save_model() fails with custom layer and SavedModel format

Have I written custom code: Yes
OS Platform and Distribution: MacOS 10.15.5, running an official Docker image
TensorFlow version (use command below): v2.2.0-rc4-8-g2b96f3662b 2.2.0
Python version: 3.6.9
CUDA/cuDNN version: N/A
GPU model and memory: N/A
Current behavior
I have defined a custom Keras layer which acts as a learnable lookup table. The layer is functional and learns throughout training. I am able to save the Keras model using both model.save('/path/to/dir') and model.save('/path/to/dir/model.h5').

However, tf.keras.models.load_model('/path/to/dir') fails whereas the H5 model seems to load properly with tf.keras.models.load_model('/path/to/dir/model.h5', custom_objects = {"Lookup": Lookup}). Passing custom_objects to the SavedModel call (without .h5) makes no difference.
You can see in the logs that the SavedModel loader doesn't know the lookup table's shape.
Describe the expected behavior
Both save/load implementations should work.
Standalone code to reproduce the issue
import tensorflow as tf

class Lookup(tf.keras.layers.Layer):
    def __init__(self, depth: int = 3, **kwargs):
        super().__init__(**kwargs)

        self.depth = depth
        self.texture = None

    def build(self, input_shape):
        lookup_shape = input_shape[1:-1] + [self.depth]

        self.lookup_table = self.add_weight('lookup_table', lookup_shape, 'float32',
                                       initializer='random_normal',
                                       trainable=True)
        super().build(input_shape)

    def call(self, inputs, **kwargs):
        entries = tf.gather_nd(params=self.lookup_table,
                                      indices=inputs,
                                      name='lookup_call')

        return entries

    def get_config(self):
        config = super().get_config()
        config.update({"depth": self.depth})
        return config

custom_objects = {"Lookup": Lookup}

lookup = Lookup()

x = tf.keras.Input(shape=(2,2), dtype='int32')
y = lookup(x)
model = tf.keras.Model(x, y)
model.compile()

model.save('/tmp/lookup_test')
loaded_model = tf.keras.models.load_model('/tmp/lookup_test', custom_objects=custom_objects)

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
WARNING:tensorflow:From /usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/resource_variable_ops.py:1817: calling BaseResourceVariable.__init__ (from tensorflow.python.ops.resource_variable_ops) with constraint is deprecated and will be removed in a future version.
Instructions for updating:
If using Keras pass *_constraint arguments to layers.
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
In  [1]:
Line 40:    loaded_model = tf.keras.models.load_model('/tf/external/model/lookup_test', custom_objects=custom_objects)

File /usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/saving/save.py, in load_model:
Line 190:   return saved_model_load.load(filepath, compile)

File /usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/saving/saved_model/load.py, in load:
Line 116:   model = tf_load.load_internal(path, loader_cls=KerasObjectLoader)

File /usr/local/lib/python3.6/dist-packages/tensorflow/python/saved_model/load.py, in load_internal:
Line 604:   export_dir)

File /usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/saving/saved_model/load.py, in __init__:
Line 188:   super(KerasObjectLoader, self).__init__(*args, **kwargs)

File /usr/local/lib/python3.6/dist-packages/tensorflow/python/saved_model/load.py, in __init__:
Line 116:   meta_graph.graph_def.library))

File /usr/local/lib/python3.6/dist-packages/tensorflow/python/saved_model/function_deserialization.py, in load_function_def_library:
Line 311:   func_graph = function_def_lib.function_def_to_graph(copy)

File /usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/function_def_to_graph.py, in function_def_to_graph:
Line 63:    importer.import_graph_def_for_function(graph_def, name="")

File /usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/importer.py, in import_graph_def_for_function:
Line 412:   graph_def, validate_colocation_constraints=False, name=name)

File /usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/importer.py, in _import_graph_def_internal:
Line 501:   raise ValueError(str(e))

ValueError: indices.shape[-1] must be <= params.rank, but saw indices shape: [?,2,2] and params shape: [] for '{{node lookup/lookup_call}} = ResourceGatherNd[Tindices=DT_INT32, _output_shapes=[[?,2]], dtype=DT_FLOAT](lookup_lookup_call_resource:0, inputs:0)' with input shapes: [], [?,2,2].
---------------------------------------------------------------------------

@d-miketa
I ran the above shared code, please let us know if it confirms your issue in this gist

Thanks for sharing the Colab, that's the exact error I'm seeing at my end.

@d-miketa
Please refer to below links and let us know if it helps.
link link1

No, those don't (directly) apply to my issue, which arises when loading the model. It works perfectly fine before the save/load cycle.

@d-miketa Looks like this was resolved in recent tf-nightly. Here a gist for your reference.
Please verify once and close the issue if this was resolved for you. Thanks!

@d-miketa Looks like this was resolved in recent tf-nightly. Here a gist for your reference.
Please verify once and close the issue if this was resolved for you. Thanks!

Yes, it works! Wonderful, thank you – I'll just wait for 2.3 then. :)

Can this issue be reopened?
With TF 2.6 I'm experiencing exactly the same problem.
Thie issue can be reproduced with the code of the first post.
Also with tf-nightly the issue is still there.
ValueError: indices.shape[-1] must be <= params.rank, but saw indices shape: [?,2,2] and params shape: [] for '{{node lookup/lookup_call}} = ResourceGatherNd[Tindices=DT_INT32, _output_shapes=[[?,2]], dtype=DT_FLOAT](lookup_lookup_call_resource:0, inputs:0)' with input shapes: [], [?,2,2].


Opens Chrome browser on Android in-case there is any redirection from main URL

Android Application has been build with Cordova v5.4.0 and Hosted-WebApp plugin v0.3.1.
First the Application is hitting a to a URL and all the plugins are working there. But incase we are doing any redirection to a page, rather than doing the redirection in the same Android app instance it is opening Chrome browser and opening the application there with the NEW URL.
Our expected behaviours are.
Our Web Application is hosted in mutliple URL. We can redirect from one URL to another URL based on business logic. All the cordova plugins should work evenIf we are playing with multiple URL in run time. Chrome browser should not get open due to URL redirection.
{
"name": "FSO MOBILE APP",
"short_name": "Fsomobile",
"mjs_cordova": {
"plugin_mode": "client"
},
"mjs_import_scripts": [
{ "src": "css/bootstrap.min.css" },
{ "src": "css/style.css" },
{ "src": "js/supportedLibrary/jquery.min.js" },
{ "src": "js/examples/audio-sample-source.js" },
{ "src": "js/examples/video-sample-source.js" },
{ "src": "js/examples/camera-sample-source.js" },
{ "src": "js/examples/barcode-sample-source.js" },
{ "src": "js/examples/common-sample-source.js" },
{ "src": "js/examples/geolocation-sample-source.js" },
{ "src": "js/examples/image-location-sample-source.js" },
{ "src": "js/supportedLibrary/angular.min.js" },
{ "src": "lib/html5.mobile.library.js" },
{ "src": "js/controller/mainAppController.js" }
],
"mjs_api_access": [
{ "match": "*" }
],
"start_url":"http://example.com/FSO2",
"scope":"http://example.com/FSO2"
"mjs_extended_scope":["https://rnam.otherdomain.net","https://login2.officedomain.net"]
}

This seems like an issue with the scope.  Can you try adding the scopoe to just be "*", this isn't good practice, but it will set the scope to all URLs, and if it still pops out into the browser, then you know it is being done with JS on the page (like a window.open or taget="blank"  etc)


[Feature Request]: i want to add solution of "Two Repeated Elements" Problem

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
User can use solution of "Two Repeated Elements" Problem for understand problem very closly
Use Case
User can use solution of "Two Repeated Elements" Problem for understand problem very closly
Benefits
User can use solution of "Two Repeated Elements" Problem for understand problem very closly
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

hey @Ajay-Dhangar , please assign this issue to me as GSSOC'24 contributor . i have already made it.


Migrate to dep 0.5.0

Per https://golang.github.io/dep/blog/2018/07/25/announce-v0.5.0.html
the format of gopkg.lock file changed a bit.
The changes are performance related: (digest per dependency,
instea of a single global one)

If we land this, what happens to people who haven't upgraded dep? What do they see?

running dep ensure on 0.4.1 succeeds, It just "downgrades" the Gopkg.lock file to the old version (basically before this PR)

Superseded by #14


sequence length is longer than the specified maximum sequence length

I try to 13B model.
When fine-tuning , the following messages happens sometime.
Token indices sequence length is longer than the specified maximum sequence length for this model (762 > 512). Running this sequence through the model will result in indexing errors
Serious error, or negligible ?

Just a warnning.https://github.com/huggingface/transformers/issues/1791


Backport removal of ember-metal/symbol

Bleh, tests are failing due to Canary issues. I'm going to update the Travis config to target 2.8 since that is what v0.3 is supposed to be compatible with.

Okay, everything is green now. @rwjblue / @dgeb when you get a chance, a merge + release would be appreciated. This is needed for anyone hoping to use 0.3 with Glimmer.

Thanks @trentmwillis! Published in v0.3.1.


test(collapse): update test case

Checklist
List of tasks you have already done and plan to do.

[x] Fix linting errors
[x] Tests have been added / updated (or snapshots)

Change information
Updated test case for ui component Collapse

有未解决的冲突，尽量先同步一下 dev 分支的代码。提交记录能干净一些


Update pypi to include MediaCling

Version 0.0.5 that is currently on pypi does not include the MediaCling class. This means you cannot follow the read me instructions on github using pip install dj-static and get the results shown. Instead you get:
ImportError: cannot import name MediaCling

Just a friendly reminder to update pypi. It looks like hundreds of people download this project from pypi each day.
https://pypi.python.org/pypi/dj-static/0.0.5
The workaround is to install from github directly.
pip install -e git+git://github.com/kennethreitz/dj-static.git#egg=dj-static

This can be closed.


Detect Offline

My heat pump occasionally goes offline due to an issue with the breaker (which i'm working on). The Kumo Cloud app knows when the device is offline, but it still appears active and controllable in my HomeKit app. Is there anyway for the bridge to detect and report when the device is offline?

That sounds like a great idea. I'll take a look and see if I can find a way to detect a non-responsive device and report it to HomeKit in a sensible way.


enh: mark taos-ws-py optional by extra feature 'ws'

Example:
pip install taospy     # without taosws module
pip install taospy[ws] # with taosws module

Codecov Report

Merging #125 (c3bc0db) into main (ba0d3e6) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   76.42%   76.51%   +0.08%
==========================================
  Files          19       19
  Lines        2316     2316
==========================================
+ Hits         1770     1772       +2
+ Misses        546      544       -2

Impacted Files
Coverage Δ

taos/cinterface.py
73.44% <0.00%> (+0.13%)
:arrow_up:

taos/result.py
72.82% <0.00%> (+0.54%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Remove dependency on headjs

Headjs does not seem to be necessary, and does not seem to be getting updates anymore.
It would be nice to remove the dependency and implement a native solution instead.

Closed with update 1.0.2


Voice/Video calling

It might be out of scope for this project, but if possible I think it'd be a very appreciated addition.

I'm hoping (and dreaming!) that Element call will eventually be able to work as a standalone app or possibly as an SDK https://github.com/vector-im/element-call
I can imagine SmallTalk being able to notify of incoming calls but delegate out to a dedicated voice/video app


add access point to invoices for one-time donations

Thank you for taking the time to report an issue 🙏
The easier it is for us to reproduce it, the faster we can solve it.
So please try to be as complete as possible when filing your issue.

URL:
Logged in as: (just provide your username or the url of your profile)
Error message if any:
Expected result:
Browser:
Bonus point if you can add a screenshot :-)
Thank you and have a wonderful day/evening!
(and sorry for inconvenience! We'll do our best to solve this ASAP)

you can do this from /transactions


Run PHPUnit for PHP 5.6 with ParaTest

No go for now as the bug failing Travis has fix only for PHP 7.


500 on metadata query

Standard request to MDQ for all entities resulted in:
I, [2016-09-01T04:48:11.364484 #29794]  INFO -- : Completed 500 Internal Server Error in 1177ms (Models: 985.3ms)
F, [2016-09-01T04:48:11.365390 #29794] FATAL -- :
NoMethodError (undefined method `uri' for nil:NilClass):
  app/models/known_entity.rb:46:in `entity_id'
  lib/metadata/saml.rb:90:in `each'
  lib/metadata/saml.rb:90:in `group_by'
  lib/metadata/saml.rb:90:in `group_by_eid'
  lib/metadata/saml.rb:84:in `filter_known_entities'
  lib/metadata/saml.rb:63:in `block (2 levels) in entities_descriptor'
  lib/metadata/saml.rb:59:in `block in entities_descriptor'
  lib/metadata/saml.rb:54:in `entities_descriptor'
  app/controllers/concerns/metadata_query_caching.rb:59:in `block in cache_known_entities_response'
  app/controllers/concerns/metadata_query_caching.rb:58:in `cache_known_entities_response'
  app/controllers/metadata_query_controller.rb:121:in `create_known_entities_response'
  app/controllers/metadata_query_controller.rb:55:in `block in handle_entities_request'
  app/controllers/metadata_query_controller.rb:46:in `handle_entities_request'
  app/controllers/metadata_query_controller.rb:20:in `all_entities'

Which seems to indicate the associated EntityID has no URI value which is not a state that should ever exist.
FR pull was running at the time.

I have tracked this back to here https://github.com/ausaccessfed/saml-service/blob/develop/app/jobs/concerns/etl/entity_descriptors.rb#L42
Upstream FR provided an EntityID that wasn't URI compliant, in this case the value BXGOTY3T was used for entityID URI (https://manager.test.aaf.edu.au/federationregistry/membership/serviceprovider/show/4965 and https://manager.test.aaf.edu.au/federationregistry/membership/entitydescriptor/show/4964). Data was modified by AAF support due to upstream client support outside of normal protections hence the flow on.
Regardless SS should not break on this case. Review import logic to ensure that invalid data at any layer spits the entire EntityID.

Closed by https://github.com/ausaccessfed/saml-service/issues/132


panic: shouldn't be possible unable to deduce repository and source type for: "golang.org/x/sys/unix"

 $ dep ensure -update
panic: shouldn't be possible unable to deduce repository and source type for: "golang.org/x/sys/unix"

goroutine 1 [running]:
github.com/golang/dep/internal/gps.(*solver).selectRoot(0xc0421a4000, 0xc0420f5500, 0x1b)
        E:/gocode/src/github.com/golang/dep/internal/gps/solver.go:502 +0xb18
github.com/golang/dep/internal/gps.(*solver).Solve(0xc0421a4000, 0x12, 0xa71d00, 0xabf608, 0xc0420fbf6e)
        E:/gocode/src/github.com/golang/dep/internal/gps/solver.go:348 +0x8e
main.(*ensureCommand).Run(0xc0421484a0, 0xc04210bb40, 0xc04204e3b0, 0x0, 0x0, 0x0, 0x0)
        E:/gocode/src/github.com/golang/dep/cmd/dep/ensure.go:148 +0x389
main.(*Config).Run(0xc04200b320, 0xc04200b320)
        E:/gocode/src/github.com/golang/dep/cmd/dep/main.go:159 +0x8ba
main.main()
        E:/gocode/src/github.com/golang/dep/cmd/dep/main.go:44 +0x25a

sm.DeduceProjectRoot: unable to deduce repository and source type for: "golang.org/x/crypto/acme/autocert"

The ultimate reason for the error is detailed in #292, but it's not great that there's a panic case that can be triggered by this. Let's treat this issue as being about covering that panic.

Any specific error message instead of the panic?

Looking at the source line, I see it's preceded by a note from me:
// TODO(sdboyer) this could well happen; handle it with a more graceful error

So yeah 😄  Problem is, at that specific point, there are a number of things that could cause the error. Still, for now, the best thing to do is probably just return the error out directly.

Should be handled somewhere else? Otherwise, dep will be print the error this error anyway:
ensure Solve(): unable to deduce repository and source type for: "golang.org/x/sys/unix"

#561 Seems like an improvement to the errors that are returned:
panic: shouldn't be possible unable to deduce repository and source type for "golang.org/x/sys/unix": unable to determine remote metadata protocol: failed to access url "http://golang.org/x/sys/unix?go-get=1"

Yes, #561 would improve the message - but it absolutely does have to return out the error, as it's not possible to continue solving if this occurs.
It could be handled earlier, e.g. in Prepare(). We'd have to iterate through each of the imports in the project, attempt deduction, and collect a slice of failures. That work should be parallelized. Kind of akin to what we do in init, but with a waitgroup and using DeduceProjectRoot() instead of SyncSourceFor().

Prepare() doesn't have access to the logger ctx.Loggers.Err unless the verbose mode is toggled. Any pointers on what could be done in that case?
BTW, I noticed that Prepare() is called twice in Run() (in init.go). I'm not sure if this intentional or not.

Right, we never print anything directly from within gps. There's only one single solitary exception to that rule, and it needs to be gotten rid of, too 😄  apart from the fs funcs you're working on in the other PR, gps should be considered self-contained, and import only things at or below its level in the project.
Instead, follow the pattern that's in that function - return a badOptsFailure with an appropriate message. It's not great, but it's consistent, and good enough for now.

BTW, I noticed that Prepare() is called twice in Run() (in init.go). I'm not sure if this intentional or not.

It is - the comments say a bit about it. It's run the second time in order to get the modified input hash for the Gopkg.lock memo field.

@sdboyer Somehow this issue is not reproducible using dep v0.1.0-88-gce194b4fb9f3.
I'm getting the following error instead of a panic: ensure Solve(): unable to deduce repository and source type for "golang.org/x/sys": unable to read metadata: unable to fetch raw metadata: failed HTTP request to URL "http://golang.org/x/sys?go-get=1": Get http://golang.org/x/sys?go-get=1: dial tcp <IP_ADDRESS>:80: getsockopt: connection refused
@bsed Could you update dep and check now?


doc: replace vscode debug method from attach to launch

a launch debug task can be created in vscode, which runs the godot game directly wiht lldb debugger.

Thanks for figuring this out, and for contributing this!  I think this is going to help people a lot, especially debugging on Windows.
That said, I don’t think we want to replace the documentation for attaching to a running game, as I think it is still a useful/common workflow for people to launch the game from Godot.
Do you think you could modify your patch so that it maintains the attach documentation, possibly as an additional (or optional) task to include after the launch task?

Do you think you could modify your patch so that it maintains the attach documentation, possibly as an additional (or optional) task to include after the launch task?

of course. done!!, and attach is indeed a very helpful method to debug individual scenes .


Incorrect parsing of language server request headers

Godot version:
3.2.beta
OS/device including version:
archlinux x86_64
Issue description:
Starting a message to the language server websocket with "Content-Length:" makes the server ignore the message.  This header is required by the the current lsp specification(3.14) and so it seems very odd to ignore it.  I believe this may be a shortcut taken to make it easier for the only current client implementation (the one for vscode) to communicate, but because it does not comply to the specification it is very confusing for a developer who is attempting to implement another client (I am currently trying to write one in emacs for lsp-mode, which sends headers the correct way).
Steps to reproduce:
Send a message to the language server (using a tool like websocat) starting with a "Content-Length: " header.  There will be no output.

If you can seperate the header and body to two messages it should be fine. But it is not really follow the LSP specification.
https://github.com/godotengine/godot/blob/5fa1905131bc20e8a4a939d0edf8370091c88a50/modules/gdscript/language_server/gdscript_language_protocol.cpp#L44-L46

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?

This is fixed since 3.2.2 where LSP has been ported to plain TCP instead of websocket: #35864


Greenkeeper/rollup 2.1.0

closes #151

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Copy / Paste of cells in new notebook editor links them

Pretty sure this is not intentional. When I copy a cell and then paste it, the two cells are then linked. They have the same execution count and typing in one also edits the other. So I can't copy a cell and then edit the copy with some changes. It's also causing some strange hover issues.

I'm not able to repro this. I'll move it to validate and @IanMatthewHuff please check if you can repro it again. I think it might already be fixed.

I'm not able to repro this. I'll move it to validate and @IanMatthewHuff please check if you can repro it again. I think it might already be fixed.

Validated

Validated


The previous stable versions, 2.2 and 2.3 (not in nixpkgs), still used Python 2 and wxGTK 2.
IIUC the first release to use Python 3 is tagged WikidPad-2-4-alpha01.
The setup.py (as far as I can tell) doesn't do standard things like making a wheel,
or running the test infrastructure, so I just copy the source to $out and a wrapper to $out/bin.
With respect to packaging, the following things are done:

wrapGAppsHook because it's a GTK app.
WikidPad has it's own sqlite.so wrapper, so we add sqlite to LD_LIBRARY_PATH

As far as I can tell, it's not useful to try using the standard Python infrastructure here;
The python infrastructure documentation says the following:
The buildPythonPackage mainly does four things:
- In the buildPhase, it calls ${python.interpreter} setup.py bdist_wheel to build a wheel binary zipfile.
- In the installPhase, it installs the wheel file using pip install *.whl.
- In the postFixup phase, the wrapPythonPrograms bash function is called to wrap all programs in the $out/bin/* directory to include $PATH environment variable and add dependent libraries to script's sys.path.
- In the installCheck phase, ${python.interpreter} setup.py test is ran.

I don't know my way around setuptools, but AFAICT from looking at setup.py --help,
the setup.py cannot build a wheel, doesn't have an install phase, and isn't set up to run pytest.
It would be nice if someone can confirm this for me.

Apparently I just have no idea how setuptools works.
I'm going to try rewriting this to use buildPythonApplication.


Thoughts on using a macro to save time defining actions.

For my work with kemalyst I've been using a macro that allows me to define actions in a way that looks a bit simpler and reminds me more of rails.
macro action(name, &content)
  class {{name}} < Kemalyst::Controller
    def call(context)
      {{content.body}}
    end
  end
end

this allows me to write controllers that look like this:
require "../models/post"

module PostController
  action Index do
    posts = Post.all
    render "post/index.slang", "main.slang"
  end

  action Show do
    id = context.params["id"]
    if post = Post.find id
      render "post/show.slang", "main.slang"
    else
      context.flash["warning"] = "Post with ID #{id} Not Found"
      redirect "/posts"
    end
  end

  action New do
    post = Post.new
    render "post/new.slang", "main.slang"
  end

  action Create do
    post = Post.new
    value = context.params.fetch("name", nil)
    post.name = value if value
    value = context.params.fetch("description", nil)
    post.description = value if value

    if post.valid? && post.save
      context.flash["success"] = "Created Post successfully."
      redirect "/posts"
    else
      context.flash["danger"] = "Could not create Post!"
      render "post/new.slang", "main.slang"
    end
  end

  action Edit do
    id = context.params["id"]
    if post = Post.find id
      render "post/edit.slang", "main.slang"
    else
      context.flash["warning"] = "Post with ID #{id} Not Found"
      redirect "/posts"
    end
  end

  action Update do
    id = context.params["id"]
    if post = Post.find id
      if value = context.params.fetch("name", nil)
        post.name = value
      end
      if value = context.params.fetch("description", nil)
        post.description = value
      end

      if post.valid? && post.save
        context.flash["success"] = "Updated Post successfully."
        redirect "/posts"
      else
        context.flash["danger"] = "Could not update Post!"
        render "post/edit.slang", "main.slang"
      end
    else
      context.flash["warning"] = "Post with ID #{id} Not Found"
      redirect "/posts"
    end
  end

  action Delete do
    id = context.params["id"]
    if post = Post.find id
      post.destroy
    else
      context.flash["warning"] = "Post with ID #{id} Not Found"
    end
    redirect "/posts"
  end
end

Is there a good reason not to merge something like this into the project?

This is awesome!

Do you have any opinion on where this should be added? It works fine to put it at the bottom of controller.cr. Namespacing it is potentially a good idea so that action doesn't become a reserved keyword but having to type YourNameSpace.action sort of defeats the purpose.
This could be a good solution.
#bottom of controller.cr
module MagicController
  macro action(name, &content)
    class {{name}} < Kemalyst::Controller
      def call(context)
        {{content.body}}
      end
    end
  end
end

#posts controller
require "../models/post"

module PostController
  include MagicController

  action Index do
    posts = Post.all
    render "post/index.slang", "main.slang"
  end

  action Show do
    id = context.params["id"]
    if post = Post.find id
      render "post/show.slang", "main.slang"
    else
      context.flash["warning"] = "Post with ID #{id} Not Found"
      redirect "/posts"
    end
  end

Yes, bottom of controller sounds like a good spot.  Not sure about the name MagicController.  ActionHelper?

Yeah that was just a place holder name to get your thoughts on including a module to get the macro in the controller namespace.


Feature Request: Option to sync chat details and photo when opening app

had discussion in discord regarding this - chat name always synced automatically with server (we are notified when name changes) - photos not synced because often times the latest photo is not cached in Mac attachments directory


Validate user store domain of the parent user invitation flow

Purpose

Add a validation logic to verify the provided invitation user store domain is valid or not https://github.com/wso2-extensions/identity-organization-management/pull/402/files#diff-ebba2067b3fa55047938aa6006a6864220dd3d4de3854fc2894d203714e0e926R737-R746

In this effort the following improvements are made.

[x] Fix codecov plugin and report generation issue.
[x] Remove powermock and replace tests with Mockito
[x] Oraganize the invitation core test class.

Related Issues

https://github.com/wso2/product-is/issues/21460

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11392719570

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11473150644

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11473150644
Status: success


Create clean_code.md

Clean code programming book
Hacktoberfest notes:

due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
please read our contributing guidelines
be sure to check the output of Travis-CI for linter errors
if this is your first open source contribution, make sure it's not your last!

What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Not a duplicate
[ ] Included author(s) if appropriate
[ ] Lists are in alphabetical order
[ ] Needed indications added (PDF, access notes, under construction)

Closing this as it's the content from an actual resource, not a link to one.


improve unit test coverage in utils

Following classes need improvements in unit test coverage.

JsonSerDe
PayloadHelper
SerDe
ConfigurationService

See code coverage numbers at https://codecov.io/github/Microsoft/SparkCLR/csharp/Adapter/Microsoft.Spark.CSharp

Current coverage:

JsonSerDe   97.37%
PayloadHelper  98.26%
SerDe   100%
ConfigurationService  85%


Enable wide Unicode support for names

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
Enables almost full Unicode support for directive names. This is tricky to test, I've added only Latin, Greek and Cyrillyc characters.

[!warning]
(Decomposed) accent modifiers are not covered by tests yet. Worth to look at.

Closes #23

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7f23ba8) 100.00% compared to head (b34ad7a) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines         1416      1427   +11
=========================================
+ Hits          1416      1427   +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

You could maybe test the math symbol for pi π, and an emoji? 🌍?

Thanks for your continued work. I’ve been wondering the last week what to do about punctuation. And about the implications to the semver version of this package.
In the ASCII range we allow ascii alphanumerics and -, ., _.
I think in the rest of the unicode range we should also only allow alphanumerics.
We should be able to do that by checking classifyCharacter(x) === undefined.
I don’t see unicode “punctuation” tested much, could you see if that changes things?
Some examples of symbols/punctuation outside of the ascii range are € and £!


Add handling for soon to exist logical directions

and do a small component in example

Description

This implements Logical Directions with PostCSS
https://github.com/adobe/spectrum-css/issues/390
How and where has this been tested?

How this was tested:
Browser(s) and OS(s) this was tested with:

Screenshots

To-do list

[ ] If my change impacts other components, I have tested to make sure they don't break.
[ ] If my change impacts documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

[ ] This pull request is ready to merge.

This is awesome. So we can merge this, then go through the rest of the components in a subsequent pull request.
If we can do this to each component without making breaking changes, that would be ideal.
Then, for everything that requires a breaking change for RSP V3, we should do that separately, after this is added. That will ensure we can get RTL support out to the maximum number of products.

Btw, this will likely be a breaking change. It requires applications to have at least a top level element with the dir attribute. It generates CSS for [LTR] and [RTL] and because it might be
border-left in LTR it'd be border-right in RTL

Hmm, interesting @snowystinger. Why can't we have it dump out no dir for LTR, and [dir=rtl] for RTL? If the existing PostCSS plugin can't do that, let's contribute that capability. There is no explicit reason why this must be a breaking change, it just sounds like a limitation of the tooling.

@devongovett Did you find the place where you found this info?
As for why, my understanding is that if you have
.classname {
border-left: 3px;
}
[dir=rtl] .classname {
border-right: 3px;
}
the rtl would actually need to do something to undo border-left, but i think that's a hard problem to solve because you can't just set it to zero or initial or inherit because that might interfere with other selectors styling

Superseded by #532, which includes the commit from this PR. Thanks for blazing the trail, @snowystinger!


Create Tapachula

uptapachula.txt

@AbnerRP lib/domains/Tapachula: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@AbnerRP I close this request as a duplicate to #20531. Please answer the question in #20531.


Provide a way to just disarm/arm a specific Area

Currently the system arms/disarms the alarm in it's entirety (all Areas).  Provide a means of just targeting specific Areas.

thanks for this great integration. I just discovered.
I have included your "ultrasync_alarm.yaml" and the three buttons appear on my HA, however it seems they only show me the current status. Do I need to change something in your code in order to arm/disarm the alarm?

I'm out of town, but i will try to share my code with you for what i did when i get back.

Thanks a mill caronc! I did few changes but still is just visual. Please let me know once you are back.

I guess all is good now. Probably I messed up something in the configuration, I did few tests and they worked. Thanks again for creating this add-ons.

Glad you got it all going; i'll close the ticket off then 🚀


feat: add basic working version of no-debug rule

This PR intends to add a new rule called no-debug.
Indeed, just like console.log statements pollutes the browser's output, debug statements can also pollute the tests:
import React from 'react'
import { render } from '@testing-library/react'

const HelloWorld = () =>
Hello World

const { debug } = render(<HelloWorld />)
debug()
//

//
Hello World

//

This rule would prevent developers to push unwanted debug statements to the codebase by warning them that it has been used.

This rule would not be useful for the base package: @testing-library/dom but for '@testing-library/react' or '@testing-library/vue'.
Should we implement the shareable configurations in this PR or wait a little?

I think is better to just have this rule now not added to recommended config and in a different task we address everything related to the frameworks configs (vue and react) and add proper doc to the readme (my idea was to include a rules table similar to eslint-jest one indicating in a "framework" column if they are enabled in any framework config). Are you happy with this?
About the rule, I think you need to limit the selector for Identifiers within a CallExpresion, as just debug would trigger an error when it shouldn't, right? (with corresponding tests)
I guess you are still pending to update doc and including the rule in the index file as the PR is flagged as WIP

It looks like a good solution to me!
For the rule, it would work for a first version but there are some edge cases to consider:

What if the user is using the debug package and giving it the same name? In that case, we should throw an error for every debug call provided it comes from the render method.
But then, what if the user renames the debug variable as printDOM or log for example? Same question if the user assigns debug to a new variable:

const { debug: log }  = render(...)
// OR
const { debug }  render(...)
const printDOM = debug

What do you think?

I'm happy to release a first version of those edge cases and improve them in a second step, but if you feel it would be easy to implement and should be included on first version, let's go for it. I just want to avoid including tons of different edge cases and focus on a first release with some basic rules and see what's the feedback in general about the plugin, but as I said those edge cases would need to be addressed sooner or later.

I think the first edge case should be included in the first release as what we want to disallow is the use of debug from the render method only instead of preventing any debug calls.
I agree for the second edge case, I don't see so far why you would rename debug. I guess we'll see once the plugin is released! 🙂


Enable authorization on Windows kubelet API

Is this an ISSUE or FEATURE REQUEST? (choose one): Issue

What version of acs-engine?: all

Kubernetes added HTTPS and webhook-based authorization to the kubelet API https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet-authentication-authorization/ . This has been implemented for Linux nodes in ACS-Engine, but not Windows yet.
Linux has the right options set:
                "--anonymous-auth":              "false",
		"--authorization-mode":          "Webhook",
		"--client-ca-file":              "/etc/kubernetes/certs/ca.crt",

Fixed :)


WrapResponseMethods not working

Hi
I'm not sure if I understand the WrapResponseMethods feature correctly.
I want to wrape my repsonses. WrapResponses works but wraps all methods.
WrapResponseMethods  lets you select specific methods for wrapping, if I understood that correctly.
The documentation says use 'ControllerName.MethodName'.
What names is this refering to. The Asp Core class and method names?
Because that isn't working in my project and also doesn't make much sense I think because the code generation only uses the swagger definition file.
I probably just missunderstood something.
Thanks in advance.

Ah figured it out.
'ControllerName.MethodName' is the Angular/Typescript class/service and method name.
Perhaps add that to the documentation?


libPPUI

Have you looked at this in the new fb2k SDK? I'm currently in the process of re-writing my Properties dialog by ditching that ancient PropertyList code and replacing it with this.
A little preview:

I just need to do some testing on the conversion of text strings back to number variants etc.
It's pretty much based entirely on this from foo_sample if you want to take a look right now..
https://github.com/marc2k3/foobar2000-SDK/blob/master/foobar2000/foo_sample/listcontrol-advanced.cpp

Looks pretty neat!
I have yet to check the libPPui... But it seems that it is worth investing some time into it.

You can point and laugh at my changes here...
https://github.com/marc2k3/foo_jscript_panel/commit/dcd8ece2ba5003a949b07f72bc3fe864ed705770
The removal of old code went in a previous commit
https://github.com/marc2k3/foo_jscript_panel/commit/c3bef8fa1ff3d0955695e78feccc6de634c5690c


Aesthetic issue in officer page

Describe the bug
See screenshot
Website Page URL
https://thewhitehat.club/officers
To Reproduce
Steps to reproduce the behavior:

Go to https://thewhitehat.club/officers
Notice the placement of the bottom officer pictures

Expected behavior
Officer pictures should remain above the footer bar despite screen size
Screenshots

Desktop (please complete the following information):

Hardware: Macbook Pro 2016, 15'
OS: MacOS 10.13.6
Browser Firefox 65.0

The size it's breaking at is 936x615 for the officer-container div, TODO: fix presumably vertical scaling of internal contents

Unsubscribe
On Sat, Feb 16, 2019 at 1:27 PM Jon Prentice<EMAIL_ADDRESS>wrote:

The size it's breaking at is 936x615 for the officer-container div,
TODO: fix presumably vertical scaling of internal contents
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/WhiteHatCP/thewhitehat.club/issues/21#issuecomment-464387385,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAzNn7jVupqT8U2UImNdSoFb-00QHx36ks5vOHergaJpZM4a-iP4
.

Added scrolling to accommodate a larger number of officers in #a7cbde0 so this bug is no longer noticable, but probably still exists.

Closing due to partial fix


Figure out absolute time and local time set up

Currently in https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-data-utils/blob/5b447aef865d1c8634ecfb245deef196c6bdfb18/src/aind_dynamic_foraging_data_utils/nwb_utils.py
We define absolute time by using a t0, but this is defined across 5 instances in nwb_utils
This should at the very least be a global variable so things don't get misaligned.
The absolute time is already defined in the NWB.
Local time is also defined, but we need more documentation on them in the nwb_utils
For example: reward_outcome_time is defined in the pipeline (https://codeocean.allenneuraldynamics.org/capsule/9216710/tree) stating that it's f"The reward outcome time (reward/no reward/no response)",, but it's unclear in nwb_utils.

duplicate. closed with https://github.com/AllenNeuralDynamics/aind-dynamic-foraging-data-utils/pull/50


Update Sample Link to use Teams PnP SSO Sample

The sample that is linked to is Node.js only, and it also uses ADAL, so the new Teams PnP Sample might be useful to link to instead. It includes a Node.js as well as a .NET version, and uses MSAL 2.0 instead. See https://github.com/pnp/teams-dev-samples/tree/master/samples/tab-sso

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52221dd3-95ec-96b9-1da8-9478527c2602
Version Independent ID: 32e9c2d8-733d-0865-2ea3-727d8684a10d
Content: Single sign-on support for tabs - Teams
Content Source: msteams-platform/tabs/how-to/authentication/auth-aad-sso.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

@laujan @KirtiPereira , Could you please help to add this link to sample code section of the Tab SSO documentation:
Link need to be added: https://github.com/pnp/teams-dev-samples/tree/master/samples/tab-sso


Add cloud mode

Include a cloud mode to a new test of MusicBox with conditions specified here: https://drive.google.com/drive/folders/1pFejiHbUIdQjs7DQeAa30m1U4wNluhjc
Initial conditions should be specified in the MusicBox configuration and remain constant during the simulation.

Need one phase and one bin, based off of this


[question]该扩展是否支持codeigniter 3

This PHPStan extension would only be available for CodeIgniter 4 and above.

Thank you for your answer


Intellisense is not working when I type . in settings files

VSCode Version: 1.4 insiders (6ef86d5f85a531caa59bfb1715469fcfaa8d2efd)
OS Version:OSX

Steps to Reproduce:

Open settings
Type git
You see suggestions - Good
Type .
Bug: Suggestions go away

Expected: Suggestions remain

Regression from my change to the JSON word rule.


[Suggestion] change the mod name

change the mod name to TitleFix For SwitchWorld
If you can or cannot, please just reply and close the issue

star this repo it


chore(main): release 1.2.0

:robot: I have created a release beep boop
1.2.0 (2024-07-08)
Features

refactor dir getter (4bd725c)

Bug Fixes

add prettier-package (9cb65e2)
unit test add after-all (80f2e29)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.2.0
:sunflower:


Add release badge to README

Purpose of this PR

Add a release badge to the README
Remove codecov.yaml since this isn't being run as part of CI

Change Category
Indicate the type of change by marking the applicable boxes:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that could affect existing functionality)
[X] Documentation update

Checklist
Before submitting your PR, please review the following:

[ ] I have conducted a self-review of my own code.
[X] I have updated documentation accordingly.
[ ] I have added tests that prove my changes are effective or that my feature works.
[ ] Existing unit tests pass locally with my changes.

/assign @ChenYi015 @ImpSy


How to decode UTF-8 chars in response?

We have a Cyrillic (Mongolian) texts returned from GraphQL API.
But Cyrillic texts are obscured. Something like this.

We write a custom UTF-8 converter.
static String utf8convert(String text) {
    List<int> bytes = text.toString().codeUnits;
    return utf8.decode(bytes);
}

And the result is here

Might be related #94

@endigo which version of the client are you using?

@HofmannZ I'm using 1.0.0-alpha6.

@endigo Which Content-Type is your endpoint returning? Should be: Content-Type: 'application/json; charset=utf-8', so that the http client can decode utf8.

in the server's response header?

@endigo Yes, in the server's response header.

Fixed with 1.0.0-alpha.8

Hi guys,
Does the issue is fixed or just me still get this problem :(
My package version: 1.0.0-alpha.9

@endigo thank u so much :3 <3


Redirect vertical scrolling as horizontal scrolling when holding shift

Because macOS is apparently a magical place where this is done at the OS level I implemented this feature in druid-shell for both GTK and Windows. The Windows patch is very straightforward but GTK has two codepaths for scroll events. The "smooth" scroll path receives data for both axis at once so I wrote it such that when shift is held the two axis are capable of fighting each other as that made the most sense as well as is consistent with the other codepath and Windows patch.
My understanding is that the shift key does not affect trackpad scrolling on macOS but that was not feasible to emulate here. On GTK the "smooth" events are not only used for scrolling but can in some cases be used for mousewheel input (I observed this firsthand on my laptop) and with Windows there only seems to be a single source of scroll data regardless of if it originated from a mousewheel or trackpad.

I will need some input on this; I'm really not sure what the conventions are on these platforms. In principal this sounds good to me.

I'm currently wrangling some git stuff on this, turns out I made a silly mistake so hold off on reviewing just yet

This is not a platform behavior on Windows. Holding shift while scrolling has no effect.
That said some applications do implement this on Windows, including some big ones like Adobe Reader, Chrome, Firefox. Amusingly in Internet Explorer shift+scroll cycles through the back button history.
I guess I'm fine with this being a druid feature on Windows. It doesn't conflict with any platform behavior really and can be useful.

That is really surprising to me, even when I used to use Windows this feature was so widespread that I never thought about it being a platform convention or not. I do remember FF having that history scrolling feature for the longest time which bugged me endlessly back in the day :laughing:
I may be biased but I think that this is a reasonable thing to expect to work regardless of the platform

Does this also apply to trackpad gestures? Is that even a relevant question? Basically: this makes sense to me for the scroll wheel, I think it's a reasonable default there, and if an application wants to get fancy they still have the opportunity. I think it's weirder for trackpad gestures.

Yes these changes should affect scrolling with a trackpad when holding shift in the GTK shell and Windows. Neither platforms seem to offer a way to differentiate between trackpad and mousewheel scroll events. It would be great if a Windows user with a trackpad can verify that WM_MOUSEWHEEL does indeed get fired when scrolling with a trackpad which would mean that this change 100% does affect the trackpad as well on Windows.

maybe ask on zulip?

That's a good idea, I forget that not everyone watches the repo and has a notification queue a mile long :sweat_smile:

This is simple both conceptually and in diff size and I would like to have it hang out in master for a while before 0.5 drops which is rapidly approaching. Any changes before a final review?

I played around with this and can confirm that:

This works on Windows.
The WM_MOUSEWHEEL event gets fired with a trackpad.

Awesome, thanks! Now I suppose someone on Linux also needs to confirm

@xStrom if you're happy to +1 this I won't block on testing with gtk.

I tested the scroll_colors example and can confirm that this works on Linux as well.


remove limits and add topology spread

Description
Removes the resource limit on the nginx ingress controller. This allows for app routing to work on clusters with many cpus. NGINX automatically scales worker processes based on node cpus.
We also change the HPA to scale slightly more aggressively. This should lower the amount of CPU used by a single nginx ingress controller replica which means that the actual usage should be more in-line with the Resource Requests (which is good because it's guaranteed).
Pod topology spread ensures nginx ingress controller scheduled on different nodes when possible. Helps avoid single Node failure taking down the Ingress.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
e2e and unit
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

/ok-to-test sha=5adce59

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 12 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 89.023%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
2068

Relevant Lines:
2323

💛  - Coveralls


Instantiate mutation type when executing it

potential fix for #126
Instantiate mutation type when executing it, first via serviceProvider then fallback to Activator.createInstance
also allow registering all mutations from multiple types that match a generic parameter (eg marker interface)

second change in this PR that makes GraphQLMutationAttribute optional (controversial change?) will take any public method, static or instance that is declared directly on the type (not inherited).

new commit

Add mutationClassInstance parameter back in to not break API - also allows user to pass in the mutation class instance if they prefer doing it that way
added new parameter addNonAttributedMethods which defaults to false to allow methods not marked as mutations to be added but not by default
reverted some tests to use old api to prove it still works and reduce amount of change


Problem with RxDart

So, because at_ciudadana_app depends on flutter_plugin_pdf_viewer ^1.0.7, version solving failed.
pub get failed (1; So, because at_ciudadana_app depends on flutter_plugin_pdf_viewer ^1.0.7, version solving failed.)
exit code 1
i need use  ^0.24.1 in my project

I have the same problem.

and for me: Because flutter_plugin_pdf_viewer >=1.0.4 depends on rxdart ^0.21.0 and flutter_cache_manager 1.4.1 depends on rxdart >=0.23.1 <0.25.0, flutter_plugin_pdf_viewer >=1.0.4 is incompatible with flutter_cache_manager 1.4.1.

Is this package still supported?


ASP.NET Core Identity Provider Support

My question would be similar to #10 , support authentication with ASP.NET Core Identity

Feel free to open a PR to support this if it's a OAuth provider.


Fix | Kudadam.com repository links

Replaces repository links for Kudadam.com to the correct ones.

Thanks, good catch!


cli/verifier: add stubs for egress checks

Description:
Adds the stubs necessary to perform egress
config verification on a pod.
A subsequent change will add additional
validations that perform the actual checks.
Part of #4634

Testing done:
$ osm verify connectivity --from-pod curl/curl-7bb5845476-5b7wr --to-pod httpbin/httpbin-69dc7d545c-hbc6d --service httpbin
---------------------------------------------
[+] Context: Verify if pod "curl/curl-7bb5845476-5b7wr" can access pod "httpbin/httpbin-69dc7d545c-hbc6d" for service "httpbin/httpbin"
Status: Success

---------------------------------------------

$ osm verify connectivity --from-pod curl/curl-7bb5845476-5b7wr --service httpbin
Error: one of --to-pod|--egress must be set for connectivity verification

$ osm verify connectivity --from-pod curl/curl-7bb5845476-5b7wr --to-pod httpbin/httpbin-69dc7d545c-hbc6d --service httpbin --egress
Error: --to-pod cannot be set with --egress

Affected area:

Functional Area

CLI Tool
[X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Did you notify the maintainers and provide attribution?

Is this a breaking change? no

Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? n/a

@keithmattix I would imagine doing something similar for ingress would allow code reusability for a lot of heavy lifting done in envoy_config.go.

@shashankram I'm doing something very similar for ingress. The cli flags needed were different enough that I made it a separate command, but the approach looks largely the same as yours

@shashankram I'm doing something very similar for ingress. The cli flags needed were different enough that I made it a separate command, but the approach looks largely the same as yours

Yes, go ahead. We can refactor the commands as necessary later on. I think initially I wanted to have separate commands, but per PR feedback there was a proposal to allow various permutations within the same command, see this for reference.


Add helpful information to the SETUP.md

The contents of the SETUP.md file gets included in
the README.md that gets delivered when a user runs the exercism fetch
command from their terminal.
At the very minimum, it should contain a link to the relevant
language-specific documentation on
help.exercism.io.
It would also be useful to explain in a generic way how to run the tests.
Remember that this file will be included with all the problems, so it gets
confusing if we refer to specific problems or files.
Some languages have very particular needs in terms of the solution: nested
directories, specific files, etc. If this is the case here, then it would be
useful to explain what is expected.

Thanks, @tejasbubane for suggesting that we add this documentation everywhere.
See exercism.io#2198.

Added in https://github.com/exercism/xperl6/pull/48


Simplify PatternSpec caching

Instead of one global cache that all patterns share,
there is now one cache per pattern. This removes the need
for an extra cache key object and also makes each cache
smaller. Together this reduces memory usage and speeds up
lookups.

I ended up with this after trying to remove the caching completely, as it adds quite a bit of memory usage. There is only once scenario (nativeMonolithicOverlapping) where caching seems to be faster than just running the specs again.

I looked deeper at that nativeMonolithic project and I think the only reason it benefits from that cache so much is that all the source files in each project have the same name. I.e. there is  project1/src1.cpp, project2/src1.cpp, ... So there are only ~200 relative paths in that project even though it has 20K files. That means we might be measuring an unrealistic speedup with that cache in that project.

We always have lots of exclude patters (all the default ANT excludes) and for Java we have **/*.java. So the native examples are definitely not the only ones.

@oehme IIUC, we removed the **/*.java include for the Java compile task. The default exclude patters are in place.

The Java include is here.


⚠ Bofrost.be has degraded performance

In 274d228, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2537 ms

Resolved: Bofrost.be performance has improved in 164e679 after 1 hour, 21 minutes.


style: using gofmt to format your code

It is weird to see
import (
    `io/ioutil`
    `testing`

    `github.com/stretchr/testify/require`
)

where use ``   instead of ""
if we want others to participate in, we should follow some basic go-style code style
just use gofmt -w . in /sonic  to format all *.go files, please

Can you explain how a different code style might prevent others from participating in this project?

Can you explain how a different code style might prevent others from participating in this project?

check this: https://github.com/bytedance/sonic/blob/main/CONTRIBUTING.md#contribution-prerequisites, please.

You need fully checking with lint tools before submit your pull request. gofmt & golangci-lint

If you don't follow the contribution rules yourself, why should others follow?
and in google code review comments: https://github.com/golang/go/wiki/CodeReviewComments#gofmt:

Gofmt
Run gofmt on your code to automatically fix the majority of mechanical style issues. Almost all Go code in the wild uses gofmt. The rest of this document addresses non-mechanical style points.
An alternative is to use goimports, a superset of gofmt which additionally adds (and removes) import lines as necessary.

I think at least you guys represent bytedance, right? Isn't the company code specification mandatory to use gofmt?
If we mr, it will be a disaster to see that all files are modified, because of our using of gofmt

hello @wymli , I've opened a pr for this #37 and find out that the code after format is less prettier than the code before format.
I learned that the code is formatted manually with great care by @chenzhuoyu to make it pretty, because there's a lot of assembly code in the go files, and assembly code format is not the same as the go code. Unfortunately, gofmt cannot handle this at the moment.
Here's some diffs, you may compare them and determine which looks better:

You may also take a look at the pr #37 .
Thanks for your suggestion anyway.

That's a trade-off, maybe just ignore these mannually fine-tuned *.go files or code snippets.
The tools can't fit all scenarios.

Every line in this project, as long as it is been written by me, are hand-tuned for aestheticness. Programming is a kind of art, not just tasks that someone forced you to finish.
Programs are indented to be read by human, not machine. Machines do NOT understand aestheticness, they can only do certain things pre-programmed by it's designer. It's also why there is very hard for computers to generate aesthetically pleasing arts.
If it's a trade-off, as long as they are functionally identical, I don't want to trade aestheticness for almost nothing.
IMO, go fmt is just an excuse to the laziness of programming. NEVER write messy code and hope go fmt magically fixes all the issues for you.
And also, go fmt is A code-style, not THE code-style. If Go really wants to force everybody to write identically looking code, they should fuse it into the syntax.
We have the rights of choosing our own style of programming, as our ByteStyle stats:

Champion Diversity and Inclusion

Take a look:
A hand-formatted program
func NameOf(id int) string {
    switch (id) {
        case APPLE  : return "Apple"
        case BANANA : return "Banana"
        case ORANGE : return "Orange"
        default     : return "Unknown"
    }
}

is considerably more readable and cleaner than the machine-generated counterpart:
func NameOf(id int) string {
	switch id {
	case APPLE:
		return "Apple"
	case BANANA:
		return "Banana"
	case ORANGE:
		return "Orange"
	default:
		return "Unknown"
	}
}

Also, the go fmt has some wierd formatting rules that cannot be turned off:
if a < (x + y) * z << 5 {
    // do something
}

will be formatted into
if a < (x+y)*z<<5 {
	// do something
}

which is A LOT messier.
Consider editing CONTRIBUTING.md.


A question

Hello i am wondering if addresses are imported to the wallet permanently or to the memory for temporary? I have too many addresses to check on my electrum client and it takes a long time to import after every restart. Is there a config to make this faster?

I have learned that it imports them into wallet dat file but after first import it takes too much time to start the service. i think it might be because it is checking if all addresses are there. can i make it like it checkes first 10 and last 10? so it wont check 50k addresses everytime i start the wallet.

EPS takes a long time because it generates all the addresses on startup. Issue #112 is relevant here. EPS needs all the addresses because it has to be ready in case Electrum requests them, so it's not possible to just generate the first and last 10. And finally, EPS already only checks the that the first and last few addresses have been imported.

What i mean is that it takes time after initial startup too. I checked wallet.dat before importing and it was like KBs and after initial startup it was around 30mb. Initial startup took around 2 hours. then i tried several times but it still takes 2 hours even though addresses are imported to wallet.dat. It's fine though i am running it on a Raspberry Pi and it is on all the time. Just wondered why it takes the same time after first startup.

It takes that time because EPS uses the master public keys to generate addresses.


Error: In 'OnFrame': Modules/BuildList.lua:168

I don't know what the specific problem is, I've tried to re-install, download the new version, but nothing seems to work, I can't access the folders, but they exist and I can put new characters inside them

You're using the Community Edition of PoB.  That repository is found here: https://github.com/PathOfBuildingCommunity/PathOfBuilding
Do you have your build location stored in something like OneDrive?  Check this comment for a possible explanation: https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/3226#issuecomment-937343595

Fresh build's working , socketed Glorious Vanity, Timeless Jewel, crashes with same kind of error messages, can't import most of my builds. Uninstalled -> re-installed 2.16.0 -> auto-upgrade to 2.19.0 errors stays.


[RESOLVED] High ICMP ping response time

Problem started at 15:14:14 on 2023.05.10
Problem name: High ICMP ping response time
Host: MF-FG
Severity: Warning
Operational data: Value: 492ms
Original problem ID: 20498
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23132&eventid=20498

Problem has been resolved in 44m 0s at 15:58:14 on 2023.05.10
Problem name: High ICMP ping response time
Host: MF-FG
Severity: Warning
Original problem ID: 20498


Fix some dep warnings & lint offenses

I spotted while doing #1334 that there were a bunch of warnings in the console output so I thought I'd fix them.  I also decided to remove all the custom exclusions from .rubocop.yml and fix any outstanding lint issues.  I've done these in lots of small commits.
Mostly they are entirely harmless but 3 lint fixes in particular made actuall changes to the app that bear close inspection:

When setting LOWEST_TIER_AREA_TYPES don't mutate UNITARY_AREA_TYPES - ee671ccb9e8540b96f7134fd34e4a55e473a699f - changes what we consider a unitary council type
Fix outstanding Date & Time lint offenses - bec379039eb776e70d77fc908f70e559c34d259f - changes the output format of times in the travel advice atom feed (it should be functionally identical though)
Remove wait_until and with/without_javascript helpers - a5d420b8c576647b71553949daee243707658bd3 - removes some integration test helpers relating to javascript

@boffbowsh - In theory, it should be ok because +00:00 and Z refer to the same thing, but you never really know what some external parser is going to do, so I think you're right to be wary.  I did a little more digging and found out two things:

We don't really have much control over the updated element that the rails atom builder will produce.  It's going to assume it gets an object it can call .xmlschema on so it's not like we can provide it with a pre-formatted string instead of a calendrical object.
If we call .to_datetime on the Time.zone.parse result we get a DateTime instance back and that means we keep the original xmlschema behaviour and output +00:00 instead of Z. Happily, rubocop doesn't complain that we are using DateTime anymore either so I guess we're respecting the law of the cop, if not the spirit.
The reason we get Z from Time.zone.parse is that this app has config.time_zone set to UTC (that is, it hasn't explicitly made a choice about timezone).  If, like whitehall and government-frontend, we set the time_zone of the app to London then we'd get +00:00 now and +01:00 in summer when we're in BST.

I think that setting the time_zone of the app to London is the right thing to do here (along with the rest of the use Time not DateTime changes).

FWIW it's pretty hit and miss if our apps have config.time_zone set to anything, which feels a bit unusual to me and might explain any strange BST behaviour we get.

I'm in favour of setting time zone to London for this. I'd rather not risk alerting people to things that happened in the past. While I agree an RSS reader shouldn't see a difference, I can quite imagine something somewhere is doing hash(updatedAt) or something.

@boffbowsh - thanks!  I've re-written the Fix outstanding Date & Time lint offenses commit to change the time zone in config.


Simulations with Costs for Increased Population Size

Reviewer 1 commented:

L172 / Eq 4 The costs and benefits of cooperation are always crucial in models like this, but while the costs are clear, the benefits are spread out using this equation. I feel like this should be clarified a little more - can the effects of this equation be reproduced in equation 2 such that both the costs and benefits of cooperation are explicitly expressed through effects on individual fitness?

A simple way to address this might be to use diminishing benefits, which can be done by raising the p parameter in the S(p) equation (Equation 4) to some power γ (a.k.a. gamma). Although it doesn't directly affect fitness, it does affect the c/b ratio.

In this plot, the green line shows S(p) as we have been using it in both papers. The red and ugly yellow-green lines show some diminishing returns. For a more complete picture, we could also do some runs with accelerating returns, which are the blue and purple lines.

[x] Add gamma parameter to model (see 1b525077372151ed023f02e38d2338960fe6f571)
[x] Add gamma to existing configuration files
[x] Do simulations with diminishing returns. gamma={0.25, 0.5}
[x] Do simulations with accelerating returns. gamma={1.5, 2.0}
Combine data and create figure(s)

[x] Time series plot
[x] Integral in each of the treatments? We haven't used the integral in this paper yet, so would require explanation

[ ] Add gamma to Table 1
Add relevant things to repository

[ ] Configuration file(s)
[ ] Data set
[ ] Analysis scripts
[ ] Figures

Does anyone have any thoughts on what a good description of Gamma would be? I was thinking "Shape of Cooperative Benefit", but that might not be descriptive enough.

Ben just suggested "concavity of benefit function"  or "Shape perimeter of production function (or shape perimeter of the benefit function"


The no_std support is broken

There was attempt to fix the no_std support in this crate in 9daa0974e7d28503581b9b8f1f3db575ae5b789a but it's been incomplete, so nuta/kerla cannot use it at the moment.
The reason why it doesn't compile in no_std environment is #![no_std] flag missing in lib.rs, but to not break the tests it has to be behind feature. I'm proposing the fix following well known pattern in embedded world of Rust in the PR.

@rexlunae hey, I just hit this problem, I noticed that this issue has been stagnant for over a year
I would like to volunteer to help you maintain this crate if this has become too much of a burden for you, I am sure others could help too, it is a really nice crate it'd be a shame if it rotted or if people had to fork it and publish it under an alternative name on crates_io

@rexlunae hi
This was filed months ago and the crate hasn't seen any activity for a while. There are users that have had to fork the project and create alternative crates in crates.io... your github account seems to have near 0 activity.
I am going to wait for another week, if we don't hear from you I am going to reach out to the crates.io maintainers and request a takeover of the crate. This crate is broken as it is and there are potential future users that may lose a lot of time by trying to consume this crate and finding issues afterwards.

Given the lack of activity, no_std support and proper license I've decided to make my own crate.
It is focused on keeping things short & sweet, for example:
use nora_endian::u32le;

let flags = u32le::from(1234);
let index = u32le::from(0);

// Easy operations on & comparisons between le/be and native types
if flags & 1 == 0 {
   // ...
}

let index_plus_one_u32: u32 = 1 + index;
let index_plus_one_u32le: u32le = index + 1;

FYI: I have just published rust-osdev/endian-num with a focus on following core::num conventions. :)


MM-40071 Only calculate suggestion list max height when first opened (5.39)

A 5.39 version of https://github.com/mattermost/mattermost-webapp/pull/9451
Related Pull Requests
https://github.com/mattermost/mattermost-webapp/pull/9451
Release Note
NONE

I'm going to block this on the master PR since I've requested QA review on that

/cherry-pick release-5.37

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   c25f2d540..ddda08506  release-5.39 -> upstream/release-5.39
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#9456-upstream-release-5.37-1638461469
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#9456-upstream-release-5.37-1638461469'
Branch 'automated-cherry-pick-of-mattermost-webapp-#9456-upstream-release-5.37-1638461469' set up to track remote branch 'release-5.37' from 'upstream'.

+++ About to attempt cherry pick of PR #9456 with merge commit ddda0850685a6f1d742f7cd125d38debf6b40663.

error: could not apply ddda08506... MM-40071 Only calculate suggestion list max height when first opened (5.39) (#9456)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU components/suggestion/suggestion_list.jsx
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

/cherry-pick release-6.0

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   de8afb3b0..5f99d3f24  MM-40220-new-modal-for-deletion-confirmation -> upstream/MM-40220-new-modal-for-deletion-confirmation
   5c2f64809..f5160bd90  cloud       -> upstream/cloud
   35a761a42..2b2537124  release-6.2 -> upstream/release-6.2
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#9456-upstream-release-6.0-1638470464
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#9456-upstream-release-6.0-1638470464'
Branch 'automated-cherry-pick-of-mattermost-webapp-#9456-upstream-release-6.0-1638470464' set up to track remote branch 'release-6.0' from 'upstream'.

+++ About to attempt cherry pick of PR #9456 with merge commit ddda0850685a6f1d742f7cd125d38debf6b40663.

error: could not apply ddda08506... MM-40071 Only calculate suggestion list max height when first opened (5.39) (#9456)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU components/suggestion/suggestion_list.jsx
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.


Use go matchers pkg from this repo in vsphere-cpi

What this PR does / why we need it

Sometime ago (#3031) we added the test matchers package that we created for tanzu-framework into community-edition as well, to remove our dependence on tanzu-framework at least for running unit tests in external-dns. This PR does the same for the latest version of the vsphere-cpi package.
Which issue(s) this PR fixes

Fixes: n/a
Describe testing done for PR

Ran make test in the vsphere-cpi v1.23.1 package.
Special notes for your reviewer

LGTM thanks @christianang


azure app service configuration support from the portal

[Enter feedback here]
looks like importing the certificate from a key vault to the webapp is supported and working from the portal once assigning those permissions

Azure App Service certificate configuration through Azure Portal does not support Key Vault RBAC permission model. You can use Azure PowerShell, Azure CLI, ARM template deployments with Key Vault Secrets User and Key Vault Reader role assignments for 'Microsoft Azure App Service' global indentity.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9fe2188c-d08d-be91-bf80-9665cac23596
Version Independent ID: e0cf82de-bdf5-97a4-f9e0-f40e8c12b064
Content: Migrate to Azure role-based access control
Content Source: articles/key-vault/general/rbac-migration.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@minow2
Thanks for your feedback! We will investigate and update as appropriate.

@msmbaldwin
Can you please check and add your comments on this doc update request as applicable.

@minow2
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

As explained above there is no support. #please-close


Set default-features = false for image dependency

Once enabled, there's no way to disable a cargo feature, so as a library, rxing probably shouldn't enable all the formats supported by the image crate.
This PR conditionally disables tests that depend on the image or image-formats features, introduces the image-formats feature and enables it by default, and adds a test step to the GitHub Actions workflow to test the crate with default features disabled.

I'll admit my ignorance here, is the issue over-inclusion of dependencies?
I'll review the PR this weekend, I should have time then, I'm trying to finish up some ports from the C++ version.

Yep, that's pretty much it. Imagine I'm writing an application that'll only ever need to decode from PNGs. Because rxing depends on image's default features, there's no way for me to disable all the other image formats.

I appreciate the explanation! Given that, this change makes sense to me. I should have time to review this weekend.


Removing doubled configuration in config.f90

Centralizing all configuration in mo_nix_config.f90.

There was one conflict in input.f90 with nsteps vs. nrow/


pom.xml version should be 3.0.1-SNAPSHOT

Probably needs the release/3.0.0 branch merging to main.

Closing - just spotted the PR! :-)


filter activations by action and time

Problem
Think of an application that consists of two different of actions:

Action T : triggered by a feed
Action E : triggered by events

T is triggered every 10 minutes, while E is being triggered several hundred times per minute.
Now imaging T is having some issues. And you don't see the outcome you expect.
You run

aio rt activations list  --limit 50

but all you can see is Action E, Action E, Action E, ..  If you ever spot any Action T, it would be bare luck because the number is too small compared to the high-frequent E... and the window of seeing 50 activations at once is too small.
No you also cannot call "list" with "skip" parameters, like

aio rt activations list  --limit 50 --skip 50, 100, 150, 200, ...

because as you "scroll" down the list of activations, the listed activations scroll, too due to more activations being added every second.
Possible Solutions

Increase the limit to receive more than 50 actions (5000 would be more desireable)

Filter the activations by their action

aio rt activations list  --limit 50 --action=actionT

that would list the first 50 activations from "actionT" (Note: NOT get the first activations filtered by "actionT")

Do not skip a constant number of activations, but skip to a certain activation:

aio rt activations list  --limit 50 --from-activation=4696c6eefe08454c96c6eefe08354ca2

would list the first 50 activations that happened earlier in time than 4696c6eefe08454c96c6eefe08354ca2 (including that id)

Do not skip a constant number of activations, but skip to a point in time:

aio rt activations list  --limit 50 --from-date=2021/12/31T05:38:50

would list the first 50 activations that happened earlier in time than the given date
Alternatives  considered
a) Scripting scrolling

aio rt activations list  --limit 50 --skip 50, 100, 150, 200, ...

Fail - see above
b) filtering after querying

aio rt activations list  --limit 50 | grep action T

See above - if the list includes action E, only. The filtered result would be empty
Additional context
What also would be nice is to show the failures, only:

aio rt activations list  --fails

Would only display the activations that fail.

Thanks for the feature request, @ackoch !
Assigning @Himavanth and @purplecabbage for review and initial feedback.

Filtering the activation list by a name is already supported.
> WSK_CONFIG_FILE=~/.nimbella/wskprops ./bin/run rt:activation:list  --help
Lists all the Activations

USAGE
  $ aio runtime:activation:list [ACTIVATION_NAME]

> WSK_CONFIG_FILE=~/.nimbella/wskprops ./bin/run rt:activation:list visits/info
 Datetime        Status    Kind     Version    Activation ID                    Start Wait Init Duration Entity
 ─────────────── ───────── ──────── ──────── ─ ──────────────────────────────── ───── ──── ──── ──────── ───────────
 06/23 13:18:34  dev error php:8.0  0.0.3      931b322f9b2846cf9b322f9b28a6cf07 cold  1075 98   156ms    visits/info

> WSK_CONFIG_FILE=~/.nimbella/wskprops ./bin/run rt:activation:list
 Datetime        Status    Kind      Version    Activation ID                    Start Wait Init Duration Entity
 ─────────────── ───────── ───────── ──────── ─ ──────────────────────────────── ───── ──── ──── ──────── ────────────────────────────────
 06/23 13:19:12  success   nodejs:10 0.0.2      e805720d21df46de85720d21df36de8c cold  89   475  485ms    nimbella/redis/get
 06/23 13:18:55  success   nodejs:10 0.0.2      fd0668e84d194c028668e84d192c02d2 cold  96   454  472ms    nimbella/redis/keys
 06/23 13:18:34  dev error php:8.0   0.0.3      931b322f9b2846cf9b322f9b28a6cf07 cold  1075 98   156ms    visits/info

Also there is --since flag so get activations starting from a particular date although it accepts epoch time instead of a date string.

Thx.. I was focusing to much on the parameters, i guess. A "since" date that accepts a date human-readable for would be great... as this is the time the listing emits..

aio runtime:activation:list [ACTIVATION_NAME]
actually is very helpful here, but the use of ACTIVATION_NAME instead of ACTION_NAME is an error.
additionally, --action filter exists on logs:
aio runtime:activation:logs --action <ACTION_NAME>


RC Test: Color Vision 1.3.0-rc.1

RC Test
Mentions: @marlitas, @amanda-phet
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html

Test Matrices

General Test Matrix

Features included

~PhET-iO~
[x] Dynamic Locale
~Alternative Input~
[x] UI Sound
~Sonification~
~Description~
~Voicing~

Focus and Special Instructions
This is Color Vision's first RC for this republication. Work was done to add dynamic locale, update artwork, as well as address some teacher suggestions for sliders.
Everything is fair game.
Issues to Verify
All issues can be closed once verified.

[x] https://github.com/phetsims/color-vision/issues/160

For QA...

General features

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (
See QA Book for a list of query parameters.)
Download HTML on Chrome and iOS.
Make sure the iFrame version of the simulation is working as intended on all platforms.
Make sure the XHTML version of the simulation is working as intended on all platforms.
Complete the test matrix.
Don't forget to make sure the sim works with Legends of Learning.
Test the Game Up harness on at least one platform.
Check this LoL
spreadsheet and notify AR or AM if it not there.
If this is rc.1 please do a memory test.
When making an issue, check to see if it was in a previously published version.
Try to include version numbers for browsers.
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there
is a problem.
As the RC ends, please review the QA credits in the about dialog. If the QA credits are complete and correct, please
add a comment in the RC test issue indicating so. If not, please open a new issue and specify what changes should be
made.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.
Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:/wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER

Further instructions in QA Book
Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
random platform.
Conduct a memory test on the stand alone sim wrapper (rc.1).
Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
Test that the sim works offline:

Click the link to the phet-io zip file (at top of issue) to download the zip file.
Unzip it to a spot locally.
Open index.html by double clicking it on your desktop or in a Finder-view.
It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

If this sim is not in this list or up to date there, make an
issue in website to ask if PhET research page links need updating. Please
assign to @terracoda and @emily-phet.

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Memory test looks ok.

QA is done.

RC spotcheck is in


Small change in repr method

the repr method of the object should return the syntax required to initialize said object.

Coverage remained the same at 100.0% when pulling a0e57008828d1e7dab9f25b46c48e22c76f44c9e on smetj:master into 57332f9122e062d7d1aa14a1bb003d4fd49fdd50 on bcj:master.


kernel: sem: handle resets with outstanding waiting threads

Previously, a k_sem_reset with any outstanding waiting threads would
result in the semaphore in an inconsistent state, with more threads
waiting in the wait_q than the count would indicate.
Explicitly -EAGAIN any waiting threads upon k_sem_reset, to
ensure safety here.
Signed-off-by: James Harris<EMAIL_ADDRESS>

adding @jukkar to look into why networking tests are failing...

There are a few k_sem_reset calls in various places in the network stack. It's entirely possible something relied on the old (broken) behavior...
Looking at it, we're dying in the k_sem_reset call in check_interface, with an access violation in z_handle_obj_poll_events because  node is NULL but we're dereferencing node->next... which means that list->next was NULL.
...which likely means we called k_sem_reset on a not-properly-initialized semaphore.
...and we totally are:
	if (check_interface(iface) == false) {
		k_sem_init(&counter, 1, UINT_MAX);

...where check_interface is the one calling k_sem_reset.
Luckily, it's a fairly straightforward fix.


Ansible role haproxy

Integrate Rosa-Luxemburgstiftung-Berlin/ansible-role-haproxy role
This makes much sense for me, as I usually use the 2 roles in a nice combination.
closes Rosa-Luxemburgstiftung-Berlin/ansible-role-haproxy#6

anything I can add her?

If it works, it works, let's go.

Thanks for the help! It's very useful to see them together.

Thanks for the help! It's very useful to see them together.

Thank you for the merge. And yes, I fully agree, they fit well together and I often use them in combination.

I want to add you as maintainer, I sent an invite. Tell me if you got it.

I want to add you as maintainer, I sent an invite. Tell me if you got it.

Hello @evrardjp - thank you for this. Yes, I got the invitation and accepted it.


[Masks: A New Generation] Bugfix - Resolving CSS bugs

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description
Resolving some extant issues with the CSS styling for darkmode.

Character Sheet Info Roll20 Internal Use only.


Documentation for clarity for testers

Provide clarify on our accepted values and allowance for adding contacts

[x] Specify the allowance for duplicate phone numbers | #189, #177
[x] Specify the allowance for duplicate emails | #179
[x] (Known Issue) Indicate workaround for phone descriptors if needed as known issues | #192
[x] (Known Issue) Indicate workaround for non-numeric names such as s/o | #178
[x] (Known Issue) Indicate workaround for venues containing prefix | #219
[x] Sort to be better described regarding attributes* | #207, #187

Additionally:

Specifies MODULE, FACULTY, VENUE unique/duplicate restrictions
Specifies TAG and AVAILABILITY unique/duplicate restrictions
Removes Redundant [Attribute] in help message

clarification: need to standardize whether to use person, contacts, staff book


Define toolchain for cross build win32

This is the toolchain file that I used in pr #976.
Contributed by STMicroelectronics

Sounds basically fine to me. How is this file being picked up by CMake?
I'd suggest to enhance the documentation about how to cross compiler on Windows for Linux.


viewport texture to mesh material not work when play.

godot3.02 debian
viewport texture to mesh material not work when play.
Issue description:

Minimal reproduction project:
godot.zip

OK, i find it .
Need to enable  enable "Local to Scene" in spatial material.


Prezto Completion

What’s the best way to add a completion to prezto?
Best I’ve found is adding files to the prezto/modules/completion/external/src directory which I know is bad practice.

Not sure as I never added an extra one, but did you try play with the after feature? https://github.com/skwp/dotfiles/blob/master/zsh/zzzz_after.zsh or if you have your own fork, then maybe adding to the prezto-override folder and configuring it there?


Build fails after upgrade to Gradle 6.4

Environment:

Jib version: 2.2.0
Build tool: Gradle 6.4 (Works with Gradle 6.3)
Java version: 11
OS: MacOS

Description of the issue:
jibDockerBuild fails with:
class org.gradle.api.internal.provider.DefaultProperty cannot be cast to class java.lang.String (org.gradle.api.internal.provider.DefaultProperty is in unnamed module of loader org.gradle.internal.classloader.VisitableURLClassLoader @22927a81; java.lang.String is in module java.base of loader 'bootstrap')

Steps to reproduce:

Configure any value for jib.from.image
Execute jibDockerBuild

This is java11?

This is java11?

yes. updated initial post

@xRomZak could there be anything in the way you're using jib.from.image that's triggering this? I can't seem to reproduce this on linux.
Can you run with the --stacktrace flag to give us some more details?
@briandealwis can you recreate this on mac? I think you might be the only one with a mac?

Works for me:
$ ./gradlew -v

------------------------------------------------------------
Gradle 6.4
------------------------------------------------------------

Build time:   2020-05-05 19:18:55 UTC
Revision:     42f7c3d0c3066b7b38bd0726760d4881e86fd19f

Kotlin:       1.3.71
Groovy:       2.5.10
Ant:          Apache Ant(TM) version 1.10.7 compiled on September 1 2019
JVM:          11.0.4 (Oracle Corporation 11.0.4+10-LTS)
OS:           Mac OS X 10.15.4 x86_64

$ ./gradlew jibDockerBuild

> Task :jibDockerBuild

Containerizing application to Docker daemon as localhost:5000/foo:bar...
Base image 'gcr.io/distroless/java' does not use a specific image digest - build may not be reproducible
Using base image with digest: sha256:f59b26c5ecc735514a38afbf845214383c4e2ba1fdd15a76225339b8ab7da8ef

Container entrypoint set to [java, -cp, /app/resources:/app/classes:/app/libs/*, jibexamples.first.Main]

Built image to Docker daemon as localhost:5000/foo:bar
Executing tasks:
[==============================] 100.0% complete

BUILD SUCCESSFUL in 2s
2 actionable tasks: 2 executed

I have the same problem, Mac, Gradle 6.4
It happens only if there is an application plugin added:
plugins {
    id "application"
}

mainClassName = "com.xxx.zzz.Application"

Ah, I see the error if I add the application plugin too.

tested using latest Gradle 6.4.1. Problem is gone. Seems it was a regression in Gradle 6.4

Thanks for the update @xRomZak
I will close for now then.


Issue with named export package

With your workflow, when building a named export only package, rollup complains:

Using named and default exports together.

Since it is a named export only package, this shouldn't happen.
Seems like one of the plugins (node-resolve or node-globals?)  added default: Object to the resulting bundle.

I can add exports: 'named' to suppress this warning, but wondering would it be possible not to create the synthetic default export (and would that be a good idea).


Newly updated Python Cloudflare Ruleset not supported yet.

What happened?
I was expecting Cloudflare Rulesets to become available for importing. I tried to do the import today with no luck since I still get 'Import is not yet supported for Rulesets' message.

Steps to reproduce
Try to import Ruleset both zone and account related.
Expected Behavior
Proper importing of Ruleset provided.
Actual Behavior
Still shows that Ruleset import is not supported.
Output of pulumi about
No response
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Please could you include details as to which versions of the plugin and pulumi you're using. Thanks

There was a release of this provider 3 days ago, so as a first action, please do ensure you're fully upgraded and if that resolves your issue.

It was indeed a mistake from my end.


Spin a Wheel present in the repo is not made using react

Description
Hey @panwar8279 I just found that the Spin a Wheel game in the repo is made using HTML CSS and vanilla js. It's not made using react. Please assign me this issue I will remove it. Thank you!
Screenshots
No response
Additional information
No response

@sumitkr2000 There are many duplicate issue which you have opened so we can't assign all these to you. Kindly make a single PR and remove all the unnecessary files.

Okay bro Ill make a single pr only :)

Also, there is another issue that I raise in which I asked to add a path for the Tetris game, I  will make a separate pr for that.

Made a single pr for removing unwanted files. So closing this issue.


Add 60k RPM support to voxl-esc driver

Changes

Added new packet header for extended RPM range commands
Added new packet packing function for extended RPM range commands
Implemented ESC firmware version check at driver start up to determine which type of RPM command to send
Added voxl-esc driver back to voxl2 build (removing this had removed the voxl-esc section from the Actuators tab in QGC)
Add Voxl2 IO default parameters

Testing

Acro and Manual mode flights were successful
Successfully spun motors on bench with props attached and verified that RPMs were higher than 32k (./voxl-esc-spin.py --id 0 --rpm 35000 --ramp-time 3.0 --enable-extended-rpm-cmd 1)
Successfully spun motors on bench with props attached via Actuators tab
Validated that standard range RPM commands are sent when using old ESC firmware and extended range commands are sent when using new ESC firmware (SW version>=39)

From Alex (referring to qc_esc_packet.c line 154) :
it is not necessary to cast to doubles when scaling the rpms, integer math is good
I updated this in the latest commit (3dd7d21) and removed the double and int16_t casts