[Bug]: Buying Airtime from Coop account fails because my account is linked to 2 accounts

Description
Buying Airtime from my coop Bank account fails and freezes at the point where I'm supposed to select the account to debit. This is because coop mobile banking links 2 accounts: your actual bank account, and your mcoopcash account which is your phone number.
Steps to reproduce

Open stax app
Select buy airtime
Choose coop account as the account to buy with
Choose safaricom as the recipient
Continue
Enter coop pin

Expected result
The app runs through all the buying Airtime steps successfully
Actual result
After entering the coop pin, app starts running but freezes at the point where you choose the account to debit.
Link to screenshots/screen recordings
https://drive.google.com/file/d/1u_QG7PnomAMiO9G-bOjiyUMwJsE6hudq/view?usp=drivesdk
Device name
Huawei y5 2019
Android OS
9
Is your phone dual SIM or single SIM?
Dual SIM
Which telco are you using for this test?
Safaricom
Stax device ID or email address
<EMAIL_ADDRESS>

@suemnjeri do you still experience this issue?


Will there be more practice papers coming soon?

Just curious, @hwkchia

Answer: just talked to @hwkchia, there will be.


[EN] Feedback for: /web/tools/chrome-devtools/?hl=en

Chrome devTools, console
is it not possible to add a shortcut like ctrl+r for terminal unix to search old inserted command?
Regards

Hey @th3nu11 please send DevTool feature requests to crbug.com.


Add offline installation guide

Add a guide on how to install KubeVela in a private cloud without
internet.
Signed-off-by: Zheng Xi Zhou<EMAIL_ADDRESS>

let's place the docs in the system-operation folder along with https://kubevela.io/docs/platform-engineers/system-operation/bootstrap-parameters

Fixed, thanks.

I'm going to merge this PR, please help refine it in the following PRs, thanks  \cc @fourierr @BinaryHB0916


remote vscode tabnine can not active

OS version: Win 10 remote service：centos7
Editor version :1.53.2
TabNine extension version: 3.2.7

when i click active

What should I do to ctivate tabnine？

@YanYeek - can you please forward port 5555?
https://code.visualstudio.com/docs/remote/ssh-tutorial#_port-forwarding

@YanYeek - can you please forward port 5555?
https://code.visualstudio.com/docs/remote/ssh-tutorial#_port-forwarding

Do I have the right Settings？

Can you share a screenshot of the tab when you click on the status bar?

Can you share a screenshot of the tab when you click on the status bar?

I see that you opened the "Tabnine Home" now you need to sign up

I see that you opened the "Tabnine Home" now you need to sign up

Thank you very much for your help. I have solved it. The method used is to clear all the files under ~/.config/TabNine and then reinstall it


Allow to start Flex without starting a daemon

For example with the flag yarn start --no-daemon / yarn run-script install-dependencies. So it downloads all repositories (media-essentials, etc.) but does not actually start a server.

Related: #525 and #522


Add sidebar left and replace primer with tailwind

[x] finish replacing all primer classes
[x] fix markdown styling
[x] replace primer tooltip with our own
[x] replace primer anim-pulse and anim-scale-in
[x] remove primer & support packages

 Add sidebar left and tailwindcss

 Add sidebar left and tailwindcss

Cool, fixed those

Sidebar bg should use this bg-skin-block-bg color:

It does use that already, no?

It does use that already, no?
Nope it doesn't, i mean about the main sidebar. It should be white here:

Others things i forgot:

Not a fan of this:

I'd rather keep it the way is it was before, with full rounded pill and without "Open".

I think for now we should show the space that you follow on the main page too. Main page give extra information (numbers of active proposals). We can remove it later when we change some others behavior.

Background color shouldnt change on mouse over:

Howdy ! Noticied that the incremential selector is overlapping the pill on mouse over.

Slightly larger line spacing here

Log out text color style is missing

Sidebar bg should use this bg-skin-block-bg color:

You mean bg-skin-block-bg or bg-skin-header-bg because where you are pointing the arrow is bg-skin-header-bg

I'd rather keep it the way is it was before, with full rounded pill and without "Open".

It doesn't look very good without the border around the space image.

Background color shouldnt change on mouse over:

I added that because currently it's looks very flat, with the join button being very prominent and the user could miss that you can also view a space by clicking on it.

Slightly different line spacing add over the height of this section.

Missing element here

@metrox-eth thanks a lot for your help!

@samuveth i mean skin block bg

Spacing btw address and pill

Upload text background missing

Placeholder text color

Placeholder text color and title bg height

Title size

SafeSnap layout is broken test here: https://bafybeigfqj3vc6qpq5gustfudjtal6r4p2dsx6ksc2czw5h3th6cjngmau.on.fleek.co/#/fabien.eth/proposal/QmV2TVKZmgXHuzT36ockuJ3hwCY31weotgirYTsA18SBDB In proposal creation too test here: https://bafybeigfqj3vc6qpq5gustfudjtal6r4p2dsx6ksc2czw5h3th6cjngmau.on.fleek.co/#/fabien.eth/create
Add background color from the skin on sidebar space icon so i doesnt look like this:

Try reduce slightly the space between space icon in sidebar
Check if something is wrong with 3box? Can't see my image here: https://bafybeigfqj3vc6qpq5gustfudjtal6r4p2dsx6ksc2czw5h3th6cjngmau.on.fleek.co/#/fabien.eth/proposal/QmUQ3ytu3JQdbVScFVkEsPtPHc6REEKCtYb7wTcaKkukrR

Also something wrong with progress bar on block results. We should use the primary color then reduce by 15% opacity for each strategy.

@bonustrack ready for merge from my side. I will improve the progress bar and tooltip in another PR.

Border shouldn't appear on mobile here:

Same for proposal creation, we shouldnt have this right border on mobile

Also can you reduce the space in green and increase in red? It should look same as on snapshot.org

Feel free to merge once you've done these changes

Feel free to merge once you've done these changes

@bonustrack Ok please approve


feat(PushToCore): Add PushToCore function to pipeline configurations

Add PushToCore function to pipeline configuration in full sample configs.
Add new push-to-core profile that is tailored for HTTP trigger ingestion.
Completes https://github.com/edgexfoundry/app-functions-sdk-go/issues/200

recheck


Fixed a crash and a logic error, gitignore updated

Fixed a crash with oh-my-zsh, whose 'which clang-format' command returns 'clang-format not found', instead of an empty string.
Fixed a logic error: abs(unsigned long - unsigned long) doesn't make sense.
git ignore file added xcworkspace

@travisjeffery any body in?

@travisjeffery new pull request has been created for oh-my-zsh crash fix.

can we not ignore the workspace? also what's the behavior now for oh-my-zsh users? just uses the bundled version of clang-format?

should or should not ignore workspace:
xcworkspace is not under version control before, so each time enter 'git status' command, git will notice me there are untracked file under project.xcworkspace, that makes me feel the project unclean.
There are 3 file/folders in it (as described here)

contents.xcworkspacedata
Maybe the project will include other projects in the future, so you may want to added this file to version control then.
xcuserdata
already ignored
xcshareddata
Contains original repo info, and will be generated by Xcode if deleted. So I think this folder should be ignored for github public projects, since there are many forks, and for each fork, this file will be different.

what's the behavior now for oh-my-zsh users? just uses the bundled version of clang-format?
I didn't change the behaviour when the extension use clang-format in bundle or the system installed one, just fix this problem:
when execute command 'which clang-format', and no clang-format installed to system, oh-my-zsh will return string 'clang-format not found' , instead of an empty string in bash.  The extension will use the 'clang-format not found' string as the system clang-format path to start an NSTask, this will raise an exception and not catched, then the Xcode crashes.
So this commit will decide if the 'which clang-format' returned string is really a file path, or a warning noticed by shell.
Many of my friends uses oh-my-zsh, but seldom install a clang-format by themselves.
oh-my-zsh is a very popular and powerful shell for mac, you may want to try it, and this line is not an advertisement : )

And the crash stack is here: https://github.com/travisjeffery/ClangFormat-Xcode/issues/99


fix: Fixed problems in examples

Fixes: #382

You need to add the manifests with release please annotations to the release-please-config.json file

fixed


installation USBs are not listed

Thank you for the work.
I have a problem with the installation(Monterey/Ventura).
The installation USBs are not listed.
Only the already installed ones are found on another hackintosh.
I created them on another hackintosh and tried them there, they work.
fastboot is disabled
Richie
sorry for my bad english

@IamTheRichie try disabling HIDE AXULUARY and enabling Show picker from misc on your EFI.

@IamTheRichie try disabling HIDE AXULUARY and enabling Show picker from misc on your EFI.


bug: Undocumented dependency on pdftotext provided by poppler-utils

Bug Report: Undocumented dependency on pdftotext provided by poppler-utils
colrev version:
colrev version 0.7.0 (installed through pip)
Running in Ubuntu on WSL:
neofetch -off

OS: Ubuntu 22.04.1 LTS on Windows 10 x86_64
Kernel: <IP_ADDRESS>-microsoft-standard-WSL2
Uptime: 7 hours, 7 mins
Packages: 1018 (dpkg)
Shell: zsh 5.8.1
Theme: Adwaita [GTK3]
Icons: Adwaita [GTK3]
Terminal: /dev/pts/4
CPU: Intel i7-8650U (8) @ 2.111GHz
GPU: 1319:00:00.0 Microsoft Corporation Device 008e
Memory: 2861MiB / 15925MiB

Current behavior:
Running colrev pdfs fails because poppler-utils is not installed to provide /usr/bin/pdftotext. See Traceback provided later in this report below.
Problem is resolved if the user manually installs poppler-utils, e.g. on Ubuntu:
sudo apt-get install poppler-utils

Expected behavior:
Running colrev pdfs completes successfully.
Steps to reproduce:
Go through the usual colrev workflow up to colrev pdfs and then attempt to run colrev pdfs
Related code:
Traceback below.
2023-02-19 20:37:16 [INFO] Prep PDFs
2023-02-19 20:37:16 [INFO] Prepare PDFs, validating them against their metadata, removing additional pages, ensuring machine readability.
2023-02-19 20:37:16 [INFO] INFO: This operation is computationally intensive and may take longer.
2023-02-19 20:37:16 [INFO] PDFs to prep                          6 PDFs
2023-02-19 20:37:20 [INFO]  Hannonen2020                            pdf_imported → pdf_needs_manual_preparation (validate_completeness)
Traceback (most recent call last):
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/bin/colrev", line 8, in <module>
    sys.exit(main())
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/colrev/ui_cli/cli.py", line 1054, in pdfs
    pdf_prep_operation.main(batch_size=0)
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/colrev/ops/pdf_prep.py", line 405, in main
    pdf_prep_record_list = pool.map(self.prepare_pdf, pdf_prep_data["items"])
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 367, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 774, in get
    raise self._value
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 48, in mapstar
    return list(map(*args))
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/colrev/ops/pdf_prep.py", line 156, in prepare_pdf
    record.data = endpoint.prep_pdf(self, record, pad)  # type: ignore
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/timeout_decorator/timeout_decorator.py", line 92, in new_function
    return timeout_wrapper(*args, **kwargs)
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/timeout_decorator/timeout_decorator.py", line 152, in __call__
    return self.value
  File "/home/blair/00blair-wsl/gitrepos-colrev/colrev-repos-venv/lib/python3.10/site-packages/timeout_decorator/timeout_decorator.py", line 175, in value
    raise load
FileNotFoundError: [Errno 2] No such file or directory: '/usr/bin/pdftotext'

Other information:
Suggestions on how to fix:

Maybe the documentation (https://colrev.readthedocs.io/) or pypi page (https://pypi.org/project/colrev/0.7.0/) could state poppler-utils as a requirement? (e.g., in addition to Git and Docker which are stated already)
Alternatively/additionally, perhaps the colrev codebase itself could check if /usr/bin/pdftotext exists, and if not, provide a gentle message suggesting the user should install it (essentially a friendly version of what the final line of the Traceback already implies). 😄

Thank you for reporting this issue. We could even think about using PdfFileReader.getPage(i).extractText() per default. The poppler/pdftotext seems to be slightly more reliable. But we could simply use it as a backup (if the extractText() fails) and print a notification if pdftotext is not available (instead of raising an Exception).


Test on 6/29 Swift 4 snapshot; update documentations

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   75.32%   75.32%
=======================================
  Files           1        1
  Lines          77       77
=======================================
  Hits           58       58
  Misses         19       19

Flag
Coverage Δ

#KituraCSRF
75.32% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

Sources/KituraCSRF/CSRF.swift
75.32% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873035f...1ef6538. Read the comment docs.


Debounce changes to search input

Bug description:
Not a bug per se, more a feature request/performance optimization suggestion.
With large lists, searching is a pain (initial rendering is "ok" - not good, though).
But searching a list of ~800 objects, using 2 properties and the or-filter from one of the examples is a pain, even on my quad-code i7. And it's practically impossible on older machines.
I suspect, that it's because the input is not properly debounced, so that 4 keystrokes results in 4 filterings, and 4 total refreshes of the ng-repeat.
I've looked at the source, but could not find the entry point where the search input is updating the data.
Also, looking at some performance tools, I see that a lot of time is used on parsing (using resultParser.source or the result of $parse), which is very expensive. Is it not possible to avoid this? I see it in all the formatters, why is something like ctrl.items not just used there?

Maybe you could submit a PR with the proposed performance improvements you've identified?
Thanks! :smiley:

It works just adding debouncing through the ng-model-options. F.ex ng-model-options="{ debounce: 500 }"
https://docs.angularjs.org/api/ng/directive/ngModelOptions


Google Drive confirmation code warning

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-F', '--verbose', 'https://drive.google.com/open?id=1UhAEdTDZnIKUwAjIA5CMi7R4PtVkU4T4']
[debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252
[debug] youtube-dl version 2019.01.16
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-92696-ge5a0013c4a, ffprobe N-92696-ge5a0013c4a, rtmpdump 2.4
[debug] Proxy map: {}
[GoogleDrive] 1UhAEdTDZnIKUwAjIA5CMi7R4PtVkU4T4: Downloading webpage
[GoogleDrive] 1UhAEdTDZnIKUwAjIA5CMi7R4PtVkU4T4: Requesting source file
WARNING: unable to extract confirmation code; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[info] Available formats for 1UhAEdTDZnIKUwAjIA5CMi7R4PtVkU4T4:
format code  extension  resolution note
18           mp4        640x360
59           mp4        854x480
22           mp4        1280x720
37           mp4        1920x1080  (best)

the file download is not a problem. It gives me this warning so I reported it but the downloaded file is ok.

I just had the same experience

Still happening
rod@alx:~$ youtube-dl -F --verbose  https://drive.google.com/file/d/1u8SwJOZ6F0XeZJ6q9J7EoGk8ElIyOyW9
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-F', '--verbose', 'https://drive.google.com/file/d/1u8SwJOZ6F0XeZJ6q9J7EoGk8ElIyOyW9']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2020.01.24
[debug] Python version 3.8.1 (CPython) - Linux-5.5.1-arch1-1-x86_64-with-glibc2.2.5
[debug] exe versions: ffmpeg 4.2.2, ffprobe 4.2.2, rtmpdump 2.4
[debug] Proxy map: {}
[GoogleDrive] 1u8SwJOZ6F0XeZJ6q9J7EoGk8ElIyOyW9: Downloading webpage
[GoogleDrive] 1u8SwJOZ6F0XeZJ6q9J7EoGk8ElIyOyW9: Requesting source file
WARNING: unable to extract confirmation code; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[info] Available formats for 1u8SwJOZ6F0XeZJ6q9J7EoGk8ElIyOyW9:
format code  extension  resolution note
18           mp4        640x360
59           mp4        854x480
22           mp4        1280x720   (best)


rollup-integrity-check-plugin: Sets up watcher on "transform" hook

Completely internal changes, no release intended.

Changes

Moves the watcher (this.addWatchFile) call to the transform hook of rollup.
Removes providing of a value in renderChunk hook, as it doesn't seem to have access to a plugin-wide variable this.checksum anyway.

GitHub

Closes #86

While this change does result into the generated cjs/umd modules having a proper integrity checksum on incremental builds, there's still an integrity error during the runtime when working with test scenarios preview.
It appears that WDS serves the outdated version of the library's alias (packageJson.main), while the changes in the worker file propagate to the browser as a regular worker update (thus, failing the integrity handshake).

Since integrity mismatch does not disable the mocking, I don't find the WDS serving outdated build module a critical issue to solve at the moment.


mitmweb --help should mention the default port

I had to search the code to find the default web port mitmweb listens on.
Shouldn't this value (and other defaults) be a part of the help output?
Perhaps something like?
diff --git a/libmproxy/cmdline.py b/libmproxy/cmdline.py
index 99b76e6..f93f482 100644
--- a/libmproxy/cmdline.py
+++ b/libmproxy/cmdline.py
@@ -737,7 +737,7 @@ def mitmweb():
         "--wport",
         action="store", type=int, dest="wport", default=8081,
         metavar="PORT",
-        help="Mitmweb port."
+        help="Mitmweb port. (default: 8081)"
     )
     group.add_argument(
         "--wiface",

The plan is to use Electron (or something along those lines) for mitmweb, which should solve this issue.

I used lsof to find that :-)

Closing this for now, mitmweb usability is generally not tackled yet.


Bubble up stale violation errors

Changed build_stale_violations to return errors instead of panicking

Ping me when lint is fixed :)


[SPARK-10761] Refactor DiskBlockObjectWriter to not require BlockId

The DiskBlockObjectWriter constructor took a BlockId parameter but never used it. As part of some general cleanup in these interfaces, this patch refactors its constructor to eliminate this parameter.

Merged build triggered.

Merged build started.

Test build #42861 has started for   PR 8871 at commit a73aa19.

Test build #42861 has finished for   PR 8871 at commit a73aa19.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42861/
Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #42864 has started for   PR 8871 at commit a73aa19.

Test build #42864 has finished for   PR 8871 at commit a73aa19.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42864/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

I've merged this in master.


Fix and improvements for Arduino Uno

fix: Cannot open Arduino Uno (ACM CDC),
fix: Cannot upload (download) HEX file to Arduino Uno,
improve performance for ACM CDC, and
fix typo.

refs https://github.com/ksksue/PhysicaloidLibrary/pull/10

v1.0.2


Proper error handling in bench routes

Is your feature request related to a problem? Please describe.
As all of us might know, stack traces are very little useful in determining errors in golang, mostly
if we have a complex long running application.
Describe the solution you'd like
Inspired by Error handling in Upspin, we should have a proper defined error interface/struct so that we can build, classify and query errors all the errors in our project. This means to have a unified single error handler for all our errors which  can be filtered as types.

May I work on this issue @Harkishen-Singh ?

@rohitgeddam are you still working on this? Could you give some updates here.

@Rits1272 you can go ahead.

@Rits1272 Are you working on this?
May I work on this?

Sorry for the recent inactivity on my part @Sanketwable, I am still working on the issue :)

OK thanks 🙃

@Rits1272 hey! Are you still working on it?

You  may go ahead @kritarthmehra

Can i work on this issue?

Yea go ahead. @rounakkumarsingh


aws-sso-cli: 1.15.1 -> 1.16.1

Description of changes
https://github.com/synfinatic/aws-sso-cli/compare/v1.15.1...v1.16.1

add getent to nativeCheckInputs needed for new upstream test
skip TestDetectShellBash on Darwin (requires dscl)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 321816 run on aarch64-darwin 1

1 package built:

aws-sso-cli

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4150


fix: filterOptions for upload fields

Description
Fixes uploads filterOptions not being respected in the Payload admin UI.
Needs a test written, fixes to types in build, as well as any tests that fail due to this change in CI.

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Not sure what was fixed , this was working o.k. for us before ,
One thing which could help is if we can get the filter in UI so user can see it when opening the Upload UI ,
Wherever user can change it or now can be parameter.


Gem bonuses only applying when held in hand and not working well worn

Minecraft Version
1.20.x
Mod Loader Version
fabric 0.15.7
Mod Version
1.0.2
Describe the Issue
Gem bonuses only apply when held, this includes gems equipped to Armor.
latest.log
nil
Do you use any other mods except the required ones?
TieredZ and LevelZ were the only mods used outside the required ones for my recent test

Fixed with https://github.com/Globox1997/SmitherZ/commit/0fae6608cf6a8c1541719f980fbae2c86731ebea


Fixed SetTaskParameters

(Although SetTaskParameters might be rewritten later,) fixing CallPutJSON is mandatory for TW next project.
also I'll appreciate if I can get permission to write to mujin repositories

(Did test/settaskparameters.cpp ever worked??? I should check it first. Also I need to add double-quote to info.program.)


[Team 3] Cursor customization, button texture change and pause/resume button addition

Description
Task: Combine Customize the cursor, Change buttons according to Design Committee Guidelines, and Add Pause & Resume Button tasks.
Feature: UI #164
This task involves enhancing the user interface of the application by customizing the cursor, changing buttons to align with the Design Committee Guidelines, and adding a Pause & Resume Button The buttons will be updated to match the design guidelines, ensuring consistency and aesthetics.
Dependencies
Design Committee Guidelines review
Milestones
List of steps that need to be completed for this task.
Cursor:

[ ] Implementing the code for Custom Cursor (Sept. 17)
[ ] Adding Design of Custom Cursor (Sept. 18)

Buttons(universal):

[ ] Create a method to implement button texture universally(Sept. 20)
[ ] Update buttons according to Design Committee Guidelines (Sept. 21)

Pause and resume button and screen:

[ ] Implement Pause & Resume Button (Sept. 25)
[ ] Create Menu for Pause & Resume(Sept. 27)

Completion Deadline: Sept. 30
Documentation

UI
Animations
Settings

Members

Moksh (@Moksh-Mehta7 ) (Moksh Mehta)

This issue is out of scope for external UI, this falls under in-game UI #170

This issue is out of scope for external UI, this falls under in-game UI #170

Ok, we will accommodate the changes


Create a AWS Batch JobQueue Runner

Hi,
I would like to add support for AWS Batch JobQueue.

I don't know cloud technologies very well but probably dask-cloudprovider could be a better suited project to ask this kind of questions ?
I am going to close this one, feel free to reopen if you fell I have missed something.


Spanner connector

This PR

adds support for a Spanner connector.
fixes a minor bug with temp file handling on Windows

@hardikmaheshwari - Can I please get an initial review ?


Fix install

Summary of Changes
During testing in a clean environment, I encountered 2 issues:

Unnecessary Import in __init__.py:
I noticed that matplotlib was imported in __init__.py but is not used. I've removed this unnecessary import to fix the install issue.

Missing numpy as a Dependency:
While numpy is not explicitly listed as a dependency, it is required for PyTorch internals. To fix the PyTorch failed import, I added numpy to the dependencies list.

I also added the missing matplotlib import in README.md
Changes Made

Removed the unnecessary matplotlib import from __init__.py.
Add numpy to the dependencies.
Updated README.md to include the missing matplotlib import in the example code.

@koaning Anything else to change ?

Nah, but I had assumed you would merge it yourself since it was already approved. Will do so now. Thanks for the PR!


Please confirm License

Could you please confirm what license this is under?
Judging by the parent MIT project this is also a MIT license, but there's no License file included.

Oh whoops! I'll add the MIT license soon.


Executing a DLC based on an RGB asset.

RGB is a protocol that brings tokens to bitcoin. On a call with some of the RGB developers today, we proposed it would really be interesting to do a DLC for an RGB asset.
This issue is meant to discuss what it would take to do this from an engineering point of view, and to keep track of lessons learned with integrating another bitcoin application into DLCs. I'm tagging the RGB developers to comment on this issue to centralize discussion.

With RGB, you do not need to follow bitcoin transaction graph; the only requirements in its terms are:

transaction spending some output with asset must contain a commitment (i.e. one of its public key in one of the outputs will be tweaked)
you have to make sure that assignments are done to the transactions which are mined; otherwise both commitment and assets must be part of the same transaction (to prevent the risk of funds loss)

Correct me if I am wrong, but DLC onchain works as a kind of “payment channel” (multiparty, unlike Lightning), with funding transaction being on-chain, and the rest (until contract closure) being ephemeral
So, funding transaction output must contain RGB asset(s) for sure (multiple assets if you do RGB-to-RGB DLC). This output is spent in CET (and later mutual closing or refund transactions). CET outputs can be spent by penalty transaction or unilateral closing transaction. CET is ephemeral; all other transactions are valid when mined (i.e. not pre-signed). Hence, all transactions exept of funding tx MUST contain tweaked public key with commitment (funding MAY contain it).
Also, it is required to remember, that while tx fee is always paid in bitcoins, the contract assets may be different, so they need separate fields in p2p protocol messages accounting the case when amounts in these fields will have different backing asset (so DLC funds must have asset and value; while for fee only value is sufficient)

In RGB when you have multiple keys involved you have a freedom to choose which key to tweak, so no need to tweak oracle key, and only one of the participant may apply the tweak. Alternatively, we may introduce another key, which will not be used in tx spending requirements and will play a “tweak holder” role (it increases tx size, but only if CET is getting onchain, which is not a normal case)

I don't think I'm fully understanding your explanation but I will explain our end which is really quite simple:
Funding transaction has inputs from both parties and 3 outputs:
Funding Output
2 change outputs
Off-chain there are many CETs spending the funding output and outputting directly to user-controlled payout addresses
DLC is enforced by giving counter-party adaptor signatures of CETs rather than normal signatures, using the oracle signature point as the tweak, this means that only one CET will ever become valid as all other CETs will be missing a valid signature (adaptor signatures are not valid bitcoin signatures).
(There is also a refund transaction which has a large nLockTime value on it)
P.S. we no longer have any penalty or mutual close or anything like this as they are not needed because force close with adaptor signatures looks exactly the same as mutual close

From @dr-orlovsky

So, for DLC+RGB we need to:

tweak one of the public keys in funding transaction (or add third “nonce” key, which will require script modification, but save one party from the need of applying tweak when creating signature, which will require DLC code modification),
add/remove 1-n satoshis from transaction fees (where N is the number of outputs), and during fee negotiation use N as a fee negotiation step
tweak public key used for one of the outputs in the rest of transactions (as in (1) this can be a “dumb/nonce” key, or a key of one of the parties)


Upload Hosted Content for In App Purchases?

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
This is more of a new feature request. While I can use deliver to upload packages for an app, or spaceship to create new in app purchases in iTC, I'd like to be able to upload a .pkg file for Apple to host my in app purchase content.
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

[INSERT OUTPUT HERE]
Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.4

Ruby
2.2.4

Bundler?
false

Git
git version 2.11.0 (Apple Git-81)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.12.4 (16E195)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
false

Is homebrew
true

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.3.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
No Fastfile found
`./Appfile`
app_identifier "com.brillicity.alllaws" # The bundle identifier of your app
apple_id<EMAIL_ADDRESS># Your Apple email address

# You can uncomment the lines below and add your own
# team selection in case you're in multiple teams
team_name "Tomer Shvueli"
team_id "5U298732TP"

# To select a team for iTunes Connect use
# itc_team_name "Tomer Shvueli"
# itc_team_id "5U298732TP"```

### fastlane gems

| Gem      | Version | Update-Status |
| -------- | ------- | ------------- |
| fastlane | 2.28.9  | ✅ Up-To-Date  |

### Loaded fastlane plugins:

**No plugins Loaded**

Loaded gems

| Gem                       | Version      |
| ------------------------- | ------------ |
| slack-notifier            | 1.5.1        |
| CFPropertyList            | 2.3.5        |
| claide                    | 1.0.1        |
| colored2                  | 3.1.2        |
| nanaimo                   | 0.2.3        |
| xcodeproj                 | 1.4.4        |
| rouge                     | 1.11.1       |
| xcpretty                  | 0.2.4        |
| terminal-notifier         | 1.7.1        |
| unicode-display_width     | 1.1.3        |
| terminal-table            | 1.7.3        |
| plist                     | 3.2.0        |
| public_suffix             | 2.0.5        |
| addressable               | 2.5.0        |
| multipart-post            | 2.0.0        |
| word_wrap                 | 1.0.0        |
| tty-screen                | 0.5.0        |
| babosa                    | 1.0.2        |
| colored                   | 1.2          |
| highline                  | 1.7.8        |
| commander-fastlane        | 4.4.4        |
| excon                     | 0.54.0       |
| faraday                   | 0.11.0       |
| unf_ext                   | <IP_ADDRESS>      |
| unf                       | 0.1.4        |
| domain_name               | 0.5.20161129 |
| http-cookie               | 1.0.3        |
| faraday-cookie_jar        | 0.0.6        |
| fastimage                 | 2.0.1        |
| gh_inspector              | 1.0.3        |
| uber                      | 0.0.15       |
| representable             | 2.3.0        |
| retriable                 | 2.1.0        |
| mime-types-data           | 3.2016.0521  |
| mime-types                | 3.1          |
| hurley                    | 0.2          |
| little-plugger            | 1.1.4        |
| multi_json                | 1.12.1       |
| logging                   | 2.1.0        |
| jwt                       | 1.5.6        |
| memoist                   | 0.15.0       |
| os                        | 0.9.6        |
| signet                    | 0.7.3        |
| googleauth                | 0.5.1        |
| httpclient                | 2.8.3        |
| google-api-client         | 0.9.26       |
| json                      | 1.8.1        |
| mini_magick               | 4.5.1        |
| multi_xml                 | 0.6.0        |
| rubyzip                   | 1.2.0        |
| security                  | 0.1.3        |
| xcpretty-travis-formatter | 0.0.4        |
| dotenv                    | 2.2.0        |
| bundler                   | 1.14.3       |
| faraday_middleware        | <IP_ADDRESS>     |

*generated on:* **2017-05-07**

Hey, thanks for letting us know about this. We'd love to have every fastlane feature work for macOS apps, however we're currently focusing our time to make fastlane the best tool for iOS and Android apps. Some of the features might work for macOS apps, however not all of them.
Thanks for understanding.

Hey KrauseFx, thanks for the response. I'm actually talking about in app purchases for iOS apps :)

This is more of a new feature request. While I can use deliver to upload packages for an app, or spaceship to create new in app purchases in iTC, I'd like to be able to upload a .pkg file for Apple to host my in app purchase content.

I didn't know you could host a pkg file, isn't that used for macOS apps only?

Nope, I've been using this for non consumable IAP for my app. In my use case, Apple hosts JSON files for me that are downloaded through an in app purchases and then ingested through the app. More here: https://developer.apple.com/library/content/documentation/LanguagesUtilities/Conceptual/iTunesConnectInAppPurchase_Guide/Chapters/CreatingInAppPurchaseProducts.html#//apple_ref/doc/uid/TP40013727-CH3-SW4

Interesting. That's not something you can currently do with fastlane, sorry. You're actually the first one to request this, so I'll leave this issue open and we can see if other people are interested in it as well.

That sounds good, thanks for the consideration!

This feature is still absent from the feature-set that fastlane provides.


Fix bowling description text case and typo

I noticed some inconsistent casing in the test descriptions for this exercise.

And indeed, it appears that most descriptions are lowercase.


fix refreshrequest to be once in an operation only

Right now, refreshrequests are sent for each qubit being altered in a gate.
By the time the Cloud comes back with a solution, the other qubits have their gates assigned, but since the refreshrequest wasn't cleared yet, no new calculation is requested.

fixed by https://github.com/gluonhq/strangefx/commit/46700e5bc450438b666f3fd764b7fb00a1f768de


TABLE_TYPE needs to be returned and defined according to the jdbc standard

TABLE_TYPE is currently returned as BASE TABLE in databend, but in the java jdbc standard, the return value should be TABLE.
https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getTableTypes--
I copy part of the source codes in java.sql.DatabaseMetaData:
    /**
     * Retrieves the table types available in this database.  The results
     * are ordered by table type.
     *
     *
The table type is:
     *

     *
TABLE_TYPE String {@code =>} table type.  Typical types are "TABLE",
     *                  "VIEW", "SYSTEM TABLE", "GLOBAL TEMPORARY",
     *                  "LOCAL TEMPORARY", "ALIAS", "SYNONYM".
     *

     *
     * @return a {@code ResultSet} object in which each row has a
     *         single {@code String} column that is a table type
     * @throws SQLException if a database access error occurs
     */
    ResultSet getTableTypes() throws SQLException;

MySql related codes:
https://github.com/mysql/mysql-connector-j/blob/7b6f9a337afe6ccb41823df485bf848ca7952b09/src/main/user-impl/java/com/mysql/cj/jdbc/DatabaseMetaData.java#L610-l613
    /**
     * Enumeration for Table Types
     */
    protected enum TableType {
        LOCAL_TEMPORARY("LOCAL TEMPORARY"), SYSTEM_TABLE("SYSTEM TABLE"), SYSTEM_VIEW("SYSTEM VIEW"), TABLE("TABLE", new String[] { "BASE TABLE" }),
        VIEW("VIEW"), UNKNOWN("UNKNOWN");

@cdmikechen HI, the table type in databend is define in information_schema.tables, you can use SELECT table_type as table_type FROM information_schema.tables GROUP BY table_type ORDER BY table_type to get it.  Databend jdbc just get from databend directly.  IMHO, we can convert BASE TABLE to TABLE but I will talk with databend developer why databend use BASE TABLE  instead of TABLE.

@cdmikechen HI, the table type in databend is define in information_schema.tables, you can use SELECT table_type as table_type FROM information_schema.tables GROUP BY table_type ORDER BY table_type to get it. Databend jdbc just get from databend directly. IMHO, we can convert BASE TABLE to TABLE but I will talk with databend developer why databend use BASE TABLE instead of TABLE.

@hantmac
I created a new PR https://github.com/databendcloud/databend-jdbc/pull/91 .
Using information_schema.tables in MySQL returns table type BASE TABLE as well, so I don't think the databend server should need to be modified, but rather on the jdbc


BUG + Solution: Typechecker crash

bug: TypeChecker crashes (ungracefully) on certain ill-typed terms
how to reproduce: In interactive mode, enter: fix (f: Nat -> Nat) (x: Nat) -> fun (y: Nat) -> x
which halts execution and prompts the message: INTERNAL ERROR: openN: M is not LC
Similarly, entering fix (f: Nat -> Nat -> Nat) (x: Nat) -> x
yields Error de tipo en (Bound 0)
solution
In function tc from module TypeChecker (case definition for Fix)
change the following lines (56 and 57) from this:
         ty' <- tc (openN [f, x] t) ((x,xty):(f,fty):bs)
         expect cod ty' t

to this:
         let t' = openN [f, x] t
         ty' <- tc t' ((x,xty):(f,fty):bs)
         expect cod ty' t'

explanation: if cod and ty' mismatch, expect tries to pretty-print term t, which should have been previously opened.

Gracias Román!


Allow a program to register for notification of context change

Create a protocol for how a third party app can register for context change notifications.  The target app should be able to tell CP that it wishes to be notified of changes and how it should be called.  Two methods should be supported including a call to an external binary or via AppleScript.  CP should call the external app or use AppleScript with a single argument, the current context.

"rejected" for 1.x.x series, lets put this is 2.x.x at some point

I would like to suggest that this use the distributed notification center or already running apps.  If an app needs to be started, it would make sense for it to be kicked off as an action.  Is there a specific use-case that you had in mind that would need the notification of context change to notify if the app is already running and start it if it isn't?
Fwiw, distributed notification center is how i was able to implement an action that would change synergy configurations depending on context, working with SynergyKM to store and change the configurations, while CP would have it change.


chore: improve HashedStorage

let's get rid of the extra functions as suggested above. PR will need to be rebased once https://github.com/paradigmxyz/reth/pull/6066 is merged


Add assertion for .type()

Fixes #9 - Cherry-picked most from #105 so kudos to @Mrparkers

Merged


Optimise Scanner performance

This is a rebase of #207
✅ What I did:

squash of the commits
integrate the upstream changes about range reporting to fix the tests during the rebase process
remove Swift 3 from the build matrix

❌What I did not do:

benchmark if there is an actual performance improvement

@yonaskolb PR rebased and entry added to the changelog

So I did some benchmarking using SwagGen as a test harness and using XCTest to measure just the stencil file generation
Results in seconds:

0.11.0 - 0.24
#207 - 0.15
0.12.0 - 5.9
#228 (this pr) - 4.5

So while this PR improves things slightly it seems something was added after the original #207 that slowed down things even more.
After some more investigation it seems #167 caused the slowdown
before: 0.25
after: 6.1

@ilyapuchka as the author of #167 do you have any other insights here?

@yonaskolb I suppose something around here might have caused performance issues https://github.com/stencilproject/Stencil/pull/167/files#diff-91493e167a3f6240a7cc916d9504d439R25

I noticed recently that parsing things like func some() {{% some tag %} fails due to usage of {{%. I see that there are some changes to the parsing of starting tokens here and wonder if this is still the case with this change and, if so, if it can be addressed @Liquidsoul

I've tried to tokenize func some() {{% if %} using this updated Lexer and the existing one. Here is the results:

the new lexer does not handle this well and crashes even.
the old lexer fails to parse the if tag but does not stop the execution.

So the new lexer does solve the issue and introduces a new problem.
Instead of failing to capture the tag as in the old one the new lexer crashes.
I see that as a blocking regression.
The fact that we did not have a testing context showing the improvement in #207 makes it hard to see this as a working optimisation. And since the original author does not seem to use Stencil anymore maybe we should just drop this entirely, see if this reported again and just address the existing performance issue.
What do you think?

@yonaskolb can you create a PR with your performance tests?

#228 has been merged so this should be next.
#228 introduced a performance loss in this commit: 93ccc56
Investigate if String/Substring is the performance issue, and how to solve this.

@yonaskolb You've mentioned a few times that you timed the tests. Are you just running them locally and checking how long yourself (with time diff or something), or do you have an actual test case we could run on CI?

I've just been timing locally using an XCTest in SwagGen while pointing to specific Stencil commit. I don't know of a way to run performance tests on CI as to fail on performance regressions you need to set a baseline and that won't be stable across different machines

I don't think we need a test that "fails", more a test that might report the change, either in CI, or here in the PR. For example, SwiftLint reports performance changes in the PR: https://github.com/realm/SwiftLint/pull/2396.

Now that whole process would be a separate PR, but just for this commit, so we can test locally, a simple test that runs a few times, and logs the average time would be nice.

@Liquidsoul I created #235 for mentioned issue

So, going through the comments again:

#167 (error log improvements) added a massive slowdown, we should try to figure out why and solve this in a separate PR.
This PR seems to have a net positive effect, similar to the old #207.
Both this and the old #207 PR add a bug with {{%, this needs to be solved before merging this.
We need to decide what {{% ... should do, and add a test for it (see #235).
We need some form of performance tests to keep track of things.

@djbe the {{% error already exists in the current code base, this is not something that's introduced by this change.
However, as I said here, this PR introduces a crash instead of a parsing failure when there is a syntax error in the stencil file.
So as I said, if we want to implement this optimisation, we may wish to rewrite this to ensure that no regressions are introduced.

I get what you mean, but a crash is an order of magnitude worse. And like I said, it’s not really an error unless you define what the syntax should be for such edge cases.

Right, so I completely missed #230, which fixed the performance issues from #167 (error improvements).
I've rebased again, and rewritten the PR a bit to squeeze as much performance as I can. I've also fixed the crash, so parsing will continue when it encounters {{%. One thing of note is that the range = ... calculations (added with the error improvements) also impact performance a bit, so I've tried minimising those. Funnily enough, switching to Substrings where possible has a negative impact on performance 🤔.
Using @Liquidsoul's test method (SwaGen) this goes from (an average of) 0.656s to (an average of) 0.419s.

The new test will have to be updated to the Spectre 9.0 format

@yonaskolb What do you mean the new format? The only difference that I saw in that PR, was just an XCTestCase class added in each file, which this PR already has since it's been rebased on master.

Can we add a performance test?

I don't know, you can only really test it with really (really) large templates, or a whole bunch of templates. Maybe leave that for a separate PR?

we could just add whatever project you are using right now to measure improvement and use its templates in a test?

I'm using SwaGen (what @yonaskolb was using), it's a whole project, with a whole bunch of templates, and the test isn't perfect as it's a full render, not just the lexer.

I've added a performance test based on the template in #224, repeated a few times 😆.
There's no reporting yet, we'll leave that for a different PR (Danger).

@yonaskolb @ilyapuchka any final thoughts? I'd be ideal to have this in for 0.13.


Motion Example component design & spec

Motion Example (video now, replacing SVG animation on the old site), need designs and spec prepared for development.

Motion Example component
For Sketchfile of Motion Page and Component spec, see issue #476

Revised motion page component spec
Ready for development.

Closing design issue. Dev issue #508


Remove "country" from changelog

Self-explanatory.

Codecov Report

Merging #868 into dev will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #868      +/-   ##
============================================
- Coverage     48.69%   48.63%   -0.07%
+ Complexity     2797     2791       -6
============================================
  Files           116      116
  Lines         27875    27875
  Branches       4650     4650
============================================
- Hits          13575    13556      -19
- Misses        12095    12111      +16
- Partials       2205     2208       +3

Flag
Coverage Δ
Complexity Δ

#JDBC42
48.13% <ø> (-0.08%)
2750 <ø> (-4)

#JDBC43
48.55% <ø> (-0.03%)
2789 <ø> (ø)

Impacted Files
Coverage Δ
Complexity Δ

...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
40.65% <0%> (-3.3%)
13% <0%> (-2%)

...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java
58.33% <0%> (-1.2%)
33% <0%> (-1%)

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
45.29% <0%> (-0.44%)
107% <0%> (-1%)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
32.42% <0%> (-0.35%)
253% <0%> (-3%)

...n/java/com/microsoft/sqlserver/jdbc/Parameter.java
64.12% <0%> (-0.21%)
64% <0%> (ø)

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
56.12% <0%> (-0.17%)
0% <0%> (ø)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
62.57% <0%> (+0.05%)
0% <0%> (ø)
:arrow_down:

...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java
79.48% <0%> (+0.19%)
5% <0%> (+1%)
:arrow_up:

...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java
39% <0%> (+0.21%)
43% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b331c3b...219491c. Read the comment docs.


Improve logging support

There are lots of times when it would be nice to increase logging in various ways. A common problem is having a json object not decode as expected or a field to be set in an unexpected way.

There's currently some logging support: it's missing some important bits (especially errors!) but each ConnectionData value has an optional Logger field, which is a function that can be called with certain kinds of log events. Additionally, there are several different predefined Logger functions in Network.Mattermost.Logging, including some which take a filter to decide which messages to log. This can be useful if you're interested in a particular log message, or messages from a particular function, e.g.
let myLogger l = mmLoggerDebugFilter $ \ l -> logFunction l == "mmPost"
let cd' = connectionData `withLogger` myLogger

will only log events that arise from the function mmPost.
I'm going to leave the issue open, but am leaving this comment to note that it's currently in progress.

Thanks for working on this!
BTW, it looks like you might have some uncommitted changes: https://travis-ci.org/dagit/mattermost-api/jobs/155790663

We now log websocket events, pings, pongs, &c. Accordingly, I think it's safe to close this issue—we just need to be sure to include logging in any new functions/endpoints we include.


change key id algorithm to hexdigit(sha256(cjson(public_key)))

The spec in section 4.2 defines that key ids are calculated using hexdigit(sha256(cjson(public_key))).
Note this PR is layered on top of #200 to simplify landing multiple patches.
Closes #150

Rebased on top of master (and #200).

Closing in favor of #203 to simplify reviews.


Api Controller TTenant Always null

When i use the following code in a api controller then the tenant will be always null also in the Sample Code
public IHttpActionResult Get()
        {
            var tenant = Request.GetTenant<AppTenant>();
            return Ok(tenant);
        }

I have found the problem and it's not a real problem in saaskit but more in the behavior of win..
You need to setup saaskit before you setup the webapi in startup.cs then it works

Yes, the order in which you register your middleware is important. The WebAPI OWIN adapter ends the pipeline.


Allow download caching

I think it is desirable to cache source code downloads and not delete them by running make clean. In all other projects I know, running make clean only removes the output files. Why remove base/.repo? Maybe it makes sense to have this configurable?

Yeah clean should only clean binaries. I think this is always the case now, but if not feel free to reopen


Certain Turing machine configurations cause site to crash

Description of the bug
On certain configurations of Turing machines, opening the testing lab causes the site to freeze and crash.
To reproduce
Unsure exactly what is causing this behaviour, but constructing a machine like the below causes the crashing. Removing any of the transitions in this machine causes the crashing to stop.

Expected behavior
No crash :)
Additional information
No response

Hmm this is similar to #410. Since there's no final state and and there is a cycle of lambdas from the source node the simulation would just search forever (since when you open the testing lab fresh you have the input of just lambda, so the tape is full of infinite lambdas). I think the proposed solution is to keep a counter on the search and ask the user "I expanded 10000 nodes, continue?" or similar.

hmm right that'd make sense, I initially had a final state, although that was also crashing, I tried to reduce this to the minimum number of states while still encountering this - wondering if the computation has to happen instantly? I was just wanting to step through one by one but it seems to apply the entire computation as soon as lab is open?

hmm right that'd make sense, I initially had a final state, although that was also crashing, I tried to reduce this to the minimum number of states while still encountering this - wondering if the computation has to happen instantly? I was just wanting to step through one by one but it seems to apply the entire computation as soon as lab is open?

No I don't think it needs to happen immediately either. I think that it should operate like the stepping lab which would likely solve both the infinite looping problem, since it's user directed, and the input finishing prematurely on TMs when a final state has an out transition, as that should just run a get successors each step. Kinda wishing I looked more closely at this now, but I'll wait to see what James wants to do with the project.

I do get a similar error with a PDA:

So the "Killer Machines" behaviour isn't unique to TMs it seems...

Don't really take much. Think its just down to the design where it requires the machine to finish before showing the steps.
e.g. This PDA causes the problem since it can keep adding to the stack

Maybe making the simulation code lazily evaluate/have step limit would solve it?

This was one of the issues we faced when implementing FSA (and the code was rewritten since I believe) - I originally used a step limit of 100 but that wasn't a good idea because it's technically possible to construct a valid machine that would break by this logic (e.g. a massive machine that goes like 150 states of lambdas).
I don't think lazy evaluation is what we want here because the skip to end button will need to evaluate everything and will still break it since there is no outcome.
Not really sure how to approach this, I thought we had something to do with transitive states and knowing what is reachable, but that might also only be applicable for FSA

Combo of lazily eval and then check if its ok with the user like JFLAP has could work

Check after 1000, 2000, 4000, etc

I know this is basically the premise of the halting problem but would it be possible to detect cycles for something like this? I've always found that JFLAP feature to be a bit gross

Cycles are already detected since the BFS tracks already seen states. The PDA I showed isn't stuck in a cycle since it keeps creating new states (The stack just keeps growing).
Maybe query chatGPT and ask it if it thinks the machine will halt or not 😜

Right yeah slight mess up in terminology from me, but I still feel like it could be possible to detect
If ChatGPT could work it out, I'm sure it's possible 😤

I don't have a good idea of how/what you need to detect, but maybe someone smart can work it out (if it's even possible) :^)

Hmm how does knowing all the transitions help to solve this issue? I'd assume that's what's happening under the hood to pick the accepted path, just not being exposed to the user because we want to keep things simple and only show the end state if accepted

Let me try to explain my idea with images. Taking the original killer machine:

The original machine has 3 paths:
0,0;R
1,1;R
λ,λ;R
If we feed to the simulator the TM with whichever path we just took removed (if we went from qX -> qX), we avoid infinite recursion, but we also force the looking of other paths in the same sim. I.e. if the sim in the case of the PDA I posted, it would at some stage be forced to succeed (if I remember my CT properly) on the string "aba" by default. The idea being to then take the arrows in the image and present them to the user as "choices" if applicable
Drawing this out, there are definite challenges to this design. First of all being that the tape is not considered. If we had a tape [1] [1] [1] [λ] on the original machine, following the diagram means that the machine will incorrectly halt when trying to return to the first '1'. Second is with the turquoise arrows, if this was implemented there would have to be a way to check that we aren't cycling between the two infinitely (because we are back to the same problem)
Maybe I am chasing my own tail and/or trying to overcomplicate the issue?
I guess the alternative is "If transition X goes from qY to qY Z times, then prevent X from being taken again (for now), but show the user that the result of doing X ∞ times is probably un-halting/inconclusive". This sounds way simpler... but still needs the knowledge of all transitions in the machine. I guess you can implement this as above images show. Perhaps that was the idea I had but lost my head when explaining

Not sure I fully understand, I don't really get how removing a certain transition would avoid infinite recursion, and I'd expect that to even give incorrect results but I'm sure there's something that hasn't clicked for me yet 😔 While I don't really get it 😓, if you think it'll work I say give it a shot
Thinking about it, the arbitrary limit of 100/1000 visits to the same state(s) could also be an okay solution if the above doesn't work (even though it's a bandaid solution), and since I originally had that logic in there I don't think it should be too hard to put it back in - I don't like it but it's better than trying to whip up a machine and having the whole site just crash on you :(
Also something else to note is that I believe this was happening when I opened the testing lab, not even clicking any buttons

Yeah I experienced the same with the PDA I posted - open test lab -> rip.
Give me a week (hopefully) to consider my life and I'll get back to you on its feasibility. This will hopefully include code mockups and HD diagrams which should increase clarity. Or I'll go insane. Whichever first I guess

Avengers assemble

Haven't been able to think it out yet but something interesting (if we can't solve it in time) is that the program doesn't crash if you are already in the testing lab

I'd presume that maybe the computation happens when you press one of the buttons, or when you first open the lab (otherwise the computation would be happening after every change to the automaton which we don't want)
Not sure if we really need to run that computation when opening the testing lab for the first time anyway but that's pretty minor


Update reference.md to 2023-10-01-preview

Added:
Latest Preview API Spec to Completions, Embeddings and Chat Completions.
Fixed:
Missing 2023-09-01-preview from Embeddings and Chat Completions.

@mrbullwinkle
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

email and Teams msg to author

Apologies that we missed this one. Going to close this out due to the merge conflict and follow-up with a separate PR to address.

#please-close


Allow volunteers to specify child age ranges

As a volunteer, I want to set my preference regarding the age range of kids I work with, so that I can have a more positive experience.

Age ranges should be 0-2, 3-5, 6-9, 10-12,  and Teen.  Users should be able to select as many as they'd like.


tighten the types in the incremental provider some more

Happened to see that there was some more opportunity to move to the proper types. Gonna piggyback on the changeset from #27972

see description, piggybacks on a different just merged thing


New HA core update has broken this

Hiya, it looks like the new HA core update has broken this integration. Devices are not detected anymore, can you have a look at what is affecting it?
Thanks

Nevermind...pushing the actual physical button of the switch made it work again...just assumed that it was the new update problem.


Creating new JS project provides old task.json

Not really a bug, but it's a bit disorienting.
Repro steps:

Have an empty workspace
Create a new JavaScript project in an empty folder
Add to workspace
tasks.json defaults to v1 runtime and immediately prompts the user to update tasks.json

Expected: To have to proper tasks.json for v2 (the default)
Actual: Returns the v1 tasks.json

Never mind probably a user settings issue.  Cannot repro.


JavaScript error: $detailModal.find is not a function

Description

click details button, you will see this error
caused by #30115
Gitea Version
latest
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
build
Database
None

My bad, should have seen this during review.