Fix host

Added host to author model. (Had to add after signup form is posted, but before it is saved).

According to issue #56 , we also need to set displayName when new user are created. Could you please change it as well?

DisplayName is now set on login. Fixes #56

Looks good to me, we can probably merge this.

Looks good to me, we can probably merge this.

Thank Will. Merging now.


Microsoft Azure Insights

Azure Insights is an OpenTelemetry sever for Azure
There is this JAR but was hoping we could just switch easily between Jaeager locally and Azure in the environment.
<dependency>
      <groupId>com.microsoft.azure</groupId>
      <artifactId>applicationinsights-agent</artifactId>
      <version>${azure-applicationinsights.version}</version>
</dependency>

There is also this from OpenTelemetry itself: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/azuremonitorexporter

hey @melloware! I'm from the Azure Monitor Java team. Were you able to get things working with the Azure Monitor OpenTelemetry Exporter? Also, are you using native images (we are working on supporting that currently).
cc @jeanbisutti @heyams

That is great news! No I was waiting to hear back right now I use Quarkus open telemetry and Jaeger locally but would love to publish to Azure when deploying my app to AKS!
Do you have anything I can try?

Also not sure if you were aware of this Quarkiverse project supporting Azure services https://github.com/quarkiverse/quarkus-azure-services
Not sure if the azure monitor plug-in belongs there or in this extension.

We should add the exporter here similarly to what happens with the Micrometer registries: https://github.com/quarkiverse/quarkus-micrometer-registry

Will be working on this.

Awesome work!

@melloware Have you tried to deploy a Quarkus native image on Azure with the telemetry enabled? Would you have any feedback to share?

I have not yet @jeanbisutti what issue are you having?  Are you getting an error?  StackTrace?

@melloware I'm not having a problem. I was curious if you tried it and what you thought.

Oh nope not yet the Azure Quarkus project i was working on got pushed the back by the client.  i was doing everything with Jaeger OpenTelemetry while waiting on this Azure Insights support!


🐛 [firebase_auth] can't read keyset; the pref value , GenericIdpKeyset does not exist

Same issue as https://github.com/FirebaseExtended/flutterfire/issues/4651 which is closed. I'm receiving the below error when running integration test on firebase auth sms code verification with an android emulator:
E/zzf     ( 1131): Problem retrieving SafetyNet Token: 7:
I/zzdu    ( 1131): keyset not found, will generate a new one
I/zzdu    ( 1131): java.io.FileNotFoundException: can't read keyset; the pref value
GenericIdpKeyset does not exist

I've added the following dependency but that does not fix the issue when running integration tests
implementation "androidx.browser:browser:1.3.0"

@cedvdb
Looking at the error log you shared and linked issue, it seem to be coming from native android sdk and may not be an issue from client side.
As a side note, check this similar issue and see if it helps.
The original issue was closed based on native fix: https://github.com/FirebaseExtended/flutterfire/issues/4651#issuecomment-847821763
But since you are running integration test on firebase auth sms code verification with an android emulator, this might be having different implications. I suggest you to open issue in https://github.com/firebase/firebase-android-sdk/issues to see what they say.

@darshankawar one thing I know for sure is that flutter fire cli picked up the wrong API key for Android, which had not enough rights, EnCE why I had problems. This is a bug in the cli.
I can't say for sure if that is what gave this error message but it did prevent me from authenticating.
Just to be clear. My issue is resolved but there is an underlying bug in the cli.

@cedvdb
Thanks for the update. CLI related issues need to be opened in dedicated repo here: https://github.com/invertase/flutterfire_cli/issues
https://firebase.flutter.dev/docs/cli/#reporting-an-issue
Closing from here since your original issue is resolved.


Added Encodable#encode(encoding:) (#684)

Encode Encodable object to String directly.
Checklist 🚀

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 5.0.
[x] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
[x] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[x] I have added a changelog entry describing my changes.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 584 tests, with 0 failures (0 unexpected) in 10.937 (12.466) seconds

:book:
tvOS: Executed 559 tests, with 0 failures (0 unexpected) in 1.924 (2.434) seconds

:book:
macOS: Executed 424 tests, with 0 failures (0 unexpected) in 1.000 (1.400) seconds

  Generated by :no_entry_sign: Danger

Failed in linux-swift.
I should deploy this extension in Foundation. I will fix it soon.

same reason with #683


Dark theme not properly supported for export

Bug report
Codepen
See this codepen to explore it yourself.
Explanation
Basically the title:
When using the dark theme, PNG and SVG exports end up with a mix of dark and light theme, which renders them unusable. As far as I can tell, the main issue is the background being rendered white.
The resulting PNG download:

The screenshot, hence expected behaviour:

This happens for the SVG as well, however, using an SVG editor, one can post-process the font colors there.

I confirm the issue. It will be addressed soon.


add integration notebook

Integration notebook has been successfully run

@pablo-gar As the original parent branch has been merged to main (as a squash commit), github is now confused as the actual changes. I'm going to close and re-open this PR to get the correct diff.


CIV-3663 Update template to add Judge recital text

Before creating a pull request make sure that:

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-3663
Change description
Add Recital text in Judge request more info screen
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

CV-UNS-GAP-ENG-01072.docx

this is just purely updating document used for local development so merging it even thought the pipeline failed for random things


Panic when command list is empty

Hey, my list of commands is dynamically configured and in some cases it may be empty.
But I still need the version and help command to be executed. At the moment I'm getting the following panic:
panic("acmd: cannot run without commands")

Can you fix it?

You can add a hidden command. It will not be visible to a user but will prevent such panic.
This should work:
	cmds := []Command{
		{
			Name: "noop",
			ExecFunc: func(ctx context.Context, args []string) error { return nil },
			IsHidden: true,
		},
	}
	r := RunnerOf(cmds, ...


wrong download link in the archive page

Once the archive is generated on the Chinese mirror, the link it provides to the user doesn't work. The mirror is configured so that /iiif/ is the root of the iiif server, but the link is /download/file/zip/bdr:I0886:1-624 which goes somewhere else... The construction of the link should use the iiifserv_baseurl property of the configuration

Fixed as of commit 0b86765


Docs: Added missing semicolon

I don't believe that semicolon is necessary. We'll be adding prettier to the project to format all the docs in the future.


Flatpickr 404 (Not found)

flatpicker issue while loading the ng2-formio component page .May I know the configure requirements for flatpickr
Package.json:
"dependencies": {
"@angular/common": "^2.4.9",
"@angular/compiler": "^2.4.9",
"@angular/core": "^2.4.9",
"@angular/forms": "^2.4.9",
"@angular/http": "~2.0.1",
"@angular/platform-browser": "~2.0.1",
"@angular/platform-browser-dynamic": "~2.0.1",
"@angular/router": "~3.0.1",
"@angular/upgrade": "~2.0.1",
"@msafi/angular2-text-mask": "^0.7.0",
"angular-in-memory-web-api": "~0.1.1",
"angular2-signaturepad": "^2.2.0",
"angular2-text-mask": "^6.3.1",
"bootstrap": "^3.3.7",
"core-js": "^2.4.1",
"flatpickr": "^2.4.3",
"formio-utils": "^0.3.0",
"formiojs": "^2.0.0-alpha.9",
"ng2-bootstrap": "^1.4.0",
"ng2-formio": "^1.0.0-beta.1",
"ng2-modal": "0.0.21",
"ng2-popover": "0.0.14",
"ng2-popup": "^0.3.2",
"reflect-metadata": "^0.1.8",
"rxjs": "^5.2.0",
"signature_pad": "^1.5.3",
"systemjs": "0.19.39",
"zone.js": "^0.8.0"
},
systemjs.config.js
map: {
app: 'app', // our app is within the app folder
............
'flatpickr': 'npm:flatpickr/dist/flatpickr.js', //newly added
}
app.module.ts
whether I have to import flatpickr in app.module ??

Closed due to no activity.


Getting error mocking intter final class with PowerMock and Mockito

From<EMAIL_ADDRESS>on April 07, 2013 18:01:53
What steps will reproduce the problem? 1. Create a class to test that calls remote REST endpoing using com.sun.jersey.api.client.WebResource: webResource.path("url").accept(MediaType.APPLICATION_XML_TYPE).get(String.class);
2. Create a unit test for that class with the @PrepareForTest Attribute
3. Run the test
4. Error occurs with "Invalid length XXXX in LocalVariableTable" What is the expected output? What do you see instead? It should not throw an exception What version of the product are you using? On what operating system? OS: Win7
Java(TM) SE Runtime Environment (build 1.7.0_15-b03)
org.mockito:mockito-all:1.9.5
org.powermock:powermock-api-mockito:1.5
org.powermock:powermock-module-junit4:1.5
junit:junit:4.8.2
com.sun.jersey:jersey-client:1.9.1:compile Please provide any additional information below. I tried also on Java(TM) SE Runtime Environment (build 1.6.0_33-b03) with the same result
Similar to https://code.google.com/p/powermock/issues/detail?id=266
Original issue: http://code.google.com/p/powermock/issues/detail?id=438

From<EMAIL_ADDRESS>on April 09, 2013 04:26:25
I faced the same issue when I was trying to mock WebResource.Builder class, which is public final inner in jersey-client 1.9.1. Finally I updated jersey to 1.17 where this class is not final any more. Not sure if PowerMock is able to mock final inner classes.


When pressing + on heat the heat temp will drop out of blue, have to press + again

The only issue I have seen is when increasing the heat it will drop to a lower level.  So your basically fighting it to increase heat.  The room temperature can be 75 and the heat set to 72, so if you want to increase to 78 you start to hit the +.  You press + 4 times to get 76 but it will then change to 72 or 73.  Press + again from the changed temperature and it changes again.  So you are constantly fighting to reach the correct temperature and the heater will turn on / off depending what it drops to.
Not using the cooling portion so unable to test.

Sending commands to the thermostat takes a couple of seconds. You need to wait for a few seconds after pressing "+" or "-" until the temperature adjustment is complete.


Introducing HealthcareApis

Adding HealthcareApis into Azure SDK.
This PR comprises of new modules for HealthcareApis that is used to manage HealthcareApis accounts such as (Get/Create/Update/Delete)
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

REST spec PR: Azure/azure-rest-api-specs-pr:
Azure/azure-rest-api-specs#5096
Azure/azure-rest-api-specs#6244

I closed the PR#6766 as suggested and opened this new one.

Please fix CI errors as well.

Updated the PR with the suggested changes. Also fixed the CI errors.


Add bookinfo traffic shifting tests

@vadimeisenbergibm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
dbdffaf86d4e226d1746ebfd4cd4f1f684bee4ce
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: vadimeisenbergibm, yutongz
Assign the PR to them by writing /assign @vadimeisenbergibm @yutongz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

why is there new html ? can you fill up the PR description ?

@ldemailly I have added the description.

@ldemailly Could you please approve the PR?

I don't understand why you need a brand new html ?

@ldemailly You have several htmls in https://github.com/istio/istio/tree/master/tests/apps/bookinfo/output:
a different html per combination of user/version of the reviews microservice. The htmls per version are different since you have different features in the html, for example stars with black or red color. The htmls per user are different since you have either test_user logged in:

            test-user  ( sign out )

or normal user logged in:

            normal-user  ( sign out )

I add a new combination (normal user, v2) to test, so I have to add a new html.

There should be a way to templatize those instead of copy-pasting big files but I guess... future cleanup (or I can't wait we move bookinfo out of istio/istio)

/lgtm
under duress :-)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ldemailly
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS [ldemailly]
tests/OWNERS [ldemailly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ldemailly

There should be a way to templatize those instead of copy-pasting big files but I guess... future cleanup (or I can't wait we move bookinfo out of istio/istio)

Let me fix it later, as part of bookinfo restructuring. Regarding moving bookinfo out of istio/istio, in general I am in favor of putting everything in a separate repo, and I did not like the merge of the Istio repositories into one. If there will be a decision to move bookinfo out of Istio, I would be glad to participate in its implementation.


(Docs) Add port to service-urls

Because we don't include <port> at the end of service-urls, users
might assume that they don't need to specify a port.
!no-release-note

CLA signed by all contributors.


Renamed all occurences of Data.xml to cus.xml in discopop_explorer

let me know if there is still some work left.

Checked all occurences of Data.xml and renamed to cus.xml in scripts and disco pop_explorer directories.


[Module Proposal]: avm-res-cache-redis (tf)

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-cache-redis
Module Details
Module name - avm-res-cache-redis
Github Repo name - terraform-avm-res-cache-redis
Terraform module for Redis Cache
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@jchancellor-ms
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:
For your module:
ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry
For your module's repository:
Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.
Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

@prjelesi - just an FYI - We need to make sure whatever is defining the repo name in the original request is accurate.  Went through the creation process before realizing the name was wrong.  terraform-azurerm-avm-res-cache-redis is the correct name instead of terraform-avm-res-cache-redis.

I would like to request a review of my module. The latest code is in a PR titled AVM-Review-PR on the module repo and all checks on that PR are passing.

Thank you for requesting a review of your module. The AVM module review process has been initiated, please perform the Requested Actions on the AVM-Review issue on the module repo.

The initial review of this module is complete and the module has been published to the registry. Requesting AVM team to close this module proposal and mark the module available in the module index.


Dimecasts Support

Episode

http://www.dimecasts.net/Content/WatchEpisode/205

Tag

http://www.dimecasts.net/Casts/ByTag/Linq2Sql

URL for the first video can be found at <source src=http://s3.amazonaws.com/Dimecasts/Episodes/episode.205/Stream_WebApi.ConsumingEndpoints.mp4 type='video/mp4' />

redirects now to a youtube channel.


feat: Add support in helm for asc-mqtt and asc-httpexport

Signed-off-by: Kyle Morton<EMAIL_ADDRESS>

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

@drkfmorton Please resolve merge conflict.


Loading CannonDebugRenderer and other Three Utils via NPM/Webpack Transpilation

Hello.
I am trying to use the Three.js debug renderer to draw meshes of cannon bodies. I was looking at https://github.com/schteppe/cannon.js/blob/master/tools/threejs/example.html
A number of dependencies appear to be loaded in the HTML before the example script is run
    <script src="../../libs/Three.js"></script>
    <script src="../../libs/Detector.js"></script>
    <script src="../../libs/TrackballControls.js"></script>
    <script src="../../build/cannon.js"></script>
    <script src="CannonDebugRenderer.js"></script>

I have two questions.

To use Three.js with this library, do I have to load it through the libs in this repository, or can I install it via NPM and import it the "traditional" way then use webpack to put it all together?

import * as THREE from 'three';
import * as CANNON from 'cannon';
import CannonDebugRenderer from '../node_modules/cannon/tools/threejs/CannonDebugRenderer.js'

I have not been having luck with the above. If I I am missing something small, and able to import Three.js as shown above (not from Cannon lib), how can I import/use CannonDebugRenderer? The above does not seem to work even though webpack is able to find all modules/classes and compile without warnings.
Specifically, I see the line
         cannonDebugRenderer = new THREE.CannonDebugRenderer(scene, world);
but if I am importing Three.js from node_modules, ie https://github.com/mrdoob/three.js/tree/dev/build , then I don't think the import includes the CannonDebugRenderer. Does this necessitate import from Cannon lib?

Disclaimer: I am pretty new to JS language/workflows, so I apologize if these are obvious questions.

The CannonDebugRenderer.js is not setup to handle esmodule imports, you can use cannon-es-debugger instead. Instructions are in the README.


clearer errors on nil/empty config values

@benburkert I've manually tested this, but we should probably add automated tests too. I wasn't quite sure where/how to fit that in to trigger the plugin start (where the errors originate), could use input or to at least talk through it.

I think the problem was largely elsewhere, namely: https://github.com/anchordotdev/rails-demo/pull/11


[FR]: Allow sorting tables by columns

Proposal summary
Allow sorting tables by any column: Projects, Datasets, Experiments and Feedback definitions
Motivation
To work with a significant amount of experiments/projects I need to be able to quickly sort by "Last Update" or "Name" for example.

Sorting has been released for the project table 🚀 Marking as done


Fix travis build error

There is some problem with the tls 1.2 support for travis that I couldn't get around.  This moves the R and arbor packages to midas and sets them up manually.

LGTM


Replaced Math.atan2 with atan2 table lookup implementation.

I changed the atan2 implementation of the AngleCalc to a TableLookup version that was provided by @karussell in https://github.com/graphhopper/graphhopper/commit/d64ab7b.
I compared the current master with this version using VisualVM. I used car with ch=fastest. Using the current master, It seems that the AngleCalc.calcOrientation was in the Top 10 of CPU time consuming methods of the overall route calculation. With the updated atan2 implementation AngleCalc.calcOrientation does not show up in the top 20 CPU time consuming method calls anymore. So it seems to me that this might fix the delay discussed in #1031.
The new atan2 implementation returns slightly different values to Math.atan2. I could not find any issues though. I needed to fix two tests. Also I had to add %360 operation, as with the new atan2 implementation we are returning 360 instead of 0. Tests expect 0, so I figured it might be better to do a modulo here instead of changing the tests and maybe introducing a bug in the code.

Would you do the comparison with the measurement script? (and an area with size like bavaria or saxonia). Then you can look into concrete numbers like routingCH.mean and routingCH_no_instr.mean for with and without this change.
I'm not sure if we should use it always, especially since we'd export this slightly wrong value to external consumers (Java/JSON API) for roundabouts (RoundaboutInstruction.setRadian)

Also I had to add %360 operation, as with the new atan2 implementation we are returning 360 instead of 0

Should we do the modulo operation for the root calcOrientation instead?

Here are the results of the measurement, I used: ./graphhopper.sh measurement baden-wuerttemberg-latest.osm.pbf. I ran it two times for every branch, master and speedup. There is a speedup, but it seems like that it is not the 20% we are looking for.

Runs
routingCH.mean
routingCH_no_instr.mean

speedup 1
2.4596033764
1.838547689

master 1
2.58897116
1.7966665841999998

speedup 2
2.305940648
1.6758486566

master 2
2.4005281016
1.7010407452

I'm not sure if we should use it always, especially since we'd export this slightly wrong value to external consumers (Java/JSON API) for roundabouts (RoundaboutInstruction.setRadian)

I can create create a parameter for the calcOrientation method like exact that is true per default, using a wrapper method, so no existing code gets broken.

Should we do the modulo operation for the root calcOrientation instead?

Mhm, might not be that easy. The case where it returns 360, is when calcOrientation returns a value slightly smaller than 0, like -.0000000000000001. That way we call Math.toDegrees((2 * Math.PI) - .0000000000000001) which returns 360.

There is a speedup, but it seems like that it is not the 20% we are looking for.

Indeed there is a speedup and I think there are further possibilities.
BTW: strange that you get such different values for the different runs. If you close all other applications and do two runs there shouldn't be a bigger difference than 5%

Mhm, might not be that easy.

ok

I investigated a bit further and when doing the angle calculation for every junction in the old code (https://github.com/graphhopper/graphhopper/commit/951b443) it got ~15% slower which is still ~5% faster than the state with this PR but explains a big part of the slow down. We could do some pre-calculation on import for the angle stuff, but for now I think this is ok.
Maybe you can have a second look if we avoid the loop in getOtherContinue over the edges leading to many tan2 calculations calls? And if not possible we keep it as it is with this PR and just introduce an exact=true parameter for the RoundaboutInstruction.setRadian
BTW: we currently do not cache the fetchWayGeometry calls (also many calls via getPointForOrientationCalculation), but temporarily replacing this with a fixed PointList did not speed up anything
BTW: line 213 looks very similar to the code in getPointForOrientationCalculation

BTW: line 213 looks very similar to the code in getPointForOrientationCalculation

Yes, but it does different things. Putting the logic into the getPointForOrientationCalculation is not worth the effort IMHO.

Maybe you can have a second look if we avoid the loop in getOtherContinue over the edges leading to many tan2 calculations calls?

I spent some time thinking about this a bit more. I came up with a heuristic that is a lot faster, but actually provides worse results, also a couple of tests fail. The idea is to use the current edge and use its point for orientation calculation as reference. Then we take the point for orientation calculation of the other edge and project it on a straight line to be equal distance than the other point. We then compare the distance between the points and the distance of the point to the base, if the points are closer to each other than to the base, this could be a continue. It might be easier to just read the code ;). So if we need speed, this could be used, but I wouldn't recommend it, as the results are worse.
I think the best would be to keep it as is and simply add the exact flag.

I forgot to add that the heuristic got about 10% speedup for ch with measurement and Baden-Württemberg, but before investing more time we should remeasure this as I only did one rin. Maybe somebody has a good idea on how to improve it, as the speedup might be worth it.

Putting the logic into the getPointForOrientationCalculation is not worth the effort IMHO.

ok

I think the best would be to keep it as is and simply add the exact flag.

:+1:

Ok, I added the exact flag, to make sure that we are actually doing the right thing, I reran the performance measures.
Master: routingCH.mean=2.426111127 routingCH_no_instr.mean=1.7078601832
PR: routingCH.mean=2.2701361754000002 routingCH_no_instr.mean=1.7059984101999999

Thanks!


Color Palette Exploration

Audit current UITK color palette vs Salt 1 (current) color palette vs Salt 2 (proposed) vs MasterBrand
Create in-situ comps for 1:1 comparison in both light and dark modes

2/8 - Exploration phase - auditing color palette, find way to modify current ones - something that will work across everything. Create plug in (zhihao) to streamline process

General Plan agreed, course of action being decided on. User Journeys being worked on. Contrast ratios under investigation.
Future Work: Get more realistic examples to use the proposed colors on.


Shuffle in labels layer broken in current master

🐛 Bug
In the current master, clicking shuffle in the labels layer has no effect.
To Reproduce
Steps to reproduce the behavior:

Open the viewer with a label layer. E.g. run examples/labels-2d.py
Select the labels layer
Click the suffle button

Expected behavior
Expected behaviour: label colours should change.
Environment
napari: 0.4.8.dev22+g8d77f01d
Platform: Linux-5.8.0-48-generic-x86_64-with-debian-bullseye-sid
System: Ubuntu 20.04.2 LTS
Python: 3.7.9 (default, Aug 31 2020, 12:42:55) [GCC 7.3.0]
Qt: 5.15.2
PyQt5: 5.15.2
NumPy: 1.19.5
SciPy: 1.6.0
Dask: 2021.01.1
VisPy: 0.6.6
OpenGL:

GL version: 4.6.0 NVIDIA 460.39
MAX_TEXTURE_SIZE: 32768

Screens:

screen 1: resolution 1920x1200, scale 1.0

Plugins:

affinder: 0.1.dev13+g89050b4
console: 0.0.2
napping: 0.1.2
scikit-image: 0.4.8.dev22+g8d77f01d
svg: 0.1.4

Just tested this in a fresh environment. This bug is not just on current master, it is also present in the 0.4.7 release. It is not present in 0.4.6 release.

Ok, this bug was introduced in the following commit @DragaDoncila
https://github.com/napari/napari/commit/f0e108ed4d0dda0317b361c7e76923931268a73b

Thanks for filing @VolkerH! Maybe @DragaDoncila can check this out when she gets the chance

I tracked it down to here:
https://github.com/napari/napari/blob/8d77f01da0da680344eed6b9e02c8e44cb032326/napari/layers/labels/labels.py#L716-L724
If I disable the code in the try block (which I don't fully understand) and instead run the code in the except IndexError block the shuffling is restored.

Ok, so there is no check whether the seed has changed. I think what needs to happen is that the setter for seed needs to somehow invalidate self._all_vals.

The try is seeing if all the labels have currently been mapped to colors. We should add some comments there too. When doing the shuffle (i.e. changing the seed) we need to remake the _all_vals map
If you add
     max_val = np.max(raw)
     self._all_vals = low_discrepancy_image(
         np.arange(max_val + 1), self._seed
     )
     self._all_vals[0] = 0

to the seed setter here then it should work
https://github.com/napari/napari/blob/8d77f01da0da680344eed6b9e02c8e44cb032326/napari/layers/labels/labels.py#L315
It's a little awkward with how to best get the max value - which is a limit of this approach. Curious what @jni or @DragaDoncila would recommend here too

Ok, so there is no check whether the seed has changed. I think what needs to happen is that the setter for seed needs to somehow invalidate self._all_vals.

Yup exactly! Beat me too it!!

if  I just add
self._all_vals = None

to the seed setter, the shuffle works as that causes the IndexError and therefore triggers the except block which restores a correct _all_vals. However, I am not deep enough into the code to oversee the potential side effects of that approach. It is probably bad style to force an Error to trigger an update.

ooo, very nice @VolkerH - I like that, i'm ok with None and re-triggering an update. Can you open a PR and then the others can review! Thanks for all this debugging

will do, give me a minute


removing Euler and adjacent chapters

After revisiting some older chapters, I have decided to remove the Euler chapter. This is because of the following reasons:

The chapter was not technically wrong, but it was very misleading as to how people truly implement Euer methods i practice. I think starting from the Taylor series makes sense from a physical point of view, but not mathematically
The code basically had the derivative hard-coded in, which is not how people often implement this.

I could re-work the chapter to keep the code, but I would need another chapter to link it to RK, Bakcwards Euler, or other methods. I think a full re-work is needed and is on the table in a few weeks when I am working on my next project (which will involve RK).

I would prefer not to delete this. I would rather unlink it on the site so that we may be able to use it later
Thoughts?

Sure, that's also fine


api, back: Standardize Geometry Representation in API Response and Backend Processing

This PR introduces changes to both the API specification and the backend processing of region geometries. The goal is to standardize the geometry data as MultiPolygon in GeoJSON format, ensuring consistency and reliability in the data we expose to our API consumers.
Changes
API Specification Update
The Swagger API specification (api.yaml) has been enhanced to define the expected geometry format strictly as a MultiPolygon. Additional descriptions have been added for each level of the array to clarify the structure of the GeoJSON object and the CRS being used.
The 200 response now references the newly defined MultiPolygonGeometry schema, which details the nested array structures and the CRS object.
Backend Geometry Processing Update
The regionController.js has been updated to convert any retrieved geometry to a MultiPolygon format. This ensures that the data conforms to the updated API specification and that clients can reliably process the geometry data.
Utilizing the ST_Multi function from PostGIS, the backend now uniformly processes all geometries as MultiPolygon, regardless of their initial format in the database.

Summary by CodeRabbit

Refactor

Enhanced the getGeometry function to convert the geometry to a MultiPolygon if it exists, improving data handling.

@coderabbitai review

@coderabbitai review

Close and recreate to make a new review


RT-AC86U

I have a similar problem as the previous bug reporters

get_wan_lan_status = { "portSpeed": { "WAN 0": "G", "LAN 1": "G", "LAN 2": "M", "LAN 3": "X", "LAN 4": "G" }, "portCount": { "wanCount": 1, "lanCount": 4 } };

Hi @NormKOALA ,
Thanks for your feedback! 👍🏻
Seem like one (or more) of the connected devices have some value non-recognizable as a boolean value.
Could you please run this python snippet from your HA venv or any other environment with AsusRouter library already installed? Just put the code to some local script.py (without forgetting to put in your values for _host and _password in it). Then run it with python3 script.py.
"""Small test for available data from your AsusRouter"""

from asusrouter import AsusRouter
import asyncio

async def gather_data(host, username, password, use_ssl):
    """Method to gether all the known data"""

    # Initialize
    router = AsusRouter(host = host, username = username, password = password, use_ssl = use_ssl)

    # Connect
    await router.connection.async_connect()

    # Get all the boolean data in raw
    data = await router.async_hook("get_clientlist()")
    for device in data["get_clientlist"]:
        try:
            info = data["get_clientlist"][device]
            print("IS: {}; IM: {}; IO: {}".format(info["internetState"], info["internetMode"], info["isOnline"]))
        except Exception as ex:
            break

    # Disconnect
    await router.connection.async_disconnect()

loop = asyncio.get_event_loop()

# Please, put your values in here
_host = "IP_or_hostname_here"
_username = "admin"
_password = "password"
_use_ssl = True

loop.run_until_complete(gather_data(_host, _username, _password, _use_ssl))

loop.close()

This would print data like this:
IS: 0; IM: block; IO: 1
IS: 1; IM: allow; IO: 1

1 line per each connected device. Need to find which one sends something else than 0, 1, allow and block

Thank you for answer.
Maybe I'm doing something wrong but it doesn't work.

No worries, that is probably my fault. It says that just cannot connect. One of the reasons could be that your router has a self-signed SSL certificate.
You can try changing to _use_ssl = False instead of True to connect without SSL.
Or, if your device doesn't have a non-SSL connection or uses a non-standard port, this is something to help. There are 2 new parameters: _cert_check = False and port = 0. The latest means using the default values of 80 or 8443 for non-SSL and SSL connections.
"""Small test for available data from your AsusRouter"""

from asusrouter import AsusRouter
import asyncio

async def gather_data(host, username, password, port, use_ssl, cert_check):
    """Method to gether all the known data"""

    # Initialize
    router = AsusRouter(host = host, username = username, password = password, port = port, use_ssl = use_ssl, cert_check = cert_check)

    # Connect
    await router.connection.async_connect()

    # Get all the boolean data in raw
    data = await router.async_hook("get_clientlist()")
    for device in data["get_clientlist"]:
        try:
            info = data["get_clientlist"][device]
            print("IS: {}; IM: {}; IO: {}".format(info["internetState"], info["internetMode"], info["isOnline"]))
        except Exception as ex:
            break

    # Disconnect
    await router.connection.async_disconnect()

loop = asyncio.get_event_loop()

# Please, put your values in here
_host = "IP_or_hostname_here"
_username = "admin"
_password = "password"
_port = 0
_use_ssl = True
_cert_check = False

loop.run_until_complete(gather_data(_host, _username, _password, _port, _use_ssl, _cert_check))

loop.close()

II hope, this will work. If not, we will find another way 🙂

With _use_ssl = False I got the following result
IS: 1; IM: allow; IO: 1
IS: 1; IM: allow; IO: 1
IS: 1; IM: allow; IO: 1
IS: 1; IM: allow; IO: 1
IS: 1; IM: allow; IO: 1

A bit weird. Seems like values are fine. But I suppose, integration still doesn't want to set up in HA
Those 3 values from each device are the only ones for which method bool_from_any is called. And it is the one causing the exception in your log. It does literally say it got value time and tried to parse it as boolean.
I'll do some tests with the code and will let you know a bit later, what else can we try

Hey, @NormKOALA ,
With the new 0.2.2 version, it is now possible to have partially parsed devices, so the problem you are experiencing won't be on the way to the integration set-up. But it will be generating warnings in the log with some additional info on which exactly values are wrong and what they report. So it would be easier to find the complete fix to this issue.
Could you try it?

Yes, now it works. Thank you!

it is now possible to have partially parsed devices, so the problem you are experiencing won't be on the way to the integration set-up.

Do you mean adding a lot of device trackers?

Yes, it's a little inconvenient. Since I don't need to know if my remote control is at home 🤣

But it will be generating warnings in the log with some additional info on which exactly values are wrong and what they report.

Like this?

I apologize for the intrusiveness, but the Download/Upload speed sensors for wlan1 are swapped)))

Lots of device trackers is the expected behaviour for HA. The standard approach is to add all the connected devices and HA is either enabling entities for them or keeps them disabled depending on if it knows this device (e.g. if it was added to the database by some other integration then device_trarcker is merged to it). I can think of a possibility to have a filter by name/mac of what devices to track, but that would be quite complicated way, so cannot be implemented fast
Yes. This is the warning. Apparently, the internetMode values are wrong at least for 1 device. The library knows true, false, allow, block, 1 and 0 as boolean values. Can you check in the full log if this warning is appearing once per 30 +- seconds or lots of times in the same second. In the first case, that would be only 1 connected device with the issue. In the latter - several / all of them. If we find the one and then find the values it reports - I'll be able to fix it completely and you will not see these warnings anymore.
It doesn't seem swapped. Values provided in the web panel are in MB/s (megabytes). The integration uses standard values for network speeds in Mb/s - megabits. So it should be 8 times larger (also a small discrepancy comes from the precision of the values). On your snapshot 0.19 MB/s = 1.52 Mb/s (integration shows 1.5), 0.03 MB/s = 0.24 Mb/s (shows 0.2). Also, you should keep in mind, that the web panel refreshes every 1-3 seconds and integration updates data every ~30 seconds - so the value is averaged over this 30 seconds

Hey, @NormKOALA,
Do you still get warnings in your log from the integration on the latest versions 0.3.0 or 0.3.1?

Hey,
With the new version 0.5.1 you should not get warnings anymore.
Please, check it out.
Since it looks like this was the final part of this issue, I can close it now.
If you would experience any other issues with the integration, feel free to open a new issue.


IFormFile not load type Microsoft.AspNetCore.Http.Internal.FormFile' from assembly 'Microsoft.AspNetCore.Http 3.0'

When using IFormFile I am getting this error at running time:
Could not load type 'Microsoft.AspNetCore.Http.Internal.FormFile' from assembly 'Microsoft.AspNetCore.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'.
<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Http" Version="2.2.2" />
<PackageReference Include="Microsoft.AspNetCore.Http.Features" Version="3.0.0" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="2.2.5" />
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="3.0.0" />
<PackageReference Include="Microsoft.Extensions.Http" Version="3.0.0" />
<PackageReference Include="Microsoft.Net.Http.Headers" Version="2.2.0" />
</ItemGroup>

using Microsoft.AspNetCore.Http.Internal;
IFormFile f = new FormFile(memoryStream, 0, memoryStream.Length, "test", "test.pdf");

IFormFile not load type Microsoft.AspNetCore.Http.Internal.FormFile' from assembly 'Microsoft.AspNetCore.Http 3.0'
   at AgencyAgreementExpiryService.Pipeline.Agreement.Process.GetPdfProcess.<ExecuteAsync>d__3.MoveNext() in C:\AgencyAgreementExpiryService\AgencyAgreementExpiryService\AgencyAgreementExpiryService.Pipeline\Agreement\Process\GetPdfProcess.cs:line 62
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine)
   at AgencyAgreementExpiryService.Pipeline.Agreement.Process.GetPdfProcess.ExecuteAsync(AgreementParameters parameters)
   at BT.AgencyAgreementExpiryService.Pipeline.LogicPipeline`1.<ExecuteAsync>d__2.MoveNext() in C:\AgencyAgreementExpiryService\AgencyAgreementExpiryService\AgencyAgreementExpiryService.Pipeline\LogicPipeline.cs:line 29

When exploring the class, it is pointing to SDK 2.2 which is the latest available version of microsoft.aspnet.core

`#region Assembly Microsoft.AspNetCore.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60
// C:\Program Files\dotnet\sdk\NuGetFallbackFolder\microsoft.aspnetcore.http\2.2.0\lib\netstandard2.0\Microsoft.AspNetCore.Http.dll
#endregion

using System.IO;
using System.Runtime.CompilerServices;
using System.Threading;
using System.Threading.Tasks;

namespace Microsoft.AspNetCore.Http.Internal
{
    public class FormFile : IFormFile
}

Is there any other library that I am missing?

ASP.NET Core version 3.0
VS 2019

@barfootCBarragan mixing versions of ASP.NET Core isn't supported and would explain this specific error you're seeing:
<PackageReference Include="Microsoft.AspNetCore.Http" Version="2.2.2" />
<PackageReference Include="Microsoft.AspNetCore.Http.Features" Version="3.0.0" />

Is there a reason you're targeting the 3.0 version of the Microsoft.AspNetCore.Http.Features package?

I have deleted Microsoft.AspNetCore.Http.Features and still having the problem:
Library class where I am using IFormFile:

Main Web Application

@barfootCBarragan again, is there a reason you're mixing 2.2 versions of packages with 3.0? If you're attempting to upgrade to 3.0, please follow the migration guide: https://docs.microsoft.com/en-us/aspnet/core/migration/22-to-30?view=aspnetcore-3.0&tabs=visual-studio.

As @pranavkm mentioned, mixing 2.2 and 3.0 dependencies like this isn't supported. Closing.


[#169504332] Download metrics data as a CSV

What
This adds a link below each chart to download redis and rds backing service
metrics as a CSV. This is so we can provide an alternative for assistive
technology users.
How to review
Code review
Who can review
Not me

Rebased this onto master and added CSV download for CDN routes


Modifications in beacon rewards tests

Refs https://github.com/keep-network/keep-core/issues/1783
In this PR we are changing 2 things in tests:

Beacon KEEP rewards for the period starting in Sep 2020 are reduced of 200k which was allocated for the period of May - Sep 2020.
We pass a creation group timestamp in tests to avoid future failures when the intervals will be over.

Nice work!


Update to DateTimeOffset.

The most recent commit changed the UnixTimestampConverter from DateTime to DateTimeOffset. It did not however, change all of the fields relying on the UnixTimestampConverter to the DateTimeOffset object. This means that the library currently crashes whenever it tries to load an object from a json file.  In order to fix this, this commit changes all of these fields to DateTimeOffsets.
In addition, there were various other fields and methods, such as Thing.FetchedAt and Thing.SearchByTimeStamp, that still used the DateTime type. All of these were changed to use DateTimeOffset. Even though these fields/methods do not rely on the UnixTimestampConverter, I figured that if we were going to use DateTimeOffset for the UnixTimestampConverter, might as well use it for everything else.

Good catch, do you know which specific objects it was crashing on before your fix?

I was able to get it to crash on every object in the fix commit.
After I changed Subreddit to DateTimeOffset, I was crashing the WikiPage by doing something like
WebAgent webAgent = new WebAgent();
AuthProvider authProvider = new AuthProvider(clientID, clientSecret, clientURI, webAgent);
Reddit reddit = new Reddit(webAgent, false);
Subreddit subreddit = reddit.GetSubreddit("AskReddit");
WikiPage page = subreddit.Wiki.GetPage("");

Here it would crash when it tried to load the RevisionDate for the WikiPage with the exception Unhandled Exception: Newtonsoft.Json.JsonSerializationException: Error setting value to 'RevisionDate' on 'RedditSharp.WikiPage'. ---> System.InvalidCastException: Specified cast is not valid.

Ah you know what, I forgot that code hadn't been ported to the 2.0 branch and I don't think I had it tested yet on the 1.0 branch. I'll get the 1.0 NuGet package updated.


Add Caliper 2023 Q2 project update

@petermetz Apologies, I've updated the report accordingly.

@petermetz Apologies, I've updated the report accordingly.

@aklenik No worries, thank you for the fix!


Complete functions for extracting from Zenodo

Write functions that will extract from the source and download to the repository. To finish this issue, we don't need to download and save the data from the source, we only need the code.
Code should be placed in: R/zenodo-search.R

Finalized with #50


Page build warning

-> https://help.github.com/en/articles/using-a-custom-domain-with-github-pages

Still getting these by email. New link:
https://help.github.com/en/github/working-with-github-pages/configuring-a-custom-domain-for-your-github-pages-site

Fixed by updating the A Records to the new GitHub IP addresses


[release-v0.13] chore: bump google.golang.org/protobuf package to 1.33

What this PR does / why we need it:
chore: bump google.golang.org/protobuf package to 1.33
Release note:
chore: bump google.golang.org/protobuf package to 1.33

The failing tests are flaky and not related to this PR


A .deb installer?

As title

Are we going to have ayaup in the future if we use the system package manager now?

Good point, it's just that current version of Aya is hard to install

Of course we will have that


piral upgrade command does not check for yarn.lock

Bug Report
For more information, see the CONTRIBUTING guide.
Prerequisites

[ ] Can you reproduce the problem in a MWE?
[x] Are you running the latest version?
[x] Did you perform a search in the issues?

Environment Details and Version
<EMAIL_ADDRESS><EMAIL_ADDRESS>MacOS 10.14.4
Description
piral upgrade command (and possibly other commands) have --install flag true by default. I noticed my upgrade patched "package.json", but didn't install the dependencies.
According to the logs, I believe the command only check for "package-lock.json", not "yarn.lock"
Steps to Reproduce
(I probably can do a MWE if needed, but in short of time, sorry...)

Go to an existing piral target which needs an update. This target uses yarn client, not npm
Run piral upgrade

Expected behavior
piral-cli uses current npmClient to run install dependencies
Actual behavior
"package.json" was patched with new piral-cli version
Installation of dependencies didn't happen
See logs
 ✘  100%  ~/workspace/shell-backup/ui feature/piral-upgrade
 ❯ piral upgrade --log-level 5
[7:29:40 AM]: [0003] Checking directory "/Users/snguyen/workspace/shell-backup/ui" ...
[7:29:40 AM]: [0003] Target exists, but not yet clear if directory.
[7:29:40 AM]: Checking provided version ...
[7:29:40 AM]: [0003] Starting the NPM process ...
[7:29:40 AM]: [0003] Applying NPM cmd "npm show piral-cli version --tag latest" in directory "/Users/snguyen/workspace/shell-backup/ui".
[7:29:40 AM]: [0003] Running "npm show piral-cli version --tag latest" in "/Users/snguyen/workspace/shell-backup/ui" ("/Users/snguyen/workspace/shell-backup/ui/node_modules/.bin").
[7:29:41 AM]: [0003] NPM show result: 0.11.3
[7:29:41 AM]: [0003] Found real version: "latest".
[7:29:41 AM]: [0003] Updating all dependencies ...
[7:29:41 AM]: Reading installed packages ...
[7:29:41 AM]: [0003] Patching the package.json ...
[7:29:41 AM]: [0003] Checking if file "/Users/snguyen/workspace/shell-backup/ui/package.json" exists ...
[7:29:41 AM]: [0003] Updating file "/Users/snguyen/workspace/shell-backup/ui/package.json" ...
[7:29:41 AM]: Updating the NPM packages to latest ...
[7:29:41 AM]: [0003] Starting the NPM process ...
[7:29:41 AM]: [0003] Applying NPM cmd "npm install --no-package-lock" in directory "/Users/snguyen/workspace/shell-backup/ui".
[7:29:41 AM]: [0003] Running "npm install --no-package-lock" in "/Users/snguyen/workspace/shell-backup/ui" ("/Users/snguyen/workspace/shell-backup/ui/node_modules/.bin").
null
Codes Reference: https://docs.piral.io/code/search

Possible Origin / Solution
[Optionally, share your idea to fix the issue]

That's true - we exclusively use npm under the hood.
What is the general approach to decide this (yarn vs npm)?

Check if there is package-lock.json -> [yes] use npm (done)
Check if there is yarn.lock -> [yes] use yarn (done)
Check the system's default manager (can this be done??) -> [found] use this one (done)
Fall back to npm (done)

No idea about (3) and if there is a general mode. Maybe someone has an idea here.
For scaffolding we would start our alg. at (3) since nothing would exist at this point.

It might be easier to explicitly define which npmClient to use. I have since devs unconsciously run npm install in a project which uses yarn, and the project ends up with both package-lock.json and yarn.lock.
lerna has npmClient config to specify yarn or npm. https://github.com/lerna/lerna/blob/master/commands/bootstrap/README.md#usage

I think this may work:

Check if there is package-lock.json -> [yes] use npm (done)
Check if there is yarn.lock -> [yes] use yarn (done)
Check the default npmClient in the .piralrc -> [yes] use found version (done)
Check if inside a lerna mono repo -> [yes] use found client (done)
Fall back to npm (done)

I think explicit declaration should be precedent.

.piralrc - more specific to piral-cli
lerna npmClient - when users setup lerna, they were asked to select npmClient
package-lock.json
yarn.lock
Fall back to npm

I think explicit declaration should be precedent.

I would not do that. There are two main reasons for that:

If your current project contains already a file -> this is what you should definitely use
Your rc file may not be in the project directory, it may be in your home directory (so in this case you may use a global setting to override an explicit local one resulting exactly in the behavior you want to avoid)

The locations for the merging of rc files is outlined at https://www.npmjs.com/package/rc.
The lerna case should not appear often - and if it does and should be usually covered by having a package-lock.json or yarn.lock already. Thus checking for such files should be priority. Lerna is a special application and we should not treat it with prio.
The only thing left is what if there are both - package-lock.json and yarn.lock. According to the algorithm above first one wins, however, it could be that a project switched and just forgot to delete the old file.
Of course, the argumentation above regarding shifting down .piralrc also should be used compared to lerna. So my new proposal would be:

Check if there is package-lock.json -> [yes] check npm
Check if there is yarn.lock -> [yes] check yarn
If only npm or yarn (one of the both) -> [yes] return checked (done)
Check if inside a lerna mono repo -> [yes] use found client (done)
If npm and yarn checked (both) -> [yes] return more recent file (done)
Check the default npmClient in the .piralrc -> [yes] use found version (done)
Fall back to npm (done)


Include confidentiality clause

Complaints under a Code of Conduct should confidential by default. A confidentiality clause is important to clarify who ( and under what circumstances ) has access to the information in a complaint. The text below suggests that complaints are not confidential by default, and that the complaint could be shared beyond the response team unless the complainant requests otherwise.

We will respect confidentiality requests for the purpose of protecting victims of abuse.

From: https://github.com/todogroup/opencodeofconduct/blame/gh-pages/index.md#L43
It's my hope that there is a generic way to specify these things, but there may not be.

Thanks for your feedback, we will definitely consider doing this.
We are in the process of collecting feedback from initially launching this and will incorporate changes in the coming weeks.

It's awesome to see this project exist. I applaud the effort going into it. /aside
I also have an example of a confidentiality clause, which I hope helps.

Thanks for your feedback. See https://github.com/todogroup/opencodeofconduct/issues/84.


[Bug] Redis Cleanup Job blocks deletion if GCS didn't start

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
ray-operator
What happened + What you expected to happen
When trying to delete a RayService where the head node hadn't spun up, the Redis Cleanup job runs into an error and the pod is stuck in an Error state. The RayCluster resource doesn't get deleted until the job finishes successfully.
I would expect the job to retry a few times with a backoff and still delete the resource if it doesn't succeed after a set number of retries.
Reproduction script
Create a RayService resource and delete it while the head pod is still in Pending or ContainerCreating stage.
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

It seems to be the right time to make the Redis cleanup a best-effort task (https://github.com/ray-project/kuberay/issues/1557#issuecomment-1788480539) cc @rueian

FWIW, you can also let the user toggle between strict and best-effort with a flag

Hi @smit-kiri,
Could you let me know what error message you saw on the Redis Cleanup job? Or did it just exit with code 1 without any message?

@rueian
I think it will fail immediately instead of retrying, as the key doesn't exist in Redis. You can see the details in the "Note" section of this PR description: https://github.com/ray-project/kuberay/pull/1592#issue-1973091979.

@rueian
I think it will fail immediately instead of retrying, as the key doesn't exist in Redis. You can see the details in the "Note" section of this PR description: #1592 (comment).

Yeah, so I wonder could we have another option - treating key not found as succeed?

Yeah, so I wonder could we have another option - treating key not found as succeed?

That makes sense too! Although does the job re-try deleting if it fails the first time? The Redis instance might not be available when it tries first, but it might after a couple minutes

Yeah, so I wonder could we have another option - treating key not found as succeed?

That makes sense too! Although does the job re-try deleting if it fails the first time? The Redis instance might not be available when it tries first, but it might after a couple minutes

Yes, it will retry several times if your redis is not started yet. The detailed behavior is covered in the PR https://github.com/ray-project/kuberay/pull/1757 and the PR can solve your current issue.
@kevin85421 I will also open a PR to make the cleanup job, by default, work in a best-effort manner in any case later.

Close by #1766


Add option to create links with root access

Since symlinks require ext2/3/4 filesystem and most Android devices do not have them - this is useless.


Integrated code lifecycle: Fix an issue when parsing special characters

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I strictly followed the server coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[x] I documented the Java code using JavaDoc style.

Motivation and Context
When the result.xml file contains invalid characters (e.g. when they are used in stdout which is provided as part of the result file) the parsing fails.
Description
We now remove such invalid characters before parsing.
Steps for Testing
code review, quite hard to replicate since you need an exercise where such invalid chars get printed. Reviewing the new test case should be enough. You can also locally outcomment the replaceAll line and see that the test now fails.
Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress
Performance Review

[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Summary by CodeRabbit

Bug Fixes

Improved error handling for test result parsing to catch all exceptions, ensuring more robust processing.
Enhanced logging to provide clearer error messages when parsing test results.

New Features

Added a new constant to remove invalid XML characters before parsing test results, improving XML file processing.

Tests

Introduced a new test to verify the handling of XML files with invalid characters, ensuring better error message reporting.

Maybe it also makes sense to address the source, which is (maybe among other places) https://github.com/ls1intum/Artemis/blob/bf3df4117cbe0cc4450a64a4f102b573056ecdab/src/main/resources/templates/c/gcc/test/testUtils/junit/TestCase.py#L47 where the stdout/stderr gets passed unsanitized to ElementTree, which leads to a broken XML file due to https://github.com/python/cpython/issues/49416
Unfortunately, my Python-foo is not strong enough to adapt the suggested workaround to modern Python versions

Thanks for the suggestion @upsj, I added the changes.

@Strohgelaender seems like the second line of the XML sanitation function was lost when applying the patch?


Time zone abbreviation

https://en.wikipedia.org/wiki/List_of_time_zone_abbreviations
Faker::Address.time_zone_abbr  #=> "AST" # Atlantic Standard Time

Is there anyone working on this issue? I would love to do that


Find more interesting examples

The current examples uses pretty limited and very fake data, this make's it hard to to understand how a chart would work in context. It would be a great boon to our documentation to have better/more interesting examples

One rich data set at hand is our contribution data. It would be kinda interesting to rebuild the gh-contributor page in react-vis

I've got some pretty interesting data that could work well for examples. I have these CSV datalogs from my car that capture a row of data per unit time, such as speed, RPM, boost pressure, air temperature, etc... You could plot things like speed vs time, speed vs RPM, etc... I've attached a file in case you want to check it out (I have it as CSV as well but github won't upload it).
datalog.xlsx

that some pretty cool data! I think we should maybe build an examples folder so that we can iteratively add cool things?

Agreed, I like that idea.

We're using react-vis for visualizing genetic profiles after engraftments. It could be a real-world example for the VerticalRectSeries.

As I'm sure you've seen we've developed location for hosting examples (http://uber.github.io/react-vis/#/examples/charts/showcase). If you have any interest I highly encourage you to submit an example! The process is real easy, just clone one of the examples in the examples folder, and add an appropriate json object in constants/pages.js

I'm marking this as closed as we have a pretty cool collection of examples now


.separated factory constructor

Hello ! I know matching feature parity with a standard Flutter widget is usually pretty tough but I'd love if the .separated constructor was added here to allow users to space their content easily. Conditional padding or space filling widgets are the only alternative and are kind of troublesome to use imho.

Actually, I don't have much experience in ListView's so pardon my ignorance. I'm also just curious to hear from a package maintainer of a ListView package if is there a technical reason why someone has not built a wrapper kind of thing around ListView instead of recreating it? Looking into this recently it looks like there's a NotificationListener widget that can be used to listen to scroll events.
Given that, I thought there would be a package that would just use that to handle events. I wrote this quick proof of concept though I haven't tested it:

lazy list builder
import 'package:flutter/material.dart';

typedef LazyBuilder = Widget Function({
  BuildContext context,
  // TODO: Specify whether loading before or after scroll extent
  Widget? loadingMore,
});

class LazyListBuilder extends StatefulWidget {
  /// A lazy builder that will be used to create the list widget. It also
  /// carries the context of the child and a loading widget to be inserted into
  /// the ListViews.
  final LazyBuilder builder;

  /// Called when more content is needed. Only works at the END of the main axis
  final VoidCallback onLoadMore;

  const LazyListBuilder({
    Key? key,
    required this.builder,
    required this.onLoadMore,
  }) : super(key: key);

  @override
  State<LazyListBuilder> createState() => _LazyListBuilderState();
}

class _LazyListBuilderState extends State<LazyListBuilder> {
  bool isLoading = false;

  // TODO: Debounce this
  void loadMore() {
    setState(() {
      isLoading = true;
    });

    widget.onLoadMore();

    if (mounted) {
      setState(() {
        isLoading = false;
      });
    }
  }

  @override
  Widget build(BuildContext context) {
    return NotificationListener<ScrollNotification>(
      child: widget.builder(
        context: context,
        loadingMore: isLoading ? const CircularProgressIndicator() : null,
      ),
      onNotification: (notification) {
        if (notification is ScrollEndNotification) {
          // TODO: Do extentBefore
          if (notification.metrics.extentAfter == 0) {
            loadMore();
          }
        }

        return false;
      },
    );
  }
}

What advantages would one way have over the other? Is there something one of them cannot do? Genuinely curious

Hello @Nolence 👋
Sorry for the very late reply.
It is already possible to replicate the .separated behavior by using the separatorBuilder option.

is there a technical reason why someone has not built a wrapper kind of thing around ListView instead of recreating it?

There is! For this particular case (adding a loading thingy on the trailing edge of the scroll view) it would be really hard to accomplish it without sacrificing the optimization of ListView.builder. In your example, on usage, you generate a list of widgets (ListTile).
Having a list of items in a scroll view is not always the case and in some cases, it may cause the crash of the app due to the number of items. (Once I worked on an app that could have 2 million items on a single listview).


LoginError: Error=BadAuthentication

Like another google play api, i also get this issue on this app, BadAuthentication

yeah it seems to happen randomly. Google may be planning to deprecate the auth mechanism being used, so one thing you can do is preserve the authToken and then pass it in via options...
gpcli_authToken=...token instead of setting the login/password env vars ought to be enough for now.

how to get the token?

For now you have two options until I have time to look into the new auth devices may be using:

mitm a real device with your login and pull it out of the network trace. The token will be in the headers and can be used with this library
keep trying to auth with this library a few times - it eventually works, then save the token.

by the way you can use gp-get-token binary installed for this w/ GOOGLE_LOGIN, GOOGLE_PASSWORD, and ANDROID_ID set in your environment. if you retry a few times you should eventually get an auth token and then you can use it as I described using the gpcli_authToken env variable going forward. That token should remain valid for a while, but I don't know exactly how long.


Request: update to d3 v4

Hi, compatibility with D3 version 4 would be awesome when you get around to it. Thank you!

I just tagged a 1.0.0 release that supports d3 v4 and leaflet 1.0. I also switched to npm deployments and the whole thing bundles to umd now, so it should work both as a global import as well as with module loaders. A typings file should be coming relatively soon.


WFLY-19538 Remove usage of deprecated WildflyTestRunner class

Resolves
https://issues.redhat.com/browse/WFLY-19538

Thanks @rhusar


AM2 mob spawning

AM2 has some amazing mobs, but they are mostly spawning with chunk creation / worldgen and not replenishing after that.
EnderZoo or CustomMobProperties to get them generating?

Looking at EnderZoo, we can do it pretty easily that way. It only gives the basic capabilities, such as biome restriction, dimension restriction, and rate. Combining it with MobProperties, though, could be pretty amazing.


Migrate from goo.gl to tinyurl.com

~Adding qs to package.json (it was a transient dependency before, but making it explicit is better).~ Using the stdlib querystring module.
Fix #218.

@siddharthkp any update on this? All our builds depend on this and even though our deployments are able to continue, we do get a nice error notification with every commit we push... 😇

consider my approve as a Vote :)


[DOCS]

Now that we have #28 merged, I think it'll make sense soon to document how to deploy it to Vercel.

Is it okay if I take this up?

Definitely! Of course.


Fix remaining pep8 issues

I have formatted all the files using black. From now all pep8 directives except E501 must be respected.
Adding the remaining ones below:

[ ] ./mainapp/views.py:189:5: E722 do not use bare 'except'
[ ] ./mainapp/views.py:478:5: E722 do not use bare 'except'
[ ] ./mainapp/views.py:515:5: E722 do not use bare 'except'
[ ] ./mainapp/views.py:542:5: E722 do not use bare 'except'
[ ] ./mainapp/views.py:691:5: F841 local variable 'body_rows' is assigned to but never used
[ ] ./mainapp/views.py:705:12: E711 comparison to None should be 'if cond is None:'
[ ] ./mainapp/csvimporter.py:16:5: E722 do not use bare 'except'
[ ] ./mainapp/csvimporter.py:61:37: E711 comparison to None should be 'if cond is None:'
[ ] ./mainapp/csvimporter.py:82:37: E711 comparison to None should be 'if cond is not None:'
[ ] ./mainapp/csvimporter.py:86:42: E711 comparison to None should be 'if cond is not None:'
[ ] ./mainapp/models/models.py:112:19: W605 invalid escape sequence '+'
[ ] ./mainapp/models/models.py:112:30: W605 invalid escape sequence '-'
[ ] ./mainapp/models/models.py:112:49: W605 invalid escape sequence '\d'
[ ] ./mainapp/models/models.py:243:19: W605 invalid escape sequence '+'
[ ] ./mainapp/models/models.py:243:30: W605 invalid escape sequence '-'
[ ] ./mainapp/models/models.py:243:49: W605 invalid escape sequence '\d'
[ ] ./mainapp/models/models.py:321:19: W605 invalid escape sequence '+'
[ ] ./mainapp/models/models.py:321:30: W605 invalid escape sequence '-'
[ ] ./mainapp/models/models.py:321:49: W605 invalid escape sequence '\d'
[ ] ./mainapp/models/models.py:643:53: E231 missing whitespace after ','
[ ] ./mainapp/models/models.py:695:19: W605 invalid escape sequence '+'
[ ] ./mainapp/models/models.py:695:30: W605 invalid escape sequence '-'
[ ] ./mainapp/models/models.py:695:49: W605 invalid escape sequence '\d'
[ ] ./mainapp/models/models.py:832:19: W605 invalid escape sequence '+'
[ ] ./mainapp/models/models.py:832:30: W605 invalid escape sequence '-'
[ ] ./mainapp/models/models.py:832:49: W605 invalid escape sequence '\d'
[ ] ./mainapp/models/models.py:890:26: E711 comparison to None should be 'if cond is not None:'
[ ] ./mainapp/tests/test_views.py:419:9: F841 local variable 'rescue_camp_tcr_1_model' is assigned to but never used
[ ] ./mainapp/tests/test_views.py:426:9: F841 local variable 'rescue_camp_tcr_2_model' is assigned to but never used
[ ] ./mainapp/tests/test_views.py:433:9: F841 local variable 'rescue_camp_tcr_3_model' is assigned to but never used
[ ] ./mainapp/utils/sms.py:38:17: E711 comparison to None should be 'if cond is not None:'
[ ] ./mainapp/utils/sms.py:40:13: E711 comparison to None should be 'if cond is not None:'
[ ] ./mainapp/utils/sms.py:42:14: E711 comparison to None should be 'if cond is not None:'
[ ] ./mainapp/utils/sms.py:44:17: E711 comparison to None should be 'if cond is None:'
[ ] ./floodrelief/test_settings.py:1:1: F403 'from .settings import *' used; unable to detect undefined names
[ ] ./floodrelief/test_settings.py:1:1: F401 '.settings.*' imported but unused
[ ] ./floodrelief/urls.py:36:68: E231 missing whitespace after ','
[ ] ./floodrelief/settings.py:15:1: F401 'dj_database_url' imported but unused
[ ]

looks good


Update API to set observation project based on field slip when appropriate

coverage: 93.413% (+0.001%) from 93.412%
when pulling 033d42d13e1281c6d55b4a2c848c62fb919c4450 on njw-obj-project-from-field-slip
into 8a8b83bba4ff80d62bdc688b73bfa62b40129bcf on main.


Emojis are not displayed in page.pdf

I have a url that contains emojis, and I am trying to generate a PDF from this link, but the emojis are not displayed properly, they get displayed as boxes.
Is there any way to generate the Pdf properly with emojis ?
Here is the code I use to generate the PDF.
return puppeteer.launch({
       pipe: true,
        args: [
            '--headless',
            '--disable-gpu',
            '--full-memory-crash-report',
            '--unlimited-storage',
            '--no-sandbox',
            '--disable-setuid-sandbox',
            '--disable-dev-shm-usage',
        ],})
            .then(response => {
                browser = response;
                return browser.newPage();
            })
            .then(response => {
                page = response;
                page.setDefaultNavigationTimeout(0);
                return page.goto(url, {
                    waitUntil: 'networkidle0'
                });
            })
            .then(() => pdf({
                 printBackground: true,
                 width: 1080,
                height: 920,
            }))
            .then(() => {
                browser.close();
                return name;
            });```

Have the same problem! Any solutions available?

+1

You haven't provided any further information about environment you are running puppeteer on (OS, puppeteer version, etc..). Though one of the reason might be missing font with emoji support installed on the system where the script is executed. Often fonts fonts-noto-color-emoji or fonts-opensymbol are installed on Debian/ubuntu based systems to properly render emojis.

You haven't provided any further information about environment you are running puppeteer on (OS, puppeteer version, etc..). Though one of the reason might be missing font with emoji support installed on the system where the script is executed. Often fonts fonts-noto-color-emoji or fonts-opensymbol are installed on Debian/ubuntu based systems to properly render emojis.

Hi,
we are using pupeteer as a cloud function where is is not allowed to install anything directly on the machine. Is it somehow possible to include these fonts from package.json?

@knyttl you can use a workaround with downloading an emoji-supported font on render as mentioned in https://github.com/puppeteer/puppeteer/issues/4086#issuecomment-671385735

If somebody using docker image (alpine) then for me works:
FROM node:16.14-alpine as base
RUN apk add font-noto-emoji
RUN apk add chromium
ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true

and puppeteer created as:
const browser = await puppeteer.launch({
	executablePath: '/usr/bin/chromium-browser',
	args: ['--no-sandbox'],
})

I am getting this error:
Step 4/21 : RUN apk add font-noto-emoji  ---> Running in 5fcbf86f3acb fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/main/x86_64/APKINDEX.tar.gz fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/community/x86_64/APKINDEX.tar.gz ERROR: unsatisfiable constraints:   font-noto-emoji (missing):     required by: world[font-noto-emoji] The command '/bin/sh -c apk add font-noto-emoji' returned a non-zero code: 1 Error: Process completed with exit code 1.

It looks like you need to install the fonts for emoji. Feel free to re-open with a recent repro and more details if it's still an issue.


Consider replacing title screen with more direct access to Adw and Gtk components

Today, title screen is a slim wrapper around Adw.StatusScreen. Other than some basic state manipulation for buttons there isn't much happening. One possibility is to allow more direct access to create Gtk and Adw components instead of needing to proxy them with a class abstraction. For example importing yafti.screen.adw.StatusScreen would give you a StatusScreen object with the additional YaftiScreen goodies allow you to map config to component properties. This would only leave Packages as a larger composite component and allow greater flexibility in definition of screens

Gonna close this one.  feel like the new layout addresses original concern.


Repairing errors for certification [WIP]

Closes  #184

Host vars moved out of securityContext

@Jainbrt give this should fix  #184

@Jainbrt give this should fix #184

I have tried with removing the parameter, it does work. You have now commented these, which should be same, right ?

Yes it should be  the same, I commented them out, because there's a requirement in case to  use these, but they clearly don't work. I want to keep them in the file as a reminder  though to investigate in the future.


Bug 1355056 - Replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions

See https://hg.mozilla.org/mozilla-central/rev/0f97f76c0b34#l26.1

Thank you for filing this issue! Fortunately we're already working on it for our ES6 conversion project.

we cannot do it for pdf.worker.js just yet, we will need to replace that with, e.g. var _self=this; ... function () { _self... }

Please do not edit PDF.js specific files directly on mozilla-central without the changes being made here first, since this GitHub repository is the canonical upstream repository, and mozilla-central is simply a downstream consumer of it.
In cases like these, changes made directly in mozilla-central will most likely just cause merge conflicts (and be reverted) during the regular PDF.js updates.
At the very least, for these kind of mass changes, personally I think that it would be most helpful if these two directories were excluded: http://searchfox.org/mozilla-central/source/browser/extensions/pdfjs/content/build, http://searchfox.org/mozilla-central/source/browser/extensions/pdfjs/content/web.

Closing as fixed by PRs #8354, #8355, #8370, and #8377.


No build instructions

If I clone the repository and run npm dev run in it I get:
> dev
> next dev

sh: 1: next: not found

If I use yarn dev I get:
00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'dev'

I'm not familiar with the frameworks used, so I'm missing something.
This is in a Ubuntu 22.04 machine.

Did you run npm install first?

Thank you. That's what it was missing.


Cannot build libtorch dependency for Torch-Tensorrt on Jetson (jetpack 4.6) using bazel

Hi, I am trying to install Torch-Tensorrt on my Jetson Xavier using jetpack 4.6
I was able to install bazel and I have reached the point in the pytorch guide where I need to build libtorch using bazel. Specifically this command:
bazel build //:libtorchtrt --platforms //toolchains:jetpack_4.6
The error that gets produced:
ERROR: /home/mic-710ailx/TensorRT/core/conversion/evaluators/BUILD:10:11: Compiling core/conversion/evaluators/eval_util.cpp failed: (Exit 1): gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 58 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox
core/conversion/evaluators/eval_util.cpp: In function 'at::Tensor torch_tensorrt::core::conversion::evaluators::createTensorFromList(const c10::IValue&, const c10::IValue&, const c10::IValue&)':
core/conversion/evaluators/eval_util.cpp:275:67: error: invalid initialization of reference of type 'const TypePtr& {aka const std::shared_ptr<c10::Type>&}' from expression of type 'std::__shared_ptr_access<c10::Type, (__gnu_cxx::_Lock_policy)2, false, false>::element_type {aka c10::Type}'
   at::ScalarType initial_scalar_type = c10::scalarTypeFromJitType(*elem_type);
                                                                   ^~~~~~~~~~
In file included from bazel-out/aarch64-fastbuild/bin/external/libtorch/_virtual_includes/ATen/ATen/core/List_inl.h:362:0,
                 from bazel-out/aarch64-fastbuild/bin/external/libtorch/_virtual_includes/ATen/ATen/core/List.h:480,
                 from bazel-out/aarch64-fastbuild/bin/external/libtorch/_virtual_includes/ATen/ATen/TensorIndexing.h:13,
                 from bazel-out/aarch64-fastbuild/bin/external/libtorch/_virtual_includes/ATen/ATen/ATen.h:20,
                 from core/conversion/evaluators/eval_util.cpp:1:
bazel-out/aarch64-fastbuild/bin/external/libtorch/_virtual_includes/ATen/ATen/core/jit_type.h:1625:23: note: in passing argument 1 of 'c10::ScalarType c10::scalarTypeFromJitType(const TypePtr&)'
 inline at::ScalarType scalarTypeFromJitType(const c10::TypePtr& type) {
                       ^~~~~~~~~~~~~~~~~~~~~
Target //:libtorchtrt failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 177.133s, Critical Path: 116.06s
INFO: 19 processes: 7 internal, 12 linux-sandbox.
FAILED: Build did NOT complete successfully

Reference documentation:
https://pytorch.org/TensorRT/tutorials/installation.html

Refer to this discussion https://github.com/pytorch/TensorRT/discussions/1077

Refer to this discussion #1077

Hello, thank you for your timely response. I did refer to this earlier actually, and it somewhat helped. It looks like towards the end of the build (building setup.py), the program wants to create some directories in the usr/local/lib/python3.6/dist-packages.
It gets a permission denied error, but when I try running with sudo -H (in hopes of giving it permission) I get this:
fatal: unsafe repository
Any ideas?
Thank you.

This most recent issue was solved by downgrading numpy version. Found on:
https://forums.developer.nvidia.com/t/sudo-python-illegal-instruction/198978
This issue can be closed.


Touch support for Highlight

When using highlight with touch devices you cannot drag or brush.
Today using the device emulator in Chrome, the touch events just navigates around the page:

I started prototyping this feature registering onTouchMove event listener instead of using the onTouchMove property of the rect element. This event listener is registered as an "active" event listener (https://developers.google.com/web/updates/2017/01/scrolling-intervention) so that preventDefault is available when the component is brushing or dragging.
With "native" event listener

Taking this approach any movement in the chart will be "prevented" and interpreted as a brush/drag.
And might impact overall performance on the page when this listener is active.
I just wanted to check if there is any interest in making this change in the core library or if I should continue the work in a fork.

I would like this feature.

I would really appreciate this feature, because we need to implement this functionality! Is there any progress for this?

I have fixed touch event support for brushing in my fork https://github.com/rlaffers/react-vis/tree/touch-events-brushing
This is based off the 1.11.7 release, so I can't PR this into master. Maybe I will find time to port those changes into the 2.x react-vis version (master) - but feel free to do it yourself if you need touch event support in 2.x react-vis.


Improve AST and PSI structure for class declarations

Although there is a lot of code here, there is not much functionality added. There are some unintentional improvements of highlighting due to some elements being name owners.
This PR makes way for starting to implement references and resolutions for a bunch of things related to classes though.

There is a lot of code here, and I would have preferred not to make such a large PR, but classes are fairly big. I tried to keep code cleanup in separate commits. Please ask me if you need help reviewing this!


Result comparing HNSW and Vamana recall stability on final runbook.

Thanks @ekzhu. This looks interesting, but I'm not sure what the exact purpose of merging this into the main branch would be.
@harsha-simhadri What do you think?

I don't mind not merging this PR. I have also written a blog post with a much more detailed analysis yet to be published. How about let's just post the link to the blog post once I finish it?

I changed the file structure a bit so that it is a bit clearer that it is not part of the submissions. Please add the blog post link to the file and open a new PR. Thanks for the contribution!


by.repeater doesn't handle one-time bindings

Essentially, a repeater defined as ng-repeat="item in ::ctrl.items" does not get found by the locator by.repeater('item in ctrl.items'). I'm not sure if this flexibility is desired, but since there is already a more precise by.exactRepeater, perhaps it'd be worthwhile.
It seems like the current implementation simply search for the locator string via .indexOf(). The fix may be as simple as stripping out the :: before checking for the locator:
return ngRepeat.replace(/::/g, '').indexOf(repeater) != -1;

duplicate of https://github.com/angular/protractor/issues/2434


Fixed Links issue

Related Issue
None
Fixes: #2656
Description
Added the correct links for the buttons like Instagram, Facebook, YouTube in footer and main page

Fixed issue - #2656
Type of PR

[x] Bug fix

Screenshots / videos (if applicable)
https://github.com/user-attachments/assets/6d5ab7a8-ab23-461e-8acd-4217f836a0fd
Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@anuragverma108 Please review this PR and assign me the labels.


Adds stub of extracting config

This I think is good enough to:

get config keys
get values

Next steps -- massage into a format that's useful.
E.g. given modules, use this to extract the configs used/values encoded.

This is pretty brittle... Doable with some assumptions but harder to make this part of the contract. I really like this approach we came up with in the slack: https://hamilton-opensource.slack.com/archives/C03M33QB4M8/p1719388668393369.

yes it's reliant on the internals of config -- which we haven't set up to
be exposed.
I think that's fine for now.
I don't want to add another decorator just for this...
On Sun, Jun 30, 2024 at 9:57 AM Elijah ben Izzy @.***>
wrote:

This is pretty brittle... Doable with some assumptions but harder to make
this part of the contract. I really like this approach we came up with in
the slack:
https://hamilton-opensource.slack.com/archives/C03M33QB4M8/p1719388668393369
.
—
Reply to this email directly, view it on GitHub
https://github.com/DAGWorks-Inc/tuning-playground/pull/3#issuecomment-2198620630,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARYMBZKSP2QXCB2NZE3KETZKA2F5AVCNFSM6AAAAABKC6A5S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGYZDANRTGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Derive more precise types for EXTRACT

Currently, all results are typed as BIGINT. Given the constrained range for each of the field types, we can derive tighter type bounds.

The relevant code is:

io.prestosql.sql.analyzer.ExpressionAnalyzer.Visitor#visitExtract for the type
EXTRACT is mapped to functions in io.prestosql.sql.planner.iterative.rule.CanonicalizeExpressionRewriter.Visitor#rewriteExtract, and each such function return type must match EXTRACT's return type

Hi. Could I please work on this issue? This will be my very first time.

Absolutely! Go for it!


How to load the parameters of vit and t5?

Hello.
I see that the script uses the following command to load the model, but there are no parameters for vit and t5 in it. How can I load them?
load_finetuned: True   finetuned: 'https://huggingface.co/Shoubin/SeViLA/resolve/main/sevila_pretrained.pth'

I have the same issue, how did you do it?

Hi, thanks for your interest SeViLA project. please check this issue for details.


ReactRefresh in monorepo fails to update when more than one react-app present in the page

Describe the bug
Unfortunately it is hard to provide a repro repo for this.
in a typescript monorepo(lerna and yarn workspaces enabled) with 2 cra started simultaneous in dev mode updates do not happen as expected.
i have a index.html that loads code from both react apps (meaning it has two different root divs) so i have 2 bundles present and 2 ws monitoring updates from react-refresh.
crashes in any of the apps get the overlay to react correctly. the apps load correctly and everything compiles correctly.
the problem is changes do not get reflected in the browser. if i remove one of the bundles being loaded, everything is back working.
Did you try recovering your dependencies?
yes, everything is fresh. using yarn, removed node_modules and yarn lock, in root and in packages.
Which terms did you search for in User Guide?
cra v4, monorepo
Environment
Environment Info:
current version of create-react-app: 4.0.0
running from /Users/.../.config/yarn/global/node_modules/create-react-app
System:
OS: macOS 10.15.7
CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
Binaries:
Node: 10.15.3 - /usr/local/opt/node@10/bin/node
Yarn: 1.22.0 - /usr/local/bin/yarn
npm: 6.4.1 - /usr/local/opt/node@10/bin/npm
Browsers:
Chrome: 86.0.4240.183
Edge: 86.0.622.63
Firefox: Not Found
Safari: 14.0
npmPackages:
react:  17.0.1
react-dom:  17.0.1
react-scripts:  4.0.0
npmGlobalPackages:
create-react-app: Not Found
Steps to reproduce

create monorepo
have index.html load 2 react-apps
start with lerna run start
change one file and wait for updates

Expected behavior
updates get to dom
Actual behavior
updates do not happen
Reproducible demo
hard to do

come on. am i missing anything? how is this stale?


[WIP]: Add config validation command

https://github.com/packit-service/packit/issues/88

We also have PackageConfigSchema which we use to validate the package config when loading it.
It can be used like:
from packit.schema import PackageConfigSchema
PackageConfigSchema().validate({'specfile_path':6, 'create_pr': 5, 'xyz': True, 'config_file_path': 'correct string'})

{'create_pr': ['Not a valid boolean.'],
 'specfile_path': ['Not a valid string.'],
 'xyz': ['Unknown field.']}

For the 'Unknown field.' you need Marshmallow v3 (i.e. Fedora >= 32) (see also #782 )

We also have PackageConfigSchema which we use to validate the package config when loading it.
It can be used like:
from packit.schema import PackageConfigSchema
PackageConfigSchema().validate({'specfile_path':6, 'create_pr': 5, 'xyz': True, 'config_file_path': 'correct string'})

{'create_pr': ['Not a valid boolean.'],
 'specfile_path': ['Not a valid string.'],
 'xyz': ['Unknown field.']}

For the 'Unknown field.' you need Marshmallow v3 (i.e. Fedora >= 32) (see also #782 )

Should we plug that into the command as well? Ideally with some pretty output formatting.

I tried to complete your tasks but run into few problems. I would like to hear your opinions on this issues. Thank you in advance.

I'd propose we'd work backwards here: define what we want achieve and then work out the internals to get there. For me, I'd expect the validate command to produce:
$ packit validate

.packit.yaml is valid and ready to be used

$ packit validate

.packit.yaml does not pass validation:
* field specfile_path has incorrect type, it should be str, is null right now

$ packit validate

.packit.yaml is valid but some of the fields seem to be filled incorrectly
* specfile_path: path "{path}" does not exist
* there is no such downstream package - {name}

I hope you get the point now. @TomasJani does this make sense to you?
@packit-service/the-packit-team WDYT?

@packit-service/the-packit-team WDYT?

How about breaking up this work into two or three (at least), and having each part in its own PR?

Implement packit validate and check that the config is a valid YAML. This can be done just by loading the file. This would be a very simple command, but would already provide user value, and can serve as a basis for follow up PRs.
Implement the part where packit validate checks the config based on the schema. This would be only schema validation. No need to check if files exist, names are valid, etc.
Implement the value check parts, which check that paths exist, names are valid, etc. You could actually approach each of these checks separately in a separate PR.

With the approach above you could avoid your PR growing to big. Large and complex changes are more challenging for reviewers, need more time to rebase, debug, test, and usually take a lot more time to merge. Limiting the scope of the PRs will make it easier for everyone, and you can expect higher quality feedback, faster.

@csomh +1
I'd probably just do points 0 and 1 in a single pull request and then do 2 in a new one

Thank you all for review.

I hope you get the point now. @TomasJani does this make sense to you?

Thank you for clearing thinks out. We should be on same page now.

With the approach above you could avoid your PR growing to big.
I'd probably just do points 0 and 1 in a single pull request and then do 2 in a new one

That is a great idea. I'll adjust my code properly.
PS: sorry for late reply

PS: sorry for late reply

That's okay @TomasJani, we all have a life outside of GitHub :sunglasses:


Question: Cell Type annotated on multiple sites

Hi,
I was exploring the Cell Type Ontology through the OLS website, so I searched "B Cell" and obtained this entry:
https://www.ebi.ac.uk/ols4/ontologies/cl/classes/http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FCL_0000236
Where the cell type "B Cell" appears to be annotated multiple times in the tree:

Shouldn't a term be annotated only once in an ontology? How is the ontology organized? Is this term assigned to multiple terms via different relationships?
Thanks,
Marta.

Hi @MartaBenegas I'm not a core contributor to CL but I can answer this. This is the same concept with the same identifier (http://purl.obolibrary.org/obo/CL_0000236) in all these places. It's just that there are multiple paths "upward" from that concept to the root 'cell' concept. The ontology is a directed graph, rather than a tree.

Hi @MartaBenegas, I will add a graph to illustrate the example you provided. Terms can have multiple parent terms, for example a leukocyte is a 'motile cell', an 'hematopoietic cell', an 'eukaryotic cell' and a 'nucleate cell'. As OLS only can show one path at a time, all paths are displayed separately.

Hope this help, and please let us know if it is not clear.

Hi @aleixpuigb, thank you for the graph! How have you obtained it?
And I'm still a bit confused about this classification.
From my point of view, the relations between the terms cell > single nucleate cell and leukocyte > lymphocyte are redundant. Since mononuclear cell is already a "Subclass of" a leukocyte, so it'll be their child (e.g. the lymphocyte term). Is this assumption not followed in this ontology?
On the other hand, aren't a nucleate cell and a hematopoietic cell always going to be an eukaryotic cell? Shouldn't they be a "Subclass of" eukaryotic cell?

Hi @aleixpuigb, thank you for the graph! How have you obtained it?

I have used protégé, a software to edit ontologies. There are other options, such as neo4j.

From my point of view, the relations between the terms cell > single nucleate cell and leukocyte > lymphocyte are redundant. Since mononuclear cell is already a "Subclass of" a leukocyte, so it'll be their child (e.g. the lymphocyte term). Is this assumption not followed in this ontology?

You are correct, the reason that it is showing is because I used the cl-base.owl file that contains all logical axioms (asserted and inferred). Therefore, it is showing relationships that editors have not added, but they are reasoned (e.g., any leukocyte that is mononucleate is a 'mononuclear cell'). This allows us to find relationships that we might have missed otherwise.

On the other hand, aren't a nucleate cell and a hematopoietic cell always going to be an eukaryotic cell? Shouldn't they be a "Subclass of" eukaryotic cell?

This is also true, those relations should be added to the ontology. I will open a ticket to find more eukaryotic cells that haven't been correctly classified. Thank you for pointing it out!

I think it would be better to get rid of hard to support grouping classes - ones that cover most of the ontology.  These are an unfortunate legacy from an earlier era of CL editing.

Eukaryotic cell is a prime example.
Mononuclear cell as a general concept is probably another one (we can come up with tighter pattern for this within immunology)

Note - the Protege view is of the editors file, before redundancy stripping.  Here is a non redundant view of the same hierarchy:

I thought the same about the term mononucleate cell there. It seems too general to be at that level of the graph.
I had further questions. While exploring the root term cell I've found quite specific cell types directly linked to it:
(I pointed out some examples)

What are the criteria for connecting them directly to the root cell term and not inside the corresponding lineage inside the eukaryotic cell term? Some children of those terms are placed inside eukaryotic cell as well (which may overcomplicate the ontology a bit):

@MartaBenegas - I agree.  I think there are number of upper level types that should just be removed because they are hard to populate consistently and don't add much value.  This includes mononuclear cell and eukartyotic cell - which really should be parents to the majority of terms in the ontology.

I was not a fan, but we added mononuclear cells at the request of data annotators if I recall, so we need to be thoughtful if we are to roll this back.  "Mononuclear cell" is a common term in hematology referring to a broad class of immune cell types, and not necessarily intended as a general grouping term for all cells with a single nucleus.
Eukaryotic cell goes back to the original, grander view, of the scope of CL I think.

Maybe a "mononuclear leukocyte" would be a better name

The text def seems to have a further clause on the shape of the nucleus.  Is this meant to exclude bi-lobed nuclei - e.g. of basophils?  If so the logical def is too broad.  However, it does seem to be doing lots of work - so perhaps better to relax the text def?:
Manual classification:

Automated:

That's a great point Alex.  I would be OK with mononuclear leukocyte.  It will still be easily recognizable to the curator and biologists and is more specific than any old one nucleus cell.