az login redirects to https://localhost:8400

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
When I execute "az login" I get prompted for my username and password and MFA approval.  After this, I get redirected to https://localhost:8400/?code={super secret code}&state={super secret state}&session_state={session_state guid}
the "az login" command just hangs and has to be terminated with ctrl-c.  upon doing this, I am not authenticated to auzre.
this makes it impossible for me to use the az cli
I have uninstalled and re-installed az cli
I have rebooted my computer
the problem persists
To Reproduce
execute "az login" from command shell
Expected behavior
az login should redirect to the authenticated page
Environment summary
OS Name:                   Microsoft Windows 10 Enterprise
OS Version:                10.0.19041 N/A Build 19041
azure-cli                          2.9.0
command-modules-nspkg              2.0.3
core                               2.9.0
nspkg                              3.0.4
telemetry                          1.0.4
Extensions:
interactive                        0.4.3
Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\khill.azure\cliextensions'
Python (Windows) 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 02:47:15) [MSC v.1900 32 bit (Intel)]
Additional context

add to S174

cc @arrownj  for awareness

The redirect URL's protocol is https which is not valid for localhost (only http is valid as no valid certificate can be issued for localhost except for a self-signed one):
https://localhost:8400/?code={super secret code}&state={super secret state}&session_state={session_state guid}
^^^^^

You may follow https://github.com/Azure/azure-cli/issues/10426#issuecomment-528308713 and see if you are unblocked after removing localhost from security policies.


CheckPrivateLinkServiceVisibility api in network has changed

request:
    body: '{"privateLinkServiceAlias": "mypls.00000000-0000-0000-0000-000000000000.azure.privatelinkservice"}'
    headers:
      Accept:
      - application/json
      Accept-Encoding:
      - gzip, deflate
      Connection:
      - keep-alive
      Content-Length:
      - '98'
      Content-Type:
      - application/json
      User-Agent:
      - azsdk-python-azure-mgmt-network/11.0.0 Python/3.6.9 (Linux-4.9.184-linuxkit-x86_64-with-Ubuntu-18.04-bionic)
    method: POST
    uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test_cli_mgmt_network_endpoint_test_network89b511ec/providers/Microsoft.Network/locations/eastus/checkPrivateLinkServiceVisibility?api-version=2020-04-01
  response:
    body:
      string: 'null'
    headers:
      azure-asyncoperation:
      - https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Network/locations/eastus/operations/93d10632-9dba-4dab-9763-ec8705fbd40e?api-version=2020-04-01
      cache-control:
      - no-cache
      content-length:
      - '4'
      content-type:
      - application/json; charset=utf-8
      date:
      - Fri, 22 May 2020 09:37:48 GMT
      expires:
      - '-1'
      location:
      - https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Network/locations/eastus/operationResults/93d10632-9dba-4dab-9763-ec8705fbd40e?api-version=2020-04-01
      pragma:
      - no-cache
      server:
      - Microsoft-HTTPAPI/2.0
      - Microsoft-HTTPAPI/2.0
      strict-transport-security:
      - max-age=31536000; includeSubDomains
      x-content-type-options:
      - nosniff
      x-ms-arm-service-request-id:
      - 746f965a-4c48-49ac-8842-55546ee5664e
      x-ms-ratelimit-remaining-subscription-writes:
      - '1199'
    status:
      code: 202
      message: Accepted

This  checkPrivateLinkServiceVisibility api returned an unexcepted code 202. I think it has been change to a LRO method, but hasn't been updated in swagger.

#11601

That should be a critical bug fix in Swagger, not something you workaround here, just my two cents. CC @RodgeFu

+1, let's wait for network team to confirm the behavior change and work with them to fix the swagger. thanks.

@00Kai0 could you check if this is still reproable?


[playground] change pattern display

ast-grep now uses custom data structures to represent patterns.
Playground should show the new pattern display

fixed


ERROR TypeError: Object doesn't support property or method 'contains'

Hi guys,
I have a project on Angular 5 and use ng2-ckeditor Version 1.1.13.
I've got an error in IE 11;
ERROR TypeError: Object doesn't support property or method 'contains'
It complains that document.contains doesn't exist.
I've found a solution all that needs to change is:
 if (this.instance || !document.contains(this.host.nativeElement)) {     return;   }
to
 if (this.instance || !document.body.contains(this.host.nativeElement)) {    return;   }
in ckeditor.component.js

Hi guys,
When will the enhancement code be committed in the repo? In need of the editor in IE.  Awaiting the commit!!

Hi guys!
I have a similar problem. I'm looking forward to fixing

I can reproduce the error in IE 11:


Is utteranc.es down?

Hello, I found out that website, mentioned in configs and other places https://utteranc.es/ can not be open.
I am wondering is it my local issue or website is broken?

It works for me

I had a similar issue, but it was due to a global cookies ban on the browser I was using at the time. when cookies are disabled, the widget doesn't render. check your console, see if anything is throwing from the utterances script?

In Belarus it does not work, also checked with some people in the country. Seems IP in the blacklist of provides or maybe even the government. Seems I need to run own copy of the bot. So, closing.


Usernames cannot contain spaces nor special characters

A specific account with space in her username was breaking the reverse search regex and pages like the Caipyra 2017 weren't loading properly. I logged into the server and replaced the space in the username by an underscore. We still have to validate the username before saving to the database.

Fixed on commit b59f21ee28cc8eaf56cbc49fd7926e243e92276f


Fix association type error while using Globalize

If you use Globalize gem, it adds Class::Translation to Class model.
Then you use GraphQL::Sugar, it tries to convert this class to GraphQL type, but it searches for Types::Class type which does not exist.
In this pull request I've changed searchable type name to Types::ClassTranslationType, so it can be simply created like other classes in app/graphql/types directory.
So you can set there all translatable fields you need like:
module Types
  class UserTranslationType < BaseObject
    model_class User::Translation

    attributes :locale, :first_name, :middle_name, :last_name
  end
end

and use such queries:
query {
  user {
    id
    email
    translations {
      locale
      firstName
      middleName
      lastName
    }
  }
}

@dolfinus This looks great! Love how you dug in and found our support-1.8 branch even though we haven't published any docs about it yet. 🙌
I also tested this code locally with one of our live projects, and all our tests ran - so we should be good! Thanks for contributing.


Fork, Commit, Merge - Easy Issue (PHP) #375

Description

Additional Context

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Fix document about scrolling docs backwards

A better key mapping, corresponding to <C-f>, for scrolling docs backwards is <C-b> because it is used for scrolling backwards in Vim (:h CTRL-B).
If you have purposely written <C-d>, close this PR. Thanks.

LGTM.


Add on for README

Hello, after some issues raised, there are codes add on to define triton engine args (e.g. ports, triton version) but the usage of these are not updated to README nor the --help yet.
Also it is not very clear the purpose of certain args like project name, name even after reading the --help.
Perhaps these can be updated in the README, so easier to use it.
This is also related to my failed attempt to use my own ClearML server and Triton setup with ClearML serving.
Suspect it might be due to familiarisation of these args and also might have gaps in implementation. But suggest to get the args right first, so that I can test out further.

Hi @okyspace
I'll try to shed some light on the mechanics of clearml-serving (If this is successful we could make it into a proper doc :)
Basically we have two Tasks, the first is the control-plane Task, it stores the configuration on the serving engine, the models that needs to be server etc.
Task (1) will be checking for new models published in the clearml Model Repository, and updating the model-ids on the endpoint configuration the Task itself stores.
The second Task (2) is actually running the Triton serving engine itself. You can think of Task (2) as a sidecar managing the Triton server inside the Triton container (Notice Task(1) is actually executed on a different machine in a different container)
Task (2) monitors the changes of the configuration of Task (1), whenever a new endpoint or model changes, it will download into the container the new model, then configure the Triton server that is running as a subprocess next to it, to use the new model.
Task(2) will also report the serving engine statistics back to Task(1).
If you wonder why we need two Task, the reasoning is that we could have multiple instances of the Triton engine, i.e. multiple Task(2), for example Task(2a) and Task(2b) all syncing back to the main Task(1).
The arguments --project and --name will set Task (1) project/name.
This is because all the information we need to monitor the serving engine will appear on this Task.
Does that help? What else are we missing here?

@bmartinn, thanks for the clarification. These are probably missing, which I didn't manage to find them in README nor --help.

usage of --engine-container, --engine-container-args to define your own triton settings. (e.g. ports, version, polling rate) which was added on in v0.3.3 if not wrong.
A way to config to use own ClearML server and Triton, which I understand it might not be working as of now.

usage of --engine-container, --engine-container-args to define your own triton settings

Following on the previous example, Task (2) (running the Triton engine) is executed by the clearml-agent specifically it will use the default Triton engine container nvcr.io/nvidia/tritonserver:21.03-py3 , then inside he container it will launch the sidecar process, that will in turn launch the engine monitor it. To allow the user to upgrade to latest Triton engines or custom container, we added the ability to specify the Triton container to user as well as additional docker arguments to be executed by the cleaml-agent when spinning the container.

A way to config to use own ClearML server and Triton, which I understand it might not be working as of now.

ClearML-server and Triton are working, nothing to worry :)
Notice that the clearml-server is only the control-plane, running Task(1), it does not do the actual serving. The spinning of the serving engine itself is done via the cleaml-agent.
Specifically let's assume we have clearml-server running on machine A (cpu-only), and machine B (gpu machine) running clearml-agent attached to one the the GPUs.
The clearml-serving (executed on a 3rd machine, say laptop), will configure the control Task (1) and spin it on the services queue, running on the clearml-server, then it configures Task (2) the serving engine, on Machine B, the GPU machine, by creating the Task and pushing it to the GPU queue.
Does that make sense ?

@bmartinn, thanks for the explanation.
Apologies for taking awhile to work on this, as was busy with other stuffs.
I tested --engine-container and it works.
But for --engine-container-args '-p 9000:8000 -p 8001:8001 -p 8002:8002 --model-control-mode poll --repository-poll-secs 5', there are errors stating that unknown flag: --model-control-mode.
This is the standard flag for triton, so I couldn't figure out why triton could not find this flag. Appreciate your help.

Hi @okyspace
I think the "  --model-control-mode poll --repository-poll-secs 5" are parameters that need to be passed  to the triton process, not the container launch command itself (of example the "-p 9000:8000 -p 8001:8001 -p 8002:8002" are port mapping arguments passed to the docker runtime when spinning the container)
If you want to change the Triton process arguments, first find for the triton Task on the clearml UI (default project DevOps name should be "triton serving engine").
Then under the Configuration tab of the Task, look for "Args"  section, and add the following key/value entries: "t_model-control-mode", "poll" and "t_repository-poll-secs", "5"
(Notice we add "t_" prefix to any argument that will be passed to the engine itself).
With all the above said, I think we should add it as a CLI argument to clearml-serving, wdyt?

With all the above said, I think we should add it as a CLI argument to clearml-serving, wdyt?
Yes, I think it might be beneficial to allow developer to have more detailed control of the serving engine.

Yes, I think it might be beneficial to allow developer to have more detailed control of the serving engine.

Sounds good to me, let's add them :)

Closing this issue as inactive, feel free to open a new issue and link to this one.


python3Packages.icmplib: init at 2.0.1

Motivation for this change
Python implementation of the ICMP protocol.
https://github.com/ValentinBELYN/icmplib
This is a Home Assistant dependency.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 109294 1

3 packages built:

python37Packages.icmplib
python38Packages.icmplib
python39Packages.icmplib

Result of nixpkgs-review pr 109294 1

3 packages built:

python37Packages.icmplib
python38Packages.icmplib
python39Packages.icmplib

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109294 run on x86_64-linux 1

3 packages built:

python37Packages.icmplib
python38Packages.icmplib
python39Packages.icmplib

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109294 run on x86_64-linux 1

3 packages built:

python37Packages.icmplib
python38Packages.icmplib
python39Packages.icmplib

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109294 run on x86_64-darwin 1

3 packages built:

python37Packages.icmplib
python38Packages.icmplib
python39Packages.icmplib

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 109294 run on x86_64-darwin 1

3 packages built:

python37Packages.icmplib
python38Packages.icmplib
python39Packages.icmplib


activeClassName being applied to multiple Link components

The activeClassName prop is being applied to multiple Link components even though separate routes are currently active. Here's my routing setup:
React.render((
    <Router history={createBrowserHistory()}>
        <Route path="/" component={Dashboard}>
            <Route path="servers" component={ViewServers} />
        </Route>
    </Router>
), document.getElementById('dashboard'));

And here's a screenshot of what I'm on about:

This screenshot is taken when the /servers route is active, and the Servers link is highlighted, but so is the Dashboard link, even though it is not meant to be. Any ideas on how to prevent this from happening?

Thanks for your question!
We want to make sure that the GitHub issue tracker remains the best place to track bug reports and feature requests that affect the development of React Router.
Questions like yours deserve a purpose-built Q&A forum. Would you like to post this question to Stack Overflow with the tag #react-router? https://stackoverflow.com/questions/ask?tags=react-router.
We also have an active and helpful React Router community on Reactiflux, which is a great place to get fast help with React Router and with the rest of the React ecosystem. You can join at https://discord.gg/0ZcbPKXt5bYaNQ46.


Add support for Finch in the Kind project

What is the problem you're trying to solve?.
Kind project cannot be used with finch. It requires running podman and finch altogether
Describe the feature you'd like
Work with the Kind community to add support for finch, the same way it exists for podman

@weikequ nice to meet you during Linux OSSummit NA 2023, I'm interested on using kind on macOS using finch also.
Here is the issue I mentioned related to nerdctl https://github.com/containerd/nerdctl/issues/349#issuecomment-1556229062
@BenTheElder made a comment 3 days ago.
Please comment in this issue, if kind support is something the project wants to add and how the community can help with this.
cc @estesp

Am I gathering correctly that this tool is used to create a VM running containerd is based on lima, similar to colima, rancher desktop etc?
nerdctl support is something kind is considering, but not committed to yet -- similar VM environments can support docker or podman, and docker in particular has some very helpful additional features that aren't easily replaced (we still don't have full parity with the podman backend), and we require most of our time currently for more general bug fixes / maintenance vs feature work (or feature review).
See the linked threads in nerdctl and from there KIND for more context.

Am I gathering correctly that this tool is used to create a VM running containerd is based on lima, similar to colima, rancher desktop etc?

Yes, Finch = (today) macOS command line client support, using Lima + containerd + nerdctl + BuildKit inside the VM instance (based on Fedora). So, very similar to colima and Rancher, although both those tools can/do provide the Docker engine inside the VM as well/optionally.

nerdctl support is something kind is considering, but not committed to yet -- similar VM environments can support docker or podman, and docker in particular has some very helpful additional features that aren't easily replaced (we still don't have full parity with the podman backend), and we require most of our time currently for more general bug fixes / maintenance vs feature work (or feature review).
See the linked threads in nerdctl and from there KIND for more context.

I wonder if this table (https://github.com/containerd/nerdctl/issues/349#issuecomment-979015373) is still the right list of missing features or if anything has changed in 18 months? Nerdctl has had a lot of development since then and is at version v1.4.0 (that table notes the version at the time being v0.14.0) // cc: @AkihiroSuda


scale down images

Relates to #454
Scales several images down to smaller dimensions to fit more nicely in the content. In many cases this was to reduce the width to 500px and scale the height appropriately

Really awesome work! Makes everything look much neater. I think these two comics below look a little fuzzy, is it like that for you?

Images are enhanced and, on average, a smaller file size, so that's good


Katex can't render cross

Some blog deployers which use markdown to write article(such as hexo), will parse the line break to
(there is line break when writing matrix or piecewise function), but katex can not render the math formula crossing
.

Agreed.  Please open a ticket with hexo-katex.


jsdom > 11.1 breaks the build

Problem description
a1a17995202db7f669451ad41690fc5e126a770c
This direct commit broke the build, though I see no obvious reason why.  I am reverting that in #7890 so I can get it merged.  We need to address jsdom separately.
/cc @oliviertassinari

Ran yarn upgrade jsdom which went to ^11.2.0, and immediately yarn test:unit presents many errors.

I confirm, I have been struggeling on this one to.

This looks like a regression given the tests are working in a real browser. #1959

I'm closing the issue. I would rather not update jsdom and wait to see the issue fixed in the future than going down the rabbit hole 🐇 . Can be very deep.


Gradle image does not contain a JDK

Somehow I was able to get it to build with a simple project but I'm not quite sure why. Creating this issue to look into what's going on.

https://github.com/chainguard-images/images/pull/522


Initial guide >= stub. Includes hints.

This is a pretty easy problem, so I had problems coming up with hints that did not give the problem away.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

@thecodingaviator Are you ok with the committed changes?  If so, please merge.  Thanks.

@RandellDawson I haven’t tested the solution yet. Have you by any chance done it?

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Reason:  This is not a full working solution.  It returns the ip address "<IP_ADDRESS>" instead of the user's ip address.
Thank you and happy coding.


Multi-Multi-ModelError

We currently have the option to combine multiple parameters to joint parameter lists and, accordingly, multiple model errors to a MultiModelError.
Do we need another recursive layer around this to allow arbitrary combinations? If so, how?
ME1(P1) \
ME2(P2)  | => MutliME1([P1, P2, P3]) \
ME3(P3) /                             | ==> MultiME3([P1, P2, P3, P4, P5]
                                     /
ME4(P4) \ => MultiME2([P4, P5])
ME5(P5) /              ||
                       \/
# OR       /  MultiME4([P6, P4, P5])
ME6(P6)  /

I think in the current development phase, this is not necessary. I would start thinking about this as soon as there is a direct requirement.

I think in the current development phase, this is not necessary. I would start thinking about this as soon as there is a direct requirement.


Tab auto-completion on -IP comes back as -IPs which does not match examples

Tab auto-completion on -IP comes back as -IPs which does not match examples

I have added -IP as alias to -IPS. Should fix your issue. Please verify and let me know. Generally both worked before due to how PowerShell allows you to not type whole parameter name but this one should make sure you can use tab auto-completion.

-IP and -IPs both worked before. Your readme examples shows -IP and would tab autocomplete shows -IPs which makes it a little confusing. I did an "update-Module PSBlackListChecker" and now both -IP and -IPs autocomplete so I would call it fixed. Thank you for the quick response.


Imaging-134

At time I can only throw a proper exception. RST markers are valid markers in entropy data so the  exception message observed in IMAGING-97 and IMAGING-134 was misleading. I can not add the missing feature yet. But I added DRI and RST markers to the JpegConstants and JpegUtils class.

Closed by #47
Thanks!


dotnet format

Added pragmas
dotnet format
Disabled var_elsewhere

With this I think we can enforce dotnet format on all changes via dotnet format --verify-no-changes

@iamcarbon I think this works OK. Any thoughts?

@iamcarbon or @aseigler Would be interesting to see if you clone this branch and run 'dotnet format', do you see no changes?
The build was triggering changes on windows but not mac.


How to publish build artifacts using azure-pipelines.yml very hard to discover

There's nothing in this document, and searching I've mostly ended up here:
https://docs.microsoft.com/en-us/azure/devops/pipelines/release/artifacts?view=vsts
Which says nothing about azure-pipelines.yml. Finally, I found this:
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/utility/publish-build-artifacts?view=vsts
Perhaps the answer is within, it's not clear yet.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7458d5b2-1bb7-7d87-7ce6-2b0c430b0155
Version Independent ID: edf5bbd3-a3f0-5426-e985-31290f8afd05
Content: YAML schema - Azure Pipelines
Content Source: docs/pipelines/yaml-schema.md
Product: devops
GitHub Login: @erickson-doug
Microsoft Alias: macoope

Hi @foolip , thanks for the feedback.
I'm currently working on something that will help with this issue. Namely, I'm updating this document on build artifacts to include yaml instructions:
https://docs.microsoft.com/en-us/azure/devops/pipelines/build/artifacts?view=vsts
I believe the YAML schema document is fine, it covers the broader concept of "Tasks" in YAML and then links to this catalog of tasks that you can use, which includes publishing build artifacts.

Great, that is the documentation I ended up at, so unless examples there would have been great.

Closing this as I've made the update mentioned above and I think we are in a good spot :) please feel free to reach out if you think otherwise, @foolip !

@elbatk is it https://docs.microsoft.com/en-us/azure/devops/pipelines/build/artifacts?view=vsts that was updated?
Following the link from there to https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/build-artifacts?view=azure-devops&tabs=yaml does have an example, so that looks good. Thanks!


Allow user to add arbitrary values for fancy multi select

This is likely a cmdk issue; yet, I was wondering if it's possible to allow a user to enter arbitrary values for the fancy multi select component.

Found it on my own

what was the solution @kalaschnik ?

I stripped away a lot of stuff that is not needed for this purpose. I also put the user-provided values into the router. Here is a demo:
https://codesandbox.io/p/devbox/amazing-feather-4y53k7


messageStore no effect at all

Verify latest release

[X] I verified that the issue exists in the latest chatgpt release

Verify webapp is working

[X] I verify that the ChatGPT webapp is working properly for this account.

Environment details
 const redisUrl = process.env.REDIS_URL || 'redis://localhost:6379'
  const store = new KeyvRedis(redisUrl)
  const messageStore = new Keyv({ store, namespace: 'chatgpt-demo' })

 const api = new ChatGPTAPI({
      apiKey: process.env.OPENAI_API_KEY,
      messageStore
    })

Describe the Bug
I used messageStore. Although there was no error reported, it had no effect at all, nor did I automatically create the Redis database. However, I can manually use the messageStore.set method

my self bug


[FLINK-19513][docs] Update docs/build_docs.sh to support the new parameters f…

What is the purpose of the change
Because watching is the default for serve since 2.4.0, we use --force_polling for regenerating the docs.
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

The doc building seems to work w/o this PR. Hence, I will close it.


Error on .map file assets/css/just-the-docs-default.css

I am not a web developer but there is a problem about generated .map file for assets/css/just-the-docs-default.css
Source map error: Error: JSON.parse: expected ',' or ']' after array element at line 56 column 1018 of the JSON data

As like i said before i am not a web dev but when i make a css lint check it is giving error on this line
Parsing Errors  Expected RBRACE at line 251, col 62.
.main-content dl { display: grid; grid-template: auto / 10em 1fr; }

Filed an issue upstream. Since this isn't breaking user experience, we can wait for a fix.

@captn3m0 it looks like there is a MR ( MergeRequest/PullRequest) on upstream about this issue.
It looks like this will be fixed soon :
https://github.com/jekyll/jekyll-sass-converter/pull/123/files

@captn3m0 looks like that patch is already merged, are we using merged version of jekyll-sass-converter (or newer version ) ?
if we are , we need to check if that bug still exist or not then if it doesn't exist any more mark this  issue as fixed and close it

hmm looks like it is merged but they didnt release a newer version (which includes that merge ) so we need to wait more for a new release tag

@captn3m0 https://github.com/just-the-docs/just-the-docs/issues/685 closed so i think this bug needs to be closed too ( if it solved problem )

It's still unreleased: https://github.com/just-the-docs/just-the-docs/pull/779

This issue will probably be fixed by #2243.

Closing this issue as it should have been fixed by https://github.com/endoflife-date/endoflife.date/pull/2243.


dts: arm: renesas: ra4: Defining MSTP regs in devicetree

Add a definition for RA4, which was not included in #76820.

still failing

@nashif

still failing

Sorry, I didn't mark it as draft and instead waited for the results of the CI build.
I'm submitting it again. I'll remove it from draft once the CI has passed.


fix stub mapping http endpoint

This was seemingly changed at some point (based on https://github.com/wiremock/wiremock/issues/253#issuecomment-84376794) and I'm guessing this got missed because it is corrected elsewhere in the documentation.
References
https://wiremock.org/docs/stubbing/#basic-stubbing:

You can configure stubs using JSON configuration files or code:

1. Via a `.json` file under the `mappings` directory
2. Via a POST request to
`http://<host>:<port>/__admin/mappings` with the JSON as a body
3. From code using one of the SDKs

Submitter checklist

[ ] The PR request is well described and justified, including the body and the references
[ ] The PR title represents the desired changelog entry
[ ] If the change against WireMock 2 functionality (incompatible with WireMock 3),
it is submitted against the 2.x branch
[ ] The repository's code style is followed (see the contributing guide)

Details: Contributor Guide

Great spot.  Many thanks for your contribution


would be nice to search for tests (by pattern) in SUnit browser

the scope for search would only be the test methods ... combined with viewing source, this would be real useful

@dalehenrich  Are you suggesting a wild-card type search similar to Browse Implementors or Browse Senders?

@ericwinger since it was over a year ago, I don't recall recall the details of what I was thinking ... I had a similar need over the weekend where I wanted to find all of the test methods with 495 in the selector ... so wild card search would be useful ... the technique used in implementors and senders is somewhat annoying to me - when I looking for a pattern match I really want to see all of the methods that match my pattern --- having to choose from a secondary list of selectors (especially when there are a bunch of matches) is very difficult, because if my first choice doesn't yield the method I am looking for I have to remember the discarded selectors and select another likely symbol.
I am using the selector pattern to find likely methods where I actually read the method or look at the class to know if it is the one(s) I am looking for.
Also, when I have a lot of possible symbol matches it is a complete waste of my time to select a likely symbol only to find that there are no methods with that selector ...


helm install - write output to file

updated the helm install command to write output to istio.yaml, see
https://github.com/istio/istio.github.io/issues/1409

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mukundha
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
Assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @mukundha. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @geeknoid


Scheduled query rules CMK check flag, stateful alerts and 1-minute frequency

Resource Provider
Scheduled query rules
Description of Feature or Work Requested
We added stateful log alerts (autoMitigate flag, alerts that automatically resolve), a flag to check if LA has linked storage (for CMK policy) and 1-minute frequency alerts.
Minimum API Version Required
2021-02-01-preview
Swagger Link
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/Microsoft.Insights/preview/2021-02-01-preview/scheduledQueryRule_API.json

monitor

@yanivlavi I get an error from new-version api that "(BadRequest) Alert rule payload cannot be empty". What does this mean?

@avjerafi Can you help here?

@kairu-ms This looks like the result of an unexpected parsing failure of some kind. Can you please share the body of the request?

@avjerafi I created a VM and tried to create a scheduled query for it. Below is the body of request.
{
   "location":"westus",
   "kind":"LogAlert",
   "properties":{
      "description":"Test rule",
      "severity":2.0,
      "enabled":true,
      "scopes":[
         "/subscriptions/0000000000000000000000000000000/resourceGroups/kairu/providers/Microsoft.Compute/virtualMachines/kairu-ws"
      ],
      "evaluationFrequency":"PT5M",
      "windowSize":"PT5M",
      "criteria":{
         "allOf":[
            {
               "query":"union Event, Syslog | where TimeGenerated > ago(1h)",
               "timeAggregation":"Count",
               "dimensions":[],
               "operator":"GreaterThan",
               "threshold":360.0,
               "failingPeriods":{
                  "numberOfEvaluationPeriods":1,
                  "minFailingPeriodsToAlert":1
               }
            }
         ]
      },
      "muteActionsDuration":"PT30M",
      "skipQueryValidation":false,
      "autoMitigate":false
   }
}

@kairu-ms The error is caused by the Severity value being provided as a float instead of as an integer.
Please use:
      "severity":2,
instead of:
      "severity":2.0,
@yanivlavi We should have validated the datatype and returned a specific validation error. I've opened a ticket for this.

@avjerafi The return value 'checkWorkspaceAlertsStorageConfigured' of is null, however its value type is bool in swagger

Swagger updated by PR https://github.com/Azure/azure-rest-api-specs/pull/14942

https://github.com/Azure/azure-cli-extensions/pull/3753


the dialog box for downloading the graph gets superimposed to the graph in a confusing way

the dialog box for downloading the graph gets superimposed to the graph in a confusing way:

closed with #7


duplicate enableHttpMethodParameterOverride calls

Laravel Version: 5.3
PHP Version:
Database Driver & Version:

Description:
I was just researching the request life cycle of a laravel application when I saw the duplicate enableHttpMethodParameterOverride() calls in the $request->capture method & kernel handle Method. The problem is that in the public\index.php of the laravel application the kernel handle method is called with the parameter of $request::capture. The $request::capture method calls enableHttpMethodParameterOverride() and returns a $request. The kernel handle also calls $request->enableHttpMethodParameterOverride(). I see duplicate function calls. Am I wrong.

Thank you for reporting, I've made a PR that removes it from capture, let's see if it was there to handle a case we don't know about :)
https://github.com/laravel/framework/pull/16013


How to get a list of tags?

Is it possible to obtain a list of tags using qualysapi?
Eventually, I am looking to create an Asset Tag with a condition of IPRange = X.X.X.X to Y.Y.Y.Y
Tried using Groovy but the documentation doesn't provide information if such a method as hasIPRange() exists.
Tried creating the file.xml as below but the error is simply not verbose enough.
<?xml version="1.0" encoding="UTF-8"?>
 <ServiceRequest>
 <data>
  <Tag>
   <name>UnixQualysTag</name>
   <ruleType>Asset Search</ruleType>
   <TAG_CRITERIA><IP_RANGES><IP_RANGE>X.X.X.X-Y.Y.Y.Y</IP_RANGE></IP_RANGES></TAG_CRITERIA>
   <created>2014-02-06T19:14:50Z</created>
   <modified>2014-02-06T19:14:50Z</modified>
   <color>#FFFFFF</color>
  </Tag>
 </data>
</ServiceRequest>

XX:qualys vgori$ curl -u "username:password" -H "Content-type: text/xml" -X "POST" --data-binary @- "https://qualysapi.qualys.com/qps/rest/2.0/create/am/tag" < ./file.xml
Error:
<?xml version="1.0" encoding="UTF-8"?>
<ServiceResponse xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://qualysapi.qualys.com/qps/xsd/2.0/am/tag.xsd">
  <responseCode>INVALID_REQUEST</responseCode>
  <responseErrorDetails>
    <errorMessage>modified: An error occurred while validating the element. Please contact your account manager..</errorMessage>
  </responseErrorDetails>
</ServiceResponse>

I was able to figure out the xml format. It is as shown below:

UnixQualysTag
<TAG_CRITERIA><IP_RANGES><IP_RANGE><IP_ADDRESS></IP_RANGE></IP_RANGES></TAG_CRITERIA>
ASSET_SEARCH

Glad you figured it out!  YOu can also get a list of all tags using the qps/rest/2.0/search/am/tag/ API with an empty results XML POST data:


feat: added support for dremio arrow flight dataset

Description
This pull request contains changes for the implementation of the Dremio Arrow Flight RPC as a Kedro Dataset.
Development notes
This is still work in progress.
Checklist

[x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added a description of this change in the relevant RELEASE.md file
[ ] Added tests to cover my changes

Hello @elanqo! If the PR is not ready yet, you can reopen it and keep it as a draft, no worries. Thank you for starting this contribution!


Add intro screen

New version of the original PR https://github.com/dat-land/dat-desktop/pull/498 by @aks-, with the branch available in this repository.

LGTM now :)

yeap, looks good and works good now

I merged #507 into this branch (to test it out) and it shows the tutorial screen for a little until the persisted dat data is loaded. This can be partly mitigated by having a dedicated showIntro action rather than a hideIntro action. So my request would be to flip that the default-state is not intro but rather loading or startup with a dedicated action triggering the intro.

This can also be reversed: If we do that and the user opens the app when the intro needs to be shown, there will be a quick flash too.
I think this means we need to introduce not just showIntro but also showTable, so there's an anticipated state before either are visible.

So my request would be to flip that the default-state is not intro but rather loading or startup with a dedicated action triggering the intro.

Well, the "loading" screen in my opinion should be a show/hide of the browser window:
https://github.com/electron/electron/blob/master/docs/api/browser-window.md#using-ready-to-show-event

Do you mean we shouldn't show the window at all before it has finished loading its internal state?

@juliangruber exactly.

Let's fix the flashing in another PR, ok?

btw, I can't approve because I created this PR (using @aks-'s branch), so someone else will have to do so.


Empty indices break platemap2samp.py

A user has discovered that empty values for "index" or "index2" in the plate maps break platemap2samp.py.
For now, the workaround is to fill those well positions with junk index sequences.

Proposed fix is just to remove those well positions from the exported SampleSheet.


Bump WinAppSDK to v1.2

Summary of the Pull Request

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@stefansjfw With 1.2 we should be able to remove the if(IsTitlebarCustimization statement everywhere, as this will work on W10 now as well!

@stefansjfw With 1.2 we should be able to remove the if(IsTitlebarCustimization statement everywhere, as this will work on W10 now as well!

I can remove that.. Although, https://learn.microsoft.com/en-us/windows/windows-app-sdk/api/winrt/microsoft.ui.windowing.appwindowtitlebar.iscustomizationsupported?view=windows-app-sdk-1.2#remarks this still says it's only win11 ?

I see winappsdk 1.2 release notes that says win10 is ok after v1809.. So I guess docs aren't updated. Change pushed. @niels9001 can you take a look

@niels9001 Why don't we do the same for Settings window - titlebar ?

Here's the screenshot. Win11 on the left, win10 VM on the right. @niels9001 looks ok, right?

Here's the screenshot. Win11 on the left, win10 VM on the right. @niels9001 looks ok, right?

Look great :)

@niels9001 , This is what happens when going from light mode to dark mode on Windows 10:

Doesn't look good but I don't think it's a blocker.

@niels9001 , This is what happens when going from light mode to dark mode on Windows 10:

Doesn't look good but I don't think it's a blocker.

Yeah looks like we need to add some additional logic on themeswitching for the Titlebar.. agree, not a blocker and something we can fix. (I think ideally we should create a proper TitleBar component that does all of this and can be re-used).

Btw, funny that
ExtendsContentIntoTitleBar = true;
works better than
AppWindow window = this.GetAppWindow();
window.TitleBar.ExtendsContentIntoTitleBar = true;
I'd expect it to behave at least the same :D

Tested Hosts and File Locksmith and there is a bug: when the window is resized from the top border the windows is moved instead.

From the top of my head: it might be possible that the click actually grasps the (extended) content of the window now, which would mean it deals with the drag area:

You can set AppWindowTitleBar.ExtendsContentIntoTitleBar to true to extend content into the title bar area, and SetDragRectangles to define drag regions (in addition to other customization options).

@stefansjfw I noticed something like that too. This should work:
        public MainWindow()
        {
            this.InitializeComponent();
            ExtendsContentIntoTitleBar = true;

@stefansjfw I expected the same result too.
I Will test changes on Windows 10 this evening.

@niels9001 was there an issue opened to cleanup titlebar handling? Can't find it...


Request for demos of FaceChain-ImagineID

Thanks for the opensource.
But can you provide ways for me to find demos of of FaceChain-ImagineID.
Thanks.

We are currently busy with several other FaceChain-related papers. Once this month's busy period is over, we will prioritize organizing them as soon as possible.

Thanks


Consider porting vim mode's incremental search to regular search addon

@mightyguava, I think the work you've done here: https://github.com/codemirror/CodeMirror/blob/e359853f6a0ec508e768a55c45cde013e8fc34b1/keymap/vim.js#L1239 is excellent. I would also love if a lot of these features (up/down to navigate search history, live updating of matches without having to hit enter) should also be in the core search addon. Is there some way I can cajole you to port it over? :)

@vincentwoo glad you like it. I think search history and incremental search are both useful things that could benefit the core search addon as well. Unfortunately nowadays I only have the time to make bugfixes to the vim keymap. I took a look at the code, and based on the way these are implemented in the vim mode I'd have to rebuild most of the functionality. I don't have the appetite to take this on at the moment.
I might come back to this later when I have more time, or I'm available for pull requests or advice if you are interested in doing it.

I don't quite have the time right now either, so let's leave this issue as a TODO for now. Maybe some of the other enterprising contributors could take a whack at it.


Getting precommand and postcommand output. How to disable?

Today I noticed getting the following output on executing any commands:
$ (master) echo "hishtory"
echo "hishtory"
__hishtory_precommand
hishtory
__hishtory_postcommand;
__hishtory_precommand

Not sure what I did. How do I disable this? Couldn't find anything in help or the readme. Thanks.

FYI:
$ (master) bash --version; hishtory status
bash --version; hishtory status
__hishtory_precommand
GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
__hishtory_precommand
hiSHtory: v0.277
Enabled: true
Secret Key: bb94e3c6-fe80-45f7-8b19-bc198fc08f74
Commit Hash: c3f9ba3bab26879d84ce52699d33c19523a9c4d8
__hishtory_postcommand;
__hishtory_precommand

Update. I was playing around with my bash command and noticed that after executing the command:
$ bash

which I believe sources my ~/.bashrc file, the precommand and postcommand output stopped. What's going on?


build(github): add common 'labels.json'; update release drafter config

As discussed in the org meeting we aim for consistency in the labels used on the engine and in modules. This PR adds the common configuration to .github/labels.json, which can be used to sync labels with https://github.com/Financial-Times/github-label-sync
We are at 32 labels now, which you can view on https://github.com/Nanoware/BrokenModule/labels. We removed a few labels as discussed in the meeting, but ended up adding two more back in: Topic: AI and Topic: Stabilization.

Common labels have been applied to all modules and this repository. From the root of the engine workspace, it can be applied to other repositories by running
github-label-sync --access-token $GITHUB_TOKEN --labels .github/labels.json $org/$repo


WIP: Rewrite Croppie in TypeScript

I've rewritten Croppie in TypeScript.
It kinda should work. Rotation is still not working yet. Don't know why. Rotation now works.
Feedback is welcomed.

@sarunint How goes the progress on this? I'd be happy to help.


Added my name & details to GSoC-Interest

Signed-off-by: Parth Sharma<EMAIL_ADDRESS>

Hi @GeorgLink, I have added the link to my proposal.

Quick reminder, that the finished project proposal has to be submitted on the official GSoC website as well.


national reddit and twitter gifs

2:1 aspect ratio gifs

Haven't merged this because I think you were going to speed up the twitter one, unless that doesn't matter for this PR.

@lindsaycarr added the speed-up commit


Store pwa-hide-install in localStorage instead to prevent re-notification all the time

Each time I load my app, the PWA install prompt appears even though I have dismissed it. This is because the pwa-hide-install value is stored in session storage rather than somewhere more permanent. This may be intentional/desired though?
Possible Solutions

Add a parameter to allow users to switch to localStorage over the current default.
Or switch to localStorage entirely. If there is a good reason to re-prompt, user should force the prompt instead. (note this would be a 'breaking' behaviour)

Yep that's a good idea. You can use the manual mode, but this can be a parameter I agree.


train

Easy to provide training code?

As mentioned in README, the training codes are currently not available.


Release Guide

Making releases still requires some effort, consists of mostly stereotype tasks, is time consuming, error-prone and requires concentration to have all the details correct to a pedantic level.
Depending on the project to release data needs to be entered or published into various places.
The current ticket aims to aid developers in aggregating the data as far as possible providing as much convenience as possible.

Closed with #274

Sample:


Allow user to limit # of characters to 10 or more

I was excited to see the new feature in 8.1.0 allowing the user to limit the number of characters from a field. Sadly, the field I'm trying to limit is a date, so I need 10 characters from it ('YYYY-MM-DD'). When I put "10" before the field name, it gets read as a "1". I can limit to 9 characters, which is frustratingly close to what I need. Any way to get that 10th character?

Nice to see someone using this new feature!  Its original intent was to limit the number of characters from1 to 9.  I see that this is too limiting for your needs.  So, its kind of a bug, kind of an enhancement.  Let me see what I can do.

Added code to support specifying more than 9 characters to include for an element.  In next release.


Re-implement ExprIdentifierVisitor::desc_expr to use Expr::Display

Which issue does this PR close?

Part of https://github.com/apache/arrow-datafusion/issues/3330
Rationale for this change

Expr already implements the Display trait so it doesn't seem necessary for ExprIdentifierVisitor to have an alternate way to build descriptions of Expr.
The ExprIdentifierVisitor::desc_expr also seemed inconsistent. In some cases, it would include expressions and in some cases it would not. It looks like it could produce the same description for different expressions.
What changes are included in this PR?

ExprIdentifierVisitor now just delegated to impl Display for Expr
Are there any user-facing changes?

Plans will look different

@waynexia Does this look reasonable?


HTTP1.1 error

python ver 3.5....
why this error..??
closure/goog/base.js existence

https://developers.google.com/blockly/hacking/closure
download success thanks

It looked in your original screenshot like you had the closure library set up correctly, did you have to do anything else to get it running?


Ed25519 private keys lack public key attribute

Tested on ubuntu 18.x openssl 1.1.1
Creating RSA and EC private keys having the public key included in the PKCS8 container works as expected:
openssl genpkey -algorithm EC -pkeyopt ec_paramgen_curve:P-256 -pkeyopt ec_param_enc:named_curve |  openssl pkcs8 -topk8 -nocrypt  > p256-private-key.pem

However, the corresponding command for Ed25519 does not:
openssl genpkey -algorithm ed25519  |   openssl pkcs8 -topk8 -nocrypt  > ed25519-private-key.pem

This is what I get:
-----BEGIN PRIVATE KEY-----
MC4CAQAwBQYDK2VwBCIEIPWCeU76Q422lF1aq5mjqE/nP/o8zEhF6gXX6Mzk9n+g
-----END PRIVATE KEY-----

I expected to rather get something like this:
-----BEGIN PRIVATE KEY-----
MFECAQEwBQYDK2VwBCIEINH5a/um17OOfX/asAKttGbNzYs0xiBB+f60wxaLphVegSEA/kms9bkr
bpI1lPLoM2j2gKySS+k89TOuyvgC43dX+Mk=
-----END PRIVATE KEY-----

@romen Any opinion on this one, please? Bug/feature? If feature, should be changed in 3.0?

@romen Any opinion on this one, please? Bug/feature? If feature, should be changed in 3.0?

This is due to differences in the standards for the way private keys are defined for different algorithms. For example this is the definition of an EC private key structure (from RFC5915):
   ECPrivateKey ::= SEQUENCE {
     version        INTEGER { ecPrivkeyVer1(1) } (ecPrivkeyVer1),
     privateKey     OCTET STRING,
     parameters [0] ECParameters {{ NamedCurve }} OPTIONAL,
     publicKey  [1] BIT STRING OPTIONAL
   }

As you can see the definition of the private key includes the public key (as an optional field).
By contrast the definition for Ed25519 (from RFC8410) is this:
   CurvePrivateKey ::= OCTET STRING

   To encode an EdDSA, X25519, or X448 private key, the "privateKey"
   field will hold the encoded private key.

So an Ed25519 is only the private key and not the public key as well.
Note that the PKCS8 standard that OpenSSL implements (from RFC5208) defines a PKCS8 private key structure like this:
PrivateKeyInfo ::= SEQUENCE {
   version Version,
   privateKeyAlgorithm AlgorithmIdentifier {{PrivateKeyAlgorithms}},
   privateKey PrivateKey,
   attributes [0] Attributes OPTIONAL }

So there is no possibility to incorporate the public key anywhere else other than embedded into the private key. By contrast later standards (RFC5958) updates PKCS8 private keys to this (renaming PrivateKeyInfo to OneAsymmetricKey):
     OneAsymmetricKey ::= SEQUENCE {
       version                   Version,
       privateKeyAlgorithm       PrivateKeyAlgorithmIdentifier,
       privateKey                PrivateKey,
       attributes            [0] Attributes OPTIONAL,
       ...,
       [[2: publicKey        [1] PublicKey OPTIONAL ]],
       ...
     }

So in this later version of the standard there is a separate field for encoding the public key. Unfortunately OpenSSL does not support this standard.
In practice this usually makes little difference since it is trivial in Ed25519 to infer the public key from the private key, and OpenSSL does this automatically:
$ openssl genpkey -algorithm ed25519  |   openssl pkcs8 -topk8 -nocrypt | openssl pkey -noout -text
ED25519 Private-Key:
priv:
    e5:5c:5f:72:4f:3c:71:ec:28:1f:98:3e:04:b5:d0:
    40:ef:d4:ad:40:ed:3f:9c:ac:2d:df:a3:56:fe:31:
    0b:c1
pub:
    9b:e8:1e:f8:85:ae:63:51:79:2f:7a:01:e1:5b:d4:
    be:3e:23:4d:d3:ce:b1:b9:92:a2:65:52:e2:2a:6d:
    66:ed

This is due to differences in the standards for the way private keys are defined for different algorithms. For example this is the definition of an EC private key structure (from RFC5915):
   ECPrivateKey ::= SEQUENCE {
     version        INTEGER { ecPrivkeyVer1(1) } (ecPrivkeyVer1),
     privateKey     OCTET STRING,
     parameters [0] ECParameters {{ NamedCurve }} OPTIONAL,
     publicKey  [1] BIT STRING OPTIONAL
   }

As you can see the definition of the private key includes the public key (as an optional field).
By contrast the definition for Ed25519 (from RFC8410) is this:
   CurvePrivateKey ::= OCTET STRING

   To encode an EdDSA, X25519, or X448 private key, the "privateKey"
   field will hold the encoded private key.

So an Ed25519 is only the private key and not the public key as well.
Note that the PKCS8 standard that OpenSSL implements (from RFC5208) defines a PKCS8 private key structure like this:
PrivateKeyInfo ::= SEQUENCE {
   version Version,
   privateKeyAlgorithm AlgorithmIdentifier {{PrivateKeyAlgorithms}},
   privateKey PrivateKey,
   attributes [0] Attributes OPTIONAL }

So there is no possibility to incorporate the public key anywhere else other than embedded into the private key. By contrast later standards (RFC5958) updates PKCS8 private keys to this (renaming PrivateKeyInfo to OneAsymmetricKey):
     OneAsymmetricKey ::= SEQUENCE {
       version                   Version,
       privateKeyAlgorithm       PrivateKeyAlgorithmIdentifier,
       privateKey                PrivateKey,
       attributes            [0] Attributes OPTIONAL,
       ...,
       [[2: publicKey        [1] PublicKey OPTIONAL ]],
       ...
     }

So in this later version of the standard there is a separate field for encoding the public key. Unfortunately OpenSSL does not support this standard.
In practice this usually makes little difference since it is trivial in Ed25519 to infer the public key from the private key, and OpenSSL does this automatically:
$ openssl genpkey -algorithm ed25519  |   openssl pkcs8 -topk8 -nocrypt | openssl pkey -noout -text
ED25519 Private-Key:
priv:
    e5:5c:5f:72:4f:3c:71:ec:28:1f:98:3e:04:b5:d0:
    40:ef:d4:ad:40:ed:3f:9c:ac:2d:df:a3:56:fe:31:
    0b:c1
pub:
    9b:e8:1e:f8:85:ae:63:51:79:2f:7a:01:e1:5b:d4:
    be:3e:23:4d:d3:ce:b1:b9:92:a2:65:52:e2:2a:6d:
    66:ed

RFC8410 specifies two private key formats.  This is the one I'm requesting:
   -----BEGIN PRIVATE KEY-----
   MHICAQEwBQYDK2VwBCIEINTuctv5E1hK1bbY8fdp+K06/nwoy/HU++CXqI9EdVhC
   oB8wHQYKKoZIhvcNAQkJFDEPDA1DdXJkbGUgQ2hhaXJzgSEAGb9ECWmEzf6FQbrB
   Z9w7lshQhqowtrbLDFw4rXAxZuE=
   -----END PRIVATE KEY-----

I assume that OpenSSL already reads both formats.

RFC8410 specifies two private key formats.  This is the one I'm requesting:
   -----BEGIN PRIVATE KEY-----
   MHICAQEwBQYDK2VwBCIEINTuctv5E1hK1bbY8fdp+K06/nwoy/HU++CXqI9EdVhC
   oB8wHQYKKoZIhvcNAQkJFDEPDA1DdXJkbGUgQ2hhaXJzgSEAGb9ECWmEzf6FQbrB
   Z9w7lshQhqowtrbLDFw4rXAxZuE=
   -----END PRIVATE KEY-----

I assume that OpenSSL already reads both formats.

RFC8410 specifies two private key formats.

It specifies only one way to encode a private key and (unlike, for example, EC) there is no possibility to embed the public key inside the private key. It provides two examples of encoding that private key in a PKCS8 structure. The first is consistent with the older PKCS8 format defined in RFC5208. OpenSSL can read/generate that just fine. The second uses the updated OneAsymmetricKey format as defined in RFC5958. That format enables you to include the public key as a separate field in the PKCS8 structure to the private key (i.e. so in this case the public key is not embedded in the private key, but separate to it). But as I noted in my answer above:

So in this later version of the standard there is a separate field for encoding the public key. Unfortunately OpenSSL does not support this standard.

RFC8410 specifies two private key formats.

It specifies only one way to encode a private key and (unlike, for example, EC) there is no possibility to embed the public key inside the private key. It provides two examples of encoding that private key in a PKCS8 structure. The first is consistent with the older PKCS8 format defined in RFC5208. OpenSSL can read/generate that just fine. The second uses the updated OneAsymmetricKey format as defined in RFC5958. That format enables you to include the public key as a separate field in the PKCS8 structure to the private key (i.e. so in this case the public key is not embedded in the private key, but separate to it). But as I noted in my answer above:

So in this later version of the standard there is a separate field for encoding the public key. Unfortunately OpenSSL does not support this standard.

I have a PR for it :)

I have a PR for it :)

But will that PR also make openssl to generate the format automatically? I don't think so. And it would not even be a good idea IMO.

But will that PR also make openssl to generate the format automatically? I don't think so. And it would not even be a good idea IMO.

No, it should be encapsulated into the corresponding providers. But at least, it will allow parsing this format.

No, it should be encapsulated into the corresponding providers. But at least, it will allow parsing this format.

@romen Any opinion on this one, please? Bug/feature? If feature, should be changed in 3.0?

Came to write what @mattcaswell already explained!

@romen Any opinion on this one, please? Bug/feature? If feature, should be changed in 3.0?

Came to write what @mattcaswell already explained!

How about fixing the pkcs8 command?

How about fixing the pkcs8 command?

I have a PR for it :)

Just for the record, this is @beldmit's PR with some initial steps toward supporting RC5958: https://github.com/openssl/openssl/pull/13942

I have a PR for it :)

Just for the record, this is @beldmit's PR with some initial steps toward supporting RC5958: https://github.com/openssl/openssl/pull/13942

How about fixing the pkcs8 command?

At the moment it is not broken, the problem you are experiencing depends on the fact that OpenSSL PKCS#8 support is conforming to RFC5208.
Also I would note that, by the letter of the RFC, while an evolution of PKCS#8, and while it obsoletes it, RFC5958 is not technically PKCS#8, so IMHO, for better compatibility with applications that expect PKCS#8 to conform to RFC5208, the new format should be optional (either a new command or some flag for the pkcs8 cmd)

How about fixing the pkcs8 command?

At the moment it is not broken, the problem you are experiencing depends on the fact that OpenSSL PKCS#8 support is conforming to RFC5208.
Also I would note that, by the letter of the RFC, while an evolution of PKCS#8, and while it obsoletes it, RFC5958 is not technically PKCS#8, so IMHO, for better compatibility with applications that expect PKCS#8 to conform to RFC5208, the new format should be optional (either a new command or some flag for the pkcs8 cmd)

Yes, everything PKIX is like this 🥶  Of course BouncyCastle use RFC5958 and JDK RFC5208.
A flag would be OK.

Yes, everything PKIX is like this 🥶  Of course BouncyCastle use RFC5958 and JDK RFC5208.
A flag would be OK.

My just released JWK <-> PEM converter https://mobilepki.org/jws-ct/keyconv can unfortunately not use keys created by OpenSSL.

My just released JWK <-> PEM converter https://mobilepki.org/jws-ct/keyconv can unfortunately not use keys created by OpenSSL.

This is a dupe of #10468 I think.


[RFC] NixOS Xorg service: should we remove intel from default videoDrivers

Right now NixOS puts a lot of Xorg-level video drivers into the default configuration. It looks like having intel creates problems now that we have Xorg 1.20.
(I am not using NixOS but I do use the NixOS xorg.conf generation code)
Xorg 1.20 has updated many things. In particular it broke Nvidia binary driver ABI compatibility (to the surprise of no one) and a popular suggestion on the forums is «just use Nouveau». On my Intel+Nvidia Thinkpad I have happily used Nouveau for a long time already with XRandR offload, but Xorg 1.20 still broke my configuration. After some more debugging and log-comparing and web-searching, it looks like:
i915/intel for Intel card + nouveau/modesetting for Nvidia leads to working built-in display, but broken VGA output (offloading doesn't work properly, although the colour range of the garbage on the screen seems roughly correct, and the mouse pointer works for some weird reason).
videoDrivers = mkForce ["modesetting"]; solves the visible problems, modesetting is used correctly for both outputs, xrandr works.
(as a side note: when building only the Xorg service, apparently two LLVM builds are necessary — maybe it was fixed since Xorg 1.20 bump, though)

I think I heard some year ago (roughly) that distributions tend to shift to use "modesetting" by default for Intel cards, so I suppose it wouldn't cause many problems.

Oh, I found some specifics, I think…
Ubuntu and Debian switched by mid-2016 (speaking of unstable repositories) for «newer» GPUs, apparently «newer» means 2007 and later. Fedora followed in January 2017.
Is it OK to just put a footnote in release notes and not even try recognising the 2007-and-older Intel GPUs?

Sounds OK to me.

Arch's wiki mentions a few things we may wish to confirm/check-if-still-accurate:
https://wiki.archlinux.org/index.php/intel_graphics
For example the wiki claims:

Also, the modesetting driver will not be benefited by Intel GuC/HuC/DMC firmware.

Presumably this is a limitation and not a feature ("no extra firmware bits needed, yay!").

Regardless I've been just using modesetting by itself for a while now.  xf86-video-intel HAS been receiving updates lately (last few weeks), so I'm honestly not sure what Intel is expecting folks to be using? And there's the tearing issue w/chrom{e,ium}, although maybe there's a good solution there :).
Yes users can specify the previous behavior but it'd be nice to provide best out-of-the-box experience possible! :)

I am not sure anymore if we want to provide the best out of the box experience or the most stable out of the box experience. A gap where using the latest intel driver means that connecting projectors to Thinkpad is black magic sounds like an argument for modesetting by default — maybe with a better list of tradeoffs in documentation.

On Mon, 11 Feb 2019 21:31:41 -0800, Michael Raskin<EMAIL_ADDRESS>wrote:

I am not sure anymore if we want to provide the best out of the box experience or the most stable out of the box experience.

"best" is perhaps in need of a clear definition,
to some "best" does mean "stable" :).
IMO "best" certainly includes stability as a leading consideration :).
(especially "best out-of-the-box",
tweaking for features >>> tweaking to not crash)

A gap where using the latest intel driver means that connecting
projectors to Thinkpad is black magic sounds like an argument for
modesetting by default — maybe with a better list of tradeoffs in
documentation.

:+1: to documentation being important, either way :).
I think we are agreeing? ^_^

--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/issues/55520#issuecomment-462622215Non-text part: text/html

Technically, attaching a projector to Thinkpad doesn't crash with the new X.org and old intel driver, it just doesn't produce any readable text on the projector.
Re: documentation — I think the details should be discussed in the PR as change requests. My values are «Firefox and terminal and PDF viewers work on all screens > XScreenSaver hacks LavaLite & Menger work acceptable > what else is there to wish?», so I am not sure what are the main tradeoffs to document (and advice on placement is welcome, right now I only put a release note about the change)

So #55583 caught me by surprise as output names in xrandr changed from { DP1, DP2, HDMI2 } ⇒ { DP-1, DP-2, HDMI-2 } which broke my X session script:
  services.xserver.displayManager. sessionCommands = ''
    ${pkgs.xorg.xrandr}/bin/xrandr --output DP1 --right-of HDMI2 --primary
    ${pkgs.xorg.xrandr}/bin/xrandr --output DP2 --right-of DP1
  '';

As well as my i3 bar setup:
# Start i3bar to display a workspace bar (plus the system information i3status
# finds out, if available)
bar {
        status_command i3status --config ~/.i3/status.conf
        position top
        output LVDS1
        output DP1
        output eDP1
}

Might be worth mentionning this specifically in nixos/doc/manual/release-notes/rl-1903.xml ?

So #55583 caught me by surprise as output names in xrandr changed from { DP1, DP2, HDMI2 } ⇒ { DP-1, DP-2, HDMI-2 } which broke my X session script:

My bad re: not mentioning this in the release notes (I did notice it, but my scripts adapt to this automatically so I didn't think about writing this down)

Might be worth mentionning this specifically in nixos/doc/manual/release-notes/rl-1903.xml ?

Done.

Another regression is that xbacklight doesn't work with the modesetting driver:
xbacklight -set 10
No outputs have backlight property

There is a 3 year old ticket for this: https://bugs.freedesktop.org/show_bug.cgi?id=96572#c15
A workaround is to use the /sys interface directly. Another one is using brightnessctl.

500d61560fb 97464d087ec

I think we should close this ticket.  Discussion about improvements sure can continue here...

Should we maybe include a link to this issue? Someone experiencing issues is likely to want more details as to why they should care about intel vs. modesetting and how to work around issues.

I do not object but also am not sure enough to actually write the line with the link.

Any particular reason to be hesitant?

No arguments against — just not sure if the benefit is worth the effort of trying to add this line in a sane way. The release not in question is already losing readability a bit…


Rename yaml headers

objective -> rationale
implementation -> details
To match best practices badge.

At the very least, we need to change "implementation". The original implementation text describes how a project can implement the criterion (equivalent to the Best Practices Badge the "details" field), but some think it's a description of how to automatically determine if it's true (equivalent to the Best Practices Badge "autofill" field).

Sounds good to me

+1 and I'll add:
criteria -> criterion


I should be able to define my own error format

I typed out all of the fields, and when I clicked save, they were gone. Let me sum up my issue again:
graphql flutter uses another package, gql_link which handles the response parsing. In the response parser it expects the error to be Map<String,dynamic> and throws an exception if it isn't. In my case, when I have an error it is just a string. The responseparser says that it can be extended to override it, but I don't know how to do it since it is wrapped in this package and I don't see anything in the api's that can override the response parser.
here is the code snippet I'm talking about in gql_link
/// Parses the response body
///
/// Extend this to add non-standard behavior
Response parseResponse(Map<String, dynamic> body) => Response(
errors: (body["errors"] as List?)
?.map(
(dynamic error) => parseError(error as Map<String, dynamic>),
)
.toList(),
data: body["data"] as Map<String, dynamic>?,
context: Context().withEntry(
ResponseExtensions(
body["extensions"],
),
),
);

also, any way to just get the raw response before parsing would work too.

Somewhere you're passing a link (e.g. HttpLink) to the client. You can implement custom parsing by extending this link with your custom implementation.


missing watch permission for events RBAC

Checks

[X] I have checked for existing issues.
[X] This report is about the User-Community Airflow Helm Chart.

Chart Version
8.9.0
Kubernetes Version
N/A

Helm Version
N/A

Description
Just @sudohainguyen proposal in https://github.com/airflow-helm/charts/pull/822 (which they closed for some reason).
I think we might be missing the watch verb from the events RBAC.
I am not sure if any current providers need it, but we should figure that out, and included it if so.
Relevant Logs
No response
Custom Helm Values
No response

was closed cause kinda stale 😅
just reopened the PR, please help have a look


Add timing for each window.

For data where we are summarizing a single activitity the windows are treated as repeat measures but for other tasks we are interested in the change over time.  For example, for Heart rate we are interested in the change in HR and need to know the time for each window.  I suggest adding the start timestamp and end timestamp for each window.

@philerooski We need to output the start and end timestamp in get window signal function. Let me know if you need help.


[BUILD] openvdb/openvdb/python/CMakeFiles/pyopenvdb.dir/build.make:173: target pattern contains no `%'. Stop.

Environment
**Operating System: Ubuntu 20.04
**Version / Commit SHA: VDB 9.0
**CMake Version: 3.16.3
**Compiler: gcc 9.3.0
Describe the problem
I got this error during cmake -D OPENVDB_BUILD_PYTHON_MODULE=ON and make -j4 to use python module.
openvdb/openvdb/python/CMakeFiles/pyopenvdb.dir/build.make:173: target pattern contains no '%'. Stop.
A message snippet during cmake:
`

-- ------------ Configuring OpenVDBPython -------------

-- Found Python: /home/dabi/miniconda3/include/python3.9) (found suitable version "3.9", minimum required is "2.7")
-- Found non-suffixed boost_python, assuming to be python version "3.9" compatible

`
To Reproduce
Steps to reproduce the behavior:

Checkout repo
mkdir build; cd build

Run CMake
cmake -D OPENVDB_BUILD_PYTHON_MODULE=ON ..

Build with
make -j4

See error
openvdb/openvdb/python/CMakeFiles/pyopenvdb.dir/build.make:173: target pattern contains no %'. Stop.`

Additional context
boost-python had been properly installed.
Python version is 3.9.

Hi @andabi - I'm currently investigating this in #1353. I have some things you can try to work around this there.

This should now be fixed. If you encouter issues with finding boost_python or boost_numpy try providing -D Boost_PYTHON_VERSION=X or -D Boost_PYTHON_VERSION_MAJOR=X.Y to tell CMake exactly which version of boost python/numpy you're expecting.


.gitignore ignores Lib on macOS

The default macOS file system is case-insensitive, and the .gitignore file has an entry for lib/ which causes Lib to be ignored as well, and trying to git add any file under gives this message:
The following paths are ignored by one of your .gitignore files:
Lib
hint: Use -f if you really want to add them.
hint: Turn this message off by running
hint: "git config advice.addIgnoredFile false"

This was fixed in 17ca2bf.


Support new app: Sequel Pro

BundleId of the app
not sure
Example window titles
Connection
Database
Structure
Content
Relations
Triggers
Table Info
Query

Implemented with #296.


feat: support mf rsbuild plugin

Description
A plugin support bundler use Rsbuild, whatever Rsbuild App or Rslib package

Related Issue

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I have updated the documentation.

can you help add rslib demo ?


Scheduling renewals

Resolves #74.
I've split the work here into three commits for easier reviewing/reasoning:

Sleep until certificate is due instead of looping and rechecking. This
simplifies the code a bit, and makes the changes required in the next commit
a ton easier. Should also perform a tiny bit better.
Randomized early renew, the "big" feature here, which I actually wanted to
work on.
Switch to a default renew_delay of 30d, as recommended by Let's Encrypt.

EDIT: @breard-r I've only checked the contribution guide again after opening this PR, and noticed one thing I've not done "right": I've added a dependency, on rand. I'd assume that's okay though?
If adding a dependency is not okay, it'd be possible to start gating some of the features behind cargo feature flags and disable them by default. Where this would also make sense is #81, which will definitely pull in a lot more dependencies.

I've split the work here into three commits for easier reviewing/reasoning:
1. Sleep until certificate is due instead of looping and rechecking. This
   simplifies the code a bit, and makes the changes required in the next commit
   a ton easier. Should also perform a tiny bit better.

2. Randomized early renew, the "big" feature here, which I actually wanted to
   work on.

3. Switch to a default renew_delay of 30d, as recommended by Let's Encrypt.

Thank you! :smile:

EDIT: @breard-r I've only checked the contribution guide again after opening this PR, and noticed one thing I've not done "right": I've added a dependency, on rand. I'd assume that's okay though?
If adding a dependency is not okay, it'd be possible to start gating some of the features behind cargo feature flags and disable them by default. Where this would also make sense is #81, which will definitely pull in a lot more dependencies.

rand is ok, and obviously adding telemetry will require additional dependencies. It's more of a "don't end up like the average NPM project" than an absolute rule. Furthermore, I still have the left-pad affair in mind.


feat(tutorial): complete step 5 DUBLIN ☘

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Please include the IBM Cloud deploy URL so we can confirm completion

No updates for 30 days. Closing.


RT causes spawn issues with FutureMC Fish

Ref: thedarkcolour/Future-MC#137
This is very annoying as the bug causes thousands of fish to spawn, completely killing tick rates. I've had 50,000 fish at once in a 3x3 chunk of ocean.

Assuming this will be fixed by Future MC.


DepositTreeSnapshot database persistence

PR Description
Stores DepositTreeSnapshot to DB (always) and loads it on Teku start if --Xdeposit-snapshot-storage-enabled flag is toggled
Part №3 of #5432
Fixed Issue(s)

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

I'm a bit confused with finalized/hot parts and complicated StoreTransaction flow, so I could be (should be) wrong there. Also shouldn't we add !optimisticTransitionBlockRootSet here https://github.com/ConsenSys/teku/blob/4f181937d0552571c6d0bd38c5a8f94aa6790dfd/storage/api/src/main/java/tech/pegasys/teku/storage/api/StorageUpdate.java#L68-L76 ?
Otherwise I think this PR is ready for review

And yes we probably should be checking that flag in StorageUpdate - I've fixed it in #6202
Deposit replay is fast, but will keep getting slower as more and more deposits get added and it's more stuff to store in the database that we don't really need.  The main aim of these stories though will be to ship a deposit snapshot with Teku to avoid having to load most of the deposits from the chain on first startup.

@ajsutton I understand the purpose, but I made this PR assuming that it could be toggled off or on when needed with a flag. The next step could be removing the flag (and toggling it always on) and so on removing deposits from the storage. Until this flag could be turned off or on on any restart, if we remove the deposits now and user toggles snapshot flag back to off, he will start without snapshot and deposits in DB. Also there is no sense to remove pre-snapshot deposits as we load deposits from EL, not DB, if snapshot is used. So we could remove them all when the feature is always on.
Another question is a way of obtaining StorageQueryChannel. It's already complicated in 2 parts of the code and I've added the 3rd place with similar code. I'm not sure what is the best way to fix it. I guess our intention is to switch fully to async soon, so maybe it's not a big deal and we could later use just CombinedStorageChannel in all palces

Sorry for the delay in getting back to this.

I understand the purpose, but I made this PR assuming that it could be toggled off or on when needed with a flag. The next step could be removing the flag (and toggling it always on) and so on removing deposits from the storage. Until this flag could be turned off or on on any restart, if we remove the deposits now and user toggles snapshot flag back to off, he will start without snapshot and deposits in DB. Also there is no sense to remove pre-snapshot deposits as we load deposits from EL, not DB, if snapshot is used. So we could remove them all when the feature is always on.

The aim of feature toggles is to let us test the new feature and get it fully working before we enable it for everyone. So I'm not worried if you can't reliably turn it back off once you've enabled it - it's more important to fully test the new behaviour before we enable it. So I think we want to add in the deletion so we can see the full results of the feature.

Another question is a way of obtaining StorageQueryChannel in PowChainService. It's already complicated in 2 parts of the code and I've added the 3rd place with similar code. I'm not sure what is the best way to fix it. I guess our intention is to switch fully to async soon, so maybe it's not a big deal and we could later use just CombinedStorageChannel in all palces

Yeah I wouldn't worry about this, I think we can probably remove the feature toggle for async storage pretty soon given it's been in use successfully for a while now.

Also there is no sense to remove pre-snapshot deposits as we load deposits from EL, not DB, if snapshot is used. So we could remove them all when the feature is always on.

Missed this bit. Not storing any deposits and just loading from the EL is probably ok. Would be something to test and see what the size of requests to the EL are in practice - people often have issues with the EL timing out when searching for deposit logs but hopefully the snapshot is usually recent enough that it won't be an issue or we can reduce the default number of blocks we cover in each request to lower the load since we don't have to scan the full chain anymore (or at least won't have to once we start including a snapshot in releases for known networks).

Removing deposits finished, need to test somehow

Finished on this. Tested in real network, all works fine after the fix. Even if we remove flag --Xdeposit-snapshot-storage-enabled after usage, client restores all deposit events info successfully

Moved "Eth1Data height not found in cache. Skipping DepositTree pruning" from warn to debug level, it's spamming a lot and it's not critical, especially considering that this snapshot could be already stored, just we've moved forward in the blockchain and height data was already pruned
Added some other logging, almost everything in debug, only pruning of deposit events (1 time in life) to INFO level. Not sure on this. I'd rather add some info at least on loading/not loading snapshot from storage but looks like we prefer minimum noise on INFO level, so I've not increased it


Changed flags for _ltfs_search_index_wp

Summary of changes
This pull request includes following changes or fixes.

Fix of issue #479
Changed flags for _ltfs_search_index_wp

Description
When a tape cartridge with a write permanent error is trying to be mounted and the MAM (cartridge memory) attribute of the Index Partion (IP) stores a generation number different than the MAM attribute of the Data Partition (DP), the mount process fails even when ltfs can still search for the index in the other partition.
The code that belongs to the logic that handles WP happens on IP, defined "can_skip_ip" flag as false and it shall be true. On the other hand, the code that handles WP happens on DP, defined the "can_skip_ip" as true and it should be false. The logic is not adjusted accordingly.
Fixes #issue_no
Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

[X] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have confirmed my fix is effective or that my feature works

I would like to ask you the things below.

Please test your code on your bench. File backend might be helpful for this kind of issue
Please clarify this PR shall be merged to v2.4-stable branch or not
Please set reviewer(s) for having review comments

@amissael95 ,
Could you take care about my previous comment about PR #480 ?

@juliocelon , @perezle ,
Could you handle this?
It looks issue #479 and it's fix (this PR) come from a customer. I don't know I just push this only on master branch.

You mentioned that the file backend might be helpful to the test this kind of issue. Did you mean to use "ltfs.vendor.IBM.forceErrorWrite" extended attribute ? I was planning to use ITDT to test this change, but could you provide me more details in case I use a file backend?

I believe a tape which has following condition is needed for your test.

The tape has a write perm while LTFS was writing an index on IP
- this write perm handling shall be successfully done and the tape is closed cleanly
VCR value returned from a tape drive is different from which is stored on MAM

I'm not sure how you can create a tape both condition was met. But you can use ITDT if you know how to do it obviously.
My intention is the file backend manages MAM and VCR on its file, so you can create those condition with editing file backend files (while ltfs is not running).

@juliocelon , @perezle ,
Both of you MUST NOT merge this PR to the stable branch!!!! This PR ruins the stable branch completely.
@amissael95 ,
Did you merge v2.4-stable branch to your dev branch (and push)?
It is completely wrong operation. Please fix your PR.
Why didi you merge

@piste-jp,
My branch was created from master branch so all these conflicts are because the differences between master and v2.4-stable branch, I did not merge or push it with v2.4-stable . I will solve this problem by making the fix change based on/from the v2.4-stable branch.
Regards


Fix: remove border bug on report previews with 3+ receipts

Details

This PR fix a UI bug with the report preview corner on ReportPreviews with 3+ Receipts
Fixed Issues

$ https://github.com/Expensify/App/issues/37485
PROPOSAL: https://github.com/Expensify/App/issues/37485#issuecomment-1977561038
Tests

Open ND
Create more than 3 receipt request money with the same user
On the report preview corner, verify that there's no UI bug, no small 1px line from the image below.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open ND
Create more than 3 receipt request money with the same user
On the report preview corner, verify that there's no UI bug, no small 1px line from the image below.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@dragnoir looks like performance tests are failing, you may need to merge main

@shawnborton @dannymcclain @dubielzyk-expensify could you confirm the styles for report previews? I have an adhoc build linked here:
https://github.com/Expensify/App/pull/38710#issuecomment-2011979371

It's looking good to me—I'm not seeing that weird border issue in the ad hoc build 💪

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Allocate product id for web browser

Use allocated product id to filter out browser on micro:bit OOB.

We added an "infrastructure" service, online bus device implements it and OOB ignored it.


Add Oliver to systemd ADR as decider

PR seems to be broken, won't accept approval from @ohessel - I'll recreate the PR.

PR seems to be broken, won't accept approval from @ohessel - I'll recreate the PR.


request_id isn't thread safe

The way request ids are generated isn't thread safe.
In particular having a global static SV * variable (i.e. static SV * request_id) is wrong
I managed to trigger the race condition in the test case by increasing the number of threads and the number of inserts.
Made a quick fix, by using a Perl shared variable and passing the value to the corresponding functions.

The related JIRA ticket was resolved in August 2014, so I'm closing this PR.


[WebSub] Refactor the hub stop logic and add tests for hub start up

Purpose
This PR refactors the hub stop logic and adds tests for hub start up.

:white_check_mark: Build ballerina-lang 175 completed (commit https://github.com/ballerina-platform/ballerina-lang/commit/ec1de2a66b by @MaryamZi)


[Component] Add camel-influxdb2 component,support for influxdb2.x .

Add camel-influxdb2 component,support for influxdb2.x .

The existing camle-influxdb only support influxdb 1.x . More info can be found here: https://github.com/influxdata/influxdb-java

Okay thanks, so lets make this more clear in the component docs for these

Okay, i will trying to fix it. Is there any document for reference?


Throw when connection is closed and we try to execute commands

Description
I ran into an issue where I had an asyncio method calling fetchall() on a Cursor, but it hung forever. This is because the connection was closed, and the loop stopped running so the fetchall future was never pulled out of the queue. An example test case is added.
Fix
This PR changes _execute so it checks for whether the connection is open or not. _connect also has to be changed, because it used to call _execute (which would throw if there is no connection yet). I'm assuming all the other calls to _execute rely on the connection being open. Is this the right approach? If there is a better way to do it, I can implement it.
Also, after the connection is closed, all futures in the queue are processed anyway.

Is there anything we can further do to get this merged?

Would you mind taking another look and merging? it would help us out to have this included in a release.
Thanks :)

Would you mind taking another look and merging? it would help us out to have this included in a release.
Thanks :)

Checking in on this. Is there anything further you need from @mariano54 ?

Sorry for the delay on returning to this. Thank you for the fixes!


Expose CopyImageError and DrawIndexedIndirectError

I noticed that these two were missing a pub export while reading through
the docs so I thought I'd add them!

[x] Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
[ ] ~Updated documentation to reflect any user-facing changes - in this repository~
[ ] ~Updated documentation to reflect any user-facing changes - PR to the guide that fixes existing documentation invalidated by this PR.~

Good catch, thanks for the PR!