Basic Auth

Possible to update to support basic auth?
Token would need to be Basic:
https://github.com/oasis-open/cti-taxii-client/blob/54dabadf1a67517e99e6a8f2961614a2a4f5ad2c/taxii2client/common.py#L143

You don't need to add it, it's already there. The TokenAuth object implements an authentication type that isn't supported by the underlying requests library, but the HTTPBasicAuth module (already part of requests) does exactly what you want.
https://requests.readthedocs.io/en/latest/user/authentication/
You can even see it being used as part of the existing code here:
https://github.com/oasis-open/cti-taxii-client/blob/54dabadf1a67517e99e6a8f2961614a2a4f5ad2c/taxii2client/common.py#L267

Thank you Andrew, this worked great! I didn't realize what I already had. Closing this issue


add College of Marin

@ProBluebbes I am sorry, the domain mycom.marin.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


readFile doesn't throw an error when the file doesn't exist

client.cloud.readFile('doesnotexist.txt') returns the empty string, as if it were a real file with no contents, but it should throw instead. (Or, apropos #35, its promise should be rejected.)

Steam doesn't indicate an error, instead it returns a "file" with 0 size, GetFileSize returns 0 when the file doesn't exists: https://partner.steamgames.com/doc/api/ISteamRemoteStorage#GetFileSize
The way we can do it is checking with FileExists method before trying to read, but since the steamworks API is designed that way, I think it should be responsibility of the consumer decide if he wants to check it or not.


Thoroughly check both the prompts, try variations of both prompts and select the best one. (creation of JSON and updating the existing JSON)

Done, the current ones work pretty well


K8SPS-270: Logging improvements

CHANGE DESCRIPTION
Problem:
Controller names not aligned with the rest of the operators
Solution
Align controller names to ps-controller, psbackup-controller and psrestore-controller
CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?
[x] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[x] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[x] Is an E2E test/test case added for the new feature/change?
[x] Are unit tests added where appropriate?

Config/Logging/Testability

[x] Are all needed new/changed options added to default YAML files?
[x] Are the manifests (crd/bundle) regenerated if needed?
[x] Did we add proper logging messages for operator actions?
[x] Did we ensure compatibility with the previous version or cluster upgrade process?
[x] Does the change support oldest and newest supported PS version?
[x] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
passed

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 23 out of 23

commit: https://github.com/percona/percona-server-mysql-operator/pull/334/commits/6614c5d2f625a83ebdb6dc668a1e04f85e14b973
image: perconalab/percona-server-mysql-operator:PR-334-6614c5d

Test name
Status

async-ignore-annotations
passed

auto-config
passed

config
passed

config-router
passed

demand-backup
passed

gr-demand-backup
failure

gr-ignore-annotations
passed

gr-init-deploy
passed

gr-one-pod
passed

gr-scaling
passed

gr-tls-cert-manager
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring
passed

one-pod
passed

scaling
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

tls-cert-manager
passed

users
passed

version-service
passed

We run 23 out of 23

commit: https://github.com/percona/percona-server-mysql-operator/pull/334/commits/6b1dd4e91f2fb2fb39fa124642083bd36948e128
image: perconalab/percona-server-mysql-operator:PR-334-6b1dd4e


add missing second arg rng to forward.apply call in minimal example

thanks to @cgarciae in https://github.com/deepmind/dm-haiku/issues/55 for the pickup!
see colab eg https://colab.research.google.com/drive/1ilWQduIWKfe1HxafUH6TZdGtzOkWbiav?usp=sharing

After the 0.02 release this is now also the default in the latest PyPi release. Thanks for the contribution!


[MNT] Update to numpy 2

Updates the version bound on numpy to include 2.0.0.

CI seems to be running 1.26.4 still

@MatthewMiddlehurst Do the changes here look helpful :), if not I can revert them.


Initial merge of Common IO libraries and tests

Description

All peripheral headers
Tests for I2C, UART, SPI

This is a copy from feature/common-io branch with formatting and small changes on CMakeList.txt
Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks

all look ok to me, suggest one minor change for this file libraries/abstractions/common_io/test/test_iot_internal.h, should have the same copyright statement as the rest

You are right. Thanks for catching it.


Crash loading certain PNG files

GUIBitmapCtrl trying to load this png:
https://www.dropbox.com/s/iptnkq5e9wzezjw/animationbar_left_end.png?dl=0
Causes crash with this error:
 D:\Torque\Torque3D\Engine\source\gfx\bitmap\loaders\bitmapPng.cpp(125,0): {Fatal-ISV} - Error reading PNG file:
IDAT: chunk data is too large

Caused by this libpng bug:
https://sourceforge.net/p/libpng/bugs/270/
Should be fixed by libpng 1.6.33 and higher, we worked around the issue by re-saving the PNGs in photoshop  (save for web -> PNG24).

@Areloch this can probably be closed.

This was resolved by the newer version of libpng


Inspecting datasets per category

Hi
Is there a way I could get all NLI datasets/all QA datasets to get some understanding of available datasets per category? this is hard for me to inspect the datasets one by one in the webpage, thanks for the suggestions @lhoestq

That's interesting, can you tell me what you think would be useful to access to inspect a dataset?
You can filter them in the hub with the search by the way: https://huggingface.co/datasets have you seen it?

Hi @thomwolf
thank you, I was not aware of this, I was looking into the data viewer linked into readme page.
This as what I am looking for, but  this does not work currently, please see the attached

I am selecting to see all nli datasets in english and it retrieves none. thanks

I see 4 results for NLI in English but indeed some are not tagged yet and missing (GLUE), we will focus on that in January (cc @yjernite): https://huggingface.co/datasets?filter=task_ids:natural-language-inference,languages:en

￼Good night my friend￼ I'm sorry, I don't understand you, it's my first time

￼Good night my friend￼ I'm sorry, I don't understand you, it's my first time


[No QA] Fix deploy announce in slack

Details

Removes success condition to avoid posting multiple messages
Resets ENV for multiple runners

cc @roryabraham @AndrewGable
Fixed Issues
$ https://github.com/Expensify/App/issues/8199
Tests

Next time we deploy app, verify:

The Slack announcement includes the correct deploy version

The success message is only posted once

If any platform fails to deploy, no success message is posted and we see a failure announcement instead.

[X] Verify that no errors appear in the JS console

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Monitor here to see if this worked

Didn't seem to work https://expensify.slack.com/archives/C07J32337/p1647557985727479 😭

Actually it looks like the workflow run I pointed you towards didn't pick up these changes. We'll just need to wait for another deploy then. I can manually CP this to test if you want?

Manually CP'ing this to test it.

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.44-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Referenced nginx helm chart deprecated

The helm chart referenced in this document is deprecated.
Currently it is using:
helm repo add stable https://kubernetes-charts.storage.googleapis.com/
And should be updated to (github):
helm repo add ingress-nginx https://kubernetes.github.io/ingress-nginx

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 12009c1f-282d-2632-fac0-64b09c432833
Version Independent ID: 6052d3d4-d295-9340-b16d-4c200e34cd73
Content: Use ingress controller with static IP - Azure Kubernetes Service
Content Source: articles/aks/ingress-static-ip.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@csnance Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate. We will update you accordingly.

@mlearned Can you please check and add your comments on this doc update request as applicable

Thank you @csnance for the feedback!
I've updated the article to address your feedback and the changes should be available soon.
#please-close


AttributeError: module 'tweepy' has no attribute 'StreamListener'

Hello:
AttributeError: module 'tweepy' has no attribute 'StreamListener'
Here is my relevant code, which is from the example on the tweepy docs page.
import tweepy
class MyStreamListener(tweepy.StreamListener):
myStreamListener = MyStreamListener()
myStream = tweepy.Stream(auth = api.auth, listener=myStreamListener)
myStream.filter(track=['python'])
FreeBSD 12.2-RELEASE/Django 3.1.6/Tweepy 3.10
Let me know if I can help myself help myself by answering any questions!
John

Are you using v3.10 installed from the latest version on PyPI or the development version from the master branch?

Master branch

I've refactored the code for streaming in the master branch.
StreamListener has been merged into Stream with https://github.com/tweepy/tweepy/commit/39abff4520e291180425ac2219d1d8597ac5da96, so you can simply subclass Stream instead.
There's other simplifications and improvements I've made as well.
I haven't updated the documentation yet, but I'll be doing so prior to v4.0 being released.
For now, you can refer to https://github.com/tweepy/tweepy/blob/master/tweepy/streaming.py and its docstrings.

Thank ya.

No problem. I'm going to leave this open to track the documentation update.

I've added documentation for API.stream with https://github.com/tweepy/tweepy/commit/18a6059e7980de7759be126ffe39836494cc4f23 and rewritten the guide to streaming with https://github.com/tweepy/tweepy/commit/bf641965278d2486cebef45bb940e2d2e691d420.


Issues after upgrading to the New Version Could not find the drag and drop manager in the context of ResourceEvents Make sure to wrap the top-level component of your app with DragDropContext

HI After Upgrading to the new release @0.2.7 my working project broke with the below mentioned error . Can any one please help me with it.

@mounikaalla-rahi
Hi, for the 0.2.7 updates dependencies to the latest versions, you may remove your node_modules, then npm i and try again.

Hi Stephen,
I tried to remove all the node modules and installed again.I am still
getting the same error.Could you please help me in resolving the issue.
Thanks,
Mounika
On Wed, May 15, 2019 at 6:19 PM Stephen Chou<EMAIL_ADDRESS>wrote:

@mounikaalla-rahi https://github.com/mounikaalla-rahi
Hi, for the 0.2.7 updates dependencies to the latest versions, you may
remove your node_modules, then npm i and try again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/StephenChou1017/react-big-scheduler/issues/134?email_source=notifications&email_token=ALCNO2L2Q74LXY25QNMNTUTPVSZCPA5CNFSM4HNH25DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQMANY#issuecomment-492879927,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALCNO2KZLJPUDFHUR6ANLY3PVSZCPANCNFSM4HNH25DA
.

--
Hello Signature

Hi Stephen,
After removing everything and upgrading the dependencies of the
"react-dnd": "^7.4.5", "react-dnd-html5-backend" : "^7.4.4". Events are not
showing up in the scheduler.Can you please confirm the version of react-dnd
and react-dnd-html5-backend required for the scheduler.
Thanks
Mounika
On Thu, May 16, 2019 at 9:12 AM Mounika Alla<EMAIL_ADDRESS>wrote:

Hi Stephen,
I tried to remove all the node modules and installed again.I am still
getting the same error.Could you please help me in resolving the issue.
Thanks,
Mounika
On Wed, May 15, 2019 at 6:19 PM Stephen Chou<EMAIL_ADDRESS>wrote:

@mounikaalla-rahi https://github.com/mounikaalla-rahi
Hi, for the 0.2.7 updates dependencies to the latest versions, you may
remove your node_modules, then npm i and try again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/StephenChou1017/react-big-scheduler/issues/134?email_source=notifications&email_token=ALCNO2L2Q74LXY25QNMNTUTPVSZCPA5CNFSM4HNH25DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQMANY#issuecomment-492879927,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALCNO2KZLJPUDFHUR6ANLY3PVSZCPANCNFSM4HNH25DA
.

--
Hello Signature

--
Hello Signature

I got this resolved,Thanks
On Thu, May 16, 2019 at 11:34 AM Mounika Alla<EMAIL_ADDRESS>wrote:

Hi Stephen,
After removing everything and upgrading the dependencies of the
"react-dnd": "^7.4.5", "react-dnd-html5-backend" : "^7.4.4". Events are not
showing up in the scheduler.Can you please confirm the version of react-dnd
and react-dnd-html5-backend required for the scheduler.
Thanks
Mounika
On Thu, May 16, 2019 at 9:12 AM Mounika Alla<EMAIL_ADDRESS>wrote:

Hi Stephen,
I tried to remove all the node modules and installed again.I am still
getting the same error.Could you please help me in resolving the issue.
Thanks,
Mounika
On Wed, May 15, 2019 at 6:19 PM Stephen Chou<EMAIL_ADDRESS>wrote:

@mounikaalla-rahi https://github.com/mounikaalla-rahi
Hi, for the 0.2.7 updates dependencies to the latest versions, you may
remove your node_modules, then npm i and try again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/StephenChou1017/react-big-scheduler/issues/134?email_source=notifications&email_token=ALCNO2L2Q74LXY25QNMNTUTPVSZCPA5CNFSM4HNH25DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQMANY#issuecomment-492879927,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALCNO2KZLJPUDFHUR6ANLY3PVSZCPANCNFSM4HNH25DA
.

--
Hello Signature

--
Hello Signature

--
Hello Signature

@mounikaalla-rahi
So will you tell us how you resolved this?:-)

I used npm to install the modules before.There are some missing
dependencies with that.When I used yarn it worked.
This Module was really helpful to me.Thanks a lot for timely
updates.Component was highly customizable thats the big advantage of it.
Below is the Snapshot of my project
[image: Screen Shot 2019-05-17 at 1.48.27 PM.png]
Is there a way that when the date range is long more than 2 months to
configure each cell as a month instead of day.So that it can fit in one
screen.?
On Thu, May 16, 2019 at 6:22 PM Stephen Chou<EMAIL_ADDRESS>wrote:

@mounikaalla-rahi https://github.com/mounikaalla-rahi
So will you tell us how you resolved this?:-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/StephenChou1017/react-big-scheduler/issues/134?email_source=notifications&email_token=ALCNO2NJAAJFN4IFPQW7JTLPVYCEVA5CNFSM4HNH25DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVTOZTI#issuecomment-493284557,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALCNO2KJNYUAYPLS57X5JRTPVYCEVANCNFSM4HNH25DA
.

--
Hello Signature

OK. I'll try to add CellUnits.Month later

@mounikaalla-rahi - How did you resolve this issue? There is no screenshot available


DHCP: Add min-secs option for each subnet

The min-secs option allows to configure a delay of 0-255 seconds before a DHCP server responds to a client's request. This can be used to set up a secondary DHCP server as stated in the manual. This PR contains changes for both v4 and v6, however I have not tested the latter much.

@vnxme looks good, thanks!


Make router available on lore object as lore.router

Sometimes it's useful to be able to access to the router from the console, just as when testing route transitions or just inspecting function behavior during development.
It should be added to lore as lore.router.

This is addressed in https://github.com/lore/lore/commit/9753e33922ce8bc5e6f8ff2253bb05010054d6d6.
Including it as part of the componentDidMount method makes it easy for the user to turn on and off, so it can easily be disabled in production if desired, or deleted completely if it has no value to the developer.


Outdated @aws-cdk/aws-appsync-alpha dependency in package.json

functionless version 0.6:
Using the latest "@aws-cdk/aws-appsync-alpha": "2.21.1-alpha.0" package in project gives:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@aws-cdk/aws-appsync-alpha
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/functionless
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@aws-cdk/aws-appsync-alpha
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/functionless
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
It seems that dev or peerDependecies is creation this error.
Would be great if it can be upgraded or more flexible.

After some research, it appears CDK's experimental versions do not support semver ranges as the CDK team seems to recognize https://github.com/aws/aws-cdk/issues/15581#issuecomment-896938220.
@sam-goodwin thoughts?

One option is to use Projen to generate a hand managed list of versions and form at the semver range.
^2.17.0-alpha.0 || ^2.18.0-alpha || ^2.19.0-alpha || ^2.20.0-alpha || ^2.21.0-alpha || ^2.21.1-alpha

Another caveat is that semver doesn't even support patch ranges so we'd need to push for each version of CDK until app sync is no longer experimental.

Another option is to just use * for experimental packages, assuming that users will match the version to the rest of CDK 2.0

* didnt't work, projen resolves * to 0.0.0 and forces us to pick a version.

What's the difference between the alpha lib and this one https://www.npmjs.com/package/@aws-cdk/aws-appsync

Its only for CDK 1

Argument of type 'Stack' is not assignable to parameter of type 'Construct'.
  Type 'Stack' is missing the following properties from type 'Construct': onValidate, onPrepare, onSynthesizets(2345)

Ah ok. Do we need to do a quick fix here by publishing a new version with upgrades dependencies?

We'd need to bump the only valid CDK version to the latest on each CDK release, which I don't think is feasible and also a breaking change for all consumers of lower versions.
For the record, yarn just warns at this issue, not fails.
npm --force may be required for consumers like @hfahlbusch using npm 7+.
I was going to cut a ticket to CDK asking for guidance as well as their versioning is the cause of this issue which would otherwise force us to avoid experimental contracts, duplicate them, or use CDK 1.0 for libraries...

Or cut a issue/PR to projen to allow * for peerDeps (which is valid npm/yarn, I think).

According to https://projen.io/node.html
You can specify versions like projen@*

Any dependencies without specific version ranges set (such as react or react@*) will given a version range in package.json so that future package upgrades and changes to the generated lockfiles such as package-lock.json or yarn.lock will follow semver.

Do we need to edit package.json manually and use the defaults?

Confirmed that * in peerDeps would work
Functionless:
  "peerDependencies": {
    "@aws-cdk/aws-appsync-alpha": "*",
  },

With any appsync-alpha, no wrning:
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>
Without appsync-alpha at all:
warning " ><EMAIL_ADDRESS>has unmet peer dependency "@aws-cdk/aws-appsync-alpha@*".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>

Ahh, I was under the impression that package.json was readonly and was overwritten.
Also looks like projen will support this use case soon. https://github.com/projen/projen/issues/1802


Add pf class to form components

Add a empty pf class to each form components so the form can be style

Fixed in v2.2.0


Can the OCR be used for local images

Hi
I am exploring the Azure's Computer vision API for my organisation and would like to know that whether the  Extract printed text API and Handwritten Text API can be extended for local images (instead of passing image url ,can i pass local path ?) , tried doing that but got an error..
I did the following changes for OCR
image_path = image_path
# Read the image into a byte array
image_data = open(image_path, "rb").read()
headers = {'Ocp-Apim-Subscription-Key': subscription_key}
params  = {'language': 'unk', 'detectOrientation': 'true'}
response = requests.post(ocr_url, headers=headers, params=params,data=image_data)
and got "image_path = image_path
# Read the image into a byte array
image_data = open(image_path, "rb").read()
headers = {'Ocp-Apim-Subscription-Key': subscription_key}
params  = {'language': 'unk', 'detectOrientation': 'true'}
response = requests.post(ocr_url, headers=headers, params=params,data=image_data)"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab15e2d6-7f06-3037-d47d-2d76fb8456ac
Version Independent ID: 396d1582-f04b-ad66-88ee-ae614ecd0ece
Content: Quickstart: Extract printed text (OCR) - REST, Python - Computer Vision - Azure Cognitive Services
Content Source: articles/cognitive-services/Computer-vision/QuickStarts/python-print-text.md
Service: cognitive-services
GitHub Login: @noellelacharite
Microsoft Alias: v-deken

--------------------------------------------------------ignore the typo
and got
HTTPError: 400 Client Error: Bad Request for url: https://westcentralus.api.cognitive.microsoft.com/vision/v2.0/ocr?language=unk&detectOrientation=true

@pragyan019 Thanks for the feedback! We are currently investigating and will update you shortly.

@pragyan019 Sorry, for now, if you want to use a local image: 1. upload it and use the URL, 2.upload it in the body of the request as an octet stream. Thanks a lot!

@pragyan019 We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.

Hi, Could you confirm that it is still not possible to use local images using the the Azure's Computer vision API ?

Hello, I am also interest if it is possible to use OCR on local images.

Hi, I could use OCR on the local picture by the following:
text_recognition_url = "https://westeurope.api.cognitive.microsoft.com/vision/v2.0/ocr?language=unk&detectOrientation=true"
headers = {
'Ocp-Apim-Subscription-Key': subscription_key,
'Content-Type': 'application/octet-stream'
}
response = requests.post(url=text_recognition_url, headers=headers, data=image_data)
Though I think this is the old version of OCR, since the results are different from the one on page: https://azure.microsoft.com/en-ca/services/cognitive-services/computer-vision/

https://github.com/Azure-Samples/cognitive-services-python-sdk-samples/blob/master/samples/vision/computer_vision_samples.py :)


Organise imports is not working for tsx files

Environment information
{
  "$schema": "https://biomejs.dev/schemas/1.4.0/schema.json",
  "organizeImports": {
    "enabled": true
  },
  "formatter": {
    "enabled": true,
    "formatWithErrors": false,
    "indentStyle": "space",
    "indentWidth": 2,
    "lineWidth": 120,
    "ignore": []
  },
  "javascript": {
    "formatter": {
      "quoteStyle": "single",
      "trailingComma": "all"
    }
  }
}

CLI:
  Version:                      1.4.1
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.12.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/9.1.1"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?
We enabled organiseImports but it does nothing for .tsx files.
NPM script: biome format ./src --write
Expected result
Imports should be organised.
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

I tried the include option as well, but it still doesn't work. The formatter it self runs properly for them.


Update README.md

Yeah, I know this is kinda dead, but I fixed some spelling errors to make the readme a little more easier to read.

lol


add soundcloud as a provider

:tada: This PR is included in version 1.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


MongoDB daily dumps seem to have stopped

The last mongo-dump file is from 2017-07-30.
https://ghtstorage.blob.core.windows.net/downloads/mongo-dump-2017-07-30.tar.gz

Indeed. The /scratch directory used to create them got full. It should be fine now.

Awesome.  Everything is back to normal.  Thanks Georgios!


[Bug]: package conflicts when installing @evidence-dev/labs

Describe the bug
After trying to install https://labs.evidence.dev via. npm install --save @evidence-dev/labs. I received conflict issues
❯ npm install --save @evidence-dev/labs
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving<EMAIL_ADDRESS>npm error Found<EMAIL_ADDRESS>npm error node_modules/svelte
npm error<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error   node_modules/@evidence-dev/component-utilities
npm error<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error     node_modules/@evidence-dev/core-components
npm error<EMAIL_ADDRESS>from the root project
npm error   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error   node_modules/@evidence-dev/core-components
npm error<EMAIL_ADDRESS>from the root project
npm error   20 more (@evidence-dev/evidence, @evidence-dev/preprocess, ...)
npm error
npm error Could not resolve dependency:
npm error @evidence-dev/labs@"*" from the root project
npm error
npm error Conflicting peer dependency<EMAIL_ADDRESS>npm error node_modules/svelte
npm error   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error   node_modules/@evidence-dev/labs
npm error     @evidence-dev/labs@"*" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error ~/.npm/_logs/2024-12-12T09_58_10_573Z-eresolve-report.txt
npm error A complete log of this run can be found in: ~/.npm/_logs/2024-12-12T09_58_10_573Z-debug-0.log

Which I tried to resolve by running npm install --save @evidence-dev/labs --legacy-peer-deps (without knowing what this does).
Now I can no longer use npm run dev to start up the evidence server.
I get the following errors when my evidence.plugins.yaml contains "@evidence-dev/labs": {} under the components section.
❯ npm run dev

><EMAIL_ADDRESS>dev
> evidence dev --open /

Failed to load component plugins Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in<EMAIL_ADDRESS>    at exportsNotFound (node:internal/modules/esm/resolve:296:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:586:13)
    at resolveExports (node:internal/modules/cjs/loader:639:36)
    at Module._findPath (node:internal/modules/cjs/loader:747:31)
    at Module._resolveFilename (node:internal/modules/cjs/loader:1234:27)
    at Function.resolve (node:internal/modules/helpers:145:19)
    at loadPluginPackage (.../node_modules/@evidence-dev/sdk/src/plugins/loadPluginPackage.js:14:75)
    at .../node_modules/@evidence-dev/sdk/src/plugins/components/loadComponentPlugins.js:36:23
    at Array.map (<anonymous>)
    at loadComponentPlugins (.../node_modules/@evidence-dev/sdk/src/plugins/components/loadComponentPlugins.js:35:39) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}
error when starting dev server:
Error: Could not resolve peer dependency "@sveltejs/vite-plugin-svelte" relative to your project — please install it and try again.
    at resolve_peer_dependency (.../node_modules/@sveltejs/kit/src/utils/import.js:16:9)
    at sveltekit (.../node_modules/@sveltejs/kit/src/exports/vite/index.js:157:27)
    at async Promise.all (index 0)
    at async asyncFlatten (.../node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:17501:12)
    at async resolveConfig (.../node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:66166:27)
    at async _createServer (.../node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:62758:18)
    at async CAC.<anonymous> (.../node_modules/vite/dist/node/cli.js:735:20)

And when evidence.plugins.yaml does not contain "@evidence-dev/labs": {} under the components section. I get
❯ npm run dev

><EMAIL_ADDRESS>dev
> evidence dev --open /

error when starting dev server:
Error: Could not resolve peer dependency "@sveltejs/vite-plugin-svelte" relative to your project — please install it and try again.
    at resolve_peer_dependency (.../node_modules/@sveltejs/kit/src/utils/import.js:16:9)
    at sveltekit (.../node_modules/@sveltejs/kit/src/exports/vite/index.js:157:27)
    at async Promise.all (index 0)
    at async asyncFlatten (.../node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:17501:12)
    at async resolveConfig (.../node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:66166:27)
    at async _createServer (.../node_modules/vite/dist/node/chunks/dep-CB_7IfJ-.js:62758:18)
    at async CAC.<anonymous> (.../node_modules/vite/dist/node/cli.js:735:20)

I then ran npm install @sveltejs/vite-plugin-svelte and got more errors. I don't know enough about npm & svelte dependencies etc to troubleshoot.
Steps to Reproduce

npm install --save @evidence-dev/labs
npm install --save @evidence-dev/labs --legacy-peer-deps
include "@evidence-dev/labs": {} under components: section of evidence.plugins.yaml ... or don't and then run
npm run dev

Logs

System Info

Severity
blocking all usage of Evidence
Additional Information, or Workarounds
I don't know how to get back to the original installation state of evidence now so I can't use it at all

Evidence Labs is no longer maintained. We should remove this from the docs

don't know how to get back to the original installation state

You can remove @evidence-dev/labs from your package.json, delete package-lock.json and node_modules and retry npm install

PR to remove from docs:
https://github.com/evidence-dev/evidence/pull/2925

Evidence Labs is no longer maintained. We should remove this from the docs

don't know how to get back to the original installation state

You can

remove @evidence-dev/labs from your package.json
delete package-lock.json and node_modules
retry npm install

I tried this but still get errors:
❯ npm install
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving<EMAIL_ADDRESS>npm error Found<EMAIL_ADDRESS>npm error node_modules/@sveltejs/vite-plugin-svelte
npm error   dev<EMAIL_ADDRESS>from the root project
npm error
npm error Could not resolve dependency:
npm error peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm error node_modules/@evidence-dev/evidence
npm error<EMAIL_ADDRESS>from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error ~/.npm/_logs/2024-12-17T10_35_26_945Z-eresolve-report.txt
npm error A complete log of this run can be found in: ~/.npm/_logs/2024-12-17T10_35_26_945Z-debug-0.log

I don't understand enough of the js/npm/svelte ecosystem. Am I supposed to be doing this in some kind of virtual-env, I just followed the docs quick-install but now the whole system is buggered

I have now removed Evidence labs from the docs so I'm going to close this issue. If you have other issues, feel free to open a new one


COMPONENTS: Main Nav

Logo

Links

Dropdown

Searchbar

Language Icon

Mobile Version

User Stories:

As a visitor, I'd like the option to switch between multiple languages (Norwegian, English, French, and Malagasy) for ease of understanding, regardless of my language preference.

As a visitor, I expect to search for specific information or topics easily on the website, ensuring I can locate desired content quickly and efficiently.

As a visitor, I hope to access the charity's social media accounts (e.g., Instagram, Facebook) easily, allowing me to stay connected and share information with others.

Finished the UI.
We need to decide the link interactivity and exactly which pages to include in main-nav.
Can be reiterated.


No such file or directory: '/your_data_path/flower/poses_bounds_exps.npy'

Hello @shsf0817,
This is amazing work. I am facing this error after running command
 python3 run_nerf.py --config configs/flower.txt
Error
Traceback (most recent call last):
  File "/home/adwait/hdr-nerf/run_nerf.py", line 790, in <module>
    train()
  File "/home/adwait/hdr-nerf/run_nerf.py", line 458, in train
    images, poses, bds, exps_source, render_poses, render_exps, i_test = load_real_llff_data(args.datadir, args.factor,
  File "/home/adwait/hdr-nerf/load_real_llff.py", line 236, in load_real_llff_data
    poses, bds, exp, imgs = _load_data(basedir, factor=factor) # factor=8 downsamples original imgs by 8x
  File "/home/adwait/hdr-nerf/load_real_llff.py", line 61, in _load_data
    poses_arr = np.load(os.path.join(basedir, 'poses_bounds_exps.npy'))
  File "/home/adwait/.local/lib/python3.10/site-packages/numpy/lib/npyio.py", line 390, in load
    fid = stack.enter_context(open(os_fspath(file), "rb"))
FileNotFoundError: [Errno 2] No such file or directory: '/your_data_path/flower/poses_bounds_exps.npy'

Please could you help?

You could replace the 'datadir' and 'basedir' in configs/flower.txt with your path, which can solve this error.

Hello @shsf0817,
This is amazing work. I am facing this error after running command
 python3 run_nerf.py --config configs/flower.txt
Error
Traceback (most recent call last):
  File "/home/adwait/hdr-nerf/run_nerf.py", line 790, in <module>
    train()
  File "/home/adwait/hdr-nerf/run_nerf.py", line 458, in train
    images, poses, bds, exps_source, render_poses, render_exps, i_test = load_real_llff_data(args.datadir, args.factor,
  File "/home/adwait/hdr-nerf/load_real_llff.py", line 236, in load_real_llff_data
    poses, bds, exp, imgs = _load_data(basedir, factor=factor) # factor=8 downsamples original imgs by 8x
  File "/home/adwait/hdr-nerf/load_real_llff.py", line 61, in _load_data
    poses_arr = np.load(os.path.join(basedir, 'poses_bounds_exps.npy'))
  File "/home/adwait/.local/lib/python3.10/site-packages/numpy/lib/npyio.py", line 390, in load
    fid = stack.enter_context(open(os_fspath(file), "rb"))
FileNotFoundError: [Errno 2] No such file or directory: '/your_data_path/flower/poses_bounds_exps.npy'

Please could you help?

Hi， thanks for your attention. You could replace the 'datadir' and 'basedir' in configs/flower.txt with your path, which can solve this error.

Something like this @shsf0817
basedir = /home/adwait/hdr-nerf/logs
datadir = /home/adwait/hdr-nerf/demo/flower

Something like this @shsf0817.
basedir = /home/adwait/hdr-nerf/logs datadir = /home/adwait/hdr-nerf/demo/flower
Is there a way to run it in google colab?

Sorry, I haven't tested the code in google colab.


Android infinite loop when refuse permission

Hello, I use your plugin for the location of a user in my application. Some users refuse permission to geolocate on Android and have made application of the application does not stop to call the functions onPause and onResume and therefore crash my application.
I have seen a similar problem on android but I do not know how to implement on this plugin.
https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/90

Hi.
You have created a Pull Request. Can you close it?
If you have found a problem, report it on issues.cordova.io
Thanks


Link-to-Web: separate URL and metadata

At the moment, we write all fields in single JSON: URL, title and description; all these fields are treated as parts of resource. This causes ResourceId be recalculated every time title or description changes. ResourceId should depend only on the URL. The rest must be written into upcoming metadata storage.
This changes the very core of ARK Shelf app (mobile and desktop versions).

The bounty was finished: https://gitcoin.co/issue/29265


Be able to disable deskop composition without using fullscreen

Currently, if not using fullscreen in games/rendering applications with fullscreen optimisations disabled, DWM.exe force tripple buffering on every monitor which increase a lot the latency experienced by the user. Using every app in fullscreen isn't practical and is a pita for dual monitors users. The only way I'm aware of disabling the composition in windows 10 is by disabling DWM.exe, which can (and will) cause many crashes, bsod and stange bugs everywhrere in the os. Being able to disable desktop composition like it was in windows 7 would be great.

I doubt Microsoft will consider this one because ever since Windows 8 DWM has been mandatory for WinRT/UWP GUI elements to be layered correctly.  Microsoft would have to rewrite their UWP and/or GDI stack to pull this one off.

Fullscreen doesn't actually disable desktop composition but instead pauses it, this disabling all GDI elements in order to give the GPU exclusive access to the screen.

I see, thanks for the clarification ! However,  I was under the impression that the "syncing" process wasn't a core component of the desktop window manager and more akin to an "effect" that would be applied after all the rendering was done (at least, the current implementation seems to be allowing variable refresh rates as freesync and gsync monitors users currently use that feature).
Thus, the idea would be to expose that feature to the end user along with the option of completely disabling triple buffering with the current implementation of dwm rather than replacing or disabling it completely.
Does that make sense ?

@nalf3in, how are you experiencing latency.  would love to put you in contact with the team and better understand that.
Disabling I'm pretty sure won't be possible so i'm going to close this as "won't fix"

@crutkas Desktop composition forces vertical sync to be always enabled in windowed mode. It makes the desktop feel significantly less responsive on low refresh rate monitors, so some may prefer the lower input latency even at the cost of screen tearing.

@crutkas DWM forces vertical sync to be always enabled in windowed mode. It makes the desktop feel significantly less responsive on low refresh rate monitors, so some may prefer the lower input latency even at the cost of screen tearing.

If your game can utilize flip model it can bypass that latency - https://wiki.special-k.info/Presentation_Model
In Windows 11 you can force DirectX 11 and 12 games to always use flip model.

But won't that only work in games, rather than other apps like browsers? The difference in responsiveness is still noticeable even outside of games when testing on Windows 7 or Linux with composition disabled.

But won't that only work in games, rather than other apps like browsers? The difference in responsiveness is still noticeable even outside of games when testing on Windows 7 or Linux with composition disabled.

Windows 7 doesn't support flip model.  Also it appears browsers are running in flip model on 10 and 11, at least Chromium based ones.


Permissions issue - question

Hi
I've created plugin with Builder at one instance of OctoberCMS.
Then I copied this plugin to another instance of OctoberCMS (and another project) on another PC.
And now I can't edit my plugin on the second instance with Builder.
I set the correct author in builder's settings.
Is there a way to resolve this problem?
Thanks in advance

Triple check your author settings for the builder plugin and the actual author name of the plugin you are trying to modify. As well, you could just click on the filter button in the builder plugin list to see all plugins on the system.


[CELEBORN-961] Catch exception when constructing Worker

What changes were proposed in this pull request?
Move the constructor of Worker into a try-catch block.
Why are the changes needed?
There are some exceptions thrown from Worker's constructor instead of Worker.initialize(), so it is necessary to catch these exceptions.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Start a worker with conf
celeborn.worker.directMemoryRatioToPauseReceive=0.7
celeborn.worker.directMemoryRatioToResume=0.7

an IllegalArgumentException will be caught

LGTM, thanks! BTW, could you set your email address in your github account, so that the project can track? @jiang13021

OK, I've done

Thanks, merged to main/0.3


Debug version resolution and conda/wheel interactions

I have a not-so-trivial setup to test with multiple versions of dependencies:

[tool.pixi.project]
channels = ["conda-forge"]
platforms = ["linux-64", "osx-arm64", "osx-64", "win-64"]

[tool.pixi.dependencies]
# scikit-learn is not included here since it's included explicitly in each task's
# dependencies either from conda or pypi (pre-release).
rich = ">=12"

[tool.pixi.pypi-dependencies]
skops = { path = ".", editable = true }

[tool.pixi.feature.docs.dependencies]
# To be synced with the versions in docs/requirements.txt
matplotlib = ">=3.3"
pandas = ">=1"
sphinx = ">=3.2.0"
sphinx-gallery = ">=0.7.0"
sphinx-rtd-theme = ">=1"
numpydoc = ">=1.0.0"
sphinx-prompt = ">=1.3.0"
sphinx-issues = ">=1.2.0"

[tool.pixi.feature.docs.pypi-dependencies]
# everything that depends on scikit-learn needs to be a pypi dependency so that this
# spec is compatible with the nightly build environment.
fairlearn = ">=0.7.0"

[tool.pixi.feature.tests.dependencies]
pytest = ">=7"
pytest-cov = ">=2.9.0"
flake8 = ">=3.8.2"
types-requests = ">=2.28.5"
flaky = ">=3.7.0"
rich = ">=12"
matplotlib = ">=3.3"
pandas = ">=1"

[tool.pixi.feature.tests.pypi-dependencies]
# these are packages that require scikit-learn. They need to be as a pypi dependency
# because otherwise there will be a package resolution conflict between pypi and conda
# when installing pre-release nightly release.
lightgbm = ">=3"
xgboost = ">=1.6"

[tool.pixi.feature.min-deps.dependencies]
python = "=3.9"
# all version constraints for this package seem to resolve to the latest. so leaving it
# as is.
quantile-forest = "=1.3.11"
scikit-learn = "~=1.1.0"
pytest = "=7"
pytest-cov = "=2.9.0"
flake8 = "=3.8.2"
types-requests = "=2.28.5"
flaky = "=3.7.0"
catboost = "~=1.0"
rich = "=12"
matplotlib = "=3.3"
pandas = "=1"
lightgbm = "=3"
xgboost = "=1.6"

[tool.pixi.feature.lint.dependencies]
pre-commit = "*"

[tool.pixi.feature.dev.dependencies]
ipython = "*"

[tool.pixi.feature.sklearn11.dependencies]
scikit-learn = "~=1.1.0"
pandas = "~=1.4"
numpy = "~=1.22"
scipy = "~=1.8"
fairlearn = "~=0.7"
catboost = ">=1.0"
python = "=3.9"

[tool.pixi.feature.sklearn12.dependencies]
scikit-learn = "~=1.2.0"
pandas = "~=1.5"
numpy = "~=1.24"
scipy = "~=1.9"
fairlearn = "~=0.8"
catboost = ">=1.0"
python = "=3.10"

[tool.pixi.feature.sklearn13.dependencies]
scikit-learn = "~=1.3.0"
pandas = "~=2.0"
numpy = "~=1.25"
scipy = "~=1.10"
fairlearn = "~=0.9"
catboost = ">=1.0"
python = "=3.11"

[tool.pixi.feature.sklearn14.dependencies]
scikit-learn = "~=1.4.0"
pandas = "~=2.1"
numpy = "~=1.26"
scipy = "~=1.11"
fairlearn = "~=0.10"
catboost = ">=1.0"
python = "=3.12"

[tool.pixi.feature.sklearn15.dependencies]
scikit-learn = "~=1.5"
fairlearn = "~=0.10"
pandas = "~=2.1"
numpy = "~=2.0"
scipy = "~=1.13"
python = "=3.13"
quantile-forest = "~=1.3.11"

[tool.pixi.feature.sklearn16]
# TODO: comment this out once scikit-learn 1.6 is released and keep for testing against
# the next release candidate.
channels = [
    {channel = "conda-forge/label/scikit-learn_rc", priority = 2},
    {channel = "conda-forge", priority = 1},
]

[tool.pixi.feature.sklearn16.dependencies]
scikit-learn = "*"
fairlearn = "~=0.11"
pandas = "~=2.2"
numpy = "~=2.1"
scipy = "~=1.9"
# add when catboost supports 3.13
# https://github.com/catboost/catboost/issues/2748
# catboost = ">=1.0"
# add quantile-forest when it's released
# https://github.com/zillow/quantile-forest/issues/103
# quantile-forest = "~=1.4"
python = "=3.13"

[tool.pixi.feature.sklearn17.pypi-options]
# This is for the nightly channel to test the dev version of scikit-learn.
extra-index-urls = ["https://pypi.anaconda.org/scientific-python-nightly-wheels/simple"]

[tool.pixi.feature.sklearn17.pypi-dependencies]
# The version value here needs to be exact, hence == instead of ~=
scikit-learn = "==1.7.dev0"
fairlearn = "*"
pandas = "*"
numpy = "*"
scipy = "*"

[tool.pixi.feature.lint.tasks]
lint = { cmd = "pre-commit install && pre-commit run -v --all-files --show-diff-on-failure" }

[tool.pixi.feature.tests.tasks]
tests = { cmd = "pytest -vsl --cov=skops --cov-report=xml --cov-report=term-missing -m \"not inference\" skops" }

[tool.pixi.environments]
default = ["docs", "tests", "lint", "rich", "dev", "sklearn17"]
lint = ["lint"]
docs = ["docs"]
ci-min-deps = ["rich", "tests", "lint", "min-deps"]
ci-sklearn11 = ["rich", "tests", "lint", "sklearn11"]
ci-sklearn12 = ["rich", "tests", "lint", "sklearn12"]
ci-sklearn13 = ["rich", "tests", "lint", "sklearn13"]
ci-sklearn14 = ["rich", "tests", "lint", "sklearn14"]
ci-sklearn15 = ["rich", "tests", "lint", "sklearn15"]
ci-sklearn16 = ["rich", "tests", "lint", "sklearn16"]
ci-sklearn17 = ["rich", "tests", "lint", "sklearn17"]

However, for the ci-sklearn11 case, eventhough I have this bit:
[tool.pixi.feature.sklearn11.dependencies]
scikit-learn = "~=1.1.0"
pandas = "~=1.4"
numpy = "~=1.22"
scipy = "~=1.8"
fairlearn = "~=0.7"
catboost = ">=1.0"
python = "=3.9"

when I get into the environment to check the scipy version, it's 1.13.1. This is probably coming from the fact that there are pypi as well as conda dpes, and the pypi deps seem to run after conda deps, and transiantly they override the scipy chosen by conda.
I don't see an easy way to debug these other than removing my lock file, disabling all envs except the one I'm interested in, and run a pixi -v command.
It'd be nicer if I could avoid that and nicely get deps resolution for an env, as well as having pypi and conda deps resolved together rather than one after another.

I guess solving the two together is something, solving one after another and detecting inconsistencies with explicitly specified constraints is another one, which is easier to achieve.


[HBASE-25328] Add builder method to create Tags.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 12s
master passed

+1 :green_heart:
checkstyle
0m 25s
master passed

+1 :green_heart:
spotbugs
0m 43s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 46s
the patch passed

+1 :green_heart:
checkstyle
0m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m  5s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

38m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 7457c8768d30 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fc3313771d

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell  @gjacoby126  @virajjasani  Could you please help reviewing this change ? Thank you !

We should not be exposing entire PrivateCellUtil even for CPs.  There is a Cell util public and CP exposed version.  For CPs to handle tags, if we need new APIs, lets target those and expose that only.  Like we have TagUtil now but private. Pls explain what are the reqs.
May be we need a way to create new Tag in correct format.  API to retrieve tags from Cell. API to add a new tag to existing Cell with or with out tags already. What else?  Let us discuss in Jira

These classes are all implementation class, so in general I do not think it is a good idea to make them public to others.
I did a simple search on https://github.com/apache/phoenix/pull/978, seems the requirement here is to create a Tag? Could we introduce something like a Tag builder and make it IA.LimitedPrivate, instead of directly expose these implementation classes?
Thanks.

Quick recap for those who haven't been following this issue:

@shahrs87 wanted to add the ability to add a custom Tag to a Delete marker, and was told that client reads or writes to Tags of any sort weren't allowed as features, but that a coproc could be used as an acceptable workaround.
It turned out that a coproc could be written, but only with code using calls that were deprecated and/or IA.Private. On the  Phoenix review, I asked @shahrs87 to fix this.
@shahrs87 raised this PR

And some more points:

Yesterday I noticed that a different Phoenix feature which I did not implement or review was recently committed using IA.Private and deprecated APIs to do something similar with Tags in a coproc. Clearly there's a general need here.
Phoenix supports HBase 1.3+ on branch-1 and 2.1+ on branch-2, with 1.3 and 2.1 support to be dropped after our next release, likely in the next month or two.
Because of semantic versioning, @anoopsjohn 's suggestion of a new LP API would only be usable in HBase 2.5+, which probably won't release until mid-2021, and likely wouldn't be released in a Phoenix version until late 2021. Using the "bad" APIs gets @shahrs87 's Phoenix feature released in the next month or so, and usable in Phoenix for all HBase versions, not just 2.5 and maybe 1.7.

I agree that @anoopsjohn and @Apache9 's proposals would be the right solution a few years back when 2.0 was being developed, but they're really expensive to do now.  I'm wearing three hats on this issue as an HBase contributor, Phoenix committer, and at my day job as an eventual user of the feature @shahrs87 is developing.
I'd like to do the right thing by all 3 of my hats -- is there a right thing that doesn't involve @shahrs87 and I waiting a year to do something in a coproc the HBase community long ago decided was OK to do?

We should not be exposing entire PrivateCellUtil even for CPs. There is a Cell util public and CP exposed version. For CPs to handle tags, if we need new APIs, lets target those and expose that only. Like we have TagUtil now but private. Pls explain what are the reqs.
May be we need a way to create new Tag in correct format. API to retrieve tags from Cell. API to add a new tag to existing Cell with or with out tags already. What else? Let us discuss in Jira

Requirements:

Create a new tag: Currently there are 2 implementations of Tag i.e. ArrayBackedTag and ByteBufferTag. Both the implementations are annotated as IA.Private. @Apache9  gave an idea to create a Builder class and make that LimitedPrivate while keeping the implementation still Private. This makes sense.

Creating a new Cell with existing Cell and list of Tags: PrivateCellUtil#Cell createCell(Cell cell, List tags)
I can't find any replacement for this api. Please let me know if I missed any class.

Get a list of Tags from a Cell something like: PrivateCellUtil#List getTags(Cell cell)
There is an already existing method which is CP public RawCell#Iterator getTags() but that returns an iterator and we have to convert it to list which is what PrivateCellUtil#getTags is exactly doing. This is nice to have api.

Cc @anoopsjohn  @Apache9 @gjacoby126

Question: would it be possible to do the following?

Mark sufficient existing APIs to create/read from Tags in coproc as LimitedPrivate(COPROC) to unblock existing Phoenix development efforts but only for branch-2 and if needed branch-1
Develop a better, more abstracted LimitedPrivate API as @anoopsjohn , @Apache9 and @shahrs87 are discussing above, to be released in HBase 2.5 (and potentially 1.7)
When HBase 3.0 is released, the new LimitedPrivate API in 2.5 becomes the only Tag API for coprocs. Reverting the temporary LimitedPrivate annotations on the existing methods to Private would be less impactful as part of a major release transition.

This gives Phoenix and other coproc developers an approved path that works for all current release branches without a long delay. It avoids either ignoring the IA, or having an awkward situation where "Phoenix 5.1 with HBase 2.5 supports Feature X, but the same Phoenix with HBase 2.4 doesn't", which already happens too often for other reasons.
But we still further the HBase community's long-standing efforts to better abstract away implementation details and only expose interfaces.
@anoopsjohn @Apache9 and @apurtell , wdyt?

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 10s
master passed

+1 :green_heart:
checkstyle
0m 27s
master passed

+1 :green_heart:
spotbugs
0m 45s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 49s
the patch passed

-0 :warning:
checkstyle
0m 24s
hbase-common: The patch generated 9 new + 56 unchanged - 0 fixed = 65 total (was 56)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m  1s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
0m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

38m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 09df588238cd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e6165412e0

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@anoopsjohn  @Apache9 @gjacoby126  Could you please review the changes for master branch.
Also it would be of great help if you guys can suggest path for Geoffrey's comment here. It will give me clear direction on how to proceed with phoenix-6231's patch. Thank you !

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 35s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

+1 :green_heart:
javac
0m 26s
the patch passed

+1 :green_heart:
shadedjars
7m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 15s
hbase-common in the patch failed.

29m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f6fb4baf9de4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 264412d30c

Default Java
AdoptOpenJDK-11.0.6+10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-common.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/4/testReport/

Max. process+thread count
211 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 32s
the patch passed

-0 :warning:
checkstyle
0m 23s
hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
0m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

35m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 6451ebcab9ee 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 264412d30c

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@anoopsjohn  @Apache9  @apurtell  Could you please review ?
 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 40s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed

+1 :green_heart:
javac
0m 27s
the patch passed

+1 :green_heart:
shadedjars
7m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
1m 16s
hbase-common in the patch failed.

30m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6c41e684a008 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 264412d30c

Default Java
AdoptOpenJDK-11.0.6+10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-common.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/5/testReport/

Max. process+thread count
202 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/5/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 25s
master passed

+1 :green_heart:
checkstyle
0m 23s
master passed

+1 :green_heart:
spotbugs
0m 41s
master passed

-0 :warning:
patch
0m 50s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 26s
the patch passed

-0 :warning:
checkstyle
0m 23s
hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  7s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

34m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux a2698acabbd1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 264412d30c

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/5/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
master passed

+1 :green_heart:
compile
0m 22s
master passed

+1 :green_heart:
shadedjars
7m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 20s
master passed

-0 :warning:
patch
7m 37s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 39s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

+1 :green_heart:
javac
0m 26s
the patch passed

+1 :green_heart:
shadedjars
7m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 12s
hbase-common in the patch passed.

30m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3c2d47ea9fcc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 264412d30c

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/6/testReport/

Max. process+thread count
205 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 53s
master passed

+1 :green_heart:
checkstyle
0m 24s
master passed

+1 :green_heart:
spotbugs
0m 43s
master passed

-0 :warning:
patch
0m 51s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 49s
the patch passed

-0 :warning:
checkstyle
0m 23s
hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 59s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
0m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

38m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux a13ea561c5dc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 264412d30c

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani  Thank you for the review. Could you please merge the PR ? I can provide patch for branch-2 and branch-1 after that if it doesn't apply cleanly.

Sure, let's wait for around half day time and unless there are any concerns, planning to merge the PR.
Thanks

Doing the review now. Sorry for being late to respond here

@anoopsjohn Thank you for your review. I have tried to address all your comments in last commit.  Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 34s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

+1 :green_heart:
javac
0m 26s
the patch passed

+1 :green_heart:
shadedjars
7m 24s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  6s
hbase-common in the patch passed.

30m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 21c7db207e21 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7d0a687e57

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/7/testReport/

Max. process+thread count
215 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/7/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m  6s
master passed

+1 :green_heart:
checkstyle
0m 24s
master passed

+1 :green_heart:
spotbugs
0m 41s
master passed

-0 :warning:
patch
0m 49s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 49s
the patch passed

-0 :warning:
checkstyle
0m 24s
hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 39s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
0m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

39m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux c2689ba77b08 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7d0a687e57

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/7/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@anoopsjohn  Addressed all your comments. Please review again. Thank you for your feedback !

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 34s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 10s
master passed

+1 :green_heart:
compile
0m 23s
master passed

+1 :green_heart:
shadedjars
7m 18s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 21s
master passed

-0 :warning:
patch
7m 48s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 49s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

+1 :green_heart:
javac
0m 26s
the patch passed

+1 :green_heart:
shadedjars
7m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 50s
hbase-common in the patch passed.

31m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4ee187ef06f4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7d0a687e57

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/8/testReport/

Max. process+thread count
198 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/8/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
the patch passed

+1 :green_heart:
compile
0m 22s
the patch passed

+1 :green_heart:
javac
0m 22s
the patch passed

+1 :green_heart:
shadedjars
7m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 36s
hbase-common in the patch passed.

27m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f4a130df4bf3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7d0a687e57

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/9/testReport/

Max. process+thread count
313 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/9/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 59s
master passed

+1 :green_heart:
compile
0m 28s
master passed

+1 :green_heart:
shadedjars
7m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
master passed

-0 :warning:
patch
8m 24s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 18s
the patch passed

+1 :green_heart:
compile
0m 29s
the patch passed

+1 :green_heart:
javac
0m 29s
the patch passed

+1 :green_heart:
shadedjars
8m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 29s
hbase-common in the patch passed.

33m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c48bd6b365b5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7d0a687e57

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/9/testReport/

Max. process+thread count
206 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/9/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 48s
master passed

+1 :green_heart:
checkstyle
0m 24s
master passed

+1 :green_heart:
spotbugs
0m 42s
master passed

-0 :warning:
patch
0m 51s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 48s
master passed

+1 :green_heart:
checkstyle
0m 24s
master passed

+1 :green_heart:
spotbugs
0m 41s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 45s
the patch passed

-0 :warning:
checkstyle
0m 24s
hbase-common: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 45s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
0m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

37m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/10/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2707

JIRA Issue
HBASE-25328

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux db18ecc02662 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7d0a687e57

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/10/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2707/10/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


404 when trying to download Node 8.1.1 headers

I am trying to build an npm package from source:
npm i fsevents --build-from-source

But this results in an
gyp ERR! stack Error: 404 response downloading https://nodejs.org/download//v8.1.1/node-v8.1.1-headers.tar.gz

Any help with this would be greatly appreciated. I'm on macOS v10.12.5 using node-gyp v3.6.2 and node v8.1.1.

node-gyp install throws same error as well on macOS with node 8.1.1.
Workaround:
run node-gyp install --dist-url https://nodejs.org/download/release to get the 8.1.1 headers downloaded properly then run your npm i again.
@michaeldzjap are you using nvm? I think this has something to do with *_MIRROR environment variables but I don't see anything about overrides when running node-gyp install --verbose

Something went wrong with the release, the embedded download URL is wrong:
$ ./node-v8.1.0-darwin-x64/bin/node -p process.release
{ name: 'node',
  sourceUrl: 'https://nodejs.org/download/release/v8.1.0/node-v8.1.0.tar.gz',
  headersUrl: 'https://nodejs.org/download/release/v8.1.0/node-v8.1.0-headers.tar.gz' }

$ ./node-v8.1.1-darwin-x64/bin/node -p process.release
{ name: 'node',
  sourceUrl: 'https://nodejs.org/download//v8.1.1/node-v8.1.1.tar.gz',
  headersUrl: 'https://nodejs.org/download//v8.1.1/node-v8.1.1-headers.tar.gz' }

IOW, not a node-gyp issue.  You'll have to use a workaround with v8.1.1 like the one @Jeff-Lewis posted.

@Jeff-Lewis Thanks, explicitly specifying the URL solved the problem. I'll close the issue, since it is not related to node-gyp.

For folks finding this issue from problems with node-sass or other things running gyp from a postinstall script where passing --dist-url is difficult, workaround with NPM_CONFIG_DISTURL=https://nodejs.org/download/release/ in your env instead.
If you're on Heroku, just do a heroku config:set NPM_CONFIG_DISTURL=https://nodejs.org/download/release/ to get your build working again.
Do make sure to unset this var on the next node release so your build doesn't break if the values from node -p process.release change later on.


[BUG] Kagami fails to generate a validator when runs outside of the repo dir

OS and Environment
macOS 13.2.1 (22D68)
GIT commit hash
d7e054d
Minimum working example / Steps to reproduce

Create a directory:
mkdir test && cd test

Install kagami binary there:
cargo install --git https://github.com/hyperledger/iroha.git \
   --rev d7e054d3aca37f1a93383d2318e7b46fa76e0010 \ # or simply `--branch iroha2-dev`
   --root ./cargo-install-root \
   kagami

Run compiled kagami:
./cargo-install-root/bin/kagami validator

Actual result
Error:
   0: Failed to construct absolute path for: ../../default_validator
   1: Expected `CARGO_MANIFEST_DIR` environment variable
   2: environment variable not found

Expected result
Expected to get the compiled wasm blob.
Logs in JSON format
N/A
Who can help to reproduce?
No response
Notes
Kagami relies to be always executed in the root of the repo:
https://github.com/hyperledger/iroha/blob/d7e054d3aca37f1a93383d2318e7b46fa76e0010/tools/kagami/src/main.rs#L815-L826
I don't think this is correct - Kagami should be a standalone, self-contained binary with "all batteries included". So, the wasm binary should be inlined into the binary itself.
This functionality is essential for #2373, which I am working on now. Thus, I assign this issue to myself.

mac m1 test

test on linux x86 gives the same results

mac m1 test
...
test on linux x86 gives the same results
Should be addressed by #3748.


reinforceDefense bug when there is a team not included in .env

Hi @coccoinomane,
I have encountered this error when trying to run reinforceDefense on a wallet with an auto-lose team (not enrolled in .env because we are auto-losing this team)
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/ec2-user/crabada-pool/bin/mining/reinforceDefense.py", line 28, in <module>
    nReinforced = reinforceDefense(userAddress)
  File "/home/ec2-user/crabada-pool/src/bot/mining/reinforceDefense.py", line 42, in reinforceDefense
    strategyName = user.getTeamConfig(mine["team_id"]).get("reinforceStrategyName")

Basically, let's say you have 3 teams. 2 high mp crabs and 1 Bulk Bulk Bulk.
You would rather auto lose BBB vs. reinforcing them for +EV return.

its failing because the teamConfig is None. maybe u could pass in a default value there or add an if statemnt when u trying to get the strategy

What do you suggest? Would passing a default value be more friendly for everyone? or an if statement?

likely could create a new strategy that returns no crabs, then register that crab team under .env with that strategy name

likely could create a new strategy that returns no crabs, then register that crab team under .env with that strategy name

Or a blacklist of teams for no reinforce, but can mine and settle.

Do you have an idea for a NoReinforce strategy logic? @EugeneTeu

class NoReinforceStrategy(ReinforceStrategy):

  def crab(self, game: Game, list: List[CrabForLending]) -> CrabForLending:
   return None

@coccoinomane

Thank you @coccoinomane, I guess that fixed the bug I reported.

Thanks @nikohd12 for spotting this bug, and thanks @EugeneTeu for proposing the new strategy 👍
The bug is actually worse than what it seems, because the bot should not consider a team unless it is not explcitly listed in .env. I have fixed this part in https://github.com/coccoinomane/crabada.py/pull/18
I also pushed the NoReinforceStrategy.py to master (https://github.com/coccoinomane/crabada.py/commit/398a9ce48bc077f5fe05868d6372c92c2a49c191).
@EugeneTeu I slightly changed your approach and overridden the query method rather than the getCrab method in order to avoid making a useless query to Crabada.
@nikohd12 , would you mind testing if the NoReinforce strategy fixes the original bug?
Thanks,
Cocco

Thanks @nikohd12 for spotting this bug, and thanks @EugeneTeu for proposing the new strategy 👍
The bug is actually worse than what it seems, because the bot should not consider a team unless it is not explcitly listed in .env. I have fixed this part in #18
I also pushed the NoReinforceStrategy.py to master (398a9ce). @EugeneTeu I slightly changed your approach and overridden the query method rather than the getCrab method in order to avoid making a useless query to Crabada.
@nikohd12 , would you mind testing if the NoReinforce strategy fixes the original bug?
Thanks, Cocco

Will do, I'll have to wait for my auto-lose team to finish and add them to my .env with NoReinforce. I'll update once testing is done.
Thank you!

Take your time, no worries 🙂

Hi @coccoinomane,
My auto-lose team kept on losing.  Thank you! No more errors upon checking cron mail too.

I am sorry for the team's morale, but happy for the bot ;-)
Thank you for letting me know, I am closing the issue.
Cheers,
Cocco


clientv3: fix health balancer, retry

Fix most of bugs in balancer with stale endpoints.
Fix sync with stale upc channel in retry path.
Will send a separate PR to remove redundant retry code.

test is still failing, but only one it seems.

GitHub sync doesn't seem to work... Will create a new PR after investigating test failures.


Typo in the main link

https://github.com/djmango/obsidian-transcription/blame/e43aae9740792401639204ca0d8636ca4940aa4b/README.md#L3C25-L3C66
The link Swiftink.io doesn't work because of 4 wwww.
P.S. I really appreciate the work you're doing, so decided to return the favor :)

Thanks @dsalavei! Just pushed a fix, totally missed this. If theres any feature additions you think would be nice to have or bugs you find don't hesitate to reach out!


misc: Add copyright & license notices to all files under jakttest/

I used git blame to get other contributors' names; but there might be
some cases I have missed.

Please don't add anyone but yourself.

A bunch of the changes look unrelated to the PR-title

OK, I updated everywhere that I added the license notice to only include myself. I don't really like it since I feel at least Andreas and JT should be in there, but if you say so, I'll just add myself and let you guys decide whether you want to add yourselves to the list :^)


Help: How to extend Pocketbase to include aggregate fields in resources

Hi and thank you for a great piece of software!
I was trying to figure out how to use aggregate values in resources, which I think is a core use case for relational databases.
The documentation doesn't show examples for actually combining the manual queries into models and showing the data in REST api.
Let's say I have a simple database of Posts and Comments. For each Post I want to see the number of comments and timestamp of last comment. Thus comments_count and last_comment would be a virtual column for Post. How exactly would you implement this with Pocketbase? Right now I solved this with Sqlite triggers to automatically update additional aggregate columns in the target table, but I don't think this is a scalable solution.
I was thinking that ultimately a readonly datatype 'sql query' would be great for this purpose, e.g. ('count(documents) etc. Admins would be able to set virtual columns directly from the web ui. But ofc the MVP would be to simply extend the server and supply your own sql queries.
Thank you for your help!

Aggregations and computed/virtual columns are not supported out of the box and this is left to users to handle on their own.
Currently there isn't an easy to do what you want without using PocketBase as framework and querying the database manually.
Here is an example how this would look like (I haven't tested it):
package main

import (
    "log"
    "net/http"

    "github.com/labstack/echo/v5"
    "github.com/pocketbase/pocketbase"
    "github.com/pocketbase/pocketbase/apis"
    "github.com/pocketbase/pocketbase/core"
    "github.com/pocketbase/pocketbase/tools/rest"
)

func main() {
    app := pocketbase.New()

    app.OnBeforeServe().Add(func(e *core.ServeEvent) error {
        // GET /api/posts_comments_count?postIds=1&postIds=2&postIds=3&...
        e.Router.AddRoute(echo.Route{
            Method: http.MethodGet,
            Path:   "/api/posts_comments_count",
            Handler: func(c echo.Context) error {
                requestData := struct {
                    PostIds []string `form:"postIds" json:"postIds"`
                }{}

                if err := c.Bind(&requestData); err != nil {
                    return rest.NewBadRequestError("Failed to load the submitted data due to invalid formatting.", err)
                }

                result := []*struct {
                    PostId          string `db:"postId" json:"postId"`
                    TotalComments   int    `db:"totalComments" json:"totalComments"`
                    LastCommentDate string `db:"lastCommentDate" json:"lastCommentDate"`
                }{}

                queryErr := app.Dao().DB().
                    Select("postId", "COUNT(id) as totalComments", "MAX(created) as lastCommentDate").
                    From("comments").
                    GroupBy("postId").
                    All(&result)
                if queryErr != nil {
                    return rest.NewBadRequestError("Failed to fetch comments count.", queryErr)
                }

                return c.JSON(200, result)
            },
            // optionally enable an auth middleware
            // Middlewares: []echo.MiddlewareFunc{
            //     apis.RequireAdminOrUserAuth(),
            // },
        })

        return nil
    })

    if err := app.Start(); err != nil {
        log.Fatal(err)
    }
}

Your suggestion for "sql" type field is a nice one, but I'll have to think a little more on it because it may turn out not so easy as it seems.


Fix that local traffic cannot be identified in networkPolicyOnly mode

Before this commit, in AntreaProxy, to respect short-circuiting, when installing flows for an external Services, an extra flow with higher priority to match traffic sourced from local (local Pods or local Node) and destined for the external Service will be installed. This is achieved by matching the local Pod CIDR obtained from the local Node object. However, when Antrea is deployed in networkPolicyOnly mode, the Pod CIDR in the local Node object is nil, resulting in the failure of install the extra flow mentioned above. To fix the issue, a new reg mark FromLocalRegMark identifying traffic from local Pods or the local Node is introduced to mark the traffic from local. This reg mark can be used in all traffic mode.
Fix #6244

/test-all

/test-windows-all


⚠ Spryr has degraded performance

In 6c396cb, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 503
Response time: 6086 ms

Resolved: Spryr performance has improved in 404a62a after 9 minutes.


refactor: useNetworkSelector instead of useNetworkContext

let's use the thunk pattern and make functions that use dispatch internally, instead of using useDispatch everywhere

preferred folder structure will be

redux

store.ts
slices

auth-slice.ts
auth-actions.ts


Transfer FXs between new multistop series

Now that the entire new Zoom multistomp series has been released [MS-50G+, MS-60B+, MS-70CDR+, MS-80IR+, MS-200D+], will we soon have a hack to transfer effects between them?
They are updates to the old series, but they came with some limitations, which means we have to buy more than one of these pedals, for example, the MS-50G+ does not have cab or IR simulation, the MS-80IR+ only has 3 blocks effect per preset, the MS-70CDR+ does not have amp or drive simulations...
With a possible hack, we would only need to have one of these pedals to access all the features of the new Zoom series.

Closing because Mungewell and chums are making excellent progress there on his Zoom zt2


Reprojection for Geometry Columns

cc: @vpipkt

Codecov Report

Merging #44 into develop will decrease coverage by 0.01%.
The diff coverage is 78.94%.

@@             Coverage Diff             @@
##           develop      #44      +/-   ##
===========================================
- Coverage    80.94%   80.92%   -0.02%
===========================================
  Files           92       93       +1
  Lines         1942     1961      +19
  Branches        90       90
===========================================
+ Hits          1572     1587      +15
- Misses         370      374       +4

Impacted Files
Coverage Δ

...la/astraea/spark/rasterframes/py/PyRFContext.scala
0% <0%> (ø)
:arrow_up:

...ark/rasterframes/jts/ReprojectionTransformer.scala
100% <100%> (ø)

...a/astraea/spark/rasterframes/RasterFunctions.scala
77.5% <100%> (+0.57%)
:arrow_up:

...astraea/spark/rasterframes/functions/package.scala
73.36% <100%> (+0.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79675cb...0f31f21. Read the comment docs.