Fix ErrorCommand loss some fields in Command

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.52%.  Consider uploading reports for the commit c0288d3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15847      +/-   ##
============================================
+ Coverage     39.47%   39.52%   +0.04%
- Complexity     4995     4996       +1
============================================
  Files          1347     1347
  Lines         45642    45611      -31
  Branches       4892     4869      -23
============================================
+ Hits          18019    18028       +9
+ Misses        25699    25659      -40
  Partials       1924     1924

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Language sprint - Week 09 - 2019

0.990.0 Spec deviations.

[ ] #13190 In an XML sequence, a character set is treated as a single string. However, in the specification, each character item is represented by a string with a single code point.
[ ] https://github.com/ballerina-platform/ballerina-lang/issues/13849 Variable Mutability in Closures
[ ] #13317, #13820: Inter-assignability between float, decimal constants and byte, int constants in a union type is allowed currently. Which is not the expected behavior. [WIP]
[ ] #13587: isAssignableToFiniteType method of Types class needs to be modified [WIP]
[ ] #13889: Introduce error binding pattern
[x] #13164: Support expressions for tuple index based access
[ ] #13838: Improvements to finite types
[ ] #13804: is check not allowed for union types that have an intersection
[x] #13654: Incorrect type checking for the reason specified in the error constructor
[ ] #13619: Module level variables cannot be public
[ ] #13899: Add map literal support to constants
[ ] #13900 Forward reference reordering needs to support Services and Objects
[ ] #13342 Object __init() methods return should be a subtype of error|()
[ ] #13903 Implicit init values of union types are only applicable when constituents are of same simple basic type

Compiler internals improvement

[x] #13902 Flatten the union type

Streaming

[ ] Prioritize the pattern processors based on their importance.
[ ] Design the very basic pattern processor (The basic state machine)
[x] #14027 Blog on implementing custom windows
[x] #14029 Fix intermittent test failures in streams

Language extensions  (k8s, docker etc.)

[x] https://github.com/ballerinax/kubernetes/issues/268 Typo in kubernetes error message
[x] https://github.com/ballerinax/kubernetes/issues/267 Config files are looked up at where ballerina command is run and not where the ballerina file is at.
[x] https://github.com/ballerinax/kubernetes/issues/164 Add Support for OpenShift
[x] https://github.com/ballerinax/kubernetes/issues/283 Error when deployment generated kubernetes artifacts

@gimantha @grainier @pubudu538 @MaryamZi @Anoukh @Shan1024 @pranavan15 @rdhananjaya @hemikak @NatashaWso2 @sameerajayasoma

PRs ready,
https://github.com/ballerina-platform/ballerina-lang/pull/13893
https://github.com/ballerina-platform/ballerina-lang/pull/13967
https://github.com/ballerina-platform/ballerina-lang/pull/13932
https://github.com/ballerina-platform/ballerina-lang/pull/14032
https://github.com/ballerina-platform/ballerina-lang/pull/13920

Open task were move to https://github.com/ballerina-platform/ballerina-lang/issues/14038


Failed to load the remote-edit package

[Enter steps to reproduce:]

...
...

Atom: 1.34.0 x64
Electron: 2.0.16
OS: Mac OS X 10.14.3
Thrown From: remote-edit package 1.9.0
Stack Trace
Failed to load the remote-edit package
At Path must be a string. Received undefined

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:28:11)
    at Object.resolve (path.js:1186:7)
    at /packages/remote-edit/lib/model/remote-edit-editor.coffee:7:36)
    at /packages/remote-edit/lib/model/remote-edit-editor.coffee:1:1)
    at /packages/remote-edit/lib/model/remote-edit-editor.coffee:1:1)
    at Module.get_Module._compile (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:146684)
    at Object.value [as .coffee] (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:150231)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:145974)
    at /packages/remote-edit/lib/main.coffee:3:20)
    at /packages/remote-edit/lib/main.coffee:1:1)
    at /packages/remote-edit/lib/main.coffee:1:1)
    at Module.get_Module._compile (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:146684)
    at Object.value [as .coffee] (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:150231)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (internal/module.js:11:18)
    at customRequire (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:1:639512)
    at Package.requireMainModule (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:2951243)
    at measure (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:2937954)
    at Package.measure (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:2936786)
    at Package.load (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:2937527)
    at PackageManager.loadAvailablePackage (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:381285)
    at config.transact (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:379708)
    at Config.transact (/Applications/Atom for cpp.app/Contents/Resources/app/static/<embedded>:11:332241)

Commands

Non-Core Packages
ask-stack 2.2.0
atom-beautify 0.33.4
atom-material-ui 2.1.3
atom-prettify 0.1.3
atomic-chrome 0.3.3
auto-update-packages 1.0.1
autocomplete-paths 2.12.2
browser-plus 0.0.98
busy-signal 2.0.0
color-picker 2.3.0
emmet 2.4.3
expose 0.15.0
file-icons 2.1.30
git-plus 8.6.1
git-time-machine 2.1.0
gpp-compiler 3.0.7
highlight-selected 0.14.0
intentions 1.1.5
language-liquid 0.7.0
linter 2.3.0
linter-eslint 8.5.2
linter-rubocop 2.2.4
linter-scss-lint 3.2.1
linter-ui-default 1.7.1
minimap 4.29.9
open-in-browsers 0.0.30
open-recent 5.0.0
pane-layout-plus 0.7.4
pdf-view 0.71.0
pigments 0.40.2
project-manager 3.3.6
remote-edit 1.9.0
sync-settings 0.8.6
tabs-to-spaces 1.0.5
terminal-plus 0.14.5
vim-mode 0.66.0
web-view 3.0.0

+1

same here.

This module have not been updated for two years - read this issue with suggestions https://github.com/sveale/remote-edit/issues/246

me too

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

Same...

Same, so where's the solution🤔

+1

same

+1

+1

+1

+1

+1

+1

+1

++

This happens to me from time to time. Each time it happens, I try restarting Atom, try opening/closing the project again and again. Eventually the problem gets fixed after 5-10 minutes. Not sure what's causing the issue and what's solving it.

same ...

same

same

👍

same

Just like Casper-O wrote, use ftp-remote-edit (works over SSH):
https://atom.io/packages/ftp-remote-edit

any fix? +1

++

same


Picking up items in spectator mode

You are able to pickup items in spectator mode.

Now solved, i think...


run co19 debug tests with release compiler

Some co19 tests in debug mode are really slow because the compiler itself also runs in debug mode:
$ tools/test.py -m debug co19_2/LibTest/collection/ListMixin/ListMixin_class_A01_t02
tools/testing/dart/main.dart:1: Warning: Interpreting this as package URI, 'package:test_dart/main.dart'.
Test configuration:
    custom configuration(architecture: x64, compiler: dartk, mode: debug, runtime: vm, system: mac, vm-options: [], timeout: null, preview-dart-2)
Suites tested: co19_2
[03:38 | 100% | +    1 | -    0]

@mraleph suggested that we should change the configuration such that the compiler itself runs in release mode.
@mkustermann would this be possible?

I think changing the way we run tests depending on test suite (like co19) is not a good idea. There's nothing which makes co19 more special than language_2 or other test suites we have.
For sim* architectures we compile tests to .dill files separately and run them then on the debug VM. We do this to avoid running the kernel isolate in simulated mode, which can be very slow.
For x64 we have an app-jit trained kernel-isolate, which should run fast (it's generated code) so there's no need to do the same as for sim* architectures.
What is this particular test doing? Maybe some of the co19 tests should be re-written do do less work.

It is calling

/tests/co19_2/src/LibTest/core/List/sort_A01_t04.test.dart
/tests/co19_2/src/LibTest/core/List/sort_A01_t05.test.dart
/tests/co19_2/src/LibTest/core/List/sort_A01_t06.test.dart

which sort huge lists of numbers.

I will look into making these tests smaller or splitting them. (Let's track progress in the other issue.)


Suggestion: Section on pandoc

This issue has a Zulip conversation here.
In general, especially while working with multiple languages (Python users like ReST, everyone else likes markdown), it helps to be able to convert syntaxes on the fly.
It would be useful then, to introduce pandoc in this context.

Good suggestion (and sorry for following-up so late)! I use pandoc often. Always when I need to convert RST to MD or the other way round. I use it through containers: https://github.com/bast/pandoc
But at the minimum it deserves a mention.


Invalid table name

$ qhs -H "SELECT s||'s ' FROM t"
Invalid table name:
  fromList ["t"]
Probably a bug of qhs. Please submit a issue report.

Thanks for your report. This is surely a bug of qhs.


Ethernet connection

Hi there, I was having issues homebridge connecting to my LG video projector when it was connected over ethernet (once manually turned on, everything worked perfectly fine).
Is it because the magic packet works only over wifi ? I'm surprised, because the other LG home bridge plugin worked over ethernet the hall time (until quite recently)

It should not matter whether you use ethernet or wifi (only in that they have different mac addresses), you just have to make sure that the correct settings are enabled on your TV so that it will still listen to the magic packet even when turned off.


Inquire about the LOD related matters of IFC

Hello developer, I would like to inquire if there is a tool that can automatically grade IFC models without the need for format conversion. If no such tools are currently available, can we manually grade the IFC model directly? How to operate it specifically? Thank you.

Hi @jingyangking
We have officially released the new library components on September 20 2023. This library substitutes web-ifc-three and web-ifc-viewer. Both WIV and WIT will remain up, but they will be deprecated and won't be maintained any longer. You can find the new docs here.
All our efforts are going towards components now. The API is very similar, so I strongly suggest you make the leap and start using it. If you still face this issue with it, you can open an issue there and we'll take a look.


upgrade nebulous kubernetes clusters to 1.20

nebulous currently installs at a 1.17 which is almost end of life - this is the highest priority of the 1.5 release

I'd like to work on this.

thanks @bil9000, we actually discovered last night we'd prefer 1.20 in this next release, i'll adjust the title and consider this one claimed. appreciate your interest in contributing.
It's sometimes as straightforward as just upgrading the eks module version - but there can be complications on apps with the upgrades, it's a bit of a discovery operation. let us know on this issue or in the kubefirst-community slack if you have any questions along the way!
https://github.com/kubefirst/nebulous/blob/main/gitops/terraform/base/eks/main.tf#L122

Sounds great, happy to help!


Auto create .env on composer create

We know that everyone going to copy .env.example and create a .env so why not auto create this file.
This script will run only when someone use composer create command.

Works, thanks!


Requires go version > 1.7

Make a note somewhere that the package requires go version 1.7 or above.

related to #9.


New version: v0.3.2

Codecov Report
Base: 91.86% // Head: 90.69% // Decreases project coverage by -1.16% :warning:

Coverage data is based on head (fffe383) compared to base (511c248).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   91.86%   90.69%   -1.17%
==========================================
  Files           9        9
  Lines          86       86
==========================================
- Hits           79       78       -1
- Misses          7        8       +1

Impacted Files
Coverage Δ

src/util.jl
80.00% <0.00%> (-20.00%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Sprint: 44] XD-2761 fix kryo registration issue

This PR is for 1.1.x. Should be applied to the master as well.

PojoCodec does not register classes to Kryo inside ser/deser methods
An extension to shared server context is enabled. The context imports from classpath*:/META-INF/spring-xd/bus/ext/*.xml.  This mechanism enables bean definitions in MessageBusConfiguration (and other beans in the shared context technically) to be added/overriden.
codec.xml has been replaced by MessageBusConfiguration. This allows a KryoRegistrar implementation to be configured by the user if registration is necessary.
PojoCodec is configured with a KryoRegistrar constructor and no implementation OOTB so it registers
no classes by default. Two implementations are included, one backed by a List and the other a Map. Another implementation might be Properties based which opens up a range of possibilities, but is not included yet. This mechanism is internal to XD 1.1.x and we will revisit this in relation to other customization features for 1.2.

It is not necessary to register classes targeted for serialization, but it is offered as a performance optimization to reduce the size of the byte stream.  A simple way to register classes is to create a /META-INF/spring-xd/bus/ext directory in $XD_HOME/config and drop an XML file in there:
<beans ...>
   	<bean id="kryoRegistrar" class="org.springframework.xd.dirt.integration.bus.serializer.kryo.KryoClassListRegistrar">
			<constructor-arg>
				<util:list id="kryoRegisteredClasses">
					<value>org.springframework.xd.extensions.test.Foo</value>
					<value>org.springframework.xd.extensions.test.Bar</value>
				</util:list>
			</constructor-arg>
		</bean>
</beans>

The bean id is unimportant as is the name of the XML file. A Map backed version is also provided to allow the user to specify class IDs for each class. This is initially more effort but may give the user more
control. This also allows the user to implement alternate strategies if necessary.
This resource may also be packaged in a jar and dropped into xd/lib. Note that the referenced domain classes must also be on the XD class path (xd/lib) else the context will fail to initialize.
NOTE that the 2nd commit replaces codec.xml with @Configuration. This removed the need to override an existing bean definition to provide this feature. Spring uses a "last one wins" strategy so overriding bean definitions relies on a stable and known bean definition processing order. One disadvantage now is that it is apparently really difficult to override bean definitions defined in 'MessageBusConfiguration`. I spent some time and haven't successfully been able to override the codec itself, which is potentially a requirement. So it is not possible currently AFAICT. With XML it was trivial to do but relies on overriding existing beans, considered to be potentially unreliable.

PojoCodec supports only one KryoRegistrar instance. In our case Spring XD is a shared, multi-tenant environment to which we can deploy multiple projects. Each of them might want to register their own types without depending on other projects.
Have you considered adding a custom annotation or interface that would allow classes to define their own Kryo ID?

Re. One KryoRegistrar instance. I believe this is the way to go in order to allow validation that different projects don't provide conflicting registrations. One could even write an implementation to maintain registrations in an external data store. We need to see what the demand for the registration feature will be. Meanwhile, I prefer to leave this to the user. Also, we plan to revisit the whole user customization theme for 1.2, so this will likely be it for 1.1.x. Possibly the Map implementation may work better for you in the grand scheme of things.
We did consider the annotation idea but this has limited application if the domain types are part of an external/shared code base which I expect would be frequently the case. I agree it would be pretty slick but seems to me like a feature for Kryo itself (if it's not there already).

Squashed and merged into master as ae64c32feb4a6ea2e28f3179500a5d5917819d46 and into 1.1.x as 6f9a8108dd782798f6823df72fd2266de96794a1


[Feature Request] Please support :popper-append-to-body="false" prop for el-color-picker component

Existing Component
Yes
Component Name
el-color-picker
Description
Please support "popper-append-to-body" prop for el-color-picker component
While use el-color-picker inside el-select, since el-color-picker is appended to body the el-select popover closes when clicking the color picker

Adding CodePen FYR.
Please add support for popper-options as well, so that the popper can be configured, i.e placement, etc.
https://codepen.io/TapeshKumar/pen/PoGEJZr


adding set location

Adding set location to alter table.  It looks like SET is not required explicitly, but that may just be for Athena
Athena SET LOCATION -- https://docs.aws.amazon.com/athena/latest/ug/alter-table-set-location.html

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

27 of 31 (87.1%)  changed or added relevant lines in 4 files are covered.
93 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.01%) to 87.797%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser/mod.rs
10
11
90.91%

src/ast/mod.rs
9
12
75.0%

Files with Coverage Reduction
New Missed Lines
%

src/test_utils.rs
2
89.38%

src/parser/mod.rs
19
83.23%

src/ast/mod.rs
72
79.75%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
20095

Relevant Lines:
22888

💛  - Coveralls


[Unstable] Prompt users to enter the password of<EMAIL_ADDRESS>when trying to SSH into Web App

OS: Windows
Build Version: 20200310.1
Repro Steps:

Create a new Linux web app --> Deploy a project to this new web app.
Select "SSH into Web App" from the new web pp context menu.

Expect:
The App Service extension is supposed to enter it for the user.
Actual:
[Unstable] it will prompt to enter the password of<EMAIL_ADDRESS>
Enter "Docker!" manually:

We might have to increase the delay between entering in terminal commands

Closing as duplicate of https://github.com/microsoft/vscode-azureappservice/issues/932


Aetherize

Refactor major parts of code from Aether repo directly into CodeCombat. Vast majority of the work done by Rob.

Coverage remained the same at 57.382% when pulling f3c40fa0ba4047fcea4f6650b1374f9eb82b899a on aetherize into 1574e554f296eb117193f8479a650d98e8ecb7d1 on master.

Coverage remained the same at 57.382% when pulling d321a3672057e1433fe4942450ca8820dfbbf39d on aetherize into 1574e554f296eb117193f8479a650d98e8ecb7d1 on master.

Original reason for this work: make Aether information more available for translation work.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #361 (90a4718) into main (2974dfe) will increase coverage by 12.36%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #361       +/-   ##
===========================================
+ Coverage   83.33%   95.69%   +12.36%
===========================================
  Files           2        1        -1
  Lines         126      395      +269
  Branches       31       53       +22
===========================================
+ Hits          105      378      +273
+ Misses         21       17        -4

Impacted Files
Coverage Δ

src/index.ts
95.69% <100.00%> (+13.69%)
:arrow_up:

example/src/main.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630993c...90a4718. Read the comment docs.


Use cases for Livewire? Can it be used for SSR-rendered apps with Laravel

Thanks for this repo @calebporzio!
This isn't a bug or feature request, but more of a question after having seen all the videos at https://calebporzio.com/a-bunch-of-cool-new-things-in-laravel-livewire/ and after going through the quickstart guide (Which works wonderfully well, btw).

When is it appropriate to use Livewire over Vue? Obviously, Livewire makes multiple Ajax requests to the server, so it's heavy on the server.
For SSR-rendered apps using Laravel + Nuxt.js, where does / can Livewire fit in? Can Livewire replace Nuxt and something like Inertiajs?
Thoughts appreciated!

My Thoughts on this:
I think what makes Livewere different is that, you can use Laravel's helpers such as ( route(), trans() ..etc) as you always do in a traditional way. and you don't need to ever worry about JS as you used to.
For example: In Inertiajs or any SPA you need to convert your routes and languages files then you create an equivalent functions for route() and trans(). and you need to find a way to handle authorizations in JS .. and alot of other things.
Livewere makes you focus in your application, you don't need to worry about JS. Also you can test your application from E2E which is a mind blowing.

so it's heavy on the server

When you use Livewere that doesn't mean you handle everything using it. Animations and UI interactions better to be in Javascript.

A good rule of thumb is: any JavaScript components that rely on ajax for server communication, will be better off as Livewire components. There's lots of other good use cases, but this gives you a basic idea of where to start.

@rakk7 agreed and these points are largely good. I guess what follows is it would be really helpful to see en example Laravel app using Livewire that:

does SSR and (basic) Auth (using Livewire, not Laravel's make:auth). Auth is always painful - right now, using Nuxt (or even a Vue layer for SSR) requires one to write APs.
integrates / plays well with Vue, and relies on Vue for a (small) client or animation-heavy, js-only piece
Not sure what @calebporzio has in mind but if such an example app can be made available, it would easily demonstrate the benefits of Livewire over something like Nuxt (or even a Vue layer)->Laravel

Good points @connecteev, and thanks for weighing in @rakk7.
I plan to create something like that example app you're talking about in the future when development on the core settles down a little bit. It would be too annoying to have to maintain ATM. But hang in there!

@calebporzio thanks and that would be great...imagine a side-by-side like you did in your talk here: https://www.youtube.com/watch?v=uQO4Xh1gMpY
except in code with a real, functional set of examples. If you want to really increase livewire's adoption, think about this.
The main use-cases I can think of  / would make sense to me are:

SSR and how vue / js cant handle it easily
In what scenarios livewire is better than inertiajs
how and "Regular" ajax is painful or bad
When livewire is bad (and too much load on the server), like for example sending an ajax request with every keystroke / pure js-only animations etc

The more people can see the big picture and play with livewire in the real world, the easier it will be on adoption.


Some bug fixes coming out of Genie contextual work

Pull Request Test Coverage Report for Build 444

6 of 11 (54.55%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 82.19%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ast/api.js
5
10
50.0%

Totals

Change from base Build 443:
-0.05%

Covered Lines:
5732

Relevant Lines:
6795

💛  - Coveralls


nixos/extra-layouts: avoid all rebuilds

Motivation for this change
Just setting the XKB_CONFIG_ROOT should be enough, so we don't need to
rebuild the xserver, xkbcomp and other packages anymore.
However, the variable has to be passed explicitely to scripts running at
build time: in particular to xkbvalidate and xkb-console-keymap.
Things done

[x] Tested in xfce
[x] Tested in gnome
[x] Tested in virtual console (console.useXkbConfig)
[x] Built manual
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thank you for the review!

Good question. services.xserver.xkbDir sets the -xkbdir option of the xserver, but the environment variable should takes priority over that. Also, the variable is not tied to Xorg and should works for wayland compositors too.
I think I would try changing the implementation of xkbDir to set XKB_CONFIG_ROOT with mkDefault, so extraLayouts can override it. Then xkbvalidate should work with both options, since I've already patched it here.


Inquiry about Fine-Tuning Using Custom Code

Hi there,
I hope this message finds you well. I am currently exploring the process of fine-tuning models using my own codebase, and I was hoping to seek some guidance on this matter.
Could you please provide me with information on how I can effectively fine-tune models using my own codebase? Additionally, would it be possible for you to share any scripts or resources related to data preprocessing for this purpose?
I truly appreciate any assistance or insights you can provide on this matter. Thank you very much for your time and support.
Best regards
@loubnabnl

You can check this blog post for fine-tuning code models on personal codebases: https://huggingface.co/blog/personal-copilot
For data processing you can find the scripts we used at https://github.com/bigcode-project/bigcode-dataset/ and details in the StarCoder papers.


FIX Don't use call_user_func in __call()

These changes were made as a result of https://github.com/silverstripe/silverstripe-cms/pull/3034 - I took a look for any __call() implementations and these ones need updating.
These would cause problems if ViewLayerData hits them with a method that doesn't exist.
Issue

https://github.com/silverstripe/.github/issues/348

The inmemorycache CI run is unrelated


Refactor rootStore.state.config to dedicated module

What is the motivation for adding / enhancing this feature?

The rootStore.state.config.entities.attribute.includeFields kind of paths are all around the code. We should create a dedicated module ConfigManager (like RouteManager) to keep the config.
Note: The thing is that the config needs to be updated runtime
What are the acceptance criteria

the old pattern rootStore.state.config should still work for backward compatibility
all the instances in the core + theme of rootStore.state.config replaced by this new fancy module

Imho it shouldn't be a module. More like a core lib

Yes, core/lib

What would You say for sth like:
  import { currentConfig } from '@vue-storefront/core/lib/config'
  if (currentConfig().images.useExactUrlsNoProxy) {

instead of:
  import rootStore from '@vue-storefront/core/store'
  if (rootStore.state.config.images.useExactUrlsNoProxy) {

?

why currentConfig? imho it should be a single entity (config) and thats all. Also - why it's a function? It's not so good for performance to return such a big object each time

This is a function because we'll be taking the config from rootStore.state.config as it was done before. It's by purpose (to have the option to dynamically reload the config with the window.__INITIAL_STATE__) we just don't want to have the rootStore.state references all over the code. So the function is cool and the naming was like currentStoreView() we have defined in the multistore.ts

But we can easily modify plain JS objects too. What is a purpose of making this huge JSON reactive and part of VS state instead of having it in a separate module as an Object?

If the purpose  of this issue is just to make alias for current behavior it doesn't make sense at all. Having config in a Vuex is a terrible idea that is really bad for either runtime and loading performance. It's not even application state.

https://github.com/DivanteLtd/vue-storefront/pull/1800/files
We're using the state to dynamically reload the config if this mode is enabled. Not sure if it could anyway lower the performance - we do have much larger objects in state (say: product's list) :)

This doesn't answer my question why we are not using plain object for config instead of using Vuex state.

Filip, the dynamicReload is by default off (low-end devices) - moreover by using state filters (included in #1800) You can pass just the things You need to override with the state - not the full config. This is in fact optimal, as the second option for dynamicConfigReload would be to have separate request which really will block the page rendering as the config is crucial for any component or Vuex state to work and can't be lazy loaded.

So we can have a separate lib+it's own config object to keep it after: loading from the bundle (in case dynamicConfigReload = false) or getting it from the state (in case of dynamicConfigReload = true)

Anyway maybe it w'd be faster to discuss this f2f - we could just have 5min discussion on this on Monday's core planning :)


fix(Tabs): scroll doesn't hide as expected during horizontal resizing

Types of changes

[ ] New feature
[x] Bug fix
[ ] Enhancement
[ ] Documentation change
[ ] Coding style change
[ ] Component style change
[ ] Refactoring
[ ] Test cases
[ ] Continuous integration
[ ] Typescript definition change
[ ] Breaking change
[ ] Others

Background and context
Tabs 组件左右滚动按钮展示和消失的长度不一致，例如：当页面宽度 resize 至 1000px 的时候展示左右滚动条，而至少 resize 到 1060px 左右滚动条才会消失。

Before
After

Solution
扩大 ResizeObserver wrapper 包裹的范围，将 isScrollable 时出现的左侧按钮也包裹在内。

How is the change tested?

Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

Tabs
修复了 Tabs 组件左右滚动按钮展示和消失的长度不一致的问题
Fix the bug that Tabs scroll buttons don't hide as expected during horizontal resizing
close #812

Checklist:

[x] Test suite passes (npm run test)
[x] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[x] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

看了一下，这样会改变headerWrapperSize的值，导致滚动到最后节点的偏移量出问题。


Adding pthreads to gtest as a dependent library. This fixes undefined…

… symbols while using intel compilers
This pull request fixes undefined symbols on surface with the intel 16 compilers:
[  6%] Linking CXX executable ../../tests/blt_gtest_smoke
../../lib/libgtest.so: undefined reference to pthread_key_create' ../../lib/libgtest.so: undefined reference to pthread_getspecific'
../../lib/libgtest.so: undefined reference to pthread_key_delete' ../../lib/libgtest.so: undefined reference to pthread_setspecific'
nm libgtest.so | grep thread
w pthread_cancel
U pthread_getspecific
U pthread_key_create
U pthread_key_delete
U pthread_mutex_destroy@@GLIBC_2.2.5
U pthread_mutex_init@@GLIBC_2.2.5
U pthread_mutex_lock@@GLIBC_2.2.5
U pthread_mutex_unlock@@GLIBC_2.2.5
U pthread_self@@GLIBC_2.2.5
U pthread_setspecific

I think this may be a safer solution, adapted from my use of thread linking in civetweb for conduit:
if(UNIX AND NOT APPLE)
    find_package( Threads )
    set(gtest_extra_libs ${CMAKE_THREAD_LIBS_INIT})
endif()

What about intel compilers on osx? I don't have the compilers to test it on my machine. Perhaps just if Unix?

@mclarsen -- we can keep if UNIX and fix if an issue pops up
(the logic I pulled that from was also guarding librt, which doesn't work on osx)

Hmm. CMake 3.3 didn't find threads.

Looking for include file pthread.h
CMake Error at /home/travis/build/LLNL/tpls/cmake/share/cmake-3.3/Modules/CheckIncludeFiles.cmake:79 (try_compile):
Unknown extension ".c" for file
 /home/travis/build/LLNL/travis-debug-build/CMakeFiles/CMakeTmp/CheckIncludeFiles.c

You need to have C as a project language when looking for threads. We had to do this in RAJA.

So we need to add C in addition to CXX in the project command in the test project:
https://github.com/LLNL/blt/blob/master/cmake/blt-test/CMakeLists.txt

The problem is that anyone using BLT and with ENABLE_TESTING would also need to have C enabled.

Added #71, which includes an option to enable / disable gtest and fruit.
If we guard the check for pthreads w/ ENABLE_GTEST,
By disabling gtest, allows fortran folks to use BLT with out requiring their cmake project includes C

@mclarsen, i merged #71 -- if you re-work you changes from master (really just shifting down your current logic into the ENABLE_GTEST block) -- we should be able to merge this PR.
(Not sure if I can checkout your fork to try to make the changes)

@cyrush , I think this is good to go.

@davidbeckingsale  FYI:
since @mclarsen's changes were on a fork, the appveyor reporting for the branch test was hung up. This was also the problem with @gonsie's pr #87.
I had to change the appveyor branch check to not be required to avoid this.
The hint was here:
http://help.appveyor.com/discussions/problems/3612-github-showing-multiple-checks#comment_38488858


Configurable throttle/debounce on resize listener

Accepts a "throttle" config attribute (default 25ms) with v0.2.0+


PhantomJS crash during functional tests

PhantomJS is crashing every time the functional tests are run in my local development environment which is the Ghost-Vagrant VM, node 0.10.30, and phantomjs 1.9.7.  I've seen one report of it also crashing in a Travis instance, so it's not as frequent in that environment, but it's still an issue.

The above is an example of the crash, although it doesn't always occur in the same place.
I've narrowed it down to coming in from #3954, specifically these two lines where listeners are attached to MediaQueryList objects:
https://github.com/TryGhost/Ghost/blob/master/core/client/views/application.js#L24
https://github.com/TryGhost/Ghost/blob/master/core/client/views/application.js#L52

Is this still crashing for people locally?

Going to close this one for now as not heard of it happening recently.


enable travis ci

@xscript,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9fdd2f9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   63.95%
=========================================
  Files             ?       18
  Lines             ?      430
  Branches          ?       67
=========================================
  Hits              ?      275
  Misses            ?      135
  Partials          ?       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdd2f9...2baa289. Read the comment docs.


Project dependencies transiently refer to System.Net.Http <= v4.3.0 that has high severity security vulnerability

Reqnroll Version
2.0.3
Which test runner are you using?
MSTest
Test Runner Version Number
n/a
.NET Implementation
.NET 8.0
Test Execution Method
Other – PLEASE SPECIFY
Content of reqnroll.json configuration file
No response
Issue Description
The projects implicitly depend on System.Net.Http v4.3.0.
One detected dependency chanin is through Moq v4.17.2 -> Castle.Core v4.4.1 -> NETStandard.Library v1.6.1 -> System.Net.Http v4.3.0
Steps to Reproduce
perform project security scan
Link to Repro Project
No response

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

Hi. The VSIX package for Visual Studio is flagging the same issues where the same System package is being used and being raised as a security vulnerability

@sjxckson Thx. I will create a separate issue for the VSIX.
Is the tool you have used to check is publicly available? I.e. can I rerun the check before releasing a new version?

@sjxckson Thx. I will create a separate issue for the VSIX.
Is the tool you have used to check is publicly available? I.e. can I rerun the check before releasing a new version?

I created an issue a few minutes ago. Im not sure it is publicy available as we use it in-house. I can ask the question though.


Interpreting negative space

A first step towards #248. Not ready to merge yet, but I wanted to open for feedback on how to use this.
This PR introduces a way to start at a road or intersection, then find a small cycle starting and ending on it, and generate the polygon that (approximately) fills the negative space between everything. Based on the types of roads and intersections in that cycle, the "block" gets classified as a few different cases.

The green polygon represents the area between a road and a separately mapped sidewalk. Assuming the road width and sidewalk placement is roughly accurate, then this could have a few interpretations. Sometimes it's a wide pavement, or the planter strip (or "verge"?) often found in suburbia:

The purple polygon is the space between dual carriageways. In OSM, a road is split into a dual carriageway when there's some kind of phyical separation between the two sides, not just paint. We could try and render something here, maybe.
There are more cases I'll add, like the space between a cycleway and road (hopefully some kind of separation for the cycleway) or the space between cycleway and sidewalk (maybe separation, or maybe just a little curb).
For this first step, I think I just want to settle for finding the polygons, classifying them, and rendering in an off-by-default layer for debugging. I'll first work on finding all of the blocks (problems handling both sides of a road and dealing with dead-ends) and improving the classification.
But more ideas in #248 could come later. We could also change the block-tracing logic to only follow sidewalks and crossings, and wind up with a nice big junction shape around all of something like this:

In that case, the big polygon is probably less useful. Seeing all of the Intersections and Roads inside is useful, because then we can reason about vehicle stop lines (behind the crosswalks, probably) and generate high-level movements through the whole junction.
Or similarly, we could try to group all of the parallel-ish OSM ways and have a higher-level representation of all of the street features from right-to-left, no matter how they're split up in OSM. Answering if https://www.openstreetmap.org/way/422264711 has a sidewalk is not straightforward, but with this kind of grouping, it would work.

Alright, I got the block-finder to pretty much handle everything except dead-ends / edge of the map. Added a few more categories in the classification, but each of them still needs some work. And improved the debugging UI a bit. Going to merge and take smaller steps.


consumer group question

I am using the consumer group and have a wired random problem
let's how I use , and I have 3 broker, and use two process to run 2 consumer, topic has 100 partitions
client_consumer = Kafka.new(seed_brokers: ['localhost:9092', 'localhost:9093', 'localhost:9094'])

consumer = client_consumer.consumer(group_id: "group_tet", offset_commit_interval: 0])
consumer.subscribe('test_topic', default_offset: :latest)}
consumer.each_message do |message|
  do_jobs(message)
end

but sometime the message will lost, and just lost some partition message
see the log like this
Resolving offset -1 for test_topic/0...
Offset for test_topic/0 is 30
and after I produce more message to partition 0, still no message comes out to each_message
but the log offset will increase like this, and keep increase
Resolving offset -1 for test_topic/0...
Offset for test_topic/0 is 31
so I think is there some issue here?
https://github.com/zendesk/ruby-kafka/blob/master/lib/kafka/fetch_operation.rb#L101
when got the offset here
resolved_offset = response.offset_for(topic, partition) topics[topic][partition][:fetch_offset] = resolved_offset || 0
is it already the latest offset?, use it to do following step will return nothing to each_message
the difficult of this problem is I can't find the consistent reproduce method....
thanks for help

Try setting offset_commit_interval to 1 rather than 0.

Also: Resolving offset-1for test_topic/0... probably means that the offset for that partition has not been committed at all, or that the commit has expired. Do you stop the jobs and restart them much later? The client uses the default commit retention time configured in the broker, so after a while the commit will be removed.

thanks for your reply~

I try to set offset_commit_interval  to 1 before, but more than 1 message will comes in 1s from different partitions and only the first message will commit and other message from different partition wii not commit. Therefore I set to 0.

for this Resolving offset -1 for test_topic/0.... I think it's ok to get -1 here
because the following will work and get the offset for this topic, partition
https://github.com/zendesk/ruby-kafka/blob/master/lib/kafka/fetch_operation.rb#L124
log like this Offset for test_topic/0 is 30
but the problem might be, if the offset already 30, use 30 to consume this partition will not receive any new message, but actually consumer didn't consume offset 30 or 29 yet.

thanks

I'm not quite sure I understand the problem here. If do_jobs() in your example works synchronously you should not see any message loss. Are you using threads to do processing?

it's not related to the do_jobs(), even I put logs here, it didn't show up when issue happened
consumer.each_message do |message|
  puts "topic=#{message.topic}, partition=#{message.partition}, offset=#{message.offset}"
  do_jobs(message)
end

the problem is the consumer can't receive message from some partitions
this normal partition
Fetching batch from test_topic/2 starting at offset 3
this is abnormal
Fetching batch from test_topic/14 starting at offset latest
it's that more clear@@?I'm sorry that I still not found the reproduce steps
all I know is start the consumer and stay for 1 day, it might happen

sorry, more clear information now,
client_consumer = Kafka.new(seed_brokers: ['localhost:9092', 'localhost:9093', 'localhost:9094'])

consumer = client_consumer.consumer(group_id: "group_tet", offset_commit_interval: 0])
consumer.subscribe('test_topic_1', default_offset: :latest)
consumer.subscribe('test_topic_2', default_offset: :latest)
consumer.subscribe('test_topic_3', default_offset: :latest)
consumer.each_message do |message|
  do_jobs(message)
end

we subscribe 3 topic in one consumer,
when I only subscribe to 1 topic, it looks fine (I'm not sure , because the issue is random)
I saw the code here, looks like the offset manager is same one
https://github.com/zendesk/ruby-kafka/blob/master/lib/kafka/consumer.rb#L75
so...could we subscribe to 3 topic in one consumer?
thanks

First of all, offset_commit_interval: 0 is simply wrong – that's not how you want to trigger offset commits. If you want offsets committed after every single message processing, use offset_commit_threshold: 1.

Fetching batch from test_topic/14 starting at offset latest

This simply means that no offsets have been committed for that partition yet, so the client will wait for messages to appear at the end of the partition. Note that since you set default_offset: :latest, you will have message loss by design. The client will wait for new messages to appear in the partitions but will not look at previous messages. You should consider using :earliest instead, which is the default.

 What's your partitioning key?

yes I'm sure the producer successfully add message into different partitions
I using simple consumer to make sure that
and I change to default_offset: :earliest and the issue disappear
but the different between :latest and earliest only is the first time consuming position
I still can't understand why using :latest, the messages from some partition can't be consumed but other partition is fine
thanks

When using :latest, only messages written to the partition after the consumer starts will be consumed. It's not enough that there are already messages in the partition.

If you can provide a full script that both produces and consumes and exhibits this problem, then I would be able to debug it.

here is the reproduce steps

clean all data in kafka broker and zookeeper
restart server and create 3 topics(replication factor 2, partition 2)
start consumer

client_consumer = Kafka.new(seed_brokers: ['localhost:9092', 'localhost:9093', 'localhost:9094'])

consumer = client_consumer.consumer(group_id: "group_tet", offset_commit_threshold: 0])
consumer.subscribe('test_topic_1', default_offset: :latest)}
consumer.subscribe('test_topic_2', default_offset: :latest)}
consumer.subscribe('test_topic_3', default_offset: :latest)}
consumer.each_message do |message|
  do_jobs(message)
end

produce message to each partition periodically
producer = kafka.async_producer(delivery_threshold: 10, delivery_interval: 10)
producer.produce(data, topic: topic, partition: partition)

thanks

Okay, I think I've found the issue – there's a race condition when the consumer subscribes to the latest messages. If no messages arrive in the max_wait_time window (which can be passed to #each_consumer) the consumer will try another fetch, but since it has no committed offsets for the partitions it will try to resolve the :latest offset again, which might mean skipping some messages that have arrived in the interim.
I think the correct solution would be to resolve offsets for all partitions at consumer startup.

thanks for your help
I will try after you fix, thanks

@tslcjames can you verify that #230 fixes your problem?

@dasch  thanks for your fix
I Use this version to test
gem 'ruby-kafka', git: 'https://github.com/zendesk/ruby-kafka.git', ref: 'ecdf17e37ea296bd8614cbd1a909ef6ad8c94e92'
when I delete all data in kafka server and restart broker and consumer
The exception Kafka::OffsetOutOfRange will happen
after I create one message to each partition, the situation disappear
and the issue I mentioned before also fixed, consumer could receive all message from each partition
I saw the log when the consumer start before any message produce
Fetching batch from test-topic-1/1 starting at offset 1
Fetching batch from test-topic-1/0 starting at offset 1
Fetching batch from test-topic-2/1 starting at offset 1
Fetching batch from test-topic-2/0 starting at offset 1
Fetching batch from test-topic-3/1 starting at offset 1
Fetching batch from test-topic-3/0 starting at offset 1

looks like the offset is wrong? there is no message in any topic now, but the offset already is 1
thanks for your help

Hmm, let me check up on that.

@tslcjames can you try with the latest HEAD of the branch again?

@dasch yes! it look nice! now the offset is correct and all partition message received
gem 'ruby-kafka', git: 'https://github.com/zendesk/ruby-kafka.git', ref: '8b53cf9935020e4eb234581eca8b09f053055fea'
the other question, as I mentioned before
whether there is same problem in here resolve_offsets?
https://github.com/zendesk/ruby-kafka/blob/master/lib/kafka/fetch_operation.rb#L101
thanks

Awesome! I'll merge that PR, then.
I don't think the problem applies to the fetch operation – Kafka's offset handling is a bit weird, here. Basically, when fetching you provide the starting offset of the fetch, so when tailing the topic you specify the offset of the next message to be written. The problem with the PR was that I tried to commit the next offset rather than the current one.

@dasch
I think I forget to test earliest case, this modification need to consider earliest also
https://github.com/zendesk/ruby-kafka/blob/51c7b83b327089aa9fd9bb488340176c2bfe608d/lib/kafka/cluster.rb#L136
thanks

I thought that would just work, since resolving earliest should return the actual offset of the earliest message. Have you observed a problem?

Yes, same offset out of range situation when first start, have you seen that before?

Hmm. It's probably because those offsets don't exist in the partitions.

@tslcjames can you test out https://github.com/zendesk/ruby-kafka/pull/231 for me?

@dasch I tested with :latest and :earliest , it ok with this version
3b27512a025d5559f040d6c389dddfddac479515
the other question, I saw sometimes the offset will be -1 when get the committed offset
even though I didn't start a new consumer group,
https://github.com/zendesk/ruby-kafka/blob/master/lib/kafka/offset_manager.rb#L32
what's the other scenario when saw -1 here?
thanks

If the offset list API returns -1 it means no offset has been committed, or that the offset commit has expired. If your consumer group is inactive for a long period of time the commits may expire.

I see, I found it's the offsets.retention.minutes too low, so the offset will be clear
thanks

It's possible to override that default in the client, but I'm not exposing it as an option yet. I've added #233 to track the issue.


pdf.js and web/viewer.js pass/open url outside webroot

I am experimenting with the pdf.js examples, and in particular the viewer.html/viewer.js. I am trying to access a URL outside of the webroot. My PHP installation has access to a specific folder outside where I store pdf files. In PHP I stream these files to the browser for download, which works fine. However, I would like to also stream the file to the viewer directly. Is that possible?
So, for example, my URL would be /web/viewer.html?file=/12345.pdf for a file that is accessible to the web browser.
However, if I want to stream this from outside the root, the URL may look like this: /web/viewer.html?file=fetch.php?id=12345
Any idea how I should go about this, as the viewer seems to fetch the filename directly. I also want to make sure that the URL remains obscured, so probably encoding the pdf (multiple pages) would presumably also not work.
Thanks

My PHP installation has access to a specific folder outside where I store pdf files.

Unfortunately we cannot really provide PHP-specific help/support here, since this is a JavaScript project after all.

However, if I want to stream this from outside the root, the URL may look like this: /web/viewer.html?file=fetch.php?id=12345

That'd most likely require modification of the viewer source-code, since nothing like that is (or will be) supported here; please also note http://mozilla.github.io/pdf.js/getting_started/#introduction (emphasis mine):

The viewer is built on the display layer and is the UI for PDF viewer in Firefox and the other browser extensions within the project. It can be a good starting point for building your own viewer. However, we do ask if you plan to embed the viewer in your own site, that it not just be an unmodified version. Please re-skin it or build upon it.

Also, when opening an issue, please provide all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md such that the issue becomes easily actionable.
Finally, please see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


Updating CODEOWNERS for 1espt config

Updating CODEOWNERS for 1espt config
Updating CODEOWNERS for 1espt config

Closing as the 1espt auto baseline config directory does not exist yet.


How to generate a continuous mouth-to-audio matching video

hi，First thank you for sharing，I have encountered problems when running this project.
I took a piece of audio and a sample image as input and generated a series of mouth-shaped changes images by running the test_all.py file. I found that by simply splicing these images and audio, I couldn't get a video with a mouth-to-sound match. How do you combine these images and audio into a video with great mouth and audio matching or can you only use video and audio as input to get a mouth-and-audio-matched video?

Actually I generate the slient video first in 25fps, and attach the audio to it in commercial software where the unmatched part can be removed automatically.

Hi, actually I generate the silent video first in 25fps and attach the audio to it in commercial software where the unmatched part can be removed automatically.

@Hangz-nju-cuhk what is the name of the commercial software? Do you have a link that you could share?
Also, I am having trouble downloading the LRW dataset. It is asking me to sign in before I download it, and I can't seem to find a sign-up page where I can set-up an account and the credentials I need to sign in. How can I fix this problem? Is there an easier way to download the dataset?


Cluster validation is not executed after host is removed from node list while provisioning cluster

Version: master 5/31
Steps to reproduce:

Create custom cluster
Add node with etcd role (cluster will wait for controlplane node)
Add node with controlplane role

Results:
When the connection to the controlplane node, can't be made, it's being removed from the node lists and cluster is not validated anymore (is there still an etcd and controlplane node when provisioning). This makes a partly provisioned cluster, and when the back-off is finished and provisioning starts again, the port check fails because components are running already.
2018/05/31 18:56:19 [INFO] Handling backend connection request [m-9974157a7e67]
2018/05/31 18:56:30 [INFO] Provisioning cluster [c-d7dlh]
2018/05/31 18:56:30 [INFO] Creating cluster [c-d7dlh]
2018/05/31 18:56:30 [INFO] cluster [c-d7dlh] provisioning: Building Kubernetes cluster
2018/05/31 18:56:30 [INFO] cluster [c-d7dlh] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2018/05/31 18:56:30 [INFO] cluster [c-d7dlh] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2018/05/31 18:56:30 [ERROR] cluster [c-d7dlh] provisioning: Failed to set up SSH tunneling for host [<IP_ADDRESS>]: Can't establish dialer connection: can not build dialer to c-d7dlh:m-1bb39e1ae792
2018/05/31 18:56:30 [ERROR] cluster [c-d7dlh] provisioning: Removing host [<IP_ADDRESS>] from node lists
2018/05/31 18:56:30 [INFO] cluster [c-d7dlh] provisioning: [network] Deploying port listener containers
2018/05/31 18:56:30 [INFO] cluster [c-d7dlh] provisioning: [network] Pulling image [rancher/rke-tools:v0.1.8] on host [<IP_ADDRESS>]
2018/05/31 18:56:37 [INFO] cluster [c-d7dlh] provisioning: [network] Successfully pulled image [rancher/rke-tools:v0.1.8] on host [<IP_ADDRESS>]
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [network] Successfully started [rke-etcd-port-listener] container on host [<IP_ADDRESS>]
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [network] Port listener containers deployed successfully
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [network] Running control plane -> etcd port checks
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [network] Running control plane -> worker port checks
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [network] Running workers -> control plane port checks
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [network] Skipping kubeapi port check
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [network] Removing port listener containers
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [remove/rke-etcd-port-listener] Successfully removed container on host [<IP_ADDRESS>]
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [network] Port listener containers removed successfully
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [certificates] Attempting to recover certificates from backup on [etcd,controlPlane] hosts
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [certificates] Successfully started [cert-fetcher] container on host [<IP_ADDRESS>]
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [certificates] No Certificate backup found on [etcd,controlPlane] hosts
2018/05/31 18:56:38 [INFO] cluster [c-d7dlh] provisioning: [certificates] Generating CA kubernetes certificates
2018/05/31 18:56:39 [INFO] cluster [c-d7dlh] provisioning: [certificates] Generating Kubernetes API server certificates
2018/05/31 18:56:39 [INFO] cluster [c-d7dlh] provisioning: [certificates] Generating Kube Controller certificates
2018/05/31 18:56:40 [INFO] cluster [c-d7dlh] provisioning: [certificates] Generating Kube Scheduler certificates
2018/05/31 18:56:40 [INFO] cluster [c-d7dlh] provisioning: [certificates] Generating Kube Proxy certificates
2018/05/31 18:56:40 [INFO] Handling backend connection request [m-1bb39e1ae792]
2018/05/31 18:56:40 [INFO] cluster [c-d7dlh] provisioning: [certificates] Generating Node certificate
2018/05/31 18:56:41 [INFO] cluster [c-d7dlh] provisioning: [certificates] Generating admin certificates and kubeconfig
2018/05/31 18:56:41 [INFO] cluster [c-d7dlh] provisioning: [certificates] Generating etcd-<IP_ADDRESS> certificate and key
2018/05/31 18:56:41 [INFO] cluster [c-d7dlh] provisioning: [certificates] Temporarily saving certs to [etcd,controlPlane] hosts
2018/05/31 18:56:47 [INFO] cluster [c-d7dlh] provisioning: [certificates] Saved certs to [etcd,controlPlane] hosts
2018/05/31 18:56:47 [INFO] cluster [c-d7dlh] provisioning: [reconcile] Reconciling cluster state
2018/05/31 18:56:47 [INFO] cluster [c-d7dlh] provisioning: [reconcile] This is newly generated cluster
2018/05/31 18:56:47 [INFO] cluster [c-d7dlh] provisioning: [certificates] Deploying kubernetes certificates to Cluster nodes
2018/05/31 18:56:52 [INFO] cluster [c-d7dlh] provisioning: [certificates] Successfully deployed kubernetes certificates to Cluster nodes
2018/05/31 18:56:52 [INFO] cluster [c-d7dlh] provisioning: Pre-pulling kubernetes images
2018/05/31 18:56:52 [INFO] cluster [c-d7dlh] provisioning: [pre-deploy] Pulling image [rancher/hyperkube:v1.10.1-rancher2] on host [<IP_ADDRESS>]
2018/05/31 18:57:08 [INFO] Handling backend connection request [m-522b30a72bc5]
2018/05/31 18:57:32 [INFO] cluster [c-d7dlh] provisioning: [pre-deploy] Successfully pulled image [rancher/hyperkube:v1.10.1-rancher2] on host [<IP_ADDRESS>]
2018/05/31 18:57:32 [INFO] cluster [c-d7dlh] provisioning: Kubernetes images pulled successfully
2018/05/31 18:57:32 [INFO] cluster [c-d7dlh] provisioning: [etcd] Building up etcd plane..
2018/05/31 18:57:32 [INFO] cluster [c-d7dlh] provisioning: [etcd] Pulling image [rancher/coreos-etcd:v3.1.12] on host [<IP_ADDRESS>]
2018/05/31 18:57:35 [INFO] cluster [c-d7dlh] provisioning: [etcd] Successfully pulled image [rancher/coreos-etcd:v3.1.12] on host [<IP_ADDRESS>]
2018/05/31 18:57:35 [INFO] cluster [c-d7dlh] provisioning: [etcd] Successfully started [etcd] container on host [<IP_ADDRESS>]
2018/05/31 18:57:35 [INFO] cluster [c-d7dlh] provisioning: [etcd] Successfully started [rke-log-linker] container on host [<IP_ADDRESS>]
2018/05/31 18:57:35 [INFO] cluster [c-d7dlh] provisioning: [remove/rke-log-linker] Successfully removed container on host [<IP_ADDRESS>]
2018/05/31 18:57:35 [INFO] cluster [c-d7dlh] provisioning: [etcd] Successfully started etcd plane..
2018/05/31 18:57:35 [INFO] cluster [c-d7dlh] provisioning: [controlplane] Building up Controller Plane..
2018/05/31 18:57:35 [INFO] cluster [c-d7dlh] provisioning: [controlplane] Successfully started Controller Plane..
2018/05/31 18:57:35 [INFO] cluster [c-d7dlh] provisioning: [worker] Building up Worker Plane..
2018/05/31 18:57:36 [INFO] cluster [c-d7dlh] provisioning: [worker] Successfully started [nginx-proxy] container on host [<IP_ADDRESS>]
2018/05/31 18:57:36 [INFO] cluster [c-d7dlh] provisioning: [worker] Successfully started [rke-log-linker] container on host [<IP_ADDRESS>]
2018/05/31 18:57:36 [INFO] cluster [c-d7dlh] provisioning: [remove/rke-log-linker] Successfully removed container on host [<IP_ADDRESS>]
2018/05/31 18:57:37 [INFO] cluster [c-d7dlh] provisioning: [worker] Successfully started [kubelet] container on host [<IP_ADDRESS>]
2018/05/31 18:57:37 [INFO] cluster [c-d7dlh] provisioning: [healthcheck] Start Healthcheck on service [kubelet] on host [<IP_ADDRESS>]
2018/05/31 18:57:42 [INFO] cluster [c-d7dlh] provisioning: [healthcheck] service [kubelet] on host [<IP_ADDRESS>] is healthy
2018/05/31 18:57:43 [INFO] cluster [c-d7dlh] provisioning: [worker] Successfully started [rke-log-linker] container on host [<IP_ADDRESS>]
2018/05/31 18:57:43 [INFO] cluster [c-d7dlh] provisioning: [remove/rke-log-linker] Successfully removed container on host [<IP_ADDRESS>]
2018/05/31 18:57:43 [INFO] cluster [c-d7dlh] provisioning: [worker] Successfully started [kube-proxy] container on host [<IP_ADDRESS>]
2018/05/31 18:57:43 [INFO] cluster [c-d7dlh] provisioning: [healthcheck] Start Healthcheck on service [kube-proxy] on host [<IP_ADDRESS>
2018/05/31 18:57:48 [INFO] cluster [c-d7dlh] provisioning: [healthcheck] service [kube-proxy] on host [<IP_ADDRESS>] is healthy
2018/05/31 18:57:49 [INFO] cluster [c-d7dlh] provisioning: [worker] Successfully started [rke-log-linker] container on host [<IP_ADDRESS>]
2018/05/31 18:57:49 [INFO] cluster [c-d7dlh] provisioning: [remove/rke-log-linker] Successfully removed container on host [<IP_ADDRESS>]
2018/05/31 18:57:49 [INFO] cluster [c-d7dlh] provisioning: [worker] Successfully started Worker Plane..
2018/05/31 18:57:49 [ERROR] cluster [c-d7dlh] provisioning: Provisioning incomplete, host(s) [<IP_ADDRESS>] skipped because they could not be contacted
2018/05/31 18:57:49 [INFO] Provisioning cluster [c-d7dlh]
2018/05/31 18:57:49 [INFO] Creating cluster [c-d7dlh]
2018/05/31 18:57:49 [ERROR] Cluster c-d7dlh previously failed to create
2018/05/31 18:57:49 [INFO] cluster [c-d7dlh] provisioning: Building Kubernetes cluster
2018/05/31 18:57:49 [INFO] cluster [c-d7dlh] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2018/05/31 18:57:49 [INFO] cluster [c-d7dlh] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2018/05/31 18:57:49 [INFO] cluster [c-d7dlh] provisioning: [network] Deploying port listener containers
2018/05/31 18:57:49 [INFO] cluster [c-d7dlh] provisioning: [network] Pulling image [rancher/rke-tools:v0.1.8] on host [<IP_ADDRESS>]
2018/05/31 18:57:56 [INFO] cluster [c-d7dlh] provisioning: [network] Successfully pulled image [rancher/rke-tools:v0.1.8] on host [<IP_ADDRESS>]
2018/05/31 18:57:56 [INFO] cluster [c-d7dlh] provisioning: [network] Successfully started [rke-cp-port-listener] container on host [<IP_ADDRESS>]
2018/05/31 18:57:56 [INFO] cluster [c-d7dlh] provisioning: [network] Port listener containers deployed successfully
2018/05/31 18:57:56 [INFO] cluster [c-d7dlh] provisioning: [network] Running control plane -> etcd port checks
2018/05/31 18:57:56 [INFO] cluster [c-d7dlh] provisioning: [network] Successfully started [rke-port-checker] container on host [<IP_ADDRESS>]
2018/05/31 18:58:01 [ERROR] cluster [c-d7dlh] provisioning: [network] Port check for ports: [<IP_ADDRESS>:2380, <IP_ADDRESS>:2379] failed on host: [<IP_ADDRESS>]

Why do you all keep kicking the can down the road on this one? Totally understand the need to triage defects and ensure the right ones get fixed first...but it is getting little frustrating.

@superseb We allow provisioning a partial cluster, so in rke cli, user still can provision a cluster with only etcd nodes, and can add controlplane nodes later, this shouldn't affect the network port check.
I tested running rke on just:
nodes:
  - address: x.x.x.x
    user: ubuntu
    role:
    - etcd

and after rke succeed i added another node:
nodes:
  - address: x.x.x.x
    user: ubuntu
    role:
    - etcd
  - address: y.y.y.y
    user: ubuntu
    role:
    - etcd
    - controlplane
    - worker

This looks like a networking problem between the nodes, can you try to reproduce again because i can't reproduce on my side

Unable to reproduce this in current master.


Add move to different list functionality

Description
Previous PRs
https://github.com/alphagov/collections-publisher/pull/1595 - built the functionality for adding, editing, reordering and deleting lists
https://github.com/alphagov/collections-publisher/pull/1601 - added the list show page and ability to add new list items to a list.
https://github.com/alphagov/collections-publisher/pull/1609 - reorder list item functionality
https://github.com/alphagov/collections-publisher/pull/1610 - Deleting a list item
The focus of this PR is adding the ability for a user to move a list item to another list.
Changes
Adds a move link page

Guidance for review
Per commit will definitely be easiest. Probs worth giving the designs/last pr a glance if you're not familiar with the card.
Guidance on the publishing components used in the frontend can be found here https://components.publishing.service.gov.uk/component-guide/
Trello card
https://trello.com/c/9VoxrVPi/413-rebuild-curate-lists-page-on-collections-publisher
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Have actioned. Thanks foe the review!


run creat_pointcloud.py

Hi author:
I faced the following problem when running creat_pointcloud.py.
Problem:
RuntimeError: The NVIDIA driver on your system is too old.
Environment on my computer:
Ubuntu 16.04 LTS, GEFORCE RTX 2060, CUDA 10.1, NVIDIA driver: 430.64.
So, Would you please tell me the required environment config?
Expecting for your reply.

Hi,
thank you for being interested in this paper!
Could you please let me know how you set up the python environment?
Did you use the provided environment.yml file?
Best,
Felix


Changed labels to popups

#4
I changed the labels to a popup that appears when you click the marker, since that seemed to work better for clicking on the group URL.

So pretty! Thank you very much.


CommunityToolkit 8 + Tunnel Effect

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update config.py

These changes are for a project I'm doing for school that uses a different LED strip and Microphone

@XeroMetal - if you need to update the configs for your project, you can create a fork (looks like you already did this), make modifications there, and then pull it into your Pi. You can keep up to date with this project with pull requests into your own repo. You can also clone this repo and make changes locally.
I'll close this request without merging because it would be better to keep the configs as generic as possible. Thanks!


Universal wrap function

#43 and #33
created a function to let any sprite wrap.
Added it in .update for; Asteroid, PlayerShot and Player.
Can be considered to be added to UFOShot.

can't merge... Are you sure its approved?


fix: Respect --locked flag

When using --rust-version, the lockfile can be blown away. While that is a problem in of its own,
this focuses on an incremental step of not blowing it away if --locked is used.
Some points that were unclear in implementation

Whether --locked should show up in --help
Where to put in --help (cargo puts it among the manifest options)
Ordering of everything (seems struct declaration and initialization is not kept in sync

This is part of #234

Thanks!

Whether --locked should show up in --help
Where to put in --help (cargo puts it among the manifest options)

We also show some of the Cargo options in help, such as manifest-path, so I think this PR is fine as it is. That said, the current one is not that consistent, so ideally we might want to show only cargo-hack-specific flags or other Cargo flags as well.

Ordering of everything (seems struct declaration and initialization is not kept in sync

I think clippy has a lint for this, but they don't seem to be complaining...?
Anyway, I agree that it is easier to understand if they are in definition order, unless there are value dependencies that cannot be reordered.

How to test as this requires the registry and I didn't see precedence for that

I have not tested it, but the following might work:

Create a test crate that depends on easytime (that the latest version cannot be compiled with the old rustc) with the normal easytime = "0.2" requirements.
https://github.com/taiki-e/cargo-hack/blob/6350a4950ab5aec7cbe0e24d8259edc37f5043cb/tests/fixtures/namespaced_features/Cargo.toml#L11-L12
Downgrade the easytime version to 0.2.5 using cargo update (and commit its lockfile).
Set MSRV of that test crate to pre-1.58.
Run cargo-hack on that test crate with --rust-version or --version-range.

I think clippy has a lint for this, but they don't seem to be complaining...?
Anyway, I agree that it is easier to understand if they are in definition order, unless there are value dependencies that cannot be reordered.

Looks to default to allow.
https://rust-lang.github.io/rust-clippy/master/index.html#/inconsistent_struct_constructor

I have not tested it, but the following might work:

More so I meant I hadn't seen registry packages used and they can get messy (more chance of network disruptions, changes from new packages being published, etc).
If you're fine with it, I can add it.

Looks to default to allow.
https://rust-lang.github.io/rust-clippy/master/index.html#/inconsistent_struct_constructor

Hmm. It is pedantic lint, so it should already be set to warn.
https://github.com/taiki-e/cargo-hack/blob/6350a4950ab5aec7cbe0e24d8259edc37f5043cb/Cargo.toml#L62

More so I meant I hadn't seen registry packages used and they can get messy (more chance of network disruptions, changes from new packages being published, etc).

Thanks for the clarification. As for the former, I think it would be fine. Even if it is very bad it can be handled using flaky_test crate or similar. As for the latter, we want to test if it is respected by specifying an older version, so we don't have to worry about what happens with the newer version.

If you're fine with it, I can add it.

That would be great!

We also show some of the Cargo options in help, such as manifest-path, so I think this PR is fine as it is. That said, the current one is not that consistent, so ideally we might want to show only cargo-hack-specific flags or other Cargo flags as well.

It wasn't too clear to me if there is something I need to do in response to this.  You said the current one isn't consistent.  I tried to make it consistent (and my latest force-push makes it more consistent).  Is there something more I should be doing?  Or is this only with the inconsistency on when cargo flags are shown more generally and separate?

Published in 0.6.20.

Thanks!
Not seeing the job that is supposed to update the manifest for install-action (e.g. taiki-e/install-action#374).  Where can I track the status of that?

Not seeing the job that is supposed to update the manifest for install-action (e.g. taiki-e/install-action#374). Where can I track the status of that?

It is usually checked automatically every 3 hours (last check was 2 hours ago). It can also be triggered manually, I just triggered it manually now.

This is now included in the latest version of install-action (https://github.com/taiki-e/install-action/pull/377).

@epage Re https://github.com/taiki-e/cargo-hack/pull/236#issuecomment-1954803270:

Its to avoid when order of field initialization is important, like if borrows are involved.

Did you find this written somewhere?

That was my rephrasing the answer given in the linked issue.

That was my rephrasing the answer given in the linked issue.

Ah. Thank you!


Made the starter code more "Swifty"

Made some enhancements to the Starter Project code so that there is a more descriptive structure to the code, as well as some refactoring with use of some more "modern" Swift code. That way, other developers can more easily use (or even copy) some code to their own projects without doing too much refactoring themselves. 😉
The enhancements in detail:

Removed some unnecessary parentheses and references to self. (as most of the time, Swift can infer it itself and the syntax highlighting in Xcode cues for an instance member)
Removed some unnecessary type annotations (Again, Swift can infer most things and it makes the code more readable and concise)
Removed breaks in switch case statements (Swift cases don't automatically fall through)
Used guard instead of if e.g. for early returns (less pyramid of doom 😉)
Used some functional programming features of Swift (i.e. .first(where: ...) finds the first element of a Sequence with a given condition)
Moved protocol conformance to extensions (Improves code structure and makes relations to protocols clearer)
Improved general structure (moved some methods that support protocol methods to extensions, others that serve user interaction to the ViewController class itself, etc.)

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

@Paccos Sorry it took me so long to take a look. I went through the changes and learned a lot of modern Swift syntax and usage. Since @timrozum is the expert and you guys have already done the review process, I pulled the branch and tried locally. Made couple of calls and confirmed that the updated app works both directions and in different app states.
Thanks again for submitting the PR @Paccos 👍
I'll go ahead and merge the PR.


which codecs from multicodec table.csv are defined and should be implemented in multihash

As it is stated here:

We use a single multicodec table across all of our multiformat projects. The shared namespace reduces the chances of accidentally interpreting a code in the wrong context.

However, there are too many codec in the table. It is not clear:
Which codecs from multicodec table.csv are defined and should be implemented as multihash?
For example, maybe the BaseN (base8, base16, base32, ...) are not hashes and, the SHAs and blake2b definitely are hashes. http, udp, ip4 are not hashes as well.
So, from this table https://github.com/multiformats/multicodec/blob/master/table.csv, we still need clearity that which are treated as hashes and should be implemented in the multihash project.

The code table is divided in sections each of which has a header line with no code value, specifying if the block that follows are hashes, bases, multiaddr protocols, etc. If this is not enough, could you suggest an alternative?

ok I understand. all codecs under multihashes are for hashes. thanks


Retrieve multiple documents with Session Token

Is your feature request related to a problem? Please describe.
When using GetItemQueryIterator I cannot see a way to pass in the session token.
Describe the solution you'd like
A way to retrieve multiple documents passing in a session token. One way would be to add session token to QueryRequestOptions and use it.
Describe alternatives you've considered
I can retrieve a single item using ReadItemAsync and pass in the session token as part of the options.
Additional context
Maybe there is a way to do this, and I've just not found it? I also opened a Stack Overflow question a few days ago, but had no response on that yet https://stackoverflow.com/questions/58644522/net-core-cosmosdb-get-multiple-documents-with-session

@bchong95 is there any reason to block making this property public?


[V4] Whitescreen when building to device

Bug Report
Ionic Info
cli packages: (/usr/local/lib/node_modules)

   @ionic/cli-utils  : 2.0.0-rc.6
   ionic (Ionic CLI) : 4.0.0-rc.6

global packages:

   cordova (Cordova CLI) : 8.0.0

local packages:

   @angular-devkit/core       : 0.6.1
   @angular-devkit/schematics : 0.6.1
   @angular/cli               : 6.0.1
   @ionic/schematics-angular  : 1.0.0-rc.5
   Cordova Platforms          : android 7.0.0 ios 4.5.4
   Ionic Framework            : @ionic/angular 4.0.0-alpha.3

System:

   ios-deploy : 1.9.2
   NodeJS     : v8.11.1
   npm        : 6.0.0
   OS         : macOS High Sierra
   Xcode      : Xcode 9.3.1 Build version 9E501

Environment Variables:

   ANDROID_HOME : not set

Describe the Bug
When building to an android or ios device you'll be greeted with a white screen and no errors when using the following code on your first page.
Steps to Reproduce
Steps to reproduce the behavior:

Generate new project.
Put example code in home page html
Build to a real ios or android device.

Related Code
<ion-header>
</ion-header>

<ion-grid slot="fixed" vertical="center" horizontal="center" padding>
  <ion-row>
    <ion-col>
      A
    </ion-col>
  </ion-row>
  <form>
    <ion-row>
      <ion-col>
        <ion-list>
          <ion-item>
            <ion-label>
              B
            </ion-label>
            <ion-input type="text"></ion-input>
          </ion-item>
        </ion-list>
      </ion-col>
      <ion-col>
        C
      </ion-col>
    </ion-row>
  </form>
</ion-grid>

<ion-footer>
</ion-footer>

Yea exactly the same for me @ASHFAQPATWARI . Tried the usual solutions for that issue such as making the timeout longer and allowing origin and still no luck. Works fine in V3 :(.

I have also added the timeout preference but no luck. I have tried in ios/android both devices.

Could be related to #14489 However only seems to not fire when using the code above.

Hello all! This has been fixed with the latest versions of Ionic and our new beta version of the webview plugin. To get the fix first make sure you have the latest version of ionic 4 (npm install<EMAIL_ADDRESS>--save-exact) and then run these two commands ionic cordova plugin rm cordova-plugin-ionic-webview ionic cordova plugin add<EMAIL_ADDRESS>Thanks!


Celery tasks don't seem to run under docker_django3.1

All of the celery services are running, but it doesn't look like any of the tasks ever get fired.
Also, when I try Feed.drain_task_feeds() mentioned in Maintenance, I get the following error:
[Feb 15 14:07:56]  ---> Draining 0 tasked feeds...
Traceback (most recent call last):
File "", line 1, in
File "/srv/newsblur/apps/rss_feeds/models.py", line 581, in drain_task_feeds
r.sadd('queued_feeds', *tasked_feeds)
File "/usr/local/lib/python3.7/site-packages/redis/client.py", line 2243, in sadd
return self.execute_command('SADD', name, *values)
File "/usr/local/lib/python3.7/site-packages/redis/client.py", line 901, in execute_command
return self.parse_response(conn, command_name, **options)
File "/usr/local/lib/python3.7/site-packages/redis/client.py", line 915, in parse_response
response = connection.read_response()
File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 756, in read_response
raise response
redis.exceptions.ResponseError: wrong number of arguments for 'sadd' command

think this might be because app = Celery('newsblur') instead of app = Celery('newsblur_web') in celeryapp.py in newsblur_web

This has been fixed on the dashboard3 branch. I'm going to continue hooking up these parts together this week, so I am hoping to get to the celery servers soon.


New tool: stacked age pyramid

Fork popbyage to produce this

Say, the data is 4-dimensional:
time,
age,
left-right groups
stacked groups
on top of these 4 dimensions we can have 2 indicators:
magnitude (above the number of people by age, gender, education level and time)
color (above the color is just by education level)

Also keep possibility of one sided age pyramid in case of absence of dimension for left-right groups

Add a button/command to hide/show the stacked groups dimension.

you can also use this one to see an example.
http://www.oeaw.ac.at/vid/dataexplorer//
click graphic explorer in the top and select south africa if you wan to see south africa

Data files:
year-age (half pyramid, solid bars)
https://drive.google.com/open?id=0B_dT7XMWVfqaS08wSmtFQkFVQUk
year-age-education (half pyramid, bars split by education)
https://drive.google.com/open?id=0B_dT7XMWVfqaRGI1Q0VEdjJtT1U
year-age-education-gender (full pyramid, half per gender, bars split by education)
https://drive.google.com/open?id=0B_dT7XMWVfqaZHlpUWR3UXJZY2s

Summary: looks good so far! Now let's make it working in a useful way
Improvements needed:

time slider should play and bars should move smoothly
three possible options:

workaround: we produce interpolated data. the data file become larger
workaround: we turn dimensions into measures. columns in data file would be: time, age, noschooling_male, someprimary_male, completeprimary_male, somesecondary_male, grade12_male, higher_male, unspecified_male, na_male, total_male, noschooling_female, someprimary_female, completeprimary_female, somesecondary_female, grade12_female, higher_female, unspecified_female, na_female, total_female
we actually change the core so that it interpolates the values across all dimensions

Color legend should show the color legend: No schooling, Some primary, Complete primary, Some secondary, Grade 12/Std 10, Higher, Unspecified, Not applicable

Make a custom color palette in metadata so it makes more sense

Maybe remove "stack" altogether and just have "color", because it doesn't make sense to split the two

the hooks should be called color, stack, side, similar to what you have
the "which" part of hook (and the indicator name) should go like: Education, Education, Sex respectively. "Side" hook should also be available to chose.

if stack color is use=constant, which=none, then we'd have a single bar per age
if stack color is use=property, which=education, then we would have the picture we have
we can also have color use=property, which=race, then instead of education levels we would have black, white, indian, colored
if side=constant, which=none, then we would have one side
if side=property, which=sex, then we would have two sides

One x axis takes the values in and the other pushes them out?

and here none of them takes 0 in

Bars should resize thickness on resizing the screen

Switch (button/command) between showing proportionate (% of total population) or absolute numbers.

So the x-axis would change from absolute numbers to %. Where % is relative to the total of whole pyramid population.

'9. Hovering behavior:

hover by segments, not by rows
don't write year, but add segment name
example for below 25-to-29-year-olds Some secondary: 13.2k
for left side: text-anchor=end to the middle of the pyramid

'10. in this example percent mode didn’t rescale to fit the bars
(it’s in presentation, slide27, file vizabi-agepyramid-race.html)

'11 scale on absolute has too much whitespace
'12 changing to single color: stacks stay but with one color
'13 changing to single color: sides switch


Publish v0.36.0 to crates.io

Thanks for your continued hard work on resvg. Would you be able to publish the latest version to crates.io? The latest version over there is v0.35.0.

Whoops, my bad. Done.


Error fetching Siku Fan 192.168.###.## data: Connection to Siku Fan failed: timed out

System Health details
System Information

version
core-2024.10.4

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.12.4

os_name
Linux

os_version
6.6.54-haos

arch
x86_64

timezone
Europe/Berlin

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

HACS Data
ok

GitHub API Calls Remaining
4994

Installed Version
2.0.1

Stage
running

Available Repositories
1526

Downloaded Repositories
8

Home Assistant Cloud

logged_in
true

subscription_expiration
28. April 2025 um 02:00

relayer_connected
true

relayer_region
eu-central-1

remote_enabled
true

remote_connected
true

alexa_enabled
true

google_enabled
true

remote_server
eu-central-1-9.ui.nabu.casa

certificate_status
ready

instance_id
18101094b09a4ea894036440f1c9859b

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 13.2

update_channel
stable

supervisor_version
supervisor-2024.10.3

agent_version
1.6.0

docker_version
27.2.0

disk_total
468.7 GB

disk_used
16.0 GB

healthy
true

supported
true

host_connectivity
true

supervisor_connectivity
true

ntp_synchronized
true

virtualization

board
generic-x86-64

supervisor_api
ok

version_api
ok

installed_addons
Mosquitto broker (6.4.1), Zigbee2MQTT (1.40.2-1), Studio Code Server (5.17.2), File editor (5.8.0), ESPHome (2024.10.2), AppDaemon (0.16.7), Grafana (10.1.3), Node-RED (18.1.1)

Dashboards

dashboards
6

resources
2

views
25

mode
storage

Recorder

oldest_recorder_run
23. Oktober 2024 um 08:38

current_recorder_run
31. Oktober 2024 um 20:37

estimated_db_size
1124.46 MiB

database_engine
sqlite

database_version
3.45.3

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
The error message is from yesterday, the debug log is from today. I hope that's not a problem. But the error occurs consistently. Debug logging is now still turned on. There should also be another error in the log regarding this integration. I will open a second post regarding this.
Logger: custom_components.siku.coordinator
Quelle: helpers/update_coordinator.py:386
Integration: Siku Fan (Dokumentation, Probleme)
Erstmals aufgetreten: 31. Oktober 2024 um 20:39:44 (140 Vorkommnisse)
Zuletzt protokolliert: 10:14:09
Error fetching Siku Fan 192.###.###.51 data: Connection to Siku Fan failed: timed out
Error fetching Siku Fan 192.###.###.52 data: Connection to Siku Fan failed: timed out
Error fetching Siku Fan 192.###.###.55 data: Connection to Siku Fan failed: timed out
Error fetching Siku Fan 192.###.###.54 data: Connection to Siku Fan failed: timed out
Error fetching Siku Fan 192.###.###.56 data: Connection to Siku Fan failed: timed out
Error fetching Siku Fan 192.###.###.53 data: Connection to Siku Fan failed: timed out
Reproduction steps
I didn't do anything, the error has been occurring since I set up the devices
Debug logs
See file stored under diagnostic dump. Unfortunately the protocol has over 620,000 characters

Diagnostics dump
2024-11-01_Debug-Log_SIKU Integration.txt

as fr as I can see it must be somthing related to your fans or network, because the packet generated looks ok, and other calls with the same data seems to work
2024-11-01 10:34:58.280 ERROR (MainThread) [custom_components.siku.coordinator] Error fetching Siku Fan <IP_ADDRESS> data: Connection to Siku Fan failed: timed out
2024-11-01 10:34:58.280 DEBUG (MainThread) [custom_components.siku.coordinator] Finished fetching Siku Fan <IP_ADDRESS> data in 10.011 seconds (success: False)

the timeout is 10 seconds in the current version, and have been set to 1 sec in the new beta to resolve network errors faster
so you could try updating to the v2.2.0-beta.2 version
https://github.com/hmn/siku-integration/releases/tag/v2.2.0-beta.2

Sorry for my late reply. I have installed the beta and now also the new official version 2.2.0. Unfortunately the problem is still not gone. After updating the official version, other errors also occurred. Should I list them here or submit a new request?

I need new logs and new incidents, but if you get timeout errors it's pretty hard for me to fix, they run UDP so any inconsistency in wifi seems to have a big impact on timeout errors

I have attached another debug log. The error occurs at 18:12:24. So my WiFi is actually very stable. The network coverage is also great. Would it possibly help if I let automations execute commands at a longer interval? I now always have a delay of one second? So e.g. Switch on the fan - one second delay - set the fan to heat recovery - one second delay - change the fan speed
2024-11-09_DEBUG Protokoll_SIKU_2.txt


Cache manager

@VeinGuo I'm going to implement offline video feature in app. I found that the library VGPlayer caches the video automatically. So here are some questions about video caching in this library.

Is there any way to find the cache file path for the specific url in VGPlayer?
Is there any option to enable/disable caching for the video in the library?
I'm going to give the user an option to download the video. To make this logic compatible with your cache manager, I think it's good to download the video directly to the cache directory. Does your cache manager simply saves the video after download is completed? What happens if user close the app before the cache manager completes downloading?
I'm looking for the solution to manually download the specific video file to the cache rather than cache manager automatically does. Is it possible?

It would be helpful for me if you explain about how your cache manager is working.
Any response is appreciated.
Thanks!

Hi,thanks for using my project

VGPlayerCacheManager.cacheFilePath(for: url)  can get to the video cache file path.
Can not close the automatic cache, the next version I will add Bool parameters to set.
The cache consists of two files, the video file and the cache progress file to save the video file to download the segment progress size, and if the user opens the application while downloading the application, the application is played again from the breakpoint.

The picture is from VIMediaCache
The cache is implemented by AVAssetResourceLoaderDelegate, which is cached.
AVAssetResourceLoaderDelegate

@VeinGuo So I want to know what happens when I manually download the video file to the cache file path?
For example, I'm going to add download button which downloads the video from url to the cache file path. I'm wondering if this can cause an issue to your library while your library may try to download the video the the same path at the same time while playing.
Can you please let me know?
Thanks!

@kennybuc  If the manual download, download directly after the completion of the local file, VGPlayer will not do the cache.

@VeinGuo Thanks for explanation and support. I appreciate!


hdl._dsl: Change FSM codegen to avoid mutating AST nodes.

Fixes #1066.

Thanks!

Just a note:
This change makes it impossible to refer to FSM.state inside of the FSM context. It used to be possible before, but now any code doing this throws the error:
AttributeError: 'FSM' object has no attribute 'state'.
Referring to state is only possible after the FSM context.

Yes, that's expected. It was never particularly well-defined, for example if you used len(fsm.state) within the FSM context, or Signal.like(fsm.state) your code was silently broken.

Very good that this is fixed now.


replace requests calls with aiohttp HTTP client calls

this will remove the dependency of requests, assuming we are committed to keeping asyncio in the Python client.

another idea is to switch to httpx, in which case this issue is related to #9


Testing: Switch ava to tape

Circle CI apparently doesn't like Ava tests. Switched to tape instead, which has a nearly identical API.
Update
CircleCI works with Ava, it just needed a circle.yml file specifying the node status.

Unneeded. CircleCI actually works with Ava tests as long as a circle.yml is included, and a node version is specified in package.json.


Query related objects

I'm sorry if this is the wrong place to ask questions.
I'm having two models on my Xamarin client app, where the Test Model has the id value of the Project Model:
public class Test : BaseModel
{
 ...
  [JsonProperty(PropertyName = "name")]
  public string Name { get; set; }
  [JsonProperty(PropertyName = "project_id")]
  public string Project_Id { get; set; }
}

public class Project : BaseModel
{
  [JsonProperty(PropertyName = "name")]
  public string Name { get; set; }
}

Now my question: I'm getting all my Test Models with the where query:
await testTable.Where(some_condition_to_get_test_models)
This yields me a list of Test objects, now I can do things like testObj.Name .
Is there a possibility to get the related Project in one query, so that I can call sth. like testObj.Project.Name to get the Projects Name for a Test Object?
Or do I have to do sth. like projectTable.LookupAsync(testObj.Project_Id) to get the related Project?

I'd recommend reading the data chapter (chapter 3) of my book, which covers relationships.  The link is http://aka.ms/zumobook


C sharp reserved keywords

Attempt to solve the issue with reserved keywords, see #4248. Names will now be prefixed with @ when it is a keyword.
Note that the list of keywords is static. If Microsoft decides to extend the list then we'd have to manually update the list.
Note that changes are based on the c-sharp-improvements branch which is not yet merged to master. Hopefully that is not a big issue.

@cklam2 can you please rebase? :)
Thanks!

@dotansimha thanks. I will first make a change in the code. Want to make use of that convertName feature instead. Will mention you again when rebased and ready for review/merge.

Updated the code and rebased onto master. Also took the chance to clean up the unit test so format looks cleaner and bit more in line with other unit tests. Btw, new unit tests for this bug are also added.
@dotansimha code is ready for review/merge, thanks.

@cklam2 I merged this one, it includes all changes from https://github.com/dotansimha/graphql-code-generator/pull/4264 as well, right?

@dotansimha thanks for the merge!
#4264 is not included in this one. I rebased that branch onto the new master.
Btw, I see a branch "revert-4250-c-sharp-reserved-keywords"?

@cklam2 thanks! The revert branch was a mistake :)
I merged #4264 as well. Thank you so much !