Deprecated?

Is this package still being maintained? If not you may wanna search for active maintainers and create an org out of it?
@MarcelMue  @jacogr

For some strange reason it seems to be little activity - I've created a fork and added some of the most interesting pull requests in my mind + the annoying path-fix: https://github.com/gforge/atom-git-control

Since there is no way to install the fork through Atom directly do this:

Make sure Atom is closed, go to your  ~/.atom/packages folder and delete the folder git-control
Clone the above fork into the packages folder
CD into the resulting folder and run apm install
Open Atom and thank @gforge

Actually you only need to do: apm install gforge/atom-git-control - no 2 (cloning) is not necessary :-)

@gforge thanks for keeping this package alive! People like you are what keep this community afloat :heart:

Hi guys,
thank you for your commitment.
Topic: Deprepcated? => Yes.

I could contact MarcelMue via Email about a view months ago, but not jacogr. I guess jacogr is the package owner. MarcelMue wrote, that they are both no longer using this package as native git support in atom has improved.
The last accepted pull request was last year.
Even if this is a great package, currently it is unusable to a lot of people because of unfixed bugs, that not ever person wants to fix

Solutions
In any case you need someone to maintain the software. As gforge has already made a fork, he might be able to do this. I'm into node, but not familiar with atom; at least I can offer fixing some small bugs. This might be enough to have a working package.
What should we do

Solution 1: get access to this package

best solution => all people using it and downloading the package will be happy
could be so easy, but depends on the @jacogr and maybe @MarcelMue

Solution 2: Make another package

this is ok, but not nice, because of the fame of the old package
I just saw, that there is already an alternative: https://atom.io/packages/git-controlhub
really good: if we can get a deprecation notice (not easy if we get no access to the package)

Next steps
So far - has anyone used https://atom.io/packages/git-controlhub? As git-controlhub is already available as official package, I guess it would be nice to stick to it. So far, it is no exact fork because of the missing git-flow features. I do not need them - is this true for you either?
Please tell your option about what to do.
Regards
Felix

@FelixFurtmayr Thanks for the update! I haven't used git-controlhub, recently I've been sticking to git bash on Windows because atom still seems to have issues dealing with git flow, it seems that it has problems with releasing its resource lock when trying to git flow finish a feature branch.
I would totally volunteer to help out with keeping this package alive if I had more time, but I'm juggling two big development projects for University and one big development project at work so I'm more than a little busy. If you're still after contributors come November when my classes finish, I'd be more than willing to help!

@devotoare cheers for the install instructions and @gforge thank you for keeping this puppy afloat! 🤘🏻


Sonar: 3 code smells

3 code smells detected:

https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=jhipster_jhipster-lite&open=AY3SEB3MsDyxtGggccut
https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=jhipster_jhipster-lite&open=AY3SEB2ssDyxtGggccus
https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=jhipster_jhipster-lite&open=AY3SEB2ssDyxtGggccur

As mentioned in the PR review, I think these are false positive, because Sonar does not yet support Java 21, and some rules are obsolete.


[BUG] one time binding may cause display "undefined"

Vue.js version
1.0.24
Reproduction Link
http://jsbin.com/qowadibeti/edit?html,js,output
Steps to reproduce
For one time binding, undefined value would display as "undefined", it's different from two-way binding.
What is Expected?
Should display as empty.
What is actually happening?
Display undefined.

Hello @dsonet,
Thank you very much for this report. We will continue this in your pull request #2989

@LinusBorg FYI. Just updated the reproduction case, also new fix.


⚠ 366.ru has degraded performance

In 7b4f768, 366.ru (https://366.ru) experienced degraded performance:

HTTP code: 200
Response time: 6586 ms

Resolved: 366.ru performance has improved in cbfe385.


Ranks Not updating.

Hello, Well I've been having an issue with Luck perms on our server, and when I use /lp user  parent add  it adds correctly, then I run the command /lp user  parent switchprimarygroup  and it switches successfully, but on Tablist, and in chat it still says their old rank, but when they travel through the nether, it updates to the new rank, but when they travel back it changes back to the default rank, and I don't know if this is a "Bug" or server Issue, or I'm doing something wrong, but I would like maybe a little guidance in this. we are running Paper 1.16.3, LuckPerms Version: 5.2.35, as well with all the plugins below.

so if I could get a little assistance back. That would be much appreciated!
Sincerely Kamu, Lead Developer, MC: Blood And Steel

Primary groups should be defined by the highest weight group you inherit, unless you changed the luckperms config. https://luckperms.net/wiki/Weight


replace : by _ in namespaces for cf relations

https://github.com/inveniosoftware/invenio-vocabularies/blob/master/invenio_vocabularies/records/systemfields/relations.py#L38

Ideally, we would have a fully consolidated programming interface. Accessing sublevels with a dotted API (e.g. record.cern.experiment). Replacing by underscore would enable dot access, but with a different interface. After discussing IRL, is better to close and re-open in the future if needed.


Removed hardware example per request

Removed section, "Creating a file share witness on a router with a USB device."
Hardware was from Ignite 2018. Detracted from currency of the content.

#assign: @robinharwood, @Xelu86
@robinharwood @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Xelu86 @EliotSeattle - sorry for the confusion. Reverting this change until I can get the rewrite done at the PMs request.


compile fix for msvc 14.24.28314

MSVC\14.24.28314\include\random(1907,1): error C2338: note: char, signed char, unsigned char, char8_t, int8_t, and uint8_t are not allowed
Wonder if you are interested in supporting MSVC 14.24.28314 compiler.. not sure what other version of MSVC work or not, this is running on a GitHub action an I haven't tested it on windows myself yet!
Changing to uint32_t fixes the compiler error, I don't think this should cause any problems with the actual generated ulid?
The uint128 implementation is just bit-wise or into a larger type anyway, so all the 0's in the upper 3 bytes won't make any difference, and this shouldn't affect performance either because it was already doing bitwise or of 2 different sized integer types.. in fact maybe you can improve performance by using the same sized integer (128) when doing the or?
the struct implementation is assigning 32bit values to 8bit array index, as we are in 0-255 should make no difference to result, maybe might affect performance, assigning the uint32 into a uint8?

Initially I'm okay doing this under an #ifdef _MSC_VER or another VS specific macro.

The uint128 implementation is just bit-wise or into a larger type anyway, so all the 0's in the upper 3 bytes won't make any difference, and this shouldn't affect performance either because it was already doing bitwise or of 2 different sized integer types.. in fact maybe you can improve performance by using the same sized integer (128) when doing the or?
the struct implementation is assigning 32bit values to 8bit array index, as we are in 0-255 should make no difference to result, maybe might affect performance, assigning the uint32 into a uint8?

This has benchmarks. Can you post before and after numbers for both scenarios. make bench should do it. For linux and mac, travis should have run. Looking into it.
Also, if possible, can you also add the GitHub Workflow for windows.
Thanks

Sorry for the late comment

hey, I had a fix for that already (we are working in a perforce depot with a git mirror).. I have committed that now.
Sorry this is taking me a long time but haven't had time to add the MSVC GitHub Actions yet.. I will add them sometime soon when I get chance and then let you know.
I did try the benchmarks with different sized integers in the distribute function and couldn't really notice any performance difference..
Also thanks for this lib in the first place, we are using it for allocating unique ID's for a node graph editor and have been happy with it so far :)

Thanks!


Update for Foundry v10

edit module.json for #25

use new compatibility and relationships objects
change "name" to "id" and "author" to "authors" object

migrate icon paths in dbs

@kandashi Hi, any news for the merge ?

I get this error
[E:\FoundryVTT\Data\modules\midi-srd\module.json] Error loading package "E:\FoundryVTT\Data\modules\midi-srd\module.json": Expected ',' or '}' after property value in JSON at position 2075

Nevermind I copied more then I was supposed to lol. But I did have to change style to styles for it to work for me.


UITK to Salt migration guide

Produce a UITK to Salt migration technical guide

Hi @mikearildbrown , please see the guides we currently have below (all ready for review):
Button: https://jpmc.stackenterprise.co/questions/73763
Accordion: https://jpmc.stackenterprise.co/questions/73775
Icon: https://jpmc.stackenterprise.co/questions/73819
Link: https://jpmc.stackenterprise.co/questions/73821
cc @jpmorganchase/salt-content

@JoanaMMoreira Updated the list of guides above, pausing for now until feedback
@lilyvc working on getting the site docs done

Should we change this title of this ticket  to reflect the initial effort ?
Migration Guide Release 1
Then should we create a ticket for Migration Guide Release 1, with 10 more components on there ?
This way we can close this ticket out and track the next priorities.

Closing as v1 is complete

Stack overflow collection created with 14 posts
Salt page is published on UITK site
Component lookup table has been created as a live document


Time controls for messages

Is there a way to set a time window for when the bot publishes messages in Google Chat and when it does not? No one want's to be pinged at 3 am in the morning by a bot. So having a way to set the bot up so it only sends/publishes messages between the hours of 9 am to 5 pm (for example) would be really handy.

Great suggestion! Applied this update in the latest update.

Seems to be publishing out of hours? Left the hours set as in the code START: 9,  END: 17 however had the bot fired after 17.

Can you run the executeUpdateWorkflow after hours and see what the debug statement says? I suspect your script timezone may not be what you expect it to be (which you can check in the script's manifest).

Thanks for the quick reply. On the Execution log, I am getting:
"Info	Europe/London: valid day (true), valid hour (false)"
which is the correct timezone.
On the scripts manifest I am seeing:
{   "timeZone": "Europe/London",   "dependencies": {   },   "exceptionLogging": "STACKDRIVER",   "runtimeVersion": "V8" }

If that's the debug log, the script exits after that logger is fired. You shouldn't see it polling for new posts. If that's the case I wonder if it was just a lag on the border of the time slot.

I'll keep an eye on it. We have it running in multiple rooms (separate script for each room) the first one posted 17:40 and the last room got a post at 18:21. The blog post that they posted was published at 17:36.

Okay, keep an eye on it. If the logic is working now and the updates were put in properly, then it shouldn't be firing. Please check and make sure all new code was moved into the other scripts.

Found the issue. Trigger execution passes an object into the target function, which was falsely enabling the init flag. I've corrected this and now it should work as expected. Great call out!

Thanks.


WIP: first pass at UnboundTransform

Resolves https://github.com/apache/iceberg-python/issues/198

@Fokko this isnt completely done, but would appreciate a review + some guidance on next steps once you run linting and see whats up haha

No worries on the speed of this one, I know you are heads down on getting write support

Hey @jayceslesar thanks for working on this, and I think you're already halfway there. The most important part is to make sure that we convert as date to a DayTransform.


Viewing yaml for a resource logs two warnings to the developer console

Expected Behavior
Viewing a resource's yaml should not log any warnings to the developer console.
Current Behavior
Currently, two warnings are logged to the developer console when a resource yaml is viewed:
Could not create web worker(s). Falling back to loading web worker code in main thread, which might cause UI freezes. Please see https://github.com/microsoft/monaco-editor#faq
You must define a function MonacoEnvironment.getWorkerUrl or MonacoEnvironment.getWorker
Steps to Reproduce
The easiest way to reproduce this is by viewing a package resource's yaml:

Open the simplens team blueprint created by Namespace Provisioning Guide
Click on any resource within in the team blueprint to bring up the resource viewer dialog
With the developer console open, click on the 'Show YAML View' button in the dialog, and the two warnings are written to the console

Possible Solution
A possible solution is to implement the web worker being requested by the editor.
Context
The Monaco Editor is used in the Resource Editors and Viewers in the Config as Data UI to give us a rich editor experience with syntax highlighting. These warnings do not seem to impact the user experience however we should see these warnings can be resolved.


Publish compute data set with 'Forever' timeout value

Fixes #733 .
Changes proposed in this PR:

timeout vale fix

After checking around and resolving what @krisliew  suggested in #733 : https://github.com/oceanprotocol/market/blob/bea4f46c9ae65b0049d1d077c0343b04a12d4579/src/hooks/usePublish.ts#L86
I also checked the createComputeService in ocean.js and there seems to be the problem: https://github.com/oceanprotocol/ocean.js/blob/77dbfb836aa122687fa4a1a7bb4100ec3e5333a7/src/ocean/Compute.ts#L349
When publishing data in market, we use createComputeService for creating computeService metadata for a ddo, which then comes as services in the the new ddo published. https://github.com/oceanprotocol/market/blob/bea4f46c9ae65b0049d1d077c0343b04a12d4579/src/hooks/usePublish.ts#L94

the issue for ocean.js createComputeService() https://github.com/oceanprotocol/ocean.js/issues/918

the issue for ocean.js createComputeService() oceanprotocol/ocean.js#918

We discussed this issue yesterday and came to the conclusion that is better to eliminate the Forever timeout option when creating a dataset with Compute asset type.

@claudiaHash
Does that mean Forever timeout will be remove for algorithm compute too? since it goes through the same createComputeService method?

No, it won't. Only  when creating a dataset with Compute type, the Forever option won't exist for timeout. The change will affect the options user can select for timeout in this situation, in the Publish form.

I tried to publish a dataset on the preview of this branch but got an error:

Using the latest deployment of the branch I just published 2 datasets, one with download  and the other one with compute access type and seemed to work for both cases.

Hope it's not something related to my setup. Did someone else also tried?


NEXT-00000 - Add CMS visibility component twig blocks

1. Why is this change necessary?
Because the templates of the components sw-cms-visibility-config and sw-cms-visibility-toggle have no twig blocks. Therefore it's hard to extend these components via plugins.
2. What does this change do, exactly?

Add the twig blocks
Rename sw-cms-visibility-toggle.html to sw-cms-visibility-toggle.html.twig

3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

I'm very sorry to tell you, but we can't accept this change. Those files are marked private for a reason and we do not want those to be extended, due to possible chaotic behavior, especially when multiple plugins would extend those. For that reason (and some more), we have that ESLint rule, you're constantly disabling.
Is there some crucial functionality (beside simple extensibility via blocks) you are lacking? Please consider opening a ticket or open a discussion for that matter :)
Thanks anyway for your continued patronage!


[embedded] Make Unmanaged available in embedded Swift, add a test for various types from the stdlib

There's no reason to exclude Unmanaged from the embedded stdlib (looks like an oversight that it was excluded), so let's make it available as it's generally useful for interop with C APIs. Also let's add a compilation test exercising various types from the stdlib.

@swift-ci please test


Broken Links

Found a broken links.

On line 81 of https://github.com/kubernetes/helm/edit/master/docs/chart_repository.md the link should be chart_repository_sync_example.md.

I'd do a PR but my company is being slow about signing the CLA.

alrighty thanks!

Another one:

Line 76 of https://github.com/kubernetes/helm/edit/master/docs/developers.md should be https://github.com/kubernetes/helm/blob/master/CONTRIBUTING.md


How to make the command palette responsive.

@mohsinxx365 this component supports a theme prop which can be used to customize the CSS. Please note that as I build towards v1.0 developing responsive is no on the roadmap. However it's easy to override the width with in CSS with any dimensions you need.

Ok thanks


cmd/compile: for range loop reading past slice end

What version of Go are you using (go version)?
1.13.5,1.14.6
Does this issue reproduce with the latest release?
yes!
What operating system and processor architecture are you using (go env)?
linux,amd64
What did you do?
try this in playground

package main
import "fmt"
func main() {
        rates:=[]int32{1,2,3,4,5,6}
	for star, rate := range rates {
		if star+1 < 1 {
			panic("")
		}

		fmt.Println(star, rate)
	}
}

What did you expect to see?
0,1
1,2
2,3
3,4
4,5
5,6
What did you see instead?
timeout running program
0 1
1 2
2 3
3 4
4 5
5 6
6 180344
7 192
8 4846592
9 0
10 180424
11 192
12 4846720
13 0
14 5822560
15 192
16 438224
17 192
18 4396406
19 0
20 385024
.....

Thanks for the report. I can reproduce this on tip, too.
cc @randall77 @cherrymui

(Tentatively labelling as a 1.15 release blocker)

it seems that changing the line if star+1 < 1 { to if start+2 < 2 { (or other number not equal to 1) will work correctly.

This issue appears to have been introduced a while ago. According to bisection, commit b812eec seems to be the most likely culprit

			// Check for i2 < max or max > i2.
 			var max *Value
 			if r == lt && pred.Control.Args[0] == i2 {
 				max = pred.Control.Args[1]
 			} else if r == gt && pred.Control.Args[1] == i2 {
 				max = pred.Control.Args[0]
 			} else {
 				continue
 			}

  			// Check condition 4 now that we have a
 			// candidate max. For this we can query the
 			// fact table. We "prove" min < max by showing
 			// that min >= max is unsat. (This may simply
 			// compare two constants; that's fine.)
 			ft.checkpoint()
 			ft.update(b, min, max, tr.d, gt|eq)
 			proved := ft.unsat
 			ft.restore()

  			if proved {
 				// We know that min <= i1 < max.
 				if b.Func.pass.debug > 0 {
 					printIndVar(b, i1, min, max, 1, 0)
 				}
 				ft.update(b, min, i1, tr.d, lt|eq)
 				ft.update(b, i1, max, tr.d, lt)
 			}

Here the requirement is i2 < max and the proof is min < max. What we add is min < i1 < max.
The problem when we put these together, min < i1 < i2 = i1+1 < max, the min < max is actually not sufficient.
Here is another way to reproduce (similar to the test in that commit)
package main

func main() {
	i := 0
top:
	if i < 2 {
		i++
		if i < 1 {
			return
		}
		println(i)
		goto top
	}
}

Wow, thanks for reporting. Yeah, as you mentioned, this is related to the prove pass. Running with -gcflags=-d=ssa/prove/off gets the correct result.
cc @dr2chase

Moving the milestone to 1.16, as this issue, while significant, is old enough not to block the 1.15 release at this point in the cycle. Please let me know if I am wrong.

I'm going to take a crack at patching this in the morning (if noone else has gotten to it by then). It is late here, but my completely unconfirmed guess is that this loop has been compiled to OFORUNTIL (placing the increment and condition after the body) and func addLocalInductiveFacts, which is then trying to infer the loop induction variable by finding the OFORUNTIL pattern, is confusing the star +1 < 1 check with the loop's increment and condition. This would explain why star + 2 < 2 doesn't have the same effect, because any increment other then +1 will not be confused with the loop increment.

Backport candidate?

@toothrot it seems like this may violate the Go API compatibility guarantee, so I think it would be good to block Go 1.15.

Interesting, reproducible for all primitive number types as well as for boolean slice.

This has a small fix, and pretty terrible consequences. Shouldn't it be 1.15?
cc @ianlancetaylor

This would be really nice to fix for 1.15. As it has been broken for several releases, our policy is to not block a release for it.
Hence the 1.16 milestone.
There's no hurry for backport issues. If/when we have a fix that looks good, and looks backportable, we can open backport issues.

Could you consider reverting the commit that causes it in 1.15?
And backporting that since both 1.13 & 1.14 are affected?

Sure, that's a possibility. It's a pretty old CL, though, it might not revert cleanly.
We could roll forward at tip but revert in 1.13 and 1.14. Options are available.

In case it wasn't clear, I meant revert it before the 1.15 release.

Summary
Generic CSE is turning this code into a pattern that prove incorrectly identifies as OFORUNTIL. Prove adds the OFORUNTIL induction variable bounds as facts in the loop header, leading to the removal of the loop exit branch.
Background
Prove has two ways of identifying loop induction variables and their min/mix:

findIndVars finds " normal" loop induction vars, and their bounds, for normal loops
addLocalInductiveFacts finds "OFORINTUL" loop induction vars, and their bounds, for OFORUNTIL loops.

During prove proper (DFS of the SSA dominator tree), prove adds facts based on the bounds of loop induction variables in two ways - the difference is part of the present issue:

bounds of "normal" loop induction variables are added as facts when entering the body of the loop.
bounds of "OFORUNTIL" induction variable are added as facts when entering the loop header (I'm not sure how this works out in a real OFORUNTIL case, I need to see one of those.).

Why is prove removing the loop exit
When prove analyses this SSA, addLocalInductiveFacts is incorrectly identifying the loop as OFORUNTIL, and therefore adding the loop induction bounds as facts in the loop header. But this is a normal loop, not OFORUNTIL, so the loop condition is in the loop header. So when we enter the loop header we learn 0 <= start < 1. With these facts present, prove finds the negative branch from the loop header, stat >= 6, unsatisfiable, and removes the negative branch. Because the negative branch of the loop header is the loop exit, removing it means the loop will never exit.
How is generic CSE involved
Generic CSE is identifying the Add64 star 1 from star + 1 < 1 in the loop body, and the Add64 star 1 from the star++ loop increment as commom subexpressions, and removing the latter of the two (gcse deadcode does the actual removal). Generic CSE also then modifies the OpPhi in the loop header so it's loop-back edge variable references the remaining Add64 star 1.
b4: ← b2 b6
    v47 (5) = Phi <int> v10 v70 (star[int])        <-------- v70, the input from the loop-back edge
    ...
    v49 (+5) = Less64 <bool> v47 v11
If v49 → b5 b7 (likely) (5)

b5: ← b4
    v51 (+6) = Add64 <int> v47 v16
    v52 (6) = Less64 <bool> v51 v16
If v52 → b9 b6 (6)

b6: ← b5
    ...                                                         <------ print() code elided
    v70 (+5) = Add64 <int> v47 v16       <------  loop increment
Plain → b4 (5)

b7: ← b4
Ret v72 (5)

becomes
b4: ← b2 b6
    v47 (5) = Phi <int> v10 v51 (star[int]).      <-------- v51, new input variable
    ...
    v49 (+5) = Less64 <bool> v47 v11
If v49 → b5 b7 (likely) (5)

b5: ← b4
    v51 (+6) = Add64 <int> v47 v16     <------ this is now the loop increment
    v52 (6) = Less64 <bool> v51 v16.  <------ addLocalInductiveFacts thinks this is OFORUNTIL loop condition
If v52 → b9 b6 (6)

b6: ← b5
    ...                                                        <------ print() code elided
Plain → b4 (+5)

b7: ← b4
Ret v72 (5)

The result of the above is a loop header with a loop induction OpPhi referencing a variable in a predecessor block, along it's loop-back edge, that increments the loop induction var and checks whether the result is less than some constant. This is the pattern that addLocalInductiveFacts is looking for.

Why is prove removing the loop exit
When prove analyses this SSA, addLocalInductiveFacts is incorrectly identifying the loop as OFORUNTIL, and therefore adding the loop induction bounds as facts in the loop header. But this is a normal loop, not OFORUNTIL, so the loop condition is in the loop header. So when we enter the loop header we learn 0 <= star < 1. With these facts present, prove finds the negative branch from the loop header, star >= 6, unsatisfiable, and removes the negative branch. Because the negative branch of the loop header is the loop exit, removing it means the loop will never exit.

Learning 0 <= star < 1 is wrong as I said. We should never prove 0 <= star < 1 because start + 1 < 1 can't be satisfied.
What (we think) we prove:

0 <= start < 1
What we require:
start + 1 < 1 (i2 < max)
0 <= 1 (min < max)

But it's obvious that start < 1 means star < 0. We can prove there is a paradox here!
Another example may help. It's not starting from 0, without i+1 and as I understand actually a OFORUNTIL case.
package main

func main() {
	i := 5
top:
	i++
	if i < 6 {
		return
	}
	if i > 6 {
		return
	}
	println(i)
	goto top
}

A more OFORUNTIL one:
package main

func main() {
	i := 5
top:
	i++
	println(i)
	if !(i < 6 || i > 6) {
		goto top
	}
}

any idea why it's not a problem for string slices or other type slices? I've been able to reproduce this only for numbers & boolean slices

Is it worth trying to figure out how often this happens in practice on a large codebase?  Given that it's been around for a while it seems fairly rare.

So, is there some reliable estimation on time to fix this bug?

There's never a reliable estimation on bug fix time :)
You can follow along with the current suggested CL at https://go-review.googlesource.com/c/go/+/244579

@WZZ1998 as of now I'm happy with the fix, but waiting to see whether it makes the cut for 1.15 or a dot release, and would love other eyes on my assessment of what the original code thought it was doing, and how the fix interacts with that.
I'm also benchmarking the fix to see if this accidentally causes terrible regressions; there's a chance that we lose some (correct) optimization that we had come to expect, since the fixed code will match a more restricted set of patterns.

@gopherbot, please open backport issues for 1.14 and 1.13.


GH-44223: [Dev] Use "Gandiva" instead of "C++ - Gandiva" label

Rationale for this change
We have Gandiva related codes. So "C++ -" isn't match the current code base.
What changes are included in this PR?
Remove the "C++ - " part.
Are these changes tested?
No.
Are there any user-facing changes?
No.

GitHub Issue: #44223

Ah, can we rename the existing "C++ - Gandiva" label to "Gandiva"?

Ah, can we rename the existing "C++ - Gandiva" label to "Gandiva"?

Yes, I am going to rename the label and merge this.

I've renamed the label: https://github.com/apache/arrow/labels/Component%3A Gandiva

Thanks!


Just duplicate the package layout

A recent change to the way we render our package pages made it mandatory for package authors to update their overview and install pages to use a new layout named package. Previously, these pages used the overview and install layouts, respectively, but those templates have been removed.
Many authors aren't aware that they have to do this, however, so when they release a new update without having made these changes, the update either fails to render when published or fails to make it through the pipeline at all. This makes for a pretty poor experience as a package author, so this PR simply duplicates the package template so that authors can continue using the old layout names until they're able to cut over to the new ones.
To be clear, I definitely don't love having to do this -- but there isn't really another way to paper over it, and I feel bad leaving authors to hit it and blocking publishing because of it. So it might be good to consider pulling it in at least for a while to give folks some time to transition. See https://github.com/pulumi/registry/pull/2796#issuecomment-1615201739 for a bit more context.

@sean1588 If merging this makes sense to you too (feel free to push back on it of course), then yeah, I guess we would have to do that.
Would be good to know whether this makes sense to you too, though, or if you can think of a better alternative. I thought about a couple of things to get around the duplication -- reading the file contents from the package template, explicitly overwriting the layout param somehow, using some other standard Hugo layout file as a fallback, etc.), but nothing quite works, in part because these files end up in the Hugo virtual filesystem, so we don't ever get access to them as files, unfortunately. It's a bummer all 'round, but I guess I'd rather take the hit myself than let users run into it. What do you think?

just updating this with our slack convo for context since I replied to you there...

yeah im not too worried about the duplication aspect of it since this is more of a temporary solution until we can get the authors over to using the new layout. I guess my only concern with this is it will technically still allow the authors to use the old layout file names and I guess not sure how to fully prevent that going forward. But I think this is fine and yeah you can go ahead and remove the validation.


How small and how large can VNets and subnets be?

I am able to create a /7 subnet , can you please revalidate the max size for a subnet

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 07cec477-f584-400f-889c-9a5403f34bad
Version Independent ID: f777fdfd-2f5a-56b9-574f-ae6d2b19f130
Content: Azure Virtual Network FAQ
Content Source: articles/virtual-network/virtual-networks-faq.md
Service: virtual-network
GitHub Login: @KumudD
Microsoft Alias: kumud

@erbalaji Thanks for the feedback! It looks like you can go a bit bigger than /7 too.

I have assigned the issue to the content author to evaluate and update as appropriate.

@allegradomel Please can you comment. Thanks!

Hi @erbalaji , thanks for this suggestion - we have made the change to say /2 instead. The change will go live in the next couple of days. #please-close


ADO extension: baselining might be too sensitive to unrelated changes

The baseline support added to the ADO extension v1.1.0 is sometimes overly sensitive to non-accessibility-related changes in the page. In particular, if a baselined failure's axe-core-suggested HTML snippet ends up changing due to a PR in a way that doesn't impact whether it fails an accessibility rule or not, the baselining logic will currently see that as "one failure fixed, one new failure found", since it will consider the versions of the failure with different snippets as different.
This tradeoff was made intentionally in the interest of having baselining's idea of failure grouping be consistent with how failure grouping works already in accessibility-insights-service, but it's something that we predict might end up being unexpected for users. We don't have good data on exactly how often this is going to be hit in practice, so we'll use this tracking issue as a place to track potential user feedback on this topic.
If you're a user reading this that is frustrated by the behavior, we'd love if you could upvote this issue (with a thumbs-up reaction) and leave a comment letting us know the specific example that caused you trouble! (ideally, including a diff of the relevant section of your baseline)

The Accessibility Insights team has received several upvotes for this issue over the course of several months, and will be investigating a solution.

Problematic Scenario
The most common scenario that we have come across that causes this issue is CSS selectors being auto-generated in a non-deterministic manner by webpack or other build processes.
For example, an element and CSS class may look like this in the source code:

Hello World

And once built, the build process will append a random string to the end of the class (-Gz1t in this case)

Hello World

This randomly generated string changes on every build, causing mismatches in the baseline file each time.

Possible Solutions/Workarounds
Adding an id/class/attribute to uniquely identify problematic element
Axe, the accessibility scanning engine used by Accessibility Insights, uses a hierarchy of possible selectors to uniquely represent an element. If a unique selector is found on any step of the hierarchy it will use that selector and skip the rest of the hierarchy.
The hierarchy used is as follows:

If an element has an id which is unique with the page
Class names which are unique within the page
Custom attributes which are unique with in the page
Custom complex selector using classes and attributes of the element and it's ancestors

If you're able to give the problematic element(s) a unique id or css class name which is not modified on build, Axe can use that selector instead of the auto-generated one.
Modifying build strategy
Depending on your project and build setup, you may be able to use a different strategy for how the build process generates selector names. For example, our own webpack settings for our CSS modules uses something like this:
{
  loader: 'css-loader',
  options: {
    esModule: true,
    modules: {
      localIdentName: '[local]--[hash:base64:5]'),
    }
  }
}

This produces deterministic selector names as long as the contents of the individual CSS module in question are unchanged. This would still cause the baseline to break if the contents of the module are changed, but it would still be a drastic improvement over breaking every build even when no source changes occur.

Unfortunately, this is out of scope given our current priorities.
Thanks for using Accessibility Insights!


A public user can download their customized, cloned skill list to an excel file

Related to #13. Any OccupationStandard can be downloaded in excel or PDF.

@Pcushing and this should definitely be an Excel file vs just a csv file, right?

@littleforest CSV is fine.


GitHub Issue #173: add stack frame arguments values to traces

This PR adds local_vars_dump configuration option. If enabled traces sent to Rollbar will include the values of arguments passed to each frame in stack traces.

Ready for review

Can we drop this one now in favor of https://github.com/rollbar/rollbar-php/pull/192 which includes this?

yes

Closing in favor of #192


[Codegen][GPU] Add pattern to distribute multi_mma ops to lanes

Distribution of an iree_gpu.multi_mma op does a one-shot rewrite from warp semantics to thread semantics, inserting a lane mapped scf.forall that extracts the appropriate slices from each operand according to the intrinsic kind.
This also adds permutation fields to iree_gpu.multi_mma for representing permuted variants of the inner intrinsic matmul for subgroup semantics.
By adding a permutation to the operands of the multi_mma operation, we can express row/column major inputs. and then distribute accordingly. There are two reasons for a generic "permutation" instead of a second set of indexing maps or something simpler like a boolean.

The permutations of each operand are unrelated, so indexing maps
cannot relate two operands with one another.
Future batched intrinsics, and options to pre-swizzle/pack the inner
dimensions can be managed with an implicit contract between the
intrinsic kind and the permutation.

@Groverkss  and @kuhar could you guys review this PR. You guys probably have more context on this.

I'm still taking a look at this. I'm trying to understand the permutation field better. This bit us hard in layouts where we should have used strides. Just making sure we arent making the same mistake again.

I'm still taking a look at this. I'm trying to understand the permutation field better. This bit us hard in layouts where we should have used strides. Just making sure we arent making the same mistake again.

You can think of permutation as a way to express matmul variants like matmul_transpose_b or matmul_transpose_a without having to insert a transpose when converting from linalg to multi_mma. It's just a transposition of the data relative to what the intrinsic default is. We might opt to change it to something more structured later, but this lets us do more or less anything we want with an implicit contract between the permutation and the mma kind.


Ensure environment is restored on error

Fixes #129
There doesn't seem to be a hook_runner_spec or hook_loader_spec anywhere, and I figured that's something you guys would prefer to set up on your own.

Coverage increased (+0.2%) to 95.41% when pulling fd3912cf9f37415afd721e1528dfd68614d2e498 on jawshooah:bugfix/restore-environment-always into fa88e74b07ef3ffc09b429506bc5256a68915bba on causes:master.

Yeah, the lack of hook_runner_spec is more a result of the fact that it's difficult to test interrupt-handling code, which is a lot of what the HookRunner class handles.
Merged in c3d972d. Thanks for the fix!


molecule fails in GitHub actions with: ansible_compat.errors.InvalidPrerequisiteError: Collection 'community.docker' not found in '['/home/runner/.ansible/collections', '/usr/share/ansible/collections']'

Issue Type

Bug report

Molecule and Ansible details
ansible [core 2.15.3]
  config file = None
  configured module search path = ['/home/runner/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/ansible
  ansible collection location = /home/runner/.ansible/collections:/usr/share/ansible/collections
  executable location = /opt/hostedtoolcache/Python/3.11.4/x64/bin/ansible
  python version = 3.11.4 (main, Jun  7 2023, 11:01:02) [GCC 11.3.0] (/opt/hostedtoolcache/Python/3.11.4/x64/bin/python)
  jinja version = 3.1.2
  libyaml = True
molecule 6.0.0 using python 3.11
    ansible:2.15.3
    azure:23.5.0 from molecule_plugins
    containers:23.5.0 from molecule_plugins requiring collections: ansible.posix>=1.3.0 community.docker>=1.9.1 containers.podman>=1.8.1
    default:6.0.0 from molecule
    docker:23.5.0 from molecule_plugins requiring collections: community.docker>=3.0.2 ansible.posix>=1.4.0
    ec2:23.5.0 from molecule_plugins
    gce:23.5.0 from molecule_plugins requiring collections: google.cloud>=1.0.2 community.crypto>=1.8.0
    podman:23.5.0 from molecule_plugins requiring collections: containers.podman>=1.7.0 ansible.posix>=1.3.0
    vagrant:23.5.0 from molecule_plugins

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Detail any linters or test runners used: I don't understand what is meant by this. I have made a branch of my role so you can look at the molecule and GitHub action configuration here.
Desired Behavior
It should just work.
Actual Behaviour
Molecule default > dependency
  INFO     Running from /home/runner/work/ansible-role-systemd-timesyncd/ansible-role-systemd-timesyncd : ansible-galaxy collection install -vvv community.docker:>=3.0.2
  CRITICAL Collection 'community.docker' not found in '['/home/runner/.ansible/collections', '/usr/share/ansible/collections']'
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.4/x64/bin/molecule", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/command/test.py", line 113, in test
    base.execute_cmdline_scenarios(scenario_name, args, command_args, ansible_args)
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/command/base.py", line 123, in execute_cmdline_scenarios
    execute_scenario(scenario)
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/command/base.py", line 166, in execute_scenario
    execute_subcommand(scenario.config, action)
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/command/base.py", line 156, in execute_subcommand
    return command(config).execute(args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/logger.py", line 189, in wrapper
    rt = func(*args, **kwargs)
         ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/logger.py", line 100, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/command/dependency.py", line 40, in execute
    self._config.dependency.execute()
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/dependency/ansible_galaxy/__init__.py", line 95, in execute
    invoker.execute()
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/dependency/ansible_galaxy/base.py", line 115, in execute
    super().execute()
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/dependency/base.py", line 91, in execute
    self._config.runtime.require_collection(name, version)
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/ansible_compat/runtime.py", line 721, in require_collection
    self.require_collection(name=name, version=version, install=False)
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/ansible_compat/runtime.py", line 725, in require_collection
    raise InvalidPrerequisiteError(msg)
ansible_compat.errors.InvalidPrerequisiteError: Collection 'community.docker' not found in '['/home/runner/.ansible/collections', '/usr/share/ansible/collections']'

For the full output of the action/workflow, see here.
Notes
I've tried around a bit with (neither helped):

adding ansible-galaxy collection install community.docker to the action, output said it was already installed (probably via pip3 install ansible from the action)

adding a requirements.yml including the community.docker collection and
dependency:
  name: galaxy
  options:
    requirements-file: requirements

which didn't help because that would require molecule to start which it doesn't

I don't know if I'm doing something wrong here or if that's a bug with the recent 6.x release. I've had this setup with a few other roles before and it worked, likely with 5.x.

Also tried with explicitly staying at 5:
pip3 install ansible "molecule>=5,<6" molecule-plugins[docker] docker

ansible [core 2.15.3]
  config file = None
  configured module search path = ['/home/runner/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/ansible
  ansible collection location = /home/runner/.ansible/collections:/usr/share/ansible/collections
  executable location = /opt/hostedtoolcache/Python/3.11.4/x64/bin/ansible
  python version = 3.11.4 (main, Jun  7 2023, 11:01:02) [GCC 11.3.0] (/opt/hostedtoolcache/Python/3.11.4/x64/bin/python)
  jinja version = 3.1.2
  libyaml = True
molecule 5.1.0 using python 3.11
    ansible:2.15.3
    azure:23.5.0 from molecule_plugins
    containers:23.5.0 from molecule_plugins requiring collections: ansible.posix>=1.3.0 community.docker>=1.9.1 containers.podman>=1.8.1
    delegated:5.1.0 from molecule
    docker:23.5.0 from molecule_plugins requiring collections: community.docker>=3.0.2 ansible.posix>=1.4.0
    ec2:23.5.0 from molecule_plugins
    gce:23.5.0 from molecule_plugins requiring collections: google.cloud>=1.0.2 community.crypto>=1.8.0
    podman:23.5.0 from molecule_plugins requiring collections: containers.podman>=1.7.0 ansible.posix>=1.3.0
    vagrant:23.5.0 from molecule_plugins

same issue, so maybe molecule-plugins is at fault?
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.4/x64/bin/molecule", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/command/test.py", line 113, in test
    base.execute_cmdline_scenarios(scenario_name, args, command_args, ansible_args)
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/command/base.py", line 119, in execute_cmdline_scenarios
    execute_scenario(scenario)
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/command/base.py", line 162, in execute_scenario
    execute_subcommand(scenario.config, action)
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/command/base.py", line 152, in execute_subcommand
    return command(config).execute(args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/logger.py", line 189, in wrapper
    rt = func(*args, **kwargs)
         ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/logger.py", line 100, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/command/dependency.py", line 40, in execute
    self._config.dependency.execute()
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/dependency/ansible_galaxy/__init__.py", line 86, in execute
    invoker.execute()
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/dependency/ansible_galaxy/base.py", line 118, in execute
    super().execute()
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/molecule/dependency/base.py", line 89, in execute
    self._config.runtime.require_collection(name, version)
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/ansible_compat/runtime.py", line 710, in require_collection
    self.require_collection(name=name, version=version, install=False)
  File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/ansible_compat/runtime.py", line 714, in require_collection
    raise InvalidPrerequisiteError(msg)
ansible_compat.errors.InvalidPrerequisiteError: Collection 'community.docker' not found in '['/home/runner/.cache/ansible-compat/8ed492/collections', '/home/runner/.cache/ansible-compat/8ed492/collections', '/home/runner/.ansible/collections', '/usr/share/ansible/collections']'

This is occurring for me as well.
For a workaround, pinning to the following versions worked for me
pip3 install ansible==8.2.0 ansible-core==2.15.2 ansible-compat==4.1.5 molecule==5.1.0 molecule-plugins[docker]==23.5.0 docker==6.1.3

Also running into this issue starting a day or two ago.

pip3 install ansible==8.2.0 ansible-core==2.15.2 ansible-compat==4.1.5 molecule==5.1.0 molecule-plugins[docker]==23.5.0 docker==6.1.3

tested a bit, miminal version of this is:
pip3 install ansible ansible-core==2.15.2 ansible-compat==4.1.5 'molecule<6' molecule-plugins[docker] docker

Here is a minimal test case to reproduce this issue (while preparing this test case I've found out that the issue had been already submitted):
python3 -m venv /tmp/molecule
/tmp/molecule/bin/pip3 install ansible molecule molecule-docker

mkdir /tmp/role
cd /tmp/role

mkdir -p molecule/default
echo '{driver: {name: docker}, platforms: [{name: instance, image: 'ubuntu:22.04'}]}' > molecule/default/molecule.yml

/tmp/molecule/bin/molecule create

Possible temporary workaround:
export ANSIBLE_COLLECTIONS_PATH=/tmp/molecule/lib/python3.10/site-packages

/tmp/molecule/bin/molecule create

@giner Thanks for the minimal repro.  There was a change in ansible-core 2.15.3 related to ansible-galaxy and it's default behaviour related to installing collections, I think this is related (https://github.com/ansible/ansible/issues/81515)
If I switch to core 2.15.2, we can see the molecule has installed to the collections in my ~/.ansible:
ansible-galaxy collection list

# /home/bthornto/.ansible/collections/ansible_collections
Collection                    Version
----------------------------- -------
ansible.posix                 1.5.4
community.docker              3.4.8

Still digging...........

Additional finding, if only ansible-core is installed and not ansible, the collections included in ansible are not installed into the venv site-packages directory and therefore not found by ansible-galaxy during the install. This results in the collections being installed in ~/.ansible and then found by molecule

@cidrblock
Do we need to add a force parameter in this function?
https://github.com/ansible/ansible-compat/blob/01f044866efab766e61d6a9b38d5bd510d479fe6/src/ansible_compat/runtime.py#L557-L565
Do you need to consider to bring isolated environment back?

@cidrblock
Do we need to add a force parameter in this function?
https://github.com/ansible/ansible-compat/blob/01f044866efab766e61d6a9b38d5bd510d479fe6/src/ansible_compat/runtime.py#L557-L565
Do you need to consider to bring isolated environment back?

Still looking..........getting to know the code. I'm trying to figure out why the ansible-galaxy install command finds the collections installed via ansible into the venv but the compat doesn't.
ansible_compat.errors.InvalidPrerequisiteError: Collection 'community.docker' not found in '['/home/bthornto/.ansible/collections', '/usr/share/ansible/collections']'

I suspect compat is not using the sys paths like core........

I think this is the login compat needs to emulate: https://github.com/ansible/ansible/blob/9afaf2216b0bf38cfbd9a0c93409959f78d01820/lib/ansible/utils/collection_loader/_collection_finder.py#L254  Candidate collection paths include sys.paths unless configured otherwise.  Looking deeper into compat to see where it should go

pin ansible version ansible==8.2.0 ansible-core==2.15.2 is sufficient for me (so ist this really molecule related?)

It seems that ansible-compat 4.1.7 was just released (https://github.com/ansible/ansible-compat/releases/tag/v4.1.7) which has fixed this issue for me.

@milliams thanks for confirming this :)

Works for me as well. @wookietreiber I guess this issue can be closed?


Ensure initial PolyDraw and FreehandDraw data is projected

When the PolyDraw and FreehandDraw stream is initialized the initial data stored in the ColumnDataSource is used to set the .data on the stream. If the data has been projected (as is the case in GeoViews) this initial data will be wrong, which means it needs to be passed through _process_msg first to ensure it is projected first.

The code is under test, and the only way I can test these changes is in GeoViews so this is ready to merge now.

The new calls to super makes sense and the change to initialize seems a reasonable way to allow geoviews to do an initial projection. Merging.


shift + enter broken again ... and again

Issue Type: Bug
Every couple of VS Code updates, this keeps breaking.
https://github.com/microsoft/vscode-python/issues/6578
Yet again... pressing shift + enter after an update gives:
command 'python.datascience.execSelectionInteractive' not found
and does not run the selected code block in the Python Interactive Pane.
Extension version: 2020.11.358366026
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:34:32.027Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.88GB (4.61GB free)

Process Argv
--crash-reporter-id f652528b-5678-4b12-9ca0-3de6b1e1135f

Screen Reader
no

VM
0%

looks like it was replaced with jupyter.execSelectionInteractive
are all of these changes to settings and commands documented somewhere?  A lot of other things have broken in the last update.

I'm sorry the migration (from Python to Jupyter extension) hasn't been very smooth for you.
With regards to the commands, all python.datascience.xyz commands have been renamed to jupyter.xyz.
With regards to documentation, we will look into this, currently our documentation sits in https://code.visualstudio.com/docs/python/jupyter-support

@DonJayamanne Not smooth? Everything's broken on my end and I've spent hours to try to fix everything while getting nothing done. The doc you mentioned is about the notebook UI. How about the interactive window? It would really be great if you guys could give folks a heads-up.

there any plan to support vscode extensions in this new jupyter UI?

Yes, I can confirm that VS Code extensions are supported in the new Jupyter UI (if not please file an issue with VS Code).

@joyceerhl I believe your current PR already this issue.

Dup of #1088


fastapi.security support

Following the FastAPI-SSO documentation, I have managed to configure a working SSO. I had to define a custom SSO provider but it still works perfectly. My current setup includes a login route (redirecting to my OAuth server) and callback route (returning some user information). Next, I would like to somehow integrate my custom SSOProvider into the FastAPI security mechanism. I'm not an expert on this topic but the driving idea seems to be that you inject your auth provider as dependencies into your FastAPI routers/apps (using fastapi.Depends). Does FastAPI-SSO support this mechanism as well?

Hi @lukas-koschmieder and thanks for your question. I am not ignoring it but I've been quite busy and fail to provide you with a full example.
The thing is fastapi-sso doesn't solve login for you, it only solves the part where you authenticate your user with a login provider. What you do next in your application is up to you. What I usually do is create a JWT (using python-jose) and return it in a cookie for the user. Then you can use ApiKeyCookie from fastapi.security as your dependency for protected endpoints which will add the lock icon into your Swagger documentation.
I'll try to come up with a code example ASAP, sorry for keeping you waiting.

@tomasvotava
Hi! Is there already a code example for the login you mentioned?

With the exact speed of 19 characters per day I have finished writing this article. Sorry for taking this long.
https://tomasvotava.github.io/fastapi-sso/how-to-guides/use-with-fastapi-security/
Let me know if that's not sufficient and I'll gladly reopen this issue.


can't log in

hello nandaka, i updated to last version just now but i keep ketting
Error at doLogin(): (<class 'mechanize._response.get_seek_wrapper_class..httperror_seek_wrapper'>, <httperror_seek_wrapper (urllib.error.HTTPError instance) at 0x3b6fdf0 whose wrapped object = <HTTPError 302: 'The HTTP server returned a redirect error that would lead to an infinite loop.\nThe last 30x error message was:\nFound'>>, <traceback object at 0x042AD408>)
Cannot Login!
what i tried
i tried relogon web pixiv on chrome and copied cookie
i tried relog with firefox and copy the cookie again
i re entered my loginin in the pixivuntil settings, but no luck

delete the old log file pixivutil.log
re-run the application
upload the log file here (zip it if required).

upload cookie string?

update cookie string?

1. delete the old log file `pixivutil.log`

2. re-run the application

3. upload the log file here (zip it if required).

it don't re-create log,
i also tried a clean pixivuntil extracted from zip but same reaction, and i run as admin
im not handy with cmd/powershell,
last time when this happends i could run it trough a powershell version,
but i cant find out how i did that
i also tried a virtual machine on the nas and i get same error , and no log file

update cookie string?
by cookies you you mean the PHPSESSID ? if so yes, i logged out, and relogged, copied the cookie and pasted it in the config of pixiv until

hmm. did you get the cookie from the logging in action? or from a valid request to pixiv.net after you logged in?
i think sometimes they might be different, but not so sure...
and as for logs, is the loglevel in your config set to DEBUG? if not try setting it toDEBUG.
also the log files are usually in the same folder of the PixivUtil2.exe, try looking for it there?

see https://github.com/Nandaka/PixivUtil2/wiki/IDE-Enviroment-(Windows) for running from source code.

I'm getting the same error on startup, here's my own logfile of the error:
pixivutil.log

Hmm, try to set your pixiv language to english?

No dice, still get the same error after updating my language setting.

btw, do you update the user agent too when updating the cookie? both must be matching with the browser that you get the cookie from.

Useragent was still identical when I checked my browser, but it looks like maybe something was jacked with the session- just to see if it did anything I manually logged out of pixiv and then logged in, then put the new session ID into my config file and it's back working again. Perhaps it needed some kind of session refresh after changing the language setting? Either way, thanks for the help!


feat: Add UI for when in localMode

Add some UI for when we are in localmode.
Might clean up the code a bit (see todo's), but from a styling perspective, should be ready for @spbyrne

TODO:

[ ] Styling from @spbyrne (and replace (i) with info icon, or link to docs)
[ ] Consider abstracting isLocal check.
[ ] Create docs page detailing local-mode, vs prod-mode, and update the link.

fixes #2290

@jamespohalloran if you run yarn from the root of the monorepo (or merge main back into this) the tests should pass.

@spbyrne already removed my wonderful fuschia styles 😭 😉 , so it should be good to go on that front!


Make sure xodr and xosc crash when exception occurs

xodr::parse() and xosc::parse() should crash when an exception occurs. If exceptions are caught, then software that uses ad-xolib as a library will have no way of knowing what went wrong in the call stack.
Therefore I moved the try/catch statement to the appln/main_xxx files instead.

Guide-Post doesnt seem to be a valid enum from the xsd of opendrive ?
The code is autogenerated and any further regeneration will override the changes.
Could you please submit a merge request without the guide-post change will go ahead and merge it.,.

I've removed the guide-post commit now. Just out of curiosity, what method do you use to autogenerate the code?


Unable to change temperature on altantic thermostats

Did you read the instructions?

[X] I have read the README, including the advanced debugging section.

The problem
Hello,
I have an Atlantic installation in my home with a bridge cozytouch.
With Overkiz integration, I am able to switch on/off all climates in my house.
But now I can't change temperature with this integration
What version of this integration (ha-tahoma) has the issue?
2.13.0
What version of Home Assistant Core has the issue?
core-2022.5.3
Which gateway / hub do you use?
Cozytouch
Device model
No response
Home Assistant log
Logs
2022-05-10 07:07:18 DEBUG (MainThread) [custom_components.tahoma] Finished fetching device events data in 0.098 seconds (success: True)
2022-05-10 07:07:48 DEBUG (MainThread) [custom_components.tahoma] Finished fetching device events data in 0.100 seconds (success: True)
2022-05-10 07:08:18 DEBUG (MainThread) [custom_components.tahoma] Finished fetching device events data in 0.102 seconds (success: True)
2022-05-10 07:08:48 DEBUG (MainThread) [custom_components.tahoma] Finished fetching device events data in 0.098 seconds (success: True)
2022-05-10 07:09:18 DEBUG (MainThread) [custom_components.tahoma] Finished fetching device events data in 0.097 seconds (success: True)

Additional information
No response

Can you download your diagnostics information (from the device page of the device that doesn't work) and than drag and drop it here in a new comment.

@YomoShitsu and for which one can't you set the temperature? I see a lot of climate entities, which one  is 'broken'?

All are broken. I can't set temperature for all...
But I can switch off/on all of them

What is the error you get? Or is it just not available? Can you add a screenshot of the climate card in the dashboard + pop-up.

I don't see any error or pop up...
when I changed temperature with my iOS Cozytouch app it doesn't sent information to home assistant. But when I switch off my climate since iOS app, it switch off it on home assistant.

And I have only two days of logbook...

Hi @iMicknl did you get some news about my issue ?
Regards

Hi guys !
Does anyone got some news about my issue ?
Ni answers since 14 days...

Sorry, our free time currently is limited, and we are focused on backported (slowly) this custom component to HA directly.
About https://github.com/iMicknl/ha-tahoma/issues/805#issuecomment-1126046645, if you restart your HA instance do you see the states refreshed?

Hello sorry for later answer...
No it doesn't work anymore

Cette erreur provient d'une intégration personnalisée
Logger: custom_components.tahoma
Source: helpers/update_coordinator.py:151
Integration: Overkiz (by Somfy) - Custom component
First occurred: 13:20:09 (1 occurrences)
Last logged: 13:20:09
Error fetching device events data: Too many requests, try again later.

Hi guys !
Any news about my issue ?

I saw a new thing :
If my Zone Control is in heat mode your extension works like a charm. But when I put it in fresh mode, it doesn't works.
Any idea ?

Last version of Kubernetes up to date
Same issue with cool mode
But integration works with heat mode

@YomoShitsu please update to 2022.12 in core (public beta now, or release in a few days). This will include the AtlanticPassAPCZoneControl. You can now use the core integration and report a bug in https://github.com/home-assistant/core/issues, when you still face issues.


MONet does not save the memory used by PyTorch

Hi, thanks for the awesome library.
How do you measure the used memory? Is it emperically measured or is it theorically computed?
I measured the memory usage by nvidia-smi and found MONet does not save the memory used by PyTorch.
First, I run the 10GB solution by python3 imagenet.py ~/imagenet -a resnet50 --gpu 0 --epochs 1 --batch-size 184 --sol ../data/monet_r50_184_24hr/solution_resnet50_184_inplace_conv_multiway_newnode_10.00.pkl. The peak memory reported by nvidia-smi is around 12GB.
Then, I run the  6GB solution by python3 imagenet.py ~/imagenet -a resnet50 --gpu 0 --epochs 1 --batch-size 184 --sol ../data/monet_r50_184_24hr/solution_resnet50_184_inplace_conv_multiway_newnode_6.00.pkl. The peak memory reported by nvidia-smi is still around 12GB.
How to use MONet to actually save the memory used by PyTorch?

Thanks for the comments.
We measured the used memory using torch.cuda.memory_allocated. This gives us the total memory used by the tensors in PyTorch. nvidia-smi, on the other hand, shows the total GPU memory used by the system.  The difference between the two is because PyTorch's caching memory allocator does not release GPU memory to the system after tensors are deallocated. While this design works well for DL workloads in general, it is not great for checkpointing because the memory of the deallocated tensors needs to be explicitly returned to the system in most cases.
We noticed that allocating a tensor pool the size of the expected memory usage goes a long way in bringing the actual system memory used close to the total memory used by PyTorch tensors. This can be done from the Python code by adding the following lines before the training loop:
pool = torch.zeros(expected_memory/4).cuda()
del pool

Added an explanation about this in the README. Closing this issue now.


Document should also list out the dependency to utilize this with major build tools like maven and gradle

Document should list the dependency to added as part of the instructions to use the storage libraries:
Maven dependency:

com.microsoft.azure
azure-storage
LATEST

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c3256c30-31d3-382e-0cc5-70d861ecc5cd
Version Independent ID: e9c9cb31-96a4-0eae-700a-05ddf8f2e93e
Content: How to use Queue storage from Java - Azure Storage
Content Source: articles/storage/queues/storage-java-how-to-use-queue-storage.md
Service: storage
Sub-service: queues
GitHub Login: @mhopkins-msft
Microsoft Alias: mhopkins

@Ankzz
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@mhopkins-msft
Can you please check and add your comments on this doc update request as applicable.

Hi @Ankzz
We are currently in the process of updating all the Storage documentation to include support for the new v12 libraries. This topic is already included in our plans and should be updated soon.
For more information on using Maven with the Java v12 libraries, please see Quickstart: Azure Queue storage client library v12 for Java.
Thanks for your feedback!
~ Mark
#please-close


Hibernate Abort improvements

fixed logging and return in case of late abortion
quicker for multi process plugins

Remaining part looks like a good improvement!

Saw you addressed my review remarks for the master, so happy to take this to 4.4. Just need to discuss if this can go in during the next QA cycle!

Thank you Pierr for your review,  indeed I made it for master first to be sure unit tests pass.  I am good to wait with this merge, no rush here, lets follow QA cycle

Hi Pierr,  since we are a bit in hurry to close some tickets, can we merge this change by end of this week?

@MFransen69 can we add this to the 4.4.2 upcoming release a new tag? Or should we take it up in the next QA cycle? I do think there are some minor risks in there that would opt for a QA cycle. So my sugegstion would be in the next QA cycle?
@adrianM27 we could still merge it (but it will not be part of the 4.4.2 tag), we have no QA tests for Hibernation so we will not test the majority of the patch anyway but some code is in shared functionality (locks that where moved) So I do think that QA on this has benefits. We can always merge it and you could use it b using the commit hash of the new tip of the 4.4 branch. Than it will be tagged with the new QA release if we have more issues we need to fix on 4.4..

Hi @pwielders / @MFransen69  do we have any potential ETD for this PR?

Hi @pwielders / @MFransen69 do we have any potential ETD for this PR?

Hi @adrianM27 , I leave it up to @pwielders to merge this, that could be done now as we have 4.4.2. out of the door. If it is merged it will be part of 4.4.3, when that will be released we will have to discuss with Comcast.


added settings page

Description
Fixes #340

Type of change
Just put an x in the [] which are valid.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.

[x] ./gradlew assembleDebug assembleRelease
[x] ./gradlew checkstyle

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@aayushinigam

Resolve the merge conflicts
Move, Show my unread notifications to top.
Add a horizontal seperator after that, and then show confirm password
Add eye icon to password fields

It's show my read notifications right?

@aayushinigam Yes. My bad!

Also, just to clear up, umm I should move show my read notificatiobs to top most?
Or between New Password and Confirm Password?

@aayushinigam Top most

Is this okay?

Is this okay?

Just change the color of seperator to orange. Then, you can update the PR.


Ticket #306: Backport thread local storage

This makes thread local storage available to older versions of libuv as well.  It is essentially a backport of libuv/libuv@5d2434bf71e47802841bad218d521fa254d1ca2d, written by Ben Noordhuis.  But the names were changed, and the functions were turned into inline functions to avoid having the same non-inline function in multiple translation units.  The test is a lot more node-based, even if the things to test more or less follow those tested in libuv.

@bnoordhuis You seem qualified to check it. It seems alright to me. Nice with passing tests too.

LGTM with a suggestion.

Thanks. It will be out in 1.8.0, but I don't know when that is.


How can I get the Hounsfield units with the given float values in abdominal CTs

Dear organizers,
Thank you for the great challenge datasets!
I notice that in the abdominal CTs, the array values are float in [0,1] instead of int as Hounsfield units, which is the first time for me to get this kind of data. Though I could visualize it with 3D slicer or ITK snap, I still wonder the window level and window size used to convert HU into 0~1?
Or can I get the window level and window size in the nifti header?
Thank you very much!
Jiancheng Yang

Hi,
I'm sorry but I can not tell you any details regarding our preprocessing.
I hope this will not present you with any problems.
Cheers,
David


resource/cloudflare_page_rule: Swap cache_key_fields to use TypeSet

When this resource was introduced, it was done so using TypeList for
the inner structure. In Terraform, TypeList is used for ordered lists
whereas TypeSet is for unordered.
This was working for the most part however the cache_key_fields fields
don't place any importance on the order so they are returned from the
API with inconsistent ordering.
To address this issue, we need to swap the representation to be
TypeSet and ignore any changes in the ordering when comparing to the
state. With this internal change comes more test coverage -- please take
a look at the test cases and ensure they match our expectations of the
defaults and functionality.
Fixes #890

integration suite is now green
$ [...] go test -timeout 120s -v -count=1 -run "^(TestCacheKeyFieldsNilValue|TestAccCloudflarePageRuleCacheKey)" github.com/cloudflare/terraform-provider-cloudflare/cloudflare
=== RUN   TestCacheKeyFieldsNilValue
--- PASS: TestCacheKeyFieldsNilValue (0.00s)
=== RUN   TestAccCloudflarePageRuleCacheKeyFieldsBasic
--- PASS: TestAccCloudflarePageRuleCacheKeyFieldsBasic (3.19s)
=== RUN   TestAccCloudflarePageRuleCacheKeyFieldsIgnoreQueryStringOrdering
--- PASS: TestAccCloudflarePageRuleCacheKeyFieldsIgnoreQueryStringOrdering (2.94s)
=== RUN   TestAccCloudflarePageRuleCacheKeyFieldsExcludeAllQueryString
--- PASS: TestAccCloudflarePageRuleCacheKeyFieldsExcludeAllQueryString (3.00s)
=== RUN   TestAccCloudflarePageRuleCacheKeyFields2
--- PASS: TestAccCloudflarePageRuleCacheKeyFields2 (3.28s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	12.731s

integration suite is now green
$ [...] go test -timeout 120s -v -count=1 -run "^(TestCacheKeyFieldsNilValue|TestAccCloudflarePageRuleCacheKey)" github.com/cloudflare/terraform-provider-cloudflare/cloudflare
=== RUN   TestCacheKeyFieldsNilValue
--- PASS: TestCacheKeyFieldsNilValue (0.00s)
=== RUN   TestAccCloudflarePageRuleCacheKeyFieldsBasic
--- PASS: TestAccCloudflarePageRuleCacheKeyFieldsBasic (3.19s)
=== RUN   TestAccCloudflarePageRuleCacheKeyFieldsIgnoreQueryStringOrdering
--- PASS: TestAccCloudflarePageRuleCacheKeyFieldsIgnoreQueryStringOrdering (2.94s)
=== RUN   TestAccCloudflarePageRuleCacheKeyFieldsExcludeAllQueryString
--- PASS: TestAccCloudflarePageRuleCacheKeyFieldsExcludeAllQueryString (3.00s)
=== RUN   TestAccCloudflarePageRuleCacheKeyFields2
--- PASS: TestAccCloudflarePageRuleCacheKeyFields2 (3.28s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	12.731s

@patryk this is ready for a re-review when you have some time

@patryk this is ready for a re-review when you have some time


Add a --small option to windows_setup.sh

Fixes #310

That's great!

@littlewhitecloud With ./windows_setup.sh --small, the mingw download is about 60MB instead of 260MB. So with your internet connection, downloading it is going to take about 55 minutes instead of 4 hours. Not great, but not anywhere near as bad as before :)


.tabs does not work with -a

It looks like that when the cli is run with crconsole -a ...(ip address), it is falling back to use localhost.
node_modules/crconsole/index.js:667
      if (err) throw err;
               ^

Error: connect ECONNREFUSED <IP_ADDRESS>:9222
    at Object.exports._errnoException (util.js:890:11)
    at exports._exceptionWithHostPort (util.js:913:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1059:14)

This patch should fix the issue.

lgtm, thanks!


GCP Auth Provider missing

Health checks on kubernetes.nodes healthgroups are returning: "Cannot create kubernetes client: No Auth Provider found for name "gcp"
Don't know if this is related to https://github.com/hashicorp/terraform/issues/15244 where the gcp auth provider is an optional dependency.
Ref: https://github.com/kubernetes-incubator/descheduler/issues/93#issue-325093488

I added _ "k8s.io/client-go/plugin/pkg/client/auth" to the import section, rebuilt and am now hitting the kubernetes api as expected.

Thanks !

Have the same issue with Azure:
Cannot create kubernetes client: No Auth Provider found for name "azure"


fw_att_control: fix airspeed subscription and validity check

fixed airspeed subscription that was not polling new updates properly resulting in the timestamp constantly =0 (as well as all other members of the airspeed struct)
replaced unsigned integer subtraction with doubles on airspeed last update check

Without these fixes, the airspeed scaling would not be active (assumes the trim value when the airspeed update was "invalid"). Also, this keeps the subscriptions all defined in a consistent manner.

This was intentionally ugly to encourage moving things towards the newer uORB c++ wrappers that are usually safer and easier to use. I'll debug this to see where it's broken.

The core problem here is that fw_att_control_main allocates the FixedwingAttitudeControl (where _sub_airspeed is constructed), then kicks off the task to actually run. The file descriptor within the Subscription is wrong.
I'll quickly convert fw_att_control to use ModuleBase, where it's easier to not make these errors.

@tstastny https://github.com/PX4/Firmware/pull/8899 fixeds your issue and gets rid of more unnecessary module boilerplate.

Addressed in #8899


Migrate to Native Craft 5 2FA?

I've done a bit of exploration here but is it possible at all to migrate or convert existing users 2FA codes over to Craft 5's native 2FA implementation? Or will I need to just uninstall this plugin and let them re set up 2FA from scratch. A lot of effort was put into getting users on board with this plugin here, so trying to minimize and disruptions to users in that regard if possible.

The implementation of Craft seems to be a lot nicer, so i prefer not to mess with that. My advice would be to uninstall the plugin and let users setup 2FA with Craft itself, which is pretty straight forward when 2FA is enforced.


Textbutton over-offset

Sorry if this is the wrong place, but couldn't find anywhere else. Saw that there was a label for feature requests so here I go;
It would be nice (and probably not too big a hurdle maybe?) to have an offset for when a TextButton is hovered, similar to how there's one for pressed, checked, unpressed.
Looking through the source, checks using the isPressed() methods, then sets offset according to the button style. There is a isOver() method as well, so I was surprised when I didn't find a over-offset.
It was easy enough to work around but I feel like it would fit in with the other offset options.
Again if this is the wrong place, feel free to delete this, and I apologize in advance.

I think this is reasonable. It would go in Button.ButtonStyle (not TextButtonStyle). The logic in Button#draw becomes:
float offsetX = style.unpressedOffsetX, offsetY = style.unpressedOffsetY;
if (!isDisabled()) {
	if (isPressed()) {
		offsetX = style.pressedOffsetX;
		offsetY = style.pressedOffsetY;
	} else if (isChecked()) {
		offsetX = style.checkedOffsetX;
		offsetY = style.checkedOffsetY;
	} else if (isOver()) {
		offsetX = style.overOffsetX;
		offsetY = style.overOffsetY;
	}
}

This has a subtle difference: if not pressed and not checked, you get the over offset rather than the unpressed offset. That makes this a breaking change for apps that don't use 0 for unpressed offset. 0 for that is common, but the potential is there.
If everybody else is OK with that, I think it's OK.


Determinate progress ring doesn't go to 99%

Describe the bug

Steps to reproduce the bug

Steps to reproduce the behavior:

Go to '...'
Click on '....'

Expected behavior

Actual behavior

Screenshots

Version Info

[x] App downloaded from Store

If so, which version? (Found on the Settings page of the app.) <IP_ADDRESS>

[ ] App built locally from source

If so, which branch? (WinUI 3 versions are built off the winui3preview branch)

Additional context

Windows 10 version:

[ ] Insider Build (xxxxx)
[x] May 2020 Update (19041)
[ ] November 2019 Update (18363)
[ ] May 2019 Update (18362)
[ ] October 2018 Update (17763)
[ ] April 2018 Update (17134)
[ ] Fall Creators Update (16299)
[ ] Creators Update (15063)
[ ] Anniversary Update (14393)

Device form factor:

[x] Desktop
[ ] Mobile
[ ] Xbox
[ ] Surface Hub
[ ] IoT

and when the progress ring is at 100% it looks weird

CC: @MarissaMatt - is this an issue with the Gallery or the ring? It seems like an issue with the ring to me. 💍

Dupe of: https://github.com/microsoft/microsoft-ui-xaml/issues/3787


Close minimal style NavigationPane from PaneItemAction.onTap()

Is your feature request related to a problem? Please describe.
As some of my NavigationPane items push to the navigation stack instead of changing the NavigationView content, I would like to be able to close a minimal style NavigationPane. Currently the pane stays open after navigation, it is noticeable when you navigate back.
Describe the solution you'd like
I would like to be able to close the minimal style NavigationPane programatically.
Describe alternatives you've considered
None, I could not find any.
Additional context
Add any other context or screenshots about the feature request here.

You can change the pane display mode with simple state management. You can see an example of how to do it on the example app: https://github.com/bdlukaa/fluent_ui/blob/master/example/lib/theme.dart


How get Source directory with Delphi?

How to get the source path with this component suite? For example: I dropped file (virtual file) from my app to the desktop. I only need then source path i.e: Desktop. How to get this path before call DropFileSource1.Execute?
Here is my code on ListView1MouseDown procedure:
ipwFTP1.LocalFile :=source path+'salam.txt';

i think, it is not possible to detect, what the target application do with your dragged object.
https://stackoverflow.com/questions/16941088/how-to-detect-target-when-i-drag-from-qt-application-and-drop-to-windows-explore


perf(examples): speed up the test-info report

Please assign this task to me
Is your feature request related to a problem? Please describe.
The test-info tasks takes almost a minute to complete.
Describe the solution you'd like
I want to see if there is a more efficient way implement the task.
Describe alternatives you've considered
I considered leaving it alone, but it's kind of ugly.
Additional context
N/A

PR ( #1447) is ready for review.


work on wiki

go to the wiki of the repo and summarize the current strategy to solve this problem.

I started to structure the Wiki. Would be useful if you could edit the section relating to the issue you're working on.


feat(scripts/training): training script to run over all models, all dataset sizes, hyparparam optimize for final results

Tagging @strsamue here, please let me know if you need more information

Short Update: I am working on it but I have to generate a model class first with the training tuning and evaluation method. so it takes a bit.

Thank you for the update @strsamue ! Ah I see, so the models in nmrcraft/models don’t work for that purpose?

no i was thinking more of something like this:
class Classifier:
def init(
self,
model_name="random_forest",
max_evals=1
target="metal"
dataset_size = 0.01
feature_columns = [
"M_sigma11_ppm",
"M_sigma22_ppm",
"M_sigma33_ppm",
"E_sigma11_ppm",
"E_sigma22_ppm",
"E_sigma33_ppm",
]
):
model_config=model_configs[model_name]
    self.tuner = HyperparameterTuner(model_name, model_config, max_evals)

    self.X_train, self.X_test, self.y_train, self.y_test = DataLoader(feature_columns=feature_columns, target_columns=target, dataset_size=dataset_size).load_data()

def hyperparameter_tune(
    self
):
    log.INFO(f"Performing Hyperparameter tuning for the Model ({self.model_name})")

    #DATA LEAKAGE!!! MUST be done by CV!!!!
    self.best_params, _ = self.tuner.tune(self.X_train, self.y_train, self.X_test, self.y_test)

def train():
    model_func = lambda **params: load_model(
        model_name, **{**params, **self.model_config}
    )

    self.model = model_func(**self.best_params)
    best_model.fit(self.X_train, self.y_train)

def evaluate():
    metrics, cm, fpr, tpr = model_evaluation(best_model, X_test, y_test)
    return metrics, cm, fpr, tpr

what do you think?

Hi @strsamue ,super, thanks a lot for this! It’s super nice to have a class like this. Could you maybe start a draft pull request so that we can look in to it?

I try to do it in the evening or tomorrow ;)

Thank you; feel free to submit a “raw” draft pull request or publish the branch for us to take a look :)

Can you elaborate on the errors you received and where exactly you require help for finishing this part of the script? We are running out of time and really need this part of the script to work, to proceed and write down our results. We need this before we can finalize the report and the poster. Thank you for letting us know asap @strsamue .

sorry completely forgot to upload the picture here you go:

so if you get this to work then the roc should be done (might need to debug some small things), the rest of the plots can be added to the visualizer rather quickly I think, and then only formatting is needed

@strsamue  Found the issue. max_evals (int=10)  was passed to the declaration of the Hyperparameter tuner, it needed to be changed to use the default value of self.algo. There was also another bug of passing the model_config to the Classifier class. The code runs for me now and is able to log the necessary results; the evaluation needs to be checked and cleaned though (I mostly commented it out for the time being, and had some issues installing kaleido via poetry/pip). In the end, we need to plot in the format for the poster and report (matplotlib pyplot).
Please check the draft PR #49.

Perfect thanks for finding the error! I'll have a look at the evaluation ;)

I got the bootstrapping working only need to add the errorbars😉 maybe i got time tonight or tomorrow😉

Amazinggg! Thanks so much 👍👍

Cose still needs some cleaning up but it works. We get this out. Did not run it yet with lots of tuning etc. will do that at home.

Pass das so?

Super super nice, vielen Dank dir! Should we open a PR to review ?

Which target is this by chance? With the confusion matrix, we had the issue that the targets X1, X2, X3, X4 didn’t work as only chloride was chosen all the time (“dummy classifier”)


Add support for Python 3.8

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1956
Originally created by @elohmrow on 2020-04-17 20:17:32

In the requirements it is stated "Python 3.6.1+", but Python 3.8 fails (at least) because there's a hard-coded dependency to psycopg2 (2.7.7).  But the earliest psycopg2 release supporting python 3.8 is 2.8.4.

View 6 previous comments from the original issue on GitLab


Guardrail for MCNP_Problem.write_to_file()

New function signature:
def write_to_file(self, new_problem, overwrite=False):
    """
    :param overwrite: Whether to overwrite the file at 'new_problem' if it exists
    :type overwrite: bool
    """
    . . .

Describe the solution you'd like
Check for the existence of the file new_problem, and do not overwrite it unless overwrite=True.
One solution: simply raise an error.
if overwrite or not os.path.exists(new_problem):
    # write the file as normal
    return
elif os.path.isfile(new_problem):
    raise FileExistsError(new_problem)
elif os.path.isdir(new_problem):
    raise IsDirectoryError(new_problem):
. . .

Describe alternatives you've considered
Or, if the file exists and overwrite == False, back up the original file with some sort of identifier, and then write to the requested filename.
UUID:
def get_backup_fname(new_problem):
    base_name, extension = os.path.splitext(new_problem)
    unique_id = uuid.uuid4()
    new_fname = f"{base_name}_backup_{unique_id}{extension}"
    return new_fname

Timestamp:
def get_next_backup_fname(new_problem):
    base_name, extension = os.path.splitext(new_problem)
    timestamp = int(time.time())   # OR use strftime('%Y%m%d%H%M%S') for human-readable
    new_fname = f"{base_name}_backup_{timestamp}{extension}"

    # If user going faster than one file per second
    index = 1
    while os.path.exists(new_file):
        new_file = f"{base_name}_backup_{timestamp}_{index}{extension}"
        index += 1

    return new_fname

Additional context
Related to pyOpenSci review here: https://github.com/pyOpenSci/software-submission/issues/205#issuecomment-2218837269

Ok I see value in this. I think I'd prefer to just error out rather than creating new files that user wasn't expecting.


Ports FROM & UNPIVOT mistyping cases from #112

Fixes FROM and UNPIVOT mistyping cases (as specified in the PartiQL Specification).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing for #123


fix plotting in separate block

Codecov Report

Merging #366 (866594d) into master (5f0ae4e) will decrease coverage by 0.72%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   87.51%   86.78%   -0.73%
==========================================
  Files          17       17
  Lines        1962     2051      +89
==========================================
+ Hits         1717     1780      +63
- Misses        245      271      +26

Impacted Files
Coverage Δ

src/simplex_oracles.jl
90.24% <75.00%> (-2.07%)
:arrow_down:

src/utils.jl
79.87% <94.44%> (-1.61%)
:arrow_down:

src/moi_oracle.jl
80.70% <0.00%> (-5.84%)
:arrow_down:

src/blended_cg.jl
83.28% <0.00%> (-1.95%)
:arrow_down:

src/abstract_oracles.jl
86.66% <0.00%> (-0.59%)
:arrow_down:

src/pairwise.jl
87.58% <0.00%> (-0.50%)
:arrow_down:

src/polytope_oracles.jl
91.91% <0.00%> (-0.39%)
:arrow_down:

src/linesearch.jl
90.79% <0.00%> (-0.29%)
:arrow_down:

src/types.jl
84.95% <0.00%> (-0.10%)
:arrow_down:

... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Support SharedArrayBuffer please :)

it was always the plan but I ran out of steam on the project I was using this for. I'd still like to add it but with SAB being spectred out of browsers the only target would be node :(

and can we even rely on SharedArrayBuffer sticking around in V8 if chrome doesn't use it any more?

@phpnode hey, nice to see you here!
I specifically want to use it or Node.js since workers landed.
I want to use this package to build thread-safe data structures for Node.js using the experimental --worker flag since I needed an allocator :)

and can we even rely on SharedArrayBuffer sticking around in V8 if chrome doesn't use it any more?

@bmeurer is it safe to say "yes"?
Also, as far as I know, SharedArrayBuffer isn't going anywhere and there are plans to re-enable it in the future in Chrome.

Hey @benjamingr! it would be possible to make the existing implementation work with SAB simply by changing every store and load to an Atomics.store() and Atomics.load() but I suspect it would be horribly slow.
This paper describes a supposedly practical lock-free skiplist which might be worth looking at: http://www.cl.cam.ac.uk/techreports/UCAM-CL-TR-579.pdf

This paper describes a supposedly practical lock-free skiplist which might be worth looking at: http://www.cl.cam.ac.uk/techreports/UCAM-CL-TR-579.pdf

That's cool, I think initially just putting a hook around malloc/free would be enough for starters :)

Making the alloc() and free() calls thread safe is one thing but there's also the question of how to safely write and read within those allocated chunks. Maybe that's a concern to be left to other libraries though?

btw this was the project that built on top of this library, sounds broadly similar to what you need (not threadsafe though sadly) https://github.com/codemix/reign

Maybe that's a concern to be left to other libraries though?

Yes, I think it is - libraries can use Atomics themselves (at least I was anticipating so) for the read/write. The important part is to have the SharedArrayBuffer shared between the workers - it's fine (for me) if only one worker can allocate/free memory and then pass that to the other workers.


Flush of one table might be triggered multiple times

Describe This Problem
Flush is checked on the write path preprocess_write(). That method has three conditions to trigger a flush: should_flush_instance, should_flush_space and should_flush_table. When memory usage reached the threshold in the instance or space level a flush is then triggered. Consider two tables belonging to two different WorkerLocals, they can trigger the flush in the instance or space level simultaneously, while these two flushes are likely to operate on the same table because of the logic of selecting tables.
To my understanding, the procedure described above may lead to two problems:

A table may be flushed multiple times.
A table may be operated by another WorkerLocal which will break our concurrent invariant "The worker is single threaded and holding this is equivalent to holding a write lock"

Proposal
The key points are

Can we select and operate tables belonging to other workers?
We can select and schedule a flush for any table, but are only allowed to operate tables belonging to the correct worker.
Should we ignore memory occupied by memtables that are flushing?
should_flush_table will distinguish these memories https://github.com/CeresDB/ceresdb/blob/91553aae4d446b4a3f31aa6e211ae1ffb592576f/analytic_engine/src/table/data.rs#L381 Trigger in instance and space levels can have the same logic.

Additional Context
No response

assign me!😆


Should "loss of smell" be added to the test

@tconley , can you ask the expert about adding a question?
See  https://www.nytimes.com/2020/03/22/health/coronavirus-symptoms-smell-taste.html

waiting for point value response from the doctors

loss of smell/taste has been added


Initial Pathology SDK v2 API support

Support for the new Philips Pathology SDK v2 API.
The API is substantially different from v1 to v2 so the METADATA.json will not be the same following the merge of this PR. The only difference when using v1 with this PR is that DICOM acquisition date is now an ISO formatted string.

With 1.2.1 I see:
$ isyntax2raw write_tiles 1.isyntax 1.v1
Traceback (most recent call last):
  File "/usr/local/bin/isyntax2raw", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.5/dist-packages/isyntax2raw/cli/isyntax2raw.py", line 80, in main
    cli()
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/isyntax2raw/cli/isyntax2raw.py", line 70, in write_tiles
    wt.write_metadata()
  File "/usr/local/lib/python3.5/dist-packages/isyntax2raw/__init__.py", line 396, in write_metadata
    'sizeX': int(self.label_x),
AttributeError: 'WriteTiles' object has no attribute 'label_x'

1.2.1 working fine again with the latest commit, and nothing concerning in the diff.

Yep, the only difference should be the ISO formatted datetime for DICOM acquisition date with v1. Added that also to the PR description.

Tested with v2 as well, including running raw2ometiff on the output.  No obvious issues, so I'm fine with this being merged.


Make phasing of multiple variants on a read explicit (group reads into phase groups)

https://www.dropbox.com/s/driavq5spauad64/Screenshot 2016-12-13 15.47.17.png?dl=0

Instead of having a variant associated with protein sequences we should instead have something like PhaseGroup(somatic_variants, germline_variants)

Combining variants into phase groups was part of the original plan: https://github.com/hammerlab/isovar/issues/3

(This would likely involve taking germline variants as input.)


UICollectionViewFlowLayoutBreakForInvalidSizes

Hello brother,
Long time, hope you are doing well
I got this error, I am trying to catch the issue but with no result, do you have any idea?

The relevant UICollectionViewFlowLayout instance is <UICollectionViewFlowLayout: 0x7fcf1e4ab300>, and it is attached to <UICollectionView: 0x7fcf20a27000; frame = (0 0; 375 812); clipsToBounds = YES; gestureRecognizers = <NSArray: 0x600000651790>; layer = <CALayer: 0x60000043f960>; contentOffset: {0, 0}; contentSize: {0, 0}; adjustedContentInset: {0, 0, 34, 0}> collection view layout: <UICollectionViewFlowLayout: 0x7fcf1e4ab300>.
Make a symbolic breakpoint at UICollectionViewFlowLayoutBreakForInvalidSizes to catch this in the debugger.

Solved by this line of code to be added in viewDidLoad
if (@available(iOS 11.0, *)) {
        pagingView.horizontalCollectionView.contentInsetAdjustmentBehavior = UIScrollViewContentInsetAdjustmentNever;
    }