Feature request: setting the default state of the "Toggle Word Wrap" option

I use "editor.wordWrap": "wordWrapColumn" and "editor.wordWrapColumn": 120 and that is perfect but I would love for files to not open with word-wrap applied. That's what the "Toggle Word Wrap" option is for. I only occasionally need to actually wrap the source code for better reading long-lines but, more often than not, I don't use the wrapping. Can an option like "editor.toggleWordWrap": true/fase be added?

@stefangabos Would my proposed settings in #38303 solve your issue?

yes, that's better explained than here.
discussion moved to #38303


fix when estimated rowCount is 0, adjust to 1

Proposed changes
if we use zero, it may cause upper joins in any order. but if we use 1, upper join orders could be more reasonable.
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Changing default wallpaper to vanta waves to vanta net

Nice twist. Job well done firstly,
I have tried to change wallpaper to vanta waves to vanta net. But copying  dist vanta.net.min.js ( in vanta github) to the vanta.waves.min.js gives black wallpaper. I believe the problem is some waves variables doesn't return valid with dist net.min.js code. Should i have to change everything in config related to waves or is there much easy way to do it ?

Is there any errors in the console? With Vanta I had to upgrade it to work with the latest Three.js. Also the waves config settings might need changing.

No error when running server. Just black screen. Min js is from vanta github.

Now that I think of it, ya you would need to change quite a bit to have it run in a worker which is what it's trying to do. I got it working by removing VANTA from the WALLPAPER_WORKERS constant so it never runs in a worker. Also in vantaWaves/index.ts you need to change references of WAVES to NET. Finally I had to replace my three.min.js which is very slimed down, with a full version of r148. It could probably look nicer if I also tweaked the config, but I left it untouched as it runs.


Having an issue trying to convert an async function

I am using the JS package, and when trying to convert a method, I am encountering issues. The method has four parameters, one of which is a function called complete which is called at the end to finish everything.
The syntax in JavaScript is as follows:
async (result, errors, complete, logs) => {
    // await a call to the BE
    complete();
}

The syntax I have used in Flutter is as follows:
import 'dart:js' as js;

js.allowInterop(
  (result, errors, complete, logs) async {
    // await a call to the BE
    complete();
  },
);

When I use plain JavaScript, it works without any issues. However, when I use the Dart function, I am getting this error: "Uncaught TypeError: T[_eval] is not a function". I haven't had issues before with async functions so I am not sure what the issue might be.
This documentation might help with the method I am trying to parse: https://docs.getnuvo.com/sdk/results

That error looks like it's related to the RTI, but is general enough that it's hard to tell where the error is coming from. Is there a simple repro/your Dart code you can add here?
One thing that I suspect may be an issue (although may not be the current issue) is that with JS, the async function returns a Promise, whereas with a Dart async function, it returns a Future<void>. Any code that assumes that that function returns a Promise might not work. Converting the resulting Future<void> to a JSPromise using dart:js_interop's toJS could work, but I'd need to see the code to figure out where that should go.

@srujzs Thanks for the response. I checked the scenario with toJS but didn't seem to work. I published this repo with minimal code to test it out. You can use the attached file (upload_file.xlsx) for upload testing. You need to go through the whole cycle of the upload in order to see the error.
upload_file.xlsx

@srujzs Thanks for the response. I checked the scenario with toJS but didn't seem to work. I published this repo with minimal code to test it out. You can use the attached file (upload_file.xlsx) for upload testing. You need to go through the whole cycle of the upload in order to see the error.
upload_file.xlsx

Thanks for the repro! It does look related to converting Futures back and forth. I mentioned how a Dart async function returns a Future that needs to be converted to a Promise, but a JS async function also returns a Promise that needs to be converted to a Future so you can use it in Dart. Here's how I'd patch your repro with dart:js_interop:

Patch
diff --git a/lib/js_helper.dart b/lib/js_helper.dart
index a4e6555..6b69429 100644
--- a/lib/js_helper.dart
+++ b/lib/js_helper.dart
@@ -1,11 +1,7 @@
 @JS()
 library nuvo;

-import 'package:js/js.dart';
+import 'dart:js_interop';

 @JS()
-external dynamic testJS(
-  Function(
-    String text,
-  ) onResults,
-);
+external JSPromise<JSAny?> testJS(JSExportedDartFunction onResults);
diff --git a/lib/main.dart b/lib/main.dart
index 82ba815..c52f1d0 100644
--- a/lib/main.dart
+++ b/lib/main.dart
@@ -1,11 +1,17 @@
+import 'dart:js_interop';
+
 import 'package:flutter/material.dart';
-import 'package:js/js.dart';
 import 'package:js_testing/js_helper.dart';

 void main() {
   runApp(const MainApp());
 }

+JSPromise<JSString> func(String text) =>
+    Future<JSString>.delayed(const Duration(seconds: 1), () {
+      return text.toJS;
+    }).toJS;
+
 class MainApp extends StatelessWidget {
   const MainApp({super.key});

@@ -16,14 +22,7 @@ class MainApp extends StatelessWidget {
         body: Center(
           child: TextButton(
             onPressed: () {
-              testJS(
-                allowInterop(
-                  (text) async {
-                    Future.delayed(const Duration(seconds: 1));
-                    return text;
-                  },
-                ),
-              );
+              testJS(func.toJS).toDart;
             },
             child: const Text('Test'),
           ),

With the above changes, test is printed to the console.

Thank you, @srujzs! This is incredibly helpful.


ImportError: DLL load failed while importing _C

Hi,
when I start ConfyUI I get the following error in the (German) CMD:
Traceback (most recent call last):
File "C:\ComfyUI\ComfyUI\nodes.py", line 1879, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-3D-Pack_init.py", line 28, in
module = importlib.import_module(f".{nodes_filename}", package=name)
File "importlib_init_.py", line 126, in import_module
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-3D-Pack\nodes.py", line 33, in
from .algorithms.main_3DGS import GaussianSplatting, GaussianSplattingCameraController, GSParams
File "C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-3D-Pack\algorithms\main_3DGS.py", line 12, in
from .main_3DGS_renderer import GaussianSplattingRenderer
File "C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-3D-Pack\algorithms\main_3DGS_renderer.py", line 24, in
from diff_gaussian_rasterization import (
File "C:\ComfyUI\python_embeded\lib\site-packages\diff_gaussian_rasterization_init.py", line 15, in
from . import _C
ImportError: DLL load failed while importing _C: Das angegebene Modul wurde nicht gefunden.
I already found out from the threat https://github.com/MrForExample/ComfyUI-3D-Pack/issues/77 that the error for others was due to the fact that they didn't install Visual Studio with C++, but I had this before installing Confyui and can't find a missing build either.
Can someone maybe help me with what else could be the problem or where else I could look?
Thank you in advance for any help!

In my tests I found several DLL load failed while importing _C cases and it was simply fixed by downgrading PyTorch to 2.2.
I guess core packages like PyTorch3D are not yet ready for PyTorch 2.3.

@Scharwunzel

Check if your cuda version is 12.1. Torch3d currently only supports at most Ao 12.1. Open cmd and enter "nvcc -- version". If there is cuda information, it means the driver has been installed. Check if the version is 12.1. If not, you need to reinstall cuda. After reinstalling, you need to run the installation command of ComfyUI-3D-Pack again

hi, sorry for the late reply and thank you für your help.
I have now tried both tips, unfortunately without success.
I have set PyTorch to
"Version: 2.2.2+cu121"
The cuda version is also available at
"Cuda compilation tools, release 12.1, V12.1.66
Build cuda_12.1.r12.1/compiler.32415258_0"
Both is showing while versions check in the cmd under \ComfyUI\python_embeded.
At start of Comfy there are following versions:
"Current version of llama_cpp: 0.2.26+cu118
Current version of timm: 0.9.12
[ReActor] - STATUS - Running v0.5.0-b3 in ComfyUI
Torch version: 2.3.0+cu118"
Do I have to do anything special for this to be taken over?

Same problem here

@Scharwunzel Try force-reinstall:
python.exe -s -m pip install --force-reinstall xformers==0.0.25.post1 torchvision torchaudio --index-url https://download.pytorch.org/whl/cu121 --extra-index-url https://pypi.org/simple

(By xformers==0.0.25.post1 we imply using PyTorch 2.2.2)

@YanWenKun  I get this Message with this command:

@Scharwunzel Try force-reinstall:
python.exe -s -m pip install --force-reinstall xformers==0.0.25.post1 torchvision torchaudio --index-url https://download.pytorch.org/whl/cu121 --extra-index-url https://pypi.org/simple

(By xformers==0.0.25.post1 we imply using PyTorch 2.2.2)

It works for me. .🥰

@Scharwunzel This error message was about other dependencies, you can ignore it, or:
python.exe -s -m pip install --force-reinstall pillow==9.5.0 numpy==1.25.2 cryptography

I'm able to successfully import the 3D pack but there's a few errors up top that I'm not sure about.

I am able to import 3D pack successfully however there's a few stuff that I don't understand. When force reinstalling  xformers==0.0.25.post1, some lines shows  "not on path". Is that why I'm seeing this error?

Hello @YanWenKun , is the 2.2.2 version still usable for this solution? I guess a new solution need to be updated for 2.4.0? Ho can I solve the problem (ImportError: DLL load failed while importing _C: The specified module could not be found.) in that case?

@GPU-server

Referring to https://github.com/YanWenKun/ComfyUI-Windows-Portable/issues/7 , just use 2.2.2 with old commit.

Or if you want to update to the latest 3D-Pack, you need PyTorch 2.4 or 2.3.
python.exe -s -m pip install --force-reinstall xformers==0.0.27.post2 torchvision torchaudio --index-url https://download.pytorch.org/whl/cu121 --extra-index-url https://pypi.org/simple

Then update/reinstall 3D-Pack.

Or just use all-in-one package:
https://github.com/YanWenKun/ComfyUI-Windows-Portable
https://github.com/YanWenKun/ComfyUI-Docker/tree/main/comfy3d-pt23

Hi thanks for your answer @YanWenKun  before running your command, I would like to show you my current set and tell if you think I should proceed:
I have this:

Package                     Version

accelerate                  1.0.0
aiohappyeyeballs            2.4.0
aiohttp                     3.10.5
aiosignal                   1.3.1
antlr4-python3-runtime      4.9.3
attrs                       24.2.0
certifi                     2024.8.30
cffi                        1.17.1
charset-normalizer          3.3.2
click                       8.1.7
cmake                       3.30.4
colorama                    0.4.6
coloredlogs                 15.0.1
contourpy                   1.3.0
cryptography                43.0.1
cycler                      0.12.1
dataclasses-json            0.6.7
Deprecated                  1.2.14
diff_gaussian_rasterization 0.0.0
diffusers                   0.30.3
einops                      0.8.0
filelock                    3.15.4
flatbuffers                 24.3.25
fonttools                   4.54.1
frozenlist                  1.4.1
fsspec                      2024.9.0
ftfy                        6.2.3
fvcore                      0.1.5.post20221221
gitdb                       4.0.11
GitPython                   3.1.43
gpytoolbox                  0.3.2
hatchling                   1.25.0
huggingface-hub             0.24.6
humanfriendly               10.0
idna                        3.8
imageio                     2.35.1
imageio-ffmpeg              0.5.1
importlib_metadata          8.5.0
iopath                      0.1.10
jaxtyping                   0.2.34
Jinja2                      3.1.4
jsonschema                  4.23.0
jsonschema-specifications   2024.10.1
kiui                        0.2.13
kiwisolver                  1.4.7
kornia                      0.7.3
kornia_rs                   0.1.5
lazy_loader                 0.4
lightning-utilities         0.11.7
llvmlite                    0.43.0
markdown-it-py              3.0.0
MarkupSafe                  2.1.5
marshmallow                 3.22.0
matplotlib                  3.9.2
matrix-client               0.4.0
mdurl                       0.1.2
mpmath                      1.3.0
msvc_runtime                14.40.33807
multidict                   6.0.5
mypy-extensions             1.0.0
nerfacc                     0.5.3
networkx                    3.3
ninja                       <IP_ADDRESS>
numba                       0.60.0
numpy                       1.26.4
nvdiffrast                  0.3.1
omegaconf                   2.3.0
onnxruntime                 1.19.2
open_clip_torch             2.26.1
opencv-python               <IP_ADDRESS>
opencv-python-headless      <IP_ADDRESS>
packaging                   24.1
pathspec                    0.12.1
peft                        0.13.1
pillow                      10.4.0
pip                         24.2
platformdirs                4.3.6
pluggy                      1.5.0
plyfile                     1.1
pointnet2_ops               3.0.0
pooch                       1.8.2
portalocker                 2.10.1
protobuf                    5.28.2
psutil                      6.0.0
pycparser                   2.22
pygit2                      1.15.1
PyGithub                    2.4.0
pygltflib                   1.16.2
Pygments                    2.18.0
pyhocon                     0.3.61
PyJWT                       2.9.0
PyMatting                   1.1.12
PyMCubes                    0.1.6
pymeshlab                   2023.12.post2
PyNaCl                      1.5.0
pyparsing                   3.1.4
pyreadline3                 3.5.4
python-dateutil             2.9.0.post0
pytorch-lightning           2.4.0
pytorch-msssim              1.0.0
pytorch3d                   0.7.8
pywin32                     307
PyYAML                      6.0.2
referencing                 0.35.1
regex                       2024.7.24
rembg                       2.0.59
requests                    2.32.3
rich                        13.9.2
rpds-py                     0.20.0
safetensors                 0.4.5
scikit-image                0.24.0
scipy                       1.14.1
sentencepiece               0.2.0
setuptools                  74.1.2
shellingham                 1.5.4
simple_knn                  0.0.0
six                         1.16.0
slangtorch                  1.2.6
smmap                       5.0.1
soundfile                   0.12.1
spandrel                    0.3.4
sympy                       1.13.2
tabulate                    0.9.0
termcolor                   2.5.0
tifffile                    2024.9.20
timm                        1.0.9
tokenizers                  0.19.1
torch                       2.4.0+cu118
torch_scatter               2.1.2+pt24cu118
torchaudio                  2.4.0
torchmetrics                1.4.2
torchsde                    0.2.6
torchtyping                 0.1.5
torchvision                 0.19.0+cu118
tqdm                        4.66.5
trampoline                  0.1.2
transformers                4.44.2
trimesh                     4.4.9
trove-classifiers           2024.9.12
typeguard                   2.13.3
typer                       0.12.5
typing_extensions           4.12.2
typing-inspect              0.9.0
urllib3                     1.26.20
wcwidth                     0.2.13
wheel                       0.44.0
wrapt                       1.16.0
xatlas                      0.0.9
xformers                    0.0.27.post2+cu118
yacs                        0.1.8
yarl                        1.9.11
zipp                        3.20.2

And I have cuda toolkit 12.1
run install.py multiple times
Put security level to weak to let comfy manager "try" to fix the issues.
And even did a quick "update_comfyui.bat". It solved an issue related to pytorch audio was not being able to be set or something.
I remained with the :
...init.py", line 53, in
module = importlib.import_module(f".{nodes_filename}", package=name)
ImportError: DLL load failed while importing _C: The specified module could not be found.
I am on the right path?

But doing all of this brung me a whole new problem:
**A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.1.2 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.
If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.**
What to do now?

@GPU-server
To downgrade Numpy:
python.exe -s -m pip install numpy<2

And I noticed that you're using CUDA 11.8 packages, which should be fine with current setup, but in case you want to downgrade from cu121 to cu118:
python.exe -s -m pip install --force-reinstall xformers==0.0.27.post2 torchvision torchaudio --index-url https://download.pytorch.org/whl/cu118 --extra-index-url https://pypi.org/simple

@YanWenKun  where did yousee the 11.8 packages, it was only torch_scatter right?
Which I upgraded to cu121
( I posted 2 messages with 2 pip lists, check it)
Anyway I think I just made it work, I also had to do something (changing code of a script in the gpytoolbox library"
I CANNOT BELIEVE ITS WORKING LOL.
Are the workflow examples eady to use? It seems there are many and I dont know what they all do?

@GPU-server
python.exe -s -m pip install --force-reinstall numpy==1.26.4

@GPU-server

Thanks. How did you know that was the exact version we needed?

Just use PyPI to find the package you need:
https://pypi.org/project/numpy/#history

did you get the problem of having your torch being unisntalled each time you isntall missing nodes?

Just seperate Python environments. One for Comfy3D, one for everything else, etc.
In portable packages, each python_embeded manage its own pip packages and isolate from the other.
I use GitHub to build big all-in-one package. It covers most popular nodes.
And I never update pip packages in one environment, I just replace the whole Python environment, like swap-in and swap-out CDs. It's faster, easier, and dependency-resolved.
Also I rarely use ComfyUI-Manger to install/update custom nodes. Using git is much faster, and it won't try to fix Python dependencies like Manager did. But it won't install missing packages, too.
Btw, I'm curious which node is asking for updating PyTorch from 2.4.0 to 2.4.1 ?

p.s. Edit extra_model_paths.yaml in ComfyUI folder to share one set of models across multiple ComfyUI instances.

@GPU-server

Download this for non-3D-Pack usage.
Download this for 3D-pack usage. Delete folders you don't need in custom_nodes.
(Optional) Under ComfyUI folder, rename extra_model_paths.yaml.example to extra_model_paths.yaml. Edit it so two ComfyUIs can share one models folder. You can skip this step if one ComfyUI is dedicated to 3D-Pack, as 3D-Pack will download models to its own folder under custom_nodes.

And lastly, you can fork this repo, add/remove nodes in stage2.sh, then build it using GitHub Actions, so you'll have a ComfyUI portable of your own.

Thanks @YanWenKun  But I wanted to learn the hard version, the version where we install it from base comfyui Official repo.
Do you remember how you did it before making that repo that is ready to use?
I want the hard way (to become an expert (like you lol)).
?

@GPU-server

Thanks. How did you know that was the exact version we needed?

Just use PyPI to find the package you need: https://pypi.org/project/numpy/#history

Ok but how did you know by visiting that website (https://pypi.org/project/numpy/1.26.4/) that this is the right version for us I mean?

@GPU-server Wow, that's cool!
Tbh, I didn't choose the hard way in this case. I analyzed the build scripts of ComfyUI official portable and rewrote them into scripts of my own flavor.
But if you want to build a ComfyUI bundle from the ground up, the key steps are:

Setup OS environment: Git, GPU drivers (or CUDA Toolkit), C++ build tools.
Setup Python venv, or embeded. Then setup PIP.
Install PyTorch + xFormers. Each version of xFormers is paired with specific PyTorch version, so you could choose the PyTorch version by choosing xFormers' version.
Git clone ComfyUI and custom nodes.
Install requirements.txt of ComfyUI. When done, a basic envrionment for running SD image generation is ready.
Install requirements.txt from custom nodes. Which is overwhelmingly full of fine details. And you should look into them, one by one.

onnxruntime-gpu needs a specific repo to download wheels from.
cupy-cuda12x needs manual install.
ninja needs binary from official, or just OS install configured with PATH.
dlib and insightface needs to compile on site, or download binary wheel files from 3rd party.
CLIP needs to install from source.
gradio is incompatible with ComfyUI-Manager as their dependency on urllib3 is different.

Comfy3D's dependency is complicated and needs special attention. You can use its installer, but manual installation gives you more control. You should examine the scripts and pick the proper wheels to install, and copy the includes and libs for later C++ compiling.

Finally, put models in and let Python run the main.py.

Ok but how did you know by visiting that website (https://pypi.org/project/numpy/1.26.4/) that this is the right version for us I mean?

Numpy2 brings break changes and many projects can't simply upgrade version number from 1.x to 2.x. 1.26.4 is the last (maybe final) working version of Numpy1. PyPI is the repository of PIP.


Refactor AnimationSet loading

Closes #962
Delegating to a copy constructor is potentially an unsafe operation as well as MSVC complaining that member variables were not initialized. All member variables are now initialized in the header by default.
I took the opportunity to refactor the loading because of the MSVC warning. The various process functions were private to the implementation file via an unnamed namespace as well as only used in one place so they made great candidates for Immediately Invoked Initializing Lambdas which aren't accessible outside the function they are declared, reducing their scope even further.

@ldicker83 or @DanRStevens The issues Codacy complains about can be safely ignored. I do not have the proper permissions to ignore them:

Codacy detected an issue:
Message: Function parameter 'fileName' should be passed by const reference.
Occurred on:

Commit:  0c2ef49c17ec744209c1bd338a2d4b9f6d72c60c
File:    NAS2D/Resource/AnimationSet.cpp
LineNum: 53
Code:    AnimationSet::AnimationSet(std::string fileName) :

Currently on:

Commit:  0c2ef49c17ec744209c1bd338a2d4b9f6d72c60c
File:    NAS2D/Resource/AnimationSet.cpp
LineNum: 53

Codacy detected an issue:
Message: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20).
Occurred on:

Commit:  0c2ef49c17ec744209c1bd338a2d4b9f6d72c60c
File:    NAS2D/Resource/AnimationSet.cpp
LineNum: 61
Code:    xmlDoc.parse(filesystem.read(mFileName).c_str());

Currently on:

Commit:  0c2ef49c17ec744209c1bd338a2d4b9f6d72c60c
File:    NAS2D/Resource/AnimationSet.cpp
LineNum: 61

Could you provide details or a reference to explain the following:

Delegating to a copy constructor is potentially an unsafe operation

Any and all documentation, websites, tutorials, etc, that Google-Fu brings up about delegating to the copy-constructor never gives an example of using the copy-constructor as the delegating constructor. Nor is it mentioned as a valid or even invalid use.

I've created a separate PR just addressing the uninitialized variable issue. See #965

Any and all documentation, websites, tutorials, etc, that Google-Fu brings up about delegating to the copy-constructor never gives an example of using the copy-constructor as the delegating constructor. Nor is it mentioned as a valid or even invalid use.

... so basically what you're saying is there's no documentation to state that it's invalid. :wink:
I'm pretty sure the warning is wrong. Nevertheless, it would be nice to have code that doesn't generate warnings.


[BUG] Filechannel close takes a long time.

What is the bug?
When committing files, channel.close() sometimes takes a long time.
How to reproduce the bug?

shuffle write data size: 14.5G
shuffle partition num: 200

sparkProperties:
spark.executor.instances: 5
spark.kubernetes.executor.request.cores: 6
spark.executor.memory: 30g
spark.shuffle.manager: org.apache.spark.shuffle.rss.RssShuffleManager
spark.rss.master.address: 192.168.x.xx:9097
spark.shuffle.service.enabled: false
spark.rss.push.data.replicate: false
spark.sql.adaptive.enabled: false
spark.sql.adaptive.localShuffleReader.enabled: false
spark.sql.adaptive.skewJoin.enabled: false

rss-defaults.conf
rss.master.address <IP_ADDRESS>:9097
rss.metrics.system.enable true
rss.remove.shuffle.delay 300s
rss.worker.flush.buffer.size 256k
rss.worker.flush.queue.capacity 512
rss.worker.base.dirs /mnt/disk1

ECS as virtual macheine:
16c64g(ecs.g7.4xlarge) x 3 workers, each worker has ESSD 100G PL1 disk.
Could you share logs or screenshots?
The first read took 28s because it was waiting for the completion of the previous stage commit file, and the subsequent shuffle read took a short time (within 0.1s), and the commit file was slow because it was slow when executing channel.close().

When I changed FileChannel.write() to DataOutputStream.write(), the above problem disappeared.

Note: I added channel.force() methoed before channel.close() and found that the time-consuming is mainly caused by channel.force().

Hi, can you share your disk metrics like disk bandwidth or "%iowait" data?
I think this means you need more disks, can you try to add more disks to "rss.worker.base.dirs" ?
@packageman

The IO metrics command I am using is iostat -x 2

IO metrics when writing files using FileChannel(ESSD 100G PL1 disk):

IO metrics when writing files using DataOutputStream(ESSD 100G PL1 disk):

When using FileChannel, %iowait is almost 100%, and when using DataOutputStream, only 32% max, and it takes less time to complete the writing of DataOutputStream.
I upgraded the disk to ESSD 500G PL2 and re-tested the FileChannel, and the IO metrics are as follows:

%iowait has dropped to about %20, w/s and wKB/s have been improved, and the writing time has been shortened a lot.
Through the above tests, it is found that the writing speed can be improved by improving disk performance or changing FileChannel to DataOutputStream(which may bring additional CPU and memory overhead for data copying).

Thanks for your concentration. You are always welcome to discuss your idea here.
I think you might misunderstand the meaning of %iowait.
IOWait (usually labeled %wa in top) is a sub-category of idle (%idle is usually expressed as all idle except defined subcategories), meaning the CPU is not doing anything. Therefore, as long as there is another process that the CPU could be processing, it will do so. Additionally, idle, user, system, iowait, etc are measurements for the CPU. In other words, you can think of iowait as the idle caused by waiting for io.
So high iowait value means efficient CPU usage and, higher disk performance means lower iowait.
FileChannel vs DataOutputStream, there is some existing reference.
http://web.archive.org/web/20120815094827/http://geekomatic.ch/2008/09.html
http://web.archive.org/web/20120815094827/http://geekomatic.ch/2008/09.html


User's expenses not displaying on their profile page

You can see Kas' expenses on the Collective:

But not on their profile:

On my own profile you can see the expenses, so why not on Kas'?

Because Kas has disabled transactions section for hompage.
https://opencollective.com/kkshl/transactions

@snitin315 is correct, the transactions section can be disabled on users' profiles, and that is why it's not displayed there.
Related: https://github.com/opencollective/opencollective/issues/3749

We don't have mandatory sections on a given Collective/Individual/Organization page, at the only exception of Collective transactions/budget.


One viewport

Although it is nice to have multiple viewports technically... in the game we have one viewport only and we should use one. It should be full-screen.

done


Print Intermediate Outputs for Each Step in a Chained Model Sequence

/kind feature
I would like to request a feature that allows intermediate outputs from each step in a sequence of models to be printed or returned, rather than only the final result , which can help user to trace relationship between model.
For example, in a workflow where a textblob-model is chained with a hugging-face-bert model, the output of the sentiment analysis could be passed as input to the BERT model for further processing. However, only the final result from the hugging-face-bert model is returned, making it hard to validate the intermediate sentiment analysis output.
Describe the solution you'd like
Here’s an example of how you could modify your InferenceGraph to print the output of each model step:
apiVersion: "serving.kserve.io/v1alpha1"
kind: "InferenceGraph"
metadata:
  name: "chained-models"
  namespace: "default"
spec:
  nodes:
    root:
      routerType: Sequence
      steps:
        - serviceName: sentiment-model
          name: sentiment-model # step name
          printResponse: true # New field to print sentiment-model's output
        - serviceName: huggingface-bert-isot
          name: huggingface-bert-isot
          data: $response
          printResponse: true # New field to print huggingface-bert-isot's output

output like this
{
  "sentiment-model": {"prediction": "0.5"},
  "hugging-face-bert": {"prediction": "real"}
}

Anything else you would like to add:
No
Links to the design documents:
[Optional, start with the short-form RFC template to outline your ideas and get early feedback.]
[Required, use the longer-form design doc template to specify and discuss your design in more detail]

/assign


Release vutils-testing 1.0.0

Do code cleanup, make the first stable release.

Coverage: 100.0%. Remained the same when pulling f1a15b39a11e9a79802be86c10f9127bbf9bc238 on code-cleanup into 8be8108cefc4798d52c590aeb1720741148c4ded on main.


⚠ PostgreSQL has degraded performance

In 162b7d3, PostgreSQL (https://news.ycombinator.com) experienced degraded performance:

HTTP code: 200
Response time: 2127 ms

Resolved: PostgreSQL performance has improved in 9cdb86d after 5 minutes.


3DArea gravity point is related to absolute (0,0,0) point

When creating area with it's own gravity, and checking 'Gravity Point', the origin of gravity is always set to absolute 0,0,0 point.
Here is minimal sample project illustrating this bug:
https://dl.dropboxusercontent.com/u/168251/godot/some/issues/gravity_point.7z

That's because your Gravity Vector is (0,0,0) I guess :smile:

Gravity Vector is (0,-1,0), and it defines the direction of the gravity not the gravity point...

It is the direction only if "Gravity Point" is unchecked... Otherwise it is the point to which things are attracted. Try changing it to something like (100,0,0) to see this :smile:

Oh I guess this one makes sense! Thanks! :)


Should we check if a REDCap instrument is "complete?

No, import all data regardless of form status.

Ideally, we should make this a project configurable option.


new jupyterlab mime types

jupyterlab has bmp/gif/markdown/json/vega/vegalite/pdf mimetypes that can be used.

Changed in version 5.0: application/json data should be unpacked JSON data, not double-serialized as a JSON string.

not sure how to handle this. Probably need to change this that mimetyp application/json is not serialized but unpacked ...
-- | Convert a MIME type and value into a JSON dictionary pair.
displayDataToJson :: DisplayData -> (Text, Value)
displayDataToJson (DisplayData mimeType dataStr) =
  pack (show mimeType) .= String dataStr

It is a bit ugly but works now with these lines:
-- | Convert a MIME type and value into a JSON dictionary pair.
displayDataToJson :: DisplayData -> (Text, Value)
displayDataToJson (DisplayData MimeJson dataStr) =
    pack (show MimeJson) .= fromMaybe (String "") (decodeStrict (encodeUtf8 dataStr) :: Maybe Value)
displayDataToJson (DisplayData MimeVegalite dataStr) =
    pack (show MimeVegalite) .= fromMaybe (String "") (decodeStrict (encodeUtf8 dataStr) :: Maybe Value)
displayDataToJson (DisplayData MimeVega dataStr) =
    pack (show MimeVega) .= fromMaybe (String "") (decodeStrict (encodeUtf8 dataStr) :: Maybe Value)
displayDataToJson (DisplayData mimeType dataStr) =
  pack (show mimeType) .= String dataStr

This is great, thanks so much!


Add must helper

A Must function is idiomatic go; the benefit of having a must is to
panic when it is not a valid UUID vs error handle.
This branch is a WIP because I wanted to discuss the proper contributions of test cases as well for this repo. This closes #42

@satori @rezxv thoughts?

Coverage decreased (-1.8%) to 94.757% when pulling 1d213916d1a8d3b9fdf4e3469b1204eeb0449ccb on marclave:marc/feature/Must_helper_wrapper into 5bf94b69c6b68ee1b541973bb8e1144db23a194b on satori:master.

Coverage decreased (-1.8%) to 94.757% when pulling 1d213916d1a8d3b9fdf4e3469b1204eeb0449ccb on marclave:marc/feature/Must_helper_wrapper into 5bf94b69c6b68ee1b541973bb8e1144db23a194b on satori:master.


Fix bad boolean check to restore chat

Details
Expensify.cash is down since some .production.env variables changed and we are not correctly checking them.
We need to explicitly check for true as the existing check will return true when the value is a string of 'false'
Fixed Issues
https://expensify.slack.com/archives/C011W8BJ9L6/p1608841232445200
Tests

Create a production web build npm run build
Make sure we are using the correct API endpoint.

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots
Web
Mobile Web
Desktop

iOS

Android

Skipping the e2e test for iOS to get us back online.


Spacing axis

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: LetterModeller sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I am interpreting this proposal as for 'optical spacing', i.e. it isn't simply an x-direction 'white space' adjustment feature (although could be implemented as such), but may also involve adjustments to glyph shape (indeed, may require such adjustments in the case of joining scripts), and may involve variable GPOS interaction, e.g. to scale kerning proportionally to variable spacing. @LetterModeller does that interpretation fit with what you have in mind.
[I think that for all new axis proposals we need to understand whether the proposed axis is optical or parametric (perhaps this is a category to add to the standard proposal template?). I define an optical axis as one that may affect more than one aspect of a design at a time, e.g. stem weight changing on a width axis; whereas a parametric axis affects only one aspect at a time, independently of others (cf. Amstelvar). These represent two different models of designing a variable font, and it seems fairly important to distinguish whether a given axis proposal is optical or parametric. All five of the initially registered OT variations axes are optical axes, although only one — Optical Size — explicitly acknowledges this.]


added Dark theme in  the website

fixes #21
Description -
added dark theme in the website
Video
https://user-images.githubusercontent.com/82874704/161753752-4ad061a5-54d4-458e-a6ab-bc008f660e7b.mp4

This pull request is having conflicts. Can you raise another pr or resolve the conflicts.

ok i am doing a new pr . so please close this pr


Add mainProgram attribute for firedragon.

NOTE: This will enter cache and release only after the successful build of all packages, which I should finish soon.


Add order filters

Creates a module and tests for order-based filters (e.g. minimum, maximum, median, etc.) for use with Dask.

Would be curious to know if you have any thoughts on this, @mrocklin.

Is there anything in particular that you would like me to comment on?

Anything that comes to mind really.
I tried to approach this in a similar way as was done with dask.array.fft. Potential concerns could be the degree of magic and whether it is too much. Another concern could be whether the test coverage is really good enough. Are there ways it could be consolidated? Also I found an oddity between some of the SciPy functions in terms of how they handled the origin argument. Do you have any thoughts on that point?

Honestly I've been sufficiently busy that I haven't given this problem enough time to have developed  informed opinions about it.
We might consider reaching out to some other people to get their thoughts.  @jni comes to mind as potentially interested in this sort of thing.

I guess if there are no concerns I'll just merge this. That said, this is clearly the very beginning of this library. So there is still plenty of time to discuss changes and improvements to this and later functionality.


Removed old loggers

I removed the old logger files and pointed the calls going to the old to the new. Removed the temporary JLogger file, renamed KLogger to Logger, and pointed Logger to the vendor logger.
Closes #484

This overlaps a little with: #538 so let's either wait on that one, or merge this in and I can redo that other PR.

Let's merge yours in first since it's so much bigger. I need to get this one very soon in order to keep trying to figure out #536, which is necessary to figure out #443.

@ronan I've rebased this atop the changes made in #538.

Seems to work.
Extracting private attributes from the parent logger seems like an iffy practice though. I'm not 100% sure why this would be necessary. This seems to be just a way of getting at some of the options, but those are passed into our constructor, we could simply capture them from there.
I don't want to hold this up though since it does the job and has the right interface. We can always revisit this later.

No, the options are explicitly private. Attempting to access the options from the child will cause fatal errors. It's been working this way since 0.8.0.

I've opened a PR against the logger repo to change the visibility to some elements to protected.
https://github.com/katzgrau/KLogger/pull/69

Yeah, you can't access the private options directly but you probably don't need to since you're generating those options in the constructor. You could simply save another protected copy of them. It's a workaround, but it's a more reliable workaround than using a PHP loophole to violate the meaning of a private variable. Simpler too. I also agree though that these variables should probably be protected in the parent class rather than private.
Either way, I'm coming in late with these comments since this is already working in the current stable release and these changes go beyond the scope of this PR so...
+1

Thanks. I've opened PR #563 so we don't lose track of the need to change Logger if/when the PR against the logger repo is accepted.


Send to epp server

relates to https://github.com/elifesciences/enhanced-preprints-issues/issues/393

My guess would be to clear you local docker cache in case you have a cached, older version of docmap-ts library that's not being updated? Happy to pair on it if you still have problems after that.

I encountered the same issue that @E-Kemp did but removing the corresponding image and the container that was based on it, cleared that issue for me.

@nlisgo said:

Let's focus on introducing the import-version endpoint in server ahead of this.

The endpoint did exist already mid-January. @E-Kemp moved it in the reorg a bit back, but it's still there. This branch probably needs updating to POST to /preprints:
>  kubectl port-forward -n epp--prod deployment/epp-server 3000:3000
Forwarding from <IP_ADDRESS>:3000 -> 3000
Forwarding from [::1]:3000 -> 3000

<another tab>
> curl -X POST http://localhost:3000/preprints
{"result":false,"message":"body sent failed validation: (ValidationError): \"id\" is required. \"msid\" is required. \"doi\" is required. \"versionIdentifier\" is required. \"article\" is required. \"preprintDoi\" is required. \"preprintUrl\" is required. \"preprintPosted\" is required"}

I almost happy with this. Just going to do some digging around server to verify that we have all the data we need to accept the import once the validation violations are resolved.


Create mixture class ExpressionExtract

A new class (with appropriate mechanisms) to model gene expression ignoring mRNA and transcriptional/translation machinery. Specifically thinking of reactions like G --> G + P. Where G is a gene and P is a protein. Proteins can still modulate genes via promoters etc.

Done


Build failure: atuin

Steps To Reproduce
Steps to reproduce the behavior:

build atuin on an x86-64 Mac

Build log
https://gist.github.com/briankung/9956c2cfae998ca39d1c4f024e45dd55
Additional context
The key part is probably this:
       >   = note: Undefined symbols for architecture x86_64:
       >             "_kCFURLVolumeAvailableCapacityForImportantUsageKey", referenced from:
       >                 sysinfo::unix::apple::disk::get_list::h94c969b00aa897d2 in libsysinfo-5beb080e6b6ae604.rlib(sysinfo-5beb080e6b6ae604.sysinfo.26a22e64a9cf7170-cgu.10.rcgu.o)
       >           ld: symbol(s) not found for architecture x86_64
       >           clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
       >
       >
       > error: could not compile `atuin` (bin "atuin") due to 1 previous error
       For full logs, run 'nix log /nix/store/hjvr6qnpdp5x1vqav760s7ggmfj4bs6l-atuin-18.3.0.drv'.

Notify maintainers

@SuperSandro2000
@Sciencentistguy
@0x4A6F

Metadata

system: "x86_64-darwin"
host os: Darwin 24.0.0, macOS 10.16
multi-user?: yes
sandbox: no
version: nix-env (Nix) 2.24.10
nixpkgs: /nix/store/rxn26bq4xm2p0x4whkp94afhy1g88cm7-source

Add a :+1: reaction to issues you find important.

That's a nice error. If you happen to find a solution, please create a PR.

Could this be related to / fixed by the new Apple SDK pattern? I noticed atuin breaking right after staging-next made its way to nixpkgs-unstable. Relevant tracking issue: #354146


JavaScript syntax is not correct

Looks like an update to atom has resulted in the syntax for javascript -- specifically key words -- not looking correct.

Actually the syntax was overhauled in PR #35 This more accurately matches the syntax highlighting given by editors like textmate and sublime


WASM Function Extension

Signed-off-by: erfenjiao<EMAIL_ADDRESS>

Please rebase on v1.8.0 branch later

Merged as the initial working version. Need to extend type support and add English doc later.


Existing websockets constructor call doesn't work in Chrome because of the extra undefined origin parameter

closed in favor of https://github.com/MetaMask/provider-engine/pull/297


Can this model suitable for multilingual-t5 accelerate?

Recently, I use the chinese function of multilingual-t5 model to accomplish the Chinese NLG tasks. However, the inference speed might be slow, could this model be used for multilingual-t5? How can I do?

So it looks like huggingface has it now: https://huggingface.co/google/mt5-base which means you can use the code in there: https://github.com/abelriboulot/onnxt5/blob/master/examples/export_pretrained_model.py

So it looks like huggingface has it now: https://huggingface.co/google/mt5-base which means you can use the code in there: https://github.com/abelriboulot/onnxt5/blob/master/examples/export_pretrained_model.py

I am getting "You are using a model of type mt5 to instantiate a model of type t5. This is not supported for all configurations of models and can yield errors." - is it ok to use this code for mT5 models?


New viz: pairwise cross coalescence plots

As per slack:

I was imagining having a matrix of plots (like R pairs() or Nate's example, but e.g. with a heat maps, including on the diagonal), showing relatively small thumbnail-like subplots of combinations of subpopulations, and with a much larger single plot in a panel above, When you mouse over a particular subplot in the pairs matrix, the edges relevant to that pair are highlighted in the large plot. If you mouse over any of the subplots on the diagonal, the edges relevant to that population only are highlighted (as if you had simplified()  the tree sequence to only samples from that population).

Transferred to https://github.com/tforest/tseda/issues/9


Information for split.py

Hi,
I'm having trouble locating the split.py file mentioned in issue #10. Could you let me know where to find this code file?
Thank you for your time!

I m facing the same problem and I can't find this code file anywhere

@primebo1 @reflectW we just uploaded it, but please note that this file is not exactly the same as the previous one we used for the paper. Since we didn't save that file, we are reimplementing this for your convenience.   So for our benchmark, our splits are recommended, for other targets, feel free to use it but double check the generated file is also suggested.

@primebo1 @reflectW we just uploaded it, but please note that this file is not exactly the same as the previous one we used for the paper. Since we didn't save that file, we are reimplementing this for your convenience. So for our benchmark, our splits are recommended, for other targets, feel free to use it but double check the generated file is also suggested.

Got it. Thanks again for your amazing work!


Problem using multiple yaml files with hydra

What is your question?
I am trying to use hydra to configure an experiment, and I want to have separate yaml files for the model, task etc but am running into some issues. I have created an example model class and registered it ("simple_lstm_enc_dec), and I am running:
hydra-train.py --config-name test --config-dir config
In the config folder I have a 'test.yaml' as follows:
model:
  _name: simple_lstm_enc_dec
  encoder_embed_dim: 64

task:
  _name: translation
  data: ...
criterion: cross_entropy

and this works fine. But what I want to do is to separate out the model parameters into a different yaml file. So what I have tried is to create a folder "config/model" and created a file inside called "simple_lstm_encoder_decoder.yaml" with the following:
_name: simple_lstm_enc_dec
encoder_embed_dim: 64

and then I change my test.yaml file to:
defaults:
  model: simple_lstm_encoder_decoder

task:
  _name: translation
  data: ...
criterion: cross_entropy

But I get an error:
"Cannot merge DictConfig with ListConfig
full_key:
reference_type=Optional[Dict[Union[str, Enum], Any]]
object_type=FairseqConfig"
I have been trying to follow this: https://github.com/facebookresearch/fairseq/blob/main/docs/hydra_integration.md
but it only mentions this possibility without giving a full example.
What is the correct way to do what I'm trying to achieve here? Thanks in advance.

Apologies, this is a duplicate of here: https://github.com/facebookresearch/hydra/issues/2023
Solution seems to be upgrading hydra to 1.1


Phrozn/Autoloader.php

Trying installing Phrozn on a dreamhost shared account and here is the message from the terminal:
Warning: require_once(Phrozn/Autoloader.php): failed to open stream: No such file or directory in /home/myuser/pear/phr on line 12
Fatal error: require_once(): Failed opening required 'Phrozn/Autoloader.php' (include_path='.:/usr/local/lib/php:/usr/local/php5/lib/pear') in /home/myuser/pear/phr on line 12
I'm quite new to this so if anyone got an idea, you're more than welcome...

I guess it is known issue #19
will need to look into it as it has been sitting in todo list for ever


test-branch/execute-job/quoted-authorization/135025bb-c8e7-4537-9ce4-e61bbd55b149

PR for testing 2b916865479a02a345db9bb29c5901bb9cca57aa

/canonical/self-hosted-runners/run-workflows 2b916865479a02a345db9bb29c5901bb9cca57aa


yarn add:package -- foo命令报错

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info

Reproduction Link: https://www.baidu.com
Browser: firefox99.0
Package Name And Version: foo

What is expected?
能正常创建项目
Extra info
Command Error: npm install @arco-materials/template-core

麻烦手动运行一下 npm install @arco-materials/template-core ，贴下详细的报错信息。


Add async Task support to BDL

This adds support (reflection and source-gen), as well as an analyser to make sure that async BDL methods always return Task. There's no test for the new analyser, like there isn't a test for the other analyser, because that's pending more tooling that has yet to be ported over from osu-localisation-analyser.
It works by waiting on the BDL method via WaitSafely().
To be tested alongside https://github.com/ppy/osu-framework/pull/5646

The new test will fail until a new SG package is released/consumed here.

One thing I was going to ask is should we be using WaitSafetly here as opposed to Wait with a CancellationToken provided?

I... did not know .Wait() had a CancellationToken override. Sounds reasonable.

I don't know if we should be passing the cancellation token into the .Wait(). In a simple test, it looks like it cancels the wait even if the task is still running, which makes sense but I don't think that would be expected from o!f - to still have things potentially running in an async context while potentially a Dispose() is now firing off.
Which brings up another issue - if we don't already (I don't think we do), BDL needs a SynchronizationContext otherwise async continuation should fail due to:
https://github.com/ppy/osu-framework/blob/66d562fe1ab45641f665dcc6c08d081f54108aed/osu.Framework/Graphics/Drawable.cs#L2596-L2622

I've tested my newest changes with the above branches and it looks to be working correctly now.

The changes to the test above fail on master and on this branch prior to the synchronisation context.
As discussed, in the future we could improve on the synchronisation context in a few ways:

Right now it's allocating a new context every load(). We could probably make it [ThreadStatic] inside the BDL threadpool.
It may be possible to rework it such that we don't need to block a BDL thread for the entire duration. I think this one in particular is going to require quite a few changes/rethinking.

As a note, ConfigureAwait(true) is the default. I'd be fine with either enforcing ConfigureAwait(true) or not ConfigureAwait(false) (i.e. not specifying anything at all), which may make more sense from a consumer/code-standards perspective.


Excessive Category Spacing

Environment
Docker
Version
0.11.5
Describe the problem
There looks to be excess space between third-forth and forth-fifth categories. It's really just a minor annoyance about how it visually looks, does not stop functionality in anyway. (Image ONE, TWO)
Adding more categories seems to do even more strange things meaning it doesn't look, at first glance, to be consistent in its spacing after the third category. Screenshots show the weirdness and the repeating HTML element that is making the strange spacing.
If I remove the element the amount of times its repeated it looks much more how I'd expect it to. (Image FOUR) (Full element in additional info) The only thing I can find different between the multiple div elements is the data-wrapper attribute.
Additional info
ONE

TWO

THREE

Duplicating div element ->

Div Elements Removed / FOUR

Please tick the boxes

[X] You've read the docs
[X] You've checked for duplicate issues
[X] You've tried to debug yourself

Looks like your config has an extra wrapper that doesn't contain any apps. You can look into that if you know how to read / edit json.
I'll try to investigate how that can happen but normally they should be deleted if they don't contain any apps

To be honest, I have no clue how this could have happened. I've simply just been using the app normally and it creates them on its own.
Another note, this version is not one that went through the major version update, when that occurred I started from scratch, so I am certain you can throw that out as the possibility of them being created / left hanging.
I'll spin up another instance and play around till I can reproduce it semi/consistently. Still weird tho.

Thank you for your efforts on investigating this !

You are correct tho, I do have a few floating wrappers here.
"wrappers": [     {       "id": "default",       "position": 0     },     {       "id": "f3bbc495-f0eb-442a-9c9c-3c91e38905f7",       "position": 3     },     {       "id": "1a279adc-8b3f-4a4b-b3ba-0b4a2da11437",       "position": 3     },     {       "id": "1ac091f8-4c46-448e-82c4-60676935661d",       "position": 4     },     {       "id": "f0d254da-fed6-4dc0-acb6-2fa79e516454",       "position": 4     },     {       "id": "367cc917-a269-4aa2-b368-3bc39619f105",       "position": 4     }   ]

Is there anyplace in the json that tells each app / category its parent wrapper that I could look for to see if somehow an item considers itself to having multiple parent locations?

Is there anyplace in the json that tells each app / category its parent wrapper that I could look for to see if somehow an item considers itself to having multiple parent locations?

Yes each app has the ID of the wrapper it's in. Try to Ctrl+f all the IDs and see if one doesn't belong to any app

Yeah, the excess wrappers don't have any children that reference them at all in the rest of the config file, so it is weird that they are still here.
My random quick idea solution could be to also add the app ID's to a list in the wrappers and to do a check for if that list is empty or not to delete the wrapper. And then also figure out why this occurred in the first place and how to solve that issue.
I'll still look into how to reproduce issue, hopefully consistently...

A quick note from me:

This doesn't happen anymore. Your config was "broken" by 0.11.0 or 0.11.1, that had a faulty migrator
The spaces are intentional, so you can drag items between categories. Don't worry, they'll go away if you have no items in them and exit the edit mode
It doesn't break Homarr, if you delete the wrapper, but you should always have one with the id "default". It's also not recommended to delete wrappers manually.

@ajnart my proposal: We should make a developer tool, that automatically fixes the amount of wrappers and their ids.

A quick note from me:

This doesn't happen anymore. Your config was "broken" by 0.11.0 or 0.11.1, that had a faulty migrator
The spaces are intentional, so you can drag items between categories. Don't worry, they'll go away if you have no items in them and exit the edit mode
It doesn't break Homarr, if you delete the wrapper, but you should always have one with the id "default". It's also not recommended to delete wrappers manually.

@ajnart my proposal: We should make a developer tool, that automatically fixes the amount of wrappers and their ids.

I think you didn't read the issue properly or looked at the screenshots.
Quoting form op "Another note, this version is not one that went through the major version update, when that occurred I started from scratch, so I am certain you can throw that out as the possibility"
(He didn't migrate from old version)
Also the screenshot shows duplicate spacing between categories outside of edit mode

Another note, I just recreated it in a fresh install... not entirely sure how I did it yet, but I still looking into it.

I figured it out.
The issue occurs when creating a new category. Making a new category ALWAYS adds a wrapper below it, either to fill the need for one at the bottom of the page or when its created for some other reason. Then the wrapper below the category above it does not get deleted because it never had any apps / children within it to check if it should be deleted or not.

A quick note from me:

This doesn't happen anymore. Your config was "broken" by 0.11.0 or 0.11.1, that had a faulty migrator
The spaces are intentional, so you can drag items between categories. Don't worry, they'll go away if you have no items in them and exit the edit mode
It doesn't break Homarr, if you delete the wrapper, but you should always have one with the id "default". It's also not recommended to delete wrappers manually.

@ajnart my proposal: We should make a developer tool, that automatically fixes the amount of wrappers and their ids.

I think you didn't read the issue properly or looked at the screenshots.
Quoting form op "Another note, this version is not one that went through the major version update, when that occurred I started from scratch, so I am certain you can throw that out as the possibility"
(He didn't migrate from old version)
Also the screenshot shows duplicate spacing between categories outside of edit mode

Ok, my bad. I didn't read the entire conversation.
Then we should implement a fix in 0.11.6

I figured it out.
The issue occurs when creating a new category. Making a new category ALWAYS adds a wrapper below it, either to fill the need for one at the bottom of the page or when its created for some other reason. Then the wrapper below the category above it does not get deleted because it never had any apps / children within it to check if it should be deleted or not.
EDIT:
However when creating a wrapper above or below with the triple dot on another wrapper does not create this same effect.

Thank you, that is very useful information. @ajnart can you take on this bug?

I figured it out.
The issue occurs when creating a new category. Making a new category ALWAYS adds a wrapper below it, either to fill the need for one at the bottom of the page or when its created for some other reason. Then the wrapper below the category above it does not get deleted because it never had any apps / children within it to check if it should be deleted or not.
EDIT:
However when creating a wrapper above or below with the triple dot on another wrapper does not create this same effect.

Thank you, that is very useful information. @ajnart can you take on this bug?

Nope sorry no idea where it comes from

Bump - This issue still exists in the beta for version 14.

Can you try and tell us if this issue still happens as of the latest image ? v0.14.0 ?

@ajnart this issue still exists in the latest version v0.14.2.

This issue will be resolved in the upcoming 1.0 release


Flash is not working in Video mode

Hello,
Thanks for providing this awesome code,
Sir, I need flash in video mode. In this code flash is only enable in camera, but when i switch to the videoCapture mode flash icon is not visible. Please guide me or provide a code snippet to enable flash while capturing video.
Thanks

Hi, in current version with out of box solution its not possible. You can implement our own control view - see description how to do it, of just fork the lib and make your changes. In nearest future, this or next week I will release new version and I'll try to add such configuration possibility.

ok sir thanks for response. i will try by my own hope for the best.


Update README cloning instructions to set core.symlinks for Windows

Description

Because some submodules have symlinks from CBMC, copying a directory in Windows may cause a hangup. This updates the instructions to set core.symlinks to true for Windows.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cbmc run checks

/bot run checks


Don't Merge! PR real time test for target branch full build

Docs Build status updates of commit af81711:
:clock10: Full build: the average full build time is 7 min(s) 39 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit af81711:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Chrome on IOS 8 free mode momentum not working

In version 3.0.7 in latest Chrome for IOS 8 the after swipe animation is failing.
Swipe is working fine but after you release the finger the  free mode momentum is missing.
It just skips the ease animation and goes strait to final position.
Works fine on Safari and Chrome on Android 4.4.

Can't replicate it on this demo http://www.idangero.us/swiper/demos/09-freemode.html

Strange. I couldn't get it working even after clearing the cache. I don't know what went wrong but now it works fine. I guess the issue can be closed.


Release v7 of Pipit

Lots of work has been done this summer and I think we are getting close to packaging version 7 of Pipit. I'm listing a couple of todos here that blocks a release. Comments and contributions are welcome!

[x] Write changelong for whats new in v7 (We should probably establish a changelog.md document) (https://github.com/Frojd/Wagtail-Pipit/commit/852c1eee9e2d95060fc275ba631e77681906cf34)
[x] Update frontend documentation so it reflects our new tooling (CRA, Storybook, Hypernova) (https://github.com/Frojd/Wagtail-Pipit/commit/dfdc25c1eed22b5e6144a700b565b1aae9c5d837)
[ ] Add documentation for building backend https://github.com/Frojd/Wagtail-Pipit/issues/174
[ ] Update builtin react components to reflect current best practices https://github.com/Frojd/Wagtail-Pipit/issues/199
[x] Make React Dev Tools work in local dev https://github.com/Frojd/Wagtail-Pipit/issues/206
[x] Upgrade to storybook 6 https://github.com/Frojd/Wagtail-Pipit/issues/200
[x] Issues with collectstatic https://github.com/Frojd/Wagtail-Pipit/issues/223

Added changelog in https://github.com/Frojd/Wagtail-Pipit/commit/852c1eee9e2d95060fc275ba631e77681906cf34, just fix it if something is wrong/missing.

Updated frontend documentation in https://github.com/Frojd/Wagtail-Pipit/commit/dfdc25c1eed22b5e6144a700b565b1aae9c5d837

Fixed react dev tools locally in https://github.com/Frojd/Wagtail-Pipit/commit/a26a14c4cefc8d6bb866831ad336134d12884814

This is superseded by https://github.com/Frojd/Wagtail-Pipit/issues/237


Enable macro-based loop unrolling

The reason I picked KRML_UNROLL_MAX to be 16 is that this guarantees that by default, if you do -funroll-loops N, then all the loops get unrolled by default. So this is a no-surprises policy.


Join or collaborate with ethereum-php

Currently, there two (maybe even more) Ethereum / Web3 libraries for PHP, digitaldonkey/ethereum-php and sc0Vu/web3.php. Both are great and they have some special features.
It will be great if they will be joined or collaborated. They could grew up and maybe someday even became the "official" PHP Ethereum / Web3 library under Ethereum organization on GitHub. It could be hard, but it would be great.
If they joined, I recommend to use name web3.php because other Ethereum / Web3 implementations are using web3.{lang} (web3.js, web3.py) so it would be better to use this standard.

digitaldonkey/ethereum-php#39

@filips123 Thanks for this suggestion, I like this idea.
I've contacted the author of the repo.
It would take some time to talk about how to collaborate due to the difference of our implementation.


Add information about Cloudflare R2 State storage

What type of feature request is this?

[ ] Mantle doesn't support a Roblox feature I would like to use
[ ] Mantle CLI improvement
[x] Other

Describe your problem
Mantle supports uploading state to AWS S3. Cloudflare R2 is S3 alternative that has quite big monthly quota of free operations (https://developers.cloudflare.com/r2/pricing/#r2-pricing) and is really easy to set up w/o any code modifications.
Since it's compatible with AWS S3 API, all you have to do to use R2 is configure Mantle in the following way.
state:
  remote:
    region:
      custom:
        name: (% R2 REGION NAME eg 'eeur' %)
        endpoint: (% S3 API [see: Select R2 Bucket > Settings > Bucket Details > S3 API] %)
    bucket: (% R2 BUCKET NAME  [see: Select R2 Bucket > Settings > Bucket Details > Name] %)
    key: (% PROJECT NAME %)

As env variables (MANTLE_AWS_ACCESS_KEY_ID, MANTLE_AWS_SECRET_ACCESS_KEY) you should set credentials of R2 API Token (has to be created separately from the bucket [see: Overview > Manage R2 API Tokens])
Describe the solution you'd like
Add an information to docs that it's possible to use Cloudflare R2.

Nice! I've updated the docs to include this information: https://mantledeploy.vercel.app/docs/remote-state/cloudflare-r2

@blake-mealey Thanks for adding!
Please note though that Cloudflare R2 doesn't support object locking, so if you're considering adding the support for it in the future, do you think there would be possible to add an option to disable it?

That's good to keep in mind


Path Resolve Issue

When an HEndpointGroup is used and you are setting up a listener on the relative root of the group, it will not work if a / is not appended.
Example:
userEndpoint.listen("/", ...)
server.listen("user", userEndpoint);
/user/name will not work but /user/name/ will work.

Fixed bud with endpoint parser. In commit c122401.


Fix Content-Disposition filename encoding

Hi! It was easy to fix it, instead of submitting an issue. I faced the problem at 0.22 I suspect it's present at 0.23 too.

@danicheg what about fix it in 0.23? I can submit another PR. WDYT?

@leoniv thanks! No need to worry about that, after we merge this PR we will merge the series/0.22 branch into series/0.23 :)

Thanks!  0.22 is officially EOL, but if it bothered you enough to fix there, it's easy enough for us to do a courtesy release there.  I'll get that started.

Thanks, we a little bit behind the progress :)

v0.22.14 is releasing from CI now with this.  I'll be asleep before it finishes. :smile:


feat(v2): add @theme-init alias to give access to initial components

Motivation

This is a quick working prototype, maybe we need to work on better naming and other things.

I have long wanted to get rid of code duplication in code block components (one basic / one with live block) and, inspired by PR #2455, I realized how this can be achieved by creating a HOC and using the basic code block component as a wrapped component.
To do this, we need a new alias, with which we can get the "initial" component - from the theme itself, not overridden by any plugins.
In this PR, both the code for adding this alias and the refactoring of code block components are simultaneously presented in order to demonstrate it in action. If there is a green light, then I can split this PR into two separate ones.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Is an new test needed for this?
See this section on preview website, where basic code blocks and live editor are used.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Because using theme-original alias (just like using theme alias) I will not get the theme component (where it was initially defined) from the plugin's code:
'@theme/CodeBlock': 'docusaurus/packages/docusaurus-theme-live-codeblock/src/theme/CodeBlock/index.js',
'@theme-original/CodeBlock': 'docusaurus/packages/docusaurus-theme-live-codeblock/src/theme/CodeBlock/index.js',

While init-theme alias refers to the proper (theme) component (from the theme itself, where it is first defined):
'@theme-init/CodeBlock': 'docusaurus/packages/docusaurus-theme-classic/src/theme/CodeBlock/index.js',

Do you see the difference? Do you understand now?
And so we can use it for HOC.

Any thoughts? Still not clear? It seems to me that this is a good way to get rid of code duplication in the live code block component, because it is annoying to duplicate changes every time.

Code highlighting via comments works as expected https://deploy-preview-2464--docusaurus-2.netlify.com/docs/next/markdown-features/#line-highlighting (in contrast to https://v2.docusaurus.io/docs/next/markdown-features/#line-highlighting)

@yangshun can you accept this PR? Am I tired of updating it every time according to master branch? As I already mentioned, this is a fairly safe change that will allow us not to duplicate changes in code block components.


WebView from @ionic-native/ionic-webview v5.0.0 causes a white screen on iOS

When<EMAIL_ADDRESS>and<EMAIL_ADDRESS>are used together the app is stuck on a white screen.
I was using it as described in the docs:
import { WebView } from '@ionic-native/ionic-webview/ngx';

constructor(private webview: WebView) { }

img = this.webview.convertFileSrc('file:///Users/dan/camera-image-12345.png')

What's your Ionic version?

I solved this in https://github.com/ionic-team/cordova-plugin-ionic-webview/issues/284#issuecomment-461933989

I am having a similar issue, although I get stuck on the splash screen rather than a white screen. I believe this is the cause, with the same versions of webview plugin and native:
2019-02-14 12:05:28.340492-0700 WICShopper[722:251610] DiskCookieStorage changing policy from 2 to 0, cookie file: file:///...
2019-02-14 12:05:28.749554-0700 WICShopper[722:251610] Apache Cordova native platform version 5.0.0 is starting.
2019-02-14 12:05:28.751269-0700 WICShopper[722:251610] Multi-tasking -> Device: YES, App: YES
2019-02-14 12:05:28.786682-0700 WICShopper[722:251610] CDVWKWebViewEngine: trying to inject XHR polyfill
2019-02-14 12:05:28.831315-0700 WICShopper[722:251610] -[WKWebViewConfiguration setURLSchemeHandler:forURLScheme:]: unrecognized selector sent to instance 0x1568cde0
2019-02-14 12:05:28.832196-0700 WICShopper[722:251610] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[WKWebViewConfiguration setURLSchemeHandler:forURLScheme:]: unrecognized selector sent to instance 0x1568cde0'
*** First throw call stack:
(0x1d1dfb3d 0x1c467067 0x1d1e4fd1 0x1d1e30c3 0x1d10bdc8 0x217ead 0x22c4cb 0x22bc6b 0x22c109 0x2297a9 0x10553f 0x22411eb7 0x22411ad9 0x2241805b 0x224155bb 0x22485159 0x21f5a1 0x105315 0x224815c5 0x22682a4b 0x22687c1d 0x2269a7c5 0x2268535b 0x1eac0c13 0x1eac0acd 0x1eac0db7 0x1d19bfdd 0x1d19bb05 0x1d199f51 0x1d0ed1af 0x1d0ecfd1 0x2247ae2d 0x22475a53 0x105213 0x1c8da4eb)
libc++abi.dylib: terminating with uncaught exception of type NSException

What’s your iOS version? The 3.x version of the plugin only supports iOS 11+, looks like you are running it on an older version

I actually came back here to share just that. I need to support iOS 10.x, so I ended up having to use webview 2.x. That does, however, work for me, so I think I'm all good.

There was no response and I can't reproduce, so closing.

So definitevely no support more for iOs < 11?

For now we are backporting changes to 2.x branch and doing releases whenever we do a 4.x release. So if you need iOS 10 support then use 2.x version of the plugin.


Clearer logs around building and deploying go apps

Description of change

Fixes
Type of change

[ ]  New feature
[ ]  Bug fix
[ ]  Refactor
[ ]  Documentation

How was this tested?

[ ]  Unit Tests
[ ]  Tested in staging
[ ]  Tested in minikube

Demo

before
after

Additional references

Documentation updated

will rebase this after other things are merged... i think you're gonna like it. worth it wait.

@janelletavares I've got this other refactor on apps deploy to accommodate languages: https://github.com/meroxa/cli/pull/301. Let me know when this PR is ready so I rebase accordingly... or the other way around.


Update Contributors.md

@gipsi, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?
We’ve added a tweet feature to our web app recently. Can you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

@Roshanjossey  Awesome! Thank you for your quick response. My main problem is getting lost, I lost your comment straight away!  I fiddled about for a while with different Git clients before going back to making the PR in the browser which is where I usually do things in GitHub.  When I eventually got to editing the file I really enjoyed tidying things up a bit.

@gipsi, I'm assuming you're having trouble to keep track of notifications from GitHub. I use https://octobox.io/ for that ( it's an open source tool 😄 )
I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


feat: Quantum Modules

Shared modules that can coexist as both eager and lazy/external within on module graph.
To the "host" eager sharing keeps next/react and so on in main.
to the remote, this eager module reference is removed, along with the "provide shared" module reference which is responsible for registering that dependency on share scope.
Doing so makes the remote container aleays consume react, but never register it nor try to load its fallback/eager reference which is removed.
In the future, Quantum modules could create ConsumeSharedModule dependencies to actually offer lazy backups to the remote, but eager provide in the host.

I have two questions about how sharing of singletons is going to work:

Are singleton sub-packages (like jotai/utils) all going to be imported from the same source as the root package?

Will we be able to set other packages to be prioritized by the host or is it only those built in to the plug-in?

Will this make the usage of remotes possible with appDir?


Maxroll import issue

Version 5.8.9
When I import, e.g., this build:
https://maxroll.gg/d4/planner/1p8k0pan#7
The legendary ring gets created like this:
- Ring:     affixPool:     - count:       - {name: attack_speed}       - {name: maximum_life}       - {name: dexterity}       minCount: 2       minGreaterAffixCount: 0     inherentPool:     - count:       - {name: resistance_to_all_elements}       - {name: armor}     itemType: [ring]     minPower: 100
In inherenPool, there should not be any "armor". Please fix.

Fixed in 5.8.10


Add indexeddb persist options to handle db version changes

Add optional persist option to provide own onUpgradeNeeded handler. This gives full control over the objectstore and context of old and new version.
Add optional persist option to give list of tables to delete.

This is great, thanks!


[Feature Request] Recognize VPN (dis-)connects

Would be great to catch the following exception when disconnecting from a VPN (e.g. company network) but leave the PreProxy running, but then ignore the proxy settings and directly connect (or maybe even have the option to load a backup different proxy setting). Also the scenario vice versa would be great (reconnect to VPN, then use the primary settings again)
[Thread-4] INFO de.fschullerer.preproxyfs.DistributeServer - Start DistributeServer on TCP port: 65000
Exception in thread "Thread-1" de.fschullerer.preproxyfs.PreProxyFSException: Error creating ProxyForwardServer socket, Program exit.
at de.fschullerer.preproxyfs.ProxyForwardServer.run(ProxyForwardServer.java:117)
Caused by: java.net.ConnectException: Connection timed out: connect
at java.net.DualStackPlainSocketImpl.connect0(Native Method)
at java.net.DualStackPlainSocketImpl.socketConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.doConnect(Unknown Source)
at java.net.AbstractPlainSocketImpl.connectToAddress(Unknown Source)
at java.net.AbstractPlainSocketImpl.connect(Unknown Source)
at java.net.PlainSocketImpl.connect(Unknown Source)
at java.net.SocksSocketImpl.connect(Unknown Source)
at java.net.Socket.connect(Unknown Source)
at java.net.Socket.connect(Unknown Source)
at java.net.Socket.(Unknown Source)
at java.net.Socket.(Unknown Source)
at de.fschullerer.preproxyfs.ForwardServerThread.(ForwardServerThread.java:31)
at de.fschullerer.preproxyfs.ProxyForwardServer.run(ProxyForwardServer.java:105)

Feature is already published. Please see latest release and the new property: TIMEOUT_FOR_PROXY_CHECK

Feature is already published. Please see latest release and the new property: TIMEOUT_FOR_PROXY_CHECK


Get Bot info

I want my bot every time send info like his id, username etc in the console.
How is that possible ? What's the exact syntax to use?
Thank you

You want to know the username and ID of the bot or the event related chat user?

You want to know the username and ID of the bot or the event related chat user?

I want to get my bot's ID in the console

You want to know the username and ID of the bot or the event related chat user?

I want to get my bot's ID in the console

I need the id for the bot verification
And I want my bot to send his details (username, ID) in the console

If you just want the bot user ID you can use the Twitch API. Here's a little tool I wrote. Just put in the username and press Go.


[CHESS]

1.d4

1.d4

1.d4

@Beliavsky this is only the move notation, no pgn. Also, I'm white!

@Beliavsky this is only the move notation, no pgn. Also, I'm white!

d4

d4


fix: consistent error response from ALB vs APIGW

Issue #, if available:
GALI-1547
Description of changes:

ALB must return an HTTP Error response instead of throwing one to avoid generic Bad Gateway response.
Changes made to make integration tests backwards compatible with the use of http:<ALB DNS Name> base URL.

Checklist:

[x] Have you successfully deployed to an AWS account with your changes?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Do we miss rush change output?

rush change is needed when we're comparing changes against develop, this PR is against feature branch.

We can do incremental diffs to feature branches as well, not sure if those are needed though:
rush change -b feature/branch


Update sm2_crypt.c

asn1_encode : x, y  =>    0 | x，0 | y

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

@neighbads we need you to put "CLA: trivial" in your commit messsage (use git commit --amend).
Or sign our CLA, https://www.openssl.org/policies/cla.html

Ping @neighbads - please could you make the update as requested by @richsalz or supply a CLA?

It isn't clear how this should be integrated as a test case.
Some instructions would be nice, a commit with the test case even better.

Shouldn't that have kicked the CLA checker to find the Trivial?

The CLA checker checks for CLA: Trivial in the commit message.  Only the PR description has been changed...

However, since that has been done, we can opt for amending the commit message ourselves...

The hexdump that @neighbads showed us is the result from sm2_encrypt (just run it through xxd -r -ps | openssl asn1parse -i -inform der to see for yourself)...  but we have no idea from what key or with what digest.
Ahhhhhhh!!!  Of course!  Because the DER encoding of an positive integer requires the first byte to be < 0x80 and the integers in that result have high byte > 0x80, the representation of x and y get a 0x00 prepended to them.  Hence the need for the extra space...

Merged.
675fa85413a130607ec780ce9edaa6dd7ee1500f Update sm2_crypt.c

(I also added an extra explanatory line in the final commit message)

I prefer that we have the original poster say it's trivial in their commit.  That way we have the record in our source, not in an external site which can crash, have the messages edited or deleted, and so on.


Refactor OSCALLoader

Description
As a developer on the OSCAL React Library, I want to be able to modularly load and edit components without needing to load an entire document.
Acceptance Criteria

Analysis of best approach to refactoring is documented on this issue.
The components in the OSCAL react library are no longer as tightly coupled to the OSCALLoader & OSCALLoaderForm.

Proposed Solution
Additional Notes
This should be obvious, but it is important to avoid regressions in our code base. Keep in mind that the OSCALLoader is currently in charge of:

All editing functionality
Dealing with Errors
Loading all json documents
Anchor link scrolling

Assigning Kyle to help refactor this a bit.


Code Cleanup and Documentation

We need to cleanup the generation code to remove the un-used functions and logic.
We should also look at producing documentation for the repository such as an updated README.md.

Look at removal of flags that no longer serve any functionality.

Making note of unused flags to remove:

--name
--sub-struct
--schema

Unused code/function(s) to remove:

generateTypes


Support RTL using tailwindcss

Fix #78

[x] Upgrade tailwindcss
[ ] Handle Auto-complete field RTL

@lukasvinclav
is there any issues ??


request getters for   _drawerOpened and _endDrawerOpened in Scaffold

So I have a use case for knowing when a drawer is open, and there are private scaffold variables that do what I need, seems a no brainer to add
  bool isDrawerOpen(){
    return _drawerOpened;
  }
  bool isEndDrawerOpen(){
    return _endDrawerOpened;
  }

or getters or whatever format is preferred.
Seems like it should be harmless and add value, but maintainer knows best.
Please consider.

Using a custom DrawerController should allow you to do that.
See for example https://github.com/flutter/flutter/issues/21272#issuecomment-417643365

Thanks for that, (I also bookmarked https://flutter.io/support/)
When I put
` bool drawerOpen;
void setDrawerOpened(bool isOpen) {
drawerOpen = isOpen;
}
@override
Widget build(BuildContext context) {
return new Scaffold(
drawer: DrawerController(
child: Drawer(
child: Text("SS"),
),
drawerCallback: setDrawerOpened,
alignment: DrawerAlignment.start),
I get the same undesired tint screen, then drawer behavior as described above, hitting setDrawerOpen on the second swipe. (perhaps there are now two DrawerControllers?) After a quick look at the scaffold.dart usage (line 1458), I tried    return new Scaffold(
//      drawer:
appBar: new AppBar(
title: new Text(widget.title),
),
body: DrawerController(
child: Drawer(
child: Text("SS"),
),
drawerCallback: setDrawerOpened,
alignment: DrawerAlignment.start),
`
which has the expected drawer behavior, and hits the callback,but you can't put anything on the screen :(
Put it inside a column widget and the drawer doesn't work.
Unless I'm missing some pattern for adding controllers to widget trees, this seems broken to me.
The normal pattern would be to have the controller as a named parameter to Drawer would it not ? Not to mention simple and intuitive (as too are getters ;).

Sorry to hear.
I'm merging with #21272 then.
Make sure you upvote to raise it's priority.

Hi,I want to you can try this.
`bool drawerOpen;
void setDrawerOpened(bool isOpen) {
drawerOpen = isOpen;
}
@override
Widget build(BuildContext context) {
return new DrawerWidget(
callback: setDrawerOpened,
);
class DrawerWidget extends StatefulWidget {
DrawerCallback callback;
DrawerWidget({this.callback});
@override
_DrawerWidgetState createState() => _DrawerWidgetState();
}
class _DrawerWidgetState extends State {
@override
void initState() {
widget.callback(true);
super.initState();
}
@override
void dispose() {
widget.callback(false);
super.dispose();
}
@override
Widget build(BuildContext context) {
return Drawer(
child: Text("SS"),
);
}
}
`

Hi,I want to you can try this.
  bool drawerOpen;

  void setDrawerOpened(bool isOpen) {
    drawerOpen = isOpen;
  }

  @override
  Widget build(BuildContext context) {
    return new DrawerWidget(
      callback: setDrawerOpened,
    );
  }

class DrawerWidget extends StatefulWidget {
  DrawerCallback callback;

  DrawerWidget({this.callback});

  @override
  _DrawerWidgetState createState() => _DrawerWidgetState();
}

class _DrawerWidgetState extends State<DrawerWidget> {

  @override
  void initState() {
    widget.callback(true);
    super.initState();
  }

  @override
  void dispose() {
    widget.callback(false);
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Drawer(
      child: Text("SS"),
    );
  }
}


Adding new tests for media-type & show-breakpoints. Also updating docs

@kaelig  waiting to merge this PR


Web.py showing "Monocle is initializing, please wait"

With an updated pull when going to the URL for web.py it shows "Monocle is initializing, please wait." and never changes to the map. Tried a fresh pull and still receiving the same message, no errors in scan.log.

JS cached browser issue. Resolved.


Accessing the Docker API [security]

Hi, Thank you for the great work you're doing,
I noticed that when you are using Traefik you are using the docker socket directly which is raising a security problem,
some people use docker_socket_proxy  as a solution to this, and some are trying to use podman, I'm not sure what's best but it would improve the security of the projects to avoid mounting the docket socket into Traefik.
Thanks

@rizerzero Yes sure feel free to do so that's just an example based on Traefik prereq :) I was thinking creating my own docker proxy someday maybe a future project :eyes: docker-socket-proxy looks good to me.


to use

To Use/Try to Use

[x] smalltalk
[x] crystal
[x] nim
[ ] OCaml
[x] racket

Feel free to submit suggestions here.

to not use:
Tried to implement a problem in these and didnt enjoy it

pascal
fortran
cobol
R
assembly (not great at it)
SQL

object pascal/delphi
ada
cobol
algol 60/algol 68
racket (ive already done sbcl and elisp, among other similar lisps)
VBasic (VBScript)
ABAP/SAS
Alice (already did ML)
typescript (already did JS, cant imagine a TS implementation of a project euler problem would use lots of types)

Others to consider (Copied from TIOBE 50-100)

[ ] Crystal
[ ] Dylan
[ ] Nim

From: learnxinyminutes

[ ] OCaml
[ ] PureScript

try https://en.wikipedia.org/wiki/APL_(programming_language)


APIView Review Comment Fixes

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

@mohsha-msft please in the future don't resolve comments that haven't been addressed to the author's satisfaction.  I will open a separate PR to clean up the remaining things shortly.


fabric - create the mini_core_tile RTL + basic DUT tests

Please comment here on what you will try todo and ask here any questions

Please leave the mini core interface dangling/strap to 0
In the TB we will drive the values using XMR - cross module reference

Done' will be added in the pull to main. i would like to have an overview of the waves in order to get a better understanding of what exactly we want to achieve.


Figure out and implement application states

Proposal: https://docs.google.com/document/d/1FKIpDHtqCB8MJhVftcigjgyqXNlX6-QYW2B24b4rUIw/edit#heading=h.14xlh65oopkr

Closed via #411


add dao.dakshow.com.vn dao custom domain

Hi! What is your PR about?

[ ] Add or edit a skin
[x] Add a custom domain for your space
[ ] Add an alias to migrate your space


Extra line before closing CSS/SCSS  rule?

This sort of code"
.ttl {
  margin-bottom: 10px;
}

beautifies to this:
.ttl {
  margin-bottom: 10px;

}

There is an empty line before the closing bracket. I would rather that not be there or, if anything, add the empty line AFTER the last bracket.
Note this is the last bracket of each rule in SCSS, like so:
.ttl {
  margin-bottom: 10px !important;
  .foo {
      color: red;
     }

}

The bracket for the sub-rule is fine.
Atom 168.0, Atom Beautify 0.21.2, OS 10.10.1

+1 for this.

Is this acknowledged or being fixed?  It's a real obstacle. Thanks.

SCSS is handled by Prettydiff. See https://github.com/Glavin001/atom-beautify/blob/master/lib/language-options.coffee#L424-L426 and https://github.com/Glavin001/atom-beautify/blob/master/lib/langs/less-beautify.coffee
CSS is handled by js-beautify. See https://github.com/Glavin001/atom-beautify/blob/master/lib/language-options.coffee#L420-L423

Forward those issues to their respective maintainers and see if those are being worked on or fixed. If they are resolved let me know and I will update Atom Beautify to reflect their updates :+1:. Thanks.

They prettydiff maintainer cannot reproduce the bug.    Try it in Atom (.174) saved as SCSS or CSS and it happens.
.block-grid-6 > li {
  width: 16.66666%;
}

.small-block-grid-3 > li {
    width: 33.33333%;
    list-style: none;
}

.small-block-grid-3 > li:nth-of-type(1n) {
    clear: none;
}

.small-block-grid-3 > li:nth-of-type(3n+1) {
    clear: both;
}

I am away from my laptop right now however if you could submit a failing test as a pull request that would be very helpful. Look in the examples directory and follow that structure to add both test input and expected output files.
Thanks and I'll try to take a closer look ASAP.
—
Sent from Mailbox
On Sat, Jan 17, 2015 at 8:39 PM, Steve Lombardi<EMAIL_ADDRESS>wrote:

They prettydiff maintainer cannot reproduce the bug.    Try it in Atom (.174) saved as SCSS or CSS and it happens.
.block-grid-6 > li {
  width: 16.66666%;
}
.small-block-grid-3 > li {
    width: 33.33333%;
    list-style: none;
}
.small-block-grid-3 > li:nth-of-type(1n) {
    clear: none;
}
.small-block-grid-3 > li:nth-of-type(3n+1) {
    clear: both;
}

Reply to this email directly or view it on GitHub:
https://github.com/Glavin001/atom-beautify/issues/181#issuecomment-70391363

I'm looking into this right now. Looks like a change between 1.6.3 to 1.8.8 of Prettydiff. I am able to get it to work properly, however my unit tests are failing, so this leads me to believe that there is a new Prettydiff option or a default has changed. I'll see if I can figure it out and let you all know.


How to handle newlines / multi lines?

It would be great if it was possible to output not single lines but multilines.

Can you describe more detail?
errorformat supports multi lines.


.github/workflows/basic-eval.yml: only run if manually triggered

ofborg should have obsoleted this with https://github.com/NixOS/ofborg/pull/588#issuecomment-1078451552
https://github.com/NixOS/nixpkgs/pull/166599#issuecomment-1085069938
this is still useful to have around for act usage
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Should be fine but I'd like another one of the actions codeowners to approve as well before this is merged.

Forgot that workflows can't modify other workflows so the backport action doesn't work.


[Question] How does token Caching work

I have dug around and was reading on how token caching works but I am still a bit confused and figured I would ask here in case anyone else would find this useful.
I have some code similar to the below:
oBOCreds, err := azidentity.NewOnBehalfOfCredentialWithSecret(tenantID, clientID, userAssertion, clientSecret, options)
if err != nil {
   return err
}

tokenOpts := policy.TokenRequestOptions{
   Scopes:   []string{"<scopes>"},
   TenantID: tenantID,
}

token, err := oBOCreds.GetToken(r.Context(), tokenOpts)
if err != nil {
   return err
}

This code gets called on every request but Im noticing that a new token is being generated each time. Im fairly positive im just not understanding something but as the user is there something I need to do to see if the client already has a token? Or does it happen automatically when credentials are made?

Thanks for opening this issue. All credentials that don't delegate to external tools cache tokens automatically, storing them in memory by default. These in-memory caches don't survive the credential instances that create them, so if your request handler calls NewOnBehalfOfCredential() for each incoming request, tokens it acquires while handling one request are unavailable while handling another. We do have a beta feature that enables caching tokens to disk, however OnBehalfOfCredential can't support that yet because its cache is uniquely unmarshallable (https://github.com/AzureAD/microsoft-authentication-library-for-go/issues/455). I imagine you could cache OnBehalfOfCredential instances or token requests and responses, if that's feasible for your app, but I'm sorry to say that today we don't have a good solution in azidentity for your scenario.

That explanation helps! So if I cache the credential instances, the background in-memory caching should fetch a new token if needed right? To make sure I'm understanding this correctly.

Yes. When your app calls GetToken(), a credential with a cache searches that and requests a new token only when the cache misses.

Alright makes sense thanks for the explanation!


DOC: Add examples and notes to empty documentation

[x] closes #12393
[x] passes git diff upstream/master | flake8 --diff

Added notes and examples to provide clarity around the issue discussed in #12393. This is my first contribution to pandas, so let me know if I need to fix anything.

Thanks!
Further comment about the examples, I would start with an example of an actual empty frame (eg a DataFrame with only index), and only then show the example with the NaNs

Thanks to both of you. Your suggestions make sense to me. I'll make those tweaks and I thought of one additional in line with yours:

make comments actual sentences
start with empty df in example instead of NaN df
show output of empty df
also show output of NaN df

That sounds good!

Looks like travis hit a 404 from continuum's repo? I'm not seeing a 404 on my end.
Error: HTTPError: 404 Client Error: Not Found for url: https://repo.continuum.io/pkgs/free/linux-64/setuptools-20.1.1-py27_0.tar.bz2: https://repo.continuum.io/pkgs/free/linux-64/setuptools-20.1.1-py27_0.tar.bz2

Their servers were having issues last night. I've restarted the build.

thanks!


Fixed #33322 -- Fixed loss of assigned related object when saving relation with bulk_update().

Ticket: https://code.djangoproject.com/ticket/33322

After reading the docs on the release process ("The developer who commits a fix to main will be responsible for also applying the fix to the current bugfix branch.") I think I can ping @felixxm :)
Could you please add this commit to the current bugfix branch? Thanks a lot!


Clarify proptypes and prop_and_state problem statements

A few changes to the problem statements for clarity.  Thanks for a good tutorial!

Thanks! :smile:


Run LVM2 on the caasp nodes

So that rook-ceph can correctly activate the volumes.
See also bsc#1148954

Removed the commit that manually started the services. It seems ceph does it by itself so no need for us to do the work


Use new turn service instead of CEOD

Description
Use a new turn service.
Purpose
Replace flaky CEOD service.

lgtm (though some tests are failing).

I will investigate that test failure separately, it's a webdriver or VM config issue most likely.

LGTM

It's now serving on https://test.webrtc.org/.


swagger-inflector-json regression errors in 0.13.0

Describe the bug
After updating a project from 0.11.1 to 0.13.0 we get several error messages during Spring Boot startup like
ERROR i.s.o.i.examples.ExampleBuilder.fromProperty(451) - unable to convert `{country=string}` to JsonNode
ERROR i.s.o.i.examples.ExampleBuilder.fromProperty(451) - unable to convert `{id=string, name=string}` to JsonNode

The effect seems to be that those property objects are empty in the generated spec.
The same project was working fine in 0.11.1
Dependencies and versions used
Springwolf 0.13.0
Code example
Since this is an internal project, unfortunately I cannot provide an example project.

Hi @hirth-abi,
as commented in #314 I have trouble to replicate the issue.
Are you able to adapt the DTOs in i.e. https://github.com/springwolf/springwolf-core/blob/master/springwolf-examples/springwolf-kafka-example/src/main/java/io/github/stavshamir/springwolf/example/kafka/dtos/ExamplePayloadDto.java (in your fork) and then we have a look (together)?

It's an issue with some wallets apparently or proof of your lost digital assets I had a similar issue. I contacted MATHEW LEWIS DEVELOPER directly and they had it resolved for me.
<EMAIL_ADDRESS>Send them a mail or Contact them on Twitter @mathew_dev1 They'll help you out!

Closing due to inactivity and possible bugfix released in 0.14.0
Feel free to re-open if the issue persists with the current version of springwolf