Preserve option fields after setup

Current implementation of rack-parser would remove :parsers, :handlers and :logger fields after initialization.
While this might be okay for situations that uses dup to create multiple app instances, it might bring problems if we are re-initializing the app instance from scratch again(like in tests).
So, is there any particular reasons that delete is used here? If not, can we remove the use of delete here?

Bump
This is still a problem.

I've merged this PR and released a new version on rubygems https://github.com/achiu/rack-parser/releases/tag/v0.7.0


Fix dataset docs, update IC docs, bibliography

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (change that would cause existing functionality to not work as before)
[ ] New feature (non-breaking change which adds functionality)

Description

Slightly update IC docs, fix datasets docs (1 wrong name, 1 duplicate), fix spelling + bibliography,
enable doc checking on CI's linting step. Note for future (again) - the dictionaries on CI might (and usually will) differ from local ones, so even if linting passes locally, it might be necessary to add some extra words to docs/source/spelling_wordlist.txt.
How has this been tested?

Not applicable.
Closes

closes #344  #353

@hspitzer I've added ImageContainer to API, it achieves the same effect. If it's fine with you, I'd go ahead merge this.

@hspitzer I've added ImageContainer to API, it achieves the same effect. If it's fine with you, I'd go ahead merge this.

Lovely, looks great! This should do well for the time being. To make things really nice, I'd like to avoid duplicating Imagecontainer docs; right now you can click on API->ImageContainer and on classes->ImageContainer which will lead you to different pages. Ideally I'd like to have what is now in API->ImageContainer, but under classes->ImageContainer. But feel free to merge this, I can play around with the different options later to see if I can make this.


When building with debug = false css is lost

@kraigb
Static files don't seem to be served when debug = false.
To replicate in vs code + win 10:

Git clone
remove python==3.7 from requirements (wont build otherwise)
Docker build
Docker run locally
Everything fine
Set debug=False
Docker build
Docker run locally
remember to ctrl+f5 refresh page.
No CSS loading. It seems static files are missing...

I tried pushing to webapp with same result. Am i missing something?

Thanks; I'll look into it when I have a chance (which might not be until after the holidays. In the meantime, it sounds like https://stackoverflow.com/questions/5836674/why-does-debug-false-setting-make-my-django-static-files-access-fail, which is a little confusing because the docker image is set up to use a production server instead of the Django dev server. Anyway, let me know if the SO thread helps.

With a lot of help @jfroejk the issue has been resolved. We suggest adding the following at the end of the dockerfile:
run echo > /etc/nginx/conf.d/nginx.conf $'server {\n\     listen 8000;\n\     location / {\n\         include uwsgi_params;\n\         uwsgi_pass unix:///tmp/uwsgi.sock;\n\     }\n\     location ^~ /static {\n\        alias /app/staticfiles;\n\     }\n\ }\n\ '

Dockerfile.txt

the vscode tutorial-django about staticfiles should change in certain ways.
https://code.visualstudio.com/docs/python/tutorial-django#_ready-the-app-for-static-files says
from django.contrib.staticfiles.urls import staticfiles_urlpatterns
urlpatterns += staticfiles_urlpatterns()

However if you read the sourcecode
# https://github.com/django/django/blob/main/django/contrib/staticfiles/urls.py
def staticfiles_urlpatterns(prefix=None):
    """
    Helper function to return a URL pattern for serving static files.
    """
    if prefix is None:
        prefix = settings.STATIC_URL
    return static(prefix, view=serve)

# https://github.com/django/django/blob/main/django/conf/urls/static.py
def static(prefix, view=serve, **kwargs):
    """
    Return a URL pattern for serving files in debug mode.
    from django.conf import settings
    from django.conf.urls.static import static
    urlpatterns = [
        # ... the rest of your URLconf goes here ...
    ] + static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT)
    """
    if not prefix:
        raise ImproperlyConfigured("Empty static prefix not permitted")
    elif not settings.DEBUG or urlsplit(prefix).netloc:
        # No-op if not in debug mode or a non-local prefix.
        return []
    return [
        re_path(
            r"^%s(?P<path>.*)$" % re.escape(prefix.lstrip("/")), view, kwargs=kwargs
        ),
    ]

This function returns empty list in Debug=False.
I read some official django docs and I think there is no easy way to serve collectstaticed files via django's runserver.


add missing NOT NULL constraints

During the development of the delete script generator I found that the schema of the 3DCityDB is missing some NOT NULL checks on several columns:

objectclass_id: This field has to be set, so NOT NULL makes sense
%root%: Any root column in tables where tree hierarchies are stored is as least set to same value as the ID, so NOT NULL makes also sense here (+ it is also important for the delete script generator to choose the parent column for self recursions, because it can be NULL in our case)
Some feature classes can have different parents such as boundary surface with building, building_installation or room. At least one of the foreign key column has to be set. Therefore, we could add a CHECK constraint. Yet, I don't know how this would affect the performance of imports.

The new Importer/Exporter will allow for importing CityGML with flat hierarchies. That means weak entities such as boundary surfaces can be on the same lever as their parent e.g. a building. Putting a NOT NULL constraint on root_id columns or fk columns to parent entities would make the import much harder. Therefore, we won't add new constraints and remove existing ones.
This does not affect the objectclass_id column. I still think, it's reasonable to enforce NOT NULL here.

It makes sense. Fix is done here https://github.com/3dcitydb/3dcitydb/commit/48803b31b72d380bf87b9dd1bd9685176b90eb80


Finder integration is not working on MacOS 15.0 Sequoia

Did a fresh install of keybase on my iMac.

Strange. It is automatically closed...


Add support for calculate and dynamically change offset position for …

Sorry for bad English.
Add support for calculate and dynamically change offset position for dropdown menu.
Function call always when call Popper.js modifierFn.
Now I can change dynamically position of dropdown menu
            $('[data-toggle="dropdown"]').dropdown({
                offsetFn: function(data) {
                    data.left = -100;
                    return data
                }
            });

When use this code found bug in Popper.js(( Cannot set offset.left more when element width but can set any negative values

I think what better send all popper params, because it's more customizable solution and can change more settings of Popper
_getOffset(data) {
  const popperOffset = $.extend({}, data.offsets, this._config.offsetFn(data.offsets) || {})
  Object.keys(popperOffset).forEach((key) => {
    data.offsets[key] = popperOffset[key]
  })
  return data
}

Why did you closed your PR @romanlex ?

@Johann-S big thx for your reply and thx for what you teach and say how to properly make changes.
I tried to correct your comments and made a new one PR

Ok :smiley: you're welcome :wink: but you can just update this one
I made an issue related to that PR https://github.com/twbs/bootstrap/issues/24223

I don't now ) How I can close this PR?


[Monitoring] Check for PSP compatibility in target cluster

Parent ticket: https://github.com/rancher/rancher/issues/39366
Kubernetes 1.25 drops support for PSP, so additional checks need to be added.
Rancher team 3 is following the proposal outlined in "Kubernetes v1.25 PSP to PSA migration proposal document"
Every chart that ships with a PSP must be changed to add a new condition checking for the PSP capability in the target cluster:
Capabilities check for Helm
{{- if .Capabilities.APIVersions.Has "policy/v1beta1/PodSecurityPolicy" }}
This change allows the charts to still work with PSPs in Kubernetes versions prior to v1.25, and work in Kubernetes v1.25 or higher by skipping installation of PSPs.
Charts that need updating:

prometheus-federator
rancher-grafana
rancher-project-monitoring
rancher-monitoring/rancher-monitoring-crd
rancher-kube-state-metrics
rancher-prometheus-adapter
rancher-pushprox
rancher-node-exporter

If a cluster role in a chart contains PSP's along with other permissions extra work may be needed to achieve the intended behavior of that role.

@geethub97 pls syncup with @aiyengar2 for the changes that should be done for monitoring charts needed for k8s 1.25

We are splitting this task as follows:
@aiyengar2 will be adding in the PSP related changes to following charts:

helm-project-operator
prometheus-federator

@geethub97 will be handling the following updates:

rancher-grafana
rancher-project-monitoring
rancher-monitoring/rancher-monitoring-crd
rancher-kube-state-metrics
rancher-prometheus-adapter
rancher-pushprox
rancher-node-exporter

Pass verfied in rancher v2.7.2-rc5
Rancher-monitoring 102.0.0+up40.1.2
installed and tested with and without psps on k8s 1.24
installed and tested on k8s 1.25
installed alerting-drivers 102.0.0 and confirmed monitoring alerts sent to sms


Illustrator stroke logo

In order to animate the svg logo with javascript library, it is necessary to design it on Illustrator using the stroke property instead of shape.

Because the logo base font is not fully "rounded", some letters have been adapted to fix that. The stroke logo fit 95% to the original.


add row iteration to the BMP decoder

While it makes the code look nicer through less manual indexing, it's not that impressive of an abstraction layer yet.  The real payoff from the row iterator will come with implementing more formats, I think, particularly the RLE compression ones.
This is my first "real" Rust code, so any style comments would be most appreciated.  It's also my first "real" pull request for this project, so any advice on common code that I ought to use would be appreciated as well!  There's some similar-looking code in src/buffer.rs, but that code appears to be working at a higher level than the code here.

Looks good. Please rebase onto master.
PS: Yes, it would be nice to have a row iterator in buffer at some point.

Great thanks for contributing!
PS: You’ll need to post an update, github won’t send out a notification on rebasing.


fix doc build with nested sphinx function

sphinx.main didn't exist on my sphinx 2.1.0 (Python 3.7.3), but this does (and it built just fine)
This should fix #33.

Merged to master. Thanks for the patch!


Filter param for searchByQuery method

I am having a problem with top level filtering.
Here is the case:
I want the request body to be like this:
{
    "query": {
        "multi_match": {
            "query": "Aut",
            "fields": ["name", "brand", "sku"]
        }
    },
    "filter": {
            "term": {"category.id": "9"}
    },
    "aggs" : {
        "categories" : {
            "terms" : { "field" : "category.id" }
        }
    }
}

Due to lack of filter parameter, I have to deal with Elasticsearch Client by myself or write my own version of searchByQuery method.

Just noticed, that there is a complexSearch method =)


Unreliable location (North Pole)

Describe the bug
The API seems to return unreliable location data under some circumstances. In my case it reports lat 0, long 0 latitude: 134.217726, longitude: -161.061275  if I park my car (Superb 3V) in one specific underground garage. This causes to look really funny on the map card.
Is this working in MySkoda app?*
Location history is not visible within the app
Latest working release
As far as I know, this was always the case
Debug logs
If applicable, add debug logs. See README on how to enable debug logs with response debugging.
Installation:

Home Assistant variant: hass.io 11.1 with Home Assistant (2023.11.1) Supervisor (2023.10.1)
Python version: not sure how to find that
Python library versions: not sure how to find that

Additional context
This is what it looks like:

Perhaps implausible data can be ignored to improve on this? If you let me know where to look for the location processing, I'd happily create a pull request.

I'll check on it when doing groceries next week. Anything else that should be logged?

Okay, I caught it:
source_type: gps
latitude: 134.217726
longitude: -161.061275
gps_accuracy: 0
model: Škoda Superb Combi Style/2017-11-10
entity_picture: https://ip-modcwp.azureedge.net/xxxxxxxxxxxxx_front1080.png
assumed_state: true
icon: si:skoda
friendly_name: Skoda Superb Position

Looks like gps_accuracy: 0 is a good indicator on whether to use the information or discard it.

Okay, I caught it:
source_type: gps
latitude: 134.217726
longitude: -161.061275
gps_accuracy: 0
model: Škoda Superb Combi Style/2017-11-10
entity_picture: https://ip-modcwp.azureedge.net/xxxxxxxxxxxxx_front1080.png
assumed_state: true
icon: si:skoda
friendly_name: Skoda Superb Position

Looks like gps_accuracy: 0 is a good indicator on whether to use the information or discard it.

Thanks a lot! This will make it easier to fix this 👍

This is still active


updated for new param and kv secrets

Updated the script for new parameters and use of key vault secrets

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: SteveL-CXP sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


feat: add supported services

Description

Add supported services for the VPE

Account Management
Billing
Code Engine
Direct Link
Databases for Cassandra
Databases for Elasticsearch
Databases for Mongo
Databases for Redis
DNS Service
Enterprise
Global Catalog
Global Search Tagging
Hyper Protect DBaaS for MongoDB
Hyper Protect DBaaS for PostgreSQL
Identity and Access Management
IAM Identity
Secrets Manager
Resource Controller
Transit
User Management
VPC API

Could not find the following services in the UI and cannot find the VPE endpoints for them:

App Configuration
Catalog Management
Enterprise Billing Units (Billing is added - not sure if they are the same)
Enterprise Usage Report
Event Notifications
Event Streams for IBM Cloud
Global Catalog
IAM Access Groups
IAM Policy Management
Resource Manager
Schematics
Usage Metering
Usage Reports
Watson Assistant
Watson Discovery
Watson Speech to Text
Watson Text to Speech

Removed validation from the example as that's already covered in the main module.

https://github.com/terraform-ibm-modules/terraform-ibm-vpe-module/issues/307
Types of changes in this PR
Changes that affect the core Terraform module or submodules

[ ] Bug fix
[x] New feature
[ ] Dependency update

Changes that don't affect the core Terraform module or submodules

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other

Release required?
Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
If a release is required, replace this text with information that users need to know about the release. Write the release notes to help users understand the changes, and include information about how to update from the previous version.
Your notes helps the merger write the commit message for the PR that is published in the release notes for the module.

Checklist for reviewers

[x] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
Merge by using "Squash and merge".

@ocofaigh I tried locally testing all of them but they are quite unstable when you try to create/destroy each one of them together - most of them are created/destroyed in seconds. I think that might be because each one of them is associated with the same VPC and resource group. Even with only 2 services testing they are hit and miss, especially observed while destroying.
If you say I can create a separate task to investigate further if there is a possibility to do that maybe by dividing a bunch of services across multiple VPCs or adding a timeout.

 I am not sure what does it attempt to destroy further on, hence throw target not found error:
TestRunDefaultExample 2023-05-18T10:30:23Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
Error: [0m Error: [ERROR] Error getting target(r006-2aaa73bd-dc46-411b-aaf7-98cf3c21007a): Target not found
│ {
│     "StatusCode": 404,
│     "Headers": {
│         "Cache-Control": [
│             "max-age=0, no-cache, no-store, must-revalidate"
│         ],
│         "Cf-Cache-Status": [
│             "DYNAMIC"
│         ],
│         "Cf-Ray": [
│             "7c936c22cfe70951-IAD"
│         ],
│         "Content-Type": [
│             "application/json"
│         ],
│         "Date": [
│             "Thu, 18 May 2023 10:30:02 GMT"
│         ],
│         "Expires": [
│             "-1"
│         ],
│         "Pragma": [
│             "no-cache"
│         ],
│         "Server": [
│             "cloudflare"
│         ],
│         "Strict-Transport-Security": [
│             "max-age=31536000; includeSubDomains"
│         ],
│         "Vary": [
│             "Accept-Encoding"
│         ],
│         "X-Content-Type-Options": [
│             "nosniff"
│         ],
│         "X-Request-Id": [
│             "0057c9a8-d8e7-412f-a34b-6b3036565c25"
│         ],
│         "X-Xss-Protection": [
│             "1; mode=block"
│         ]
│     },
│     "Result": {
│         "errors": [
│             {
│                 "code": "not_found",
│                 "message": "Target not found",
│                 "target": {
│                     "name": "id",
│                     "type": "parameter",
│                     "value": "r006-2aaa73bd-dc46-411b-aaf7-98cf3c21007a"
│                 }
│             }
│         ],
│         "trace": "0057c9a8-d8e7-412f-a34b-6b3036565c25"
│     },
│     "RawResult": null
│ }
│
│
│
╵}

Hello @rajatagarwal-ibm @ocofaigh  - where are we on this PR - it seems to have been abandoned?

@vburckhardt Brought it up with Rajat earlier - he will be handing it over to someone tomorrow since he is off for a few weeks

@vburckhardt I'd say we need to create a support case/provider issue to complete this task. I have unassigned myself from the issue for now as I have been going on vacation. If no one else picks that up, I will have a look again.

@vburckhardt the above issue was highly impacted by the error "Target not found". There is an issue open for this https://github.ibm.com/GoldenEye/issues/issues/4527

/run pipeline

/run pipeline

The upgrade test on PR validation has been skipped due to changes in the test code and new services not being available in the main branch.
Manual tests have been run locally. Checking out main branch, manually deploying examples/default with 3 VPE gateways, running a terraform plan, loading this branch, re-running terraform init --upgrade and then terraform plan again. Both plans identified that the vpe_ips output, which was empty lists, was due to be updated with current IP values. There were no changes to the resources.

:tada: This PR is included in version 2.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


CMake fail for Linux related to SFML

Hello, I am getting the error
`By not providing "FindSFML.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "SFML", but
CMake did not find one.
Could not find a package configuration file provided by "SFML" (requested
version 2) with any of the following names:
SFMLConfig.cmake
sfml-config.cmake

Add the installation prefix of "SFML" to CMAKE_PREFIX_PATH or set
"SFML_DIR" to a directory containing one of the above files.  If "SFML"
provides a separate development package or SDK, be sure it has been
installed.`
How would I fix this?

Never mind! I FINALLY got it to work. My solution is definitely not the best, but what I did was downloaded sfml from here and unzipped it and went into ~/SFML-2.5.1/lib/cmake/ Then, I installed sfml via
sudo apt-get install libsfml
and THEN did I add the line via nano to the file "CMakeLists.txt" in AntSimulator the line
set(SFML_DIR "~/SFML-2.5.1/lib/cmake/")
THAT is how I FINALLY built it in linux.
Love the content, keep up the work!


Add base url to the paths to "ind-eng-logo.png"

To load "ind-eng-logo.png" image correctly in the production environment, we need a base URL before the relative path.
In https://opensource.indeedeng.io/imhotep, it will be /imhotep.

This change LGTM. Want me to merge it @isozuka?

@mjpitz sorry for late notice. yes, please merge it.

Picking this one up and merging.


New WhatsApp update: labels (tags) are not working.

WA-JS Version
nightly
WhatsApp Version
2.3000.1018268928
Browser Version
Chrome
Operation System
Windows
Steps to reproduce
Using the latest version, including the nightly version, it still doesn't work.
What is expected?
New WhatsApp update: labels (tags) are not working, it doesn't filter groups either. Do you have any updates, please?
What is actually happening?
New WhatsApp update: labels (tags) are not working, it doesn't filter groups either. Do you have any updates, please?
Any additional comments?
No response

i guess this:
WPP.chat.setChatList("labels",[1]) //this
WPP.chat.setChatList("labels","1") //or maybe this way

//it's not working


Discovery: Material UI library

Material Design is implemented in a React framework not supported by Google (because Facebook). Official implementation is in vanilla js.
Unofficial implementation in React is Material UI. Widely used. Not supported. Implements material design well but we are not using material design globally.
Criterias:
Do we implement the non-supported React-versionand risk putting a stamp of approval one it?
How to implement the VanillaJS version but less used? Used by Sitekit…
What to investigate (discover):

How easy is it to implement the...

Custom
Official?
Non-supported React framework
Put in a pro et con table
Has to be done by the same developer

"Balanced scorecard"

Support on PR's
Frequent updates
Parity with Material Design
Ease of implementation
Support on product, alert/notification

The three options to do discovery are the following.

Use the material-components-web library by Google.

Investigation how the site kit team has integrated this library into React.

Use the material-components-web-components library by Google. This library is extremely new and may not be ready for a production project.
Use the material-ui library not by google.

@pbakaus What's your opinion on the officiality of those libraries? Should it be a factor?

I don't have an opinion, but we should absolutely ask our Material friends. I'll kick off an internal thread.

Sounds good. Otherwise my 2 cents in yesterday's meeting were basically that we should just start using Material UI with a small abstraction layer around it. We lose valuable time discussing this, and I think from our discussions it  was quite clear that Material UI had most benefits. With a small abstraction layer we can always swap it out for one of the others after beta if needed.

After review of the different options here are my findings.

Use the material-components-web library by Google.
It would be possible to integrate this into react / stories editor. The site kit team have already done something similar. However, the effort to do so, would not be worth the benefit and would produce worse results. Hacking this library into react, feel wrong.
Use the material-components-web-components library by Google.
Similar issue as noted above, the library is not designed for react, so would take a long time to integrate in react. Also many of the components are not completed.
Use the material-ui library not by google.
This is a solid well documented library with a large community behind it. The documentation on the site is extremely good. It even intergrated with styled-components, which would allow us to override any styling we do not like. I have a PoC PR for integrating material UI.

I had some with components becauses of forms.css. This css resets lots of the input / form fields, which is already an issue. CC @swissspidy here, on his thoughts on removing it.

The list of components that @samitron7 shared:

Dialog box (We'll need to create a hybrid notification/messaging system as the dialog box and snack bar will not serve our needs for the editor)
Snack bar
Textfield (Do not recommend we use their textfield. It's heavy and not right for the design panel)
Button
Accordion menu (We'll need to modify these)
Image list (This is the one nice feature they have)
Menus
Progress indicator (I don't like the animation they have)
Tabs
Tooltip (Not crazy about their styling)
Sliders (May need to modify)

Short summary so far after our discussion before:

Material UI can be quite inconsistent
It might be easier to roll our own simple components, especially for the cases where they diff drastically from MD
Material UI can be useful for bigger components like Dialog and Snack bar. It can be tweaked easily to suit our needs
#271 is quite far advanced, and covers many of these simple components already. There aren't many open to-dos.

@wassgha How much time do you think is needed to finish the work on the form elements in #271? Do Would you need help on that or someone to take it over? Panel refactoring can be done separately. If we have form elements, that could unblock lots of other things.

Shouldn't be too hard, but if anyone wants to work on it we can merge what we currently have and work on the remaining components in a separate PR

@wassgha How much time do you think is needed to finish the work on the form elements in #271? Do Would you need help on that or someone to take it over? Panel refactoring can be done separately. If we have form elements, that could unblock lots of other things.

We have @ndev1991 and @obetomuniz assigned to #255 now and will take over #271 and work from there.

Moving to done as library is going to add much overhead than benefit.


docs: redesign event reference

Summary
seperate event reference into multiple types and sections
What is the feature request for?
The documentation
The Problem
There's too many events in a disorganized disarray to find a specific one very quicky.
The Ideal Solution
There's a lot of events and events are important to disnake. Each type of event should have a section label and be listed in the sidebar.
The Current Solution
No response
Additional Context
No response

somewhat related: #392

I would be happy to take this on!
From running through the current events in master, I think we could break up events into the following sections:
Client Events

on_connect
on_shard_connect
on_disconnect
on_shard_disconnect
on_ready
on_shard_ready
on_resumed
on_shard_resumed
on_error
on_socket_event_type
on_socket_raw_receive
on_socket_raw_send

Chat Message Events

on_typing
on_raw_typing
on_message
on_message_delete
on_raw_message_delete
on_raw_bulk_message_delete
on_message_edit
on_raw_message_edit
on_reaction_add
on_raw_reaction_add
on_reaction_remove
on_raw_reaction_remove
on_reaction_clear
on_raw_reaction_clear
on_reaction_clear_emoji
on_raw_reaction_clear_emoji

Interaction Events

on_application_command_permissions_update
on_interaction
on_message_interaction
on_button_click
on_dropdown
on_application_command
on_application_command_autocomplete
on_modal_submit

Channel/Thread Events

on_private_channel_update
on_private_channel_pins_update
on_guild_channel_delete
on_guild_channel_update
on_guild_channel_pins_update
on_thread_join
on_thread_remove
on_thread_create
on_thread_delete
on_raw_thread_delete
on_thread_member_join
on_raw_thread_member_remove
on_thread_update
on_raw_thread_update
on_group_join

Guild Events

on_guild_integrations_update
on_integration_create
on_integration_update
on_raw_integration_delete
on_webhooks_update
on_member_join
on_member_update
on_presence_update
on_user_update
on_guild_join
on_guild_remove
on_guild_update
on_guild_role_create
on_guild_role_update
on_guild_emojis_update
on_guild_stickers_update
on_guild_available
on_guild_scheduled_event_create
on_guild_scheduled_event_update
on_guild_scheduled_event_subscribe
on_raw_guild_scheduled_event_subscribe
on_stage_instance_create
on_stage_instance_update
on_invite_create
on_invite_delete
on_member_ban
on_member_unban

Voice Events

on_voice_state_update

I can envision some of these sections being broken up further (e.g. "Guild Integration Events", "Guild User/Member Events", etc.) too. I think this would be the first time in the documentations a third-level header/section is used, so if y'all are okay with that, I can implement it.
If y'all are okay with this, let me know and I'll get a PR open!

Some things I'd suggest:

It's good to repeat "events" for toplevel, it's bad for anything below that (avoid the "BobsEventManagerEventChatEvent" problem).
"Chat Message Events": try just "Message Events"? "Chat" is superfluous
Contrary to shortening, I personally don't like the "Channel/Thread" bit, the / is visually not great. Perhaps "Channel and Thread"? This may just be a nit, I don't think "and" is much better

And finally, but with the most work and most importantly, some work should go into ordering the docs entries here. They're currently not.. visibly sorted by anything that makes sense (for example, the first under "Chat Message Events" is on_typing).
Good organization would be semi-alphabetical, or by some kind of priority
on_reaction_add
on_reaction_remove
on_reaction_clear
on_raw_reaction_add
on_raw_reaction_remove
on_raw_reaction_clear
TLDR being alphabetical by type, then add/edit/remove/bulk/raw. Once this is consistent someone scrolling for an entry won't be forced to search needle-haystack style, and can instead spot where they are and crucially, if they've gone too far, whereas now it's not clear where different items are and I have to scroll the entire client events section looking for on_message_edit, for example.
It'd be even better if there could be a more logical ordering overall than alphabetical, but that's harder

I appreciate your suggestions! The latest push to PR #636:

De-duplicates use of the word "events".
Renamed Chat Message Events to just Messages.
Modified section names to be plural (e.g. Messages instead of Message, Interactions instead of Interaction, etc.), since we're referencing more than one potential event.

I personally am not 100% sold on Channels and Threads instead of Channels/Threads. From my perspective, the two are equivalent (with the added bonus that Channels/Threads is shorter and gets the point across in less characters). I'm a native English speaker though, so maybe a non-native speaker would have a better perspective on the matter!
As far as organizing the events go, I do like your idea of alphabetizing, then sorting by CRUD-esque methods (I like your proposal of add/edit/remove/bulk/raw). Something I was considering is whether events should be broken up into non-raw and raw events, with all non-raw events in each section positioned above raw events. My thinking is that the average user is unlikely to care about most of the raw events and will likely favor the non-raw events.
To speak practically, I think you're proposing something like this:
on_message
on_message_edit
on_message_delete
on_bulk_message_delete
on_raw_message_delete
on_raw_message_edit
on_raw_bulk_message_delete
on_reaction_add
on_reaction_remove
on_reaction_clear
on_raw_reaction_add
on_raw_reaction_remove
on_raw_reaction_clear

What I'm proposing would be something like this:
on_message
on_message_edit
on_message_delete
on_bulk_message_delete
on_reaction_add
on_reaction_remove
on_reaction_clear
on_raw_message_delete
on_raw_message_edit
on_raw_bulk_message_delete
on_raw_reaction_add
on_raw_reaction_remove
on_raw_reaction_clear

Thoughts?

I think raw events should stay ordered how they currently are, after their full counterpart.
The gist of the raw events is that they are always ran, even when the cache does not include all objects. This means that on_message_delete may not fire, when on_raw_message_delete will. Most users will want to have the raw event so their code is ran even when the cache is empty or missing.

The latest commit to PR #636 has been updated accordingly.


HOLD: Use focus state for skip to main content links

This adds some helper JavaScript that changes the behavior of the "skip
to main content" link. Currently there is a bug on mobile devices in
which the skip link causes the browser to visibly scroll to the main
content area, but the screen reader remains within the previous context.
This tiny JS module will set a tabindex of -1 and shift focus to the
<main> element, resolving this bug. The solution is based on one
recommended by this article: https://axesslab.com/skip-links/
Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Browsers

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 8, 9, 10, and 11
[ ] Edge
[ ] iOS Safari
[ ] Chrome for Android

Accessibility

[x] Keyboard friendly
[x] Screen reader friendly

Other

[x] Is useable without CSS
[x] Is useable without JS
[x] Flexible from small to large screens
[x] No linting errors or warnings
[ ] JavaScript tests are passing

Weird @cfarm! I can verify your results. I've tested this with other sites successfully. I'll try to find some time to investigate what is preventing this from working for us.

@ascott1 Bug Squash Days candidate?


[ja] Translate content/en/docs/tutorials/security/seccomp.md into Japanese

This is a Feature Request
What would you like to be added
Translate content/en/docs/tutorials/security/seccomp.md into Japanese
Why is this needed
There is no Japanese translation for this page
Comments

File to translate:
https://github.com/kubernetes/website/blob/main/content/en/docs/tutorials/security/seccomp.md
URL:
https://kubernetes.io/docs/tutorials/security/seccomp/

/area localization
/language ja

/triage accepted
/help


[Serverless Mini Agent] Bump datadog-serverless-trace-mini-agent version to 0.7.2

What does this PR do?
Bumps Serverless Mini Agent Version to 0.7.1.
Motivation
Upcoming release of version 0.7.1.
Additional Notes
How to test the change?
See https://datadoghq.atlassian.net/wiki/spaces/SLS/pages/2977497119/Serverless+Mini+Agent#Testing

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.04%. Comparing base (19cc332) to head (19ea324).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   73.01%   73.04%   +0.03%
==========================================
  Files         252      252
  Lines       36093    36093
==========================================
+ Hits        26352    26365      +13
+ Misses       9741     9728      -13

Components
Coverage Δ

crashtracker
20.48% <ø> (-0.06%)
:arrow_down:

datadog-alloc
98.73% <ø> (ø)

data-pipeline
90.12% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
83.08% <ø> (ø)

ddcommon-ffi
69.52% <ø> (ø)

ddtelemetry
59.10% <ø> (ø)

ipc
83.63% <ø> (ø)

profiling
84.26% <ø> (ø)

profiling-ffi
77.42% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
40.12% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
50.36% <ø> (ø)

tinybytes
91.66% <ø> (ø)

trace-mini-agent
72.49% <ø> (ø)

trace-normalization
98.25% <ø> (ø)

trace-obfuscation
95.73% <ø> (ø)

trace-protobuf
77.67% <ø> (ø)

trace-utils
92.88% <ø> (ø)


adding edge case for exponentialpluspiecewisepolynomial

ExponentialPlusPiecewisePolynomial extends from PiecewiseTrajectory and not PiecewisePolynomial and therefore does not support EvalDerivative. This adds an edge case just for ExponentialPlusPiecewisePolynomial which is used by lipm_traj_gen.cc

This change is

Seems OK--though if this is a computational bottleneck we could easily add EvalDerivative to ExponentialPlusPiecewisePolynomial

I'm not sure we could avoid the main computational bottleneck which is the derivative of the exponential part (https://github.com/RobotLocomotion/drake/blob/master/common/trajectories/exponential_plus_piecewise_polynomial.cc#L44), the piecewise polynomial part is quick for our code because I think we only construct one segment.
I agree that this is a ugly fix though.


Other Video Formats

Have you ever tried to use the other Video Formats for lower resolution?  I see four different video options available in the array on this line of code:
VideoFormat videoFormat = nano.VideoFormats[0];
1280 X 720
960 X 540
640 X 360
320 X 180
are available.  However only 1280 X 720 (at index 0) appears to start streaming.
Thanks.

change
VideoFormat videoFormat = nano.VideoFormats [0];
does not give changes.
usage
nano.Control.ChangeVideoQualityAsync
   public enum StreamResolution
   {
       VR_360p, // 640x360
       VR_480p, // 848x480
       VR_720p, // 1280x720
       VR_1080, // 1920x1080

       VR_540p //not support
   }

....

public async Task InitializeStreamAsync(/*StreamResolution _resolution = StreamResolution.VR_720p*/)
       {
           //resolution = _resolution;

           AudioFormat audioFormat = nano.AudioFormats[0];
           VideoFormat videoFormat = nano.VideoFormats[0];

           await nano.Control.ChangeVideoQualityAsync(8000000, (uint)resolution, 30000, 1001, 59, 0);
           await nano.InitializeStreamAsync(audioFormat, videoFormat);

       }


Cannot "override" the packet.Level when calling CaptureMessage

It seams like there is no way to currently override the packet.Level when we call CaptureMessage. The call to client.context.interfaces() is also private so we cannot use the raw client.Capture() method to achieve the same result.
Is there any way to do this as we need to set the level tag to the "log level" on our side?

Have the same problem, I want to set some information to warning level.

Having the same problem

We are looking to interface Sentry with alerting (OpsGenie and co) for some projects, and being able to set log level to WARNING at least is critical to making this useful.

Moved to https://github.com/getsentry/raven-go/issues/237


-mistake

This is an accidental duplicate of issue #180. Please refer to that issue for the correct information and discussion.


enum to json mapping

One use-case I run into a lot is mapping enums to serialize as non-integers such as strings. I know its not really modern C++ to use preprocessor macros, but I wrote one that declares a from_json()/to_json() specialization in one statement to make it easier and less redundant to specialize the mapping between a given set of enum values and a set of json values. Motivating example:
// enum type declaration
enum TaskState {
    TS_STOPPED,
    TS_RUNNING,
    TS_COMPLETED,
    TS_INVALID=-1,
};

JSON_SERIALIZE_ENUM( TaskState, {
    {TS_INVALID, nullptr},
    {TS_STOPPED, "stopped"},
    {TS_RUNNING, "running"},
    {TS_COMPLETED, "completed"},
});

// Usage:
// enum -> json string
nlohmann::json j = TS_STOPPED;
assert(j == "stopped");

// json string-> enum
nlohmann::json j3 = "running";
assert( j3.get<TaskState>() == TS_RUNNING);

// unmapped json -> enum (default value is first pair)
nlohmann::json jPi = 3.14;
assert( jPi.get<TaskState>() == TS_INVALID );

The JSON_SERIALIZE_ENUM() macro above is implemented as:
#define JSON_SERIALIZE_ENUM( ENUM_TYPE, ...)\
	inline void to_json( nlohmann::json& j, const ENUM_TYPE& e){\
		static const nlohmann::multi_bimap<ENUM_TYPE,nlohmann::json> m=__VA_ARGS__;\
		j = m.at_right(e);\
	} \
	inline void from_json( const nlohmann::json& j, ENUM_TYPE& e){\
		static const nlohmann::multi_bimap<ENUM_TYPE,nlohmann::json> m=__VA_ARGS__;\
		e = m.at_left(j);\
	}

This example is still just a sketch since it does not take into account that basic_json can be specialized for different types.
One benefit of the multi_bimap<> is that it allows multiple enum values to map to the same JSON value and multiple JSON values to map to the same enum. The first matching pair found in at_right()/at_left is returned.
I can provide you with implementation details for the multi_bimap<TL,TR> class but it is mostly just a simple wrapper around a vector<pair<TL,TR>> that is linear searched in at_right()/at_left(). When a key is not found in at_right() or at_left(), the first pair is used as default values.

I did some tinkering and came up with a new version of the macro that does not require a multi_bimap class:
#define NLOHMANN_JSON_SERIALIZE_ENUM( ENUM_TYPE, ...)\
    inline void to_json( nlohmann::json& j, const ENUM_TYPE& e) {\
        static const std::vector<std::pair<ENUM_TYPE,nlohmann::json>> m=__VA_ARGS__;\
        auto it = std::find_if(m.cbegin(),m.cend(),[e](const auto& ej_pair)->bool{return ej_pair.first==e;});\
        j = ((it!=m.cend())?it:m.cbegin())->second;\
    }\
    inline void from_json( const nlohmann::json& j, ENUM_TYPE& e) {\
        static const std::vector<std::pair<ENUM_TYPE,nlohmann::json>> m=__VA_ARGS__;\
        auto it = std::find_if(m.cbegin(),m.cend(),[j](const auto& ej_pair)->bool{return ej_pair.second==j;});\
        e = ((it!=m.cend())?it:m.cbegin())->first;\
    }

I like the proposal from @dgendreau. Unless anyone objects, I would add it for the 3.2.1 release.
@theodelrieu - What do you think?

It looks good to me as well. I just have two remarks:

Generic lambdas are C++14, so you must type the whole type yet another time.
Passing ENUM_TYPE instead of const ENUM_TYPE& in to_json would be better.

Other than that, it's all good!

Thanks for the quick feedback!

You might also want to have a second version of the macro that takes (ENUM_TYPE, JSON_TYPE, ...) to allow the user to map to something other than the default nlohmann::json type.

@dgendreau this can already be done in the macro, by templating on BasicJsonType

I hadnt thought of that. Yes, thats a cleaner approach.

Thanks for the feedback @theodelrieu.
Is this version closer to what you had in mind?
#define NLOHMANN_JSON_SERIALIZE_ENUM( ENUM_TYPE, ...)\
    template<typename BasicJsonType>\
    inline void to_json( BasicJsonType& j, ENUM_TYPE e) {\
        static const std::vector<std::pair<ENUM_TYPE,BasicJsonType>> m=__VA_ARGS__;\
        auto it = std::find_if(m.cbegin(),m.cend(),[e](const std::pair<ENUM_TYPE,BasicJsonType>& ej_pair)->bool{return ej_pair.first==e;});\
        j = ((it!=m.cend())?it:m.cbegin())->second;\
    }\
    template<typename BasicJsonType>\
    inline void from_json( const BasicJsonType& j, ENUM_TYPE& e) {\
        static const std::vector<std::pair<ENUM_TYPE,nlohmann::json>> m=__VA_ARGS__;\
        auto it = std::find_if(m.cbegin(),m.cend(),[j](const std::pair<ENUM_TYPE,BasicJsonType>& ej_pair)->bool{return ej_pair.second==j;});\
        e = ((it!=m.cend())?it:m.cbegin())->first;\
    }

No problem! That's it, but there's one nlohmann::json left.

Suggested user documentation for this feature:
Insert the following just before the "Binary formats (CBOR, MessagePack, and UBJSON)" section
Specializing enum conversion
By default, enum values are serialized to JSON as integers. In some cases this could result in undesired behavior. If an enum is modified or re-ordered after data has been serialized to JSON, the later de-serialized JSON data may be undefined or a different enum value than was originally intended.
It is possible to more precisely specify how a given enum is mapped to and from JSON as shown below:
// example enum type declaration
enum TaskState {
    TS_STOPPED,
    TS_RUNNING,
    TS_COMPLETED,
    TS_INVALID=-1,
};

// map TaskState values to JSON as strings
NLOHMANN_JSON_SERIALIZE_ENUM( TaskState, {
    {TS_INVALID, nullptr},
    {TS_STOPPED, "stopped"},
    {TS_RUNNING, "running"},
    {TS_COMPLETED, "completed"},
});

The NLOHMANN_JSON_SERIALIZE_ENUM() macro declares a set of to_json() / from_json() functions for type TaskState while avoiding repetition and boilerplate serilization code.
Usage:
// enum to JSON as string
nlohmann::json j = TS_STOPPED;
assert(j == "stopped");

// json string to enum
nlohmann::json j3 = "running";
assert( j3.get<TaskState>() == TS_RUNNING);

// undefined json value to enum (where the first map entry above is the default)
nlohmann::json jPi = 3.14;
assert( jPi.get<TaskState>() == TS_INVALID );

Just as in Arbitrary Type Conversions above,

NLOHMANN_JSON_SERIALIZE_ENUM() MUST be declared in your enum type's namespace (which can be the global namespace), or the library will not be able to locate it.
It MUST be available (e.g., proper headers must be included) everywhere you use the conversions.
When using get<ENUM_TYPE>(), undefined JSON values will default to the first pair specified in your map.
If an enum or JSON nvalue is specified more than once in your map, the first matching occurrence from the top of the map will be returned when converting to or from JSON.

Should we look into serializing third party enums with an adl_serializer<> specialization? I think that would require the to_json()/from_json() functions to also be declared static.

Should we look into serializing third party enums with an adl_serializer<> specialization

The library must not specialize adl_serializer, ever. Here is the current way conversions work:

Constructor will call JSONSerializer<T>::to_json
If JSONSerializer<T> (e.g. adl_serializer<T>) was specialized, if will take that specialization.
If nlohmann::to_json is called by JSONSerializer<T>::to_json, the library will try to find a valid overload via ADL.
If no viable overload is found via ADL, then it will look at overloads defined inside conversions/to_json.hpp.
If none is found, you lose.

About 4, it's the only place where we can put types that are in a different namespace, because each overload is visible by nlohmann::to_json.
Note: everything said here applies to from_json as well.

Re: adl_serializer,
Understood. I was looking at the new macro as the user defining a from_json/to_json, not the library defining it. Thats why I was making sure we didnt have a missing scenario where the user needs to specialize the serialization of and enum in a namespace they do not control. Thats probably overkill for now.
Re: static_assert,
I updated the macro above.

Could you add the static_assert in to_json as well?

I was looking at the new macro as the user defining a from_json/to_json, not the library defining it.

I misunderstood what you meant, it would be possible of course, but I'd rather leave specializations being explicit to write. For now at least.

Done

Looks good to me, time to open a PR! :)

ok. ill do that after work today.

oh, what file would you recommend adding the macro to?

Good question... Either in json.hpp or in a new file that will get included by json.hpp.

Hi Niels,
Sorry I was delayed. I didnt want to submit a PR without verifying it first.
I added the new header and manually patched it into the amalgamated json.hpp and it works in practice, but I was stuck trying to set up cmake / amalgamate and run the unit tests. I'm on a widows MSVC 2015 build environment. Is there an easier way to run cmake / amalgamate / unit tests for a Windows / VC2015 machine?

For amalgamation, you do not need CMake, but only Python and astyle.

@dgendreau Can you send me a patch so I can make a PR?

@dgendreau Could you open a PR or send me a patch?

@dgendreau @theodelrieu Do we agree that https://github.com/nlohmann/json/issues/1208#issuecomment-420305133 should be added to the library? If so, I could create a PR.

Hi. Sorry I was away. I'll post a PR this evening.

@dgendreau Any news on this? As I wrote above: I could also create a PR if we agree that https://github.com/nlohmann/json/issues/1208#issuecomment-420305133 should be the fix.

PR #1323 contains the macro definition, the documentation, and a few test cases. Thanks everybody for the good work! As I had some time, I opened the PR myself. It would be great if you could have a look whether anything else needs to be added.


Add DataContract and JsonProperty attribute serialisation

Having a model
[DataContract]
public class MyModel
{
    [DataMember(Name = "full_name")]
    public string Name { get; set; }
}

When sending a standard JsonPatch request
[
    { "op": "add", "path": "/full_name", "value": "John Doe" }
]

The serilizer does not map /full_name to the property Name of MyModel. However, if you use change tha path to /Name it will then map the property.
The JsonPatch needs to adhere to the JsonProperty and DataContract attributes and default to PropertyName if no attribute is present.
This will follow the conventions used else where in the MVC framework when building API's
Thanks

Thank you for filing this issue. It took a while for us to get to this issue. In order for us to investigate this issue, please provide a minimalistic repro project that illustrates the problem.

Hi. We're closing this issue as we have heard no response from you for some time now. If you have more details and are encountering this issue please add a new reply and re-open the issue.


Upgrade attributes field to more generic "secondary info" that adds templating support

Secondary info will continue to support attributes of the current entity.
But it should also support templating.  Two potential use cases:

Datetime conversion of attributes on current entity
Display something from another entity related to the main one the card is showing

For example, I have a slider-button-card controlling an automation that queries the next alarm sensor of my phone.  I would like to display the next alarm time on the same card that controls the automation.

I imagine the config might have to change to support this.
Current:
attribute: current_temperature

Potentially it will have to look like these:
secondary_info:
  type: attribute
  data: current_temperature

and
secondary_info:
  type: template
  data: |
    {{ template goes here }}

It actually looks like OP was working on this before reverting it: https://github.com/mattieha/slider-button-card/commit/c58a6ae5f410ea5f5c0c9c2622a0b465fe85924b
This might be a good starting point!


Could you teach me how to know the  test accuracy?

Thank you for reading my issue.
Could you teach me how to know the test accuracy?
I could know about validation error but I couldn't know how to test the new data which are not used in training phase.
I am trying to use DoReFa Net

Thanks. https://github.com/ppwwyyxx/tensorpack/blob/master/examples/load-alexnet.py#L60 has a function to load an existing model (through the session_init option) and run the model on new data.
In the example it's loading from a dict. You could use session_init=SaverRestore('train_log/xxx/model-xxx") if you're loading from a TF-format checkpoint.
DoReFa net examples also contain such functions at here.
Feel free to ask if it's not clear enough.

Thank you for your replying.
Your explanation is very clear so that I got confidence to implement it.
I have one more question.
I want to use the function of run_image() in DoReFa  net.
But, I couldn't understand how to specify the argument to run it.
I put the  the command like this.
python alexnet-dorefa.py --run
But it did't work well because the training was started.
Thanks a lot!

You can see an example in the docstring in alexnet-dorefa.py. Something like --load path/to/model --run a.jpg b.jpg c.jpg.
Also see alexnet-dorefa.py --help.

Finally I understand the method to use it.
Thank you for your kindness.


Updated exception messages

Pull Request Template
Description
Updating the exception messages to provide a consistent story.
ResponseMessage

ResponseMessage.Content will always be null for exception scenarios
ResponseMessage.ErrorMessage will contain StackTrace if it was converted from an older DCE

Response status code does not indicate success: PreconditionFailed; Substatus: 0; Reason: ({
  "Errors": [
    "One of the specified pre-condition is not met"
  ]
}); ActivityId = 28923a6b-097b-4b10-87af-4c3b6d039609; RequestCharge = 1.24;

CosmosException:

CosmosException.Message will NOT contain StackTrace

Response status code does not indicate success: PreconditionFailed; Substatus: 0; Reason: ({
  "Errors": [
    "One of the specified pre-condition is not met"
  ]
}); ActivityId = 6075135a-c00a-40ca-b7ea-5a64ffced45e; RequestCharge = 1.24;

CosmosException.ToString() includes stack trace, diagnostics, and all other relevant information
CosmosException.ResponseBody is the raw response from the service or DCE.Message

{
  "Errors": [
    "One of the specified pre-condition is not met"
  ]
}

Difference:
ResponseMessage.ErrorMessage may contain stack trace and inner exception ToString() logic. CosmosException.Message will only contain the formatted text show above.

Ideally have full context on all surfaces unless its an issue.


Support for HTTP/2

If I understand correctly, OFFAT does not currently work for HTTP/2? I tried to fuzz some API that uses HTTP/2, but OFFAT produces
RemoteDisconnected('Remote end closed connection without response')
Is support for this planned in the future?

Unfortunately the extensive use of requests package prevent implementation of HTTP/2 as urllib3 which requests uses doesn't have nor plans to add HTTP/2
An alternative could be to migrate to: https://pypi.org/project/pycurl/ which support HTTP/2 if libcurl has HTTP/2 compiled into it

Hello @dmdhrumilmistry, I have an idea for this. We could pass an argument like --http2 which  would enable HTTP/2 and then implement it using httpx.
If that sounds good, can you assign this issue to me?

Hello @dmdhrumilmistry, I have an idea for this. We could pass an argument like --http2 which would enable HTTP/2 and then implement it using httpx.
If that sounds good, can you assign this issue to me?

Hey,
Sounds good to me! but currently, I'm not planning to maintain python version anymore. I've been busy lately, but I'm porting complete codebase to golang. Currently, I'm using fasthttp which sadly doesn't support http2 (at the time of writing). If you're interested in contributing to the project, then you can create a module with interface which can support http1 (fast http), http2 (net/http) and http3 (quic-go) requests.
LMK if you'd like to pick this up. Also, Note its not necessary to implement all at once, you can implement it in phases.
Golang Codebase: https://github.com/owasp-offat/offat

Yes, I would surely like to take that up.

I'm creating new issue in golang codebase and assigning it to you.


Add google-auth-httplib2 as dependency

Description

Adding a new dependency.
Motivation and Context

As discussed here https://github.com/spotify/luigi/pull/2361#issuecomment-378661375
This is used by https://github.com/google/google-api-python-client/blob/v1.6.6/googleapiclient/discovery.py#L371
Another option is to fix luigi.contrib.bigquery somehow.
Have you tested this? If so, how?

Manually installing this package worked for me.

tox.ini is just adding it as a dependency for tests; didn't you mean to add it as a dependency for the real thing?
It's a bit unfortunate that contrib modules aren't separate packages with their own setup.pys; that would be the place to declare dependencies...

I did mean to put it as real thing. Sorry for the mistake. Another PR coming.

Now the problem is, I don't know where to put it. setup.py doesn't seem to be a good place. @ulzha as you mentioned, how do we handle contrib deps?

That looks like a big change in code structure. Not so sure we want to spend that much effort atm.


Webhook for pull review request (and others)

Gitea version (or commit ref): 1.14

Description
There is currently no webhook for PR review requests. The NotifyPullReviewRequest method exists, but it is not implemented by the webhook. While my use case in particular is about this NotifyPullReviewRequest, I notice there are other notifications that are not implemented in the webhooks:

(NotifyPullReviewRequest)
NotifyIssueChangeRef
NotifyPullRequestCodeComment
NotifyPullRequestPushCommits
NotifyRenameRepository
NotifyTransferRepository

commenting for NotifyPullReviewRequest support to be added.


all our code is failing for muon's import

waiting for fix on their side
https://github.com/scverse/muon/issues/135

@kevinrue @SarahOuologuem please open a PR fixing version of scanpy to 1.9 to keep going for now. @Zethson and the rest of the scverse team are on the issue, hopefully it will be resolved in a couple of weeks.


⚠ Bofrost.be has degraded performance

In 60172cf, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1749 ms

Resolved: Bofrost.be performance has improved in b387116 after 44 minutes.


Open Mobile Map Package Sample

Demonstrates opening a mobile map package.

@john0005 Can you please review?

Looks like Yellowstone needs to be added to the samples data. I refreshed it and didn't see it in there.

@john0005 my bad, the mmpk should be there now

Looks good!


Publish 0.2.10

When I try to pull in the latest version I get  0.2.9 which gives a uninitialized constant Capistrano::S3 (NameError) has the latest version been published and I'm missing it, or does the latest version just need a push?

Fixed.
I indeed never published v0.2.10, I think I lost my private signing key at that time. Made a new one.

*I published a new v0.2.11 to avoid confusion.


Added rds to system status lambda

Summary | Résumé
Add rds to system status lambda

If you look at the plan, it indicated that we are deleting the non-vpc policies :
I double checked with pat and that is okay. We are adding an ecr security group and that will cover all the cloudwatch policies that we are deleting.


disable post buttom after post

disable the post button after with post and delete the text below.
Put a ✔ instead of the post button for example

Issue résolue par le commit 8a2b09
Le bouton n'apparait plus et le succès du post est signalé par un 'check' vert apparaissant à la place de l'icone de chargement.

KO on 0.1.9

Issue fixed in commit 8a2b09 and the button is not reposting since but commit 841dbe sets the cursor as 'default' when hovering the button after a successful post to make it clear that it is not clickable.
Still looking for a way to prevent focus on click thought. If anyone has a solution he's welcome to comment it or implement it via a pull request


Fixed a word

It is on-premises, not on-premise.

@allanhirt : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@allanhirt Thanks for this fix.


Latest mod release (v1.4.0) causes crash on launch with Minecraft v1.20.6

crash log.txt

Sorry for really late reply to the issue, 1.20.6 support has been added in the latest release (v1.5.0) :)


Conductor Server Logging Questions

In the startup-script of the Docker deployment (https://github.com/Netflix/conductor/blob/master/docker/server/bin/startup.sh), the Conductor server gets started with this command:
nohup java -jar conductor-server-*-all.jar $config_file 1>&2 > /app/logs/server.log`
Is there a way to better "configure" the logging - i.e. to provide a logback.xml or log4j.properties to e.g. configure the log-level and the log message format?
Thanks for any help.

@blueelephants yes, it takes two arguments and second one (after the config file) is the location of log4j properties.
https://github.com/Netflix/conductor/blob/master/server/src/main/java/com/netflix/conductor/server/Main.java#L47

Many thanks for your help!


Add AutoMooncake type

Checklist

[x] Appropriate tests were added
[x] Any code changes were done in a way that does not break public API
[x] All documentation related to code changes were updated
[x] The new code follows the
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
[x] Any new documentation only uses public API

Additional context
AutoTapir needs to be deprecated in favour of AutoMooncake, because Tapir.jl has been renamed to Mooncake.jl.
I could do with some advice on the appropriate way to deprecate AutoTapir -- should I just add the constructor to the legacy.jl file, or is there something else that I should do?

Can we have a default setting so that people don't need to dig into the Mooncake.Config docs? Like AutoMooncake(; config=nothing)?

We could do that. I'd prefer to prevent people from writing AutoMooncake() -- they should at least have to write AutoMooncake(; config=nothing) -- in order to ensure that people are aware that they have some configuration options.

Sounds good, let's do that. As a user of ADTypes it's always a bit painful to go grab a specific type from a package to configure backends (like AutoZygote(; config=Zygote.ZygoteRuleConfig()))

Ready for review?


Don't run baseline package validation during NuGet publishing for major version changes (OSOE-857)

To allow breaking changes in major versions, something that the baseline package validator we use during NuGet publishing doesn't do (see https://github.com/dotnet/sdk/issues/40907), let's not run it in such cases.
So, if New-NuGetPackage notices a major version change (e.g. from 1.2.3 to 2.0.0) then disable baseline package validation (but only that, package validation should otherwise run).
If https://github.com/dotnet/sdk/issues/40907 is implemented before, then this won't be needed.
Jira issue

@sarahelsaig wasn't this an issue for you for https://github.com/Lombiq/Helpful-Libraries/releases/tag/v10.0.0?

No,  when I pushed a major tag it always worked.

That's what I remembered doing before, but still, I had to do https://github.com/Lombiq/UI-Testing-Toolbox/commit/803e87f553dc16885995616958bd4a08ea3d8644 to publish a new major version. It failed under https://github.com/Lombiq/UI-Testing-Toolbox/actions/runs/9100082776/job/25014098526 without it.

This seems to br working well now.


Remove ignore on *.DotSettings.user since it's covered in *.user and keep publi…

…sh settings since private info is in the pubxml.user
Reasons for making this change:
Everytime i add a publish profile to a new solution i always get tripped up because pubxml is ignored... this is a huge pain since i want the server name etc in there. Passwords are already stored hidden in the pubxml.user which is ignored.

Is this a problem just for you? Can you point to any public discussions on this issue?

No, this is a problem for anyone I've talked with, they general don't use the VS .gitignore for this issue and just re-use their own. I did not look at any public discussion but if you create a new repo with this gitignore, then create a publish profile to push to azure or w/e server you want, check your code in, then try and reference that publish profile on your build server it will fail (because publish profiles being checked in is ignored by default). I don't see how that's a good thing?

I guess the main reason this was ignored was because connection strings to databases fully get stored in the pubxml? Is that the reason?


should rename to Size or just delete this func

https://github.com/mattn/go-gtk/blob/2d9b918c84fca8f12b4ed572cd8e8d1f4cb046f5/gtk/gtk.go#L9731-L9735

fixed in #366


1/18 Publish for metadata update

…ice = dotnet-ml-api (#167)
Summary
Describe your changes here.
Fixes dotnet/docs#Issue_Number (if available)

@BillWagner
Could you please help to merge this PR? It is to publish the metadata update in the PR https://github.com/dotnet/ml-api-docs/pull/167


Search directly for a file hash

I want to be able to put a hash number into the search and find the file that way.
I tried it with the current 0.2.0-beta and it doesn't work.
Also currently you cannot just copy a hash from the files you upload.
Simple as that.

Hi @no112358, thanks for your interest and welcome to github!
Great idea!
We've implemented searching by file hash you can expect it in the next release 0.2.1-beta.
With regards to copying hash from your own local files view, we are considering multiple ways to expose more information of files at subsequent releases.

I kinda already knew you already done it, seems like an obvious thing, just wrote it just in case.
Hash copying is not really neccesary if you're bringing Magnet links in 0.2.1-beta?

We hadn't done it yet, but fulfilled your request 😉.
Can't say when exactly magnet links will be out, we're focussing mostly on bug fixing for 0.2.1-beta.

great job can't wait to see the results 👍


Device listing page invokes the backend Device API two times when a searching through filters

Device listing page invokes device API two times for every search term provided.

This issue will be fixed with PR : https://github.com/wso2/carbon-device-mgt/pull/793/files


Calico APIServer does not find certs secret

Expected Behavior
When installing Calico through the tigera-operator on k3s and Fedora CoreOS the API Server is correctly started.
Current Behavior
Calico APIServer cannot start because the pods cannot find the secret calico-apiserver-certs:
10m         Normal    Scheduled           pod/calico-apiserver-6b895bd67d-86xss    Successfully assigned calico-apiserver/calico-apiserver-6b895bd67d-86xss to node-00
10m         Warning   FailedMount         pod/calico-apiserver-6b895bd67d-86xss    MountVolume.SetUp failed for volume "calico-apiserver-certs" : failed to sync secret cache: timed out waiting for the condition
9m31s       Warning   FailedMount         pod/calico-apiserver-6b895bd67d-86xss    MountVolume.SetUp failed for volume "calico-apiserver-certs" : secret "calico-apiserver-certs" not found
8m33s       Warning   FailedMount         pod/calico-apiserver-6b895bd67d-86xss    Unable to attach or mount volumes: unmounted volumes=[calico-apiserver-certs], unattached volumes=[], failed to process volumes=[]: timed out waiting for the condition

Possible Solution
-
Steps to Reproduce (for bugs)
Create the /var/lib/kubelet/volumeplugins/nodeagent~uds directory to make calico work on Fedora CoreOS (see GitHib calico issue)
Install tigera-operator through Helm chart with the following values:
installation:
  enabled: true
  flexVolumePath: /var/lib/kubelet/volumeplugins
  cni:
    type: Calico
  calicoNetwork:
    mtu: 1400
    bgp: Disabled
    ipPools:
      - blockSize: 26
        cidr: "<IP_ADDRESS>/16"
        encapsulation: VXLANCrossSubnet
        disableBGPExport: true
        natOutgoing: Enabled
        nodeSelector: all()
apiServer:
  enabled: true

Context
The installation fails through Terraform.
Your Environment

Operating System and version: Fedora CoreOS 39 with k3s-selinux installed
Kubernetes distribution: k3s (v1.27.9+k3s1)

k3s additional args:
      "--selinux",
      "--disable-cloud-controller --disable=servicelb --kubelet-arg='cloud-provider=external'",
      # disable default CNI
      "--flannel-backend=none --disable-network-policy",
      # disable default Traefik Ingress controller
      "--disable=traefik",
      # CIDR to use for pod IPs
      "--cluster-cidr='<IP_ADDRESS>/16'",
      # CIDR to use for service IPs
      "--service-cidr='<IP_ADDRESS>/16'",
      # Cluster domain
      "--cluster-domain=custom.domain.local",
      # encrypt secrets at rest
      "--secrets-encryption"

This sounds like an issue with SELinux or the volume mounting on the host.
If you still believe this is a tigera-operator problem please provide operator logs and provide some guidance on what you believe is being configured incorrectly.

Yes it should be SELinux. I will reopen in case the problem persists and would relate to the operator.


[incubator/kafka] Update templates/service-brokers-external.yaml to use correct targetPort for service type LoadBalancer or NodePort

What this PR does / why we need it:
This fixes a bug that broke the external access feature for kafka
brokers. Now the external broker services route to the correct targetPort.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #11867
fixes #9062

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md

Test results given below for external service type NodePort and LoadBalancer.
Test results with external type NodePort
makbook:kafka mayankkapoor$ git diff #changes to values.yaml
diff --git a/incubator/kafka/values.yaml b/incubator/kafka/values.yaml
index a6844efe..b29053d6 100644
--- a/incubator/kafka/values.yaml
+++ b/incubator/kafka/values.yaml
@@ -135,7 +135,7 @@ external:
     useExternal: true
   # create an A record for each statefulset pod
   distinct: false
-  enabled: false
+  enabled: true
   servicePort: 19092
   firstListenerPort: 31090
   domain: cluster.local
@@ -166,10 +166,10 @@ configurationOverrides:
   ## - https://cwiki.apache.org/confluence/display/KAFKA/KIP-103%3A+Separation+of+Internal+and+External+traffic
   ##
   ## Setting "advertised.listeners" here appends to "PLAINTEXT://${POD_IP}:9092,"
-  # "advertised.listeners": |-
-  #   EXTERNAL://kafka.cluster.local:$((31090 + ${KAFKA_BROKER_ID}))
-  # "listener.security.protocol.map": |-
-  #   PLAINTEXT:PLAINTEXT,EXTERNAL:PLAINTEXT
+  "advertised.listeners": |-
+    EXTERNAL://kafka.cluster.local:$((31090 + ${KAFKA_BROKER_ID}))
+  "listener.security.protocol.map": |-
+    PLAINTEXT:PLAINTEXT,EXTERNAL:PLAINTEXT

Result:
makbook:~ mayankkapoor$ kubectl -n kafka get svc
NAME                       TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)                      AGE
kafka                      ClusterIP   <IP_ADDRESS>   <none>        9092/TCP                     2m43s
kafka-0-external           NodePort    <IP_ADDRESS>   <none>        19092:31090/TCP              2m43s
kafka-1-external           NodePort    <IP_ADDRESS>     <none>        19092:31091/TCP              2m43s
kafka-2-external           NodePort    <IP_ADDRESS>    <none>        19092:31092/TCP              2m43s
kafka-headless             ClusterIP   None             <none>        9092/TCP                     2m43s
kafka-zookeeper            ClusterIP   <IP_ADDRESS>     <none>        2181/TCP                     2m43s
kafka-zookeeper-headless   ClusterIP   None             <none>        2181/TCP,3888/TCP,2888/TCP   2m43s

makbook:~ mayankkapoor$ kubectl -n kafka describe svc kafka-0-external
Name:                     kafka-0-external
Namespace:                kafka
Labels:                   app=kafka
                          chart=kafka-0.14.1
                          heritage=Tiller
                          pod=kafka-0
                          release=kafka
Annotations:              external-dns.alpha.kubernetes.io/hostname: kafka.cluster.local
Selector:                 app=kafka,release=kafka,statefulset.kubernetes.io/pod-name=kafka-0
Type:                     NodePort
IP:                       <IP_ADDRESS>
Port:                     external-broker  19092/TCP
TargetPort:               9092/TCP
NodePort:                 external-broker  31090/TCP
Endpoints:                <IP_ADDRESS>:9092
Session Affinity:         None
External Traffic Policy:  Cluster
Events:                   <none>

makbook:~ mayankkapoor$ kafkacat -L -b kafka.cluster.local:31090
Metadata for all topics (from broker -1: kafka.cluster.local:31090/bootstrap):
 3 brokers:
  broker 2 at kafka-2.kafka-headless.kafka:9092
  broker 1 at kafka-1.kafka-headless.kafka:9092
  broker 0 at kafka-0.kafka-headless.kafka:9092
 0 topics:

Test results with external type LoadBalancer
makbook:kafka mayankkapoor$ git diff #changes to values.yaml
diff --git a/incubator/kafka/values.yaml b/incubator/kafka/values.yaml
index a6844efe..812efc4d 100644
--- a/incubator/kafka/values.yaml
+++ b/incubator/kafka/values.yaml
@@ -127,7 +127,7 @@ headless:
 ## External access.
 ##
 external:
-  type: NodePort
+  type: LoadBalancer
   # annotations:
   #  service.beta.kubernetes.io/openstack-internal-load-balancer: "true"
   dns:
@@ -135,7 +135,7 @@ external:
     useExternal: true
   # create an A record for each statefulset pod
   distinct: false
-  enabled: false
+  enabled: true
   servicePort: 19092
   firstListenerPort: 31090
   domain: cluster.local
@@ -166,10 +166,10 @@ configurationOverrides:
   ## - https://cwiki.apache.org/confluence/display/KAFKA/KIP-103%3A+Separation+of+Internal+and+External+traffic
   ##
   ## Setting "advertised.listeners" here appends to "PLAINTEXT://${POD_IP}:9092,"
-  # "advertised.listeners": |-
-  #   EXTERNAL://kafka.cluster.local:$((31090 + ${KAFKA_BROKER_ID}))
-  # "listener.security.protocol.map": |-
-  #   PLAINTEXT:PLAINTEXT,EXTERNAL:PLAINTEXT
+  "advertised.listeners": |-
+    EXTERNAL://kafka.cluster.local:$((31090 + ${KAFKA_BROKER_ID}))
+  "listener.security.protocol.map": |-
+    PLAINTEXT:PLAINTEXT,EXTERNAL:PLAINTEXT

Test results:
makbook:~ mayankkapoor$ kubectl -n kafka get svc
NAME                       TYPE           CLUSTER-IP      EXTERNAL-IP   PORT(S)                      AGE
kafka                      ClusterIP      <IP_ADDRESS>   <none>        9092/TCP                     2m53s
kafka-0-external           LoadBalancer   <IP_ADDRESS>    <pending>     31090:30250/TCP              2m53s
kafka-1-external           LoadBalancer   <IP_ADDRESS>    <pending>     31091:32569/TCP              2m53s
kafka-2-external           LoadBalancer   <IP_ADDRESS>    <pending>     31092:30317/TCP              2m53s
kafka-headless             ClusterIP      None            <none>        9092/TCP                     2m53s
kafka-zookeeper            ClusterIP      <IP_ADDRESS>   <none>        2181/TCP                     2m53s
kafka-zookeeper-headless   ClusterIP      None            <none>        2181/TCP,3888/TCP,2888/TCP   2m53s

makbook:~ mayankkapoor$ kubectl -n kafka describe svc kafka-0-external
Name:                     kafka-0-external
Namespace:                kafka
Labels:                   app=kafka
                          chart=kafka-0.14.1
                          heritage=Tiller
                          pod=kafka-0
                          release=kafka
Annotations:              external-dns.alpha.kubernetes.io/hostname: kafka.cluster.local
Selector:                 app=kafka,release=kafka,statefulset.kubernetes.io/pod-name=kafka-0
Type:                     LoadBalancer
IP:                       <IP_ADDRESS>
Port:                     external-broker  31090/TCP
TargetPort:               9092/TCP
NodePort:                 external-broker  30250/TCP
Endpoints:                <IP_ADDRESS>:9092
Session Affinity:         None
External Traffic Policy:  Cluster
Events:                   <none>

makbook:~ mayankkapoor$ kafkacat -L -b kafka.cluster.local:30250
Metadata for all topics (from broker -1: kafka.cluster.local:30250/bootstrap):
 3 brokers:
  broker 2 at kafka-2.kafka-headless.kafka:9092
  broker 1 at kafka-1.kafka-headless.kafka:9092
  broker 0 at kafka-0.kafka-headless.kafka:9092
 0 topics:

/assign @benjigoldberg

thanks for the PR @mayankkapoor
/ok-to-test

/lgtm

@mayankkapoor I think I screwed up with my initial assessment and now the new settings cause some issues.
I was running into issues where I was updating the Helm values files, running helm upgrade --install kafka incubator/kafka -f values.yml and wondering why the pod wasn't listening on port 3109X.
Turns out, running upgrade doesn't recreate the pods, and thus the service wasn't started with the new listener.
I think the changes in this PR actually break functionality, especially for external listeners.

:( Here goes my weekend. @bonovoxly Can you please post some test cases for me to run through as I work on a fix? The commands you're using, and the values.yml file would be helpful as well. Need to test the same way you're testing.

Yeah let me gather data, to make sure I'm not making a mistake (again)...

@mayankkapoor trying to capture what I'm running into here: https://github.com/helm/charts/issues/12853

@bonovoxly I'm first trying to fix external access via NodePort. My current research is documented here: #12876.


Lines disappear from graph when add new metric

Alex, when I begin to add new metric, and first select host group all lines disappear from graph, I think it is not right, grafana must not query if itemid is not defined.

Thanks!

See 330d90053fe8f07525d85366a319628b5bab599e


Restore microbenchmark runs for trace-agent

What does this PR do?
Restore microbenchmark runs for trace-agent in Benchmarking Platform.
Motivation
We can now do more performance testing. More performance testing - more confidence that quality of solutions is adequate.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


catalog: Refactor buildOutboundPolicies()

This PR changes

from if !mc.isTrafficSplitApexService(destService) {
to if mc.isTrafficSplitApexService(destService) { + continue

** no functional code changes**
This PR simply removes a level of indentation!

Codecov Report

Merging #3794 (6c9cf7f) into main (7ecbf42) will decrease coverage by 0.01%.
The diff coverage is 74.07%.

:exclamation: Current head 6c9cf7f differs from pull request most recent head d7fc0cf. Consider uploading reports for the commit d7fc0cf to get more accurate results

@@            Coverage Diff             @@
##             main    #3794      +/-   ##
==========================================
- Coverage   68.42%   68.40%   -0.02%
==========================================
  Files         188      188
  Lines       10748    10749       +1
==========================================
- Hits         7354     7353       -1
- Misses       3345     3347       +2
  Partials       49       49

Flag
Coverage Δ

unittests
68.40% <74.07%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/catalog/outbound_traffic_policies.go
85.23% <74.07%> (+0.07%)
:arrow_up:

pkg/k8s/announcement_handlers.go
72.97% <0.00%> (-5.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ecbf42...d7fc0cf. Read the comment docs.


Add image flag to support GL_NEAREST rendering

I wrote the solution for this proposal issue #223 to add Nearest interpolation or linear in creation image as imageFlag.
Use NVG_IMAGE_NEAREST to enable Nearest interpolation.

@memononen it's possible to add this new feature to your master branch? or it will be discarded? I have a project that use and i want to mantain you main branch.

Merged!

Oh! thanks to merge and consider it as a new feature!


Adding tests for callerid in client -> vtgate connections.

Fixing all the places that broke, in bson and grpc.
@aaijazi @guokeno0 @enisoc @sougou last change before snap for me, I think.

LGTM


[FEATURE REQUEST] PXE add gpg key for the local repository

In the pxe tutorial, I noticed an unresolved problem with adding local repositories when installing Debian
https://github.com/bluebanquise/bluebanquise/blob/master/tutorials/docs/sysadmin_servers_farm_deployment.md#debian-11-and-12
The debian installer uses apt-setup to generate apt configs.
https://github.com/kaisenlinux/apt-setup/tree/master/generators
In the repository you can see that the priority is set in the file name
The script runs first 01setup, then 40cdrom, etc.
To make changes to the apt settings, you can place a script with the required priority in the /usr/lib/apt-setup/generators/
For example, add a gpg key from the local repository:
d-i partman/early_command string apt-install gnupg ; \
wget -O /usr/share/keyrings/deb-public.gpg https://local-mirror.com/gpg/deb-public.gpg ; \
echo -e "cp /usr/share/keyrings/deb-public.gpg /target/tmp/deb-public.gpg\nchroot /target /bin/bash /bin/apt-key add /tmp/deb-public.gpg" > /usr/lib/apt-setup/generators/001add-gpg ; \
chmod +x /usr/lib/apt-setup/generators/001add-gpg ; \

I tested removing the gpg check.
Changes required to /usr/lib/apt-setup/generators/50mirror
This script may change in Debian releases, so it is not recommended to edit it.
It is more correct to download the DVD iso, unpack it, pick up the dists and pool on the web pxe
Create the private part of the gpg key:
gpg --full-generate-key
answer questions,passphrase leave without value
Exporting the public part of the gpg key:
gpg --list-keys
pub   rsa4096 2024-10-21 [SC]
      61908676B6BFC04B50E0EE40FHKLB8F8EDA99765

gpg --output pxe/debian/deb-public.gpg --export 61908676B6BFC04B50E0EE40FHKLB8F8EDA99765
Let's sign the Release with the gpg key:
gpg -abs -o pxe/debian/12/iso_content/dists/bookworm/Release.gpg pxe/debian/12/iso_content/dists/bookworm/Release
Edit pressed by adding:
d-i partman/early_command string apt-install gnupg ; \
wget -O /usr/share/keyrings/deb-public.gpg http://${next-server}/pxe/debian/deb-public.gpg ; \
echo -e "cp /usr/share/keyrings/deb-public.gpg /target/tmp/deb-public.gpg\nchroot /target /bin/bash /bin/apt-key add /tmp/deb-public.gpg" > /usr/lib/apt-setup/generators/001add-gpg ; \
chmod +x /usr/lib/apt-setup/generators/001add-gpg

One more thing,if you use external repositories in the pressed configuration, after some time, the OS installation will stop working. Because external Debian repositories store the latest two versions of the kernel, for example for debian 11 this is
https://ftp.debian.org/debian/pool/main/l/linux-signed-amd64/linux-image-5.10.0-30-amd64_5.10.218-1_amd64.deb
https://ftp.debian.org/debian/pool/main/l/linux-signed-amd64/linux-image-5.10.0-32-amd64_5.10.223-1_amd64.deb

linux-image-5.10.0-28 and older kernels have been removed from the repository.
The netboot installer is updated with the release of a new kernel and will always try to install this particular kernel when pxe boots. If the kernel is not available in the repository, the installation will fail.
For example,
netboot for debian 12.5 kernel 6.1.0-18 will stop working
https://www.debian.org/News/2024/20240210

Dear @alexey-orekhov
My apologies for the late answer. Its school holidays here, and I have to be with kids :slightly_smiling_face:
Thank you very much !
This is very interesting. I need to try again with these new data.
I remember I had another issue, with SATA drivers not being loaded from the ISO initrd when using local repository, so I used the netboot. Then using netboot I couldn't grab repos from the ISO due to the signed repo issue.
Solution is to use the netboot compatible with the release ISO (if it still exist), and combine both using your signing method.
I will give it a try as soon as possible :blush:


ValidationStep title changes based on VBA state

@Expensify/pullerbear
cc @kevinksullivan
Details
A bank account has two state when it hits the ValidationStep: PENDING or VERIFYING. Currently the step title will only show "Test Transactions" for all situations. We should now show "Connect Bank Account" for VERIFYING, and "Test Transaction" for PENDING
Fixed Issues

$https://github.com/Expensify/App/issues/7322
Tests / QA Steps

Follow https://stackoverflow.com/c/expensify/questions/342 to add a PENDING bank account

When you get the PENDING state, verify that the title says "Test Transactions"

Add another VBA that needs to be verified and is in the VERIFYING state

When you get to the validationStep, verify that the title says "Connect Bank Account"

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@nkuoch looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @nkuoch in version: 1.1.31-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@ctkochan22 What platforms do you need this tested on? all or just Web

Just web is fine!

🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Removing Emergency label. It's old


IPv4 Support

Brickner[CodePlex] Add support for IPv4 datagrams (over Ethernet).
Should looks like this:
Packet packet;
packet.Ethernet.IpV4...

Brickner[CodePlex] Details need update

Brickner[CodePlex] Included in Version 0.2.0
** Closed by Brickner 9/12/2009 3:00 AM

Associated with changeset 25467.


Better type inference of tagged union predicate functions

TypeScript Version:  2.4.0 / nightly (2.5.0-dev.201xxxxx)
Code
type X = {t: "x"}
type Y = {t: "y"}
type Z = X | Y

let a: Array<Z>

function predicate(x: Z) {
  return x.t === "x"
}

const result =  a.find(predicate)

Expected behavior:
I want result to have a type of X. Which means I want the predicate function to have a return type of x is X.
Actual behavior:
The result of the predicate is of type Z and result is of type Z

Please see https://github.com/Microsoft/TypeScript/issues/5101#issuecomment-145693151

Hmm. so I need to overload the .find function? Or should I be doing something like this?
function predicate<T extends Z>(x: Z): x is T {
  return x.t === "x"
}

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


[Bitwarden] Add search keywords for card and login (fixes #945)

Description
Improved search by adding card brand, last 4/5 digits, username and hostnames to the ListItem keywords.
I haven't updated a CHANGELOG.md since one does not yet exist.
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed in the metadata folder

Hi @daniel-stoneuk 👋
Thanks for taking your time making this extension even better 🔥
We added support for categories, screenshots and the changelog you mentioned – do you have time for adding this too, or should I help out? 💪

I'll add the changelog update now! Cheers.

Should we add the categories, screenshots and changelog in a separate PR @pernielsentikaer?

Would be fine to add them all in this PR if possible @daniel-stoneuk 😄

Thanks a lot for the screenshots @daniel-stoneuk !


Is it description or summary in page information ?

There are two definition as page's description or page's summary.
Somewhere in the templates, the summary has been used, such as here in templates/partials/head.html.
And another place in templates/partials/page_list.html both of them has been handled.
And in the sample contents, the description has been used.
So I think it's better to use one exact definition to avoid this duality (or we should handle both of them everywhere).

Yes, you are right, the page's description and page's summary is different. And the description <meta> tag should use description  instead of summary.
I fixed it in https://github.com/st1020/kita/commit/2c1452673dae803d85b5c12ce4d888cc5a996ea6.


Enabled docker tests, set up travis to run redis

Codecov Report

Merging #107 into master will increase coverage by 14.24%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #107       +/-   ##
===========================================
+ Coverage   22.99%   37.23%   +14.24%
===========================================
  Files          33       33
  Lines         948      948
  Branches       17       10        -7
===========================================
+ Hits          218      353      +135
+ Misses        730      595      -135

Impacted Files
Coverage Δ

core/src/main/scala/laserdisc/protocol/RESP.scala
77.07% <0%> (+2.54%)
:arrow_up:

core/src/main/scala/laserdisc/protocol/Show.scala
87.09% <0%> (+3.22%)
:arrow_up:

core/src/main/scala/laserdisc/package.scala
56.52% <0%> (+4.34%)
:arrow_up:

...re/src/main/scala/laserdisc/protocol/StringP.scala
5.08% <0%> (+5.08%)
:arrow_up:

core/src/main/scala/laserdisc/protocol/Read.scala
49.46% <0%> (+13.97%)
:arrow_up:

core/src/main/scala/laserdisc/protocol/ListP.scala
25% <0%> (+25%)
:arrow_up:

...s2/src/main/scala/laserdisc/fs2/RedisAddress.scala
40% <0%> (+40%)
:arrow_up:

...e/src/main/scala/laserdisc/protocol/Protocol.scala
55.55% <0%> (+55.55%)
:arrow_up:

fs2/src/main/scala/laserdisc/fs2/MkResource.scala
63.63% <0%> (+63.63%)
:arrow_up:

fs2/src/main/scala/laserdisc/fs2/RedisClient.scala
68.57% <0%> (+68.57%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e21a1...9c20540. Read the comment docs.


Just a test...

Testing it for myself...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0193ed76-3eec-18ac-512f-45f8118dde34
Version Independent ID: 8e693833-3e45-2bb8-ddc2-d0c54936c3c1
Content: A New Feedback System Is Coming to docs.microsoft.com
Content Source: teamblog/a-new-feedback-system-is-coming-to-docs.md
Service: unspecified
GitHub Login: @EisenbergEffect
Microsoft Alias: EisenbergEffect

Closed ^^


Improve neuropixels calibration file error messages

Remove dangling ")" from NP2.0 missing calibration file message
Add SN information to NP1.0 exception messages
Fixes #138

I think merge conflict is fine, we just need to resolve. The conflict will be in the XML tag only, right?

@jonnew There will be merge conflicts outside of the XML tags, I modified the methods so that all parsing for a single calibration file was done inside of a single method, thus allowing me to reuse the same functionality in the GUI. However, we have since decided to remove this file parsing in the GUI until we can check against a schema. I would like to keep those parsing methods intact, as it will make it easier to integrate into the GUI later on, but that conflicts with these changes. It shouldn't be a huge conflict, so I guess it's not a big problem, but I know merge conflicts can be annoying.

@bparks13 I guess I would like to review the changes to the parsing code before merging. Your changes are in the commit history so they can be recalled if needed, espeically if you create and issue with a link the the commit.


[WIP] add support for reading Orc decimal column

I have tested the reading of short decimal  type column by query_benchmark

@JkSelf @zhejiangxiaomai

@zuochunwei  can you to add a unit test in Gluten to test this function?


Accordion Error Solved

Accordion Error and Builder Error solved.Different language problem..

@ahmetkotan, how is the error triggered?

This seems to be abandoned, please reopen if necessary.


Create a bundle for the install script to support other domains

For the CS Engine we need to have an install script like OSS does, but
the locations are all different, as is the GPG key used. This is
accomplished here by slightly altering the script itself and adding a
simple 'sed' based bundle for make.sh.
/cc @jfrazelle @bmangold

ping @tianon as well :heart:

So does this mean release.sh's handling of install.sh could potentially be simplified to take advantage of this new build bundle?  Without that, this seems like something's missing. :smile:

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "cs-105-download-script" git@github.com:mikedougherty/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

I added a commit to use this in release.sh. I tested the commands on their own but don't have a good setup at the moment to do an end-to-end test. It's pretty straightforward so I don't think there will be any issues, but I can spend some time testing tomorrow if necessary.

LGTM

@jfrazelle do we want these squashed?

its only two i think its fine unless mike finds time but i know hes busy :)

busy be damned! rebase done. thanks folks :)

Nice, LGTM :+1:

I see two LGTM's, guess that means merge?


fix(chat): fix colors (Issue #2113)

Description:
The strokes of the upper and lower blocks are different
Issues:

Issue #2113

UI changes

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review