Model Predictions has Issues with merging sub-words

The model prediction seems to have a bug and does not properly deal with the sub-words in the output.
For example this is the output obtained:
[[' representation', ' documents', ' mask', 'ing strategies', ' transformer language models', ' discrim', 'in', ' gener', 'ative', ' discrim', 'in', 'ative', ' Key', 'phrase Boundary Infilling with Replacement', 'K', 'BI', ' key', 'phrase extraction', ' gener', 'ative', ' BART', ' Key', 'B', 'ART', ' Cat', 'Se', 'q', ' key', ' generation', ' named entity recognition', ' answering', ' relation extraction', ' abstract', 'ive summarization']]

After executing the following code:
tagger = KeyphraseTagger.load(
    model_name_or_path="../../outputs"
    )

input_text = "In this work, we explore how to learn task-specific language models aimed towards learning rich " \
             "representation of keyphrases from text documents. We experiment with different masking strategies for " \
             "pre-training transformer language models (LMs) in discriminative as well as generative settings. In the " \
             "discriminative setting, we introduce a new pre-training objective - Keyphrase Boundary Infilling with " \
             "Replacement (KBIR), showing large gains in performance (upto 9.26 points in F1) over SOTA, when LM " \
             "pre-trained using KBIR is fine-tuned for the task of keyphrase extraction. In the generative setting, we " \
             "introduce a new pre-training setup for BART - KeyBART, that reproduces the keyphrases related to the " \
             "input text in the CatSeq format, instead of the denoised original input. This also led to gains in " \
             "performance (upto 4.33 points in F1@M) over SOTA for keyphrase generation. Additionally, we also " \
             "fine-tune the pre-trained language models on named entity recognition (NER), question answering (QA), " \
             "relation extraction (RE), abstractive summarization and achieve comparable performance with that of the " \
             "SOTA, showing that learning rich representation of keyphrases is indeed beneficial for many other " \
             "fundamental NLP tasks."

keyphrases = tagger.predict(input_text)
print(keyphrases)

As can be seen in the output keyphrases 'mask' and 'ing strategies' are treated as separate keyphrases. This seems like a bug while putting together the sub-words during formatting the prediction output.

@ad6398 The model files used for prediction can be obtained over here - https://huggingface.co/dmahata/dlkp_test

Hey @debanjanbhucs , I printed each token and its tag. The issue is not with the decoding algorithm but with the model. It is not trained too well to identify masking strategies as a single keyphrase. The file attached here has tokens and their tag predicted by the model, we can clearly see that mask has B tag, ing has B and strategies has I tag. The same goes for other KPs
token_tag.txt


new module: annual-report

Ostensibly what we previously had thought of as stuff that would fall under the .gov-speak class.

Moved to: https://community.service.gov.au/t/template-annual-report


[Tech] Spike - Include SonarQube.com and Travis for JSLint coverage

Migrated from https://github.com/gov-ithub/auth-sso/issues/45
Originally created by @alexchiraples on Tue, 15 Nov 2016 14:02:38 GMT

https://docs.travis-ci.com/user/sonarqube/
http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner

sonarqube not working with Linux dist & .net core projects.
integration with:

#36 - coverity
#37 - better code hub


fix: borked 0x pairs

Description
Fixes (some) borked 0x pairs. For some reason, using the price endpoint with no validation to get a quote, then using the quote endpoint with validation is causing the latter (i.e the pre-broadcast quote) to respond with 400.
Fixed by consistently using the /quote endpoint, and consistently skipping validation - as our flow makes it so that by the time of <TradeConfirm />, we are already in a state where allowance is granted.
Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes https://github.com/shapeshift/web/issues/5598
Risk

0x quotes could be broken, test you're still able to get 0x quotes against develop

Testing

0x quotes are happy
XRP20 -> ETH using ZRX is happy at pre-broadcast quote time (ping myself or @MBMaria for the address to use in Frame)

Engineering

☝🏽

Operations

☝🏽

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5678   👈

This stack of pull requests is managed by Graphite.

Closing as broadcasting this would revert anyway


enable assertions for test

Updating the build to enable assertions in build.gradle.kts by adding the enableAssertions flags like:
  tasks.configureEach<Test> {
    ...
    enableAssertions = true
  }

results in test failing with assertion failures.
It would be good to fix these errors so that assertions can be enable permanently for test, as they are quite helpful when working  with Calcite.

This errors may just have been due to actual issues in https://github.com/substrait-io/substrait-java/pull/180

These are actually enable already. Please ignore.


Adding to .gitignore public/data/all_minified.json and public/data/all.json

Hi!
I have been trying to merge my clone with this repository, and I always got problems merging these files.
public/data/all_minified.json
public/data/all.json
In fact, all files that are being modified during the installation process. Won't be better to add all those files or folders to .gitignore?
Esteban

Hi! Actually that's what I thought at first. But it seems that some people have been facing various issues during the installation process. In case they are not able to finish the whole process, they can still build the site using the included data files.
Regarding the merge issue, I've been using -X theirs or -X ours to automatically resolve the conflicts.


Add information about ZUS vacation tax relief

https://www.zus.pl/-/wakacje-składkowe-zwolnienie-z-opłacania-składek-zus

I am going to take this one

PR merged
I assume issue either can stay open until the procedure is verified by someone, or can be closed and fixes to text will be introduced separately if needed.

Closed by https://github.com/sobolevbel/jdg/pull/190


Create 2ALpxn4fNxvqaXlL37Pu3V

Hey @TwoMilesBlue, thanks for submitting all of these playlists! Unfortunately, it's a bit cumbersome for me to merge them individually. Would you be able to combine them into a single pull request, as described here? https://github.com/mackorone/spotify-playlist-archive/pull/265
If you're not comfortable with the command line, you can just create a bunch of empty files in a folder on your computer and upload them via this link: https://github.com/mackorone/spotify-playlist-archive/upload/main/playlists/registry

Quick update: I decided to just add these playlists myself to clear the queue: https://github.com/mackorone/spotify-playlist-archive/commit/fe432f9fa1b79729b9e21ec04c6094d18c421de7. Thanks again for contributing!
Separately, @maciejpedzich, I just noticed that the playlist validator bot prints out the playlist name twice in a row, rather than the playlist name and the playlist owner. Presumably that's an easy fix?

Quick update: I decided to just add these playlists myself to clear the queue: fe432f9. Thanks again for contributing!
Separately, @maciejpedzich, I just noticed that the playlist validator bot prints out the playlist name twice in a row, rather than the playlist name and the playlist owner. Presumably that's an easy fix?

Yeah, I think the bot accidentally appends the playlist's title back to the description string found in the Spotify playlist's page metadata. I might be able to push a fix later today


comment mismatch (copy/paste error)

comment mismatch (copy/paste error)
Originally posted by @ahsonkhan in https://github.com/Azure/azure-sdk-for-c/pull/582

duplicated from #651


Improve libcalico logging levels

Most of the logging in libcalico is V2 level glog.  Need to revisit the logging levels to ensure logging is not quite so verbose.
Perhaps consider a different logging package.
If we stick with glog, then perhaps follow k8s logging level guide:
https://github.com/kubernetes/kubernetes/blob/master/docs/devel/logging.md

I think we've moved away from glog in favor of logrus, so this should include making sure we've standardized on that.

We already sue logrus now - but the log levels do need sorting out.
Not particularly important for the release of calicoctl since logging is disabled by default.  Where required by Felix, the logging levels have already been sorted out.  This is therefore low priority.


:bookmark: release v0.4.7

Description

Import genotypes of other WPs coming from Uruguay
Deal with affymetrix report with less SNPs than declared
Add an option to skip coordinate check when importing affymetrix report
Import from affymetrix a limited number of samples
Skip sample creation when there's no alias
Support for missing columns in affymetrix report files
Support invalid python names in src.features.affymetrix.read_affymetrixRow
Update requirements
Deal with missing files in import_datasets.py
Update Uruguay metadata locations
Move Galway sheep to Ireland country (Ovine HapMap)

Related Issue

closes #75
Motivation and Context

This PR model new data and code required to include new data into database
How Has This Been Tested?

Code has been tested by importing the data and by CI
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change which improve code itself)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Coverage increased (+0.1%) to 92.803% when pulling bd5639ee1bdba151d24c19df3d7bae2b127d6cde on devel into c1f1b364121723dbc1b8b745455237ea448623fc on master.


Reduce memory footprint

The test introduced in #1784 demonstrated that creating a million accounts results in average memory usage of 5kiB per account. This is far in excess of what is acceptable for even modest performance requirements,
We should consider reducing the memory footprint significantly.
The proposed solution is to use Trait objects in lieu of statically-typed enum objects.

This issue is especially given https://github.com/hyperledger/iroha/issues/1777

might be worth considering: https://github.com/upx/upx


Recompiling a ts file after changing the case of the filenames does not propogate the case change

Howdy,
I have a file called "Example.ts", I compile it, then I rename it to "example.ts" and re-compile.
The javascript files that get output remain "Example.js".
I expect my rename to propagate to my .js files.
The bug can get particularly ugly in visual studio, here is an example video:
https://www.youtube.com/watch?v=7cYQqvBSXPQ&feature=youtu.be
Here is my tsc:
{
  "compilerOptions": {
  "noImplicitAny": false,
  "noEmitOnError": true,
  "removeComments": false,
  "sourceMap": true,
  "target": "es6"
},
  "exclude": [
    "node_modules",
    "wwwroot"
  ]
}

am using tsc 1.6.2

Did not search well enough, #5275 should fix


HTTP request content getting improperly sorted into falcon Request object attributes

This is a weird problem, and I'm having a hard time articulating it, but suddenly yesterday I am unable to properly interact with falcon Request objects. It would appear that the attributes of the request are being improperly picked from the HTTP request body.
For example, the method and path attributes are populated with the CONTENT-TYPE header, such that:
request.method == "CONTENT_TYPE"
request.path == "application/json"
I am at a total loss as to why this is occurring. At first I thought my HTTP client was screwing things up, but I tried a variety of clients, from cURL, to HTTPie, to the Python requests library, and simple am having no luck.

I am using waitress as my WSGI server, it may be a player in this issue as well. I thought I'd work backwards from my application code, so I'm starting here.

Looks like when I use gunicorn for WSGI, things seem happy. I'm noting here that the running of each is different. waitress has an entry point inside a Python script, gunicorn is an executable to which you give a WSGI object as a parameter.. Checking to see if waitress can be invoked as such and if it still fails.

Ah! waitress exhibits this behavior even if I invoke it externally like gunicorn. Looks like Falcon is fine here, it's waitress that is barfing all over itself it would seem. Feel free to comment on this if you believe otherwise, but I'll go look into fixing waitress (or migrating to a different WSGI server...) now.

If anyone runs into the same thing (and as I've learned is as dumb as I am) here's what actually was happening. I'm quite embarrassed:
One of the values for one my headers had a newline at the end, resulting in an HTTP request like so:
POST /some/path
HEADER-KEY:header-vaue
                                                                          #  <--- this blank line makes HTTP think the following is the request body
Content-Type:application/json
Host:localhost
Connection: close
User-Agent:MyUserAgent
Content-Length:XXX

{"request_body_contents":"lalalalalalalalalala","something":"barbarbarbar"}     # I think this might just be straight-up ignored.


Fixed a small bug in L=4 blatt weisskoft coefficient.

Codecov Report

Merging #61 (7de55ea) into dev (d48ddd5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #61   +/-   ##
=======================================
  Coverage   69.39%   69.39%
=======================================
  Files          82       82
  Lines       11407    11407
  Branches     2189     2189
=======================================
  Hits         7916     7916
  Misses       2917     2917
  Partials      574      574

Flag
Coverage Δ

unittests
69.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tf_pwa/breit_wigner.py
92.73% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d48ddd5...7de55ea. Read the comment docs.


Add sigaltstack and related types

sigaltstack is part of the sigaction family of APIs, used to control which stack signal handlers run on.

@acfoltzer do you have plans to finish this PR?


upgrade spring-boot and spring framework

Upgrade to latest spring-framework v5 and spring-boot v2

Already here https://github.com/apache/camel/commit/d7ccd073c37c225cf29e0c9649745e9bc1234644
on branch master.
Do you need this on boot2ga? Everything it's in master now.

Ah the boot2ga branch is now merged to master so it should b deleted


The catalog page should have a link to the package

Suggestion:
When we upload a package to the gallery we first drop it in the "flatcontainer" without updating the flatcontainer index.json, so it is not yet discoverable
Then we create the catalog page, and the catalog page should have a link to the nupkg.

What is the intent of this? (e.g. is the client suddenly going to start consuming the catalog?)
/cc @joyhui @johnataylor


Feature/e2e

Description
Basic e2e test that covers:

Folder creation
Form save
XML upload
Wizard navigation
Folder publishing

To run, execute npx cypress open
Related issues
Closes #10
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update (this needs a follow up PR)

Changes Made

Installed Cypress and cypress-file-upload packages
Tested frontend logic with backend connection

Testing

[x] Tests do not apply

Note: There isn't much more to test in current state of the app. This merge can be used as base for e2e tests with Cypress.
Also, CI and GH Actions integration aren't in this PR. Should we try to get those running as well?

Also, CI and GH Actions integration aren't in this PR. Should we try to get those running as well?

yes I think those should be done as well this could be introduced as part of this PR or another PR  (if that is the case please create an issue about what will be done)
https://github.com/cypress-io/github-action - seems to be the way to go ?
Note: the workflow will change following https://github.com/CSCfi/metadata-submitter/pull/158 and https://github.com/CSCfi/metadata-submitter/pull/151
as the user would need login, but a mock AAI is provided in the integration tests of those PRs.

I am ok with leaving This example ... in the cypress files but I must recognise don't look very nice.
We would reference the source and where to find more information.
the only requests of change would be:

to have a github action for this.
mention in main README.md how to run the tests

I agree that example file doesn't look good.
I Removed the file and added e2e testing info to README.md


change the sample's application type from web to spa

change the sample's application type from web to spa to support pkce which changed in https://github.com/Azure/azure-sdk-for-java/pull/17530

LGTM

LGTM


Add cargo smart-release

cargo-smart-release seems great! And it even mentions they use the same Conventional Commits spec as I suggested in Noir. I think the reason I'd lean towards release-please is the ability to share workflows across various projects that may be rust, typescript, etc.
What do you think?

Yeah I think a homogenous approach would be better.
My only point towards cargo-smart-release was the fact that it seems to recognise workspaces, but we can get the same functionality that I would like by doing feat(acvm), feat(acir), feat({workspace_name})`

(Keeping this issue open until we switch to release-please)

Oh yeah, release-please has cargo-workspace support but you have to move away from specifying the version in the workspace file so it can manage the crates independently, which I felt was too heavy-handed/overkill for the noir repo but maybe it makes sense to diverge for this repo.

Closing this as we are using release-please


Add Note Command

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ba53b8c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #49   +/-   ##
=========================================
  Coverage          ?   68.03%
  Complexity        ?      417
=========================================
  Files             ?       75
  Lines             ?     1386
  Branches          ?      151
=========================================
  Hits              ?      943
  Misses            ?      402
  Partials          ?       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba53b8c...ed7cd4c. Read the comment docs.

We can actually use this, feel free to review and merge.


Add debian to setup and podman

As per https://github.com/ansible/receptor-collection/issues/32 I added these functionality on setup role:
Setup Role:
enhancements:

local_receptor variable to allow the usage of setup-local.yml that use local_receptor_path bin to setup receptor pkg. If set to true we skip the OS setup. This is indipendet from OS;
setup-Debian.yml that simply install package if someone pass it. Due to the fact that receptor is not in any Debian packages, we simply set __receptor_packages to [] and actually will not used for debian family, due to the fact that receptor package not exist;
setup-local.yml that copy local receptor bin to receptor_install_dir and configure system to associate service and so on. In case of local receptor bin was not foun on local_receptor_path we download the package from receptor repository with latest tag (or tag passed via vars).
In all cases we check the receptor via command and stop configuration if is not installed

bug-fixing:

remove become_user on tls_local.yml but maintain become to true. This to avoid the error on copy file when ansible try to become unprivileged user when task is runned under root and receptor_user is un unpriviledge user.

Podman Role:

added support to debian with installation of pkg via apt
added configuration of storage.conf to defer fuse-overlayfs on rootless env

Hi team,
i move this PR in ready for merge due to the fact that receptor repository is near to deploy the pre-build packages and now we can setup this on debian OS

what do you think about still running the Install dependencies specific to the node type task
but exclude receptor install if local_receptor is set
something like this,
diff --git a/roles/setup/tasks/main.yml b/roles/setup/tasks/main.yml
index 2730207..660f63c 100644
--- a/roles/setup/tasks/main.yml
+++ b/roles/setup/tasks/main.yml
@@ -4,7 +4,7 @@

 # Setup/install tasks.
 - include_tasks: "setup-{{ ansible_os_family }}.yml"
-  when: ansible_os_family in ['RedHat', 'Debian'] and not local_receptor
+  when: ansible_os_family in ['RedHat', 'Debian']

 - include_tasks: "setup-local.yml"
   when: local_receptor
diff --git a/roles/setup/tasks/setup-Debian.yml b/roles/setup/tasks/setup-Debian.yml
index 8f2c58d..d21678f 100644
--- a/roles/setup/tasks/setup-Debian.yml
+++ b/roles/setup/tasks/setup-Debian.yml
@@ -3,6 +3,7 @@
   ansible.builtin.apt:
     name: "{{ receptor_packages }}"
     state: present
+  when: not local_receptor

 - name: Install dependencies specific to the node type
   ansible.builtin.apt:
diff --git a/roles/setup/tasks/setup-RedHat.yml b/roles/setup/tasks/setup-RedHat.yml
index 24c51a2..5c9061e 100644
--- a/roles/setup/tasks/setup-RedHat.yml
+++ b/roles/setup/tasks/setup-RedHat.yml
@@ -3,6 +3,7 @@
   ansible.builtin.dnf:
     name: "{{ receptor_packages }}"
     state: present
+  when: not local_receptor

 - name: Install dependencies specific to the node type
   ansible.builtin.dnf:

what do you think about still running the Install dependencies specific to the node type task but exclude receptor install if local_receptor is set
something like this,
diff --git a/roles/setup/tasks/main.yml b/roles/setup/tasks/main.yml
index 2730207..660f63c 100644
--- a/roles/setup/tasks/main.yml
+++ b/roles/setup/tasks/main.yml
@@ -4,7 +4,7 @@

 # Setup/install tasks.
 - include_tasks: "setup-{{ ansible_os_family }}.yml"
-  when: ansible_os_family in ['RedHat', 'Debian'] and not local_receptor
+  when: ansible_os_family in ['RedHat', 'Debian']

 - include_tasks: "setup-local.yml"
   when: local_receptor
diff --git a/roles/setup/tasks/setup-Debian.yml b/roles/setup/tasks/setup-Debian.yml
index 8f2c58d..d21678f 100644
--- a/roles/setup/tasks/setup-Debian.yml
+++ b/roles/setup/tasks/setup-Debian.yml
@@ -3,6 +3,7 @@
   ansible.builtin.apt:
     name: "{{ receptor_packages }}"
     state: present
+  when: not local_receptor

 - name: Install dependencies specific to the node type
   ansible.builtin.apt:
diff --git a/roles/setup/tasks/setup-RedHat.yml b/roles/setup/tasks/setup-RedHat.yml
index 24c51a2..5c9061e 100644
--- a/roles/setup/tasks/setup-RedHat.yml
+++ b/roles/setup/tasks/setup-RedHat.yml
@@ -3,6 +3,7 @@
   ansible.builtin.dnf:
     name: "{{ receptor_packages }}"
     state: present
+  when: not local_receptor

 - name: Install dependencies specific to the node type
   ansible.builtin.dnf:

Yes, should be ok

Fix some reviews.
I added also specific systemd path for redhat and debian .
Only open points are:

[ ] remove install receptor for debina and for the "local" install
[ ] clarify if linger for rootless env should be maintainer
[ ] clarify if removal of become in the tls copy it should be maintained

okay after some testing, we do need the enable-linger task for the podman user on Debian. Without it, restarting the node will cause jobs to not run.

remove install receptor for debina and for the "local" install
yes remove receptor install for debian

clarify if linger for rootless env should be maintainer
yes keep linger for debian

clarify if removal of become in the tls copy it should be maintained
yes remove the become_user for tls copy

@fosterseth should be ok now. Let me know if something need to change.
Thanks

@fosterseth you mean that download should be done on controller node and then send everything to execution node?
Because in my mind execution node should be access on github/other repository, but we can think to modify this behaviour.
If yes, we need to change littlebit the logic, because we need to set ansible_system of execution node and then download package based on it (and skip if already exists).

since there's 24 commits i think we might want to squash and merge this PR
btw AMAZING work @fosterseth @tanganellilore !


UI Bootstrap 1.0.0+

Can the demo's and documentation be upgraded to work with UI Bootstrap 1.0.0+?
A lot of the directives have now been changed.

Agreed. Until then using $uibModal instead of $modal was the only difference for me.

@HackedByChinese  I would like to send PR with latest UI Bootstrap( 2.1.3), which also needs AngularJS upgrade to 1.4.x or higher.

@anuja-joshi Sounds good, if you'd like to.


gpflow.github.io

Currently https://gpflow.github.io/ gives a 404 not found error. Would be great if it could forward to gpflow.org or the docs underneath https://gpflow.github.io/GPflow/.
(In the longer run, it might be good to have the gpflow.org website through github.io as well - might make it easier to maintain? I don't even remember anymore how I would update the gpflow.org site)

Done.


Optional usability improvements

Things that would be nice to have (later):

[x] make the version argument optional (run most recent by default)

[x] make the token.txt optional (and modify the error message to say that it is optional)

[x] prompt the user to add the GitHub access token token.txt when running make.

[x] can we display the assumptions in English / slightly more helpful way? instead of a1_syn-2.0.77

[x] save the audit trust report to a file (on -a)

[x] optionally add a flag to specify the output file (for either logging or -a or both)

[x] rename detective.py to sherlock.py?

[x] log and -a could be separate subcommands instead of -a being a flag

[x] consider adding a flag to hide Z3 logging information

==================================
Solving for minimum weight of assumptions for tokio-1.40.0...
Number of Z3 Variables: 8
Formula Construction Time: 0.023 sec
Minimum weight of assumptions for tokio-1.40.0: 60
Z3 Solving Time: 0.004 sec
Z3 Num Conflicts: 5

consider adding a flag to hide Z3 logging information

Z3 logging information is now stored in logs/solver!

separate sub commands added.


Markdown and reminders support

Is it possible to add support for GitHub Flavored Markdown? This would allow for things like lists and checklists and general text formatting, without needing to create a separate note type. You don't have to add support for stuff like LaTeX or Mermaid diagrams if you don't want to.
Adding on to that, reminders/deadlines would be quite good for stuff like checklists, or even just regular notes.

Yeah, @noClaps that's a nice idea

So, I am assigning you

I don't know programming, I'm just saying that from a user perspective

I don't know programming, I'm just saying that from a user perspective

Ooo ok ok
Thanks, @noClaps for your suggestion

can you describe about this issue

can you describe about this issue

That's not an issue it's an idea if you read the first comment you will understand.

So we need to integrate markdown in the app right

So we need to integrate markdown in the app right

Not needed right now


Add inverse property

In other plugins exists an inverse property that in money, start inputs by decimal digits

use numericInput: true
Op di 19 mei 2015 om 16:47 schreef José Barbosa<EMAIL_ADDRESS>
In other plugins exists an inverse property that in money, start inputs by
decimal digits
—
Reply to this email directly or view it on GitHub
https://github.com/RobinHerbots/jquery.inputmask/issues/916.

#644

numericInput: true show it

here my code

The inverse is already available but is not working for complexer masks.
See issue #644


CSS not recognized when stylesheet added after Live Preview is launched

Original Subject: Live Preview not working for CSS
System: Mac OSX 10.9.3
Brackets: Sprint 39
Chrome: version 35.0.1916.114
Live Preview does not work at all with CSS. It works fine with HTML. I have tested all the suggestions on the troubleshooting page and searched the topics for similar problems.
The case I am testing is very simple: a folder including only a .html and a .css file. The .html file refers to the .css file. The .html includes only some simple very basic code, including a header with a certain ID. The .css defines the background color of this header.
When I activate Live Preview Chrome opens and shows the page perfectly. When I alter the text in the header, it is immediately updated in Chrome (without saving or refreshing).
When I go to a css line, the Live Preview highlights the section which the css line relates to. However, when I change for example the color in the css line (either in the .css file or in the quick edit view), nothing is changed in the preview in Chrome.
When I then save the files (html and css) and refresh the Chrome webpage, still nothing changes. (the Live Preview is still working for the html and to highlight the sections)
When I then disable Live Preview and enable it again, the page is reopened in Chrome with the new color. However, when I refresh the page in Chrome (without changing anything else), the color is changed back to its original color, while this 'setting' is nowhere in the css anymore (the adjustment has been saved).
The same works the other way around: when I change the color say from yellow to red, save the file and refresh the Chrome page (Live Preview is constantly on) I see that it does not update the view (still yellow). If I then, before doing anything else, change the color back again to it's original color (yellow) in the css file, save the file and disable Live Preview to enable it again, the page is shown with a red header background...
I get the feeling that I am missing something obvious here because it doesn't work at all with css while it works with html, but I can't figure out how to get it working.

I am a beginner, and confused how to use the .html file and .css file of mine. I prepared them using Sublime Text 2 and paste them in github respiratory of mine, as site it displays but clearly the style format .css doesn't work. Actually, they are under one folder, but I think somehow they have to have some connection, but they don't. How to solve my problem, please?

@girm1 Live Preview uses the browser, so your page needs to work in browser without Brackets or Live Preview. Once your page is working in a browser, then you can use Live Preview.

Hi, Randy,
Thank you very much, for your fast answer. As I said last time, I am new
for the github system, unfortunately, I couldn't realize your answer. From
my sublime text 2 of my computer, my project has shown good on the browser;
however, when I created the respiratory in github and override the
existence .html and.css files by mine, by simply copying from sublime and
paste to github, in fact, the html file is shown on the browser, but
terribly, because of not reading the .css file or not formatted. For
clearance, I attached the two files, with some modification. Please,
explain me step by step what I have to do.
Thank you,
Girma
On Sun, Jan 25, 2015 at 2:17 PM, Randy Edmunds<EMAIL_ADDRESS>wrote:

@girm1 https://github.com/girm1 Live Preview uses the browser, so your
page needs to work in browser without Brackets or Live Preview. Once your
page is working in a browser, then you can use Live Preview.
—
Reply to this email directly or view it on GitHub
https://github.com/adobe/brackets/issues/7990#issuecomment-71390682.

@girm1 First, go through the Troubleshooting guide -- you might find solution there.
Otherwise, your problem does not seem to be related to this issue, so please open a New Issue with all of these details. Attached files to not get sent through so you have to paste in the contents in issue (if files are small enough) or provide a link to your files.

Actually, this question doesn't sound like it's related to Brackets at all.  I don't see any mention of Live Preview or other Brackets features.  It sounds like the question might actually be about GitHub Pages, an online hosting feature of GitHub itself.
@girm1 If you're actually using the desktop code editor app Brackets, could you post a series of screenshots showing what you're doing in Brackets, along with more details on what you're trying to accomplish?
In the meantime though, I'll close this since I suspect it's not a Brackets issue.

@peterflynn Re-opening. I asked @girm1 to open a new issue because that problem is unrelated to this issue, but this issue (captured in this comment) is still valid.

Ah, sorry -- somehow I missed the earlier comment history above that :-/

Workaround: delete & re-add the tag after creating the CSS file. Then Live Preview will reflect the CSS file (and will update live to reflect future edits to it).
This is probably similar to #7348: HTML Live Preview creates the tag, but the tag fails to load since the file doesn't exist yet; later, when the file does exist, we have to go back and poke the browser to "retry" loading the tag (which can only be done by removing it from the DOM and re-adding it).


DefaultConfigService should be a map

It act like so, but is not. This way, it would be easier to use it as a dev.

there is already a record (exportedData) existing


Sandcastle moved to GitHub

Sandcastle
Sandcastle Help File Builder similar to NDoc
https://github.com/EWSoftware/SHFB
Sandcastle moved to GitHub

@cdrfun Thanks.


Fixed typo: substition(s)->substitution(s)

Corrected a few other occurrences of substition(s).

Thanks, I guess word completion kicked in.


C# performance worker improvements

Improve C# qps worker to support more perf testing scenario. Modifications:

support async streaming closed loop and  async unary closed loop scenarios
support generic client and generic server
honor request.ResponseSize in simple server
print warning for some features that are not supported yet

I've tried C# qps worker successfully with these scenarios:

1, 2, 7, 8, 11, 12, 13
we'll need to define a "mixed" scenario with sync client and async server (C# only has sync client), perhaps as scenario "5b" or "6b".

Rebased & friendly ping.

Yes, will check up on this shortly.
On Fri, Mar 25, 2016, 4:29 PM Jan Tattermusch<EMAIL_ADDRESS>wrote:

Rebased & friendly ping.
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/5904#issuecomment-201582943

LGTM except for a few minor comments, most of which do not require changes in the current PR. My only request for the current PR is to use a warning instead of an assertion in the one case that I mentioned. Sorry for the delay.

LGTM.


Fix apps navigation when connection wallet connect from in app browser

Steps to reproduce:

Open some app;
Switch to AW app;
Tap Browser tab
Visit app.mail3.me
Tap WalletConnect
Wait

Expectation:

no redirection
Actual:
app get redirected to prev used app

How do you do this especially step (2)?

Open some app;
Switch to AW app;

I'm trying to look for the little system-generated back button at the top left to appear at the end of step 2.

@oa-s bump ^

Is there could be a case when she open link not from a browser, but from another app? Telegram for example. In this case it get generated https://aw.app/ethereum:0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7/transfer?address=0x8e23ee67d1332ad560396262c48ffbb01f93d052&uint256=1

Ah, thanks. So:

Open Notes or Telegram etc. Tap on a link that opens AlphaWallet (eg. https://aw.app/ethereum:0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7/transfer?address=0x8e23ee67d1332ad560396262c48ffbb01f93d052&uint256=1)
Automatically switched to AW app
Tap Browser tab
Visit example.walletconnect.org
Proceed to connect (tap reject, it's easier)

But this sounds a bit rare. Let's see how common is this. How did it happen to you?


Add auto refresh settings to Serilog for WebApiBox

https://edi.wang/post/2019/1/5/auto-refresh-settings-changes-in-aspnet-core-runtime

Reopen if this feature will ever be required.


🚧 WIP: reinstall systemd for the Oracle 8 test

Description
The oraclelinux:8 image has had many of the files laid down by the systemd package removed from its filesystem. The package must be reinstalled because the system thinks it already has been.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

Well, at least it's a different error now.
  | * timezone[UTC] action set
  | * dnf_package[tzdata] action install (up to date)
  | * execute[/usr/bin/timedatectl --no-ask-password set-timezone UTC] action run
  |
  | ================================================================================
  | Error executing action `run` on resource 'execute[/usr/bin/timedatectl --no-ask-password set-timezone UTC]'
  | ================================================================================
  |
  | Mixlib::ShellOut::ShellCommandFailed
  | ------------------------------------
  | Expected process to exit with [0], but received '1'
  | ---- Begin output of /usr/bin/timedatectl --no-ask-password set-timezone UTC ----
  | STDOUT:
  | STDERR: Failed to create bus connection: No such file or directory
  | ---- End output of /usr/bin/timedatectl --no-ask-password set-timezone UTC ----
  | Ran /usr/bin/timedatectl --no-ask-password set-timezone UTC returned 1


Converted Files with UTF8 BOM to UTF8 and Opted into Common Tests - Fixes #250

Pull Request (PR) description
Several of the module files were using UTF8 with BOM encoding. This PR converts them to UTF8 encoding. It also opts into the common tests:
"Common Tests - Validate Module Files"
"Common Tests - Validate Script Files"
This Pull Request (PR) fixes the following issues:
Fixes #250
Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[ ] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

Codecov Report

Merging #251 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #251   +/-   ##
===================================
  Coverage    97%    97%
===================================
  Files        17     17
  Lines      1321   1321
===================================
  Hits       1284   1284
  Misses       37     37

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@johlju - would you mind signing off this one again? Had to rebase after merging the other PR.

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Nordic lighting app OnSRPClientNotification: [DL]Operation refused for security reasons

Problem
Keep seeing the message in the above title when pairing Nordic lighting app and consequently failing the pairing.
It occurred with both commit 9cc0fb36dbc1508159788cac6adf26322ec5f558 as well as with cfc35951be66a664a6efdadea56d1b8ea6e63e96.
Attached files are the Nordic log and Wireshark PCAP log, reproduced with cfc35951be66a664a6efdadea56d1b8ea6e63e96.
The problem occurred between  7:25:19am PDT and 7:26:15am PDT.
802.15.4 decryption key: B38E612D11DC3BB798545AA8BC1C9D07
Key index: 0
20220517-nordic-refused.txt
20220517-Nordic-operation-refused-for-security-reasons.pcapng.zip
Proposed Solution
N/A

I looked back at the Apple border router log and found that updates were rejected by the Apple border router as well, most likely for the same reason as #18737. Hence, this is no issue for Nordic platform.

@Damian-Nordic
I'm reopening this issue because @Abhayakara found an issue on Nordic side, too.
Packet # 121 in the pcap file, the subtypes with TTL=0 must not be present, per https://www.ietf.org/archive/id/draft-ietf-dnssd-srp-13.html#name-handling-of-service-subtype .
Specifically, "Similarly, there is no mechanism for deleting subtypes. A delete of a service deletes all of its subtypes. ".
Copied the packet #121 DNS records below.
Domain Name System (query)
    Transaction ID: 0x7b33
    Flags: 0x2800 Dynamic update
    Zones: 1
    Prerequisites: 0
    Updates: 13
    Additional RRs: 2
    Zone
    Updates
        _matter._tcp.default.service.arpa: type PTR, class IN, 8E21999A5C0AD09A-00000000E0C9C955._matter._tcp.default.service.arpa
            Name: _matter._tcp.default.service.arpa
            Type: PTR (domain name PoinTeR) (12)
            Class: IN (0x0001)
            Time to live: 7200 (2 hours)
            Data length: 36
            Domain Name: 8E21999A5C0AD09A-00000000E0C9C955._matter._tcp.default.service.arpa
        _I8E21999A5C0AD09A._sub._matter._tcp.default.service.arpa: type PTR, class IN, 8E21999A5C0AD09A-00000000E0C9C955._matter._tcp.default.service.arpa
            Name: _I8E21999A5C0AD09A._sub._matter._tcp.default.service.arpa
            Type: PTR (domain name PoinTeR) (12)
            Class: IN (0x0001)
            Time to live: 7200 (2 hours)
            Data length: 2
            Domain Name: 8E21999A5C0AD09A-00000000E0C9C955._matter._tcp.default.service.arpa
        8E21999A5C0AD09A-00000000E0C9C955._matter._tcp.default.service.arpa: type ANY, class ANY
            Name: 8E21999A5C0AD09A-00000000E0C9C955._matter._tcp.default.service.arpa
            Type: * (A request for all records the server/cache has available) (255)
            Class: ANY (0x00ff)
            Time to live: 0 (0 seconds)
            Data length: 0
        8E21999A5C0AD09A-00000000E0C9C955._matter._tcp.default.service.arpa: type SRV, class IN, priority 0, weight 0, port 5540, target FAD789F07C0D4A01.default.service.arpa
            Service: 8E21999A5C0AD09A-00000000E0C9C955
            Protocol: _matter
            Name: _tcp.default.service.arpa
            Type: SRV (Server Selection) (33)
            Class: IN (0x0001)
            Time to live: 7200 (2 hours)
            Data length: 25
            Priority: 0
            Weight: 0
            Port: 5540
            Target: FAD789F07C0D4A01.default.service.arpa
        8E21999A5C0AD09A-00000000E0C9C955._matter._tcp.default.service.arpa: type TXT, class IN
            Name: 8E21999A5C0AD09A-00000000E0C9C955._matter._tcp.default.service.arpa
            Type: TXT (Text strings) (16)
            Class: IN (0x0001)
            Time to live: 7200 (2 hours)
            Data length: 21
            TXT Length: 8
            TXT: CRI=5000
            TXT Length: 7
            TXT: CRA=300
            TXT Length: 3
            TXT: T=0
        _matterc._udp.default.service.arpa: type PTR, class NONE, 068094B6B32F6112._matterc._udp.default.service.arpa
            Name: _matterc._udp.default.service.arpa
            Type: PTR (domain name PoinTeR) (12)
            Class: NONE (0x00fe)
            Time to live: 0 (0 seconds)
            Data length: 19
            Domain Name: 068094B6B32F6112._matterc._udp.default.service.arpa
        _V65521._sub._matterc._udp.default.service.arpa: type PTR, class NONE, 068094B6B32F6112._matterc._udp.default.service.arpa
            Name: _V65521._sub._matterc._udp.default.service.arpa
            Type: PTR (domain name PoinTeR) (12)
            Class: NONE (0x00fe)
            Time to live: 0 (0 seconds)
            Data length: 2
            Domain Name: 068094B6B32F6112._matterc._udp.default.service.arpa
        _S15._sub._matterc._udp.default.service.arpa: type PTR, class NONE, 068094B6B32F6112._matterc._udp.default.service.arpa
            Name: _S15._sub._matterc._udp.default.service.arpa
            Type: PTR (domain name PoinTeR) (12)
            Class: NONE (0x00fe)
            Time to live: 0 (0 seconds)
            Data length: 2
            Domain Name: 068094B6B32F6112._matterc._udp.default.service.arpa
        _L3840._sub._matterc._udp.default.service.arpa: type PTR, class NONE, 068094B6B32F6112._matterc._udp.default.service.arpa
            Name: _L3840._sub._matterc._udp.default.service.arpa
            Type: PTR (domain name PoinTeR) (12)
            Class: NONE (0x00fe)
            Time to live: 0 (0 seconds)
            Data length: 2
            Domain Name: 068094B6B32F6112._matterc._udp.default.service.arpa
        068094B6B32F6112._matterc._udp.default.service.arpa: type ANY, class ANY
            Name: 068094B6B32F6112._matterc._udp.default.service.arpa
            Type: * (A request for all records the server/cache has available) (255)
            Class: ANY (0x00ff)
            Time to live: 0 (0 seconds)
            Data length: 0
        FAD789F07C0D4A01.default.service.arpa: type ANY, class ANY
            Name: FAD789F07C0D4A01.default.service.arpa
            Type: * (A request for all records the server/cache has available) (255)
            Class: ANY (0x00ff)
            Time to live: 0 (0 seconds)
            Data length: 0
        FAD789F07C0D4A01.default.service.arpa: type AAAA, class IN, addr fd03:9558:1ab3:0:edf1:223f:4999:13ad
            Name: FAD789F07C0D4A01.default.service.arpa
            Type: AAAA (IPv6 Address) (28)
            Class: IN (0x0001)
            Time to live: 7200 (2 hours)
            Data length: 16
            AAAA Address: fd03:9558:1ab3:0:edf1:223f:4999:13ad
        FAD789F07C0D4A01.default.service.arpa: type KEY, class IN
            Name: FAD789F07C0D4A01.default.service.arpa
            Type: KEY (security key) (25)
            Class: IN (0x0001)
            Time to live: 7200 (2 hours)
            Data length: 68
            Flags: 0x0201
            Protocol: 3
            Algorithm: ECDSA Curve P-256 with SHA-256 (13)
            [Key ID: 40877]
            Public Key: a02d07cbe1bd4da82e375211e4f3d3dad5e77ea2f932623f2940f0ddbffe9a3af55b2d41…
    Additional records
        <Root>: type OPT
            Name: <Root>
            Type: OPT (41)
            UDP payload size: 1272
            Higher bits in extended RCODE: 0x00
            EDNS0 version: 0
            Z: 0x8000
                1... .... .... .... = DO bit: Accepts DNSSEC security RRs
                .000 0000 0000 0000 = Reserved: 0x0000
            Data length: 12
            Option: UL - Update lease
        <Root>: type SIG, class ANY
            Name: <Root>
            Type: SIG (security signature) (24)
            Class: ANY (0x00ff)
            Time to live: 0 (0 seconds)
            Data length: 84
            Type Covered: Unused (0)
            Algorithm: ECDSA Curve P-256 with SHA-256 (13)
            Labels: 0
            Original TTL: 0 (0 seconds)
            Signature Expiration: (0)Dec 31, 1969 16:00:00.000000000 PST
            Signature Inception: (0)Dec 31, 1969 16:00:00.000000000 PST
            Key Tag: 0
            Signer's name: FAD789F07C0D4A01.default.service.arpa
            Signature: 7fc400c594bef6b782fb832d34f4a81546568dd49f3eeddbfa129631dede49d8337fdd48…
    [Response In: 124]

@Damian-Nordic could you please take another look at this issue as this particular issues is causing several failures in our testing and in general is the root cause of poor pairing reliability on Nordic platform?

@aajain-com The issue with sending PTR records with TTL=0 must be sent in OpenThread before we can integrate it into the Nordic's SDK. Abtin commented in https://github.com/openthread/openthread/issues/7742 that he would plan to take a look at that. Is there a confirmation from Apple Border Router developers that the records are the reason why the SRP update is rejected?

@Damian-Nordic, TLDR, I will add a PR  in OT to change this to unblock this.
Some thoughts on this:

My interpretation of this was that when we remove a service, it automatically removes all its sub-types as well.
This seems to be similar to how when we remove a host, all its registered services are also removed on server.
SRP client therefore has the option to optimize this (client can chose to include explicit removes or leave it out)
Server would then handle this either way.
I know and expect this to work when we remove a host (server should handle it either way if client include service removes or not).
But it seems to be treated differently for service remove with it sub-types.
It may be worth it to relax the Apple's server implementation to allow this (can simply ignore sub-type remove PTRs) to ensure they can handle devices that may use older OT implementation.

Some background on this:

We added sub-type support (since matter wanted to use it) in SRP implementation in OT before it was added in the SRP spec draft.
On client side we kept the implementation simple in the sense that all sub-types are always included in SRP update (we considered it specific behavior/restriction of OT SRP client).
On server side, we kept the implementation more flexible (allowing subtypes in different SRP updates). The idea at the time was to support sub-types in multiple SRP updates on server side and/or allow remove of a sub-type, and see if we want to change/enhance it on client later.
Later on (as Ted also looked into implementing this), we noticed allowing sub-types in different SRP updated can create a lot of unnecessarily complex situations, so in the latest SRP draft the atomic treatment of sub-types is required explicitly.

It seems pretty simple to just not emit the subtype if its lifetime is zero.

Hi, I managed to test Apple border router with the Nordic Thread device containing the sub-type PTR removal fix from @abtink. It works better, as Apple border router accepts the service removal sent by the Matter firmware. Unfortunately it still rejects the removal using OpenThread CLI commands (ot srp client service remove ... ) with the same error message "[DL]Operation refused for security reasons". On the other hand service removal using both methods (by the Matter firmware and ot cli) works fine with the OpenThread Border Router, so still we have some behavior difference here.
To discover the difference between Matter firmware and OT cli I gathered pcaps from Wireshark. It looks like the Matter firmware doesn't simply remove single service, but also by the way updates another services. OT cli srp remove command just removes the single service, so my assumption is that Apple Border Router rejects the SRP updates that contain only service removal operation. Please see the wireshark screenshots:
SRP removal request by the OpenThread CLI remove command

SRP removal request by the Matter firmware:

@Abhayakara @kpark-apple do you have any ideas on why single remove operation could be rejected by the Apple TBR?

It looks like the OT cli is removing the service PTR and service instance name and adding the host, so you have a host with no services after this is done. This should be okay. I don't know if you're able to send me un-redacted logs from your Thread BR (you'd have to run this with the debugging profile and then generate a sysdiagnose).
Instructions for debugging profile here if you don't have them: https://download.developer.apple.com/iOS/tvOS_Logs/mDNSResponder_Logging_Instructions.pdf
General page for info about debugging profiles here: https://developer.apple.com/bug-reporting/profiles-and-logs/
The instructions include how to generate a sysdiagnose and attach it e.g. to an email message or upload it. If you can do the above while reproducing the issue, I should be able to figure out why the update is being rejected by looking at the log. Bear in mind that all your DNS lookups are not private while this profile is installed.


bump dep version

Any update here @rustonaut?
If you don't have time to maintain, you can add some other people as maintainer also <3

Just telling you that I didn't forgot you.
The thing is this isn't really my project, it's a bit complicated.
I will try to resolve it (last time that fizzled out :sweat: ).
If it can't be resolved I will put up and appropriate way forward for the project soon.

The thing is this isn't really my project, it's a bit complicated.

😃
Now it is @meh, hello there.

If it can't be resolved I will put up and appropriate way forward for the project soon.

I think anytime you can ask either of these communities to help:
https://github.com/rust-unofficial
https://github.com/rust-lang-nursery

Now it is

You maybe might be mixing up people :sweat_smile: (1) I'm not meh. Through the project is now back home instead of being stranded in my account :tada:
(1): Or maybe not, your sentence can be interpreted in multiple ways.

The project was at https://github.com/rustonaut/rust-phonenumber, now it is at https://github.com/meh/rust-phonenumber
So I thought the ownership has been moved from you to @meh, no?

Yes you are correct, your sentence just could have been interpreted as you believing that meh is e.g. my private account while rustonaut is a work account or something similar.
------- Original Message -------
On Monday, May 23rd, 2022 at 10:12 PM, Omid Rad @.***> wrote:

The project was at https://github.com/rustonaut/rust-phonenumber, now it is at https://github.com/meh/rust-phonenumber
So I thought the ownership has been moved from you to @.***(https://github.com/meh), no?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Hello darkness my old friend. I remember the week I spent writing this, it really taught me how to hate phone numbers.
Anyway, I'll do a pass of merging and stuff soon.

the current nom and quick-xml versions being used are not going to be supported on future versions of Rust. Can we push this PR through?

Thanks a lot @name1e5s I took your change and updated dependencies once again as part of 6640133a3b433d21e80e44f5e04ec2da2e10f5cb before the repository was transferred to us.


Psubscribe

Looks like there is trouble using psubscribe in last version (0.12.1).
when I use this, i receive message
redisSub.subscribe('/checktoken');
When i use this, nothing happen:
redisSub.psubscribe('*');
Nothing change except that in my code.
(Project here: https://github.com/StephaneC/SocketIoToBus)

Hey @StephaneC I think the problem is that you should be calling:
client.on('pmessage') rather than client.on('message'), if you're using psubscribe.
I've added a unit test for your specific use-case,
https://github.com/NodeRedis/node_redis/pull/796
let me know if you continue to run into problems and we can reopen this ticket.

@bcoe we might consider consolidating the event handler, don't you think so?


Further increase ES2015 compliance

There are massive changes to the ESLint file, though I hopefully didn't
turn on anything too egregious.  Anyway, this commit makes the code as
ES2015-compliant as native Node.js will allow.  Nothing in here should
not be supported by Node 6.x, but I still recommend the field in
package.json for specifying Node 8+, which is in active LTS as of the
time of writing, in which case, the project may wish to consider going
to ES2016 or 2017 support instead to nab that exponent operator as well
as the object spread operator.
Further additions to the code include a beefed-up .gitignore file,
courtesy of https://gitignore.io, as well as a small .eslintrc.json
file in the testing area.  The latter allows for the removal of the
comment headers about define and it, as they are defined as part of
the mocha environment.  It inherits everything from the settings above
it, too, so it's able to be super compact.
Signed-off-by: Jonathan Sifuentes<EMAIL_ADDRESS>

Instead of Standard, if you like semicolons, might I suggest semistandard, airbnb-base, or even the PrettierJS line of tools? With the latter option, options can either be injected directly into the .eslintrc or can be inserted in a .prettierrc file, which is JSON formatted.


5.7.4 RC1 - Redactor button tooltips are partially hidden by mouse cursor

When a user moves their cursor from Redactor content to the Redactor toolbar the mouse cursor hides portions of the tooltip.

Moving the tooltip to the top prevents this.

If you change this don't forget to leave the tooltip to the bottom when the toolbar is fixed on top.


Handle errors upon attempt to load and parse annotations

When there are SR documents available that don't conform with the format expected by Slim, the viewer displays an error message.

Not all errors may be worth bringing to the attention of the user. Let's try add checks to determine whether an existing SR does represent a displayable annotation.

First reported by @fedorov in #42

@wlongabaugh @fedorov as discussed this morning, I am not entirely sure what causes this error to be displayed. I've added a couple of additional checks of SR document content before attempting to extract annotations from the Measurement Report (see #58). Does this resolve the issue?

Testing your branch against the dev proxy is the best way to check if this solves the problem.

This turned out to be an issue with the DICOMweb interface of either the Google Healthcare API or the proxy server.
If there was no match for the search transaction, the server responds with an empty HTML document instead of with a empty JSON array as specified by DICOM Part 18 Section <IP_ADDRESS>.3.

In addition, the server erroneously responds with status code 200 instead of 204 as specified by DICOM Part 18 Section <IP_ADDRESS>.

The erroneous status code (200 instead of 204) seems to be caused by the proxy, because when accessing the Google Healthcare API directly a 204 status code is returned as expected.
The erroneous payload (text/html instead of application/dicom+json) seems to be an issue with the Google Healthcare API. I have reported the issue, but it may take some time until it will get fixed.
Of note, the dicomweb-client will ensure that an empty array is returned to the caller when a 204 status code is returned by the origin server.


Document multiple request/response loops in examples

An API documentation example might encompass multiple requests to the API. Right now we don't support this, and I believe a later request will override a former one.

Still needs some styling, but this is in 0.3.0


How to customize/encode IDs in the API?

Is it possible to encode IDs in the Wagtail API instead of revealing the actual database IDs?
For example, I'd like to use hashids instead like DRF Serializer Extensions enables here, but the DRF Serializer Extensions doesn't seem to work with Wagtail.
I'm currently custom-overriding the PagesAPIViewSet, PageSerializer, and PageParentField. But this is tedious and brittle.

If this doesn't exist, I think the most convenient way to do it would be for Wagtail or its router to take a setting like page_id_override with either:

the string name of the field to use instead of id
or an object with encode/decode functions like: {encode: fn, decode: fn} that passes the id and specific Page model class in or the actual instance for encode

@bunnyfly Would these changes help? https://github.com/wagtail/wagtail/pull/6164

Hey @ababic! Thanks for the link and response :-)
I think that fulfills half the need (not revealing actual DB IDs)! But the other half is that there's an established pattern of using hashids in my API.
Two immediate benefits that they give over UUIDs are that they encode not just the ID but also the model type (Wagtail Page in this case); and that they're short, user-friendly, and URL-friendly (e.g. yx7u5 vs ffd115ea-925c-46ae-8958-e63990d635c3).
I'm not advocating for hashids themselves, just illustrating the fact that giving users a choice and opportunity to encode/decode or pick their own ID fields could be useful!
My current solution I threw together yesterday was:

Overriding wagtail.api.v2.views.PagesAPIViewSet's get_urlpatterns detail path to allow string pk params.
A middleware that decodes incoming pk params on the Page detail path from hashids into ids.
Custom PageSerializer (and nested PageParentField) set as my custom PagesAPIViewSet's base_serializer_class that overrides the ID fields.

I'm sure that doesn't capture all the ways IDs might creep up or get used, but it seems to be working so far.

@bunnyfly thank you for the thorough reply.

Two immediate benefits that they give over UUIDs are that they encode not just the ID but also the model type (Wagtail Page in this case); and that they're short, user-friendly, and URL-friendly (e.g. yx7u5 vs ffd115ea-925c-46ae-8958-e63990d635c3).

I'm with you here on the benefits over UUIDs, but I'm just wondering what the benefits over using the integer IDs are, as they would surely be shorter and even more user-friendly?
Also, the pages API already has a concept of types, as they appear in results, and can be filtered on, so do type-flavoured identifiers really add much in this case?
I realise I'm getting "beside-the-point" slightly here, as this isn't an argument for or against hashids specifically. But, I have to wonder how useful a generic "swap the ID-related behaviour of the API" feature would really be. I don't feel like there are many approaches you could take, and it would add quite a large degree of additional complexity.
If developers do have a preference for something like hashids, then I think the only reasonable solution is to subclass the bits they need to and figure out what needs to be overridden. Maybe there are some smaller, safer, tweaks that can be made to make that process less tedious (and we'd happily review such PRs), but I don't feel like an implementation of this proposal (in its current state) would be benefitial enough to warrant the overhead of development and maintenance.


[choreo] Use anti-tunneling math in control interval guess

the guess control interval counts in choreo will take into account the minimum width of the robot to have a better chance that there are enough intervals to prevent tunneling in trajoptlib.

splitting this pr into 2. one for choreo side and one for trajoptlib.


Add slightly hacky delay test

@landmanbester @rcyndie This PR adds an imperfect test for the delay initialization. It doesn't test everything and can definitely be improved but it is a starting point. An almost identical test could be added for a TEC initialization method. Note that the comparisons are not to high precision as this only uses the initialization i.e. it will be limited by the accuracy of the transform.

This has been superseded.


Nested metadata splitters

From Discord:
AM] jMyles: At first blush, this seems reasonable
[10:58 AM] jMyles: When do you suppose that these lengths will be used (by users of BSS, I mean).  In other words: what does the length of a (for example) ChecksumVerifyingSplitter mean to them?
[10:58 AM] jMyles: One thing I don't like about it: if the question is, "why I cast-and-append this, how many bytes will it occupy in my payload?" - it gives the wrong answer.
[11:11 AM] kprasch: This assertion shows show clean to compare can look now - without any special handling https://github.com/nucypher/bytestringSplitter/pull/33/files#diff-6c0b8eda6e69baae4b3b68f649a626b7R296
[11:12 AM] kprasch: It at least partially depends on how len is evaluated in nucypher under the hood
[11:13 AM] kprasch: Analternate approach might be to have methods for evaluating length
[11:20 AM] jMyles: I get it, I get it.  And as I say, it seems sensible.
But ultimately the question is: what are users likely to expect here?
Are they likely to expect that the "discharge" is the measurement being conducted by len?  Or the actual bytes representation of the object they have in hand?
[11:21 AM] jMyles: Typically, if I have an object (that is not a collection), foo, of type Foo, I expect that if len(foo) == x, then len(bytes(foo)) == x will hold as well.
[11:21 AM] jMyles: Let's bring it over to the PR
[11:21 AM] damonC: I kinda feel like the stuff we are adding for versioning and checksuming is "headers"
[11:21 AM] damonC: ok

@jMyles said this

One thing I don't like about it: if the question is, "why I cast-and-append this, how many bytes will it occupy in my payload?" - it gives the wrong answer.

This is a good point.
@KPrasch you're right, maybe to deal with this we can just have a def total_length

I found that the use of __len__ internally was causing me some headaches in that sometimes I want the bytes length and other times the payload length, and so i had to do stuff like this

Or length_including_headers ?

right.
So... should len(a_splitter_class) be the length we should expect as bytes?
To be fair, one reason I didn't go that way is that if there's a VariableLength included in the splitter, what's the point anyway?


Accessing IR Omni publisher with the create_2

Put simply, it lists that the ir sensors are supported with this repo, but I'm unable to see it as a topic in ros with gazebo and the create_2.launch file, is this feature only for runtime instead of gazebo?

Only the omni IR sensor is supported, and this referring to the real robot driver. Note, this is a passive sensor (not a range finder). To get an equivalent sensor in a Gazebo simulation, we should modify the simulation description with an appropriate plugin. I'm not sure if there exists a plugin for this type of fiducial sensor.

Thankyou for the reply, would it be possible to get help to work on this? I'm willing to help out as much as I can, but I have little experience with developing urdf or sdf models.

@Interaze I don't have much time to dedicate, but it does look like gazebo_ros supports bumper sensors. You could try adapting that example, adding it to the create gazebo description file.


WIP: implement comment parsing

This PR implements the comment parsing #10
I have 2 questions:

I've left #token and token# as invalid_op errors rather than comment errors. Would you prefer for these to give invalid comment errors?
There are quite a few “TODO: add comments” instructions throughout. All of the cases seem to be covered by implementing the parsing in TokenStream, but before removing them I wanted to check if there’s something else you intended in those spots or with this implementation in general

You can leave the "TODO: add comments" as is. We'll do another pass later to write proper documentation.
🤦 Yes, of course that's what that means. I guess I was really laser focused on comment parsing to interpret everything as relating to that :)

Could you add a test case for when a comment is placed after the last end token?
I added after end and another test for before begin, since that could fail in a different way with an implementation inside advance() as discussed


Move borehole.temperature_uncertainty to profiletable?

This is another comment that came up from Marcus. Incidentally I found myself wondering the same thing when I corrected the data from Odegard. It seems that it's really an attribute of the profile, more than the borehole? It this something we have just kept there for historical reasons, or is there a practical reason?

@mjacqu We've discussed this as being inevitable in the long run, but had yet to encounter a situation where this was needed, so we decided not to do it as it adds to the curatorial burden. Do we now have a situation where we really need profile.temperature_uncertainty instead? I'm not aware of one, but what we have run into already is the need for measurement.temperature_uncertainty. For example when uncertainties are estimated from repeat measurements at depth or from the extrapolation of the thermistor timeseries to an equilibrium temperature.
We could consider an optional column in measurement and either a column in borehole or profile that provides a default.


[Event Request] Table 37 "Sales Line"."No."

Please add event as we required in #21355. I can not find event OnValidateNoOnAfterCreateDimFromDefaultDim. I can not use event from subfunction CreateDimFromDefaultDim, because my code have to work for validate trigger only not for subfunction.

Availability update: We will publish a fix for this issue in the next update for release 22.
Build ID to track: 56629.


Inspiring Leader is broken

2nd lvl paladin with 18 charisma supposed to give +6 temp hp, but gives only +1.
https://drive.google.com/drive/folders/1E53u8lA6rIoGiXSDMkG8WyV_L5btboWb?usp=sharing
Game version 1.4.31
Mod version <IP_ADDRESS>

fixed on <IP_ADDRESS>, DEV branch. Thanks.


[Bug] dbatools.io/commands Data Masking appears twice

Errors Received
dbatools.io/commands site:

Steps to Reproduce
Data Masking appears twice in the Categories section.
In the orange highlighted one, the anchor link doesn't work;
in the yellow highlighted one, the anchor link does work.
Expected Behavior
Only 1 entry for Data Masking
Actual Behavior
Two (one duplicate) entry, and one anchor not working.

That should be fixed now.

Seems stale bot is messing up now, it should not have labeled this in 14 days. :(


Logentries and nodemailer integration

Now using nodemailer to notify via email when either 1) hard error occurs 2) the api-sync server starts 3) the api-sync server stops.
Additionally integrated w/ logentries to channel significant events/errors/warnings to logentries service.
Refer to the README configuration section for details on setting up logentries and nodemailer tokens/auth.

yea unfortunately need that token for the logentries service, switched to direct smtp usage: https://github.com/jsdelivr/api-sync/pull/17


Extension Names in Extension Browser Should Display an  ... For Long Names

Search for angular  in the extension explorer

Bug
Note that extension names that are too long have a hard cutoff
Suggested Fix
Add a ... overflow to the name, similar to the extension description

@mjbvz I would like to contribute here. As the names of the extensions are under a flex box we should force the ... on its children, as text-overflow applies to block elements.
.extensions-viewlet>.extensions .extension>.details>.header-container>.header {
min-width: 0;
}
.....
.extensions-viewlet>.extensions .extension>.details>.header-container>.header>.name{
text-overflow: ellipsis;
white-space: nowrap;
overflow: hidden;
}

fixes the issue.
Can I submit a PR here?

@rishii7 Sure, a PR would be great. You may want to take a look at #24242 for this as well since the problems are related to this one
I believe @joaomoreno or @sandy081 should be able to review any PRs here and provide help on this issue

#24371

Fixed by #24371, thanks @rishii7 !


KubeVirt platform troubleshooting documentation

This PR adds more troubleshooting steps that are specific to the KubeVirt platform.

/retest

@bryan-cox could you give another lgtm, i updated the doc to revise a few of the cli command examples to be more accurate

/lgtm


⚠ Jenkins Plugins Artifactory has degraded performance

In 2e005f6, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1235 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 28999a8 after 40 minutes.


How to use the default admin username and password?

I am trying to get started with sails-permissions but I am unclear on how the default username and password work.
When trying to run the example in the docs using the authorization header 'Basic YWRtaW46YWRtaW4xMjM0'  (admin:admin1234)
POST /user
{
username: 'tjwebb',
email<EMAIL_ADDRESS>password: 'test123'
}
"error": "Could not authenticate user admin"
I've also tried using<EMAIL_ADDRESS>as the username.  What am I missing?
Btw I am using the sails-postgresql adapter.

Basic YWRtaW46YWRtaW4xMjM0' (admin:admin1234)

The unit tests authenticate using<EMAIL_ADDRESS>/ admin1234 and work fine. The auth header is here: https://github.com/tjwebb/sails-permissions/blob/master/test.js#L10.
Try this and let me know if you have issues.

It seems as though the default admin user was not being created in my database.  I grabbed the changes that resolved issue #28,  ran sails generate permissions-api --force, and now the authentication is working as expected.
Thanks!

Ok awesome. I'm not sure why that wasn't getting created, but I'm glad everything is working now. Let me know if you run into any other issues; thanks.


Rails 5.1 warnings

After update to rails 5.1 in my project, i'm getting a lot of warnings that i tracked down to this gem:

DEPRECATION WARNING: The behavior of changed? inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after save returned (e.g. the opposite of what it returns now). To maintain the current behavior, use saved_changes? instead.

DEPRECATION WARNING: The behavior of changed_attributes inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after save returned (e.g. the opposite of what it returns now). To maintain the current behavior, use saved_changes.transform_values(&:first) instead.

I tried to replace changed? by saved_changes? but some tests fails and it says saved_changes? method doesn't exist. #89

Well, I could remove the deprecation warnings but one spec actually fails.
Will investigate further in the next days. Suggestions welcome! 😸

Is there any update on this?

@6temes Do you still see the warnings when you use https://github.com/krautcomputing/active_record-acts_as master?

I configured the master branch in my Gemfile and I don't have any warning. 🎉
Would it be possible to create a new release with the current master?
Thanks!

I wanted to find out what causes one spec to fail with Rails 5.1 before releasing a new version: https://travis-ci.org/krautcomputing/active_record-acts_as
Just didn't have time yet... any help is appreciated of course! 😄


Idea: ".SecondSection"

I am wondering if it is possible to implement something like ".SecondSection" (instead of ".FirstSection"), for left-side navigation:
https://github.com/hbstack/docs/blob/033bfdd96b86c214b49c0c839e22b441c5c7b072/layouts/partials/hb/modules/docs/nav.html#L1
My layout is quite large :
content
  beginner-books
    book1
    book2
    ...
  expert-books
    book1
    book2
    book3

The goal is, when I click expert-books -> book3 on top level menu, to open page at http://localhost:1313/expert-books/book3, it should show chapters from book3. But right now it shows book1, book2, book3, because of .FirstSection returns expert-books content. Maybe it is easier to create such function as Hugo-core?
I am not sure how hard is it; just sharing idea, researching... thanks,

I am not sure how hard is it

It's possible, but there might be some edge case that needs to be considered (for example, how to determine if the documents belong to first/second section). I'm not very interested in this, but PR is welcome.
You can achieve this easily by separating books into the first sections.

OK, just think of a simple method to test it:

Install dev branch: hugo mod get github.com/hbstack/docs@feat-root-section
Specify docs_root_section as false on First Section, such as docs/_index.md.
Rebuild to ensure there isn't cache.

This is solution suggested by AI ;)
### **Alternative Approach: Using Custom Front Matter**

If you prefer more control, you can use custom front matter variables to explicitly define the navigation root for each page or section.

**Example:**

In your section's `_index.md` files:

```yaml
# content/book1/part1/_index.md
nav_root: true

Then, in your template, you can check for the nav_root parameter:
{{- /* Check if the current page or any ancestor has nav_root set to true */ -}}
{{- $navRoot := . -}}
{{- with .Ancestors }}
  {{- range . }}
    {{- if .Params.nav_root }}
      {{- $navRoot = . }}
    {{- end }}
  {{- end }}
{{- end }}

{{- /* Use $navRoot for navigation */ -}}
{{- $tree := partialCached "hb/modules/docs/functions/tree" . $navRoot }}

This method allows you to specify which sections should act as navigation roots, giving you flexibility beyond the second level.

Maybe this is what I need, testing now: {{ (index .Ancestors.Reverse 2).Title }} - hopefully it returns title of "/part2" if page is located in /content/book1/part2/chapter4/page1.md

I tried, feat-root-section, I didn't notice any change of functionality

Hmm, please describe it in detail? I've tested it myself before I pushed that branch.

having 400 "href" elements per webpage will make it SEO-unfriendly

Is there any related SEO advice from the official website? Such as Google itself.
BTW, I didn't follow the code you provided. If the number of links is sort of matter, then we need to reduce it in some way or just hide the navigation.

having 400 "href" elements per webpage will make it SEO-unfriendly

Is there any related SEO advice from the official website? Such as Google itself.

There are no such "official" advice. However, basic ranking algorithm for text is  TF/IDF (erm frequency-inverse document frequency), so that 400 links with non-related text may devalue main textual content of the page, etc.; Google algo may find it "keywords stuffing" and so on; yes, nice to have schema.org META in HTML it may help... but in general faster pages are more SEO-friendly, de-facto; Google advises that too and has "speed test" tool for that. For example, some of my webpages perform bad with this test on mobile devices, because DOM is too sophisticated.
This page has 795 "href" in it: https://securitiesexamsmastery.ca/14/
And all child pages have the same 795.
https://pagespeed.web.dev/analysis/https-securitiesexamsmastery-ca-14/npj7zbx3e3?form_factor=mobile

Quoting user comment from 2019 here,
"Google used to recommend that any page have no more than 100 links per page. However, they removed the "100 links per page" from the webmaster guidelines some time ago. Matt Cutts released a video where he says that the limits for page size and number of links per page are much higher than they used to be.
I've personally worked on a website with 250-400 links on every page. That site did very well in search engines."
https://webmasters.stackexchange.com/a/81171

Also, I'd like to mention that previous version of the same book https://securitiesexamsmastery.ca/14/ had 3 and even 4 levels of navigation, with same amount of pages navigation was much slower in Chrome browser, I believe because of sophisticated DOM. Now, it is only "chapter/section", two levels of navigation, and it feels 10x faster (with even more pages)

My fault; https://securitiesexamsmastery.ca/14/  "root" page is _index.md and lists 795 links; child pages are 443 links in average.

I tried, feat-root-section, I didn't notice any change of functionality

Hmm, please describe it in detail? I've tested it myself before I pushed that branch.

I'll try again; maybe I did something incorrect.

This webpage, for example, is No.1 in search results (in my Canadian area), https://www.google.com/search?q=canary+deployments+clojure&rlz=1C5CHFA_enCA950CA950&oq=canary+deployments+clojure&gs_lcrp=EgZjaHJvbWUyBggAEEUYOTIHCAEQIRigAdIBBzI2MWowajeoAgCwAgA&sourceid=chrome&ie=UTF-8
"canary deployments clojure"
https://clojurepatterns.com/9/8/2/
It has 588 "href" elements. But some other pages have around 1100+ "href", https://clojurepatterns.com/10/9/23/ for example. I think Google is smart enough. Also, it is two-level-hierarchy with navigation. I am going to make repo public for this site too.

I tried again hugo mod get github.com/hbstack/docs@feat-root-section and I noticed it doesn't modify go.mod or module.yaml - not sure how it works

ok, it looks like installed correct module,
<EMAIL_ADDRESS><EMAIL_ADDRESS>

I think I confused everyone...
I have this layout currently:
content
    book1
    book2
    book3

Homepage will show book1, book2, book3. When I click "book1", it will show only content of "book1" (which is 2nd level from "root"). And what I suggested is to have functionality for 3rd level. Maybe that's why I cannot test github.com/hbstack/docs@feat-root-section - because 2-nd level already works, as for example on this https://clojureforjava.com/ site.
"book1/_index.md" has `type: docs" in it. See https://github.com/MasteryEducation/SecuritiesExamsMastery.ca/tree/main/content for example, I have two "books" on it, https://securitiesexamsmastery.ca/

I forgot that I override list.html here... after deleting this file it works!!! I override "list.html" because I wanted _index.md to show some content; but I don't need it anymore
Thank you @razonyang

@FuadEfendi So that branch is working right? If so, I'll merge it later.


Add helper to detect nested control-flow writes to variables

Summary
This helper function is intended for use during the DAGCircuit
construction in the near term, where it will need to distinguish whether
a control-flow operation reads or writes a variable.
This is not an efficient operation on the QuantumCircuit tree
representation, and in general is something that should instead be
calculated by data-flow analysis (or similar) on a graph-based
representation of the program, or cached.  However, DAGCircuit
currently does not represent control-flow well enough to do anything
like this across the circuit, so the helper method is necessary in the
short term, despite the effective quadratic complexity on the
control-flow depth of a circuit during complete recursive conversion of
blocks to DAGCircuits.
Details and comments
Depends on #10974
Close #10940.
It might be preferable to store the number of writes to variables within QuantumCircuit, but the only way to reliably keep this number up-to-date is to add an extra check within QuantumCircuit._append, and I'm wary of affecting the performance of that inner-loop function for a feature that most circuits will not use.  DAGCircuit is already very inefficient with regards to classical handling at the moment and needs a more complete rework, so this feels like a reasonable compromise; performance is poorer than it could be for control-flow ops in DAGCircuit (it's already poor), but circuits that don't use it aren't affected.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

273 of 297 (91.92%)  changed or added relevant lines in 18 files are covered.
16 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.01%) to 87.026%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/circuit/classical/types/ordering.py
18
19
94.74%

qiskit/circuit/controlflow/_builder_utils.py
3
4
75.0%

qiskit/circuit/controlflow/builder.py
0
1
0.0%

qiskit/circuit/controlflow/for_loop.py
5
6
83.33%

qiskit/circuit/controlflow/if_else.py
5
6
83.33%

qiskit/circuit/controlflow/switch_case.py
4
5
80.0%

qiskit/circuit/controlflow/while_loop.py
4
5
80.0%

qiskit/circuit/classical/expr/constructors.py
5
7
71.43%

qiskit/circuit/store.py
33
35
94.29%

qiskit/circuit/controlflow/control_flow.py
35
38
92.11%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
4
91.67%

crates/qasm2/src/parse.rs
12
96.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
74373

Relevant Lines:
85461

💛  - Coveralls

This will be rewritten in other forms.  Closing.


Increase Gradle max retries and backoff

See https://github.com/aspnet/AspNetCore-Internal/issues/2052 and https://github.com/gradle/gradle/commit/156b5ebd00971cc7fd6bd94420f0fa63b5488e8d for some context here.
Gradle is timing out in some of our builds. It has retries but they seem to be insufficient for our needs. However, there are internal Gradle properties that allow this to be controlled. We should increase the number of retries and possibly the backoff as well to make our build more reliable.

org.gradle.internal.repository.max.retries (default 3) is the number
of retries (initial included)
org.gradle.internal.repository.initial.backoff is the initial time
before retrying, in milliseconds (default 125)

Helpful note from AzDo docs actually

How do I fix timeouts when downloading dependencies?
To fix errors such as Read timed out when downloading dependencies, users of Gradle 4.3+ can change the timeout by adding to Options -Dhttp.socketTimeout=60000 -Dhttp.connectionTimeout=60000. This increases the timeout from 10 seconds to 1 minute.

Awesome!

So after some investigation through github issues and old prs and scanning release tags, the version of gradle we use does not have retries. So I'll work on upgrading the version of gradle we use to take advantage of the new feature.

This is blocking some builds fairly frequently. Can you make this your top priority @mikaelm12 ?


AttributeError: MitmChannelBased instance has no attribute 'run'

After running command:
sudo ./krack_all_zero_tk.py wlan0 wlan1 eth0 "xxx" -t xx:xx:xx:xx:xx:xx
I get this error:
`WARNING: Failed to execute tcpdump. Check it is installed and in the PATH
===[ KRACK Attacks against Linux/Android by Lucas Woody ]===

Traceback (most recent call last):
File "./krack_all_zero_tk.py", line 593, in
attack.run(strict_echo_test=args.strict_echo_test)
File "./krack_all_zero_tk.py", line 513, in run
self.mitmconfig.run()
AttributeError: MitmChannelBased instance has no attribute 'run'
[23:15:48] Closing hostapd and cleaning up ...`

After running command:
sudo ./krack_all_zero_tk.py wlan0 wlan1 eth0 "xxx" -t xx:xx:xx:xx:xx:xx
I get this error:
`WARNING: Failed to execute tcpdump. Check it is installed and in the PATH
===[ KRACK Attacks against Linux/Android by Lucas Woody ]===

Traceback (most recent call last):
File "./krack_all_zero_tk.py", line 593, in
attack.run(strict_echo_test=args.strict_echo_test)
File "./krack_all_zero_tk.py", line 513, in run
self.mitmconfig.run()
AttributeError: MitmChannelBased instance has no attribute 'run'
[23:15:48] Closing hostapd and cleaning up ...`

Did you install tcpdump?

hello @Real96 , @taleen98 ,Did u solve the error posted by @KanG00 . I am getting same error. Could you help me.
@lucascouto .Hello luca,please help

hello @Real96 , @taleen98 ,Did u solve the error posted by @KanG00 . I am getting same error. Could you help me.
@lucascouto .Hello luca,please help

Did you install tcpdump?

@Real96. thank you for ur instant reply. yes I have installed tcpdump. I am a PhD student working on Channel MitM and experiment KRACK attacks.because of these errors, i cannot move forward. could you send me an email to me<EMAIL_ADDRESS> Hoping ur email.

@Real96. thank you for ur instant reply. yes I have installed tcpdump. I am a PhD student working on Channel MitM and experiment KRACK attacks.because of these errors, i cannot move forward. could you send me an email to me<EMAIL_ADDRESS>Hoping ur email.

I did the attack one year ago and to make it work i had to downgrade Scapy version to 2.3.3. This was the only problem i was getting. I never got the tcpdump problem, but as the error says, you should have tcpdump installed and also in the path. Also i don't think it is so much necessary, tcpdump is needed to dump the packets, i think you can just use wireshark or something else

@Real96 .Thank u so much. ok. Should I check path of tcpdump? My scapy version is 2.4.2. Should I try downgrade? by the by.million thank that you considered my error. I have just followed u on twitter, could u foloow me back, so that I can discuss some of my doubts. with hope....

@Real96 .Thank u so much. ok. Should I check path of tcpdump? My scapy version is 2.4.2. Should I try downgrade? by the by.million thank that you considered my error. I have just followed u on twitter, could u foloow me back, so that I can discuss some of my doubts. with hope....

I wrote you there!

Downgrade Scapy and it should work.

Downgrade Scapy and it should work.

Yeah, 2.3.3 made it work for me

@nolsie, thank you for responding. I have contacted @Real96 . He gave me instructions. I am working on it.once solved .I will post here. Thanks again.


Unbound analysis for show statements

Summary of the changes / Why this improves CrateDB
Checklist

[x] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Retest this please
Running: Test class org.elasticsearch.cluster.coordination.ReconfiguratorTests
After 20s process did not stop


Add documentation regarding testing

Following discussion #672, we should add details in the documentation about how you can properly override the user dependency during testing.

Is this the same as https://fastapi-users.github.io/fastapi-users/cookbook/create-user-programmatically/?

@luisroel91 No, it will be slightly different.
The goal is to add some guidance to properly write unit tests with FastAPI Users, especially how to use the dependency_overrides mechanism of FastAPI to "mock" the current_user dependency.
I've added some insights here: https://github.com/fastapi-users/fastapi-users/discussions/830#discussioncomment-1874201

@frankie567 added pr to show the example of testing fastapi-users


navigateAfterFuture

navigateAfterFuture doesn't exists

You are right @sopedro. This feature was removed since 1b26aac002bf97bc67b0955fcf93c7e9b64ba6d0 commit. I asked to @KarimMohamed2005 to review this commit because the code was removed by mistake (git merge without pull).

Temporary solution:
  splashscreen:     git:       url: https://github.com/KarimMohamed2005/SplashScreenFlutterPackage.git       ref: f8c1ae4f88258bbf33f4c71d1e7bed089da0d65f

Has anyone tried implementing this with bloc pattern? By the way, the code was not fixed yet for navigateAfterFuture.

Any news on this?

hi @IoanaAlexandru , you can try using this. It's basically the same with this repo, just having the navigateAfterFuture added back.

Hello guys,
Karim was so busy these days and he even archived the repo, but he unarchived it today, this repo will be active starting from now.
This issue has been solved now and will be pushed to the pub.dev package 2 hours from now
Thank you


lmql server  threading error

When I run lmql serve-model tiiuae/falcon-7b-instruct
I get the following error
Exception in thread scheduler-worker:
Traceback (most recent call last):
File "/opt/homebrew/anaconda3/envs/llm/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
self.run()
File "/opt/homebrew/anaconda3/envs/llm/lib/python3.10/threading.py", line 953, in run
self._target(*self._args, **self._kwargs)
File "/opt/homebrew/anaconda3/envs/llm/lib/python3.10/site-packages/lmql/models/lmtp/lmtp_scheduler.py", line 247, in worker
model = LMTPModel.load(self.model_identifier, **self.model_args)
File "/opt/homebrew/anaconda3/envs/llm/lib/python3.10/site-packages/lmql/models/lmtp/backends/lmtp_model.py", line 51, in load
return LMTPModel.registry["transformers"](model_name, **kwargs)
File "/opt/homebrew/anaconda3/envs/llm/lib/python3.10/site-packages/lmql/models/lmtp/backends/transformers_model.py", line 18, in init
self.model = AutoModelForCausalLM.from_pretrained(self.model_identifier, **self.model_args)
File "/opt/homebrew/anaconda3/envs/llm/lib/python3.10/site-packages/transformers/models/auto/auto_factory.py", line 461, in from_pretrained
config, kwargs = AutoConfig.from_pretrained(
File "/opt/homebrew/anaconda3/envs/llm/lib/python3.10/site-packages/transformers/models/auto/configuration_auto.py", line 986, in from_pretrained
trust_remote_code = resolve_trust_remote_code(
File "/opt/homebrew/anaconda3/envs/llm/lib/python3.10/site-packages/transformers/dynamic_module_utils.py", line 535, in resolve_trust_remote_code
signal.signal(signal.SIGALRM, _raise_timeout_error)
File "/opt/homebrew/anaconda3/envs/llm/lib/python3.10/signal.py", line 56, in signal
handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
ValueError: signal only works in main thread of the main interpreter
Looks like the signal for model load is sent from the child thread.
Python 3.10.11 running in conda env.

Falcon does not support running in a background thread. To run in in the main thread, try running the serve-model command with --single_thread. This may have an effect on overall latency.

@lbeurerkellner Could you expound on why Falcon doesn't support running in a background thread? Any links to references or such?
I've faced endless turmoil getting Falcon to play nicely with LMQL, but, it's got the only license I can work with for a certain gig.


Feature/onetouch --- Add IP Address

Add IP address showing in the LauncherFragment. The IP address will be checked every time when starting the server.

Thanks @Zeshengx, I refactored this PR into #14 to remove the extraneous .DS_Store files and the changes to the .iml files, which were just autogenerated changes by Android Studio.
I also changed the update to occur when the fragment was loaded, so it will show an IP even before the server is started, as long as wifi is enabled.


chore(deps): bump i18next libraries

i18next: ^10.6.0 => ^21.6.16
i18next-browser-languagedetector: ^2.1.1 => ^6.1.4
<EMAIL_ADDRESS>=><EMAIL_ADDRESS>react-i18next": ^9.0.3 => ^11.16.7

High Level Overview of Change

translate was changed to withTranslation
useTranslation hook was added

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

lgtm, assuming you checked to make sure the translations were actually working

If I re-enable the picker it works great.


Clarify ssh ForwardAgent instructions

@millerdev

👍 I was just re-reading that and thinking it should be re-worded. thanks.

Actually, it could also use something along the lines of "ansible uses your local ssh key to authenticate via a mechanism called ForwardAgent", I'll offline


Specify system emoji fonts for emoji code-points

Mac OSX & Ubuntu in particular have bugs relating to the proper display of emojis in browsers. Explicitly specifying locally-installed system emoji fonts as fall-backs at the end of the font stack fixes the issue! 🤷
Documented here: https://www.client9.com/css-color-emoji-stack/

A big thank you @barneycarroll


anki: 2.1.11 -> 2.1.14

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build anki

Fails to rebuild on darwin:
/private/tmp/nix-build-qtwebengine-5.11.3.drv-0/qtwebengine-everywhere-src-5.11.3/src/3rdparty/chromium/base/mac/sdk_forward_declarations.h:51:3: error: redefinition of enumerator 'NSSpringLoadingHighlightEmphasized'
  NSSpringLoadingHighlightEmphasized```

Seems unrelated, that platform has been broken since #50379. It was merged regardless for some reason.

@NixOS/darwin-maintainers do you mind having a look? If it is failing and we cannot fix it, we must exclude it.

Cool, thanks.


Support for epwalsh/obsidian.nvim

Feature Description
I do not believe epwalsh/obsidian.nvim currently works with blink.cmp. I am not sure if this feature request should be made in this project or in obsidian.nvim, but please let me know if support for this plugin is planned.

Ayy a fellow Canadian! This should be made in the obsidian.nvim repo although you may be able to get it working with https://github.com/saghen/blink.compat


Getting Width and Height of Image

I have a question.
How can I get width and height of image that I get from TakePhotoAsync or PickPhotoAsync?
Thanks.

@prashantvc TakePhotoAsync or PickPhotoAsync have SaveMetaData property. It means that I can get metadata? Please give me your opinion. Thanks!


Moduleize

@leeacto @jonhoman
Nests objects into the MokiRuby module, requires them all so the library works

+1 LGTM


v1.18.1 Alt+F S no longer a single action in Chinese Language("locale":"zh-CN")

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:32:36.023Z)
OS Version: Windows_NT x64 10.0.16299
Extensions:

Extension
Author (truncated)
Version

vscode-great-icons
emm
2.1.20

cpptools
ms-
0.14.2

Steps to Reproduce:

Set language to "ZH-CN" (Chinese)
Alt + F, S the Save(S) it still clash with Save To Workspace
Note: English language ("en-US") is not clash now.

Reproduces without extensions: Yes/No

Ah this is about chinese, I guess we need to wait for the localization to drop in.