parse error using go1.8beta1

I'm running:
go version devel +8fa2344 Sat Jan 7 06:37:46 2017 +0000 darwin/amd64

go-torch and FlameGraph are at:
$ pwd
/Users/bmizerany/src/github.com/uber/go-torch
$ git rev-parse HEAD
5decf9ecdab5dd3375e1e8d2872351548a7be450
$ cd FlameGraph/
/Users/bmizerany/src/github.com/uber/go-torch/FlameGraph
$ pwd
/Users/bmizerany/src/github.com/uber/go-torch/FlameGraph
$ git rev-parse HEAD
ef645645a3fe814f155e3b6bb6446d1c10c7c2e1

I ran a benchmark and then go-torch like:
$ go test -run=none -bench=HTTP -memprofile=mem.prof
$ go-torch -alloc_space server.test mem.prof

and got the error:
INFO[13:16:41] Run pprof command: go tool pprof -raw -seconds 30 -alloc_space server.test mem.prof
FATA[13:16:41] Failed: could not parse raw pprof output: strconv.ParseInt: parsing "0:": invalid syntax

I get the same error with -alloc_objects

Thanks for the report @bmizerany
The parser was initially created for CPU profiles, so it assumed the raw profile output contained 2 columns of output. The memory profile also happened to have 2 columns so it worked fine, but 1.8 adds more columns, breaking the parser.
I'll clean up the parser to parse all columns correctly.

Ah makes sense. Thank you! I love this tool.
On Mon, Jan 9, 2017 at 11:17 PM Prashant Varanasi<EMAIL_ADDRESS>wrote:

Thanks for the report @bmizerany https://github.com/bmizerany
The parser was initially created for CPU profiles, so it assumed the raw
profile output contained 2 columns of output. The memory profile also
happened to have 2 columns so it worked fine, but 1.8 adds more columns,
breaking the parser.
I'll clean up the parser to parse all columns correctly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/uber/go-torch/issues/51#issuecomment-271503447, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAALiPrgfJCSOJipzQea4j8JIRfLt6iks5rQzB0gaJpZM4Ldzhb
.

This is still happening for me with go1.8. I haven't been able to get it working since this fix. Any ideas?

@bmizerany Are you sure you're using the latest version of go-torch?
I'm able to use CPU and memory profiles from go1.8 RC3 fine:
$ go version
go version go1.8rc3 darwin/amd64

$ go test -bench . -cpuprofile prof.cpu -memprofile prof.mem
BenchmarkStdUint64-8   	200000000	         9.81 ns/op
BenchmarkUint64-8      	100000000	        13.9 ns/op
PASS
ok  	github.com/uber-go/atomic	4.378s

$ go-torch atomic.test prof.cpu
INFO[23:37:43] Run pprof command: go tool pprof -raw -seconds 30 atomic.test prof.cpu
INFO[23:37:43] Writing svg to torch.svg

$ go-torch atomic.test prof.mem
INFO[23:38:00] Run pprof command: go tool pprof -raw -seconds 30 atomic.test prof.mem
INFO[23:38:00] Writing svg to torch.svg

Unfortunately go-torch doesn't have a --version (Filed #57 since we really should have versions), but you can make sure you have the latest using go get -u -f github.com/uber/go-torch

@prashantv I tried what you suggested but am still getting:
$ go get -u -f github.com/uber/go-torch
$ go-torch -alloc_space server.test mem.prof
INFO[06:00:45] Run pprof command: go tool pprof -raw -seconds 30 -alloc_space server.test mem.prof
FATA[06:00:45] Failed: could not parse raw pprof output: strconv.ParseInt: parsing "0:": invalid syntax
$ cd ~/go/src/github.com/uber/go-torch/
$ git rev-parse HEAD
a4daa2b9d2816627365ca5a4e8cfcd5186ac3659
$ uname -a
Darwin Blakes-MacBook-Pro-2.local 15.6.0 Darwin Kernel Version 15.6.0: Thu Jun 23 18:25:34 PDT 2016; root:xnu-3248.60.10~1/RELEASE_X86_64 x86_64
$ go version
go version devel +bd56169 Wed Feb 8 16:20:25 2017 +0000 darwin/amd64
$

Please let me know if there is more info I can send you.

Can you do which go-torch to confirm it's using one built by the go tool.
The revision in ~/go/src/github.com/uber/go-torch looks right, so can you cd in, build a binary there, and see if that binary works for parsing the output.
$ cd ~/go/src/github.com/uber/go-torch
$ go build .
$ ./go-torch -alloc_space [...]

I'm also running on a mac, but I'm using the latest Go 1.8 RC.

Argh. The move to the new standard $HOME/go from $HOME keeps haunting me. I was using an old binary. It works now. My bad.

No worries, glad it's working!


[in_app_purchase] does not support passing ObfuscatedProfileId to BillingFlowParams

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
It is known that by setting applicationUserName in PurchaseParams, it will eventually be passed to the BillingFlowParams.setObfuscatedAccountId() method. In reality, BillingFlowParams has another method setObfuscatedProfileId() to set developer information, but currently it cannot be passed. It is hoped that the official team can support this setting.
Proposal
final BillingResultWrapper billingResultWrapper =
await billingClientManager.runWithClient(
(BillingClient client) => client.launchBillingFlow(
product: purchaseParam.productDetails.id,
offerToken: offerToken,
accountId: purchaseParam.applicationUserName,
oldProduct: changeSubscriptionParam?.oldPurchaseDetails.productID,
purchaseToken: changeSubscriptionParam
?.oldPurchaseDetails.verificationData.serverVerificationData,
prorationMode: changeSubscriptionParam?.prorationMode),
);
return billingResultWrapper.responseCode == BillingResponse.ok;
}

Thanks for the proposal. I can see obfuscatedProfileId in launchBillingFlow here but it's missing in the caller (reference to this)

@mariamhas Consider this when looking at ways to improve billing support.

Is there any new progress

It's been three months, any plans for a fix?


Conflicts with name generation

With many of the same thing and relying on name generation there can be name conflicts. When this happens the call fails which causes issues with things like terraform.
Rancher should rely on k8s to gen a name instead of doing it internally.

rancher/rancher:master 636311443
There's not really a good way to test this one at scale from the QA side, so tests focused around ensuring resource names continue to be generated correctly. This was originally only reproduced a few times w/ cluster names when the number of clusters was high (~2000).

Created several clusters
Cluster names continue to be randomly generated and in the correct format c-hkm48
Other resource names are in correct formats: user-xhqb6, p-jv2cm
Automation passes without unusual failures


fix: GatewayLdkClient::info() doesn't rely on timestamps

Fixes #5965

Reverted with https://github.com/fedimint/fedimint/pull/6217, going to investigate flakiness


Demo got stuck when emitting amount of shapes in tiny size at one

The system seems to be unstable when deal with very tiny shapes. Tested on the latest master branch.
Steps to Reproduct

change the Shoot method to produce tiny shapes:

    Random rand = new(123);
    public void ShootPrimitive()
    {
        const float primitiveVelocity = 20.0f;

        var pos = Camera.Position;
        var dir = Camera.Direction;

        var sb = World.CreateRigidBody();
        sb.Position = Conversion.ToJitterVector(pos);
        sb.Velocity = Conversion.ToJitterVector(dir * primitiveVelocity);

        //var ss = new BoxShape(0.3f);
        var ss = new BoxShape(rand.Next(1, 4) / 1000f);
        sb.AddShape(ss);
    }

change the Control method to shoot a alot at once:

    for (global::System.Int32 i = 0; i < 10; i++)
    {
        ShootPrimitive();
    }

Run the demo and press space.

Additionally, there is another issue, may be a same problem as described below:
I continuously spawning tiny size shapes, meanwhile, I remove the rigidbody in world randomly. Soon got a exception says Shapes passed to default narrow phase collision handler are not associated with a rigid body
System.InvalidOperationException
  HResult=0x80131509
  Message=Shapes passed to default narrow phase collision handler are not associated with a rigid body.
  Source=Jitter2
  StackTrace:
   at Jitter2.World.Detect(Shape sA, Shape sB) in E:\UnityProjects\jitterphysics2-deterministic-ecs-edition\src\Jitter2\World.Detect.cs:line 289
   at Jitter2.World.DetectCollisionsCallback(Batch batch) in E:\UnityProjects\jitterphysics2-deterministic-ecs-edition\src\Jitter2\World.Step.cs:line 451
   at Jitter2.World.DetectCollisions(Boolean multiThread) in E:\UnityProjects\jitterphysics2-deterministic-ecs-edition\src\Jitter2\World.Step.cs:line 764
   at Jitter2.World.Step(Single dt, Boolean multiThread) in E:\UnityProjects\jitterphysics2-deterministic-ecs-edition\src\Jitter2\World.Step.cs:line 144
   at JitterDemo.Playground.Draw() in E:\UnityProjects\jitterphysics2-deterministic-ecs-edition\src\JitterDemo\Playground.cs:line 127
   at JitterDemo.Renderer.OpenGL.GLFWWindow.Sync() in E:\UnityProjects\jitterphysics2-deterministic-ecs-edition\src\JitterDemo\Renderer\OpenGL\GLFWWindow.cs:line 291
   at JitterDemo.Renderer.OpenGL.GLFWWindow.Open(CreationSettings settings) in E:\UnityProjects\jitterphysics2-deterministic-ecs-edition\src\JitterDemo\Renderer\OpenGL\GLFWWindow.cs:line 179
   at JitterDemo.Program.Main() in E:\UnityProjects\jitterphysics2-deterministic-ecs-edition\src\JitterDemo\Program.cs:line 25

Maybe it'a problem caused by DynamicTree.
I want to known why the tiny shapes so different, and how to solve the problems

@labbbirder : Thanks for the report! Just to keep things sorted:  Can you just open a separate issue for the "Shapes passed to default narrow phase collision handler are not associated with a rigid body"-problem? Another user also reported this and I was not able to reproduce it, yet.


add callback or not to bedrockServer.executeCommand

Thanks for your contribution
by the way, the parameter name is not intuitive. callback means the function being called. I guess mute or suppress would be better.
and the comment does not explain the code. It seems to be hindering understanding of the code afterward.

Oh okay!

Ignoring all errors is a pretty bad design.

Umm... I'll find another way

Umm... I'll find another way


Example doesn't work anymore

Hi @danvick,
Apparently, the example at example/lib/main.dart doesn't work anymore.
There are a lot of print messages and the values are not correctly saved in the GlobalKey (even after save() and validate()).
I experienced the same behavior in another project.
Could you please check ?
Thanks a lot

Hi,
Same behavior on my side: the values map are empty from globalKey.currentState.value (even after save() and validate()).
I've upgraded the Flutter version to 1.7.8, seems related ?
/opt/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, v1.7.8+hotfix.3, on Mac OS X 10.14.5 18F132, locale en-GB)
    • Flutter version 1.7.8+hotfix.3 at /opt/flutter
    • Framework revision b712a172f9 (13 days ago), 2019-07-09 13:14:38 -0700
    • Engine revision 54ad777fd2
    • Dart version 2.4.0

Thanks.

Hi,
Which version of the package are you using?

This issue will be closed due to inactivity


Rename corrupts files

I've found that if I rename a file while another file is open, any new data that I try to write to the open file is instead written to the renamed file.
Here is a test case that triggers the bug:
echo "--- Rename test ---"
scripts/test.py << TEST

    lfs_size_t size;

    lfs_format(&lfs, &cfg) => 0;
    lfs_mount(&lfs, &cfg) => 0;

    // open a log file, write something, then close it
    lfs_file_open(&lfs, &file, "log_0", LFS_O_CREAT | LFS_O_WRONLY) => 0;
    lfs_file_write(&lfs, &file, "0000000000", 10) => 10;
    lfs_file_close(&lfs, &file) => 0;

    // open test file
    lfs_file_open(&lfs, &file, "test", LFS_O_CREAT | LFS_O_WRONLY) => 0;

    // write to test file
    lfs_file_write(&lfs, &file, "1111111111", 10) => 10;
    lfs_file_sync(&lfs, &file) => 0;

    // rename log file
    lfs_rename(&lfs, "log_0", "log_1") => 0;

    // write to test file
    lfs_file_write(&lfs, &file, "2222222222", 10) => 10;
    lfs_file_sync(&lfs, &file) => 0;

    // close test file
    lfs_file_close(&lfs, &file) => 0;

    // check log file contents
    lfs_file_open(&lfs, &file, "log_1", LFS_O_RDONLY) => 0;
    size = lfs_file_read(&lfs, &file, buffer, sizeof(buffer) - 1);
    buffer[size] = 0;
    printf("%s\n", buffer);
    test_assert(size, 10);
    strcmp((const char*)buffer, "0000000000") => 0;

    // check test file contents
    lfs_file_open(&lfs, &file, "test", LFS_O_RDONLY) => 0;
    size = lfs_file_read(&lfs, &file, buffer, sizeof(buffer) - 1);
    buffer[size] = 0;
    printf("%s\n", buffer);
    test_assert(size, 20);
    strcmp((const char*)buffer, "11111111112222222222") => 0;

TEST

I'm sorry, i didn't see any error in you code.

When I add the test case to test_files.sh and run make test_files, this is the output:
$ make test_files
./tests/test_files.sh
=== File tests ===
--- Rename test ---
11111111112222222222
./tests/test_files.sh:48: assert failed with 20, expected 10
    size => 10

The test case writes "0000000000" to "/log_0", then renames it to "/log_1", but reading the file after the rename gives "11111111112222222222".
I have run the test in both WSL x64 and a Fedora x64 virtual machine, and I get the same result.

I think even if you don't rename the file "log_0", the result is still "11111111112222222222". After you first write "1111111111" to the file "test", the pos of file will move to the end of file. Then you continue write "2222222222" to  the same file. The result will do become "11111111112222222222" . you need to use lfs_file_seek(... ,0,LFS_SEEK_SET).

Right, but the problem is the contents of "log_1" is "11111111112222222222", when it should be "0000000000".

Yes，it is! I try it just now. But i think this woud be a illegal operation. User known how to avoid if. lfs_rename don't need open the file.

I ran my test case with the v2.2 release and it passed, so I'm closing this issue.


App crash while saving/loading configs

this, and few types of other errors, are causing app crashes. skin changer is one of the problem.

Are you using the latest version? This was supposed to be fixed in a6e9d084c5eae3b8430f72050e3b2c92b9e8c254

@danielkrupinski yes i am using the latest version.

Press "Retry" and show callstack.

With the Steam version only.

@danielkrupinski  do we need to use vac by pass with osiris as well?


Fully automate dev setup with Gitpod

This commit implements a fully-automated development setup using Gitpod.io, an
online IDE for GitLab, GitHub, and Bitbucket that enables Dev-Environments-As-Code.
This makes it easy for anyone to get a ready-to-code workspace for any branch,
issue or pull request almost instantly with a single click.

@jeffersonparke Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Accidental pull request.


[Feature Request]: Replace 4:3 black bars with custom bezel

Describe the feature you'd like to see added
Lambada brought up the idea in the discord, so I'm reposting it here. I'm guessing this would be done by drawing the texture over the game, but would that cause issues with alt-tabbing or losing window focus? Is there a better way?

Thank you @Tenome for creating this issue here.
I all attach here the bezels that I have created so far. This way this feature can be beta tested with it.
The first bezel is in 4K:

The second bezel is in 1080p:

I also created two more variants that are transparent. This way this feature could be very customizable, for example:
Add a transparent bezel and select the color behind it, if set the HEX RGB code for RED #d32829 the color would affect the transparent bezel.
Example:

Bezel in 4k but transparent:

Bezel in 1080p but transparent:

Another sample applied to the intro movie:

I love the red one.


Enhance Codec's decoding options

Problem
Currently, Decode allows decoding only the entire axis. It requires a 2D bytes slice as input and reconstructs nil shares via non-nil ones. However, we now need an additional use case where we want to reconstruct only particular nil shares and not all of them. This optimization is a part of lazy-extend effort and avoids unnecessary share reconstruction for Codec
Solutions

change the Decode slice share inputs to have three states: built, nil, and empty(zero-length). The new empty share slices will signal to Codec that they need to be reconstructed by the provided built, while nil shares will be left untouched.

Less explicit and needs to be properly documented

add a new DecodeSome method that takes the same shares slice as input + an additional slice of bools with the same line as the shares slice, following klauspost's ReconstructSome method.

Allocates additional slice
Two code paths for lazy and non-lazy decoding that can be single.

Refs
Blocked on https://github.com/klauspost/reedsolomon/issues/264

I prefer the second proposed solution because it is API additive.


[iOS] updateMetadataForTrack fix

The fix change "withProperties" method name to "properties" method name, which is the right instance.

Thanks for this fix @holospeed <3


fix: loosened web3 version requirement to allow testing v6

Can this one be fixed?
I use uvicorn 0.15.0 because later versions have websockets version that is newer than max version required by uniswap-python.
I can not use python 3.11 because uvicorn 0.15 has httptools 0.2.x dependency which can not be build on 3.11.
:exploding_head:

@lsnk There you go, making a new version now.


Fix: babel runtime

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #1   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      6    +1
  Lines          78     56   -22
  Branches       12     10    -2
=====================================
- Hits           78     56   -22

Impacted Files
Coverage Δ

src/modules/convert-csv-to-array-of-arrays.js
100% <ø> (ø)
:arrow_up:

src/helpers/check-if-valid.js
100% <0%> (ø)
:arrow_up:

src/modules/convert-csv-to-array-of-objects.js
100% <0%> (ø)
:arrow_up:

src/index.js
100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f03e40...6f25d85. Read the comment docs.


Clamp durability bar

Prevents there from being an absurdly long durability bar as in

when batteries are stacked.

..wait, it seems 1 is the wrong number to clamp.

Dividing the durability bar by stack size is a better solution.

Thanks for the PR, but this actually brought to my attention a small inconsistency in the FTL Energy API regarding stacked energy containing items which should be sorted out when https://github.com/TechReborn/Energy/pull/9 is merged. I'll close this for now and wait for the PR.


[fix] bug where v1alpha1/2 linodecluster webhooks have same auto-generated name

What this PR does / why we need it:
After bumping to use v1alpha2 LinodeClusters in a capi project, I cannot apply the config/webhooks directory via kustomize+tilt as both the v1alpha1 and v1alpha2 LinodeCluster webhooks are named vlinodecluster.kb.io (error below). This is due to a (potential) typo in the //+kubebuilder:webhook:.... auto-generation comments for all custom resources: vlinodemachine.kb.io, vlinodevpc.kb.io, vlinodecluster.kb.io, and vlinodeobjectstoragebucket.kb.io. LinodeClusters are the first custom resource to introduce a new api version which is why the issue is only seen for those webhooks.
Build Failed: ValidatingWebhookConfiguration.admissionregistration.k8s.io "capi-validating-webhook-configuration" is invalid: webhooks[1].name: Duplicate value: "vlinodecluster.kb.io"

This PR:

updates to use capi naming convention for webhooks
updates admissionReviewVersions for all webhooks to include their appropriate versions
fixes the bug where the v1alpha1 and v1alpha2 LinodeCluster webhooks have the same auto-generated name

These changes were originally introduced in a separate PR, https://github.com/linode/cluster-api-provider-linode/pull/385, which was closed in favor of this one. I am linking it as there is important context relating to the changes.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
TODOs:

[x] squashed commits
[ ] includes documentation
[ ] adds unit tests
[ ] adds or updates e2e tests

@AshleyDumaine sorry for the double ping, this PR replaces https://github.com/linode/cluster-api-provider-linode/pull/385. Let me know if these changes match up with what you are thinking


Appending an accessor throws an error

If in a model I use protected $appends to add say a computed field like full_address then you will get
Undefined offset: 0 {"exception":"[object] (ErrorException(code: 0): Undefined offset: 0 at .../vendor/yab/laravel-scout-mysql-driver/src/Services/ModelService.php:44)
Will submit a simple PR that will fix this now

Fixes applied in v2.0.1


Icon is missing

Operating system: Windows 10
Messenger for Desktop version: 2.0.6

I upgraded to 2.0.6 and the icon in my taskbar is missing. I tried reinstalling and it's still missing.

Can you try to unpin it and then pin it again?

If you uninstall 2.0.6 and then install 2.0.4 (https://github.com/aluxian/Messenger-for-Desktop/releases/tag/v2.0.4), does the icon come back?

Duplicate, will be tracked here: https://github.com/aluxian/Messenger-for-Desktop/issues/1206


Update Autoware.Auto's documents for autoware.universe

Currently, Autoware.Auto's documents are written for Autoware.Auto (of course) and GitLab.
However, since autoware.universe has different architecture and uses GitHub, the documents should be updated.

As @IshitaTakeshi says here, we need some tutorial documents.
https://github.com/autowarefoundation/autoware.universe/issues/204#issuecomment-1012027433

I think this can be closed because minimal documents were created.


⚠ Bofrost.be has degraded performance

In 212fc64, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1541 ms

Resolved: Bofrost.be performance has improved in bab3486 after 7 minutes.


Added ARIA attributes

Gets the Aria label from the input element and adds it to the "label" automatically.
If an Aria label is set: Checkboxes can be toggled using the 'space bar' and navigated using 'tab'.
if no Aria label is set, then it defaults to the normal setup.

Let me thank you a lot for this PR.
It seems to be working but I will take a look today in your request.
Thank you in advance, again.
Could you please stash all commits ?

You should be able to squash on merge - instead of me changing my branch :)
https://help.github.com/articles/about-pull-request-merge-squashing/

Thank you !


dynamic import within Island components with useEffect

I was trying to include Monaco editor and related tree-sitter libraries into Fresh pages. Here's my codes:
// Initialize the editor, run CSR-only after the DOM is loaded.

import { useEffect } from "preact/hooks";

// tree-sitter-related JSON configurations.

export default function Init() {

    useEffect(() => {
        (async ()=>{
            // TODO: Should be enabled in the future.
            // const {initEditor} = await import("../static/editor.js");
            // initEditor();

            console.log("Initializing the editor")

            // Import Monaco editor.
            const monaco = await<EMAIL_ADDRESS>
            // // Import tree-sitter-related libraries.
            // const treeSitterCppResponse = await fetch("/assets/tree-sitter-cpp.wasm")
            // const treeSitterCpp = await WebAssembly.instantiateStreaming(
            //     treeSitterCppResponse,
            //     {}
            // );
            // const Parser = await<EMAIL_ADDRESS>            // const {Theme, Language, MonacoTreeSitter} = await<EMAIL_ADDRESS>            // const cppGrammarResponse = await fetch("../static/assets/tree-sitter-grammar/cpp.json")
            // const cppGrammar = cppGrammarResponse.json()
            // const themeResponse = await fetch("../static/assets/tree-sitter-theme/tomorrow.json")
            // const theme = await themeResponse.json()

            // // Initialize the tree-sitter libraries.
            // Theme.load(theme);
            // console.log("Here is the structure of Parser:");
            // console.log(Parser);
            // // await Parser.default.init()
            // // const language = new Language(cppGrammar)

            // (globalThis as typeof globalThis & {monaco: typeof monaco})
            //     .monaco = monaco;
        })();
    }, [])

    return <></>
}

The most codes have been commented for the following errors, but the codes above still causes the errors (as well as warnings):
▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/monaco-editor.mjs:668:60979:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,Yt(g=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/monaco-editor.mjs:668:60950:
      668 │ ...|(u=g0e(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/monaco-editor.mjs:668:61015:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,Yt(g=>{r(u,g),this._lastDiff=u;let m=ek.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/monaco-editor.mjs:668:60986:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,Yt(g=>{r(u,g),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/freemarker2/freemarker2.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/freemarker2/freemarker2.js:668:66260:
      668 │ ...||(u=wQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/freemarker2/freemarker2.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=$b.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/freemarker2/freemarker2.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/handlebars/handlebars.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/handlebars/handlebars.js:668:66260:
      668 │ ...||(u=hQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/handlebars/handlebars.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=Ub.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/handlebars/handlebars.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/html/htmlMode.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,yt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/html/htmlMode.js:668:66260:
      668 │ ...||(u=oJ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/html/htmlMode.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,yt(f=>{r(u,f),this._lastDiff=u;let g=t1.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/html/htmlMode.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,yt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/xml/xml.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/xml/xml.js:668:66260:
      668 │ ...||(u=dQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/xml/xml.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=Ub.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/xml/xml.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/yaml/yaml.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/yaml/yaml.js:668:66260:
      668 │ ...||(u=dQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/html/html.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/html/html.js:668:66260:
      668 │ ...||(u=hQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/html/html.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=Ub.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/html/html.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/yaml/yaml.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=Ub.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/yaml/yaml.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/liquid/liquid.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/liquid/liquid.js:668:66260:
      668 │ ...||(u=hQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/liquid/liquid.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=Ub.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/liquid/liquid.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/mdx/mdx.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/mdx/mdx.js:668:66260:
      668 │ ...||(u=dQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/mdx/mdx.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=$b.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/mdx/mdx.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/typescript/tsMode.js:668:67385:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,Pt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/typescript/tsMode.js:668:67356:
      668 │ ...|(u=Wle(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/typescript/tsMode.js:668:67421:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,Pt(f=>{r(u,f),this._lastDiff=u;let g=B0.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/typescript/tsMode.js:668:67392:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,Pt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/javascript/javascript.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/javascript/javascript.js:668:66260:
      668 │ ...||(u=uQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/javascript/javascript.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=$b.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/javascript/javascript.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/css/cssMode.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,yt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/css/cssMode.js:668:66260:
      668 │ ...||(u=jQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/css/cssMode.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,yt(f=>{r(u,f),this._lastDiff=u;let g=t1.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/css/cssMode.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,yt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/typescript/typescript.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/typescript/typescript.js:668:66260:
      668 │ ...||(u=dQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/typescript/typescript.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=Ub.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/typescript/typescript.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/json/jsonMode.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,yt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/json/jsonMode.js:668:66260:
      668 │ ...||(u=cJ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/json/jsonMode.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,yt(f=>{r(u,f),this._lastDiff=u;let g=o1.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/language/json/jsonMode.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,yt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/razor/razor.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/razor/razor.js:668:66260:
      668 │ ...||(u=hQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/razor/razor.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=Ub.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/razor/razor.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/python/python.js:668:66289:
      668 │ ...ginal,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/python/python.js:668:66260:
      668 │ ...||(u=dQ(u,e.original,e.modified),u=(e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

▲ [WARNING] The "??" operator here will always return the right operand [suspicious-nullish-coalescing]

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/python/python.js:668:66325:
      668 │ ...dified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;let g=Ub.fromDif...
          ╵                                                      ~~

  The left operand of the "??" operator here will always be null or undefined, so it will never be
  returned. This usually indicates a bug in your code:

    https://esm.sh/v135/monaco-editor@0.52.0/denonext/esm/vs/basic-languages/python/python.js:668:66296:
      668 │ ...e.original,e.modified,void 0)??u,u=(e.original,e.modified,void 0)??u,wt(f=>{r(u,f),this._lastDiff=u;l...
          ╵                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

An error occurred during route handling or page rendering.
An error occurred during route handling or page rendering.
An error occurred during route handling or page rendering.
An error occurred during route handling or page rendering.
An error occurred during route handling or page rendering.
Error: The service was stopped
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1059:25
    at Object.responseCallbacks.<computed> (https://deno.land/x/esbuild@v0.20.2/mod.js:679:9)
    at afterClose (https://deno.land/x/esbuild@v0.20.2/mod.js:669:28)
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1972:11
    at eventLoopTick (ext:core/01_core.js:175:7)
Error: The service was stopped
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1059:25
    at Object.responseCallbacks.<computed> (https://deno.land/x/esbuild@v0.20.2/mod.js:679:9)
    at afterClose (https://deno.land/x/esbuild@v0.20.2/mod.js:669:28)
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1972:11
    at eventLoopTick (ext:core/01_core.js:175:7)
Error: The service was stopped
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1059:25
    at Object.responseCallbacks.<computed> (https://deno.land/x/esbuild@v0.20.2/mod.js:679:9)
    at afterClose (https://deno.land/x/esbuild@v0.20.2/mod.js:669:28)
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1972:11
    at eventLoopTick (ext:core/01_core.js:175:7)
Error: The service was stopped
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1059:25
    at Object.responseCallbacks.<computed> (https://deno.land/x/esbuild@v0.20.2/mod.js:679:9)
    at afterClose (https://deno.land/x/esbuild@v0.20.2/mod.js:669:28)
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1972:11
    at eventLoopTick (ext:core/01_core.js:175:7)
Error: The service was stopped
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1059:25
    at Object.responseCallbacks.<computed> (https://deno.land/x/esbuild@v0.20.2/mod.js:679:9)
    at afterClose (https://deno.land/x/esbuild@v0.20.2/mod.js:669:28)
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1972:11
    at eventLoopTick (ext:core/01_core.js:175:7)
Error: The service was stopped
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1059:25
    at Object.responseCallbacks.<computed> (https://deno.land/x/esbuild@v0.20.2/mod.js:679:9)
    at afterClose (https://deno.land/x/esbuild@v0.20.2/mod.js:669:28)
    at https://deno.land/x/esbuild@v0.20.2/mod.js:1972:11
    at eventLoopTick (ext:core/01_core.js:175:7)

Really weird and I have to turn to NodeJS for now.

HeavySnowJakarta/coolcpp-online-deno-fresh helps repro the error.
ref: #975


Is this project dead?

It seemed promising but  no new releses in years

Development is very active, but author decided not to make releases at all.

Maybe it became closed project

When will we can use it?


Speed and sensitivity settings don't do anything, consider implementing "disable trackpoint"

I tried values of 0 to 100 for both and there is no effect on a t440 (the one with integrate trackpoint buttons combo) on Ubuntu19.04.
Then again the trackpoint buttons don't work at all with the conventional touchpad settings enabled (top to click and gestures), and they barely work with those settings disabled. Even more seriously, the touchpad palm rejection makes the trackpoint itself completely unusable - if you rest your hands normally while using the trackpoint, you will touch the touchpad with your palm and this will cause the trackpoint to stop moving entirely.
So at least on my system, the trackpoint doesn't work at all. I suspect that longstanding palm rejection bug this is a fundamental libinput issue affecting all linux distros and all thinkpads. I remember the buttons sort of barely working on Ubuntu 18.04 but the basic palm rejection bug has been there from the beginnings of libinput. There is no way this will ever get fixed.
Do we actually know if any modern thinkpad trackpoints work on Linux at all? If the answer is no, then the only relevant trackpoint setting is "disable trackpoint." It's possible that trackpoints work on the thinkpads that are 10 years old (where palm interference wasn't an issue) but the new ones are probably all broken.

Yes trackpoint works just fine on Linux for all modern thinkpads, with palm
rejection. The value range is also 0-255, with both values 0 meaning the
trackpoint is disabled.
I suspect the trackpoint edit not working has to do with newer distros
using rmi to interface with trackpoint, where as older distros use
serio1/serio2. I will have to do some research to see how to get both to
work, but it should just be a matter of checking if one file exists and if
not using the other file.
On Tue, Oct 15, 2019, 7:41 AM ripefig<EMAIL_ADDRESS>wrote:

I tried values of 0 to 100 for both and there is no effect on a t440 (the
one with integrate trackpoint buttons combo) on Ubuntu19.04.
Then again the trackpoint buttons don't work at all with the conventional
touchpad settings enabled (top to click and gestures), and they barely work
with those settings disabled. Even more seriously, the touchpad palm
rejection makes the trackpoint itself completely unusable - if you rest
your hands normally while using the trackpoint, you will touch the touchpad
with your palm and this will cause the trackpoint to stop moving entirely.
So at least on my system, the trackpoint doesn't work at all. I suspect
that longstanding palm rejection bug this is a fundamental libinput issue
affecting all linux distros and all thinkpads. I remember the buttons sort
of barely working on Ubuntu 18.04 but the basic palm rejection bug has been
there from the beginnings of libinput. There is no way this will ever get
fixed.
Do we actually know if any modern thinkpad trackpoints work on Linux at
all? If the answer is no, then the only relevant trackpoint setting is
"disable trackpoint." It's possible that trackpoints work on the thinkpads
that are 10 years old (where palm interference wasn't an issue) but the new
ones are probably all broken.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/devksingh4/thinkpad-tools/issues/9?email_source=notifications&email_token=AEO4JMXR26NQM6S24LOFNY3QOW3ANA5CNFSM4JA4ASJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HR3ROHA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEO4JMTMBJT2NCW7L6U4NWDQOW3ANANCNFSM4JA4ASJA
.

Are you using Ubuntu?
This bug is still open, for T450, which has different input hardware, but it's slightly different than mine: it just says the trackpoint is slow and the speed can't be changed without recompiling libinput or something:
https://bugs.launchpad.net/ubuntu/+source/libinput/+bug/1733083
I've tried 440, 450 and and 430 over several years with Ubuntu and libinput. All of them had serious issues with the trackpoint and (previously) touchpad that made it impossible to use the computer without a conventional external mouse.

I am using Debian but have previously used Ubuntu. It worked fine on my
T480. I don't think the file edited relies on libinput; it edits the buffer
which the trackpoint exposes to the system
On Tue, Oct 15, 2019, 12:47 PM ripefig<EMAIL_ADDRESS>wrote:

Are you using Ubuntu?
This bug is still open, for T450, which has different input hardware, but
it's slightly different than mine: it just says the trackpoint is slow and
the speed can't be changed without recompiling libinput or something:
https://bugs.launchpad.net/ubuntu/+source/libinput/+bug/1733083
I've tried 440, 450 and and 430 over several years with Ubuntu and
libinput. All of them had serious issues with the trackpoint and
(previously) touchpad that made it impossible to use the computer without a
conventional external mouse.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/devksingh4/thinkpad-tools/issues/9?email_source=notifications&email_token=AEO4JMSF2424G3L6QAO3OVDQOX6Z7A5CNFSM4JA4ASJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBJUMWI#issuecomment-542328409,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEO4JMQUM2DQHNTRVBYMZGTQOX6Z7ANCNFSM4JA4ASJA
.

I just published a patch which may fix this problem, please try now

No, it still doesn't affect the speed or sensitivity.

Feature to disable trackpoint added.


Degraded performance after porting multi-thread build to new MacBook Pro

Environment info
Operating System: MacOS Sierra, 2.9 GHz Intel Core i5
Compiler: gcc...info as follows (having used "brew install gcc --without-multilib)":
gcc --version
Configured with: --prefix=/Library/Developer/CommandLineTools/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 8.0.0 (clang-8<IP_ADDRESS>)
Target: x86_64-apple-darwin16.1.0
Thread model: posix
Package used (python/R/jvm/C++): python
xgboost version used: Latest, 0.6
I've just ported my xgboost code from an old Macbook Air to a new Macbook Pro - same processor but faster.  I've built the code as I did before, using the instructions on https://xgboost.readthedocs.io/en/latest/build.html, and so have multi-core xgboost all working in a Jupyter notebook, and it nicely maxes out all the CPU cores when training a model etc.  So far so good.  Weirdly the performance is way slower (I estimate by factor of 5) than on my previous machine.  It "feels like" a compilation issue, almost like it's not fully exploiting the processor's features.  I've put xgboost into verbose mode so I can see each iteration being logged, and it only manages one iteration per second or so (across 4 cores, with a relatively simple set of training data).
Any ideas where to look/how to debug this problem?

More info - it's related to the multi-threading:

With nthread=4, I get about 3-4 rows logged as follows:
[12:17:52] src/tree/updater_prune.cc:74: tree pruning end, 1 roots, 52 extra nodes, 0 pruned nodes, max_depth=6
But weirdly with nthread=1, I get about 10 rows logged per second. ie. it's 2.5x faster with only 25% of the cores in use

I am not sure if it is related but I've also noticed a degradation in performances since recent commits added coverage tests and accidentally left TEST_COVER variable in make/config.mk set to 1.
Setting this value to 0 solved the issue for me.

Ouch. really sorry about that. I have set WITH_TEST to 0 in https://github.com/dmlc/xgboost/pull/1853 That indeed disables optimization while compiling and would make things slower. Not sure how thread parallelization would be affected by it though. (I would assume it wouldnt become worse with more threads!)

Yep - that's improved the performance back to where it should be! Also the multi-threading performance is better than single-threaded/core as you'd expect. Thanks.


Dear Imgui: Firefox support

Currently Firefox isn't supported. This is somewhat surprising as imgui-js's as well as implot's online examples appear to be working fine.
Wondering if this is due to a linking emscripten flag or due to how GFLW3 and WGPU are initialised/used.

I found out that currently only Nightlies support WebGPU.

I think we just need to patiently wait until WebGPU support makes it to the main branch.


Image and text retrieval

I would like to quote your method of Qualitative analysis, method. image and text retrieval your work is very meaningful, however this piece of code did not find convenient open source? Thank you very much!

Hi, I have added the qualitative evaluation codes (img2txt, txt2img, and visual_concept). Thanks.

Thank you very much!


Add ability to scale bar chart based on time

[x] feature request

Currently the area and line charts accept x-domain data on a time scale but the bar chart treats it like linear string data. It would be awesome to allow the bar charts to accept time based scaling data.

How would that work? If the x axis is a time scale, how much time would each bar represent?
This is possible, but would require additional inputs, like defining the bar range. And if you are going to do that, it would probably be easier to just wrangle your data and use an ordinal scale with the existing bar charts.

The way I have solved for this with D3 is to set the width of the bar equal to the total width of the chat divided by the total data-sets in the array. I suppose that assumes that each data-set has a uniform time distribution for each bar (which I think would be the case for most charts).
A snippet from my D3 example:
this.xScale = d3.scaleTime().rangeRound([0, this.width]);
this.xScale.domain([data[0].time_bucket, data.slice(-1).pop().time_bucket]);
this.svg.selectAll('.converge')
      .data(data)
      .enter().append('g')
      .selectAll('.rekt')
      .data((d) => { return this.stack.keys(['success', 'failure'])(d); })
      .enter().append('g')
        .attr('class', (d) => { return `converge-${d.key}` })
        .attr('fill', (d) => { return this.color(d.key); })
      .selectAll('rect')
      .data((d) => { return d; })
      .enter().append('rect')
        .attr('y', (d) => { return this.yScale(d[1]); })
        .attr('x', (d) => { return this.xScale(d.data.time_bucket); })
        .attr('height', (d) => { return this.yScale(d[0]) - this.yScale(d[1]); })
        .attr('width', this.width / data.length)
        .attr('transform', `translate(-${this.margin.left}, 0)`);

Right, but that's a bad assumption to make if you want the chart to work for all types of time data. What if I have two dates that are very close to each other? The bars would overlap in that case.
To solve this, you would have to divide the domain into buckets, and then wrangle the data to calculate the values for each bar. The chart could handle this, but it requires an extra input - either number of buckets, or the span of a bucket.

I don't think this is feasible for the generic use case. I'll close and just extend the BaseChartComponent to fit my needs. Thanks for the input!


[HUDI-361] Implement CSV metrics reporter

Currently, there are only two reporters MetricsGraphiteReporter and InMemoryMetricsReporter. InMemoryMetricsReporter is used for testing. So actually we only have one metrics reporter.  propose to provide a CSV metrics reporter.

The CI is broken!

hi, @XuQianJin-Stars, from the ci error detail, we can see that have 10 Checkstyle violations in hudi-client module. You can check it in your local env.

hi, @XuQianJin-Stars, from the ci error detail, we can see that have 10 Checkstyle violations in hudi-client module. You can check it in your local env.

Thank you very much, hudi 's code style is error import into idea.

hi, @XuQianJin-Stars, how to get the csv metrics file in product environment easily ?

hi, @XuQianJin-Stars, how to get the csv metrics file in product environment easily ?
Unless csv is placed on the public file system of hdfs, it can only be collected locally by an agent like Flume.

Hi @XuQianJin-Stars I am also wondering whether this kind of reporter is easy and common to used?

hi @XuQianJin-Stars, thanks for your contribution, CSV metrices reporter seems not popular in product, so I suggest closing this, WDYT? @leesf
also, flink doesn't use CSV reporter
https://ci.apache.org/projects/flink/flink-docs-release-1.10/monitoring/metrics.html#reporter

hi @XuQianJin-Stars, thanks for your contribution, CSV metrices reporter seems not popular in product, so I suggest closing this, WDYT? @leesf
also, flink doesn't use CSV reporter
https://ci.apache.org/projects/flink/flink-docs-release-1.10/monitoring/metrics.html#reporter

sorry for late response. +1 to close the PR


Improve session list item accessibility

Overview (Required)

Improvements for TalkBack

Remove unnecessary contentDescription from item view
Add stateDescription to favorite button

It's not the best, but it's easier to read.
Screenshot
Notice the TalkBack reading at the bottom of the screenshot.
Session item

Before
After

"isFavoritedtrue"
"[Session title] [Room name] [Minutes]"

Favorite button

Before
After

"bookmark icon, ボタン"
"ON, favorite, ボタン"

ScreenRecord
Before
https://user-images.githubusercontent.com/3139391/189697654-9f1ba2ca-ebd0-42be-a28e-376b02f60e76.mp4
After
https://user-images.githubusercontent.com/3139391/189697705-ce403daf-49de-4ff7-bf01-3f095a78b168.mp4

Awesome work for a11y! 🎉 ✨
I believe that it's better for everyone, also How about attache the recorded video with using Talkback ? ⏺
My idea helps for your PR will easy to review/ behavior check for us. 🙇♀

Yes, I'm cheking now.

hmmm...

Could you run ./gradlew spotlessKotlinApply?

@yukilabo @takahirom Sorry. CI is failing due to #397🙏


MAP types are not supported on version 0.21

Describe the bug
We recently released support for nested types during profiling, however I am finding that MAPs do not have profiling insights or table outputs.
To Reproduce
Steps to reproduce the behavior:

start Rill
model SELECT map([100, 5], [42, 43])
see no table, no profiling

Expected behavior
I expect to see top k and tables for MAP types.
Screenshots
Internal video here: https://www.notion.so/rilldata/MAP-types-not-working-in-21-0-62a1e1638d524411ae7483e675328bb0

This appears to possibly an invalid type in the runtime. I get a 400 error with "proto: invalid type: duckdb.Map". Passing on to @begelundmuller to triage, if my understanding is correct.

Yep, looks like we didn't have proto/JSON serialization for DuckDB map types. Added it here: https://github.com/rilldata/rill-developer/pull/1787

This is not working for me in the application @begelundmuller .  Please see my note in notion. https://www.notion.so/rilldata/Application-Bugs-and-Polish-for-21-1-6d7f59f3076249f7af64dfbc8acc47df

It should work for everything except maps with map/array keys (not values). Conversation for supporting complex types in map keys continuing here: https://github.com/rilldata/rill-developer/issues/1798.


test examples

ensure that SG and 7 bridges solutions are as expected
make sure visualizations work

mostly implemented.  Should add a test checking that examples scripts run without errors and produce expected files

could try
https://pypi.python.org/pypi/pytest-console-scripts
or for integration testing: write the CLI command as string, parse w shlex and test that files are written.  could use tempdirs to be clean about it.


fix: integration test

Signed-off-by: Abirdcfly<EMAIL_ADDRESS>

Integration Test / suite (ca) still fails and so does upstream, should be a problem with the part we haven't changed yet, need to keep working on it, will submit it as an additional pr later.

see https://github.com/hyperledger-labs/fabric-operator/pull/89


community: fix create_sql_agent prefix

Description: fix create_sql_agent prefix and suffix when prefix & suffix arguments are nor None.
Issue:
Dependencies:
Twitter handle: @dalssoft

Hi @dalssoft I don't think I understand this fix. When the arguments are None the or is going to default to the react prompt anyway. Would you mind updating the description of the PR title to explain what is being fixed?

The problem occurred because it was ignoring prefix or suffix when calling create_sql_agent.
Rational:
if you pass a prefix as string it will go to this line but does not create a prompt.
so when on this if, it will create a new prompt with defaults but ignore the prefix (or suffix).
Maybe a better strategy is to create a prompt in the first place instead of what I'm suggesting in this PR.

Believe this was fixed in https://github.com/langchain-ai/langchain/pull/23693. Apologies as this PR was earlier. Let me know if issues remain and can re-open.


Changed CRLF line endings to LF.

Also changed some of the tests. And if they're still CRLF then fml I should get checked for mental issues

restarting on new branch


chore: drop support for HTML, PDF, and Markdown converting functions

Description
Drop support for the converters to convert to HTML/PDF.
Reasons
Take a look at Conversion to HTML README section, PR #1990, some discussions at related issues, PRs, discussions, and Slack. We discussed more details there.
Here is the key list of reasons:

Lack of Standardization in Quill JS: Those two features are not a standard features in Quill JS, Our implementation was a workaround rather than a core part of the Quill ecosystem. We decided to focus more on the existing core code without adding more code that is not tested and doesn't adhere to high-quality standards, We’ve been receiving a high volume of reports across Issue Tracker, GitHub discussions, Slack, and private messages regarding this, we prefer to focus on the primary goal of the project, improve existing code, prioritize other things, critical bugs that make the editor unusable, performance issues, tests, inconsistency, code quality, extensibility, bugs, feature requests, architecture, docs, usability. There are other alternatives that focus on this functionality, the only use case where you might want those two features (converting Delta to HTML/PDF) is to add the Save as feature. The project focuses on the editor itself.
Dependency on Third-Party Projects: The conversion features relied heavily on third-party packages, We didn't implement our own implementation designed from the ground up for the project, instead we used existing packages, slightly modifying them.
Quality and Stability: The implementation is far from stable, with bugs and inconsistencies issues., We found that the experimental support did not meet the high standards we strive for in our primary package.
Differences: There are structural and functional differences between HTML and Quill Delta that often result in inconsistencies and incomplete, as we keep adding more features, most of them are broken when converting to HTML and then back to Delta, requiring storing custom attributes in HTML elements, which make it incompatible with existing HTML from other systems, storing custom HTML attributes might cause some issues in case the system validate the syntax, attributes of the HTML. See Quill JS #1551 for more details.
Increased Issue Reports: This made it more difficult for contributors and maintainers to concentrate on improving the primary functionality of the editor package and addressing critical bugs and feature requests. We don't have custom labels to filter the issues and this would require extra input when creating an issue, some users might not select the correct input.
Limited Usefulness: We have reports from users regarding bugs and feature requests who are storing the Delta as HTML in the database, you usually don't need to store it as HTML in case you use Web, you can use Quill JS or Flutter web with flutter_quill, there are some reasons where you might want to convert Delta to HTML for sending it as an email or publish it somewhere else, or for migration from the existing system, there are already existing solutions like vsc_quill_delta_to_html or flutter_quill_delta_from_html, see Conversion to HTML section for more details, it's not recommended to store the Document as HTML or other data formats in the database, it causes other issues regarding performance other than bugs and doesn't support all features.
Project Structure: Add two more directories, that will also need to be maintained in CI, docs, scripts, the example, and other places, which consume more resources when building the project for each commit, and release.

While we're grateful to the library authors, we prefer to minimize the dependencies, when a new release of Flutter comes out, this will make it harder to update the package with the new release of Flutter, requiring more around, sometimes forking the package and edit them manually, reverting the changes to use the original and maintained package, most developers will update Flutter to use them with most projects, they might have some projects that use flutter_quill, which will cause build failure and require either temporary workarounds or downloading different versions of Flutter, See Comment #2114954661 as an example.
Why breaking change?
The quill_pdf_converter and quill_html_converter are experimental packages.
Even though the version is not experimental (to allow automated publishing and centralize the version) We have marked them as experimental in the package README.md for the two packages in GitHub and Pub.dev, README.md of the repository, in CHANGELOG.md, the docs of the code of all flutter_quill, quill_html_converter and quill_pdf_converter for all functions and classes, marked them as experimental using meta, mentioned that in GitHub issues, discussions and in Slack.
We have already mentioned that the support can be dropped at anytime

This library is experimental and the support might be dropped at any time.

You can still use the old version of those packages for now. Take a look at the existing quill_html_converter and quill_pdf_converter
We haven't dropped the support for the experimental functions DeltaX.fromMarkdown and DeltaX.fromHtml in flutter_quill, which work well for the Rich Text Pasting Feature only, we do plan soon, we will deprecate them first for a while then avoid exposing them and only using them internally for this feature which also requires super_clipboard, we recommend to avoid using those APIs as soon as possible.
Suggested alternatives

DeltaX.fromMarkdown: https://pub.dev/packages/markdown_quill
DeltaX.fromHtml: https://pub.dev/packages/flutter_quill_delta_from_html
quill_pdf_converter: https://pub.dev/packages/flutter_quill_to_pdf
quill_html_converter: https://pub.dev/packages/vsc_quill_delta_to_html

There might be other alternatives for other data formats, you might want to explore them on pub.dev.
Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I titled the PR using Conventional Commits.
[x] I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
[x] All existing and new tests are passing.
[x] I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

[ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
[x] No, this is not a breaking change.

@CatHood0

This PR will remove quill_html_converter including the changes of #1990.

Maybe we should move the changes to vsc_quill_delta_to_html if the change is suitable and works for most use cases though it has some specific features that do not conform to standard Quill Delta, such as line-height or maybe to a new package that's specifically designed for HTML conversion with Quill in general or Flutter Quill?
The line-height property is specific to CSS and is not natively supported in HTML. In the context of Flutter Quill, it appears we are attempting to convert the line-height attribute to convert HTML back to Delta, it's also not supported in standard Quill Delta. As discussed previously in #1990, this might not be a valid use case.

It seems that the package flutter_quill_delta_from_html which is used for the rich text pasting feature, might not support nested list or sublist, tested while using the rich text pasting feature

Can you provide me with the text you used as an example?
I saw the README, that has the nested list with Markdown syntax, which the latter is not supported. I could be misunderstanding something, so if you provide me with the text you used I could test about this problem, while I take advantage and find a solution to add the HTML indent attribute to Delta

Can you provide me with the text you used as an example (I mean if you used HTML or if you are directly using the list that comes from the README)?

Copying the following:

- [Flutter Quill](#flutter-quill)
  - [📚 Table of contents](#-table-of-contents)
  - [📸 Screenshots](#-screenshots)
  - [📦 Installation](#-installation)
  - [🛠 Platform Specific Configurations](#-platform-specific-configurations)
  - [🚀 Usage](#-usage)
  - [🔄 Migration](#-migration)
  - [🔤 Input / Output](#-input--output)
    - [🔗 Links](#-links)
  - [⚙ Configurations](#-configurations)
    - [🔗 Links](#-links-1)
    - [🖋 Font Family](#-font-family)
  - [📦 Embed Blocks](#-embed-blocks)
    - [🛠 Using the embed blocks from `flutter_quill_extensions`](#-using-the-embed-blocks-from-flutter_quill_extensions)
    - [🔗 Links](#-links-2)
  - [🔄 Conversion to HTML](#-conversion-to-html)
  - [🌐 Translation](#-translation)
  - [🧪 Testing](#-testing)
  - [👥 Contributors](#-contributors)

Which is in Markdown, and rendered in GitHub which uses HTML, calling platform-specific code
to access the Clipboard (withsuper_clipboard plugin) that will return this HTML:
<ul dir="auto" style="box-sizing: border-box; padding-left: 2em; margin-top: 0px; margin-bottom: var(--base-size-16); color: rgb(230, 237, 243); font-family: -apple-system, "system-ui", "Segoe UI", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(13, 17, 23); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;">
Flutter Quill

📚 Table of contents

📸 Screenshots

📦 Installation

🛠 Platform Specific Configurations

🚀 Usage

🔄 Migration

🔤 Input / Output

🔗 Links

⚙ Configurations

🔗 Links

🖋 Font Family

📦 Embed Blocks

🛠 Using the embed blocks from flutter_quill_extensions

🔗 Links

🔄 Conversion to HTML

🌐 Translation

🧪 Testing

👥 Contributors

The HTML will be different depending on the platform, it can return  as the root element or the content directly though we're already parsing the required part of HTML outside of DeltaX.

The HTML will be different depending on the platform, it can return  as the root element or the content directly although we're already parsing the required part of HTML outside of DeltaX

This in itself is not a problem, flutter_quill_delta_from_html does validations to make sure we always get the nodes we need (the ones that contain the content to be parsed to Delta).
Anyway, I'm trying a solution for this right now, because it seemed simple, but it's not so simple in practice.

Which is in Markdown, and rendered in GitHub which uses HTML, calling platform-specific code
to access the Clipboard (withsuper_clipboard plugin) that will return this HTML

Thanks for the example, I will take it into account while I resolve the issue of nested lists.

It seems that the package flutter_quill_delta_from_html which is used for the rich text pasting feature, might not support nested list or sublist, tested while using the rich text pasting feature

This already was fixed at the flutter_quill_delta_from_html version -> 1.2.7

Not sure why it is closed

Not sure why it is closed

It has been referenced on the PR that has been closed, still not sure why.


notifyItemInserted at top of grid invalid layout

As pointed out by yiğit boyar on G+, if you add an item to the top of your grid, and then call adapter.notifyItemInserted(  ), the resulting layout will be "wrong".  A position is at the top of the grid if it's index is less than the number of columns.  So, if you have a two-column grid, positions 0 and 1 are both at the top.  This only affects item insert/remove operations at the top of the grid.

There are (so far) at least two approaches to work around this issue.  The easy (inefficient?) way is to use notifyDataSetChange() (instead of notifyItemInserted) to re-layout and re-bind everything after you insert at the top.  This works, but you really shouldn't do this.
The second approach is to call invalidateItemDecorations() on the recyclerView after the insertion.  The problem with this approach is that, if there is already a re-layout underway (as a result of calling notifyItemInserted) then this call may be ignored.  If you delay the call slightly, it seems to work as expected.
public void addItemAtPosition(int position, String item) {
    myDataset.add(position, item);
    mAdapter.notifyItemInserted(position);
    mSGLM.scrollToPosition(position);

    // Items added to the top row? Better invalidate the decorator.
    // Delay to ensure that the previous layout pass has completed.
    if (position < columnCount) {
        new Handler().postDelayed(new Runnable() {
            @Override
            public void run() {
                mRecycler.invalidateItemDecorations();
            }
        }, 300);
    }
}

The underlying issue appears to be a bug in RecyclerView (#93156), and it looks like this has been fixed with release 22 of the recyclerview-v7 library.  Calling invalidateItemDecorations in a hander.post is no longer required.


[Bug] SwiftBarcodeScanPlugin.swift deprecated code

BUG REPORTS WITHOUT PROVIDING THESE INFORMATIONS WILL BE CLOSED DIRECTLY. DON'T REMOVE THE SECTIONS!
Describe the bug
A build warning that .devices(for:) is deprecated
'devices(for:)' was deprecated in iOS 10.0: Use AVCaptureDeviceDiscoverySession instead.
File: SwiftBarcodeScanPlugin.swift
Function: public func handle
Line: 23
result(AVCaptureDevice.devices(for: .video).count)
To Reproduce
Steps to reproduce the behavior:

Open in Xcode
Build

Expected behavior
Expected no error
Screenshots
Logs
Environment (please complete the following information):

Version of barcode_scan 4.1.4
Output of flutter --version:

Flutter 2.2.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision f4abaa0735 (9 weeks ago) • 2021-07-01 12:46:11 -0700
Engine • revision 241c87ad80
Tools • Dart 2.13.4

Additional context
Only warnings at this stage

+1 - any plans to fix this?

i have this message too:
[21:42:14]: ▸     'flashMode' was deprecated in iOS 10.0: Use AVCapturePhotoSettings.flashMode instead.
[21:42:14]: ▸     return device != nil && (device?.flashMode == AVCaptureDevice.FlashMode.on || device?.torchMode == .on)
[21:42:14]: ▸                                      ^
[21:42:14]: ▸ 'flashMode' was deprecated in iOS 10.0: Use AVCapturePhotoSettings.flashMode instead.
[21:42:14]: ▸       device.flashMode = on ? .on : .off
[21:42:14]: ▸              ^


report count measurement, and update README

Builds off of #86
Mostly just some updates to the README, I also changed the measurements for the message_received event to be a count instead of a latency. I'm trying to avoid the flakey auto-unub tests by giving 10ms for the server to finish registering our subscription before we start publishing messages.

Flakey test is not fixed, but everything else looks good


[BUG] Passing wrong parameter when calling newConfigurationException method in DotExpanderProcessor

Describe the bug
The first parameter of the method ConfigurationUtils.newConfigurationException() is processorType, but DotExpanderProcessor passes wrong parameter when calling it, even though it doesn't affect the response of the API.
To Reproduce
Steps to reproduce the behavior:

Create a ingest pipeline with dot_expander processor, and the value of field doesn't contain a dot:

PUT _ingest/pipeline/test2
{
  "processors": [
      {
        "dot_expander": {
          "field": "foobar"
        }
      }
    ]
}

The response has correct processor type:
{
  "error": {
    "root_cause": [
      {
        "type": "parse_exception",
        "reason": "[field] field does not contain a dot",
        "processor_type": "dot_expander",
        "property_name": "field"
      }
    ],
    "type": "parse_exception",
    "reason": "[field] field does not contain a dot",
    "processor_type": "dot_expander",
    "property_name": "field"
  },
  "status": 400
}

Expected behavior
Correct the first parameter when calling newConfigurationException method in DotExpanderProcessor
Host/Environment (please complete the following information):

OS: [macOS]
Version [2.9]

Is it that "reason": "[field] field does not contain a dot" should be "[foobar] field does not contain a dot" ?

Fixed by https://github.com/opensearch-project/OpenSearch/pull/10737.


[BUG] Key Vault script in tre-deploy target fails due to missing environment variable

/devops/scripts/set_contributor_sp_secrets.sh is run as part of the tre-deploy target in Makefile. If run manually, the script will fail, because TRE_ID environment variable is not defined. The Makefile target loads environment variables from .env files, but injects TF_VAR_ prefix so although TRE ID is in the environment variables, it has a name the script is not expecting.
A solution is to also use load_env.sh to process the /templates/core/.env file in tre-deploy target.

@tompaana  I'll update the makefile and test so will add the line in bold:
tre-deploy:
echo -e "\n\e[34m»»» 🧩 \e[96mDeploying TRE\e[0m..."
&& . ./devops/scripts/check_dependencies.sh nodocker
*&& . ./devops/scripts/load_env.sh ./templates/core/.env *
&& . ./devops/scripts/load_terraform_env.sh ./devops/.env
&& . ./devops/scripts/load_terraform_env.sh ./templates/core/.env
&& cd ./templates/core/terraform/ && ./deploy.sh
&& cd ../../../ && ./devops/scripts/set_contributor_sp_secrets.sh

The variables are loaded correctly but the script fails on this line and actually crashes my terminal:
az keyvault secret set --name deployment-processor-azure-client-id --vault-name $key_vault_name --value $CONTRIBUTOR_SP_CLIENT_ID

When I add the above two calls to load the required env variables, I'm instead seeing auth issues and Terraform terminates.
Given the error message, it seems additional env variables are picked up but also a change in behaviour - probably because of the existence of the ARM_ variables? ARM_TENANT_ID should be optional according to the quickstart.
│ Error: Failed to get existing workspaces: Error retrieving keys for Storage Account "<storage-account-name>": azure.BearerAuthorizer#WithAuthorization: Failed to refresh the Token for request to https://management.azure.com/subscriptions/<id>/resourceGroups/<rg>/providers/Microsoft.Storage/storageAccounts/<account name>/listKeys?api-version=2021-01-01: StatusCode=400 -- Original Error: adal: Refresh request failed. Status Code = '400'. Response body: {"error":"invalid_request","error_description":"AADSTS900023: Specified tenant identifier '__change_me__' is neither a valid DNS name, nor a valid external domain.\r\nTrace ID: c0a1f46b-f8f1-43ae-8e9d-2f5b40cc7900\r\nCorrelation ID: ee34bec3-077a-4233-a00e-e0aba47c0e26\r\nTimestamp: 2021-06-18 13:49:32Z","error_codes":[900023],"timestamp":"2021-06-18 13:49:32Z","trace_id":"c0a1f46b-f8f1-43ae-8e9d-2f5b40cc7900","correlation_id":"ee34bec3-077a-4233-a00e-e0aba47c0e26","error_uri":"https://login.microsoftonline.com/error?code=900023"} Endpoint https://login.microsoftonline.com/__CHANGE_ME__/oauth2/token?api-version=1.0

@christoferlof the variabes are correct, I think there was an issue with Key Vault.
Can you try to replace the variables in the script in real values and run it without loading the env?
I have a hunch that you will see the same behavior... I don;t think it is related.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v3.15 to before v4.9.291",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=08a9ff3264181986d1d692a4e6fce3669700c9f8",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=637d652d351fd4f263ef302dc52f3971d314e500"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "08a9ff3264181986d1d692a4e6fce3669700c9f8",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "637d652d351fd4f263ef302dc52f3971d314e500",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "btrfs: fix memory ordering between normal and ordered work functions\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.9.291 by commit 637d652d351fd4f263ef302dc52f3971d314e500, it was introduced in version v3.15 by commit 08a9ff3264181986d1d692a4e6fce3669700c9f8. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002226


Downstream Workers

Continuing from the work done in: https://github.com/alphagov/publishing-api/pull/439 I have refactored all the uses of the PresentedContentStoreWorker to use either DownstreamDraftWorker, DownstreamLiveWorker or DownstreamDiscardDraftWorker.
The advantages of having these classes is

Simplified API to initialise workers
Workers more closely tied to their responsibility offering clearer opportunities to validate asynchronous actions
Opportunities to re-use expensive downstream operations to improve performance.

In refactoring these I was able to address some bugs that we have in the Publishing API:

We now send unpublishings to both the draft and live content stores.
Replace a discarded draft with an unpublished item (if one exists)
The content store action of discarding a draft is less vulnerable to race conditions by nesting all uses of it and checking for content conflicts.

I like this a lot, great refactoring 💯 . I'm unsure about "mediator" as a term here, but I also can't quickly think of an alternative. I won't merge as this is a large change so I think it's worth some additional eyes.

Also double 💯  for clear commit messages

Thanks @boffbowsh 👍 - I struggled a bit about the mediator class, seemed the closest design pattern to employ.
I'm working with @cbaines and @dougdroper to try reduce complexity in that class so might well get renamed/repurposed.

Lots of things going on here, but superficially looks good, have you pushed it to integration to double check that everything works as expected?

@dougdroper all looks good on my tests


Implmented RHTPQMap

What this PR does / why we need it?
Implements RHTPQMap which will be used in CrdtObject.
And this PR contains draft test code.
I think writing test code will need some more time, so I want to you guys to review this codes before I write tests.
Any background context you want to provide?

The PR implemented based on rh_tpq_map.ts in yorkie-js-sdk.
I found some weird point(just nitpick) from original, and you can check them on PR comment.

Returning nullable object vs throw the exception

According to @hackerwins 's guide, it's written to throw an Exception in most situations.
However, the some code seems to intend returning nullable object, then I use returning instead of throw an Exception

Some more implements

Added toIDString() to TimeTicket
Added remove() to CrdtElement (I know @7hong13 implemented this function in other PR(#9), surely this can be drop by rebase or merge)

What are the relevant tickets?
None

Fixes #
Checklist

[ ] Added relevant tests or not required
[x] Didn't break anything

@skhugh Thanks for checking out things we missed in previous reviews. How about making a PR that reflects the comments you have left here?


Way to get all routes in a node micro-service

Hello,
I'm working on a project with many micro-services.
All controllers have routes.
But in my case, i would like get all controller's routes in on of my micro-service (for the scalability).
For exemple :

MyServCtrl1

/myServ1/put

MyServCtrl2

/myServ2/post
/myServ2/get
If I start a server with MyServCtrl1 (scan folder MyServ1). I would like to get all routes from both controllers when I'm using routeService getRoutes()

So i decided to launch 1 server with all controllers, saves all routes, stop it and create the micro-service. But, the second server, keep the first server routes ! (In the Properties Metadata map).
Do you have a mean to retrieve all routes in this micro-service ?
Thanks in advance

Hi @Tlahey,
I don't understand exactly why you need to create two server to build your routes one time again.
You can mount all micro-service on the final server rather than launch a server then stop it and retrieve the built routes. The final result is the same.
Maybe I need an example to understand your need.
See you.

Ok so, i've got a system where I use multiple micro services hosted on different Docker containers. Each of these microservices should be aware of all the routes there is. So we are trying to find a way to instatiate all the routes once to use as a list for our initialisation. But once we have this list we want each of our services to only be aware of the routes hosted on this container.
A quick example
I've got 3 controllers that instantiate 3 endpoints : /a /b /c
We've got one container per controller but we want each container to be aware of all the routes.
We actually need to have the routes in each container but each separate endpoint should only be accessible in its own container
Thanks in advance,

So you need to have three express server instance (that instantiate his own controllers), one per container, and one express server that list all services generated by each instances. The fourth server will be a proxy, I think.
Actually,  TsExpressDecorators, manage one express server by node process.  So you must to start micro service  in a separately node process (container).
The fourth server can get all routes via an http request on /restendpoint for each server started.
I'm not if I answered to your question, and if my solution is the right solution ^^.
See you

While your solution is correct, it can cause problems. I can see two mains sources of problems with this implementation :

If one of my micro Service dies, the lister server will not be able to get its endpoints, resulting in a truncated list of endpoints
If the lister server dies, all my micro-Services are incapacitated
We discussed it internally and we are going to develop a external parsing solution to get routes and controller methods directly from .ts controller files.

Thank you for your time and keep up the good work

Thanks @Tlahey ^^
You can use node forever to prevent this problem :) Node application will be restarted automaticaly ;)


Where is the "mono_sent.py" file?

Thanks for your great work!
I am wondering where is the "mono_sent.py"(the file used for training the language model)?
Looking forward to your reply!

The REAME was wrong, the correct file is models/sent_lm.py. I fixed it. Please, read the updated documentation.

The REAME was wrong, the correct file is models/sent_lm.py. I fixed it. Please, read the updated documentation.

Thanks！And which task is used to train the language model? The masked language taks like bert?


Resolve some reactredux warnings

This seems to have started causing failures when we updated our typescript version. It was missed because those tests were marked as flaky.

Closing in favor of https://github.com/aspnet/AspNetCore/pull/11784 which needed the change anyway.