[BUG] EnqueueRequestForNode should not only watche update of node's allocatable

What happened:
NodeSLO controller should handle the change about node labels, while now it returns with doing nothing if allocatable not changed.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

App version:
Kubernetes version (use kubectl version):
Install details (e.g. helm install args):
Node environment (for koordlet/runtime-proxy issue):

Containerd/Docker version:
OS version:
Kernal version:
Cgroup driver: cgroupfs/systemd

Others:

/help-wanted

/help

/milestone v1.6

/close by #2201


[BULK] - DocuTune remediation - Sensitive terms with GUIDs (part 40)

Applying sensitive terms with GUID changes as part of Content SFI and outlined in Overview - Writing content securely - Platform Manual. Changes are part of the Microsoft-wide SFI effort. Point of contact: @CelesteDG
DocuTune v<IP_ADDRESS>
CorrelationId: ac15aa43-4e2b-437f-ab1c-fdd7e79cd4db
#docutune

#docutune-review

LGTM


Return compiler arguments for invalid package manifests

Companion of https://github.com/swiftlang/swift-package-manager/pull/8138

Currently, when there‘s a syntax error in a package manifest, we don’t get any build settings from it in SourceKit-LSP and thus loose almost all semantic functionality. If we can’t parse the package manifest, fall back to providing build settings by assuming it has the current Swift tools version.
Currently, when there‘s a syntax error in a package manifest, we don’t get any build settings from it in SourceKit-LSP and thus loose almost all semantic functionality. If we can’t parse the package manifest, fall back to providing build settings by assuming it has the current Swift tools version.
Fixes #1704
rdar://136423767

https://github.com/swiftlang/swift-package-manager/pull/8138
@swift-ci Please test

@swift-ci Please test

@swift-ci Please test Windows


add bug/ feature request reporting to menu

https://github-api.kohsuke.org/

attach log file
attach properties file, with sensitive details masked


Sprint 1 Signup functionalities are now gone

Sprint 1 signup validations has been deleted due to pushing an unstable branch

Signup functionalities are done


Bug: Blob lines containing a decimal separator are omitted

Description
Fixing a bug that cause lines containing a decimal separator to get omitted from updated blobs.
Checklist:

[X] I confirm that my submission adheres to the Code of Conduct.
[X] I have tested that the code works with sample data and verified all tests are passing
[X] I have verified that any tests that I have supplied with this Pull Request work and I have fixed any code which caused pre-existing tests to fail.
[ ] I have updated the README with any changes in dependencies/configuration values.
[X] I have linted my code to ensure that it is formatted correctly.

Codecov Report

Merging #132 (228b3fc) into main (5d432ed) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   22.27%   22.27%
=======================================
  Files          26       26
  Lines         606      606
=======================================
  Hits          135      135
  Misses        471      471

Impacted Files
Coverage Δ

...s/Functions/Ingestion/ProcessPwnedPasswordEntry.cs
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Reorganize reconciler packages and add unit tests

Common helpers have been moved to common sub-packages, and a testing package was created with utilities that can be imported in tests.
There is now a single AWSEventSourceStatus struct common to all event sources, since they all expose the same status conditions.
All packages are covered to a least 90%, reconciliation tests leverage Knative's Table tests.

pkg/reconciler
├── awscodecommitsource
├── awscognitosource
├── awsdynamodbsource
├── awsiotsource
├── awskinesissource
├── awssnssource
├── awssqssource
├── common
│   ├── event
│   ├── object
│   ├── resource
│   └── semantic
└── testing

Closes #91

@sameersbn the CI fails with bad output from test2json, are you familiar with that error?

@sameersbn the CI fails with bad output from test2json, are you familiar with that error?

Haven't seen it before. Are you able to run the tests on your machine with go test and gotestsum?
Maybe this has some clues https://github.com/golang/go/issues/27582

Both are running alright locally:
gotestsum --junitfile aws-event-sources-unit-tests.xml -- -cover -coverprofile=c.out ./pkg/adapter/... ./pkg/apis/... ./pkg/reconciler/...
✓  pkg/adapter/awssqssource (43ms) (coverage: 42.6% of statements)
✓  pkg/adapter/awsdynamodbsource (37ms) (coverage: 63.3% of statements)
✓  pkg/adapter/awssnssource (45ms) (coverage: 67.3% of statements)
✓  pkg/adapter/awscognitosource (60ms) (coverage: 66.7% of statements)
✓  pkg/adapter/awskinesissource (133ms) (coverage: 66.7% of statements)
✓  pkg/adapter/awscodecommitsource (335ms) (coverage: 59.8% of statements)
∅  pkg/apis/sources
∅  pkg/apis/sources/v1alpha1
✓  pkg/reconciler/awscodecommitsource (1.115s) (coverage: 91.6% of statements)
✓  pkg/reconciler/awscognitosource (958ms) (coverage: 91.7% of statements)
✓  pkg/reconciler/common/object (92ms) (coverage: 100.0% of statements)
✓  pkg/reconciler/awsdynamodbsource (999ms) (coverage: 91.7% of statements)
✓  pkg/reconciler/awsiotsource (1.231s) (coverage: 91.2% of statements)
✓  pkg/reconciler/common/event (36ms) (coverage: 100.0% of statements)
✓  pkg/reconciler/common/semantic (47ms) (coverage: 77.8% of statements)
✓  pkg/reconciler/awssnssource (1.059s) (coverage: 91.2% of statements)
✓  pkg/reconciler/awskinesissource (1.219s) (coverage: 91.2% of statements)
✓  pkg/reconciler/awssqssource (1.029s) (coverage: 91.2% of statements)
∅  pkg/reconciler/common
✓  pkg/reconciler/common/resource (28ms) (coverage: 100.0% of statements)
∅  pkg/reconciler/testing

@antoineco I see the following lines in the logs
/usr/local/go/pkg/tool/linux_amd64/link: signal: killed
/usr/local/go/pkg/tool/linux_amd64/link: signal: killed
 ``

Can you try add ing `-p=1` to the `test` target in `scripts/inc.Target` ? I think we could be running out of memory on the ci instance

the root Makefile also has test target, add it there as well

@antoineco I've created a PR against your branch to workaround this issue. It turns out that the pkg tests request more memory than the CI instance can provide. I've disabled parallelization of the pkg tests to workaround this issue.

@sameersbn thanks for looking into it! I didn't have time yesterday. Should I cherry pick the commit from #121?


Change the theme color based on the top edge

Firefox extension that does this already: https://addons.mozilla.org/nl/firefox/addon/vivaldifox/
Docs on how to implement it:
https://blog.mozilla.org/addons/2018/03/08/theme-api-update/
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/theme/update

Closing because of irrelevance


Failed when I try to login

I got an error message which is 登录失效，请重新登录
When I stay on the login page for a long time and enter the username and password to login

This error has been fixed, you can try again.


Raise exception instead of echo in alert-rules add when rule-id is invalid

Description

Raise exception when rule-id is invalid, make error message adhere to format

Issues Resolved
INTEG-1470
Did you remember to do the below?

[x] Add unit tests to verify this change

[n/a] Add an entry to CHANGELOG.md describing this change

[n/a] Add docstrings for any new public parameters / methods / classes

Seems like we should add a changelog under a Fixes header like
Fixes issue where bulk alert rules would show as successful when adding users to a non-existent alert rule.


❄ Snowflake connector

User story
As a user, I quickly want to connect my Snowflake data warehouse with Kuwala to start applying transformations. I only want to put in my credentials and establish the connection. Once connected, I want to see the database schema to see all available tables. For every existing table, I want to see a preview of the data and the column types.
Acceptance criteria

[x] The user can establish a connection to their Snowflake data warehouse by providing the necessary credentials.
[x] The user can retrieve the database schema and explore all available tables.
[x] The user can preview the data in the table and its data types.
[x] The dbt project in the backend is automatically set up

Non-functional requirements

[x] Connecting to the Snowflake takes less than 5 seconds.
[x] Loading the list of all available tables takes less than 5 seconds.
[x] Loading the preview of a table takes less than 5 seconds.
[x] In the preview of a table, up to 200 columns are displayed instantly.
[x] In the preview of a table, up to 300 rows are displayed instantly.

Resources and technical details
To establish the connection and interaction with Snowflake, we can use snowflake-connector-python.
The automatic dbt project setup should be integrated along the lines of #83 after it is merged. Dbt has an adapter for Snowflake as well.
API routes
To be able to select Snowflake, you need to add it to the data catalog.

[x] Test connection to data source
[x] Save credentials for data source
[x] Get hierarchy of database (schema, category, tables)
[x] Get preview of data in table

Designs
The designs are in the same manner as for #80.

Hi @mattigrthr I will love to work on this issue.

Awesome! 🙌🏽 Please create a fork and open the PR from there to the main repo (see our contributing guidelines). You can also create the PR as a draft early on before it's ready for review. Then it's easier to follow along in between. 🤓

Closed with #116

Only merged into dev atm. Reopening and closing when in master.


Reclaim IPs when node name is re-used

If we can see that a different peer was previously running with the same node name, mark it for reclaim.
This is a straightforward change to improve #3394, but not a full fix, which would involve storing the UID and dealing with upgrading from a previous version which didn't store it.

not a full fix

actually it doesn't seem that bad now: it doesn't let any other peers reclaim that node which is now replaced, but as long as Weave Net does start up on that node it will do the reclaim.

I rewrote that part so the map is not indexed by node-name.


[FIX] Process missing values separately

Closes #23

when row term is assigned to nb:MissingValue -> do not put it into "Levels" but directly append to MissingValues array
read columns for "value", "type" and "isPartOf" as string to about pandas converting types
change the order of column type checks in process_dict so is_tool() is checked before is_discrete() because the latter is so unspecific that it also captures is_tool cases (effectively rendering this category unaccessible if it is checked later)

@alyssadai thanks for spotting all these issues. I addressed the more direct ones here, and we'll address the bigger missingValue one separately in #28. Let me know if you have other comments or if we can merge


/pypi/{package}/{version}/json: yanking an older release updates latest release's yanked_reason field

Describe the bug
Yanking an older version of a package leads to unexpected side-effect for latest version's package info provided via the JSON endpoint. In particular, the yanked_reason field gets updated.
Expected behavior
When yanking a version of a package, no other verision's yanked_reason field should be updated.
To Reproduce

Create new package on test.pypi.org
Release version 0.2.0.
Release version 0.3.0.
Yank version 0.2.0.
Check json endpoint of package version 0.3.0.

$ curl -sL https://test.pypi.org/pypi/abn-test-rss-yank/0.3.0/json | jq '.info.yanked'
false
$ curl -sL https://test.pypi.org/pypi/abn-test-rss-yank/0.3.0/json | jq '.info.yanked_reason'
"Testing Yank"

My Platform
N/A
Additional context

Test package: https://test.pypi.org/project/abn-test-rss-yank/

This appears to be due to this line:
https://github.com/pypa/warehouse/blob/bd2b3a22f4f84072eb03abb771a88ddab1489e7a/warehouse/legacy/api/json.py#L193
The reference to r here is a remnant from this iterator:
https://github.com/pypa/warehouse/blob/bd2b3a22f4f84072eb03abb771a88ddab1489e7a/warehouse/legacy/api/json.py#L129
The fix should be as direct as changing the earlier line to release.yanked_reason.

Cheers for the quick fix @ewdurbin @di


radiobutton checked state

I would like to add checked state for radiobuttons.

@OlhaNikoliuk What's the status of this issue?


[Accessibility] Talkback does not announces/read string/description label over Text

React Native version: 0.55.4

Steps To Reproduce

Create a react native layout where a text is used inside a view/TouchableHighlight . Pasted below for references
without accessibility, normal operation this works out fine.. i see both read and "Details:- Not spoken" labels. Also clicking/tapping on "Details:- Not.." spoken button works as expected.
But when i turn on accessibility, talkback does not  navigate to the "Details:- ..", nor does it speaks/reads it. Both the text are visible though. Even tapping on "Details:- Not" does not takes the controls there.

Describe what you expected to happen:
while swapping left right, the navigation/highlight should go to "Details:- " button/text, so that user can enter it and see the details.
<View>
      <View >
        <View accessible={true} accessibilityLabel="READ">
          <Text style={styles.sendActionTextLabel}>"READ"</Text >
        </View>
        <TouchableHighlight onPress={this.MyPage.bind(this)} underlayColor='transparent' accessibilityTraits={'button'} accessibilityComponentType={'button'} >
          <Text accessible={true} style={styles.discoverButtonTextLabel} accessibilityLabel="Double tap to get details">"Details : - NOT SPOKEN BY ACCESSIBILITY or accessible either by swipes"</Text >
        </TouchableHighlight >
      </View>
  </View>

Is this still the case for version 0.59? What about 0.60-rc3?
If it doesn't happen on those versions anymore we can close this.


Hotel and Non Hotels Images

I added hotels and non hotels images

Please make changes on the conflicting files, rename them
training_images/hotels/hotel1.jpg
training_images/hotels/hotel2.jpg
training_images/hotels/hotel5.jpg


Update scalameta to 4.4.25

Updates org.scalameta:scalameta from 4.4.24 to 4.4.25.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalameta" } ]

labels: library-update, semver-patch

Codecov Report

Merging #31 (dc031a9) into main (f7a8c63) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   76.39%   76.39%
=======================================
  Files          17       17
  Lines         572      572
  Branches       20       29    +9
=======================================
  Hits          437      437
  Misses        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a8c63...dc031a9. Read the comment docs.


[Bug] [Triaged]: SwiftCurrent_CLI not building successfully in consuming iOS application

What happened?
While testing aspects of the new data-driven workflow feature, I created a brand new SwiftUI Project and added the SwiftCurrent, SwiftCurrent_SwiftUI, and SwiftCurrent_CLI dependencies via SPM.
Building after doing this resulted in 15 build errors in the SwiftCurrent_CLI target stemming from a library called "_InternalSwiftSyntaxParser". Likely due to this bit from the SwiftSyntax README:

Embedding SwiftSyntax in an Application

SwiftSyntax depends on the lib_InternalSwiftSyntaxParser.dylib/.so library which provides a C interface to the underlying Swift C++ parser. When you do swift build SwiftSyntax links and uses the library included in the Swift toolchain. If you are building an application make sure to embed _InternalSwiftSyntaxParser as part of your application's libraries.

You can either copy lib_InternalSwiftSyntaxParser.dylib/.so directly from the toolchain or even build it yourself from the Swift repository, as long as you are matching the same tags or branches in both the SwiftSyntax and Swift repositories. To build it for the host os (macOS/linux) use the following steps:

git clone https://github.com/apple/swift.git
./swift/utils/update-checkout --clone
./swift/utils/build-parser-lib --release --no-assertions --build-dir /tmp/parser-lib-build

Embedding in an iOS Application

You need to build lib_InternalSwiftSyntaxParser.dylib yourself, you cannot copy it from the toolchain. Follow the instructions above and change the invocation of build-parser-lib accordingly:

./swift/utils/build-parser-lib --release --no-assertions --build-dir /tmp/parser-lib-build-iossim --host iphonesimulator --architectures x86_64
./swift/utils/build-parser-lib --release --no-assertions --build-dir /tmp/parser-lib-build-ios --host iphoneos --architectures arm64

Version
SwiftCurrent Version 5.1.3
Xcode Version 13.3
macOS version 12.3
Relevant code sample
No response
Relevant log output
ld: warning: Could not find or use auto-linked library '_InternalSwiftSyntaxParser'
Undefined symbols for architecture x86_64:
  "_swiftparse_syntax_structure_versioning_identifier", referenced from:
      static SwiftSyntax.SyntaxParser.verifyNodeDeclarationHash() -> Swift.Bool in SwiftSyntax.o
  "_swiftparse_diagnostic_get_fixit", referenced from:
      closure #2 (Swift.UInt32) -> SwiftSyntax.FixIt in SwiftSyntax.Diagnostic.init(diag: Swift.UnsafeRawPointer, using: SwiftSyntax.SourceLocationConverter?) -> SwiftSyntax.Diagnostic in SwiftSyntax.o
  "_swiftparse_diagnostic_get_range", referenced from:
      closure #1 (Swift.UInt32) -> SwiftSyntax.SourceRange in SwiftSyntax.Diagnostic.init(diag: Swift.UnsafeRawPointer, using: SwiftSyntax.SourceLocationConverter?) -> SwiftSyntax.Diagnostic in SwiftSyntax.o
  "_swiftparse_diagnostic_get_message", referenced from:
      SwiftSyntax.Diagnostic.Message.init(Swift.UnsafeRawPointer) -> SwiftSyntax.Diagnostic.Message in SwiftSyntax.o
  "_swiftparse_diagnostic_get_range_count", referenced from:
      SwiftSyntax.Diagnostic.init(diag: Swift.UnsafeRawPointer, using: SwiftSyntax.SourceLocationConverter?) -> SwiftSyntax.Diagnostic in SwiftSyntax.o
  "_swiftparse_diagnostic_get_fixit_count", referenced from:
      SwiftSyntax.Diagnostic.init(diag: Swift.UnsafeRawPointer, using: SwiftSyntax.SourceLocationConverter?) -> SwiftSyntax.Diagnostic in SwiftSyntax.o
  "_swiftparse_parse_string", referenced from:
      closure #4 (Swift.UnsafePointer<Swift.Int8>) -> Swift.UnsafeMutableRawPointer? in static SwiftSyntax.SyntaxParser.(parseRaw in _FF480AC1827F0899EF1492D28392D5EA)(Swift.String, SwiftSyntax.IncrementalParseTransition?, Swift.String, SwiftSyntax.DiagnosticEngine?) -> SwiftSyntax.RawSyntax in SwiftSyntax.o
  "_swiftparse_diagnostic_get_source_loc", referenced from:
      SwiftSyntax.Diagnostic.init(diag: Swift.UnsafeRawPointer, using: SwiftSyntax.SourceLocationConverter?) -> SwiftSyntax.Diagnostic in SwiftSyntax.o
  "_swiftparse_diagnostic_get_severity", referenced from:
      closure #3 (Swift.UnsafeRawPointer?) -> () in static SwiftSyntax.SyntaxParser.(parseRaw in _FF480AC1827F0899EF1492D28392D5EA)(Swift.String, SwiftSyntax.IncrementalParseTransition?, Swift.String, SwiftSyntax.DiagnosticEngine?) -> SwiftSyntax.RawSyntax in SwiftSyntax.o
      SwiftSyntax.Diagnostic.Message.init(Swift.UnsafeRawPointer) -> SwiftSyntax.Diagnostic.Message in SwiftSyntax.o
  "_swiftparse_parser_create", referenced from:
      static SwiftSyntax.SyntaxParser.(parseRaw in _FF480AC1827F0899EF1492D28392D5EA)(Swift.String, SwiftSyntax.IncrementalParseTransition?, Swift.String, SwiftSyntax.DiagnosticEngine?) -> SwiftSyntax.RawSyntax in SwiftSyntax.o
  "_swiftparse_parser_set_node_handler", referenced from:
      static SwiftSyntax.SyntaxParser.(parseRaw in _FF480AC1827F0899EF1492D28392D5EA)(Swift.String, SwiftSyntax.IncrementalParseTransition?, Swift.String, SwiftSyntax.DiagnosticEngine?) -> SwiftSyntax.RawSyntax in SwiftSyntax.o
  "_swiftparse_parser_set_node_lookup", referenced from:
      static SwiftSyntax.SyntaxParser.(parseRaw in _FF480AC1827F0899EF1492D28392D5EA)(Swift.String, SwiftSyntax.IncrementalParseTransition?, Swift.String, SwiftSyntax.DiagnosticEngine?) -> SwiftSyntax.RawSyntax in SwiftSyntax.o
  "_swiftparse_parser_dispose", referenced from:
      $defer #1 () -> () in static SwiftSyntax.SyntaxParser.(parseRaw in _FF480AC1827F0899EF1492D28392D5EA)(Swift.String, SwiftSyntax.IncrementalParseTransition?, Swift.String, SwiftSyntax.DiagnosticEngine?) -> SwiftSyntax.RawSyntax in SwiftSyntax.o
  "_swiftparse_parser_set_diagnostic_handler", referenced from:
      static SwiftSyntax.SyntaxParser.(parseRaw in _FF480AC1827F0899EF1492D28392D5EA)(Swift.String, SwiftSyntax.IncrementalParseTransition?, Swift.String, SwiftSyntax.DiagnosticEngine?) -> SwiftSyntax.RawSyntax in SwiftSyntax.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

These will be useful in solving this:
https://forums.swift.org/t/unable-to-compile-lib-internalswiftsyntaxparser-myself-from-latest-commit/38020/10
https://github.com/apple/swift-syntax

The 5.7 version of Swift-Syntax should do even better at fixing this issue.


Prepare basic assets and create first testing map

For testing, create class / controller for loading maps from Tiled editor software

@mikolajszymczuk1 Load tile maps from tiled example:


Request parameters documentation is stripped when consuming application/x-www-form-urlencoded in 3.0.0

Please take the time to search the repository, if your question has already been asked or answered.

[x] What version of the library are you using? Is it the latest version? The latest released version is

What kind of issue is this?

[ ] Question. Is this a question about how to do a certain thing?

[x] Bug report. If you’ve found a bug, spend the time to write a failing test. Bugs with tests or
steps to reproduce get fixed faster. Here’s an example: https://gist.github.com/swankjesse/6608b4713ad80988cdc9

[ ] spring xml/java config that is relevant
[ ] springfox specific configuration if it makes sense
[x] include any output you've received; logs, json snippets etc.; and what the expected output should be
[x] if you have a repo that demonstrates the issue for bonus points! https://github.com/pimg/swagger-test/blob/master/src/main/java/com/example/swaggertest/MyController.java

[ ] Feature Request. Start by telling us what problem you’re trying to solve. Often a solution
already exists! Don’t send pull requests to implement new features without first getting our
support. Sometimes we leave features out on purpose to keep the project small.

Please do consider starring this repository if you do like this project and find it useful.

I have recently upgraded to version 3.0.0 but am still outputting Swagger version 2.0 reports.
After upgrading to version 3.0.0 I found out that my request parameters on an endpoint are not documented anymore.
Output
Pre 3.0.0 output: (wanted behavior)
...
    consumes: [
      "application/x-www-form-urlencoded"
    ],
    produces: [
      "application/json"
    ],
    parameters: [
      {
        name: "grant_type",
        in: "formData",
        description: "Grant type. Right now we only support 'client_credentials' value.",
        required: false,
        type: "string"
      },
      {
        name: "request_token",
        in: "formData",
        description: "Your JWT Request Token. Check docs to see how to generate it.",
        required: false,
        type: "string"
      }
    ]
...

3.0.0 output:
...
    consumes: [
      "application/x-www-form-urlencoded"
    ],
    produces: [
      "application/json"
    ],
    parameters: [
      {
        name: "grant_type",
        in: "formData",
        required: false,
        type: "string"
      },
      {
        name: "request_token",
        in: "formData",
        required: false,
        type: "string"
      }
    ],
...

Java code:
I've tried two options:

Old way (worked with pre-3.0.0)

@ApiOperation(value = "Request an access token", response = AccessTokenResponseDTO.class)
@PostMapping(value = "/tokens", consumes = APPLICATION_FORM_URLENCODED_VALUE, produces = APPLICATION_JSON_VALUE)
public AccessTokenResponseDTO getAccessToken(
        @ApiParam("Your JWT Request Token. Check docs to see how to generate it.")
        @RequestParam(value = "request_token")
                String requestToken,

        @ApiParam("Grant type. Right now we only support 'client_credentials' value.")
        @RequestParam(value = "grant_type")
                String grantType) {
    return null; // logic here
}

Using @ModelAttribute (@RequestBody also did not work)

@ApiOperation(value = "Request an access token", response = AccessTokenResponseDTO.class)
@PostMapping(value = "/tokens", consumes = APPLICATION_FORM_URLENCODED_VALUE, produces = APPLICATION_JSON_VALUE)
public AccessTokenResponseDTO getAccessToken(
        @ModelAttribute AccessTokenRequestDTO accessTokenRequestDTO) {
    return null; // logic here
}

@lombok.Data
public class AccessTokenRequestDTO {
    @ApiParam(name = "request_token", value = "Your JWT Request Token. Check docs to see how to generate it.")
    private String requestToken;

    @ApiParam(name = "grant_type", value = "Grant type. Right now we only support 'client_credentials' value.")
    private String grantType;
}

Test repository, with an even smaller example: https://github.com/pimg/swagger-test/blob/master/src/main/java/com/example/swaggertest/MyController.java

A workaround is adding a charset to the MediaType on the controller like so:
@PostMapping(value = "/tokens", consumes = "application/x-www-form-urlencoded;charset=UTF-8", produces = APPLICATION_JSON_VALUE)

Thanks for the detailed bug report!


Add support for expanding HTML5 named character references

Add support for expanding the HTML5 named character references, for example
The full list can be found here: https://www.w3.org/TR/html5/syntax.html#named-character-references
and a JSON form can also be found on that page.

This is outside of the scope of pugixml and will not happen. I recommend pre- or post-processing the data if you need to support HTML5 character references (pre-processing would involve expanding the HTML5 references in the document prior to parsing, post-processing would involve expanding the individual value strings as you read them from the document after parsing - correct post-processing involves using parse_no_escapes so that you can unescape the values manually).
There are three issues with supporting this:

pugixml is not an HTML parser; there is a number of missing features required to correctly parse HTML documents, as outlined in #106. The value of adding specifically named reference expansion is probably lower than adding any other feature because it's easy to work around its absence

The HTML character reference table is HUGE. pugixml parser core (sufficient to parse an XML document and pretty-print it to stdout) compiles to ~40 kB on Linux x64. I tried to make a reasonably size-efficient encoding that can be quickly searched through and the tables alone add up to ~67 kB. This is a non-starter as a feature that's compiled in. Obviously it can be compiled out by default, but at this point a pre-processor works just as well.

pugixml has a fundamental design assumption that the document is parseable inplace. For this assumption to hold any reference expansion has to result in a byte sequence that is not longer than the input. Two named references out of the HTML table, ≪⃒ and ≫⃒, expand to 6 bytes when encoded using UTF-8, which makes it impossible to parse some documents with these references.

Here's the aforementioned size-efficient encoding: https://gist.github.com/zeux/0c12a521b1c10637a2179126f1688782
This is not necessarily very performant; it'd probably be beneficial to replace the first phase lookup with a switch. Regardless, the tables are too big, and two of the references can't even be parsed in all cases.


Add OMIS Refund model

This only adds a Refund model with defined attrs so that we can migrate the records.

Codecov Report

Merging #582 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #582      +/-   ##
===========================================
+ Coverage    96.43%   96.44%   +<.01%
===========================================
  Files          123      123
  Lines         3707     3708       +1
  Branches       326      326
===========================================
+ Hits          3575     3576       +1
  Misses          94       94
  Partials        38       38

Impacted Files
Coverage Δ

datahub/omis/payment/constants.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe83db...e05511a. Read the comment docs.


Incorrect Time Format Fails Silently

I'm developing an app and a member of my team is using this lib to ingest JWT's that I generate.  We ran into an issue that providing exp and nbf times in an inappropriate format the lib fails silently about the failure to parse.  Not sure if this intended behavior but it caused us some headaches.

The library follows the RFC 7519 spec, and those claims are of type NumericDate representing an epoch time. What is the source token you're trying to decode/verify and what is the error that you're expecting?


Updating to current behavior

Closes https://github.com/MicrosoftDocs/office-docs-powershell/issues/7716

Docs Build status updates of commit f88d14a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsOnlineTimeRange.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@tseward

@Kateyanne Please merge this PR. Thanks

Docs Build status updates of commit 6ac67d8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsOnlineTimeRange.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 26e7da4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Closing and reopening to try to fix error

Docs Build status updates of commit 26e7da4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsOnlineTimeRange.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add iShowU.app v1.94.1

Added iShowU screen recorder application.

Seeing as url doesn’t point to a specific version, this cask should use version :latest and sha256 :no_check. See an example.

Thanks. Merged as df89f85.


fix!: handle error on metrics

I treated metrics initialization as like it's being run in init while it's not. Even if these are programmer bug errors, metrics initialization will happen after some other components have started, causing various artifacts if not stopped gracefully.

Codecov Report

Merging #123 (4716bc9) into main (27e85f9) will decrease coverage by 0.17%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   69.43%   69.27%   -0.17%
==========================================
  Files          37       37
  Lines        2971     2981      +10
==========================================
+ Hits         2063     2065       +2
- Misses        761      769       +8
  Partials      147      147

Files
Coverage Δ

p2p/subscriber.go
48.52% <100.00%> (ø)

p2p/metrics.go
13.79% <0.00%> (-1.03%)
:arrow_down:

sync/metrics.go
15.38% <0.00%> (-1.29%)
:arrow_down:

p2p/exchange.go
85.65% <0.00%> (-1.14%)
:arrow_down:

sync/sync.go
71.19% <0.00%> (-1.19%)
:arrow_down:

... and 1 file with indirect coverage changes


Linker command failed with exit code 1 (use -v to see invocation)

Description
ld: warning: Could not find or use auto-linked library 'swiftCompatibility50': library 'swiftCompatibility50' not found
ld: warning: Could not find or use auto-linked library 'swiftCompatibility51': library 'swiftCompatibility51' not found
ld: warning: Could not find or use auto-linked library 'swiftCompatibility56': library 'swiftCompatibility56' not found
ld: warning: Could not find or use auto-linked library 'swiftCompatibilityConcurrency': library 'swiftCompatibilityConcurrency' not found
ld: warning: Could not find or use auto-linked library 'swiftCompatibilityDynamicReplacements': library 'swiftCompatibilityDynamicReplacements' not found
ld: warning: Could not find or use auto-linked library 'swiftCompatibilityPacks': library 'swiftCompatibilityPacks' not found
ld: warning: Could not find or use auto-linked framework 'CoreAudioTypes': framework 'CoreAudioTypes' not found
Undefined symbols for architecture arm64:
"_swift_FORCE_LOAD$_swiftCompatibility50", referenced from:
_swift_FORCE_LOAD$swiftCompatibility50$_FirebaseAnalytics in FirebaseAnalytics17
_swift_FORCE_LOAD$swiftCompatibility50$_FirebaseCoreInternal in FirebaseCoreInternal4
_swift_FORCE_LOAD$swiftCompatibility50$_FirebaseCrashlytics in FirebaseCrashlytics85
_swift_FORCE_LOAD$swiftCompatibility50$_FirebaseRemoteConfig in FirebaseRemoteConfig18
_swift_FORCE_LOAD$swiftCompatibility50$_FirebaseRemoteConfigInterop in FirebaseRemoteConfigInterop4
_swift_FORCE_LOAD$swiftCompatibility50$_FirebaseSessions in FirebaseSessions6
_swift_FORCE_LOAD$swiftCompatibility50$_FirebaseSharedSwift in FirebaseSharedSwift4
...
"_swift_FORCE_LOAD$_swiftCompatibility51", referenced from:
_swift_FORCE_LOAD$swiftCompatibility51$_FirebaseAnalytics in FirebaseAnalytics17
_swift_FORCE_LOAD$swiftCompatibility51$_FirebaseCoreInternal in FirebaseCoreInternal4
_swift_FORCE_LOAD$swiftCompatibility51$_FirebaseCrashlytics in FirebaseCrashlytics85
_swift_FORCE_LOAD$swiftCompatibility51$_FirebaseRemoteConfig in FirebaseRemoteConfig18
_swift_FORCE_LOAD$swiftCompatibility51$_FirebaseRemoteConfigInterop in FirebaseRemoteConfigInterop4
_swift_FORCE_LOAD$swiftCompatibility51$_FirebaseSessions in FirebaseSessions6
_swift_FORCE_LOAD$swiftCompatibility51$_FirebaseSharedSwift in FirebaseSharedSwift4
...
"_swift_FORCE_LOAD$_swiftCompatibility56", referenced from:
_swift_FORCE_LOAD$swiftCompatibility56$_FirebaseAnalytics in FirebaseAnalytics17
_swift_FORCE_LOAD$swiftCompatibility56$_FirebaseCoreInternal in FirebaseCoreInternal4
_swift_FORCE_LOAD$swiftCompatibility56$_FirebaseCrashlytics in FirebaseCrashlytics85
_swift_FORCE_LOAD$swiftCompatibility56$_FirebaseRemoteConfig in FirebaseRemoteConfig18
_swift_FORCE_LOAD$swiftCompatibility56$_FirebaseRemoteConfigInterop in FirebaseRemoteConfigInterop4
_swift_FORCE_LOAD$swiftCompatibility56$_FirebaseSessions in FirebaseSessions6
_swift_FORCE_LOAD$swiftCompatibility56$_FirebaseSharedSwift in FirebaseSharedSwift4
...
"_swift_FORCE_LOAD$_swiftCompatibilityConcurrency", referenced from:
_swift_FORCE_LOAD$swiftCompatibilityConcurrency$_FirebaseAnalytics in FirebaseAnalytics17
_swift_FORCE_LOAD$swiftCompatibilityConcurrency$_FirebaseCoreInternal in FirebaseCoreInternal4
_swift_FORCE_LOAD$swiftCompatibilityConcurrency$_FirebaseCrashlytics in FirebaseCrashlytics85
_swift_FORCE_LOAD$swiftCompatibilityConcurrency$_FirebaseRemoteConfig in FirebaseRemoteConfig18
_swift_FORCE_LOAD$swiftCompatibilityConcurrency$_FirebaseRemoteConfigInterop in FirebaseRemoteConfigInterop4
_swift_FORCE_LOAD$swiftCompatibilityConcurrency$_FirebaseSessions in FirebaseSessions6
_swift_FORCE_LOAD$swiftCompatibilityConcurrency$_FirebaseSharedSwift in FirebaseSharedSwift4
...
"_swift_FORCE_LOAD$_swiftCompatibilityDynamicReplacements", referenced from:
_swift_FORCE_LOAD$swiftCompatibilityDynamicReplacements$_FirebaseAnalytics in FirebaseAnalytics17
_swift_FORCE_LOAD$swiftCompatibilityDynamicReplacements$_FirebaseCoreInternal in FirebaseCoreInternal4
_swift_FORCE_LOAD$swiftCompatibilityDynamicReplacements$_FirebaseCrashlytics in FirebaseCrashlytics85
_swift_FORCE_LOAD$swiftCompatibilityDynamicReplacements$_FirebaseRemoteConfig in FirebaseRemoteConfig18
_swift_FORCE_LOAD$swiftCompatibilityDynamicReplacements$_FirebaseRemoteConfigInterop in FirebaseRemoteConfigInterop4
_swift_FORCE_LOAD$swiftCompatibilityDynamicReplacements$_FirebaseSessions in FirebaseSessions6
_swift_FORCE_LOAD$swiftCompatibilityDynamicReplacements$_FirebaseSharedSwift in FirebaseSharedSwift4
...
ld: symbol(s) not found for architecture arm64
Showing Recent Errors Only
Undefined symbol: _swift_FORCE_LOAD$_swiftCompatibility50
Undefined symbol: _swift_FORCE_LOAD$_swiftCompatibility51
Undefined symbol: _swift_FORCE_LOAD$_swiftCompatibility56
Undefined symbol: _swift_FORCE_LOAD$_swiftCompatibilityConcurrency
Undefined symbol: _swift_FORCE_LOAD$_swiftCompatibilityDynamicReplacements
Linker command failed with exit code 1 (use -v to see invocation)
我使用cocospods 升级firebase到10.25.0版本 报错
我按照readme 操作Other Linker Settings 天际了-ObjC和-lc++ 也添加了空的swift文件 依然解决不了我的问题,希望能解决我的问题
Reproducing the issue
Showing Recent Errors Only
Undefined symbol: _swift_FORCE_LOAD$_swiftCompatibility50
Undefined symbol: _swift_FORCE_LOAD$_swiftCompatibility51
Undefined symbol: _swift_FORCE_LOAD$_swiftCompatibility56
Undefined symbol: _swift_FORCE_LOAD$_swiftCompatibilityConcurrency
Undefined symbol: _swift_FORCE_LOAD$_swiftCompatibilityDynamicReplacements
Linker command failed with exit code 1 (use -v to see invocation)
Firebase SDK Version
10.25.0
Xcode Version
15.4
Installation Method
CocoaPods
Firebase Product(s)
AB Testing, Analytics, Crashlytics, DynamicLinks, Installations, ML Model Downloader, Remote Config
Targeted Platforms
iOS
Relevant Log Output
Showing Recent Errors Only
Undefined symbol: __swift_FORCE_LOAD_$_swiftCompatibility50

Undefined symbol: __swift_FORCE_LOAD_$_swiftCompatibility51

Undefined symbol: __swift_FORCE_LOAD_$_swiftCompatibility56

Undefined symbol: __swift_FORCE_LOAD_$_swiftCompatibilityConcurrency

Undefined symbol: __swift_FORCE_LOAD_$_swiftCompatibilityDynamicReplacements

Linker command failed with exit code 1 (use -v to see invocation)

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

I am also facing the same issue

Please see if anything in the discussion at #12603 helps.

在项目中添加一个swift文件就可以了


Generated plugin doesn't work with stable Kibana version

Hi, I've just cloned Kibana 5.0 branch and wanted to use plugin, generated with this generator, but it won't start with current kibana version, as it's 5.0.1 in 5.0 branch and plugin-helper wants 5.0.0:
npm start

><EMAIL_ADDRESS>start /home/isergiichuk/Projects/test-plugin
> plugin-helpers start

 watching for changes  (298 files)
  log   [14:40:17.585] [info][listening] basePath Proxy running at https://localhost:5601/uol
server    log   [14:40:19.800] [warning] Plugin "test_plugin" was disabled because it expected Kibana version "5.0.0", and found "5.0.1".
optmzr    log   [14:40:19.837] [warning] Plugin "test_plugin" was disabled because it expected Kibana version "5.0.0", and found "5.0.1".

After changing version in package.json from 5.0.0 to 5.0.1 everything will work again.
Probably, this should somehow be handled by generator, am I right ?

Yeah, all you need to do is update the kibana version in your package.json and it will be golden. We haven't quite worked out the best way to generate plugins for specific versions of kibana...

Related to https://github.com/elastic/generator-kibana-plugin/issues/50
This is fixed in the template by using a text input.


fix: remove unused variables, do clean up work

Just some clean up before the project increase in complexity

Thanks for the pull request, @Ian2012!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


nginx listen on specific ip

Info:

Docker version ($ docker --version): Docker version 18.09.1, build 4c52b90
Laradock commit ($ git rev-parse HEAD): 50b6272ffffd0f75b6b8af81d842542c96dc8182
System info (Mac, PC, Linux): Linux
System info disto/version: Debian 10

Issue:
Hello! I'm using laradock to server several projects. Each project should listen on their own ip (<IP_ADDRESS>, <IP_ADDRESS>, 192.168.1...). Currently nginx container listening on all ip addresses. How i can make what i want? Port forward on the host? All configs are default. Thanks!

Look at this: https://serverok.in/configure-nginx-to-listen-on-single-ip-address
I presume you're using it on development machine. Why don't you just use domain names like project1.local, project2.local in nginx config and add those entries to hosts file?


Where are these non-2023 SWH data coming from?!?

The following folders of data are being written by L1:
SWH_2024
SWH_2032
SWH_2023
SWH_2019

This looks like a problem in the raw data?

@roylrich Is this a known thing?

I looked at this whole file. The loggers were placed for a while before the instrumentation attached. As soon as it has data, the time shifts to correct time in this file. The time is coordinated by server and so we did not have coms at transition until cell was installed later on.  The out time data could be removed in this case with no loss.
RR

Thanks. Is there a known "good data start" point in time?
Also, is it OK if I do delete the bad-timestamp data right in the original Dropbox data? I don't want it creeping back in later.

Good start:
"2023-04-03 15:00:00",975,422,"COMPASS_SWH_TR","813IN-SITU AT600V232 1",763.9,13.08,1858.9,2406.8,1.24,1.56,1,537.96,0,482.3,195.3,0.34,3.21,3.9,1.086,95.48,11.371,97
I actually need to think about the best way to do this. The data is mirrored to dropbox and google drive from a folder on my server. I think it would be replaced by the file from my server if we change it on dropbox.

Okay. I'm going to leave this issue open for now, then. Thanks.

Is this just in this file or can you give me a list of files with this date. I will be do edits on server when I get on next

@roylrich Most of the initial 2023-04-08 files have this problem:

Compass_SWH_TR_422_CheckTable_20230408000350.dat - lines 5-976 are bad
Compass_SWH_TR_422_SapflowB_20230408000353.dat - lines 5-976 are bad
Compass_SWH_TR_422_TerosTableA_20230408000356.dat - file OK but no data
Compass_SWH_TR_422_TerosTableB_20230408000358.dat - lines 5-976 are bad
Compass_SWH_TR_422_WaterLevel600A_20230408000401.dat - file OK but no data
Compass_SWH_TR_422_WaterLevel600C_20230408000406.dat - file OK but no data
Compass_SWH_UP_423_CheckTable_20230408000409.dat  - lines 5-4029 are bad
Compass_SWH_UP_423_SapflowA_20230408000412.dat  - lines 5-4029 are bad
Compass_SWH_UP_423_TerosTableA_20230408000414.dat  - lines 5-4029 are bad
Compass_SWH_UP_423_WaterLevel600A_20230408000417.dat  - lines 5-4029 are bad
Compass_SWH_W_421_CheckTable_20230408000419.dat - lines 5-3744 are bad
Compass_SWH_W_421_ClimaVue50_15min_20230408000422.dat - lines 5-3744 are bad
Compass_SWH_W_421_ClimaVue50_24hr_20230408000425.dat  - lines 5-43 are bad
Compass_SWH_W_421_ExoTable_20230408000427.dat  - lines 5-4029 are bad
Compass_SWH_W_421_TerosTableC_20230408000430.dat  - lines 5-4029 are bad
Compass_SWH_W_421_WaterLevel600C_20230408000432.dat  - lines 5-3744 are bad

It might be simplest to delete all the 20230408 files.

For the 0-9 release, I will simply drop the April 8th files from SWH. @roylrich will deal with this on his end by editing/deleting.


Handle circular reference detection for Strings with same reference

For issue #101 it looks like boxed primitives were handled separately due to the caching of certain values (e.g. small integers). I believe this issue also applies to Strings (due to String interning).
The fix may be as simple as adding String to the map(s) in this static block:
https://github.com/jhalterman/modelmapper/blob/master/core/src/main/java/org/modelmapper/internal/util/Primitives.java#L37
This is the test mentioned on issue #15 (linked in issue #101) modified for Strings:
public class Test {
public static void main(String args[]){
    // Create mapper
    ModelMapper mapper = new ModelMapper();

    // Add custom converter mapping on Integer
    mapper.addConverter(new AbstractConverter<String, ComplexObject>() {
        @Override
        protected ComplexObject convert(String source) {;
            return new ComplexObject(source);
        }
    });

    // Create a source object with two integers wrapping the SAME VALUE
    SourceObject sourceObject = new SourceObject("10", "10");

    // Create a destination (no matter its params)
    DestinationObject destinationObject =  new DestinationObject("30", new ComplexObject("40"));

    // Map the source to the destination
    // => Because of https://www.owasp.org/index.php/Java_gotchas#Immutable_Objects_.2F_Wrapper_Class_Caching
    // complexObject and id are seen like the same value by the circular reference mechanism.
    mapper.map(sourceObject, destinationObject);
}

static class SourceObject {
    private String complexObject;
    private String id;
    public SourceObject(String id, String complexObject) {
        this.id = id;
        this.complexObject = complexObject;
    }
    public String getComplexObject() {
        return complexObject;
    }
    void setComplexObject(String complexObject) {
        this.complexObject = complexObject;
    }
    public String getId() {
        return id;
    }
    public void setId(String id) {
        this.id = id;
    }
}

static class DestinationObject {
    private ComplexObject complexObject;
    private String id;
    public DestinationObject(){/*non-private no-argument constructor for mapping*/};
    public DestinationObject(String id, ComplexObject complexObject) {
        this.id = id;
        this.complexObject = complexObject;
    }
    public ComplexObject getComplexObject() {
        return complexObject;
    }
    public void setComplexObject(ComplexObject complexObject) {
        this.complexObject = complexObject;
    }
    public String getId() {
        return id;
    }
    public void setId(String id) {
        this.id = id;
    }
}

static class ComplexObject {
    private String id;
    public ComplexObject(String id){
        this.id = id;
    }
}

}

Cannot reproduce it with master branch ModelMapper.
I think it might be fixed by #177 .
Feel free to reopened if still have problem, thank you!


Crash on "Popups" tab.

After clicking on Popups tab in admin there is following error:
TypeError
destroy is not a function
Call Stack
 safelyCallDestroy
  webpack-internal:///10344:22927:5
 commitHookEffectListUnmount
  webpack-internal:///10344:23095:11
 commitPassiveUnmountInsideDeletedTreeOnFiber
  webpack-internal:///10344:25093:11
 commitPassiveUnmountEffectsInsideOfDeletedTree_begin
  webpack-internal:///10344:25043:5
 commitPassiveUnmountEffects_begin
  webpack-internal:///10344:24951:11
 commitPassiveUnmountEffects
  webpack-internal:///10344:24936:3
 flushPassiveEffectsImpl
  webpack-internal:///10344:27033:3
 flushPassiveEffects
  webpack-internal:///10344:26979:14
 commitRootImpl
  webpack-internal:///10344:26930:5
 commitRoot
  webpack-internal:///10344:26677:5

From developer console I see that error is coming from CookieTab component.
Strapi version: 4.11.0
Plugin version: 1.1.2

@Vethavear Thanks for reporting! I will look into it as soon as possible.

Hi everyone, the issue has been solved by cef52eef in version 1.2.2. Thanks for reporting the issue


[multi-texture] Animation bugs

I found 2 bugs within the multi-texture skybox type.

If you add multiple animation objects with different textures, the texture used for the first animation will be used for all animations, overriding all other ones.

frameDuration doesn't work. Only the duration parameter can be used to specify the animation speed.

Edit: Here's an example pack. multi_texture.zip
It has 8 different lightning animations with different timings and textures (see configs), however you'll see the same texture flashing all at the same time.

Fixed in https://github.com/AMereBagatelle/fabricskyboxes/commit/9a271a90efe2d274796188e3ec7ce1e78d91d405


CiliumIdentities (in CRD) are never GC

https://github.com/cilium/cilium/blob/32d6166f7f0dd4bf1fdbc5953c6d5ebe19b1c6d1/pkg/k8s/identitybackend/identity.go#L207-L209

Fixed #9152

@aanm is it really fixed ? The function still return nil :thinking:
I have a cluster with more than 50 000 entries of cilum identity in etcd


Make tofino work on windows again

For the UA service to be completely detached and outlive the parents on all platforms it can't share any stdio with the parent.
Apparently ignoring just stdin breaks process spawning on Windows.
Fixes #578

I haven't testing this on OSX but this makes things work right on Windows.

Coverage remained the same at 42.516% when pulling e8047ffe146e8cd9bc586b4cefc11ad546b91ca2 on Mossop:fixwindows into b32d798abd1b445d5bde6a70ecf5cbce216436dd on mozilla:master.

Looks good -- confirmed it works in OSX with Twofinos


Upgrade path to Pydantic 2.0

Major path updates include:

frontend:

Node 16 to 18
Latest Pinia requires changes in stores, where imports are not required (cause actual errors), and parameter declaration must happen in functions.

backend and celeryworker:

Python 3.9 to 3.11
FastAPI 0.88 to 0.99 (Inboard 0.37 to 0.51)
Poetry to Hatch
Postgres 14 to 15

Review required on the new hatch pyproject.toml file, and to ensure that the environments are stable. @br3ndonland, I'd appreciate your review.

The fix to frontend is related to a Vite error: https://github.com/scj2000/scj2000-web-v2/commit/b923143c106e352954771e19053d8eaddb414dbe


Improve Date range selector

#1306
Checklist

[x] the [contributor license agreement][] is signed
[x] commit message follows [commit guidelines][]
[ ] tests are included
[x] screenshots are included showing significant UI changes
[ ] documentation is changed or added

Description of change
Here are some improvements made for the Date range selector. However, the component becomes a lot more complicated accordingly. So I am still thinking if these improvements are worth to have.

Used KeyboardDatePicker to allow type and clear a date. But in order to properly use it, state is required, which increases complexity.
Changed to default picker labels to from and to.
Added a util function to help convert a date object to a string in ISO format. The reason is Javascript native function toISOString changes the time to UTC time,  which may result in incorrect search results.

Merged in although a flaky test MyResourcesTest failed.


TxQ full queue RPC info (RIPD-1404):

RPC ledger command returns all queue entries in "queue_data"
when requesting open ledger, and including boolean "queue: true".

Includes queue state. e.g.: fee_level, retries, last_result, tx.
Respects "expand" and "binary" parameters for the txs.

Remove some unused code.

Some sample Json output:
{
	"ledger" :
	{
		"closed" : false,
		"ledger_index" : "20",
		"parent_hash" : "AFE6058DD09B7320D2B3DDF8DDA1022F0ECC0EAF910ACB609FF5F5F7DD3A7A2E",
		"seqNum" : "20"
	},
	"ledger_current_index" : 20,
	"queue_data" :
	[

		{
			"account" : "rG1QQv2nh2gr7RCZ1P8YYcBUKCCN633jCn",
			"fee_level" : "256",
			"last_result" : "terPRE_SEQ",
			"preflight_result" : "tesSUCCESS",
			"retries_remaining" : 1,
			"tx" : "1B2C73099795359F8A14F81721C1995E955818F7A48DC36DB2CE03B32EF0308B"
		}
	],
	"status" : "success",
	"validated" : false
}

{
	"ledger" :
	{
		"closed" : false
	},
	"ledger_current_index" : 11,
	"queue_data" :
	[

		{
			"account" : "rG1QQv2nh2gr7RCZ1P8YYcBUKCCN633jCn",
			"auth_change" : false,
			"fee" : "10",
			"fee_level" : "256",
			"last_result" : "terPRE_SEQ",
			"max_spend_drops" : "10",
			"preflight_result" : "tesSUCCESS",
			"retries_remaining" : 8,
			"tx" :
			{
				"tx_blob" : "1200072400000008644000000BA43B740065D551C37937E080000000000000000000000000005553440000000000AE123A8556F3CF91154711376AFB0F894F832B3D68400000000000000A73210388935426E0D08083314842EDFBB2D517BD47699F9A4527318A8E10468C97C0527447304502210091222BAB6E5D8C0325D943600C7EBD55C8CB3AA110C71C415613B28CCCC4EB180220543AD25D2C695749F89448B1CCCB918A0CD0EE992A7B0807E2170B3B2E75B80B8114AE123A8556F3CF91154711376AFB0F894F832B3D"
			}
		},

		{
			"account" : "rG1QQv2nh2gr7RCZ1P8YYcBUKCCN633jCn",
			"fee_level" : "256",
			"preflight_result" : "tesSUCCESS",
			"retries_remaining" : 10,
			"tx" :
			{
				"tx_blob" : "120003240000000968400000000000000A73210388935426E0D08083314842EDFBB2D517BD47699F9A4527318A8E10468C97C0527446304402204F4D61DD5BBD1CC0468B3302A303AF732FA0887B817FC9CCCBF315CFE609BC3102202DA25B6EDD5E0DB263DE20EC59886477A88786E46F998C8918A88FC7D8C530CF8114AE123A8556F3CF91154711376AFB0F894F832B3D"
			}
		}
	],
	"status" : "success",
	"validated" : false
}

Codecov Report

Merging #2020 into develop will increase coverage by 0.09%.
The diff coverage is 90.09%.

@@             Coverage Diff             @@
##           develop    #2020      +/-   ##
===========================================
+ Coverage    67.27%   67.37%   +0.09%
===========================================
  Files          683      683
  Lines        49231    49267      +36
===========================================
+ Hits         33121    33193      +72
+ Misses       16110    16074      -36

Impacted Files
Coverage Δ

src/ripple/rpc/impl/Handler.cpp
97.61% <ø> (-0.06%)
:x:

src/ripple/rpc/impl/RPCHandler.cpp
61.84% <ø> (+14.36%)
:white_check_mark:

src/ripple/rpc/impl/Handler.h
20% <ø> (ø)
:white_check_mark:

src/ripple/app/misc/TxQ.h
96.87% <100%> (+0.1%)
:white_check_mark:

src/ripple/app/misc/impl/TxQ.cpp
96.25% <100%> (+0.52%)
:white_check_mark:

src/ripple/app/ledger/LedgerToJson.h
100% <100%> (ø)
:white_check_mark:

src/ripple/rpc/handlers/LedgerHandler.h
70.58% <100%> (ø)
:white_check_mark:

src/ripple/app/ledger/impl/LedgerToJson.cpp
88% <79.16%> (+15.27%)
:white_check_mark:

src/ripple/rpc/handlers/LedgerHandler.cpp
91.89% <94.73%> (+1.56%)
:white_check_mark:

src/ripple/app/misc/impl/LoadFeeTrack.cpp
81.53% <ø> (-4.62%)
:x:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209fe8f...ae7aba6. Read the comment docs.

Nice coverage bump

@miguelportilla Thanks for the feedback! I rebased on to 0.60.0-rc4, and pushed a new commit to make those suggested changes.

Rebased again onto 0.60.0.

Squashed and marked Passed.

Merged to develop as<PHONE_NUMBER>2ebff63ee226c3cbb3fba75f8a9058


Remove trait shim needed before Path stabilized

Now that Path has stabilized in Rust 1.5, I removed the UUPathExt trait
needed to support stable, beta, and nightly.

Thanks!


Upgrade momentjs platform

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?

[ ] No, I'm not changing any folders (skip to Summary and delete the rest of this section)
[ ] Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).
If an entry for this folder exists in content-build and you are:

Deleting a folder:

First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!

Add the link to your merged vets-website PR here

Then, Delete the application entry in registry.json and merge that PR before this one

Add the link to your merged content-build PR here

Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

:warning: TeamSites :warning:
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.
Did you change site-wide styles, platform utilities or other infrastructure?

[ ] No
[ ] Yes, and I used the proxy-rewrite steps to test the injected header scenario

Summary

(Summarize the changes that have been made to the platform)
(If bug, how to reproduce)
(What is the solution, why is this the solution)
(Which team do you work for, does your team own the maintenance of this component?)
(If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

Link to ticket created in va.gov-team repo
department-of-veterans-affairs/va.gov-team#0000
Link to previous change of the code/bug (if applicable)
department-of-veterans-affairs/vets-website#0000
Link to epic if not included in ticket
department-of-veterans-affairs/va.gov-team#0000

Testing done

Describe what the old behavior was prior to the change
Describe the steps required to verify your changes are working as expected
Describe the tests completed and the results
_Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
Optionally, provide a link to your test plan and test execution records

Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before
After

Mobile

Desktop

What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing

[ ] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
[ ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
[ ] Linting warnings have been addressed
[ ] Documentation has been updated (link to documentation *if necessary)
[ ] Screenshot of the developed feature is added
[ ] Accessibility testing has been performed

Error Handling

[ ] Browser console contains no warnings or errors.
[ ] Events are being sent to the appropriate logging solution
[ ] Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

[ ] Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Overlapped with other platform work, closing


Add an editorconfig file

From http://editorconfig.org/:
"EditorConfig helps developers define and maintain consistent coding
styles between different editors and IDEs. The EditorConfig project
consists of a file format for defining coding styles and a collection of
text editor plugins that enable editors to read the file format and
adhere to defined styles."
I tried my best to derive the specific settings from the Leaflet source
code.
I'm a bit unsure whether Leaflet uses lf or crlf though, there seems to
be a bit of both. :)

Adding the configuration at a higher level is a good idea, but it forces you to create a master folder.
What about adding ".editorconfig" to .gitignore? This would allow everyone to add his own editorconfig to the root folder without adding "noise" to the repository.
Maybe it's time to rethink this issue, as editorconfig is more established after three years.
If not, here's a configuration that fullfills the current lint configuration:
# http://editorconfig.org
root = true

[*]
indent_style = tab
indent_size = 4
end_of_line = crlf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true


add qff mockup

I decided to have a go at doing one of the pages from the Qantas app.
Source (iOS):

I used some assets from their apk but did not bother to recolor them so there are a few inconsistencies but not material (ha ha) to this challenge. I also used '>' instead of the graphic to go faster. I altered one aspect of the source image to remove information given it has my details on it.
What went well?
Overall, it was pretty easy to put this layout together (that said, the code took many shortcuts and this screen would better be coded with templates etc). If I didn't have trouble hiding the navbar (spoilers for next question: I did), it would have looked something like this (edited to remove the nav):

which I think is pretty nice. Ignoring the navbar, it was very satisfying to build this on iOS and then find that many things 'just looked right' on android immediately.
What went less well?
Hiding the Navigation Bar:
The truth is, without hacks/post image editing, the pages actually looked like this:

So yeah, I had trouble hiding the navigation bar. It could be something I missed (I use native embedding so typically manage navigation bar and the 'shell' of the app from native code). In this case I tried Shell.NavBarIsVisible="False" in the Shell definition, and Xamarin.Forms.NavigationPage.SetHasNavigationBar(this, false);, but neither seemed to have the desired effect.
Default Values:
In most cases I explicitly specified text colour but you can see that where I didn't "Hello Ryan K" and "Trip to Melbourne", the colours that come out on each platform were different. My expectation for Visual is that they would be the same.
Customising tab bar:
This is probably something I'm just not across how to do - but I wasn't sure how to customise font/ size for the tabbar items. This is probably the biggest visual difference between the iOS and Android screenshots and I think that if I had customised the font and image size they would have ended up looking more consistent. However, similar to the previous point, I'd still expect that in lieu of any explicit configuration I should get tabbars that look the same.
Overall
I had fun mocking this up and it was my first exposure to both Visual and Shell. Based on my understanding of what Visual aims to achieve, I think my main piece of feedback would be that I think defaults for things like text colours should be consistent across platforms.

Love it! And great to see a XAML-free entry!
So the hiding of the navigation bar in this case can be done on the ContentPage like this:
Shell.SetNavBarIsVisible(this, false);

Doing it in the OnAppearing results in a content shift, so I did it in the constructor.
However it is resulting in still showing the status bar, so I set a negative margin of -44 to swallow it up. I think that still is something we should look at.

Customizing font/size and really anything at this point with the tab bar requires a platform renderer. This is a top request to provide a template for this, or at least expose more styles.
Colors - yes, this is a common theme across all the PRs. We'll get that fixed.

Aha! Too easy - thanks for that.
One other thing I thought of is that is small but significant is the Visual/Material default appearance for Frame. In standard forms you put a frame on the page and immediately have to fiddle with it to turn it into something a little more tasteful. The Visual frame is subtle and nice out of the box, which clued me into thinking that tasteful defaults make a lot of sense for Visual. Things like margin/padding, fonts (idk how easy bundling fonts would be) are all potentially part of the material theme, so it could make sense to default them (maybe you already are).
It was getting late last night so I mostly focused on the issues but I really liked working with Visual and next File -> New I think I'd start with it turned on 🤓


Integrate with Google Fit or Runkeeper APIs?

Research indicated we'll try to integrate Runkeeper's HealthGraph API
https://runkeeper.com/developer/healthgraph
And the relevant .NET library https://github.com/Tron5000/HealthGraphNet/


Add support for builds without amd64

Still needs unit tests for pulp_pull plugin changes, but this is pretty much what I have in mind for allowing builds without x86_64 platform. Any early feedback would be greatly appreciated. Thanks!
This PR is ready for review. It provides two main functionalities:

Ability to override buildroot image for a given platform via reactor config map.
Allow pulp_pull plugin to handle builds where only manifest list digest is available.

The commit "Add goarch to platform mapping" also includes get_build_image_override(). Should that be in a separate commit, or should the commit message be updated to mention it? I'm fine with either or none so I'll approve.

It was incorrectly moved to that commit. Moved than hunk to commit "Add build_image_override reactor configuration"


DNM: test trigger ci on release-7.5

What problem does this PR solve?

Issue Number: close #xxx
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/test all

Wait until the tikv & tiflash binary build been completed.

/test all

/test all

/retest


Is there any easy way to push&pull dictionary objects for kvstore?

I'm trying to convert and extend autoencoder example for distributed training in multi-machines. I have to keep args, args_grad etc. in kvstore. However, KVStore API supports only integer keys, not support string keys. This makes my job difficult. Is there any easy way to push&pull a dictionary object for kvstore?

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!

related issue: https://github.com/apache/incubator-mxnet/issues/8224


fix sa_sigaction signature

The signature for sa_sigaction shoud be extern "C" fn(libc::c_int, *mut libc::siginfo_t, *mut libc::c_void).

Thanks for the PR! I think though that this is handled above with the SA_SIGINFO flag check. The fall-through case you modified is when the signal handler isn't registered with all three arguments.

Thanks, good to know!


Modal box closing when clicked on Scroll bar

Modal box closing when clicked on Scroll bar (Chrome / Win 7). Able to scroll modal with mouse wheel, but can't scroll with scroll bar because of the fix #13816
This is working fine on 3.2.0

I think this issue is back again in version 3.3.2.

Hi, it appears I'm experiencing this issue, but only in IE and Firefox.
I've got a collapsed menu with an icon to open a modal with a sub-menu. Clicking on the scroll bar closes the modal, but using the mouse's scroll wheel works.
Currently using 3.1.1 (I know it's a bit outdated, but I'm working on a project that we aren't able to upgrade at this point). Can anyone advise a solution/workaround? Thanks!

I think this issue is back again in version 3.3.2.

@trinzia If you are still seeing problems in 3.3.5, please open a new issue. Thanks!

@mjohnson290 Please ask that sort of question on StackOverflow, IRC, or Slack, rather than this bug tracker. See the "Community" section of the README for pointers. Thanks!


[FloatingActionButton] Tooltip

Can't achieve to have a Floating action button with tooltip.
I saw the component has not tooltip prop, so try to insert an IconButton inside but didn't work for me..
so tried to use an IconButton but it has no onClick event so..
Anyway to have an circled button with hover and onClick?

Icon button + simply onClick is my best achieve at the moment ^^
Have to change all my floating action buttons to icon buttons

:+1:  FloatingActionButton should have tooltip prop

+1 FloatingActionButton must have tooltip prop

Maybe we should have a Tooltip component

It would ease things, but for now I'm using this fab(syntax modified to conform to my linter settings)
https://gist.github.com/kress95/6207799dedc128470392

@oliviertassinari we have a Tooltip component now I believe.. do you know how might that be used to achieve this use case?

duplicate of #1366. Closing


Jin/OIDC refactor

Changes introduced:

Updated the es-apim.yml to include the Azure Login task configured for OIDC as well as the id-token: write permissions
Changed secret name AZURE_SUBSCRIPTION to AZURE_SUBSCRIPTION_ID
Added exclude path for terraform-related directories:
'!reference-implementations/AppGW-IAPIM-Func/terraform*'

Member

updated the docs/README to reflect the new subscription id secret name

I've added some adjustments to the deployment readme for the switch to OIDC. @JinLee794 are you able to verify this lines up to what you configured? Might need to pick your brains on section 4 so we can make it more specifc.

I've added some adjustments to the deployment readme for the switch to OIDC. @JinLee794 are you able to verify this lines up to what you configured? Might need to pick your brains on section 4 so we can make it more specifc.

Yes, thank you for adjusting the documentation!
I think for section #4, we could leverage the existing documentation to populate this section -https://github.com/MicrosoftDocs/azure-dev-docs/blob/main/articles/github/connect-from-azure.md

@briggsb9 - updated the federated credentials section

@JinLee794 Might have our wires crossed sorry! I had already added parts of that doc in an attempt to make our readme a little more succinct and relevant as I thought it scanned better. Let me know if it didn't scan well.

@JinLee794 Might have our wires crossed sorry! I had already added parts of that doc in an attempt to make our readme a little more succinct and relevant as I thought it scanned better. Let me know if it didn't scan well.

Yes, agreed on the doc improvements! I have also updated the federated credentials part (section 4) so please take a look. If all else looks good, I think we are good to approve and merge.

Thanks @JinLee794. Just corrected the heading sizes.
Which option is relevant to our pipeline when setting the subject in section 4? I think we can trim this down to make it more specific and make the guide a little easier to follow.
The value of this is defined by GitHub depending on your workflow:


can you add localization for arabic

is there a way to change the locale of the numbers ?

Hi @rulefahd , You can override each digit with digitsNumber property. it should overwrite 0-9.
try in lastest ver slide_countdown: ^0.2.3
 digitsNumber: ['٠', '١', '٢', '٣', '٤', '٥', '٦', '٧', '٨', '٩'],

Great job , Thank you


yamlark

DO NOT MERGE, still testing
Can't test if this works yet because main seems to be broken.
The parser is kind of disgusting, but it works 🤷♂ .

It looks like I need to support sequences. Found a case.

Almost there, but there's still a case I'm missing.

Oh no....


User update  throws validation exception

I have following user schema:
Schema.User = new SimpleSchema({
  emails: {
      type: [Object],
      // this must be optional if you also use other login services like facebook,
      // but if you use only accounts-password, then it can be required
      optional: true
  },
  services: {
      type: Object,
      optional: true,
      blackbox: true
  },
  "emails.$.address": {
      type: String,
      regEx: SimpleSchema.RegEx.Email
  },
  "services.$.password": {
    type: String,
    min: 6,
  },
  createdAt: {
      type: Date
  },
  profile: {
      type: Object
  },
  articles: {
      type: [String],
      optional: true
  },
  categories: {
      type: [String],
      optional: true
  }
});

And when I want to do:
Meteor.users.update({_id: user._id}, {$set: { 'user.articles': articleIds }});

I get following exception:
I20150423-16:49:16.112(-4)? Exception while invoking method 'bootstrapArticles' Error: When the modifier option is true, validation object must have at least one operator
I20150423-16:49:16.113(-4)?     at checkModifier (packages/aldeed:simple-schema/simple-schema-validation.js:271:1)
I20150423-16:49:16.113(-4)?     at doValidation1 (packages/aldeed:simple-schema/simple-schema-validation.js:321:1)
I20150423-16:49:16.113(-4)?     at doValidation (packages/aldeed:simple-schema/simple-schema-context.js:9:1)
I20150423-16:49:16.113(-4)?     at SimpleSchemaValidationContext.simpleSchemaValidationContextValidate [as validate] (packages/aldeed:simple-schema/simple-schema-context.js:44:1)
I20150423-16:49:16.113(-4)?     at [object Object].doValidate (packages/aldeed:collection2/collection2.js:317:1)
I20150423-16:49:16.113(-4)?     at [object Object].Mongo.Collection.(anonymous function) [as update] (packages/aldeed:collection2/collection2.js:154:1)
I20150423-16:49:16.113(-4)?     at app/server/article.js:25:20
I20150423-16:49:16.113(-4)?     at Array.forEach (native)
I20150423-16:49:16.113(-4)?     at Function._.each._.forEach (packages/underscore/underscore.js:105:1)

I think I am missing something trivial here :)

My bad. In $set I was doing user.articles instead of articles.


Analyzer gets confused by string interpolation of this

The analyzer doesn't like '$this$foo':
class A {
  String test1(String foo) => '$this'; // fine
  String test3(String foo) => '${this}$foo'; // fine
  String test2(String foo) => '$this$foo'; // "Undefined name 'this'"
}

void main() { }

The VM compiler handles all three fine.

Behavior is correct. You can only use an identifier after a $ in an interpolated string and this is a reserved word, not an identifier.
(Not saying it's not annoying, and we shouldn't consider allowing it, but currently the analyzer is correct).

Well ok, but the analyzer disagrees with the VM and the VM is more convenient in this case so I suggest we just change the analyzer (and if necessary, the spec). :-)

I'll mark this as a language change request then. One that I'm quite positive to :)

Behavior is correct. You can only use an identifier after a $ in an interpolated string and this is a reserved word, not an identifier.

Then why is String test1(String foo) => '$this'; allowed? Still seems like an analyzer inconsistency with the spec. CFE seems fine with '$this' as well...


Segmentation fault (core dumped) during license activation (for specific beta versions of unity)

Describe the bug
when I try to run the tests and building of my Unity project. It gives me a generic docker error. It has some Segmentation Fault errors but they don't seem to stop the job when they are raised.
Screenshots

logs_43.zip

Hey @BlackDereker and thanks for your bug report.
I'm not sure what the issue is caused by, do you have any idea? What have you tried? Could you test if you have the same issue with unity verison 2019.2.11f1?

Looks like it gives an error when trying to connect to Unity's licensing system. I didn't test on version 2019.2.11f1

I am receiving the same error when running against version 2020.1.0b9.

Here is my config:
# This is a basic workflow to help you get started with Actions

name: CI

# Controls when the action will run. Triggers the workflow on push or pull request
# events but only for the master branch
on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

env:
  UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}

jobs:
  build:
    name: Build my project ✨
    runs-on: ubuntu-latest
    steps:

      # Checkout
      - name: Checkout repository
        uses<EMAIL_ADDRESS>        with:
          lfs: true

      # Cache
      - uses<EMAIL_ADDRESS>        with:
          path: Library
          key: Library

      # Build
      - name: Build project
        uses<EMAIL_ADDRESS>        with:
          unityVersion: 2020.1.0b9
          targetPlatform: StandaloneWindows64
          versioning: None

      # Output
      - uses<EMAIL_ADDRESS>        with:
          name: Build
          path: build

Thanks everyone for reporting the issues. Please keep posting the versions that suffer from this error.
@KaneFreeman Can you also confirm that these errors are happening consistently (or only once per x runs)?

It is happening on every build. I had the setup previously working on version 2019.3.8f1.
This was the working config:
# This is a basic workflow to help you get started with Actions

name: CI

# Controls when the action will run. Triggers the workflow on push or pull request
# events but only for the master branch
on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

env:
  UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}

jobs:
  build:
    name: Build my project ✨
    runs-on: ubuntu-latest
    steps:

      # Checkout
      - name: Checkout repository
        uses: actions/checkout@v2
        with:
          lfs: true

      # Cache
      - uses<EMAIL_ADDRESS>        with:
          path: Library
          key: Library

      # Test
      - name: Run tests
        uses<EMAIL_ADDRESS>        with:
          unityVersion: 2019.3.8f1

      # Build
      - name: Build project
        uses<EMAIL_ADDRESS>        with:
          unityVersion: 2019.3.8f1
          targetPlatform: StandaloneWindows64

      # Output
      - uses: actions/upload-artifact@v1
        with:
          name: Build
          path: build

@KaneFreeman having compared your two workflows, there are actually a lot of changes, which doesn't really help narrow it down to for example a specific version of unity-builder or of unity (see picture below)
Did you also update the license to one from 2020.1.0b9 or is it crashing because you're using a license that still has an old format?

Yes I am working to test it more incrementally. I did update the license.

I was able to get the error again just by updating the version.
Here is the config:
# This is a basic workflow to help you get started with Actions

name: CI

# Controls when the action will run. Triggers the workflow on push or pull request
# events but only for the master branch
on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

env:
  UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}

jobs:
  build:
    name: Build my project ✨
    runs-on: ubuntu-latest
    steps:

      # Checkout
      - name: Checkout repository
        uses: actions/checkout@v2
        with:
          lfs: true

      # Cache
      - uses<EMAIL_ADDRESS>        with:
          path: Library
          key: Library

      # Test
      - name: Run tests
        uses<EMAIL_ADDRESS>        with:
          unityVersion: 2020.1.0b9

      # Build
      - name: Build project
        uses<EMAIL_ADDRESS>        with:
          unityVersion: 2020.1.0b9
          targetPlatform: StandaloneWindows64

      # Output
      - uses: actions/upload-artifact@v1
        with:
          name: Build
          path: build

I can confirm my project gets the same segfault error when using 2020.1.0b9, and builds fine with no issues using 2019.3.8f1 and 2019.3.14f1.

2020.1.0b9 is beta, you should report this to unity as it could definitely be on their side. :v:

Hi friends. I fixed this issue by removing calls to xvfb and instead using the -nographics flag. That got my activation working properly in Docker. I'm not sure if the Github Actions use xvfb, but I'm betting they do, given that the behavior is the same.
I wrote up our fixes here:
https://johnaustin.io/articles/2020/running-unity-20201-in-docker

Hey @Kleptine, thanks for posting a possible fix!
We've been talking about using that flag in https://github.com/webbertakken/unity-actions/issues/84 as well, and unfortunately it's not a good fix as it disables features in unity (hence we were using xvfb in the first place).


Relocate under dafny-lang?

Hi @tchajed! I love this action, and couldn't resist using it in the CI for the Dafny standard library: https://github.com/dafny-lang/libraries :)
Would you be amenable to us moving it under the dafny-lang org, and making it more officially maintained as a Dafny feature?

Sure, that sounds like a great thing! In order to transfer the repo you need permission to create a repo in the destination organization. I invited you as a collaborator in case you want to do the transfer, or you can give me permission and I'll do the transfer myself. GitHub should leave a redirect so downstream repos continue to work (presumably just mit-pdos/daisy-nfsd and dafny-lang/libraries, but who knows who else has discovered this).

I see. No worries, we've temporarily made you a member of dafny-lang, feel free to try the transfer again!

Great, thanks for doing that @RustanLeino! I've transferred the repo and left the organization to save you the trouble.

Ah it seems leaving the organization revoked my access to this repo so now I can't close the issue myself, could somebody add me back? Sorry about that!

Ha, no good deed goes unpunished. :) Thanks for helping us out @tchajed!


Curl error on Laravel 11

Describe the bug
when sending notifications locally it works but when uploaded to the live server it gives a 411 error.
here is the error description
`cURL error 0: The cURL request was retried 3 times and did not succeed. The most likely reason for the failure is that cURL was unable to rewind the body of the request and subsequent retries resulted in the same error. Turn on the debug option to see what went wrong. See https://bugs.php.net/bug.php?id=47204 for more information. (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for https://fcm.googleapis.com/v1/projects/pixify-de9ec/messages:send
Kreait
 \
Firebase
 \
Exception
 \
Messaging
 \
MessagingError
PHP 8.3.3
11.6.0
cURL error 0: The cURL request was retried 3 times and did not succeed. The most likely reason for the failure is that cURL was unable to rewind the body of the request and subsequent retries resulted in the same error. Turn on the debug option to see what went wrong. See https://bugs.php.net/bug.php?id=47204 for more information. (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for https://fcm.googleapis.com/v1/projects/pixify-de9ec/messages:send
Expand vendor frames
20 vendor frames
Illuminate
 \
Routing
 \
RouteFileRegistrar

: 39
{closure}
46 vendor frames
routes
 /
web
.php

: 39
//    'auth:sanctum',
//    config('jetstream.auth_session'),
//    'verified',
//])->group(function () {
//    Route::get('/dashboard', function () {
//        return view('dashboard');
//    })->name('dashboard');
//});
Route::get('/privacy_policy', function () {
return view('pages.privacy_policy');

})->name('privacy_policy');
Route::get('/notify', function () {
// $cloudMessaging = Firebase::messaging();

// $message = CloudMessage::withTarget('topic', 'general')

//     ->withNotification(Notification::create("Test Notification", 'Success'));

// $status = $cloudMessaging->send($message);

// dd($status);

$messaging = app('firebase.messaging');

$message = CloudMessage::withTarget('topic', 'general')

->withNotification(Notification::create('Title', 'Body'))

->withData(['key' => 'value']);

dd($messaging->send($message));

});`
Installed packages
{
    "name": "laravel/laravel",
    "type": "project",
    "description": "The skeleton application for the Laravel framework.",
    "keywords": ["laravel", "framework"],
    "license": "MIT",
    "require": {
        "php": "^8.2",
        "filament/filament": "3.2.72",
        "intervention/image": "^3.6",
        "kreait/firebase-php": "^7.10",
        "kreait/laravel-firebase": "^5.8",
        "laravel/framework": "^11.0",
        "laravel/jetstream": "^5.0",
        "laravel/sanctum": "^4.0",
        "laravel/telescope": "^5.0",
        "laravel/tinker": "^2.9",
        "league/color-extractor": "^0.4.0",
        "livewire/livewire": "^3.0"
    },
    "require-dev": {
        "fakerphp/faker": "^1.23",
        "laravel/pint": "^1.13",
        "laravel/sail": "^1.26",
        "mockery/mockery": "^1.6",
        "nunomaduro/collision": "^8.0",
        "phpunit/phpunit": "^11.0.1",
        "spatie/laravel-ignition": "^2.4"
    },
    "autoload": {
        "psr-4": {
            "App\\": "app/",
            "Database\\Factories\\": "database/factories/",
            "Database\\Seeders\\": "database/seeders/"
        }
    },
    "autoload-dev": {
        "psr-4": {
            "Tests\\": "tests/"
        }
    },
    "scripts": {
        "post-autoload-dump": [
            "Illuminate\\Foundation\\ComposerScripts::postAutoloadDump",
            "@php artisan package:discover --ansi",
            "@php artisan filament:upgrade"
        ],
        "post-update-cmd": [
            "@php artisan vendor:publish --tag=laravel-assets --ansi --force"
        ],
        "post-root-package-install": [
            "@php -r \"file_exists('.env') || copy('.env.example', '.env');\""
        ],
        "post-create-project-cmd": [
            "@php artisan key:generate --ansi",
            "@php -r \"file_exists('database/database.sqlite') || touch('database/database.sqlite');\"",
            "@php artisan migrate --graceful --ansi"
        ]
    },
    "extra": {
        "laravel": {
            "dont-discover": []
        }
    },
    "config": {
        "optimize-autoloader": true,
        "preferred-install": "dist",
        "sort-packages": true,
        "allow-plugins": {
            "pestphp/pest-plugin": true,
            "php-http/discovery": true
        }
    },
    "minimum-stability": "stable",
    "prefer-stable": true
}

PHP version and extensions
composer               2.6.6     Composer package
composer-plugin-api    2.6.0     The Composer Plugin API
composer-runtime-api   2.2.2     The Composer Runtime API
ext-bcmath             8.3.3     The bcmath PHP extension
ext-ctype              8.3.3     The ctype PHP extension
ext-curl               8.3.3     The curl PHP extension
ext-date               8.3.3     The date PHP extension
ext-dom                20031129  The dom PHP extension
ext-fileinfo           8.3.3     The fileinfo PHP extension
ext-filter             8.3.3     The filter PHP extension
ext-ftp                8.3.3     The ftp PHP extension
ext-gd                 8.3.3     The gd PHP extension
ext-gettext            8.3.3     The gettext PHP extension
ext-hash               8.3.3     The hash PHP extension
ext-iconv              8.3.3     The iconv PHP extension
ext-intl               8.3.3     The intl PHP extension
ext-json               8.3.3     The json PHP extension
ext-libxml             8.3.3     The libxml PHP extension
ext-mbstring           8.3.3     The mbstring PHP extension
ext-mysqli             8.3.3     The mysqli PHP extension
ext-mysqlnd            0         The mysqlnd PHP extension (actual version: mysqlnd 8.3.3)
ext-openssl            8.3.3     The openssl PHP extension
ext-pcntl              8.3.3     The pcntl PHP extension
ext-pcre               8.3.3     The pcre PHP extension
ext-pdo                8.3.3     The PDO PHP extension
ext-pdo_mysql          8.3.3     The pdo_mysql PHP extension
ext-pdo_sqlite         8.3.3     The pdo_sqlite PHP extension
ext-phar               8.3.3     The Phar PHP extension
ext-posix              8.3.3     The posix PHP extension
ext-random             8.3.3     The random PHP extension
ext-reflection         8.3.3     The Reflection PHP extension
ext-session            8.3.3     The session PHP extension
ext-shmop              8.3.3     The shmop PHP extension
ext-simplexml          8.3.3     The SimpleXML PHP extension
ext-soap               8.3.3     The soap PHP extension
ext-sockets            8.3.3     The sockets PHP extension
ext-sodium             8.3.3     The sodium PHP extension
ext-spl                8.3.3     The SPL PHP extension
ext-sqlite3            8.3.3     The sqlite3 PHP extension
ext-sysvsem            8.3.3     The sysvsem PHP extension
ext-tokenizer          8.3.3     The tokenizer PHP extension
ext-xml                8.3.3     The xml PHP extension
ext-xmlreader          8.3.3     The xmlreader PHP extension
ext-xmlwriter          8.3.3     The xmlwriter PHP extension
ext-zip                1.22.3    The zip PHP extension
ext-zlib               8.3.3     The zlib PHP extension
lib-curl               7.70.0    The curl library
lib-curl-openssl       <IP_ADDRESS>  curl OpenSSL version (<IP_ADDRESS>)
lib-curl-zlib          1.2.7     curl zlib version
lib-date-timelib       2022.10   date timelib version
lib-date-zoneinfo      2023.4    zoneinfo ("Olson") database for date
lib-fileinfo-libmagic  543       fileinfo libmagic version
lib-gd                 2.0.35    The gd library
lib-gd-freetype        2.8.0     freetype version for gd
lib-gd-libjpeg         6.2       libjpeg version for gd
lib-gd-libpng          1.5.13    libpng version for gd
lib-iconv              2.17      The iconv library
lib-icu                50.2      The ICU unicode and globalization support library
lib-icu-cldr           <IP_ADDRESS> ICU CLDR project version
lib-icu-unicode        6.2.0     ICU unicode version
lib-icu-zoneinfo       2018.5    zoneinfo ("Olson") database for icu
lib-libsodium          1.0.18    The libsodium library
lib-libxml             2.9.1     libxml library version
lib-mbstring-libmbfl   1.3.2     mbstring libmbfl version
lib-mbstring-oniguruma 6.8.2     mbstring oniguruma version
lib-openssl            <IP_ADDRESS>  OpenSSL 1.0.2u  20 Dec 2019
lib-pcre               10.42     The pcre library
lib-pcre-unicode       14.0.0    PCRE Unicode version support
lib-pdo_sqlite-sqlite  3.7.17    The pdo_sqlite-sqlite library
lib-sqlite3-sqlite     3.7.17    The sqlite3-sqlite library
lib-zip-libzip         1.5.2     The zip-libzip library
lib-zlib               1.2.7     The zlib library
php                    8.3.3     The PHP interpreter
php-64bit              8.3.3     The PHP interpreter, 64bit
php-ipv6               8.3.3     The PHP interpreter, with IPv6 support

Steps to reproduce the issue.
# Insert the commands issued in the terminal if they are needed
# to reproduce the issue. Otherwise, delete this code block.

// Insert the PHP code to reproduce the issue. Please ensure that it is code that
// can be copy pasted to reproduce it.

Error message/Stack trace
cURL error 0: The cURL request was retried 3 times and did not succeed. The most likely reason for the failure is that cURL was unable to rewind the body of the request and subsequent

Additional information
No response

If something works locally but not on a remote machine, it's usually something in the remote environment that doesn't work. I'm not familiar with this particular error, but it looks like a networking problem, perhaps there's a misbehaving proxy somewhere or another problem with the internet/network connection.
I can not do more than take guesses, but I'm quite sure this is not something I can fix in code, so I'll have to close this issue.
Please keep in mind that I don't work for Google, so I can't say anything about Firebase, the service. If you believe your environment has no problems, you might want to create a support issue with them.
Good luck!

Sorry but everything is correct on my side let me clear.
there is 2 different laravel project I created both are ^11.0 but on one its working but with another its not working if you want i can post both composer.json file. same server same firebase but one working another not. maybe laravel did something worn in new update.

So now i figured out the issue
when using kreait/firebase-php:v7.9.1 it works fine but as soon as I upgrade to version v7.10.0  then I get the guzzle HTTP error

7.10 switched from using consequent HTTP/1.1 request to concurrent HTTP/2 requests. This by itself shouldn't be a problem, but the memory usage can increase, depending on how many requests are sent, due to changes on how these requests are handled by the SDK. How many messages are you sending?
It should be possible to reduce the memory footprint by sending the messages in batches instead of all at once.

Thank you for sharing your findings, I'm sure this will be very helpful to others stumbling upon this issue!

Yeah I found the issue that when use old version of nginx it doesn't support http2 and it doesn't send proper request body to Google api so when update the nginx version everything solved. Thanks for your great support.

What is the nginx version number you are using?

是的，我发现问题是，使用旧版本的 nginx 时，它不支持 http2，并且不会向 Google api 发送正确的请求主体，因此，当更新 nginx 版本时，所有问题都解决了。 感谢您的大力支持。
Boss, which version of Nginx are you ultimately using?

Could you please test with the branch in  if this solves the issue?


runtime: panic reported on wrong line on deferred statements

What version of Go are you using (go version)?

$ go version
go version go1.15.1 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/francesco/.cache/go-build"
GOENV="/home/francesco/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/francesco/go/pkg/mod"
GONOPROXY="github.com/netdata/*"
GONOSUMDB="github.com/netdata/*"
GOOS="linux"
GOPATH="/home/francesco/go"
GOPRIVATE="github.com/netdata/*"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2 -Wno-incompatible-pointer-types"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build091588623=/tmp/go-build -gno-record-gcc-switches"

What did you do?

If we try to close a nil channel on a defer, or if we try to call a nil function on a defer, then we get a panic on the return statement while the line with the defer is not reported in the stack trace.
https://play.golang.org/p/mcO-A4WRWXC
https://play.golang.org/p/eQnYvAcaLCD
What did you expect to see?
I'd expect to see the defer statement in the panic stack trace. If you look at the links to the playground above, line 10 is not reported, we can see only lines 12 and 16.
What did you see instead?
I see only lines 12 and 16, not line 10 (the one with the defer).

Thanks for reporting. Do you know if this happens with older releases too?
/cc @aclements @randall77 @mknyszek @prattmic per owners.

@dmitshur I was running on 1.14.3 when I noticed and upgraded to 1.15.1 later just to check if this had been fixed by a newer release. So 1.14.3 is definitely affected. I checked now with 1.13.5 and it is affected as well.

This is intentional. We report the line number of the return point, because that's where the defer is executed (not where it is queued up). Discussion of maybe changing the behavior is at #29797. Closing as a dup.


Add 'POSITION_INDEPENDENT_CODE ON' (also known as '-fPIE').

First thx for these very useful lib!
I encountered some issues when linking with libcpptrace. Typically, here is the error I got:
/usr/bin/ld: lib/cpptrace/lib/libcpptrace.a(cpptrace.cpp.o): relocation R_X86_64_32S against symbol `_ZTVNSt7__cxx1115basic_stringbufIcSt11char_traitsIcESaIcEEE@@GLIBCXX_3.4.21' can not be used when making a PIE object; recompile with -fPIE

I just added the POSITION_INDEPENDENT_CODE ON flag on the targets, and now it works like a charm :-).

Hey thanks for the PR! I think looks good to me but let me double check the implications later today. It might be desirable to have an option for whether or not to use PIC.

Fair enough, sounds wise :-).

I updated my PR :-)

Awesome thank you so much!