Daser is not sampling a block with txs

Celestia Node version
2fde72c4184f069fd841a4d37e1d772a71528af6
OS
Ubuntu 20.04.3 LTS / Testground
Install tools

install testground
install docker

Others
No response
Steps to reproduce it

Run tc-002-da-sync from big-blocks testplan
Wait until 4th block gets filled with txs

Expected result
Full and Light nodes can das 4th block and onwards
Actual result
Full and Light are not dasing the filled 4th block and onwards
Relevant log output
<< validators[002] (338ca4) >> {"height":"4","txhash":"39314ACBDA9B1049A069E99676C736EBF87318B437D29815FB11BF0C032CDB99","codespace":"","code":0,"data":"12200A1E2F7061796D656E742E4D7367506179466F7244617461526573706F6E7365","raw_log":"[{\"msg_index\":0,\"events\":[{\"type\":\"message\",\"attributes\":[{\"key\":\"action\",\"value\":\"/payment.MsgPayForData\"}]},{\"type\":\"payfordata\",\"attributes\":[{\"key\":\"signer\",\"value\":\"celestia1vdjkcetnw35kzvtyd4ukcemev468getkx4jkuapedsehydm9de6kzwrdd34nyvr8ve5rwup4vd5q5w3z8x\"},{\"key\":\"size\",\"value\":\"10000\"}]}]}]","logs":[{"msg_index":0,"log":"","events":[{"type":"message","attributes":[{"key":"action","value":"/payment.MsgPayForData"}]},{"type":"payfordata","attributes":[{"key":"signer","value":"celestia1vdjkcetnw35kzvtyd4ukcemev468getkx4jkuapedsehydm9de6kzwrdd34nyvr8ve5rwup4vd5q5w3z8x"},{"key":"size","value":"10000"}]}]}],"info":"","gas_wanted":"1000000000","gas_used":"71816","tx":null,"timestamp":"","events":[{"type":"coin_spent","attributes":[{"key":"c3BlbmRlcg==","value":"Y2VsZXN0aWExZG15bGd5ZXR0ZXY1ZW50OWwzcjdlbnVhOG1sazIwZ2ZoN3A1Y2g=","index":true},{"key":"YW1vdW50","value":"MTAwMDAwMDAwMDAwdXRpYQ==","index":true}]},{"type":"coin_received","attributes":[{"key":"cmVjZWl2ZXI=","value":"Y2VsZXN0aWExN3hwZnZha20yYW1nOTYyeWxzNmY4NHoza2VsbDhjNWxwbmpzM3M=","index":true},{"key":"YW1vdW50","value":"MTAwMDAwMDAwMDAwdXRpYQ==","index":true}]},{"type":"transfer","attributes":[{"key":"cmVjaXBpZW50","value":"Y2VsZXN0aWExN3hwZnZha20yYW1nOTYyeWxzNmY4NHoza2VsbDhjNWxwbmpzM3M=","index":true},{"key":"c2VuZGVy","value":"Y2VsZXN0aWExZG15bGd5ZXR0ZXY1ZW50OWwzcjdlbnVhOG1sazIwZ2ZoN3A1Y2g=","index":true},{"key":"YW1vdW50","value":"MTAwMDAwMDAwMDAwdXRpYQ==","index":true}]},{"type":"message","attributes":[{"key":"c2VuZGVy","value":"Y2VsZXN0aWExZG15bGd5ZXR0ZXY1ZW50OWwzcjdlbnVhOG1sazIwZ2ZoN3A1Y2g=","index":true}]},{"type":"tx","attributes":[{"key":"ZmVl","value":"MTAwMDAwMDAwMDAwdXRpYQ==","index":true}]},{"type":"tx","attributes":[{"key":"YWNjX3NlcQ==","value":"Y2VsZXN0aWExZG15bGd5ZXR0ZXY1ZW50OWwzcjdlbnVhOG1sazIwZ2ZoN3A1Y2gvMQ==","index":true}]},{"type":"tx","attributes":[{"key":"c2lnbmF0dXJl","value":"aThEUkZDNXJzekVFeGNDMElSYW9WcWFKTlRwUVdZK2l1bkd2YVZOdXZ6SW1oblovS3pjMkNSMVhVdlZTZ1BVTmU4SGJPT0VVSFVzU3VWK0ZxVThIVEE9PQ==","index":true}]},{"type":"message","attributes":[{"key":"YWN0aW9u","value":"L3BheW1lbnQuTXNnUGF5Rm9yRGF0YQ==","index":true}]},{"type":"payfordata","attributes":[{"key":"c2lnbmVy","value":"Y2VsZXN0aWExdmRqa2NldG53MzVrenZ0eWQ0dWtjZW1ldjQ2OGdldGt4NGprdWFwZWRzZWh5ZG05ZGU2a3p3cmRkMzRueXZyOHZlNXJ3dXA0dmQ1cTV3M3o4eA==","index":true},{"key":"c2l6ZQ==","value":"MTAwMDA=","index":true}]}]}
<< bridges[002] (2cc42e) >> 2022-10-28T12:40:53.465Z	INFO	header/store	store/store.go:301	new head	{"height": 4, "hash": "0B176A8D35EBC0E5BF105FD5599447DDF0D237F7CD433A1B35DC740EE8F279F4"}
<< lights[000] (c448ad) >> 2022-10-28T12:40:53.466Z	INFO	header/store	store/store.go:301	new head	{"height": 4, "hash": "0B176A8D35EBC0E5BF105FD5599447DDF0D237F7CD433A1B35DC740EE8F279F4"}
<< lights[000] (c448ad) >> 2022-10-28T12:40:53.466Z	DEBUG	pubsub	go-libp2p-pubsub@v0.6.2-0.20220812132010-46b2a019f2f2/validation.go:457	validation done; took 571.076µs
<< lights[000] (c448ad) >> 2022-10-28T12:40:53.466Z	DEBUG	header/p2p	p2p/subscription.go:39	received message	{"topic": "header-sub", "sender": "12D3KooWQTTEdvu1C3RxuM5oWGBd8vpBTnQ4upoD4s2BqTcCyWgu"}
<< lights[000] (c448ad) >> 2022-10-28T12:40:53.466Z	DEBUG	header/p2p	p2p/subscription.go:46	received new ExtendedHeader	{"height": 4, "hash": "0B176A8D35EBC0E5BF105FD5599447DDF0D237F7CD433A1B35DC740EE8F279F4"
<< lights[000] (c448ad) >> 2022-10-28T12:40:53.467Z	INFO	das	das/subscriber.go:33	new header received via subscription	{"height": 4}
<< lights[000] (c448ad) >> 2022-10-28T12:40:53.468Z	DEBUG	das	das/worker.go:44	start sampling worker	{"from": 4, "to": 4}
<< lights[000] (c448ad) >> 2022-10-28T12:40:53.468Z	DEBUG	das	das/worker.go:62	got header from header store	{"height": 4, "hash": "0B176A8D35EBC0E5BF105FD5599447DDF0D237F7CD433A1B35DC740EE8F279F4", "square width": 32, "data root": "a8WpChSPfde0wtYjU7NVxFVvkl7zykCRvJfocnGMGNo=", "finished (s)": 0.000002536}
<< lights[000] (c448ad) >> 2022-10-28T12:40:53.468Z	DEBUG	share/light	light/availability.go:60	Validate availability	{"root": "a8WpChSPfde0wtYjU7NVxFVvkl7zykCRvJfocnGMGNo="}

<< fulls[002] (00d797) >> 2022-10-28T12:40:53.471Z	DEBUG	share/eds	eds/retriever.go:236	requesting quadrant	{"axis": 1, "x": 1, "y": 0, "size": 16}
<< fulls[002] (00d797) >> 2022-10-28T12:41:23.472Z	WARN	share/eds	eds/retriever.go:254	quadrant request timeout	{"timeout": "30s", "axis": 1, "x": 1, "y": 0, "size": 16}

Notes
If we have empty blocks -> DASer works fine with dasing latest headers
Logs https://gist.github.com/Bidon15/8613e4881f8e309dfbd2e530ce00be6d

Height 4 is width 32

So, it's an issue lying in how we use modules in testground
https://github.com/celestiaorg/test-infra/pull/97 vs https://github.com/celestiaorg/test-infra/pull/102
On PR 97, this bug is not reproducing as well as in production
However, in PR 102 we can clearly see that bitswap is not kicking in
Bitswap is not kicking in using monorepo: https://gist.github.com/Bidon15/af38abb3e9c35b4947c70e38003eead9
Everything works as expected on non-monorepo(previous): https://gist.github.com/Bidon15/23cc9ff205852a87ee4f8294df1b578a
cc: @derrandz

@Bidon15 Noted, so our theory about dependencies mismatch is on-point. Will debug this sometime today

Closing as we have found the root cause in how monorepo behaves


salt: 3007.0 -> 3007.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for salt is: Portable, distributed, remote execution and configuration management system
meta.homepage for salt is: https://saltproject.io/
meta.changelog for salt is: https://docs.saltproject.io/en/latest/topics/releases/3007.1.html
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3007.1 with grep in /nix/store/w867ifrakzh26bwycwfbnzs7mbdbxaaa-salt-3007.1
found 3007.1 in filename of file in /nix/store/w867ifrakzh26bwycwfbnzs7mbdbxaaa-salt-3007.1

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.pytest-testinfra
python312Packages.pytest-testinfra
salt

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/w867ifrakzh26bwycwfbnzs7mbdbxaaa-salt-3007.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A salt https://github.com/r-ryantm/nixpkgs/archive/17fb355fad7d10d030c3134fc2301297ab5cad73.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/17fb355fad7d10d030c3134fc2301297ab5cad73#salt

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/w867ifrakzh26bwycwfbnzs7mbdbxaaa-salt-3007.1
ls -la /nix/store/w867ifrakzh26bwycwfbnzs7mbdbxaaa-salt-3007.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

6 packages built:

python311Packages.pytest-testinfra
python311Packages.pytest-testinfra.dist
python312Packages.pytest-testinfra
python312Packages.pytest-testinfra.dist
salt
salt.dist

Maintainer pings
cc @Flakebi for testing.

Result of nixpkgs-review pr 314401 run on x86_64-linux 1

6 packages built:

python311Packages.pytest-testinfra
python311Packages.pytest-testinfra.dist
python312Packages.pytest-testinfra
python312Packages.pytest-testinfra.dist
salt
salt.dist


[hotfix] remove pkg.module

Closes #6238
This is a hotfix, but I'm not convinced this is the right way.
The problem
In #6021 pkg.module was introduced (which is good).
But.
es build doesn't expose global variable, which breaks plugins or code that refers to window.L.
Furthermore, most bundlers (like rollup, webpack etc.) use es bundle if available.
That's why 1.3.2 breaks people's apps.
The solution
This PR solves a problem described above, but I don't thinks there's any sense in providing es bundle, which exposes global variable.
This side-effect (global variable) would break tree shaking, so using es bundle over umd bundle doesn't make any sense.
We cannot get rid of global variable - see #2364, so Leaflet is not ready for exposing es module.
Summary
IMHO we should revert #6238 and provide only umd bundle, as before.
What do you guys think?
@Rich-Harris
@mourner @ghybs @IvanSanchez @perliedman

I don't really have a stake in this, but personally I'd argue against going back to using globals in Leaflet itself for the sake of plugins — this is really just a question of dealing with legacy, since modules are now supported in all browsers (IE11 doesn't count!), and shipping proper ESM has tangible benefits such as treeshakeability.
It's easy enough for an app using those plugins to create window.L itself. Could even add a leaflet/global module for convenience, which could be used as an alias for Leaflet itself via webpack/Rollup config:
// leaflet/global.js
import * as L from '..';
export * from '..';

window.L = L;

Yeah, based on the number of responses in that issue, it looks like we should revert and hotfix (so that automatic semver upgrades in people's apps don't break automatically), and consider readding this for a major version (where people will have to upgrade manually). Perhaps together with dropping old IEs.

personally I'd argue against going back to using globals in Leaflet itself for the sake of plugins

@Rich-Harris I completely agree; the issue here is that a breaking change is happening in a patch release, which is not right even if the change itself is great.

@mourner done

@Rich-Harris

It's easy enough for an app using those plugins to create window.L itself

Yeah, that's probably the way to go. Thanks for your feedback!
But in this case, if one's using at least one plugin which needs window.L exposed, then Leaflet wouldn't not be treeshaken? Am I right?

Solution for rollup: https://www.npmjs.com/package/@ec-nordbund/rollup-plugin-leaflet


eAccelerator not compatible with Slim?

 They use PHP 5.4.29, eAccelerator <IP_ADDRESS>-ea.
[Wed Jun 25 20:43:57 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12789): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:57 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12786): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:56 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12775): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:56 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12774): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:53 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12769): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:53 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12764): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:52 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12762): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:52 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12761): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:46 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12742): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:46 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12741): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:45 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12738): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:43:45 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(12737): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:12:58 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(7118): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:12:58 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(7115): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:12:57 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(7110): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72
[Wed Jun 25 20:12:56 2014] [error] [client x.x.x.x] ] [notice] EACCELERATOR(7105): PHP crashed on opline 0 of set() at /home/xxxxx/vendor/slim/slim/Slim/Helper/Set.php:72

This error seems to come from this function, but have no idea what could happen:
    /**
     * Set data key to value
     * @param string $key   The data key
     * @param mixed  $value The data value
     */
    public function set($key, $value)
    {
        $this->data[$this->normalizeKey($key)] = $value;
    }

Thanks,
Jérémy

Someone else who uses and is familiar with eAccelerator will have to confirm. I know Slim works great with APC and ZendOPcache


file doc/a1823995.txt contains 'XXXXXXX'

Hi,
Thanks for supplying the project! I may have found an issue within the a1823995.txt file with an insertion of a high severity bug of 'XXXXXXX' seen in multiple lines.
Would appreciate you taking a look, if you've got the time.
Thanks.

thanks for reporting


Sample code doesn't return VM.List()

Describe the bug
The sample given at https://github.com/vmware/vsphere-automation-sdk-python/tree/v<IP_ADDRESS>
import requests
import urllib3
from vmware.vapi.vsphere.client import create_vsphere_client
session = requests.session()
Disable cert verification for demo purpose.
This is not recommended in a production environment.
session.verify = False
Disable the secure connection warning for demo purpose.
This is not recommended in a production environment.
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
Connect to a vCenter Server using username and password
vsphere_client = create_vsphere_client(server='<vc_ip>', username='<vc_username>', password='<vc_password>', session=session)
List all VMs inside the vCenter Server
vsphere_client.vcenter.VM.list()
This code doesn't return the list of VMs even hough I have 2 vms created in vCenter/ESXi.
The output is just blank..
(vCenterDemo) (base) $ python vCClient.py
(vCenterDemo) (base) $
Reproduction steps

...
Expected behavior
List of VMs in the vCenter
Additional context
No response

Please share following details:

Installation type: typical/local/air-gapped
Environment details such as Python, Setuptools and pip version.
Steps to reproduce

Our listVM sample is also available in samples dir and detailed instructions to install SDK and run samples are available in README. Please refer to quick start guide and run SDK samples sections.

Installation type is Typical.
(vCenterDemo) (base) girish$ pip3 --version
pip 23.1.2 from /Users/../lib/python3.7/site-packages/pip (python 3.7)
(vCenterDemo) (base) girish$
(vCenterDemo) (base) girish$
(vCenterDemo) (base) girish$ python3 --version
Python 3.7.6
(vCenterDemo) (base) girish$
(vCenterDemo) (base) girish$
Steps to reproduce:
(1) Update the sample code with vCenter server ip, user credentials
(2) Run python3 my sample.py (The code is pasted in earlier message) The sample given at https://github.com/vmware/vsphere-automation-sdk-python/tree/v<IP_ADDRESS>

Please try this (replace values in placeholders for IP, Username and Password):
import requests
import urllib3
from vmware.vapi.vsphere.client import create_vsphere_client
session = requests.session()

# Disable cert verification for demo purpose.
# This is not recommended in a production environment.
session.verify = False

# Disable the secure connection warning for demo purpose.
# This is not recommended in a production environment.
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)

# Connect to a vCenter Server using username and password
vsphere_client = create_vsphere_client(server='<vc_ip>', username='<vc_username>', password='<vc_password>', session=session)

# List all VMs inside the vCenter Server
list_of_vms = vsphere_client.vcenter.VM.list()

print("List Of VMs")
print("----------------------------")
print(list_of_vms)
print("----------------------------")

Hi. Just tried the above code. but still no Vms.
(vCenterDemo) (base) girish$ python3 vCClient2.py
List Of VMs
[]

(vCenterDemo) (base) girish $ python3 vCClient2.py
List Of VMs
[ ]

Nevermind.  Got the output.
Summary(vm='vm-16', name='vm-001', power_state=State(string='POWERED_ON'), cpu_count=2, memory_size_mib=8192)]

Thanks.


ASA-214: Use mocks for Python tests

Description
Adding mock data to use for Python unit tests instead of calling the API directly.
Checklist

[x] Code compiles correctly
[x] Created tests which fail without the change (if applicable)
[x] All lint and unit tests passing
[x] Extended the README / documentation, if necessary

[ ] Updated NEWS.md if modifying the R package

Additional Comments
Anything else you'd like to add.

They aren't. I just grabbed data from the API so the tests aren't actually testing anything related to filter/querying.


Colon in solution extend add-knowledge does not handle colon (:) properly

Description
When I run: fsoc solution extend --add-knowledge solution:solution-knowledge-name
The manifest.json is updated, and a file is created, however, the filename gets a strange name. (this is probably due to the way it handles the : which may be a difficult character in file paths
Expected Behavior
If instead it uses the : to split and create solution as the folder underneath knowledge, and the solution-knowledge-name as the file under that path
Actual Behavior
It creates a file with : in it
Affected Version
fsoc version 0.31.0
Steps to Reproduce

First step
Run command: fsoc solution extend --add-knowledge solution:solution-knowledge-name

Checklist

[ x] I have read the contributing guidelines
[x ] I have verified this does not duplicate an existing issue

@tutnes thank you for reporting this, checking it out...

@tutnes sorry for the delayed response on this. My understanding is that the solution name should not be part of the type name when using --add-knowledge. We can add checks to make sure that the character set is verified and colon is disallowed with a helpful message.

Note: PR #163 adds a check and a clarifying error message. Thank you @tutnes for pointing this out!


Quote the file path to the Ruby bin directory when starting fluentd as a windows service

The the file path is passed to win32-service (which calls windows functions CreateService) and to Process.spawn.  Both require spaces to be wrapped in quotes or windows will not properly handle them.
Without this fix fluentd will fail fail when initializing or when starting with a ruby directory that contains spaces.

@nurse How about this?
Does ruby have the function for this case?

It does not have a function that I am aware of.

@repeatedly instead of passing argv as single string, just pass them as array.
see also https://ruby-doc.org/core-2.4.1/Process.html#method-c-spawn

@iantalarico Could you try convert single string to array?

@repeatedly @nurse I gave this a try but was unable to make it work.  Looking the documentation it looks like if I don't just pass a command line string it does not use the shell and will try to execute a built in command.  I'm guessing this may not work if we are passing a path to an exe as the command.

@iantalarico Where and How it failed. I thought both ruby_path and rubybin_dir + "/ruby.exe " are full path.

@nurse It fails on Process.spawn.
If the path is quoted we get the error "Invalid argument - "C:/Program Files (x86)/TestDir/bin/ruby.exe""
If the path is unquoted we get the error "No such file or directory - OpenEvent"
I don't think it's and issue with the path I think it's an issue of what Process.spawn expects when we pass the command and an array.

@iantalarico How did you quote?
It seems you quoted twice, because Invalid argument is raised when path includes double quote.

@nurse I tried:
""#{rubybin_dir}/ruby.exe""
and
"#{rubybin_dir}/ruby.exe"

@iantalarico Could you show with Process.spawn(... )?

@nurse
Process.spawn("#{rubybin_dir}/ruby.exe", "#{rubybin_dir}/fluentd",  opt, "-x #{INTEVENTOBJ_NAME}")
and
Process.spawn(""#{rubybin_dir}/ruby.exe"", ""#{rubybin_dir}/fluentd"",  opt, "-x #{INTEVENTOBJ_NAME}")

Process.spawn("#{rubybin_dir}/ruby.exe", "#{rubybin_dir}/fluentd", opt, "-x #{INTEVENTOBJ_NAME}")

seems correct.
And it shows "No such file or directory - OpenEvent" at Process.spawn?
The term "OpenEvent" is shown at that point sounds strange.

@nurse Yea I was wrong only the first one was failing on process spawn the second one fails on event open:
"C:/Program Files (x86)/TestDir/lib/ruby/gems/2.3.0/gems/win32-event-0.6.3/lib/win32/event.rb:125:in open'"  "winsvc.rb:59:in service_stop'", "C:/Program Files (x86)/TestDir/lib/ruby/gems/2.3.0/gems/win32-service-0.8.10/lib/win32/daemon.rb:309:in `block in mainloop'"
It looks like the service is failing in some way in the daemon.
I can dig more into this if need be but I don't see a problem with just passing a command line string?

@iantalarico
Maybe Process.spawn("#{rubybin_dir}/ruby.exe", "#{rubybin_dir}/fluentd", opt, "-x", INTEVENTOBJ_NAME) is correct.
or maybe just it reached an another issue on your environment/setting.
Anyway I need full backtrace of the error.

@nurse  I think that was the full backtrace. I did "err.backtrace.inspect"

After fixed this problem, I will release new v0.14.

@nurse Is the original backtrace I sent okay?  Are you okay with the fix as is?  This is essentially what was being done before.  If not I can dig into this more.

@iantalarico Backtrace is OK.
Did you try Process.spawn("#{rubybin_dir}/ruby.exe", "#{rubybin_dir}/fluentd", opt, "-x", INTEVENTOBJ_NAME)?

@nurse It looks like I get the same backtrace:
C:/Program Files (x86)/TestDir/lib/ruby/gems/2.3.0/gems/win32-event-0.6.3/lib/win32/event.rb:125:in open'" "winsvc.rb:59:inservice_stop'", "C:/Program Files (x86)/TestDir/lib/ruby/gems/2.3.0/gems/win32-service-0.8.10/lib/win32/daemon.rb:309:in `block in mainloop'"

Hmm, it is not sufficient to investigate the issue. It seems to need more digging...

@nurse I'm happy to dig more into this but why is the current solution not acceptable? This is what the current code is doing.

@iantalarico Ah, I wrongly saw CI is failing but it looks false-positive.
And both part looks affect only Windows.
Therefore though array is better, current patch is acceptable.
@repeatedly Could you merge this if CI is ok.

@nurse Alright thanks.  As I said I am happy to look into the array solution more if you feel strongly going that route.

Thanks for your work 👍


Feature Request: Contact

Environment

Python version: 3.9
Nautobot version: 1.1.4

Proposed Functionality
As part of the Nautobot Plugin Device Lifecycle Management plugin the model of a contact was introduced there.

Use Case

This is something that could be used in many other places as well. Such as assigning ownership of devices.
Ownership of sites
By moving into core then other plugins can leverage the model and have a single unified contact experience

Database Changes
Create new data model, user

External Dependencies
None

How about we turn this into a discussion to cover how we might model this and how it would be associated with other objects?


feat(omnisharp): add more settings

As I was reviewing the Omnisharp LSP I found these configuration items that I
figured could be ported to lspconfig as well.
I've tested this new config in some sample projects (while comparing to
VSCode's C# plugin behaviour), seems to work fine!
I don't do any C# so I'm not sure if I'm missing something, but I believe this
should be fully backwards compatible.
These have primarily been sourced from the VSCode extension [1].
[1] https://github.com/OmniSharp/omnisharp-vscode/blob/88ad237e1e904ad0f91d2de39c30132198a02dcb/src/omnisharp/server.ts#L345-L434

I realized the docs probably needs to be updated

I realized the docs probably needs to be updated

see also https://github.com/neovim/nvim-lspconfig/issues/2011


Extend the JSON spec to allow for searching for body of modified files.

Currently, only file names are searched and filtered to try to find dangerous files.  It'd be great if you could in git-deny-patterns.json specify a search that looks for items in the body of checked in files, such as "-----BEGIN RSA PRIVATE KEY-----" etc

I could help with that but I'm trying to think other examples (besides -----BEGIN RSA PRIVATE KEY-----) where this feature could be useful. Any ideas?

See the appendix of this paper for a long list of great examples, with robust regexes ready to go:
https://www.ndss-symposium.org/ndss-paper/how-bad-can-it-git-characterizing-secret-leakage-in-public-github-repositories/
(As discussed here https://blog.acolyer.org/2019/04/08/how-bad-can-it-git-characterizing-secret-leakage-in-public-github-repositories/)


Mastery Pages from Champion.gg [Enhancement]

if this could be added to the LoLClient as like an overlay it would help some noobs like me and others that are new to league :P thanks for the awesome app thou! keep up the good work :D

This could be interesting, but attempting to do an overlay with Electron will take a lot of work. I'll think on it and get back to this issue otherwise.

If Riot ever adds supposed for imported masteries, I'll for sure take this up. Until then I'm going to close this.


Fix inconsistent HTTPStatus string representation

Hello,
In some python environments, HTTPStatus conversion to string will not result in their value but in their repr ("<HTTPStatus.OK: 200>" instead of "200")
It leads to the following error in mod_wsgi:
ValueError: status code is not a 3 digit integer

because the returned status is "<HTTPStatus.OK: 200> OK" instead of "200 OK"
Explicit call to the value property ensure that the fstring contains the numerical representation of the HTTP code and not the human readable representation of the enum.
mod_wsgi behavior:
>>> str(HTTPStatus.OK)
'<HTTPStatus.OK: 200>'
>>> HTTPStatus.OK.__str__
<method-wrapper '__str__' of HTTPStatus object at 0x7fb3d52bbd50>

python CLI behavior
>>> str(HTTPStatus.OK)
'200'
>>> HTTPStatus.OK.__str__
<method-wrapper '__repr__' of HTTPStatus object at 0x7faa19c06350>

Well done, once again improving our compatibility.


common types

To use a Vector2D or Vector3D or something simple as a date, we need to declare placeholder structs or representations. The task is to collect a set of common types and their presentation in the different targets which the code to translate them.
Common types:

Date (e.g. date + time)
Vector2d, Vector3d
Bytes
Urls
var (e.g. Qt variant or TS any type)

Do we need common types per technology?

The cli would support this, but providing common types in each template must be tracked there.


PDFs - Content 'Format' not 'Type'

This has been picked up by Lennie.

Explore renaming Types of content to Formats

Come back to this in conjunction with Content Strategy work on content types. We will leave as is, since the current content is not just about formats.

Now being tracked in Trello


display phone contact in assignee without .sms

Details
Subtext in assignee shows @expensify.sms at the end. This removes that.
Fixed Issues

$ https://github.com/Expensify/App/issues/22050
PROPOSAL: https://github.com/Expensify/App/issues/22050#issuecomment-1629254842
Tests

Click assign task
Add a phone number contact with whom you had a chat as assignee for the task
Check the subtext of the assignee does not show @expensify.sms at its end

[x] Verify that no errors appear in the JS console

Offline tests

Click assign task
Add a phone number contact with whom you had a chat as assignee for the task
Check the subtext of the assignee does not show @expensify.sms at its end

QA Steps

Click assign task
Add a phone number contact with whom you had a chat as assignee for the task
Check the subtext of the assignee does not show @expensify.sms at its end

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/102477862/8fc90a9f-a8e9-4d66-a4b6-33ba0ceb86f9

Mobile Web - Chrome
https://github.com/Expensify/App/assets/102477862/41150ce1-1775-419f-92ff-3eea88d3e517

Mobile Web - Safari
https://github.com/Expensify/App/assets/102477862/5b18e4ab-5060-490e-bc1e-839453944752

Desktop
https://github.com/Expensify/App/assets/102477862/556f7039-cb49-4d21-b456-3bc8ff178308

iOS
https://github.com/Expensify/App/assets/102477862/1bf15a9a-6851-4d8a-9d9c-f83f151b61cc

Android
https://github.com/Expensify/App/assets/102477862/1712babe-fafb-4631-900d-fd71683d94dd

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.41-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.42-0 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
cancelled 🔪

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Type checking on plist.append()

I don't know if this is the 'correct' way to handle typings, but it at least gives an example of fixing the examples in #1

Still missing type annotations for items(), values() and keys() in pdict and tdict.

This is great! I'll create a new branch and merge/examine this later. Thanks!

I think the problem is that the | operator used as a 'or' check on multiple types is not supported before 3.10. I can change to using Union instead, which should be supported.


contracts: Add deprecation switch to RequestManager

fixes: #475

Looks good to me, but should we also have code to deprecate the fill manager?

Looks good to me, but should we also have code to deprecate the fill manager?

I cannot see a real benefit for it, assuming that we redeploy all the contracts for a new version. But it certainly does not harm.


add help text to batch change form

part of #346.
Changes in this pull request:

add tooltips in New Batch Change form
add link to create a group under the record owner group selection

I like this, but wonder if there should be something clearer for A+PTR/AAAA+PTR types (since both types require both, but need to have the FQDN for input name and IP for record data). If not here, there should be an indication in the portal docs.

I like this, but wonder if there should be something clearer for A+PTR/AAAA+PTR types (since both types require both, but need to have the FQDN for input name and IP for record data). If not here, there should be an indication in the portal docs.

you mean for deletes? forgot about that, just added a note about it in the portal docs.


Read json customization to exclude text customizations

Move design spec interfaces into a single module which is now shared by localization plugin and keywords plugin.
Visit the reaction chain to find all the text node customizations.

Not really related to this change, but the "Submit" button is a little confusing as to whether it applies to the "Char Limit" and "Description", or just "Description".


Better support for meta-RL training

Add new class methods to construct a MultiClassMultiTaskEnv with only one task
Introduce TaskSpec as an opaque container for task information. User should call
sample_task(n) to obtain a list of TaskSpec and pass to set_task(), without
the need to know what is inside TaskSpec.

I think this is a good idea, but there are two fairly obvious (/ more or less necessary, IMHO) additions that would be nice to have:

Equivalent changes for MT10 / MT50.
A way of getting the list of all task_names for each benchmark (in a canonical order that matches task_id).

We can add those in a separate PR, if necessary.

Keren previous added a property all_task_names in MultiClassMultiTaskEnv which returns a list of all task_names. Is that what you meant?

@ryanjulian @krzentner @naeioi I added an env wrapper for padding observation dimension. PTAL

I hardcoded the max_obs_dim and get rid of the extra wrapper. PTAL @ryanjulian @krzentner @naeioi


Group value files into folders

Is your feature request related to a problem? Please describe.
We currently have a lot of values files in https://github.com/elastisys/compliantkubernetes-apps/tree/main/helmfile/values. We should group them into folders where possible.
Describe the solution you'd like
Group similar value files into folder, like we have done with opensearch and thanos.
Describe alternatives you've considered
Additional context
Definition of done:
Similar value files are grouped into folders.

Closing in favor of https://github.com/elastisys/compliantkubernetes-apps/issues/695


unable to install on AIX

I have tried to install JSON::JQ 0.09 on AIX 7.2 system. My perl version is 5.14.2.
Building and testing Alien-LibJQ-0.05 ... FAIL
/home/micsw/.cpanm/work/1659593899.23921106/Alien-LibJQ-0.05/_alien/build_ECX3/jq-1.6/src/builtin.c:1048:20: error: 'INFINITY' undeclared (first use in this function)
   return jv_number(INFINITY);
                    ^~~~~~~~
/home/micsw/.cpanm/work/1659593899.23921106/Alien-LibJQ-0.05/_alien/build_ECX3/jq-1.6/src/builtin.c:1053:20: error: 'NAN' undeclared (first use in this function)
   return jv_number(NAN);
                    ^~~

I am aware of the issue jq with AIX but we have installed a properly working jq AIX port as an rpm from
AIX Toolbox for Open Source Software

/opt/freeware/bin/jq
/opt/freeware/bin/jq_32
/opt/freeware/bin/jq_64
/opt/freeware/doc/jq-1.6
/opt/freeware/doc/jq-1.6/AUTHORS
/opt/freeware/doc/jq-1.6/COPYING
/opt/freeware/doc/jq-1.6/ChangeLog
/opt/freeware/doc/jq-1.6/NEWS
/opt/freeware/doc/jq-1.6/README
/opt/freeware/doc/jq-1.6/README.md
/opt/freeware/lib/libjq.a
/opt/freeware/lib64/libjq.a
/opt/freeware/man/man1/jq.1
/opt/freeware/include/jq.h
/opt/freeware/include/jv.h

Why isn't that used to build the libjq.so?

hi,
Thank you for reaching me on this.
The problem above occored because I didn't take any existing system jq library for making this perl binding. The underlying module Alien::LibJQ always tries to compile libjq.a from source code. I rely on cmake for system/compilier portability.
Looks like it still cannot work on AIX. Unfortunately I have to testing environment to try.
The jq library from AIX Toolbox is missing the pkg-config file for compiling and linking, usually called something like jq.pc. It records the gcc (or other compiler) flags and linking options.
One way to resolve this, ask the maintainer of AIX Toolbox to add back the missing pkg-config files, they can be auto generated while making this package. Once the jq.pc file is available, I will instruct my package build to search for it and use the libjq.a inside instead.

Thx for the explanation. I will try to reach out the maintainer of AIX jq rpm package.

I guess what they said is true. Alternative option is to fix my own build on AIX, the cmake tool used will make a proper pkgconfig file together with the built binaries.


now i hate my computer thanks

imma sell it
ah also the code needs to compile the headers cstdio cstdlib and cmath

@ElGusanitoPLAY I'm sorry, could you please elaborate on what exactly is the problem you are experiencing with the code?


Suggestion: Use subdir for hass data

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
Currently hass intallation data clogs up directory when the devcontainer is spun up
Describe the solution you'd like

create a subdir hass or the likes
symlink custom_components, configuration.yaml into this dir.
in scripts/develop -> cd ../hass and do install there
.gitignore could then be hass too making it immune to additional hass artifacts, backups etc

Describe alternatives you've considered
N/A
Additional context
N/A

What you describe is how it used to be, that was confusing for people.
The way it was now is simpler, but you control your repository so you can do whatever you need/want there ;)

What you describe is how it used to be, that was confusing for people. The way it was now is simpler, but you control your repository so you can do whatever you need/want there ;)

ah I see. Thanks!

FWIW https://github.com/ludeeus/integration_blueprint/pull/102


Manual approval required for workflow run<PHONE_NUMBER>: Release t0rn refs/tags/v1.12.3-rc.0

Please approve runtime upgrade with github release t0rn v1.12.3-rc.0
Runtime upgrade dry run output:
💈 Script started at 1830844 block in t0rn chain

🐡 Running with dryrun flag!

🐙 checking out v1.12.3-rc.0...
✅ tag checked out

🔎 making sure runtime version got updated...
✅ runtime versions updated

🫧 check WASM artifact...
🔢 WASM blake2_256 hash: 0x6e633cb6201aecc15ff80de511c3d2bf870bc6cd82357e410fb7525306917190
🔢 WASM blake2_256 hash fetched from release: 0x6e633cb6201aecc15ff80de511c3d2bf870bc6cd82357e410fb7525306917190
✅ WASM blake2_256 hash is matching
⚙ set_code runtime upgrade... dry
✅ runtime upgrade executed... dry

Workflow is pending manual review.
URL: https://github.com/t3rn/t3rn/actions/runs/4808648036
Required approvers: [AwesomeIbex MaciejBaj]
Respond "approved", "approve", "lgtm", "yes" to continue workflow or "denied", "deny", "no" to cancel.

Workflow cancelled, closing issue.


Modify separator used for constructing path

Issue
Ran into a bug while trying to use the library to connect with the Blocks service. It seems that the string for loading the config dotenv file is using a colon instead of a forward slash as shown below

Approach

Changed the pathSeparator to separator when constructing the config file path

Testing
I was able to follow the sample code from the documentation using Java 1.8. This executed successfully when run with credentials against the sandbox environment.
package com.simbachain.simba.test.sandbox;

import com.simbachain.SimbaConfigFile;
import com.simbachain.auth.blocks.BlocksConfig;
import com.simbachain.simba.management.AuthenticatedUser;

public class ConfigTest {

    public static void main(String[] args) throws Exception {

        SimbaConfigFile config = new SimbaConfigFile();

        String clientId = config.getAuthClientId();
        String clientSecret = config.getAuthClientSecret();
        String authHost = config.getAuthBAseUrl();
        String host = config.getApiBaseUrl();

        BlocksConfig authConfig = new BlocksConfig(clientId, clientSecret, authHost);
        AuthenticatedUser user = new AuthenticatedUser(host, authConfig);

        System.out.println("Authenticated user: " + user.whoami());
    }

}

Many thanks fir spotting and fixing this. I'll merge


An extra space between "From" and "Table" in Stream query is causing issue in streamcontroller and the widget is not getting updated

It seems really weird.  I faced this in my project, so decided to try it with the official example. This is happening in both iphone and android emulators
Steps to reproduce:

Launch the official example from floor repo.

Add a task and save

a) Expected behaviour: Count and listview both getting updated

b) Actual behaviour: Same as above

insert an extra space between "From" and Table in following query and save. You dont even need to run the build

@Query('SELECT DISTINCT COUNT(message) FROM task')
Stream<int?> findUniqueMessagesCountAsStream();

Add a task and save

a) Expected behaviour: Count and listview both getting updated
7.b) Actual behaviour: Listview is getting updated but not the count

Additional info: It's happening with other stream queries as well
Could someone confirm if they are seeing the same behaviour.
I am feeling like I must be missing something

Without space

With space

It's an interesting thing, and it certainly shouldn't be happening.
Thanks for reporting the issue. I'll take a look what might be wrong.

To be honest I wasn't able to replicate the issue. An extra space automatically removes in the generated code. Please take a look a sample code bellow.

Thnx @dkaera let me see if it get fixed after running the build. I remember running the build but will double check.

@dkaera running build fixes it it seems. You can close it


in_forward: Add source_host_key parameter. fix #804

This feature will be supported by porting into v0.14 API and using inject plugin helper.

@tagomoris How to insert client's hostname by inject plugin helper?

Rebased.

Oh, I misunderstood the problem.

IMO, parameter name should be source_hostname_key instead of source_host_key to show this feature injects hostname, not host address or others explicitly.

It is derived from in_tcp so you also think in_tcp's parameter should be renamed?

Adding newer name to in_tcp sounds good idea.
in_forward plugin is used much widely than in_tcp, so I think we should NOT follow the bad way of in_tcp.

Renamed.

Okay. After test passed, I will merge this patch.


v51's  expo-secure-store dependecy breaks web compatibility

Describe the bug
expo-bugsnag v51.x added  expo-secure-store as peer-depedency. This package doesn't work on the web platform and causes the app to crash on runtime.
A possible fix would be to use AsynStorage when running in the web platform.
Steps to reproduce

Launch the app on the web

Environment

Bugsnag version:  51.0.0
Expo SDK version: 51

Error messages:
Uncaught TypeError: _ExpoSecureStore.default.getValueWithKeySync is not a function

Hi @jypa  :wave: ,
Thanks for raising this issue. We're going to take a look at addressing this. We don't currently have an ETA we can share on when this will be available, but we will make sure to post any updates on this thread.

Ended up patching the package like this:
let deviceId
    if (Platform.OS === 'web') {
      deviceId = localStorage.getItem(DEVICE_ID_KEY)
      if (!deviceId || !cuid.isCuid(deviceId)) {
        deviceId = cuid()
        localStorage.setItem(DEVICE_ID_KEY, deviceId)
      }
    } else {
      const storeOptions = {
        requireAuthentication: false,
        keychainAccessible: SecureStore.ALWAYS_THIS_DEVICE_ONLY
      }

      deviceId = SecureStore.getItem(DEVICE_ID_KEY, storeOptions)
      if (!deviceId || !cuid.isCuid(deviceId)) {
        deviceId = cuid()
        SecureStore.setItem(DEVICE_ID_KEY, deviceId, storeOptions)
      }
    }

Hi @giaset, thanks for sharing this -please see the comment on the linked PR:
https://github.com/bugsnag/bugsnag-expo/pull/185#issuecomment-2161042749

This is now fixed in v51.0.1


Add permissions for scheduling goals

Add permissions for scheduling goals that restrict access based on plan owner and collaborators.

To discuss with Joel and Luke:

Is this still applicable for procedural scheduling rules?
Is this now feasible to do after our DB merge?


Cant find /etc/rpimonitor/data.conf  or any other configuration files

I want to edit rpimonitord.conf.d or /etc/rpimonitor/data.conf and I cant find /rpimonitor under etc.
Is it stored somewhere else?
Thanks!

I dont find it either. Any idea?

@.***:~ $ stat /etc/rpimonitor/data.conf
stat: cannot statx '/etc/rpimonitor/data.conf': No such file or directory
diegoweb @.***> ezt írta (időpont: 2022. ápr. 5., K,
15:33):

/etc/rpimonitor/data.conf is a symlink to a file under
/etc/rpimonitor/template
SSH into the container and type:
stat /etc/rpimonitor/data.conf
In my case:
File: ‘/etc/rpimonitor/data.conf’ ->
‘/etc/rpimonitor/template/raspbian.conf’
—
Reply to this email directly, view it on GitHub
https://github.com/michaelmiklis/docker-rpi-monitor/issues/15#issuecomment-1088709577,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACY67SKULIOCS6WMDV7Y5H3VDQ6JDANCNFSM5NEJA2KA
.
You are receiving this because you commented.Message ID:
@.***>


SV identified with 706  accessions

In your method, Genotypes of Structural variants (SVs) in 706 accessions with following code:
multigrmpy.py -i /public10/home/sci0011/projects/tomato2/08_paragraph/02_vcf/SV.paragraph.vcf -m /public10/home/sci0011/projects/tomato2/08_paragraph/01_bam/samples_${sample}.txt -r ~/data/ref/SL5.0/SL5.0_chr_number.fa -o . --threads 64

but how to gain the file "SV.paragraph.vcf" ?

it is the SV set we used for constructing the TGG1.0. There are likely some SVs that failed to meet the requirement of the paragraph, therefore we filtered out these SVs (nine SVs if I remember correctly).


the date of the migration of beta to stable is missing

The website used to display the date when the beta would become stable. It's not shown after the switch to rustup based installation steps.
This was useful because you'd know when to look for a new release.

Don't worry, I've fixed it https://github.com/rust-lang/rust-www/pull/680

I've fixed it https://github.com/rust-lang/rust-www/pull/709


Service with 'uncompleted' status can also be rolling updated.

In GitLab by @cuiaq123 on Mar 20, 2018, 15:52
Menu location：Dashboard More Detail
Preconditions：
operating：
expected results：grafana element can not be shown
actual results：grafana element is shown

In GitLab by @luotian-github on Nov 8, 2019, 07:48
Agree, uncompleted service can not be rolling update. Considering check the status in UI also

In GitLab by @luotian-github on Nov 8, 2019, 07:48
fixed in PR#1117

In GitLab by @sokril on Nov 8, 2019, 08:19
closed

In GitLab by @sokril on Nov 8, 2019, 08:19
assigned to @luotian-github


1.19.3 support?

I saw your reddit post about how there doesn't seem to be a velocity plugin that lets you use portals to travel between servers. Unfortunately for my use case I'm stuck with 1.19.3 due to geyser+switch support.
Thanks in advance!

I looked into upgrading today, without losing the possibility to maintain 1.19.2 aswell, and couldn't figure this out yet.
Ill let you know when I make any progress or if I can manage to do so, but im on it!


Unable to store a MonitorSocket for later use

There does not seem to be any way to store a MonitorSocket along with the corresponding Context in a structure.
This would be useful in the scenario where the underlying fd of the MonitorSocket is registered with an eventloop and a struct is used to store state used in the callback invoked by the eventloop.

I think this is a limitation of the borrow checker, because it prevents structs from referencing their own members. I saw some discussion a while back about fixing it at the language level. I don't know if there's much that can be done to address it here. Given the silence on this ticket, I assume no one else has ideas on how to address this, either. Feel free to reopen if you have a suggestion.

Another approach to fix this issue. This one is better than my previous one as it also allows to send MonitorSocket between threads. Details in pull request.

I saw some discussion a while back about fixing it at the language level.

This was a long time ago, and I haven't heard much about self-borrows in a while, so I don't think we'll see this addressed at the language level any time soon. I'd like to reduce the lifetimes in this library to make it easier to use. I just reviewed a couple PRs, including @darkelement's, that implement Clone for Context. The problem with this approach is that Context is not threadsafe, as per libudev's documentation.

I saw some discussion a while back about fixing it at the language level.

This was a long time ago, and I haven't heard much about self-borrows in a while, so I don't think we'll see this addressed at the language level any time soon. I'd like to reduce the lifetimes in this library to make it easier to use. I just reviewed a couple PRs, including @darkelement's, that implement Clone for Context. The problem with this approach is that Context is not threadsafe, as per libudev's documentation.

The thread-safety issue actually isn't a problem, because the types are !Send. #13 should land soon.

The thread-safety issue actually isn't a problem, because the types are !Send. #13 should land soon.

Fixed in #13, which is now released in v0.3.0: https://github.com/dcuddeback/libudev-rs/releases/tag/v0.3.0.

Fixed in #13, which is now released in v0.3.0: https://github.com/dcuddeback/libudev-rs/releases/tag/v0.3.0.


Update Item

Yesterday I realised that there is no update Item, and trying to implement it myself  was not straight forward, especially the conditional updates and the nested fields when you have lists and maps inside your model. On the same note as the Put ReturnValue, having the option to get the updated fields is also good.
I know you are pretty responsive and quick to add these, I realise that this feature may be the trickiest until now, Let me know if you wanna discuss it here, may be I'll make a PR.
For now I just exported the DocumentClient and made a plain update myself just to not get stuck.

Yea update is a bit interesting because it's really updateOrCreate (DynamoDB will create the item if you call updateItem and it doesn't exist).
From the caller's point of view, I think you'd want a way to express a potentially nested change set on the model. For that, lenses are a very useful tool. So I'd imagine an API something like:
const key = // dynamodb key
const updateLens = XXXModel.update(key)
updateLens.foo.bar.baz.update(value => newValue) // nested field
beyonce.updateItem(lens)

Yes definitely, the lenses will also help when generating the attributes to update in the dynamodb request and may be the conditions if present.


Icon is missing in F-Droid

Same for the readme file. It looks linke this was caused by renaming the master branch to main in the iOS repository. Good thing to rename it IMO, but those image urls need to be fixed, thanks!

Thanks for bringing this up :)
Regarding F-Droid: We'd need to provide this as metadata via one of the supported methods mentioned in https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/. I think creating either the fastlane or triple-t structure directly in our repo would be best, since we could easily adapt these.
Regarding Readme: Yep, will update this.

readme fixed in https://github.com/criticalmaps/criticalmaps-android/commit/4e4481916ebb8bbcc8f9030b8a8e5ce3f63ebc8e


Add some overlooked APF metrics, fix a wrong one

This PR updates the documentation on the metrics from API Priority and Fairness.

/cc @wojtek-t
/cc @tkashem
/cc @deads2k

/lgtm

Something seems to have gone wrong with the CNCF checking. Can I make it try again? Is there a known problem that has been fixed?

close and reopen to prod CNCF CLA checker to do the right thing

@tengqm : I think this is waiting on your approval?

/approve


Fix preact/debug accessing attributes that don't have toString

In some rare cases (e.g. with material-ui v1-alpha), a prop value doesn't have the toString() function, and thus cannot be cast to a string, throwing TypeError: Cannot convert object to primitive value. This should fix that.

Coverage remained the same at 100.0% when pulling 8d34c7f5b9cadfdc5f78a9db88ced9bf4fd72bec on plusCubed:master into 824404bf0ebad47af12686f806f5876dbe499bbe on developit:master.

I've looped @NekR in since he wrote this. Looks good to me though.

Coverage remained the same at 100.0% when pulling 00be0a1571b1adc1e514375907c61ac9292efa64 on plusCubed:master into e026d9e1a871a3f84fb88a499168b4af083673f6 on developit:master.


Absturz bei Verbindungsfehler

Bei fehlender Verbindung stürzt der Adapeter ab.

nina.0
2020-03-07 08:58:12.947
info
(3565) Terminated (NO_ERROR): Without reason

nina.0
2020-03-07 08:58:12.946
info
(3565) terminating

nina.0
2020-03-07 08:58:12.939
error
at process._tickCallback (internal/process/next_tick.js:63:19)

nina.0
2020-03-07 08:58:12.939
error
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)

nina.0
2020-03-07 08:58:12.939
error
at emitErrorNT (internal/streams/destroy.js:91:8)

nina.0
2020-03-07 08:58:12.939
error
at TLSSocket.emit (events.js:198:13)

nina.0
2020-03-07 08:58:12.939
error
at TLSSocket.socketErrorListener (_http_client.js:401:9)

nina.0
2020-03-07 08:58:12.939
error
at ClientRequest.emit (events.js:198:13)

nina.0
2020-03-07 08:58:12.939
error
at Request.onRequestError (/opt/iobroker/node_modules/request/request.js:881:8)

nina.0
2020-03-07 08:58:12.939
error
at Request.emit (events.js:198:13)

nina.0
2020-03-07 08:58:12.939
error
at self.callback (/opt/iobroker/node_modules/request/request.js:185:22)

nina.0
2020-03-07 08:58:12.939
error
at Request.request.get [as _callback] (/opt/iobroker/node_modules/iobroker.nina/main.js:181:38)

nina.0
2020-03-07 08:58:12.939
error
(3565) TypeError: Cannot read property 'indexOf' of undefined

nina.0
2020-03-07 08:58:12.938
error
(3565) uncaught exception: Cannot read property 'indexOf' of undefined

nina.0
2020-03-07 08:58:12.937
error
(3565) Request error{"errno":"ETIMEDOUT","code":"ETIMEDOUT","syscall":"connect","address":"<IP_ADDRESS>","port":443}

nina.0
2020-03-07 08:58:12.934
error
at process._tickCallback (internal/process/next_tick.js:63:19)

nina.0
2020-03-07 08:58:12.934
error
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)

nina.0
2020-03-07 08:58:12.934
error
at emitErrorNT (internal/streams/destroy.js:91:8)

nina.0
2020-03-07 08:58:12.934
error
at TLSSocket.emit (events.js:198:13)

nina.0
2020-03-07 08:58:12.934
error
at TLSSocket.socketErrorListener (_http_client.js:401:9)

nina.0
2020-03-07 08:58:12.934
error
at ClientRequest.emit (events.js:198:13)

nina.0
2020-03-07 08:58:12.934
error
at Request.onRequestError (/opt/iobroker/node_modules/request/request.js:881:8)

nina.0
2020-03-07 08:58:12.934
error
at Request.emit (events.js:198:13)

nina.0
2020-03-07 08:58:12.934
error
at self.callback (/opt/iobroker/node_modules/request/request.js:185:22)

nina.0
2020-03-07 08:58:12.934
error
at Request.request.get [as _callback] (/opt/iobroker/node_modules/iobroker.nina/main.js:181:38)

nina.0
2020-03-07 08:58:12.934
error
(3565) TypeError: Cannot read property 'indexOf' of undefined

nina.0
2020-03-07 08:58:12.933
error
(3565) uncaught exception: Cannot read property 'indexOf' of undefined

nina.0
2020-03-07 08:58:12.925
error
(3565) Request error{"errno":"ETIMEDOUT","code":"ETIMEDOUT","syscall":"connect","address":"<IP_ADDRESS>","port":443}

Adapterversion ist 0.0.15

Teil des Logs
host.iobmaster | 2020-03-07 09:00:57.469 | error | Caught by controller[2]: (node:21794) [DEP0018] DeprecationWarning:  Unhandled promise rejections are deprecated. In the future, promise  rejections that are not handled will terminate the Node.js proc
-- | -- | -- | --
host.iobmaster | 2020-03-07 09:00:57.469 | error | Caught by controller[2]: (node:21794) UnhandledPromiseRejectionWarning:  Unhandled promise rejection. This error originated either by throwing  inside of an async function without a catch block, or by
host.iobmaster | 2020-03-07 09:00:57.468 | error | Caught by controller[2]: (node:21794) UnhandledPromiseRejectionWarning: undefined
host.iobmaster | 2020-03-07 09:00:57.468 | error | Caught by controller[1]:     at process._tickCallback (internal/process/next_tick.js:63:19)
host.iobmaster | 2020-03-07 09:00:57.468 | error | Caught by controller[1]:     at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
host.iobmaster | 2020-03-07 09:00:57.468 | error | Caught by controller[1]:     at emitErrorNT (internal/streams/destroy.js:91:8)
host.iobmaster | 2020-03-07 09:00:57.467 | error | Caught by controller[1]:     at TLSSocket.emit (events.js:198:13)
host.iobmaster | 2020-03-07 09:00:57.467 | error | Caught by controller[1]:     at TLSSocket.socketErrorListener (_http_client.js:401:9)
host.iobmaster | 2020-03-07 09:00:57.467 | error | Caught by controller[1]:     at ClientRequest.emit (events.js:198:13)
host.iobmaster | 2020-03-07 09:00:57.467 | error | Caught by controller[1]:     at Request.onRequestError (/opt/iobroker/node_modules/request/request.js:881:8)
host.iobmaster | 2020-03-07 09:00:57.467 | error | Caught by controller[1]:     at Request.emit (events.js:198:13)
host.iobmaster | 2020-03-07 09:00:57.466 | error | Caught by controller[1]:     at self.callback (/opt/iobroker/node_modules/request/request.js:185:22)
host.iobmaster | 2020-03-07 09:00:57.466 | error | Caught by controller[1]:     at Request.request.get [as _callback] (/opt/iobroker/node_modules/iobroker.nina/main.js:181:38)
host.iobmaster | 2020-03-07 09:00:57.466 | error | Caught by controller[1]: TypeError: Cannot read property 'indexOf' of undefined
host.iobmaster | 2020-03-07 09:00:57.466 | error | Caught by controller[0]:     at process._tickCallback (internal/process/next_tick.js:63:19)
host.iobmaster | 2020-03-07 09:00:57.466 | error | Caught by controller[0]:     at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
host.iobmaster | 2020-03-07 09:00:57.465 | error | Caught by controller[0]:     at emitErrorNT (internal/streams/destroy.js:91:8)
host.iobmaster | 2020-03-07 09:00:57.465 | error | Caught by controller[0]:     at TLSSocket.emit (events.js:198:13)
host.iobmaster | 2020-03-07 09:00:57.465 | error | Caught by controller[0]:     at TLSSocket.socketErrorListener (_http_client.js:401:9)
host.iobmaster | 2020-03-07 09:00:57.465 | error | Caught by controller[0]:     at ClientRequest.emit (events.js:198:13)
host.iobmaster | 2020-03-07 09:00:57.464 | error | Caught by controller[0]:     at Request.onRequestError (/opt/iobroker/node_modules/request/request.js:881:8)
host.iobmaster | 2020-03-07 09:00:57.464 | error | Caught by controller[0]:     at Request.emit (events.js:198:13)
host.iobmaster | 2020-03-07 09:00:57.464 | error | Caught by controller[0]:     at self.callback (/opt/iobroker/node_modules/request/request.js:185:22)
host.iobmaster | 2020-03-07 09:00:57.463 | error | Caught by controller[0]:     at Request.request.get [as _callback] (/opt/iobroker/node_modules/iobroker.nina/main.js:181:38)
host.iobmaster | 2020-03-07 09:00:57.463 | error | Caught by controller[0]: TypeError: Cannot read property 'indexOf' of undefined

installier mal die 0.0.21 via github da ist das gelöst


For branch bug: both branches break the loop

Hello,
I am using SPIRV-Cross to translate SPIRV code generated from OpenCL (with clspv) to Metal.
I found one of my compute shaders generating wrong data and I narrowed the problem to SPIRV-Cross generating wrong code for one of the loops. I am attaching a simplified version of the OpenCL shader, the SPIRV binary and disassembled files, and the Metal output generated by SPIRV-Cross.
spirv-cross-bug-for.zip
Let me explain the problem. This is a piece of code of the simplified shader attached, only contains the loop that SPIRV-Cross is failing to generate:
float maxh = data[0];
for (int i = 1; i < nbins; ++i)
{
    if (maxh < data[i]) maxh = data[i];
}

I am omitting here the SPIRV output generated by CLSPV, but the code seems correct for this simplified version, and indeed works fine on the original/full shader.
Here is the Metal code generated by SPIRV-Cross for that loop:
float _75;
for (;;)
{
    _75 = (_70 < _15._m0[_71]) ? _15._m0[_71] : _70;
    if (!(_71 < 35u))
    {
        break;
    }
    else
    {
        _70 = _75;
        _71++;
        break; // Problem!
    }
}

It does not match perfectly, as some of the SPIRV instructions are executed as part of the previous loop, that you can find on the full shader. But I think is enough to understand the problem. The "break" on the else block should not be there, or should be a "continue".
After debugging the SPIRV-Cross execution I found for the conditional on that loop CompilerGLSL::branch enters the false block with the same BlockID for the "from" and "to" parameters. But it enters the second condition as "is_break(to)" returns true, so the later test "to_is_continue || from == to" is never checked, and it outputs a "break". I could fix the problem by just switching the order of this two conditions, but I don't know if the order is relevant for other cases.
Please, let me know if I can provide any more information or help in solving this issue.
Regards,
Oscar.

Wow. That was a quick response and a quick fix.
Thank you!


[v1.2] casting booleans always returns in True

https://github.com/striglia/pyramid_swagger/blob/swagger_12/pyramid_swagger/tween.py#L293
unfortunately casting string to boolean is not as simple as bool()

Shouldn't it just be bool(json.loads(value))? Are we not loading the json first?

json bodies would already be casted by json.loads(), it's an issue for query/path/form I think

Looks like most people are effectively focusing on Swagger 2.0 at this point, so closing this 1.2 issue.


[WIP] Construction Yard

Taken from #8 :
Acceptance criteria:

[x] Construction Yard is drawn on map
[x] Construction Yard is drawn within viewport
[x] Ability to select Construction Yard
[ ] Ability to place multiple Construction Yards
[ ] When placing Construction Yard - all cells that the ConstYard occupies should be clickable and select the same structure
[x] When selecting the Construction Yard - the "selection box" should span over the entire structure.

To test:

[ ] point and click anywhere on the map and it will place a Construction Yard

Just drawing an image works, but it has to be incorporated in the game itself as an actual entity now:

Drawing within viewport works now as well.

Selected Construction Yard shows a red 'hover' cell:

When not selected:

And when not on the structure:

Selection box on structure spans entire structure. Created a new issue for the fading animation ( see #23 ).

"all cells that the ConstYard occupies should be clickable and select the same structure" basically works but we need a class that 'places' the structure for us and takes the logic within that divides the structure over the map and determines what the top left corner is (so that it knows where to start drawing)

Oh boy I went a bit out of scope:

You can place buildings everywhere now, to solve this I made https://github.com/stefanhendriks/dune2themaker4j/issues/10

Merged, as this became the new "master" anyway. Made https://github.com/stefanhendriks/dune2themaker4j/issues/24 since drawing is not perfect (I just noticed)


Added clarification for ARM Dashboard deployments

Current documentation was not clear for non amd64 platforms. Added an small clarification and command example to deploy it to ARM systems.

This change is

@rf232 all suggestions applied and merge from master.

Added some changes reflecting the changes introduced in this Dashboard PR: #1549

@rf232 Any further comments or suggestions?

@rf232 @devin-donnelly Is this good to go?

This appears valid, although it's weird that we lead with the exceptions first (amd and arm) and then end with the default (which I guess is Intel?).  From a docs perspective, the PR is accurate, but that section could probably use a rewrite to lead with the default first and then the exceptions.

Just updated my fork and checked that all changes where already applied to the master branch. I think we can close this PR.
Thx


Integration with Angular2-seed

I have a bare bone project based off the Angular2-seed located at https://github.com/mgechev/angular-seed
When I try to integrate angular2-bootstrap-confirm I receive
Can't bind to 'message' since it isn't a known property of 'button'
I have successfully integrated into the Angular2 quickstart, but there is something clearly conflicting or missing with the Angular2-seed and Angular2-bootstrap-confirm.

After working for hours, then posting this question, I had a bright idea - maybe I'm not importing the ConfirmModule into the proper NgModule of my project.  I had imported it into my app.module, but was using it in the home.module, moving the import fixed the issue.  My issue, sorry - I thought imports filtered down to sub-modules, apparently not.


ingest intellectually organized objects workflow

https://docs.google.com/document/d/1lQcEt3_slGvSKYmw3hKKGtm9HiLsLEytdbC7oEI0xVo/edit


Faster SNAPGraphReader implementation

This PR is the extension of https://github.com/kit-parco/networkit/pull/160.
The new SNAP Graph Reader performs twice as good as the old one by using mmap() and iterating just once over the file.
In addition, it can now be used for directed graphs too and there are parameters to further speed up the performance if necessary.
I also modified the Graph class in order to reserve space, but not create nodes (here). However this change has shown no difference in benchmarking with larger graphs

@rbange This PR needs a rebase. Can you rebase it, resolve the conflicts in IOGTest and update the PR by force pushing your branch?


[Feature-WIP](inverted index) Filter out and remain predicates that do not support apply by inverted index, and add inverted index regression case

Proposed changes

Filter out and remain predicates that do not support apply by inverted index, like BF predicate, IS_NULL predicate, IS_NOT_NULL predicate.
Add inverted index regression case that based on tpcds_sf1 data set.

Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.6 seconds
load time: 491 seconds
storage size:<PHONE_NUMBER>9 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230128124607_clickbench_pr_85661.html


Users SBAT see only Celo networks (Alfajores, Betanet) on blockscout

Dropdown in top-right should show Celo networks and not non-Celo networks.

fixed by https://github.com/celo-org/blockscout/pull/13


After opening and editing files with nvim in yazi, the preview is not updated automatically.

I have to move the cursor between files to update the preview.

This is intentional and a compromise for performance.
Currently, only changes in any one of the three elements (url, mime, skip) trigger a re-preview. It's simple to re-preview every time a file changes (content, permissions, owner, group, etc.), but it's not an efficient way.

My CPU is Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz and I do not feel any lag in preview when I move between items. Does this performance loss really matter?

I really want this feature, but I'm not sure how to implement it at the moment. Please consider:
On an older machine where the current cursor file is continuously appended to at a millisecond level, how should Yazi handle re-previews?
Should it frequently spawn processes for files like videos and PDFs that rely on other tools (ffmpegthumbnailer, poppler, etc.)?

Maybe the title is not clear, I mean I open a file with neovim in yazi, edit it explicitly, and quit, the preview is not updated as expected. So just trigger update when I quit and the files is changed, and it is uncessary to supervise the file.

The preview is triggered by a watcher, which relies on file change notifications from the operating system and is independent of whether the file is opened.
If you expect that the preview should only be re-previewed when a file is opened and its content changes, I believe this is not a good way. It would lead to inconsistent preview behavior, meaning that any other method causing a content change would not trigger a re-preview.

Fixed by https://github.com/sxyazi/yazi/pull/360


Full support for material-components-web ?

This library looks really promising so far. Definitely the best react implementation of material-components-web I could find. I would like to use this library for a production web app. Are you planning on fully implementing and supporting all the m-c-w components? Any idea how long you will be supporting it for? (As an open-source creator myself, I don't want to assume you're fully committed to this project!)
Looking through your project, I see it's almost complete, just a few are missing:

[ ] mdc-animation
[ ] mdc-auto-init
[ ] mdc-base
[x] mdc-button (missing ripple)
[x] mdc-card
[x] mdc-checkbox
[x] mdc-drawer
[x] mdc-dialog
[x] mdc-elevation
[x] mdc-fab
[x] mdc-form-field
[x] mdc-grid-list
[x] mdc-icon-toggle
[x] mdc-layout-grid
[x] mdc-list
[x] mdc-menu
[x] mdc-radio
[ ] mdc-ripple
[ ] mdc-rtl
[ ] mdc-select
[x] mdc-snackbar
[x] mdc-switch
[x] mdc-textfield (missing advanced states)
[ ] mdc-theme
[x] mdc-toolbar
[x] mdc-typography

@dubert , thank you for your appreciation. Sure, I want to implement all of them and no plans to stop supporting. At the moment i'm implementing Menu component and extending Textfield for fullwidth and multiline. Keep in touch :+1:

Do you have any starting points where you would appreciate contribution?

I've created a few issues from your list. They marked as 'enhancement'. You can assign one of them or create a new one which you would like. Be careful, i've already assigned #13 :)

Just wanted to say I appreciate what you guys are doing! I'll be using this in production also.

Very very nice project....is it possible to have stuff like selects and maybe auto complete. Great guys

@pricetula Yes, sure. I just want to finish Menu component. A little bit tricky there

very good work, it will be a great library after finishing all (specially RTL support)


Bugfix/solidity install

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[SP-6008] - Backport of PDI-19064 - The Append Option in JSON Output will create new files when the number of rows exceed the number of blocs (9.2 Suite)

@ssamora
@smmribeiro
@moraesvc

:white_check_mark: Build finished in 39m 52s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core,engine,plugins/json/core

:ok_hand: All tests passed!
Tests run: 5098, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


Time issue with demand_eq

Currently, the eval function evaluates the demand_eq state variable in no_inst.py with the notion that time is in seconds. However, it is unclear to the user what time step length the t variable should be.
This issue can be closed when:

A state variable that defines what the demand eq’s time step length is: second/day/month/year. The default will be set as month.
The README is updated to tell the user that this new state variable must be the same as the dt variable defined in the control section of the cyclus input file.

wouldn't it be easier if we just did t = self.context.time instead of messing with the whole dt variable?
Without it the user can have an intuitive sense of time rather than having to convert the time into other units.
so if the dt in the simulation is a month (2592000 secs), the equation t variable would be in months.
    def demand_calc(self, time):
        """
        Calculate the electrical demand at a given timestep (time).

        Parameters
        ----------
        time : int
            The timestep that the demand will be calculated at.
        Returns
        -------
        demand : The calculated demand at a given timestep.
        """
        t = time
        demand = eval(self.demand_eq)
        return demand

But generally I agree the clarification in the readme is needed

We can do that, but you need to ensure that the user puts their equation in with regard to the timestep.
Also, not all growth rates will be in regard to the operational time step of the simulation. For example you might consider your growth rate annually, but the time step of the simulation might be weeks, or months, or even seconds. In which case the demand equation needs to account for these differences.
I suppose this is acceptable, since we're already asking users to understand how to input a equation via eval, so they much have some knowledge of how to write python. I'm just hesitant to put most of the burden on the user, when we could solve the problem on the developer side.

So from my understanding, we can move forward in two ways:

Assume that dt is a month and tell the user that the input in the demand_eq assumes that time is in month-long time steps.
Generalize it so that the user can define the time step length of their demand_eq.

Option 1 is easier to implement but we lose generality. I personally would be in favor of option 2. Perhaps, we could implement only month-long and year-long time step options (and not provide minute/second options).
Thoughts? @jbae11 @FlanFlanagan

I think the best way is option 2 with default month. If @FlanFlanagan agrees, I'll make a PR about it once #40 gets merged.

Let's do Option 3:
Make it clear to the user that the demand_eq should have the same time step length as the dt that they defined in the simulation control. Default dt is month-long and so, default demand_eq will also be a month.

Option 3 is my vote.

okay, I'll make the PR once #47 is merged.

closed with https://github.com/ergs/d3ploy/pull/46


K8SPXC-707 read source id from last binlog

Test name
Status

upgrade-haproxy
passed

recreate
passed

big-data
passed

storage
passed

scaling
passed

haproxy
passed

init-deploy
passed

self-healing
failed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

security-context
passed

upgrade-proxysql
passed

demand-backup
passed

smart-update
passed

limits
passed

self-healing-advanced
passed

monitoring-2-0
passed

affinity
passed

operator-self-healing
failed

one-pod
passed

pitr
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

demand-backup-encrypted-with-tls
passed

users
passed

upgrade-consistency
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

scheduled-backup
failed

tls-issue-cert-manager-ref
passed

validation-hook
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/03e802a2507917990b9311d02219e15b8c20528f
image: perconalab/percona-xtradb-cluster-operator:PR-847-03e802a2

Test name
Status

upgrade-haproxy
passed

storage
passed

self-healing
failed

scaling
passed

scaling-proxysql
passed

security-context
passed

big-data
passed

haproxy
passed

init-deploy
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

self-healing-advanced
passed

operator-self-healing
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/03e802a2507917990b9311d02219e15b8c20528f
image: perconalab/percona-xtradb-cluster-operator:PR-847-03e802a2

Test name
Status

big-data
passed

haproxy
passed

scaling
passed

storage
passed

upgrade-haproxy
passed

recreate
passed

init-deploy
passed

self-healing
failed

restore-to-encrypted-cluster
passed

scaling-proxysql
failed

upgrade-proxysql
passed

limits
passed

monitoring-2-0
passed

demand-backup
passed

security-context
passed

smart-update
passed

affinity
passed

one-pod
passed

self-healing-advanced
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

operator-self-healing
passed

pitr
passed

users
passed

upgrade-consistency
passed

demand-backup-encrypted-with-tls
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

scheduled-backup
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/db4b60c3bd78079cd7a5239876cfcd6132b98022
image: perconalab/percona-xtradb-cluster-operator:PR-847-db4b60c3

Test name
Status

recreate
passed

haproxy
passed

storage
passed

scaling
passed

upgrade-haproxy
passed

big-data
passed

init-deploy
passed

scaling-proxysql
passed

self-healing
failed

restore-to-encrypted-cluster
passed

upgrade-proxysql
passed

limits
passed

security-context
passed

monitoring-2-0
passed

demand-backup
passed

smart-update
passed

affinity
passed

one-pod
passed

self-healing-advanced
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

operator-self-healing
passed

pitr
passed

users
passed

demand-backup-encrypted-with-tls
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

scheduled-backup
passed

upgrade-consistency
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/d686437d4ae013b9abfe4246a16ddf21f6c99c85
image: perconalab/percona-xtradb-cluster-operator:PR-847-d686437d

Test name
Status

upgrade-haproxy
passed

storage
passed

scaling
passed

self-healing
failed

big-data
passed

scaling-proxysql
passed

security-context
passed

recreate
passed

restore-to-encrypted-cluster
passed

demand-backup
passed

haproxy
passed

pitr
passed

init-deploy
passed

demand-backup-encrypted-with-tls
passed

scheduled-backup
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

self-healing-advanced
passed

operator-self-healing
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/d686437d4ae013b9abfe4246a16ddf21f6c99c85
image: perconalab/percona-xtradb-cluster-operator:PR-847-d686437d

Test name
Status

recreate
passed

storage
passed

scaling
passed

haproxy
passed

upgrade-haproxy
passed

big-data
passed

init-deploy
passed

scaling-proxysql
passed

self-healing
failed

restore-to-encrypted-cluster
passed

upgrade-proxysql
passed

security-context
passed

limits
passed

monitoring-2-0
passed

smart-update
passed

affinity
passed

demand-backup
passed

one-pod
passed

auto-tuning
passed

self-healing-advanced
passed

proxysql-sidecar-res-limits
passed

users
failed

pitr
passed

operator-self-healing
passed

upgrade-consistency
passed

demand-backup-encrypted-with-tls
passed

scheduled-backup
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/47d22899fd0e7e6dd7e64505b911ac397ca67053
image: perconalab/percona-xtradb-cluster-operator:PR-847-47d22899

Test name
Status

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/5aa85406742f373cb7a5cdf9e3e1db1481f4bf91
image: perconalab/percona-xtradb-cluster-operator:PR-847-5aa85406

Test name
Status

big-data
passed

scaling
passed

haproxy
passed

upgrade-haproxy
passed

recreate
passed

storage
passed

self-healing
failed

init-deploy
passed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

upgrade-proxysql
passed

security-context
passed

limits
passed

monitoring-2-0
passed

demand-backup
passed

smart-update
passed

affinity
passed

self-healing-advanced
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

operator-self-healing
passed

users
passed

pitr
failed

upgrade-consistency
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/85f9ad9fb8f8674b153114e45d6a5981a0ea5779
image: perconalab/percona-xtradb-cluster-operator:PR-847-85f9ad9f

Test name
Status

recreate
passed

haproxy
passed

big-data
passed

scaling
passed

storage
passed

upgrade-haproxy
passed

self-healing
failed

init-deploy
passed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

security-context
passed

upgrade-proxysql
passed

limits
passed

monitoring-2-0
passed

demand-backup
passed

smart-update
passed

affinity
passed

self-healing-advanced
passed

one-pod
passed

auto-tuning
passed

operator-self-healing
passed

proxysql-sidecar-res-limits
failed

pitr
failed

upgrade-consistency
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

demand-backup-encrypted-with-tls
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

scheduled-backup
failed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/45b9faa1ae3a466caeb5b0521595968a63784fde
image: perconalab/percona-xtradb-cluster-operator:PR-847-45b9faa1

Test name
Status

scaling
passed

scaling-proxysql
passed

security-context
passed

upgrade-haproxy
passed

storage
passed

self-healing
failed

recreate
passed

big-data
passed

restore-to-encrypted-cluster
passed

haproxy
passed

demand-backup
passed

init-deploy
passed

pitr
failed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

upgrade-proxysql
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

smart-update
passed

upgrade-consistency
passed

self-healing-advanced
passed

operator-self-healing
passed

demand-backup-encrypted-with-tls
passed

scheduled-backup
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/45b9faa1ae3a466caeb5b0521595968a63784fde
image: perconalab/percona-xtradb-cluster-operator:PR-847-45b9faa1

Test name
Status

upgrade-haproxy
passed

big-data
passed

haproxy
passed

init-deploy
passed

scaling
passed

limits
passed

scaling-proxysql
passed

monitoring-2-0
passed

security-context
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

storage
passed

tls-issue-cert-manager-ref
passed

self-healing
failed

validation-hook
passed

recreate
passed

restore-to-encrypted-cluster
passed

demand-backup
passed

pitr
failed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

self-healing-advanced
passed

operator-self-healing
passed

demand-backup-encrypted-with-tls
passed

scheduled-backup
passed

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/847/commits/45b9faa1ae3a466caeb5b0521595968a63784fde
image: perconalab/percona-xtradb-cluster-operator:PR-847-45b9faa1


Change DB to one that supports ~3 million rows

@lucavgobbi and @pablov suggested Amazon EC2 (free for 12 months). If someone can set up this instance and send in PVT the connection details, I can set this up in the server.

@lucavgobbi set an instance at EC2 and Jarbas is using it already. But (it looks like there's always a but) as the app is running in a different server, importing the datasets to it is taking ages. But it's working… eventually we can import all the records to it. Yay.


feat: expose username and password environment variables

Description

This PR exposes the OPENFGA_DATASTORE_USERNAME and OPENFGA_DATASTORE_PASSWORD environment variables. They can be references directly in the values file, or through a secret. The username and password keys in the secret are also configurable. I took inspiration from Keycloak's way of accessing username and password from an existing secret.
References

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

I made similar changes to our fork or the openfga chart and made a PR before actually checking this one that's been parked here for quite a while.
https://github.com/openfga/helm-charts/pull/163
Hoping to bump this PR for review by code owners and would also propose to make it so that uriSecret gets the same configurability with regards to key selection, perhaps consolide them into one secret.