shorten long message because it's a bit too long

Hi @bengeisler
I had to remove some letters from the long message because it was still a bit too long.
On the issue of the timestamps (I've not yet created a separate issue for it, sorry)
Last week I installed Twincat3 on a new machine (a VM in Virtualbox), I noticed that on that machine I did not have the issue with the timestamps, I'm not sure why.
And although the file now has a correct timestamp in the name it only contains the first message that I log. All subsequent messages are not logged and I notice the following error in TcLogCore.Error:

Message		4/3/2023 10:30:15 899 ms   | 'Tests_Task' (351): Closing file failed. Error thrown by FB_FileClose. Consult Beckhoff InfoSys. Internal Error: 1795

Thanks for following up!
I could reproduce the issue with the long string name. However, it was due to another unit test that set the delimiter (which was an empty string by default) and thus changing the length of the complete log string. I changed the other unit test by resetting the delimiter in the teardown of the test in cc2f9b6. This ensures the maximum string length being logged no matter in which order of the unit tests are being run.
I'm glad to hear that the timestamp issue is working on the new machine! Since I can't reproduce it, I'll leave it for now.
I will have a look into the issue with FB_FileClose. I somehow have the suspicion it could be due to logging every cycle. Did you run any tests with fewer logging calls?

I think it is indeed related to logging every cycle, my cycle time is 50ms, I tried the following:

logging once every 10 cycles => that works
changing the cycle time to 500ms => that does not work

I can reproduce this issue with a unit test introduced in 4fd3dbc.
I'm working on a solution to this, but I need some time. I don't want to wrap all the file system calls into a while loop to finish it in one cycle because logging is not the most important job of a real time system.
I guess the underlying problem is that in every cycle log messages get appended to the buffer, and in each cycle one log message gets appended to the file, so the file is kept open. When you keep logging forever, the file stays open forever...
For now, I'd suggest you use triggered logging as it is described here. For logging every cycle TcLog is probably not the right tool. You can have a look at TwinCAT Scope which could be more appropriate for this.

Hi @slabarque,
I did some more work on this in 6c01f09. The unit test is now parameterized and tests up to 100 consecutive logging calls. To be able to do this, I increased the string buffer size that works in the background and caches the logging messages. To make this more explicit, I introduced a breaking change: the buffer size has to be specified in the declaration of TcLogCore like this:
VAR
	CoreLogger	:	TcLogCore(nBufferSize := 100000);
END_VAR

I updated the library to version 0.2.0.
Let me know if that works for you :)

Actually, I think the point is more to stop logging at some point than how many logs per cycle you use. I introduced a new unit test in 76fdfd4 that logs 100 messages in one cycle, but only once. So if you could refactor your TcUnit tests in a way to only log the results, 21 of them in one cycle should absolutely be feasible (given the buffer size is large enough).
As for the missing truncation above 255 chars: I use the FB_FilePuts from Beckhoff, which is designed to write every string on a new line. The datatype T_MaxString can take more than 255 chars, but as Beckhoff notes, the string functions can only handle 255 chars. I'd stick to that limit in order to avoid unspecified behavior.

I've tried some things based on your recommendations. When I log x messages in 1 cycle and then wait x+2 cycles I get good results but that is not feasible as a permanent solution in my case. When init with a large buffer size (I tried 100000 and went up to 1000000) and I log x messages per cycle for y cycles and then wait x*y+2 cycles I still get the fileClose issue (where x = 21 and y = 17). I'm running out of investigation time, so I will stick to ADS logging for these TcUnit tests and will experiment more with file logging and triggers on a next project.
I also added some additional logging to TcLog to investigate the fileClose issue was amazed to see that the DynamicStringBuffer goes from state STATE_APPEND_DATA_TO_FILE to 'STATE_OPEN_FILE`.

If you are interested I can give you access to my project on Github. It is project I made to review some code a colleague of mine wrote and demonstrate to him the importance of unit testing and logging.
Thanks for your time!

Hi, thanks for the idea with logging the state machine! I'll have a look at this.
I'm about to finish my masters thesis, so I'm also a little bit short of time right now. I can't promise to fix it within the next days.
However, I'd like to point out that the persisting mechanism is optional for this library. You can also use it to log to ADS, but with the added benefit of the string builder built in. Maybe that's helpful in your case.
I'd be happy to have a look at your project to run my fixes against it. And I'm also happy to see that logging and unit testing are slowly making their way into the PLC world :)

I finally found time to follow up on this issue and fixed it in #4. Thanks for the detailed analysis, it was very helpful!
I introduced unit tests for testing up to 50 consecutive cycles with 50 messages logged per cycle without any problems.
I found that for x cycles with y messages each it takes roughly x * y * 4 + 4 cycles to persist them. Better allow for some more cycles.
The necessary buffer size can roughly be calculated by x * y * ~270. 270 is just a rough guess, the Beckhoff info system is quite vague about it. It should be the max string size + a little bit.
Do you still have your project so I can test the fix against it? Thanks!

I'll try make some time in coming days to check the fix.

Thanks! There is a new release that introduces a major performance upgrade for the persistence mechanism and allows to persist up to 100 messages per cpu cycle. The total time is roughly 1.5 * # consecutive cycles with logging. A unit test with 50 consecutive logging cycles and 50 logs per cycle executes within 75 cycles.


removed unused shade plugin

Coverage remained the same at 97.081% when pulling 9a5e4ee2abcb2e37f945bf234218a5e5131a9574 on remove-shade-plugin into 0c297b89c1cf8ee40eca8133b07481011229895c on master.


Managed SNI Improvements

Investigating the managed SNI (Sql Network IOnterface) implementation used in non-windows OS's for another thread there are a number of changes which would be beneficial to make.
SNIProxy is used only by the managed SNI and is at best pointless and at worst possibly harmful.

Consider:
https://github.com/dotnet/SqlClient/blob/9e3f0d625eb5ec15e069a1d8f118d3bac41b61f5/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs#L33-L36
https://github.com/dotnet/SqlClient/blob/9e3f0d625eb5ec15e069a1d8f118d3bac41b61f5/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs#L469-L472
Where we have a single instance which we use to access another single instance which holds an error code that is used by every physical handle in the process to report errors. It's surprising that this works under high load. Errors should be reported as exceptions or function returns not through this single instance.

An example of useless behaviour is
https://github.com/dotnet/SqlClient/blob/9e3f0d625eb5ec15e069a1d8f118d3bac41b61f5/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs#L450-L453
A single instance is fetched by the caller and then the parameters passed in and used. This could be done directly in the caller, there is no virtual or polymorphic behaviour here.

The demuxing code in MarsConnection that deals with received mars packets is complicated and difficult to follow. It is an implicit state machine decoding the current state from multiple variables in a loop. It also has multiple exit points which makes packet lifetimes very difficult to track leading to cached packet leaks to the GC. This can be written as an explicit state machine make it far easier to debug and work with. It may also allow full demuxed packets to be forwarded rather than copied for a perf improvement.
Code based async is used throughout and has many opportunities for small improvements. ValueTask can be used in several areas for non netstandard2.0 builds to possibly avoid TCS and Task allocations on hot paths.

@Wraith2
Ack: I think we can try and gather more data to understand the impact of current v/s proposed changes.
Interesting would be to capture and validate issues with GetLastError() design and if exceptions do flow over and cause disruption.

I started working through how to remove the last error behaviour and it's a minefield. I got 30 files in and stopped because it was clearly too much work to do with other outstanding changes in progress. The singleton behaviour is actually worse than I originally thought because it's stored in a ThreadLocal and if there's any async/threadpool between it being set and fetch it'll be wrong. I'm assuming that at the moment there are none of those but it's not an easy thing to validate, it would be easy to break it without noticing.
It will also affect the native side because it'll change the TdsParser-StateObject interface so it may be best to wait until merging of netfx and netcore are further along.

Ok.
I did see the same design on Native SNI, but hadn't thought of it's association with StateObject.
We might as well, close this topic for now then. We can come back to it, when we have moved over from Native SNI (as that's one of our goals too once we make it a lot stable).

Ok. The trivial methods I'll remove in a small easy PR and leave the error handling rework as a future large change.


Add missing NaturalPersonKYCFields field proof_of_liveness

The proof_of_liveness field is mandatory in order to comply with the KYC requirements for SEP-6.

Hi @ydag, thank you for adding this.


Add support all versions pg-sql.

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
https://github.com/yiisoft/yii2/issues/15265, https://github.com/yiisoft/yii2/issues/18232

It's not easy to review the pull request with all these function imports made. It's better to do such changes separately.


Endpoint for page fault calculation for range of frames

This Endpoint should accept the following GET request:
GET faultsArray?maxFrames=9&referenceString=base64(4,5,6,7,8,9) &FIFO=false&LRU=true&OPT=false&SC=true
It should calculate the amount of page faults for the specified reference string starting with
x frames up to maxFrames. It returns an Array of page faults for specified page replacement algorithms:
{
LRU: [89, 78, 5, 6],
SC: [89, 78, 5, 6],
}

@masterYoda8 , @xgsngxguy  it would be nice if you could provide a range of values that are allowed for the maxFrames Parameter. Moreover, should I add a minFrames  parameter that marks the beginning of the array, or should we start at a fixed number?

I think min number would be a great idea. This also means that we have to input fields in our frontend. Min number should be 1 and max number can be set to 12. Keep in mind to check whether user gave min number input which is greater than max number input. For example 7-5 range which should throw an error message.

I think it would be nice if I can also start at number 4...and then maybe up to 10. Max value can go up to 20 in my eyes.
In short: Range 1 - 20, but it should be possible to start at a specific number in that range.


Using component into the render-icon

Hi,
I would like use Vue components into the render-icon. Do you know how to proceed? Any idea?
Mickael

Please explain more. I don't quite understand what you want to do.

Hi,
Context
In fact i'm using Font Awesome with the version 5. There exists a component version of Font Awesome (https://github.com/FortAwesome/vue-fontawesome). To use a specific icon you can write: <font-awesome-icon icon="spinner" />`.
Problem
With the render-icon, you can specify an HTML content, but if you want specify a component content you can't.
Maybe my need is stupid, but i'm curious to know how to solve this kind of problem. In other word how you can generate HTML content from JavaScript from component...
In the long-term, you could imagine complex components into columns and why not VueTable inside ;-)
I hope my explanation is clearer.
Mickael

@mickaelbaron I don't think that is possible because in order for <font-awesome-icon> to work, Vue has to be able to compile it (because it is vue component). I think the only place that this can be used inside Vuetable is via the __slot or __component special field since Vue can compile and use it. I also don't know if there is any easier way to make this work outside of those mentioned context.

Hi, thanks for your response.
Maybe a day there will be a workaround to solve this issue.
Have a nice day
Mickael

FWIW I am interested in this too...


fix: address mismatch in ids passed to cbr rules

Description
fixes https://github.com/terraform-ibm-modules/terraform-ibm-cos/issues/201
Types of changes in this PR
No release required

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other changes that don't affect Terraform code

Release required

[x] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[ ] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[ ] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.

Checklist for reviewers

[x] The PR references a GitHub issue.
[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

Generated rules with the fix (using the 'complete' example - https://github.com/terraform-ibm-modules/terraform-ibm-cos/tree/main/examples/complete)

@jojustin @daniel-butler-irl @ocofaigh - Should be good to go whenever you have final cycles for review.

:tada: This PR is included in version 5.6.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[midcobra] split Telemetry middleware into sentry and segment middlewares

Summary
see previous PR for motivational context.
This PR just does a split of the code, but is a functional no-op
How was it tested?

compiles
sanity check: opened devbox shell

but didn't really verify that the sentry or segment are being logged properly.

Current dependencies on/for this PR:

main

PR #348

PR #349

PR #351

PR #352

PR #355

PR #358

PR #361   👈

This comment was auto-generated by Graphite.

abandoning in favor of #366


Getting "Network Protocol Error" if mod is in the server

Minecraft Version
1.21.x
Mod Loader Version
0.16.0
Mod Version
1.3.13
Describe the Issue
Whenever i tried joining the server i'd get a "Network Protocol Error", after some binary search it seemed like RpgDifficulty was causing the error
latest.log
Errors below Line 959 (Note: it's not REI, tested without it cause i thought it was a bit sus by the log and previous ones)
No errors in console, only client.
Do you use any other mods except the required ones?
Yes

yes, when i removed your mod it worked just fine

same problem here

still having issues in 1.21.1 Fabric 0.16.5.

How can I reproduce this bug?
The log you sent here is about a bundle item sync issue.

i guess the only way of reproducing this bug is using the same modpack i am.
Also, thats what i find weird because i was getting kicked with my inventory empty.


Fixes Select error

It works this way. Please check and merge if confirmed.

Hi @pklimai,
thank you for your PR!
The problem was due to a bug in Kotlin Wrappers and has been fixed in version pre.329


⚠ Mobitopup has degraded performance

In a893713, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 4633 ms

Resolved: Mobitopup performance has improved in faea65f after 9 minutes.


HELP!  Trying to Link Meeting Guide Data between Orange County Central Offices

We are using version 3.14.12; TMSL IU
The Orange County central offices share a meeting database.  Rather than pointing the www.aanoc.org to the meeting page at www.oc-aa.org, I am trying to link the data with the "Link Meeting Guide" option in the program.
Orange County Central Office - https://www.oc-aa.org/meetings - Parent Region - Change Detection Enabled.
Error:
Invalid response,
WP_Error Object
(
[errors] => Array
(
[http_request_failed] => Array
(
[0] => cURL error 28: Connection timed out after 10001 milliseconds
)
    )

[error_data] => Array
    (
    )

[additional_data:protected] => Array
    (
    )

)
.

hi @fbarnese i'm going to move this to our TSML discussions, i want to put it somewhere that will help future users and i think they are most likely to look there. one sec


Add a small writing style guide

As proposed on #1401, here's a proposal for a small writing guide to clarify common rules for contributors.
CC @AndrejMitrovic

LGTM.

I feel like this has gotten in way too quickly.

I think this needs broader consensus.
As I argued on the similar Phobos PR, we actively need to avoid stuffing CONTRIBUTING.md with trivia. GitHub tells people to read this file before people submit changes, so this should only contain things that people need to read before submitting changes. just because someone somewhere one time submitted a PR that would've been avoided had he read the entirety of our guidelines does not make a case to burden all contributors with more guidelines that they must read.

I think this should be reverted. Feel free to put this on the wiki on a linkable page, though.
@andralex ?

Yah this doesn't quite add a lot of value yet. It would be useful to initiate it as a wiki page and merge it when it gets more significant.

Ok we could move it to the wiki. I'll revert it for now.

@CyberShadow: From that perspective (the link on PR/issue creation), the whole file should be scrapped, though, and replaced with a short bullet list of important things to consider (links to style, our processes, …).

Yep, that's just what I said here: https://github.com/dlang/phobos/pull/4585#issuecomment-239056002


Backfill original_name

This is a script to ensure that images imported from iNat photos have a unique original_name.

Adds the iNat photo_id and uuid to the original_name of Images which were imported from iNat photos prior to Fri Dec 13 15:03:37 2024 -0800. (Later imports already have the desired original_name.)
The point is enabling efficient syncing/updating of Observations.
This is a run-once script which can be deleted after it's run.

NOTE: Some original_names cannot be fixed. Either:

The photo has been deleted from iNat.
The entire iNat observation has been deleted.

coverage: 93.506%. remained the same
when pulling ca55364bdb39806d422d11810c00e44c95e1b491 on 2577-backfill-original_filename
into 7b9b831a404375cbc4212d2010cbefef7a4a8cbc on main.

This PR isn't a thing of beauty, but it works -- I manually tested it locally -- and will be used only once.
I therefore prefer to avoid investing time time to make it pretty.
It takes about 10 minutes to run, primarily because it hits the iNat API no more than once per second, per iNat's request to "eep it to 60 requests per minute". (There are about 600 relevant Observations, and I'm hitting the iNat API ~once per Observation.)
Question
Should this be turned into a Job?

QUESTION
Is it worth the effort to turn this into a background Job?
This isn't a thing of beauty, but

It works (I tested it manually in the dev environment).
It will be used only once.

I therefore prefer to avoid investing time to make it pretty.
It takes about 10 minutes to run, primarily because iNat asks: "keep it to 60 requests per minute", I'm hitting that API once per O)bservation, and there about 600 relevant Obss.

Sounds like no need to make it a job. Good to go, IMO.

Thanks for looking at it and the comments.
On Sat, Dec 28, 2024 at 2:53 PM andrew nimmo @.***>
wrote:

Sounds like no need to make it a job. Good to go, IMO.
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/2608#issuecomment-2564490099,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFDRND7EAZUZN3PBYDT2H4MV3AVCNFSM6AAAAABUKDX4MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUGQ4TAMBZHE
.
You are receiving this because you were assigned.Message ID:
@.***>

This is a one time thing, right?  If so, then I wouldn't merge it into main, but rather copy it over to the server and run it.  You can leave it on this branch as a record of what was done, but I don't think there is value in merging it into main.

Thanks. Will do.
Sent from Gmail Mobile
El El dom, dic 29, 2024 a la(s) 07:25, Nathan Wilson <
@.***> escribió:

This is a one time thing, right? If so, then I wouldn't merge it into
main, but rather copy it over to the server and run it. You can leave it on
this branch as a record of what was done, but I don't think there is value
in merging it into main.
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/2608#issuecomment-2564741330,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFF3D4CM2LUIS6TJZZ32IAA7HAVCNFSM6AAAAABUKDX4MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUG42DCMZTGA
.
You are receiving this because you were assigned.Message ID:
@.***>

Closing this per @mo-nathan's suggestion.


Constructing an IndexedTables from an Array should keep the sparse nature of IndexedTables

Hello,
When creating an IndexTable from an Array, I haven't found (but maybe that's possible) to keep the sparse nature of IndexTables by filtering out values during construction
julia> using IndexedTables

julia> a = zeros(5, 4)
5×4 Array{Float64,2}:
 0.0  0.0  0.0  0.0
 0.0  0.0  0.0  0.0
 0.0  0.0  0.0  0.0
 0.0  0.0  0.0  0.0
 0.0  0.0  0.0  0.0

julia> a[2, 3] = 2
2

julia> it = IndexedTable(a)
─────┬────
1  1 │ 0.0
1  2 │ 0.0
1  3 │ 0.0
1  4 │ 0.0
2  1 │ 0.0
2  2 │ 0.0
2  3 │ 2.0
2  4 │ 0.0
3  1 │ 0.0
3  2 │ 0.0
3  3 │ 0.0
3  4 │ 0.0
4  1 │ 0.0
4  2 │ 0.0
4  3 │ 0.0
4  4 │ 0.0
5  1 │ 0.0
5  2 │ 0.0
5  3 │ 0.0
5  4 │ 0.0

julia> length(it) == length(a)
true

maybe a keyword argument accepting an anonymous function that filter out some values could be defined
julia> IndexedTable(a, filter=x->x==0)
ERROR: MethodError: no method matching IndexedTables.IndexedTable(::Array{Float64,2}; filter=#1)
Closest candidates are:
  IndexedTables.IndexedTable(::Any; idxcols, datacols) at /home/scls/.julia/v0.6/IndexedTables/src/tabletraits.jl:12 got unsupported keyword argument "filter"
  IndexedTables.IndexedTable(::Any...; names, rest...) at /home/scls/.julia/v0.6/IndexedTables/src/IndexedTables.jl:71
  IndexedTables.IndexedTable(::C<:IndexedTables.Columns, ::AbstractArray{T,1}; agg, presorted, copy) where {T, C<:IndexedTables.Columns} at /home/scls/.julia/v0.6/IndexedTables/src/IndexedTables.jl:45 got unsupported keyword argument "filter"
Stacktrace:
 [1] (::Core.#kw#Type)(::Array{Any,1}, ::Type{IndexedTables.IndexedTable}, ::Array{Float64,2}) at ./<missing>:0

julia> length(it) == 1
false

Kind regards

Right now, NDSparse is not exactly an array because we throw KeyError instead of return a default value. So this conversion is correct, like it or not.
I'll open a new issue to track this.

closing in favor of #103

I think constructing an IndexedArray from an Array but filtering out some values doesn't imply the concept of default value. that's (in my mind) a different problem

default value can have some interest when converting IndexedArray to Array but anonymous function to filter out some values have interest when converting Array to IndexedArray

Right now, you can filter the NDSparse as a stop-gap. This makes a good case for supplying a filter function in the constructor. I'm willing to accept the change in a PR, and believe that figuring out #103 is the right way to forward.


don't create additional stargate pods until first one is ready

What this PR does:
Waits to create additional Stargate Deployments until the first one becomes ready. This is only done for standalone-Stargate scenarios where it is not part of a K8ssandraCluster.
Which issue(s) this PR fixes:
Fixes #297
Checklist

[ ] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[ ] CHANGELOG.md updated (not required for documentation PRs)
[x] CLA Signed:  DataStax CLA

Closing since this was addressed by #306.


updated GitHub logo overlapping issue Issue #32

Fixed GitHub logo overlapping issue
Also added a background to the content so it is better visible when using dark colours
https://github.com/Nirbhayparmar/gradientiser-BgGenerator/issues/32
GitHub logo fix

Background for content

Can you show me the mobile version screenshot? Because on large screen this is looking great, but I am not sure about smaller screens.

Can you open a seperate PR for text visibility because a previous PR #31 solved logo overlapping issue. Remove changes related to logo and then open a new PR.


Simplified and formatted

Simplified and formatted, I tested it and it works perfectly

just before i merge, i wanna know some things:

Are those only formatting changes?
are there any changes to logical stuff, or only unnecessary syntax removal/replacement?

nice, is this ready to merge?

nice, is this ready to merge?

Ye

But merge and squash it


chore(issue template): ask people to tag their issues

:+1: makes sense to me

I actually find this clutters stuff - we can tag issues ourselves in a better, searchable way, and issue title is precious space to describe the actual problem. So I'm luke-warm on this change.

I think that's fair. Although it might help put some context around an issue that might help triage a little better (e.g. I recently closed something I thought was a question when it was really a feature request).
I also like the fact that it highlights that thinking about the type of issue is important, hopefully that further might help people opt-out on debugging/usage questions.
Those are both pretty soft arguments though, so i'm fine either way :smile:

I think we still have a problem where its not clear if someone is asking a support question, a bug report, or a feature request.  We can also just remove the title tags when we add the github labels.

I'm going to go ahead and executively close this one - I think that the current template is meeting our needs decently.


Add stable code for release 0.1.0

Signed-off-by: Rodolfo Olivieri<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2a87a96). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #1   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         5
  Lines           ?       128
  Branches        ?        23
========================================
  Hits            ?       128
  Misses          ?         0
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a87a96...4074866. Read the comment docs.


PyCharm can't see my BBC micro:bit

My problem is that after installing the micropython plugin, it won't recognize my BBC micro-bit "Detect" does not work, and when I brows to the device's WIndwos folder, the "OK" button is not enabled.

@mawg Sorry for my late reply. Is this issue still relevant to you? I'm sorry for confusion, but you have to specify the COM port which was assigned to your device by Windows. It's COM4, COM5, or COM + some other number. At the moment I don't have an access to a Windows machine so I cannot tell you why "Detect" button failed to detect it or how you can do it by yourself. I could offer only a naive piece of advice to google how to determine a COM port number on Windows for your BBC Micro:bit.

Hey, I did put the right COM in the path but it gave me this error

Configuration is still incorrect. Do you want to edit it again?

If I continue anyways, nothing happens. I used MicroBitTools. It flashed without any issue.


Update SA1023 to not trigger first in line, inside a foreach without braces

Fixes #3538

Ready for review

Any comments, @sharwell?


⚠ Bofrost.be has degraded performance

In 7d61701, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1569 ms

Resolved: Bofrost.be performance has improved in a870f5a after 6 minutes.


Add PowerShell accelerator for SuppressMessageAttribute

It is well within the norm for PowerShell to define accelerators for common types to make it easier for PowerShell scripters to specify an attribute like ValidateSet or ValidateNotNull and not have to remember the full typename System.Management.Automation.ValidateSetAttribute.
Ditto for System.Diagnostics.CodeAnalysis.SuppressMessageAttribute.  Please consider asking the PowerShell team to add the accelerator SuppressMessage for this type.  It will make PowerShell scripts that need to use this attribute easier to write and read.

I agree that it might be useful super forward-looking, but today this will only help in the case where:

You're running PS 5.1+
The module you're running is using a SuppressMessageAttribute
You don't have Script Analyzer installed

Given all that, this is firmly within the realm of "nice to have" for me, and I'm not sure anything nice to have can make it in PS 5.1 right now. I'm going to place it on UserVoice, though, as something we might want to do in the future for PowerShell.

Sounds reasonable.


Bump to version 3.5.0

Bump to version 3.5.0

Maybe we can checkout a new branch so there are no other commit messages.


Polygon contains() documentation bug

Hi,
the documentation for contains() states: "Returns True if the object’s interior contains the boundary and interior of the other object and their boundaries do not touch at all."
Consider this:
>>> from shapely.geometry import Polygon
>>> outer = Polygon(((0,0), (0, 10), (10, 10), (10, 0), (0,0)))
>>> inner = Polygon(((0,0), (0,5), (5, 5), (5,0), (0,0)))
>>> outer.contains(inner)
True

Obviously, the boundaries in this case do touch. It looks more like contains() checking just whether the interior of inner is completely contained in the interior of outer, without considering the boundaries.

I agree the Shapely wording for object.contains() is not correct.  That said, object.contains() isn't quite as simple as the interior of an object being completely contained by the interior of another object without considering the boundaries.
Since Shapely geospatial operators are mostly or wholly GEOS spatial operators, and GEOS objects.contains() implements the Dimensionally Extended 9 Intersection Model (DE-9IM), looking at the DE-9IM contains mask is helpful:  T*****FF*.  The interiors must intersect, to some extent, but that doesn't disallow the interior of an object from also intersecting the boundary of the outer object.
>>> from shapely.geometry import Polygon, LineString
>>> outer = Polygon(((0,0), (0, 10), (10, 10), (10, 0), (0,0)))
>>> inner = LineString(((0, 0), (5, 0), (5, 5)))
>>> boundary = LineString(((0, 0), (5, 0)))
>>> outer.contains(inner)
True
>>> outer.contains(boundary)
False
>>>

@bixb0012 Do you want to suggest a concrete improvement to the documentation's text or perhaps submit a PR?


Jest CI issues

Creating this to keep track of the problems.
Prior related PRs: #3056, #3096, #3097, #3098
I still get an error sometimes, while running yarn test (i.e. in concurrent mode). This doesn't fail with yarn test-serve --runInBand or yarn test-build --runInBand
The root cause still seems to be that the teardown is initiated before ssr-vue.spec.ts runs.
I wonder if a better strategy would be to use one page per test suite, as described here: https://playwright.dev/docs/test-runners#jest--jasmine
However, when changing the setup to match that, many tests fail (on assertions), possibly because they rely on the page being changed by previous tests in the same test suite (spec file).
 FAIL  packages/playground/ssr-vue/__tests__/ssr-vue.spec.ts (26.31 s)
  ● client navigation

    page.click: Execution context was destroyed, most likely because of a navigation.
    =========================== logs ===========================
    waiting for selector "a[href="/about"]"
      selector resolved to visible About
    attempting click action
      waiting for element to be visible, enabled and stable
    ============================================================
    Note: use DEBUG=pw:api environment variable to capture Playwright logs.page.click: Execution context was destroyed, most likely because of a navigation.
    =========================== logs ===========================
    waiting for selector "a[href="/about"]"
      selector resolved to visible About
    attempting click action
      waiting for element to be visible, enabled and stable
    ============================================================
    Note: use DEBUG=pw:api environment variable to capture Playwright logs.

      111 | test('client navigation', async () => {
      112 |   await untilUpdated(() => page.textContent('a[href="/about"]'), 'About')
    > 113 |   await page.click('a[href="/about"]')
          |              ^
      114 |   await untilUpdated(() => page.textContent('h1'), 'About')
      115 |   editFile('src/pages/About.vue', (code) => code.replace('About', 'changed'))
      116 |   await untilUpdated(() => page.textContent('h1'), 'changed')

I wonder if a better strategy would be to use one page per test suite

Why would that be better? Do you know if there are performance implications?

Just something to try out, because it's incredibly hard to isolate why the teardown seems to happen before the test finishes running. I don't think opening a new window per spec file has much of a performance penalty, but we'd have to check.
You could help with the debugging by running:
DEBUG=pw:api PW_DEBUG=1 VITE_DEBUG_SERVE=1 yarn test-serve

You can also enable slowMo: 1000 here:
https://github.com/vitejs/vite/blob/ffa03ad/scripts/jestGlobalSetup.js#L9-L14

Closing as we've migrated to Vitest https://github.com/vitejs/vite/pull/8076


Revert "fix npm install not working"

Reverts MemberJunction/MJ#8

the root package.json was updated to reference @memberjunction/mjaiengine, but since this package doesnt exist yet npm install would fail


analytics.harmony.one

Description
analytics.harmony.one is planned to be a platform where Harmony users can see all metrics dashboard for harmony ecosystem.
Basically the website will be public and will have a dashboard with metrics taken automatically from:
Social media:
Twitter (followers+tweets+retweets)
Youtube(views+subscribers)
Reddit(followers+messages)
Facebook (engagement,likes,follows)
Telegram (engagement+online+total)
Others (medium+wechat+linkedin+instagram)
DEX:
SeeSwap (users, pools, liquidity, volume) - fetch info from coinspider
Swoop (users, pools, liquidity, volume)  - fetch info from coinspider
ViperDex (users, pools, liquidity, volume)  - fetch info from coinspider
Mochiswap (users, pools, liquidity, volume)  - fetch info from coinspider
Users:
Bridge: assets, users, tx (defi summer)
Davinci: sales, assets, artists
Viper: accounts, assets
Mochi: accounts, assets
Blits: mau, dau, downloads
Economics:
Gateways: fiat, wallets, exchanges
dApps: deploys, transactions, accounts
Staking: validators, delegators, tokens
Token: rank, price, full cap
Developers:
Github: contributors, commits, pull requests
Gitcoin: funded, bounties, follows
Downtime: mainnet, testnet, api
Teams: full time, part time, work hours
Advocates:
dao: spends, votes, members
github: forks, stars, issues
discord: online, messages, total
newsletter: click, open, subscribe
website: clicks, bounces, visits
youtube: views, subscribers
NFT marketplaces:
LMA (user, art sold/on sale)
BeastQuest (user, art sold/on sale)
Soccerplayers (user, art sold/on sale)
Attari (user, art sold/on sale)
BeneFit (user, art sold/on sale)
Mochi.market (user, art sold/on sale)
Bridge:
Horizon ETH (liquidity locked)
Horizon BSC (liquidity locked)
Validators:
Validators Mainnet ( total number elected/ not elected / total staked)
Validators testnet (total number elected/ not elected / total staked)
Tokens info:
fetch Coinspider front page ( https://coin-market-chart.herokuapp.com/)
Context
The website will be the official analytics page for harmony, should load very fast, and should give a very good experience to users, in desktop and also in smartphones
Acceptance Criteria
Best submission wins the whole prize. The judging criteria will be:
Usability (simple and functional)
Must have a responsive design and should work on all modern platforms ESPECIALLY on Smartphone . Light/Dark mode. Consistent with Harmony staking dashboard UI elements/design.
Use of modern tech solutions & open source components. Full source code to be submitted.
Architecture, Design and operating document (Installation/Upgrade/Maintenance)
Test scenarios & Test results submitted
.Scalability of solution. Performance results (Infrastructure requirement for given number of concurrent users/API calls to be submitted).
99.9% Annual uptime for the site.
Reference
Integrate with Dune Analytics like Liquity's dashboard.
Reward
$2000 equivalent in ones as the reward

Is the bounty still open, only issue is the funding for this work


Feature/fix touchable opacity styles

This provides an ability to style the TouchableOpacity element as well as default styles to fix an issue in RN v0.36 .
Also updated the SampleApp to that RN version and fixed the layout issues introduced by that.
Let me know if you want me to change anything

looks good, can you accept?


add ability to disable a plugin

Resolves #136

This functionality was introduced by #209 . This PR can be closed.


Raw Result Testing On VOT2018

I download your Raw result (VOT2018)in google_drive and find the result in the first raw below
|  Tracker Name   | Accuracy | Robustness | Lost Number |  EAO  |
|      model                |  0.590   |   0.178    |    38.0     | 0.447 |
|    SiamRPN++         |  0.601   |   0.234    |    50.0     | 0.415 |
|      ATOM                 |  0.590   |   0.203    |    43.4     | 0.400 |
|      LADCF                |  0.503   |   0.159    |    34.0     | 0.389 |
|       MFT                   |  0.505   |   0.140    |    30.0     | 0.385 |
| model_DaSiamRPN |  0.586   |   0.276    |    59.0     | 0.383 |
|     SiamRPN             |  0.586   |   0.276    |    59.0     | 0.383 |
|      UPDT                  |  0.536   |   0.184    |    39.2     | 0.378 |
|       RCO                   |  0.507   |   0.155    |    33.0     | 0.376 |
|       DRT                    |  0.519   |   0.201    |    43.0     | 0.356 |
|    DeepSTRCF           |  0.523   |   0.215    |    46.0     | 0.345 |
From the result DaSiamRPN, my toolkit is ok. EAO is same as DaSiamRPN paper
if it is possible that I download the wrong data. From your paper EAO is 0.452
By the way I run the model and the result is the same as the Raw result
I really hope for your help.

The small difference may be caused by different evaluation tools, you can try to use VOT2018 benchmark for evaluation.

I see


Investigate cases in which subgroup size 16 is noticeable slower

After running huggingface benchmarks with subgroup size 16 (https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/9499093865), we saw some cases in which subgroup size 16 reported worse performance:

huggingface amp_bf16 inference PLBartForCausalLM: 3.58x vs 2.36x speedups
huggingface bf16 inferece BartForCausalLM: 2.52x vs 1.19x speedups
huggingface f32 training T5Small: 0.65x vs 0.50x speedups

Investigate and create followup issues if needed or write report in this issue.
Env:
TIMESTAMP=20240613123916
JOB_NAME=huggingface-inference-amp_bf16
GITHUB_RUN_ID=9499093865
GITHUB_RUN_NUMBER=102
GITHUB_RUN_ATTEMPT=1
PYTHON_VERSION=3.10
PYTORCH_REPO=Stonepia/pytorch
PYTORCH_COMMIT_ID=22ce6c6508d1d13b263d4c8b1fd6b98505983e92
IPEX_REPO=
IPEX_COMMIT_ID=
LLVM_REPO=llvm/llvm-project
LLVM_COMMIT_ID=765206e050453018e861637a08a4520f29238074
BENCHMARK_REPO=weishi-deng/benchmark.git
BENCHMARK_COMMIT_ID=e90564f719a8df7daf0cff4a245404c435b7693a
TRITON_REPO=intel/intel-xpu-backend-for-triton
TRITON_COMMIT_ID=b25bf436956b8fce31bdd8dba68a9aa3959917e6
TORCHVISION_COMMIT_ID=
TORCHTEXT_COMMIT_ID=
TORCHAUDIO_COMMIT_ID=
TRANSFORMERS_VERSION=4.27.4
TIMM_COMMIT_ID=b9d43c7dcac1fe05e851dd7be7187b108af593d2
LIBIGC1_VERSION=1.0.16510.19-881
LEVEL_ZERO_VERSION=1.3.29138.29-881
GPU_DEVICE=Intel(R) Data Center GPU Max 1550
AGAMA_VERSION=881

So far, we haven't been able to reproduce this behavior on the current llvm-target branch. Will investigate further.

Work on this ticket had been blocked by #1647 for most of last week. We were able to obtain data from a CI run end of last week and will present a summary offline in the meeting.

As discussed in chat offline, varying performance between different CI runs (based on the same commit) are still a problem for this investigation.
We'll try to still identify a consistent outlier in the performance comparison with the different subgroups sizes and then investigate what causes that performance difference.

After comparing CI runs 4 and 5, three outlier models could be identified where sub-group size 16 consistently across both runs provided worse performance than sub-group size 32:

AllenaiLongformerBase training with float16 and amp_fp16
XLNetLMHeadModel training with float16 and amp_fp16
BlenderbotSmallForCausalLM inference with amp_fp16

For XLNetLMHeadModel, neither sub-group size provides a speedup over Pytorch execution, so the model was excluded from further investigation.
AllenaiLongformerBase
Comparing device timing from unitrace for both SG-sizes shows two Triton kernels that are among the GPU kernels that take up the most time.
For SG-size 32:
                                   Kernel,        Calls,            Time (ns),     Time (%),         Average (ns),             Min (ns),             Max (ns)
"triton_poi_fused_index_add_new_zeros_13",          179,            480605600,     8.665852,              2684947,                28800,              2943360
"triton_poi_fused_index_add_new_zeros_25",          178,            443019040,     7.988125,              2488871,                 6080,              2830400

For SG-size 16:
                                   Kernel,        Calls,            Time (ns),     Time (%),         Average (ns),             Min (ns),             Max (ns)
"triton_poi_fused_index_add_new_zeros_13",          178,            631492960,    10.590560,              3547713,                 2720,              4099520
"triton_poi_fused_index_add_new_zeros_25",          178,            629485440,    10.556891,              3536435,                 6080,              4015200

Whereas these two kernels each take up ~8% of the overall execution time of the model with SG-size 32, they take up 10.5% with SG-size 16.
The average execution time of the kernel also increases from 2.6ms to 3.5ms, a 1.3x slowdown.
The kernels are attached to this comment. They are both rather simple, but both use tl.atomic_add. @chengjunlu had confirmed in a chat offline that performance for atomic operations is a known issue, so that the performance difference potentially stems from this operation.
BlenderbotSmallForCausalLM
Comparing device timing from unitrace for both SG-sizes shows one Triton kernel that is among the GPU kernels that take up the most time.
For SG-size 32:
                                   Kernel,        Calls,            Time (ns),     Time (%),         Average (ns),             Min (ns),             Max (ns)
"triton_red_fused__log_softmax__to_copy_view_8",           15,             42188320,     6.827563,              2812554,              2708160,              2900960

For SG-size 16:
                                   Kernel,        Calls,            Time (ns),     Time (%),         Average (ns),             Min (ns),             Max (ns)
"triton_red_fused__log_softmax__to_copy_view_8",           15,             60684640,     9.484119,              4045642,              3979680,              4196800

Whereas the kernel takes up less than 7% of the overall execution time of the model with SG-size 32, it takes up 9.5% with SG-size 16.
The average execution time of the kernel also increases from 2.8ms to 4ms, a 1.43x slowdown.
The kernel is attached to this comment and is also rather simple. It however uses a reduction. From previous investigations by @victor-eds, it is known that the current pattern used for reductions in the XPU backend is less efficient for SG-size 16, as it generates significantly more assembly instructions, so the performance difference most likely stems from this known issue.
add_new_zeros_25.txt
add_new_zeros_13.txt
softmax_to_copy_view_8.txt

I filed #1867 and #1868 to as follow-up to investigate the root cause of the two outliers. That investigation currently has lower priority.


Any way to simulate a server error?

I'm wanting to test that something for websocket.onerror, what would I need to do in the mocked server to invoke this on the websocket?

Right now the only way to trigger the onerror is by trying to connect to an invalid or closed connection. Something like this:
it('.onerror will be fired', (done) => {
  // uncomment the following line and onerror will not be triggered
  //const server = new Server('ws://localhost:8080');
  const socket = new WebSocket('ws://localhost:8080');

  socket.onerror = function error() {
    assert.ok(true, 'websocket does not have a server to connect to');
    done();
  };
});

If you are looking for something on the server to manually trigger an error like so:
it('errors can be sent from the server', (done) => {
  const server = new Server('ws://localhost:8080');
  const socket = new WebSocket('ws://localhost:8080');

  server.on('connection',  () => {
    server.triggerError() // this does not exist right now
  })

  socket.onerror = function error() {
    assert.ok(true, 'the server has sent an error');
    done();
  };
});

I can add the functionality. Just let me know.

Yes, the second example is what I am talking about. Adding a triggerError method on the server mock would be awesome!

@thoov I don't think the first is triggered even when using websockets instead of socket io. A way to do this would be great!

@thoov I guess that triggerError never happened?
Sorry to add a "me too", but this is an important function of a mock library. I want to exercise the error handling of my client code (which, given the way developers think, is often broken). And it's definitely your second case. I don't want an invalid endpoint - it should be valid - but causing errors in some cases.
Should I do it and make a pull request?  Or is it big enough that it will cause conflicts with your refactor?

@TimMurnaghan Thanks for reminding me. Just published 7.1.0 where you can call server.simulate('error');. Here is the PR: #184


Crashes when rendering gltf model with skeleton

Hi,
Three-rs crashes when I try to render a gltf model with a skeleton. The crash happens at src/render/mod.rs:719. This happens because we get a bone before a skeleton.
I've temporaraly fixed it by iterating twice, once for the skeletons and again for the bones.
Thanks.

Thanks for the files! I'm able to repro now.
@alteous do you know if this is expected from gltf? we might need to stash those bones somewhere then, until the skeleton comes.

I wonder if this will be affected (positively?) by #203. cc @randomPoison

I'll certainly test it out and make sure it doesn't cause a problem with the new implementation. @afonso360  what is the licensing on the glTF files you provided? Could they be added to the three repo (or rather the example-data repo to be used for examples and regression testing?

Unfortunatley i think that might be a more complicated issue. I got the model from here, changed a few things, did the animation and exported. I'm not sure that the original license covers this use case.
However, i've quickly created another example animation which shows the same issues. I've uploaded it here:
2_twisty_cube.gltf
buffer_2_twisty_cube.bin
This one is completely mine, so feel free to use it.

I can confirm that the changes in #203 avoid this issue when loading glTF files, but the underlying bug is easy to reproduce by making the first child of a Group a Bone and then the next child the Skeleton it belongs to (note that you do this by adding the Skeleton first then the Bone, because internally the children are listed in reverse of the order in which they are added).
Internally, the issue has to do with how the renderer handles skeletons and bones. When the renderer walks the node hierarchy, it pushes any skeletons it finds onto a stack. When it finds a bone, it assumes the bone belongs to the skeleton at the top of the stack (i.e. the skeleton it found most recently). This assumption doesn't match how the three-rs API allows users to put Skeleton objects anywhere in the scene's hierarchy.
Personally, I think the best solution is to somehow limit bones/skeletons such that the bones in a skeleton must be "children" of that skeleton. In practice, any other setup doesn't make sense, and allowing skeletons/bones to be put anywhere only allows users to inadvertently create nonsensical hierarchies. If that's not desirable, I think it would be possible to rework the renderer to fully adhere to the public API's semantics.

This assumption doesn't match how the three-rs API allows users to put Skeleton objects anywhere in the scene's hierarchy.

Three supports having the skeleton separately from the meshes it affects. But not the bones - I don't see the point of having them outside of the skeleton. So we are in agreement here, and just need to adjust the code to enforce it (earlier and more politely - a panic is also sorta enforcement).

I dunno if this is the best place to discuss it, but my suggestion would be to limit skeleton/bone hierarchies to only be composed of Bone objects, with a single Skeleton at the root. The user would be able to add bones (and only bones) as children of a Skeleton, and they could add bones (and only bones) as children of other bones. There are some fiddly details that would have to be worked out, but this approach would enforce the relationship between bones and skeletons.

A problem with the solution I described above: How would we handle the case where we want to attach an object to a joint in a skeleton? For example, say we have a skinned character model and we want to have it hold an object in its hand. Under the current model, we could easily add the model to the Group that represents the character's hand. But if skeleton hierarchies can only be made up of bones, how do we have another object follow a joint in the skeleton?
I could imagine adding some kind Follows constraint that allows you to specify that an object should always be moved to the world position of another object, which would effectively allow an object to be attached to another without having an actual parent/child relationship. I don't know that's actually a better solution, though.

@randomPoison right, we can't have bones only in there.

I could imagine adding some kind Follows constraint that allows you to specify that an object should always be moved to the world position of another object, which would effectively allow an object to be attached to another without having an actual parent/child relationship. I don't know that's actually a better solution, though.

I've been thinking around this idea for a long time, albeit not so deeply. The conclusion I came up with is that parent/child relationships are bad in general and should be gone. Instead, all objects should only have the world space transformation tracked. And there should be a set of physical constraints between them. Some of the constraints would then simulate the old-style parent-child relationships.
However, this is too futuristic and experimental. Three-rs is a fine place to try out things internally, but it's not meant to expose unconventional APIs to the users. So we are pretty much settled on having the traditional parent-child hierarchies here, for convenience reasons.

Note that glTF does not currently require a particular skeleton structure — the bones do not have to form a tree, and (if they are a tree) there may also be other nodes in that tree. The skin.skeleton property is optional, and not used at all in some glTF implementations including three.js. There has been discussion of removing it from the spec entirely.
See https://github.com/KhronosGroup/glTF/issues/1403 for details and links to related issues, and feel free to comment there. 🙂


Update mbedtls to 2.16.0 (LTS release) + ubsan hack

Update mbedtls version to 2.16.0 which is an LTS version, we should probably stick to that since maintaining it will probably be easier.
Bonus:
~Do not call memcpy with length 0 during mbedtls_ssl_read. (I don't like this, but couldn't find another way, I'll try to contact the mbedtls people to seek another solution, I don't understand why there is no "poll" kind of function).~
EDIT: Well, ofc it's passing NULL as dest parameter and not the length zero that the sanitizer doesn't like. So, I made a better hack that does not require us to hack into the library (and it's much much better :) ). We simply pass a 1 byte buffer to it (keeping length to 0). See the change in stream_peer_mbed_tls.cpp
This prevents runtime errors with use_ubsan=1 when calling mbedtls_ssl_read with NULL buffer and 0 length during poll. Closes #25591 .

Don't you mean 2.16.0?

Don't you mean 2.16.0?

Yes I do :dancer:

Thanks!


JoErNanO: Watch buffalo-airporttaxi.com

JoErNanO requests the watch of the watch_keyword buffalo\-airporttaxi\.com. See the Metasmoke search here and the Stack Exchange search here.

buffalo\-airporttaxi\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

!!/approve

Coverage remained the same at 65.422% when pulling fb4116c63e87f9c5a5bc18f5bad84ac08e84e0d8 on auto-blacklist-1526177216.6951854 into e4fb2b1274fd2aae2cde94bef6cc27177d6714e3 on master.


Update OrientJdbcConnection.java

support tx

Hi @robinZhao
Thank you very much, I'm checking the PR.
In the meantime, could you please sing the license agreement on CLAHub?
Thanks
Luigi

Hi @robinZhao
Thank you very much, I'm checking the PR.
In the meantime, could you please sing the license agreement on CLAHub?
Thanks
Luigi

hi:
I singed the agreement.
thanks


ModuleNotFoundError: No module named 'filedate'

Hey! Thanks for this great tool! I almost paid for Metadatafix.com.
I am a beginner coder so I might have done something wrong but I am getting the following error when reach up to Step 4 of https://github.com/joshua-holmes/google-photos-metadata-fix?tab=readme-ov-file#how-to-use-it
Is this a bug? Or am I doing somthing wrong??

Hey, thanks for reaching out about your question.
The error is caused because you have not installed all of your dependencies. filedate is one of those dependencies. Installing the dependencies is done in step 3, but poetry is needed for that to work.
However, if you don't want to go through the trouble of installing `poetry, I'll give you a shortcut. Try typing this into your terminal to install the dependencies, then just continue with step 4:
pip3 install \
exif \
filedate \
filetype \
Pillow \
pillow-heif \
progressbar2 \
pytest \
pytest-mock \
python-dateutil \
python-utils \
Unidecode \
whatimage

same issue

Try running python3 -m pip list


Added smooth Navigation bar template

I had added an animated Navigation Bar containing Logo and 6 anchor tags.
I am a hacktoberfest participant , please merge the PR.

Done @mudit023

Done

Done @mudit023

Please add the comments

In both HTML and CSS files?

Done @mudit023

You haven't added gif in the Readme file . Please check again and add comments in both html and css so that it can become easier for others to understand

All done @Susaksham , have a look now.


Updating entityId

Hi
I just wonder if this description is valid as it is possible to update the entityId by using the Teams Javascript SDK to update it.
"{entityId}: The ID you supplied for the item in this tab when first configuring the tab."
Regards,
Oskar

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8dfa1a29-bcf4-0cc5-ae3a-b185a00fd7bc
Version Independent ID: c68181e1-151b-fc78-2671-fe9b397b702e
Content: Get context for your tab - Teams
Content Source: msteams-platform/tabs/how-to/access-teams-context.md
Product: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

@OskarNet -  Generally we assign the entityId to item in tab while configuring the tab.
We can update the entityId via Graph API or SDK's but we can lost the original context of item which may be saved in storage.
Also in the documentation , it is not mentioned that we can not update the entityId.
Please let me know if you still have any doubt/query.

@OskarNet - Could you please let me know if you are still facing any issue on this.
If your issue is already resolved, Could you please close it.

Well, it would just be clearer to mention that it is possible to modify it. Like it text is now it sounds like that is not the case.

Closing this issue for now. Please feel free to reopen this issue if you are still facing the issue.


Methods from base class are not called

Godot version:

e2e20ae
Issue description:

Base.gd
extends Node2D
class_name Base

func _ready() -> void:
	print("ready")

func _process(delta: float) -> void:
	print("process")

Inherited.gd
extends Base

When you attach the Inherited.gd to a node, the methods are not called.
Minimal reproduction project:

ReproductionProject.zip

I guess you need to call super() on the methods for that to happen.

Can fix this first? I found so many times I need redefine methods and call super()

Seems fixed in b76dfde
Except for _init(), see #50590


srpm fails when spec file is not in the project root dir and there is a custom create-archive: action

I've been scratching my head in https://github.com/cockpit-project/cockpit-podman/pull/1016 and https://github.com/cockpit-project/cockpit/pull/17450 about some packit config cleanups which we want to do. Part of it is that they stop dynamically creating a spec file in the project root directory, and move to a valid spec file in packaging/projectname.spec. We really don't want to keep the .spec in the root dir, that's just clutter -- it should go together with debian, arch, etc. packaging.
What I am seeing can be reproduced with https://github.com/martinpitt/python-dbusmock/ , which is a fairly simple and standard (wrt. packit config). With a pristine checkout, packit srpm works fine. But when I add a custom create-archive:
--- packit.yaml
+++ packit.yaml
@@ -12,6 +12,10 @@ files_to_sync:
   - src: packaging/python-dbusmock.spec
     dest: python-dbusmock.spec

+actions:
+  create-archive:
+    - sh -exc 'git archive HEAD | xz > python-dbusmock-$(git describe).tar.xz; ls python-dbusmock-*.tar.xz'
+
 jobs:
   - job: copr_build
     trigger: pull_request

Then packit srpm fails the same way as I saw in these (much more complex) PRs:
2022-06-14 13:53:13.818 schema.py         WARNING The 'metadata' key in jobs is deprecated and can be removed.Nest config options from 'metadata' directly under the job object.
2022-06-14 13:53:13.818 schema.py         WARNING The 'metadata' key in jobs is deprecated and can be removed.Nest config options from 'metadata' directly under the job object.
2022-06-14 13:53:13.818 schema.py         WARNING The 'metadata' key in jobs is deprecated and can be removed.Nest config options from 'metadata' directly under the job object.
2022-06-14 13:53:13.818 schema.py         WARNING The 'metadata' key in jobs is deprecated and can be removed.Nest config options from 'metadata' directly under the job object.
2022-06-14 13:53:13.827 base_git.py       INFO   Using user-defined script for ActionName.create_archive: [['sh', '-exc', 'git archive HEAD > python-dbusmock-$(git describe).tar.xz; ls python-dbusmock-*.tar.xz']]
2022-06-14 13:53:13.829 logging.py        INFO   + git archive HEAD
2022-06-14 13:53:13.829 logging.py        INFO   ++ git describe
2022-06-14 13:53:13.836 logging.py        INFO   + ls python-dbusmock-0.27.5-8-g203cfe6.tar.xz
2022-06-14 13:53:13.836 logging.py        INFO   python-dbusmock-0.27.5-8-g203cfe6.tar.xz
2022-06-14 13:53:13.837 upstream.py       INFO   Created archive:
2022-06-14 13:53:13.837 upstream.py       INFO   	parsed   path: /var/home/martin/upstream/python-dbusmock/python-dbusmock-0.27.5-8-g203cfe6.tar.xz
2022-06-14 13:53:13.837 upstream.py       INFO   	absolute path: /var/home/martin/upstream/python-dbusmock/python-dbusmock-0.27.5-8-g203cfe6.tar.xz
2022-06-14 13:53:13.837 command_handler.py INFO   Nothing to clean.
2022-06-14 13:53:13.837 utils.py          ERROR  Preparation of the repository for creation of an SRPM failed: '/var/home/martin/upstream/python-dbusmock/python-dbusmock-0.27.5-8-g203cfe6.tar.xz' is not in the subpath of '/var/home/martin/upstream/python-dbusmock/packaging' OR one path is relative and the other is absolute.

This doesn't make sense to me -- why would it require the spec file to be in the root dir? The docs explicitly say it can be somewhere else, and without create-archive that works fine.

One workaround which is arguably a bit weird is to build the tarball in packaging/ subdirectory:
--- packit.yaml
+++ packit.yaml
@@ -12,6 +12,10 @@ files_to_sync:
   - src: packaging/python-dbusmock.spec
     dest: python-dbusmock.spec

+actions:
+  create-archive:
+    - sh -exc 'git archive HEAD | xz > packaging/python-dbusmock-$(git describe).tar.xz; ls packaging/python-dbusmock-*.tar.xz'
+
 jobs:
   - job: copr_build
     trigger: pull_request

However, while that is easy in this reproducer, it's much harder in real projects where you call make dist -- one would have to explicitly mv it.

Found the problem @_@
it's one-liner
the function we are using for computing relative paths cannot work with subdirs; python has another that can - seriously...

I'm unable to reproduce locally, so let's track it as a new issue.


feat: Set container manager types and support podman :anchor:

coverage: 80.276% (-0.3%) from 80.625%
when pulling 6e0aba2d63dcabe24b83b239021697b49a33910a on feature/add-podman-manager
into 5b92a585320d0c9288bbd5109daada39c851a631 on main.


psyche search indexer & client component

Replaces the basic page title/description searcher with https://github.com/dragonwocky/psyche for faster site navigation and page content searching.

Hi @dragonwocky
This is awesome, thanks!
I have some ideas to improve it, but I'm going merge it as is and open new issues.


The contract has already been initialized

At the 5th step (Initialize Factory)
Scheduling a call: marseille.testnet.new()
Doing account.functionCall()
Receipt: 5QYfUzQaNisH7EWV4pynDMS7zpxKjWDybA24ZBzoE5Bq
Failure [marseille.testnet]: Error: {"index":0,"kind":{"ExecutionError":"Smart contract panicked: The contract has already been initialized"}}
ServerTransactionError: {"index":0,"kind":{"ExecutionError":"Smart contract panicked: The contract has already been initialized"}}
at Object.parseResultError (/usr/local/lib/node_modules/near-cli/node_modules/near-api-js/lib/utils/rpc_errors.js:31:29)
at Account.signAndSendTransactionV2 (/usr/local/lib/node_modules/near-cli/node_modules/near-api-js/lib/account.js:160:36)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async scheduleFunctionCall (/usr/local/lib/node_modules/near-cli/commands/call.js:57:38)
at async Object.handler (/usr/local/lib/node_modules/near-cli/utils/exit-on-error.js:52:9) {
type: 'FunctionCallError',
context: undefined,
index: 0,
kind: {
ExecutionError: 'Smart contract panicked: The contract has already been initialized'
},
transaction_outcome: {
block_hash: '6tYUZ93nt2a7g1NVWy5Hw4MPyE6iU72NZytSAZEY1C8e',
id: 'GhazSZ7pH2AAT4wgcYSXF39uwUTNTMArCHeDuohfNjCZ',
outcome: {
executor_id: 'marseille.testnet',
gas_burnt:<PHONE_NUMBER>670,
logs: [],
metadata: [Object],
receipt_ids: [Array],
status: [Object],
tokens_burnt: '242793217967000000000'
},
proof: [ [Object], [Object], [Object], [Object] ]
}
}
How can I erase previous contract to create a new one, and initialize it with the procedure specified in README file

I have not neardev file.
I tried to erase sputnikdaofactory2.wasm and download again. Apparently it works.
Thank you, and thank you again to solve my other issue !


Can I create a session file manually? (Cannot login)

--login doesn't work for me, it gets to the checkpoint, and no matter how many times I tell Instagram that yes, it was me, and then repeat the command, it always gets the checkpoint again.
Tried using a troubleshooting script from the docs, it fails at
HTTP redirect from https://www.instagram.com/graphql/query to https://www.instagram.com/challenge/?next=/graphql/query[REDACTED]
Cookie import failed: JSON Query to graphql/query: Expecting value: line 1 column 1 (char 0)

despite me being logged into instagram on firefox.
Is there a way I can just simply make a session file myself by copying over a cookie from my browser? Would be great if somebody could provide an example of how to format and how to name the session file. Or at least the cookies file? I can follow the link the script outputs before failing and can get the .json it seems to require through the browser.

Running the troubleshooting script through a VPN helped.


[GOBBLIN-870] Adding abfs scheme

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-870

Description
Adding supported abfs scheme
https://www.cloudera.com/documentation/enterprise/latest/topics/admin_adls2_config.html
https://docs.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-abfs-driver
Print stacktrace
Tests
trivial changes
Commits
[GOBBLIN-870] Adding abfs scheme

Codecov Report

Merging #2725 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #2725      +/-   ##
============================================
+ Coverage     45.01%   45.02%   +0.01%
- Complexity     8740     8742       +2
============================================
  Files          1884     1884
  Lines         70266    70266
  Branches       7709     7709
============================================
+ Hits          31628    31638      +10
+ Misses        35709    35701       -8
+ Partials       2929     2927       -2

Impacted Files
Coverage Δ
Complexity Δ

...blin/service/modules/core/GitFlowGraphMonitor.java
73.77% <0%> (ø)
23 <0> (ø)
:arrow_down:

...e/modules/flowgraph/datanodes/fs/AdlsDataNode.java
50% <0%> (ø)
2 <0> (ø)
:arrow_down:

.../org/apache/gobblin/cluster/GobblinTaskRunner.java
66.19% <0%> (+0.46%)
29% <0%> (ø)
:arrow_down:

...lin/restli/throttling/ZookeeperLeaderElection.java
72.22% <0%> (+2.22%)
13% <0%> (ø)
:arrow_down:

...he/gobblin/writer/FineGrainedWatermarkTracker.java
84.67% <0%> (+2.41%)
29% <0%> (+1%)
:arrow_up:

...in/java/org/apache/gobblin/cluster/HelixUtils.java
39.25% <0%> (+3.73%)
13% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3523dbc...344ad44. Read the comment docs.


Add debug logs to KeyRefresher for Thread identity

In our application code, we are using multiple threads which invoke the KeyRefresher class. But only a subset of them are found to be running after a specific time. So, we want to verify if there are any exceptions in the threads, and which threads are currently running when Trust Managers and Key Managers are refreshed.
Signed-off-by: Ashwin Tumma<EMAIL_ADDRESS>

Thank you for your comment, @pranavbhole, on https://github.com/AthenZ/athenz/pull/1525 . Incorporated changes in this PR; somehow DCO was failing in the other.

Is there any reason why just using "[%thread]" in your slf4j configuration xml file doesn't give you the needed details?


Control of max submitted jobs to host

I got this error when submitting jobs with SoS to our cluster:
sbatch: error: Batch job submission failed: Job violates accounting/QOS policy (job submit limit, user's size and/or time limits)

I then checked: showq indicates I have submitted 482 jobs (!! most of them declined, of course) . But in my configuration file I did have:
    max_running_jobs: 30

also I have set -J to 30. Am I doing something wrong here? It is true that -J will override max_running_jobs, and SoS should at least recognize one of these settings?

Please update your submitting sos instance and check again. The problem was caused by the new batch submission method that was designed for faster execution on local host, but PBS does not stack jobs and submit them altogether. Therefore an option batch_size was introduced which is set to 1 for PBS.

Ok, I will test it more on my end and let you know.

Not the case here. I am using a task spooler with script
[10]
input: for_each={'i': range(100)}
task:
sh: expand=True
  echo {i}
  sleep 100

Command
$ sos run test -c ~/docker.yml  -q ts -J 10

shows that there are always 10 running jobs
$ sos status -c ~/docker.yml -q ts  -s running
859af4841863cade	0b867c3c3e496af1 default_10	   1 min 34 sec	running
62eeb2fc9fdf659a	0b867c3c3e496af1 default_10	   1 min 33 sec	running
30ca39d5c884f755	0b867c3c3e496af1 default_10	   1 min 33 sec	running
9b3d4b39b9919b9a	0b867c3c3e496af1 default_10	         33 sec	running
902daf1d12dbc73e	0b867c3c3e496af1 default_10	         30 sec	running
bcdecd6c35093b7b	0b867c3c3e496af1 default_10	         28 sec	running
939cb4c376d2e243	0b867c3c3e496af1 default_10	         28 sec	running
280bdae91652bb8b	0b867c3c3e496af1 default_10	          3 sec	running
abaf2f4c76a3ee3e	0b867c3c3e496af1 default_10	          1 sec	running

-v4 will show a bunch of messages like
DEBUG: submit f66ce86db5d7e988: tsp -L f66ce86db5d7e988 sh ~/.sos/tasks/f66ce86db5d7e988.sh

and you should not see jobs submitted all at once to remote host.

I was in fact using -r host; also a more complex workflow. My account is currently fully queued. I'll try this simple one once it is freed up, then try to make a MWE of my case, if it is still problematic.

-r means submitting from remote host, then that instance of sos should be updated. I guess you already know it hough.

I am sorry, it must have been a glitch on my end -- at some point I used pip install --upgrade --user switch that installed a copy from pip to ~/.local on my cluster. Then for non-pip versions that got updated and  installed into my conda they were overridden by what's found in ~/.local. I think it now works as intended. Sorry for having to have you tested it ...


proposed update to use 'locals'

@XChenP and @jacksandom - This is passing tests and ready to be merged back to #113.

@XChenP - Per your approval, I've gone ahead and merged the PR into your feature branch. Thanks!


include!() support

Hello,
It would be great to have racer work with capn proto generated Rust code.
I think this is an include!() problem. You can test this for yourself like this:

git clone https://github.com/dwrensha/capnpc-rust
cd capnpc-rust
cargo build   (probably requires nightly rustc)
cd example/addressbook
cargo build
vi addressbook.rs
try to 'gd' on line 39 address_book.init_people(2) -> not found (init_people)
try to type address_book.  -> not found

Does capnpc-rust write the addressbook generated source anywhere? Racer currently needs the source code to do completions / find definitions at the moment

It does, and this may be the tricky part because it relies on an OUT_DIR env var supplied by rustc.
For example, on my system the source file winds up here:
target//debug/build/addressbook-20f8a45beadaa3ee/out/addressbook_capnp.rs
The include!() to find the file is:
include!(concat!(env!("OUT_DIR"), "/addressbook_capnp.rs"));

This enhancement would also be great for working with gl-rs (which does something similar with OUT_DIR).

Probably related to #693
Have the same problem with vulkan_rs

It would be great thing for those who use https://github.com/rust-lang-nursery/rust-bindgen and construction like:
include!(concat!(env!("OUT_DIR"), "/c_lib_include.rs"));

I think we can support include! itself.
But other macros like concat! and cargo environment variables like OUT_DIR are major obstacles :fearful:
So... yeah I don't say we never support this, but we can't support this kind of feature immediately, sorry.

@kngwyu

But other macros like concat! and cargo environment variables like OUT_DIR are major obstacles fearful
So... yeah I don't say we never support this, but we can't support this kind of feature immediately, sorry.

But what about this particular case:
include!(concat!(env!("OUT_DIR"), "/c_lib_include.rs"));

?
It is recommended way for code generation according to official cargo docs, is it hard to match such code with regexp and look for last modified file in: target/(debug|release)/build/${crate_name}-*/c_lib_include.rs ?

@Dushistov
OK, I'll try it.

@kngwyu
Great! Thank you.

Hi, is anyone working on this, because I don't want to duplicate effort.


3.0.0-m2 - NPE on a query

Hi,
Non blocking for me, but I think we should fix the NPE or return better error - FYI
on demodb:
1.
java.lang.NullPointerException:
SELECT count(*) FROM Orders GROUP BY OrderDate.format('yyyy')
2.
works as expected:
SELECT count(*), OrderDate.format('yyyy') as year FROM Orders GROUP BY year
3.
return strange recordsets:
SELECT count(*), OrderDate.format('yyyy') FROM Orders GROUP BY OrderDate.format('yyyy')
4
works as expected:
SELECT count(*), OrderDate.format('yyyy') as year FROM Orders GROUP BY OrderDate.format('yyyy')

Thanks @santo-it
I'll check it asap
Luigi

Fixed on develop
Closing, thanks!
Luigi


Slow-mo executes basic.forever as soon as it's declared

microbit.org-ticket: 2622
When the slow-mo option is used, the code inside the anonymous function argument for things like basic.forever() is executed as soon as it is declared. So in cases where we have variables initialised in the "on start" block, they will be undefined at that point and cause a Program Error: r.isRef is not a function error.
The program below is a simple example illustrating this issue:
let dot: game.LedSprite = null
basic.forever(() => {
    dot.move(1)
})
dot = game.createSprite(0, 0)

https://makecode.microbit.org/_cyRWqFU6Jbmp

@riknoll interesting bug. Looks like slow-mo is changing the execution order.

Totally possible. We might need to revisit how we instrument the code. Right now it just inserts pauses at breakpoints

@riknoll this is fixed right. Resolved.


[DatePicker] New DatePicker component in new gestalt-datepicker package

This PR creates new component: DatePicker.
DatePicker introduces new dependencies: react-datepicker and date-fns. To maintain the lightness of gestalt, DatePicker is introduced in a new package gestalt-datepicker.
To use it, it must be installed and imported: import Datepicker from "gestalt-datepicker"
This PR has these major changes:

refactors rollup-config.js to allow multiple gestalt packages.
creates a gestalt-datepicker package with the DatePicker component, flow-typed coverage, and tests.
updates gestalt/docs to include a beta DatePicker component and multiple use cases.

PENDING IMPROVEMENTS:

gestalt-datepicker to use dynamic imports for locales in /src/datePickerUpdateLocale.js

TODO

[x] Accessibility checkup
[x] Update documentation
[ ] Add/update Tests >> Needs revision: tests  ok, but fail due to set up
[x] Format PR title: ComponentName: Description.

moving date-fns out

moving date-fns out
export function registerLocale(localeName, localeData) {
const scope = typeof window !== "undefined" ? window : global;
if (!scope.localeData) {
scope.localeData = {};
}
scope.localeData[localeName] = localeData;
}


Replace service id in URL with a value of my choice?

Hello,
I wonder if it is possible to replace service id with something else in service URL for Jersey provider? Or make it possible? Let's say with ecf.jaxrs.jersey.server.pathPrefix value, for example.
In other words, if service URL is http://localhost:8080/1 is it possible to replace the "1" with another value?

Hi,
Yes it is possible to replace the /1 with some other string.   The reason it is 1 is because it needs to be unique for each service instance, and the remote service id (1 in typical case) does that.
It's not enough to use the pathPrefix only, however to do so...as typically this will result in /pathprefix/1.
This can be easily addressed as well, but before refreshing my own memory about how to do this let me leave it at that and see if this is necessary.
Thanks,
Scott

Thanks for the quick response.
Well, I've been trying to figure it out for a while.
I've tried to configure the service context path through DS Component annotation and ended up with something like this:
@Component(property = { "service.exported.interfaces=*", "service.intents=jaxrs",
    "service.exported.configs=ecf.jaxrs.jersey.server", "ecf.jaxrs.jersey.server.uri=/test",
    "ecf.jaxrs.jersey.server.exported.interfaces=MyInterface" })

But it stil gives me http://localhost:8080/1/test (or http://localhost:8080/test/1 if I go with ecf.jaxrs.jersey.server.pathPrefix instead of ecf.jaxrs.jersey.server.uri as you mentioned).
So help would be very helpful  if it's not too much trouble for you.

Hi Airaketa
I will respond more fully later this evening.   It currently requires extending a class and I'll explain that later but I'm considering adding properties based customization in next release version.

Hi Airaketa.  I haven't forgotten about this, I just had something come up.  I've decided to do two things:

I have an example that I'm completing of how to create a new remote service provider...based upon the jersey provider, that shows how to override the use of the remote service id (i.e. /1) in the path.   This will work with the current version of JaxRSProvider release.

Add to the JaxRSProvider to allow folks like yourself to customize the use/or not of remote service id via service or system properties (e.g. like the pathPrefix).

Hi Airakea.  WRT 1 in my message above:
I've added a new example project here:
https://github.com/ECF/JaxRSProviders/tree/master/examples/org.eclipse.ecf.provider.jersey.ext.example
This project is an extension of the jersey server remote services provider allows you or others to customize the URL creation at runtime.   There are two classes:  Activator and ExtJerseyServerContainer.  The activator has code that allows a new provider to be made available with config id:  ecf.jaxrs.jersey.server.ext.   You can use this provider in the student service example (StudentServiceImpl class) by adding a service property:  service.exported.configs=ecf.jaxrs.jersey.server.ext
The ExtJerseyServerContainer class is where the url path prefix can be customized.  This is by implementing this method (overrides superclass method that is responsible for the '/{serviceId}' ...e.g. '/1' in the url path:
https://github.com/ECF/JaxRSProviders/blob/c2d869b747869f3d7c3346bc387c72fe7793afbd/examples/org.eclipse.ecf.provider.jersey.ext.example/src/org/eclipse/ecf/provider/internal/jersey/ext/example/ExtJerseyServerContainer.java#L27
As you can see, to get an empty string (rather than /1) just return "".   Or you can specify any prefix you want via the pathPrefix service property, which will be then available at runtime in the ExtJerseyServerContainer.servletPathPrefix variable.
I intend to create my own example usage of this extended jersey provider, but first I want to complete 2.  With 2 in place, it won't be necessary to create an extended provider as per 1 at all, but rather it will be possible to set a servletPathPrefix and have that be used instead of /1.   I wanted to create the 1 example anyway, however, because it does allow other more-specialized customization of the provider behavior, which some may wish to do as well.

Hi Scott,
Thank you so much for your help in solving this issue. I will try to implement this for my own service.
Adding the new service property would also be very useful. So I will definitely be watching and waiting for a new version to come out.

Hi Airaketa.
I've just released version 1.10.0 of the JaxRSProviders.
I made a number of subtle changes to assist in implementing your use case.
First, I added a new system/service property for both/all JaxRSProviders called includeRemoteServiceId which defaults to 'false'...meaning that the /1 will be default not be added to the remote service URL as it was in the past.  If the includeRemoteServiceId is set to true, howeveer, the /1 will be added as suffix as it was previously.  See the page describing the includeRemoteServiceId as well as other system/service properties:
https://github.com/ECF/JaxRSProviders/wiki/JaxRS-Distribution-Provider-Configuration-Properties
As before, the pathPrefix system/service property allows an explicit path prefix to be set for the remote service servlet.   This Karaf tutorial shows how this works:
https://wiki.eclipse.org/Tutorial:_JaxRS_Remote_Services_on_Karaf
I think this will be more understandable, but it does have the consequence that if the same pathPrefix is used for two service instances the second will fail.   In that case it might be helpful to set includeRemoteServiceId to true.
I'm going to close this issue.   Please reopen if these changes and the example distribution provider described above are not sufficient for dealing with your use cases.


Allowing Cookies in ReportServerCredentials

Would it be possible in your latest version to allow or set cookies in ReportServerCredentials?
Thanks,

I think so.


Support for ASM.JS target

I am building in-browser tool to design and program FPGAs using Yosys and Arachne-PNR.
Yosys provides ability to build for the  ASM.JS target. Would it be possible to add similar ability to the Arachne-PNR?

I'm new to emscripten.  I played around with a bit and was able to get arachne-pnr to build and serialize the chipdb files with it.  (See the emscripten branch.)  I guess I'd need to a second link to embed the binary chipdb files.  What interface would you want?  Would just calling main with string args do it?

Yes, @cseed calling main with a string would do the trick.


[DO NOT MERGE] testing linter can cancel all other CI workflows

We need to add the license:check as well lol

We need to add the license:check as well lol

this is a dummy PR triggered just so CI can break. I will address this separately. thanks for bringing it up


fileNameChanged event

Event to handle filename changes (either when loading defaultImage or loading a file)

Thanks for that!
I merged this commit in another pull-request (Pr/49 #54) after resolving the conflict.


bootstrap tabs problem

Google maps doesn't initialize on tabs. Any solution ?

see #347

Thanks that's solved the problem.

Perfect! :+1:  close this if its ok.

Thanks @lluiscanals
There is also an example on ngMap.github.io. Please search with "router"


Drop (revert) allEntries option in favor autoConfigure

Operating System: Ubuntu 18.04
Node Version: 10.2.1
NPM Version: 6.1.0
webpack Version: 4.10.0
webpack-hot-client Version: 3.0.0

[ ] This is a bug
[ ] This is a feature request
[x] This is a modification request

Code

i think not required
Expected Behavior
We implement allEntries option (but not released). After spend a lot of time on migration from webpack-dev-server to webpack-serve in many projects (i use git version and build script, because i needed add hot client not only first entry point) i found this option is misleading and unnecessary.
We already have autoConfigure option and we can implement more universal solution:

autoConfigure: true (maybe add alias first) - mean modify only first entry (as works right now).
autoConfigure: 'all - modify all entries.
autoConfigure: ['list', 'of', 'entries'] - modify only entries which in array.

This values of option are enough in 99% use case. Also no new option and more universal solution.
Actual Behavior
allEntries configure only all entry points. Also no easy solution to configure list of entries.
For Bugs; How can we reproduce the behavior?
not the bug
For Features; What is the motivation and/or use-case for the feature?
not the feature

I disagree with your assessment. Two boolean options is inherently simpler and less complex than a single option with multiple potential values, with an infinite number of potential requested values. As allEntries will in all likelihood be seldom-used unless chunks are being manipulated, a straightforward option is preferred.

@shellscape I disagree too. A lot of configs contain not only one entry point, also may values in webpack have same values. Example splitChunks.chunks can contain initial, async all, array and function, it is enoght in 99% use case.  When you have one entry point you don't require allEntries, but when you have many entrypoint (very very othen part of their do not require for hot client) you should write bug config around where add hot client, where not. What we need allEntries if this does not solve easy configuration in most cases :confused:

Or we can rename allEntries to entries with only two values true and function It is solve all problem with big and complex configuration

(Use the edit button please)
What you're proposing is more complex and honestly more confusing. I do not believe that your proposal is good architecture. Users have three courses of action:

default behavior - first entry in each compiler configuration
all entries in each compiler configuration
manual configuration

If users need more than 1 or 2, or they need something more custom, they can turn off auto config and set it up themselves for full control. What you are proposing is the old approach of do-everything-and-try-to-anticipate-every-need-of-the-user-ever that got webpack-dev-server into trouble. We've written in stone the three different choices users have, with the last being empowerment of the user to use whatever setup they want to, manually. That's enough flexibility, and minimizes complexity in the module.
That's all we need.

@shellscape hm, okey, let's leave this as is, when wait release new version with allEntries option? (in same case it is very comfortable).

I wasted a night because allEntries defaults to false. QAQ

Bummer. It's right there in the documentation too: https://github.com/webpack-contrib/webpack-hot-client#allentries

Because I am not using webpack-hot-client directly.
When the webpack-serve is updated, I don't know that there is such a change.
Just a little do not understand why the default value is not true.
Anyway, I successfully solved my problem.


Build Pathology HoVerNet Model Zoo Bundle

Fixes https://github.com/Project-MONAI/MONAI/issues/5181
Description
Build HoVerNet model zoo bundle
Status
Ready/Work in progress/Hold
Please ensure all the checkboxes:

[x] Codeformat tests passed locally by running ./runtests.sh --codeformat.
[x] In-line docstrings updated.
[x] Update version and changelog in metadata.json if changing an existing bundle.
[x] Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
[x] Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
[ ] Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
[ ] Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
[ ] Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

Hi @drbeh, I try to run the inference part in my local env, but get this error error.log, could you help take a look at it? And also help address comments by @SachidanandAlle in the inference part. Thanks!

@KumoLiu this one needs to be fixed too. Thanks
https://github.com/Project-MONAI/tutorials/blob/5a497332b2b9df201d59e60f9f1062a11babc144/pathology/hovernet/inference.py#L136

Hi @drbeh, I have updated all the results, this PR is only waiting for the update of the performance curve from Michael.  Could you please help double-check the license descriptions in the README? If everything is ok, this PR can be merged first and I will create another PR to update the curve once I get the link. Thanks!

Hi @KumoLiu, the inference is not working anymore because of the post-processing. Do you know why?
2022-12-13 21:09:05,835 - ignite.engine.engine.SupervisedEvaluator - ERROR - Current run is terminating due to exception: applying transform <monai.transforms.compose.Compose object at 0x7f3490071b20>
2022-12-13 21:09:05,862 - ignite.engine.engine.SupervisedEvaluator - ERROR - Engine run is terminating due to exception: applying transform <monai.transforms.compose.Compose object at 0x7f3490071b20>
Traceback (most recent call last):
  File "/home/bhashemian/workspace/MONAI/monai/transforms/transform.py", line 102, in apply_transform
    return _apply_transform(transform, data, unpack_items)
  File "/home/bhashemian/workspace/MONAI/monai/transforms/transform.py", line 66, in _apply_transform
    return transform(parameters)
  File "/home/bhashemian/workspace/MONAI/monai/apps/pathology/transforms/post/dictionary.py", line 535, in __call__
    d[self.instance_info_key], d[self.instance_map_key] = self.instance_map_post_process(
  File "/home/bhashemian/workspace/MONAI/monai/apps/pathology/transforms/post/array.py", line 735, in __call__
    instance_contour = self.generate_instance_contour(instance_mask, offset)
  File "/home/bhashemian/workspace/MONAI/monai/apps/pathology/transforms/post/array.py", line 561, in __call__
    inst_contour = generate_contour(inst_contour_cv)
  File "/home/bhashemian/workspace/MONAI/monai/apps/pathology/transforms/post/array.py", line 462, in __call__
    raise ValueError(
ValueError: Invalid coutour coord [ 1.  13.5] is generated, areas may contain boundaries or small holes

Hi @drbeh, since the post-processing is not robust, I have encountered this problem before, if you draw the wrong data, you will find that it may contain some holes in some instances, which cannot be avoided in the whole post-processing. Thanks!

I searched further for the cause of the error and found that the default dtype setting in Watershed and GenerateWatershedMarkers is not very reasonable and causes problems when the number of instances exceeds 256. I create a PR to change the default value. https://github.com/Project-MONAI/MONAI/pull/5732
Since the dtype value changed, we may change SaveImage in Inference or remove it. May need @drbeh to confirm here. Also in the tutorial repo.
https://github.com/Project-MONAI/model-zoo/blob/b54e8b0b45fdad456e005c4100548dfbcc162cf8/models/pathology_nuclei_segmentation_classification/configs/inference.json#L105-L122
I also added a workaround way to prevent the issue when the instance contains holes.
https://github.com/Project-MONAI/MONAI/blob/d1cdf416f3041c09cda4cd17afaa6ba97318ef0f/monai/apps/pathology/transforms/post/array.py#L735
I also take a look at the wrong case, which instance looks like this.

/build

how you fine tune the model?
you have models/model.pt (as part of the bundle)
For stage 0 what is the value for PRETRAIN_MODEL_URL ?

how you fine tune the model? you have models/model.pt (as part of the bundle)
For stage 0 what is the value for PRETRAIN_MODEL_URL ?

Hi @SachidanandAlle, for most of the hyperparameters we set them according to the values in the original repo.
Since we used nv-imagenet weight as our pretrained weight in stage 0 which is non-public, so we didn't put the link here.

That makes sense, I will add it.

That makes sense, I will add it.

and by default your checkpoint loader for stage 0 will load that.. unless user specifies PRETRAIN_MODEL_URL.. will that possible and makes sense?  this is when user wants to fine tune the model (means, train additional/new samples over existing bundle model that we are releasing)

and by default your checkpoint loader for stage 0 will load that.. unless user specifies PRETRAIN_MODEL_URL.. will that possible and makes sense? this is when user wants to fine tune the model (means, train additional/new samples over existing bundle model that we are releasing)

Hi @SachidanandAlle, I have added the final weight for stage 0. Users can simply train stage 1 from that weight. And also if they want to train from stage 0, they could specify a MODEL URL. If they don't specify a MODEL URL, then it will only train the decoder without pretrained weight.

and by default your checkpoint loader for stage 0 will load that.. unless user specifies PRETRAIN_MODEL_URL.. will that possible and makes sense? this is when user wants to fine tune the model (means, train additional/new samples over existing bundle model that we are releasing)

Hi @SachidanandAlle, I have added the final weight for stage 0. Users can simply train stage 1 from that weight. And also if they want to train from stage 0, they could specify a MODEL URL. If they don't specify a MODEL URL, then it will only train the decoder without pretrained weight.

Just verified.  Logistically Looks good now.

/build

The blossom ci test failed due to breaking changes of hovernet. We may need to wait for monai 1.1 release and then merge this bundle. Hi @KumoLiu @Nic-Ma @drbeh , what do you think?

perhaps you can set it to 1.1.0rc2 for now? I think rc2 has all code changes it needs

/build

/build

/build


Update neo diagram before version release 0.13

Update neo diagram before version release 0.13

Fixed by #1384.


Test breaking out individual clues into separate notes, embedding the entire note into the Image Analysis page

Note pages can be embedded within other note pages in Obsidian. Doing so may make the vault graph view functionality more useful.
Need to make sure such embedding works within Quartz as well.
In general I need to think more about how to better use Obsidian/Quartz functionality to make visual connects between important concepts without cluttering the site.

This has now been tested and verified working in Quartz. Here is the first page I've tested it with.
Converting this issue for further consideration of methodology and implementation of it across the vault.


'userConfig' and 'generateJsonReport' should be added to the plugin exports

I'm trying to use this plugin, but it currently conflicts with a local "after:run" hook in my code. By exporting these two items, I can include a direct call to them and mirror the "after:run" hook in the plugin.

It might even make sense to move the cypress hooks into their own functions and then export those. It would be cleaner and make using multiple plugins much simpler.

Hi @fitzsimb , Looks like you have encountered the multiple cypress on events. Please refer to this issue, if you're looking for a quick fix.

It might even make sense to move the cypress hooks into their own functions and then export those. It would be cleaner and make using multiple plugins much simpler.

It would be nice to export the internal generateJsonReport function, however, it relies heavily on the context in which you're running it, in which case it needs the test result object, which is only available in after:run or after:spec hooks, so practically, if there is only a chance for you to invoke this generateJsonReport function in either of these hooks, then we might as well just set it up for you.


Issue with integration Firebase in sub-project

Xcode version: 10.2.1
Firebase SDK version: 6.3.0
Firebase Component: Analytics and Performance
Component version:

I am trying to add Firebase Analytics and Performance to the subproject, Can I even do that?
Facing issue on

Not using Cocoapods, Adding it manually.

Please help here.

Hi @vishal91 thanks for the report.
What exactly do you mean by "subproject"?
For some reason the modulemap in GoogleUtilities isn't picking up a required framework, StoreKit. If you go to the target options in Xcode, go to the "Build Phases" tab and expand the "Link Binary With Libraries" section you can click the + sign and add StoreKit.
Let me know if that works!

@ryanwilson By sub-project, I mean dynamic framework.

The Firebase pods are static frameworks and cannot be dependencies of dynamic frameworks. They can be dependencies of other static frameworks.


corrected an event name in  wizard docs stepclick.fu.wizard -> stepclicked.fu.wizard

confirmed https://github.com/ExactTarget/fuelux/blob/master/js/wizard.js#L257 thx for the fix


User should not be able to try to create a post or a thread via the Tab view without credentials setup.

Original bug report

https://bsky.app/profile/mathewlowry.bsky.social/post/3lcg4meidic2n

Addressed with latest release.