Check if application metrics are intended to be disabled

Simple attempt at fixing https://github.com/istio/istio/issues/34388
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[x] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @kevin-lindsay-1. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SGTM. @douglas-reid any concern?

@googlebot I signed it!

/ok-to-test

@kevin-lindsay-1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

lint_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test lint_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

gencheck_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test gencheck_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-ipv6-k8s-tests_istio

lint_istio
e1d6a83df9d0eea33412d00a83d3e55229a9ce4d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevin-lindsay-1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test unit-tests_istio

release-test_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test release-test_istio

integ-helm-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-multicluster-tests_istio

integ-security-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-security-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-telemetry-mc-k8s-tests_istio

analyze-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
1d4bf1e4f637daf1acc0e14b57ce1fc55467d135
link
/test integ-ipv6-k8s-tests_istio

lint_istio
e1d6a83df9d0eea33412d00a83d3e55229a9ce4d
link
/test lint_istio

gencheck_istio
e1d6a83df9d0eea33412d00a83d3e55229a9ce4d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@bianpengyuan do you know why tide still hasn't run? I'd like to get all my ✅  taken care of.

tide will unblock when PR is approved. Thanks!


Develop

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: matejkriz:x: reviewpad[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


Add authentication to guardian using google idtoken (from google SSO login)

Summary
Right now, I saw that the only way to know which user did some action is by using AUTHENTICATED_USER_HEADER_KEY or X-Auth-Email request header (default). It seems that anyone could just change the email on request header to act as someone who create appeal/approve request. On my project, I need to add some kind of auth mechanism to make sure that the request is coming from legitimate user (in my case, user which is logged-in via Google SSO)
Proposed solution
Adding new interceptor for authentication using google's idtoken. If you have a frontend dashboard which has login via Google feature, you could integrate it with Guardian.
There will be configuration to enable/disable this auth interceptor, and if idtoken validation is disabled, it will fallback to default auth checking using X-Auth-Email request header
Related pull request: https://github.com/odpf/guardian/pull/349

The existing guardian is intended to be served behind an auth service/proxy such as shield or Google IAP and not to be directly consumed by the client. Therefore, the current approach is considering any value from the header (AUTHENTICATED_USER_HEADER_KEY) as a legitimate user email provided by the auth service, not client.
Although I agree that your use case is valid and common, it also should be introduced into guardian as a configurable approach e.g.: the authentication method can be configured through config.yaml whether to use header key, SSO login, or any other supported method.
Any suggestions @ravisuhag @bsushmith @haveiss?

I see your point, thanks for pointing that out. I wasn't aware that guardian should be behind IAP, but let's say that I'm going to deploy it without IAP or shield, is there any security precaution that I should consider when using guardian features and I only use the google idtoken interceptor?

Although I agree that your use case is valid and common, it also should be introduced into guardian as a configurable approach e.g.: the authentication method can be configured through config.yaml whether to use header key, SSO login, or any other supported method.

I'm open to any suggestions about the configuration 👀

I agree with suggestion from @rahmatrhd . @swallowstalker Actually, not just Guardian most of our services expect Shield or any other auth mechanism to be placed in front. But, idea of having an optional auth system within tools completely makes sense. My proposal would be move auth interceptor in a single place in https://github.com/odpf/salt or Shield to make it reusable. If using salt we can introduce a auth package which can then be used Guardian and should be made optional as Rahmat suggested.

would that be ok if i move the interceptor code to github.com/odpf/salt/auth/grpc/idtoken.go, and then import it on internal/server/server.go just like this PR? do I need to change the config.yaml structure?

@swallowstalker Instead of moving it right away in salt. Let's create an auth package in github.com/odpf/guardian/pkg/ which can then later be easily moved to salt.
Also, now that we are moving towards introducing different ways to establish the identity of users we should generalize the configs.
Something like:
auth:
 provider: default/google
 options:

and in auth package, we can have a generic interface that each provider should meet.  Thoughts?
cc @rahmatrhd @bsushmith @AkarshSatija

A reference for anyone checking this issue: https://github.com/salrashid123/google_id_token

@swallowstalker Instead of moving it right away in salt. Let's create an auth package in github.com/odpf/guardian/pkg/ which can then later be easily moved to salt.

Agree, I will move interceptor code into pkg dir
Maybe we can have structure like this?
auth:
 provider: default/google/oidc
 options:
  oidc:
   audience:
   eligible_email_domains:

default has no additional config at all, how about that?

@swallowstalker We would need to pull out AUTHENTICATED_USER_HEADER_KEY  also in this. Which i think could be part of default auth provider.

so it would be something like this?
auth:
 provider: default/google/oidc
 options:
  default:
   authenticated_user_header_key:
  oidc:
   audience:
   eligible_email_domains:

Yes

auth:
  provider: default
  default:
    header_key:

auth:
  provider: oidc
  oidc:
    audience:
    eligible_email_domains:

^ these look simpler IMO

auth:
 provider: default/google/oidc
 options:
   audience:
   eligible_email_domains:

I think keeping the options key makes it easy to identify that these are the provider options. But we can omit the low-level provider key. Thoughts? If we see challenges with this approach even what Rahmat is proposing should be good as well.

I'm leaning towards @rahmatrhd idea, because i thought that specifying the provider type on the config will give less empty valued-fields on the implementation struct. If we choose default, i think it's better to have oidc entire config value to nil, and vice versa, rather than having 1 options struct with multiple empty fields (imo)
type AuthConfig struct {
  Provider string `mapstructure:"provider"`
  Default DefaultConfig `mapstructure:"default"` # this will be nil if we choose oidc, or
  Oidc OidcConfig `mapstructure:"oidc"` # this will be nil if we choose default
}

type DefaultConfig struct {
  HeaderKey string `mapstructure:"header_key"`
}

type OidcConfig struct {
  Audience string `mapstructure:"audience"`
  EligibleEmailDomains string `mapstructure:"eligible_email_domains"`
}

instead of
type AuthConfig struct {
  Provider string `mapstructure:"provider"`
  Options AuthOptions `mapstructure:"options"`
}

type AuthOptions struct {
  HeaderKey string `mapstructure:"header_key"` # this will be empty if oidc is chosen
  Audience string `mapstructure:"audience"` # this will be empty if default is chosen
  EligibleEmailDomains string `mapstructure:"eligible_email_domains"` # this will be empty if default is chosen
}

Sounds good . Let's go with it.

hi all, i've refactored auth interceptor into pkg/auth package, but i'm still wondering about how to support backward compatibility for AUTHENTICATED_USER_HEADER_KEY
here's my attempt to support previous version without making anyone break their old config when upgrading guardian to latest version, what are your thoughts on this?
https://github.com/odpf/guardian/pull/349/commits/5149a63c14d794d6d1019aedd7ab73cc6a2b1f4d

hi all, i've refactored auth interceptor into pkg/auth package, but i'm still wondering about how to support backward compatibility for AUTHENTICATED_USER_HEADER_KEY
here's my attempt to support previous version without making anyone break their old config when upgrading guardian to latest version, what are your thoughts on this?
5149a63

@swallowstalker This is fine.

adding this as part of v0.6.0 milestone

closing this as https://github.com/odpf/guardian/pull/349 has been merged


Parent versions not updated inside pom files in integration module

Description:
Parent version section is not updated to the correct version in the test-result-service [1]   and tests-kubernetes-integration [2] pom.xml files.  current value is hard coded
[1] - https://github.com/wso2/product-sp/blob/45c89ff78950cc8493fa72a77fd5e3d49bcdffbb/modules/integration/test-results-service/pom.xml#L25
[2] - https://github.com/wso2/product-sp/blob/45c89ff78950cc8493fa72a77fd5e3d49bcdffbb/modules/integration/tests-kubernetes-integration/pom.xml#L26
Suggested Labels:
Type/Bug

Since we did not run the above-mentioned module for each and every release, Jenkins will not automatically update the versions in the POM file. That is why we have a version mismatch between the pom files.


Regarding Moments Estimation

Hi @peterdsharpe, I was validating the code with avl and I found that the moments estimated from this code is way off. Upon looking at vlm3.py I found the formula for moments are incorrect.
Could you please check and confirm with it.

Hey @dnsuman,
Uh oh! Could you please post your code and validation data?
I've done some moment validation against XFLR5 and AVL on my end and found them to all agree - let's see if we can figure out where the issue is!

Hey @peterdsharpe,
I have added the image of the equation. The moment equation should contain the wing area, once I added the wing area to the equation I got the pitching moment coefficient to be overestimated by 6% when compared to AVL and lift coeficient was 5% below the estimated value from AVL, which is quite good. But the lateral and directional moment coefficient does'nt match up at all.
I have also attached an image of my output for a wing you can have a look.

I have attached the image of the corrected moments equation of vlm3

Normalization
Ah! Yes, the normalization to s_ref was corrected in the latest (v1.0.0-beta) release:

(however, v1.0.0 is still in beta, so it may be wise to wait another week or two before updating)
Lateral & Directional moments
Regarding the lateral and directional moments: it looks like VLM3 is saying that the lateral and directional moments are basically 0 to within machine precision (-2.7e-16 and 1.09e-17, respectively). Is this not what you're finding with AVL?

Also:
The latest (v1.0.0-beta) release has the nice feature of being able to take advantage of symmetry in the problem (reducing the matrix size by a factor of 2), so it will output true zeros for lateral/directional coefficients in symmetric cases (as opposed to tiny tiny nonzero values). Also, it's way, way faster (<100 milliseconds). Example output from symmetric case:

After some correction to the AVL inputs from my end I got near similar values for lateral and directional moment coefficients.
The Aerosandbox is really a good work you have done. I am currently trying to implement this for wing twist optimization and I will be validating it with AVL and later do CFD analysis to confirm the design of the wing.
Currently I would be using vlm3 but later on I will work with the beta version and work on that.
Also, I wanted to know in the beta version is the viscous part added to the vlm code?

I appreciate it - thanks!
The beta version replaces the old solvers with two new solvers: "CasVLM1" and "CasLL1". (The old solvers are still available through the aerosandbox_legacy_v0 folder, though things like geometry definition are not guaranteed to be cross-compatible.) There are a good number of benefits associated with the new solvers, namely; the methods are written to lend themselves nicely to a simultaneous-analysis-and-design (SAND)-like architecture.
Regarding viscous modeling: That's currently a feature in CasLL1, but not CasVLM1. CasLL1 is basically a fully-nonlinear lifting-line (LL) solver, as opposed to a vortex-lattice model (VLM). Because of this, CasLL1 lends itself to viscous analysis more easily. Honestly, in most of my personal research work (currently working on solar-electric aircraft design), I've been primarily using CasLL1!
For your twist optimization study, it sounds like you probably want to use something like this script from the beta version:
https://github.com/peterdsharpe/AeroSandbox/blob/master/examples/casll1_spanload_optimization_test.py
But again, the beta version is still under heavy development, so no promises on user-friendliness there just yet!

Yes, I want to implement something similar to the spanload optimization but instead of chord length as my design variable will be the twist at each stations on the wing. Also, in the previous version of vlm3 is it possible to extract the elemental force coefficients.
It will take some time for me to understand the beta version and if I find any issues I'll reach out.

Yes - in the code I linked, both chord and twist optimization are happening simultaneously. You can choose to just do twist optimization if you want by swapping the "#" on these two lines (roughly line 57 in the file I linked):
# chords = cas.linspace(0.2, 0.2, n)
chords = cas.vertcat(*[variable(0.1, 0.001, 1) for i in range(n)])

And yes - in VLM3, forces should be available at each point on the wing by using vlm3.Fi_geometry. You can get the location associated with each point using vlm3.vortex_centers.

Thank you. I'll look into that and update you if I find any issues.

Is it possible to get the local CL using vlm3?

Unfortunately no, though there's probably a way to back-calculate this! You can do this with CasLL1, though, via CasLL1.CL_locals


Sphere{T} = UnitSphere{3,T} is a confusing definition

It's not clear why UnitSphere refers to an N-sphere while Sphere is a 3-sphere. I'd expect a Sphere to also have a radius and centre (down the line). So maybe UnitSphere -> UnitHyperSphere while Sphere -> UnitSphere.

Yes, HyperSphere seems more correct terminology, good point.
There could be a Sphere with radius and centre at some point. For the time being, many domains simply have a "basic" type that contains no data, like UnitSphere and ChebyshevInterval. They come with zero memory overhead and a simple, clean and efficient implementation that does not implicitly favour one affine map over another one. But I agree one would also expect a more fully featured sphere in a package like this.
I digress, but that is something I had in mind with the DerivedDomain type, which I think is currently never used and isn't even fully implemented (it should perhaps be removed). The idea is that a domain that derives from DerivedDomain has its own type, yet it simply contains some other domain. A sphere could be a DerivedDomain, that contains a mapped domain consisting of a UnitSphere and an affine map. That's perhaps more complicated than it should be for this use case, but it is a generic way of making domains with more functionality and a richer interface (using dispatch on the new type), while reusing existing (efficient) implementation.

Note that affine translations and domains with parameters are slightly different in IEEE, take the ball defined by: x^2 + y^2 ≤ r^2 vs the affine version (x/r)^2 + (y/r)^2 ≤ 1:
julia> x,y
(2.1213203608786055, 2.1213203262406797)

julia> x^2 + y^2 ≤ 9
true

julia> (x/3)^2 + (y/3)^2 ≤ 1
false

So I think both versions should exist without viewing it as too redundant.

Are we going to distinguish between an n-ball and an (n-1)-sphere?

Also, is the current "3-sphere" is embedded in R3 or R4? I don't know the design well enough to distinguish whether or not the super type is supposed to be the ambient domain or something that the instance looks like locally. This is rather picky, but there may be ways around this like overriding supertype

julia> struct MyType{N, T}
           center::T
           radius::T
       end

julia> abstract type MyAbstractType{N, T} end

julia> Base.supertype(::MyType{N, T}) where {N, T} = MyAbstractType{N + 1, T}

julia> sph = MyType{2, Float64}(0.0, 1.0)
MyType{2,Float64}(0.0, 1.0)

julia> supertype(sph)
MyAbstractType{3,Float64}

What about spheres and balls with different, possibly user-defined, norms? I think generic balls are then closed convex domains, so not sure how much would be gained from this. Perhaps a guarantee that a hyperspherical harmonic expansion is 1-to-1.


Verify not working

Hello
crypt.varify is not working, getting below error:
/home/hyper1/Sawtooth-projects/auth/node_modules/node-forge/lib/util.js:1602
input = input.replace(/[^A-Za-z0-9+/=]/g, '');
^
TypeError: input.replace is not a function
at Object.util.decode64 (/home/hyper1/Sawtooth-projects/auth/node_modules/node-forge/lib/util.js:1602:17)
at Crypt.verify (/home/hyper1/Sawtooth-projects/auth/node_modules/hybrid-crypto-js/lib/crypt.js:48:32)
at Object. (/home/hyper1/Sawtooth-projects/auth/server.js:36:19)
at Module._compile (internal/modules/cjs/loader.js:702:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
at Module.load (internal/modules/cjs/loader.js:612:32)
at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
at Function.Module._load (internal/modules/cjs/loader.js:543:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
at startup (internal/bootstrap/node.js:240:19)

Got same issue. Please help
" undefined is not a function (evaluating 'input.replace(/[^A-Za-z0-9+/=]/g, '')') "

problem solved:
use this code to varify
var varify = crypt.verify(senderPublicKe, decrypted.signature, decrypted.message)

problem solved:
use this code to varify
var varify = crypt.verify(senderPublicKe, decrypted.signature, decrypted.message)

Just ran into this same issue. Could @juhoen update the documentation to reflect this change to the verify method? That would eliminate the confusion here.

should it throw an error or should it just return false?

The error is in the documentation
https://github.com/juhoen/hybrid-crypto-js/pull/13/commits/a808761e3789b71ad9b066fc5836052bd70a64b0

Thank you for your support.


Add OpenGraph meta tags to the front page

@wilzbach If we're not going to do anything with Travis, can we disable it? It's making everything red.

I went ahead and disabled it.


LFS: file is undownloadable with EOF error, git lfs push --all origin master from source repo (where the full file is still present) doesn't fix it

Gitea version (or commit ref): 9e627af built with: bindata, sqlite
Git version: 2.11.2
Operating system: whatever the default docker image uses
Database (use [x]):

[X] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[X] No - don't know how to reproduce!
[ ] Not relevant

Log gist:

Description
I have an LFS file which cannot be downloaded: every pull that involves it will give an EOF error as shown below. git lfs push --all origin master from source repo (where the full file is still present) doesn't fix it, the lfs push doesn't return any error but the problem simply doesn't go away.
jonas@cyberman:~/Develop/simuworld$ git lfs pull
Git LFS: (0 of 1 files) 1.01 MB / 115.43 KB
cannot write data to tempfile "/home/jonas/Develop/simuworld/.git/lfs/objects/incomplete/034c77f1f05ec89421e4a63f0e3a4ca1ecf852cc6d2bf611f126f275728e017d.tmp": LFS: unexpected EOF
jonas@cyberman:~/Develop/simuworld$

Also please note that the git-lfs client is build to absolutely rely on the server to have successfully stored the file when it gets a positive HTTP response at the end of the upload. Therefore if gitea's LFS server doesn't do this yet, it would probably be a good idea to have some sort of hook verify that the whole file arrived before sending a positive HTTP response code.

+1 on this being required, using Git LFS for any number of large files frequently results in them not being able to be pulled anymore.
@JonasT have you found a way to re-upload the files manually in this circumstance?

Hey :wave:, I'm one of the Git LFS authors. I don't know how Gitea works, but the Git LFS client will attempt to verify uploads if the server desires.
https://github.com/git-lfs/git-lfs/blob/master/docs/api/basic-transfers.md#verification
This is useful in cases where an LFS server uses external cloud storage (like S3) without any proxying. By adding a verify action to the Batch API response, Git LFS can make another call to the LFS server, giving it a chance to verify the file has been successfully uploaded.
If you can delete the file from the server, you can then run git lfs push --all on a clone with a valid .git/lfs/objects/03/4c/034c77f1f05ec89421e4a63f0e3a4ca1ecf852cc6d2bf611f126f275728e017d file to re-upload to the server.

@technoweenie Interestingly enough, I've now deleted and repushed the particular file that I'm running into issues with to the server and I'm still getting the same error. I actually reuploaded all of the LFS objects, and it's still the same file. I've checked the MD5 sum of all of the files (the original file, the file in .git/lfs/objects/{OID_PATH} on the original repo, the LFS object on the server, and the incomplete file on the broken clone .git/lfs/objects/incomplete/{OID}.tmp) and they all actually match. I'm going to poke around some more and see why it might be getting an EOF error on this.
I will also look into adding the verify action, thanks for that hint!

Submitted a PR that fixes this issue for me. The problem was that it was returning a 206 response (Partial Content) but providing the full file size as the Content-Length instead of the truncated size.

@lafriks I don't know. GitHub.com currently uses verify, while GitHub Enterprise does not (due to a custom upload server). So, we test both.
If you're comfortable that your LFS server can verify that the exact contents have been saved to the storage layer, adding the verify action will slow things down. But, I suppose double checking doesn't hurt much :) This only happens the first time a unique LFS OID is uploaded, so it's not a big perf hit.

@techknowlogick thanks for your answer. So probably we need to add that verify until we implement proper server-side verification

lol. wrong tech
ping @technoweenie

@techknowlogick sorry :)

@technoweenie what status should /verify handler return if verification fails and should it remove lfs object from server store if for example size differs?

I'd say a 422. LFS will follow any 3xx redirects, and treats 4xx and 5xx statuses as errors. A 4xx error is more appropriate in this case, as a 5xx would imply some kind of server issue (DB down, disk full, etc).


fix: Provide a way to get agentOptions as config instead of whole httpAgent

Update Axios version to latest

:tada: This PR is included in version 1.3.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


"Instance field '_stackTraceString' is not defined" under linux/mono

Under Linux/Mono, I get this exception:
System.TypeInitializationException: An exception was thrown by the type initializer for AsyncFriendlyStackTrace.ExceptionExtensions ---> System.ArgumentException: Instance field '_stackTraceString' is not defined for type 'System.Exception'
  at System.Linq.Expressions.Expression.Field (System.Linq.Expressions.Expression expression, System.String fieldName) [0x00000] in <filename unknown>:0
  at AsyncFriendlyStackTrace.ReflectionUtil.GenerateGetField[Exception,String] (System.String fieldName) [0x00000] in <filename unknown>:0
  at AsyncFriendlyStackTrace.ExceptionExtensions..cctor () [0x00000] in <filename unknown>:0
  --- End of inner exception stack trace ---

I imagine that the internal implementation of System.Exception in Mono is different than the "original" .NET implementation. I took a look at the sources, maybe it can be fixed using Exception.ToString() to get an exceptions stack trace, instead of using a private field? But I'm not sure about the RemoteStackTrace? (I don't even know what's this supposed to be, that's why I didn't submit a PR in the first place).

ToString() would not be good, as it doesn't contain just the stack trace, but also the message and inner stack traces.
The _stackTraceString field stores exception stack trace after deserialization. I just looked in Mono's sources, it seems the field's name is slightly different - stack_trace. Feel free to submit a PR with an #if MONO to contain this difference. Thanks!
RemoteStackTrace is used in .NET for RealProxy invocations. From what I can see, this is still the same in Mono (_remoteStackTraceString).


Incorrect plural forms in pl locale

The current Polish translation needs some corrections, for example it shows "11 sekundy temu", ..., "19 sekundy temu" instead of "11 sekund temu", ..., "19 sekund temu". There are similar problems with other units of time, you can see it when running tests I've added in a separate PR https://github.com/hustcc/timeago.js/pull/99

@jcubic locale pl was created by jcubic, maybe you can discuess here for the language.
I know nothing about pl. ^_^

The fix in PR looks good.

@jcubic OK~


Fixing bug in FPGA design DB Q11

Existing Sample Changes
Description
This fixes a functional bug in the DB Q11 design for the FPGA. The cache in the compute kernel allows us to break the loop-carried dependency for a distance equal to the cache depth - 1. The ivdep pragma was applied with no 'safelen' and therefore broke the dependency for all loop iterations, which is not functionally correct.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[X] Command Line
[X] regtests

Marked as a draft until testing is complete.


support issue.locked

The v3 API returns a locked boolean indicating whether an issue has been locked, at least according to https://developer.github.com/v3/issues/#get-a-single-issue, but I don't see it in the Issue struct.

A Locked *bool `json:"locked,omitempty" field should be added to the Issue struct to resolve this.

Thanks, @kevinburke for the report.  This looks like an accidental omission.


Battle Factory: Remove unnecessary set properties

Nice! Could probably also throw out all the "level" : 5s in LC and just check if the tier is LC instead. BSS already has its own Factory anyway so everything else here will always be 100.

ok done

done

done @Marty-D


Create LocationAdmin class

Create LocationAdmin class than can do following:

filter by: city
list view, show fields: title, city, capacity
group form fields:

details: title, capacity
address: all other fields

any other improvements, welcome...

working on it

PR approved, thank you


machine learning

Supervised and unsupervised learning algorithms
Artificial neural networks
Feature selection methods
Evaluation and validation of machine learning models

In Supervised learning, the algorithm learns from a labeled dataset, where the input data is paired with corresponding output labels. The goal is to learn a mapping from inputs to outputs, so that the algorithm can make predictions or classifications for new, unseen data. eg. Classification, Regression
Artificial Neural Networks (ANNs) are a class of machine learning models inspired by the structure and functioning of biological neural networks in the human brain. ANNs consist of interconnected nodes, also known as artificial neurons or perceptrons, organized in layers.
Feature selection is an essential step in the machine learning pipeline that involves selecting a subset of relevant features or variables from the original set of features. This process aims to improve model performance, reduce computational complexity, and enhance interpretability.
Evaluating and validating machine learning models is a crucial step to ensure that your models generalize well to new, unseen data and perform effectively in real-world scenarios.


Detailed notification when user create a public request

On top of page, show public events available at this time slot in bold. This
notification should discourage user to create an event when a public event is already
scheduled at this time-slot anywhere in NCBS.

This has been fixed.


[Feature Request]: Multiple/alternate definitions

Enhancement Details
Multiple/alternate definitions for functions
Solution
Add multiple definitions to markdown
Additional Context
Example: This function does the same thing, but can be called in different ways
--[[
	@definition self:copy(other)
	@brief copies matrix4 values from another matrix4
	@param other:`math.matrix4` the matrix to copy from
	@return `math.matrix4` this matrix copied from `other`
]]
--[[
	@definition matrix4.copy(a, b)
	@brief copies matrix4 values from another matrix4
	@param a:`math.matrix4` the matrix to copy into
	@param b:`math.matrix4` the matrix to copy from
	@return `math.matrix4` matrix `a` copied from `b`
]]
function class.copy(a, b)
	--does something
end

I'm not sure that the python library I use can handle this kind of thing. I believe it'll think the first block is a global comment, not a function's. I also don't know if this is something people typically even do in Lua code when it comes to libraries, for example.
As far as I know, people usually keep it as colon or dot index calls and not mix them.

So, I had some discussion with other people. It's definitely something that would have an advantage over using luadocs. However, like I said, I don't think that it would handle it all in two split comment buffers like that. I'll give it some thought, though. Something like either --- to know there's an alt definition.


Lattice Crosslink-NX EVN support

This issue is there to allow to reproduce more easily the several recent merge requests associated with the support of that board:

https://github.com/enjoy-digital/litex/pull/1747
https://github.com/enjoy-digital/litex/pull/1748
https://github.com/enjoy-digital/litex/pull/1749
https://github.com/litex-hub/zephyr-on-litex-vexriscv/pull/17
https://github.com/litex-hub/zephyr-on-litex-vexriscv/pull/19
https://github.com/litex-hub/zephyr-on-litex-vexriscv/pull/13
https://github.com/zephyrproject-rtos/zephyr/pull/61640

Once everything gets merged on LiteX-side, it would be a good time to remove the [draft] flag off the Zephyr one.

Here is a script to do everything: Clone all LiteX and Zephyr repos at the correct branch and build a LiteX and Zephyr image:
curl -Lo zephyr_on_litex_on_crosslink_nx_evn.sh  https://github.com/litex-hub/zephyr-on-litex-vexriscv/files/12381804/zephyr_on_litex_on_crosslink_nx_evn.txt

zephyr_on_litex_on_crosslink_nx_evn.txt
When run without argument, it does nothing but printing these instructions:
# WARNING: this script will reset all changes to the repos in these directories:
  /home/josuah/workspace_1692382287_litex  /home/josuah/workspace_1692382287_zephyr

# You can reuse this workspace by running:
export id=1692382287

#1: modify the hardware as described by LiteX:
# - Remove R18 and R19 and populate R15 and R17
# - Program the FTDI with UART on port B with FTProg or https://github.com/trabucayre/fixFT2232_ecp5evn

#2: Run all build phases:
sh zephyr_on_litex_on_crosslink_nx_evn.sh litex zephyr prog

#3: Power-cycle the board and load the bitstream:
sh zephyr_on_litex_on_crosslink_nx_evn.sh load

#4: Connect to the LiteX shell
litex_term /dev/ttyUSB1

#5: Boot into Zephyr from LiteX bootloader:
LiteX> boot 0x01000000

# Then you should have the Zephyr shell
uart$

All the submissions that are left are RFCs, the other ones were not essential.
Nothing left here! The remaining [RFC]s can live on their own.
Thank you for watching! :)


Failed to activate the inline-messenger package At Arguments to CompositeDisposable.add must have a .dispose() method

[Enter steps to reproduce below:]

...
...

I'm not aware of any packages that use this library.  If anyone can point me to them I'd appreciate it.

[Enter steps to reproduce below:]

...
...

Atom Version: 1.11.2
Electron Version: 0.37.8
System: Unknown Windows Version
Thrown From: inline-messenger package, v1.2.8
Stack Trace
Failed to activate the inline-messenger package
At Arguments to CompositeDisposable.add must have a .dispose() method

TypeError: Arguments to CompositeDisposable.add must have a .dispose() method
    at assertDisposable (C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\node_modules\event-kit\lib\composite-disposable.js:70:13)
    at CompositeDisposable.module.exports.CompositeDisposable.add (C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\node_modules\event-kit\lib\composite-disposable.js:43:11)
    at Object.module.exports.Messenger.activate (file:///C:/Users/Dimen/.atom/packages/inline-messenger/lib/inline-messenger.coffee:52:20)
    at Package.module.exports.Package.activateNow (C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package.js:183:20)
    at C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package.js:156:32
    at Package.module.exports.Package.measure (C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package.js:92:15)
    at C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package.js:149:26
    at Package.module.exports.Package.activate (C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package-manager.js:538:21)
    at C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package-manager.js:519:29
    at Config.module.exports.Config.transactAsync (C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package-manager.js:514:19)
    at PackageManager.module.exports.PackageManager.activate (C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package-manager.js:497:46)
    at C:\Users\Dimen\AppData\Local\atom\app-1.11.2\resources\app.asar\src\atom-environment.js:779:28

Commands

Config
{
  "core": {
    "disabledPackages": [
      "php-class-tree",
      "php-integrator-refactoring",
      "language-stylus",
      "autocomplete-css"
    ],
    "packagesWithKeymapsDisabled": [
      "api-docs"
    ],
    "telemetryConsent": "no",
    "themes": [
      "atom-material-ui",
      "atom-material-syntax-light"
    ]
  }
}

Installed Packages
# User
aligner, v0.22.2 (inactive)
aligner-javascript, v1.0.0 (inactive)
aligner-php, v1.0.0 (inactive)
atom-autocomplete-php, v0.19.4 (inactive)
atom-beautify, v0.29.13 (inactive)
atom-css-unit-converter, v1.1.1 (inactive)
atom-material-syntax, v0.4.6 (inactive)
atom-material-syntax-light, v0.4.5 (inactive)
atom-material-ui, v1.3.6 (inactive)
atom-ternjs, v0.15.0 (inactive)
autocomplete-css-with-stylus-support, v1.0.0 (inactive)
autocomplete-php, v0.3.7 (inactive)
autocomplete-project-paths, v2.2.0 (inactive)
docblockr, v0.8.7 (inactive)
file-icons, v1.7.22 (inactive)
git-plus, v5.18.0 (inactive)
highlight-selected, v0.11.2 (inactive)
inline-messenger, v1.2.8 (inactive)
intentions, v1.1.2 (inactive)
language-pug, v0.0.19 (inactive)
linter, v1.11.18 (inactive)
linter-eslint, v8.0.0 (inactive)
linter-php, v1.3.1 (inactive)
material-ui, v1.0.9 (inactive)
multi-cursor, v2.1.3 (inactive)
php-integrator-annotations, v1.0.3 (inactive)
php-integrator-autocomplete-plus, v1.1.5 (inactive)
php-integrator-base, v1.2.6 (inactive)
php-integrator-call-tips, v1.1.1 (inactive)
php-integrator-navigation, v1.0.3 (inactive)
php-integrator-tooltips, v1.0.4 (inactive)
pigments, v0.37.0 (inactive)
platformio-ide-terminal, v2.2.0 (inactive)
project-manager, v3.2.5 (inactive)
quick-docs, v0.1.0 (inactive)
script, v3.10.1 (inactive)
Stylus, v3.1.0 (inactive)
Sublime-Style-Column-Selection, v1.7.2 (inactive)
sync-settings, v0.7.2 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (inactive)
base16-tomorrow-dark-theme, v1.2.0 (inactive)
base16-tomorrow-light-theme, v1.2.0 (inactive)
one-dark-ui, v1.6.0 (inactive)
one-light-ui, v1.6.0 (inactive)
one-dark-syntax, v1.3.0 (inactive)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.7.0 (inactive)
archive-view, v0.61.1 (inactive)
autocomplete-atom-api, v0.10.0 (inactive)
autocomplete-css, v0.11.2 (inactive)
autocomplete-html, v0.7.2 (inactive)
autocomplete-plus, v2.31.1 (inactive)
autocomplete-snippets, v1.11.0 (inactive)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (inactive)
background-tips, v0.26.1 (inactive)
bookmarks, v0.42.0 (inactive)
bracket-matcher, v0.82.1 (inactive)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (inactive)
dev-live-reload, v0.47.0 (inactive)
encoding-selector, v0.22.0 (inactive)
exception-reporting, v0.40.0 (inactive)
find-and-replace, v0.201.1 (inactive)
fuzzy-finder, v1.4.0 (inactive)
git-diff, v1.1.0 (inactive)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (inactive)
image-view, v0.59.0 (inactive)
incompatible-packages, v0.26.1 (inactive)
keybinding-resolver, v0.35.0 (inactive)
line-ending-selector, v0.5.0 (inactive)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (inactive)
metrics, v1.0.0 (inactive)
notifications, v0.65.1 (inactive)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.242.2-hotfix1 (inactive)
snippets, v1.0.2 (inactive)
spell-check, v0.68.2 (inactive)
status-bar, v1.4.1 (inactive)
styleguide, v0.47.0 (inactive)
symbols-view, v0.113.1 (inactive)
tabs, v0.101.0 (inactive)
timecop, v0.33.2 (inactive)
tree-view, v0.209.3 (inactive)
update-package-dependencies, v0.10.0 (inactive)
welcome, v0.35.1 (inactive)
whitespace, v0.33.0 (inactive)
wrap-guide, v0.38.2 (inactive)
language-c, v0.52.1 (inactive)
language-clojure, v0.21.0 (inactive)
language-coffee-script, v0.47.2 (inactive)
language-csharp, v0.12.1 (inactive)
language-css, v0.37.1 (inactive)
language-gfm, v0.88.0 (inactive)
language-git, v0.15.0 (inactive)
language-go, v0.42.1 (inactive)
language-html, v0.45.1 (inactive)
language-hyperlink, v0.16.0 (inactive)
language-java, v0.23.0 (inactive)
language-javascript, v0.119.0 (inactive)
language-json, v0.18.2 (inactive)
language-less, v0.29.5 (inactive)
language-make, v0.22.2 (inactive)
language-mustache, v0.13.0 (inactive)
language-objective-c, v0.15.1 (inactive)
language-perl, v0.35.0 (inactive)
language-php, v0.37.2 (inactive)
language-property-list, v0.8.0 (inactive)
language-python, v0.45.0 (inactive)
language-ruby, v0.69.0 (inactive)
language-ruby-on-rails, v0.25.0 (inactive)
language-sass, v0.56.0 (inactive)
language-shellscript, v0.22.4 (inactive)
language-source, v0.9.0 (inactive)
language-sql, v0.23.0 (inactive)
language-text, v0.7.1 (inactive)
language-todo, v0.28.0 (inactive)
language-toml, v0.18.0 (inactive)
language-xml, v0.34.9 (inactive)
language-yaml, v0.26.0 (inactive)

# Dev
No dev packages

have same problem too.

have same problem too.

Steps to reproduce:

install package
wait for a couple of seconds

OR

restart Atom

Atom Version: 1.11.2
Electron Version: 0.37.8
System: Microsoft Windows 10 Pro
Thrown From: inline-messenger package, v1.2.8
Stack Trace
Failed to activate the inline-messenger package
At Arguments to CompositeDisposable.add must have a .dispose() method

TypeError: Arguments to CompositeDisposable.add must have a .dispose() method
    at assertDisposable (C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\node_modules\event-kit\lib\composite-disposable.js:70:13)
    at CompositeDisposable.module.exports.CompositeDisposable.add (C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\node_modules\event-kit\lib\composite-disposable.js:43:11)
    at Object.module.exports.Messenger.activate (file:///C:/Users/Åsmund Stavdahl/.atom/packages/inline-messenger/lib/inline-messenger.coffee:52:20)
    at Package.module.exports.Package.activateNow (C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package.js:183:20)
    at C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package.js:156:32
    at Package.module.exports.Package.measure (C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package.js:92:15)
    at C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package.js:149:26
    at Package.module.exports.Package.activate (C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\src\package-manager.js:538:21)
    at C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\node_modules\settings-view\lib\package-manager.js:460:29
    at exit (C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\node_modules\settings-view\lib\package-manager.js:73:16)
    at triggerExitCallback (C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\src\buffered-process.js:215:47)
    at ChildProcess.<anonymous> (C:\Users\Åsmund Stavdahl\AppData\Local\atom\app-1.11.2\resources\app.asar\src\buffered-process.js:237:18)
    at emitTwo (events.js:100:13)
    at ChildProcess.emit (events.js:185:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)

Commands
     -1:22.8.0 command-palette:toggle (atom-pane.pane.active)
     -1:21.2.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -1:21.2.0 settings-view:open (atom-pane.pane.active)
     -1:10.3.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -1:08.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config
{
  "core": {
    "telemetryConsent": "limited"
  }
}

Installed Packages
# User
es6-javascript, v1.0.0 (inactive)
git-control, v0.8.2 (inactive)
git-plus, v5.18.0 (active)
inline-messenger, v1.2.8 (inactive)
quantum-shell, v0.7.1 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (inactive)
base16-tomorrow-dark-theme, v1.2.0 (inactive)
base16-tomorrow-light-theme, v1.2.0 (inactive)
one-dark-ui, v1.6.0 (active)
one-light-ui, v1.6.0 (inactive)
one-dark-syntax, v1.3.0 (active)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.7.0 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.2 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (active)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.201.1 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.59.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (active)
metrics, v1.0.0 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.242.2-hotfix1 (active)
snippets, v1.0.2 (active)
spell-check, v0.68.2 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.0 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.101.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.209.3 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.33.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.2 (active)
language-csharp, v0.12.1 (active)
language-css, v0.37.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.42.1 (active)
language-html, v0.45.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.23.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.2 (active)
language-less, v0.29.5 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.2 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.69.0 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.56.0 (active)
language-shellscript, v0.22.4 (active)
language-source, v0.9.0 (active)
language-sql, v0.23.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.9 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages

As for other packages that use this one: I'm pretty sure I installed something that used this package but I don't remember which.
I'll certainly tell you if I rediscover it :)
Best regards

[Enter steps to reproduce below:]

restart Atom or close all tabs

Atom Version: 1.12.2
Electron Version: 1.3.6
System: Mac OS X 10.12.2
Thrown From: inline-messenger package, v1.2.8
Stack Trace
Failed to activate the inline-messenger package
At Arguments to CompositeDisposable.add must have a .dispose() method

TypeError: Arguments to CompositeDisposable.add must have a .dispose() method
    at assertDisposable (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:70:13)
    at CompositeDisposable.module.exports.CompositeDisposable.add (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:43:11)
    at Object.activate (/Users/avsosnovskiy/.atom/packages/inline-messenger/lib/inline-messenger.coffee:52:20)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:184:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:157:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:150:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:147:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:548:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:529:29
    at Config.module.exports.Config.transactAsync (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:524:19)
    at PackageManager.module.exports.PackageManager.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:506:46)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:792:28

Commands

Config
{
  "core": {
    "closeEmptyWindows": false,
    "openEmptyEditorOnStart": false,
    "projectHome": "/Users/avsosnovskiy/Проекты",
    "telemetryConsent": "no",
    "useCustomTitleBar": true
  }
}

Installed Packages
# User
atom-autocomplete-php, v0.20.2 (inactive)
atom-beautify, v0.29.13 (inactive)
atom-darcula, v0.2.0 (inactive)
atom-monokai, v0.10.4 (inactive)
atom-runner, v2.7.1 (inactive)
atom-typescript, v10.1.12 (inactive)
auto-encoding, v0.6.2 (inactive)
convert-to-utf8, v0.2.4 (inactive)
dracula-ui, v0.3.0 (inactive)
file-icons, v1.7.25 (inactive)
inline-messenger, v1.2.8 (inactive)
linter, v1.11.18 (inactive)
linter-php, v1.3.1 (inactive)
monokai, v0.18.0 (inactive)
project-manager, v3.3.3 (inactive)
quick-docs, v0.1.0 (inactive)
Remote-FTP, v0.9.4 (inactive)
todo-show, v1.8.0 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.45.0 (inactive)
base16-tomorrow-dark-theme, v1.3.0 (inactive)
base16-tomorrow-light-theme, v1.3.0 (inactive)
one-dark-ui, v1.6.2 (inactive)
one-light-ui, v1.6.2 (inactive)
one-dark-syntax, v1.5.0 (inactive)
one-light-syntax, v1.5.0 (inactive)
solarized-dark-syntax, v1.0.5 (inactive)
solarized-light-syntax, v1.0.5 (inactive)
about, v1.7.0 (inactive)
archive-view, v0.62.0 (inactive)
autocomplete-atom-api, v0.10.0 (inactive)
autocomplete-css, v0.13.1 (inactive)
autocomplete-html, v0.7.2 (inactive)
autocomplete-plus, v2.31.4 (inactive)
autocomplete-snippets, v1.11.0 (inactive)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (inactive)
background-tips, v0.26.1 (inactive)
bookmarks, v0.42.0 (inactive)
bracket-matcher, v0.82.2 (inactive)
command-palette, v0.39.0 (inactive)
deprecation-cop, v0.54.1 (inactive)
dev-live-reload, v0.47.0 (inactive)
encoding-selector, v0.22.0 (inactive)
exception-reporting, v0.40.0 (inactive)
find-and-replace, v0.202.2 (inactive)
fuzzy-finder, v1.4.0 (inactive)
git-diff, v1.1.0 (inactive)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (inactive)
image-view, v0.60.0 (inactive)
incompatible-packages, v0.26.1 (inactive)
keybinding-resolver, v0.35.0 (inactive)
line-ending-selector, v0.5.0 (inactive)
link, v0.31.2 (inactive)
markdown-preview, v0.158.8 (inactive)
metrics, v1.1.1 (inactive)
notifications, v0.65.1 (inactive)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.1 (inactive)
settings-view, v0.243.1 (inactive)
snippets, v1.0.4 (inactive)
spell-check, v0.68.4 (inactive)
status-bar, v1.4.1 (inactive)
styleguide, v0.47.2 (inactive)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.0 (inactive)
timecop, v0.33.2 (inactive)
tree-view, v0.210.0 (inactive)
update-package-dependencies, v0.10.0 (inactive)
welcome, v0.35.1 (inactive)
whitespace, v0.35.0 (inactive)
wrap-guide, v0.38.2 (inactive)
language-c, v0.54.0 (inactive)
language-clojure, v0.22.1 (inactive)
language-coffee-script, v0.48.0 (inactive)
language-csharp, v0.12.1 (inactive)
language-css, v0.40.1 (inactive)
language-gfm, v0.88.0 (inactive)
language-git, v0.15.0 (inactive)
language-go, v0.43.0 (inactive)
language-html, v0.46.1 (inactive)
language-hyperlink, v0.16.1 (inactive)
language-java, v0.24.0 (inactive)
language-javascript, v0.122.0 (inactive)
language-json, v0.18.3 (inactive)
language-less, v0.29.6 (inactive)
language-make, v0.22.2 (inactive)
language-mustache, v0.13.0 (inactive)
language-objective-c, v0.15.1 (inactive)
language-perl, v0.37.0 (inactive)
language-php, v0.37.3 (inactive)
language-property-list, v0.8.0 (inactive)
language-python, v0.45.1 (inactive)
language-ruby, v0.70.2 (inactive)
language-ruby-on-rails, v0.25.1 (inactive)
language-sass, v0.57.0 (inactive)
language-shellscript, v0.23.0 (inactive)
language-source, v0.9.0 (inactive)
language-sql, v0.25.0 (inactive)
language-text, v0.7.1 (inactive)
language-todo, v0.29.1 (inactive)
language-toml, v0.18.1 (inactive)
language-xml, v0.34.12 (inactive)
language-yaml, v0.27.1 (inactive)

# Dev
No dev packages

[Enter steps to reproduce below:]

...
...

Atom Version: 1.12.3
Electron Version: 1.3.6
System: Mac OS X 10.11.5
Thrown From: inline-messenger package, v1.2.8
Stack Trace
Failed to activate the inline-messenger package
At Arguments to CompositeDisposable.add must have a .dispose() method

TypeError: Arguments to CompositeDisposable.add must have a .dispose() method
    at assertDisposable (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:70:13)
    at CompositeDisposable.module.exports.CompositeDisposable.add (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:43:11)
    at Object.activate (/Users/andrew/.atom/packages/inline-messenger/lib/inline-messenger.coffee:52:20)
    at Package.module.exports.Package.activateNow (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/package.js:184:19)
    at /opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/package.js:157:32
    at Package.module.exports.Package.measure (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/package.js:150:26
    at Package.module.exports.Package.activate (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/package.js:147:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/package-manager.js:548:21)
    at /opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/package-manager.js:529:29
    at Config.module.exports.Config.transactAsync (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/package-manager.js:524:19)
    at PackageManager.module.exports.PackageManager.activate (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/package-manager.js:506:46)
    at /opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:792:28

Commands

Config
{
  "core": {
    "disabledPackages": [
      "yuno-commit-plus"
    ],
    "ignoredNames": [
      ".git",
      ".hg",
      ".svn",
      ".DS_Store",
      "._*",
      "Thumbs.db",
      ".pyc"
    ],
    "telemetryConsent": "limited",
    "themes": [
      "one-light-ui",
      "solarized-light-syntax"
    ]
  }
}

Installed Packages
# User
atom-alignment, v0.12.1 (inactive)
atom-beautify, vundefined (inactive)
atom-html-preview, v0.1.22 (inactive)
atom-prettify, v0.1.3 (inactive)
auto-indent-file, v0.2.0 (inactive)
change-case, v0.6.3 (inactive)
cucumber, v0.5.0 (inactive)
file-icons, v1.7.24 (inactive)
gem-wiseguy, v0.4.4 (inactive)
git-blame, v0.4.11 (inactive)
inline-messenger, v1.2.8 (inactive)
linter, v1.11.18 (inactive)
linter-pep8, v1.3.2 (inactive)
linter-ruby, v1.2.2 (inactive)
minimap, v4.25.6 (inactive)
pretty-json, v1.6.1 (inactive)
scratch, v1.2.0 (inactive)
solarized-light-ui, v0.1.0 (inactive)
split-diff, v1.0.6 (inactive)
Sublime-Style-Column-Selection, v1.7.2 (inactive)
symbol-gen, v1.3.1 (inactive)
tablr, v1.5.5 (inactive)
theme-switcher, v1.1.0 (inactive)
to-base64, v0.4.2 (inactive)
xml-formatter, v0.10.0 (inactive)
yuno-commit-plus, v0.2.1 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.45.0 (inactive)
base16-tomorrow-dark-theme, v1.3.0 (inactive)
base16-tomorrow-light-theme, v1.3.0 (inactive)
one-dark-ui, v1.6.2 (inactive)
one-light-ui, v1.6.2 (inactive)
one-dark-syntax, v1.5.0 (inactive)
one-light-syntax, v1.5.0 (inactive)
solarized-dark-syntax, v1.0.5 (inactive)
solarized-light-syntax, v1.0.5 (inactive)
about, v1.7.0 (inactive)
archive-view, v0.62.0 (inactive)
autocomplete-atom-api, v0.10.0 (inactive)
autocomplete-css, v0.13.1 (inactive)
autocomplete-html, v0.7.2 (inactive)
autocomplete-plus, v2.31.4 (inactive)
autocomplete-snippets, v1.11.0 (inactive)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (inactive)
background-tips, v0.26.1 (inactive)
bookmarks, v0.42.0 (inactive)
bracket-matcher, v0.82.2 (inactive)
command-palette, v0.39.0 (inactive)
deprecation-cop, v0.54.1 (inactive)
dev-live-reload, v0.47.0 (inactive)
encoding-selector, v0.22.0 (inactive)
exception-reporting, v0.40.0 (inactive)
find-and-replace, v0.202.2 (inactive)
fuzzy-finder, v1.4.0 (inactive)
git-diff, v1.1.0 (inactive)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (inactive)
image-view, v0.60.0 (inactive)
incompatible-packages, v0.26.1 (inactive)
keybinding-resolver, v0.35.0 (inactive)
line-ending-selector, v0.5.0 (inactive)
link, v0.31.2 (inactive)
markdown-preview, v0.158.8 (inactive)
metrics, v1.1.2 (inactive)
notifications, v0.65.1 (inactive)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.1 (inactive)
settings-view, v0.243.1 (inactive)
snippets, v1.0.4 (inactive)
spell-check, v0.68.4 (inactive)
status-bar, v1.4.1 (inactive)
styleguide, v0.47.2 (inactive)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.0 (inactive)
timecop, v0.33.2 (inactive)
tree-view, v0.210.0 (inactive)
update-package-dependencies, v0.10.0 (inactive)
welcome, v0.35.1 (inactive)
whitespace, v0.35.0 (inactive)
wrap-guide, v0.38.2 (inactive)
language-c, v0.54.0 (inactive)
language-clojure, v0.22.1 (inactive)
language-coffee-script, v0.48.0 (inactive)
language-csharp, v0.13.0 (inactive)
language-css, v0.40.1 (inactive)
language-gfm, v0.88.0 (inactive)
language-git, v0.15.0 (inactive)
language-go, v0.43.0 (inactive)
language-html, v0.46.1 (inactive)
language-hyperlink, v0.16.1 (inactive)
language-java, v0.24.0 (inactive)
language-javascript, v0.122.0 (inactive)
language-json, v0.18.3 (inactive)
language-less, v0.29.6 (inactive)
language-make, v0.22.2 (inactive)
language-mustache, v0.13.0 (inactive)
language-objective-c, v0.15.1 (inactive)
language-perl, v0.37.0 (inactive)
language-php, v0.37.3 (inactive)
language-property-list, v0.8.0 (inactive)
language-python, v0.45.1 (inactive)
language-ruby, v0.70.2 (inactive)
language-ruby-on-rails, v0.25.1 (inactive)
language-sass, v0.57.0 (inactive)
language-shellscript, v0.23.0 (inactive)
language-source, v0.9.0 (inactive)
language-sql, v0.25.0 (inactive)
language-text, v0.7.1 (inactive)
language-todo, v0.29.1 (inactive)
language-toml, v0.18.1 (inactive)
language-xml, v0.34.12 (inactive)
language-yaml, v0.27.1 (inactive)

# Dev
No dev packages

[Enter steps to reproduce:]

Restart Atom.

Atom: 1.19.4 x64
Electron: 1.6.9
OS: Ubuntu 16.04.3
Thrown From: inline-messenger package 1.2.8
Stack Trace
Failed to activate the inline-messenger package
At Arguments to CompositeDisposable.add must have a .dispose() method

TypeError: Arguments to CompositeDisposable.add must have a .dispose() method
    at assertDisposable (/usr/share/atom/resources/app/node_modules/event-kit/lib/composite-disposable.js:74:19)
    at CompositeDisposable.module.exports.CompositeDisposable.add (/usr/share/atom/resources/app/node_modules/event-kit/lib/composite-disposable.js:43:17)
    at Object.activate (/packages/inline-messenger/lib/inline-messenger.coffee:52:20)
    at Package.module.exports.Package.activateNow (/usr/share/atom/resources/app/src/package.js:253:25)
    at /usr/share/atom/resources/app/src/package.js:225:38
    at Package.module.exports.Package.measure (/usr/share/atom/resources/app/src/package.js:99:21)
    at /usr/share/atom/resources/app/src/package.js:218:32
    at Package.module.exports.Package.activate (/usr/share/atom/resources/app/src/package.js:215:40)
    at PackageManager.module.exports.PackageManager.activatePackage (/usr/share/atom/resources/app/src/package-manager.js:645:40)
    at /usr/share/atom/resources/app/src/package-manager.js:626:35
    at Config.module.exports.Config.transactAsync (/usr/share/atom/resources/app/src/config.js:346:24)
    at PackageManager.module.exports.PackageManager.activatePackages (/usr/share/atom/resources/app/src/package-manager.js:621:25)
    at PackageManager.module.exports.PackageManager.activate (/usr/share/atom/resources/app/src/package-manager.js:603:52)
    at /usr/share/atom/resources/app/src/atom-environment.js:843:36

Commands

Non-Core Packages
atom-beautify 0.30.5
atom-bootstrap3 1.2.12
atom-html-preview 0.1.22
atom-minify 0.8.0
atom-ternjs 0.18.3
atom-typescript 11.0.7
autoclose-html 0.23.0
autocomplete-python 1.10.2
busy-signal 1.4.3
color-picker 2.2.5
django-templates 0.5.0
docblockr 0.11.0
editorconfig 2.2.2
emmet 2.4.3
file-icons 2.1.11
git-control 0.9.0
git-history 3.3.0
git-log 0.4.1
highlight-line 0.12.0
inline-messenger 1.2.8
intentions 1.1.5
jslint 1.5.1
less-than-slash 0.17.0
linter 2.2.0
linter-csslint 2.0.0
linter-eslint 8.2.1
linter-jsonlint 1.3.0
linter-php 1.4.0
linter-pycodestyle 2.1.3
linter-pylint 2.1.0
linter-ui-default 1.6.8
materialize-css 0.3.0
navigate 0.1.17
php-debug 0.2.5
php-twig 4.0.0
pigments 0.40.2
prettier-atom 0.38.0
sass-autocompile 0.13.3
script 3.15.0
symbols-tree-view 0.14.0
sync-settings 0.8.3
todo-show 2.0.0

+1

+1
As for packages that inline-messenger is a dependency: quick-docs is one.

+1
And gem-wiseguy.


Added plugin for adding width and height attributes.

Add width and height attributes to an outer <svg> element.
Values are extracted from the viewBox attribute.
This allows the SVG to display at the correct size when rendered in a web browser without additional CSS.

There is already addAttributesToSVGElement. Perhaps, it's worth extending it.

Hi @GreLI, thanks for the reply. addAttributesToSVGElement currently only supports attribute names, not values. I would suggest updating this plugin to support attribute values. Do you want me to open a PR for that?

Hi @GreLI, thanks for the reply. I would urge you to reconsider, as I think this plugin adds some real value that cannot be achieved with the addAttributesToSVGElement plugin.
This plugin retrieves the width and height from the viewBox attribute. Then it adds these values as width and height attributes.
This is really valuable, because if an SVG without width and height attributes is embedded into a webpage, it will expand to 100% width of its container. If CSS fails to load due to a network error, the SVG will expand to fill 100% width of the browser window, resulting in a completely illegible page. Many sites, like github.com, css-tricks.com, nytimes.com, use width and height attributes on their SVGs.
This is a common problem because when SVGs are saved from Adobe Illustrator, they include a viewBox attribute, but not height or width attributes, so it would be good if SVGO makes it easier for web developers to address this problem.

The quick googling shows, that one have to turn off “responsive” option in Adobe Illustrator dialog to keep “width” and ”height” parameters: https://css-tricks.com/illustrator-to-svg/#post-247993

Yep right you are. I was thinking that svgo removed the height and width attributes but that is not the case. Thats OK then. Thanks!

@GreLI , how can addAttributesToSVGElement be used to transform the title attribute to another attribute of chose? We use the removeTitle plugin now, but we still need some identifier on the svg element, which should be the same as the title was. I can't see any plugin that can do this, and there is almost no docs on how to use the addAttributesToSVGElement plugin. Some extra docs would be helpful.

I think that when we update the following line, we could set the value of an attribute based on the current svg: https://github.com/svg/svgo/blob/02e0e416c8145da6770fde2174b977a83daea008/plugins/addAttributesToSVGElement.js#L70
By giving the option of OR being a value, OR being a function which will return a value based on the svg


CN Verification fails out-of-the-box

HI there. I have an Asus RT-AC68U running Asuswrt-Merlin 384.19
Turning on the VPN client after following the instructions prints "Error - check configuration!". These are the logs:
Nov 14 12:40:08 rc_service: httpd 261:notify_rc start_vpnclient1
Nov 14 12:40:10 ovpn-client1[20212]: OpenVPN 2.4.9 arm-unknown-linux-gnu [SSL (OpenSSL)] [LZO] [LZ4] [EPOLL] [MH/PKTINFO] [AEAD] built on Aug 14 2020
Nov 14 12:40:10 ovpn-client1[20212]: library versions: OpenSSL 1.1.1g  21 Apr 2020, LZO 2.08
Nov 14 12:40:10 ovpn-client1[20213]: NOTE: the current --script-security setting may allow this configuration to call user-defined scripts
Nov 14 12:40:10 ovpn-client1[20213]: Outgoing Control Channel Encryption: Cipher 'AES-256-CTR' initialized with 256 bit key
Nov 14 12:40:10 ovpn-client1[20213]: Outgoing Control Channel Encryption: Using 256 bit message hash 'SHA256' for HMAC authentication
Nov 14 12:40:10 ovpn-client1[20213]: Incoming Control Channel Encryption: Cipher 'AES-256-CTR' initialized with 256 bit key
Nov 14 12:40:10 ovpn-client1[20213]: Incoming Control Channel Encryption: Using 256 bit message hash 'SHA256' for HMAC authentication
Nov 14 12:40:10 ovpn-client1[20213]: TCP/UDP: Preserving recently used remote address: [AF_INET]<redacted external IP>:1194
Nov 14 12:40:10 ovpn-client1[20213]: Socket Buffers: R=[122880->122880] S=[122880->122880]
Nov 14 12:40:10 ovpn-client1[20213]: UDP link local: (not bound)
Nov 14 12:40:10 ovpn-client1[20213]: UDP link remote: [AF_INET]<redacted external IP>:1194
Nov 14 12:40:11 ovpn-client1[20213]: TLS: Initial packet from [AF_INET]<redacted external IP>:1194, sid=9144dd9c 04130c74
Nov 14 12:40:11 ovpn-client1[20213]: VERIFY OK: depth=1, CN=ChangeMe
Nov 14 12:40:11 ovpn-client1[20213]: VERIFY KU OK
Nov 14 12:40:11 ovpn-client1[20213]: Validating certificate extended key usage
Nov 14 12:40:11 ovpn-client1[20213]: ++ Certificate has EKU (str) TLS Web Server Authentication, expects TLS Web Server Authentication
Nov 14 12:40:11 ovpn-client1[20213]: VERIFY EKU OK
Nov 14 12:40:11 ovpn-client1[20213]: VERIFY X509NAME ERROR: CN=pihole_e05ebf22-b14c-43ab-9a83-dedeaa0e2d6a, must be pihole_e05ebf22-b14c-43ab-9a83-
Nov 14 12:40:11 ovpn-client1[20213]: OpenSSL: error:1416F086:lib(20):func(367):reason(134)
Nov 14 12:40:11 ovpn-client1[20213]: TLS_ERROR: BIO read tls_read_plaintext error
Nov 14 12:40:11 ovpn-client1[20213]: TLS Error: TLS object -> incoming plaintext read error
Nov 14 12:40:11 ovpn-client1[20213]: TLS Error: TLS handshake failed
Nov 14 12:40:11 ovpn-client1[20213]: SIGUSR1[soft,tls-error] received, process restarting

The certificate authority on the PiHole is set up with a common name (CN) of "ChangeMe". I confirmed this by running this on my PiHole:
$ sudo openssl x509 -noout -subject -in /etc/openvpn/easy-rsa/pki/ca.crt
subject=CN = ChangeMe

Of course, ChangeMe ≠ to the expected pihole_e05ebf22-b14c-43ab-9a83-dedeaa0e2d6a, so this check fails. I can work around it by setting Verify Server Certificate Name to No under Advanced Settings of the VPN client.
Is there a way to configure this system with a real CN?

At first blush this appears to be a Pi-hole specific bug. Since this is quite a stale issue, I'll ask if this is still an issue. Please re-open if you're encountering this problem today using the latest versions of the software. It's worth noting: I am recommending folks use the Wireguard tutorial going forward: https://github.com/rajannpatel/Pi-Hole-on-Google-Compute-Engine-Free-Tier-with-Full-Tunnel-and-Split-Tunnel-Wireguard-VPN-Configs


⚠ Bofrost.be has degraded performance

In d89ca2e, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1327 ms

Resolved: Bofrost.be performance has improved in 0218a31.


Show popular golinks

Design Doc
rpc ListPopularGolinks
rpc ListPopularGolinks(ListPopularGolinksRequest) returns (ListPopularGolinksResponse) {}

message ListPopularGolinksRequest {
  int32 limit = 1;
  int32 days = 2;
}

message ListPopularGolinksResponse {
  repeated Golink golinks = 1;
}

ListPopularGolinks returns the top ${limit} most popular golinks in the last ${days} days. If you give limit = 10 and days = 30, it returns the top 10 most popular golinks this month. Max limit is 100 and days can be 7 or 28.
How to calculate the popularity over a fixed period
Optimizing on Firestore, Golink accepts inaccuracy and data losses and calculates the popularity only over 7 days and 28 days.
Adding redirect_count_30days, redirect_count_7days, redirect_count_calculated_date, and daily_redirect_counts fields into golink documents, like:
{
  "golinks": {
    "my-link1": {
      "name": "my-golink",
      "url": "http://my-golink.example.com",
      "redirect_count_28days": 160,
      "redirect_count_7days": 21,
      "redirect_count_calculated_date": "2023-08-23"
      "daily_redirect_counts": [1, 1, 2, 3, ...] // 28 values
    }
  }
}

ListPopularGolinks can query by redirect_count_28days or redirect_count_7days.
When user uses a golink, if redirect_count_calculated_date is today, Golink increments redirect_count_28days, redirect_count_7days, and the first element of daily_redirect_counts, otherwise, calculate redirect_count_28days and redirect_count_7days based on redirect_count_calculated_date and daily_redirect_counts. To avoid increasing latency, this should be processed asynchronously with goroutine, accepting data loss.
Daily calculation
WIP


Support importing GPG keys for signing

Currently, cosign import-key-pair only has support for RSA and ECDSA keys in PEM format and does not offer support for importing GPG keys. The motivations for supporting import of GPG keys include:

To ease the transition from the GPG ecosystem to the Sigstore ecosystem by offering this as backward compatibility for people who have pre-existing GPG keys they want to keep using
To have more uniformity between Cosign and Rekor for supported key / signature types (Rekor supports a GPG type)

https://superuser.com/questions/435321/how-can-i-export-public-keys-in-pem-format-with-gnupg

Is this one still actionable? Id like to attempt this one but I see there is a good deal of discussion around it?

I would like this support very much.

https://superuser.com/questions/435321/how-can-i-export-public-keys-in-pem-format-with-gnupg Though I agree a simpler and/or automated process would be great.

Totally referenced this article before I found this issue. The whole process was a bit cumbersome so I resolved to just generate a key pair per the docs.


Exclude bitbucket from URL check (like github)

I think we can remove the check completely, it seems not many of the big sites support HEAD requests.
Or has anyone a better idea to check if the url is correct without downloading the complete file?

Do we always need to download the whole file anyway to generate the hash, @rrelmy? If that's the case, then I agree it would be good to remove this check_url function.
I'll merge this in since it's consistent with what's already there.

@lukesampson most of the time the file will be downloaded for the hash generation.
But not always, there is support to extract the hash from the webpage or a separate hash file (example: ant)
I don't have stats on how much of the autoupdates download the file anyway but I think it's the majority.


SVG Support

Gitea version (or commit ref):  1.12.0+dev-352-gcadec9bc2
Operating system: Arch
Database (use [x]):

[ ] PostgreSQL
[X] MySQL
[ ] MSSQL
[ ] SQLite

Description
SVG files aren't shown as images they're shown as though they're source which leads to a ridiculously long page load time and rather useless display.
Screenshots

External renderers may be of use as a stop-gap solution.

This is a duplicated issue with #1095.