Guidance needed on polyfills

When using ES6 to ES5 you often are using API as well as language enhancements and need polyfills, e.g. for Array.prototype.find or Map.
Closure Compiler gives you some of these, but not all. It's not clear which are missing, and this is changing as I see frequent new commits adding polyfills. Presumably at some point ES6 will be fully polyfilled, but then there will be ES7.
However the Closure Compiler externs are much more broadly defined, so you can easily compile a project that references a modern API in the externs without warnings, but find at runtime in specific browsers it fails.
I feel that we need some/all of:

A brief wiki page which explains the above and gives advice for how to ensure all polyfills needed are present for a given target platform; see https://github.com/google/closure-compiler/issues/1388#issuecomment-171396194;
A better externs system (https://github.com/google/closure-compiler/issues/1388#issuecomment-171395445) where perhaps you specify the target environment and the externs subset are chosen correctly, rather than blindly including all externs;
A simple JS script that consumes a given externs file, and reports which constructors and prototype properties are missing, which can be run in a given platform/browser to check for missing polyfills.

@shicks has been the primary person working on the compiler polyfills so he may be the best person to do item 1. Item 2 is possible today by passing specific --externs flags but I agree this could be improved. 3 would be good too and could probably be totally separate from the compiler itself, so would be a great thing to get from an external contributor.

At this point, all the planned polyfills are complete (String, Array, Object, Number, Math, Set, and Map; the others - mainly weak collections, Proxy, and Reflect - are much less feasible and so we're not planning on tackling them at all), though the RewritePolyfills pass is and has been off by default, which means that although they're included in the runtime, they will always be stripped from the output (provided it's using advanced optimizations).  I'm working on turning it on soon, but there are a few wrinkles.  As you pointed out, it's important to prevent surprises, where someone expects something to be polyfilled but it isn't.  The compiler pass has some affordance for this: if it's enabled and it sees a non-polyfilled symbol and the --language_out is too low, then it will emit a warning.  This breaks down in two ways: (1) the compiler doesn't currently support --language_out=ES6 at all, so any use of (e.g.) WeakMap will always warn, and there's not currently any way to say "yes, I said ES5, but I only care about modern browsers"; (2) there are some symbols that are technically only introduced in ES6 but it's perfectly reasonable to assume they're available even in many older browsers, such as typed arrays.  I've left these out completely, so they won't be warned on, but I'm not 100% confident about this choice; (3) prototype methods are nearly impossible to statically analyze, so we don't really even try - if anything could possibly be an ES6 prototype method call, we install the polyfill on the native object and leave it at that.
I would like to see a little finer gradation in the --language_out flag, i.e. an "es5+" and/or "es6-" option that would allow us to not warn on typed arrays or WeakMap, but would otherwise behave the same as ES5... but that's a much bigger change.

I would like to see a little finer gradation in the --language_out flag, i.e. an "es5+" and/or "es6-" option that would allow us to not warn on typed arrays or WeakMap, but would otherwise behave the same as ES5

Can we let the people who want WeakMap in the result use lang_out ES5 and suppress the warning? Having language levels for things that aren't really JS versions seems more confusing.

@shicks wrote:

they will always be stripped from the output

From what I can see, the polyfills are declared as $jscomp.something, and never take effect (i.e. assigned to global 'something' if not already present in the runtime environment) unless you enable this pass? Hence pruned as unused?
Presumably this pattern is used so that, with the pass enabled, should you not need a particular polyfill, CC will automatically prune it. But presumably, even if included in the output, the polyfill will only have an effect for older environments.
So I gather this means all these polyfills have no effect whatsoever unless you enable RewritePolyfills.
What are the wrinkles with this pass? Can I turn it on for my project?

That's exactly true.  We're trying to be cautious in rolling this out because it (obviously) has a high potential to break people.  The internal roll-out strategy was to get all the polyfills in place first and then flip the flag, mainly so that in case there are any breakages we can roll back only the flag switch, rather than having to roll back all the implementations.
The biggest wrinkle with the pass is probably the version logic.  We're keying off of the language_out flag to decide whether to do the rewriting, and that flag isn't fine-grained enough to work as well as it could.  Another issue is that it doesn't play very nicely with other polyfill-like code - for instance, if your code does
if (typeof Reflect === 'function') { ... }

then this is a sort of attempt at doing your own polyfill, and the pass doesn't know how to interpret it very well.  As such, right now you would need to turn off the whole pass to make this work.  It might be nice to be able to do more fine-grained configuration, but we're hesitant to implement that, since it's a pretty complicated configuration and would therefore be very difficult to test thoroughly.

 Where they overlapped, and with your pass enabled at build time, would the first to load be the version that took effect, or would advanced mode rewrite yours to unrelated functions?
Does your comment about versions relate to the FeatureSet recent commits at all?

Just interesting: why do you wanna write your own polyfills instead of usage core-js? :)

The build-time pass will rewrite e.g. Map to $jscomp.Map, so you won't get other (e.g. Babel) polyfills.  We like this approach because it makes it very clear that polyfilling has happened, instead of overwriting objects on window and then we have a state where you can't look at the code and reason about the codepath.  That said, prototype methods are written directly onto the native objects because it's a lot less reasonable to rewrite them.
In terms of why we wrote our own, please see the response on https://groups.google.com/forum/#!topic/closure-library-discuss/dosZGv-LIG0.

@supersteves https://github.com/google/closure-compiler/commit/f2eb08a075c1105423e96cf53c2a0aa1e2f98607 Added the --rewrite_polyfills flag.

Thanks!

is there a way to rewrite the polyfills without adding the polyfills on every file, but instead having a way to guarantee that window.$jscomp = $jscomp; is set once at the page level, and any compiled file loaded in that page reuse $jscomp?

Is there a way to disable the warning about unimplemented Polyfills?
E.g. you get this even if you declare Reflect in an externs.js:
t.js:5: WARNING - Built-in 'Reflect' not supported in output version ECMASCRIPT5: set --language_out to at least ECMASCRIPT6

You can avoid the warnings by skipping the compiler's rewriting of the polyfills --rewrite_polyfills=false. If you want to run the pass and not see the warnings, I think it's not possible at the moment. @shicks can chime in.

Is there a trick how to load polyfills dynamically, only when needed? For example goog.userAgent says it's IE11.

Not that I can think of.  You could disable them from your main binary and make a separate binary with just the polyfills, but the normal use case is to simply include them at the start of your binary, which is going to load them no matter what (even if they do nothing since all the symbols already exist).  That of course gets into questions of how to conditionally load code, and the compiler has no stance on that.


CMS Sideframe unit tests

67.42% → 100%
waits for https://github.com/divio/django-cms/pull/5110

Changes Unknown when pulling 27765b4c57101c643c126ee9b531ec6543805197 on FinalAngel:feature/unit-tests/cms-sideframe into ** on divio:develop**.

nice work, LGTM

Coverage increased (+1.4%) to 88.719% when pulling 45bcc822ae78345466ff89284d5f6d538665f665 on FinalAngel:feature/unit-tests/cms-sideframe into 391f2ec65d5d0d1643ecc48119755b649c9608c1 on divio:develop.


API mismatch between Parsed::with_offset_* and UtcOffset:{minutes_after_hour,seconds_after_minute}

Context: I'm parsing dates from the CLI, which are assumed to be local time unless a --utc flag has also been set. So I grab a UtcOffset at program start and initialize my Parsed with it.
Because of the i8 (UtcOffset) vs u8 (Parsed), the initialization looks like this:
let mut p = Parsed::new()
                 .with_offset_hour(offset.whole_hours())
                 .unwrap()
                 .with_offset_minute(offset.minutes_past_hour().try_into().unwrap())
                 .unwrap()
                 .with_offset_second(offset.seconds_past_minute().try_into().unwrap())
                 .unwrap();

This is inconvenient and error-prone (I nearly used offset.whole_minutes().try_into().unwrap()).
Also, it seems to me that the Parsed API is incapable of handling a sub-hour negative offset ? There's no such timezone in the real world, but it still feels dissatisfying.
I propose these new Parsed methods to fix this: with_offset(self, UtcOffset) -> Self, with_time(self, Time) -> Self, with_date(self, Date) -> Self, and the set_ equivalents. The date and time versions are here for consistency, but it's not hard to imagine usecases that would benefit from them. AFAICT these methods should be infallible, an added usability gain.

Also, it seems to me that the Parsed API is incapable of handling a sub-hour negative offset?

I just checked — this is unfortunately correct. I will introduce a field and relevant methods to set the sign explicitly. The format description would still require the offset hour to be present to set the sign, but it should realistically be present in any situation.
Adding methods to set the offset, date, and time seem reasonable due to the obvious benefit. They will be fallible, though, as future checks for consistency might be implemented (in this situation tzdb would be required for checks). This is similar to how set_month and set_weekday are fallible. Right now nothing, not even range validity, is actually checked on setting, but I want to keep that possibility open.

Case in point: the code above is buggy, correct one is .with_offset_minute(offset.minutes_past_hour().abs().try_into().unwrap()) or .with_offset_minute(offset.minutes_past_hour().abs() as u8) :sweat_smile:

I'll make a PR for the new set/with methods in the next few days - that sounds like a good first-time-issue.

Coming back around to this, I'm going to fix the buggy behavior shortly. I've changed my mind on with_date and similar methods. Ultimately the Parsed struct is intended for parsing, and there's no component for a full date, time, or offset.

I've just pushed a commit that fixes this to the extent possible. The existing methods (getters, setters, and builders) have been deprecated and replaced with signed equivalents. The now-deprecated methods will attempt to convert to the signed value and fail if not possible.


Install failing

We previously used this addon with no issues, but for some reason we recently started receiving failures from Broccoli and removed it from our package.json.
Now, we can't install it:
portal top % ember install "webnuts/ember-cli-honeybadger.git"
DEPRECATION: `ember-cli/lib/errors/silent.js` is deprecated, use `silent-error` instead.
Installed packages for tooling via npm.
WARNING: Could not figure out blueprint name from: "webnuts/ember-cli-honeybadger.git". Please install the addon blueprint via "ember generate <addon-name>" if necessary.
Installed addon package.

portal top % ember -v
ember-cli: 2.6.2
node: 6.0.0
os: darwin x64

Any ideas?

Strange. Does it fail for a clean Ember Cli project?

Hmm, no that seems to work. I'll try clearing caches and seeing what happens.

Yeah. Try that. I'm also happy to take a look, if you upload your project on Github.

I was able to solve this by running ember g ember-cli-honeybadger -- which just added the following dependency to bower.json: "honeybadger.js": "^0.4.2". Not sure why the source command didn't work in my project anymore... but this issue is resolved. Thanks for the prompt reply!


Updated Social Links, Upgraded font awesome to 5.7

Updated Social Links, Upgraded font awesome to 5.7 and Included Boots…

👍🏻@keshav1245


Redesign Network Signin

Description:
Replace current network signin screen with new version.
Design example should be adapted to current onboarding colour scheme for now.
Steps:

Signin menu button will show an information popup, then forwards to signin page.
Signin screen redesign.

See attached example screenshots.

QA passed. This is good for now.


transfer to JuliaInterop?

How would you feel about transferring this package to JuliaInterop (retaining admin rights, etc., of course)? We're trying to get more of the packages for Julia interacting with other languages and systems in one place to promote collaboration and sharing of ideas, code, etc.

OK, sounds good to me! Do I initiate this following https://help.github.com/articles/transferring-a-repository-owned-by-your-personal-account/ or how does it work?

Yep, that should do it. Let me know if there are any issues.

Transfer completed, seems this was quite painless, even the CI is working. I have commit access and it looks like I can manage issues, but the settings button on the main repository page seems missing, is that intentional?


add sphinx-changelog dependency

🚀 Pull Request
Description

This pull-request adds sphinx-changelog which support the use of towncrier for managing the geovista release changelog.

Basically, this will underpin our changelog, see


build fail

Time:        11.617 s, estimated 33 s     > 18 |       <InlineSegmentGroup>          |        ^^^^^^^^^^^^^^^^^^       19 |
       20 |
Frames
       21 |           <FormatSelect × Build failed error Command failed with exit code 1.

What command do you use to run the build?

yarn build

I can't reproduce, can you attach the complete output of yarn build? Also, can you make sure you run it on the head of the main branch?

yes, I am using the main branch


[Feature Request] Add LinkedList implementation

🚀 Feature Request
LinkedList is another important data structure to learn and hence should be added.
Adding visual learning images, to help grasp the concept better.

Would you like to work on this feature?

[ ] Yes
kindly assign me this issue under gssoc-ext and hacktoberfest-accepted with appropriate level

I want to work on it. Can you please assign it to me?


shopware-cli: 0.2.1 -> 0.2.6

Description of changes
Update of package

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 249585 run on x86_64-linux 1

1 package built:

shopware-cli


What Our Community Says section issue is solved

Description
What Our Community Says section Testimonials cards is now responsive.
Checkout This PR @mdazfar2

Related Issues

Closes #1457

Screenshots / videos (if applicable)

Before

Now

Amazing work @Hemraj-7

Thank You! @mdazfar2 , If you want any help at any time you can tell me. I will do.

Thank You! @mdazfar2 , If you want any help in frontend at any time you can tell me. I will try to do my best.

Sure.


deriving BEq fails for structures with Prop fields

Update: This used to be RFC to make BEq work for Prop, but from feedback it seems like the motivating deriving BEq bug should be fixed more locally.  See below for an MWE.
Old proposal
Currently BEq is defined only over Type, not Sort, and thus can't handle Prop.  Due to proof irrelevance, it would hopefully be harmless to extend BEq to work for any Prop, using a single, trivial instance.
This issue currently blocks deriving BEq from working if a structure has Prop fields, a simple example being
structure S where
  p : True
  deriving BEq

which produces the error message
typeclass instance problem is stuck, it is often due to metavariables
  BEq (?m.302 x✝¹ x✝ a✝ b✝)

Arthur Adjedj on Zulip suggested this was due to BEq being restricted to Type.  There are presumably other ways to fix deriving BEq in this case, but generalizing BEq would be a particularly simple one.
Community Feedback
Matthew Ballard suggested submitting this as an RFC in this Zulip thread.
Impact
Add :+1: to issues you consider important. If others benefit from the changes in this proposal being added, please ask them to add :+1: to it.

There's nothing preventing there from S having a BEq instance, even a LawfulBEq. It would be a different story if it were structure S : Prop where ...
The DecidableEq derive handler works here, and from that you get a BEq:
structure S where
  p : True
  deriving DecidableEq

#synth BEq S -- succeeds

This seems to just be a bug in the BEq derive handler that it can't handle a Prop field in the structure.

I’m happy to change this to be a bug report on deriving BEq if that’s the preference.

I changed the title, but don’t have permission to change the label.

I got a similar errror in
structure Result where
 derivation : String
 mrs : MRS
deriving Repr

where MRS is defined as
structure MRS where
  top : Var
  index : Var
  preds : List EP
  hcons : List Constraint
  icons : List Constraint

instance : ToFormat MRS where
 format
 | {top := t, index := i, preds := ps, icons := [], hcons := hs} =>
   f!"[ LTOP: {t}
        INDEX: {i}
        RELS: < {Format.joinSep (ps.map fun a => format a) " "} >
        HCONS: < {Format.joinSep (hs.map fun a => format a) " "} > ]"
 | {top := t, index := i, preds := ps, icons := is, hcons := hs} =>
   f!"[ LTOP: {t}
        INDEX: {i}
        RELS: < {Format.joinSep (ps.map fun a => format a) " "} >
        HCONS: < {Format.joinSep (hs.map fun a => format a) " "} >
        ICONS: < {Format.joinSep (is.map fun a => format a) " "} > ]"

instance : Repr MRS where
 reprPrec m _ := f!"{m}"

@girving, could you update the issue description? I think no need to keep the old version, it's just noise now. If you prefer to just open a new issue that might even be easier.

From my side. Not sure how I solved, but the error disappeared after moving to Lean last release. Maybe my step by step procedure to update Lean and std were not ideally and some of the lake clean and lake build solve the issue.

@semorrison I updated the issue description.

Woohoo, thank you!


The unique feature is renamed ptr_internals

Same as https://github.com/rust-lang-nursery/nomicon/pull/48, but into a temporary branch. Once this is merged https://github.com/rust-lang/rust/pull/46952 can update the submodule to that branch. After that reaches Nightly, the branch can be merged into master.

[assumes it's fine]


define style for current item

hi
how can i define different style for current item?
for example i want to change color and size of current item.
tnx

close #60
I got the solution on my own.
Just need to edit the file "AbstractWheelTextAdapter.java" at line number 47.
public static final int DEFAULT_TEXT_COLOR = 0xFF101010;
In this file you can customise the whole style of the wheel & also apply custom text fonts too.

I had the same question. You solution works like a charm, thanks arshu-dev ;)


Recompile Error on complex GLSL shader: "Over 3 compilation loops detected. Must be a bug!"

Failure occurs at L453 of spirv_glsl.cpp, when calling compile() on SPIR-V passed to the GLSL compiler.
SPIR-V assembly that causes the failure can be found here: https://gist.github.com/fuchstraumer/7bd2a40a056c2eaa2ab889792e8fbabd
Issue is caused by using variables returned from atomic add, irrespective of the sign of the variables used. The partially recompiled source can be found here: https://gist.github.com/fuchstraumer/b47eababc5f925d4c3cf863c72f713d4
This could well be an issue in the logic of the shader, as it's shown weird non-deterministic behavior. RenderDoc captures of it will show different results for the point light grid and point light index counter results each time the event is re-run by RenderDoc - not sure what causes this, but it could also be unrelated to this particular issue.

The cross-compiled SPIR-V compiles fine now. Non-deterministic behavior sounds like an unrelated shader bug if anything. Ordering of atomics isn't deterministic.

I figured - that was probably a case of me providing a bit too much detail. Regardless, thanks for the quick fix!


[BUG]: Switching is working for the first couple of ours, then stops.

Describe the bug.
In the lasttest version, de switching is working again, but stop after a couple of hours.
This is also noticeable on the measurements of the energy readings. See attached graph, the arrows: First one is the update/restart of HA and the second one is the moment the measurement is stopping regularly updating. At 5 AM I restarted HA again and the readings become normal again.

What version of Plugwise Beta are you using?
0.40.2
What was the last working version of Plugwise Beta (or Core if not using beta before)?
No response
What version of Home Assistant Core are you using?
2023.8.1
What type of installation are you running?
Home Assistant OS
How did you install plugwise-beta?
HACS
What kind of Plugwise device is having issues?
USB: Stick
What firmware version is your Plugwise product at?
latest
Logging
No response
Diagnostics information
No response
Additional information
No response

Sorry. wrong GitHub page!

Transferred to correct repo :)

@herwinjan I made a potential fix for this. Could you please try my cloned repository?
To do this what you can do is checkout my git repository [1], then create a symlink from
[homeassitant]/lib/python3.11/site-packages/plugwise_usb to the plugwise_usb folder inside the git checkout.
[1] https://github.com/plugwise/python-plugwise-usb

@herwinjan  can you try the following and report your result?
https://github.com/plugwise/plugwise_usb-beta/issues/67#issuecomment-1871858557

hi @herwinjan I am closing now. Please create a new issue if you have any further issues.


Is networking docs up-to-date?

They haven't been updated for 7 years.

Yes.

Yes.

Okay. I just haven't gotten libv86 networking to work.


Create unipanamericana.txt

https://unipanamericana.edu.co/

https://unipanamericana.edu.co/pregrado/facin/ingenieria-de-software-bogota2/

@joriveros Pull request merged. Thank you!


Enhancing User Experience: Auto-Focusing on the Search Bar with Dynamic Placeholder Text Based on User's Selection

Is your feature request related to a problem? Please describe
On the Circuitverse homepage, there's a search icon that, when clicked, reveals a search bar with options to select users and projects. However, I've noticed that the focus doesn't automatically shift to the search bar when it's revealed, and the placeholder text doesn't accurately describe what should be input. I'd like to suggest making improvements to address these issues.
https://github.com/CircuitVerse/CircuitVerse/assets/77529419/3480f474-e23d-421f-9744-6c324f3ccd03
Describe the solution you'd like
When i click on search icon my focus or text cursor should be in the search bar and if i select user option the placeholder should show "search for users here" and similarly for the projects.
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
Yes

Hi @rajesh604, I believe #4023 addresses this issue.

okay

As it's a duplicate  issue of #4023, closing this issue.
But @rajesh604 , you can raise a issue maybe on this -
When users option is selected, show Search user by name  in the placeholder
When projects option selected, show Search project by name or description in placeholder
You can give a better suggestion for placeholder text as well.


Can't forward OMCI packet from ONU channeltermination.1:1 to vOMCI. No connection

Hi,
tr451_polt_simulator not able to inject OMCI test messages to ONU simulator, its getting failed with below error,
tr451_polt_simulator (vomci) Logs :
root@5fa7ed0a25f3:/opt/obbaa-polt-simulator/build/fs# ./tr451_polt_daemon -log debug -f /app/share/vomci.cli -d
bcmos_task_create#144> INF: Thread dev_log_save: priority 30 is ignored. Start as root to honor priorities
bcmos_task_create#144> INF: Thread dev_log_print: priority 30 is ignored. Start as root to honor priorities
1: /po/au priv_key=/app/share/vomci_privatekey.pem local_cert=/app/share/vomci.cer peer_cert=/app/share/polt.cer
2: /po/set client_server=client enable=yes
3: /po/end client_server=client name=polt1 port=8433 host=<IP_ADDRESS>
bcmos_task_create#144> INF: Thread polt_client_server: priority 19 is ignored. Start as root to honor priorities
4: /po/filter client_server=client name=filt1 priority=100 ep_name=polt1 Type=any
5: /po/onu channel_term=channeltermination.1 onu_id=1 serial_vendor_id=BRCM serial_vendor_specific=00000001
[2318131: I default             ] bcm_dev_log_task.c 1458| Logging started
[2318134: I POLT                ] bcm_tr451_polt_common.cc 819| Enabling client subsystem..
[2318134: D POLT                ] bcm_tr451_polt_common.cc 1010| Allocated client endpoint polt1
[2318134: D POLT                ] bcm_tr451_polt_common.cc 1043| Edded entry to client endpoint polt1: polt1 host-name=<IP_ADDRESS> port=8433
[2318134: I POLT                ] bcm_tr451_polt_client.cc 327| Creating client polt1: entry polt1 <IP_ADDRESS>:8433
[2318134: D POLT                ] bcm_tr451_polt_common.cc 1053| Released client endpoint polt1
[2318135: D POLT                ] bcm_tr451_polt_common.cc 401| Added filter filt1 --> polt1
[2318138: I POLT                ] bcm_tr451_polt_common.cc 532| pOLT client polt1 started
[2318139: I POLT                ] bcm_tr451_polt_client.cc 129| client polt1.polt1: establishing ssl connection with the server at <IP_ADDRESS>:8433
[2318164: I POLT                ] bcm_tr451_polt_client.cc 173| client polt1.polt1: 'hello' exchange with the server at <IP_ADDRESS>:8433 completed: connected to vomci polt1
bcmos_task_create#144> INF: Thread polt1: priority 9 is ignored. Start as root to honor priorities
[2322032: I POLT                ] bcm_tr451_polt_client.cc 129| client polt1.polt1: establishing ssl connection with the server at <IP_ADDRESS>:8433
[2322034: I POLT                ] bcm_tr451_polt_client.cc 164| client polt1.polt1: 'hello' exchange with server at <IP_ADDRESS>:8433 failed. Re-connecting..
[2323034: I POLT                ] bcm_tr451_polt_client.cc 129| client polt1.polt1: establishing ssl connection with the server at <IP_ADDRESS>:8433
[2323051: I POLT                ] bcm_tr451_polt_client.cc 173| client polt1.polt1: 'hello' exchange with the server at <IP_ADDRESS>:8433 completed: connected to vomci polt1
bcmos_task_create#144> INF: Thread polt1: priority 9 is ignored. Start as root to honor priorities
/po/inject channeltermination.1 1 0054480a01000000040001000000000000000000000000000000000000000000000000000000000000000028
[2434817: D POLT                ] sim_tr451_polt_vendor.cc 118| RX from ONU: cterm=channeltermination.1 onu_id=1 length=44 OMCI_HDR=0054480a 01000000
[2434817: E POLT                ] bcm_tr451_polt_common.cc 882| Can't forward OMCI packet from ONU channeltermination.1:1 to vOMCI. No connection
pOLT client-server running in same docker container but onu-simulator is running on same VM in different docker container.
tr451_polt_simulator (polt) logs :
root@5fa7ed0a25f3:/opt/obbaa-polt-simulator/build/fs# ./tr451_polt_daemon -log debug -f /app/share/polt.cli -d
bcmos_task_create#144> INF: Thread dev_log_save: priority 30 is ignored. Start as root to honor priorities
bcmos_task_create#144> INF: Thread dev_log_print: priority 30 is ignored. Start as root to honor priorities
1: /po/set client_server=server enable=yes
2: /po/au priv_key=/app/share/polt_privatekey.pem local_cert=/app/share/polt.cer peer_cert=/app/share/vomci.cer
3: /po/en client_server=server name=polt port=8433
bcmos_task_create#144> INF: Thread polt_client_server: priority 19 is ignored. Start as root to honor priorities
4: /polt/filter client_server=server name=filt1 priority=100 ep_name=vomci1 Type=any
5: /po/onu channel_term=channeltermination.1 onu_id=1 serial_vendor_id=BRCM serial_vendor_specific=00000001
6: /po/rx_mode mode=onu_sim onu_sim_ip=<IP_ADDRESS>   onu_sim_port=50000 local_udp_port=50100
bcmos_task_create#144> INF: Thread cm_rx: priority 7 is ignored. Start as root to honor priorities
[2322800: I default             ] bcm_dev_log_task.c 1458| Logging started
[2322801: I POLT                ] bcm_tr451_polt_common.cc 819| Enabling server subsystem..
[2322802: I POLT                ] bcm_tr451_polt_server.cc 201| Creating server polt: any:8433
[2322802: D POLT                ] bcm_tr451_polt_common.cc 401| Added filter filt1 --> vomci1
[2322804: I POLT                ] bcm_tr451_polt_common.cc 532| pOLT server polt started
[2322806: I POLT                ] bcm_tr451_polt_server.cc 60| polt: Enabling ssl authentication
[2322809: I POLT                ] bcm_tr451_polt_server.cc 75| Server polt is listening on <IP_ADDRESS>:8433
[2323051: I POLT                ] bcm_tr451_polt_server.cc 122| Server polt: received HelloRequest from vOMCI vomci1
[2323053: I POLT                ] bcm_tr451_polt_server.cc 154| polt: Forwarding OMCI messages from pOLT to vOMCI vomci1@ipv4:<IP_ADDRESS>:41692 enabled
ONU-SIM logs :
root@8f909806eaf6:/# onusim.py -n channeltermination.1 -i 1 -p 50000 -l 2
DEBUG:onusim:args Namespace(address='<IP_ADDRESS>', ctermname='channeltermination.1', dumpfile=None, extended=False, loglevel=2, onuidfirst=1, onuidlast=None, port=50000)
DEBUG:onusim:server Endpoint(address=('<IP_ADDRESS>', 50000), is_server=True, cterm_name='channeltermination.1', onu_id_range=range(1, 2), tr451=True, dumpfd=None)
Docker network connectivity between polt-sim and onu-sim is working fine.
I have followed the installation instruction using link (https://broadbandforum.github.io/obbaa-onu-simulator/usage/introduction.html#with-tr451_polt_simulator-old-not-using-docker-compose).  Any help is very much appreciated.

Dear @akhileshkumar7662
I have the same problem. Have you solved it?
Please share information if you have more. Thank you!
Dear @jswalls  @wlupton  @johnblackford
Is this a code problem or a deployment step problem? Please help me. Thank you!
Dongyang.

hi @fandy-genew ,
Can you please follow below steps and check if you are able to proceed?
Step-1 : Update ~/obbaa-polt-simulator/certificates/cli_scripts/tr451.cli file as below:
#/po/au priv_key=/certificates/vomci_privatekey.pem local_cert=/certificates/vomci.cer peer_cert=/certificates/polt.cer
/po/set client_server=client enable=yes
#/po/end client_server=client name=polt-simulator port=8433 host=polt-simulator
/log/n name=POLT log_level_print=DEBUG log_level_save=DEBUG
Step-2: Update docker-compose file with below highlighted command
docker-compose.yml:
version: "3.5"
services:
polt-simulator:
build:
context: ./
args:
OBBAA_OLT_ADAPTER_VERSION: "1.0"
dockerfile: Dockerfile
image: broadbandforum/obbaa-polt-simulator:latest
stdin_open: true
tty: true
container_name: polt-simulator_compose
command: ["-dummy_tr385","-f","/certificates/cli_scripts/tr451.cli"]
environment:
- PASSWD=root
ports:
- "10830:10830"
volumes:
- "./certificates:/certificates"
Step-3 : Start pOLT simulator(docker-compose up -d)
Step-4 : Start onu-simulator(docker container run -it --name obbaa-onu-simulator --network obbaa-polt-simulator_default --rm -p 50000:50000/udp broadbandforum/obbaa-onu-simulator:latest bash),
Note : onu-simulator must always be running on the same network as that of pOLT simulator.
Step-5: Attach onu-simulator to pOLT simulator using command : /po/rx_mode mode=onu_sim onu_sim_ip= onu_sim_port=50000

Dear @selvaitech ,
Thanks for you quick reply.
Follows your step, error in Step-4. Please check the result and help me again.
Step-1:
fandy@onu-1:~/obbaa-polt-simulator/certificates/cli_scripts$ vi tr451.cli
#/po/au priv_key=/certificates/vomci_privatekey.pem local_cert=/certificates/vomci.cer peer_cert=/certificates/polt.cer
/po/set client_server=client enable=yes
#/po/end client_server=client name=polt-simulator port=8433 host=polt-simulator
/log/n name=POLT log_level_print=DEBUG log_level_save=DEBUG
Step-2:
fandy@onu-1:~/obbaa-polt-simulator$ vi docker-compose.yml
version: "3.5"
services:
polt-simulator:
build:
context: ./
args:
OBBAA_OLT_ADAPTER_VERSION: "1.0"
dockerfile: Dockerfile
image: broadbandforum/obbaa-polt-simulator:latest
stdin_open: true
tty: true
container_name: polt-simulator_compose
command: ["-dummy_tr385","-f","/certificates/cli_scripts/tr451.cli"]
environment:
- PASSWD=root
ports:
- "10830:10830"
volumes:
- "./certificates:/certificates"
Step-3:
fandy@onu-1:~/obbaa-polt-simulator$ docker-compose up
Creating network "obbaapoltsimulator_default" with the default driver
Creating polt-simulator_compose ...
Creating polt-simulator_compose ... done
Attaching to polt-simulator_compose
polt-simulator_compose | Starting netopeer2-server in the background
polt-simulator_compose | /usr/local/sysrepo /usr/local
polt-simulator_compose | /usr/local
polt-simulator_compose | Cleaning up stale state
polt-simulator_compose | bcmos_task_create#144> INF: Thread dev_log_save: priority 30 is ignored. Start as root to honor priorities
polt-simulator_compose | bcmos_task_create#144> INF: Thread dev_log_print: priority 30 is ignored. Start as root to honor priorities
polt-simulator_compose | bcmos_task_create#144> INF: Thread netconf: priority 16 is ignored. Start as root to honor priorities
polt-simulator_compose | [239552: I default             ] bcm_dev_log_task.c 1476| Logging started
polt-simulator_compose | [239562: I SYSREPO             ] Scheduled changes not applied because of other existing connections.
polt-simulator_compose | libyang[1]: Node type container "channel-termination" used as operand.
polt-simulator_compose | libyang[1]: Previous warning generated by XPath subexpression[75] "ietf-interfaces:name".
polt-simulator_compose | libyang[1]: Identityref value is not derived from all its bases. (path: /ietf-interfaces:type)
polt-simulator_compose | libyang[1]: Failed to resolve identityref "iana-if-type:ghn". (path: /ietf-interfaces:type)
polt-simulator_compose | libyang[1]: Previous warning generated by XPath subexpression[0] "ietf-interfaces:type = 'iana-if-type:ghn'".
polt-simulator_compose | libyang[1]: Identityref value is not derived from all its bases. (path: /ietf-interfaces:type)
polt-simulator_compose | libyang[1]: Failed to resolve identityref "iana-if-type:ghn". (path: /ietf-interfaces:type)
polt-simulator_compose | libyang[1]: Previous warning generated by XPath subexpression[0] "ietf-interfaces:type = 'iana-if-type:ghn'".
polt-simulator_compose | libyang[1]: Failed to resolve identityref "bbf-availability:unknown". (path: /bbf-vdsl:tag)
polt-simulator_compose | libyang[1]: Previous warning generated by XPath subexpression[7] "tag='bbf-availability:unknown'".
polt-simulator_compose | libyang[1]: Failed to resolve identityref "bbf-availability:unknown". (path: /bbf-vdsl:tag)
polt-simulator_compose | libyang[1]: Previous warning generated by XPath subexpression[46] "tag='bbf-availability:unknown'".
polt-simulator_compose | libyang[1]: Failed to resolve identityref "bbf-availability:unknown". (path: /bbf-fast:tag)
polt-simulator_compose | libyang[1]: Previous warning generated by XPath subexpression[7] "tag='bbf-availability:unknown'".
polt-simulator_compose | libyang[1]: Failed to resolve identityref "bbf-availability:unknown". (path: /bbf-fast:tag)
polt-simulator_compose | libyang[1]: Previous warning generated by XPath subexpression[46] "tag='bbf-availability:unknown'".
polt-simulator_compose | [239938: I SYSREPO             ] Connection 2 created.
polt-simulator_compose | [239938: I SYSREPO             ] Session 30 (user "root", CID 2) created.
polt-simulator_compose | libyang[1]: Node type container "channel-termination" used as operand.
polt-simulator_compose | libyang[1]: Previous warning generated by XPath subexpression[75] "ietf-interfaces:name".
polt-simulator_compose | [240008: I SYSREPO             ] Triggering "ietf-interfaces" "enabled" event on enabled data.
polt-simulator_compose | [240008: I NETCONF             ] bbf-xpon.c 148| xpath=/ietf-interfaces:interfaces/interface event=4
polt-simulator_compose | [240008: I SYSREPO             ] Triggering "ietf-interfaces" "done" event on enabled data.
polt-simulator_compose | [240009: I NETCONF             ] bbf-xpon.c 148| xpath=/ietf-interfaces:interfaces/interface event=2
polt-simulator_compose | [240010: I NETCONF             ] bbf-xpon.c 283| Subscribed to /ietf-interfaces:interfaces/interface subtree changes.
polt-simulator_compose | [240035: I SYSREPO             ] Triggering "bbf-olt-vomci" "enabled" event on enabled data.
polt-simulator_compose | [240036: I NETCONF             ] bbf-vomci.c 67| xpath=/bbf-olt-vomci:remote-network-function/nf-server event=4
polt-simulator_compose | [240036: I SYSREPO             ] Triggering "bbf-olt-vomci" "done" event on enabled data.
polt-simulator_compose | [240036: I NETCONF             ] bbf-vomci.c 67| xpath=/bbf-olt-vomci:remote-network-function/nf-server event=2
polt-simulator_compose | [240037: I NETCONF             ] bbf-vomci.c 652| Subscribed to /bbf-olt-vomci:remote-network-function/nf-server subtree changes.
polt-simulator_compose | [240037: I SYSREPO             ] Triggering "bbf-olt-vomci" "enabled" event on enabled data.
polt-simulator_compose | [240037: I NETCONF             ] bbf-vomci.c 180| xpath=/bbf-olt-vomci:remote-network-function/nf-client event=4
polt-simulator_compose | [240038: I SYSREPO             ] Triggering "bbf-olt-vomci" "done" event on enabled data.
polt-simulator_compose | [240038: I NETCONF             ] bbf-vomci.c 180| xpath=/bbf-olt-vomci:remote-network-function/nf-client event=2
polt-simulator_compose | [240038: I NETCONF             ] bbf-vomci.c 667| Subscribed to /bbf-olt-vomci:remote-network-function/nf-client subtree changes.
polt-simulator_compose | [240039: I SYSREPO             ] Triggering "bbf-olt-vomci" "enabled" event on enabled data.
polt-simulator_compose | [240039: I NETCONF             ] bbf-vomci.c 348| xpath=/bbf-olt-vomci:remote-network-function/nf-endpoint-filter event=4
polt-simulator_compose | [240039: I SYSREPO             ] Triggering "bbf-olt-vomci" "done" event on enabled data.
polt-simulator_compose | [240039: I NETCONF             ] bbf-vomci.c 348| xpath=/bbf-olt-vomci:remote-network-function/nf-endpoint-filter event=2
polt-simulator_compose | [240040: I NETCONF             ] bbf-vomci.c 684| Subscribed to /bbf-olt-vomci:remote-network-function/nf-endpoint-filter subtree changes.
polt-simulator_compose | [240040: I NETCONF             ] bbf-vomci.c 701| Subscribed to /bbf-olt-vomci:remote-network-function/nf-server/listen/listen-endpoint/remote-endpoints subtree operation data retrieval.
polt-simulator_compose | 1: #/po/au priv_key=/certificates/vomci_privatekey.pem local_cert=/certificates/vomci.cer peer_cert=/certificates/polt.cer
polt-simulator_compose |
polt-simulator_compose | 2: /po/set client_server=client enable=yes
polt-simulator_compose |
polt-simulator_compose | [240041: I POLT                ] bcm_tr451_polt_common.cc 880| Enabling client subsystem..
polt-simulator_compose | 3: #/po/end client_server=client name=polt-simulator port=8433 host=polt-simulator
polt-simulator_compose |
polt-simulator_compose | 4: /log/n name=POLT log_level_print=DEBUG log_level_save=DEBUG
Step-4:
fandy@onu-1:~/obbaa-onu-simulator$ docker container run -it --name obbaa-onu-simulator --network obbaa-polt-simulator --rm -p 50000:50000/udp broadbandforum/obbaa-onu-simulator:latest bash
docker: Error response from daemon: network obbaa-polt-simulator not found.
ERRO[0000] error waiting for container: context canceled
Manually start onu simulator test and same error:
Window #1
fandy@onu-1:~/obbaa-onu-simulator$ onusim.py -n channeltermination.1 -i 1 -p 50000 -l 2
DEBUG:onusim:args Namespace(address='<IP_ADDRESS>', ctermname='channeltermination.1', dumpfile=None, extended=False, loglevel=2, onuidfirst=1, onuidlast=None, port=50000)
DEBUG:onusim:server Endpoint(address=('<IP_ADDRESS>', 50000), is_server=True, cterm_name='channeltermination.1', onu_id_range=range(1, 2), tr451=True, dumpfd=None)
No message received from omci.
Window #2
fandy@onu-1:~/obbaa-polt-simulator/build/fs$ ./start_tr451_polt.sh -d
bcmos_task_create#145> INF: Thread dev_log_save: priority 30 is ignored. Start as root to honor priorities
bcmos_task_create#145> INF: Thread dev_log_print: priority 30 is ignored. Start as root to honor priorities
[926596: I default             ] bcm_dev_log_task.c 1476| Logging started
/po/set client_server=server enable=yes
[943552: I POLT                ] bcm_tr451_polt_common.cc 907| Enabling server subsystem..
/po/au priv_key=//home/fandy/obbaa-onu-simulator/share/polt_privatekey.pem local_cert=//home/fandy/obbaa-onu-simulator/share/polt.cer peer_cert=//home/fandy/obbaa-onu-simulator/share/vomci.cer
/po/en client_server=server name=polt port=8433
[943578: I POLT                ] bcm_tr451_polt_server.cc 216| Creating server polt: name_for_hello=polt listen=any:8433
/polt/filter  name=filt1 priority=100 ep_name=vomci1 Type=any
bcmos_task_create#145> INF: Thread polt_client_server: priority 19 is ignored. Start as root to honor priorities
[943596: I POLT                ] bcm_tr451_polt_common.cc 588| pOLT server polt started
[943597: I POLT                ] bcm_tr451_polt_server.cc 60| polt: Enabling ssl authentication
[943653: I POLT                ] bcm_tr451_polt_server.cc 75| Server polt is listening on <IP_ADDRESS>:8433
[968734: I POLT                ] bcm_tr451_polt_server.cc 126| Server polt: received HelloRequest from vOMCI polt1
Server BcmPoltServer::OmciServiceMessage::ListenForVomciRx ++
[968736: I POLT                ] bcm_tr451_polt_server.cc 159| polt: Forwarding OMCI messages from pOLT to vOMCI polt1@ipv6:[::1]:56298 enabled
UpdateOnuAssignmentsConnected ++
/po/onu channel_term=channeltermination.1 onu_id=1 serial_vendor_id=BRCM serial_vendor_specific=00000001
polt_cli_onu_add ++
sim_tr451_vendor_onu_added ++
/po/rx_mode mode=onu_sim onu_sim_ip=<IP_ADDRESS> onu_sim_port=50000 local_udp_port=50100
bcmos_task_create#145> INF: Thread cm_rx: priority 7 is ignored. Start as root to honor priorities

~, Logger/, Run, Quit, Polt/

[1030913: E POLT                ] bcm_tr451_polt_common.cc 724| polt: Can't send OMCI message to vOMCI. No connection. ONU channeltermination.1:1
:
Window #3
fandy@onu-1:~/obbaa-polt-simulator/build/fs$ ./start_tr451_polt.sh -d
bcmos_task_create#145> INF: Thread dev_log_save: priority 30 is ignored. Start as root to honor priorities
bcmos_task_create#145> INF: Thread dev_log_print: priority 30 is ignored. Start as root to honor priorities
[960715: I default             ] bcm_dev_log_task.c 1476| Logging started

~, Logger/, Run, Quit, Polt/
/po/au priv_key=/home/fandy/obbaa-onu-simulator/share/vomci_privatekey.pem local_cert=/home/fandy/obbaa-onu-simulator/share/vomci.cer peer_cert=/home/fandy/obbaa-onu-simulator/share/polt.cer
/po/set client_server=client enable=yes
[968700: I POLT                ] bcm_tr451_polt_common.cc 907| Enabling client subsystem..
/po/end client_server=client name=polt1 port=8433 host=localhost
bcmos_task_create#145> INF: Thread polt_client_server: priority 19 is ignored. Start as root to honor priorities
[968721: I POLT                ] bcm_tr451_polt_client.cc 339| Creating client polt1: name_for_hello=polt1  entry polt1 localhost:8433
[968722: I POLT                ] bcm_tr451_polt_common.cc 588| pOLT client polt1 started
[968722: I POLT                ] bcm_tr451_polt_client.cc 131| client polt1.polt1: establishing ssl connection with the server at localhost:8433
[968735: I POLT                ] bcm_tr451_polt_client.cc 173| client polt1.polt1: 'hello' exchange with the server at localhost:8433 completed: connected to vomci polt
bcmos_task_create#145> INF: Thread polt1: priority 9 is ignored. Start as root to honor priorities
/po/filter name=filt1 priority=100 ep_name=polt1 Type=any

~, Logger/, Run, Quit, Polt/
/po/onu channel_term=channeltermination.1 onu_id=1 serial_vendor_id=BRCM serial_vendor_specific=00000001
[1003647: I POLT                ] bcm_tr451_polt_common.cc 303| ONU channeltermination.1:1 is assigned to remote endpoint polt using filter 'filt1'

~, Logger/, Run, Quit, Polt/
/po/inject channeltermination.1 1 0054480a01000000040001000000000000000000000000000000000000000000000000000000000000000028

Thanks, Dongyang

@fandy-genew
Regarding Start of onu simulator:
I see that in your case the docker network for polt-simulator is obbaapoltsimulator_default . you are using the wrong command : docker container run -it --name obbaa-onu-simulator --network obbaa-polt-simulator --rm -p 50000:50000/udp broadbandforum/obbaa-onu-simulator:latest bash (pointing to non-existing docker network obbaa-polt-simulator), failure is expected.
So your command must be pointing to the existing network(something like this)
docker container run -it --name obbaa-onu-simulator --network obbaapoltsimulator_default --rm -p 50000:50000/udp broadbandforum/obbaa-onu-simulator:latest bash
ONU-Simulator IP:
/po/rx_mode mode=onu_sim onu_sim_ip=<IP_ADDRESS> onu_sim_port=50000 local_udp_port=50100 --> IP pointing to the onu-simulator container is wrong
You must be able to get the onu-simulator's docker container IP, using the below said commands.
docker inspect polt-simulator_compose | grep IPA
"SecondaryIPAddresses": null,
"IPAddress": "",
"IPAMConfig": null,
"IPAddress": "<IP_ADDRESS>",
docker inspect obbaa-onu-simulator | grep IPA
"SecondaryIPAddresses": null,
"IPAddress": "",
"IPAMConfig": null,
"IPAddress": "<IP_ADDRESS>",
Note : This above output confirms that both simulators are on the same docker network.

@selvaitech
Thanks for you greate support.
I manually run simulator is OK.
1. Window1: start onu simulator
onusim.py -n channeltermination.1 -i 1 -p 50000 -l 2
2. Window2: start polt server simulator
./start_tr451_plot.sh -d
/po/set client_server=server enable=yes
/po/au priv_key=//home/fandy/obbaa-onu-simulator/share/polt_privatekey.pem local_cert=//home/fandy/obbaa-onu-simulator/share/polt.cer peer_cert=//home/fandy/obbaa-onu-simulator/share/vomci.cer
/po/en client_server=server name=polt port=8433
3. Window3: start polt client simulator
./start_tr451_plot.sh -d
/po/au priv_key=/home/fandy/obbaa-onu-simulator/share/vomci_privatekey.pem local_cert=/home/fandy/obbaa-onu-simulator/share/vomci.cer peer_cert=/home/fandy/obbaa-onu-simulator/share/polt.cer
/po/set client_server=client enable=yes
/po/end client_server=client name=polt1 port=8433 host=localhost
**4. Config polt server by Window 2**
/polt/filter  name=filt1 priority=100 ep_name=polt1 Type=any
/po/onu channel_term=channeltermination.1 onu_id=1 serial_vendor_id=BRCM serial_vendor_specific=00000001
/po/rx_mode mode=onu_sim onu_sim_ip=<IP_ADDRESS> onu_sim_port=50000 local_udp_port=50100

**5. Config polt client by Window 3**
/po/filter name=filt1 priority=100 ep_name=polt1 Type=any
/po/onu channel_term=channeltermination.1 onu_id=1 serial_vendor_id=BRCM serial_vendor_specific=00000001

**6. Send message to onu simulator by Window 3, then Window1 will print out messages**
/po/inject channeltermination.1 1 0054480a01000000040001000000000000000000000000000000000000000000000000000000000000000028


Feature Request: app icon options

I just got the update that adds the Big Sur style icon. However, I'm not fond of icons changing, and I particularly dislike Big Sur's icon language. Can you add a preference to restore the previous icon?

We can understand why some don't like Big Sur's design language. Regardless, the NetNewsWire team works hard to match platform conventions and be good citizens in the Apple ecosphere. We think we've struck a good balance by using the old icons on Catalina and the new on Big Sur. We don't have any plans to provide a preference to go against platform conventions at this time.


Need rust installed to install via the trust lib

install.sh: ERROR need rustc (command not found)
this will work without rust: https://gist.github.com/sjparkinson/327dc78c60ab81a06c946630b4288910
But there is a problem with mktemp on linux #9
I really like the idea of  using NPM for distributing binaries. Trust works really well for automating the creation of binaries. But I think we should use a node script to download the releases. I'm  running into the same issue trying to distribute rustywind

Update I'm downloading the release using this script: https://github.com/avencera/rustywind-npm/blob/master/install.js
And I add the bin line to my package.json:
https://github.com/avencera/rustywind-npm/blob/master/package.json#L20
Doing this means the the binary will be remove during npm uninstall -g  or yarn global remove


Wiki : documentation include

In https://github.com/dingo/api/wiki/Transformers
Add a documentation on include:
there is several way describe there : https://github.com/dingo/api/issues/854

Includes are provided by the Fractal package, and you can find documentation on it there.
https://fractal.thephpleague.com/transformers/


Provide ACMG classification support for SVs/CNVs

Is your feature request related to a problem? Please describe.
There are ACMG classifications for CNVs. VarFish does not provide support for them.
Describe the solution you'd like
Implement support for annotating CNVs using the corresponding ACMG guidelines similar to how it is done for small variants.
Describe alternatives you've considered
N/A
Additional context

Technical standards for the interpretation and reporting of constitutional copy-number variants: a joint consensus recommendation of the American College of Medical Genetics and Genomics (ACMG) and the Clinical Genome Resource (ClinGen)
#426

In first approximation just having the result classification benign, likely benign, VUS, likely pathogenic, pathogenic would be extremely helpful, as we currently are unable to properly annotate any identified SVs in Varfish, which blocks Clinvar transfer of SVs.

Will stop working on this. The vue code for structural variants differs too much from that for small variants.

Okay, no problem. We can discuss issues and longer term plan next thursday.


mkl lib for osx?

the script only downloads for linux.  is there an osx version?

Are you referring to the script that downloads MKL? We did not test mkl-dnn on OSX so there are probably additional issues. If you already have MKL installed (there is a free version now), you can try using it to with mkl-dnn by setting MKLROOT environment variable. This can be done by, for example, sourcing mklvars.sh setup script.
PS. If you decide to give this a try, please let me know how it went. If there are minor issues, we can try fixing them before we start working on an official OSX support.


2007 - Updates Placeholder Links

James accurately pointed out that the link for the NoFormsPlaceholder was now not as relevant.
Updated to point to our page on Content Modelling.
Closes #2007

What if you don't use Tina Cloud?

What if you don't use Tina Cloud? what if you're an editor just clicking on the pencil icon?

A good question that I don't have the answer for.  The link is based off James' suggestion.
What would you propose?  This is in tinacms, so is there a universal location?


Offer is still in active status though it has expired long time ago

I noted that we still show "Expired" offers as "Highest Offer" (on /snek/gallery/914494658-1?redesign=true)

I found that it would not show "Expired" offers. In your link provided, the offer that has price of 0.1ksm, is still in active status.

offer has expired 7 month ago
Originally posted by @roiLeo in https://github.com/kodadot/nft-gallery/issues/4697#issuecomment-1384063922

It may be related to snek side. Or if we don't set cancelled status for some offer correctly.


type_definition should take value receiver

This allows With chaining on a non-ptr TypeDefinition:
td.WithType(IntType).WithName(name)

Pull Request Test Coverage Report for Build 190372007

5 of 10 (50.0%)  changed or added relevant lines in 1 file are covered.
190 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-3.07%) to 29.037%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

hack/generator/pkg/astmodel/type_definition.go
5
10
50.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/zips/env.go
3
0%

pkg/zips/types.go
25
54.76%

pkg/zips/client.go
75
3.96%

pkg/zips/template.go
87
26.32%

Totals

Change from base Build 190367185:
-3.07%

Covered Lines:
1800

Relevant Lines:
6199

💛  - Coveralls

Pull Request Test Coverage Report for Build 190372007

-5 of 10 (50.0%)  changed or added relevant lines in 1 file are covered.
190 unchanged lines in 4 files lost coverage.
Overall coverage increased (+2.4%) to 34.485%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

hack/generator/pkg/astmodel/type_definition.go
5
10
50.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/zips/env.go
3
0%

pkg/zips/types.go
25
54.76%

pkg/zips/client.go
75
3.96%

pkg/zips/template.go
87
26.32%

Totals

Change from base Build 190367185:
2.4%

Covered Lines:
978

Relevant Lines:
2836

💛  - Coveralls


feat: :sparkles: change chain name with asset name

Changed chain name with asset name inside assets table.
What is the purpose of the change
Resolve issue #2429
ClickUp Task
ClickUp Task URL
Brief Changelog

Testing and Verifying

Documentation and Release Note

Looks great!


RTL changes

Hi @hikaysici ,
Just for information asking this.
Have you done any RTL changes from the original riscduino code?

Also facing error during PDN stage:
Error: pdn_cfg.tcl, 89 can't read "::env(FP_PDN_MACROS)": no such variable

https://github.com/hikaysici/Efabless_MPW6_riscduino/blob/faacfa367a934d4f7b861411725b20a330b34ad8/openlane/user_project_wrapper/pdn_cfg.tcl#L72


OS X: App refuses to launch with BetterDiscord

I get a javascript error, see atached file
Version used 0.2.7
How can I uninstall the thing on OS X ? OK i reinstalled the app and it removed the broken BetterDiscord

Did this get fixed for Discord Version 1.0.0 (0.0.239) ?

Just tried with Discord 1.0.0 (0.0.239), still have the problem.
It worked fine on the previous version.

https://github.com/iVEnoVaLue/BetterPlugins/raw/master/app/OSX/Installer/BetterDiscord.pkg
Base script version 2.7 (compatible with 2.8)
This week i have a few days free and i might get to rewrite the base script

The .pkg did work


Image disappears in the last slide (slide becomes blank) when it moves left

Checks

[X] Not a duplicate.
[X] Not a question, feature request, or anything other than a bug report directly related to React Splide. Use Discussions for these topics: https://github.com/Splidejs/splide/discussions

Version
0.6.20
Description
I use React Splide with these options:
const options = {
    type: "loop",
    autoplay: true,
    pauseOnHover: false,
    arrows: false,
    pagination: false,
    width: "100%",
    height: "100%",
    interval: 3500,
    speed: 1500,
  }

And I notices that as soon as the last slides starts to move left an image in the slide becomes blank. Not the slide itself because I still can see text inside. Also the first slides that comes from the right also has blank image. Here is the gif I made: https://imgur.com/a/u1SGtNU
I tried to reduce the rewindSpeed but it didn't help.
P.S. I also noticed that if I give the last slider some backround color then it would ignore that CSS rule. But when it moves left it would change it's color. For example, if I set background color for every 2nd child of all slides (I have 6 slides in total, but it doesn't work with nth-child(2)):
.slide {
  display: flex;
  flex-direction: column;
  justify-content: space-between;
  align-items: center;

  &:nth-child(2) {
    background-color: tomato;
  }
}

then I would get this: https://imgur.com/a/6nJ9yIz
I think the last slide loses it's is-visible class as soon as it starts to move.
Reproduction Link
No response
Steps to Reproduce
.
Expected Behaviour
.

Splide generates clones to loop the slider. When you start dragging on the first (or last) slide, it reculucutates each visibility and the active slide loses is-visible since it's out of viewport (a bit).
Why do you need to rely on is-visible?

I don't rely on it. I just thought the problem was with the is-visible class. Anyway as you can see here the slider works a bit strange

Do you mean an image desappears in just a simple loop slider?
If so, the issue is not reproductive:
https://codesandbox.io/s/37-ejc5s
Please fork and reproduce your issue on it.


Add Custom Document Well Option (like Productivity Power Tools 2017/2019 extension)

The horizontal scrollbar for file tabs is so tiny that it is very difficult to drag it with the mouse or track it using the scroll wheel. Currently there is a setting called Editor: Tab Sizing which only provides two options: fit and shrink.
I would like to propose a feature like the Custom Document Well option provided by the Productivity Power Tools 2017/2019 extension.
This feature would allow users to customize the behavior and look of their document tabs.

Scrollable tabs
Maintain spatial consistency of the documents that are included in the document well.
Vertical tabs
Document tabs are shown vertically, allowing you to fit more tabs than are normally visible when shown horizontally.
Show close button in tab well
Show the close document button in the document well that will close the active tab, similar to Visual Studio 2008.
Tab Commands for Navigation
Using Ctrl+Alt+Page Down and Page Up to navigate between tabs (including pinned) in visual order.
Activate a specific pinned tab by Ctrl+Num Pad 1 through 0
Activate a specific regular tab by Ctrl+Alt+Num Pad 1 through 0
Sort by most recently used
Whenever a tab becomes active, it is moved to the left - such that all tabs will be sorted in most recently used order.
Sort tabs by project
Tabs will be sorted by the project they belong to, thus keeping them always together in the document tab well.
Sort tabs alphabetically
Tabs will be sorted alphabetically. When Sort By Project is turned on, tabs will be sorted first by project and then alphabetically.
Color tabs according to their project or according to regular expressions
This option permits tabs to be colored according to the project they belong to. This is particularly useful when sorting tabs by project, as it allows you to immediately identify different groups of project documents.
You can also configure regular expressions and assign a color to each one. If the name of a tab matches the configured regular expression, it will be colored with the assigned color.
Show close button in tab
Modify dirty indicator style
This option allows you to select from a set of different dirty indicators that you might prefer over the asterisk.
Modify minimum and maximum tab size
Allows you to modify minimum and maximum tab size. Try setting minimum and maximum sizes to the same value, and you will have evenly spaced tabs.

Thanks in advance for your consideration.

Additional sort option: sort by full path. Useful for web projects with multiple "index.cshtml" or "default.aspx" files.


Add GitHub workflow to close stale PRs

Is your feature request related to a problem or challenge?
We currently have 116 open PRs, some of them from around one year ago. This creates an additional maintenance burden for reviewers and also can result in older active PRs being ignored.
Describe the solution you'd like
We could use this GitHub action to automatically close PRs that are inactive for 60 days:
https://github.com/marketplace/actions/close-stale-issues
Describe alternatives you've considered
No response
Additional context
No response

@alamb WDYT?

@alamb WDYT?

I think that would be super helpful 🙏  and I think it would be nice to have a policy that just closes stale PRs rather than doing it manually (which requires I think writing down some explanation of what is needed).
Maybe we can also write up a section in the docs (I can maybe help) about how PRs are prioritized for reviews?
Here are some filters I have been using

Read to merge: https://github.com/apache/arrow-datafusion/pulls?q=is%3Apr+is%3Aopen+review%3Aapproved+-is%3Adraft
Need review https://github.com/apache/arrow-datafusion/pulls?q=is%3Apr+is%3Aopen+-review%3Aapproved+-is%3Adraft+

@alamb are there someone working with this?
If not, I think I can work with it.
this is meaningful!!!

Thank you @Tangruilin  -- this would be really helpful. I agree it is meaningful. No one is working on it that i know of

I plan on picking this up if nobody beats me to it.


Adds script to apply whitelabel settings and resources

Description
Adds a script called whitelabel.py which applies a list of customizations to the app source.
JIRA tickets: OSPR
Discussions: This change provides one step in the approach laid out in the edX Mobile Whitelabel Strategy document.
Screenshots:
Sandbox URL: TBD - sandbox is being provisioned.
Partner information: 3rd party hosted Open edX instance
Merge deadline: None
How to test this PR

See this branch's README.rst for instructions on how to use the new whitelabel.py script.  These instructions also need testing, so they're not repeated here.
Build and run the updated app to ensure that the customizations you configured made it into the app itself.

Reviewers

[ ] @carlio
[ ] edX reviewer[s] TBD

Thanks for the pull request, @pomegranited! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.
Create an OSPR issue for this pull request.

Codecov Report

Merging #959 into master will decrease coverage by 21.6%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #959       +/-   ##
==========================================
- Coverage    45.7%   24.1%   -21.61%
==========================================
  Files         402     697      +295
  Lines       26388   55286    +28898
==========================================
+ Hits        12061   13327     +1266
- Misses      14327   41959    +27632

Impacted Files
Coverage Δ

Pods/Parse/Parse/PFInstallation.m
7.4% <0%> (ø)

...mmandRunner/URLSession/PFURLSessionCommandRunner.m
0% <0%> (ø)

Pods/Parse/Parse/PFCloud.m
0% <0%> (ø)

...API/ProtocolVersions/FBSDKBridgeAPIProtocolWebV2.m
0% <0%> (ø)

...KCoreKit/FBSDKCoreKit/Internal/UI/FBSDKCloseIcon.m
0% <0%> (ø)

...DKCoreKit/Internal/Network/FBSDKGraphRequestBody.m
0% <0%> (ø)

...eKit/FBSDKCoreKit/FBSDKCoreKit/FBSDKGraphRequest.m
0% <0%> (ø)

Pods/Parse/Parse/Internal/PFBase64Encoder.m
0% <0%> (ø)

Pods/Bolts/Bolts/iOS/BFURL.m
0% <0%> (ø)

...arse/Parse/Internal/ACL/State/PFACLState_Private.h
0% <0%> (ø)

... and 289 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440220f...3d9111a. Read the comment docs.

@haikuginger  Thanks for your review!  Let me know when you're ok with it, and I'll squash and create an OSPR.

Thanks for the pull request, @pomegranited! I've created OSPR-1831 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
If you like, you can add yourself to the AUTHORS      file for this repo, though that isn't required.     Please see the CONTRIBUTING     file for more information.

Thanks for your review, @gsong, I've addressed your comments.
Please let me know what else I need to do before this can be merged?

Fixed the nits you noticed, thank you @gsong !  It's looking lovely and clean now.
Is this ok to merge, or do I need a second review?

Thank you, @gsong !


boehmgc: 8.0.6 -> 8.2.0

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Not sure the branch change went right.

100% sure the branch change failed miserably. Fixing.

@ofborg build guile

Being experimental, I will remove the "upgrade" commit.

@ofborg build guile

May target master if there is no rebuilds. I am not familiar with this pkg, ask for someone else if you need a review :-)

@ofborg build guile

@ofborg build guile

Diff LGTM, have you tried building and running nix with this?

@ofborg build guile nix

@ofborg build guile nix

@ofborg eval

@ofborg eval

Any noticeable reason for the egregious failure on Darwintel?

@ofborg build guile nix


Timer test (with fixed coding style)

@siddMahen how is this for style?

Are both timers necessary? @BrytniR @timmysilv

@siddMahen with the limited amount of thought we put into it, we decided an easy way to add a second timed function is by adding a second timer. There isn't really the pure h/w benefit because the timer code Shimi made uses s/w as well, so we could just make different commands occur periodically based on one timer in s/w. Totally up for discussion but hey now we have 2.

@timmysilv ah, so just to clarify, there's one hardware timer driving two software timers?

Also, this branch cannot be merged until its git history is cleaned up using git rebase.

@siddMahen they're actually 2 separate hw timers with periods too small for us to use, so we manage both by essentially using their max periods a certain number of times, which is done in software. Virtually identical except one's 16-bit, and the other is 8-bit

Ah ok, thanks. Maybe we should rename them timer_8t and timer_16t, to denote which hardware timer the software timers are based on?

@BrytniR Is there a reason set_vars_ is public? Is there a mechanism to turn timers on and off?

@siddMahen no, it can be made private.

@BrytniR @brunofalmeida @timmysilv Just rebased on top of master; this should be ready to merge. Could someone quickly review this?


Check field by option from select

When i manually checking filed by selected option - other fields not checking
example http://jsfiddle.net/f3jt1vje/  -  on submit not checking name field

Your method 'check' is not dynamic.
Maybe you can use the method required with function parameter
http://jqueryvalidation.org/category/methods/#example:-makes-“parent”-required-only-if-age-is-below-13
$.validator.addMethod(
        'check',
    function (value) {
        var valid = $('#testing').validate().element('#test' + value),
            filled = !! $('#test' + value).val();
        return filled && valid;
    },
        'test is wrong');

No response, closing. Feel free to add further information, will re-open the issue then..


File size is required in order to decrypt a basebackup with DecryptSink.

This fixes the issue reported at https://github.com/aiven/pghoard/issues/309
The patch makes sure that the actual basebackup file size is passed to the DecryptSink, which can then decrypt the backup with no errors.

Thanks for looking into this and providing a fix. This looks legit. There are a couple of calls to _find_nearest_basebackup from tests that would need to be updated.

Thanks for the fast reply. Tests are fixed now.

when will the next version of pghoard be released, I am blocked on this exact issue, and would prefer to use a version I can install with pip3


Feat: Reordering documentation to add more clairty [APE-1822]

What I did
I moved the Fixtures section on top of the Test Pattern section as mentioned on this issue APE-1822
Checklist

[ ] Is consistent
[ ] Is good documentation
[ ] Documentation has been updated

can we do this instead? https://github.com/ApeWorX/ape/pull/1829/files

Thank you @rafael-abuawad for contributing!
I think per our discussion in #1822, that #1829 is a better fix
closing in favor of #1829


Set-Content -LiteralPath on Windows fails to write to Pester's TestDrive:

Note:
This is a bizarre symptom that I only see in the very specific combination of  factors mentioned in the title (as of PowerShell Core 7.0.0-preview.5, Pester 4.9.0, on Windows, with TestDrive:, and Set-Content with -LiteralPath rather than -Path)
Given that I don't see it in Windows PowerShell, I thought I'd start by reporting it here.
Steps to reproduce
Run the following on Windows:
Describe "Set-Content can write to the root of TestDrive:" {
  It "Set-Content -LiteralPath" {
    {
      'hi' | Set-Content -Literalpath TestDrive:\foo.txt
    } | Should -Not -Throw
  }
}

Expected behavior
The test should pass.
Actual behavior
The test fails:
Set-Content : Access to the path 'C:\foo.txt' is denied.

Note how directory C:\ was unexpectedly targeted.
If you remove -LiteralPath (or switch to -Path), the problem goes away.
The problem does not surface with other PS drives.
Environment data
PowerShell Core v7.0.0-preview.5 on Microsoft Windows 10 Pro (64-bit; Version 1903, OS Build: 18362.418)
Pester 4.9.0

New-PSDrive -Name TestDrive -Root C:\tmp\ -PSProvider FileSystem
 'hi' | Set-Content -Literalpath TestDrive:\foo.txt

This works well.
Maybe @nohwnd add more info.

I wonder is C:\ the TestDrive? Usually it is user temp directory.

I wonder is C:\ the TestDrive? Usually it is user temp directory.

@mklement0 could you try with 4.10.1 and newer version of PS7? https://www.powershellgallery.com/packages/Pester/4.10.1
@iSazonov you are right testdrive should be user temp directory.

@mklement0 could you try with 4.10.1 and newer version of PS7? https://www.powershellgallery.com/packages/Pester/4.10.1
@iSazonov you are right testdrive should be user temp directory.

I tried on PowerShell Core 7.2.0-preview.2, with both Pester 4.10.1 and 5.1.1, and still see the problem.

I tried on PowerShell Core 7.2.0-preview.2, with both Pester 4.10.1 and 5.1.1, and still see the problem.

Same issue.
PowersHell version 7.1.4, pester 4.9.0.
Using -Path instead of -LiteralPath resolves the issue for tests but we have to use -LiteralPath.
Interestingly -LiteralPath for Test-Path, Get-Content and Resolve-Path works correctly.
What I found out is that once the target file exists, Set-Content -LiteralPath can overwrite the file located on TestDrive:\.


error 1 / error 2

ran
cmake -B Build -S .
installed all the DEP's and got past the errors and warnings but the
cmake --build Build --config Release -j 4
ends in...
gmake[2]: *** [Tests/CMakeFiles/Tests.dir/build.make:262: Tests/Tests] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:2600: Tests/CMakeFiles/Tests.dir/all] Error 2
gmake: *** [Makefile:160: all] Error 2
full output attached
log.txt

@lbutler112233 what compiler are you using?

cmake version 3.18.2


💬 Setup Discord Server ⇢ eQui\ Labs

First of all, I would like to congratulate you on the great work you have been doing. I would like to help you in N ways - but for now, I am broke 🥲.
Anyway, I really liked the transition support between the previous plugin, which I mentioned to you before, and yours. I was using the other one because to switch from it to yours I had to go to each note and change the way the banner was placed, but now when I installed yours - explosion sound -, it took the place of the other one without any problems, overlapping them. I turned off the previous one and finally got to see how beautiful it is - here is a preview of how it all looks below.
There is nothing to be fixed here, maybe you can add more image providers, optimize the code, change something in the readme to make it clearer for newbies, you know, little details that we will see after the hard work of writing lines and lines.
I would really like a direct communication channel with you because, well, bug notes on GitHub are not very efficient - suggestions like Telegram or Discord are fine, even if, as you read this, think about the countless community requests you have received; I hope they don't take your arm ~lol.
Thanks in advance for all this, I know it's not easy, but I hope your effort pays off - and I hope to help you at some point 🫡.
Note: Maybe an AI-powered banner image generator in the future? Looking forward to tomorrow!
About img: You may not understand, but it is written in pt-br 😅

Beautiful Note!

Thank you for your kind words!
I am contemplating setting up a simple Discord Server for a community around all open source software I develop.
stay tuned... I'll ping you here with an invite link once I have something up and ready.

@Leike-Dev love the screen shot. what plugin are you using for the formatting toolbar on the bottom of the note?

I guess it is Editing Toolbar with Fixed position setting:

I guess it is Editing Toolbar with Fixed position setting:

Exactly this plugin 🥰. I really like it and for the Obsidian look I use Primary.
My settings:

@Leike-Dev / @Moyf
Haven't had time to setup a Discord Server yet, but feel free to add me as a friend/message me there in the meantime.
Discord username: jparkerweb

What do you think? @Moyf  🏃♂➡

What do you think? @Moyf 🏃♂➡

I don't use Disord very often for network reasons, but I've added JParker
You can also provide a username and I'll add you! ~

This is my username _azurita 🥰

This is my username _azurita 🥰

Yeah I've sent the request~ 😸

Accepted 🏃♂➡

@Moyf @Leike-Dev
Either of you have names suggestions for a Discord server, or "company" name for all the stuff I've been writing?

@Moyf @Leike-Dev Either of you have names suggestions for a Discord server, or "company" name for all the stuff I've been writing?

Justin's Amazing Plugins ; )

Pixelin(Pixel + Plugin) or Inker(Plugin + Parker)? 😅

I think I've settled on eQuill Labs
need a logo now :)

Got something in mind? Minimalist? Line drawing? Colorful?

@Leike-Dev @Moyf
invite here:
https://discord.gg/vQDmkkQp
Maybe you two can help me setup the server and take on the moderator roles?
I'm no discord expert ;)

! logo-outline-half

Nice Logo! 👍🏻
Unfortunately I open Discord probably once or twice a month lol, I have a hard time accessing DC due to network reasons.
But anyway, I've joined the channel ; )

It's amazing. A great logo 😊

starting on the website:

make sure it is mobile friendly as well ;)

starting to add content to the projects section:

https://github.com/YappyBots/YappyGitHub


Lint code

Linting the codebase as planned.
This is a draft pull request as it should show the current progress to the other maintainers of the repository and provides a platform to discuss the change i've made.
Still to do:

async package
jUnit Tests
two methods in assembly.java (hard to describe)

closes #60

It is not 100% complete but let us merge it to avoid further conflicts.
I will continue with that besides the other issues.
I would like to leave Issue #61 open for the moment :)

It is not 100% complete but let us merge it to avoid further conflicts.
I will continue with that besides the other issues.
I would like to leave Issue #61 open for the moment :)

Guess we can go live now :D
All checks are passing and the linter runs on the whole repo!

All checks are passing and the linter runs on the whole repo!

Amazing, incredible work! :heart_eyes: Feel free to merge it! The honor is all yours!

@Acconut  merged the PR now :)

Incredible :100:


Files in MANIFEST.in are not copied

For some reason all files specified in MANIFEST.in are not copied to the installation path. This would severely shorten all training data includes in setup.py

I shall examine my dark proteome visualisation project for a walker solution.


Build number not set to project Extension

We just added this step to our workflow, which works great for the main target of our project, but fails to correctly set the build number in the embedded Extension we have.
This triggers a warning in TestFlight, which states"

CFBundleVersion Mismatch - The CFBundleVersion value '0' of extension 'XXX.app/PlugIns/OneSignalNotificationServiceExtension.appex' does not match the CFBundleVersion value '651' of its containing iOS application 'XXX.app'.

Hi @AnoxySoftware!
Can you send us the related build URL please?

Sure @bitce , it happens on all of our builds, but here is one for example:
https://app.bitrise.io/build/ea1018e607fd7547

Hy there, in this build I can't find this warning 🤔
for me it says no error uploading

Hi again @AnoxySoftware!
So we've taken a look, and this doesn't seem to be an "issue". By design the step was created to be limited to a single plist file and doesn’t search for any other scenarios.
That said, it's rather strange that nobody reported this limitation before, we've created a task for the team to include this feature in the step :)

Thank you @bitce
I'll wait for the update.

Hi @AnoxySoftware !
Sorry for the delayed answer.
You are right, this step will modify the version number in one Info.plist only.
If your IPA contains multiple build targets ( e.g watch app, extensions ), then you would need to add this step to your workflow multiple times for every build target one by one ( with the current target's Info.plist path ).
Currently, we do not plan to change how the step works.
I would suggest creating a feature request for modifying the step, to find these Info.plist automatically.
https://discuss.bitrise.io/c/feature-request

Thx. I just did this and see how it will end up :)


Read permission errors

@ilogue not exactly sure why permission errors on read only raw files started popping up?

Traceback (most recent call last):
File "/home/ktavabi/Projects/niprov/niprov/adding.py", line 70, in add
img.inspect()
File "/home/ktavabi/Projects/niprov/niprov/fif.py", line 13, in inspect
provenance = super(FifFile, self).inspect()
File "/home/ktavabi/Projects/niprov/niprov/basefile.py", line 23, in inspect
self.provenance['hash'] = self.hasher.digest(self.path)
File "/home/ktavabi/Projects/niprov/niprov/hashing.py", line 19, in digest
with open(filename, "r+b") as f:
IOError: [Errno 13] Permission denied: '/mnt/ALAYA/data/ilabs/bad_baby/bad_129a/raw_fif/bad_129a_mmn_raw.fif'
[provenance:warning] Error inspecting file: /mnt/ALAYA/data/ilabs/bad_baby/bad_129a/raw_fif/bad_129a_mmn_raw.fif

Can you try with:
On Feb 1, 2016 10:33, "Kambiz"<EMAIL_ADDRESS>wrote:

@ilogue not exactly sure why permission errors on read only raw files
started popping up?

Traceback (most recent call last):
File "/home/ktavabi/Projects/niprov/niprov/adding.py", line 70, in add
img.inspect()
File "/home/ktavabi/Projects/niprov/niprov/fif.py", line 13, in inspect
provenance = super(FifFile, self).inspect()
File "/home/ktavabi/Projects/niprov/niprov/basefile.py", line 23, in
inspect
self.provenance['hash'] = self.hasher.digest(self.path)
File "/home/ktavabi/Projects/niprov/niprov/hashing.py", line 19, in
digest
with open(filename, "r+b") as f:
"rb" instead of "r+b"

IOError: [Errno 13] Permission denied:
'/mnt/ALAYA/data/ilabs/bad_baby/bad_129a/raw_fif/bad_129a_mmn_raw.fif'
[provenance:warning] Error inspecting file:
/mnt/ALAYA/data/ilabs/bad_baby/bad_129a/raw_fif/bad_129a_mmn_raw.fif

—
Reply to this email directly or view it on GitHub.

If that work, please PR it
On Feb 1, 2016 10:41<EMAIL_ADDRESS>wrote:

Can you try with:
On Feb 1, 2016 10:33, "Kambiz"<EMAIL_ADDRESS>wrote:

@ilogue not exactly sure why permission errors on read only raw files
started popping up?

Traceback (most recent call last):
File "/home/ktavabi/Projects/niprov/niprov/adding.py", line 70, in add
img.inspect()
File "/home/ktavabi/Projects/niprov/niprov/fif.py", line 13, in inspect
provenance = super(FifFile, self).inspect()
File "/home/ktavabi/Projects/niprov/niprov/basefile.py", line 23, in
inspect
self.provenance['hash'] = self.hasher.digest(self.path)
File "/home/ktavabi/Projects/niprov/niprov/hashing.py", line 19, in
digest
with open(filename, "r+b") as f:
"rb" instead of "r+b"

IOError: [Errno 13] Permission denied:
'/mnt/ALAYA/data/ilabs/bad_baby/bad_129a/raw_fif/bad_129a_mmn_raw.fif'
[provenance:warning] Error inspecting file:
/mnt/ALAYA/data/ilabs/bad_baby/bad_129a/raw_fif/bad_129a_mmn_raw.fif

—
Reply to this email directly or view it on GitHub.


How to remove the manually installed copy?

I installed the app manually and then discovered the snap package so I decided to install the snap version instead. My only problem is now I have two copies of the app don't know how to remove the manually installed copy. I tried using Synaptic to remove it and it removed one copy but not the other.

sudo apt-get purge tusk*
to remove all tusk application


Serializing a tf.keras.Model in half-precision

System information.

Have I written custom code (as opposed to using a stock example script provided in Keras): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Colab
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): 2.11.0
Python version: 3.8.16
Bazel version (if compiling from source):
GPU model and memory:
Exact command to reproduce:

Describe the problem.
After setting the precision policy to be mixed_float16 the serialized model is not in half-precision.
Is this expected? For larger models (Stable Diffusion, for example), allowing users to serialize models in half-precision can be quite beneficial.
Describe the current behavior.
The model gets serialized in full precision.
Describe the expected behavior.
Users should have a way to serialize a model in half-precision.
Contributing.

Do you want to contribute a PR? (yes/no): no
If yes, please read this page for instructions
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue.
Colab Gist: https://colab.research.google.com/gist/sayakpaul/c7abb6f8057ba21857985de5e26a22d8/scratchpad.ipynb

@SuryanarayanaY I was able to replicate the issue, please find the gist here.
Thank you!

Hi @sayakpaul ,
Apologies for delayed response.Setting the policy to 'mixed_float16' or 'mixed_bfloat16', makes the compute dtype to be float16 or bfloat16 and the variable dtype to be float32.
In the attached code of yours doesn't checked the serialized model dtypes. I tested the same code and after model.save(), I have reloaded the model and checked the dtype which is same as initial model.
For initial model:
model Compute dtype: float16
model Variable dtype: float32

For serialized model after reloading:
reloaded_model Compute dtype: float16
reloaded_model Variable dtype: float32

Please refer to attached gist.
This is what you looking right? Please confirm if anything else missing here.
Thankyou!

I want to serialize the model weights in FP16.

@sayakpaul ,
Policy will be applicable to computations only. As Model weights are Variables they will remain as float32 dtype only which is default.Please refer to documentation link1 and link2.The main purpose of Policy is to improve performance by making computations in float16 when set global_policy to mixed_float16  or mixed_bfloat16.

@sayakpaul ,
This is not a serialization issue.Model variables(weights) always will be either float32 (by default) or float64 if set global_policy to float64. Model weights will not be converted to half precision since it affects Accuracy of Model.
The minimum precision for model variables is float32 by default.Even if you set 'mixed_float16' for global policy and layer dtype also, the model variables(weights) will remains as float32 only.You can only change model.variables to float64 by setting the policy to float64.
Please refer to attached demo gist
You can check the model.variable_dtype for your model before and after serialization also it will remain same.Please report if you find any descripencies.

This is a bummer that even if I wanted to have the model weights in FP16, I cannot do it.

@sayakpaul ,
I have found one API which can

@sayakpaul ,
Sorry there has been some correction regarding model.weights default dtype.Actually I have digged more and found an API tf.keras.backend.set_floatx which actually controls the default dtype of Keras. As we know the model variable dtypes are 'float32' by default we can set this to 'float16' using tf.keras.backend.set_floatx('float16').In this way we can minimize the precision level in computations wherever required to improve performance.But even with this API if we use dtype='float16' for all layers but after building model the Variables still be stored as 'float32' only.Please refer to attached gist here.But we can however use weights as 'float16' which can improve the model performance by reducing computation time and resources at cost of Accuracy if required.

@SuryanarayanaY thanks!
Could you please include a section comparing the model sizes in your Colab so that size benefits are evident?

@SuryanarayanaY

Policy will be applicable to computations only. As Model weights are Variables they will remain as float32 dtype only which is default.

That's understandable.
But as it might be useful in certain cases (larger model), what if a new arugment is introduced in the saving API, for example: keras.callbacks.ModelCheckpoint(saving_policy='float16', ..)/ model.save(saving_policy='float16)`, etc! cc @rchao  @reedwm


Add Kokkos profiling regions

Codecov Report

Merging #75 (c24213c) into master (071e0fe) will decrease coverage by 0.06%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   94.50%   94.43%   -0.07%
==========================================
  Files          41       41
  Lines        4607     4621      +14
==========================================
+ Hits         4354     4364      +10
- Misses        253      257       +4

Impacted Files
Coverage Δ

src/Picasso_ParticleLevelSet.hpp
0.00% <0.00%> (ø)

src/Picasso_GridOperator.hpp
99.08% <100.00%> (+0.01%)
:arrow_up:

src/Picasso_LevelSet.hpp
97.95% <100.00%> (+0.08%)
:arrow_up:

src/Picasso_MarchingCubes.hpp
99.38% <100.00%> (+<0.01%)
:arrow_up:

src/Picasso_ParticleInit.hpp
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kwitaechong @abisner this is ready for review - any missing regions?

Good catch - added for mesh and facet geometry

HIP failure unrelated


To C2D readme, show how to reuse orders

There's new functionality from provider and ocean.py for reusing orders
It will be helpful to showcase this in the C2D readme.
That's the aim of this issue:) Perhaps put it at the bottom.

Closed in #799


VoiceKit V1: debouncing the arcade button

I'm currently using a VoiceKit V1 on a Pi3B with the latest AIY image.  While working on double-click logic for an assistant script, I noticed that when using
    button = aiy.voicehat.get_button()
    button.on_press(on_button_pressed)

my callback function was quite often being called more often than the button was pressed.  Looking at the time between callbacks, a typical pattern was like this:
pi@raspberrypi:~ $ python3 test_button.py
Callback 0:1540519746.185709 Callback 1:1540519747.6299
Time between (secs.) 1.4441909790039062
------------------------------------------------
Callback  1. Time since previous callback:  1.444 secs.
Callback  2. Time since previous callback:  1.255 secs.
Callback  3. Time since previous callback:  1.259 secs.
Callback  4. Time since previous callback:  1.378 secs.
Callback  5. Time since previous callback:  1.171 secs.
Callback  6. Time since previous callback:  1.250 secs.
Callback  7. Time since previous callback:  0.081 secs. *bounce*
Callback  8. Time since previous callback:  1.065 secs.
Callback  9. Time since previous callback:  0.081 secs. *bounce*
Callback 10. Time since previous callback:  1.091 secs.
Callback 11. Time since previous callback:  0.081 secs. *bounce*
Callback 12. Time since previous callback:  1.072 secs.
Callback 13. Time since previous callback:  0.081 secs. *bounce*
Callback 14. Time since previous callback:  1.135 secs.
Callback 15. Time since previous callback:  0.081 secs. *bounce*
Callback 16. Time since previous callback:  1.180 secs.
Callback 17. Time since previous callback:  1.213 secs.
Callback 18. Time since previous callback:  1.248 secs.
Callback 19. Time since previous callback:  0.081 secs. *bounce*
Callback 20. Time since previous callback:  1.120 secs.

Pressing the button 15 times at 1-1.5 second intervals led to 21 callbacks, 6 of which followed the previous one by about 81 milliseconds.
Clearly my kit came with a very bouncy button, since the debounce_time limit in /aiy/_drivers/_button.py is set to 80 milliseconds.  I don't know how common a problem this is, and I've worked around it by writing my own button driver, since I don't like to modify released code.  If it's at all widespread, one might consider relaxing the default limit in _button.py or adding a keyword parameter to get_button() to allow it to be set from the high-level API.
-jon

Current debounce time in exactly 0.08 seconds: https://github.com/google/aiyprojects-raspbian/blob/93a6306438492464c25916b6b2f53d8e4750579b/src/aiy/_drivers/_button.py#L28
You can change it and see how everything works after.


Does system overview figure (Fig. 3) from paper contains incorrect information?

I'm trying to understand what's going on underneath the hood by reading the methodology section in your paper.
As far as I understood, the LSeg visual encoder maps an image (the embedding of each pixel lies in the CLIP feature space), and the embeddings from the visual encoder are stored in a matrix with the corresponding locations in the grid map. If I understand correctly, this is what happens on the left side of Fig. 3 (VLMap Creation).
When I look at the Localizing Open-Vocabulary Landmarks Section B., it says,
... we apply the pre-trained CLIP text encoder [10] to convert such a list of texts into a list of vector embeddings  [e0,e1,...,eM ], e∈R ...
I found the corresponding function/lines in the repository:
https://github.com/vlmaps/vlmaps/blob/58060f97239074338ab419a2090d43fa752d724d/vlmaps/utils/clip_utils.py#L133
https://github.com/vlmaps/vlmaps/blob/bc79b26a577e5a9408f86e45e5c16530ca80f867/examples/clip_mapping_lseg_from_scratch_batch.py#L50
However, on the right side of Fig. 3 (Landmark Indexing), I see that the Open-Vocabulary Label Set is fed into the LSeg Text Encoder instead of CLIP, and the embedding representations in the figure match with those in Section B:

... we apply the pre-trained CLIP text encoder [10] to convert such a list of texts into a list of vector embeddings  [e0,e1,...,eM ], e∈R ...
I'm a little confused here. Shouldn't the Landmark Indexing section of Figure 3 have the CLIP Text Encoder instead of the LSeg Text Encoder?
Would be much appreciated if you could enlighten me on this issue.
Thank you for your time.

Hi @BashMocha , sorry for the delay of reply.

However, on the right side of Fig. 3 (Landmark Indexing), I see that the Open-Vocabulary Label Set is fed into the LSeg Text Encoder instead of CLIP, and the embedding representations in the figure match with those in Section B:
Actually, LSeg freezes the CLIP text encoder during training. Therefore, the text encoders from LSeg and from CLIP are the same. So you can either use the text encoder from LSeg or use that from CLIP. In our implementation, we choose to use the one from CLIP. Sorry for the confusion here.

Thank you for the explanation. I'm closing the issue now.


Added few more details regarding react error boundary

Checklist

Please note that in case of below checklist not updated accordingly, the maintainers have the right to immediately close your pull request.

[x] You created a branch from dev branch.
[ ] You PR is raised on dev branch and not onmaster.
[ ] Blog follows Blog Guidelines.
[ ] You have read the Contribution Guidelines before creating this PR.
[ ] Checked for any duplicate blog entry.
[ ] Checked for all grammatical errors in the blog.
[ ] You have not published the blog content anywhere else on the internet on platforms like medium, dev.to etc.
[ ] The content is not copy-pasted from anywhere else on the Internet.

Description of change

Commenting as a reminder on this PR