Add support for string collation

This is just an initial pull requests to implement the support for string collation (somewhat similar to what exists in SQL Databases) that address the issue #200. It is just a starting point, I have some doubts that should be addressed.
The collation is supported only on BoltDB for now but the implementation on other storage engine should be easy.
Basic idea
Right now the indexes to search in the database use the hash of the string. In order to support the string collation, before hashing the stream, the string is converted to its comparison key using the used collator. If no collation is specified the storage engine works as before.
Configuration
In order to configure the collation the following options have been added to the configuration file:
collation_type

Type: String
Default: ""

The collation to be used for string comparison by the database. The string should be a valid BCP 47 language tag. If empty no collation is used.
collation_options

Type: List of String
Default: []

A list of option tag to be applied to the selected collation. Valid options are: "IgnoreCase", "IgnoreDiacritics", "IgnoreWidth", "Loose", "Force", "Numeric"
The same options are available on the command line with -collation_type and -collation_options. The later is a comma separated string.
Open questions

Right now every string is collated. A proper implementation should implement a different behavior based on the type of the object as defined by RDF standard (http://www.w3.org/TR/n-quads/#n-quads-language):

IRI should not be collated
string literals should be collated according to the specified language or the default if it is not defined.
string that represents a different datatype should not be collated

I'm not happy with this level of complication because it would complicate the query. A differentiation between IRIs (that should NOT be collated) and string (to be collated) could be interesting even if I think that right now the parser drops the the angular bracket so more work is required.

If the db is opened with a different collation there's no error but the behavior could be unexpected. Probably the collation should be stored in the db and checked open start.

The Collator is now implemented in the graph package but should be probably moved in a different package.

Only one collation is supported right now. Multiple collation support (e.g: specifying it at connection level) could be used but it should be properly designed and I don't see a use case.

It seems the Travis-CI environment doesn't support the packages in golang.org/x path. I'm investigating

Now the Travis-CI works, was a mistake on my side.

@LAlbertalli It took me a bit to pick this up and see where you're going with it.
I think I get what your intent is; however if I'm not mistaken, this makes the entire database follow the collation rules (ie, case insensitivity, et al?)
Now nodes "A" and "a" are the same. See also the other collation options. A person with lastName "Mueller" and one with lastName "Müeller" are not the same. Though they may want to be searched/traversed that way, they are not, canonically, the same, and representing them in the database as the same node is going down a troubling path.
I completely understand why #200 exists and it's a useful ask. In fact, I think it's part of a more general problem/pattern: the textual index.
So yeah, we'd need a new index. Which can leverage the backing store where possible. Where not possible, we'd need to (a) provide one (say in a new Bolt bucket) or (b) claim that this feature is unsupported for some particular backends (which I don't like, but I can't conclusively prove is unavoidable). Many backends would do this for us -- an SQL backend could leverage LIKE for example. For memory/Bolt/LevelDB -- we'd either need to invent one per (using a similar trick to what you've written here, for canonicalization) or use a text-index library (My sketchbook contains a mention to look at bleve )
This would also involve a value-iterator of some form -- all values that match (in the appropriate ways) the value at hand.
On the query level, this would hopefully manifest as
g.V("Mueller")  // (set of exactly one, "Mueller")
g.Find("mueller") // (set of potentially many, case insensitive and whatnot)

I'm sketching it out in this comment, but I also really appreciate your documentation style. If this sounds cool to you (and I'm really happy to help here with some subfeatures) perhaps we start a design issue?

@barakmich yes, issue #200 was opened from a colleague of mine, so I know exactly the issue. And after seeing the Cayley architecture I thought that a full collation support was better than just case insensitive search.
I understand where you came from in your proposal and I like it but let me go a little bit to the core of the problem before discussing the solution. "Straße" and "Strasse" are two different word for an English speaking person but are the same word for a German one. And "Obama" seems a single node but could reference the President of the United States or the First Lady. And maybe "A" and "a" are the same node but "Apple" and "apple" are not (one is the company, the other the fruit). I'm making real examples on which my colleagues are working right now. If we use Cayley for storing an entities graph for text analysis the problem of different word that collates to the same one is just a subset of the disambiguation problem. Our experience on text analysis with regard to the collation (we use Python that doesn't support collation, and MySQL DB which it does) is that the better approach is having your instrument collations aware and manage the ambiguity that arises at the application level were you could apply heuristic specific to your field. Plus it is easier to run collated comparison and then filter the result to be bitwise than the other way around (the possible string to test or search are just huge).
Obviously, if the collations doesn't apply to the data stored (I don't know, a DNA sequence?) the database could be configured without collation.
Adding an index for text search is a compelling idea, I like it and was the first solution I analyzed. But I have discarded it for these reasons:

Increase the code complexity (I assume the idea is to have an index that maps the single collated string to the multiple not collated one. From a certain point of view g.Find("mueller) == g.V("Mueller","Müeller"...) ),
Slow down the find query having to do an additional lookup,
Increase the space required for the database around 10-15% if I estimated it right,

I suspect that few people will mix V and Find in their usual workflow and the find could be easily transformed in a V (the original string is not transformed, only the indexes are collated) while it is not true for the opposite.
Also, my expectation for a Find syntax is something more similar to the SQL LIKE or a regexp than just a collated search. My guess is that a Find feature would be cool but should solve a different set of problems than just being sure that "Mueller" == "Müeller" for the search in the database (that in the end is the meaning of a collation).
But these are obviously my considerations, I'm more than happy to hear the suggestions of other Cayley users.
Bye
L.

I talked this PR over with some friends of mine from the Freebase world. (I do take it very seriously)
While I still think that a textual index would be cool (and worth the growth in size) there's another place you could hook into the Extract, Transform, and Load.... In the Transform, instead of the Load.
Right now we parse quads either strictly or non-strictly, but at the end of the day, these are functions from file to list of quads.
You could get equivalent behavior to this PR, without intentional loss of data or strange indexing, and without an extra index. Essentially, you could imagine functions which take sets of quads, and transform them into other sets of quads. Think  io.Reader wrapped in bufio
Creating a Transform interface (name of your choice) which takes a list of quads and returns a list of quads -- before they get written -- would be kind of nice. In this case, the transform is simple; lowercase/canonicalize the strings (here you could also do appropriate things for RDF types, as you mention). More advanced versions of this could reconcile data, pull related data, deduplicate data... or any number of things.
You could also chain these, which simplifies some of the fanout of options you have.
Indexing progresses as normal.
What do you think?

This makes very much more sense to me. The idea of doing things magical inside the engine was making me a little queazy. I'd be very much happier if transforms happened at this boundary instead.

@kortschak Incidentally, this may ultimately provide a way out of the nquads/cquads weirdness -- as cquads are a relatively simple transform on proper RDF NQuads.

That's true, but nquads are faster to parse because the grammar is more
restrictive. The state graph of cquads is insane.

If I understand the comment, the idea is to define an interface to specify how to transform the data during the loading. This idea is for sure a good one and allow many future extension. But regarding the specific problem I'm trying to address, I see some limitations:

the same transformations should be applied to the data used for querying. I see two possibility:

moving the transformation on the business logic that runs the query, with the side effect of complicating the query process.
having the same transformation applied also to the query, but this will complicate the interface.

Loss of information. If for instance I introduce a canonicalize and a lower case transformation, in the node bucket I will find for instance "new york" instead of "New York" and "Strasse" instead of "Straße" and that would be the data returned to me. Depending on the context this loss of information could be acceptable or not.

I understand the issue over loosing informations in the index but I feel that losing it, also if intentionally, in the overall data is an even bigger concerns (let me know if I have misunderstood the proposal, obviously). I think I should go back to the drawing board to try to address all the concerns. I don't have much time right now but I try to came up with something by the end of the week.

Hey! Did you come up with an alternative?

Hi Barak,
Sorry, my fault. In this moment other priorities has emerged so I hadn't had time to think at this issue.
I think the best move right now is to to close the Pull Requests and I will maintain my separate branch with the collator for my use case.
Bye
L.

@LAlbertalli You can do that, because that's open source, but I don't want to discourage contributions :cry:
If you have other PRs, you can send them, of course. And hopefully with text indexing (or similar) we can reevaluate in the future.

I know and I'm willing to contribute more features. Just in this moment I have to refocus on new features and Cayley with this patch is enough for now, so I can't devote my time to this feature.
I will probably come back on this in few months...
Thanks
L.


How to get the utf-8 character 👾👾 equivalent to a Github emoji automatically?

I would like to know the utf-8 equivalent of :heart: ♥ or :space_invader: 👾.
How to get the utf-8 character equivalent to a Github emoji automatically?
:heart: -> U+2764
:space_invader: -> U+1F47E

Thanks!

Set emoji.replace_mode = 'unified'; and the raw unicode codepoints will be inserted

thanks.


[R-package] Error in xgb.iter.update: Invalid Parameter format for min_split_loss expect float but value='NULL'

Hi,
I've been using xgboost for R.
It had been working perfectly, but now it is giving me the error below when I try to run the same exact code as I was before.
Error in xgb.iter.update(bst$handle, dtrain, i - 1, obj) :
  Invalid Parameter format for min_split_loss expect float but value='NULL'

This happens when I call
model <- xgb.train(data = dtrain, objective = "binary:logistic", eval_metric = "logloss",
        watchlist = watchlist, early.stop.round = 3, nrounds = 2000,
        eta = params$eta, gamma = params$gamma, max_depth = params$max_depth, min_child_weight = params$min_child_weight,
        max_delta_step = params$max_delta_step, subsample = params$subsample, colsample_bytree = params$colsample_bytree,
        lambda = params$lambda, alpha = params$alpha)

where params is a list with the following values:
> params
$eta
[1] 0.01

$max_depth
[1] 30

$min_child_weight
[1] 100

$max_delta_step
[1] 1

$subsample
[1] 0.5

$colsample_bytree
[1] 0.8

$lambda
[1] 0

$alpha
[1] 0

I updated the version of xgboost to 0.4-3 from 0.4-2, and I am assuming that this was the cause.
I tried looking through the code to find where the error message Invalid Parameter was being raised, but I could not find it.
Could you please help me?

Sorry, I found out that params$gamma is NULL.
I wonder why it was working before, but taking gamma = params$gamma out fixed the problem.


please add ajax search on Autocomplete select component

hello .
please add ajax search on Autocomplete select component for find item after search .
Similar component : select2
thanks 👍

@kaungmyatlwin If it is the best idea! so the user has more flexibility and can manipulate and obtain the data in the way that he considers best
if you can do a PR on this it would be great

Sure! I'll look into it
On Wed, Oct 3, 2018, 7:11 PM ldrovira<EMAIL_ADDRESS>wrote:

@kaungmyatlwin https://github.com/kaungmyatlwin If it is the best idea!
so the user has more flexibility and can manipulate and obtain the data in
the way that he considers best
if you can do a PR on this it would be great
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lusaxweb/vuesax/issues/231#issuecomment-426622700,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKp82IUjsNgahlAn3iixCyuBJgpxEyaSks5uhLBfgaJpZM4Wfx6C
.


tools/horizon-cmp: Use Latest-Ledger header

In #1791 we added Latest-Ledger header. We should check it in horizon-cmp and repeat requests later if Latest-Ledger is different in base and test servers. This will decrease the number of false positives.

Closed in #2286.


COG format not recognised?

With QGIS, I can easily add a raster layer with https://pangeo-eosc-minioapi.vm.fedcloud.eu/afouilloux-work/srtm_41_19.tif and it works out of the box. However, it does not seem to work with JupyterGIS.
If I open a QGIS project with such COG, I don't see it on the map and I have the same issue if I try to add such COG as a raster layer in JupyterGIS.
Below is what I see in QGIS:

Thanks for the issue! Do you have an error in the console with that specific file?

I don't have any error in the console. By the way, I checked the content of this file more carefully and it is not a COG but a simple geotiff stored online (which is common with small raster files). I generated the COG for the same image  and I also got the same issue e.g. I don't see anything but a black screen. The validated COG is https://pangeo-eosc-minioapi.vm.fedcloud.eu/afouilloux-work/srtm_41_19_cog.tif

It looks like the tif is loading, just around Strasbourg instead of Cape Town. The huge black square is probably because of how OpenLayers handles nodata values. We should look into making those transparent by default.

So the project is probably using a projection we're not supporting yet?

Yea it looks like the tif is using EPSG:32733, and OpenLayers only supports EPSG:4326 and EPSG:3857 out of the box
Reference

We may want to start looking into using https://github.com/proj4js/proj4js to support other projection types

Actually let's close this issue in favor of #191


Modify transition to partner

Adding some links, and changing focus from product management to agile project management.
Product management will become more relevant but won't replace project management (I propose)
Unless my definition of product mgmt is wrong, of course

@jaysonmc , please review changes and approve (split 1 file into 7 for linking to StrategySummary roadmap)
:smiley:

@remyb2canada Not sure why we're breaking it in sub documents but OK. Could have used the in page links instead.

@gcharest doing some micro-md so that future changes are easier :laughing:

OK but think about how this will render as a website as well ;)
For example, could have used this:

It adds the location URL in the page:

I'm not sure either why we should split the Strategy in different files. Could you share more details on the advantages @remyb2canada ?

@gabrielcossette @gcharest cool, reverted to last commit :)
File is back to one file only


Undefined bar: exemple

Hi, I have a little problem with polybar.
When I try to lancee polybar in the console with the example bar I receive an error message. So I tried to use the more recent version by recompiling and nothing nor done.
OS: Arch Linux x86_64
Shell: zsh 5.5.1
WM: i3
Polybar 3.2.0-12-gfba8722
Features: +alsa +curl +i3 -mpd +network +pulseaudio +xkeyboard
Config path: ~/.config/polybar
Config file: config.txt (the name of file is config not config.txt)
Test performed
> polybar exemple
error: Undefined bar: exemple
> polybar -l info exemple
* Loading config: /home/anthony/.config/polybar/config
error: Undefined bar: exemple
* Waiting for spawned processes to end
* Reached end of application...

is there any way to get more information about what polybar does and why he can't find my bar example?
Thank you in advance and if you need more information

For some reason your config file uses DOS line-endings (CR LF) instead of unix line-endings (LF). Polybar doesn't support that (yet). Please convert the config file to unix line-endings and it will work.

Thanks for your time. Problem fixed


Create multiple translations at once

Not sure if this is an issue, or if I just misunderstand the documentation or if I have some other issue in my implementation. But Im using this lib in a Silex project and trying to do a Category entity with translation. It works some... But when I try to do like the following example from the readme.md file:
$category = new Category;
$category->translate('fr')->setName('Chaussures');
$category->translate('en')->setName('Shoes');
$em->persist($category);

// In order to persist new translations, call mergeNewTranslations method, before flush
$category->mergeNewTranslations();

$category->translate('en')->getName();

Only the last one is created, in this case "en". If I do $category->translate('fr'), then "en", then "sv" only "sv" is created.
Do you have to persist, merge and flush in between each call to $category->translate('x')? Or do I have some error in my implementation?

Sorry about this. It seems it was my implementation. :)
After your reply I did some remaking. Im implementing this in a Silex project and was using simple annotation mode in Doctrine to start with. I've changed that. Unfortunately I've changed some more things so Im not sure exactly what was the cause.
But we can close this now knowing it isn't you. :)

How you did the integration with Silex?
Thanks!


dart2native is obsolete

https://dart.dev/tools/dart-compile
Instead of dart2native the following command should be used:
   mkdir -p dart/bin && dart compile exe dart/benchmark.dart -o dart/bin/benchmark

If you wish you can send a PR. I'll try to review asap.


Bottom Practice Button

Please extensively review my change. I like the idea of a practice button at the bottom. It saves time and it is a lot cleaner. Although I have very limited experience with haskell, I have created a pull request with a possible creation. I would appreciate any feedback and/or constructive criticism. Thank you.

Thank you! The Haskell code looks good, I will build locally and test the website to see if the css appears okay as well.
I just happened to push a lot of changes (related to auth), so there are a few merge conflits (these "<<<<<<< HEAD" and "=======" snippets if you go to the "Files changed tab"). Could you try resolving them? I can help if needed.
I think it should suffice for you to run to add my repostory as a remote on your repo (by running: git remote add jqueiroz "https://github.com/jqueiroz/lojban.io"), then merge with my changes (by running: git merge jqueiroz/master), then resolve conflits (by manually editing files, then running "git add ." and "git merge --continue"), then pushing your changes again ("git push").


TransferUtility get URL

I have been looking through the sample and available docs but I can't seem to find how you can get the URL of the file after uploading it to the S3 bucket.
Use case:
I want to upload a file/pdf to S3 (and make it public)
After that I want to get the public url of the file on S3 so I can share it

@Glennmen Thank you for reporting to us. The TransferUtility#upload method uses the PutObjectRequest to perform an upload. It doesn't return an URL. However, you can generate a pre-signed URL using our SDK which you can then share it until the URL is expired.
See https://github.com/aws/aws-sdk-android/blob/1d492dc7d8ad37a14596ddc337ba1a0733ec1182/aws-android-sdk-s3/src/main/java/com/amazonaws/services/s3/AmazonS3Client.java#L3192 for details.

@kvasukib Thanks for your reply, so if I understand correctly (I haven't found any clear docs about all the SDK functions), first use TransferUtility#upload to upload the file to S3 and then use the generatePresignedUrl() function to generate a pre-signed URL.
Will have to experiment with it once I start implementing it into the app, not sure if we are going to at this point. I saw it as a possible feature in our next meeting topic and decided to do some research first.

If you want to make the file public, you might want to consider 1 of the two options:

Make the file accessible to everyone who has AWS Credentials

or

Make the file accessible to everyone without any credentials (For this case, you will have to use some API to update ACL on the file)

Thanks,
Rohan


cluster-autoscaler doesn't scale up when Pods are Pending due to space exhaustion

Describe the issue
I logged this as an issue, not a bug because it looks more like a potential new feature. The issue I am facing if pods get into the Pending state because there is no more space left for them on any node for a lvm, the pods get stuck there and the cluster-autoscaler, https://github.com/kubernetes/autoscaler doesn't kick in to add a node.
Environments

Version: Any
OS: Any

To Reproduce
Steps to reproduce the behavior:

Create pods with PVCs until storage is exhausted on all nodes
Observe pending pods.

Expected behavior
cluster-autoscaler detects the condition and adds nodes.
Additional context
I think this happens because cluster-autoscaler is running a scheduler simulation to see if it needs to add pods. Since topolvm-scheduler is a scheduler extender, it won't be a part of the simulation cluster-autoscaler runs..

Because storage capacity gets published by a running CSI driver and the cluster autoscaler needs information about a node that hasn't been created yet, it will currently not scale up a cluster for pods that need volumes. Seems like there is an idea  how to provide that information which is WIP


[SPARK-7078] [SPARK-7079] [WIP] Binary processing sort for Spark SQL

This is a WIP commit towards implementing a binary processing cache aware external record sort for use in Spark SQL.  The code here is modeled after an early design of #5868, which supported pluggable functions for comparing key prefixes and comparing serialized records.
I'll update this PR with a detailed design description later, similar to the detailed descriptions and comments posted at #5868; I'm only opening this now so that I can run some things through Jenkins and track some code review comments.
This is blocked on merging #7176.
This will address the following JIRAs (not putting the links in the title yet because I don't want to send an email blast): [SPARK-7078] [SPARK-7079].
TODOS:

[ ] Spill cleanup tests
[ ] Refactoring of string prefix code, plus more tests.
[ ] Comments + real PR description.

Merged build triggered.

Merged build started.

Test build #33615 has started for   PR 6444 at commit 2c6a389.

Test build #33615 has finished for   PR 6444 at commit 2c6a389.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33615/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #33624 has started for   PR 6444 at commit 6261ded.

Test build #33624 has finished for   PR 6444 at commit 6261ded.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33624/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #34166 has started for   PR 6444 at commit cc59ddd.

Test build #34166 has finished for   PR 6444 at commit cc59ddd.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34333 has started for   PR 6444 at commit aeed5eb.

Test build #34333 has finished for   PR 6444 at commit aeed5eb.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34334 has started for   PR 6444 at commit 4dbd4ce.

Test build #34334 has finished for   PR 6444 at commit 4dbd4ce.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34723 has started for   PR 6444 at commit c13b7ea.

Test build #34723 has finished for   PR 6444 at commit c13b7ea.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34857 has started for   PR 6444 at commit c125027.

Test build #34857 has finished for   PR 6444 at commit c125027.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35152 has started for   PR 6444 at commit 07d3c04.

Test build #35152 has finished for   PR 6444 at commit 07d3c04.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35182 has started for   PR 6444 at commit 5c64837.

Merged build triggered.

Merged build started.

Test build #35187 has started for   PR 6444 at commit 6663172.

Test build #35182 has finished for   PR 6444 at commit 5c64837.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35198 has started for   PR 6444 at commit 5140be0.

Test build #35187 has finished for   PR 6444 at commit 6663172.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #35198 has finished for   PR 6444 at commit 5140be0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35476 has started for   PR 6444 at commit 526a1bb.

Test build #35476 has finished for   PR 6444 at commit 526a1bb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

@zsxwing, there's still a lot that I have to implement here, but if you have a chance could you review the pieces that are here now? Most of this code is substantially similar to the earlier Tungsten shuffle sorter patch that you reviewed, so hopefully most of it is easy to follow and looks okay. There's a Reviewable link in the pull request description if you prefer to use that to manage the long review.

Merged build triggered.

Merged build started.

Test build #35926 has started for   PR 6444 at commit c74851b.

Test build #35926 has finished for   PR 6444 at commit c74851b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

I'm in the process of updating this to reflect @davies' recent changes to support arbitrary column types in UnsafeRow.  One bit of trickiness is the fact that UnsafeExternalSorter, which manages the spilling, doesn't know anything about SQL and thus can't directly implement the logic for spilling and reading ObjectPools back during the merge.  In the worst case, I guess that the merging step might need to keep a bunch of ObjectPools in memory at the same time, which could end up causing us to OOM, but in those cases we would have OOM'd before, too.

In order to address the object spilling case, I'm going to need to write a failing test case first.  In order to do this, I'm going to have to borrow some of the manual spill triggering test interfaces that I added for UnsafeShuffle so that I can write deterministic unit tests which hit the spill paths with small inputs.

@JoshRosen Maybe we could leave supporting object in another PR (having a white list of supported types).

Merged build triggered.

Merged build started.

Test build #36202 has started for   PR 6444 at commit 91c44fc.

What's the defined sort ordering if the sorting column is nullable?  Do the null values appear first?  Last?

Test build #36202 has finished for   PR 6444 at commit 91c44fc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36309 has started for   PR 6444 at commit 6752611.

Test build #36309 has finished for   PR 6444 at commit 6752611.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #36357 has started for   PR 6444 at commit 1b54894.

Test build #36357 has finished for   PR 6444 at commit 1b54894.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36361 has started for   PR 6444 at commit 95dac39.

Merged build triggered.

Merged build started.

Test build #36367 has started for   PR 6444 at commit 6e45926.

Test build #36367 has finished for   PR 6444 at commit 6e45926.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36369 has started for   PR 6444 at commit 6667749.

Test build #36369 has finished for   PR 6444 at commit 6667749.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36372 has started for   PR 6444 at commit 08afc60.

Test build #36361 has finished for   PR 6444 at commit 95dac39.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #36372 has finished for   PR 6444 at commit 08afc60.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36451 has started for   PR 6444 at commit 2fafb31.

Test build #36451 has finished for   PR 6444 at commit 2fafb31.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

There may be a corner-case when encoding NaN values with different bitpatterns into UnsafeRow, since these NaNs won't be identical (see comment at https://github.com/apache/spark/pull/7176#discussion_r33807115). This is not a big deal yet, since we currently don't have defined semantics for sorting on columns containing NaN, but we should remember to investigate this if we try to fix NaN sorting.

Merged build triggered.

Merged build started.

Test build #36591 has started for   PR 6444 at commit a4a7aab.

Merged build triggered.

Merged build started.

Test build #36592 has started for   PR 6444 at commit 5822e6f.

Test build #36591 has finished for   PR 6444 at commit a4a7aab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #36592 has finished for   PR 6444 at commit 5822e6f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #36615 has started for   PR 6444 at commit 9969c14.

Merged build triggered.

Merged build started.

Test build #36619 has started for   PR 6444 at commit 7c3c864.

Test build #36615 has finished for   PR 6444 at commit 9969c14.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36632 has started for   PR 6444 at commit 88b72db.

Test build #36619 has finished for   PR 6444 at commit 7c3c864.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #36632 has finished for   PR 6444 at commit 88b72db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #36645 has started for   PR 6444 at commit 8d7fbe7.

Merged build triggered.

Merged build started.

Test build #36647 has started for   PR 6444 at commit 87b6ed9.

Test build #36645 has finished for   PR 6444 at commit 8d7fbe7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #36647 has finished for   PR 6444 at commit 87b6ed9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #36659 has started for   PR 6444 at commit 1d7ffaa.

Test build #36659 has finished for   PR 6444 at commit 1d7ffaa.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36665 has started for   PR 6444 at commit 88aff18.

Test build #36665 has finished for   PR 6444 at commit 88aff18.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36736 has started for   PR 6444 at commit f99a612.

Test build #36736 has finished for   PR 6444 at commit f99a612.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36737 has started for   PR 6444 at commit 293f109.

Test build #36737 has finished for   PR 6444 at commit 293f109.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36762 has started for   PR 6444 at commit 845bea3.

Test build #36762 has finished for   PR 6444 at commit 845bea3.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36771 has started for   PR 6444 at commit d13ac55.

Test build #36771 has finished for   PR 6444 at commit d13ac55.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36916 has started for   PR 6444 at commit 3947fc1.

Test build #36916 has finished for   PR 6444 at commit 3947fc1.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36917 has started for   PR 6444 at commit cd05866.

Test build #36917 has finished for   PR 6444 at commit cd05866.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #36992 has started for   PR 6444 at commit 2f48777.

Merged build triggered.

Merged build started.

Test build #36998 has started for   PR 6444 at commit 5135200.

In the process of writing a real PR description so please don't merge prematurely

Test build #36992 has finished for   PR 6444 at commit 2f48777.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM

Test build #36998 has finished for   PR 6444 at commit 5135200.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #37015 has started for   PR 6444 at commit 5135200.

@davies, there's one minor change in SparkPlanTest that I want to partially undo: the sorting prior to output comparison should continue to be opt-out, not opt-in, since you want sorting most of the time.   Let me push another commit for this real quick.

Merged build triggered.

Merged build started.

Test build #37018 has started for   PR 6444 at commit 35dad9f.

Test build #37018 has finished for   PR 6444 at commit 35dad9f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #37015 has finished for   PR 6444 at commit 5135200.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Jenkins retest this please

Merged build triggered.

Merged build started.

Test build #37045 has started for   PR 6444 at commit 35dad9f.

Test build #37045 has finished for   PR 6444 at commit 35dad9f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

This is failing tests because my change to SparkPlanTest introduced multiple overloaded methods with default arguments, which isn't legal in Scala.  Let me see if I can find a clean way to fix this.

I hacked around the default args. issue by removing many overloaded methods in SparkPlanTest.  Please take a look.

Merged build triggered.

Merged build started.

Test build #37051 has started for   PR 6444 at commit 6beb467.

Test build #37051 has finished for   PR 6444 at commit 6beb467.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #1041 has started for   PR 6444 at commit 6beb467.

LGTM, The last failure is caused by an known flaky test, I think this one is good to go.

Test build #1041 has finished for   PR 6444 at commit 6beb467.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Thanks - I'm going to merge this and review more next week. We can address feedbacks incrementally for this one.

Looks like this was merged but GitHub didn't auto-close.


chore: remove python and wasm_python executors

As a part of the work required to land https://github.com/bacalhau-project/bacalhau/issues/2351 this PR removes the JobSpecLanguage, its executor, and the wasm_python executor. https://github.com/bacalhau-project/bacalhau/pull/2381 follows this (is based on) with the rest of the changes for #2351

@lukemarsden I will await an approval from you before enabling auto-merge.

Go ahead!
On Wed, 19 Apr 2023, 23:21 Frrist, @.***> wrote:

@lukemarsden https://github.com/lukemarsden I will await an approval
from you before enabling auto-merge.
—
Reply to this email directly, view it on GitHub
https://github.com/bacalhau-project/bacalhau/pull/2373#issuecomment-1515456708,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACATUQAUZDIJ3JR2V4TIA3XCBQQNANCNFSM6AAAAAAXB3OD74
.
You are receiving this because you were mentioned.Message ID:
@.***>


Loop control and playback direction

Control number of iterations in a loop and playback direction

Added play direction in 472748a4167c0f1b08160faea84d44541d5823e3
Loop toggle is already implemented.
Number of iterations might be related to playing a range and/or playing frames in a random order, which maybe can be solved with finite state machines, signals.

Random frame order is implemented in 9fd5df6631e3c85d5f09573ba1b72a1e78a88867 (and the docs updated in 3f88c5e36c590f607c94a7aac5f8c0fc12415a0e).

Closing this issue as playback direction has been implemented, and a new issue (#37) has been opened to discuss related topics.


[Typo] Change signifikant -> significant in problem matcher

Hello there, I was looking at adding support for the problem matcher object format to Danger and spotted a typo inside the source.

Thanks @orta
Actually the property isn't used at all in the code besides test. So instead of renaming it I removed it.

👍


Set ‘Use Legacy Swift Language Version’ flag to YES

I opened the Swift Legacy flag and fixed a optional syntax error.
It can be build on Xcode 8.2 now with Swift 2.3 .

Swift 2.3 is no longer supported in Xcode 8.3 and above.

So, when will the iOS RN version support Gitlab login?

On 13 Apr 2017, at 11:07 AM, Preston Ursini<EMAIL_ADDRESS>wrote:
Swift 2.3 is no longer supported in Xcode 8.3 and above.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/mattermost/ios/pull/51#issuecomment-293766016, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_S-u878nDIjkgBXFY8b_g2TK0tqB9Lks5rvZFtgaJpZM4LltIq.

I've ported this project to work with Swift 3 / Xcode 8.3.1 and have posted the following pull request.
https://github.com/mattermost/ios/pull/55
This pull request should no longer be necessary.


[example] update add-ssl example

Use builtin HTTPS functionality instead of a customization.
/cc @3scale/documentation

@4integration do you have any feedback on this?

I have looked at the configuration and it is the same as I have but I am using docker-compose and .env file.
But noticed that the image is different.
I have used:
registry.access.redhat.com/3scale-amp22/apicast-gateway:1.8
and could not get HTTPS to work so tested with the same as you
quay.io/3scale/apicast:master
That makes the HTTPS listener going and responding but getting
C:\>curl -v https://gwdomain.com:8443/_threescale/healthz
*   Trying <IP_ADDRESS>...
* Connected to gw.domain.com (<IP_ADDRESS>) port 8443 (#0)
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: C:\Apps\curl-7.46.0-win64\bin\curl-ca-bundle.crt
  CApath: none
* TLSv1.2 (OUT), TLS header, Certificate Status (22):
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS header, Unknown (21):
* TLSv1.2 (IN), TLS alert, Server hello (2):
* error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error
* Closing connection 0
curl: (35) error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error

@4integration registry.access.redhat.com/3scale-amp22/apicast-gateway:1.8 image corresponds to the v3.2.0 of the APIcast upstream.
These new APICAST_HTTPS_* environment variables appeared after the release, and currently are not available in the productized APIcast image (only in the latest upstream – quay.io/3scale/apicast:master).
See the entry ENV variables to make APIcast listen on HTTPS port in the CHANGELOG.
For registry.access.redhat.com/3scale-amp22/apicast-gateway:1.8 the old approach still needs to be used.

@4integration the example shows the curl call with --cacert param to expect the self signed certificate.

@mayorova thanks a lot for the clarification.
Since it didn't work just to pick the latest image
registry.access.redhat.com/3scale-amp22/apicast-gateway:1.8
but now I got it working :)
The only things I have changed are:

Changed volume mount point for certs
Using absolute path for certs

So 1-2 of these caused the issue, now solved.


Timezone handling buggy since 4.1.3/4.2.1

Issue Summary
https://github.com/wagtail/wagtail/pull/9628#issuecomment-1450070061
Unfortunately, my fix from #9628 breaks something...
If you set your admin user's timezone to something differing from the default timezone, and then open the schedule-publication-dialog for a page, the set date will change with every save-request... edit: since the date fields are part of the form, every save just changes the dates in the form
I'm quite sure it has something to do with the deferred rendering of TemplateResponses (see django docs).
In case of TemplateResponses, the set timezone is reset to the old value before the template is rendered...
I think we have to combine it with the similar handling for the current language here:
https://github.com/wagtail/wagtail/blob/fdc36a69891a92db6dca32703cddec1d573c193f/wagtail/admin/auth.py#L182-L207
I really don't know, why I have missed that language handling and the comments about the deferred rendering, sorry... :disappointed:
Unfortunately I'm not able to make a PR before monday. The fix should be not that hard, it probably duplicates some of the language related code. As a quick, temporary alternative, you could of course revert the commits (which will probably break the tests, that have been fixed with #9628):

https://github.com/wagtail/wagtail/commit/f05cbb2f0e62dc3a1f40f91da5a569175924e54e
https://github.com/wagtail/wagtail/commit/b745dfd0dcf76c90e7c1603147865ed6586a64e4

Steps to Reproduce

In your new virtualenv: pip install wagtail && wagtail start mysite && cd mysite && pip install -r requirements.txt && ./manage.py makemigrations && ./manage.py migrate && ./manage.py createsuperuser && ./manage.py runserver
Login to the CMS
Go to the account settings, and at least change the timezone to something other than UTC (the default timezone)
Add a new page (http://<IP_ADDRESS>:8000/admin/pages/add/home/homepage/3/) and save it as a draft.
Set a schedule by using the side panel and configure a date in the future.
Open the schedule overlay again, the time should be different to the one you have used previously. You can repeat step 5 and 6 again and again, it will change the date everytime. You don't even have to use the overlay, since the date fields are part of the form, you can just save the draft.

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Python version: 3.11
Django version: 3.2, 4.1.7
Wagtail version: 4.1.3, 4.2.1
Browser version: Firefox 111

It feels like the if hasattr(response, "render"): should probably be outside, e.g.
with override_tz(time_zone), LogContext(user=user):
    if preferred_language:
        with override(preferred_language):
            response = view_func(request, *args, **kwargs)
    else:
        response = view_func(request, *args, **kwargs)

    if hasattr(response, "render"):
        render = response.render

        def overridden_render(response):
            with override_tz(time_zone):
                if preferred_language:
                    with override(preferred_language):
                        return render()
                return render()

        response.render = types.MethodType(
            overridden_render, response
        )
    return response

Nice, that's even better! 👍

While reviewing this issue, I found other places where we override the locale to use the user's preferred language, but not the timezone:

Emails: https://github.com/wagtail/wagtail/blob/8705124eaff349f4a2160a514ed9fba40034f5a0/wagtail/admin/mail.py#L267-L269
Userbar: https://github.com/wagtail/wagtail/blob/8705124eaff349f4a2160a514ed9fba40034f5a0/wagtail/admin/templatetags/wagtailuserbar.py#L58
On saving the account form: https://github.com/wagtail/wagtail/blob/8705124eaff349f4a2160a514ed9fba40034f5a0/wagtail/admin/views/account.py#L266-L269

I think we should also do the same for all of them, especially emails. I think userbar and account form are not relevant for vanilla Wagtail projects, but there may be other projects where they define a custom userbar item or a custom account settings template with datetimes.
It's out of scope for this issue though, considering that it has always been the behaviour and not a regression.


Material Icons Don't Work on Samsung Galaxy SIII

Material Icons don't work on galaxy sIII, NoteII, Note III.
On samsung S4, and Iphone It works well but It does not work on these.
screen :
http://imageshack.com/a/img909/740/fc12Qo.png

I'm assuming your galaxy sIII, NoteII, Note III and running an android version below 4.4, in which case this would be a duplicate of: https://github.com/Dogfalo/materialize/issues/1802


FormSection: add 'absolute' parameter

This is a possible solution for #2852

Codecov Report

Merging #2985 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2985   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          67      67
  Lines        1395    1395
======================================
  Hits         1395    1395

Impacted Files
Coverage Δ

src/FormSection.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0343d39...b7e0233. Read the comment docs.

Closing this after discussion on #2852 lead to #2996.


As a user, I want to create a podcast, so that I can be discoverable and add episode to the podcast.

Acceptance Criteria:

[ ] The user should be able to create a new podcast with relevant details, such as the podcast name, description, and category.
[ ] Upon creating a podcast, the user should receive a unique identifier or URL for the podcast to enhance discoverability.
[ ] The user should have the ability to add and publish episodes to the created podcast with appropriate metadata, including episode title, description, and audio file upload.

Demo Steps:

Navigate to the "Create Podcast" section within the user profile settings.
Fill out the necessary details for the new podcast, including the podcast name, description, and category.
Upon successful creation, retrieve the unique podcast identifier or URL from the system.
User will now have an option to add episodes to a podcast.

Potential Risks:

Inadequate validation of podcast details leading to inconsistencies in the podcast directory.
Technical issues with audio file uploads resulting in episode publication errors.
Insufficient user guidance or documentation leading to confusion during the podcast creation process.
Overloading the podcast hosting system due to a high volume of simultaneous podcast and episode creations.

Additional notes:
This story is loosely tied to #110 , an episode is ADDED to a podcast.

Duplicate story


WIP: Working SAML auth in VM against a test endpoint

This PR allows SAML authentication in Carto. Configured via a new saml_authentication property in app_config.yml. Generally, if configured, SAML authentication takes precedence over other methods.
These are the basics required for a specific client and works with their SAML authentication scheme. Additional TODOs are noted below, some of which are not necessary for the client, but should be strongly considered now that this feature is moving out of a Carto fork.
Instructions to setup a development environment to test this were provided to @javisantana via the #cartodb-azavea slack channel.
Additional TODOs:

Autocreate users if the user doesn't exist yet in
cartodb on login. Should be quite straightforward to do
this in the same way as for http_header_authentication.
Come up with a way to test this code in isolation
Clean up a bit so that SAML is more compatible with
other auth providers
Come up with a more extensible way to convert the SAML
name_id to a username/subdomain
Handle subdomainless urls
Implement SAML logout. This was not part of the original feature
request for us. But should be relatively straightforward:
https://github.com/onelogin/ruby-saml#single-log-out

I'll be working on the testing and merge here: CartoDB/cartodb/pull/11047 .

Hi, @CloudNiner . I'm testing this and I have a first question. Disclaimer: I haven't used SAML before, so it will probably be easy or dumb :_).
I'm testing this with Salesforce SAML. After setting everything until authentication response worked, authentication fails because name_id is empty. Code:
=> 190:     return nil unless saml_response.attributes['name_id'].present?

Salesforce returns these attributes:
@attributes={"userId"=>["0050Y000000NjP5"]<EMAIL_ADDRESS><EMAIL_ADDRESS>"is_portal_user"=>["false"]}

You said that "Come up with a more extensible way to convert the SAML
name_id to a username/subdomain".  Would a "name_attribute" configuration parameter that defaults to name_id but that can be set to username in my case makes sense to you?
Thanks!

No problem, happy to help.
We just expect that some field in the SAML response identifies a unique ID for a user. Adding a configuration parameter for that field to the saml_authentication section in app_config.yml makes sense, as you suggested. We just used name_id because it was the field our SAML endpoint was using.
The comment regarding "Come up with a more extensible way to convert the SAML
name_id to a username/subdomain" was more focused around this bit, which transforms the email in name_id to a Carto username (link):
=> 192:    subdomain = CartoDB.email_to_subdomain(saml_response.attributes['name_id'])

Our email_to_subdomain method was a bit more specific than the one here, I just tried to make it as generic as possible, but I'm sure I missed some cases. If the unique ID that the SAML endpoint returns isn't an email, you could just use that for the username instead of munging the email. This might be something else that can be sensibly configured in app_config.yml.

@CloudNiner thanks! I'll probably add the name_id configuration to the first merge, and approach the transformation and other TODOs afterwards.


UTF-8 Issue

Hello friends I'm testing the cms
I found that It doesn't support unicode utf-8 until I manuali added it in index
""
it would be a good if you add this option from admin panel
After I added it works, now I can write in Georgian Language without any problem

Thanks for your report. I'll add it on the next update.

this issue was fixed.


Revert "Bump actions/checkout from 3 to 4"

Reverts John2KKK/skills-communicate-using-markdown#1

[ ] Turn on GitHub Pages
[ ] Outline my portfolio
[ ] Introduce myself to the world


Docs: similarity search

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Closes #(issue_number)
Type of change
Please delete options that are not relevant.

[x] Documentation update

How Has This Been Tested
Checklist

[ ] I have merged the original branch into my forked branch
[ ] I added relevant documentation
[ ] follows the style guidelines of this project
[ ] I did a self-review of my code
[ ] I added comments to my code
[ ] I made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works

Only thing left to this PR after the code review is to include a few screenshots in the UI section and we can merge this. Could you include them @davidberenstein1957 ?


Building master fails on osx 10.12.1

clang: error: no such file or directory: '1'
/Applications/Xcode.app/Contents/Developer/usr/bin/make  all-am
depbase=echo source/Arguments.o | sed 's|[^/]*$|.deps/&|;s|\.o$||';
/usr/bin/clang++ -DHAVE_CONFIG_H -I.  1 -std=c++0x -I../libpit/Source   -g -O2 -MT source/Arguments.o -MD -MP -MF $depbase.Tpo -c -o source/Arguments.o source/Arguments.cpp &&
mv -f $depbase.Tpo $depbase.Po
clang: error: no such file or directory: '1'
make[1]: *** [source/Arguments.o] Error 1
make: *** [all] Error 2

I'm going to close this for now macOS has been my primary OS for years and I've regularly built Heimdall without issue, including on 10.12.x.
I'm not sure what's going on with all the references to '1', however I'm guessing it was an issue with your particular setup. If you've followed the README exactly and this is an on-going problem, then please provide some more information about the steps you've followed, relevant software versions etc.


proxy import

First of all, this is the most valuable program on the market in my eyes.
my question is how to import my own proxy list

/files/proxies/your_proxy.txt
You can specify the name of the list in the command line to start your attack


API: improve api.sh and update api

First commit modifies api.sh so that the image builder api.yaml file is downloaded with curl, this way we don't have to manually download it anymore.
Second commit updates api via npm run api.

/retest

Ah... there is a bit of an issue now, that npm run api is run in the CI to verify the API was not tempered with manually, which means that anytime the backend updates api spce, all fronted PR checks fail :)
I'll propose a split of the actions to npm run api:update that would download and regen and npm run api that would only regen :)
Tomorrow tho, I'm just stopping by today xD

Ah... there is a bit of an issue now, that npm run api is run in the CI to verify the API was not tempered with manually, which means that anytime the backend updates api spce, all fronted PR checks fail :)
I'll propose a split of the actions to npm run api:update that would download and regen and npm run api that would only regen :) Tomorrow tho 😛

Oof :dizzy_face: great catch! Splitting the actions into two steps sounds great. :+1:

Splitting the actions into two steps sounds great. 👍

Here we go: https://github.com/RedHatInsights/image-builder-frontend/pull/1585 :)


Use explicit symmetric key

A symmetric key needs to be passed into BindingBuilder.getEncryptedKeyBuilder() so that the encoded contents of that key can be used in a generated key afterwards in both AsymmetricBindingBuilder and SymmetricBindingBuilder

I reviewed the pull request and this code looks good, thanks for figuring out the mistakes and changing the method signature of getEncryptedKeyBuilder() as that makes sense to me.


[improvement](create tablet) backend create tablet round robin among disks

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.69 seconds
stream load tsv:          537 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size:<PHONE_NUMBER>6 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.63 seconds
stream load tsv:          539 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          66 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size:<PHONE_NUMBER>0 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.34 seconds
stream load tsv:          540 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          66 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size:<PHONE_NUMBER>0 Bytes

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.82 seconds
stream load tsv:          532 seconds loaded<PHONE_NUMBER>9 Bytes, about 134 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>6 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.51 seconds
stream load tsv:          547 seconds loaded<PHONE_NUMBER>9 Bytes, about 130 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select:          29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size:<PHONE_NUMBER>6 Bytes

run buildall

run buildall

run buildall


Crash at the beginning sometimes

Hi, i'm using this framework on my app and was working without problem but with the last Xcode upgrade, SlideMenuControllerSwift makes my app to crash before anything show. I thought I solved it by reinstalling but keeps make my app to crash sometimes. It's awnfull and I don't feel like i'm able to solve it without any help.
This is the error (console log):
dyld: Library not loaded: @rpath/SlideMenuControllerSwift.framework/SlideMenuControllerSwift
  Referenced from: /Users/informatica/Library/Developer/CoreSimulator/Devices/54140521-7CA1-458D-AC7F-8DD4CD43CBDA/data/Containers/Bundle/Application/B45458DB-EDBE-462D-9A98-A8B5CC457A7F/gowizyu.app/gowizyu
  Reason: no suitable image found.  Did find:
	/Users/informatica/Library/Developer/CoreSimulator/Devices/54140521-7CA1-458D-AC7F-8DD4CD43CBDA/data/Containers/Bundle/Application/B45458DB-EDBE-462D-9A98-A8B5CC457A7F/gowizyu.app/Frameworks/SlideMenuControllerSwift.framework/SlideMenuControllerSwift: required code signature missing for '/Users/informatica/Library/Developer/CoreSimulator/Devices/54140521-7CA1-458D-AC7F-8DD4CD43CBDA/data/Containers/Bundle/Application/B45458DB-EDBE-462D-9A98-A8B5CC457A7F/gowizyu.app/Frameworks/SlideMenuControllerSwift.framework/SlideMenuControllerSwift'

	/Users/informatica/Library/Developer/CoreSimulator/Devices/54140521-7CA1-458D-AC7F-8DD4CD43CBDA/data/Containers/Bundle/Application/B45458DB-EDBE-462D-9A98-A8B5CC457A7F/gowizyu.app/Frameworks/SlideMenuControllerSwift.framework/SlideMenuControllerSwift: required code signature missing for '/Users/informatica/Library/Developer/CoreSimulator/Devices/54140521-7CA1-458D-AC7F-8DD4CD43CBDA/data/Containers/Bundle/Application/B45458DB-EDBE-462D-9A98-A8B5CC457A7F/gowizyu.app/Frameworks/SlideMenuControllerSwift.framework/SlideMenuControllerSwift'

	/Users/informatica/Library/Developer/CoreSimulator/Devices/54140521-7CA1-458D-AC7F-8DD4CD43CBDA/data/Containers/Bundle/Application/B45458DB-EDBE-462D-9A98-A8B5CC457A7F/gowizyu.app/Frameworks/SlideMenuControllerSwift.framework/SlideMenuControllerSwift: required code signature missing for '/Users/informatica/Library/Developer/CoreSimulator/Devices/54140521-7CA1-458D-AC7F-8DD4CD43CBDA/data/Containers/Bundle/Application/B45458DB-EDBE-462D-9A98-A8B5CC457A7F/gowizyu.app/Frameworks/SlideMenuControllerSwift.framework/SlideMenuControllerSwift'

(lldb)

This is the pod:
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, "10.0"

use_frameworks!

target 'gowizyu' do
  # Comment this line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!

  # Pods for gowizyu
    pod 'SwiftValidator', :git => 'https://github.com/jpotts18/SwiftValidator.git', :branch => 'swift3-dave'
    pod 'SlideMenuControllerSwift'
    pod 'KRProgressHUD', '~> 1.6'
    pod 'Alamofire', '~> 4.0'
    pod 'SwiftyJSON'
    pod 'Google/CloudMessaging'
end

And this is where it crash ( Thread 1: EXC_BREAKPOINT (code=EXC_1386_BPT, subcode=0x0) ):
dyld_sim`dyld_fatal_error:
    0x10d9fb000 <+0>: int3
->  0x10d9fb001 <+1>: nop

I am also having the same issue. It only happens in Xcode 8.

Here is what I did resolve the issue.
Find the SlideMenuControllerSwift.framework in your project folder/pods folder in xCode.
Inside the framework you will find _CodeSignature folder. I had around 5 files in that _CodeSignature folder. Delete all except Code Resources file.
Clean build project and run.

In xcode 8 pls. don't use via pod.

Reinstall. It worked for me.

@patiljignesh  using by pod or manually, because m trying multiple time via pod but same error getting.

Using pod. Make sure to uninstall. Close Xcode before doing this.
Sent from my iPhone

On 23 Nov 2016, at 06:13, rs10693<EMAIL_ADDRESS>wrote:
@patiljignesh using by pod or manually, because m trying multiple time via pod but same error getting.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


5776 close position

revamped portfolio positions. fix ability to cancel orders and close positions. Still need to fix formatting between the interaction of Positions and Orders in portfolio page. need more testing of different markets and orderbook.
fixed up mobile layout for newly vamped Portfolio Positions page.

A few failing tests — it looks like they might be due to some changes coming down the pipes in the follow-on task, so if so, feel free to comment out temporarily.


Make DocumentArray compatible with FastAPI

Context
Atm FastAPI is working with BaseDocument. But we need to make it work for DocumentArray.
this is currently working
    class Mmdoc(BaseDocument):
        img: ImageDoc
        text: TextDoc
        title: str

    input_doc = Mmdoc(
        img=ImageDoc(tensor=np.zeros((3, 224, 224))), text=TextDoc(), title='hello'
    )

    app = FastAPI()

    @app.post("/doc/", response_model=Mmdoc, response_class=DocumentResponse)
    async def create_item(doc: Mmdoc):
        return doc

but we need to extend it to
    class Mmdoc(BaseDocument):
        img: ImageDoc
        text: TextDoc
        title: str

    da = DocumentArray[Mmdoc]([Mmdoc(
        img=ImageDoc(tensor=np.zeros((3, 224, 224))), text=TextDoc(), title='hello'
    )])

    app = FastAPI()

    @app.post("/doc/", response_model=DocumentArray[Mmdoc], response_class=DocumentArrayResponse)
    async def create_item(da: DocumentArray[Mmdoc]):
        return doc

We decided to postpone this ticket to first handle other "release committed" tickets and to take some time to come up with a clear way of making DocumentArray compatible with FastAPI

Both of the following options turned out to be complicated:

Make DocumentArray extend Pydantic BaseModel
See if we can make FastAPI think we're passing Pydantic models with small modifications to DocumentArray.

Because of that, let's go with a simpler approach for now and implement one of the above later.
How would it work:
Let's create a separate Pydantic model PydanticDocumentArray which will be passed as a request, and will have a method to_docarray() to initialize a DocumentArray object from it.
Example:
@app.post("/doc/", response_model=DocumentArray, response_class=DocumentArrayResponse)
async def create_item(docs: PydanticDocumentArray[Mmdoc]):
    docs: DocumentArray[Mmdoc] = docs.to_docarray()
    return docs


Alphabet Bold Numbers Fix

Fixed Bold Numbers not showing in TitleState.
Before

After

@NeeEoo It's ready


Patch to add support for swap space on SD card

NOTE: 'discard=once' currently not supported by Jolla, using 'discard' instead
priority set to 10 (i.e.: lower than zram)
At some point of time in the future, I should add support for options - e.g.: in /etc/sysconfig/mount-sd

Almost 100 downloads at https://openrepos.net/content/v10lator/bleeding-edge-sd-utils with zero bug reports so far (@DrYak this does include the modified line we talked about).
Also using it for myself. Guess it's safe to merge. :)


Can't set invocationsPerMinute nor firesPerMinute.

One of invocationsPerMinute or firesPerMinute is limited at 60, and I can't increase it. Not sure why.
First I tried changing the variables in ansible/group_vars/all, but it didn't work.
Then I tried using wskadmin (like so: wskadmin limits set --invocationsPerMinute 999 whisk.system), but I think I'm not able to set it up correctly, or maybe I'm not using couchdb. I get Failed to set limits ([Errno 111] Connection refused). Here is my whisk.properties:
WHISK_LOGS_DIR=~/openwhisk/logs
DB_PROTOCOL=http
DB_PORT=5984
DB_HOST=<IP_ADDRESS>
DB_USERNAME=whisk_admin
DB_PASSWORD=some_passw0rd
DB_WHISK_AUTHS=local_subjects
DB_WHISK_ACTIONS=local_whisks
DB_WHISK_ACTIVATIONS=local_activations

I think I'm just not using the ansible method, and I don't have couchdb. There's no documentation on how to set these variables if I'm not using the ansible method of installation I guess.
To install openwhisk I just install Docker, Java and Node.js, and then run ./gradlew core:standalone:bootRun. I'm on an Ubuntu 18.04 machine.

I think this is because couchdb isn't exposed through docker on localhost. wskadmin is trying to access a closed port. I am using a kubernetes/helm deployment but I needed to replace ie: <IP_ADDRESS> with the IP address of couchdb inside the cluster and exposed as an endpoint by kubernetes. I was able to find this using kubectl get endpoints -n openwhisk which produced an output like:
NAME               ENDPOINTS                                            AGE
...
owdev-couchdb      <IP_ADDRESS>:5984                                     20h

so DB_HOST=<IP_ADDRESS>
then I was able to run wskadmin successfully:
wskadmin -v user get guest
...
========
REQUEST:
GET http://<IP_ADDRESS>:5984/test_subjects/guest
Headers sent:
...
--------
RESPONSE:
Got response with code 200
...

The procedure should be similar in docker, IE: docker container inspect couchdb-container.
Although I'm still not sure what WHISK_LOGS_DIR should point at, I was able to locate all the other variables by finding them within the helm chart, which should also be similar in docker/ansible-
See:

https://github.com/apache/openwhisk/blob/master/ansible/README.md#setup
https://github.com/apache/openwhisk/blob/master/ansible/templates/db_local.ini.j2
https://github.com/apache/openwhisk/blob/af11418df942e8d2cdc4c4ce933645fa723e9e45/ansible/group_vars/all#L250

So I figured it out.
We can modify this file https://github.com/apache/openwhisk/blob/master/core/standalone/src/main/resources/standalone.conf
It has the lines
  config {
    controller-instances = 1
    limits-actions-sequence-maxLength = 50
    limits-triggers-fires-perMinute = 60
    limits-actions-invokes-perMinute = 60
    limits-actions-invokes-concurrent = 30
  }

We can modify the limits to what we want.
And then we need to supply the file through the -c parameter, through the --args parameter. Like so:
sudo ./gradlew core:standalone:bootRun --args='-c /path/to/openwhisk/core/standalone/src/main/resources/standalone.conf'

That's it.

A bit off topic. But there's an alternative way to run openwhisk. We can do
sudo ./gradlew :core:standalone:build

And this will create a file in the bin folder called openwhisk-standalone.jar. In general, you can run openwhisk by doing
sudo java -jar ./bin/openwhisk-standalone.jar

And in our case, we need to supply the standalone.conf file through the -c parameter to the command above. We can do this:
sudo java -jar ./bin/openwhisk-standalone.jar -c /path/to/openwhisk/core/standalone/src/main/resources/standalone.conf


Import fails with Access denied; you need (at least one of) the SUPER privilege(s) for this operation

Hi Guys,
If you will have time please help me with an import. I started the import and I think while validation is running the process stops with the below error message:
Importing dump failed: could not execute import command: Warning: Using a password on the command line interface can be insecure. ERROR 1227 (42000) at line 18: Access denied; you need (at least one of) the SUPER privilege(s) for this operation
If you need anything else please let me know.
Best regards,
Sebi

I've just pushed the fix for this. Will update the agents soon.

Just deployed this, can you please test @sebastian-madaras?

Hi Dani,
The improvement that you added to CloudDB has solved the import of the
original dump file.
Best regards and I appreciate the help,
Sebi
On Thu, Apr 12, 2018 at 1:29 PM, Daniel Javorszky<EMAIL_ADDRESS>wrote:

Just deployed this, can you please test @sebastian-madaras
https://github.com/sebastian-madaras?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/djavorszky/ddn/issues/278#issuecomment-380773208, or mute
the thread
https://github.com/notifications/unsubscribe-auth/APJwrEhlHNCikjfrxKscRjtzyWKAd-W2ks5tnzqfgaJpZM4TG5Xb
.


Not submit to elasticsearch

This is my config file

I'm not sure when I run it always gives me this log. There are few rows available in the table but the submitted is always = 0

Thank you

This is correct. The total submitted rows are totalrows and this is > 0.

Hello jprante,
How about the submitted ?
I thought "totalrows" is the rows from sql database and "submitted" is the rows that has been submitted to elasticsearch index.
Thanks for your response

The log is confusing, submitted is the number of docs written to ES since the last submitted.


Local CSV Support

+1, this would be very handy

@archiewood think this is closed now that duckdb is in place.

I agree, but I think we probably need to do a better job of documenting this.
If you wanted to connect to a csv via the settings UI at the moment, you'd have to create a duckDB database, use that as your data connection, and then totally ignore it, and select * from 'path/to/your/data.csv' which feels pretty unintuitive!

does leaving the connection blank for duckdb use the :memory: database? (that is how it is handled in dbt-duckdb, for example)

Currently leaving it blank will not do anything, in the sense that it won't let you save without entering some text in that field. Which means it wont know you want to use duckDB.
It's a hang-over from how the sqilte connector works which is relatively similar, but can't work without a file.
It would be reasonably straightforward to edit the connector to just have a ':memory:' option I think.
But I'd ideally also like to signpost that you can use CSVs a bit more clearly, for those people who don't know what DuckDB is. Idea being they can select csv from the dropdown, and it selects the DuckDB connector under the hood, and gives people a link to the DuckDB docs on the csv syntax.

I've got a standalone CSV option working in the settings menu, which spins up a :memory: duckdb.
I'm also going to add a sources directory to the project as the recommended place to store csv files.
The last unsolved question is: should the CSV "connector" accept a full filepath, or should it be pointed at the sources directory to begin with?
E.g.,
select * from 'sources/myfile.csv'
vs.
select * from 'myfile.csv'

As an analyst, prefer ability to pass a file path so I can decouple data replication from data transformation and visualization.


Fix: Tooltip info out of screen issue

Description of PR
The PR fixes the issue when tooltip info gets out of the screen. To solve this, I had to rewrite tooltip component making some modifications to support re-render of tooltip component on change of props. I have transformed it to use react hooks.
Type of PR

[x] Bugfix
[ ] New feature

Relevant Issues
Fixes #1380
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots
Before

After

Thanks for the PR! :D


perf(src): :zap: auto generate dist

:tada: This PR is included in version 1.0.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Negative limits for numeric inputs

I need put negative limits for numeric input in my application, when there is a negative max limit, it does not allow to enter input.
Here is an example : https://codepen.io/hpgtlbnu-the-vuer/pen/ExzXOPm
Is there a configuration or something wrong ?
Thank you for your help

@RobinHerbots I think noValuePatching should allow to input any valid numeric value (including appropriate group and decimal separators) even if it's outside the min - max range. Then if the field loses focus, the Inputmask should patch the value according to set limits.

@Techn1c4l ,
The noValuePatching is about https://robinherbots.github.io/Inputmask/#/documentation#novaluepatching
@step0726 ,
I will have a look at the issue.


Remove character spacing from titles

Related to https://github.com/GetLuko/streamline/issues/42
Checklist before requesting a review

[x] Working on iOS
[x] Working on Android
[x] Integration tests added
[x] Visual regressions screenshots are up to date
[ ] Design validated

Looks good to me, thanks @hcourthias !


fix: Add activeState name, disable button for same state

Description

Disable state button when state is already selected.
Add default cursor for disabled buttons
Rename vars to prevent confusion between state url path and state name.

Related Issue

Motivation and Context

Issue #5
How Has This Been Tested?

Tested locally
Screenshots:
Example of Indiana being selected and Indiana button disabled.

Thank you @sautumn


[fre] Aspirated  not included in transcriptions

Wiktionary does not mark aspirated  in its transcriptions for French, instead adding a note before the transcription indicating whether a word-initial  is aspirated or mute, as on this page. This distinction is phonologically relevant – although  is silent, words that start with an aspirated  behave as though they start with a consonant – so it probably should be included in our transcriptions, right?

You're asking the right kind of question... h-aspire is the kind of thing that ought to be in a true phonemic transcription of a word but... I am not surprised that it isn't present here. We don't catch specialty tags like that superscript "aspirated h" that you see on the page for haricot, and if we did, say just for French, what would we add to the phonemic transcription? Would you instead give it as /ha.ʁi.ko/? I don't know...there be dragons.

Most bilingual dictionaries I've seen use an apostrophe or something similar (e.g. /'aʁiko/), and the Wikipedia article on it says that French dictionaries mark it with an asterisk (e.g. /*aʁiko/). Of course, neither choice is standard IPA, but I suppose we could add a note in the phones file to explain.

I am vaguely opposed to adding non-IPA signs, since that would likely break
other tools and require language-specific interpretation notes. Is there an
IPA alternative?
I think in this case we may have to acknowledge that this tool is really
only generating citation pronunciations; it doesn’t handle sandhi phenomena
(which this is: we don’t have any other liaison information here either)
nor is it obvious how to make it do so without substantially enriching the
spec.
On Thu, Oct 1, 2020 at 11:00 PM ajmalanoski<EMAIL_ADDRESS>wrote:

Most bilingual dictionaries I've seen use an apostrophe or something
similar (e.g. /'aʁiko/), and the Wikipedia article on it says that French
dictionaries mark it with an asterisk (e.g. /*aʁiko/). Of course, neither
choice is standard IPA, but I suppose we could add a note in the phones
file to explain.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/issues/212#issuecomment-702500525,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OJALZEFHJDH7UNV2ZLSIU63PANCNFSM4R7Y4NKQ
.

I'm going to close this for now. We can reopen if we ever figure out what the right thing to do is. I think this might be a simple enhancement to WikiPron (cf. Lucas's scripts to grab frequency data) but not part of WikiPron itself.


Fixed placeholder color in darkmode (IOS)

after research about the problem seems like there are two ways to solve the bug

override this behaviour by setting placeholderTextColor on the Input
disable app's dark mode support in  Info.plist file

seems like setting the placeholderTextColor its more like a workaround the problem (since every time we use an Input we have to explicit specify placeholder color)
I think disable app dark mode its more approachable solution because its more general, will not affect the app and we have to change it just in one place in all the application without overriding any styles
⚠ on emulator its working ok but needs to be tested on a real device still just to be sure

Tested on real device. No issues observed 👍


fix(field-item): align headings and content vertically

背景描述

FieldItem标题和正文垂向不对齐 #528
主要改动

删除.md-field-item-title和.md-field-item-control的line-height

Codecov Report

Merging #529 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #529   +/-   ##
=======================================
  Coverage   81.15%   81.15%
=======================================
  Files          91       91
  Lines        2722     2722
  Branches      522      522
=======================================
  Hits         2209     2209
  Misses        367      367
  Partials      146      146

Impacted Files
Coverage Δ

components/field/item.vue
75% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de796c...7a86ee8. Read the comment docs.


feat: add scalar subquery pushdown to scan

Which issue does this PR close?
Part of #372  and #551
Rationale for this change
With Spark 4.0, the SubquerySuite in Spark fails as Comet scan did not support the scala subquery feature.
What changes are included in this PR?
Adds the support for scalar subquery pushdown into Comet scan
How are these changes tested?
Existing Spark/sql unit tests in SubquerySuite

Currently DRAFT to make sure ci for older versions passes.
Note the shims for the older versions had to be refactored as this required a change specifically for Spark 3.3 which was different from the change required for Spark 3.4 and above.

@kazuyukitanimura Ready for your review.

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.66%. Comparing base (de8c55e) to head (231d0e5).
Report is 6 commits behind head on main.

Files
Patch %
Lines

...ala/org/apache/spark/sql/comet/CometScanExec.scala
0.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #678      +/-   ##
============================================
- Coverage     33.69%   33.66%   -0.04%
+ Complexity      840      813      -27
============================================
  Files           109      109
  Lines         42527    42527
  Branches       9343     9343
============================================
- Hits          14331    14318      -13
- Misses        25245    25252       +7
- Partials       2951     2957       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@kazuyukitanimura @andygrove @comphead Can we merge this?

Merged, thanks @parthchandra @andygrove @comphead


Arm64 Build for Apple Silicon?

Proposal
I would like to explore how we can configure CircleCI to build a native arm64 binary for macOS, so it can be used on M1 developer machines via flow-bin.
Use case
I was able to build flow on my M1 with the following small changes (ocamlbuild 4.10.2 or 4.12.0 is required for M1 support):
diff --git a/Makefile b/Makefile
index fa3bcbc80..a9bcf7ae0 100644
--- a/Makefile
+++ b/Makefile
@@ -25,7 +25,7 @@ ifeq ($(OS), Windows_NT)
 else
   UNAME_S=$(shell uname -s)
   UNAME_M=$(shell uname -m)
-  SWITCH=ocaml-base-compiler.4.09.1
+  SWITCH=ocaml-base-compiler.4.10.2
 endif

 # Default to `ocamlbuild -j 0` (unlimited parallelism), but you can limit it
diff --git a/README.md b/README.md
index 50e6bca4c..04c15846a 100644
--- a/README.md
+++ b/README.md
@@ -83,6 +83,7 @@ Flow is written in OCaml (OCaml 4.09.1 is required).
     ```sh
     # on Mac and Linux:
     opam init
+    opam update

     # on Windows:
     scripts/windows/init_opam.sh

The performance is substantially better (2x performance) than through Rosetta 2:
x86:
$ time flow check
Found 0 errors
✨  Done in 3.28s.

________________________________________________________
Executed in    3.52 secs   fish           external
   usr time  1005.93 millis   63.00 micros  1005.87 millis
   sys time  678.18 millis  1213.00 micros  676.97 millis

native arm64:
$ time ../flow/bin/flow check
Found 0 errors
________________________________________________________
Executed in    1.58 secs   fish           external
   usr time  634.83 millis   73.00 micros  634.76 millis
   sys time  331.76 millis  1190.00 micros  330.57 millis

I am not familiar enough with ocamlbuild to know if there is a way for us to output an ARM64 binary on an Intel Mac builder, as CircleCI does not yet provide M1 support.
I'm experimenting with how to get it working in this CircleCI job, but they are currently having an outage.

I know it's not nice to do, but really, bump.

I think it should be possible to add it to the CircleCI job, I'll give it another go-around today, but that depends on FB staff wanting to merge it.

I don't believe it will be possible to cross compile on an intel Mac without something like https://github.com/ocaml-cross/opam-cross-windows. The compiler and ppxs would need to be built for intel but the rest of the artifacts for M1. But happy to be surprised if you can get it working @STRML!
We will add this as soon as M1 hosts are available in CI.

There may be a (slow) way to make this work using docker buildx in CircleCI, investigating that now.

Yeah I'm way off base on that idea. You can use docker buildx on M1 machines to do x86_64 and arm64 builds for linux which will work both on MacOS and Linux hosts, because both of them are effectively running Linux kernels to run Docker.
If you want something that will work natively on MacOS (aarch64-apple-darwin), it's more of a problem. You really seem to need an actual M1 host, or you need a way of passing flags to gcc directly like in the Apple docs so you can build a universal binary.
I don't know enough about ocamlopt to really understand how to do this, and neither does Google as far as I've been able to take it. It is theoretically possible on MacOS >= 11 and XCode >= 12 to build universal binaries even on x86, but I don't know how to make that work within the OCaml toolchain.

@STRML it looks like they found a solution using GitHub Actions here?
https://discuss.ocaml.org/t/cross-compiling-ocaml-with-github-actions/9154

Hello? Isn't Facebook using the new Macs for development?

we have internal M1 builds, yeah. we're still waiting on CircleCI to launch M1 runners to integrate with our external releases, which we're told is Real Soon Now. i'm frustrated it's taking so long as well...

Looking at this, it looks like ARM mac is coming soon from CircleCI.

CircleCI roadmap says that it's released 🎉

Yes, you might see that we already started to build it on mac arm: https://app.circleci.com/pipelines/github/facebook/flow/5541/workflows/ed21b666-0e64-435f-88ca-1f1623ed0c51/jobs/97719

Any update on this? The ARM binary has been available for a while already but it's not yet included in npm releases.


"yaml: did not find expected key" with basic example

Hello,
When I try to convert basic example from  https://github.com/metal3d/katenary/blob/master/examples/basic/docker-compose.yaml, I obtain "yaml: did not find expected key" even if the chart is generated.
I guess the pb comes from these lines
katenary.io/mapenv: |
DB_HOST: {{ .Release.Name }}-database
I saw that indentation matters but I tried the example out of the box
My  katenary version : 2.0.0-beta2
My kompose version : 1.25.0 (a70f80cc)
BR
Vincent

The problem is simply that you didn't encaplusate "{{ .Release.Name }}-database" with quotes. Brackets are valid JSON objects, and Katernary tries to load the "mapenv" label as YAML.
Try with:
version: "3"

# this example is absolutely not working, it's an example to see how it is converted
# by Katenary
services:
  webapp:
    image: php:7-apache
    environment:
      DB_HOST: database
    ports:
      - "8080:80"
    labels:
      # expose an ingress
      katenary.io/ingress: 80
      # DB_HOST is actually a service name
      katenary.io/mapenv: |
        DB_HOST: "{{ .Release.Name }}-database"
    depends_on:
      - database

  database:
    image: mariadb:10
    environment:
      MARIADB_ROOT_PASSWORD: foobar
      MARIADB_USER: foo
      MARIADB_PASSWORD: foo
      MARIADB_DATABASE: myapp
    labels:
      # because we don't provide "ports" or "expose", alert katenary
      # to use the mysql port for service declaration
      katenary.io/ports: 3306

I just see that it's my example which is wrong... I will fix!

Thank you for your quick answer !


[PROD] KLM panicked with fatal error: concurrent map read and map write

Description
Dahsboards show a drop in memory consumption and CPU usage at ~2024-04-19T01:26UTC and ~2024-04-212T01:22UTC
Reason is a panic due to fatal error: concurrent map read and map write
Diving into the logs we can again see a problem with github.com/jellydator/ttlcache/v3.(*Cache[...]).Start(0x387fa80):
Apr 19, 2024 @ 01:26:35.746 - golang.org/x/net/http2.(*clientConnReadLoop).run(0xc012265fa8)
Apr 19, 2024 @ 01:26:35.746 -	/go/pkg/mod/golang.org/x/net@v0.21.0/http2/frame.go:237 +0x65
Apr 19, 2024 @ 01:26:35.747 -	/workspace/internal/declarative/v2/ssa.go:53 +0x206
Apr 19, 2024 @ 01:26:35.747 - github.com/jellydator/ttlcache/v3.(*Cache[...]).Start(0x387f2c0)
Apr 19, 2024 @ 01:26:35.747 - created by golang.org/x/net/http2.(*Transport).newClientConn in goroutine 341519527
Apr 19, 2024 @ 01:26:35.747 -	/workspace/internal/declarative/v2/ssa.go:103 +0x18a
Apr 19, 2024 @ 01:26:35.747 -	/go/pkg/mod/golang.org/x/net@v0.21.0/http2/transport.go:821 +0xca6
Apr 19, 2024 @ 01:26:35.747 - github.com/kyma-project/lifecycle-manager/internal/declarative/v2.(*ConcurrentDefaultSSA).serverSideApplyResourceInfo(0xc04fbb7f40, {0x383b6a8, 0xc093320b10}, 0xc0ee84c680)
Apr 19, 2024 @ 01:26:35.747 - internal/poll.runtime_pollWait(0x79002da6e248, 0x72)
Apr 19, 2024 @ 01:26:35.747 - github.com/kyma-project/lifecycle-manager/internal/declarative/v2.(*ConcurrentDefaultSSA).serverSideApply(0xc04fbb7f40, {0x383b6a8, 0xc093320b10}, 0xc0ee84c680, 0xc076d15680)
Apr 19, 2024 @ 01:26:35.747 - 	/workspace/internal/declarative/v2/ssa.go:121 +0x152
Apr 19, 2024 @ 01:26:35.748 - created by github.com/kyma-project/lifecycle-manager/internal/declarative/v2.NewInMemoryCachedManifestParser in goroutine 1
Apr 19, 2024 @ 01:26:35.748 -     /workspace/pkg/remote/client_cache.go:19 +0xc5

Steps to reproduce
to be found out
Environment Type
Managed
Environment Info
Kubernetes Version: x.y.z
Docker Version: x.y.z
Kyma CLI Version: x.y.z
If used - k3d/k3s/minikube versions
Attachments
No response

Likely a duplicate of https://github.com/kyma-project/lifecycle-manager/issues/1455


Python 3.7 interop

We could backport some functionality, so that ir_axioms also works with Python 3.7.
This would allow users to experiment with ir_axioms in Google Colab

Fixed in 242bafca8acfdd9de6203507afff291b01e86cfc


OpenCage provider: use no_annotations=1 as returned data is not used

OpenCage results include https://opencagedata.com/api#annotations data by default. As this data isn't put into the Location response object it can be skipped in the request.

I'm afraid this might count as a breaking change, because it would affect the contents of the location.raw value.
Is the benefit from disabling these by default really prominent?

Well, it seems to reduce mean request time in tests by 20%, so I guess that's something.
I'm merging this, but will add a new method param to switch annotations and will make it on by default, in order to not break backwards compatibility.

Sounds good. Thanks a lot.


Add callback component

A picture tells a thousand words
Before this PR
The callback component was the only component that we should'nt customize
After this PR
Now, for the context, or redux package, you can customize by adding a prop

Awesome PullRequest! Thank you @Madebymaurice
@youf-olivier what do you think about it?

I would try to understand why we can't use the same logic as the other overrides component. I'll check this afternoon.
Thanks for the PR !


Fix user agent header value when chaining commands

What?

Fix issue : while chaining neoload commands, the command in the user-agent was always the last command of the chain.
Only send a  header user-agent in one request per CLI command. We don't want to send a user-agent for example for all "GET test-results" requests while running a test.

Why?
To have more accurate info on how the CLI is used
How?
Issue : Before the "rest_crud.set_command()" was called in the main.py, but all commands are loaded at the beginning. That's why we need to call "set_command" into each "cli()" function.

We need to do this EVEN for on-prem installations because these installations work the same way as the SaaS !


v0.9.2_12: Stacking selector is broken //The percentage of extreme poverty is not 11.5 ± 0.3%

SEVERITY: Major
MODULE: Tool Page
Platform:  Windows 7 / Chrome 47.0
STEPS TO REPRODUCE:

Navigate to URL: http://dev-tools.gapminderdev.org:3001/tools/mountain
Tools page is loaded.
Click “Stack”, small pop up screen is displayed
Click “Regions” in the first line
Note that the percentage of people living in the extreme poverty is not 11.5 ± 0.3%

ACTUAL RESULTS:
The percentage of people living in the extreme poverty is not 11.5 ± 0.3%
EXPECTED RESULTS:
The percentage of people living in the extreme poverty should be 11.5 ± 0.3%
SCREENSHOT:

#1180 might be a root cause

Fixed with https://github.com/Gapminder/vizabi/commit/3085685cbe2a98454c7c1bac92a6187740bbf369


Update website for 2020

It's live already.

Yes it has been published, but the modifications still are in progress..


Allow appcenter distribute releases list to display unpublished release

Hello guys,
I'm facing problem, I tried to fetch all releases associated to an app through:
appcenter distribute releases list --app XXX/YYY
The result is an empty array.
Using appcenter-cli version: 2.1.0
| Loading list of releases...logFilter, request: {
  "rawResponse": false,
  "queryString": {},
  "url": "https://api.appcenter.ms/v0.1/apps/XXX/YYY/releases?published_only=true",
  "method": "GET",
  "headers": {
    "Content-Type": "application/json; charset=utf-8",
    "user-agent": "appcenterCli/2.1.0 NodeJS/v10.15.3 darwin/19.2.0",
    "x-api-token": "...."
  },
  "body": null
}
- Loading list of releases...Response status code: 200
Body: []

When i use the web 'https://appcenter.ms/orgs/XXX/apps/YYY/distribute/releases', i got the full list.
curl 'https://appcenter.ms/api/v0.1/apps/XXXX/YYYY/releases' -H 'x-api-token: ...'

[{"origin":"appcenter","id":1,"short_version":"1.6.0","version":"70","uploaded_at":"2020-01-02T16:18:48.000Z","enabled":true,"is_external_build":false}]⏎

So could you tell my why the cli is restricted to the 'published_only' release?
Is there a way to add an option to be able to fetch all releases using the cli?
thanks

@Jerome91410 - What is the scenario for needing the unpublished releases? The App Center CLI currently only supports fetching published releases.

@phillipleblanc I expected to use it in my CD process.
When I release feature, my CI check if the build already exists, if not the CI has to build the iOS/Android releases and publish them on appcenter

ios build time: ~20min
android build time: ~10min

We would love to have that feature as well!
We are using the CLI from our CI/CD to identify old releases and remove them from AppCenter. At this point we are unable to list unpublished releases :-(


Google asisstant

I like this application and I think you should try it too. https://xvo.ch/weather/

Summons Cummon


Resource harbor_replication does not support argument trigger

It is defined as model https://github.com/BESTSELLER/terraform-provider-harbor/blob/274944faf4073369032bdc1d12979073138f8b75/models/replications.go#L15
but not defined in provider https://github.com/BESTSELLER/terraform-provider-harbor/blob/274944faf4073369032bdc1d12979073138f8b75/provider/resource_replication.go#L12

I think, what your are looking for is schedule
https://github.com/BESTSELLER/terraform-provider-harbor/blob/master/docs/resources/replication.md
for now, you can only set manual or a cron
but with this PR (https://github.com/BESTSELLER/terraform-provider-harbor/pull/76), we should be able to also set event_based for replication

Yes that's what I was looking for. Thanks