CardMediaTypeMap should be exported from CardMedia.d.ts

Typescript error since compiler does not know the shape of CardMediaTypeMap

[ ] The issue is present in the latest release.
[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
import * as React from 'react';
import { OverridableComponent, OverrideProps } from '../OverridableComponent';
interface CardMediaTypeMap<P, D extends React.ElementType> {
props: P & {
image?: string;
src?: string;
};
defaultComponent: D;
classKey: CardMediaClassKey;
}
declare const CardMedia: OverridableComponent<CardMediaTypeMap<{}, 'div'>>;
export type CardMediaClassKey = 'root' | 'media';
export type CardMediaProps<D extends React.ElementType = 'div', P = {}> = OverrideProps<
CardMediaTypeMap<P, D>,
D

;

export default CardMedia;

Expected Behavior 🤔
import * as React from 'react';
import { OverridableComponent, OverrideProps } from '../OverridableComponent';
export interface CardMediaTypeMap<P, D extends React.ElementType> {
props: P & {
image?: string;
src?: string;
};
defaultComponent: D;
classKey: CardMediaClassKey;
}
declare const CardMedia: OverridableComponent<CardMediaTypeMap<{}, 'div'>>;
export type CardMediaClassKey = 'root' | 'media';
export type CardMediaProps<D extends React.ElementType = 'div', P = {}> = OverrideProps<
CardMediaTypeMap<P, D>,
D

;

export default CardMedia;

Steps to Reproduce 🕹

Steps:

Context 🔦

Your Environment 🌎

Tech
Version

Material-UI
v4.?.?

React

Browser

TypeScript

etc.

CardMediaTypeMap should be exported from CardMedia.d.ts

It seems that we export such variable in the other components, so for the only sake of consistency, this sounds like a valid request.


Coerce email validation duration attribute to Float

NOTE: In some instances the Loqate API is returning integers, which due to the current strict definition is causing the parsing of the email validation result to fail.
[Loqate::Email::EmailValidation.new] 0 (Integer) has invalid type for :duration violates constraints (type?(Float, 0) failed)

@wilsonsilva for 👀

@wilsonsilva for 👀

Sorry for making you wait so long! I was on holidays.

Sorry for making you wait so long! I was on holidays.

@lostie https://rubygems.org/gems/loqate/versions/0.11.0

@lostie https://rubygems.org/gems/loqate/versions/0.11.0


[$500] Address - Blue border appears around the row and the field is not focused when using Tab key

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com
Go to Settings > Profile > Personal details > Address
Click on any field
Navigate to the next field with tab key

Expected Result:
The next field will be focused with just one click
Actual Result:
A blue border appears around the field and the next field is not focused. It is only focused after pressing Tab key for the second time
This issue also happens in other area of the app that involve entering value
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/85a2b1e3-7aa6-460e-a468-b398c566ccbc
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e6211747d5d8420e
Upwork Job ID:<PHONE_NUMBER>129036288
Last Price Increase: 2023-11-10

Proposal
Please re-state the problem that we are trying to solve in this issue.
Blue border appears on the row when pressing tab key in the address page
What is the root cause of that problem?
To prevent focusing by tab, we set tabIndex=-1 below
https://github.com/Expensify/App/blob/3939beaf7969fb04bc46083b395a45118a406b05/src/components/TextInput/BaseTextInput/index.js#L258
but tabIndex is changed here
https://github.com/Expensify/App/blob/3939beaf7969fb04bc46083b395a45118a406b05/src/components/Pressable/GenericPressable/index.tsx#L16
This is the root cause
What changes do you think we should make in order to solve the problem?
I think we need to use props.tabIndex if exists
Update
https://github.com/Expensify/App/blob/3939beaf7969fb04bc46083b395a45118a406b05/src/components/Pressable/GenericPressable/index.tsx#L16
to
            tabIndex={props.tabIndex ?? (!accessible || !focusable) ? -1 : 0}

This works as expected
What alternative solutions did you explore? (Optional)

Hey @Ollyws, can you please review the proposals above? Thanks!

@Ollyws please provide an update. Thanks!

This is a regression caused by https://github.com/Expensify/App/pull/31118.

Proposal
Please re-state the problem that we are trying to solve in this issue.

Issue is that we are not able to focus on next textinput.

What is the root cause of that problem?

In WebGenericPressable ( https://github.com/Expensify/App/blob/main/src/components/Pressable/GenericPressable/index.tsx ) we are not forwarding   tabIndex prop when it is defined from parent component.
We have few implementations of GenericPressable where we are passing it but haven't checked if its being forwarded or not.
Like in this commit:

https://github.com/Expensify/App/commit/465f0a817dfe5c9ffb50b71accff13a4fdfa81d1

What changes do you think we should make in order to solve the problem?

We should check if tabIndex is undefined or not and then forward it. We are checking if it is undefined or not as we might want to focus it by passing 0 as tabIndex. And thus we can't use short hand operator || like this tabIndex={props.tabIndex || (!accessible || !focusable ? -1 : 0)} as it will not forward 0 as tabIndex.

const tabIndex = props.tabIndex !== undefined ? props.tabIndex : !accessible || !focusable ? -1 : 0;

tabIndex={tabIndex}

What alternative solutions did you explore? (Optional)

If we are sure we don't want Pressable in BaseTextInput/index.js then we pass accessible={false} like we did in CheckboxWithLabel.

https://github.com/Expensify/App/blob/91ef64083723d1ef98351f6f0e6eafeea6950117/src/components/CheckboxWithLabel.js#L112-L115

This also resolves our issue but i wasn't sure if this could affect other parts of the code or not.

@Ollyws can you please complete the list above? Thanks!

@Ollyws and @tienifr please accept the offers in Upwork and I will process the payments. Thanks!

@Ollyws requires payment offer (Reviewer)
@tienifr requires payment offer (Contributor)

Bump @Ollyws to complete the checklist above. Thanks!

Hey @Ollyws, can you please complete the checklist above? Thanks!

Thanks! @Ollyws, please accept the offer in Upwork.

All set!


trial mode onboarding - potential improvements

in the Settings screen, on Account line, and in the Account screen, on Backup/upgrade account, add an ⚠ sign (only if on level 0)
I'm not a fan of the phone icon for Backup/upgrade account. I don't think it convey the right message. I'm not sure which icon we could replace it with (I know it's here probably because it share the same state as where the phone number has been entereted). maybe person-circle-outline from ionicons is a better ? we will eventually also have email here so we could prepare for that at the same time.
modal "Upgrade your account" has light grey title but white text. I think all should be white (or all light grey) - but the title should never be less visible in term of opacity than the text associated with it
this PR didn't work. https://github.com/GaloyMoney/galoy-mobile/commit/649557187c2d7344fc77d640b345b7ba5e6e106a still flickering on app start
I think the "upgrade your account modal" is good in place where we want to suggest to user to upgrade (ie: receive onchain), but it's not the best message for when the user is on the Account screen and tap on Upgrade. It's conflating 2 uses cases: marketing message (which is what this screen is designed for, as it is currently) and set the expectation when the user already shows the intent to upgrade. If we want to set expectation in the upgrade flow, when the user shows the intent to upgrade, then we can have an additional screen, probably not in modal but as a standard screen, that would sit prior to the "enter your phone" screen, with a text along the line:

title: "You're going to upgrade your account"
text: "Upgrading your account make your account recoverable. You will do this by verifying your phone number in the follow screen. It also give you higher transactions limits and more functionality"
other improvements:

in the Account screen swap Account level with Backup/upgrade account, so that all actionable items are grouped together

Are you saying that you want  ⚠  and  "person-circle-outline" for Backup/upgrade account?

Are you saying that you want warning and "person-circle-outline" for Backup/upgrade account?

I think the warning could be within the text (at the end of it) if we're on level 0.


Changes for Transaction, Addresses, Receive screen GUI only

GUI related changes to screens as per new design

Merged changes


How Rebuild the solution?

I follow the requirement on the main page

ArcGIS Runtime SDK for WPF
Xceed Data Grid for WPF (www.xceed.com).
ActiveReports for .NET 3.0 (www.datadynamics.com).

But still getting some errors.

What are the proper step to Rebuld the Solution. I just want change the app to use my road network.

You don’t need to rebuild the app to use your own road network. Just use your network to publish route and VRP services and point to your services in services.xml.
-Rodney
From: dropyghost<EMAIL_ADDRESS>Sent: Wednesday, March 09, 2016 07:45
To: Esri/route-planner-csharp
Subject: [route-planner-csharp] How Rebuild the solution? (#26)
I follow the requirement on the main page

ArcGIS Runtime SDK for WPF
Xceed Data Grid for WPF (www.xceed.comhttps://urldefense.proofpoint.com/v2/url?u=http-3A__www.xceed.com&d=CwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=-A4AYYiEJOVeNWm0UFk04A&m=tPw57oJWuIrYHH_XRRDHQzmCB-waj155-L84UDv27fo&s=xjeDB81vwg7VR9aRWqrCFTLNMdgS6UeCKOpiUsYoTWU&e=).
ActiveReports for .NET 3.0 (www.datadynamics.comhttps://urldefense.proofpoint.com/v2/url?u=http-3A__www.datadynamics.com&d=CwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=-A4AYYiEJOVeNWm0UFk04A&m=tPw57oJWuIrYHH_XRRDHQzmCB-waj155-L84UDv27fo&s=Fu8qN3wE00OcpoaupOuVjXnT7hYrmNUlMfxofYBkAPk&e=).

But still getting some errors.
[image]https://urldefense.proofpoint.com/v2/url?u=https-3A__cloud.githubusercontent.com_assets_10077853_13640701_f0319e3a-2De5e7-2D11e5-2D9207-2De63693b850f9.png&d=CwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=-A4AYYiEJOVeNWm0UFk04A&m=tPw57oJWuIrYHH_XRRDHQzmCB-waj155-L84UDv27fo&s=qAcZJt8mWUqUo7JUFCwrjbKonDJXl42-6-KZ8Ztxn0U&e=
What are the proper step to Rebuld the Solution. I just want change the app to use my road network.
—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Esri_route-2Dplanner-2Dcsharp_issues_26&d=CwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=-A4AYYiEJOVeNWm0UFk04A&m=tPw57oJWuIrYHH_XRRDHQzmCB-waj155-L84UDv27fo&s=WIJ3N3VQ6rFvevIQYiUYv5PdmlRN_-G881ZHE5qucfI&e=.

I install the prebuild version and doesnt have a services.xml file there.
Also beside road network can I change setting to also use my maps?

C:\Program Files (x86)\RoutePlanner

Yes, all of this is in services.xml. C:\Program Data\RoutePlanner\services.xml
BTW, Program Data is a hidden directory by default.
From: dropyghost<EMAIL_ADDRESS>Sent: Wednesday, March 09, 2016 08:12
To: Esri/route-planner-csharp
Cc: Rodney Conger
Subject: Re: [route-planner-csharp] How Rebuild the solution? (#26)
I install the prebuild version and doesnt have a services.xml file there.
Also beside road network can I change setting to also use my maps?
C:\Program Files (x86)\RoutePlanner
[image]https://urldefense.proofpoint.com/v2/url?u=https-3A__cloud.githubusercontent.com_assets_10077853_13641767_df00cf74-2De5eb-2D11e5-2D9f0f-2D266ea5b8de09.png&d=CwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=-A4AYYiEJOVeNWm0UFk04A&m=XPKHJgiqOhFMhteAc1pmT3CxrG29WPWBQmHCPumfm5A&s=ejAY-dM-maPp80MsfDiVD10RNJDW__LjI3dFvBNU8zQ&e=
—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Esri_route-2Dplanner-2Dcsharp_issues_26-23issuecomment-2D194368709&d=CwMCaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=-A4AYYiEJOVeNWm0UFk04A&m=XPKHJgiqOhFMhteAc1pmT3CxrG29WPWBQmHCPumfm5A&s=FP1s5G5V5wh6J1jbAmOmYenDsj3LCDkc7j4R6MmX9_E&e=.

I change the services.xml and try replace the street satellite map, but didnt see any change or error, and still show same maps like is reading it from somewhere else.
    <service type="ArcGISCached" server="server.arcgisonline.com" basemap="true" visible="true">
      <name>Streets</name>
      <title>StreetMap World 2D</title>
      <soapurl>https://server.arcgisonline.com/arcgis/services/World_Street_Map/MapServer</soapurl>
      <opacity>1</opacity>
    </service>
    <service type="ArcGISCached" server="server.arcgisonline.com" basemap="true" visible="false">
      <name>Satellite</name>
      <title>Imagery World 2D</title>
      <soapurl>https://server.arcgisonline.com/arcgis/services/World_Imagery/MapServer</soapurl>
      <opacity>1</opacity>
    </service>

Also looks like my map is a different format/type as the one is beign used by planner.
My Map

ArcGis

So how I know if Im replacing the map service correctly and what format should I publish my map?


Cursor finalized without prior close()

I'm seeing a lot of warnings like
02-09 11:27:45.935  20050-20059/com.gumroad.android W/CursorWrapperInner﹕ Cursor finalized without prior close()

after saving an object. Am I doing something wrong?

Can you post the offending code that you're calling the sugar library with? It's hard to know what's going on with a single log message.


SelectBox: ComboBox role workaround for native select Addresses: #60929

@chrmarti - thanks again for catching
@isidorn
@Tyriar
If anyone of you can review and merge, I am following new procedures not merging myself as non-MS team member.
Thanks!

Assign explicit role=combobox to native select box (select)
Electron 2.x incorrect assignment issue
Voiceover also affected
Equally addresses same issue with Debug Configurations label
Does not affect SelectBox within new settings , already addressed there

See: #60929

@cleidigh thanks for the PR, this all looks good so I will merge it in.
Assigning to November milestone though, since this will only be available in the November stable release. The october one is already frozen and we are only accepting critical fixes.


No integration with github

Having some linkage with github (eg just a link to the repo and links for #1 and #99) seems nice.

Given there is a github project linked
When I click on a commit link
Then I should end up in github
And not in Heidi!


Make websocket::stream async_teardown of next_layers configurable

Currently async_close() will tear down next layers(like ssl::stream and tcp::socket) which is pretty nice. However, there are cases where the next layers are managed additionally for some custom purposes(like keep-alive) and then shutting down the whole chain is basically making such tasks hard to achieve.
My proposal is to add an option to set_option() about that behavior. Of course, by default keep it on so there will be no behavioral change, but at least whoever want to manage the layers by himself will have the possibility to do so.

This behaviour of async_close was added recently as a result of a user
request.
Do you have a specific use case for leaving a socket open after the
websocket is finished with, or is this a theoretical concern?
On Thu, 28 Jan 2021 at 00:51, Nikolay Baklicharov<EMAIL_ADDRESS>wrote:

Currently async_close() will tear down next layers(like ssl::stream and
tcp::socket) which is pretty nice. However, there are cases where the next
layers are managed additionally for some custom purposes(like keep-alive)
and then shutting down the whole chain is basically making such tasks hard
to achieve.
My proposal is to add an option to set_option() about that behavior. Of
course, by default keep it on so there will be no behavioral change, but
at least whoever want to manage the layers by himself will have the
possibility to do so.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/boostorg/beast/issues/2157, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHOZSMHP7M5R74MT4QNINDS4CRJFANCNFSM4WWED6WA
.

--
Richard Hodges
<EMAIL_ADDRESS>office: +442032898513
home: +376841522
mobile: +376380212

This behaviour of async_close was added recently as a result of a user
request.
Do you have a specific use case for leaving a socket open after the
websocket is finished with, or is this a theoretical concern?
On Thu, 28 Jan 2021 at 00:51, Nikolay Baklicharov<EMAIL_ADDRESS>wrote:

Currently async_close() will tear down next layers(like ssl::stream and
tcp::socket) which is pretty nice. However, there are cases where the next
layers are managed additionally for some custom purposes(like keep-alive)
and then shutting down the whole chain is basically making such tasks hard
to achieve.
My proposal is to add an option to set_option() about that behavior. Of
course, by default keep it on so there will be no behavioral change, but
at least whoever want to manage the layers by himself will have the
possibility to do so.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/boostorg/beast/issues/2157, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHOZSMHP7M5R74MT4QNINDS4CRJFANCNFSM4WWED6WA
.

--
Richard Hodges
<EMAIL_ADDRESS>office: +442032898513
home: +376841522
mobile: +376380212

I'm that very same user. :) The thing before was that the job was halfway done. If the next layer is ssl::stream it would be shutdown, but leaving the tcp socket, on the other hand if the next layer is tcp socket, then it will shut it down.  My previous request was to shutdown the whole chain to make the operation consistent.
However, I have a use case where the next layer is ssl::stream(with tcp socket) and I just want to close the websocket, without closing the SSL stream and the tcp socket and yes my experiments are purely for fun and research, there is no a real showstopper currently on real projects, but yeah, I thought that a simple option for that behavior would be useful. :)

I'm that very same user. :) The thing before was that the job was halfway done. If the next layer is ssl::stream it would be shutdown, but leaving the tcp socket, on the other hand if the next layer is tcp socket, then it will shut it down.  My previous request was to shutdown the whole chain to make the operation consistent.
However, I have a use case where the next layer is ssl::stream(with tcp socket) and I just want to close the websocket, without closing the SSL stream and the tcp socket and yes my experiments are purely for fun and research, there is no a real showstopper currently on real projects, but yeah, I thought that a simple option for that behavior would be useful. :)

Definitely not, because the WebSocket specification says that when the websocket connection is closed, the TLS connection MUST be torn down. You are asking for behavior from Beast that goes against the RFC. If you really need to do that, write your own NextLayer type which is a wrapper around socket or TLS stream, and implement teardown for that.

Definitely not, because the WebSocket specification says that when the websocket connection is closed, the TLS connection MUST be torn down. You are asking for behavior from Beast that goes against the RFC. If you really need to do that, write your own NextLayer type which is a wrapper around socket or TLS stream, and implement teardown for that.

Ook, take it easy man, I haven't read the RFC in such detail. Yes, I know about the workaround with custom layer, I was just wondering if I can avoid it. Anyway, thanks for the info.

Ook, take it easy man, I haven't read the RFC in such detail. Yes, I know about the workaround with custom layer, I was just wondering if I can avoid it. Anyway, thanks for the info.


Added gitignore and included .DS_Store

Second line removed. I thought it was needed to ignore DS_Store in all files and sub-files.


the example readme of "echo" still empty

Version:
Platform:
Subsystem:

Type:

Severity:
Very Low
Description:
the example readme of "echo" still empty
Steps to reproduce the error:

It got filled with #166 check it out! :)


Add optional LinkedIn nickname

Add optional LinkedIn nickname instead of simply showing the LinkedIn ID. If you are unfortunate like my friend you may have a LinkedIn ID that is in this form: johndoe-8675235.
This addition enables you to add a second parameter that can be displayed instad for a more aesthetic appearance in the header.

Im not exactly sure of the various ways of getting the LinkedIn ID. I just figured that everyone took the name that was in the url when you are on your profile page. If there is another way the PR might have some optimization in store.
Anyhow, thanks for approving. Nice to be able to contribute to an already awesome repo.

What about in print though? Presumably if you enter go to linkedin.com/in/johndoe without the numeric ID your friend won't be found (and worse someone else's friend might be)?
I thought about this in adding Orcid, which is aesthetically even worse, but I think it's important it be usable when printed as well as while a digital, clickable, PDF.


paging: when on page > 1 and adding a filter, the page does not reset

If say on page 4 and a filter is added such that there are no longer 4 pages of results, page 4 is still shown, but obviously has no results. The page number should reset when the filters are changed

cc @jrhodes-sitback

See https://github.com/sajari/sajari-sdk-react/blob/master/examples/standard-search/src/App.js#L23

Need to add the page reset to 1 in the filter listener e.g.
`categoryFilter.listen(selectionUpdatedEvent, () => {
values.set({ page: "1" });
pipeline.search(values);
});`

@mlhoque @jrhodes-sitback you need to update your version.

This issue seems to be present in the example:
https://sajari-sdk-react.netlify.com/example
Search for a term with a lot of pages, page through and then change term to something with a few pages. It gets stuck.

@sampotts thanks for spotting this, I'll get a fix into the example code now.
For reference to solve that issue, you can use the following snippet of code:
values.listen(EVENT_VALUES_UPDATED, (changes, set) => {
  if (!changes.page) {
    set({ page: "1" });
  }
});


Would You Please Help Upload ContivVPP-arm64 Docker Images to Official Docker Repo

Hi:
Now Contiv/VPP arm64 docker images can be built by the command:
docker/build-all.sh
on arm64 platform.
And we are committing the sample deployment yaml file for arm64 as contiv-vpp-arm64.yaml:
https://github.com/contiv/vpp/pull/992
So could you please help build and upload the corresponding contivvpp arm64 docker images, such as
contivvpp/ksr-arm64, contivvpp/cni-arm64, contivvpp/vswitch-arm64 to facilitate its deployment on arm64 platform.
Any question or request is welcome.

Hi,
we cannot really help with building ARM images, wince we do not have any spare ARM server that could be used for builds. However, I we create appropriate repos on Dockerhub and give you write access to them if you want to setup build on your infra. Just let me know, e.g. via Slack (https://contivvpp.slack.com/):
https://join.slack.com/t/contivvpp/shared_invite/enQtNDE0MDk3NzAxOTc0LThmZDlmYTRlMWExZjUyNWIyMGQ3YjgxMzA1NjFhNjk1ZjIwNGRmNmE5Mzc1OWI1MTI3ZjM4NTQ3ZWI2YTQ3ODM

@rastislavszabo
For our company's policy, I can not upload docker images directly. But we may do it via our 3rd party partners to do it.  I will contact them for this issue and respond to you after that.
Thanks a lot.

We are solving that.

Images are uploaded now.


No toolbar / buttons to confirm the crop

I just started using the library.  I'm using the 4.5.0 (latest as of this writing).  But when I launch it, by default, it just shows the image to be cropped in a white activity devoid of any buttons / toolbar.  I've tried the different settings in CropImageOptions, but none of them seem to show any buttons / toolbar.
Here are the settings I've tried:
imageCropper.launch(
    CropImageContractOptions(
        uri = uri,
        cropImageOptions = CropImageOptions(
            cropShape = CropImageView.CropShape.OVAL,
            aspectRatioX = 1,
            aspectRatioY = 1,
            fixAspectRatio = true,
            outputCompressQuality = 75,
            backgroundColor = Color.MAGENTA,
            activityBackgroundColor = Color.BLACK,
            toolbarColor = Color.BLUE,
            toolbarTitleColor = Color.WHITE,
            toolbarBackButtonColor = Color.CYAN,
            toolbarTintColor = Color.RED,
            activityMenuIconColor = Color.GREEN,
            activityMenuTextColor = Color.GREEN,
            showCropLabel = true,
            multiTouchEnabled = true,
            activityTitle = "Hello",
            cropperLabelText = "It's me"
        )
    )
)

As you can see from the screenshot below, there's no toolbar or any button to confirm the crop.  The activityTitle also does not show, which seems to indicate that there indeed is no toolbar.

Just roll your own activity.

Then maybe remove those parameters?  toolbarXXX, activityMenuXXX would lead people to believe that those actually do something.

Trying to save the world, in your app AndroidManifest.xml, just add:
        <activity android:name="com.canhub.cropper.CropImageActivity"
<EMAIL_ADDRESS>
Crop tools should then display fine.

@vanniktech Atleast Add some example to roll own activity. Also Add disclaimer in notes with Bold Letters. I wasted 2 hours for this. Because I am using No Action bar Activity Theme in App. Now these days all the devs using this practice.

https://github.com/CanHub/Android-Image-Cropper#2-using-cropview


Lower lockbot timeframe and add comment.

Resolves #849.

Description
The reasoning here is that some older tickets in the conda org have been waiting to be locked for a long time. We need to point out to new participants that there is a way forward instead of piling on, especially if the old issues were open-ended and no decision was made in the past. It's worth opening new issues instead.

We removed the lockbot comment to decrease noise: https://github.com/conda/infrastructure/issues/547

@kenodegard is it still worth lowering the timeout for locking closed issues?

A whole year is probably overkill so lowering it makes sense but a month feels a little short (especially since our releases are bi-monthly). Maybe 3 or 6 months?
As for the lockbot comment, I'm pretty sure we should not add that back.

A whole year is probably overkill so lowering it makes sense but a month feels a little short (especially since our releases are bi-monthly). Maybe 3 or 6 months?
As for the lockbot comment, I'm pretty sure we should not add that back.

Okay, I've used 180 days.


Upgrade to version 2 zipkin format?

It seems likely that we are having issues due to data format here: https://github.com/apache/incubator-skywalking/issues/1495#issuecomment-408727598
Can you consider moving to v2 format or using https://github.com/openzipkin/zipkin-php? It is easy for people to get this wrong.. many use v2 by default. Eventhough the server can read both formats, people get the endpoint wrong.

already support zipkin v2 format, user can set molten.span_format=zipkin_v2

resolved


Should pure use the new PureComponent?

https://github.com/facebook/react/pull/7730

As I understand It will lock recompose on specific React version.
For now I use it in a big project with old React 0.14.x and it works well.
BTW Im not sure about React version support politic.
Sometimes it will be easier to drop old versions support but it will be a problem
for me if sometimes is today :-)

PureComponent check both props and state. In contrast, pure check only props, so it might be quicker.

I think pure should stay as it is. First due to what @wuct sad.
2nd - pure is HOC, while PureComponent is full Component that you most likely going to use as class My extends React.PureComponent.  To me this a bit different scenario of usage.
Unless PureComponent has some dramatic advantages in usage it does not make sense for me to deprecate  or rework pure

@dlebedynskyi pure HOC could be rewritten to use React.PureComponent and will have a really short source, so 2 is not so different ;-)

@istarkov  well yeah. But why does it has to be rewritten? it is not like is working wrong now.

For fun for example, a good reason as I know ;-)

@istarkov  it is your repo guys) go for it if you really think it is needed )


added rbd install instructions and ceph admin secret consistency

added rbd install instructions to fix #1256
added consistency between cephfs and rbd to use the same ceph admin secret

/assign @cofyc

/lgtm
/approve
Thanks!


LAB_02b-Manage_Governance_via_Azure_Policy.md.pdf

English:
Create and assign tags via the Azure portal
Current Translation:
Créer et attribuer des balises via le portail Azure
Suggested Translation:
Créer et attribuer des étiquettes via le portail Azure
Description:
For consistency puroposes. Inconsistent translation of tags, tagging, tagged

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Run bugfix tool and waiting for result. ICMS QUERY.


Abstract type deserializer settings not taken into account

If I have a class
@JsonDeserialize(as = SomeConcreteClass.class)
public class SomeAbstractClass {
    public String getSomeProperty();
    public String getSomeOtherProperty();
}

public class SomeConcreteClass {
    public Object getSomeProperty();
}

   @JsonCreator
   public SomeConcreteClass(
        @JsonProperty(value = "someProperty", required = true) Object someProperty
    ) { ... }
}

the schema should take into account that the object cannot be deserialized without someProperty and mark it as "required". Currently it does not.

Please provide test-case showing the problem.

I am sorry that it took me so long to get back to you.
Today I recreated the issue I saw one year ago, and while I realized that there were some issues in the code above, the case is still valid with the current version of Java (14), Jackson (2.9.6) and jsonSchema (1.0.39).
Below you can find the working code of a fairly minimal example
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;

@JsonDeserialize(as = SomeConcreteClass.class) //the class for deserializing the json to requires someProperty
public abstract class SomeAbstractClass {
    public abstract String getSomeProperty();
    public abstract String getSomeOtherProperty();
}

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;

public class SomeConcreteClass extends SomeAbstractClass {

    private final String someProperty;
    private String someOtherProperty;

    @JsonCreator
    public SomeConcreteClass(@JsonProperty(value = "someProperty", required = true) String someProperty) {
        this.someProperty = someProperty;
    }

    public String getSomeProperty() { return someProperty; }

    public String getSomeOtherProperty() { return someOtherProperty; }

    public void setSomeOtherProperty(String someOtherProperty) { this.someOtherProperty = someOtherProperty; }
}

When generating the json schema like so:
ObjectMapper mapper = new ObjectMapper();
JsonSchemaGenerator schemaGenerator = new JsonSchemaGenerator(mapper);
Class<SomeAbstractClass> clazz = SomeAbstractClass.class;
JsonNode node = schemaGenerator.generateJsonSchema(clazz);

the result contains "someProperty":{"type":"string"}. However, it should also state "required":["someProperty"], as the only possibility to deserialize a json to SomeAbstractClass is to deserialize it to SomeConcreteClass which requires someProperty to be present.


sst_importer: add wire extra bytes into the packed size

What is changed and how it works?

Issue Number: Close #14313
What's Changed:
This PR added some extra bytes for each modification, so the unpacked_size would be nearer to the real raft entry size.

Check List
Tests

Manual test (add detailed scripts or steps below)

I have tested it in the internal cluster, if you are a PingCAP employee, you can check it at here. There aren't suitable screenshots to be published, sorry for that.
And I guess this can also be checked by any table with average row size less than 70B (see the comments), but for now I don't have suitable cluster for running such tests...
Release note
None

(This is a fix over the master branch.)

Better add a test.

Maybe we should let the engine to tell the size of modification. In raftkv2, writes are encoded using more simple codec and can batch up more modifications than v1.

@BusyJay I agree the idea of letting the engine provide some way to calculate "real size" of some write, and I think before we figuring out some ideal interface definition, perhaps we can merge this for solving the problem we have encountered now?

LGTM

/merge


Hello rails react backend app

In this PR I did the following:
Create a new Rails API app called 'hello-rails-back-end'.
Initialize your project with Git.
Make sure that your project has a Postgres database set up.
Create a table for storing your messages and create 5 different greetings.
Create an API endpoint that selects a random greeting from your table (you will need a controller with an action and rails route).

Project Status: INVALIDATED :red_circle:
Hi @mudasiri ,
While you made a great effort in this project, I can't go ahead and review your code.

Invalid Code Review Request

This is because you have submitted a project, that has the link to the frontend leading to an error page. However, per the project requirements, you should ensure that you add the link to the frontend of your project in the README and ensure that a Pull Request is created in the Frontend Repo as well :+1:
Project Requirement

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @NahnahAJ in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Change a (test) matrix via molecule.yml

Issue Type

Feature request

Molecule and Ansible details
molecule --version

2.16.0

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Desired Behavior
I'm ansible-galaxy install SeleniumHQ.selenium role, which is in fact an ansible module. And one of my task is
- name: Run Selenium server
  selenium:
    role: standalone
    state: running

Running molecule, I got the puzzling
Couldn't parse task at /vagrant/ansible-role-robotframework/tasks/main.yml:25 (no action detected in task. This often indicates a isspelled module name, or incorrect module path.

The error appears to have been in '<unicode string>': line 25, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

(could not open file to display line))
{ 'name': 'Install Selenium',
  'selenium': { '__file__': '/vagrant/ansible-role-robotframework/tasks/main.yml',
                '__line__': 26,
                'role': 'standalone',
                'state': 'running'}}

Until I understood, I've to molecule dependency before anything else. My immediate problem's solved, I updated my test pipeline & my doc to do that. But I'm 99% sure the next guy is gonna have the same issue trying to dev my role or another alike.
So what I'ld like to do is to keep on using molecule test everywhere, and define my scenario matrix in molecule.yml roughtly like this
...
scenario:
  name: default
  matrix:
    test:
    - dependency
    - lint
    - destroy
    - syntax
    - create
    - prepare
    - converge
    - idempotence
    - verify
    - destroy
...

I don't know if that's a feature worth the time and it's not an issue for me anymore, but maybe others will second it.

I am not sure I understand. You want to customise the matrix for the test sequence?  molecule dependency is already run under the molecule test sequence. Chaing the sequence is documented via https://molecule.readthedocs.io/en/latest/configuration.html#scenario.

... Hell, this is exacty it.
So yeah, my need is to run molecule dependency BEFORE lint, and I can do that like this
scenario:
  name: default
  test_sequence:
    - destroy # destroy before dependency
    - dependency # dependency need to be first since we install a module (selenium) via ansible galaxy
    - lint
    - syntax
    - create
    - prepare
    - converge
    - idempotence
    - side_effect
    - verify
    - destroy

Maybe there ought to be a hint about that in the molecule matrix usage / doc, this is the first thing you're looking for whenever the test matrix is wrong for your use case. In my humble opinion.
Thanks @lwm !

Maybe there ought to be a hint about that in the molecule matrix usage / doc, this is the first thing you're looking for whenever the test matrix is wrong for your use case. In my humble opinion.

Submit that PR! :fire: :fire: :fire:


X509_NAME: Fix encoding of_NULL-DN in x509_name_canon()

See analysis in https://github.com/openssl/openssl/pull/14589#discussion_r610892756.
This corrects and simplifies use of the canon_enc field in X509_NAME_cmp().
Fixes #14813.

Withdrawn in favor of alternative #14832.


tooltip text needs tiny edit

On the map view, the small calendar icon near the date menu:
"Go to the latest date for which [signal name] is defined"
should be
"Go to the latest date for which [signal name] is available".

How about "...for which data is available", if that is what it is supposed to mean.

@dlaliberte sorry, my original comment had text in angled brackets which the markdown expunged.  I edited it now to square brackets.

should have been fixed with #613


PhantomJS tests for the visualiser javascript.

These tests check that the visualiser displays the correct number of DONE/PENDING/FAILED/etc. tasks using PhantomJS.  The Python unittest starts PhantomJS in a subprocess whilst running the tornado IOLoop in-process.  I use an implementation of MergeSort to populate the scheduler with a medium-sized task-graph.

This is super cool!
We should probably set it up as a separate set of tests in Travis but other than that, looks awesome! I have been thinking about building something similar for a long time but didn't know where to start.

OK, I'll refactor as a separate travis run.  Travis went OK on my fork but it looks like it's been hit by the KeepAliveThread problem mentioned in server_test.py.

Hey @stephenpascoe ! I tried running this locally, and I can't get it to run. Both via tox -e visualiser and nosetests -v --tests=test/visualiser. I get the same FAIL issue, I think this is the relevant log:
===== Luigi Execution Summary =====

/bin/sh: phantomjs: command not found
FAIL

======================================================================
FAIL: test (visualiser.visualiser_test.TestVisualiser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/lynnroot/.pyenv/versions/luigi-27/lib/python2.7/site-packages/tornado/testing.py", line 132, in __call__
    result = self.orig_method(*args, **kwargs)
  File "/Users/lynnroot/Dev/spotify/luigi/test/visualiser/visualiser_test.py", line 63, in test
    assert status == 0
AssertionError:
-------------------- >> begin captured stdout << ---------------------
Server port is 51877
Starting phantomjs
Entering event loop
PhantomJS return status is 127
--------------------- >> end captured stdout << ----------------------

Also I'm not too familiar with PhantomJS so perhaps I'm missing a piece of setup.

I'm guessing it's installed by default on Travis but not locally.
I don't think we can enforce installing it so maybe we should disable it by default when running locally and enable it on Travis

ah yes looking at this random Travis job it looks like PhantomJS is installed. Which actually is surprising since - from what I can tell - it isn't declared in the .travis.yml as a dependency. But perhaps we get that "for free".
@stephenpascoe I'd actually suggest having a script in scripts/, similar to scripts/ci/setup_hadoop_env.sh to download & install PhantomJS. @erikbern what are your thoughts on that?

if it's easy to install phantomjs then sure (i suspect unfortunately it's not)

Hmm it does seem like it may be a bit complicated: docs - especially since it says it takes a long time to build, and it is dependent on the system (and simple linux binaries are not yet available). Perhaps thoroughly documenting how to run tests locally in CONTRIBUTING.rst or somewhere.

Also after brew install phantomjs tests pass \o/

Yes, PhantomJS is installed on Travis and is pretty easy to install on unix.  We could skip if phantomjs is not available but that risks missing the tests without realising it.

Travis failed :( It passed in my Travis build (https://travis-ci.org/stephenpascoe/luigi) but there is a timeout in the test that might have been exceeded.  I'll look into making it less fragile.

@stephenpascoe before we merge, how would you feel about adding a line or two to CONTRIBUTING.rst on needing to have PhantomJS installed?
Also mind squashing commits into one?

i think it's good as it is and i'm happy to merge but will give it another day or so

looks awesome!
https://travis-ci.org/spotify/luigi/jobs/92008229


undefined method `image_metadata' for nil:NilClass

I am using attachinary with rails 4.1.1 , but stuck with this issue and not able to solve it, can someone please guide me how to fix this issue...
This error come from: form.html.erb page
<% form_for :Book do |f| %>
<%= f.attachinary_file_field :image %>
<%= f.submit %>
<% end %>

Hi @anknet
This probably means that you didn't use has_attachment in your model to define the image field.
For example:
class Book < ActiveRecord::Base
  has_attachment :image
end

I have the same problem, and I have the field defined in my model :(

I ran into this issue with rails 4.2.  The error reports f. is nil. Seems like a bug in attachinary, I didn't really look into it though.  It appears that the association is not being built for new objects, which means you have to use:
attachinary_file_field_tag 'topic[images]', @topic, :images
instead of
f.attachinary_field_field
it will work!

Problem also arises when using the fields_for helper. Attachinary gets to here:
# attachinary-1.3.1/lib/attachinary/view_helpers.rb @ line 7

def builder_attachinary_file_field_tag(attr_name, builder, options={})
  options = attachinary_file_field_options(builder.object, attr_name, options)
  builder.file_field(attr_name, options[:html])
end

But builder.object will be nil when using fields_for.

Any updates on this? I would love to know how to have an attachinary field on an association in a fields_for block.

@scott Your method worked for me as well. I changed my = f.attachinary_file_field :avatar to = attachinary_file_field_tag 'room[avatar]', @room, :avatar and it appears to be working now. At least it cleared the error. Now I have to work at getting the image to display after upload.
Thanks for the suggestion. Seems to have saved me a ton of work and headaches.

UPDATE: So for my instance it turned out that it wasn't the attachinary_file_field that was to blame. When I changed the architecture for my model to belong to a parent organization my form paths got messed up. Despite the fact that I was pointing to organization_room_path , when I inspected the form in the browser my form url was set to the edit path instead of the update path. When I submitted my form each time it would simply refresh the page.
I had to change my form_for structure like this:
OLD:
= form_for organization_room_path, html: {class: 'my-class-here'}
NEW:
 = form_for @room, url: organization_room_path, html: {class: 'my-class-here'}
I hope this helps someone else in a similar situation.


Master -> Live

Docs Build status updates of commit 9e9e987:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mr-dev-days-sessions.md
:white_check_mark:Succeeded
View

mixed-reality-docs/system-gesture.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 2c66c89:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mr-dev-days-sessions.md
:white_check_mark:Succeeded
View

mixed-reality-docs/system-gesture.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Transformation of overdisp parameters for tag negative binomial likelihood

Currently parameters for overdisp for tag negative binomial likelihood are directly used for tau of log_density_negativebinomial function of ADMB.
This function requires tau > 1.
If overdisp is calculated using a transformation
E.g.
overdisp = 1 + exp(parm)
overdisp can avoid potential error related to tau, although this change inevitably cause problem for existing models using tag data

Hi Yukio,
I suppose that both this alternative parameterization and the standard one could be offered as alternatives available rather than force all users to make a change. However, I'm curious if you think that the overdispersion parameter can be reasonably estimated from the data available. My memory from working with a tagging model long ago is that was inadequate information and the overdispersion parameter either went to the lower bound (something like 1.0001) or got really large. If users are always fixing these parameters, the parameterization doesn't matter for estimation and the status-quo parameterization is easier to interpret.
Perhaps @puntae has some thoughts on estimability and parameterizing overdispersion in negative binomial: would we be better off using overdisp = 1 + exp(parm).
-Ian

Sorry folks I am being asked to comment on an alternative but I am not
seeing it?
On Thu, Mar 10, 2022 at 8:02 AM Ian Taylor @.***> wrote:

Hi Yukio,
I suppose that both this alternative parameterization and the standard one
could be offered as alternatives available rather than force all users to
make a change. However, I'm curious if you think that the overdispersion
parameter can be reasonably estimated from the data available. My memory
from working with a tagging model long ago is that was inadequate
information and the overdispersion parameter either went to the lower bound
(something like 1.0001) or got really large. If users are always fixing
these parameters, the parameterization doesn't matter for estimation and
the status-quo parameterization is easier to interpret.
Perhaps @puntae https://github.com/puntae has some thoughts on
estimability and parameterizing overdispersion in negative binomial: would
we be better off using overdisp = 1 + exp(parm).
-Ian
—
Reply to this email directly, view it on GitHub
https://github.com/nmfs-stock-synthesis/stock-synthesis/issues/273#issuecomment-1064220291,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMXZHWNGHMHRDHKORVLCI3U7IMLBANCNFSM5QLHLRPQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Andre E Punt (he, him, his)
Director: School of Aquatic and Fishery Sciences
College of the Environment
University of Washington
206-221-6319 (O) [Not checked regularly at present]
@.***
http://fish.washington.edu/people/punt/
http://puntlab.washington.edu/
*I often send emails early in the morning and over weekends to achieve my
personal work-life balance. Responses are never expected outside normal
working hours. *

Sorry, @puntae for the inadequate context.
The status-quo parameterization of the negative binomial likelihood for tagging data in SS3 has the overdispersion parameter specified directly.
ADMB requires that parameter to have overdisp > 1, so when you created a Gummy Shark model with tagging data in SS3 long ago, you set the overdispersion parameter bounds at 1 and 100 and fixed the values at 1.001:
(as in this model based on that work: https://github.com/nmfs-stock-synthesis/test-models/blob/main/models/tagging_mirrored_sel/control.ss#L578-L580)
@yukio-takeuchi suggested that we could reparameterize as overdisp = 1 + exp(parm) to avoid the lower bound issue, but noted that a change in parameterization would either add complexity or break backwards compatibility, so it seems worth judging whether the benefits are worth the effort.
I believe the SS3 tagging likelihood can trace its origins back to your School Shark model from 22 years ago, so that makes you an expert by default, but I realize that was a long time ago.
Have you ever successfully estimated the negative binomial overdispersion parameter? It might be slightly easier in the current setup of SS3 where those parameters can be mirrored across tag groups.

I wish I had done it this way from the beginning, but seems little benefit today.  Yukio - is it because your system requires use of unbounded parameters?  I would prefer to save this change until somebody?? launches into the long requested major re-work of the tag-recapture module.

HI Folks,
What I did 22? years ago is not a great status-quo approach for anything.
That said I agree with Rick that a wholesale rework on the tagging approach
(part of FIMS M2) would seem the way forward - I agree with the 1+exp(par)
approach in principle even if it has par -> -Inf to get the limit - but I
would not change SS now to make a minor fix when major fixes are needed.
Andre
On Thu, Mar 10, 2022 at 9:21 AM Richard Methot @.***>
wrote:

I wish I had done it this way from the beginning, but seems little benefit
today. Yukio - is it because your system requires use of unbounded
parameters? I would prefer to save this change until somebody?? launches
into the long requested major re-work of the tag-recapture module.
—
Reply to this email directly, view it on GitHub
https://github.com/nmfs-stock-synthesis/stock-synthesis/issues/273#issuecomment-1064308880,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMXZHVJYQKSWHDFWVDK37DU7IVRXANCNFSM5QLHLRPQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Andre E Punt (he, him, his)
Director: School of Aquatic and Fishery Sciences
College of the Environment
University of Washington
206-221-6319 (O) [Not checked regularly at present]
@.***
http://fish.washington.edu/people/punt/
http://puntlab.washington.edu/
*I often send emails early in the morning and over weekends to achieve my
personal work-life balance. Responses are never expected outside normal
working hours. *

Even though I created this issue, I agree with keeping current parameterization of overdisp = parm for SS.
On the other hand, is it possible to insert an “error  check” code when tag overdispersion parameter block of control file is read to check if it is larger than 1?

Great idea.


Add the possibility to configure custom headers globally

So far, this library allows to specify two global configuration params:

log_query_on_error
log_response_on_error

It would be nice to have the possibility to specify custom headers to be used on every bridge. For example, we've been using the pattern of adding the service' name in a custom header, which is particularly useful when grepping calls in load balancer logs (i know there is opentelemetry for this, but our current retention time and filtering features are not on par with the ELK stack)

it actually lets you to configure custom headers on single bridges, however you can set a global config, then refer to it when defining the bridge. Yes, it's bit more verbose (and repetitive), but it's also more explicit and declarative.
considering the nature of this library (exposing helpers to build bridges for several endpoints), I suspect that making a config like that as implicit might be more error prone.
IMHO, having global configs for logging makes sense, but I'd avoid the same approach for headers to use in bridge.

it actually lets you to configure custom headers on single bridges, however you can set a global config, then refer to it when defining the bridge. Yes, it's bit more verbose (and repetitive), but it's also more explicit and declarative.
considering the nature of this library (exposing helpers to build bridges for several endpoints), I suspect that making a config like that as implicit might be more error prone.
IMHO, having global configs for logging makes sense, but I'd avoid the same approach for headers to use in bridge.

sorry, i completely missed your reply... fair enough for me, you are right :+1:


Add GTM Datacenter support to the SDK

@zancas @wojtek0806 @pjbreaux
What issues does this address?
Fixes #497
What's this change do?
This change provides support for the GTM Datacenter API. It uses
exclusive mixins to allow users to specify either the 'enabled' or
'disabled' attributes and handles their mutual exclusion appropriately
Where should the reviewer start?

test/functional/tm/gtm/test_datacenter.py
f5/bigip/tm/gtm/test/test_datacenter.py

Any background context?
The SDK does not support the GTM datacenter API

Nice docstring.


dynamo: AttributeBase does not include name property

Describe the bug
AttributeBase and its subclasses do not include the name property in stubs
To Reproduce
Steps to reproduce the behavior:

Install boto3-stubs[dynamodb]
Run mypy/pyright on the following code sample

from boto3.dynamodb.conditions import Attr

a = Attr(name="my_field")
a.name
...

Actual output
mypy issue.py
issue.py:4: error: "Attr" has no attribute "name"  [attr-defined]
Found 1 error in 1 file (checked 1 source file)

Expected output
mypy issue.py
Success: no issues found in 1 source file

Additional context
Your OS, boto3-stubs installation method, boto3 version, etc.

@fivepapertigers thank you for your contribution. I am going to prepare a new release ASAP.

@fivepapertigers I just released a new version of mypy_boto3_builder, and mypy-boto3-dynamodb 1.28.73 with the fix included.
Please update and let me know if it works as it should. Thank you for the PR again, I added you to the contributors list.


ftplugin(python): Fix bad define regex

Thanks to @zeertzjq

thanks, I merge it now.
FTR: In the future you may want to consider using :let syntax, see :h :let-& so you don't need to escape the \ anymore:
let &l:include='^\s*\(from\|import\)'
let &l:define='^\s*\(\(async\s\+\)\?def\|class\)'


Add auto-update attributes for cdnjs

This would just add attributes that allow a package to be auto-updated if added to cdnjs: https://github.com/cdnjs/cdnjs/blob/master/CONTRIBUTING-WIP.md#2-configure-auto-update

Cool, thanks


Fix failing token decryption unit test

What is the context of this PR?
This fixes the intermittent issue we get in one of our unit tests. Since we use the same app context for multiple tests that decrypt token, shared across the unit test class as a property, the solution is to tear down the app context between tests.
How to review
Run tests locally and in actions as part of build. To speed it up remove all irrelevant jobs from pull_request.yaml and only install python dependencies and unit tests.
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

I ran actions in a draft PR and it failed once out of 15 times, not sure if there's a further underlying issue? https://github.com/ONSdigital/eq-questionnaire-runner/actions/runs/9503668920/job/26234364306?pr=1394

I ran actions in a draft PR and it failed once out of 15 times, not sure if there's a further underlying issue? https://github.com/ONSdigital/eq-questionnaire-runner/actions/runs/9503668920/job/26234364306?pr=1394

Yeah I saw that and also had the same error again locally and in actions, so have to tackle it differently since setting up the app and tearing it down doesn't fix it.

The unit test job in actions passed 15 consecutive times now after we've added the new fix.


Update PulseIlluminationShader to Foundry VTT 0.7.9

Which class should be updated?
PulseIlluminationShader
For which version should the class be updated?
Foundry VTT 0.7.9

taking this

Fixed by #276


1.20.1 server crashing on startup

Modloader
Forge
Minecraft Version
1.20.1
Modloader Version
47.0.3
No Chat Reports Version
1.20.1-v2.2.1
Modpack Info
No response
The latest.log File
https://pastebin.com/YERBTs5m
Bug Description
server crashes on startup, does not crash if nochatreports is removed
Steps to Reproduce
No response
Other Information
No response

It looks like there is an issue with the config file:
[25Jun2023 01:19:37.709] [modloading-worker-0/FATAL] [NoChatReports/]: Could not read config file: C:\Users\User\Desktop\Storage\1.20 test\config\NoChatReports\NCR-Common.json
[25Jun2023 01:19:37.710] [modloading-worker-0/FATAL] [NoChatReports/]: This likely indicates the file is corrupted. You can try deleting it to fix this problem. Full stacktrace below:

Like it says in the logs, you can try to delete the file mentioned to see if that helps. If it doesn't, you can use version 1.20.1-v2.2.2 which I just released to hopefully get more information in the log.

tried the same setup on a fresh server with no preexisting config files on 2.21 and still got a crash but upgraded to 2.2.2 and the server no longer crashes


Investigate TODO comment in DropAction fault regarding "limit"

As commented on here by @AndyTWF.
The comment might be inert or otherwise unimportant, but in the interests of getting the aforementioned pull request merged adding this issue to defer looking at this until later.

@jaley has made a summary of the issue: https://github.com/ably/ably-asset-tracking-android/pull/933#discussion_r1083903659


chore: generate ts declarations

This PR adds a post-build step to the Makefile to generate typescript declaration files.
Closes: #8

@filahf shouldn't we reference the types in pkgjson https://www.typescriptlang.org/docs/handbook/declaration-files/dts-from-js.html#editing-the-packagejson ?

I think it might be redundant when the declaration is next to the file. And since there are multiple entry points, I'm unsure what that reference should be. TS seems to have no problem finding the types as it is

ideally, would be great to npm run build && npm run copy then in a new TS project npm i the dist generated folder

Yep that's what I've done locally. I made a new TS project and symlinked the dist folder by pnpm link ../assets/dist/

Yep that's what I've done locally. I made a new TS project and symlinked the dist folder by pnpm link ../assets/dist/

so we are good to go :)
ready for merge?

I'm ready, thank you!

there had an error when generating types:
https://github.com/pmndrs/assets/actions/runs/11001199403/job/30545314325#step:5:3235
can you see this?

I might've forgotten to update the lockfile. Could that be the reason?

I might've forgotten to update the lockfile. Could that be the reason? Does it work for you locally?

yes totally because of the npm ci typescript is probably missing

Yea makes sense, sorry about that. I'll post another pr for the lockfile

no problem really
but I reverted, can you create another full PR?

for info, I've checked, the repo still use yarn v1
can you install yarn v1 to yarn add -D typescript ?


Prepare for Spring Cloud Azure 4.13.0 release

Description
Prepare for Spring Cloud Azure 4.13.0 release
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Moved closing div to wrap content on off-canvas

The example had the closing off-canvas tag before the off-canvas-content so the toggle example would not work correctly.

The existing example is correct; the menus are siblings of the content wrapper. You can see in our documentation layout how this works.


What's the status on supporting WebGPU and WGSL?

The README currently says:

Currently only SPIR-V support is planned, Vulkan's open compiler target
Possible a future version could support DXIL (the target for DirectX) or WGSL (the WebGPU shading language that's bijective with SPIR-V)

Right now I'm working on Vello, a 2D graphics engine implemented on top of wgpu. We won't even consider an alternative which is Vulkan-only.
Is WebGPU support in the pipeline? Any idea if or when it will happen?

We support wgpu, both native (passed through to vulkan) and on the web (using naga to translate). Some of the examples in the repo use it and we have run some on multiple platforms including web and Android.
I don't believe there are any plans for the compiler backend to output anything other than spir-v, especially with MS switching to spir-v for directx (https://devblogs.microsoft.com/directx/directx-adopting-spir-v/) and naga existing.
That being said, we have an experimental IR which may allow us to directly do the translation naga does internally in the future if it makes sense (https://github.com/Rust-GPU/spirt).
@eddyb can correct me if I am wrong as I am still new to the project.

My project renderling uses rust-gpu and wgpu and targets WebGPU on web. naga is pretty capable of translating SPIR-V into WGSL, and I've done some work to make it more capable. There is still work to be done in wgpu+naga but most shaders compile and validate easily. Let me know if you want to get into the specifics - I can tell you if I think your shaders will work.


Video beta

This is a draft PR showing the new Vonage Video API implementation

Codecov Report

Merging #224 (c990245) into main (a0be3c2) will increase coverage by 0.25%.
The diff coverage is 97.95%.

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   97.44%   97.69%   +0.25%
==========================================
  Files          15       16       +1
  Lines         469      564      +95
==========================================
+ Hits          457      551      +94
- Misses         12       13       +1

Impacted Files
Coverage Δ

src/vonage/client.py
96.05% <94.44%> (-0.22%)
:arrow_down:

src/vonage/video.py
98.71% <98.71%> (ø)

src/vonage/errors.py
100.00% <100.00%> (ø)

src/vonage/messages.py
100.00% <0.00%> (+1.88%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxkahan Please do not merge this into main but maintain a separate branch for now.

@dragonmantank Have made your suggested changes


Add latest and final changes from BrainName [sf#18]

Reported by mmc46 on 2013-10-10 13:04 UTC

Updated by mmc46 on 2013-11-08 12:09 UTC

status: open --> closed


Checks timeout, probably waiting for a connection to primary

The check code uses all the app IPs to find the primary. I think this might be causing some of the check timeouts, it would be quicker and hopefully less brittle to use IPs from the primary region only.

Agreed, I have a refactor in progress that should address this.  Also, i'm thinking we could probably just pull leadership information from the secondary itself.  We can resolve leadership information by running show primary_conninfo; on the secondary, or if we wanted to be super quick about it we could yank it from the postgresql.conf file itself.

I made quite a few optimizations on this front.  While we may continue to see timeouts occasionally, but we will at least be provided with details as far as what exactly timed out.
If it's a particular check that caused the timeout, we will see a checkout output that looks something like:
[✓] transactions: readonly (239.05µs)
[✗] replication: Timed out (9.99s)
[-] connections: Not processed

If we see a connection timeout before the checks are processed, we will see the same old "Context deadline exceeded", except it will have some additional information pertaining to the node it's failing to connect to.
These changes are available in the latest PG12/PG13 images.


Add tsc-generated type definitions for opt-in

Our type definitions and the TypeScript compiler feature to generate *.d.ts files from them are quite mature now, but not yet ready for prime time. Other than last time we started including types, where users were no longer able to use @types/ol instead, I'd like to include them in a separate directory now, so users can opt in to use them.
Opt-in is easy and explained in the README:

When authoring in TypeScript, we recommend you try out the types that are included in the ol package. To use these types, make sure you have the following entry for @types/ol in your package.json's devDependencies section:
{
...
  "devDependencies": {
    ...
    "@types/ol": "file:node_modules/ol/types",
    ...
  }
}

This way, we can encourage users to start working with the built-in types, and when we feel our type definitions are complete, we can include them directly along with the modules.
I also updated the README with a paragraph about applications that want to use our untranspiled ES6 code.

Thanks for the work on this @ahocevar! It is great that finally again openlayers can provide automatically generated declarations - not perfect, but usable. And this will probably soon reveal any major issues about the generated declarations.


Feature: always

Add always callback firing after then or catch callback

That feature should be in your preferred choice of Promise library, not in Axios. One example of a library that supports this is Bluebird, but there are many other options.


A popup message about an achievement appears three times

Hello. It looks like I've found a bug. For some reason, a popup message about an achievements appears three times at once. Here is a screenshot: http://data2.floomby.com/files/share/3_2_2016/20/Rhw1LiPkjkidULwatQij3Q.jpg I use Firefox 44.0.
P.S.: Thank you for this wonderful game )

Probably related: #3242

Maybe CocoModel.pollAchievements is happening too often?


Delayed job daemon forcefully closes all udp file descriptors under port 8192

In my rails app I am using statsd to report metrics. The reporting works in any model/controller that runs in the main rails process. The reporting also works when using the work_off rake task.
When using the delayed job as a daemon it does not work. It seems that the Daemon gems closes off all udp file descriptors (in port 1 to 8192) when the worker thread is being created.
This means a lot of things will not work out of the box, like statsd.
Is there a way around this (other than reconnecting for every job)?

You don't need to reconnect for each job, you just need to reconnect after
the worker forks. There isn't a lifecycle hook exposed for this so
currently the only way to do it is to monkey patch
Delayed::Worker.after_fork (in the alias_method_chain style) and append
your own behavior.
On Sat, Dec 17, 2016 at 8:59 AM Guy<EMAIL_ADDRESS>wrote:
In my rails app I am using statsd to report metrics. The reporting works in
any model/controller that runs in the main rails process. The reporting
also works when using the work_off rake task.
When using the delayed job as a daemon it does not work. It seems that the
Daemon gems closes off all udp file descriptors when the worker thread is
being created.
Is there a way around this (other than reconnecting for every job)?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/collectiveidea/delayed_job/issues/960, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AABZ-NT6JgCBclPgTRPCrEb0wE_2fRv8ks5rI-rXgaJpZM4LP5Kq
.

I think I may be experiencing a very related issue:
When trying to change the logger for DelayedJob, to a logger that uses UDP, I am getting an error saying RemoteSyslogLogger::UdpSender error: IOError: closed stream.
Could this be related? If so, any word as to how to overcome this?
This is the related StackOverflow question if it is of any interest.

Closing stale


Make sharding function configurable

"buf breaking" lint is complaining:

apple/swift_homomorphic_encryption/pir/v1/pir.proto:58:1:Previously present reserved range "[4]" on message "KeywordPirParameters" is missing values: [4] were removed.

But this is fine: we intentionally reserved tag 4 for the message that we now added.


Config entry from integration weatherflow_forecast has an invalid unique_id of type int

Describe the bug
Error in logfile:
2024-12-01 14:11:10.081 ERROR (MainThread) [homeassistant.config_entries] Config entry 'xxx' from integration weatherflow_forecast has an invalid unique_id '12345' of type int when a string is expected, please create a bug report at https://github.com/briis/weatherflow_forecast/issues

To Reproduce
Restart integration
Expected behavior
No errors

It seems to have lost some entities

I did edit all the not available ones out...sorry, I didn't make a note of what changed!

I also had this message during initial startup when installing WeatherFlow on a new home assistant supervised installation:
2024-12-23 10:40:15.042 INFO (SyncWorker_3) [homeassistant.util.package] Attempting install of pyweatherflow-forecast==1.1.0
2024-12-23 10:42:21.092 ERROR (MainThread) [homeassistant.config_entries] Config entry 'Rottino Dr' from integration weatherflow_forecast has an invalid unique_id '146439' of type int when a string is expected, please create a bug report at https://github.com/briis/weatherflow_forecast/issues
2024-12-23 10:42:21.092 ERROR (MainThread) [homeassistant.config_entries] Config entry 'Rottino Dr' from integration weatherflow_forecast has an invalid unique_id '146439' of type int when a string is expected, please create a bug report at https://github.com/briis/weatherflow_forecast/issues


Create floating chat

Add a small chat like button at the right corner of the screen (movable in the future)
When the user clicks the button a chat with Anna and the user starts, every conversation between user and Anna will be there from that moment.
This issue requires one to just make the front end of the problem.

The idea is user should be able to see a floating chat at his screen all the time.

What type of conversation will be there between user and anna. And what is the expected output from Anna (action and text).

we only need anna to say things to user for now.
This line https://github.com/Anna-Assistant/Anna/blob/master/background.js#L276 is said back to user now.
I was thinking the same text will be shown to the user.

This issue is still unsolved. We are looking for an intercom like chat instead of the current status symbol.
As Anna replies something, the chat bubble should say what anna says.


feature_store & graph_store V1

What do these changes do?
Step 1: Implement GraphScope-based PyG Remote Backend and complete the end-to-end integration of GraphScope and PyG. (Finished)
Step 2: Get data from the Server through PyG Remote Backend and support sampling on the Client side. (Not yet)
Related issue number

PyG Remote Backend Based on GraphScope #3739

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Yi-Eaaa Could you make sure that the PR-Check has passed?


[WIP] Add a script for porting data to the new models

To Do:

[x] Add a framework for porting data according to a json object.
[ ] Make the script create tables if not existing.
[ ] Add transformation data.
[ ] Add cleaning techniques to data.

Kind of addresses #46

@UtkarshMe Lodash provides excellent functionality to do these kinds of data structure manipulations. See if it suits your needs.

Makes #50 redundant.

Read the documentation in the README to populate config.js

Great work! From what I can comprehend, I feel that the user doesn't need to fiddle with the rules, which the script is already taking care of. I changed the other required variables, still, porting is not working for me.

Did you switch off the debug? Also, the script ports according to the models.sql file in src/data. Check if the ones in your database are same or not. Create a new DB and try?


Update mvc3.md; Updated download link

Actualized "Download the [installer here]" link

@Andrey-Kovtun Thank you for updating the link.

I was glad to make my modest contribution :)


Replace audio backend with miniaudio

By popular demand.
Work in progress.
Here be dragons.

https://github.com/SFML/SFML/compare/master...miniaudio_rebase
I took a shot at rebasing and fixing merge conflicts. Some of the conflicts were easily fixed but I'm still not sure I correctly fixed the conflicts in src/SFML/Audio/Sound.cpp. I can't get it to compile.

I have most of the build errors fixed and removed all the imgui and imgui-sfml source code. I still need to fix compiler warnings and clang-tidy errors but this PR is at least in a state where it passes most of CI which means more people should be able to test it out.

miniaudio officially supports iOS and building for it even has a dedicated subsection in its documentation.

I think my hunch was right. This should be fixable by telling CMake what specific files need to be compiled as Objective-C++.

I've fixed almost all of the compiler warnings. The last one to address is here where MinGW appears to have found a null dereference inside of mini audio. I'm not sure if this warning is triggered by code we wrote or what.
We'll probably just pragma around this but I wanted to highlight it in case someone had an idea for a different fix.
Lastly I still have to fix those iOS jobs and then'll have 100% green CI :)

I was able to fix the iOS build errors and added and workaround to deal with that MinGW warning that I didn't otherwise know how to fix. CI should be 100% green now!

Rebased on master and applied a few changes recommended by Kimci.

There are some new clang-tidy errors because the implementation structs use an m_ prefix in spite of being structs with exclusively public data.

Adding ImGUi-SFML creates a circular dependency. ImGui-SFML depends on SFML as shown by ImGui-SFML::ImGui-SFML linking to SFML::Graphics. However SFML is now downloading ImGui-SFML.
If we break the API and ImGui-SFML needs updating as sometimes happens, then we can’t merge the PR because SFML CI will fail. However if we try to fix this API change in ImGui-SFML first then ImGui-SFML CI will fail because SFML hasn’t yet merged this change. That feels a bit messy to me. As long as we don't break the API we're fine but it's not great that this design doesn't withstand SFML API changes gracefully.
I'm questioning whether it's worth adding ImGui-SFML just for an example. I get its value. It's useful to have sliders and other GUI elements on screen but it comes at the cost of some annoying new complexities that we could avoid by simplifying the example. Perhaps simplifying this example to work with keyboard controls is a cleaner solution.

This PR increases the clean build time on my machine from ~20 seconds to ~25 seconds. Most of that can be attribute to us downloading and building ImGui-SFML for the new example. I'm not yet sure if this also means a ~25% increase to how long CI jobs take since we do lots of caching in CI.

@eXpl0it3r @binary1248: I've rebased on the current master branch and I've also removed a lot of code repetition between SoundStream.cpp and Sound.cpp by introducing a src/MiniaudioUtils.{h,cpp} utility component.
I've kept my commit separate for now so that my refactoring can be reviewed.

Addressed comments and replaced sound stage with sound effects example that no longer relies on ImGui.

If I run sound-effects and press right arrow about once per second to cycle through its states, I quickly get this UBSan error
UndefinedBehaviorSanitizer:DEADLYSIGNAL
==98515==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x00012da7f780 (pc 0x0001038f567c bp 0x00016d5bcfb0 sp 0x00016d5bcf80 T5810290)
==98515==The signal is caused by a READ memory access.
    #0 0x1038f567c in vorbis_synthesis+0x1b0 (vorbis:arm64+0xd67c)
    #1 0x1038d8fdc in _fetch_and_process_packet+0xbc (vorbisfile:arm64+0x4fdc)
    #2 0x1038d97a4 in ov_read_filter+0x90 (vorbisfile:arm64+0x57a4)
    #3 0x1038d9abc in ov_read+0x14 (vorbisfile:arm64+0x5abc)
    #4 0x102d04b6c in sf::priv::SoundFileReaderOgg::read(short*, unsigned long long) SoundFileReaderOgg.cpp:199
    #5 0x102c68268 in sf::InputSoundFile::read(short*, unsigned long long) InputSoundFile.cpp:261
    #6 0x102c5ff80 in sf::Music::onGetData(sf::SoundStream::Chunk&) Music.cpp:189
    #7 0x102c81204 in sf::SoundStream::Impl::read(void*, void*, unsigned long long, unsigned long long*) SoundStream.cpp:118
    #8 0x102bac92c in ma_data_source_read_pcm_frames_within_range(void*, void*, unsigned long long, unsigned long long*) miniaudio.h:57163
    #9 0x102baaedc in ma_data_source_read_pcm_frames miniaudio.h:57278
    #10 0x102c574d8 in ma_engine_node_process_pcm_frames__sound(void*, float const**, unsigned int*, float**, unsigned int*) miniaudio.h:74347
    #11 0x102c5429c in ma_node_process_pcm_frames_internal(void*, float const**, unsigned int*, float**, unsigned int*) miniaudio.h:72453
    #12 0x102bd8684 in ma_node_read_pcm_frames(void*, unsigned int, float*, unsigned int, unsigned int*, unsigned long long) miniaudio.h:72557
    #13 0x102c54bc8 in ma_node_input_bus_read_pcm_frames(void*, ma_node_input_bus*, float*, unsigned int, unsigned int*, unsigned long long) miniaudio.h:71701
    #14 0x102bd8a10 in ma_node_read_pcm_frames(void*, unsigned int, float*, unsigned int, unsigned int*, unsigned long long) miniaudio.h:72575
    #15 0x102bd7c50 in ma_node_graph_read_pcm_frames miniaudio.h:71232
    #16 0x102bf2a78 in ma_engine_read_pcm_frames miniaudio.h:75207
    #17 0x102aa4cfc in sf::priv::AudioDevice::AudioDevice()::$_1::operator()(ma_device*, void*, void const*, unsigned int) const AudioDevice.cpp:144
    #18 0x102aa4b20 in sf::priv::AudioDevice::AudioDevice()::$_1::__invoke(ma_device*, void*, void const*, unsigned int) AudioDevice.cpp:138
    #19 0x102c31754 in ma_device__on_data_inner(ma_device*, void*, void const*, unsigned int) miniaudio.h:18675
    #20 0x102c30938 in ma_device__on_data(ma_device*, void*, void const*, unsigned int) miniaudio.h:18756
    #21 0x102c2de6c in ma_device__handle_data_callback(ma_device*, void*, void const*, unsigned int) miniaudio.h:18808
    #22 0x102ae3b1c in ma_device__read_frames_from_client(ma_device*, unsigned int, void*) miniaudio.h:18838
    #23 0x102c2d0f8 in ma_device_audio_thread__default_read_write(ma_device*) miniaudio.h:19328
    #24 0x102adcfec in ma_worker_thread(void*) miniaudio.h:40874
    #25 0x102bfdff4 in ma_thread_entry_proxy(void*) miniaudio.h:16494
    #26 0x18318af90 in _pthread_start+0x84 (libsystem_pthread.dylib:arm64e+0x6f90)
    #27 0x183185d30 in thread_start+0x4 (libsystem_pthread.dylib:arm64e+0x1d30)

==98515==Register values:
 x[0] = 0x0000000437460000   x[1] = 0x0000000000000000   x[2] = 0x0000000137460000   x[3] = 0x000000016d5bce80
 x[4] = 0x0000000003000001   x[5] = 0x0000000000000003   x[6] = 0x0000000000000000   x[7] = 0x0000000000000000
 x[8] = 0xfffffffffb67fb56   x[9] = 0x000000012da7f558  x[10] = 0x0000000000000018  x[11] = 0x0000000000000252
x[12] = 0x000000011e4b77b0  x[13] = 0x0000000000000000  x[14] = 0x0000000000007f73  x[15] = 0x0000000000000000
x[16] = 0xfffffffffffffff1  x[17] = 0x00000001f52030f0  x[18] = 0x0000000000000000  x[19] = 0x000000013f7534b8
x[20] = 0x0000000000000002  x[21] = 0x000000013f7534c0  x[22] = 0x000000013f7535a0  x[23] = 0x0000000140080800
x[24] = 0x0000000140080828  x[25] = 0x000000013f753280  x[26] = 0x0000000000000038  x[27] = 0xffffffffffffffff
x[28] = 0x0000000000000004     fp = 0x000000016d5bcfb0     lr = 0x00000001038f5658     sp = 0x000000016d5bcf80
UndefinedBehaviorSanitizer can not provide additional info.
SUMMARY: UndefinedBehaviorSanitizer: SEGV (vorbis:arm64+0xd67c) in vorbis_synthesis+0x1b0
==98515==ABORTING
Abort trap: 6

If I spam inputs in slightly different ways I can get other errors. Not sure how these errors relate to each other but it points to there being something going on with how this example program manages changing states.

Updated.
Tested on Windows and Linux (Manjaro). Does not trigger any sanitizers and @texus example terminates cleanly.

Fixed issues mentioned by @kimci86.

I can confirm that the mentioned issues are fixed (tested on Linux). The noise is gone, all the effects in the example work and it no longer crashes.

The crashes seem to be fixed now. However I still cannot get any audio to play. Can anyone else try this example on macOS and let me know if you hear anything?

I updated the miniaudio header to a newer version, it includes a fix for an issue that users reported causing audio not to play on macOS systems.
I also made the console output when running sound code without an available playback device a bit more helpful.
If you uncomment MA_DEBUG_OUTPUT in Miniaudio.cpp, miniaudio should dump a bunch of information to the console to help narrow down the problem.

It's working now!

Just tested this on my current project, felt sweet to be able to delete openal32.dll and have this just work. Noticed no problems, and also had to make 0 changes in my code to get it to work. Great job so far folks!

https://github.com/Marioalexsan/ProjectSilver/blob/7d328858e5d664af14a8891b9de71de620f76651/ProjectSilver/src/ProjectSilver/AudioEngine.cpp#L165
This check now returns a status of Paused instead of Stopped when using the miniaudio branch, which doesn't really seem correct given that I don't even use pause() anywhere.
This is the state in which the audio is when doing the stop check:

Periodic rebase. No changes made.

https://github.com/SFML/SFML/compare/feature/miniaudio...feature/miniaudio_remove_pimpl
I removed the use of PIMPL from AudioDevice. Here are the compile time differences
feature/miniaudio:
Benchmark 1: ninja clean && time ninja sfml-audio
  Time (mean ± σ):      2.109 s ±  0.024 s    [User: 11.991 s, System: 1.479 s]
  Range (min … max):    2.059 s …  2.141 s    10 runs

feature/miniaudio_remove_pimpl:
Benchmark 1: ninja clean && time ninja sfml-audio
  Time (mean ± σ):      2.105 s ±  0.029 s    [User: 12.066 s, System: 1.482 s]
  Range (min … max):    2.046 s …  2.150 s    10 runs

PIMPL in this case seems to make zero measurable difference to compile times. We're better off removing that pointer indirection since it serves no purpose.

I rebased my tests in #2927 onto this PR and am getting some failures. The above failure in CHECK(music.getStatus() == sf::SoundSource::Status::Paused); sounds similar to what Marioalexsan brought up.

I tried this branch with my project and would like to share my experience.
Aside from migrating my code to SFML 3, I've made zero code changes related to the audio and it's working 🥳 . All audio (both sf::Sound and sf::Music) in my game are loaded using custom stream input because they're embedded in a custom file format.
The audio data is mostly OGG and WAV (Some spicy details: The WAV is originally stored in pure WAV without headers, my game construct its header).
There's one behavior change however! There's a scenario where my game calls sf::Sound::play() (or sf::SoundSource::play()) multiple times, and before the actual audio finish playing. This is usually happen for UI SFX stuff. When using old engine (OpenAL), the playback is reset and the audio is played all over again from start. But now with new engine (miniaudio), it does nothing.
I could workaround this by calling stop() each time I calls play(). But I would hope SFML would retain the old behavior.

Rebased on master and fixed a minor merge conflict.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

48 of 873 (5.5%)  changed or added relevant lines in 27 files are covered.
12 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-1.4%) to 49.577%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

include/SFML/Audio/Sound.hpp
0
1
0.0%

include/SFML/Audio/SoundBuffer.hpp
0
1
0.0%

src/SFML/Audio/InputSoundFile.cpp
18
19
94.74%

src/SFML/Audio/Music.cpp
0
1
0.0%

src/SFML/Audio/OutputSoundFile.cpp
0
1
0.0%

src/SFML/Audio/SoundBufferRecorder.cpp
0
1
0.0%

include/SFML/Audio/SoundSource.hpp
0
2
0.0%

src/SFML/Audio/Listener.cpp
0
4
0.0%

src/SFML/Audio/SoundFileReaderMp3.cpp
4
10
40.0%

src/SFML/Audio/AudioResource.cpp
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

include/SFML/Audio/SoundStream.hpp
1
0.0%

src/SFML/Audio/SoundFileReaderMp3.cpp
1
81.31%

include/SFML/Audio/SoundRecorder.hpp
1
0.0%

src/SFML/Audio/SoundRecorder.cpp
2
0.0%

src/SFML/Audio/Sound.cpp
2
0.0%

src/SFML/Audio/SoundBuffer.cpp
2
0.0%

src/SFML/Audio/SoundSource.cpp
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.4%

Covered Lines:
10351

Relevant Lines:
19558

💛  - Coveralls

Rebased on master
Removed PIMPL from AudioDevice
Fixed getStatus returning unexpected values, emulates previous OpenAL behaviour now

@Marioalexsan @LumineBot The issues you were having should be solved now.
As far as I can tell, Miniaudio doesn't impose any kind of limit on the number of sounds that can exist or simultaneously play at the same time. All mixing and audio effects are performed in software so it should only be limited by available CPU/RAM.

I'm going to add my voice to the choir in telling you all that you're awesome. I updated my game to use this branch, I haven't noticed any issues. The new functionality is great, we can do some cool dynamic audio transitions very easily now. Not needing a dll for openal is also very nice.

I'm going to add my voice to the choir in telling you all that you're awesome. I updated my game to use this branch, I haven't noticed any issues. The new functionality is great, we can do some cool dynamic audio transitions very easily now. Not needing a dll for openal is also very nice.

And there is nothing more rewarding than seeing all the new features being put to good use. 😃

Ah, unfortunately I may have found an issue. The following program crashes on the miniaudio branch but not on the master branch
#include <SFML/Audio.hpp>
#include <vector>
#include <iostream>

int main() {
	std::vector<std::string> files = {
		"example1.wav",
		"example2.wav"
	};

	std::vector<sf::SoundBuffer> buffers(files.size());
	std::vector<sf::Sound> sounds;

	for (size_t i = 0; i < files.size(); ++i) {
		std::cout << files[i] << std::endl;
		if (!buffers[i].loadFromFile(files[i])) {
			std::cerr << "Failed to load " << files[i] << std::endl;
			return -1;
		}

		sounds.emplace_back(buffers[i]); // crashes here
	}
}

pure virtual method called
terminate called without an active exception
Process finished with exit code 134 (interrupted by signal 6:SIGABRT)
__pthread_kill_implementation 0x00007ffff69b29fc
sf::SoundSource::setPitch SoundSource.cpp:63
sf::SoundSource::SoundSource SoundSource.cpp:42
sf::Sound::Sound Sound.cpp:230
main main.cpp:26
This is on commit 8c15fafdb19bb9ff49e544c0c33ee2b6798c5dfc

Ah, unfortunately I may have found an issue. The following program crashes on the miniaudio branch but not on the master branch
#include <SFML/Audio.hpp>
#include <vector>
#include <iostream>

int main() {
	std::vector<std::string> files = {
		"example1.wav",
		"example2.wav"
	};

	std::vector<sf::SoundBuffer> buffers(files.size());
	std::vector<sf::Sound> sounds;

	for (size_t i = 0; i < files.size(); ++i) {
		std::cout << files[i] << std::endl;
		if (!buffers[i].loadFromFile(files[i])) {
			std::cerr << "Failed to load " << files[i] << std::endl;
			return -1;
		}

		sounds.emplace_back(buffers[i]); // crashes here
	}
	return 0;
}

pure virtual method called terminate called without an active exception
Process finished with exit code 134 (interrupted by signal 6:SIGABRT)
__pthread_kill_implementation 0x00007ffff69b29fc sf::SoundSource::setPitch SoundSource.cpp:63 sf::SoundSource::SoundSource SoundSource.cpp:42 sf::Sound::Sound Sound.cpp:230 main main.cpp:26
This is on commit 8c15faf

Looks like sf::SoundSource copy constructor relies on being able to call setPitch, which will try invoke getSound(), but getSound() is virtual on SoundSource and is overriden by sf::Sound, which itself hasn't been fully constructed since sf::SoundSource must be constructed first. Also m_impl won't be valid until after sf::SoundSource copy constructor has run.
Threw some screenshots below of what I spotted in the debugger, don't have much more to offer than that but hope it helps! Loving the miniaudio work and wanna help it anyway I can!

Rebased on master and fixed minor merge conflict.

I reenabled the clang-tidy check which is catching this pure virtual function call bug so that we can get better feedback once we start trying to fix it.

@danieljpetersen The pure virtual method call issue should be fixed now.

My Audio unit tests are now passing without any crashes. There is however this oddity in the sf::SoundSource tests
    SECTION("Set/get pitch")
    {
        SoundSource soundSource;
        soundSource.setPitch(42);
        CHECK(soundSource.getPitch() == 0);
    }

    SECTION("Set/get volume")
    {
        SoundSource soundSource;
        soundSource.setVolume(0.5f);
        CHECK(soundSource.getVolume() == 0);
    }

    SECTION("Set/get position")
    {
        SoundSource soundSource;
        soundSource.setPosition({1, 2, 3});
        CHECK(soundSource.getPosition() == sf::Vector3f());
    }

    SECTION("Set/get relative to listener")
    {
        SoundSource soundSource;
        soundSource.setRelativeToListener(true);
        CHECK(!soundSource.isRelativeToListener());
    }

    SECTION("Set/get min distance")
    {
        SoundSource soundSource;
        soundSource.setMinDistance(12.34f);
        CHECK(soundSource.getMinDistance() == 0);
    }

    SECTION("Set/get attenuation")
    {
        SoundSource soundSource;
        soundSource.setAttenuation(10);
        CHECK(soundSource.getAttenuation() == 0);
    }

The setters and getters seem to just not work. Setting a value does not result in being about to get the old value. The setters and getters behave as one would expect with the OpenAL backend.

SoundSource was downgraded from being a semi-concrete class managing the actual OpenAL sound source to being an abstract interface with common functionality that is used by Sound and SoundStream. If you work around the fact that you shouldn't even be able to instantiate a SoundSource object by defining an empty derived class you can't expect it to work properly because there is no backing implementation behind it. If you want to test the SoundSource interface instantiate a proper object (Sound or Music) and test through a SoundSource& to the object.

CI is failing due to Homebrew updating clang-tidy which includes some new checks. I fixed that in https://github.com/SFML/SFML/pull/2953.

Thank you Binary! That did indeed fix it. And thank you Bambo, thank you Thrasher!
Yesterday I wrote a little sound interpolator for the audio section of my codebase, where you give a duration and an easing formula for any given music/sound property(s). I've got it working in my game now to transition music on scene changes, it's especially nice when going from high tempo to low tempo music.
I'm looking forward to whenever this gets merged into master.

Rebased and updated.

Big thanks to @binary1248 for taking on this work and everyone for reviewing! 🎉


Invalid Prisma endpoint provided: PRISMA_ENDPOINT

thank you tutorial !!!
in client and server, when I run yarn start, I get the error
'Invalid Prisma endpoint provided: PRISMA_ENDPOINT'
I try find anwser in this issues react-fullstack-graphql/issues, but I don't know what mean?
this is my error image:

I need your help, thanks!

How did you fix this error?

I have same issue could you please help me. How did you fixed this issue


⚠ Bofrost.es has degraded performance

In cdd3abc, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1617 ms

Resolved: Bofrost.es performance has improved in 57ca602 after 10 minutes.


USSD registration - Add fixture testing

[x] number fixtures

[x] use utils function checkFixturesUsed to test

@gsvr plz review

:+1:


UserRightsAssignment: unable to Force multiple values

Details of the scenario you tried and the problem that is occurring
I am trying to set the value of generatesecurityaudits to two SIDs, however this fails to apply. Force only appears to work when setting a single SID.
Verbose logs showing the problem
Error from the Set-TargetResource:
PowerShell DSC resource MSFT_UserRightsAssignment  failed to execute Set-TargetResource functionality with error message: Could not convert Identity: LOCAL
SERVICE,NETWORK SERVICE to SID
    + CategoryInfo          : InvalidOperation: (:) [], CimException
    + FullyQualifiedErrorId : ProviderOperationExecutionFailure
    + PSComputerName        : localhost

Error from the end of the job:
The SendConfigurationApply function did not succeed.
    + CategoryInfo          : NotSpecified: (root/Microsoft/...gurationManager:String) [], CimException
    + FullyQualifiedErrorId : MI RESULT 1
    + PSComputerName        : localhost

Suggested solution to the issue
Ideally, when specifying Force = $true, it would wipe out any existing values and replace them only with the ones you specify.
The DSC configuration that is used to reproduce the issue (as detailed as possible)

Configuration CIS_WindowsServer2016_v110_MS_lvl1 {
    param (
        [string[]]$NodeName ='localhost'
        )

    Import-DscResource -ModuleName 'NetworkingDsc'
    Import-DscResource –ModuleName 'PSDesiredStateConfiguration'
    Import-DscResource -ModuleName 'AuditPolicyDsc'
    Import-DscResource -ModuleName 'SecurityPolicyDsc'

    Node $NodeName {
        # Firewall Configuration - adjust interface alias
        NetConnectionProfile DefaultConnectionProfile {
            InterfaceAlias   = 'Ethernet 3'
            NetworkCategory  = 'Private'
        }
        # 2.2.30 (L1) Ensure 'Generate security audits' is set to 'LOCAL SERVICE,NETWORK SERVICE'
        UserRightsAssignment Generatesecurityaudits {
            Policy   = 'Generate_security_audits'
            Identity = 'LOCAL SERVICE,NETWORK SERVICE'
            Force    = $true
        }

The operating system the target node is running
OsName               : Microsoft Windows Server 2016 Datacenter
OsOperatingSystemSKU : DatacenterServerEdition
OsArchitecture       : 64-bit
WindowsBuildLabEx    : 14393.3085.amd64fre.rs1_release.190703-1816
OsLanguage           : en-US
OsMuiLanguages       : {en-US}
Version and build of PowerShell the target node is running
Name                           Value

PSVersion                      5.1.14393.3053
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.3053
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
Version of the DSC module that was used ('dev' if using current dev branch)
<IP_ADDRESS>

Hi @mnotley-reward, try updating the Identity property with an array like this:
Identity = 'LOCAL SERVICE,NETWORK SERVICE'

@mnotley-reward, can you confirm this resolved your issue?


Change logo to be transparent

@jnm2 How's this?

I think it's an improvement. It might look even more consistent to have a white border around the bell too. What do you think?

You're right @jnm2. I made the change. How's this?


Rare attributes do not support decimals

Hello, I have many layers of each element, the hat has 60, the back has 64, hair has 25, clothes have 65, how do I set the rare attributes, if the hat needs to set which rare 5 elements, background 1 rare, clothes 3 rare, so how to change the name is correct~
At first I thought it supported decimals, so I set them all to decimal points. Using 100/64 layers like this, I got the approximate average

Then I found out that he doesn't support decimals and reports an error~

100/64

I want to set 63 normal and 1 rare
So I'm thinking 1.58*63+0.46 = 100
But it seems a little naive to think

Done, changed the int() to eval(), generated no more problems, can use decimals