Bash: Line wrapping issue

Category

[ ] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[x] Etc.

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

Steps to reproduce:

Use bash with fzf
Do an echo "abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc" (so you have that command in your bash history)
export PS1="abc abc abc abc abc abc abc abc abc abc abc abc abc abc abc"
Activate fzf's reverse-i-search (Ctrl + r)
Select the echo "abc .." line, press enter
Bash prompt is wrapped incorrectly. After pressing enter in the last step, the cursor is placed at the very end of the line (right after the closing "), however there is more text on the right side of the cursor (after EOL).

Is that caused by fzf?
See this demonstration video:
EDIT: Filled out issue template. Sorry.

It is probably a minor rendering bug of bash, and unfortunately there's not much we can do about it. Pressing CTRL-L clears the prompt when that happens.

Possibly related: #681

Yup, this is a duplicate of #681
Continuing the discussion over there.


Add lock free data structures to wsv

https://jira.hyperledger.org/browse/IR-1065
https://jira.hyperledger.org/browse/IR-1066
Signed-off-by: i1i1<EMAIL_ADDRESS>Description of the Change
Remove lock from WSV and make maps and sets mutable concurrently. It uses dashmap crate for that.
Benefits
This change removes racing for whole wsv and adds locks for its subparts.
Possible Drawbacks
Lockfree actually caused several panics and needs for rework.
Usage Examples or Tests [optional]

Alternate Designs [optional]
dashmap is also good, it offers entry api and some lock free functions, but there are cautions about deadlocks. It is probably a good candidate, but should be used wisely.
lockfree is very generic and good crate, but it seems very unsafe to use it, as it can panic. Also it is quiete slow
flurry is a port of java hashmap, so it seems to be very robust, but it requires using crossbeam epoch in api, so we need to drastically change it in order to use it.

@i1i1 I remember you were doing performance tests for both of the crates, can you publish the results here?

Benchmark of lockfree vs dashmap:
Insert scenario (50000 Inserts per thread):

Number of threads
Lockfree time(ms)
Dashmap time(ms)

1
27.926
4.7712

2 l 60.090
6.3390

3
98.009
7.9950

4
116.96
8.6376

5
152.93
16.902

6
191.50
19.881

7
229.63
23.266

8
267.37
28.643

Generally dashmap 5-10x faster than lockfree
lockfree insert/1       time:   [27.814 ms 27.926 ms 28.051 ms]
change: [-1.2313% -0.4817% +0.2635%] (p = 0.22 > 0.05)
No change in performance detected.
Found 14 outliers among 100 measurements (14.00%)
2 (2.00%) high mild
12 (12.00%) high severe
dashmap insert/1        time:   [4.7606 ms 4.7712 ms 4.7832 ms]
change: [-1.8906% -1.3788% -0.9190%] (p = 0.00 < 0.05)
Change within noise threshold.

@i1i1 in the benchmarks mutexmap name is a bit confusing. Consider changing it to std HashMap behind async_std Mutex

Or you can mark it with * and describe it below.

@eadventurous looked through every RwLock in iroha_data_model. Unfortunately using HashSet/HashMap there would require removing Ord everywhere. I guess it is better to leave BTreeMap/BTreeSet for this small cases.

Possible design for wsv (the same as before but with some lifetime wrangling)
https://gist.github.com/i1i1/cd84e1c5d5f29a1175033ff17ce4fe1c

I was concerned about using dashmap in the async context because of the spinlocks (I thought they might still computation time from other tasks as they are not cooperating). But I investigated the issue more and it seems they do cooperate. I was testing with ASYNC_STD_THREAD_COUNT=1 - the most extreme case, and other tasks can still proceed even if one of the tasks was locked there, waiting for write access.
Also there is an issue for async support for dashmap, and it is mentioned there that it is fully compatible https://github.com/xacrimon/dashmap/issues/25

@eadventurous Yeah it won't make sense as it would require locking and removing spinlocks from datastructure. Let's just keep that in mind and never take mutable refence for dashmap as it might deadlock whole datastructure.

Mutable references will sometimes be taken,  as we do mutate WSV it is just a matter of for how long, but anyway, I checked this and it seems working even in this extreme case, and it does not block the whole thread.

@eadventurous we don't need to take mutable reference (&self for rust) as we can mutate it through datastructures like rwlock or dashmap/dashset. We have variety of options

@eadventurous  It will live here https://jira.hyperledger.org/browse/IR-1078


Question about computing the affinity score

Thanx for ur great job. @bobwan1995 @desenzhou
As shown in ur paper, u compute the affinity score using the Holistic Feature only.
But, as i read from lib/modeling/hoi.py, u compute the affinity score (i.e. interaction_affinity_score in the code) using both Holistic Feature and Zoom-in Feature, which is same as computing local relation score (i.e. interaction_action_score in the code)?
Please see lib/modeling/hoi.py in line 347-349
I am so confused that I couldn't eat my meal. Does it mean using both Holistic Feature and Zoom-in Feature in computing  the affinity score is better than Holistic Feature only?
Waiting for reply. Thanx!

You are very meticulous. Actually the performance is close when we use holistic or holistic+local features to predict binary scores. This code is an initial version where we use holistic+local, I will revise it and give a new ckpt later (maybe after I get back to school). In conclusion, there is nearly no difference whether to use holistic or holistic+local features to predict binary scores, and you can try it by yourself. We choose to only use holistic features just for simplification. Thank you!

I got it! Thanx again.
Looking forward to your HICO code, by the way.
I can eat my hamburger in peace now. Zhen Xiang!


Saving weather forecasts breaks when looking up sensor

[FLEXMEASURES] Only one location: 52.0867,5.088.
[FLEXMEASURES] Getting weather forecasts:
[FLEXMEASURES]  Latitude, Longitude
[FLEXMEASURES] -----------------------
[FLEXMEASURES] 52.0867, 5.088
[FLEXMEASURES] Called OpenWeatherMap API successfully at 2022-01-06 15:04:00+01:00.
[FLEXMEASURES] Processing forecast for 2022-01-06 15:00:00+01:00 (horizon: -1 day, 23:56:00) ...
[FLEXMEASURES] Task get_weather_forecasts encountered a problem: "'Sensor' object has no attribute 'latitude'". More details: {'src_module': '/home/seita/.virtualenvs/seita-flexmeasures/lib/python3.8/site-packages/flexmeasures/data/scripts/grid_weather.py', 'src_linenr': 391, 'src_func': 'save_forecasts_in_db', 'src_code': 'location[0] - weather_sensor.latitude'}
[FLEXMEASURES] Reported task get_weather_forecasts status as False

The fix of that line is to change sensor.latitude into sensor.location[0] or into sensor.get_attribute("latitude").
However, the lookup of the sensor by type above might also be broken, pay good attention.

Actually, that whole file needs to be depretaed and become our flexmeasures-opwenweathermap plugin. I'll get to know the code by fixing this problem, so maybe a good time to start that :)


Admin cli support terminate a partitioned topic

Motivation
Now, Admin cli only support a non-partitioned topic, But In actually, I usually want to terminate the whole topic, instead of one partition of topic.
Modifications
add  admin command partitioned-terminate, support terminate whole topic without specify partition.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no) no
The public API: (yes / no) yes
The schema: (yes / no / don't know) no
The default values of configurations: (yes / no) no
The wire protocol: (yes / no) no
The rest endpoints: (yes / no) no
The admin cli options: (yes / no) yes
Anything that affects deployment: (yes / no / don't know) no

Documentation
need doc, i will update it later

@BewareMyPower  PTAL

@gaozhangmin Thanks for your great contribution.
Want users to know your awesome code changes? Do not forget to add docs accordingly! And you can ping me to review the docs. Let's grow Pulsar together!

@Anonymitaet  docs added

Could you add some unit tests? What if my parameter is a non-partitionedTopic?

The restful api test is already covered by testTerminatePartitionedTopic.
I will add a  admin client request test.

@BewareMyPower  @congbobo184  @315157973
I think, instead of introduce a new admin cli command partitioned-terminate,  allow terminate command to terminate a partitioned-topic would be better. What do you think.
then api /{tenant}/{namespace}/{topic}/terminate/partitions  would be useless.

I prefer the previous one. Because for other commands we also use partition-xxx for partitioned topics.

@315157973  test added. PTAL.

@gaozhangmin Thanks for your doc. Does the code change affect only master or other versioned docs (for example, 2.8.1 and 2.8.2?
If latter, could you please help update all affected versions? Thanks

@gaozhangmin Thanks for your doc. Does the code change affect only master or other versioned docs (for example, 2.8.1 and 2.8.2?
If latter, could you please help update all affected versions? Thanks

Only master, I think.

@gaozhangmin Thanks for your doc. Does the code change affect only master or other versioned docs (for example, 2.8.1 and 2.8.2?
If latter, could you please help update all affected versions? Thanks

I don't know which version it will be included

It looks good. Could you please also add a unit test in PulsarAdminToolTest.java ?

done

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@eolivelli Could you review it again? I think your comments have been addressed.

@eolivelli  PTAL again

@eolivelli  @codelipenghui  PTAL again

@codelipenghui  This pr is ready to merge. I think.


Provide macro to define custom punctuation, analogous to custom keywords

For example a function-like macro may want to use <=> as punctuation. Parsing this as Token![<] Token![=] Token![>] would be incorrect because it does not enforce that the tokens are Joint.

@CAD97 may be working on this.

It won't be possible to use the exact same strategy as CustomKeyword uses today for both a CustomKeyword and CustomPunctuation at the same time, as the implementations of Sealed and Token overlap.
This will require either finding another approach or putting token::Sealed in $crate::export so that it can be implemented on a case-by-case basis.

Added in #620.


Standardize terminology

Currently, in the attribution and activation patching examples on nnsight, patching is done FROM clean TO corrupt. While, in standardized settings patching is done FROM corrupt TO clean. A better set of terms could also be base and source.
Will submit a PR for this soon if it seems ok, and someone doesn't beat me to it. :)
cc/ @JadenFiotto-Kaufman Can you please :+1: if this sounds reasonable?

@arunasank Absolutely go ahead and I will merge it in :)


Uncaught (in promise) Error: gl error: 1282

I noticed that the example "transform feedback"
of the webgl-state-diagram stops on the line
gl.beginTransformFeedback(gl.POINTS);

fixed: https://github.com/gfxfundamentals/webgl2-fundamentals/commit/397a447619d3e76ced9424264191bcaf8bfde8ab
It might be 20 minutes or so before it will work and you might have to load this url and then pick "refresh" or clear your cache


[5.2] Fixed slug that wasn't working with utf8 characters

Doesn't our ascii method need fixing? Also, is there any reason you sent this to the master branch that doesn't get released until the end of november this year>

Doesn't our ascii method need fixing?

I don't know, it was wrong to convert to ascii anyway as a URL can contain utf8 chars

Also, is there any reason you sent this to the master branch that doesn't get released until the end of november this year?

I'm new to laravel, do you want me to push that on another branch?

Bug fixes would go to 5.1 branch. This would also need a more thorough description.

sorry I don't have time to further dig into the issue. I thought it was a pretty straight forward and obvious patch. Good luck.

Excuse me, what is the time of the Session settings do not work?

Excuse me, what is the time of the Session settings do not work?

What?

that was random


Can you provide some example with react-redux?

Hello @jas-chen. Can you provide some example with https://github.com/gaearon/react-redux?

I haven't make sure it works yet, but since rx-redux implemented all of the redux APIs, I think it will work naturally. Let me know if you encounter any problem while getting them work together.
The reactive way to combine react and rx-redux is working in progress, I think I need to take a look at cycle-react's source code to get some idea.

@jas-chen I tried use official example https://github.com/gaearon/redux/tree/breaking-changes-1.0/examples/counter with rx-redux instead of redux but this example doesn't work with rx-redux.

Compare this https://github.com/gaearon/redux/blob/breaking-changes-1.0/src/index.js#L7 and this https://github.com/jas-chen/rx-redux/blob/master/src/index.js#L7. Also this https://github.com/gaearon/redux/blob/breaking-changes-1.0/src/createStore.js#L130 and this https://github.com/jas-chen/rx-redux/blob/master/src/createStore.js#L44. Also interesting this commit https://github.com/gaearon/redux/commit/d92f08e804a8b2f91d7f77a8bb10ee1c279cee6a

Will keep working on this issue next day, thanks for the info!

@jas-chen Also I'll look on this problem today but later.

@xgrommx I just provide an example, check it out!

@jas-chen Without an additional subscription this code doesn't work? I mean the same like in original Redux.

I see you have a new approach for middlewares?) Difference between an original middleware and reactive middleware just don't to use dispatch?

@xgrommx I think this is because state$ is a [cold observables](https://github.com/Reactive-Extensions/RxJS/blob/master/doc/gettingstarted/creating.md#Cold vs. Hot Observables), it start running upon subscription, so we have to call subscribe().
What if rx-redux call subscribe() for you? The initial state will be published immediately and you can't get it when you subscribe to state$ later.

In this case react-redux will not subscribe to state$, so you can call subscribe() right after createStore if you don't want to modify App component.

I updated the example, moved it out.

Hot observable can be get with publish().refCount() or publishValue(v).refCount()

@xgrommx thank you! Check out v0.5.2 and updated version react-redux example.
Awesome 👍!

@xgrommx, see universal example, it shows how you can benefited from using RxMiddleware.

@jas-chen Thanks! Also look at this method http://xgrommx.github.io/rx-book/content/observable/observable_instance_methods/connect.html which give able create a hot observable.


Confusion with mobile templates: Improve user experience

Summarized Feedback from<EMAIL_ADDRESS>
Confusion with the use of templates on mobile, because the current process of choosing a template during the creation of a note is not intuitive or user-friendly.


Add Mime Type determination to static_proxy

I was having issues with uploadify because asset_proxy was setting Content-type to application/octet-stream, so I've added code to use the mimetypes library to detemine the correct Content-type header to send. I've tested and it resolves my particular problem.

That's great, thank you.


Fixed Error deploying the default config in openshift: failed to install release: values don't meet the specifications of the schema(s) in the following chart(s): nginx-ingress: - controller.ingressClass: Invalid type. Expected: object, given: string

Describe the bug
When installing the openshift-operator "Nginx Ingress Operator" in default configuration Version nginx-ingress-operator.v2.0.2 and you select "Create NginxIngress" with the default configuration and click "create" you receive the following error:
failed to install release: values don't meet the specifications of the schema(s) in the following chart(s): nginx-ingress: - controller.ingressClass: Invalid type. Expected: object, given: string
To Reproduce
Steps to reproduce the behavior:

Install Nginx Ingress Operator Version v2.0.2 from the frontend
Under Nginx Ingress Controller on the first page klick "Create Instance"
In the Yaml view of the opened page klick "Create"
Under the "Nginx Ingress Controller" Tab you see the status "Conditions: Initialized, ReleaseFailed"
Klicking on the Controller you see the Error under Messages:

failed to install release: values don't meet the specifications of the schema(s) in the following chart(s):
nginx-ingress:
- controller.ingressClass: Invalid type. Expected: object, given: string

Expected behavior
It should be able to create the sample without issues to check if the setup is working
Your environment

Version of the NGINX Ingress Operator - Nginx Ingress Operator
2.0.2 provided by NGINX Inc
Version of the Ingress Controller - Image Tag 3.3.2-ubi
Version of Kubernetes: Openshift 4.13.10
Kubernetes platform (e.g. Mini-kube or GCP)
Using NGINX

Additional context
If the line 55 -> ingressClass: nginx is removed the installation proceeds

I can confirm this bahaviour, this currently blocks us from upgrading to 3.3.2 without having to purge the operator.


where is the setting.txt?

In train.ipynb, I have found setting.txt. But I can not find it in your file.
Can you help me?

Just create a settings.txt file with the following setup:
{
"data_root": "/path/to/your/data"
}

you need to create the settings.txt yourself. It should look like this:
{
"data_root": "/path/to/your/data"
}

Just create a settings.txt file with the following setup:
{
"data_root": "/path/to/your/data"
}

Thank you, Can you give me all datasets baiduyun link?

Follow instructions from here:
https://github.com/jutanke/pak#mot16
https://github.com/jutanke/pak#cuhk03
https://github.com/jutanke/pak#market-1501
https://github.com/jutanke/pak#dukemtmc-reid
Some of them will be automatically downloaded, the other ones have to be downloaded manually

Follow instructions from here:
https://github.com/jutanke/pak#dukemtmc-reid
https://github.com/jutanke/pak#cuhk03
https://github.com/jutanke/pak#market-1501
https://github.com/jutanke/pak#mot16
Some of the datasets will be downloaded automatically by the library (MOT16 and Market1501) while you will have to download the others manually. Put the zip-files in the same directory that you chose in your settings.txt as "data_root".


Only exclude test.js at the top-level

Currently you exclude it at any level.
This excludes https://github.com/sindresorhus/ava/blob/master/lib/test.js even though it's lib/test.js.

@sindresorhus let me know if the new include/exclude logic solves this problem for you.

:+1:


Warnings in console

prop warning issue from package, even though i am mentioning computed properties from my component

Please share more details. This was not helpful

Please share more details. This was not helpful

Closed due to no activity

Closed due to no activity


eROSITA CalPV cleaned event lists appear to be way overly cleaned

With only a few event lists in the final files - may specifically be the eFEDS ones. We noticed when working with CalPV data in XGA for initial testing

I think the reason for this was we actually were selecting only the bad events, rather than the other way around...


appstream: 1.0.1 -> 1.0.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/appstream/versions.
meta.description for appstream is: Software metadata handling library
meta.homepage for appstream is: https://www.freedesktop.org/wiki/Distributions/AppStream/
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.2 with grep in /nix/store/29cmg9a5y796yc24zy77v9gpzq4ssx4v-appstream-1.0.2
found 1.0.2 in filename of file in /nix/store/29cmg9a5y796yc24zy77v9gpzq4ssx4v-appstream-1.0.2

Rebuild report (if merged into master) (click to expand)

676 total rebuild path(s)

676 package rebuild(s)

First fifty rebuilds by attrpath
Sylk
adapta-gtk-theme
ajour
alfis
altair
alvr
amberol
anytype
appimage-run
appimage-run-tests
appstream
apx-gui
arduino-ide
ashpd-demo
audio-sharing
authenticator
autokey
bada-bib
badlion-client
banking
baobab
bazecor
beekeeper-studio
beeper
bespokesynth
bespokesynth-with-vst2
betterdiscord-installer
blackbox-terminal
blanket
bloomrpc
blueberry
blueprint-compiler
boatswain
bookworm
bootstrap-studio
bottles
bottles-unwrapped
breath-theme
budgie.budgie-control-center
budgie.budgie-desktop
budgie.budgie-desktop-with-plugins
budgie.budgie-gsettings-overrides
budgie.magpie
budgiePlugins.budgie-analogue-clock-applet
budgiePlugins.budgie-user-indicator-redux
buttercup-desktop
caido
cambalache
caprine-bin
cartridges

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/29cmg9a5y796yc24zy77v9gpzq4ssx4v-appstream-1.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A appstream https://github.com/r-ryantm/nixpkgs/archive/1d0ce7c80adb49282585d53fe1cf0d7864fba0d3.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1d0ce7c80adb49282585d53fe1cf0d7864fba0d3#appstream

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/29cmg9a5y796yc24zy77v9gpzq4ssx4v-appstream-1.0.2
ls -la /nix/store/29cmg9a5y796yc24zy77v9gpzq4ssx4v-appstream-1.0.2/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings

Breaks {libsForQt5,qt6Packages}.appstream-qt.

@ofborg build appstream appstream.passthru.tests


Add desktop environments

In practice only GNOME and KDE offer reasonable Wayland support "out of the box" as a complete desktop environment nowadays. It's worth a mention.

Thanks ! 🙂


Use strict_encode64 for basic authentication

Base64.strict_encode64 method doesn't need to remove the "\n" characters a posteriori.

Coverage remained the same at 96.0% when pulling c11d4fc27761a9f1eacdf5889d4d6bc814a68b71 on erik-escobedo:strict_encode64 into 452a0853286fc0d2919037598ac891dd3e7b1d19 on intridea:master.

@erik-escobedo ping!

This change was merged in #414


Add common.RetryForever() and use for concurrent operations

Description
Add common.RetryForever() and use for system-critical, concurrent operations that can fail.
Background
The Edge application approaches some errors by logging and running the rest of the program without retrying the failed operation. This is undesirable when those operations are critical (such as relayer startup and sync, which can mean that deposits no longer work). Critical operations should be retried because:

It allows the application to self heal, rather than run without critical capabilities; and
It allows for more reliable alerting and monitoring based on repeating critical errors.

This change allows critical operations to be retried every N seconds. Some such errors are transient and will fix themselves on retry. Other errors will have to be manually fixed by Edge operators.
Note that in a previous PR, we implemented an approach which propagated concurrent errors back to the server shutdown logic. However, this was much more complicated and introduced a paradigm to error handling that is not consistent with how Edge is implemented today.
Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes
None
Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have added the relevant labels
[ ] I have updated the official documentation
[ ] I have added sufficient documentation in code

Testing

[x] I have tested this code with the official test suite
[x] I have tested this code manually

Note that the failing TestE2E_Bridge_DepositAndWithdrawERC1155 passes on my machine. I assume its flakey due to the heuristic it uses for waiting for blocks after the deposit txs

the approach should be to error as soon as possible and stop the execution from progressing.

@vcastellm this notion is contrary to the existing Edge code base which does not handle critical concurrent errors. Edge is a monolithic application and exiting on failure of one of its components is potentially contrary to design.
I started a PR that implemented logic to stop the program based on concurrent errors here: https://github.com/0xPolygon/polygon-edge/pull/1373
I closed it because I felt like I was rewriting Edge's approach to those errors. I am happy to pick that PR up again if you guys prefer that approach.
Alternatively, we could update this PR to add more sophisticated logic so that not everything is retried.

In some cases retrying an error could make sense but in the majority of cases, the approach should be to error as soon as possible and stop the execution from progressing.

I initially misinterpreted this to mean stop the program - but I understand that you mean stop the goroutine that is erroring.
This approach makes it very hard to operate and debug Edge instances. We could have an instance that failed to sync rootchain events many hours ago and we would have to search for that singular ERROR log in an unknown range of time. If the sync was retried, we would see the ERROR log regularly. If we alert on every ERROR log, then we are inundated with alerts - I believe because dispatcher can ERROR log if RPC requests from users fail.
If we keep the status quo, and don't retry for failures like gRPC server startup, event tracker sync, and prometheus server, what is your advice for cutting through the logs and being able to alert on ERRORs? Am I incorrect about the dispatcher logging ERROR on user requests? Thanks

Looking at tt.Sync in ethgo https://github.com/umbracle/ethgo/blob/main/tracker/tracker.go#L578.
The RetryForever here only helps for batchsync, because the longrunning for loop after it is handled concurrently by the Sync func itself. That means the following changes is useless apart from retrying the batchsync before the for loop
	go common.RetryForever(ctx, time.Second, func(context.Context) error {
		if err := tt.Sync(ctx); err != nil {
			e.logger.Error("failed to sync", "error", err)
			return err
		}
		return nil
	})

@Stefan-Ethernal Yep I can see the golangci-lint warnings in my IDE about line cuddilng etc. I was ignoring them as I wasn't sure whether you guys really wanted to enforce those spacing requirements.
I am happy to add a workflow step that enforces the linter if you would like. Or perhaps there is a reason you do not want this. Thanks

@Stefan-Ethernal Yep I can see the golangci-lint warnings in my IDE about line cuddilng etc. I was ignoring them as I wasn't sure whether you guys really wanted to enforce those spacing requirements given the github workflow does not enforce them.
I am happy to add a workflow step that enforces the linter if you would like. Or perhaps there is a reason you do not want this. Thanks

@sergerad In fact we do have GH workflow for linters as well, although for some reason it hasn't been triggering for external collaborators. I have created a #1512  which got merged into the develop, so if you can rebase to the latest commit on the develop branch and let's see is it any better now (I expect it to trigger). 🙂 🤞

Have removed the retry logic apart from polybft sync / event tracker. If we merge this PR, I will need to do a follow up PR to ethgo to address the fact that this error is not handled: https://github.com/umbracle/ethgo/blob/main/tracker/tracker.go#LL582C7-L582C22
@vcastellm are you happy doing the retries on the sync logic? Currently in this PR we are also concurrently retrying initialization logic for the handlers because the tests rely on the fact that those errors are not handled yet. If we want initialization logic out of the concurrent retries, I can update the tests in this PR.
If you are not happy doing retries on sync logic at all, I can close this PR

I did rebase when you mentioned the linting. I can see this commit in my logs

Yep, but that one didn't work, so we have opened and merged another PR today (#1526) and now it's working properly :slightly_smiling_face:


[KYUUBI #6843] FIX 'query-timeout-thread' thread leak

Why are the changes needed?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

Please fix the failed checks.

@ASiegeLion please write the PR description seriously, and revert unnecessary code changes.

@ASiegeLion请认真撰写 PR 描述，并撤销不必要的代码更改。

ok

@ASiegeLion please write the PR description seriously, and revert unnecessary code changes.

ok

Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (dc3ac89) to head (9107a30).
Report is 4 commits behind head on master.

Files with missing lines
Patch %
Lines

.../kyuubi/engine/spark/operation/ExecutePython.scala
0.00%
1 Missing :warning:

...e/kyuubi/engine/spark/operation/ExecuteScala.scala
0.00%
1 Missing :warning:

...uubi/engine/spark/operation/ExecuteStatement.scala
0.00%
1 Missing :warning:

.../org/apache/kyuubi/operation/KyuubiOperation.scala
0.00%
1 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6844   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         687     687
  Lines       42463   42467    +4
  Branches     5796    5796
======================================
- Misses      42463   42467    +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

We also fixed this issue a few months ago.
cc @lsm1

@ASiegeLion  In other engines, there might be the same issue. Please fix it.

Seems the contributor is slient a while, let me merge this, and @lsm1 could you please send a followup to cover the rest?

Merged to 1.11.0/1.10.2/1.9.4


chore(main): release 1.17.0

:robot: I have created a release beep boop
1.17.0 (2023-09-28)
Features

add mutt-language-server support (#283) (517924a)
add templ support (#282) (80c4262)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/williamboman/mason-lspconfig.nvim/releases/tag/v1.17.0 :sunflower:


⚠ Slack has degraded performance

In eaa225e, Slack (https://status.slack.com/api/v2.0.0/current) experienced degraded performance:

HTTP code: 200
Response time: 91 ms

Resolved: Slack performance has improved in a69df0f.


Background images for tracing

The ability to import a background image to trace over would be a huge boon for e.g. translating orthographic drawings into FTD replicas.
Some auxiliary features for usability:

The ability to set and change the image scale (in source image pixels per grid square).
The ability to set and change the X/Y offset for the image.
An opacity slider.
The ability to save the background image name and settings to the project file.

Nothing about this feature request is all that difficult. I wanted to be able to adjust the background and grid colors anyway, which would also be helpful.
The only thing I might need is an example of the sort of image you're talking about for reference. Does this image search for orthographic drawing boat give back the sort of stuff you work with?
Notes for reference
How to access and transform the pixels of a SKBitmap object. Note that some methods of accessing all the pixels are much faster than others.

Exactly those kind of drawings.
The point on scale is essentially that it's not always possible to do an exactly 100% scale replica, and that it could be useful to sweep through and find the scale where things best align to the grid, whether that be at 97% or 120% or whatever.  Similarly with x/y offset, since any origin point is going to be a compromise.  But this is a set once and never touch it again kind of thing, so it could always be done in an external tool.

The initial implementation has been merged into the main branch.

The implementation I have has been released with VGraph 1.9. Feel free to create a new issue if the background image feature needs some adjusting.


Pass the Environment and TraceInfo everywhere.

The lack of Environment information was preventing the project to be compatible with the original PHP.
This commit can be considered as a replacement of Environment#current.
Also added test for string offsets.

Resolves #302

Wow...
We need to return the valueOfIndex method without env, so as not to break backward compatibility, but mark them as deprecated methods.

And you need to resolve conflicts...

:+1:

@dim-s Done.


Example missing double quotes

The example for requiring three tags under the 'Policy rule' section has a syntax error:
"value": "[less(length(field('tags')), 3)]",
"equals": true
true needs to be contained within double quotes: "true"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9762f1b7-0e3a-d58f-fd99-a27ad948907b
Version Independent ID: 89e28332-184e-ba84-df1f-e7698c5e0f7c
Content: Details of the policy definition structure - Azure Policy
Content Source: articles/governance/policy/concepts/definition-structure.md
Service: azure-policy
GitHub Login: @DCtheGeek
Microsoft Alias: dacoulte

@brandonbrownchenega Thank you for bringing this to our notice, we will review and fix the document accordingly.

@brandonbrownchenega Thanks for the question! I reviewed this with the engineers, and it actually works either way (with or without the quotations). However, it appears the portal is syntax highlighting this as "wrong".  The team took a task to fix that, so for now we'll correct this in the docs to align to the experience.  Thanks for pointing this out!
As @BharathNimmala-MSFT fixed this in linked PR #51511 which I just accepted, I'm going to close this issue.  Thanks again for pointing it out!
@MicrosoftDocs/azure-cxp-triage #please-close

@DCtheGeek Ahh, thank you, that makes sense. I was using the policy editor with this example and it did indeed highlight the syntax error. Good information!


support for angular AOT

Hi, there was a question on stackoverflow that I answered where this directive does not work with AOT. Please see my answer to the question if you'd like to make this directive compatible with AOT.
http://stackoverflow.com/questions/43166491/angular2-build-under-angular-cli-with-directive-and-ng-build-prod/43172360?noredirect=1#comment73418872_43172360
I'd also say, you should probably expose the source TS file alongside the generated JS file in the published package. In a new release of course.

Please do this, I don't like pulling dependencies in manually!

@seiyria maybe You want to contribute with this?

@NagRock see #7

Is there any plan to fix this issue?

Done in 1.1.0 version.


Possibility to run this as Coreboot payload

As far as I can see, this uses no BIOS routines at all.
Could this run as Coreboot payload?
Would be fun to port, even if just for educational purposes.

Yes, it's definitely possible with some amount of porting. The only interrupts BootMine uses are 0x10 (for printing strings and changing the graphics mode) and 0x16 (for getting keystrokes). I'm not sure if these are provided for Coreboot payloads, but if they aren't, the interrupt calls can be replaced with the lower-level operations that the interrupts do internally (probably communicating with IO ports) or be replaced with Coreboot routines.
I couldn't easily find details on the execution environment of Coreboot payloads, but it seems like they're 32-bit, ELF files, and relocatable (I could be wrong about this). This seems different from a boot sector or COM file's execution environment, although it's possible that Coreboot has more options for 16-bit flat binaries with a static load address.


fix : adds the arrayvec dependency

This commit adds the arrayvec dependency to the sortKey.
Potential fix #2276

Updated the arrayvec according to #2287

Code changes look good, thanks for the contribution! The commit message is stale, can you update it please. If you are interested in improving your git skills check out this blog on writing good commit logs: https://cbea.ms/git-commit/

Code changes look good, thanks for the contribution! The commit message is stale, can you update it please. If you are interested in improving your git skills check out this blog on writing good commit logs: https://cbea.ms/git-commit/

Sure, I'll check it out and update the commit.

Too late for that now, but I think it's not a big deal here.

Sorry, I meant to hold off on merging this until I gave you a chance to fix it, but I forgot.
I should update my ACK script to allow writing "ACK  except..." which will catch my eye.

I'll take care of it from next time.


Always On option documentation

"With the Always On feature, you can’t control the endpoint. It always sends a request to the application root."
"Endpoint" is referenced, but is not previously defined. Control of the endpoint is referenced, but is not defined. The pronoun "It" is ambiguous. The pronoun "you" is unclear. What enpoint? What is meant by control? What control is given up by this option?
This needs clarification and expansion. Please address.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e25899c-1ed8-7cfc-2c37-73bb010a87f0
Version Independent ID: 8b366c42-43f8-d5eb-b619-b356e75a9916
Content: Configure apps in the portal - Azure App Service
Content Source: articles/app-service/configure-common.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@HughDevlin  Thank you for bringing this to our notice, our team will look into it and get back to you at the earliest.


Add a terminology page to explain DPG concept

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.22087485,Service Bus:0.10993354,Azure.Core:0.046690904'

@pshao25, could you provide more description for this page? thanks

The simplest example is:

DPG
HLC
Convenience method
Subclient

@pshao25 is this still valid?


Rename add to create

Hi,
It's really weird that you specify the 'create' event for inotify and then listen on the 'add' event for javascript.
Please just keep this the same to avoid confusing one name with the other.
Cheers,
Mark

no related to the issue - Is this repo still active? @kerphi

no related to the issue - Is this repo still active? @kerphi

I doubt that as well.
After i made my slew of issues i took the code and made my own "fork" of this project.
It's different though. This project does more on incoming events (like checking if the file exists for create and move events). I don't say it's 'wrong', but just not something i needed. I merely needed an inotify implementation to get the inotify events in node.js, which i now have :) If there is an interest, i can push it to a repository and publish it on npm.

I'm just about to start a project which will need what this package seems to be doing, I'll let you know once I will start using it - hopefully it works out of the box :100:


[LYFT] [STRMCMP-1594] Using instance variables during Kafka Consumer / Producer instantiation

Problem

Pipelines with multiple Kafka Consumers/ Producers experienced challenges due to topics being a class variable rather than an instance variable. https://github.com/lyft/beam/commit/13bbb1502b7bf73e1835fdd0d780762ec258b0a6 . By using a list of kafka topics,

Fix

Marked the state variables at instance level.
Also fixed a loooooong outstanding bug with not instantiating the correct class FlinkKafkaSink  within the sink.

Test

Tested this fix on validation pipelines in ptmodelexec and realtimefactualsvalidation services.

/ptal @premsantosh @bhanuvikasr @sethsaperstein-lyft @leoluoInSea
cc @samuelfu


Improve syntax highlighting in the editor

Adds a highlighting mode to Ace for the sequence diagram language.
This is a bit nasty, a quick copy/paste/hack of asciidoc, but it makes the editor look a little better.

It feels like this should be a PR on Ace instead, but I thought it might reach the people who need it better if it was part of js-sequence-diagrams.
To use it, put mode-sequencebramp.js in js/ace and change your index.html to editor.getSession().setMode("ace/mode/sequencebramp");

Excellent @andrewdonkin I'll happily accept this! Would you mind resolving the issues that hound bot found.

Done.  I'd squash them if I could.


TEST Add Group tests for collating family IDs and getting all children

That's an annoying failure :/

I loosened the assertion a little, green now


image rotating when I dont want it to

I have some images that display correctly when loaded directly in the browser but are being rotated when I rezie using w_ q_. I am assuming the exif data in some of my images is wrong. Anyway was wondering if there was a way to prevent rotation when the image is resized. So far in my limited experiments flying is quite cool :) Thanks.

Hi @srsquare ,
thanks for reporting your issue and your feedback!
is it possible to provide an example image?

https://oi.flyimg.io/upload/w_600,q_80/ ... JackAttacked-Feb2021/IMG_20210215_003758.jpg
when I load the image directly its fine, but when passed through flying its upside down... I fixed it directly by rotating the img 90 degrees, saving it, rotating it back, and saving, and then it (among others) were fine. I just would like a way to tell flyimg not to rotate...

n

Hi @srsquare,
it seems your image contains metadata and Rotation information, and imagemagik uses that information.
to get around this issue, I've added a new option called auto-orient, you can add it to the flying URL options as ao_1
Please update your repo and give it a try.


Use tar on linux (removing the dependency on funzip)

I'd like to remove the dependency mac too, but we need to double check the signing procedure before doing so

Replaced with #49


Document better the differences between views, iterators and lazylists

useful pattern: x.view.[transforms].to(LazyList)

consolidating under https://github.com/scala/collection-strawman/issues/311


Path to labels.json

Currently with option Add Labels From Package I can only take the path from current directory, it would be awesome if I could specify path to some other directory with my labels.json or even HTTP so I can use a Gist.

I'd be happy to pick this up @himynameisdave.
I think the best approach would be to support other local paths now, and then look at HTTP support.

@Jameskmonger go for it!


Separate machine and compiler configuration

As we start playing with remote machines that may or may not be available at a given time, it'll be useful to be able to re-use the same machine configuration for various different compilers; enable/disable entire machines at a time; and maybe probe on the machine before making connections (or, eventually, even keep a single connection alive throughout act).
I propose changing compiler.spec so that it now has two top-level lists: a list of compilers as present and a list of machines, which'll be similar to the ssh blocks we have now.  We'll replace (ssh ...) blocks in compilers with a lookup into the machine table.  The machine blocks will have (enabled BOOL) configurables, just like the compilers.  The local machine will always be referred to as local, and can also be configured to a lesser extent.
Here's a mini-example:
(
    (machines
        (local
            (enabled true)
        )
        (ssh pi
            (enabled false)
            (host "<IP_ADDRESS>")
            (user pi)
        )
    )
    (compilers
        ((local gcc) ; naming here is just a convention
            (machine local) ; can be omitted
            (cmd gcc)
            (emits (x86 att))
        )
        ((local clang) ; naming here is just a convention
            (enabled false)
            (cmd clang)
            (emits (x86 att))
        )
        ((pi gcc)
            (machine pi)
            (cmd gcc)
            (emits (arm)
        )
    )
)

Done in f9c8a91cf05b0ad4f80e57f4d8eebadd6522c1da.


[Error: key] When creating feed

Hi 👋
I'm trying to run some minimal code with hypercore, but I can't make it start.
This fails at hypercore inmediatly, this is the relevant code
const hypercore = require('hypercore')
const key = process.argv[2] || 'global'
const feed = hypercore('./.data', key, { valueEncoding: 'utf-8' })

This throws the following error
$ node hypercore/minimal/index.js
C:\CLC\VIDA\Web\Comun\ypalma\hypercore-playground\node_modules\hypercore-crypto\index.js:133
  sodium.crypto_generichash(digest, HYPERCORE, publicKey)
         ^

Error: key
    at Object.exports.discoveryKey (C:\CLC\VIDA\Web\Comun\ypalma\hypercore-playground\node_modules\hypercore-crypto\index.js:133:10)
    at new Feed (C:\CLC\VIDA\Web\Comun\ypalma\hypercore-playground\node_modules\hypercore\index.js:79:42)
    at Feed (C:\CLC\VIDA\Web\Comun\ypalma\hypercore-playground\node_modules\hypercore\index.js:52:39)
    at Object.<anonymous> (C:\CLC\VIDA\Web\Comun\ypalma\hypercore-playground\hypercore\minimal\index.js:7:14)
    at Module._compile (internal/modules/cjs/loader.js:1151:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1171:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47

As you can see the erro doesn't say much, so I'm stuck. Am I doing something wrong?
Any help would be appreciated.

That's a very goofy error message, but try parsing the key into a buffer
const key = Buffer.from(process.argv[2] || 'global', 'base64')

I'm unsure whether the 'global' value would work - AFAIK it needs to be an 8-byte public key

Thanks, that worked! That length requirement is documented somewhere? I think it should.
closing this :)

It has to be a 32 byte public key buffer. I’ll make the assert a bit more sane


Convert WaitStatus to/from i32

I have raw waitpid statuses in a database that I want to be able to parse as WaitStatuses, but decode is not exposed.
I want to be able to serialize and deserialize WaitStatuses and going to/from the raw i32 seems like a good way to do that.

For 1, you should be able to cast it using as and if that doesn't work you can use mem::transmute.
As for serializing/deserializing, that should really be done by serde. Maybe we could add a feature to derive the relevant traits for appropriate types.

For 1, you should be able to cast it using as and if that doesn't work you can use mem::transmute.

I don't understand how this could work without calling decode somehow.

Ahh, indeed. Should've looked at the code first!
But i think I need some more context to really understand your use case and whether it should be supported here. So can you explain your use case more? You end up with a WaitStatus, and then what? As far as I can see there's no API inputs that are of type WaitStatus. So why convert them?

rr --- https://github.com/mozilla/rr --- records program execution and builds a trace which contains, among other things, process exit codes as reported by waitpid. It's written in C++.
I want to read those codes in a Rust program and then process them e.g. to distinguish regular exit from fatal signals and extract the fatal signal number. nix WaitStatus provides that logic but I can't use it.
(Actually I can only actually use it if the nix Signal type is extended to handle Linux RT signals as well. Right now nix just panics on such signals which is not good...)

I'm not entirely convinced this should be supported by nix, but I don't think I fully appreciate the use case. My main concern is that we purposefully encapsulate types in order to prevent invalid types from being created and I don't think i32 is the right intermediary here. Maybe what's better is to implement serde's Serialize/Deserialize traits (or whatever the equivalent are named, I've never used serde) and then you can use that for storing this values in the database and recovering them assuming your ORM would support it. That would be a general-use solution I would endorse including in nix and also remove even more logic from your program, because what you actually want to store are WaitStatus's, not i32s.
But I still have only a very narrow view of this context. I'd suggest you whip up some code to do what we want (for rr as well probably) and then we can iterate on it.

rr's written in C++ so I can't use nix there.
Another use-case is if you're writing something like strace in Rust. You'd then want to use ptrace to read memory from the tracee and convert the value into a WaitStatus to interpret it. This in in fact what rr does, so even if it was written in Rust we'd still need this conversion.

My main concern is that we purposefully encapsulate types in order to prevent invalid types from being created

Sure, so have decoding return Result<WaitStatus>.

Why don't we go ahead and move on to a PR for this and evaluate it there? Seems like a minimal amount of work to expose a useful new API.
Also, since you speak of strace, I want to ping @geofft here as he's writing gtrace, which is an strace implementation in Rust.

Filed https://github.com/nix-rust/nix/pull/741


fix signed url [do not merge yet]

This PR fixes the bug #15

Update: this PR needs more work. It confirm that if the method is "get_object" you need a ResponseContentType, while if you use a "PUT" you need a "ContentType", however it is not enough as the generated signed url is NOT suitable for put data. Indeed it is puzzling as I do not understand how to do exactly from the documentation.

This is superseded by https://github.com/nimbella/nimbella-sdk-python/pull/18


⚠ Bofrost.fr has degraded performance

In 3d3d8ab, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1020 ms

Resolved: Bofrost.fr performance has improved in 3e09afb.


Slow down my VS Code when enable this plugin

Describe the bug
Thanks for your awesome plugin. I enjoy it! But when I enable this plugin, my VS Code becomes slow.
To Reproduce
Steps to reproduce the behavior:
I only encountered this issue in this repo, sorry for couldn't provide a mini reproduction.

Clone repo https://github.com/Boshen/oxc.git
Following the CONTRIBUTE.md to setup
Search file crates/oxc_minifier/src/printer/gen.rs
try to type something.

Expected behavior
Maybe should write codes smoothly.
Screenshots
In this video, I am using the same typing speed.
enabled: [start - 0:30]
disabled: [0:50 - end]
https://github.com/mtbaqer/vscode-better-folding/assets/33973865/9ba1d24f-1dbe-49ed-80e3-ee3855b897de
Desktop (please complete the following information):

OS: macos 13.2.1, M1 Pro, 16 G.
Browser: Chrome
Version: v0.5.1

Additional context
None

Confirming that this is still an issue on 0.5.1 as well.


[plot] Allow to add custom item in the plot

This proposal is there to improve OO programming with the plot.

The current way to manage "legend" creates a lot of overhead in the code

addThing sometimes updates an existing item, sometimes not
Then a legend always have to be provided, which have to be unique
The kind is also always needed to remove an item
Some parameters are not provided by the functional API, then the item anyway have to be created with the functional API, then the object have to be reached using the legend, then the item can be updated with the desired arguments

The "kind" limiting custom third party objects (exception if nothing fit)
There is no public API to dead with plot items (add and remove are private)

Few changes could make the life easier.

[x] Create addItem(item) and removeItem(item). This 2 functions will not deal with legend/kind. An object is unique.
But addItem is already used for shapes, then...
[x] Copy addItem as addShape
[x] Update addItem to support both single item or shape arguments

The shape arguments can be deprecated in the next release
And can be removed the release after

[ ] Create public setActiveItem which takes an item

This should be enough to provide a cleaner API, without breaking the legend for the functional API.
Here what i expect to have
item = MyShape()
item.setThing()
plot.addItem(item)
self._item = item  # store the item somewhere for further use
...
plot.removeItem(self._item)

Well, the uniqueness of the legend is not a problem. The id of the item is unique so, it is enough to set the legend to the item's id to solve most of your caveats.

This deserves a reference to #2

For me the last missing thing is a global signal for the active item. I will create a dedicated issue for that.


Document the workflow from swagger.yaml to go files

Right now there is a manual step involved in generating swagger yaml files, see e.g., https://github.com/keptn/keptn/tree/master/mongodb-datastore
swagger generate server -A mongodb-datastore -f ./swagger.yaml --with-expand

It is unclear which version of swagger needs to be used,
It is unclear that this command also generates .go files
For devs it is not clear that this command needs to be executed everytime a change has been introduced, this should be automated!

Has been fixed with 0.6.1 release.


Dek manager

This elaborates on some of the ideas in #893, and also adds an abstraction mechanism to support multiple ciphers.
The AesIvGenerator has been copied (duplicated) from the inband package.
The APIs in this PR would replace those of KeyContext and AesGcmEncryptor.

Presented here mainly for discussion, rather than for merging any time soon.
But interested in what you make of it @robobario


Remove Queue package workarounds for older unsupported Pythons

Python 2.5 is neither supported nor tested by redis-py. Can remove
workaround.

Merged as 3f1e817f24b4b51c1d1f17a7c1ef5a3bc5746751


[Question] Delete Calls

Is there a feature to delete calls? If so how can I do it

https://github.com/victornpb/deleteDiscordMessages/issues/99#issuecomment-659885068


Remove unused struct

PR Details

Description

Remove unused struct
Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[x] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (18a160c) 99.06% compared to head (befd7a8) 99.06%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1746   +/-   ##
=======================================
  Coverage   99.06%   99.06%
=======================================
  Files          32       32
  Lines       28482    28482
=======================================
  Hits        28215    28215
  Misses        177      177
  Partials       90       90

Flag
Coverage Δ

unittests
99.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add popovers-methods link to sidenav

Hi @hadalin!
Thanks for wanting to contribute to Bootstrap by sending this pull request!
Unfortunately, your pull request seems to have some problems:

Normal pull requests should never be against the gh-pages branch.

You'll need to fix these mistakes and revise your pull request before we can proceed further.
Once you've fixed these problems, you can either ask the maintainers to re-open this pull request, or you can create a new pull request.
Thanks!
(Please note that this is a fully automated comment.)

FWIW that's already been taken care of for the next release https://github.com/twbs/bootstrap/commit/06bec750066fd6696d7beb9a6eef0519a37062b5


#869 Adding IPv6 option to config

+cp into v1.6 branch

@rootzoll This would have been a candicate for the "squash-merge"..! :-D


Package.json Update in devDependencies

Please add "mocha": "2.3.3" (or whatever version) to the devDependencies in package.json so the tests can run.
Thanks.
Joey

Done:
https://github.com/brutalhonesty/alexa-nodekit/commit/2137140406d651fbad782a30d63886de8750d1c5


SOCIAL-447: Fix OAuth2 redirect url when server is behind a proxy

https://jira.spring.io/browse/SOCIAL-447
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.
When we are behind a proxy which is terminating SSL and forwarding
our server http rather than the original https or the original user
request, OAuth2AuthenticationService will incorrectly generate a
redirect_uri using the http scheme rather than https.  A similar issue
can occur if the proxy is doing port translation.  To correct this, we
are replacing the original approach, which is to use
HttpServletRequest.getRequestURL() with an approach that looks for and
uses X-Forwarded-Proto and X-Forwarded-Port request headers, which
should be inserted by the proxy.

Which version of Spring-Social has this update?

@jaffadog Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@jaffadog Thank you for signing the Contributor License Agreement!

Would it be possible to backport this fix in the 1.1.x branch please?
Related: https://github.com/spring-projects/spring-social/issues/258


Update request access to get access for tools page

Description of change
When user does not have access to tool(s) on the tools page, the button now says Get access to {tool} instead of request access to {tool}
Checklist

[ ] Have tests been added to cover any changes?
[ ] Have E2E tests been added to cover any React changes?
[ ] Have Accessibility tests been added to cover any React changes?

Now covered in #3219


fix: use a cache file name with a fixed size.

Closes #348
📑 Description

Our current caching method creates a file with the following pattern:
$BACKEND_AI-$LANG-$SENC
SENC corresponds to a base64 encoding of the errors detected on an object during analysis.
This approach fails when we have multiple errors reported for the same object. The base64 string becomes too long, resulting in the following error:
error storing value to cache: open /Users/matthisholleville/Library/Caches/k8sgpt/openai-english-SW5ncmVzcyBrOHNncHQvZmFrZS1pbmdyZXNzIGRvZXMgbm90IHNwZWNpZnkgYW4gSW5ncmVzcyBjbGFzcy4gSW5ncmVzcyB1c2VzIHRoZSBzZXJ2aWNlIGs4c2dwdC9mYWtlLXNlcnZpY2Ugd2hpY2ggZG9lcyBub3QgZXhpc3QuIEluZ3Jlc3MgdXNlcyB0aGUgc2VjcmV0IGs4c2dwdC9mYWtlLXNlY3JldCBhcyBhIFRMUyBjZXJ0aWZpY2F0ZSB3aGljaCBkb2VzIG5vdCBleGlzdC4=: file name too long
To address this issue, we use SHA256 to encode filename and keep fixe file name size
✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed

ℹ Additional Information

I have also fixed another bug related to the no-cache feature. Previously, when we activated no-cache, the cache was not used, but the command result was not updated either. This resulted in bugs like the following:
$ k8sgpt analyze --explain

0 k8sgpt/fake-hpa(fake-hpa)
Error: HorizontalPodAutoscaler uses StatefulSet/fake-deployment as ScaleTargetRef which does not exist.
Fake

$ k8sgpt analyze --explain --no-cache

0 k8sgpt/fake-hpa(fake-hpa)
Error: HorizontalPodAutoscaler uses StatefulSet/fake-deployment as ScaleTargetRef which does not exist.
The HorizontalPodAutoscaler is trying to scale a StatefulSet/fake-deployment, which does not exist.

$ k8sgpt analyze --explain

0 k8sgpt/fake-hpa(fake-hpa)
Error: HorizontalPodAutoscaler uses StatefulSet/fake-deployment as ScaleTargetRef which does not exist.
Fake

I have fixed this issue so that when the --no-cache option is enabled, the cache is not used, but it is updated with the latest response.

For me, this looks good ...
@AlexsJones : What do you think?


Frontend auth and backend

this makes login/register sort of work on the frontend. a lot of the apis need userdetailsid which isn't
working on this branch from the backend, so it doesnt fully work.
the backend authfilter stuff is also working now. something weird with findbyId so I did it by hand.
if you don't a session you'll get UNAUTHORIZED response now, and login/register should give you
a session cookie in postman and the frontend.

if we merge this right now frontend will break a bit because its now using the backend and userdetailids isn't working properly on the frontend part, but at least the backend is authenticating now.


Embedded ldap connention refused

Hi
Do i need any additional configuration to setup embedded ldap, I have following dependency in my pom.xml
<dependency>
            <groupId>org.springframework.ldap</groupId>
            <artifactId>spring-ldap-core</artifactId>
        </dependency>
        <dependency>
            <groupId>org.springframework.security</groupId>
            <artifactId>spring-security-ldap</artifactId>
        </dependency>
        <dependency>
            <groupId>com.unboundid</groupId>
            <artifactId>unboundid-ldapsdk</artifactId>
        </dependency>
        <dependency>
            <groupId>org.springframework.security</groupId>
            <artifactId>spring-security-test</artifactId>
            <scope>test</scope>
        </dependency>

Also in application properties file
spring.ldap.embedded.ldif=classpath:test-data.ldif
spring.ldap.embedded.base-dn=ou=users,dc=cluster,dc=local
spring.ldap.embedded.port=8389
spring.ldap.embedded.url=ldap://localhost:8389/

But while running test i am getting connection refused.
org.springframework.ldap.CommunicationException: localhost:8389; nested exception is javax.naming.CommunicationException: localhost:8389 [Root exception is java.net.ConnectException: Connection refused]

I noticed in the guide that the @EnableWebSecurity annotation was missing from WebSecurityConfig.java. Maybe this is your issue.

@djnoddyp I added the annotation, still doesnt work.

I am having the same issue.

@MadKeys I resolved it by adding all my security configurations in my configuration class.. I don't why this happens.. below is the configuration I have for the ldap auth..
`
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Profile;
import org.springframework.ldap.core.LdapTemplate;
import org.springframework.security.authentication.encoding.PlaintextPasswordEncoder;
import org.springframework.security.config.annotation.authentication.builders.AuthenticationManagerBuilder;
import org.springframework.security.config.annotation.authentication.configuration.EnableGlobalAuthentication;
import org.springframework.security.ldap.DefaultSpringSecurityContextSource;
import org.springframework.security.ldap.userdetails.UserDetailsContextMapper;
import java.util.Arrays;
@Configuration
@Profile("DEV_STANDALONE_H2_TEST_LDAP")
public class TestApplicationSecurityConfigurationHolder {
private static final Logger LOG = LoggerFactory.getLogger(TestApplicationSecurityConfigurationHolder.class);
@EnableGlobalAuthentication
@Profile("DEV_STANDALONE_H2_TEST_LDAP")
public static class AuthConfigure {

    @Autowired
    protected void configureGlobal(AuthenticationManagerBuilder auth) throws Exception {
        LOG.info("#################");
        LOG.info("TEST");
        LOG.info("configuring ldap authenticaton");
        LOG.info("#################");

        auth
                .ldapAuthentication()
                .userDetailsContextMapper(ldapUserContextMapper())
                .contextSource(contextSource())
                .userDnPatterns("cn={0},ou=people")
                .groupSearchBase("ou=groups")
                .passwordCompare()
                .passwordEncoder(new PlaintextPasswordEncoder())
                .passwordAttribute("userPassword");
    }

    @Bean
    public DefaultSpringSecurityContextSource contextSource() {
        LOG.info("configuring embedded LDAP context source");
        DefaultSpringSecurityContextSource contextSource = new DefaultSpringSecurityContextSource(
                Arrays.asList("ldap://localhost:8389/"), "dc=springframework,dc=org");
        contextSource.afterPropertiesSet();
        return contextSource;
    }

    @Bean
    public LdapTemplate ldapTemplate(){
        return new LdapTemplate(contextSource());
    }

    @Bean
    public UserDetailsContextMapper ldapUserContextMapper() {
        return new AccountLdapContextMapper();
    }
}

}
`
The UserDetailsContextMapper is to map the ldap user and then give him permission or do with anything with him after he logs in.. (I do not think it 's important, I just had to explain it)

Same problem here, any solutions?

I was able to get mine to work by adding the ComponentScan annotation and pointing it to the package that contains my WebConfig file.
@SpringBootApplication @ComponentScan("com.xxx") public class StoreManager extends SpringBootServletInitializer { ...

Worked for me after adding compile("org.springframework:spring-tx")     compile("com.unboundid:unboundid-ldapsdk") to the build.gradle file

Worked for me after adding
compile("org.springframework:spring-tx") compile("com.unboundid:unboundid-ldapsdk")
to the build.gradle file

Worked for me after adding
compile("org.springframework:spring-tx")   compile("com.unboundid:unboundid-ldapsdk")
to the build.gradle file

It only seems to work when I use (1):
spring.ldap.embedded.ldif=classpath:test-server.ldif
If I use anything else, such as (2):
spring.ldap.embedded.ldif=src/main/resources/test-server.ldif
much less an external directory such as (3):
spring.ldap.embedded.ldif=/usr/local/clo/app/authserver/test-server.ldif
or even just the default project directory (4):
spring.ldap.embedded.ldif=test-server.ldif
None of these other options work - only option 1.

Works for me with additional changes as below:
application.properties
spring.ldap.embedded.base-dn=dc=springframework,dc=org spring.ldap.embedded.ldif=classpath:test-server.ldif spring.ldap.embedded.port=8389 spring.ldap.embedded.url=ldap://localhost:8389/

@michaellow thanks for sharing, worked for me as well with this configuration

It all works for me out of the box. All the changes suggested are already in the complete sample. Maybe if you have an issue check your maven/gradle caches for bad jars.
@dav0 if you want to use a file location for a resource you have to use the file: prefix (default is classpath).

worked for me - out of the box as the changes in the complete example.
However in my initial project i was initially getting this error - i found that the resources folder did not have the two files - application.properties and test-server.ldif
when i copied the two files in the initial - it worked

It only seems to work when I use (1):
spring.ldap.embedded.ldif=classpath:test-server.ldif
If I use anything else, such as (2):
spring.ldap.embedded.ldif=src/main/resources/test-server.ldif
much less an external directory such as (3):
spring.ldap.embedded.ldif=/usr/local/clo/app/authserver/test-server.ldif
or even just the default project directory (4):
spring.ldap.embedded.ldif=test-server.ldif
None of these other options work - only option 1.

Try this:
spring.ldap.embedded.ldif=file:///usr/local/clo/app/authserver/test-server.ldif

add in application.properties
spring.ldap.embedded.ldif=classpath:test-server.ldif
spring.ldap.embedded.base-dn=dc=springframework,dc=org
spring.ldap.embedded.port=8389

This does not work if you have different version of spring dependencies.
just do not mess up with dependencies demo app works as is.

它似乎只在我使用（1）时起作用： spring.ldap.embedded.ldif=classpath:test-server.ldif
如果我使用其他任何东西，例如（2）： spring.ldap.embedded.ldif=src/main/resources/test-server.ldif
更不用说外部目录，例如 (3)： spring.ldap.embedded.ldif=/usr/local/clo/app/authserver/test-server.ldif
甚至只是默认项目目录 (4)： spring.ldap.embedded.ldif=test-server.ldif
这些其他选项都不起作用 - 只有选项 1。

have you solve the question ? I have the same question like you

I want to konwn have you final solve the question? And how do you do it ?

Assuming you are following this guide (https://spring.io/guides/gs/authenticating-ldap/) and made your project with spring initializer, please check the dependency unboundid-ldapsdk. If there is scope Test remove it.


Bluetooth Icons

Add bluetooth.png for each theme.

Once #387 is merged, there should be active Bluetooth icons for Automatic, Systematic, Retroactive and Neoactive.  I went with the more official oval design because I liked how it looked with the background shapes.
I believe this should mean the majority of the themes have a bluetooth icon.  It appears that the icon has been added to all themes except for the Pixel theme.  If you feel this is sufficient to close this issue, feel free to do so.

It's been a while and this issue has been resolved in all but one theme.  I'm going to go ahead and close it, but if you feel like it needs to be reopened, please feel free to reply.


Tinker must be restarted for code to take effect.

Hello
I've started studying the Laravel framework on @JeffreyWay's Laracasts for a few hours and I noticed this:
Bug:
When using tinker, I receive the mass-assignment error even if the columns are whitelisted with $fillable. The error is:  Illuminate\Database\Eloquent\MassAssignmentException with message 'title')
How to reproduce:

Create a Model with a title column

Start tinker now

Whitelist the title for mass assignment

Try to add a new row and notice the error eg.
>>> App\Article::create(['title'=>'1st Article']);

Restart tinker

Repeat (4), this now it works

So...
Is there a way to avoid restarting tinker?

I think you mean tinker cause tinkster is way something else :D

@Anahkiasen Yep, thanks.

This is not a bug. It is how tinker works.

@JosephSilber I see, thanks.

@kadimi you might want to check out this repo: https://github.com/ajthinking/tinx

We've love contributions back to the original repo. We were discussing the possibility of restarts only recently.

@kadimi Here a simple bash command:
while true; do php artisan tinker; done
CTRL+D = reload
CTRL+C = exit
or
.profile file:
alias pat="php artisan tinker"
alias patt="while true; do php artisan tinker; done"
after type "pat" to normal tinker, and "patt" to continous tinker.

@GrahamCampbell Any more recent thoughts about how not to be required to restart Tinker after editing code?
I see "Laravel Tinx was archived on 12th December 2019 and is no longer maintained." but also that it seems to be just a suggestion like https://github.com/laravel/framework/issues/8504#issuecomment-478248339
@szekeresa It seems to work for me so far (+1), but would you mind explaining what that is doing and what the downsides are of running Tinker that way?
Thanks!

@szekeresa It seems to work for me so far (+1), but would you mind explaining what that is doing and what the downsides are of running Tinker that way?
Thanks!

This command while true; do php artisan tinker; done runs a loop with tinker, and every time you close it by Cmd+D or exit it the loop starts over again, so it reloads the classes and all the lot. Cmd+C closes it.


Question: Is -Xcli.debug=true actually necessary for correct metrics in JRuby?

We're using JRuby 1.7.x and 9000 and when we use
JRUBY_OPTS="-Xcli.debug=true --debug" bundle exec rspec

we get what we believe are accurate coverage metrics, but a lot of extra debug output. For one test suite, the extra output was 10,000+ lines in JRuby 1.7.x, but down to ~150 in 9000. Manageable, but still annoying. But when we remove -Xcli.debug=true, like so
JRUBY_OPTS="--debug" bundle exec rspec

we get the same coverage metrics but without the extra output. So this begs the question, is -Xcli.debug=true really necessary. It appears that is all the code is checking for, even though it suggests --debug in the warning:
From simplecov/lib/simplecov.rb:4-13:
# Coverage may be inaccurate under JRUBY.
if defined?(JRUBY_VERSION)
  if ENV["JRUBY_OPTS"].to_s !~ /-Xcli.debug=true/
    warn "Coverage may be inaccurate; Try setting JRUBY_OPTS=\"-Xcli.debug=true --debug\""
    # see https://github.com/metricfu/metric_fu/pull/226
    #     https://github.com/jruby/jruby/issues/1196
    #     https://jira.codehaus.org/browse/JRUBY-6106
    #     https://github.com/colszowka/simplecov/issues/86
  end
end

@headius @enebo Is it simple impossible to get similar-to-MRI C0 code coverage details on JRuby 9000?  Does -Xcli.debug=true --debug no longer help improve how JRuby calculates coverage of Ruby lines?

That is true indeed. Running it against couple JRuby projects I have I get the same coverage without -Xcli.debug=true but with just --debug.

AFAIW --debug sets that flag for you, but while this topic is on the books, it constantly warns about this option even if we set it in .jrubyrc it would be nice if it detected this option in a cleaner way.

@envygeeks hmm.  I looked into how to get this info from the runtime at one point but didn't succeed.  Any help is appreciated.

At the time I did try just --debug https://github.com/metricfu/metric_fu/commit/7fd31ea637ac0747b85bd2d11889de412f29496f but I haven't played with it since
@enebo https://twitter.com/tom_enebo/status/462289024107814914
recommended JRUBY_OPTS="-Xcli.debug=true"
but that didn't work and caused other failures
JRUBY_OPTS="--debug" Still produced the below error, as did
JRUBY_OPTS="--debug -Xcli.debug=true"

Failure message was
home/travis/build/metricfu/metric_fu/gemfiles/vendor/bundle/jruby/1.9/gems/simplecov-0.8.2/lib/simplecov.rb:31 warning: tracing (e.g. set_trace_func) will not capture all events without --debug flag

SimpleCov::Formatter::MetricFu calculates the same coverage from an RCov report as from SimpleCov
     Failure/Error: expect(source_file.coverage.count).to eq(covered_lines_from_rcov_text.count)

       expected: 11
            got: 8

       (compared using ==)
     # /home/travis/build/metricfu/metric_fu/spec/metric_fu/metrics/rcov/simplecov_formatter_spec.rb:52:in `(root)'

Coming to correct myself, it seems there is no --debug as it's not listed in the JRuby help but I know you can quickly detect debug mode with this:
jruby --dev -Xcli.debug=true -e '$stdout.puts JRuby.runtime.debug?'
true

Seems like that could be a PR right there

@bf4 I'm playing with JRuby a bit to see what options it has so far but I'll ship one after I finish testing, so far I know that the --debug option we thought existed is actually simply -d (that might be a bug in JRuby?) but here is what I've gathered so far quickly:
jruby --debug # Does not trigger JRuby.runtime.debug?
echo cli.debug=true > .jrubyrc # Triggers JRuby.runtime.debug?
jruby -Xcli.debug=true # Triggers JRuby.runtime.debug?
jruby -d # Triggers JRuby.runtime.debug


feat: change landing page hero

Motivation
Make the landing page a bit nicer so that it looks more presentable during F8.
There's the announcement changes in this PR as well as they're on the same branch, please ignore those parts when reviewing this.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan

Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

1290Sent from my Samsung Galaxy , an AT&T LTE smartphone
-------- Original message --------From: Docusaurus-Bot<EMAIL_ADDRESS>Date: 3/20/19  3:20 AM  (GMT-06:00) To: facebook/Docusaurus<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [facebook/Docusaurus] feat: change landing page hero (#1290) Deploy preview for docusaurus-preview ready!
Built with commit 44082c5
https://deploy-preview-1290--docusaurus-preview.netlify.com
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/facebook/Docusaurus","title":"facebook/Docusaurus","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/facebook/Docusaurus"}},"updates":{"snippets":[{"icon":"PERSON","message":"@docusaurus-bot in #1290: Deploy preview for docusaurus-preview ready!\n\nBuilt with commit 44082c51c14648d9bc2ec93720e508b75dc994ca\n\nhttps://deploy-preview-1290--docusaurus-preview.netlify.com"}],"action":{"name":"View Pull Request","url":"https://github.com/facebook/Docusaurus/pull/1290#issuecomment-474731138"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/facebook/Docusaurus/pull/1290#issuecomment-474731138",
"url": "https://github.com/facebook/Docusaurus/pull/1290#issuecomment-474731138",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]


[Outlook] (availability) List all applicable modes per platform

Docs Build status updates of commit 483e75d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/office-add-in-availability.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[LLVMGPU] Cleanup VirtualMMA functions to match refactoring on base MMAAttr

Apply similar cleanups to what is done in https://github.com/iree-org/iree/pull/19098. For most part we do:

Templateize getVectorType and getOpaqueMmaLayout to work on any intrinsic
Use common getOpaqueMmaLayout for VirtualMMA
Update getABCElementTypes to be similar to MMAAttr
Rename get.*MFMA fn to get.*MMA since MFMA is CDNA specific but in
reality it does not have to be MFMA instructions

I'm going to hit merge for you because @Groverkss said he'd make changes to this file tomorrow, which would conflict.


suppress warning 16

This PR would fix issue https://github.com/owlbarn/owl/issues/594
It probably needs some discussion first, whether this is the right way to fix the mentioned compiler warnings.

Thanks! The fix looks OK to me. Still not quite clear about the reason we have these warnings, and currently I can't think of a better way to suppress them.  Any suggestion? @ryanrhymes


WPF plot control resize leads to chart becoming smaller

Issue: Resizing the WPF plot control repeatly leads to pie chart becoming smaller due to the axis range steadily increases:

ScottPlot Version: 5.0.44 (latest)
Code Sample:
Create a new .net8.0 WPF project with a minimal window:
<Window x:Class="ScottPlotTest.MainWindow"
        xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:ScottPlot="clr-namespace:ScottPlot.WPF;assembly=ScottPlot.WPF"
        Title="MainWindow" Height="450" Width="800">
    <ScottPlot:WpfPlot x:Name="Plot"/>
</Window>

using System.Windows;

using ScottPlot;

namespace ScottPlotTest
{
    public partial class MainWindow : Window
    {
        public MainWindow()
        {
            InitializeComponent();

            List<PieSlice> slices = new()
            {
                new()
                {
                    FillColor = Colors.Red,
                    Value = 10
                },
                new()
                {
                    FillColor = Colors.Yellow,
                    Value = 20
                },
                new()
                {
                    FillColor = Colors.Orange,
                    Value = 30
                }
            };
            Plot.Plot.Add.Pie(slices);
        }
    }
}

Steps to reproduce:
Use the mouse to repeatly resize the window up and down.

Hi @Fruchtzwerg94, thanks for reporting this!
Adding additional context, this behavior is because the Pie will always zoom out to make sure that axis limits are "square", so repeatedly changing the aspect ratio only zooms out. Related: #4422
https://github.com/ScottPlot/ScottPlot/blob/db251c67d9e6a3f393fde4d1704eabb6318d4ffc/src/ScottPlot5/ScottPlot5/Plottables/PieBase.cs#L33-L44
See these for more context:

https://github.com/ScottPlot/ScottPlot/issues/4422#issuecomment-2453474843
https://github.com/ScottPlot/ScottPlot/issues/4422#issuecomment-2453476928
https://github.com/ScottPlot/ScottPlot/issues/4422#issuecomment-2453506755

I'm not totally sure an easy fix is achievable... but it may be worth implementing that SquarePreserveSmallestAxis axis rule and using it in PieBase to see if it fixes this problem.
I'll keep researching for a simpler/temporary fix until I decide what action I should take tonight...

I'll keep researching for a simpler/temporary fix until I decide what action I should take tonight...

This seems to work! Now it makes me wonder if the entire square units behavior can be discarded...
var pie = formsPlot1.Plot.Add.Pie([10, 20, 30]);
pie.ManageAxisLimits = false;

I'll close this issue for now without taking action, but these are my conclusions:
Temporary fix: disable the "automatic zoom out" behavior like this:
var pie = formsPlot1.Plot.Add.Pie([10, 20, 30]);
pie.ManageAxisLimits = false;

Remaining problem: Slice labels are placed using the coordinate system so if "square units" aren't enabled, the placement of labels gets really bad.
Best solution (contributions are welcome!): PieBase could be refactored to remove IManagesAxisLimits, ManageAxisLimits, and UpdateAxisLimits() so pie charts no longer require square units. However, the logic that determines where slices are so text can be rendered there must be adapted to place text correctly since the coordinates would now have to be multiplied by the ratio of the horizontal and vertical axis limit span. This information is available inside the Render() method like this:
float WidthHeightRatio = rp.DataRect.Width / rp.DataRect.Height;


Add a "Pending invitations" link in user menu

User story
As an Open Collective user, I can quickly find the pending invitations that were sent to me to join a collective.
Best solution for this problem
In the user menu, fetch the user pending invitations. If there are some, display a link to member-invitations with the total count.

@Betree how can I get the no. of pending invitations ?

Ideally, we would create a dedicated memberInvitationsCount to avoid returning the whole data. But there are not a lot of them, so I'm fine with just fetching memberInvitations and use the length.
One thing tho: in the spirit of #2126, we may want to fetch the data dynamically from TopBarProfileMenu.

@rista404 thank you for completing this one! Feel free to assign yourself on the issue if you want to, we sometimes use this info to get a glimpse of who contributed already.
We also added you to https://github.com/orgs/opencollective/teams/contributors/members. You can now push directly to most Open Collective repos :tada: (only the master branches are protected).

@shannondwray can you please document this feature?

Where would I find this now Ben?

@shannondwray it's still in the same place, even with the new menu. But the link only appears if you have pending invitations. I can invite you to a test collective if you need to screenshot this, just let me know.

yes please!


Add is_accelerated_network_supported in VhdSchema

Some VHDs don't support accelerated network. Add is_accelerated_network_supported in VhdSchema, so users can define the accelerated network capability for the VHD.
Add _check_image_capability to check if the image can support AN. If not, and test cases require an SRIOV data path, then raise NotMeetRequirementException.
If the VHD doesn't support AN, then set the network interface data path as Synthetic, Lisa will deploy VM without AN enabled.

@LiliDeng  LGTM


update correlation qc

minor expansion to Correlation QC visualization:

makes spreadsheet a bit easier to view at a glance
adds by-well plate view of failed correlations

added in code so that site with NA values don't plot on plate overviews of {compartment}_thresholds and confluence.

@gwaygenomics thanks for the review!
Sorry again about wasting your time on the site naming mistakes. Yes, they were from using an older version.
I think I've addressed all your suggestions, other than naming the new plot. Perhaps with my more thorough description of the goal of the plot you can help suggest a better name for it?


Feature request: Add an option to filter tags by name

Hi,
It would be great if we could filter tags by name. For example for css based files, where you could have the same tag in multiple locations, for example:
// Anchor element 1
// Anchor element 2
// Anchor element 3
// Anchor element 1
...
// Anchor element 1.
There are multiple instances for that specific element, and if I could just filter them by typing their name, that would be a great feature

@JordanDi123 , also it would be really great to filter by type of anchor ('FIXME', 'TODO', etc.).
And by the way, congratulations for this extension, it's very thoughtful.


Document reserved identifiers

Note somewhere in documentation that keywords, the names of builtin types, all identifiers beginning with a double underscore, and _start are reserved.

Folding this ticket into https://github.com/ashn-dot-dev/sunder/issues/45.