[Fix-13381][plugin] fix error while parsing hive load sql

Purpose of the pull request
This pull request fix parsing error while using variables in sql like load inpath '/path/paramName=${paramValue}'.
Currently, all quotes around a param defenition are removed after replacing, but sometimes quotes are part of a sql. For example, when load data into hive table, sql looks like LOAD DATA [LOCAL] INPATH 'filepath' [OVERWRITE] INTO TABLE tablename, quotes around the filepath are both part of sql.

fix #13381
Brief change log
fix regex matching params.
Verify this pull request
Verified manually.

Codecov Report

Merging #13378 (34e6547) into dev (dd0d730) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #13378      +/-   ##
============================================
+ Coverage     39.45%   39.47%   +0.01%
- Complexity     4311     4314       +3
============================================
  Files          1083     1083
  Lines         40756    40756
  Branches       4673     4670       -3
============================================
+ Hits          16079    16087       +8
+ Misses        22890    22880      -10
- Partials       1787     1789       +2

Impacted Files
Coverage Δ

...dolphinscheduler/plugin/task/api/AbstractTask.java
0.00% <0.00%> (ø)

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
50.00% <0.00%> (+6.45%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

good job, thanks for your first contribution.
Can you add some unit tests for this regex?

done

good job, thanks for your first contribution. Can you add some unit tests for this regex?

@davidzollo done

I had approved to run CI.

TBR
@SbloodyS @caishunfeng

It is not the must fix bug for 3.0.x and will change our behavior, I think we should put it into 3.2.0

I approval the CI run

@alextinng can you run command mvn spotless:apply locally to pass code style check?

@alextinng can you run command mvn spotless:apply locally to pass code style check?

done, Please Take A Look

seem CI error, I re-trigger the CI

seem CI error, I re-trigger the CI

seems ci is not triggered automatically...... bad experience

seem CI error, I re-trigger the CI

Error:  Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 252.288 s <<< FAILURE! - in org.apache.dolphinscheduler.e2e.cases.WorkflowE2ETest
Error:  testRunWorkflow  Time elapsed: 19.917 s  <<< ERROR!
org.awaitility.core.ConditionTimeoutException:
Assertion condition defined as a lambda expression in org.apache.dolphinscheduler.e2e.cases.WorkflowE2ETest that uses org.apache.dolphinscheduler.e2e.pages.project.ProjectDetailPage
Expecting value to be true but was false within 10 seconds.
at org.apache.dolphinscheduler.e2e.cases.WorkflowE2ETest.testRunWorkflow(WorkflowE2ETest.java:182)
Caused by: java.util.concurrent.TimeoutException
at org.apache.dolphinscheduler.e2e.cases.WorkflowE2ETest.testRunWorkflow(WorkflowE2ETest.java:182)

restart the failed CI

approval CI

BTW, ci still failed
On Sat, May 6, 2023 at 5:38 PM sonarcloud[bot] @.***>
wrote:

SonarCloud Quality Gate failed.    [image: Quality Gate failed]
https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13378
[image: Bug]
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=BUG [image:
A]
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=BUG 0
Bugs
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=BUG
[image: Vulnerability]
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=VULNERABILITY [image:
A]
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=VULNERABILITY 0
Vulnerabilities
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=VULNERABILITY
[image: Security Hotspot]
https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=SECURITY_HOTSPOT [image:
A]
https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=SECURITY_HOTSPOT 0
Security Hotspots
https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=SECURITY_HOTSPOT
[image: Code Smell]
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=CODE_SMELL [image:
A]
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=CODE_SMELL 1
Code Smell
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=CODE_SMELL
[image: 42.9%]
https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13378&metric=new_coverage&view=list 42.9%
Coverage
https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13378&metric=new_coverage&view=list
[image: 0.0%]
https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13378&metric=new_duplicated_lines_density&view=list 0.0%
Duplication
https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13378&metric=new_duplicated_lines_density&view=list
—
Reply to this email directly, view it on GitHub
https://github.com/apache/dolphinscheduler/pull/13378#issuecomment-1537102218,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADYWN4VRSUIVOFTNDRHGL4DXEYLXXANCNFSM6AAAAAATXXE4G4
.
You are receiving this because you commented.Message ID:
@.***>

--
Best Wish
—Jay Chung

BTW, CI still failed

BTW, ci still failed
…
On Sat, May 6, 2023 at 5:38 PM sonarcloud[bot] @.> wrote: SonarCloud Quality Gate failed. [image: Quality Gate failed] https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=13378 [image: Bug] https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=BUG [image: A] https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=BUG 0 Bugs https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=BUG [image: Vulnerability] https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=VULNERABILITY [image: A] https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=VULNERABILITY 0 Vulnerabilities https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=VULNERABILITY [image: Security Hotspot] https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=SECURITY_HOTSPOT [image: A] https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=SECURITY_HOTSPOT 0 Security Hotspots https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=SECURITY_HOTSPOT [image: Code Smell] https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=CODE_SMELL [image: A] https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=CODE_SMELL 1 Code Smell https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=13378&resolved=false&types=CODE_SMELL [image: 42.9%] https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13378&metric=new_coverage&view=list 42.9% Coverage https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13378&metric=new_coverage&view=list [image: 0.0%] https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13378&metric=new_duplicated_lines_density&view=list 0.0% Duplication https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=13378&metric=new_duplicated_lines_density&view=list — Reply to this email directly, view it on GitHub <#13378 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYWN4VRSUIVOFTNDRHGL4DXEYLXXANCNFSM6AAAAAATXXE4G4 . You are receiving this because you commented.Message ID: @.>
-- Best Wish —Jay Chung

I'm troubleshooting this problem, you may ignore ci task until I solved this issue.

you can start the standalone server in your IDEA, and then open new IDEA windows and run command
./mvnw -B -f dolphinscheduler-api-test/pom.xml -am \
    -DfailIfNoTests=false \
    -Dcheckstyle.skip=false \
    -Dtest=org.apache.dolphinscheduler.api.test.cases.TenantAPITest test

I have force push to run de ci

will test wether is work or ot

will take over this patch after #https://github.com/apache/dolphinscheduler/pull/14094 merge

it is odd still failed

I have conducted detailed testing in my local environment. So far, what can be confirmed is the issue with the github actions. But the triggering conditions have not been determined yet.
I think we can ignore api-test-result for now and merge this PR until we find a solution to the problem. WDYT? @zhongjiajie @EricGao888

That sound good to me, but I want to try it one more time. please wait

still failed 😭

can you add some short desc in https://github.com/apache/dolphinscheduler/blob/d46e4659d917e1994bc9045c57fe3b865a308352/docs/docs/en/guide/upgrade/incompatible.md#L9-L8 to tell users this incompatible change? @alextinng


Release 1.0.2

@Dayou-Zhang I'm not sure if the citation in dcfnal.py is accurate. Please correct me and add more if I missed any.

@sunqm Here is a list of citations associated with the MC-DCFT code. Can you please update it for me? Thank you.
Reference:
[1] Multiconfiguration Density-Coherence Functional Theory
    Dayou Zhang, Matthew R. Hermes, Laura Gagliardi and Donald G. Truhlar
    J. Chem. Theory Comput. 2021 17 (5), 2775-2782
    DOI: 10.1021/acs.jctc.0c01346
[2] DC24: A new density coherence functional for multiconfiguration
    density-coherence functional theory.
    Dayou Zhang, Yinan Shu and Donald G. Truhlar
    J. Comput. Chem. 2024.
    DOI: 10.1002/jcc.27522


One failed sample causes the entire pipeline to crash

Version info

bcbio version (bcbio_nextgen.py --version): 1.2.8
OS name and version (lsb_release -ds): "CentOS Linux release 8.1.1911 (Core) "

To Reproduce
Exact bcbio command you have used:
bcbio_nextgen.py /expanse/projects/qstore/csd686/kfisch/sample_sheet_new.yaml \
-n 64 \
-t local \
--workdir /expanse/projects/qstore/csd686/kfisch/

Your sample configuration file: attached
bcbio-nextgen.log
Observed behavior
Error message or bcbio output: Running the ATACseq pipeline, one of the several samples failed at the MACS2 step as the bam file wasn't properly formed. This resulted in a non-zero exit status of BCBIO that I can't move past with this one failed sample.

bcbio-nextgen-commands.log
Expected behavior
I expected that a single failed sample would throw the error that I observed, get flagged in an error report so I know this sample failed and then would be skipped so the rest of the samples/pipeline could finish.
Log files
Please attach (10MB max): bcbio-nextgen.log, bcbio-nextgen-commands.log, and bcbio-nextgen-debug.log.
Additional context
Thank you!

Hi @kmfisch
Thanks for reporting and sorry about the issues!
You are running bcbio 1.2.8, so your issue is not related to the latest big update.
Could you please attach your yaml config file?
Also, what is your macs2 version? (macs2 --version)
Thanks!
Sergey

Hi @naumenko-sa Thank you! Attached is the yaml config file. I'm running MACS2 <IP_ADDRESS>. I dug deep into this and it was a low reads file that didn't have any reads aligned in the *-DN.bam. So the fact that this file had 0 reads is expected, but what what unexpected is that instead of skipping it or throwing a warning in the log that this had 0 reads and was being skipped, it crashed the entire
sample_sheet_new.yaml.txt
pipeline. Thank you!
Katie

Hi Katie @kmfisch !
Thanks for the excellent work debugging!
I agree, we should at least give an error message in such a case.
I pushed a fix here: https://github.com/bcbio/bcbio-nextgen/pull/3562.
As a rule of thumb, we are trying to error out on the bad data in bcbio - to make this fact known as early as possible
rather than handling exceptions and proceeding.
You are on bcbio1.2.8, but if you could install a separate latest dev bcbio and test out this commit - that would be a great help.
How to install a separate bcbio:
https://bcbio-nextgen.readthedocs.io/en/latest/contents/development.html#creating-a-separate-bcbio-installation
Or if you could share fastq files for the failed samples (are they just empty or have some reads?) that would also be helpful.
Sergey


Design choices for adding rerankers/cross-encoders

@KennethEnevoldsen @Muennighoff
Before I implement a solution, I wanted to sketch out my potential direction.
Cross-encoders need to take both query and document at the same time.  This is somewhat orthogonal to the early design of mteb (it's not about embeddings or the e in mteb) and so many abstract tasks will require some heavy changes as they expect embeddings (see BitextMining or STS).
I can see two options:

Update all abstract tasks to take cross-encoders, will require changing each abstract task to check for the model type and generate results from either of the options
Update just the most relevant tasks (Retrieval) and just don't allow rerankers in some of the other classes like BitextMining or STSEvaluator.

I would've liked to do this just by extending the DRESModel class without any other changes, but the AbstractTasks themselves make that impossible since Cross-Encoders can't return embeddings
I'm fine with either proposal, but wasn't sure how big of a change we wanted.  I'm also fine implementing it just for retrieval and instruction retrieval and then others can extend it later.

My thinking for how to structure this:

define a new model class Reranker (or CrossEncoder) that takes in the usual arguments like model name, batch size, etc. and  also includes a DRESModel or a path to the results of a DRESModel. The reranker class will implement a search function that only does reranking, taking in queries and documents at the same time based on the top N results from the DRESModel.
Change the abstract tasks to check for this model type and if so, to pass both query/doc in rather than do the normal query and document separately.

Please let me know if there's another way I should be structuring this change!

@orionw I have actually been considering adding in a model interface object (a python protocol). If you are familiar feel free to create a protocol for the CrossEncoder otherwise I will create one from the Encoder and then we can extend it from there.

model interface object (a python protocol)

Do you mean like a pure abstract class / mixin style object?  I'm not very familiar with interfaces in Python.
Unfortunately, I don't think there is much similarity between CrossEncoders and the standard Encoders -- although the names suggest similarity, CrossEncoders don't really share any of the same methods.  CrossEncoders are really just another name for LLMs adapted to retrieval tasks these days.

Is there any standard interfaces for CrossEncoders we can rely on for this?

A great question, also not really.  I was planning to make the rerank method throw an error if not extended as a type of abstract class to force users to define it.  There are a few general types of reranking, but usually it's model specific (a specific token true/false or a specific listwise reranking, etc.).

Great discussion! I think that from a user-perspective, the best way would be to in addition to supporting

Great discussion. I think that for users the best way would be to in addition to supporting
from mteb import MTEB
from sentence_transformers import SentenceTransformer
model_name = "average_word_embeddings_komninos"
model = SentenceTransformer(model_name)
evaluation = MTEB(tasks=["Banking77Classification"])
results = evaluation.run(model, output_folder=f"results/{model_name}")

we also support
from mteb import MTEB
from sentence_transformers import CrossEncoder
model_name = "average_word_embeddings_komninos"
model = CrossEncoder(model_name)
evaluation = MTEB(tasks=["Banking77Classification"])
results = evaluation.run(model, output_folder=f"results/{model_name}")

where CrossEncoder from SentenceTransformers could be the standard interface? Not sure how well it works but @tomaarsen may have thoughts.
Then users can combine them in anyway they want by passing previous result files and a value k for how much to rerank? I.e. you can also rerank with a bi-encoder if you want to.
Just my thoughts, I may be mistaken / other ways may be better! :)

Do you mean like a pure abstract class / mixin style object? I'm not very familiar with interfaces in Python.

A protocol is quite distinct from a abstract class in the case that it does not need to inherit e.g. a SentenceTransformer can implement a Encoder protocol (it is a class with an encode method) without ever inheriting from the Encoder protocol. You can see an example here in the SEB.
Basically it just specifies what methods you want from the object. A popular saying is: "if it quacks [implements .quack()] like a duck and swim like a duck [has method .swim()] it is a duck [even though it isn't a subclass of duck]" ;)
It is not too different from an abstask really with the exception that it rarely defines functionality and does not require inheritance.
Python primatives like Sequence (e.g. list, tuples), Iterable,  Mapping (e.g dict)  are all protocols.

Ahh right so maybe let us built the CrossEncoder interface around the sentence transformer interface if possible

What a wonderful coincidence! Just yesterday I was drafting a potential extension of MTEB with CrossEncoder models! Or perhaps it's not a coincidence, if you were also inspired by yesterday's Jina reranker models.
In my experiments, I only attempted to extend MTEB for Retrieval, though I didn't get very far. MTEB has a sizable collection of high quality datasets, and (re-)using them for reranking seems quite valuable. That said, a big concern of mine was that CrossEncoder models are slow: they're not normally used for retrieval across a ton of documents, but instead for reranking.
We might have to be a bit smart and selective with our datasets as a result, or select subsets instead, but I dont think this should be a problem.
Additionally, I think it makes sense to start small: we don't need to necessarily support all tasks out of gate, especially as CrossEncoders are primarily used for retrieval and reranking tasks.
Regarding using the SentenceTransformers CrossEncoder as a "standard" model: I think that would work quite well. Just like with the current bi-encoder implementation, we don't have to require that the model is a CrossEncoder instance, just that it supports the relevant methods: __init__, predict and rank (or variations, if desired, like predict_batch). @KennethEnevoldsen's idea regarding protocols works well with this, and CrossEncoders will fit the protocols nicely, allowing for easy tests as there's quite a few open reranker models that would benefit from benchmarking.
Additionally, I want to notify you that I intend to invest more time into improving CrossEncoders within Sentence Transformers. The bi-encoders are getting improved support through better training next month or so, and cross encoders are also in the pipeline afterwards. My ideas include easier training, loss logging, bfloat16 training, multi-gpu training, automatic model card generation, a "Use in Sentence Transformers" button on Hugging Face, etc.
I'd be glad to assist this effort, both here directly and via changes in Sentence Transformers, if beneficial. That also includes reviews, running benchmarks, etc. I think this can be very impactful for model authors, researchers and NLP practitioners alike.

Tom Aarsen

Thanks for the comment @tomaarsen! That is wonderful news and I agree with your comments about them being very expensive. I did see the Jina rerankers but was doing this to incorporate some results from my recent FollowIR paper, so unfortunately it was not as selfless as you are. Thanks for your help on SentenceTransformer and its really exciting to hear that CrossEncoders will be improved :)
I've made a PR that accomplishes this, those of you that are interested/able to review it please feel free to check out #457.

I believe this issue can be closed - do re-open if there is something I missed


Reworked mm_override.cfg

Added more commands and fixed some values. Also the positioning is now alphabetically.

Are these commands blocked by competitive?

Are these commands blocked by competitive?

Not sure, I'm adding some default values to various commands that mastercomfig changes. I'll update the mm_override.cfg now.

I can get the list of allowed cvars for you.

I can get the list of allowed cvars for you.

Alright.

https://gist.github.com/mastercoms/c4b65d588a486cd58c765eccce284144

Alright, what I can do? I am confused.

Competitive mode uses a whitelist, rather than a blacklist, to stay on the safe side. The cvars in the files allowed-in-competitive.txt, hidden.txt, and internal-use.txt are allowed in competitive. They don't need to be reset. Then, in cvarlist.log, the cvars with GAMEDLL, ARCHIVE, REPLICATED, and CHEAT are not reset by competitive mode.
Finally, viewmodel_fov and mat_dxlevel have restricted values in competitive mode, but I don't think you need to set those.

What about cvars with CLIENTDLL?

They are reset if they do not have any of the other flags.

I'm here editing the cvarlist.log file and I already found close caption cvars (cc_). It is strange that they are reset.

Not a surprise. TF2 does not have any captions by default, being a competitive multiplayer title. People can override their captions using things like Clovervidia's captions to get a competitive advantage.


StreamBuilder always ConnectionState.waiting on iOS device, on Android device ConnectionState.active

Connection state at function submitButton always wating on iOS Device.
Widget submitButton(LoginBloc bloc) {
    return StreamBuilder(
      stream: bloc.submitValid,
      builder: (context, snapshot) {
        return RaisedButton(
            child: Text('Login'),
            color: Colors.blue,
//          if one of the two streams has an error, or has no data, the button onPressed gives null to stay unclickable
            onPressed: snapshot.hasData ? null : null);
      },
    );
  }

this file for login Screen :
login_screen.txt
this file for login bloc
login_bloc.txt

Please consider asking support questions in one of the other channels listed at http://flutter.io/support .


running react-native run-ios does not launch app

I'm trying to run the PizzaLocation app but When running react-native run-ios it outputs Build Succeeded but nothing launches. I've looked around online but haven't had any luck finding anything.
I get the following output in terminal
** BUILD SUCCEEDED **

The following commands produced analyzer issues:
	Analyze Base/RCTModuleMethod.mm
	Analyze Modules/RCTUIManager.m
(2 commands with analyzer issues)

Installing build/Build/Products/Debug-iphonesimulator/PizzaApp.app
Launching org.reactjs.native.example.PizzaApp
org.reactjs.native.example.PizzaApp: 42784

And then in my other terminal window I see this, but nothing else happens from here.
Metro Bundler ready.

Loading dependency graph, done.
 BUNDLE  [ios, dev] ./index.js ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ 100.0% (1974/1974), done.

Steps to reproduce

ignite new PizzaApp

Andross selected
No i18n
No Animation

run react-native run-ios.

ignite doctor results:
System
  platform           darwin
  arch               x64
  cpu                4 cores                                                            Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
  directory          /Users/xxx/Documents/xxx/React/react-native/PizzaApp
vvv -----[ DEBUG ]----- vvv
{ Error: not found: yarn
    at getNotFoundError (/usr/local/lib/node_modules/ignite-cli/node_modules/gluegun/node_modules/which/which.js:13:12)
    at Function.whichSync [as sync] (/usr/local/lib/node_modules/ignite-cli/node_modules/gluegun/node_modules/which/which.js:131:9)
    at which (/usr/local/lib/node_modules/ignite-cli/node_modules/gluegun/src/core-extensions/system-extension.js:113:22)
    at Command.module.exports [as run] (/usr/local/lib/node_modules/ignite-cli/src/commands/doctor.js:45:20)
    at process._tickCallback (internal/process/next_tick.js:68:7) code: 'ENOENT' }
^^^ -----[ DEBUG ]----- ^^^

react-native info
Environment:
  OS: macOS Sierra 10.12.6
  Node: 10.2.1
  Yarn: Not Found
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: Xcode 9.1 Build version 9B55
  Android Studio: Not Found

Packages: (wanted => installed)
  react: 16.3.1 => 16.3.1
  react-native: 0.55.1 => 0.55.1

I was able to get this working. It still does not work if I just use react-native run-ios but if I run with react-native run-ios --simulator="iPhone 6s" or specifying another iPhone type it works.

I did that, but still, nothing opens.

Are you on a Mac? I found also that after I run the command in terminal, If it doesn’t open it was just that the simulator didn’t open automatically, so I had to manually launch the simulator

@pdad04 can you please let me know how to manually launch simulator

@pdad04 can you please let me know how to manually launch simulator

@lalithnarayan on Mac if you open spotlight search (command-Space Bar) and type 'simulator' then enter, it should open. That is what I had to do initially when my sim was not launching on its own.

@pdad04  thank you

I opened the project in XCODE and it worked.

@EriksonMurrugarra Er Me too. I run by terminal, It didn't open in simulator but it worked when i build by xcode. Could you help me?

After you run it from Xcode try running it from the terminal again. Usually the terminal command starts working for me again.

Having the same issue in xcode 10

Having the same issue in xcode 10

me too. try this maybe, it worked for me before but now the problem appear again
Xode -> file -> project setting
for « pre user build system » choose « legacy »

As @gdowens  mentioned, I followed those steps and it worked for me
rm -rf ios/build then running react-native run-ios --simulator

I just ran through the steps outlined above and, other than running into this issue, it worked fine.

I opened the project in XCODE and it worked.

Can you please elaborate the steps.

I've tried

setting all workspace/ project build and pre-build systems to "legacy"
deleting the build folder
running the run-ios with different specified devices

But every time my simulator opens, the app opens to the loading page, then crashes. It never gets pass the loading page.
But if I build the project from XCode everything works fine.
Any advice?

@michlee1337  Related to #1401, maybe? Try the latest Ignite CLI and Ignite Bowser, it might help.

I was able to resolve it by building it from Xcode itself.
Once build is succeeded, you may need to run (if you get an error)
"sudo launchctl limit maxproc [limit for one user] [total limit]"
Inside Simulator Help, Apple's example values are 2000 for one user and 2500 total.

Just going to put this here, because it comes up in search results and I've been trying to figure this out for several hours: If you are using react-native-splash-screen, make sure you do SplashScreen.hide() 🤦♂

I've tried

setting all workspace/ project build and pre-build systems to "legacy"
deleting the build folder
running the run-ios with different specified devices

But every time my simulator opens, the app opens to the loading page, then crashes. It never gets pass the loading page.
But if I build the project from XCode everything works fine.
Any advice?

Did you figure out? I am having the same issue.
it works with Xcode, but not in terminal (react-native run-ios)

@stelselim Hi did you get your problem fixed? Running into the same issue

same issue

same issue

Just quit searching, i jumped into Flutter. Its much more stable and hasslefree. I would recommend

@stelselim react native is more flexible to design app

This issue seems to be more of a catch-all for many different types of issues. I'm going to lock it for now. If you have a particular issue and especially if you can provide a repro, feel free to file it in the appropriate place:
https://github.com/infinitered/ignite/issues for CLI issues
https://github.com/infinitered/ignite-bowser/issues for issues with Ignite Bowser boilerplate
https://github.com/infinitered/ignite-andross/issues for issues with Ignite Andross boilerplate


Lots of minor tidy-ups to hw/Makefile

This isn't a big deal per se, but I've been regenerating registers a lot recently and poring through the console output to find the stuff I cared about was getting a bit painful. I've split the changes into a series of self-contained commits: this might be a bit easier to review but, more importantly, is easier to bisect if I've messed something up.
The point of all of this is to tidy up the output. Before, make -C hw -j4 all generated 475 lines. Now it generates 80.

thanks @rswarbrick ! this generally looks good to me (definitely needed to do some makefile syntax googling).
I'm not an expert on Makefiles though, so maybe others can chime in on best practices etc.
In general everything here makes sense, and thanks for cleaning it up.


.NetCore 3.0 publish to single file fail on Cent OS-7

Issue Title
.NetCore 3.0 publish to single file fail on Cent OS - 7
Project settings
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.0</TargetFramework>
    <LangVersion>8.0</LangVersion>
    <PublishReadyToRun>true</PublishReadyToRun>
    <PublishSingleFile>true</PublishSingleFile>
    <PublishTrimmed>true</PublishTrimmed>
    <RuntimeIdentifier>linux-x64</RuntimeIdentifier>
  </PropertyGroup>
  <ItemGroup>
    <Folder Include="Properties\PublishProfiles\" />
  </ItemGroup>
</Project>

Exception

System.AggregateException: One or more errors occurred. ---> System.Exception: Publishing failed.
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Microsoft.Publish.Framework.Model.DefaultPublishSteps.<>c__DisplayClass26_0.<IsBuildCompletedSuccessfully>b__2()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Publish.Framework.Model.DefaultPublishSteps.<DefaultCorePublishStep>d__23.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Publish.Framework.ViewModel.ProfileSelectorViewModel.<RunPublishTaskAsync>d__205.MoveNext()
---> (Inner Exception #0) System.Exception: Publishing failed.<---

System.Exception: Publishing failed.

@livarcocc @nguerrera

Was this publish initiated from Visual Studio? Can you look at the output window and see what errors are there?

cc @vijayrkn

What do you get if you use dotnet publish on the command line?

Was this publish initiated from Visual Studio? Can you look at the output window and see what errors are there?

Yes, I am using VS 2019 Professional Version 16.2.1
1>------ Build started: Project: LinkCrawler.Net, Configuration: Release Any CPU ------
1>You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview
1>LinkCrawler.Net -> C:\LinkCrawler.Net\bin\Release\netcoreapp3.0\linux-x64\LinkCrawler.Net.dll
2>------ Publish started: Project: LinkCrawler.Net, Configuration: Release Any CPU ------
2>Restore completed in 41.65 ms for C:\LinkCrawler.Net\LinkCrawler.Net\LinkCrawler.Net.csproj.
2>LinkCrawler.Net -> C:\LinkCrawler.Net\LinkCrawler.Net\bin\Release\netcoreapp3.0\linux-x64\LinkCrawler.Net.dll
2>Optimizing assemblies for size, which may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
2>Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are using a supported runtime identifier, or set the PublishReadyToRun property to false.

Looks like, I have to change 'PublishReadyToRun ' to 'false' and now its working!

Heads up that VS 16.2 + 3.0 is not supported. Please use VS 16.3 Preview 2, which includes 3.0 preview 8. cc @livarcocc

@vijayrkn Is there a tracking issue for VS hiding the real errors behind that ugly System.Exception when the build step of publish fails? If not, I will file one.

Heads up that VS 16.2 + 3.0 is not supported. Please use VS 16.3 Preview 2, which includes 3.0 preview 8. cc @livarcocc

@nguerrera - Thank for the heads-up, I will update to latest,

@vijayrkn Is there a tracking issue for VS hiding the real errors behind that ugly System.Exception when the build step of publish fails? If not, I will file one.

Yes. We have a bug tracking this already.


Use mongodb functions.

There's a way to load and use the functions from mongodb?
For example, in robomongo i do it:
db.loadServerScripts();
db.users.insert({
    _id:getNextSequence("users"),
    name:"Teste",
    password:"000"
})

Thank you.

Hey,
Got the same issue, have business logic on the db (I know, it is bad);
You can solve it by using the native driver:
Like that for instance:
var nativeDB;
var MongoClient = require('mongodb').MongoClient;
MongoClient.connect("mongodb://localhost:27017/" + database, function(err, db) {
    if(!err) {
        console.log("We are connected");
        nativeDB = db;
    }
});
nativeDB.eval("jobsDayPerDay()", function (err, result) {
        res.send(result);
})

But then you do not use the lib anymore, you directly access the layer under it, it is not a good practise but it kind of work 😄

I'll close this issue as, like you said, having logic on the db is bad ;)
Having said that, you can still use monk to access the raw db:
const db = monk(...)
db.executeWhenOpened().then((rawDb) => {
    rawDb.eval("jobsDayPerDay()", function (err, result) {
      res.send(result);
    })
})

executeWhenOpened is a private API so use it at your own risk


TypeScript separator background colour unusually dark, and lacks contrast with text

Description
The background colour of the key/value separator is unusually dark in TypeScript files, and is almost the same colour as the text colour.
Steps to Reproduce

Create a file called test.js
Add the following content:

const foo = {
  bar: true
};

Rename the file to test.ts

Expected behavior:
There will be little or no change in the text/background colour contrast for the colon that separates the key (bar) from the value (true).
Actual behavior:
The background colour changes from transparent to #373b41, while the text colour changes from #0184bc to #383a42. This is a change in contrast ratio from 4:1 to 1.01:1.
Reproduces how often:
This was reproduced in 100% of my tests.
Versions
Atom    : 1.21.0
Electron: 1.6.9
Chrome  : 56.0.2924.87
Node    : 7.4.0
apm  1.18.5
npm  3.10.10
node 6.9.5 x64
python 2.7.10
git 2.4.1
Additional Information
This appears to be caused by the .syntax--meta.syntax--separator background colour, which is a fixed hex value.

Also: thank you to all the contributors, especially @simurai, for their work on this!

This has also started happening to me with a recent update

Until this is fixed, you can add this to your global stylesheet to make the background color transparent:
.syntax--ts {
	.syntax--meta {
		&.syntax--separator {
			background-color: rgba(0, 0, 0, 0);
		}
	}
}

Thanks for the report!  I can reproduce on macOS 10.12.6 with Atom 1.23.0-dev-9a953726.

/cc @simurai for when you're back :v:

Looks like that background mistakenly got added when converting from a base16 theme 3 years ago, but didn't get noticed until TypeScript started to use that .syntax--separator scope. :grimacing:
Anyways, let's 🔥  remove it. @timswalling thanks for the issue. 🙇


Max IR and depth resolution?

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D435i

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
Apple Silicon Mac

SDK Version
{ 2.x? }

Language
python

Segment
others

Issue Description
I am new to realsense. What is the maximum simultaneous depth and IR stream I can get please?
Device 1:
  Name: Intel RealSense D435I
  Serial Number:<PHONE_NUMBER>54
  Firmware Version: 5.14.0
  USB Connection Type: 3.2

I can seem to get 640x480 max for both.. How can I get better?

Hi @zumpchke  The maximum supported resolution and frames per second (FPS) speed for both depth and IR simultaneously on a USB 3 connection is 1280x720 at 30 FPS.

thank you


Not working on AMD RX 570

Hey there.
Tried to all released versions (1.01 to 1.03), but none worked. Tried using the debug mode (on version 1.02), pressing F3 button (on version 1.03) and nothing seems to trully enabling it, even if the debugger shows it's running. Even if there's some image degradation, the FPS doesn't increases at all. Actually, there is even some FPS drops.
There's a Youtube video with the same issue using a similar graphics card. You may check it here:
https://youtu.be/XYBWYi5G054
Please, let me know about anything I may do to help solving it. I became a huge fan of your work
Game version: Epic Games Store
My specs:
GPU: XFX RX 570 4GB (Stock)
CPU: Xeon x3440 2.5ghz (Stock)
Mem: 2x4GB ddr3 1333mhz
Mobo: Phitronics H55-M

Debug mode is only for printing messages to DebugView, it may decrease performance. FPS boost is achieved by switching frame scaling mode to lower than your real resolution. This mod just makes it less blurry (this is how FSR works). F3 button works only if you enable it in config file.

I Used debug mode only on 1.02 version. The current version (1.03), I didn't.
Yeah, I changed the upscaling mode. Here are the results for:
Normal:

Quality (0.667):

Performance (0.500):

All with MSAA (and FXAA) OFF .

Well, looks like your game is bottlenecked by CPU. You can delete d3d11.dll and see the same performance with different scaling modes.

Just tested it removing d3d11.dll and, well, you are right...  Will upgrade to Rysen 3500x soon.
I will contact the guy from the video I mentioned, see if he still getting the issue and wich is his CPU.
Many thanks for your support.


[FLINK-1201] Add flink-gelly to flink-addons (with commit history)

Hi everyone,
here's the new PR for the graph api.
I have addressed the comments of #326 and looking forward to additional feedback!
-V.

Thank you.
Looks good. History is preserved and you addressed my comments.
+1 for merging it.

Haven't had a closer look yet, but one thing that I noticed is the naming of the test files.
In the current codebase all tests are named XyzTest (or XyzITCase) instead of TestXyz. Not sure if its worth changing though...

No worries, I can rename the tests. It's better to be consistent :)
May I ask, what is the difference between a XyzTest and a XyzITCase test though? Thnx!

Sure, XyzTest are unit tests which are executed in Maven's test phase. These should execute rather fast. Everything that brings up a full Flink system is an integration test case (XyzITCase) and executed during mvn verify. These are used for long running tests.

Alright, thanks @fhueske! So, it seems all of our tests are integration test cases. I will update later today I hope :)

Tests renamed :)

One more thing ;-)
Did we collect ICLAs from all people contributing significant parts to Gelly?

@fhueske why is that needed? Gelly is Apache 2.0 licensed and Flink too: https://github.com/apache/flink/blob/master/LICENSE

This is not about the license of the software / code itself. The ASF homepage says

The ASF desires that all contributors of ideas, code, or documentation to the Apache projects complete, sign, and submit (via postal mail, fax or email) an Individual Contributor License Agreement (1) (CLA) [ PDF form ]. The purpose of this agreement is to clearly define the terms under which intellectual property has been contributed to the ASF and thereby allow us to defend the project should there be a legal dispute regarding the software at some future time. A signed CLA is required to be on file before an individual is given commit rights to an ASF project.

An ICLA also prevents that major parts of the code base need to be removed / rewritten, if a contributor decides to change the license in the future.

I see, did not know about this. thanks!

Right, thanks @fhueske for bringing this up!
@balidani, @andralungu, @cebe: could you please complete and sign this form (if you haven't already)? Thank you!

Good catch, Fabian. Yes, please do submit ICLA to secretary before we could
continue.
On Sunday, February 1, 2015, Vasia Kalavri<EMAIL_ADDRESS>wrote:

Right, thanks @fhueske https://github.com/fhueske for bringing this up!
@balidani https://github.com/balidani, @andralungu
https://github.com/andralungu, @cebe https://github.com/cebe: could
you please complete and sign this form
https://www.apache.org/licenses/icla.pdf (if you haven't already)?
Thank you!
—
Reply to this email directly or view it on GitHub
https://github.com/apache/flink/pull/335#issuecomment-72372857.

@cebe: could you please complete and sign this form (if you haven't already)? Thank you!

done.

Sorry, I will only be able to fill the form on Sunday, my internet
connection is horrible here. Is that ok?
Daniel
On Feb 2, 2015 3:53 PM, "Carsten Brandt"<EMAIL_ADDRESS>wrote:

@cebe https://github.com/cebe: could you please complete and sign this
form (if you haven't already)? Thank you!
done.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/flink/pull/335#issuecomment-72469660.

@balidani that's OK :)
@cebe we've got the acknowledgement for you, thanks!
@andralungu has submitted hers today.

I'm really sorry that I've messed up this pull request by renaming "flink-addons" to "flink-staging" :(
I was doing it in a rush.... Really sorry.

I got the ACK from Apache. My ICLA has been filed :)

@rmetzger does this mean I need to do the history filtering magic again and open a new pr?
@andralungu thanks a lot!
@balidani have you submitted yours?

@vasia yes, just submitted mine

Great, thanks ^^

@vasia: You don't need to open a new pull request, force pushing to the branch this PR is based on will update it.
I don't know if you need to do the history filtering magic again. Maybe a rebase is sufficient.

Simple renaming didn't seem to keep the history, so I did the filtering again :)
Didn't you have the same problem when moving flink-addons to flink-staging?
Let me know if it's fine now. Thanks!

I'm getting the following error on travis:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.12.1:check (validate) on project flink-gelly: Failed during checkstyle execution: Unable to find suppressions file at location: /tools/maven/suppressions.xml: Could not find resource '/tools/maven/suppressions.xml'. -> [Help 1]

Any idea how to solve this? Thanks!

in the pom.xml in flink-gelly; change flink-addons to flink-staging

Ha! Thanks :))
On Feb 10, 2015 1:10 PM, "zentol"<EMAIL_ADDRESS>wrote:

in the pom.xml in flink-gelly; change flink-addons to flink-staging
—
Reply to this email directly or view it on GitHub
https://github.com/apache/flink/pull/335#issuecomment-73689455.

@vasia my ICLA has been filed!

Thanks @balidani.
And travis tests now pass :tada:


Add the possibility to explicitly set the number of vaccinations

Is your feature request related to a problem? Please describe.
Most countries make available data on the number of vaccinations carried out. Currently, it's hard to calibrate Covasim using those data, because the vaccinate() intervention works based on the prob parameter.
Describe the solution you'd like
It would be very useful to add the ability to explicitly set the number of vaccinations per day, similarly to the test_num() intervention. In addition, it would be important to retain the ability to target a specific subpopulation.
Describe alternatives you've considered
Use the subtarget parameter to explicilty target people, but it's hard to make it work if dynamic rescaling is on.
Additional context
An example of vaccinations data available https://github.com/italia/covid19-opendata-vaccini.

Thanks @imcatta ! We are aware of this and it didn't quite make it into the 3.0.2 release, but we're hoping it'll make it into the 3.0.3 release :)

Any updates? :)

@imcatta Sorry, it took a while! But this was part of the Covasim 3.0.6 release last week, a new intervention called cv.vaccinate_num():
https://docs.idmod.org/projects/covasim/en/latest/whatsnew.html#version-3-0-6-2021-06-21


Bug: An empty row in the debug info table in debug sierra mode

When switching to debug sierra mode, an extra empty row appears in the debug info table

@melnikga you up for this one?

@mazurroman yes


Fix repo url in README

The repository URL seems to be leftover from an older repo.

Never mind, somehow GitHub magically makes the older URL also work. :tophat:

GitHub magically makes the older URL also work

It's still a good change. Can you re-open it? We should give the correct, current name.

Thx!


composer.json should be valid

Hello,
I know, it's a little error, but current version of composer.json is not valid, because it does not satify the JSON schema validation !
Package description is missing.
composer validate command produced such results
./composer.json is valid for simple usage with Composer but has
strict errors that make it unable to be published as a package
See https://getcomposer.org/doc/04-schema.md for details on the schema
# Publish errors
- description : The property description is required

Free ping, to let know status

Is this project still maintained ?

Yes it is. I'd like to discontinue the polyfill but this project is active in general. I've been working on a sorted set and some interface changes.

@rtheunissen is there a reason to discontinue the polyfill though? I think increase adoption it's better than a PHP extension (even if there is performance benefits to the latter)

It's a tricky problem, but I think if I could do it all over again I wouldn't include the polyfill at all. While it does improve adoption of the library, I'm not convinced that adopting something practically worse is a good thing overall. The effect is antithetical to the goal of this project. Those who want to use it should find a way to install the extension one way or another.
In other words, the existence of the polyfill discourages adoption of the extension. The problem to solve is to make adoption of the extension either easier, or default.
I think the ideal solution to the problem that the polyfill is trying to solve is to instead make the library available by default, either by merging with the language or at the distribution level as a default extension.

I'm not convinced that adopting something practically worse is a good thing overall.

This is only my opinion, but I think this polyfill is a net positive :) Indeed my primary motive to use this library is the features, not the performances.
And while performance definitely matters, if you are concerned or wish to improve them, then the extension is available. As a user it's a freebie so I'll be inclined to do it, but I'll also admit it has been helpful to be able to use it right away thanks to the polyfill way some annoying client third-party hosting provider adds the extension.
But this is purely as a user, since as a maintainer this may be very different...

Adding a description to a composer.json file is not the most hard to do, unless you've really decided to abandon this package.
In such case, please mark up using the GitHub repo feature (archive) please !
I won't ask to identify it on packagist because it will need to re-publish a new release with (https://getcomposer.org/doc/04-schema.md#abandoned).


AssertJ: issue with Assertions.assertThat().usingRecursiveComparison().isEqualTo()

Recursive comparision is getting failed after spring boot upgrade to 3.2.1 with JDK 17.
After spring boot upgrade the test cases are faling. Upgraded from spring boot 2.7.18 to 3.2.1.

assertj core version:3.24.2
java version: 17
test framework version: Junit 5
os (if relevant):  window

below are the steps to reporduce the issue

       public class ContactUpdateQueueModel
        {
               private String id;
               private String contactId;
               private String backend;
               private String contactType;
        }

        Map<String, Direction> sortMap = new HashMap<>();
        sortMap.put("contactId", Direction.ASC);
        sortMap.put("updateTimeStamp", Direction.ASC);
        RepositoryItemReader<ContactUpdateQueueModel> AMSactual= new RepositoryItemReader<>();
        AMSactual.setRepository(repository);
        AMSactual.setMethodName("findUpdate");
        AMSactual.setSort(sortMap);
        AMSactual.setSaveState(false);
        AMSactual.setPageSize(250);
        reader.setArguments(Arrays.asList("AMS", "PENDING"));

        Map<String, Direction> sortMap = new HashMap<>();
        sortMap.put("contactId", Direction.ASC);
        sortMap.put("updateTimeStamp", Direction.ASC);
        RepositoryItemReader<ContactUpdateQueueModel> AMSexpected = new RepositoryItemReader<>();
        AMSexpected.setRepository(repository);
        AMSexpected.setMethodName("findUpdate");
        AMSexpected.setSort(sortMap);
        AMSexpected.setSaveState(false);
        AMSexpected.setPageSize(250);
        AMSexpected.setArguments(Arrays.asList("AMS", "PENDING"));

        assertThat(AMSactual).usingRecursiveComparison().isEqualTo(AMSexpected);

But from version 3.24.2, we get the following instead:
java.lang.AssertionError:
Expecting actual:
  org.springframework.batch.item.data.RepositoryItemReader@632ceb35
to be equal to:
  org.springframework.batch.item.data.RepositoryItemReader@1c93f6e1
when recursively comparing field by field, but found the following difference:

field/property 'lock' differ:
- actual value  : java.util.concurrent.locks.ReentrantLock@34c01041[Unlocked]
- expected value: java.util.concurrent.locks.ReentrantLock@76f4b65[Unlocked]

The recursive comparison was performed with this configuration:
- no overridden equals methods were used in the comparison (except for java types)
- these types were compared with the following comparators:
  - java.lang.Double -> DoubleComparator[precision=1.0E-15]
  - java.lang.Float -> FloatComparator[precision=1.0E-6]
  - java.nio.file.Path -> lexicographic comparator (Path natural order)
- actual and expected objects and their fields were compared field by field recursively even if they were not of the same type, this allows for example to compare a Person to a PersonDto (call strictTypeChecking(true) to change that behavior).
- the introspection strategy used was: DefaultRecursiveComparisonIntrospectionStrategy

	at com.fis.payments.apex.batch.reader.TerminalContactAssignmentQueueReaderTest.testGetReader(TerminalContactAssignmentQueueReaderTest.java:62)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

related to https://github.com/assertj/assertj/issues/3369#issuecomment-1953615601

At the moment, the best course of action is either ignoring the fields of type ReentrantLock or registering a way to compare them:

ignoring the fields of type: ignoringFieldsOfTypes
registering a bi-predicate to compare certain fields or types

Just curious why you are comparing readers instead of the reader content only, IMO comparing locks fields don't make a lot of sense unless you are in a very specific context where you are managing locks explicitely.

Just to be extra clear, in java 17 it is illegal to use relfection on java/javax types, we have to use equals.

Just to be extra clear, in java 17 it is illegal to use relfection on java/javax types, we have to use equals.

Thank you @joel-costigliola.
But i have already used the hash code and equals method in the Model class.

Just to be extra clear, in java 17 it is illegal to use relfection on java/javax types, we have to use equals.

Correction: it's only on JRE types not javax AFAIK

I have added ignoringFieldsOfTypesMatchingRegexes(String... regexes) since there is not much we can do for types like Locks so best is to ignore them.


use TLSConfig.ServerName as the client hostname if provided

Currently quic client always parse hostname from the addr. It prevent us to specific a different hostname to the client.
This PR is to enable this by the TLSConfig.ServerName field. Thanks.
Signed-off-by: Phus Lu<EMAIL_ADDRESS>

Codecov Report

Merging #686 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
- Coverage   91.35%   91.32%   -0.03%
==========================================
  Files          81       81
  Lines        5573     5575       +2
==========================================
  Hits         5091     5091
- Misses        303      304       +1
- Partials      179      180       +1

Impacted Files
Coverage Δ

session.go
88.13% <0%> (-0.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f965942...fe34002. Read the comment docs.

Thanks for the PR! :) This is definitely something we want to support, but I think it would be better to add this code to client.go, in particular around here (and don't try to extract the hostname from the addr if it is set in the tls.Config). Would you mind moving it there?

@lucas-clemente Thanks, I done the modification. :)

Superseeded by #693.


copr: fix cluster index common handle and row value decode order

Signed-off-by: iosmanthus<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: close #8557
Problem Summary:
What is changed and how it works?
This pull request force the table scan executor to extract the column from the value first and then extract other columns from key and ignore those columns that are already filled.
What's Changed:
Related changes

Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note

fix cluster index common handle and row value decode order

LGTM

/merge

/run-test

/rebuild

/merge


DFP native ads doesn't trigger callback

I'm using Google.MobileAds nuget package 7.16.0, but i have some issue to use NativeContentAd and
NativeAppInstallAd. Sometimes when i make a request of native ads no methods are triggered of those:

DidFailToReceiveAd
DidReceiveNativeContentAd
DidReceiveNativeAppInstallAd

This is my example code (inside ViewDidLoad):
...
LoadNativeAd("/23154429/AdxNative/app_native_1_serp", this));
...

public void LoadNativeAd(string adUnit, AdvertListView rootViewController)
        {

                List<AdLoaderOptions> adLoaderOptions = new List<AdLoaderOptions>();
                adLoaderOptions.Add(new NativeAdViewAdOptions() { PreferredAdChoicesPosition = AdChoicesPosition.TopRightCorner });

                var adsLoader = new AdLoader(adUnit, rootViewController, new NSObject[] { AdLoaderType.NativeContent, AdLoaderType.NativeAppInstall }, adLoaderOptions.ToArray());
                adsLoader.Delegate = rootViewController;
                var requestSim = Google.MobileAds.DoubleClick.Request.GetDefaultRequest();
                requestSim.CustomTargeting = NSDictionary.FromObjectAndKey(
                    (NSString)JR.BL.Core.Settings.CurrentCountry, (NSString)"country");
                var simul = new System.Collections.Generic.List<string>();
                simul.Add("622801a654b4700c0f23d16a55862ab0");
                simul.Add("kGADSimulatorID");
                requestSim.TestDevices = simul.ToArray();
                adsLoader.LoadRequest(requestSim);

        }

public void DidReceiveNativeContentAd(AdLoader adLoader, NativeContentAd nativeContentAd)
        {

               Utils.NativeAds.Add(adLoader.AdUnitID, nativeContentAd);
               TableView.ReloadData();

        }

        public void DidFailToReceiveAd(AdLoader adLoader, RequestError error)
        {

               Console.WriteLine("AdLoader: " + adLoader.AdUnitID + " | error:" + error.UserInfo.ToString());

        }

        public void DidReceiveNativeAppInstallAd(AdLoader adLoader, NativeAppInstallAd nativeAppInstallAd)
        {

                Utils.NativeAds.Add(adLoader.AdUnitID, nativeAppInstallAd);
                TableView.ReloadData();
        }

We are in touch with google support and this is their answer:

For iOS specifically, an issue was observed with the callback events not being triggered when an ad is returned, so it's very likely that is causing the relatively lower render rate. I've suggested to Luigi on your team that this issue be reported to the Xamarin team, which provides the SDK wrapper being used by your apps, as we weren't able to replicate the issue with the Google SDK and don't directly control or support the Xamarin product.

Any news?

bump
Any updates on this? We've multiple customers affected by this issue.

Is this still an issue? If yes, can you provide a test case? That will make things faster.


feat(markdownit): add types of $md

Improve the development experience by adding TypeScript types.

this would be useful to me, thanks !

Thanks for PR <3 I will merge it little bit later. Probably creating dedicated repo for markdown-it module.


Can I use this project to make an app that supports Gitlab?

I really like how this app works but at work we use self hosted gitlab is it possible that I use this project as a starting point for a new app that supports gitlab? Thanks in advance.

There's an open discussion for this here: #408 - Currently the scope of the project is limited to GitHub (maybe looking into Enterprise) but there's definitely nothing stopping you from forking off and making changes to support other hosts!

Thanks @Sherlouk I'll take a look on the other issue.


fix simulator compilation

It feels like we should add compiling this to CI

bors r+
We had a single run in CI: https://github.com/tigerbeetledb/tigerbeetle/blob/af1bee199f1ea9a722ff196c1adb682e86ef9c54/.github/workflows/test_and_build.yml#L154-L164 but I assume it was disabled b/c there are currently some "false" failures in the simulator that we are stuck with until state transfer is implemented. Compilation would work in the mean time though.

https://github.com/tigerbeetledb/tigerbeetle/pull/416


Update jupyterhub repo to have simple and advanced images.

Outcome:

One minimal image that all the notebooks can run on
One development image with DEA-Proto, fc, wofs etc

This is done now, depending on the permissions of the user they are given access to a list of different environments on startup.


Cannot send attachment using Resend

Package version
6.12.1
Describe the bug
When sending an email using a class email, everything works until trying to follow the attaching files process. All I get is failures, and upon looking at the error I get "Unable to send email using the resend transport: Response code 422 (Unprocessable Entity)".
export default class ChangelogNotification extends BaseMail {
  subject = 'Tailwind test'

  /**
   * The "prepare" method is called automatically when
   * the email is sent or queued.
   */
  prepare() {
<EMAIL_ADDRESS>    this.message.html(ChangelogEmail({ text: 'Trust reputation' }))
    this.message.attach(app.makePath('public/deepslate.png'), {})
  }
}

Reproduction repo
No response

I will attach a reproducible repo tomorrow

@CodingDive Thanks for narrowing down the issue. So we just have to wait for Resend to allow this?


Generate app button disabled in a particular workflow in app generator

Actual Behaviour
Unable to generate app through generator when following a workflow.
Expected Behaviour
The generate android app button should not be disabled.
Steps to reproduce it

Select a zip file to upload.
Select the API endpoint radio button.
Select the upload zip file radio button.

Screenshots of the issue

Would you like to work on the issue?
Yes, would like to work on this issue.

This is because this is not deployed. You need to deploy it to a server.


Apple Depricated API Issue

I recieved the following notice from Apple after adding thsi plugin.
ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of new apps that use UIWebView APIs starting from April 2020. See https://developer.apple.com/documentation/uikit/uiwebview for more information.
What is the solution for accessing Photo's and Media after next month?

Isn't this library, see: https://devblogs.microsoft.com/xamarin/uiwebview-deprecation-xamarin-forms/


Forwarded ports on Remote SSH host are not working

Type: Bug
{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "msedge",
            "request": "launch",
            "name": "Launch Edge against localhost",
            "url": "http://localhost:3000",
            "webRoot": "${workspaceFolder}"
        }
    ]
}

[Window Title]
Visual Studio Code - Insiders
[Content]
Unable to launch browser: "Timed out waiting for browser connection"
The above worked fine till last update and it works fine in current stable release.
A browser window opens but then i get the above timeout message.
Output of Shared console output:
2023-05-17 17:36:05.169 [error] [uncaught exception in sharedProcess]: Cannot read properties of undefined (reading 'then'): TypeError: Cannot read properties of undefined (reading 'then')
    at b.s (c:\Users\Ashesh\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:23:4987)
    at b.q (c:\Users\Ashesh\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:23:4387)
    at c:\Users\Ashesh\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:23:3776
    at E.invoke (c:\Users\Ashesh\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:19:145)
    at u.deliver (c:\Users\Ashesh\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:19:2121)
    at a.fire (c:\Users\Ashesh\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:19:1729)
    at MessagePortMain.X (c:\Users\Ashesh\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\code\node\sharedProcess\sharedProcessMain.js:17:23920)
    at MessagePortMain.emit (node:events:513:28)
    at MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:2:367)
2023-05-17 17:36:05.267 [info] [SharedProcessTunnelService] Created tunnel 9: localhost:53846 (local) to localhost:53846 (remote).
2023-05-17 17:36:05.366 [info] Creating a socket (renderer-Tunnel-b0b59687-fa67-4920-ac08-10e91060276d)...
2023-05-17 17:36:05.366 [error] [remote-connection][Tunnel       ][b0b59…][initial][[object Object]] socketFactory.connect() failed or timed out.  None of my manually forwarded ports work.

Facing the same issue on my VSCode Insiders as well. Was working fine on 16th May 2023, and the problem started yesterday (17th May 2023).
For me, this occurs when I am trying to port-forward a webpage loaded on my virtual machine to my local machine.
Below is a sample of the logs from the "Shared" Output tab. The same error related to the socketFactor.connect() is faced.
2023-05-18 08:55:49.743 [error] [remote-connection][Tunnel       ][f94ed…][initial][[object Object]] socketFactory.connect() failed or timed out. Error:
2023-05-18 08:55:49.743 [error] TypeError: Cannot read properties of undefined (reading 'connect')
    at D (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:37:15984)
    at r (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:37:16746)
    at o (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:37:19510)
    at C (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:37:20917)
    at async a.l (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:74:12326)
2023-05-18 08:55:49.743 [error] [uncaught exception in sharedProcess]: Cannot read properties of undefined (reading 'connect'): TypeError: Cannot read properties of undefined (reading 'connect')
    at D (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:37:15984)
    at r (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:37:16746)
    at o (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:37:19510)
    at C (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:37:20917)
    at async a.l (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:74:12326)

@alexr00 @chrmarti I believe this is the issue I am encountering.

The latest work version: <IP_ADDRESS>30515
SystemSetup: https://az764295.vo.msecnd.net/insider/9084e081d4e89ed8ab67fce340d573c4e1378939/VSCodeSetup-x64-1.79.0-insider.exe
UserSetup: https://az764295.vo.msecnd.net/insider/9084e081d4e89ed8ab67fce340d573c4e1378939/VSCodeUserSetup-x64-1.79.0-insider.exe

Range of commits where this occurred:
https://github.com/microsoft/vscode/compare/9084e081...9233de80

@connor4312 or @alexdima I think this is related to https://github.com/microsoft/vscode/pull/180263, though I'm not sure how yet.

Thanks for the detailed issue!


⚠ Bofrost.fr has degraded performance

In 23eb838, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1213 ms

Resolved: Bofrost.fr performance has improved in c633931 after 6 minutes.


Fix some address crawler timing issues

Motivation
Zebra's address crawler is fragile - small changes can cause significant regressions.
This PR deals with a few different sources of that instability.
Solution

Fix a race between the first heartbeat and getaddr requests
Temporarily reduce the getaddr fanout to 1, until we implement #2214
Make sure finished requests are always sent as soon as they are ready
Simplify the Connection awaiting request state machine
Improve connection metrics and logging

Review
This PR is ready for review.
Let's assign a reviewer when people are back from leave.
Reviewer Checklist

[ ] Code implements Specs and Designs

I've tested this PR locally, and the crawler and address book metrics look a lot better.
It's hard to test this PR, because the timing issues are subtle, and don't show up in some network environments. We should have better tests after we implement #1592.

Bumping this up to high priority, because this fix causes CI failures, and it might conflict with other PRs.

I've tested this PR locally, and the crawler and address book metrics look a lot better. The number of peer addresses rises rapidly, and gets full after a few hours. And Zebra doesn't hang any more, even after a few days.


#209: Grammar fixes

Fixes #209
Updated context sensitive keywords list

Note: The grammar for macros isn't well documented and it appears you can use more than just build configurations as macro conditionals. I'm assuming that any conditional clause can be put in there for the time being, until I find something more specific.

Current coverage is 87.24%

Merging #210 into master will not affect coverage as of 3659f8a

@@            master    #210   diff @@
======================================
  Files           34      34
  Stmts         1466    1466
  Branches       250     250
  Methods          0       0
======================================
  Hit           1279    1279
  Partial         60      60
  Missed         127     127

Review entire Coverage Diff as of 3659f8a

Powered by Codecov. Updated on successful CI builds.

:+1: Great work!


ng generate not working

I'm trying to run angular cli commands like ng generate component hello and it changes nothing.

Hi @gauravmakkar !
Could you please provide some error console output or anything else? I just tried it locally and everything worked as expected.
Cheers!

My bad. I guess the issue was this angular-cli installation. Re-installed it and working fine now.

Happy to hear that you resloved your problem!


[error] The edge module has not been pre-compiled for node.js version v6.9.1

The edge module has not been pre-compiled for node.js version v6.9.1. You must build a custom version of edge.node. Please refer to https://github.com/tjanczuk/edge for
building instructions.

How i can fix it?

you will need to build per the instructions on that link or use an older version of nodejs

I've got the same issue, while i using edge-oledb on Electron:
if your project is on Electron, you can solve it this way:
-1- get the latest Electron (fine on v1.4.7.)
-2- instead using npm edge (edge-oledb need it) you install https://www.npmjs.com/package/electron-edge
-3- to force edge-oledb to use electron-oledb, find the edge-oledb index.js file:
\resources\app\node_modules\edge-oledb\index.js
and replace:
-var edge = require('edge');
+var edge = require('electron-edge');

thank you for the additional info, hope it helps (now I need to try Electron when I got a chance)


Make it easier to load resources in production

In the current state of the project, when you build the application (mincss+uglify), the minified results are placed in the public/dist folder.
If you were using relative paths for images, fonts and such in css files, (which in my opinion is a logical solution, instead of writing /modules/something in front of every resource needed), your app won't load resources due to different paths of minified css and the actual path of resources.
For this type of thing to work, it is much needed for the build script to also copy all other resource files to the dist folder with their original file structure, and also putting the minified css to public/dist/css folder.
This should work out of the box, instead of having to manually change paths in all css files or moving files around manually.

The easier solution would be to create a dist folder in each module and place CSS/JS there, but that is something that can be changed by the user. I don't see an issue with us changing it as long as most people are in favor of the change.

in my config i added a base path that should point to the base url of the CDN, and i added a base tag in the main layout file.
Now, because the minified css is inside the dist folder, i changed it's build destination to dist/css, added a grunt task to copy everything from modules/*/img/ into dist/img so the relative paths in the css files can work (../img/pic.png). I made a copy task that copies everything from public/lib/ to dist/lib/, and another one that copies all angular html templates with the original folder structure into dist/.
By doing things this way i'm sure that the dist folder contains everything that should be put on CDN and everything should load correctly, although the solution is not perfect.

@codydaig @mleanos any thoughts on this? Not much in our implementation has changed, but loading resources is always something we should try to improve imo. I also want to see if you guys have any thoughts on whether this is really holding anything back or we should just close and come back to it when we do a much larger refactor.

@ilanbiala I honestly hadn't though much about this because I don't actually MEAN in production. However, I do think this may be a little bigger of a priority if it causes issues in the production environment. @mleanos thoughts? You've had experience in production.

This topic is definitely an important issue to handle.
Would anyone like to review how we can approach a similar production build (dist directory) for this?
cc @codydaig @mleanos @ilanbiala @FREEZX

On the project i had worked on, what i said i did in my last comment is still in place and works well enough.

@FREEZX is it open source? can you show us an example of such implementation?
are you able to offer a PR?

@FREEZX also see my suggestion for the dist/ directory here: https://github.com/meanjs/mean/issues/1087#issuecomment-243136976

@lirantal No, it's not open source unfortunately.
I also have this on my own framework which might prove useful:
https://github.com/FREEZX/nuke.js/blob/master/build.js
What it does is it goes through all the CSS files, finds all resources they use and copies them together with the minified css files.

Ok, saw it.
I think there's probably a better and more intuitive way of doing it with existing tools in gulp so if we don't have a PR for this I'll close it.


fix(registry): correct repository name in the signature info

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area registry

What this PR does / why we need it:
You can probably feel me facepalming very hard from this.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 728040eeb2c1b136ab1a783de8d828c1a3f8fa42

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Pint pulsar update

@Hazboun6 maybe you can have a look at this and merge it soon, too.  The PintPulsar class did not have dm, dmx, or stoas attributes, which were necessary for WidebandTimingModel.  Nihan was responsible for most of this dev.

@pennucci This looks good. Once the tests pass I'll merge.

@pennucci This looks good. Once the tests pass I'll merge.

@Hazboun6 One line of changing single to double quotes occurred in the linting...!  It should pass now?

@Hazboun6 One line of changing single to double quotes occurred in the linting...!  It should pass now?


BeanShell's automatic casts are more restrictive than Java

The following code:
> cat t8.java
public class t8 {
public static void main(java.lang.String[] $0s)
{
byte b1;
b1 = 127;
return;
}
}
Process cat exited with code 0
Compiles in Java:
> javac t8.java
Process javac exited with code 0
But throws an exception in Beanshell:
> java -classpath ../bsh-2.0b5.jar bsh.Interpreter t8.java
Class: class t8 main method threw exception:Variable
assignment: b1: Can't assign int to byte : at Line: 4 : in
file: t8.java : b1 = 127
Called from method: main : at Line: -1 : in file: <Called
from Java Code> : <Compiled Java Code>
Process java exited with code 0
Reported by: nigel_galloway
Original Ticket: "beanshell/bugs/225":https://sourceforge.net/p/beanshell/bugs/225

No exception on BeanShell 3.0.0-SNAPSHOT.841 works like java
t8.java.txt
bsh % source("t8.java");
--> $0 = class t8 :Class
bsh % t8.main(new String[0]);
--> void

Closed works as expected


Modal component sets the StatusBar to White

Is this a bug report?
Yes
Have you read the Contributing Guidelines?
yes
Environment
Environment:
OS:  macOS Sierra 10.12.6
Node:  6.11.3
npm:  3.10.10
Watchman:  4.7.0
Using expo
Packages: (wanted => installed)
react-native: 0.48.1 => 0.48.1
react: 16.0.0-alpha.12 => 16.0.0-alpha.12
Target Platform: iOS (10.3)
Steps to Reproduce
Open a modal in Android.
Expected Behavior
Should just activate a modal an present the view.
Actual Behavior
Statusbar turned white.

This happens in the following phones:

Samsung Galaxy A5 2017 - 6.0.1
Huawey Ascent P8 - Android 6.0
Sony Xperia Z1 - Android 5.1.1

But when trying on:

BQ Aquaris 5H - Android 4.4.2
Google Nexus 5X- Android 7.1.2

it works properly.
Seems like is SO version related.
Reproducible Demo
https://snack.expo.io/HkIaCRviZ

this bug had be fixed??? @EnriqueDev
have the same issue here


Fix code scanning alert - Denial of Service in Connect2id Nimbus JOSE+JWT

Tracking issue for:

[ ] https://github.com/bcgov/nr-forest-client/security/code-scanning/156

So far, a fix for this issue is not available. the dependency library used (Nimbus JOSE+JWT)[https://mvnrepository.com/artifact/com.nimbusds/nimbus-jose-jwt] is still reporting not only this but another CVE associated to some of it's dependencies yet. We will keep monitoring it for any possible mitigation scenario available.


Compile for Qt for Android

Hi
Is possible to compile the library for Qt but working on Android platform? Basically it mean to compile library for Qt but using the Android NDK arm7a and armv8 compilers...
Thank you

Probably, but you have to modify a resvg-qt build script first. And probably harfbuzz build script  too. Other than that there should be no platform specific problems.
But again, I never tried to do this and I have no plans to support android/ios.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_0cwelyqp0b/clone/recipe/meta.yaml:21: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_0cwelyqp0b/clone/recipe/meta.yaml:23: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_0cwelyqp0b/clone/recipe/meta.yaml:26: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_0cwelyqp0b/clone/recipe/meta.yaml:28: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_0cwelyqp0b/clone/recipe/meta.yaml:28: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_0cwelyqp0b/clone/recipe/meta.yaml:43: missing_pip_check: For pypi packages, pip check should be present in the test commands
WARNING: /tmp/abs_0cwelyqp0b/clone/recipe/meta.yaml:50: missing_description: The recipe is missing a description
ERROR: /tmp/abs_0cwelyqp0b/clone/recipe/meta.yaml:50: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_0cwelyqp0b/clone/recipe/meta.yaml:50: missing_dev_url: The recipe is missing a dev_url
Errors were found


Extract replicaset member creation logic

This is related to #165, it's a simple refactor to ease understanding of the code to be changed in the other issue.
My argument is that the replicaset member configuration should be constant for every run, with the same set of attributes.
This will make it easier to make sense of the replicaset code

@josephholsten Could you take a look on this?

Sorry! Forgot to push some modifications.

Done!

For what I'm investigating this errors and incompatibility issues caused by the latest chefdk version release.
In my setup both of this commands worked without any issues.
$ chef exec rake
$ kitchen test all
The issue, and that's can either be faced as a CI issue as an environment one, is that the version that brew provides is fixed on the latest stable of chefdk 1.5.x and the CI uses the latest development version of it 2.0.x.
I don't know if I should update, since this is probably the most used version in the wild, or the CI should test for this release as well.

@shortdudey123 I think this one is ready to merge now.
Figured I'd ping you considering you've done a lot of work on this recently 👍

@shortdudey123 should we merge this, after the aprovais?

One other suggestion, since I don't have the habili

Sorry, didn't meant to close the PR


Background transparency

Hello,
I'm working on a pywal based theme, which ingesting the pywal colors from ~/.cache/was/colors and thanks working great. However, I'm unable to get the background to be transparent. Also is there any facility to reapply lush based on an event? Currently I have to rerun Lushify when I change a background.

I'm working on a pywal based theme, which ingesting the pywal colors from ~/.cache/was/colors and thanks working great. However, I'm unable to get the background to be transparent.

Generally that's dependent on the terminal and set separately I think?

Also is there any facility to reapply lush based on an event? Currently I have to rerun Lushify when I change a background.

You mean from an external-to-vim event? I think you can hook into nvim via it's RPC system and basically use that to tell lush to re-run (or rather, just tell vim to reload it's colorscheme). I'm not sure how complicated that would be though, depends on what's changing your wallpaper and your language/msgpack library.
Another option would be making a small plugin that watches a file for changes and executes a command when they change. I might look at making that actually.

Here is a very basic watcher plugin:
https://github.com/rktjmp/fwatch.nvim
The API for that plugin might change as I think about it more and it probably has a bug or two, but it should let you at least try the idea.
You need to make your background change effect a file somehow.

In your case you're probably doing something like:
lua << EOF
local fwatch = require('fwatch')

fwatch.watch("/home/deepsix/.config/x_bg_file_or_something", "colorscheme my_scheme")

?

@rktjmp  I've published my really rough (but working) pywal based theme, I am definitely open to suggestions, this is my first Lua program, and I really don't consider myself a developer per se. I'm sure you can improve upon it, more importantly I think long term basing it on pywal might not be the greatest idea because it often times doesn't extract more than 8 colours for a pallete.
I am still unable to get lightline or transparency to work..
Code is here:
https://github.com/Deep-Six/pywal-lush

That's actually pretty neat if not somewhat unpredictable.
I managed to get the auto application working with fwatch, but you have to put a small timer to avoid trying to generate the scheme from a half updated file.
I just put this after where I set my colorscheme
lua << EOF
fwatch = require('fwatch')
fwatch.watch("/home/soup/.cache/wal/colors", {
  -- when file changes
  on_event = function()
    -- wait 200ms then
    vim.defer_fn(function()
      -- reapply the colorscheme
      vim.cmd("colorscheme pywal")
    end, 200)
  end
})
EOF

Lightline is pretty awkward. You can see in the examples a bit on how to get it to work, it involves basically building a separate dictionary for lightline and then turning it off and on again.
Not sure if all status lines are like that or not,  I think lualine just uses regular highlight groups so lush should just be able to set them no problem.
The transparency (as in, see wallpaper through vim) stuff will be per-terminal and not controlled by lush or vim.

I managed to get lightline working, it was a matter of finding the right
theme name to not deviate from your original methodology. I'm getting to
rework it when I have time.
I might take a look at lualine for ease of use.
It is unpredictable but it actually by and large works pretty well. The
real problem only happens when you have an image that doesn't have the
colour diversity needed.
Thanks for lush it was super cool to play with!
On Mon., May 3, 2021, 08:37 Oliver Marriott, @.***>
wrote:

That's actually pretty neat if not somewhat unpredictable.
I managed to get the auto application working with fwatch, but you have
to put a small timer to avoid trying to generate the scheme from a half
updated file.
I just put this after where I set my colorscheme
lua << EOF
fwatch = require('fwatch')
fwatch.watch("/home/soup/.cache/wal/colors", {
-- when file changes
on_event = function()
-- wait 200ms then
vim.defer_fn(function()
-- reapply the colorscheme
vim.cmd("colorscheme pywal")
end, 200)
end
})
EOF
Lightline is pretty awkward. You can see in the examples a bit on how to
get it to work, it involves basically building a separate dictionary for
lightline and then turning it off and on again.
Not sure if all status lines are like that or not, I think lualine just
uses regular highlight groups so lush should just be able to set them no
problem.
The transparency (as in, see wallpaper through vim) stuff will be
per-terminal and not controlled by lush or vim.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rktjmp/lush.nvim/issues/38#issuecomment-831264402,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFR63V6J55GQQUNTXBHOWZDTL2RJJANCNFSM43QPZ5NQ
.

@rktjmp  the watch works perfect making this totally dynamic! Thanks!

Stumbled upon this thread after I found your pywal lush theme and modified to work with wpgtk, and was looking for dynamic reloading. Thanks a lot to both of you for your work

Since the issue title is still background transparency, I am experiencing the following; with some wallpapers (and associated color scheme) my vim background is non-existent (as desired), but with some, there is a background. I'm not sure what's causing this, do you have any idea how I can make them all transparent?

Possibly pywal/wpgtk sets something funny depending on what the background is? Sounds weird though.
Does it persist if you re-open the terminal? It may be something like compiz/picom/whatever acting up.
That sporadic strip down the right is from the ColorColumn group, see :h colorcolumn for info on disabling it.
Actually, the ColorColumn seems like it's never being blended, maybe because it's so dark. I wonder if the term/compositor has trouble mixing dark colours and some wallpapers just have darker backgrounds?

The background colors do change per wallpaper, but are all a slightly different shade of black/gray. Re-opening the terminal doesn't change anything. What's funny is that only with 3 specific wallpapers I always have a transparent background, with the rest I don't.
Before migrating over to lua, I used the native .vim theme for pywal/wpgtk, and there I had no problems. However then I was also in 8 bit color mode, this is 24 bit color mode.
The color column is intentional yeah

Okay so its probaby because a background is explicitly set on all highlight groups. If I remove the bg= call from a specific highlight group, that group gets transparent.

Hey everyone,
Credit really goes to Oliver, he did the hard work. This was my first (and
so far only) foray into Lua, so by all means if you have improvements
please let me know!
Let me know if you got background transparency working, this was something
I didn't fuss with too much about.
Thanks,
Jayson
On Sun, 20 Jun 2021 at 15:20, David Brouwer @.***>
wrote:

Okay so its probaby because a background is explicitly set on all
highlight groups. If I remove the bg= call from a specific highlight
group, that group gets transparent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rktjmp/lush.nvim/issues/38#issuecomment-864619130,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFR63V6XUO6JEGAIFZ6MDO3TTZSSPANCNFSM43QPZ5NQ
.

Background works perfectly now, after deleting all explicit bg = color definitions for right highlight groups

Can you submit a PR?
Thanks,
Jayson
On Mon, 21 Jun 2021 at 03:08, David Brouwer @.***>
wrote:

Background works perfectly now, after deleting all explicit bg = color
definitions for right highlight groups
[image: image]
https://user-images.githubusercontent.com/25869544/122745346-3109a400-d289-11eb-927c-e30e77c1e5f4.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rktjmp/lush.nvim/issues/38#issuecomment-864909350,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFR63V6TNMCU2EMDGYL5RKLTT4FSHANCNFSM43QPZ5NQ
.

Just run :%s/ bg = color1,//g << that's all I've done to solve the the background issue

Closing this as it seems to be sorted out.