Fix dropdown option validation to allow null or empty string as value

Description
Fix dropdown option validation to allow null or empty string as value
Fixes #3330
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test A
Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Thanks for fixing this: now the widget value can be set to null programmatically, but the same cannot be done from UI. There should be a "clear" function like there is in the datepicker widget.


Add reviewers section to OWNERS file.

Changes
Add @lcarva, @chuangw6 to reviewers so they actually can get assigned reviews.
See https://www.kubernetes.dev/docs/guide/owners/ for documentation.

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/lgtm


Shader language GLES2 type issue with mod

Godot version:
Godot_v3.2-beta6_x11.64
OS/device including version:
Kubuntu 19.10
Issue description:
Running the code below (the second line) with GLES2 gives the following error in the output tab, the shader editor is unaware, and there some glitch drawing. Wrapping the expression in an int() works around it. It works in GLES3.
 drivers/gles2/shader_gles2.cpp:129 - SceneShaderGLES2: Fragment shader compilation failed:
0:1274(2): error: initializer of type float cannot be assigned to variable of type int

 drivers/gles2/shader_gles2.cpp:360 - Method/Function Failed, returning: __null
 drivers/gles2/shader_gles2.cpp:88 - Condition ' !version ' is true. returned: false
 drivers/gles2/shader_gles2.h:257 - Condition ' !version ' is true. returned: -1
 drivers/gles2/shader_gles2.h:257 - Condition ' !version ' is true. returned: -1

Steps to reproduce:
vec2 fragcord = UV * 10.0;
int val = int(fragcord.x) % 4;

Fixed by #35202.


Fix build error in RNCCameraRollManager.m

Summary
After upgrading to 1.3.0 that includes #87, my builds started to fail on the step to link react-native-cameraroll with the following message:
Undefined symbol: _OBJC_Class_$_RCTImageLoader.

I'm not sure what @tomtargosz's environment is like that allowed this to work, but it does not seem to work in 0.61.x with autolinked (cocoapods) dependencies. It looks like the recommendation made in that file by the react-native team is incorrect. I'm also not 100% confident this will work with RN < 0.60. I suspect the way react-native-svg fixed this may be backwards compatible - see this commit and this one that specifically notes backwards-compatibility
The correct way to fix this, which I see in react-native-image-crop-picker and in several internal react files, is to use [self.bridge moduleForName:@"ImageLoader" lazilyLoadIfNecessary:YES].

Test Plan

I made these changes in my local copy of the cocoapods and was able to compile.
What's required for testing (prerequisites)?
A react-native app on RN 0.61.x that includes this package as an autolinked dependency via cocoapods.
What are the steps to reproduce (after prerequisites)?
Try to build. It fails (for me - I haven't tried to repro with a fresh create-react-native-app but I don't see why it would work with a fresh app).
Compatibility

OS
Implemented

iOS
✅

Checklist

[x] I have tested this on a device and a simulator
[x] ~I added the documentation in README.md~
[x] ~I mentioned this change in CHANGELOG.md~
[x] ~I updated the typed files (TS and Flow)~
[x] ~I added a sample use of the API in the example project (example/App.js)~

Thanks for this! Could you help me out and run a fresh react-native init on <0.60 app to see the effect of this change on older RN versions? Getting a confirmation, even if it's a failure, will make me more confident to merge this. Also we can make a note in the release notes and the readme about the loss of backwards compatibility.

So I've asked @RSNara about the backwards compatibility and I'm going to see what he says first. I'm considering reverting https://github.com/react-native-community/react-native-cameraroll/pull/87 for the time being, which leaves a warning but at least doesn't cause any compile errors and is fully backwards compatible until a solution that would work in older versions of React Native can be found.

So as far as I can tell, if we merge this in the compatibility will be:
<EMAIL_ADDRESS>|<EMAIL_ADDRESS><EMAIL_ADDRESS>|<EMAIL_ADDRESS>(after merging the last PR<EMAIL_ADDRESS>|<EMAIL_ADDRESS>I'll update the readme after releasing the fix. Thanks.


Allow more than one EditorPlugin per addon, support GDExtension classes

Implements https://github.com/godotengine/godot-proposals/issues/3782
I initially wanted to work on allowing GDExtension to register EditorPlugins (without the need for a proxy script), but because I also need more than one, I figured the proposal above could be done at the same time. So it could also solve https://github.com/godotengine/godot-cpp/issues/640
This adds support for a new editor_plugins key in plugin.cfg, which contains an array of strings. Each string can either be a path to a script (if it contains a .), or a class name present in ClassDB. The latter allows extensions to register EditorPlugins.
I left the old script key for backward compatibility, but could be removed eventually, or kept for convenience.
The way this work also means addons implemented using GDExtension can be turned on and off the like script-based ones.
There are a few issues:

GDExtension classes inheriting EditorPlugin have to be registered in ClassDB for this to work. But it seems it would expose them to the Add Node dialog for example, which is not desired. Maybe it needs a new argument to register_class in the GDExtension API, unless that already exists?
How do extension class instances cope with a library getting unloaded? (for example, when Godot looses focus, if the library is configured that way). The question is already valid for classes in the edited scene tree, not just plugins.
How can we limit class names to extensions? Currently you can specify a class name that happens to be a core class, but it isn't intentional. Maybe need to add ClassDB::is_extension_class?

Splitting this would be weird, because GDExtension support is done through the feature itself, as a result of handling class names and not just scripts. If I were to split, I'd have no way to make another PR without pretty much rewriting this one. Also, most of GDExtension concerns aren't directly about the PR itself, but about in-editor GDExtension classes in general. I mentionned them here for awareness.

We approved the feature in the GDExtension PR review meeting. The comment by @KoBeWi should be addressed though, as compatibility features should always be surrounded by #ifndef DISABLE_DEPRECATED.
Another feedback is that the logic for selecting either script or editor_plugins should likely be reversed, so that editor_plugins takes precedence over script when both are defined. Also, if both are defined, Godot should give you a warning.
Regarding the support of class names in the list, we are not really convinced this is the best way to implement it. Modules usually register themselves as plugins by calling EditorPlugins::add_by_type. We are thinking a better to solve this situation would be to expose this function (or some EditorPlugins::register_extension_class()) to extension themselves so that we can register a class that way. If this function was exposed, it make support for class names in the editor_plugins list unnecessary, simplifying things a bit. Also, we could maybe rename it to editor_plugins_scripts to make it clear it does not support class names ? WDYT ?

The difference with modules is that modules registering plugins with add_by_type cannot be turned on and off (which makes sense since they cannot be removed from the engine as well without recompiling it). While if they are part of this config registration, they can be turned off.
If we go for exposing EditorPlugins::add_by_type, first of all, it cannot be that exact function since it is template. When I look at how it is defined, I'm quite confused because it does not add anything right away, instead it registers inside a list (limited to 128 elements with a never-decreasing count), and that logic would have to change because it looks like it was written only for core and modules plugins that can never be removed until the editor closes. Extensions can be added anytime and removed anytime (well, currently not, but we should try not to assume that since other devs are figuring out how to do it).

For the GDExtension part of this, I see at least three possible approaches (the last two are just restating what @Zylann describes above in their last comment):

We could add an add_editor_plugin() and remove_editor_plugin() to EditorInterface. After the editor is initialized, it should be safe to add or remove editor plugins at any time, since we do it with addons. The challenge here is can a GDExtension call this method after the EditorNode is initialized and ready? I suspect that GDEXTENSION_INITIALIZATION_EDITOR may happen before EditorNode initialized, and if that's the case, this wouldn't work (at least without adding another initialization level, ex GDEXTENSION_INITIALIZATION_EDITOR_READY)
Mark the editor plugin classes as editor plugins in ClassDB and then have EditorNode loop through them after doing the built-in ones. This could also allow us to attempt to remove editor plugins when the class is being removed. And if we try to add such classes after the editor is already initialized, it could just add them right away.
Actually expose EditorPlugins::add_by_type() via a new GDExtension interface function, and have editor plugins from GDExtensions get added the same way as the built-in ones. This option (as @Zylann points out as well) has the disadvantage of not allowing a way to unregister the editor plugins, and registration would only work at editor startup. If a GDExtension is enabled or disabled sometime in the middle of the editor running, it wouldn't work.

So, I think option nr 1 or 2 are the better way to go.
Does anyone have a preference? Or, any other implementation ideas?

Despite what I wrote in my last comment yesterday, I ended up trying out an implementation that is closer to option nr 3, but done in away to avoid it's downsides (ie. fully supporting adding and removing editor plugins at any time, including engine initialization/deinitialization).
Here's the draft PR: #77010
I did start to implement the other options but abandoned them for various reasons:

Option nr 1: there were issues with initialization order, which would have required adding a new initialization level, and thought that would probably be rejected. And I started to feel that the API would be confusing on EditorInterface, which already has a set_plugin_enabled() and is_plugin_enabled function (where "plugin" actually means "addon").
Option nr 2: marking the classes as editor plugins in ClassDB would have worked, but the only thing we really need from ClassDB, is that it already exists early enough in Godot's initialization process. We could easily avoid adding new code to ClassDB by just keeping a list on EditorPlugins which would also exist early enough. So, I figured it'd be best not add anything to core.


Less code in unsafe and a logic error fix

This PR is pretty simple:

Reduces the amount of code covered by unsafe blocks
Fixes a logic error in Audio::init_dma()

The logic error is a result of asserting that the length and alignment of the data are not their required values, rather than asserting that they are.
Note that even with this fix, the alignment check still doesn't work because mem::align_of_val() returns the minimum alignment needed for the type, which for &[u8] is always 1. I'll submit a separate PR that fixes this.

LGTM, thanks!


Adding image for Eclipse setup documentation

Adding image used in the Performing a Full Build of Umple in Eclipse Using Ant page of the wiki. No code changes have been made.

Thanks.
I wonder if you can organize files in this way?
This is my suggestion
-wiki-resources
- eclipse
- eclipse-plugin
- eclipse-ant-setup

Let me know what you think of the changes in the latest commit. Thanks

Great. Thanks. Now, you can add it to the page. I'll update the page related to the plugin.


Any performance benchmarks of sentence segmentation of Spacy vs stanza

It seems like you utilize Spacy sentence segmenter here. Have you benchmarked stanza's segmenter?

There was a small discussion on LinkedIn about that. One conclusion seemed that if I wanted to replace spaCy that pySBD would be the most interesting candidate.

Thanks for the swift reply. Looking at the image in pySBD readme, blingfire seems accurate enough but ridiculously fast. Interesting.


Some constructive feedback for making Chartist even better

I needed to quickly add some charts to an accounting web application. Looked at many graph packages. Chartist looked the most appealing and I experimented with it, but in the end had issues which were taking too much time to resolve so I’ll have to pick something else but meanwhile here is some constructive feedback for you:

I loved the idea of Chartist. I looked at many graph packages and what attracted me to Chartist  was a small memory footprint, efficient data passing (no redundant x values), big range of charts, open source, and ease of use (more on that later). Your closest rivals are VIS.JS which has beautiful charts but a larger memory footprint, Google Charts whose license doesn’t permit offline use (a deal breaker), and D3 which is beautiful but has a steep learning curve. Compared to these Chartist’s advantage would be ease of use.

But while the initial Chartist examples are easy to use, once you start using it, that ease of use evaporates.

Finding errors is tedious and time consuming. When you do something wrong, instead of an error message, you get something like a null error which isn’t best practice and wastes time chasing them down. RECOMMEDATION: Proper error messages. These will add some bytes to your memory footprint true, but the cost of not doing this is you lose people who decide it’s too much work through. Even “Chartist Error 16” is okay. Looks more pro than a null exception!

I get why Chartist uses plugins: They keep the memory footprint small.  So you have to include them anyway and because they are plugins, they waste extra time to locate, download, unpack (different directory structures) configure, load, and debug.

A big problem with keeping the plugins development separate from the main Chartist engine is they break! Ex: Legend plugin currently doesn’t handle colors properly (someone else posted on Stackoverflow about this).  In the end took too much time to fix and wasn’t even sure it was fixable so that was a deal-breaker. RECOMMENDATION: Bring plugins under the main distro and ensure they work properly.

You also have inconsistent quality in the plugins.  Inconsistent Code quality: Some of those plugins are half-baked, buggy and too much effort to set up. RECOMMENDATION: Bring plugins into the main distro and make sure they work out of the box.

Ease of use. The API should make it as easy as possible for us to serve data with a minimum of effort. The initial examples are great but from there the work piles up and reason we’re using Chartist in the first place is we don’t have time to learn a more advanced package like D3 but Ex: the color instructions for Chartist are too involved. I’m not going to spend time learning SCSS. If I had that time I’m going to learn D3 instead. CONCLUSION: Too much mucking around. (Ex: should be able to display a legend by saying "legend = true" and nothing more!) Options should be terse (not needing pages of setup which some plugins do) and smart (smart defaults so options are optional and not mandatory) Also cleanup API Ex: distributeSeries seems a kludge. I think when that is needed could be detected automatically.

Some of the charts look ugly compared to other packages e.g. These are issues with placement of the labels. Truth is I as in me can live with this because it’s a tradeoff but I can imagine users being turned off by that when there are slicker alternatives so there is a temptation not to invest time in a stopgap.  RECOMMENDATION: Prettier charts. Pretty feels unnecessary but the world loves pretty!

I hope you can consider these because I think Chartist has a lot of promise. D3 is overkill for standard charts, and VIS.JS memory footprint is a problem for 3G. The world needs an easy-to-use open source charting library like Chartist.

Hi there, Thanks for your feedback, and I fully agree with it! Unfortunately I couldn't find any time to work on chartist lately, but I will incorporate most of your feedback and other ideas I've gathered in Chartist 1.0.0 https://github.com/chartist-js/chartist
The main issue is time.... :-(

Hello @GreatWhiteSnark 👋
Thank you for the feedback!
Chartist has recently been updated to version 1.0 with some new exciting changes like ESM and TypeScript support. The migration guide can be found right here. Please consider taking a look : )


New Opportunity for household's non primary contact: record is read only

https://powerofus.force.com/_ui/core/chatter/groups/GroupProfilePage?g=0F980000000CjRe&fId=0D58000002AFily&fromEmail=1

Included in beta release version 3.44 (Beta 1) and higher

Included in production release version 3.44


KAFKA-10544: Migrate KTable aggregate and reduce

As part of the migration of KStream/KTable operations to the new Processor API https://issues.apache.org/jira/browse/KAFKA-8410, this PR includes the migration of KTable aggregate/reduce operations.
Testing strategy: operations should keep the same tests as new processor should be compatible.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I just merged in trunk and re-ran ./gradlew clean :streams:testAll and it passed.


Min/Max Values Do not apply to current temperature

Hello, I use this plugin to automate my wood stove. You allow the temperature thresholds to be changed, but once it passes 212F (100C) it errors out because there is an internal limit in the Characteristic.CurrentTemperature. I forked it awhile ago and added (below) but I don't want to keep updating my fork with your updates. Is this plausible to add the min/max for current temperature as well?
    this.service
      .getCharacteristic(Characteristic.CurrentTemperature)
      .setProps({
        minValue: -600,
        maxValue: 600
      });

Hi there, according to the Homebridge API reference for CurrentTemperature, the minimum and maximum values allowed for the characteristic are -270 and 100 respectively.
The plugin does not interfere with these boundaries. Are you able to confirm that your fork allows you to set values past this range?

@Tommrodrigues Here is a screenshot of the widget surpassing the 212F / 100C limitation.
https://imgur.com/a/gsExuih

That's interesting, I'm surprised that you were able to surpass the limitation imposed by Homebridge.
I have integrated your request into the latest release (commit 770468de6cab7a47f3a1db8c3d928e35809e1396). Thank you for your request!


Make files executable

Codecov Report
Base: 89.58% // Head: 89.58% // No change to project coverage :thumbsup:

Coverage data is based on head (5895a74) compared to base (d8fdd29).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   89.58%   89.58%
=======================================
  Files          42       42
  Lines         749      749
  Branches      149      149
=======================================
  Hits          671      671
  Misses         78       78

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Are Kuma groups coercible to “or” logic?

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
Other
🔖 Feature description
The Kuma monitoring groups are nice if you want be sure a set of services/devices are up having an “at glance” status overview. That is any member of a kuma group is "and"ed in order to have the group status.
What about "or"ing kuma groups? is it possible? I would like to use them for presence detection, grouping all ips (pc, mobile, …) used by family members: if at least one is active that member is at home.
Is it possible? How to do it?
✔ Solution
The group status should have 2 options: or | and.
The and option is as groups are working now.
The or options let a group be up when at leat one of the member is up
❓ Alternatives
No response
📝 Additional Context
No response

I think this is a duplicate of https://github.com/louislam/uptime-kuma/issues/3387
If you agree, could you please close this Issue, as duplicates only create immortal zombies and are really hard to issue-manage?
If not, what makes this issue unique enough to require an additional issue? (Could this be integrated into the issue linked above?) ^^

The and option is as groups are working now

Not quite true.
Please see https://github.com/louislam/uptime-kuma/issues/3629#issuecomment-1689912853

Duplicate request


Spring 3 targeting filter exclusion fix

Description
Same fix as in main.

API change check
API changes are not detected in this pull request.


New Feature?

I've implemented a new live-preview interface as a debug feature - I removed the menu again to keep the functionalities consistent. What do you think about it? I'd be happy to incorporate it into the source code here as well. Unfortunately, my PC isn't the fastest, but otherwise, it works with a 1-second delay.

Oh nice that's super cool. Let's get it integrated and we can worry about optimizing it later.
Is there anything you need from me to help the bot run on your PC? I.e. I can prune the ONNX models to make them faster.

I tried only a variant of this today to make 5000 synthetic images. You can see the results here: https://github.com/Pbatch/ClashRoyaleBuildABot/wiki/State
I will try a super run with all the classes in the game at some point. Let me know if you want to the see the code!


ATL-3241: add geo_ip_sort to intl_autocomplete

Fixes AV-3241
Checklist

[x] Up to date with main
[x] All the tests are passing

[x] Delete all resources created in tests

[x] Prettier
[x] Spectral Lint
[x] npm run bundle outputs nothing suspect
[x] npm run postman outputs nothing suspect

Changes
Adding geo_ip_sort field to intl_autocompletions request body.
Areas of Concern (optional)

I will take a look tomorrow morning. @amaan-lob do you mind fixing the merge conflict?

I will take a look tomorrow morning. @amaan-lob do you mind fixing the merge conflict?

Sorry, it took me a while to get back to this but the merge conflict should now be resolved.


Checkpoint request

I am wanting to try out XPhoneBERT for my school project, but the main page README.md file doesn't clearly show how to generate audio from input text.
I have try it out though, and I find that the model I am inferring through is RoBERTa, not XPhoneBERT.
After that, I try looking for the infer code inference.py. Fortunately, it it is in the VITS_with_XPhoneBERT folder. In this code file, the model state reads from a checkpoint .pth file for inference.
Therefore, I want to ask for this checkpoint so that I can use it for my school project.
Thank you.

Thanks for your consideration, but sorry, following our company rules, I cannot release our TTS model


Extended skbuild.md page

Extended skbuild.md building on sample-data-parallel-extensions repo.
This page builds on sample data-parallel extensions repo: https://github.com/IntelPython/sample-data-parallel-extensions

maybe one last paragraph on some perf. numbers or some other conclusion is needed. But, do not sweat.


How can I use this as a git diff viewer?

Is your feature request related to a problem? Please describe.
Nope.
Describe the solution you'd like
offering configs?
Describe alternatives you've considered
Additional context

You can use it as diff viewer but not as a git diff viewer. There is no integration with git and no plan to add this feature as well.


Properly extend CmsSectionEntity and CmsSectionDefinition

Going deeper into the SW6 rabbit hole i am kinda confused at extending a core entity and hope to get some help understanding what to do.
So i extended sw-cms-section-config and created a dropdown - let's call it customDropdown.
Now of course the value selected in customDropdown won't be saved to the database without a function.
I found out that i have to add a function to class CmsSectionEntity in CmsSectionEntity.php so i added those lines
    /**
     * @var string|null
     */
    protected $customDropdown;

    public function getCustomDropdown(): ?string
    {
        return $this->customDropdown;
    }

    public function setCustomDropdown(string $customDropdown): void
    {
        $this->customDropdown = $customDropdown;
    }

and also extended the function defineFields() in CMSSectionDefinition.php with
new StringField('custom_dropdown', 'customDropdown'),
Works fine! My value gets saved in my database ( column is created on plugin installation ). So that is not my problem at all.
BUT i know that working in core files is, of course, the wrong way.
So i am trying to understand how i extend both files correctly. I tried to follow https://docs.shopware.com/en/shopware-platform-dev-en/how-to/entity-extension#extending-an-entity but i am not sure what event i have to listen here and if i need a subscriber etc.
Appreciate the help!

Not relevant anymore. Documentation and examples helped me understand writing and extending Extensions. Closing this.


32-bit ELF Core target not compliant with IDataTarget interface contract

Per @mikem8361 & @hoyosjs for 32-bit targets the baseAddress is supposed to be sign extended by the caller.
When reading from an ELF Core dump this contract is not being followed.  When loading memory from the core dump with the sign extended address.  The target fails to load the correct address from the core dump.
We are currently consuming 1.1 for dotnet-dunp analyze.  This is breaking 32-bit Linux dump analysis.
/cc @leculver

Which exact function do you mean?  Is there a repro?  Sign extension issues are very prevalent all throughout ClrMD 1.1.  I'll need to know which functions or properties you are seeing this with.

There is no documentation mentioning sign extended in the unmanaged api docs.
https://docs.microsoft.com/en-us/dotnet/framework/unmanaged-api/common-data-types-unmanaged-api-reference
https://docs.microsoft.com/en-us/dotnet/framework/unmanaged-api/debugging/iclrdatatarget-readvirtual-method

@leculver
The issue I observed was with an ELF core dump.  Using IDataTarget.  These APIs
        bool ReadMemory(ulong address, byte[] buffer, int bytesRequested, out int bytesRead);
        bool ReadMemory(ulong address, IntPtr buffer, int bytesRequested, out int bytesRead);

I made a targeted fix for CoreDumpReader.
commit de55b80a5753f29a68481605e0b7abd0f4865125 (HEAD)
Author: Steve MacLean<EMAIL_ADDRESS>Date:   Mon Jun 22 15:36:01 2020 -0400

    Fix 32-bit CoreDumpReader to strip high bits of CLRDATA_ADDRESS

diff --git a/src/Microsoft.Diagnostics.Runtime/src/DataReaders/Core/CoreDumpReader.cs b/src/Microsoft.Diagnostics.Runtime/src/DataReaders/Core/CoreDumpReader.cs
index 1a5e900..7c7c911 100644
--- a/src/Microsoft.Diagnostics.Runtime/src/DataReaders/Core/CoreDumpReader.cs
+++ b/src/Microsoft.Diagnostics.Runtime/src/DataReaders/Core/CoreDumpReader.cs
@@ -233,18 +233,31 @@ namespace Microsoft.Diagnostics.Runtime
             }
         }

+        // Convert CLRDATA_ADDRESS to ELF address
+        private long GetElfAddress(ulong addr)
+        {
+            if (_pointerSize == 4)
+            {
+                // CLRDATA_ADDRESS 32-bit addresses are sign extended to 64 bits.
+                // This does not match ELF treatment
+                // Strip sign bits to get the ELF address
+                return (long) (addr & 0xffffffff);
+            }
+            return (long) addr;
+        }
+
         public uint ReadDwordUnsafe(ulong addr)
         {
-            int read = _core.ReadMemory((long)addr, _buffer, 4);
+            int read = _core.ReadMemory(GetElfAddress(addr), _buffer, 4);
             if (read == 4)
                 return BitConverter.ToUInt32(_buffer, 0);

             return 0;
         }

-        public bool ReadMemory(ulong address, byte[] buffer, int bytesRequested, out int bytesRead)
+        public bool ReadMemory(ulong addr, byte[] buffer, int bytesRequested, out int bytesRead)
         {
-            bytesRead = _core.ReadMemory((long)address, buffer, bytesRequested);
+            bytesRead = _core.ReadMemory(GetElfAddress(addr), buffer, bytesRequested);
             return bytesRead > 0;
         }

@@ -263,7 +276,7 @@ namespace Microsoft.Diagnostics.Runtime

         public ulong ReadPointerUnsafe(ulong addr)
         {
-            int read = _core.ReadMemory((long)addr, _buffer, _pointerSize);
+            int read = _core.ReadMemory(GetElfAddress(addr), _buffer, _pointerSize);
             if (read == _pointerSize)
             {
                 if (_pointerSize == 8)
@@ -278,7 +291,7 @@ namespace Microsoft.Diagnostics.Runtime

         public bool VirtualQuery(ulong address, out VirtualQueryData vq)
         {
-            long addr = (long)address;
+            long addr = GetElfAddress(address);
             foreach (ElfProgramHeader item in _core.ElfFile.ProgramHeaders)
             {
                 long start = item.VirtualAddress;
@@ -305,4 +318,4 @@ namespace Microsoft.Diagnostics.Runtime
                 _threads.Add(status.ThreadId, status);
         }
     }
-}
\ No newline at end of file
+}

I could move it up a few layers to make it more generic...

This is the root cause of https://github.com/dotnet/diagnostics/issues/1255

I've added a few thoughts about the problem in the pull request.  We'll need to go a different direction in 2.0 to fix this, but I'm fine with the proposed spot-fix in 1.1.


Rampant noise added at each step of sampling when animdiff is in use.

there are no errors with my install, no smoking gun. but when I add the Animdiff loader into the workflow, my nodes all seem to permanently start adding noise to every sampling step.
this persists after animdiff is unloaded and requires a server restart to fix.
I am fairly sure this is some odd interaction with my comfyUI install because i've had some issues with it and had to delete tensorflow to make the thing run. so it could easily be my fault but... yeah, this is the only issue I have after fixing comfyUI not starting and it mystifies me.
just seems to bork denoising somehow :<

Hi @Ferniclestix, sorry for my late reply. Please update to the latest version, this issue should be fixed already.

thanks, ill re-download and check it out. :)


Invalid registration attempt

[22:11:22] [Server thread/WARN] [FML]: ****************************************
[22:11:22] [Server thread/WARN] [FML]: * Invalid registration attempt for an Ore Dictionary item with name oreResonating has occurred. The registration has been denied to prevent crashes. The mod responsible for the registration needs to correct this.
[22:11:22] [Server thread/WARN] [FML]: *  at net.minecraftforge.oredict.OreDictionary.registerOreImpl(OreDictionary.java:619)
[22:11:22] [Server thread/WARN] [FML]: *  at net.minecraftforge.oredict.OreDictionary.registerOre(OreDictionary.java:605)
[22:11:22] [Server thread/WARN] [FML]: *  at net.minecraftforge.oredict.OreDictionary.registerOre(OreDictionary.java:604)
[22:11:22] [Server thread/WARN] [FML]: *  at mcjty.deepresonance.ForgeEventHandlers.registerBlocks(ForgeEventHandlers.java:37)
[22:11:22] [Server thread/WARN] [FML]: *  at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_180_ForgeEventHandlers_registerBlocks_Register.invoke(.dynamic)
[22:11:22] [Server thread/WARN] [FML]: *  at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)...
[22:11:22] [Server thread/WARN] [FML]: ****************************************

No crash, I suppose its this mod fault because of call stack.
Deep Resonance 1.12-1.4.9
MjctLib 1.12-2.4.4
[21:50:07] [main/INFO] [FML]: Forge Mod Loader version <IP_ADDRESS>0 for Minecraft 1.12 loading
[21:50:07] [main/INFO] [FML]: Java is Java HotSpot(TM) 64-Bit Server VM, version 1.8.0_141, running on Windows 10:amd64:10.0, installed at C:\Program Files\Java\jre1.8.0_141

Heyo
Just dropping by to let you know this is still an issue with the latest version
Version

Minecraft 1.12.2
jre1.8.0_151
forge-1.12.2-<IP_ADDRESS>75-universal.jar
mcjtylib-1.12-2.5.0
deepresonance-1.12-1.5.0

Log
[16:57:59] [main/WARN] [FML]: ****************************************
[16:57:59] [main/WARN] [FML]: * Invalid registration attempt for an Ore Dictionary item with name oreResonating has occurred. The registration has been denied to prevent crashes. The mod responsible for the registration needs to correct this.
[16:57:59] [main/WARN] [FML]: *  at net.minecraftforge.oredict.OreDictionary.registerOreImpl(OreDictionary.java:642)
[16:57:59] [main/WARN] [FML]: *  at net.minecraftforge.oredict.OreDictionary.registerOre(OreDictionary.java:628)
[16:57:59] [main/WARN] [FML]: *  at net.minecraftforge.oredict.OreDictionary.registerOre(OreDictionary.java:627)
[16:57:59] [main/WARN] [FML]: *  at mcjty.deepresonance.ForgeEventHandlers.registerBlocks(ForgeEventHandlers.java:37)
[16:57:59] [main/WARN] [FML]: *  at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_872_ForgeEventHandlers_registerBlocks_Register.invoke(.dynamic)
[16:57:59] [main/WARN] [FML]: *  at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)...
[16:57:59] [main/WARN] [FML]: ****************************************

Hmm I actually don't know what's wrong here. This is my code:
    OreDictionary.registerOre("oreResonating", ModBlocks.resonatingOreBlock);

nm. Fixed it for next release

I don't know enough Java to be of assistance. But you've done some amazing work. I don't know if this breaks anything in game as your mods are the only ones I k ow of that use resonating ore, but I'll dig around and see if I can help figure it out.

The item needs to be created and registered before adding to the dictionary.

Hey guys. I fixed it already :-)


CMakeFiles/Makefile2:706: recipe for target 'utils/CMakeFiles/jetson-utils.dir/all' failed
make[1]: *** [utils/CMakeFiles/jetson-utils.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

Hi @omrode1, what version of JetPack-L4T are you on?
This should have automatically been installed when you ran cmake, in the libgstrtspserver-1.0-dev package:
https://github.com/dusty-nv/jetson-inference/blob/3f0603a3957b8ccde59caa848792d427ad0a6742/CMakePreBuild.sh#L34
Can you try running sudo apt-get install libgstrtspserver-1.0-dev ?

cat /etc/nv_tegra_release
R32 (release), REVISION: 5.0, GCID: 25531747, BOARD: t186ref, EABI: aarch64, DATE: Fri Jan 15 23:21:05 UTC 2021
i found this, does that anything to do with the l4t version or else there is an another command ?

so, the RTSP error seems to have been resolved using sudo apt-get install libgstrtspserver-1.0-dev
but the new error is being emerged and the following texts has been thrown out.
[  1%] Linking CXX shared library ../aarch64/lib/libjetson-utils.so
/usr/bin/ld: cannot find -lGL
collect2: error: ld returned 1 exit status
utils/CMakeFiles/jetson-utils.dir/build.make:5196: recipe for target 'aarch64/lib/libjetson-utils.so' failed
make[2]: *** [aarch64/lib/libjetson-utils.so] Error 1
CMakeFiles/Makefile2:706: recipe for target 'utils/CMakeFiles/jetson-utils.dir/all' failed
make[1]: *** [utils/CMakeFiles/jetson-utils.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

Hi @omrode1, do you have libGL.so under /usr/lib/aarch64-linux-gnu ?
$ find /usr -name 'libGL*'
/usr/local/cuda-10.2/samples/common/lib/linux/aarch64/libGLEW.a
/usr/local/cuda-10.2/samples/common/lib/linux/x86_64/libGLEW.a
/usr/local/cuda-10.2/samples/common/lib/linux/armv7l/libGLEW.a
/usr/lib/chromium-browser/swiftshader/libGLESv2.so
/usr/lib/chromium-browser/libGLESv2.so
/usr/lib/aarch64-linux-gnu/libGL.so.1.0.0
/usr/lib/aarch64-linux-gnu/libGLU.a
/usr/lib/aarch64-linux-gnu/libGLdispatch.so.0
/usr/lib/aarch64-linux-gnu/libGLEWmx.so.1.13
/usr/lib/aarch64-linux-gnu/libGLESv1_CM.so
/usr/lib/aarch64-linux-gnu/tegra/libGLX_nvidia.so.0
/usr/lib/aarch64-linux-gnu/libGLX.so.0.0.0
/usr/lib/aarch64-linux-gnu/libGL.so
/usr/lib/aarch64-linux-gnu/libGL.so.1
/usr/lib/aarch64-linux-gnu/libGLX_mesa.so.0
/usr/lib/aarch64-linux-gnu/libGLESv2.so.2.0.0
/usr/lib/aarch64-linux-gnu/libGLX.so.0
/usr/lib/aarch64-linux-gnu/libGLdispatch.so.0.0.0
/usr/lib/aarch64-linux-gnu/tegra-egl/libGLESv2_nvidia.so.2
/usr/lib/aarch64-linux-gnu/tegra-egl/libGLESv1_CM_nvidia.so.1
/usr/lib/aarch64-linux-gnu/libGLESv1_CM.so.1
/usr/lib/aarch64-linux-gnu/libGLX.so
/usr/lib/aarch64-linux-gnu/libGLESv1_CM.so.1.0.0
/usr/lib/aarch64-linux-gnu/libGLESv2.so.2
/usr/lib/aarch64-linux-gnu/libGLdispatch.so
/usr/lib/aarch64-linux-gnu/libGLU.so.1
/usr/lib/aarch64-linux-gnu/libGLX_mesa.so.0.0.0
/usr/lib/aarch64-linux-gnu/libGLEWmx.so.1.13.0
/usr/lib/aarch64-linux-gnu/libGLU.so.1.3.1
/usr/lib/aarch64-linux-gnu/libGLESv2.so
/usr/lib/aarch64-linux-gnu/libGLX_indirect.so.0
/usr/lib/aarch64-linux-gnu/libGLU.so


feat: thor streaming swaps quote

Description
Does what it says on the box: this allows us to get quotes for the price-optimized streaming swaps, which will now be automagically reflected in the UI
Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
N/A
Risk

Low - this really only passes a new queryparam in, and the way THOR quotes work is both the streaming and regular flavor are returned in the quote response, the latter being unaffected by whether or not a streaming swap is requested in the quote, meaning there is effectively no regressions risks on regular quotes
Testing

Try a bigly quote e.g ~2000 USD worth of an UTXO to another UTXO
Ensure the streaming swap value is higher than the non-streaming flavor

Engineering

☝🏽

Operations

☝🏽

Screenshots (if applicable)

Just clarifying with Gomes as to why this is required since we make our own separate memos for regular and streaming quotes


slow intellisense/type checking

Issue Type: Bug
Possibly related issues: https://github.com/Microsoft/vscode/issues/51819, https://github.com/Microsoft/vscode/issues/53541
1.24.x appears to have introduced a performance regression for performance in Typescript projects. The type checking process frequently hovers at 100% for several seconds at a time, with a corresponding lack of updates in the UI (red underlines where they don't make sense, out of date type information, Intellisense stating that it's "Loading...").
I switched to the insiders build and disabled all extensions and the issue persists.
This is especially bad when there's a lot of churn, such as changing branches or even when making a quick sequence of edits. Anecdotally, the longer said sequence of edits is the longer the type checker hangs, up to a limit where it appears to catch up (5-10 seconds or so? I haven't timed it). Changes made in one open file are often slow to be reflected in another open file (such as when I change the type of a value).
Is there a way to downgrade to 1.23.x? Both so it works better for me and so I can help verify that it was indeed 1.23 -> 1.24 that caused the problem. What other debugging information would help?
VS Code version: Code - Insiders 1.25.0-insider (0f080e5267e829de46638128001aeb7ca2d6d50e, 2018-07-04T14:06:34.850Z)
OS version: Darwin x64 17.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 3

Memory (System)
16.00GB (0.06GB free)

Process Argv
/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron

Screen Reader
no

VM
0%

Extensions: none

code-insiders --status
Version:          Code - Insiders 1.25.0-insider (0f080e5267e829de46638128001aeb7ca2d6d50e, 2018-07-04T14:06:34.850Z)
OS Version:       Darwin x64 17.4.0
CPUs:             Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)
Memory (System):  16.00GB (0.18GB free)
Load (avg):       3, 3, 3
VM:               0%
Screen Reader:    no
Process Argv:     /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron
GPU Status:       2d_canvas:                    enabled
                  flash_3d:                     enabled
                  flash_stage3d:                enabled
                  flash_stage3d_baseline:       enabled
                  gpu_compositing:              enabled
                  multiple_raster_threads:      enabled_on
                  native_gpu_memory_buffers:    enabled
                  rasterization:                enabled
                  video_decode:                 enabled
                  video_encode:                 enabled
                  vpx_decode:                   enabled
                  webgl:                        enabled
                  webgl2:                       enabled

CPU %   Mem MB     PID  Process
    3      131   52530  code-insiders main
    3       98   52531     gpu-process
    7      328   52532     window (SiteService.ts — clues-frontend)
    0       98   52538       extensionHost
   99      344   52542         electron_node electronForkStart.js tsserver.js
    0       49   52554           electron_node typingsInstaller.js tsserver.js typesMap.js
    0       66   52560         electron_node jsonServerMain.js
    0       49   52539       watcherService
    0       49   52571       searchService
    0       82   52540     shared-process
    2       82   52577     window (Process Explorer)

Workspace Stats:
|  Window (SiteService.ts — clues-frontend)
|    Folder (clues-frontend): 268 files
|      File types: js(80) tsx(77) ts(37) scss(33) json(6) yml(3) md(3)
|                  woff2(2) png(2) ico(2)
|      Conf files: tslint.json(2) makefile(1) package.json(1) tsconfig.json(1)
|                  settings.json(1)

Does this reproduce in the latest VS Code build with all extensions disabled?

@mjbvz I had the same problem, when i disabled all the extensions the problem disappeared on VS Code 1.25.0.
Btw i didn't installed new extensions from when i was on version 1.23.1 and there were no problems with all the extensions enabled.

I am experiencing this with 1.25.0 as well, the problem with finding a cause or validating a fix is that it dosen't instantly happen on starting vscode. It builds up over time where after a couple of hours the typechecker becomes unusably slow and even just typing becomes very unresponsive (takes up to a second sometimes after a few hours of work).
The rest of my system is running completely fine in the meantime. One of 8 virtual cores (4 real cores with HT) is often used 100% by the vscode tsserver for a few seconds after saving a file. But everything else is below 10% usage and RAM is also still available, SWAP completely untouched.
External tsc watchers and webpack builders are continuing to run fine without needing restarts even after days of running.
I have however definitely experienced it with all extensions disabled in the stable 1.25.0.
Testing the insider builds right now.

FWIW I downgraded to 1.23.x and the problem went away. I'll try to reproduce in the next couple days on the latest insiders build but as @maritz has noted it takes a bit to get there as it's not a binary working/broken reproduction but more of a slow climb to sadness.

So far so good.
Some unrelated problems, but the slowdowns did not appear for me with the following extensions installed:

Bracket Pair Colorizer
Docker
Document This
EditorConfig for VS Code
Gitlens
markdownlint
Prettier
TSLint

I had a much shorter list on 1.25 at one point, so this list should have definitely triggered it imo.

Mine was mostly better for a few days until yesterday when the same issues seem to have returned noticeably.
I noticed some more patterns in the behavior: the delay is easiest to trigger when using go-to-definition to go to a file I haven't visited yet (or in some time) and is accompanied by a large jump in memory usage of the tsserver.js extension process noted in the original report (sometimes up to ~200mb in a single shot). Memory usage of that process tends to hover at around 1.1gb; unsure if that's normal or not.
I still see other instances of the problem, such as very long wait times for Intellisense to come up with a list of suggestions, but the pattern for those is harder to identify. When that does happen, it tends to stick around for a while, which is to say that a file/workplace in a bad state doesn't seem to get better over time like it might with a simple empty-cache issue.

@seansfkelley Did you try insiders or still on 1.25?

Oops, sorry; this is 1.26.0-insider 7e992cab07f6d3faf5a137e8ca0d094f8dffeee6.

Here's an example of the types of issues that crop up routinely. I was editing code higher up in the file, which was of course breaking syntax further down in the file. The message is obviously erroneous
but this file never refreshed itself even once the file was again syntactically valid and should have type-checked.
I had time to take both of these screen shots, write this comment and then edit it, before I gave up and ran "Reload window",* at which point the file (without further edits) was considered valid, as it should be.
Extensions are still disabled; insiders version d1272ff8edbaa54c81382f82fa2091f63ed3daea.
* "Reload project" doesn't ever seem to help.

Please try collecting the TS Server log:

Set "typescript.tsserver.log": "verbose",
Restart VS Code and reproduce the problem
In VS Code, run the TypeScript: Open TS Server log command
This should open a folder with a tsserver.log file in it

Look through that log file for errors or stack traces. If you can share the log, I can also take a look to see if anything stands out

⚠Warning: The TypeScript log may include information from your workspace, including file paths and source code. If you have any concerns about posting this publicly on Github, just let me know and we can arrange something else. On our side, we only use these logs to investigate issues like this

FWIW, these performance issues have been slowly tapering off, so I haven't seen cases as egregious as originally cited. I still have no idea what caused the issue in the first place (bad combination of libraries? over-aggressive cache clearing? slow filesystem?) but I've been staying on the insiders build and it's been improving back to the point where it used to be.
If the issue returns, I'll try to collect some useful logs before reopening.


Add awslabs/smithy-rs-server as a crate owner in the publisher tool

With this change, the publisher tool won't fail when publishing the
aws-smithy-http-server crate.
Motivation and Context
https://github.com/awslabs/smithy-rs/runs/7663884426?check_suite_focus=true
Testing
I have not tested this change. The correct_owner function has side-effects. I could extract:
let incorrect_owners = owners
    .iter()
    .filter(|&owner| !CRATE_OWNERS.iter().any(|o| o == owner));

(link)
into its own function to make that logic testable, but we would only be testing that filter.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I think we need to refactor the publisher so that it places both groups on smithy-rs runtime crates, but only the SDK group on the AwsRuntime and AwsSdk crates. The PackageCategory enum can be used to tell which crate is which.
Alternatively, we can just remove the groups entirely and only give the bot access, since really, it's the only thing that actually needs access for releases.

I think we need to refactor the publisher so that it places both groups on smithy-rs runtime crates, but only the SDK group on the AwsRuntime and AwsSdk crates. The PackageCategory enum can be used to tell which crate is which.

Ah! Much better. Didn't know we had PackageCategory. I've done the change in https://github.com/awslabs/smithy-rs/pull/1619/commits/b07709c977635e8d81c7fb19d21786b641a4ddb2.


can NOAA get a release of netcdf-c with the latest zlib/szip features?

@WardF, the NOAA operational team (from back East) have asked me to ask whether there can be a netcdf-c library release within the next month or so? And if not, then when can there be a release?
The recent changes to zlib/szip compression have made a big difference for them, and they want to release that (already delayed) code into operations and to the science community,. The slow sequential compression was a big roadblock to their release, and now it is gone.
Their goal in this release is to give the community netcdf-based data files, for greater ease of use in the science community.
However, they cannot release code that depends on the netcdf-c master branch, they need to specify a formal release. While they can build and use the master branch, for the purposes of scientific reproducability, they really need a release version.
So any information you can provide would be helpful, and I will pass it along to the NOAA team. If there is anything I can do to help, please let me know.

The next netcdf release is of interest to leadership at the Environmental Modeling Center (EMC). (Those are the guys that do the operational weather forecasts.)
I have explained to them that I am no longer working for Unidata; that I don't influence the team, nor do I have any access to team planning.
They are in charge of a serious operational system and are used to things being planned far in advance. They are not looking for a firm commitment to any date, but just asking if there will be a release in the next few months.
I'm sure they would welcome any information you wish to provide.

We will have a release out shortly; just working on a few details. Feel free to put them in contact (or message me your contact their offline if you prefer) and I'll reach out and give them the details.  Thanks Ed, appreciate it!

Thanks, I have let them know that you are the one to contact for release info. You may get contacted. ;-)
I have also relayed the news that a release will be out reasonably soon. This is all they are immediately concerned about. Their next release goes out in a couple months, and they are counting on the szip and parallel zlib being present in a formally released netcdf-c by then. They are currently testing with netcdf-c and netcdf-fortran master branch, but they would like to specify an actual release for their eventual users.
Thanks for all your hard work and thanks for merging my PRs. These changes are making netcdf considerably more performant for high-volume data producers like NOAA.


[Bug]: ssh_askpass error intermittently popping up

Describe the bug
I had obsidian-git working on this machine flawlessly for a while, but in the recent past (I believe coinciding with github changing their keys), it has started popping up this error when trying to sync:

ssh_askpass: exec(/usr/bin/ssh-askpass): No such file or directory
Host key verification failed.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

However, git works everywhere else on my machine, and in fact, if I go to my vault directory and manually do git pull, git commit -am "blah blah", git push, it all works fine.
In fact, I think that it was even sometimes working intermittently despite also saying this error!
I uninstalled and reinstalled obsidian-git, and now it appears to reliably sync, but it still also gives the error, which I would like to remove. What can I try?
Relevant errors (if available)
Uncaught (in promise) Error: ssh_askpass: exec(/usr/bin/ssh-askpass): No such file or directory
Host key verification failed.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

    at Object.action (plugin:obsidian-git:26501:25)
    at PluginStore.exec (plugin:obsidian-git:26526:25)
    at eval (plugin:obsidian-git:24031:43)
    at new Promise (<anonymous>)
    at GitExecutorChain.handleTaskData (plugin:obsidian-git:24029:16)
    at GitExecutorChain.eval (plugin:obsidian-git:24013:44)
    at Generator.next (<anonymous>)
    at fulfilled (plugin:obsidian-git:22858:24)

Steps to reproduce
I don't know how to do this without having exactly my setup
Expected Behavior
It to sync without the ssh-askpass error
Addition context
Obsidian version 1.1.16
Ubuntu 20.04
git version 2.25.1
I have no idea why it's asking for ssh-askpass. On my other machine, with the same exact versions as this one, it doesn't have ssh-askpass installed either.
Operating system
Linux
Installation Method
AppImage
Plugin version
2.19.1

May you try installing ssh-askpass?

May you try installing ssh-askpass?

Hi @Vinzent03 , I did at one point, and I don't think it fixed the issue. But regardless, I don't have ssh-askpass installed on my other computer with nearly identical setup (just Ubuntu 22.04 on other vs 20.04 on this machine), and I don't think I should need it.
I think it should be a big clue that obsidian-git is currently working in the sense that it's pulling/committing/pushing successfully, but it's also trying to do something with ssh-askpass.

May you try installing ssh-askpass?

After installing ssh-askpass, everytime I try to push it asks for the password and then does the job.
Thank you :heart:

It probably needed ssh-askpass, because the environment variable SSH_ASKPASS was set to that file. I'm closing this, because this depends on your ssh setup.


[10.0.0] last puppet-systemd not supported

Warning:
'puppet-redis' (v10.0.0) requires 'puppet-systemd' (>= 2.0.0 < 7.0.0)

Hint:
https://github.com/voxpupuli/puppet-redis/issues/522 must be fixes before.

This is already merged in https://github.com/voxpupuli/puppet-redis/pull/518 and will be available in the next release

Only an simple update of the version number will not work, because puppet-redis will use functions, that are deprecated in puppet-systemd 7.0.0 and will let puppet-redis fails.

which one exactly?
the tests didn't reveal any such problem, maybe we need new test.

See my commend. I see the same problem when using puppet-systemd 7.0.0

Ok. But doesn't this make this issue just a duplicate of #552?

Unfortunately, I don't know if there are more places where code is used that has been marked as obsolete. This is the first place I stumbled across it.

Same for the last one:
'puppet-redis' (v11.0.0) requires 'puppet-systemd' (>= 2.0.0 < 8.0.0)


Tests not compiling on Linux

I'm using Linux Mint, and I'm getting some errors that seems the compiler isn't recognizing some language features correctly:
 cc -std=c99 -fPIC tests/audio.c    `simple2d --libs` -o tests/audio
tests/audio.c: In function ‘on_key’:
tests/audio.c:58:11: error: incompatible type for argument 1 of ‘S2D_PlaySound’
           S2D_PlaySound(snd_1);
           ^
In file included from tests/audio.c:1:0:
/usr/local/include/simple2d.h:300:6: note: expected ‘Sound’ but argument is of type ‘struct Sound *’
 void S2D_PlaySound(Sound sound);
      ^
tests/audio.c:60:11: error: incompatible type for argument 1 of ‘S2D_PlaySound’
           S2D_PlaySound(snd_2);
           ^
In file included from tests/audio.c:1:0:
/usr/local/include/simple2d.h:300:6: note: expected ‘Sound’ but argument is of type ‘struct Sound *’
 void S2D_PlaySound(Sound sound);
      ^
tests/audio.c:65:11: error: incompatible type for argument 1 of ‘S2D_PlayMusic’
           S2D_PlayMusic(mus_1, -1);
           ^
In file included from tests/audio.c:1:0:
/usr/local/include/simple2d.h:315:6: note: expected ‘Music’ but argument is of type ‘struct Music *’
 void S2D_PlayMusic(Music music, int times);
      ^
tests/audio.c:67:11: error: incompatible type for argument 1 of ‘S2D_PlayMusic’
           S2D_PlayMusic(mus_2, -1);
           ^
In file included from tests/audio.c:1:0:
/usr/local/include/simple2d.h:315:6: note: expected ‘Music’ but argument is of type ‘struct Music *’
 void S2D_PlayMusic(Music music, int times);
      ^
tests/audio.c:104:7: error: too few arguments to function ‘S2D_Close’
       S2D_Close();
       ^
In file included from tests/audio.c:1:0:
/usr/local/include/simple2d.h:229:5: note: declared here
 int S2D_Close(Window *window);
     ^
tests/audio.c: In function ‘main’:
tests/audio.c:122:9: error: incompatible types when assigning to type ‘struct Sound *’ from type ‘Sound’
   snd_1 = S2D_CreateSound("media/sound.wav");
         ^
tests/audio.c:123:9: error: incompatible types when assigning to type ‘struct Sound *’ from type ‘Sound’
   snd_2 = S2D_CreateSound("media/music.ogg");
         ^
tests/audio.c:125:9: error: incompatible types when assigning to type ‘struct Music *’ from type ‘Music’
   mus_1 = S2D_CreateMusic("media/sound.wav");
         ^
tests/audio.c:126:9: error: incompatible types when assigning to type ‘struct Music *’ from type ‘Music’
   mus_2 = S2D_CreateMusic("media/music.ogg");
         ^
tests/audio.c:132:3: warning: implicit declaration of function ‘S2D_FreeWindow’ [-Wimplicit-function-declaration]
   S2D_FreeWindow(window);
   ^
make: ** [tests] Erro 1

cc --version show this:
cc (Ubuntu 4.9.3-8ubuntu2~14.04) 4.9.3
Copyright (C) 2015 Free Software Foundation, Inc.

Do sudo make install to update simple2d header in installation path.

thanks, this worked.


with-universal-configuration example errors

Examples bug report
https://github.com/zeit/next.js/tree/canary/examples/with-universal-configuration
Example name
with-universal-configuration
Describe the bug
mherold-mac:with-universal-configuration-app mherold$ yarn dev
yarn run v1.7.0
$ next
Error: .plugins[0][1] must be an object, false, or undefined
    at assertPluginItem (/Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/validation/option-assertions.js:157:15)
    at /Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/validation/option-assertions.js:134:14
    at Array.forEach (<anonymous>)
    at assertPluginList (/Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/validation/option-assertions.js:133:9)
    at /Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/validation/options.js:84:20
    at Array.forEach (<anonymous>)
    at validate (/Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/validation/options.js:62:21)
    at /Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/config-chain.js:141:36
    at cachedFunction (/Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/caching.js:40:17)
    at init (/Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/config-chain.js:122:12)
    at /Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/config-chain.js:206:17
    at buildRootChain (/Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/config-chain.js:85:20)
    at loadPrivatePartialConfig (/Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/partial.js:41:53)
    at loadPartialConfig (/Users/mherold/git/temp/with-universal-configuration-app/node_modules/@babel/core/lib/config/partial.js:66:16)
    at babelConfig (/Users/mherold/git/temp/with-universal-configuration-app/node_modules/next/dist/server/build/webpack.js:88:57)
    at _callee2$ (/Users/mherold/git/temp/with-universal-configuration-app/node_modules/next/dist/server/build/webpack.js:164:34)
error Command failed with exit code 1.

Irrespective of this error, I'd love an alternate path to defining our own environment variables at build time.

You should use commonjs modules in .babelrc.js. Don't forget to update babel-plugin-transform-define to 1.3.0
// .babelrc.js
const env = require("./env-config.js");

module.exports = {
  presets: ["next/babel"],
  plugins: [["transform-define", env]]
};

I'll make PR on this issue :)

You're lovely people, thank you!


from_meshio fails on old ex27

I was trying to regenerate a mesh for ex27 as part of the discussion with @bhaveshshrimali on the speed of pypardiso relative to scipy.sparse in #690 so that the number of elements could be varied but the old make_mesh(make_geom(...)) code seems not to work with the new (#680 ?) skfem.io.mesh.from_meshio.
The code:
from skfem import *
from skfem.io.meshio import from_meshio

from itertools import cycle, islice

import numpy as np

from pygmsh import generate_mesh
from pygmsh.built_in import Geometry

def make_geom(length: float, lcar: float) -> Geometry:
    # Barkley et al (2002, figure 3 a - c)
    geom = Geometry()

    points = []
    for point in [
        [0, -1, 0],
        [length, -1, 0],
        [length, 1, 0],
        [-1, 1, 0],
        [-1, 0, 0],
        [0, 0, 0],
    ]:
        points.append(geom.add_point(point, lcar))

    lines = []
    for termini in zip(points, islice(cycle(points), 1, None)):
        lines.append(geom.add_line(*termini))

    for k, label in [
        ([1], "outlet"),
        ([2], "ceiling"),
        ([3], "inlet"),
        ([0, 4, 5], "floor"),
    ]:
        geom.add_physical(list(np.array(lines)[k]), label)

    geom.add_physical(geom.add_plane_surface(geom.add_line_loop(lines)), "domain")

    return geom

if __name__ == "__main__":
    from pathlib import Path

    geom = make_geom(35.0, 0.2)

    with open(Path(__file__).with_suffix(".geo"), "w") as fgeo:
        fgeo.write(geom.get_code())

    mio = generate_mesh(geom, dim=2)
    print(mio)

    mesh = from_meshio(mio)
    print(mesh)

    mesh.save(Path(__file__).with_suffix(".vtk"))

When I run this with pygmsh==6.1.1 (before the big API change in pygmsh 7), I believe that this generates a valid *.geo file, which is accepted by Gmsh (4.8.4 here) and Gmsh can write this as MSH 4.1 file which is understood by meshio, but something goes wrong in skfem.io.meshio.from_meshio:
Traceback (most recent call last):
  File "/home/gdmcbain/src/scikit-fem/docs/examples/ex27_mesh.py", line 55, in <module>
    mesh = from_meshio(mio)
  File "/home/gdmcbain/miniconda3/envs/skfem/lib/python3.9/site-packages/skfem/io/meshio.py", line 93, in from_meshio
    facets = {k: [tuple(f) for f in
  File "/home/gdmcbain/miniconda3/envs/skfem/lib/python3.9/site-packages/skfem/io/meshio.py", line 94, in <dictcomp>
    np.sort(m.cells_dict[bnd_type][v[bnd_type]])]
IndexError: index 381 is out of bounds for axis 0 with size 380

I don't mean to suggest that we should rely upon pygmsh<7 but I believe the GEO and MSH 4.1 files are valid, as is the meshio.Mesh, but I'll check.
The intermediate files are generated and interrogated with
python docs/examples/ex27_mesh.py  # say, depending on where the above is saved
gmsh -2 docs/examples/ex27_mesh.geo
meshio info docs/examples/ex27_mesh.msh

Hmmm. this runs fine for me.
if __name__ == "__main__":
    from pathlib import Path

    geom = make_geom(35.0, 0.2)

    with open(Path(__file__).with_suffix(".geo"), "w") as fgeo:
        fgeo.write(geom.get_code())

    mio = generate_mesh(geom, dim=2)
    print(f"meshio: {mio}")

    mesh = from_meshio(mio)
    print(f"scikit-fem: {mesh}")

    mesh.save(Path(__file__).with_suffix(".vtk"))

Info    : Running 'gmsh -2 C:\Users\bshri\AppData\Local\Temp\tmpyyrojl4v.geo -format msh -bin -o C:\Users\bshri\AppData\Local\Temp\tmpqwcqah75.msh' [Gmsh 4.8.3, 1 node, max. 1 thread]
Info    : Started on Wed Aug 18 11:10:08 2021
Info    : Reading 'C:\Users\bshri\AppData\Local\Temp\tmpyyrojl4v.geo'...
Info    : Done reading 'C:\Users\bshri\AppData\Local\Temp\tmpyyrojl4v.geo'
Info    : Meshing 1D...
Info    : [  0%] Meshing curve 1 (Line)
Info    : [ 20%] Meshing curve 2 (Line)
Info    : [ 40%] Meshing curve 3 (Line)
Info    : [ 50%] Meshing curve 4 (Line)
Info    : [ 70%] Meshing curve 5 (Line)
Info    : [ 90%] Meshing curve 6 (Line)
Info    : Done meshing 1D (Wall 0.00199914s, CPU 0s)
Info    : Meshing 2D...
Info    : Meshing surface 8 (Plane, Frontal-Delaunay)
Info    : Done meshing 2D (Wall 1.52614s, CPU 1.48438s)
Info    : 33772 nodes 67548 elements
Info    : Writing 'C:\Users\bshri\AppData\Local\Temp\tmpqwcqah75.msh'...
Info    : Done writing 'C:\Users\bshri\AppData\Local\Temp\tmpqwcqah75.msh'
Info    : Stopped on Wed Aug 18 11:10:09 2021 (From start: Wall 1.57989s, CPU 1.54688s)
meshio: <meshio mesh object>
  Number of points: 33772
  Number of cells:
    line: 700
    line: 40
    line: 720
    line: 20
    line: 20
    line: 20
    triangle: 66022
  Cell sets: outlet, ceiling, inlet, floor, domain, gmsh:bounding_entities
  Point data: gmsh:dim_tags
  Cell data: gmsh:physical, gmsh:geometrical
  Field data: outlet, ceiling, inlet, floor, domain
scikit-fem: Triangular mesh with 33772 vertices and 66022 elements.
WARNING:root:VTK requires 3D points, but 2D points given. Appending 0 third component.

Oh, O. K., great.  (I wonder what's going on here, but I'll sort that out later.)  You should be able to change lcar, the second argument to make_geom, to get meshes of different fineness to experiment with in #690.
Are you running on scikit-fem master, i.e. with #680?  There were some substantial changes to skfem.io.meshio.from_meshio in that which I don't know have been published as a release.

Thanks for the meshing code.

Are you running on scikit-fem master, i.e. with #680? There were some substantial changes to skfem.io.meshio.from_meshio in that which I don't know have been published as a release.

Nope, right now on 3.2.0. Will try it out with master later today.

Yeah, I suspect a regression in #680.  I'll git bisect.

Can you give an example meshio.Mesh which fails without running pygmsh? E.g., save this mio object using mio.write(...).

Yes.   Insert
    mio.write(Path(__file__).with_suffix(".msh"), file_format="gmsh22", binary=False)

then
m = from_file("docs/examples/ex27_mesh.msh", out={})

gives

Triangular mesh with 2300 vertices and 4218 elements.

with subdomains and boundaries.

So it works when loading from a file?

Well yes but not necessarily the same file.  That second file was MSH 2.2 whereas Gmsh (called internally by pygmsh<7) would have generated MSH 4.1 and I didn't dare write that with meshio.

The differences to the earlier implementation are not huge, but I think the relevant detail is that the line which now fails was moved outside of the try block. I thought this part of the code cannot fail but I was proven wrong.

Again something strange going on with cell_sets it seems.

Can you give information about meshio version also? Could be important.

pip list | grep meshio says 4.4.6, but I generally pip install ~/src/meshio on some snapshot of main.  Might be b3630c2d8d7649b14d26665ca75679258b6fc483.

Aargh, I just did
cd ~/src/meshio
git checkout main
git pull upstream main
pip install .

and got hit with
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pygmsh 6.1.1 requires meshio<5,>=4, but you have meshio 5.0.0 which is incompatible.

Then retrying pip install pygmsh\<7 uninstalls meshio-5.0.0 and gives me back meshio-4.4.6.
So it looks like I have pygmsh==6.1.1 and meshio==4.4.6.
I am very unhappy about these forced movements in pygmsh and meshio.

So to avoid pygmsh, here's the equivalent GEO code:
length = 35.0;

Point(1) = {0, -1, 0, 1.0};
Point(2) = {length, -1, 0, 1.0};
Point(3) = {length, 1, 0, 1.0};
Point(4) = {-1, 1, 0, 1.0};
Point(5) = {-1, 0, 0, 1.0};
Point(6) = {0, 0, 0, 1.0};

Line(1) = {1, 2};
Line(2) = {2, 3};
Line(3) = {3, 4};
Line(4) = {4, 5};
Line(5) = {5, 6};
Line(6) = {6, 1};

Curve Loop(1) = {3, 4, 5, 6, 1, 2};
Plane Surface(1) = {1};

Physical Surface("domain", 7) = {1};

Physical Curve("outlet", 8) = {2};
Physical Curve("ceiling", 9) = {3};
Physical Curve("inlet", 10) = {4};
Physical Curve("floor", 11) = {5, 6, 1};

After installing Gmsh (e.g. pip install gmsh), run this with
gmsh -2 -clscale 0.125 -format msh41 -o bfs41.msh bfs.geo
gmsh -2 -clscale 0.125 -format msh22 -o bfs22.msh bfs.geo

to get two mesh files in formats MSH 4.1 and 22, both ASCII, with 5647 nodes.  Reduce the -clscale number to get more.
Here are the GEO and meshes:

bfs.zip

I have git-pulled and pip-installed the current meshio main (5.0.0) and then from_file(msh, []) does work with both, producing seemingly identical MeshTri1's with subdomain and boundaries.
So maybe there's nothing to worry about here?

But then with -clscale 0.2
gmsh -2 -clscale 0.2 -format msh41 -o bfs41.msh bfs.geo

to match the old example (saved in docs/examples/meshes/backward-facing_step.json with 2302 vertices), now having 2300 vertices, the IndexError is raised, even though the mesh looks O. K. and meshio is happy with it.
If this clscale is generated in MSH 2.2
gmsh -2 -clscale 0.2 -format msh22 -o bfs22.msh bfs.geo

it does work.
Further,
meshio.write("bfs41_22.msh", meshio.read("bfs41.msh"), file_format="gmsh22", binary=False)
skfem.io.meshio.from_file("bfs41_22.msh", [])

works too.
But it doesn't really work since using it in ex27 #690 diverges!

||F(u)|| = 3.687950e+00
||F(u)|| = 1.489416e+01
||F(u)|| = 1.781031e+01
||F(u)|| = 1.989103e+01
||F(u)|| = 2.295013e+01
||F(u)|| = 2.532056e+01
No convergence for initial step.
Traceback (most recent call last):
  File "/home/gdmcbain/src/scikit-fem/docs/examples/ex27.py", line 269, in <module>
    natural(bfs, bfs.make_vector(), 0.,
  File "/home/gdmcbain/miniconda3/envs/skfem/lib/python3.9/site-packages/pacopy/natural.py", line 62, in natural
    raise e
  File "/home/gdmcbain/miniconda3/envs/skfem/lib/python3.9/site-packages/pacopy/natural.py", line 52, in natural
    u, _ = newton(
  File "/home/gdmcbain/miniconda3/envs/skfem/lib/python3.9/site-packages/pacopy/newton.py", line 31, in newton
    raise NewtonConvergenceError(
pacopy.newton.NewtonConvergenceError: Newton's method didn't converge after 5 steps.

(And this is the same using pardiso or not.)
So something's not quite right, but is it my GEO, Gmsh, meshio, or scikit-fem?...  And I still can't generate new finer meshes for to test pardiso #690 on ex27.

Leaving Gmsh out of it for the moment, I tried taking the existing JSON file and putting it through to_meshio(from_meshio(...)).  This permutes the three arrays in .boundaries but doesn't that doesn't bother ex27; it converges just fine.  I don't think there's any other difference in the skfem.Mesh after the round-trip.
mesh_path = Path(__file__).with_name("backward-facing_step.json")
mesh = skfem.io.json.from_file(mesh_path)

mio = skfem.io.meshio.to_meshio(mesh)
mesh1 = skfem.io.meshio.from_meshio(mio)

for k in mesh.boundaries:
    assert not np.array_equal(
        mesh.boundaries[k], mesh1.boundaries[k]
    ) and np.array_equal(mesh.boundaries[k], np.sort(mesh1.boundaries[k]))

I've stepped through from_meshio with the MSH 4.1 file generated by the bfs.geo above and the culprit raising the IndexError at
https://github.com/kinnala/scikit-fem/blob/e4a4b2b87072ece9cd386fb83d67adff54031ff5/skfem/io/meshio.py#L93-L96
is m.cell_sets_dict["gmsh:bounding_entitles"].  This peculiar cell-set is something that was added later to the meshio MSH 4.1 reader.  I don't really know what it's for, but in this example we have 370 lines (m.cells_dict["line"].shape == (370, 2)) but there is a 371 in the culprit: m.cell_sets_dict["gmsh:bounding_entities"]["line"] is

array([  1,  -2, 178, 171, 359, 350, 365, 354, 371, 364], dtype=int32)

Hence the IndexError.

Can we just ignore any cell-set starting with "gmsh:"?  As in ff83c84.  If so, and ex27.py reads with
        self.mesh = skfem.io.meshio.from_file(Path(__file__).parent / "meshes" / "backward-facing_step.msh", [])

the example works again (and it's easier to generate meshes with different sizes, and the file is slightly smaller—;180 v. 196K for the old JSON).

Recoding the MSH 4.1 from Gmsh with skfem.Mesh.load("bfs.msh").save("bfs.vtu") is considerably smaller: 84 K.  Perhaps VTU is a good choice for examples for which we need to store the mesh statically?  It doesn't rely on optional heavy libraries like h5py like XDMF or NetCDF4 like Exodus and can be viewed in ParaView.

I'm not sure why this error didn't show up earlier.  I couldn't see anything in #680 that would have triggered it.  Maybe we were just lucky before and the spurious "gmsh:bounding_entities" were imbibed but happened not to contain invalid indices and so didn't raise the IndexError and were carried around as worthless but harmless ballast?


Equivalent for OrtOwnedTensor in ort 2.0

Hello and thank you for the ort! I noticed that OrtOwnedTensor  is no longer available in version 2.0. I searched through the migration guide here but couldn't find any information about its equivalent in the new version.
Could you please clarify what the equivalent of OrtOwnedTensor is in ort 2.0, or provide guidance on how to achieve similar functionality with the new API?
Thank you for your help!

The equivalent would be ort::Tensor.
Admittedly, the migration docs are a bit out of date, so I'd suggest also taking a look at the examples (& on 1.16 branch) to see how usage has changed.

thank you so much!


Cannot invoke Provider.autoDispose if type is specified

Describe the bug
As title implies. See minimal code to reproduce issue below.
To Reproduce
final a = StateNotifierProvider<SomeStateNotifier, String>(
  (ref) => SomeStateNotifier(''),
);
final b = StateNotifierProvider<SomeStateNotifier, String>.autoDispose(
//                                                         ^^^^^^^^^^^
// The class 'StateNotifierProvider' doesn't have a constructor named 'autoDispose'.
// Try invoking a different constructor, or define a constructor named 'autoDispose'.
  (ref) => SomeStateNotifier(''),
);
final c = StateNotifierProvider.autoDispose(
  (ref) => SomeStateNotifier(''),
);

class SomeStateNotifier extends StateNotifier<String> {
  SomeStateNotifier(super.state);
}

Expected behavior
Provider.autoDispose be able to be invoked. Didn't get a chance to thoroughly look into it but could be due to not passing the type over to here?
https://github.com/rrousselGit/riverpod/blob/6afc93ed8ef651fef18c0b27fc4f4c20d8dd23b0/packages/riverpod/lib/src/provider/base.dart#L35

final b = StateNotifierProvider.autoDispose<SomeStateNotifier, String>

Place the types after the auto dispose modifier.


Update AlignByDeviceQuery Doc

After deleting the dateTypeMapping structure in QueryPlan, the doc need to be updated too.

Hi, since the English design documents are merged, you'd better modify English version too. : )

Hi, thank you for reminding. :）


dlib training

Hello, thanks for releasing this research! Which dataset did you use to train the dlib model?

I use the official model provided by Dlib, not trained it by myself.
I recommend using FaceBoxes or other detectors, you can refer to 3DDFA_V2.

Oksay, thank you!


should fix the addition of the Shine_Dalgarno_sequence

fixes #48
this should be working now:

The bottom annotation is created from the de novo annotation.  The top one is from the loader.   Not sure why the CDS is calculated the way it is.

Looks like everything is ready.   Let me know if this works.
I don't have Anthony C's github (or I can't remember it), but add him as well.

Looks like everything is ready.   Let me know if this works.
I don't have Anthony C's github (or I can't remember it), but add him as well.

Thanks! I made the 4.2.10 release, it should land on pypi shortly


Issue 248

This PR adds

source code locations to most objects
error object with message, location, severity and subsystem
consistent compiler-style error messages (<line>:<col>: error message) for the CLI
aggregation of error messages where possible (instead of bailing out on first error)

Rebased to develop

Please add unit tests for all new code which is not yet covered.
https://codecov.io/gh/Componolit/RecordFlux/pull/285/diff

The test coverage is improved now. @treiher any other open issues with this PR?

There is on other noteworthy change in 60995f3. When making Message fail on errors in the constructor, I realized that my test for #277 was never really executed and that my fix was bogus.


Issue installing the plugin on iOS

Hi mate,
We are trying to use the plugin in an Android / iOS app and it works fantastic on Android. However, when building the app for iOS we get a weird list of link errors for JLToast. Here's a very short extract:
ld: warning: Auto-Linking supplied '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftFoundation.dylib', missing required architecture i386 in file /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftFoundation.dylib (3 slices)
ld: warning: Auto-Linking supplied '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftObjectiveC.dylib', missing required architecture i386 in file /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftObjectiveC.dylib (3 slices)
ld: warning: Auto-Linking supplied '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftDispatch.dylib', missing required architecture i386 in file /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftDispatch.dylib (3 slices)
ld: warning: Auto-Linking supplied '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftCore.dylib', missing required architecture i386 in file /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftCore.dylib (3 slices)
ld: warning: Auto-Linking supplied '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftCoreGraphics.dylib', missing required architecture i386 in file /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftCoreGraphics.dylib (3 slices)
ld: warning: Auto-Linking supplied '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftUIKit.dylib', missing required architecture i386 in file /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftUIKit.dylib (3 slices)
ld: warning: Auto-Linking supplied '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftDarwin.dylib', missing required architecture i386 in file /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftDarwin.dylib (3 slices)
ld: warning: Auto-Linking supplied '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftCoreImage.dylib', missing required architecture i386 in file /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphoneos/libswiftCoreImage.dylib (3 slices)
Undefined symbols for architecture i386:
  "Foundation._convertNSArrayToArray <A> (__ObjC.NSArray?) -> [A]", referenced from:
      function signature specialization <Arg[0] = Dead and Owned To Guaranteed> of JLToast.JLToastCenter.deviceOrientationDidChange (JLToast.JLToastCenter)(Swift.AnyObject?) -> () in JLToastCenter.o
  "Foundation._convertNSStringToString (__ObjC.NSString?) -> Swift.String", referenced from:
      @objc JLToast.JLToast.text.getter : Swift.String? in JLToast.o
      JLToast.JLToast.text.getter : Swift.String? in JLToast.o
      @objc JLToast.JLToast.text.setter : Swift.String? in JLToast.o
      @objc static JLToast.JLToast.makeText (JLToast.JLToast.Type)(Swift.String) -> JLToast.JLToast in JLToast.o
      @objc static JLToast.JLToast.makeText (JLToast.JLToast.Type)(Swift.String, duration : Swift.Double) -> JLToast.JLToast in JLToast.o
      @objc static JLToast.JLToast.makeText (JLToast.JLToast.Type)(Swift.String, delay : Swift.Double, duration : Swift.Double) -> JLToast.JLToast in JLToast.o

As you can see, it complains about fundamental things. I'm not sure what to make of it, but we are getting the same results on two completely independent systems. Maybe you can shed some light on what's wrong with our setups?
Thanks.

It seems that JLToast switched from Objective-C to Swift which produced your described errors, see ios-runtime #257. Next version drops the iOS support, because i'm not able support a third-party pod.

Actually, if you set your cocoapod to the version before he switched; you can still use it to support iOS...


I cannot add a tool to toolbar in Overlay

I cannot add other tools to the output html.
tools options is not working assuming that I am setting correctly
I also tried with specific; hover = HoverTool(tooltips=[("%",'@Percent'),("WW","@WW"),("A","@AREA")])

curve = hv.Curve(df,key_dimensions,value_dimensions).groupby(value_dimensions).overlay()
points = hv.Points(df,key_dimensions,value_dimensions).groupby(value_dimensions).overlay()

curve_points = curve * points
curve_points = curve_points.opts(
    plot=dict(
        width=1500,
        height=500,
        tools=['hover','yzoom_in'],
        toolbar='above',
        title_format="Usage by A"))

finalplot = curve_points

plot = renderer.get_plot(finalplot).state

save(plot,"Out.html",title="Out",resources= bk.resources.INLINE,logo=None)

I think there might some some bug here but first I need to figure out what you're trying to do. It looks like you are applying a groupby along the value dimensions which is not supported as far as I know. Secondly you'll likely have to apply the hover tool to the points and curve individually, since it needs to associate the tooltips with those particular plot elements.

I had issues adding/modifying the existing tools too (places I dumped .options(tools=TOOLS), but I can't seem to reproduce it with a simple example...
import holoviews as hv
import pandas as pd
import numpy as np
import parambokeh
import param

hv.extension('bokeh')

def cpd_int(p, r, t=840, n=12, c=0, cf=1, cr=0, crf=1):
    """
    Calculate compound interest
    :param p: (float) - principal or initial deposit
    :param r: (float) - annual interest rate in percent
    :param t: (int) - time in months
    :param n: (int) - number of times interest is compounded each year
    :param c: (float) - recurring contribution at the beginning of every cf
    :param cf: (int) - contribution frequency in months
    :param cr: (float) - additional contributions added every crf
    :param crf: (int) - contribution ramp frequency in months
    :return p: (float) - final amount
    """
    nom = int(1 / (n / 12))  # number of months
    r /= 100
    p_arr = np.zeros(t)

    tot_c = 0
    for i in range(t):
        if i % crf == 0:
            c += cr
        if i % cf == 0:
            p += c
            tot_c += c
        if i % nom == 0:
            p *= (1 + r / n)
            p_arr[i] = p

    tot_r = p - tot_c - p_arr[0]
    return p_arr, tot_c, tot_r

TOOLS = ['reset']
CURVE_OPTS = dict(
    width=925,
    height=500,
    color='black',
    show_grid=True,
    show_legend=False,
    default_tools=[],
    line_width=0.75,
    tools=TOOLS,
    logy=True,
)

class InterChange(hv.streams.Stream):
    Initial_savings_in_dollars = param.Number(default=1000, bounds=(0, 100000), precedence=0)
    Annual_interest_rate_in_percent = param.Number(default=1.65, bounds=(0, 10), precedence=2)
    Contributions_in_dollars = param.Number(default=0, bounds=(0., 20000.), precedence=3)
    Contribution_frequency_in_months = param.Number(default=12, bounds=(1., 240), precedence=4)
    Increasing_contributions_in_dollars = param.Number(default=0, bounds=(0., 5000.), precedence=5)
    Increasing_contribution_frequency_in_months = param.Number(default=24, bounds=(1., 240.), precedence=6)

    output = parambokeh.view.Plot()

    def view(self, audit_dt=None, *args, **kwargs):
        p_arr, tot_c, tot_r = cpd_int(
            self.Initial_savings_in_dollars,
            self.Annual_interest_rate_in_percent,
            c=self.Contributions_in_dollars,
            cf=self.Contribution_frequency_in_months,
            cr=self.Increasing_contributions_in_dollars,
            crf=self.Increasing_contribution_frequency_in_months
        )
        tot_p = p_arr[-1]
        ini_dt = pd.datetime.today()

        dts = pd.date_range(ini_dt,
                            periods=len(p_arr),
                            freq='1MS')
        df = pd.DataFrame({
            'Time': dts,
            'Savings [$]': p_arr
        })

        curve = hv.Curve(df, 'Time', 'Savings [$]')
        curve = curve.options(**CURVE_OPTS)
        curve = curve.redim.range(**{'Savings [$]': (
            self.Initial_savings_in_dollars, self.Initial_savings_in_dollars ** 2.5)})

        if audit_dt is None:
            audit_dt = ini_dt + pd.Timedelta(days=365)
        else:
            audit_dt = np.clip(audit_dt, dts[0], dts[-1])
        vline = hv.VLine(audit_dt).options(color='red', line_width=0.5)

        months_diff = int((audit_dt - ini_dt).days / 31)
        tgt_p, tgt_c, tgt_r = cpd_int(
            self.Initial_savings_in_dollars,
            self.Annual_interest_rate_in_percent,
            t=months_diff,
            c=self.Contributions_in_dollars,
            cf=self.Contribution_frequency_in_months,
            cr=self.Increasing_contributions_in_dollars,
            crf=self.Increasing_contribution_frequency_in_months
        )
        tgt_p = tgt_p[-1]

        years_diff = int(months_diff / 12)
        text = '{0} years: Total ${1:,.0f}, Interest ${2:,.0f}, Contributions ${3:,.0f}, Initial ${4:,.0f}'.format(
            years_diff, tgt_p, tgt_r, tgt_c, self.Initial_savings_in_dollars)

        return (curve.relabel(text) * vline).cols(1).options(tools=TOOLS)

    def event(self, **kwargs):
        if not self.output:
            streams = [self, hv.streams.PointerX().rename(x='audit_dt')]
            self.output = hv.DynamicMap(self.view, streams=streams).options(tools=TOOLS)
        else:
            super(InterChange, self).event(**kwargs)

interchange = InterChange(name='')
parambokeh.Widgets(interchange, callback=interchange.event, push=False,
                   on_init=True, view_position='below', width=925)

If I changed to below, it works as expected. I was trying to make it more concise.. Thx
curve = hv.Curve(df,key_dimensions,value_dimensions).groupby(value_dimensions)
curve = (curve.opts(plot=plot_options)).overlay()
points = hv.Points(df,key_dimensions,value_dimensions).groupby(value_dimensions)
points = (points.opts(plot=plot_options)).overlay()
curve_points = curve * points

now I having a problem with
grid_style = {'grid_line_color': 'black', 'grid_line_width': 10,'ygrid_line_dash':[10,10]}
.. It does not take it.
If I have only Curve or points without any overlay.. no issue.
grid_style = {'grid_line_color': 'black', 'grid_line_width': 10,'ygrid_line_dash':[10,10]}
plot_options = dict(
width=1500,
height=500,
sizing_mode='scale_width',
tools=[hover,'yzoom_in'],
toolbar='above',
title_format="L8 Usage by FA",
xticks=WWs,
yticks=percents,
gridstyle=grid_style,
legend_position='bottom_right',
show_grid= True,
fontsize={'ticks':'15pt','title':'30pt'})
curve = hv.Curve(df,key_dimensions,value_dimensions).groupby(value_dimensions)
curve = (curve.opts(plot=plot_options)).overlay()
points = hv.Points(df,key_dimensions,value_dimensions).groupby(value_dimensions)
points = (points.opts(plot=plot_options)).overlay()
curve_points = curve * points

@euacar Could you confirm your version of holoviews? I would also recommend using .options over .opts because it's less nested and performs immediate validation.

holoviews==1.10.1
bokeh==0.12.15

I changed to .options as below and got the error below and no gridstyle still. .opts does not have a problem of positioning the legend.
ValueError: Unexpected option 'legend_position' for Curve types across all extensions. No similar options found.
curve = hv.Curve(df,key_dimensions,value_dimensions).groupby(value_dimensions)
curve = (curve.options(**plot_options)).overlay()
points = hv.Points(df,key_dimensions,value_dimensions).groupby(value_dimensions)
points = (points.options(**plot_options)).overlay()

A fix for gridstyles was merged as part of 1.10.5 (see https://github.com/ioam/holoviews/pull/2765), so try updating.

thx... new version solved the gridstyle problem...


#55 Static Documentation website

What does this PR do?
It generates a static github pages documentation website for our package
Description of Task to be completed?

converts readme to static documentation
add few relevant wiki information to the website

How should this be manually tested?
In your local machine run
$ mkdocs serve

Visit http://<IP_ADDRESS>:8000/ to view the site
Any background context you want to provide?
This documentation is generated using Mkdocs.. Take a look at it for more information
Hoisted example
Express ACL Documentation

Coverage remained the same at 100.0% when pulling e695328fce82929c53c45ee9f34108ece95b5658 on docs into d07bef43fdc5ca07e135ec14b5bd8d828b7e8c98 on develop.

Coverage remained the same at 100.0% when pulling e695328fce82929c53c45ee9f34108ece95b5658 on docs into d07bef43fdc5ca07e135ec14b5bd8d828b7e8c98 on develop.


arm64: fix jump address to el2 entry when leaving el3

Summary
put el3 return address to label 2:, when executing eret instruction we will jump to that label
Impact
Testing

@pussuw please take a look


Nullabor module: create?

What do you think, @tseemann  ?

An example is Tom Connor's tutorial at
https://discourse.climb.ac.uk/t/nullarbor-tutorial-automated-bacterial-sequence-mapping-variant-calling-mlst-assignation-and-resistance-screening/32


docs: Docs for CSS components using ion-ios7* icons

From @kevinsolsol on April 17, 2015 16:32
Type: docs
Platform: all
http://ionicframework.com/docs/components/#item-icons (and more I would guess) makes reference to <i class="icon ion-ios7-telephone-outline"></i> - should have the 7 removed as this will not work with RC3 so would confuse new users

Copied from original issue: driftyco/ionic#3546

fixed


Add Pull Request Template

Describe the bug

Adding a PR template
Template path .github\pull_request_template.md

Screenshots

Additional context
GSSOC 2023

Hello @SurajPratap10
Please assign me this issue
Thank you

Hey @SurajPratap10
Please review my Pull request #215
Thank you

assigned @andoriyaprashant

@SurajPratap10 Thank you for merging my pull request with the GSSOC title. But can you please add the GSSOC level to this issue's pull request(#215) as well? Otherwise, my pull request won't count.
Thank you for your support


Create a garbage collector for OSM pod secrets

This GitHub issue is for the creation of a garbage collector for Envoy secrets created by OSM.
This will resolve #2795.
One proposal would be to launch a periodic job, which:

fetches secrets created by OSM Injector (these would have a unique label)
finds secrets without a matching Pod (unclear yet what the most efficient and reliable way to do this is)
deletes secrets from point 2

Why is this needed?
For each new Envoy, which is added to a Pod, in a namespaces added to the OSM service mesh we create a Kubernetes secret.
When the Pod is terminated (for whatever reason) the Kubernetes secret remains on the cluster. As @addozhang discussed in #2795 this causes issues. We need to run a clean-up job to scoop-up unused secrets.
There are alternative methods to passing Envoy bootstrap config and secrets, which do not require secret-per-pod:

This link for context only. We will not pursue this: [RFC] injector: Use inline Envoy bootstrap config instead of k8s Secret mounted volume #2234

I propose we:

[ ] Create a POC
[ ] Create a (very) small design doc (and link here) OR a minimal RFC PR (in lieu of a design doc - with minimal working to gather feedback)
[ ] Gather feedback
[ ] Implement

I believe adding this label to all Secrets created by the OSM Controller would make it easier to link Secret to Pod and find Secrets without Pods:

[ ] label Envoy bootstrap config Secrets with proxyUUID label #3297


Updated Dockerfile

Closes #35

Ignore the snyk tests. They're failing for everything for some reason


Update .gitlab-ci.yml

Added source query to solve the warning may allow multiple pipelines to run for a single action due to rules:when clause with no workflow:rules - read more: https://docs.gitlab.com/ee/ci/troubleshooting.html#pipeline-warnings

LGTM!


chore: update react-native-blob util for privacy manifest

This PR resolves PHIRE-734
Description

Update react native blob util to latest version with a privacy manifest.
PR Checklist

[ ] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

update react native blob util - Brian

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Dev changes (update react native blob util - Brian)

  Generated by :no_entry_sign: dangerJS against 23b5db3dfb36264c7cddf6425f7f839049bc9154


Step Functions - "Express" type

Would be nice to have a way to create "Express" type state machines.
I don't think it's implemented in Terraform though.

Correct, this appears to be tracked in https://github.com/terraform-providers/terraform-provider-aws/issues/11348

Looks like this will get released in 3.27.0 of the provider in https://github.com/hashicorp/terraform-provider-aws/pull/12249


Is it possible to update Tile name through POST?

Yes, it does appear to be possible. I will investigate.

Perfect. Thank you!

I've done some research on this one and unfortunately, I can't seem to replicate the HTTP sequence that renames the Tile in the mobile app. So, hesitant to say it can be supported at this point. I'll leave this issue open in case I (or better yet, others) can dedicate some more research to it and find a solution.


Include build-script to make use of rollup config

As there already is a rollup.config.js included in this project I expected that there would be a build-script too which makes use of this file. So far rollup is only used for the docs:build and checksize task. Including this new script would help beginners to simplify using the component later on. Throughout the docs roolup is mentioned first when talking about building your component so I think it's fair to include a step to build the component. An alternative would be to also include a webpack config and also step for that but I'd argument for rollup to keep the starter project simple

@googlebot I signed it!


Certain controller revisions wont work with Airbender.

In testing with my controllers only the CECHZCU A1 works with Airbender. Unknown reason as to why it doesn't work with Airbender but does with SCPToolkit.
Working types:
-CECHZCU A1
Non-Working types:
-CECHZCU (Fails after HID_COMMAND OUTPUT REPORT is sent)
Will add more if found!

Also worth noting that the non-a1 works with <IP_ADDRESS>......


Cannot retrieve app icon when not using public domains

Hi
Is it possible to use nativefier with my own DNS instead of Google's? I tried to run nativefier with one of my company's internal webapps, and I got this error:
Cannot automatically retrieve the app icon: Get https://xx.xx.com: dial tcp: lookup xx.xx.com on <IP_ADDRESS>:53: no such host
As it's a internal application, the URL is not in public DNS, but it is in my computer DNS (a local server).

Yeap, this is expected behaviour. It's because I'm running the bestIcon service on my Digital Ocean droplet, and the icons are retrieved from this API. Naturally the droplet would be unable to access your intranet. I plan to port the icon retrieval so that it is self-contained in the near future (when I have more time), could you try to manually add the icons with the --icon flag instead?

Yes, I saw that --icon flag. But as we have several internal applications, I was asking if there's an option to use another DNS to avoid downloading each icon manually. Don't worry, I'll do it that way until you have that free time. :)


Codeception Test Support

Added test wrappers and support for codeception
Adding test cases for the Encryption and Identity classes

Merge might be a little weird since this branched directly off of hmac-auth branch

Merged to hmac-auth branch