Modify related APIs due to addition of language field in Account

Close: https://github.com/aicers/review-web/issues/250
Among the list of tasks I needed to perform was the following items.

Modify account, insert_account, modify_account, and other related APIs in review-web as needed to support the field.
Add two new APIs in review-web: one for retrieving the user's language setting, and another for updating it.

However, after looking at the existing code, I found that the original purpose could be achieved just by modifying the existing API rather than adding new APIs, so I worked on adding language-related codes to the existing function without adding separate new APIs. But, I think there could be some misunderstanding about these task so before I open the PR to merge, I have just opened the draft PR and I ask you to review the code I worked on. @sehkone

This draft looks good to me in regard to modifying existing APIs.
In regard to your this question,

However, after looking at the existing code, I found that the original purpose could be achieved just by modifying the existing API rather than adding new APIs, so I worked on adding language-related codes to the existing function without adding separate new APIs. But, I think there could be some misunderstanding about these task so before I open the PR to merge, I have just opened the draft PR and I ask you to review the code I worked on

I think we need separate APIs because current insert_account and update_account requires the user to be SystemAdministrator or SecurityAdministrator. I think we want to allow users of any role type to retrieve and modify their language settings.

I already specified the additional APIs in the patio.

This draft looks good to me in regard to modifying existing APIs.
In regard to your this question,

However, after looking at the existing code, I found that the original purpose could be achieved just by modifying the existing API rather than adding new APIs, so I worked on adding language-related codes to the existing function without adding separate new APIs. But, I think there could be some misunderstanding about these task so before I open the PR to merge, I have just opened the draft PR and I ask you to review the code I worked on

I think we need separate APIs because current insert_account and update_account requires the user to be SystemAdministrator or SecurityAdministrator. I think we want to allow users of any role type to retrieve and modify their language settings.

I've got your point. I will create new APIs so that anyone can modify the language settings regardless of the role. @sophie-cluml

I added a function to update the user's language selection. Originally, the task description I was assigned was supposed to add two api for each of 'retrieve' and 'update', but I thought that just one function to change the language setting was enough, so I added just one api. (but I may have misunderstood the meaning of the word 'retrieve'. I understood the word in the meaning of 'recovery.' If so, please let me know with comments here.)
I think I need to write the test code on the function I modified and added, but I'm not very good at how to write the test code in this repository yet, especially with using tokio. If you have any advice, I'll refer to it and add the test code. @sehkone @sophie-cluml

@sophie-cluml @div-seungha,
I recall that this PR was originally intended to address only issue #250. However, it now also includes changes for issue #268. I believe this is not optimal. It would be more appropriate to manage the new issue in a separate PR.
PRs should be processed expeditiously. Continuing to add new features and modifications will necessitate additional discussion and feedback, which can significantly delay resolution and lead to negative consequences.
Furthermore, the initial text of this PR got modified to include this new issue. When modifying a text, any changes should be clearly visible to others. In this context, that is not easy. Therefore, if you need to modify text written earlier, it would be better to add a new comment instead of editing the existing text directly.
In conclusion, I recommend removing the additions related to issue #268 and addressing them in a separate PR.

@sophie-cluml @div-seungha,
I recall that this PR was originally intended to address only issue #250. However, it now also includes changes for issue #268. I believe this is not optimal. It would be more appropriate to manage the new issue in a separate PR.
PRs should be processed expeditiously. Continuing to add new features and modifications will necessitate additional discussion and feedback, which can significantly delay resolution and lead to negative consequences.
Furthermore, the initial text of this PR got modified to include this new issue. When modifying a text, any changes should be clearly visible to others. In this context, that is not easy. Therefore, if you need to modify text written earlier, it would be better to add a new comment instead of editing the existing text directly.
In conclusion, I recommend removing the additions related to issue #268 and addressing them in a separate PR.

I understand what you mean. I have restored the commit to the previous state and changed the current PR from Draft to ready to merge. I would appreciate it if you could check this PR as a PR to solve #250 . I will create a separate PR right away for the new API addition. @sehkone cc. @sophie-cluml

@div-seungha test code 작성에 대해 논의하기 위해 따로 미팅 요청 드리도록 하겠습니다.

@div-seungha CI fail 확인 부탁드립니다.


Validating Builders for nested nessages

This PR enables generation of validating builders for nested message types.
A validating builder class would be named after the pattern: <EnclosingType><NestedType>VBuilder
So, for example for Uri.Protocol, the Validating Builder class would be UriProtocolVBuilder.
If java_multiple_files is set to false, the outer class name would be used in the prefix of the name:
<OuterType><TopLevel><Nested><YetMoreNested>VBuilder.
Notable API changes:

MessageDocumentation was eliminated in favor of having comment-related methods under MessageType.
LocationPath now consolidates the logic of working with paths.

@armiol, @dmdashenkov, PTAL.

@armiol, once this finished, this PR in core-java should fix the broken build because of absence of version.gradle.


Running dotnet core console application fails to read input from internal debug console

Environment data
dotnet --info output:

.NET Command Line Tools (2.1.4)
Product Information:
Version:            2.1.4
Commit SHA-1 hash:  5e8add2190
Runtime Environment:
OS Name:     ubuntu
OS Version:  17.10
OS Platform: Linux
RID:         linux-x64
Base Path:   /usr/share/dotnet/sdk/2.1.4/
Microsoft .NET Core Shared Framework Host
Version  : 2.0.5
Build    : 17373eb129b3b05aa18ece963f8795d65ef8ea54

VS Code version:

1.20.0
c63189deaa8e620f650cc28792b8f5f3363f2c5b
x64

C# Extension version: 1.13.1
Steps to reproduce

Follow https://code.visualstudio.com/docs/other/dotnet
Change Main to:

Console.Write("Name: ");
var name = Console.ReadLine();
Console.WriteLine("Hello {0}!", name);

Expected  behavior
Printing Name:  in the debug console.
Waiting on  Console.ReadLine.
Printing Hello {0}! where {0} is whatever was read on the previous line.
Actual behavior
Prints this on starting debugging:
-------------------------------------------------------------------
You may only use the Microsoft .NET Core Debugger (vsdbg) with
Visual Studio Code, Visual Studio or Visual Studio for Mac software
to help you develop and test your applications.
-------------------------------------------------------------------
Loaded '/usr/share/dotnet/shared/Microsoft.NETCore.App/2.0.5/System.Private.CoreLib.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
Loaded '/home/olian04/Documents/Projects/Learning/dotnet-console/bin/Debug/netcoreapp2.0/dotnet-console.dll'. Symbols loaded.
Loaded '/usr/share/dotnet/shared/Microsoft.NETCore.App/2.0.5/System.Runtime.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
Loaded '/usr/share/dotnet/shared/Microsoft.NETCore.App/2.0.5/System.Console.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
Loaded '/usr/share/dotnet/shared/Microsoft.NETCore.App/2.0.5/System.Threading.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.
Loaded '/usr/share/dotnet/shared/Microsoft.NETCore.App/2.0.5/System.Runtime.Extensions.dll'. Skipped loading symbols. Module is optimized and the debugger option 'Just My Code' is enabled.

Then prints this on manually stopping debugging:
Name:
The program '[18836] dotnet-console.dll' has exited with code 0 (0x0).

Possible solution:
In launch.json change the default value of console from internalTerminal to externalTerminal.
Solution found through this SO question

Hi @Olian04, as you discovered, if you want to take console input, you need to use use either externalTerminal or integratedTerminal. There is a comment in the launch.json explaining it --
            // For more information about the 'console' field, see https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md#console-terminal-window
            "console": "integratedTerminal",

And here is a link to the documentation: https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md#console-terminal-window


[Hacktoberfest][Easy] Add technical Blog or your experiences about tech you worked on!

Well it's your website too!

Can i work on this lol?

I can create a blog on Debugging Tools and Technique for beginners in JavaScript

You can assign me for technical blogs :)

It’s for everyone, go for it guys!

Can we add medium links of our blogs?

Hello, @piyush97 actually I am still learning JavaScript and I don't know gatsby framework...so I don't know how to access codebase and push the blog...If you can help me with this issue. That would be very helpful :)


Extend Tran tests of her conv2d gradients to QuickCheck

This extends to QuickCheck the tests, written by @tranma. They test Tran's manual gradients of conv2d vs gradients automatically computed by horde.
QuickCheck is testing this 100 times by default. Only small random arrays of up to 2.5K elements each are used, because horde-ad is not yet optimized for the build/index coding style (but for bulk operations instead).
This group of tests is run with
cabal test shortTestForCI --enable-optimization --test-options='-p "Tests of the port of adopt code" --quickcheck-replay=3

where the last number determines the main seed and can be changed.

Let me merge before the test harness bitrots completely. We can adjust, extend the test, fix the gradients, etc., later on.


[PlaygroundLogger] Set SWIFT_INSTALL_OBJC_HEADER to NO.

The generated Objective-C header isn't used by PlaygroundLogger's clients, so this can safely be disabled.
This addresses rdar://problem/72063883.

This repo doesn't have Swift CI support, but I've tested this locally using the same Xcode tools that are used in Swift CI.


[WFLY-13161] CLIENT-CERT login does not work in intermediate elytron setup

Issue: https://issues.redhat.com/browse/WFLY-13161
Two comments:

The support for X509 evidences was added as possibly supported (if you think supported is better just let me know).
I doubted a lot between setting the credential to the final user certificate or the full chain. Finally I decided to use the first option (getFirstCertificate method) because I have checked and plain undertow/picketbox configuration just sends the client certificate (only one), so I'm doing the same. Nevertheless the BaseCertLoginModule accepts both (the test works for both options). The same, comment me if you prefer the full chain.

@darranl I'm going to ask for your review cos you already know about this issue. Change that if needed.

@darranl Remember to take a look to this PR when you have time. ;-)
I wanted your comments to go for downstream.


Same folder as original image

Hi,
Would it be possible to save the newly created thumb to the same folder as the original image ?
And while I'm here, I have another question:
How to delete the thumb when I delete the original image from for example an attachOneor attachMany relationship ?
Regards,
Alexis

I also need to delete thumbs when I delete the original image, any help would be much appreciated.
+1 saving to same folder!

The same folder cannot be used everytime, ex: theme assets.

Actually you cannot delete a single thumb generated by this plugin, you can only clear the cache at all.

If anyone would like to contribute with a deleteThumbs() method can take inspiration by the same in https://github.com/octobercms/library/blob/master/src/Database/Attach/File.php

This plugin is being migrated to core (see #55), so we are trying to figure out what issues are still relevant to invite to reopen them in core.
Issues that will remain inactive in next 30 days will be closed.


GUVNOR-2758: Collapse Empty Rules warnings into one line

This PR tries to minimize amount of warnings in Analysis Report panel by collapsing Empty Rule warnings into single line.

@jomarko When you click on an issue in the Analysis Report the offending rows are highlighted in the table. Can you please confirm the same behaviour happens with this collapsing of Analysis Report entries? I.E. if I have 2 empty rows, although only one occurrence is listed in the Analysis Report both rows are highlighted in the table?

@manstis yes it works for me in such way.

Thank-you for confirming @jomarko Let's wait for @Rikkola to approve before I merge.

@manstis sure, no problem. I discussed this change with @Rikkola this morning. So I am glad if he will do also the review.

@jomarko Like we talked in IRC. The reporting can get crowded and we should make the small list  have as few issues listed as possible. Because of this it makes sense to merge empty rule for example in one row.
Now there is one problem with merging the reports in SingleCheck. We have 3 types of Checks

SingleCheck - for one row
PairCheck - one row against other
OneToManyCheck - one row against every other row

We use the types, and rows assigned to them, to refresh the Checks. So if row 1 changes. It reruns the check SingleChecks with row 1, PairChecks with row 1 and all the OneToMany checks.
Because of this if we merge the lines in the SingleCheck. If you have 3 rows all empty. Remove the first ( or fill in the first ) and you still have rows 1-3 listed as problem lines in the other 2.
Going to write some JavaDocs for the above. Should have done that ages ago. You needed them now.
The better place for the line merge is in the report visualization. We report as detailed as possible with noise, but then visualize it in a more simple way. I would do this in AnalysisReportScreen.

@Rikkola I amended the PR. Now all EmptyRules, MissingActions and MissingConditions should be merged in the report panel.

@Rikkola according to our discussion on irc. I moved the merging logic into IssuesSet class.


chore(deps): remove memoffset dependency

offset_of! macro became stable in Rust 1.77.0 which is now within our MSRV. Remove the memoffset crate, and use std::mem::offset_of instead.

#7573  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 1, 6:39 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

Thanks for reviewing, @camc314.


Cannot understand the purpose of popToRootViewcontroller?

extension MICountryPicker {
override public func tableView(tableView: UITableView, didSelectRowAtIndexPath indexPath: NSIndexPath) {
    tableView.deselectRowAtIndexPath(indexPath, animated: true)
    let country: MICountry!
    if searchController.searchBar.isFirstResponder() {
        country = filteredList[indexPath.row]
    } else {
        country = sections[indexPath.section].countries[indexPath.row]

    }
    delegate?.countryPicker(self, didSelectCountryWithName: country.name, code: country.code)
    didSelectCountryClosure?(country.name, country.code)
    navigationController?.popToRootViewControllerAnimated(true)
}

}

I think it it should be either pop to previous or dismissviewcontroller depending upon app's behaviour

Sir are you there please resolve this issue Thanks

Will be handled from closure or delegate method starting from 0.1.7 👍


ng e2e no longer supports specifying a project name

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [x] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

node -v
v10.9.0

npm -v
6.4.1

ng -v
Angular CLI: 6.2.1
Node: 10.9.0
OS: win32 x64
Angular: 6.1.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.8.1
@angular-devkit/build-angular      0.8.1
@angular-devkit/build-ng-packagr   0.8.1
@angular-devkit/build-optimizer    0.8.1
@angular-devkit/build-webpack      0.8.1
@angular-devkit/core               0.7.4
@angular-devkit/schematics         0.7.4
@angular/cli                       6.2.1
@angular/pwa                       0.7.4
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.2.1
@schematics/angular                0.7.4
@schematics/update                 0.8.1
ng-packagr                         4.1.1
rxjs                               6.2.2
typescript                         2.9.2
webpack                            4.18.0

Repro steps

Install angular-cli 6.2.1
Create an angular workspace with three projects:

project1
project2
project2-e2e - configured with a protractor.conf.js file to run tests against project2

Try to run ng e2e project2-e2e
The cli ignores the project name parameter, and tries to find an e2e architect node in angular.json, instead of running the actual project2-e2e configuration specified in angular.json
Re-order the projects in angular.json to:

project2
project1
project2-e2e

Re-run ng e2e project2-e2e

Because project2 is first in the list, it seems to run e2e tests for that project

Run ng e2e -h and notice that  is no longer an accepted paramter, even thought the docs say that it is still valid.

$ ng e2e -h
usage: ng e2e [options]
options:
  --configuration (-c)
    Specify the configuration to use.
  --prod
    Flag to set configuration to 'production'.

Desired functionality

This seems to work fine in Angular 6.1.4:

Run ng e2e -h and notice that <project> is an accepted parameter:

$ ng e2e -h
usage: ng e2e <project> [options]
options:
  --configuration (-c)
    Specify the configuration to use.
  --prod
    Flag to set configuration to 'production'.

Mention any other details that might be useful

The issue seems to be related to this file, but I am not 100% sure about that: https://github.com/angular/angular-cli/blob/6.2.x/packages/angular/cli/commands/e2e.json

I found the same issue. I should include
"project": {
      "type": "string",
      "description": "The name of the project to serve.",
      "$default": {
        "$source": "argv",
        "index": 0
      }
    },

@byliuyang is that something we can do on our end or is it something that needs to change in the cli?  We are running into the same problem.

6.1.5 works as well, the problem starts at 6.2.0

@babeal It should ideally be changed in the CLI. I currently have a file that overrides e2e.json.

Fixed in master


When the adapter returns result to the user, it should include a reas…

…onable message if the request was unauthorized
Fixes #12

Codecov Report

Merging #17 into master will increase coverage by 0.08%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   86.45%   86.53%   +0.08%
==========================================
  Files           2        2
  Lines         251      260       +9
==========================================
+ Hits          217      225       +8
- Misses         20       22       +2
+ Partials       14       13       -1

Impacted Files
Coverage Δ

3scaleAdapter/pkg/threescale/threescale.go
77.03% <66.66%> (+0.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e72c41...937af29. Read the comment docs.


Add new qual, USE/CACHE to add "[cache]" prefix to the URL

Reported by ansley b manke on 24 Mar 2010 17:16 UTC
See section "<IP_ADDRESS> Caching" in this document
http://www.unidata.ucar.edu/software/netcdf/docs/netcdf/DAP-Support.html
talks about adding [cache] to the URL.  We should have a qualifier on USE to let the Ferret user employ this. However, no urgency on this because UNFORTUNATELY the current implementation of OPeNDAP caching in the netCDF libraries follows this strategy:
"The cache is completely purged when nc_close() is invoked."

This makes it useless for our purposes.  We never re-read the coordinates twice in the same session.  The importance of caching is to avoid re-reading the coordinates in the next session.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1730

Modified by ansley.b.manke on 5 Jan 2011 18:24 UTC

Modified by ansley.b.manke on 7 Jan 2011 23:39 UTC


Accordion's icon wrong sizing

Describe the bug
The component is not styling the incoming SVG icons, only their container. In case the user gives the SVG a size bigger than expected, the interactive area of the component increases massively.
To Reproduce
Give the icon prop an SVG icon bigger than expected (this is: > 24x24px). Then inspect it and see its area, if you hover in any part of that area you will see the bug.
Expected behaviour
Fit the container size.
Screenshots

Looks like this issue with the svg is happening in more components than expected. I will track here the affected ones and the progress:

[ ] Accordion
[ ] Select


User dropdown menu is awkwardly placed

Give container some padding away from the screen edges.

Maybe add some icons on the options while we're up there.


Add support for SECBUFFER_STREAM on DecryptMessage

This PR adds support for SECBUFFER_STREAM. See https://github.com/Devolutions/sspi-rs/issues/84 for more information.

@CBenoit Jordan was asking me about this yesterday, so maybe you can review this one first :)

@CBenoit Jordan was asking me about this yesterday, so maybe you can review this one first :)

Perfect, I was wondering which one I should review first :)


Total time not shown when doing watson report with default options

When doing watson report, with default options, the total time is not shown. Even tough, the documentation for report command shows it in a example output.

The overall total time is only shown if the report includes sub-reports for several projects. If there's only one project shown, the overall total time is equal to the total time of the project.

Closing this. Works as designed.


Consistent isolation behavior of HTTP driver.

Currently the isolation behavior of HTTP driver differs from the behavior of the DOM driver:
const main = ({DOM, HTTP}) => {
  const child = isolate(ChildComponent)({DOM, HTTP});

  const ownRequests$ = O.just(...);
  const state$ = model(...);
  const vtree$ = view(state$, child.DOM);

  const responses$ = HTTP.flatMap((r$) => ...);
  const elements$ = DOM.select('.foo').observable;

  return {
     HTTP: O.merge(ownRequests$, child.HTTP),
     DOM: vtree$,
  };
};

responses$ will contain both the requests main itself made and the requests child made.
On the other hand elements$ with only contain the the .foo elements that main itself created and not the .foo elements that the child created.
Obviously the DOM driver behaves as expected: The main component should explicitly not be able to access the .foo elements of the child.
I argue that the same should be true for responses$: It should only contain the requests that were made be main itself.
Since main needs to provide the requests to child the HTTP object should still contain all the child requests as well but still separate for example in HTTP.all.
The sources are already behaving correctly:
vtree$ contains both the child.DOM vnodes and the own vnodes of main.
O.merge(ownRequests$, child.HTTP) contains both the own requests and the child requests.
HTTP.isolateSource should build a new HTTP object like:
HTTP.isolateSource = (HTTP, scope) => {
  const newHTTP = HTTP.all.filter(exactScope(scope));
  newHTTP.all = HTTP.all.filter(exactOrChildScope(scope));

  return newHTTP;
};

So HTTP.all does not contain all requests of the application but only the one of the current component and it's children.
@whitecolor

So it is actually not so breaking, usually parent has no intentes to handle child requests.

@laszlokorte

Since main needs to provide the requests to child the HTTP object should still contain all the child requests as well but still separate for example in HTTP.all.

You mean response, not request, right?

HTTP itself is a meta stream of responses right? So it's a stream of requests. But yes response$$ to be exact.

Ok, I see how you think of it, I just call it response$$ or sources.HTTP or HTTPSource.
I'm thinking about this proposal. On one hand it doesn't differ from the DOMSource because the latter is always consumed with a .select().events(). In a theoretical sense, if you wouldn't call .select().events() on the DOMSource, you would get all possible events from the DOM. On the other hand, DOMSource.select() has isolation built in, and we don't have an equivalent for the HTTP driver.
Don't bother my bikeshedding, I'm just trying to be thorough, so can you point out a case where the current HTTP driver was unintuitive and presenting problems because of this?
One thing I try to maintain is the abstraction purity, where all read effects (for both the parent and the child) have to pass through the parent. It helps to think of a driver source as a raw resource that is passed down the hierarchy and progressively filtered as it goes down the hierarchy. It's not good if it's a magical resource which behaves differently depending on who queries it in the hierarchy.
One of the benefits of sources and sinks requiring explicit handling/routing to and from its children is the opportunity to do preprocessing and postprocessing. Think: being able to process responses at the parent level before sending them to the child. Or postprocessing a vdom$ sent by a child. The latter could be done for accomplishing overlay tutorials[1]. These kind of things I try to keep in mind.
So I'm leaning more towards the default being what it currently is, and perhaps adding a helper like sources.HTTP.own which has only response$ originated by the current component (the parent). It would also be a non-breaking change.
[1] This is something I have been wanting to demonstrate but is still a bit annoying given how virtual-dom and snabbdom vtrees work. These libraries don't provide an easy way of changing a vtree without using mutation which would create weird issues elsewhere. We would need something like React's cloning of the tree.

So I'm leaning more towards the default being what it currently is, and perhaps adding a helper like sources.HTTP.own

This is good option, in dom driver I would perefer to have something like this. Because I too see isolation it isolation from siblings, not parent, but DOM driver work another way currenlty, but maybe i'm missing something about DOM.

So I'm leaning more towards the default being what it currently is,

Couldn't agree more. HTTP driver is an idiomatic Cycle driver.

but DOM driver work another way currenlty

+1. DOM driver is an idio(ma)tic Cycle driver.
IMHO, the title of this issue should be changed to "Consistent isolation behavior of DOM driver".

+1. DOM driver is an idio(ma)tic Cycle driver.
:smile:

I agree that ultimately the current behavior of the HTTP driver is simpler and probably the desired one.
I just think that the inconsistency makes it harder to grasp the concept of isolation.
const clicks$ = DOM.select('.foo').events('click');
// is empty if the parent ITSELF has no element with class foo

You would not want receive click events on elements that you have not created your self. That's how understood the isolation requirement for the DOM driver and I think that should not be changed.
const url = new RegExp('http://foo.io/status');
HTTP.filter((r$) =>
  url.match(r$.url)
).flatMap((r$) => r$.catch(O.just("error")))
// may be not empty even if parent ITSELF did not request anything

Now I think that is an inconsistency that makes it hard to understand what exactly isolation does.
If I ask you: What does isolation is good for?
Answer A: I prevent's sibling components from messing around with each other's stuff
Answer B: I prevent's sibling components and child/parent components from messing around with each other's stuff
If A: cool, then why can a parent not access it's child elements and events?
If B: cool, then why does a parent see all the http responses of it's children by default?
Final answer: Well, the drivers can do whatever they like to do.
(which is technically correct because that's how isolateSink and isolateSource are implemented, but it does not help grasping isolation)

Ultimately I do not care too much about this as I understand your reasoning. It's just a though triggered by all this isolation discussion in the other issues. I suspect that these inconsistencies and the question what isolation actually means and what it should do and what it should not do contribute to all those "conflicts" in the other discussions.

but it does not help grasping isolation

Agreed, what I'm looking for is

a case where the current HTTP driver was unintuitive and presenting problems because of this?

And

If B: cool, then why does a parent see all the http responses of it's children by default?

Because I want to try keeping the possibility of preprocessing responses.
But I'm not giving a final answer here. I'm still thinking about it.

Maybe Shadow DOM and give some thoughts about proper isolation for cycle
http://www.html5rocks.com/en/tutorials/webcomponents/shadowdom-301/

Event Model
Some events cross the shadow boundary and some do not. In the cases where events cross the boundary, the event target is adjusted in order to maintain the encapsulation that the shadow root's upper boundary provides. That is, events are retargeted to look like they've come from the host element rather than internal elements to the Shadow DOM.

We've once contemplated that when we had custom elements, but now that everything is done with pure logic in the app code, it's not an option, not to mention the problems with SDOM's adoption in browsers. But it couldn't help with the HTTP driver, right?

Custom elements is unnesessary thing, I posted it here becase shadow DOM is too just component isolation idea. So how it works with event: events that are seen by (propagated to) parrent components, but event source (target) is isolated element itself, not target that is see within it. And in DOM driver currently parent doesn't see isolated events at all. It is related question should or not isolated events be available to parent via DOM.select().events

Downgrading this to a discussion until we reach consensus on what to do, otherwise it looks like there's an immediate task to be done.


build: split circleci

Right now Circle CI failure is misleading since it's doing two things but we only see one result. (normal building/test, running e2e tests)
This should be able to split them into separate workflows so we can put the required constraint back on the build and it should always pass, then move the less reliable e2e tests on separate workflow that may or may not fail

Hmm, seeing a bunch of "Cannot mkdir: Permission denied" errors

:tada: This PR is included in version 0.352.2 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Covering all Python versions

:tada: This PR is included in version 3.8.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Meta Mouse Cursor Mode

This feature request describes a new concept of the "meta mouse cursor mode".
In this mode, the mouse cursor doesn't interact with the UI directly anymore, but shows information about the hovered/clicked UI element and offers options to change its appearance.
The meta-mode intends to provide an intuitive and uniform way for the user to answer questions such as

What is the meaning of this UI element? What does its color mean?
Why is it shown?
How can its appearance be changed? (How to change its foreground/background color, how to hide it)

This feature could replace the "Inspect token" feature.
It could also replace various context menus to hide/show certain UI elements (such as minimap, status items, scrollbars etc.)
It would also help users to figure out how to disable unicode highlighting or bracket pair colorization.
Ideally you could use this concept to quickly change theme colors of abitrary elements.
@isidorn @digitarald @misolori might be interested in this.

I like the angle of expanding the inspect token feature. @aeschli
@digitarald @misolori what do you think about this? To me it feels like it has similarity of in-place hints which I know had previous discussions.

Loving this idea and we had similar concepts for a "theme inspector" where users are always asking what the name of a certain color token was so this would aid in this with an even larger scope.

From feature ideas this would be useful for users who customize VS Code? It feels like it could help a lot to debug context and theming issues.
@isidorn hints would be more of a guided tour than exploration via mouse hovers. This reminds me of what Edge's experimental help hover from focus mode: https://github.com/MicrosoftEdge/DevTools/blob/main/explainers/FocusMode/explainer.md

From feature ideas this would be useful for users who customize VS Code?

This, but also if you see something (e.g. bracket pair colorization or the minimap) and want to learn its meaning or just want to disable it.
It could function as interactive help.

There are so many cases where users don't the name of something so in turn they don't know how to turn it off or change it. This would greatly solve that issue and serve other purposes.

It would also be an easy way to learn the name of certain features. Could really help new extension developers.

@misolori we could start thinking about this from the design side, so once somebody on your team has time maybe we do an initial exploration. What do you think?

Sounds good, I can add this to our queue.

Maybe this can replace the Interface Overview, which hasn't aged that well:

I am interested in how we can make this simple enough to help new users, but still in-depth enough to help extension authors and theme creators. Maybe it is the same implementation, but different UI components – and extensions can also extend it?

@digitarald cool idea to replace the interface Overview.
Extensions extending it - maybe as step 2, I would not start with this to not overcomplicate the problem.


Fix Get-DbaADObject domain resolution issue

Type of Change

[x] Bug fix (non-breaking change, fixes #2861
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Fix domain resolution issue with Get-DbaADObject.
Approach

The result of the first line is passed to the second - previously, the first line's result was being assigned to $null and would cause this to throw.
$Context = New-Object System.DirectoryServices.ActiveDirectory.DirectoryContext('Domain', $Domain)
$null = [System.DirectoryServices.ActiveDirectory.Domain]::GetDomain($Context)

Commands to test

Test-DbaSpn <servername> # this would issue a warning about AD lookup failing previously

Screenshots

Learning

Thanks so much! Will merge once @niphlod reviews 👍

nm, i can see how this resolves the issue, thank you very much! 💯 🥇


How to validate input model field?

@strawberry.input
class OrderParameters():
    offerer: str
    zone: str
    order_type: int = strawberry.field(
        description="The order type, support: {}".format(OrderType.dict())
    )
    start_time: int
    end_time: int
    salt: int
    offer: List[OfferItem]
    consideration: List[ConsiderationItem]
    zone_hash: str
    total_original_consideration_items: int
    conduit_key: str
    counter: int

I have many input fields, and each field needs to be verified separately?

Hello, what kind of validation are we talking about? If it's simple validation that doesn't have to interact with your data storage/db you can use pydantic, otherwise you should check them in your code.

Probably not the most elegant solution, but I had existing Django ModelForms, so I wrote my own helper function that generates a base strawberry input from a ModelForm.  I then use that form in my mutation just like I would in a Django view function.


Add transactions for manual subscriptions in October

We have three subscriptions that manual. Add transactions in the ledger for each of those orders.

done


CHECK_FAILED / Update information fails to be queried

When i try to run the code
final upgradeInfo = await HuaweiInAppUpdate.checkForUpdate();
i will get this error
CHECK_FAILED / Update information fails to be queried
Please Help

final upgradeInfo = await HuaweiInAppUpdate.checkForUpdate();
above object of upgradeInfo I got null . check below output is the object value :
UpgradeInfo{updateAvailable: false, appId: null, appName: null, packageName: null, diffSize: null, diffDownUrl: null, diffSha2: null, sameS: null, size: null, releaseDate: null, icon: null, versionCode: null, versionName: null, oldVersionCode: null, oldVersionName: null, downUrl: null, newFeatures: null, releaseDateDesc: null, detailId: null, fullDownUrl: null, bundleSize: null, devType: null, isCompulsoryUpdate: null, isAutoUpdate: null, notRcmReason: null}
how I can correct this or any thing is missing .

@MamdRoyalWorld @humzashahid-mobile
Hi, I personally unable to reproduce the CHECK_FAILED issue. However I have added a new update with PR #8 to get more details  about the error in v1.2.0, you may try update to v1.2.0 and access the error detail through PlatformException.details. Refer Huawei Error Result Code for more details regarding the error.

Closed due to no further response.


Can't import into Archimate

I've cloned the repo but can't get a handle on anything for Archimate to open (either v5.0.1 or v5.2.0). It doesn't like any of the XML files, nor can I make the collaboration plugin read anything. Any assistance?
Background: I'm Rob Baxter, Tech Lead at DARE UK. I've been using Archimate (drawn "by hand" via diagrams.net/draw.io) to model TRE federation on the back of SATRE, other DARE UK drivers and v1.0 (Apr '23) of our original architecture blueprint. I'm really keen to see where you are with SDE modelling and how I should accomodate in my views.

Hi Rob.
Have you tried using the collaboration plugin to load the repo directly from github (rather than cloning it first)?
Collaboration->Import Model to Workspace. You can then specify the same url you would use to clone.
It should work with either http or ssh links but I've had more success with ssh: git@github.com:scwcsu/snsde-archi-model.git

Perhaps it added it to the collab workspace but didn't open it? Can you see the collab workspace - I think by default it opens to the right of the screen. Use Collaboration->Toggle Collaboration Workspace if it's not there.
Is the model listed in that view? Right click and choose Open Model if it is.

Ah! Bingo! There it is (actually, I have three copies, one for each attemp :-) ). You know, I thought I'd tried that but clearly not. Thanks for your help! I'll close the issue.


Incorrect Packaging

hello has anyone encountered this/ know what is the issue?
At the top of all my files, i typed package cs2030.simulator;  except for PQ,Pair and ImList where i typed package cs2030.util;
I have also set all my classes to be public and my code is able to compile and run in vim.
Thanks!

are your java files stores outside of the cs2030 folder?

hi i thought we are only required to submit java files to codecrunch, do we submit the entire cs2030 folder?

Should store all your java files outside of you cs2030 folder, then let package cs2030.simulator and cs2030.util create the sub-folders for you. Do make sure that the util and simulator files are put in the right folders, could be a simple spelling error

thanks everyone for the help! I realised I did not create a simulate class for each level and just used the main class itself to run


[Transaction]Add auth for PerformanceTransaction

Motivation & Modifications
Add auth for PerformanceTransaction
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[x] doc-required
Three newly added parameters need to be updated on docs.

[ ] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

Hi @momo-jun can you follow up on the doc? Thanks

Hi @momo-jun can you follow up on the doc? Thanks

Sure. Already on it.

Hi @momo-jun can you follow up on the doc? Thanks

Sure. I'm on it.


Data accessors don't add a module dependency

Code like this:
module Snapshot.Import.Open where

import Snapshot.Import.Impl

fst :: Product -> Int
fst (Product x _) = x

where Snapshot.Import.Impl defines a Product data type doesn't add an import into the BackendModule imports.
@natefaubion said:

The issue is that data constructor accessors don’t incur a dependency on the module. It’s a bit of a gray area, but it makes sense to incur the dependency.

https://github.com/aristanetworks/purescript-backend-optimizer/blob/0927ccdcdd3e1a96c922608dea6053567b45c2dc/src/PureScript/Backend/Optimizer/Analysis.purs#L351-L353
A usedDep analysis needs to be added here for GetCtorField accessors.

Seems like OpIsTag also doesn't add a dep.


fromString more than 10 digits

Example:
(IntN(64)).fromString("9999999999", false, 10).toString(10)
>>> "9999999999"
(IntN(64)).fromString("10000000000", false, 10).toString(10)
>>> "1410065408"

Not exactly sure where this is happening, but it seems that either fromString or toString is somewhere resorting to 32-bit integer arithmetic where it shouldn't (exceeding signed<PHONE_NUMBER> or unsigned<PHONE_NUMBER>).

Do we need to fix this?
I ask because the library is not in demand on npm, but it is useful... I did not find other similar libraries


Refresh CUDA 12 migrator

Recently the CUDA 11.8 migrator was closed out ( https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5340 ). As part of that it was determined a small updated was needed to the CUDA 12 migrator ( https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5340#discussion_r1441268175 ). While this largely works for most feedstocks without changes, those that have use_local: true will have issues with re-rendering until the CUDA 12 migrator they have is updated. This PR pulls over those updates to fix re-rendering on the feedstock. Please let us know if you have any other questions.

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #18.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #18

@conda-forge-admin , please re-render

This is passing! 🎉
@conda-forge/cyrsoxs this is ready for review 🙂

@conda-forge-admin , please re-render

@conda-forge-admin , please re-render

@conda-forge-admin , please re-render

@conda-forge/cyrsoxs this is ready for review! 😄

@pbeaucage would you be able to look? 🙂

@jakirkham looks great, thank you!

Thanks Dean! 🙏


Parse HTTP body for every method

Apparently this helper library is not able to receive PUT/DELETE/etc. parameters.
I solved the problem by writing this in the HttpRequest class at the bottom of the constructor:
$streamParameters = [];
// merge stream (http body) with post parameters
if (self::isJsonString($this->inputStream)){
    // json
    $streamParameters = (array)json_decode($this->inputStream);
}
elseif ($this->inputStream){
    // url params
    $streamParameters = (array)self::httpParseQuery($this->inputStream);
}
$this->postParameters = array_merge($this->postParameters, $streamParameters);

I know this is not the nicest solution, but it still supports two encodings. If you have some time, please fix it.
ModifiedRequest.zip

PR's are always welcome


[CWS] improve kernel headers download error feedback

What does this PR do?
This PR:

improves the error reporting from the kernel headers find module
add kernel header comparison fallback to "with patch=0 version", this is useful because debian is starting to distribute kernels with headers versioned with the full version (5.16.8 for example) when it only provided versions like 5.16.0 before...

I'm obviously open to find a better way of checking the downloaded kernel version. Maybe we could simply skip the check if we look at downloaded headers, since they should be downloaded based on the kernel version.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] The appropriate team/.. label has been applied, if known.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

@paulcacheux Can you clarify what has changed with the debian kernel headers? Are you saying before they didn't have the patch/sublevel version set for LINUX_VERSION_CODE? Wouldn't that have caused previous comparisons to fail?


inspiration: Add liskin/dotfiles

Copyright Assignment

[X] This document is covered by the MIT License, and I agree to contribute this PR under the terms of the license.

Checking back - this needs to have the merge conflicts resolved. Would you like me to do that, or would you prefer to do it yourself?

Done.


df output can wrap breaking the disk space checks

The output of df can wrap over multiple lines if device names are long. This breaks the disk space checks here and here.
For example
$ df -h /tmp/datastax
Filesystem            Size  Used Avail Use% Mounted on
/dev/mapper/vg_root-lv_tmp
                      6.0G  761M  4.9G  14% /tmp

The use of df's --portability option could be helpful, but it is not available on macos.

being worked on in https://github.com/datastax/diagnostic-collection/pull/111


package-lock.json references local directory for actor-helpers

As the title says, while package.json references the actor-helpers repo, the package-lock references a local version of the actor-helpers repo via a file:// url, causing an error on install.

Thanks for the report! It should now be fixed :smile:


Support for Greengenes taxonomy format

The Greengenes-style taxonomic lineage file format is widely used in microbiomics, such as QIIME 2, GTDB-tk, MetaPhlAn, etc. It would be good to let the user append taxonomic annotations of contigs by dragging and dropping a taxonomy file into the BinaRena window after the main data (e.g., the assembly files) are already loaded.
A Greengene-style file looks like this:
G000712055	k__Bacteria; p__Firmicutes; c__Clostridia; o__Clostridiales; f__Ruminococcaceae; g__Ruminococcus; s__Ruminococcus sp. HUN007
G001794515	k__Bacteria; p__Candidatus Yanofskybacteria; c__; o__; f__; g__; s__Candidatus Yanofskybacteria bacterium RIFCSPHIGHO2_02_FULL_46_19
G000257665	k__Bacteria; p__Actinobacteria; c__Actinobacteria; o__Micrococcales; f__Microbacteriaceae; g__Candidatus Aquiluna; s__Candidatus Aquiluna sp. IMCC13023
G000429005	k__Bacteria; p__Proteobacteria; c__Alphaproteobacteria; o__Sphingomonadales; f__Sphingomonadaceae; g__Novosphingobium; s__Novosphingobium acidiphilum
G000166695	k__Bacteria; p__Firmicutes; c__Clostridia; o__Thermoanaerobacterales; f__Thermoanaerobacterales Family III. Incertae Sedis; g__Caldicellulosiruptor; s__Caldicellulosiruptor kristjanssonii
G900100945	k__Bacteria; p__Bacteroidetes; c__Sphingobacteriia; o__Sphingobacteriales; f__Sphingobacteriaceae; g__Mucilaginibacter; s__Mucilaginibacter gossypii
G000717345	k__Bacteria; p__Actinobacteria; c__Actinobacteria; o__Streptomycetales; f__Streptomycetaceae; g__Streptomyces; s__Streptomyces lydicus
G001298505	k__Bacteria; p__Actinobacteria; c__Actinobacteria; o__Corynebacteriales; f__Corynebacteriaceae; g__Corynebacterium; s__Corynebacterium pseudotuberculosis
G001439295	k__Bacteria; p__Proteobacteria; c__Gammaproteobacteria; o__Cellvibrionales; f__Porticoccaceae; g__; s__SAR92 bacterium BACL16 MAG-120322-bin99
G000710465	k__Bacteria; p__Actinobacteria; c__Actinobacteria; o__Streptomycetales; f__Streptomycetaceae; g__Kitasatospora; s__Kitasatospora sp. MBT63

The goal is to automatically extract information of each of the seven ranks: kingdom, phylum, class, order, family, genus, and species, and put them into individual categorical columns.
In some instances there is domain before or in place of kingdom, and/or strain after species.
@pavia27 can comment on the adoption of this format.

@AbhinavChede Yes!


Use esbuild's support for transforming async/await to generator

Command
build
Description
AFAIK Angular CLI is using Babel plugins to transform async/await to generators for zone.js support as that transformation wasn't supported by esbuils. But support has been added https://github.com/evanw/esbuild/issues/2780, which you might be able to use to speed up the build.
This is just letting you know, as I requested that feature while playing around with zone.js for a different non Angular based project where I have hit this limitation of zone.js which the Angular CLI hides from you.
Describe the solution you'd like
Use the native esbuild transform for transforming async/awaitnto generators.
Describe alternatives you've considered
No response

Esbuild is already used to transform a async/await to generators when using the modern builds.


ubuntu22.04 vs ubuntu20.04 libjsoncpp-dev installation

I git clone the OpenCalib git to two OS ubuntu20.04 and ubuntu22.04
I noticed under ubuntu22.04, I was stucked in the installation of
sudo apt-get install libjsoncpp-dev
...
[ 50%] Building CXX object CMakeFiles/CameraCalibration.dir/src/run_intrinsic_calibration.cpp.o
[ 66%] Linking CXX static library ../lib/libCameraCalibration.a
[ 66%] Built target CameraCalibration
[ 83%] Building CXX object CMakeFiles/run_intrinsic_calibration.dir/src/run_intrinsic_calibration.cpp.o
[100%] Linking CXX executable ../bin/run_intrinsic_calibration
/usr/bin/ld: cannot find -ljsoncpp: No such file or directory
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/run_intrinsic_calibration.dir/build.make:150: ../bin/run_intrinsic_calibration] Error 1
make[1]: *** [CMakeFiles/Makefile2:111: CMakeFiles/run_intrinsic_calibration.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
Running of
mkdir -p build && cd build
cmake .. && make
was not successfull!!!
However, getting stucked for several times, I chose to reinstall my OS from ubuntu22.04 to ubuntu20.04 and the problem was solved.
Now, I am able to run
cd ./intrinsic_calib/
./bin/run_intrinsic_calibration ./data/

Write down the relevant packages installed for the succesful running of the codes

Installation of Ubuntu20.04

sudo apt install git

git clone https://github.com/PJLab-ADG/SensorsCalibration.git

sudo apt install cmake

sudo apt-get install build-essential
sudo apt-get install g++

sudo apt install libgtk2.0-dev pkg-config

sudo apt install libcanberra-gtk-module libcanberra-gtk3-module -y

Install OpenCV
# Install minimal prerequisites (Ubuntu 18.04 as reference)
sudo apt update && sudo apt install -y cmake g++ wget unzip

# Download and unpack sources
wget -O opencv.zip https://github.com/opencv/opencv/archive/4.x.zip
wget -O opencv_contrib.zip https://github.com/opencv/opencv_contrib/archive/4.x.zip
unzip opencv.zip
unzip opencv_contrib.zip

# Create build directory and switch into it
mkdir -p build && cd build

# Configure
cmake -DOPENCV_EXTRA_MODULES_PATH=../opencv_contrib-4.x/modules ../opencv-4.x

# Build
cmake --build .

#
sudo make install

sudo apt install libpcl-dev

cd ./intrinsic_calib/
./bin/run_intrinsic_calibration ./data/

ckinsung@CKS-G3-3590:~/Documents/SensorsCalibration-master/camera_intrinsic/intrinsic_calib$ ./bin/run_intrinsic_calibration ./data/
image path: ./data/
Select image 5.png
Select image 3.png
Select image 22.png
Select image 13.png
Select image 23.png
Select image 6.png
Select image 11.png
Select image 2.png
Select image 12.png
Select image 17.png
Select image 20.png
Select image 15.png
Select image 16.png
Select image 10.png
Select image 18.png
Select image 4.png
Select image 7.png
Select image 8.png
Select image 9.png
Select image 14.png
Select image 19.png
Select image 21.png
input 22 images
detected 22 images

camera intrinsic:
1057.55	0	963.605
0	1059.61	581.099
0	0	1

dist:
-0.148233, 0.095432, -0.000553691, -0.000477981, -0.0229052,

If you replace  libjsoncpp.a with ${JSONCPP_LIBRARIES} in the CMakeLists.txt file and install cppjson via
sudo apt-get install libjsoncpp-dev

it should compile without errors.


Add GPU implementation of QR factorization [wip]

Proposed changes
Add a GPU implementation of QR factorization using the blocked Householder reflection algorithm, see:
Andrew Kerr, Dan Campbell, Mark Richards, QR Decomposition on GPUs
Jan Priessnitz, GPU acceleration of matrix factorization
Here is the reference code in numpy for the algorithm.
Left todo

[x] clean up handling of batched inputs: slice the inputs/outputs and only pass the slice to the algorithm. Temporaries need only be sized for a single input matrix.
[ ] share some constants between the kernel and the driver function.
[x] consider merging the two kernels to compute W.
[ ] benchmark and optimize grid/block sizes.

Checklist
Put an x in the boxes that apply.

[ ] I have read the CONTRIBUTING document
[ ] I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have updated the necessary documentation (if needed)

@awni I tried to apply your comments and pushed https://github.com/ml-explore/mlx/pull/975/commits/501b889de904adf3b60f4b19d16b3ee46bdc5db2 to avoid creating a new command buffer for each kernel, but I get:
-[AGXG13XFamilyCommandBuffer tryCoalescingPreviousComputeCommandEncoderWithConfig:nextEncoderClass:]:1015: failed assertion `A command encoder is already encoding to this command buffer'

Did you manually make a command encoder  from the command buffer? MLX manages an active command encoder so you should not make it directly. Rather call the device.get_command_encoder() to get the active encoder.

Rather call the device.get_command_encoder() to get the active encoder.

I also tried doing that in https://github.com/ml-explore/mlx/pull/975/commits/b979ccf3e4051b99320e5d69abe138359c9f0660 which just produces the wrong result.

I also tried tracing and XCode complains about redundant bindings. Should I somehow refactor how I bind buffers to the encoder?

I fixed the code (needed to introduce one more kernel to ensure the atomics were synchronized properly across different threadgroups). It's a bit slow, so I'll try to improve it now:
  device     n  time_ms
0    cpu  2000    99.39
1    gpu  2000   283.36

@nicolov are you planning to come back to this?

I compared with Pytorch, which can use either magma or cusolver. I used a cloud machine with A100 and a desktop with a 1050 (which should be in the ballpark of my M1 Max):

magma
cusolver
cpu

1050
8.8
11.7
14.1

A100
18.2
6.3
21

The magma backend (see here) ends up calling magma_sgeqrf2_gpu(m, n, dA, ldda, tau, info) (here) which is an hybrid CPU/GPU algorithm using queues to overlap CPU compute (factorization of small submatrices) and GPU compute (transformation on the remainder of the matrix).
I'm not sure if it makes sense to implement such a hybrid in mlx, as it would require a lot of synchronization points. @awni what do you think?
Benchmark code:
import torch
a = torch.randn((1000, 1000))
a_cuda = a.to('cuda')

%timeit torch.linalg.qr(a, 'complete')

torch.backends.cuda.preferred_linalg_library('magma')
%timeit torch.linalg.qr(a_cuda, 'complete')

torch.backends.cuda.preferred_linalg_library('cusolver')
%timeit torch.linalg.qr(a_cuda, 'complete')

I'll close this PR, will re-open if I find an algorithm that's fast enough.


Revert to npm install from npm ci

Due to TravisCI issues that occur about once a week:
0.49s$ npm ci
npm ERR! Unexpected string in JSON at position 609390
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-07-25T19_59_42_628Z-debug.log
The command "npm ci" failed and exited with 1 during .

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.
[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Not production code.


feat: add Regex() matcher

Closes #113
Let me know if it's something you'd be interested in having - happy to make some tweaks if required

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm neutral about whether this feature should be added, but if it's added, I wonder if we could make these two changes:

Immediately compile the regular expression into a regexp.Regexp.
Match byte[] in addition to string. Maybe even io.RuneReader.

PS: I'm not an admin who can decide whether to merge this PR or not.

Hi @merrett010 thanks for this PR. I'm not opposed to adding this feature if others aren't.
However, I agree with both of @favonia's suggestions. While in most cases I would imagine the matcher will be used a single time - it wouldn't hurt to be on the safe side and compile the regular expression once. Matching []byte would also be a nice touch.

Thanks both for your comments. I agree @favonia's suggestions are a nice addition. Have pushed up a new commit fyi @JacobOaks

@merrett010 I tried to make some suggestions but did not figure out how to make suggested edits across multiple deletions and additions. I have figured it out and will recreate my suggestions. Sorry for the noise!

I made three suggestions:

Panic early when the the regular expression is invalid instead of silently ignore it.
Use character literals instead of character codes.
Use "matches ..." instead of "matching ...".

@favonia Thanks for reviewing, all seemed like good suggestions to me

Cheers @JacobOaks, have seen to those now


Implement automated build of docker images on github

pre-commit.ci autofix

pre-commit.ci autofix


Convert our repo to be a rust workspace

A rust workspace will allow all our rust modules/crates to have dependency management and versioning from a central point while still coe-exising with our go processes.
Again this is what we do in bpfman so that can be a good reference

Makes perfect sense since we're moving to all Rust soon. :+1:

@EandrewJones no rush at all but if you want to keep helping this is a logical good next issue :)

@EandrewJones no rush at all but if you want to keep helping this is a logical good next issue :)

I can pick this up. I started work on #50 already, but I can bracket that for now.

/assign @EandrewJones
Yeag I think #50 isn't as important, we can discuss further priorities during our meeting


add extended Theme support for Edge and Node

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)

did not find any tests. updated Storybook

[x] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
only Node specific fill Color is supported
Issue Number: N/A
What is the new behavior?
Different colors for fill, activeFill,... can be defined for each node and edge
add extended support for Node and Edge specific Theme support

added theme Property to GraphNode
added theme Property to GraphEdge
deprectated fill Property in GraphNode (Hint to node.theme.fill added)
updated Storybook to showcase extended Color Support

Does this PR introduce a breaking change?
[x] Yes
[ ] No

I would deprecated previous fill Property. If this is not intended, deprecation hints can be removed

@AnWeber - Happy to merge if you can resolve some of those items.

@AnWeber - Happy to merge if you can resolve some of those items.

@amcdnl I can gladly incorporate the comments, but I don't directly understand what I should change and how. What do you mean by mentioning You should be able to access the theme via the hook.
The change is explicitly that I can use a different theme/style per node. Access to a central theme via hook is not helpful here?

Going to close this for now given the conflicts. I'm still happy to accept this we just need to make sure the pattern follows.


Lamba Layer Release - March 2022 Update layer versions in README.md

Description:
This PR updates the README.md and changelog.md with respective versions for Python, NodeJS, Java-agent, Java-wrapper and collector layers
Documentation:
It is a documentation change

Critical changes to the architecture component of the layer names.

Thanks for the call out, committed those changes


default type parameters for type aliases, interfaces and functions

currently only classes can have default type parameters, allow default type parameters on interfaces, type aliases and functions too

@rbuckton I was sort of surprised this wasn't implemented with your other changes -- thoughts?

Default type parameters should work fine for Type Aliases, Interfaces, and Functions. See the test case. Are there specific cases where this is not working?

Specific examples:

function
interface
class
type alias

here is what i see:

supid VSCode turned out it was set up to use 2.2.1 version, ignoring tsdk parameter in settings.json
sorry for troubles


[CWS] sbom: speedup code path when the package is not there

What does this PR do?
This PR speeds up the file querier for SBOMs by adding two fast paths:

first it adds a layer of slices.Contains that will be optimized to first check if we even need to start the double for loop
second it adds a negative lookup cache, i.e. hashes that don't match any package, with 2 values in it (because of the /usr/ edge case in our query code)

The main goal of this is to speed up the case where we query a package and return nil, which is quite frequent.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


fix: adds deprecated tag to all version tags for dev-tools*

The vulnerability scanner expects just as many deprecated tags as the public image tags for it to skip scanning. Since we tag dev-tools with major, minor and patch, it requires three deprecated tags.

For a future PR: I think this tagging section is big enough now that we might want to split this into a script for maintainability


Copy grid and core packages from develop to master

This PR fixes inconsistency between master and develop branches. Dependabot was targeting master branch only and causing rolling package-lock discrepancies whenever merges were occurring between the environments.


Textbox doesn't handle accents.

Using JuliaBox:

@Carreau, is this an issue on the IPython side?

No seem to work on 3.1 (tried on try.jupyter.org)


Add Actor.prototype.fetchNearbyActorsSorted

Description

Add Actor.prototype.fetchNearbyActorsSorted.
Motivation and Context

Add Actor.prototype.fetchNearbyActorsSorted.
we can get nearby entities with a few conditions.
I wanted to use CxxVectorToArray for its returning type.
but sometimes it crashes the server.
so I changed to use toArray instead of CxxVectorToArray.
should I use just CxxVector or keep current code?
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

Checklist:

[X] My code follows the code style of this project.
[X] I have tested my changes and confirmed that they are working

if structureReturn is true. it will be constructed by the native function and it should be destructed.
so It cannot convert to the JS array without individual components. all components should be deleted before returning.

I fixed it.

It cannot convert to the JS array without copying individual components.

but, do you mean that I should not use toArray?

@mdisprgm
it will crash.
toArray() will reference components if it's the component is a class.
and those are destructed after the destructor of the vector.
it's the same with CxxVectorToArray.

I changed it to copying a new instance for each components.

Nice works.
it seems no problem.


Can only build for Python2 or Python3, but not both

Trying to follow the build instructions for Linux at https://github.com/Openwsman/openwsman/wiki/installation-of-openwsman-from-source#building-from-source
yields the following
╰─>$ cmake -DCMAKE_INSTALL_PREFIX=$HOME/local ..
-- Version 2.7.2
-- Package Version "2.7"
-- Plugin API Version "2.2"
-- Building for x86_64
-- Libraries will be installed in /home/fmil/local/lib64
-- Configuration will be installed in /home/fmil/local/etc/openwsman
CMake Error at CMakeLists.txt:119 (MESSAGE):
  Can only build for Python2 or Python3, but not both

-- Configuring incomplete, errors occurred!
See also "/home/fmil/tmp/openwsman/build/CMakeFiles/CMakeOutput.log".

Thought you might want to know.

Thanks for the reports, I'll update the docs.
I guess this happens because you have installed (the development files of) Python 2 and Python 3 in parallel.
CMake tries to make an "educated guess" which Python version to compile against by probing its environment.
You can explicitly select the Python version by adding (reverse the booleans for Python 2)
  -DBUILD_PYTHON=FALSE  -DBUILD_PYTHON3=TRUE

to the CMake call.


exception Enable multithreading to use std::thread : Operation not permitted

while running the scan_xd_api_test using the following command
./build/sick_scan_xd_api_test sick_scan_xd/launch/sick_mrs_1xxx.launch.py hostname=<IP_ADDRESS>
or
./build/sick_scan_xd_api_test ./sick_scan_xd/launch/sick_mrs_1xxx.launch hostname:=<IP_ADDRESS>
I faced the following error:
sick_scan_xd_api_test started
[Info]: sick_scan_api V. 2.9.1
[Info]: SickScanApiInitByCli: ./build/sick_scan_xd_api_test sick_scan_xd/launch/sick_mrs_1xxx.launch.py hostname=<IP_ADDRESS>
[Error]: ## ERROR SickScanApiInitByCli(): exception Enable multithreading to use std::thread: Operation not permitted
## ERROR SickScanApiInitByCli: library call SickScanApiInitByCli() failed, error code 1
## ERROR sick_scan_xd_api_test: SickScanApiInitByCli failed, error code 1

I have an MRS1104C-111011
I only built the sick_scan_xd since I am not using an LDMRS or a multiScan136 sensor.
I am running ubuntu 18.04
gcc version 7.5.0
python version 3.6.9
cmake version 3.10.2
make version 4.1
followed installation steps:
mkdir -p ./sick_scan_ws
cd ./sick_scan_ws
git clone https://github.com/SICKAG/sick_scan_xd.git

mkdir -p ./build
pushd ./build
rm -rf ./*
export ROS_VERSION=0
cmake -DROS_VERSION=0 -DLDMRS=0 -DSCANSEGMENT_XD=0 -G "Unix Makefiles" ../sick_scan_xd
make -j4
sudo make -j4 install
popd

cd sick_scan_xd/doxygen/
doxygen ./docs/Doxyfile
cd ..
cd ..

export LD_LIBRARY_PATH=.:`pwd`/build:$LD_LIBRARY_PATH  # append absolute path to build folder
./build/sick_scan_xd_api_test sick_scan_xd/launch/sick_mrs_1xxx.launch.py hostname=<IP_ADDRESS>

It seems, that there is a problem regarding pthread support. Please ensure, that pthread is installed on your system.
If possible, we recommend to upgrade to Ubuntu 20.04 or newer.
Maybe reading this discussion can also help to fix this issues on your system:
https://stackoverflow.com/questions/8649828/what-are-the-correct-link-options-to-use-stdthread-in-gcc-under-linux


Misplaced public message popup on order success page

Describe the bug
After the contribution flow, on order success page, the popup to leave a public message is not where it should be. The bug doesn't seems to appear after a page refresh, so that might be linked to client-side rendering.

To Reproduce
Steps to reproduce the behavior:

Go to /collective/donate
Complete the contribution flow
See error

Expected behavior
SSR and client-side should render the same UI. See screenshot above.

@Betree   what would be the best way to reproduce this. without actually making a real donation? lol

i am on staging and I can not reproduce this bug

Should ideally be resolved with https://github.com/opencollective/opencollective/issues/2745

@kewitz have you tested that it works before closing?

@znarf yes. I reviewed, tested and merged. I will deploy soon.

@kewitz Thank you, great to know!


[@pkg-tools/pkg-tools] The exported CLIs appear aren't portable in implementation

As part of refactoring https://github.com/dopt/please to use pkg-tools, I started by using the monolithic package (less devDeps + I planned on using all the tools).
After installing and refactoring package scripts to use the pkg-tools I was met with errors that suggest the exported CLIs (the bin) bit isn't portable -- which looking at the implementation, kinda makes sense.
My sense is that each re-exported CLI will need a js file wrapper that imports the module, to be properly portable.

Closed via https://github.com/pkg-tools/pkg-tools/pull/28


Add screenshot

Please squash these merges and add the screenshot. I'll start using GNOME Shell when I upgrade to Ubuntu 17.10 in a couple of months so I'm afraid I won't be getting shots on that for now...

Messed up adding the screenshot, will try again, this time adding Daniel's...


[Bug] SDK YAML tests fail at the commissioning step

Describe the bug
When running any SDK YAML test using the TH, the harness returns an error stating the commissioning failed and "Buffer too small" can be seen in the logs. On the DUT side, the logs indicate that the commissioning was successful.
Using the same command found in the log provided by the TH, the commissioning works fine manually.
I tried re-flashing the TH image on the RPI and the problem is still seen.
Steps to reproduce the behavior
No response
Expected behavior
No response
Log files
UI_Test_Run_2024_02_08_16_25_00.log
PICS file
No response
Screenshots
No response
Environment
Version: 2.10-beta2.2+spring2024Sha: 2432a29
Additional Information
No response

Hi @uritustefan
Can you please share three things for the investigation:

The DUT's log from the TH run
The project's configuration
The "Test Harness Doctor" output (run the ./scripts/th/th-doctor.sh repo script)

Thanks!

th_doctor_output.txt
project_configuration.txt
DUT_log.txt
Hello. I've uploaded the files you requested

Hello again @uritustefan,
First, thanks for sharing the files.
Sorry about the delay.
About the "Buffer too small" error that appears in the log, there's another issue focused on that in the following link: https://github.com/project-chip/certification-tool/issues/153
Let's see if their investigations help your problem.

Meanwhile, let me ask for your help here, since I don't have the test environment set:
One thing odd to me is that the buffer error doesn't stop the pairing process.
The last step is actually the "ThreadNetworkSetup". Made me wonder...
I saw that the project's config is the default, beside the test_parameters.
I'm assuming you're NOT using the scripts/OTBR/otbr_start.sh and TH automatically brings up the OTBR, right?
Can you try one of these two options:

Remove thread-dataset-hex completely from test_parameters (to verify if SDK YAML already has this info)
Use thread-dataset-hex = 000300000f02081111111122222222051000112233445566778899aabbccddeeff01021234 (to verify if that's the simple dataset expected from your config)

Hello. I've closed the issue as it is no longer reproducing with the latest TH from the latest SVE. We couldn't pinpoint exactly what the cause was.


Amit/roger 968 Created common role of permissions generation for nginx and marathon-server roles

Moved our temp dir creation, temp dir cleanup handler, creating user-permissions.json from google spreadsheets, creating nginx basic auth file (.htpasswd) and copying the permission files to servers all in a common role (generate-permissions-file).
This common role is depended by nginx and marathon-server and run when enable_nginx_auth and marathon_auth_enable are true respectively.
Using virtualenv to install python packages to locally generate the permissions file from google spreadsheets.
Three options are supported to copy the permissions file for either role. (From googlespreadsheets, local file passed in, or default template file)
Renamed ansible secrets variables and places they are used. Pushed updated secrets file.

@ankanm and @vmahedia Please review.

LGTM

LGTM


Introduce double_click_distance like other toolkits such as Gtk,Qt,imgui.

Not tested yet!
For details checkout my comment on cosmic-files: https://github.com/pop-os/cosmic-files/issues/575#issuecomment-2408974015
Note: asked the maintainer of iced in discord and he is fine with such a change, so this could potentially upstreamed.
Fixes https://github.com/pop-os/cosmic-files/issues/575

Tested in cosmic-files, ready for review!!


Fullscreen youtube video in modal disappears

Having a youtube video inside a modal and going full screen shows website with modal overlay. Video is gone!
Happens in Chrome but not in Firefox.
Codepen

Same problem here, can you please tell me if you find a trick ?
Thanks

Same issue here.... any fix?

+1 any solutions to this?

Same issue here, even if I include the iframe directly into the modal wrapper, removing the modal-content and the modal-footer.

+1 has there been a solution to this

+1, but looks like it's probably related to this Chromium bug

+1 I've been having this same issue, I've had to take out the fullscreen option in my videos to work around this.

+1 same issue in Chrome and Safari

+1 same issue here with Vimeo in Chrome

+1

.modal{
will-change: inherit
}

Freaking awesome, thanks Anton!

The http://codepen.io/anon/pen/KpwXwr works fine for me now in Chrome and Firefox.
Probably Youtube made some changes already.


Would you happen to have the solution for Q6 in hw1?

I've been wracking my brain at this for an hour about now, What's not clear is the hypothesis I have to compare against. From what I can tell, there's one target function that agrees for every hypothesis from 1 to 4.

Never mind.

Glad you figured it out.


md-paginator how i can get the next  or prev click event

Bug, feature request, or proposal:
What is the expected behavior?
What is the current behavior?
What are the steps to reproduce?
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U
i have this code
<md-paginator [length]="length"
          [pageSize]="pageSize"
          [pageSizeOptions]="pageSizeOptions"
          (page)="pageEvent = $event"
          (selectChange)="onPaginateChange($event)">
</md-paginator>

What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are Stack Overflow, gitter, mailing list, etc.

The page event will fire when a change occurs


Sync csc_master with upstream/master

git fetch upstream
git merge --ff-only upstream/master
git checkout -B CCCP-2844-2
git cherry-pick csc_master
git push origin CCCP-2844-2

This looks fine, but since I'm only 99% sure, repeating the question from Flowdock:
Should this get the "Rebase and merge" green button treatment? Or even some extra stuff from CLI?

Ah my bad. Rebase and merge sound right.

Now that is strange.
The "Rebase and merge" button spoke of 250 commits, but now it claims only 1 was merged? Is this now the desired state or not quite?

Hmm. We could check in a few days when there are more commits upstream if we can fast-forward in changes.

https://github.com/CSCfi/tempest/tree/csc_master said ~777 commits ahead and ~1444 commits behind. So something fishy.
I did

git branch -D csc_master
git checkout master
git checkout -B csc_master
git cherry-pick 2b50745
git push origin csc_master --force

I guess syncing repos should not be done with PRs. Sorry for that.

I guess syncing repos should not be done with PRs. Sorry for that.

I've done it once with
git remote something
git pull
git remote something
git push

And that seemed somehow clunky so honestly not sure what's the "best" way. Whatever works I guess :)


Make "rewrite" parameter mandatory and update packages

@DrMegavolt — ping please

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add technical indicators on the graph

Like:

Simple Moving Average
Exponential Moving Average

A simple moving average is implemented in https://github.com/drorata/stocks-playground/commit/c1af0a2373a75efbe16455c0080c8c8359d18c50

Closed in https://github.com/drorata/stocks-playground/commit/36e2f65aecaef50cca328a22df696455c34413d4


s3 create bucket command results in ERR_STREAM_WRITE_AFTER_END error

Noticed that from something changed in how s3 commands are handled from 3.1.4 onwards.
When using:

Serverless framework v3
@aws-sdk/client-s3 nodejs library (using aws sdk v3)
moto-server using the docker image

If I use<EMAIL_ADDRESS>or below the following works:
import { PutObjectCommand, S3Client } from '@aws-sdk/client-s3'

const s3 = new S3Client({
  region:'eu-west-1',
  endpoint: 'http://localhost:5000',
  forcePathStyle: true,
})

s3.send(new CreateBucketCommand({ Bucket: 'bucketName' }))

If I update to any version of moto released beyond that the same thing fails without any code changes being made with the following error:
Error [ERR_STREAM_WRITE_AFTER_END]: write after end
    at new NodeError (node:internal/errors:387:5)
    at ClientRequest.end (node:_http_outgoing:925:15)
    at writeBody (/Users/foo/sample-project/node_modules/@aws-sdk/node-http-handler/dist-cjs/write-request-body.js:22:21)
    at ClientRequest.<anonymous> (/Users/foo/sample-project/node_modules/@aws-sdk/node-http-handler/dist-cjs/write-request-body.js:9:13)
    at ClientRequest.emit (node:events:513:28)
    at ClientRequest.emit (node:domain:489:12)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:622:11)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
    at Socket.socketOnData (node:_http_client:521:22)
    at Socket.emit (node:events:513:28) {
  code: 'ERR_STREAM_WRITE_AFTER_END',
  '$metadata': { attempts: 1, totalRetryDelay: 0 }
}

I can't seem to find anything in the changelog or docs what would explain why this is happening, oddly enough if I replace the moto server with the latest localstack docker image it works 🤷♂.

Hi @successkrisz, thanks for raising this.
It looks like this is related to the dependencies packaged within the Docker-container. The same error occurs when running moto_server on the master-branch, with the latest version with flask==2.1.2 and werkzeug==2.1.2.
However, if I install flask==2.0.3 and werkzeug==2.0.3 (the versions used in the Moto 3.1.3 docker container), everything works fine.

Some notes on what I've found so far:

The region matters - the error does not occur when the S3Client has the parameter region:'us-east-1'
The error is due to werkzeug specifically - the flask-version does not matter
Werkzeug 2.1.0 sends a HTTP/1.1 response - 2.0.3 sends a HTTP/1.0 response

Moto-specific findings:

Moto sends a response-body, while AWS does not. Changing this behaviour does not make a difference - the error still occurs even when sending an empty body
Moto sends some extra headers that AWS does not. Changing this does not make a difference either

Considering that the error still occurs after changing Moto's response to look exactly like AWS in terms of body/headers/HTTP-version, I'm a bit stumped on what else could be the cause.

@bblommers  I have created an S3 bucket. For S3, I need to add a policy saying that if I try to upload, it should throw me an error as "access denied." I have written a sample code for it. Actually, it should throw me an error message, but I don't see anything.
policy= {
"Id": "Policy1672912478470",
"Version": "2012-10-17",
"Statement": [
{
"Sid": "Stmt1672912475646",
"Action": [
"s3:"
],
"Effect": "Deny",
"Resource": "arn:aws:s3:::harshit3bucket/",
"Principal": "*"
}
]
}
policy_string = json.dumps(policy)
file_path = 'C://Users//PycharmProjects//datbase//inputs//'
object_name = 'expectedfile.csv'

s3_client.put_bucket_policy(
    Bucket=BUCKET_NAME,
    Policy=policy_string
)
s3_client.put_bucket_policy(Bucket='harshit3bucket', Policy=json.dumps(policy))
result = s3_client.get_bucket_policy_status(Bucket='harshit3bucket')
print("rest", result['PolicyStatus'])
path_of_file = os.path.join(file_path, object_name)
res = s3_client.upload_file(path_of_file, 'harshit3bucket', 'hello.csv')
reading_content = s3_client.get_object(Bucket='harshit3bucket', Key='hello.csv')
print(reading_content["Body"].read())

Hi @GovindSkand, can you open a new issue with your question? It doesn't seem to be related to the JS SDK

Hi Spulec/Moto,
I have raised an issue(https://github.com/spulec/moto/issues/5820). Could
you please check and let me know where I am doing wrong?
Thanks and regards,
Govind.K.R
On Thu, Jan 5, 2023 at 5:47 PM Bert Blommers @.***>
wrote:

Hi @GovindSkand https://github.com/GovindSkand, can you open a new
issue with your question? It doesn't seem to be related to the JS SDK
—
Reply to this email directly, view it on GitHub
https://github.com/spulec/moto/issues/5432#issuecomment-1372145148, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5C5TDURIFLHZPOBUMEEDLDWQ23WHANCNFSM576OZIRQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I had another look at this, and I believe it is a bug in how the AWS handles 100-Continue requests.
Initially, the request only sends the headers.  This happens here:
https://github.com/aws/aws-sdk-js-v3/blob/6b4bde6f338720abf28b931f8a4506613bd64d3f/packages/node-http-handler/src/write-request-body.ts#L9
However: This particular event is invoked twice, meaning that the body is send twice. That's what the error is referring to: ERR_STREAM_WRITE_AFTER_END talks about the request, not about Moto's response.
Locally I've verified this by patching the writeRequestBody-method in the linked file, to only send the request-body once:
httpRequest.on("continue", () => {
    if (!httpRequest.already_continued) {
        writeBody(httpRequest, request.body);
        httpRequest.already_continued = true
    }
});

With this change, the test works fine.
Logging in werkzeug (i.e., MotoServer) confirms that we only send the 100-Continue once, so I don't quite understand why this event happens twice.

As a workaround: As of Moto 4.2.5, it is possible to run the MotoProxy instead. Using the following test:
import { CreateBucketCommand, S3Client } from '@aws-sdk/client-s3'
import { NodeHttpHandler } from '@aws-sdk/node-http-handler';
import ProxyAgent from 'proxy-agent';

const s3 = new S3Client({
  region:'us-east-2',
  forcePathStyle: true,

  requestHandler: new NodeHttpHandler({
        httpAgent: ProxyAgent('http://localhost:5005'),
        httpsAgent: ProxyAgent('http://localhost:5005')
    }),
})

s3.send(new CreateBucketCommand({ Bucket: 'asdfqwerasdfqwe3' }))

succeeds against the MotoProxy, without having to patch anything.
Note that this does involve setting up the required SSL certificates. The documentation has more information about this: http://docs.getmoto.org/en/latest/docs/proxy_mode.html
I configured Node by setting this environment variable:
export NODE_EXTRA_CA_CERTS=/location/to/ca.crt

Note that I don't know enough about Node to know whether that is the best way to configure proxies/SSL validation - this just happened to work.

@bblommers I see you closed this as completed. Does that mean it got fixed or just noting that it has a workaround?

Hi @maschwenk, this has not been fixed - just closed because there is a workaround and I don't believe the problem lies within Moto.


Update CONTRIBUTING.md

Update IntelliJ IDEA settings

Use the 'import settings from JAR' feature for simplicity

Add how to build and configure the project
Add the checklist based on @dongjinleekr's checklist:

https://github.com/line/armeria/pull/328#issuecomment-263481827

This is how the new CONTRIBUTING.md looks:
https://github.com/trustin/armeria/blob/contributor_guide/CONTRIBUTING.md

Current coverage is 64.90% (diff: 100%)

Merging #344 into master will decrease coverage by 0.02%

@@             master       #344   diff @@
==========================================
  Files           327        327
  Lines         13140      13140
  Methods           0          0
  Messages          0          0
  Branches       1948       1948
==========================================
- Hits           8532       8529     -3
- Misses         3698       3701     +3
  Partials        910        910

Powered by Codecov. Last update 390e91c...531a930

@dongjinleekr PTAL as well, since it's based on your proposal. Please let me know if there's something to add or change.

Few more general suggestions:

What about @Nonnull and @Nullable annotation policy? Required? Preferred but not that strict?
Might be better to leave a note about toString(). should be added and typical way to build it(toStringHelper) and levarage XXFormat for achieving human readability.

What about @Nonnull and @Nullable annotation policy? Required? Preferred but not that strict?
Might be better to leave a note about toString(). should be added and typical way to build
it(toStringHelper) and levarage XXFormat for achieving human readability.

Fixed all.

Made each checklist item a heading so that I can link it: https://github.com/trustin/armeria/blob/contributor_guide/CONTRIBUTING.md#meaningful-exception-messages

I love your organization! :) What I would like to add only is about the modifiers - Many Java programmers habitually make all methods public. How about add this sentence: "If some method is not invoked from the other class or outside of the package, make them private or remove the modifier, i.e., make them package-private (default)."

@dongjinleekr Sounds like a good idea. Updated: https://github.com/trustin/armeria/blob/contributor_guide/CONTRIBUTING.md#use-public-only-when-necessary

Use public only when necessary
The classes, methods and fields that are not meant to be used by a user should not be public. Use the most restrictive modifier wherever possible, such as private, package-local and protected, so that static analysis tools can find dead code easily.

:+1:

LGTM 👍


Addresses Issue #44 'Catalog showing image streams that aren't builder images'

Fixes #44
@spadgett

@dtaylor113 Please open a follow on PR to check all spec tags for builder. Not all image streams have a latest tag (or a latest that's tagged as a builder), so it's possible for things to be hidden entirely that shouldn't.

@spadgett I added issue #52 yesterday, and just updated it with your comment above.   I need to meet up with you at some point to understand what is required.  Especially what I need to do with 'status.tags'.  -thanks!

@dtaylor113 Sure, let me add some comments in the issue explaining.


HHH-16338 Hibernate does not classify entity as dirty if a JSON object is modified and therefore no updates are issued.

https://hibernate.atlassian.net/browse/HHH-16338
Test showing the reported issue has been fixed

Thanks @beikov


Why repo not in ublue-os organization?

The project code itself is part of the ublue-os organization (https://github.com/ublue-os/bluefin) so why not the website as well? It would simplify continuity in case e.g. you cannot maintain the website anymore for whatever reason.

Yeah the websites for the images (like Bazzite) are still under the lead maintainer's repo as opposed to ublue-os right now.  Eventually, these should be moved but it's more of a later thing.  Sorry if this was difficult to find.


disposeOnUnmount usability problem

It seems problematic that @disposeOnUnmount's effect will be disposed on unmount, but (in a property initializer) gets initialized on construction, not mount. Wouldn't this mean that if a component gets mounted, unmounted, and then mounted again, the autorun/reaction will only be active during its first lifespan? Would this be possible to address automatically or is the solution just to call it as a function in componentDidMount() instead of in a property initializer?

If you are ever planning to transition to React Hooks, have a look here...
https://mobx-react.js.org/recipes-effects

@bsmith-cycorp This is something, I didn't even think about (I'm a newbie here). I'm afraid, having to initialize the variable in componentDidMount() makes this feature mostly useless; when you do this, then you can add a disposer call to componentWillUnmount() as well. It could get more usable with
@lifecycle.autorun doSomething = () => whatever()

adding autorun(this.doSomething) and its disposer to where they belong.

if a component gets mounted, unmounted, and then mounted again

I don't think that's possible. Do you have an example when it happens?

You know, I'd been operating under the assumption that it was for a very long time, but I'm now struggling to come up with proof.

FWIW: https://reactjs.org/docs/react-component.html#componentwillunmount
Once a component instance is unmounted, it will never be mounted again.


added missing functionality to cratedialect

Add missing dialect attributes from initialize method.
Add tests for the same.

Coverage increased (+0.05%) to 95.98% when pulling 27f3eb41c7974f6313e069380e543ffed8477a93 on spanky/113 into ab0f35b184a8b0f28cbc803d23391292efa034b0 on master.

changes are missing, otherwise ack

Coverage decreased (-1.27%) to 94.66% when pulling 070626182ca4b541365a16b412ddfc17c9db2d80 on spanky/113 into ab0f35b184a8b0f28cbc803d23391292efa034b0 on master.

Coverage decreased (-0.07%) to 95.86% when pulling 070626182ca4b541365a16b412ddfc17c9db2d80 on spanky/113 into ab0f35b184a8b0f28cbc803d23391292efa034b0 on master.

Coverage increased (+0.05%) to 95.98% when pulling 0a4e3e87ecbdbb34e170161db3201fa754df4912 on spanky/113 into ab0f35b184a8b0f28cbc803d23391292efa034b0 on master.


Adding documentation for Request Options

Clarifying how to add HeaderOption and QueryOption onto requests, from
issue #17

@mimisasouvanh Could you take a look?


Build and deploy

Supersedes #31
Resolves #6
Thanks for all your help @jasonpet!

add a default route so that ansible deploy can make sure the app is running
automatically create the Cloudant table if it doesn't yet exist
log to file

Depends on #33 - we shouldn't really start deploying this until we have the two feed actions we know we will need.

This also needs proper annotations for the feed actions.

@dubeejw When you are finished with #33, please provide annotations here for the two feed actions.

@jasonpet I see some of the other services are making use of a DB_PREFIX property. Can you explain the significance of that, and whether we should make use of it when creating our own db?

@bjustin-ibm, here are the annotations.
kafkaFeed.js
-a description 'Feed to list to Kafka messages' \
-a parameters '[ {"name":"brokers", "required":true, "description": "Array of Kafka brokers"}, {"name":"topic", "required":true, "description": "Topic to subscribe to"}, {"name":"isJSONData", "required":false, "description": "Attempt to parse messages as JSON"}, {"name":"endpoint", "required":true, "description": "Address to OpenWhisk deployment"}]' \
-a sampleInput '{"brokers":"[\"<IP_ADDRESS>:9093\"]", "topic":"mytopic", "isJSONData":false, "endpoint": "owkafkafeedprovider.mybluemix.net"}'

messageHubFeed.js
 -a description 'Feed to list to Message Hub messages' \
 -a parameters '[ {"name":"kafka_brokers_sasl", "required":true, "description": "Array of Message Hub brokers"},{"name":"username", "required":true, "description": "Message Hub username"},{"name":"password", "required":true, "description": "Message Hub password"},{"name":"topic", "required":true, "description": "Topic to subscribe to"},{"name":"isJSONData", "required":false, "description": "Attempt to parse messages as JSON"},{"name":"endpoint", "required":true, "description": "Address to OpenWhisk deployment"}]' \
 -a sampleInput '{"kafka_brokers_sasl":"[\"kafka01-prod01.messagehub.services.us-south.bluemix.net:9093\"]", "username":"someUsername", "password":"somePassword", "topic":"mytopic", "isJSONData":false, "endpoint":"owkafkafeedprovider.mybluemix.net"}'

@bjustin-ibm - sorry, just noticed your db_prefix question.  This is used to prefix the trigger database name with username_host.  You should be doing this as well.  If you have multiple whisk environments sharing a cloudant account you will want each using a unique name for the trigger database.  I know many our Jenkins build environments do use a shared cloudant account.

Great, thanks @jasonpet.

@jasonpet and @dubeejw please review.

LGTM

@bjustin-ibm, I see the build scripts here, but not the deploy scripts. I am assuming we will be using Ansible for the deployment, which will essentially execute a Docker run command.

Never mind, Jason explained it to me.

@jasonpet Please review (again). We'd like to get this merged today, if possible.

LGTM.  The docker.gradle file (distdocker support) is no longer necessary since we no longer build in ansible and just deploy image from dockerhub.  However, it won't hurt to leave it in case we need it in future or for users to build local docker image.


update copyright year from 2023 to 2024 in all relevant files

@erichorwath : i have run the "Make generate" command. https://github.com/SAP/dns-masquerading-operator/pull/95/commits/9cdecd9a664a61f27daa2da7c459846635acaf8f


Retry getConfig

This was also failing with ECONNRESET

Pull Request Test Coverage Report for Build 406978158

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 41.522%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/jupyter/serverInstance.ts
4
73.81%

Totals

Change from base Build 406945109:
-0.01%

Covered Lines:
22055

Relevant Lines:
48743

💛  - Coveralls


Create an API for responding to changes in network interfaces

I just noticed this TODO item in the README.
I have code for both Linux (using an AF_NETLINK socket) and Windows (using NotifyAddrChange) to do this, and I'd love to merge it in, but the external API is an open question.
My current use-case needs to receive change events, but also cancel these events on program exit. To do this, my notifiers spawn threads, send change messages via a crossbeam channel, and have custom Drop impls that wake up a side-channel to cancel the thread.
Async could work here, but async rust scares me a little 😅. Do you have any preferences on what the API should look like?

IMO blocking API is a good starting point.


Adding Echo for Lemmy client

You need to edit template.md and not the read me which is edited automatically, see previous addition.

@wiki-me Done. Thanks!