K_THREAD_STACK_EXTERN() confuses gen_kobject_list.py

Describe the bug
If a C file is built that has an extern declaration of a thread stack, before the actual declaration of the thread stack, the kernel object detection mechanism will fail to register the stack object and system calls on it (such as k_thread_create()) will fail:
0x00423000 is not a valid _k_thread_stack_element
syscall z_hdlr_k_thread_create failed check: bad stack object
***** Kernel OOPS! *****
Current thread ID = 0x00401ae0
eax: 0x00000000, ebx: 0x00000000, ecx: 0x00000000, edx: 0x00000000
esi: 0x00000000, edi: 0x00000000, ebp: 0x00000000, esp: 0x00428f98
eflags: 0x00000246 cs: 0x002b
call trace:
eip: 0x00002fb0
NULL base ptr
Fatal fault in thread 0x00401ae0! Aborting.

This could happen commonly if a header file has the extern declaration, and the C file which defines the thread stack object includes it.
Only seems to affect thread stacks, other kernel object types work fine if an extern declaration is present. Probably has something to do with how gen_kobject_list.py handles arrays.
This also affects K_THREAD_STACK_ARRAY_DEFINE.
To Reproduce
Build an application with CONFIG_USERSPACE enabled with the following code snippet:
K_THREAD_STACK_EXTERN(ustack);
K_THREAD_STACK_DEFINE(ustack, STACK_SIZE);

If you build with VERBOSE=1, the output of gen_kobject_list.py will not show it.
If you then comment out the K_THREAD_STACK_EXTERN() line, it will be detected:
gen_kobject_list.py: symbol 'ustack' at 0x423000 contains 1 object(s)
Similar behavior with K_THREAD_STACK_ARRAY_DEFINE, please make sure both are fixed.
extern k_thread_stack_t
	tstacks[MAX_NUM_THREAD][K_THREAD_STACK_LEN(STACK_SIZE)];
K_THREAD_STACK_ARRAY_DEFINE(tstacks, MAX_NUM_THREAD, STACK_SIZE);

I found this when making adjustments to tests/kernel/sched/schedule_api to run some tests in user mode.
Expected behavior
gen_kobject_list.py should not disregard thread stacks which have an extern declaration in the same compilation unit.
Impact
major annoyance, possible to work around. will greatly confuse users who don't know about this bug.
please backport to 1.14
Environment (please complete the following information):
Seen on qemu_x86, probably affects all userspace arches

@wentongwu can you take a look at this one? This would be a good opportunity to learn more about how gen_kobject_list.py works.

@wentongwu can you take a look at this one? This would be a good opportunity to learn more about how gen_kobject_list.py wo

sorry, mis-click.
yes, I'm checking this issue. Thanks

will add analysis for DW_TAG_typedef to fix this issue.

not only DW_TAG_typedef doesn't been considered, but also handle "extern type variable[]" incorrectly.


[fix][broker] Invalidate metadata children cache after key deleted

This fixes #13489
This fixes #14779

Motivation

There is a chance if a topic reassign to a broker that owned this topic once, consumer reconnect will failure with BadVersionException, here's detail: https://github.com/apache/pulsar/issues/14779#issuecomment-1554473113
Reproduce steps:

a topic deleted in broker1
recreate the topic in broker2, start a consumer with it
broker crash or bundle split, topic reassign to broker1, by now consumer will reconnect failure

Modifications
Cleanup metadata children cache if managed-ledger key deleted
Verifying this change

[x] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[x] doc-not-needed

Matching PR in forked repository
PR in forked repository: https://github.com/Shawyeok/pulsar/pull/7

/pulsarbot rerun-failure-checks

Besides, I remember that ZK cannot remove recursively at a batch but iterating from children to parent. How the cache won't be invalidated by its children getting deleted?
Anyway, invalidate cache eagerly won't introduce correctness issue.

Besides, I remember that ZK cannot remove recursively at a batch but iterating from children to parent. How the cache won't be invalidated by its children getting deleted?
Anyway, invalidate cache eagerly won't introduce correctness issue.

In the scenario described in https://github.com/apache/pulsar/issues/14779#issuecomment-1554473113, node1 does not have a watcher associated with the newly created znode cursor. As a result, the mechanism to invalidate the parent key children cache does not work.

Codecov Report

Merging #20363 (4e9086f) into master (1e664b7) will increase coverage by 36.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master   #20363       +/-   ##
=============================================
+ Coverage     36.93%   72.95%   +36.01%
- Complexity    12032    31889    +19857
=============================================
  Files          1687     1864      +177
  Lines        128761   138403     +9642
  Branches      14002    15185     +1183
=============================================
+ Hits          47553   100965    +53412
+ Misses        74932    29427    -45505
- Partials       6276     8011     +1735

Flag
Coverage Δ

inttests
24.17% <100.00%> (-0.16%)
:arrow_down:

systests
24.90% <100.00%> (-0.10%)
:arrow_down:

unittests
72.22% <100.00%> (+40.28%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...he/pulsar/metadata/impl/AbstractMetadataStore.java
85.38% <100.00%> (+32.67%)
:arrow_up:

... and 1430 files with indirect coverage changes

I'd appreciate it if you can provide a znode view of execution steps to demonstrate the exception.

Try me break down into two steps to explain how this error could be produced in #14779:

When topic back to node1, it will only initialize the managed-ledger without initializing any cursors, due to cache consistency
pseudo call stack:

MetaStore#getCursor
ManagedLedgerImpl#initializeCursors
MetaStore#asyncUpdateLedgerIds
ManagedLedgerImpl#asyncCreateLedger
ManagedLedgerImpl#initializeBookKeeper
MetaStore#getManagedLedgerInfo
ManagedLedgerImpl#initialize

https://github.com/apache/pulsar/blob/1e664b7f550ffa28d3c810f3b7d6d625d5905eb3/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L570-L572

When a consumer reconnects to node1, the broker only checks if the cursor has been loaded into memory
https://github.com/apache/pulsar/blob/1e664b7f550ffa28d3c810f3b7d6d625d5905eb3/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L981-L982

pseudo call stack:
AbstractMetadataStore#put
MetaStore#asyncUpdateCursorInfo
ManagedCursorImpl#persistPositionMetaStore
ManagedCursorImpl#switchToNewLedger
ManagedCursorImpl#createNewMetadataLedger
ManagedCursorImpl#initialize
ManagedLedger#asyncOpenCursor
PersistentTopic#getDurableSubscription
PersistentTopic#internalSubscribe
PersistentTopic#subscribe
ServerCnx#handleSubscribe

BTW, broker will try create a cursor znode which already exists in zk, so it'll receive NODEEXISTS.
Here's NODEEXISTS how to be handled, a BADVERSION:
https://github.com/apache/pulsar/blob/3f2978d32223d61f04db1de330f5b167a63925ae/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java#L244-L246
In summary, this is how I observed the occurrence of BadVersionException.

After a discussion with @Shawyeok I learned that it's about two broker node that:

Broker 1 has cache for topic znode.
Broker 1 switches to a different topic, delete the topic znode but forget to clear the children cache.
Broker 2 create the topic znode and cursor child znode
Broker 1 switches back to the original topic. It doesn't set watches or perform put cursor znode by itself so the child cache is still empty (not uninit).

Merging...
Thanks for your contribution and detailed investigation @Shawyeok!

@Shawyeok Could you add a test for this patch?

@Shawyeok Could you add a test for this patch?

Sure, I'll do it later.

As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label


Rename getStarted to setup

Renaming to match what we show the user

can't wait to fix the merge conflicts.


Attempting to "Create Azure Arc Data Controller" give account error

Hi,
I get the following error in the "Create Azure Arc Data Controller" Wizard. Step 1.
ADS Insiders Build 1.27.0
Azure Arc Extension 0.9.0
Error: Error fetching subscriptions for account Eric Burgess -<EMAIL_ADDRESS>tenant 105bXXXX-XXXX-XXXX-XXXX-24d304d195dc : Token retrieval failed with an error. Open developer tools to view the error
Error: Error fetching subscriptions for account Eric Burgess -<EMAIL_ADDRESS>tenant 72f9XXXX-XXXX-XXXX-XXXX-2d7cd011db47 : Token retrieval failed with an error. Open developer tools to view the error.
While this error was happening I was unable to select the drop down to pick a valid subscription. Hence the Wizard wouldn't work.
Error: Error fetching subscriptions for account Eric Burgess -<EMAIL_ADDRESS>tenant XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXX : Token retrieval failed with an error. Open developer tools to view the error	at c:\Users\EricBu\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\azurecore\dist\extension.js:16:18559	at processTicksAndRejections (internal/process/task_queues.js:94:5)	at async Promise.all (index 0)	at async Object.t.getSubscriptions (c:\Users\EricBu\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\azurecore\dist\extension.js:16:18283)	at async j (c:\Users\EricBu\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\resource-deployment\dist\main.js:1:46128)	at async t (c:\Users\EricBu\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\resource-deployment\dist\main.js:1:38716)	at async Timeout._onTimeout (c:\Users\EricBu\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\resource-deployment\dist\main.js:1:39057) (at c:\Users\EricBu\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\azurecore\dist\extension.js:16:18653)
I get around the error, by removing my account from ADS, and adding back the same Azure account.
I was able to deploy the Arc Data Controller.
MAR2021BUGBASH

Issues with the security tokens for Azure accounts are a known issue - see https://github.com/microsoft/azuredatastudio/issues/12165 - so I'm going to close this as a dupe of that (and also since it's not specifically an Arc issue)


Update search-indexer-howto-access-private.md

API Management not supported yet

@mrcarter8
Can you review the proposed changes? Note that the validation warning must be resolved before this PR can be merged.
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#please-close  This is a duplicate of #123781


Improve communication for 'set selection'

When setting the selection, communicaiton box says: "The selection area has to overlap with the 'location'."
--> what does this mean? The location is not visible, how do people know? Isn't it set once at the beginning, but not every time a user opens it? This needs clarification!

See also #3.


UI Enhancement : Can we add a info message in Your Farms and Farm Finder for farm details

Which package/s are you suggesting this feature for?
No response
Is your feature request related to a problem? Please describe
Can we add a info message in Your Farms and Farm Finder so user know he can get more farm details by clicking on the farm.

Describe the solution you'd like
we can add a alert or info message like this:

Work completed:
Added the alert to both pages.

verified on devnet
version : db2daf4
alert added to both pages


Add to "Override Using" helpMarkDown

This is to address feedback from Taylor.  I intend to update the MSDN docs separately.  @madhurig is the language correct?

@DavidStaheli: Thanks for the change, wording looks good. I left one small comment. Should we apply the same to Xcode task?


End PoC of Network Problem Detector

What this PR does / why we need it:
End PoC of Network Problem Detector. It is production ready and should be documented as such.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Release note:

/lgtm


CDAP-14619 use objects instead of JsonObject and JsonArray

Use proper java objects for the service endpoints instead of
manually manipulating json for many endpoints.
This makes the code much easier to understand and maintain.

KafkaService and Explorer are not using JsonObject anymore. DirectiveService I'm saving for later because I couldn't easily figure out what their responses are, since they merge json objects and stuff like that.
I'll do SchemaRegistryService if we touch it, I'm not sure where it's being used.


Turning on/off for users

Hello! I tried making an overlay myself but that ran into the ground under the TOS of Twitch. Anyways, I was wondering if if you use this during your stream, will it show up for anyone? and can they turn it off somehow? @iiiklox

Hello!
Are you referring to Twitch stream extensions? In which case no, unfortunately. This is a client-side overlay so what you see is what you get, no toggles for viewers.
Although, I did some digging and I found this Twitch extension. This is a viewer-sided chat overlay that seems to have the functionality you’re looking for. I haven’t used it before, though!

Yeah unfortunately that is broken right now, so I went on a journey to remake the extension from scratch, knowing nothing about twitch extensions. I ended up recreating it successfully... only to find out that it breaks TOS apparently. I'd need permission from every user before I can 'publish' what they typed, show their username, as well as have the broadcaster have the ability to moderate every single message before displaying it. Your project looks really cool though!

Can you do me a favor? Join this channel https://discord.gg/YaVMeywA and talk to the host? He wants to use this but he's not on github, so he's got some questions about customization.


Update to 2.7.7 causes compile errors

Bumping the dependency from 2.7.6 to 2.7.7 causes the following error message in our build which uses go 1.19:
Error: /home/runner/go/pkg/mod/github.com/sijms/go-ora/v2@v2.7.7/utils.go:559:8: value.SetZero undefined (type reflect.Value has no field or method SetZero)

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5336076619/jobs/9670223260#step:5:40824

Yep, the issue is here: https://github.com/sijms/go-ora/blob/v2.7.7/v2/utils.go#L559
Note that SetZero method of reflect.Value was not added until Go 1.20 (see: https://pkg.go.dev/reflect#Value.SetZero)
Either go-ora needs to set the minimum Go version to 1.20 in https://github.com/sijms/go-ora/blob/master/v2/go.mod, or find another way to implement the functionality added by SetZero.

I replace value.SetZero() with value.Set(reflect.Zero(value.Type())) in new release


Increase test coverage

Codecov Report

Merging #222 (6eb7f0b) into master (0cf977a) will increase coverage by 0.74%.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##             master     #222      +/-   ##
============================================
+ Coverage     47.58%   48.33%   +0.74%
- Complexity      629      643      +14
============================================
  Files           133      133
  Lines          2940     2940
  Branches        390      390
============================================
+ Hits           1399     1421      +22
+ Misses         1407     1377      -30
- Partials        134      142       +8

Impacted Files
Coverage Δ

...in/java/seedu/address/model/tag/UniqueTagList.java
53.84% <0.00%> (+30.76%)
:arrow_up:

...a/seedu/address/model/person/UniquePersonList.java
84.00% <100.00%> (ø)

src/main/java/seedu/address/model/tag/Tag.java
73.33% <0.00%> (+20.00%)
:arrow_up:

...ess/model/tag/exceptions/TagNotFoundException.java
100.00% <0.00%> (+100.00%)
:arrow_up:

...ss/model/tag/exceptions/DuplicateTagException.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf977a...6eb7f0b. Read the comment docs.


Implement preferred location from server

Fixes issue #7.

Current coverage is 5.29% (diff: 0.00%)

Merging #13 into dev will decrease coverage by 0.10%

@@               dev       #13   diff @@
========================================
  Files           86        86
  Lines         3262      3326    +64
  Methods          0         0
  Messages         0         0
  Branches       326       333     +7
========================================
  Hits           176       176
- Misses        3076      3140    +64
  Partials        10        10

Powered by Codecov. Last update 4cb2ed0...d5b59f4


docs(news blog): add new blog entry for refinement day 1 in R25.03

Description
This PR add a new entry in our Blog section to announce and provide some guidance for refinement day 1. The links for the team's session are still missing. Will be added later.

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[X] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[X] Copyright and license header are present on all affected files

The links for the breakout sessions are only examples and we are still sending or creating the correct ones, aren't we? :)

The links for the breakout sessions are only examples and we are still sending or creating the correct ones, aren't we? :)

yes, have just to find out how to do that ;)

The links for the breakout sessions are only examples and we are still sending or creating the correct ones, aren't we? :)

yes, have just to find out how to do that ;)

ah perfect :) 👍


Exchange: GEMINI

{
  "name": "gemini",
  "docurl": "https://docs.gemini.com/websocket-api/#market-data",
  "wssurl": "wss://api.gemini.com/v1/marketdata/:symbol",
  "pairs": "BTCUSD, LTCUSD, LTCBTC, ETHUSD, ETHBTC, ETCUSD, ETCBTC, BFXUSD, BFXBTC, RRTUSD, RRTBTC, ZECUSD, ZECBTC",
  "active": "N"
}

Will integrate this exchange following same rule as earlier one and see what pattern emerges. Hopefully can start to refactor code relating to redis and transformation of data as well as the command line 'calling'

Found the record related to trade
xxxxxxxxx 0 { type: 'trade',
tid:<PHONE_NUMBER>,
price: '12889.87',
amount: '0.00960975',
makerSide: 'ask' }
xxxxxxxxx 1 { type: 'change',
side: 'ask',
price: '12889.87',
remaining: '0.99039025',
delta: '-0.00960975',
reason: 'trade' }
I cannot seem to tell whether its a buy or a sell though.

"A trade does not occur unless a buyer meets the ask or a seller meets the bid.
Read more: What do the bid and ask prices represent on a stock quote? | Investopedia https://www.investopedia.com/ask/answers/042215/what-do-bid-and-ask-prices-represent-stock-quote.asp#ixzz52n9RKDHI
Follow us: Investopedia on Facebook

Refactoring functions into separate file enough for now; will do more refactoring in next exchange development


Server process terminates suddenly since 0.1.122

Since docker.io/eidolonai/sdk_base:0.1.122 the server process just terminates after starting
eidolon@ec7e20f56032:/app/resources$ eidolon-server --disable-metrics DISBABLE_METRICS --fail-on-bad-agent false  -p 3001 .
INFO:     Started server process [166]
INFO:     Waiting for application startup.
INFO - Building machine 'DEFAULT'

No errors or anything.
The same behaviour is on K8s and Docker standalone.
I tested the versions up to 0.1.121 and they work, all version 0.1.122 <= 0.1.125 produce that probably wrong behaviour.

thanks @anoner0815
Was this one of our example repos? Or if it was a custom repository / branch could share that with us to reproduce the issue?

I was in the eidelon-git-search repo using just the Dockerfile and patching the EIDOLON_VERSION arg before building the image

Ok, this is strange. eidolon-git-search works just fine for me, but when experimenting setting up azure I ran into the same issue. so I have a repro now.
Elevating and grabbing this since it is a pretty bad

I could reproduce this erroneous behaviour using poetry run eidolon-server . on eidolon-repo.
After checkout out a6c10cb3 (tag 0.1.121) the server stays up and running. Possibly an issue with WSL2?

System:

Ubuntu 22.04 in WSL2
Local user
Workspace is local, no mounted Win folder
Python 3.10.12
Poetry (version 1.8.3)


FP Loops and Dart

Given #29, how do I implement loops in a functional way?
I've been stumped on this for a while and since the functional programming sect of Dart seems to be small, I've yet to find any answers that have been relevant to my Flutter app. From my understanding, the lack of tail recursion optimisation means that the using recursive functions in general (especially for large datasets or small stacks on constrained devices) has a chance of making my app misbehave or perform poorly.
Here's a small example of a loop I'd like to get rid of (it's riddle with side effects).
    while (cacheSize > maxSize) {
      final fileSize = await _deleteOldestFile();
      cacheSize = cacheSize - fileSize;
    }

P.S. Sorry if this is the wrong place for this.

Hi @TheOnlyNurse
The performance of a recursive function may vary based on the specific implementation of the method you use.
The most suitable way I see to convert your code example to functional is to use a recursive call. I do not know if there may be another more performant solution.
I am going to close the issue since it is not related to fpdart. Feel free to comment if you have any other doubt.

Thanks for your time @SandroMaglione, I appreciate it


CB-18222: Added ability to collect salt highstate execution metrics and generate json report from them

Added getSaltExecutionMetrics method to SshJClientActions, with which you can collect the salt highstate execution metrics in E2E test cases.
The collected metrics are sent back to the machine running CB from the salt master instance, and a json report is generated. The report contains data about:

the instances a specific highstate affected
which states ran on a specific instance
how long a state took to run
what salt functions were called during the application of a salt state (e.g. file.managed, cmd.run, etc.)
details about specific function runs, such as duration, start time, return code, etc.

The generated reports could be collected as artifacts in the E2E test runs and be used to, for example, to identify salt states that took unusually long to complete.
(This PR contains code for tasks CB-18222 and CB-18341)

For a future improvement: We can create a separate Java class for the Salt related SSH Client Action, as a refactor for a better organised and manageable Salt related functionalities here.

I added a new class called SshSaltExecutionMetricsActions for this feature.
@aszegedi

This was a very promptly accomplished future enhancement :star_struck: Thank you!


Add turf.js and JSTS example

This PR adds two examples showing the integration with turf.js and JSTS.
@bjornharrtell I saw that there is a jsts.io.olParser class, but I couldn't find an up-to-date build online that I could use in the example.

Thanks for the heads up @tsauerwein, I've made the 0.16.0 release available at:
https://cdn.rawgit.com/bjornharrtell/jsts/gh-pages/lib/0.16.0/javascript.util.min.js
https://cdn.rawgit.com/bjornharrtell/jsts/gh-pages/lib/0.16.0/jsts.min.js

Thanks @bjornharrtell! I updated the example with olparser.

Very cool! Please merge.

Thanks for doing this @tsauerwein :)


Expanded filename's date sort functionality

Added postFilenameDateFormat and postFilenameDateCaptures for user to be able to process post files with time in the filename, that way posts created on same day can be sorted in a correct and desired order
New regex looks for the date at the beginning of the line and supports both 2016-01 and 2016-01-01 as well as 2016-01-01_2130

Thank you for the suggestion! Closed because of version 2.0 release. Feel free to resubmit under v2 if it's still relevant.


Practical Application?

Hi! I'm very interested in your project, I'm currently working on an open source project that should be able to interpolate the face (with expression) in video frames of person a into something that looks more like person b.
What I have so far:
Dataset Generation

Extracting frames from many youtube videos of person a or person b
Running facial recognition and alignment to save every training usable region of interest with the correct people into personA and personB folders

Translation Utility

Provide low fps video of person a, for each frame extract the region of interest (face)
Run it through some kind of image translation (I would like to use your project for that)
Then save the result back into the original region of interest. (possibly add color correction, etc of modified roi with pix2pix)

What I want to use your project for:
Image Translation
personA->personB conversion (or at least a high similarity, like in the male->female projects) of regions of interest in individual videoframes
What I don't understand
How to use your project for this purpose ;) Can you point me in a direction, so that I can set up your project for this specific application?

I want to do the similar purpose of imageA->imageB.
At these GANs project, they always use random noise to generate image, but I want an imageA to generate a NEW image with some relation, just like a label.
Do anyone have some ideas about it ?


A zigzagging check for morphologies

This check is implemented for the following issue:
https://bbpteam.epfl.ch/project/issues/browse/SCIMORPH-9
The algorithm checks if the endpoint of a segment lies within or close to another segment upstream.
Firstly, it checks that the distance of the projection of the vector from the center of the other segments to the endpoint of the running one is smaller than the half length of that segment plus a 5% tolerance to take into account exact overlaps.
Secondly, the orthogonal complement of the projection must be smaller or equal than the sum of the maximum radius of each segment pair.
Zero segments are ignored.

Current coverage is 100.00%

Merging #267 into master will not affect coverage as of 533933d

@@            master    #267   diff @@
======================================
  Files           42      42
  Stmts         1753    1795    +42
  Branches         0       0
  Methods
======================================
+ Hit           1753    1795    +42
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 533933d

Powered by Codecov. Updated on successful CI builds.

In the end, I did not use the distance of line to point that I added and tested in morphmath, because I calculated the distance from the complement vector of the projection, which was much faster. However, I kept the function in morphmath, because it might come handy. I can remove it if you think that it is unnecessary .

Is this really zigzagging? From the description in the link, it sounds like a section turns back on itself.

Well, to be honest I had no idea how to name it... :P
You are right, a segment turns back to a previous one.

Maybe "back-track"?


regression temporary remove test case 'tpch q21' until we fix it

Proposed changes
Issue Number: close #xxx
Problem summary
NPE thrown when we run regression test tpc-h q21 on Nereids
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

duplicate pr，close it


Script not running (php)

I followed everything, downloaded and extracted the php script, put the token data into a token.txt file, moved it into the right folder and renamed the php download into php.zip which I also copied into the right folder. Getting me an error along the lines of "system can't find path".
After un-zipping the php.zip manually and again running the bat file I'm now getting this:

Update your powershell. Download link here https://www.microsoft.com/en-us/download/details.aspx?id=54616
After you update it, extract cheat files to new folder and run cheat.bat

Try to put the folder directly on the C:\ path

@Martan404 That didn't help
@VladTheImpaller I'm on Win7 Pro. After updating from version 2 to version 5.1 the script now works. Thanks for the info.


Released Flutter web app missing LICENSE asset

Steps to Reproduce

Run flutter build web.
Run npx serve in build/web folder
Open localhost url in browser.

Expected results:
/build/web
  assets
    AssetManifest.json
    FontManifest.json
    LICENSE
    fonts
      MaterialIcons-Regular.ttf
      <other font files>
    <image files>
  index.html
  main.dart.js
  main.dart.js.map

This is the expected files and folders after compile as found in https://flutter.dev/docs/deployment/web#building-the-app-for-release
Actual results:

This is the result I get after running compiled Flutter web app.

Logs

True for current beta 1.19.0-4.3.pre and master 1.20.0-3.0.pre.130.
But the NOTICES file is generated in assets

@VladyslavBondarenko  Correct me if i’m wrong. What I understand from your explanation is that LICENSE file won’t be generated into the assets anymore and instead replaced with NOTICES file. If so, why does the app still looked for LICENSE file from the asset?

@eleazargan
I can't see that app is looking for LICENSE file

Could you provide your flutter doctor -v?

@VladyslavBondarenko  Here's the result from flutter doctor -v on my device. I'm not developing for mobile app so I reckon I would not need Xcode and Android toolchain.

Using the setup of Flutter version that I have, I've created a new app just to make sure it is not because of the issue with the current app that I am working on. It still happened even in a new and freshly created app. The example above is run with flutter run -d chrome --release

@eleazargan
I see this now, when running with beta and when doing regular refresh (not hard reload).
But I can't see this when running with dev or master. Can you confirm that LICENSE in not looked for with other flutter versions?

Related to https://github.com/flutter/flutter/pull/57871

@VladyslavBondarenko
Yep. Building the app with master seem to have solved the issue. Also, the issue does not appear when building with beta version 1.7.5. However, once I upgraded to 1.19.0-4.3.pre on beta, the issue persist.

I would like to also get a clear understanding on whether this piece of information from the Flutter documentation website is still relevant.

Has Flutter web support past the development period?
Can we safely use master or stable channel to build our Flutter for web app?

@jonahwilliams Could this be due to existing apps picking up the old file? Is there a migration guide for the rename (if necessary)?

The aggregate LICENSE file is being renamed to NOTICES. If the flutter_service_worker.js was generated incorrectly it will contain an entry for "assets/LICENSE" instead of ""assets/NOTICES" - but updating the former to the latter will fix it (at least until you build the next time).
Sorry for the trouble here, I missed the rename working through all the other platforms so the web service worker was updated later: https://github.com/flutter/flutter/pull/58890

Could this be due to existing apps picking up the old file?

No, its just a regular bug

Duplicate of https://github.com/flutter/flutter/issues/57904

@jonahwilliams should this be closed? Was it fixed with https://github.com/flutter/flutter/pull/58890?

Yes, also the website has been updated with https://github.com/flutter/website/pull/4325


DataPrepModule noisy if wires are not created

As reported in vdcoldbox issue 1 DataPrepModule is very noisy if no wires are produced. There does not appear to be an option to turn off wire building there. This should be added.

I am modifying the module not to build wires if the wire container name (WireName) is empty.

I think this was done.


Refactor config

check

-1 Removing .config from A10Config will require everything that looks in config for something to have foll-blown a10-config support for it. This isn't bad for anything in a10-neutron-lbaas, but it's bad for extensions like a10-openstack that don't have a way to modify what a10-neutron-lbaas's A10Config class does.

@Cedev, umm, yes, not seeing .config is the entire point.  a10-openstack should be instantiating an A10Config() object, which can access the get methods. It's to make the per provider config transparent to the higher-level code.

Actually the order in this pull is:
A10_CONFIG_DIR
config_dir
venv
legacy
/etc/a10

:+1:


Custom Copilot Power BI: User Info

Hi there!
I´m looking for a way to get User Information on Power BI Custom Report.
I need to create a list of users that are using CoPilots.
I could not find user information on dataverse side. Any Ideas?
Thanks in Advance!

What is the channel where your users access your copilot? (created by Copilot Studio)
Do users authenticate via your copilot?

I don't think this is possible out of the box indeed, but perhaps you could log an event activity with the values and gather this in Power BI. This will be challenging as well, because I don't think you can log an event for every new session.


Build-Args Flag

#81

Please use for of instead of map. You should only use map when you're returning something.

Thanks guys


Example CSV

An example CSV for driving the bulk processing tool would be a useful addition to the repo.

For NHM testing and evaluation I will reference examples in our Data Portal.
NB: specimen persistent URL example: https://data.nhm.ac.uk/object/e94e5adc-6394-4bb5-9683-289fe349c8a6
image persistent URL example: https://data.nhm.ac.uk/media/6b2e3631-387e-4162-8960-8e75fc34709d
/object/ is specimens, /media/ is images
https://data.nhm.ac.uk/media/6b2e3631-387e-4162-8960-8e75fc34709d is also the base URL for IIIF access to that image too, so you can do: https://data.nhm.ac.uk/media/6b2e3631-387e-4162-8960-8e75fc34709d/info.json & https://data.nhm.ac.uk/media/6b2e3631-387e-4162-8960-8e75fc34709d/full/512,/0/default.jpg etc

Two examples to be getting on with:
PinnedInsect-SingleRow-Example.csv
PinnedInsect-TenRow-Example.csv
Will create a larger example and need to add examples for herbarium sheets and microscope slides.


[Model Deprecation]: SerialPart 2.0.0

Update Reason
Since the existing SerialPart was adapted and a new version (#557) will be available soon, the current version SerialPart 2.0.0 must be set deprecated!
MS1 Criteria

[ ] The model that should be deprecated exists and is not deprecated already
[ ] The respective model does not affect existing use cases (aspect is either used in higher versions or replaced by a different aspect)
[ ] A shared aspect, which will be deprecated, is not used by any released aspect model

FYI @jacewski-bosch @jonbckr @BenediktMuellerIML

modeling_team


CommutationTransformation is not a valid pass

The CommutationTransformation does not preserves the semantic of the DAG. I do think that the commutative DAG is useful for some transformation and we should have some form of support for it. However, this is probably a discussion for another time.
Suggested solutions
I think, for now, the direct solution is to remove this pass. In the near future a commutative DAG can be storage in the property set. We owe a discussion if the main DAG should be a commutative DAG. Please, dump your thoughts about it in #1914.

I think it's fine to remove it, as the CommutationAnalysis pass is the main pass used for optimizations. The CommutationTransformation pass is not used. If we end up creating a new DependencyGraph structure, then a pass like this will be useful.

closed via https://github.com/Qiskit/qiskit-terra/pull/1956


[HOLD for #32413][$500] Expense report title is too far away from avatar in page header

HELD on https://github.com/Expensify/App/issues/32413

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1701391579217569
Action Performed:
Go to an expense report
Expected Result:
The expense report title and small subtext (From...) should be just 12px away from the room avatar
Actual Result:
The expense report title and small subtext (From...) are too far to the right of the avatar in the page header compared to other chats (DMs, rooms, etc)
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01420f85f91e69170f
Upwork Job ID:<PHONE_NUMBER>183658496
Last Price Increase: 2023-12-03
Automatic offers:

situchan | Contributor | 28014682

Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense report title is too far away from avatar in page header
What is the root cause of that problem?
https://github.com/Expensify/App/blob/1682be47d71b5a84c20c2396e833c0a015829252/src/components/AvatarWithDisplayName.js#L135
What changes do you think we should make in order to solve the problem?
need to update like this
<View style={[styles.flex1, styles.flexColumn]} />

This seems to be fixed when I apply https://github.com/Expensify/App/issues/32413#issuecomment-1837561113

Please re-state the problem that we are trying to solve in this issue.
Expense report title is too far away from avatar in page header
What is the root cause of that problem?
shouldShowSubscriptAvatar && !isExpenseRequest ? styles.ml4 : {}
when the condition is true the style which is ml4: Sets the margin-left to 16 units.
What changes do you think we should make in order to solve the problem?
ml0: Sets the margin-left to 0 units.
ml1: Sets the margin-left to 4 units.
ml2: Sets the margin-left to 8 units.
ml3: Sets the margin-left to 12 units.
ml4: Sets the margin-left to 16 units.
If you want to set the expense report title and small subtext (From...) should be just 12px away from the room avatar.
then we have to use 'styles.ml3'.
but I want to suggest you should use 'styles.ml1' which sets right margin
Image:

@johncschuster could you reassign the C+ here, I have more priority task on my plate right now

I can take this

@situchan, I've assigned you the C+ role, but Melvin tagged you for the contributor. Just making a note in case Melvin doesn't correctly assign the contributor down the line.

@mkhutornyi's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

@situchan Can you please put this on hold for https://github.com/Expensify/App/issues/32413

@shubham1206agra will there be any conflict?

Actually this seems to be fixed with that issue too as a side effect

Actually this seems to be fixed with that issue too as a side effect

Alright let's hold this and wait for that fix to go out. Then just verify that this issue is also fixed.

PR is out: https://github.com/Expensify/App/pull/33042

@greg-schroeder I'm OOO starting Monday, December 18 (today) through Tuesday, January 2.
Current status:
We've just put this issue on hold to see if https://github.com/Expensify/App/pull/33042 resolves it.
If this issue is open when I'm back from OOO, I'll take it back over. Thank you!

Linked PR is going through final reviews

Deployed to staging

PR is deployed in v1.4.15-5 and it's looking good:

This should be all set


Remove version: Vromans.ChordPro version 0.977

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: Package still available.;


Sonoff DW2 Wifi unavailable on HA restart

On Home Assistant restart the sensor is unavailable until you open the door/window

Startup log says its off line but it is not:
2020-12-22 16:45:18  DEBUG    main          1001037f52 == Init   | {'uiid': 102, 'extra': {'manufacturer': 'SONOFF', 'model': 'DW2', 'sw_version': 'OPL-DMA-GL v1000.2.924'}, 'params': {'rssi': -91, 'actionTime': '2020-12-22T16:43:25.330Z', 'fwVersion': '1000.2.924', 'battery': 3.111, 'type': 3, 'chipID': 'd0270206fbf4', 'mac': 'xxxxxxxxxxxx', 'switch': 'off', 'lastUpdateTime': '2020-12-22T16:43:25.330Z', 'cloud': 'offline'}}

As far as the README points out this is normal, as the DW2 device is a cloud only device. See documentation here - https://github.com/AlexxIT/SonoffLAN#common-problems-in-only-lan-mode under section "Devices unavailable after reboot"

Hi Yes I had read that Thanks. I have found it does connects after about 40min.


IRC Channel bridge

Can be done on a "main" and "-offtopic" channel, not sure about the demand though

can this be closed as the bridge is now operational?

can this be closed as the bridge is now operational?

yeah I think so, just add issues/pull requests for config / mt-mods-infra repo to connect channels and change other things.


fix nightly-run

Nighty runs are failing:
https://app.circleci.com/pipelines/github/OpenLineage/OpenLineage/11475/workflows/ce4f5cc1-712b-4b2f-a7ef-a0b5519c4648
The cause looks to be related to an incorrect parameter usage.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.52%. Comparing base (caecf5f) to head (c175b9a).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2862   +/-   ##
=======================================
  Coverage   85.52%   85.52%
=======================================
  Files          58       58
  Lines        3413     3413
=======================================
  Hits         2919     2919
  Misses        494      494

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Drone 0.4.0

merge this into master and delete all other branches restructing / cleaning up  swarm

LGTM!


The code says to import only from/2

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


feat: Add code to pass manifest_file _path and user agent.

please remove all dev changes, including debug prints and changes to package.json.
you can override from vscode settings.json if you want to change server base for testing. no need to change in package.json

Codecov Report

Merging #497 (c9abc55) into master (e11ebf9) will decrease coverage by 0.91%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
- Coverage   60.43%   59.51%   -0.92%
==========================================
  Files          18       18
  Lines         829      830       +1
  Branches      169      169
==========================================
- Hits          501      494       -7
- Misses        328      336       +8

Impacted Files
Coverage Δ

src/authextension.ts
44.11% <100.00%> (+1.69%)
:arrow_up:

src/multimanifestmodule.ts
46.26% <0.00%> (-5.98%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a0a8d...c9abc55. Read the comment docs.


Ajs

https://github.com/prankbots/prankself/commit/3b9e0226312ebc6dcaaaa8f4c0afe3f783acb63b#r42753384

https://github.com/prankbots/prankself/commit/3b9e0226312ebc6dcaaaa8f4c0afe3f783acb63b#r42753384


Things about Graph Classfication

What can I do to achieve graph classfication? I know it can be done to add pooling layer and softmax, and change loss function, etc.
The question is, now the model's input is like one graph, I have no idea that whether I need to change the model' input or architecture.
Thanks for your time.

Hello,
Thank you for reaching out about EGAT. I appreciate your interest in this topic.
While I have some experience with GNNs, my focus has primarily been on node-level regression tasks rather than graph-level tasks. As such, I may not be the best resource for your specific inquiry.
However, I can suggest a couple of GitHub repositories that compile papers on GNNs, which you might find helpful:

thunlp/GNNPapers: Must-read papers on graph neural networks (GNN)
https://github.com/thunlp/GNNPapers

TrustAGI-Lab/Awesome-Graph-Neural-Networks: Paper Lists for Graph Neural Networks
https://github.com/TrustAGI-Lab/Awesome-Graph-Neural-Networks

Please note that these repositories haven't been updated recently, so the literature may not be current. However, they could still provide a good starting point for your research.
If you have any specific questions about the work in this repository, please feel free to ask, and I'll do my best to assist you.

Thanks for your reply.


Discovery: URL encoding of discovery form data can exceed URL length limit

It is possible for facet GET queries to exceed the 4096 character URI length limit. Should use method POST.

New Discover uses POST and RESTful API calls


Log spam and stuttering if logged into facebook without internet connection

We are using the Facebook Unity and Parse .NET SDKs in our mobile app, developed in Unity for Android and iOS.
To reproduce:

Login to Facebook (using ParseFacebookUtils.LogInAsync)
Close app
Disable internet connection
Open app

User is still 'logged in', but the apps framerate drops drastically until internet is enabled, and constantly spams out this in the android logs (using a Samsung Galaxy s6):
I/System.out(1430): (HTTPLog)-Static: isSBSettingEnabled false
Logging out of Facebook doesn't help either, seems to happen in old versions of the app too.
None of this happens in the Facebook sample app, only when Parse is involved.

Just been informed this is only happening on Android, iOS is unaffected.

Thanks for providing some basic steps to reproduce. If we eventually start going over the possibility of tests for Unity on Android I'll see if we need to add something to guard against this.

I close this issue as the FacebookUtil class no longer exists and login support using other auth methods is, afaik, not longer specifically implemented anymore.
If this issue arises with the latest version of the SDK and any third-party auth method feel free create a new ticket to discuss possible solutions.


fix_utf8 method on string in Russian returns "???????"

What is this feature about (expected vs actual behaviour)?
fix_utf8 method on string in Russian returns "???????"
How can I reproduce it?
echo UTF8::fix_utf8("строка на русском");

Thanks for the bug-report. I have fixed the bug in "UTF8::utf8_decode()" in version 3.1.29
-> The problem
I tried to adapt the naming of the methods from the php-core, so e.g. we can use "UTF8::strpos($haystack, $needle, $offset = 0)" for "strpos($haystack, $needle, $offset = 0)"
But sometimes this was not the best idea... so the name of "utf8_decode()" is really bad, because it is more like a "utf8_to_iso_8859_1()" function, but so in the code it looks like it can handle utf8-strings. :/
-> The solution
Now we will check if  "UTF8::utf8_decode()" fixed iso-encoding problems and otherwise we will keep the utf8-string. (but only if the second parameter is "true")


Update grammar rules to handle quoteless module names

This is a quick implementation of my suggested change to the grammar rules.
These are now valid import statements.
load system io.
load system io
load io.
load io

@SupurCalvinHiggins Thank you for your contribution!  Welcome to the Asteroid project!


Controller integration testing RFC - WIP

This is similar to the pattern we follow for testing commands in the CLI. Which it should because the CLI tests are modeled after the Knative reconciler tests. The main difference is that the trigger is a reconciliation key rather than a cli invocation and in our case, the client interface is different since we're building on controller-runtime.
See: https://github.com/projectriff/cli/blob/master/pkg/testing/command_table.go
Usage: https://github.com/projectriff/cli/blob/master/pkg/build/commands/function_create_test.go#L282-L1103

As discussed on projectriff.slack.com, I am overall a bit skeptical about the matrix approach for testing, as the number of attributes of the test cases seem to grow over time to a point where it sometimes becomes hard to understand which attribute to use or not for a particular situation.
Moreover, the context is spread between the custom test runner and the relevant test case one is interested in. It may be difficult to understand a test case without first understanding what the custom test runner does.
It is also not possible to improve a particular matrix test case. Structural changes apply to all of them.
In my opinion, “traditional” tests offer a greater flexibility, with a smaller learning curve (I assume most developers are familiar with given-when-then structures + before/after hooks).
Maybe there is some solution to be found in the middle, i.e. standard enough so that we do not duplicate code for common tasks and flexible enough to allow local one-off variations without surfacing these subtleties to the general "framework".

@fbiville The table approach seems to be working out quite well so far in that the test framework seems to be reusable across controllers. If we had to add features to the framework for particular controllers, that would be more of a concern.
My main concern about the table approach was that introducing minor variations on existing "rows" would result in a lot of duplication between rows, but that is being avoided by using helper functions to avoid excessive duplication. For example, @scothis has introduced a nice collection of helper functions for constructing certain common objects, in pkg/controllers/testing/factories.
I share your concern about the table approach being a little impenetrable for newcomers, but I think that's mitigated by using the same test framework across all the controller tests. Also, I think the table tests are pretty easy to read once you've grokked the general design of reconcilers (admittedly a bit of a hurdle for newcomers). I think using non-table tests wouldn't really help much as there is a lot of machinery associated with testing controllers and non-table tests would be more likely to diverge from each other in the use of such machinery.


Clarify that custom highlights are case-sensitive

There are currently no clarification whether the keywords are case-sensitive or not

Should they be case-sensitive?

I would say the code should be modified to make them case-insensitive.

Yeah, this is definitely a bug with the code, they shouldn't be case-sensitive. I just didn't thin kabout that.


[Feature Request] See attachments from all ancestor work items

We often add attachments to anywhere in the hierarchy of epic/feature/pbi/task work item hierarchy. It would be very useful to be able to see attachments from all ancestor work items, not just the immediate parent.
Thanks for creating this extension! 👍

such feature will help us too


How to view real-time last price data in Python

How to view last price data (using websockets) in Python? I wasn't able to find any python websocket examples here: https://github.com/kroitor/ccxt/tree/master/examples/py
The library looks fantastic btw, great stuff

Hi!
Thx for your feedback!
According to the Manual:

Full public and private HTTP REST APIs for all exchanges are implemented. WebSocket and FIX implementations in JavaScript, PHP, Python and other languages coming soon.

Streaming is a very wanted feature, of course. We have announced the work on WebSocket support already) We will update you when this is available, in the meantime I'm closing this issue as a duplicate. Hope to deliver this September. Stay tuned )


Add the cloud-utils-growpart package to the cloud-init package list.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
[x] Ready to merge

Summary

cloud-utils-growpart is necessary for container host scenarios where the image is distributed with minimal free diskspace but then it is expected to expand on deployment. The expansion is powered by cloud-utils-growpart which enables cloud-init to grow the partitions on the first boot.
This change added the cloud-utils-growpart package to the cloud-init list since it's almost always that we want both to be installed together.
Change Log

Add cloud-utils-growpart of the cloud-init package list to allow for automatic expansion.

Does this affect the toolchain?

NO
Associated issues

7613: cloud-init in azl 2.0 baremetal image fails to grow the root partition

Links to CVEs

No

Test Methodology

Build baremetal image locally.
Using qemu-img, converted the vhdx to qcow2, and resize the disk.
Created a VM and attached cloud-init data.
Booted the image and verified that the root partition has been expanded.

We won't increate the disk-size since the test is unblocked by added a data disk. For customers, they need the real fix: cloud-init-growpart works with selinux.


GH-43483: [Java][C++] Support more CsvFragmentScanOptions in JNI call

Rationale for this change

Support more CSV fragment scan options
What changes are included in this PR?

Implement nearly all cpp code supported CsvFragmentScanOptions
Are these changes tested?
Yes, new added test and exists UT.

Are there any user-facing changes?
No.

GitHub Issue: #28866
GitHub Issue: #43483

Sorry, can we make a new issue instead of reusing a closed one?

@jinchengchenghh there is a checkstyle error in one of the CIs, could you please try mvn spotless:apply and see if it can be fixed? Not sure why is it only occurring in one CI though :thinking:

@jinchengchenghh Overall LGTM!, I will review once tomorrow.


Updated default tag to latest stable version.

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

@tjacobhi Could you follow https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md to fix the CI error? If the breaking change is expected, you can comment about it.

@tjacobhi Could you follow https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md to fix the CI error? If the breaking change is expected, you can comment about it.

Thanks, I'll fix the CI errors. The breaking change is expected. We were previously requiring read-only properties in requests bodies, but not giving them in responses. This was incorrect behavior and failed checks by the ARM team. ARM Reviewers have stated that these changes are needed and have signed off on them.

/azp run automation - sdk

@akning-ms Could you help to merge it?

@akning-ms ping - can you help merge this asap.


add engbert microsaccades event detection

this implements #3

PR #109 needs to be merged before this

I have added very very basic tests.
We will decide on how to test event detection methods after the warsaw meeting.


No syntax highlighting under very specific circumstances

Environment data
dotnet --info output:
.NET Core SDK (reflecting any global.json):
 Version:   2.1.500
 Commit:    b68b931422

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.14
 OS Platform: Darwin
 RID:         osx.10.14-x64
 Base Path:   /usr/local/share/dotnet/sdk/2.1.500/

Host (useful for support):
  Version: 2.1.6
  Commit:  3f4f8eebd8

.NET Core SDKs installed:
  2.1.500 [/usr/local/share/dotnet/sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.6 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.6 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.6 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

VS Code version: 1.29.1
C# Extension version: 1.17.1
Steps to reproduce
Input the following into VSCode into a .cs file:
namespace SomeNamespace
{
	class Test
	{
		void Init()
		{
			Something.listener = async args => { return true; };
		}

		void ThisFunctionHasNoSyntaxHighlighting()
		{
			var aString = "test";
		}

		void ButThisOneIsFine()
		{
			var aString = "test";
		}
	}
}

(it looks like GitHub's highlighting has the same issue)
Expected  behavior
The second function should be syntax highlighted. Both the return and true keywords should also be highlighted in the delegate assigned in the first function.
Actual behavior
The things mentioned above should be highlighted since it's all valid C#. The return true highlighting issue seems to be independent but maybe related to the function highlighting issue. Here's a screenshot in my editor:

There are many things that fix the second function's highlighting, such as:

Adding parens around args in the delegate in the first function (this also fixes the return true highlighting)
Removing the async keyword in the delegate
Removing the namespace

Ported to https://github.com/dotnet/csharp-tmLanguage/issues/142


[site-support-request] video.nationalgeographic.com

D:\youtube-dl>Waiting for file handle to be closed ...
Updated youtube-dl to version 2014.09.19.

D:\youtube-dl>youtube-dl.exe --verbose http://video.nationalgeographic.com/video/smallpox-sci
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'http://video.nationalgeographic.com/video/smallpox-sci']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2014.09.19
[debug] Python version 2.7.8 - Windows-7-6.1.7601-SP1
[debug] Proxy map: {}
[generic] smallpox-sci: Requesting header
WARNING: Falling back on generic information extractor.
[generic] smallpox-sci: Downloading webpage
[generic] smallpox-sci: Extracting information
ERROR: Unsupported URL: http://video.nationalgeographic.com/video/smallpox-sci; please report this issue on https://yt-dl.org/bug . Be sure to call yo
utube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
  File "youtube_dl\extractor\generic.pyo", line 545, in _real_extract
  File "youtube_dl\utils.pyo", line 1509, in parse_xml
  File "xml\etree\ElementTree.pyo", line 1300, in XML
  File "xml\etree\ElementTree.pyo", line 1642, in feed
  File "xml\etree\ElementTree.pyo", line 1506, in _raiseerror
ParseError: undefined entity: line 30, column 0
Traceback (most recent call last):
  File "youtube_dl\YoutubeDL.pyo", line 524, in extract_info
  File "youtube_dl\extractor\common.pyo", line 180, in extract
  File "youtube_dl\extractor\generic.pyo", line 890, in _real_extract
ExtractorError: Unsupported URL: http://video.nationalgeographic.com/video/smallpox-sci; please report this issue on https://yt-dl.org/bug . Be sure t
o call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.

Support for nationalgeographic has been added in youtube-dl 2<IP_ADDRESS>. Refer to our FAQ if you need help updating.


⚠ ClamAV has degraded performance

In 229eca7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 96 ms

Resolved: ClamAV performance has improved in e97eb7a after 5 minutes.


Do not supply a refresh token when a client does not have the refresh_token grant

This issue is imported from pivotal - Originaly created at Jul 27, 2020 by Bart Geesink
Currently all clients get a refresh_token, but only clients that have permission to use the refresh_token grant are allowed to actually exchange it. This can be confusing. I'd like to see that the token endpoint only returns refresh_tokens to clients that have this grant configured in Manage

@bartgeesink In the current codebase we only return a refresh_token if the client has the refresh_token grant in the metadata grants list. On test2 I have removed this grant from the Playground Client RP and after the push to OIDCNG I confirmed that the refresh_token is not present in the response.

{
  "access_token": "eyJraWQiOiJrZXlfMjA...",
  "expires_in": 7200,
  "id_token": "eyJraWQiOiJrZXlfMjAyMF8wOF8wMl8w...",
  "token_type": "Bearer"
}
``` (Okke Harsta - Aug 2, 2020)

Something I really overlooked. Sorry for the confusion.  (Bart Geesink - Oct 1, 2020)


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/opstest2/docs-archive-test-source.git

Docs Build status updates of commit 2abb058:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RepositoryUnauthorizedWithSourceCommit] Git data access to 'https://github.com/opstest2/docs-archive-test-target' (branch: Release_Archive_main_2022-03-09-01-36-12) is not authorized.. It looks like this might be the first time user: v-alji submitted a pull request to this repo. Before user can run builds in a pull request, he/she can enable 'v-alji' GitHub account in Docs by visiting Docs Portal (https://ops.microsoft.com). After enabling his/her account (v-alji), close and then reopen this pull request to start another build.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Usage example of train_mnist?

So I can run train_mnist:
~/sandbox/dlprimitives$ ./train_mnist
Usage device net.json mnist_img mnist_lbl

Is there a complete workable usage example with example parameters? No idea what these mean but it looks exactly what I'm looking for to hack it (planning to do realtime learning as done in my deep Neuronal Filter: https://github.com/berndporr/deepNeuronalFilter). So basically inference & training at every time-step.

From build directory:
./train_mnist 0:0 ../tools/nets/mnist_train.json ../data/MNIST/raw/train-images-idx3-ubyte ../data/MNIST/raw/train-labels-idx1-ubyte

Where 0:0 is platform:device next the net for training 3rd and 4th are MNIST raw data as downloaded and gunzipped.
However I strongly recommend to take a look https://github.com/artyom-beilis/pytorch_dlprim - pytorch backend based on dlprimitives - it is way more full featured training system that supports much more operators and features.
Dlprimitives as training/inference framework support very basic nets (something like Caffe) it works in static graph and operator set is very-very limited.
If future I plan to invest in pytorch backend and ONNX inference support.

The py torch wrapper has far too much overhead. What I ideally need is forward and backward pass every 20us. So needs to be C++ but as much as possible in the kernels. Just now I just need a fully connected encoder with 3 layers and tanh. That works pretty well with CUDA but I get max 2kHz out of it. So no python for sure. For that reason I love your library. Even that it's a bit limited it far far more complex than my deep neuronal filter or CLDL. I'm rather after super low training times in the region of ms or us.

Thanks. Works:
./train_mnist 0:0 tools/nets/mnist_train.json /tmp/train-images-idx3-ubyte /tmp/train-labels-idx1-ubyte
Using: Intel(R) HD Graphics 5500 [0x1616] on Intel(R) OpenCL HD Graphics
Start training
Epoch/iter 0/100 loss=0.512333 acc=0.84517

The py torch wrapper has far too much overhead

There is C++ API for pytorch, but if you are only running a small net it indeed can be easier to use dlprimitives

Wondering how to inject the loss directly here:
https://github.com/artyom-beilis/dlprimitives/blob/master/examples/cpp/train_mnist.cpp#L118
As I said above I calc a different loss which is not based on labels vs output. I've gone through the code for two last two hours but couldn't find it. Also would be happy to add a function to add that properly. As I said I'm doing realtime noise cancellation and there the error (loss) is the difference between the network output (just one neuron, i.e. encoder) and a noisy signal:

thunk of the adaptive box of the deep network. At every audio sample it's propagated through the network. Then an error is calculated (i.e. loss) and then the weights are changed. I guess that would be your SGD solver. So it's all there but I have no idea where in your code I could set the error/loss.


No NCv2 and NCv3 in SKU family in Loacation "West Europe"

https://azure.microsoft.com/en-au/global-infrastructure/services/ shows that both NCv3 and NCv2 are supported in Region West Europe, However when my customer want to create NCv2 or NCv3 instance, he cannot request a vCPU quota increase in West Europe region via https://docs.microsoft.com/en-us/azure/azure-supportability/resource-manager-core-quotas-request

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe04a05a-f753-ee1f-5171-fd2a81a030f9
Version Independent ID: 1507a7ac-11cc-81a7-e932-9e8ef9644e2b
Content: Azure Resource Manager vCPU quota increase requests
Content Source: articles/azure-supportability/resource-manager-core-quotas-request.md
Service: microsoft-docs
GitHub Login: @ganganarayanan
Microsoft Alias: gangan

@celinama Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

What do you mean they cannot open a core request? The N series VMs are not enabled on any subscriptions by default. In order to get them enabled you have to open a support request. These requests go to the Subscription and billing team and are free to open. From there the team reviews your subscription and if eligible, they will be enabled.
If your customer is not the admin of the subscription then it is possible they personally cannot open a ticket to enable these. If that is the case, then whoever the subscription admin is will need to open that request for them

Hello Micah,
Thanks for your reply.
Let me make it more clear, take my personal subscription “Visual Studio Enterprise“ Sub ID: 2bf6233c-b369-4bc3-9308-866feb94e821 for example, If I go to Usage + quotas--> request increase, IN Quota type choose “Computer/VM(cores/vCPUs) subscription limit increase”  and choose “West Europe” as the location. However in SKU family I failed to found NCSv2/NCSv3. If I choose South Central US as the location then NCSv3 Series is listed in SKU family.
According to your reply, my subscription is not eligible to ask for enablement on N series in West Europe? How can I open a support request if request series (NCSv2/NCSv3) are not listed in required location “West Europe”?
<EMAIL_ADDRESS>Thanks!
Celina Ma
Sr. Cloud Solution Engineer
Azure Customer Experience (CXP)
' +61 (2) 88179902
Monday – Friday 9 AM to 6 PM (GMT + 10:00)
If you need immediate attention for any of the ongoing case while I am out of shift, please send a separate email with case ID to acebackup<EMAIL_ADDRESS>A team member will take action to help you.
[CXP Logo - CSE_White]
From: Micah<EMAIL_ADDRESS>Sent: Saturday, 21 July 2018 3:32 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Celina Ma<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] No NCv2 and NCv3 in SKU family in Loacation "West Europe" (#12028)
What do you mean they cannot open a core request? The N series VMs are not enabled on any subscriptions by default. In order to get them enabled you have to open a support request. These requests go to the Subscription and billing team and are free to open. From there the team reviews your subscription and if eligible, they will be enabled.
If your customer is not the admin of the subscription then it is possible they personally cannot open a ticket to enable these. If that is the case, then whoever the subscription admin is will need to open that request for them
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F12028%23issuecomment-406671554&data=02|01|Celina.Ma%40microsoft.com|325de46e744948c88ba808d5ee66a4f6|72f988bf86f141af91ab2d7cd011db47|1|0|636677046980120598&sdata=eoaUv9M5J4QIgqJh2T26IT1i9uDM8RFPYD2FIj8i0bE%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAmZF1emDm7M0KBagzGpMK6RGoECbRPKCks5uIhP3gaJpZM4VXQzJ&data=02|01|Celina.Ma%40microsoft.com|325de46e744948c88ba808d5ee66a4f6|72f988bf86f141af91ab2d7cd011db47|1|0|636677046980130606&sdata=z%2FjUcViO%2FDBiTbbXmvshRJcKfX6McX8wN7yEELCs2Mk%3D&reserved=0.

@celinama I will close this for now as there is not actionable items against this specific doc. See my above comment to see if that helps.
If all else fails, open a support ticket to the subscription and billing team and ask for their assistance to your request routed to the correct team.

@mimckitt I am facing the same problem I have a VM in West Europe, and when I want to change its size to NC_V3, it says not available. See:

It says none of the availability zones have it. Is it because of the bubble at the top saying there is no temp disk?


Manual fix of Face doc

To test it: tox -c ../../../eng/tox/tox.ini -e sphinx from the folder in question

Closing this PoC


App doesn't work on YT 12.19.56 (latest one)

App doesn't work on YT 12.19.56 (latest one). I have to use the older version to get back your app's function. Please check it out and Update! Thank you!

I already install YoutubePlaybackBackground 2.0.1

I already installed YoutubePlaybackBackground 2.0.1

Can you please check if it's fixed now? I guess I made a little mistake while updating the code :P

I have the same problem

Unfortunately, the problem's still there. @th3an7

Yup, I was wondering if it's only me, looks like not.

Yeah, I'm having the same issue still.

Yeah same here, problem persists.

I really hope it gets fixed relatively soon. This is by far the best modification to youtube.

I hope you can fix it sooner.

Same issue on latest update.

Same problem. If I had known that, I wouldn't have downloaded.

Same problem here...

You can temporarily use Lucky Patcher https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/293#issuecomment-298825442
I've checked every single line of code and I still don't know, why is it not working...
@esgie @pylerSM... can you guys check it out?

Until the problem is solved, you can uninstall updates of the YouTube and downgrade to the previous version, where it worked:
http://www.apkmirror.com/apk/google-inc/youtube/youtube-12-17-54-release/
Just choose the right version for your phone..

Hope the issue gets solved quickly.

According to logcat, the version code is different than expected:
05-27 17:39:06.591 I/YTBackgroundPlayback(6262): No hook details were found for the version of YouTube installed on your device. [vc:1219563300]
05-27 17:39:06.591 I/YTBackgroundPlayback(6262): Using the fall-back hook details for YouTube as a last resort.
05-27 17:39:06.596 W/YTBackgroundPlayback(6262): One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.libraries.youtube.player.background.BackgroundTransitioner
05-27 17:39:06.600 W/YTBackgroundPlayback(6262): One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.libraries.youtube.innertube.model.PlayabilityStatusModel
05-27 17:39:06.604 W/YTBackgroundPlayback(6262): One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.apps.youtube.app.background.BackgroundSettings
05-27 17:39:06.607 W/YTBackgroundPlayback(6262): One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.apps.youtube.app.background.BackgroundSettings
05-27 17:39:06.611 W/YTBackgroundPlayback(6262): One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.libraries.youtube.common.util.PackageUtil
05-27 17:39:06.611 I/YTBackgroundPlayback(6262): Done applying the hooks. [vc:1219563300]

Version multiplier is 1000, so version is<PHONE_NUMBER>/1000=1219563, the json has 121956

@nampud thanks for posting that log - it REALLY helped :D
Now, can someone else check if there is the same error? Version number can
differ according to device DPI, CPU arch and/or Android version...
1219563300 is arm, nodpi, 5.0+ version...
If someone with different CPU arch (x86/arm64) could check if log displays
different numbers (ie. 3400 for arm64 and 3700 for x86 - both for nodpi
5.0+)
If yes, please say so, so we could change version numbers in .json
On Sat, May 27, 2017, 17:48 nampud<EMAIL_ADDRESS>wrote:

According to logcat, the version code is different than expected:
05-27 17:39:06.591 I/YTBackgroundPlayback(6262): No hook details were found for the version of YouTube installed on your device. [vc:1219563300]
05-27 17:39:06.591 I/YTBackgroundPlayback(6262): Using the fall-back hook details for YouTube as a last resort.
05-27 17:39:06.596 W/YTBackgroundPlayback(6262): One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.libraries.youtube.player.background.BackgroundTransitioner
05-27 17:39:06.600 W/YTBackgroundPlayback(6262): One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.libraries.youtube.innertube.model.PlayabilityStatusModel
05-27 17:39:06.604 W/YTBackgroundPlayback(6262): One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.apps.youtube.app.background.BackgroundSettings
05-27 17:39:06.607 W/YTBackgroundPlayback(6262): One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.apps.youtube.app.background.BackgroundSettings
05-27 17:39:06.611 W/YTBackgroundPlayback(6262): One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.libraries.youtube.common.util.PackageUtil
05-27 17:39:06.611 I/YTBackgroundPlayback(6262): Done applying the hooks. [vc:1219563300]
Version multiplier is 1000, so version is<PHONE_NUMBER>/1000=1219563, the
json has 121956
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/321#issuecomment-304460025,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxxbND8ekEI6x7vWGg4EOPJtzdlbdCQks5r-EXpgaJpZM4NhicU
.

How do I get that log you talking about? I have an arm64 (Helio P10)

Check Xposed app (somwhere there should be log)
On Sat, May 27, 2017, 21:00 sidnov<EMAIL_ADDRESS>wrote:

How do I get that log you talking about? I have an arm64 (Helio P10)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/321#issuecomment-304470379,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxxbEch49n4u8jfaqBwbWj0wZsr1UXBks5r-HLdgaJpZM4NhicU
.

The xposed log doesn't report this, you need to check the logcat (I have an arm device so I can't be of help)

@Aurora does your phone uses YouTube app with specific DPI or nodpi version?
Everyone else who have other CPU arch. - check adb logcat as @Aurora
suggested for getting logs.
On Sat, May 27, 2017, 22:26 Aurora<EMAIL_ADDRESS>wrote:

The xposed log doesn't report this, you need to check the logcat (I have
an arm device so I can't be of help)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/321#issuecomment-304474714,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxxbLEhJF8MfxrbkothhoO7OBnKz_feks5r-IbrgaJpZM4NhicU
.

My logcat says:
No hook details were found for the version of YouTube installed on your device. [vc:<PHONE_NUMBER>]

As I thought - @MichelTenVoorde and @nampud logs proves that version is changing depending on device CPU arch/OS version/DPI...
Now, is there anyone who knows how to add some kind of wildcard for version naming in .json (ie. latest update would look like "121956****")

The issue still seems to persist for me, and I can't seem to locate the log, but will be willing to post it if told where to find it.

@Ithilden use adb logcat to get the log - you need a PC to do this :)

How can i fix the error?

05-28 04:51:39.822 11580 11580 I YTBackgroundPlayback: No hook details were found for the version of YouTube installed on your device. [vc:1219563340]
05-28 04:51:39.822 11580 11580 I YTBackgroundPlayback: Using the fall-back hook details for YouTube as a last resort.
05-28 04:51:39.825 11580 11580 W YTBackgroundPlayback: One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.libraries.youtube.player.background.BackgroundTransitioner
05-28 04:51:39.828 11580 11580 W YTBackgroundPlayback: One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.libraries.youtube.innertube.model.PlayabilityStatusModel
05-28 04:51:39.831 11580 11580 W YTBackgroundPlayback: One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.apps.youtube.app.background.BackgroundSettings
05-28 04:51:39.834 11580 11580 W YTBackgroundPlayback: One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.apps.youtube.app.background.BackgroundSettings
05-28 04:51:39.837 11580 11580 W YTBackgroundPlayback: One of the hooks could not be applied: java.lang.ClassNotFoundException: com.google.android.libraries.youtube.common.util.PackageUtil
05-28 04:51:39.837 11580 11580 I YTBackgroundPlayback: Done applying the hooks. [vc:1219563340]

Hi, same problem here.
Since upgrading YT to 12.19.56 the background playing doesn't autostart.
My device specs are: Android KitKat 4.4.2 - 320dpi - ARMv7 Processor rev 3 (v7|)

So I'm not a Java coder but the issue is quite simple it seems. Basically the version codes, up until the previous YT version, were made of 9 digits. Now they're made of 10 digits. The division by 1000 was sufficient until the previous 1000 to filter out the differences in architectures/DPI sizes; but now a division by 10000 is needed. So you'd need to drop support for all the previous versions (since 10000 causes trouble/some old versions would have the same result when divided by 10000), and change the version id to 121956

i updated youtube 2 days ago and this module is not working... hope ull fix it :)

@AuroraWright I've seen your solution but I don't think @pylerSM would like to drop those all those previous version, at least not right now...
What about this: https://github.com/th3an7/YouTubeBackgroundPlayback/commit/540a7967c21effb180c1cd2f12fcd093a4a3ed7f
Would that work?
If not, I could build new module .apk with newly created json file for further updates

@th3an7, it still doesn't work. In my case, hooks-1.json should have 1219563 instead of 1219560 as the version string to match. May I suggest just looking at the leftmost 6 digits of the version number? Should work as far as I can tell. If version number scheming changes in the future, oh well, that'd be something to worry about later.

Being desperate for background playback 🌝, fixed it locally for now by changing line 70 of YouTubeBackgroundPlayback.java to:
JSONArray hooks = hooksFile.optJSONArray("1219560");

That is one solution :)
I will probably build new apk - please check Xposed repo for updates... it should be available in max. 30 min

that apk is working fine here

same here

Works just fine here too.

OK, will release newly updated apk to repo then :)
Thanks everyone for helping :D

BTW: Does this module displays notification all the time or only when YT is in background?

All the time. However, when I close the notification while I'm in the YT app it doesn't come back until I put YT in the background.

Here is small bonus - this one should show notification only when YT is in background :)
BackgroundOnly.zip

It's alive! Again! The module is working perfectly.. Thanks very much to th3an7 for hard work!

Thanks for getting it working on the latest version. BTW once I switched to the "notification always on" one, I found that it's very useful and I really like that simple add on.

Glad I could help :P
I'd also like to thanks everyone who reported it, posted logs and proposed changes :)
Enjoy YouTube in background :D

Thank you! The app works. But when i installed the bonus app BackgroundOnly, the function disappeared. I had to reinstall to get back the function. Could u check it ? :D

Reinstall normal one or background only?
Try uninstalling module completely, then installing "bonus" one. Remember
to enable it in Xposed app and reboot after install!
On Sun, May 28, 2017, 18:22 DoomD95<EMAIL_ADDRESS>wrote:

Thank you! The app works. But when i installed the bonus app
BackgroundOnly, the function disappeared. I had to reinstall to get back
the function. Could u check it ? :D
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/321#issuecomment-304524733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxxbL-w6WIzwK-1x0yOeD918Y21kawFks5r-Z9FgaJpZM4NhicU
.

Or if you could post logcat... Maybe I f***** up something again :P

Haha. dont need to. After followed your steps, i got the app. I thought BO apk is an add on, so i installed it after installed the module. But doing a clean install is working. Thanks for your immediately support!

Oh, no problem :)
Glad you've fixed it :D
On Sun, May 28, 2017, 18:41 DoomD95<EMAIL_ADDRESS>wrote:

Haha. dont need to. After followed your steps, i got the app. I thought BO
apk is an add on, so i installed it after installed the module. But doing a
clean install is working. Thanks for your immediately support!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/321#issuecomment-304525845,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxxbMulOhu39rSTAB5A20FoFyblAAIKks5r-aPGgaJpZM4NhicU
.

It works perefectlly
Thank you

After the last update, it's working again perfectly. Thank you so much for fixing it quickly.
:1st_place_medal:

@rambomhtri not sure, but if your ROM supports Substratum themes, you could try preparing such theme for YouTube app :)

Thank you. My ROM is like 99% vanilla Android, although my carrier has done some minor modifications. In example, Xposed GravityBox works fine, and that module is meant to work mainly in vanilla Android. So, I guess my ROM is ready for that themes you say. How do they work? Where can I download them? Is there an official thread so I can dig more information?

Substratum theme engine has its own forum on XDA -
https://forum.xda-developers.com/apps/substratum
On Mon, May 29, 2017, 19:46 Rambo Hunter<EMAIL_ADDRESS>wrote:

Thank you. My ROM is like 99% vanilla Android, although my carrier has
done some minor modifications. In example, Xposed GravityBox works fine,
and that module is meant to work mainly in vanilla Android. So, I guess my
ROM is ready for that themes you say. How do they work? Where can I
download them? Is there an official thread so I can dig more information?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/321#issuecomment-304706971,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxxbG1OOCqJCfPGh1hDCrcBI6d-V33bks5r-wSFgaJpZM4NhicU
.

@rambomhtri Have you found your theme?
Got something for you... can you test it? :)
test.zip

I'm having a similar issue. Youtube version 12.14.56
Upgrading to 2.02 broke background playback. Uninstalling and then reinstalling 2.01 made it works again.

@Vorul, 2.0.2 is made for YT 12.19.56+... It has no backwards
compatibility...
Stay on 2.0.1 or update your YT app :)
On Tue, May 30, 2017, 03:15 vorul<EMAIL_ADDRESS>wrote:

I'm having a similar issue. Youtube version 12.14.56
Upgrading to 2.02 broke background playback. Uninstalling and then
reinstalling 2.01 made it works again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/321#issuecomment-304751990,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxxbHRLjywihmjgmE5JqnKgQ78wX5q9ks5r-22_gaJpZM4NhicU
.

@th3an7
Hallo my dear friend. No, unfortunately I couldn't manage to understand how Substratum works, it seems a little complicated. I installed it, went to settings and tried to apply some theme's but they were paid versions or there would be a message in Google Play saying my device is not compatible. Also I searched for How To videos in YouTube and I couldn't find a guide or tutorial explaining the basics: from start when you install the app to when you apply a little custom theme to a chosen app.
What's that zip?

@rambomhtri in a nutshell

Download Substratum theme engine from Play Store (https://play.google.com/store/apps/details?id=projekt.substratum)
Download zip I've posted earlier and install .apk from it
After installing an app, open Substratum, you should see a list with installed themes
Choose one, inside there, select app to theme (with a checkbox next to it)
After selecting apps, click on paintbrush at the down right
Select "Build & Enable", wait a while and you should be done :)

OK, I'm doing it right now.
By the way, if I understood well, Substratum is only a "color changer" of apps, it doesn't need to replace original Play Store apps, it's compatible with your module, it's compatible with future releases, etc... right?
But what would happen if YouTube app gets updated to 13.0 and includes new tabs and new UI?
Thank you for your time and help, really appreciated. 💯

Substratum is changing overlays so it does not modify anything in apk
files, it just lays it's layers on top of running apps (at least I think so)
It should work as long as you said - if they change something like colors
of the background, add a new tab or something like that, the theme also
needs to be updated...
On Tue, May 30, 2017, 17:24 Rambo Hunter<EMAIL_ADDRESS>wrote:

OK, I'm doing it right now.
By the way, if I understood well, Substratum is only a "color changer" of
apps, it doesn't need to replace original Play Store apps, it's compatible
with your module, it's compatible with future releases, etc... right?
But what would happen if YouTube app gets updated to 13.0 and includes new
tabs and new UI?
Thank you for your time and help, really appreciated. 💯
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/321#issuecomment-304913993,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxxbISn217sfsIpFVfGkRc0_iwY1Zypks5r_DSlgaJpZM4NhicU
.

OK, well, wow, wooow, WOOHOOW, what the hell, that's what I've been looking for, literally, 6 years. Amazing, actually amazing, truly amazing, amazingly amazing. I can't stop laughing, every single thing is blacked out, comments, all screens.

First, how did you do that?
I asked that first question to know if I would be able to customize a little bit those layers, in example: since my screen is not AMOLED (sad but true), I'd rather use a dark grey for general background color, and if it's possible different tones of grey separating sections like video title and description from suggested videos, comments from suggested videos, etc... Is it simple to do it or you need to know some programming? How much can you fine tune those colors?
I recently made a PayPal account (still don't know how to use it though, I'm in process of learning). When I'm ready, I'd love to buy you a beer or two for your background module and for this amazing tool and tutorial.

Thank you! :)

I've just used a tutorial from substratum github page - https://github.com/substratum/template :D
There is also a video on XDA YT channel - https://www.youtube.com/watch?v=gNDKhBO3q-E
I could take a look and change something... hit me up on Hangout or something so we can talk about changes (don't want to spam it more here at it is already :P)

It's still not working for me, I thought the package I'll update itself? or do I need to manually install it?

Update the module to 2.0.2 - it should work
On Wed, May 31, 2017, 11:56 clragon<EMAIL_ADDRESS>wrote:

It's still not working for me, I thought the package I'll update itself?
or do I need to manually install it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pylerSM/YouTubeBackgroundPlayback/issues/321#issuecomment-305143494,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMxxbCXiDoRPSgRxaj-t6p3QeGPsw-knks5r_TlAgaJpZM4NhicU
.

oh yeah. but 2.0.2 is not on xposed(?)
I just installe it manually now.

I have 2.0.2 installed and it doesn't work on some vids, and the slider or player controls play/paues etc  doesn't come up after tapping the screen sometimes.  only on some vids if i turn off the screen it stops playing and says There was a problem while playing Playback ID ib6hf7xyf_xy0qs

Works fine with the 2.0.2

Does not work for me, YouTube 12.19.56, this 2.0.2, OS 6.0.1, phone nexus 5


Readiness probe is not working correctly

Bug description

Configuration is not respecting initial delay. In my app initial delay is set to 120s but POD is in Running state before that.

example-app-6bbdf98bd8-dc57t   1/2     Running   0          34s

It sets the application in Running state even if readiness probe fails - Warning  Unhealthy  15s   kubelet, aks-agentpool-17141372-vmss000000  Readiness probe failed: HTTP probe failed with statuscode: 503. Also, it should start checking after initial delay.

When I check the website it says: no healthy upstream. It routes the traffic even if health check fails.
Expected behavior
It should respect and override defined readiness probe configurations.
Steps to reproduce the bug
Install istio with this value: rewriteAppHTTPProbe: true in sidecarInjectorWebhook and mutual TLS is enabled.
readinessProbe:
      httpGet:
        path: /
        port: 3000
      initialDelaySeconds: 120
      periodSeconds: 10
      timeoutSeconds: 10

Pod Describe
example-app:
  Readiness:    http-get http://:15020/app-health/example-app/readyz delay=120s timeout=10s period=10s #success=1 #failure=3
istio-proxy:
  ISTIO_META_POD_PORTS:              [
                                         {"containerPort":3000}
                                     ]
  ISTIO_META_CLUSTER_ID:             Kubernetes
  POD_NAMESPACE:                     default (v1:metadata.namespace)
  INSTANCE_IP:                        (v1:status.podIP)
  SERVICE_ACCOUNT:                    (v1:spec.serviceAccountName)
  ISTIO_META_POD_NAME:               example-app-788f77795f-l6ssb (v1:metadata.name)
  ISTIO_META_CONFIG_NAMESPACE:       default (v1:metadata.namespace)
  SDS_ENABLED:                       false
  ISTIO_META_INTERCEPTION_MODE:      REDIRECT
  ISTIO_META_INCLUDE_INBOUND_PORTS:  3000
  ISTIO_METAJSON_LABELS:             {"app":"example-app"}

  ISTIO_META_WORKLOAD_NAME:          example-app
  ISTIO_META_OWNER:                  kubernetes://api/apps/v1/namespaces/default/deployments/example-app
  ISTIO_KUBE_APP_PROBERS:            {"/app-health/example-app/livez":{"path":"/","port":3000},"/app-health/example-app/readyz":{"path":"/","port":3000}}

Version (include the output of istioctl version --remote and kubectl version)
1.3.5
How was Istio installed?
Helm template using values.yaml file
Environment where bug was observed (cloud vendor, OS, etc)
AKS

I am not sure what the problem is? Here is a pod that is "not ready". No Istio injection at all:
NAME                                 READY   STATUS      RESTARTS   AGE
badhealth-6c858d4f85-ltspv           0/1     Running     0          30s

Running is independent of "ready"
What you should check is kubectl get endpoints and istioctl pc endpoints and see if the endpoint shows up

Yes. There is an endpoint (kubectl get endpoints) and istioctl pc endpoints give me an error - Error: accepts 1 arg(s), received 0
Why traffic is going to the pod even if the readiness probe fails?

If an endpoint exists then it seems like a k8s issue. Does it actually have a ready endpoint or just the object?
Is it like: (not ready)
NAME          ENDPOINTS                                          AGE
badhealth                                                        4d16h

Or ready:
NAME          ENDPOINTS                                          AGE
badhealth     <IP_ADDRESS>:80                              4d16h