SCons: Use r-strings for wayland-scanner builder command

I wonder if there's a static check we could do to spot this without this trial and error?

It wasn't a problem in the past, but Python 3.12 made this a warning (and I think 3.13 will stop supporting this syntax and error out).

So far it's only been needed when there's invalid escape codes, like \. here. < and > in these other examples seem fine. But yeah I can apply it to all the wayland-scanner invocations for consistency.


Adding sample function in go template

Changes
Fixes #839

:broom: function template uses signature which expects a CloudEvent and returns a CloudEvent
:broom: add example function to go template, this function uses the same events as the spring-boot template
:broom: test added to check correct events and payloads

/kind enhancement

Regarding the security check failing, I am not sure what to do with that.. it seems an issue with a vendor file.

@lance @lkingland I've just pushed the simplest template function possible.. the idea here is to have a signature that consumes and produce a cloudevent, hence I followed @lkingland advice to just return a CloudEvent that echos the input.
For me at least, it is much clear to have a simple example of returning a cloudevent in the template..
if we are all ok with this I can replicate this into the springboot template to remove the more complex example that we have there.
Also.. following @lkingland advice, I've created a personal repo with some examples, that I will happily send to an official example repo if we have such a thing. https://github.com/salaboy/func-templates


[Feature] Improve faulted session error message

Feature
I was encountering the faulted session error. Eventually, I found that there are two bugs in my code, but the problem is that RISC Zero toolkit never provided the actual error message---I have to eventually use the gdb0 tool to figure out where it starts to go wrong, and why.
So, I am requesting improved error message for faulted session.

for 0.19.1, currently, the error message is only "faulted session", without the original error message passed from the rrs library.
for the main branch, the problem is indeed very severe, because I see completely no error message from the execution. The output is blank.

So, I think at the very least, one needs to restore the error message in the current main branch. Ideally, the original error message from the rrs library is exposed.
Motivation
Easier debugging if some unsafe memory operations cause illegal instructions.
Implementation
Recommend to use anyhow to send the error message with the original error message from rrs. More fundamentally, the main branch should be able to deliver at least the "faulted session" error instead of leaving the output blank.

For reference, the underlying errors that I eventually undercover are alignment errors, from two places.
Issue 1. If I use include_bytes! but intend to rephrase the bytes into a data structure, as in the example below.
static BSK_BYTES: &[u8] = include_bytes!("../../../bsk");
let bsk = black_box(unsafe {
    std::mem::transmute::<&u8, &[GgswCiphertext; 16]>(&BSK_BYTES[0])
});

There is a possibility that it would trigger faulted session because the BSK_BYTES could be just aligned to byte. But I actually need them to align to u32. This is solved by the include_bytes_aligned macro.
Issue 2. I used transmute to cast a pointer to u8 into a pointer to u32, in order to copy data faster by copying 32-bit at a time. However, if the u8 is not at aligned to u32, this would also failed.
unsafe {
    let len = $msg.len();
    core::ptr::copy(
        core::mem::transmute::<*const u8, *const u32>($msg.as_ptr()),
        TRACE_MSG_CHANNEL.as_mut_ptr(),
        (len + 3) / 4,
    );
}

This is basically due to my use of transmute without taking care of alignment. I fixed my code (https://github.com/l2iterative/profiler0/commit/8f4aec90cb9126b911b16a61023deb5209fe468c) by not doing the casting.

So we're removing the proof of fault from the zkvm for now and do this as a part of future circuits. so https://github.com/risc0/risc0/pull/1317 reverts to the old behavior and give you the error message from the rrs library. Closing


Add the initialDelaySeconds of preflight to the helm chart

Fixes: #30379

This allows the initialDelaySeconds option to be configured. This allows users running larger clusters to extend the time it takes for preflight to become ready.

/test

/ci-e2e

/ci-clustermesh

/ci-clustermesh

The preflight daemonset cannot really fail. We should just get rid of the liveness probe entirely.

The preflight daemonset cannot really fail. We should just get rid of the liveness probe entirely.

Do you mean to only keep readinessProbe and delete livenessProbe? @squeed

Exactly; liveness of preflight is not interesting regardless. It's not a running service.

I'm converting it to draft as there are conflicts and it seems the change needs a different approach.

/test

/ci-ipsec-upgrade)

/ci-ginkgo

/ci-awscni

/ci-eks

/ci-e2e

/ci-ingress

/ci-ginkgo

/test

/test

/test

/ci-ipsec-e2e

/ci-clustermesh

/cc @squeed PTAL.

Hi @chaunceyjiang , could you please update the PR description to describe the motivation (why?) for this PR? This can help future readers to understand the PR. Something as simple as "This makes the option configurable so that users running larger clusters can extend the time for preflight to become ready" would be useful.

Apologies for missing this, it fell off of my radar.

@chaunceyjiang this needs a quick fix -- see the smoke tests for details.

Hi, @squeed I ran make -C install/kubernetes locally but nothing changed. Do I need to rebase the main branch?

/test

/ci-awscni

/ci-gke

/ci-ginkgo

/ci-ingress


Add OpenBuckets - Search engine for misconfigure cloud storages

Add OpenBuckets - https://openbuckets.io

I don't think this is directly piracy-related

It's similar to grayhatwarfare, but better. So thought I should add it.

I tried searching, but most returned server errors or nothing interesting. I couldn't find anything piracy-related. Sorry, I can't add this. But thanks for your attempt.


Add integration test for hotrod on k8s

There is a sample setup for HotROD + all-in-one combo in ./examples/hotrod/kubernetes. We already have integration tests that validate this combo (.github/workflows/ci-docker-hotrod.yml), it would be good to extend those tests to cover the k8s deployment as well, so that we can guarantee that the provided configs are valid.

Hi @yurishkuro, I'd like to contribute to the repository and noticed this issue. Since it will be my first time working on this repo, could you provide some guidance for me to get started?

Hi @yurishkuro ! I'd love to look at this issue if possible. Thank you!


An error occurred uploading an image

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
Greetings:
I am running Bookstack within a LXC container (Debian 12) on a ProxMox host. Bookstack is served up and reverse-proxied via Cloudflare Tunnel Services which also handles the cert.
Cloudflare is configured as follows: https://bookstack.foo.bar/ -> http://<IP_ADDRESS>/
Apache2 receives the request with the following config:
Details

<VirtualHost *:80>

	# This is a simple example of an Apache VirtualHost configuration
	# file that could be used with BookStack.
	# This assumes mod_php has been installed and is loaded.
	#
	# Change the "docs.example.com" usage in the "ServerName" directive
	# to be your web domain for BookStack.
	#
	# Change the "/var/www/bookstack/public/", used twice below, to the
	# location of the "public" folder within your BookStack installation.
	#
	# This configuration is only for HTTP, Not HTTPS.
	# For HTTPS we recommend using https://certbot.eff.org/

	ServerName bookstack.foo.bar
	DocumentRoot /var/www/bookstack/public/

	<Directory /var/www/bookstack/public/>
		Options Indexes FollowSymLinks
		AllowOverride None
		Require all granted
		<IfModule mod_rewrite.c>
			<IfModule mod_negotiation.c>
				Options -MultiViews -Indexes
			</IfModule>

			RewriteEngine On

			# Handle Authorization Header
			RewriteCond %{HTTP:Authorization} .
			RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization}]

			# Redirect Trailing Slashes If Not A Folder...
			RewriteCond %{REQUEST_FILENAME} !-d
			RewriteCond %{REQUEST_URI} (.+)/$
			RewriteRule ^ %1 [L,R=301]

			# Handle Front Controller...
			RewriteCond %{REQUEST_FILENAME} !-d
			RewriteCond %{REQUEST_FILENAME} !-f
			RewriteRule ^ index.php [L]
		</IfModule>
	</Directory>

	ErrorLog ${APACHE_LOG_DIR}/error.log
	CustomLog ${APACHE_LOG_DIR}/access.log combined

</VirtualHost>

My .env is as follows:
Details

# This file, when named as ".env" in the root of your BookStack install
# folder, is used for the core configuration of the application.
# By default this file contains the most common required options but
# a full list of options can be found in the '.env.example.complete' file.
#APP_DEBUG=true
# NOTE: If any of your values contain a space or a hash you will need to
# wrap the entire value in quotes. (eg. MAIL_FROM_NAME="BookStack Mailer")

# Application key
# Used for encryption where needed.
# Run `php artisan key:generate` to generate a valid key.
APP_KEY=base64:firidoX8NFE1bZNjwowzQcv62K0rr7F93ijGuinSLcg=

# Application URL
# This must be the root URL that you want to host BookStack on.
# All URLs in BookStack will be generated using this value
# to ensure URLs generated are consistent and secure.
# If you change this in the future you may need to run a command
# to update stored URLs in the database. Command example:
# php artisan bookstack:update-url https://old.example.com https://new.example.com
APP_URL=https://bookstack.foo.bar

#Database details
DB_HOST=localhost
DB_DATABASE=bookstack
DB_USERNAME=bookstack
DB_PASSWORD=extremelysecurepassword

# Mail system to use
# Can be 'smtp' or 'sendmail'
MAIL_DRIVER=smtp

# Mail sender details
MAIL_FROM_NAME="BookStack"
<EMAIL_ADDRESS>
# SMTP mail options
# These settings can be checked using the "Send a Test Email"
# feature found in the "Settings > Maintenance" area of the system.
# For more detailed documentation on mail options, refer to:
# https://www.bookstackapp.com/docs/admin/email-webhooks/#email-configuration
MAIL_HOST=smtp.office365.com
MAIL_PORT=587
<EMAIL_ADDRESS>MAIL_PASSWORD=extremelysecurepassword_too
MAIL_ENCRYPTION=tls

STORAGE_TYPE=local
FILE_UPLOAD_SIZE_LIMIT=100

So, my setup is:
Cloudflare (https://bookstack.foo.bar/) -> Apache2 (*:80) -> /var/www/bookstack
Additionally, all of /var/www/bookstack is owned recursively by www-data:www-data
Still, any time I attempt to upload an image to a page whilst editing, I get this:

Finally, browser debugging panel looks thusly:
Details

app.js?version=v23.08:43 Refused to set the document's base URI to '' because it violates the following Content Security Policy directive: "base-uri 'self'".

init_instance_callback @ app.js?version=v23.08:43
edit:1 Mixed Content: The page at 'https://bookstack.foo.bar/books/azure/page/create-the-storage-account/edit' was loaded over HTTPS, but requested an insecure resource 'http://bookstack.foo.bar/images/gallery/'. This request has been blocked; the content must be served over HTTPS.
app.js?version=v23.08:25 TypeError: Failed to fetch
    at Go (app.js?version=v23.08:18:1286)
    at an (app.js?version=v23.08:18:1752)
    at Object.Gu (app.js?version=v23.08:18:1858)
    at jf (app.js?version=v23.08:25:32608)
    at app.js?version=v23.08:25:32980
(anonymous) @ app.js?version=v23.08:25
edit:1 Mixed Content: The page at 'https://bookstack.foo.bar/books/azure/page/create-the-storage-account/edit' was loaded over HTTPS, but requested an insecure resource 'http://bookstack.foo.bar/images/gallery/'. This request has been blocked; the content must be served over HTTPS.
app.js?version=v23.08:25 TypeError: Failed to fetch
    at Go (app.js?version=v23.08:18:1286)
    at an (app.js?version=v23.08:18:1752)
    at Object.Gu (app.js?version=v23.08:18:1858)
    at jf (app.js?version=v23.08:25:32608)
    at app.js?version=v23.08:25:32980

Any thoughts? Any help is greatly appreciated!
Also, I posted this over on Redit but am posting here in case this is the better location.  If this is viewed as spam, I will happily take one down.
 Right now that only provides the tail end of the log stack. Getting 100 lines should do the trick tail -n 100 /var/www/bookstack/storage/laravel.log. The most relevant lines should start with a datetime for the error, ideally matching when you reproduced the error in the UI.
If you're running tail -f /var/www/bookstack/storage/laravel.log and don't see new lines appear when you cause this specific error, then this may not be a back-end error. Possible that the request is not hitting the server due to the browser console errors you're reporting.

If you're running tail -f /var/www/bookstack/storage/laravel.log and don't see new lines appear when you cause this specific error, then this may not be a back-end error. Possible that the request is not hitting the server due to the browser console errors you're reporting.

I suspect your suspicion may be correct.  No new laravel entries once the bookstack container restarts:
[stacktrace] #0 /var/www/bookstack/app/Api/ApiTokenGuard.php(103): BookStack\\Api\\ApiTokenGuard->validateToken() #1 /var/www/bookstack/app/Api/ApiTokenGuard.php(58): BookStack\\Api\\ApiTokenGuard->getAuthorisedUserFromRequest() #2 /var/www/bookstack/app/Api/ApiTokenGuard.php(77): BookStack\\Api\\ApiTokenGuard->user() #3 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Auth/AuthManager.php(340): BookStack\\Api\\ApiTokenGuard->authenticate() #4 /var/www/bookstack/app/Http/Middleware/ApiAuthenticate.php(46): Illuminate\\Auth\\AuthManager->__call() #5 /var/www/bookstack/app/Http/Middleware/ApiAuthenticate.php(19): BookStack\\Http\\Middleware\\ApiAuthenticate->ensureAuthorizedBySessionOrToken() #6 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): BookStack\\Http\\Middleware\\ApiAuthenticate->handle() #7 /var/www/bookstack/app/Http/Middleware/StartSessionIfCookieExists.php(20): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() #8 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): BookStack\\Http\\Middleware\\StartSessionIfCookieExists->handle() #9 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(67): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() #10 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\\Cookie\\Middleware\\EncryptCookies->handle() #11 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Middleware/ThrottleRequests.php(126): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() #12 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Middleware/ThrottleRequests.php(57): Illuminate\\Routing\\Middleware\\ThrottleRequests->handleRequest() #13 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\\Routing\\Middleware\\ThrottleRequests->handle() #14 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(116): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() #15 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(797): Illuminate\\Pipeline\\Pipeline->then() #16 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(776): Illuminate\\Routing\\Router->runRouteWithinStack() #17 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(740): Illuminate\\Routing\\Router->runRoute() #18 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(729): Illuminate\\Routing\\Router->dispatchToRoute() #19 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(190): Illuminate\\Routing\\Router->dispatch() #20 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(141): Illuminate\\Foundation\\Http\\Kernel->Illuminate\\Foundation\\Http\\{closure}() #21 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Http/Middleware/TrustProxies.php(39): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() #22 /var/www/bookstack/app/Http/Middleware/TrustProxies.php(41): Illuminate\\Http\\Middleware\\TrustProxies->handle() #23 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): BookStack\\Http\\Middleware\\TrustProxies->handle() #24 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() #25 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php(40): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle() #26 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\\Foundation\\Http\\Middleware\\TrimStrings->handle() #27 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() #28 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\\Foundation\\Http\\Middleware\\ValidatePostSize->handle() #29 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php(86): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() #30 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\\Foundation\\Http\\Middleware\\PreventRequestsDuringMaintenance->handle() #31 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(116): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() #32 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(165): Illuminate\\Pipeline\\Pipeline->then() #33 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(134): Illuminate\\Foundation\\Http\\Kernel->sendRequestThroughRouter() #34 /var/www/bookstack/public/index.php(52): Illuminate\\Foundation\\Http\\Kernel->handle() #35 {main} "}
Any ideas where to go next if that is the case?
And, as always, thank you for your time and expertise!

Can you got to edit a page, open the browser development console, then paste in the below and hit enter?:
document.querySelector(`[option\\:dropzone\\:url]`).getAttribute('option:dropzone:url')

When confirm if the value it returns starts with a https:// or http:// or if it doesn't match your main APP_URL value.

Does a similar console error/warning appear if you start typing a search in the header search bar (at least 3 characters, without pressing enter)?

Does a similar console error/warning appear if you start typing a search in the header search bar (at least 3 characters, without pressing enter)?

Dan:
No, the only errors that appear in the console are those that are referenced above and only when you are a) editing and b) attempting to insert a picture.
One critical element I left out (and I apologize, I can't believe it slipped my mind) is that this bookstack instance started clean and then an existing, backup was imported in (we had a hardware failure).  Existing articles, books, etc. show the same errors as when dealing with new (ones created post import) however, on the old instance, there were no errors.

That shouldn't really affect things to be honest, really unsure why this is occuring just here though.
Your access logs show a an image upload POST resulting in a 301 response, which I really don't understand being possible from a BookStack handling point of view.

Again when editing the page, can you go to the console and run document.querySelector('[option\\:dropzone\\:url].image-manager').getAttribute('option:dropzone:url') to confirm if that starts with http or https.
Do attachments upload fine?
If you add an image, via drag + dropping an image file directly into the editor, does that work?
Do you have in play, or have you attempted to set, any additional apache config upon that shown in your original post?
Has anything been set on the apache or Cloudlfare side to manipulate URLs (Force or strip slashes for example).

That shouldn't really affect things to be honest, really unsure why this is occuring just here though. Your access logs show a an image upload POST resulting in a 301 response, which I really don't understand being possible from a BookStack handling point of view.

Again when editing the page, can you go to the console and run document.querySelector('[option\\:dropzone\\:url].image-manager').getAttribute('option:dropzone:url') to confirm if that starts with http or https.

This is the response with the above command:
'https://bookstack.foo.bar/images/gallery?uploaded_to=21'

Do attachments upload fine?

No, they produce the same error

If you add an image, via drag + dropping an image file directly into the editor, does that work?

No, it produces  a similar error:
app.js?version=v23.08:25 TypeError: Failed to fetch     at Go (app.js?version=v23.08:18:1286)     at an (app.js?version=v23.08:18:1752)     at Object.Gu (app.js?version=v23.08:18:1858)     at jf (app.js?version=v23.08:25:32608)     at app.js?version=v23.08:25:32980

Do you have in play, or have you attempted to set, any additional apache config upon that shown in your original post?

I have not

Has anything been set on the apache or Cloudlfare side to manipulate URLs (Force or strip slashes for example).

Nothing that I am aware of outside of using a new tunnel on this new instance (the old tunnel died with the hardware that housed the old bookstack)

Coming back to this, there's not much else I can think of to understand why the wrong URL is being attempted here.
The only other thing that might provide some answers, is if you can provide a HAR capture that covers the time from loading up the editor to attempting an image upload. That way I can get a fuller picture of the browser-side of things.
There's details here on how to capture a HAR file in various browsers.
It can contain private information, so probably best not to post here, but you can send it to my email (shown in my Github profile), just reference this issue within the email itself.

Coming back to this, there's not much else I can think of to understand why the wrong URL is being attempted here.
The only other thing that might provide some answers, is if you can provide a HAR capture that covers the time from loading up the editor to attempting an image upload. That way I can get a fuller picture of the browser-side of things.
There's details here on how to capture a HAR file in various browsers. It can contain private information, so probably best not to post here, but you can send it to my email (shown in my Github profile), just reference this issue within the email itself.

Dan:
Ultimately I decided to start from scratch so unfortunately I can't go down this path.  Thank you so much for checking back.  Even I forgot about it.

Okay, no worries, I'll therefore close this off.


你好， 你的gitbook theme很好看， 请问我可以使用吗？

Of course you can, just fork and use it. The main style is placed in the style folder.

thank you

@nicesu you're welcome~


Missing studio preview for menus

The preview is important for when deleting routes that are still referenced in the menu:

It will now look like this instead

LGTM :thumbsup:


fix(upgrade): Fix MAE consumer and upgrade's dependency issue

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

Fixes #3097


patch: fix 404 link

resolves #40

Sorry did you fix it or just like move it to a different issue or something that doesn't seem to be fixed for me and I was really excited to read this page

it was an old page in the docs. it is now https://docs.useanything.com/agent/usage

Awesome thanks for your time. Also really appreciated your youtubes about AnythingLLM


Remove getFields method

See #27

@ddeboer are you OK with this as well? I would wait for some other changes in the repo prior to merging this as some classes will be removed anyway, why bother those then?

Yes, agreed on removing the method and keeping this PR on hold for now.

Now conflicts with master. Could you please rebase?

Rebased on master.


Updated the styling / Fixed resize.

The styling [especially the version selection] has been updated.
Restricted the window's resize bounds.
Condensed some of the code in website.js

Sure thing! Must have forgotten to exclude that line when doing the pull
request.
On Thu, Apr 1, 2021, 11:04 AM MoaufmKlo @.***> wrote:

@MoaufmKlo requested changes on this pull request.
The developer tools still seem to automatically open when you open it.
Could you please remove line 17 in main.js?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MoaufmKlo/BuildToolsGUI/pull/22#pullrequestreview-626424815,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXB3ZGHMFCR44KFONJRAXLTGSKP7ANCNFSM42GBIUSQ
.

Fixed the line, also removed the comments.


Signaling NaNs in Glulx

There's a test failure in Glulxercise with Glulxe linked to somewhat recent versions of Glibc, that I've been unable to track down for a long time. The four tests for edge cases of @pow having to do with NaN (pow(1, NaN); pow(1, -NaN); pow(NaN, 0); pow(-NaN, 0)) all fail because the @pow operation returns another NaN, which it's not supposed to.
I finally tracked it down to the definition of the NaNs used:
Constant M_NAN  = $7F800001; ! one of many NaN values
Constant M_NNAN = $FF800001; ! another, with a sign bit

These are 'signalling NaNs', because the most significant bit of the mantissa is 0. 'Quiet NaNs' would have a 1 bit there, e.g. $7FC00001. Signalling NaNs were added to the IEEE floating point standard much later so they're not very well known, but C compilers and standard libraries may treat them differently than quiet NaNs. Compilers generally have switches that can be used to turn the behaviour of signalling NaNs back into quiet NaNs. In this case, I was running into this code in Glibc, which special-cases powf(1, NaN) to return NaN if the input NaN is signalling, regardless of what the C compiler does with signalling NaNs.
So, the fix is to not trust the platform's powf() function (and probably pow() as well) and compile Glulxe with -DFLOAT_COMPILE_SAFER_POWF on Linux. I'm assuming we don't want to include the signalling NaN behaviour in the Glulx specification. It's too esoteric and is unlikely to be useful.
However, it might be nice to make Glulxe more robust against this little-known C standard library quirk on some platforms. I can think of a few possible actions to take:

Change the M_NAN and M_NNAN constants in glulxercise.inf to be quiet NaN bit patterns. This is essentially saying "we don't care, it's harmless if your stdlib has this quirk, but at least your tests won't fail."
Make it more obvious what the problem might be if glulxercise.inf fails: for example, test explicitly with both quiet and signaling NaNs so it's clear if one fails and the other doesn't, and add a line in glulxercise.inf suggesting compiling Glulxe with -DFLOAT_COMPILE_SAFER_POWF if the floatexp test fails.
Change Glulxe to just always use the safer powf() wrapper, and never use the platform's powf() directly; add a similar wrapper for pow().
Change Glulxe to turn signalling NaNs into quiet NaNs whenever encoding or decoding them for a float or double operation. As far as I can tell, it's possible to do this and still be conformant with the Glulx spec.

What do you think?

Are the tests not using the jisnan opcode, or is the opcode not working for these NaNs?

I'm pretty sure jisnan is working correctly. The problem is in executing the pow opcode. We decode the operands into 32-bit floats in C, and one of them is a signalling NaN which causes the call to glulx_powf() and the platform's powf() to misbehave.

Oh, I misunderstood the issue.
So the question is whether the defaults should be changed to be safer, or perhaps whether to make NaNs conform within Glulxe.
glulx_powf is a pretty cheap wrapper around powf, so it wouldn't hurt to always use it. But it's also quite easy to enable if needed. Option 4 would almost certainly be a much worse performance hit.

Using the glulx_powf() wrapper, and adding glulx_pow(), seems easiest. Done.


Make expiry checks friendly without active support helpers

Using this gem outside of rails yields a bunch of ArgumentError: comparison of Time with String failed exceptions when you try it in a testing environment.

Oh nice, thanks for this


✘ [ERROR] Could not resolve "@aws-sdk/client-dynamodb"

Have you experienced this bug with the latest version of the template?
yes
Steps to Reproduce
Ran  the following with alias pn=pnpm
valbaca@maxbook js % pn dlx create-remix@latest --template remix-run/grunge-stack

 remix   v2.12.1 💿 Let's build a better website...

   dir   Where should we create your new project?
         ./hello-grunge

      ◼  Template: Using remix-run/grunge-stack...
      ✔  Template copied

   git   Initialize a new git repository?
         Yes

  deps   Install dependencies with pnpm?
         Yes

  init   This template has a remix.init script. Do you want to run it?
         Yes

      ✔  Dependencies installed

      ✔  Git initialized
      ✔  Dependencies for remix.init script installed

      ◼  Running template's remix.init script...

? Do you want to run the build/tests/etc to verify things are setup properly? Yes

Expected Behavior
Successful startup after initial setup
Actual Behavior
valbaca@maxbook hello-grunge % pn dev

> hello-grunge-b2cc@ dev /Users/valbaca/Code/js/hello-grunge
> remix dev --manual -c "arc sandbox -e testing"

 💿  remix dev

⚠  Test routes enabled.
 info  building...
✘ [ERROR] Build failed with 4 errors:
node_modules/.pnpm/@architect+functions@8.1.6/node_modules/@architect/functions/src/tables/legacy.js:16:25: ERROR: Could not resolve "@aws-sdk/client-dynamodb"
node_modules/.pnpm/@architect+functions@8.1.6/node_modules/@architect/functions/src/tables/legacy.js:18:28: ERROR: Could not resolve "@aws-sdk/lib-dynamodb"
node_modules/.pnpm/@architect+functions@8.1.6/node_modules/@architect/functions/src/tables/legacy.js:24:25: ERROR: Could not resolve "aws-sdk/clients/dynamodb"
node_modules/.pnpm/@architect+functions@8.1.6/node_modules/@architect/functions/src/tables/legacy.js:57:40: ERROR: Could not resolve "@smithy/node-http-handler" [plugin css-bundle-plugin]

    app/root.tsx:20:30:
      20 │ import { cssBundleHref } from "@remix-run/css-bundle";
         ╵                               ~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onLoad" callback registered here:

    node_modules/.pnpm/@remix-run+dev@2.12.1_@remix-run+react@2.12.1_react-dom@18.3.1_react@18.3.1__react@18.3.1_typ_roc5sjsp5ppwfghrzndgv6kr4u/node_modules/@remix-run/dev/dist/compiler/plugins/cssBundlePlugin.js:35:12:
      35 │       build.onLoad({
         ╵             ~~~~~~

    at setup (/Users/valbaca/Code/js/hello-grunge/node_modules/.pnpm/@remix-run+dev@2.12.1_@remix-run+react@2.12.1_react-dom@18.3.1_react@18.3.1__react@18.3.1_typ_roc5sjsp5ppwfghrzndgv6kr4u/node_modules/@remix-run/dev/dist/compiler/plugins/cssBundlePlugin.js:35:13)
    at handlePlugins (/Users/valbaca/Code/js/hello-grunge/node_modules/.pnpm/esbuild@0.17.6/node_modules/esbuild/lib/main.js:1279:21)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

✘ [ERROR] Could not resolve "@aws-sdk/client-dynamodb"

    node_modules/.pnpm/@architect+functions@8.1.6/node_modules/@architect/functions/src/tables/legacy.js:16:25:
      16 │     let dynamo = require('@aws-sdk/client-dynamodb')
         ╵                          ~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "@aws-sdk/client-dynamodb" as external to exclude it from the bundle, which will remove this error. You can also surround this "require" call with a try/catch block to handle this failure at run-time instead of bundle-time.

✘ [ERROR] Could not resolve "@aws-sdk/lib-dynamodb"

    node_modules/.pnpm/@architect+functions@8.1.6/node_modules/@architect/functions/src/tables/legacy.js:18:28:
      18 │     let docclient = require('@aws-sdk/lib-dynamodb')
         ╵                             ~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "@aws-sdk/lib-dynamodb" as external to exclude it from the bundle, which will remove this error. You can also surround this "require" call with a try/catch block to handle this failure at run-time instead of bundle-time.

✘ [ERROR] Could not resolve "aws-sdk/clients/dynamodb"

    node_modules/.pnpm/@architect+functions@8.1.6/node_modules/@architect/functions/src/tables/legacy.js:24:25:
      24 │     let dynamo = require('aws-sdk/clients/dynamodb')
         ╵                          ~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "aws-sdk/clients/dynamodb" as external to exclude it from the bundle, which will remove this error. You can also surround this "require" call with a try/catch block to handle this failure at run-time instead of bundle-time.

✘ [ERROR] Could not resolve "@smithy/node-http-handler"

    node_modules/.pnpm/@architect+functions@8.1.6/node_modules/@architect/functions/src/tables/legacy.js:57:40:
      57 │       let { NodeHttpHandler } = require('@smithy/node-http-handler')
         ╵                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "@smithy/node-http-handler" as external to exclude it from the bundle, which will remove this error. You can also surround this "require" call with a try/catch block to handle this failure at run-time instead of bundle-time.

I'm new to Remix Stacks, so not sure if this is known or not, figured I'd Open an Issue first.
I'm guessing it's an outdated architect and/or incompatibility  with dynamodb

Same issue when running with npx.
macOS, node v22.9.0

del node mods, and lock file, re install ?

I have this exact issue on a new project (using npx). Not sure where to go from here...
Is this still an active project? Are others NOT getting these errors on new installs? This repo is referenced as an official stack on the remix website so I presumed it would just work out of the box but I never got past the first command: npx create-remix@latest --template remix-run/grunge-stack. The same things happens if you run npm run dev.
Removing /node-modules and /package-lock.json and reinstalling npm install does not solve the issue.
I'm using node v22.8.0

The repo hasn't been updated in a while, there is an open vite pr too that has been sitting around for months. I would prob start with SST instead

I read the migration from architecture 10 to 11 and included a couple of new devDependencies needed
    "@aws-sdk/client-apigatewaymanagementapi": "^3.713.0",     "@aws-sdk/client-dynamodb": "^3.713.0",     "@aws-sdk/client-s3": "^3.713.0",     "@aws-sdk/client-sns": "^3.713.0",     "@aws-sdk/client-sqs": "^3.713.0",     "@aws-sdk/client-ssm": "^3.713.0",     "@aws-sdk/lib-dynamodb": "^3.713.0",
and the browserPolyfill config in the remix.config file
browserNodeBuiltinsPolyfill: { modules: { querystring: true } },
As of now, i run npm run dev after following previous instructions from readme file, and it worked.
Hope it helps


It would be nice to be able to inherit the Ok and Err Result classes

I currently have a client that returns my own (very similar) Result object:
public function resolve(MyOwnNamespace\Client\Request $request): MyOwnNamespace\Client\Result

Ok/Err are marked final, which makes sense. However, being able to extend them would drastically reduce the diffs and footprint of this library as a dependency. For example,
namespace MyOwnNamespace\Client\Result;

class Err extends \TH\Maybe\Result\Err implements \MyOwnNamespace\Client\Result

This would import all the functionality of \TH\Maybe\Result\Err, and prevent the need to change function signatures all throughout the app. Thoughts on making this change?

I wondered about allowing this too :thinking: but I don't want to make it possible that child classes misbehave (eg: making them return true for both isOk() and isErr())
But I just realized I can make the methods final instead of the whole class. I guess that could work. I'll give it a try

Hi @MattyRad, you can now extend Ok & Err, I have, however, marked all existing methods and the constructor as final to guarantee that subclasses can't change the desired behavior.
Please let me know if that works for you if you can try it!

Thanks, works great! If you're interested, here is a (redacted) snippet of how I'm using it:
<?php

use TH\Maybe;

/**
 * @template E
 *
 * @extends Maybe\Result\Err<E>
 * @implements MyOwnNamespace\Result<never, E>
 */
final class Err extends Maybe\Result\Err implements MyOwnNamespace\Result
{
    /**
     * @return self<MyHttpException>
     */
    private static function make(int $http_code, ?string $detail): self
    {
        $error = new MyHttpException(...[
            'http_code' => $http_code,
            'detail' => $detail,
        ]);

        return new self($error);
    }

    /**
     * @return self<MyHttpException>
     */
    public static function BAD_REQUEST(?string $detail = null): self
    {
        return self::make(400, $detail);
    }

    /**
     * @return self<MyHttpException>
     */
    public static function UNPROCESSABLE_ENTITY(?string $detail = null): self
    {
        return self::make(422, $detail);
    }

    /** more http codes ... */
}

/**
 * @return MyOwnNamespace\MyClient\Result<HttpResource, RejectedRequestException>
 */
public function resolve(MyClient\Request $request): MyClient\Result
{
    if (true /*or whatever */) {
        return new MyOwnNamespace\MyClient\Result\Ok("👍");
    }

    return Err::UNPROCESSABLE_ENTITY("It's wrong, yo.");
}

$result = $this->client->resolve($request);

// TODO: use some of the TH\Maybe\Result internal functions to remove the try/catch
try {
    $duckey = $result->unwrap();
} catch (MyHttpException) {
    $my_exception = $result->unwrapErr();
    $http_code = $error->http_code; // No static analysis errors! Nice!
}

interesting :) thx for sharing!


feat/resume

Please review before merging.

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Show accessions per project

┆Issue Number: HCAB-390

Needs indexing.

This requires changes to metadata-api, Azul and data-browser itself.

Azul changes deployed to dev - @frano-m you are good to go.


Review the section on ISO19115

Following integration of ISO19115 records from NILU and PPD the section on ISO19115 encoding should be updated. Particular focus should be on how to reflect:

which vocabulary that is used for free text fields like URLs, keywords etc
how to encode landing pages for datasets (using online resource in either data or citation sections
how to encode information on the relevant data centre
how to properly identify the purpose of URLs

As some partners serving ISO19115 are using GeoNetwork there are some limitations of this that has to be considered/evaluated.

This is ongoing.

Updated, closing.


Add container short- and longhands

Related issue: https://github.com/ryboe/CSS3/issues/184
This PR adds the container properties; the shorthand, container, and the longhands, container-name and container-size.
Should I add tests for these?

should I add tests for these?

they're always welcome and pretty straight forward to add 👍🏻

local tests of this look good 👍🏻

How do I go about that? Just list them in properties-list.py for each value?

So I did add the property-value combinations to properties-list.py - not sure how the testing actually works and whether I should be adding things to syntax_test_properties_c. Also I did notice that the highlighting for property values seems to just ignore order, but that may be by design. For example, if you do container: foo / none; then the none is technically not valid but gets highlighted as such since it'd be valid before the /. This behavior is already present in much older properties, though; if I name an animation alternate, it gets highlighted in an animation declaration as a keyword, even if it is used as ident.
If the lack of support for the value order is by design, then this PR is ready for another round of review; otherwise, please point me in the right direction.
As a sidenote, if it is by design, then my font shorthand PR would also be ready for review, since it suffers from the same issue.

If the lack of support for the value order is by design

I can't answer this, but the original package author can if he's willing: cc @ryboe

If the lack of support for the value order is by design

It was simply much harder to write regexes that enforce value order. Many of the regexes I was trying to write were so complicated that they were impossible to read or debug. So I gave up trying. I sacrificed the ability to detect out-of-order errors for regex simplicity.
That was the best I could do at the time, but this is not a law or anything. If there are certain properties where you think value order can be enforced and the regexes aren't too complicated, please feel free to write them the way you think is best 🙂

I honestly don't think it is worth the effort either; it seems unlikely people give their container the name inline-size or any of the other identifiers for container-type; and even if they do, having it highlight as a keyword instead of an ident is not the end of the world.


Hangman Puzzle Game

Project title
Hangman Puzzle Game
Project Description
create a hangman puzzle game that uses the JavaScript Fetch API to retrieve new puzzles from the given API endpoint.
Stack:
And in order to tick the check box just but x inside them for example - [x] like this. Please delete options that are not relevant.

[x] Html
[x] CSS
[x] JavaScript
[ ] ReactJS

/assign


⚠ Samsung has degraded performance

In 7be5957, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3202 ms

Resolved: Samsung performance has improved in a322b6c.


Update COC version

@vinzvinci updated readme.

I revert it. I thought u edit COC file. You're doing it wrong, please follow the instructions here.


Add tox as a dev dependency

tox is the tool used to run the tests both locally and in the CI pipeline, but it is not added as a dependency in any of the requirement files. Therefore, it has to be installed manually and every time the environment is synced using pip-sync requirements/dev.txt, it is removed from the environment.
This commit adds tox in the test.txt requirement file (and therefore in the dev.txt file which depends on it). A couple of packages have also been updated (namely packaging and platformdirs) to avoid conflicts with the dependencies of tox.

The point of having tox in the virtual environment is to ensure that anyone who runs the environment will have the exact same version of the package, ensuring reproducibility. If I were to install tox in an OS other than Fedora 39, the version might be different and things may not work as expected. The same logic applies to all packages that are run in the environment.
As for the CI pipeline using an image with tox pre-installed, I don't really see the point of doing it that way. Why don't we use the same environment as the one used for developing, specifying the version in the requirements, to make it consistent and reproducible? In fact, it's possible that this could be the cause of what happens in #736, where a test fails locally but not in the CI.

@juspence I've modified the dependency to be inside dev.txt instead of test.txt. The issue of making it consistent with the tox version run in the CI will be tackled in a different PR in the future.


TokenTextEncoder does not respect reserved tokens

I get poor results for translate_ende_wmt_bpe32k (this may be related to issues #317 , #309 ), and believe this is due to a problem with reserved tokens not being respected by TokenTextEncoder, and the provided vocabulary file.

INFO:tensorflow:Inference results INPUT: In this sense , the measures will partially undermine the American democratic system .
INFO:tensorflow:Inference results OUTPUT: In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In In
In In In In In

{'outputs': array([68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68,
68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68,
68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68,
68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68,
68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68, 68], dtype=int32), 'problem_choice': 0, 'inputs': array([[   68],
[   35],
[ 2196],
[    0],
[    2],
[  651],
[   55],
[18587],
[15840],
[    2],
[ 1874],
[ 1763],
[  260],
[    1],
[    1],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0]], dtype=int32)}

The first 10 lines of vocab.bpe.32000 look like this:

,
.
the
in
of
and
die
der
to
und

Note that "," and "." get assigned the indices 0 and 1, conflicting with the reserved tokens.
I started a new training run with a modified vocab:

pad
eos
,
.
the
in
of
and
die
der

and this gives better results (model hasn't converged yet):

INFO:tensorflow:Inference results INPUT: In this sense , the measures will partially undermine the American democratic system .
INFO:tensorflow:Inference results OUTPUT: In diesem Sinne wird die Maßnahmen in der Lage sein , das amerikanische System zu bekämpfen .

{'outputs': array([   54, 11958,    11, 10408,   164,   231,   940,    92,  2802,
9, 12051,  7944,     3,     1,     0,     0,     0,     0,
0,     0,     0,     0,     0,     0,     0,     0,     0,
0,     0,     0,     0,     0,     0,     0,     0,     0,
0,     0,     0,     0,     0,     0,     0,     0,     0,
0,     0,     0,     0,     0,     0,     0,     0,     0,
0,     0,     0,     0], dtype=int32), 'problem_choice': 0, 'inputs': array([[24820],
[   22],
[ 3467],
[ 8753],
[  111],
[  322],
[   48],
[    4],
[  229],
[   10],
[ 4995],
[14095],
[ 7298],
[    3],
[    1],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0],
[    0]], dtype=int32)}

I'd suggest that TokenTextEncoder actually reserves the first two integers for reserved tokens, and starts counting from 2, but I realize this will break compatibility with trained models. Alternatively, you could fix the vocabularies of pre-defined problems - I don't know how many are affected.

are you using your regular BPE ?
with the out-of-the-box subwords script the vocab.endefr.32768 file is as follow:
''
''
', '
'.'
'the_'
'de_'
''
'''
'in_'
'of_'

They seem to refer to regular BPE.
My BPE vocab also starts with , and . like Rico's but I didn't experience any issues with not including pad and eos. I trained my BPE model back on T2T 1.0.11.

I'm using the problem translate_ende_wmt_bpe32k , which out-of-the-box downloads and uses vocab.bpe.32000 (in v1.2.4).

@Rico: Just wondering how did you manage to get a translation result in your second example using a BPE. The input has only been tokenized and not preprocessed with BPE. When using the BPE model I think T2T requires you to tokenize as well as apply BPE before submitting for translation.

Does this problem still exist in 1.2.5? We tried to correct the reserved tokens in vocabs, but maybe there's still sth missing?

@mehmedes : the preprocessed test sets are in /tmp/t2t_datagen (or wherever you downloaded wmt16_en_de.tar.gz ), for instance as newstest2013.tok.bpe.32000.en . From a quick look at the data, the files were (probably) preprocessed like this:

/path/to/mosesdecoder/scripts/tokenizer/normalize-punctuation.perl -l en | \
/path/to/mosesdecoder/scripts/tokenizer/tokenizer.perl -l en | \
/path/to/subword-nmt/apply_bpe.py -c bpe.32000

@lukaszkaiser : there's been no change to the vocabs or the handling of reserved tokens between 1.2.4 and 1.2.5 - yes, the problem still persists.

I was asking because your input stated a clean sentence

INFO:tensorflow:Inference results INPUT: In this sense , the measures will partially undermine the American democratic system .

I would have expected the input to be more like
INFO:tensorflow:Inference results INPUT: In th@@ sen@@ etc.

Coincidentally, all words in this sentence happen to be frequent in the training data.

The behavior of TokenTextEncoder with regards to reserved tokens depends on whether it is constructed from a file or from a list. If it is constructed from a file, then it's expected that the file includes reserved tokens (i.e. the first line is <pad> and the second line is <EOS>) if there are any. If it's from a list, then the reserved tokens are added. The reason is because if you initialize from a list and then call store_to_file, the file will include the reserved tokens.


Fix RBAC on example file: service account requires get to ConfigMap

The existing example yaml does not define the RBAC for getting the ConfigMap that contains the configuration.
Please note that a least privileged approach was chosen, the service account will only be able to get the ConfigMap aws-iam-authenticator.

/assign @micahhausler


Does not install

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the bug has not already been reported

Fastify version
v3.29.0
Plugin version
master
Node.js version
16.x
Operating system
macOS
Operating system version (i.e. 20.04, 11.3, 10)
latest
Description
If I clone this repository and  run npm i I get:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/fastify
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/aws-serverless-fastify
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

I'm on npm v8.5.5.
Steps to Reproduce
see above
Expected Behavior
No response

I think nothing we can do here.
Or just remove aws-serverless-fastify from benchmark.
https://github.com/benMain/aws-serverless-fastify/blob/master/package.json#L70

let's do that then?

or use --force, like here: https://github.com/fastify/aws-lambda-fastify/blob/master/.github/workflows/ci.yml#L30

ok, I've found an alternative solution: https://github.com/fastify/aws-lambda-fastify/commit/db86c28298b2733a33f7ee5e5f5ac1e094121c52
thanks to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides


why options in session_config like intra_op_parallelism_threads/inter_op_parallelism_threads doesn't work in tensorflow estimator distribution mode？

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):just tried to import it.
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):CentOS Linux release 7.2
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):binary
TensorFlow version (use command below):1.7 to 1.10
Python version:2.7
Bazel version (if compiling from source):N/A
GCC/Compiler version (if compiling from source):N/A
CUDA/cuDNN version:N/A
CPU model and memory:Intel(R) Xeon(R) CPU E5-2670 v3 @ 2.30GHz,128G
Exact command to reproduce:N/A

Describe the problem
when i set intra_op_parallelism_threads/inter_op_parallelism_threads for estimator dist mode like this:
config = tf.ConfigProto() config.intra_op_parallelism_threads = 4 config.inter_op_parallelism_threads = 4 run_config = tf.estimator.RunConfig().replace(session_config=config) model = tf.estimator.DNNLinearCombinedClassifier(             model_dir=model_dir,             linear_feature_columns=wide_columns,             dnn_feature_columns=deep_columns,             dnn_hidden_units=hidden_units,             config=run_config)
it doesn't work, i find the options isn't passed to kernals:
tensorflow/python/estimator/training.py
if config.session_config is None:   session_config = config_pb2.ConfigProto(log_device_placement=False) else:   session_config = config_pb2.ConfigProto( 	  log_device_placement=False, 	  gpu_options=config.session_config.gpu_options)
only a few options are set, the code above indicate intra_op_parallelism_threads/inter_op_parallelism_threads have no effect，is a bug？why？

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

@skye I suppose the user needs to switch to GraphRunner in this case?

Nagging Assignee @jart: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jart: It has been 45 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jart: It has been 61 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jart: It has been 76 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Can you please take a look at this PR and see if it helps?
https://github.com/tensorflow/models/pull/5046/files#diff-a418c41de193111b623e6c168f552206R51
The above PR was effective for wide and deep in github.com/tensorflow/models


Add clippy and nightly for travis.

r? @Fraser999
(maidsafe_highfive has picked a reviewer for you, use r? to override)

r? @Fraser999

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


bettercap: 2.11 -> 2.24

Motivation for this change

2.24: https://github.com/bettercap/bettercap/releases/tag/v2.24
...
2.11: https://github.com/bettercap/bettercap/releases/tag/v2.11

Seems to work?
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Duplicate of #61154

@c0bw3b can we re-open this PR?
It is better than the other one I created earlier.

Sure


Load an already created form into FormBuilder

I have the data one gets in JSON format when a form is created. What if the user wishes to open a previously created form and further edit it? How does one go about doing that? Which function or component in FormBuilder.js does one need to work with?

BuilderView.prototype.initialize = function(options) {
var selector;
selector = options.selector,
this.formBuilder = options.formBuilder,
this.bootstrapData = options.bootstrapData;
if (selector != null)
{
this.setElement($(selector));
}
this.collection = new FormbuilderCollection;
this.collection.bind('add', this.addOne, this);
this.collection.bind('reset', this.reset, this);
this.collection.bind('change', this.handleFormUpdate, this);
this.collection.bind('destroy add reset', this.hideShowNoResponseFields, this);
this.collection.bind('destroy', this.ensureEditViewScrolled, this);
this.render();
this.collection.reset(this.bootstrapData);
return this.bindSaveEvent();
};
This is the new code and I am creating a meanJS application. Based on your code it seems like I have to send data into this function by options.bootstrapData.


Crash on webpage after safari restart

I was looking at an MSA and got this when I restarted my machine and safari remembered the page:
An error occured
ERROR
Cause: javax.portlet.PortletException: org.apache.jasper.JasperException: An exception occurred processing JSP page /WEB-INF/jsp/msa.jsp at line 28 25: ObjectMapper objectMapper = new ObjectMapper(); 26: ObjectReader jsonReader = objectMapper.reader(Map.class); 27: 28: Map<String, String> key = jsonReader.readValue(SessionHandler.getInstance().get(SessionHandler.PREFIX + pk)); 29: if (key != null) { 30: featureIds = key.get("featureIds"); 31: figfamId = key.get("figfamId"); Stacktrace:
Message: org.apache.jasper.JasperException: An exception occurred processing JSP page /WEB-INF/jsp/msa.jsp at line 28 25: ObjectMapper objectMapper = new ObjectMapper(); 26: ObjectReader jsonReader = objectMapper.reader(Map.class); 27: 28: Map<String, String> key = jsonReader.readValue(SessionHandler.getInstance().get(SessionHandler.PREFIX + pk)); 29: if (key != null) { 30: featureIds = key.get("featureIds"); 31: figfamId = key.get("figfamId"); Stacktrace:
See log for stacktrace

I suspect this may have something to do with data saved in session/cookie.
Andrew, see if any action needed or close the ticket.

Yes this is a session based error. Results are thrown out for MSA once a day. We need to convert the system over to running on the cluster and think about whether we want to make them persistent.


Temporary Dangerfile

Hi @orta, this works now, taken from https://github.com/Themoji/danger/blob/master/Dangerfile

Awesommmme

Closed


Cannot install app from testflight

Used ios instruction, build is going ok, w/o any problems is deployed to testflight
But cannot install from testflight, shows message, that error occurs while installing
cd "${SRCROOT}/.symlinks/plugins/freerasp/ios" if [[ "${CONFIGURATION}" =~ "Release" ]]; then     rm -rf ./TalsecRuntime.xcframework     ln -s ./Release/TalsecRuntime.xcframework/ TalsecRuntime.xcframework else     rm -rf ./TalsecRuntime.xcframework     ln -s ./Debug/TalsecRuntime.xcframework/ TalsecRuntime.xcframework fi
"The app cannot be installed because its integrity could not be verified"

Hello @ilia-grishakov-m10 ,

What is the build configurations you use? Is it Debug/Release, or some other configurations?
When you remove freeRASP, are you able to install the app? It might be due to Developer ID Notary Service - Outage, please verify this.
Could you show us how you integrated the above script in the Xcode?

Kind regards,
Talsec team

Hello @ilia-grishakov-m10 , according to Apple System Status, it should be now OK.
Were you able to resolve your issue?
Kind regards,
Talsec developer


Add a CURL Command Section

In order to help people see the raw output behind the EventSource Demo there can be an inclusion of a CURL command section which people can copy for the future.

Added a Basic cURL command section


New term request: nanogram/microliter, ng/ul

For biological experiments, it is quite common to specify concentrations in nanogram/microliter with the synonym ng/ul. Would it be possible to add it to this ontology?
And if so, what would be the best process?

Hello, have added the unit with the term ID UO:0010050. Thank you for the suggestion!


Deduplicate concurrent calls to bot.init

If one does
bot.start()
await bot.init()

then this would make grammY perform two identical calls to getMe.
This PQ optimizes the above scenario. Any number of calls will be deduplicated automatically, so that all promises resolve at the same time when the first getMe call completes.
In addition, the initialization via bot.init is made more robust by automatically retrying the API call if there are network issues. Previously, this was only the case for init calls done via bot.start.

@all-contributors add @drmikecrowe for their review!


build: use package.json to manage semantic-release ...

... and its dependencies.
Signed-off-by: Subin Shekhar<EMAIL_ADDRESS>PR summary
use package.json to manage semantic-release
Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[x] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 2.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Website Whitelist?

For blacklisting websites, we currently have a blacklisted website file, and Smokey has a command to add to it. For whitelisting websites, we have to submit a pull request to add to findspam.
Could a whitelist file and command be added to Smokey?
Obviously we would need to set some criteria first, such as how many fp's the website is getting to qualify for whitelisting etc. I'm thinking about websites such as regex101 and similar

A partial whitelist already exists here, but this would definitely be a good addition.

I'm going to merge this for now, but I think in future it might be a good idea to start work on a global whitelist (#490) which doesn't only work for LAEOA

See #490


trufflehog pre-commit check fails when pushing new branches

Describe the bug
Pushing up a new branch fails the trufflehog pre-commit check with:
Traceback (most recent call last):
  File "/Users/jacobhayes/src/github.com/artigraph/artigraph/.direnv/python-3.9.7/bin/trufflehog", line 8, in <module>
    sys.exit(main())
  File "/Users/jacobhayes/src/github.com/artigraph/artigraph/.direnv/python-3.9.7/lib/python3.9/site-packages/truffleHog/truffleHog.py", line 92, in main
    output = find_strings(args.git_url, args.since_commit, args.max_depth, args.output_json, args.do_regex, do_entropy,
  File "/Users/jacobhayes/src/github.com/artigraph/artigraph/.direnv/python-3.9.7/lib/python3.9/site-packages/truffleHog/truffleHog.py", line 337, in find_strings
    branches = repo.remotes.origin.fetch()
  File "/Users/jacobhayes/src/github.com/artigraph/artigraph/.direnv/python-3.9.7/lib/python3.9/site-packages/git/remote.py", line 792, in fetch
    res = self._get_fetch_info_from_stderr(proc, progress)
  File "/Users/jacobhayes/src/github.com/artigraph/artigraph/.direnv/python-3.9.7/lib/python3.9/site-packages/git/remote.py", line 688, in _get_fetch_info_from_stderr
    with open(osp.join(self.repo.common_dir, 'FETCH_HEAD'), 'rb') as fp:
FileNotFoundError: [Errno 2] No such file or directory: '/var/folders/ss/tgmzwbx52y35qpr7rzrtv8ym0000gn/T/tmpsxmkab_e/.git/FETCH_HEAD'

To Reproduce
Create a new branch, add a commit, and git push -u origin <branchname>

Removed from pre-commit in https://github.com/artigraph/artigraph/commit/0808f6dba97f469be4764458fa898b432fc79faf. It's still run in CI for each commit.


When running bin/setup on Mint 21.2 I get a load error re: charlock_holmes

Similar to #103. When I run bin/setup on my machine I get the following error:
LoadError: libicudata.so.73: cannot open shared object file: No such file or directory - /home/<me>/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/charlock_holmes-0.7.7/lib/charlock_holmes/charlock_holmes.so
Here is my system info from inxi:
System:   Kernel: 5.15.0-76-generic x86_64 bits: 64 compiler: gcc     v: 11.3.0 Desktop: Cinnamon 5.8.4 Distro: Linux Mint 21.2 Victoria     base: Ubuntu 22.04 jammy
I have icu4c installed via brew: icu4c: stable 73.2
I have libicu-dev installed via apt.
What else could I try, since upgrading to the latest Ubuntu isn't really an option if I wish to stay on Mint?

@afittro You might try this suggestion from a similar issues on the charlock_holmes repo: https://github.com/brianmario/charlock_holmes/issues/156#issuecomment-789790455
bundle pristine charlock_holmes

oh, good idea. I actually never thought of using pristine within bundler.
But alas, after doing that the error remains. Thank you for the suggestion and for helping me grow :)

@afittro, did you ever this this straightened out?

No. I had the problem initially without the apt-installed libicu-dev. I just had the brew install of icu4c. I only added the apt install as an attempt to resolve the issue.

having the same issue on mac m1 and ruby 3.2.4

@shaunakv1 You might try doing this:
BUNDLE_BUILD__CHARLOCK_HOLMES="--with-cxxflags=-std=c++17" bundle install

It was suggested in a thread on the charlock_holmes repo:
https://github.com/brianmario/charlock_holmes/issues/172#issuecomment-2200579820

This is still failing for me:
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /usr/share/rvm/gems/ruby-3.3.4/gems/charlock_holmes-0.7.9/ext/charlock_holmes
/usr/share/rvm/rubies/ruby-3.3.4/bin/ruby extconf.rb --with-cxxflags\=-std\=c++17
checking for pkg-config for icu-i18n... [" ", "", "-licui18n -licuuc -licudata"]
checking for pkg-config for icu-io... [" ", "", "-licuio -licui18n -licuuc -licudata"]
checking for pkg-config for icu-uc... [" ", "", "-licuuc -licudata"]
checking for -licui18n... yes
checking for unicode/ucnv.h... yes
checking for -lz... yes
checking for -licuuc... yes
checking for -licudata... yes
checking for icu that requires explicit C++ version flag... yes
checking for icu that compiles with c++20 standard... no
checking for icu that compiles with c++17 standard... no
checking for icu that compiles with c++11 standard... no
checking for icu that compiles with c++0x standard... no
Cannot compile icu with your compiler: recent versions require C++17 support.
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
	--with-opt-dir
	--without-opt-dir
	--with-opt-include=${opt-dir}/include
	--without-opt-include
	--with-opt-lib=${opt-dir}/lib
	--without-opt-lib
	--with-make-prog
	--without-make-prog
	--srcdir=.
	--curdir
	--ruby=/usr/share/rvm/rubies/ruby-3.3.4/bin/$(RUBY_BASE_NAME)
	--with-icu-dir
	--without-icu-dir
	--with-icu-include=${icu-dir}/include
	--without-icu-include
	--with-icu-lib=${icu-dir}/lib
	--without-icu-lib
	--with-icu-i18n-dir
	--without-icu-i18n-dir
	--with-icu-i18n-include=${icu-i18n-dir}/include
	--without-icu-i18n-include
	--with-icu-i18n-lib=${icu-i18n-dir}/lib
	--without-icu-i18n-lib
	--with-icu-i18n-config
	--without-icu-i18n-config
	--with-pkg-config
	--without-pkg-config
	--with-icu-io-dir
	--without-icu-io-dir
	--with-icu-io-include=${icu-io-dir}/include
	--without-icu-io-include
	--with-icu-io-lib=${icu-io-dir}/lib
	--without-icu-io-lib
	--with-icu-io-config
	--without-icu-io-config
	--with-icu-uc-dir
	--without-icu-uc-dir
	--with-icu-uc-include=${icu-uc-dir}/include
	--without-icu-uc-include
	--with-icu-uc-lib=${icu-uc-dir}/lib
	--without-icu-uc-lib
	--with-icu-uc-config
	--without-icu-uc-config
	--with-icui18n-dir
	--without-icui18n-dir
	--with-icui18n-include=${icui18n-dir}/include
	--without-icui18n-include
	--with-icui18n-lib=${icui18n-dir}/lib
	--without-icui18n-lib
	--with-icui18nlib
	--without-icui18nlib
	--with-unicode-dir
	--without-unicode-dir
	--with-unicode-include=${unicode-dir}/include
	--without-unicode-include
	--with-unicode-lib=${unicode-dir}/lib
	--without-unicode-lib
	--with-z-dir
	--without-z-dir
	--with-z-include=${z-dir}/include
	--without-z-include
	--with-z-lib=${z-dir}/lib
	--without-z-lib
	--with-zlib
	--without-zlib
	--with-icuuc-dir
	--without-icuuc-dir
	--with-icuuc-include=${icuuc-dir}/include
	--without-icuuc-include
	--with-icuuc-lib=${icuuc-dir}/lib
	--without-icuuc-lib
	--with-icuuclib
	--without-icuuclib
	--with-icudata-dir
	--without-icudata-dir
	--with-icudata-include=${icudata-dir}/include
	--without-icudata-include
	--with-icudata-lib=${icudata-dir}/lib
	--without-icudata-lib
	--with-icudatalib
	--without-icudatalib

To see why this extension failed to compile, please check the mkmf.log which can be found here:

  /usr/share/rvm/gems/ruby-3.3.4/extensions/x86_64-linux/3.3.0/charlock_holmes-0.7.9/mkmf.log

extconf failed, exit code 1

Gem files will remain installed in /usr/share/rvm/gems/ruby-3.3.4/gems/charlock_holmes-0.7.9 for inspection.
Results logged to /usr/share/rvm/gems/ruby-3.3.4/extensions/x86_64-linux/3.3.0/charlock_holmes-0.7.9/gem_make.out

  /usr/share/rvm/rubies/ruby-3.3.4/lib/ruby/3.3.0/rubygems/ext/builder.rb:125:in `run'
  /usr/share/rvm/rubies/ruby-3.3.4/lib/ruby/3.3.0/rubygems/ext/ext_conf_builder.rb:28:in `build'
  /usr/share/rvm/rubies/ruby-3.3.4/lib/ruby/3.3.0/rubygems/ext/builder.rb:193:in `build_extension'
  /usr/share/rvm/rubies/ruby-3.3.4/lib/ruby/3.3.0/rubygems/ext/builder.rb:227:in `block in build_extensions'
  /usr/share/rvm/rubies/ruby-3.3.4/lib/ruby/3.3.0/rubygems/ext/builder.rb:224:in `each'
  /usr/share/rvm/rubies/ruby-3.3.4/lib/ruby/3.3.0/rubygems/ext/builder.rb:224:in `build_extensions'
  /usr/share/rvm/rubies/ruby-3.3.4/lib/ruby/3.3.0/rubygems/installer.rb:852:in `build_extensions'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/rubygems_gem_installer.rb:72:in `build_extensions'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/rubygems_gem_installer.rb:28:in `install'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/source/rubygems.rb:200:in `install'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/installer/gem_installer.rb:54:in `install'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/installer/gem_installer.rb:16:in `install_from_spec'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/installer/parallel_installer.rb:156:in `do_install'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/installer/parallel_installer.rb:147:in `block in worker_pool'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/worker.rb:62:in `apply_func'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/worker.rb:57:in `block in process_queue'
  <internal:kernel>:187:in `loop'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/worker.rb:54:in `process_queue'
  /usr/share/rvm/gems/ruby-3.3.4/gems/bundler-2.4.10/lib/bundler/worker.rb:90:in `block (2 levels) in create_threads'

An error occurred while installing charlock_holmes (0.7.9), and Bundler cannot continue.

In Gemfile:
  bullet_train-incoming_webhooks was resolved to 1.7.21, which depends on
    bullet_train-api was resolved to 1.7.21, which depends on
      bullet_train was resolved to 1.7.21, which depends on
        extended_email_reply_parser was resolved to 0.5.1, which depends on
          charlock_holmes

I think this is ultimately an issue with charlock_holmes and I don't think there's really anything we can do about it. I'm going to close this issue.
If someone can come up with some consistent reproduction steps please post them here and feel free to reopen this issue.


I have a 16 line VELODYNE lidar. How can I directly access this system?

I have a 16 line VELODYNE lidar. How can I directly access this system?

Hey @ytgcljj you should be able to use this node if you can record a ROS bag file with your VLP 16.


There was no story, so I didnt add any, just some inspiration

You didn't write any story so I just filled in something random. You are free to ask me to do any change you like before approving!

If there's nothing else you're curious to try, I'll just close this part of the homework.


Revert custom sharding WAR

Is this just a reminder like #477?

Is this just a reminder like #477?

Yes

The WAR is not needed anymore since a proper fix landed: https://github.com/openxla/xla/pull/8896

Workaround should no longer be needed following https://github.com/openxla/xla/pull/8896. @jaro-sevcik checked this morning.


[Unit Tests] Utils: hasProperty

Need to make a unit test for hasProperty utils

I'm attempting...

um... where's the hasProperty file lol
cant seem to find it in src/util

review #1381


Node labels in the graph should be shown conditionally

Only show labels for nodes that have incoming edges.

published in the latest version of the browser


Local 0 fields removed

programming so it does not put "0" in fields Loc_Unit_Label_Text and Loc_Unit_Nbr when the phone number matches to CityFone, but CityFone doesn't provide a valid number.  It should just leave those fields blank.

Thanks, Hunter!  Between now and next week, I would appreciate your changing the programming so it does not put "0" in fields Loc_Unit_Label_Text and Loc_Unit_Nbr when the phone number matches to CityFone, but CityFone doesn't provide a valid number.  It should just leave those fields blank.


Map: Need backend endpoint which for an arbitrary number of variables and their configuration can indicate missingness

the title isnt great, so ill try to explain. we are introducing an ez time filter, where the user can choose a temporal variable and define a range (or maybe ranges) to filter over without having to enter the menu. for that we are introducing a new component (see https://github.com/VEuPathDB/web-monorepo/issues/245) which among other things needs to indicate for which values that temporal variable has data visible on the map.
this endpoint needs to know which variable is the temporal variable of primary interest, as well as how the map markers are configured, in order to do this. exact api tbd.

This is an interesting problem. My initial thought is for the API to return a list of ranges for which data is present. The problem with this is that the response size could be proportional to the range of the variable values. This would only be possible if, for example, every other time unit has data and we return each individual data point as a discrete range. Likely, the desired behavior in this scenario would be to return the entire range.
This suggests the need for some kind of threshold to indicate the maximum time gap before breaking up an interval. We could set this threshold based on the range of the temporal variable values to ensure we don't have an unreasonable number of intervals in our response (e.g. if the study is over 5 years, only break up an interval if 5 days are missing).
Have we decided the granularity of ranges for the time picker? Is it ever going to be more granular than days? I'm guessing not, because I'm not aware of any studies that have datetimes.

another possible complication is that presence or absence of data depends in part on how the map markers are configured, and configuration can vary per map type. ill put some thought to these things and hopefully comment again later.

i was thinking about this some more, and its possible the concern about different map types having different configuration can be handled using filters? like presumably the things that impact whether there is data visible on the map are always: 1) marker variable selections 2) values selected for those variables and 3) the viewport.
im also currently inclined for dates to maybe assume day granularity? so the response would literally just list each day and a value of 0 or 1.

As you suggested, it seems like the distributions endpoint could be pretty serviceable for your requirements listed above. If we wanted to save some data transmission, we could add an option to omit the zero values. I agree that all the marker types should have enough in common to provide:

geo filters
temporal variable spec

Here's an example example request to distributions:
{
    "valueSpec": "count",
    "filters": [
        {
            "entityId": "GAZ_00000448",
            "type": "longitudeRange",
            "variableId": "OBI_0001621",
            "left": -88.681640625,
            "right": -70.30664062
        }
    ],
    "binSpec": {
        "displayRangeMin": "2020-05-19T00:00:00Z",
        "displayRangeMax": "2022-12-17T00:00:00Z",
        "binWidth": 1,
        "binUnits": "day"
    }
}

nice. then if the markers were configured w varX, values 1,2,3 those could be passed as part of the filters as well. so the question is to the frontend: @bobular @moontrip , are you happy to use the distributions endpoint (passing the viewport and marker vars as filters) and collapse any count > 1 to 1?

Yes, I think this would work, thanks.  I think we might add a client-side heuristic to bin at week or month as required. We have some 40+ year datasets.
@d-callan @dmgaldi

Oh, but we wouldn't know what the full date range was until we had already made the request?

ranges should be in the study metadata for that variable. that, plus any filters applied to that variable, should tell you what range to show for the xaxis of the ez time slider.
im going to close this. we can reopen if it turns out this plan doesnt work out as intended for some reason.


Fixed wrong trailing comma in tsconfig

IDE highlighted comma like "JSON standard does not allow trailing comma", i am just removed it.
Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Just typo fixing
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #5061 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #5061   +/-   ##
=======================================
  Coverage   95.08%   95.08%
=======================================
  Files          72       72
  Lines        2421     2421
  Branches      614      614
=======================================
  Hits         2302     2302
  Misses         99       99
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e17a7...976e34f. Read the comment docs.


jacdac-ts: support new protocol features: qos, version, events

[x] QoS counter sending
[x] QoS counter usage
[x] version bit
[x] triplicate event sending
[x] triplicate event reception

events implemented in https://github.com/microsoft/pxt-jacdac/pull/28

events implemented in https://github.com/microsoft/pxt-jacdac/pull/28

Is QoS going to be a register i can query from jacdac-ts? Since only a physical device can collect those, I'll need to poke the Makecode device to give me that info.

Is QoS going to be a register i can query from jacdac-ts? Since only a physical device can collect those, I'll need to poke the Makecode device to give me that info.

You can actually check the counter in announce packet (supported by latest JM firmware) that lists the number of packets sent and see if you got all of them.
What you cannot do from website is the flood ping (ie if you enable it, the webusb probably won't keep up)

You can actually check the counter in announce packet (supported by latest JM firmware) that lists the number of packets sent and see if you got all of them.
What you cannot do from website is the flood ping (ie if you enable it, the webusb probably won't keep up)

This was for jd-ts, I think it's now all done


[WIP] use inject in install command

Signed-off-by: Dennis Adjei-Baah<EMAIL_ADDRESS>

@deebo91 wrote in https://github.com/runconduit/conduit/issues/302#issuecomment-365445559:

I could use your help in verifying whether traffic is routed properly. My test was to first run the new install command. Then, install emojivoto in its own namespace. Then I verified that I could see stats for conduit/controller pods as well as emojivoto/* pods. I also took a look at the logs in the conduit proxy with tokio_core=warn,mio=warn,h2::proto=warn,debug set as the logging level and I am seeing h2 traffic being sent to telemetry. Does that suffice as exit criteria?

@klingerf just gave me a brief status update about the regression test framework project. I think the exit criteria should be to pass those tests with the proxy injected into the control plane.

That sounds reasonable @briansmith.  I am currently working on refactoring out the inject code.

@briansmith I am switching back to just having all the inject code in the inject.go. I agree that adding  dependencies might make things a little more complex. My thought process on the previous commit was that moving the Inject functionality into its own module would make it testable and isolate concerns from the inject.go since it is doing both CLI stuff as well as the processing of YAML and injecting proxy code.

@adleong it looks appears that there is a sudden spike in metrics for the controller when an API from the control pod is called

Perhaps disabling metric recording when the proxy is in the control pod would be a possible fix for now?

I think we just need to configure CONDUIT_PROXY_CONTROL_URL on the controller sidecar proxy to be <IP_ADDRESS>:8086.

@briansmith this PR is ready for a review. I ended up just hardcoding the proxy configs into the install script. If I were to use the Inject YAML I created earlier, I would have had to add additional checks on the incoming YAML to check if the current YAML section being processed was a controller deployment in order to apply specific configs for the proxy to be inject. i.e. set the CONDUIT_PROXY_CONTROL_URL to <IP_ADDRESS>.8086 instead of the proxy api DNS name.
I tested out the change locally and traffic is routed successfully both in the controller pod as well as services running in a different namespace. However, I am seeing strange behavior in the web UI were metrics for the conduit controller are showing up as downstream services in emojivoto deployments. A quick fix may be to exclude  controller pod metrics from showing up in the web UI

I am seeing strange behavior in the web UI were metrics for the conduit controller are showing up as downstream services in emojivoto deployments. A quick fix may be to exclude controller pod metrics from showing up in the web UI

This implies to me that there is some latent bug in how we present traffic to downstream services. Are we currently only showing traffic between Conduit-proxied pods, and not traffic from Condiut-proxied pods to non-Conduit-proxied pods? Are we not showing traffic from non-Conduit-proxied pods to Conduit-proxied pods? If ether of those are true, that seems like a significant limitation that we should be tracking with its own issue in GitHub.
I'm pretty sure we should show all the stats for all traffic in the UI, including traffic to the controller. However, I would confirm this with the design & product teams. That is, the "strange" behavior you describe seems like the right behavior to me.

I ended up just hardcoding the proxy configs into the install script.

If we were to do that then we'd have difficulty maintaining things going forward. Every time we change how inject works we'd have to figure out what manual change we need for install. Every time we add a new proxy setting we'd have to figure out what manual change we need for install in addition to inject. Every time we suspect there's a problem with the configuration of the proxy in the control plane we'd have to manually compare the control plane's configuration of the proxy to the "normal" configuration. This means many people who don't normally work on the install.go code would have to be very familiar with it. It also means that many features would get blocked on the CLI code reviewers reviewing the install.go changes.

If I were to use the Inject YAML I created earlier, I would have had to add additional checks on the incoming YAML to check if the current YAML section being processed was a controller deployment in order to apply specific configs for the proxy to be inject. i.e. set the CONDUIT_PROXY_CONTROL_URL to <IP_ADDRESS>.8086 instead of the proxy api DNS name.

OK, that's a valid concern. Is that check hard to implement? We already get as an input the namespace of the controller as controlPlaneNamespace. Can't we just implement the check using something like this?:
    controlPlaneDNSName := fmt.Sprintf("proxy-api.%s.svc.cluster.local", controlPlaneNamespace)
    if t.namespace == controlPlaneNamespace && t.name == controller {
        controlPlaneDNSName = "localhost"
    }

   ...
-        Value: fmt.Sprintf("tcp://proxy-api.%s.svc.cluster.local:%d", controlPlaneNamespace, proxyAPIPort),
+        Value: fmt.Sprintf("tcp://%d:%d", controlPlaneDNSName, proxyAPIPort),

(I'm assuming here Kubernetes names are case-sensitive.)
If the check isn't significantly more complicated than this then I think we should do it your original way instead of this new hard-coded way.

Closing this PR in favor of

#381
#365
#379


chore: use GitHub's form schema for bug reports

Description
Use GitHub's form schema for the bug report template. This way we can require certain fields to be filled out.
Test plan
View the file to see how it will look like:

This is a good bug template. Now that everything is required, it's too narrow for tracking our own "feature" and "task" work. Have you thought about a template for that, or even a blank form just for code owners?

This is a good bug template. Now that everything is required, it's too narrow for tracking our own "feature" and "task" work. Have you thought about a template for that, or even a blank form just for code owners?

There's blank_issues_enabled but you can only turn it on or off. There's no "owners only". It's a bit problematic, but I think it should be fine to turn it on.


Let users to correct/edit maps.

How can we contribute to actually edit the maps?
The rework new maps are on the official ubisoft website, but all unlabelled.
If there was easy tutorials on labelling, etc. would be nice. Of course we need to keep the font/styles consistent, so some help would be nice.

this project died already


[Bug report] "connect timed out" error when running integration test

Describe what's wrong
As title.
Error message and/or stacktrace
java.lang.RuntimeException: Failed to connect to Hive Metastore
...
Caused by: java.net.ConnectException: Operation timed out (Connection timed out)
...

or
org.apache.iceberg.exceptions.RESTException: Error occurred while processing GET request
...
Caused by: java.net.SocketTimeoutException: Read timed out
	at java.net.SocketInputStream.socketRead0(Native Method)
...

See all failure reports: reports.zip
How to reproduce
On MacOS, use main branch, open 1 terminal to run dev/docker/tools/mac-docker-connector.sh and the other terminal to run ./gradlew clean build.
Additional context
No response

Running the integration tests I was unable to reproduce this. Please give us more details on the macOS version, CPU, amount of memory, and the Java version you are using.

@justinmclean
Build time:   2023-06-30 18:02:30 UTC
Revision:     5f4a070a62a31a17438ac998c2b849f4f6892877

Kotlin:       1.8.20
Groovy:       3.0.17
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          1.8.0_362 (Amazon.com Inc. 25.362-b08)
OS:           Mac OS X 14.2.1 aarch64

I think it might be something related to docker setup, as the read time out indicates a network issue.

I can't tell from the information provided, but it might be possible that something is running on one of the ports used for the integration test.

@justinmclean The issue is gone after upgraded to latest docker software.


Using 'new static' without parens is marked as error

From new parser, #357
class Foo {
  public function bar() {
    new Foo;      // No error
    new self;     // No error
    new static(); // No error
    new static;   // Error
  }
}

This issue was moved to Microsoft/tolerant-php-parser#148


Issue using v2 of library

I copied your example code into main.go and when I try to build the app I get the following error.
go build
main.go:4:2: open /home/gregf/dev/go/src/github.com/gregf/thome/vendor/github.com/caarlos0/gohome/main_freebsd_test.go: no such file or directory

Not sure why this is happening. I used golang's dep package manager to vendor your library all the files appear to be there. Any idea what might be going on?

So update, I tried to use github.com/caarlos0/gohome instead of the gopkg.in link. Same error. Digged into it a bit and noticed the symlink for main_freebsd_test.go was there but the file it links to main_linux_test.go isn't there even though it's in the repo. I don't know why? Do you think this is a bug in godep?

seems like


qs.parse(accessToken) renders empty object

accessToken is a JSON object in itself. qs.parse(accessToken) would render an empty object.
There're qs.parse(accessToken) elsewhere in the code as well and may have the same issue.

+1 with this, I discovered this myself and fixed it the same way.
You just need to remove qs.parse() as @ricolo has done.

I guess Facebook has finally changed their return type. It was necessary prior to Graph API 2.3.

Thanks @ricolo.


Fix formatting

[x] Struct definitions first, impl after;
[x] Public first, private after;
[ ] Use free functions instead of static one if self is not used.

Missing free functions refactor from file_naming module.


Add cronStream

Takes a cron style schedule (with timezone?) and produces items according to the schedule.

This could be very useful to build a scheduler, but requires writing a crontab parser. Another option is adding a dependency to the cronexp library: https://code.dlang.org/packages/cronexp/~master

I was actually thinking of using some structured arguments instead of the actual cron syntax.


Styles: Deprecate old Badge, new Badge, Chip

Umbrella task for the folling Subissues generated from #1864.
Subissues
- [ ] https://github.com/swisspost/design-system/issues/2196
- [ ] https://github.com/swisspost/design-system/issues/2197
- [ ] https://github.com/swisspost/design-system/issues/2198
- [ ] https://github.com/swisspost/design-system/issues/2199

Closing as the umbrella issue is not needed anymore.


Allow keys to have capital letters

This will make keys easier to read. (ie. childdisability could become childDisability)

Stumbled across the solution while I was trying to figure something else out. See PR #33

Closed #33


Implement reading custom digests.

Implement reading custom digests.

https://github.com/radekg/gossiperl-client-js/issues/3


Neasted template: reuse templates in templates

Is your feature request related to a problem? Please describe.
Unnecessary repetitive patterns in mapping templates.
Describe the solution you'd like
The templates in mapping.yml is a cool feature, but to simplify some rules it would be nice if they can be:

Aliased
Reusable in next templates

Consider the 2 definitions: delimiter and quality
https://github.com/euzu/m3u-filter/blob/9905dbff674055e10b664b2060a4d09142a56b2f/mapping.yml#L94-L99
We can see that the second is repeating the delimiter pattern in it's own expression. That also applies for the other defined template entries.
Describe alternatives you've considered

Aliases: L96 and L117 are examples of aliases, but the yaml representation may be different, like name could be an array :shrug:
Reusable: I've added comments with the natural syntax I would have naively used: L96 L99 L102...

Additional context
Problem is accentuated by #7

done.


Fixed Temperature Scaling

Have managed to fix the temperature values, using a mass based rescaling factor after the the values have been generated, for more details see commit 9dbefd2.
One issue we noticed that @fjebaker might be able to provide some insight into is the optimisation, as in order to generate this scaling factor, we have to use a second value function, which is simply for radius, but this almost doubles the render time. I'm sure there is probably a way to extract the radius values without repeating the geodesic calculations, but we don't really have a firm enough grip on the ValueFunction and how that works to be able to apply that.

If you're just multiplying the temperature by a value that depends on the radius, you could implement a single value function, along the line of
# ...

M_phys = mass*1.99e30
r_isco_phys = AccretionFormulae.r_isco(M_phys, 0.998)
r_g_phys = M_phys

# ...

function my_function(m, sol, max_time; kwargs...)
    g = AccretionFormulae.redshift(m, sol, max_time; kwargs...)
    u = sol.u[end]
    M = m.M
    a_star = m.a
    temperature = AccretionFormulae.observed_temperature(u[2], a_star, M, g)

    # ...

    numerator = AccretionFormulae.mass_scale_fraction.(M_phys, η_phys, edd_ratio_phys, r_isco_phys, r_g_phys, u[2]*M_phys)
    denom = AccretionFormulae.mass_scale_fraction.(M, η, edd_ratio, R_isco, M, u[2])

    temperature * numerator / denom
end

my_vf = ValueFunction(my_function)

# ...

I haven't tried running your code like this, but you shouldn't need to run a new ValueFunction to get another value. They are designed to be composable, so this should work fine for you?
I'm currently working on adding render caches and exports though, so you can save geodesics and run mutliple ValueFunctions on them without having to re-render the image. If the above isn't sufficient for whatever reason, by Monday this should be available to you.
If you make changes, please just push them to this PR!

I had a look at that implementation, and it would work in theory, but with the way our variables are used, it makes it quite awkward to make, so I think we'll stick with our implementation for the time being, until the render caches are ready.

@phajy

Hi @phajy , we have been able to have a look at this, and made a bit of progress, and might have something that looks promising. For every pixel, we found the emitted flux for the radius of that pixel, then we determined the energy bin based on the redshift of the emitted energy (6.4 keV) and added the flux per unit area in this pixel the corresponding energy bin.
The bins were found in slightly convoluted way (lines 173-181), but seems to work for now. The flux per unit area was found by relating the number of pixels the image spanned to the radius of the black hole.
Here is a plot that we got:

It looks quite bad, but we noticed that in the area that the lines don't drop down to zero, it seems to resemble the shape we expect, and there could be some sort of noise we have accidentally introduced?
When we isolated the 5-10 keV region, we got:

Which could be in the right direction?

Hi @phajy , we have been able to have a look at this, and made a bit of progress, and might have something that looks promising. For every pixel, we found the emitted flux for the radius of that pixel, then we determined the energy bin based on the redshift of the emitted energy (6.4 keV) and added the flux per unit area in this pixel the corresponding energy bin.
The bins were found in slightly convoluted way (lines 173-181), but seems to work for now. The flux per unit area was found by relating the number of pixels the image spanned to the radius of the black hole.
Here is a plot that we got:
It looks quite bad, but we noticed that in the area that the lines don't drop down to zero, it seems to resemble the shape we expect, and there could be some sort of noise we have accidentally introduced?
When we isolated the 5-10 keV region, we got:

Which could be in the right direction?

Just wanted to add that the units for flux have been clumsily implemented for now but we want to get the shape before anything else - we will revisit in the morning with fresh heads. We'll also take a look at using an arbitrary function for the emissivity profile.

Thanks for the code update and example plots. I've made some further updates and will submit a new Pull request.

No problem. And sorry again for just pushing the changes to the repository - I forgot that I hadn't "forked" this project so thought I was pushing it to my repository not astro-group-bristol!
To get a decent line profile you need to have enough pixels in the region you're interested in (i.e., the inner disk) to create a smooth spectrum for a given number of spectral bins. You can, of course, play around with r_in, r_out, inclination, and emissivity profile (which ideally should be the Page & Thorne profile from the temperature map).
Finally, you should just be able to do the integration once and have a value function that returns a vector of, e.g., [g, r, temperature] or whatever. That would make execution of the code much faster.

For sure, that was something we had planned, we're going to look at cleaning up and optimisation very soon.

@kyle8mcknight the caching method should be ready tonight -- I'm sorry it's been delayed a couple of days. I encountered an issue with type inference for allocating the output array, but I think that is fixed now!  I'll look into optimizing this very soon.

Interesting, I'll have a look at this tonight and give you a shout tomorrow if we have any trouble.


feat: Disable report link when no source path is set

"Report problem" used to be hidden in plugins.jenkins.io footer. This should hide it again.
On the main site it makes sense to show "report problem" and not "improve the page" for some pages, so we can't just change this in the footer component.
CC @halkeye @NotMyFault

if you modify that script locally in your node_modules directory does it work? Empty string should be treated as not passed right?

if you modify that script locally in your node_modules

That's what I tried with the plugins site. Empty string is treated as false here.

awsome!

@halkeye will you be able to cut a release for this?

yea, probably not till tomorrow though, i'm going to ask infra to move it to infra.ci like web components. Github actions isn't looking at PR titles, only commits to decide if it should release or not.

(also if not, i can remember how to cut a manual release)

https://github.com/jenkins-infra/gatsby-plugin-jenkins-layout/releases/tag/v1.4.0
i guess I had too many "fix jenkinsfile" type commits, so it didn't detect your change, but released