Issue Evaluating Rule #3

Hi,
I'm currently testing Burrow and I'm struggling to understand how rule 3 gets triggered. As I understand it the lag needs to increase for every interval in the current window while the consumer moves forward by committing offsets.
Let's assume my producer is producing faster than my consumer is consuming and therefore lag is increasing.
If my consumer commits offsets, let's say, every 5 seconds, but the parameter "broker-offsets" is greater than 5 seconds then I don't don't see how it can be triggered as the true lag will be stale for some intervals and therefore the rule will be skipped.
In my testing the only way I can get a consumer group to go into a WARN status is by ensuring that broker offsets are refreshed more frequently then the consumers commits, is this correct ? If so, is there a performance impact on setting a low value for broker-offsets ?
Thanks,
Tom

I think I'm encountering this issue as well. I have a consumer that basically commits every single time it reads a message, but often lags behind a faster producer. This results in an inverse sawtooth wave of offset lag - the lag slowly decreases while the consumer is committing but Burrow hasn't refreshed the high water mark from Kafka, and then suddenly increases massively, resulting in an overall increase over time, but never triggering the WARN state in Burrow.
It's not really reasonable to require consumers to "hold off on committing" just to make Burrow recognize that they're falling behind.
I'm going to poke around the source code to see if I can figure out any way to fix this, but it would be great if someone familiar with the codebase were willing to jump in and beat me to it. :)

Alright, Tom, I think I have an answer for us both.
If we set the configuration option
[tickers]
broker-offsets=5

then Burrow will update its high water mark every 5 seconds from Kafka, as you know.
The only other thing that seems to be necessary is forcing Burrow to ignore consumer updates that happen at a faster frequency. This can be done with
[lagcheck]
min-distance 10

(or, I assume, any value higher than 5).
Once your configuration is set up this way, WARN seems to work.
I guess I'm not seeing how Burrow accepting configuration min-distance < broker-offsets isn't basically a bug - it seems basically guaranteed to soft-disable the WARN state unless your consumers just so happen to commit less often than broker-offsets.  So my two cents would be: Burrow should regard this adverse configuration as a bug, and either throw a detailed error on startup (probably preferable), or automatically adjust one of the parameters to appropriately avoid the WARN state.

Thanks @petergaultney, that makes perfect sense. I'll do some more testing around this.

I'm going to change how min-distance works a little in the rewrite. I think it makes more sense to accept every offset commit that comes in, but if it violates min-distance it should just update the latest offset stored, not create a new one. I believe this is the source of a number of strange behaviors.

Resolved by 1.0 rewrite


fix: Ranks being unselectable in CP performances

Description
Fix for a bug where X Axis for the CP performances graphs kept going back to rounds even after selecting ranks.

Looks like issue is fixed 👍


Update MD file on new branch 2017-22-01_23-12-28

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update awtrix-light to 0.11.0

Please update my adapter ioBroker.awtrix-light to version 0.11.0.
This pull request was created by https://www.iobroker.dev c0726ff.

0.11.0 created at 09.01.2024
200 user
OK


Dependency attack specifically targeting ps-tree

One of your dependencies (event-stream) has an injection that specifically targets this package. Update to event-stream to 4.x to remove it. More info: https://github.com/dominictarr/event-stream/issues/116

FYI<EMAIL_ADDRESS>locked to<EMAIL_ADDRESS>(which if I read this thread correctly pre-dates the questionable changes).
Thanks to folks for bringing it to my attention: https://github.com/indexzero/ps-tree/pull/34


Clean up cephfs provider Docker image

While exploring the cephfs storage provider for personal use, I noticed a couple things:

The Dockerfile doesn't run a yum clean all, which (from testing) inflates the uncompressed image size by ~103MB
The default CMD is set to chmod o+x /usr/local/bin/cephfs_provisioner - the Deployment manifest overrides the command, but I noted that cephfs-provisioner.go relies on being able to exec /usr/local/bin/cephfs_provisioner, so it seems most likely that this is a mistake.  Do note that that file is provided from inside this repo, and does have 755 permissions already, so everything should already work regardless.

I have changes in master on https://github.com/mcronce/external-storage that correct both of these things.  If the proposed changes are accepted I will submit a PR.

Sounds good to me, please submit a PR 👍 , it's best we follow convention.

Done - thanks!


index.html

a little bit change in 'welcome' class

@armanbinmahmud   thanks for making your first contribution, I will be merging your Pull Request, also look at the issues so that you can get a chance to win a limited community Swag from me.
If you like the project and Repo please give it a star and Follow me on Github (would be appreciated)


Deno support is undocumented

How should we use this on Deno?
I've imported it without problems using the URL https://cdn.skypack.dev/@octokit/webhooks-methods?dts.
I'm using the verify method this way:
await verify(secret, payload, "X-Hub-Signature-256");

But it's returning false every time.
Here's my full code:
import { Application } from "https://deno.land/x/oak/mod.ts";
import { verify } from "https://cdn.skypack.dev/@octokit/webhooks-methods?dts";

const app = new Application();

app.use(async (ctx, next) => {
  try {
    await next();
  } catch (_err) {
    ctx.response.status = 500;
  }
});

const secret = "...";

app.use(async (ctx) => {
  const signature = ctx.request.headers.get("X-Hub-Signature-256");
  if (signature) {
    const payload = await ctx.request.body({ type: "text" }).value;
    const result = await verify(secret, payload, signature);
    console.log(result);
  }
  ctx.response.status = 200;
});

I accidentally clicked on 'bug'. The bug label might not be accurate.

I'm experiencing the same problem with both X-Hub-Signature and X-Hub-Signature-256.

Alright, here's a working example of GitHub signature verification for Deno:
import { Buffer } from "https://deno.land/std/io/mod.ts";
import { timingSafeEqual } from "https://deno.land/std/node/crypto.ts";
import { hmac } from<EMAIL_ADDRESS>
const encoder = new TextEncoder()

const signature = req.headers.get(`x-hub-signature`) ?? ``;
const signatureBuffer = encoder.encode(signature);

const payload = await req.body({ type: `text` }).value;

const algorithm = signature.startsWith("sha256=") ? "sha256" : "sha1";

const verification = `${algorithm}=${hmac(algorithm, "helloworld", payload, "utf8", "hex")}`;
const verificationBuffer = encoder.encode(verification);

// constant time comparison to prevent timing attachs
// https://stackoverflow.com/a/31096242/206879
// https://en.wikipedia.org/wiki/Timing_attack
const matchesSignature = signatureBuffer.length === verificationBuffer.length
  && await timingSafeEqual(signatureBuffer, verificationBuffer);

I already made it working with https://stackoverflow.com/questions/71076989/how-to-validate-github-webhook-with-deno.


Unnecessary extra code for mention

You already have the user, no need to get the user again

I was just trying out the GetUser method, to see if it grabs from cache


Commit Message Templates

[ ] add GitSavvy.sublime-settings option commit_template that accepts a string
[ ] when set, this string will be used to pre-populate the commit window on new commits
[ ] user should be able to define tab-stops (similar to how snippets work), so that they can tab between the "fields" that need to be filled out

Maybe we should use git's commit template? loot at setting commit.template

Hey,
I use the "commit_help_extra_file": option to set the commit message that I am supposed to use. However, the commit screen (and the amend commit screen for that matter) ends up showing the GitSavvy's help message anyway.
To make a commit, type your commit message and press CTRL-ENTER. To cancel
the commit, close the window. To sign off on the commit, press CTRL-S.
You may also reference or close a GitHub issue with this commit.  To do so,
type # followed by the tab key.  You will be shown a list of issues
related to the current repo.  You may also type owner/repo# plus the tab
key to reference an issue in a different GitHub repo.
Is there a way to disable this?
Cheers!
Bharath
ಭರತ

@divmain It's a very useful feature. In my team we have to add branch name manually to every commit.

A complete hack but the following works to get a jira prefix added to all commits.
Install gitsavvy as a git repo as described in readme.
edit ~/.config/sublime-text-3/Packages/GitSavvy-master/core/commands/commit.py
line 26, add a default prefix/marker
        COMMIT_HELP_TEXT = """JIRA-1234

line 133, add move cursor to end of prefix
        self.view.run_command("gs_replace_view_text", {
            "text": initial_text,
            "nuke_cursors": True
            })
    self.view.run_command("move_to", {"to": "eol"})

There does not seem to be a way to force a reload of the plugin without a restart so make a simple bash function to set the current task id you are working on and restart sublime.
function git_template {
	sed -i -e "s/JIRA-[[:digit:]]*.*/JIRA-$1 /" ~/.gitmessage
        sed -i -e "s/JIRA-[[:digit:]]*.*/JIRA-$1 /" ~/.config/sublime-text-3/Packages/GitSavvy-master/core/commands/commit.py
        kill $(pgrep sublime -U <user>)
        subl &
}

Now simply run git_template 5678 and enjoy  :-)


ctrl+s in integrated terminal while ssh'ed into Linux terminal prevents further stdout from displaying

Issue Type: Bug

Open integrated terminal
ssh into remote
press ctrl+s
ssh session stops responding.

Note:  If I start a screen prior to pressing ctrl+s, the ssh session still stops responding, but when I start a new terminal, ssh back into the same remote and reattach to the same screen, I can see that the ssh session that stopped responding was still receiving my commands, I was just not able to continue seeing the stdout.  See gif below.

 See https://unix.stackexchange.com/q/137842/115410


Remove unused code

build-depends: https://github.com/rh-nfv-int/nfv-example-cnf-deploy/pull/51
This code is legacy one that is no longer used:

cnf-app-mac-fetch (cnf-app-mac-operator) - we still have references to this : https://github.com/rh-nfv-int/cnf-app-mac-fetch, but in fact, the current cnf-app-mac-operator is the evolution of that code, we no longer need this
cnf-run configmap (testpmd-operator) - even though this file is loaded by using a configmap, we never use it; we rely on the Python scripts provided in the testpmd image

Check is working, the removed code is not affecting, this is ready for review


bump to pg_net 0.11.0

CHANGELOG https://github.com/supabase/pg_net/releases/tag/v0.11.0

@samrose I see the Nix CI fails with:

  /usr/bin/git branch --list --remote origin/pg_net-0.11.0
  /usr/bin/git tag --list pg_net-0.11.0
  Error: A branch or tag with the name 'pg_net-0.11.0' could not be found

How to fix that?


Load external url

These changes (built on top of #138, I'll rebase once the other PR is merged) allow loading the file from GET url parameter.
The main use case for it is to create a link like https://chemiscope.org/?load=https://my.super.website.net/chemiscope-file.json; where my.super.website.net could be a journal SI storage website or an individual researcher website.
~These changes work only partially:~

~loading http://localhost:8080/?load=https://chemiscope.org/Arginine-Dipeptide.json.gz works fine~
~loading http://localhost:8080/?load=https%3A%2F%2Farchive.materialscloud.org%2Frecord%2Ffile%3Frecord_id%3D458%26file_id%3Dfd83321d-1b1a-47c5-b580-4904bb07291b%26filename%3Darginine-kpcovr-0.55.json.gz (the URL of one KPCovR file from the materials cloud archive) fails with a CORS error. I'm not sure if this comes from archive.materialscloud.org or object.cscs.ch/archive/.... What seems to happen is the script request the file from archive.materialscloud.org and get a 302 found status, and get redirected to object.cscs.ch/archive/... which fails. Trying to load directly from object.cscs.ch/archive/... gives me a 200 OK status, but fails due to a CORS error.~

~I don't fully understand how CORS work and who is responsible to set the right HTTP headers to make it work, but it seems that it should be done by the remote host (materials cloud in the second case). Github pages (where chemiscope.org is hosted) seems to always allow CORS requests.~

I got it to work by using https://allorigins.win/, thanks @ceriottm for the pointer that this kind of website existed!

This is mostly there, the only missing parts are documentation & tests.

This is ready for review! This PR contains the changes from #196, I'll rebase it once the other PR is merged.


build: fix miniprogram adapter

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

fix miniprogram adpter

+1


[v3 rc4] TilingSprite Errors

I just gave RC4 a try. I was a very easy transition from v2. Well done and thanks for this! But TilingSprite seems to be a difficult child for now.
1. Still messy borders
See here: http://jsfiddle.net/cc6r8s7n/4/
This is my old and closed issue to this: https://github.com/GoodBoyDigital/pixi.js/issues/1457
There are messy borders or the might ne gaps of a single pixel.
(The stretching error (see https://github.com/GoodBoyDigital/pixi.js/issues/1458) is fixed as far as I can test for now)
Might be related to this ?
https://github.com/GoodBoyDigital/pixi.js/issues/1630
2. No Canvas rendering
See here: http://jsfiddle.net/cc6r8s7n/4/
Same here: https://github.com/GoodBoyDigital/pixi.js/issues/1659
I also tracked it down to generateTilingTexture. Even by using the correct method signature it will fail at
renderer.currentRenderer.flush();
TilingSprite.js#L391
This is where I stopped to investigate into it.

hey there, just uploaded a new Tiling texture to the dev branch.. please let me know if it works ok for ya!

Canvas seems to be fixed, but WebGL version stopped working for me (no errors in the console).

hmm.. the fiddle works like a boss for me?

I'll double-check it, but it was working fine before the last update.

webGL got a bit or a teardown - its now tiling in the shader rather than generating a PoT texture as it was before...

Maybe it's nor working for me because I'm using a tile from a spritesheet.

Yes! This looks promising so far. Gaps are gone, canvas is running. My tiles are loaded from different spritesheets. But there is a display problem in the canvas renderer with Background Tiling Sprites which are only moved with tilePosition.x. They just disappears if the x position is large enough. It's running totally fine so I guess it's a bug with the canvas renderer ? I will provide you with a fiddle for this.

Great to hear @georgiee :+1:
@krzysztof-o
was testing this one: http://jsfiddle.net/t5cvsbww/
it uses a sprite sheet and seems to be all cool?

Okay. That was easy to reproduce. I hope it's the same to fix it :)
Bug Description:
Only in Canvas: If the horizontal tilePosition is larger than the tile width itself the tile disappears. This might be the same for the vertical equivalent.
Here is the fiddle with two dat gui controls to change the position and the width of the tile.
http://jsfiddle.net/ym4zcj8k/
Here two screenshots. The TilingSprite should span the whole window as it's shown in the first screenshot.

Thank you very much for this new TilingSprite component!

I found the problem. When the tile image is 1px width it doesn't appear. As soon as I resized it to 2px it started working.

@GoodBoyDigital

webGL got a bit or a teardown - its now tiling in the shader rather than generating a PoT texture as it was before...

At the moment I am in the process of performance testing my current application on a iPad2 device. I just rechecked it and gained 30fps, so that I'm now at 60fps. What a great decision to move the tiling to the shader. You just saved me from a very tedious profiling session. Wonderful! :sparkles: :thumbsup:

@georgiee happy days, great to hear! :D

should be fixed now on the dev branch @georgiee :+1:

YES. Confirmed. Fixed! Thank you very much! It's my pleasure to close this ticket.

@GoodBoyDigital, the issue with 1px-width tile still exists in WebGL renderer.

@krzysztof-o - is that from a sprite sheet?

Yes, the tile is 1px width (the spritesheet itself is larger).

cool - due to precision issue this is going to be pretty tricky to fix. Any reason why you are using a 1 px tiling sprite? Graphics Object would be much nicer?

But I can't achieve gradients in Graphics Object.
Resizing to 2px works for me but it seems like a dirty workaround.
This is the tile I'm using:

i see! for now this is the best way to go is to do 2px width. I will have a think about a workaround.. cheers!

Ok, thanks a lot!

Hey, I got another small bug for you in webgl and canvas. The tiling sprite will jump if the tilingPosition is past the width of the base texture.  See http://jsfiddle.net/ym4zcj8k/3/ and test the tiling position around 512 or 1024
The tiling sprite will jump when you pass a multiple of the width of the base texture which is 512 in this example. I think this is the error in the code for webgl.
https://github.com/GoodBoyDigital/pixi.js/blob/b68ab0f5ca4cc617d2725107501c41107f9e6f3f/src/extras/TilingSprite.js#L200
It should be modulo the real width of the given tiling texture. But contains the width of the whole spritesheet.
this.shader.uniforms.uTransform.value[0] = (this.tilePosition.x % tw) / this._width;
this.shader.uniforms.uTransform.value[1] = (this.tilePosition.y % th) / this._height;

Hey @georgiee , did you find a fix for this one please ?

Na, I did not look into it yet as the deadline for my current project is far enough in the future so I'm just betting on a fix with some upcoming commits. I still think my suggested fix could work but I hadn't time to try it yet. You could easily monkey patch and test it yourself. Just copy the TilingSprite source from this repository, override the necessary code parts and give it a try by including it after the pixi library.

I tried but it didn't work.
for me, this piece of code isn't working for every cases :
// apply padding to stop gaps in the tile when numbers are not rounded
    this.shader.uniforms.uFrame.value[0] = tempUvs.x0 + (0.5 / tw); // the 0.5 is padding
    this.shader.uniforms.uFrame.value[1] = tempUvs.y0 + (0.5 / th); // the 0.5 is padding
    this.shader.uniforms.uFrame.value[2] = tempUvs.x1 - tempUvs.x0 + (-1 / tw); // the -1 is padding offset
    this.shader.uniforms.uFrame.value[3] = tempUvs.y2 - tempUvs.y0 + (-1 / th); // the -1 is padding offset

I Have a texture inside a spritesheet. I only repeat on Y. This means my tilingtexture.width is equal to the frame width.
First, I add to remove the 0.5 padding on x to not get an extra pixel on the right.
Then, I tried to toy with the y padding offset but depending on my tilingsprite position, I didn't find a value able to fix every tests.
This is very visible in my game because my tilingsprites are inside a scrollable container. So I can see the gaps blinking when I scroll.
https://cloud.githubusercontent.com/assets/581736/7416695/7c3aa18e-ef61-11e4-8c06-b6f2927dc917.png
https://cloud.githubusercontent.com/assets/581736/7416718/a50be24e-ef61-11e4-8242-75b757345d5b.png

Here's a very simple fiddle showing TilingSprite generating a texture that repeats 1px too early.
https://jsfiddle.net/ya9b73qk/1/

I was able to get @weepy's test case working correctly by removing the padding completely.
I'm curious if you (@JiDW) have tried using 0 instead of the 0.5 and -1 padding (or just remove the padding thing completely) and did that work for your cases? It works for the cases I have lying around.

I think I managed to kill all these issues here with the latest dev code. Let me know if you build the latest dev and it still doesn't work for you!
I was able to get all the test cases posted here working (along with our own examples and such).

I can confirm that the jumping doesn't happen anymore. Thanks Chad!

heya englercj
i've tried the latest 3.0.5 and also from source, but i still seem to get the same problem as reported in https://jsfiddle.net/ya9b73qk/1/
do you have a fiddle showing it working?

I updated the URL of the pixi library you were loading to 3.0.5 and it works fine:
https://jsfiddle.net/ya9b73qk/2/

apologies my bad. i confirm it works well
On Fri, May 15, 2015 at 10:50 PM Chad Engler<EMAIL_ADDRESS>wrote:

I updated the URL of the pixi library you were loading to 3.0.5 and it
works fine:
https://jsfiddle.net/ya9b73qk/2/
—
Reply to this email directly or view it on GitHub
https://github.com/GoodBoyDigital/pixi.js/issues/1683#issuecomment-102533134
.

pixi.js - v3.0.10
I have a "Repeat 2nd row&col as 1st row&col" webgl renderer issue on TilingSprite on my chrome 53.0.2785.143 m(64-bit) win7 AMD Readeon 6800, (also happens to NW.js build on the same machine), chrome version may varying cauz I found the same thing on early chrome version:
I'm working on a pixel style game so I set
PIXI.SCALE_MODES.DEFAULT = PIXI.SCALE_MODES.NEAREST;
and I just make a TilingSprite like :
var bg = new PIXI.extras.TilingSprite(texture, 100, 100);
This is my test texture (16x16 or any resolution or using sprite sheet).

This is the result:

But the result SHOULD BE:

As you can see,there's an 1 pixel offset issue: every tile's 1st row&col is replaced by the 2nd row&col.
As i'm running out of the time, I do not have much time thinking, so I just pray to my mysterious ancient power in vain and they point me at the fragment shader of TilingSprite:
coord = clamp(coord, uPixelSize, uFrame.zw-uPixelSize);
then I enlarge the clamp a little bit, hope that will cheat the floating processor to give my 1st pixel row&col back:
coord = clamp(coord, uPixelSize-0.001, uFrame.zw-uPixelSize+0.001);
Then it just works. (0.001 or 0.0001 or 0.00001 or whatever)
I do not kno it's just me or my machine or  it's actually an issue, but may be some one could use it as a very DIRTY solution while you're on the same boat.
times out =.=!!

@duanhaoyi
Please use latest pixi instead of 3.0.10, I just fixed those issues two weeks ago


skip_tabs not working

I configured swipe_nav: in raw config of dashboard and set skip_tabs: 2 to skip the third tab. Tab is still shown on swipe.

Okay. Found a solution myself:
skip_tabs: 2,
works. So need to add a comma at the end. Should work without too IMHO or mentioned in documentation.

Thank you very much for the issue!
This is indeed a bug and needs to be fixed. I wonder how it stayed there so long without being noticed.

Can you test the last pre-release (v1.12.1)? Everything should be working.

To be honest: I do not know how to test pre-releases ;-)

It's now available for everybody 👍


Add the ability to filter

The ability to filter and sort tasks based on some factor should be added.

What about filtering based on tags? Like, show only tasks with "dotodo" tag.

That would be a nice start. Hopefully, we could get to a point where we could also be able to filter based on Priority in addition to tags.

filter based on Priority

Oh, yeah, somehow didn't think of that... :)
That's a good idea. Then, we'll probably need to have a pop-up with options by what criteria to filter.


Building contracts with different compiler settings

Component
Forge
Describe the feature you would like
Currenlty forge build uses a single configuration settings for all compiled contracts.
In our project, we need to compile the production code (2 contracts) using via-ir, but all the supporting contracts without.
We currently use hardhat configuration with specific "configuration override" for just those 2 contracts.
It would be nice if forge supported such configuration too.
Additional context
No response

Is there any plan to implement this feature?
Having few production contracts an a lot of surrounding  test contracts is a common practice.
Current (single-compiler settings) require either very slow project compilation, since all tests (and unused library contracts) are required to be optimized, or testing the production code in un-optimized build - which makes the tests incomplete, and gas tests unusable.

Would like this feature as well

Another reason to tune the compiler for specific contracts is that some of them need to be compile into a small bytecode, but they shouldn't force all the contracts in the project to get poor runtime optimization.

Some contracts are just large, and must have a lower optimizer_runs to fit in the 24576B size limit.
Some contracts are designed to be deployed multiple times by the end users, they too should be optimized for small deployment size, because the gas savings coming from high optimizer_runs may never recoup the higher deployment costs.

@mattsse Any thoughts on this? We're running into this where we have a few contracts, and one is quite large and just over the limit on the our optimizer setting. It would be nice to override the profile settings per contract.

Related: https://github.com/foundry-rs/foundry/issues/6099


New feature request: Warn and Info

Hi, first of all, thank you for this beautiful library. :) 👍
Can something like toast.info() and toast.warn() come out of the box from the API?
Most of the libraries have four types: info, warn, error, success

Thanks! I'll close this issue in favour of #29


Error in api.request

Hi,
been working with this package for a while now, using it to create an automated reporting for my firm's DCM-accounts. When I tried to login just now, I was able to login, but when I tried to run
files <- files.list(profileId,results=100)
I got:
Error in api.request(req.url, querystring = req.q.string) :    Forbidden (HTTP 403).
I double checked and the login I am using works and has sufficient permissions for access (or at least used to have then?).
Did something change I am unaware of?
Thanks in advance

okay, found the issue: in files.list ,you call
req.url <- paste0("https://www.googleapis.com/dfareporting/v2.2/userprofiles/",profileId,"/files") , which is deprecated, just need to change it to "v2.3" and it works!

Thanks. Are you able to submit a pull request with that change?

Hi,  get the same error message, although authentification is successful
Error in api.request(req.url, querystring = req.q.string) :
Forbidden (HTTP 403).
Since I just downloaded the package it is already on
req.url <- paste0("https://www.googleapis.com/dfareporting/v2.5/userprofiles/",profileId,"/files")
Which other reasons might be possible? Thanks for any thoughts!

Hi, I get the same error too. Have changed v2.7 to v2.8 by using command:
body(files.list)[[12]][[3]][[3]] <- substitute(req.url <-
paste0("https://www.googleapis.com/dfareporting/v2.8/userprofiles/", profileId, "/files"))
I get the error:
Error in api.request(req.url, querystring = req.q.string) :
Internal Server Error (HTTP 500).
Any idea how to resolve this?

GO here: https://console.developers.google.com/apis/dashboard
Select your project.
Then click "enable API".
Then click on "DCM/DFA Reporting And Trafficking API"
Then click on "enable"

HI,sorry for the short answer. Am currently in Afrika with not the best internet access ... please allow me to get back to you next week, when I am back in Europe.Thanks for your thoughts!Cheers, LucieOn 25 May 2017 at 11:34 Willem Paling<EMAIL_ADDRESS>wrote:Have you been through these steps:After you create the client id and secret in the google APIs console, you also have to go in and enable the DCM Reporting API.GO here: https://console.developers.google.com/apis/dashboard Select your project. Then click "enable API". Then click on "DCM/DFA Reporting And Trafficking API" Then click on "enable"—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for the response.
Yes, I have enabled the 'DCM/DFA Reporting And Trafficking API' for my project. I can see the API requests being made and number of errors thrown on the API manager dashboard.

I had been successfully using this package to pull down files from DCM up until last week when I started getting this same error. Could this be related to a version change? Any help is appreciated!

@Th3Bust3r - I had the same issue. Looks like @kairos35 just needs to update to the 2.8 API. I fixed it in my code based on what @PriyankaAvhad had done above. Before you run the files.list() function, just add.
body(files.list)[[12]][[3]][[3]] <- substitute(req.url <-
paste0("https://www.googleapis.com/dfareporting/v2.8/userprofiles/", profileId, "/files"))
Hope that works!

Thanks @mdh1984 and @PriyankaAvhad that works perfectly!!

This is an easy fix. Just a find/replace in the code. Feel free to submit a PR. Otherwise I'll try get it resolved in the next few weeks.


TAXII 2.0 Intelligence Feed not available anymore

Hello There,
Regarding module 2, Exercise 3, The Intelligence feeds are not available anymore (https://www.celerium.com/pickupstix) by celerium. Is there any possibility that you update the module with a new free/open-source intelligence feed provider, please?

Ok Solution may be done through Kaspersky  >>   https://support.kaspersky.com/datafeeds/general/15908
I am still validating it.

Hi @tamer-fpga -
Please find the different Threat Intelligence feed options available for Microsoft Sentinel below.
https://learn.microsoft.com/en-us/azure/sentinel/threat-intelligence-integration#taxii-threat-intelligence-feeds
Thanks

Ok Solution may be done through Kaspersky >> https://support.kaspersky.com/datafeeds/general/15908 I am still validating it.

sorry missed this comment. Yes this is also one of the feed option available.
Thanks

For Kaspersky feeds, they do not want to give me the token so I can’t configure it. I will look at MS link you provided However if anyone can provide fir the token, I would like to get it at my email.

Hi @tamer-fpga are you still facing this issue?

The issue has been resolved by this comment above
————
https://github.com/Azure/Azure-Sentinel/issues/7460#issuecomment-1453289548


Deprecated AUTHENTICATION_ENABLED parameter ignored

There is a typo in app.py which causes create_app to ignore the deprecated AUTHENTICATION_ENABLED parameter

Great! Happy you found it!


automatically create empty release for each tag; fixes #1414

This Github workflow creates a new empty release for each (new) pushed tag and for tags only. Normal push events are getting ignored.
This solution will not create releases for past tags, only for newly pushed ones after this workflow is active.
This is an attempt to fulfill all 3 criteria given by @Eloston in https://github.com/Eloston/ungoogled-chromium/issues/1414#issuecomment-798822753

by looking at the issues it should also fix #1407


Running the network for a custom dataset

Hi, thanks for the great work!
I am working on a project where I have to register pointclouds of shapenet objects (Complete point cloud) with point clouds generated for a single view of the same object. Was wondering if this code base can be used to do the same?
I was also wondering how the data was prepared, if you have any codes for the same.
Thanks!

Thanks for asking~ To render partial point clouds, you may check the following functions from open3d:
http://www.open3d.org/docs/0.9.0/tutorial/Advanced/customized_visualization.html
Hope it helps~

Hi, Many thanks for the reply.
I already have a custom dataset. The source and target pointclouds are from different sources in my case and I would want to try GMCNet and see how good the registration is when compared to FCG(Implemented in Open3d).
So could you please tell me what preprocessing and data preparation tasks I have to carry out on the source and target pointcloud datasets. Like you had done for your custom dataset.
Many thanks in advance!


Travis setup

Appreciate your help @alexeyt820, but v2 does not depend on Quick and Nimble any more so I'll have to close this.


Pushover quiet Not working

Pushover notification does Not send Messages quiet but loud, nevertheless IT IS configuered AS quiet.

Use the bug template on github. I have absolutely no information about your version, system or anything else. Issue closed


Right command to right option stopped working 10.14.1

Above swap stopped working after update from 10.14 to 10.14.1
MBP 2018, 15"
Keys are working like w/o any modification.

My Karabiner Elements 12.1 dvorak mapping stopped working (!!!) with 10.14 to 10.14.1 upgrade.
I re-installed from a freshly downloaded 12.1 PKG, and everything is back to normal.
See if a reinstall helps in your case?

cpbotha, thanks A LOT! It helped!

don't know why but your advice @cpbotha works. Thanks

Yo, i have similar problem with command and option modifications .
So on what version it will be working fine?
I have Mojave

My Simple Modifications stopped working for me after installing the latest security update (https://support.apple.com/en-us/HT209193) for MacOS High Sierra 10.13.6. It looks like it's the same update that went out for Mojave 10.4.1.
I was then (and am now) running Karabiner Elements 12.1.0.
This is what got everything working for me again:

Copy ~/.config/karabiner/karabiner.json somewhere safe.
Uninstall Karabiner Elements
Restart
Install Karabiner Elements
Copy config back to ~/.config/karabiner/karabiner.json
Open Karabiner Elements -> Misc -> Restart Karabiner Elements

I'm not sure if each of those steps was necessary, but, together, they worked for me.

@mdawaffe your steps worked for me without the need of 1. and 5.


/change and ChangePasswordForm

Who is handling /change endpoint?  express-stormpath documentation talkes about /reset and /change and its not clear which one is to be used.
	<Route path='/change' component={ChangePasswordPage} />

is not working for me.  I never see the form.  Seems like /change is being consumed on the server side and index.html is being returned properly, but there is no form.  Here is my ChangePasswordPage:
import React from 'react';
import DocumentTitle from 'react-document-title';

import { ChangePasswordForm } from 'react-stormpath';

export default class ChangePasswordPage extends React.Component {

    componentDidMount() {
	console.log( 'mounting changepassword form' );
    }

    render() {
	return (
	    <DocumentTitle title={`Change Password`}>

Change Your Password

		<ChangePasswordForm spToken={this.props.location.query.sptoken} />

	    </DocumentTitle>
	);
    }
}

I never even see the console.log.

I have it working now.  It was apparently a tooling problem.
import { MasterPage, IndexPage, LoginPage, RegisterPage, ResetPasswordPage, ChangePasswordPage, VerifyEmailPage, ProfilePage } from './pages';

did not work.  Who knows why.  If I remove ChangePasswordPage from that line and import it all by itself:
import ChangePasswordPage from './pages/ChangePasswordPage';

then things started working.
Arg!! Two wasted hours in debug.


BasicCharacterObject Properties

Description

Sync the values in the Synced list below.
Create an integration test for all values (1 for server changing the value and 1 for client changing the value if applicable)
Create a command to test changing the value in game see similar command

Also see additional information at the bottom for more information and templates
Synced

Method/Field Name
Sync Type

BodyPropertyRange
TODO

DefaultFormationGroup
TODO

DefaultFormationClass
TODO

KnockbackResistance
TODO

KnockdownResistance
TODO

DismountResistance
TODO

FormationPositionPreference
TODO

Race
TODO

IsFemale
TODO

FaceMeshCache
TODO

IsObsolete
TODO

Level
TODO

Culture
TODO

Age
TODO

FaceDirtAmount
TODO

HairTags
TODO

BeardTags
TODO

TattooTags
TODO

IsSoldier
TODO

Deferred

None
Externally Deferred

None
Non-Synced
None
Intended Design

Message networking

Integration Testing

Location

Create a branch based from development
Related Issues

N/A
Requirements

N/A
Additional information

Using the GameInterface Service Tempale create commands to test the synced values.
For network communication use Server Service Template and Client Service Template
It is recommended to start with an integration test, you can create one using the test template.
Definition of Done

[ ] Class level comments exist for all new classes.
[ ] XUnit tests exist for every method that does not require the game to be ran.
[ ] Commands exist for all new sync items.

Duplicate of #947


forgo.mount() typing not matching with behaviour

When trying to run the following code I got an unexpected error:
import * as forgo from "forgo";

const App= () =>
  new forgo.Component({
    render() {
      return
Tooltip
;
    }
  });

forgo.mount(document.getElementById("root"), <App />);

forgo.min.js:520 Uncaught Error: The container argument to the mount() function should be an HTML element.
Now, because of the typing of mount(), this doesn't throw an error, though I'm not sure why.
export function mount(
  forgoNode: ForgoNode,
  container: Element | string | null
): RenderResult {
  return forgoInstance.mount(forgoNode, container);
}

null however is never a valid container because if (parentElement) will always return false.

Sandbox

You have the arguments reversed. This works:
forgo.mount(<App />, document.getElementById("root"));

I'll see if I can tighten up the type signature to blow up correctly.

I'm going to wait on this types change until we publish breaking changes is v4.0. Since document.getElementById() returns type HTMLElement | null, disallowing null would be a breaking change as it would force existing call sites to add a non-null ! assertion.


Remove all traces of crowdin branch support

As mentioned in https://github.com/microsoft/pxt/pull/9954, I removed support for crowdin branches with the V2 upgrade. This PR removes the remaining traces of support we had throughout the webapp.
There was surprising amount of code for a crowdin feature that AFAIK we have never used.

@srietkerk nope. this code was checked in 8 years ago


How to provide alternatives in sequence

Suppose I have the following class:
struct Foo{
  virtual void before();
  virtual void do();
  virtual void after();
};

With the sequence approach I can make sure, those functions are called in order when having a single instance.
But what do I do when I have multiple instances? Example:
Foo* f1 = new Foo;
Foo* f2 = new Foo;
container.add(f1, f2);
// Expect (f1.before && f2.before) + (f1.do && f2.do)  + (f1.after && f2.after)
container.process();

How can I ensure, that both before are called first, then both do etc while the order of the calls to the same function do not matter?

Something like:

s1 : f1.before -> f1.do
s2 : f1.before -> f2.do
s3 : f2.before -> f1.do
s4 : f2.before -> f2.do

etc…


Doesn't build on Go 1.12

This package uses crypto/ed25519 which was added in Go 1.13. The older name golang.org/x/crypto/ed25519 still works and ends up being a wrapper for the same package when build with Go 1.13+. Would you consider using the older name for a while longer?
(I use Go 1.13, but our stuff gets included in various Linux distros and such and they're not always super quick to upgrade to the latest compiler, etc.)

quic-go also requires Go 1.13, therefore I don't see any reason to support Go 1.12 any longer.

How so? This is the only compile failure that prevents quic-go from building on Go 1.12.

That's currently true, but I don't think it would be a good idea to stop using new features just to support some outdated Linux distributions.


"Waiter StackUpdateComplete failed: Waiter encountered a terminal failure state" error during deployment

After having merge https://github.com/aws101/aws101/tree/todo-sharing-feature this error occurs during the "Create or update application stack" build step with build ultimately failing:
upload: ./network.yml to s3://aws101.dev/stacks/application/network.yml
{
"StackId": "arn:aws:cloudformation:::stack/aws101-application-parent/860672b0-c3c3-11ea-9df5-0a1a4d297742"
}
Waiter StackUpdateComplete failed: Waiter encountered a terminal failure state
##[error]Process completed with exit code 1.
See https://github.com/aws101/aws101/actions/runs/220988679

Fixed with 7ceadb11391bfe8b32347e6327d337fa134a2c22


feat: RHEL 8.4, RHEL 8.2 & RHEL 7.9 GPU support

adds RHEL8.2 molecule target
renames rhel8 ami image template to rhel82 for consistency
adds missing Makefile target for sles15

CONTROVERSIAL:

limits RHEL8.2 to a base image that has kernel headers available
adds RHEL8 support for run file driver installation
adds RHEL7 support for run file driver installation

@tillt have you verified this works?

Tested in konvoy2 deployment:
konvoy-ami-rhel-8.4-nvidia-1.21.6-1637284130
ami-0da5fe116861cb57e

all nodes came up fine, GPU feature discover running fine on all GPU nodes
node-feature-discovery   nvidia-feature-discovery-gpu-feature-discovery-ktf2d                 1/1     Running    0          2m48s
node-feature-discovery   nvidia-feature-discovery-gpu-feature-discovery-rnnfv                 1/1     Running    0          3m1s
node-feature-discovery   nvidia-feature-discovery-gpu-feature-discovery-sqhzj                 1/1     Running    0          2m48s
node-feature-discovery   nvidia-feature-discovery-gpu-feature-discovery-xj4jd                 1/1     Running    0          2m51s

however:
$ k logs -n kube-system              ebs-csi-node-9qk48 node-driver-registrar

I1119 01:49:51.408909       1 main.go:113] Version: v2.1.0
I1119 01:49:51.409543       1 main.go:137] Attempting to open a gRPC connection with: "/csi/csi.sock"
I1119 01:49:51.409570       1 connection.go:153] Connecting to unix:///csi/csi.sock
I1119 01:49:53.369829       1 main.go:144] Calling CSI driver to discover driver name
I1119 01:49:53.372849       1 main.go:154] CSI driver name: "ebs.csi.aws.com"
I1119 01:49:53.372904       1 node_register.go:52] Starting Registration Server at: /registration/ebs.csi.aws.com-reg.sock
I1119 01:49:53.373125       1 node_register.go:61] Registration Server started at: /registration/ebs.csi.aws.com-reg.sock
I1119 01:49:53.373284       1 node_register.go:83] Skipping healthz server because HTTP endpoint is set to: ""
I1119 01:49:53.797263       1 main.go:80] Received GetInfo call: &InfoRequest{}
I1119 01:49:53.825456       1 main.go:90] Received NotifyRegistrationStatus call: &RegistrationStatus{PluginRegistered:true,Error:,}
E1119 01:50:50.253854       1 connection.go:131] Lost connection to unix:///csi/csi.sock.
E1119 01:51:50.251858       1 connection.go:131] Lost connection to unix:///csi/csi.sock.
E1119 01:52:50.250456       1 connection.go:131] Lost connection to unix:///csi/csi.sock.
E1119 01:53:50.256933       1 connection.go:131] Lost connection to unix:///csi/csi.sock.
E1119 01:54:50.249827       1 connection.go:131] Lost connection to unix:///csi/csi.sock.
E1119 01:55:50.252880       1 connection.go:131] Lost connection to unix:///csi/csi.sock.
E1119 01:58:20.251125       1 connection.go:131] Lost connection to unix:///csi/csi.sock.
E1119 02:02:00.251884       1 connection.go:131] Lost connection to unix:///csi/csi.sock

very confusing -- I doubt the GPU drivers are to blame but cant prove it....

rhel-8-nvidia: fatal: [default]: FAILED! => {"changed": false, "failures": ["No package kernel-headers-4.18.0-193.65.2.el8_2.x86_64 available.", "No package kernel-devel-4.18.0-193.65.2.el8_2.x86_64 available."], "msg": "Failed to install some of the specified packages", "rc": 1, "results": []}

Indeed RHEL 8.2 GPU build is borked right now. We have a way to fix it by installing headers that are close enough in their version and pointing the run file-installer to them. For now, lets disable to Makefile target and add a note, sg?

RHEL8.2 can be done by limiting the base image to something that has a kernel with kernel headers available. Updated the PR accordingly.

RHEL8.2 and RHEL7.9 GPU tested without issues using konvoy2 deployments and kommander 2.1 on top with nvidia services enables.
RHEL8.4 GPU showed weird networking issues. @joejulian is looking into those.

I can reproduce the networking issues with a non GPU RHEL8.4 image built (no overrides) - the problems are not introduced by GPU builds. That means this PR should be good to go.

@joejulian the issue you trapped into, missing kernel headers, should be fixed.


Python GAPIC: Video-intelligence v1beta1

This pull request was generated by artman. Please review it thoroughly before merging.

@ethanbao Since the Python folks are all out other than me, can you approve and merge?

Um maybe this should be closed out now


docs.rs failed to build docs for 0.13.0

Because of the fips feature of aws-lc-rs. We need to disable it for docs.

Tracking: https://github.com/aws/aws-lc-rs/issues/600

Does docs.rs update Cargo.lock automatically when building docs?


Cleaner Worker

Completed transactions can be removed from all databases except the Registry.
We can implement a cleaner services.

Milestone 3 included


Image Stitching angle issue

Can your package stitch images that are at different angle from each other? Given they are similar. I'm trying to stitch images taken in my home to a 3D panorama. Please respond ASAP 😊

can you make a sketch or do you already have images?


Tag range to create changelog

In my case I would like to create changelogs not only for the last release but also for hotfixes further back in time.
%%{init: { 'gitGraph': {'showCommitLabel': false}} }%%
    gitGraph
       commit tag:"1.0.0"
       commit tag:"1.1.0"
       branch hotfix/1.1.x order:2
       checkout main
       commit tag:"..."

       checkout main
       commit tag:"..."

Here it would help me if instead of a tag, I could specify a range over which the changelog is generated.
I have created a fork for this purpose.
I still determine the necessary tag area for me about an extra script.
I use it like this:
name: Create GitHub Release Draft

on:
  push:
    tags:
      - [0-9]+.[0-9]+.[0-9]+

jobs:
  release-draft-with-changelog:
    runs-on: ubuntu-latest

    steps:
      - name: Checkout Code
        uses: actions/checkout@v2
        with:
          fetch-depth: 0

      - name: Get previous tag
        id: previousTag
        run: |
          name=$(git --no-pager tag --sort=creatordate --merged ${{ github.ref_name }} | tail -2 | head -1)
          echo "previousTag: $name"
          echo "::set-output name=name::$name"

      - name: Update CHANGELOG
        id: changelog
        uses: sitepark-com/changelog-action@main
        with:
          token: ${{ github.token }}
          fromTag: ${{ github.ref_name }}
          toTag: ${{ steps.previousTag.outputs.name }}

      - name: Create Release
        uses: ncipollo/release-action@v1
        with:
          allowUpdates: true
          draft: true
          name: ${{ github.ref_name }}
          body: ${{ steps.changelog.outputs.changes }}
          token: ${{ secrets.GITHUB_TOKEN }}

But it would be more elegant if the previousTag would be determined in the changelog action. I haven't found a way to do this using the graphql query in the JavaScript.
Would this be a feature that could be merged?

Yes, create a PR and I'll merge it.


added assertions to test max propagation delay

Motivation
Closes #1553 #1559

Changes
added assertions for block and atx propagation to test_mining
Test Plan
ran tests
TODO

bors r+

bors r+

bors r+

bors r+

bors r+

bors r+


Save Image Texture bug

Description
After capture a scene from rednerDoc, I find miss  alpha data in .rdc
when save  image File Format is .png  , I need to do  Alpha mapping - discord
But .png default seeting is Preserve, Alpha mapping field for .png format is disabled,
I change .jpg format to save image with Alpha mapping - discord,
After I success save  .jpg file, save a .png fomat again,
The field about Alpha mapping is lock in discord
I think save imgae field keep the last status, and I can use Alpha discord in png Format.
Is it a bug for .png format can choose alpha discord?
Well it help me save a image file I need.
Environment
Render v1.4
OS: Windows7

I'm not sure what the problem you're describing is. The alpha mapping options when saving textures are only relevant for texture formats like jpg or bmp which don't have an alpha channel themselves. With png, dds, and others the alpha channel can be losslessly saved into the texture so there's no need to try and remap it.
What is the actual problem or bug you are seeing?

I did some testing independent of the reporter, doing three exports in sequence from the same texture view of Willems' particlefire Vulkan sample. I did all of this with the 1.4 Linux binaries downloaded from the RenderDoc website.

When exporting a PNG initially, the alpha mapping option is disabled and has the value Preserve.
The exported PNG has the same alpha as the texture.
When changing to JPG, the alpha mapping option is enabled and I can change it to Discard.
The exported JPG doesn't have any transparency, as is expected.
When changing back to PNG, the alpha mapping option is disabled but keeps the value Discard.
The exported PNG appears opaque and has an all-white alpha channel according to GIMP, not sure if there's an actual alpha channel in the file but both file and ffprobe says "rgba".

My interpretation is that they have an use case where discarding alpha for PNG on export is what they want but I feel that it's probably out of scope of RenderDoc to unnecessarily mangle output that can be represented in the chosen format.
There is however evidence of an actual bug where a disabled export option has effect on a format it shouldn't have an effect on.

Good catch! There was some leftover code that would discard the alpha for PNG (and TGA) by setting it to 255, even though that should not be supported as you point out in the texture save options being disabled.

Sorry for my poor english and  company can't upload any code or image file to github
Thanks for @zao  correctly reproduce experiment for my problem.
@baldurk
I also confused about dump image from RenderDoc GUI and using renderdoccmd.exe
What's the different between both?
Because I  tkink it should get the same .png result, but get different.
Can discuess in here?

If the bug you were talking about is the one @zao identified, I'll close this issue as it should be fixed now.
I'm not sure what image output you mean from renderdoccmd. renderdoccmd is not intended for direct use by users it's more of an internal tool. The only image output it has is dumping the thumbnail, which is not replayed but saved at capture time to allow quick preview of the .rdc file in file explorers etc.
If you see any differences between the replayed output and the thumbnail it may be due to non-determinism in the replay, bugs in the application, bugs in RenderDoc, or something else. I'd need to see a reproducible case to investigate.


Dockerfile: switch to alpine base image

follow-up to https://github.com/shin-/dockerpy-creds/pull/11, but the pass package is not yet in the "stable" Alpine package index, so perhaps you didn't want that.
The alpine image makes the image quite a bit smaller;
REPOSITORY            TAG       IMAGE ID        CREATED             SIZE
docker/pycreds-test   alpine    2451e1c13a9e    3 seconds ago       134MB
docker/pycreds-test   latest<PHONE_NUMBER>9f    10 minutes ago      951MB

@shin-


"Set version" using Maven@3 is skipping some modules sometimes

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: Maven@3
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises?

If using Azure Pipelines, provide the account name, team project name, build definition name/build number: hpcodeway

Agent - Hosted or Private:

If using private agent, provide the OS of the machine running the agent and the agent version: ADO agent v2.200.2

Issue Description
[Include task name(s), screenshots and any other relevant details]
Task logs
[Enable debug logging and please provide the zip file containing all the logs for a speedy resolution]
Troubleshooting
We have a step to set the artifact version using the following command
/usr/local/ado-agent/_work/_tool/maven/3.6.3/x64/apache-maven-3.6.3/bin/mvn -f /usr/local/ado-agent/_work/7/s/pom.xml --settings /usr/local/ado-agent/_work/_temp/.m2/settings.xml versions:set -DnewVersion=0.1.246 -DprocessAllModules -DgenerateBackupPoms=false

Our pipelines started to fail sometime because this step does not apply the new version to all of our submodules. Sometimes it skips a single child module, sometimes it skips a lot of modules, and there is no pattern.
In this example, the step skipped two children modules (Assertions and Model Classes) on a specific project

In this example, it skipped almost all of the children modules in another project (it applied the change on 4 of 22 modules)

In the following step, where our pipeline publishes these modules to Nexus, it fails because of some modules have the snapshot version.
Sometimes this step works properly applying the new version to all of the children modules.
Can someone help us?
Error logs
[Insert error from the logs here for a quick overview]

Hi @pedrofurlanetto thanks for reporting! We are working on more prioritized issues at the moment but will get back to this one soon.


add zh_cn translation

Oops... WTHIT's maven repository seems to be down. I'll wait for recovery.
Btw, thank you for your contribution:)


watcher is not added after certificate renewal in istio-proxy

Bug Description
Hi,
I think I found an issue that watcher is not added for some custom certificates mounted to istio-proxy after the certificate renewal. This causes pods with istio-proxy not to communicate with other services out of the mesh after the certificate expired.
Basically, this issue is affecting my egress usecase where the client certificates are defined in a DestinationRule. Also this issue happens occasionally. Also this issue happens occasionally.
Here are the steps followed and the istio-proxy logs:

After necessary certificates are created in a secret, those certificates are mounted to the istio-proxy using annotation.

sidecar.istio.io/userVolume:
  {"cm-mediator-client-cert":{"secret":{"optional":true,"secretName":"cm-mediator-client-cert"}},...
sidecar.istio.io/userVolumeMount:
  {"cm-mediator-client-cert":{"mountPath":"/etc/istio/cm-mediator-client-cert/","readOnly":true},...

Then DestinationRule with following tls configuration is applied:

tls:
        caCertificates: /etc/istio/sip-tls-trusted-root-cert/cacertbundle.pem
        clientCertificate: /etc/istio/cm-mediator-client-cert/clicert.pem
        mode: MUTUAL
        privateKey: /etc/istio/cm-mediator-client-cert/cliprivkey.pem

The certificate from "cm-mediator-client-cert" secret is read at the beginning and renewed without a problem several times for some time. However after multiple rotations (issue showed up after 14-15 hours with rotation each 30 min), no watcher is added for "/etc/istio/cm-mediator-client-cert/clicert.pem" (please check 2023-05-08T19:19:58.823159Z below) and the old certificate is being read, although the certificates in the secret "cm-mediator-client-cert" has been renewed. As a result istio-proxy cannot use a valid certificate after some time.

2023-05-08T04:35:26.590718Z	info	cache	adding watcher for file certificate /etc/istio/cm-mediator-client-cert/clicert.pem
2023-05-08T04:35:26.590761Z	info	cache	read certificate from file	resource=file-cert:/etc/istio/cm-mediator-client-cert/clicert.pem~/etc/istio/cm-mediator-client-cert/cliprivkey.pem
...
2023-05-08T04:44:15.792743Z	info	cache	read certificate from file	resource=file-cert:/etc/istio/wcdbcd-client-cert/clicert.pem~/etc/istio/wcdbcd-client-cert/cliprivkey.pem
2023-05-08T04:44:15.792842Z	info	ads	SDS: PUSH for node:timer-service-56b79b4489-gjl6j.nef-5g-ft-bp-450-cces-ns-1 resources:1 size:1.2kB resource:file-cert:/etc/istio/wcdbcd-client-cert/clicert.pem~/etc/istio/wcdbcd-client-cert/cliprivkey.pem
2023-05-08T04:44:15.792869Z	info	cache	event for file certificate /etc/istio/cm-mediator-client-cert/clicert.pem : REMOVE, pushing to proxy
2023-05-08T04:44:15.792909Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:11 Version:
2023-05-08T04:44:15.793061Z	info	cache	event for file certificate /etc/istio/wcdb-cert/clicert.pem : REMOVE, pushing to proxy
2023-05-08T04:44:15.793115Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:11 Version:
2023-05-08T04:44:15.793225Z	debug	envoy config	Received gRPC message for type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.Secret at version
2023-05-08T04:44:15.793250Z	debug	envoy config	Pausing discovery requests for type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.Secret (previous count 0)
2023-05-08T04:44:15.793344Z	debug	envoy config	Secret is updated.
2023-05-08T04:44:15.793400Z	info	cache	adding watcher for file certificate /etc/istio/cm-mediator-client-cert/clicert.pem
2023-05-08T04:44:15.793435Z	info	cache	read certificate from file	resource=file-cert:/etc/istio/cm-mediator-client-cert/clicert.pem~/etc/istio/cm-mediator-client-cert/cliprivkey.pem
...
2023-05-08T19:19:57.769582Z	debug	envoy connection	[C49083] closing data_to_write=143 type=0
2023-05-08T19:19:57.769586Z	debug	envoy connection	[C49083] setting delayed close timer with timeout 1000 ms
2023-05-08T19:19:57.769593Z	debug	envoy pool	[C3] response complete
2023-05-08T19:19:57.769598Z	debug	envoy pool	[C3] destroying stream: 0 remaining
2023-05-08T19:19:57.769643Z	debug	envoy connection	[C49083] write flush complete
2023-05-08T19:19:57.769648Z	debug	envoy connection	[C49083] closing socket: 1
2023-05-08T19:19:57.769664Z	debug	envoy conn_handler	[C49083] adding to cleanup list
2023-05-08T19:19:58.822358Z	info	cache	event for file certificate /etc/istio/wcdb-cert/clicert.pem : REMOVE, pushing to proxy
2023-05-08T19:19:58.822422Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:11 Version:
2023-05-08T19:19:58.822545Z	info	cache	event for file certificate /etc/istio/data-coordinator-zk-client-cert/clicert.pem : REMOVE, pushing to proxy
2023-05-08T19:19:58.822551Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:11 Version:
2023-05-08T19:19:58.822798Z	info	cache	event for file certificate /etc/istio/wcdbcd-client-cert/clicert.pem : REMOVE, pushing to proxy
2023-05-08T19:19:58.822824Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:11 Version:
2023-05-08T19:19:58.822892Z	info	cache	event for file certificate /etc/istio/cm-mediator-client-cert/clicert.pem : REMOVE, pushing to proxy
2023-05-08T19:19:58.822916Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:11 Version:
2023-05-08T19:19:58.822944Z	info	cache	adding watcher for file certificate /etc/istio/data-coordinator-zk-client-cert/clicert.pem
2023-05-08T19:19:58.822978Z	info	cache	read certificate from file	resource=file-cert:/etc/istio/data-coordinator-zk-client-cert/clicert.pem~/etc/istio/data-coordinator-zk-client-cert/cliprivkey.pem
2023-05-08T19:19:58.823055Z	info	ads	SDS: PUSH for node:timer-service-56b79b4489-gjl6j.nef-5g-ft-bp-450-cces-ns-1 resources:1 size:1.2kB resource:file-cert:/etc/istio/data-coordinator-zk-client-cert/clicert.pem~/etc/istio/data-coordinator-zk-client-cert/cliprivkey.pem
2023-05-08T19:19:58.823085Z	info	cache	adding watcher for file certificate /etc/istio/wcdb-cert/clicert.pem
2023-05-08T19:19:58.823102Z	info	cache	read certificate from file	resource=file-cert:/etc/istio/wcdb-cert/clicert.pem~/etc/istio/wcdb-cert/cliprivkey.pem
2023-05-08T19:19:58.823129Z	info	ads	SDS: PUSH for node:timer-service-56b79b4489-gjl6j.nef-5g-ft-bp-450-cces-ns-1 resources:1 size:1.2kB resource:file-cert:/etc/istio/wcdb-cert/clicert.pem~/etc/istio/wcdb-cert/cliprivkey.pem
2023-05-08T19:19:58.823159Z	info	cache	read certificate from file	resource=file-cert:/etc/istio/cm-mediator-client-cert/clicert.pem~/etc/istio/cm-mediator-client-cert/cliprivkey.pem
2023-05-08T19:19:58.823218Z	info	ads	SDS: PUSH for node:timer-service-56b79b4489-gjl6j.nef-5g-ft-bp-450-cces-ns-1 resources:1 size:1.2kB resource:file-cert:/etc/istio/cm-mediator-client-cert/clicert.pem~/etc/istio/cm-mediator-client-cert/cliprivkey.pem
2023-05-08T19:19:58.823217Z	info	cache	adding watcher for file certificate /etc/istio/wcdbcd-client-cert/clicert.pem
2023-05-08T19:19:58.823247Z	info	cache	read certificate from file	resource=file-cert:/etc/istio/wcdbcd-client-cert/clicert.pem~/etc/istio/wcdbcd-client-cert/cliprivkey.pem
2023-05-08T19:19:58.823297Z	info	ads	SDS: PUSH for node:timer-service-56b79b4489-gjl6j.nef-5g-ft-bp-450-cces-ns-1 resources:1 size:1.2kB resource:file-cert:/etc/istio/wcdbcd-client-cert/clicert.pem~/etc/istio/wcdbcd-client-cert/cliprivkey.pem
2023-05-08T19:19:58.823324Z	debug	envoy config	Received gRPC message for type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.Secret at version

Do you know what could be leading watcher addition to be skipped for the certificate?
I don't have a proper bug-report to share at the moment as I'm struggling to make a small POC to reproduce the issue.
As of now the issue happens very rarely.
Thanks in advance.
Best regards
Version
Istio 1.14.5 and above

Additional Information
No response
Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

I think it is because we are using the upstream fsnotify instead of istio one, which is better suitavle for k8s volumemount

istio.io/pkg/filewatcher watches parent directory path

Please set sidecar.istio.io/agentLogLevel : debug and share the log

Hello everyone,
I'm just jumping in to say that I managed to reproduce the issue after many tries.
The issue can be reproduced very sporadically, so far, I only managed to reproduce it twice.
One time it happened after I rotated the certificate ~700 times and one time it happened after only 80 rotations.
From the debug logs of the istio-proxy you can see one rotation which was performed correctly and one which led to an out-of-sync ca cert:
2023-05-11T11:37:43.568520Z	info	cache	event for file certificate /etc/sleep/ca_certs/example.com/cacert : REMOVE, pushing to proxy
2023-05-11T11:37:43.568611Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:4 Version:
2023-05-11T11:37:43.568644Z	debug	cache	removing file /etc/sleep/ca_certs/example.com/cacert from file certs
2023-05-11T11:37:43.568824Z	debug	ads	Skipping push to sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-2, no updates required
2023-05-11T11:37:43.568883Z	info	cache	event for file certificate /etc/sleep/client_certs/client.example.com/tls.crt : REMOVE, pushing to proxy
2023-05-11T11:37:43.568958Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:4 Version:
2023-05-11T11:37:43.568975Z	debug	cache	removing file /etc/sleep/client_certs/client.example.com/tls.crt from file certs
2023-05-11T11:37:43.568994Z	debug	ads	Skipping push to sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-2, no updates required
2023-05-11T11:37:43.568880Z	debug	ads	Skipping push to sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-4, no updates required
2023-05-11T11:37:43.569045Z	debug	cache	generate secret "file-cert:/etc/sleep/client_certs/client.example.com/tls.crt~/etc/sleep/client_certs/client.example.com/tls.key"
2023-05-11T11:37:43.568901Z	debug	ads	Skipping push to sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-1, no updates required
2023-05-11T11:37:43.569223Z	debug	ads	Skipping push to sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-1, no updates required
2023-05-11T11:37:43.569319Z	debug	cache	generate secret "file-root:/etc/sleep/ca_certs/example.com/cacert"
2023-05-11T11:37:43.569486Z	info	cache	adding watcher for file certificate /etc/sleep/ca_certs/example.com/cacert
2023-05-11T11:37:43.569528Z	info	cache	read certificate from file	resource=file-root:/etc/sleep/ca_certs/example.com/cacert
2023-05-11T11:37:43.569595Z	info	cache	adding watcher for file certificate /etc/sleep/client_certs/client.example.com/tls.crt
2023-05-11T11:37:43.569635Z	info	cache	read certificate from file	resource=file-cert:/etc/sleep/client_certs/client.example.com/tls.crt~/etc/sleep/client_certs/client.example.com/tls.key
2023-05-11T11:37:43.569668Z	debug	ads	SDS: PUSH for node:sleep-5bf448844f-4z7jx.istio-mt-esarleo-0 resources:1 size:1.2kB resource:file-root:/etc/sleep/ca_certs/example.com/cacert
2023-05-11T11:37:43.569712Z	debug	ads	Skipping push to sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-3, no updates required
2023-05-11T11:37:43.569730Z	debug	ads	SDS: PUSH for node:sleep-5bf448844f-4z7jx.istio-mt-esarleo-0 resources:1 size:2.9kB resource:file-cert:/etc/sleep/client_certs/client.example.com/tls.crt~/etc/sleep/client_certs/client.example.com/tls.key
2023-05-11T11:37:43.572197Z	debug	ads	ADS:SDS: REQ sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-4 resources:1 nonce:448eca3d-dbda-4076-a98a-5650409d565c version:
2023-05-11T11:37:43.572218Z	debug	ads	ADS:SDS: ACK sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-4  448eca3d-dbda-4076-a98a-5650409d565c
2023-05-11T11:37:43.572229Z	debug	ads	ADS:SDS: REQ sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-3 resources:1 nonce:b0afa3bf-8cac-46b2-a43d-2bcc7929bc9a version:
2023-05-11T11:37:43.572241Z	debug	ads	ADS:SDS: ACK sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-3  b0afa3bf-8cac-46b2-a43d-2bcc7929bc9a
2023-05-11T11:39:08.584927Z	info	cache	event for file certificate /etc/sleep/client_certs/client.example.com/tls.crt : REMOVE, pushing to proxy
2023-05-11T11:39:08.584986Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:4 Version:
2023-05-11T11:39:08.584996Z	debug	cache	removing file /etc/sleep/client_certs/client.example.com/tls.crt from file certs
2023-05-11T11:39:08.585039Z	debug	cache	generate secret "file-cert:/etc/sleep/client_certs/client.example.com/tls.crt~/etc/sleep/client_certs/client.example.com/tls.key"
2023-05-11T11:39:08.585140Z	debug	ads	Skipping push to sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-1, no updates required
2023-05-11T11:39:08.585178Z	debug	ads	Skipping push to sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-2, no updates required
2023-05-11T11:39:08.585237Z	debug	ads	Skipping push to sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-3, no updates required
2023-05-11T11:39:08.585249Z	info	cache	event for file certificate /etc/sleep/ca_certs/example.com/cacert : REMOVE, pushing to proxy
2023-05-11T11:39:08.585284Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:4 Version:
2023-05-11T11:39:08.585321Z	info	cache	adding watcher for file certificate /etc/sleep/client_certs/client.example.com/tls.crt
2023-05-11T11:39:08.585357Z	info	cache	read certificate from file	resource=file-cert:/etc/sleep/client_certs/client.example.com/tls.crt~/etc/sleep/client_certs/client.example.com/tls.key
2023-05-11T11:39:08.585388Z	debug	cache	generate secret "file-root:/etc/sleep/ca_certs/example.com/cacert"
2023-05-11T11:39:08.585594Z	debug	cache	already watching file for /etc/sleep/ca_certs/example.com/cacert
2023-05-11T11:39:08.585604Z	debug	ads	Skipping push to sleep-5bf448844f-4z7jx.istio-mt-esarleo-0-1, no updates required
2023-05-11T11:39:08.585611Z	info	cache	read certificate from file	resource=file-root:/etc/sleep/ca_certs/example.com/cacert
2023-05-11T11:39:08.585628Z	debug	cache	removing file /etc/sleep/ca_certs/example.com/cacert from file certs

As you can see it can happen that after the secret has been rotated the watcher is not created due to the file already being watched.
2023-05-11T11:39:08.585594Z	debug	cache	already watching file for /etc/sleep/ca_certs/example.com/cacert
And this seems to eventually lead to the out-of-sync cert.
Could it be a race condition between the creation and removal of watchers?
Here is the full bug-report.zip and the istio-proxy.log

I think I understand the issue and tried to fix in https://github.com/istio/istio/pull/44890. Is it possible to test that patch?

Hello @ramaraochavali
Sure, I will test it right away, but I will need 2 days as the issue is hardly reproducible even without the fix

@LithiumSR Thank you so much.

Hello @ramaraochavali
I have performed more than 1300 cert rotations and the issue could not be reproduced.
I think we can assume that it is fixed.
Thank you a lot!

@LithiumSR Thank you so much for the update


twitch stream key

i wonder if its possible to retrieve stream key.. or if u could add the possibility to do that

You can use the twitchClient.getChannelEndpoint("channelName").getChannelPrivilegied() Method to get more information than with the default getChannel(). You can then use channel.getStreamKey() to get the stream key. This requires the channel_read scope.
The new helix api does not support returning stream keys right now - so this feature might vanish once we upgrade to helix if they didn't add it until then.


PHPStorm keeps on updating the project

I'm using PHPStorm on macOS and have the Docker Compose application running. PHPStorm goes crazy because it keeps on refreshing the index. Any idea what can cause this? I already excluded the var directory.
Could it be related to the :delegated mount? That Docker syncs everything back from the container to the host?

Upgraded to latest EAP, dropped .idea folder, and restarted seems to fix it. Weird. First time I see this issue.


Authentication does not work without internet access

It seems after authentication, the auth server redirects to omnibear.com
This does not work without internet.

Works fine with Omnibear 0.6.0 on Firefox 55.


psr-7 attempt to set the Host header during construction

fixes: zendframework#172

Thanks, @pine3ree


Other websocket engine/server support

In my project i using socket.io with uws engine (it "fastester", because it written with C++), and i using it on csgo.tm, csgo.com, dota2.net, etc. (over  15000 connections at the peak (16 threads CPU, see screenshot below

import http from 'http'
import socketIO from 'socket.io'

const server = http.Server(app)
const io = socketIO(server, {
	serveClient: false,
	wsEngine: 'uws',
	transports: ['websocket', 'polling']
})

How i can connect this engine to the subscriptions-transport-ws?

@Maxpain177 WebSockets and socket.io are related but different technologies. If you want to use socket.io, you'd have to build your own transport, which shouldn't be too hard based on the example of this repo.

Thanks

Max, are you getting worse performance with vanilla websockets in gql subscriptions?

@scf4 Yes, but without gql subs. When i using websocket server, writen on pure javascript, cpu usage increases twice.

I just found this: https://www.npmjs.com/package/subscriptions-transport-socketio
I haven't checked it out and there's no GH repo for it but let me know how it goes!

@scf4 It's our package :)

@Maxpain177 please consider adding it to https://github.com/chentsulin/awesome-graphql =)

@maxpain177 could you post it on GitHub?

@scf4 Done.


Quickstart document should use pingora v0.3

Describe the bug
The quickstart tutorial includes a step near the end for adding built-in argument parsing functionality in the server. The interface used for this was not introduced until the v0.3.0 release from what I can tell, but the current quickstart document suggests using the v0.1.0 release.
Pingora info
Pingora version: v0.1.0
Rust version: cargo 1.82.0-nightly
Operating system version: Ubuntu 22.04
Steps to reproduce
Follow the quickstart tutorial at https://github.com/cloudflare/pingora/blob/main/docs/quick_start.md verbatim until you reach https://github.com/cloudflare/pingora/blob/main/docs/quick_start.md#command-line-options. Upon adding those lines, the compiler is unable to detect the Opt::parse_args interface.
Expected results
Expected to walk through each step of the tutorial and run it.
Observed results
When using the existing documentation, the program doesn't compile part-way through the quickstart tutorial.
Additional context
None

Because this is a largely trivial documentation change, I went ahead and opened up a PR at https://github.com/cloudflare/pingora/pull/433. Feel free to take it or leave it!

Whoops! Thanks for the pr. We will fix that soon (and give you credit for it)

This was fixed with your PR as part of the weekly sync. Thank you for your contributions! 🎉


[PE-D][Tester F] Table column names do not fit in the application window size

When the application is started with the default resolution, most of the columns for the table are truncated due to their larger font size. This causes the user some inconvenience from a user experience standpoint.

Labels: severity.VeryLow type.FeatureFlaw
original: kevin-pek/ped#3

enhancement


The typecheck option not working as expected

Describe the bug
The typecheck function does not work very well and has many problems.

This configuration didn't work at all when I used typecheck.include.
When I don't use it, it fails to detect and classify type errors in files ending with .spec.
At the same time, it can only detect and classify type errors in files ending with .spec-d.

These phenomena describe what makes the answer to this issue seem inaccurate.
Reproduction
https://github.com/NWYLZW/recurrent-vitest-typecheck-include
There are two script here, namely test:a, test:b and test:c.

test:a no typecheck.include
test:b set the typecheck.include
test:c set the include and typecheck.include

System Info
System:
  OS: macOS 14.1.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 90.98 MB / 32.00 GB
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 18.19.0 - /usr/local/bin/node
  Yarn: 1.22.19 - /usr/local/bin/yarn
  npm: 10.2.3 - /usr/local/bin/npm
  pnpm: 8.12.1 - ~/Library/pnpm/pnpm
Browsers:
  Safari: 17.1
npmPackages:
  vitest: ^1.0.4 => 1.0.4

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I think a part of the confusing behavior might be coming from the fact that include option requires **/ prefix.
Your example uses src/**/*.spec.ts but I think that needs to be **/src/**/*.spec.ts to match something. This is confusing but  glob pattern usually works in that way in Vite ecosystem.
Here is what I changed https://stackblitz.com/edit/github-31y6zp?file=vitest.config.b.js
After changing that, I see unhandled errors which seems to be coming from typescript errors of non type test files.
That's probably not an intended behavior so it could be Vitest's bug.

When I replace typecheck.include: src/**/*.spec.ts to **/src/**/*.spec.ts, it works.
Indeed, I also saw type errors for files that were not marked in the include field. This is probably another problem, but the solution you provided can solve my problem.
Thank you.

Hey, glad you figured it out.
I suppose this issue was mainly about typecheck.include flag, so can you close this issue?
If other issues come up, then please feel free to create a new issue. Thanks!


[WIP] npm - update everything

Cleans up & updates npm dependencies..
Closes #59

notes...
wiredep 2.2.2 > 3.0 (and 4.0) - breaks order of jquery

@himdel would you like me to have @AllenBW finish this, or would can you get this over?

@chriskacerguis depends, I probably won't be able to do this in the next few weeks, so.. @AllenBW how much time do you have? ;)

@himdel I'll get @AllenBW to do his mojo and update everything.

Closing this PR, I moved this to a new issue https://github.com/ManageIQ/manageiq-ui-self_service/issues/143


Noe/revoke from UI

Implement revocation action from the UI (in Profile)

cleanup evm utils
rename existing web util (for tx frames)useExternalProvider to useExternalSigner
implement a WalletPicker drawer UI, to select an external wallet to link to the app
keep the wallet that was linked during onboarding into memory rather than forgetting it
implement the useExternalSigner helper for react native using thirdweb
implement a useXmtpSigner helper to get an external / privy signer that matches the XMTP client owner address
implement the revoke method using that signer, to revoke other installations

Very excited about this one, this leads the way for transactional frames work next week!

This is really great! There's a few dark mode styles that need to be cleaned up and probably some word play from a product perspective, but I thin we can create an internal feature build to get some additional testing on it before releasing, but really amazing progress on this 😄

@alexrisch word play here: https://github.com/ephemeraHQ/converse-app/pull/916

@alexrisch I applied some corrections and launched build 2.0.3 internally


arch: aarch64: do EL2 init in EL3 if necessary

If EL2 is implemented but we're skipping EL2, we should still
do EL2 init.
This in particular causes problems when different
cores have different virtual timer offsets.
Signed-off-by: James Harris<EMAIL_ADDRESS>

@MrVan - FYI.


Problems with setting the filters for the time curve

I´ve a bug in the iPhone App (Demo App with Demo Thingsboard).
Newest iOS 15.3

The Refresh button "Aktualisieren" remains greyed out, the only thing I can do is cancel.

Thank you for reporting the issue,
This issue will be resolved in TB 3.3.4 version (main product, not mobile app).

I´ve tryed with 3.3.4 now it works. thx for fixing it!


Fix OMP_NUM_THREADS code block in array best practices

Currently the
export OMP_NUM_THREADS=1
export MKL_NUM_THREADS=1
export OPENBLAS_NUM_THREADS=1

code block in the "Avoid Oversubscribing Threads" section of the array best practices documentation isn't being rendered. Specifying bash as the language fixed the issue locally.

Thanks @jrbourbeau !


Debug

WIP to inspect why Pylot does not generate any results after a simulation

@rsomers1998 Thanks a lot for your contributions! Do you think the new bug you found is now fixed with https://github.com/ADS-Testing/SAMOTA/pull/5/commits/4304713d0f3c3e337322019e2e80a3a238ad641b?
Also, do you mind if we keep this branch for debugging and put implementation/runner/run_SAMOTA_c.py into another branch, e.g., causal-testing?

Apologies, I did not mean to commit that file. It has been removed from this branch.
The other bug appears to be a versioning issue with protobuf. The suggested fix is to Downgrade the protobuf package to 3.20.x or lower. as we are currently using 4.25.0. I have not messed with this and am just using the workaround for now as I don't know what is causing the dependency and what other versions/interfaces may need to be changed.

Turns out protobuf could just be downgraded without breaking anything. This fixes the warning (https://github.com/ADS-Testing/SAMOTA/issues/6#issuecomment-1794926969) and also issue #8

Commit a5dcb30 seems to fix simulation not acknowledging finished.txt. Simulation does not always wait the full 660 seconds now


Zipline: Stylize Stories on Camper News -- Refers to depreciated features

Challenge http://freecodecamp.com/challenges/zipline-stylize-stories-on-camper-news has an issue.

User Story: As a user, I can click a link to go directly to the post's discussion page.

News posts no longer have a discussion page.

You might need to do a hard refresh, because this was fixed 4 days ago in 9abac81db5a01be223088bca197065143f5f6daf ;)
Thank you for reporting though! Remember to close this issue.

Closing this issue as it is solved in 9abac81. @ahstro thanks.


ajax DataSource

Hey!
I'm trying to make it where I can pull events per a year instead of one call. I tried renderEnd which just causes an endless loop because I used the setDataSource (is there any other way to add events? I didn't see any in the documentation). customDataSourceRenderer works only on initial load. Is there a way to do it by year?
Thanks!

I just update the widget to improve AJAX management.
Now you can use AJAX request to load your datasource when changing the current year, with the following code :
var calendar = $('#calendar').calendar({
	yearChanged: function(e) {
		e.preventRendering = true;

		$(e.target).append('

');

		$.ajax({
			url: "your-url",
			success: function(dataSource) {
				$(e.target).data('calendar').setDataSource(dataSource);
			}
		});
	}
});

Then, if you want to make your first loading using AJAX (if the data of the current year are not loaded with the page), just add the following line :
calendar.setYear(new Date().getFullYear());

You should have something like this :

Paul,
I am new to this. Can you provide an example of server code (C# prefer) that generate the datasource?
Thanks!

My code behind:
var dataSource = from b in bookings
select new
{
id =  b.VillaID,
name = b.Actions.ToString(),
location = b.Notes,
startDate = b.CheckInDate.ToShortDateString(),
endDate = b.CheckOutDate.ToShortDateString()
};
                var rows = dataSource.ToArray();
                var retVal = Json(rows, JsonRequestBehavior.AllowGet);
                return retVal;

Event yearChanged is not mentioned in documentation: http://www.bootstrap-year-calendar.com/#Documentation/Events

$(e.target).data('calendar').setDataSource(dataSource); doesn't works!

It should work.
Here is full, working example. I use it in my calendar: https://github.com/Paul-DS/bootstrap-year-calendar/issues/103

With the current version not having the yearChanged event yet - I found I could get around it using the renderEnd event thus:
    renderEnd: function(e) {
        if (yearSave != e.currentYear) { getyear(e.currentYear); }
        yearSave = e.currentYear;
    },

If at the end of a render, the year has changed since the last render - then reload the next year.
My getyear function is below.  (I'm using twig to generate the page - hence the {{}}'s) Note that after getting the ajax data back, I have to correct the date formats, as the calendar requires 'date' format objects which can't be sent directly by ajax.
function getyear(year)
{
    $.ajax({
        url: "{{ path_for('trip.yearjson',{'year':''}) }}"+year,
        success: function(dataSource) {
            console.log("loaded source");
        var objs = JSON.parse(dataSource);  {# Convert to manageable format #}
        for (var i = 0; i < objs.length; i++)
        {
            objs[i].startDate = new Date(objs[i].startDate);
            objs[i].endDate = new Date(objs[i].endDate);
        }
        $('#calendar').data('calendar').setDataSource(objs);
        }
    });

Hi, @robandwend if not wrong year changed it's include on this repo (not on actual release) you can check is mentioned on #139 if not wrong.

You should document de deprecated functions in the documentation.
the renderEnd function by yearChanged works fine.
thank you @robandwend .


Arrow Support

Hi, I can't find that dataframe supports Arrow as internal serialization / backend.
Is this something which you're working on?

Hi, Lundez!
Currently DataFrame doesn't use Arrow as backend, but it's definitely on the roadmap.
Until now we were mostly focused on frontend part: typesafe Kotlin API, code generation, schema inference and other tricks that provide great experience when you work with data in Kotlin. But now API and overall data model are getting stable, so it's time to do more performance tuning and scalability, including Arrow support.
Currently the project has only two active contributors, so any help will be very much appreciated!

Hi, do you have any headers on how to start?
Do you think the java arrow API can work with your "typing" (or whatever to call the typing is used in data frames)? 😊
I think adding arrow would give this project a big boost.
Also adding a query optimizer would follow up as a huge bonus, like pola.rs / spark. To optimize columns and other this when using arrow makes a lot of sense! 😄

I have some experience with arrow (as an arrow committer) so let me try to set this up.
Current plan is to split into two parts:

Arrow schema reading
Arrow file / data loading and off-heap memory management

@Jimexist incredibly excited to hear this!

Currently the project has only two active contributors, so any help will be very much appreciated!

What do you think about my last PR-s?
Also I have made some code writing to Arrow but it does not cover all DataFrame-supported column types (was made for Krangl originally)

Hello again.
I am working with more complex unit test for Arrow reading. Will make PR a little later.
Just now, you can look at data example and code it was generated with here

@koperagen, @nikitinas, I want your opinion about the next detail.
In Arrow schema we have nullable flag but it's value does not depend on column content. And we may get a column that is marked as not nullable but actually contains null values. Here is an example.
So, we can:

Ignore nullable flag in the file, read all data and set nullable flag in DataFrame schema if and only if there are null values in the column;
Look at nullable flag and always copy it to DataFrame schema; thus reading data like above will produce an error;
Look at nullable flag, copy it to DataFrame schema by default and then change not nullable to nullable if there are null values.

What behavior is the best and should we support different of them, in your point of view?

@koperagen, @nikitinas, I want your opinion about the next detail.
In Arrow schema we have nullable flag but it's value does not depend on column content. And we may get a column that is marked as not nullable but actually contains null values. Here is an example.
So, we can:

Ignore nullable flag in the file, read all data and set nullable flag in DataFrame schema if and only if there are null values in the column;
Look at nullable flag and always copy it to DataFrame schema; thus reading data like above will produce an error;
Look at nullable flag, copy it to DataFrame schema by default and then change not nullable to nullable if there are null values.

What behavior is the best and should we support different of them, in your point of view?

Could we support different read-modes? Defaulting to first or third makes sense, but a strict-mode would be great (second) through a flag/read-mode IMO

@koperagen, @nikitinas, I want your opinion about the next detail.
In Arrow schema we have nullable flag but it's value does not depend on column content. And we may get a column that is marked as not nullable but actually contains null values. Here is an example.
So, we can:

Ignore nullable flag in the file, read all data and set nullable flag in DataFrame schema if and only if there are null values in the column;
Look at nullable flag and always copy it to DataFrame schema; thus reading data like above will produce an error;
Look at nullable flag, copy it to DataFrame schema by default and then change not nullable to nullable if there are null values.

What behavior is the best and should we support different of them, in your point of view?

Hm, i would prefer 1 as a default, because in REPL it can help avoid unnecessary null handling when there are no nulls. But we also need 3 for Gradle plugin which generates schema declaration from data sample.
Do i understand the second option right? Something like this would be possible?
    val df = DataFrame.readArrow()

    df.notNullableColumn.map { it  / 2 } // null pointer exception

I think we shouldn't have this mode unless there is very strong evidence that it is very useful for someone :)
Or do you mean this?
    val df = DataFrame.readArrow() // Exception: notNullableColumn marked not nullable in schema, but has nulls

All that reminds me of "Infer" that is used as a flat for some operations.

Thank you for highlighting Infer enum. It can probably be used as parameter.

Hm, i would prefer 1 as a default

OK, thanks for sharing.
About 2, I expected something like
val df = DataFrame.readArrow() // Exception: notNullableColumn marked not nullable in schema, but has nulls

when callnig
DataColumn.createValueColumn(field.name, listWithNulls, typeNotNullable, Infer.None)

but actually we have
val df = DataFrame.readArrow()
df.notNullableColumn.map { it  / 2 } // null pointer exception

now. I will fix that.
Where can I read more about the Gradle plugin? How do you use it?

I suggest next mapping if use Infer as a parameter:

Infer.Nulls — set nullable flag in DataFrame schema if and only if there are null values in the column, make default;
Infer.None — copy Arrow schema to DataFrame, throw Exception like "notNullableColumn marked not nullable in schema, but has nulls";
Infer.Type — copy Arrow schema to DataFrame, change not nullable to nullable if there are null values. Or it actually would be the same as Infer.Nulls (single type is already guaranteed by Arrow).

Where can I read more about the Gradle plugin? How do you use it?

https://kotlin.github.io/dataframe/gradle.html

I suggest next mapping if use Infer as a parameter:

I'm not sure about it anymore. Because Infer.Type does a different thing in other operations. Infer.Nulls is
"actual data nullability" == "schema nullability", and in our case
"set nullable flag in DataFrame schema if and only if there are null values in the column" is "narrow nullability if possible", and a third option is "widen nullability if needed"
What do you think about a new enum, let's say something like SchemaVerification? It describes variants of this operation:
actual nullability (from data) + schema nullability (from file) -> nullability | error
Maybe some other name, idk

Implemented in #129


Feature Request: Add info about the resources under chaos

Feature Request: Add info about the resources under chaos
Feature request
What happened: ChaosEngine and ChaosResult do not contain information about the specific target of the chaos.
For instance if I leave the 'appLabel' field empty, when the engine executes, how will I know on which pod, exactly did the chaos happen. Even if appLabel is filled, it would still be
helpful to know the targets of the chaos. I can only see the targeted pod if i look at the logs of the helper pod.
What you expected to happen: I expect to be able to see the names of the pods, that the ChaosEngine is injecting chaos into, as well as the deployment they belong to. Either in the
ChaosEngine or the ChaosResult.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?: A 'nice to have' would be to have a verdict (from ChaosResult) for each unique deployment. For example if 1 ChaosEngine does pod-kill on 3 pods, each from
a different deployment and the verdict is Fail, does this mean that one of them failed or all 3 ?

This is a great requirement!!

We added this here: https://github.com/litmuschaos/litmus-go/pull/336, thanks for raising this issue! :)


Require since-annotation on Java public API members

Partially addresses https://github.com/gradle/gradle/issues/27113 for public API written in Java.
Enforcement for Kotlin APIs will be done in a follow-up.
An example of what is expected to be since-annotated:
/**
 * @since 8.6
 */
public enum NewEnum {

    /**
     * @since 8.6
     */
    VALUE1;

    /**
     * @since 8.6
     */
    public static final String STATIC_FIELD = "";

    /**
     * @since 8.6
     */
    public void publicMethod() {}

    // @since not required for non-public methods
    private void privateMethod() {}

    // @since not required for overridden methods
    @Override
    public String toString() {return super.toString();}
}

@ov7a, IIUC this rule is only enforced for the incubating members added in the current version of Gradle.
And for this there were some violations, which I addressed in a preliminary PR to keep them separated.
All the checks seem to be passing

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.


[Issue]: Error 404 installing 'latest' node version

What happened?
I can't install the latest version of node via nvm install lastest
It throws:
Error retrieving "https://nodejs.org/dist/latest-lastest/SHASUMS256.txt": HTTP Status 404

If I access the URL through a browser, I get a 404 error.
What did you expect to happen?
Install the latest version
Version
1.1.11 or newer (Default)
Which version of Windows?
Windows 10 (Default)
Which locale?
Other Non-English
Which shell are you running NVM4W in?
Command Prompt
User Permissions?
Administrative Privileges, Elevated
Is Developer Mode enabled?
None
Relevant log/console output
No response
Debug Output
Running NVM for Windows with administrator privileges.
Error getting console handle: La operación se completó correctamente.
Windows Version: 10.0 (Build 20348)

NVM4W Version:      1.1.12
NVM4W Path:         C:\Users\Administrador\AppData\Roaming\nvm\nvm.exe
NVM4W Settings:     C:\Users\Administrador\AppData\Roaming\nvm\settings.txt
NVM_HOME:           C:\Users\Administrador\AppData\Roaming\nvm
NVM_SYMLINK:        C:\Program Files\nodejs
Node Installations: C:\Users\Administrador\AppData\Roaming\nvm

Total Node.js Versions: 2
Active Node.js Version: v22.6.0

No problems detected.

Find help at https://github.com/coreybutler/nvm-windows/wiki/Common-Issues

Anything else?
No response

I can confirm this is a bug.
Note to self: The latest version is being handled literally instead of converting to the latest version or dropping the version. Notice the link is https://nodejs.org/dist/latest-lastest/SHASUMS256.txt when it should be https://nodejs.org/dist/latest/SHASUMS256.txt or https://nodejs.org/dist/latest-v22.x/SHASUMS256.txt.

yes, i have same problem ，how can i do？

yes, i have same problem ，how can i do？

https://github.com/coreybutler/nvm-windows/issues/1164#issuecomment-2284158568

What happened?
I can't install the latest version of node via nvm install lastest
It throws:
Error retrieving "https://nodejs.org/dist/latest-lastest/SHASUMS256.txt": HTTP Status 404

I think there's a typo, it should be nvm install latest

Yes, Indeed its typo mistake, the command worked without any error

I close the issue.
Thanks, @wsobolewski & @Tejas-Sharma-dev 😅


Convenience function for single axis figure

I use this in various Notebooks as a convenience function to get a single-axis figure but still using faceted's kwargs (see code below).  Any interest in including it or something like it in faceted proper?  Another alternative would be for faceted to return a single ax instance rather than a length-1 array in the case of a single-paneled plot.
Basically this is to avoid having to do
fig, axarr = faceted(1, 1, width=4)
ax = axarr[0]

and instead simply do
fig, ax = facet_ax()

def facet_ax(width=4, cbar_mode=None, **kwargs):
    """Use faceted to create single panel figure."""
    if cbar_mode is None:
        fig, axarr = faceted(1, 1, width=width, **kwargs)
        return fig, axarr[0]
    else:
        fig, axarr, cax = faceted(1, 1, width=width,
                                  cbar_mode=cbar_mode, **kwargs)
        return fig, axarr[0], cax

I agree some sort of convenience functionality like this would be very nice.  I have this use-case a lot too!  I've gotten in the habit of doing something like this:
fig, (ax, ), cax = faceted(1, 1, width=4, cbar_mode='single')

i.e. leveraging tuple unpacking to keep things all on one line.
In principle I'm not opposed to adding a separate function, but I feel like that could be awkward too in an interactive setting; e.g. it might mean you need to go back and import another function on the fly.  I know in the case of a single set of axes, @nathanieltarshish in the past has suggested always returning that instead of a length-one list, similar to plt.subplots.  What are your thoughts on that approach?
I guess one drawback is that axes is no longer guaranteed to be an iterable, though I don't think that's something I personally rely on too much; maybe others do.
Regardless though, I'm happy to discuss this more and take a PR to address it.  It's been on my radar for some time, despite not having an open issue.  Thanks for bringing it up!

I guess one drawback is that axes is no longer guaranteed to be an iterable, though I don't think that's something I personally rely on too much; maybe others do.

Well, I guess my single-panel workaround and others' depend on this, but I wouldn't mind changing my code where necessary.  I don't automate plot making all that much.

fig, (ax, ), cax = faceted(1, 1, width=4, cbar_mode='single')
Ahhh, I didn't realize that you could wrap ax in a tuple to do this as a one-liner.  Honestly, that's sufficient for my needs for the time being.  I.e. don't expect a PR!
I guess one drawback is that axes is no longer guaranteed to be an iterable, though I don't think that's something I personally rely on too much; maybe others do.
A way of avoiding this would be to implement it as a separate function.

No worries; sounds good.  I agree a separate function is the least disruptive way to add this convenience option.  In re-reading your initial post, I now see that you also described the alternative I suggested 🤦♂.  Sorry, it's been a busy week...


Formatting fixes

Summary

Ticket Link

@justinegeffen addressed but it still says changes are requested so idk what's going on here.

@justinegeffen addressed but it still says changes are requested so idk what's going on here.

I think I sorted that out, thanks for letting me know!


Buildpack test

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/test all