Bug 2016058: Bump openshift-sync-plugin to 1.0.51 and various dependant plugins

Hi @gabemontero ,
Here a test PR with the latest build. Let's see if it works well.
/assign @gabemontero

/retest

/retest

/test images

/retest

/retest

The image build was failing as this is happening sometimes after fresh push of the sync plugin: The plugin copy is not propagated to all the repositories instances; and downloading the plugin then fails.
After some retests; it seems to work.

/retitle  Bug 2016058: Bump openshift-sync-plugin to 1.0.51 and various dependant plugins

I will let the tests pass and push an updated PR with your requirements @gabemontero then.

The installed plugins look good, including the plugins we removed from the list that are not getting fetched based on sync plugin's new dependencies:
2021-12-16T15:04:12.036181548Z Installed plugins:
2021-12-16T15:04:12.042699150Z ace-editor:1.1
2021-12-16T15:04:12.048401557Z ant:1.11
2021-12-16T15:04:12.054268154Z apache-httpcomponents-client-4-api:4.5.13-1.0
2021-12-16T15:04:12.060121028Z authentication-tokens:1.4
2021-12-16T15:04:12.066193687Z blueocean-autofavorite:1.2.4
2021-12-16T15:04:12.072081305Z blueocean-bitbucket-pipeline:1.24.8
2021-12-16T15:04:12.077997479Z blueocean-commons:1.24.8
2021-12-16T15:04:12.083819549Z blueocean-config:1.24.8
2021-12-16T15:04:12.089817228Z blueocean-core-js:1.24.8
2021-12-16T15:04:12.095704603Z blueocean-dashboard:1.24.8
2021-12-16T15:04:12.101755105Z blueocean-display-url:2.4.1
2021-12-16T15:04:12.107627324Z blueocean-events:1.24.8
2021-12-16T15:04:12.113503357Z blueocean-github-pipeline:1.24.8
2021-12-16T15:04:12.119307226Z blueocean-git-pipeline:1.24.8
2021-12-16T15:04:12.125268428Z blueocean-i18n:1.24.8
2021-12-16T15:04:12.131164057Z blueocean:1.24.8
2021-12-16T15:04:12.151748453Z blueocean-jwt:1.24.8
2021-12-16T15:04:12.157964460Z blueocean-personalization:1.24.8
2021-12-16T15:04:12.164033242Z blueocean-pipeline-api-impl:1.24.8
2021-12-16T15:04:12.169888962Z blueocean-pipeline-editor:1.24.8
2021-12-16T15:04:12.175761730Z blueocean-pipeline-scm-api:1.24.8
2021-12-16T15:04:12.181785504Z blueocean-rest-impl:1.24.8
2021-12-16T15:04:12.187602454Z blueocean-rest:1.24.8
2021-12-16T15:04:12.193421254Z blueocean-web:1.24.8
2021-12-16T15:04:12.199266934Z bootstrap4-api:4.6.0-3
2021-12-16T15:04:12.205102967Z bouncycastle-api:2.25
2021-12-16T15:04:12.210806657Z branch-api:2.6.4
2021-12-16T15:04:12.216559806Z caffeine-api:2.9.2-29.v717aac953ff3
2021-12-16T15:04:12.222306256Z checks-api:1.7.2
2021-12-16T15:04:12.228139053Z cloudbees-bitbucket-branch-source:2.4.4
2021-12-16T15:04:12.233983172Z cloudbees-folder:6.16
2021-12-16T15:04:12.239779863Z config-file-provider:3.8.1
2021-12-16T15:04:12.245676641Z configuration-as-code-groovy:1.1
2021-12-16T15:04:12.251454900Z configuration-as-code:1.54
2021-12-16T15:04:12.257688172Z credentials-binding:1.27
2021-12-16T15:04:12.263691751Z credentials:2.6.1
2021-12-16T15:04:12.269548366Z display-url-api:2.3.5
2021-12-16T15:04:12.275409643Z docker-commons:1.17
2021-12-16T15:04:12.281231939Z durable-task:493.v195aefbb0ff2
2021-12-16T15:04:12.286930151Z echarts-api:5.0.2-1
2021-12-16T15:04:12.292742401Z favorite:2.3.1
2021-12-16T15:04:12.298415639Z font-awesome-api:5.15.2-2
2021-12-16T15:04:12.304246424Z git-client:3.10.0
2021-12-16T15:04:12.310049516Z github-api:1.114.2
2021-12-16T15:04:12.315794828Z github-branch-source:2.6.0
2021-12-16T15:04:12.321615191Z github:1.34.0
2021-12-16T15:04:12.327370776Z git:4.10.0
2021-12-16T15:04:12.333111417Z git-server:1.9
2021-12-16T15:04:12.338846310Z google-oauth-plugin:1.0.6
2021-12-16T15:04:12.344619104Z groovy:2.4
2021-12-16T15:04:12.350482067Z handy-uri-templates-2-api:2.1.6-1.0
2021-12-16T15:04:12.356191777Z htmlpublisher:1.25
2021-12-16T15:04:12.361941550Z jackson2-api:2.13.0-230.v59243c64b0a5
2021-12-16T15:04:12.368006035Z jenkins-design-language:1.24.8
2021-12-16T15:04:12.373839813Z jira:3.5
2021-12-16T15:04:12.379703863Z job-dsl:1.77
2021-12-16T15:04:12.385649623Z jquery3-api:3.6.0-1
2021-12-16T15:04:12.391451008Z jsch:<IP_ADDRESS>
2021-12-16T15:04:12.397259366Z junit:1.52
2021-12-16T15:04:12.403047499Z kubernetes-client-api:5.10.1-171.vaa0774fb8c20
2021-12-16T15:04:12.408879982Z kubernetes-credentials:0.9.0
2021-12-16T15:04:12.414636402Z kubernetes:1.31.0
2021-12-16T15:04:12.420337093Z lockable-resources:2.11
2021-12-16T15:04:12.426116035Z mailer:1.34
2021-12-16T15:04:12.431929376Z mapdb-api:<IP_ADDRESS>
2021-12-16T15:04:12.437676019Z matrix-auth:2.6.8
2021-12-16T15:04:12.443364392Z matrix-project:1.19
2021-12-16T15:04:12.449049896Z mercurial:2.15
2021-12-16T15:04:12.454705680Z metrics:<IP_ADDRESS>
2021-12-16T15:04:12.460312969Z oauth-credentials:0.4
2021-12-16T15:04:12.466125115Z okhttp-api:<IP_ADDRESS>
2021-12-16T15:04:12.472049230Z openshift-client:1.0.35
2021-12-16T15:04:12.477853619Z openshift-login:1.0.26
2021-12-16T15:04:12.483518999Z openshift-sync:1.0.51
2021-12-16T15:04:12.489177366Z pam-auth:1.6
2021-12-16T15:04:12.494796249Z pipeline-build-step:2.14
2021-12-16T15:04:12.500511381Z pipeline-graph-analysis:1.10
2021-12-16T15:04:12.506215161Z pipeline-input-step:2.12
2021-12-16T15:04:12.511811444Z pipeline-milestone-step:1.3.1
2021-12-16T15:04:12.517548887Z pipeline-model-api:1.9.3
2021-12-16T15:04:12.523270908Z pipeline-model-definition:1.8.4
2021-12-16T15:04:12.528917267Z pipeline-model-extensions:1.9.3
2021-12-16T15:04:12.534623856Z pipeline-rest-api:2.15
2021-12-16T15:04:12.540274897Z pipeline-stage-step:2.5
2021-12-16T15:04:12.546035377Z pipeline-stage-tags-metadata:1.8.4
2021-12-16T15:04:12.551770560Z plain-credentials:1.7
2021-12-16T15:04:12.557563862Z plugin-util-api:2.4.0
2021-12-16T15:04:12.563249626Z popper-api:1.16.1-2
2021-12-16T15:04:12.569050350Z prometheus:2.0.10
2021-12-16T15:04:12.574923250Z pubsub-light:1.13
2021-12-16T15:04:12.580686177Z scm-api:2.6.5
2021-12-16T15:04:12.586323756Z script-security:1.78
2021-12-16T15:04:12.592225990Z snakeyaml-api:1.29.1
2021-12-16T15:04:12.597894079Z sse-gateway:1.24
2021-12-16T15:04:12.603576636Z ssh-credentials:1.19
2021-12-16T15:04:12.609291099Z structs:1.23
2021-12-16T15:04:12.614965838Z subversion:2.15.1
2021-12-16T15:04:12.620664388Z token-macro:266.v44a80cf277fd
2021-12-16T15:04:12.626274128Z trilead-api:1.0.13
2021-12-16T15:04:12.631881441Z variant:1.4
2021-12-16T15:04:12.637509459Z workflow-api:2.47
2021-12-16T15:04:12.643150708Z workflow-basic-steps:2.20
2021-12-16T15:04:12.648898490Z workflow-cps-global-lib:2.17
2021-12-16T15:04:12.654614133Z workflow-cps:2.94
2021-12-16T15:04:12.660385146Z workflow-durable-task-step:2.35
2021-12-16T15:04:12.666170128Z workflow-job:2.41
2021-12-16T15:04:12.672028909Z workflow-multibranch:2.26
2021-12-16T15:04:12.677842823Z workflow-scm-step:2.13
2021-12-16T15:04:12.683524429Z workflow-step-api:2.24
2021-12-16T15:04:12.689236800Z workflow-support:3.8

/lgmt

there ^^ is the input into the ART request

awesome @gabemontero ; you made a typo in lgtm ; could you please re-lgtm it :-)
I will make the ART request based on what you copy pasted.

ART request made here:
https://issues.redhat.com/browse/ART-3603
@gabemontero we will need to cut a cherry pick for it until 4.8 at least as the bug impacts all the versions since then.
I don't remember if the bot accepts if the bz is not VERIFIED; let's ee.
/cherry-pick release-4.9
/cherry-pick release-4.8

/lgtm

we will need to cut a cherry pick for it until 4.8 at least as the bug impacts all the versions since then

@akram Is there still intention to backport this to 4.8 and 4.9? Currently they're still broken from the sync plugin issue.

we will need to cut a cherry pick for it until 4.8 at least as the bug impacts all the versions since then

@akram Is there still intention to backport this to 4.8 and 4.9? Currently they're still broken from the sync plugin issue.

yes @chriscarpenter12
https://bugzilla.redhat.com/show_bug.cgi?id=2037346 is tracking the backport to 4.9.z
https://bugzilla.redhat.com/show_bug.cgi?id=2037348 is tracking the backport to 4.8.z


DeepSeek demo

Describe the bug
When I run File search_graph_schema_deepseek.py using my own API Key, an error occurred.
To Reproduce
Steps to reproduce the behavior:

Replace my own key in File search_graph_schema_deepseek.py  and Run;
See error: Completions.create() got an unexpected keyword argument 'model_provider' which happend on search_graph_schema_deepseek.py", line 50, in <module>  result = search_graph.run()

Desktop (please complete the following information):

OS: Ubuntu20

I have reviewed issue#587 and made modifications as follows, but it still doesn't work：
from scrapegraphai.models.deepseek import DeepSeek
deepseek_instance = {
    "model": "deepseek/deepseek-chat",
    "base_url": "https://api.deepseek.com/v1",
    "api_key": deepseek_key,
}

llm_model_instance = DeepSeek(**deepseek_instance)

graph_config = {
    "llm": {
        "model_instance": llm_model_instance,
        "model_tokens": 4000
    },
    "verbose": True,
}

# ************************************************
# Create the SearchGraph instance and run it
# ************************************************

search_graph = SearchGraph(
    prompt="向我列举成都著名的小吃",
    config=graph_config,
    schema=Dishes
)

result = search_graph.run()
print(result)

I have reviewed issue#587 and made modifications as follows, but it still doesn't work：
from scrapegraphai.models.deepseek import DeepSeek
deepseek_instance = {
    "model": "deepseek/deepseek-chat",
    "base_url": "https://api.deepseek.com/v1",
    "api_key": deepseek_key,
}

llm_model_instance = DeepSeek(**deepseek_instance)

graph_config = {
    "llm": {
        "model_instance": llm_model_instance,
        "model_tokens": 4000
    },
    "verbose": True,
}

# ************************************************
# Create the SearchGraph instance and run it
# ************************************************

search_graph = SearchGraph(
    prompt="向我列举成都著名的小吃",
    config=graph_config,
    schema=Dishes
)

result = search_graph.run()
print(result)

In this case, I received the following error:
cannot pickle '_thread.RLock' object
search_graph_schema_deepseek.py", line 54, in <module>
    search_graph = SearchGraph(
TypeError: cannot pickle '_thread.RLock' object

are you using a collar notebook?

are you using a collar notebook?

No~ I use my laptop to connect to my Linux server via SSH

I have reviewed issue#587 and made modifications as follows, but it still doesn't work：
from scrapegraphai.models.deepseek import DeepSeek
deepseek_instance = {
    "model": "deepseek/deepseek-chat",
    "base_url": "https://api.deepseek.com/v1",
    "api_key": deepseek_key,
}

llm_model_instance = DeepSeek(**deepseek_instance)

graph_config = {
    "llm": {
        "model_instance": llm_model_instance,
        "model_tokens": 4000
    },
    "verbose": True,
}

# ************************************************
# Create the SearchGraph instance and run it
# ************************************************

search_graph = SearchGraph(
    prompt="向我列举成都著名的小吃",
    config=graph_config,
    schema=Dishes
)

result = search_graph.run()
print(result)

In this case, I received the following error:
cannot pickle '_thread.RLock' object
search_graph_schema_deepseek.py", line 54, in <module>
    search_graph = SearchGraph(
TypeError: cannot pickle '_thread.RLock' object

Continue making changes. With reference to
commit 546e59abe4f709378f0a30d475134edf0d7b09e5, I have made the following improvements to File scrapegraphai/graphs/search_graph.py (start with Line 47   maybe):
from ..models.deepseek import DeepSeek
def __init__(self, prompt: str, config: dict, schema: Optional[BaseModel] = None):
       self.max_results = config.get("max_results", 3)

       # if all(isinstance(value, str) for value in config.values()):
       #     self.copy_config = copy(config)
       # else:
       #     self.copy_config = deepcopy(config)

       # Custom deepcopy function to handle non-picklable objects
       def custom_deepcopy(obj, memo=None):
           if memo is None:
               memo = {}

           # 检查是否已经拷贝过该对象
           if id(obj) in memo:
               return memo[id(obj)]

           if isinstance(obj, dict):
               new_dict = {k: custom_deepcopy(v, memo) for k, v in obj.items()}
               memo[id(obj)] = new_dict
               return new_dict
           elif isinstance(obj, list):
               new_list = [custom_deepcopy(v, memo) for v in obj]
               memo[id(obj)] = new_list
               return new_list
           elif isinstance(obj, tuple):
               new_tuple = tuple(custom_deepcopy(v, memo) for v in obj)
               memo[id(obj)] = new_tuple
               return new_tuple
           elif isinstance(obj, DeepSeek):
               # 特殊处理 DeepSeek 对象
               new_obj = DeepSeek(
                   client=obj.client,
                   async_client=obj.async_client,
                   root_client=obj.root_client,
                   root_async_client=obj.root_async_client,
                   model_name=obj.model_name,
                   openai_api_key=obj.openai_api_key,
                   openai_api_base=obj.openai_api_base,
                   openai_proxy=obj.openai_proxy
               )
               memo[id(obj)] = new_obj
               return new_obj
           elif hasattr(obj, '__dict__'):
               new_obj = obj.__class__()
               memo[id(obj)] = new_obj
               for attr in obj.__dict__:
                   setattr(new_obj, attr, custom_deepcopy(getattr(obj, attr), memo))
               return new_obj
           else:
               return obj

       self.copy_config = custom_deepcopy(config)

The error: TypeError: cannot pickle '_thread.RLock' object disappear.  There is a problem with the structured format of the output. So I change the File scrapegraphai/nodes/generate_answer_node.py Line 100 and Line 105:
method="json_mode"

The problem with the structured format of the output disappear. But I encountered a new error: *** pydantic.v1.error_wrappers.ValidationError: 1 validation error for Generation text   str type expected (type=type_error.str).
I have located the potential issue to the _execute_standard function in the scrapegraphai/graphs/base_graph.py file, but it's too complex and I'm not good at handling it.

are you using search_graph_schema_deepseek.py?

Yeah, that's the file. I just replaced my api_key in it.

@VinciGit00  I found the reason. The reason is SearchGraph use deepcopy in config. and the config have model_instance. model_instance has the CookieJar object. the CookieJar object cannot use deepcopy to copy.

I also find there are other graph use it except it. But seem model_instance and deepcopy are not compatible.

we do it for the parallelism and deep copy of instances of graphs, @goasleep do you have any idea of how to fix it?

@gudufengzhongyipilang I might have a fix for the problem with the error Completions.create() got an unexpected keyword argument 'model_provider'. It might be related to our recent refactor of the AbstractGraph. I'll try to fix it later today.
@goasleep if you found a way to fix the TypeError: cannot pickle '_thread.RLock' object, you're officially our hero. We've been having an open issue about it (#374) for a very long time.

@f-aguzzi  I will try fix it later

@gudufengzhongyipilang I might have a fix for the problem with the error Completions.create() got an unexpected keyword argument 'model_provider'. It might be related to our recent refactor of the AbstractGraph. I'll try to fix it later today.
@goasleep if you found a way to fix the TypeError: cannot pickle '_thread.RLock' object, you're officially our hero. We've been having an open issue about it (#374) for a very long time.

Sure, thank you for your hard work and attention.

Hi please update to the new version

Requirement already satisfied: scrapegraphai in /usr/local/lib/python3.10/site-packages (1.16.0)
have a error
TypeError: Completions.create() got an unexpected keyword argument 'model_provider'

hi please update to the new demo

@gudufengzhongyipilang @xs818818 We might have fixed TypeError: Completions.create() got an unexpected keyword argument 'model_provider'. Check out the latest beta, it's in there. Let us know if it works or if the problem is still there.

Okay. I will verify it later.

hi please update to the new demo

Thank you~


Support server to server and copy and paste integration

Support this package for server to server and copy and paste

@vdbelt  is this PR welcome? Otherwise, I can also use our fork as copy and paste integration

I don't have the ability to test myself, but your PR is welcome and looks good to me. Thanks!


Store scaled minimum in a separate variable

Fixes a small bug where the minimum wasn't being a reset when the image changed by storing the global minimum (480x480) in a different variable than the scaled minimum (480 scaled down based on the image size) so it doesn't get overwritten.
@DoSomething/front-end

:ship:

:+1:


[load test] Use 7.x application when Java 7 is requested

What does this PR do?
Use a 7.x version of the test application when a 7.x version of Java is requested.

:grey_exclamation: Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: [Pull request #1525 opened]

Reason: Aborted from #2

Start Time: 2020-11-20T17:00:37.587+0000

Duration: 9 min 48 sec

Commit: 6639b0d3d359fa1a22a5d5ee848e50be044c7501

Log output
Expand to view the last 100 lines of log output

[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-redisson-plugin                                 [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-jms-plugin                                      [pom]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-jms-plugin-base                                 [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-jmx-plugin                                      [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-jsf-plugin                                      [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin                         [pom]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin-common                  [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin-5_x                     [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin-6_x                     [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-es-restclient-plugin                            [pom]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-common                     [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-5_6                        [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-6_4                        [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-grpc                                            [pom]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-grpc-plugin                                     [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-kafka-plugin                                    [pom]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-kafka-base-plugin                               [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-kafka-headers-plugin                            [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-mongoclient-plugin                              [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-okhttp-plugin                                   [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-opentracing-plugin                              [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-profiling-plugin                                [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-servlet-plugin                                  [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-log-correlation-plugin                          [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-micrometer-plugin                               [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-log-shipper-plugin                              [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-spring-resttemplate-plugin                      [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-spring-webmvc-plugin                            [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-urlconnection-plugin                            [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-scheduled-annotation-plugin                     [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-quartz-job-plugin                               [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-process-plugin                                  [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-dubbo-plugin                                    [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-scala-concurrent-plugin                         [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:elastic-apm-agent                                   [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-agent-benchmarks                                [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-7_1                        [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-jms-spring-plugin                               [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-jedis-2-tests                                   [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-jedis-3-tests                                   [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-lettuce-3-tests                                 [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-grpc-test-1.6.1                                 [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-opentracing                                     [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:integration-tests                                   [pom]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:simple-webapp                                       [war]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:jsf-app                                             [pom]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:jsf-app-dependent                                   [war]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:jsf-app-standalone                                  [war]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:cdi-app                                             [pom]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:cdi-app-dependent                                   [war]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:cdi-app-standalone                                  [war]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:soap-test                                           [war]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:apm-agent-attach                                    [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:application-server-integration-tests                [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:spring-boot-1-5                                     [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:spring-boot-2                                       [pom]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:spring-boot-2-base                                  [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:spring-boot-2-jetty                                 [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:spring-boot-2-tomcat                                [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:spring-boot-2-undertow                              [jar]
[2020-11-20T17:08:14.090Z] [INFO] co.elastic.apm:external-plugin-test                                [jar]
[2020-11-20T17:08:14.090Z] [INFO]
[2020-11-20T17:08:14.090Z] [INFO] ------------------< co.elastic.apm:apm-agent-parent >-------------------
[2020-11-20T17:08:14.090Z] [INFO] Building co.elastic.apm:apm-agent-parent 1.19.1-SNAPSHOT          [1/83]
[2020-11-20T17:08:14.090Z] [INFO] --------------------------------[ pom ]---------------------------------
[2020-11-20T17:08:40.704Z] [INFO]
[2020-11-20T17:08:40.704Z] [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ apm-agent-parent ---
[2020-11-20T17:08:44.924Z] [INFO]
[2020-11-20T17:08:44.924Z] [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-java) @ apm-agent-parent ---
[2020-11-20T17:08:54.946Z] [INFO]
[2020-11-20T17:08:54.946Z] [INFO] --- jacoco-maven-plugin:0.8.5:prepare-agent (default) @ apm-agent-parent ---
[2020-11-20T17:09:13.100Z] [INFO] argLine set to -javaagent:/var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1525/src/github.com/elastic/apm-agent-java/.m2/org/jacoco/org.jacoco.agent/0.8.5/org.jacoco.agent-0.8.5-runtime.jar=destfile=/var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1525/src/github.com/elastic/apm-agent-java/target/jacoco.exec
[2020-11-20T17:09:13.100Z] [INFO]
[2020-11-20T17:09:13.100Z] [INFO] --- license-maven-plugin:1.19:update-file-header (first) @ apm-agent-parent ---
[2020-11-20T17:09:19.500Z] Sending interrupt signal to process
[2020-11-20T17:09:21.287Z] script returned exit code 143
[2020-11-20T17:09:22.714Z] Stage "Tests" skipped due to earlier failure(s)
[2020-11-20T17:09:22.980Z] Stage "Unit Tests" skipped due to earlier failure(s)
[2020-11-20T17:09:23.001Z] Stage "Smoke Tests 01" skipped due to earlier failure(s)
[2020-11-20T17:09:23.021Z] Stage "Smoke Tests 02" skipped due to earlier failure(s)
[2020-11-20T17:09:23.040Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-11-20T17:09:23.060Z] Stage "Javadoc" skipped due to earlier failure(s)
[2020-11-20T17:09:23.286Z] Failed in branch Unit Tests
[2020-11-20T17:09:23.303Z] Failed in branch Smoke Tests 01
[2020-11-20T17:09:23.318Z] Failed in branch Smoke Tests 02
[2020-11-20T17:09:23.333Z] Failed in branch Benchmarks
[2020-11-20T17:09:23.350Z] Failed in branch Javadoc
[2020-11-20T17:09:23.741Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-11-20T17:09:23.868Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-11-20T17:09:23.926Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-11-20T17:09:24.371Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1525
[2020-11-20T17:09:24.656Z] [INFO] getVaultSecret: Getting secrets
[2020-11-20T17:09:24.892Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-11-20T17:09:26.030Z] + chmod 755 generate-build-data.sh
[2020-11-20T17:09:26.030Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1525/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1525/runs/1 ABORTED 528164
[2020-11-20T17:09:26.581Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1525/runs/1/steps/?limit=10000 -o steps-info.json
[2020-11-20T17:09:26.832Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1525/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-11-20T17:09:26.832Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2020-11-20T17:09:28.176Z] Retry 2/3 exited 22, retrying in 2 seconds...
[2020-11-20T17:09:30.038Z] Retry 3/3 exited 22, no more retries left.

Looks fine for the build part, the command line to start the application is not the same for Java7 variant as it's packaged as a .war file.
java -jar ./target/petclinic.war

@SylvainJuge Indeed I forgot to modify the command-line invocation. Could you take a look now and see if that command looks correct to you?


BUG: fix inconsistent filepath sorting on ubuntu

fixes https://github.com/qiime2/distributions/actions/runs/11374413273/job/31645766306?pr=366#step:9:234

prepare PR (linked above) passed with these changes, so i'm going to merge this.


Suggested API changes for frontend

[ ] User channels: API to list channels a user is part of. Needed for profile section channels tab
[ ] User packages: Similar to above. API to list packages a user is part of.
[ ] /api/channels/{channel_name}/packages/{package_name}: Need more info (Summary, description, URLs, platforms, current version) #299
[ ] API for package logs and files
[ ] /api/channels Need count of members and packages in the response

sounds doable ;-)
do you need to have the list of channels/packages in the /user/me response or as a separate endpoint?

API for package logs and files

I don't think that we keep logs for packages. What kind of logs do you think of?
For files, you can get the filenames of all archives in /api/channels/{channel_name}/packages/{package_name}/versions, but we don't keep the archive content in the database. If this is something, you would like to have, it would need specific implementation.

/api/channels Need count of members and packages in the response

:+1:

sounds doable ;-)
do you need to have the list of channels/packages in the /user/me response or as a separate endpoint?

API for package logs and files

I don't think that we keep logs for packages. What kind of logs do you think of?
For files, you can get the filenames of all archives in /api/channels/{channel_name}/packages/{package_name}/versions, but we don't keep the archive content in the database. If this is something, you would like to have, it would need specific implementation.

/api/channels Need count of members and packages in the response

:+1:

I think logs and files can wait, we will just not have those two tabs in the first release of the new frontend and will add that once we have the database ready.

I think logs and files can wait, we will just not have those two tabs in the first release of the new frontend and will add that once we have the database ready.

do you need to have the list of channels/packages in the /user/me response or as a separate endpoint?

I think either would do. I don't see a clear advantage of one over the other at the moment

do you need to have the list of channels/packages in the /user/me response or as a separate endpoint?

I think either would do. I don't see a clear advantage of one over the other at the moment

do you need to have the list of channels/packages in the /user/me response or as a separate endpoint?

I think either would do. I don't see a clear advantage of one over the other at the moment

one advantage of having everything on the same endpoint, is that we need to make one request instead of 3 to get user detail, package and channel list
on the other hand there is more data to transfer, so if the channels/packages are not used often, it is a waste of bandwith
also for list of packages, we might need to paginate them or just expose 10 most recent or similar
what do you think? @chaitanya-deep @wolfv

do you need to have the list of channels/packages in the /user/me response or as a separate endpoint?

I think either would do. I don't see a clear advantage of one over the other at the moment

one advantage of having everything on the same endpoint, is that we need to make one request instead of 3 to get user detail, package and channel list
on the other hand there is more data to transfer, so if the channels/packages are not used often, it is a waste of bandwith
also for list of packages, we might need to paginate them or just expose 10 most recent or similar
what do you think? @chaitanya-deep @wolfv

They are currently in three different pages but the design might change in the future. And so far there is no analytics on how often people visit each page.
Might be better to have three different endpoints. That way I can implement the frontend with pagination.

They are currently in three different pages but the design might change in the future. And so far there is no analytics on how often people visit each page.
Might be better to have three different endpoints. That way I can implement the frontend with pagination.


DC/OS is unable to fetch: https://secure.gravatar.com/avatar/6edd0acaf80f784fab3dd2c31d604e74.jpg?s%3D80&r=g&d=mm

We see this in the Cosmos logs:
Feb 02 19:13:10 ip-10-0-7-85.us-west-2.compute.internal cosmos.sh[5798]: 19:13:10.937 INFO [finagle/netty4-2] access - <IP_ADDRESS> - - [02/Feb/2018:19:13:10 +0000] "GET /package/resource?url=https://secure.gravatar.com/avatar/6edd0acaf80f784fab3dd2c31d604e74.jpg?s%3D80&r=g&d=mm HTTP/1.1" 403 367 15 "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0"

You can reproduce this by booting a 1.11 cluster and navigating to the Catalog page in the UI and looking at the request sent by the browser.
HTTP response:
{"type":"Forbidden","message":"Unable to complete request due to Forbidden response from service [ResourceProxyHandler$] while accessinghttps://secure.gravatar.com/avatar/6edd0acaf80f784fab3dd2c31d604e74.jpg?s=80","data":{"serviceName":"ResourceProxyHandler$","destination":"https://secure.gravatar.com/avatar/6edd0acaf80f784fab3dd2c31d604e74.jpg?s=80","status":403}}

@twk3 can you update this?


Fix typo in "Asset content" section of UPGRADING.md

When referring to how to escape HTML tags, the documentation forgot to call the content method.
When using html_safe, an exception will be raised because html_safe is not defined on Propshaft::Asset.
Using raw, on the other hand, will call to_s on the Propshaft::Asset instance, returning an expected tag

Thanks!


Error: No JSON object could be decoded

RethinkDB installed on a Debian, but I'm getting an error message when connecting by Python 2.7:
`

import rethinkdb as r
r.connect()
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python2.7/dist-packages/rethinkdb/net.py", line 661, in connect
return conn.reconnect(timeout=timeout)
File "/usr/local/lib/python2.7/dist-packages/rethinkdb/net.py", line 572, in reconnect
return self._instance.connect(timeout)
File "/usr/local/lib/python2.7/dist-packages/rethinkdb/net.py", line 427, in connect
self._socket = SocketWrapper(self, timeout)
File "/usr/local/lib/python2.7/dist-packages/rethinkdb/net.py", line 322, in init
(self.host, self.port, ex))
rethinkdb.errors.ReqlDriverError: Could not connect to localhost:28015. Error: No JSON object could be decoded`
The web interface can access and manipulate the data normally.

Hi, and sorry you're having an issue.You should consider asking about this in the RethinkDB IRC or Slack if you can, or re-opening this ticket in the RethinkDB source code repository -- this is the repository for the documentation.
links to IRC/Slack/etc: http://rethinkdb.com/community/
rethinkdb repo: https://github.com/rethinkdb/rethinkdb

sorry


Change coin supply to int64 and format nicely.

NOTE:  Coin supply is not updated by websocket yet, so this number never changes unless the page reloads
This PR removes " DCR" suffix from value passed from go to browser.  Now a JS function expecting just a number that operates on it will not fail.
Add amountAsFloatParts function to web and explorer template maps.  It takes an amount as int64 and returns a []string of: part left of decimal place, right with trailing zeros removed, and trailing zeros.
Add fancyFloatParts html template definition that takes the []string from amountAsFloatParts and creates a stylized floating point coin value.
Adjust title of root page.

@gozart1 OK.  I did some renaming and rebased.  Hopefully it is still correct.

hmm, github seems to have gotten confused.  I'll make a new PR if it doesn't see the new commit soon.


redux: Fire actions for 'realm' events with op update or update_dict

The bulk of this is just transferring information from the docs into our types:

first, updating InitialDataRealm, for what we get in the /register response
then, making types for realm op: update and realm op: update_dict events, based on InitialDataRealm

Next, we should do what Greg says here:

[…] I think what I'd want to do (and what really any sane client that has ambitions of handling more than one or two special cases would want to do, unless like the web client it's already been written) would be to convert them both into a common format, basically corresponding to an update_dict event, and have the code that handles the details of an event just handle that one form.

Thanks for the review! Revision pushed.

Looks good! Merging.


link updates

GitHub handles the link redirect (you can visit either URL now) so closing this out.


JAD: Blacklist lemonparty.fr

JAD requests the blacklist of the website lemonparty\.fr. See the Metasmoke search here and the Stack Exchange search here.

lemonparty.fr has been seen in 5 true positives, 0 false positives, and 0 NAAs.


docs: improve documentation

Description
Improve the documentation of the golang module in order to further explain the usage of this module in a terraform project unit test. The documentation added here includes:

README usage section, with code examples
In-line examples added for pkg.go.dev documentation
In-line verbose comments for struct fields and functions that are primarily used by a consumer, which will also document in pkg.go.dev for those items.

Types of changes in this PR
Documentation changes.
NOTE: may require a patch level version number so that in-line documentation gets pushed to pkg.go.dev properly.
No release required

[ ] Examples or tests (addition or updates of examples or tests)
[x] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other changes that don't affect Terraform code

Release required

[x] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[ ] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[ ] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
Documentation (README and in-line comments) only

Checklist for reviewers

[x] The PR references a GitHub issue.
[ ] If relevant, a test for the change is included or updated with this PR.
[x] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

@toddgiguere I think you need to rebase and resolve conflicts

:tada: This PR is included in version 1.5.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat: Causal Graph Rewriter

I've written the Rewriter struct. It should be serialisable, so the next thing I will do is write a simple "compiler" binary that goes from Mark's format to a rewriter ready to go.
The main piece missing here are the fn boundary methods for LHS and RHS. Can you fill those in?
Hopefully not too many merge conflicts arise from this.


⚠ Bofrost.at has degraded performance

In fa49d90, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1504 ms

Resolved: Bofrost.at performance has improved in 52aa3e9.


Support multiple levels of complex types

a datacontract like this does not reflect the items collection:
public class ClientListResponse : ResponseBase<ClientList>     {     }
public class ResponseBase<T>     {         [DataMember]         public T Body { get; set; }     }  public class ClientList     {         [DataMember]         public List<ClientSummary> Clients { get; set; }     }
The mapping helper adds the definition to the definitionsTypesList, but when these are built any complex type inside is not mapped.

can you retry with latest version? 1.0.7
Did some changes that might impact this

Hi,
A lot better. However, when using IEnumerable the T type is not refelcted. Works for List.

can you retry again? 1.0.8

let me know if you still have any issue


AWS metadata submitted to the Eureka server contains nulls for public-ipv4 and public-hostname when running the client with useLocalMetadata=true

In continuation of #51: The AWS metadata submitted to the Eureka server when registering will alsways contain all the fields defined in AwsMetadata. When running the service in the private, values for public-ipv4 and public-hostname will be null. This causes Eureka to choke when requesting the instance resource on /eureka/apps.
This could be considered a bug in the Eureka server, but the client should not submit the null values in the first place. The solution is to filter nulls out of the AWS metadata before merging it into the config.
I'll make a fix for this and submit a pull request.

Available in v2.5.2. Thanks @tbfangel!


Use Bytes instead of Any in Runner API FunctionSpec

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify.
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Coverage decreased (-0.007%) to 70.651% when pulling 92a35825c44346fd5077cc206ab554e51e45531a on tgroh:bytes_instead_of_any into fff82b003879fc4b914b88ddff0582b50b3513a5 on apache:master.

R: @robertwb @kennknowles
CC: @lukecwik

Can you merge and fix tests?

ping

The failure is based on stage code within
I can perform a worker dance in order to move forwards, or this can be submitted, imported, and fixed internally.

I'm in favor of worker dance after 2.1.0 goes out. Alternatively you could add a new field and populate it, port, then remove the old one. And you can rename later while keeping the field number, if you like. Still blocked on 2.1.0 either way.

+1 for worker dance.

I believe this will now pass tests, as the change will be performed in a sequence of individually backwards-compatible changes.
+R: @vikkyrk

Coverage decreased (-0.02%) to 70.159% when pulling 9efa1b1f6131f5699c1ef69de445321ab8a189e8 on tgroh:bytes_instead_of_any into f731de0b357bc5eccee565271ade96e1946bf0bd on apache:master.

You could skip the renumbering and save some time.

retest this please

LGTM once tests pass. Thanks

Changes Unknown when pulling 170a00165b0e64fe133ff4cfaccf3a61e2106a27 on tgroh:bytes_instead_of_any into ** on apache:master**.


Runners not cleaned up from the list of GitHub runners

When using the standard ec2 runner setup from the documentation it seems as if the GitHub runners aren't being cleaned up. The returned message is GitHub self-hosted runner with label <random id> is not found, so the removal is skipped but when I look at the list of runners, I see the runner with that label as offline. The AWS side seems to clean up  properly. In any case, thanks for this great tool!

eh, i discovered this was entirely me. sorry about that!

@jduncan-xoi Good that you found the root cause. Can you please share the reason behind that?

@jduncan-xoi Good that you found the root cause. Can you please share the reason behind that?

@machulav Sure, I had a bad token for the stop-runner section. I suppose one enhancement proposal could be to make the errors more verbose as when it has a bad token or null for the token, it just returns null and the message in the original post here.

It makes a lot of sense! Thanks for the notice!


Confusion regarding signs of in-context vectors

Congratulations on your excellent work! The idea is truly inspiring.
I have some questions about the calculation of ICV. In the original paper, Equation 1 uses $y - x$ (where $y$ is the target). However, in the notebook, it seems to be the opposite. Does this mean it is moving in the opposite direction? Or does it have something to do with svp_flip?
Thank you for clarifying this.

Hey,
Thanks for your attention to our work. Yes, in the Jupyter Notebook we use $x-y$, but when we generate the ICV, we also take the negative sign so it is actually $y-x$ as you mentioned. Sorry for the confusion.

Thank you for your prompt reply!
I'm still confused thought. What does the opposite sign represent? If I understand correctly, in get_icv, hidden_states[demonstration_id][0].flatten() represents $x$, and hidden_states[demonstration_id][1].flatten() represents $y$. Are we still subtracting $x - y$ here?

In the get_icv we compute $x-y$, and in the notebook, we subtract $x-y$, thus is we add $y-x$ which is consistent with the paper. Hope this explanation is clear.

In the get_icv we compute x−y, and in the notebook, we subtract x−y, thus is we add y−x which is consistent with the paper. Hope this explanation is clear.

Oh, I just realized that when applying icvs, it involves subtraction (icv_all_tasks -= alpha[i] * lambda_sim * F.normalize(self.icvs[i], dim=-1).repeat(1,x.shape[1],1)). That would explain everything. Thank you.
I have another question regarding normalization though. Before PCA, it seems like the differences are not normalized. Does it contradict with the paper (Sec 3.1)?

In the get_icv we compute x−y, and in the notebook, we subtract x−y, thus is we add y−x which is consistent with the paper. Hope this explanation is clear.

Oh, I just realized that when applying icvs, it involves subtraction (icv_all_tasks -= alpha[i] * lambda_sim * F.normalize(self.icvs[i], dim=-1).repeat(1,x.shape[1],1)). That would explain everything. Thank you.
I have another question regarding normalization though. Before PCA, it seems like the differences are not normalized. Does it contradict with the paper (Sec 3.1)?

Hello Authors, Can you please answer the last question mentioned above? Also can you clearly tell how the direction of the incontext vector has been considered in your demo_notebook.ipynb file? Thanks.


Create reasonable README.md

Readme.md calls this out as a "quick and dirty" editor. That's completely wrong at this point considering the ability to apply Unicode normalization to edited strings to get as close to "user perceived chars" with its gem.String as possible. We need to add a readme.md showing a quick start usage, talk about the ability to use gem.String, and a link to the current golang docs.

yeah we aren't gonna support language-aware unicode style collation. that is a massive pita and there are many libraries for that already. maybe in the future, but not for 1.0.0. include this in the readme as well

include the godoc badge


Show screen for container providers is causing an exception

clicking on a provider in the container providers page leads to an exception with the error: undefined method `name' for nil:NilClass [ems_container/show]

@miq-bot add_label providers/containers

@miq-bot add_label ui

@abonas

@zeari we'll need more information on this:

does it always happen? (I assume not...) - what solved it?
logs?
detailed exception?

@zeari we'll need more information on this:

does it always happen? (I assume not...) - what solved it?
logs?
detailed exception?

@abonas
It doesn't replicate on your end?

Yes, always.
Couldn't manage to get logs for UI issues. Where can I find them?
Thats all that appears on screen.

I can say that the exception originates from the corresponding textual_summary.rb

@abonas
It doesn't replicate on your end?
Yes, always.
Couldn't manage to get logs for UI issues. Where can I find them?
Thats all that appears on screen.
I can say that the exception originates from the corresponding textual_summary.rb

@zeari,  it works for me.
@h-kataria , any advice on logs - where more details can be retrieved? nothing on evm.log

@abonas @zeari look in production.log or development.log depending upon the mode you are running in

@abonas Closing this. The problem was caused by defining a provider via command line and not adding a zone.


SpeedTap Updates

Added pause menu and button to toggle between SpeedTap levels. Tested all buttons and working in current build.

Looks great!


Getting 'Module parse failed' error

Installed the screenfull package but getting the error:

This is a problem with your bundler, not this package.


Some changes mainly include colorful shadows and enhanced preview experience

I just make two small change to this library:

Bitmap.Config is ALPHA_8 before, this will make shadow color invalid, so I change it to ARGB_4444, and allow use opaque color draw shadow.
Cause shadow layer can not preview in xml, so I directly set the background shadow color in edit mode.

在recyclerview中，如果阴影布局过大，都会造成卡顿。


Nav collapses after clicking on tertiary item

The nav should close when hovering off the nav OR if they click on the pin/collapse icon at the top of the tertiary nav panel.

@miq-bot assign @skateman

@miq-bot add_label ui, bug

cc @serenamarie125 @jeff-phillips-18

@miq-bot add_label darga/yes

If you click on a menu item, the browser reloads the whole page, i.e. re-renders every pixel on the page. In the case of ManageIQ this can be fixed only by rewriting the whole UI into Angular. So I think this issue can be closed ....
cc @dclarizio @serenamarie125 @jeff-phillips-18


Add npm workspaces

Summary
Binging NPM 7 Workspaces into the monorepo
Details
Refs. https://github.com/cucumber/cucumber/issues/1259
TODO

[ ] Set up npm workspaces and tsconfig.build.json so we can npm i && npm run build all npm modules from root.
[ ] Remove common dev dependencies and configs from */javascript/package.json and only declare them once in the root package.json
[ ] Update .templates/javascript/default.mk
[ ] Remove .templates/javascript/.eslintrc.json and all copies
[ ] Remove .templates/javascript/.prettierrc and all copies
[ ] Figure out what to do with the generated messages/javascript/src/messages.js and messages/javascript/src/messages.d.ts files

Currently, npm i && npm run build will fail from a fresh clone. We don't want to have to do npm i && pushd messages/javascript && make && popd && npm run build

[ ] Allow contributors to run TypeScript code without needing to build the code (no need to run npm run build from the root)

[ ] Update all tsconfig.json files to just { "extends": "../../tsconfig.json" }
[ ] Set up compilerOptions.paths in root tsconfig.json file
[ ] Set up tsconfig-paths

[ ] Update .circleci/config.yml

Can we still build npm modules independently?
If yes, do they need to depend on a job that does the npm install && npm run build?
What's left to do in npm module CI jobs? Just npm test?

[ ] Update the monorepo build

Need to tun npm i in root. Running npm run build should be the last step. Run npm test to test all modules.

[ ] Update contributor docs
[ ] Update .templates/javascript/default.mk

[ ] Remove remove-local-dependencies

Figure out what to do with the generated messages/javascript/src/messages.js and messages/javascript/src/messages.d.ts files...Currently, npm i && npm run build will fail from a fresh clone. We don't want to have to do npm i && pushd messages/javascript && make && popd && npm run build

In the messages/javascript package.json:
{
  "scripts: {
    "prepare": "npm run pbjs && npm run pbts",
    ...
  }
}

That should run automatically after install in a local/workspace context. See https://docs.npmjs.com/cli/v7/using-npm/scripts#life-cycle-scripts.

Figure out what to do with the generated messages/javascript/src/messages.js and messages/javascript/src/messages.d.ts files...Currently, npm i && npm run build will fail from a fresh clone. We don't want to have to do npm i && pushd messages/javascript && make && popd && npm run build

In the messages/javascript package.json:
{
  "scripts": {
    "prepare": "npm run pbjs && npm run pbts",
    ...
  }
}

That should run automatically after install in a local/workspace context. See https://docs.npmjs.com/cli/v7/using-npm/scripts#life-cycle-scripts.

My understanding of npm workspaces is that you're only supposed to run npm install from the root directory. I wonder if this skips running of individual modules' npm lifecycle scripts.
Any idea?

Looks like the answer is "yes since we fixed it recently" https://github.com/npm/cli/issues/1965.
I'll push a commit and we find out?

Worked for me locally with a fresh clone! Also npm 7 is very fast.

The details provided by @aslakhellesoy here and @davidjgoss, here,  would be useful inclusions in the existing item:

[ ] Update contributor docs


update phase command to upload certs after expiration

Fixes #17453
@neolit123

/assign @jimangel

Maybe it will finally work this time ? :frowning_woman:

/lgtm

Maybe it will finally work this time ?

:crossed_fingers:

/approve


UESTRPG sheet redone

Changes / Comments
Redid the sheet from scratch after encountering a bunch of issues over the past versions. Tried to stick more closely to the original 5e OGL sheet this time, to make up for the fact that idk what I'm doing. Also used the opportunity to restore spell slot tracking for ease of use with NPC spellcasters alongside the magicka / spell point system for PCs.
Roll20 Requests
Include the name of the sheet(s) you made changes to in the title.
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

Is this a bug fix?
Does this add functional enhancements (new features or extending existing features) ?
Does this add or change functional aesthetics (such as layout or color scheme) ?
Are you intentionally changing more that one sheet? If so, which ones ?
If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Greetings @EnricoDandolo1
This pull request has merge conflicts in it and I will be unable to merge your sheet until you have resolved those. Due to the size of this sheet it will need to be done locally in your fork's repository on your workstation.
Thanks,
Cassie

I'm sorry, I've spent the last 40 minutes googling without finding an answer (ignoring my lecturer's thoughts on early dynastic Sumer) and I can't figure out how to do that. I've tried both Git Bash (which doesn't find the repository to begin with), Git GUI (which I can't figure out), but neither will seemingly give me the option to choose what changes to commit ... :'(

I'm sorry, I've spent the last 40 minutes googling without finding an answer (ignoring my lecturer's thoughts on early dynastic Sumer) and I can't figure out how to do that. I've tried both Git Bash (which doesn't find the repository to begin with), Git GUI (which I can't figure out), but neither will seemingly give me the option to choose what changes to commit ... :'(

Some pointers:

git add --patch <filename> to select which changes in a file should go into the commit.
git add <filename> to select files to go into a commit.
git clone to get the repository locally, probably needed for Git Bash

I confess I don't even understand what to do with those. I've got the repository forked and downloaded locally, and did the commit using GitHub Desktop. The idea is to completely replace the three existing files on live, is there no way to do that? Sorry for the noobiness, I feel like at this point I need some handholding :')

It looks like you fixed it on your own. One thing, though, you should consider trying the current version of the sheet and see whether it still works.

Sorry for the noobiness, I feel like at this point I need some handholding :')

No need to be sorry ;) What you want, could have been achieved by doing the following (not best practice :P):

Get copies of the final version of your files and save them somewhere outside the reach of Git.
You have already forked the Roll20 repository "roll20-character-sheets". Please note: Forking is a GitHub thing. Usually, that is called cloning.
Create a new branch on your fork (online). Use a descriptive name.
Edit the files, iirc you can do this online: Paste the contents of your saved final versions.
Make a commit with the changes.
Make a new pull request (use your new branch as source for the pull request).

Then, you could close this pull request here. For the next time.
My personal recommendation: Learn Git. It's an invaluable skill, even outside software engineering. I used the book Pro Git and when doing stuff just googling found everything I needed, most of it on Stack Exchange.

Thanks for the advice, will definitely bear that in mind for the future. The changes seem to work, at least until I encounter the next bug. Learning Git is definitely on my list, right behind gaining a modicum of understanding of music theory and continuing to study cuneiform languages lol Cheers!

The wiki have links some good resources that explains the basics well IMO.


Chore: LANDGRIF-683 update model to store contextual layers

General description
Create a new entity (ContextualLayers) to keep track of new magic h3 tables representing contextual layers
Related N to 1 to H3Data
Also added a new CHANGELOG file inside the /api folder. there is one at source level, should we keep the one outside, should we update the new one with the info the older one has?
Since the scope of this task is to just update the data-model to update the model so they can develop a script to populate it, I haven't add any test.
Also I considered that this entity won't have a standard CRUD, besides probably getting category names and layer names
But since the needs here are still not clear, I think will be better to add specific test for specific tasks instead of adding
'useless' CRUD tests that a consumer will never use
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Run the API and check:
1.a new table contextual_layers is created
2. Is related to H3Data
3. h3Data has a new column contextualLayerId

Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

[x] Branch name / PR includes the related Jira ticket Id.
[ ] Tests to check core implementation / bug fix added.
[x] All checks in Continuous Integration workflow pass.
[ ] Feature functionally tested by reviewer(s).
[ ] Code reviewed by reviewer(s).
[x] Documentation updated (README, CHANGELOG...) (if required)

Testing in local done - all good, just that thing we mentioned with h3dataCategory and h3data properties in the Entity


Bump client-swift-sdk version for BroadcastExt dependency

SampleHandler now depends on LKSampleHandler, added in LK 1.0.1.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Tiny panel on Hidpi

On Hidpi screen (4k) the clipmenu seems tiny, Although I used throw Rofi which run faultlessly with -dpi 192 parameter. Any suggestions?

Set your CM_LAUNCHER env to use rofi?

I put this: export CM_LAUNCHER=rofi in .bash_profile, isn't the right way?

Clipmenud is usually run by systemd user, hence the setting goes into /.config/systemd/user/clipmenud.service.d/override.conf
[Service]
Environment=CM_LAUNCHER=rofi

I deleted that line in .bash_profile, and created the following file:
~/.config/systemd/user/clipmenud.service.d/clipmenud.service.conf:
[Unit]
Description=Clipmenu daemon

[Service]
ExecStart=
ExecStart=/usr/bin/clipmenud
Restart=always
RestartSec=0
Environment=DISPLAY=:0
Environment=CM_LAUNCHER=rofi

MemoryDenyWriteExecute=yes
NoNewPrivileges=yes
ProtectControlGroups=yes
ProtectKernelTunables=yes
RestrictAddressFamilies=
RestrictRealtime=yes

[Install]
WantedBy=default.target

Restart my system, when I'm checking systemctl --user status clipmenud.service it's running but typing printenv CM_LAUNCHER didn't return anything.
Another trying, I execute clipmenu -i -fn Terminus:size=22 and finally it seems great on Hidpi, but I think it's still don't use Rofi, because its colors and positions different from Rofi's settings.
Thanks.

Then I restart my system, when I'm checking systemctl --user status clipmenud.service it's running but typing printenv CM_LAUNCHER didn't return anything.

That's not how environment variables work -- they're propagated by process hierarchy, printenv isn't going to help you here.

I found the proper way in Arch Linux wiki: "Environmental variables needed for applications should instead be added to /etc/environment", so I put there CM_LAUNCHER=rofi and finally clipmenu now uses rofi, and when I type printenv CM_LAUNCHER I got rofi.
Thanks.

I found the proper way in Arch Linux wiki: "Environmental variables needed for applications should instead be added to /etc/environment", so I put there CM_LAUNCHER=rofi and finally clipmenu now uses rofi, and when I type printenv CM_LAUNCHER I got rofi.

This isn't really the ideal way since now this pollutes every single application you use, but if it works for you, no big deal :-)


feat: embed types

What type of pull request is this?

[x] Non-breaking code change
[ ] Breaking code change
[ ] Documentation change/addition
[ ] Tests change

Description

I just figure this will be somewhat useful for someone
Changes

Embed type field
EmbedTypes enum

Checklist

[x] I've formatted my code with Black
[x] I've ensured my code works on Python 3.10.x
[x] I've tested my code

The test failed because the bot didn't have a proper token.

Are you sure you've tested this? I literally tried to send an embed and got a type error. You likely forgot to mark this field as no_export_meta
TypeError: Object of type EmbedTypes is not JSON serializable

I swear I did test it and it worked?

Fixed btw


ValueError: output name: save/control_dependency, was provided, but the Tensorflow graph does not contain a tensor with this name.

I am trying to convert one of the following pertained models:
https://github.com/mrharicot/monodepth
http://visual.cs.ucl.ac.uk/pubs/monoDepth/models/model_cityscapes.zip
Using the following code:
import tensorflow as tf
import tfcoreml as tf_converter
import operator
import sys

meta_path = 'model_cityscapes.meta'
output_node_names = ['save/control_dependency']

with tf.Session() as sess:

    # Restore the graph
    saver = tf.train.import_meta_graph(meta_path, clear_devices=True)

    graph = tf.get_default_graph()
    input_graph_def = graph.as_graph_def()
    sess = tf.Session()
    saver.restore(sess, "model_cityscapes")

    # Freeze the graph
    frozen_graph_def = tf.graph_util.convert_variables_to_constants(
        sess,
        sess.graph_def,
        output_node_names)

    # Save the frozen graph
    with open('output_graph.pb', 'wb') as f:
      f.write(frozen_graph_def.SerializeToString())

tf_converter.convert(tf_model_path = 'output_graph.pb',
                     mlmodel_path = 'output_graph.mlmodel',
                     output_feature_names = output_node_names)

I ran the summarize tool to get all the output node names. I am wondering why tf-coreml complains about the save/control_dependency since it must be included in the frozen graph. Is this a bug?

The graph is not frozen properly. Instead of calling tf.graph_util.convert_variables_to_constants, please use the from tensorflow.python.tools.freeze_graph import freeze_graph as used in the example Jupiter-notebooks in this repo.

Thanks a lot! However that gives me the exact same error:
import tensorflow as tf
import tfcoreml as tf_converter
import operator
import sys

from tensorflow.python.tools.freeze_graph import freeze_graph

meta_path = 'model_cityscapes.meta'
output_node_names = ['save/control_dependency']

with tf.Session() as sess:

    # Restore the graph
    saver = tf.train.import_meta_graph(meta_path, clear_devices=True)

    graph = tf.get_default_graph()
    input_graph_def = graph.as_graph_def()
    sess = tf.Session()
    saver.restore(sess, "model_cityscapes")

    init_op = tf.global_variables_initializer()
    sess.run(init_op)

    tf.train.write_graph(sess.graph_def, '.', 'output.pbtxt')
    saver.save(sess, "./output.ckpt")

    graph_def_file = './output.pbtxt'
    checkpoint_file = './output.ckpt'
    frozen_model_file = './frozen_model.pb'
    output_node_name = 'save/control_dependency'

    freeze_graph(input_graph=graph_def_file,
                input_saver="",
                input_binary=False,
                input_checkpoint=checkpoint_file,
                output_node_names=output_node_name,
                restore_op_name="save/restore_all",
                filename_tensor_name="save/Const:0",
                output_graph=frozen_model_file,
                clear_devices=True,
                initializer_nodes="")

tf_converter.convert(tf_model_path = frozen_model_file,
                     mlmodel_path = 'output_graph.mlmodel',
                     output_feature_names = output_node_names)

Before calling the convert function, please make sure that the frozen graph is correct.
You can use Netron to visualize the graph.
I think what is incorrect in the script above, that is causing a wrong frozen def is the name of the output
output_node_name = 'save/control_dependency'
It can be tricky to find the correct output of a TF graph. I looked at the .pbtxt file and picked the last Conv2D op, "model/decoder/Conv_17/convolution". Using that, the exported graph,  seems to be slightly better but it still doesn't have a 'placeholder' op for the input which it should have. However, that could be added "strip_unused_lib" function call (as used here).
To find the correct input and output op names, either you should look at the training source code that generated the graph in the first place. Or the summarize graph tool as described here might also be useful.

The source is not really providing the output names. I also used the exact same summarize tool as you mentioned in the comment.
I might tweak around for a while but I will just think that this model is not suitable for CoreML yet.
Thanks for your help anyway!

Another thing to note is that unlike freeze_graph, the output_feature_names argument of the function tf_converter accepts a list of tensor names (not the operation names). output_node_names = ['save/control_dependency'] is a list of operation names. What should rather be provided to the converter is a list of tensor names output_feature_names = ['save/control_dependency:0']

Thanks :)


feat(schema): Add Web Annotations

This replaces #38
In the previous attempt at annotations, we found that it was very difficult to develop a schema that could allow us to define types, add semantic annotations, and then automatically render to json-ld.
As a result, we came up with this new solution, which defines a graphql-specific schema, and then we'll create a specific json-ld serialiser which can convert this schema into json-ld output.
With @musicog, we believe that this schema fits all required annotation types within Trompa. I'm in the process of documenting the schema, and we'll add this to official documentation soon.
Some items are still pending and need further discussion. I'll mark these in review.

This is ready for review.
I've managed to create each type of annotation that we need to store. The client demos at https://github.com/trompamusic/trompace-client/tree/master/demo/annotation do each of these types of annotations

A describing or commenting annotation with a text body
An annotation of a freeform tag ('tagging' motivation)
A tag annotation from a fixed list of options (DefinedTermSet)
An annotation with a custom palette of motivations (DefinedTermSet with skos:broader relation on DefinedTerms)
A ranking annotation ('assessing' motivation)
An annotation that targets the URL at a given field of an existing node (e.g. the contentUrl field of an AudioObject node)
An annotation that targets a node in the CE (e.g. annotating an existing annotation)
An annotation that targets an external URL
An annotation whose body is text
An annotation whose body is an existing node in the CE (e.g. a DefinedTerm or a Rating)
An annotation whose body is an external URL

Annotations are also ThingInterfaces, and so can be used in an ItemList, to create the concept of an "Annotation session"

Nice work!


[WIP] Firebase error handling and native logs

As a result of https://gitlab.com/c-hive/payment-gateway/merge_requests/16#note_207430633.
Extracted:
When we use a generic error ahdnling in FB it registers the handler as succeeded (besides also logging the error of course). E.g.
something().catch(err => { console.error(err); });

Comment by @gomorizsolt moved here:

Please add this to the firebase best practices.

Please consider the following samples before we agree upon this error handling stuff.
When the Promise is rejected because of Promise.reject(...).
static createCustomer() {
  return new Promise((resolve, reject) => {
    return reject({
      error: "CREATE_CUSTOMER_ERROR",
    });
  });
}

// 1. When the error is NOT caught.
function handler(user) {
  return Model.create(user)
    .then(() => Service.createCustomer(user));
}

// Firebase logs rejections by default.
// As it is not wrapped into an error class(i.e. `return reject(...)`), it does not include the stack trace. That is why the output is not [object Object].
// => { error: 'CREATE_CUSTOMER_ERROR' }

// 2. When the error is caught and also re-thrown.
function handler(user) {
  return Model.create(user)
    .then() => Service.createCustomer(user))
    .catch(err => {
      // It does not matter if the error is serialized or not, the log remains the same in both cases => because of `Promise.reject(...)`.
      console.error(err);
      // OR
      console.error(JSON.stringify(err));
      // => { error: 'CREATE_CUSTOMER_ERROR' }

      // Re-throw the error to reflect the Promise's state to Firebase.
      // This adds an additional log entry to Firebase's console without serializing the object out of the box.
      throw new Error(err);
      // => Error: [object Object] at Promise (/srv/app/services/chargebee-service.js:27:13) at new Promise ...

      // Thereby, the `err` must be serialized by calling JSON.stringfy().
      // Also adds an additional log entry to Firebase's console but with a readable error object.
      throw new Error(JSON.stringify(err));
      // => Error: {"error":"CREATE_CUSTOMER_ERROR"} at userModel.create.then.catch.err (/srv/app/firebase-handlers/signup/signup.js:13:13) at <anonymous>
    });
}

When the Promise is rejected because of throw new Error(...).
static createCustomer() {
  return new Promise((resolve, reject) => {
    throw new Error({
      error: "CREATE_CUSTOMER_ERROR",
    });
  });
}

// 1. When the error is NOT caught.
function handler(user) {
  return Model.create(user)
    .then(() => Service.createCustomer(user));
}

// Firebase logs the error to the console along with its stack trace, but does not serialize the object(i.e. the error).
// => Error: [object Object] at Promise (/srv/app/services/chargebee-service.js:27:13) at new Promise ...

// 2. When the error is caught.
function handler(user) {
  return Model.create(user)
    .then(() => Service.createCustomer(user))
    .catch(err => {
      // => Serializing is required as it contains the stack trace along with the error itself.
      console.error(JSON.stringify(err));

      // Re-throw the error to reflect the Promise's state to Firebase.
      throw new Error(JSON.stringify(err));
      // Results in the same behavior.
    });
}

Instead of throw new Error(err); why not throw err;? IMO we should not fiddle with the error object unless needed.
As per what is being logged: I would not rely on FB's logging because as you pointed out it's not always consistent and requires manual intervention. I'd follow our existing error handling practices for logging the error (i.e. JSON.stringify). My only concern here is that I want the handler to register as failed in FB. This requires us to let the promise fail which we should do. FB will create another (perhaps unneeded) log entry about the error but that's just a side effect, we should not care about it imo as we have our own meaningful logs.

Instead of throw new Error(err); why not throw err;?

Thanks for the idea, I have completely forgotten this approach. It is suffice to throw the error without wrapping into a class.


Add "auto" option to ipv4-subnet and ipv6-subnet

If we do not care about the assigned IPv4/IPv6 subnet for the container network, we let the container runtime allocate one for us. This guarantees to avoid a collision of the hardcoded range (<IP_ADDRESS>/24 and 2001:172:20:20::/64) with any existing container networks. For example this makes it possible to run concurrent isolated topologies without directly modifying the topology files.
This just works for the podman runtime. For the docker runtime we compute the IPv6 subnet manually because it can only pick addresses from the configured (global) subnet.

thanks @mzagozen
I have rebased this PR since in the meantime we switched to go1.21.
I also added the docs/schema and slightly opimized the v6 ULA code.
Let me know if that seems OK to you and we can merge

Agree on the docs and refactoring. I pushed another rebased branch to fix the diff in the GitHub UI.


Correctly test sqs.Queue parameters in sqs.py

validate_parameters() has a fixed list of valid sqs.Queue parameters which is not in sync with troposphere.
Notably, it lacks QueueName, which makes it fail when using FifoQueue=True -- since FifoQueue requires a name set. QueueName should have been added in https://github.com/remind101/stacker_blueprints/pull/118 -- this merge solves that and also tries to prevent this type of error in the future by using the keys from sqs.Queue.props for checking instead of listing parameters.
Also add a test for sqs.py.

Superseded by https://github.com/remind101/stacker_blueprints/pull/132.


Image in README is broken

Describe the error
The image in the README is a broken link.
How to replicate the bug
Step by step to reproduce the error:

Click on the link "VS Code Example".

Screen shots

Browser window shows:
AccessDeniedAccess DeniedZW994GXC0FM1PXTT7lO9Xuy3NQ/kgmjk1A/P33VUibGZEK82Et0yA9RFVTNNnCOeCSycCKJvqdZNtfCLDd0AUEsTNe7R/T0RFDd+ww==
This XML file does not appear to have any style information associated with it. The document tree is shown below.
<Error>
AccessDenied
<Message>Access Denied</Message>
<RequestId>ZW994GXC0FM1PXTT</RequestId>
<HostId>7lO9Xuy3NQ/kgmjk1A/P33VUibGZEK82Et0yA9RFVTNNnCOeCSycCKJvqdZNtfCLDd0AUEsTNe7R/T0RFDd+ww==</HostId>
...
</Error>

Runtime environment

OS: iOS M1
Browser: chrome
Version: 118.0.5993.117 (Official Build) (arm64)

@saltorre thanks for finding the problem, this is now resolved.


add "why simpleserver" to faq

for ppl that don't get why simpleserver is worth using vs bukkit plugins, etc.

I could answer this quite simply:
"Simple server is, as its name implies, simple to use. Easy to setup and maintain with a low barrier to entry. You don't have to take an afternoon off to learn how to use this system. Simple server is a one stop shop for chat functions, area protection, commands, and group functions that rival those you might find in bukkit (but with none of the hassle). Its functionality grows with each version. Even better, simple server is the perfect server manager for admins who use mods that are not ported to bukkit."

they don't rival those in bukkit.....but that is pretty good...
On Nov 24, 2011, at 12:51 AM, mensreaMC wrote:

I could answer this quite simply:
"Simple server is, as its name implies, simple to use. Easy to setup and maintain with a low barrier to entry. You don't have to take an afternoon off to learn how to use this system. Simple server is a one stop shop for chat functions, area protection, commands, and group functions that rival those you might find in bukkit (but with none of the hassle). Its functionality grows with each version. Even better, simple server is the perfect server manager for admins who use mods that are not ported to bukkit."

Reply to this email directly or view it on GitHub:
https://github.com/SimpleServer/SimpleServer/issues/188#issuecomment-2850345

Thanks for this. Added it to the faq.


Extends "Hide Minimap With Chat" support to Resizable - Classic layout

This PR allows the "Hide Minimap With Chat" functionality to be usable with the Resizable - Classic layout.
I appreciate that this plugin is only intended to be used with the Resizable - Modern layout (I mean its even in the project's name! lol), so feel free to reject this PR on the basis of it being outside the scope of the features you intend to support - I'm happy to just create a fork instead 👍

@Ruckwad Any thoughts? Would be nice to push this to the plug-in hub so the functionality could be used without having to use a shadow jar.
Again, if this is outside the scope of the plugin I'm happy to fork instead, just let me know :)

@Ruckwad Any thoughts? Would be nice to push this to the plug-in hub so the functionality could be used without having to use a shadow jar.
Again, if this is outside the scope of the plugin I'm happy to fork instead, just let me know :)

hey, sorry i rarely check this but i appreciate the update and dont mind if you or others want to fork or recreate a better version... this was just my version of an idea i had

@Ruckwad Any thoughts? Would be nice to push this to the plug-in hub so the functionality could be used without having to use a shadow jar.
Again, if this is outside the scope of the plugin I'm happy to fork instead, just let me know :)

hey, sorry i rarely check this but i appreciate the update and dont mind if you or others want to fork or recreate a better version... this was just my version of an idea i had and being kinda nooby, it definitely could use adjustments lol
let me setup my new computer and check code before pull request because last i remember there was a brief period where alot of the ids were changed which caused issues

Hi, cheers for accepting the PR and no worries about the delay.
Just a gentle reminder that you'll need to submit a PR to the plugin-hub to push this update live. This is just a simple matter of updating the commit in the plugins/collapsible-modern-chat file. I could submit the PR if you wanted but I'm unsure whether only the plugin's author is allowed to do this. Thanks!


Data for Section 4.2.3

Hello, I notice that the code for CVAEs in this repository is for Section 4.2.3 while the data processing code is for Section 4.2.2. Would you mind release your dataset for Section 4.2.3?

Hi @apolaris Beichen, I have added the preprocessing code for the experiment in Section 4.2.3 and wrote a brief instruction for using it in the README file. Please let me know if you have further questions. Thanks.
Notice that since we are doing random train/test splits on this experiment, the resulting metrics can be slightly different for various splits, but they should not be varying too much.

Thank U！


Small questions

1- What version of Decrypt9 should be used? Can Plailect post a link to the latest release?
2.- The CTRNAND fix should be used if i'm going to use a redNAND backup instead of the sysNAND backup? My sysNAND was downgraded with Gateway, but not the redNAND. Should i follow the steps?

You need to click on the link of what you accomplished when upgrading/downgrading your SysNAND version. The Decrypt9 link will be given to you once you click on the links in the chart/table.

I don't know about this.

Decrypt9WIP by D0k3, 2016/08/23 (verify in the main menu of Decrypt9WIP). https://github.com/d0k3/Decrypt9WIP/releases/latest

And also, that /file9/ folder on Step 2, should be created by the user? Or is a special folder that has some archives aside from this guide?

2. Only do it if you can't boot.
All links have been updated to use the /releases/latest url.


Live

Test PR

Docs Build status updates of commit f1e6f90:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Test PR


Profile add-to-team no longer unselects checkboxes

Before this patch clicking "Add to 2 teams" to add a user to teams from their profile deselected all the checkboxes for the duration of the spinner. With this patch the boxes stay selected. It doesn't seem to exhibit the opposite bug of keeping teams selected across sessions.

cjb points out this was in to fix a bug where one team errors out the checkboxes didn't clear


Add hints on NPCs for some checks

Adds NPC hints for

Faron SotH
Kina
Owlan
Levias

Also fixes song hint mapping bug & puts song/npc hints on the spoiler log.

Not sure how to deal with the conflicts here so I've left this PR out of the beta-features branch until they get resolved

Is this feature still desired? If so, it could do with updating so it can get tested and merged

I believe we decided that we wanted the feature, but that there were implementation problems, along with some debate about the specifics of the feature. From what I recall, there were two major things that were blocking this:

How exactly we wanted triforce hints to work, should it be one static piece chosen randomly at generation, or should you be able to dynamically receive some number of the hints based on what you have collected? This also begs the further question of how it would interact with TFH, but that’s a bridge that we can cross when TFH becomes a reality
Turning it into a conditional multi so that it functions similarly to the equivalent functionality in OoTR, and so that we can maintain current functionality without making the Impa hint a special case/separate option.

In the interim, I’ve actually come up with a few other notes on this that I never got around to writing up anywhere and eventually forgot about this.

We could likely rename this to “Miscellaneous Hints.” Even though this currently only impacts NPCs, I could see merit in adding some variations of this style of hint on actors that aren’t NPCs (such as signs).
These hints should probably not remove the hint status of locations that it hints, and instead rely on deduplication to prevent potential bugs when it is disabled
Using the conditional multi implementation should eventually allow us to give better and more specific help text for each option, which would mean the help text for the option as a whole doesn’t have to worry about specific cases (such as the fact that levias is the only one that becomes an always hint)
This doesn’t necessarily need to be part of this particular PR, but Batreaux rewards and Beedle’s shop items would also make great candidates for this style of hint (on an NPC or otherwise)


[CV] Need for new value-types in json

Until now, in the CV we have the xref for each term, like "xref: value-type:xsd:int "The allowed value-type for this CV term."
These value types are still XML specific.
Do we need to specify them in json, and if, what values types do we have there?

JSON has a few different types:

string
Numeric types
object
array
boolean
null

I've tried to specify the types of the JSON elements in the schema as appropriately as possible. For the parameter values this hasn't been done though because they can have any type of value depending on the CV term.
So specifying the type in the CV makes sense as far as I'm concerned. Then we can still validate the types ourselves outside of the JSON schema.

I think, this can be closed.
The OBO states the type in more or less the same way as it is required in JSON. We just need to be sure not to set types in the CV, which do not exist in JSON.


Autocomplete Issue - Doesn't remove initially typed characters. (Community Edition - 21.3.2)

Hi,
I'm facing the issue with autocomplete, where the characters that we type initially to get suggestions from auto-complete, don't get replaced by the selected suggestion from drop-down, but get appended at the end. I'm using the latest version (21.3.2) of community edition.
I have the option "Replace current word" selected as well, but this doesn't resolve the issue.

Further I found that, if we have the option "Activate Hippie Engine for autocompletion" selected, then only we face this problem, otherwise don't.

@sandeshk89 , could you please check if the issue is still reproducible for you against 22.0.1?


add lttd-consulting

LTTD Consulting is a Training company
Here is the document certifying the training center
12920826  - LTTD CONSULTING -  Qualiopi - v1.pdf

@ValentinBonneau First stage of verification passed, official domain is lttd-consulting.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@ValentinBonneau Regrettably, I have to close the request without merging, because this organization is a training center, not a college, nor a university. Please ensure that you are familiar with this repository rules located at the bottom of this page.
Please apply for an appropriate licensing option (which may also be free) at https://www.jetbrains.com/community/education/#courses.
Thank you for your understanding!


stagehand 3.0.0 defaults to snapshot 1.1 not 2

URL: https://pub.dartlang.org/packages/stagehand#-versions-tab-
When dart2 dev sdk is installed, executing stagehand web-angular should use snapshot dart2.
Hello there. I have installed dart 2 64.1-1 and wanted to try angular 5. After doing a:
"pub global activate stagehand" and "pub global activate webdev", i have errors on stagehand and webdev. I saw that errors appear because the script uses snapshots 1.1 from either two.
The error on stagehand web-angular command is: "..../.pub-cache/global_packages/stagehand/bin/stagehand.dart.snapshot:1:1: Error: Unable to decode bytes as UTF-8.
���ܶj "
The error in webdev is a bit more complicated for me to understand and way longer.
If I do manualy dart and pick the snapshots from bin that are ended with dart2 it works as expected.
I installed as indicated on the website in preview angular 5, dart2 sdk (dev).
OS: WattOS (it's a stripdown  version of Ubuntu 16.04.4 LTS -Xenial).
I want to appologise in advance. I am new to programming, github and reporting issues.(but i love what you are doing with dart and angular and flutter)
Great day, devs.

This issue was moved to dart-lang/stagehand#544


Added missing

fixes indexiatech/ember-idx-tree#5
added missing <i> causing an ember-cli error

+1
Please merge that

Could you merge it please? thanks


Fixed Filters, products pagination and sort Fix/608

Fixed Filters, products pagination and sort
Screenshots

Original
Updated

 |

 |

Checklist

[x] 🔽 My branch is up-to-date with "development" branch
[x] ✅All tests passed locally
[x] ✨My changes working with up-to-date admin and back-end part locally, like charm
[x] 🔗 Link pull request to issue

please highlight the selected button


[cxx-interop] Allow removing elements from std::set.

Allow removing elements from std::set/std::unordered_set in Swift.
Resolves https://github.com/swiftlang/swift/issues/72799

@swift-ci please test

@egorzhdan  It seems that the compilation failed on Linux. Is there an easy way to cross-compile to Linux from macOS? Thank you!

@swift-ci please smoke test

@egorzhdan  Thank you for your review. I have addressed all the comments, and everything has passed the unit tests on my local environment.

@swift-ci please test

@swift-ci please build toolchain Amazon Linux 2


fix: fix hgctl in high kubenetes version problem by auto detecting k8s version and adding helm lookup function

…s version and adding helm lookup function

Ⅰ. Describe what this PR did
fix hgctl in high kubenetes version problem by auto detecting k8s version and adding helm lookup function
Ⅱ. Does this pull request fix one issue?

fix #627
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #629 (a3fcd02) into main (26654ae) will decrease coverage by 0.14%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
- Coverage   35.42%   35.29%   -0.14%
==========================================
  Files          71       71
  Lines       10240    10241       +1
==========================================
- Hits         3628     3615      -13
- Misses       6327     6340      +13
- Partials      285      286       +1

Files
Coverage Δ

pkg/cmd/hgctl/uninstall.go
0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


gradient accumulation preview / wip

I can't seem to get this working tonight, something is off.
The Python part works. i.e. we have the following. Running the default python script reproduces the old behavior before this PR:
python train_gpt2.py --write_tensors=0

This uses T=64, B=4, so per fwdbwd we process 4 * 64 = 256 tokens. So now asking for a total batch size of 512 will calculate the need to do 2 gradient accumulation steps, so we get 256 * 2 = 512 (as desired). So doing:
python train_gpt2.py --write_tensors=0 --total_batch_size=512

Will now do an inner loop of 2. First iteration is only fwd/bwd, and second iteration does fwd/bwd/update. The losses that get printed are (correctly!) identical to the ones above, because our data batch is fixed and identical, so we are simply doing two fwd/bwd on the exact same data, and the same gradient, ending up with the exact same losses, all as expected.
Now, to reproduce Python "vanilla" setup, we can do in llmc:
make train_gpt2cu PRECISION=FP32 && ./train_gpt2cu -b 4 -t 64 -l 1e-4 -v 200 -s 200 -a 1 -x 10 -f 0

This (correctly) reproduces the old behavior and outputs the exact same losses. But now we want to desire batch size 512 by appending the new flag -z 512:
make train_gpt2cu PRECISION=FP32 && ./train_gpt2cu -b 4 -t 64 -l 1e-4 -v 200 -s 200 -a 1 -x 10 -f 0 -z 512

This will correctly calculate that it needs 2 grad accum steps, but the losses come out all wrong. And I'm not sure why. I tried to mirror the approach in both files very closely, including the variable names, etc.
Thinking through:
Issue 1: I noticed that some of the kernels don't correctly += for the parameters. I fixed the few that I found but I'm not sure that I got all of them, and I don't feel confident that my changes are ok, so to speak.
Issue 2: I did not yet test the multi-gpu setup. I don't have confidence that the current implementation handles that correctly.
To be continued...

This isn't the problem you're debugging as it won't even affect the FP32 path (couldn't find anything wrong sadly!), but I noticed we're doing this everywhere:
            dbias[i] += (floatX)scratch_dbias[i];
            dweight[i] += (floatX)scratch_dweight[i];

That will result in:

Convert scratch_dbias from FP32 to BF16/FP16
Do the addition of two BF16/FP16 values with a BF16/FP16 output
Write BF16/FP16 output to dbias

But what we actually want to do is:

Convert dbias to FP32
Do the addition of two FP32 values with a FP32 output
Round FP32 to BF16/FP16 (either round-to-nearest-even or ideally stochastic rounding)
Write BF16/FP16 output to dbias

Unfortunately, just removing the (floatX) and making it implicit doesn't help, so we actually need to explicitly cast dbias to FP32:
            dbias[i] = (float)dbias[i] + scratch_dbias[i];
            dweight[i] = (float)dweight[i] + scratch_dweight[i];

Or even more explicit:
            dbias[i] = (floatX)((float)dbias[i] + scratch_dbias[i]);
            dweight[i] = (floatX)((float)dweight[i] + scratch_dweight[i]);

This also goes back to what I was saying yesterday about how it would be possible to change Packed128 to always read/write floats rather than the native type with some "very C++" idioms that I don't love but which would protect us against this kind of thing, and interestingly potentially allow us to "hide" stochastic rounding inside Packed128 (although that has its own set of trade-offs).
Anyway for now just doing the latter would be good as a baseline before this gets merged.

Merged alternative PR to this one, closing.


Log Compare in Co-Simulation Flow - spike_log_to_trace_csv.py does not produce any output

I set up the ibex example and I'm using the latest master of riscv-dv, and noticed that the comparison at the end doesn't work because the script "spike_log_to_trace_csv.py" does not produce any output in it's resulting csv file. Any clues on what might be going wrong?

Can you post the command you are using and the screen log?

Running core_ibex_base_test with <ibex_git_repo>/dv/uvm/out/instr_gen/asm_tests/riscv_arithmetic_basic_test.0.bin
Processing simulator setup file : yaml/rtl_simulation.yaml
Found matching simulator: vcs
Comparing spike/DUT sim result : <ibex_git_repo>/dv/uvm/out/asm_tests/riscv_arithmetic_basic_test.0.o
Processing ibex log : <ibex_git_repo>/dv/uvm/out/rtl_sim/riscv_arithmetic_basic_test.0/trace_core_00_0.log
Processed instruction count : 7508
0 PASSED, 1 FAILED
RTL & ISS regression report is saved to <ibex_git_repo>/dv/uvm/out/regr.log
Contents of <ibex_git_repo>/dv/uvm/out/regr.log:
Test binary: <ibex_git_repo>/dv/uvm/out/asm_tests/riscv_arithmetic_basic_test.0.o
ibex : <ibex_git_repo>/dv/uvm/out/rtl_sim/riscv_arithmetic_basic_test.0/trace_core_00_0.csv
spike : <ibex_git_repo>/dv/uvm/out/instr_gen/spike_sim/riscv_arithmetic_basic_test.0.csv
Mismatch[1]:
[2] ibex : lui              x2, 0xde6af000        -> sp(0xde6af000) addr:0x8000009a
7507 instructions left in trace ibex
Compare result[FAILED]: 0 matched, 1 mismatch
0 PASSED, 1 FAILED
Contents of <ibex_git_repo>/dv/uvm/out/rtl_sim/riscv_arithmetic_basic_test.0/trace_core_00_0.csv
instr,rd,rd_val,rs1,rs1_val,rs2,rs2_val,imm,str,addr,binary,mode
,ra,00000000,,,,,,"addi             x1, x0, 0            ",80000098,00000093,
,sp,de6af000,,,,,,"lui              x2, 0xde6af000       ",8000009a,de6af137,
,sp,de6af432,,,,,,"addi             x2, x2, 1074         ",8000009e,43210113,
,gp,b2b85000,,,,,,"lui              x3, 0xb2b85000       ",800000a2,b2b851b7,
,gp,b2b849f8,,,,,,"addi             x3, x3, -1544        ",800000a6,9f818193,
,tp,00000000,,,,,,"addi             x4, x0, 0            ",800000aa,00000213,
,t0,92ed0000,,,,,,"lui              x5, 0x92ed0000       ",800000ac,92ed02b7,
,t0,92ed0792,,,,,,"addi             x5, x5, 1938         ",800000b0,79228293,
,t1,00000000,,,,,,"addi             x6, x0, 0            ",800000b4,00000313,
,t2,00000000,,,,,,"addi             x7, x0, 0            ",800000b6,00000393,
...
etc.
** Contents of <ibex_git_repo>/dv/uvm/out/instr_gen/spike_sim/riscv_arithmetic_basic_test.0.csv**
instr,rd,rd_val,rs1,rs1_val,rs2,rs2_val,imm,str,addr,binary,mode
...
This test file is blank. It is supposed to be generated by <ibex_git_repo>/vendor/google_riscv-dv/scripts/spike_log_to_trace_csv.py. Attempting to run this script manually gives the same result, as follows:
Command
cd <ibex_git_repo>/uvm/dv
python3 ../../vendor/google_riscv-dv/scripts/spike_log_to_trace_csv.py --log out/instr_gen/spike_sim/riscv_arithmetic_basic_test.0.log --csv out/instr_gen/spike_sim/riscv_arithmetic_basic_test.0.csv
Contents of <ibex_git_repo>/uvm/dv/out/instr_gen/spike_sim/riscv_arithmetic_basic_test.0.log
core   0: 0x0000000000001010 (0x00028067) jr      t0
core   0: 0xffffffff80000080 (0x0100006f) j       pc + 0x10
core   0: 0xffffffff80000090 (0x5f47c037) lui     zero, 0x5f47c
core   0: 0xffffffff80000094 (0x51100013) li      zero, 1297
core   0: 0xffffffff80000098 (0x00004081) c.li    ra, 0
core   0: 0xffffffff8000009a (0xde6af137) lui     sp, 0xde6af
core   0: 0xffffffff8000009e (0x43210113) addi    sp, sp, 1074
core   0: 0xffffffff800000a2 (0xb2b851b7) lui     gp, 0xb2b85
core   0: 0xffffffff800000a6 (0x9f818193) addi    gp, gp, -1544
core   0: 0xffffffff800000aa (0x00004201) c.li    tp, 0
core   0: 0xffffffff800000ac (0x92ed02b7) lui     t0, 0x92ed0
core   0: 0xffffffff800000b0 (0x79228293) addi    t0, t0, 1938
core   0: 0xffffffff800000b4 (0x00004301) c.li    t1, 0
core   0: 0xffffffff800000b6 (0x00004381) c.li    t2, 0
...
etc.

Please enable RISCV_ENABLE_COMMITLOG when install spike
https://github.com/riscv/riscv-isa-sim/blob/master/config.h.in#L73

I made that change and reinstalled spike, and pulled all the latest changes from both git repositories, it seems like some changes went in since yesterday, now it completely passes.


fix: Receipt requirement is counting old receipts

Issues Addressed
Closes #299
Additional Information
I'm making this PR as a draft because Im not sure if this is the right way to solve the problem
so let me know what I can change or if its good

State logic changes can be found here: https://github.com/tiki/apps-receipt-capacitor/issues/326