Uncaught SyntaxError: import not found: clamp

Just decided to try this picker out as I appreciated the design, and ran into Uncaught SyntaxError: import not found: clamp immediately. You can recreate this by creating a brand new svelte/vite project and trying to load the picker.
Devtools links to the import from chyme in Picker.svelte.

Ji there,
It did happen before but I fixed it. There is paybe something else happening.
I'll have an eye on this soon!

Hey, I tried to install with npm i -D svelte-awesome-color-picker and copied the demo code in index.svelte without any trouble. Are you sure you installed the lastest version? I'll need a bit more insight to help you.
<script>
	import ColorPicker from 'svelte-awesome-color-picker';

	let rgb; // or hsv or hex
</script>

<ColorPicker bind:rgb />

Yes still happening. I'm on the latest version of both svelte/vite and the color picker (1.2.3). Try this:
npm create vite@latest picker-test -- --template svelte
cd picker-test
npm install
npm i -D svelte-awesome-color-picker
# change the App.svelte page to what you said
npm run dev

For me in both Firefox and Chrome this throws the same import not found error.

I didn't see your reply. 😨
I did try today the exact same thing and it's working like a charm.

Are you working on windows?
Do you see the lib chyme in your node_modules? If not, you can install it manually but you should definitely not have to
Can you copy the full stacktrace?


ringbuffer: dif is never less than zero

Since dif is of type uint64, it can never be less than 0. Instead, when attempting to put an item into a full queue or get an item from an empty queue, dif overflows in the mod calculation manner (e.g., -1 mod 2^64 becomes<PHONE_NUMBER>3709551615). In most cases, this overflow is not a serious problem because it is rare to use such an excessively large queue size. However, it might be better to clarify dif never goes negative numbers.

Security Insights
No security relevant content was detected by automated scans.
Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.


Update Hapi example

Since version 18 (released in January), Hapi's request.url returns the parsed URL, so parse is not needed.
Ref:

https://hapijs.com/api#-requesturl
https://github.com/hapijs/hapi/pull/3822

Thanks!


healthcheck: support rootless mode

now that dbus authentication works fine from a user namespace (systemd
241 works fine), we can enable rootless healthchecks.
It uses "systemd-run --user" for creating the healthcheck timer and
communicates with the user instance of systemd listening at
$XDG_RUNTIME_DIR/systemd/private.
Closes: https://github.com/containers/libpod/issues/3523
Signed-off-by: Giuseppe Scrivano<EMAIL_ADDRESS>

Looks like this fixes this issue:
$ podman run --name=docker_mongo_3_4_7 -d ... --healthcheck-command /bin/sh -c docker-healthcheck docker.COMPANY.COM:5004/PATH/mongo:3.4.7 --smallfiles
922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c

$ systemctl --user status 922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c
● 922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c.service - /usr/bin/podman healthcheck run 922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0b>
   Loaded: loaded (/run/user/1000/systemd/transient/922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c.service; transient)
Transient: yes
   Active: inactive (dead) since Tue 2019-07-09 15:30:50 EEST; 6s ago
  Process: 17103 ExecStart=/usr/bin/podman healthcheck run 922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c (code=exited, status=0/SUCCESS)
 Main PID: 17103 (code=exited, status=0/SUCCESS)

heinä 09 15:30:50 beckst-lnx systemd[1641]: Started /usr/bin/podman healthcheck run 922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c.
heinä 09 15:30:50 beckst-lnx podman[17103]: healthy
heinä 09 15:30:50 beckst-lnx systemd[1641]: 922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c.service: Succeeded.

$ systemctl --user status 922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c.timer
● 922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c.timer - /usr/bin/podman healthcheck run 922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5>
   Loaded: loaded (/run/user/1000/systemd/transient/922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c.timer; transient)
Transient: yes
   Active: active (waiting) since Tue 2019-07-09 15:26:10 EEST; 5min ago
  Trigger: Tue 2019-07-09 15:31:51 EEST; 19s left

heinä 09 15:26:10 beckst-lnx systemd[1641]: Started /usr/bin/podman healthcheck run 922d1277cc48418620843ecdc2ea1447c2cbd1322eaa0be5b8fe5c8fbc15e99c.

$ podman container inspect --format '{{json .Config.Healthcheck}}' docker_mongo_3_4_7
{"Test":["/bin/sh","-c","docker-healthcheck"],"Interval":30000000000,"Timeout":30000000000,"Retries":3}

$ podman container inspect --format '{{json .State.Healthcheck}}' docker_mongo_3_4_7
{"Status":"healthy","FailingStreak":0,"Log":[{"Start":"2019-07-09T15:30:50.215217205+03:00","End":"2019-07-09T15:30:50.417395522+03:00","ExitCode":0,"Output":""},{"Start":"2019-07-09T15:31:21.21267606+03:00","End":"2019-07-09T15:31:21.408044864+03:00","ExitCode":0,"Output":""},{"Start":"2019-07-09T15:31:52.215381587+03:00","End":"2019-07-09T15:31:52.41479621+03:00","ExitCode":0,"Output":""},{"Start":"2019-07-09T15:32:23.23313914+03:00","End":"2019-07-09T15:32:23.456162557+03:00","ExitCode":0,"Output":""},{"Start":"2019-07-09T15:32:54.218175701+03:00","End":"2019-07-09T15:32:54.412113251+03:00","ExitCode":0,"Output":""}]}

I'm unsure: should I report this here or on the issue? Is there a comment command I have to write to "acknowledge" the fix?

@stefanb2 here it is enough.  Thanks to have tried it out!

... and the service & timer units are removed after the container is stopped.

/lgtm
/hold

LGTM, nice work @giuseppe

/hold cancel


Feat: Add ASH file compression/decompression

A major feature required for libWiiPy to be able to surpass current offerings is the ability to both compress and decompress ASH files. Currently no library has support for this, there's just one Windows tool for extracting standard ASH files, one Python script for extracting only ASH files in My Pokemon Ranch, and then one Windows tool with no source that can compress standard ASH files.
Currently, there isn't any reference code out there for the compression routines, but thanks to the valiant effort of @Garhoogin, we now have modern, readable C code for decompression that can support both standard ASH files and the variant in My Pokemon Ranch, rather that needing two separate variations, which can be found here. It will need to be translated into Python, but then we'll have working decompression code, which is definitely a really great first step.
Work is currently being done to reverse engineer the compression routines.

Decompression is now fully working! Standard ASH files can be decompressed with the default options, and My Pokémon Ranch files can be decompressed if the distance tree bits are set to 15.
For the compression side, it's worth noting that ASH files are based on deflate and use Huffman trees to store the data.


jupyter kernel - connecting from csharp

Hi PTVS team,
since you connect jupyter kernel in PTVS, so I thought maybe you can point out what is the problem with ICSHARP. I recall that PTVS had similar connection problems once ipython project got updated from version 2 to 3. Can you please have a look?
https://github.com/zabirauf/icsharp/issues/5

@zooba @int19h we got ICSHARP (c# kernel) working for jupyter 4.0, is it possible to use VS intellisence in C# within ipython REPL if the kernel is switched from python to c#?

The current REPL is hardwired for Python editing, and won't switch language according to what the backend actually uses.
Note that C# guys are working on their own REPL (using the same core implementation as PTVS in VS 2015 - it's now part of VS platform, to be reusable by any language that needs one). Connecting to Jupyter sounds more like a feature for their implementation to support, though if they do it, it would probably be based on the work that we do for ours for 3.0.

We can't actually connect to a Jupyter kernel yet, though it's pretty high on my wishlist for 3.0. Once we have that, it should be relatively easy to port between languages.

how are you going to support R without this multi-language REPL? :) does NTVS use different REPL mechanism (no ipython)?

R support is a separate thing (RTVS) that's going to have its own REPL, same as C# etc. We're not focusing on Jupyter integration there for the first release, though it's probably going to happen at some later point.
NTVS REPL is its own thing and has no IPython integration.

Actually, the current REPL doesn't use IPython either :)
We mostly just hook stdin and stdout and redirect those. If you look at visualstudio_ipython_repl.py you'll see we're hijacking messages that would have been rendered by the console renderer, rather than using the protocol directly.

this has been fixed


When examining the interaction, the covalent bond is not displayed.

When I pulled up the results on Discovery Studio to observe the interaction, instead of forming a covalent bond, it displayed as an unfavorable bump. I utilized a command targeting a specific Residue, namely Cys, and a suitable warhead group.

Please provide a reproducible example and a better description of what the problem is.

Thank sir. Here is one of several results I obtained when targeting ATOM S at Cys81. However, upon examining the interaction between the receptor and its ligand (through Discovery Studio), there is no formation of a covalent bond. This is the issue I am currently facing. Thank you for taking the time to assist me.
      (_)

/  | '_ \| | '_ \ / _ |
| (| | | | | | | | | (| |
_, || |||| ||_,|
/ |
|/
gnina v1.1 master:e4cb380+   Built Dec 18 2023.
gnina is based on smina and AutoDock Vina.
Please cite appropriately.
Commandline: ./gnina -r 2lnsA.pdb -l NOHA-1.pdb --config ConfigCys.txt --covalent_rec_atom A:81:SG --covalent_lig_atom_pattern C=C -o Output_ligand/NOAH-1a_lig_covalent_docking.sdf
Using random seed: 144604580
0%   10   20   30   40   50   60   70   80   90   100%
|----|----|----|----|----|----|----|----|----|----|

mode |  affinity  |  intramol  |    CNN     |   CNN
| (kcal/mol) | (kcal/mol) | pose score | affinity
-----+------------+------------+------------+----------
1       -2.83        0.00       0.5767      2.740
2       -2.77        0.00       0.5631      3.206
3       -3.14        0.00       0.5284      3.037
4       -2.54        0.00       0.5270      2.939
5       -2.73        0.00       0.5242      3.274
6       -2.78        0.00       0.5203      2.928
7       -3.29        0.00       0.5174      3.486
8       -2.96        0.00       0.4820      2.960
9       -3.94        0.00       0.4797      3.284
Below is the image illustrating the interaction between the ligand and the receptor.

Thank you.

I can't reproduce your example since you haven't provided any files, but of course there is going to be a steric clash at the covalent interaction if the ligand is being analyzed as a non-covalent binder.

Please provide a reproducible example and a better description of what the problem is.

I can't reproduce your example since you haven't provided any files, but of course there is going to be a steric clash at the covalent interaction if the ligand is being analyzed as a non-covalent binder.

Thank sir. I used the warhead group to form a covalent bond. These are the files I used in the example above.
Covalent Docking.zip

There is nothing wrong here.  The output is correct.  Why do you think otherwise?

There is nothing wrong here. The output is correct. Why do you think otherwise?

Thank you. I've only recently started delving into this field, so there are still many mistakes on my part. I hope you understand. Regarding this issue, when I observed the interaction between the ligand (output file) and the receptor (2lnsA), I didn't see any covalent bonds formed in the image I posted above; it indicated an unfavorable bump instead. Therefore, I think I might have made a mistake somewhere along the way. Thank you for taking the time to assist me.

The covalent ligand and the receptor are provided to Discovery Studio as separate files.  It does not know they are suppose to be covalently bound.


Fix two issues with moving to workspaces

Seeing a couple of issues moving to workspaces. One is a global issue with React Scripts 5, and might be solved with this issue:

https://github.com/storybookjs/storybook/issues/17049

The other is a single issue with a Vite dependencies mis-match in React-DOM.

Turns out CRA doesn't work with NPM workspaces. Started a new repo that only uses Vite and will migrate projects (or start new ones) in that repo. Eventually will archive this one.


Bluetooth: controller: legacy: Fix Tx pool corruption

Fix Tx pool from being corrupted when rough central device
uses invalid packet sequence numbers, causing NULL pointer
to be released into free data Tx pool.
Fixes #22968.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

@cvinayak want this merged for 2.2?


exclude tests from coverage

Codecov Report

Merging #25 (3527f60) into main (c4037e2) will increase coverage by 1.79%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main       #25      +/-   ##
===========================================
+ Coverage   98.20%   100.00%   +1.79%
===========================================
  Files           6         5       -1
  Lines        1558       698     -860
===========================================
- Hits         1530       698     -832
+ Misses         28         0      -28

Impacted Files
Coverage Δ

tests/main.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4037e2...3527f60. Read the comment docs.


Add offset to Clock.UserTimeClock against overflow

UserTimeClock returns elapsed time from an arbitrary starting time, not
epoch. This means value could be negative or arbitrarily large (not in
line with System.currentTimeMillis.) Other metrics classes, such as
SlidingTimeWindowReservoir multiply the Clock.getTicks with some value
to create a collision buffer. If nanoTime is large enough, this can
overflow and break the window.
To work around this, this commit modifies Clock.UserTimeClock to return
elapsed time since the UserTimeClock class was classloaded. It is still
elapsed time and increasing, but it will be a smaller value and therefore
less likely to overflow. Unless the JVM has a really long uptime. Hmm...

This isn't guaranteed to fix the issue, I've reopened #515.

I don't know about the leak but this patch does fix the overflow issue. What do you think is missing?

It is possible that the class is loaded when long ns = System.nanoTime(); ns >= 0 && ns < Long.MAX_VALUE / COLLISION_BUFFER thus the overflow behavior is entirely unchanged. Also, javadocs advise us that nanoTime may be negative, causing further weirdness, including but possibly not limited to underflow.

I don't quite get the class loading issue. However, the negative nanos shouldn't be a problem as long as the difference is used; values from subsequent invocations will always be larger numbers.

Having thought through it, the answer, if we're going to do getTick() * 256 in SlidingTimeWindowReservoir, is to change all instance of that to (something like) (getTick() % (Long.MAX_VALUE / COLLISION_BUFFER)) * COLLISION_BUFFER.

@ryantenney - Can you explain your comment to @omerkudat regarding:
long ns = System.nanoTime(); ns >= 0 && ns < Long.MAX_VALUE / ((COLLISION_BUFFER - 1) / COLLISION_BUFFER)
Providing only offsets from an initial value System.nanoTime()obtained when the UserTimeClock class is loaded seems okay, although I do agree that overflow could eventually happen over a long period of time when multiplying by COLLISION_BUFFER.

This will still cause an overflow after ~417 days uptime by my reckoning

Here's what I've done at my place that fixed it https://github.com/dropwizard/metrics/pull/931
We had this problem when physical server uptime was over 417 days - rebooting server, would restart up time for another 417 days, but we wanted a permanent fix, so I created this one.


Not all recurring transactions are created at the same time

When I set up a new recurring transaction, only two new transactions will appear: the start date transaction and the first recurrence. Each time I re-open the account, it adds a single further recurring transaction in the series until the recurrences have caught up to present day.
This is a very annoying problem if I'm adding a bunch of data at once as I have to close and re-open the account repeatedly to get it to populate.

Hmm interesting....I think this might have broke when we introduced the transaction reminders system. Will look into it

https://github.com/NickvisionApps/Denaro/releases/tag/2023.9.0


[Bug] Fix colocate/buck_shuf grf with bucket absent

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
https://github.com/StarRocks/starrocks/issues/6686
Problem Summary(Required) ：

When a runtime filter generated buck_shuf join is used as a global rf, it aslo needs bucketseq-to-partition mapping to keep the build side and probe side have the same data partition policy.
In both colocate and buck_shuf grf,  some buckets would be pruned, so set the corresponding partition index in bucketseq-to-partition mapping to a special value(BUCKET_ABSENT) to indicate that the bucket is absent.

run starrocks_fe_unittest

run starrocks_fe_unittest


Error while device discovery

The unexpected behaviour takes place during device discovery.
The UI shows a throbber for a long time. After a while, the device list appears.
It happens rarely but all the exceptions have to be handled correctly.
2017-10-06 09:18:15,616 WARNI [netdisco.ssdp] Error fetching description at http://<IP_ADDRESS>:1400/xml/device_description.xml
2017-10-06 09:18:15,955 WARNI [netdisco.ssdp] Found malformed XML at http://<IP_ADDRESS>:2869/upnphost/udhisapi.dll?content=uuid:ade7e5de-6475-4210-9560-15012dd35ec5:

Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/requests/packages/urllib3/connection.py", line 142, in _new_conn
    (self.host, self.port), self.timeout, **extra_kw)
  File "/usr/lib/python3.5/site-packages/requests/packages/urllib3/util/connection.py", line 98, in create_connection
    raise err
  File "/usr/lib/python3.5/site-packages/requests/packages/urllib3/util/connection.py", line 88, in create_connection
    sock.connect(sa)
TimeoutError: [Errno 110] Connection timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 595, in urlopen
    chunked=chunked)
  File "/usr/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 363, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/usr/lib/python3.5/http/client.py", line 1106, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python3.5/http/client.py", line 1151, in _send_request
    self.endheaders(body)
  File "/usr/lib/python3.5/http/client.py", line 1102, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python3.5/http/client.py", line 934, in _send_output
    self.send(msg)
  File "/usr/lib/python3.5/http/client.py", line 877, in send
    self.connect()
  File "/usr/lib/python3.5/site-packages/requests/packages/urllib3/connection.py", line 167, in connect
    conn = self._new_conn()
  File "/usr/lib/python3.5/site-packages/requests/packages/urllib3/connection.py", line 151, in _new_conn
    self, "Failed to establish a new connection: %s" % e)
requests.packages.urllib3.exceptions.NewConnectionError: <requests.packages.urllib3.connection.HTTPConnection object at 0xb2f7a5b0>: Failed to establish a new connection: [Errno 110] Connection timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/requests/adapters.py", line 423, in send
    timeout=timeout
  File "/usr/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 640, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/usr/lib/python3.5/site-packages/requests/packages/urllib3/util/retry.py", line 287, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
requests.packages.urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='<IP_ADDRESS>', port=1400): Max retries exceeded with url: /xml/device_description.xml (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0xb2f7a5b0>: Failed to establish a new connection: [Errno 110] Connection timed out',))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/device_discovery", line 9, in <module>
    load_entry_point('senic-hub', 'console_scripts', 'device_discovery')()
  File "/usr/lib/python3.5/site-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3.5/site-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.5/site-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3.5/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/home/root/senic-hub/senic_hub/backend/device_discovery.py", line 60, in command
    discover_and_merge_devices(devices_path, now)
  File "/home/root/senic-hub/senic_hub/backend/device_discovery.py", line 68, in discover_and_merge_devices
    discovered_devices = discover_devices()
  File "/home/root/senic-hub/senic_hub/backend/device_discovery.py", line 103, in discover_devices
    device_description = get_device_description(device_type, device_info)
  File "/home/root/senic-hub/senic_hub/backend/device_discovery.py", line 200, in get_device_description
    return device_class(device_info).device_description
  File "/home/root/senic-hub/senic_hub/backend/device_discovery.py", line 316, in __init__
    response = requests.get('http://{}:1400/xml/device_description.xml'.format(self.ip_address))
  File "/usr/lib/python3.5/site-packages/requests/api.py", line 70, in get
    return request('get', url, params=params, **kwargs)
  File "/usr/lib/python3.5/site-packages/requests/api.py", line 56, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/lib/python3.5/site-packages/requests/sessions.py", line 475, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/lib/python3.5/site-packages/raven/breadcrumbs.py", line 297, in send
    resp = real_send(self, request, *args, **kwargs)
  File "/usr/lib/python3.5/site-packages/requests/sessions.py", line 596, in send
    r = adapter.send(request, **kwargs)
  File "/usr/lib/python3.5/site-packages/requests/adapters.py", line 487, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='<IP_ADDRESS>', port=1400): Max retries exceeded with url: /xml/device_description.xml (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0xb2f7a5b0>: Failed to establish a new connection: [Errno 110] Connection timed out',))
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.5/threading.py", line 862, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib/python3.5/site-packages/netdisco/mdns.py", line 20, in start
    self.zeroconf = zeroconf.Zeroconf()
  File "/usr/lib/python3.5/site-packages/zeroconf.py", line 1523, in __init__
    socket.inet_aton(_MDNS_ADDR) + socket.inet_aton(i))
OSError: [Errno 105] No buffer space available

2017-10-06 09:20:47,768 INFO  [root] Next device discovery run scheduled for 2017-10-06 09:20:55.771880

Will be closed by a PR in the senic-os repository. This error has been fixed by updating the sysctl value : /proc/sys/net/ipv4/igmp_max_memberships to more than zero.


Sparse matrix multiply orders of magnitude slower than PyTorch

I have been doing some profiling comparing cupy's sparse matrix dot() with PyTorch's mm() and I'm getting some very surprising results. I noticed that while cupy is using cusparse, PyTorch appears to be using only thrust/cub to do the multiply.
Strangely, I'm finding that it's the cusparse csrgemm_kernel from cupy that is dominating the runtime of the multiply, taking 40ms. The end-to-end matrix multiply is taking upwards of 70ms for cupy. The PyTorch implementation is taking a little over 2ms to run the multiply end-to-end.
I'm attaching the nvvp file with my profiling results. I'm pretty surprised. The algorithm being profiled is a simple Multinomial Naive Bayes using the 20-newsgroups dataset from scikit-learn. I trained both algorithms twice in order to eliminate jit and cuda context creation from the comparison.
>>> cupy.show_config()
CuPy Version          : 6.5.0
CUDA Root             : /usr/local/cuda
CUDA Build Version    : 10000
CUDA Driver Version   : 10000
CUDA Runtime Version  : 10000
cuDNN Build Version   : 7600
cuDNN Version         : 7600
NCCL Build Version    : 2406
NCCL Runtime Version  : 2406

Related: #2664

Could you try the proposed patch? https://github.com/cupy/cupy/pull/2698

Could you try the proposed patch? #2698

I only implemented matrix-vector multipy (spmv) in #2698 and did not try spmm. (Also the gains or not an order of magnitude as mentioned here).  Regardless of how small the sparse matrix is, it seems that even the CUB-based approach still takes close to 20 ms. It could be useful to determine what the source of that overhead is.
@cjnolet.  How many nonzero entries are in the dataset you are testing with?

@grlee77, I'm using the 20-newgroups with all the labels from scikit-learn, which looks to have an nnz of 1787565.
from sklearn.metrics import accuracy_score
from sklearn.datasets import fetch_20newsgroups
from sklearn.feature_extraction.text import CountVectorizer
from sklearn.preprocessing import LabelBinarizer

import cupy.prof
import time
import math
import torch
import numpy as np

Here's the PyTorch Naive Bayes implementation that I've been using for comparison:
def scipy_to_torch(sp):
    coo = sp.tocoo()
    values = coo.data
    indices = np.vstack((coo.row, coo.col))

    i = torch.cuda.LongTensor(indices)
    v = torch.cuda.FloatTensor(values)

    return torch.cuda.sparse.FloatTensor(i, v, torch.Size(coo.shape))

class PyTorchBayes(object):

    def __init__(self, l, alpha=1.0, fit_prior=True, class_prior=None):
        self.alpha = alpha
        self.l = l
        self.fit_prior = fit_prior
        self.class_prior = class_prior

        self.n_features_ = None

    @cp.prof.TimeRangeDecorator(message="pytorch_fit()", color_id=1)
    def fit(self, X, y, _partial=False, _classes=None):

        self.n_features_ = X.shape[1]
        self._init_counters(y.shape[1], X.shape[1])

        self.classes_ = self.l.classes_
        self.n_classes_ = self.l.classes_.shape[0]

        self._count(X, y)
        self._update_feature_log_prob(self.alpha)
        self._update_class_log_prior(class_prior=self.class_prior)

        return self

    def predict(self, X):
        jll = self._joint_log_likelihood(X)

        _, indices = torch.max(jll, 1)
        return indices

    def _init_counters(self, n_effective_classes, n_features):
        self.class_count_ = torch.zeros(n_effective_classes).cuda()
        self.feature_count_ = torch.zeros(n_effective_classes, n_features).cuda()

    def _count(self, X, Y):

        with cp.prof.time_range(message="pytorch_matrix_multiply", color_id=7):
            feature_count_ = torch.sparse.mm(X.t(), Y).t()

        print(str(feature_count_))

        self.feature_count_ += feature_count_
        self.class_count_ += Y.sum(axis=0)

    def _update_class_log_prior(self, class_prior=None):

        if class_prior is not None:
            self.class_log_prior_ = torch.log(class_prior)

        elif self.fit_prior:
            log_class_count = torch.log(self.class_count_)

        self.class_log_prior_ = torch.full((self.n_classes_, 1),
                                           -math.log(self.n_classes_)).cuda()

    def _update_feature_log_prob(self, alpha):
        """ apply add-lambda smoothing to raw counts and recompute log probabilities"""
        smoothed_fc = self.feature_count_ + alpha
        smoothed_cc = smoothed_fc.sum(axis=1).reshape(-1, 1)
        self.feature_log_prob_ = (torch.log(smoothed_fc) - torch.log(smoothed_cc))

    def _joint_log_likelihood(self, X):
        """ Calculate the posterior log probability of the samples X """
        ret = torch.sparse.mm(X, self.feature_log_prob_.T)
        ret += self.class_log_prior_.T
        return ret

def load_corpus_cpu():

    twenty_train = fetch_20newsgroups(subset='train',
                                      shuffle=True, random_state=42)

    count_vect = CountVectorizer()
    X = count_vect.fit_transform(twenty_train.data)
    Y = twenty_train.target

    return X, Y

And here's the small script I'm running to test PyTorch:

X, y = load_corpus_cpu()
l = LabelBinarizer()
Y = torch.cuda.FloatTensor(l.fit_transform(y)).cuda()

a = scipy_to_torch(X)

# Run once to "prime" any initialization
m = PyTorchBayes(l)
m.fit(a, Y)

with cupy.prof.time_range(message="fit()"):
  start = time.time()
  m = PyTorchBayes(l)
  m.fit(a, Y)
  end = time.time() - start

print("PYTORCH: %s" % str(end))

y_hat_gpu = m.predict(a)
print(str(accuracy_score(y, y_hat_gpu.cpu().numpy())))

I'm getting this as my output (accuracy matches scikit-learn):
PYTORCH: 0.008881330490112305
0.9245182959165635

time.time() does not include GPU activities, so looks like only kernel launch time is counted. How did you time the CuPy code?

I timed each algorithm internally using ‘cupy.prof.time_range’ (as can be seen here and found the numbers described in the description.
The end to end times were computed for internal cuml benchmarking, but I felt it relevant to post them here. I had run a test-case where I synchronized the streams before calling ‘start = time.time()’ but didn’t find any difference in the runtimes.
Also, important to note- the order of magnitude difference being referred in the title is the actual runtime of the sparse multiply kernels (from the attached nvvp session) and not the end to end from ‘time.time()’.

@leofang, I missed the ‘sync=True’ in the fit() function when constructing the reproducible script. I’ve updated my previous reply accordingly.

Thanks, I didn't pay attention to the origin post and jumped into the middle of the thread. Could you share your cupy script so we can test locally ourselves? It'd offer a different view from an nvvp session.

sorry that I opened a different issue for SpMV, but in #2790 I attached a modification to cupyx/scipy/sparse/coo.py, that improved the timing for SpMV with 10M nnz  from 0.06 to 0.00024 seconds. I could be related.


Introduce per domain metrics

What changed?
Introduce PerDomain metrics

Why?
Make the changes to metrics backward compatible

How did you test it?
existing test

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 0183c93b-f07e-4a98-9b40-90281e44bb75

48 of 111 (43.24%)  changed or added relevant lines in 3 files are covered.
70 unchanged lines in 9 files lost coverage.
Overall coverage increased (+0.06%) to 57.384%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/persistence/elasticsearch/esVisibilityMetricClients.go
12
37
32.43%

common/persistence/persistenceMetricClients.go
26
64
40.63%

Files with Coverage Reduction
New Missed Lines
%

common/persistence/persistenceMetricClients.go
1
55.64%

common/cache/lru.go
2
92.2%

common/task/fifoTaskScheduler.go
2
84.54%

common/task/parallelTaskProcessor.go
2
92.75%

common/util.go
2
52.44%

common/persistence/nosql/nosqlplugin/cassandra/workflow.go
3
59.1%

common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go
14
79.16%

service/history/execution/mutable_state_task_refresher.go
15
64.24%

common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go
29
74.22%

Totals

Change from base Build 01839f28-1836-42e5-a407-d235d95acd74:
0.06%

Covered Lines:
85335

Relevant Lines:
148709

💛  - Coveralls


Consider WebUSB as alternative solution for Chrome Apps deprecation

An alternative to building native applications (issue #64) as a solution to the Chrome Apps deprecation on Linux, macOS and Windows (issue #29) is to move the Chrome Apps code onto ledgerwallet.com and use the WebUSB API (available in Chrome) to communicate with the hardware wallet.
This path is being investigated by the Trezor hardware wallet (development branch).
Disclosure: I am the author of the WebUSB specification.

We're currently doing the same thing over U2F and have been deploying it since 2016. WebUSB is also an option we'll be looking at in the future.


After changing WSL to be installed from the Windows Store, I now get "UtilTranslatePathList:2671: Failed to translate" for the BoxCryptor drive.

Version
Microsoft Windows [Version 10.0.19045.2311]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
Ubuntu 20.04
Other Software
BoxCryptor 2.53.2568
Repro Steps
Have BoxCryptor installed and set up to encrypt at least one cloud data provider (e.g. OneDrive)
Expected Behavior
WSL should start without any complaints.
Actual Behavior
WSL complains that:
<3>WSL (443) ERROR: CreateProcessParseCommon:782: Failed to translate X:\

As far as I can tell, this doesn't affect functionality (I always knew I couldn't access the Boxcryptor drive from WSL2), but before I set WSL to be installed from the Windows Store, I never got this warning. It keeps showing up in scripts that call WSL tools.
Diagnostic Logs
No response

/logs

Thanks @dandrei.
I'm not seeing the WSL boot logs in the folder you shared. Can you try running wsl.exe --shutdown before running the trace collection script ?

WslLogs-2022-12-14_23-22-09.zip
How about now?

Similar issue for me.
Steps to reproduce
0- check that F drive does not exist
C:>f:
The system cannot find the drive specified.
1- get WSL2 with Ubuntu 20-04 on Windows 10 running with no error
2- upgrade WSL with wsl --install
3- (not sure if necessary to reproduce) upgrade Ubuntu to 22-04
4- launch wsl
Expected behavior
No error message
Actual behavior
C:>wsl
<3>WSL (160) ERROR: UtilTranslatePathList:2671: Failed to translate f:\temp\windows.x64_193000_db_home\bin
root@FR-PAR-PF31E9M0:/mnt/c#

Make sure if the f:\temp\ is not present in PATH environment variable. If present try to remove it.

Removing
f:\temp\windows.x64_193000_db_home\bin
from the windows path has resolved the issue.
Many thanks

The latest exchanges are about a different issue (folders not accessible to WSL that are included in the PATH environment variable). This does not address the original question, and in fact people should not be forced to remove folders they actually need from the PATH variable just to suppress a WSL warning message.

I'm having the same error:
<3>WSL (18890) ERROR: UtilTranslatePathList:2671: Failed to translate f:\temp\windows.x64_193000_db_home\bin
but when I look to windows path, I do not see such entry
Maybe I'm looking at it in the wrong way.
I displayed the Path using: echo %PATH%
So to me this error message should not be there

I'm having the same error: <3>WSL (18890) ERROR: UtilTranslatePathList:2671: Failed to translate f:\temp\windows.x64_193000_db_home\bin
but when I look to windows path, I do not see such entry
Maybe I'm looking at it in the wrong way. I displayed the Path using: echo %PATH%
So to me this error message should not be there

when checking the system path I saw the reference to f:\temp\windows.x64_193000_db_home\bin and was able to remove.

I get the same error:
<3>WSL (515) ERROR: UtilTranslatePathList:2671: Failed to translate D:\apache-ant-1.9.16\bin
<3>WSL (515) ERROR: UtilTranslatePathList:2671: Failed to translate D:\xpdf-tools-win-4.04\bin64
rookyzer@Lithium:~$

Steps to reproduce? this immediately after the latest Windows update. system restarted, I launchd WSL and there it was.

Try to remove those directories from PATH or other environment variable.

none of the files on my D drive are visible but, I can see them from windows

I mean from Windows' PATH variable. Do those directories appear in echo %PATH% command output in Command Prompt?

yes.
D:>echo %PATH%
C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Python310\Scripts;C:\Python310;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\jdk-11.0.16\bin;C:\Program Files\WinMerge;C:\Program Files\nodejs;C:\ProgramData\chocolatey\bin;C:\Program Files\Amazon\AWSCLIV2;C:\Gradle\gradle-7.5.1\bin;C:\apache-maven-3.8.6\bin;C:\Users\user\AppData\Local\Microsoft\WindowsApps;C:\Users\user\AppData\Local\Programs\Microsoft VS Code\bin;C:\Users\user\AppData\Roaming\npm;D:\apache-ant-1.9.16\bin;D:\xpdf-tools-win-4.04\bin64
D:>

removing those directories from PATH did the trick; I guess I'll just launch using the fullpath names


ExternalSecrets should be have namespace prefix

When creating external secrets it would be nice if newly created secrets in vault service (GKE,Azure, Aws,...) would have namespace prefix in their name.
E.g. If you have 2 environments in one cluster (staging and beta), then you define secret, it should be mapped to different vault secrets so that you can rotate/change them independently and they are different across environmets .
Currently you have to do this by creating externalSecret resource manually and create links to two different vault secrets.
Inspiration is in this thread:
https://kubernetes.slack.com/archives/C9MBGQJRH/p1625211231317400

this is a more flexible solution #351
though we do have support for an annotation you can use to conditionally use a different prefix in vault based on the environment/namespace: https://jenkins-x.io/v3/develop/faq/config/secrets/#how-do-i-configure-secrets-differently-in-staging-versus-production


Add the ability to set a foreign key on a model to create relationships

It would be great if developers could be a given the option to create one-to-one relationships using foreign keys. This pattern should feel natural for developers who are familiar with relational databases.
import { factory, primaryKey, foreignKey } from '@mswjs/data'

const db = factory({
  user: {
    id: primaryKey(String),
    publications: manyOf('post'),
  },
  post: {
    id: primaryKey(String),
    userId: foreignKey("user")
    title: String,
  },
})

And then we could get posts belonging to a specific user with the following syntax.
const user = db.user.findFirst({
   where: {
      id: "abc"
   }
})

const userBlogPosts = db.post.findMany({
   where: {
      user_id: user.id
   }
})

Alternatively, the library could implicitly create a userId field on a blogPost if blogPost was declared with a oneOf("user") relationship. I think this is what mirage does.

Hi, @canrozanes. Thanks for raising this.
Tell me, would the usage of transient + derivative properties work for you?
const db = factory({
  user: {
    id: id(Number),
    city: transient(oneOf('city')),
    cityId: derivative(({ city }) => city.name),
  },
  city: {
    name: id(String),
  },
})

const user = db.user.create({
  id: 1,
  city: db.city.create({ name: 'London' }),
})

user.cityId // "London"
user.city // undefined

I'm tackling this precise use case in the Data rewrite and I could use your feedback.
Why not use foreignKey()?
The API you proposed implies that the key given as the value to the user_id property would be identifiable as foreign. But in the context of operations (create/update/etc), those key are taken from the existing extraneous models (like user), and will know nothing about post.userId having to be foreign.
To put plainly, it becomes problematic to ensure the contract with this kind of API.


Automatically enable required add-ons in Blender preferences

Users can simply run the setup_world function instead of manually enabling in the preferences the 'add_mesh_extra_objects' add-on during first installation.
https://github.com/smegason/Goo/blob/3c6d8f5f85da776a22e385a88feba4d5b0e74b71/scripts/modules/goo/goo.py#L1887
If other add-ons become needed to run Goo, they will be added in future releases.
Thanks to Charles Dai for the idea.

Fixed.


Restructures directories in preparation for mono-repo.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.882%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1424

Relevant Lines:
1639

💛  - Coveralls


A few suggestions that might

help improve/extend OS detection/support
install more of the dependencies - curl and wget were missing

Just some completely untested notes so setting this draft.

Shall have a proper look but looks like the option of using an IP has been removed?

Guess checking for systemd is necessary as well. However should just change the description to modern os

Typos and sudo due to late night dev!
Just noticed I'm just up the road from you, in Perthshire.

I do that a lot too - my missing fi contribution was due to the summons to eat :-)
I enjoyed Perthshire when we used it as a base for the Glasgow Commonwealth Games combined with a holiday that was probably the start of our journey to becoming "New Scots" ( although it seems I've really just come "home".

Shall have a proper look but looks like the option of using an IP has been removed?

? :eyeglasses:  ?

Lol. So not actually in Ayrshire then?
In the first change on the install script there's a check for a genuine domain, I don't believe the automatic retrieval of IP has been left in. As some will use dns addresses and some are happy using IP, I wanted to give the opportunity to use both, especially at the moment as not using ssl for anything.

nope IP check is still there, thats what you get for checking on your phone lol

going to merge into dev

Lol. So not actually in Ayrshire then?
Oh yes - East Ayrshire and loving it.
I'll try and test it out later and if I didn't break anything obvious I'll de-draft it.

Ah cool, Ill test off of your repo now

ok, so tested on 3 distros
centos:
Installing prerequisites
Unsupported OS```

ubuntu 20.04: (ran prereqs manually and installed fine)
```unzip command doesnt exist```

Debian 11:

Choose your preferred option, IP or DNS/Domain:1
Installing prerequisites
Unsupported OS

Thanks for the feedback - I'll take a look at what I've borked ...

I don't have the energy myself to debug tonight but after meetings tomorrow can have a look and do some tests etc depending how you get on

So far so good : tested and working on ZorinOS and Pop! and Mint ...

ok, so tested on 3 distros centos: `./install.sh: line 13: dig: command not found (easy sorted just need a yum install dig at the start)

centos-stream 9 didn't need dig, but maybe ... probably worth adding to the prereqs and make that the first action
tested on alma and failed because no wget ??? manually installing prereqs first it sailed through OK so there's something fishy there (it looks like it  gets picked up as a rhel derivative but  then messes up the yum somehow ... probably the same issue with opensuse ...)

yeah move os detect and prereqs first I think would make sense.
Can deal with any anomalies as they come up with distros, ill test with centos, ubuntu and debian, tbf the majority of first time users/guys with less experience will use one of those 3 I would imagine.

is that you finished now? If so can merge to dev

still getting the issues using a vps hosted on hetzner, how are you testing it?

local QEMU VMs  Not always freshly installed (some are playing at being github workflow runners etc ...

how strange, moved the install above the choice so dig is definitely installed, just playing with it myself, I have seen combined before not working for apt and yum

still getting the issues using a vps hosted on hetzner, how are you testing it?
Debian - E: Unable to locate package curl wget unzip tar dnsutils

oof!  Hmm, my vm must have been pre-populated.
I think it is getting quoted combined package name to install :-(  Either need to separate out again (ugly)
or refactor to "+="  the whole command or some such.

I have changed it slightly and it appears to work fine now, but thats separating out the prereqs, which doesnt make much sense why it would be different

Suse was me forgetting yast/zypper since a long time ... working on a refactor but can't test til later.

I think you just need to remove the quotes from apt-get install ${PREREQ}

done that and yeah working fine, I broke debian prereqs off to PREREQDEB and centos to PREREQYUM just incase we need to use it more in the future

see alternate PR ...
I need to get to other stuff now ... back later


Support parallel provisioning of workers

To clarify, this issue is to spin up/horizontally scale into more linode workers as needed?

It's currently possible to scale up the cluster by simply changing the NO_OF_WORKERS variable in settings.env, and running ./kube-linode.sh create again. This issue is more of speeding up the process of provisioning by provisioning them in parallel as opposed to running them sequentially.


Feature Request: add support 16k Gpt models

Open AI has rolled out 16k versions of their GPT models. Please add support with BetterChatGPT for these versions.

I've opened a pull request for this. https://github.com/ztjhz/BetterChatGPT/pull/351


RecipeUnlocker

Mod name
RecipeUnlocker
Curseforge link

Modrinth link

Other link
https://github.com/gbl/RecipeUnlocker
What it does
Removes the recipe unlocking mechanic
Why should it be in the modpack
Unlocking recipes makes no sense for survival Minecraft, only custom maps. This is evident by Bedrock Edition as well, where this feature does not exist.
Why shouldn't it be in the modpack
No license, not on CF, animations may distract, unlocking tooltips must still be disabled with another mod
Categories

[ ] Performance optimization
[ ] Graphics optimization
[x] New feature
[ ] Optifine parity
[ ] Fixes a bug/dependency
[ ] Replaces an existing mod

Additional details

Related: I Am Very Smart

Please replace with I Am Very Smart, it's well known and widely used.

Okay, I'll make a new issue for that.
This one is now rejected because it's closed, not in CF and abandoned.


Throw error instead of returning undefined

Related to https://github.com/microsoft/vscode-jupyter/pull/7795
Basically ensure IJupyterSession to line up with the Jupyter lab API
With this change, its similar to Jupyter Lab services API, hence switching over to the other is easier.

Codecov Report

Merging #7800 (5fa04ba) into main (9d21db7) will increase coverage by 0%.
The diff coverage is 71%.

@@          Coverage Diff           @@
##            main   #7800    +/-   ##
======================================
  Coverage     69%     69%
======================================
  Files        363     363
  Lines      22275   22285    +10
  Branches    3377    3375     -2
======================================
+ Hits       15510   15520    +10
- Misses      5426    5998   +572
+ Partials    1339     767   -572

Impacted Files
Coverage Δ

src/client/datascience/types.ts
100% <ø> (ø)

src/client/datascience/jupyter/jupyterNotebook.ts
68% <44%> (+<1%)
:arrow_up:

src/client/datascience/baseJupyterSession.ts
68% <66%> (-1%)
:arrow_down:

src/client/debugger/jupyter/kernelDebugAdapter.ts
79% <83%> (-1%)
:arrow_down:

...lient/datascience/jupyter/kernels/cellExecution.ts
77% <100%> (+<1%)
:arrow_up:

...ent/datascience/jupyter/pythonVariableRequester.ts
45% <0%> (-8%)
:arrow_down:

src/client/common/application/webviews/webview.ts
69% <0%> (-2%)
:arrow_down:

src/client/datascience/jupyter/kernels/kernel.ts
73% <0%> (-2%)
:arrow_down:

src/client/api.ts
51% <0%> (ø)

src/client/api/pythonApi.ts
62% <0%> (ø)

... and 107 more


Sentinl Watchers: Error 500 Internal Server Error: An internal server error occurred

kibana version 5+
elasticsearch version 5+
recently i configured sentinl and created alert when i try to run that alert i am getting error like
Sentinl Watchers: Error 500 Internal Server Error: An internal server error occurred .Please provide an example of configuration setup for generating alert mail notification based on condition like x>100.

I'm sorry but this is completely unclear. Please take time to read the Wiki documentation, and if you want, feel free to open a new issue with proper description, logs and information. Thanks.


Add listener/endpoint configuration population logic to grpc module.

Purpose
This is to fix invalid error message when we add a wrong configuration for listener and client endpoint initialization.
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #18823 into master will increase coverage by 4.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #18823      +/-   ##
==========================================
+ Coverage   14.95%   19.92%   +4.96%
==========================================
  Files          47       52       +5
  Lines        1230     1355     +125
  Branches      187      208      +21
==========================================
+ Hits          184      270      +86
- Misses       1033     1072      +39
  Partials       13       13

Impacted Files
Coverage Δ

composer/packages/tracing/src/ToolBar.tsx
71.05% <0%> (ø)

composer/packages/tracing/src/TraceList.tsx
94.44% <0%> (ø)

composer/packages/tracing/src/DetailView.tsx
79.31% <0%> (ø)

composer/packages/tracing/src/TraceLogs.tsx
70.37% <0%> (ø)

composer/packages/tracing/src/index.ts
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e74e9...709b070. Read the comment docs.


Update macro to allow for return value, to add get_incoming_transactions, start working on new test

Codecov Report
Patch coverage: 77.55% and project coverage change: +0.41 :tada:

Comparison is base (ab6e589) 56.55% compared to head (b5550d7) 56.96%.

:exclamation: Current head b5550d7 differs from pull request most recent head 01a46a0. Consider uploading reports for the commit 01a46a0 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #375      +/-   ##
==========================================
+ Coverage   56.55%   56.96%   +0.41%
==========================================
  Files          35       35
  Lines        5243     5277      +34
==========================================
+ Hits         2965     3006      +41
+ Misses       2278     2271       -7

Impacted Files
Coverage Δ

zingocli/tests/darkside/constants.rs
100.00% <ø> (ø)

zingolib/src/wallet.rs
63.42% <ø> (-0.31%)
:arrow_down:

zingolib/src/lightclient.rs
61.80% <50.00%> (+1.37%)
:arrow_up:

zingolib/src/wallet/traits.rs
51.00% <50.00%> (ø)

zingocli/tests/darkside/tests.rs
87.03% <90.00%> (+0.67%)
:arrow_up:

zingocli/tests/darkside/utils.rs
91.66% <95.23%> (+5.00%)
:arrow_up:

... and 8 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CSP improvements

We now apply the rules to the whole app, so it applies even to new windows.
Since we apply it to the whole app, there's no way to trick our app into redirecting and then go around our CSP.
I also added some additional rules that are not covered by the default-src 'none'; rule.
Since it's dynamically injected now, we can make it even stricter and only allow the local port marketmaker is running on.
The rules are now also more readable.

Great idea generating it dynamically.
I also just realised, our CSP will block remote marketmaker nodes. Not worth blocking this for that as basically nobody apart from me uses that. And even if someone did use a remote node, they would likely tunnel it locally rather than actually access it over the internet so would probably still work. But just worth baring in mind.
We could dynamically add the custom marketmaker url if it's set to fix this, but really not worth the effort right now.

Oh, just realised you're now injecting headers rather than using the meta tag so maybe not so simple to change this.

Done


Introduce Rate-Limiter for template Operator

This PR introduces a rate limiter for the template operator. The rate limiter is based on both an overall (token bucket) and per-item (exponential) rate limiter.
Furthermore, an environment test was set up for the template operator, covering the basic use-case.

/retest

/hold

I have created this PR https://github.com/jeremyharisch/kyma-operator/pull/1
envtest have no controllers running so you have to set resources to ready manually or use a custom resource..

Great stuff, I however still have some questions:
Correct me if im wrong, but This test does not actually test for rate limiting, right? Also the busy box chart we should probably not hard code into our samples here but instead download it for tests on demand. Wdyt?

Yes, you are right - The implemented test only tests the happy path and does not consider the RateLimiting. I am currently thinking about a way how to properly test the RateLimiting in this envTest

The envTest for the RateLimiter is still missing. I will do a research how to test it properly, until then this PR is on hold

I have now spent some time to find a proper way of testing the workqueue.RateLimiter, and I have come to the conclusion that there is no reasonable way without too much overhead to test this functionality.
We are here relying on a basic builder option given by the sigs.k8s.io/controller-runtime/pkg/controller pkg and used internally by the controller. The used rate limiters are imported from the k8s.io/client-go/util/workqueue pkg. Both packages are well known and tested.
For a proper testing, in our test-suite, we would need to analyse the Queue from Controller - But since the Controller is a private field of the Builder and no read-functions are given, we do not have a proper access for analysing.
In addition, I have asked the kubebuilder-community how this is testable without any responses until now (asked one week ago).
All in all, I propose to not test this functionality in our suite due to the explained reasons.

/unhold


[New Project]: Add project Disney+ Hotstar Clone

Description
A Disney Plus Hotstar clone is a streaming website replica that mimics the design and functionality of the popular Disney Plus Hotstar platform. It features user-friendly navigation, streaming content categories, and a library of movies, series, and live TV options.
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

Kindly assign it to me @beRajeevKumar asap.


Added non-javascript dialogs for alert/confirm/prompt [#160839797]

@kswenson I made the changes you requested and then amended the commit and forced pushed.  Do you want to re-review?


Reflect 1.4.5 in the readme

This will avoid issues for new users who can miss the update text on the readme.

Thanks!


401 Invalid password -> 401 Invalid credentials

Fixed #85

merged via e9e3b0c, thanks @breun. I just squshed the two test: ... commits into one.
As a side node, one thing that helps us with reviews is if you push the test commits first, so that the CI kicks off and we see a failed build for the commit, that then gets green with the fix: or feat: commit, makes sense? No biggie really, just a learning I had myself recently :)

Ah, the instructions said to commit after the test change, but did not mention pushing the commit. I did commit, but only locally. Might be good to make that explicit for other first timers.
Also, the instructions did not mention forking the repository and cloning it from your own account before creating the pull request. That is necessary, right?

ah sorry, I forgot the "push" part, usually we add it. Thanks!
The instructions don’t mention the forking, but link to this tutorial here, which explains everything in detail:
https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github
Was that your first pull request?

Not really the first, but it's been a while.

it was right on, thanks :ok_hand:


[Fix] Fix inference_detector fail on non-cuda and non-cpu devices

Motivation
mmdet.apis.inference_detector will fail on non-cuda and non-cpu devices because of this https://github.com/open-mmlab/mmdetection/blob/e9cae2d0787cd5c2fc6165a6061f92fa09e48fb1/mmdet/apis/inference.py#L146-L153
torch.Tensor.is_cuda will return False when tensor is not on cuda device, so when this tensor is on other non-cuda devices, this code will not move tensor to the same device with the model weight and this will cause inference_detector crash.
Modification
use mmcv.device.scatter to move the input to device when model weight is not on cpu.
BC-breaking (Optional)
This change is unlikely to cause any issues, but I have tested it on both MLU device and CPU to be sure.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

ci seems on hold, did I miss something?


After postprocess in fairseq, how about bleu score?

Hi,
Thanks for these very helpful advices on reproducing WMT14 results. I followed all process for fairseq, but get confused when trying to get the final or "moderate" increased bleu score. After spliting the compound word, can you provide a process for scoring the translation? thanks.

Hi, calculate BLEU of translation should be the same. Note that you should split compound word on both reference and hypothesis before scoring BLEU, see [get_ende_bleu.sh](perl -ple 's{(\S)-(\S)}{$1 ##AT##-##AT## $2}g' < $tok_gold_targets > $tok_gold_targets.atat) for more details.

I have updated doc for sacrebleu usage


I want to contribute a random MEME generator

@ianshulx can you please assign this to  me and add hacktoberfest 2024 labels

@damarudhvarma Okay i've assigned you with Labels


Incorporating Balochistan workflow to master

Resolves https://github.com/epidemics/covid/issues/452

Allow overwriting region names in config.yml
Add Balochistan data to sites/balochistan/
Moves data to generated the main site to sites/main/
Made it possible to specify in config.yaml and estimates.csv when the model was updated/when the estimates were made.

NB: The sites/ directory would be how I would organize the different sites going forward.
Blocked by https://github.com/epidemics/epimodel/pull/49

Does someone know a better/cleaner way to take care of the custom names?

I believe this is superseded by switching to luigi. The way how this could be changed is by providing a different data-dir (or just it outputs directory) https://epidemicforecasting.slack.com/archives/CV93A58G7/p1590040992047800?thread_ts=1590019434.047600  . You can then have a config per site (or just provide the parameter on CLI)

I will do that

Cool. Any ETAs?

With this commit it has become impossible to reproduce the website builds using the hdf5 files in fixtures. The reason is the reworking of how the trace/group names work and how it expects the traces to be named in hdf5 and how it puts them in the exported json file.
The breakage for the normal site, renamed main here, is limited and I will make a issue about it. For balochistan it might be more severe and I have no idea how to approach it at this point.

And do we still need it?


doc: fix typos and broken DCO link

Corrected a few typos and a broken reference to the DCO in the contribution guidelines.

The spelling change has been reverted.


Update node dependencies

Codecov Report

Merging #6 (3b34775) into main (7376ddc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines            5         5
  Branches         1         1
=========================================
  Hits             5         5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7376ddc...3b34775. Read the comment docs.


Module not found: 'react-addons-shallow-compare'

Short description
I was trying to do
Install the plugin with npm.
Expected results
To successfully install.
Actual results
Instead of installing successfully, what I saw was that I got an error saying
Module not found: 'react-addons-shallow-compare'.

Reproduction steps

use<EMAIL_ADDRESS>npm install react-geosuggest --save
run your app
Finally the error will happen

it's not an error
it's warning related to peer dependencies

Before 2.0.1, if you encounter this error, you can fix it temporarily by using a webpack resolve alias:
resolve: {
  alias: {
    'react-addons-shallow-compare': 'react/lib/shallowCompare'
  }
}

Same error, and it's actually an error, not a warning. My application won't run with that. I'm using CRA.


InTheHand.Net.Bluetooth not working for Linux

Tested with Ubuntu 23.04. Exception in BluetoothClient.Connect.
"System.NullReferenceException" in InTheHand.Net.Bluetooth.dll aufgetreten.: 'Object reference not set to an instance of an object.'
bei InTheHand.Net.Sockets.BluetoothClient.Connect(BluetoothEndPoint remoteEP) in /home/default/32feet/InTheHand.Net.Bluetooth/Platforms/Linux/BluetoothClient.linux.cs: Zeile119
bei InTheHand.Net.Sockets.BluetoothClient.PlatformConnect(BluetoothAddress address, Guid service) in /home/default/32feet/InTheHand.Net.Bluetooth/Platforms/Linux/BluetoothClient.linux.cs: Zeile107
bei InTheHand.Net.Sockets.BluetoothClient.Connect(BluetoothAddress address, Guid service) in /home/default/32feet/InTheHand.Net.Bluetooth/BluetoothClient.cs: Zeile72
bei Program.Main(String[] args) in /home/default/32feet/Test/Program.cs: Zeile17
Testprogram:
BluetoothAddress.TryParse("............", out BluetoothAddress bluetoothAddress);
BluetoothClient client = new BluetoothClient();
client.Connect(bluetoothAddress, BluetoothService.SerialPort);

The problem is here in InTheHand.Net.Bluetooth/Platforms/Linux/BluetoothClient.linux.cs method PlatformInitialize.
Th line _socket = new Socket(AddressFamilyBluetooth, SocketType.Stream, BluetoothProtocolType.L2Cap); throws a System.Net.Sockets.SocketException with message "Address family not supported by protocol". And so the _socket is null. That causes the NullReferenceException in the Connect method.
I've used the branch linux at commit 10207ba from May 3 2023.
Any idea how to fix this?

Linux is not fully implemented yet so the code you see there is a work in progress.

Maybe it would help to solve the creation of the socket. So do you know why I can't create a socket for a bluetooth connection? So basically why it's not possible to create a new Socket(AddressFamilyBluetooth, SocketType.Stream, BluetoothProtocolType.L2Cap)? Why does this throw the Exception "Address family not supported by protocol"?

there's no solution for standard Bluetooth communications in C# under Linux :(

InTheHand.Net.Bluetooth 4.1 (released to NuGet today) supports both Windows and Linux when using the net6.0 or net7.0 target platforms. Not all functionality is implemented for Linux yet - you have to connect with a known channel rather than a service UUID but I'm working on adding discovery and SDP features to bring it to parity with Windows.

Hi @peterfoot
I got this exception :
Address Family: Unknown
Address Byte: 31
Size: 10
Unhandled exception. System.Net.Sockets.SocketException (22): Invalid argument
   at InTheHand.Net.Sockets.LinuxSocket.ThrowOnSocketError(Int32 result, Boolean throwOnDisconnected)
   at InTheHand.Net.Sockets.LinuxSocket.Connect(EndPoint remoteEP)
   at InTheHand.Net.Sockets.LinuxBluetoothClient.Connect(BluetoothEndPoint remoteEP)
   at InTheHand.Net.Sockets.LinuxBluetoothClient.Connect(BluetoothAddress address, Guid service)
   at QuickBTTest.Program.Main(String[] args) in D:\DevProjects\Prevo100CSharp\QuickBTTest\Program.cs:line 52
Abandon (core dumped)

Currently on Linux you need to use Connect(EndPoint) so that you can specify the channel id because there is no SDP lookup yet.

you can specify the channel id

Can you give me an example ?
I still have an exception if I use BluetoothEndPoint.

This is what I've been using to connect to a printer. The service uuid is ignored because it specifies channel 1:-
client.Connect(new BluetoothEndPoint(device.DeviceAddress, BluetoothService.SerialPort, 1));
if (client.Connected)
{
    var stream = client.GetStream();
    StreamWriter writer = new StreamWriter(stream);
    writer.WriteLine("Hello printer");
    writer.Flush();
    writer.Close();
    client.Close();
}

@peterfoot It looks like LinuxBluetoothListener never sets it's Active property in the Start method, causing listeners on linux to throw Not listening. You must call the Start() method before calling this method.

Peter, got it working superbly on Windows.
Would like cross-platform to Linux too, but I'm also getting the above error:
Address Family: Unknown
Address Byte: 31
Size: 10
Currently using 4.1.43, tried to upgrade to 4.1.44 but got downgrade error:
"Severity Code Description Project File Line Suppression State Details Error (active) NU1605 Warning As Error: Detected package downgrade: InTheHand.Net.Bluetooth from 4.1.44 to 4.1.43. Reference the package directly from the project to select a different version. GKDxRCI_Service.Android -> GKDxRCI_Service -> ServiceComms -> InTheHand.Net.Bluetooth (>= 4.1.44) GKDxRCI_Service.Android -> InTheHand.Net.Bluetooth (>= 4.1.43) GKDxRCI_Service.Android C:\GKDTEC\xRCI\GKDxRCI NET8\GKDxRCI_Service.Android\GKDxRCI_Service.Android.csproj 1"
Two questions:
Does the latest version include full Linux support?
Why am I getting downgrade error in my Android project?


Signal Handling and server Shutdown

We need to implement catching terminate signals and do our own server exit so it would not block ports

Completed in PR #39


Vertical Knob support

Hi
Thanks for the library. I am asked to display an audio knob which (according to our Audio guys) suppose to let users change the value by moving the mouse vertically.
What they want is when a user moves the mouse vertically he will be able to change the value from 0 100% and vice versa. Today I see it allows to change the value only half way when moving vertically.
Is there a way to add this functionality? I don't mind making a pull request just point me in the right direction...
Thanks!

??

@neomib Hey. Sorry for the wait. Can you describe in more detail what you need. Or attach a screenshot

Sometimes it goes all the way till 100% but not as smoothly as I expect it..thanks

no, this feature is not implemented for now


Confirm documentation for "incorporating into prior project"

This is feedback received from a user updating a pre-existing project with the PPT:

The directory layout described in "Incorporating the template into a
prior project" is different than that described in "Starting a new
project" ... And I think the latter is the correct expected one?

A cursory glance at the docs looked correct, but perhaps I missed some subtleties.

Thanks for starting the issue!
The difference is between this statement in "Incorporating ...":
For example, if your project is in a directory named /science, your source code and tests might look like this:

 /science/src/module.py
 /science/tests/test_module.py

and this in "Starting a new project ..."
If this option is selected the template will create an example module src/{{package_name}}/example_module.py and test file tests/{{package_name}}/test_example_module.py. Defaults to True during simple installation.

They differ in that the "package_name" is in the directory level below "src" for the latter but not the former.

The documentation was updated to properly reflect the directory structures that we're looking for.
https://lincc-ppt.readthedocs.io/en/latest/source/existing_project.html#a-note-on-directory-structure


Move cloud-stream-kafka/rabbit samples to Spring AOT smoke tests

This proposal removes all cloud-stream-[kafka|rabbit] samples and leaves behind a README.md pointing to their new home.

I think the target is different (Spring Boot 2.x versus 3.x) so for now I think I would prefer to keep the samples on Spring Native side. Once Spring Boot 3 GA is released, I think we will do some global updates to Spring Native and its samples to redirect to Spring Boot 3, Spring AOT smoke tests and related  documentation. As a consequence, I don't merge this PR. Feel free to let me know if that does not make sense from your POV.

Sorry I miss it was on sb-3.0.x branch.


send an immediate event on client watch connect to force grpc headers through

prevents ConnectionTimeoutInterceptor from timing out when an envelope isn't executed within the timeout window
can only send this event when the client supports it (to avoid the watch dying due to 'unknown event type'), so I had to add some stuff in to send the p8e-sdk version as a GRPC header (could have sent an ENVELOPE_ACCEPTED event, but this seemed better)

Codecov Report

Merging #100 (66b3ed2) into main (d039c9e) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #100      +/-   ##
============================================
- Coverage     12.07%   12.00%   -0.07%
  Complexity       37       37
============================================
  Files            65       65
  Lines          3446     3465      +19
  Branches        364      367       +3
============================================
  Hits            416      416
- Misses         2970     2989      +19
  Partials         60       60

Impacted Files
Coverage Δ

...e/engine/grpc/interceptors/JwtServerInterceptor.kt
0.00% <0.00%> (ø)

...nce/engine/grpc/observers/EnvelopeEventObserver.kt
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d039c9e...66b3ed2. Read the comment docs.


Geofence Sync Rule names should follow naming conventions

In developing naming conventions for the GeoEvent server we decided that all components for a GeoEvent template should be in the format templatename-component name.
Several of the Geofence Sync rules do not follow this format. The most notable are the services that use 7,8,9 as their names.
We need to correct all the sync rules to use the proper naming convention.

@pHill5136 my impression is that this has been resolved. I am closing.


gpu resource manager operator parts

This adds the operator support for the GPU fractional resource management. As long as the fractional resource management is missing from gpu-plugin, this PR is useless. Don't merge yet.
Signed-off-by: Ukri Niemimuukko<EMAIL_ADDRESS>

Codecov Report

Merging #640 (1148ecd) into main (a207bfe) will decrease coverage by 0.13%.
The diff coverage is n/a.

:exclamation: Current head 1148ecd differs from pull request most recent head 0e6a508. Consider uploading reports for the commit 0e6a508 to get more accurate results

@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   57.75%   57.61%   -0.14%
==========================================
  Files          31       31
  Lines        2192     2192
==========================================
- Hits         1266     1263       -3
- Misses        853      855       +2
- Partials       73       74       +1

Impacted Files
Coverage Δ

pkg/deviceplugin/server.go
84.17% <0.00%> (-2.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a207bfe...0e6a508. Read the comment docs.


fix(dependabot): udpate dependabot configuration

Thank you for contributing to kube!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Check list:

[ ] Mark if documentation changes are required.
[ ] Mark if tests were added or updated to cover the changes.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.60%. Comparing base (e7e07dd) to head (4688313).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   57.60%   57.60%
=======================================
  Files          14       14
  Lines         743      743
=======================================
  Hits          428      428
  Misses        233      233
  Partials       82       82

Flag
Coverage Δ

unittests
57.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add option when solving problem to optimize with default metric

In the past, it was possible to call a OneshotPlanner() with parameter optimality_guarantee=OptimalityGuarantee.SOLVED_OPTIMALLY without providing any metric. This has been changed in UP. For most basic sequential planning problems without action costs, however, it seems rather clear what metric to use. This pull request adds the option to use the MinimizeSequentialPlanLength metric by default.

Dear @franklinselva, does this change work for you or does it interfere with temporal planning?
@sebastianstock, for your information.

@alexander-sung Currently, Bridge().solve() expects sequential plans by default. I think using the function to solve temporal planning might crash.
Also, we may need to revise the solve() function since dependency graphs can be now used as default way for execution.

On my side, the changes work well with temporal planning.

Yes, I'm referring to your second point. The function name solve() is very unspecific, so you might want to use this interface for more than sequential plans, I thought. We can discuss this further in our next meeting.


Language Cannot Be Set to null in docs but that's an error?

Version
"spatie/geocoder": "^3.1",
Bug?
C:\laragon\webroots\XXX>php artisan ide-helper:meta

In Geocoder.php line 39:

  Type error: Argument 1 passed to Spatie\Geocoder\Geocoder::setLanguage() must be of the type string, null given, called in C:\laragon\webroots\one-calendar\calendar\vendor\spatie\geocoder\src\GeocoderServiceProvider.php on line 24

Why is it a bug?
Because the documentation says that it could be null (see https://github.com/spatie/geocoder/blob/master/README.md).
It is not null when published - this is a README.md thing.

This should now just work.


⚠ Bofrost.es has degraded performance

In cb092be, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1437 ms

Resolved: Bofrost.es performance has improved in f3e0905 after 9 minutes.


feat: deleteItem() and deleteComment()

Towards #293
CC @huai-jie

Ah, so currently it is used for deleting the dummy data.
Anyway, do you think allowing users to delete the items and comments they have created can be a valuable feature in this case?


Fix workspace crates tests not being run

Fixes https://github.com/rust-lang/docs.rs/issues/2391

@Nemo157 This PR fixes the tests of the metadata and font-awesome-as-a-crate, it build them on CI and adds them to the CI cache.
I saw that the CI jobs were run on my fork as well so as bonus I also restricted CI to only run on the master branch (when pushing)

Apart from that I'm actually not sure about the caching feature in general any more (which I added, so that's on me). It definitely improves CI times, but also it lead to us silently not running a part of the tests. And relying on test binary naming feels volatile at the least

Yeah, relying on test binary names is not great. I tried using cargo --message-format but this felt overkill.

we could try to just use Swatinem/rust-cache in all jobs, and not share any binaries between the jobs. What do you think?

Yes, that would be great. I can try to do it, but won't have time to do it until a few days.
Maybe we can merge this PR in the mean time and follow-up with this bigger refactor.

Apart from that I'm actually not sure about the caching feature in general any more (which I added, so that's on me). It definitely improves CI times, but also it lead to us silently not running a part of the tests. And relying on test binary naming feels volatile at the least

Yeah, relying on test binary names is not great. I tried using cargo --message-format but this felt overkill.

we could try to just use Swatinem/rust-cache in all jobs, and not share any binaries between the jobs. What do you think?

Yes, that would be great. I can try to do it, but won't have time to do it until a few days. Maybe we can merge this PR in the mean time and follow-up with this bigger refactor.

This was broken for a long time, so having it broken for a little longer is not a big issue IMO.
So IMO we should directly do the refactor (or rather, simplification, refactor sounds so huge 😄  ).

last week I also started doing this (dropping the binary caching), though I didn't dig through the remaining test failures yet:

https://github.com/rust-lang/docs.rs/compare/master...syphar:docs.rs:fix-test
https://github.com/syphar/docs.rs/actions/workflows/ci.yml?query=branch%3Afix-test

I've updated the PR to remove the custom CI binary caching. I've consolidated the "build" and "build_test" jobs into a single "test" job. I also contains some tests fixes, but I did not fixed the ignored test since none are worth it, they mainly serve as copy/paste examples.
Let me if would like anything else.
@rustbot label -S-waiting-on-author +S-waiting-on-review

#[ignored] is really used as a way to categorize long-duration build-tests that we don't want to run locally normally, but they should be run in CI.

#[ignored] is really used as a way to categorize long-duration build-tests that we don't want to run locally normally, but they should be run in CI.

Oops, forgot this. Fixed.

@Nemo157 @syphar What do you think about the latest changes? Can we move forward?


[QUESTION] How do I build on Mac OS without building dependencies?

I am trying to build the SDK and example on MacOS 10.15.7 without building the dependencies, but have run into issues.
I have run the following:
brew install pkg-config openssl cmake gstreamer gst-plugins-base gst-plugins-good gst-plugins-bad gst-plugins-ugly log4cplus gst-libav

cmake .. -DBUILD_GSTREAMER_PLUGIN=ON -DBUILD_DEPENDENCIES=OFF

^ this cmake fails with the following error:
...
-- Found PkgConfig: /usr/local/bin/pkg-config (found version "0.29.2")
-- Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the system variable OPENSSL_ROOT_DIR (missing: OPENSSL_INCLUDE_DIR)
CMake Error at dependency/libkvscproducer/kvscproducer-src/CMakeLists.txt:118 (message):
  OpenSSL is not found.  Make sure to export PKG_CONFIG_PATH to where
  OpenSSL's pc file is

-- Configuring incomplete, errors occurred!
See also "/Users/mrl/workspaces/amazon-kinesis-video-streams-producer-sdk-cpp/build/CMakeFiles/CMakeOutput.log".

So I ran the following command which I found in the console output when brew installed openssl (note that I am using the fish shell):
set -gx PKG_CONFIG_PATH<EMAIL_ADDRESS>
I was then able to successfully re-run cmake. I think that the documentation or cmake configuration could use some enhancement to help avoid this issue.
When I then ran make, I got the following error and I am not sure how to get around it:
...
[ 79%] Linking C shared library libcproducer.dylib
ld: cannot link directly with dylib/framework, your binary is not an allowed client of /usr/lib/libcrypto.dylib for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [dependency/libkvscproducer/kvscproducer-src/libcproducer.dylib] Error 1
make[1]: *** [dependency/libkvscproducer/kvscproducer-src/CMakeFiles/cproducer.dir/all] Error 2
make: *** [all] Error 2

How can I resolve this issue? And what can be done to prevent others from running into this in the future?

This might help:  https://developer.apple.com/forums/thread/124782
It seems Apple added his recently and they intend for libraries like libcrypto.dylib that they've built to be used by them only.  With 10.15 and greater that library is no longer a symlink like it used to be rather some sort of stub/wrapper library.  To solve your problem it looks like you will not be able to just use the system libcrypto rather you'll need to brew install openssl and then make sure to add that to link to the newly installed openssl.  Make sure to wipe out your old cmake cache and start with a fresh cmake run after you've installed openssl.

This might help:  https://developer.apple.com/forums/thread/124782
It seems Apple added his recently and they intend for libraries like libcrypto.dylib that they've built to be used by them only.  With 10.15 and greater that library is no longer a symlink like it used to be rather some sort of stub/wrapper library.  To solve your problem it looks like you will not be able to just use the system libcrypto rather you'll need to brew install openssl and then make sure to add that to link to the newly installed openssl.  Make sure to wipe out your old cmake cache and start with a fresh cmake run after you've installed openssl.

Resolving.

Resolving.


Make 'clone' true by default

As per previous conversations, make 'clone' true by default. As this is a breaking change, this will be blocked until 2.0

there is a significant performance penalty incurred when using the clone option on a collection.
As a quick test I get around 775k ops/s without clone option and around 155k ops/s with clone option turned on.  that is for indexed finds.  unindexed find was only marginally slower 25k->22k.

@obeliskos Yes, but iirc we all agreed (in one of the issues I opened a few weeks ago) turning it on by default as this is the "usual" expected behavior from users. Also, this won't remove in any way the functionality/performance with clone: false, so people seeking performance over stability/expected behavior could still easily get it.

i'm sure i never suggested making an 80% hit the 'default'...  what is your reasoning for wanting it to be the default? Generally loki prioritizes performance over protecting you from yourself.
I have no context for this, was this email or github convo?

Hmmm, maybe I'm brainfarting and I only spoke with @techfort? I'm sure this
was here in github. Let me search for the issue.
El El mar, 15 mar 2016 a las 22:54, obeliskos<EMAIL_ADDRESS>escribió:

i'm sure i never suggested making an 80% hit the 'default'... what is your
reasoning for wanting it to be the default? Generally loki prioritizes
performance over protecting you from yourself.
I have no context for this, was this email or github convo?
—
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
https://github.com/techfort/LokiJS/issues/379#issuecomment-197042375

'clone' option used to just clone on inserts, i expanded this to clone when you get data out as well... this adds big performance hit but i think this is what one would expect from a clone option.

I knew it was here somewhere! https://github.com/techfort/LokiJS/issues/347
My final point in that issue was: Loki is, mainly, a database, not an in-memory-cache (like Redis). The normal/expected behavior of a database is to insert/fetch your data without doing funny things (modifications, in this case) if you're not explicitly doing it (calling update/delete). That's why I suggested to set clone to true by default.
There is indeed a major performance hit caused by this, but this is how it should work, or at least this is what users expect. And a prove of that are all the issues related to clone: https://github.com/techfort/LokiJS/issues?utf8=✓&q=is%3Aissue+clone
Also, after going through all of those issues I realized that the defacto-answer (like a template) is always "Do you have clone turned on?", which is a clear indicative that people expect this behavior, instead of having to switch it on.

Hmm, well as i said this feature 'used' to only affect 'insert' perf, but has since been expanded to getting data out so there is large perf hit when getting out that @techfort may not have been aware of.  He can weigh in.
Perhaps we can add another loki method like addClonedCollection or addReferenceCollection to simplify 'defaulting'?
Up to now loki has been dependency free making it easy to just drop in and run.  Having said that we do support a cloneMethod of 'jquery-extend-deep' so if lodash is more performant we could add soft-dependency similarly but that would not make for a good 'default'.   How does lodash handle date objects?  Using our current 'parse-stringify' clone method dates are flattened to a string (as they are when saving and reloading).

I don't think adding more methods to the API would be a solution as that would still require users to compare and understand the difference between addCollection and a theoretical addClonedCollection, which is pretty much the same as just leaving it as addCollection({clone: true/false}).
@VladimirTechMan had some negative thoughts about changing anything in Loki that might affect (negatively) the performance, so maybe I'm trying to defend a wrong idea in the first place, but I really do believe this is how a database should behave.
About the lodash deepClone:
x = _.clone({d: (new Date())})
Object {d: Wed Mar 16 2016 03:16:51 GMT+0100 (CET)}
typeof(x.d)
"object"

it looks like it's cloning objects as-is. I'm wondering if ES6/7 could offer some help here... will research that.

Oh... :-( It sounds as if I'm getting a reputation of person obsessed with only performance, over any kind of safety. While I am definitely focused very much on the perf topic for my on-going project with Loki inside (well, again, dealing with up to 40-50K records, all in a browser app, not that surprising – I hope!). But I am not exactly a type of character ready to sacrifice any kind of safety / robustness measure over the performance. My stance is much more like: give the developers a choice between "less performance for more safety out of the box" vs "more performance for less safety out of the box".
From that perspective, the "clone" options itself is exactly that choice. Thus, no concerns for my app – I can easily set clone: false in my code. The real question is, between the two major choices (even "mindsets") from the previous paragraph, what do we want to make a default. @techfort as the author has his major vote on it. And @obeliskos as the key long-time contributor is also a key decision maker here, from my perspective.
Having said that, one thing that I was considering myself as a possible "third way" approach here. Are you aware of the Immutable.js (originating from Facebook)? That one is quite a reasonable approach to dealing with immutable objects in JS (trying to minimize performance overheads -- by doing some smarter things than what a typical "plain" cloning does in many cases). The library is not without some "caveats attached" – in particular, mixing objects built with Immutable.js and plain JS objects in one collection would be a call for troubles. And Loki will not handle the objects constructed with Immutable.js "out of the box" right now. But we might consider that approach, as I expect that it can be lighter (compared to plain cloning) while giving the immutability benefits / guarantees where that is desirable. [As a side note, it would also make Loki much more applicable to the Redux-based app design, if you're familiar with the concept / library.) Anyway, those are my two cents to your discussion above.

To clarify: I meant to say, "we might consider the approach with supporting both the plain JS objects in Loki, with or without cloning them – as it has been implemented, though maybe with some tweaks – and the collections with the records constructed using Immutable.js".

give the developers a choice between "less performance for more safety, out of the box" vs "more performance for less safety, out of the box".

I couldn't have expressed that better. The entire issue here is to decide whether to offer safety or performance out of the box. In any case, an improvement of the docs is required. I'm thinking about big red blinking text :smile: explaining what happens when clone: true and what happens when clone: false. Currently the docs don't say too much about that, thus so many users making the error of running their databases without clone: true and ending up with screwed documents.
As for Immutable.js, I heard a few things about it, but never got the time to read the docs/code. Will research that too.

hey @alexandernst @VladimirTechMan @obeliskos - regarding this: I think LokiJS always had a particular identity, with its unique combination of speed / simplicity / minimalism (among which I include the fact that it's dependency-free).
Offering a solution that is not faster than other solutions of the same type, not as easily integrated and easy to pick up puts the whole project's existence into question.
That is why the first iteration of LokiJS did not even have a clone option: I was basically giving everybody a solution that was screaming fast, although it was up to the developer to the brakes in place, LokiJS only had the accelerator pedal.
Now the product has matured, expanded and improved, especially because of the contributions you made, so it makes perfect sense to think of LokiJS as a fully-fledged F1 car instead of a dragster with no brakes.
In my view, as of 2.0, we should investigate and benchmark the performance of safety options, and provide "profiles" (e.g. full-speed, with-brakes, slow-and-steady-wins-the-race...). Developers will always have the freedom to customise and tweak every single configuration option, but if we guide them towards 2-3 major "approved" approaches they might be less likely to either misunderstand the db behaviour or slow it down unnecessarily.
Just an idea.
As for the current cloning mechanism, we should definitely go the DI route. If a developer knows what they are doing then they'll choose a cloning mechanism that is both satisfactory functionality-wise and performs well (I could have said "performant" but i have a crusade against this word, it can be used to describe a priest telling mass "he's the performant of the ritual", not a fast database). So basically, either use our own clone function if none is injected or whatever is injected.

:+1: @techfort, I agree with your stance on LokiJS, please continue to give developers control over performance and use documentation and demo/example code to point developers toward the major 'approved' approaches.
I work on an enterprise app which uses LokiJS and our architecture is designed around LokiJS being configurable as an in-mem store that doesn't copy or modify any references.

Hey @all, sorry for not REing early, kind of a busy week...
Ok then, let's keep clone: false by default, but let's make it clear what
exactly that means.
I also like the idea of profiles. This is pretty much how the Windows
installer of MySQL/MariaDB work (they ask you how many connections you have
and how much data, and then they optimize the DDBB).

Hi @all, we just started with loki and had the same struggle as @alexandernst mentioned. I also agree that the performance boost is the better option, but please add a note in the docu.


chore: update dependencies

Reason for Change:

Updates some deps to resolve findings from CVE scanners
Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] relevant PR labels added

Notes:

/azp run Azure Container Networking PR


Claim Validity: Expulsion

Description
As a user, I want to know if I can be expelled or expel my tenant
Scope of Work

[ ] Determine cases that may result in expulsion of tenant
[ ] Determine specific facts that influence the possibility of expulsion
[ ] Ensure said facts are collected if an expulsion scenario is detected
[ ] Train model to determine whether expulsion is permitted/possible given set of facts

Story Points

[1, 2, 3, 5, 8, 13, 20, 40]

Priority

[Low, Medium, High]

Risk

Medium

Demo requirement

The user provides begins a conversation with the system
The system determines the claim category and promps for facts
The user builds their case by submitting information about their claim involving expulsion
The sytem determines, given the user's facts, whether or not they may evict their tenant (as a landlord), or be evicted given their actions (as a tenant)

Acceptance Criteria

The system is able to ask for relevant information to determine the possibility of expulsion
The system is able to adequately parse user responses to extract information into facts
The system is able to determine whether a tenant can be expelled from their dwelling

Documentation, files, diagrams, etc. relating to this feature:
Url, books, etc.
Changes:

[Optional]

Need to know more about inputs required to complete this story.


Error installing PIL on raspberry pi

pip install PIL

Downloading/unpacking PIL
Could not find any downloads that satisfy the requirement PIL
Some externally hosted files were ignored (use --allow-external PIL to allow).
Cleaning up...
No distributions at all found for PIL
Storing debug log for failure in /root/.pip/pip.log

pip uninstall PIL
Can't uninstall 'PIL'. No files were found to uninstall.

I got this error but it has been resolved in the following link
http://stackoverflow.com/questions/21242107/pip-install-pil-dont-install-into-virtualenv
fix:
pip install PIL --allow-external

Well, there is a suggestion to use --allow-external switch, in the console output, you could do that, and if it would fail, you would follow another suggestion, that would surely say something along the lines of "use --allow-unverified to install this package". I'm really surprised that that question doesn't have like -100 votes up on StackOverflow, but I guess it's the world we live in, where dumb questions, solved by just reading the screen are upvoted, and actual questions, that are not as easily solved are downvoted...
By the way, close this issue, if it's solved.


[GLUTEN-3297][CH] Refactor filter push down framework in gluten, support orc FPD and reuse parquet FPD in CH.

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #3297)

LGTM


label information to be expanded on holders

The name attribute at the holder class shall also contain an instance documenting the external label (respectively content of the documentation in case there would be no label).
holder::name:
value-name: "externalLabel"
value: "Identifier of the holder according to the currently valid documentation of the equipment."

Potential Proposal:
In contrary to former considerations, there shall be no additional instance in the Holder::name list-attribute, but an explicit externalLabel attribute.
The following changes shall be made to the EquipmentAugment modelling:

A HolderSpec class shall be added.
An abstraction of type Specify shall be added and connect the new HolderSpec class with the existing Holder class and contain the target "/CoreModel:ControlConstruct:ControlConstruct/CoreModel:Equipment:Equipment/CoreModel:ContainedHolder:Holder".
A Holder_Pac class shall be added.
A composite association [1/1] shall connect from HolderSpec to Holder_Pac.
A Holder_Pac :: externalLabel[1] : String = "External label not yet defined." attribute with comment "Identifier of the holder according to the currently valid documentation of the equipment." shall be added.

Has been updated and published in EquipmentAugment_1.0.0-tsi.240104.1330+yang.1


Started porting to hapi 17

Thanks for your work @sibartlett 😄
When do you plan to release a version compatible with Hapi 17?


del

del

You know Github stores history, right? Editing to hide stuff just brings it back to light. See Streisand effect


Couldn't instantiate the backend tokenizer

Error occurred when executing Prompt Generator:
Couldn't instantiate the backend tokenizer from one of:
(1) a tokenizers library serialization file,
(2) a slow tokenizer instance to convert or
(3) an equivalent slow tokenizer class to instantiate and convert.
You need to have sentencepiece installed to convert a slow tokenizer to a fast one.
File "F:\ComfyUI\execution.py", line 152, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "F:\ComfyUI\execution.py", line 82, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "F:\ComfyUI\custom_nodes\ComfyUI-0246\utils.py", line 381, in new_func

Hello, thanks for reporting. I have added new updates. Please update the node and let me know if the issue is going on.