go-finance v2

Total rewrite that aims to simplify naming conventions and model serialization while improving testability. Only truly breaking change is in the options section of the lib, see README for new syntax.

Codecov Report

Merging #5 into master will increase coverage by 29.31%.
The diff coverage is 93.11%.

@@             Coverage Diff             @@
##           master       #5       +/-   ##
===========================================
+ Coverage   62.53%   91.85%   +29.31%
===========================================
  Files          13       10        -3
  Lines         347      270       -77
===========================================
+ Hits          217      248       +31
+ Misses        120       11      -109
- Partials       10       11        +1

Impacted Files
Coverage Δ

utils.go
100% <100%> (+5.12%)
:white_check_mark:

symbols.go
75% <100%> (+16.66%)
:white_check_mark:

options.go
90% <100%> (+70.7%)
:white_check_mark:

quotes.go
100% <100%> (+74.07%)
:white_check_mark:

fetch.go
84.21% <84.21%> (ø)

pairs.go
81.81% <85.71%> (+42.92%)
:white_check_mark:

datetime.go
90.47% <90.47%> (ø)

option.go
93.33% <91.3%> (+14.16%)
:white_check_mark:

fields.go
93.33% <93.33%> (ø)

history.go
91.83% <94.73%> (+63.57%)
:white_check_mark:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b13adef...7d13b6f. Read the comment docs.


Model overfitted or mapping challenge dataset not diverse? Poor performance with custom images

Excellent results can be achieved using the Developers' fully-trained model (found here: https://app.neptune.ml/neptune-ml/Mapping-Challenge/files) to predict on the test_images set provided as part of the mapping challenge. However, over the past few days I have experimented with custom data from Bing imagery and Hexagon and have gotten very poor results. Here are some examples:

(a few were good)

Where cyan circles denote mask centroids. I have experimented with several factors, such as:

image source (bing vs hexagon)
image quality (high vs low areas)
zoom level (pixels per meter given fixed 300x300 image size)
quality level due to conversion from png to jpg
overlapping tiles and keeping only masks found in both

And I've treated my custom data exactly as I treated test data. I used the same pipeline and settings for both. I'm sort of forced to conclude that either the model has overfitted to the "type" of data given by the open challenge, or said given data is not a diverse selection of image sources.
Has anyone else found good results with custom imagery? If so, what was the source?

@carbonox-infernox good job analyzing the results on external data.
I do think that the dataset provided by the organizers was not very diverse and was provided more as a proof of concept than anything else.
So in short, I think the model just learned what it was fed. A simple building dataset.
That being said I think (talked about it with other participants), that you can finetune the model we have for just a few epochs on a new dataset successfully.
I'd suggest you try that.

Hi @51616 Just download the model and place it in your experiment directory. In neptune.yaml you have to specify experiment_dir. Inside this directory you should create a models directory and place your unet file there. While inferencing the code will look for a file with model weights in that directory. Hope it helps.
ps.2. It's prepared for more than one class, so the first channel refers to "background" class, and the other refers to "building" class. (I hope I remember this correctly)

Can you guide us through how to train my own datasets? Along with preparing training data and code examples would make this very clear. :),how to generate the file of metadata.csv?


Fixing async function instance intialization issue

When doing a type conversion for async function we were passing the wrong
type handler.

@akroshg @tcare @pleath Can you please take a look?

:shipit:

Looks good


Add Java Default Certificat Authorities into the keystore if using a custom cert SSL

change defaultJavaKeyStoreFile always to the correct path. paths are changed since any version of java.
e.g. /usr/lib/jvm/zulu-8-amd64/jre/lib/security/cacerts
Old pull request #1555

@svenvogel you need to change the target branch. Currently, you opened this PR against master. If you wnt to propose this to 4.10 you can open a PR against 4.10 branch.

@rafaelweingartner changed to 4.10

@svenvogel now the problem is that you are bringing a lot of changes from master to 4.10.
Can you rebase only your commits on top of 4.10?


Cannot read property 'viewContainer' of undefined in CdkTree Angular 9 RC3

Since upgrading to Angular 9 RC3, I'm seeing the following exception when creating a CDK Tree:
core.js:6068 ERROR TypeError: Cannot read property 'viewContainer' of undefined
    at CdkTree.renderNodeChanges (tree.js:730)
    at SafeSubscriber._next (tree.js:716)
    at SafeSubscriber.__tryOrUnsub (Subscriber.js:183)
    at SafeSubscriber.next (Subscriber.js:122)
    at Subscriber._next (Subscriber.js:72)
    at Subscriber.next (Subscriber.js:49)
    at TakeUntilSubscriber._next (Subscriber.js:72)
    at TakeUntilSubscriber.next (Subscriber.js:49)
    at Observable._subscribe (subscribeToArray.js:3)
    at Observable._trySubscribe (Observable.js:42)

This is caused by the _nodeOutlet property on the CdkTree being undefined.
Environment

Angular: 9 RC 3
CDK/Material: 9 RC 4
Browser(s): Chrome 78
Operating System (e.g. Windows, macOS, Ubuntu): Windows

@crisbeto could you take a look?

Nothing stands out that could be causing the issue. Also the tree hasn't been touched in a while so it's unlikely that we've introduced this recently. @jinder are you running with Ivy and is it possible to isolate this into a Stackblitz?

I've spent half a day or so trying to isolate the problem to reproduce on a small project, and I can't.  I've cleared my yarn cache, done a fresh install, and then gradually stripped away all the code in our component.  The error occurs when I set the dataSource, regardless of what's in it.  For whatever reason, the ViewChild cdkTreeNodeOutlet isn't being found, even though cdkTreeNodeOutlet is defined in my template.
When I do this on a fresh project, there's no issue - but I'm not sure what set of code/dependencies would cause the Ivy ViewChild behaviour to change for our specific project.  I think I'll wait for the next RC and see how that behaves.

I believe this may have been caused by the ng upgrade process or something to do with the Ivy postinstall.  I've now blasted everything, and re-upgraded from Angular 8 which appears to have fixed the issue.


Add find by number

Add method containsNumbers method in StringUtil to check for Phone containing given numbers argument
Add check for Phone containing keywords argument in test method of NameContainsKeywordsPredicate
Modify and add more test cases in NameContainsKeywordsPredicateTest to include Phone

Codecov Report

Merging #53 (03f20db) into master (aba5f3c) will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master      #53      +/-   ##
============================================
+ Coverage     72.10%   72.13%   +0.03%
- Complexity      399      402       +3
============================================
  Files            70       70
  Lines          1233     1238       +5
  Branches        125      127       +2
============================================
+ Hits            889      893       +4
  Misses          312      312
- Partials         32       33       +1

Impacted Files
Coverage Δ

...in/java/seedu/address/commons/util/StringUtil.java
91.30% <75.00%> (-3.44%)
:arrow_down:

...ss/model/person/NameContainsKeywordsPredicate.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feat(compass): add new fields in asset model

Added new fields on Asset to accomodate the new model from Meteor

url: string

attributes: map[string]interface{}

@ravisuhag
Meteor Asset model now has

Data Table | Dashboard | Job
Labels map<string,string>
Attributes map of any

While Compass in this PR will have

Data map of any
Labels map<string,string>
Attributes map of any

There could be a redundancy on Compass model if we add Attributes since it behaves the same as Data.
But without it, there could be conflicts if we merge Meteor Data and Attributes before mapping it to Compass' Data.
Do you think we should add this new Attributes field in Compass?

Attributes are mostly related to model metadata. So, they are better suited in Table|Topic|Dashboard. Asset on the other hand can still continue to maintain labels.

Closed in reference to a new PR. #174


TeslaMate encryption of API tokens

Adds support for AES_256_GCM encrypted API tokens implemented by PR https://github.com/adriankumpf/teslamate/pull/2360 in TeslaMate.

@tobiasehlert What is left before this can be merged?

@tobiasehlert What is left before this can be merged?

@noocyte, the problem is that the decryption doesn't work and I was kind of stuck.
@LelandSindt seems to have solved the decryption.. trying his code in 51306bf to see if it works :)

Could you please mention in your new Release notes, that you have to add the encryption key to your service section as well?

@pkuehnel I did mention that in the beginning and updated the readme with the ENCRYPTION_KEY parameter.
But I can make it more clear :)


_lub & _lud Issue

I'm currently having an issue with _lud and _lub.  In addition to not capturing the data of when/who last updated a record in a grid, I see that both fields are available for inline edits when they shouldn't be if this keyword is working correctly.
These seemed to work before and I'm wondering if there's anything that would cause these fields to stop working as expected. The grid and both fields are set to allow inline editing. Changing the KTL version didn't seem to make a difference either.

It seems like the issue is related to the _ttip that was added to the field after the _lub. For now, I've just removed the _ttip and everything is now working as expected.

Intersting, thanks for reporting.  I'll investigate...
Norm

Fixed!  Try dev mode.
Will be part of next release.
Norm


Higher-order effects and bidirectional effects

Right now we can specify interfaces as follows:
interface Proc {
  def fork { f: () => Unit }: Unit
}

we can implement them with new. However, computation is not allowed as arguments when using the try construct.
It is somewhat obvious that this can be combined with bidirectional effects, to establish a sound semantics. So, we should just implement it as:
try {
  ...
} with Proc {
  def fork() = resume { {f} => ... f()... }
}

(this is dual to #152)

Q: Are there any interesting examples we could implement with this?

A first step towards this issue would be to add block parameters to operation declarations and only support them on objects (fail on handlers). Then, in a second step, we can also support handlers.

For people interested in working on this issue, there is a branch containing first steps at https://github.com/effekt-lang/effekt/tree/higher-order-effects

Should hopefully be fixed by #361

Fixed by #361.


Added UseMvcWithDefaultRoute extension to BuilderExtensions

Added UseMvcWithDefaultRoute extension method to BuilderExtensions,
which adds Mvc to the request pipeline with a default route to the
Index action on the HomeController.
#1885

53f3a91f01c740f3cbf5209a9eeeefd614a6cbc2


Stopped and Not Listening

I've been using RDPWrap for some time now. Then some Windows updates stopped working.
OS: windows 10 Pro (x64)
Version: 1709
Build: 16299.371
termsrv.dll - Version 10.0.16299.15
after installing:

install:

before installing:

I checked all the services and they are running. Disabling anti-virus nevertheless continues with the same situation.
It did not solve!
Thank you for your help.

This looks like a duplicate of #215.

thank you!
Revolved!  #215
ok disabled smartscreen, disabled win defender,
disabled firewall
checked permissions on folder C:\Program Files\RDP Wapper\
Now ITs running


throw when a promise isn't returned?

not sure how you feel about this (or what would need to change), but it's pretty easy to forget to return next in:
function (ctx, next) {
   return next().then(v => { ... })
}

what do you think about throwing if undefined is returned?
unfortunately, right now not returning a promise silently causes the control flow to change.

Sounds great. I can't see any real caveats to enabling this 👍
The code change required would be: https://github.com/blakeembrey/throwback/blob/master/src/index.ts#L38-L43. Something like const res = fn(); if (res === undefined) { throw }; return resolve(res).

The only unfortunate thing is that it doesn't help once you switch to async/await (which would always return a promise) or your middleware legitimately returns undefined (but we can warn in the README to wrap it in a promise).


Allow admin to change user's password

I want to allow to my admin user to change user's passwords via PUT /auth/password and everything goes nice except for passwords_controller is using the current login id for do the update and I need can change it with any user id.

User.find(:id).update(password:'example',password_confirmation:'example')

Please use the mailing list or StackOverflow for questions/help, where a wider community will be able to help you. We reserve the issues tracker for issues only.


Dev

Polarization with no Fock diagram is benchmarked up to the third order!

Codecov Report

Merging #21 (eafca7e) into master (418bd66) will increase coverage by 1.52%.
The diff coverage is 91.74%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   61.99%   63.51%   +1.52%
==========================================
  Files          27       27
  Lines        1876     1949      +73
==========================================
+ Hits         1163     1238      +75
+ Misses        713      711       -2

Impacted Files
Coverage Δ

src/expression_tree/build.jl
93.33% <0.00%> (-3.89%)
:arrow_down:

src/parquet_builder/benchmark/diagram_count.jl
57.31% <80.00%> (+13.08%)
:arrow_up:

src/diagram_tree/tree.jl
89.28% <100.00%> (+10.71%)
:arrow_up:

src/expression_tree/eval.jl
92.85% <100.00%> (ø)

src/expression_tree/pool.jl
51.35% <100.00%> (ø)

src/parquet_builder/filter.jl
56.81% <100.00%> (+9.09%)
:arrow_up:

src/parquet_builder/green.jl
100.00% <100.00%> (+15.38%)
:arrow_up:

src/parquet_builder/polarization.jl
97.01% <100.00%> (+0.04%)
:arrow_up:

src/parquet_builder/sigma.jl
92.59% <100.00%> (+0.13%)
:arrow_up:

src/parquet_builder/vertex3.jl
96.49% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 418bd66...eafca7e. Read the comment docs.


Diagram picture sql interpretation

Created a new repo for this project.
Created a file named schema_based_on_diagram.sql where you implement the database from the above diagram.
Join tables from many-to-many relationships might not appear in the diagram, but we added them.
We added the FK indexes.

Thank you

Hi @Goldinium,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that does not have a professional README and because this is a pair programming activity make sure you all participated
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Hyper CLI not working correctly on Manjaro Linux when installed from the AUR

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate (however there is one which is very similar, more on that later).

OS version and name: Manjaro Linux
Hyper.app version: 2.1.0canary2-1 (Installed from the AUR)
.hyper.js
The issue is reproducible in vanilla Hyper.app: I highly assume so, the only thing I've done was change the background color.

Issue
When attempting to use any command from the hyper CLI, I get the following:
/home/dakedres/.gtkrc-2.0:4: Unable to find include file: "$HOME/.gtkrc-2.0.mine"
Disabling Chromium GPU blacklist
running in prod mode
electron will open file:///usr/lib/hyper/resources/app.asar/index.html
Checking for notification messages
No matching notification messages

And it opens a new instance of the terminal, I found this previously mentioned issue which was very similar, however they were on Windows 10. So I decided to follow the answer to that issue and opened a new instance of the terminal as root (using sudo hyper) and try to reinstall the CLI command in PATH. In the Hyper terminal instance I had used to open the root instance, I got the following:
[Notification] Hyper CLI instalation: Command is added in PATH only at package installation. Please reinstall.

(hyper:9181): libnotify-WARNING **: 00:38:05.918: Failed to connect to proxy

(hyper:9181): libnotify-WARNING **: 00:38:05.931: Failed to connect to proxy

(hyper:9181): libnotify-WARNING **: 00:38:05.947: Failed to connect to proxy

(Yes that typo is accurate to the what it logged)
And it hung for quite a while, so I stopped the process. Judging from the information it gave me, I decided to try and reinstall as root, just in case, to no avail.
Any help would be greatly appreciated, I'd really like to be able to use Hyper to it's full potential again.

The CLI tools must be added to your path.
export PATH=/usr/lib/hyper/resources/bin:$PATH

Ah it works now, thank you!


Update Dashboard Names

Summary
A concise description of the changes being introduced. If you are submitting a PR for a
new quickstart please review the pre merge checklist section to validate this PR is ready for review.

Pre merge checklist

[ ] Did you check you NRQL syntax? - Does it work?
[ ] Did you check your dashboard image quality? -  Do they look good?
[ ] Did you check that your alerts actually work?
[ ] Did you include an InstallPlan and Documentation reference?
[ ] Did you check your descriptive content for voice, tone, spelling and grammar errors?
[ ] Did you attach images of your dashboards to the PR so we can see them working?

Screenshots
Attach images of any visual changes, such as a dashboard here.

@brammerl Thanks for the PR! There seems to be a mixture of changes in this PR, beyond just changing dashboard names, can you give some more details as to what else this PR is intending to do so we can evaluate it?

@jpvajda Hey! this PR isn't supposed to be open quite yet.  I'll close the PR. It's encompassing work done for another issue that involves writing the script to validate dashboard names.

@brammerl ok, thanks!


Cannot detect d435i device on Ubuntu 22.04

Required Info

Camera Model
D435i

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
Linux Ubuntu 22.04

Kernel Version (Linux Only)
6.2.0-32-generic

Platform
PC

SDK Version
legacy / 2.54.2

Language
python3.10.10

Segment
Robot

Issue Description
The PC could recognized the device cause after lsusb | grep 8086, I got output Bus 002 Device 002: ID 8086:0b3a Intel Corp. Intel(R) RealSense(TM) Depth Camera 435i.
However,

Hi @Norweig1an  Which command are you entering that causes the list in the image above to be generated, please?

If I understand it clearly, I just command realsense-viewer and the output generated.

Apologies for the delay in responding further.
In the log image that you supplied, it looks as though the launch of realsense-viewer is having problems with rendering the graphics.
Which method did you use to install the librealsense SDK on your computer, please?
You could also try updating the video drivers on your computer to see whether a missing or outdated video driver is causing the graphics not to be generated.
Another cause of such a problem could be if a computer is in a 'headless' configuration (a computer that does not have a display monitor screen attached).

Hi @Norweig1an  Do you require further assistance with this case, please?  Thanks!

Thanks for your help, I found that the driver of realsense conflict with the driver of nvidia graphics card, and after I downgrade the version of Nvidia driver it solved.

You are very welcome, @Norweig1an - thanks very much for the update!


how do we send a notification to a group of users ????

@famas23 Why don't you loop the users of your group and send to each one a notification ?

Hi, if you want use it like a group notification, in Notification class use a user common field, like group:
1. User Entity
 /**
    * @var string
    *
    * @ORM\Column(name="group", type="string")
    */
    private $group;
// generate setter/getter

2. Change jsonSerialize Notification class
public function jsonSerialize()
  {
      return [
          'type' => $this->getType(),
          'description' => $this->getDescription(),
          'checked' => $this->getChecked(),
          'checkedAt' => $this->getCheckedAt(),
          'createdAt' => $this->getCreateAt(),
          'url' => $this->url,
          'id' => $this->id,
          'userId' => $this->user->getGroup() //This helps the server identify if a specific users is connected and only send notifications to that user. You can use another field for common notifications, for example group notifications.
      ];
  }

@laurentiustroia what a hack 🙈

If you want change the Handler, is your option, but will be slow if you have many connection and you iterate it. userId is used to group the users, if you pass there a unique ID in Handler you will have Key => User, but if you not passed a unique ID the Handler will use key => array of users.


Extracting audio from video, ffmpeg command

When using ffmpeg on command line I have:
ffmpeg -i video.mp4 -ss 00:03:05 -t 00:00:45 -vn -acodec copy audio.aac
I would like to extract audio (copy, not re encoding) from video and specify start (-ss) and duration (-t) timecodes
Is this possible to do this with php-ffmpeg?

You can see https://github.com/PHP-FFMpeg/PHP-FFMpeg/issues/252
Maybe separate processes will be needed to cut it afterwards.


installing 1.7 on windows bash

I'm really at a loss :( thanks!
$ gvm install go1.7
Installing go1.7...
 * Compiling...
ERROR: Failed to compile. Check the logs at /home/adam/.gvm/logs/go-go1.7-compile.log
ERROR: Failed to use installed version

$ vim /home/adam/.gvm/logs/go-go1.7-compile.log
go tool dist: FAILED: /home/adam/.gvm/gos/go1.7/pkg/tool/linux_amd64/asm -I /tmp/go-tool-dist-402974788/math -I /home/adam/.gvm/gos/go1.7/pkg/include -D GOOS_linux -D GOARCH_amd64 -D GOOS_GOARCH_linux_amd64 -o /tmp/go-tool-dist-402974788/math/tan_amd64.o /home/adam/.gvm/gos/go1.7/src/math/tan_amd64.s: read |0: interrupted system call
go tool dist: FAILED: /home/adam/.gvm/gos/go1.7/pkg/tool/linux_amd64/asm -I /tmp/go-tool-dist-402974788/math -I /home/adam/.gvm/gos/go1.7/pkg/include -D GOOS_linux -D GOARCH_amd64 -D GOOS_GOARCH_linux_amd64 -o /tmp/go-tool-dist-402974788/math/sqrt_amd64.o /home/adam/.gvm/gos/go1.7/src/math/sqrt_amd64.s: wait: interrupted system call
go tool dist: open /tmp/go-tool-dist-402974788/sync/atomic/asm_amd64.o: no such file or directory
strconv
can't create /tmp/go-tool-dist-402974788/strconv/_go_.a: open /tmp/go-tool-dist-402974788/strconv/_go_.a: no such file or directory

gvm install go1.7 --binary fixed it!
Going to leave this here because google searching didn't return any results!


Add Joe to README contributors

@jomey is missing from the contributors README. This needs to change 😄  https://github.com/uwhackweek/jupyterbook-template#contributors-

@all-contributors add @jomey for code, ideas, content

You're too fast! 😆 Thanks @scottyhq

Pretty slick bot. Thanks guys!


[Q] How to use variables in nested config for custom expression plot?

Hi, I have a question about drawing line plots with expressions.
I am using pytorch lightning and logging hyperparams in a nested dictionary, as shown below (I put the raw file in run config tab here).
I have no problem with using values in the top-level dict(like ${config:seed_everything})
Now I want to use the variable batch_size for plot. I already tried things like ${config:batch_size}, ${config:data:batch_size} or ${config:data/batch_size} but none of them worked.
What is the correct way to use such variable to plot custom metric?
{
  "data": {
    "desc": null,
    "value": {
      "dataset": "imagenet",
      "task_type": "classification",
      "batch_size": 128
    }
  },
  "seed_everything": {
    "desc": null,
    "value": 123
  },
  (...)
}

Hey @SeminKim - could you describe what is your ultimate ideal use case/ workflow? Which kind of metric or custom plot are you trying to log / achieve? Thanks!

Hi @vitoria-wandb,
I logged the sum of loss in a batch for each training step and now I want to compare the mean loss (mean over single batch) between different runs.
To do this, I want to draw a line plot panel showing mean_loss = (train_loss / batch_size).
As the runs have different batch sizes, I cannot simply scale the train loss with same number.
(I am also facing similar issue, i.e. when I plot the unweighted loss = loss / weight_coefficient).
I tried to draw it in the Expressions tab of line plot, but have no idea about how can I retrieve batch_size from my logged config.
It seems in wandb it is logged like {'data':{'value':{'batch_size':128}}}. I attached the part of raw config in the first comment (result of 'view raw data' button in config tab of run overview).
For the workflow: I have a Data class with batch_size as an init argument and I am logging all the config with log_hyperparams
function of Pytorch Lightning. Hyperparams and class initialization arguments are automatically handled by LightingCLI, and it will internally log them by calling wandb.config.update.
Thanks for your help!

Hey @SeminKim - I think I see what you mean, let me know if this code can be of help here.
Workspace here.
The entire code is in the Colab link above, but have a look at these lines specifically:
        self.log('train_loss', loss)
        self.log('mean_loss', mean_loss)
        self.log('batch_size', self.config['data']['value']['batch_size'])

I believe you can log the mean_loss already in the code, or you can do so from the UI. Please see the video below.
Let me know if this was of help! And let me know if you have any questions!
https://github.com/user-attachments/assets/30a3810d-7a6b-4604-a0e6-289159ed9188

Thanks for your kind reply, it seems I can mitigate the issue by updating my training code to explicitly log mean_loss or batch_size.
Still, as I already have lots of old runs without explicit logging, it would be great if I can reuse them.
Is there a way to directly use the config's batch_size on UI, for  those old experiments? (I guess there's a way to do this because I can utilize this value for filtering runs as shown below...)

Hi Kim, since we have not heard back from you we are going to close this request. If you would like to re-open the conversation, please let us know!


Game is too difficult now

The game feels better, but now its wayy too difficult and the enemies are wayy too strong, add some more health to our player, and maybe lower enemy hp but increase enemy spawn rate!

Going to adjust game difficulty now

Going to make enemies do less damage, and make attacking window a little bit larger

Moved around some values, now game runs a bit berrer difficulty wise, fixed via commit 26d06ce5512755809dad74233b5ec1aebf833ec8


Refactor/user endpoints

Description
Update endpoints and corresponding tests.
Checklist

[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works AND the tests pass

@iamcristos Please note this PR is not ready for review.

We won't have time to evaluate this possible change before the end of Labs.


Unable to upgrade Ubuntu to 18.10

I'm trying to upgrade ubuntu to 18.10. However, whenever I run sudo do-release-upgrade, it runs for a while and then I get the error:
Your system is unable to reach the snap store, please make sure you're connected to the Internet and update any  firewall or proxy settings as needed so that you can reach the snap store
and  dpkg: error processing archive /tmp/apt-dpkg-install-sZrp5N/6-lxd_1%3a0.4_all.deb (--unpack):  new lxd package pre-installation script subprocess returned error exit status 1
Please fill out the below information:

Your Windows build number:  Microsoft Windows [Version 10.0.18277.1000]

What you're doing and what's happening:

sudo apt update && sudo dist-upgrade
sudo do-release-upgrade

What's wrong / what should be happening instead:
Upgrade completes without error

#2972 #2374

script I was left with a working system, just had a broken lxd.

Not exactly. You just haven't discovered the broken parts yet.

I tried to run those commands, but before the first one would work, I had to reinstall lxd.  When it failed to connect and prompted abort/retry/ok, I selected ok, and then the dkpg commands worked and I was able to apt-get upgrade.

sudo apt update && sudo dist-upgrade

Should say sudo apt dist-upgrade.


Feature request to take in a number format

In our application we have a requirement that any double value in an equation is converted using a number format.
Example:
format = NumberFormat.getInstance()
Number number = numberFormat.parse(value);
retVal = number.doubleValue();
Using exp4j, it would be nice if the evaluate function accepted a NumberFormat which it would use to convert every double value during the calculation process.

Hmm I'll have to take a look at that, but I'm quite sure that using e.g. a german NumberFormat (a comma instead of a dot as a decimal separator) will break exp4j, since there's no way to distinguish between a argument separator and a decimal separator.
E.g.:
log(3,4)
There's no way to decide if this is the log of 3 to the base 4 (2 arguments) or the natural logarithm of 3.4 (only a single argument)
But I'm of course open to suggestions...

Ahh ok yes I see that would unnecessarily complicate matters. No problem, found that the NumberFormat is no longer necessary in my project so I don't need the NumberFormat anymore. Thanks.


Fixed and updated OpenSSL Windows links in building docs

Pull request checklist:

[ ] CHANGELOG.md was updated, if applicable

Description

Links were broken, seems like there is no live exe for 1.0.2u, so I swapped it over to an archive, there is a zip, although I kept it this way to avoid any re-documenting

 I thought I had an alert for OpenSSL version changes, nice pick!

Qt ssl should work with openSSL 1.1.1+ from 5.15 according to docs, so seems like whole paragraph can be dropped?


Deserialization efficiency improvements - PR using a UTF8 memory stream to further reduce memory pressure.

This PR takes the code from PR #39, and further reduces memory allocations. This is done by writing JSON directly into a MemoryStream (actually a RecyclableMemoryStream) as UTF8 bytes. This provide the following benefits:

Avoids the final call to stringBuilder.toString() and the large temporary JSON string that allocates (and the copying of characters from the StringBuilder into that string).  Instead, the memory stream can be passed directly to JsonSerializer.Deserialize().
The characters are written to the memory stream utf8 encoded, which writes one byte per character (for typical payloads) instead of two bytes per character for strings.

These factors are particularly beneficial when handling large binary hex values.
Here are some BenchmarkDotNet benchmarks comparing performance in these these three branches:

master
deserialization-efficiency-improvements (PR #39)
deserialization-efficiency-improvements-streams-v2 (this branch/PR)

Method
Mean
Error
StdDev
Gen0
Allocated

ResponseWithValues_MapTo_CustomClass (master)
279.5 us
1.33 us
1.24 us
49.8047
409.46 KB

ResponseWithValues_MapTo_CustomClass (PR #39)
228.2 us
1.20 us
1.12 us
20.0195
165.72 KB

ResponseWithValues_MapTo_CustomClass (this PR)
256.5 us
0.83 us
0.77 us
13.1836
108.01 KB

The benchmark used here processes 100 rows. This new PR uses 108.01 / 409.46 = 26.37% of the memory allocations, compared to the current master branch. Speed is slightly faster too.

Here's a benchmark for processing 1MiB of binary (2,000,000 hex characters)...

Method
Mean
Error
StdDev
Gen0
Gen1
Gen2
Allocated

HexToBase64_Long (master)
24.30 ms
0.278 ms
0.260 ms
4406.2500
593.7500
593.7500
34.01 MB

HexToBase64_Long (PR #39)
6.088 ms
0.0932 ms
0.0872 ms
312.5000
148.4375
-
2.56 MB

HexToBase64_Long (this PR)
6.812 ms
0.0474 ms
0.0420 ms
-
-
-
37 B

Memory allocations are reduced from 34MB to 37 bytes! Performance is 3.56 faster.
/cc @georgebarbu

@colgreen Hi! Thank you, this looks really nice.
It took me a while to digest all these changes, but they are looking good.
Oh and benchmark results looks awesome - thanks.
I'm gonna merge this and release new version soon.

Added in 0.4.6.

@colgreen Hi! Thank you, this looks really nice. It took me a while to digest all these changes, but they are looking good. Oh and benchmark results looks awesome - thanks. I'm gonna merge this and release new version soon.

No problem. Thanks for taking a look and merging 👍 🚀


Fixes and improvements to SF docs

Fixes image width, JSOn entries in HTML tables, heading changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: samgnaniah:x: Samuel Mervyn GnaniahSamuel Mervyn Gnaniah seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[No QA] feat: fix storybook

Details

This PR fixes the failing builds for storybook
Fixed Issues

$ https://github.com/Expensify/App/issues/19777
PROPOSAL: https://github.com/Expensify/App/issues/19777#issuecomment-1567556251
Tests

Fetch the PR and run npm install.
Run npm run storybook
Run npm run storybook-build

Verify that storybook runs and builds correctly.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

No QA required
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
Video showing the successful build:
https://github.com/Expensify/App/assets/30054992/ff8ef16f-96c1-49b1-bb16-a9b1da5bba03

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Speaking of which, let's also update the QA Steps section of the PR description to say there are no QA steps needed - the QA team doesn't check out code locally.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.24-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Docs doesnt work

Hello, i install plugin
    graphiQLTool({
      apiVersion: '2023-08-01',
    }),

Hi, I installed the plugin and it doesn't seem to work(empty resutl) and there is no documentation

+1 I'm seeing the same thing


move admin controller to user controller

Description
move admin.controller.ts to user.controller.ts
resolves #160

yes

@YashJain2409 I can't see admin.routes.ts file changed

is it ok now ?

@YashJain2409 please edit the PR title and follow conventional commits

is it correct now ?

@all-contributors please add @YashJain2409 for code


Jittering Functions documentation

@jobrachem review?

Thank you very much, @jobrachem . All comments make sense. I'll fix everything

Ready @jobrachem

@GianmarcoCallegher  what about this one: https://github.com/liesel-devs/liesel/pull/144#discussion_r1384949524


Scrollbar Suddenly Not Showing Up

I have a WebKit-based browser, and I've added a has-scrollbar class to certain containers, but the custom scrollbar isn't working anymore. Unsure of why this was happening because I recall it working before before (I can still see the scrollbar on 7.css's page). Is anyone else experiencing the same issue?
For reference I have it added as a class of an article tag:

...

I wonder if it's because I'm using an article tag instead of a div tag? Is there another way to have the scrollbar show up for articles? Thanks.

Hey, I can't really help without further context. Would be helpful if you could elaborate more on "custom scrollbar isn't working anymore", e.g. does the default scrollbar appear in place of the custom one? or there's no scrollbar whatsoever? is the scroll region scrollable as expected...

Hi, sorry for the vagueness in the initial post! I should have provided more context.
The default scrollbar appears in place of the custom one. The scroll region is scrollable as expected. On a separate part of the site, the scrollbar works as intended when "has-scrollbar" is added as a class to a div tag, like in the guide:

  Lorem ipsum dolor sit amet...

For this particular scenario, though, I have a container with tags, so something more like:

                <menu aria-label="Window with Tabs" role="tablist">
                    <button aria-controls="introduction" aria-selected="true" role="tab">Intro</button>
                    <button aria-controls="research" role="tab">Research</button>
                    <button aria-controls="art" role="tab">Art</button>
                </menu>

                    [intro text]

                    [research text]

                    [art text]

What does work is adding a "has-scrollbar" class to the parent div, but then we end up with something like this:

Where the scrollbar shows up, but when there isn't a scroll needed (like for Intro) there is a container for it, and when there is a scroll needed, it's outside the article container.
I'd appreciate being able to have something like this instead:

Which I tried to execute with the initial code (first codeblock), but it didn't work (only the default scrollbar shows up).
Let me know if you need any additional information, and I really appreciate you looking at this.

I made a minimal CodeSandbox based on what you've provided and the scrollbar shows up still.
Can you have a look and check with your code to see if anything is missing?

Ah, this helped me figure it out! I had another div around that codeblock:

About Me

                    <button aria-label="Close"></button>

[what you had copied]

To mimic a window. I had applied "overflow: scroll" to the outer window at some point, which made the default scrollbar show up as it was scrolling on the outer window and not the inner article.
Thank you so much for helping me take a look at this and sorry for the trouble.


What permissions are needed in netbox to see the "status" and "lldp neighbors" tab on a device?

NetBox version
3.6.5
Describe the bug
When I am logged into my user, which has all permissions, I can not see the Status and LLDP Neighbors tab.
It works when I am logged in with the default admin user.
To Reproduce

Install netbox napalm
add to local_requirements.txt, and add plugin to configuration.py
Run ./upgrade.sh in netbox
Create oauth user, using Azure as backend.
Create group and map to my user.
Create permissions and map to group. (Ctrl+A for all permissions)
Check all: Can view, can add, can change, can delete.
Which includes object type NetBox Napalm Plugin > Napalm Platform Config

Expected behavior
I expect to see the Status tab and LLDP Neighbor tab under device when I am logged in with my regular user aswell
Screenshots
It works with admin user

Additional context
Maybe related to something in Netbox, as I am having similar problems with https://miaow2.github.io/netbox-config-diff/ netbox config diff plugin.

You may need to add a permission. This should be in the documentation!
https://github.com/netbox-community/netbox/discussions/8709

dcim.napalm_read_device ?


Backport SPARK-18672

@justinuang @ash211 @pwoody
Fixes issues with rename/close ordering we have been seeing

Done in #116


Use /lib64 for eccodes version higher than 2.19.0

launch jenkins int2lm<EMAIL_ADDRESS>real_type=double cosmo_target=gpu +eccodes +claw +verbose

launch jenkins int2lm<EMAIL_ADDRESS>

launch jenkins int2lm<EMAIL_ADDRESS>

launch jenkins int2lm@master%pgi

spack.concretize.UnavailableCompilerVersionError: No compilers with spec<EMAIL_ADDRESS>found for operating system cnl7 and target haswell.
Because pgi on daint does not exist?

pgi exists, but not<EMAIL_ADDRESS>:)

magically green on both machines, please don't ask x) merging anyway, we needed only confirmation on Daint

thx !


Add ACPID to default package manifest

Problem Description:
Graceful shutdown via AWS GUI/CLI not currently possible
Expected Behavior:
Issue an instance-shutdown via the AWS software and have the OS undertake a graceful shutdown procedure.
Actual Behavior:
(Nitro HVM) Instance OSes have no "hook" to receive the graceful shutdown requests. Ultimately, the cloud-layer has to initiate a forcible shutdown.
(Detailed) Steps to reproduce:
Issue a shutdown request via AWS cloud-layer tools
(Optional) Fix recommendation:
Add the ACPID package to the AMI. Per the AWS FAQ:

Q. How are instance reboot and termination EC2 API requests implemented by the Nitro Hypervisor?
The Nitro Hypervisor signals the operating system running in the instance that it should shut down cleanly by industry standard ACPI methods. For Linux instances, this requires that acpid be installed and functioning correctly. If acpid is not functioning in the instance, termination events will be delayed by multiple minutes and will then execute as a hard reset or power off.

The recently-included ec2-hibinit-agent (in Lx-GetAMI-Utils commit fc20dcc) should result in the ACPID package being installed without need for an explicit update of AMIgen7.


fix: correcting docker image name on package.json

Coverage remained the same at 85.161% when pulling 3012366ee01d6be6ce8182873858d162292935d2 on pacostas:fix-docker-image into 193e3f677d7ae4f0b951a89f5b313b1e6d5f2061 on nodeshift-starters:main.

PR merged thanks!


workerupload.go: A lock was held for too long

Bug Report
I'm seeing this when I upload 5-6 files of ~1 GB each using Minio.
Stack Trace or error message
A lock was held for too long, id '186515'. Call stack:
        File: '/home/mike/go/src/github.com/NebulousLabs/Sia/modules/renter/workerupload.go:177'
        File: '/home/mike/go/src/github.com/NebulousLabs/Sia/modules/renter/worker.go:80'
A lock was held until deadlock, subsequent call to unlock failed. id '186515'. Call stack:
        File: '/home/mike/go/src/github.com/NebulousLabs/Sia/modules/renter/workerupload.go:195'
        File: '/home/mike/go/src/github.com/NebulousLabs/Sia/modules/renter/worker.go:80'

Environment

Sia version: 47514b49625fe841348d24773ba4c7c54da4fa17
OS: Ubuntu 16.04 LTS x64

Any useful logs
Nothing looks interesting in renter.log or contractor.log

Thanks for the quick turnaround!


docs: updating CRD definitions and RBAC should be mentioned in 2.3 -> 2.4 migrations

After upgrading from 2.3 to 2.4 with the kubernetescrd provider enabled, traefik fails to fetch CRDs from k8s (i.e. Middlewares). Updating both CRD and RBAC as per commit 76f42a30 add ServersTransport on services solves the issue. IMHO upgrading CRD definitions and RBAC should hence be mentioned as a 2.3 -> 2.4 migration requirement here

Do you want to request a feature or report a bug?

Bug

What did you do?
Upgraded Traefik from 2.3 to 2.4

What did you expect to see?
My kubernetescrd setup to keep working
What did you see instead?
All routers complaining with a "middleware xxx does not exist".
Below error helped to track the issue down:
E0328 09:26:33.087928       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.20.2/tools/cache/reflector.go:167: Failed to watch *v1alpha1.ServersTransport: failed to list *v1alpha1.ServersTransport: serverstransports.traefik.containo.us is forbidden: User "system:serviceaccount:kube-system:traefik-authkeys" cannot list resource "serverstransports" in API group "traefik.containo.us" at the cluster scope
Output of traefik version: (What version of Traefik are you using?)
Reproducible with any release in the 2.4 branch. 2.3.7 works as expected

Closed by #8019.


Add JAX and Torch GPU Test setup

Creates trigger files.  Will update the build.sh in separate PR to work for JAX and Torch.

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (b811a37) 78.01% compared to head (3bc708d) 64.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18562       +/-   ##
===========================================
- Coverage   78.01%   64.28%   -13.74%
===========================================
  Files         334      334
  Lines       32379    32379
  Branches     6317     6317
===========================================
- Hits        25262    20815     -4447
- Misses       5547    10134     +4587
+ Partials     1570     1430      -140

Flag
Coverage Δ

keras
64.28% <ø> (-13.65%)
:arrow_down:

keras-jax
?

keras-numpy
?

keras-tensorflow
?

keras-torch
64.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 89 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Just wondering whether 3 GPU builds will consume too much computation resource (since this is presubmit, which might trigger multiple runs per PR).
Can u check with infra team about the current resource pool size and usages?

Valid concern. Right now the TF GPU test takes ~ 4 mins - https://source.cloud.google.com/results/invocations/9e557e12-d454-479e-97ed-55a5f12a3b2d/targets

Just wondering whether 3 GPU builds will consume too much computation resource (since this is presubmit, which might trigger multiple runs per PR).
Can u check with infra team about the current resource pool size and usages?

Valid concern. Right now the TF GPU test takes ~ 4 mins - https://source.cloud.google.com/results/invocations/9e557e12-d454-479e-97ed-55a5f12a3b2d/targets

I see. How about just merge three backends GPU test together for now. We can split them later if it takes long time to run.
Also please make sure to run all 3 of them even if some of them are failed.

Just wondering whether 3 GPU builds will consume too much computation resource (since this is presubmit, which might trigger multiple runs per PR).
Can u check with infra team about the current resource pool size and usages?

Valid concern. Right now the TF GPU test takes ~ 4 mins - https://source.cloud.google.com/results/invocations/9e557e12-d454-479e-97ed-55a5f12a3b2d/targets

I see. How about just merge three backends GPU test together for now. We can split them later if it takes long time to run.
Also please make sure to run all 3 of them even if some of them are failed.

Sure.  I can do that.  Just that the output may not be pretty to review.  But I see your point.  I can make that change and reduces the number of machines we are provisioning.

Thanks -- LGTM

Should we combine the TF, JAX, Torch GPU tests in one run or have them as separate?  I see Scott's point that it will reduce the number of machines provisioned, but might make reading the errors slightly difficult with a long long.  I can make changes to use one presubmit or keep it as three.

I would advocate for running 3 separate jobs in order to reduce total runtime -- unless it's eating too much quota, in which case a single job might be preferable.

I would advocate for running 3 separate jobs in order to reduce total runtime -- unless it's eating too much quota, in which case a single job might be preferable.

Ok.  We can start with 3 separate jobs.  If we run into quota issues, we can consolidate into one.  Does that work @qlzh727 ?

I would advocate for running 3 separate jobs in order to reduce total runtime -- unless it's eating too much quota, in which case a single job might be preferable.

Ok. We can start with 3 separate jobs. If we run into quota issues, we can consolidate into one. Does that work @qlzh727 ?

Ack, let's try that first.


fix(ci): migrate to anvil-zksync-action

What :computer:

Switch to anvil-zksync-action

Why :hand:

Action was renamed recently and our CI is failing due to that

Evidence :camera:
https://github.com/matter-labs/foundry-zksync/actions/runs/12235765131/job/34127753305#step:5:26

@Karrq we can still make use of era-test-node-action but would require using alpha.36 instead of alpha.29

I want to keep the same version we have been testing with and that we are targeting

I want to keep the same version we have been testing with and that we are targeting

You can close this PR then, with the re-release of alpha.29 on the mirrored era-test-node repo action will pick up the tag correctly: https://github.com/matter-labs/foundry-zksync/actions/runs/12235765131/job/34144769367


test(api): disable module concatenation in tree-shaking test

Which problem is this PR solving?
Fixes CI failures in https://github.com/open-telemetry/opentelemetry-js/pull/3208#issuecomment-1312384503.
Short description of the changes
When small modules are concatenated, variable names are mangled, which fails the matching in the tree-shaking test.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] Followed the style guidelines of this project
[x] Unit tests have been added

Maybe it would be safer to validate on a name we know won't be manged? Or on the string API_NAME which is a string constant and can't be mangled?

Maybe it would be safer to validate on a name we know won't be manged? Or on the string API_NAME which is a string constant and can't be mangled?

Yeah, that's another option. The value of API_NAME is not so unique so we still need an anchor to locate the exact string -- and API_NAME itself can be mangled too. So I find the current approach might be the most straightforward one.


JetBrains: "Applying Edit fails" is shown for fraction of seconds when user tries to ''Generate Unit Test"

IDE Information
PyCharm 2024.1.4 (Community Edition)
Build #IC-233.14015.106, built on January 25, 2024
Runtime version: 17.0.9+7-b1087.11 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Metal Rendering is ON
Registry:
ide.experimental.ui=true
Non-Bundled Plugins:
idea.plugin.protoeditor (233.13135.65)
DevKit (233.14015.152)
gherkin (233.11799.165)
cucumber-java (233.11799.196)
PythonCore (233.14015.106)
com.sourcegraph.jetbrains (6.0.22-nightly)
Kotlin: 233.14015.106-IJ
Bug Description
Platform: Windows 11
Steps to reproduce:

Have Cody plugin installed in your PyCharm editor
Login to Cody with Free/Pro user
Make sure user have code written
Select code and give command 'Generate Unit Test'

Observed behavior:
Applying edit fails message is shown for fraction of seconds
Expected behavior:
Edit should be applied without any error
Additional context
Note:

After Code is applied wait for sometime and then click UNDO & Observed
After Pressing Undo also edit doesn't get deleted

Video Link:
https://drive.google.com/file/d/1Ekvi339-dDnwlivcB48gC8PMy7DQSRpj/view

@RajatNagoria I was not able to reproduce this.
Have you seen it only once or is it more frequent behaviour?

@pkukielka It is more frequently repro for me


Configuration file to include dataset information

We should have configuration that allows you to specify datasets, where they live, what backends they should be tested with, and the error threshold for validation.
Also it would be good to specify the percentage of total extent to use in validation, so that on large clusters we can set to 1 so that we validate the entire image.
rough, rough draft:
validationExtentSize = ".3" // Means to take up a random 30% of extent for validation

datasets: {
  name : "nex",
  type : "file",
  path : "something"
  resampleMethod : "bilinear" or "nearest_neighbor" // if it's continuous, bilinear, if it's a classification (NLCD), nearest neighbor
}

s3 {
  bucket       = geotrellis-test
  loadPrefix   = nex-geotiff
  ingestPrefix = gt-integration-test
}

accumulo {
  instance   = gis
  zookeepers = localhost
  user       = root
  password   = secret
  table      = gtintegration
}

hadoop {
  ingestPath = /geotrellis-integration/
  loadPath   = /geotrellis-integration-load/
}

file {
  ingestPath = /tmp/geotrellis-integration/
  loadPath   = /tmp/geotrellis-integration-load/
}

validation {
  tiff = tasmax_amon_BCSD_rcp26_r1i1p1_CONUS_CCSM4_200601-201012-200601120000_0_0.tif
  dir  = /data/tmp/
}

[{
   "name":"nex",
   "type":{
      "loadBackend":"hadoop",
      "ingestBackend":"accumulo",
      "tileType":"singleband",
      "ingestType":"spatial"
   },
   "path":{
      "load":"/geotrellis-integration-load/",
      "ingest":"gtintegration"
   },
   "ingestOptions":{
      "resampleMethod":"bilinear",
      "layoutScheme":{
         "type":"zoomed",
         "crs":"EPSG:3857",
         "tileSize":256,
         "resolutionThreshold":0.1
      },
      "keyIndexMethod":{
         "type":"zorder"
      }
   },
   "validationOptions":{
      "validationExtentSize":0.3,
      "resolutionThreshold":0.1
   }
},
{
   "name":"nex",
   "type":{
      "loadBackend":"hadoop",
      "ingestBackend":"accumulo",
      "tileType":"singleband",
      "ingestType":"temporal"
   },
   "path":{
      "load":"/geotrellis-integration-load/",
      "ingest":"gtintegration"
   },
   "ingestOptions":{
      "resampleMethod":"bilinear",
      "layoutScheme":{
         "type":"zoomed",
         "crs":"EPSG:3857",
         "tileSize":256,
         "resolutionThreshold":0.1
      },
      "keyIndexMethod":{
         "type":"zorder",
         "timeTag":"ISO_TIME",
         "timeFormat":"yyyy-MM-dd'T'HH:mm:ss",
         "temporalResolution":1314000000
      }
   },
   "validationOptions":{
      "validationExtentSize":0.3,
      "resolutionThreshold":0.1
   }
}]

Done,  in master right now.


Added Emplace_hint file for unordered_map directory

This PR adds emplace_hint.md file for unordered_map directory by strictly adhering to the contributing guidelines.

Fixes #31
Changes

Added file for implementing emplace_hint() method in unordered_map in C++ .

Checklist

[✅] I have read CONTRIBUTING guidelines.
[✅] This is a typo fix.
[✅] I am not updating any todo.txt files.

@Bhupesh-V  I have made a PR for titled file. This is my first PR and participating in HacktoberFest '22. Thanks for creating such a good beginner-friendly guidelines for contributing.
BEst!


[Spec Impl] Implement Session Termination of the Spec

Background
The spec says
The session MUST be terminated if at least one of the following conditions occur:

After a time-out of no activity occurs.
If the Wallet does not want to receive any further requests.
If the Verifier does not want to send any further requests.

Termination is as per the default BLE write.
In case of a termination, the Wallet and Verifier MUST perform at least the following actions:

Destruction of session keys and related ephemeral key material
Closure of the communication channel used for data retrieval

We already have Connection closure implemented

What to do
TBD

This requirement has been moved to Jira.
Link to Jira ticket: https://mosip.atlassian.net/browse/MOSIP-26907


Jumps to bottom on new message

If I'm trying to catch up, so scrolling up and reading older messages, I get "pulled" back to the bottom of the chat window every time a new message is posted. This is kinda annoying :-)

Yeah we'll work on that thanks!


Trouble tracing why convergence is slower in Lightning

I recently refactored some code from [this tutorial])(https://www.assemblyai.com/blog/end-to-end-speech-recognition-pytorch) (trains speech-to-text using librispeech 100 hr) into Lightning and found it to be converging slower and never reaching the same level of loss. I made a lot of changes when I refactored into Pytorch lightning, and I slowly undid them until I was left with the original code and the lightning version. I even set comet to be the logger so that they had the same logging, and the results are the same. I can't figure out what's going on. As far as I can tell, the code is identical (except for the training loop) and I don't know how to proceed. (Edit: I've now added the training loop code from both notebooks at the bottom of this post for ease of access)
Here are the notebooks: The final few cells (train/test/main functions) are the relevant/distinct portion.
Non-lightning Notebook - converges faster
Lightning Notebook - converges slower

I am using torch 1.4.0 and torchaudio 0.4.0.
Train loss vs step in both versions, other metrics (char error rate and word error rate) are also worse.
The most recent comparison (visualized below) didn't use a seed, but I have run many variations, including ones where torch/np use the same seed, and the results were similar.

)
Non-Lightning Version:
def train(model, device, train_loader, criterion, optimizer, scheduler, epoch, iter_meter, experiment):
    model.train()
    data_len = len(train_loader.dataset)
    with experiment.train():
        for batch_idx, _data in enumerate(train_loader):
            spectrograms, labels, input_lengths, label_lengths = _data
            spectrograms, labels = spectrograms.to(device), labels.to(device)

            optimizer.zero_grad()

            output = model(spectrograms)  # (batch, time, n_class)
            output = F.log_softmax(output, dim=2)
            output = output.transpose(0, 1) # (time, batch, n_class)

            loss = criterion(output, labels, input_lengths, label_lengths)
            loss.backward()

            experiment.log_metric('loss', loss.item(), step=iter_meter.get())
            experiment.log_metric('learning_rate', scheduler.get_lr(), step=iter_meter.get())

            optimizer.step()
            scheduler.step()
            iter_meter.step()
            if batch_idx % 100 == 0 or batch_idx == data_len:
                print('Train Epoch: {} [{}/{} ({:.0f}%)]\tLoss: {:.6f}'.format(
                    epoch, batch_idx * len(spectrograms), data_len,
                    100. * batch_idx / len(train_loader), loss.item()))
                # if(batch_idx >= 100):
                #   print("Exiting Early")
                #   break

def test(model, device, test_loader, criterion, epoch, iter_meter, experiment):
    print('\nevaluating...')
    model.eval()
    test_loss = 0
    test_cer, test_wer = [], []
    with experiment.test():
        with torch.no_grad():
            for i, _data in enumerate(test_loader):
                spectrograms, labels, input_lengths, label_lengths = _data
                spectrograms, labels = spectrograms.to(device), labels.to(device)

                output = model(spectrograms)  # (batch, time, n_class)
                output = F.log_softmax(output, dim=2)
                output = output.transpose(0, 1) # (time, batch, n_class)

                loss = criterion(output, labels, input_lengths, label_lengths)
                test_loss += loss.item() / len(test_loader)

                decoded_preds, decoded_targets = GreedyDecoder(output.transpose(0, 1), labels, label_lengths)
                for j in range(len(decoded_preds)):
                    print("\nTarget:", decoded_targets[j])
                    print("\nPredicted:", decoded_preds[j])
                    test_cer.append(cer(decoded_targets[j], decoded_preds[j]))
                    test_wer.append(wer(decoded_targets[j], decoded_preds[j]))

    avg_cer = sum(test_cer)/len(test_cer)
    avg_wer = sum(test_wer)/len(test_wer)
    experiment.log_metric('test_loss', test_loss, step=iter_meter.get())
    experiment.log_metric('cer', avg_cer, step=iter_meter.get())
    experiment.log_metric('wer', avg_wer, step=iter_meter.get())

    print('Test set: Average loss: {:.4f}, Average CER: {:4f} Average WER: {:.4f}\n'.format(test_loss, avg_cer, avg_wer))

def main(learning_rate=5e-4, batch_size=20, epochs=10,
        train_url="train-clean-100", test_url="test-clean",
        experiment=Experiment(api_key='dummy_key', disabled=True)):

    hparams = {
        "n_cnn_layers": 3,
        "n_rnn_layers": 5,
        "rnn_dim": 512,
        "n_class": 29,
        "n_feats": 128,
        "stride":2,
        "dropout": 0.1,
        "learning_rate": learning_rate,
        "batch_size": batch_size,
        "epochs": epochs
    }

    experiment.log_parameters(hparams)

    use_cuda = torch.cuda.is_available()
    torch.manual_seed(7)
    device = torch.device("cuda" if use_cuda else "cpu")

    if not os.path.isdir("./data"):
        os.makedirs("./data")

    train_dataset = torchaudio.datasets.LIBRISPEECH("./data", url=train_url, download=True)
    test_dataset = torchaudio.datasets.LIBRISPEECH("./data", url=test_url, download=True)

    kwargs = {'num_workers': 1, 'pin_memory': True} if use_cuda else {}
    train_loader = data.DataLoader(dataset=train_dataset,
                                batch_size=hparams['batch_size'],
                                shuffle=True,
                                collate_fn=lambda x: data_processing(x, 'train'),
                                **kwargs)
    test_loader = data.DataLoader(dataset=test_dataset,
                                batch_size=hparams['batch_size'],
                                shuffle=False,
                                collate_fn=lambda x: data_processing(x, 'valid'),
                                **kwargs)

    model = SpeechRecognitionModel(
        hparams['n_cnn_layers'], hparams['n_rnn_layers'], hparams['rnn_dim'],
        hparams['n_class'], hparams['n_feats'], hparams['stride'], hparams['dropout']
        ).to(device)

    print(model)
    print('Num Model Parameters', sum([param.nelement() for param in model.parameters()]))

    optimizer = optim.AdamW(model.parameters(), hparams['learning_rate'])
    criterion = nn.CTCLoss(blank=28).to(device)
    scheduler = optim.lr_scheduler.OneCycleLR(optimizer, max_lr=hparams['learning_rate'],
                                            steps_per_epoch=int(len(train_loader)),
                                            epochs=hparams['epochs'],
                                            anneal_strategy='linear')

    iter_meter = IterMeter()
    for epoch in range(1, epochs + 1):
        train(model, device, train_loader, criterion, optimizer, scheduler, epoch, iter_meter, experiment)
        test(model, device, test_loader, criterion, epoch, iter_meter, experiment)

learning_rate = 5e-4
batch_size = 20
epochs = 10
libri_train_set = "train-clean-100"
libri_test_set = "test-clean"

main(learning_rate, batch_size, epochs, libri_train_set, libri_test_set, experiment)

Lightning Version:

class SpeechTrainModel(pl.LightningModule):
    def __init__(self, hparams):
        super().__init__()
        self.hparams = hparams
        self.model = SpeechRecognitionModel(
        hparams['n_cnn_layers'], hparams['n_rnn_layers'], hparams['rnn_dim'],
        hparams['n_class'], hparams['n_feats'], hparams['stride'], hparams['dropout']
        )
        self.criterion = nn.CTCLoss(blank=28)

    def forward(self, x):
        return self.model(x)

    def training_step(self, batch, batch_nb):
        spectrograms, labels, input_lengths, label_lengths = batch
        output = self(spectrograms)  # (batch, time, n_class)
        output = F.log_softmax(output, dim=2)
        output = output.transpose(0, 1) # (time, batch, n_class)

        loss = self.criterion(output, labels, input_lengths, label_lengths)
        tensorboard_logs = {'train_loss': loss}
        return {'loss': loss, 'log': tensorboard_logs}

    def validation_step(self, batch, batch_nb):

        spectrograms, labels, input_lengths, label_lengths = batch

        output = self(spectrograms)  # (batch, time, n_class)
        output = F.log_softmax(output, dim=2)
        output = output.transpose(0, 1) # (time, batch, n_class)

        loss = self.criterion(output, labels, input_lengths, label_lengths)

        # decoded_preds, decoded_targets = GreedyDecoder(output.transpose(0, 1), labels, label_lengths)
        # for j in range(len(decoded_preds)):
        #     test_cer.append(cer(decoded_targets[j], decoded_preds[j]))
        #     test_wer.append(wer(decoded_targets[j], decoded_preds[j]))
        return {'val_loss': loss}

    def validation_epoch_end(self, outputs):
        # OPTIONAL
        avg_loss = torch.stack([x['val_loss'] for x in outputs]).mean()
        tensorboard_logs = {'val_loss': avg_loss}
        return {'val_loss': avg_loss, 'log': tensorboard_logs}

    def prepare_data(self):
        if not os.path.isdir("./data"):
            os.makedirs("./data")
        self.train_dataset = torchaudio.datasets.LIBRISPEECH("./data", url="train-clean-100", download=True)
        self.test_dataset = torchaudio.datasets.LIBRISPEECH("./data", url="test-clean", download=True)

    def configure_optimizers(self):
        hparams = self.hparams
        optimizer = optim.AdamW(self.parameters(), hparams['learning_rate'])

        scheduler = optim.lr_scheduler.OneCycleLR(optimizer, max_lr=hparams['learning_rate'],
                        steps_per_epoch=int(len(self.train_dataset)),
                        epochs=hparams['epochs'],
                        anneal_strategy='linear')

        scheduler_dict = {'scheduler': scheduler, 'interval': 'step'}

        return [optimizer], [scheduler_dict]

    def train_dataloader(self):
        self.train_loader = data.DataLoader(dataset=self.train_dataset,
                    batch_size=self.hparams['batch_size'],
                    shuffle=True,
                    collate_fn=lambda x: data_processing(x, 'train'),
                                )
        return self.train_loader

    def val_dataloader(self):
        return data.DataLoader(dataset=self.test_dataset,
                    batch_size=self.hparams['batch_size'],
                    shuffle=False,
                    collate_fn=lambda x: data_processing(x, 'valid'),
                                )

learning_rate=5e-4
batch_size=20
epochs=10

hparams = {
    "n_cnn_layers": 3,
    "n_rnn_layers": 5,
    "rnn_dim": 512,
    "n_class": 29,
    "n_feats": 128,
    "stride":2,
    "dropout": 0.1,
    "learning_rate": learning_rate,
    "batch_size": batch_size,
    "epochs": epochs
}

mdl = SpeechTrainModel(hparams)
trainer = pl.Trainer(gpus=1, max_epochs=epochs, logger=comet_logger)
trainer.fit(mdl)

Convergence problem.
Try:
def configure_optimizers(self):
        hparams = self.hparams
        optimizer = optim.AdamW(self.parameters(), hparams['learning_rate'])

        scheduler = optim.lr_scheduler.OneCycleLR(optimizer, max_lr=hparams['learning_rate'],
                        steps_per_epoch=int(len(self.train_dataset)),
                        epochs=hparams['epochs'],
                        anneal_strategy='linear')

        scheduler_dict = {'scheduler': scheduler, 'interval': 'step'}

        return [optimizer], [scheduler_dict]

Thank you for the quick reply and suggestion, I changed that and tracked the results. I do not believe it fixed the problem. It appears to have improved things slightly but maybe it is variance as I am currently using colab(differing hardware) and not seeding. If there is anything you'd suggest I run to ensure reproducibility please let me know. Here are the results:
Train loss vs step

Train_loss vs duration

As you can see train loss vs step seems to be about the same as before. Train loss vs duration improves and more closely matches the non-lightning version, but it could also be that colab allocated better hardware for that session (or that in the previous training, I was running both at once, I'm not sure what the impact of that is).

Ok, found 2 more mistakes.

In the non-lightning version, your iter_meter does take a step in test loop, but in lightning, this step is updated in val_loop too. Maybe this is creating a mismatch in the above graph since step is on the x-axis.
In scheduler, in non-lightning version your scheduler takes steps_per_epoch=int(len(train_loader)) but in lightning version it is steps_per_epoch=int(len(self.train_dataset)).

Thank you Rohit, you are a lifesaver. It was #2, updating the lightning version by changing steps_per_epoch in the scheduler to the length of the train loader fixed the problem. I really appreciate you taking the time to help.

Np. Also there is pl.seed_everything in lightning you can use to reproduce your results.
https://github.com/PyTorchLightning/pytorch-lightning/blob/ed581eb64f105a39c1516527cd733a93f033edcb/pytorch_lightning/utilities/seed.py#L13-L18
BTW thanks for blog link above. Was looking for something similar to start with speech. It is quite good.


Disable absolute redirects

This fixes an issue where users who visit www.gov.uk/design-system would get an absolute redirect to our origin domain (govuk-design-system-production.cloudapps.digital/design-system/).

You can preview this change here:
Built with commit d5ea882a4313cdf20f51688e5bbf6b6bc34dfd36
https://deploy-preview-328--govuk-design-system-preview.netlify.com


[nrf fromtree] net: lwm2m: fix hanging deregistration

Fixed a deadlock in deregistration by moving mutex unlocking.

@tokangas Wasn't this commit already included in the upmerge? It's present on the main branch.


Server works bad with mod installed

As the person in #16 said the mod on a 1.20.1 forge server causes lag spike's and bad tps.
Is there any fix available?

same issue

fix it. use 2.2.0


Change definition of ENNReal.HasInv

This allows lemmas such as inv_top to be rfl. Suggested by @urkud on Zulip: https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/ENNReal.2Emul_div/near/368077795

I'm no longer sure that it's worth it. OTOH, we can do it for a WithTop, then we'll get it for WithTop NNRat too (does anyone need it?)


Removed duplicate search layout code

There was a decent chunk of duplicate code on the search template. This reduces that by moving the if search performed and if no results conditionals only affect the title of the page.
cc/ @mpiotrowicz @stevebosworth @carolineschnapp

A {% if item.price %} is nested inside an {% if item.featured_image %} so the logic seems flawed. If you have a featured_image for sure you have a price.

i think if just looks like that because of the indentation. item.price is not inside item.featured_image.

Oh right I am so sorry: http://take.ms/WYFoe Would you like me to test all this in a sandbox? I can do that if you give me one more hour. Thanks for using a better check for the presence of a product result. We have dropped so many requirements for a product to be a product :) No need for type / vendor / description...

Yea that'd be great. I'm working on another theme's search results now and mimicking what's going on here. There may be another commit or two so no rush.

When showing the description or content, there's often an indentation:

I think that issue may be with our Liquid filters, OR RTE. I ran into this issue before and can't remember for the life of me what I did to get rid of the space. You, I, will also see that when showing a stripped, truncated article content. No amount of | remove: '  or | trimgets rid of that white space at the beginning.

Must be an RTE thing. Not happening on my shop https://carson-dev-shop.myshopify.com/search?q=page

Must be, yes. I will dig from its grave a Github issue I once created for this.
Moving on!


Quick find next astronomy event

Full moon
New moon
Meteor shower
Eclipse (when implemented)

Finds the next occurrence of the event from the display date (exclusive) and sets the date to that.
This can be accessed by clicking the date picker on the astronomy tab - appears above the calendar view as a dropdown and search button.

May I suggest the moons quarters? (Relevant for neaps vs. springs.)


VMware?

VMware is cited in second paragraph:
"This is the third tutorial in a series that shows you how to set up disaster recovery to Azure for on-premises VMware VMs. In the previous tutorial, we prepared the on-premises Hyper-V environment for disaster recovery to Azure."
But this page is about Hyper-V with SCVMM.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7e7c9330-09be-b71f-8204-f1a708bb007e
Version Independent ID: 207b4132-f489-25aa-9e46-24a8dc5ed35f
Content: Set up Hyper-V (with VMM) disaster recovery using Azure Site Recovery - Azure Site Recovery
Content Source: articles/site-recovery/hyper-v-vmm-azure-tutorial.md
Service: site-recovery
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

#assign:davidsmatlak

Thanks for the feedback. I'll update the document.

I submitted the fix for this issue and when it merges, this issue will automatically close. The updated document will be online within 24 hours.


SN564: Add Azure Translate Service

Description
This PR adds an azure translate service for the automatic translation in the functions app. It also refactors the automatic translation endpoint for sentenceText. The new endpoint can handle all types of apis in a single function. Example below.

Fixes SN564 and SN562.
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[x] Tested the API endpoint on Swagger with the 'Try it out' feature

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas

Checklist for API
If you added new API endpoints / made changes to exsting endpoints, please fill this checklist.

[x] The endpoint is accessible through Swagger.
[x] The endpoint supports permissions and authentication for different roles.
[x] All exceptions have been handled and appropriate status code is returned to the user.
[x] I have added docstrings for ViewSets / Serializers.

Note: The test is failing because drf-yasg is not configured with the latest drf version - 3.14.0. For now, we are not changing it because drf-yasg might make it compatible with latest drf, but in the future if it continues to break then we can fix the drf version.


Ignore fake emails in user search and typeahead

In organizations where emails are not public, we create fake "emails" with unique user IDs. At present, these emails are queried in user search and typeahead, which is certainly not what the user intends. Along with #4869, it makes user search feel "broken".
If email address visibility for an organization is something other than "everyone", we should ignore the email field in user search.

Might be solved by #3902?


Fix error message output introduced in PR 58

Oops, the separator was used in the error message output, replacing it
with a dot.

Nice catch!


Projecting new data into an existing model - Question

I have a very naive question regarding UMAP and projecting new data into an existing UMAP embedding:
Are the new data explicitly constrained to be within the previously embedded data points? My question stems from integrating data from differing platforms or tissues or treatment data. If I have an embedding from measurement platform A (for instance sequencing types like single-cell RNA) and wish to project data from measurement platform B into the previous embedding made with platform A. Will the data points from platform B be constrained to fall within the points from A?
Not sure if I'm asking a coherent question...
Thanks again @lmcinnes for such an incredible approach!

As an explicit example if it helps:

The "normal FTE" was the initial embedding and the "hgsoc_ascites" is the new data. The prior is "normal tissue" and the latter is "cancerous tissue" likely originating from the former. I'm not seeking interpretation of the data/joint embedding, but more about if it's expected that new data projected into the original embedding is constrained to fall within the prior data points.

The new data is not constrained to lie within the training data, but the training data is assumed to be a representative sample of the data. Thus new data that is significantly different from the training data will still be assumed to somehow lie on the learned structure, and get pulled in. That is, you should not expect data that is significantly different to form a new cluster or group; it will simply end up near the closest representatives of the training data. I'm not entirely sure if this answers your question, so please feel free to seek further clarification.

This does indeed answer my question! Thanks so much!


Start removing licenses(notice) and replacing with license()

licenses() does not do anything.

@teeler - can we do this?

Lowered in urgency. It's going to make my imports harder if I do this today.

friendly ping from reviewers.
license() is a no-op in Bazel. It is not used in Blaze when applicable_licenses is used.

The failing test is unrelated to this. It is that --noenable_bzlmod does not work with bazel at head, and bazelci is ignoreing the explicit bazel version.


[MWPW-129920] Marquee large updates - new height variants

This is the implementation of two new variants of Marquee Large with min heights 560px (called standard variant) and 360px (called compact variant).
Only the height changes are implemented, hence the font and type scales of the standard and compact large marquees will be same as the current large marquee.
Any other changes for the large marquee and the updates for quiet marquee will be done once the designs are finalised (as the part of a separate ticket).

Resolves: MWPW-129920
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/drashti/marquee-std/final-height?martech=off
After: https://marquee-height--milo--drashti1712.hlx.page/drafts/drashti/marquee-std/final-height?martech=off

verified the height for  Marquee Large 700 , Standard Marque 560 and Compact Marque 360
height looks fine .
verified URL's : https://marquee-height--milo--drashti1712.hlx.page/drafts/shrinidhivp/Marquee-Large/marquee-final-height
https://marquee-height--milo--drashti1712.hlx.page/drafts/drashti/marquee-std/final-height


Vendor MCM v0.43

What this PR does / why we need it:
This PR vendors machine-controller-manager v0.43.0
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

@himanshu-kun is the ginko PR required here too? I didn't file any .ci/test file.

@himanshu-kun is the ginko PR required here too? I didn't file any .ci/test file.

Hi Shafeeque. No its not required here as the test script will install the ginkgo version which is in the vendor folder which is this and since its major version 1.x.x so tests will run fine.


Added ability to strip custom tags from documentation

Added ability to strip custom tags from documentation through new optional tagging.stripAdditionalTags arrayOfStrings.

thanks


Skia crash in customer:money

customer:money reported crash seen in the wild.
Thread 0  (id: 0x00000303) CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x000002e0 ]Show exception record
0x0000000182e17a74(Metal + 0x00010a74)
0x00000001a0963190(AGXMetalA8 + 0x0007f190)
0x00000001a095c3f4(AGXMetalA8 + 0x000783f4)
0x00000001a093ea58(AGXMetalA8 + 0x0005aa58)
0x0000000105340708(Flutter + 0x002b4708)
0x0000000105347e48(Flutter + 0x002bbe48)
0x0000000105348458(Flutter + 0x002bc458)
0x0000000105340fa4(Flutter + 0x002b4fa4)
0x000000010525944c(Flutter + 0x001cd44c)
0x000000010524cad8(Flutter + 0x001c0ad8)
0x000000010524cdf8(Flutter + 0x001c0df8)
0x00000001052787c8(Flutter + 0x001ec7c8)
0x00000001052ef5a4(Flutter + 0x002635a4)
0x000000010550b5cc(Flutter + 0x0047f5cc)
0x000000010511b60c(Flutter + 0x0008f60c)
0x00000001050a5268(Flutter + 0x00019268)
0x00000001050bee8c(Flutter + 0x00032e8c)
0x000000010539e840(Flutter + 0x00312840)
0x000000010539f400(Flutter + 0x00313400)
0x000000010539eb10(Flutter + 0x00312b10)
0x00000001053a5208(Flutter + 0x00319208)
0x00000001050c9c7c(Flutter + 0x0003dc7c)
0x00000001050cbbf0(Flutter + 0x0003fbf0)
0x00000001810e3dbc(CoreFoundation + 0x000ebdbc)
0x00000001810e3ae0(CoreFoundation + 0x000ebae0)
0x00000001810e32e0(CoreFoundation + 0x000eb2e0)
0x00000001810e0ec8(CoreFoundation + 0x000e8ec8)
0x0000000181000c54(CoreFoundation + 0x00008c54)
0x0000000182eacf80(GraphicsServices + 0x0000af80)
0x000000018a7595c0(UIKit + 0x000735c0)
0x00000001003cb6b4(ios_prod_global -main.m:35)main
0x0000000180b20568(libdyld.dylib + 0x00001568)

Unfortunately, user reports are all we have at this point. No reproduction. We do know that this particular crash came from iOS 11.2 device. They have other traces as well which end up in AGXMetalA8 lib and together they form ~7% of their total crashes on iOS (2nd most severe) making this a P2.

@flutter-symbolizer-bot 2eac514f26a676d1df0821e815d501149d3ead7f release arm64

@mraleph How does the bot know what platform to use? From the crash format?

@mehmetf yeah, from the crash format. also you need to be a public member of Flutter org on GitHub (which you are not - you can check by looking at this issue in incognito window) to issue commands to the bot.
I will do some tweaks to the bot and update this issue once it is ready.

I have made some tweaks to the bot, including writing a README for it (check its profile).
What follows is the demo.

@flutter-symbolizer-bot 2eac514f26a676d1df0821e815d501149d3ead7f release arm64

@flutter-symbolizer-bot https://github.com/flutter/flutter/issues/69642#issue-735022434 internal engine#2eac514f26a676d1df0821e815d501149d3ead7f ios release arm64

@mehmetf as you can see I added support for internal stack trace format for ios. If you have examples of how internal stacks for Android apps look like, please send them to me as well so that I could adjust RegExps. Bot now reports errors to users that try to invoke it.

@xster seems like a Skia crash on iOS reporter by @mehmetf see symbolization above.

@chinmaygarde as well. Unfortunately, user reports are all we have at this point. No reproduction. We do know that this particular crash came from iOS 11.2 device.  They have other traces as well which end up in AGXMetalA8 lib and together they form ~7% of their total crashes on iOS (2nd most severe) making this a P2.

This is the other trace:
Thread 0  (id: 0x00000303) CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x000002e0 ]Show exception record
0x000000018733fa74(Metal + 0x00010a74)
0x00000001a4d808c0(AGXMetalA8 + 0x000728c0)
0x00000001a4d689bc(AGXMetalA8 + 0x0005a9bc)
0x0000000105b70534(Flutter + 0x002b4534)
0x0000000105b73610(Flutter + 0x002b7610)
0x0000000105a81f24(Flutter + 0x001c5f24)
0x0000000105a885d8(Flutter + 0x001cc5d8)
0x0000000105a7a630(Flutter + 0x001be630)
0x0000000105a7a5b4(Flutter + 0x001be5b4)
0x0000000105a88270(Flutter + 0x001cc270)
0x0000000105a88200(Flutter + 0x001cc200)
0x0000000105a7c9c4(Flutter + 0x001c09c4)
0x0000000105a7cdf8(Flutter + 0x001c0df8)
0x0000000105aa87c8(Flutter + 0x001ec7c8)
0x0000000105b1f5a4(Flutter + 0x002635a4)
0x0000000105d3b5cc(Flutter + 0x0047f5cc)
0x000000010594b60c(Flutter + 0x0008f60c)
0x00000001058d5268(Flutter + 0x00019268)
0x00000001058eee8c(Flutter + 0x00032e8c)
0x0000000105bce840(Flutter + 0x00312840)
0x0000000105bcf400(Flutter + 0x00313400)
0x0000000105bceb10(Flutter + 0x00312b10)
0x0000000105bd5208(Flutter + 0x00319208)
0x00000001058f9c7c(Flutter + 0x0003dc7c)
0x00000001058fbbf0(Flutter + 0x0003fbf0)
0x000000018560afbc(CoreFoundation + 0x000eefbc)
0x000000018560ace0(CoreFoundation + 0x000eece0)
0x000000018560a4e0(CoreFoundation + 0x000ee4e0)
0x00000001856080c8(CoreFoundation + 0x000ec0c8)
0x0000000185527e54(CoreFoundation + 0x0000be54)
0x00000001873d4f80(GraphicsServices + 0x0000af80)
0x000000018eba7678(UIKit + 0x00073678)
0x0000000100d8f6b4(ios_prod_global -main.m:35)main
0x0000000185044568(libdyld.dylib + 0x00001568)

@flutter-symbolizer-bot https://github.com/flutter/flutter/issues/69642#issuecomment-721246638 internal engine#2eac514f26a676d1df0821e815d501149d3ead7f ios release arm64

Has signs of https://github.com/flutter/flutter/issues/69449. @mehmetf does money use platform views?

The second stack trace looks like a duplicate of https://github.com/flutter/flutter/issues/69102. This is unlikely to be the platform-views race that @xster linked to.

Ah never mind you're right. @gaaclarke already looked at it and seems like it's another background GPU issue?

Yea, I suspect this may be a background GPU problem.  Looks like a canvas flush is causing some GPU operations and it isn't protected with the GPU-disabling SyncSwitch.  I can create a PR today.
https://github.com/flutter/flutter/issues/69102 is a bit different because the syncswitch was in the stacktrace.

This is probably another issue that was caused by https://github.com/flutter/engine/pull/20671  We are now sending people through the platform views controller when we didn't previously didn't and that code was meant to run in a situation where the main thread and the raster thread were merged so we couldn't get GPU operations in the background.  I suspect @cyanglaz's PR https://github.com/flutter/engine/pull/22275 will fix this.

Actually, if you look at the thread, it is thread 0, which the platform thread.  This means this crash is happening when the threads are merged.  If this is a GPU backgrounding problem, that means we are getting some events on the platform thread after applicationWillResignActive.  So, the GPU is disabled, but since this doesn't go through the syncswitch it still tries to use the GPU.  I was wrong, we need to route this code through the gpu disable syncswitch despite the threads being merged.

Even with the fixes, customer:money continues to see this crash.
Thread 7  (id: 0x00007103) CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x000002e0 ]Show exception record
0x0000000186d207fc(Metal + 0x0000f7fc)
0x00000001a557a85c(AGXMetalA7 + 0x0007985c)
0x00000001a550b614(AGXMetalA7 + 0x0000a614)
0x00000001a550d5c8(AGXMetalA7 + 0x0000c5c8)
0x00000001063d0724(Flutter + 0x002b8724)
0x00000001063d36ec(Flutter + 0x002bb6ec)
0x00000001062e3160(Flutter + 0x001cb160)
0x00000001062e2ddc(Flutter + 0x001caddc)
0x00000001062fa2a0(Flutter + 0x001e22a0)
0x00000001062ee184(Flutter + 0x001d6184)
0x0000000106305994(Flutter + 0x001ed994)
0x00000001062edd50(Flutter + 0x001d5d50)
0x00000001062c85a8(Flutter + 0x001b05a8)
0x0000000106384bfc(Flutter + 0x0026cbfc)
0x00000001064d07cc(Flutter + 0x003b87cc)
0x00000001061562e0(Flutter + 0x0003e2e0)
0x00000001064d00ac(Flutter + 0x003b80ac)
0x0000000106154fc4(Flutter + 0x0003cfc4)
0x0000000106156f38(Flutter + 0x0003ef38)
0x0000000184eb3aa4(CoreFoundation + 0x000eeaa4)
0x0000000184eb3768(CoreFoundation + 0x000ee768)
0x0000000184eb300c(CoreFoundation + 0x000ee00c)
0x0000000184eb0b5c(CoreFoundation + 0x000ebb5c)
0x0000000184dd0da4(CoreFoundation + 0x0000bda4)
0x0000000106156e14(Flutter + 0x0003ee14)
0x000000010615679c(Flutter + 0x0003e79c)
0x0000000184b3121c(libsystem_pthread.dylib + 0x0000221c)
0x0000000184b3110c(libsystem_pthread.dylib + 0x0000210c)

@flutter-symbolizer-bot https://github.com/flutter/flutter/issues/69642#issuecomment-738887789 internal engine#5dcf1d243eb401d59dab2b6310dea36267c2ba7c ios release arm64

This engine hash was generated by cherrypicking this fix (and a couple of others) onto the dev branch: https://github.com/flutter/engine/commits/5dcf1d243eb401d59dab2b6310dea36267c2ba7c

Hi , Can you provide the EAT for this fix to be released on stable channel? It really causes many crash on ios

ma 7.12.2020 klo 5.45 mybotgb<EMAIL_ADDRESS>kirjoitti:

Hi , Can you provide the EAT for this fix to be released on stable
channel? It really causes many crash on ios
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/69642#issuecomment-739644572,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ4UBVNT2RGNM2L5TSRQVBDSTRFT3ANCNFSM4TIJLIGA
.

@gaaclarke could you give this one another look?

The SyncSwitch is in the stacktrace so this isn't a result of executing GPU commands in the background like we thought.  This now is a duplicate of https://github.com/flutter/flutter/issues/69102 which chinmay is looking into.  On that issue I asked if anyone had the console log (https://github.com/flutter/flutter/issues/69102#issuecomment-720738001), maybe someone will have them here.

I'm going to close this as a dup of #69102 and provide any further updates there.


[WIP] Nulls not distinct option

Closes: https://github.com/kysely-org/kysely/issues/711
Modifier "nulls not distincts" added to:

[x] CREATE TABLE - ADD COLUMN
[x] CREATE TABLE - ADD UNIQUE CONSTRAINT
[x] CREATE INDEX
[x] ALTER TABLE - ADD COLUMN
[x] ALTER TABLE - ADD UNIQUE CONSTRAINT

Also:

added unit tests
added docs description

@koskimas @igalklebanov Hi, this is my first pull request here and it's still in progress. Could you please review to ensure I'm heading in the right direction? I've added a new option to addUniqueConstraint because it seemed a bit challenging to modify a constraint once it's already been added (or perhaps I just didn't find a way to do so). Also, I've changed the documentation on the site, as I couldn't find an example of createTable when I needed it personally.
I'll willingly make any changes. Thanks!

@igalklebanov Thanks for your comments. Implemented/fixed everything, ready to review.


[CS] Fixes #2208 Add CheckConstantExpressionDefinedInConstructOrSetupRule

I think assignment inside if condition should be skipped.

I skipped if parent of assign is not a ClassMethod, but Stmt like If_, this condition may happen when a need of fallback value like in
https://github.com/symplify/symplify/blob/2b6f0598c5a920d97424322259e8de0aef46f6dd/packages/easy-coding-standard/packages/configuration/src/Configuration.php#L217-L219

All checks have passed 🎉 @TomasVotruba it is ready for review.

It seems the variable definition should be allowed if variable will be used in next statement -> skip

I've added handling to allow when Assign variable is used in next statement.

weird, got many unrelated phpstan error, I will re-check.

Finally, All checks have passed 🎉 @TomasVotruba it is ready for review.

I've added handling useless used in next statement like this:
class DisallowInsideOtherMethodNextDeadCode
{
    public function otherMethod()
    {
        $a = __DIR__ . '/static.txt';
        $a;
    }
}

❌
As next statement is not inside other statement, so it disallowed. The allowed one is when there is next used but inside other statement:
class AllowInsideOtherMethodUsedAfterDefinition
{
    public function otherMethod()
    {
        $a = __DIR__ . '/static.txt';
        $this->run($a);
    }
}

👍

All checks have passed 🎉 @TomasVotruba I think it is ready.


Update IC Candid Files

Motivation
The Internet Computer APIs have updated.
Changes

Updated the interface description files for the Internet Computer.
Updated the javascript bindings for the latest IC interface.

Tests

[ ] Please check the API updates for any breaking changes that affect our code.

Even if they pass, we might want to have some backwards compability test.
For example, if a field changes type, none of the tests here would pass, but then when we install the version in NNS Dapp it could break the app.
I'm not sure this is a priority at the moment.
Closing for now until ic-mgt and ckbtc are updated manually fixing the issues.