rebase: update to latest snapshotter

this commit update the snapshotter client to v6.1.0
Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>

Added ok-to-test as there is no other jobs in the CI.

Added ok-to-test as there is no other jobs in the CI.
@humblec
It was decided to add ok-to-test label after a pr has the required approvals, in a FIFO fashion.

Can you mention go version update in commit too ?
and do we need to update go version here too https://github.com/ceph/ceph-csi/blob/devel/docs/development-guide.md#workspace-and-repository-setup?

Added ok-to-test as there is no other jobs in the CI.
@humblec
It was decided to add ok-to-test label after a pr has the required approvals, in a FIFO fashion.

Can you mention go version update in commit too ?

done.

and do we need to update go version here too https://github.com/ceph/ceph-csi/blob/devel/docs/development-guide.md#workspace-and-repository-setup?

not really. even if its 1.17 its compatible,

@nixpanic looks like mergify configuration is not working as expected, mergify added ok-to-test label at wrong time


Created S3 bucket to store keys

I guess the lifecycle_rule - enabled tag takes boolean only value? lifecycle_rule { id = "quarterly_retention" prefix = "quarterly/" enabled = true

Hi @krupalb-dev, this has just been copied from here https://github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket which was suggested by mod plaftorms.

I guess the lifecycle_rule - enabled tag takes boolean only value? lifecycle_rule { id = "quarterly_retention" prefix = "quarterly/" enabled = true

Hi @krupalb-dev, this has just been copied from here https://github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket which was suggested by mod plaftorms.

Ok, I've approved it. Hopeful this will work then...


(chore) Update help text on Essential Qualifications input

Trello card URL:
https://trello.com/c/QZ4B12A7/491-essential-qualifications-text-revision
Changes in this PR:
Updated help text on Essential Qualifications input on job creation form
Screenshots of UI changes:

 Essential qualifications text revision


Update api-management-howto-log-event-hubs.md

added json request body for REST API call for creating logger using managed identity.

@kuheli12
Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request. Thanks!
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@microsoft-github-policy-service agree company="Microsoft"


Refactor questions to final version

What is the purpose of HTML?
a) To create the layout and structure of a website
b) To add style and design to a website
c) To create interactive elements on a website
d) To manage and organize the backend of a website
Correct Answer: a) To create the layout and structure of a website
What is the purpose of CSS?
a) To create the layout and structure of a website
b) To add style and design to a website
c) To create interactive elements on a website
d) To manage and organize the backend of a website
Correct Answer: b) To add style and design to a website
What is the purpose of JavaScript?
a) To create the layout and structure of a website
b) To add style and design to a website
c) To create interactive elements on a website
d) To manage and organize the backend of a website
Correct Answer: c) To create interactive elements on a website
What is the purpose of jQuery?
a) To create the layout and structure of a website
b) To add style and design to a website
c) To create interactive elements on a website
d) To simplify the use of JavaScript on a website
Correct Answer: d) To simplify the use of JavaScript on a website.


I wanna put submodule or binary of flatbuffer

I stopped because it would be redistribution but it is inconvenience...

I already finished this issues(#13)
I have to integrate flatbuffer into ThirdParty of UnrealEngine.

already apply master branch (https://github.com/KirisameMarisa/BocchiTracker/pull/23)


All src packages are broken.

For Example, at boost_program_options-src.targets, defined macro is invalid.
<PreprocessorDefinitions>BOOST_PROGRAM_OPTIONS-SRC_NO_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>

BOOST_PROGRAM_OPTIONS-SRC_NO_LIB should be BOOST_PROGRAM_OPTIONS_NO_LIB.

https://github.com/sergey-shandar/getboost/blob/f1b602fbb784dd041d9b7f7647c08d8e75a1f6cf/builder/builder/SrcPackage.cs#L84-L105
All src packages are define macro "BOOST_-SRC_NO_LIB".

Should be fixed in 1.62.0


Change password length of OTP failed

While changing OTP password length i'm receiving failed due formatting

It was fixed earlier today in https://github.com/pocketbase/pocketbase/issues/5617.
I'll push a rc3 prerelease sometime tomorrow (eventually with fix for https://github.com/pocketbase/pocketbase/discussions/5623#discussioncomment-10873639).


Default ROS version of master branch

The ROS version of master branch seems compatible with ROS-melodic. I think you should specifiy the compatible version on the e-manual.
Those who use ROS-kinetic would face small trouble using gazebo package if they follow the install instruction of e-manual

Hi @mch5048
Sorry for the late reply, and thanks for using OpenManipulator.
The master branch version of open_manipulator_simulations is successfully worked on ROS-kinetic environment too. What is the problem you are talking about? please tell me.

@gpwhd07 Sorry for the late reply too :+1:  .
Actually, the problem was related to missing PID gain configuration for the gazebo controller.
I had installed all the packages from the master branch, and configured the system for the gazebo simulation.
However, at the time I launched gazebo controller threw errors of missing pid gains for the simulated controller, which should have been specified at the yaml file.
It seems related to this commit :
https://github.com/ROBOTIS-GIT/open_manipulator_simulations/commit/6acba54eb738533a9f19fecd35e4d6cf15a4e65d#diff-6a539fac0eefe3b88e8e6ba5c1fec0e2,
Because the original config file I had at that time had no pid gains, so I had to copied the values from the kinetic-devel branch.
Anyhow, It seems that the problem has been solved.


Feature Addition in Note Editing Activity

Addition of option of ITALIC font in Note-Editing Activity.
Adding color palette for the text in the Note-Editing Activity.
Creating a Home Button for DISCARDING the changes the returning back to Home Page.(Landing Page)
Improvement in the UI/ / Design of Note Editing Activity.
Screenshots:

Good Work! Thankyou.


Support for U256 and I256 field types

Is your feature request related to a problem? Please describe.
I am dealing with cryptocurrencies and need support for UInt256. Without this support, I can’t even ingest JSON with values larger than U/I64.
Describe the solution you'd like
Support for U/I256 integer types
Describe alternatives you've considered
I tried ingesting values as text but that resulted in an ingestion error because it is not text
Additional context
N/A

I tried ingesting values as text but that resulted in an ingestion error because it is not text

If you ingest it as text, you need to quote it. JSON doesn't have 256 bit numbers.

Would it be possible for the system to cast the values to string instead of requiring users to modify all their data to use Quickwit?
Sent from my phone

On Aug 3, 2022, at 06:02, PSeitz @.***> wrote:

I tried ingesting values as text but that resulted in an ingestion error because it is not text
If you ingest it as text, you need to quote it. JSON doesn't have 256 bit numbers.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

If you put u256 as a JSON number and not as text, you are probably doing something wrong. There is barely any support for u256 in general.

@machete-michael: can you give us an example of a document you are trying to ingest?

Hi François,
Thank you for reaching out but please go ahead and close the ticket.
I deal with systems that handle UInt256 and I’ll simply process these values in those systems and not involve Quickwit.
You could also easily come up with a test JSON with a value that is greater than what’s supported by U/I64 to replicate this problem.
Cheers,
Michael

On Aug 3, 2022, at 09:14, François Massot @.***> wrote:

@machete-michael: can you give us an example of a document you are trying to ingest?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

No pb, but maybe you saw a bug that I cannot reproduce.
Let me explain you what I did to reproduce:

Create an index with dynamic mapping
Insert 2 documents with a huge integer either set as int or string:

[
{
   "cart": [
      {
          "product_description": "Cherry Pi",
          "product_id": 2.2010202020202104e68
      }
    ]
},
{
  "cart": [
     {
        "product_description": "Cherry Pi",
        "product_id": "220102020202021011012039120299292991191992929292999992922299299393929"
      }
  ]
}
]

With that, I tried a few queries and saw a few things
Query on float is broken
curl -XGET http://localhost:7280/api/v1/my_dynamic_index/search\?query\=car.product_id:2.20
{
  "InvalidQuery": "The field '_dynamic' does not have positions indexed"
}%

I cannot do a query on the exact string "Cherry Pi" as it is immediately considered as a phrase query. This is not what I want as the dynamic mapping is using the default raw tokenizer.
curl -XGET http://localhost:7280/api/v1/my_dynamic_index/search?query=car.product_id:%22Cherry\sPi%22
{
  "InvalidQuery": "The field '_dynamic' does not have positions indexed"
}
```

I had a look on the JSON spec. While it does not limit the number range per se, it does discourage large number ranges for interoperability reasons.
https://datatracker.ietf.org/doc/html/rfc7159#section-6

This specification allows implementations to set limits on the range
and precision of numbers accepted.  Since software that implements
IEEE 754-2008 binary64 (double precision) numbers [IEEE754] is
generally available and widely used, good interoperability can be
achieved by implementations that expect no more precision or range
than these provide, in the sense that implementations will
approximate JSON numbers within the expected precision.  A JSON
number such as 1E400 or 3.141592653589793238462643383279 may indicate
potential interoperability problems, since it suggests that the
software that created it expects receiving software to have greater
capabilities for numeric magnitude and precision than is widely
available.
Note that when such software is used, numbers that are integers and
are in the range [-(253)+1, (253)-1] are interoperable in the
sense that implementations will agree exactly on their numeric
values.

Yup, agreed. I could totally be doing something wrong.
Please close ticket if QuickWit doesn’t want to entertain this idea.
Thank you.
Sent from my phone

On Aug 3, 2022, at 06:25, PSeitz @.***> wrote:

If you put u256 as a JSON number and not as text, you are probably doing something wrong. There is barely any support for u256 in general.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

Yup… I’ve already submitted a separate bug, #1829, on what you described here.
Thanks again for looking into it.
Sent from my phone

On Aug 3, 2022, at 17:30, François Massot @.***> wrote:

No pb, but maybe you saw a bug that I cannot reproduce.
Let me explain you what I did to reproduce:
Create an index with dynamic mapping
Insert 2 documents with a huge integer either set as int or string:
[
{
"cart": [
{
"product_description": "Cherry Pi",
"product_id": 2.2010202020202104e68
}
]
},
{
"cart": [
{
"product_description": "Cherry Pi",
"product_id": "220102020202021011012039120299292991191992929292999992922299299393929"
}
]
}
]
With that, I tried a few queries and saw a few things
Query on float is broken
curl -XGET http://localhost:7280/api/v1/my_dynamic_index/search?query=car.product_id:2.20
{
"InvalidQuery": "The field '_dynamic' does not have positions indexed"
}%
I cannot do a query on the exact string "Cherry Pi" as it is immediately considered as a phrase query. This is not what I want as the dynamic mapping is using the default raw tokenizer.
curl -XGET http://localhost:7280/api/v1/my_dynamic_index/search?query=car.product_id:"Cherry\sPi%22
{
"InvalidQuery": "The field '_dynamic' does not have positions indexed"
}
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.


Feature/example advance2

Description

Added new code example Advance 2 and README documentation for multiples VM creation with for_each block.
Change overview (tick true):

[ ] This introduces backward incompatible changes
[X] This adds a new backward compatible Feature
[ ] This fixes a Bug

Version information:

Previous Version: 2.1.0

Next Version based on Semantic Versioning (see above): 2.1.0

How Has This Been Tested?

[X] Apply of all examples was successfull
[X] Apply of all test was successfull

Checklist:

[X] I have run tests and documented them above
[X] I have performed a self-review of my own code
[X] I have updated the documentation
[X] I have updated the CHANGELOG

I don't see the point of the advanced2 example. It doesn't show any features of the module. It just showcases how to use a for_each. I don't think examples of a module is the right place to showcase a terraform function.
In my opinion examples should only showcase features of the module.

So then ?


#664 Amazon S3 Cache updated

Code for issue #664 to include support for the Amazon S3 Cache.
Builds within Visual Studio 2017 . I've tested using the ImageProcessor.TestWebsite and change the media directory to be /amazon. Within security.config is commented out configuration for S3 and similarly a cahce.s3.config file exists within the chache configuration in that.
Let me know what the next steps are.

Apologies for the slow response. I'll have a look at this ASAP.

Hey @AndyFelton
I'm gonna do this slightly differently than I would normally and merge the code in without my normal review.
I'll then do any cleanup and stylistic changes and I'd like you to give it one last pass before I set up a nuget package for it.
That sound OK?

Sounds good to me!
On 31 August 2018 at 00:49, James Jackson-South<EMAIL_ADDRESS>wrote:

Hey @AndyFelton https://github.com/AndyFelton
I'm gonna do this slightly differently than I would normally and merge the
code in without my normal review.
I'll then do any cleanup and stylistic changes and I'd like you to give it
one last pass before I set up a nuget package for it.
That sound OK?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JimBobSquarePants/ImageProcessor/pull/673#issuecomment-417504011,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ5q8nHpXAT_hvnUlXquzfvDkyxrvPkkks5uWHoXgaJpZM4Uhqyg
.

--
Andy Felton (BEng)
Technical Director

Nemisys
www.nemisys.uk.com
E-mail<EMAIL_ADDRESS>Support<EMAIL_ADDRESS>Tel: +44 (0)844 706 9665
Fax: +44 (0)<PHONE_NUMBER>


chore: make sure preprocess_row include row number

Description: make sure preprocess_row include row number. It is necessary for detecting duplicate user_id on the first occurence.
JIRA: AU-44
Testing instructions:

[ ] Pass make test

Reviewers:

[ ] tag reviewer
[ ] tag reviewer

Merge checklist:

[ ] All reviewers approved
[ ] CI build is green
[ ] Version bumped
[ ] Changelog record added
[ ] Documentation updated (not only docstrings)
[ ] Commits are squashed
[ ] Merge and release this before upgrade this https://github.com/edx/edx-bulk-grades/pull/88

Post merge:

[ ] Create a tag
[ ] Check new version is pushed to PyPI after tag-triggered build is
finished.
[ ] Delete working branch (if not needed anymore)

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.
@edx/masters-devs-gta

Okay, here's what I've got.
process_file:
try:
   self.preprocess_row(row, rownum)
catch TypeError:
   self.preprocess_row(row)

And then I believe preprocess_row can stay the same, but make sure to also include tests for subclasses that only have the old signature. I'd also like to get some other opinions on this. This is a small change but really hits at some things we've been trying to think about more recently. How should this be documented? Should we add a warning? Should we, instead of making the change above, simply make this a breaking change? Should we have some sort of versioning on this? All valuable questions

Okay, here's what I've got.
process_file:
try:
   self.preprocess_row(row, rownum)
catch TypeError:
   self.preprocess_row(row)

And then I believe preprocess_row can stay the same, but make sure to also include tests for subclasses that only have the old signature. I'd also like to get some other opinions on this. This is a small change but really hits at some things we've been trying to think about more recently. How should this be documented? Should we add a warning? Should we, instead of making the change above, simply make this a breaking change? Should we have some sort of versioning on this? All valuable questions

I just made some logic change. It should not propagate the effect to the subclasses. The benefit is that I can find the row number using result_data.

Do not need to change this.


Introducing pipedstat model

What this PR does / why we need it:

Mark PipedStats model as deprecated
Introduce PipedStat model which wraps piped stat data with timestamp value. The timestamp value will be used to filter out outdated piped stat on expose
Remove TTLHashCache constructor, since we will not expire value of hashkey by the cache itself but make it in application layer (address it later).

Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

typo in the PR title

Intruducing

/todo skip

Cool
/lgtm

/approve


GUVNOR-2192 : Guided Decision Table V&V - Finding Deficiency

Deficiency checks.
Several bug fixes with improved test coverage.
Added one to many check type. For situations where an issue on a single row depends on all the other rows. Not sure if this will be needed for anything else than defiency, but making the check allows the Checks class to automatically update the checks as cell values change.

http://github.com/droolsjbpm/drools-wb/commit/71e104d15


suggest and some question

suggest
I looked the video and i think the leetcode request ( which info of test) is should'nt pop up it's should more flat with code for read and code is working at sametime.
question

is the data leetcode autoupdate?
How process is going done? ( any big update or something cause i look your extension is really awesome but i not start leetcode yet just in plan)

Thank you and keep it up. Good job guys

I understand, maybe a new layout where you can code and read the question together. Will work on this later when I can.
It works the same way as how the Leetcode website works. The data are parsed and shown each time from the Leetcode API and All the best on your Leetcode journey.
Consider a :star: if you like this plugin :)


Deprecation of Get-CsUserSession

Updated documentation to include deprecation of this cmdlet

Docs Build status updates of commit 8a8a052:
:clock10: Full build: the average full build time is 14 min(s) 41 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 8a8a052:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsUserSession.md
:x:Error

Details

skype/skype-ps/skype/Get-CsUserSession.md

[Error]

Failed to parse this MAML markdown file due to :2:(0) '## Deprecation Notice
'
 Unexpected header name Deprecation Notice, please use PlatyPS to do content validation

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@amareshbAtMicrosoft - looks like there are some errors. Here is the schema that the markdown is checked against: https://github.com/PowerShell/platyPS/blob/master/platyPS.schema.md  I suspect it might be the ## of adding a new heading.. maybe better to move the notice to description and remove the heading # symbols.

@Haider<EMAIL_ADDRESS>- wondering if you are tracking this ?
Outlookhttps://aka.ms/qtex0l for iOS

From: Ken Withee<EMAIL_ADDRESS>Sent: Tuesday, May 5, 2020 1:29:25 PM
To: MicrosoftDocs/office-docs-powershell<EMAIL_ADDRESS>Cc: Amaresh Bikki<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/office-docs-powershell] Deprecation of Get-CsUserSession (#5456)
@amareshbAtMicrosofthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FamareshbAtMicrosoft&data=02|01|amareshb%40microsoft.com|d52cbc457eeb42b1a60008d7f13300ac|72f988bf86f141af91ab2d7cd011db47|1|0|637243073626056548&sdata=bOo9s%2BK2TQIf4O36zYseBsJtVThtYQuZBIcZs4699vY%3D&reserved=0 - looks like there are some errors. Here is the schema that the markdown is checked against: https://github.com/PowerShell/platyPS/blob/master/platyPS.schema.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FplatyPS%2Fblob%2Fmaster%2FplatyPS.schema.md&data=02|01|amareshb%40microsoft.com|d52cbc457eeb42b1a60008d7f13300ac|72f988bf86f141af91ab2d7cd011db47|1|0|637243073626066546&sdata=qwpfWmyZ%2BJ3OW2Ex6iI3%2Fd%2FDVZGlvwtB4uiMxFQexT4%3D&reserved=0 I suspect it might be the ## of adding a new heading.. maybe better to move the notice to description and remove the heading # symbols.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Foffice-docs-powershell%2Fpull%2F5456%23issuecomment-624288899&data=02|01|amareshb%40microsoft.com|d52cbc457eeb42b1a60008d7f13300ac|72f988bf86f141af91ab2d7cd011db47|1|0|637243073626066546&sdata=NJilj69LqsquxKtFw7Hf6Myo%2BG7yFUVVa8CtKLDc31M%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGDU55SZAGZS2A7VLBXUXITRQBZKLANCNFSM4MXZXTYQ&data=02|01|amareshb%40microsoft.com|d52cbc457eeb42b1a60008d7f13300ac|72f988bf86f141af91ab2d7cd011db47|1|0|637243073626066546&sdata=sT%2Bvs%2B0v9pJCsLz8861PDDsacUy1EfXE9p1NL8tb5IA%3D&reserved=0.

Yup, on my radar... I’ll find time in Tom’s calendar this week to understand how to update docs. Thanks for the heads up!
Sent from my mobile device

From: Amaresh Bikki<EMAIL_ADDRESS>Sent: Tuesday, May 5, 2020 1:32:20 PM
To: MicrosoftDocs/office-docs-powershell<EMAIL_ADDRESS>MicrosoftDocs/office-docs-powershell<EMAIL_ADDRESS>Haider Razi<EMAIL_ADDRESS>Cc: Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/office-docs-powershell] Deprecation of Get-CsUserSession (#5456)
@Haider<EMAIL_ADDRESS>- wondering if you are tracking this ?
Outlookhttps://aka.ms/qtex0l for iOS

From: Ken Withee<EMAIL_ADDRESS>Sent: Tuesday, May 5, 2020 1:29:25 PM
To: MicrosoftDocs/office-docs-powershell<EMAIL_ADDRESS>Cc: Amaresh Bikki<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/office-docs-powershell] Deprecation of Get-CsUserSession (#5456)
@amareshbAtMicrosofthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FamareshbAtMicrosoft&data=04|01|Haider.Razi%40microsoft.com|85da2ee5616048c9299d08d7f1336901|72f988bf86f141af91ab2d7cd011db47|1|0|637243075430272016|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|-1&sdata=RbFItMTkMgkC5eTgvHv9H8cppbPnF66kz61EQet2Xv8%3D&reserved=0 - looks like there are some errors. Here is the schema that the markdown is checked against: https://github.com/PowerShell/platyPS/blob/master/platyPS.schema.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FplatyPS%2Fblob%2Fmaster%2FplatyPS.schema.md&data=04|01|Haider.Razi%40microsoft.com|85da2ee5616048c9299d08d7f1336901|72f988bf86f141af91ab2d7cd011db47|1|0|637243075430282012|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|-1&sdata=8YTUCZj%2BZWT5%2FvRMkpwx%2FOdBreBR3bDQTW8kkQBQEF8%3D&reserved=0 I suspect it might be the ## of adding a new heading.. maybe better to move the notice to description and remove the heading # symbols.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Foffice-docs-powershell%2Fpull%2F5456%23issuecomment-624288899&data=04|01|Haider.Razi%40microsoft.com|85da2ee5616048c9299d08d7f1336901|72f988bf86f141af91ab2d7cd011db47|1|0|637243075430292001|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|-1&sdata=n5czkbozgJLCsDz5%2BCt8HZKev9nIzLYduyIhQoZSLSo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGDU55SZAGZS2A7VLBXUXITRQBZKLANCNFSM4MXZXTYQ&data=04|01|Haider.Razi%40microsoft.com|85da2ee5616048c9299d08d7f1336901|72f988bf86f141af91ab2d7cd011db47|1|0|637243075430292001|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|-1&sdata=ZDzL6eKjswkbNjPRRt6z7C%2BOzeCYNO6rFodpKOTibWg%3D&reserved=0.

Docs Build status updates of commit 6d265a9:
:clock10: Full build: the average full build time is 16 min(s) 1 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 6d265a9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsUserSession.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d1ef264:
:clock10: Full build: the average full build time is 16 min(s) 3 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit d1ef264:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsUserSession.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


yt.publish_date returning blank value

I'm currently running the latest version (6.6.2) but now any videos that I try to process, the yt.publish_date property always returns a blank value instead of the datetime object as before. I'm also using oauth if that makes any difference.

update to the latest version and test, show us the code you are using to test

Upgraded to pytubefix 6.8.1
Ran code:
yt = YouTube("https://www.youtube.com/watch?v=YL9apblSQ-s", use_oauth=True, allow_oauth_cache=True)
print(yt.publish_date)

Output:
None

I just used it without authentication
and it worked normally:
>>> from pytubefix import YouTube
>>>
>>> yt = YouTube("https://www.youtube.com/watch?v=YL9apblSQ-s")
>>> print(yt.publish_date)
2024-07-14 09:00:17-07:00
>>>

So strange. Even without authentication I still get "None".
Is there a way to print the raw output to see all the data that is being returned from the query? All other properties seem to load fine except for the publish_date.
Also, I'm running my application on a VPS physically located in Germany. Not sure if geographically there are any differences in what YouTube returns.

I tested here also, without authentication, with pytubefix 6.8.1, and it works normally.
from pytubefix import YouTube

yt = YouTube("https://www.youtube.com/watch?v=m2caY5CL63E")
print(yt.publish_date)

output:
2024-07-23 08:00:54-07:00
Maybe the IP of your VPS was blocked by Youtube.
If you do many requests, likely will be blocked. To overcome the blocking you have to use proxies.

For whatever reason, the HTML output comes through different just for the date value. I updated your publish_date function within the extract.py file to properly handle both versions and now it works perfectly...
def publish_date(watch_html: str):
    """Extract publish date and return it as a datetime object
    :param str watch_html:
        The html contents of the watch page.
    :rtype: datetime
    :returns:
        Publish date of the video as a datetime object with timezone.
    """
    try:
        # First attempt to find "datePublished"
        result = re.search(
            r'(?<=itemprop="datePublished" content=")\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}[+-]\d{2}:\d{2}',
            watch_html
        )
        if result:
            return datetime.fromisoformat(result.group(0))

        # If "datePublished" is not found, attempt to find "publishDate"
        result = re.search(
            r'(?<="publishDate":{"simpleText":")\w+ \d{1,2}, \d{4}',
            watch_html
        )
        if result:
            return datetime.strptime(result.group(0), '%b %d, %Y')
    except AttributeError:
        return None


Support multiple watch directories

See #28 for discussion.
The tentative conclusion is to allow watch_dir to be a list of directories, each of which the plugin will check and watch if valid (silently ignoring invalid / nonexistent directories).
The plan is to work on this on the plugin's develop branch, which has recently gotten a bunch of improvements thanks to #27 and will be merged into master as soon as I'm a little more confident about null-ls.

See #28 for discussion.

Continuing from the previous discussion. I think the config option would work well for a standalone repo but will it be a robust solution? Suppose I am working on a mono-repo and this repo would have many directories consisting of different features. Then one would need to mention all the directories in the config option and as the number of directories would increase so would the need to change the config. Now in a team, one might work on multiple mono-repos and that would mean cluttering up the config and every time one would need to change the config if a directory is renamed or moved. I think the config option should be set up just once and it should just work irrespective of the project structure.

I feel like the cleanest solution for complex situations involving multiple mono-repos would be to have users set watch_dir to "", then have the watcher respect .gitignore files, since they're as close to universal as we can get. (This would be in addition to the option to set watch_dir as a list, which I think is a good solution for small-to-medium projects.)
Plenary's scandir module has a respect_gitignore flag, so we could use that to get all non-ignored directories at the top level, then run a separate watcher for each. We'd still have to test the performance impact of running multiple watchers (and I'd appreciate help with this, since I don't personally work on any large projects), but I think this would be the most lightweight option.
I'm also thinking of eventually spinning off the file watching functionality into a separate library-style plugin, so I think that would be the most flexible solution for other use cases, too. What do you think?

Yes, you're right. Using .gitignore would be as close to a universal solution as possible.
I think the watch_dir option should always be set to "" and if a user chooses to watch specific directories then he/she could just provide the directories in a list. Since almost all projects would use .gitignore, I don't think the option to provide a list of directories is needed but it should be there as an option.
I can help with user testing but I don't work on very large repos but I do work on a mono repo which I could use to test the plugin.

Hmm, you're right that it could actually work as sensible default. Maybe watch_dir could then be a fallback option that accepts a single directory or list of directories to watch if the root directory doesn't have a .gitignore file, which would work for small projects that aren't set up as Git repositories.
I'm prototyping this locally and will update the issue when the feature is available to test, but it's working pretty seamlessly so far (I'm using my own projects and this repo to test it). I also want to put in a PR to fix a couple of Plenary bugs and make sure .gitignore works properly with directories.

The Plenary maintainers moved fast on the PR, so I was able to get this up and running for now, and it's available on the develop branch.
It's working well on the sample repo and on my work projects, but the question is how it will perform when watching 2+ directories simultaneously. Could you give it a try when you can? If you set debug = true in your plugin setup function, you'll be able to see in :messages if the watcher is active on the expected directories, too.

it is currently watching all the directories but it's including node_modules as well. However, formatting isn't working for me.

Hmm, that's strange. What is the format of your .gitignore like? I think think the Plenary module we're using doesn't support complex patterns, but node_modules, /node_modules, and node_modules/ should all work.
For formatting: the null-ls integration hooks into the Neovim LSP client, so if you've set enable_formatting = true, it should format the current file when you run vim.lsp.buf.formatting(). If that doesn't work, could you open up another issue so we can troubleshoot?

My .gitignore has /.node_modules.
Do I need to install the null-ls plugin? If so, what do I put in the sources option while setting it up?

Does the root dir resolve correctly in your project? You should see a message that says attempt to watch root dir ... in :messages. Also, are you running the latest version of Plenary? (If you're unsure, I would comment it out, run your plugin manager's clean command, then reinstall.)
If those don't work, could you try cloning the sample-monorepo and verifying that it correctly ignores node_modules? If so, I think there's something about your project setup that we have to account for.
File watching doesn't depend on null-ls, but formatting does. You'll need to install the plugin, then add require("null-ls").setup {} somewhere in your config. This plugin should take care of the rest.

Also, are you running the latest version of Plenary? (If you're unsure, I would comment it out, run your plugin manager's clean command, then reinstall.)

After updating Plenary, it successfully ignores node_modules.

If the root dir looks okay, could you tell me where node_modules is located relative to the root? (I don't know anything about monorepo structure, but I'm working under the assumption that node_modules is in the root dir.)

Not all monorepo setup will hoist the node_modules folder to the root. Lerna uses a root node_modules and also every user defined package has a node_modules folder.

File watching doesn't depend on null-ls, but formatting does. You'll need to install the plugin, then add require("null-ls").setup {} somewhere in your config. This plugin should take care of the rest.

Formatting still doesn't work. Using the default option prettier.

Thanks for confirming! The monorepo issue is concerning (we'll probably have to recursively check for sub-root directories within the root directory and scan each), but I'm going to wait until it comes up to deal with it and consider this closed for now.
For formatting, could you open up another issue and post your full config for this plugin and for null-ls? Thank you for your help and patience!


disable system metrics with special value for interval

Describe the problem you are trying to solve
As of now, monitoring is enabled/disabled by including a key called metrics_interval_s in the corresponding section. It is difficult to include or remove a key completely in deployment configurations based on conditions. It would be much easier for the values to be altered, though.
Describe the solution you'd like
If the metrics can be enabled/disabled by specifying specific value for the key, it would be very easy to enable/disable them in different deployment configurations. ex: negative value may be used to disable metrics as negative values for interval doesn't make sense.
Notes

null should disable system metrics


sdba - Is OOP really necessary?

I am implementing Cannon's MBCn adjustment and I am confronted to an adjustment object that can not follow the train-adjust scheme : it needs to do both in a single step. Furthermore, I have part of the adjustment that could be performed by an object that doesn't need a train step. This adds to the ExtremeValues adjustment object that is re-implementing the train and adjust method (so like 95% of its base class...).
I think I have painted myself in a corner with this OOP structure that is BaseAdjustment. Internally, we still need objects, to remember parameters and to have common methods (like the json parsing stuff).
I am suggesting to move to 2 types of objects (or more if needed):

Classic Adjustment following the train-adjust scheme, but train would become a class method returning an instance that can perform adjustments.
No-train adjustments : with a single adjust static method. No object is ever returned even if the code uses one internally. This is for methods where the training is not separable from the adjust, or where there is enormous computational efficiency to be gained when doing both together.

All current algorithms would loose need for an __init__, at least from the point of view of the user. This will divide the kwargs in 2 categories (as it is now, except for ExtremeValues). So, for most cases this is merely a merge between the init and the train step, but I think it will ease my implementing and will go in the direction of Patrick's advice : Do no implement "published methods", but provide the modular tools to replicate those.
Example, using NPDFTransfer which is part of the MBCn process.
from xclim.sdba import QuantileDeltaMapping, NPDFTransfer

## Before:
QDM = QuantileDeltaMapping(n_quantiles=10, kind='+', group='time.dayofyear')
QDM.train(ref, hist)
scen = QDM.adjust(sim, interp='linear')

NPDFT = NPDFTransfer() # No params really
# This step doesn't really need both and the training data has the same shape as either, so it's not efficient
NPDFT.train(ref, hist)
scen = NPDFT.adjust(sim)

## After
QDM = QuantileDeltaMapping.train(ref, hist, n_quantiles=10, kind='+', group='time.dayofyear')
scen = QDM.adjust(sim, interp='linear')

scen = NPDFT.adjust(ref, sim)

What do our power users @RondeauG  @dgergel and @huard think?

No objection.

Also have no objection - I think this all sounds good.


Add documentation for operator version

Description of the change:
Add documentation for generated operator version.
Motivation for the change:
Motivation is to add documentation on the operation version so users of the SDK know what this version is. Happy to change wording if needed.

Thanks for the review @camilamacedo86. Will push an update to the doc comment later today.

@camilamacedo86 - updated Version comment.

Looks like travis build failed with a goveralls failure:
$ $GOPATH/bin/goveralls -service=travis-ci -coverprofile=coverage.out -repotoken=$COVERALLS_TOKEN
Bad response status from coveralls: 422
{"message":"service_job_id (684389024) must be unique for Travis Jobs not supplying a Coveralls Repo Token","error":true}
@estroz is it possible to re-run the build?

Hi @bvwells,
Just rebase it with the master. It started to occurs when the project is outdated. It might be solved with an upgrade in the module used.  I will track this need an issue in the repo. Really tks.

Thanks for the merge @camilamacedo86!


Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'attributes')

Hello my friend. not time ago. I have a problem. I had to completely setup my instance again. Server crashed. Fortunately I had a Backup. But when adding the card i get error in subject line.#
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'attributes')
    at sipjs-card.ts:442:97
    at Array.map (<anonymous>)
    at oe.render (sipjs-card.ts:440:50)
    at oe.update (lit-element.js:6:304)
    at oe.performUpdate (reactive-element.js:6:4816)
    at oe.scheduleUpdate (reactive-element.js:6:4463)
    at oe._$E_ (reactive-element.js:6:4371)

my config:
- type: custom:sipjs-card
  server: home-access.ddns.me
  port: "443"
  button_size: '100'
  custom:
    - name: Doorbell
      number: "8001"
      icon: mdi:doorbell-video
      entity: sensor.8001_state
      camera: camera.doorbell
    - name: Softphone Thorsten (Test)
      icon: mdi:cellphone-basic
      number: "8002"
  # dtmfs:
  #   - name: dtmf1
  #     signal: 1
  #     icon: mdi:door
  ringtone: /local/asterisk/Doorbell-ring-chime.mp3
  ringbacktone: /local/asterisk/backtone.mp3
  video: true
  state_color: true
  auto_answer: false
  hide_me: true
  custom_title: InterPhone
  extensions:
    - person: person.dashboard
      name: Dashboard
      extension: "8003"
      secret: "8003"
      icon: mdi:desktop-mac-dashboard
      entity: sensor.8003_state
    - person: person.laptop
      name: Laptop
      extension: "8004"
      secret: "8004"
      icon: fas:laptop
      entity: sensor.8004_state
      # camera: camera.doorbell
    - person: person.phone_thorsten
      name: SoftPhone Thorsten
      extension: "8002"
      secret: "8002"
      icon: mdi:cellphone-basic
      entity: sensor.8002_state
    # - person: person.phone_thorsten
    #   name: Phone Thorsten Companion App
    #   extension: "8006"
    #   secret: "8006"
    #   icon: mdi:cellphone-basic
    #   entity: sensor.asterisk_extension_8006
      # camera: ''
  # buttons:
  #   - name: Unlock Door
  #     entity: lock.main_door
  #     icon: mdi:door-closed-lock

any idea? :)

I got behind it.... if an extension is 9in the config where no extension is created by the integration. Let this open for further questions. But an error message would be nice

I also have this error I don't use the integration I have my own asterisk.
did you manage to solve it?


Installer timeout variable on if app opened from user or boot

Plumbs timeout arg from desktop app to native installer to keybase install.

The native installer accepts a timeout arg
The keybase install command accepts a timeout arg
The desktop app sends install timeout as 30s if opening from login (boot)
Changing default KBTask timeout to 60s. This is large (needs to be > than install timeouts) but it should never be hit and only happens if something catastrophic goes wrong.

There is also a change in this PR which removes some code on service install where we checked if install was actually needed and skipped it if not. This loaded the service status, did version and plist compares to see if install was needed. Since we start/stop everything on app start/quit, these checks are unnecessary (install is always needed). We can remove this code, and services will always install on startup. This makes things simpler and easier to reason about. If somehow services were running on install, this will re-install, which is ok too.

@chromakode ?
cc @keybase/react-hackers

Fixed issues from review


RetryErroneousIntegrationTest.java:11: Implement...

The puzzle 10-f8a4ea3e from #10 has to be resolved:
https://github.com/iakunin/codexia-bot/blob/46e2bc468674962cfad1666904100c6ebc744c43/src/test/java/dev/iakunin/codexiabot/hackernews/cron/RetryErroneousIntegrationTest.java#L11-L11
The puzzle was created by Maksim Iakunin on 20-Apr-20.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 10-f8a4ea3e has disappeared from the source code, that's why I closed this issue.


Bug fix for truncated-normal

Description
Fix bug where I add the mean before multiplying by the standard deviation when computing the truncated mean.

@AzizZayed Can you rebase this on top of master?

@AzizZayed  Please rebase your code

Codecov Report

Merging #1022 (6e44967) into master (fd84636) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1022      +/-   ##
============================================
- Coverage     70.00%   69.97%   -0.04%
+ Complexity     5109     5108       -1
============================================
  Files           504      504
  Lines         22617    22617
  Branches       2372     2372
============================================
- Hits          15833    15826       -7
- Misses         5517     5528      +11
+ Partials       1267     1263       -4

Impacted Files
Coverage Δ

...pi/src/main/java/ai/djl/ndarray/BaseNDManager.java
50.00% <0.00%> (ø)

...gine/src/main/java/ai/djl/dlr/engine/DlrModel.java
53.12% <0.00%> (-3.13%)
:arrow_down:

...ain/java/ai/djl/tensorflow/engine/TfNDManager.java
79.36% <0.00%> (-2.39%)
:arrow_down:

api/src/main/java/ai/djl/util/Platform.java
43.47% <0.00%> (-2.18%)
:arrow_down:

api/src/main/java/ai/djl/repository/Artifact.java
91.37% <0.00%> (-1.73%)
:arrow_down:

...g/src/main/java/ai/djl/serving/util/Connector.java
55.40% <0.00%> (-1.36%)
:arrow_down:

...ngine/src/main/java/ai/djl/mxnet/jna/LibUtils.java
42.23% <0.00%> (-1.25%)
:arrow_down:

...rc/main/java/ai/djl/paddlepaddle/jni/LibUtils.java
51.14% <0.00%> (ø)

api/src/main/java/ai/djl/inference/Predictor.java
90.38% <0.00%> (+2.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd84636...6e44967. Read the comment docs.


Use SQLite for storage backend

The XML one is easier to debug, but keeps the entire object graph in RAM. This will be a flag day unless we detect the old library and continue using the XML one if it exists.
We could also move the SQLite database to ~/Music/Submariner/, which would make backing up easier.

We could also move the SQLite database to ~/Music/Submariner/, which would make backing up easier.

Or make this configurable, prompting to perforate the sandbox as needed.


Fix power calculation when encoding the BigDecimal into NUMERIC

I'm unsure if this is the best way to do this but it seems to do the job.
Related to issue: https://github.com/launchbadge/sqlx/issues/1691

Yeah, this math was.... hard. Thanks for double-checking it.
The MySQL build failures are unavoidable right now due to a regression in our type tests, but since this is passing for Postgres I'll merge it.


Improved Debugger support - do not require to recreate breakpoints

Currently new file will be created for hot-reloaded code and breakpoints can be added there.
Alternatively in IDE wide function-breakpoint can be set referencing patched class name ChangedClass*_Patched*
This works but is rather bad user experience.
[ ] Investigate if existing Rider / VS integration packages can be patched by Harmony in a way that'd help improve workflow
[ ] IDE plugin that allows to move existing breakpoints (big issue here is need to install additional IDE plugin)
[ ] other approach? potentially if breakpoints can be read from Unity side maybe adding Debugger.Break in those lines would help?)

I wonder if it'd be possible to tamper with the pdb of the newly-compiled assembly to point to the original source file instead of the generated, compiled one...?

Not sure, would need to know a bit more how VS / Rider loads and work with PDBs under the hood


Updating Point Cloud Values in Real-Time

Can you kindly tell me how to run this script with multiple images same as in your demo video?
Thanks

I would also be interested in how to get a depth stream out of your code example. Could you briefly explain how you implemented that in the example from the DepthVisualizer repository?
Many thanks.


Error --module 'importlib._bootstrap' has no attribute 'SourceFileLoader'

I m running the following code from Brest cancer example
import sys
try:
import pandas as pd
except ImportError as e:
print("pandas is required for this example. Please install with conda or pip  and then try again.")
sys.exit()
import numpy as np
import sklearn
from sklearn import ensemble
import kmapper as km
from kmapper.plotlyviz import *
import warnings
warnings.filterwarnings("ignore")
getting error
module 'importlib._bootstrap' has no attribute 'SourceFileLoader'

try:
pip install pandas
and run again.


find-deps.sh

How use find-deps.sh?
i use find-deps.sh find C:\example\path\TestProject
return -->.class
hierarchy:
TestProject.src.iwareq.testpr.Main.java

Which shell are you using? MinGW or WSL?

Which shell are you using? MinGW or WSL?

PowerShell

Well, its a bash skript (.sh) not a powershell script (.ps1), this won't work. Install WSL and run it from bash.
Or replicate the script. Its not doing much besides calling jdeps -recursive -regex "it\.unimi\.dsi\.fastutil\..*" -verbose:class -cp "<your jar>"

iwareq@hide:/mnt/c/Users/dimon/IdeaProjects/fastutil$ bash find-deps.sh find /mnt/c/Users/dimon/IdeaProjects/testProfect
find-deps.sh: line 2: $'\r': command not found
: invalid option name set: pipefail

whats next?

interesting. Which distribution? I guess Ubuntu from the looks of it.
Probably jdeps slightly changed their output format. You can extract the list of classes in the middle (all the "it.unimi..." being referenced) and pack that into a file (dependencies.txt) and then do find-deps.sh minimize yourjar.jar dependencies.txt if I remember correctly

interesting. Which distribution? I guess Ubuntu from the looks of it.
Probably jdeps slightly changed their output format. You can extract the list of classes in the middle (all the "it.unimi..." being referenced) and pack that into a file (dependencies.txt) and then do find-deps.sh minimize yourjar.jar dependencies.txt if I remember correctly

Yes, Ubuntu. Returned "Resolving transitive dependencies"

Hm, it seems jdeps significantly changed its functionality. I can't find a way to restrict it to only analysing the given classes as roots.
To fix this, one would need to write something that parses the complete output of jdeps (essentially, a list of all dependencies in fastutil) and then build the dependency tree for the given dependencies.
Doable, but its probably easier to just minimize the final jar with proguard or similar.

Why not fix the script?

Hey, why not capitalize on split.sh? It does exactly what you need (I think).

Why not fix the script?

As I just said, jdeps changed how it works apparently.

Hey, why not capitalize on split.sh? It does exactly what you need (I think).

If it creates an archive with the files that I use the project, then - yes, this is what I need

maybe open issue?)

split.sh separates fastutil in the native datatypes (int long double Object). Just run it in fastutil source folder after compiling. You'll save ~15 MB.
find-deps.sh won't work because of change in jdeps behaviour. Considering the minimal benefits and many caveats of this script I don't see a reason to fix it (PR is welcome of course).

split.sh separates fastutil in the native datatypes (int long double Object). Just run it in fastutil source folder after compiling. You'll save ~15 MB.
find-deps.sh won't work because of change in jdeps behaviour. Considering the minimal benefits and many caveats of this script I don't see a reason to fix it (PR is welcome of course).

thx


allow specifying network for cluster without meshNetworks being configured (#26618)

allow specifying network without meshNetworks fully configured

remove redundant slice alloc and add safety check for clusterID

move cluster id check

set clustername to match in tests

isControllerForProxy

(cherry picked from commit 97c21c4e6036a3e09484ae1d5c007a94c134c2ff)
fixes #26657

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio_release-1.6
06f376e67daac772a72e5179594ae06b240fe1b0
link
/test lint_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.6
9ecd9dad3b3a32b6c8c2b23011442e02e431bf67
link
/test unit-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Update maintainer-list.nix

Adding "french-isotope" as maintainer.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Are you maintaining a package? I believe that normally a commit like this would be included in the same PR as the first package for which you add yourself as a maintainer.

The commit message needs to be fixed. Check the history for that file.

Are you maintaining a package? I believe that normally a commit like this would be included in the same PR as the first package for which you add yourself as a maintainer.

Hi, i'm not a maintainer already, I wish to help with maintaining, I understood your point nonetheless.

@French-isotope the best way to help maintaining nixpkgs is to add new packages, review PRs, fix broken packages, fix issues, etc.
See https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md for details.
I'm going to close this PR. If you in the future add a package, then go ahead and add yourself as a maintainer.

@French-isotope the best way to help maintaining nixpkgs is to add new packages, review PRs, fix broken packages, fix issues, etc.
See https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md for details.
I'm going to close this PR. If you in the future add a package, then go ahead and add yourself as a maintainer.

Perfect, thank you for your time.


Implement EmptyNode (take 2)

Closes #58

Codecov Report

Merging #60 (0fccf27) into main (38b26b1) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   93.53%   93.28%   -0.25%
==========================================
  Files          20       21       +1
  Lines        1515     1460      -55
==========================================
- Hits         1417     1362      -55
  Misses         98       98

Impacted Files
Coverage Δ

src/ops/common.jl
100.00% <ø> (ø)

src/ops/sources.jl
92.53% <ø> (-3.24%)
:arrow_down:

src/alignment.jl
93.04% <100.00%> (-0.02%)
:arrow_down:

src/empty.jl
100.00% <100.00%> (ø)

src/ops/lagging.jl
91.48% <100.00%> (+1.10%)
:arrow_up:

src/core.jl
73.33% <0.00%> (-1.67%)
:arrow_down:

src/identity_map.jl
86.84% <0.00%> (-0.97%)
:arrow_down:

src/block.jl
91.76% <0.00%> (-0.55%)
:arrow_down:

src/ops/window.jl
96.87% <0.00%> (-0.35%)
:arrow_down:

... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Could you also add an optimisation to skip for Empty nodes so that we can remove the broken test?

Yep good plan! Done.


dart: 3.4.4 -> 3.5.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for dart is: Scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps
meta.homepage for dart is: https://dart.dev
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.5.0 with grep in /nix/store/3qmla1mjsym8927bfpwqd4irl5y6ww49-dart-3.5.0
found 3.5.0 in filename of file in /nix/store/3qmla1mjsym8927bfpwqd4irl5y6ww49-dart-3.5.0

Rebuild report (if merged into master) (click to expand)

28 total rebuild path(s)

28 package rebuild(s)

First fifty rebuilds by attrpath

dart
dart-sass
discourse
discourseAllPlugins
domine
expidus.calculator
expidus.file-manager
flutterPackages-source.beta
flutterPackages-source.stable
flutterPackages-source.v3_13
flutterPackages-source.v3_16
flutterPackages-source.v3_19
flutterPackages-source.v3_22
flutterPackages-source.v3_23
gitlab
gitlab-ee
jekyll
jsonnet
protoc-gen-dart
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
shopware-cli
vscode-runner

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3qmla1mjsym8927bfpwqd4irl5y6ww49-dart-3.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dart https://github.com/r-ryantm/nixpkgs/archive/186fb1299cd093962e586c84401e69a6601844e2.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/186fb1299cd093962e586c84401e69a6601844e2#dart

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3qmla1mjsym8927bfpwqd4irl5y6ww49-dart-3.5.0
ls -la /nix/store/3qmla1mjsym8927bfpwqd4irl5y6ww49-dart-3.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

11 packages failed to build:

expidus.calculator
expidus.calculator.debug
expidus.calculator.pubcache
expidus.file-manager
expidus.file-manager.debug
expidus.file-manager.pubcache
flutterPackages-source.beta
flutterPackages-source.stable
flutterPackages-source.v3_13
flutterPackages-source.v3_16
flutterPackages-source.v3_19

23 packages built:

dart
dart-sass
dart-sass.pubcache
discourse
discourseAllPlugins
domine
domine.pubcache
gitlab
gitlab-ee
jekyll
jsonnet
jsonnet.doc
protoc-gen-dart
protoc-gen-dart.pubcache
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
shopware-cli
vscode-runner
vscode-runner.pubcache

Maintainer pings
cc @GRBurst for testing.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for dart is: Scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps
meta.homepage for dart is: https://dart.dev
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.5.1 with grep in /nix/store/ka7rqy3zp56vsg7inpanf5mlif5bc0kp-dart-3.5.1
found 3.5.1 in filename of file in /nix/store/ka7rqy3zp56vsg7inpanf5mlif5bc0kp-dart-3.5.1

Rebuild report (if merged into master) (click to expand)

28 total rebuild path(s)

28 package rebuild(s)

First fifty rebuilds by attrpath

dart
dart-sass
discourse
discourseAllPlugins
domine
expidus.calculator
expidus.file-manager
flutterPackages-source.beta
flutterPackages-source.stable
flutterPackages-source.v3_13
flutterPackages-source.v3_16
flutterPackages-source.v3_19
flutterPackages-source.v3_22
flutterPackages-source.v3_23
gitlab
gitlab-ee
jekyll
jsonnet
protoc-gen-dart
quarto
quartoMinimal
rstudio
rstudio-server
rstudioServerWrapper
rstudioWrapper
shopware-cli
vscode-runner

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ka7rqy3zp56vsg7inpanf5mlif5bc0kp-dart-3.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dart https://github.com/r-ryantm/nixpkgs/archive/fdd524aa1ea724fa3aac26ed4ff6ba3aebcafa70.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/fdd524aa1ea724fa3aac26ed4ff6ba3aebcafa70#dart

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ka7rqy3zp56vsg7inpanf5mlif5bc0kp-dart-3.5.1
ls -la /nix/store/ka7rqy3zp56vsg7inpanf5mlif5bc0kp-dart-3.5.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 120m and timed out

Maintainer pings
cc @GRBurst for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.


Push deletion event for comments when deleted / banned

If a mod or creator deletes a comment, others in the live stream still sees it, it's only hidden for new viewers. We should push a delete event where the app will clean them up for active viewers.

We also need to push them to internal apis for deletion in notifications

expect a new websocket message removed that will contain the comment that was removed.


Unable to insert UUID as integer in primary key column of a table created in spanner database

I have model written in declarative base of SQL Alchemy.
Class Roles(Base):
    __tablename__ = "roles"
    __table_args__ = (
        Index("roles_name", "name", unique=True),
    )

    id = Column(Integer, primary_key=True, default=get_uuid())
    name = Column(String(10), nullable=False)

As you may have noticed I have set the default value of primary key column id to get_uuid().
def get_uuid():
    pk = uuid.uuid4().int >> 64
    return pk

The above method return UUID as integer of bit size 64 or less. This is because the column id of this table is set to int and spanner can hold up to 64 bit.
So now to insert a row in this table -
>>> role = Roles()
>>> role.name = "Admin"
>>> session.add(role)
>>> session.commit()

This resulted in following exception -
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/google/api_core/grpc_helpers.py", line 72, in error_remapped_callable
    return callable_(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/grpc/_channel.py", line 946, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "/usr/local/lib/python3.10/site-packages/grpc/_channel.py", line 849, in _end_unary_response_blocking
    raise _InactiveRpcError(state)
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
        status = StatusCode.FAILED_PRECONDITION
        details = "Could not parse<PHONE_NUMBER>1562567628 as an integer"
        debug_error_string = "UNKNOWN:Error received from peer ipv4:<IP_ADDRESS>:9010 {grpc_message:"Could not parse<PHONE_NUMBER>1562567628 as an integer", grpc_status:9, created_time:"2022-11-12T06:48:36.468914625+00:00"}"
>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/google/cloud/spanner_dbapi/cursor.py", line 269, in execute
    ) = self.connection.run_statement(statement)
  File "/usr/local/lib/python3.10/site-packages/google/cloud/spanner_dbapi/connection.py", line 454, in run_statement
    _execute_insert_heterogenous(
  File "/usr/local/lib/python3.10/site-packages/google/cloud/spanner_dbapi/_helpers.py", line 57, in _execute_insert_heterogenous
    transaction.execute_update(
  File "/usr/local/lib/python3.10/site-packages/google/cloud/spanner_v1/transaction.py", line 302, in execute_update
    response = api.execute_sql(
  File "/usr/local/lib/python3.10/site-packages/google/cloud/spanner_v1/services/spanner/client.py", line 1096, in execute_sql
    response = rpc(
  File "/usr/local/lib/python3.10/site-packages/google/api_core/gapic_v1/method.py", line 154, in __call__
    return wrapped_func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/google/api_core/retry.py", line 283, in retry_wrapped_func
    return retry_target(
  File "/usr/local/lib/python3.10/site-packages/google/api_core/retry.py", line 190, in retry_target
    return target()
  File "/usr/local/lib/python3.10/site-packages/google/api_core/timeout.py", line 99, in func_with_timeout
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/google/api_core/grpc_helpers.py", line 74, in error_remapped_callable
    raise exceptions.from_grpc_error(exc) from exc
google.api_core.exceptions.FailedPrecondition: 400 Could not parse<PHONE_NUMBER>1562567628 as an integer

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1900, in _execute_context
    self.dialect.do_execute(
  File "/usr/local/lib/python3.10/site-packages/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py", line 1013, in do_execute
    cursor.execute(statement, parameters)
  File "/usr/local/lib/python3.10/site-packages/google/cloud/spanner_dbapi/cursor.py", line 70, in wrapper
    return function(cursor, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/google/cloud/spanner_dbapi/cursor.py", line 289, in execute
    raise IntegrityError(getattr(e, "details", e)) from e
google.cloud.spanner_dbapi.exceptions.IntegrityError: []

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 1451, in commit
    self._transaction.commit(_to_root=self.future)
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 829, in commit
    self._prepare_impl()
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 808, in _prepare_impl
    self.session.flush()
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 3386, in flush
    self._flush(objects)
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 3525, in _flush
    with util.safe_reraise():
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/util/langhelpers.py", line 70, in __exit__
    compat.raise_(
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/util/compat.py", line 208, in raise_
    raise exception
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 3486, in _flush
    flush_context.execute()
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/unitofwork.py", line 456, in execute
    rec.execute(self)
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/unitofwork.py", line 630, in execute
    util.preloaded.orm_persistence.save_obj(
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/persistence.py", line 245, in save_obj
    _emit_insert_statements(
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/orm/persistence.py", line 1238, in _emit_insert_statements
    result = connection._execute_20(
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1705, in _execute_20
    return meth(self, args_10style, kwargs_10style, execution_options)
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/sql/elements.py", line 333, in _execute_on_connection
    return connection._execute_clauseelement(
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1572, in _execute_clauseelement
    ret = self._execute_context(
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1943, in _execute_context
    self._handle_dbapi_exception(
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 2124, in _handle_dbapi_exception
    util.raise_(
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/util/compat.py", line 208, in raise_
    raise exception
  File "/usr/local/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1900, in _execute_context
    self.dialect.do_execute(
  File "/usr/local/lib/python3.10/site-packages/google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py", line 1013, in do_execute
    cursor.execute(statement, parameters)
  File "/usr/local/lib/python3.10/site-packages/google/cloud/spanner_dbapi/cursor.py", line 70, in wrapper
    return function(cursor, *args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/google/cloud/spanner_dbapi/cursor.py", line 289, in execute
    raise IntegrityError(getattr(e, "details", e)) from e
sqlalchemy.exc.IntegrityError: (google.cloud.spanner_dbapi.exceptions.IntegrityError) []
[SQL: INSERT INTO roles (id, name) VALUES (%s, %s)]
[parameters: [18011687921562567628, 'Admin']]
(Background on this error at: https://sqlalche.me/e/14/gkpj)

What I understood for this is that the spanner is not willing to accept the generated UUID.
status = StatusCode.FAILED_PRECONDITION
details = "Could not parse<PHONE_NUMBER>1562567628 as an integer"

I have checked the method get_uuid(). It does return int value of but size 64 or less.
The README of this repo suggests [creating a table's primary key as Integer] (https://github.com/googleapis/python-spanner-sqlalchemy#create-a-table) and while in inserting a row in the database generate value of primary key in hex. I did exactly the same but it didn't work.

@jeetpatel9, well, this value<PHONE_NUMBER>1562567628 is bigger than the maximum Spanner INT64 value: https://cloud.google.com/spanner/docs/reference/standard-sql/data-types#integer_types
That's why it's failing.


Close #158, make intro screen separate

Close #158
One option. Cons: The short title field is still on that first page, separated from the question about the intro screen title. The 'Action' that the user needs to add for the splash screen (the very first screen of the interview) needs the short title value in order to run. If we put the short title field on the same page as the intro screen (the second page of the interview), that question will be asked first, which is a little confusing.

Should be ready for re-review


[BEAM-3837] Handle BundleSplitRequests in Python SDK Harness.

This should be sufficient to handle splits, including checkpointing, over the FnAPI.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

On Fri, Feb 8, 2019 at 10:48 AM Maximilian Michels<EMAIL_ADDRESS>wrote:

@mxm commented on this pull request.
PR looks good, but I'm struggling a bit to see this piece in the whole
picture of portable SDF support.

Thanks for looking into this, and good questions. I'll try to answer them
as best I can.

Looking at
https://docs.google.com/document/d/1tUDb45sStdR8u7-jBkGdw3OGFK7aa2-V7eo86zYSE_4,
this PR implements the Python SDK harness side of the splitting logic.

Correct.

The Runner can make use of the splitting to balance work more evenly.
Another use case is checkpointing during bundle processing.

Yep. Right now the runner is at the mercy of the SDF to decide to
checkpoint, this allows the runner to explicitly request that the SDK stop
processing a bundle (either ASAP, or some point in the future).

The SDK harness will eventually support reorganizing the fusion to
parallelize splits.

This is more speculative. Realistically, rather than adding such support
into SDKs, if the runner wants to change fusion it could request the
bundles stop ASAP, re-fuse, and then send different process descriptors for
the SDK harness to work on from that point forward.
Note that this PR does not request splits at arbitrarily deep points in the
fusion tree; it only splits into an SDF that is a root (immediately
following the GRPC read). Given that we generally want a "redistribute"
after the initial restriction splitting phase of an SDF this is not a huge
restriction; further work on extending this arbitrarily adds significant
complexity and can be done later if needed.

How are the Runners going to make use of this feature? Doesn't this
require that Runners know about all parallel instances of an SDF to
estimate how long splits take to process? Or do Runners simply measure
processing time of its own splits, in case there are more than one?

These changes are runner initiated, so there are various levels at which
they can take advantage of this.  The simplest is, of course, to never
request any splits at all. This works fine in batch, but in streaming one
would require sources that periodically checkpoint on their own (the
previous PR). The next level of sophistication is for the runner to
periodically checkpoint (e.g. after a certain amount of time has passed) to
be able to commit work and bound the re-processing required on failure
recovery (useful for batch, but almost essential for streaming). One step
more than that is supporting dynamic rebalancing, e.g. if twice as many
workers got added to a job, it could request that every existing worker
return half its remaining work. Or if some workers finish early, it could
see which workers have the most pending work ahead (progress not yet
implemented) and steal some of theirs to give to the idle one(s). These
require an increasingly global view of the state of the system.

How far is the support in terms of rearranging fusion according to the
splitting? Do we gain much from parallelizing splits on the same node or is
this only useful if the Runner's execution engine provides a means to
dynamically rebalance work on its workers?

Without the ability to rebalance work, the primary advantage to the runner
is the ability to checkpoint at the runner's request.

Thank you for the comments. I think it starts to make sense now.

Note that this PR does not request splits at arbitrarily deep points in the fusion tree; it only splits into an SDF that is a root (immediately following the GRPC read).

That certainly simplifies the splitting because the fusion does not have to be changed after the splitting.

This works fine in batch, but in streaming one would require sources that periodically checkpoint on their own (the previous PR).

Ah ok, and this is handled via the ProcessBundleResponse's DelayedBundleApplication which can be checkpointed.

Without the ability to rebalance work, the primary advantage to the runner is the ability to checkpoint at the runner's request.

FYI Rebalancing is supported by Flink and the Runner is theoretically ready to support it. However, the process is rather manual. You need to savepoint the current application state and then restart the job from that savepoint with a different parallelism. You also need to set the "maximum parallelism" before you first start the job which determines the partitioning degree of the state.

Yes, I think Flink could take advantage of this as well, with some runner-side work.

Thanks!


[PS17] Alert now working inside quickview

javascript is not loaded

is this fixed already?

This is primarily bug in ps17. They newly load and compose content for quickview using javascript, instead of iframe. While this is a good approach, they forget to include/run javascript from product page as well, so any included content that depends on this javascript will not work.
This issue affects many modules, not just pricealert. So I believe prestashop team will address it in the future (maybe they already have).
To fix it on my side, it would require a significant redesign of module. So I'm putting this on ice, hoping that ps will fix the root cause


python312Packages.publicsuffixlist: <IP_ADDRESS>40502 -> <IP_ADDRESS>40506

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 309497 run on aarch64-linux 1

2 packages marked as broken and skipped:

python311Packages.parsedmarc
python311Packages.parsedmarc.dist

13 packages built:

parsedmarc
parsedmarc.dist
pretalx
pretalx.dist
pretalx.static
python311Packages.checkdmarc
python311Packages.checkdmarc.dist
python311Packages.publicsuffixlist
python311Packages.publicsuffixlist.dist
python312Packages.publicsuffixlist
python312Packages.publicsuffixlist.dist
trustymail
trustymail.dist


Fix the error message for route53.

Only 'ERROR' was printed which made debugging the actual error
problematic.

In the production instance right now it only prints that error though, so it doesn't really help in figuring out why it is failing if it never reaches the end.

Big fan of printing errors as soon, as they happen. Printing them after the loop will result in printing the error with another timestamp.


Add support for asciidoc(tor) formatted blogs, including styling for admonitions

This took me a (very) surprisingly long time to work out, with some undocumented settings used to get it working. This way means that generated images are put in the correct locations during generation, with the correct path put into the HTML for when it's loaded in the browser.
You may need to do:
- gem install asciidoctor
- gem install asciidoctor-diagram --pre
I spent a while chopping up the asciidoctor sass to make some admonition styles that fit with our styles. I didn't want to do anything too outlandish without consulting first, so it's basic. I have some ideas, though, so we should chat about that at some point.
Here's an example of what it looks like:

This can't be merged.  Can you resolve conflicts and update the PR?

Okay, redone. Please have a play around and see if everything looks good. BTW - I will need to rebase my blogposts, but that shouldn't be too hard with this done.

Still can't be automatically merged.

whoops!


nrf52840 please add dcdc voltage setting (UICR.REGOUT0) to config

Hi all!
I am programming an nrf52840-dongle. It derives its power from usb using a buck converter in the nrf chip, and each time i flash it, the output voltage setting (UICR.REGOUT0) is reset to 1.8V. I need it running at 3.3V.
So far, i have not found REGOUT0 exposed in the hal anywhere, nor have i found a way to write to UICR in a nice way (well, there is a uicr_write_masked, but it's not exposed).

Sounds like a good idea, is this something you'd like to contribute?

i'm not sure about that... maybe

This issue can be closed?
cc: @DeepSOIC @Dirbaio

I believe this can be closed.


Interactive Tutorial - Exposing Your App

_REF: https://kubernetes.io/docs/tutorials/kubernetes-basics/expose/expose-interactive/
Description
We're instructing students to expose a Service by way of kubectl expose using a label type of NodePort:
$ kubectl expose deployment/kubernetes-bootcamp --type="NodePort" --port 8080
service/kubernetes-bootcamp exposed

We then instruct the student to list the services once again:
$ kubectl get services
NAME                  TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)          AGE
kubernetes            ClusterIP   <IP_ADDRESS>      <none>        443/TCP          2m58s
kubernetes-bootcamp   NodePort    <IP_ADDRESS>   <none>        8080:31757/TCP   21s

Expectation
In instruction notes, we're expecting from our students to read, understand and acknowledge that expose has assigned an external IP to the Service.
Problem
However, in the output external-ip is <none> but rather you'd see a PORT NAT based assignment (which correlates to previous notes in the curriculum regarding NodePort exposure).
Fix
We should rather point out at port NAT-ting omitting external IP (none is assigned).

Debugging info
describe
$ kubectl describe services/kubernetes-bootcamp
Name:                     kubernetes-bootcamp
Namespace:                default
Labels:                   run=kubernetes-bootcamp
Annotations:              <none>
Selector:                 run=kubernetes-bootcamp
Type:                     NodePort
IP:                       <IP_ADDRESS>
Port:                     <unset>  8080/TCP
TargetPort:               8080/TCP
NodePort:                 <unset>  31757/TCP
Endpoints:                <IP_ADDRESS>:8080
Session Affinity:         None
External Traffic Policy:  Cluster
Events:                   <none>

$NODE_PORT
$ echo NODE_PORT=$NODE_PORT
NODE_PORT=31757

minikube ip
$ curl $(minikube ip):$NODE_PORT
Hello Kubernetes bootcamp! | Running on: kubernetes-bootcamp-765bf4c7b4-fp5fr | v=1

$ echo $(minikube ip)
<IP_ADDRESS>

I think we should change

We have now a running Service called kubernetes-bootcamp. Here we see that the Service received a unique cluster-IP, an internal port and an external-IP (the IP of the Node).

to explain that Minikube does not assign an external IP here.
Would that fix be acceptable?
/language en

Yes.
--
; Alexandru Gheorghe
; <alghe.global [at] gmail [dot] com>
;
; Sent from mobile (please excuse any typos)
On Tue, Apr 13, 2021, 18:18 Tim Bannister @.***> wrote:

I think we should change
We have now a running Service called kubernetes-bootcamp. Here we see
that the Service received a unique cluster-IP, an internal port and an
external-IP (the IP of the Node).
to explain that Minikube does not assign an external IP here.
Would that fix be acceptable?
/language en
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/issues/27537#issuecomment-818906495,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACTHAL6MV2WKWHKUFFNOILDTIR4FJANCNFSM423OGRQA
.

I'm unable to find the contents for this module that I can update in order to rephrase that section. Would someone point me to the right repo/dir so I can submit a request for code review on this issue?
Cloning website seems not to be enough in order to do these changes - unless I am missing something here.

Hi, I am working on a similar issue with updating the documentation, and I think you can make the related changes and pull request at https://github.com/katacoda-scenarios/kubernetes-bootcamp-scenarios
Cheers!

@alghe-global would you be willing to revise the issue description based on https://github.com/kubernetes/website/issues/27537#issuecomment-818906495 ?

Also, if this is already fixed, let's close the issue.


enable search bar for non-english characters search in normal search mode.

Enable search bar for non-english characters search in normal search mode.
And make it configurable in .env
ENHANCE_SEARCH_BAR_COMPATIBILITY=false

Thanks for offering this @charlietag but I wouldn't want to take this approach so I'm going to close off this PR.
I don't like to introduce options for branching logic where possible, and this somewhat makes the search index functionality redundant.
At a high level, it's a workaround, whereas the core issue attempting to be addressed should probably be dealt with at an indexing level.


coincidency, beavery

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[b,c]

/trunk merge


Out of date Azure RM backends

Bicep version
Latest Azure DevOps agent Bicep version as of 2022-07-28
Describe the bug
When deploying we are receiving this error sometimes:
{
    "status": "Failed",
    "error": {
        "code": "NoRegisteredProviderFound",
        "message": "No registered resource provider found for location 'westeurope' and API version '2021-08-01' for type 'networkWatchers/flowLogs'. The supported api-versions are '2017-09-01, 2017-10-01, 2017-11-01, 2018-01-01, 2018-02-01, 2018-03-01, 2018-04-01, 2018-05-01, 2018-06-01, 2018-07-01, 2018-08-01, 2018-10-01, 2018-11-01, 2018-12-01, 2019-02-01, 2019-04-01, 2019-06-01, 2019-07-01, 2019-08-01, 2019-09-01, 2019-11-01, 2019-12-01, 2020-01-01, 2020-03-01, 2020-04-01, 2020-05-01, 2020-06-01, 2020-07-01, 2020-08-01, 2020-11-01, 2021-01-01, 2021-02-01, 2021-03-01'. The supported locations are 'westus, eastus, northeurope, westeurope, eastasia, southeastasia, northcentralus, southcentralus, centralus, eastus2, japaneast, japanwest, brazilsouth, australiaeast, australiasoutheast, centralindia, southindia, westindia, canadacentral, canadaeast, westcentralus, westus2, ukwest, uksouth, koreacentral, koreasouth, francecentral, australiacentral, southafricanorth, uaenorth, switzerlandnorth, germanywestcentral, norwayeast'."
    }
}

It appears a few backends for the Azure RM are out of date. Most of the time it does get executed fine with the API version i'm using (2021-08-01).
The documentation also confirms this:
https://docs.microsoft.com/en-us/azure/templates/microsoft.network/2021-08-01/networkwatchers/flowlogs?tabs=bicep
I did see this with more resources, not just the networkWatcher.
To Reproduce
Steps to reproduce the behavior:
Deploy resources with 2021-08-01 a few times. You'll probably hit this one sooner or later.

This is an issue the Network Resource Provider needs to resolve. Would it be possible for you to open up an Azure Support Ticket for this one?

Sorry for the delay in response.
For clarity: this is not only the Microsoft.Network namespace. i'm randomly getting these errors for all providers. Again: i think there are backends out of date or w/e, since a simple pipeline rerun resolves the issue.

Rob, I shared this with the Networking team, but did not get any traction. The best way to make progress on this issue will be to open a support ticket.


Uses stages not flows is being set incorrectly

I have a study where the data uses a graphical flow-frequency function and a stage-discharge function. On the graphical frequency function, UsesStagesNotFlows should be false but it is true:

I tried to fix this, but failed.

I believe i have fixed this.
Here is a graphical using flows:

On line 133 there is a ctor that defaults the last 3 values. When this ctor was being called, the calling class was not passing that information in, so it was always getting defaulted to "true".

I now pass in the boolean. I had to do the opposite value because that class stores if it is using flows.

What about the min and max values? Should those be using the default or should we be passing those values in?

This bug was fixed in the graphical_frequency_bug branch.

Could you please do a test? I think I made the same change (but didn't commit) over the weekend and it didn't work for me. Of course whenever I am in the VM or V I am pretty clueless.
A way to test would be to use a graphical flow-freq and rating curve for a stage damage compute. Then make sure that stages are on the x axis, not flows.

Ok, testing.

You are right, this did not fix it. I am looking into it.

Thank you sir

I think this is the problem. Is there a reason that this argument has a default of true. I feel like we should remove the default and force everyone calling it to specify if it is stages or flows.

Changing the above line to use the actual value fixed the issue (i think). Stages are on the x axis:

I removed the default value for that argument so that you have to tell it what value to use. I had to update one unit test by passing in "true".

Huh. So are we having trouble overriding the default value?
I can't remember exactly why I put the default value there but I have a guess - I probably added the parameter after the constructor had been in use and I didn't want to break stuff.
If clearing the default value does the trick then im supportive - but I'd also like to learn more about why the default value couldn't be overridden

The default value can be overriden but if you look at this pic, the value is hard coded to true instead of passing in the correct value.

We ran into two places where the value was getting set to true no matter what. One was because we didn't pass in an argument so it was getting defaulted to true. The other one we were always passing in true instead of asking the property what the correct value was.

I get what you mean about adding to the ctor after the code has been there a while and not wanting to break things, but i think in this case that is an argument that we don't want to be left up to chance.

Cool. Thanks for making this work.


PandasIndex init with object indices slow without cftime

What happened:
While profiling some basic code working with datasets, I came across a repeated import that was slowing things down considerably. During various dataset operations, PandasIndex instances are initialized. When an index is object-valued, PandasIndex.__init__ calls safe_cast_to_index -> _maybe_cast_to_cftimeindex -> CFTimeIndex.__new__ -> assert_all_valid_date_type -> import cftime. If cftime is not installed, this generates a ModuleNotFoundError, which is caught in _maybe_cast_to_cftimeindex. However, searching and failing to find the cftime import takes much longer than correctly finding it. As a result, this code is much slower if cftime is not installed.
What you expected to happen:
PandasIndex.__init__, as a relatively commonly called portion of code, should be reasonably fast. Its execution time should not strongly depend on an optional dependency like cftime.
Minimal Complete Verifiable Example:
import xarray as xr
from xarray.core.indexes import PandasIndex
import pandas as pd
from timeit import timeit

print(timeit(lambda: PandasIndex(pd.Index(data=['abc', 'def'])), number=1000))
# with cftime, this takes about 60 ms
# without cftime, this takes over 4000 ms

Anything else we need to know?:
Relevant code is here: https://github.com/pydata/xarray/blob/960010b00119367ff6b82e548f2b54ca25c7a59c/xarray/core/utils.py#L67

Sorry, this was an issue for an older version of xarray. Fixed in the newest version!

for reference, the PR that fixed this was #5640


[FLINK-22545][coordination] Fix check during creation of Source Coordinator thread

What is the purpose of the change
Fixed bug FLINK-22545 leading to test instabilities, by changing a "safety net" sanity check during the creation of the Source Coordinator thread (which drives the Source's Split Enumerator).
The check was meant as a safeguard to prevent re-instantiation after fatal errors killed a previous thread.
But the check was susceptible to thread termination due to idleness in the executor.
This updates the check to only fail if there is in fact an instantiation next to a running thread, or after a
previously crashed thread.
Verifying this change
This fixes a test instability, and is verified by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@rmetzger  FYI, as you previously worked on this issue.

Thanks for the review, @rmetzger.
Manually merged in 331ae2cdfa7462b7cc5ed018484cb3eda257a174


Generator with closure does not correctly handle return()

When a generator function contains a loop with both a closure capturing a variable and a yield expression, then calling iterator.return() does not correctly finish the generator.

TypeScript Version:  2.9.0-dev.20180519

Search Terms: generator, closure, yield, finally, return
Code
function* closure(log: string[]) {
    try {
        let sum = 0;
        while (true) {
            const value = 'value';
            const fn = () => value;
            log.push('yield');
            sum += yield sum;
        }
    } finally {
        log.push('finally');
    }
}

let log = [];
let gen = closure(log);
gen.next(); // {done: false, value: 0})
gen.next(10); // {done: false, value: 10})
gen.next(20); // {done: false, value: 30})
// log === ['yield', 'yield', 'yield']

let {done, value} = gen.return();
console.log('done', done);
console.log('value', value);
console.log('log', log);

Expected behavior:
Running the snippet should log the following to the console:
done true
value undefined
log [ "yield", "yield", "yield", "finally" ]

Actual behavior:
Running the snippet logs the following to the console:
done false
value 30
log [ "yield", "yield", "yield", "yield" ]

Playground Link: http://www.typescriptlang.org/play/index.html#src=function* closure(log%3A string[]) {
    try {
        let sum %3D 0%3B
        while (true) {
            const value %3D 'value'%3B
            const fn %3D () %3D> value%3B
            log.push('yield')%3B
            sum %2B%3D yield sum%3B
        }
    } finally {
        log.push('finally')%3B
    }
}

let log %3D []%3B
let gen %3D closure(log)%3B
gen.next()%3B %2F%2F {done%3A false%2C value%3A 0})%0D%0Agen.next(10)%3B%20%2F%2F%20%7Bdone%3A%20false%2C%20value%3A%2010%7D)%0D%0Agen.next(20)%3B%20%2F%2F%20%7Bdone%3A%20false%2C%20value%3A%2030%7D)%0D%0A%2F%2F%20log%20%3D%3D%3D%20%5B'yield'%2C%20'yield'%2C%20'yield'%5D%0D%0A%0D%0Alet%20%7Bdone%2C%20value%7D%20%3D%20gen.return()%3B%0D%0Aconsole.log('done'%2C%20done)%3B%0D%0Aconsole.log('value'%2C%20value)%3B%0D%0Aconsole.log('log'%2C%20log)%3B%0D%0A
Related Issues: None that I found

Initial investigation
In the snippet above, calling iterator.return() should execute the finally block and then finish the generator (done === true). Instead, the generator simply keeps running: it goes through an extra iteration of the while loop and hits another yield.
I've set up a more complete reproduction case that compares the same test case with the following configurations:

TypeScript targeting ES5
TypeScript targeting ES2015
Babel targeting ES5 using babel-preset-env
native JavaScript running in Node 8.11.1

Only TypeScript targeting ES5 results in the faulty behavior, all other configurations behave correctly.
This also happens when you use yield* instead of a closure (with downlevelIteration: true), see this test case:
function* yielder(value: number) {
    return (yield value);
}

function* yieldStar(log: string[]) {
    try {
        let sum = 0;
        while (true) {
            log.push('yield');
            sum += yield* yielder(sum);
        }
    } finally {
        log.push('finally');
    }
}

Even more minimal test case:
function* minimal() {
    try {
        yield* yielder('first');
        yield 'second';
    } finally {
        return 'finally';
    }
}

function* yielder(value: any) {
    return (yield value);
}

let gen = minimal();
assert.deepStrictEqual(gen.next(), {done: false, value: 'first'});
assert.deepStrictEqual(gen.return(), {done: true, value: 'finally'});

When targeting ES5 with downlevelIteration: true, gen.return() returns {done: false, value: 'second'} instead of the expected result.
(I suspect the closure case desugars to the yield* case, since the compiler must create a _loop_1 generator function and yield* inside the loop body.)