Outdated/broken image on Azure

PerfkitBenchmarker has not updated its images used by vms for a while, causing some software installation problems, especially on Azure.
When trying to install openjdk-7-jdk, I get following errors.
2015-01-27 17:26:36,504 ERROR    Got exception running InstallPackages: Got non-zero return code (100) executing sudo DEBIAN_FRONTEND='noninteractive' /usr/bi
n/apt-get -y install openjdk-7-jdk
Full command: /usr/bin/ssh -A -p 22<EMAIL_ADDRESS>-2 -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -o IdentitiesOnly=yes -o PreferredAut
hentications=publickey -o PasswordAuthentication=no -o ConnectTimeout=5 -o GSSAPIAuthentication=no -o ServerAliveInterval=30 -o ServerAliveCountMax=10 -i /tmp
/perfkitbenchmarker/run_fdf1048d/perfkitbenchmarker_keyfile sudo DEBIAN_FRONTEND='noninteractive' /usr/bin/apt-get -y install openjdk-7-jdk
STDOUT: Reading package lists...
Building dependency tree...
Reading state information...
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
openjdk-7-jdk : Depends: openjdk-7-jre (= 7u71-2.5.3-0ubuntu<IP_ADDRESS>) but it is not going to be installed
Recommends: libxt-dev but it is not installable
STDERR: Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
E: Unable to correct problems, you have held broken packages.

What's the next step here?

I'm running into this exact same issue, and it's causing the Hadoop test to fail.  I'm having a similar problem with the block_storage benchmark saying :
"Package libaio1 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
STDERR: Warning: Permanently added '<IP_ADDRESS>' (ECDSA) to the list of known hosts.
E: Unable to locate package libaio-dev
E: Package 'libaio1' has no installation candidate"
In the case of open-jdk, I manually created a VM using the same image you're using and manually walked through the apt-get update and apt-get install commands, and the open-jdk package installed successfully --- is there anything different (permissions or path?) about remote installation via SSH command vs. interactive installation in a terminal window?
(Right now I'd characterize this as a bug rather than an enhancement)

I do not think this problem is caused by remote SSH. I remember when I first caught this bug, I log into the VM and try to install manually and the problem still exists.
Also I do think it happens only on some of the vms, as in the third thread, I tried cassandra_stress with 4 exactly same vms, 2 succeed, but the other 2 failed with this package installation problem.

yuyantingzero, what image/machine-type are you attempting to run against?
I was trying to run Hadoop Terrasort on an A7 machine type in US Central.  The image PKB selected was "b39f27a8b8c64d52b05eac6a62ebad85__Ubuntu-14_04_1-LTS-amd64-server
-20150123-en-us-30GB"
If the results are inconsistent, that would indicate some sort of inconsistency in copies of the VHDs...

I ran against default image/machine-types. Image: "b39f27a8b8c64d52b05eac6a62ebad85__Ubuntu14_04_1-LTS-amd64-server-20150123-en-us-30GB" , machine type: A1 (Small in PKB).
@timothyeharris , does all of the vms in hadoop test failed to retrieve the package? The hadoop tests creates 9 vms.

Work around is to installing the necessary package manually, I will be writing a fix for this.

@timothyeharris do you mind opening another issue to track fio, block_storage_benchmark? I will fix the open-jdk bug in this release, but do not have enough time for the fio block_storage_benchmark.

Fix in dev. According to @ehankland , Azure seems to improve their repository servers recently. After a few retries, even without replacing the sources.list, it still succeeds. But I will leave the fix as it is, and remove it when apt-get install openjdk-7-jdk succeeds without retrying.


Why no deceptive dinos?

The utilities don't have deceptive dinos in it. Also you can't spam open the dino box.

Check out #409, I added the Deceptive Dinos & Dino box.

Thank you.


Implement workspace type check

it looks like agent version 1.x in combination with disabling multiple checkouts results in the behavior that the agent creates a server workspace. All my tasks expect to work against a local workspace.
This behavior is no longer present in agent version 2.0.
Current proposal is to add an explicit error message to the Update Gated Changes and the Check-in task to warn people of this condition.
If someone wants to contribute a TF Checkout task, I'd be happy to include it with the extension, but I'm not going to invest time in this feature for the following reasons:

Agent 1.x is being phased out in favor of agent 2.x
Agent 2.x doesn't create server workspaces in this condition.
Exclusive Checkout has long been e Source Safe migration enabler, but the guidance has always been to move away from this behavior. It's bad enough to do source control operations during build, but doing it with Exclusive Checkout is too much.
Adding a Check-out task would cause confusion for all those people who do not need it.
I don't want to add yet another test scenario to the list of scenario's I need to go through when releasing a new version of these tasks.

Related to: #36 and #37


Remove the participant default_number

As discussed with @emanuelschuetze it makes problems and is not used.

Begin to remove the default_number from the user code (accounts and participants)

I assume the same has to be done in the backend. What should happen with the existing data? With the default_structure_level, it was migrated into the normal structure level (if a participant did not have a structure level, the default structure level from the account was used). Should something similar be done here? Or should the default number simply be dropped?

@emanuelschuetze @rrenkert

Opened https://github.com/OpenSlides/openslides-backend/issues/2117 for this


OSError

Hello, this question has been bothering me for a long time, I want to ask you. thanks
OSError: Model name 'xlnet-large-cased' was not found in tokenizers model name list (xlnet-base-cased, xlnet-large-cased). We assumed 'xlnet-large-cased' was a path, a model identifier, or url to a directory containing vocabulary files named ['spiece.model'] but couldn't find such vocabulary files at this path or url.

I have same problem, did u fix it? please tell me if u have fixed it. Thanks!


Translation of currencies has too many duplicated strings

This is a problem about #1503
Many countries use the same currency (United States Dolar, Euro).
There should not be duplicated Translation strings for United States Dolar or Euro (one for each country).

yeah, good call. We could probably just break the currencies out into a separate object within the translation files. The mapping between a country and it's currency is done outside of the translation files, in countriesMd.js.

Yes, that would be the best approach.

Agreed.

this is fixed.


Fix REJECTED error code to match the spec.

It should have been fixed in #151, that was an oversight from my part.

Thanks @yschimke for spotting this!


doc(README): Fix the example in the README.

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Commit: 244994b7aa3151953768f7c025576365d7cfcaf0
Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

Merged manually.


Doxygen - Infrastructure for RPP

Doxygen for RPP

@samjwu you can use the .Doxyfile to populate the sphinx build similar to MIVisionX. Let me know if you need any changes.


feat: support prepare pushdown

Ticket(s) Closed

Closes #51

What
Why
How
Pushdown PREPARE, EXECUTE and DEALLOCATE statement to duckdb directly.
Tests

Note: There is a issue that PostgreSQL will replan the query when certain catalog changes occur, such as changes to the search path or when a table is deleted. In contrast, DuckDB does not replan when the search path is changed.
If there are two foreign tables in different schemas and the prepared statements do not specify the schemas, it may lead to ambiguity or errors when referencing the tables.
create foreign table public.t1(xxx);
create foreign table s1.t1(xxx);

prepare q1 as select * from t1;
execute q1; (query table public.t1);

set search_path to 's1';

execute q1; (query table public.t1 in duckdb, but it should be s1.t1 in Postgres);

Note: There is a issue that PostgreSQL will replan the query when certain catalog changes occur, such as changes to the search path or when a table is deleted. In contrast, DuckDB does not replan when the search path is changed. If there are two foreign tables in different schemas and the prepared statements do not specify the schemas, it may lead to ambiguity or errors when referencing the tables.
create foreign table public.t1(xxx);
create foreign table s1.t1(xxx);

prepare q1 as select * from t1;
execute q1; (query table public.t1);

set search_path to 's1';

execute q1; (query table public.t1 in duckdb, but it should be s1.t1 in Postgres);

Can we force DuckDB to replan via some API call? We want to imitate the Postgres behaviour as much as possible.

Note: There is a issue that PostgreSQL will replan the query when certain catalog changes occur, such as changes to the search path or when a table is deleted. In contrast, DuckDB does not replan when the search path is changed. If there are two foreign tables in different schemas and the prepared statements do not specify the schemas, it may lead to ambiguity or errors when referencing the tables.
create foreign table public.t1(xxx);
create foreign table s1.t1(xxx);

prepare q1 as select * from t1;
execute q1; (query table public.t1);

set search_path to 's1';

execute q1; (query table public.t1 in duckdb, but it should be s1.t1 in Postgres);

Can we force DuckDB to replan via some API call? We want to imitate the Postgres behaviour as much as possible.

Yes.  We could execute prepare in Duckdb again. It will override the plan. I will fix it tomorrow.

Note: There is a issue that PostgreSQL will replan the query when certain catalog changes occur, such as changes to the search path or when a table is deleted. In contrast, DuckDB does not replan when the search path is changed. If there are two foreign tables in different schemas and the prepared statements do not specify the schemas, it may lead to ambiguity or errors when referencing the tables.
create foreign table public.t1(xxx);
create foreign table s1.t1(xxx);

prepare q1 as select * from t1;
execute q1; (query table public.t1);

set search_path to 's1';

execute q1; (query table public.t1 in duckdb, but it should be s1.t1 in Postgres);

Can we force DuckDB to replan via some API call? We want to imitate the Postgres behaviour as much as possible.

Yes. We could execute prepare in Duckdb again. It will override the plan. I will fix it tomorrow.

Sweet. That sounds wonderful. We want to be as "Postgres idiomatic as possible", so whatever the user experience Postgres users expect is is what we should try to replicate.

Note: There is a issue that PostgreSQL will replan the query when certain catalog changes occur, such as changes to the search path or when a table is deleted. In contrast, DuckDB does not replan when the search path is changed. If there are two foreign tables in different schemas and the prepared statements do not specify the schemas, it may lead to ambiguity or errors when referencing the tables.
create foreign table public.t1(xxx);
create foreign table s1.t1(xxx);

prepare q1 as select * from t1;
execute q1; (query table public.t1);

set search_path to 's1';

execute q1; (query table public.t1 in duckdb, but it should be s1.t1 in Postgres);

Can we force DuckDB to replan via some API call? We want to imitate the Postgres behaviour as much as possible.

Yes. We could execute prepare in Duckdb again. It will override the plan. I will fix it tomorrow.

Sweet. That sounds wonderful. We want to be as "Postgres idiomatic as possible", so whatever the user experience Postgres users expect is is what we should try to replicate.

Yes, I completely agree. I detect changes in the search path and determine whether to replan in DuckDB. It's ready for review. @rebasedming

I will carefully review this PR today or tomorrow.

Thank you <3


Various PPC SLEIGH fixes

Ensure matching registers dont conflict
If any of the multiple registers are the same in an instruction
there may be side effects if the same token is used further in
the SLEIGH, reordered SLEIGH when possible otherwise added
locals
signess issues in unsigned comparison against -1
-1 < tmp implies MAX_INT < tmp for 32-bit, which is always false
switched to signed comparison
Remove unused argument in divZero macro
Add cr0 bit 2 for stwcx. and stdcx.
Currently a pcodeop is used for this store.  Upon success
the cr0 bit 2 is set.  The current code would likely result
in the decompiler showing infinite loops (unless some other
instruction writes to cr0) as this is typically in a tight
loop waiting for the store to complete.
The ISEL instruction didn't preserve a register value while
calculating whether it should write the first or second value
resulting in unconditionally writing the one value if any of
the first three operands match.
several flags getting set after register value changed

I should also add, just in case its overlooked from the commit's intent, I did notice inconsistent subOverflow() usage in subfo, subfo., and subfco compared to insn like subfco. and subfeo.

I realized how ugly i made this PR, it is now 2 commits, the first containing the bug fixes and the 2nd is only whitespace

I realized how ugly i made this PR, it is now 2 commits, the first containing the bug fixes and the 2nd is only whitespace

leaving out whitespace cleanup and CR macro consistency for now

@GhidorahRex   squashed everything and fast forwarded to the current master, nothing seems off/conflicting


Spike: experiment proposal for account recovery

As an implementer of Valora's account recovery feature MVP, I need a northstar metric (and other experiment proposal details) to guide my decision-making with implementation details for the feature.
AC:

experiment proposal is drafted and published to notion
proposal is circulated for feedback and updated with everyone's contributions

Note from Silas: treat as code review. Author gets the final say on more opinion-based topics of discussion. Bugs should still be addressed.


How can I download TF API document?

How can i download TF API document?
Search in webpage is not so convenient.

You can fork a local client from github and read the documents locally. Would that work?

@sherrym yes, that works. However it is not so convenient, it can't support search and navigation. If there is a chm version, it will be so helpful.

It's all Markdown files and GitBook toolchain has ability to to turn
markdown into PDF or ePub, but it would need a bit of work to hook it up
On Wed, Aug 17, 2016 at 12:29 AM, binTang<EMAIL_ADDRESS>wrote:

@sherrym https://github.com/sherrym yes, that works. However it is not
so convenient, it can't support search and navigation. If there is a chm
version, it will be so helpful.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/3810#issuecomment-240334963,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABaHJtj3ghMPH8TZTx74D26NhMjM6EOks5qgrhSgaJpZM4JkFaI
.

Marking this as contributions welcome as we'd be happy to accept contrib scripts that would streamline this, but it is not something we're likely to get to soon. Thanks!

Hi, @aselle I create a pull reuqest at https://github.com/tensorflow/tensorflow/pull/4747 to fix this. May you help to review it? Thank you in advance!

The online preview address is https://haosdent.gitbooks.io/tensorflow-document/content/api_docs/

@haosdent I really like your gitbook. Are you planing to update your gitbook peridcoally? It seems your gitbook is not updated to TF 1.0 documents.

@haosdent Can you provide a PDF version?

Closing due to lack of activity, but we're happy to accept PRs if someone wants to improve the situation.

I've built a local version of html format, it is official version r1.10. Check it out https://github.com/danyfang/TensorFlow-Documentation-HTML

@sherrym @rabintang
You can fork a local client from github and read the documents locally.
Actually I tried this.. Forked docs from https://github.com/tensorflow/docs and tried building it by running
python setup.py build
according to what was shown in help menu. I am getting errors.
Is this the actual method to build or am I doing something wrong?
Can you please share a step-by-step guide?
It's my first time building docs for offline browsing.. Thank you..

@danyfang

I've built a local version of html format, it is official version r1.10

Can you also guide me on building docs on local machine to browser offline? It would be a great help.. Please!
Thank you..

@danyfang

I've built a local version of html format, it is official version r1.10

Can you also guide me on building docs on local machine to browser offline? It would be a great help.. Please!
Thank you..

Have you solved the problem?
I also want to download TF API document because it's website is blocked in china.....

@sherrym @rabintang
I'm getting errors building it too.
@ParikhKadam It's been more than a year now. Any luck?


Fix NaNs on the chart

Cool, the only thing we might want to improve is date range fallback:  up to you whether it should be done here or separately

I guess it would be best to fix that, when we'll be redesigning the charts.


App managing interface.

[ ] Add a possibility to install an app via the URL.

[x] Add a checkbox in GUI to install prereleases.

[x] Add a button to reset the changes.

@yakutovicha not sure but perhaps some of these items were done/decided not to be done?

@yakutovicha not sure but perhaps some of these items were done/decided not to be done?

Thanks for the reminder. Indeed, most of the requested changes are already taken care of. I slightly modified the description, to better describe the required functionality.
I think the only remaining thing is to add something like aiidalab install <URL>. I believe @csadorf is working on it.

I think the only remaining thing is to add something like aiidalab install <URL>. I believe @csadorf is working on it.

@yakutovicha , yes and I am working on it in the context of #201 . However, I have created #213 to keep track of this more explicitly and recommend that we remove that sub-task here and close.


Fixing trailing commas issues on rule statuses

IMPORTANT: Where possible all PRs must be linked to a Github issue
Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@ellykits please review, can I start working on unit test cases?

please add some tests for joinToString

done.

Implementation and tests look good just need to verify that the CI will build correctly before we merge.


🐛 BUG: C3 + Angular integration broken due to #3247

Which Cloudflare product(s) does this pertain to?
C3
What version of Wrangler are you using?
2.0.2
What operating system are you using?
all
Describe the Bug
heya, I just got a report from Andrew @ Angular that we accidentally broke C3+Angular with https://github.com/cloudflare/workers-sdk/pull/3247
I confirmed that C3 does indeed fail to scaffold Angular project with the following error:
┌ Installing Angular SSR ..
- Determining package manager...
ℹ Using package manager: npm
- Searching for compatible package version...
✔ Found compatible package version<EMAIL_ADDRESS>- Loading package information from registry...
✔ Package information loaded.
- Installing packages...
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/common
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^16.0.0-next.0" from<EMAIL_ADDRESS>npm ERR! node_modules/@nguniversal/express-engine
npm ERR<EMAIL_ADDRESS>from the root project

I think the problem is that the SSR bits we need are in Angular's 16.1.x branch which is currently marked as @next on npm. So by merging that PR we rolled back Angular bits needed for the SSR to work.
I propose that we change that version map to specify "next" or ">16.1.0-next.0". "next" is likely safer (clean rollback) for right now, and once Angular 16.1.0 is released we can pin to "^16.1.0".
update: I just spoke with @AndrewKushner and he explained to me that we accidentally pinned C3 to Angular@next in https://github.com/cloudflare/workers-sdk/pull/3232, which is incorrect as we need a "^16.0.1" version instead. So @eneajaho PR https://github.com/cloudflare/workers-sdk/pull/3247 correctly fixed this, but we haven't yet released this fix which was merged just a few hours ago.
Therefore to get to a good state with Angular, we need to cut a release from the main branch. No rollback needed.
FYI: @AndrewKushnir, @petebacondarwin, @eneajaho

fixed in<EMAIL_ADDRESS>that just went out.


https://pipelinedata.blob.core.windows.net/sampledata/mnist does not exist

This blob does not exist, and therefore the curl request that is supposed to trigger a batch score doesn't work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f24ec969-b354-a6ee-fde3-0b7e478a7827
Version Independent ID: 316e0373-e365-3e42-0529-850c06030b2b
Content: Use batch endpoints for batch scoring - Azure Machine Learning
Content Source: articles/machine-learning/how-to-use-batch-endpoint.md
Service: machine-learning
Sub-service: core
GitHub Login: @tracych
Microsoft Alias: tracych

@cindyweng we'll review your feedback and get back to you shortly. Thanks.

@tracychms can you please provide an accurate blob path based on above feedback? Thanks!

the blob path is accurate with mnist sample images. sample is working fine.
sample mnist image in blob: https://pipelinedata.blob.core.windows.net/sampledata/mnist/0.png

Can confirm now it's working fine. Might have been an outage issue?


Failed Criteria

In the GREYErrorFormatter, this changes the output key for failed criteria from "Assertion Criteria" or "Action Name" to "Failing Assertion" or "Failing Action", depending on whether an assertion or action failed.

Please diff this against the element-not-found PR.


Suggestions.

Awesome! My writing style can sometimes br... regrettably verbose. Huge walls of text arr daunting to the reader, and inevitability distract. This could be perfect for allowing me to expound upon a point without overwhelming the reader, to offer an aside which may not be critical to understanding the poking I'm making, but is tangentaly relevevant. Anyway... I really like this :)
Just trying the demo, the interaction feels very natural, unencumbering. It's got a nice UX flow. However, I think that it might be a good idea to offer some stronger visual cues to someone who perhaps doesn't realize that the underlined text means it will expand. Because it's in-line, your styling options are rather limited (so it doesn't mess up the spacing). Perhaps a small icon inline, or better yet a tooltip. You could even have it appear partially for a few seconds without hovering just so that the user knows there is a potential interaction.
So that's the first suggestion. The second: considered making the expanded yext distinguishable from the main body. Italics, a light grey background, smaller font with a heaver weight and lightened text color are all subtle things that could go a long way. Maybe one style could even reveal a block quote as apposed to a inlined text.
And finally, there should be some way to collapse the text. I tried double tapping the expounded text expecting it to collapse, de-clutter the screen. If attempted that instinctually, I'm sure others will as well.
Any way, awesome concept. Would line to hear your thoughts smoky my suggestion. I'll be certain to PR this ;)

Hello! I'm really glad you like this, what you describe is exactly what I had in mind when working on the concept. About your points:

You're right about needing stronger visual cues. Someone who's unfamiliar with the concept won't know why those words are highlighted. As with anything, it's a tradeoff (giving unfamiliar users visual cues vs not annoying familiar users). I think that users who haven't seen an expounder link before are likely to click on it just to see what happens, and the resulting animation and appearing text is probably clear enough that they'll know that those links make explanatory text appear. My general preference is also to leave it to the site's designer to choose exactly how they want links to appear, barring my preference for visual consistency across installations, which is indicated by the dashed underline.
Similarly, I don't think there's anything we can do here to make expounded text fit every site, if only because we don't know which elements will be expounded. Expounder doesn't just support text, it supports any element (images, videos, anything), so anything we add there might break people's functionality. That's why this is also left as something for the site owner to customize (and that's easy to do).
We've had a lot of feature requests for re-contracting links. I get the need to contract the links again as well, but, in my case, it's just OCD that "something that was closed shouldn't stay open". The expounded text becomes part of the overall narrative when opened, so I don't think adding an option to close it again is that useful, also because the user will have read the text by then and will move on, so the text remaining there doesn't hurt anything. Do you have another reason for wanting it collapsed? So many people have requested it that I'm considering adding it, I'm just not sure if it's OCD there as well or if there's a better argument that i'm not aware of.

Thanks for taking a time to give some feedback!

I'm in favor of add a re-contracting feature to allow correcting misclicks. If the user accidentally expands some text, they should be able to contract it if they want to.
Another reason to allow contracting links is if the text that is expanded is not actually helpful to the user. The user might realize on seeing the expanded text that they don't actually want to read it, particularly if there is a lot of it.

I like that it can contract now but the block o' text is still something that was jarring. Perhaps the expounded information can be visually separated more.
I tried something here using the text in this thread that demonstrates what I mean.
In the code the main thing would be converting the span of data-expounded to a div
CSS
div[data-expounded] {
    width: 100%;
    padding: 25px;
    box-shadow: rgb(47, 47, 47) 0px 0px 20px inset;
    border-radius: 5px;
    display: none;
    background-color: rgb(93, 93, 93);
}

JS
Abstracted for single term
var expounded_box = document.querySelector("[data-expounded]");

function toggle_ex(element){
    if (element.style.display != "none"){
        element.style.display = "none";
    }
    else{
        element.style.display = "block";
    }
}

var data-expounder = document.querySelector("[data-expounder]");
$(data-expounder).click(function(){toggle_ex(box);})

That looks nice, but it's more of a tool tip or lightbox, which is a different idea from what expounder tries to be. Of course, anyone should feel free to customize expounder, like you've done, but I'd like the default experience to remain a part of the text that's indistinguishable from the rest when expounded, both for the link and the text.

Fair enough. I guess it's up to the author and their ability to keep it simple to prevent too big a wall of text from emerging.


Add support for Linux

While most of cppcoro is platform agnostic, some of the thread-pooling and I/O code is OS-specific.
This issue is for providing an implemention of the cppcoro I/O abstractions for Linux.
Will need to get it building under Clang as a first step. See #3.
Then:

Look into writing an epoll I/O event loop, based io_service implementation.
Port file and socket (once written) interfaces to Linux.
Add build-system support for Linux

cppcoro is now at least buildable under Linux/Clang on the clang branch.
Still outstanding is the need to work on an implementation of io_service using epoll and then subsequent file/socket implementations.

For async file I/O for io_service I'm thinking of using kernel aio (ie. io_submit, io_getevents and friends).
Although from my research this seems to be somewhat limited in that it's only truly async for files opened with O_DIRECT.
For async socket I/O it seems like epoll is the go.
Need to investigate how to mix the two approaches (aio/epoll) in the same event loop.

So, did you guys start working on this?

I haven't started on Linux async I/O support yet.

I will work on it. But before I start can you help me compile the current code on linux? The build instructions aren't working for me.

Sure. Can you create a new issue to work through the build issue?

scheduler_operator_tests.cpp and io_service_tests.cpp are now working in linux. I will get file tests working as well and send a PR. I am using linux message queues as a sub for iocp, timerfd/eventfd for WaitableTimer/AutoresetEvent, and epoll for WaitForMultipleObjects. For files, I plan to send messages to the message queue from AIO's signal handling functions.

Great! I look forward to the PR :)
For AIO, can you use an eventfd as the aio_resfd parameter of the iocb block for an I/O request as a way to have it wake up the epoll() loop when the operation completes. When epoll() indicates that the AIO eventfd is signalled then you know you need to call io_getevents() to retrieve pending I/O completion events. This should avoid the need for signal-handling functions.
Or are you talking about something different?

That's right! I will try the resfd way. I remember a while ago that it wasn't stable. Its been long. They should've worked it out by now...

@lewissbaker Got a chance to try it out? I have a fixed few things. Will send another commit into the PR soon.

@neo5167 I have started reviewing the code and am about 50% through.
I have had quite a number of other distractions the last couple of weeks, though, so it's taking a little longer than I'd hoped. I hope to finish the initial pass of the review soon.

@lewissbaker @neo5167 thanks for the library and the port for Linux!
I grabbed a copy it and used it in the prototype application I am playing with. One issue I noticed is that the POSIX message queue based message_queue is pretty slow, it became a bottleneck when I need to do lots of io_service.schedule()/resume_on(). I plugged in Cameron Desrochers's lock free queue with built-in block queue wrapper, it solved my problem.
I guess this might be useful. Thanks.

@lni Thanks for the input. I will take a look at that and see how we can use that.

@lewissbaker Is it possible to get a private email address to chat with you? I wanted to go over somethings but prefer doing it in a private setting. Thanks!

@neo5167 Sure, no worries. My email is my github username at gmail dot com.

The linux scheduler and timer support code (beta) is at the following fork if anyone wants to try:
https://github.com/neo5167/cppcoro

Hows linux support as of today?

I did implement the linux support for an older version that is here:
https://github.com/neo5167/cppcoro

There any important upstream changes in cppcoro branches that I'd be missing out on? It work? ;)

oh btw one thing I noticed with your repo @neo5167  is the definition of the linux inner namespace conflicts with some other projects pre-processor definition of linux=1.

Alright cool @neo5167  got it building with vcpkg, will report back if I find anything, here's the port file info if anyone is needing it: https://bitbucket.org/aparavi/vcpkg/src/aparavi/ports/cppcoro/

Hi there! Am I right to see, that the work on the Linux support is suspended right now (last comment on December 21st)? Any chance I can offer my help?

Hi there !
I just implemented the io_service, file and net APIs using liburing.
There are some requirements: GCC10 (10.2 fixes some compilation errors in lambda captures within a coroutine) and kernel >= 5.4 (5.5 for accept, connect, send, recv operations).
This is still a work-in-progress stuff but it is almost functional.
Check my fork.
Tell me what you think about it.

All tests passing !
make -j && ctest
[...]
100% tests passed, 0 tests failed out of 160

And my cppcoto-http extension works pretty well :)


cmd/exec should be os/exec

The page refers to a cmd/exec package. It should say os/exec.

Thanks! Will be on the site shortly.


Virtual tissue cutting in real-time medical simulations

Hello @loopstring ,
first of all, big thanks for sharing this code! Great work - mesh cutting is a super challenging topic and, beside tetcutter, I am not aware of any other open code in this field. May I ask if you are the author behind the Adaptive Virtual Node paper? If yes then I would like to congratulate on your work!
I have smoothly integrated your code with my Position Based Dynamics simulation framework in Unity3D and run some initial test. https://cdn.pbrd.co/images/H8e6mfy.jpg
So far so good. However, there is still a long way before apply this method in simulation.
For example, any general suggestions on how to tackle the  gradual cutting, e. g. when scalpel is going through the tissue?
Currently, it seems that there is no snapping or resulting structures optimizations. Also the edges of cutting mesh generate new nodes on the cutted mesh.
In other words, what are the plans for further developments? Are you interested only in the cutting algorithm alone or you'd like to push it further towards complete out-of-the-box solution
Thank you

Hi @korzen ,
Thank you very much for the feedback.
When scalpel moves from an old position to a new one, generating a new cutting surface between the two positions and using that to cut the mesh might work.
The subdivision step and resulting structure should be close to optimal for resolving the intersection points. For the new nodes, I will update the code to clean them up if they are not part of the mesh.
I definitely would love to push out a more complete solution, but haven't got enough bandwidth to do so yet, and the timeline is not quite clear at this moment. Sorry about that!


docs: Rewrite setState with function argument in first example

This small change is off the main point of the example code :)
However, while learning React, I have often followed even small details of clearly-written examples like this without clearly understanding what I was doing. If I understand correctly, a function argument is now the public recommendation when next state depends on previous state:
https://facebook.github.io/react/docs/state-and-lifecycle.html#state-updates-may-be-asynchronous

Thanks @pedrottimark! I knew it was possible to pass a function to setState but I didn't know it was a recommendation. Can you update the README.md file as well?

Current coverage is 100% (diff: 100%)

Merging #28 into master will not change coverage

@@           master   #28   diff @@
===================================
  Files           3     3
  Lines          46    46
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           46    46
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update e010536...c3d9bea

@adriantoine Yes, good point, I had edited README.md and thank you for reminding me to edit the code in test/examples.test.js
Do you prefer that I push another commit or squash them and force push to my fork?

@pedrottimark don't worry you can push another commit, I'll squash it using GitHub "Squash and merge" anyway 😊

Great! Thanks for your contribution! @pedrottimark

Oh you have even added the semantic-release prefix to the PR 👌


cargo guide: guidance around selecting the version of a dependency?

Problem
In the cargo guide, the page on dependencies (https://doc.rust-lang.org/cargo/guide/dependencies.html) describes how one can add specific versions of a couple dependencies, e.g. by editing Cargo.toml:
[package]
name = "hello_world"
version = "0.1.0"
edition = "2021"

[dependencies]
time = "0.1.12"
regex = "0.1.41"

and then links to external documentation regarding SemVer and how other / newer versions of packages could be requested.
However, the documentation doesn't provide any specific guidance around how one should normally choose the versions of their dependencies. Is there any existing convention in the community? For example:

Prefer using the latest major release?
Look at the documentation on crates.io, and make a choice there?
Use an external tool to add dependencies to the project?

It might also be worth documenting the use of cargo add, once https://github.com/rust-lang/cargo/issues/2179 becomes part of stable.
It would also be nice if the crate versions chosen in this documentation matched a more current version (regex is currently 1.5.5, based on https://crates.io/crates/regex).
Proposed Solution

Consider providing some guidance for users on how dependency versioning should be done.

In particular, note if there are any consequences for downstream users if you plan to build a rust library?

Document and describe the use of cargo add?

Notes
No response

I also stumbled on a semi-related entry in the FAQ:
https://doc.rust-lang.org/cargo/faq.html#can-libraries-use--as-a-version-for-their-dependencies
which I think implicitly recommends versioning of the form 1.4.* or 1.*.

For how precise to be, there was a users thread on that subject.

It might also be worth documenting the use of cargo add, once https://github.com/rust-lang/cargo/issues/2179 becomes part of stable.

In addition to the guide page, we should also consider the reference page.  The former can focus more on cargo add but the latter needs to go into all the details and not get distracted too much with cargo add.  Both can cross-link to cargo add's documentation page.
We've also talked about getting crates.io to be updated to reference cargo add.

@kevinushey - I agree with you about your interpretation somewhat. That FAQ answer is saying that you may use 1.* or 1.4.* (at least for a package published to crates.io), but it isn't recommending that you do so.
If the package is following semantic versioning, the constraint I would like is "MAJOR number must be exactly X, MINOR number and PATCH must be at least Y.Z". But I don't know if I can enforce that in Cargo?
The other question I don't know the answer to, but it seems relevant, is this: Suppose my package A depends on packaged B and C. And B and C both depend on package D. Is my build of package A faster if B and C depend on the same version of D?
Sorry I'm not adding answers here - I'm just flagging some ways that I, as a relatively inexperienced Cargo user, also get confused.

"MAJOR number must be exactly X, MINOR number and PATCH must be at least Y.Z". But I don't know if I can enforce that in Cargo?

You are looking for the ^ requirement, witch is also the one you get if you do not use a symbol. ^X.Y.Z or X.Y.Z (If X is 0, then it is MINOR number must be exactly Y, PATCH must be at least Z")

Is my build of package A faster if B and C depend on the same version of D?

Yes, Clean builds will generally be faster when things unify. But, developers want the latest changes from there deps and want a way to upgrade. As a compromise, Cargo will try to get the largess version for each dep (even if that means having D 1.0.0 and D 2.0.0 in the tree), but will only select one semver compatible version in each category (so a requirement ^1.0 may resolve to 1.5 even if 1.9 is available so that it can unify with some other requirement >=1.0, <=1.5).

This might deserve it's own issue, but I found my way here wishing that cargo add could resolve the version for me, but leave out the patch version. Maybe something like this?
cargo add (crate) --minor

I love that cargo add can go find the latest version for me, I just don't want it to lock all the way to the patch version.
As a workaround I run add then remove the patch version from my Cargo.toml manually.

People have requested options for controlling the precision but I've generally pushed back

We want to keep the scope narrow so the --help is not overwhelming for new users and they run into paralysis from choice
We want to keep the scope for cargo add narrow to not overwhelm the cargo team
Workarounds exist, either by manually editing or by manually adding
We prefer full precision as its the safest minimal version of the dependency

However, to support people who do customize their precision, cargo upgrade preserves the existing precision.


openssh: put tests into passthru

openssh tests are very slow (they take ~30 mins because they are not parallelized). This makes rebuilding (esp. after changes e.g. to systemd) painful. Putting the tests into a separate derivation solves this without losing any testing capability.
Debian does the same: https://packages.debian.org/sid/openssh-tests
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test openssh

I don't think Hydra automatically builds passthrough.tests so it will not build the tests as part of building openssh.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1346

Suggest using the finalAttrs/finalPackage pattern instead of taking openssh as an argument. This will ensure you're testing the exact variant you think you're testing.

I am basically doing the same in an overlay since a longer time because the tests are so annoyingly slow.

hm. why does this fail on aarch64-linux?

I think that was just an ofborg runner issue

I don't think Hydra automatically builds passthrough.tests so it will not build the tests as part of building openssh.

@nikstur I really would like to merge this, but this feedback ^^ needs to be addressed.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1559

this feedback ^^ needs to be addressed.

I guess the solution is to explicitly add the openssh tests to a hydra jobset. I don't know much about hydra though. Any pointers would be appreciated.

this feedback ^^ needs to be addressed.

I added this to release-small now. I would love if someone that knows more about hydra could review this.

Seems to evaluate on my machine:
nix-eval-jobs -- --force-recurse nixos/release-small.nix  306.57s user 137.58s system 52% cpu 14:04.92 total


Simplify Shelley listPools operation.

Issue Number
#1847
Overview
This PR tidies up some loose ends from PR #1847:

[x] Coalesces the various pool DB data merging functions into a single function with a more straightforward type.
[x] Simplifies the definition of readPoolDbData.
[x] Revises comments for readPool{Registration, Retirement} functions.

bors try

bors r+

bors r+


added nina-mir

Related issue

What changes does this PR do?
adds my name
Screenshots (If any)

Questions

closing due to inactivity


Start removing superflous fields for facet

In my (really quite limited) understanding, the fields that are defined in the facet schema aren't actually used for anything.

They're not used in the content-tagger tagger UI that people use to tag content
They're not used in finder-frontend and search-api because we never expose the facet of a content item (only the facet_group and facet_value)

I'm 100% confident about this! Please tell me if I'm wrong.

Closing this as the team won't use the facet system anymore, so leaving this for later!


fine tune iproute2 update

Merging this since I merged the earlier one, well, early. :)

This will only install the updated iproute2 if vxlan is the default Tenant network type, not if it is an enabled type driver but not the default. I don't think we have any stacks in this configuration, but I would rather not leave a land mine.


mevn init fails on windows

Do you want to request a feature or report a bug?
Think its a bug
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.
If I use mevn init  (used my own appname like cookies to test it out) and selected default => single page app => nodejs hosting =>   server side template (I selected yes)
What is the expected behavior?
If this is a feature request, what is motivation or use case for changing the behavior?
To work without outputting an error after mevn init completion
Local Environment Information
Please paste the results of mevn info here.
after I've done mevn init it  outputs this error in my command line
`
You're all set
Now, just type in cd cookies && mevn serve
(node:1580) UnhandledPromiseRejectionWarning: Error: Command failed: C:\Windows\system32\cmd.exe /q /s /c "rmdir /s /q cookies.git"
The system cannot find the file specified.
at makeError (C:\Users\PC\AppData\Roaming\npm\node_modules\mevn-cli\node_modules\execa\index.js:174:9)
at module.exports.sync (C:\Users\PC\AppData\Roaming\npm\node_modules\mevn-cli\node_modules\execa\index.js:338:15)
at handleShell (C:\Users\PC\AppData\Roaming\npm\node_modules\mevn-cli\node_modules\execa\index.js:117:9)
at Function.module.exports.shellSync (C:\Users\PC\AppData\Roaming\npm\node_modules\mevn-cli\node_modules\execa\index.js:361:43)
at showInstructions (C:\Users\PC\AppData\Roaming\npm\node_modules\mevn-cli\lib\commands\basic\init.js:71:21)    at _callee$ (C:\Users\PC\AppData\Roaming\npm\node_modules\mevn-cli\lib\commands\basic\init.js:210:13)
at tryCatch (C:\Users\PC\AppData\Roaming\npm\node_modules\mevn-cli\node_modules\regenerator-runtime\runtime.js:63:40)
at Generator.invoke [as _invoke] (C:\Users\PC\AppData\Roaming\npm\node_modules\mevn-cli\node_modules\regenerator-runtime\runtime.js:293:22)
at Generator.next (C:\Users\PC\AppData\Roaming\npm\node_modules\mevn-cli\node_modules\regenerator-runtime\runtime.js:118:21)
at asyncGeneratorStep (C:\Users\PC\AppData\Roaming\npm\node_modules\mevn-cli\lib\commands\basic\init.js:27:103)

(node:1580) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1580) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
`
Screenshots
If applicable, add screenshots to help explain your problem.
Nope sorry
Additional context
Nope sorry

init.js
diff --git a/src/commands/basic/init.js b/src/commands/basic/init.js
index 3ac33b8..5432bc1 100644
--- a/src/commands/basic/init.js
+++ b/src/commands/basic/init.js
@@ -57,8 +57,6 @@ const showInstructions = () => {
   console.log(chalk.cyan.bold(`You're all set`));
   console.log(chalk.cyan.bold(`Now, just type in ${userCommandInstruction}`));

-  let removeCmd = isWin ? 'rmdir /s /q' : 'rm -rf';
-  execa.commandSync(`${removeCmd} ${path.join(projectPathRelative, '.git')}`);
   makeInitialCommit();
 };

Feel free to send a fix.


Don't depend on sphinx-build on PATH, use sphinx installed on the same interpreter

Fixes #58
Fixes #74
Some of my CI/CD pipelines were failing because of this. The problem arises if sphinx-build in the local PATH points to a different python version from the main sys.executable.

Coverage remained the same at 76.068% when pulling d824913ba95f32d49c07ab2c8c03640458d5d2ca on KristianHolsheimer:develop into e0f40b6359ca00a48ca5ba903de1e25da27de453 on GaretJax:develop.

@GaretJax The CI pipeline is failing, because pyaml doesn't like python 3.4:

Collecting PyYAML>=3.10 (from -r requirements.txt (line 4))
PyYAML requires Python '>=2.7, !=3.0., !=3.1., !=3.2., !=3.3., !=3.4.*' but the running Python is 3.4.8

Would you be able to fix this? And if so, would you be able to let me know when I can rebase?

Thanks for this PR @KristianHolsheimer! I recently got the commit bit here -- #81 -- I'm taking a bit of time modernizing stuff here.
I'll ping you here once all of that is done! ^>^

This looks like a reasonable alternative fix for #58.

@pradyunsg I rebased on develop

Many thanks @KristianHolsheimer! ^>^


Bump version of Jinja macros to 3.0.0 which uses GOV.UK 5.1.0

User Need
As an engineer
I want our code to use the latest relevant versions
so that it is up to date
Value
Keep code up to date
Functional Requirements:

Update to use latest govuk-frontend-jinja (3.0.2) and govuk-frontend (5.1.0)

Fix any compatibility issues

Acceptance Criteria:

[x] Code uses latest govuk-frontend-jinja
[x] Code uses latest Jinja compatible version of govuk-frontend
[x] Code adapted to improve ease of future updates
[x] Tests pass

📝 Notes

The new version of govuk-frontend phase banner has changed to improve contrast for accessibility.

Notes:

https://github.com/ministryofjustice/operations-engineering-join-github/pull/186


feat: Add global search bar

Pull Request
📖 Description
from

to

Example when typing valid content:

Note: Hides on mobile - future work could make it nice & responsive. Probably an Icon only button that pops up a fullscreen overlay

🎫 Issues

Fixes #1578
👩💻 Reviewer Notes

📑 Test Plan
Manually test the nav menu looks the same (I tested each item 1 by 1 & saw no difference).
Test that the search bar behaves as a nice UX.
✅ Checklist
General

- [ ] I have added tests for my changes.
Not done - No tests in Demo site

[x] I have tested my changes.
[x] I have updated the project documentation to reflect my changes.
[x] I have read the CONTRIBUTING documentation and followed the standards for this project.

@microsoft-github-policy-service agree

@Hona It's a pity that the search component doesn't work with keyboard arrows. This is a problem for our Accessibility rules. Would it be possible to make another PR and replace it with a FluentAutocomplete, for example? We'll have to see beforehand if it works in the same way :-)

Probably because you used a FluentSearch and a FluentMenu. And pressing Down/Up keys don't select an Items. The FluentAutocomplete do that.


Add Child Asset button on subasset page results in blank section

Screenshot added

Designed that way for now. Need to check if it is possible to disable the button.

Fix is available in the latest uploaded DTM version


(WIP) add additional multicast operations

Waiting on the libc release
Corresponds to similar changes in net2

Thanks! I've published libc now and I think there may be a compile error on Windows?

Thanks for publishing. I’ll take a look at the windows failure when I have a minute.

Thanks!


order_service.place_order() does not return any reponse

When placing order using order_services, Order is placed but it does not return any response. Looking at the code, it seems it is supposed to return a json response.

I think this is a problem with the td ameritrade api and not the python module.


Fix issue #10 (eq is too rigid)

I guess this fixes the issue, right?

While at it I applied some refactorings of duplicated logic in d481a7c. If you do not want to mix the bugfix with a refactoring I could move it to a seperate PR (or drop it alltogether, if you find it too invasive).

The Python documentation actually enforces to return NotImplemented when comparing to another type is not supported. This way, the runtime will also ask the other Operand what it thinks about this comparison:
>>> class Thing:
...     def __eq__(self, other):
...             print(f"{self} == {other}")
...             return NotImplemented
...
>>> Thing() == Thing()
<__main__.Thing object at 0x7ff20a877a60> == <__main__.Thing object at 0x7ff20a8abd30>
<__main__.Thing object at 0x7ff20a8abd30> == <__main__.Thing object at 0x7ff20a877a60>
False
>>> Thing() == 1
<__main__.Thing object at 0x7ff20a8abd30> == 1
False
>>> None == Thing()
<__main__.Thing object at 0x7ff20a8abd30> == None
False

You can see how the runtime first asks the left operand, than the right operand about this comparison. As int and NoneType have the same behavior of returning NotImplemented when being compared to our Thing, we get the chance to answer this comparison (if, for example, we wanted Thing to be comparable to a number, even if it is on the right side of a comparison). :-)


ion-infinite-scroll threshold cannot be a percentage

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
I'm submitting a ...
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Threshold value for infinite scroll does not work when the value is a percentage. But when it's a pixel value, it works properly.
Using for example a "50%" value, the event is not fired when reaching 50% of the content but is fired when reaching 100px distance from the bottom I guess. That same value I found searching for 'threshold' in the source code.
Expected behavior:
When scrolling to 50% of the screen, the infinite scroll event should be fired.
Steps to reproduce:
Demo here: http://plnkr.co/edit/yQ8E8syVZtkA2mBs9TPU?p=preview
Related code:
<ion-header>
  <ion-navbar>
    <ion-title>{{ appName }}</ion-title>
  </ion-navbar>
</ion-header>

<ion-content padding>
  <ion-list>
   <ion-item *ngFor="let i of items">
     my item value
   </ion-item>
 </ion-list>

 <ion-infinite-scroll threshold="50%" (ionInfinite)="doInfinite($event)">
   <ion-infinite-scroll-content></ion-infinite-scroll-content>
 </ion-infinite-scroll>
</ion-content>

Other information:
As said in the documentation here: https://ionicframework.com/docs/api/components/infinite-scroll/InfiniteScroll/
The threshold value can be a percentage. If it's not the case, the documentation should be updated.

The threshold value can be either a percent, or in pixels.

Ionic info::
cli packages: (/Users/mycuistot/.nvm/versions/node/v6.10.2/lib/node_modules)

    @ionic/cli-utils  : 1.10.2
    ionic (Ionic CLI) : 3.10.3

global packages:

    Cordova CLI : 7.0.0

local packages:

    @ionic/app-scripts : 2.1.4
    Cordova Platforms  : android 6.2.3 ios 4.4.0
    Ionic Framework    : ionic-angular 3.6.0

System:

    Android SDK Tools : 25.2.5
    ios-deploy        : 1.9.0
    ios-sim           : 5.0.13
    Node              : v6.10.2
    npm               : 5.4.1
    OS                : OS X El Capitan
    Xcode             : Xcode 8.2.1 Build version 8C1002

Hello! Thank you for opening an issue with us!
It is easier to see how this works with numbers in place, so I changed your code as such:
export class HomePage {

  appName = 'Ionic App';
  items: Array<string> = [];

  constructor(public navController: NavController) {
    this.addItems(100);
    }

  doInfinite(scroll) {
    alert('scrolling');
    setTimeout(() => {
      this.addItems(16);
      scroll.complete();
    }, 500);
  }

  private addItems(c: number): void {
    for (let i = 0; i < c; i++) {
      this.items.push(`item # ${this.items.length + 1}`);
    }
  }

}

Some of this depends on how fast you scroll, so scroll at a moderate pace. Also, the current size of the page matters. On my display, your plunkr shows 16 items.
With the threshold set to 50%, I expect doInfinite() to kick in around the item number 92 mark (display holds roughly 16 items,  half of that is 8 items, I have 100 items, 50% of the screen from the bottom is then 92 items).
With the threshold set to 50px, I expect doInfinite() to kick in around the item number 100 mark as the items are close to 50px tall themselves so the 50px left threshold would be passed around item 99 or so and by the time things register item 100 will likely be shown.
If you scroll at a reasonable speed, you will see that this is indeed the way things play out with the code above. You will also see that this is the way things continue to play out as items are added. With the threshold set to 50%, the fetch is triggered when roughly half of a screen height of items are left unshown, and with 50px when basically the last item is shown.
So far as I can tell, everything is working as designed. I will close this.
Thank you for using Ionic

Hi. I believe it does not make sense to set a % threshold of the display. If I set the threshold to be 50% I expect doInfinite() to trigger at 50% of scroll height or similar. This is what @WilliamDASILVA meant.


Rework the "where to go from here" section to track items we want to teach

This is part of the cleanup described in this issue:
https://github.com/rust-embedded/discovery/issues/231

r? @andre-richter
(rust_highfive has picked a reviewer for you, use r? to override)

bors r+


Fix typo in title: dashbaord -> dashboard

Yes, that must be it. I just changed one word in the .Rmd and hit knit then committed the index.Rmd and index.html files. A whole bunch of other index_files changed as well but I didn't commit those.  Is that OK or is there something you'd like me to do differently?

I'm going to be showing the dashboard during a talk tomorrow afternoon (around 2pm UTC) so if it was possible to fix/merge this by then, that would be nice.

Sorry for the delay! I just noticed my Gmail app hadn't been updating for 2 days
thanks again for the fix!!


Why not add useCss to this library?

This library has 95% of the functionality in the useCss hook but isn't itself made available in this library. I would prefer to add just nano-css rather than react-use since the dependency tree for that package is pretty large. Obviously it's not too crazy to just add the useCss code directly to my project but it would be nice to just include it directly from this package. Thanks for the nice work on this package!

We can do that. PR for this is welcome!


Bython modifies braces within strings.

Bython v0.8  exhibits a problem in which it modifies braces within single and double quotation strings.
Code to reproduce:
test.by:
print('Hello, world! I have braces {} here.');
print("Hello, world! I have braces {} here, too.");
The output produced is:
Hello, world! I have braces:here.
Hello, world! I have braces:here, too.
The expected output is, of course:
Hello, world! I have braces {} here.
Hello, world! I have braces {} here, too.
Thanks!

From the issue I can tell no good grammar tree is build for braces analysis, it's no good to rely on the project.

+1

Old issue but I wrote this and maybe it will work better for you, if you still want it
Bython

+1


Misc fixup

Vim swap files (boo hiss I know)
npm scripts over broken bin scripts :stuck_out_tongue:
Continuation of my IIFE crusade

CR @lanetix/engineers
Also, I can't push to this repo hence the fork.

Maybe not for this PR, but it makes sense to create a template README.md file with some basic headers so people can fill out the details about the microservice once it's generated.
If that's a future PR, then :bow:.

#3 created for ^^

Good suggestion @tone81

:ship:

I really like @tone81's suggestion above.


Game crashes on /txt command

Resolves issue #120

This PR fails Poggit CI checks because FormAPI isn’t updated on Poggit (see this issue)


Unknown Host URL for Announce

Hi in Sia latest client I can't even use it because of strange visual glitches, so I moved to 0.5.0-rc.
Now when I try to host some GB and announce my hosting, it asks for me to specify a URL to announce on.. what URL do I use??

Your IP, or your hostname if you have one.

Don't use the release candidates. They have substantially altered constants and are not fit for regular use. They are just meant to pilot new features.


fix Makefile to unbreak build with newer go

With go 1.7 on OpenBSD; linking fails:
/usr/local/go/pkg/tool/openbsd_amd64/link: -X flag requires argument of the form importpath.name=value

I dont know in which version the -X foo=bar syntax was added and what version of go you're planning to support, but tweaking Makefile#L133->136 to use it fixed the issue for me.

Hi @landryb,
We'll update the Makefile. If I recall, support for -X foo=bar was added in Go 1.5. So it will become the minimal version required to build Facette.

I am having this same error message when trying to build facette 0.3.0 on FreeBSD with go-1.7.1.
Could you please let me know how you tweaked the Makefile to fix this problem?

The following patch works for me:
--- Makefile.orig       2016-10-01 10:18:24.965128000 +0800
+++ Makefile    2016-10-01 10:18:48.102780000 +0800
@@ -116,10 +116,10 @@
@$(call mesg_start,$(notdir $@),Building $(notdir $@)...)
@install -d -m 0755 $(dir $@) && $(GO) build
-ldflags " \

                          -X main.version $(VERSION) \

                          -X main.buildDate '$(BUILD_DATE)' \

                          $(PKG_LIST:%=-X github.com/facette/facette/%.version $(VERSION)) \

                          $(PKG_LIST:%=-X github.com/facette/facette/%.buildDate '$(BUILD_DATE)') \

                          -X main.version=$(VERSION) \

                          -X main.buildDate='$(BUILD_DATE)' \

                          $(PKG_LIST:%=-X github.com/facette/facette/%.version=$(VERSION)) \

                          $(PKG_LIST:%=-X github.com/facette/facette/%.buildDate='$(BUILD_DATE)') \
                  " \
                  -tags "$(TAGS)" \
                  -o $@ cmd/$(notdir $@)/*.go && \

Hi,
I just push a fixed  version of the Makefile in 7ae8cc2e337eb047c2939cd86949a0003bdd0d3f.
Go 1.5 will now be the minimum required version to build Facette.


Reverse examples/plugin dependency relationship.

This moves tests that depend on the plugin from concat-examples to
concat-plugin. The one shortcoming, IMO, is that it requries duplicating
the SMT flag.

It would be helpful for us to have this change in.

This looks good to me. @conal, any objection to us merging this one?

Just rebased & merged it.

Sorry I forgot about this one.
Do all of the examples still build and work, including graphics (WebGL) and SMT?

So graphics builds, and test suites run. SMT compiles - is there a test suite or example for that one?

(I.e. @conal, I see the comment about this in the README, but don't see what exactly I should uncomment in Test/Examples.hs.)

@mikesperber Thanks. I don't remember how to test SMT, and I'm happy to assume that it'll work out fine (or doesn't matter).


CI | Rearrenge the CI job dependency

Now all our CI tests will be triggered at a same time once a PR is made. This is somehow a huge cost of resource given that we now only have limited instances like IBM SE. A typical scene is when we find some bugs with rust lint, we will go back to fix regardless of the outcome of e2e tests.
We'd better add some dependency relationship between the tests, e.g.

Only rust suites tests are triggered once a PR is made
Only after a good successful rust suites test is passed, e2e/docker build tests can be triggered

This would help use to avoid needless e2e tests to occupy much computation power.

We might also try the non-tee/sample tests before running the hw-specific ones.


Can this works on android phones that dont have gms battery-included ?

Is your feature request related to a problem? Please describe.
when i run a demo of this plugin on android emulator, i got this msg.

most android phones in China don't have google play services out-of-the-box, so i'm wondering if this can work on a phone that don't have gms ?
Thanks !

Hi,
Thanks for using the plugin. 'Play services' is required for the barcode scanner to work as it is dependent on google vision API. So devices which don't have gms it won't run.

Get it,
Thanks !

I'll update you on this whenever barcode scanning will not be dependent on GMS. Thanks.

how deal this problem;

Would this fix the issue? https://github.com/AmolGangadhare/flutter_barcode_scanner/issues/35


502: fcgi: invalid header version

What happened?
I am building a docker image with frankenphp using tag 1.0.3-php8.2 but all pages gives me a 502.
Build Type
Docker (Debian Bookworm)
Worker Mode
No
Operating System
macOS
CPU Architecture
Apple Silicon
Relevant log output
app-1  | {"level":"error","ts":1707671625.8918583,"logger":"http.log.error.log0","msg":"fcgi: invalid header version","request":{"remote_ip":"<IP_ADDRESS>","remote_port":"57338","client_ip":"<IP_ADDRESS>","proto":"HTTP/1.1","method":"GET","host":"localhost:8181","uri":"/user/login","headers":{"Connection":["keep-alive"],"Sec-Fetch-User":["?1"],"Accept":["text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7"],"Sec-Fetch-Mode":["navigate"],"Sec-Fetch-Site":["none"],"Accept-Language":["en-US,en;q=0.9,nl;q=0.8,da;q=0.7"],"Upgrade-Insecure-Requests":["1"],"Sec-Ch-Ua-Platform":["\"macOS\""],"User-Agent":["Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36"],"Sec-Fetch-Dest":["document"],"Accept-Encoding":["gzip, deflate, br"],"Cookie":[],"Sec-Ch-Ua":["\"Not A(Brand\";v=\"99\", \"Google Chrome\";v=\"121\", \"Chromium\";v=\"121\""],"Sec-Ch-Ua-Mobile":["?0"]}},"duration":0.002536749,"status":502,"err_id":"0tg0qz2zz","err_trace":"reverseproxy.statusError (reverseproxy.go:1267)"}

Do you use a custom Caddyfile? FrankenPHP doesn't rely nor use FastCGI.

Oh my.. I thought i had removed that already :(
My bad :D


_now TXT Record Deleted, what's my Token ?

When attempting to transfer over my domain to Now.sh from Heroku, I was configuring my DNS via Cloudflare and deleted my _now TXT record without realizing the difficulty of getting the token back. I am unable to alias my domain properly and have hit a roadblock. Any help would be greatly appreciated.

Thank you so much for the effort you have put into this issue! 😊
However, since we completely re-worked the entire codebase of Now CLI and this issue does not apply to the new code anymore, I'm closing it now.
You can read more about our biggest release yet here: https://zeit.co/blog/now-2


Tracking pixel coordinates

Hello
I'm building a project with OpenSeadragon to inspect large objects. In order to do this, I need to know the coordinates of the pixel where the cursor is placed to find out the distance in mm to a certain point of the image that I already know.
The fist approach that I tried is use imaginghelper plugin, but when the object is created it raises an error:
Cannot read x property of null in viewer.viewport.contentSize.x
The code that I wrote for that is this one:
viewer = OpenSeadragon({
		id:            'map',
		prefixUrl:     'openseadragon/images/',
                tileSources: url,
		showNavigator: true
     });
var imagingHelper = viewer.activateImagingHelper({onImageViewChanged: onImageViewChanged});

Seconldly, I tried to add a handler that captures when the user clicks on the image, but it returns the coordinates on a single tile, not the coordinates on the whole tiled image. The code that I used for this is:
viewer.addHandler('canvas-click', function(event) {
        console.log('click', event.position);
 });

Is there any way to do this?
Thanks in advance

Perhaps the imaging helper issue is due to this issue:
https://github.com/msalsbery/OpenSeadragonImagingHelper/issues/9
You might try pinging the author there, or even proposing a patch.
Anyway, it's easy enough to translate to image coordinates. The event.position from the canvas-click event is in web coordinates, relative to the viewer, so you'd just need to do:
var imagePoint = viewer.viewport.viewerElementToImageCoordinates(event.position);

For more information on the various coordinate systems, see:
http://openseadragon.github.io/examples/viewport-coordinates/

Thanks for your quick response.
I choosed the second aproach and it works with viewerElementToImageCoordinates method.
I'll try to work further with the imaging plugin issue just in case that I were able to find a solution.
regards


[stable/mariadb] Replace maintainer in Chart.yaml

Replace bitnami-bot by Bitnami as maintainer
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md

/lgtm


Add ComposeExtension selectItem support

@BillZengMSFT,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Store squeak in database using full raw data

This should simplify the table model

https://github.com/yzernik/squeaknode/pull/442


search/replace backslash in code Editor. Backslash disapears.

What steps will reproduce the problem?

"Ctrl + F" (or "Ctrl + H")
type \ in the search box
type F3

What is the expected output? What do you see instead?
I would expect that the next \ is searched/replaced.
instead, the \ disapear from the search box, which stop the search.
Versions and main components

Spyder Version: 3.0.0dev  (Oh, I though I had a regular version !)
Python Version: 3.5.1 64bit
Operating system: Windows 7 64bit

Dependencies
I have a bad dependency : jedi 0.9 is too high according to the dependency checker
jedi; >=0.8.1;<0.9.0 ; installed=0,9;  (Experimental) Editor's code completion, go-to-definition and help

Thank you for your report ! There is alredy an existing issue about it (#3141) so I'll close this one.


Feature request: Jake tasks integration

VSCode Version:
OS Version:

Steps to Reproduce:

List tasks
Jake tasks should be listed

@vp2177 is this something that could be accomplished with an extension?

@Tyriar yes even though VSCode has built-in support for grunt and gulp tasks, actually, the docs also mention Jake: https://code.visualstudio.com/docs/editor/tasks#_autodetecting-gulp-grunt-and-jake-tasks

@waderyan @gregvanl did we remove Jake support due to low usage or something?

I was not aware of this. @chrisdias do you have context for this? We talk about Jake in the docs, but we don't show it with the Configure Task command.

We may need to simply update the docs and then keep this alive as a valid feature request to bring Jake back.

yes, jake had very low usage.
cc @dbaeumer

+1 for updating the doc and keep this around as a feature request.

Doc issue here - https://github.com/Microsoft/vscode-docs/issues/636


Allowing the user to drop a folder onto the “Drag Races compatible wi…

…th this slot here” for wardrobe items.  It will then do a recursive folder search for all RaceData elements and add them to the list of compatible races for that particular asset.
The only drawback of this is the error ArgumentException: Getting control 8's position in a group with only 8 controls when doing DragPerform due to the list changing in the middle of an OnInspectorGUI() call.  However, I have noticed no negative side effects to this.

Adding a fix for a null ref exception when your options do not have "saveColors" as a selected option.

Adding a fix for a null ref exception when your options do not have "saveColors" as a selected option.

Merged - thanks


Fix FileWatcher DELETE event reporting and rearrange tests

This pull request have 2 different but related main changes:

The FileWatcher was skipping DELETE events, except on very weird cases where the file was deleted and re-created just before the event was triggered by awatch().
This also extends the integration test to test both situations (delete events when a file exist and when it doesn't).
Because there is usually a considerable delay between a change in the filesystem happens and awatch() emits an event it is difficult to decide if we should filter events based on the file existing or not. For example, if a create event is received but before is triggered the file was removed, should we emit the create event or not? Or the other way around, should we emit a delete event if a file was created again before the event was triggered.
It is probably best to leave this decision to the user, and let them deal with races.

FileWatcher tests were rearranged and split between unit and integration tests.
The existing tests were really integration tests, as they are not only testing FileWatcher, but also Select and PeriodicTimer, which is confusing when there is a bug in any of the other classes as we might get test failures here (this actually happened during the development of #79).
Because of this the current tests were moved to test/util/test_integration.py. We also mark the tests with the pytest mark integration to make it more clear they are integration tests, and to enable an easy way to only run (exclude) integration tests.
New unit tests were added to the current test file, properly mocking awatch to avoid interactions with the OS.
There are many more integration tests posing as unit tests, but this PR only takes care of FileWatcher. With time we should move the rest too.

I would make a release after this is merged.

@leandro-lucarella-frequenz can you please wait for a simple PR that addresses #53 which is based on the changes on this PR?


test(PanoImageRenderer): added equirectangular render test

added "coverage:chrome" build script
Issue
#45
Details
Added equirectangular render test using resemblejs.
To run the renderer tests, run command "npm run test:chrome" or "npm run coverage:chrome",
because currently webgl is not available on headless chrome.

Coverage increased (+7.6%) to 45.035% when pulling 3a51c99b68bd125a4fca8e522ad91bcde1ec87bc on YawPitchControl#35 into 98f6af56ec9b1b898cc20de7c7e5e7984687ad51 on master.

Coverage increased (+7.6%) to 45.035% when pulling 63da4f7f185def0c290ab28c7981aa5d3feb7e70 on YawPitchControl#35 into 98f6af56ec9b1b898cc20de7c7e5e7984687ad51 on master.

Coverage decreased (-0.2%) to 45.253% when pulling 11f067fa588022a7040a7f681a628b820a51ff5e on YawPitchControl#35 into 1c085a68db9891e67e86998e319adf0a6b059902 on master.


Progress block at 99% for 2min

Hi everybody
Any ideas ??

From when this happened to me once the width in the css was essentially 99.9999999999992342453 and counting upwards. Seems that there can be a case when it will continue like this until I assume it all rounds up and finally finishes.

It probably has to do with this line https://github.com/HubSpot/pace/blob/master/pace.coffee#L457

http://en.wikipedia.org/wiki/Zeno's_paradoxes#Achilles_and_the_tortoise

but how we can fix that ?

Hi guys,
Does anyone have any updates about that problem ?

Is there a solution for this problem?
Davide


inconsistencies in automatic axis limits

Reported by andrew wittenberg on 24 Jul 2013 21:41 UTC
There are some inconsistencies in how automatic horizontal and vertical axis limits are set:
 	NOAA/PMEL TMAP
 	FERRET v6.85 (PyFerret 1.0.0beta)
 	Linux 2.6.32-358.6.2.el6.x86_64 - 07/19/13
 	24-Jul-13 16:45

yes? can v; set v ul; plot/vs/line {0,1},{0,1}
yes? set v ur; plot/vs/line {0,1.001},{0,1.001}
yes? set v ll; plot/vs/line {0,1.03},{0,1.03}
yes? set v lr; plot/vs/line {0,.98},{0,.98}

I'm attaching the resulting figure (ferret_v685.gif).  At top left, the vertical axis goes to 1.1 instead of 1.0 -- unlike the horizontal axis, which goes to 1.0.  In the bottom panels, the horizontal axis grows/shrinks just enough to encompass the top-right point, while the vertical axis is quantized at a full tic mark.
Running the same commands in the single-precision version produces similar results qualitatively (see ferret_v6725.gif), but the quantization of the vertical axis occurs at a slightly different value.
To make the scaling consistent between the two axes, the behavior of the horizontal axis seems like the better way to go -- it fills more of the plot with data, it gives a clearer picture of the data range, and it's graphically more robust to precision issues.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2085

Comment by ansley.b.manke on 25 Jul 2013 22:51 UTC
There have been a few variations in this behavior as shown in the first two attached images. However the basic behavior where the independent axis fits the data and the dependent axis (tries to) have some buffer at the top and bottom, goes back a long time.
Let's look at a couple more plots, one with current and older versions of Ferret, the other drawn with a change to set the dependent axis ends to match the data range.

Comment by ansley.b.manke on 25 Jul 2013 23:23 UTC
Along these lines, I always find it irritating that PLOT/VS scatter plots make symbols right on the axis lines. One has to go back and set /hlimits and /vlimits in order to see some of the symbols. Should the behavior be to make sure the symbols are NOT right on the axes?
In the first plot, if I don't make them large and red, many of the points are hard to see:
yes? plot/vs/color=red/thick/siz=0.2 {1,4,5,4,1}, {0,2,3,3,1}
yes? plot/vs/color=red/thick/siz=0.2/hlim=0.5:6.5/vlim=-0.5:3.5 {1,4,5,4,1}, {0,2,3,3,1}

Comment by andrew.wittenberg on 26 Jul 2013 00:08 UTC
Thanks for those additional examples, Ansley.  You've changed my mind -- it's better '''not''' to have the auto-limits shrink-wrap the data, since shrink-wrapping (1) hides parts of symbols along edges, (2) looks poor without at least some whitespace around the data, (3) might make an audience wonder whether some data actually extends beyond the plot bounds, and (4) makes the axes look uglier and unbalanced, without the tic marks and labels at the extreme ends of the axes.
So then, what would you think about making the horizontal axis auto-limits behave exactly like the quantized vertical axes?  Maybe with a tweak to ensure that each axis-limit expands to the next major tic that is strictly wider than (high end >, not >=; low end <, not <=) the data.

Attachment from andrew.wittenberg on 24 Jul 2013 21:43 UTC
ferret_v6725.gif
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2085_GIT_1357/ferret_v6725.gif

Attachment from andrew.wittenberg on 24 Jul 2013 21:43 UTC
ferret_v685.gif
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2085_GIT_1357/ferret_v685.gif

Attachment from ansley.b.manke on 25 Jul 2013 22:49 UTC
line plot with current and older Ferret behavior
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2085_GIT_1357/lineplot_padded.gif

Attachment from ansley.b.manke on 25 Jul 2013 22:50 UTC
line plot with dep. axis set using exact data limits
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2085_GIT_1357/lineplot_nopad.gif


Do not use externall k8s to run the tests

What does this PR do?
{SUBJ}
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/SVPI-226
How to test this PR?

make test
make itest

/retest


runtime: duplicate key in map literal not detected

What version of Go are you using (go version)?

$ go version
go version go1.20.3 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
Reproducible using https://go.dev/play/p/IV_Nb547iZY
What did you do?
Execute the following code :
package main

import "fmt"

func main() {
	type s struct{}
	m := map[s]int{
		{}: 1,
		{}: 2,
	}
	fmt.Println(m)
}

What did you expect to see?
An error duplicate key struct{} in map literal
What did you see instead?
The program executes without issue and prints the following:
map[{}:2]

I don't think this is a bug. Confusing, I agree, but it follows the spec for composite literals.

It is an error to specify multiple elements with the same field name or constant key value. For non-constant map keys, see the section on evaluation order.

The crux of the question is whether the key you are using is a constant. https://go.dev/ref/spec#Constants lists the constants, and structs (empty or otherwise) are not constants. Even if they are obviously constant to you and me, they are not "Go constants" according to the spec.
For non-constants, we run each entry in the literal as an insert, in program order. There's no error possible in that scenario, we just get subsequent keys overwriting previous ones. That's why you get {}:2 at the end.

I guess this could be a possible vet check?
@adonovan @timothy-king

vet could warn about "ast"-identical, side effect free, non-pointer* struct keys in map composite literals. Seems feasible to do it.
It is not clear how often people would write map[struct{}]int though. This is an unclear way to write an optional int compared to struct{int; bool} or *int. For more complex examples does this happen in practice? So I am worried about meeting the frequency requirement for vet (README). Is there another example that happened in practice? Maybe this is just theoretically surprising?
[*] with maybe an exception for *struct{}.


Plunker or js fiddle?

Can smbd provide working plunkr or jsfiddle example?
Thank you

yep, would be good. Cannot get ot working too.

It's quite simple, the only problem I have is with aligning text, it gives me an error due to not finding widths on it.
This is my code that I'm working to print ID Cards, on this example I'm using a special font saved on my font folder.
If the error you get is with length then just try changing the encoding of the font.
``

Here is an easy way.
Just download this repository and run test.html.


Added some methods from std::option::Option

Added the and and and_then methods. I use these a lot. I also bumped the version since I added functionality. Please check Cargo.toml to make sure I did that right, I'm not the best at semver.
If/when this gets accepted, would it be possible to get the new version pushed to crates.io?
Thanks!

Ok, I rebased after the other pull requests were merged. Not sure I did it correctly. Let me know, I can start a new PR from scratch if needed. I'm still a novice with Git. Thanks.

Thank you for the PR! Should we inline the methods?

Good catch. Done.

Thanks again!

Glad to contribute! (These PR's are my first for rust.) I prefer to pull
crates from crates.io and not github though, could you possibly update on
crates too? I see the added or methods aren't in the version on crates.io
either.
Thanks,
On Wed, May 23, 2018 at 3:56 PM, llogiq<EMAIL_ADDRESS>wrote:

Thanks again!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/llogiq/optional/pull/29#issuecomment-391509380, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJSF1pNnZXVi_epRVOCbBpRb2fPOtPHFks5t1dsdgaJpZM4UHujs
.

Sure, I'll do that later today (I'd do it now, but unfortunately didn't get a seat on my commute today, so I cannot use my notebook right now).


Llava Initial approach to clear images

This changes the Interactive executor to be able to continue the conversation including new images. The example (outside the executor) clears the KV_CACHE to reset the previous images.

This is ready to review.

I modified the example to show how to manage the conversation changing the images when we want to talk about different images.
I update the documentation with the examples and the ILLamaExecutor interface change.

As an example:

SignalRT, two short remarks.

 The context size will limit this because with adding new images the length of the answer will decrease (it is the difference between the context size and the prompt size). I am not sure if this is a feasible approach while using GPU and it will probably make everything slower with the CPU. I also think that this makes the example complicated.
Are you sure that llama.cpp handles several images per prompt well?
I have noticed that llava uses 20% more GPU memory, than before. I am not sure if this has to do with the C# code or the C++ code. I was running some tests with the code of IntPtrMax  and that seems to use 20% less GPU memory. Can you think of any reason for the higher GPU memory usage?

This feels a bit like a hack to workaround not having properly KV cache management in the executors tbh. But without a redesign of the way executors work with sequence IDs etc (which is what I'm working on, slowly, with BatchedExecutor) this is probably the best option for now.

But without a redesign of the way executors work with sequence IDs etc (which is what I'm working on, slowly, with BatchedExecutor) this is probably the best option for now.

@martindevans Recently I'm also working on such things (experimental), inspired by vllm. There are a lot of works to do so I think I'll add it to preview branch or add a namespace experimental for it at first. Since you are also working on it, I'll push a draft ASAP so that we could discuss how to make it together. :)  Besides I'd be more than happy to see your idea. Please feel free to ping me if there is anything I could help with.

@zsogitbe

SignalRT, 3 short remarks.

 The context size will limit this because with adding new images the length of the answer will decrease (it is the difference between the context size and the prompt size). I am not sure if this is a feasible approach while using GPU and it will probably make everything slower with the CPU. I also think that this makes the example complicated.
Are you sure that llama.cpp handles several images per prompt well?
I have noticed that llava uses 20% more GPU memory, than before. I am not sure if this has to do with the C# code or the C++ code. I was running some tests with the code of IntPtrMax  and that seems to use 20% less GPU memory. Can you think of any reason for the higher GPU memory usage?
I think that using ModelContext.GetState() and ModelContext.LoadState(state) is a better solution (both in llama and llava). I am not sure about the KV_CACHE and from the remark of ggerganov I think that he was also not sure about it.

The goal is to support the capabilities of the model: https://github.com/haotian-liu/LLaVA/pull/432 . You can use one image if you want. I don´t see the problem to maintain the interface to be able to pass more than one image. Other Multi Dimensional models support also several images.
I cannot see with my configuration different GPU memory usage between this PR and the previous version. I cannot compare with other architectures. Do you test this with exactly the same llama/llava dll versions in all scenarios?.
I give a try to your proposal without success. The model begans to mix images in the answer. This is the answer that provides with the third image of my previous demo mixing two different scenes:  This is a color photograph depicting a young woman standing on a wooden bridge overlooking a canal with a cup of coffee. The woman appears to be looking off into the distance, away from her red shirt. In the background, there are trees and a building in the background.

@martindevans, @AsakusaRinne
I'm also giving a try to a new batch executor (currently outside LlamaSharp to simplify my test). I'm focusing on server concurrent usage. I'm getting some metrics on the performance of this method, I will share with you when I have the comparison done.
I will integrate this PR "as is". We will probably need to change llava support in the near future (https://github.com/ggerganov/llama.cpp/issues/4216#issuecomment-1991730224).

Thank you for your answer SignalRT,
In general the llava code is very well done! Thank you for your effort.
After reading the reference you have provided above and taking into account that the models are trained with one image only per input record, I think that it does not have any sense to use multiple images as input for one prompt. I also do not see immediately a good use case for such a functionality. I think that the model will be confused and in the best case it will describe multiple images as it would be one image, for example as a collage or it will just describe one image.
I also think that the example would be easier to understand if there would only be one image as input. It is a bit confusing now what is happening in the example (I had to think very hard to understand your example and this should not be the aim - the example should be easy to understand and simple).
But, it is up to you to decide.
I have noticed the higher GPU usage because I have an example which does not run anymore on the GPU (out of memory), but was fitting into GPU memory before. I do not know what has happened and where, I just see the result of it. Maybe it has to do with GPU memory allocation type (automatic thread pool with overhead). I think that the GPU memory allocation type has changed in the C# code or in the C++ code. I hope that we will have some kind of option to optimize GPU memory usage because it is very important for the speed (everything is much faster with GPU).
I have tried saving/loading the state also and it did not work. After loading the context state the model produces garbage in my case. Probably a bug in state management somewhere. The kv  cache clearing work.
@martindevans, @AsakusaRinne, @SignalRT, does state saving/loading work with the general llama code base? This is important because I was counting on this to work (using it to reset the context without recreating it). Or do we need to use kv cache clearing there also?

I'm not aware of any issues with state load/save at the moment. It's something I'm going to be actively working on soon (load/save conversations in the BatchedExecutor), so if there are any issues they'll be fixed soon :)


where has organise imports gone?

Does this issue occur when all extensions are disabled?: Yes/No
YES

VS Code Version:
1.80.0
OS Version:
windows 10
Steps to Reproduce:

ctrl-shift-p used to show "organise imports" as an option. Now it is missing. how do I access this?

What language is this for?

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

python

It looks like this is caused by the Python extension. Please file the issue to the Python extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Update golang.org/x/image to v0.18.0

Result of go get -u  golang.org/x/image && make tidy
Fixes: https://github.com/go-gitea/gitea/security/dependabot/67

I was unable to create a backport for 1.22. @silverwind, please send one manually. :tea:
go run ./contrib/backport 31541
...  // fix git conflicts if any
go run ./contrib/backport --continue


Fix potential github action smells

Motivation and Context

Description
Hey! 🙂
I want to contribute the following changes to your workflow:

Use commit hash instead of tags for action versions
Use fixed version for runs-on argument
Avoid jobs without timeouts
Prevent running issue/PR actions on forks
Steps should only perform a single command
Use names for run steps

These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more

Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

@microsoft-github-policy-service agree

@RogerBarreto Here is a scientific paper and a blog post about potential security risks related to GitHub Actions

Going to close this out because the team has decided that we'll remove both of these actions.


AndroidManifest Permissions Cleanup

Hey guys,
I noticed in the migration guide from 1.4.x to 2.0.x you mention that

All SDK permissions other than location adn networking have been commented out in the manifest. Please check the manifest if you previously had certain permissions set, e.g. for camera access or vibration

Here's what could be improved:

The VIBRATE permission is currently not commented out or removed from the manifest, but it should be according to the quote from the migration guide above.
You don't need the ACCESS_COARSE_LOCATION permission if you already declare the ACCESS_FINE_LOCATION permission. The second one implicitly grants the first one as well.
You don't need the ACCESS_WIFI_STATE permission. I did a full  text search on the project and it doesn't use the WifiManager anywhere - this is what the permission would be necessary for. I only see that the code in SdkUtil is using the ConnectivityManager, which requires the ACCESS_NETWORK_STATE permission, and is enough even to check whether the device has WiFi connectivity. It's explained in detail here. ACCESS_WIFI_STATE is only necessary if you need to access detailed information about individual WiFi connections - which it seems like you don't.

Cheers!

Thanks - we have created a JIRA ticket our of your comments and will cleanup the manifest in a coming commit.
Issue will be kept open until change is commited.

Great stuff guys :)

In branch 2.0.1 the manifest has been cleaned up

Awesome, thanks!


Implemented workaround for bad serialization id in CronSchedule

Added field encapsulation to account for possible NPEs due to legacy object deserialization.
Added functionality to rewrite Quartz blobs to fix problematic serialization ids introduced in recent release.
Added support for Quartz in solo-server, critical in testing the serialization id hack-fix.

Following up on https://github.com/azkaban/azkaban/pull/2457

@acharneski  Thank you so much for working on this PR very quickly to unblock all of us. I really appreciate your quick response and fix.

Thanks @li-ygerchikov and @jakhani for the review. I've responded to all your comments and made some changes to address them. Please re-review.

Pull Request Test Coverage Report for Build 5116

8 of 273 (2.93%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.3%) to 40.206%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-web-server/src/main/java/azkaban/flowtrigger/quartz/FlowTriggerScheduler.java
0
3
0.0%

azkaban-solo-server/src/main/java/azkaban/soloserver/AzkabanSingleServer.java
0
24
0.0%

azkaban-web-server/src/main/java/azkaban/scheduler/QuartzScheduler.java
4
31
12.9%

azkaban-web-server/src/main/java/azkaban/scheduler/QuartzHacker.java
0
71
0.0%

azkaban-web-server/src/main/java/azkaban/scheduler/CustomQuartzDeserializer.java
0
140
0.0%

Files with Coverage Reduction
New Missed Lines
%

azkaban-exec-server/src/main/java/azkaban/execapp/jmx/JmxJobMBeanManager.java
1
72.73%

azkaban-exec-server/src/main/java/azkaban/execapp/JobRunner.java
1
77.69%

Totals

Change from base Build 5114:
-0.3%

Covered Lines:
12970

Relevant Lines:
32259

💛  - Coveralls

@li-ygerchikov Addressed comments

@li-ygerchikov @jakhani Just a follow up, I believe all changes requested have been made. Please re-review. Thanks!

The code appears to be good after all the iterations.
Please follow the coding guidelines and use wrap around, final etc.
I think if you configure intelliJ as per the readme, it should do it for you.

Thanks, I have made the formatting changes and cleanups. Please check again @djaiswal83

@acharneski can you please rebase your code? We had a test which started failing after daylight saving. It would be nice to have clean travis CI build.

@acharneski I have added one small comment. Everything else looks good to me. Thank you so much for working on this PR.

Rebased as @djaiswal83 requested
Thank you!


How to maintain data for each row in aggrid when I made Multiselect dropdown in aggrid

I made this multiselect dropdown for a column in aggrid. but the issue is that when i select any value form one of them dropdown, then rest dropdown has been filled same as the first one in the particular column.Please give me appropriate solution. Thanx in advance.

Make sure you use different input model object. Do a deep copy, don't copy by reference.
If it doesn't help, I need you to copy your code & replicate the problem in Plunker / JsFiddler.

Hi,
Below is the code which i have used.
i have taken json data in arr11.
{
headerName: "Resource", field: "RESOURCES", width: 350,
cellRenderer: function (params) {
if (params.data.FLAG == 'L') {
return '';
}
}
}

issue code.txt

I need more than that; eg. the controller & view

Please find the attached code:
issue code.txt

@atulmayank23 ,
I'm unable to help with chunks of code like that. As I said, please replicate your issue in JsFiddler or Plunker.

@atulmayank23  How you have created multi select dropdown in ag-grid?


About SMPL_CS

thx your awsome work! when i try to inference my own video, i found that using smplerx rendering mesh leads a bad result, So i want to ask  when do you open the smpl_cs code？ or could you explain that "SMPL-CS integrates 3D, depth, and continuous semantic information" more detailed, so that i can try to make it by myself. thx a lot

Already released.