Error on creating instance

A clear and concise description of what the bug is.
Environment

vk version: Current (quicklisp)
CL implementation (name & version): SBCL 2.1.1
OS: Ubuntu (21.04)

If it's not purely CL-related, please add:

Vulkan lib version: ...
Graphics driver: ...

How to reproduce the issue
Using the test code from VK or 01 from VK samples
Expected behavior
Creating and instance
Actual behavior
Can not find the correct dynamic function for cffi:translate-into-foreign-memory
Additional context
Looks like its not using the correct type class, %vk are all c-<struct name> and the translation functions appear to be <struct-name>

Seems if i rename the :class on the defcstruct to remove the c- it works. Did this naming scheme get changed recently?

Oh man, that's strange. The c--prefixes have been there from the start and the translator methods also specialize on the c--prefixed class names.
I tried to reproduce this issue earlier today with a fresh install of SBCL and Quicklisp on Ubuntu 20.04 and Windows 10 by running all samples (also fresh pulls of all necessary external repositories and no other systems than vk and vk-samples explicity ql:quickloaded) and the test case and everything worked fine.
It's pretty late for me (CET), but I'll try again with your setup tomorrow.
I guess your Quicklisp is up to date?

Yeah up to date. Let me try the again, but it's a odd that i've got it to work by renaming

@JolifantoBambla so sorry for wasting your time, this was totally my fault. I had started crafting some of my own adhoc bindings in by project and I think it had silently shadowed your symbols, doh.
Again my apologies for taking your time, and thanks so much for looking and providing these bindings.

@Guthur No worries, glad it works now. I hope it fits your needs :)


Issue with SR300 when using realsense

Required Info

Camera Model
SR300

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 16.04

Kernel Version (Linux Only)
4.4.0-57-generic

Build System
Makefile

I have the SR300 and tried the samples in windows 10 with it. They were all working. But when I install it in Ubuntu, only the color output is showing but no visible output in the infrared output. A screen-shot is attached for reference.

I ran the test program and got one error. But I don't know what the error means:
librealsense-master/bin/debug# ./unit-tests-live-sr300

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
unit-tests-live-sr300 is a Catch v1.2.1 host application.
Run with -? for options

-------------------------------------------------------------------------------
SR300 streams 640x480 depth and infrared
-------------------------------------------------------------------------------
../unit-tests/unit-tests-live-sr300.cpp:262
...............................................................................

../unit-tests/unit-tests-live-sr300.cpp:262: FAILED:
  {Unknown expression after the reported line}
due to a fatal error condition:
  SIGSEGV - Segmentation violation signal

===============================================================================
test cases:    17 |    16 passed | 1 failed
assertions: 36707 | 36706 passed | 1 failed

Please tell me how can I fix it. Thank you

Hi, the symptoms you observe on Ubuntu are due to a missing kernel patch, as was documented in many cases, like this one.
Running LibRealSense on Ubuntu requires patching UVC driver to support the camera's Depth data formats.
Please follow the Installation manual, especially the Linux Installation chapter to correct it.
The specific patch file for your distribution is called "patch-uvcvideo-16.04.simple.sh".
Tip: Make sure you boot-up with 4.4.0-57 kernel selected before running the scripts.

Hi, the symptoms you observe on Ubuntu are due to a missing kernel patch, as was documented in many cases, like this one.
Running LibRealSense on Ubuntu requires patching UVC driver to support the camera's Depth data formats.
Please follow the Installation manual, especially the Linux Installation chapter to correct it.
The specific patch file for your distribution is called "patch-uvcvideo-16.04.simple.sh".
Tip: Make sure you boot-up with 4.4.0-57 kernel selected before running the scripts.


LK contour() function causes SAM to crash

The following test script runs in SAM 2018.11.11 r4 but not in SAM 2020.2.29:
contour_test.zip

Trace to setting axis reversed in contour plot before axes were created from lkscript call. Fixed in lkscript.cpp in SAM_306 branch of wex and merged into develop and patch branches of wex.

verify reversed y axis in marine energy wave results

Tested SAM 2020.2.29 r2rc on Ubuntu 18.04.3 LTS


The option --proxy-config is not registered with the serve command.

Please provide us with the following information:

OS?

Windows 10

Versions.

angular-cli: 1.0.0-beta.11-webpack.2
node: 6.9.1
os: win32 x64

Repro steps.

I added "start": "ng serve --proxy-config proxy.conf.json" to the package.json. I created the proxy.conf.json file in the same directory as the package.json with the following code in it:
{
"/api": {
"target": "http://localhost:1111",
"secure": false
}
}

I then ran npm start from my app directory.
The log given by the failure.

npm start
ng serve --proxy-config proxy.conf.json

The option '--proxy-config' is not registered with the serve command. Run ng serve --help for a list of supported options.
Mention any other details that might be useful.
ng serve --help only has --proxy listed in it.

Thanks! We'll be in touch soon.

@Cassidie you are using an outdated version of the cli. Update to the latest version and see if the issues persist.

@Cassidie Just to elaborate more on what @deebloo said,
You'll want to update your package.json to use the latest version of the angular cli (currently "angular-cli": "1.0.0-beta.19-3")
You will also want to reinstall the angular cli globally

npm remove -g angular cli to remove it
npm cache clean to clear any cached information related to the cli
npm install -g angular-cli to reinstall it globally.

Then you'll want to make sure to delete your node_modules directory in your project because there are a few dependencies in there that can get left behind if you just delete the angular-cli module.
Then you'll need to do npm install in your project root to make sure that you have the latest version of the angular-cli installed (as well as all your other dependencies)
There may be some other files that need to be update in the process because angular-cli beta 11 was before the time of NgModules so you'll likely need to upgrade your entire project if you want to have the most effective development environment, this is outside the scope of the CLI however.

Thank you for the responses! I have updated the cli and my project, but I now have an ng build error:
Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
    at Object.getWebpackCommonConfig (C:\Builds\Github\vintage-software\sprint-app\App\node_modules\angular-cli\models\webpack-build-common.js:23:26)
    at new NgCliWebpackConfig (C:\Builds\Github\vintage-software\sprint-app\App\node_modules\angular-cli\models\webpack-config.js:15:29)
    at Class.run (C:\Builds\Github\vintage-software\sprint-app\App\node_modules\angular-cli\tasks\build-webpack.js:17:22)
    at Class.run (C:\Builds\Github\vintage-software\sprint-app\App\node_modules\angular-cli\commands\build.js:50:26)
    at Class.<anonymous> (C:\Builds\Github\vintage-software\sprint-app\App\node_modules\angular-cli\lib\models\command.js:152:17)
    at tryCatch (C:\Builds\Github\vintage-software\sprint-app\App\node_modules\rsvp\dist\lib\rsvp\-internal.js:215:12)
    at invokeCallback (C:\Builds\Github\vintage-software\sprint-app\App\node_modules\rsvp\dist\lib\rsvp\-internal.js:230:13)
    at C:\Builds\Github\vintage-software\sprint-app\App\node_modules\rsvp\dist\lib\rsvp\then.js:29:16
    at flush (C:\Builds\Github\vintage-software\sprint-app\App\node_modules\rsvp\dist\lib\rsvp\asap.js:85:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

I appreciate your help!

It looks like it can't read the "webpack common config" you're likely missing some files, here's a screenshot of what my root looks like.

You may have to generate a new project with the updated cli, and move your src over to it, and then update the package.json to include any packages you installed on your previous project.

My directories match yours. I think you might be right about generating a new project and migrating mine to it. I read in the angular-cli update docs that it recommends to update with a migration, but I thought I could be slick and do it without that. Live and learn! haha I will try that! Thank you again!

I was able to get the proxy working by regenerating my project!

I had the same error.  I think the correct syntax is:
ng serve --proxy-config=proxy.conf.json


Add git workflows

Add template for contribution and branch creation.

I also added the new semantic release pipeline.


Login Problem

Dear, I'm trying to use your code. I have a problem with login. After the click on the button facebook shows me the save button to save the access and on this show there is a problem that do not permit to access on the social network.

Hi Marco, thank you for creating this issue. Could you share a screenshot of the browser instance and the log output from the script?

Hi Marco, I'm closing this issue as I haven't heard back from you. Please re-open this when you have more information to share in regards to the problem you experienced.


Unhide the /cloudflare/rules section

If I hadn't tripped over it in the docs, I'd never have found it. Can you make it a tab on the Plugin config section?

That feature’s about as bold as the version number on this project. I’ve been meaning to revamp the settings and give the rules table a proper home in a 1.0 release—will leave this open until that’s done.

That's totally fair! We/re moving off Ak*mai to Cloudflare, so I'm eager to make things easy for my team

This section is really helpful, so +1 for exposing it.
I wonder if we could get a pattern that triggers a pattern.  I have an AMP version of all my articles.  Would be pretty awesome if /articles/{slug} could also trigger their matching /amp/articles{slug}.

Finally released v1.0.0 with this update.


Fix legacy query failure replying

What was changed
Make sure we still reply to legacy queries in specific failure scenarios
Why?
Could cause timeouts where they were not necessary
Checklist

Closes

How was this tested:
Existing tests

Any docs updates needed?

Is this fixing a regression in core or has it always been broken?

Is this fixing a regression in core or has it always been broken?

No, this is making a refinement to a recent change introduced here: https://github.com/temporalio/sdk-core/pull/792
Now rather than always dumping out of replying to queries if history application failed in an earlier activation, now we'll still reply if the only thing the task was doing was issuing a legacy query.


WebUI doesnt detect devices that the Desktop app detects

I tried to pair 2 Xiaomi mija door sensors using the webapp.  I tried to add them using Sensors->Add Sensor-> Other.   The webui was never able to detect these sensors though.  However in the Desktop UI, both devices appeared, however I am unable to set their 'Name', 'Model' or change any settings for them.
Furthermore they do not show up in the WebUI under sensors.

This appears to be a problem with deConz, not with the docker image. Please open an image on the deCONZ repo.


Shap throws back a tensor shape error for concatenate keras model

Help, I keep receiving and error about my input tensor shape and output tensor shape when trying to use the DeepExplainer.
I built my network around the pseudo code from this article:
https://towardsdatascience.com/decoded-entity-embeddings-of-categorical-variables-in-neural-networks-1d2468311635
My X is a list of numpy arrays (1 array for each categorical type) and the layers are concat using the Keras functional API where the final output layer is sigmoid (classification problem)
Submitting from my phone but will add a snapshot of error once I get on my laptop.

Hey, did you ever figure out your issue? I think we might have the same issue. I.e., SHAP doesn't support data input whereby it is a collection of arrays. I'm thinking about simply using LIME and then having a custom wrapper prediction

Hey, did you ever figure out your issue? I think we might have the same issue. I.e., SHAP doesn't support data input whereby it is a collection of arrays. I'm thinking about simply using LIME and then having a custom wrapper prediction

Yeah we def have the same issue.

DeepExplainer should support multiple input models now. If you have a case where it fails let us know!


tks: init at 1.0.32

Motivation for this change
Add TKS, a command line tool and more for managing time sheets for work.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) N/A
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" N/A
[x] Tested execution of all binary files (usually in ./result/bin/). tks-weekly-prep does not run due to a missing Scriptalicious.pm, but that can be fixed at a later time.
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

closing because it got stalled. Please open a new PR if there is still interest.


moved HasNextResultSet from unary result interface to common result i…

…nterface
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report

Merging #63 (e3234d4) into master (3bf2541) will decrease coverage by 15.42%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #63       +/-   ##
===========================================
- Coverage   49.40%   33.98%   -15.43%
===========================================
  Files          75       45       -30
  Lines        9136     6739     -2397
===========================================
- Hits         4514     2290     -2224
+ Misses       4341     4313       -28
+ Partials      281      136      -145

Flag
Coverage Δ

1.16.x
33.98% <ø> (ø)

1.17.x
33.98% <ø> (-15.43%)
:arrow_down:

integration
?

ubuntu-latest
33.98% <ø> (-15.43%)
:arrow_down:

unit
33.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf2541...e3234d4. Read the comment docs.


Create a Toggle command for the side-panel.

I would like to create a simple hotkey, something to the effect of <leader>av -> :AvanteToggle
If the :AvanteAsk panel is currently closed, it would be opened. and vice versa.

Nevermind... I'm seeing that the builtin <leader>aa already does this.


Why the property  'parseText' is invalid.

I use this plugin,and i set the property  'parseText' to true.
but after i send message with url,can't get link.

fixed in 0.1.0


Replace winapi dependency with windows

Since normpath was added, opener has depended on both winapi (directly) and windows-sys (transitively).
This commit replaces usage of winapi with the windows crate so that it only depends on a single windows API crate. Additionally, the windows crate includes some functions that were manually linked in opener, so those manual links were able to be cleaned up.

I'm not very experienced with unsafe Rust 😅. Any feedback is appreciated!

Friendly bump 🙂  Anything needed from me?

I just pushed a commit fixing some style nits. However, I've just realized we're using the windows crate here, while normpath depends on the windows-sys crate, which is actually a totally separate crate (windows does not depend on windows-sys). So we would still be depending on two separate Windows API crates. Two possible solutions:

Switch from normpath to dunce, which has no dependencies
Don't use windows, and instead use windows-sys like normpath

The first option is simpler, but I believe there's some edge cases where normpath is more compatible with certain paths, so maybe we'd need to go with the second option.

I've switched over to windows-sys in https://github.com/Seeker14491/opener/pull/29, so now we only have one Windows API crate in our dependency tree.


Update scalafmt-core to 3.3.3

Updates org.scalameta:scalafmt-core from 3.3.2 to 3.3.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #78 (d88843f) into master (94e3295) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   31.78%   31.78%
=======================================
  Files          17       17
  Lines         258      258
  Branches        6        6
=======================================
  Hits           82       82
  Misses        176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e3295...d88843f. Read the comment docs.


No permissions to write to /opt/ when using install option

when running ./factorio install errors and returns Aborting install, unable to write to '/opt/factorio'!. Running as sudo does not help.

Appreciate the insight @buson94 :)
Please, if you want to I'd be happy if you could elaborate on the things you mentioned in a separate/multiple separate tickets.
For example "When installing, the script should make sure to do X".
<3

@montematico did @buson94 's suggestions help you get the server installed or did you solve it in any other way?
(who owns the /opt/factorio directory, to help me debug this further - please provide the output of ls -alsh /opt/factorio and whoami)


I can't download a course.

Udeler | Udemy Course Downloader
1.13.0
Account Type?
Personal
Steps to reproduce

EBUILDING_COURSE_DATA: undefined(0)
Cannot read property 'asset_type' of undefined
✔ Expected Behavior
I want to be able to download this like my other courses :)
🔍 Additional context
Operating System: windows 10

Hi, which course?

https://www.udemy.com/course/sfrdan-ileri-seviye-angular-egitimi

Hi, which course?

https://www.udemy.com/course/sfrdan-ileri-seviye-angular-egitimi

Hi, which course?

This is actually an error in Udemy API.
Please try to log in with a new token, please let me know the result.

see a new version


Proposal: Auto add PROVIDERS, DIRECTIVES, PIPES when adding 3rd party libs, etc.

Discussion on AngularAir today regarding 3rd party libraries (https://plus.google.com/events/c7m79d5o04nom5eednk5ecqtebk) brought up an interesting thought.
See also: https://github.com/angular/angular/issues/5503
If 3rd party libs all adhered to a certain naming convention and style when exporting necessary services, directives, pipes, etc., it would be incredibly helpful if this CLI could auto-annotate the src code files with the necessary directives, providers, pipes, etc.
Consider the following scenario:

User wants to use ng2-image-lazy-load (https://github.com/NathanWalker/ng2-image-lazy-load)

Since it followed certain conventions, IMAGELAZYLOAD_PROVIDERS , the CLI might provide an additional helpful aid (command can be whatever, just using add-lib for example):

ng add-lib ng2-image-lazy-load

It would proceed to run npm install ng2-image-lazy-load, then prompt with a couple questions:
$ Would you like this provider as part of the bootstrap? (y/n)

If "y":
$ Please provide the path to the src file which bootstraps your app:
$ src/bootstrap.ts

It would add the import statements and append the aptly named [lib_prefix]_PROVIDERS in the user's app bootstrap.
If the lib contained no constants with PROVIDERS in the name, it would modify nothing.
If "n":
$ Please provide the path of the component you would like the providers added to:
$ src/components/main.component.ts

It would add the import statements and append the libraries aptly named PROVIDERS in the viewProviders of the component.
Similar scenarios would apply for DIRECTIVES, PIPES, etc.
If this were possible, every 3rd party lib could suggest using the CLI as the first option to install, followed by manual npm install.
/cc @jvandemo, @gdi2290, @valorkin, @ocombe, @jeffwhelpley,  @pascalprecht, @mgechev, @ludohenin, @robwormald

the proposal sounds reasonable to me (with some tweaks). I think that we should prefer local import over global import, so I'd reorder the options.
Would you like to create a test package(s) in npm that we can experiment with?

Tweak away.
local over global certainly sounds better and any options or workflows that make sense to you here as well.
For now, you can experiment with https://github.com/NathanWalker/ng2-image-lazy-load
npm install ng2-image-lazy-load
It follows the conventions mentioned. This file (https://github.com/NathanWalker/ng2-image-lazy-load/blob/master/ng2-image-lazy-load.ts) exports PROVIDERS and DIRECTIVES.
I'll update that to the latest alpha release over the weekend.
If you need anything specific, let me know.

adjective: adlib; adverb: adlib
musical context:

Jazz musicians may adlib during a performance, meaning they are free to vary tempo and instrumentation.

programmers context:

When using any framework to create an application, there will come a time when a developer must adlib to complete the applications specifications.

Might be a fun command: adlib

i think perhaps a simple solution for this would be something along the lines of
//myPluginRoot.ts
import {MyPluginServiceA, MyPluginServiceB} from './services';
import {MyDirectiveA, MyDirectiveB} from './directives';
import {MyPipeA, MyPipeB} from './pipes';

//export the named stuff for granular usage
export * from './services'
export * from './directives'
export * from './pipes'

//use es6 default syntax to export the "plugin"
export default {
  providers: [MyPluginServiceA, MyPluginServiceB],
  directives: [MyDirectiveA, MyDirectiveB],
  pipes: [MyPipeA, MyPipeB]
}

users and tooling are then easily able to do :
//naming is irrelevant here
import myPlugin from 'myPlugin'

//now its consistent:
myPlugin.directives
myPlugin.services
myPlugin.pipes

and this is easily done with templating, as the actual name of the export is "default" - no weird lookups necessary and no NAMING_CONVENTIONS to force / invent.
see http://plnkr.co/edit/Yi1e3ifiX0gSqd8Qs2h4?p=preview - i added a little plugin registration helper too, which @IgorMinar will probably yell at me about.

That's the best solution I've heard yet Rob. Very clean and simple.
I could pull your plunk (the gist of it anyway) into a repo tomorrow or
Friday and publish it so it could be experimented with in this setup.
On Thu, Dec 10, 2015 at 12:03 AM Rob Wormald<EMAIL_ADDRESS>wrote:

i think perhaps a simple solution for this would be something along the
lines of
//myPluginRoot.tsimport {MyPluginServiceA, MyPluginServiceB} from './services';import {MyDirectiveA, MyDirectiveB} from './directives';import {MyPipeA, MyPipeB} from './pipes';
//export the named stuff for granular usageexport * from './services'export * from './directives'export * from './pipes'
//use es6 default syntax to export the "plugin"export default {
providers: [MyPluginServiceA, MyPluginServiceB],
directives: [MyDirectiveA, MyDirectiveB],
pipes: [MyPipeA, MyPipeB]
}
users and tooling are then easily able to do :
//naming is irrelevant hereimport myPlugin from 'myPlugin'
//now its consistent:
myPlugin.directives
myPlugin.services
myPlugin.pipes
and this is easily done with templating, as the actual name of the export
is "default" - no weird lookups necessary and no NAMING_CONVENTIONS to
force / invent.
see http://plnkr.co/edit/Yi1e3ifiX0gSqd8Qs2h4?p=preview - i added a
little plugin registration helper too, which @IgorMinar
https://github.com/IgorMinar will probably yell at me about.
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular-cli/issues/96#issuecomment-163528438.

@robwormald I like it very much

+1 on this solution @robwormald :)

@robwormald — Brilliant, love your proposal! :+1:

Go for it! (maybe not the helper thing...)

On Dec 10, 2015, at 12:16 AM, Nathan Walker<EMAIL_ADDRESS>wrote:
That's the best solution I've heard yet Rob. Very clean and simple.
I could pull your plunk (the gist of it anyway) into a repo tomorrow or
Friday and publish it so it could be experimented with in this setup.
On Thu, Dec 10, 2015 at 12:03 AM Rob Wormald<EMAIL_ADDRESS>wrote:

i think perhaps a simple solution for this would be something along the
lines of
//myPluginRoot.tsimport {MyPluginServiceA, MyPluginServiceB} from './services';import {MyDirectiveA, MyDirectiveB} from './directives';import {MyPipeA, MyPipeB} from './pipes';
//export the named stuff for granular usageexport * from './services'export * from './directives'export * from './pipes'
//use es6 default syntax to export the "plugin"export default {
providers: [MyPluginServiceA, MyPluginServiceB],
directives: [MyDirectiveA, MyDirectiveB],
pipes: [MyPipeA, MyPipeB]
}
users and tooling are then easily able to do :
//naming is irrelevant hereimport myPlugin from 'myPlugin'
//now its consistent:
myPlugin.directives
myPlugin.services
myPlugin.pipes
and this is easily done with templating, as the actual name of the export
is "default" - no weird lookups necessary and no NAMING_CONVENTIONS to
force / invent.
see http://plnkr.co/edit/Yi1e3ifiX0gSqd8Qs2h4?p=preview - i added a
little plugin registration helper too, which @IgorMinar
https://github.com/IgorMinar will probably yell at me about.
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular-cli/issues/96#issuecomment-163528438.

—
Reply to this email directly or view it on GitHub https://github.com/angular/angular-cli/issues/96#issuecomment-163530467.

Will not this push to use MVC like folder separation?
Like for angular 1 really was really popular controllers\directives\templates separation
which became really fast unusable in large apps
that all moved to components separation all related to component in one folder
a bit later nested components and common folders appeared as a practice
+1 to @robwormald that we should not push/invent name conventions

this is for third party packages (like yours) which will presumably ship via NPM, and thus the structure of the package is mostly irrelevant to the user. The structure internal to the module / plugin is entirely up to you, that was just a quick and dirty demo.

@valorkin — I think using a folder structure with directives, services and pipes makes sense for libraries (the Angular team also does this internally in the Angular source code) although the library author could decide to use another structure.
The structure for an actual application (not a library) would be component driven though, if that makes sense.

just said my IMHO
Angular team actually uses components structure (but call it modules) and MVC separation inside of it

@valorkin — I think the Angular repository (in its current form) is hard to compare to a third party library.
However, if we peek inside one of the modules, then we can see a similar structure e.g.: https://github.com/angular/angular/tree/master/modules/angular2/src/common
I think such a structure is probably closer to what most (smaller) libraries will contain.
If you have a larger library that contains modules then it definitely makes sense to create a module folder structure. Ultimately the library author should decide.
Although one could argue that it would be better to split into different repositories than in different modules.
Would be great if there is an Angular 2 ecosystem with a lot of very small libraries (as in node).
What are your thoughts on splitting into different repositories? Thanks!

Taking in account user option to to require and bundle only require part of libs
it is awesome opportunity to minimize js size and bootstrap time
(as a consequence of reduced amount of js to be parsed by VM)
modules are optional
splitting in components like this: https://github.com/angular/angular/tree/master/modules/angular2/src
seems to me as proven concept, IMHO

@IgorMinar Here is a test lib to experiment with that uses @robwormald's excellent standards proposal above:
https://github.com/NathanWalker/ng2-cli-test-lib
npm install ng2-cli-test-lib

Expectations of cli

manually npm installing should not be required (cli should handle that)
questions should be prompted similar to suggestions above to allow the user to specify how they would like the lib added and annotated in their src
cli should properly add the correct annotations given the lib's standard default exports

Sample component to test if it worked
@Component({
    selector: 'demo',
    template: `
      <test></test>
      <div>{{title | uppercase}}</div>
    `,
    directives: [.... **hopefully cli will auto add these properly** ...],
    pipes: [.... **hopefully cli will auto add these properly** ...]
})
export class Demo {
    public title:string = "having standards for these libs will help a lot!";

    constructor(private test1:TestService, private test2:TestService2) { }
}

bootstrap(Demo, [.... **hopefully cli will auto add these properly** ...])

Given something like the above, you should be able to see this in the console:

TestService and TestService2 simply log to console that they have been created properly via DI.
TestPipe lets us know it's transforming successfully.
In the browser, this should be seen:

The TestDirective in the lib simply inserts text into the element.
The TestPipe simply transforms title to uppercase.
Conclusions

If all this works out ok, an official styleguide could be written regarding the authoring of 3rd party libs for Angular2. It would also suggest all lib's mention angular-cli as the primary method to add the lib.

btw, @robwormald's registerPlugins (in pluginHelper.ts) utility found here http://plnkr.co/edit/Yi1e3ifiX0gSqd8Qs2h4?p=preview is pretty nifty :+1:

@NathanWalker you just made best ng2 starter package for angular 2? You know it right? :)

@NathanWalker — Great effort! Thanks!
Once we have settled on a best practice I will also update generator-angular2-library accordingly.

fyi, testing lib https://www.npmjs.com/package/ng2-cli-test-lib, updated to use latest alpha.53.
@IgorMinar @robwormald if either of you have any opinion on lib name prefix (repo prefix), please share. Most of the discussion has settled on ng2- for becoming the standard prefix for all angular2 libs to come. But I think there's still time to settle on something else before the landscape starts to fill up dramatically with ng2-.

no real comment on the prefix.
thinking about the installation process - i'd personally rather use npm. i think it would be reasonable to have package authors add a field to their package.json (something like "ng" : { "plugin" : true } ) - the CLI can then scan for those. needs a bit more thought on that, but I don't think we want to build a package manager too :)

I was thinking the same. Using npm manually is likely universally preferred.
My thought initially on that was more for the pure newbie (new to node, new to angular, etc.) and since it might be rather trivial, it might make sense. The teams best discretion there.

you should also add styles
import ng2lib, {MyDirective} from 'ng2lib';
@Component({
  selector: 'app',
  providers: [  ...ng2lib.providers],
  directives: [  ...ng2lib.directives],
  styles: [ ...ng2lib.styles],
  template: `<my-directive></my-directive>`
})
export class App {}

parsing package.json for the correct keyword angular2, ng2 or, ng2module (whatever everyone agrees on) should be prefered when segmenting npm for example npm search for ng2 (tbh they should really add hashtags to npm)

+1, fully integrated :)

What if a library author would configure package.json to run angular-cli as an npm postinstall script?
Possible benefits:

angular-cli would automatically run after npm install
library author can configure angular-cli to run with options specific to the library
angular-cli itself does not have to be aware of anything, it is the library author that calls angular-cli
backwards compatible: no postinstall script => no action is taken
expandable: the library author could perform other actions as well in the postinstall script
flexible: library author can choose preferred language e.g. JavaScript or bash
script can be standalone run using npm run postinstall

Possible issues:

What if angular-cli is not installed? Should angular-cli be a devDependency?
Script should be non-interactive to ensure that it can be run unattended e.g. on Travis?

What happens when the end user doesn't want the lib to auto install inside its application?

@ocombe In that case, user could simply exit, Ctrl + c, since the install would have completed, they could just exit the postinstall angular cli if they didn't want to go through those steps.
@jvandemo great additional thoughts. Using cli manually could still work as suggested/described throughout this discussion and as an option on top of everything, libs could also provide this postinstall step as a convenience. I think having it both ways (via through cli directly or via postinstall when using npm manually to install a lib) doesn't hurt.
Possible issues:

What if angular-cli is not installed? Should angular-cli be a devDependency?
I vote no. It just wouldn't que up angular-cli if it's not installed, or may throw an error after installing. Either way, the lib would describe in its installation steps that installing angular-cli as a prerequisite may help them configure their app to use the lib but it's not required.

Script should be non-interactive to ensure that it can be run unattended e.g. on Travis?
This alone may make having a postinstall step problematic. But if there's an easy way to turn off for Travis, then it would be fine.

Based on @gdi2290 suggestion to handle styles, I've updated the test lib to handle this as well.
This works out like the following:
import {TestDirective} from './src/app/directives/test.directive';
import {TestService, TestService2} from './src/app/services/test.service';
import {TestPipe} from './src/app/pipes/test.pipe';
import {TestStyles} from './src/app/test.styles';

export * from './src/app/directives/test.directive';
export * from './src/app/services/test.service';
export * from './src/app/pipes/test.pipe';
export * from './src/app/test.styles';

export default {
  directives: [TestDirective],
  pipes: [TestPipe],
  providers: [TestService, TestService2],
  styles: TestStyles.styles(),
  styleUrls: ['src/public/css/test.css']
}

This attempts to handle styles and styleUrls just to experiment with.
The styles utilizes a service with a static method of inline styles that the lib uses:
export class TestStyles {
  public static styles(): string[] {
    return [`
      test a {
        font-size:20px;
        color:blue;
      }
    `];
  }
}

This may or may not be the best way forward, but wanted to give you something to experiment with here to handle inline styles as well as styleUrls.
The TestDirective is now a link to this repo itself.
Test if styles were added properly
If all the styles load properly (the inline as well as the style urls), then the directive should render in blue with font-size:20px (comes from inline style) like so:

Additionally if the styleUrls load properly, the :hover state should be red with text-decoration:none and use cursor:pointer like so:

@ocombe In that case, user could simply exit, Ctrl + c, since the install would have completed, they could just exit the postinstall angular cli if they didn't want to go through those additional steps.

No, it should entirely be optional.
If we use it in the postinstall for npm, then I think that we should have another npm plugin that would be an angular-cli helper, this would be a dependency for your lib, and would check postinstall if angular-cli is installed in this repository, in which case it will install itself (or offer to, we can disable this in CI environment pretty easily), and if not it would just exit.

@ocombe — No, it should entirely be optional.

Agreed, maybe any npm script that is not triggered automatically could do e.g.:
$ npm run angular-cli

Then it would be optional and the benefits of the script remain.
It would also solve the dependency issue where the consumer would have to have angular-cli installed globally to run the script (and thus angular-cli doesn't have to be a devDependency).

@NathanWalker — This attempts to handle styles and styleUrls just to experiment with. Styles utilizes a service with a static method of inline styles that the lib uses.

Great work Nathan! What is your reasoning behind using a static method for styles?

@jvandemo thanks, it's really just 1 way to do it, no particular reason,
and should be simple to test and experiment with. If you have any ideas on
some other ways to handle both inline styles and/or styleUrls, lemme know.
On Mon, Dec 14, 2015 at 11:34 PM Jurgen Van de Moere <
<EMAIL_ADDRESS>wrote:

@NathanWalker https://github.com/NathanWalker — This attempts to handle
styles and styleUrls just to experiment with. Styles utilizes a service
with a static method of inline styles that the lib uses.
Great work Nathan! What is your reasoning behind using a static method for
styles?
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular-cli/issues/96#issuecomment-164673357.

@NathanWalker Interesting, because using a function could be convenient to pass in options e.g.:
styles: TestStyles.styles({
  flexbox: true
})

@jvandemo +1 would provide for some very interesting app configurations across various devices ;)

https://www.npmjs.com/package/ng2-cli-test-lib updated to 2.0.0-beta.0

Turns out a really cool guy @superchris tried out the lib today on his own brave accord and in the process helped reveal a couple things, of which I just fixed in 1.0.7. (it was previously installing its own dependencies in node_modules (within the lib's folder) after installing).
His project shows an example implementation of the ng2-cli-test-lib:
https://github.com/superchris/angular-cli-test
One thing of interest is that the ComponentMetadata:
providers/viewProviders, 'directives, and pipes` all support nested arrays.
However styles and styleUrls do not.
I'm sure this is for good reason but maybe it should be consistent for all metadata.
Given this, when integrating the library in, I had to do this:
https://github.com/superchris/angular-cli-test/blob/master/src/app/angular-cli-test.ts#L9
Which is not 1/1 consistent with the others. Not sure if this should be reported as an issue or if this difference is warranted.
Lastly, until the cli implements some of the features aforementioned, styleUrls will be a more manual process when installing/using 3rd party libs, so I did not implement that in @superchris awesome test project.

we should be using spread operator whenever possible since it also clearly shows which ones are collections and which ones aren't (as if all caps wasn't enough)
import {FORM_DIRECTIVES} from 'angular2/common';
import {APP_PROVIDERS} from '../app-providers';
import {MyDirective} from './my-directive';
import {APP_STYLES, APP_THEME_STYLES} from '../app-styles';
@Component({
  selector: 'home',
  providers: [
    ...APP_PROVIDERS
  ],
  directives: [
    ...FORM_DIRECTIVES,
    MyDirective
  ],
  styles: [
    ...APP_THEME_STYLES,
    `
      .main {
        background: gray;
      }
    `
  ],
  template: `
    <my-directive></my-directive>
  `
})
export class App {}

for styles: we can use the spread operator for now. I made a pull-request to spread all the collections https://github.com/angular/angular/pull/6049

@gdi2290 +1 nice :)

I got something working. See https://github.com/angular/angular-cli/pull/135
Based on @NathanWalker test lib https://github.com/NathanWalker/ng2-cli-test-lib

Is it possible to add 3rd party library without adding mappings to system config?

With @jkuri 's help, we were able to modify ng2-cli-test-lib to be compatible with SystemJS specifically.
This makes the lib work with the incredible effort @jkuri put forth here: https://github.com/angular/angular-cli/pull/135

Please check out my last commit. Any suggestions/tests/fixes/comments are very welcome. If someone interested to check it out, here is usage example
git clone https://github.com/jkuri/angular-cli -b 3rd-party-libs
cd angular-cli
npm i
[sudo] npm link

then create new project using ng new somewhere
ng new project
cd project
npm link angular-cli
ng libs install ng2-cli-test-lib
ng libs uninstall ng2-cli-test-lib

I tested out and the project builds properly, with injecting with custom or automatic injection or uninstalling the lib afterwards (cleans properly).
If this will hopefully be accepted by maintainers we can define how the library must be created to be compatible with ng libs command and rework the code afterwards. Now  ng2-cli-test-lib library uses systemjs-builder to generate SystemJS compatible format and the script looks like this.
If we decided to also support other loaders than system, to facilitate the work of developers of the libs, this script can easily be tweaked to export other formats.

The more I think about this idea, the less I like it, at least in regards to automatic code generation and injection and the like. I think it's an overreach for what the CLI should do.

I can certainly understand that.
To me, cli tools in general are merely a toolbox containing commands that
make tasks easier. Some use more commands all the time whereas to others
maybe never.
The goal here was to simply offer an additional helpful aid to those that
find it helpful.
Personally, this is the type of tool in the toolbox that I would use for
rapid prototyping where a boss comes to me and says, "I'd like to see
what's possible for this idea by tomorrow." I may not use it all the time
but there are times where I would appreciate it.
I think most advanced users (pros) always have a sour taste for tools that
offer to sugar up an otherwise easy task for them. Git GUI apps vs. command
line: perfect example of this.
In the end, it's just about helpful options to me. Ya like honey on your
toast? Great. And for you, grape jam? Fantastic.
On Tue, Jan 12, 2016 at 1:44 AM Rob Wormald<EMAIL_ADDRESS>wrote:

The more I think about this idea, the less I like it, at least in regards
to automatic code generation and injection and the like. I think it's an
overreach for what the CLI should do.
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular-cli/issues/96#issuecomment-170854097.

@robwormald you can simply answer "no" to the first questing after installing a lib with that command/task.

This has been merged. Documentation is here: https://github.com/angular/angular-cli/pull/173


Call built-in ProvisionerCleanup on vagrant destroy

... otherwise plugins like vagrant-butcher aren't triggered. Compare with: https://github.com/mitchellh/vagrant/blob/v1.7.2/plugins/providers/virtualbox/action.rb#L97
Works fine with vagrant-butcher on multi-machine setup.

LGTM!

@pfink Thanks for this PR, I think we will merge this one pretty quickly, obviously :+1:


[WFCORE-5073] ConsoleMode should not return true from hasConsole if t…

…he module is not present
https://issues.redhat.com/browse/WFCORE-5073

Core - Full Integration Build 9821 outcome was FAILURE using a merge of 43eda602ce8128f32c90b2d4c02c32f553e12c81
Summary: Exit code 1 (Step: Build & test full (Maven)) (new) Build time: 00:04:11

Core - Full Integration Build 9861 outcome was FAILURE using a merge of 43eda602ce8128f32c90b2d4c02c32f553e12c81
Summary: Exit code 1 (Step: Build & test full (Maven)) (new) Build time: 00:04:24

Core - Full Integration Build 9824 outcome was FAILURE using a merge of 43eda602ce8128f32c90b2d4c02c32f553e12c81
Summary: Tests failed: 1 (1 new), passed: 2393, ignored: 14 Build time: 01:03:52
Failed tests
org.jboss.as.test.clustering.cluster.jpa.ClusteredJPA2LCTestCase.testEntityCacheReplication: java.lang.AssertionError
	at org.jboss.as.test.clustering.cluster.jpa.ClusteredJPA2LCTestCase.testEntityCacheReplication(ClusteredJPA2LCTestCase.java:115)
------- Stdout: -------
 [0m02:16:20,545 INFO  [org.jboss.modules] (main) JBoss Modules version 1.10.1.Final
 [0m [0m02:16:21,070 INFO  [org.jboss.msc] (main) JBoss MSC version 1.4.11.Final
 [0m [0m02:16:21,090 INFO  [org.jboss.threads] (main) JBoss Threads version 2.3.6.Final
 [0m [0m02:16:21,330 INFO  [org.jboss.as] (MSC service thread 1-1) WFLYSRV0049: Test 21.0.0.Beta1-SNAPSHOT (WildFly Core 13.0.0.Beta4-SNAPSHOT) starting
 [0m [0m02:16:22,648 INFO  [org.wildfly.security] (ServerService Thread Pool -- 15) ELY00001: WildFly Elytron version 1.13.0.CR3
 [0m [0m02:16:24,179 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m02:16:24,210 INFO  [org.xnio] (MSC service thread 1-1) XNIO version 3.8.1.Final
 [0m [0m02:16:24,232 INFO  [org.xnio.nio] (MSC service thread 1-1) XNIO NIO Implementation Version 3.8.1.Final
 [0m [0m02:16:24,339 INFO  [org.jboss.remoting] (MSC service thread 1-6) JBoss Remoting version 5.0.18.Final
 [0m [0m02:16:24,372 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 29) WFLYCLINF0001: Activating Infinispan subsystem.
 [0m [0m02:16:24,395 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 31) WFLYRS0016: RESTEasy version 3.12.1.Final
 [0m [0m02:16:24,399 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 33) WFLYCLJG0001: Activating JGroups subsystem. JGroups version 4.2.4
 [0m [33m02:16:24,444 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 39) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.
 [0m [0m02:16:24,474 INFO  [org.jboss.as.naming] (ServerService Thread Pool -- 36) WFLYNAM0001: Activating Naming Subsystem
 [0m [0m02:16:24,493 INFO  [org.jboss.as.connector] (MSC service thread 1-3) WFLYJCA0009: Starting JCA Subsystem (WildFly/IronJacamar 1.4.22.Final)
 [0m [0m02:16:24,523 INFO  [org.wildfly.extension.io] (ServerService Thread Pool -- 30) WFLYIO001: Worker 'default' has auto-configured to 8 IO threads with 64 max task threads based on your 4 available processors
 [0m [0m02:16:24,550 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 25) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 1.4)
 [0m [0m02:16:24,566 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0003: Undertow 2.1.3.Final starting
 [0m [33m02:16:24,625 WARN  [org.wildfly.clustering.web.undertow] (ServerService Thread Pool -- 40) WFLYCLWEBUT0007: No routing provider found for default-server; using legacy provider based on static configuration
 [0m [0m02:16:24,630 INFO  [org.jboss.as.connector.deployers.jdbc] (MSC service thread 1-4) WFLYJCA0018: Started Driver service with driver-name = h2
 [0m [0m02:16:24,742 INFO  [org.jboss.as.naming] (MSC service thread 1-5) WFLYNAM0003: Starting Naming Service
 [0m [0m02:16:24,969 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0012: Started server default-server.
 [0m [0m02:16:25,027 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-6) WFLYUT0018: Host default-host starting
 [0m [33m02:16:25,097 WARN  [org.jboss.as.domain.http.api.undertow] (MSC service thread 1-7) WFLYDMHTTP0003: Unable to load console module for slot main, disabling console
 [0m [0m02:16:25,124 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-1) WFLYUT0006: Undertow HTTP listener default listening on [::1]:8080
 [0m [0m02:16:25,195 INFO  [org.jboss.as.patching] (MSC service thread 1-4) WFLYPAT0050: Test cumulative patch ID is: base, one-off patches include: none
 [0m [33m02:16:25,248 WARN  [org.jboss.as.domain.management.security] (MSC service thread 1-4) WFLYDM0111: Keystore /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/clustering/target/wildfly-jpa-dist-1/standalone/configuration/application.keystore not found, it will be auto generated on first use with a self signed certificate for host localhost
 [0m [0m02:16:25,266 INFO  [org.jboss.as.server.deployment.scanner] (MSC service thread 1-8) WFLYDS0013: Started FileSystemDeploymentService for directory /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/clustering/target/wildfly-jpa-dist-1/standalone/deployments
 [0m [0m02:16:25,500 INFO  [org.jboss.as.connector.subsystems.datasources] (MSC service thread 1-4) WFLYJCA0001: Bound data source [java:jboss/datasources/ExampleDS]
 [0m [0m02:16:25,622 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0212: Resuming server
 [0m [0m02:16:25,624 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: Test 21.0.0.Beta1-SNAPSHOT (WildFly Core 13.0.0.Beta4-SNAPSHOT) started in 5749ms - Started 202 of 348 services (203 services are lazy, passive or on-demand)
 [0m [0m02:16:25,625 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://[::1]:9990/management
 [0m [0m02:16:25,626 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0054: Admin console is not enabled
 [0m [0m02:16:26,610 INFO  [org.jboss.modules] (main) JBoss Modules version 1.10.1.Final
 [0m [0m02:16:27,063 INFO  [org.jboss.msc] (main) JBoss MSC version 1.4.11.Final
 [0m [0m02:16:27,076 INFO  [org.jboss.threads] (main) JBoss Threads version 2.3.6.Final
 [0m [0m02:16:27,231 INFO  [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: Test 21.0.0.Beta1-SNAPSHOT (WildFly Core 13.0.0.Beta4-SNAPSHOT) starting
 [0m [0m02:16:28,487 INFO  [org.wildfly.security] (ServerService Thread Pool -- 7) ELY00001: WildFly Elytron version 1.13.0.CR3
 [0m [0m02:16:29,673 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m02:16:29,698 INFO  [org.xnio] (MSC service thread 1-3) XNIO version 3.8.1.Final
 [0m [0m02:16:29,708 INFO  [org.xnio.nio] (MSC service thread 1-3) XNIO NIO Implementation Version 3.8.1.Final
 [0m [0m02:16:29,755 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 29) WFLYCLINF0001: Activating Infinispan subsystem.
 [0m [0m02:16:29,767 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 31) WFLYRS0016: RESTEasy version 3.12.1.Final
 [0m [33m02:16:29,767 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 39) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.
 [0m [0m02:16:29,784 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 33) WFLYCLJG0001: Activating JGroups subsystem. JGroups version 4.2.4
 [0m [0m02:16:29,816 INFO  [org.jboss.as.connector] (MSC service thread 1-5) WFLYJCA0009: Starting JCA Subsystem (WildFly/IronJacamar 1.4.22.Final)
 [0m [0m02:16:29,853 INFO  [org.wildfly.extension.io] (ServerService Thread Pool -- 30) WFLYIO001: Worker 'default' has auto-configured to 8 IO threads with 64 max task threads based on your 4 available processors
 [0m [0m02:16:29,859 INFO  [org.jboss.as.naming] (ServerService Thread Pool -- 36) WFLYNAM0001: Activating Naming Subsystem

Core - Full Integration Build 9864 outcome was FAILURE using a merge of 43eda602ce8128f32c90b2d4c02c32f553e12c81
Summary: Tests failed: 1 (1 new), passed: 6724, ignored: 104 Build time: 04:38:32
Failed tests
org.jboss.as.test.integration.messaging.mgmt.JMSQueueManagementTestCase.removeJMSQueueRemovesAllMessages: java.lang.AssertionError: expected:<1> but was:<2>
	at org.jboss.as.test.integration.messaging.mgmt.JMSQueueManagementTestCase.removeJMSQueueRemovesAllMessages(JMSQueueManagementTestCase.java:518)

@bstansberry thanks


fix: substring with negative indices should produce correct result

Which issue does this PR close?
Closes #463
Rationale for this change
Fix for substring with negative indices produces incorrect results
What changes are included in this PR?

negative len in substring(child, start, len) should be >= 0
test cases

How are these changes tested?
added more test cases that would fail without the change.

@viirya @andygrove can you take a look. Thanks

Merged. Thanks @sonhmai @andygrove


chore(Python): add diameter of binary tree

PR Checklist:

[ ] My submission is formatted according to the guidelines in the contributing guide
[ ] My addition is on refer on the language README.md file
[ ] My addition does not have a spelling problem
[ ] My submission has a proper and user-friendly description of the algorithm
[ ] My submission has the time complexity of the algorithm
[ ] My submission has sample input-output of the program (NOT FOR PYTHON)

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

Other information:

Hi @geekboi777,
Please complete the pull request checklist

PR Checklist:

[ ]  My submission is formatted according to the guidelines in the contributing guide
[ ]  My addition is on refer on the language README.md file
[ ]  My addition does not have a spelling problem
[ ]  My submission has a proper and user-friendly description of the algorithm
[ ]  My submission has the time complexity of the algorithm
[ ]  My submission has sample input-output of the program (NOT FOR PYTHON)

What kind of change does this PR introduce? (check at least one)

[ ]  Bugfix
[ ]  New algorithm
[ ]  Optimization in previous algorithms
[ ]  Code style update
[ ]  Refactor
[ ]  Documentation
[ ]  Other, please describe:

Briefly describe the changes in this PR
Other information:

Hi @geekboi777,
Please completed the pull request checklist, and this will be a valid pull request

Hi @geekboi777,
Any updates?

Hi @geekboi777,
This pull request will be closed when making a change please re-open this pull request.


Proof-Read-01 Spanish version

Proof-read Spanish version. Moved some lines to match English order.

@PolyDeveloper can you do a new merge on this and resubmit? There appear to be some merge conflicts.

@jjeffryes Can you please walk me through the process? I noticed there is a message: Only those with write access to this repository can merge pull requests. Could it be  is because I don't have write access? Thanks

@PolyDeveloper you should be able to do it with these git commands:
git fetch
git merge master
That will get a copy of the latest master file, and merge it with your current branch. After that check the code to make sure it's working, and the merge didn't break anything.
If you are using the Git desktop app, then do the following:

switch your current branch to master
click the sync button to update to the latest copy
switch back to you patch-1 branch
you should now see an option for "Update from master", click it
if there are any conflicts, they will be listed in the Changes screen
if everything is fine, click sync again (while in your patch-1 branch) to update this PR.

@jjeffryes Getting the following:
Conflicts:
js/models/languagesMd.js

Closed by #356


Provide and install OpenShift related manifests

install MachineConfig to provide a new SELinux policy
install SecurityContextConstraint to provide RTE DaemonSet additional permissions

/lgtm
see the inline comments

/hold I want to move ignition logic under getting manifests, because I totally agree that it should not be under the update, because it something that should be static

/hold cancel


[BUG] Does not work for Matrix Jobs

It appears that the values from the Matrix spec are not being used templated into the Job script correctly

This problem was caused by how we copy files to the Job to run, which was now changed and fixed in this commit. So everything should and seems to work now


additional stale element captures

I missed a couple references in the final version of #291. This also fixes this issue.

Coverage remained the same at 95.79% when pulling 53ecc8f4c7cf16314d51b182838e005a6266ebef on titusfortner:additional_stale into e7996d6e646d244142d27d1367feb8df186c16e3 on watir:master.

Coverage remained the same at 95.79% when pulling 53ecc8f4c7cf16314d51b182838e005a6266ebef on titusfortner:additional_stale into e7996d6e646d244142d27d1367feb8df186c16e3 on watir:master.


How can I set the ui-tabset breakpoint to xs?

I have looked through the documentation and have searched through the issues tab and am unable to find an answer.
How can I set the ui-tabset directive to break at the xs breakpoint?
(just to confirm this is when the tab headings break (and stack vertically) not the content itself).
<div class="container-fluid">
      <uib-tabset justified="true">
        <uib-tab heading="tab1">
           .....
        </uib-tab>
        <uib-tab heading="tab2">
          .....
        </uib-tab>
      </uib-tabset>
    </div>
  </div>

@jamesla, please be respectful of our time and our process by adhering to the issue template, the first line of which indicated that the issues forum is not to be used for support requests.  Thanks.  As this is clearly a support request, I am closing this.
Additionally, it is not at all clear what you mean by "xs" breakpoint.


Show curator notes on term info page

The ontology will soon have addition annotation property assertions beyond the usual comment, definition, synonym, subset. One of the most important ones will be curators_note, which will appear when @dougli1sqrd implements the SPARQL construct for https://github.com/geneontology/go-ontology/issues/13384
We would like curator note to appear in the amigo term info. More generally it would be good for this to be extensible to other properties which may appear (and are more common in other ontologies); but for GO curators curator_note is a high priority.
I can see two possible implementations

Treat analogous to existing APs, add a new field in owltools to access, add a field in the solr schema, and change the term info perl template to include
Use obojson (where extensible annotations are standardized). This is already defined (#58).

I think 1 would be preferred if we ever want to facet on these, which we don't so I would opt for 2.
This in on the same path for fixing things like showing synonym scope (#290 - see checklist).
Note: we'll also want this visible in Noctua somehow, but this will depend on https://github.com/geneontology/noctua/issues/257

@cmungall What is the relationship with #421 ?

Also note #368 .

#421 depends us committing to a certain path for documentation. I think it's easier to decouple these and keep 421 on the wishlist.


Documentation for how to set user attributes

Hi, we're evaluating using Wasabi, and there's one thing I haven't been able to figure out from the docs. If we want to limit an experiment to users from CA for example, how do we let Wasabi know which users these are? Is it:
a) Set it in advance, via an API call?
b) Looked up from our database during assignment?
c) Passed from the client in the assignment API call?
While digging through the Java docs I see mention of a "SegmentationProfile" and related mentions of "Hyrule", but haven't been able to figure out how these are set. Is there API documentation somewhere?

Sorry that this wasn't documented better.  The first thing you might want to know is that, if you are able to get Wasabi installed on your local machine, you can get to the API docs (using Swagger) by cd'ing to your local wasabi repo and typing:
./bin/wasabi.sh resource:api
This is mentioned toward the end of the README (scroll down when you're on the top level wasabi page here on github).
But to answer your question, Wasabi definitely handles segmenting users, e.g., limiting the users put in the test by the state they live in.  You can control which users are in the test based on their passing a segmentation rule.  You define the rule using the Wasabi Admin UI, in the Segmentation tab when you are editing an experiment.  You can either define it using widgets (if your rule is simple enough, e.g., the example you gave) or you can define it using a rule language (the online help has some information about the language).  Usually, you will be fine using the widgets and then you don't need to remember the language syntax.
In order to actually use segmentation in Wasabi, you create an experiment and define a segmentation rule for it.  Part of what you define in the segmentation rule is the name of the parameters that will contain the value for each user, e.g., "state" in your example.  Then you start your experiment.  When you call the Wasabi to request whether a particular user is in the experiment and, if so, what bucket they're assigned to, you need to call a version of the API where you pass in some JSON that includes "profile information" about the user, that is, things like what state they are in.  Look at the API Calls tab for your experiment in the Admin UI for an example call using curl.  The information you pass is then plugged into the rule and if the result is "true", then the user is allowed in the test.  Of course, then things like sampling rate, mutual exclusion, etc. will come into play, but at least the user will now be past the segmentation stage.  If they do not pass the segmentation rule, you will get that in the response from the API call.
So, basically, the answer is c) in your list of choices in your question.
Note that Hyrule is simply the engine we use to evaluate rules.  It is what executes the language using the profile.

Thanks for the prompt reply! That makes sense, and is what I suspected. Looking forward to doing a full investigation and kicking the tires on it very soon. Cheers!

Was this one closed without updating the documentation? It's still a bit confusing. Suggestions:

Add a section to the user-guide on this with a screenshot of the API Calls section
Provide a more complex curl example to the /assignments endpoint in the "Call Wasabi" section of the user guide

I was trying to solve exactly the same problem, then I stumbled upon this post
https://github.com/intuit/wasabi/issues/289


rel shortcode doesn't work for static files

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.87.0+extended linux/amd64 BuildDate=unknown

Does this issue reproduce with the latest release?
yes
I have a static file I would like to show the full URL for in a page.
content/index.md
static/deployment.yaml

In my page I would like to have this content rendered (backslashes added to escape GH formatting)
\```bash
kubectl apply -f {{< ref "/deployment.yaml" >}}
\```

But instead I get an error that the page is not found
[en] REF_NOT_FOUND: Ref "/manifests/hello-eks-a.yaml": "/home/rothgar/src/website/content/index.md:14:18": page not found
Rebuild failed:

Logged 1 error(s)

Can this check be disabled or can static files be supported by the ref shortcode?

Can this check be disabled

You can format the shortcode within the code fences such that it will not be evaluated:
{{</* ref "/deployment.yaml" */>}}

This will be rendered as:
{{< ref "/deployment.yaml" >}}

You can configure the ref and relref functions (and their corresponding shortcodes) to throw a warning instead of an error. See https://gohugo.io/content-management/cross-references/#ref-and-relref-configuration

can static files be supported by the ref shortcode?

Currently the ref and relref functions (and their corresponding shortcodes) are limited to pages, but you could do something like this:
layouts/shortcodes/absurl.html
{{ absURL (.Get 0) }}

Then in your content:
{{< absurl "/deployment.yaml" >}}

Thanks for the quick comment. I saw a thread about ignoring the rendered content but in this case I want the content to be rendered properly in the code block.
I was hoping to avoid creating a custom shortcut but I'm guessing that's probably the easiest solution.
I also didn't know about configuring the error level. That might be another good alternative but I would be worried that won't catch other situations where I want an error for missing pages.


Could page range be cleaned up automatically?

Hi,
Being a sloppy maintainer of my zotero database, and importing references from many different sources as well, I get space and dash- differences in the pages field.
Sometimes there is just one dash between the page numbers, sometimes there are more.
Also the space between the numbers and the dashes can vary.
Better bibtex currently (5.2.16) seems to do no translation of this field and I think (correct me if I'm wrong) a bibtex citation style also cannot remove superfluous space.
I propose to automatically clean up the 'pages' field during export by replacing
<space><number1><space><dash(es)><space><number2><space>
with
<number1><en-dash><number2>
Paul
Report ID:
HNWRJTFW-euc
Exporter used:
better bibtex
Expected behavior:
number\en-dash number
Actual behavior:
no filtering at all, just a copy of the pages field contents

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>43 ("clean up some dashes")
Install in Zotero by downloading test build <IP_ADDRESS>43, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

Hi,
In my test
149-158 becomes pages = {149--158}
123  ----      432 becomes {123---432}
Paul

The first is because I assume that to be a page range, and https://tex.stackexchange.com/questions/58668/why-should-i-use-in-pages-field-of-a-bibtex-entry. The second is because 4 dashes don't mean anything in latex (or citeproc - it also looks strange in a zotero-generated bibliography), and a triple-hyphen (em-dash) seems to come closest to the input.

When I google en-dash and em dash, I understand that the proper character for a page range is the en-dash.
One dash is considered an error by the test build, and fixed by adding the missing dash.
I think 3 dashes should also map to two dashes, to end up with an en-dash in latex. I don't see the difference with the single dash, both are syntactically valid, but bad practice.
I understand your argument against replacing 4 dashes, it wasn't a very serious example, but still possible...
Paul

Anything is possible in the pages field, as it's free-form text.

Looking at https://github.com/retorquere/zotero-better-bibtex/commit/a6796ad481719d4f904d4ddcbb7b8cfef6f90da6, I think that a space after a comma should be kept, e.g., for pages = {20, 1--14}.

Ok, this makes sense.
Thanks for your time.
Paul

@qqobb working on that.

@qqobb would you expect the space to be retained, or added?

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>63 ("keep spaces after comma")
Install in Zotero by downloading test build <IP_ADDRESS>63, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

My view is, while it’s probably safe to remove spaces in patterns like “number(s) space hyphen(s) space number(s)“ in pages fields (though some nagging doubts remain), spaces after commas as well as pretty much everything else in a pages field should definitely be retained unchanged.
For example, /usr/local/texlive/2019/texmf-dist/bibtex/bib/beebe/tugboat.bib on my machine contains pages = "{c\,3}-{c\,3}", which would no longer be formatted as intended if spaces after commas were added.
A similar (though admittedly hypothetical) example would be a page numbering pattern along the lines of A,7–A,11. (Note that similar patterns such as  G--i--G--v, G-1--G-28, M-1--M-14 do occur in bib files that come with TeX Live as well as in books in the wild.)
As you said yourself, above, ultimately it’s “the responsibility of the user to make sure the zotero entries contain sensible data.”

The replacement is currently pretty picky - I split on ,<spaces> (which is subsequently replaced by ,<space>), and of the chunks that sit between us them, only those exactly matching number - number would be changed. 7-A should be safe.

c<thin space>3-c<thin space>3 wouldn't be picked up for change -- this conversion affects BBT export only, and in Zotero, you either wouldn't have {c\,3}-{c\,3} (and also, it wouldn't be changed because the text between the commas doesn't match <number><optional spaces><hyphens><optional spaces><number>), or you'd have it surrounded by <script> tags, which is always just passed through as-is.

5963 retains space after comma but does not insert it if it's not there.

@njbart do you have samples at hand for the cases you mention so I can add them to my test suite? I'm prepping for a new release.

Sorry for replying late. I agree with @njbart's comments, but don't have strong opinions. As written in https://tex.stackexchange.com/a/58671 linked to above, many BibTeX style files (.bst) take care of the pages field, e.g., replacing - by -- to produce an en-dash. So at least some of the issues here might already be taken care of by the style you use. Generally, avoiding automatic "corrections" might be desirable for code simplicity and user control of the output. Trying to keep the translation on a letter-by-letter basis where possible might be a good design choice. But the transformations here seem moderate, so it might be ok to include them. An alternative might be to move this to a postscript which users could find in the documentation.

the cleanup behavior is pretty old in BBT (although this extends it a bit), if I removed it entirely  behavior would change for existing users. I'd rather not do that, I'm going to schedule a release with what I have now.


fmriprep 20.2.1 image on Docker Hub?

I was just looking to update our Singularity image to fmriprep 20.2.1, which I see at GitHub is at
20.2.1 (Long-Term Support)
from Nov 6, 2020.  On Docker Hub, though, the version is reported as fmriprep 20.2.0, though, but the date says Sep, 28, 2020.
Will there be an updated Docker Hub image for 20.2.1?

nipreps/fmriprep:20.2.1

Ah.  Sorry I missed the switch to the new group name at Docker Hub.


Obsolete default project version

According #209 we use for Pyb develop version number like "A.B.C.dev" which allows automatically increase distribution version by timestamp (like maven). But default version for projects without version is version="1.0.dev0". More usefull will be version="1.0.0.dev"
Also we should add "A.B.C.dev" behaviour description to documentation.

I think this was done for backwards compatibility to ensure we don't disrupt other people's versioning schemes if they had dev0.

Nothing is preventing a user to set their default version to use dev

Backwards compatibility will keep because it's affect only dev versions. If somebody use default 1.0.dev0 for any production purpose - it's very bad practice and we should stop it.
Also with changes we will provide high culture of .dev usage (when I asked guys who works with Pyb in my env - they confirm that created first version as copy-paste from Pyb summary).

@AlexeySanko PyBuilder substitutes .dev with actual .devN where N is timestamp. It does not substitute .dev0 or any .devM when specified directly, since those values are not normalized per PEP-0440.
https://www.python.org/dev/peps/pep-0440/#developmental-releases
https://www.python.org/dev/peps/pep-0440/#implicit-development-release-number
https://github.com/pybuilder/pybuilder/blob/7017a2a9dcc20286f75711e16203d42a65047cb2/src/main/python/pybuilder/core.py#L348

Hi, @arcivanov
I know about it (and about pep440 and about .dev) - I created pull request to docs - https://github.com/pybuilder/pybuilder.github.io/pull/29
But A.B.C.devXXXXXX looks like really better than 'A.B.devC'.

Convension is convension. And dics will be enough. I'll rollback this changes into https://github.com/pybuilder/pybuilder/pull/502

Can we close this then?

Rollbacked into #502


json workflows won't load

When I try to load a json workflow, nothing happens. There's no message in the terminal or anything. It just does nothing. Drag-n-drop or browse doesn't make a difference.
Any help would be appreciated. Thanks in advance.

Did you miss the readme migration notice? https://github.com/Stability-AI/StableSwarmUI?tab=readme-ov-file#migration-notice
https://github.com/mcmonkeyprojects/SwarmUI/discussions/2

Did you miss the readme migration notice? https://github.com/Stability-AI/StableSwarmUI?tab=readme-ov-file#migration-notice mcmonkeyprojects/SwarmUI#2

Yeah. I just migrated, hoping it would fix it, but it didn't.
It seems to be the larger json's (~500k) written in Python. The smaller ones (~30k) seem to work just fine.

You're posting in the legacy repo here, need to use the modern repo

Well, either way, I mean, it's the same error as before I migrated. If someone knew what was wrong, I could at least try it.

You need to post in the correct repo


Upgraded version of pyparsing

Now pip install -r requirements.txt works in Python 3

Awesome - thanks @askogvold! Can you please PR this over to the base directory as well?


Mention the styling of controls

I was following the tutorial and I couldn't understand why the controls were not appearing (obvious in retrospect).
Maybe instead of adding the style to the diff, you can put some mention about style not being added or something.
(thanks for the work anyway)

ah yep, good catch, thanks!


Fix ServicePrincipalNames description

The current ServicePrincipalNames description is completely wrong. Replaced with the text from the updated Get-Help description.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@X-Guardian Thank you for following up with copy editing suggestions.

@dariomws306 @get-itips @tseward
Peer review needed for this PR. Thanks.

Looks good.

Looks ok.

I am ok with this one.

@AndreaBarr This PR that has passed review is ready to be merged.


vector: update platforms list to include aarch64-darwin

Description of changes
Some local testing has revealed that Vector builds on aarch64-darwin without issue. I can't currently verify for x86_64-darwin but it'd be great if someone else could test that out.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Verified this in #194653 :slightly_smiling_face:


How to get access to Clerk instance outside of components?

Hi! I'm working on an Astro app that utilizes vue-clerk. It all works great, but I have a use case where I need access to the Clerk instance in code outside of components. I know that inside the components I can use useClerk composable, but how can I get access to it in non-component code?

Hello! You can access the Clerk instance attached to the window object:
console.log(window.Clerk.loaded)

Also, if you don't mind the Vue components and is cool to use Astro components, please see @clerk/astro. You can use the provided stores and create your own composables

Thanks @wobsoriano ! The window.Clerk works great. @clerk/astro seems to focus on Astro with server rendering, so I'm gonna stick with vue-clerk :)
If somebody else searches for solutions, this is how I ended up using it to connect to SurrealDB database using JWT token from Clerk:
...
const token = await window.Clerk.session?.getToken();
if (!token) {
  console.error("No token to authenticate with");
  return undefined;
}

await database.connect(SURREALDB_URL, {
  prepare: async (connection) => {
    await connection.use({ namespace: "test", database: "test" });
    await connection.authenticate(token);
  },
});
...

Glad it worked out for you!
FYI we support static and hybrid outputs in @clerk/astro as well!


PHP 8.4.0beta5

apcu build is broken. Is there a reason we include apcu in the bref base layer? Does it not work as an extension?

This extension is built-in the main bref layers.

I see you triggered a rebuild, but I don't think it'll succeed, as changes are needed to the apcu extension source to make it work properly on beta5 (and later).

Yep, I figured it doesn't hurt to retry 🤷 But the error message didn't look like it would make any difference.

Building the extension from source seems to work. Not sure if what I've done is actually identical to what we had before. Was the extension previously being enabled using an ini file?

APCu 5.1.24 has now been released.

Nice!


Correct purpose differentiation between Icarus and Shelley

Issue Number

adp-766
Overview

[x] correcting account -> hardened derivation
[x] differentiate between Icarus and Shelley

Comments

Note: approving now, but our test coverage should've been / should be sufficient to cover this.

I have added additional assertions to check if derivation path is valid for Shelley / Icarus and Byron addresses in the integration tests.

bors r+


Freezes main thread

I have a tinder-like stack of images. Touch events are not delivered while big images gets loaded/decode.
Thats because you decode image with dispatch_sync and it stops main_thread.

Been experimenting with this approach:
public func connection(connection: NSURLConnection, didReceiveData data: NSData) {
        self.data?.appendData(data)

        dispatch_sync(queue) {
            let decoder = CCBufferedImageDecoder(data: self.data)
            decoder.decompress()
            let decodedImage = decoder.toImage()

            UIGraphicsBeginImageContext(CGSizeMake(1,1))
            let context = UIGraphicsGetCurrentContext()
            CGContextDrawImage(context, CGRectMake(0, 0, 1, 1), decodedImage.CGImage)
            UIGraphicsEndImageContext()

            dispatch_async(dispatch_get_main_queue()) {
              self.image = decodedImage
              self.setNeedsDisplay()
              self.layoutIfNeeded()
            }
        }
    }

Call load(URL: NSURL) from background thread:
dispatch_async(dispatch_get_global_queue(QOS_CLASS_DEFAULT, 0), { () -> Void in
    self.imageView.load(NSURL(string: URLString)!)
})

It works quite well, but sometimes images not displayed. 2 of 10 runs approx.
Any thoughts?

I think 782488618da9a3b453270fad0e58a366bdb5bdef should mitigate this. If not, are you able to share an example image / code snippet for debugging purposes?


Update keep alive of client to 5min to prevent spamming the server

Related to https://github.com/mesg-foundation/core/issues/760, https://github.com/mesg-foundation/core/issues/759 and https://github.com/mesg-foundation/core/pull/770
Client should not ping the server more often than the EnforcementPolicy.MinTime set on the server otherwise they get a GOAWAY error.
By default it's 5min, so I set the client to ping the server every 5min.
Also, by setting the client ping > to server ping, it also resolves the problem when both client and server were pigging themselve in both way. Now the client actually never has to ping the server if the connection is still open and the server pings the client.
This is a critical fix and needs to be released as soon as possible.

This fix worked for me


Skip screenshot -- per component config?

Hello, I just stumbled across this project and it is great! Thank you.
I was wondering if there could be a way to skip screenshots for components, sort of along the lines of the async screenshots. With some sort of config, like:
export const MyComponent = () => {...};
MyComponent.viteshot = { skip: true };

I know I could get fancy with the filePathPattern but I could have some things that I would like skipped all over the place and that could get messy.

Hey @jgodi, sorry for the delay (was on holidays then got covid 😷).
I'm curious what's your filePathPattern in this case? Is it that you're using Storybook stories as the source of your ViteShot screenshots, and some of them aren't screenshot-friendly so you want to disable them?

We have since re-architected our docs. These can likely be closed out.
Basically we had all of our examples that we wanted to take screenshots for as *.snippet.tsx. But there were some that had that name that we showed in our docs, that we didn't want screenshots taken. So that is where this skip came in.
Now, we have different *.example.tsx and .snippet.tsx to differentiate the two.

https://github.com/fwouts/viteshot/pull/82 could be closed out too, if you want


(again...) No Syntax Highlighting for python

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.82.2
OS Version: Windows 11 22621.2283

Again i have no syntax highlighting after updating vscode and some extensions.
It looks like this:

Yes, I activated Pylance. And Yes it is selected.
Also, i enabled this: "editor.semanticHighlighting.enabled": true
Restarted VSCode, nothing changed. Reinstalled Python Extension, nothing changed.
I've opened this session on a network folder. But i added it to the "allowed" paths
I'm tired of this.

Addition:
log of python language server

Try removing the "editor.semanticHighlighting.enabled": true line

as expected, nothing changes.


[dv] Use array for multi-reg in RAL model

Address #5852 item 1
Change to generate multi-reg as below. User can access the reg by using
the index, e.g. ral.sw_binding[0]
 class keymgr_reg_block extends dv_base_reg_block;
    rand keymgr_reg_sw_binding sw_binding[8];
    rand keymgr_reg_salt salt[8];

before this change, it generates the multi-reg like this
 class keymgr_reg_block extends dv_base_reg_block;
    rand keymgr_reg_sw_binding_0 sw_binding_0;
    rand keymgr_reg_sw_binding_1 sw_binding_1;
    rand keymgr_reg_sw_binding_2 sw_binding_2;
    rand keymgr_reg_sw_binding_3 sw_binding_3;
    rand keymgr_reg_sw_binding_4 sw_binding_4;
    rand keymgr_reg_sw_binding_5 sw_binding_5;
    rand keymgr_reg_sw_binding_6 sw_binding_6;
    rand keymgr_reg_sw_binding_7 sw_binding_7;
    rand keymgr_reg_salt_0 salt_0;
    rand keymgr_reg_salt_1 salt_1;
    rand keymgr_reg_salt_2 salt_2;
    rand keymgr_reg_salt_3 salt_3;
    rand keymgr_reg_salt_4 salt_4;
    rand keymgr_reg_salt_5 salt_5;
    rand keymgr_reg_salt_6 salt_6;
    rand keymgr_reg_salt_7 salt_7;

multi-fields will be handled in next PR
Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

This is a nice improvement, but I don't think the approach taken in the code is something we should merge. The problem is that you add a "upward link" from a register to its parent multi-register. This kind of breaks the data model that the reggen code uses (where big things only contain smaller things).
Fortunately, it's not too hard to do this the other way around. I'm going on holiday for a week tomorrow(!). As I didn't want to leave this in limbo, I've knocked together something that I think should work better. I'll push it up as a draft PR in a second, linking back here. Please could you grab the changes there and squash them into this PR?
There are probably a couple of corners that could still be improved. In particular, I'm not happy about having to duplicate the logic for iterating over all_regs in the template file, but I don't know how to avoid it without passing function pointers to hunks of template, which I don't think Mako supports. It'd be great if you had a better idea than I managed!
Assuming the data model stays sensible, please don't feel you have to wait for a review from me before merging.

Oh, one other note: this won't work if we have a "compact" multi-register that doesn't divide equally into a whole number of registers. For example, suppose there's a 16-bit value that we want 9 copies of. In that case, the last register really is of a different type because it just contains one 16-bit field, not two.
I'm perfectly happy for us to add an assertion to the MultiRegister code to disallow such things, but please could you do that before merging support for arrays? (Otherwise, I think we'll get rather confusing errors if we ever end up in this situation).

Oh, one other note: this won't work if we have a "compact" multi-register that doesn't divide equally into a whole number of registers. For example, suppose there's a 16-bit value that we want 9 copies of. In that case, the last register really is of a different type because it just contains one 16-bit field, not two.
I'm perfectly happy for us to add an assertion to the MultiRegister code to disallow such things, but please could you do that before merging support for arrays? (Otherwise, I think we'll get rather confusing errors if we ever end up in this situation).

thank you very much for making the PR #7191. I have squashed it into the first commit here
on the top of that, I added 2nd commit to handle unevenly divided mulitreg. Please take a look.
Here is the commit message
Update on the top of #7191
1. add `multireg.dv_compact` and `reg.dv_packed_fields` to support
unevenly divided fields, and some related logic
2. add `gen_dv.riname_w_idx` to get the instance name easier without
adding similiar code in multiple places

3rd PR is to fix all IP to use the new RAL

Looks great, thanks!


Switch default regex engine to PCRE2

This is the next step for the migration towards PCRE2 (#12790).
With this change PCRE2 becomes the default regex engine.
There's still an automatic fallback when pkg-config can't find libpcre2, so you should still be able to build Crystal programs if libpcre2 is missing on the build system. This will change in a future release, though.
It's always possible to actively choose one or the other with -Duse_pcre and -Duse_pcre2.
The compiler continues to be built with PCRE for now to ensure consistency for regex literals in the language (see #12857).

So it looks like PCRE2 JIT support is broken on Windows and leads to invalid memory access (#13013).
All other platforms seem to be working good, though.
To move forward, I have disabled JIT compilation for win32 (we might want to have some way for configuring that in general). It's not essential and we can still move forward with migrating to PCRE2.

After https://github.com/crystal-lang/crystal/pull/13056 is merged we can undo the last commits.


Made styles unique on security grid

Q
A

Bug fix?
yes

New feature?
no

New sample?
no

What's in this Pull Request?
A minor fix on @russgove's awesome security grid web part that fixes issues with other list web parts on the same page being affected.
Also made the web part more theme friendly..

Thanks Hugo!   Do your changes make the webpart pick up the theme color from the site?

Yeah, I didn't test it extensively, so I'm sure that it could be improved, but it picks up the theme colors.
It was my pleasure. I'm always happy to help!

Hey I updated the readme file and added some animated gifs for the new
features but they dont seem to have been pulled. Are they in the queue or
should i do another PR?
On Mon, Apr 6, 2020 at 9:25 AM Hugo Bernier<EMAIL_ADDRESS>wrote:

Yeah, I didn't test it extensively, so I'm sure that it could be improved,
but it picks up the theme colors.
It was my pleasure. I'm always happy to help!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SharePoint/sp-dev-fx-webparts/pull/1196#issuecomment-609792656,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASNDHAPHLRVEMTXBED4RMTRLHJ4LANCNFSM4MCABNKA
.

Do you mind submitting another PR? I don't seem to see the references to the animated GIFs or the updated readme. I'll process it as soon as I receive it, scout's honor!

Hey , the ARE there. I see them on the dev branch. I was looking on the
Master branch.
This as presented on the weekly calls about 3 years ago!
On Mon, Apr 6, 2020 at 10:38 AM Hugo Bernier<EMAIL_ADDRESS>wrote:

Do you mind submitting another PR? I don't seem to see the references to
the animated GIFs or the updated readme. I'll process it as soon as I
receive it, scout's honor!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SharePoint/sp-dev-fx-webparts/pull/1196#issuecomment-609834655,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASNDHBYGITG57LYO226X4TRLHSNHANCNFSM4MCABNKA
.

Thanks, I'll look for them and will integrate the changes. We're trying to move away from the dev branch and accepting PRs directly to the master branch to help process PRs faster.

@russgove I merged your PR and added the theme support we discussed. I hope you don't mind, it is such a cool demo I thought it deserved to look good in every environment :-)

Thanks Hugo. I'm looking forward to installing your updates in my
environment!
On Mon, Apr 6, 2020 at 9:56 PM Hugo Bernier<EMAIL_ADDRESS>wrote:

@russgove https://github.com/russgove I merged your PR and added the
theme support we discussed. I hope you don't mind, it is such a cool demo I
thought it deserved to look good in every environment :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SharePoint/sp-dev-fx-webparts/pull/1196#issuecomment-610129166,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASNDHAM6DKG24JUZ24LHFLRLKB6XANCNFSM4MCABNKA
.

I hope they live up to your quality standards!


TypeScript import issue

Description of the bug
fuse.js v7.0.0
import
import Fuse from "fuse.js";

tsconfig.json (https://github.com/tsconfig/bases/blob/main/bases/node20.json)
"module": "node16",
"moduleResolution": "node16",

package.json
"type": "commonjs",
"engines": {
  "node": "20.x"
},

typescript error

error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("fuse.js")' call instead. To convert this file to an ECMAScript module, change its file extension to '.mts' or create a local package.json file with { "type": "module" }.

Based on comments in this thread, this package incorrectly exports typings.
https://github.com/microsoft/TypeScript/issues/53045#issuecomment-1452605559
The error was resolved when I copied fuse.d.ts to fuse.d.cts and manually edited node_modules/fuse.js/package.json
"exports": {
  ".": {
    "import": {
      "default":"./dist/fuse.mjs",
      "types": "./dist/fuse.d.ts"
    },
    "require": {
      "default":"./dist/fuse.cjs",
      "types": "./dist/fuse.d.cts"
    }
  }
}

Seems like fuse.js needs to expose d.cts and d.ts.

I'm also affected by this issue. Is there any plan to resolve it in near future?


I set the workdir, but the launch directory still generated the ignite directory.

I set the workdir, but the launch directory still generated the ignite directory.
`
IgniteConfiguration igniteConfiguration = new IgniteConfiguration(); igniteConfiguration.setAsyncCallbackPoolSize(Runtime.getRuntime().availableProcessors() / 2); igniteConfiguration.setWorkDirectory(System.getProperty("user.home") + "/data");
`

Did the set workdir not take effect? What does this file mean?

It works as expected for me with Ignite 2.16:
package org.example;

import org.apache.ignite.Ignition;
import org.apache.ignite.configuration.IgniteConfiguration;

public class Main {
    public static void main(String[] args) {
        IgniteConfiguration igniteConfiguration = new IgniteConfiguration();
        igniteConfiguration.setWorkDirectory(System.getProperty("user.home") + "/w/tests/ignite-work");

        Ignition.start(igniteConfiguration);
    }
}

 pavel > work > w > tests > ignite-work $ ls -la --recursive
.:
total 16
drwxrwxr-x  4 pavel pavel 4096 Oct 22 10:39 .
drwxrwxr-x 73 pavel pavel 4096 Oct 22 10:39 ..
drwxrwxr-x  4 pavel pavel 4096 Oct 22 10:39 db
drwxrwxr-x  2 pavel pavel 4096 Oct 22 10:39 diagnostic

./db:
total 16
drwxrwxr-x 4 pavel pavel 4096 Oct 22 10:39 .
drwxrwxr-x 4 pavel pavel 4096 Oct 22 10:39 ..
drwxrwxr-x 2 pavel pavel 4096 Oct 22 10:39 0_0_0_0_0_0_0_1_lo_127_0_0_1_172_17_0_1_192_168_13_151_47500
drwxrwxr-x 2 pavel pavel 4096 Oct 22 10:39 marshaller

./db/0_0_0_0_0_0_0_1_lo_127_0_0_1_172_17_0_1_192_168_13_151_47500:
total 8
drwxrwxr-x 2 pavel pavel 4096 Oct 22 10:39 .
drwxrwxr-x 4 pavel pavel 4096 Oct 22 10:39 ..

./db/marshaller:
total 8
drwxrwxr-x 2 pavel pavel 4096 Oct 22 10:39 .
drwxrwxr-x 4 pavel pavel 4096 Oct 22 10:39 ..

./diagnostic:
total 8
drwxrwxr-x 2 pavel pavel 4096 Oct 22 10:39 .
drwxrwxr-x 4 pavel pavel 4096 Oct 22 10:39 ..

It works as expected for me with Ignite 2.16:
package org.example;

import org.apache.ignite.Ignition;
import org.apache.ignite.configuration.IgniteConfiguration;

public class Main {
    public static void main(String[] args) {
        IgniteConfiguration igniteConfiguration = new IgniteConfiguration();
        igniteConfiguration.setWorkDirectory(System.getProperty("user.home") + "/w/tests/ignite-work");

        Ignition.start(igniteConfiguration);
    }
}

 pavel > work > w > tests > ignite-work $ ls -la --recursive
.:
total 16
drwxrwxr-x  4 pavel pavel 4096 Oct 22 10:39 .
drwxrwxr-x 73 pavel pavel 4096 Oct 22 10:39 ..
drwxrwxr-x  4 pavel pavel 4096 Oct 22 10:39 db
drwxrwxr-x  2 pavel pavel 4096 Oct 22 10:39 diagnostic

./db:
total 16
drwxrwxr-x 4 pavel pavel 4096 Oct 22 10:39 .
drwxrwxr-x 4 pavel pavel 4096 Oct 22 10:39 ..
drwxrwxr-x 2 pavel pavel 4096 Oct 22 10:39 0_0_0_0_0_0_0_1_lo_127_0_0_1_172_17_0_1_192_168_13_151_47500
drwxrwxr-x 2 pavel pavel 4096 Oct 22 10:39 marshaller

./db/0_0_0_0_0_0_0_1_lo_127_0_0_1_172_17_0_1_192_168_13_151_47500:
total 8
drwxrwxr-x 2 pavel pavel 4096 Oct 22 10:39 .
drwxrwxr-x 4 pavel pavel 4096 Oct 22 10:39 ..

./db/marshaller:
total 8
drwxrwxr-x 2 pavel pavel 4096 Oct 22 10:39 .
drwxrwxr-x 4 pavel pavel 4096 Oct 22 10:39 ..

./diagnostic:
total 8
drwxrwxr-x 2 pavel pavel 4096 Oct 22 10:39 .
drwxrwxr-x 4 pavel pavel 4096 Oct 22 10:39 ..

I am also using version 2.16, JDK 21, and a cluster deployment method with a total of 3 nodes. The data mainly consists of some external data sources and some in memory data sources. No problem found

The diagnostic directory I specified is empty, but there are data files in the ignote directory of the startup directory


iOS: Ask for add photos to library privacy.

Add NSPhotoLibraryAddUsageDescription key and
value to Info.plist. Now when user try's to download
photo from lightbox, dialog is popped to take permission.
This preference is considered while downloading next time.
When permssion is not allowed, CameraRoll throws error
which is then caught and can't download toast message is shown.
This fixes: app becomes unrespossive on selecting download
option in lightbox actionsheet when permission is not given.
Fix: #2216
https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html

Great find! I thought we've added this permission.
That explains a lot :)