[bug] non-main modules sometimes do not update

I've been using the ide a lot today, and there is one bug 🐛  I can't figure out.
my Main module import an Input module.
When I write something wrong on my Input module and save the file, no error is shown.

🔴  no error shown
When I go back to my Main module and hit save, suddenly, the bottom toolbar tells me an error is detected:

and indeed, when I go back to my Input  module, I see the error:

(I'm not 100% sure, but it may have been working a few hours ago. As of now, the bug is present, and restarting the ide server doesn't solve it)

same the other way around: when I fix the error in Input.purs, I need to go to back to Main.purs and save Main for the fix to be detected.
📝  In the same time, the pscid works instantly. I don't need to switch back to Main module for pscid to see the Input module now contains an error

@nwolverson this problem appears to be related to https://github.com/nwolverson/atom-ide-purescript/issues/95
indeed, the file that triggers typechecking upon save has tooltips, but the other hasn't.
How can I help you on this one ?

Hmm...... after https://github.com/nwolverson/atom-ide-purescript/issues/102#issuecomment-232434994, I enabled fast rebuild, quitted Atom (Cmd-Q), restarted it, and now, it seems to be working fine, and both modules correctly typecheck upon save ! ❤

⚠  (It may just be a coincidence, since I also rebooted my laptop)

Seems like you hit some odd case with something in the particular file. If you can reproduce again reliably it might be interesting to see if you were able to share the project.
You're on psc 0.9.2 I think?  What you wrote above seems to indicate an issue writing externs with the full compilation but not psc-ide.

if I can reproduce it reproductibly, I'll make a proper report and share a test project, sure !
I'm on psc 0.9.2, yes, on mac el capitan, using atom 1.9.0-beta0
In both my Main and Input module, I was doing some FFI.
It could also be a data race since I have in the same time running

pulp --watch build --to test.js
`pscid``
a psc-ide-server

If you can reproduce the effect - even if it just happens rather than understanding the precise steps - the thing to look at would be output/Module.Name/externs.json - is it valid JSON (or corrupted on writing somehow) and if you take a copy does it match what you get normally (when things work).

I just tried one last time without fast-rebuild not to miss a good occasion to see if I had a reproductible test case, but the bug seems to be gone for now even without fast-rebuild. I guess "restarting my laptop" fixed it for now. I'll report any more findings if I encounter the bug.

got it, I'll pay attention to those things from now on

Got the bug again without falst-rebuild:
the non reloading module is Debug.purs:
Debug.purs:
module Debug where

import Prelude
import Control.Monad.Eff (Eff)
import DOM (DOM)

foreign import p :: forall a eff. a -> Eff (dom :: DOM | eff) Unit

ss
plop
sss
s

Debug.js
`js``
"use strict";
exports.p = function(a){return function(){console.log(a)}};

when I save Debug.purs, the `pulp --watch build --to test.js` process says:

```bash
* Source tree changed; restarting:
* Building project in /Users/rvion/dev/psc-b
Error found:
at /Users/rvion/dev/psc-b/src/Debug.purs line 12, column 1 - line 12, column 1

  Unable to parse module:
  unexpected end of input
  expecting binder or indentation

See https://github.com/purescript/purescript/wiki/Error-Code-ErrorParsingModule for more information,
or to contribute content related to this error.

* ERROR: Subcommand terminated with exit code 1

and output/Debug/externs.json contains:
{"efVersion":"0.9.2","efModuleName":["Debug"],"efExports":[{"ValueRef":{"Ident":"p"}}],"efImports":[{"eiModule":["Prim"],"eiImportType":{"Implicit":[]},"eiImportedAs":null},{"eiModule":["Prelude"],"eiImportType":{"Implicit":[]},"eiImportedAs":null},{"eiModule":["Control","Monad","Eff"],"eiImportType":{"Explicit":[{"PositionedDeclarationRef":[{"start":[4,27],"name":"/Users/rvion/dev/psc-b/src/Debug.purs","end":[4,30]},[],{"TypeRef":["Eff",[]]}]}]},"eiImportedAs":null},{"eiModule":["DOM"],"eiImportType":{"Explicit":[{"PositionedDeclarationRef":[{"start":[5,13],"name":"/Users/rvion/dev/psc-b/src/Debug.purs","end":[5,16]},[],{"TypeRef":["DOM",[]]}]}]},"eiImportedAs":null}],"efFixities":[],"efTypeFixities":[],"efDeclarations":[{"EDValue":{"edValueName":{"Ident":"p"},"edValueType":{"tag":"ForAll","contents":["eff",{"tag":"ForAll","contents":["a",{"tag":"TypeApp","contents":[{"tag":"TypeApp","contents":[{"tag":"TypeConstructor","contents":[["Prim"],"Function"]},{"tag":"TypeVar","contents":"a"}]},{"tag":"TypeApp","contents":[{"tag":"TypeApp","contents":[{"tag":"TypeConstructor","contents":[["Control","Monad","Eff"],"Eff"]},{"tag":"RCons","contents":["dom",{"tag":"TypeConstructor","contents":[["DOM"],"DOM"]},{"tag":"TypeVar","contents":"eff"}]}]},{"tag":"TypeConstructor","contents":[["Data","Unit"],"Unit"]}]}]},null]},null]}}}]}

formated, it gives :
{
  "efVersion": "0.9.2",
  "efModuleName": [
    "Debug"
  ],
  "efExports": [
    {
      "ValueRef": {
        "Ident": "p"
      }
    }
  ],
  "efImports": [
    {
      "eiModule": [
        "Prim"
      ],
      "eiImportType": {
        "Implicit": []
      },
      "eiImportedAs": null
    },
    {
      "eiModule": [
        "Prelude"
      ],
      "eiImportType": {
        "Implicit": []
      },
      "eiImportedAs": null
    },
    {
      "eiModule": [
        "Control",
        "Monad",
        "Eff"
      ],
      "eiImportType": {
        "Explicit": [
          {
            "PositionedDeclarationRef": [
              {
                "start": [
                  4,
                  27
                ],
                "name": "/Users/rvion/dev/psc-b/src/Debug.purs",
                "end": [
                  4,
                  30
                ]
              },
              [],
              {
                "TypeRef": [
                  "Eff",
                  []
                ]
              }
            ]
          }
        ]
      },
      "eiImportedAs": null
    },
    {
      "eiModule": [
        "DOM"
      ],
      "eiImportType": {
        "Explicit": [
          {
            "PositionedDeclarationRef": [
              {
                "start": [
                  5,
                  13
                ],
                "name": "/Users/rvion/dev/psc-b/src/Debug.purs",
                "end": [
                  5,
                  16
                ]
              },
              [],
              {
                "TypeRef": [
                  "DOM",
                  []
                ]
              }
            ]
          }
        ]
      },
      "eiImportedAs": null
    }
  ],
  "efFixities": [],
  "efTypeFixities": [],
  "efDeclarations": [
    {
      "EDValue": {
        "edValueName": {
          "Ident": "p"
        },
        "edValueType": {
          "tag": "ForAll",
          "contents": [
            "eff",
            {
              "tag": "ForAll",
              "contents": [
                "a",
                {
                  "tag": "TypeApp",
                  "contents": [
                    {
                      "tag": "TypeApp",
                      "contents": [
                        {
                          "tag": "TypeConstructor",
                          "contents": [
                            [
                              "Prim"
                            ],
                            "Function"
                          ]
                        },
                        {
                          "tag": "TypeVar",
                          "contents": "a"
                        }
                      ]
                    },
                    {
                      "tag": "TypeApp",
                      "contents": [
                        {
                          "tag": "TypeApp",
                          "contents": [
                            {
                              "tag": "TypeConstructor",
                              "contents": [
                                [
                                  "Control",
                                  "Monad",
                                  "Eff"
                                ],
                                "Eff"
                              ]
                            },
                            {
                              "tag": "RCons",
                              "contents": [
                                "dom",
                                {
                                  "tag": "TypeConstructor",
                                  "contents": [
                                    [
                                      "DOM"
                                    ],
                                    "DOM"
                                  ]
                                },
                                {
                                  "tag": "TypeVar",
                                  "contents": "eff"
                                }
                              ]
                            }
                          ]
                        },
                        {
                          "tag": "TypeConstructor",
                          "contents": [
                            [
                              "Data",
                              "Unit"
                            ],
                            "Unit"
                          ]
                        }
                      ]
                    }
                  ]
                },
                null
              ]
            },
            null
          ]
        }
      }
    }
  ]
}

🔴  @nwolverson Ok, so I have been able to "reproduce" the problem with fast-rebuild too, and the buggy module doesn't even use FFI
Here is the steps I just did to go from "working sate" to "buggy state":

I had a project compiling
I decided to move some types and data decl from module A in a new module B
I copied the types dans data decls, put them in a new file, added "module B where" at the top, and saved the file as src/B.purs
I added "import B" in module A
5: 🔶  first anomaly: instead of having erros related to missing imports in B.purs, I only got erros about A not being able to import B, as if B didn't exist.
6: I fixed import problems, following pscid output instead of relying on atom
7: after B is fixed, on atom, module A accept to import B, and the projects appears green
8: 🔴  BUT.. B doesn't typecheck anymore, and when I write buggy stuff in B, it doens't do anything until I hit save in A or in an other module importing B.

and if I quit completely Atom (cmd-Q) and restart it, the problem is temporarily fixed

A cannot know about B until it compiled successfully at least once. We need the externs files loaded inside the server.
I have a feeling that multiple servers writing and watching the same output/ folder might create trouble.
Can you recreate the issue without pscid running?

@kRITZCREEK @nwolverson  ok, so I can now replicate the bug all the time.

case 1:

🚫  nopscid
🚫  no pulp --watch build --to test.js
✔  atom

as mentioned above, just create a new file Eee.purs containing something like

module Eee where

ok :: Int
ok = 3

try to import it from an existing module currently working in atom

🔴  -> it doesn't work. the newly created module is never loaded
restarting the ide-server doesn't work. The only way for ide-atom to be aware of the newly created Eee.purs is to restart Atom completely

case 2:

✔  pscid
✔  pulp --watch build --to test.js
✔  just atom

1.idem: create a new file Eee.purs containing
module Eee where

ok :: Int
ok = 3

try to import it from an existing module currently working in atom

it fails for the first few seconds, until pulp --watch build --to test.js write stuff in output folder, creating a mixed state. Then, atom still does nothing when Eee.purs is saved, but when on an other module working fine and importing Eee, it correclty sees Eee, and will report errors coming from it (it there is).
Again, restarting the ide-server doesn't do anything, and the only way to get Atom fully aware of the newly created Eee.purs is to restart Atom completely

case 3:
🔴  when I delete a file (let's say C.purs), It still appears in the autocompletion list from other modules

after one more day of purescript hacking, I can confirm the reproductibility, both with and without fast-loading. (atom + atom-ide-purescript) have a problem with newly created modules, but restarting atom completely solves it until next module addition

Case 3 is #105. For the others will try to reproduce, sounds like new files aren't being watched properly.

Case 1 seems to work fine for me, maybe I'm missing something.

In Atom, create Eee.purs
Paste in module content above
Save
Switch to Main.purs

At this point I can trigger completion from Eee (typing ok in Main.purs), or add and use an import, and build successfully (by saving Main.purs).

@nwolverson forgot to add the last step showing the bug x)
now, go in Eee, and write something silly, like
module Eee where

ok :: Int
ok = 3

d

I have the same problem. Ide doesn't see changes in other modules after fast rebuild. For example if I have modules A and B and module A imports module B, then if I add a function in module B or write something that causes an error, module A doesn't see it. And it happens not from time to time, but all the time. The only workaround is to reopen atom.
There is another bug that I found - Ide starts only when you open a file. If you start atom with previous session, then nothing happens.

@rvion Just tried this again and still can't reproduce (your new file/Eee issue). Is this still an issue for you? Possibly some recent changes make something work slightly differently.
@starper Not sure if I follow. For sure if I save file B (and it successfully builds) then the changes are reflected in A. If B fails to build, then the previous successful build will be the "last status" until you go fix it (as rebuild operates on a single-file basis). Can you provide some detailed steps to reproduce?

Sorry about that "write something that causes an error" thing, I haven't use purescript for month and a half and for some reason I thought that module A could see if imported module B has an error before. My bad. But anyway, there are still two issues left.
Here are my steps (I'll perform a step, then write it down, then perform the next one and so on):

Open atom
Create new file A.purs (file is opened in a new tab, ide is started, empty output folder is created, .psc-ide-port file is created)
Write this lines in my A.purs file

module A where

import Prelude

Save it (now I have an error as expected, because project is not built yet)
Build a project with ctrl-o b (using pulp)
Error is gone
Create a B.purs file with this lines

module B where

import Prelude
import Control.Monad.Eff (Eff)

bar :: forall e. Eff e Unit
bar = pure unit

Save it
Go to module A and edit it

module A where

import Prelude
import B (bar)
import Control.Monad.Eff (Eff)

foo :: forall e. Eff e Unit
foo = bar

Save it
Go to module B and remove this lines

bar :: forall e.   Eff e Unit
foo = baz

Save it (now I have a Cannot import value baz from module B error)
Build it with ctrl-o b (error is gone, no issues now)
Save it again (Cannot import value baz from module B error is back)
Close atom (.psc-ide-port file is removed)
Open it again (it opens with previous sassion, tabs with files A.purs and B.purs are open, ide is not working)
Open some other .purs file (now I can see the message that ide is working)
Go back to module A and save it (no issues now)
Close atom (.psc-ide-port is not removed)
Open atom again (same as before ide is not started)
Open some .purs file (now message says that server is started on two different ports and there are two instances of it running)

So I end up with those two issues that I described before - module A does not see changes in module B and ide does not work until you open some .purs file. Plus an issue with two instances of server running at the same time. I hope it'll help.
BTW I use windows 10, atom 1.9.4, purescript 0.9.3 and atom-ide-purescript 0.14.6

Thanks for the detailed steps!
I'm trying to follow this, at the step

Go to module A and save it (nothing happens it builds with no issues)

I do not see that this is the case. I get the correct complaint about bar in
import B (bar)

If this built it would be wrong (can you maybe edit the above post to highlight parts that you believe to be in error?) So everything up until closing atom for the 1st time, works as expected for me. (I'll continue to investigate as I have different versions)
I can reproduce nothing starting when you restart the session, opened #120 (but think this is an Atom regression).
When you say "open some other .purs file" - is that a file within the same project or elsewhere? A separate psc-ide-server will be started if it is in another project

.purs file is in the same project, like Main for example. Post is updated.

@nwolverson It is still happening but I need to check if I correctly updated the plugin.
my issue is the same as @starper.
I found workarounds, so I cal live with it for now :)

@starper still can't see anything like the 1st issue, where A.purs builds when it should not. I started with a fresh project created from pulp init, same versions you listed, and followed your steps, this is what I see:

I did notice there is a race condition #121 on starting the package after re-opening the window. I'll ask you to re-test when that is fixed

I'll retest too, since what you show above doesn't work for me

@nwolverson what tool do you use to screen capture ?

That's LICEcap
(I bet there's one difference that nobody thought to notice that's causing the discrepancy but hard to track down the variables...)

Ok, so I was wrong saying that it happens all the time, it's not. Sometimes it works. I tried to find some kind of pattern, because it feels like it happens quite random, but all I can see for now is that it works at first, but then at some point it stops. So you have to mess around with it a little, adding, changing and removing functions until this bug appears.
This time I was "lucky" and it failed at the very beginning...

Thanks for the link :)
I noticed that I don't create files the same way you do. I create new files with ctrl-n, followed by ctrl-s, matbe it doesn't trigger events the exact same way? (Cant't test atm, not at home)

What I've noticed is that ide sees changes in js files. For example if you have
foreign import fooImpl :: Eff e Unit

but have no fooImpl in js file, there will be an error, but when you add fooImpl, then error is gone. Maybe it'll be helpful :)

Maybe something like restart on save option can make it work? (as a temporary workaround)

@starper to what end? You should be able to achieve this effect in your init script if that's something you find useful

So that people who have this issue do not have to restart editor everytime this bug appears. What init script?

I think if you have to restart your editor repeatedly like that, something is badly wrong, and it would be better to track it down. I never was able to reproduce this, so it won't be fixed otherwise.
So this still happens. Does the "restart psc-ide-server" command work for you?
Init script is your atom init script, you could for example listen to file saves and run a command.

It seems that it is psc-ide-server issue, so restarting it should work, but I can't find any command to do it, so I just restart editor. I guess restart on save option is overkill for this issue, but some keybinding for restarting server would be great.
I just use Atom as editor, I never looked inside of it, so I have very little understanding about what's going on in there.

There is a command "Ide Purescript: Restart Psc Ide"  you can find in the command palette, the PureScript package submenu. The actual command is ide-purescript:restart-psc-ide which can also be bound to a key (check your key bindings - ~/.atom/keymap.cson)

It works, thanks.

With the latest purescript-v0.10.3 release everything is back to normal for me. I tried my best to reproduce this error, but everything works just fine now. If @rvion has no errors too, then I guess we can close this issue.

@starper are you on windows by chance? in 0.10.3 the server now uses a polling mechanism as the default on windows.

@kRITZCREEK yes, I'm on windows 10.


Issue #33 - Support for a RemoveCachePolicyTagBeforeExecution Setting

Added a new EFCoreSecondLevelCacheSettings.RemoveCachePolicyTagBeforeExecution property and options extension method.
Updated DbCommandInterceptorProccessor.cs to check the new setting property. When the setting property is true the cache policy comment is removed from the command.CommandText before proceeding to execution. A ConditionalWeakTable is used to retrieve the parsed cache policy after command execution.
Added test cases to confirm the cache is still used and the expected sql without the comment is executed when the setting is configured to true.

@VahidN Why close this PR?
I made it configurable so you could keep the comments in by default and ppl who wanted the query plan cache performance improvements could opt-in via an options method

I will remove the whole method names and lines in comments later. This PR is not necessary.


Bug: style rules end up on the wrong selectors after a URL with a close-paren in it

I found that styles go missing or apply to the wrong elements if they come after a URL string which has a close-paren character in it.
My actual use case was an inline SVG in a data URI, with a colour expressed in rgb(...) format. I found the next selectors getting appended to the previous selector, which led to styles not applying or applying to the wrong selectors.
I gradually boiled it down to a small case, which I've put in Code Sandbox.
Environment
Reproducible on Code Sandbox with styled-components 5.2.1.
Reproduction
https://codesandbox.io/s/styled-components-bug-styles-go-missing-after-a-close-paren-in-a-url-string-406j1
Steps to reproduce
Run the above sandbox.
Expected Behavior
Text is red.
Actual Behavior
Text is not red.

This is likely an issue with how stylis perceives your input there. Generally, you can try to base64 encode with url('...') values for instance, but otherwise there isn't much we can do to resolve this. I believe the upgrade to stylis@4 may fix this though once it's dropped into styled-components.
For now, I'll go ahead and close this, since there's not much we can do to fix this on our end. But rest assured, you're not doing anything wrong, it's likely stylis that in v3 can't parse this.

Thanks. Yeah, I've now confirmed that it was a Stylis 3.x problem and was fixed from 4.0.0 onwards. Is there a roadmap to upgrading the dep within styled-components?

@tremby It's already been upgraded on main afaik, which is posed to become v6, (ref: #3333). So, it's only a matter of time so far.

OK, thanks.


Augur State Testing: Crash Recovery

[ ]  Process restarts after crashing in the middle of syncing
[ ]  Process restarts after crashing in the middle of adding new block from blockstream
[ ]  Process restarts after crashing in the middle of a rollback

@robert-e-davidson3 -- I'm removing this from the larger epic so I can close it.
Do you still wanna build crash recovery tests?

I'm fine with this being closed. They'd be good tests but we won't get to
them
On Mon, Jul 29, 2019, 23:04 Paul Gebheim<EMAIL_ADDRESS>wrote:

@robert-e-davidson3 https://github.com/robert-e-davidson3 -- I'm
removing this from the larger epic so I can close it.
Do you still wanna build crash recovery tests?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AugurProject/augur/issues/1108?email_source=notifications&email_token=AK6RBU67C3PYDYY4AESX55DQB7KV7A5CNFSM4GZDPYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3C4ADA#issuecomment-516276236,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK6RBU7BTPTS6V573T2IJ4LQB7KV7ANCNFSM4GZDPYAQ
.

Closing, perhaps this will be done at a later date!


Update to git repo not being reflected in latest build

Details
If this issue is for a specific project or build, include the following:

Project: https://readthedocs.org/projects/firefox-puppeteer/

Build #: 3887613

There are (many) newer commits on master on https://github.com/mozilla/gecko-dev.git. However, this build always pulls revision b5709cdb58616cd9b39cd0555ca7182949f95785, which is from March 23.
I have tried wiping the builds, and it is not helping. Any ideas as to how to fix this are welcome.

Did you try to "wipe" the version on RTD (see "Versions" tab) and then re-build?

Chiming in to say that I had the same problem on https://securedrop-support.readthedocs.org/en/latest, and "wiping" the "latest" version on RTD, then re-building, resolved the issue for me.

I've been having a similar problem (docs not being updated on push), but on readthedocs.com, where this is no Wipe option. I'm thinking that Wiping might help my problem as well. Is that a forthcoming feature?

I tried wiping multiple times. Another admin was able to get it build eventually.

@sydvicious I saw that latest builds for your project are working properly. Is the issue fixed? Can we close it? It's the same for @garrettr project.

I no longer work with that project. Feel free to close this issue.
Sent from my iPhone

On Apr 18, 2017, at 20:38, Manuel Kaufmann<EMAIL_ADDRESS>wrote:
@sydvicious I saw that latest builds for your project are working properly. Is the issue fixed? Can we close it? It's the same for @garrettr project.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Delete past scheduled operations

If an operation execution time is in the past, it should be deleted. Brainstorm where this should happen and make issue(s) to implement.

[x] On publishing DB contents, if operation is in past update its friendly name (baby step)
[x] Instead, delete it

Not the best code, but it works


Cache database files (leveldb)

I see in activity.py that the Local Storage database is simply opened and parsed manually.
I would just like to point out that these databases can be opened with the plyvel python library, which makes getting out specific information out of them a little easier, here's a quick example to just print all of the key-value pairs:
import plyvel
import pathlib
directory = pathlib.Path("path/to/Local Storage/leveldb")
db = plyvel.DB(str(directory), create_if_missing=False)

for k, v in db:
    kd = k.decode('utf8', errors='ignore')
    vd = v.decode('utf8', errors='ignore')
    print('%s: %s' % (kd, vd))

db.close()

There's a lot more useful information in there.

While we're on packages, I see brotli is imported in common.py, but never it's used?

Thanks for pointing out that library. I didn't know about its existence when I was writing this code. This was my first Python project and it was written using only standard library. You can see the original one if you select tag v1.0. I think I added brotli a couple months ago when I was adding some error checking but did not used it.
Feel free to use my implementation as a baseline but you can certainly make a more efficient one by using other libraries like numpy, numba etc. If you can get even more data out of it that's even better.
I don't have plans to update it at the moment and I think if anything it should be written from scratch as this manual method is very inefficient.
Looking forward to see your solution!

I see, I was hoping you would maintain this as I have little time myself..
If I find the time I might at least rewrite it from scratch, but I've read elsewhere that Discord does change the cache format every now and then - and that would add a need for maintenance.
Either way, thanks for replying!

I might do that at some point but I can't promise anything. Yes you are right, there were previous solutions like FireKitty which is older than mine and targeted completely different storing method that they used. When I will have some time I will have a look at plyvel library. It might save a lot of time when writing a new code.


[sparse]: add tracer-based implementation of sparsify

Co-authored by: @mattjj
Eventually I think we'll choose one implementation to stick with; for now we'll keep both in parallel.

I spent a half hour trying to do the popattr and setnewattr solution, and ran into two issues:

because Tracer delegates getattr() to aval, and SparseTracer needs to reference spenv to compute its aval, doing this directly leads to infinite recursion errors.
Even controlling for that (by gating things on hasattr) the code errors if main.spenv is removed in the places you indicated, I think because of this aval issue.

Perhaps the issue lies in the fact that we're computing avals lazily, and we should instead compute them eagerly when SparseTracer is created?

No, even that doesn't work... we still end up trying to access main.spenv during instantiation of SparseTracer at moments when it is not defined.

OK, I think I managed to do roughly what you had in mind. PTAL!


Extra lines in drawcoastlines in ortho projection

These extra lines pop up at various places. I haven't (in 2 min of looking) found a pattern to their appearance yet

Can you provide code to reproduce this?

https://gist.github.com/jradavenport/778260a1f0553575be99
Note of course this happens even w/o the underlying density map data

Which version of matplotlib? This seems like a polygon closing issue.
On Sun, Feb 22, 2015 at 4:10 PM, James Davenport<EMAIL_ADDRESS>wrote:

https://gist.github.com/jradavenport/778260a1f0553575be99
Note of course this happens even w/o the underlying density map data
—
Reply to this email directly or view it on GitHub
https://github.com/matplotlib/basemap/issues/180#issuecomment-75458119.

version 1.4.0
Also have seen this kind of artifact here

Have update to 1.4.3, and was on latest of basemap already.
Also can confirm issue occurs for high resolution

I can't reproduce this using the latest matplotlib and basemap on master. I don't know what fixed this, but it seems to be fixed. Closing.


[GitHub Actions] Output from called reusable workflows via env context or GITHUB_ENV is not supported

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
Reusable Workflows
https://docs.github.com/en/actions/using-workflows/reusing-workflows
Reusable Workflows: Limitations
https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations
Reusable Workflows: Using outputs from a reusable workflow
https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-outputs-from-a-reusable-workflow
What part(s) of the article would you like to see updated?
According to the Limitations:

Any environment variables set in an env context defined at the workflow level in the caller workflow are not propagated to the called workflow.

The opposite is also not supported but it's not listed under the Limitations section.
Using outputs from a reusable workflow also does not mention anything about env context or GITHUB_ENV as it's mainly focused on the output parameters.
Adding this (i.e. env context or GITHUB_ENV cannot be used to set env vars for output purposes) under the Limitations section would be helpful.
Thanks!
Additional information
No response

@iamazeem Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

@iamazeem - Thanks for raising this. Would the following fix this issue?
In Limitations, after the existing bullet point "Any environment variables set in an env context defined at the workflow level in the caller workflow are not propagated to the called workflow." add:

Similarly, environment variables set in the env context defined in the called workflow are not accessible in the env context in the caller workflow. Instead you must use outputs of the reusable workflow. For more information, see "[AUTOTITLE](/actions/using-workflows/reusing-workflows#using-outputs-from-a-reusable-workflow)."

Then at the end of the list of limitations, add:

Reusable workflows are called directly within a job, and not from within a job step. You cannot, therefore, use GITHUB_ENV to pass values to job steps in the caller workflow.

@hubwriter: LGTM. :+1:  That would definitely help.

@iamazeem - Thanks for confirming.
Feel free for yourself (or anyone else) to open a PR to make this change.  🙇♂
If you haven't contributed to the docs before, please take a look at our contributing guidelines.

@hubwriter: PR #25700 created.


Can this extension implement polygons and polylines on Google Map?

Also how to add an api key? Thank you!

Thanks! I'm really appreciated. Currently I'm using your extension under vue-echarts environment. I loaded the map correctly but it failed to display scatter chart on the map using your demo code. Also when I add another tooltip component,  the map is just crashed which I don't know why. This is my Map.vue.
`

`

Could I know if you are assigning the ECharts instance object with Vue ref? If so, I'd like to suggest using a normal variable without any wrapper.
let chart;
chart = echarts.init(document.getElementById('chart-container'));

No I didn't use ref. It's just . All components and series can be set in option.

I tried the example from vue-echarts, it works.
<template>
  <v-chart class="chart" :option="option" />
</template>

<script>
import { use } from "echarts/core";
import { CanvasRenderer } from "echarts/renderers";
import { ScatterChart } from "echarts/charts";
import {
  TitleComponent,
  TooltipComponent
} from "echarts/components";
// import google map extension
import "echarts-extension-gmap";
import VChart from "vue-echarts";
import { ref, defineComponent, onMounted } from "vue";

use([
  CanvasRenderer,
  ScatterChart,
  TitleComponent,
  TooltipComponent
]);

function isGoogleMapAPILoaded() {
    return typeof google !== 'undefined' && typeof google.maps !== 'undefined'
}

function loadGoogleMapScript() {
    const mapScriptURL = 'https://maps.googleapis.com/maps/api/js?key=you key';
    return new Promise((resolve, reject) => {
      // if google map API script has loaded, no need to insert it again
      if (isGoogleMapAPILoaded()) {
        resolve()
      } else {
        const scriptNode = document.createElement('script')
        scriptNode.setAttribute('type', 'text/javascript')
        scriptNode.setAttribute('charset', 'utf-8')
        scriptNode.setAttribute('src', mapScriptURL)
        scriptNode.setAttribute('id', 'google-map-api-script')
        scriptNode.onload = () => {
          if (isGoogleMapAPILoaded()) {
            resolve()
          } else {
            reject('failed to load google map API script')
          }
        }
        scriptNode.onerror = e => {
          reject(e)
        }
        // check again before inserting script
        if (isGoogleMapAPILoaded()) {
          resolve()
        } else {
          document.head.appendChild(scriptNode)
        }
      }
    })
}

export default defineComponent({
  name: "HelloWorld",
  components: {
    VChart
  },
  setup: () => {
    const option = ref();

    onMounted(async () => {
      // load api
      await loadGoogleMapScript()

      option.value = {
        title: {
          text: "Traffic Sources",
          left: "center"
        },
        tooltip: {
          trigger: "item"
        },
        legend: {
          orient: "vertical",
          left: "left",
          data: ["Direct", "Email", "Ad Networks", "Video Ads", "Search Engines"]
        },
        gmap: {
          center: [108.39, 39.9],
          zoom: 4
        },
        series: [
          {
            name: "Scatter",
            type: "scatter",
            coordinateSystem: "gmap",
            data: [
              [120, 30, 50]
            ],
            encode: {
              value: 2
            }
          }
        ]
      }
    })

    return { option };
  }
});
</script>

<style scoped>
.chart {
  height: 100vh;
}
</style>

<style>
body {
  margin: 0;
}
</style>

Actually I use Vue2 and just tag script in index.html to get permission like this:
<script async             src="https://maps.googleapis.com/maps/api/js?key=..."> </script>
Also I think I didn't define the async vue component like you do.
Is that the potential reason?

I think I found where is wrong. Map needs to be specified height, that is:
<v-chart class="chart" :option="option" />
<style scoped> .chart {   height: 100vh; } </style>
Otherwise scatter or other overlays won't be displayed.

That's great. Glad to see your problem solved.


Huggingface NLP, Uploading custom dataset

Hello,
Does anyone know how we can call our custom dataset using the nlp.load command? Let's say that I have a dataset based on the same format as that of squad-v1.1, how am I supposed to load it using huggingface nlp.
Thank you!

What do you mean 'custom' ? You may want to elaborate on it when ask a question.
Anyway, there are two things you may interested
nlp.Dataset.from_file and load_dataset(..., cache_dir=)

To load a dataset you need to have a script that defines the format of the examples, the splits and the way to generate examples. As your dataset has the same format of squad, you can just copy the squad script (see the datasets forlder) and just replace the url to load the data to your local or remote path.

Also if you want to upload your script, you should be able to use the nlp-cli.
Unfortunately the upload feature was not shipped in the latest version 0.2.0. so right now you can either clone the repo to use it or wait for the next release. We will add some docs to explain how to upload datasets.

Since the latest release 0.2.1 you can use
nlp-cli upload_dataset <path/to/dataset>

where <path/to/dataset> is a path to a folder containing your script (ex: squad.py).
This will upload the script under your namespace on our S3.
Optionally the folder can also contain dataset_infos.json generated using
nlp-cli test <path/to/dataset> --all_configs --save_infos

Then you should be able to do
nlp.load_dataset("my_namespace/dataset_name")


Duplicate locations

Context
We're noticing samples from the same place?

Description
Add to the gisaid_geoLocationRules.tsv
Sorry to not open a PR. I don't have a system set up to test the change easily TnT
Thank you very much!

Hi @danrlu ! Thanks for flagging this. We actually aren't doing as much curation beyond 'division' level (here that would be 'Magdalena' as we used to, simply because of the effort it takes to sort out smaller locations & the lack of time. However, this was a pretty easy one so I've added it in a PR #333  here, which hopefully should be merged soon!

Thanks very much Emma! This totally makes sense. We may continue to notice these (on the location level) in the future given the nature of our product. Would you guys want to have those future corrections integrated to this repo, or we should just keep a local copy of the location rules?

If you are able @danrlu, then making a PR would be really valuable to us! If you check out what I did in mine you can do something similar - edit the file so that it corrects the location (it's worth searching first to ensure that the location isn't in there already and gets a more complex name - as was the case here with us calling it Santa Marta (Magdalena) (since there are more than one)).
Then we can review, and merge in, and hopefully even more people can benefit! Even though it's not something we can dedicate time to doing directly anymore, we'd of course be happy to keep things updated for everyone if others like yourself are finding these!

Sounds good and will do!! Thanks very much!


Introduce a builder for Codegen

Issue: #3995
Description
I have implemented a builder for the Codegen following the example described in #3995. I also replaced existing calls to Codegen::run and Codegen::run_with_config with the builder.
I removed Codegen::run as it is never called and I am unsure if it even makes sense to keep run_with_config separate from the builder. What do you think?
There are conversions from &[&str] to Vec and back again in the builder which I don't like. However, I think overall it is the simplest implementation in this case as we avoid lifetimes and trait bounds. Apart from just merging run_with_config with the builder.
Upon writing this I realized that I forgot to update the codegen readme. I will update the readme once the implementation is approved (to avoid having to keep updating it).
Let me  know what you think :)
How was this PR tested?
Tested that everything still builds and existing tests pass. I have a few failing tests on my machine even without these changes so those will have to be tested during CI.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I agree with you; let's not worry too much about the conversions back and forth between &[&str] and Vec. You can modify the signature of run_with_config if that simplifies a few things, but don't sweat it.
Thanks for the contribution, @jmintb!


feat: {slot} placeholder for MenuItem

Hello,
this PR adds the feature that you have access to the current slot of the menu item via the {slot} placeholder when building dynamic inventories with filler items.
I added a new parameter to the setPlaceholders Method. The parameter slot is filled with the value of the MenuItemOptions#slot(). In places where it doesn't make sense like opening and closing click handlers, I decided to give -1 as value. This is also the case for ClickAction via the execute command.
So the value -1 means that it Item doesn't have anything todo with a MenuItem directly.
This was commissioned work by makiil.grosnach.

Wow, great job! So far from what I've seen, it works really, really well! I tried doing this a while back, but failed miserably 😂
I just tested it out with my DeluxeShop plugin and it works flawlessly. My entire shop is just 1 item!

At some point, "internal" placeholders were discussed, but nothing came of it. One concern that remains from that conversation is backward compatibility. The concern stems from the fact that the {slot} placeholder could be overriding any already existent argument called {slot}.
I am going to spend some time putting together a POC for internal placeholders to see if we can maybe merge this into that.

At some point, "internal" placeholders were discussed, but nothing came of it. One concern that remains from that conversation is backward compatibility. The concern stems from the fact that the {slot} placeholder could be overriding any already existent argument called {slot}.
I am going to spend some time putting together a POC for internal placeholders to see if we can maybe merge this into that.

The only solution to that would be to a different symbol instead of {}?

The only solution to that would be to use a different symbol instead of {}?

This is what I have in mind. The problem is that there aren't many good ones we can use. I am not a fan of %% which PlaceholderAPI uses because you can't tell when the placeholder is supposed to start or end. Using ${} might create confusion since it is pretty similar to arguments. I think the best one we can choose now is <> but this can be discussed further.
One other mention I have is that we might want to implement a proper "internal" placeholder system instead of just adding more parameters to the parse function whenever we want new placeholders.
We can probably build upon this PR since it seems to work fine but we have to remember, that data is not always available. For example, we can't have the slot number in the menu title since the title is parsed only once. So we would have context-dependent placeholders.

this was a great! i tried it and work as a charm, need it to be in


Basic cleanup of SQL Server provider namespaces

@ajcvickers Is this something you suggest other providers to also do?

@ErikEJ We are currently doing API review of the provider assemblies. This is the first part of that work, but there are also some other changes coming. It would be a good idea to keep your provider updated so that the APIs align, but it is obviously not strictly necessary.

Thanks, I will attempt to align namespaces

:shipit:

@ErikEJ our general rule with providers etc. is that we don't introduce a provider specific sub-namespace. Types keep the same namespace as the type they inherit from core (or the related types in core). We do introduce some sub-namespaces when it makes sense (i.e. we introduce Microsoft.Data.Entity.Migrations in relational, because there is no migrations concept in core).

cc @roji since you may want to apply these same rules in Npgsql

Thanks @rowanmiller, have applied this in Npgsql


import errno

errno.ENOENT is used on line 671

Thank you very much for your contribution! Can you please rework your patch a little to use direct variable import?
from errno import ENOENT
....
if err.errno != ENOENT


Logging to db by IP only now in the machine column of countersamples?

Looks like in TabMon v1.2 is the machine column only going to be by IP or is hostname an option I have just missed somewhere? I have tried a couple of different values for computerName and removing address attribute (which caused the service to fail on start) to get the old format.
I personally preferred displays by hostname and may end up writing a trigger to modify the incoming entries if I've missed a config item.
Thanks,

I also needed to add IP addresses for Tabmon to come up in 1.2.  This is a departure from machinename only in 1.0

Hello,
The Machine column is determined by the the "address" attribute in the host lines. The "address" attribute can be either the IP address or the FQDN. "ComputerName" should be the actual computer name of the host and will not affect what is displayed in the workbook.
We made this change in order to resolve issue #99.
In order to get the old format in the workbook, I suggest changing "address" to the FQDN for the server.
Let me know if that works,
Dan

Thanks, that was it. Had worked by hostname in v1.1 prior. Putting the hostname back into address field, got desired results.


plugin: new katex plugin for math rendering

Hi, thanks for your contribution. A plugin for Katex is a great idea.
I use to store the new plugins to the https://github.com/lumeland/experimental-plugins repository, so they can be imported from there and tested before adding it to the main Lume repo. But in this case, I think it can be merged directly to the main repo.
I want to make some changes before merging but I will do in the comming days.


Find a way to deduplicate scanning

Most terraform repos use the OCI for validation. This validation runs tfsec. The security workflow also does tfsec. Would be nice to get rid of this duplication and preferable automatic.

Wait until security scan is required check (https://github.com/coopnorge/terraform-github-repos/issues/38)


Add build pipeline of app image

AsIs
Currently no CI for automatically build container image, and we need to run pack command in local environment.
This might cause environmental mismatches, so it is required to implement CI to build/push Django image to GHCR.
ToDo
Using GitHub actions, implement CI to run pack CLI.
Also, we need to pass some environmental variables during build process for Django application to boot up properly.
(i.e. SECRET_KEY, MySQL credentials, ...etc)
For SECRET_KEY, the utils might be used for generating random keys.
(Optional) Acceptance criteria
Django image in GHCR would be updated after merging any of PRs into main branch

For using pack with GitHub Actions, buildpacks-actions could be used with ease.
https://github.com/mamezou-tech/buildpacks-action


404 on the popup page

I can launch a lab or notebook and display example.ipynb. The IntSlider and the Button are rendered as expected.
(Note, that I had to comment the import ipypopout.sync_patch statement of the first cell : no module ipypopout.sync_patch could be found)
When I click the button, a new browser window appears, but with a 404 error message. This URL could not been resolved : localhost:8888/voila/templates/ipypopout/static/popout.html?kernelid=65140b14-6a46-4586-a700-d30a5033462e&modelid=3bc5eb88a37a417c8843f4fad63fe923&baseurl=/
I thought I should run voila before -> voila example.ipynb returns a jinja2.exceptions.TemplateNotFound: browser-open.html error :(
Using a lab or a notebook, gives the same result.
Any idea please ?
About my setup :

Python 3.10 virtual environment (venv)
pip install .
then jupyter-lab or jupyter notebook
Below the version for some modules that might be involved :
ipykernel==6.23.2
ipython==8.14.0
ipyvue==1.9.2
ipyvuetify==1.8.10
ipywidgets==8.0.6
Jinja2==3.1.2
jupyter_client==8.2.0
jupyter_core==5.3.1
jupyter_server==2.6.0
jupyterlab==4.0.2
jupyterlab-pygments==0.2.2
jupyterlab-widgets==3.0.7
jupyterlab_server==2.23.0
mistune==2.0.5
nbclassic==1.0.0
nbclient==0.7.4
nbconvert==7.5.0
nbformat==5.9.0
notebook==6.5.4
notebook_shim==0.2.3
Pygments==2.15.1
requests==2.31.0
tornado==6.3.2
traitlets==5.9.0
voila==0.5.0a4
widgetsnbextension==4.0.7

I tried to run it in a new environment, and it works for me, I can not reproduce this issue.
We have seen that ad blockers or other protection plugins in the browser can interfere with the popout, maybe you can check if that's happening in your case.
import ipypopout.sync_patch can indeed be removed. This was needed for ipywidgets<7.7

What is the URL in the browser when you run example.ipynb?

I can reproduce the issue using the exact versions you specified. Will look into it.

It's because of voila==0.5.0a4. Can you try with voila==0.4.0? (this also requires jupyterlab<4)


add wb-matlab-like image filtering

and also an example set of algorithm params is:
            "algorithm_params": {
                "peaks": peaks,
                "labels": labels,
                "window_size": 100,
                # "min_distance": 9,
                "min_filter": 4,
                "manage_collisions": "prune",
                "fb_threshold_margin": 20,
            },

THANK you for getting this submitted! First pass comments above. Will follow up here when I've had a chance to try this on some of our data and have a better idea what kind of output it produces

Results from testing look good! I went ahead and made most of the changes that I requested above. I'll handle the rest (I think just moving some pieces of this into image-processing) a little later on.
I think the only substantial changes I made were:

Median filtering now takes place before median thresholding. This allows us to share the filtering block with the other algorithms in the tmip family, and it seems sensible to denoise before thresholding
Anisotropic scaling happens before peakfinding. I know that you don't love this, but for now, I think it's necessary (as detailed in comment above)
Gaussian and peakfinding params are now configurable

I'm going to go ahead and merge now, because this is useful and I want it in the code base, but please let me know if you have objections to any of these changes and we can discuss.


Display Score explanation visually

Same as PR #305 for Elasticsearch 2.0

@gquintana hey, sorry again for taking so long.
I finally had time to look at this in detail, and there are a few things that I don't like so much:

Perhaps the workflow should be different for visualising the enhanced explain. I see it more as a "visualisation" feature that can be turned on/off for a request that already has the explain flag set to true. This would allow both strategies. On top of this, perhaps if the request doesn't have the explain, pressing the "toggle" button would repeat the request with the new visualisation enabled.

There are a few issues with the code itself, mostly lines too long, usage of double-quotes and etc. This is my fault for not having a proper CONTRIBUTE.MD. Will try to find time and create one. But running grunt build should tell you the things that are wrong.

the new visualisation leaves the "shard" information out, and this is normally useful, since the difference in score might actually come from which shard a query was executed on

the current look and feel still looks a bit rough sometimes, with the index/type being too big in comparison with the rest of the text.

I can either pick up your contributions and apply the changes myself, or you are also more than welcome to do it. Just let me know :)
and thanks again :)

About workflow, there 2 parts in your wish

Modifying the Request URL, I fear it would be too complicated because it would require to parse the URL (can you see something to do it easily?) and modify it (may be introducing errors).  Then you need to detect if the request is a candidate for enabling explanation. At the moment, I only detect whether the URL contains the keyword explain which is pretty easy.
Replacing the "Send & Show Explanation" by a  "Show Explanation" button. It would require to click twice (once on the send button, once on explain). The button could appear as soon as an explanation is found in the response. But the feature would remain hidden most of the time, no clue is given to the user about how to use it.
I also thought about ways to make the response more "lightweight":

using a tab panel component per search hit do switch between source and explanation
using a paging component to display search hit one per page

Code style: sorry, I'll fix that
Shard info: I'll add that at the top with the json-view directive
Look'n'feel: I'll make document Id font smaller. I admit I am not very good at making things look beautiful.

@lmenezes I fixed the last 3 points (code style, shard info, look and feel)

@gquintana thanks :)
Perhaps at some point I give it a go making the explain feature to be more part of the visualisation rather than the request, but this is already pretty useful!


include images for "dark patterns are everywhere" carousel on home page for different industries

this seems to be being built out as we speak, but wanted to flag the images for each of the industries that are not complete just yet.

@stephtngu This is up for review


enable https, borrow some stdlib wrapping classes

Wanted to have the option of this running with https.

This looks like a great contribution, thanks! If you agree to the CLA I can merge it in.

https://github.com/github/lfs-test-server/blob/master/CONTRIBUTING.md
Doesn't direct me to any CLA.
Shouldn't be a problem just need to know where to look.

Does it allow you to accept it if you click the "Details" link in the build failure notice on this page?

Yes looks good now.

Excellent, thanks!


Support artifact servers that return "unauthorised" instead of "not found"

Expected Behavior
Gradle should resolve dependencies from custom repositories without errors.
Current Behavior
Gradle fails to resolve dependencies because of breaking changes introduced in 4.3 that you can not control if you are using JitPack.io.
Context
I'm sure that this issue gets closed without a resolution (as the other two issues reported recently did), but I thought I could spare some time for those users having the same issue as I do - so you don't have to bother about upgrading to Gradle 4.3 and then going back to 4.2.1 that works correctly.
If you are using JitPack and / or have multiple repositories, do not upgrade to Gradle 4.3 otherwise you would break your builds. When you have certain dependency in your own repository and Gradle 4.3 tries to find it in JitPack, your build fails. You can not do anything about it and re-ordering the repositories in your build script (as suggested by developers in another thread) is not an acceptable solution.
Steps to Reproduce (for bugs)
There are tens of dependencies that can trigger this. Just add random library that does not exists in JitPack, e.g. https://jitpack.io/com/github/random/Random/1.0/Random-1.0.pom
Your Environment
You will get "Received status code 401 from server: Unauthorized" from JitPack and build fails even thought you have this library in your own repository.
TL;DR [WARNING] do not upgrade to Gradle 4.3 if you are using multiple repositories or JitPack.io, otherwise you would not be able to build your projects.

This is a problem in jitpack. It should return 404, not 401 when something isn't found.
Why is reordering not acceptable?

Because the order should not matter and it can be part of library we're not authors of.
Does not make any difference, the 401 error is thrown no matter the order of the repositories.

@oehme How exactly is throwing an exception when any repository returns 4xx client error (but 404) for any dependency hiding problems in a build configuration?

This is a problem in jitpack. It should return 404, not 401 when something isn't found.

I'm not sure I agree. In fact, this behavior with GitHub is actually problematic in some cases and requires the use of preemptive auth. I wouldn't say returning a 404 for what is effectively a permissions issue is idomatic API design, albeit common.

I think it's reasonable that Gradle fails on authorisation errors. Otherwise we would be hiding actual problems in your build configuration.

So this comes down to this change: https://docs.gradle.org/current/release-notes.html#avoid-checking-other-repositories-when-dependency-resolution-in-one-repository-fails
I think your logic is reasonable, the whole purpose behind this change was that failure to access repositories could effectively not surface due to ordering, etc, causing different dependencies to be used in different build invocations. However, this is in itself potentially a use-case, relying on repository ACLs to determine which dependencies for a build to use. It's a bit goofy but not entirely unreasonable. I don't see how ordering would affect this, you'd have to programmatically "omit" the repositories you don't have access to.
I'm slightly leaning towards us relaxing this restriction to exclude client errors as @FrancescoCapari has suggested. This is a pretty disruptive change for folks relying on this behavior. I certainly agree that server errors (5XX) or other IO exceptions (timeout, etc) should trigger the build to fail but perhaps a good middle ground is proceeding on client errors. In almost every case, folks that rely completely on auth for their repositories will still encounter a failed build as the required dependencies simply won't be found.

Another scenario:
We have artifactory configured to have separate snapshot and release repositories.  If you request a snapshot from a release repository, it will return a 409 conflict response, to let you know you are looking in the wrong repository.
In 4.2.1, this was not a problem, but in 4.3, gradle sees the 409 response and throws an exception.
I agree with @mark-vieira that all 4xx responses should be treated the same way as 404s.

@mark-vieira @danlange Thanks for your contribution. Agreed - all HTTP client errors (4xx) should not fail a dependency lookout.
Since dropping Gradle would be quite complicated for us and since we're afraid that this breaking change (quite literally) won't get fixed, we currently at least wrote a simple proxy server that simply searches for dependencies and returns 401 for all client errors - this is the only way we could think of to make Gradle great again and usable for us. Quite ridiculous solution, but at least it works.

I'm not sure ignoring all 4xx codes is the way to go (e.g. think of "Unsupported Method") , but I get the point.
On the technical level we can treat 401 and 409 the same as 404 (i.e. remember that the module was missing and continue to the next repo), though we should probably present a different error to the user if the module couldn't be found at all. I.e. instead of "not found" we should spell out "not authenticated" or "not applicable".

I think handling individual client error codes differently is fraught with danger. In practice, these error codes are implemented to mean very different things depending on the server. We can't reliable take any individual error code to mean anything other than "the server didn't like the question we asked". I don't see much benefit in cherry picking some codes to bail on and others to proceed. Like I've said before, in most of these scenarios the build will fail anyhow.

Let's back the change out for 4.3.1 and add it back in with a more lenient behavior in 4.4.

@bigdaz It think this issue has been fixed by your PRs https://github.com/gradle/gradle/pull/3381 and https://github.com/gradle/gradle/pull/3382. Can we close this?

Yes, though we should open a follow-up to handle 5xx better.

@oehme Created issue and closing this one.

@FrancescoCapari This has been fixed. Could you try out your project with a snapshot of the 4.3.1 release? https://downloads.gradle.org/distributions-snapshots/gradle-4.3.1-20171107130851+0000-bin.zip

@bmuschko BUILD SUCCESSFUL (I tried your snapshot and I can verify that this issue is no longer reproducible with 4.3.1 snapshot). Thank you guys.

@FrancescoCapari With Gradle 4.4 we will treat dependency resolution handling for HTTP 5xx error codes the same way as we do for connection and socket timeouts (do not ask subsequent repositories). we'd love for you to try it out and provide us with feedback to avoid any potential issues in the final release. You can try out a snapshot distribution here: https://services.gradle.org/distributions-snapshots/gradle-4.4-20171112235945+0000-bin.zip. The actual change can be found here if you are interested: https://github.com/gradle/gradle/pull/3412. thanks for your support! let us know if you have any questions.


Batch norm docs -> r1.1

Fixed up the documentation for tf.contrib.layers.batch_norm and tf.layers.batch_normalization explaining how to include the update ops in the train_op. Also simplified the existing tf.layers.batch_normalization documentation to the least error-prone option (adding to the train_op).
PiperOrigin-RevId: 156609483
See https://github.com/tensorflow/tensorflow/commit/675f0f9073e9e6ac6df8018e972f2b38f2c4c23c for the same change in master.

We probably wont touch this branch anymore, as 1.2 is around the corner.
Is it OK if we only cherrypick this into r1.2?

Yes, please recreate pulling this change into r1.2.


Update sbt-bloop to 1.4.9

Updates ch.epfl.scala:sbt-bloop from 1.4.8 to 1.4.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-bloop" } ]

labels: sbt-plugin-update, semver-patch

ouf, we need to remove it.


Overlapping meaning from card client.Get

code in https://github.com/istio/istio/blob/master/pilot/pkg/config/kube/crd/client.go#L333
why return Pointer type and bool type，this return two value have overlapping meaning .
Pointer type can completely replace boolean type. don't need return bool, this is bed code.

Indeed.
/assign

By returning nil, we have no change to know what error happened inside.
Please consider return the error so we can react to it.
@hzxuzhonghu

There is no error, just not exists.

I mean the error returned by apiserver
https://github.com/hzxuzhonghu/istio/blob/76a09e95f59c9c0a44cd9dba9e1bc38851ed937c/pilot/pkg/config/kube/crd/client.go#L352


i18n: Add Japanese translation

Summary:
Adds translation file and tests for Japanese, ISO 639-2 code 'jpn', ISO 639-1 code 'ja'.
Japanese sentence structure is different from English, so where a sentence is split over multiple strings, the individual strings do not match, but the sentence as a whole does.
Description for the changelog:
Add Japanese translation
Other info:
Closes #932

Hey @jgadsden,
Sorry, I completely missed that file. I just added the necessary changes and amended my commit. I hope this approach is okay.


refactor(ci): just use the default cloned course-management-tools dir

Unless I'm misunderstanding something, we don't need this CMT abstraction right? Can't we just rely on the checked out dir that is created when it clones and we can avoid having the cd CMT in various places?

Unless I'm misunderstanding something, we don't need this CMT abstraction right? Can't we just rely on the checked out dir that is created when it clones and we can avoid having the cd CMT in various places?

Yes, it seems it's not needed. So let's remove it as you propose


Msal.js v1 - Improve interaction_in_progress reliability

Throws interaction_in_progress error at time of attempting to set the temporary cache value to minimize the gap between checking/setting cache and reduce occurrence of race conditions

Codecov Report

Merging #4466 (0fa7b5e) into dev (76473e9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag
Coverage Δ

*Carryforward flag

msal-angular
96.39% <ø> (ø)

Carriedforward from 76473e9

msal-browser
87.51% <ø> (ø)

Carriedforward from 76473e9

msal-common
85.32% <ø> (ø)

Carriedforward from 76473e9

msal-core
82.67% <100.00%> (+0.01%)
:arrow_up:

msal-node
82.97% <ø> (ø)

Carriedforward from 76473e9

msal-node-extensions
76.03% <ø> (ø)

Carriedforward from 76473e9

msal-react
92.70% <ø> (ø)

Carriedforward from 76473e9

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

lib/msal-core/src/UserAgentApplication.ts
72.61% <100.00%> (ø)

lib/msal-core/src/cache/AuthCache.ts
90.00% <100.00%> (+0.20%)
:arrow_up:


chore: Run make generate for grouped Renovate updates

How to categorize this PR?

/area dev-productivity
/kind enhancement
What this PR does / why we need it:
Renovate stopped running make generate for etc-druid and machine-controller-manager updates since grouping them in single PRs: #10907
According to the following package rule, Renovate is configured to run make generate but since the groups include dependencies from github-releases the rule for make generate does not match anymore:
https://github.com/gardener/gardener/blob/c53ca48952a1e64d231365f8c3c175d0e8b01187/.github/renovate.json5#L101-L118
Example PRs where Renovate did not run make generate:

https://github.com/gardener/gardener/pull/10956
https://github.com/gardener/gardener/pull/10926

Which issue(s) this PR fixes:
n.a.
Special notes for your reviewer:
/cc @oliver-goetz
Release note:

NONE

Thanks a lot!
/lgtm
/approve


rename and add tests

@tmatsuo PTAL

Can you provide what are changed? Can I see the changes in the generator rather than generated changes?

@tmatsuo https://github.com/bshaffer/apis-client-generator/commit/30fd801e0678cdbf3cfd848cc6634673431035ad

@tmatsuo removed all changes other than renaming/adding tests. PTAL

LGTM


Feature request: Allow for the manual setting of colors

The current "accent color hue" is set through sliders like this

This is user-friendly but prevents the inputting of themes via hex/rgb code (or something similar). Perhaps a user-fillable box could be shown that can set the colors? This could update based on the current slider settings so 1) folks can see what hex/rgb color they currently have  and 2) put in the hex/rgb color that they want
(in accessibility circles hex is usually preferred over RGB)

A couple issues with this:

The plugin relies on using HSL values (not hex or RGB) because they can be manipulated via CSS to generate all of the other colors.
The sliders are designed to limit the gamut to prevent issues with low contrast combinations

The first could be solved via an input field that automatically converts the values from hex to HSL. Not sure about the second.

A couple issues with this:

The plugin relies on using HSL values (not hex or RGB) because they can be manipulated via CSS to generate all of the other colors.
The sliders are designed to limit the gamut to prevent issues with low contrast combinations

The first could be solved via an input field that automatically converts the values from hex to HSL. Not sure about the second.

HSL values should work fine, so long as it's labelled that way!
The use case I'm thinking of is (for example) using this plugin to make base colors gruvbox-ish. I'm not sure if there is a way to prevent issues with low contrast but I feel like they'd be minority of issues? perhaps these two settigs could be in an "advanced" toggle with that warning?

HSL values should work fine, so long as it's labelled that way!
The use case I'm thinking of is (for example) using this plugin to make base colors gruvbox-ish. I'm not sure if there is a way to prevent issues with low contrast but I feel like they'd be minority of issues? perhaps these two settigs could be in an "advanced" toggle with that warning?

Yeah I love the idea of the Advance Appearance plugin, but the automatic colours are a dealbreaker. I get the appeal of a hue slider and the math adjustments that come afterward. But the resulting palettes are too monotone. It would be nicer imo if the plugin could support easier development of fully hand crafted colour themes.

Yeah I love the idea of the Advance Appearance plugin, but the automatic colours are a dealbreaker. I get the appeal of a hue slider and the math adjustments that come afterward. But the resulting palettes are too monotone. It would be nicer imo if the plugin could support easier development of fully hand crafted colour themes.


Feature added - clients && locations seeds implemented

https://www.loom.com/share/68e020d89eed485f965df8d839c5e9fb

Nice Job Saeed!! Good idea using the truncate. I didn't think of that.

Need a loom video walking through your code! Please add it to your description. In your description, include a quick blurb on what work was done and why the work was done. Like the title of the PR!

Done!

Whoa! This branch is based on another working branch that has not been merged yet.
DONT MERGE

seeds look good, like the use of truncate as well

Duplicate branch.


Allow client/server communication without payload

Removes the requirement of a data payload for communication, e.g. socket.send('join', null); can now be written as socket.send('join');.
(Also fixes error in Room.hx)

:+1: Thanks for your help!


CC incompatiblility

Please use the search functionality before reporting an issue. Also take a look at the closed issues!
Issue description: error when loading a custom cc (a mod called cubic chunks) world
Steps to reproduce:

install cubic chunks (1.12) (http://forkie.me/job/Cubic Chunks Related Jobs/job/Cubic Chunks 1.12-1.12.2/)
Create a world
Set world type to Custom Cubic (or flat cubic)
Select create

Version (make sure you are on the latest version before reporting):
Forge: should work on all versions since it's a mekanism problem
Mekanism: i used the latest version, should happen on all 1.12 version
Other relevant version: probably happens on all cc versions
If a (crash)log is relevant for this issue, link it here: https://cdn.discordapp.com/attachments/322363883698520065/405271648040779776/crash-2018-01-19_18.55.45-server.txt
[gist/pastebin/etc link here]

Its 20 days, nobody has noticed?

Hi @Gamer95875 ,
This has certainly been noticed, @thiakil added a label 19 days ago. We (the devs) all are currently quite busy with our real lives.

Ok then, just be sure to prioritise irl things and give me an eta (if you can), this mod is definently one of my favourites.


Installing in Oracle Linux

Could you offer any advice how to install this node in Oracle Linux please and what additional dependencies need to be installed.
Node-RED version: v1.0.3
Node.js  version: v10.19.0
Oracle Linux 4.14.35-1902.300.11.el7uek.x86_64 x64 LE
The installation presently fails (adding via palette manager).
-----------------------------------------------------------
2020-04-05T20:31:24.125Z Install : node-red-contrib-googlehome 0.0.6

2020-04-05T20:31:23.356Z npm install --no-audit --no-update-notifier --save --save-prefix="~" --production<EMAIL_ADDRESS>2020-04-05T20:31:42.094Z [out]
2020-04-05T20:31:42.094Z [out] ><EMAIL_ADDRESS>install /home/opc/.node-red/node_modules/mdns
2020-04-05T20:31:42.094Z [out] > node-gyp rebuild
2020-04-05T20:31:42.094Z [out]
2020-04-05T20:31:46.087Z [out] make: Entering directory `/home/opc/.node-red/node_modules/mdns/build'
2020-04-05T20:31:46.089Z [out]   CXX(target) Release/obj.target/dns_sd_bindings/src/dns_sd.o
2020-04-05T20:31:46.092Z [err] make: g++: Command not found
2020-04-05T20:31:46.094Z [err] make: *** [Release/obj.target/dns_sd_bindings/src/dns_sd.o] Error 127
2020-04-05T20:31:46.094Z [err] gyp ERR! build error
2020-04-05T20:31:46.094Z [err] gyp ERR! stack Error: `make` failed with exit code: 2
2020-04-05T20:31:46.094Z [err] gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:191:23)
2020-04-05T20:31:46.094Z [err] gyp ERR! stack     at ChildProcess.emit (events.js:198:13)
2020-04-05T20:31:46.094Z [err] gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
2020-04-05T20:31:46.094Z [err] gyp ERR! System Linux 4.14.35-1902.300.11.el7uek.x86_64
2020-04-05T20:31:46.094Z [err] gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
2020-04-05T20:31:46.094Z [err] gyp ERR! cwd /home/opc/.node-red/node_modules/mdns
2020-04-05T20:31:46.094Z [err] gyp ERR!
2020-04-05T20:31:46.094Z [out] make: Leaving directory `/home/opc/.node-red/node_modules/mdns/build'
2020-04-05T20:31:46.095Z [err] node -v v10.19.0
2020-04-05T20:31:46.095Z [err] gyp ERR! node-gyp -v v5.0.5
2020-04-05T20:31:46.095Z [err] gyp ERR! not ok
2020-04-05T20:31:47.170Z [err] npm WARN<EMAIL_ADDRESS>No repository field.
2020-04-05T20:31:47.170Z [err] npm WARN<EMAIL_ADDRESS>No license field.
2020-04-05T20:31:47.184Z [err]
2020-04-05T20:31:47.253Z [err] npm ERR! code ELIFECYCLE
2020-04-05T20:31:47.253Z [err] npm ERR! errno 1
2020-04-05T20:31:47.253Z [err] npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
2020-04-05T20:31:47.253Z [err] npm ERR! Exit status 1
2020-04-05T20:31:47.253Z [err] npm ERR!
2020-04-05T20:31:47.253Z [err] npm ERR! Failed at the<EMAIL_ADDRESS>install script.
2020-04-05T20:31:47.253Z [err] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
2020-04-05T20:31:47.257Z [err]
2020-04-05T20:31:47.257Z [err] npm ERR! A complete log of this run can be found in:
2020-04-05T20:31:47.257Z [err] npm ERR!     /home/opc/.npm/_logs/2020-04-05T20_31_47_251Z-debug.log
2020-04-05T20:31:47.273Z rc=1

Been a while since I played on a RedHat based distro (used to be hard core Fedora) but you are probably looking for a package called avahi-compat-libdns_sd-devel

avahi-compat-libdns_sd-devel.x86_64 0:0.6.31-19.el7 is already installed.
From the above log, is this line significant? is a further package needed?
2020-04-05T20:31:46.092Z [err] make: g++: Command not found
Or should that command be fulfilled from the avahi package.

Err, in that case you have WAY bigger problems.
If you don't have a basic c++ compiler (g++ ) installed then you must have had a bunch of problems installing Node-RED and any nodes that have native components.
I'd suggest you make sure the "Development Tools" group is installed
sudo yum group install "Development Tools

I haven't had any problems at all in installing node-RED, or the palette of nodes which have worked fine. This is the first problem that I have hit.
I'm installing all contrib nodes via the palette in the normal manner.
Maybe I've just dodged contrib nodes with native components...

...but, I've now installed sudo yum group install "Development Tools" and the node has now successfully installed into the palette.
There doesn't seem to be any connectivity though, but at least it appears to be installed so I'll close this down.
Thanks  Ben

I've just rebooted node-red and noted the below warning. Is this normal?
*** WARNING *** The program 'node' uses the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** The program 'node' uses the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see <http://0pointer.de/avahi-compat?s=libdns_sd&e=node>
*** WARNING *** The program 'node' called 'DNSServiceRegister()' which is not supported (or only supported partially) in the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see <http://0pointer.de/avahi-compat?s=libdns_sd&e=node&f=DNSServiceRegister>
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see <http://0pointer.de/avahi-compat?s=libdns_sd&e=node>
*** WARNING *** The program 'node' called 'DNSServiceRegister()' which is not supported (or only supported partially) in the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see <http://0pointer.de/avahi-compat?s=libdns_sd&e=node&f=DNSServiceRegister>

The hint is in the word "Warning"


Test platform specific extensions - Publishing to multiple targets

Testing #133868
Let's say I want to publish my extension to darwin-x64, linux-x64 and win32-x64, is there a way I can do that as a vsce one-liner? Or do I need to run vsce publish <platform> multiple times?

Dupe of an internal issue. Closing for now.


Add Pagination/View More to Speaker Section

The current speaker section is getting long. The idea is to display the last 6 speakers, with a "view more" button that will load additional speakers. Specific max/mins of this feature are up to debate.

Screenshot of current list:


Adding 4.1 and now pushes

@sosiouxme @tbielawa
Note: I checked and git merge as well as git push automatically no-op if nothing changed. So no extraneous pushes will occur.

/lgtm

Alright @tbielawa & @sosiouxme
Although I agree with @sosiouxme that the merge versions aren't really needed anywhere else, I agree more that it's the type of thing that is better in commonlib. If we ever need that info elsewhere then we're good now.
Also, current master version is also in commonlib now.


track groff bug and reenable box in block quotes once it's fixed

https://savannah.gnu.org/bugs/index.php?64561
.PRINTSTYLE TYPESET
.START

.QUOTE
.CODE
.BOX
Some boxed code
.BOX OFF
.QUOTE OFF

.PP
A \*[CODE]code\*[CODE OFF] item

Should not produce this:

Bug is closed and due to release with 1.24.0


Sample project on usage

Hello,
Is there any resources on the usage of this project in a sample app?
May be something that for example uses something simple and widely know like libcurl?

Hey!
As repository README states, on current moment it's just a research project right now. So nothing is published and the only thing you can do is to just check the sources 😀
Project currently contains example of usage with OpenSSL.


Plates sliding over each other

Maybe there's just something I'm not getting, but to me, it seems like currently when two plates collide, they don't crash into each other making a mountain, they just pass over each other without interacting. I'm not sure if this is the current intended behaviour or what could be done about it.
The seed in this example is /tectonics.js/index.html?seed=ChgW3

You can see that the plates are the same plates from before they collided.

Known bug. The models either needs some representation of subduction zone congestion, or better representation of crust as it subducts and drags the rest of the crust with it, or both.

This is going to be my next focus now that I've made some progress on #8. Could be a simple fix. It might only require us to recalculate velocity with each timestep.

I wonder if part of the problem with elevations blowing up doesn’t come back to crust segments stacking up like this.

On Mar 13, 2018, at 2:12 PM, Carl Davidson<EMAIL_ADDRESS>wrote:
This is going to be my next focus now that I've made some progress on #8. Could be a simple fix. It might only require us to recalculate velocity with each timestep.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

The thing with elevations blowing up has everything to do with integrating conserved mass deltas over multiple plates. If conserved mass was less likely to stack up around plate boundaries, then yeah, it would probably mask the problem, but it wouldn't fix it.
If that doesn't make sense: continental crust is a conserved quantity in the model. It's never created or destroyed, but it is transported and transformed. Continental crust can be transported/transformed by a number of processes: erosion, weathering, accretion, asteroid impact, etc. The model represents each process using a "delta". For each grid cell, the delta indicates how much crust will be gained or lost within a single timestep. Because continental crust is conserved, if you sum up the gains/losses for each grid cell, the sum will always equal zero. We check against this assumption every timestep and we can guarantee the deltas are calculated properly, but the problem is with how we add the deltas onto the plates. For performance reasons, we calculate the deltas only once for the entire globe, but for accuracy reasons, we store the state of the crust across several plates (the alternative to this is storing a single world map of crust and running an advection model).
So in other words, for each grid cell in the delta we have to allocate it to a grid cell on one of the plates. This is where conservation errors crop up. Imagine what happens when a grid cell on a plate map corresponds to multiple grid cells on the world map.
My solution so far has been to tinker around with different approaches and pick the one that seems to work the best. Not the ideal solution, but it's gotten better. Actually, as of 19114235afe1493802cb55ec016bf1efdc8e3871 the model is slowly losing mass, not gaining it.
Either way, fixing this issue may help to mask an otherwise intractable problem.

As of commit abf1ae6dc1a1eda597959300cb27438b89adc002, plate velocity is calculated deterministically for each timestep based on crust density. This will almost certainly resolve this issue.
Here's a brief rundown how it works:
Start with density

use that to calculate the buoyancy force: B = g Δρ where g is force of gravity and Δρ is difference in density compared to the mantle.

The velocity of subducting crust is essentially the terminal velocity of the crust as it descends into the viscous mantle due to the buoyancy force.
OK, now we already have a plate field as part of the simulator. Each plate has a mask indicating regions it occupies. Take the gradient of that mask and that gives you a boundary normal - in other words, a set of vectors that are normal to the plate boundary.

Multiply boundary normal by the velocity of subducting crust and you get an estimate for lateral velocity at that point. The average across all estimate is an estimate for the velocity of the entire plate.
It's important to note this is not the proper way to calculate velocity. It's only a fast approximation. If we wanted to do it the right way, we'd calculate the net drag force given the current plate velocity, then use that with the buoyancy force to update velocity. We'd do this for several iterations each timestep to get a good estimate. The reason we don't do it this way is 1.) it's slow, 2.) it's complicated, and 3.) it's not super important.
TL;DR: Imagine a cloth with lead weights strapped to one side. It's sitting in a vat of honey. The lead weights slowly drag the cloth into honey at a constant rate of speed. It's kind of like that.

Going to close this out if no objection


[#937] feat: Add rest api for servernode list of losing connection and unhealthy

What changes were proposed in this pull request?
Obtain the list of ServerNodes whose heartbeat is lost from a Coordinator Server
Obtain the list of ServerNodes whose unhealthy from a Coordinator Server
Why are the changes needed?
There is no interface for viewing lost and unhealthy lists
Fix: #937
Does this PR introduce any user-facing change?

Change in user-facing APIs.

How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
Updated UT: SimpleClusterManagerTest

@jerqi @smallzhongfeng Please review it for me

@smallzhongfeng Could you help review this pr?

nitpick but LOSTED should be LOST I think btw

You should run these commands locally.
mvn -B -fae checkstyle:check -Pspark3
mvn -B -fae test-compile spotbugs:check -Pspark3
mvn package -Pspark3

Codecov Report

Merging #938 (be50016) into master (cb22510) will increase coverage by 1.35%.
The diff coverage is 52.50%.

@@             Coverage Diff              @@
##             master     #938      +/-   ##
============================================
+ Coverage     55.34%   56.69%   +1.35%
+ Complexity     2273     2054     -219
============================================
  Files           344      293      -51
  Lines         16982    12952    -4030
  Branches       1349     1205     -144
============================================
- Hits           9398     7343    -2055
+ Misses         7038     5212    -1826
+ Partials        546      397     -149

Impacted Files
Coverage Δ

.../uniffle/coordinator/web/servlet/NodesServlet.java
13.63% <0.00%> (-6.37%)
:arrow_down:

...n/java/org/apache/uniffle/common/ServerStatus.java
94.44% <100.00%> (+0.69%)
:arrow_up:

...ava/org/apache/uniffle/coordinator/ServerNode.java
83.92% <100.00%> (+0.29%)
:arrow_up:

...ache/uniffle/coordinator/SimpleClusterManager.java
77.57% <100.00%> (+2.25%)
:arrow_up:

... and 56 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xianjingfeng are you going to refactor this in a follow-up pr?

Yes. @advancedxy

Thank you all


ci: docs check

Fundamental "how do I use this library" docs are done for insim, insim_pth, insim_smx.
deny(missing_docs) has been enabled and all further work will happen through #97


Detect Series - Phase 2

detection of increasing and decreasing pattern of numeric datatypes.

Hi Professor,
I have made the updates as suggested. Please verify.


Binded slot name do not distribute content as expected in Polymer#1.7.0

Description

Binded slot name do not correctly distribute slotted elements on non-chromium browser
Live Demo

http://jsbin.com/denumizugi/edit?html,console,output
Steps to Reproduce
Create a slot using binding for the name : <slot name="[[slotName]]"></slot>
Expected Results
Nothing should be displayed
Actual Results
'Should not be assigned' is displayed on non-chromium browser
Browsers Affected

[ ] Chrome
[x] Firefox (flashes)
[x] Edge
[x] Safari 10
[x] Safari TP Release 15 (Safari 10.1, WebKit 12603.1.8)
? Safari 9
? Safari 8
[x] IE 11

Versions

Polymer: v1.7.0
webcomponents: v0.7.22

I wanted to do <slot name$="[[slotName]]"></slot> but is failed converting to <content select$="[slot=[[slotName]]]"></slot>. So the converted binding looks like <content select="[slot=[[slotName]]]"></slot>. Therefore, when the binding occurs, it sets 'select' as a property instead of an attribute on non-chrome browser (that do not natively support v0 web components). During distribution, the _matchesContentSelect function
var select = contentElement.getAttribute('select');
if (!select) {
  return true;
}
select = select.trim();
if (!select) {
  return true;
}

returns always true.

The issue you pointed out can probably be most easily resolved by checking for the property in addition to the attribute, since supporting the slot->content transformation with the attribute binding is more problematic: although the parser will parse an attribute with $ in the name, some browsers throw when trying to set it, so we can't just move the attribute binding and allow the normal annotation parsing to extract the binding from it.
However, note that even if that was fixed, in 1.x Shady DOM does not automatically watch for dynamic changes to the select attribute on <content>, so you would need to manually force distribution after setting slotName by calling distributeContent, as in this example: http://jsbin.com/tomoro/edit?html,output


pyWal support and terminal coloring

with pywal and it's -R flag you can apply colors to I guess any terminal. There is other wal programs that works with wal colors such as wal-telegram. There is my approach of doing that:
home.nix
  home.file = {
	".cache/colors.json".source = config.lib.stylix.colors {
	        template = builtins.readFile ./pywal.json.mustache;
	        extension = ".json";
	      };
};
home.activation =  #ALSO ACTIVATES AT REBOOT
      {
        generate_pywal_colors = lib.hm.dag.entryAfter ["writeBoundary"] ''
         $DRY_RUN_CMD ${pkgs.pywal}/bin/wal -f ~/.cache/colors.json
         $DRY_RUN_CMD ${pkgs.pywal}/bin/wal -R
       '';
telegram-colors = lib.hm.dag.entryAfter ["writeBoundary"] ''
#         $DRY_RUN_CMD      rm -rf ~/.cache/.wal-telegram-git
         $DRY_RUN_CMD ${pkgs.git}/bin/git clone --depth 1 https://github.com/guillaumeboehm/wal-telegram ~/.cache/.wal-telegram-git || PATH=/run/wrappers/bin:/.local/bin:/root/.nix-profile/bin:/etc/profiles/per-user/root/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin          /usr/bin/env bash -i -c '~/.cache/.wal-telegram-git/wal-telegram --wal -g -r -b ~/Pictures/wallpaper.jpg' && PATH=/run/wrappers/bin:/.local/bin:/root/.nix-profile/bin:/etc/profiles/per-user/root/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin          /usr/bin/env bash -i -c '~/.cache/.wal-telegram-git/wal-telegram --wal -g -r -b ~/Pictures/wallpaper.jpg'
       '';
};

pywal.json.mustache
{
    "special": {
        "background": "#{{base00-hex}}",
        "foreground": "#{{base07-hex}}",
        "cursor": "#{{base07-hex}}"
    },
    "colors": {
        "color0": "#{{base00-hex}}",
        "color1": "#{{base01-hex}}",
        "color2": "#{{base02-hex}}",
        "color3": "#{{base03-hex}}",
        "color4": "#{{base04-hex}}",
        "color5": "#{{base05-hex}}",
        "color6": "#{{base06-hex}}",
        "color7": "#{{base07-hex}}",
        "color8": "#{{base08-hex}}",
        "color9": "#{{base09-hex}}",
        "color10": "#{{base0A-hex}}",
        "color11": "#{{base0B-hex}}",
        "color12": "#{{base0C-hex}}",
        "color13": "#{{base0D-hex}}",
        "color14": "#{{base0E-hex}}",
        "color15": "#{{base0F-hex}}"
    }
}

home-manager's programs.pywal module is also setting some settings there.
i feel that can get kinda so big they might not be the best place for that, which makes me wonder if this could be a better place as well.
the basic process seems to be about ensuring there's a template file for the application in question, then from nix having the application's actual style/configuration file include a dynamic include to that (presuming their format supports this), e.g. see my attempt for Zathura.
i feel like we could do stuff like that here, so maybe the question would be if it's in scope. if anything tho, it would seem desirable to have these play nice, i.e. ensuring stylix wouldn't like override its colors with static ones, so that could be an argument in favor of handling this from the stylix repo.

Hey @KiaraGrouwstra,
I stumbled upon this issue and I was wondering whether you were aware that stylix has builtin support for generating colorschemes based on the wallpaper similarly to what pywal does (although the details elude me):
https://stylix.danth.me/configuration.html#generated-schemes

@99linesofcode thanks for mentioning that.
i guess the unfortunate part of stylix for this purpose tho would be having to rebuild your nixos config just to change wallpaper, which seems like a bunch of unnecessary cpu cycles.
delegating the theme generation stuff to the likes of pywal for that would alleviate that need.

i guess the unfortunate part of stylix for this purpose tho would be having to rebuild your nixos config just to change wallpaper, which seems like a bunch of unnecessary cpu cycles.

In the future, this operation would mostly happen at runtime: https://github.com/danth/stylix/pull/477#issuecomment-2254170449


Add permissions env variables in workflow

Required items, please complete
Change(s):

Added permissions and environment variables in github actions workflow

Reason for Change(s):

Added permissions and environment variables.

Version Updated:

NA

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

closing this for now and will reopen this once I start work on it.


🐛 Bug Report: DocsGPT version gets hidden on smaller screen

📜 Description
https://github.com/arc53/DocsGPT/assets/108279746/8bb2f814-12e9-411d-985a-76183aa08e6c
The version select gets hidden when on smaller screens.
👟 Reproduction steps

Open drop down from the version select.
Open inspect and go to a smaller screen size.
And click outside the select and it will vanish.

👍 Expected behavior
It should be present  on smaller screens.
👎 Actual Behavior with Screenshots
--
💻 Operating system
Windows
What browsers are you seeing the problem on?
Chrome
🤖 What development environment are you experiencing this bug on?
Docker
🔒 Did you set the correct environment variables in the right path? List the environment variable names (not values please!)
No response
📃 Provide any additional context for the Bug.
No response
📖 Relevant log output
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🔗 Are you willing to submit PR?
Yes, I am willing to submit a PR!
🧑⚖ Code of Conduct

[X] I agree to follow this project's Code of Conduct

@dartpain Can you look into this, if this if genuine or not and assign me.

This is a cloud version bug and it was fixed. Thank you!


Give GodSVG a better icon

Self-explanatory, GodSVG needs a good app icon. I'm thinking of keeping the blue flame, maybe even having some subtle reminiscence of Godot in its overall shape. I don't think the handle is necessary, or the eyes. The eyes are cute though, I'll try to keep them when/if I wind up making the design!

I'll make some sketches tomorrow.

Now I'm onto this cute fox making a paint stroke with its tail, in an overall G shape.

Pinning as solving this is for the first alpha would be great.

Hi, I whipped this up in Affinity Designer.   The SVG is as exported by Affinity.

This was my sketch over the above drawing.

Hi, I whipped this up in Affinity Designer. The SVG is as exported by Affinity.

I love this, but it strays off a little from what I was aiming for with the fox icon:

I'm pretty set on using blue as the main color at this point, and I'm also set on having a simple icon without tiny details, one that would have its details easy to discern even at a resolution like 16x16. So I prefer not to go with a rainbow.
This logo is C-shaped, while the overall shape of the fox with its paint trail in the concept is G-shaped. This is important to the concept as it's the first letter of the app.
 I only want to have a closed eye with of a happy face (as the above post), or a sleepy face (like the pic below) because while it's a tiny detail, it does a lot to emphasize the cuteness of the logo.

I think I get what you are aiming for.  I'll take another shot at this.  This is a cool and ambitious project.

Thanks a lot for the effort!

P.P.S. Sorry nevermind, it's easy to fetch the text when you post a SVG file on Github, so it doesn't matter.

I worked up some new variants based on your sketches and rendered them at powers of 2 from 128 to 16 px square.  Let me know what you think.   I will provide the SVG (and Affinity files, if you want them) when we settle on a design.  Also, I can fix the faint line across the dark blue in the middle color scheme.
128 px

64 px

32px

16px

I like this! I don't really have much to critique. The main thing is, I'd like to see whether a version without outlines could work.
Don't worry about artifacts as long as the overall shapes are right, since in the end I'll tweak slightly the shape, colors, etc. and optimize it anyway.
Minor remarks:

The orange sploch above the paint trail must go, the ones at the end shouldn't be different colors.
The paint trail should be smoother
It should be clearer that the fox's cheek tuff is not part of the face.
the end of the tail is sticking too far to the right

Here is the next iteration - with and without outlines. Personally I prefer no outlines.
128px

64px

32px

16px

Cool! Can I get an SVG of the last no-outline version? Also, what's your real name? (Or do you want to be credited only by your Github handle?)

Hi, Here is the SVG.  My name is Tom Blackwell.

Also, here is a version with the outline of the red part of the stroke improved a little.

You're welcome. 🙂

Closed by #243