Unhandled Error: launch.js line 51.  this.log undefined.

Command ran
Running command:
/Users/tommulkins/Projects/Worthy Financial/worthy-frontend/src-cordova/node_modules/ios-sim/bin/ios-sim launch /Users/tommulkins/Projects/Worthy Financial/worthy-frontend/src-cordova/platforms/ios/build/emulator/Worthy Financial - Earn 5 percent return on your savings.app --devicetypeid com.apple.CoreSimulator.SimDeviceType.iPhone-SE--2nd-generation-, 13.4 --log /Users/tommulkins/Projects/Worthy Financial/worthy-frontend/src-cordova/platforms/ios/cordova/console.log --exit

Expected behavior
Successfully deploys to ios simulator.
Actual behavior.
Exception thrown:
Error: Unhandled error. ('[ios-sim] /Users/tommulkins/Projects/Worthy Financial/worthy-frontend/src-cordova/node_modules/ios-sim/src/commands/launch.js:51\n' +
  '          this.log(`logPath: ${path.resolve(flags.log)}`)\n' +
  '               ^\n' +
  '\n' +
  "TypeError: Cannot read property 'log' of undefined\n" +

Steps to reproduce the problem
Build and deploy cordova app using ios-sim 9.0.0
System Specs
Please run the commands below in your Terminal.app and include it in the issue. Check when done and include results below.

[ ] 1. system_profiler SPSoftwareDataType

Software:

    System Software Overview:

      System Version: macOS 10.15.4 (19E287)
      Kernel Version: Darwin 19.4.0
      Boot Volume: Macintosh HD
      Boot Mode: Normal
      Computer Name: Tom’s MacBook Pro
      User Name: Tom Mulkins (tommulkins)
      Secure Virtual Memory: Enabled
      System Integrity Protection: Enabled
      Time since boot: 1 day 23:20

[ ] 2. ios-sim --version

ios-sim/9.0.0 darwin-x64 node-v12.13.1

[ ] 3. xcodebuild -version

Xcode 11.4.1
Build version 11E503a

[ ] 4. xcode-select --print-path

/Applications/Xcode.app/Contents/Developer

[ ] 5. node --version
v12.13.1

Same here

Same here as well

@tommulkins have you found a workaround?

@tommulkins have you found a workaround?

I just downgraded to 8.0.2 and have been using that ever since.


[coffeescript] syntax highlighting breaks on indented comment blocks

VSCode Version: 1.7.0
OS Version: 10.11.6

Steps to Reproduce:

Add comment block (three hashtags in a row)
Indent comment block

This appears to be caused by the lookbehind used in the regular expression marking the beginning of a comment block here. For some reason, this expression matches all characters except for empty spaces.
A temporary fix on my machine is to change the expression from (?<!#)###(?!#) to ^[^#]*###(?!#), though this would possibly break for multiple block comments on a single line.

Per @aeschli, VSC's CoffeeScript grammar is from https://github.com/textmate/coffee-script.tmbundle. There is a corresponding issue in that repo.

Any word on this and #15008? I've been fixing it manually but whenever VSCode updates it wipes that out. Really tedious for me, would love to fix it if I can help.

They already have a PR in for the fix ... https://github.com/textmate/coffee-script.tmbundle/pull/11

@drKnoxy seems to be dead in the water, and there isn't a fix for #15008. Are we sure that the maintainers of that package are active?

Probably inactive, I hear everyone is switching from textmate to vscode (har har har)

Fixed by switching to the atom/language-coffee-script grammar.


Update https-browserify dependency.

This helps resolve issues when resolving https urls, eg. https://github.com/substack/https-browserify/issues/6 & downstream in https://github.com/Rebilly/ReDoc/issues/243

🙌 Hey @sokra
could you please review and merge this PR. It's pretty simple and safe - just updating https-browserify to the latest version with the important issue fixed.
Thanks in advance

Browserify hasn't marked this change as a breaking change, so I expect this change to be safe to merge.

Thanks 👍
Shipped with 2.1.0 (should land in current webpack 3 installations)


Armored Elytra storage format

Why is the Armored Elytra storage format so complicated?
You could just serialize the chestplate and elytra ItemStacks as bytes and store that directly in the parent item.

Has there been a new version since this?

Has there been a new version since this?

Sorry for the delay,
Just released v1.11.0 with this feature :)


[ ] Yes
[x] No

If requesting a CLI for "arkade get"
How many downloads does this tool have? Check at:
https://somsubhra.github.io/github-release-stats/
The tool has 628,233 downloads for the latest release
Your Environment

Operating System and version (e.g. Linux, Windows, MacOS): Ubuntu 20.04

Please go ahead and send us a pull request @AmrSaber
The easiest way to get started, is to look at a closed and merged pull request to see what to change.
Let us know if you need anything cc @Shikachuu
Alex

/add label: status/approved

/close


Separate cache blocks from cache entries.

Rather than storing cache blocks in set_associative_cache itself, allocate them separately and just store a pointer in the cache.
This allows:

Removing the locked interface and never having uninitialized blocks in the cache. Instead, each read_iop owns a block and swaps with the cache when the read finishes.
Removing the memcpy on grid block write. Instead, the writer passes a *BlockPtr and then grid swaps it with the cache. (This means writers have to be aware that writing a block consumes that data.)

Also, it was previously possible for inserting a key into the cache to cause two evictions. In some workloads (notably src/lsm/tree_fuzz, but not src/benchmark) this led to cache occupancy dropping to ~40%. We can avoid this by overwriting the existing entry if there is one, at the expense of muddling the fifo order of the cache.

The fuzzer seems happy so far. ~20 successful seeds.


Weapons that fire with left-click cannot be fired from close range

Has this issue already been reported? Did you ask for help before making this report?

[X] I have searched the existing issues
[X] I have asked for help

Current Behavior
Non-melee weapons that have a LEFT_CLICK shoot trigger will not fire if you are looking at an entity that is less than 6 blocks away from you. Instead, the vanilla 'weak attack' sound plays, as if you are trying to hit it with the gun.
Expected Behavior
The weapon will fire even if you are looking at a nearby entity.
Steps To Reproduce

Use this config
Spawn a mob
Point the gun at the mob at point blank range and try to fire with left-click
Slowly move away from the mob until the gun fires

Frequency
100% of the time
Version and Log
Log file link

Anything else?
Video demonstration:
https://user-images.githubusercontent.com/9055352/200096461-b1462329-f572-4356-911e-75bb6c8c1ece.mp4

Requires trigger activation when damaging entity via left-click (TriggerType.LEFT_CLICK -> weapon handler)


Improve grammar in documentation

Type of changes

[ ] Bug fix
[ ] New feature
[x] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[x] I've run the latest black with default args on new code.
[x] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[x] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

Codecov Report
Base: 98.51% // Head: 95.40% // Decreases project coverage by -3.11% :warning:

Coverage data is based on head (45b479d) compared to base (8baf90b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2756      +/-   ##
==========================================
- Coverage   98.51%   95.40%   -3.12%
==========================================
  Files          74       74
  Lines        7897     7897
==========================================
- Hits         7780     7534     -246
- Misses        117      363     +246

Flag
Coverage Δ

unittests
95.40% <ø> (-3.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

rich/_windows_renderer.py
0.00% <0.00%> (-100.00%)
:arrow_down:

rich/_win32_console.py
3.01% <0.00%> (-86.94%)
:arrow_down:

rich/console.py
95.14% <0.00%> (-2.89%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

The FAQ is auto-generated by Faqtory, so pointless to edit. Not going to edit a standard COC. Don't agree with the majority of the remaining edits.


Upgrade requests to version 2.20.0 [20m]

To fix security vulnerability:
CVE-2018-18074 More information
moderate severity
Vulnerable versions: <= 2.19.1
Patched version: 2.20.0
The Requests package through 2.19.1 before 2018-09-14 for Python sends an HTTP Authorization header to an http URI upon receiving a same-hostname https-to-http redirect, which makes it easier for remote attackers to discover credentials by sniffing the network.


Update document to sync with recent updates

Changes

:broom: Update document to sync with recent updates

/kind documentation

Thanks for updating the docs


Added SecureColumnByCoordsMutSlice.

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#750  👈
#749
#748
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Alon-Ti and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 77.77778% with 12 lines in your changes missing coverage. Please review.

Project coverage is 92.97%. Comparing base (16af67e) to head (d4581c8).

Files
Patch %
Lines

crates/prover/src/core/backend/simd/column.rs
77.77%
12 Missing :warning:

Additional details and impacted files
@@               Coverage Diff               @@
##           col-chunks1     #750      +/-   ##
===============================================
- Coverage        93.05%   92.97%   -0.08%
===============================================
  Files               86       86
  Lines            11239    11290      +51
  Branches         11239    11290      +51
===============================================
+ Hits             10458    10497      +39
- Misses             688      700      +12
  Partials            93       93

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Merge activity

Jul 23, 10:28 AM EDT: @Alon-Ti started a stack merge that includes this pull request via Graphite.


[release-1.10] Give more debug info on istioctl install failure

This is an automated cherry-pick of #34669

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.10
cc63632acead19314d8c12c8996749f593d86c5e
link
/test unit-tests_istio_release-1.10

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.10
cc63632acead19314d8c12c8996749f593d86c5e
link
/test unit-tests_istio_release-1.10

integ-pilot-k8s-tests_istio_release-1.10
cc63632acead19314d8c12c8996749f593d86c5e
link
/test integ-pilot-k8s-tests_istio_release-1.10

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@googlebot I consent.

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio_release-1.10
cc63632acead19314d8c12c8996749f593d86c5e
link
/test integ-distroless-k8s-tests_istio_release-1.10

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio_release-1.10
cc63632acead19314d8c12c8996749f593d86c5e
link
/test integ-distroless-k8s-tests_istio_release-1.10

integ-security-k8s-tests_istio_release-1.10
cc63632acead19314d8c12c8996749f593d86c5e
link
/test integ-security-k8s-tests_istio_release-1.10

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


ng-embed parses Youtube user page links as videos

For example
https://m.youtube.com/user/UltraHypnosis
ng-embed attempts to embed this link as a video.

I've run into it as well, seems like the regex returns positive for user channels with 11+ characters in its name. Going to send a PR request.

Fixed.


install git for composer packages on github

if you need to install a specific commit of a package, composer needs git

:+1:


Modal search - ARC reported issues

When modal is closed, ARC reports 'Non-active element in tab order'.
When modal is open, it reports 'aria-hidden="true" is used on an element that contains one or more focusable child elements' (header) and 'aria-hidden="true" is used on a focusable element' (main).
Alerts (whether open or closed) for 'aria-hidden used', autocomplete missing, no nav landmark, missing bypass methods, no H1 heading

No nav, no bypass method and no H1 are down to the skeleton content in the documentation sample, but other issues can be checked.

Closing this as OK.  The 'aria-hidden containing focusable elements' warning is down to the fact that all sibling elements in the body are being set to 'aria-hidden' when the modal is opened.  This is being flagged by this rule  however, in our instance we have other ways of stopping the tab/keyboard focus from dropping out of the modal until it is closed.  Therefore, the elements behind are not accessible to the keyboard either.


Added Import Book page

Setup very basic import system that imports a book and creates a new page.
Does not work with phpdoc2 as they do not export to a single xml.
Addresses #149

Hi @Jujhar, Apologies for my lack of response on this over the last 15 or so months.
Thank you for offering this pull request, The code within looks well done. Unfortunately this is not a feature I'd look to incorporate into the core project. While people may find this useful to help migrate their content into BookStack, I think the maintenance and support surrounding such as system will just be too much as the supported migration platforms evolve, change or show their side-effects & edge-cases that make such a system troublesome.
Instead I'd prefer to focus on extending the API so that people can more easily script imports for their desired system, and share such scripts if they wish.


notification support

check sysrepo notification works as expected

https://github.com/microsonic/goldstone-mgmt/pull/31


Change URL when moving from Desktop/Source views

For easier sharing, we should add:
https://demo.react.email/preview/vercel-invite-user?view=source

I just uploaded a solution to this problem, I believe I have solved it and can close the question.
https://github.com/zenorocha/react-email/pull/245


New catch version is pretty long

Expected Behavior
Can catch pokemon and find apropriate path
Actual Behavior
Makes long minutes before actually seeing a pokemon
Why yesterday behaviour has change ?

what commit are you running? i dont see any issues on b8606bc509ca89902441b213f5ee7996cca29137
[2016-07-25 13:36:24] [#] A Wild Pidgey appeared! [CP 125] [Potential 0.42]
[2016-07-25 13:36:24] [#] IV [Stamina/Attack/Defense] = [6/2/11]
[2016-07-25 13:36:26] [x] Using Pokeball (chance: 53.30%)... (87 left!)
[2016-07-25 13:36:27] [x] Captured Pidgey! [CP 125] [6/2/11]
[2016-07-25 13:36:27] [#] Pidgey has been exchanged for candy!

There is an issue regarding SpiralNavigator. @douglascamata is already working on a fix.

I'm on 'dev' to be as close as possible on the latest version and try to give some work on it.
@tstumm Thanks ! Waiting for this fix :)

I'm having trouble with the fix. Any help is appreciated. Please setup the maps integration to have a better picture of how (bad) it's walking. lol

@douglascamata I will try to see that tonight (I'm at work for now). The former method wasn't enough great ? Because yesterday it was actually pretty efficient.

@LeaklessGfy we're refactoring towards implementing a Behaviour Tree and this broke the SpiralNavigator. It's not calculating next points to walk to correctly, I guess. :/

@douglascamata Alright thanks for this informations and can you tell me more about the problem you encounter ? What's actually happening with that function on map ? Google map direction make the process buggy ? Another thing ?

@LeaklessGfy basically the bot is walking like a drunk cockroach. I think next step is not being calculated correctly by SpiralNavigator.

Alright the big problem here is that the master branch is actually at the same point of dev ... I think that's a terrible thing because here we are stuck until we don't find the solution of this problem and I can't get a eye on it for now ... On slack we should warn every dev on this issue.

@tstumm Seem to fix it ? (on slack he told some things about that, need to test in order to see if it works)

Just updated to #813 the latest commit in dev and it's not fixed, still won't find anything.

Fixed

Wait @crazy4ever can you post a log?

Normally log gets kinda long since its printing a walk msg on every tick. For me it catches pokemon now and then. Of course its not doing this on every tick because the distance travelled is normally low.

@tstumm Set debug to true and do i just have to copy everything in it or does it safe the info somewhere?

Alright, reinstalled everything, and now "catch" isn't working like before, but when using "all" it actually catches pokemons.
It's just "catch" that isn't working.

modes are: all, farm, poke


Skip flaky TestBrokerNotReadyAfterBeingReady test for namespaced Broker

This is limiting our ability to merge PRs, skipping for now

@pierDipi should we open an issue to investigate why this is failing for namespaced brokers?

/test upgrade-tests


Overriding build-cmd with "" results in default build command running

Since Python treats empty strings as falsy, build_task will use the default build command (using CMake) if the user provides build-cmd: "".   See https://github.com/Oblong/obi/blob/a7452af911c5daee643b25b22f71f58b736e163f/obi/task/task.py#L139
My expectation is that providing an empty build-cmd, or build-cmd: ~ would make the build-task a no-op.  Instead, I have to provide something like build-cmd: /usr/bin/env true

Should be fixed by #78, thanks @Gobiner!


Multiple Public IP support for Azure Firewall deployed in Virtual Hub

Is your feature request related to a problem? Please describe.
This is a new feature request. We are adding a new field HubIPAddresses through which users can specify the multiple IP addresses they would like to be attached to the firewall.
Describe the solution you'd like
HubIPAddresses was earlier a read-only property on Azure Firewall. With this change it will be editable, and users will be able to provide the count of public IP addresses they would like us to deploy and a list of IP addresses which will contain those addresses that were previously deployed and they would like to retain. So HubIPAddresses contains a new field fpublicIPs which has sub fields Addresses and Count through which the user can provide the 2 inputs.
Describe alternatives you've considered
There are not alternatives as this is a requirement by design.
Additional context
Swagger changes will soon be posted here.

add to S171

add to S172

What is the update on this?


Update for Xcode 10.2 / Swift 5

bump version
bump .swift-version
update podspec
update Podfile
update project to recommended settings
convert framework to Swift 5
convert sample to Swift 5
fix warnings

$ pod lib lint

 -> RevealingSplashView (0.8.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description

RevealingSplashView passed validation.

@PiXeL16?

@PiXeL16

Thanks for merging @PiXeL16. Could you please also make a new release and push it to cocoapods?

@PiXeL16 Please publish new version, can't update to Swift 5.0

You can just point your dependency manager to Master, not the one published and it should be fine. I gave successor acces to @weakfl Since I dont have time to maintain this repo anymore.
@weakfl Would you be able to publish the new version?

@PiXeL16 @blackcolt I'll look into it...

@PiXeL16 I'll also need permissions on cocoapods.org, I've sent you an email with my account details...

Done! Thank you


Pydantic Validation with database connection

I want to validate a field against the database., i.e. Check Whether a field exists in the database's table (similar to Marshmallow)?
I am using SQLalchemy as the ORM, Is it possible to write such validators with Pydantic
My code sample looks like
class EmailSchema(BaseModel):
    address: str
    inserted_at: datetime

    @validator('email')
    def validate_name(cls, value, db_session:Session = Depends(get_db)):
        if db_session.query(Email).filter(Email.address == value).count():
            raise ValueError('Email already exists')
        return value

Currently, it is not working, Is this type of validator allowed in pydantic ? How to use it ?

The short answer is you shouldn't do IO (including db access) in validators, because:

most new development would use asyncio for db access which won't work in validators which aren't coroutines
it's very useful to have a hard distinction between checking the data integrity and checking whether it's consistent with the rest of the world

However it you really want to do this it should be possible, you just need to make db_session global or otherwise accessible via closure inside the validator.

OK, Then I have to a separate validation methods to do validations with the database things?

otherwise accessible via closure inside the validator.

Can you please give an example of this ?

def whatever():
    db_session = ...

    class EmailSchema(BaseModel):
        address: str
        inserted_at: datetime

        @validator('email')
        def validate_name(cls, value):
            if db_session.query(Email).filter(Email.address == value).count():
                raise ValueError('Email already exists')
            return value

Like others I also have done the DB validations inside the validators, which not only as per @samuelcolvin violates the SOC (separation of concerns) but also makes it almost impossible to test while writing unit tests. When you are using the dependency injection in Fast API for creating DB sessions you can easily override this in Fast API by overriding the dependencies like app.dependency_overrides[get_db] = get_test_db but there is no way you can send this session to the validator hence you end up using the actual DB session inside the validator thereby halting your unit tests.

Like others I also have done the DB validations inside the validators, which not only as per @samuelcolvin violates the SOC (separation of concerns) but also makes it almost impossible to test while writing unit tests. When you are using the dependency injection in Fast API for creating DB sessions you can easily override this in Fast API by overriding the dependencies like app.dependency_overrides[get_db] = get_test_db but there is no way you can send this session to the validator hence you end up using the actual DB session inside the validator thereby halting your unit tests.

And that's exactly my issue, thank you for sharing


How to setup AzureDevops Selfhosted agents in Azure ContainerAppservice?

We are using Azuredevops server and looking for a way to run our self hosted Build agents in Azure ContainerAPP service as this will support KEDA. But looking in Microsoft documents, there is no guidance to create it and couldnt find any good article on how to create the ADO self hosted agents in AzureContainerApp with private access.
Is anybody achieved this in your envireonments or tried? Please help me with the steps if you have achieved this already.
{
"status": "Failed",
"error": {
"code": "InternalServerError",
"message": "Internal server error occurred. correlation ID: xxxxxxxxxxxxxxxx"
}
}

Hi @vivuu1989 are you trying to use the KEDA scaler Job object for devops agents? This is not supported today per the docs. We are currently designing Jobs! Let me know

Hi @vivuu1989 are you trying to use the KEDA scaler Job object for devops agents? This is not supported today per the docs. We are currently designing Jobs! Let me know

But from the docs, Its mentioned that Container app is supporting KEDA and also found some articles about build agents in containerapps.

Hi @vivuu1989 are you trying to use the KEDA scaler Job object for devops agents? This is not supported today per the docs. We are currently designing Jobs! Let me know

hi,
But from the docs, its mentined that the containerapp is supporting KEDA feature and over internet could find some articles about configuring build agents in containerapps.
https://techmindfactory.com/Containers-For-Azure-DevOps-Automation/

see: https://github.com/microsoft/azure-container-apps/issues/24 and please add comments there for tracking


Consider adding a connection timeout

Currently the timeout argument only controls timeouts while closing the connection.
The discussion in #112 suggests it may be useful to implement a general timeout on the connection.
I'm unsure about this and filing this issue for future consideration.

Wrapping with asyncio.wait_for(..., timeout=...) seems all right.


v12.1.0

Coverage increased (+8.0e-05%) to 99.976% when pulling fcdc80ceba43f6a10136d069a4ef40144eb63209 on release-candidate into f7238db7cc863eb7a5b994aa97b13934f8d136e7 on v12.


Update berkeley replayer cron image

Update image used for berkeley replayer cron job.
Also, add auth credential for gsutil in the script, which started to fail recently.
Tested by manually starting the cron job, verifying that a new checkpoint file was created.

!ci-build-me

!ci-build-me

!ci-build-me

!approved-for-mainnet


Extend build_db.clj to take an "only-changes" argument and document it in README.org

This isnt going to be strait forward. 2 main reasons are 1) Some change files need to be applied before building functions and some need to be after. 2) Most change cannot be applied twice.  We need to develop a way to check which files remaining on master need to be applied.  Two systems may be in different points of deployment (collect.earth vs a dev computer) so we cant just delete the changes immediately after they are deployed (not to mention if someone forgot, it could wreck the system).

Yes, I outlined two solutions for this in our mattermost chat.

Have clojure -A:build-db apply-changes write a file in the
toplevel repo directory (ignored with .gitignore), called something
like .build-db-changes. This file would contain a list of all the
src/sql/changes files that had been successfully applied to the DB
on this machine. This allows collect.earth and
ceodev.servirglobal.net to be out of sync without issue.

Have clojure -A:build-db apply-changes INSERT rows into a DB
table for each src/sql/changes file that is successfully applied to
the DB on this machine.

In either case, the command would begin by reading in (from file or
DB) the list of files that have been applied already. Then it could
read in (from the source tree) the list of src/sql/changes files that
are currently in the repo.
The algorithm would proceed by sorting both lists chronologically
(assuming we continue to keep the timestamps in the change file
names). You would then drop all entries in the already-applied list
that fall before the first entry in the currently-available list.
This allows us to delete change files periodically from the source
tree without breaking anything.
You then take the set/difference of currently-available and
already-applied, which would give you the set of entries that are
currently under src/sql/changes that have not yet been applied to
this DB. If you chronologically sort this list, you can then apply
each of these entries in order to bring the DB up to date with all
available changes.
For safety, as each file is applied to the DB, you should do so in a
transaction, so if it fails, any changes it attempted to make will be
automatically rolled back. Each time a change file is applied
successfully, you either append its name to the list in
.build-db-changes or INSERT it in the appropriate DB table. If any
change file fails, let its transaction roll-back and exit with an
error message for the user. Do not attempt to apply any other change
files.
This approach allows you to debug the issue with that one change file
and then rerun clojure -A:build-db apply-changes to resume where you
left off.

This issue would require adding three alias subcommands to :build-db:

apply-changes: Apply all change files to the DB (in transactions)
that are not recorded in the DB with their file hashes. If file
hashes don't match file names in the DB for files on disk, raise a
warning and halt.

save-changes: Delete all entries from the change file table in the
DB and add only those files under src/sql/changes. This should be
called by the "build-all" subcommand.

last-change: Return the last entry (in chronological order) from
the change file table in the DB.


Docs for Mixed precision training and the use of LossScaleOptimizer in custom loops with jax backend

Hi,
Should we Scale the loss and gradients like in the tf.keras docs for jax backend or the LossScaleOptimizer takes care of it in float16 training?
Tried just wrapping AdamW in it thinking it'll take care of scaling but the training doesn't improve after some steps (but model trained in float32 does train properly)
I checked Mixed precision policy API, examples, model.fit to see how it handles it but didn't understand and LossScaleOptimizer for mixed precision training in jax but did not find it.
Please include the details in the docs. Thanks

@SuryanarayanaY Please can you respond??? @sachinprasadhs could you please see this...

Hi @VachanVY ,
Are you using custom training loop or simple model.fit. AFAIK without custom training loop model.fit should take care of it. With custom training we need to do some extra steps as mentioned for Tensorflow backend. It seems documentation for this not yet available. I will cross check again and will update.
Thanks!

I'm using a Fully Custom Training Loop. Checked the Source Code felt like LossScaleOptimizer is taking take of scaling and maybe descaling
    def stateless_apply(self, optimizer_variables, grads, trainable_variables):
        if not self.built:
            raise ValueError(
                f"To call `stateless_apply`, {self.__class__.__name__} "
                "must be built (i.e. its variables must have been created). "
                "You can build it via `optimizer.build(trainable_variables)`."
            )
        finite = self.check_finite(grads)
        return ops.cond(
            finite,
            lambda: self._stateless_handle_finite_grads(
                optimizer_variables, grads, trainable_variables
            ),
            lambda: self._stateless_handle_non_finite_grads(
                optimizer_variables, trainable_variables
            ),
        )

https://github.com/keras-team/keras/blob/e6e62405fa1b4444102601636d871610d91e5783/keras/optimizers/loss_scale_optimizer.py#L103
    def _stateless_handle_finite_grads(
        self, optimizer_variables, grads, trainable_variables
    ):
        def upscale():
            mapping = list(zip(self.variables, optimizer_variables))
            with backend.StatelessScope(state_mapping=mapping) as scope:
                self.step_counter.assign(0)
                self.dynamic_scale.assign(self.dynamic_scale * 2.0)
            return [scope.get_current_value(v) for v in self._variables]

        def increment():
            mapping = list(zip(self.variables, optimizer_variables))
            with backend.StatelessScope(state_mapping=mapping) as scope:
                self.step_counter.assign_add(1)
            return [scope.get_current_value(v) for v in self._variables]

        mapping = list(zip(self.variables, optimizer_variables))
        with backend.StatelessScope(state_mapping=mapping):
            # Potentially upscale loss and reset counter.
            own_variables = ops.cond(
                ops.equal(self.step_counter, self.dynamic_growth_steps - 1),
                upscale,
                increment,
            )

            # Unscale gradients.
            scale = self.dynamic_scale
            unscaled_grads = [
                g if g is None else ops.divide(g, scale) for g in grads
            ]
            (
                new_trainable_variables,
                new_inner_variables,
            ) = self.inner_optimizer.stateless_apply(
                self.inner_optimizer.variables,
                unscaled_grads,
                trainable_variables,
            )

        new_optimizer_variables = own_variables + new_inner_variables
        return new_trainable_variables, new_optimizer_variables

@SuryanarayanaY Can you please mention atleast briefly about how to use it, it's a bit urgent.... Thanks.

@SuryanarayanaY It's been a week, could you please reply by telling me how to use it, moreover it's very important for training large models.

@fchollet Could you please look into this? Thanks.

Hi @VachanVY ,
Could you please submit a code snippet on how you have done custom training loop? May be it helps us. Thanks!

from my repo
@partial(jax.jit, static_argnums=-1)
def compute_loss(trainable_variables:list, non_trainable_variables:list, X_batch:Array, y_batch:Array, num_grad_accumalation_steps:int):
    logits, non_trainable_variables = model.stateless_call(
        trainable_variables,  non_trainable_variables,
        X_batch
    )
    loss = loss_fn(y_batch, logits)
    accuracy = get_accuracy(y_batch, logits)
    unscaled_loss = loss/num_grad_accumalation_steps
    scaled_loss = optimizer.scale_loss(unscaled_loss)
    return scaled_loss, (unscaled_loss, accuracy, non_trainable_variables)
grad_fn = jax.value_and_grad(compute_loss, has_aux=True)

@partial(jax.jit, static_argnums=-1)
def mini_step(train_state:Sequence[list], X_batch:Array, y_batch:Array, num_grad_accumalation_steps:int):
    trainable_variables, non_trainable_variables = train_state

    (_, aux), scaled_grad = grad_fn(
        trainable_variables, non_trainable_variables, X_batch, y_batch,
        num_grad_accumalation_steps
    )
    (unscaled_loss, accuracy, non_trainable_variables) = aux
    return scaled_grad, (unscaled_loss, accuracy), (trainable_variables, non_trainable_variables)

@jax.jit
def update_params(grads:list, trainable_variables:list, optimizer_variables:list):
    trainable_variables, optimizer_variables = optimizer.stateless_apply( # also handles scaled grads if LossScalerOPtimizer is used
        optimizer_variables, grads, trainable_variables
    ) # returns updated trainable_variables
    return trainable_variables, optimizer_variables


Handling of bots

Spunkybot doesnt seem to handle AI bot players (players with address "bot")
This creates a couple of issues.
Database is populated with bot players and their stats. - not needed / waste of space
Bots are included in team shuffles or team balancing (they should be ignored as they are placed in a specific team by the admin) i.e we dont want a game where its 4bots vs 4humans
players that teamkill bots (for valid reason i.e. to get the flag) are kicked from the server as bots will never "!FP"
there are probably other problems not yet found - essentially spunkybot should ignore bots and not count them as players.
the easiest way to identify them by rcon is their IP address will be "BOT"

Database is populated with bot players and their stats. - not needed / waste of space

no stats are stored until player registers, only the join date is stored, so yes some kB could be saved :-)

Bots are included in team shuffles or team balancing

in case the admin ensures that the same amount if bots are always in a fixed team, this may work.  so this could be a feature request

players that teamkill bots are kicked from the server

of course, it is the same behavior as the built-in friendlyFire feature. TK is TK. and there is still the automatic forgive timer, so in case you kill a bot just one or two times in a few minutes, nothing will happen.
how do you ensure that some idiots do not teamkill all bots all the time? from my point of view it makes no sense to allow TK of bots by default. there should be an option to enable if you allow TK of bots.

Also on my specific issue with bots (they change their names everytime they are added to the game) this means i have about 100+ users in the database that are current bots lol.
Yes I can see your point on TK and Shuffling. Its probably best to make it an option in the config how spunkybot should handle in game bots.

OMG :-) why are you adding 100 bots?... do you know that spunkybot has an addbot command?
The database exclusion can be done easily, so this will be added.
The shuffle command uses the rcon feature shuffleteams, so this cannot be controlled and I will not try to implement my own shuffle feature.
Allowing TK of bots can be implemented, the option to enable/disable this feature should also be simple to implement.

im not adding 100 bots im adding 2v2.  however each time they are kicked and re-added they come back with a new name and thus a new player number with spunkybot lol
Thanks for the other implementations :)


fix: Hover state of incoming connection fix

Description
Fixed hover state issue of incoming connection dropdown inside property pane
Fixes #8459
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually tested locally

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: bug-fix/8459-property-pane-hover-state

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
54.85 (0.01)
36.53 (0)
33.63 (0)
55.37 (0)

:green_circle:
app/client/src/pages/Editor/PropertyPane/PropertyPaneConnections.tsx
66.3 (0.71)
31.48 (0.57)
46.88 (1.43)
65.93 (0.71)

/ok-to-test sha=0886ec6


added generateTemporaryConfigurationFile option

putLibraryJarsInTempDir did not work for me. My project had to many -injars, not libraries.
This pull request introduces a new option generateTemporaryConfigurationFile that generates a temporary proguard configuration file that includes all arguments.
The pull request does not modify other options.
fixes #113

Thanks!


Training accuracy problem

Hello, thank you for releasing the code.
But according to the train.sh you provided, the accuracy of PSNR obtained by training the rain100H dataset is only about 23~24, and the SSIM is about 0.77. I don’t know what went wrong.
Can you give me some advice? Thanks again for your work

I'm sorry that I forgot to add the rainlayers for rainmix, now I added them into the rainmix folder. Maybe you need to redownload them.
I uploaded the pretrained models for SPA-data, you can test using these models.
Here are some tips which may help:
(1) For dataset rain1400, we trained 200~240 epochs to get the best model of v2. And we fine-tune on the pretrained model of v2 for about 40 epochs to get the best model of v3, and about 60 epochs to get the best model for v4. (We used smaller learning rate for fine-tuning)
(2) For dataset rain100H, we trained 3500~4000 epochs to get the best model of v2. And we fine-tune on the pretrained model of v2 for about 2500 epochs to get the best model of v3, and about 2400 epochs to get the best model for v4. (We used smaller learning rate for fine-tuning)
(3) For dataset rain100L, we trained about 4800 epochs to get the best model of v3, and we trained about 600 epochs to get the best model of v4.
(4) For dataset SPA-data, we trained about 351k iters to get the best model of v3, and we trained about 117k iters to get the best model of v4. (batch size is 16)

Hello, thank you for releasing the code.
But according to the train.sh you provided, the accuracy of PSNR obtained by training the rain100H dataset is only about 23~24, and the SSIM is about 0.77. I don’t know what went wrong.
Can you give me some advice? Thanks again for your work

I'm sorry that I forgot to add the rainlayers for rainmix, now I added them into the rainmix folder. Maybe you need to redownload them.
I uploaded the pretrained models for SPA-data, you can test using these models.
Here are some tips which may help:

(1) For dataset rain1400, we trained 200 to 240 epochs to get the best model of v2. And we fine-tune on the pretrained model of v2 for about 40 epochs to get the best model of v3, and about 60 epochs to get the best model for v4. (We used smaller learning rate for fine-tuning)

(2) For dataset rain100H, we trained 3500 to 4000 epochs to get the best model of v2. And we fine-tune on the pretrained model of v2 for about 2500 epochs to get the best model of v3, and about 2400 epochs to get the best model for v4. (We used smaller learning rate for fine-tuning)

(3) For dataset rain100L, we trained about 4800 epochs to get the best model of v3, and we fine-tune on the pretrained model of v3 for about 600 epochs to get the best model of v4.

(4) For dataset SPA-data, we trained about 351k iters to get the best model of v3, and we fine-tune on the pretrained model of v3 for about 117k iters to get the best model of v4. (batch size is 16)


If you add the same directory, deletion acts strange

I re-added a directory because I thought I hadn't added it.
There were two behaviors:
One, it re-added it.   Would think maybe should point out it's already there, but that's not a big deal.
What was weird was when there was two, when I deleted the 'new' one, it nuked the contents of the other one too, but didn't remove that.  So now i have an empty folder.

Thanks for reporting!


Add wheel/python-version/python-implementation/status badage for PyPI.

Please review it. Thanks.
Related Issues: https://github.com/badges/pypipins/issues/39 https://github.com/badges/pypipins/issues/37

@espadrine I modified the try.html and reverted the index.html.

Thanks a lot for contributing! I hope all is well on @kura's side.
(As a tiny extra, it would be fantastic if you'd use === instead of ==.)

@espadrine I pushed new commits.

10/10 will merge and prod.

Thank you!

It's live. Try it, tell me if there is a bug we didn't anticipate; I'll update the website in 24h to invite everyone to use it.

:+1:

Hello guys,
It seems like py_versions isn't working
https://img.shields.io/pypi/py_versions/Django.svg
For my project
https://img.shields.io/pypi/py_versions/myql.svg

Thanks

@josuebrunel https://img.shields.io/pypi/pyversions/Django.svg (without the underline) works here.

@tonyseek thanks a lot. Great job :+1:

https://github.com/tonyseek/shields/commit/dee58b43c459eb8cc46f5bb780340657996c156a is a temporary commit :-)

Great work, thanks.
Any chance to add a replacement for the format badge (somewhat more informative than wheel: yes/no)?
And maybe make the version badge green (red looking like a warning)?

@xflr6 yes, that would be great! What did it look like? format | wheel etc.?

Yes, the best available format from wheel, source, or edge (red, yellow, green).

In my opinion keeping wheel be standalone may be better, because it is a encouraged format rather than egg(outdated) and source(almost all packages have it). :whale:

Further information on how to detect wheel / egg: https://github.com/kura/yarg/blob/master/yarg/package.py#L241

@xflr6 this should work: https://img.shields.io/pypi/format/graphviz.svg
As usual, I'll update the website in 24h.

Great, thanks a lot!
As for the color of the version badge, I just realized that mine are red because I conservatively keep my packages  in the 0.x versions. I see the point, but then I would like to second #349 for adding an optional parameter to override the color (at least for the version badge so we have full backwards-compatibility with pypip).

@xflr6 I wish to keep backwards-compatibility with pypip. Can you specify the difference between the current state and pypip?

Sorry this did not come through: The version badge was green regardless of the version (so a color-overriding parameter would make it possible to make the badge look exactly like before).


Nick: Watch vxnet.pro

Nick requests the watch of the watch_keyword vxnet\.pro. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

vxnet\.pro has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cocomac in Charcoal HQ


TEIIDTOOLS-904 running the websocket over tomcat

@blafond @rareddy this took a some more playing around, but it does seem to create the endpoint of of the existing embedded tomcat instance. I can see it come up in the integration test under ws://localhost:port/teiid-ddl-language-server - where port is the standard randomly assigned tomcat port.  We should probably consider taking teiid out of the endpoint name.

When you say random port because you did not assign the defined port and used 0 as to randomize right? to enable the call through the OAuth proxy we need some kind of context, it can be "/dv/lsp" or "dv-lsp" where the former would not require any changes in Syndesis Operator whereas later would need.

When you say random port because you did not assign the defined port and used 0 as to randomize right? to

No, I literally mean when running one of the IntegrationTest* classes which uses @SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT)

So, in the end the only question I have is do we need a separate port or can we run over existing one?

I think my initial comment made this confusing.  This runs over the same port as all of the http traffic.

nice :+1:

@shawkins So other than rebuilding DV (./tools/bin/syndesis build -m dv -d -i -f) I'll just need to discover the root URL and append the teiid-ddl-language-server ( and possibly remove teiid from it) ?

discover the root URL

Yes the root dv url now exposes that endpoint, which yes we can consider renaming.


SyncAccelerator is throwing with missing app_id

SyncAccelerator keep through error despite having all details. Everything else is working fine.
Error message coming;
Error: Input required and not supplied: app_id

@sebassem & @JamJarchitect can you take a look here

@spotakash thanks for catching this. We just submitted a PR to solve this issue. Please fetch the latest and give it a go and let us know if its resolved.

It is still failing
Run tibdex/github-app-token@v1
with:
github_api_url: https://api.github.com/
repository: spotakash/cgy-azgoviz
env:
remote_repository: Azure/Azure-Governance-Visualizer-Accelerator
AcceleratorVersionPath: https://raw.githubusercontent.com/Azure/Azure-Governance-Visualizer-Accelerator/main/version.json
branch_name: pull-latest-upstream-release
pr_title: New AzGovViz Accelerator GitHub Release Available
pr_body: This is an automated 'pull_request' containing the latest release from the upstream repo.
Please review the 'files changed' tab to review changes.
Error: Error: Input required and not supplied: app_id

@spotakash You would have to get the new changes to fix this issue, either create a new teamplate from the repo or simply replace the syncAccelerator workflow code from this repo

Tried replace syncAccelerator workflow code (however I already git fetch already)
Now, it is failing at Add Files, Commit and Push
1s
Run currentVersion=$(jq -r .AcceleratorVersion version.json)
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    69  100    69    0     0    141      0 --:--:-- --:--:-- --:--:--   141
100    69  100    69    0     0    141      0 --:--:-- --:--:-- --:--:--   141
Pushing changes to origin...
The following paths are ignored by one of your .gitignore files:
releases
hint: Use -f if you really want to add them.
hint: Turn this message off by running
hint: "git config advice.addIgnoredFile false"
Error: Process completed with exit code 1.

@spotakash did you fork or create a new repo from template?  If you created a new template , please replace the latest yaml for syncAccelerator or if you forked please git fetch now. This error/warning should go away now, please let me know if it works

It was new repo from template. I replaced syncAcceletor with code you pointed out, above fail is after that.
I don’t want to create another repo from template I have to start from scratch and fix app and secrets.

It was new repo from template. I replaced syncAcceletor with code you pointed out, above fail is after that. I don’t want to create another repo from template I have to start from scratch and fix app and secrets.

understood, I pushed some fixes today. Please try to replace the workflow code and let me know the result


Use retrolambda on some gradle tasks

Is there a way to apply retrolambda only to one of the tasks? I want to provide both a jdk8 and jdk7 build of my library, and I would like to create separate tasks for those builds.

Not really documented but you can call the retrolamda task directly. https://github.com/evant/gradle-retrolambda/blob/master/gradle-retrolambda/src/main/groovy/me/tatarka/RetrolambdaTask.groovy

@evant Looks like I finally have an excuse to learn Groovy, thanks for the help!


chore: update fluvio to 0.10.8

rustls update seems to require some code/or deps changes

closing in favor of https://github.com/infinyon/mqtt-connector/pull/37


Best place to host my dapp?

Where do you recommend hosting my dapp. What services am I looking for?

heroku


Processes started with bash file flutter/bin/dart do not terminate children processes when killed

which dart on my machine points to path/to/flutter/bin/dart. I was writing a test in DDS and attempting to start a process:
final process = await Process.start('dart', args);

Since dart points to flutter/bin/dart, this actually starts a bash process, not a dart process. Later in my code, I attempted to kill this process: process.kill(); and was checking that other parts of the ecosystem responded accordingly to the process being killed (specifically, I was verifying that DevTools would disconnect). Calling process.kill() killed the bash process, but not any subprocesses that were started by the bash process (i.e. the dart process that DevTools should be responding to). I expect any user who points their Dart to flutter/bin/dart and is trying to spawn a process will hit this issue.
@bkonyi and I spent time debugging this this morning. Please add any additional details or thoughts.

Hi @kenzieschmoll, Thanks for filing the issue. Would it be possible to share a minimal reproducible code?
This looks related to https://github.com/flutter/flutter/issues/98435

It looks like this is blocked by https://github.com/dart-lang/sdk/issues/22470

Totally thought I followed up on this, but I guess I didn't. This isn't related to dart-lang/sdk#22470 but is an issue with the wrapper scripts we have around the standalone Dart VM in the Flutter SDK. We should be execing the VM from within those wrappers, but instead we're spawning a child process. It's a rather simple fix IIRC.

Totally thought I followed up on this, but I guess I didn't. This isn't related to dart-lang/sdk#22470 but is an issue with the wrapper scripts we have around the standalone Dart VM in the Flutter SDK. We should be execing the VM from within those wrappers, but instead we're spawning a child process. It's a rather simple fix IIRC.

Ahh cool

@gspencergoog any reason not to call exec from our bash entrypoints rather than spawning a subprocess for flutter and dart?

No, no reason at all.  That's the right thing to do.

Labeling it as applicable based on the discussion / thread above.

No, no reason at all. That's the right thing to do.

cool, I can open a PR for that

I can confirm this is still an issue on windows with the batch scripts used.

@slightfoot Could you please file that as a separate issue?  since this thread has been locked and limited to collaborators only.

I can confirm this is still an issue on windows with the batch scripts used.

I agree with @maheshmnj, please file a new issue for that; this issue was specifically for bash entrypoint.


keyword in filtering column not showing when state save is true and user reload page

Describe the bug
when state save is true and user search by any column in individual search and then user refresh it, the content of table showing with filtered data but the keyword not showing up in input type of column,
so if we want to showing up all data we must memorize which search column is typed and then press [backspace[]

Hi @nazerulgit
It is fixed with v.3.6.1 https://github.com/ekondur/DatatableJS/releases/tag/v3.6.1
Please update your package.
Thanks for your contribution

yes sir, allready fixed in 3.6.1 version
thanks sir


Backend-api-defination module Does not exist

In backend-infrastructure/pom.xml

com.tribune
backend-api-definition

backend-api-definition module is not present . Can you add it?

Sorry I've neglected this repo but I'll do it soon ISA.

@sajal-halder I've added the api-definition module along with some notes:

This module includes files generated by open-api.
Treated as part of the infrastructure layer.
It's an optional feature, so there's no need to utilize it currently.
---- It's not necessary at the moment, but you can see how it's implemented/considered in the project.


Added Debian changelog installation step for Debian package generation

@jet47 please look at it.

:+1:


Better Respect Package installation sources

Description of the new feature / enhancement
Currently winget list seems to list all installed applications, and in many cases this is great.
However it is not currently respecting that other tooling, like chocolatey, SCCM, intune or other package management solutions, may be in use for management of applications in estates already (like it is in mine) or that the application may have been manually installed as part of a short functionality test & should not become a winget manageable application which may be internal software or may be software installed direct from the web to have a quick nosy at it & see if it is worth keeping longer term.
It therefore would be handy to be able to specify for winget to only return applications that have been installed by it, so that any upgrade cycles that orgs and users have in place aren't fighting with winget & importantly if an org decides they are limiting the roll out of versions of software like Visual Studio or Office or other inner sourced version that need security team sign off & that process to allow use of newer versions isn't getting bypassed by how winget is currently blindly assuming that any installed application that matches a package listed in the winget packages repo is fair game for being auto managed by winget going forward.
Adding this feature will help IT Admins, Developers & Security teams in being able plan out whether they are going to migrate application management entirely to winget or keep what they currently have & allow winget for new packages & keep existing ones in their tooling of choice. Especially if this is a mixed environment with other Microsoft tooling like Intune, or SCCM, PowerShell DSC, Azure Machine Config or other 3rd party tools.
This was found as part of me trying to look into what was happening with how PowerShell can be released & available on winget and unable updated due to a package ID mismatch thanks to a previous update via Microsoft Update as discovered in this PowerShell issue & noticing that all my chocolatey installed applications show, whether or not there is an update available on winget or not.
#1488 - I think is a potential starter for this with the priority scale however there will be times when you want to set a per package ID source priority , example being you may be testing out an internal vendor build of an application to verify a bug fix prior to them releasing to either winget or their main package source feed.
Proposed technical implementation details

[ ] implement a InstalledByWinget attribute for packages
[ ] on find a package should be returned with a warning note of not installable via winget if the ID matches the install was via another source that winget cannot pass an install request off to
[ ] on install a package should check if it is managed elsewhere and throw an error to the user if install is attempted unless admin settings allow the user to override the previous installation source (I.e to allow winget to manage it)
[ ] on listing installed packages, it should check this store, prior to mapping the source as winget & if not via winget, should return unknown, unless winget adds ability for other package management tools to show as sources
[ ] on upgrade, a package that was installed via other means but is available via winget should prompt for user input on whether this should now be managed by winget, unless it is already deemed managed via another package manager & ideally delist it as a managed package from the other package manager as not to have conflicts between them
[ ] enable option to delist from winget a package that was once installed by it, as it has a self updating mechanism that is already in use so no longer needs maintaining by winget (should stay in the store as having initially been installed by winget)

This duplicates --pin functionality. Basically, you're requesting a way to pin packages in the package manager that weren't installed by it.

There is a lot to unpack in this feature request. I appreciate the time it took to articulate the desired behaviors and the scenario where they apply. I'll put some initial thoughts below:
Enterprise customers can stand up their own "private" REST source for WinGet packages and disable the default sources to ensure WinGet is only updating/installing packages coming from the configured source(s).
WinGet does have a local tracking database for packages installed by WinGet, but it's currently only used to help with correlation to the source a WinGet package came from.
The WinGet List command is displaying all installed packages and attempts to correlate any installed package against what is available in any configured source.
WinGet does not prevent users from downloading and installing software using other means. Some packages also have their own mechanisms for auto-updating software when new versions become available. WinGet does not block any of those mechanisms. There would be some interesting edge cases where WinGet may not have been used for an initial install or an intermediary update so reasoning about "installed by WinGet" might be a bit challenging from a UX perspective.
It is possible to "Pin" any packages that WinGet should not attempt to upgrade, but this also requires those packages to be available in one of the configured sources.

(We may get confused if we call Chocolatey, SCCM, Intune, etc. "installation sources" because winget has its own concept of a "source". I'd call them "package managers".)
We may be able to distinguish apps installed by specific package managers by data in the ARP. If we can do that, then we probably should leave them alone because we can tell we don't know how to handle them. I don't know if there is any such data but we could look into it.
For other package managers that, like winget, basically run an existing installer, I don't know if we can tell the difference between a manual installation and an installation through that other package manager. In that case the pinning may work.
Maybe we could have an option to not try and correlate ARP data with available packages, and instead just use the tracking catalog. That would limit a lot what we can do, but seems like it may be desired in some cases.

We may be able to distinguish apps installed by specific package managers by data in the ARP

There is no standard for package managers to mark themselves as the handler of installed applications in ARP nor other places.
Microsoft could of course define such a value if they wanted to.


Wrong argument type in python example code in AWS Classic/apigateway/RestApi

I'm trying to create an AWS rest api gateway with the python example code here.
And I found that the types of aws.apigateway.RestApiEndpointConfigurationArgsseems to be wrong.
endpoint_configuration=aws.apigateway.RestApiEndpointConfigurationArgs(
    types=["REGIONAL"],
))

According to this document, the type of types should be str instead of list.
After chaning that line of code to types="REGIONAL", pulumi correctly displays a preview when running pulumi up.
Issue details

Steps to reproduce

Run pulumi up with the following python example code.

import pulumi
import hashlib
import json
import pulumi_aws as aws

example_rest_api = aws.apigateway.RestApi("exampleRestApi",
    body=json.dumps({
        "openapi": "3.0.1",
        "info": {
            "title": "example",
            "version": "1.0",
        },
        "paths": {
            "/path1": {
                "get": {
                    "x-amazon-apigateway-integration": {
                        "httpMethod": "GET",
                        "payloadFormatVersion": "1.0",
                        "type": "HTTP_PROXY",
                        "uri": "https://ip-ranges.amazonaws.com/ip-ranges.json",
                    },
                },
            },
        },
    }),
    endpoint_configuration=aws.apigateway.RestApiEndpointConfigurationArgs(
        types=["REGIONAL"],
    ))
example_deployment = aws.apigateway.Deployment("exampleDeployment",
    rest_api=example_rest_api.id,
    triggers={
        "redeployment": example_rest_api.body.apply(lambda body: json.dumps(body)).apply(lambda to_json: hashlib.sha1(to_json.encode()).hexdigest()),
    })
example_stage = aws.apigateway.Stage("exampleStage",
    deployment=example_deployment.id,
    rest_api=example_rest_api.id,
    stage_name="example")

Expected:
A preview of the update should be displayed.
Actual:
The following error occurs:
error: Program failed with an unhandled exception:
error: Traceback (most recent call last):
    File "/usr/local/bin/pulumi-language-python-exec", line 107, in <module>
    loop.run_until_complete(coro)
    File "/Users/my_name/opt/miniconda3/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
    return future.result()
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/stack.py", line 110, in run_in_stack
    await run_pulumi_func(lambda: Stack(func))
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/stack.py", line 45, in run_pulumi_func
    await wait_for_rpcs()
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/stack.py", line 94, in wait_for_rpcs
    raise exception
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/resource.py", line 447, in do_register
    resolver = await prepare_resource(res, ty, custom, remote, props, opts, typ)
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/resource.py", line 105, in prepare_resource
    serialized_props = await rpc.serialize_properties(props, property_dependencies_resources, translate, typ,
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/rpc.py", line 149, in serialize_properties
    result = await serialize_property(v, deps, input_transformer, get_type(k), keep_output_values)
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/rpc.py", line 288, in serialize_property
    is_known = await output._is_known
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/output.py", line 158, in run
    is_known = await self._is_known
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/rpc_manager.py", line 65, in rpc_wrapper
    result = await rpc
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/output.py", line 94, in is_value_known
    return await is_known and not contains_unknowns(await future)
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/output.py", line 94, in is_value_known
    return await is_known and not contains_unknowns(await future)
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/output.py", line 94, in is_value_known
    return await is_known and not contains_unknowns(await future)
    [Previous line repeated 15 more times]
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/resource.py", line 447, in do_register
    resolver = await prepare_resource(res, ty, custom, remote, props, opts, typ)
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/resource.py", line 105, in prepare_resource
    serialized_props = await rpc.serialize_properties(props, property_dependencies_resources, translate, typ,
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/rpc.py", line 149, in serialize_properties
    result = await serialize_property(v, deps, input_transformer, get_type(k), keep_output_values)
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/rpc.py", line 329, in serialize_property
    return {
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/rpc.py", line 330, in <dictcomp>
    k: await serialize_property(v, deps, input_transformer, types.get(k), keep_output_values)
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/rpc.py", line 193, in serialize_property
    element_type = _get_list_element_type(typ)
    File "/Users/my_name/opt/miniconda3/lib/python3.9/site-packages/pulumi/runtime/rpc.py", line 106, in _get_list_element_type
    raise AssertionError(f"Unexpected type. Expected 'list' got '{typ}'")
AssertionError: Unexpected type. Expected 'list' got '<class 'str'>'
error: an unhandled error occurred: Program exited with non-zero exit code: 1

Seems an issue in the TF example: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/api_gateway_rest_api

Duplicate of https://github.com/pulumi/pulumi-aws/issues/2033


Support "value" in guard of Python for-each statements

Checklist

[ ] I have added tests
[ ] I have updated the docs and cheatsheet
[ ] I have not broken the cheatsheet

Make sense? I should prob do this for TS as well?

On the question of whether we should do this, my 2c is that it would be useful to try to explain, in some vague human-oriented way, what "name" and "value" mean.
I still don't have a sense for it; I can't reliably predict which I should expect to show up where.
For example, in
for aaa in bbb:
  pass

does name fine refer to aaa? (value fine refers to bbb, I believe.) If not, why not? If so, why?

yeah I think "name" should def be aaa here if bbb is value. I can't say I have a super precise definition for what value should be, it just felt intuitively right. I'm not sure we need to be able to precisely state it, because a) they can see it with the visualizer, and b) it's gonna be controlled by system I in the end anyway. But I'm probably just making excuses 😄. Maybe we should discuss?

Fwiw the field names they're using (left and right) are the same we expect for name / value pairs in assignments, so I think that's a good sign. And the "name" here supports destructuring, which we support with names in assignment statements.
Maybe a "value" is a source from which data flows? Eg return value flows out of function, assignment value flows into the variable, etc

I like this change and would like to see it for more languages if you have the time. Personally I feel that typescript and java that has basically an identical syntax should support this as well.

Cool. Do you agree the domain should be just the guard, or do we want the whole loop?

That sounds reasonable, but is also a bit inconsistent with how we do name for functions for example.

I dont have a strong feeling one way or the other. My thinking was that it doesn't feel strongly enough like a value / name that we'd want users to get trapped there from anywhere in the body. But agreed it's a bit inconsistent

Ok I added Typescript, but not Java, as Java name and value scopes aren't migrated, so I'm holding off, as I don't want to mess with legacy matchers, and we prefer languages be migrated by people who use them


Add --host flag for backup command

Please add --host flag to backup command to be used with --stdin flag.
This is useful when pulling/pushing files for backup from other hosts. See workarounds mentioned in #784. If a backup from another host was made without this flag, then forget command can't be used reliably.

And no, unfortunately one couldn't set a hostname with an envvar. [Go gets it directly from the kernel at least in Linux.](https://github.com/golang/go/blob/964639cc338db650ccadeafb7424bc8ebb2c0f6c/src/os/sys_linux.go#L9)

Good idea, we can certainly add such a parameter. Thanks for raising this issue!

Is there any reason why you wouldn't want the parameter name to be consistent with other commands, i.e. "--host"? I know it would help to clean up my scripts a little.


Cannot find "Full Stack Cloud Application"

Where I had this trouble
Exercises>Getting Started - Setting up your Development Environment>Creating the Development Space>Enter a name for your development space and select application profile Full Stack Cloud Application.

The content of trouble
I cannot find Full Stack Cloud Application.

(Maybe is this the privilege of the participant of the workshop?)
Note
I did not register this workshop.
I tried this exercise from the session catalog.

I created SCP trial account and subscribed BAS before start this exercise.

I chose SAP Cloud Business Application instead and could reach exercise 7.

The dev spaces names  shown in the exercises were already available in the dedicated TechEd SAP Business Application Studio instance and are expected to roll out to production end of this week. Until then, you can use SAP Cloud Business Application in your own trial account in order to complete the exercises.


Tempfiles cause errors in gv.vim

Issue

With gv.vim and fugitive installed:

Open a file in a git workspace
:GV? i
select item in quickfix-list
press o

 Neomake: [12.-:-] file is not readable (fugitive:///home/~~~~/Studium/Thesis/Veritask/.git//572bb4d80d15290a51bce2fe1d21d3736c561e4c/app/controllers/Tasks.scala)
 E926: Current location list was changed

Expected behavior
Step 5 should open the file
With tempfile enabled it works for the first item.
Output from (verbose) NeomakeInfo
Neomake debug information
Async support: 1
Current filetype: scala
Enabled makers
For the current filetype (with :Neomake):

scalac

args: ['-Ystop-after:parser']
auto_enabled: 1
errorformat: '%E%f:%l: %trror: %m,%Z%p^,%-G%.%#'
exe: 'scalac'

scalastyle

args: []
auto_enabled: 1
errorformat: '%trror file=%f message=%m line=%l column=%c,%trror file=%f message=%m line=%l,%tarning file=%f message=%m line=%l column=%c,%tarning file=%f message=%m line=%l'
exe: 'scalastyle'
ERRORS:
maker's exe (scalastyle) is not executable.
NOTE: you can define g:neomake_scala_enabled_makers to configure it (or b:neomake_scala_enabled_makers).

For the project (with :Neomake!): None.
NOTE: you can define g:neomake_enabled_makers to configure it.
Default maker settings:

remove_invalid_entries: 0
buffer_output: 1

Settings
g:neomake_error_sign = {'texthl': 'NeomakeErrorSign', 'text': 'x'}
g:neomake_info_sign = {'texthl': 'NeomakeInfoSign', 'text': 'i'}
g:neomake_javascript_enabled_makers = ['standard']
g:neomake_message_sign = {'texthl': 'NeomakeMessageSign', 'text': '>'}
g:neomake_open_list = 0
g:neomake_place_signs = 1
g:neomake_vimwiki_enabled_makers = ['mdl']
g:neomake_vimwiki_mdl_maker = {'errorformat': '%f:%l: %m'}
g:neomake_warning_sign = {'texthl': 'NeomakeWarningSign', 'text': '⚠'}

Windows: 0
[shell, shellcmdflag, shellslash]: ['/usr/bin/zsh', '-c', 0]

:version

NVIM v0.2.0-dev
Build type: RelWithDebInfo
Compilation: /usr/bin/x86_64-linux-gnu-gcc -g -O2 -fdebug-prefix-map=/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -D_GNU_SOURCE -I/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1/build/config -I/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1/src -I/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1/.deps/usr/include -I/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1/.deps/usr/include -I/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1/.deps/usr/include -I/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1/.deps/usr/include -I/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1/.deps/usr/include -I/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1/.deps/usr/include -I/usr/include -I/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1/build/src/nvim/auto -I/build/neovim-jbdVy6/neovim-0.1.7ubuntu1+git201703221849+3251+23~ubuntu16.10.1/build/include
Compiled by root@lgw01-06

Optional features included (+) or not (-): +acl   +iconv    +jemalloc +tui
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

With tempfile enabled it works for the first item.

I think that's what the tempfile feature is about then.
I can see though that you should not see an error when autolinting, but currently we do not distinguish between running Neomake manually or through an autocommand.
https://github.com/neomake/neomake/pull/1167 is meant to improve this, so that you would not configure an autocommand yourself and/or we would detect if being run from an autocommand (https://github.com/neomake/neomake/issues/1171).
Can this issue be closed then for now, i.e. have it understood correctly?

The "E926: Current location list was changed" should not happen though, if it is caused by Neomake it needs to be fixed: it should not change the location list if the file is skipped.
And even of it is not skipped, it would replace the existing location list then?!

With tempfile enabled it works for the first item.

I think that's what the tempfile feature is about then.

For the next files it gives the same error and with and without tempfiles enabled, it breaks the quickfixlist for selecting a revision of the file.
Maybe the issue is that neomake triggers on every scala buffer, even if it is a revision from the git tree?

How do you run Neomake? (i.e. how have you configured the autocommands)?
If you would run it only on BufWritePost this would not happen I suppose.
I could imagine that Neomake would not take over a location list that exists already, e.g. based on getloclist(0, {'all': 1}) being empty or something similar.
Then however, errors would not be displayed.
As for your current setup, you could use a function to call Neomake, and there check if it should run:
function! MyNeomakeCheck()
    let locinfo = getloclist(0, {'all': 1})
    if has_key(locinfo, 'winid')
        if getwinvar(locinfo.winid, 'quickfix_title') == 'o: open / o (in visual): diff / O: open (tab) / q: quit'
            return
        endif
    endif
    Neomake
endfunction
augroup my_neomake
    au!
    au BufWritePost,BufWinEnter * call MyNeomakeCheck()
augroup END

This will only skip Neomake in case the gv.vim window is open.
You could use just title instead, but it requires https://github.com/junegunn/gv.vim/pull/36.

Maybe the issue is that neomake triggers on every scala buffer, even if it is a revision from the git tree?

More or less, but I consider it to be a feature that temporary/virtual buffers like that can be linted, e.g. when using :Gdiff etc.
With #1171 this would be silent in case you do not enable tempfiles, and with a custom function like above you could also skip certain files, e.g. based on the bufname.

There have been made improvements in this regard.
Please re-open with more information if it is still an issue for you.


fix: make DesktopLeftNav not overflow screen

Unfortunately I wasn't able to fix #729 completely (details in issue comment).
This fixes the part where the DesktopLeftNav overflows the screen and creates a blank space at the bottom
Before:
https://github.com/bluesky-social/social-app/assets/5601392/198509fa-9cf9-424d-a087-11a80380e78c
After
https://github.com/bluesky-social/social-app/assets/5601392/9736b3c2-9f0f-43f0-baaf-01c75bc164eb

It should be auto, my bad


Stock Details that we collect from different camps

A section provide detail information about the items that we collect from different camps
Like how many items are available and what more items are needed in the camps.
In this way we can control the stock items that people are providing to flood affected regions.
The volunteers in the camps update the stock details on the site and we can share this info with other camps and in other districts.
When an particular items are transferred or received to the destination place we can update the same on the site.
Status will be like
eg: Need 1000 sanitary pads at XXX village.
4000 sanitary pads are available at YYYY camp
1000 sanitary pads is transferred via Volunteer Head to the XXX village
1000  sanitary pads delivered at XXX village
And we can inform people that we need X numbers of particular items.
Please let me know if this issue is reasonable and we can start working on that ASAP.
Also currently AnboduKochi volunteers are collecting and providing relief items from various location in Ernakulam. We can take help from them about the stock details.
Thanks

In production now


trigger default path from the api

so other functions can trigger a 404 response if no paths match. Related: https://github.com/yoshuawuyts/methodist/issues/1

Api should probably be .default(params)

Closed in GH-27


[Add]: Relationship between StorageClass and other k8s components

Notes for Reviewers
This PR fixes #

Adds Relationship between StorageClass and other k8s components.

Working proof of this PR:
https://github.com/meshery/meshery/assets/128715606/c284c457-acc6-4434-9c89-1e5156fb5192
Signed commits

[x] Yes, I signed my commits.

@pandeyshubham03 would you like to offer review here?

I currently have the read-only access to the spreadsheet. Kindly allow me to edit it in order to make necessary changes.

Note: Spreadsheet updated.  ✅


Test ticket for Github FS Integration

 FreshService Ticket ID: 118 FreshService Ticket Agent: Sai Madhan K FreshService Ticket Agent Email<EMAIL_ADDRESS>Ticket Priority: Low FreshService Ticket Description: This is just a test ticket for Github FS Integration.Ticket attachments : 1.Freshservice-logo.png

Agent Sai Madhan K linked FreshService ticket 118 to this issue

Agent Sai Madhan K unlinked FreshService ticket 118 from this issue


[BUG] Some characters, like § or ° can't be input into our shell

Fixed since 054ab59c3e4942327c17bc4fe948733ec5b8be1a.
Merged with #164


Add a shorter name too?

Please consider adding a shorter name too in the /bin , e.g. lb .
( Maven also has mvn :) ).

I aliased it to lzb. I'm not sure whether to favour adding an explicit lzb script or relying on the user to create their own shortcuts.

@pledbrook I think in order to be consistent with reason and name of the project, a very short would be mandatory :) .
Aliasing does not work on Windows very easily, so in order to be consistent across platforms, it would be easier to have the files duplicated with the shorter name in /bin.


Refactor

Refactor with the goal of abstracitng the sprockets.mixins.amqp.AMQP class out of the request handler
Add an instance of the AMQP class on the Tornado application
Trim down the internal connection flow

very nice ... especially since I need AMQP publishing outside of a tornado.web.RequestHandler ;)


Spi api fix

I don't know how this vendor attribute came in. I don't remember agreeing on this, moreover for something which breaks struct alignment and for a feature that is useless afaik: if CS (aka nss in stm32's vocabulary) is handled externally: the driver knows about it through the cs pointer in config, so it can handle it accordingly.

The behaviour is not only related to CS GPIO, since it should do-able to avoid CS completely and only use the MISO/MOSI/CLK signals.
But the feature was used to enable CS-less slave SPI transfers since in the general use-case, the CS is taken from the pad, and if CS is not used all transfers will fail.
Finally having a vendor attribute in the configuration is mandatory for such corner use cases...

No I am certain we can avoid a vendor specific attribute.
In most controllers actually, there is no control over the logic of CS at all, and wire it up or not: the transfer will work anyway. If you don't care of any data back actually you can even wire only MOSI/CLK.
If really this stm32 controller needs this NSS IGNORE, then let's enable the possibility to pass a cs pointer, with a NULL gpio_dev, make spi_context handling this case. Done.
We should always avoid SoC/Arch/vendor specific in these generic API. I am using SPI quite a lot in my drivers, and I really don't want to have SoC/Arch/vendor stuff controlled over #ifdefs there just because we fail to find a generic way. Also, by experience, the tiny bit of  "flexibility" you offer to users about that, and they will just use it as crazy, nullifying the generic aspect of the API. Fixing that afterwards is painful. We still have this legacy SPI API lurking around for instance...

Ok then for this specific use case

@tbursztyka : I guess you'll need to update drivers/bluetooth/hci/spi.c:133 as well to remove vendor field.
Last, we'll be able to update code under CONFIG_BT_SPI_BLUENRG to take advantage of spi_context_.. (not required to do it within current PR, though).

@erwango : good point, missed that one. PR updated


For a coding question: about parser

I would like to ask, in parser, is "shecc" a directly generated instruction set linked list sequence? I don't seem to have found the relevant code for AST. If so, please point out.
If possible, may you comment on each structure and field in def.h?
Heartfelt thanks.

By the way, the book Parsing Techniques: A Practical Guide 2/e offers valuable insights into the inner workings of compilers and is a highly recommended resource for those interested in learning more about this topic.

Thanks. I'll read this.


Step based data is not available in follow steps

Hi there.
I was trying to use step-based options to add/remove form fields based on the data from a former step.
Dumping $formData in the flow-class revealed that the entity is still the same as in the beginning. Shouldn't this be done?

Could you use some code to explain what you are trying to do? Where do you dump $formData?


[AllSidesBridge] New bridge

AllSides is a news aggregator that provides balanced news based on media bias ratings. I made a bridge to follow their headline roundups and kept it extensible in case anyone wants to follow other aspects of their site. I only included the AllSides writeups, since it would be tricky to display the article excerpts in a feed reader.

nice


bugfix: make the PullImage test util work

Ⅰ. Describe what this PR did
The post method of pullImage will hijack the connection so that the HTTP header always contains 200. It means that we cannot just check the HTTP status. We should read all the data bytes from server.
Ⅱ. Does this pull request fix one issue?

NONE
Ⅲ. Describe how you did it
Read the bytes from server and check the error in the jsonstream.
Ⅳ. Describe how to verify it
Remove the command.PouchRun("pull", busyboxImage) in the beginning of test.
Ⅴ. Special notes for reviews
It is very important to make CI happy

LGTM

Codecov Report

Merging #1386 into master will decrease coverage by 3.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
- Coverage   38.61%   35.07%   -3.54%
==========================================
  Files         248      254       +6
  Lines       16512    17795    +1283
==========================================
- Hits         6376     6242     -134
- Misses       9318    10737    +1419
+ Partials      818      816       -2

Impacted Files
Coverage Δ

cri/v1alpha1/cri_utils.go
0% <0%> (-29.32%)
:arrow_down:

cri/v1alpha2/cri_utils.go
0% <0%> (-28.42%)
:arrow_down:

apis/server/utils.go
61.11% <0%> (-5.56%)
:arrow_down:

ctrd/watch.go
69.81% <0%> (-3.78%)
:arrow_down:

daemon/mgr/network.go
68.3% <0%> (-0.5%)
:arrow_down:

daemon/mgr/container.go
49.35% <0%> (-0.09%)
:arrow_down:

cri/src/cri_types.go
0% <0%> (ø)

cri/src/cri_network.go
0% <0%> (ø)

cri/src/cri.go
0% <0%> (ø)

cri/src/cri_stream.go
0% <0%> (ø)

... and 3 more


move part of tests to scope style

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Codecov Report
Patch coverage has no change and project coverage change: -25.22 :warning:

Comparison is base (3958d05) 66.39% compared to head (2182e21) 41.18%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #792       +/-   ##
===========================================
- Coverage   66.39%   41.18%   -25.22%
===========================================
  Files         229      171       -58
  Lines       22827    18888     -3939
===========================================
- Hits        15157     7779     -7378
- Misses       6881    10773     +3892
+ Partials      789      336      -453

Flag
Coverage Δ

?

go-1.17.x
?

go-1.19.x
41.18% <ø> (-25.02%)
:arrow_down:

go-1.20.x
?

integration
?

macOS
41.18% <ø> (+0.15%)
:arrow_up:

ubuntu
?

unit
41.18% <ø> (+0.07%)
:arrow_up:

windows
?

ydb-22.5
?

ydb-23.1
?

ydb-23.2
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 181 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[TEST] Add back necessary tests for deprecated settings that are replaced during applying inclusive naming

Description
Add some unit tests for validating the backwards compatibility of deprecated master node role and cluster.initial_master_nodes setting.
All the added tests are modified copies of existing tests.
The old node role/setting name in tests were replaced by new node role/setting name in PR #2424 and #2451, and in this PR I added some duplicate tests for the deprecated node role/setting name.
Reason:
To avoid the backwards compatibility of the deprecated setting is broken by mistake during the process of replacing non-inclusive terminology.
There was an issue https://github.com/opensearch-project/OpenSearch/issues/2769 that shown a fault caused by PR https://github.com/opensearch-project/OpenSearch/pull/2463 (Deprecate setting 'cluster.initial_master_nodes' and introduce the alternative setting 'cluster.initial_cluster_manager_nodes' ).
Issues Resolved
Resolve https://github.com/opensearch-project/OpenSearch/issues/2805
Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I'm not sure if it's necessary to backport to 2.0 branch, because there is no fault found during adding the tests.

@kartg and @dblock , thank you for your review! I have resolved the above comments, could you please have a look at again?


feat(app-layout): add

I know we have agreed on the slotted version, but as it can be seen now it requires following components to be bundled with app layout component:

Drawer
Nav
NavContent
Overlay

So it might be something we should reconsider in the next iteration...

@hopkins-tk please can you expand your thoughts on bundling other elements? I thought that we did discuss this issue and agreed that this won't be problem when developer will use blaze-elements bundle where it should get deduplicated.

@elmariofredo you are right - that's why I just put it so that we can discuss it, but leave it now as is...
I am not worried about size of the produced bundle, but the number of necessary classes/files in the source code...
But again for the fist iteration it is fine.


Enforce levelization in libxrpl with CMake

Adds two CMake functions:

add_module(library subdirectory): Declares an OBJECT "library" (a CMake abstraction for a collection of object files) with sources from the given subdirectory of the given library, representing a module. Isolates the module's headers by creating a subdirectory in the build directory, e.g. .build/tmp123, that contains just a symlink, e.g. .build/tmp123/basics, to the module's header directory, e.g. include/xrpl/basics, in the source directory, and putting .build/tmp123 (but not include/xrpl) on the include path of the module sources. This prevents the module sources from including headers not explicitly linked to the module in CMake with target_link_libraries.
target_link_modules(library scope modules...): Links the library target to each of the module targets, and removes their sources from its source list (so they are not compiled and linked twice).

Uses these functions to separate and explicitly link modules in libxrpl:

Level 01: beast
Level 02: basics
Level 03: json, crypto
Level 04: protocol
Level 05: resource, server

Not a review yet, but this is such a cool idea.

I like how you moved extract to appropriate locations, but it seems that extract is function-wise the same as hash.
Given we already specialize both boost::hash (e.g. in IPEndpoint.h) and std::hash (e.g. in Book.h) I think that cleaning this up belongs in a different PR (also converting extract to hash), so maybe just take a note for future refactoring.

I do wonder whether Builds/levelization is becoming superfluous with this change. Why should we keep it, if the ordering of modules (and header isolation) enforce it for us ?

Builds/levelization is still used to diagnose cycles in xrpld. I want to remove it after we've eliminated all of the cycles.

Builds/levelization is still used to diagnose cycles in xrpld. I want to remove it after we've eliminated all of the cycles.

Makes sense. All the more reason to make an effort moving parts of xrpld into libxrpl, but that's separate discussion and more than one PR.

Bad news right out the gate on Windows builds:
$ cmake build/cmake/msvc19.ON
-- Using Conan toolchain: C:/Dev/rippled/review1/build/conan.msvc19/build/generators/conan_toolchain.cmake
-- Conan toolchain: C++ Standard 20 with extensions OFF
-- Conan toolchain: Setting BUILD_SHARED_LIBS = OFF
-- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.19045.
[...]
-- Conan: Component target declared 'xxHash::xxhash'
-- Conan: Including build module from 'C:/.conan/4b4fe1f3/1/lib/cmake/protobuf/protobuf-generate.cmake'
-- Conan: Including build module from 'C:/.conan/4b4fe1f3/1/lib/cmake/protobuf/protobuf-module.cmake'
-- Conan: Including build module from 'C:/.conan/4b4fe1f3/1/lib/cmake/protobuf/protobuf-options.cmake'
CMake Error at cmake/isolate_headers.cmake:44 (file):
  file failed to create symbolic link
  'C:/Dev/rippled/review1/build/cmake/msvc19.ON/modules/xrpl.libxrpl.beast/xrpl/beast':
  A required privilege is not held by the client.

Call Stack (most recent call first):
  cmake/add_module.cmake:25 (isolate_headers)
  cmake/RippledCore.cmake:69 (add_module)
  CMakeLists.txt:123 (include)

CMake Error at cmake/isolate_headers.cmake:44 (file):
  file failed to create symbolic link
  'C:/Dev/rippled/review1/build/cmake/msvc19.ON/modules/xrpl.libxrpl.basics/xrpl/basics':
  A required privilege is not held by the client.

Call Stack (most recent call first):
  cmake/add_module.cmake:25 (isolate_headers)
  cmake/RippledCore.cmake:76 (add_module)
  CMakeLists.txt:123 (include)

CMake Error at cmake/isolate_headers.cmake:44 (file):
  file failed to create symbolic link
  'C:/Dev/rippled/review1/build/cmake/msvc19.ON/modules/xrpl.libxrpl.json/xrpl/json':
  A required privilege is not held by the client.

Call Stack (most recent call first):
  cmake/add_module.cmake:25 (isolate_headers)
  cmake/RippledCore.cmake:80 (add_module)
  CMakeLists.txt:123 (include)

CMake Error at cmake/isolate_headers.cmake:44 (file):
  file failed to create symbolic link
  'C:/Dev/rippled/review1/build/cmake/msvc19.ON/modules/xrpl.libxrpl.crypto/xrpl/crypto':
  A required privilege is not held by the client.

Call Stack (most recent call first):
  cmake/add_module.cmake:25 (isolate_headers)
  cmake/RippledCore.cmake:83 (add_module)
  CMakeLists.txt:123 (include)

CMake Error at cmake/isolate_headers.cmake:44 (file):
  file failed to create symbolic link
  'C:/Dev/rippled/review1/build/cmake/msvc19.ON/modules/xrpl.libxrpl.protocol/xrpl/protocol':
  A required privilege is not held by the client.

Call Stack (most recent call first):
  cmake/add_module.cmake:25 (isolate_headers)
  cmake/RippledCore.cmake:87 (add_module)
  CMakeLists.txt:123 (include)

CMake Error at cmake/isolate_headers.cmake:44 (file):
  file failed to create symbolic link
  'C:/Dev/rippled/review1/build/cmake/msvc19.ON/modules/xrpl.libxrpl.resource/xrpl/resource':
  A required privilege is not held by the client.

Call Stack (most recent call first):
  cmake/add_module.cmake:25 (isolate_headers)
  cmake/RippledCore.cmake:94 (add_module)
  CMakeLists.txt:123 (include)

CMake Error at cmake/isolate_headers.cmake:44 (file):
  file failed to create symbolic link
  'C:/Dev/rippled/review1/build/cmake/msvc19.ON/modules/xrpl.libxrpl.server/xrpl/server':
  A required privilege is not held by the client.

Call Stack (most recent call first):
  cmake/add_module.cmake:25 (isolate_headers)
  cmake/RippledCore.cmake:97 (add_module)
  CMakeLists.txt:123 (include)

-- xrpl.libxrpl.basics with 14 sources took 14 sources from xrpl.libxrpl
-- xrpl.libxrpl.beast with 15 sources took 15 sources from xrpl.libxrpl
-- xrpl.libxrpl.crypto with 3 sources took 3 sources from xrpl.libxrpl
-- xrpl.libxrpl.json with 9 sources took 9 sources from xrpl.libxrpl
-- xrpl.libxrpl.protocol with 51 sources took 51 sources from xrpl.libxrpl
-- xrpl.libxrpl.resource with 4 sources took 4 sources from xrpl.libxrpl
-- xrpl.libxrpl.server with 2 sources took 2 sources from xrpl.libxrpl
-- Configuring incomplete, errors occurred!

@ximinez ok, try again.

It's building successfully now. Neat workaround. Super annoying that this is an issue, though.
I remember there were some file(CREATE_LINK calls elsewhere that were simply disabled under Windows. Would it be worth coming back to those to use this same technique?
Otherwise, I'll come back to the rest of this review as soon as I get some other priorities knocked out.

@thejohnfreeman I see this has two approvals. Since I've verified that it builds under Windows, it's up to you if you want to wait for mine, too, or go ahead and add the "Passed" label and provide a commit message. I'll preemptively mark it as "Blocked" now to be sure we wait until after the 2.3.0 release before merging.

@ximinez I would still appreciate your review.


TNO-2777 report sticky buttons

Added code to make the buttons stick to the bottom.

The changes Nehal made look ok to me. I am not sure if the git history would look right after merging to dev. I will let Jeremy to decide.