make use of incoming Message's replyTopic header if needed

as per reference doc: https://docs.spring.io/spring-kafka/docs/current/reference/html/#reply-message:

Starting with version 2.5, the framework will detect if these headers are missing and populate them with the topic - either the topic determined from the @SendTo value or the incoming KafkaHeaders.REPLY_TOPIC header (if present)

Seems we overlooked the incoming KafkaHeaders.REPLY_TOPIC logic.

It is really much easier to review if there is a history of commits in the PR.
And sometime we just review the latest commit which might not include changes for other files.
When we merge PR, we squash to preserve only one commit in the main for the issue we are resolving.
Thanks for understanding!

 It is really much easier to review if there is a history of commits in the PR. And sometime we just review the latest commit which might not include changes for other files. When we merge PR, we squash to preserve only one commit in the main for the issue we are resolving.
Thanks for understanding!

a little bit late to read this comment. yeah, for sure. I totally understand. Will keep that in mind from now on. thanks.
btw, I am not very confident about my changes in this PR (seems a big overlooking if valid). I am a developer whose job requires good Spring Kafka experience and I think contributing directly is the best way to learn. Thanks for your patience and good product.

@NathanQingyangXu ,
thank you very much for so thoughtful contributions!
Would you mind double checking if PR build failure is related somehow to your changes: https://github.com/spring-projects/spring-kafka/actions/runs/6903843623/job/18783345784?pr=2904 ?

as usual, unit testing cases protected. Fixed the bug and now they would not complain.

New unit testing cases are desperately needed. My current concern is to
confirm my PR validity. Will add testing cases soon.
On Fri, Nov 17, 2023, 1:56 p.m. Artem Bilan @.***>
wrote:

@.**** requested changes on this pull request.
Looks like this fix introduces some new functionality.
Any chances to have ti covered with unit test, please?
In
spring-kafka/src/main/java/org/springframework/kafka/listener/adapter/MessagingMessageListenerAdapter.java
https://github.com/spring-projects/spring-kafka/pull/2904#discussion_r1397745394
:

@@ -482,14 +489,14 @@ else if (result instanceof Message) {
iterableOfMessages = iterator.next() instanceof Message;

Let's leave it wit this assumption for now!
We can look into that later.
Let's concentrate on missed headers logic in this your PR!
—
Reply to this email directly, view it on GitHub
https://github.com/spring-projects/spring-kafka/pull/2904#pullrequestreview-1737688252,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6UYASBEMEO4VPXER7A4F3YE6XOPAVCNFSM6AAAAAA7PHPRSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZXGY4DQMRVGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

During unit testing case development, I found this PR is invalid. For the following code snippet:
/**
* Return the default expression when no SendTo value is present.
* @return the expression.
* @since 2.2.15
*/
public static String getDefaultReplyTopicExpression() {
return PARSER_CONTEXT.getExpressionPrefix() + "source.headers['"
		+ KafkaHeaders.REPLY_TOPIC + "']" + PARSER_CONTEXT.getExpressionSuffix();
}

so if no reply topic is specified, the above default expression will ensure we got the value from KafkaHeaders.REPLY_TOPIC header.
There are other minior issues valid in this PR, but given the gist of it is invalid, I close this PR for now.


docs: Add architecture diagram to website

Signed-off-by: Peter Engelbert<EMAIL_ADDRESS>What this PR does / why we need it:
Adds a high-level diagram of Eraser's architecture
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #399

can we replace Qualys with Other providers or something?

Codecov Report

Merging #431 (e81e5c2) into main (ff8727f) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e81e5c2 differs from pull request most recent head 16427be. Consider uploading reports for the commit 16427be to get more accurate results

@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   13.86%   13.86%
=======================================
  Files          12       12
  Lines        1248     1248
=======================================
  Hits          173      173
  Misses       1057     1057
  Partials       18       18

Flag
Coverage Δ

unittests
13.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Use private key for Houdini password

@pcucka @Idclip @jmlait @kmuseth - can someone approve this please?
It's a simple change, moving the plaintext password up into a CI env variable, but it's needed for one of the CII best practices badge criteria.

It's a simple change, moving the plaintext password up into a CI env variable, but it's needed for one of the CII best practices badge criteria.

So where's this password now stored, in Circles config? How would we change it if required?

It's a simple change, moving the plaintext password up into a CI env variable, but it's needed for one of the CII best practices badge criteria.

So where's this password now stored, in Circles config? How would we change it if required?

Yes, I added it to our Circle CI config, as I have administrator privileges. For Azure, we'd need to contact the ASWF helpdesk to do it for us.

Yes, I added it to our Circle CI config, as I have administrator privileges. For Azure, we'd need to contact the ASWF helpdesk to do it for us.

cool thanks for clarifying


API Function Request: Get Marker/Regions Notes/Subtitles

Hi !
SWS come with Regions and Markers notes (subtitles) possibility.
But, we cant reach them at script level.
It would be nice to have a function like GetMarlerNotes(id) so that we can return these notes into ReaScript.
Thanks for listening !

A Set function would be handy too. 👍
Or we can consider GetSet functions instead.
Also, extra notes from SWS are not accessible either from API, like :

Track notes
Extra project notes

For flexibility, it would be nice to have them too.

@nofishonfriday Hi ! Any progress on your investigation about this ? :)

@X-Raym
Here's a test version for getting / setting region subtitles (for markers may come later if getting to working ok with regions):
https://www.dropbox.com/s/ysl24dy2ftuzq5k/reaper_sws64_GetSetRegionSubs01.dll?dl=1
Example code:
reaper.ClearConsole()

function msg(m)
  return reaper.ShowConsoleMsg(tostring(m) .. "\n")
end

local regionIdx = 1 -- one-based (as how region numbers are displayed in the project / Region/Marker manager)

-- SET REGION SUB --
local fastStringIn = reaper.SNM_CreateFastString("Subtitle for region 1")

-- set region sub, note: region must in exist in project already that region sub can be set!
-- returns true if region sub is set successfully (ie region exists in project)
regionSubIsSet = reaper.NF_SetRegionSub(fastStringIn, regionIdx)

reaper.SNM_DeleteFastString(fastStringIn)

-- GET REGION SUB --
local fastStringOut = reaper.SNM_CreateFastString("")

-- get region sub, returns empty string if region not existant or region sub not set
regionSub = reaper.NF_GetRegionSub(fastStringOut, regionIdx)

msg("Region sub for region 1: " .. regionSub)
reaper.SNM_DeleteFastString(fastStringOut)

Let me know how it goes. :)

@nofish Nice you work on that :P
Could it be based on RegionIDX (like parameter of EnumProjectMarker) or on idx (like the retval of EnumProjectMarker) ?
Currently, if there is markers, it is not very handy to plug this function.
Here is demo code with a usual region/marker loop:
https://www.dropbox.com/s/fi8wnguret60a2j/region notes.rpp?dl=0
count_markers_and_regions, count_regions = reaper.CountProjectMarkers(0)
for i = 0, count_markers_and_regions - 1 do
  local retval, isrgnOut, posOut, rgnendOut, nameOut, markrgnindexnumberOut =  reaper.EnumProjectMarkers( i )
  local fastStringOut = reaper.SNM_CreateFastString("")
  regionSub = reaper.NF_GetRegionSub(fastStringOut, retval)
  msg("Region sub " .. retval .. " = " .. regionSub)
  reaper.SNM_DeleteFastString(fastStringOut)
  i = i + 1
end

We already have to deal with idx and regionIDX, so a third type of index (the one displayed on the timeline, wich is different that the other two) is a bit confusing. (or maybe I miss something. Which prove it can be confusing haha :P)
Note that it is already generic (it can return both marker and region notes, so the name might be change). IMHO, it it can deal with EnumProjectMarkers( i ) i parameter it would then be more coherent (as this function is also able to return both markers and regions).
What do you think ?

@nofishonfriday well, the most confusing part is that all of that are called indexes ^^
Ok so I tested with a more complete code snippet. Let's restart from there:
count_markers_and_regions, count_regions = reaper.CountProjectMarkers(0)
for i = 0, count_markers_and_regions - 1 do
  local retval, isrgnOut, posOut, rgnendOut, nameOut, markrgnindexnumberOut =  reaper.EnumProjectMarkers( i )
  markerIdx, regionIdx = reaper.GetLastMarkerAndCurRegion( 0, posOut )
  local fastStringOut = reaper.SNM_CreateFastString("")
  regionSub = reaper.NF_GetRegionSub(fastStringOut, markrgnindexnumberOut)
  msg("i = " .. i)
  msg("retval = " .. retval)
  msg("is_region = " .. tostring(isrgnOut))
  msg("markrgnindexnumberOut = " .. markrgnindexnumberOut)
  msg("NOTES = " .. regionSub)
  msg("")
  reaper.SNM_DeleteFastString(fastStringOut)
  i = i + 1
end

We have EnumProjectMarkers( i ) index. This can return both Region or Markers. i is zero based.
The retval of EnumProjectMarkers( i ) is in fact just i + 1.
the markrgnindexnumber returned value of EnumProjectMarkers( i ) is the number in the arrange view

So it sounds like the markrgnindexnumber should work, according to your comment, but it does not. Something is wrong in the get notes function. I think it is confused by the order of the marker/region.
Here what I got with my RPP:
i = 0
retval = 1
is_region = true
markrgnindexnumberOut = 1
NOTES = Region 1

i = 1
retval = 2
is_region = false
markrgnindexnumberOut = 1
NOTES = Region 1

i = 2
retval = 3
is_region = true
markrgnindexnumberOut = 3
NOTES = Region 3

i = 3
retval = 4
is_region = false
markrgnindexnumberOut = 2
NOTES = Marker 1

i = 4
retval = 5
is_region = true
markrgnindexnumberOut = 2
NOTES = Marker 1

Instead of
i = 0
retval = 1
is_region = true
markrgnindexnumberOut = 1
NOTES = Region 1

i = 1
retval = 2
is_region = false
markrgnindexnumberOut = 1
NOTES = Marker 1

i = 2
retval = 3
is_region = true
markrgnindexnumberOut = 3
NOTES = Region 3

i = 3
retval = 4
is_region = false
markrgnindexnumberOut = 2
NOTES = Marker 2

i = 4
retval = 5
is_region = true
markrgnindexnumberOut = 2
NOTES = Region 2

What I would find useful is the NF_GetRegionSub to be a NF_GetMarkerRegionSub and would work just like the EnumProjectMarkers( i ) with the i parameter. This way, easy to plug in the loop !

Your provided material helps a lot again Sir! °°
Thanks.
Next version:
https://www.dropbox.com/s/m37shzq1cbhncgk/reaper_sws64_GetSetRegionSubs02.dll?dl=1
updated script:
reaper.ClearConsole()

function msg(m)
  return reaper.ShowConsoleMsg(tostring(m) .. "\n")
end

count_markers_and_regions, count_regions = reaper.CountProjectMarkers(0)
for i = 0, count_markers_and_regions - 1 do
  local retval, isrgnOut, posOut, rgnendOut, nameOut, markrgnindexnumberOut =  reaper.EnumProjectMarkers( i )
  markerIdx, regionIdx = reaper.GetLastMarkerAndCurRegion( 0, posOut )
  local fastStringOut = reaper.SNM_CreateFastString("")
  regionSub = reaper.NF_GetMarkerRegionSub(fastStringOut, i) -- renamed function and works now on i index!
  msg("i = " .. i)
  msg("retval = " .. retval)
  msg("is_region = " .. tostring(isrgnOut))
  msg("markrgnindexnumberOut = " .. markrgnindexnumberOut)
  msg("NOTES = " .. regionSub)
  msg("")
  reaper.SNM_DeleteFastString(fastStringOut)
  i = i + 1
end

Console output I now get with your project:
i = 0
retval = 1
is_region = true
markrgnindexnumberOut = 1
NOTES = Region 1

i = 1
retval = 2
is_region = false
markrgnindexnumberOut = 1
NOTES = Marker 1

i = 2
retval = 3
is_region = true
markrgnindexnumberOut = 3
NOTES = Region 3

i = 3
retval = 4
is_region = false
markrgnindexnumberOut = 2
NOTES = Marker 2

i = 4
retval = 5
is_region = true
markrgnindexnumberOut = 2
NOTES = Region 2

Looks ok ?
(The Set... function is not working correctly yet...)

Next version for testing the Set function:
https://www.dropbox.com/s/8mrmlkkh4nxclud/reaper_sws64_GetSetRegionSubs03.dll?dl=1
For test code I used this:
reaper.ClearConsole()

function msg(m)
  return reaper.ShowConsoleMsg(tostring(m) .. "\n")
end

-- set subs
count_markers_and_regions, count_regions = reaper.CountProjectMarkers(0)
for i = 0, count_markers_and_regions - 1 do
  local retval, isrgnOut, posOut, rgnendOut, nameOut, markrgnindexnumberOut =  reaper.EnumProjectMarkers( i )

  if isrgnOut == true then
    fastStringIn = reaper.SNM_CreateFastString("new Subtitle text for region " .. markrgnindexnumberOut)
  else
    fastStringIn = reaper.SNM_CreateFastString("new Subtitle text for marker " .. markrgnindexnumberOut)
  end

  regionSubIsSet = reaper.NF_SetMarkerRegionSub(fastStringIn, i)
  reaper.SNM_DeleteFastString(fastStringIn)
  i = i + 1
end

-- get subs
count_markers_and_regions, count_regions = reaper.CountProjectMarkers(0)
for i = 0, count_markers_and_regions - 1 do
  local retval, isrgnOut, posOut, rgnendOut, nameOut, markrgnindexnumberOut =  reaper.EnumProjectMarkers( i )
  markerIdx, regionIdx = reaper.GetLastMarkerAndCurRegion( 0, posOut )
  local fastStringOut = reaper.SNM_CreateFastString("")
  regionSub = reaper.NF_GetMarkerRegionSub(fastStringOut, i)
  msg("i = " .. i)
  msg("retval = " .. retval)
  msg("is_region = " .. tostring(isrgnOut))
  msg("markrgnindexnumberOut = " .. markrgnindexnumberOut)
  msg("NOTES = " .. regionSub)
  msg("")
  reaper.SNM_DeleteFastString(fastStringOut)
  i = i + 1
end

What do you think ?

@nofishonfriday This seems to works flawlessly, even with non consecutive marker index ! Ready to be merge :P
Note: You can color highlight your code snippet :P https://help.github.com/articles/creating-and-highlighting-code-blocks/

Cool, thanks for testing.
Some final touches before PR / merge:
https://www.dropbox.com/s/0j6w9yhve6hrj1c/reaper_sws64_GetSetRegionSubs04.dll?dl=1

Functions have been renamed to NF_Get/SetSWSMarkerRegionSub (to be consistent with already existing  NF_Get/SetSWSTrackNotes)

SetMarkerRegionSub got a new param, see updated ReaScript API doc. (ReaScript: Open reaScript documentation (html)... )

Also it would be nice if you could say what you think about the doc for these functions, if I should change/add anything.
Thanks.

@nofishonfriday All good and working fine !
(how much faster it is with the force update set to off ?)

When set to on the function must: iterate over all existing subs and check if the passed in one is currently displayed so it can update it imediately.
Don't know how much that makes in real life (you could measure and tell me if you're curious :P).

@nofishonfriday so don't you think that there shouldn't be an extra update parameter, but simply a force display update function, as we have with other system( reaper.UpdateArrange etc...) ?

Done.
https://www.dropbox.com/s/zur7lc6xdzfyu4v/reaper_sws64_GetSetRegionSubs05.dll?dl=1
Reverted forceDisplayUpdate param, added NF_UpdateSWSMarkerRegionSubWindow()

@nofishonfriday good and efficient !

Thanks for the snippet template, I've linked it in the ReaScript doc.
I think a little optimisation (better coding practice) would be to create the fastString before the loop and delete afterwards instead of creating / destroying in every iteration (didn't think about this when doing the script originally).
-- For SWS v<IP_ADDRESS>
reaper.ClearConsole()

function msg(m)
  return reaper.ShowConsoleMsg(tostring(m) .. "\n")
end

-- set subs
fastStringIn = reaper.SNM_CreateFastString("")
count_markers_and_regions, count_regions = reaper.CountProjectMarkers(0)
for i = 0, count_markers_and_regions - 1 do
  local retval, isrgnOut, posOut, rgnendOut, nameOut, markrgnindexnumberOut =  reaper.EnumProjectMarkers( i )

  if isrgnOut == true then
    reaper.SNM_SetFastString(fastStringIn, "new Subtitle text for region " .. markrgnindexnumberOut)
  else
    reaper.SNM_SetFastString(fastStringIn, "new Subtitle text for marker " .. markrgnindexnumberOut)
  end

  regionSubIsSet = reaper.NF_SetSWSMarkerRegionSub(fastStringIn,i)
  i = i + 1
end
reaper.SNM_DeleteFastString(fastStringIn)
reaper.NF_UpdateSWSMarkerRegionSubWindow()

-- get subs
fastStringOut = reaper.SNM_CreateFastString("")
count_markers_and_regions, count_regions = reaper.CountProjectMarkers(0)
for i = 0, count_markers_and_regions - 1 do
  local retval, isrgnOut, posOut, rgnendOut, nameOut, markrgnindexnumberOut =  reaper.EnumProjectMarkers( i )
  markerIdx, regionIdx = reaper.GetLastMarkerAndCurRegion( 0, posOut )
  regionSub = reaper.NF_GetSWSMarkerRegionSub(fastStringOut, i)
  msg("i = " .. i)
  msg("retval = " .. retval)
  msg("is_region = " .. tostring(isrgnOut))
  msg("markrgnindexnumberOut = " .. markrgnindexnumberOut)
  msg("NOTES = " .. regionSub)
  msg("")
  i = i + 1
end
reaper.SNM_DeleteFastString(fastStringOut)

@nofishonfriday yes you can :P

added in v2.10.0

NF_GetSWSMarkerRegionSub()

NF_SetSWSMarkerRegionSub()
NF_UpdateSWSMarkerRegionSubWindow()


Support topic level Policies

Is your feature request related to a problem? Please describe.
The existing settings is not fine-grained enough, and many settings can only be set at the namespace level.
The following settings are hoped to support Topic level：

[ ]  topicDispatchRate
[ ]  subscriptionDispatchRate
[ ]  message_ttl_in_seconds(WIP)
[ ]  subscription_expiration_time_minutes
[x]  backlog quota(Done) #7646
[ ]  retention_policies(WIP)
[ ]  DelayedDeliveryPolicies
[ ]  SubscriptionAuthMode
[ ]  max_producers_per_topic
[ ]  max_consumers_per_topic
[ ]  max_consumers_per_subscription
[ ]  max_unacked_messages_per_consumer
[ ]  max_unacked_messages_per_subscription
[ ]  compaction_threshold
[ ]  is_allow_auto_update_schema
[ ]  schema_validation_enforced
...

Describe the solution you'd like
Use SystemTopic to save and update these Topic level settings
Describe alternatives you've considered
We have considered using zk, but the amount of configuration will be relatively large, not suitable for using zk

Sorry @315157973, I forgot I have added an issue #2688 for tracking topic level policies. Since there is more context in the old issue, I would like to close this issue first, and if you want to update the old issue, you can add a comment. Thanks.


[Playground][Frontend] Run timer fix; CodeRunner and OutputType extraction.

Resolves #24617
Resolves #24691

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @alexeyinkin

R: @damondouglas


:oldfiles /pattern/ list only files that match a pattern

New patch for the :oldfiles /pattern/ feature.  Now it has the same syntax as vimgrep.  The pull request also contains a test.

having this would be a nice addition!

@brammool I updated the patch, it now uses the same syntax as the :grep command. Maybe it can get included into vim8.


Distortion Correction?

Because the maths is difficult to deal with. So i decided to buy the official holokit cardboard. And i am using iphone 8 for test.
So far, i feel the depth is correct ,which is good (i bought a third party headset and depth is incorrectly closer than the real thing). However, it has a strong distortion problem in the edge area. So only the position close to the center of view is marching the real world.  I see that in the code, holokit v1 model set the distortion correction to zero. And if i manually adjust the distortion, it will break the perspective.
So what should i do?

i modified HoloKit-BarrelDistortion.shader, change "float a = 1.0 + r2 * _BarrelDistortionFactor;" to "float a = 1.0 + (1-sqrt(r2)) * _BarrelDistortionFactor;". it seems better in my case.


quickCreate modal breaks if there are any fields forEach is not a function

When using the field like this:
\R64\NovaFields\BelongsTo::make( 'Hotel' )->quickCreate()->disableTrashed(),
it shows overlay for modal with loading animation but without the actual modal.
Uncaught (in promise) TypeError: (intermediate value).forEach is not a function
The actual Hotel model has some fields.
If I drop all the fields except ID field from that hotel model it gives me cancel, create, create and add new buttons without fields.
The XHR request I see for the hotel that scripts makes returns fields and panels, but it seems that the script is not catching it in forEach.

I believe that if breaks here by inspecting the js in debugger: https://github.com/64robots/nova-fields/blob/master/resources/js/modals/ModalCreate.vue#L116
I'm not sure why. I've tried forking it but haven't actually made package myself for laravel (only nova components etc.) so I'm not sure how I would use webpack in debug mode to test it out to log the data and hunt down the error.
Can anyone help?
PHP 7.4
Laravel 7.22.4
Nova 3.8.2
Nova Fields 0.17.0

Just a quick update. I was downgrading the nova version down until 3.0.* and it's where it started working. So something after that build version broke quickCreate.

Thanks for your detailed report. Definitely is something Nova has introduced that has broken this package. Will investigate and make a trace and see if I can find out where is the source of the issue.

Just released 0.18.0 with the fix. Thanks to pointing that out! 🎉

Great, thanks!
Well, I did as much as I could to debug :) It's much easier if you know what is broken and where to look at. If all my clients and colleges did thorough research before saying "it doesn't work" life would be much easier :D


Drop old components installation method

We now install all components using helm underneath, so support for old installation method can be now removed.

CI is failing.

Oops, I didn't clean the unit tests. Fixed now.

It seems openebs-operator can't be installed through helm?

It seems openebs-operator can't be installed through helm?

I didn't really test this code, so fixing now :see_no_evil:


No slot "selection" find

In multiple select exmple , a "selection" slot is used, but i did't find it in "slot" menu, and i imitate the exmple,it dose't work

Not sure if this is the same issue I was about to report, but the slot selection is not documented with the other available slots.
@shentao I'd be happy to add documentation, if you'd like someone to do so.

@jwkicklighter If you have a moment to do that, that would be awesome!

I made the changes locally, but I can't get yarn install/npm install to succeed properly.Is there a particular version of npm, yarn, or node being used?

Uh. I think this might be the result of the recent dependency updates. Might have to postpone it a bit. Please submit a PR with that change and once the dependency issue is solved, I will be able to rebuild the docs.


Instant update after UI actions

Hello folks,
Thanks a lot for this awesome project.
I'm noticing that most of UI actions are only applied after changing the current view to another one. Examples of that;

Click on a lisiting result header to sort result
Show / hide recent queries list
Delete an item from the recent queries list
Mark search query as a favourite one

I find this behavior consistent and this left me wondering; is that on purpose? or am I missing something?

Are you talking about when the URL updates or the UI itself? We tried to make the URL update infrequently to reduce the length of the back button history in the browser, but the UI should request and show updates rapidly when the query changes. We only rerun the query about every 250ms as you type so that fast typists don't cause excessive quey load. If you are making changes in the UI and it doesn't update, please let us know which browser you're using and send us some sample steps. Thanks!

Hi Ahmed, I work with Scott on this project and focus on the front end. The
issues you're describing sound related to localStorage when change
notifications are not firing. As Scott suggested, it's likely this is
browser specific so it would help us to know which browser you are on.
Thanks!
On Mon, Feb 12, 2018 at 7:26 PM, Scott Louvau<EMAIL_ADDRESS>wrote:

Are you talking about when the URL updates or the UI itself? We tried to
make the URL update infrequently to reduce the length of the back button
history in the browser, but the UI should request and show updates rapidly
when the query changes. We only rerun the query about every 250ms as you
type so that fast typists don't cause excessive quey load. If you are
making changes in the UI and it doesn't update, please let us know which
browser you're using and send us some sample steps. Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/elfie-arriba/issues/180#issuecomment-365139784,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADSvn0zQPQ7vIw-YCHIwKJzWo7Fw7Emrks5tUQDegaJpZM4SA_CL
.

Thanks Scott and Jeff.
I'm referring to UI updates. This is happening in both FF & Chrome (latest stable release) on Windows 8.1.
Sample One (in both FF & Chrome)

Perform a search query
Click on Site Title or Help icon to switch to the Help view and then return back to the Start view, the most recent search query/queries is not listed in the Recent list
Refresh the page, the most recent queries now appear in the Recent list

Sample Two (in FF)

In home/start view, hover on an item in the Recent list and click "Delete" button
Following the delete action, item still appears in Recent list
Refresh the page or switch the view and then return back to home/start view, the deleted item is now removed from the list.

Using DevTools to monitor/track the updates of "recents" localstorage key, it is not instantly updated following the applied UI action e.g. delete a recent item, mark search query as a favourite one etc...
Please let me know should any further clarifications required.

Hi Ahmed, thanks for providing those repros!
Regarding sample one: that is a bug. Short term fix is to call mru.push() on when the query is cleared. Longer term fix is likely to simply commit the mru after a fixed timeout, rather than wait for a subsequent event. I will put it on our backlog.
Regarding sample two: I was not able to repro because we don't test in Firefox. However, this issue is likely here: https://github.com/Microsoft/elfie-arriba/blob/6fa8cec2e2194147d1377bed0582a2534a15724f/Arriba/Arriba.Web/js/utilities.js#L104. My guess that is that it should work if you provide the right Event ctor for Firefox.
Hope that helps!


Vehicle Routing get started docs: Python tabs

https://docs.timefold.ai/timefold-solver/latest/quickstart/quarkus-vehicle-routing/quarkus-vehicle-routing-quickstart

This will probalby need a design meeting. The VRP java/kotlin guide heavily leans on Quarkus.


How to change backbone

How can I properly change the backbone to a different network?

I am trying to change the backbone of a WideResnet-40-2 but get a very different result


docs: Improve BGP Control Plane page

Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[x] Thanks for contributing!

Fixes: #23817
Clarifies installation of BGP Control Plane
Fixes non-functional hyperlinks

Yes, I just clicked to rerequest review and didn't notice it removed the second one.

Dylan: Just thinking, while reviewing this PR again: If the two different BGP features are mutually exclusive, should we consider a follow-up PR to make the Cilium agent fail to start if both are required by the user?

To be honest, I don't know if the two are mutually exclusive, I will double check this for myself. However, I can recall a few issues where I have seem users enable both at the same time and them being confused as to why configuration from the legacy feature doesn't apply to the BGP Control Plane.
I think there fundamentally isn't an conflict since both use different methods of configuration and do not interfere on a network level as far as I know. And I would not enforce mutual exclusion in the agent since that would make migrating from MetalLB to BGP CP harder.
I still agree with the spirit of this doc change, but I suggest we change it be advisory and keep the clarification that enabling BGP CP does not disable the legacy BGP feature.


feat: use cached kernel

Thank you for contributing to the Universal Blue project!
Please read the Contributor's Guide before submitting a pull request.

I built a local image pushed to local registry to test the approach of direct replacing the signed vmlinuz file.
This main kernel, as provided by kernel-cache repo, has 3 signatures:

upstream fedora
ublue akmods (our traditional akmods sig)
ublue kernel (new sig to align with full kernel signing and Fedora 41 release)

Note: non-main kernels are not "Fedora Official" so we strip any signatures from them and they will only have the latter 2.
Output to verify above:
herman@fedora:~$ sbverify --list /usr/lib/modules/6.9.7-200.fc40.x86_64/vmlinuz
signature 1
image signature issuers:
 - /C=US/ST=Massachusetts/L=Cambridge/O=Red Hat, Inc./OU=Fedora Secure Boot CA 20200709/CN=fedoraca
image signature certificates:
 - subject: /C=US/ST=Massachusetts/L=Cambridge/O=Red Hat, Inc./OU=Fedora Secure Boot Signer/OU=bkernel01 kernel/CN=kernel-signer
   issuer:  /C=US/ST=Massachusetts/L=Cambridge/O=Red Hat, Inc./OU=Fedora Secure Boot CA 20200709/CN=fedoraca
signature 2
image signature issuers:
 - /O=Universal Blue/OU=kernel signing/CN=ublue<EMAIL_ADDRESS>image signature certificates:
 - subject: /O=Universal Blue/OU=kernel signing/CN=ublue<EMAIL_ADDRESS>   issuer:  /O=Universal Blue/OU=kernel signing/CN=ublue<EMAIL_ADDRESS>signature 3
image signature issuers:
 - /O=Universal<EMAIL_ADDRESS>akmods
image signature certificates:
 - subject: /O=Universal<EMAIL_ADDRESS>akmods
   issuer:  /O=Universal<EMAIL_ADDRESS>akmods

Observations:

kernel boots with SecureBoot disabled
kernel fails to boot with SecureBoot enabled if a ublue MOK NOT enrolled (qemu kvm uefi, lacking Microsoft key)
kernel boots with SecureBoot enabled if a ublue MOK NOT enrolled (on physical hardware with Microsoft key)
kernel boots with SecureBoot enabled if ublue akmods MOK is enrolled (qemu kvm uefi, lacking Microsoft key)
can rebase to another image, and rollback to image with this custom signed kernel, booting still works

All this seems good... yes, the process feels a bit janky, but it works.

Next step as discussed with @m2Giles:
Add support to install.sh such that, if the kernel-cache (and thus akmods) provides a different kernel version than what is on the building image, we'll do an rpm-ostree override replace to the kernel-cache RPMs.
But for identically matching kernels, the rpm-ostree override replace fails to work (since the RPMs are otherwise identical), and in that case we'll just replace the vmlinuz file with our signed copy.
I'm waiting for this to be solid here, then I'll use this approach on uCore, too.


Contact INHA for their Transkribus data

Check with https://skylab.inha.fr/PENSE/LettresDeJacquesDoucetAReneJean1908-1929/ where it's written Transkribus is used.
@alix-tz @emchateau You might know someone inside ?

Antoine Courtin was in charge of this project, but he is now in Orsay. I can write him to know who is actually in charge.
Best regards,

I was in touch with Jean-Christophe Carius (@jccarius) last year, he was ok with the idea of indexing their data in HTR-United, but we probably need to recall them :)

Thanks for the reminder. We plan to share the documents very soon. (in July or August)

The repository for the transcriptions of "Les Papiers Barye" project is open. We hope to be able to share the "Correspondance Jacques Doucet / René jean" data (capta) quite soon...
===== YAML =====
schema: https://htr-united.github.io/schema/2022-04-15/schema.json
title: Les Papiers Barye
url: https://gitlab.inha.fr/snr/LesPapiersBarye
authors:

name: Claass
surname: Victor
roles:

transcriber
project-manager
quality-control

name: Gain
surname: Justine
roles:

transcriber
quality-control

name: Martin-Vigier
surname: Suzanne
roles:

transcriber
quality-control
institutions:

name: Institut National de l'histoire de l'art (INHA)
roles:

transcriber
aligner
project-manager
quality-control
digitization
description: >-
Ensemble de documents autour du sculpteur Antoine-Louis Barye. Paris,
Bibliothèque de l’Institut national d’histoire de l’art, collections Jacques
Doucet, Archives 166. Institut National de l’Histoire de l’art (INHA) /
Set of documents about the sculptor Antoine-Louis Barye. Paris,
Library of the Institut national d'histoire de l'art, Jacques
Doucet, Archives 166. National Institute of Art History (INHA)
project-website: https://skylab.inha.fr/PENSE/LesPapiersBarye/
language:

fra
production-software: Transkribus
script:
iso: Latn
script-type: mainly-manuscript
time:
notBefore: '1819'
notAfter: '1914'
hands:
count: more-than-10
precision: exact
license:
name: Etalab OL 2.0
url: https://spdx.org/licenses/etalab-2.0.html
format: Alto-XML
volume:
metric: characters
count: 362629
metric: lines
count: 17880
metric: pages
count: 918
metric: files
count: 918

Very very good news ! Thank you !

Cool ! :D
Just a question regarding the images: are they accessible anywhere?

The images are on the IIIF server of The INHA digital library.
Each XML-ALTO files indicates its corresponding IIIF urls in the
"Description / fileIdentifier" tag.
Example:

https://bibliotheque-numerique.inha.fr/i/?IIIF=/65/47/f8/b8/6547f8b8-4a80-4349-ae34-9ccb5023a304/iiif/1101_doucet_ARCHIVES166_2_2_001-002_000001.tif/full/2082,/0/default.jpg

...

...

Le ven. 9 sept. 2022 à 16:08, Alix Chagué @.***> a
écrit :

Cool ! :D
Just a question regarding the images: are they accessible anywhere?
—
Reply to this email directly, view it on GitHub
https://github.com/HTR-United/htr-united/issues/73#issuecomment-1242022323,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGU7ACCAZEZT2HNHWAQO6R3V5NAGPANCNFSM5Z5XEFEQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

The repository for the transcriptions of "La Correspondance Jaques Doucet - René Jean" is open.
The corresponding image files are on Gallica as indicated in the Description/sourceImageInformation/fileIdentifier element of each ALTO document.
===== YAML =====
schema: https://htr-united.github.io/schema/2022-04-15/schema.json
title: La Correspondances Jacques Doucet - René Jean
url: https://gitlab.inha.fr/snr/LaCorrespondanceDoucetReneJean
authors:

name: Cugy
surname: Pascale
roles:

transcriber
project-manager
quality-control

name: Fieschi
surname: Caroline
roles:

project-manager
quality-control

name: Peyrard
surname: Alix
roles:

transcriber
quality-control

name: Prohin
surname: Lucie
roles:

transcriber
quality-control

name: Sarda
surname: Marie-Anne
roles:

support
institutions:

name: Institut National de l'histoire de l'art (INHA)
roles:

transcriber
project-manager
quality-control

name: Bibliothèque nationale de France
roles:

digitization
description: >-
Projet entrepris dans le cadre du programme La Bibliothèque d’art et
d’archéologie de Jacques Doucet : corpus, savoirs et réseaux de l’Institut
national d’histoire de l’art à partir d’un corpus de lettres et documents
conservés au Département des manuscrits de la Bibliothèque nationale de France
sous la cote NAF 13124, une des principales sources sur la relation entre
Doucet et René Jean qu’il engagea comme bibliothécaire le 2 juin 1908.
project-website: https://skylab.inha.fr/PENSE/LettresDeJacquesDoucetAReneJean1908-1929/
language:

fra
production-software: Transkribus
script:
iso: Latn
script-type: mainly-manuscript
time:
notBefore: '1908'
notAfter: '1929'
hands:
count: less-than-11
precision: exact
license:
name: Etalab OL 2.0
url: https://spdx.org/licenses/etalab-2.0.html
format: Alto-XML
volume:
metric: characters
count: 83312
metric: lines
count: 2987
metric: pages
count: 200
metric: files
count: 200

Merci, pull request ouverte pour @alix-tz


Rename swagger to openapi

Rename directories, modules and files from swagger to openapi
DOCK-574

Looks like you need to modify the name in the client pom that uses it.


Fix dates wth is wrong with them

Resolved by:
https://github.com/ryanAllMad/js-job-helper/pull/44


resolves context path from servlet context, fixes #213

Takes use of @ConditionalOnWebApplication to resolve contextPath from ServletContext only if running as web application. See #218.

yes, with and without

Am 29.04.2017 um 19:44 schrieb Jan Galinski<EMAIL_ADDRESS>@jangalinski commented on this pull request.
I did not know that @Configuration https://github.com/Configuration can be used in this way ... did you test this with a war deployment?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/camunda/camunda-bpm-spring-boot-starter/pull/240#pullrequestreview-35501168, or mute the thread https://github.com/notifications/unsubscribe-auth/AMTszXbtNPXbys3BLoVZbcmyxot1DoZ1ks5r03bwgaJpZM4NMLPv.


[DRAFT] Claim rewards for all positions directly from the pools page

What is the purpose of the change

ClickUp Task
ClickUp Task URL
Brief Changelog

Testing and Verifying

Documentation and Release Note

@nicolaslara is this still being worked on?

No. Worked on this in NJ and should be ready for review / merge. The only thing left should be deciding where to position the button

@nicolaslara can you sync with Nass on this? I recommend making a proposal for him to review.

Reopened.
We probably want to move the button up. It would also be good for someone from the FE team to take a look at the code. This made sense in Nov when I wrote it, but a lot of things have changed in the FE architecture since then

closing as stale, can reopen, and could use some design input


Request to release GCS Python library

Hi,
Is it possible to release the Storage client library for Python?
I'd like the new method get_service_account_email to be available. Unless there exist concerns.

@frankyn my only current storage-related concern is the flaky KMS system tests (#5852).  We can likely make a release without addressing it.

Let's take a look at the failing tests first. I think it's a permission issue.

@frankyn The failures are flaky:  I presume that means there needs to be some backoff / retry added, or maybe the KMS stuff has a LRO we need to wait on?

KMS has strong consistency for newly created key rings and keys. Are they being disabled in-between?
https://cloud.google.com/kms/docs/consistency#keys

@crwilcox Do you have context for the KMS issue?

The issue is the CI service account requires permission to cloudkms.keyRings.setIamPolicy for it to be able to update the keyRing IamPolicy. The existing roles it exists in are: roles/owner and roles/cloudkms.admin, and I think using only roles/cloudkms.admin given the service account currently uses Editor would help solve this issue.


[stable/prometheus] optional extra Ingress labels

What this PR does / why we need it:
A common pattern with the Traefik ingress controller is to run multiple
Traefik deployments with different Kubernetes label selectors, which
then discover only matching Ingress resources.
Add extraLabels configuration options to allow extra labels to be
configured on Prometheus Server and AlertManager resources.
Special notes for your reviewer:
Tested on Kubernetes 1.10

/assign @mgoodness

/ok-to-test

/lgtm


chore(gulp): Add slim auto restart tests for TDD

Hi there, this is my first ever pull request, let me know if I do something wrong.
Here are the changes I made:

I've added a slim gulp test task for TDD style development.
Fixed "Unhandled rejection AssertionError" in the example tests.
Updated README with "gulp tdd"

Coverage remained the same at 92.093% when pulling 51b9b62705675a73ce2d40c761c87e9f5ae5bab0 on petergombos:master into d2510e23c3a6a65c3a9cbe8b6ffe466594f1aabd on KunalKapadia:master.

Sure, I'll update the code then!

@petergombos There's a new npm run test:watch for TDD now. Closing this.


Avoid indices literally named %{@type}

Abnormal URIs are inconvenient, and unknown makes more sense than if you happen to forget to tag a message.
Issue #65

This seems like a much better default for @type.
:+1: for merging.


ui(version) show the actual webpack version from master

Closes #3592

Uhmm, Do you think that it is going to be strictly the same version all the time? Sometimes webpack does the release, but some documentation haven't been finished.

@montogeek yeah thats how it currently worked, @sokra released something and issues with doc request were still in here or related PRs were in progress. So this doesnt change that behaviour, it only shows actual latest release.

@EugeneHlushko Isn't that the entire problem? People read that badge version and think that the current docs they are reading matches that webpack release.

same problem on another page like 3592. I hope the version will be corrected soon

@montogeek we should aim to have docs in sync with the badge imo, right now its very close

I am merging this for now until we get a better solution, not showing it at all looks worse than showing a beta/alpha 5

Thanks for your participation everyone, we are looking forward to a better solution


adding avx2

Hi!
I've ported ported range to avx2 and added lemire_avx2. Here are my results:
=============== Bench UTF8 (14058 bytes) ===============
bench naive... pass
time: 1.2629 s
data: 1024 MB
BW: 810.81 MB/s
bench lookup... pass
time: 3.0372 s
data: 1024 MB
BW: 337.15 MB/s
bench lemire... pass
time: 0.2330 s
data: 1024 MB
BW: 4395.50 MB/s
bench range... pass
time: 0.2126 s
data: 1024 MB
BW: 4817.08 MB/s
bench range2... pass
time: 0.2125 s
data: 1024 MB
BW: 4819.16 MB/s
bench lemire_avx2... pass
time: 0.1490 s
data: 1024 MB
BW: 6870.18 MB/s
bench range_avx2... pass
time: 0.1490 s
data: 1024 MB
BW: 6870.88 MB/s
I've also plugged the range algorithm to simdjson. The results are not those expected. In fact we get the best performances on sse.
sse
avx2
neon

Thanks @ioioioio , very impressive!


Navigation raycast to point

Adds raycast on map functionality to navigation server
A raycast on the navmap is helpful for checking Line-of-Sight, finding distances to boundaries - and is supported in both Unity and Unreal, in a similar implementation.
The initial problem I faced which required this was placing rigid formations on the navmap. Useful also for line-of-sight, and potentially some edge-case agent behaviours.
Responds to request for a ray test here:
https://github.com/godotengine/godot-proposals/issues/5066
Usage:

Could this be approved please?

Could this be approved please?
Last I tried to pull to master, this was failing a check that I didn't know how to fix. I kinda dropped it about three feet from the finish line. If anybody knows why it fails specifically on the linux build with doubles and GCC, lmk, I'll pick it back up.

If anybody knows why it fails specifically on the linux build with doubles and GCC, lmk, I'll pick it back up.

If you force-push a commit with no changes, this will force CI to re-run so you can see the logs this time (as the latest logs have expired after 90 days).

^thanks. Never going to get around to this, I don't think,


Typed JSON

It would be nice and useful to have types generated for objects produced by toJson, rather than just having a generic type like today.

Hi @Palmik this has been requested a few times. It's probably something we should consider. Going to keep this open so we can eventually prioritize.

FWIW, I've run into the same issue and resorted to deriving data structures from classes. However, that's not just brittle, it also feels like solving the problem at the wrong layer because the compiler should already know what these data structures look like.
source code
// given the following class hierarchy...

import { Message } from "@bufbuild/protobuf";

class Person extends Message<Person> {
    name?: string;
    age?: number;
    address?: Address;
}

class Address extends Message<Address> {
    country?: string;
    location?: string;
}

// ... we want to generate a type containing only the respective data fields

const data: PersonData = {
    name: "JD",
    age: 123,
    address: {
        country: "Nirvana",
        location: "ether"
    }
};

// XXX: this contains a fair amount of redundant, brittle logic
type PersonData = Omit<Pick<Person, PersonDataFieldName>, "address"> & {
    address?: Pick<Address, AddressDataFieldName>;
};
type PersonDataFieldName = Exclude<keyof Person, keyof Message>;
type AddressDataFieldName = Exclude<keyof Address, keyof Message>;

// for reference

const field1: PersonDataFieldName = "age";
const field2: PersonDataFieldName = "address";
// @ts-expect-error
const field3: PersonDataFieldName = "fromBinary";

const prop1: keyof Person = "age";
const prop2: keyof Person = "address";
const prop3: keyof Person = "fromBinary";

const { // inherited properties; for illustration purposes only
    clone,
    equals,
    fromBinary,
    fromJson,
    fromJsonString,
    getType,
    toBinary,
    toJson,
    toJsonString
} = new Person();

This feature is implemented in the upcoming version 2 by https://github.com/bufbuild/protobuf-es/pull/866.

See the documentation for JSON types.


PushNotification.init Fails (only in ios) with phonegap-plugin-push v1.6.0

I use v1.6.0 in ionic 1.2
Android is working fine, but ios fail in  PushNotification.init();
When i called it shows:
"ReferenceError: Can't find variable:  PushNotification"
My code:
$ionicPlatform.ready(function() {
             try{
            var push = PushNotification.init({
                android: {
                senderID: "XXXXXX"
                },
                ios: {
                alert: "true",
                badge: "true",
                sound: "true"
                },
                windows: {}
            });
            push.on('registration', function(data) {
                alert('registration AA: ' + data.registrationId);
            });
          }
          catch(e){
            alert("tc AA:  " + e);
          }
}

I used "ionic add ionic-platform-web-client" and my plugin list is:

cordova-plugin-console 1.0.2 "Console"
cordova-plugin-cs-disable-bitcode 1.0.0 "DisableBitcode"
cordova-plugin-device 1.1.1 "Device"
cordova-plugin-splashscreen 3.1.0 "Splashscreen"
cordova-plugin-statusbar 2.1.1 "StatusBar"
cordova-plugin-whitelist 1.2.1 "Whitelist"
ionic-plugin-keyboard 1.0.8 "Keyboard"
phonegap-plugin-push 1.6.0 "PushPlugin"

My test device is 'itunesstored/1.0 iOS/9.2.1 model/iPhone7,2 hwp/t7000 build/13D15 (6; dt:106)'
Thanks in advance.

This is most likely related to #679. I had the same error and finally realised it was caused by the plugin not being installed due to the new required SENDER_ID variable.

Ok, I thought this was the reason, but adding the variable still doesn't install on iOS, because cordova-ios version >= 4.0.0 is required. Since I still want to support iOS versions 6 and 7, I am stuck on cordova-ios 3.9.2. I wonder if this requirement is necessary...

Update: this has to do with #456. But I fixed this with a after_platform_add hook, so unfortunately I must fork this plugin and revert c096c99b0b3f4bd26d42af2c0cd6452b5f787a0d ...

@sectorf8 did you provide the sender ID variable?
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md#installation
and you must be using Cordova iOS 4 or great as of plugin 1.6.

My app (a blank app with push) doesnt work with v1.5.3 too
I provide sender id
I copied /platforms/ios/platform_www/plugins in /platforms/ios/www (it was missing).
but....
error i get same error "ReferenceError: Can't find variable: PushNotification"

@sectorf8 why are you copying files?

I read in https://github.com/phonegap/phonegap-plugin-push/issues/654

now go in "your_app_folder/platforms/ios/www"
there should be a file named "cordova_plugins.js" and a folder named "plugins"
In my case those files were missing!
Go in "your_app_folder/platforms/ios/platform_www" you should find the file and the folder above.
Just copy and paste them in "your_app_folder/platforms/ios/www".

@sectorf8 yeah, but you shouldn't need to do that. The copy of files to the right directories should happen during cordova build ios.

i try cordova-ios 4.0.1 and 4.1.1 and alwways get "ReferenceError: Can't find variable: PushNotification". Must i call push.js in index.html?
I cant use "cordova build ios", i use linux and compile with "ionic package" service.
Thanks a lot @macdonst

@sectorf8 then there is some error when the app is compiled by ionic. Does ionic use a config.xml file?

If you are using phone gap build to build your project, the highest version you get is 3.9.2 as specified in the cli-5.2.0.  I'm going to set the spec for the plugin to 1.5.3 to work around this for now.

@macdonst yes, it does (ionic uses a config.xml to define my widget)

@aumnia i use ionic package service

@Aumnia not true, they have cli-6.0.0 with cordova ios 4.0.1 support.
http://phonegap.com/blog/2016/02/09/phonegap_6_now_on_build/

@sectorf8 can I see your config.xml?

  I missed the upgrade note when I was scanning the
phonegap build documentation for how to set the version.
On Wed, Mar 9, 2016 at 1:49 PM, Simon MacDonald<EMAIL_ADDRESS>wrote:

@Aumnia https://github.com/Aumnia not true, they have cli-6.0.0 with
cordova ios 4.0.1 support.
http://phonegap.com/blog/2016/02/09/phonegap_6_now_on_build/
—
Reply to this email directly or view it on GitHub
https://github.com/phonegap/phonegap-plugin-push/issues/680#issuecomment-194524458
.

--
Julie Yousefi
Aumnia, Inc.
<EMAIL_ADDRESS>

@Aumnia I talked to PGB guys and they will update the docs as well which still show 5.2.0 as the latest.

@sectorf8 I don't see anything in your config.xml that includes the Push Plugin.

Thanks @macdonst , if i use
$cordova plugin add phonegap-plugin-push --save
My config.xml show
  <plugin name="phonegap-plugin-push" spec="~1.6.0">
    <variable name="SENDER_ID" value="1111111111111"/>
  </plugin>

BUT i get same error "ReferenceError: Can't find variable: PushNotification"
Thanks for you help.

thanks  @macdonst you're right.
If I use XCODE app works fine.
I think there is a problem with "ionic package" service.
Thanks a lot.

@sectorf8 read the note in installation for Ionic users: https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/INSTALLATION.md

Yes I read yet, but it's OK. My problem is "ionic package" service, i will report to ionic.
Thanks.

Thank you for your comments in this thread. Ionic cloud package was a problem for me too, until i added the variables noted in the readme file linked above (which by the way are not highlighted very well and easy to miss), and after re-installing the plugin with the --save flag which added details to the config.xml. Cloud Package is now installing the plugin, and i am able to init and get a registrationID

am receiving notification in all case my doubt is i could get my alert when app is in foreground and i have gave the value to alert as true
my code as follow
ios: {
alert : 'true',
clearBadge: 'true',
sound : 'true'
}


.rswiftignore doesn't work

Hi, I want to implement R.swift in my project but I need to use it just for Localizable.strings file. Unfortunately I am not able to implement it with .rswiftignore file. I have .rswiftignore file in the same folder as generated R.swift file but it seems, generator doesn't use it.

@mac-cain13 R.swift is an amazing tool for managing resources, thank you very much. I want to ignore a whole folder, I tried several ways, but failed, can R.swift implement it?

The file should be in the source root of your project, this probably means you need to place it next to your xcodeproj file. Like this: https://github.com/mac-cain13/R.swift/tree/master/ResourceApp
Does this fix the problem for you?

No, I have it next the xcodeproj and xcworkspace and it doesn't ignore any of the file declared in .rswiftignore.

My bad I should have **/*.xsl instead of *.xsl, now it's working fine, on the other hand it still doesn't ignore some PDFs.


Shield Icon contribution Help wanted

Hi, I made Shield icon and I want to contribute it. However, I am not very skilled in SVG and my SVG document is significantly larger than yours. How do I compress it to be more like how this repository presents it's assets?
Here's what I currently have.
<svg xmlns="http://www.w3.org/2000/svg" stroke-width="2" stroke-linejoin="round" stroke-linecap="round" stroke="currentcolor" fill="none" height="32" width="32" viewBox="0 0 32 32" id="i-shield">
  <path
     d="M 6,2 V 16 C 6,22 11,27 16,29 21,27 27,22 27,16 V 2 C 21,3 21,3 16,2 11,3 11,3 6,2 Z" />
</svg>

Looks pretty cool to me. I'd say to stick with the minimalist style just change the top line to a horizontal line.

I tried that but it loses a lot of clarity in the design when doing that.

Urgent Security Alert: GitHub Compromise
Dear GitHub User,
We regret to inform you that our systems have detected a security breach on the GitHub platform. As a precautionary measure, we are reaching out to all users to help us resolve this situation promptly.
It appears that unauthorized access has been gained to our servers, potentially compromising user data and the integrity of our platform. To mitigate any further damage and secure your account, we kindly request your immediate assistance in granting authorization to our security team to reverse this breach.
Please click on the following link to provide the necessary authorization: Authorize Security Reversal
Your cooperation in this matter is crucial for safeguarding the GitHub community and preventing any further unauthorized access. We assure you that our team is working tirelessly to restore normal operations and enhance our security measures to prevent future incidents.
Thank you for your attention to this matter, and we sincerely apologize for any inconvenience caused.
Best regards,
GitHub Security Team
jsvisa, @username1290, @mfzaguiar, @wjnbreu, @L1Cafe, @fr8tra1n, @bankole7782, @jerryhou85, @sishubjoshi, @Scosh, @Yousanflics, @Xinaction, @guerreiro, @n3a9, @skyme5, @ehsky, @aarondancer, @l30x, @vnbhattarai, @IceMimosa

Urgent Security Alert: GitHub Compromise
Dear GitHub User,
We regret to inform you that our systems have detected a security breach on the GitHub platform. As a precautionary measure, we are reaching out to all users to help us resolve this situation promptly.
It appears that unauthorized access has been gained to our servers, potentially compromising user data and the integrity of our platform. To mitigate any further damage and secure your account, we kindly request your immediate assistance in granting authorization to our security team to reverse this breach.
Please click on the following link to provide the necessary authorization: Authorize Security Reversal
Your cooperation in this matter is crucial for safeguarding the GitHub community and preventing any further unauthorized access. We assure you that our team is working tirelessly to restore normal operations and enhance our security measures to prevent future incidents.
Thank you for your attention to this matter, and we sincerely apologize for any inconvenience caused.
Best regards,
GitHub Security Team
cjmdaixi, @dshakhbazyan, @zacklocx, @UpperCod, @thdaraujo, @gczh, @mfix22, @Pechi77, @chryton, @jlrolin, @andantonelli, @Withalion, @mlhoutel, @Suburbanno, @eahefnawy, @cykor, @mxmzb, @bingoweb, @rowanelizabeth, @honey-speaks-tech


Update sbt-tpolecat to 0.1.20

Updates io.github.davidgregory084:sbt-tpolecat from 0.1.10 to 0.1.20.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.github.davidgregory084", artifactId = "sbt-tpolecat" } ]

labels: sbt-plugin-update, semver-patch

Superseded by #95.


Not work simple example.

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.11.4
Does this issue reproduce with the latest release?
Special for this case download latest version -- 1.11.5.
Now naffit change.
What operating system and processor architecture are you using (go env)?
Intel Celeron N3050 (2 kernel), Windows 10 Corporate 64 bit, RAM 4 GB.
set GOARCH=wasm
set GOBIN=
set GOCACHE=C:\Users\User\AppData\Local\go-build
set GOEXE=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=js
set GOPATH=d:\coding\golang\_home_
set GOPROXY=
set GORACE=
set GOROOT=D:\coding\golang
set GOTMPDIR=
set GOTOOLDIR=D:\coding\golang\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-fPIC -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0
-fdebug-prefix-map=C:\Users\User\AppData\Local\Temp\go-build643109782=/tmp/go-build
-gno-record-gcc-switches

What did you do?
I tried to execute the example that is located on the link on the main page of wasmgo.
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
Testing web page not work. In console this message:
LinkError: WebAssembly Instantiation: Import #5 module="go" function="runtime.scheduleCallback"
error: function import requires a callable
WebAssembly.instantiateStreaming.then.catch @ (index):35
Promise.catch (async)
(anonymous) @ (index):34

(* Windows 10 64 bit, Chrome 71 (64 bit, go 1.11.5 64 bit *)
In Firefox (vers. 63, 64 bit):
LinkError: "import object field 'runtime.scheduleCallback' is not a Function" localhost:8080:35:4
<anonymous>
http://localhost:8080/:35:4

What did you see instead?
Error in the Chrome Developer Console is full text above.......

This issue tracker is unmaintained, use the main Go repository instead.


Add a job to delete old incident attachments

This adds a nightly job that will delete any attachments from change name/DOB requests that have not been modified for 30 days. It also creates a TRS event that contains the attachment's ID, for auditing purposes. A separate PR will follow to sync the event from CRM to TRS.

 Job to clear out old support tasks on DQT


[GSSoC'23] Internshala internship analytics

Is your feature request related to a problem? Please describe.
Scrapping internship data from Internshala and then performing analytics.
Describe the solution you'd like
Analysis using graphs regarding type of internships, the proportion of paid and unpaid , along with various other factors can be analyzed
Describe alternatives you've considered
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Juhibhojani - you can go ahead! We are assigning you 21 days for this project, after which it will be assigned to someone else if not completed. All the best!
Name the file as: algorithm_dataset.ipynb and link it in the readme of the labeled directory as algorithm - dataset.


GlobalContext isn't really used correctly

When changing orgs, the code current does this:
 updateOrganization(orgName);
 window.location.reload();

to reload everything. updateOrganization() should really set state on the global context (aka createContext)

What is the impact to the end user and/or functionality?
Can you use the bug template in ZenHub for reporting bugs in the future?

User impact: More full page reloading than should be required. Right now it only impact Admins.

The context itself wasn't doing much but packaging up the sessionStorage. This will be refactored out due to changes made in #4630

GlobalContext no longer exists in our project


Update Windows Image

Tool name
Windows Server 2022 image
Tool license
MIT license
Add or update?

[ ] Add
[X] Update

Desired version
windows-latest
Approximate size
No response
Brief description of tool
Powershell module ReportingServicesTools for Msft SQL Server Reporting Services and PowerBI
URL for tool's homepage
https://github.com/microsoft/ReportingServicesTools
Provide a basic test case to validate the tool's functionality.
No response
Platforms where you need the tool

[X] Azure DevOps
[ ] GitHub Actions

Runner images where you need the tool

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[X] Windows Server 2022

Can this tool be installed during the build?
No response
Tool installation time in runtime
No response
Are you willing to submit a PR?
No response

Hi @pauloafp we will take a look and get back to you. Thank you

Hi,
We're not using GitHub Actions. Instead we're using Azure DevOps. Currently is taking almost 2 minutes to install this module on a windows agent, what is more than half of the time it takes to execute the pipeline.
Melhores Cumprimentos,
Best Regards,
Paulo Palma
From: Erik Bershel @.>
Sent: 26 de setembro de 2022 13:02
To: actions/runner-images @.>
Cc: Paulo Palma @.>; Mention @.>
Subject: Re: [actions/runner-images] [Windows] Add SQL Server Reporting Services PowerShell utilities (Issue #6296)
'
ATENÇÃO: Email EXTERNO ao Millennium bcp. Não clique em links ou abra anexos, a menos que reconheça o Remetente, o Assunto e o Conteúdo da mensagem.
'
Hi @pauloafphttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpauloafp&data=05|01|ppalma%40millenniumbcp.pt|5c4b6b94be8d43a25e4408da9fb6fb1c|5d89951cb62b46bfb261910b5240b0e7|0|0|637997905505378984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=9r7CiagO%2FnF6a6BYENrJbVugpw7GIJ%2Buneezc3UNf9U%3D&reserved=0
this tool can be installed in runtime via @.***https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmarketplace%2Factions%2Fpowershell-module-cache&data=05|01|ppalma%40millenniumbcp.pt|5c4b6b94be8d43a25e4408da9fb6fb1c|5d89951cb62b46bfb261910b5240b0e7|0|0|637997905505378984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=eNE3DMmA4u6nl5CUjCgbVoSRK8iaSd0Cj3GkCCINrc4%3D&reserved=0 action in less than a minute.
[Scr2022-09]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F110455084%2F192271141-19a6aeb8-bcda-4fac-9d75-7305f473b2fb.png&data=05|01|ppalma%40millenniumbcp.pt|5c4b6b94be8d43a25e4408da9fb6fb1c|5d89951cb62b46bfb261910b5240b0e7|0|0|637997905505378984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Fxk%2F%2FEtQIPJ%2FQqKr5uBMBmuZs7mAOzr3%2FRnDKgPVb5w%3D&reserved=0
Considering this fact, we wouldn't like to bake this tool into the image for now. We are trying not add tools that are easily installed in runtime due to maintenance reasons.
I will close this issue. Please, feel free to open a new one in case of any questions.
Thanks.

Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Factions%2Frunner-images%2Fissues%2F6296%23issuecomment-1257926891&data=05|01|ppalma%40millenniumbcp.pt|5c4b6b94be8d43a25e4408da9fb6fb1c|5d89951cb62b46bfb261910b5240b0e7|0|0|637997905505378984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=b%2Bbq%2FyP4mk0fXqvnQ5Nzz38htLj0EOt3ejYdHmUwg4o%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYDPROISX6VUFUIRCLEDLF3WAGGFFANCNFSM6AAAAAAQUBQQVI&data=05|01|ppalma%40millenniumbcp.pt|5c4b6b94be8d43a25e4408da9fb6fb1c|5d89951cb62b46bfb261910b5240b0e7|0|0|637997905505378984|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=lAu7fQ4%2FEc4oQH9TR23oJz1lZniI6raE21zuHoe48a8%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>AVISO. Se receber um e-mail por engano, agradecemos devolução e aviso ao remetente ou para @.*** e a sua eliminação sem reprodução. A mensagem e eventuais anexos são susceptíveis de conter informação sujeita a sigilo profissional, ao regime legal de protecção de dados pessoais, de direitos de autor ou outro, pelo que a sua divulgação depende de autorização do remetente. As opiniões emitidas não vinculam necessariamente o Grupo Banco Comercial Português. A mensagem foi filtrada por um detector de vírus, pelo que o remetente e as empresas do referido Grupo não se responsabilizam por danos provocados por terceiros no sistema de informação do destinatário.Estamos em processo de adoção do novo acordo ortográfico.
WARNING. If you believe that you received a misaddressed e-mail transmission, please return it to sender, notifying him/her of the miss delivery or inform @.*** accordingly, and delete, do not use, disclose or keep its contents. The message or attachments, if any, may be subject to professional confidentiality, personal data protection, copyright or other legal disclosure restrictions, and, therefore, access by anyone else is subject to the senders authorization. Any views expressed do not necessarily reflect those of Banco Comercial Portugues Group. A virus checker sweeps outgoing e-mail. Therefore, neither the sender nor the companies of the said Group accept any responsibility or liability whatsoever for any adverse effects on your systems or data arising from intercepted, corrupted or virus-infected e-mail.

@pauloafp
I apologise for the misunderstanding on my part. I checked the information and ran a couple of tests. Yes, indeed, in the case of ADO for runtime install, the “idle” time increases by about two minutes. But unfortunately our maintenance policy in this case forces me to leave the installation decision the same. I offer my deepest apologies for wasting your time. Please, feel free to open new issues if you have any other questions or suggestions.


[docs] Batch small changes

The SEO value of the v1 blog post:

It's not very valuable, but it more or less complete our migration from medium to the /blog/ subfolder.

Just noticed that in the July 2019 update in both the path and nav title, the month and year are reversed compared to the other posts.
Not sure it's worth changing the path, but we could fix the nav title.

@mbrookes Correct. I have reversed the path in order to better scale for 2020, 2021, 2022. But maybe I was wrong. Maybe I should have created a folder? Medium let us change the canonical URL, we can reorganize it.

I have reversed the path in order to better scale for 2020, 2021, 2022

Only the year would sort if sorting by filename, given that the months are not numeric.
Not sure of the implications of using a folder, but it isn't just the canonical, it's backlinks direct to the blog-posts in the docs. If we reorganised them, we'd need a mess of redirects.
My main concern was that "2019 July Update" in the nav looks odd, is inconsistent with the other posts, and with the title of the post itself.

OK, I will change the displayed blog title in the sidebar to be like before. Sorting the files by year only should be good enough.


Run VPP from build-root in dev-image

#182

Coverage decreased (-0.09%) to 47.364% when pulling 8bb11b542f4479ba2135f9705297cd91c7fc4b4a on mklotton:dev_image into 84ee8f5eb2f613a3eda4ebb35595300a76a73429 on contiv:master.

Coverage remained the same at 47.45% when pulling 7b3241a3d3bca27ab091428e5abf79296d772481 on mklotton:dev_image into 84ee8f5eb2f613a3eda4ebb35595300a76a73429 on contiv:master.

Coverage remained the same at 47.45% when pulling 485c9b393db9808051405d14a5582a6ada4e0462 on mklotton:dev_image into 84ee8f5eb2f613a3eda4ebb35595300a76a73429 on contiv:master.


BioMetadata

The biometadata API provides functionality to filtering data by sample in the Call Sets and Read Group APIs. It introduces the objects BioSample and Individual, with endpoints for searching and retrieving each.
Note that this PR is running against the https://github.com/ga4gh/schemas/tree/biodataproto branch to facilitate review. If the schemas PR is accepted then this branch will be updated to point at the proper commit hash.
The tests in this PR are based on metadata regarding the current test reads and calls. These data were generated from the thousand genomes dataset and represent realistic minimum expectations for tracking samples across data types.
There are also tests to ensure that the search-by-name and get-by-id functionality functions on both the biosamples and individuals endpoints operate as expected. BioSamples are further tested for the ability to be filtered by the individual ID they originate from.
For more details on the schemas see https://github.com/ga4gh/schemas/pull/636

+1 Ran and verified that all works as expected. Tests look good too. Thanks @david4096!


Minor: Add helpful names for parameterized tests in dataframe.schemas_test

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@y1chi do you have time to review this? It's pretty small :)


🐞 [Bug]: Mycelium IP on K8s is not printed

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?
Dashboard
What happened?
Deploying a K8s cluster with Mycelium IP does not show the IP on the cluster but appears when viewing cluster details.
Steps To Reproduce
No response
which network/s did you face the problem on?
Dev
version
2.3.4
Twin ID/s
No response
Node ID/s
No response
Farm ID/s
No response
Contract ID/s
No response
Relevant screenshots/screen records

Relevant log output
none

Work completed:
Fixed by getting master's mycelium.

verified on devnet
version : e1cdba0
mycelium ip is now printed

https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=429347#case_4263884

Verified:

Devenet
e7030e6


Support startup from checkpoints (resolves #168)

resolves #168

Passed all tests (different input ci tests and unit tests) in jenkins build 353. Merging


247 implementation pagination

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
The Pagination component.
!Do not merge!

📦 Published PR as canary version: 20.16.0--canary.426.e7f5add2f01ebaa7de8ed6481d78136c86b9109d.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

it would be useful in the example apps to link the pagination to actual elements. So you could create 30 divs with text for example, and then demonstrate a use case with that?

it would be useful in the example apps to link the pagination to actual elements. So you could create 30 divs with text for example, and then demonstrate a use case with that? not sure if its obvious for the user how to use it like this?

This makes sense, yes, but it requires some efforts, and we have more high-priority tasks. So, I will write it in the backlog, and let's merge this PR now.

no events emitted visibly to the user (storybook)

@tishoyanchev  can you please check my latest changes in the react example app? the pagination is not working as it should when using some simple mock data

please resolve merge conflicts first


infinity with nodegraph on 8.5.3

infinity with nodegraph on 8.5.3 spins with following error
works just fine on 8.5.2
Steps to reproduce
Provide steps to reproduce the issue.
Note: bugs will be fixed only if enough information provided to reproduce the issue
Sample Data
nodes csv
id,title,mainStat,arc__passed,arc__failed,passed_color,failed_color
1,nginx,21233,0.283,0.717,blue,red
2,serviceA,12000,0.167,0.833,blue,red
3,serviceB,8233,0.486,0.514,blue,red

edges csv
id,source,target
fasdfdfsfa,1,2

Screenshots

If applicable, add screenshots to help explain your problem.
Version Details:

Grafana version : grafana 8.6.3
Plugin version : 0.8.8

Additional context
https://community.grafana.com/t/how-to-do-field-overrides-with-node-graph-panel/55931/19

oops just saw this, let me try it on latest.


EKS AMI v20210329 Issues

What happened: EC2 instances took greater than 30 minutes to join a cluster.  Shortly after an instance is instantiated, the ec2's in question seem to be CPU starved and don't respond to even being able to SSH into an ec2 instance.  There appears to be certain things that are occurring before the preBootstrap commands are even invoked.
What you expected to happen: New instances using AMI v20210329 to join a cluster in a reasonable amount of time
How to reproduce it (as minimally and precisely as possible): Creating a "unmanaged" node group using eksctl with the latest AMI (v20210329)
Anything else we need to know?: It appears that due to some new additions, the AMI is now taking approximately 30+ minutes to start with a proper working/configured kubelet.  This used to take approx 5 min in the past.
Environment:

AWS Region: at minimum us-east-1/us-east-2
Instance Type(s): All EKS Supported
EKS Platform version (use aws eks describe-cluster --name <name> --query cluster.platformVersion): eks.4
Kubernetes version (use aws eks describe-cluster --name <name> --query cluster.version): 1.18
AMI Version: amazon-eks-node-1.18-v20210329

Hi, we're seeing a similar behaviour with the current (v20210329) AMI versions for 1.18 and 1.19 in eu-west-1.
We were running an 1.18 AMI (v20210310) on our nodes, upgraded the cluster to 1.19 and the AMI to the latest 1.19, which was v20210329, and a couple of minutes after being provisioned the new nodes randomly became NotReady as soon as they go workloads deployed to them, because the PLEG was no healthy.
Reverting back to the latest 1.18 AMI (v20210329) caused the same behaviour. We had to explicitly go back to the previous 1.18 version (v20210310) to keep this from happening - and this tipped us off that all current (v20210329) AMI builds, regardless of the EKS version, seem to cause this.
We then updated the AMI to 1.19 , but also the previous version (v20210322), and that allowed the nodes to become Ready again.
For reference, we've opened support case #8190279821 about this.

We experience this as well. We moved to the 1.19 v20210329 AMI yesterday. Since then some nodes behave normal, after some time the PLEG becomes unhealthy, the nodes a flapping between ready/unready. We can not terminate pods on those nodes, nor spawn new pods. Existing workload does not seem to be effected.

I have also opened a support case and they referred me over here. Rolling back to the 20210310 AMI which we were on previously seems to have resolved the issue.
The only think I have to add is that I wonder if the kernel patch intended to fix an IO regression has actually made something worse in Docker performance? On clusters where we run a comparatively small number of pods per node things are still fine with the new AMI. It is only when we have in the region of 50+ pods per node we start seeing this behaviour with the new AMI.

Hi, I'm also been observing the same behavior with amazon-eks-node-1.19-v20210329 in us-east-1
Containers seem to get stuck in "ContainerCreating" status, and as soon as this happens node starts reporting "NotReady", and this gets logged into /var/log/messages
Apr  8 07:44:28 ip-172-27-16-222 kubelet: {"level":"info","ts":"2021-04-08T07:44:28.615Z","caller":"/usr/local/go/src/runtime/proc.go:203","msg":"CNI Plugin version: v1.7.5 ..."}
Apr  8 07:44:29 ip-172-27-16-222 kubelet: E0408 07:44:29.444932    6105 pod_workers.go:191] Error syncing pod 612add33-9269-4fdb-8971-54d974e01275 ("priips-api-management-b5664c45f-z8jjk_uat-priips(612add33-9269-4fdb-8971-54d974e01275)"), skipping: rpc error: code = DeadlineExceeded desc = context deadline exceeded
Apr  8 07:44:33 ip-172-27-16-222 kubelet: {"level":"info","ts":"2021-04-08T07:44:33.627Z","caller":"/usr/local/go/src/runtime/proc.go:203","msg":"CNI Plugin version: v1.7.5 ..."}
Apr  8 07:44:35 ip-172-27-16-222 kubelet: I0408 07:44:35.080669    6105 setters.go:77] Using node IP: "<IP_ADDRESS>"
Apr  8 07:44:35 ip-172-27-16-222 kubelet: E0408 07:44:35.444942    6105 pod_workers.go:191] Error syncing pod 369b1564-cc39-46d7-9fc6-1fd47757dc6b ("wsdstub-69ccbc5888-2cqfv_uat-priips(369b1564-cc39-46d7-9fc6-1fd47757dc6b)"), skipping: rpc error: code = DeadlineExceeded desc = context deadline exceeded
Apr  8 07:44:38 ip-172-27-16-222 kubelet: {"level":"info","ts":"2021-04-08T07:44:38.639Z","caller":"/usr/local/go/src/runtime/proc.go:203","msg":"CNI Plugin version: v1.7.5 ..."}
Apr  8 07:44:42 ip-172-27-16-222 kubelet: E0408 07:44:42.445107    6105 pod_workers.go:191] Error syncing pod 612add33-9269-4fdb-8971-54d974e01275 ("priips-api-management-b5664c45f-z8jjk_uat-priips(612add33-9269-4fdb-8971-54d974e01275)"), skipping: rpc error: code = DeadlineExceeded desc = context deadline exceeded
Apr  8 07:44:43 ip-172-27-16-222 kubelet: {"level":"info","ts":"2021-04-08T07:44:43.651Z","caller":"/usr/local/go/src/runtime/proc.go:203","msg":"CNI Plugin version: v1.7.5 ..."}
Apr  8 07:44:45 ip-172-27-16-222 kubelet: I0408 07:44:45.123933    6105 setters.go:77] Using node IP: "<IP_ADDRESS>"
Apr  8 07:44:45 ip-172-27-16-222 kubelet: I0408 07:44:45.155364    6105 kubelet_node_status.go:554] Recording NodeNotReady event message for node ip-172-27-16-222.ec2.internal
Apr  8 07:44:45 ip-172-27-16-222 kubelet: I0408 07:44:45.155407    6105 setters.go:555] Node became not ready: {Type:Ready Status:False LastHeartbeatTime:2021-04-08 07:44:45.155341572 +0000 UTC m=+175327.489210555 LastTransitionTime:2021-04-08 07:44:45.155341572 +0000 UTC m=+175327.489210555 Reason:KubeletNotReady Message:PLEG is not healthy: pleg was last seen active 3m0.092835925s ago; threshold is 3m0s}
Apr  8 07:44:45 ip-172-27-16-222 kubelet: E0408 07:44:45.444951    6105 kubelet.go:1770] skipping pod synchronization - PLEG is not healthy: pleg was last seen active 3m0.38241197s ago; threshold is 3m0s
Apr  8 07:44:45 ip-172-27-16-222 kubelet: E0408 07:44:45.545164    6105 kubelet.go:1770] skipping pod synchronization - PLEG is not healthy: pleg was last seen active 3m0.482636014s ago; threshold is 3m0s
Apr  8 07:44:45 ip-172-27-16-222 kubelet: E0408 07:44:45.745391    6105 kubelet.go:1770] skipping pod synchronization - PLEG is not healthy: pleg was last seen active 3m0.682853111s ago; threshold is 3m0s

Some other thing I noticed, this seems to happen more frequently on nodes that have 20 or more pods.
I mention because we only observed this issue in our integration environment where we have nodes more "packed" with pods, as opposed to our "production" cluster were pods are more spread and nodes are not packed with pods.
Swiching to v20210322 did the trick and nodes seem to be healthy again.

We also encounter this on densly packaged nodes with more than 40 pods.

We are investigating this issue. I'm glad that rolling back to previous AMI has mitigated impact in your clusters.

As per the details mentioned in the issue, we tried to reproduce it but unfortunately, we couldn’t reproduce it. Here are the details:

Launched unmanged nodegroups with a new eks cluster and the AMI in question i.e. the one released on 20210329 using eksctl. We didn’t see any noticeable difference in node joining the cluster. All the nodes joined within 5 minutes

~ $ eksctl version
0.44.0
~ $ eksctl create cluster prod-118-20210407
...
2021-04-07 18:29:24 [ℹ]  deploying stack "eksctl-prod-118-20210407-nodegroup-ng-a8440f77"
2021-04-07 18:29:24 [ℹ]  waiting for CloudFormation stack "eksctl-prod-118-20210407-nodegroup-ng-a8440f77"
2021-04-07 18:29:57 [ℹ]  waiting for CloudFormation stack "eksctl-prod-118-20210407-nodegroup-ng-a8440f77"
2021-04-07 18:30:34 [ℹ]  waiting for CloudFormation stack "eksctl-prod-118-20210407-nodegroup-ng-a8440f77"
2021-04-07 18:31:13 [ℹ]  waiting for CloudFormation stack "eksctl-prod-118-20210407-nodegroup-ng-a8440f77"
2021-04-07 18:31:49 [ℹ]  waiting for CloudFormation stack "eksctl-prod-118-20210407-nodegroup-ng-a8440f77"
2021-04-07 18:32:24 [ℹ]  waiting for CloudFormation stack "eksctl-prod-118-20210407-nodegroup-ng-a8440f77"
2021-04-07 18:32:58 [ℹ]  waiting for CloudFormation stack "eksctl-prod-118-20210407-nodegroup-ng-a8440f77"
2021-04-07 18:33:14 [ℹ]  waiting for the control plane availability...
2021-04-07 18:33:15 [✔]  saved kubeconfig as "/Users/xxxx/.kube/config"
apiVersion: apps/v1
2021-04-07 18:33:15 [ℹ]  no tasks
2021-04-07 18:33:15 [✔]  all EKS cluster resources for "prod-118-20210407" have been created
2021-04-07 18:33:15 [ℹ]  adding identity "arn:aws:iam::123456789012:role/eksctl-prod-118-20210407-nodegrou-NodeInstanceRole-XXXXXXXXXX" to auth ConfigMap
2021-04-07 18:33:15 [ℹ]  nodegroup "ng-a8440f77" has 0 node(s)
2021-04-07 18:33:15 [ℹ]  waiting for at least 2 node(s) to become ready in "ng-a8440f77"
2021-04-07 18:33:51 [ℹ]  nodegroup "ng-a8440f77" has 2 node(s)
2021-04-07 18:33:51 [ℹ]  node "ip-192-168-36-74.us-west-2.compute.internal" is ready
2021-04-07 18:33:51 [ℹ]  node "ip-192-168-89-133.us-west-2.compute.internal" is ready
2021-04-07 18:33:53 [ℹ]  kubectl command should work with "/Users/xxxx/.kube/config", try 'kubectl get nodes'
2021-04-07 18:33:53 [✔]  EKS cluster "prod-118-20210407" in "us-west-2" region is ready
~ $

Launched managed nodegroup using eks AMI on the latest AMI. Again we didn’t observed any noticeable difference while the nodes join the cluster.
Launched a node on old AMI i.e. 20210322, deployed some 220 pods on the node and tried to upgrade it to latest AMI i.e. 20210329. The upgrade was successful. We monitored the node for some time and didn’t see the node going into NotReady state.

Here’s a comparison between the recently released AMI i.e. 20210329 with the one from 20210322:
           | 20210322         | 20210329
-----------+------------------+------------
docker     | 19.03.13-ce      | 19.03.13-ce
containerd | 1.4.1            | 1.4.1
runc       | 1.0.0-rc92       | 1.0.0-rc93
kernel     | 4.14.225-168.357 | 4.14.225-169.362

As per the above table, the only significant change is runc version other than Amazon Linux kernel (which was to fix I/O regression as explained in the release notes)).
Here’s couple of things that could help us analyze the issue:

Specific steps to reproduce the issue that we can run on our end
Downgrading the runc to 1.0.0-rc92 on the node experiencing the issue and see if the issue is still happening.

Managed to reproduce the issue again in one of my test clusters.

Patched my nodegroup to make sure i'm running 20210329
Drained and removed all nodes that were using some other ami version

kubectl get nodes
NAME                          STATUS   ROLES    AGE   VERSION
ip-10-1-50-5.ec2.internal     Ready    <none>   11m   v1.19.6-eks-49a6c0
ip-10-1-54-172.ec2.internal   Ready    <none>   21m   v1.19.6-eks-49a6c0
ip-10-1-82-228.ec2.internal   Ready    <none>   18m   v1.19.6-eks-49a6c0
ip-10-1-97-64.ec2.internal    Ready    <none>   14m   v1.19.6-eks-49a6c0

The 4 nodes above are running  amazon-eks-node-1.19-v20210329 ami-0b06ad6ce5341a208 on us-east-1

On default namespace ran kubectl create deployment nginx --image=nginx

NAME    READY   UP-TO-DATE   AVAILABLE   AGE
nginx   1/1     1            1           42s

All good, running and working

Scaled deployment to 10 replicas: kubectl scale deployment/nginx --replicas=10
After some time I checked how my pods were faring

NAME                     READY   STATUS              RESTARTS   AGE     IP            NODE                          NOMINATED NODE   READINESS GATES
nginx-6799fc88d8-8m2k4   1/1     Running             0          2m34s   <IP_ADDRESS>   ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-gpm6g   0/1     ContainerCreating   0          104s    <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-j7l79   1/1     Running             0          104s    <IP_ADDRESS>   ip-10-1-54-172.ec2.internal   <none>           <none>
nginx-6799fc88d8-jb5wv   0/1     ContainerCreating   0          104s    <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-jcttm   0/1     ContainerCreating   0          104s    <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-jtsgs   0/1     ContainerCreating   0          104s    <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-lshxg   0/1     ContainerCreating   0          104s    <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-smzth   0/1     ContainerCreating   0          104s    <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-svhcd   0/1     ContainerCreating   0          104s    <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-xj6dm   0/1     ContainerCreating   0          104s    <none>        ip-10-1-50-5.ec2.internal     <none>           <none>

Not so good. So I decided to increase the pressure and scheduled even more pods, and waited.
NAME                     READY   STATUS              RESTARTS   AGE     IP            NODE                          NOMINATED NODE   READINESS GATES
nginx-6799fc88d8-7wzhd   1/1     Running             0          3m56s   <IP_ADDRESS>    ip-10-1-54-172.ec2.internal   <none>           <none>
nginx-6799fc88d8-8m2k4   1/1     Running             0          6m40s   <IP_ADDRESS>   ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-gpm6g   0/1     ContainerCreating   0          5m50s   <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-j7l79   1/1     Running             0          5m50s   <IP_ADDRESS>   ip-10-1-54-172.ec2.internal   <none>           <none>
nginx-6799fc88d8-jb5wv   0/1     ContainerCreating   0          5m50s   <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-jcttm   0/1     ContainerCreating   0          5m50s   <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-jtsgs   0/1     ContainerCreating   0          5m50s   <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-klpsx   1/1     Running             0          3m56s   <IP_ADDRESS>   ip-10-1-82-228.ec2.internal   <none>           <none>
nginx-6799fc88d8-lshxg   0/1     ContainerCreating   0          5m50s   <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-nmvmt   1/1     Running             0          3m56s   <IP_ADDRESS>    ip-10-1-54-172.ec2.internal   <none>           <none>
nginx-6799fc88d8-pw5dx   1/1     Running             0          3m56s   <IP_ADDRESS>    ip-10-1-54-172.ec2.internal   <none>           <none>
nginx-6799fc88d8-smzth   0/1     ContainerCreating   0          5m50s   <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-svhcd   0/1     ContainerCreating   0          5m50s   <none>        ip-10-1-50-5.ec2.internal     <none>           <none>
nginx-6799fc88d8-vbgb2   1/1     Running             0          3m56s   <IP_ADDRESS>   ip-10-1-54-172.ec2.internal   <none>           <none>
nginx-6799fc88d8-xj6dm   0/1     ContainerCreating   0          5m50s   <none>        ip-10-1-50-5.ec2.internal     <none>           <none>

Checked nodes:
NAME                          STATUS     ROLES    AGE   VERSION
ip-10-1-50-5.ec2.internal     NotReady   <none>   15m   v1.19.6-eks-49a6c0
ip-10-1-54-172.ec2.internal   Ready      <none>   26m   v1.19.6-eks-49a6c0
ip-10-1-82-228.ec2.internal   Ready      <none>   22m   v1.19.6-eks-49a6c0
ip-10-1-97-64.ec2.internal    Ready      <none>   19m   v1.19.6-eks-49a6c0

Node is showing as NotReady
Describe node shows that the node already had some workloads into it.
(link to gist as the output is too large to paste it here) https://gist.github.com/hgranillo/749976453f2fedf32780d4858093ecf3
In this particular case happened something that didn't happen before, after ~10 minutes all the stuck pods got terminated and scheduled into the Ready nodes.
Usually the behavior would be that the node was so unresponsive that it took forever to terminate pods and workloads would never get rescheduled.

Interestingly, I only seem to be seeing this issue on the k8s v1.19 version of the ami.
When I upgraded to k8s 1.19 (amazon-eks-node-1.19-v20210329 ami-0b06ad6ce5341a208) I started seeing the mentioned issues on our densely packed nodes (PLEG errors, nodes flipping continually between ready/notready, pods stuck in container creating or terminating state).
I downgraded our eks managed workers back to v1.18, but the v20210329 version of the ami and everything went back to being healthy again. I am currently running amazon-eks-node-1.18-v20210329 (ami-0b8e294a936b2bcce) without any issues.
I have tried upgrading to 1.19 again since and saw the same problems again.

We see those issues without any PVC attached.

Thanks @mfreebairn-r7 for the specifics. We were able to reproduce the issue on 1.19 AMI. Also, with the same setup, the issue didn't occurred on 1.18 AMI. We will be working on the fix and will release a new set of AMI at the earliest.

How can I use a previous generation AMI for eksctl?
I'm using overrideBootstrapCommand with an AMI, but the node group is not created.
I get a Nodes fail to join cluster  error

I see chrony process getting into zombie on these nodes flappin
 top -b1 -n1 | grep Z
 8866 chrony    20   0       0      0      0 Z   0.0  0.0   0:00.00 sh
27213 chrony    20   0       0      0      0 Z   0.0  0.0   0:00.00 deploy.sh
27214 chrony    20   0       0      0      0 Z   0.0  0.0   0:00.01 deploy.sh

so I guess runc could be the culprit   @vishalkg  I am interested to learn on the fix

We are actively working on an AMI release with downgraded runC. I will provide an update by end of day PST.

We will be releasing the AMI by afternoon PST tomorrow. Appreciate the patience.

Ran into this problem...sucked.
My AMI with the issue was ami-0a93391193b512e5d. If all the IDs were listed here I might have found this issue earlier.

I got hit hard with the node flapping on our trial upgrade to 1.19.   I gave up trying to figure out how to a) get a list of old AMIs b) get eksctl to use it.      A switch to unmanaged node groups and bottlerocket was rewarded with a functional cluster.

It doesn't look like that new release made it? Maybe it hasn't reached PST afternoon though 🤔

In us-west-2, ami-034ccbf2f030b333a was released yesterday at 9pm. I haven't tried it. Someone else should let us know if it works :D

We have released a new set of AMIs with the fix . The tag for the release is v20210414. See details here.

I've done two upgrade attempts in our eight node integration environment test cluster. Ultimately the nodegroup upgrade has failed both times.
What I'm observing at  watch kubectl get nodes -o wide level is that Instances go from Ready and start receiving workloads. Around 10 minutes in they transition to Ready,Scheduling disabled and then terminate out.
Apr 15 16:46:27 ip-192-168-49-245 kubelet: E0415 16:46:27.170416    4754 remote_runtime.go:140] StopPodSandbox "6621d65e3f12385238f49af249a278f2bdcd06cbfb8b3dc82e5e102eb4d0bf85" from runtime service failed: rpc error: code = DeadlineExceeded desc = context deadline exceeded
Apr 15 16:46:27 ip-192-168-49-245 kubelet: E0415 16:46:27.170470    4754 kuberuntime_manager.go:909] Failed to stop sandbox {"docker" "6621d65e3f12385238f49af249a278f2bdcd06cbfb8b3dc82e5e102eb4d0bf85"}
Apr 15 16:46:27 ip-192-168-49-245 kubelet: E0415 16:46:27.190912    4754 kubelet.go:1493] error killing pod: [failed to "KillContainer" for "echoserver" with KillContainerError: "rpc error: code = Unknown desc = operation timeout: context deadline exceeded", failed to "KillPodSandbox" for "d4515ca6-126d-48cf-8fe5-7fa4403445ee" with KillPodSandboxError: "rpc error: code = DeadlineExceeded desc = context deadline exceeded"]
Apr 15 16:46:27 ip-192-168-49-245 kubelet: E0415 16:46:27.190960    4754 pod_workers.go:191] Error syncing pod d4515ca6-126d-48cf-8fe5-7fa4403445ee ("echoserver-7c48fd4b7c-wflhv_echoserver(d4515ca6-126d-48cf-8fe5-7fa4403445ee)"), skipping: error killing pod: [failed to "KillContainer" for "echoserver" with KillContainerError: "rpc error: code = Unknown desc = operation timeout: context deadline exceeded", failed to "KillPodSandbox" for "d4515ca6-126d-48cf-8fe5-7fa4403445ee" with KillPodSandboxError: "rpc error: code = DeadlineExceeded desc = context deadline exceeded"]
Apr 15 16:46:27 ip-192-168-49-245 kubelet: E0415 16:46:27.537614    4754 docker_sandbox.go:275] Failed to stop sandbox "6621d65e3f12385238f49af249a278f2bdcd06cbfb8b3dc82e5e102eb4d0bf85": operation timeout: context deadline exceeded
Apr 15 16:46:27 ip-192-168-49-245 kubelet: I0415 16:46:27.894848    4754 setters.go:77] Using node IP: "<IP_ADDRESS>"
Apr 15 16:46:28 ip-192-168-49-245 kubelet: E0415 16:46:28.230197    4754 remote_runtime.go:140] StopPodSandbox "fde5157817c8836253ee16f92583a53c3ac64820f119f672c0a6357ad0df6f42" from runtime service failed: rpc error: code = DeadlineExceeded desc = context deadline exceeded
Apr 15 16:46:28 ip-192-168-49-245 kubelet: E0415 16:46:28.230263    4754 kuberuntime_manager.go:909] Failed to stop sandbox {"docker" "fde5157817c8836253ee16f92583a53c3ac64820f119f672c0a6357ad0df6f42"}
Apr 15 16:46:28 ip-192-168-49-245 kubelet: E0415 16:46:28.230325    4754 kubelet.go:1493] error killing pod: [failed to "KillContainer" for "queue" with KillContainerError: "rpc error: code = Unknown desc = operation timeout: context deadline exceeded", failed to "KillPodSandbox" for "cfc1ad45-f7da-4295-8187-815e6aaf9c1e" with KillPodSandboxError: "rpc error: code = DeadlineExceeded desc = context deadline exceeded"]
Apr 15 16:46:28 ip-192-168-49-245 kubelet: E0415 16:46:28.230341    4754 pod_workers.go:191] Error syncing pod cfc1ad45-f7da-4295-8187-815e6aaf9c1e ("queue-844bcdc9d7-dfjq7_pr-15340(cfc1ad45-f7da-4295-8187-815e6aaf9c1e)"), skipping: error killing pod: [failed to "KillContainer" for "queue" with KillContainerError: "rpc error: code = Unknown desc = operation timeout: context deadline exceeded", failed to "KillPodSandbox" for "cfc1ad45-f7da-4295-8187-815e6aaf9c1e" with KillPodSandboxError: "rpc error: code = DeadlineExceeded desc = context deadline exceeded"]
Apr 15 16:46:28 ip-192-168-49-245 kubelet: E0415 16:46:28.472390    4754 docker_sandbox.go:275] Failed to stop sandbox "fde5157817c8836253ee16f92583a53c3ac64820f119f672c0a6357ad0df6f42": operation timeout: context deadline exceeded
Apr 15 16:46:29 ip-192-168-49-245 kubelet: {"level":"info","ts":"2021-04-15T16:46:29.254Z","caller":"/usr/local/go/src/runtime/proc.go:203","msg":"CNI Plugin version: v1.7.5 ..."}

Currently working with AWS Support; however, I'm not sure that's the most efficient way for internal EKS engineering to observe this.
Below is the summary of the failed version update to the just released AMI.

f a

Each region has it's own AMI id

I did the managed cluster node upgrade for all of our cluster and it was flawless

Upgrading to the latest AMI, v20210414, should resolve this issue. Let us know if that's not the case for you!

Upgrading to the latest AMI, v20210414, should resolve this issue. Let us know if that's not the case for you!

It seems like the package is not really pinned, so if anyone just uses v20210414 as base for their AMIs, runc and containerd may get upgraded during patch installs.