Redo #30 and fix test

Seems there is a permission issue for me to create a direct branch in repo kbst/terraform-provider-kustomize (described here).
This PR is the fix for tests based on #30:

Though the new terraform plan diff is based on the fields in targeted kustomize data, fiels inside an array is still not able to be processed in the json merge, as a result and compromise, we have to satisfy the targeted array elements by having all fields returned from the cluster, such as imagePullPolicy: Always under the containers array.
creationTimestamp: null in targeted kustomize data will always differ from the value returned from cluster with a concrete timestamp value. Removing creationTimestamp: null fixes it.
Note I've turned off all the ImportStateVerify tests, that is actually due to a limitation of terraform import that is not aware of the data: https://www.terraform.io/docs/commands/import.html#provider-configuration. The fact is that when doing an import, the targeted kustomization from data is not configured at all, causing it to be empty thus the state imported is the "full" manifest without a "base" to compare and process at all. This sounds another flaw of this targeted data approach. People usually have to do an extra terraform apply after the import to have the states trimmed and sync'd. Note this is not a problem specific to our provider but is a terraform wide limitation, other providers using data suffer it too, like this: https://github.com/hashicorp/terraform/issues/17847

All the tests worked before and the test manifests are valid. Having creationTimestamp: null set and imagePullPolicy: Always not set is a use-case the provider needs to support.
If we merge the proposed change, we would force users to make changes to their valid K8s manifests that have previously worked and would work fine with kubectl. I am not convinced this is the right way forward. I think keeping a more verbose diff is the better option.

People with creationTimestamp: null or without imagePullPolicy: Always (in the array) will not be forced to change them, instead they just keep getting diff in terraform plan.
I made such changes to the test manifest just to satisfy the terraform test framework's expectation of a "zero diff after apply" (there is a test after a terraform apply asserting no diff should be found in a following terraform plan).
They fall into two tiers:

Fields like creationTimestamp and resourceVersion that are calculated and assigned on server side are preferred to be omitted in kustomize. Keeping them would incur noisy diffs on terraform plan. If people really want to keep these fields in kustomize and intend not to see the plan diff, they need to change those values to what are actually on server (k8s cluster), e.g., grab the actual creationTimestamp value of a resource once it's applied and use that value in kustomize to mute further plan diffs. On the other hand, the value null of creationTimestamp is an edge case that the propsed new json strip-and-diff approach would skip comparing that will always result in an addition of + creationTimestamp = null, because such null fields are stripped in the 2x 3-way diff for producing the plan diff from actual k8s resource.
Similarly but not exactly same as 1), fields in an array, for example, the imagePullPolicy: Always as one of the fields in container[0] in a deployment, can pop up as a deletion in the plan diff (not defined in kustomize manifest, but does exist on server). Reason is that I don't do a "strip" on an array element at all, meaning, we don't pre-process the container[0] from server against the "targeted" container[0] to hide any fields inside it. People are suggested to amend their kustomize code by adding the imagePullPolicy: Always propagated by server, once they see the planned diff after their first apply. Otherwise they will keep seeing that plan diff of such "deletions". There can be a resolve of this issue by doing deeper "strip" of the fields in arrays too, on an element-by-element basis (container[0] vs container[0], container[1] vs container[1], ...), like how we've been stripping the basic fields of a resource against the "targeted" object.

I think keeping a more verbose diff is the better option.
This would absolutely keep the logic as simple and straightforward for us, however I reckon keeping all the verbose plan may frustrate people by repeating too much diff, especially for thhose having hundreds of resources to maintain.

All in all, I feel both issue 1 and 2 as I described above are just minor noises if people don't choose to change their existing kustomize code. Compared to the full verbose diff, those minor diffs could be more acceptable in my opinion. And issue 2 could even be resolved with some further work doing the "targeted" strip too on array element level.
If you have more reasons going for the simple "verbose diff" way, please let me know and we can have more discussion and evaluation around it.

@pst In addition I've turned the import to only save "minimal" identity of the resource instead of a full manifest so as to have all the tests fixed.
Also a "Limitations" section has been added to README.md to make some clarification.

Ok, I've done some more testing.
Current implementation
$ terraform version
Terraform v0.12.24
+ provider.kustomization v0-beforechange

I run a terraform apply for a Istio installation, to have something sizeable. This results in:
Apply complete! Resources: 63 added, 0 changed, 0 destroyed.

Now, running a terrafrom plan returns, as expected:
No changes. Infrastructure is up-to-date.

When I now switch to the new implementation:
New implementation
$ terraform version
Terraform v0.12.24
+ provider.kustomization v1-afterchange

I run terraform init and then terraform plan I get:
Plan: 0 to add, 8 to change, 0 to destroy.

You can see the full diff in a Gist, it's quite long.
I assumed, this was only because of switching from the old version to the new. So I run terraform apply
Apply complete! Resources: 0 added, 8 changed, 0 destroyed.

The problem is however, running a terraform plan now, will again plan to make the same changes:
Plan: 0 to add, 8 to change, 0 to destroy.

@maxiaohao I still agree with you, less verbose diffs would be good. But this proposed implementation has too many side effects. I did some reading and it seems the CustomizeDiff function could potentially be used to change the displayed diff, without touching the actual state. Maybe that's a viable approach?

Hi @pst,
The diffs in the gist look to be due to the array elements in the json which are not stripped in the current simplifyJSON using jsonmergepatch.
In the above issue 2) as I mentioned, I think a new implementation with array element-by-element simplification could eliminate such annoying diffs.
The bigger concern is 1) with such as creationTimestamp: null legally in user's kustomization, we'll not be able to suppress the diff against the "computed" values from actual resource, however I think leaving such diff to users is not a bad idea.
Please let me know if you are Okay with that plan? If so I'd like to spend more time doing a new implementation of the simplifyJSON with raw json data traversal so resolve issue 2).
On CustomizeDiff, that's a good point. I had a look at it and basically I feel we can make use of diff.SetNew to align new (users' kustomization, tf config) with old (state).
Note that asks for a change from
a) storing the simpilfied slim json (no field above kustomization/tf config will be stored), to
b) storing the full manifest from k8s cluster directly into state.
We are currently with a) in this PR and we have limitations (as mentioned in the readme) in terraform import and refresh where kustomization/users' tf config is not involved where this "target-based" approach requires it.
So I think b) could be a better way to go. Though it requires to change the schema to optional and computed, plus when showing the diff, the whole state'll look bit long and off what is defined in kustomization/tf config, as long as we do the the custom diff properly with the new impl of simplifyJSON, I bet we could be rather precise in showing the diff.
Please also evaluate the idea of b) and let me know what you think.
Thanks!

I would:

Take a fresh start and go back to the previous implementation with the last-applied-config annotation to get rid of all the import issues
Investigate if either CustomizeDiffFunc or SchemaDiffSuppressFunc can be used to cleanup the diff
Try to let the K8s API's server-side-dry-run handle as much of the cleanup as possible. It has access to the OpenAPI schema and should therefor do a better job than a client side 3-way merge

This provider should stay as simple as possible. Leave the hard things to the Kubernetes API. If that's not possible, stick with the more verbose diff.

This has been stale for quite a while. I'll go ahead and close it.

Yeah I did more attempts earlier regarding the CustomizeDiffFunc or SchemaDiffSuppressFunc etc. and seemed none could give a neat fix in terms of the diff stuff. Probably need a look into some other directions in the future.


[stable/kiam] Update serer.service.name from grpc to grpclb

Is this a request for help?:

BUG REPORT:

Version of Helm and Kubernetes:
Helm 2.10.0
Kubernetes 1.10.7
Which chart:
stable/kiam
What happened:
One of the templates (server-service.yaml) hasn't been updated with the original template https://github.com/uswitch/kiam/blob/master/deploy/server.yaml. The value:
  ports:
    - name: grpc
      port: {{ .Values.server.service.port }}
      targetPort: {{ .Values.server.service.targetPort }}
      protocol: TCP

should be
  ports:
    - name: grpclb
      port: {{ .Values.server.service.port }}
      targetPort: {{ .Values.server.service.targetPort }}
      protocol: TCP

So it causes issues with the DNS discovery:
https://github.com/uswitch/kiam/issues/144
What you expected to happen:
server-service port name is equal to grpclb
How to reproduce it (as minimally and precisely as possible):
Install latest chart and see the logs of any of the agents, error like:
_"INFO: grpc: failed dns SRV record lookup due to lookup _grpclb.tcp.kiam-server on <IP_ADDRESS>:53: no such host"
appears

thanks for the catch, doing a pr

@alvgarvilla PR: https://github.com/helm/charts/pull/8003

@cpanato thanks to you! I was about to do it myself right now :)


Coverage % is incorrect

Description
Working with the app, we have created some policies. The coverage % is way off.

Steps to Reproduce
Defined a custom policy with required status.
Expected Behaviour
Coverage % should be below or equal to 100%
Relevant Logs / Console output
N/A
Your Environment
Additional context

Fixed in version 1.0.6

this issue was not reproducible. an update in v1.0.5 fixed this issue on 1-13.


[Feature Request] Support OpenType fonts

Pretty self-explanatory. This lib only supports TrueType fonts and it would be nice if it also supported OpenType.

OpenType support would be appreciated.

as of https://github.com/golang/go/issues/22451 OpenType support + full x/image/font.Face support is in x/image/font.
having gg migrate away from freetype/truetype.Font and to font.Face would be great.


Saving progress

Fixes: #57
Description:
Although a client application is supposed to continuously fetch and process data from the CDC log, it may be stopped either due to user's wish or some unforeseen environmental factor (e.g. there is a power outage). It would be useful for the application to be able to restart and continue from the place where it previously ended processing.
Created new trait responsible for creating checkpoints along with default implementation.  Also created a function spawning new tokio task solely responsible for periodically creating these checkpoints. By using RemoteHandle we should be able to manage said task.
W.I.P.: Need to create more tests, integrate it into existing stream readers, refactor this code and implement reading checkpoints.

Resolved conflicts, applied suggestions and created tests.

Now all tests are passing.


Fix consulrunner build tags for Windows

Whitespace is important. Also, an underscore in the file name implies
the associated tag.
Signed-off-by: Anthony Emengo<EMAIL_ADDRESS>

we merged https://github.com/cloudfoundry-incubator/consuladapter/pull/2/files , as we don't think the redundancy in the filename//build tags has any negative consequences.


Firefox UI glitches with multiple monitors

Firefox 36 on OSX 10.9
With e.g. a laptop hooked up to a (larger) external monitor, there are some odd glitches when moving the window between monitors. Note that these glitches only appear the first time uProxy is clicked after switching screens - if you click away and then click it again to reopen, it appears normal. So overall this is likely low priority, but wanted to note regardless as it certainly looks odd.
Here's a screenshot when moving from the smaller (laptop) monitor to the larger external one:

And here's a screenshot of the reverse direction (larger to smaller):

Possibly related, but when using the larger monitor several times the uProxy window appeared in the middle of the Firefox window instead of at the top right by the addon icon. Not sure if this is desired behavior or not. An example:

The panel position issue is resolved in #1134


Classname removed from every  but the last

When I explicitly pass a classname to a th tag it is stripped from every column but the last one. Is there a way around this?
ex:

...
Thanks.

the problem is right here: https://github.com/glittershark/reactable/blob/master/src/reactable/thead.jsx#L10-L19
for some reason when the child has an object for the children it will properly pass the props.. but if the children is a string it ignores them. Why not build the column object each time like:
                columns.push({
                    key: th.props.column,
                    label: th.props.children,
                    props: filterPropsFrom(th.props)
                });

seems to fix the problem.. but then again I didn't read much into the logic of the children, column === "string";

@mephux
I take you mean something like this (in JSX)?
<Table
     className="table-hover"
     id="myTable"
     sortable={true}
     props={filterPropsFrom(th.props.className)} >

But this doesn't work. Could you give an example of how to assign classnames to <Th> tags?


Add requireEncryption and includeImplicit

Add two more parms (defaulting so that no code changes are needed in the user base) to AutoDetect.
bool requireEncryption ( = false )
bool includeImplicit ( = true )
These defaults reflects the previous codes intentions ( even if it didn't work so well... ).
I would actually recommend
bool requireEncryption ( = true )
bool includeImplicit ( = false )
Can we do that?

Can we please take an object FtpAutoDetectConfig and add all the 4 options there?


support serving the API over unix domain socket

unix://$PATH as listen argument will bind aptly to a unix domain socket
rather than TCP.
This allows binding the API to a UDS rather than a port.
Since aptly has no concept of authentication or any amount of high level
API hardening one needs to bottle it up in some other manner. Binding
to a localhost port is often a step in the right direction, ultimately is
still a scary insecure setup as any user on that host getting compromised
would mean that the entire archive is compromised as well.
UDS on the other hand are basically files and have their access managed
by regular file permission. As such, binding to a socket is in fact
the least insecure way to listen as you'd have to explicitly open up the
socket permissions to an access qualified group. In the most conservative
scenario that means no one but the aptly user can talk to the API, in a
more practical setup apache might get access as well and proxy the UDS
with authentication or limited to GET operations.
Using UDS allows reducing the attack surface of the API server while
preserving all the flexibility.
Fixes #
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change

Checklist

[x] unit-test added (if change is algorithm)
[x] functional test added/updated (if change is functional)
[x] man page updated (if applicable)
[x] documentation updated
[x] author name in AUTHORS

I've revised the commit to return from socket serving (good catch!) and test the /api/version content instead :)

Code looks good, thanks 👍
Would you mind adding note on unix domain socket support to aptly serve command line help (make man should re-generate manual page for you).  And PR for the documentation (website): https://github.com/aptly-dev/aptly-dev.github.io

I've add a help and manpage update to the commit.
FWIW, the manpage generator doesn't seem to like multi-line Example: blocks and loses the newlines. While that looks silly I've kept it this way as the example should be helpful even if incorrectly formatted ^^

https://github.com/aptly-dev/aptly-dev.github.io/pull/33 for website update


You are an accomplice of IT companies violating User Privacy

If you can track and identify user for good by using this approach, you are depriving our right to privacy.
You said that this is only for educational usage but once it is carried out, there is no way to revert.
You are helping big companies like Google by identifying users. And you are violating First Amendment to the United States Constitution.
So I suggest you remove this repo or develop an approach to against it

Demonstration purposes to force the major browser vendors to take action against this vulnerability. Very far from collaborating with the dark side of the force!

@LasmGratel why is it @jonasstrehle responsibility to develop an approach to fix this? He demonstrated this vulnerability as his research project, it's Google's and Apple's job to fix that!

You know he is kind of right. I have been thinking about building a tracking system and this seems perfect. And i think those popup ad companies already implement this system. And companies like Google doesn't really need to because they own the platforms, global internet traffic and literally have tracking scripts embedded inside every page on the internet.
#Brave

@LasmGratel So assume you get your wish and this repo is removed. That would fix the situation... how, exactly? Are you suggesting that @jonasstrehle is the only person in the world capable of writing the software, and removing the repo will magically solve the problem once and forever? Are you even serious?

@LasmGratel @jonasstrehle

Update your browsers or change to brave browser, thats the easy fix at the moment.

when you don't even know what his Constitution does?
hope I do so!

And I would like to assume that the day by which nobody could retain their privacies would come to us eventually, and remove this repo won't magically solve this problem, but I'm sure that as long as this repository exists, the process till that day will be "magically" accelerated. One of you said "Those big companies have their own way of tracking users and steal their privacies", it is not even comparable, at least their methods are not public yet, a normal person can hardly use their ways, but this repo brings a substantial reduction of costs, and also provides a way or some sort of inspirations for those individuals and companies with no ability to develop their own "BIG BROTHER", your repo won't be the direct reason of that day, but you will definitely become an accomplice of this sin. If you're really passionate about "force those big browsers to take action against this vulnerability", then you should not choose this way, absolutely

Also I see you have no action to urge browsers up to release a hotfix. So "force those big browsers to take action" is just a excuse.

@LasmGratel what have you done to improve user privacy? It looks like you're adamant about it, I'm sure you have a track record of pro-privacy actions?
@dylech30th it looks like some people prefer to hide their head in the sand and ignore issues, rather than discuss them in the open. I prefer for vulnerabilities to be published and get fixed by big companies (remember HSTS super cookie?) than silently ignoring them.
Also this vulnerability was discovered way before here: https://www.cs.uic.edu/~polakis/papers/solomos-ndss21.pdf
Did you email this researcher to fix that?
Did you @LasmGratel ?

Please consider the difficulty of turn a paper into real and just use an existing repo directly, while papers can bring significant complexities to prevent most people from reading and take action according to it, think of the 2000 stargazers of this repo, how many of them are actually want to use it for "education purpose", your target can be easily achieved by just providing a demonstration site, instead of giving out the full reproduce steps and source codes. I support publishing these vulnerabilities to notice those big companies, but I'd also prefer to keep the lowest reproducibility

2,000 stars is exactly what we need to have Apple/Google notice and take action. Out of those 2000 stars there will be devs from Google and Apple.

@dylech30th 冲冲冲

I'll keep my point: force those companies to be noticed and take action by publishing those vulnerabilities is good, however, it is better to minimize the reproducibility, because it is hard to know how many new ideas will be inspired by this repo, and it is also hard to know how many of those ideas will be actually used to make a contribution of privacy safety, and how many of them will just be used on some dirty deeds

Some context (Chinese): OP was trying to call for same ideas with them on V2EX, one of the most common community for developers.
However, Chinese developers are way more familiar with this kind of bureaucracy, which is usually represented as:

Whenever there was a problem/question, don't deal with the problem/question; deal with who had raised it.
Eventually OP called for a bunch of mockery on themselves. I think it very valid to leave OP alone and 🤣

People against this repo probably implemented such tracking system, and don't want others to notice this problem.

 Actually, removing this repo does NOTHING but hides your head in the sands.
And, THERE ARE ALREADY LAWS for protecting privacy,  as the author @jonasstrehle  wrote: IT IS FOR EDUCATIONAL AND RESEARCH PURPOSE, why didn't you just SUE those bad companies who dare to violate the laws?

@LasmGratel ask fingerprintjs to take down their repository. I guess they operate in the US.


Flutter Demo App crashes in Chrome

I installed flutter on Ubuntu 16.04 and tried to run the demo counter app in Chrome. after clicking the button 10 times, it crashes with the following error:
semantics_helper.dart:124 Uncaught TypeError: Cannot read property 'Symbol(dartx.remove)' of null at _engine.DesktopSemanticsEnabler.new.tryEnableSemantics (semantics_helper.dart:124)
at _engine.SemanticsHelper.new.shouldEnableSemantics (semantics_helper.dart:43)
at _engine.EngineSemanticsOwner.__.receiveGlobalEvent (semantics.dart:1349)
at HTMLElement. (pointer_binding.dart:172)
Steps to Reproduce

Install flutter on Ubuntu 16.04 with Android Studio
Create new sample flutter project (the counter demo)
Run:
flutter channel dev
flutter upgrade
flutter config --enable-web
cd
flutter create .
flutter run -d chrome
Click on the button (+) eleven times and check the chrome debugger for errors.

flutter run -d chrome --verbose
[  +14 ms] executing: [/home/android-studio/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +23 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 84a1de5c74eb9f7e550c6da776c5b621d5b581f6
[        ] executing: [/home/android-studio/flutter/] git describe --match v*.*.* --first-parent --long --tags
[  +12 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[        ] v1.12.14-29-g84a1de5
[   +4 ms] executing: [/home/android-studio/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[   +7 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/master
[        ] executing: [/home/android-studio/flutter/] git ls-remote --get-url origin
[   +6 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +32 ms] executing: [/home/android-studio/flutter/] git rev-parse --abbrev-ref HEAD
[   +5 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] master
[  +19 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +12 ms] executing: /home/Android/Sdk/platform-tools/adb devices -l
[   +7 ms] Exit code 0 from: /home/Android/Sdk/platform-tools/adb devices -l
[        ] List of devices attached
[  +11 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +119 ms] Generating /home/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
[  +63 ms] Launching lib/main.dart on Chrome in debug mode...
Building application for the web...
[+5820 ms] Starting daemon...
[  +86 ms] Initializing inputs
[   +7 ms] Reading cached asset graph...
[ +112 ms] Reading cached asset graph completed, took 111ms

[ +116 ms] Checking for updates since last build...
[ +322 ms] Checking for updates since last build completed, took 322ms

[   +6 ms] Initializing inputs
[   +1 ms] Reading cached asset graph...
[        ] Reading cached asset graph completed, took 111ms
[        ] Checking for updates since last build...
[        ] Checking for updates since last build completed, took 322ms
[ +502 ms] About to build [web]...
[   +2 ms] Running build...
[ +112 ms] Running build completed, took 54ms

[        ] Caching finalized dependency graph...
[   +3 ms] Caching finalized dependency graph completed, took 72ms

[   +2 ms] Succeeded after 131ms with 0 outputs (0 actions)

Attempting to connect to browser instance..
[+1612 ms] Debug service listening on ws://<IP_ADDRESS>:40381/KS-OK_wUDsQ=

[ +254 ms]       Failed to load asset at path: packages/build_web_compilers/src/dev_compiler/dart_sdk.js.

                 Status code: 404

                 Headers:
                 {
             "date": "Wed, 27 Nov 2019 17:19:05 GMT",
             "content-length": "9",
             "x-frame-options": "SAMEORIGIN",
             "content-type": "text/plain; charset=utf-8",
             "x-xss-protection": "1; mode=block",
             "x-content-type-options": "nosniff",
             "server": "dart:io with Shelf",
             "via": "1.1 shelf_proxy"
           }

                 Content:
                 Not Found}

[  +21 ms] Debug service listening on ws://<IP_ADDRESS>:40381/KS-OK_wUDsQ=

➜  t git:(master) ✗ flutter analyze
Analyzing t...
No issues found! (ran in 0.9s)

➜  t git:(master) ✗ flutter doctor -v
[✓] Flutter (Channel master, v1.12.15-pre.29, on Linux, locale en_GB.UTF-8)
    • Flutter version 1.12.15-pre.29 at /home/android-studio/flutter
    • Framework revision 84a1de5c74 (5 hours ago), 2019-11-27 07:40:51 -0500
    • Engine revision fad1b23c42
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /home/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /home/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /home/android-studio
    • Flutter plugin version 41.1.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (2 available)
    • Chrome     • chrome     • web-javascript • Google Chrome 78.0.3904.108
    • Web Server • web-server • web-javascript • Flutter Tools

• No issues found!

@nturgut @yjbanov

@Sylvus Thanks for letting us know the issue, fix is on the way.

If one fixes to the latest engine code, it should be fixed now.


Chrome on iPhone opens sharing popup twice

First in a new tab as intended and second it replaces current page with a sharing page.

Can’t reproduce it.


[BUG] Community Partners Section is having irregular containers width.

Description of the bug
The Community Partners section on the landing page of the website is having irregular container width.
Please add screenshots (if applicable)

Add any other context about the problem here
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey @siddhi-244 @darkterminal @vinzvinci
I would like to work on this under GSSoc.
Please add the label GSSoC23.
And assign it to me.

Great catch! Assigned ✅

Wooo... nice drive :car:


When making swap transaction after inputting password, error message pops up but transaction still works.

Does this happen every time it is sent? or was it just once? it seems you closed yoroi before entering the password then reopening yoroi-dapp-connector and submit the tx. And after you returned to UI you saw this 2 popups.

It has happened multiple times, at least 3. This could be the issue
actually. I use a password manager so when I click to copy password,
connector closes and I need to open again to complete transaction..
On Mon, 16 Aug 2021 at 11:35, Dmitry Usov @.***> wrote:

Does this happen every time it is sent? or was it just once? it seems you
closed yoroi before entering the password then reopening
yoroi-dapp-connector and submit the tx. And after you returned to UI you
saw this 2 popups.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ergolabs/ergo-dex-frontend/issues/44#issuecomment-899405719,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUNWKJMZMIRKS6G3YNQ27GLT5DSXHANCNFSM5B7AHK6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Understand.
Every time when you close dapp connector you will see some message (tx submitted or user rejected) it is how yoroi dapp connector works. In your situation you see it multiple times because password manager closes connector and you reopen it.
It is not the our UI issue. If you think password manager shouldnt close the dapp connector, please write issue yoroi team. Thanks!


added stale issues and PRs workflow

Description
added stale issues and PRs workflow

Codecov Report

Merging #127 (1b925d9) into main (3d36c1d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   46.14%   46.14%
=======================================
  Files          58       58
  Lines        2815     2815
=======================================
  Hits         1299     1299
  Misses       1504     1504
  Partials       12       12


Sass imports from src/ directory don't work

Is this a bug report?
Yes.
Did you try recovering your dependencies?
Yes, npm v6.4.1
Which terms did you search for in User Guide?
(update the link in the issue template, you are referring people at a welcome README.md now)
I went through the whole Styles And Assets section.
Environment
System:
OS: Linux 4.18 Ubuntu 18.10 (Cosmic Cuttlefish)
CPU: x64 Intel(R) Core(TM) i5-3330 CPU @ 3.00GHz
Binaries:
Node: 11.2.0 - /usr/bin/node
npm: 6.4.1 - /usr/bin/npm
Browsers:
Chrome: 70.0.3538.110
Firefox: 63.0
npmPackages:
react: Not Found
react-dom: Not Found
react-scripts: Not Found
npmGlobalPackages:
create-react-app: Not Found
Steps to Reproduce
> npx create-react-app my-app && cd my-app
> npm i -S node-sass
> Rename App.css into App.scss, update App.js imports.
> Create _vars.scss in src/ dir. Add a sample variable in there.
> Use that var in App.scss (it works), import _vars.scss as follows:
@import 'vars';
> Create a new component in src/components dir, add an .scss for it.
> Try to import _vars.scss as @import 'vars'; (FAILS with File to import not found or unreadable: vars.)

Expected Behavior
Sass imports from ./src (non-relative path, like @import 'vars') are expected to work for sass stylesheets located deeper in the file tree.
At least that's what the docs say: https://facebook.github.io/create-react-app/docs/adding-a-sass-stylesheet (scroll to the bottom).

In earlier versions of CRA, Sass tutorial was recommending to use node-sass-chokidar with --include-path switch (specified in package.json scripts) to enable imports from src/ directory.
Now docs tell to just install node-sass, say nothing about tweaking build scripts and sass imports from src/ apparently should work automatically (which they don't).

I will continue investigating this on my own, but right now the documentation is misleading and that should be fixed.
Reproducible Demo
Derived from Steps to Reproduce section:
https://github.com/arkadyt/sass-imports-bug-cra

Updated the issue.

Worth noting this: https://github.com/facebook/create-react-app/issues/4494#issuecomment-441464956

@qnm, worked like a charm, thanks :)


[ADD]: PHP PHISHING BACKDOOR SCRIPT 👾

Aim

Script to be used during Phishing campaigns as a credentials collector linked to backdoored HTML
action parameter

Details

Having phished for instance login form of the target website, this login form will have it's action attribute changed to direct into this very script.
Then, the script will collect the $_POST data and store them in file (in a print_r format, csv list or both, depending on setting $log_format).
This script also takes care of issuing the warning message of having typed wrong password (or rather of redirecting the user onto file capable of displaying such message, via $wrong_password_url variable).
Then, the script keeps wrong passwords typed numer in a session variable to detect whether specific user has been phished already and he should be redirected to the target site immediately (in order to prevent him looking at the webpage and inspecting it).

Do I want to work on this:

[x]  Yes
[ ] No

Hey there @avinashkranjan & @vanshitaverma 👋🏻
Please assign this issue to me as soon as possible so that i can make more valuable contributions!
Thank you.


Turned the primes document into an embedded resource.

This might help to get started with the embedded resource issue (see #123 ).

There's a problem with the double-check locking implementation. Checking it now.

There's obviously a problem with the format of the embedded file but so far it's not straightforward to find what that is through Travis (works fine on my PC). There's, however, another issue that when multiple instances access PrimesList.Instance and it doesn't happen all the time - however, I've managed to successfully simulated and I've sent a commit into this PR.
I'll try to think of a way to solve the original issue and then see what should be included in this PR and what shouldn't.
I'm 0 commits behind master btw.

Doesn't work on my machine though.
Here's how to reproduce:
# Checkout upstream/master
git clone https://github.com/aalhour/C-Sharp-Algorithms.git
cd C-Sharp-Algorithms

# Get your changes into a branch checked out from upstream/master
git checkout -b nickntg-master master
git pull https://github.com/nickntg/C-Sharp-Algorithms.git master

# Build and run
dotnet build --configuration Release
dotnet test

Here is the output I got:
➜ dotnet build --configuration Release
Microsoft (R) Build Engine version 16.3.0+0f4c62fea for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 28.04 ms for /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/Algorithms/Algorithms.csproj.
  Restore completed in 28.06 ms for /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/DataStructures/DataStructures.csproj.
  Restore completed in 59.7 ms for /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/UnitTest/UnitTest.csproj.
  Restore completed in 31.44 ms for /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/UnitTest/UnitTest.csproj.
  DataStructures -> /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/DataStructures/bin/Release/netcoreapp2.0/DataStructures.dll
  Algorithms -> /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/Algorithms/bin/Release/netcoreapp2.0/Algorithms.dll
  UnitTest -> /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/UnitTest/bin/Release/netcoreapp2.0/UnitTest.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:01.18

➜ dotnet test
Test run for /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/UnitTest/bin/Debug/netcoreapp2.0/UnitTest.dll(.NETCoreApp,Version=v2.0)
Microsoft (R) Test Execution Command Line Tool Version 16.3.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

A total of 1 test files matched the specified pattern.
(a)(s)(z)(x)(d)(c)(f)(v)(a)(z)(s)(x)(c)(v)(f)(d)(f)(c)(d)(v)(s)(x)(a)(z)Walk the graph using DFS from F:
                                                                                [xUnit.net 00:00:02.08]     UnitTest.DataStructuresTests.CuckooHashTableTest.DoTest [FAIL]
                                                                                X UnitTest.DataStructuresTests.CuckooHashTableTest.DoTest [58ms]
  Error Message:
   System.FormatException : Input string was not in a correct format.
  Stack Trace:
     at System.Number.StringToNumber(ReadOnlySpan`1 str, NumberStyles options, NumberBuffer& number, NumberFormatInfo info, Boolean parseDecimal)
   at System.Number.ParseInt32(ReadOnlySpan`1 s, NumberStyles style, NumberFormatInfo info)
   at System.Convert.ToInt32(String value)
   at DataStructures.Common.PrimesList.<>c.<_initializeData>b__7_1(String item) in /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/DataStructures/Common/PrimesList.cs:line 80
   at System.Linq.Enumerable.SelectListIterator`2.ToList()
   at DataStructures.Common.PrimesList._initializeData() in /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/DataStructures/Common/PrimesList.cs:line 80
   at DataStructures.Common.PrimesList.get_Instance() in /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/DataStructures/Common/PrimesList.cs:line 52
   at DataStructures.Dictionaries.CuckooHashTable`2..ctor() in /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/DataStructures/Dictionaries/CuckooHashTable.cs:line 49
   at UnitTest.DataStructuresTests.CuckooHashTableTest.DoTest() in /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/UnitTest/DataStructuresTests/CuckooHashTableTest.cs:line 11
Test run in progress.Remove At 4:
[0] => fst
[1] => sec
[2] => trd
[3] => for
[4] => sxt
[5] => svn
[6] => egt

(d) (x) (f) (c) (s) (d) (v) (a) (z)

                                                                                [xUnit.net 00:00:02.16]     UnitTest.DataStructuresTests.PrimeListTest.DoTest [FAIL]
                                                                                X UnitTest.DataStructuresTests.PrimeListTest.DoTest [9ms]
  Error Message:
   System.FormatException : Input string was not in a correct format.
  Stack Trace:
     at System.Number.StringToNumber(ReadOnlySpan`1 str, NumberStyles options, NumberBuffer& number, NumberFormatInfo info, Boolean parseDecimal)
   at System.Number.ParseInt32(ReadOnlySpan`1 s, NumberStyles style, NumberFormatInfo info)
   at System.Convert.ToInt32(String value)
   at DataStructures.Common.PrimesList.<>c.<_initializeData>b__7_1(String item) in /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/DataStructures/Common/PrimesList.cs:line 80
   at System.Linq.Enumerable.SelectListIterator`2.ToList()
   at DataStructures.Common.PrimesList._initializeData() in /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/DataStructures/Common/PrimesList.cs:line 80
   at DataStructures.Common.PrimesList.get_Instance() in /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/DataStructures/Common/PrimesList.cs:line 52
   at UnitTest.DataStructuresTests.PrimeListTest.DoTest() in /Users/ahmad/PersonalWorkspace/C-Sharp-Algorithms/UnitTest/DataStructuresTests/PrimeListTest.cs:line 11
Test run in progress.Is there an edge from f to c? True. If yes it's weight is: 1.
After removing edges (d-c), (c-v), (a-z):

a: [s(1), x(3)]
z: []
s: [a(1), x(3), d(3)]
x: [s(3), d(1), c(2), a(3)]
d: [x(1), f(1), s(3)]
c: [x(2), f(1)]
f: [d(1), c(1), v(1)]
v: [f(1)]

(a)(s)(x)(z)(d)(c)(f)(v)(a)(z)(x)(c)(v)(f)(d)(s)(f)(d)(c)(v)(s)(x)(a)(z)

(f)(v)(c)(d)(x)(a)(z)(s)(a)(s)(z)(x)(d)(c)(f)(v)(a)(z)(s)(x)(c)(v)(f)(d)Walk the graph using BFS from F:

Test Run Failed.
Total tests: 171
     Passed: 169
     Failed: 2
 Total time: 3.9706 Seconds

The above output matches the output of the Travis build, btw.

Done that. Here's the output from two consecutive runs of dotnet test.
D:\Projects\C-Sharp-Algorithms>dotnet test
Test run for D:\Projects\C-Sharp-Algorithms\UnitTest\bin\Debug\netcoreapp2.0\UnitTest.dll(.NETCoreApp,Version=v2.0)
Microsoft (R) Test Execution Command Line Tool Version 16.3.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

A total of 1 test files matched the specified pattern.

Test Run Successful.
Total tests: 171
     Passed: 171
 Total time: 1,0824 Seconds

D:\Projects\C-Sharp-Algorithms>dotnet test
Test run for D:\Projects\C-Sharp-Algorithms\UnitTest\bin\Debug\netcoreapp2.0\UnitTest.dll(.NETCoreApp,Version=v2.0)
Microsoft (R) Test Execution Command Line Tool Version 16.3.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.51]     UnitTest.DataStructuresTests.HashTableSeparateChainingTest.DoTest [FAIL]
  X UnitTest.DataStructuresTests.HashTableSeparateChainingTest.DoTest [30ms]
  Error Message:
   System.NullReferenceException : Object reference not set to an instance of an object.
  Stack Trace:
     at DataStructures.Dictionaries.ChainedHashTable`2.CopyTo(KeyValuePair`2[] array, Int32 arrayIndex) in D:\Projects\C-Sharp-Algorithms\DataStructures\Dictionaries\ChainedHashTable.cs:line 609
   at UnitTest.DataStructuresTests.HashTableSeparateChainingTest.DoTest() in D:\Projects\C-Sharp-Algorithms\UnitTest\DataStructuresTests\HashTableSeparateChainingTest.cs:line 107

Test Run Failed.
Total tests: 171
     Passed: 170
     Failed: 1
 Total time: 1,0687 Seconds

Perplexed yet?

What is your OS and IDE?

@aalhour Windows 10 with VS 2017.

That's why, there is a different "Format CultureInfo" between the Operating Systems. I get errors on my machine (mac OS) and the tests fail on Travis CI (Ubuntu), can you try implementing a CultureInfo to parse the file?

@aalhour It's not culture info (it's all straight integers anyway - were it for decimals, a CultureInfo.InvariantCulture parameter would be needed on Split()). It's the line splitting that seems to not work as expected with the embedded resource. Still trying to understand why, since it seemed to be working with the file.
I can revert all commits or submit a new, cleaner PR. There still is a separate issue with the double-null check pattern that is lurking around.
What do you want me to do?


Support for linux

What is the update strategy for Linux?  In true Linux fashion there should be a yum repo and and a repo for apt-get.
Additionally it looks like this being discussed in the atom project, https://github.com/atom/atom/issues/2956.
It looks like nuts doesn't differentiate between debian and fedora based distro's.  https://github.com/GitbookIO/nuts/blob/master/lib/nuts.js#L144 and https://github.com/GitbookIO/nuts/blob/master/lib/nuts.js#L145
I am going to submit a PR to support the following platform types.

linux_deb_64
linux_deb_32
linux_rpm_64
linux_rpm_32

I opened #84.  @SamyPesse could you please review?


Issue/79 fallback image

Thanks for the feedback @okbel. I have updated the PR here :)

Looks good!
What do you think, @lfades? Only worried about CLS in case src gets populated later, but I don't think that could happen in any case
🤔

Looks good!
What do you think, @lfades? Only worried about CLS in case src gets populated later, but I don't think that could happen in any case
🤔


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade" workflow

Codecov Report

Merging #51 (e196604) into main (4958138) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #51   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           27        26    -1
=========================================
- Hits            27        26    -1

Impacted Files
Coverage Δ

src/backend-stack.ts
100.00% <100.00%> (ø)

src/lambda/process-metrics-function.ts
100.00% <100.00%> (ø)

src/stateful-stack.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e99f43...e196604. Read the comment docs.


Add support for cloud-init

cloud-init is a widely used approach to customize a VM as it boots for the first time. You can use cloud-init to install packages and write files, or to configure users and security. Because cloud-init is called during the initial boot process, there are no additional steps or required agents to apply your configuration.

More information is available here.
In practice, adding a custom_data input variable could solve this:

custom_data - (Optional) The Base64-Encoded Custom Data which should be used for this Virtual Machine. Changing this forces a new resource to be created.

cosed by #71


Consider XML Author customisations

Consider XML Author extension capabilities, and how they can improve user-experience for document author.
Potentially include:

adding new high level topics, or different types
finding related content
drastically reducing the command available in the UI

Oxygen Editor provides the possibility to adapt the Menu and save the changes into a layout file. We can then provide this file to a client. We can decide, what are the needed buttons and menus to reduce the amount of possible functionality.

Great. Are you able to test/confirm that these get stored when we Export Layout?

Ok.  Page layout and menu organisation stored in Layout, which can be exported & imported.


error ThreadSanitizer failed to allocate...for all windows tests

The recent version of the windows-latest base made an issue with go test -race:
==5480==ERROR: ThreadSanitizer failed to allocate 0x000002351000 (37031936) bytes at 0x200df68450000 (error code: 87)

Some references:

https://github.com/golang/go/issues/46099

The race detector uses ~10x the memory that a run without -race uses.

https://github.com/actions/virtual-environments/issues/785

Good news, maxim-lobanov has created a wrapper configure-pagefile-action task.

However, I think just removing -race for tests on Windows could be a quick-and-dirty but a working cheaper solution for us.

fixed by https://github.com/gobuffalo/.github/commit/f5b131b8983bf63e4f5e15074c632b01cbba9020 (v1.3) with conditional step [1].
[1] https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsif


Support reloading consuming segment using force commit

Another try of #9310

Use force commit to achieve consuming segment reload
Modify HybridClusterIntegrationTest to use LLC to test the consuming segment reload
Make LLC default for integration test because most (if not all) use cases use LLC

Another try of #9310

Use force commit to achieve consuming segment reload
Modify HybridClusterIntegrationTest to use LLC to test the consuming segment reload
Make LLC default for integration test because most (if not all) use cases use LLC

@Jackie-Jiang I will go ahead and delete the PR I started as you pushed the change here. Thanks for driving it as I have been real busy at work these days

@jugomezv Thanks for trying it out. I didn't realize it requires changing the integration test in the beginning

Codecov Report

Merging #9640 (7fa61a3) into master (77fa36d) will increase coverage by 40.49%.
The diff coverage is 60.86%.

@@              Coverage Diff              @@
##             master    #9640       +/-   ##
=============================================
+ Coverage     28.09%   68.58%   +40.49%
- Complexity       53     5308     +5255
=============================================
  Files          1935     1947       +12
  Lines        103815   104145      +330
  Branches      15758    15790       +32
=============================================
+ Hits          29162    71431    +42269
+ Misses        71780    27664    -44116
- Partials       2873     5050     +2177

Flag
Coverage Δ

integration1
?

integration2
24.82% <26.08%> (+0.34%)
:arrow_up:

unittests1
67.36% <80.00%> (?)

unittests2
15.67% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...server/starter/helix/HelixInstanceDataManager.java
75.57% <38.46%> (+0.23%)
:arrow_up:

...local/indexsegment/mutable/MutableSegmentImpl.java
57.88% <85.71%> (+57.88%)
:arrow_up:

...ata/manager/realtime/RealtimeTableDataManager.java
68.96% <100.00%> (+1.53%)
:arrow_up:

...segment/local/data/manager/SegmentDataManager.java
78.57% <100.00%> (+78.57%)
:arrow_up:

...nt/virtualcolumn/VirtualColumnProviderFactory.java
58.33% <100.00%> (+58.33%)
:arrow_up:

...pinot/minion/exception/TaskCancelledException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...nverttorawindex/ConvertToRawIndexTaskExecutor.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...e/pinot/common/minion/MergeRollupTaskMetadata.java
0.00% <0.00%> (-94.74%)
:arrow_down:

...plugin/segmentuploader/SegmentUploaderDefault.java
0.00% <0.00%> (-87.10%)
:arrow_down:

.../transform/function/MapValueTransformFunction.java
0.00% <0.00%> (-85.30%)
:arrow_down:

... and 1392 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[WIP] Remove TempBlobManager

Remove the abomination that is TempBlobManager.
The class is used only as a replacement for DiskBlobManager when running various functional tests. The problem is that we are not testing DiskBlobManager which is the actual class that gets used in the client and needs to be tested.  This change is necessary because I will be making various changes to DiskBlobManager for the blob announcement rework and I will need tests run on the actual class.
To get the tests woring with DiskBlobManager, we use tempfile.mkdtemp() anywhere we can to create temporary working directories that DiskBlobManager and other classes need.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Message

:book:
See http://keepachangelog.com/en/0.3.0/ for details on good changelog guidelines

  Generated by :no_entry_sign: Danger

A couple questions, otherwise LGTM


parallelcluster GUI does not allow viewing of minor versions, but yet complains about incompatible major version.

I created a PCUI for 3.11.0.  I can view my 3.11.0 and prior clusters.  I cannot view my pcluster 3.11.1 clusters.
  The error message in the red bar the top complains:

It seems that 3.11.0->3.11.1 would be a minor version change, not a major version, so I believe the error message is in error.
It would be nice if minor versions could be managed by the major version PCUI?
Reproduce by:
Create a 3.11.0 and 3.11.1 cluster.  Create PCUI for 3.11.0. Fire it up. It will show both clusters. Click on the 3.11.1 cluster and watch the (misleading) error message appear.

Hi Guntram,
Currently, PC UI avoids managing newer cluster versions, regardless of patch/minor version changes. Please use the latest version of PC UI to manage your 3.11.1 clusters.
We will be working on improving PC UI version management.
Thank you,
Hanwen

No worries. I appreciate what we've got. We should just improve the error message at the top.
Thank you!


Request package be moved to JuliaSparse

I'm doing a Julia Summer of Code updating/completing the SSGrB wrapper and providing AD chain rules for the operations. Would you be willing to have this package moved to the JuliaSparse organization? @ViralBShah will facilitate the move.

This is a great idea. @abhinavmehndiratta If ok with you, please let me know and either @Wimmerer or I can give you owner access to JuliaSparse to facilitate the move. Naturally, we'll make sure you continue to have admin access to the package going forward.

Seems like a good idea. Let me know the procedure, I would be happy to help.

I've sent you an invitation to be an owner of JuliaSparse. Once you accept it, you can go to the settings in this repo and transfer the repo to the new org.

I've transferred the ownership, are there any further steps needed ? Will I need to re-register the package ?

Thanks @abhinavmehndiratta! I've got a fairly significant rewrite coming in a few weeks. Would you like me to ping you for review or am I good to merge things once mentors have reviewed?
I will also credit you in the README as original author, of course.

I don't think I'll have the time to work on this project, you can go ahead and make changes as you find suitable. All the best for your JSoC, looking forward to some great stuff !


[Spark] Ensure commit directory is created for old and new tables

Which Delta project/connector is this regarding?

[x] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Description

Remove createLogDirectory and replace all usages with ensureLogDirectoryExists since the latter is optimized for creation rather than existence check now.
Ensure commit directory is created on existing tables when manged-commits is enabled.

How was this patch tested?
UTs
Does this PR introduce any user-facing changes?
No

Yooohoooo. THREE THOUSAND!!


fix: fix Readme for CI doctest

The ci still fails due to the readme also being tested without alloc at some point.
Do we also want to add a cfg flag for alloc in the readme test?

We had that before. Not sure why it was removed.

It's pretty ugly indeed. But also the only way to make it work. Unless we configure the CI to only run tests with the alloc feature, which also seems like a bad idea.
This is a downside of writing the tests directly in README.md and importing them with #![doc = include_str!("../README.md")]. Documentation code written directly in the source code can have hidden lines with an extra #:
# #[cfg(feature = "alloc")] {
// Visible test code goes here
# }

But that has the downside of needing to duplicate a lot of documentation/text. However, it can be automatically generated with https://crates.io/crates/cargo-rdme


Docs update contributing

Step 6 in the description of how to create a development version is now obsolete. I also changed the numbering from hard-coded to automatic. The URL at the end of the page seems to be irrelevant too, it isn't seen when viewed as a web-page.
One of the titles in the intro section could be more conversational in tone.

Hey Keith! Thanks for the corrections! The URL at the end of the page is relevant, since it defines the abbreviation GitHub that is used excessively in the page. Please revert that part of the change.

 Just push another change to your branch and things will be fine!


Import 49bda8c4b0: Removed marketplaceID from Octree::readFromByteArray (by Maki)

This is an automated proposal to look at a commit made by Maki and import it into Overte

Commit:
49bda8c4b0eb3ac12c17ec265b87863d0a70ae79

Author:
Maki

Date:
Mon, 10 Feb 2020 22:47

Removed marketplaceID from Octree::readFromByteArray

Stats:

Filename
Stats
Lines
Added
Removed
Lines in blame

libraries/octree/src/Octree.cpp

5
2
3
⚠ 0

1 files
-
5
2
3
0

To work on this, please assign the issue to yourself, then look at the commit and decide whether this would be a good addition to Overte.

If the commit is useful, tag it with "Tivoli: Keep", and keep it open until it's merged.
If the commit is not useful, tag it with "Tivoli: Discard", and close it.
If the commit is not useful right now, but might be later, tag it with "Tivoli: Maybe later", and close it.
If it's hard to decide, tag it with "Tivoli: Discuss", and keep it open.

Useful commits should be submitted as a PR against Overte. Tag this issue in PR, so that it's automatically closed once the PR is merged.
You can cherry-pick this issue with this command:
git cherry-pick 49bda8c4b0eb3ac12c17ec265b87863d0a70ae79

Marketplace removal, probably breaks the protocol? I think we already have a PR for this in Vircadia


Solve #42 - Add a garbage collector

Closes #42
Context
On this PR, a new BOT was added called GarbageCollector. This BOT archives all the records on a PostgresDB table. Example of use:
options = {
  process_options: {
    connection: {
      host: "localhost",
      port: 5432,
      dbname: "bas",
      user: "postgres",
      password: "postgres"
    },
    db_table: "use_cases"
  },
  write_options: {
    connection: {
      host: "localhost",
      port: 5432,
      dbname: "bas",
      user: "postgres",
      password: "postgres"
    },
    db_table: "use_cases"
  }
}

bot = Bot::GarbageCollector.new(options)
bot.execute

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

69 of 69 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2100

Relevant Lines:
2100

💛  - Coveralls


Revamping Readme

I would like to enhance the readme of this project as the internal readme for each folders' are a lot more descriptive than the outside one. Would like to work on this issue under Hacktoberfest.

You may go ahead


Training with rois RuntimeError: Trying to resize storage that is not resizable

Hi,
I am testing training with the region of interests instead of the full voxels and training using the default training settings and a fully connected network, I successfully ran the prepare data part and when training started I got the error below. I did not save the roi tensors, used the default setting.
clinicadl  version 1.3.1 (with the recent edits in a separate conda environment), python 3.8
./trainDLroi.sh
17:58:14 - Find mask for roi rightHippocampusBox.
17:58:14 - Find mask for roi leftHippocampusBox.
17:58:14 - A new MAPS was created at /home/msa/ADCNDLroi
17:58:14 - Path of json file: /home/msa/ADCNDLroi/maps.json
17:58:16 - Training split 0
17:58:16 - Find mask for roi rightHippocampusBox.
17:58:16 - Find mask for roi leftHippocampusBox.
17:58:16 - Find mask for roi rightHippocampusBox.
17:58:16 - Find mask for roi leftHippocampusBox.
17:58:19 - Working on cuda:1
17:58:19 - Criterion for classification is CrossEntropyLoss()
17:58:19 - Beginning epoch 0.
Traceback (most recent call last):
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/bin/clinicadl", line 8, in
sys.exit(cli())
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/home/msa/clinicadl-dev/clinicadl/train/tasks/classification_cli.py", line 79, in cli
task_launcher("classification", task_specific_options, **kwargs)
File "/home/msa/clinicadl-dev/clinicadl/train/tasks/task_utils.py", line 110, in task_launcher
train(Path(kwargs["output_maps_directory"]), train_dict, train_dict.pop("split"))
File "/home/msa/clinicadl-dev/clinicadl/train/train.py", line 15, in train
maps_manager.train(split_list=split_list, overwrite=erase_existing)
File "/home/msa/clinicadl-dev/clinicadl/utils/maps_manager/maps_manager.py", line 149, in train
self._train_single(split_list, resume=False)
File "/home/msa/clinicadl-dev/clinicadl/utils/maps_manager/maps_manager.py", line 669, in _train_single
self._train(
File "/home/msa/clinicadl-dev/clinicadl/utils/maps_manager/maps_manager.py", line 855, in _train
for i, data in enumerate(train_loader):
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 628, in next
data = self._next_data()
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1333, in _next_data
return self._process_data(data)
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1359, in _process_data
data.reraise()
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/_utils.py", line 543, in reraise
raise exception
RuntimeError: Caught RuntimeError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 302, in _worker_loop
data = fetcher.fetch(index)
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 61, in fetch
return self.collate_fn(data)
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 265, in default_collate
return collate(batch, collate_fn_map=default_collate_fn_map)
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 128, in collate
return elem_type({key: collate([d[key] for d in batch], collate_fn_map=collate_fn_map) for key in elem})
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 128, in
return elem_type({key: collate([d[key] for d in batch], collate_fn_map=collate_fn_map) for key in elem})
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/utils/data/_utils/collate.py", line 120, in collate
return collate_fn_map[elem_type](batch, collate_fn_map=collate_fn_map)
File "/home/msa/miniconda3/envs/ClinicaDL-Dev/lib/python3.8/site-packages/torch/utils/data/utils/collate.py", line 162, in collate_tensor_fn
out = elem.new(storage).resize(len(batch), *list(elem.size()))
RuntimeError: Trying to resize storage that is not resizable

Hi,
I think it might related to the dataset. It is likely that you have two samples in the dataset which do not have exactly the same dimension, therefore the collate function crashes. If you use a num_workers in the dataloader of 0 (with clinicadl it would be --n_proc 0) you might a more detailed stacktrace to help you pinpoint the issue.


Repo name should be with capital P - super sensitive thing for community

Just a note on the repo name which has one of the most classic typos on the product names... It's SharePoint, not Sharepoint... this will jump on every single community member eyes if it's not fixed.

Hi @VesaJuvonen,
Casing has been updated as requested. Closing the issue.


Terrain Generalization

We should experiment with generalizing the terrain using the DEM downsampling suggestions based on Tom Patterson's Web Shaded Relief blog. Here is the DEM downsampling he recommends:

...you can resample DEMs to slightly coarser resolutions to produce more generalized shaded reliefs. This is especially useful at intermediate scales (zoom levels 5-13) that tend to look too noisy. The chart above offers suggested resampling amounts for these zoom levels.

We can also experiment with compositing a "slope shade" on top of the hill shade.
Relates to #74

I think here's an example of what we lost when we removed the slope shade. A user sent in this example of some terrain features that seem to have disappeared in the new version:

To my eye, I see two major differences. First, in the square area we see a plateau, and in the new hillshade you can't see the southwest edge of the plateau, but in the old hillshade you see it fairly strongly. Second, in the banana-shaped area, there is a long, deep valley that trends exactly NW-SE, which is quite visible in the old hillshade, but seems to disappear in the new version.
These are both cases where a terrain feature is lined up perfectly with the direction of the illumination (from the upper left), which causes the hillshade process to throw no shadow at all. But when a slope shade is also included, these inconvenient features at least have some type of definition, so you can still see that they exist.
Thoughts? Am I interpreting these images (and the process) correctly?

I'm thinking that the difference between the two is probably a combination of:

difference in DEM source data
variances in any DEM resampling
light angle
lack of slope shade
the "hard light" composite operation being used by Tessera

It's too bad that we didn't have enough time to experiment more with this part of the process before the v1 launch. I think it's definitely worth attempting to generate an alternative hillshade that's closer to the original stamen terrain tiles.

In a more positive light, it's worth noting that there aren't any visible tile seams in the new hillshade which are visible in the old sample above.


Support for Python 3.8

Hello, is there binaries for python 3.8?

O.k. I guess I found some binaries here. Thanks anyway.


add label when creating the PR

Is there an existing issue for this?

[X] I have searched the existing issues

Feature description
The current behavior we are experiencing is as follows: we specify the labels for Dependabot according to the documentation, as shown below:
# Specify labels for pull requests

version: 2
updates:
  - package-ecosystem: "npm"
    directory: "/"
    schedule:
      interval: "weekly"
    # Specify labels for npm pull requests
    labels:
      - "npm"
      - "dependencies"

All these tags are added after creating the PR.
The problem with this setup is that there is a delay between PR creation and the update that adds the label. Our bot assigns people to the PR, and we want to avoid this.
Can the labels be added during PR creation, and why is it currently done through an update?

Unfortunately, this is a GitHub limitation and  there is little that we can do about it
The only enhancement I can see is to only trigger 1 request with all the labels instead of what we have now. Would that help?
See https://github.com/orgs/community/discussions/24724

there is little that we can do about it

Don't you work at the same company now?

FWIW this also causes our GitHub actions to fail to start, in about half of dependabot PRs. I think because labels are added quickly and there's some race condition in how GitHub handles it.
This was an example: https://github.com/PRQL/prql/pull/4321
Note that that example eventually merged — each time this happens I add-and-then-immediately-remove a label, and that causes it to start a pipeline to start successfully


update yamagi quake 2 - 7.30 => 7.43

Motivation for this change
Update version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

commit message should be: yquake2: 7.30 -> 7.43


Added Don Juan Mask from Hotline Miami

About the PR

Added a new Don Juan Mask from Hotline Miami.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl: Dragma55

add: Don Juan Mask into Misc.

Mask icon is way too big ingame, it's bigger than dwarves.

Re-open when you come back to this.


Validate front matter as a valid Schema.org schema

Blurry front matter is designed to use Schema.org schemas as their front matter for SEO. We can validate that front matter matches a Schema.org type to find missing/extra fields and communicate that in the CLI.
One possible library we could use for those types: https://github.com/lexiq-legal/pydantic_schemaorg

As a matter of fact the current version does not pass https://validator.schema.org/ by default. There is an invalid property "pathname" (for something like webpage). Is there a way to suppress this?

There is an invalid property "pathname" (for something like webpage). Is there a way to suppress this?

Ah! That's a bug, then. It should be available in the template context but not included in the schema. Are you able to open a big for that? If not I should be able to this evening.

Yeah, I can do that!
Am Di., 14. Nov. 2023 um 15:10 Uhr schrieb John Franey <
@.***>:

There is an invalid property "pathname" (for something like webpage). Is
there a way to suppress this?
Ah! That's a bug, then. It should be available in the template context but
not included in the schema. Are you able to open a big for that? If not I
should be able to this evening.
—
Reply to this email directly, view it on GitHub
https://github.com/blurry-dev/blurry/issues/26#issuecomment-1810284714,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADEO4BO5FWHUB2AKCSAROTYEN3W7AVCNFSM6AAAAAA7ID3SQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQGI4DINZRGQ
.
You are receiving this because you commented.Message ID:
@.***>


Font family required

In every header tag should contain font family to change the font style

Solved! Added font family on version 0.0.6


OAuth2 client credentials support for policy store auth

Is your feature request related to a problem? Please describe.
The OPAL Client Configuration Variables currently only support sending static values to OPA through the POLICY_STORE_AUTH_TOKEN. However, our machine-to-machine communication relies on OAuth2 client_credentials, which cannot be implemented with a static token. As a result, we are unable to use the current authentication method provided by the OPAL Client Configuration Variables.
Describe the solution you'd like
To provide more flexibility in authentication for the OPAL Client, we propose adding support for additional authentication methods to communicate with OPA. Specifically, we suggest implementing the ability to create additional tokens using either a token or OAuth2 method.
To enable this functionality, we recommend adding new configuration variables:
POLICY_STORE_AUTH_TYPE
POLICY_STORE_AUTH_OAUTH_SERVER
POLICY_STORE_AUTH_OAUTH_CLIENT_ID
POLICY_STORE_AUTH_OAUTH_CLIENT_SECRET.
If the value "oauth" is found in the POLICY_STORE_AUTH_TYPE variable, the OPAL Client will send the client ID and client secret to the OAuth2 server using the client_credentials standard. The response will include a token with an expiration time. The OPAL Client will use this token to communicate with the OPA agent and will cache it until its expiration before requesting a new one.
By implementing these changes, we can enable the OPAL Client to support a wider range of authentication methods, allowing for more flexibility in machine-to-machine communication.

Hey @scarlier I'm checking this now, will get back to you soon.

Hi @scarlier,
Just checked and I want to make sure I understand your proposition.
OPA does not have built-in OAuth 2 support for authentication, it has Token-based and TLS-based authentication.
You are suggesting OPAL itself will support authenticating against an OAuth2 server with client credentials on behalf of OPA (which is unaware) and will then will inject the OAuth2-powered token into OPA as a static token, same as now.
When the OAuth token is expired, you suggest OPAL will replace it.
The mechanism for that would be to override the system.authz policy (which i think is possible and does not require a restart of the OPA agent, but it might require changes to the way OPAL authenticates to OPA, it needs to be aware of the transition between tokens, maybe with a special context).
Am I understanding correctly?
If I am, will you be willing to contribute this as a pull request? Or is this a feature request?

I mean the following:
Configuring OPA with the following
--server --authentication=token --authorization=basic
Then it is possible to create a policy under package (this is NOT managed by OPAL)
package system.authz

default allow := {
    "allowed": false,
    "reason": "unauthorized resource access"
}

allow := { "allowed": false, "reason": reason } {
    //do some JWT validation based on input.identity
}

Now OPA is configured to only accept requests with a bearer token, and we have control through the special policy package who can access it.

The OPAL Client is then responsible for sending requests to OPA with a header Authorization: Bearer the_oauth_access_token for every request going to OPA.
Challenge
The challenge is how to load the system.authz policy package if OPAL Client did not send the data yet to a fresh OPA instance.
By default, OPA will give a response:
{
    "code": "internal_error",
    "message": "authorization policy missing or undefined"
}

i think we are meaning the same thing @scarlier.
OPAL must manage the token lifetime from outside to OPA, by modifying the token and the system authz policy.
Any chance you are willing to contribute a PR? if not - i will add this to the team's backlog.

Ah yes, I see what you mean @asafc  was only looking at standalone OPAL.
A bit rusty on python, but I'll try to create a pr for this task.


Arbitrary data signature API

Following the pre-conf notion (https://dear-twist-ac1.notion.site/Preconfirmations-API-Specification-1363b4619cb080a6a4cfd170c61771bc), all validators will need to perform a common step, which is signing a delegation.
I suspect future “validator-commitment” modules will also need such signatures.
My recommendation is to establish a generalized “sign arbitrary data” API between VC and commit-boost, with a dedicated domain type that renders slashing impossible.
This will enable commit-boost modules to request the VC (and DVT clusters) to sign arbitrary data, specifically in the pre-conf scenario, a delegate message.
Pros:

Implement once, serve multiple use-cases

Cons:

Might make the implementation more complex/ slower

So just implement signer API for that?


feat: Add append_base_domain option to connections

What this PR does / why we need it:
This option allows to append the base domain of a cluster to host names constructed from SSH services of type NodePort. Also add the missing documentation for option base_domain.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

 Add append_base_domain option to connections to allow appending the base domain of a cluster to host names constructed from SSH services of type NodePort

/approve
/lgtm


Allow collections of references to be stored in schemas

BTW awesome test coverage, thanks for doing the work!


Compatible with Jekyll 3

Seems to work for me.

:+1:

Yep, this works for me too!

🚢 it!

:+1: Thanks for this, merging it in!


lib/generators: withRecursion: don't break attr-sets with special attrs

Description of changes
Note: This is an alternative implementation for https://github.com/NixOS/nixpkgs/pull/168327. Please also read the discussion about the pros and cons of this vs the other PRs in #168327 before deciding which patch is preferable.
cc @Profpatsch @K900 @infinisil @lheckemann

Closes #168327
The issue reported there can be demonstrated with the following
expression:
→ nix-instantiate --eval -E "with import ./. {}; pkgs.lib.options.showDefs [ { file = \"foo\"; value = pkgs.rust.packages.stable.buildRustPackages; } ]"
error: attempt to call something which is not a function but a string

       at /home/ma27/Projects/nixpkgs/lib/trivial.nix:442:35:

          441|   isFunction = f: builtins.isFunction f ||
          442|     (f ? __functor && isFunction (f.__functor f));
             |                                   ^
          443|

Basically, if a __functor is in an attribute-set at depth-limit,
__functor will be set to "<unevaluated>". This however breaks
lib.isFunction which checks for a __functor by invoking __functor
with f itself.
The same issue - "magic" attributes being shadowed by withRecursion -
also applies to others such as
__pretty/__functionArgs/__toString.
Since these attributes have a low-risk of causing a stack overflow
(because these are flat attr-sets or even functions), ignoring them in
withRecursion seems like a valid solution.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Like, these functions do not do anything complicated, yet they are getting absurdly complex.

I might have misunderstood, withRecursion is outside of toYAML, a new and it looks like undocumented function which I don’t know what it’s fo.

.


Redundant usage of Boolean.not()

Obsolete. Superseded by #7034 and #7035
Expected Behavior of the rule

Suggest to replace Boolean.not() by the operator ! if it is possible.
// Compliant
if (!isValid) { ... }
val notValid = isValid?.not() // OK to use .not() for nullable types

// Noncompliant
if (isValid.not()) { ... } // Call .not() could be replaced by the operator !

Context

It might confuse if both of options  are used for boolean iversion. It is harder to understand if a condition is negative because you have to check both the start and the end of the condition.
Automatic refactorings like "Invert 'If' condition" doesn't work correctly with .not(). Applying of such refactoring produces double-negative expression !isValid.not()

Hi @osipxd I think you can use the ForbiddenMethod rule for this thing. Are you not able to do that?

I think you can use the ForbiddenMethod rule for this thing.

Unfortunately not. When I add pattern kotlin.Boolean.not to ForbiddenMethod, detekt reports also !, because .not() is operator fun.

However, this rule might be generalized to "Redundant explicit usage of an operator" with configurable list of operators to be reported.
ExplicitOperatorCall:
    enabled: true
    operators:
      - not
      - plusAssign

By the way, @atulgpt. I've noticed that you prefer to use .not() (at least in this repository), can you elaborate on why should it be used instead of !?
I know the point that ! is easy to miss in expression, but I'm not sure usage of explicit operator completely solves this problem. In addition to the reasons I've described in "Context" section, there is another one reason: until ! is not prohibited from usage, we cannot ensure there will no construction like !isValid.not(). This problem could be solved with something like "Double negative expression" rule, by the way.

Some statistics
Usages of ! in detekt project ~70 files
Usages of .not() in detekt project ~18 files (2 of them is usage of .not() on a nullable type)

By the way, @atulgpt. I've noticed that you prefer to use .not() (at least in this repository), can you elaborate on why should it be used instead of !?
I know the point that ! is easy to miss in expression, but I'm not sure that usage of explicit operator completely solves this problem. In addition to the reasons I've described in "Context" section, there is another one reason: until ! is not prohibited from usage, we cannot ensure there will no construction like !isValid.not(). However, this problem could be solved with something like "Double negative expression" rule.

Some statistics
Usages of ! in detekt project ~70 files
Usages of .not() in detekt project ~18 files (2 of them is usage of .not() on a nullable type)

Hi @osipxd, I think it's my preference as I somehow find .not very easy to use as it  goes very well with my flow of thinking(as you have to apply it at the very end so I don't have to traverse the cursor back to add ! ) also it makes the expression easy to use in a chain of operators
But I am not against forbidding the use of .not in certain condition(it would have been awesome if we can accomplish this using ForbiddenMethod). It's just that I might not be using that rule in my projects
I completely agree with double Inverted rule as that pattern should be disallowed

"Double negative expression" sounds like a great rule for detekt.
And about this rule I don't think we should have a rule that forbids the usage of .not. In general the people see detekt rules as something they should follow as good patterns. Even if they are not enable by default. So I think that your proposal of RedundantExplicitOperatorCall would be a better fit. Also we already have a rule to promote [] over get so maybe we can merge it (I can't recall the name now).

Closing this one in favor of the created issues. Let's continue discussion there.

Closing this one in favor of the created issues. Let's continue discussion there.


Missing file when install

When I had installed this library, in folder Lib, there was only index.js and did not combine AndroidAutoReconciler, AndroidAutoReact, ..... And can you give me a full example of this library? Many thanks.

I was working on my own version of this library. I didn't fork it as this project seems to be abandoned. Here is my repository. I haven't been able to work on it lately but it has most of the features (I think) implemented.

I was working on my own version of this library. I didn't fork it as this project seems to be abandoned. Here is my repository. I haven't been able to work on it lately but it has most of the features (I think) implemented.


Use go-kit/log for REST API

Fixes #149
Signed-off-by: Tobias Guggenmos<EMAIL_ADDRESS>

@Nexucis If you're motivated, feel free to review.

Thanks for the review! If you don't notice any newly arises issues with my changes I'll merge.


MAINTAINERS: remove @jellonek

As you can see on issue tracker - I have too little time to maintain kvm component and even recently in review (https://github.com/coreos/rkt/pull/3304#discussion_r84576995) I missed quite important thing.
This is why I think that I should be no longer maintainer or this component.
I wanted to suggest someone from my old Intel team, but IMO this could be at first discussed on syncup, so I'm leaving that part without any suggestion.

Thanks for letting us know @jellonek - you'll always be welcome to help out more if your situation changes.


runtime visualise data from database

I am using this plugin in nativescript vue project. But observing some issues like database is returning 0 results or the query is not returning expected data.
Wondering if we have a tool to visualise data within database during runtime like in browser.
Thank you.

I'm not sure but I can look into it


About setting different learning rate in different layers

Hi,
I would like to set different learning rate for different layers. For examples, I use the default learning rate settings during training on dataset 1, now I need to train on dataset 2 and I want to keep the first few layers fixed. How do I set the learning rate of some layers to 0?
Thanks in advance if anyone can provide me some answers or hints!

Hi @SimpleXP,
The ModelParam > pretrain > fix_params should fit your need.
If the name of your parameter partially matches any strings in fix_params, the parameter will be frozen.
In the example below, you can see that the first conv, the first stage and all BN gamma beta are fixed as the standard setting.
https://github.com/TuSimple/simpledet/blob/a95605aa053640f9565551b94111a2bdf61d45d2/config/faster_r50v1c4_c5_512roi_1x.py#L130-L133

Hi @SimpleXP,
The ModelParam > pretrain > fix_params should fit your need.
If the name of your parameter partially matches any strings in fix_params, the parameter will be frozen.
In the example below, you can see that the first conv, the first stage and all BN gamma beta are fixed as the standard setting.
https://github.com/TuSimple/simpledet/blob/a95605aa053640f9565551b94111a2bdf61d45d2/config/faster_r50v1c4_c5_512roi_1x.py#L130-L133

Thanks, Roger! Problem solved!


[improve][build] Upgrade Testcontainers to 1.18.3 & docker-java to 3.3.0

Motivation

keep the dependency up-to-date

Modifications
Upgrade Testcontainers to 1.18.3 and docker-java to 3.3.0 .
docker-java version has to be kept in sync with Testcontainers version.
The correct version can be found in the testcontainers pom. For example for 1.18.3, one can find the docker-java version here: https://repo1.maven.org/maven2/org/testcontainers/testcontainers/1.18.3/testcontainers-1.18.3.pom
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

this replaced previous PR #20519

IIRC once we picked to a specific branch we remove the release/xxx label. But that can be argued to still mark which version is fixed.
cc @Technoboy- @RobertIndie

I think the release label is supposed to stay on the PR.

That's how I've been doing it for a year and a half.

IIRC once we picked to a specific branch we remove the release/xxx label. But that can be argued to still mark which version is fixed.
cc @Technoboy- @RobertIndie

@tisonkun That's not how we have been using labels.
We can always change the way. One of the problems is that the process isn't documented. I wrote 2 long emails on the dev list, but I guess nobody has been able to read those yet.
This is the thread: https://lists.apache.org/thread/69mwjso51kzkrv5xgdmw04d9wngbg8br


[Card] closeIcon and openIcon customizable in Card, fix #5488

Add the possibility to change the expandable button Icon in the Card component, this gives more opportunity to customize the component and solves #5488.

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

I've added an integration test that makes a simple control on the color of the open and close Icon passed through the properties.
I hope it's enough.
Every feedback is welcome.

@Gerigot Thanks!

It's a pleasure ;) ... I'm also checking the project 'next', trying to understand how it works and I hope I'll have time to migrate some component.


Provid better installation method

Maybe provide a way of installing an initial Githooks (will get updated afterwards by itself)

by simple curl <script> | bash (like homebrew) method.

install.sh bootstrapper which just  installes Githooks
A install mode which does not setup either --template-dir nor core.hooksPathmeaning full local
Run ~/.githooks/bin/cli install in your repo, and your good to go.

Solved by #124 #121 .
Brew and linux package is difficult as Githooks does its own update logic and must be deactivated for that...


set_xscale() and set_yscale() are called with arguments only if scale is logicle

Fixes #289.

I think tests are outside the scope of this issue, but I opened a new issue addressing this topic more generally in #292.


chore: Add CODEOWNERS file

https://github.com/ethereum-optimism/mocktimism/issues/13

Current dependencies on/for this PR:

main

PR #14

PR #15   👈

PR #16

PR #17

This comment was auto-generated by Graphite.

Fixed it by adding devx pod as maintainers

https://github.com/orgs/ethereum-optimism/projects/54/views/2?pane=issue&itemId=41831165


Repo sync for protected CLA branch

The pull request is created from main637904775373600121 to main to fix git push error for protected CLA branch

@opbld15 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Fixes TTL texture loading exceptions

Closes #704
Introduced probably when @kvakvs was refactoring traffic light texture loader (not all texture files were moved) and we didn't spotted that under review 😕
On 99.9% fixes #714 too.

Awesome catch! Will test this shortly.
I <3 bugfixes!!

My goal was to go below 300 issues (little steps), but... it might be way harder than I thought 😄

If I can get the UI finished for #699 that will fix a big list of issues.


Overflow not handled well

When I change the demo code and clump a bunch of entry times together this pushes some of the labels off the bottom:
const data = [
    { time: new Date(1977, 4, 25), episode: 4, name: "A New Hope" },
    { time: new Date(2015, 11, 18), episode: 7, name: "The Force Awakens" },
    { time: new Date(2015, 11, 18), episode: 7, name: "The Force Awakens" },
    { time: new Date(2015, 11, 18), episode: 7, name: "The Force Awakens" },
    { time: new Date(2015, 11, 18), episode: 7, name: "The Force Awakens" },
    { time: new Date(2015, 11, 18), episode: 7, name: "The Force Awakens" },
    { time: new Date(2015, 11, 18), episode: 7, name: "The Force Awakens" }
];

Result:

Is there any way to avoid this happening?
Ideally I'd like it to look something like this (courtesy of my amazing paint skills):

Is this possible?

Thanks :)


Fix NACK interceptor sendBuffer overridden

Keeps a copy of packet in responder_interceptor, fixes #84
While trying to fix this, I was also thinking about how we might reduce copy/allocations throughout pion. Have implemented a version of this that works within intercepters (unexported for now). any feedback is welcome!

Actually, just realized this doesn't cover header extensions being overridden. Will need to marshal/unmarshal for now. Would be great to use @kevmo314's zero copy headers as well.


[Bug] html-minifier 404

I'm submitting a ...
[x] bug report

Do you want to request a feature or report a bug?
The bug happens when cloning the project and running npm i.

What is the current behavior?
If i clone the project from scratch (wich leaves me in master branch), then use npm i this is the error:

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

Clone.
Run npm i in project folder.

What is the expected behavior?
All working ok.

What is the motivation / use case for changing the behavior?
Fix errors to allow development and testing.

Please tell us about your environment:

Angular version: 2.2.0
Browser: [all | Chrome 54.0.2840.98 | Safari 10.0.1 ]

Ok i removed the entire project and clone it again and now it works, idk why that error popped out.


Reduce some duration of sleep(n) in tests

What was wrong?
Timeout of 0.5 in tests is often more than what is actually needed.
How was it fixed?
Reduced to 0.1.
Cute Animal Picture

@carver yep poking around :)


Add a Hera runner guide

Added a "User guides" tab (and moved the expr guide into there) in #758 that we can start populating

Closing as I've included it in the list of guides to be added in #761