Question: how can I add a server side environment variable?

Hi and truly thanks for this repo!
How can I add an environment variable that is accessible server side in Angular?
For example an API endpoint that is localhost for development and some online endpoint for production.
I have studied the code but can't see an example, apologies if I've missed anything!

Don't think there is support for it at the moment.
I did tackle this by adding a service call to load those environment variables at app startup. Can provide a PR if desired.

Hello, i`m not entirely sure what you mean by your question. But you can stuff like that using webpack.
Don`t know if you mean ENVIRONMENT VARIABLE from system, or just variable that is accessible in your typescript as global variable lets say.
You can provide "global" variable that will be available in all your scripts using https://webpack.js.org/plugins/define-plugin/.
If you want to use System Environment Variable on server side you can since SSR is running in nodejs and process.env.ENV_VARIABLE.
I hope this helps, if not try to be more specific what you need :), i ll try to help you :).

@kukjevov Is right, I actually have it setup already in the project so you should be able to test again process.env.production to set a different BASE_URL for your Apis for example.
https://github.com/MarkPieszak/aspnetcore-angular2-universal/blob/master/src/Angular2Spa/webpack.config.js#L185
You can see it in use here in bootstrap-client: https://github.com/MarkPieszak/aspnetcore-angular2-universal/blob/master/src/Angular2Spa/Client/bootstrap-client.ts#L16
Hope that helps and glad the Starter is helping people get going!
I'm working on doing a super cleanup and 2017 upgrade here soon. Some things aren't working as well now that the projects have split up, want to get it all back together soon!

Hi all/Mark,
Thanks for that, I'll have a look at using process.env, I guess this will only be accessible within an "isNode" if statement, which is fine.
As an aside, really looking forward to Angular 4 and AOT integration! It's great they're moving Universal to the core so it is not left behind and kept in line with Angular Core's standards.
Anyway, once again this project really was a huge help for me, so much appreciated.

So the process.env are set from webpack and become available in your code, so when it builds development mode, in your code (process.env.defelopment) will be true, and process.env.production will be false. You can use those if you need to set something based on those scenarios.
Glad it helped! The project structure might change a bit again, think I'm going to keep it simpler as it originally was and let people split out the projects on their own if they want.

Just as a side note, I am loading a json file with app config setting as I don't see it proper to have those in the webpack config. These settings are per-installation and thus should be easily changed by non technical people. That was the type of solution I was referring to.

Could you please clarify how to use webpack for environment variables or refer me to a link?
The previous links are broken.
I would need something similar to the ng environment where I define a json for each environment and within the Angular application I use something like import { environment } from '../environments/environment';
Then at runtime the variables will be used for the environment build (e.g: ng serve --prod would use production variables).
Is there anything inplace for this or any example I could look at, please?
Thank you

I don't see process.env anywhere in this code.  Was this functionality removed since a year ago?

Yes it was removed. You can pass variables from server to client by adding properties to the TransferData objects. Search the solution for TransferData and find the relevant .ts and cs files to change. I also pass my API endpoint url via transferData in order to avoid having to import { ORIGIN_URL } from '@nguniversal/aspnetcore-engine'; because that import pulls a huge (about 500 kb) bundle of unnecessary server side stuff to the client.  see #512 for info.

Hi!!, Can I get environment variables from the server without using .NET server side?

Did anyone get any progress getting env variables or value of --env in server.ts or if its possible from webpack please help me out here

Did anyone get any progress getting env variables or value of --env in server.ts or if its possible from webpack please help me out here

I am in the same issue. I have an angular app with nodejs backend. In the nodejs app, I used process.env a lot to fetch environment variables. But when I run npm run build:ssr, the code compiles without my already set node environment variables. Hence my code fails. I'm seriously searching for solution

@specialobyno Sorry for the late reply. I made it work using a technique. I wrote an article on it feel free to message me if you're stuck anywhere. Here's the link.


[Feature Request] Expose time_dim parameter on GAE and other advantage estimators

The functional advantage estimators such as generalized_advangate_estimate have a time_dim kwarg. The object-oriented interface for advantage estimation deduces time_dim as tensordict.ndim - 1. It would be nice to expose this time_dim as a parameter on GAE and other objects for advantage estimation. This is relevant for some use cases where it may not be convenient/possible to represent all tensors in the input tensordict with the same time dimension.

You're absolutely right.
There are 2 things we can do:

Use the names of the dimensions that is supported by tensordict to indicate what the time dimension is
do exactly as you say if the time dimension is not marked and default to tensordict.ndim-1 if no dim is passed.
I'll make a PR with this shortly!


successful_active_health_check_uneject_host can cause not wanted outlier uneject

Title: successful_active_health_check_uneject_host can cause not wanted outlier uneject
Description:
This callback function:
https://github.com/envoyproxy/envoy/blob/b5ca88acee3453c9459474b8f22215796eff4dde/source/common/upstream/outlier_detection_impl.cc#L315
doesn't care about the result of the health check or the health transition parameter, only the health flags.
Consider the following scenario:

The peer host becomes not available.
FAILED_ACTIVE_HC health flag is still not set because there was no or not enough failed health check so far.
Outlier detection ejects the host.
If the next health check still doesn't set FAILED_ACTIVE_HC, it will uneject the host regardless of whether the check result was success or failure.

You can see this in a real health check and outlier detection log:
Host <IP_ADDRESS>:40002 is down, first failed health check:
{"health_checker_type":"THRIFT","host":{"socket_address":{"protocol":"TCP","address":"<IP_ADDRESS>","port_value":40002,"resolver_name":"","ipv4_compat":false}},"cluster_name":"cluster_0","timestamp":"2024-02-13T16:15:01.267Z","health_check_failure_event":{"failure_type":"NETWORK","first_check":false},"locality":{"region":"","zone":"","sub_zone":""}}

Outlier detection ejects the host:
{"type":"CONSECUTIVE_5XX","timestamp":"2024-02-13T16:15:03.083Z","cluster_name":"cluster_0","upstream_url":"<IP_ADDRESS>:40002","action":"EJECT","num_ejections":1,"enforced":true,"eject_consecutive_event":{}}

Second failed health check. Callback unejects the host which makes its state healthy, but this is obviousy wrong:
{"health_checker_type":"THRIFT","host":{"socket_address":{"protocol":"TCP","address":"<IP_ADDRESS>","port_value":40002,"resolver_name":"","ipv4_compat":false}},"cluster_name":"cluster_0","timestamp":"2024-02-13T16:15:06.268Z","health_check_failure_event":{"failure_type":"NETWORK","first_check":false},"locality":{"region":"","zone":"","sub_zone":""}}
{"type":"CONSECUTIVE_5XX","timestamp":"2024-02-13T16:15:06.268Z","secs_since_last_action":"3","cluster_name":"cluster_0","upstream_url":"<IP_ADDRESS>:40002","action":"UNEJECT","num_ejections":1,"enforced":false}

Outlier detectiont ejects the host again:
{"type":"CONSECUTIVE_5XX","timestamp":"2024-02-13T16:15:09.084Z","secs_since_last_action":"2","cluster_name":"cluster_0","upstream_url":"<IP_ADDRESS>:40002","action":"EJECT","num_ejections":2,"enforced":true,"eject_consecutive_event":{}}

Third failed health check finally sets FAILED_ACTIVE_HC, callback does nothing just like at the further health checks.
{"health_checker_type":"THRIFT","host":{"socket_address":{"protocol":"TCP","address":"<IP_ADDRESS>","port_value":40002,"resolver_name":"","ipv4_compat":false}},"cluster_name":"cluster_0","eject_unhealthy_event":{"failure_type":"NETWORK"},"timestamp":"2024-02-13T16:15:11.269Z","locality":{"region":"","zone":"","sub_zone":""}}
{"health_checker_type":"THRIFT","host":{"socket_address":{"protocol":"TCP","address":"<IP_ADDRESS>","port_value":40002,"resolver_name":"","ipv4_compat":false}},"cluster_name":"cluster_0","timestamp":"2024-02-13T16:15:11.269Z","health_check_failure_event":{"failure_type":"NETWORK","first_check":false},"locality":{"region":"","zone":"","sub_zone":""}}
{"health_checker_type":"THRIFT","host":{"socket_address":{"protocol":"TCP","address":"<IP_ADDRESS>","port_value":40002,"resolver_name":"","ipv4_compat":false}},"cluster_name":"cluster_0","timestamp":"2024-02-13T16:15:16.270Z","health_check_failure_event":{"failure_type":"NETWORK","first_check":false},"locality":{"region":"","zone":"","sub_zone":""}}
{"health_checker_type":"THRIFT","host":{"socket_address":{"protocol":"TCP","address":"<IP_ADDRESS>","port_value":40002,"resolver_name":"","ipv4_compat":false}},"cluster_name":"cluster_0","timestamp":"2024-02-13T16:15:21.271Z","health_check_failure_event":{"failure_type":"NETWORK","first_check":false},"locality":{"region":"","zone":"","sub_zone":""}}
{"health_checker_type":"THRIFT","host":{"socket_address":{"protocol":"TCP","address":"<IP_ADDRESS>","port_value":40002,"resolver_name":"","ipv4_compat":false}},"cluster_name":"cluster_0","timestamp":"2024-02-13T16:15:26.273Z","health_check_failure_event":{"failure_type":"NETWORK","first_check":false},"locality":{"region":"","zone":"","sub_zone":""}}
{"health_checker_type":"THRIFT","host":{"socket_address":{"protocol":"TCP","address":"<IP_ADDRESS>","port_value":40002,"resolver_name":"","ipv4_compat":false}},"cluster_name":"cluster_0","timestamp":"2024-02-13T16:15:31.274Z","health_check_failure_event":{"failure_type":"NETWORK","first_check":false},"locality":{"region":"","zone":"","sub_zone":""}}

The same has been already mentioned in #28303, but closed without any real outcome.
Since uneject can happen even at failed health check I doubt this was a planned behaviour for successful_active_health_check_uneject_host.
For fix && transition == HealthTransition::Changed should be added to the condition in the callback to
make sure we uneject the host only at that health check which just cleared the FAILED_ACTIVE_HC flag.
Config:
...
cluster_manager:
  outlier_detection:
    event_log_path: /tmp/thrift_health.log
static_resources:
  listeners:
  - name: listener_0
    address:
      socket_address:
        protocol: TCP
        address: <IP_ADDRESS>
        port_value: 50051
    filter_chains:
    - filters:
      - name: envoy.filters.network.thrift_proxy
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.filters.network.thrift_proxy.v3.ThriftProxy
          stat_prefix: ingress_service
          protocol: BINARY
          transport: FRAMED
          payload_passthrough: true
          route_config:
            ...
          thrift_filters:
          - name: envoy.filters.thrift.router
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.network.thrift_proxy.router.v3.Router
              close_downstream_on_upstream_error: false
  clusters:
  - name: cluster_0
    ...
    common_lb_config:
      healthy_panic_threshold:
        value: 0.0
    health_checks:
    - timeout: "5s"
      interval: "5s"
      no_traffic_interval: "10s"
      unhealthy_threshold: 3
      healthy_threshold: 1
      event_log_path: /tmp/thrift_health.log
      always_log_health_check_failures: true
      custom_health_check:
        name: envoy.health_checkers.thrift
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.health_checkers.thrift.v3.Thrift
          method_name: ping
          transport: FRAMED
          protocol: BINARY
    outlier_detection:
      consecutive_5xx: 2
      interval: "10s"
      base_ejection_time: "30s"
      max_ejection_time: "30s"
      max_ejection_percent: 100

CC @wbpcode for outlier detection expertise

&& transition == HealthTransition::Changed

this was the original implementation but later removed based on this comment.  I will take a look on Monday to see if it makes sense to add that check back.
@wbpcode  for any other suggestions

Yes, it depends on what we mean under the successful_active_health_check_ part.
A single successful check or healthy_threshold long series of successful checks.
Since the callback is called after both success and failed checks some additional condition is needed there.
For me the second interpretation seems more reasonable, that is why I suggested the transition.
The first is also ok however little weird: If healthy_threshold is bigger than 1 nobody expect any action for a single success hc.
Also today a callback doesn't get information about the result of the single health check.

Yes, it depends on what we mean under the successful_active_health_check_ part.
A single successful check or healthy_threshold long series of successful checks.

A single successful check is what was implemented because if we rely on healthy threshold (>1 case), the outlier detection might actually "uneject" because its ejection period has passed - so this flag might not be of that use. This flag was introduced to get the benefit of a successful check before the ejection time so that we do not have to wait longer.

Yes, if healthy threshold is big, ejection period is small, then this flag wouldn't have effect. But why is that problem?
But ok, let's stay at the original concept. How the callback can get the result of the current single health check?

it seems the changelog entry for this bug fix was lost during merge conflict resolution. Can it be corrected? Was it backported to 1.29.x?

hi @NersesAM that is just in the latest docs - i was about to update this now anyway - the docs for the supported  branches should be correct already i think


REFPLTB-2650, REFPLTB-2716, Add RPI extender support to hal-wifi-cfg8…

…0211 repo
Reason for change: Enable RPI_EXTENDER compilation flag and fix wifi_getRadioChannels API implementation for getting available 5GHz radio channels.
Test procedure: Checked that OpenSync got needed information from HAL
Risks: None

https://jenkins.code.rdkcentral.com/job/github-triggered/39146/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/6028/ started

Sanity tests for ['RPI4 GW BB'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/22715/

Sanity tests for ['TURRIS GW BB'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/22716/


Support other achitectures

Hi =) At first i have to say Hypriot is one of my absolut favorite Systems! It has everything I need and more! Therefore I wanted to ask, if it is possible to support other architectures (like amd64) to, as I want to use it on my servers =)

Arm64 build is mentioned on https://github.com/hypriot/image-builder-rpi/issues/291


CSS validation issues

Typo @ Emoji.css
https://github.com/joeattardi/picmo/blob/7a996dbc0a94a771beba573a66861e7484b7a0b9/packages/picmo/src/views/Emoji.css#L24
Should be solid instead of soldi.
Test by going to:
https://jigsaw.w3.org/css-validator/validator.html.en#validate_by_input
Enter this CSS (omit the CSS variable as that alone would actually pass the validation):
.test {
  outline: 1px soldi #fff;
}

Invalid values for linear-gradient
https://github.com/joeattardi/picmo/blob/efd47b0367bff64f1f23d92a60cf519acd60e305/packages/picmo/src/styles/index.css#L39-L45
Test by going to:
https://jigsaw.w3.org/css-validator/validator.html.en#validate_by_input
Enter this CSS:
.test {
  background-image: linear-gradient(
    90deg,
    rgba(#fff, 0) 0,
    rgba(#fff, 0.2) 20%,
    rgba(#fff, 0.5) 60%,
    rgba(#fff, 0)
  );
}

The values passed to rgba should be RGB values, not hexadecimals.
Types are incompatible
https://github.com/joeattardi/picmo/blob/7a996dbc0a94a771beba573a66861e7484b7a0b9/packages/picmo/src/views/CategoryTabs.css#L60
This produces the following CSS validation issue:
Value Error : max-width The types are incompatible ))

Test by going to:
https://jigsaw.w3.org/css-validator/validator.html.en#validate_by_input
Enter this CSS:
.test {
  max-width: min(calc(8 * 2rem * 1.3 + 2.75rem), calc(var(--category-count) * 2.5rem));
}

The reason for this to fail is that the --category-count CSS variable is not readable through the CSS as it is assigned dynamically through the JS here:
https://github.com/joeattardi/picmo/blob/7a996dbc0a94a771beba573a66861e7484b7a0b9/packages/picmo/src/views/EmojiPicker.ts#L316
But if you pass this CSS to the validator it actually passes because the CSS parser can now read the CSS value:
:root {
  --category-count: 1;
}

.test {
  max-width: min(calc(8 * 2rem * 1.3 + 2.75rem), calc(var(--category-count) * 2.5rem));
}

This issue causes an HTML validation error on the page because the styles are injected to the page but the CSS variable is not. HTML validation issues can cause issues during accessibility evaluations.

Yikes, those are definitely not valid CSS colors. No idea where those came from. I even wrote a book on CSS and didn't catch it. Probably in a late night coding session. :) I tested the generated stylesheets and they all pass the validator now, this will be fixed in the next release.


Documentation

The library currently has no documentation.  We need to look at what other Python libraries use for docs and come up with a plan to create some.

I think, it's first importantly to decide what we want our documentations to convey, multiple categories include

the functions the library has and small examples as to how we can use them (most python small libraries use this, personally i find this less explanatory and not efficient

The functions along with the algorithm/basic intuition with how they work and a good number of examples (libraries such as NLTK, Sklearn, Keras, use this because it is important to understand what each function is doing, I think this is a good way to start)

I documentation which involves showing our source code and explaining what it does,  a few examples. (Pytorch has such a documentation, this is because it encourages users to highly custamize the classes pytorch provides)

Since PySBOL implements the second type, I am guessing we should stick with that, however since we are to integrate dnaplotlib, I strongly suggest we choose a better apt template.


Do not manage /etc/mailname

/etc/mailname is managed on all our systems (including those not running Postfix) through site.pp.
Using this module produces the following error, even if manage_conffiles is false:
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: File[/etc/mailname] is already declared in file /etc/puppet/code/environments/production/modules/postfix/manifests/files.pp:31; cannot redeclare at /etc/puppet/code/environments/production/manifests/site.pp:20 at /etc/puppet/code/environments/production/manifests/site.pp:20:3 on node xx
Also there should ideally be a separate flag to not attempt to manage /etc/mailname, since this manage_conffiles flag also affects other important files that should be managed.

we also need to not manage /etc/mailname here, in fact, it should be absent.

I'm fine with a flag to not manage it.

actually, looking at the source, it seems there's an undocumented manage_mailname setting that does exactly what we need here. maybe this issue should be closed after all.

Fixed by #312


weird highlighting while running neovim inside a tmux session

My nvim config

My tmux config
This is not the case when using a different colorscheme.

Sorry my bad. Didn't read the documentation


fix(extra/rust): xcbuild requires 2 paths to be exposed by env

Symptoms

$ cargo build
error: linking with `cc` failed: exit status: 134
  |
  = note: LC_ALL="C" PATH="/nix...
...
  = note: xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun
          libc++abi: terminating with uncaught exception of type std::runtime_error: codesign_failed: 1
          /nix/store/pz87iqygyl6gklpqlwd8bjs8sqd6hvl3-post-link-sign-hook: line 4: 74910 Abort trap: 6           CODESIGN_ALLOCATE=codesign_allocate /nix/store/ss3qicb0gzh00f87c6xs9nfdj92mad8k-sigtool-0.1.3/bin/codesign -f -s - "$linkerOutput"

This is actually a mint cargo workspace with `lsp`, and many other "hello world" crates
$ cargo build
error: linking with `cc` failed: exit status: 134
  |
  = note: LC_ALL="C" PATH="/nix/store/40rb2myhi22n2jr3a1f5r7n673j1llcw-rust-minimal-1.72.0-nightly-2023-06-29/lib/rustlib/aarch64-apple-darwin/bin:/nix/store/hayj70xixmzri25f0c2vbdrn1q3xy31s-devs
hell-dir/bin:/nix/store/ysnid4p0w4r9kg9834i327j4lxhcb50f-bash-interactive-5.2-p15/bin:/path-not-set:/Users/hungtran/local_repos/zork/.bin:/Users/hungtran/.nix-profile/bin:/nix/var/nix/profiles/de
fault/bin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/hungtran/Applications/Home Manager Apps/kitty.app/Contents/MacOS:/nix/store/cp70ajpjw8arik7x8rrq27w1swv
22s9r-neovim-ruby-env/bin:/nix/store/c6jz0w2gwc4clmhawsmh203yrh31pq6m-nodejs-18.16.1/bin:/nix/store/ihn63vylyqmjjgr63r9shzvrjbfv16jg-tree-sitter-0.20.8/bin:/nix/store/vbn3abzrfj32qy59g868hb7ndrwk
igl0-fzf-0.42.0/bin:/nix/store/ndy7daf60jsqwaqzm5b8g44fvra43sc0-ripgrep-13.0.0/bin:/nix/store/dkjx87xjnh7kk2yjbsqw608jgpp2a4j6-zk-0.14.0/bin:/nix/store/s55k81yblx0k1qdily40n7jl67215ivs-fd-8.7.0/b
in:/nix/store/4ypgz0lrii62saqgrcn432sa13clqns0-clang-11.1.0-lib/bin:/nix/store/pi2c2p233k099y0d21mwjkhnyg8r9wa5-nil-2023-05-09/bin:/nix/store/bx4g81bdsq9mlby0dijlr82xcgwk8mry-rust-minimal-1.72.0-
nightly-2023-06-29/bin:/nix/store/wkrvjivxffs6g7q728n12mgb427yhggj-nickel-1.0.0/bin:/nix/store/vjb7cj5ljmkqljcnzj6rmbc2n24vh9c4-nls-1.0.0/bin:/nix/store/fjbcw6iz6h3gyi6yigin682gcsbn6994-sg.nvim/b
in:/nix/store/1qmphwp6j96aimch0z9rjq7xlrkf3dyv-go-1.20.5/bin:/nix/store/vxs6h5zj2lnij97w207ml2bqv4bmqqya-lua-language-server-3.6.22/bin:/nix/store/i2ga2q14vr1dwbh3iz6nk06jqi451gz8-pyright-1.1.316
/bin:/nix/store/cfmx8v5iigf3i0rm1z2wdyfn2bqpy9hp-python3.10-pylint-2.16.2/bin:/nix/store/dhj27qx5c2yx4bzq12j18yzlsvyqqbg0-python3.10-flake8-6.0.0/bin:/nix/store/9prmj5wrivli1ijshg09gd8j5zzq07iv-a
pple-framework-System-11.0.0/bin:/nix/store/vfvlqvyzyvhns7gyz1bvgj8q6307i4rm-apple-framework-CoreFoundation-11.0.0/bin:/Users/hungtran/.local/share/nvim/mason/bin" VSLANG="1033" ZERO_AR_DATE="1"
"cc" "-arch" "arm64" "/tmp/rustcMg0rTh/symbols.o" "/Users/hungtran/local_repos/zork/target/debug/deps/lsp-d92861ee639d84ad.1jr4o2kw6y3ksl0u.rcgu.o" "/Users/hungtran/local_repos/zork/target/debug/
deps/lsp-d92861ee639d84ad.204ae4tecutcekgy.rcgu.o" "/Users/hungtran/local_repos/zork/target/debug/deps/lsp-d92861ee639d84ad.3moztt19cmw0o1ks.rcgu.o" "/Users/hungtran/local_repos/zork/target/debug
/deps/lsp-d92861ee639d84ad.46lr2edtiuegj2kp.rcgu.o" "/Users/hungtran/local_repos/zork/target/debug/deps/lsp-d92861ee639d84ad.50vptv1ge4mtdwgr.rcgu.o" "/Users/hungtran/local_repos/zork/target/debu
g/deps/lsp-d92861ee639d84ad.frtdyazq0exhm9p.rcgu.o" "/Users/hungtran/local_repos/zork/target/debug/deps/lsp-d92861ee639d84ad.31rjo0bzdr75oec0.rcgu.o" "-L" "/Users/hungtran/local_repos/zork/target
/debug/deps" "-F" "/nix/store/hayj70xixmzri25f0c2vbdrn1q3xy31s-devshell-dir/Library/Frameworks" "-L" "/nix/store/40rb2myhi22n2jr3a1f5r7n673j1llcw-rust-minimal-1.72.0-nightly-2023-06-29/lib/rustli
b/aarch64-apple-darwin/lib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libstd-05943b50472cd2d6.rlib"
 "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libpanic_unwind-d4df49eb937c25fb.rlib" "/nix/store/57phj
a1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libobject-d9455aebba8055d5.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26j
xga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libmemchr-218138b1ab541b3e.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nigh
tly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libaddr2line-d187e6473663e7f6.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch6
4-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libgimli-2b31aea7ba1669cf.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustli
b/aarch64-apple-darwin/lib/librustc_demangle-c1dfb86e23640844.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-
darwin/lib/libstd_detect-27914095f0dba818.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libhashbr
own-b8e271a3426f8722.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/librustc_std_workspace_alloc-4
96f42c51ffe7099.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libminiz_oxide-6bd89cd5d42afec5.rli
b" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libadler-37f6ce1bec5f08ec.rlib" "/nix/store/57phja1hxk
5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libunwind-6d20841979b6d418.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-r
ust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libcfg_if-ecea5914c2ef473a.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2
023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/liblibc-cc741fbf27f447be.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-da
rwin/lib/rustlib/aarch64-apple-darwin/lib/liballoc-4e0b06e5749dd743.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-
apple-darwin/lib/librustc_std_workspace_core-70a0087d6881bc8d.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-
darwin/lib/libcore-6fc8bef838a5948d.rlib" "/nix/store/57phja1hxk5wlz49ia6gp3k98n26jxga-rust-std-1.72.0-nightly-2023-06-29-aarch64-apple-darwin/lib/rustlib/aarch64-apple-darwin/lib/libcompiler_bui
ltins-a2bfdcafe5010b58.rlib" "-lSystem" "-lc" "-lm" "-L" "/nix/store/40rb2myhi22n2jr3a1f5r7n673j1llcw-rust-minimal-1.72.0-nightly-2023-06-29/lib/rustlib/aarch64-apple-darwin/lib" "-o" "/Users/hun
gtran/local_repos/zork/target/debug/deps/lsp-d92861ee639d84ad" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun
          libc++abi: terminating with uncaught exception of type std::runtime_error: codesign_failed: 1
          /nix/store/pz87iqygyl6gklpqlwd8bjs8sqd6hvl3-post-link-sign-hook: line 4: 74910 Abort trap: 6           CODESIGN_ALLOCATE=codesign_allocate /nix/store/ss3qicb0gzh00f87c6xs9nfdj92mad8k-si
gtool-0.1.3/bin/codesign -f -s - "$linkerOutput"
          clang-11: error: linker command failed with exit code 134 (use -v to see invocation)

error: could not compile `lsp` (bin "lsp") due to previous error

The fix explained
xcbuild on its own require 2 entries of $PATH to be appended so that rustc, thus cargo build, can see and use xcrun via $PATH
Potential upstream fixes and alternative approaches
https://github.com/NixOS/nixpkgs/pull/242431
But the PR will still likely not resolve this in an elegant way. The way xcbuild is structured, collocating xcbuild and its xcrun via symlinkJoin will fail the build due to sharing (iirc) /share symlinks.
How the traditional route of pkgs.mkShell works was via a hack of adding a string-path onto propagatedBuildInputs so that it gets added to environment variable. devshell despises this approach in favor for minimal env via mkNakedShell.
Alternative approaches
Why an alternative approach? The current fix wishes for pkgs.xcbuild to coincide with the one rustc uses. With the popularity of many rust-overlays, this is very rarely the case. A drift of version is fine (for now), but it will require the end user to fetch xcbuild twice, and may break in dep requirements (unlikely since xcbuild is archived. The following approaches take these potential pitfalls into account.
a. I'm not confident enough for an attempt of refactoring xcbuild so that it is friendly for collocation with xcrun. From the back of my mind, this will likely drastically change many dependent derivations. Even xcbuild.withXcrun would be a better solution that solves at the upstream level.
b. Wiggle mkNakedShell, which I'm also not too confident in, to take into account of propagatedBuildInputs and other pre-req derivations.
c. A more bold approach is to just disregard xcbuild entirely and use xcrun on our Rust environment. At the time of discovery, I didn't note this down in more details, so take this with a grain of salt.

Hi, any interest in merging this?
Is there anyway I could contribute to help getting this merged?

yup, thank you. I just got overloaded with notifications.


Use "generic" mixins in new controllers

Some time ago @Ladas created some mixins to share similar code repeated in many controllers:
See
  include Mixins::GenericButtonMixin
  include Mixins::GenericListMixin
  include Mixins::GenericSessionMixin
  include Mixins::GenericShowMixin

e.g. in app/controllers/cloud_subnet_controller.rb
Unfortunately we have not refactored all the controllers to use that and we create new controllers that also don't use that.
@h-kataria, @lgalis, @mzazrivec, @AparnaKarve, @ZitaNemeckova : please, take a look if we can catch that in review and if we can use this and clean it up more.

Also, it's a good time to look at what is the shared code. E.g. the GenericButtonMixin now shows, that we were copypasting a code used for instances everywhere.

Well @Ladas, there's at least one other group of controllers that has similar shared code, but other that what you did. That is CimInstanceController and it's descendants such as OntapStorageVolumeController.
That is pretty generic, but follows a different patter that the one you introduced with you mixins.
I don't think it is beneficial to have 2 ways to do the same thing :-(
Ideas on what to do with this?

Compare GenericButtonMixin::button with CimInstanceController::process_button: similar structure, just different set of actions dumped there :-(.

I'd keep the mixin version, since .. a) it's already a mixin - a bit more flexible, b) it's newer (Cim's history goes to the Initial commit, the mixin version is from March).
Otherwise, it's not that important which one, but it is important that we try to use just one of them everywhere :).

yeah I think 3rd version is on pages with explorer and vms. But I think, that almost the whole Cloud could be wrapped by the mixins I did, it's mostly the same copypasted code there.
I assume it should look differently than just mixins, but as a first step of getting rid of the copypasted code, it's good.  :-)


Localization of 'Custom Map Data' not working

Hi,
The Custom Map Data menu option and popup aren't applying the localized strings.
Transifex shows that the strings where translated to Spanish 2 months ago.
See attached screenshots in "Spanish":

The localisation are updated with every new iD-release for the osm-website and several times a day on the iD-preview at http://preview.ideditor.com/master . In German everything is localized at the preview:

Oh! Thanks!


[excel] (ExcelAPI 1.9) Removing preview tags for Excel 1.9

This removes any preview tags from API descriptions going out with the 1.9 release.

Docs Build status updates of commit 36cd502:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-events.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-multiple-ranges.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-ranges-advanced.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-ranges.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-shapes.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-tables.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-workbooks.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-worksheets.md
:white_check_mark:Succeeded

docs/excel/performance.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@kbrandl Just got word from the API team and couple of these items didn't actually make it out of preview for this release. I'm going to close the PR and sort everything out.

Docs Build status updates of commit 36cd502:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-events.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-multiple-ranges.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-ranges-advanced.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-ranges.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-shapes.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-tables.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-workbooks.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-worksheets.md
:white_check_mark:Succeeded

docs/excel/performance.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/excel-api-requirement-sets.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 86b0ae9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-events.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-multiple-ranges.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-pivottables.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-ranges-advanced.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-ranges.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-shapes.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-tables.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-workbooks.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-worksheets.md
:white_check_mark:Succeeded

docs/excel/performance.md
:white_check_mark:Succeeded

docs/reference/requirement-sets/excel-api-requirement-sets.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Popover option set padding is missing

Version: SilverStripe 4.4.x-dev, elemental 4.0.x-dev

Add new block

Fix at https://github.com/silverstripe/silverstripe-admin/pull/766


llext: add support for STT_OBJECT relocations

These relocations are needed e.g. when an LLEXT is built from multiple files and they share data objects.

Would it be difficult to add a testable extension that covers we support global object linking? I think its worth adding if you don't mind spending the few extra minutes making it.

Thank you for adding a test #72383

Would it be difficult to add a testable extension that covers we support global object linking? I think its worth adding if you don't mind spending the few extra minutes making it.

@teburd #72383 and the result is interesting. Firstly - yes, I made it a separate PR on purpose to not slow down this one, while we polish the test ;-) Secondly - turns out that currently even the simple "object_ext" test is silently "green-failing" (TM) at least on Xtensa. It outputs:

DEBUG   - QEMU (291790): I: Loaded extension object
DEBUG   - QEMU (291790): number: 0
DEBUG   - QEMU (291790): number, updated: 0
DEBUG   - QEMU (291790): string: (null)

My new multi-file test from that PR is producing a similar 0-result. With my this PR I'm getting:

DEBUG   - QEMU (288615): I: Loaded extension object
DEBUG   - QEMU (288615): number: 42
DEBUG   - QEMU (288615): number, updated: 0
DEBUG   - QEMU (288615): string: hello

and

DEBUG   - QEMU (288593): I: Loaded extension multi_file
DEBUG   - QEMU (288593): initial: local 66 plus external 24 equals 90
DEBUG   - QEMU (288593): updated: local 24 plus external 66 equals 90

respectively. That result is for llext.simple.writable and for modules_enabled_writable. However, for modules_enabled_writable_relocatable it's worse:

DEBUG   - QEMU (288606): I: Loaded extension multi_file
DEBUG   - QEMU (288606): initial: local 0 plus external 24 equals 24
DEBUG   - QEMU (288606): updated: local 24 plus external 0 equals 24

and

DEBUG   - QEMU (288606): I: Loaded extension object
DEBUG   - QEMU (288606): number: 24
DEBUG   - QEMU (288606): number, updated: 0
DEBUG   - QEMU (288606): string: (null)

So that case still has to be fixed, and presumably twister should be updated to recognise failures.

It's completely fine that its separate, agreed no need to slow down, but definitely a good practice to prevent regression and ensure that yes, we really did add the feature and we can prove it.
It's interesting that it doesn't fail today, so maybe some asserts in the extension are needed to ensure failure is caught, or some added call to tell the calling ztest (beyond an assert) that it failed (return an errno perhaps?)

It's interesting that it doesn't fail today, so maybe some asserts in the extension are needed to ensure failure is caught, or some added call to tell ztest its failed, or perhaps changing the signature of the extension test_entry to return integer codes where -errno is signaling error.

The ztest control macros are already available; however, enforcing full compliance exposes a few issues such as these that need to be tackled by fixing the linking code. That's my end goal... as soon as I can get to it :slightly_smiling_face:

It's interesting that it doesn't fail today, so maybe some asserts in the extension are needed to ensure failure is caught, or some added call to tell ztest its failed, or perhaps changing the signature of the extension test_entry to return integer codes where -errno is signaling error.

@teburd @pillo79 How about this: after this one and #72383 are merged, we (me or somebody else) make a PR adding those checks. That PR will fail twister tests, so it won't be merged. So we'll keep fixing linking until it can be merged? Or we can add several such PRs exposing individual errors.

It's interesting that it doesn't fail today, so maybe some asserts in the extension are needed to ensure failure is caught, or some added call to tell ztest its failed, or perhaps changing the signature of the extension test_entry to return integer codes where -errno is signaling error.

@teburd @pillo79 How about this: after this one and #72383 are merged, we (me or somebody else) make a PR adding those checks. That PR will fail twister tests, so it won't be merged. So we'll keep fixing linking until it can be merged? Or we can add several such PRs exposing individual errors.

That is an interesting approach! :+1:


Managed Server Unable to connect to the Administration Server

Hi
I've created a WLS domain on my kubernetes cluster, all pods are running. The admin server has started fine and I can access the admin console. However the managed servers have not registered with the admin server. I see this error in the logs:
<Dec 3, 2018 10:46:07 AM GMT>    <Unable to connect to the Administration Server. Waiting 5 second(s) to retry (attempt number 3 of 3).>
<Dec 3, 2018 10:50:33 AM GMT>    <Could not register with the Administration Server: java.rmi.RemoteException:
[from AdminURL 0] weblogic.deploy.service.internal.transport.UnreachableHostException: [Deployer:149145]Unable to contact "null". Deployment is deferred until "null" becomes available. WARNING: If this is a redeploy app and contains JSP pages that have been touched, these JSP changes wont be reflected when the server starts unless precompile is set to true in weblogic.xml; nested exception is:
java.net.ConnectException: Tried all: '1' addresses, but could not connect over HTTP to server: 'domain1-admin-server', port: '7001'
failed reasons:
[0] address:'domain1-admin-server/<IP_ADDRESS>',port:'7001' : java.net.ConnectException: Connection timed out (Connection timed out)
[from AdminURL 1] weblogic.deploy.service.internal.transport.UnreachableHostException: [Deployer:149145]Unable to contact "null". Deployment is deferred until "null" becomes available. WARNING: If this is a redeploy app and contains JSP pages that have been touched, these JSP changes wont be reflected when the server starts unless precompile is set to true in weblogic.xml; nested exception is:
java.net.ConnectException: Tried all: '1' addresses, but could not connect over HTTP to server: '<IP_ADDRESS>', port: '7001'
failed reasons:
[0] address:'/<IP_ADDRESS>',port:'7001' : java.net.ConnectException: Connection timed out (Connection timed out)

<IP_ADDRESS> is the cluster IP of the admin server pod and the admin server is listening on 7001. When I exec to the admin pod I can curl http://<IP_ADDRESS>:7001/console OK, when I try on a managed server pod it times out.

Hi @mriccell
The admin server is exposed fined via the adminNodePort, I can access it from my desktop with no issues.
What I see though is that only the admin server has started, the two managed servers are down. When I exec to the managed server pods I can see that the managed server is trying to start but can't access the admin server to register (as per the log above). AFAIK the managed server pod should be able to access the admin server pod via the cluster IP.
I am running a three node OKE cluster on OCI.

Hi @mriccell
I am running this on OKE on Oracle Cloud Infrastructure and it seems that an additional ingress rule is required above those created on cluster creation to allow node to node traffic.
I added a stateful ingress rule in my VCN for <IP_ADDRESS>/16 for all protocols (<IP_ADDRESS>/16 is the VCN CIDR) and the issue was fixed. The WLS console reported all the managed servers were up and I could curl the admin server URL from the managed server pod as expected. Removing the ingress rule causes the issue to return.

Closing as cause identified.


PvRecorder failed to read audio data frame.

Hello there, I'm a fellow developer who uses nodejs and I'm trying to learn how to use the pico voice recorder, I've got my code here however, it seems to produce an error (its given in the title, too lazy to paste it again), may I have some assistance? here's my code
const { PvRecorder: Recorder } = require('@picovoice/pvrecorder-node');
const fs = require('fs');
const { WaveFile } = require('wavefile');
const frames = [];
let recording = true;

(async () => {
  const frameLength = 512;
  const wavFile = new WaveFile();

  const recorder = new Recorder(frameLength, 0);
  recorder.start();

  setTimeout(() => {
    console.log(`stopping`)
    recorder.release()
    recording = false;
    return
  }, 2000)

  while(recording){
    const frame = await recorder.read()
    frames.push(frame)
    console.log(frame)
  }

  const data = new Int16Array(recorder.frameLength * frames.length)

  for(let i = 0; i < frames.length; i++){
    data.set(frames[i], i * recorder.frameLength)
  }

  wavFile.fromScratch(1, recorder.sampleRate, 16, data)
  fs.writeFileSync('funni.wav', wavFile.toBuffer());

})();

I'm using version 1.2.0

Never mind it seems to magically work now, insane. Imma close this so that I do not take up anyone's precious time


Bug: It wouldn't let me change the hour when editing an existing effect

If I try to edit the time of an existing effect, the app only lets me enter the hour value from 1 to 10, it wouldn't let me enter hours from 11 to 23, even when the original hour entered when creating the effect was in that diapason. Only deleting and creating a new effect helps.

I just started using the app and thought I encountered the same issue until I noticed that there is a "AM/PM" toggle next to the time field when editing an effect that is not there when an effect it first created.
@Leeleevy maybe it's the same for you?

hey guys, thanks for using my app and keeping faith in it. im so sorry for being late on the issue, but i am working on a big update and revamp of the app i talked about it on my tekegram community. i also made a discord community recently.
as for the bug you have reported, it is good to know that there are many factors involved, 1 is that there are infact control buttons for am and pm, the app does not let you put an hour in the future but seems like this logic made a lot of mess in the application so i will absolutely look into it.


Refactor Providers transaction/estimates versions

Describe the refactor
Providers implement only one version of transaction/estimate but accept the parameter version which is the transaction modifier.
There are two solutions to this:

Refactor provider code so that it supports all versions of transactions:

Extract the creation of transactions into factory functions for each version of the transaction
Implement factory function in provider for submitting transactions based on version

Remove the version parameter and fix the value to the supported one (it should be transactionVersion -> 1)

move transactionVersion to constants
use transactionVersion as a fixed version in providers

My suggestion:

Remove Support for Transaction Version 0
Only support Transaction Version 1 and 2 for Declare. Declare v1 should be removed in future.

Partially resolved.
Not resolved part of the estimate fee version but it has no solution.


Create versioning example

Cache versioning is one of important usecase of caching.
So create versioning example to fill following condition.

download file with version
clear old version file
check the specified version file is downloaded.

merged! https://github.com/mattak/Unicache/pull/10


Fix creation of Pact broker secret.

Pact broker secret was not created well as the env vars were not propagated to the script. Fixing.

/retest

/retest

/retest

Closing in regards to HAC_3532


Ensure that DNSSEC is enabled for Cloud DNS

Possible check to target the following resource

[ ] google_dns_managed_zone

closing, tracking in spreadsheet


Allow array in Audience

The Audience claim (aud) can be one or multiple values. See 4.1.3 in spec.
I've updated the typescript definitions to allow for this.

Thank you for your contribution ❤


Document user stores properties in the config catalog

Description:
Add the information in [1] together with the code to the config catalog.
[1] https://is.docs.wso2.com/en/5.9.0/setup/working-with-properties-of-user-stores/
Related Issues
https://github.com/wso2/docs-apim/issues/2464

This issue can be closed with the above set of PRs.

This issue can be closed with the above set of PRs.


Stacktrace includes entries with python's interanals

In recent weeks, I've started noticing that many stacktraces contain details of calls inside python's log module (i.e.: all the handling insidelogging/__init__.py):
https://github.com/python/cpython/blob/3.8/Lib/logging/__init__.py#L1463
https://github.com/python/cpython/blob/3.8/Lib/logging/__init__.py#L1577
https://github.com/python/cpython/blob/3.8/Lib/logging/__init__.py#L1587
https://github.com/python/cpython/blob/3.8/Lib/logging/__init__.py#L950
This is very annoying and just makes stacktraces harder to see. This is obviously never shown by Python when emitting logs either.
Example event on sentry.io.

You want to set https://docs.sentry.io/error-reporting/configuration/?platform=python#in-app-include to a list of module/package names that belong to your application, or inversely you can also use ..exclude to just exclude stdlib logging/celery frames etc

I think this should be included by default, rather than me having to configure it.
I can't image any scenario were one might care about the internal calls that logging.error() makes inside the logging module.
These trace lines were not included in the past either.

Do you have an example of an event where those lines were not included?

Here's a few without those lines:
https://sentry.io/organizations/hobarrera/issues/1512741395/?project=124552&query=is%3Aunresolved&statsPeriod=14d
https://sentry.io/organizations/hobarrera/issues/1657959391/?project=124552&query=is%3Aunresolved&statsPeriod=14d
https://sentry.io/organizations/hobarrera/issues/1671976684/?project=124552&query=is%3Aunresolved&statsPeriod=14d
I'm seeing a pattern though: they're al either asserts or raise.
It seems it's always logged for logger.error or warning calls.

I see, that's to be expected then. In any case it seems like we should have better defaults for in_app_exclude here.

I think so too. Merely adding logging to the default should suffice.

I looked into this a little bit and didn't find a lightweight way to figure out if a module belongs to the stdlib or not. My issue with just hardcoding a bunch of names is that the user can have a logging module that shadows stdlib, in which case not showing those frames would be a regression over the status quo (and worse than showing too many frames)

The problem appears to be this line:
https://github.com/getsentry/sentry-python/blob/3a7943b85c97a117cd2f171d47a4dffea980a67f/sentry_sdk/integrations/logging.py#L209
Sentry generates its own stacktrace, ignoring the stacklevel parameter of the logging call. Instead, it should be using the stack_info attribute of the LogRecord that is provided to it, so long as that is set.

Hey @WhyNotHugo !
Thanks for reporting this and also thanks @RJPercival for following up. We need to investigate this more.
I put in on our internal list of low prio enhancements and we will do a proper road map planning in the next couple of weeks where we decide want to implement in the next months.

we should try to repro the events above (they're old and deleted) and then I think we can just add a grouping rule here.


Add dependabot for GitHub Actions

Resolves #34

Applicable Issues

Issue #34
Description of the Change

In #30 we introduced dependabot for the Go ecosystem, now we do the same to the GitHub Actions (.github/workflows) ecosystem.
Alternate Designs

Dependabot is a GitHub native functionality, so no other designs were really considered.
Benefits

We get notified when there are updates to dependencies used in this repo, and pull requests are automatically created to solve them.
Possible Drawbacks

We may get spammed with a lot of pull requests (unlikely).
Updating dependencies may break stuff, but hopefully we will notice the automatic tests failing because of that.
Sign-off

Jonas Alfredsson -<EMAIL_ADDRESS>Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by:

Ah, my bad. Fixed the commit message (copy-paste fail).


Add new sensors from AVM, Bosch and Shelly

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
No problem just a feature request
Describe the solution you'd like
Manufacturer: AVM
Device: FRITZ!DECT 200
Power usage when on: 1,1 Watt (1W confirmed with PlugS)
Power usage when off: 0,5 Watt (<1W confirmed with PlugS)
Source: https://avm.de/produkte/smart-home/fritzdect-200/technische-daten/
Manufacturer: PLUG_COMPACT
Device: BOSCH
Power usage when on: 1,000 W --> Meassured with Shelly PlugS/Tasmota calibrated
Power usage when off: <1,000 W Cant be meassured by PlugS
Source: https://www.bosch-smarthome.com/de/de/produkte/geraete/zwischenstecker-kompakt/
Manufacturer: Shelly
Device: 3EM
Power usage when on: < 1 W
Power usage when off: N/A its always on
Source: https://www.shelly.cloud/de/products/shop/shelly-3em-1
Describe alternatives you've considered
no idea
Additional context
would be nice if you could all these devices. This plugin is so great and usefull!!!

For the standby power of the smart plugs it's very important to have a good power reading.
The Shelly plug S is not good at accurately measuring power values < 0.5W
When we put in 1W for the bosch plug compact and in reality it's like 0.55W then this difference will add up over time, and amount of kWh used will be double the actual amount.
I have very good results with the Zhurui PR10 meter, which is awesome and very accurate, can measure up to 2 decimal digits.
Only device which seems sensible to add is the FRITZ!DECT 200, as you found the actual specs as provided by the manufacturer and you were able to verify them kind of with the Shelly.
Would be awesome if you are able to actual measure the devices. But I can see ~$50 investment is very hefty when you only purchase it for this use case.

Well, i like this project and i ordered the ZHURUI PR10-C EU16A...will arrive on monday. I have some other plugs - which i dont use anymore - but then i could also provide you with these data. It could be also usefull for other things (i think). Will be very busy during the week, but i think next weekend i can provide you with (hopefully) correct data from that device.

That's awesome.

I have a question about the meassurement....could you help me with this before i start with all devices.
The Shelly Plug S are running on Tasmota with MQTT on, messaging every 10 seconds and leds off. So in Standby its consuming between 0,24-0,52W.  So would you then just use the avarage  (0,38W) as standby power usage? Or would you do the meassurement over a fixed time? or anything else? ...Just to get propper results ;-)

I don't understand your question exactly.
Which device are you trying to measure? I thought you were going to measure with Zhurui PR10 as the Shelly Plug S is unable to measure very low currents accurately.

What i mean is, that the consumption (in this case in standby) is not constant. See video...So what value would you need for that device? The middle consumption over 10secs? or time x or how are you doing this?
https://github.com/bramstroker/homeassistant-powercalc/assets/29686097/c4475920-f56e-43b8-81b1-315f1274f4a1

I see what you mean. It will always fluctuate a littlebit, but in your case it fluctuates quite a bit.
In this case it makes sense to pick the average. 0.38 seems quite reasonable looking at the values.
However not sure how we going to add this shelly Plug S profile to the library. As we only allow a single profile per unique device (manufacturer / model).
I measured the Shelly Plug S running the official firmware
https://github.com/bramstroker/homeassistant-powercalc/blob/master/custom_components/powercalc/data/shelly/shelly plug s/model.json
I measured 0.52. Can do another measurement tomorrow to verify.
Could be that your firmware is behaving differently and also has another power characteristic because of that.

manufacturer / model
Maybe as new manufacture...in this way:
Tasmota / ShellyPlugS
Will start later or tomorrow with the measurements of the devices. I think I have about 20 Shelly's, some Bosch, AVM, Gosund and so on. Will put it in an excel sheet and then we will see.

Hey, 1st batch of measured devices is ready. Please let me know if this is sufficient and you can work with this. Then i would continue with next devices (probably next weekend)
measurements.xlsx

Looking good!
You may go forward and make a Pull Request for AVM, Bosch and Nous. Please make a separate Pull request per model.
I think most people use the Nous A1T with the Tasmota firmware as I google it, so it makes sense to add it to the library.
For the Shelly I will do some new measurements with the official firmware soon. Also using the same strategy measuring the kWh for 30 min. When I get similar readings, you can just use the build-in Shelly Plug S profile.
Not sure if many people use the Shelly with other firmware than the official.
I doesn't feel right to me to make a manufacturer directory Tasmota. Also this won't make auto discovery work correctly, because the auto discovery routine looks at the device manufacturer and tries to find similar directory.
The only "right" solution is to also take the integration in consideration which provides the entity. i.e. Shelly vs Tasmota. But that will need a thorough overhaul of the library system. So that's not something which is on the roadmap.
Anyway you always have the option to add the models to your local powercalc installation. see: https://homeassistant-powercalc.readthedocs.io/en/latest/library/protocol.html#light-model-library

Thinking about this some more, we may implement separate profiles for different firmware using sub profile mechanism. Which is also used for some other models.
For example https://github.com/bramstroker/homeassistant-powercalc/blob/master/custom_components/powercalc/data/lifx/LIFX A19 Night Vision/model.json
I can write a new matcher which checks if the entity is provided by a certain integration. If so we can automatically load a separate profile, which is in another subdirectory.
Could look something like this.
"sub_profile_select": {
        "matchers": [
            {
                "type": "integration",
                "integration": "tasmota",
                "profile": "firmware_tasmota"
            }
        ],
        "default": "firmware_official"
    }

And directory structure:
- shelly
  - plugS
    - model.json
    - firmware_official
      - model.json
    - firmware_tasmota
      - model.json

Okay, PR for AVM, Bosch and Nous done (hopefully its correct?! 1st time for me)

Not sure if many people use the Shelly with other firmware than the official.
For me that was the reason to buy them...i also have two Tasmota lights now. So i would be very happy if you could add something which could cover those devices :-) ...For my understanding your matcher looks nice for this

I think we can close here?!
Once i have datas from other sensors i will do it with a PR. Thanks @bramstroker


New widget/sales new vs old customers

@cesar-tonnoir

looks good to me! just tell me when the last 10% spec are ready to be merged


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In a2ef89c, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 13375 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 4e3a598.


Changes v0.0.2

Feedback as discussed during meeting 16 January 2023
General

[ ] Include placeholder for description per plot/table. Once there, to be updated by INBO in https://github.com/inbo/alien-species-portal/blob/mockup/alienSpecies/inst/extdata/translations.csv
[ ] All trias plots: Use the INBO theme for (ggplot) colors and background color white

Global indicators page

[ ] Pathways: Level 1 full names; Level 2 abbreviations. To be updated by INBO in https://github.com/inbo/alien-species-portal/blob/mockup/alienSpecies/inst/extdata/translations.csv#L137-L187
[ ] Pathways, all plots/tables: always put the level 'Unknown' as last. Both for level 1 and level 2
[ ] Pathways > Introduced species per pathway level 1 - trends plot: First period is 2020-2029, while second is 1950-1959. Should be chronological.
[ ] Origin > Number of introduced species per year & continent plot: Include time slider for the plot

Species information page

[ ] All maps: hide background layer (globe) by default.
[ ] All maps: include option to select region: Vlaanderen, Wallonie, Brussels hoofdstedelijk gewest. By default all 3 selected. First INBO needs to add extra column indicating in which region the observation/reporting is
[ ] All maps: remove gray layer (continental/atlantic) and replace by regions (see previous). @SanderDevisscher needs to add this layer first. Relevant piece of code
[ ] Observations: show more map than histogram, e.g. height of map 70%, height of histogram 30%
[ ] Observations: check which encoding is used for the grids (UTM?) : Files are here
[ ] Indicators: Error message is too much to the right. Select e.g. Muntiacus reevesi & both checkboxes
[ ] Indicators: remove plot title
[ ] Reporting: Input field for source should allow to select t0, t1 etc
[ ] Management: First select Lithobates - Jamaicensis the app breaks
[ ] Management: For Lithobates add municipality trend graph similar to "Evolutie gerapporteerd afschot
Gemeente" from grofwildapp

All maps: include option to select region: Vlaanderen, Wallonie, Brussels hoofdstedelijk gewest. By default all 3 selected. First INBO needs to add extra column indicating in which region the observation/reporting is

This will be done based on an assignment of gridcells to a region. @damianooldoni can you help with this ?

@SanderDevisscher Included commit b222db8 Is it sufficient to add the borders? I don't need to color the regions?


Rate limit error when not limited

Bug description
I'm having no trouble using the API with other tools but with yours I get:
{
    "error": {
        "message": "Rate limit reached for default-gpt-3.5-turbo in organization org-pWX3d5auFNjsEBqgeA5Rp0bd on tokens per min. Limit: 90000 / min. Current: 1 / min. Contact us through our help center at help.openai.com if you continue to have issues.",
        "type": "tokens",
        "param": null,
        "code": "rate_limit_exceeded"
    }
}

aicommits version
v1.11.0
Environment
System:
    OS: Linux 5.15 Ubuntu 22.04.2 LTS 22.04.2 LTS (Jammy Jellyfish)
    CPU: (12) x64 12th Gen Intel(R) Core(TM) i5-1235U
    Memory: 4.85 GB / 7.58 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.17.0/bin/yarn
    npm: 9.6.7 - ~/.nvm/versions/node/v18.17.0/bin/npm

Can you contribute a fix?

[ ] I’m interested in opening a pull request for this issue.

That's the response sent by OpenAI so it's out of our hands. Try reaching out:

Contact us through our help center at help.openai.com if you continue to have issues.


Error downloading files to local directory

Hello this looks like a really cool package!
I followed the how to's to get a list of granules to download, but the download function gives the following error message. Any suggestions to fix this?
results = earthaccess.search_datasets(short_name = 'MYD10A1F',                                      temporal = ('2005-07-01','2010-11-01'),                                       bounding_box = (67.00390352, 38.80432187, 67.81368289, 39.29232868),                                       )
Datasets found: 1
downloaded = earthaccess.download(results, local_path='./data/MYD10A1F')
Input In [40], in <cell line: 1>()
----> 1 downloaded = earthaccess.download(results, local_path='./data/MYD10A1F')

File ~/mambaforge/envs/pangeo/lib/python3.10/site-packages/earthaccess/api.py:188, in download(granules, local_path, provider, threads)
    186     granules = [granules]
    187 try:
--> 188     results = earthaccess.__store__.get(granules, local_path, provider, threads)
    189 except AttributeError as err:
    190     print(err)

File ~/mambaforge/envs/pangeo/lib/python3.10/site-packages/earthaccess/store.py:475, in Store.get(self, granules, local_path, provider, threads)
    472     local_path = Path(local_path)
    474 if len(granules):
--> 475     files = self._get(granules, local_path, provider, threads)
    476     return files
    477 else:

File ~/mambaforge/envs/pangeo/lib/python3.10/site-packages/multimethod/__init__.py:373, in multimethod.__call__(self, *args, **kwargs)
    371 """Resolve and dispatch to best method."""
    372 self.evaluate()
--> 373 func = self.dispatch(*args)
    374 try:
    375     return func(*args, **kwargs)

File ~/mambaforge/envs/pangeo/lib/python3.10/site-packages/multimethod/__init__.py:368, in multimethod.dispatch(self, *args)
    366 matches = {key for key in list(self) if isinstance(key, signature) and key.instances(*args)}
    367 matches -= {ancestor for match in matches for ancestor in match.parents}
--> 368 return self.select(types, matches)

File ~/mambaforge/envs/pangeo/lib/python3.10/site-packages/multimethod/__init__.py:352, in multimethod.select(self, types, keys)
    350 if len(funcs) == 1:
    351     return funcs.pop()
--> 352 raise DispatchError(f"{self.__name__}: {len(keys)} methods found", types, keys)

DispatchError: ('_get: 0 methods found', (<class 'earthaccess.store.Store'>, <class 'list'>, <class 'pathlib.PosixPath'>, <class 'NoneType'>, <class 'int'>), set())```

Hey! Can you please report which version of earthaccess you have installed (earthaccess.__version__)?

The earthaccess.search_datasets function returns "collections", and you can't feed those to earthaccess.download. You probably want the earthaccess.search_data function (see docs), which returns "granules". Those you can download.
@mfisher87 If I'm right on this, perhaps we could provide a more helpful error message?

Great catch, Ian! We'd discussed using a tool like @pydantic.validate to add runtime validation to our top-level API functions to catch things like this early and give the user more useful error message. I found the open issue for that: #420
@theobarnhart-USGS apologies for the poor messaging. Can you let us know if Ian's suggestion gets you back on track? Feel free to close this issue if so, and we will track the larger work needed to improve the error message in #420.

Thank you @itcarroll! My brain was not seeing search_data vs search_datasets. Things seem to be working much better now.

Thank you @itcarroll! My brain was not seeing search_data vs search_datasets. Things seem to be working much better now.

You're not alone, I made the same mistake when I read this issue :laughing: Maybe we should think about the the top-level API; are these good names for these functions? Why not use common terminology like search_collections and search_granules? "Dataset" is often used to refer to a single data file. :thinking:

Thank you @itcarroll! My brain was not seeing search_data vs search_datasets. Things seem to be working much better now.

You're not alone, I made the same mistake when I read this issue 😆 Maybe we should think about the the top-level API; are these good names for these functions? Why not use common terminology like search_collections and search_granules? "Dataset" is often used to refer to a single data file. 🤔

I agree on the need for better function names here. I like search_collections and search_granules, and I'd like to add find_collections and find_granules as another pair of names for consideration.


Allow to consume deps in use_callback hook

Description

This pr refactors  use_callback hook to allows to consume deps, e.g.
    let onclick = {
        let counter = counter.clone();
        use_callback(
            move |_e, counter| {
                // Consume the deps `counter` here.
                let _ = **counter;
            },
            counter
        )
    };

This is a break change of previous design.
Checklist

[ ] I have run cargo make pr-flow
[x] I have reviewed my own code
[x] I have added tests

@futursolo We talked about this in my previous PR, now I'm changing the signature of use_callback from use_callback(|in_type| {}, deps); to use_callback(|in_type, deps| {}, deps);, so we can easily to consume deps in function body, eliminate extra clone/move for deps. But the signature is a bit more complicated than before, so we consider this again to determine if this will be more convenient, any advice?


preferred server timestamp

inserted in the BackendConfig, forcing the resynchronization of the
object to the broker, which will indicate all clients that the
server has been restarted, and that they must re-connect to the endpoint.
This timestamp changes everytime a submariner-gateway is started,
otherwise a server will restart, and all the client connections will
remain unconnected because pluto doesn't know about them anymore.
Signed-off-by: Miguel Angel Ajo<EMAIL_ADDRESS>

The unit test failure is unrelated - random HTTP failure from ipify.GetIp().


Adding correct include headers (for complete installation)

It seems that "secp256k1_recovery.h" are not installed into PREFIX/ by default, adding it and its friends.

Hi @villesundell,
We maintain this fork only to control versioning and to add the vc++ solution and nuget packaging. As a rule we try not to make changes to the library. But in any case this shouldn't be necessary. See:
https://github.com/libbitcoin/secp256k1/blob/version4/Makefile.am#L101-L111


no diagnostics in javascript files (ft=javascript.jsx)

what i do:
mkdir ~/coc-tsserver-test
cd ~/coc-tsserver-test
echo "const a=''; a()" > test.js
cp test.js test.ts
vim test.js test.ts

what i see:

what i expect:
to see This expression is not callable. in the test.js file as well as the test.ts file

It's expected for tsserver, send your feature request to https://github.com/microsoft/typescript


Interface ConfigurationOptions is missing newer Bugsnag options

It seems that the TypeScript interface ConfigurationOptions is missing the following properties / new configuration options:
autoNotifyUncaught?: boolean;
autoNotifyUnhandledRejection?: boolean;
apiKey?: string;
autoCaptureSessions?: boolean;
sessionEndpoint?: string;
beforeNotifyCallbacks?: any;

... whereas beforeNotifyCallbacks and the already defined logger could maybe even be more strict (e.g. sth like Array<(notification: any, error: any) => any> or if you'd argue that the lack of typing for that means no breaking change with non-any-types, then Notification / Error and => boolean).

Hi @my-name-was-already-taken (great name). Sorry for the delay in getting back to you. I'll schedule getting this fixed, and also look at adding some automate QA to ensure the types are complete/accurate for any future changes. Thanks for your patience!

@bengourley What's the status of this? I can knock this out quickly if you're open to a PR.

Hi @ajsharp, we would gladly receive a PR! This work is scheduled but it's lower priority than other things we have on the table right now, so is unlikely to be visited in the immediate future. If you make a PR I'll expedite some time to get it reviewed/merged though. Cheers

Fixed via #144.


Rename meeting-superadmin to admin

Currently, the name "superadmin" has two meanings. There is the organization superadmin and the meeting superadmin.
Could we rename the meeting-superadmin to admin? It would help to talk about the permissions.

ok for me

ok for me

I guess that was done up until last Friday at the meeting. If it was not done in a service, it will soon stumble upon this change anw. Closing.

I guess that was done up until last Friday at the meeting. If it was not done in a service, it will soon stumble upon this change anw. Closing.


workflows: filter out schedule events from forks

The general recommendation for forks is to disable Actions from the project settings, since most are contributionforks that don't need to run workflows in the context of the fork.
However, there are cases where one might need to enable Actions from a fork, e.g. for workflow development purposes. This change should alleviate workflow runs pressure for these instances.

@nbusseneau was this meant to be added to v1.10 project? It won't be in v1.10 unless we backport it.

@nbusseneau was this meant to be added to v1.10 project? It won't be in v1.10 unless we backport it.

No, this was a mistake. Good spot ;)


Stop using an all in one image for installing azd in template pipeline definitions

Today, we use an all-in-one azd container image in our template GHAs which includes all the possible dependencies needed to run any of our templates. This results in a very slow start time for pipeline runs as the image is very large. The image also includes many dependencies that are irrelevant to a given user's application (e.g. if I'm using a Python and React template, I don't need or care about Java being installed)
Instead, we should move to:

Installing the deps as steps in the pipeline definition (e.g. setup-python, setup-node). This is more transparent to the user what versions of their dependencies are being used in CI. This would also enable a user to more easily customize the versions of their dependencies needed to package their application for deployment.
Installing azd via curl

With these enhancements, I was able to get my pipeline run time from 13mins31secs to 10mins37secs for todo-python-mongo. See  https://github.com/savannahostrowski/build-demo-session/blob/main/.github/workflows/azure-dev.yml as an example.

This would be handled by #2207

Now that azd auto acquires bicep, this feels like a really good change.
With azd delivered as a task, we also definitively know that we're running in GitHub for example, and can enforce certain CI behaviors at the task level. One thing that comes into mind is to improve our usage telemetry upload behavior in this mode.


Upgrade :poison to version 2?

Might as well get the latest version of poison?
No worries if you know of reasons not to do this...

It would conflict with ecto's dependency on it which still is for 1.0. And since geo only uses poison when setting up the ecto types, it doesn't make sense right now.

Looks like the version can be updated using an or (i took a look at how ecto is currently handling it). I need to update the postgrex dependency as well. I'll publish a new version tonight.

Updated https://hex.pm/packages/geo


Get the textual format from query itself, not the database

Can I get the textual form of the notification I'm creating with the query itself?
Notifynder::category('user.following')
			           ->from($senderId)
			           ->to($receiverId)
			           ->url(User::find($senderId)->slug)
			           ->send();

Eg: user1 started following you

Can you elaborate a bit more please i'm not sure what you are meaning thanks

I figured it out. Thanks anyway.
I have another issue.
$user->getNotifications()
User_id = 2

array:2 [
0 => array:15 [
"id" => 7
"from_id" => 3
"from_type" => null
"to_id" => 2
"to_type" => null
"category_id" => 1
"url" => "rajsoni"
"extra" => null
"read" => 1
"created_at" => "2015-07-04 11:45:22"
"updated_at" => "2015-07-04 18:33:06"
"expire_time" => null
"text" => "started to follow you"
"body" => array:3 [
"id" => 1
"name" => "user.following"
"text" => "started to follow you"
]
"from" => array:34 [
"id" => 3
"first_name" => "Raj"
"last_name" => "Soni"
"dob" => "0000-00-00"
"slug" => "rajsoni"
"username" => "rajsoni"
"email" =><EMAIL_ADDRESS>"alternate_email" => ""
"salt" => ""
"phone_number" => 0
"facebook_profile_link" => ""
"twitter_profile_link" => ""
"profile_picture" => ""
"profile_picture_thumb" => ""
"interests" => 0
"events_visited" => 0
"events_created" => 0
"city" => ""
"state" => ""
"country" => ""
"address" => ""
"pincode" => ""
"organisation_id" => 0
"is_verified_by_email" => 0
"is_verified_by_sms" => 0
"ratings" => 0
"is_organisation" => 0
"bio" => ""
"gender" => ""
"followers_count" => 0
"following_count" => 0
"is_deleted" => 0
"created_at" => "2015-07-04 11:14:10"
"updated_at" => "2015-07-04 12:29:25"
]
]
1 => array:15 [
"id" => 6
"from_id" => 1
"from_type" => null
"to_id" => 2
"to_type" => null
"category_id" => 1
"url" => "narangrishab"
"extra" => null
"read" => 1
"created_at" => "2015-07-04 11:45:10"
"updated_at" => "2015-07-04 18:33:06"
"expire_time" => null
"text" => "started to follow you"
"body" => array:3 [
"id" => 1
"name" => "user.following"
"text" => "started to follow you"
]
"from" => array:34 [
"id" => 1
"first_name" => "Rishab"
"last_name" => "Narang"
"dob" => "0000-00-00"
"slug" => "narangrishab"
"username" => "narangrishab"
"email" =><EMAIL_ADDRESS>"alternate_email" => ""
"salt" => ""
"phone_number" => 0
"facebook_profile_link" => ""
"twitter_profile_link" => ""
"profile_picture" => ""
"profile_picture_thumb" => ""
"interests" => 0
"events_visited" => 0
"events_created" => 0
"city" => ""
"state" => ""
"country" => ""
"address" => ""
"pincode" => ""
"organisation_id" => 0
"is_verified_by_email" => 0
"is_verified_by_sms" => 0
"ratings" => 0
"is_organisation" => 0
"bio" => ""
"gender" => ""
"followers_count" => 0
"following_count" => 0
"is_deleted" => 0
"created_at" => "2015-07-03 17:04:27"
"updated_at" => "2015-07-05 10:48:43"
]
]
]
It's not returning me all the notifications belonging to user id =2

@fenos  Basically, it's returning me notifications for to_id rather than from_id

@narangrishab of Course that make sense, you want to get the notification *received from that user not the sent one
to_id means who receive the notification

It's this solved?

Hey @fenos . Yep it's solved. Thanks buddy!

No problem, for any question or issue i'm here :+1:

@fenos  How do I trigger a notification alert whenever a new notification is added. Basically like facebook does it, how do I notify a particular user that notification has come. Do I need some kind of sockets/triggers for it? Could you suggest any package for laravel.

@narangrishab Exactly you have to use sockets, in Laravel 5.1 it's pretty easy it come out with a EventEmitter that can talk your sockets. It use  NodeJs,socket.io, Redis. It's also documented on the laravel docs

Do I need to move my entire project to node js for the same?
Also, Do I need to use Redis? @fenos

Currently I'm using Laravel 5.0 with Mysql as my db.

Why not upgrade if you want to use sockets?

Could you recommend some tutorial for notifications using Laravel and Sockets?


feat(ngx-tour): add and remove a body class to allow for custom stying when the tour is active

Description
Upon starting the tour, a ngx-tour-active class is applied to the body. This allows for styling customisation like disabling pointer-events, for example.
Screenrecording
https://github.com/user-attachments/assets/c7bd951f-9a54-40d7-811d-4161a3b9a0a4

Can you also fix the tests?

The tests will be fixed in a later PR. Currently, we are unable to find a solution as to why they are failing.
cc: @IbenTesara


Support streaming query

DuckDB now supports streaming queries which do not materialize everything before returning the first rows

I would be happy to help out on this :) Will start to take a look and see if I can understand enough to make a PR :)


SNMP trap ingester: people want it

What is the feature to be added?
An ingester that can receive SNMP traps and ingest them
Some qualifications on this ingester to keep it simple:

Listen only, no polling
Ingest traps as they are, no polling to resolve MIBs

Why should we add this feature? (Business justification? What problem is the feature trying to solve?)
Many switches and routers can't log critical events via standard logging channels, SNMP Traps allow for at least capturing those events.
How does this feature address the above problem?
Gets logs where there may not be any
Any other comments?
Cisco is going to do dumb stuff, so make sure to test on them.

@kris-watts-gravwell do we know either of the following:

What version of SNMP they want to use?
What devices they intend to use?

no
no


Add craft.ai to Friends

Fixes #570

r? @aturon
(rust_highfive has picked a reviewer for you, use r? to override)

Yay!


Ability to have different number of columns and layouts in each folder

Is your feature request related to a problem? Please describe.
Within a profile, you can only have one grid layout for every folder.  You must make the number of buttons suitable for the largest folder and then have extra empty buttons on every other page.
Describe the solution you'd like
Ability to set layouts for individual folders.
Describe alternatives you've considered

Using multiple folders with buttons that "scroll" between them.  This would be a hassle to use.
Switching to different profiles with a button.  This is not a feature yet but is on the to-do list.  This would work but the project structure would not be as clean.

This reminded me of one thing... I like seeing artist/track name from Spotify, but on a single button it gets pretty cramped up. I was thinking of adding another "feature request", but I think this one could fit my suggestion: the ability to merge buttons. Merging two would be enough for track info to sit there comfortably ;D


Explicit return not required for containers containing < 2 elements for insertion sort

If there are less than 2 elements then,
(1..container.size-1)

will resolve to either 1..1 or 1..0 which will cause the loop to not even execute, hence will return the container itself.

(1..1).each { |x| puts "Hello" } does print Hello, so it would run in the case of size==1.

Sorry @kanwei , my comment was slightly misleading. But my PR is still correct.
The statement return container if container.size < 2 will only return true for the case when container.size is either 0 or 1.
In those two case (1..container.size-1) will evaluate to 1..-1 & 1..0 which will cause the loop to not even execute, hence will return the container itself.
For container.size = 2, the code (1..container.size-1) will evaluate to 1..1 for which the loop will run once, and it is correct.


Add feedback api form

Ref: https://github.com/LeastAuthority/winden/issues/118
Adds the new feedback form on the front-end. The form will make a post request to /v1/feedback on submit.

Few initial notes:

Allows to submit empty form. Maybe require at least one field had some value, doesn't matter which.
Maybe notification "Feedback sent" could be hidden after 10 sec. as now it is always visible till user clicks
"On a scale" line has larger font and weight, was this intentionally done (like encourage to rate)?
Lets add simple E2E test to fill form and send.

I'll add non-empty validation

I was thinking about auto-hiding the notification, but I think it's better if it's manually closed or that it closes on it's own after navigating to a different screen. That way the user can't miss the message (if they miss it, they might try to submit the same feedback again)
Some other options we can do:

keep the alert section where it is now, but it closes itself after ~10s or navigating to a new page
A modal saying that the feedback was sent (most in-the-way approach, but the user can't miss it)
use a floating notification like https://mantine.dev/others/notifications/#demo (but the bottom-right area is be easy to miss)

I'm just using the default theme for now, just pushed to code as is to check if there is any changes we want to do before I start on that

Will do :+1:

Few small notes:

Can we keep the same notification style, when user gets error filling form, with success, only make different notification icon. Currently error is shown in bottom and it is not fully clear if it is an error.
Currently we don't limit length, how much user can input. Maybe each field could limit text to maximum 2000 symbols.

Can we keep the same notification style, when user gets error filling form, with success, only make different notification icon. Currently error is shown in bottom and it is not fully clear if it is an error.

I haven't worked on the styling and layout of it yet, I wanted to get the tests green first. Though I think it should stay near the bottom in the same style as the form validation for the code input: red text under the fields. Since it applies to all fields, I think it should be near the Submit button. wdyt?

I haven't worked on the styling and layout of it yet, I wanted to get the tests green first. Though I think it should stay near the bottom in the same style as the form validation for the code input: red text under the fields. Since it applies to all fields, I think it should be near the Submit button. wdyt?

Logical, as you don't need to look top if page doesn't reload.

@donpui I added content size validation and changed the styling


Animated downloading button is added

Fixes Issue
Closes #1288

Changes proposed

Screenshots

Checklist

[x] You've linked this PR to the correct issue.
[x] You have checked that the code is working correctly.
[x] You ⭐ the repository!

Note to reviewers

@Spyware007 please review this pr

Please check #1346


Can it support to combined with a goroutine pool as the resource of the future using, like the Future In Java?

Future I think it can make the code more clear without doubt, and sometimes it using the flight goroutine to running its 'Job'， which is little not suitable for the web server. So can the future using the goroutine pool resource to running ? Thanks.

It's possible to run the executor goroutine using a pool. Any of these should do the job.

@PursuingPing there's now pool support available in master 🙂


Bug in 'OncogenicPathways' function

OncogenicPathways not working
laml.maf <- system.file("extdata", "tcga_laml.maf.gz", package = "maftools")
laml <- read.maf(maf = laml.maf)
OncogenicPathways(maf = laml)

The error is as following:
Error in graphics::layout(p, ...) : ...

Change to "lo = layout(matrix(c(1,2,3), 1, 3, byrow =F), widths = panelWidths)" in oncopathway.R would help. It seemed to be systematically problem of R instead of oncopathway.R

Hi,
Sorry for the late reply.
I have trouble reproducing the error. Could you please post your sessionInfo? I suspect it must be due to conflict betweengraphics::layout and plotly::layout (?)


Grafana escalation for CVE detection investigation into bootstrap package advisories

1. 6 Bootstrap CVEs:

"CVE-2018-14040"
"CVE-2018-14042"
"CVE-2018-20676"
"CVE-2018-20677"
"CVE-2024-6485"
"CVE-2016-10735"

pending-upstream-fix:
Details: Grafana project maintainers claim the bootstrap lib is only there now to support Angular plugins that still use them. Angular is planned to be removed as a part of the Grafana 12 release. Until then this library is required. However, since the release of Grafana v11, the angular_support_enabled configuration parameter to inherently support for AngularJS based plugins is set to false by default. The bootstrap vulnerability exposure is entirely controlled by the configuration and use cases determined by the user

hey @jamie-albert looks like a conflict needs to be resolved, then we can land this!

Merge when ready:D

Merge when ready:D

Any chance we can include a URL in the notes to back up our claim of what the maintainers are saying?

I can include that no problem 👍


Error(s) in loading state_dict for VideoLLAMA

Hi, I am running the demo with only VL branch, I set the checkpoint path like:
llama_model: "model_weights/vicuna_final/"
ckpt: '/home/ubuntu/Documents/Video-LLaMA/model_weights/Pre-trained_Visual_Encoder/pretrained_minigpt4.pth'   # you can use our pretrained ckpt from https://huggingface.co/DAMO-NLP-SG/Video-LLaMA-2-13B-Pretrained/
equip_audio_branch: False

and the weight files are organised like: https://i.postimg.cc/CKCFK2ZD/files.png
When I run the command:
python demo_video.py \
    --cfg-path eval_configs/video_llama_eval_only_vl.yaml \
    --model_type vicuna \
    --gpu-id 0

It raises an error:
Initializing Chat
Loading VIT
Loading VIT Done
Loading Q-Former
Using pad_token, but it is not set yet.
Loading checkpoint shards: 100%|██████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:06<00:00,  3.13s/it]
Load first Checkpoint: /home/ubuntu/Documents/Video-LLaMA/model_weights/Pre-trained_Visual_Encoder/pretrained_minigpt4.pth
Traceback (most recent call last):
  File "/home/ubuntu/Documents/Video-LLaMA/demo_video.py", line 67, in <module>
    model = model_cls.from_config(model_config).to('cuda:{}'.format(args.gpu_id))
  File "/home/ubuntu/Documents/Video-LLaMA/video_llama/models/video_llama.py", line 608, in from_config
    msg = model.load_state_dict(ckpt['model'], strict=False)
  File "/home/ubuntu/anaconda3/envs/videollama/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1604, in load_state_dict
    raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for VideoLLAMA:
        size mismatch for llama_proj.weight: copying a param with shape torch.Size([5120, 768]) from checkpoint, the shape in current model is torch.Size([4096, 768]).
        size mismatch for llama_proj.bias: copying a param with shape torch.Size([5120]) from checkpoint, the shape in current model is torch.Size([4096]).

So what is the problem? Thank you a lot!

It seems like the llama_proj.weight declared by the model has a different size compared to the pretrained_minigpt4.pth. @hangzhang-nlp @lixin4ever Thank you a lot!

I'm seeing the same issue, have you found a solution?

Hi @tiesanguaixia , same issue here.
Do you find any solution?

This weight works in my case - https://huggingface.co/wangrongsheng/MiniGPT4-7B/tree/main

Hi~We are researching a project, and the Webvid-2.5M dataset is very important to us. We found that the link is no longer working. Could you share this dataset with us?
<EMAIL_ADDRESS>


Problem with basic auth on GET request

Hi,
i am trying to do a GET request with basic auth, but the auth header are not send.
Here is the code:
axios.get( 	'api/example', 	{ 		headers: { 'Accept': 'application/json' }, 		auth: { 			username: 'example', 			password: 'passwdexample' 		}, 		params: { sinceDays: 7 } 	}
Image of header sent
Thanks

Since you closed this yourself, can you mention what solved the problem for you?


Support .ico format

It'd be good to have .ico format download

Came here to say this. Please add .ico format!

I did some digging and there does not seem to be a simple way to enable this. Since there is no backend it would need to be done completely in Javascript and so far I could only find a few hacks that will not work on all browsers. So for the time being I would suggest using a converter such as icoconverter.com.

Thank you guys for reporting but at this point there does not seem to be a satisfying fix.

I spent some time today and wrote a backend just for .ico creation ;-).


You need to enable javascript to run this app

I installed the app using npm install and while running the app using npm start. After deploying the project on GitHub, the app displays a message saying You need to enable JavaScript to run this app.

yeah mee too any solution §


Is there a way to update contents in bulk?

Please use the mailing list! See https://groups.google.com/forum/#!forum/github-api


Stebalien's TODO

[x] Remove DialContext and add a context parameter to Dial.
[ ] Add a SetAddrFilters method to Listener. Let's push this down as far as we can go.
[ ] Figure out naming. This package is really really "multiaddr transports". go-libp2p-interface-conn is the equivalent for p2p transports.

Nonsensical due to the refactor.


Undesired behavior using AssetManager->publish

What steps will reproduce the problem?
Try to publish a  file with dependencies using the mock assetManager of codeception.
Check this datetimepicker extension: https://github.com/nkovacs/yii2-datetimepicker/blob/master/DateTimePicker.php#L191
What is the expected result?
The publishFile/Directory should copy and publish the bundles to the right place.
SUGGESTION: The mockAssetManager should be initialized and parse the aliases of the basePath attribute. Even if the assetManager is disabled and mocked the publish methods should work properly.
What do you get instead?
Asset manager publishes the asset to the wrong folder without parsing the basePath, which contains mostly the alias '@webroot'. The results is a new folder under the project-root<EMAIL_ADDRESS>Additional info

Q
A

Yii version
2.0.7

PHP version
PHP 5.6.23

Operating system
Linux xxxxx 3.13.0-85-generic #129-Ubuntu SMP Thu Mar 17 20:50:15 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

I think it's already fixed in Codeception master. Anyway, it is not an issue of Yii core framework.

Yes you have right, \Codeception\Lib\Connector\Yii2 is responsible to mock the assetManager.
But the issue with the @webroot directory still exists when you use the publish() method. (https://github.com/Codeception/Codeception/issues/3706)
but thanks anyway.


[DO NOT MERGE]: Fix cli demo data

It has content (and requires) from https://github.com/inveniosoftware/invenio-rdm-records/pull/519. If needs merge, cherry pick the last commit and remove the pids assertion of the test.

Closed in favour of https://github.com/inveniosoftware/invenio-rdm-records/pull/519


[naver] Add support for multi track videos

youtube-dl.exe "http://tvcast.naver.com/v/434716"
[Naver] 434716: Downloading webpage
ERROR: couldn't extract vid and key; please report this issue on https://yt-dl.org/bug .
Make sure you are using the latest version; type  youtube-dl -U  to update.
Be sure to call youtube-dl with the --verbose flag and include its complete output.

Duplicate of #5857.

Duplicate of #3711.


OpenAPIDeserializer code cleanup

No logic changes. Code cleanup only.

@taylortails Thank you for your feedback. Just to clarify, are you suggesting that the code can be removed because it is equivalent and redundant, or should it remain as it is?


Modus NavBar - Include Add icon

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #1247
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
We tested both using the index.html page and running storybook to verify. Review was done by different developer than the one doing the work.
Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (including CHANGELOG updates)
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

We can wait on this being included in a future release at this time.

Closing, will create new PR when work is completed on changes.


Journeys endpoint broken?

For me the journeys endpoint seems to be broken. I always get a 503 error. Anyone else experiencing the same problems?
Seems like ÖBB changed the domain - if I change "https://tickets-mobile.oebb.at" to "https://shop.oebbtickets.at" it works again.

Saw your PR on this. Looking good to me.
Thank you!


Making it work only in Release

Is there a way to make it work only in release? So there is no "slowdown" when starting the project do debug it.

I suppose you're specifically talking about project.json, as opposed to csproj, in which you just use a different command line, correct?

Yes, talking about using it with project.json in a Windows Phone project. What do you mean by different command line?

I'm taking about the fact that in order to use the tool with sln/csproj, you directly call roslyn-linq-rewrite app.csproj, as opposed to msbuild

Yes it probably makes sense to only optimize linq when ordinary c# optimizations are on. The only minor problem with this is that dotnet build always recompiles dependencies that use custom compilers, but that's another issue