Adding new progress popup

Extend popup dialog to not show a close button
Adding download files command

fixing #27


Questions about Roundup

line 314, the equation divide d.Ticks and then multiple it again? Or should it just be the reverse of "RoundDown" method:
return time.AddTicks(time.Ticks / d.Ticks);
Could anyone look into it?

I've made a comment, it looks like the math in your PR isn't exactly correct. I think you intend for a modulus operation vs division. Also, please include unit tests with pull requests, thanks for the contribution!

That's right. It should be "%" instead of "/".
Honestly, I haven't done any unit test before. But I'll read some examples of others' PR first and learn from it.

You can also just take a peak at the QuantConnect.Tests project, there are several examples of using nUnit in there. It's fairly easy to use.


feat: removing user from organisation

What does this PR do?
This PR aims to allow an organisation owner to remove a member from their organisation.
How can this be manually tested?

Create an organisation using POST /api/v1/organisations
Create a new user and get their user ID
Add the user to the organisation
Remove the user from the organisation

Edge Cases

Test when the organisation does not exist
Test when the current user is not the owner of the organisation
Test when the specified user is not a member of the organisation

Checklist

[x] Create the endpoint HTTP DELETE /api/v1/organisations/{org_id}/users/{user_id} to remove a user from an organization.
[x] Implement authentication middleware to validate JWT tokens.
[x] Implement an authorization check to ensure that only the organization's owner has the ability to remove users.
[x] Validate the request param {orgId} and {userId}
[x] Write unit tests for all scenarios, including successful removal of user from organization and validation errors.

Responses
Successful Response
{
      status: 'Success',
      message: 'User removed successfully',
      status_code: 200,
}

Error Response when organisation does not exist
{
   status: 'error',
   message: 'Organisation not found',
    status_code: 404,
}

Error Response when the current user does not own the organisation
{
        status: 'Forbidden',
        message: 'Only admin can remove users',
        status_code: 403,
}

Error Response when the specified user is not a member of the organisation
{
        status: 'error',
        message: 'User not found',
        status_code: 404,
}

Associated Issue
Issue #61

Please fix your workflow, pull the latest changes to the repo run your install and push back

Merge conflicts, please resolve


Kartoza Epic 5: Put docker osm on healthsite orcestration

Problem
Currently, on our current PR orchestration, docker osm is separated from healthsites, making use to spin it up separately
Solution
Put docker osm on our orchestration with healthcare profile on it and spin it up with healthsites orchestration
child of #1011

it is already done


Incorrect triangulation of polygons with many holes

I tried to use Text to write Chinese, but there were many problems.
For example, the simplest one is to write the word "回". But the result is this (contains unnecessary connections):
class TextBug(Scene):
    def construct(self):
        txt = Text("回", font="庞门正道标题体", height=FRAME_HEIGHT-1)
        self.add(txt)

I lowered its opacity and showed the point set and its indices. The result is this:
class TextBug(Scene):
    def construct(self):
        txt = Text("回", font="庞门正道标题体", height=FRAME_HEIGHT-1)
        txt.set_fill(opacity=0.3)
        self.add(txt)
        points = txt[0].get_points()
        ind = index_labels(points).set_color(PURPLE).set_stroke(width=1)
        self.add(ind)

The position and order of the point set are correct. So I suspect that there may be an error in the triangulation, so I displayed the inner triangles in the triangulation, and the result is this:
class TextBug(Scene):
    def construct(self):
        txt = Text("回", font="庞门正道标题体", height=FRAME_HEIGHT-1)
        txt.set_fill(opacity=0.3)
        self.add(txt)
        points = txt[0].get_points()
        ind = index_labels(points).set_color(PURPLE).set_stroke(width=1)
        self.add(ind)
        tri = txt[0].get_triangulation()
        tri_indices = tri[len(points):]
        a = tri_indices[0::3]
        b = tri_indices[1::3]
        c = tri_indices[2::3]
        for i, _ in enumerate(a):
            self.add(Polygon(points[a[i]], points[b[i]], points[c[i]],\
            stroke_color=WHITE, stroke_width=4, fill_color=ORANGE, fill_opacity=0.5))

Basically it is certain that there is a problem, but I don't know how to solve it.

In addition, this is the svg file of this Chinese character, you can use SVGMobject to test it.
d17bf5c77d8120cd.txt (change its extension to .svg, because GitHub does not support uploading svg files here)
And it this way, not only Text will have problems, but SVGMobject and even other mobjects may also have such problems.
So, @3b1b please take a look at this.

The best solution to this would be to find a replacement for the current "earclip_triangulation" function.  Unfortunately, this does not seem to work well for polygons with too many holes.  I have previously looked for a more robust library in python, and if you can find one do let me know.
I can take a look at this example and try to fix it more directly, but I'm hesitant to make any promises.

One solution here would be to find a more robust polygon triangulation library written in C, not python, and use that.

I just tried another simpler Scene:
def get_tri(mob):
    tri = mob.get_triangulation()
    points = mob.get_points()
    tri_indices = tri[len(points):]
    a = tri_indices[0::3]
    b = tri_indices[1::3]
    c = tri_indices[2::3]
    tris = VGroup()
    for i, _ in enumerate(a):
        tris.add(Polygon(points[a[i]], points[b[i]], points[c[i]],\
        stroke_color=WHITE, stroke_width=4, fill_color=ORANGE, fill_opacity=0.5))
    return tris

def get_dots(mob):
    points = mob.get_points()
    dots = VGroup()
    for point in points:
        dots.add(SmallDot(point, color=PURPLE))
    return dots

class SquaresTri(Scene):
    def construct(self):
        squares = VGroup(*[
            Square(i) for i in np.arange(7, 0, -2)
        ])
        self.add(squares)
        square = VMobject()
        square.set_fill(opacity=0.3)
        for index, mob in enumerate(squares):
            if index % 2:
                square.append_points(mob.get_points()[::-1])
            else:
                square.append_points(mob.get_points())
        self.add(square)
        self.add(get_tri(square), get_dots(square))

The expected result is like (made in cairo-backend version):

But the code now give me this:

And if I try more squares, that is to change np.arange(7, 0, -2) to np.arange(7, 0, -1), it will give me this error:
Traceback (most recent call last):
  File "manim.py", line 5, in <module>
    manimlib.main()
  File "...\manimlib\__init__.py", line 12, in main
    scene.run()
  File "...\manimlib\scene\scene.py", line 76, in run
    self.tear_down()
  File "...\manimlib\scene\scene.py", line 95, in tear_down
    self.interact()
.........
  File "...\manimlib\mobject\types\vectorized_mobject.py", line 800, in get_triangulation
    inner_tri_indices = inner_vert_indices[earclip_triangulation(inner_verts, rings)]
  File "...\manimlib\utils\space_ops.py", line 364, in earclip_triangulation
    j = int(norms[norms[:, 1].argmin()][0])
IndexError: too many indices for array: array is 1-dimensional, but 2 were indexed

So there may exactly be something wrong in earclip_triangulation.

This may be helpful: https://github.com/SebLague/Ear-Clipping-Triangulation/tree/master

Am I wrong in saying https://trimsh.org/ would handle this?

Okay, I think I may have fixed it with this commit.  Let me know if that works for you.

Am I wrong in saying https://trimsh.org/ would handle this?

Maybe I'm missing something, but it looks like trimesh is useful for working with and manipulating meshes of 3d objects once you already have them, but I'm not seeing where it would be useful for finding the triangulation of a 2d polygon with many holes.

Okay, I think I may have fixed it with this commit. Let me know if that works for you.

Great, it works now.

The aforementioned SquaresTri scene has been able to run normally. And some Chinese can also be displayed normally:

But the "回" mentioned at the beginning and the svg file still cannot be displayed correctly:

I guess it’s because the points of the svg with the word "回" are concentrated first on the inner circle and then on the outer circle, causing the outer circle to cover the inner circle:

Can you attach the relevant svg?  When I render that character in other fonts it looks fine, but I don't currently have the font from the example above installed.

Here: d17bf5c77d8120cd.txt (change its extension to .svg, because GitHub does not support uploading svg files here)
(I sent this svg at the front of this issue, but it may not be obvious)

Okay, I'll look into it.

Alright, I believe this change should actually fix it in a more robust way.  It works on the svg you passed, and it seems to work on all the Chinese text I try, let me know how it looks @TonyCrane.

That's great! And I also tried some other characters and even a whole passage, they all look good.

But there may be still a bug. When I tried to run the SquaresTri Scene, it can't display properly, which can display correctly before this changes.
class SquaresTri(Scene):
    def construct(self):
        squares = VGroup(*[
            Square(i) for i in np.arange(7, 0, -1)
        ])
        self.add(squares)
        square = VMobject()
        square.set_fill(opacity=0.3)
        for index, mob in enumerate(squares):
            if index % 2:
                square.append_points(mob.get_points()[::-1])
            else:
                square.append_points(mob.get_points())
        self.add(square)

Fascinating.  Unless I am mistaken, believe this is an error with the mapbox_earcut library, and not with the wrapper I wrote around it.
In some sense, this is an "unstable" exception.  What I mean that is that if you perturb the squares slightly, e.g.
       squares = VGroup(*[             Square(i).shift(0.1 * i * RIGHT) for i in np.arange(7, 0, -1)         ])
then it works properly.  Also, if you call square.insert_n_curves(10), it will render correctly.
The wrapper is just there to turn a polygon with holes into a continuous polygon by connecting the holes, analogous to how the limit of a keyhole contour is a discontinuous contour with a hole in it.  The way it connects up indices in the perturbed example is the same as how it does in the faulty centered example, which leads me to believe it's not an issue with that connecting process.  From there, it's up to the mapbox_earcut library to fill in the single continuous polygon correctly.
Perhaps this means the ultimate solution really does lie with finding a better triangulation library.
If it's alright, I'll go ahead and close this issue since it seems like the exception involving holes within holes within holes may be pathological enough not to come up in practice.  But of course, feel free to reopen it if it does.

The Chinese character shown in svg is not correctly displayed.
54bc7458065788e9.txt
Change txt to svg.

Fascinating. Unless I am mistaken, I believe this is an error with the mapbox_earcut library, and not with the wrapper I wrote around it.
In some sense, this is an "unstable" exception. What I mean that is that if you perturb the squares slightly, e.g.
 squares = VGroup(*[ Square(i).shift(0.1 * i * RIGHT) for i in np.arange(7, 0, -1) ])
then it works properly. Also, if you call square.insert_n_curves(10), it will render correctly.
The wrapper is just there to turn a polygon with holes into a continuous polygon by connecting the holes, analogous to how the limit of a keyhole contour is a discontinuous contour with a hole in it. The way it connects up indices in the perturbed example is the same as how it does in the faulty centered example, which leads me to believe it's not an issue with that connecting process. From there, it's up to the mapbox_earcut library to fill in the single continuous polygon correctly.
Perhaps this means the ultimate solution really does lie with finding a better triangulation library.
If it's alright, I'll go ahead and close this issue since it seems like the exception involving holes within holes within holes may be pathological enough not to come up in practice. But of course, feel free to reopen it if it does.

The Chinese character shown in svg is not correctly displayed.
54bc7458065788e9.txt
Change txt to svg.

Okay, maybe not as pathological as I suspect.  I'll look into if this can be fixed without changing the triangulation library, otherwise, that's probably what we'll need to do.

Okay, maybe not as pathological as I suspect. I'll look into if this can be fixed without changing the triangulation library, otherwise, that's probably what we'll need to do.

There are two versions about this issue you offered before this one, they all work. But this one, it fails.

Man, this is getting hackier by the minute.  I've added done more tweak, which seems to fix this character and the others I try, but clearly the game of small tweaks to fix edge cases suggests a deeper fix may still be needed.

Man, this is getting hackier by the minute. I've added one more tweak, which seems to fix this character and the others I try, but clearly, the game of small tweaks to fix edge cases suggests a deeper fix may still be needed.

Great, at least for 99.9% scenarios, it is enough. If possible, I think it is a great idea to have a video lecture about earcut algorithm and how to cut and paste different parts by some examples like the aforementioned to work with earcut algorithm, I think it will be interesting and very useful.


Inaccurate translation of "Auto-Import Completions" in zh-cn

 Environment data

Language Server version: 2024.12.1
OS and version: darwin arm64
Python version (and distribution if applicable, e.g. Anaconda):
python.analysis.indexing: true
python.analysis.typeCheckingMode: off

 Code Snippet

 Repro Steps

Install ms-ceintl.vscode-language-pack-zh-hans
Turn display language to zh-cn
Open the tab below:

 Expected behavior
The "自动导入完成" line is translated from "Auto-Import Completions".
"Completion" have both meaning of "an unfinished job being done" and "the missing part of sth being filled in". The phase "完成" is closer to the "job done" meaning, making the sentence may be understood as "auto import is completed", which is inaccurate and a bit confusing without context.
I suggest "自动导入补全" or "自动 import 补全" instead.
 Actual behavior
 Logs

Thanks for posting this issue, I agree with this suggestion.


Containerized Ubiquity-Docker-Plugin

Containerize ubiquity-docker-plugin as per Docker's managed plugin system ( plugin v2 architecture)
Pull request supporting

Issue #52
Issue #51
IBM/ubiquity#126
IBM/ubiquity#127 (awaiting SCBE changes if any)
IBM/ubiquity#125

TODO: Will change glide.yaml ubiquity dependency to dev branch once capabilities branch has been checked into ubiquity/dev branch

This change is

Review status: 0 of 12 files reviewed at latest revision, 19 unresolved discussions.

config.json, line 3 at r3 (raw file):

{
  "description": "Ubiquity Docker Volume Plugin",
  "documentation": "https://github.com/IBM/ubiquity-docker-plugin",

This is problematic
The documentation for GA is going to be in SCBE user guide, so the right location here should be change according for the GA

config.json, line 76 at r3 (raw file):

    "socket": "ubiquity.sock",
    "types": [
      "docker.volumedriver/1.0"

r u sure about this version 1.0?

config.json, line 95 at r3 (raw file):

    },
    {
      "source": "/root/.ssh",

what is this for?
if its for Spectrum Scale please add docstring here to mention it

config.json, line 113 at r3 (raw file):

    },
    {
      "source": "/etc/passwd",

r u sure we need this bind?  why?  the contain run as root so why we need it?

Dockerfile, line 10 at r3 (raw file):

FROM alpine:latest
RUN apk --update add ca-certificates multipath-tools nfs-utils open-iscsi openssh sg3_utils \

you should mention package=VERSION, so it will take a specific version and not the latest.
so please checkout what are the latest one that it install it with, and just put the vesion inside.  (we want to have full control on the version that comes to GA version)

glide.yaml, line 6 at r3 (raw file):

  version: ^1.3.0
- package: github.com/IBM/ubiquity
  version: capabilities

change it to dev before the marj

main_suite_test.go, line 80 at r3 (raw file):

	backend = "spectrum-scale"

	confFileName := fmt.Sprintf("/tmp/ubiquity-plugin%s.conf", "Sock")

what is this name Sock?

ubiquity-client.conf, line 1 at r3 (raw file):
Are all these params still relevant??   I think you put them all inside the json file, don't you?  please clarify.

= "/tmp"
backends = ["spectrum-scale"]
logLevel = "info"         # debug / info / error

scripts/plugin_v2.sh, line 3 at r3 (raw file):

#!/bin/bash

set -e

please rename the file to
build_docker_plugin.sh

scripts/plugin_v2.sh, line 5 at r3 (raw file):

set -e

PLUGIN_NAME="ubiquity/ubiquity-docker-plugin"

check if this param already exported and if so use it, if not use the default you mentioned here.
and i think the name PLUGIN_NAME is wrong, because it actually the plugin docker repository, right?

scripts/plugin_v2.sh, line 6 at r3 (raw file):

PLUGIN_NAME="ubiquity/ubiquity-docker-plugin"
TAG="v1"

the same here
please check if TAG export already exist, if so use this TAG if not use v1.0.0 as the default.
also print at the begin of the script the plugin name and the tag

web_server/handler.go, line 82 at r3 (raw file):

		return
	}
	removeVolumeRequest.ContainerOrchestrator = "docker"

please add this "docker" string as const inside the ubiquity repository and use it here instead of duplicate the "docker" here and in the plan you going to use it for validation.

web_server/handler.go, line 98 at r3 (raw file):

	}
	attachRequest.Host = c.hostname
	attachRequest.ContainerOrchestrator = "docker"

same here - use const

web_server/server.go, line 60 at r3 (raw file):

	router.HandleFunc("/VolumeDriver.Path", s.handler.Path).Methods("POST")
	router.HandleFunc("/VolumeDriver.List", s.handler.List).Methods("POST")
	router.HandleFunc("/VolumeDriver.Capabilities", s.handler.GetCapabilities).Methods("POST")

why capability is post and not GET?
ahhh its because we sending the request - i must say its very confusing.

web_server/server.go, line 70 at r3 (raw file):

	err = s.serveUnixSocket(pluginsPath, router)
	if err != nil {
		panic("Error starting web server: " + err.Error())

why  the error message is "error starting web server"??   isn't should be fail to open unix socket?

web_server/server.go, line 77 at r3 (raw file):

	if _,err := os.Stat(resources.DockerPropagatedMount); err != nil {
		if os.IsNotExist(err) {
			if err := os.MkdirAll(resources.DockerPropagatedMount, 0755); err != nil {

why 755?
do you thing other should be able to cd to this directory?
do we expect this path to be already created?

web_server/server.go, line 93 at r3 (raw file):

	if _,err := os.Stat(pluginsPath); err != nil {
		if os.IsNotExist(err) {
			if err := os.MkdirAll(pluginsPath, 0755); err != nil {

755 is ok?

web_server/server.go, line 103 at r3 (raw file):

	}

	ubiquitySocketAddress := path.Join(pluginsPath, fmt.Sprintf("%s.sock", "ubiquity"))

please put this string :  fmt.Sprintf("%s.sock", "ubiquity") as const

web_server/server.go, line 105 at r3 (raw file):

	ubiquitySocketAddress := path.Join(pluginsPath, fmt.Sprintf("%s.sock", "ubiquity"))

	err := syscall.Unlink(ubiquitySocketAddress)

why syscall?
anyway please move this operation inside the ubiquity Executor interface
so you will be able to add unit testing for this part.
did you done unit testing for this code? not sure you can until u put it inside the xecutor

Comments from Reviewable

Hi @amit
Thanks for the effort of this task.
I conducted code review on this PR, please review and apply them.
In addition - is this the only PR for the new docker plugin v2?
Thanks

Review status: 0 of 13 files reviewed at latest revision, 19 unresolved discussions.

config.json, line 3 at r3 (raw file):
Previously, shay-berman wrote…
This is problematic
The documentation for GA is going to be in SCBE user guide, so the right location here should be change according for the GA

The documentation for Ubiquity-Docker-plugin should not be SCBE doc. It should be the landing page for docs related to the plugin only. which in our case is the github readme . The documentation link as of now is correct and can be changed in the future when ubiquity has an official docs page

config.json, line 76 at r3 (raw file):
Previously, shay-berman wrote…
r u sure about this version 1.0?

Yes, I'm sure about version 1.0, this is version 1.0 of their V2 architecture

config.json, line 95 at r3 (raw file):
Previously, shay-berman wrote…
what is this for?
if its for Spectrum Scale please add docstring here to mention it

This is needed for scale.  There is nothing called docstring . Descriptions etc can be done later during GA of ubiquity-docker-plugin

config.json, line 113 at r3 (raw file):
Previously, shay-berman wrote…
r u sure we need this bind?  why?  the contain run as root so why we need it?

yes we need to bind /etc/passwd , /etc/group as we have do user, group permissions change for scale backend.

Dockerfile, line 10 at r3 (raw file):
Previously, shay-berman wrote…
you should mention package=VERSION, so it will take a specific version and not the latest.
so please checkout what are the latest one that it install it with, and just put the vesion inside.  (we want to have full control on the version that comes to GA version)

This can be changed later, it is always advisable to have the latest version of packages to avoid defects and security vulnerabilities

glide.yaml, line 6 at r3 (raw file):
Previously, shay-berman wrote…
change it to dev before the marj

yes, changed to dev

main_suite_test.go, line 80 at r3 (raw file):
Previously, shay-berman wrote…
what is this name Sock?

This is for our integration testing . Integration testing will probably be meaningless going forward as plugin must be tested as v2, so acceptance tests will be a better way to go forward .

ubiquity-client.conf, line 1 at r3 (raw file):
Previously, shay-berman wrote…
Are all these params still relevant??   I think you put them all inside the json file, don't you?  please clarify.

= "/tmp"
backends = ["spectrum-scale"]
logLevel = "info"         # debug / info / error

Integration tests run differently than acceptance tests. CI pipeline will going forward need to run acceptance tests only . These commits to integration testing are needed but will not be used in CI/ CD pipeline but these changes need to go in.

scripts/plugin_v2.sh, line 3 at r3 (raw file):
Previously, shay-berman wrote…
please rename the file to
build_docker_plugin.sh

done

scripts/plugin_v2.sh, line 5 at r3 (raw file):
Previously, shay-berman wrote…
check if this param already exported and if so use it, if not use the default you mentioned here.
and i think the name PLUGIN_NAME is wrong, because it actually the plugin docker repository, right?

no need to do env checking. This is just a variable  and it is plugin name . Please try it out first to know how it works.

scripts/plugin_v2.sh, line 6 at r3 (raw file):
Previously, shay-berman wrote…
the same here
please check if TAG export already exist, if so use this TAG if not use v1.0.0 as the default.
also print at the begin of the script the plugin name and the tag

No need for env checking first . Printing at beginning is already done

web_server/handler.go, line 82 at r3 (raw file):
Previously, shay-berman wrote…
please add this "docker" string as const inside the ubiquity repository and use it here instead of duplicate the "docker" here and in the plan you going to use it for validation.

done

web_server/handler.go, line 98 at r3 (raw file):
Previously, shay-berman wrote…
same here - use const

done

web_server/server.go, line 60 at r3 (raw file):
Previously, shay-berman wrote…
why capability is post and not GET?
ahhh its because we sending the request - i must say its very confusing.

POST is good for now

web_server/server.go, line 70 at r3 (raw file):
Previously, shay-berman wrote…
why  the error message is "error starting web server"??   isn't should be fail to open unix socket?

This is correct message. We do capture error message when socket fails and log that.

web_server/server.go, line 77 at r3 (raw file):
Previously, shay-berman wrote…
why 755?
do you thing other should be able to cd to this directory?
do we expect this path to be already created?

path is created  while creating the plugin, this is a secondary check just in case.

web_server/server.go, line 93 at r3 (raw file):
Previously, shay-berman wrote…
755 is ok?

Yes this is needed and I've checked with Docker folks

web_server/server.go, line 103 at r3 (raw file):
Previously, shay-berman wrote…
please put this string :  fmt.Sprintf("%s.sock", "ubiquity") as const

That  is not necessary

web_server/server.go, line 105 at r3 (raw file):
Previously, shay-berman wrote…
why syscall?
anyway please move this operation inside the ubiquity Executor interface
so you will be able to add unit testing for this part.
did you done unit testing for this code? not sure you can until u put it inside the xecutor

changed to using executor to use unlink instead of syscall.

Comments from Reviewable


Will not even install

I am getting errors when trying to install:
npm ERR! code ENOENT
npm ERR! syscall spawn git
npm ERR! path git
npm ERR! errno -2
npm ERR! enoent An unknown git error occurred
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
and on digital ocean I get:
npm ERR! code 128
npm ERR! An unknown git error occurred
npm ERR! command git --no-replace-objects ls-remote<EMAIL_ADDRESS>npm ERR! Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
npm ERR<EMAIL_ADDRESS>Permission denied (publickey).
npm ERR! fatal: Could not read from remote repository.
npm ERR!
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
I am able to install other repositories without any problems.

Duplicates #118


Hanging webhooks

Hello
I develop a bot, and there are often situations when a user sends a message, but a webhook message comes in 10-15 seconds, this happens if the user has not written for a long time. This happens without using your telegram-bot-api. Actually, my question is, will using your local server help to solve this problem?
P.S I understand that this is not an Issue, I don't know who to turn to anymore, I can't understand what's going on

This is likely an issue with the server where your bot is hosted, or with the bot's code.


Snippets does not show in autocomplete like before, something has changed?

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.75.0
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.6.0

Dont know what has happened but it must be something that has changed in how the snippets are put into the autocomplete list since I have not changed anything in my current project I work in and the snippets worked fine last week but now they dont even show up in the autocomplete list.
Steps to Reproduce:

Create a snippet with a key that i something generic, like "vos" or in my case "lkga"
Type the snippet text in your editor

Expected behavior:
The defined snippet should be the first item in autocomplete list since its an exact match.
Current behavior:
The snippet is not present at all in the autocomplete list.

Same here. I also noticed that if you type just several (or even one) first characters of the snippet it appears in the autocomplete list. But if type the whole snippet, it's not there.

Same experience, the latest release broke a few things.

Noticed the same thing.

Same problem here, though it seems to behave randomly. Sometimes I get my snippets, sometimes I don't.

Same here.
version info:
Version: 1.75.0 (user setup)
Date: 2023-02-01T15:23:45.584Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No

/duplicate of https://github.com/microsoft/vscode/issues/173244

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Install on code-server

I can not install the application on code-server
https://github.com/cdr/code-server
During installation, the error "Unable to install because, the extension 'rogalmic.bash-debug' compatible with current version '1.33.1' of VS Code is not found."

Dependencies are:
  "engines": {
    "vscode": "^1.37.0",
    "node": "^10.11.0"
  },

Which version of vscode is used for install?


Record reference should include attribute target for positional records

Positional records can include the field: or property: attribute target on the primary constructor in order to apply attributes to the field or property generated from those parameters. (You can also apply the parameter: but that is the default).
In addition, this content should be linked from the following locations:

Attributes that affect compilation, in the section on AttributeUsage
JSON Serialization: One of the most common scenarios for using this will be applying JSON serialization attributes to the record's properties. Likely candidates would be the name, or the ignore attribute.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20818c64-4ad8-fb15-5d79-e7f98614e9c4
Version Independent ID: de1f383b-ef20-4776-57a8-04edae892166
Content: Records - C# reference
Content Source: docs/csharp/language-reference/builtin-types/record.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

/cc @tdykstra Which JSON sample makes the most sense for linking to the new content for this issue?

Shayne's tweet provided an example of using this with MongoDB. The team should consider updating the 5.0+ versions of the web API MongoDB tutorial to show this feature off.

@BillWagner I think the records reference should also include the ability of documenting the primary constructor through /// <param name="ParamName"></param>. Is it okay for this to be tracked in this issue or should I open a separate issue?

Thanks @Youssef1313
Let's address it as part of this issue.

Which JSON sample makes the most sense for linking to the new content for this issue?

https://docs.microsoft.com/dotnet/standard/serialization/system-text-json-immutability?pivots=dotnet-5-0#immutable-types-and-records


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-06-17)
⚠ BREAKING CHANGES

Entity marked as hidden in Home Assistant are automatically hidden in Matter.

Features

lights: added identify cluster server (c527a07)
refactor device types to aspects, add (#52) added hidden attribute (9bc4126)
refactor home-assistant-client (20477cb)

Bug Fixes

add pattern matcher after refactoring (38f2303)
deps: update dependency @dotenvx/dotenvx to v0.44.4 (#75) (63fd48b)
deps: update docker/build-push-action action to v6 (#87) (77b22b1)
deps: update npm (#73) (af80419)
fix level control brightness selector (48fb8ac)
lights: removed dist import (0b7cfb7)
made level control and onoff aspect configurable (81f64ff)
removed dist imports (f3f150f)
switch: add identify aspect to switches (d8579f8)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.0
:sunflower:


broken website width - why there is a horizontal scroll in the browser?

simply put for some reason there is a horizontal scroller bar in the browser for some reason


Allow to set UDP ClientConn timing parameters

Fixes #180
Adds SetTransmissionNStart, SetTransmissionAcknowledgeTimeout, SetTransmissionMaxRetransmit
It's not threadsafe, do we needs an additional Mutex and "safe" methods for using the values?

Yes. It must be thread-safe becasue get/set can be used from different go routines. You can use atomic.Value instead of mutex for each value.

Are you okay with using go.uber.org/atomic. Maybe an alternative is to copy the wrappers over from there to remove the dependency.

Thx


Add integration test

The rust project can be split into two parts:

Godot Scene runner
Scene Runtime

The Scene-Runtime is mostly a wrapper to the Javascript code and it can be tested by unit test mostly.
For the Godot scene runner, the Godot environment is needed. For this: using #[itest] macro from godot_macros to inject the Godot environment and test the Godot-related part in Rust seems to be the right approach.

[ ] Test parenting and cyclic parenting

Regarding the Godot project, it can involve some calls to the library, but also it can have its own tests, one approach could be using https://github.com/bitwes/Gut

Integration tests were set up.
Rust library test should be tagged with #[itest]


TLS Certificate chain not accepted when registering

Description
When joining an iSHARE Test Network (which is based on HLF Fabric), the provided certificate chain for TLS certificates that will be used by the peer nodes is being rejected. This is caused by the start/end date of one of the intermediates being wider than the start/end date of its issuer.
The certificate has been bought from a commercial vendor (Sectigo), so we can expect that they deliver a valid certificate + validation chain.
Running openssl verify ... against the certificate + ca chain shows OK responses for each certificate.
Is it correct and expected that Hyperledger considers this chain invalid, or should  Hyperledger work in line with the way browsers and openssl verify works, and accept this certificate chain as valid for TLS connections?
Details of the certificate + chain (DNS names redacted):
../scripts/summarizePem.sh fullChain.pem
Inspecting fullChain.pem

cert_0.pem contains:
subject=CN=<redacted>
issuer=C=GB, ST=Greater Manchester, L=Salford, O=Sectigo Limited, CN=Sectigo ECC Domain Validation Secure Server CA
notBefore=Apr  4 00:00:00 2024 GMT
notAfter=Apr  5 23:59:59 2025 GMT

cert_1.pem contains:
subject=C=GB, ST=Greater Manchester, L=Salford, O=Sectigo Limited, CN=Sectigo ECC Domain Validation Secure Server CA
issuer=C=US, ST=New Jersey, L=Jersey City, O=The USERTRUST Network, CN=USERTrust ECC Certification Authority
notBefore=Nov  2 00:00:00 2018 GMT
notAfter=Dec 31 23:59:59 2030 GMT

cert_2.pem contains:
subject=C=US, ST=New Jersey, L=Jersey City, O=The USERTRUST Network, CN=USERTrust ECC Certification Authority
issuer=C=GB, ST=Greater Manchester, L=Salford, O=Comodo CA Limited, CN=AAA Certificate Services
notBefore=Mar 12 00:00:00 2019 GMT
notAfter=Dec 31 23:59:59 2028 GMT

cert_3.pem contains:
subject=C=GB, ST=Greater Manchester, L=Salford, O=Comodo CA Limited, CN=AAA Certificate Services
issuer=C=GB, ST=Greater Manchester, L=Salford, O=Comodo CA Limited, CN=AAA Certificate Services
notBefore=Jan  1 00:00:00 2004 GMT
notAfter=Dec 31 23:59:59 2028 GMT

Steps to reproduce
No response

When joining an iSHARE Test Network (which is based on HLF Fabric)

what's an iSHARE test network? Please don't tell me BlackRock uses Fabric too... :-)
Does the certificate chain work with a simple test using a Golang web server that uses TLS? I'm asking because Fabric doesn't do anything special to the TLS intermediate and root certificates once it's up and running.
Also can you tell the Fabric version?


Revert "Eyecandy: Longer transitions"

Reverts denoland/deno_website2#1780
@Milo123459 Thanks for the PR, but I think this makes the whole site feel slower. I am going to revert it.

I think this makes the whole site feel slower.

I think this is a bit harsh, the patch literally just changes the duration of the animation on-hover for a couple of clickable items

That's the power of UI! Even minuscule changes can make or break it. I think it makes the experience of navigating around the site worse 🤷♂

@Milo123459 No worries. Nothing against you personally!


not quite a pull request, feedback request

On  my fork, branch "working" , and html file "test.html" I've applied a lot of bootstrap styling to make navigation easier.  We had discussed some of this a while ago, and I just wanted to see if this what you had in mind before I go about diving into the python code for html generation

Hi @thfield, thanks. Is there a way I could view it (e.g. by you pushing the site to your gh-pages branch)?

Ok, @cjerdonek got it working on gh-pages: http://thfield.github.io/sf-base-election-data/test.html

Cool, that looks great!  I'm not quite sure yet how to manage modifications to the web site (especially large ones), and also given that the Python is still a bit in flux.  Maybe we can talk about it in person sometime.  Can you shoot me an e-mail just so I can be sure I have yours?  I don't think I have it.  Mine is listed at the bottom of the README of this repo.
Ideally, perhaps the Python code could remain the same or nearly the same, and the Django templates alone could be modified to allow experimenting with different layouts.  Also, just as an FYI, I'm thinking about breaking the HTML-generation code into a separate repo, so that the JSON file and the code to generate the JSON will be in one repo, and code that uses the JSON to generate HTML will be in a different one.  However, that change is probably at least a month away though.

Closing this since we discussed in person.


[Fix] index of storae key in access list

This PR try to fix issue #1132. It respect tx circuits's view, updating the index of storage key into a global increasement, for both copy event and tx.

will have a review tonight.


Protocol error

I and my players get sometimes a Protocol error oO
All have Minecraft 1.6.5 ..
And sometimes (often by some players) you can write in the chat only 2-3 messages, then you need to relogg again (and then is often the protocol error).
Sorry for bad english.

This is EXACTLY what drove many people insane before we switched to the 8.3.4, but now we only get it every once in awhile.

i get this same problem(or something related) on a mac(cilent) and linux(server) with the launch.sh #149

outdated -> closing


fix for #2738

Please test it, i tried to setup a full development environment but i couldn't so i grabbed the react component and test it, it worked for me.
Related issue: #2738

i suspected it would do that because i couldn't use all the component i would like to setup the full dev env but i get the following error Error: PostgreSQL needs to be installed before setup can be completed.
i am on Ubuntu 20.04 i have all dependencies installed, also i am using  postgresql-12

thank you for the help,
i'll install ubuntu xanial VM tomorrow and use the .travis.yml as a source.

Hello @kueda
i managed to setup the databases manually using bin/setup instructions then i did the rest of the setup process everything went smoothly .
However when i ran the local server the homepage loaded but when i enter most pages (eg: http://localhost:3000/signup) i get the following error.
Elasticsearch::Transport::Transport::Errors::NotFound at /signup
`[404] {"error":{"root_cause":[{"type":"index_not_found_exception","reason":"no such index [development_observations]","resource.type":"index_or_alias","resource.id":"development_observations","index_uuid":"na","index":"development_observations"}],"type":"index_not_found_exception","reason":"no such index [development_observations]","resource.type":"index_or_alias","resource.id":"development_observations","index_uuid":"na","index":"development_observations"},"status":404}
`

OS : Ubuntu 16.04
Ruby : 2.6.5

Looks like elasticsearch didn't get set up correctly. Did you go through the steps at https://github.com/inaturalist/inaturalist/wiki/Development-Setup-Guide#elasticsearch? Since you're getting that error I'm guessing you have ES up and running but you just didn't run rake es:rebuild.

@ThamiMemel, not sure if you're still planning to work on this, but we just changed the default branch from master to main, so you might need to update this PR or just open another one.

@ThamiMemel it's been a month so I'm guessing you're not planning on working on this anymore. I'm going to close this for now and open up the issue, but if you change your mind and want to work on this again, feel free to open a new PR.


🎉 ✨ wizard: fasttrack integration, modular page config

TL; DR
Run
etl-wizard fasttrack

and check that it works as expected.
More in-depth
Tasks

[x] Make apps more modular. Apps are added to the Wizard homepage by means of a config.yml file.

https://github.com/owid/etl/issues/2255

[x] Move Fast-Track to Wizard.

https://github.com/owid/etl/issues/2253

[x] Add metaplay
[x] Put Wizard pages in a single folder: apps/wizard/pages/

Review guidelines
Several files are affected by this PR, but most are due to file renaming.

Renaming of apps/wizard/templating → apps/wizard/etl_steps.
Fast-track support in Wizard: apps/wizard/pages/fasttrack/

[ ] apps/pages/wizard/fasttrack/app.py: Entrypoint to the app.
[ ] apps/pages/wizard/load.py: Load the data from a Google sheet or local CSV. (contains former content from fasttrack.csv and fasttrack.sheets code, and additional.
[ ] apps/pages/wizard/process.py: Process and submit the new dataset to Grapher. Some of the code could live in app.py, but just took some away to reduce length of it.
[ ] apps/pages/wizard/fast_import.py: Class Fasttrackimport, used in process.py to submit the new dataset.
[ ] apps/pages/wizard/utils.py: Utils for the step.
[ ] apps/pages/wizard/fasttrack/cookiecutter/: Template to create python grapher script.
[ ] apps/pages/wizard/fasttrack/markdown/: Text shown in the app (mostly guidelines on how to import data)

Make adding apps/pages to Wizard simpler: apps/wizard/config/

[ ] apps/pages/wizard/config/config.yml: List of Wizard apps. Easily configurable.
[ ] apps/pages/wizard/config/__init__.py: Load configuration and others.
[ ] apps/pages/wizard/app.py, apps/wizard/home.py, apps/wizard/cli.py: Minor changes to make it work with new modular configuration.

Integrate Metaplay into Wizard

[ ] apps/wizard/pages/metaplay.py: Script with metaplay app. Deprecated and removed the former version from apps/metadata_playground/ and command etl-metaplay (in favour of etl-wizard metaplay).

Future

Deprecate walkthrough.
Deprecate fasttrack (outside of wizard).
Add guidelines to our docs on how to add a new page/app to Wizard.

Summary by CodeRabbit

New Features

Introduced dynamic table of contents generation in the Wizard app.
Added new Fast-track tool functionalities for importing datasets from Google Sheets or local CSV files.
Implemented a metadata playground app for enhanced data handling and visualization.

Enhancements

Improved logic for page switching in the Wizard app to support various phases and aliases.
Enhanced configuration loading and validation for more robust app settings management.

Documentation

Updated guidelines and instructions for importing datasets using the Fast-track tool.
Removed outdated references to the metadata_playground tool, focusing on current functionalities.

Refactor

Streamlined app configuration and CLI phase definitions for better maintainability and user experience.

@Marigold The most relevant change is related to fasttrack.
If you could just try it as you usually have and see how it feels. Some things are slightly different (e.g. the file difference) since the Streamlit framework has different capabilities.

@lucasrodes I tested it locally and ran into an error. Instructions:

etl-wizard fasttrack locally
Existing sheet, select DRAFT OWID Donations / latest
Submit

then I ran into an error
File "/Users/mojmir/projects/etl/etl/files.py", line 146, in _str_presenter
    if (len(lines) > 1) or (max([len(line) for line in lines]) > 120):
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I think I should be able to fix it (and get familiar with the code as a bonus), just let me know if you're ok with it.

hi @Marigold , I think I was getting this error too when using the former fasttrack version with certain google sheets. So I assumed this was not a new issue.
Looks like maybe there is something off with the google sheet? or maybe there is something not accounted for in the code?
Note that you may have to fix this in two places: apps/fasttrack and apps/wizard/pages/fasttrack


Fix filesystem linking on clang9

The nightly Linux builds are now running on Focal which has LLVM 9, which no longer provides filesystem as a separate library and instead provides it as part of libc++
Intended to resolve red status on https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/
Signed-off-by: Emerson Knapp<EMAIL_ADDRESS>

Nightly Linux Clang Libcxx

This isn't an optimization, just a build fix for a new version of the compiler

Nightly linux clang libcxx

Linux
Linux-aarch64
macOS
Windows

@emersonknapp did you have a reason for not scoping your CI builds to --packages-up-to pluginlib?

Since the cmake extras affect the build of dependent packages it needed to be everything upstream as well. Maybe --packages-up-to pluginlib --packages-above pluginlib would be more directed

Maybe --packages-up-to pluginlib --packages-above pluginlib would be more directed

The package selection arguments take the intersection so that would just build pluginlib. You'd need to separately list both sets first and use --packages-select with it.

Since the cmake extras affect the build of dependent packages it needed to be everything upstream as well.

Packages depending on pluginlib are called downstream packages.

Hence just build everything, no packages-through option... the slow stuff is like ogre vendor, and rviz uses pluginlib so probably not much to be gained

Packages depending on pluginlib are called downstream packages.

You're right, but you also got the point :)

Looking at the rosbag2_storage build failure in Linux/clang, this header's include check for std::filesystem and >=C++17 is coming back negative resulting in it finding and including experimental::filesystem and triggering the deprecation warning.
If we don't make any changes to that header, I think the downstream packages all need to be moved to C++17. Bumping the C++ version in rosbag2_storage to C++17 resolved that build error locally. The other option to explore is silencing that deprecation warning as we currently do on Windows.

Foxy won't be requiring C++17 since we currently don't use any C++17 features. So it needs stay compatible with C++14 compilers.

In that case @emersonknapp and I will need to look closer and figure out why this change resolves the issue for pluginlib's own build but not rosbag2_storage's on top of it.

After looking at combinations of C++14, 17 and experimental/filesystem, filesystem locally I'm not sure why this PR in its current state doesn't trigger the deprecation error during pluginlib's own test compilation. But I am pretty sure that the right answer to using C++14 with experimental/filesystem via clang10 is to suppress the deprecation.
@emersonknapp do you want to pull https://github.com/ros/pluginlib/commit/79576967292a7955c42f433cbb1ccb1802cdb9a9 into your branch and re-run the full CI gamut? I ran  which just includes pluginlib and rosbag2_storage. This should be enough to get us building on clang to address the warnings.

Linux
Linux-aarch64
macOS
Windows
Nightly linux clang libcxx

@nuclearsandwich I think we're good to merge with this, see analysis in previous comment for yellow builds

@nuclearsandwich @dirk-thomas @emersonknapp  Even if we're targeting C++14, the correct change to target C++14 is to set CMAKE_CXX_STANDARD to 17, as explained here https://github.com/ros/pluginlib/pull/182#issuecomment-606383370. By silencing the warning, you will break the build.


Add NodeFort.io

Hi @prettymuchbryce, I had to remove NodeFort.io in https://github.com/ipfs/awesome-ipfs/pull/306 to fix our CI (it failed due to broken link).
(if you restore the service at some point in the future, feel free to add it again)


dismiss announcement option

used to be there, wasn't useful?

forgot, it shows up in maximal theme


Add plot_imputation

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[ ] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Type of Change

[ ] Examples / docs / tutorials / contributors update
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Improvement (non-breaking change which improves an existing feature)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes
Look #588.
Related Issue
#588.
Closing issues
Closes #588.

Example script
import matplotlib.pyplot as plt
import pandas as pd

from etna.analysis import plot_imputation
from etna.datasets import TSDataset
from etna.transforms import DensityOutliersTransform
from etna.transforms import TimeSeriesImputerTransform

def main():
    df = pd.read_csv("examples/data/example_dataset.csv", parse_dates=["timestamp"])
    ts = TSDataset(df=TSDataset.to_dataset(df), freq="D")
    outliers_transform = DensityOutliersTransform(in_column="target", distance_coef=1.0)
    ts.fit_transform(transforms=[outliers_transform])

    # imputers
    imputer_zero = TimeSeriesImputerTransform(in_column="target", strategy="zero")
    imputer_running_mean = TimeSeriesImputerTransform(in_column="target", strategy="running_mean")
    imputer_forward_fill = TimeSeriesImputerTransform(in_column="target", strategy="forward_fill")

    # plots
    plot_imputation(ts=ts, imputer=imputer_zero)
    plt.savefig("imputer_zero")

    plot_imputation(ts=ts, imputer=imputer_running_mean)
    plt.savefig("imputer_running_mean")

    plot_imputation(ts=ts, imputer=imputer_forward_fill)
    plt.savefig("imputer_forward_fill")

if __name__ == "__main__":
    main()

imputer_zero:

imputer_running_mean:

imputer_forward_fill:

Codecov Report

Merging #598 (361c866) into master (4e50849) will decrease coverage by 0.21%.
The diff coverage is 11.76%.

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   85.72%   85.50%   -0.22%
==========================================
  Files         117      117
  Lines        5759     5776      +17
==========================================
+ Hits         4937     4939       +2
- Misses        822      837      +15

Impacted Files
Coverage Δ

etna/analysis/plotters.py
16.61% <6.25%> (-0.50%)
:arrow_down:

etna/analysis/__init__.py
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Add a local on-stack FAT cache for next_cluster

For some operations, e.g. seeking in a file, this makes a huge performance difference since we avoid (re)reading the FAT for every node in the linked list.
For other operations that call next_cluster only once there are no negative implications since the memory for the FAT block would have been allocated on the stack anyways.
A motivation from my specific use case: Seeking in a somewhat large audio file (e.g. 30 minutes) would take multiple seconds, but is now without any perceptible delay.

Interesting!
I'll check this out on Friday when I have some free time.

Still on my todo list. I got distracted by other things.

OK, picking this up right now!

Thank you for this PR! I'll schedule a release soon once I've had another pass to check if there's anything else we should be caching.

Excellent, thank you!


Chord behavior - Smart punctuation (using prefix tilde ~)

Hi there! hope you doing well!
I am using all chords with prefix mode, with the tilde ~, in order to insert my own space (meanwhile new version is released), but Smart  Punctuation (chord option) is deleting last letter of the resultant word with a prefix config, e. g. dictionary file csl  = casual~ is launching the right result casual  -with ending space-, but if you add some punctuation (example, period <.>) script is retrieving: casua. The test is using the prefix configuration, but when just need the prefix itself is when this is happening.
I was thinking about the suggested option is just about adding this tilde symbol if some checkbox is selected at the config panel... Anyway, I hope helping you with this littler bug 😄

Thank you! This is now fixed in this version in 'updates' branch.
I am now going to add the long-delayed change to let users choose not to have spaces added around chords. (And this should eliminate the need to use prefixes as workarounds.)


Option of a new Item in the list

I would like to have the option to add a new item that is not in the enum, for example an item with the name of AUDIO, which when clicking I can call my function to capture audios.

This sounds like a thing for new update

Hi. I have created a new version of the lib. It is already available for both regular(2.2.0) and compose(1.1.0) usage. The changes and usage is described in the Readme. Fill free to contact in the future

In another update It could have an ItemType Custom, which it already closes the picker and calls any function. In my case I want to call a bottomsheet with a button to record an audio
pickerDialog {
            setItems(
                setOf(
                    ...
                    ItemModel(ItemType.Custom())
                )
            )
            setListType(PickerDialog.ListType.TYPE_LIST)
        }.setPickerCloseListener { type, uris ->
            when (type) {
                ...
                is ItemType.Custom -> myRecAudio()
            }
        }.show()

MimeType.Custom expects a parameter

and the ItemType.Files opens the files in my case could not open

yes a parameter of mimeType, e.g. */*. text/plain etc. All ItemTypes except camera items can have one or more mime types to scope the usage of the picker. Btw there is also a new type for audio files AudioGallery

Ok, This AudioGallery opens the files, the ideal would be to have a generic item, which when clicking on it does not call the files, it could close the pickerDialog, falling into an exception.
.setPickerCloseListener { type, uris ->
            when (type) {
                ...
                is ItemType.Generic -> myRecAudio()
            }
        }.show()

the dialog is dismissable, so I don't think there is a need for a button to close it

I didn't express myself properly, I'll try to show in pictures what I have today.
I have this bottomNavigation with 3 options (Audio, Photo and Video)

Clicking on Audio first item opens this BottomSheet with a button to record an audio

In the second it opens a dialog for photo where I'm using another image capture lib

In the third item I use your lib, just to record video or get it from the gallery.

I would like to eliminate bottomNavigation leaving a FloatActionButton calling its library with all the options, which I just need to capture audio.

This would be the example of what I wanted to set up, the last item would call my audio recording function.

Sorry for the amount of images.

I got it. So you want to record audio as well. I will think about it in future updates )


Intro Tour, last dialog imo could be improved.

Operation System: win 10
Beaker version: prerelease 3
At the end of the tour I would like to have a "Done!" or "Enjoy!"  button.

... I'm not a big fan of animations, but here, if the Done! button is clicked, it would be OK, if it transforms into the (?) icon, top right in the corner.
So the user knows, how to "re-activate" the dialog again. ... but this is just a nice to have ;)

intro changed. so I'll close it


libpg_query: 15-4.1.0 -> 15-4.2.0

Description of changes

https://github.com/pganalyze/libpg_query/releases/tag/15-4.2.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build libpg_query

Result of nixpkgs-review pr 215296 run on aarch64-darwin 1

1 package built:

libpg_query


Update drafts extension

Description
Add command Create Draft From Selection as requested with #8815

Screencast
trivial command, no new screencast / screenshot needed

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Thanks @pernielsentikaer that was fast 🤯


Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

I am seeing this error when dragging elements within my list. The sorting is correct and the elements are moving as expected but I am getting this error after dropping my element
Expected behavior

Are you able to reproduce this on one of the examples of our storybook? Do you have this on multiple browsers?
Ideally, could you please create a sandbox reproducing the problem?

I was able to fix this issue by adding a missing key to a parent element. Thanks!

Do you mean that it was a parent created inside a .map() that was missing a key?

Incase anyone finds this, for me it might have been adding
 customHolderRef={mainRef}

field to the SortableList that references the parent div.
Not 100% sure yet, but it feels like it has stopped happening.


Map the kernel tracepoint events to the thread ids and time

For every thread id we monitor which tracepoint events have been triggered and at what time. For that, a red-black tree has been utilized (std::map) that has as the key the thread id and as the value another red-black three to map the pair time and tracepoint event. A sorted associative container has been chosen such that the tracepoint events are sorted: for every thread id found in an non-descending order, the events are found in a non-descending order of time.
Every occured tracepoint event not only is it map to the corresponding thread on which it has been activated but also, it is stored in an universal entry dedicated to all the thread ids (SamplingProfiler::kAllThreadsFakeTid).
At the end, the tracepoint event is registered, meaning that the upper and lower bound for the timeline on which the events happen can be updated.

I see that this is based on the model of EventTracer/EventBuffer, but that's something really old and that we really really need to get rid of—it should not be taken as an example. I would probably look into CaptureData, it should still be accessible everywhere with GOrbitApp->GetCaptureData(). Maybe ask @florian-kuebler for advice as he recently introduced it.
(If it ends up taking too long or being too complicated and we really need to go this route, let's at least avoid having two classes, TracepointEventTracer doesn't do anything.)

I see that this is based on the model of EventTracer/EventBuffer, but that's something really old and that we really really need to get rid of—it should not be taken as an example. I would probably look into CaptureData, it should still be accessible everywhere with GOrbitApp->GetCaptureData(). Maybe ask @florian-kuebler for advice as he recently introduced it.
(If it ends up taking too long or being too complicated and we really need to go this route, let's at least avoid having two classes, TracepointEventTracer doesn't do anything.)

I will also remove TracepointEventTracer.

It is indeed based on EventTracer/EventBuffer because in those file the mapping from the thread ids/timestamps to the events is actually done. The data given by 'GOrbitApp->GetCaptureData()' only gives the callstack events without any hint towards an ordering of the thread ids or of the timestamps. I already have a way to store the tracepoint events and this time I wanted a way to keep track of the threads and timestamps. However, I can see that the style used was 'old'. I will change to fit the new code style. If you have any suggestions please let me know.

I see that you moved from a global to storing a TracepointEventBuffer in OrbitApp which is an improvement. I still think that it should be moved to CaptureData. For example there is a CallstackData in CaptureData. You are right that it doesn't map from tids and timestamps, but don't worry about that (it's actually one reason why EventBuffer is still around), add what you need to your class for what your goal is. For example you can have a TracepointData there, doing what you are doing with TracepointEventBuffer, but without worrying about the parallelism with EventBuffer (e.g., you probably don't need to map by thread, you don't need Reset as you can just create a new object when the capture is cleared, etc.).

It is indeed based on EventTracer/EventBuffer because in those file the mapping from the thread ids/timestamps to the events is actually done. The data given by 'GOrbitApp->GetCaptureData()' only gives the callstack events without any hint towards an ordering of the thread ids or of the timestamps. I already have a way to store the tracepoint events and this time I wanted a way to keep track of the threads and timestamps. However, I can see that the style used was 'old'. I will change to fit the new code style. If you have any suggestions please let me know.

I see that you moved from a global to storing a TracepointEventBuffer in OrbitApp which is an improvement. I still think that it should be moved to CaptureData. For example there is a CallstackData in CaptureData. You are right that it doesn't map from tids and timestamps, but don't worry about that (it's actually one reason why EventBuffer is still around), add what you need to your class for what your goal is. For example you can have a TracepointData there, doing what you are doing with TracepointEventBuffer, but without worrying about the parallelism with EventBuffer (e.g., you probably don't need to map by thread, you don't need Reset as you can just create a new object when the capture is cleared, etc.).

I think the TracepointEventBuffer can either live in the App or in CaptureData for now. There is one issue to be solved anyways, which is synchronization. The original idea of CaptureData was that it lives on the capture thread, and being basically invincible to all other threads while capturing, and then make it visible for read only when capturing is done. But as we can select callstacks while capturing, this isn't solved anyways. Currently, this is somewhat save, as the CallstackData is synchronized internally. However, we should in general rework synchronization of CaptureData. It should provide a mechanism to thread-safe stream data to the app and should be still write only on the capture thread.
TracepointEventBuffer would introduce a similar issue. But as this needs to be done anyways, I think it would be fine to move it to CaptureData for now.


Loki push API: Add can_connect guard in relation events.

Bug Description
Sometimes _on_logging_relation_changed is fired before pebble_ready.
For instance two methods "inside" _on_logging_relation_changed we are executing:
        files = container.list_files(self._rules_dir)

And if Pebble is not ready, and ops.pebble.ConnectionError is raise
To Reproduce
See: https://github.com/canonical/grafana-agent-k8s-operator/runs/5771963079?check_suite_focus=true#step:4:530
Environment
All versions of loki_push_api lib
Relevant log output
Traceback (most recent call last):
  File "./src/charm.py", line 242, in <module>
    main(LokiOperatorCharm)
  File "/var/lib/juju/agents/unit-loki-0/charm/venv/ops/main.py", line 431, in main
    _emit_charm_event(charm, dispatcher.event_name)
  File "/var/lib/juju/agents/unit-loki-0/charm/venv/ops/main.py", line 142, in _emit_charm_event
    event_to_emit.emit(*args, **kwargs)
  File "/var/lib/juju/agents/unit-loki-0/charm/venv/ops/framework.py", line 283, in emit
    framework._emit(event)
  File "/var/lib/juju/agents/unit-loki-0/charm/venv/ops/framework.py", line 743, in _emit
    self._reemit(event_path)
  File "/var/lib/juju/agents/unit-loki-0/charm/venv/ops/framework.py", line 790, in _reemit
    custom_handler(event)
  File "/var/lib/juju/agents/unit-loki-0/charm/lib/charms/loki_k8s/v0/loki_push_api.py", line 1237, in _on_logging_relation_changed
    self._process_logging_relation_changed(event.relation)
  File "/var/lib/juju/agents/unit-loki-0/charm/lib/charms/loki_k8s/v0/loki_push_api.py", line 1263, in _process_logging_relation_changed
    self._remove_alert_rules_files(self.container)
  File "/var/lib/juju/agents/unit-loki-0/charm/lib/charms/loki_k8s/v0/loki_push_api.py", line 1361, in _remove_alert_rules_files
    files = container.list_files(self._rules_dir)
  File "/var/lib/juju/agents/unit-loki-0/charm/venv/ops/model.py", line 1301, in list_files
    return self._pebble.list_files(path, pattern=pattern, itself=itself)
  File "/var/lib/juju/agents/unit-loki-0/charm/venv/ops/pebble.py", line 1807, in list_files
    resp = self._request('GET', '/v1/files', query)
  File "/var/lib/juju/agents/unit-loki-0/charm/venv/ops/pebble.py", line 1281, in _request
    response = self._request_raw(method, path, query, headers, data)
  File "/var/lib/juju/agents/unit-loki-0/charm/venv/ops/pebble.py", line 1328, in _request_raw
    raise ConnectionError(e.reason)
ops.pebble.ConnectionError: [Errno 2] No such file or directory

Additional context
No response

Closed PR https://github.com/canonical/loki-k8s-operator/pull/132 since fix is moved to #152 .


Don't allow corrections that just void the channel (for multichannel types)

Such corrections should be rejected with "The correction was not saved, as it did not hold any relevant changes".
Make sure API doesn't return channel for multichannel bots.
Further don't pass the channel to the correction interface, so it's not publicly visible anymore.

Actually, making the channel ineditable seems sane to me. I should probably also remove the channel property from the API at some point.


[QA] Application switcher content shows settings element only after it was selected once

Tested using oCIS 1.0.0.-RC5
Go to settings section in order to make it appear in the Application switcher menu. After refreshing the browser, it disappears again

re-tested with local server oCIS version 1.11.0 vs web 4.1.0
is not reproducible


Gas fees on PHI Network

Gas fees are much too high for phi network. transactions can process fast with 2000 wei . 1 gwei is very high for chain and makes it very expensive for users. can we please adjust gas to 2000 wei and not 1 gwei thank you

@Phinetwork in case, shouldn't eth_gasPrice return 1 instead of 2000 (0x7d0)?
curl -H 'accept: application/json' -H 'content-type: application/json' -H 'user-agent: AlphaWallet/395 CFNetwork/1237 Darwin/20.5.0' -H 'accept-language: en-us' --data-binary ' {"method":"eth_gasPrice","params":[],"id":1,"jsonrpc":"2.0"}' --compressed "https://rpc1.phi.network" -s

{"jsonrpc":"2.0","id":1,"result":"0x7d0"}

not sure what you mean. I Just know that chain will process fast with transaction cost of 2000 wei 1gwei is very expensive for the tokenomics. but 2000 wei works to process fast and is appropriate for tokenomics.

I'm sorry I mixed up the 2 gas prices (2000 and 1) when I was writing this comment: https://github.com/AlphaWallet/alpha-wallet-ios/issues/4931#issuecomment-1173310044.
Will fix this. There will be a limitation in the UI though, the gas price used will show up as "~0 PHI". Our gas UI is tailored for gwei :)

thats ok if gas price shows up at 0 gwei would perfer that they have user pay so high gas. will make it so users can practically use with wei so its ok we appreciate the update


Adding PHP8 support in composer.json

Hi there - this seems to work when I run my cypress tests and the PHPUnit tests run too (I had to change one small thing in a test but that should have failed before my changes as well / had nothing to do with my changes, as far as I can see).

Any chance we can get this merged soon?

Any chance we can get this merged soon?


Kinetic.set broken

Kinetic.set stopped working.
doesn't work:
Kinetic.set(self, props: .Rotate(0.25), .Scale(0.4))
works:
Kinetic.animate(self).duration(0).to(.Rotate(0.25), .Scale(0.4)).play()

changing the duration in the function call from 0 to 1 seems to fix it.
change:
public func set(target: NSObject, props: Property...) {
	let tween = Tween(target: target, from: nil, to: props, mode: .To)
	tween.duration(0)
	tween.seek(tween.duration)
}

public func setAll(targets: [NSObject], props: Property...) {
	for (_, item) in targets.enumerate() {
		let tween = Tween(target: item, from: nil, to: props, mode: .To)
		tween.duration(0)
		tween.seek(tween.duration)
	}
}

to:
public func set(target: NSObject, props: Property...) {
	let tween = Tween(target: target, from: nil, to: props, mode: .To)
	tween.duration(1)
	tween.seek(tween.duration)
}

public func setAll(targets: [NSObject], props: Property...) {
	for (_, item) in targets.enumerate() {
		let tween = Tween(target: item, from: nil, to: props, mode: .To)
		tween.duration(1)
		tween.seek(tween.duration)
	}
}

This issue has been corrected, so you don't need to set the duration to 1 anymore. The issue was that the Kinetic.set method wasn't to() with the desired properties before trying to seek to the end of its timeline, updating the properties. The preloader example makes extensive use of this method which is now working properly again.

works! Thanks.


Request is so slow

Hello,
Im using example from steambot and that requests lasts for so long,
SteamCommunity construct -> 10,4723s
Login -> 8,231s
Send Trade offer -> 2,2469s
Get confirmations and accept -> 9,6686s
If you need I can provide code examples but it is almost default example.
Somebody has the same problem?
Or any solution how to solve it?
I've tried different Steam libraries/classes before and they were pretty quickier but accepting trade offer didn't work.
Im running on PHP6 hosting in Slovakia

Has same problem

every request will get the  steamid and sessionid first. if you save them the first time,next time  do not get to go again.will be faster~

@h1100e it should be somehow added into library, not? can you show me any example please? thank you a lot ;)

I think, pull request will be better


StackOverflow when RegExp encounters a very large string [LUCENE-10501]

When RegExp encounters a very large string, it hits a Stack Overflow exception when parsing it.
Simple program to repro:
$ ls
RegExpTest.java       lucene-core-9.1.0.jar
$ cat RegExpTest.java
class RegExpTest {
    public static void main(String[] args) {
        StringBuilder strBuilder = new StringBuilder();
        for (int i = 0; i < 50000; i++) {
            strBuilder.append("a");
        }
        try {
            new org.apache.lucene.util.automaton.RegExp(strBuilder.toString());
        } catch (StackOverflowError e) {
            System.out.println("Stack overflow");
            System.exit(-1);
        }
        System.out.println("Success");
    }
}
$ javac -cp './lucene-core-9.1.0.jar:.' RegExpTest.java
$ java -cp './lucene-core-9.1.0.jar:.' RegExpTest
Stack overflow
$ java -Xss1G -cp './lucene-core-9.1.0.jar:.' RegExpTest
Success

Based on #7218 , this appears to be due to the recursive parsing implementation.

Migrated from LUCENE-10501 by Kartik Ganesh (@kartg), 1 vote

Is this fix expected to be released soon?

it will be released in lucene 9.8
On Wed, Sep 6, 2023, 12:39 thomas-warner @.***> wrote:

Is this fix expected to be released soon?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/lucene/issues/11537#issuecomment-1708984872,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFSB7DBT3OCW56UQFWLXUDXZDGQNANCNFSM6AAAAAA3TRAQHU
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

@zhaih when is lucene 9.8 expected to be released?

There's no fixed schedule, we usually release after some amount of changes
are checked in. IIRC the last release was in July
On Wed, Sep 6, 2023, 13:02 thomas-warner @.***> wrote:

@zhaih https://github.com/zhaih when is lucene 9.8 expected to be
released?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/lucene/issues/11537#issuecomment-1709019677,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFSB7A3DOMMSQRF6CUFOHLXZDJFDANCNFSM6AAAAAA3TRAQHU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Given that the version would include a fix that is tracked as a security vulnerability, can there be some commitment to a timeline? Or possibly cherry-pick to a minor release 9.7.1?

From: Patrick Zhai @.>
Sent: Wednesday, September 6, 2023, 9:05 PM
To: apache/lucene @.>
Cc: Lily Warner @.>; Comment @.>
Subject: Re: [apache/lucene] StackOverflow when RegExp encounters a very large string [LUCENE-10501] (Issue #11537)
[External Email]

There's no fixed schedule, we usually release after some amount of changes
are checked in. IIRC the last release was in July
On Wed, Sep 6, 2023, 13:02 thomas-warner @.***> wrote:

@zhaih <https://github.com/zhaihhttps://github.com/zhaih> when is lucene 9.8 expected to be
released?
—
Reply to this email directly, view it on GitHub
<https://github.com/apache/lucene/issues/11537#issuecomment-1709019677https://github.com/apache/lucene/issues/11537#issuecomment-1709019677>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFSB7A3DOMMSQRF6CUFOHLXZDJFDANCNFSM6AAAAAA3TRAQHUhttps://github.com/notifications/unsubscribe-auth/AEFSB7A3DOMMSQRF6CUFOHLXZDJFDANCNFSM6AAAAAA3TRAQHU>
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHubhttps://github.com/apache/lucene/issues/11537#issuecomment-1709023471, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AONIE7LBKZ2SYEHAUK2L4G3XZDJQ7ANCNFSM6AAAAAA3TRAQHU.
You are receiving this because you commented.Message ID: @.***>

I checked the CHANGES list since last release and seems we have good amount
of commits already, let me start a thread about releasing the next version.
On Wed, Sep 6, 2023 at 1:08 PM Lily @.***> wrote:

Given that the version would include a fix that is tracked as a security
vulnerability, can there be some commitment to a timeline? Or possibly
cherry-pick to a minor release 9.7.1?

From: Patrick Zhai @.>
Sent: Wednesday, September 6, 2023, 9:05 PM
To: apache/lucene @.>
Cc: Lily Warner @.>; Comment @.>
Subject: Re: [apache/lucene] StackOverflow when RegExp encounters a very
large string [LUCENE-10501] (Issue #11537)
[External Email]

There's no fixed schedule, we usually release after some amount of changes
are checked in. IIRC the last release was in July
On Wed, Sep 6, 2023, 13:02 thomas-warner @.***> wrote:

@zhaih <https://github.com/zhaihhttps://github.com/zhaih> when is
lucene 9.8 expected to be
released?
—
Reply to this email directly, view it on GitHub
<https://github.com/apache/lucene/issues/11537#issuecomment-1709019677<
https://github.com/apache/lucene/issues/11537#issuecomment-1709019677>>,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AEFSB7A3DOMMSQRF6CUFOHLXZDJFDANCNFSM6AAAAAA3TRAQHU
<
https://github.com/notifications/unsubscribe-auth/AEFSB7A3DOMMSQRF6CUFOHLXZDJFDANCNFSM6AAAAAA3TRAQHU>>

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub<
https://github.com/apache/lucene/issues/11537#issuecomment-1709023471>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AONIE7LBKZ2SYEHAUK2L4G3XZDJQ7ANCNFSM6AAAAAA3TRAQHU>.
You are receiving this because you commented.Message ID: @.***>
—
Reply to this email directly, view it on GitHub
https://github.com/apache/lucene/issues/11537#issuecomment-1709027590,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFSB7COK6HADSGC6CHM4FLXZDJ43ANCNFSM6AAAAAA3TRAQHU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@zhaih can this fix be released as a patch version of 8.x? Version 9.x is not compatible with elasticsearch which has lucene as a dependency

What is your concern @snow-lily-warner
ES should have been protected against this for a while now: https://github.com/elastic/elasticsearch/pull/84624
And the latest version of ES when released will have the newly released Lucene version, which will have the local change in Lucene.

FWIW: Apache Jackrabbit Oak is stuck with Lucene 4.7.x for the time being. That said, backporting the change to the 4.7.2 source seems to be trivial; see https://github.com/reschke/jackrabbit-oak-lucene/commit/f0c2b60db907f5eb24bd1ec5ed39b6ea28ef60a5.


Add example kustomization to add the plugin to argocd

This should install the latest argocd (HA) and then kustomize it to include the vault-replacer plugin.

Thanks. Looks good.


actions.py

Testing Plan:
GIFs or Screenshots:

@cr4zyafrican did you intend to open this pull request?


Sync aborts file upload

If a sync occurs while the file picker dialog is open, the upload will not take place after the file is chosen.
The same happens for other functions of the New-menu as well - if the menu is open and sync takes place, the menu choice picked afterwards (such as new folder) will not have an effect.
A rather annoying thing when this happens during navigation towards target file.

This issue was fixed on v1.4.0. #300


Add prose between code snippets

When reading this page it was tricky to parse this section because input and output looked the same. I added some text in between the snippets to break up the flow a bit.

Another pattern I've used is to include the output in the same block, but prefix the command with the shell prompt $

Is there a clever bit of CSS or rST we can use so that when people highlight the line to copy&paste it the $ doesn't get copied? That would be the luxury version I think

I'm not aware of anything. Since we're using MyST Parser maybe they'd be willing to add an extension for this use-case?


Map RGB to Depth offline

Required Info

Camera Model
SR300

Firmware Version

Operating System & Version
Ubuntu 14.04

Kernel Version (Linux Only)

Build System
Makefile

Is there a way to map the RGB image to the depth image or the point cloud? I saw the C example for mapping depth to color but the other way seems to be only possible using the synthetic rs::stream::depth_aligned_to_color? Can it be done offline instead?

You can look a the code in the file image.cpp.
Whenever you have a synchronized depth and color image, you can do all the transformations you want offline. Anyway, you  can only start from the depth image in my understanding, whatever you do, this means deprojection to find z,  transformation in other color's frame, projection in color's frame.


Added a few more translations.

Fixed Issue #1
I have added new translations of "screenshot", "goodbye", "recurrent", "prohibited" and "into".

Hey @aharna I think that the translations you add must be unique and general, only one or two of your translations looks like ready to be added.
If you can work it out then it would be great!
Still ping me anytime if you have any questions 😎

@aharna any issues you got?

Yea sure!!
But two see which two were good I will have to see your code again. For that you will have to reopen this PR.


Adds ability to add remote files

I've added the ability to pass in urls to add images/files to the pass.

That was a concern of mine. However, I like the way this library is "on-the-fly" and I feel like that kinda goes against that.
Either way, I appreciate the library :) I only had to regenerate the p12 a million times to get apple to seemingly-magically accept it, but nicely done.