Checking wrong list in query

Describe the bug
The Scheduled rule with GUID 957cb240-f45d-4491-9ba5-93430a3c08be stores the IP as ClientIPOnly, but looks at a nested list [0][0]. At our place, this is constantly wrong, and should only be:

Hopefully this will help others as well - I could not find any entries in our logs where this value actually works. We use this column in a title override, but keep getting blank on the IP.

Hi @bittib010 , Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 25Dec2023. Thanks!

Hi @bittib010, team is still checking on this issue and get back you by - 29-12-2023. Thanks!

Hi @bittib010 ,Could you please share more details on this issue,which solution and what wrong query?

Here is the query: https://github.com/Azure/Azure-Sentinel/blob/e99fa2b06eacbbe3e5865f77b8626ba20919e269/Solutions/Microsoft 365/Analytic Rules/RareOfficeOperations.yaml#L4
And looking at the query, like my original post here, showing the query and where it is looking into nested lists, in our dataset we never get a nested list, and therefore by looking at something that does not exist, we get an empty value:

Therefore we would like to see if changing it to (end of line 4):
  OfficeActivity
  | where Operation in~ ( "Add-MailboxPermission", "Add-MailboxFolderPermission", "Set-Mailbox", "New-ManagementRoleAssignment", "New-InboxRule", "Set-InboxRule", "Set-TransportRule")
  and not(UserId has_any ('NT AUTHORITY\\SYSTEM (Microsoft.Exchange.ServiceHost)', 'NT AUTHORITY\\SYSTEM (w3wp)', 'devilfish-applicationaccount') and Operation in~ ( "Add-MailboxPermission", "Set-Mailbox"))
  | extend ClientIPOnly = tostring(extract_all(@'\[?(::ffff:)?(?P<IPAddress>(\d+\.\d+\.\d+\.\d+)|[^\]]+)\]?', dynamic(["IPAddress"]), ClientIP)[0])
  | extend AccountName = tostring(split(UserId, "@")[0]), AccountUPNSuffix = tostring(split(UserId, "@")[1])

Hi @bittib010 ,I am able to replicate the issue and have only 3 records in our work space,Please find below screen shot for reference

Could you please share sample data in CSV format to (v-muuppugund@microsoft.com),so will be modify the analytic rule and update you

Hi @bittib010 ,Gentle Reminder,,I am able to replicate the issue and have only 3 records in our work space,Please find below screen shot for reference

Could you please share sample data in CSV format to (v-muuppugund@microsoft.com),so will be modify the analytic rule and update you

I'm sorry, im not able to do so in a while. I hoped you would get the same output as we did, but that shows only that there are differences in the data outputting. I'm currently unavailable to produce any dummy data for the next two weeks as I'm logged off main computer.

Hi @bittib010 , Working on the changes ,will be raising PR for the same.

Hi @bittib010, Team is still working on changes, and will raise a PR once it gets completed. Thanks!

Hi @bittib010 , Apologies for the delayed response, its a 1p connector, made the changes tested it, need to push it as don't have permissions as the connector is not reflecting Will update you.

Hi @bittib010 ,just want update,as its 1p connector,we are discussing internally process to push it and will update you once had an update

Hi @bittib010 ,we have defined the process internally and will be working on the PR,will update you once PR is pushed

Hi @bittib010 ,PR has merged,so we are closing the issue.


Update to Kotlin 2.0.20 & Koin to 4.0.0

Hi @mirzemehdi ,
I recently updated my projects to Kotlin 2.0.20 and Koin 4.0.0. And I've faced a compilation issue on iOS, which comes from Koin 4.0.0:
https://github.com/InsertKoinIO/koin/issues/2003
Basically, when updating from Koin 4.0.0-RC1 to 4.0.0, they removed the dependency com.benasher44:uuid to instead use the Kotlin’s standard library UUID.
Since your library is still using Kotlin 2.0.0 and Koin 4.0.0-RC1, you also need to update your library to these versions, so we can keep on using your awesome lib :)

@Tweener thanks for reporting this. For now temporary solution would be to add uuid library into your gradle file, until I release new version with updating koin version
implementation("com.benasher44:uuid:0.8.4"

Thanks a lot @mirzemehdi ! 👍
Hopefully you won't face any issue when updating. When I did it, it went pretty smooth and took my like 5 minutes. 🤞

@Tweener @DmitriSerhienko This is implemented in 1.3.0 version.
Now this error shouldn't occur: "error: KLIB resolver: Could not find "com.benasher44:uuid""

Just tested and I confirm the issue is gone. Thank you @mirzemehdi ! 🙏


[docs]: E4S Deployment on OLCF

Please describe the issue
We should document E4S deployment on OLCF in https://e4s.readthedocs.io/en/latest/deployment.html
According to https://dashboard.e4s.io/ we have multiple installation on Crusher.

I acknowledge this issue. We will work on updating the documentation. There is still some discussion on our installation vs a system installation, but we can definitely describe what we have installed for 22.05 as shown in the dashboard.

Here is a PR adding the requested documentation:

https://github.com/E4S-Project/e4s/pull/84


Ability to launch SQL Lab with database, schema and SQL query pre-populated using URL params or JSON payload

Is your feature request related to a problem? Please describe.
We are using a Data Cataloging tool which allows our users to view available datasets in our data lake. We would like to integrate this tool with Superset. The functionality would allow the user to launch Superset inside SQL Lab view and query the table that they were viewing within the Data Cataloging tool.
Describe the solution you'd like
We would like to be able to pass parameters to
https://ourhost:ourport/superset/sqllab
eg:
https://ourhost:ourport/superset/sqllab?sqlstring=blah

Describe alternatives you've considered
We have had a look at https://github.com/apache/incubator-superset/blob/0.36.0/superset/views/sql_lab.py to see if we can define a separate to overwrite the query editor from the params. We've also looked at the static JS generated for the UI but couldn't see a clear way to do this.

cc: @yousoph @junlincc @Steejay

Now Superset does not seem to generate SQLlab query through URL parameters. But you can use work around to do that.
SavedQueryRestApi.post                  POST       /api/v1/saved_query/

Create a saved query from the above API, then saved post response id to the Data Catalog app
Query this Saved query from http://<hostname>:<port>/superset/sqllab?savedQueryId=<saved id>


yep

i try to compile psych engine and it says You must have a "project.xml" file or specify another valid project file when using the 'test' command but i actually got the project.xml

https://github.com/ShadowMario/FNF-PsychEngine wackhead

:trollface: imagine using kade

no but seriously, you're probably not compiling into the right folder, so you might wanna:
`> D:

cd [your path]
lime test windows
`

that or your project.xml has a issue [or its because its Project.xml, and not project.xml]

[or its because its Project.xml, and not project.xml]

i love case errors :D

[or its because its Project.xml, and not project.xml]

this is why i quit c++


Add modrinth plugins support for paper server-side packs

As above

This wouldn't be that hard to implement - packwiz already supports retrieving plugins from Modrinth and placing them in the right folder, it just needs bukkit/spigot/paper/etc to be added to GetLoaders (and other places like the init command) so that it knows it wants plugins for those servers.

folia support would be great too

This wouldn't be that hard to implement - packwiz already supports retrieving plugins from Modrinth and placing them in the right folder, it just needs bukkit/spigot/paper/etc to be added to GetLoaders (and other places like the init command) so that it knows it wants plugins for those servers.

Is it really this simple?
I might give a bash at it shortly to see if I can get Purpur working


context keyword causes unexpected formatting of the function paramaters

Expected Behavior
All following formattings should be accepted:
    fun test(block: context(Int) () -> Unit = {}) {}

    fun test(
        block: context(Int) () -> Unit = {},
    ) {}

Observed Behavior
ktlint formats both cases as follows:
    fun test(
        block: context(Int)
        () -> Unit = {},
    ) {}

Your Environment

ktlint version: 1.3.1
editorconfig

[*]
charset = utf-8
indent_style = space
indent_size = 4
insert_final_newline = true
max_line_length = 120
trim_trailing_whitespace = true

[*.{kt,kts}]
ktlint_code_style = ktlint_official
ktlint_function_signature_rule_force_multiline_when_parameter_count_greater_or_equal_than = unset

Thanks for reporting. Minimum requirement should be that the TYPE_REFERENCE context(Int) () -> Unit will not be wrapped. If the type has a default value the equals sign should be on the same line as the type reference. The default value itself is allowed to be wrapped, if it does not fit the line.

Agree.


Compression(?) issue

Hi, I have a small but minor issue with your mishiro program. In the previous versions of your program, when I download unity3d meshes, I think they were decompressed/unpacked. But in the newer version of the program all the files seem to be packed/compressed and I'm unable to open the unity3d files in other programs because of it. Is there a way you can make it so the unity3d files are uncompressed like in your previous versions? Thank you so much for reading!

@ankiramania Do you mean the unity3d files downloaded in HOME? I have never changed the download method in recent versions. I think this problem may be caused by game have used a newer unity3d version, so the files on server have some difference with previos.


Remove Haystack code, flag references, index file, and tests from PFC

Elasticsearch7 is live, so we can remove the Haystack code, files, tests and Flag from PFC.
How to test this PR

Run unittest-current and check 100% coverage

tox -e unittest-current paying_for_college
coverage report -m | egrep "Stmts|paying_for_college"

Check out the search page (Docker setup) and make sure search works as expected.
http://localhost:8000/paying-for-college2/understanding-your-financial-aid-offer/api/search-schools.json?q=Harvard

The coverage report indicates that class ElasticSchool (lines 21-27 in test_search.py) isn't being used, so I think that declaration  can be dropped.


[stable/prometehus-blackbox-exporter] Improve configurability.

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No
What this PR does / why we need it:
[stable/prometehus-blackbox-exporter] Improve configurability:

values.yaml:

Add: priorityClassName, podDisruptionBudget, strategy.

templates/deployment.yaml:

Parameterize: strategy.
Add: priorityClassName.

templates/poddisruptionbudget.yaml:

Add: new file.

Which issue this PR fixes
None
Special notes for your reviewer:
None
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @desaintmartin

Thanks!
/ok-to-test

tide Pending — Not mergeable. Needs approved, lgtm labels.

Can you help with this @desaintmartin ?  thanks

Sorry for the noise. Took a moment to get the sign-off right.

/lgtm

We miss a way to disable the PDB if not needed, let me do a PR.


Question: Is it possible to checkout a revision (SHA) instead of tag

Plug 'user/repo1', 'branch_or_tag_or_sha'

(Sorry for the bump, ignore. This is just to help future readers. But imo this ticket should be closed with wontfix label or similar.)
There is however the :PlugSnapshot command documented in the README, for those who haven't read it fully and came here first, like me.

Just in case someone still comes across this issue. This now seems to be resolved , there is an commit option along with branch and tag as described in https://github.com/junegunn/vim-plug#plug-options
Below is an example on how checkout a specific commit (SHA) only :
Plug 'kassio/neoterm', { 'commit': '6389a24c42572020e0978600e632fd90094fe642' }

Just in case someone still comes across this issue. This now seems to be resolved , there is an commit option along with branch and tag as described in https://github.com/junegunn/vim-plug#plug-options
Below is an example on how checkout a specific commit (SHA) only :
Plug 'kassio/neoterm', { 'commit': '6389a24c42572020e0978600e632fd90094fe642' }


Trouble getting the example to work

Hi,
I'm trying to get your example running but I'm running into issues. I've tried deploying the project to an android emulator, it does some quick building but doesn't start the app.
I've also tried porting the code to my app but that was also unsuccessful, my project builds properly but the 'Foo.txt' file is not found when I try to read it.
Any idea what I could be doing wrong?

The project didn't deploy because deploying was disabled in the configuration. After running the Example I'm running into the same issue. System.IO.FileNotFoundException: 'Foo.txt'
@dellis1972 Any idea what could be wrong?
I've tried looking into it myself and so far I was able to confirm that BuildAssetFeature runs and produces a  AssetsFeature.zip that contains the data. However inside the binlog I couldn't find any reference to the zip later so I'm unsure yet how it's supposed to end up in the main project.

If you are trying in debug configuration it might be defaulting to AndroidPackageFormat = apk which will not work.
Try adding
<AndroidPackageFormat>aab</AndroidPackageFormat>
to the Example csproj, see if that helps.

Thanks, that was the last missing piece. It's working now.
I'm also recieving message like this, but currently they don't seem to do any harm:
message : MSB4120: Item 'Assets' definition within target references itself via (qualified or unqualified) metadatum 'Filename'. This can lead to unintended expansion and cross-applying of pre-existing items.
message : MSB4120: Item 'Assets' definition within target references itself via (qualified or unqualified) metadatum 'Extension'. This can lead to unintended expansion and cross-applying of pre-existing items.
message : MSB4120: Item 'Assets' definition within target references itself via (qualified or unqualified) metadatum 'RecursiveDir'. This can lead to unintended expansion and cross-applying of pre-existing items.

can you provide a diagnostic build log?
From the command line do a dotnet build -bl to get an msbuild.binlog file. Zip that up and attach it to this issue. It might be something I need to modify in the targets.

Fix via https://github.com/infinitespace-studios/MauiAndroidAssetPackExample/commit/9cd00fa439a28c9b9ac1908f491a9021d229d9ec.
Just a slight change to the target.


Correct way to save as xls file?

I'm using XLSX.writeFile to save a workbook file. As xlsx file is working fine, when I try to save the file as a xls file (by change the filename to XXX.xls), the saved file cannot be opened by both Excel and Numbers on Mac.
Is there a format issue on xls file? I attached my code below:
const data = [];
data.push(['label1', 'label2']);
data.push(['data1', 'data2']);
const book = XLSX.utils.book_new();
const sheet = XLSX.utils.aoa_to_sheet(data);
XLSX.utils.book_append_sheet(book, sheet, 'sheet1');
XLSX.writeFile(book, `${filename}.xls`);

This is working with Excel:
//const XLSX = require("xlsx"); // uncomment if using nodejs
const filename = "issue1245";
const data = [];
data.push(['label1', 'label2']);
data.push(['data1', 'data2']);
const book = XLSX.utils.book_new();
const sheet = XLSX.utils.aoa_to_sheet(data);
XLSX.utils.book_append_sheet(book, sheet, 'sheet1');
XLSX.writeFile(book, `${filename}.xls`);

Numbers is indeed erroring, but this is a dupe of https://github.com/SheetJS/js-xlsx/issues/1188


Error: Cannot find module 'passport'

installing and using passport is not working. I get an error Error: Cannot find module 'passport' even though it's installed

I just want to use passport to support facebook-passport, but for some reason when I try to use passport itself it will give me an error.
Expected behavior

I just expect to use this package as normal
Actual behavior

Steps to reproduce

I'm using typescript

npm i --save passport
import * as passport from 'passport';
app.use(passport.initialize()); <--- just a simple use like this will produce the error.

// Format code using Markdown code blocks

import * as passport from 'passport';
this.app.use(passport.initialize()); <-- this part throws the error when passport is in use

Environment

Operating System: macOS 11.4 20F71 x86_64
Node version: v12.13.1
passport version<EMAIL_ADDRESS>

Here's a video just to prove it:
https://user-images.githubusercontent.com/19770382/126026443-99d5ee05-963d-46c5-a4da-204e9d37ad2d.mov

Use can use this repo too.
https://github.com/artoodeeto/ggpo-server/tree/feat/facebook-auth
you can just run command npm run dev:docker and check file server.ts that's where the BS is.
Thank you and I really love and support you guys. I appreciate the response.

@artoodeeto
try:

down the docker container
remove the dist folder if created
docker compose build
docker compose up

I was facing this type of issue with docker as well. Maybe this will resolve your problem.

@jatin510  Thanks for responding bro. I did this already. I run docker-compose run --build but no luck I don't have dist folder too.

@artoodeeto  I looked into the issue. Actually, this issue is due to docker (volume).
The docker container is not able to share the data with the host machine.
I am not much familiar with docker and docker compose. Sorry can't help you with that.
But, When you will install packages directly inside the container the package will get installed.   In my case my volume disk space was full. I have to prune everything. Man thank you. I love you bro. remember that. LA with love bro.

For me as a Ubuntu user i fix it by adding sudo to the npm command

Why still not updates on that?


Update Readme.md and add steps to run the project locally

Add the steps to run Django Project locally.
This would help the contributors to set up project on the local system.
Just add the commands to run in the terminal.
The steps should include -

Installing Django in virtual environment.
Installing the dependencies.
Connecting project to MySQL database.
Migrating the project DB.
Create a superuser.
Run the local server.

Can I do this ?
Please assign me under GSSOC'21

Yeah sure you can take up the issue. If you have doubts regarding commands you can ask here
I am assigning the issue to you.

Thanks, @khannakshat7

Which python version is this repo running on?

We are using python 3.6


fix propagation and speed up using numba

Hey,
I think the implementation of the propagation is wrong.
I fixed it and I used numba to speed up the script.
It works better and it is much faster now.
You can still use it without numba if you remove all "@jit(nopython=True)"
Hope it helps

@Gasp34 can you explain what you found to be wrong? also I get an error for even p_size although it is used in the paper.

I don't remember exactly but if you read the original PatchMatch paper and look at the implementation of the propagation in this repo you will see that it is not done correctly.
One good way to see that there is a problem is to test an image again itself and you will see that the offset map is not 0...
Have you tried with my fix ?

i tried both. i can confirm the even p_size happens also without your fix. I didn't do sanity testing but I can confirm I get similar results with your method but considerably faster. thanks!

I think you'll need to make a lot of modification and testing to make it work with even p_size


[Event Request] Codeunit 437 "IC Navigation" -  NavigateToSalesOrderDocument

Dear ALAppExtensions team,
through this issue we would like to request the addition of an event publisher OnNavigateToSalesDocumentOnDocumentTypeCaseElse in Codeunit 437 "IC Navigation" with the following signature:
[IntegrationEvent(false, false)]
local procedure OnNavigateToSalesDocumentOnDocumentTypeCaseElse (DocumentNo: Code[20]; ICDirectionType: Enum "IC Direction Type"; ICPartnerCode: Code[20]; DocumentType: Enum "IC Transaction Document Type"; var OpenDoc: Boolean)
begin
end;
which would be used to add an else branch to case DocumentType in procedure NavigateToSalesDocument(DocumentNo: Code[20]; ICDirectionType: Enum "IC Direction Type"; ICPartnerCode: Code[20]; DocumentType: Enum "IC Transaction Document Type"): Boolean
begin
case DocumentType of
DocumentType::Order:
exit(NavigateToSalesOrderDocument(DocumentNo, ICDirectionType, ICPartnerCode));
DocumentType::Invoice:
exit(NavigateToSalesInvoice(DocumentNo));
//>>>> New >>>>
else begin
OnNavigateToSalesDocumentOnDocumentTypeCaseElse(DocumentNo, ICDirectionType, ICPartnerCode, OpenDoc);
exit(OpenDoc);
end;
//<<<< New <<<<
end;
exit(false);

Thanks in advance.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11415.


Adds initial version of Markdown renderer

Initial version of a Markdown renderer and a Dart syntax highlighter. Some stuff left to do:

Add support for links
Better custom loading of images
Potentially break out the parsed markdown data out of the Markdown widget
API documentation

This needs tests.

I don't think we should include Markdown rendering in the Material Gallery.

Instead, the markdown package itself should have an example/ directory that contains an example of how to use it.


_j.split is not a function

Hi, I have a fatal error aftere update
23 Sep 08:33:06 - [red] Uncaught Exception:
23 Sep 08:33:06 - [error] TypeError: _j.split is not a function
at init. (/home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/build/nodes/Protect.js:233:105)
at Generator.next ()
at /home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/build/nodes/Protect.js:31:71
at new Promise ()
at __awaiter (/home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/build/nodes/Protect.js:27:12)
at Object.handleUpdate (/home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/build/nodes/Protect.js:139:40)
at /home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/build/SharedProtectWebSocket.js:175:22
at Array.forEach ()
at SharedProtectWebSocket.processData (/home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/build/SharedProtectWebSocket.js:173:37)
at WebSocket.emit (node:events:517:28)
at WebSocket.emit (node:domain:489:12)
at Receiver.receiverOnMessage (/home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/node_modules/ws/lib/websocket.js:1220:20)
at Receiver.emit (node:events:517:28)
at Receiver.emit (node:domain:489:12)
at Receiver.dataMessage (/home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/node_modules/ws/lib/receiver.js:569:14)
at Receiver.getData (/home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/node_modules/ws/lib/receiver.js:496:10)
at Receiver.startLoop (/home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/node_modules/ws/lib/receiver.js:167:16)
at Receiver._write (/home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/node_modules/ws/lib/receiver.js:94:10)
at writeOrBuffer (node:internal/streams/writable:392:12)
at _write (node:internal/streams/writable:333:10)
at Receiver.Writable.write (node:internal/streams/writable:337:10)
at TLSSocket.socketOnData (/home/grafana/.node-red/node_modules/node-red-contrib-unifi-os/node_modules/ws/lib/websocket.js:1355:35)

@crxporter Something I can assist to solve this?

What is your nodered version and node version?

Hi,
Nodered version: 4.0.3
Node version: 1.1.0
I did some additional testing.
Screenshot 1: I was using one protect node per camera and select the different event per camera.
Screenshot 2: I've changed this to 1 protect node for all camera's and handle the events in some logic after the protect node. In this last setup, the error is not there (with the same set of camera's).
Screenshot 1:
[cid:7896eaaa-d999-4c39-9d21-fc8a39327ee4]
Screenshot 2:
[cid:220f2055-61d3-453c-a981-60a67d0976f5]

From: crxporter @.>
Sent: Saturday, October 19, 2024 0:07
To: NRCHKB/node-red-contrib-unifi-os @.>
Cc: Stijn Vandenbroucke @.>; Author @.>
Subject: Re: [NRCHKB/node-red-contrib-unifi-os] _j.split is not a function (Issue #84)
What is your nodered version and node version?
—
Reply to this email directly, view it on GitHubhttps://github.com/NRCHKB/node-red-contrib-unifi-os/issues/84#issuecomment-2423305371, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFSISQJZPZB6MKF7FOT6JY3Z4GBA5AVCNFSM6AAAAABOVLYGLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGMYDKMZXGE.
You are receiving this because you authored the thread.Message ID: @.***>

I was looking for nodejs version, too.
Screenshots did not come through.
Interesting that it works as expected with just one node. Let's get @marcus-j-davies attention if he's got a moment to look


Improve snackbars in sample app

Ticket

[00000]

Github Issue

ISSUE-

Description

Change the duratin the snackbars are shown to indefinite.
Add an action button for snackbars that show any error.
Update project param in Circle CI with the new project name in Firebase

Commit message

Improve snackbars in sample app

Screenshot

Testing

[ ] Added unit tests
[ ] Ran unit tests successfully
[ ] Added documentation for public APIs and/or Wiki

          1 Warning

:warning:
The Pull Request title does not follow the convention [00000] PR Title text

  Generated by :no_entry_sign: Danger

          1 Warning

:warning:
The Pull Request title does not follow the convention [00000] PR Title text

  Generated by :no_entry_sign: Danger


refine travis-ci scripts

OK, this project is a complex repo, thus the travis-ci script is actually false here.
I will make it correct.

I fixed the circulate dependency and it can build on jdk8.
But it fails on jdk11 at https://travis-ci.org/github/apache/commons-weaver/jobs/691189806#L7350
So seems I have to put jdk11 into allow failure but there are only two tests and we put 1/2 into allow failure? That is somehow crazy I say.
Well I have no idea about ant, and I think the travis-ci script is correct now, hoping somebody will fix it.


[Release] sdk/resourcemanager/devhub/armdevhub/0.1.0

https://github.com/Azure/sdk-release-request/issues/3198

/check-enforcer override


[Bug] No alert msg on FE when updating application with exception.

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

I can't sure that the case type was known for community because my glance at the 2.0.0 edition preview.

No alert msg on FE when updating application with exception (It only affects the user experience and is not strictly a bug.
May be  design missing  or classical bugs in the current edition but not exception interceptor catch mechanism missing )

A solution to fix the case

After the change:

StreamPark Version
N.A
Java Version
1.8
Flink Version
N.A
Scala Version of Flink
2.12
Error Exception
N.A

Screenshots
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

We need to inform users of more operational  error info, not just the backend record error logs, Welcome to improve this part

@wolfboys Thx. brother~.
I'll paste the docs I sorted out here.
Then try to fix the corresponding lines.
finally Add a mini-section into the community contribute part to describe a rule for Devs & Reviewers.


Fix for issue #19

Remove early return of result to ensure log messages are always evaluated.

@DavidXArnold can you review this PR also?

👍


Update version to 1.0.95-2 on staging

Update version to 1.0.95-2

🚀 Deployed to staging by @OSBotify in version: 1.0.95-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


ihaskell install fails on jupyter 4.5.0 with "Detected Jupyter, but could not parse version number."

I'm trying to create a MacPorts port of IHaskell. See https://github.com/macports/macports-ports/pull/4706
I get a full build up to the point of jupyter --version, then get the error message:
Detected Jupyter, but could not parse version number.

My jupyter --version returns:
jupyter core     : 4.5.0
jupyter-notebook : 5.7.8
qtconsole        : 4.5.1
ipython          : 7.5.0
ipykernel        : 5.1.1
jupyter client   : 5.2.4
jupyter lab      : not installed
nbconvert        : 5.5.0
ipywidgets       : 7.4.2
nbformat         : 4.4.0
traitlets        : 4.3.2

It looks like requirements.txt wants 4.4.0 for jupyter core, but there's a later version now.
Is this the issue?
If so, would it be possible to update to allow version 4.5.0?

This has been addressed by ac478079dcbd6f947bac34bf190ad2f9d1e6891d, please try again and reopen if the issue is not yet fixed.

Thanks you! That worked! But a new issue…

Oh, what is it?


Added MPI-DS

Max Planck Institute for Dynamics and Self-Organization

@shubhamdipt I am sorry, but Max Planck Institute is very well-known research institution, and the official website at http://www.ds.mpg.de confirms that. This repository is for universities and colleges only, because students and teachers are eligible for free educational licenses for JetBrains tools, but not researchers. To get a discount for research institutions please contact<EMAIL_ADDRESS>I am closing the request without merging, please reopen and comment if I am mistaken. Thank you for your understanding!

Hi @philipto , First of all Max Planck Institutes also host students especially PhD students besides Masters and Bachelors. Secondly there are already two MPIs included in the list (https://github.com/JetBrains/swot/tree/master/lib/domains/de/mpg). I agree to the fact that these institutes also have many researchers which is similar to Universities too.


SDL Printing Fails on Schema Directives with Arguments

Hi SPQR team / @kaqqao!
First, I'd like to say thanks for building such an incredible library. It is a really cool and powerful tool.
I am not sure if this bug pertains to just graphql-spqr-spring-boot-starter:1.0.0, graphql-spqr, or even graphql-java as a whole. I am trying to use graphql-java's schemaPrinter with the spqr generated schema:
    @Bean
    public GraphQL graphQL() {
        GraphQL gql =  GraphQL.newGraphQL(graphQLSchema())
        .build();

        SchemaPrinter schemaPrinter = new SchemaPrinter();
        String printedSchema = schemaPrinter.print(gql.getGraphQLSchema());
        System.out.println(printedSchema);

        return gql;
    }

This fails when I include a schema directive with an argument. If this is added, the SDL Printer fails:
@GraphQLDirective(name = "key")
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.TYPE})
public @interface Key {
    String fields() default ""; //However, directives without arguments work. If I remove this line, SDL will print successfully
}

Here is the error I am getting:
Caused by: graphql.AssertException: Internal error: should never happen: unexpected type GraphQLTypeReference{name='String'}
	at graphql.Assert.assertShouldNeverHappen(Assert.java:53)
	at graphql.execution.ValuesResolver.externalValueToLiteral(ValuesResolver.java:292)
	at graphql.execution.ValuesResolver.valueToLiteral(ValuesResolver.java:226)
	at graphql.execution.ValuesResolver.valueToLiteral(ValuesResolver.java:212)
	at graphql.execution.ValuesResolver.valueToLiteral(ValuesResolver.java:197)
	at graphql.schema.idl.SchemaPrinter.printAst(SchemaPrinter.java:719)
	at graphql.schema.idl.SchemaPrinter.directiveString(SchemaPrinter.java:898)
	at graphql.schema.idl.SchemaPrinter.directivesString(SchemaPrinter.java:862)
	at graphql.schema.idl.SchemaPrinter.directivesString(SchemaPrinter.java:832)
	at graphql.schema.idl.SchemaPrinter.directivesString(SchemaPrinter.java:827)
	at graphql.schema.idl.SchemaPrinter.lambda$objectPrinter$8(SchemaPrinter.java:626)
	at graphql.schema.idl.SchemaPrinter.printSchemaElement(SchemaPrinter.java:1013)
	at graphql.schema.idl.SchemaPrinter.print(SchemaPrinter.java:446)

Thanks in advance for your help. I am extremely motivated to solve this problem as it is blocking me from implementing Apollo federation. If I should post this in another repo like graphql-java, or there is anything else I can do, please let me know.

Ugh. graphql-java historically had a ton of issues with leaving type references unresolved,  especially around directives (and it was usually me discovering and fixing them 😇), and this certainly smells like one of those. But, I can't rule out SPQR doing something wrong just yet. I'll have to investigate a bit. I'll try to poke around today.

Btw any chance you can reproduce this with a small example? That would help immensely... But I fear it won't be exactly easy to reproduce at will, as these bugs are all about the order in which types are discovered. So in a different schema it would simply not manifest... Still, it shouldn't be too difficult either.

Thanks so much for looking into this! Really appreciate it. I am currently working on building a smaller sample project so I can share with you.

Hey @kaqqao, I found it was relatively straight forward to reproduce the problem in a basic Springboot 2.7.0 project. Here is the link.
Once again, greatly appreciate your help! Please let me know if there's anything else I can do to support this fix.


fix(tearsheet): slug spacing

Closes #5870
This PR fixes the spacing for the AI Slug when there is no close icon.
Before:

After:

Design concerns:
I do have a concern, the spacing when the close icon is present is different with the slug to be inline with the close icon. Can we get design input on this?
https://github.com/user-attachments/assets/49ffcab6-9aaf-40af-a0c0-3e50580ae812
What did you change?

packages/ibm-products-styles/src/components/Tearsheet/_tearsheet.scss

How did you test and verify your work?
Storybook

Hey @AlexanderMelox , you have the spacing right here for the slug/AI label. The design intent is:

When there is no close button, the slug should be indented inside the container
When there is a close button, the slug icon should be aligned with the close icon.

The close button and the slug have different size and spacing (close is flush with the edge, slug is not) which is why you get that bit of spacing discrepancy.

@davidmenendez Everything is ready


conventionalcommit indicator

for machine readability and to differentiate normal commit messages from conventional commits i suggest that there should be one or more characters at the beginning of the line to indicate a conventional commit.
example:
$fix(gui):spelling error in settings wnidow

Can you elaborate?

the point of a leading character is that it makes conventionalcommits easy to identify for tools and also for users. everyone who has seen one before immediately recognizes it and doesnt have to ponder if the commits just use a similar syntax by accident. it also helps to avoid conflicts if a commit of a project that doesnt support conventional commits just happens to have a commit with a valid syntax and if tools can identify conventional commit by a leading character it can also check for syntax errors. it also spreads the word if people visit a project with conventional commits and ask themselves what the meaning of the commit with same leading character mean and then got to the documentation or faq.

Which tools are you talking about specifically? Have you tried https://github.com/conventional-changelog/conventional-commits-detector?

oh, i didnt know this tool. thanks

It's Ok :)


[VL] Daily Update Velox Version (2024_03_14)

Velox Upstream New Commits:
9aab7cb47 by xiaoxmeng, Fix hash build spill partition calculation discovered by join fuzzer (9071)
0e1b90389 by zky.zhoukeyong, Remove unnecessary check in provide_std_interface in ComplexWriterTypes.h (8669)
96cc5b57c by Kevin Wilfong, Add utility to randomly trigger OOMs at test time and add an option to Aggregation Fuzzer to enable it (9035)
17fc58b08 by Ubuntu, Add various Cuda decoders (9038)
5bdb78714 by Ubuntu, Add Cuda rountrip meter (9037)
9b6935b39 by Ankita Victor, Add bit_length Spark function (8945)
180024a33 by xiaoxmeng, Simplify the row number spill control logic (9057)
58c89fc07 by Jialiang Tan, OrderBy threshold spill deprecate (9059)
0193758e8 by Jialiang Tan, Deprecate threshold based spill in HashAggregation (9058)
81c609ab4 by Wei He, test alternative plans in WindowFuzzer (8359)
cb583e246 by Wei He, Add custom input generator for map_union_sum (8949)
4624bc712 by Daniel Munoz, Back out "ResultOrActions" (9053)
e8d544794 by Daniel Munoz, Back out "Merge actions support" (9052)
cc284c0e7 by Daniel Munoz, Back out "Add non-blocking support for DwrfReader" (9051)
762cd74fe by rui-mo, Optimize CAST(timestamp as varchar) (8385)
d5f1abc35 by Marcus D. Hanwell, Minor updates for building with C++20 enabled (9019)
246c9c06d by xumingming, Clarify documentation for LIKE Presto function (9062)
3ab4f10ca by Ma, Rong, Support year-month interval schema in arrow c_abi (8959)
ee50d7eb9 by Ma, Rong, Add make_timestamp Spark function (8812)
764aebdaf by Masha Basmanova, Add day(interval) Presto function (9054)

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4949_time.csv
log/native_master_03_13_2024_d7ed0844e_time.csv
difference
percentage

q1
35.81
38.81
2.999
108.37%

q2
23.96
24.06
0.109
100.45%

q3
37.18
38.18
1.000
102.69%

q4
36.52
38.49
1.966
105.38%

q5
69.32
69.71
0.390
100.56%

q6
7.49
7.45
-0.038
99.50%

q7
85.63
82.46
-3.177
96.29%

q8
84.69
83.21
-1.479
98.25%

q9
124.79
121.83
-2.960
97.63%

q10
43.70
44.36
0.663
101.52%

q11
20.59
20.90
0.312
101.51%

q12
28.75
28.06
-0.682
97.63%

q13
48.16
46.88
-1.279
97.34%

q14
18.94
21.98
3.042
116.06%

q15
29.23
33.08
3.850
113.17%

q16
14.56
13.84
-0.725
95.02%

q17
101.70
101.80
0.095
100.09%

q18
143.28
141.05
-2.233
98.44%

q19
14.74
15.07
0.326
102.21%

q20
27.95
27.03
-0.922
96.70%

q21
228.84
229.52
0.683
100.30%

q22
13.65
13.86
0.209
101.53%

total
1239.48
1241.63
2.151
100.17%

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4949_time.csv
log/native_master_03_13_2024_d7ed0844e_time.csv
difference
percentage

q1
35.26
38.81
3.549
110.06%

q2
25.56
24.06
-1.495
94.15%

q3
37.02
38.18
1.165
103.15%

q4
38.02
38.49
0.468
101.23%

q5
70.77
69.71
-1.063
98.50%

q6
7.05
7.45
0.406
105.76%

q7
85.88
82.46
-3.425
96.01%

q8
85.21
83.21
-1.998
97.66%

q9
122.76
121.83
-0.925
99.25%

q10
44.38
44.36
-0.021
99.95%

q11
20.22
20.90
0.681
103.37%

q12
28.91
28.06
-0.849
97.06%

q13
48.88
46.88
-2.000
95.91%

q14
19.51
21.98
2.470
112.66%

q15
30.51
33.08
2.568
108.42%

q16
12.84
13.84
0.994
107.74%

q17
101.41
101.80
0.385
100.38%

q18
141.50
141.05
-0.450
99.68%

q19
14.91
15.07
0.156
101.05%

q20
28.98
27.03
-1.952
93.26%

q21
224.49
229.52
5.035
102.24%

q22
13.96
13.86
-0.103
99.26%

total
1238.03
1241.63
3.596
100.29%


Error at Auto Updating Application using  NAppUpdate

when use auto update app every time get bellow error.
Error while trying to install software updates
Could not launch cold update proc

ess.

Can you try and provide more details on this please? there's not much for me to go on here

We have used NAppUpdate.Framework.dll in app and after completion of "BeginPrepareUpdates" methods we are making call to "updManager.ApplyUpdates(true,true,true)" or even we have tried with t wo different overloaded versions of this method. API does download the updates in temp folder and also create backup folder and when it runs the  "updater.exe", it does prompt me for UAC but after that it throws below error:

"Error while trying to install software updates
Could not launch cold update proc"

And noticed that when we move application installation folder from Program files to other location (like Desktop) then except *.exe other files are updated. I also do not see where my apps exe is closed before restart.
Tried your sample app too and getting same results.
I hope it will help you in further debugging..

Our users have also experienced this problem on 23 different machines since we started to log this error.
I do not have a clean reproduction case, but I think it might be related to the UAC settings since it is thrown when NauIpc.LaunchProcessAndSendDto() return null. And it does that if the user does not elevate UAC.
A good step in the right direction would be to not supress the exceptions.

PRs welcome
On Jul 10, 2015 4:26 PM, "Robin Andersson"<EMAIL_ADDRESS>wrote:

Our users have also experienced this problem on 23 different machines
since we started to log this error.
I do not have a clean reproduction case, but I think it might be related
to the UAC settings since it is thrown when
NauIpc.LaunchProcessAndSendDto() return null. And it does that if the
user does not elevate UAC
https://github.com/synhershko/NAppUpdate/blob/bc22bb4909ce5c9fb7ef0c13fdacccf4999b2d24/src/NAppUpdate.Framework/Utils/NauIpc.cs#L113
.
A good step in the right direction would be to not supress the exceptions.
—
Reply to this email directly or view it on GitHub
https://github.com/synhershko/NAppUpdate/issues/54#issuecomment-120410853
.

@synhershko Delivered: https://github.com/synhershko/NAppUpdate/pull/55 :)

I have investigated this issue further - it seems like the ManualResetEvent simply timeout before it manage to connect to the pipe. But why it fails to connect to the pipe is still unknown to me.
Will keep updating my progress at: https://github.com/robinwassen/NAppUpdate2/issues/1

I got to see this problem with my own eyes for the first time, could not debug it but it took approximately 10 seconds before the exception was thrown.
Which leads me into that it is due to a timeout of the ManualResetEvent.
If a timeout occurs the whole Marshal.GetLastWin32Error() part is bypassed and therefore we don't get the error.
Need to redo the error handling so it is done even though it is a ManualResetEvent timeout.

@synhershko I rewrote the Win32 pipe handling with .NET 3.5 way of managing pipes in the branch: https://github.com/synhershko/NAppUpdate/tree/54-timeout-error-handling
In order to do this I bumped up the .NET Framework version from 2.0 to 3.5, but as far as I remember there should be no compatibility issues due to this.
Also uploaded my test app project here: https://storage.googleapis.com/digiexam/temp/ConsoleNamedPipe.zip
Do you have any obvious objections to what I did? I need to do some more thorough testing before I proceed to do a PR.

@robinwassen I'm thinking this is fixed now?

@synhershko This has not been fixed, we hoped that the recent major rewrite of the related code would solve the problem.
Could not launch cold update process
System.TimeoutException: The NamedPipeServerStream timed out waiting for a named pipe connection, but the process has exited with exit code: -2146232576 (System.Runtime.InteropServices.COMException)
 at NAppUpdate.Framework.Utils.NauIpc.LaunchProcessAndSendDto(NauDto dto, ProcessStartInfo processStartInfo, String syncProcessName)
 at NAppUpdate.Framework.UpdateManager.ApplyUpdates(Boolean relaunchApplication, Boolean updaterDoLogging, Boolean updaterShowConsole)

Second exception:
Could not launch cold update process
System.IO.IOException: All pipe instances are busy

 at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
 at System.IO.Pipes.NamedPipeServerStream.Create(String fullPipeName, PipeDirection direction, Int32 maxNumberOfServerInstances, PipeTransmissionMode transmissionMode, PipeOptions options, Int32 inBufferSize, Int32 outBufferSize, PipeAccessRights rights, SECURITY_ATTRIBUTES secAttrs)
 at System.IO.Pipes.NamedPipeServerStream..ctor(String pipeName, PipeDirection direction, Int32 maxNumberOfServerInstances, PipeTransmissionMode transmissionMode, PipeOptions options, Int32 inBufferSize, Int32 outBufferSize, PipeSecurity pipeSecurity, HandleInheritability inheritability, PipeAccessRights additionalAccessRights)
 at System.IO.Pipes.NamedPipeServerStream..ctor(String pipeName, PipeDirection direction, Int32 maxNumberOfServerInstances, PipeTransmissionMode transmissionMode, PipeOptions options)
 at NAppUpdate.Framework.Utils.NauIpc.LaunchProcessAndSendDto(NauDto dto, ProcessStartInfo processStartInfo, String syncProcessName)
 at NAppUpdate.Framework.UpdateManager.ApplyUpdates(Boolean relaunchApplication, Boolean updaterDoLogging, Boolean updaterShowConsole)

We just need to gather some more information about why the updater exits with error code -2146232576 now.

I think we found the root of the problem.
Our application was built using .NET 4.x and it embedded the updater which was built using .NET 3.5. When computers don't have .NET 3.5 installed the updater wont start and the application will crash.
Closing this ticket as: https://github.com/synhershko/NAppUpdate/pull/85 will solve this, just make sure that you include NAppUpdate with the same .NET version as your application.


Investigate Resetting Store for Restart Conversation

Hi,
How to add support for restart conversation in webchat(React).
I have requirment where user can click on clear button then all the conversation should delete and
new conversatoin will start.

Hi @kunal7898, this is currently not a feature built into Web Chat. However, you are welcome to add this feature yourself through creating your own components and applying them to Web Chat. Please take a look at our samples. 10.a.customization-card-components
We do have a tracking issue for a sample that includes a restart button: https://github.com/Microsoft/BotFramework-WebChat/issues/1293. Please feel free to track that issue and add comments you may have there. Thank you!

@kunal7898 - reopening this issue, sorry for the confusion!
We are concerned there may be a bug on resetting the store in Web Chat, which would prevent users from implementing their own restart button. I am reopening this bug and changing the criteria to track investigation of the store issue.
Thanks for filing!

We are using an old way of passing in the store using store props, instead of Provider. This is required for multiple store setup, but it looks like it is buggy.
We should move to the new way of react-redux to pass in a store via ReactReduxContext, and it should fix this issue.
Repro steps

Create a Web Chat Redux store
Create a <ReactWebChat> with the reference of the store
Talk to the bot for a few turns
Create a new Web Chat Redux store
Assign the new store to the existing <ReactWebChat> component

Expected
The transcript should be cleared because the newer store is empty. Also, verify:

The older DirectLineJS (contained in previous store) should be disconnected (all observables are unsubscribed)
Web Chat will talk to the newer DirectLineJS and offline UI will work with it

Actual
The transcript is not empty.

Bumped to<EMAIL_ADDRESS>it fixed an issue about switching store, a.k.a. transcripts not clear after switching store. But there is another bug on react-redux preventing our work, submitted at https://github.com/reduxjs/react-redux/issues/1339.
The react-redux bug is causing action to dispatch to wrong store after switching store. This will prevent us from switching store because apparently all actions are still dispatching to the old store.
Their bug does not repro on react-redux@^7. But moving to that version would require us to bump to<EMAIL_ADDRESS>(with React hooks), which we planned for 4.6 and is a big risk while doing it in 4.5.
I am postponing this bug to 4.6.

Taking a look at the issue you filed above, the team no longer supports version 6. This would be fixed at the same time as https://github.com/microsoft/BotFramework-WebChat/issues/1818

When working on this PR, also do the followings:

Bump react-redux to >= 7.1.0
Bump redux-saga to latest (1.0.5)

This is resolved in the latest build from the master branch. I put together a quick sample that resets the store after the user is inactive for five seconds. Note, when the store is replaced, Web Chat dispatches a DIRECT_LINE/DISCONNECT action so you need to create a new Direct Line connection as well.
Bot Framework Web Chat (master)
function App() {

  const [directLine, setDirectLine] = useState(createDirectLine({}));
  const [store, setStore] = useState();
  const [timer, setTimer] = useState();

  const initConversation = useCallback(() => {
    setStore(createStore(
      {},
      () =>  next => action => {
        if (action.type === 'DIRECT_LINE/INCOMING_ACTIVITY') {
          const { payload: { activity: { from: { role }}}} = action;
          role === 'user' && setTimer(5000);
        }
        return next(action);
      }));

    (async function() {
      const res = await fetch('https://webchat-mockbot.azurewebsites.net/directline/token', { method: 'POST' });
      const { token } = await res.json();

      setDirectLine(createDirectLine({ token }));
    })().catch(error => console.log(error));

  }, [setStore, setDirectLine, setTimer]);

  useEffect(() => {
    initConversation();
  }, []);

  return directLine && (

      <Timer ms={timer} onComplete={initConversation} />
      <ReactWebChat className='chat' directLine={directLine} store={store} />

  )
}

Screen capture

This is resolved in the latest build from the master branch. I put together a quick sample that resets the store after the user is inactive for five seconds. Note, when the store is replaced, Web Chat dispatches a DIRECT_LINE/DISCONNECT action so you need to create a new Direct Line connection as well.
Bot Framework Web Chat (master)
function App() {

  const [directLine, setDirectLine] = useState(createDirectLine({}));
  const [store, setStore] = useState();
  const [timer, setTimer] = useState();

  const initConversation = useCallback(() => {
    setStore(createStore(
      {},
      () =>  next => action => {
        if (action.type === 'DIRECT_LINE/INCOMING_ACTIVITY') {
          const { payload: { activity: { from: { role }}}} = action;
          role === 'user' && setTimer(5000);
        }
        return next(action);
      }));

    (async function() {
      const res = await fetch('https://webchat-mockbot.azurewebsites.net/directline/token', { method: 'POST' });
      const { token } = await res.json();

      setDirectLine(createDirectLine({ token }));
    })().catch(error => console.log(error));

  }, [setStore, setDirectLine, setTimer]);

  useEffect(() => {
    initConversation();
  }, []);

  return directLine && (

      <Timer ms={timer} onComplete={initConversation} />
      <ReactWebChat className='chat' directLine={directLine} store={store} />

  )
}

Screen capture

how to achieve the same on webchat without using react?

@alokraj68 This how to question is better suited for StackOverflow. Please post your question there with the Web Chat and BotFramework tags so the BotFramework Support Team and the community at large can help you work through your issue.

Hi,
Can this sample be implemented in a normal HTML web chat, in the below sample?
https://github.com/microsoft/BotFramework-WebChat/tree/master/samples/01.getting-started/a.full-bundle
If we could can anyone please share the code.
Thanks


Update user documentation

Try to clarify model_format (does not serve as a version)
Try to clarify model_version (it's the version of a configuration)
Try to clarify model_target (not there yet...)
Fix alias examples (external users don't know S3 and telstate separator is unfortunately not '.' 😢 )
Clarify aliases for empty targets (telescope-level models)
Various style and code reference fixes
Try to expand the code example a bit to include fetcher creation

Also, I really don't know what to say about model_target. I was hoping you have some more suggestions :-)

Also, I really don't know what to say about model_target. I was hoping you have some more suggestions :-)

Also, I really don't know what to say about model_target. I was hoping you would have some more suggestions :-)

My suggestion is we see how we end up using it as we introduce more model types, then update the documentation to match reality.

Also, I really don't know what to say about model_target. I was hoping you would have some more suggestions :-)

My suggestion is we see how we end up using it as we introduce more model types, then update the documentation to match reality.

OK, that's sensible, forging ahead!

OK, that's sensible, forging ahead!


[feat] Add GPU operator: sparse_fill_empty_rows and sparse_reshape

Description
Add GPU operator: sparse_fill_empty_rows and sparse_reshape
Fixes # (issue)
Type of change

[ ] Bug fix
[ ] New Tutorial
[ ] Updated or additional documentation
[ ] Additional Testing
[x] New Feature

Checklist:

[ ] I've properly formatted my code according to the guidelines

[ ] By running Black + Flake8
[ ] By running pre-commit hooks

[ ] This PR addresses an already submitted issue for TensorFlow Recommenders Addons
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

LGTM


Update the RTD generated files and the README about how to generate; fix comment format in code

@andrewwhitehead - I updated a comment in a code module that should be checked to be sure I didn't break anything.  Pretty sure not :-).  The rest of this probably has to be just accepted and I'll test on the RTD site to make sure we are happy.

Codecov Report

Merging #307 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   87.36%   87.36%
=======================================
  Files         236      236
  Lines       11074    11074
=======================================
  Hits         9675     9675
  Misses       1399     1399


update: readme and example env

coverage: 67.716%. remained the same
when pulling 82a6a695552b3d733199204f7e1a25e72d1656ec on fix/readme
into f79c7e130f191900b6c1e139dfedcada8474e01b on main.


Fix video playback when filename contains spaces

Summary
When a video file contained spaces or was URI encoded the video player was not able to play the file even if the file actually existed in the the storage, this PR converts the spaces into dashes when saving the file so it can be played.
Also the iOS Share Extension will set the filename as decoded
Ticket Link
https://mattermost.atlassian.net/browse/MM-11640
Device Information
This PR was tested on: iOS 11.4 and Android 7.1

@saturninoabril changes made my friend


update MD_ArenaDefault current pointer in MD_ArenaDefaultPush after allocating new arena

I'm not familiar with this codebase, I was just looking at the arena implementation, so excuse me if this is not correct, but I believe it's intended that the "current" pointer is updated after adding a new arena to the linked list, which would be congruent with MD_ArenaDefaultPopTo behaviour.

I'm having exactly the same confusion. I assume with this change it would be the correct behavior. The default reserve size is 64mb that's large enough that the issue don't usually occur.


staging.yaml under workflows

Scope of changes
Staging items
Type of change

[ ] bug fix
[ ] new feature
[ ] documentation
[x] other (describe)

Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible
Author checklist

[ ] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[ ]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[ ]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #696 (e430072) into main (8c2a659) will decrease coverage by 5.95%.
The diff coverage is n/a.

:exclamation: Current head e430072 differs from pull request most recent head 920715d. Consider uploading reports for the commit 920715d to get more accurate results

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   44.04%   38.08%   -5.96%
==========================================
  Files         575      155     -420
  Lines       17181     2434   -14747
  Branches     1247      618     -629
==========================================
- Hits         7567      927    -6640
+ Misses       8430     1330    -7100
+ Partials     1184      177    -1007

Impacted Files
Coverage Δ

web/gds-user-ui/src/components/ui/Card.tsx

...nents/Section/PasswordResetConfirmaton.stories.tsx

...ateManagement/X509IdentityCertificateInventory.tsx

...ts/SwitchFormControl/SwitchFormControl.stories.tsx

...user-ui/src/components/Sidebar/Sidebar.stories.tsx

web/gds-user-ui/src/constants/trixo.ts

web/gds-user-ui/src/components/ui/Button.tsx

web/gds-user-ui/src/utils/test-utils.tsx

web/gds-user-ui/src/components/Addresses/index.tsx

web/gds-user-ui/src/theme/components/Button.ts

... and 410 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Drift config updates

Pull Request
Short Summary

add missing config funcs
Add ability to update config args form config and profile

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.93%. Comparing base (44bd3e6) to head (16363e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   91.93%   91.93%
=======================================
  Files          12       12
  Lines         533      533
=======================================
  Hits          490      490
  Misses         43       43


UX tables get displayed along with json output on usage of --json flag

I've built a command and Im displaying some data using the table component off Ux (from the library @salesforce/sf-plugins-core), but when I use the --json flag, the json response is output after the table. I'd expect only the json result  and not the table to be printed.
To Reproduce
Steps to reproduce the behavior:

Create a command with a Ux table printing some data on the stdout.
use the command with the -- json flag

Expected behavior
I would expect the output to be just the json data, based on what Im returning in the command class instead of the table + json output.
Additional context
Versions used -
@oclif/core - 2.15.0
@salesforce/sf-plugins-core - 4.0.0

The ux module is not aware of the json flag and so you have to handle it yourself. The Command class has a jsonEnabled() method on it that will return true is json is enabled (either by the flag or env var). I would use that to determine if ux.table should be called.
if (!this.jsonEnabled()) ux.table()


Question: can I get coverage if I have not source code?

I am using karate-demo and using mvn clean test -Pcoverage, then I can get the code coverage of karate-dmo.
But, in fact, we test one http interface which only use ip+port(have not source codes), right? So, we can also get coverage?
Thanks a lot!!!

I am not aware of any way to do this, and this is not in scope for karate. sorry !


Any way to make it adjust to inlay hints

First of all, thank you for this amazing plugin.
I am having a small problem though, I have lsp inlay hints active and this messes up with the plugin. Is there anyway to make it work with inlay hints?
example:

I haven't used inlay hints much at all, but I have just had a look at the API and I think this should be possible.
I should be able to hook the inlay hints and inject the same amount of space into the string.
I will have a play with a PoC later
Thanks for the report, I imagine there are going to be a few cases like this with different configs!

Thanks @luispinto23 that would be great
It seems to work for me, but I don't use inlay hints regularly so it won't get tested much more.
The PR needs actually tests before it can be merged. And Mac CI hasn't been updated to 0.10 yet. So a merge will be pending that anyways

I think I am using the correct version here, please correct me if I am wrong:

It's working correctly when no inlay hints are present:

But when I move to somewhere with inlays it's breaking:

Error  11:26:21 PM msg_show.lua_error Error detected while processing CursorMoved Autocommands for "*": 11:26:21 PM msg_show Error executing lua callback: ...re/nvim/lazy/precognition.nvim/lua/precognition/init.lua:159: attempt to index field 'location' (a nil value) stack traceback: 	...re/nvim/lazy/precognition.nvim/lua/precognition/init.lua:159: in function 'build_virt_line' 	...re/nvim/lazy/precognition.nvim/lua/precognition/init.lua:263: in function 'display_marks' 	...re/nvim/lazy/precognition.nvim/lua/precognition/init.lua:291: in function <...re/nvim/lazy/precognition.nvim/lua/precognition/init.lua:279>
I am not used to debug this kind of things, so please let me know if I can be of any help and I'll try to provide any more info.

Hi @luispinto23
Change the commit line to
branch = "inlay_hints"
You will need to remove that line when the change is merged
I think it should work fine, I have done more on this tonight and it seems to be working well

Thank you to let me know how to point to the right code.
It's working fine!

Is there somewhere we can donate to buy you a beer or a coffee?

Thank you to let me know how to point to the right code.
It's working fine!

Is there somewhere we can donate to buy you a beer or a coffee?

Brilliant
I will try and get the testing strategy fleshed out
I think I will need to mock an lsp so will look into this
Thanks for your assistance @luispinto23
I have my GitHub sponsors set up if you wanted to, but it's really not necessary

I tested this out as well today and lgtm.


Remove dagger (dependency injection library)

I want to remove this library for few reasons:

it seems to be used only to create instance of one class
it adds complexity in library managment
But mostly because I want to merge membrane-webrtc-android  with client-sdk-android. And removing dagger will just simplify all that.

I will fix above comments in new repo: https://github.com/jellyfish-dev/android-client-sdk (created ticket for this)


VSTest@2 task seem only able to run TP v1; need to run multi-targeted test project

Environment

Server - Azure Pipelines

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:
https://dev.azure.com/true-myth/TrueMyth

Agent - Hosted

If using Hosted agent, provide agent queue name: Unsure; I'm using separate Windows (VS2017) and Linux (ubuntu-16.04) jobs

Issue Description
The problem I'm having is that I have a project targeting both net461 and netstandard2.0, and I  need VSTest to execute my test suite for both.  My understanding is that TP v2 is required for this, but I am somehow unable to cause the VSTest@2 task to use TP v2; it seems to only use the v1 executable and ignores the vstestLocation property in the YAML.
https://dev.azure.com/true-myth/TrueMyth/_build/results?buildId=20&view=results
My YAML file can be seen here: https://github.com/true-myth/true-myth-csharp/blob/next/azure-pipelines.yml
How can I ensure that I'm using TPv2, and then also, how can I make the VSTest task run the test suite for all targeted frameworks?

Ok, it looks like I overlooked a property on the task.  I'm using this now:
- task: VSTest@2
  inputs:
    testAssemblyVer2: 'test\TrueMyth.Test\TrueMyth.Test.csproj'
    platform: '$(buildPlatform)'
    configuration: '$(buildConfiguration)'
    vstestLocationMethod: location
    vstestLocation: 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\TestPlatform\vstest.console.exe'

The task now picks up the TP v2 executable as configured, but: it doesn't actually run any tests:

Key line (for searching):
##[warning]No results found to publish.

@aggieben Usually it is not advised to target a test project on netstandard2.0, you can instead target netcoreapp2.0 or netcoreapp2.1. These can then take references to any netstandard project.
Also, netcore projects cannot be run by VsTest task today. This is a limitation which will be fixed in future releases. For them you need to use dotnet task with 'test' command. I will suggest you to use the Windows job to run the net46 tests and the linux job to run netcore tests. If that is not what you want, please explain your scenario and we can guide you.

@prawalagarwal I was somewhat unclear about my project - the project under test targets net461 and netstandard2.0.  The test project itself targets net461 and netcoreapp2.1.
But I'm confused about your suggestion about VSTest.  I did finally get this to work, and VSTest does indeed run the test suite for netcoreapp2.1.  See the latest test run here: https://dev.azure.com/true-myth/TrueMyth/_build/results?buildId=60&view=logs.  It's possible I am misinterpreting the results of the test run, but this looks like it's running on .NET Core:
2018-11-29T22:59:59.8682420Z [command]"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\TestPlatform\vstest.console.exe" D:\a\1\s\test\TrueMyth.Test\bin\Release\netcoreapp2.1\TrueMyth.Test.dll /EnableCodeCoverage /logger:trx "/TestAdapterPath:\"D:\a\1\s\"" /Framework:FrameworkCore10
2018-11-29T22:59:59.9452806Z Microsoft (R) Test Execution Command Line Tool Version 15.8.0
2018-11-29T22:59:59.9452981Z Copyright (c) Microsoft Corporation.  All rights reserved.
2018-11-29T22:59:59.9453046Z
2018-11-29T23:00:00.2172594Z Starting test execution, please wait...
2018-11-29T23:00:00.3103404Z Test run will use DLL(s) built for framework .NETCoreApp,Version=v1.0 and platform X86. Following DLL(s) do not match framework/platform settings.
2018-11-29T23:00:00.3346091Z TrueMyth.Test.dll is built for Framework 2.1 and Platform AnyCPU.
2018-11-29T23:00:00.3346283Z Go to http://go.microsoft.com/fwlink/?LinkID=236877&clcid=0x409 for more details on managing these settings.
2018-11-29T23:00:00.3346386Z
2018-11-29T23:00:00.8644796Z M�i�c�r�o�s�o�f�t� �(�R�)� �C�o�v�e�r�a�g�e� �C�o�l�l�e�c�t�i�o�n� �T�o�o�l� �V�e�r�s�i�o�n� �1�5�.�0�.�3�0�3�1�9�.�0�
2018-11-29T23:00:00.8645609Z �
2018-11-29T23:00:00.8645966Z �
2018-11-29T23:00:00.8646497Z �C�o�p�y�r�i�g�h�t� �(�c�)� �M�i�c�r�o�s�o�f�t� �C�o�r�p�o�r�a�t�i�o�n�.� � �A�l�l� �r�i�g�h�t�s� �r�e�s�e�r�v�e�d�.�
2018-11-29T23:00:00.8646895Z �
2018-11-29T23:00:00.8647260Z �
2018-11-29T23:00:00.8647613Z �
2018-11-29T23:00:00.8647942Z �
2018-11-29T23:00:00.9066474Z �2.2487
2018-11-29T23:00:03.7414962Z [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.0 (64-bit .NET Core 4.6.27019.06)

@aggieben you should run betcoreapp2.1 test and net461 in separate instance of vstest task. Running them together in a single instance of task is not supported today. I saw your build and i see you are running them in different instance of task. This should work

please reopen the issue if you are still facing any issues.

@acesiddhu Is this still not supported? (targeting multiple frameworks in one task)
I have two tests projects, one targeting .NET Framework and one targeting netcoreapp and I'm trying to find a good way to have all tests run even if the first test task/project fails.


README, pre-commit-config: update pip-audit rev

Fixes #326.
Signed-off-by: William Woodruff<EMAIL_ADDRESS>

LGTM! Just curious though, how come it doesn't work for older versions? Does that mean that as soon as we push a new release, it's going to break everyone's pre-commit hooks?

It does, this was just a funny case of the README having a nonexistent version (at least, one that doesn't have a matching GitHub release perhaps?).

Yeah, we never published a 2.1.2 release:


Ensure build timestamp is consistent and set in SBOM

To enable reproducible build testing:

Set consistent nightly build timestamp and filename, consistent with timestamp used by the openjdk make file, thus enabling reproducibility...
Set build timestamp into SBOM, so it's easily available to re-build reproducibly
For reproducible "release" builds, get build timestamp generated by openjdk make file --with-source-date=version logic, so it can be set in SBOM

Related #3245


Challenge 26: tests don't pass if double quotes are used in setMessage

The last test fails with double quotes for the string
setMessage = () => {
    this.setState({ message: "Goodbye!" });
  }

... but passes with single quotes
setMessage = () => {
    this.setState({ message: 'Goodbye!' });
  }

Also, it would be worth mentioning that setMessage doesn't need a variable assignment keyword (var/let/const) since we're using the class syntax.

Ok I've fixed the problem with the test. What do you mean exactly by the last comment on variable assignment?

Normally, function expressions are assigned to variables that get declared with keywords.
const myFunction = function() {};
const myArrowFunction = () => {};

Anyone unfamiliar with the ES6 class syntax may assume this is the case here, as well, but it throws an error and all of the tests fail.


Customize route failure response

Right now, Tide always returns an empty 404 response when there is no route match. This should be customizable.
Possibly blocked by https://github.com/rust-net-web/tide/issues/5, if we want to use the same configuration mechanism for this.

Also note that currently no middleware is applied to this fallback 404 responder. Worth thinking if that's what we want.

@aturon Currently working on this. Thought process is as follows:
We can allow user's to specify a default handler. This function will run if no route match is found. The other thing i'd like to implement is an error handler akin to actix-web's, see here. I think between the two of them, that should give a pretty good start for  handling any kind of failures that can happen during a request :) Let me know what you think!


Making VS Code plugin optional in build

Currently cargo xtask install tries to run npm --version to build VS Code plugin.
In the command line it shows ERROR, however I do not want to install VS Code plugin.
Could you rename that or use explicit arguments what to install?

cagro xtask --server installs only the server.
λ cargo xtask install --help
    Finished dev [unoptimized] target(s) in 0.25s
     Running `target/debug/xtask install --help`
cargo xtask install
Install rust-analyzer server or editor plugin.

USAGE:
    cargo xtask install [FLAGS]

FLAGS:
        --client-code    Install only VS Code plugin
        --server         Install only the language server
        --jemalloc       Use jemalloc for server
    -h, --help           Prints help information


Do not request artwork if not available

Description:
Hopefully this should fix the "flickering" behavior that people are seeing once and for all.
Related issue (if applicable): fixes #6293

Thanks 🐬

You're the best. :D

I hope it works for you too 😊


Issue with Loading Strategy and Configuration Files in Hummingbot for Custom Strategy

have developed a custom strategy for Hummingbot named contract_analyzer. I have created both a configuration file and a template for this strategy, but I am encountering persistent errors when trying to load the strategy. The configuration file is located in /home/hummingbot/conf/strategies/contract_analyzer.yml, and the template file should be located in /home/hummingbot/hummingbot/templates/.
Error:
async_utils - Unhandled error in background task: 'NoneType' object has no attribute 'value' (See log file for stack trace)

In the log, I also get an error regarding the template file not being found:
FileNotFoundError: [Errno 2] No such file or directory: '/home/hummingbot/hummingbot/templates/conf_contract_analyzer_strategy_TEMPLATE.yml'

Provide more details specifically attach the logs, it will be helpful for both cases:

Error 1: Seems like there is some "None" object you are trying to call.
Error 2: File not found, it means strategy template file is not generating.


Simplify test by using Harness get_filesystem_root and add_network

Per discussion with Guillaume, we want to reduce the number of mocks in tests. In particularly, here we can use:

Harness.get_filesystem_root method to make to make the push/pull operations more real and avoid patching Container push/pull/exists
Harness.add_network to avoid patching Model.get_binding

In addition, tighten up the test a fair bit. Instead of exists always returning True, create the specific files we're looking for.
Also assert that vault.unseal() was actually called. It was too easy to break the test and accidentally follow the wrong code path, and the test still succeeded. For example, if you removed the patch_get_binding before, the test would still pass fine, but would be following one of the early returns -- not what the test was trying to test for.
Also pin ops to a version compatible with the latest version to ensure we have the newish features.
Not saying you have to merge this as is, but this is an example of how to 1) tighten up assertions, and 2) use the newish filesystem and network fakes in Harness.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] I have added tests that validate the behaviour of the software
[x] I validated that new and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Oops, the test I actually intended to fix here was the one Guillaume linked me to, test_given_certificates_pushed_when_install_then_certificate_not_pushed_to_workload. Oh well, hopefully this one provides an example you can replicate. :-)

Closing and taking this change part of PR #59


Set default logging to INFO. Sleep before client test.

For high-rate telemetry forwarding, we don't want to print urllib debug messages.
Sleeping will reduce flakiness of client test and spurious build errors.

This PR is trivial and it's been a few days. I'm going to submit. I can send a follow-up PR with changes if need be.


Removal of stopped worker which doesn't dispatch onStop

Hey nice bundle.
My workers will restart on file changes in development to reload the used resource inside the worker.
It looks like the onStop won't get triggered.
To overcome this, I created a command which I can use to clear the workers.
It looks like this:
    $onChange = debounce(static function () {
        run('docker compose stop xxx_worker');
        run ('docker compose exec xxx php bin/console messenger:monitor:purge:worker'); // Custom command as workaround
        run ('docker compose exec xxx php bin/console messenger:monitor:purge --older-than all'); // to only see new messages after reload
        run('docker compose start xxx_worker');
    }, 5000);

#[AsCommand(
    name: 'messenger:monitor:purge:worker',
    description: 'Remove all worker ids from the cache.',
)]
class MessengerMonitorPurgeWorkerCommand extends Command
{
    public function __construct(
        private readonly CacheInterface $cache
    )
    {
        parent::__construct();
    }

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $item = $this->cache->getItem("zenstruck_messenger_monitor.worker_ids");
        $item->set([]);
        $this->cache->save($item);

        return Command::SUCCESS;
    }
}

So basically, it would be nice to have a command for that like mine or any other solution to automatically remove workers which aren't really running.
The command works in my case, but I am sure in other cases, without restarting the workers, they won't register themselves again.

Could you please provide your symfony version and explain what 'docker compose stop xxx_worker' calls.
Does it dispatch WorkerStoppedEvent?

Hey @Chris53897, I might wasn't explicit enough. I especially talking about the scenario in which the WorkerStoppedEvent won't get called. In my case the xxx_worker service container is just a simple php bin/console messenger:consume async -vv. But to be explicit, in my cases the event won't get called as the service will be killed a lot in development, which results in the lose cache objects.


⚠ Jenkins Plugins Artifactory has degraded performance

In 801b28e, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2739 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 97a4266 after 6 hours, 23 minutes.


Add two error codes from RFC 6750

Add two error codes from RFC 6750 and align docstring formatting in that file.

Please rebase.

@thedrow All set.


Add support for the Windows OS

This pull request adds support for running @react-native-community/art with react-native-windows.

I've added commits to add a Windows project to the example app.
This included updating the example to 0.63 as well.

I've added a couple of commits to add a GitHub action to build and run the windows example.


What is 2.5d_factor in preprocessed H3.6M data?

Hi, I looked through LCN and all data processing scripts, but none of them ever mentioned 2.5d-related fields. I wonder how is 2.5d_factor in the pkl file is calculated?

I think it's on their T-PAMI version section 6.2.2. Basically, it's just a normalizing factor between pixel coordinates and the world coordinates.

I think it's on their T-PAMI version section 6.2.2. Basically, it's just a normalizing factor between the pixel coordinates and the world coordinates.

I read through that section, but it actually explains your DataReaderH36M section. I wonder how to obtain that factor, as it does not appear in any code scripts.

I think it's on their T-PAMI version section 6.2.2. Basically, it's just a normalizing factor between the pixel coordinates and the world coordinates.

Hi @Walter0807, I read through that section, but it actually explains your DataReaderH36M. I wonder how to obtain that factor, as it does not appear in any code scripts, thx!

Sorry, it should be in Section 6.2.1 (LCN, PAMI 2020).

The 2.5d factor is the $lambda$ here.

I think it's on their T-PAMI version section 6.2.2. Basically, it's just a normalizing factor between the pixel coordinates and the world coordinates.

Hi @Walter0807, I read through that section, but it actually explains your DataReaderH36M. I wonder how to obtain that factor, as it does not appear in any code scripts, thx!

Sorry, it should be in Section 6.2.1 (LCN, T-PAMI 2020).  The 2.5d factor is the λ here.

Thanks for your reply! I wonder if there is any code related to this part, it's very hard to infer by oneself.

Sorry, I did not implement this part, the processed data was from LCN. If you have the original H36M data, you can estimate the corresponding $\lambda$ as described.

Sorry, I did not implement this part, the processed data was from LCN. If you have the original H36M data, you can estimate the corresponding λ as described.

Thanks for replying! From my understanding, in data processing script of lcn, joint_3d_image is P_p and joint_3d_camera is P_c, which should be root-centered and then used to calculate λ. When I tried using the above approach, the result is not the 2.5d_factor.

Sorry, I did not implement this part, the processed data was from LCN. If you have the original H36M data, you can estimate the corresponding λ as described.

Thanks for replying! From my understanding, in data processing script of lcn, joint_3d_image is P_p and joint_3d_camera is P_c, which should be root-centered and then used to calculate λ. When I tried using the above approach, the result is not the 2.5d_factor.

Is the result close or not? I did not go into the code details of LCN, perhaps you can leave an issue there.

Sorry, I did not implement this part, the processed data was from LCN. If you have the original H36M data, you can estimate the corresponding λ as described.

Thanks for replying! From my understanding, in data processing script of lcn, joint_3d_image is P_p and joint_3d_camera is P_c, which should be root-centered and then used to calculate λ. When I tried using the above approach, the result is not the 2.5d_factor.

Is the result close or not? I did not go into the code details of LCN, perhaps you can leave an issue there.

非常抱歉如此打扰了，我发现他们的repo从来不解答issue才到此处提问。如果按照上述的理解来minimize，λ会在0.2左右（实际上应该是4.6左右）。所以我以为是理解出现问题

Hi, sorry for the confusion. I consulted the LCN authors and here is the update:

Here is the original λ computation: https://github.com/CHUNYUWANG/lcn-pose/blob/master/tools/gendb.py#L85 (used for ICCV 2019 version, fixed bounding box size for normalization).
In the T-PAMI version, they switched to a different computation method (pasted above).
The two versions actually give very similar λ results.
我觉得可能是你算minimize的方式不太一样，可以看一下release版的实现看看是否有帮助。

I think it's on their T-PAMI version section 6.2.2. Basically, it's just a normalizing factor between the pixel coordinates and the world coordinates.

Hi @Walter0807, I read through that section, but it actually explains your DataReaderH36M. I wonder how to obtain that factor, as it does not appear in any code scripts, thx!

Sorry, it should be in Section 6.2.1 (LCN, T-PAMI 2020).  The 2.5d factor is the λ here.

My fault. λ (world to pixel) should be the reciprocal of 2.5d_factor (pixel to world).

Thank you so much for your help! I figured it out now.


Update wokwi-hx711.md to explain return values

Explain 0-2100 and 0-21000 return values, and the limitation to Channel A x128 gain.

Thanks!


Rustup init

Fixes https://github.com/rust-lang-nursery/multirust-rs/issues/255

r=me but travis failure seems legit (rustup-setup.sh wasn't renamed)

Also we gotta figure out how to hide the openssl build logs on travis...

:umbrella: The latest upstream changes (presumably #310) made this pull request unmergeable. Please resolve the merge conflicts.

@bors r=alexcrichton

Merge conflict :(

@bors r=alexcrichton


NEXT-14171 - Add SitemapSalesChannelCriteriaEvent, fixes shopwareBoos…

…tday/platform#300

1. Why is this change necessary?
Some extensions which adds a own sales channel like Shopware Markets needs an event to remove their own sales channel from the sitemap generation
2. What does this change do, exactly?
This change adds an event where extension manufacturers can change the criteria object for loading the sales channel when generation sitemaps.
3. Describe each step to reproduce the issue or behaviour.

Create sales channel which should not be in the sitemap
Run sitemap:generate command

4. Please link to the relevant issues (if any).
#300
5. Checklist

[ ] I have written tests and verified that they fail without my change
[X] I have squashed any insignificant commits
[X] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[X] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

I have created a Testing Installation for this Pull Request. It will be available at https://github.sw6.ovh/instance?number=309 in the next minutes.


53 implement googlelogin component and cognito integration

Overviews of implementation (Scope)

AWS Cognito, Google login function authentication implementation at top page.

Review points

Coding style
Extensibility for future modifications (because we have to complete authenticated function later)

Future Work

#64
#65

@uskayyyyy
Thank you for your detailed review!! I fixed them.
In addition, I created issues for future work. Please take a look at and review them.

@kotaaaa Thank you for updating and creating new issues!
Could you also create a .env.example, please, since this PR first introduces .env.local file?

Added! Please check.


Dividend dispensary

This works tied with the open-ended fundriser. Needs conflict resolution.

Hi,
in an attempt to clean up the current specification, I'm going to close old and outstanding pull requests. Please note, it's tagged as "old idea", so the work is not wasted and we can potentially review it at some point later.
Please feel free to resubmit it as new pull request, if you still think it's a good idea.


remove depFile check,  dependency file is not mandatory in Kubeless runtimes

fixes #202 .
No problems with null depFile (see this).

hi @lorenzo-ange, can you increase the version in the package.json so the change gets released?

hi @andresmgot , package.json version increased :)

thanks!


SubsetWorker: missing try at sample level

needs this one https://github.com/iejMac/video2dataset/blob/af9daf23a729f09edb21c042c04e51a89d38e4e4/video2dataset/workers/download_worker.py#L178

@danielmend


Add map_name to GameInfo

Adds map_name to GameInfo. Will be useful in conjunction with the sc2ai.net bot ladder. My bot specifically needs it to load map specific training data from text files.
I would also suggest changing game_settings_.map_name to game_settings_.map_path to avoid confusion. map_name will almost never match the map filename. For example, the map_name may contain spaces, and does not usually include the .SC2Map file extension.
game_settings_.map_name does not appear to be publicly exposed, so it should be safe to change. There is already an inconsistancy in Coordinator::StartGame. map_path is passed into the function, and map_name is set to it.

Looks good, thanks! Maybe we should expose local_map_path too...


WPS : disconnected from station loop

Hello,
I've asked for some help in the espressif/arduino-esp32 issues, and they proposed me to ask directly in this forum after making some tests.
I've compiled and loaded in my Olimex ESP32 gateway the WPS code from the library (see below) and I see the following feedback in the monitor.
"Starting WPS" and "Station Mode Started" are comming just after the boot and the errors after presssing the WPS button.

Starting WPS
Station Mode Started
[W][WiFiGeneric.cpp:270] _eventCallback(): Reason: 201 - AUTH_FAIL
Disconnected from station, attempting reconnection
[W][WiFiGeneric.cpp:270] _eventCallback(): Reason: 201 - AUTH_FAIL
Disconnected from station, attempting reconnection
[W][WiFiGeneric.cpp:270] _eventCallback(): Reason: 201 - AUTH_FAIL
Disconnected from station, attempting reconnection
[W][WiFiGeneric.cpp:270] _eventCallback(): Reason: 201 - AUTH_FAIL
Disconnected from station, attempting reconnection
...

I made some tests with the following routers with the same result:

Huawei B310s-22
My android phone (Sony Xperia Z3 compact)
And compiled with the two following boards configuration:
Olimex ESP32 gateway
ESP32 Dev Module

Code:
/*
Example Code To Get ESP32 To Connect To A Router Using WPS
===========================================================
This example code provides both Push Button method and Pin
based WPS entry to get your ESP connected to your WiFi router.

Hardware Requirements
========================
ESP32 and a Router having atleast one WPS functionality

This code is under Public Domain License.

Author:
Pranav Cherukupalli<EMAIL_ADDRESS>*/

#include "WiFi.h"
#include "esp_wps.h"

/*
Change the definition of the WPS mode
from WPS_TYPE_PBC to WPS_TYPE_PIN in
the case that you are using pin type
WPS
*/
#define ESP_WPS_MODE WPS_TYPE_PBC

esp_wps_config_t config = WPS_CONFIG_INIT_DEFAULT(ESP_WPS_MODE);

String wpspin2string(uint8_t a[]){
  char wps_pin[9];
  for(int i=0;i<8;i++){
    wps_pin[i] = a[i];
  }
  wps_pin[8] = '\0';
  return (String)wps_pin;
}

void WiFiEvent(WiFiEvent_t event, system_event_info_t info){
  switch(event){
    case SYSTEM_EVENT_STA_START:
    Serial.println("Station Mode Started");
    break;
    case SYSTEM_EVENT_STA_GOT_IP:
    Serial.println("Connected to :" + String(WiFi.SSID()));
    Serial.print("Got IP: ");
    Serial.println(WiFi.localIP());
    break;
    case SYSTEM_EVENT_STA_DISCONNECTED:
    Serial.println("Disconnected from station, attempting reconnection");
    WiFi.reconnect();
    break;
    case SYSTEM_EVENT_STA_WPS_ER_SUCCESS:
    Serial.println("WPS Successfull, stopping WPS and connecting to: " + String(WiFi.SSID()));
    esp_wifi_wps_disable();
    delay(10);
    WiFi.begin();
    break;
    case SYSTEM_EVENT_STA_WPS_ER_FAILED:
    Serial.println("WPS Failed, retrying");
    esp_wifi_wps_disable();
    esp_wifi_wps_enable(&config);
    esp_wifi_wps_start(0);
    break;
    case SYSTEM_EVENT_STA_WPS_ER_TIMEOUT:
    Serial.println("WPS Timedout, retrying");
    esp_wifi_wps_disable();
    esp_wifi_wps_enable(&config);
    esp_wifi_wps_start(0);
    break;
    case SYSTEM_EVENT_STA_WPS_ER_PIN:
    Serial.println("WPS_PIN = " + wpspin2string(info.sta_er_pin.pin_code));
    break;
    default:
    break;
  }
}

void setup(){
  Serial.begin(115200);
  delay(10);

  Serial.println();

  WiFi.onEvent(WiFiEvent);
  WiFi.mode(WIFI_MODE_STA);

  Serial.println("Starting WPS");

  esp_wifi_wps_enable(&config);
  esp_wifi_wps_start(0);
}

void loop(){
  //nothing to do here
}

Thanks is advance for your help
Bertrand

Exactly the same issue in my case:

the same sketch
different board: Node32s
different router: FRITZ!box 7490
Look forward to your support with best regards Peter.

Hi @petervflocke I tried to reproduce the phenomenon with single STA with one AP, but I can create a crash with two STAs do WPS with the AP. So I want to make sure whether you do WPS operation by two STAs at the same time?


touchZoomRotate only disable rotation toggle

From MapBox documentation it is possible to disable rotation when users zoom on mobile through:
map.touchZoomRotate.disableRotation()

But in react-mapbox-gl there's no option to only disable rotation when zooming on mobile. When touchZoomRotate is set to false it disables both zoom and rotate, which makes the option quite redundant.
This is my current factory parameters:
const ReactMap = Mapbox({
	accessToken: process.env.MAPBOX_ACCESS_TOKEN,
	minZoom: 5.75,
	maxZoom: 16.25,
	dragRotate: false,
	doubleClickZoom: false,
	pitchWithRotate: false,
	touchZoomRotate: false
});

bumping this as I'm also looking for a solution to the same problem

Me too. I would like to have an option where I can prevent rotation on a mobile device, but still allow zooming.

I solved this by directly referring to the map:
import React, { useState, useEffect, useRef, useCallback } from "react";

const mapRef = useRef(null);

const onMapLoad = useCallback(()  => {
      const map = mapRef.current.getMap()
      //turn off option to rotate map with SHIFT+Cursor
      map.keyboard.disableRotation()
      map.touchZoomRotate.disableRotation()
  }, []);

...

            <Map mapboxAccessToken={XXXXXXX}
                ref={mapRef}
                initialViewState={{
                  longitude: 13,
                  latitude: 47,
                  zoom: 9.5,
                }}
                onClick={onClick}
                onMouseEnter={onMouseEnter}
                onMouseLeave={onMouseLeave}
                onLoad={onMapLoad}
                mapStyle="mapbox://styles/mapbox/streets-v12"
                touchZoomRotate={true}
                touchPitch={false}
                dragRotate={false}
            >

However, a prop integrated with the package would still be appreciated!

Hey @omattman @gregholst  can we prevent rotation but still allow zooming in map?
I tried setting up touchZoomRotate as false but it prevents both rotation and zooming in map. I want to disable the rotation only.

@anjaliD-syn try these properties, they work for me:
touchZoomRotate={true}
touchPitch={false}
dragRotate={false}

@gregholst Thanks for your reply. I tried your suggestion but no luck :(. With above config it still allows to rotate on mobile screens.

@anjaliD-syn that is strange, for me rotation with fingers is not possible on my mobile phone (Android / Firefox). However, I can't see any other property that seems related. What version of react-map-gl do you use, just trying to find the difference...my package.json says: "react-map-gl": "^7.0.25"


fix: optional params of some ApiDataFactory functions

Motivation/Description of the PR

Description of this PR, which problem it solves
Resolves #issueId (if applicable).

Applicable helpers:

[ ] WebDriver
[ ] Puppeteer
[ ] Nightmare
[ ] REST
[ ] FileHelper
[ ] Appium
[ ] Protractor
[ ] TestCafe
[ ] Playwright

Applicable plugins:

[ ] allure
[ ] autoDelay
[ ] autoLogin
[ ] customLocator
[ ] pauseOnFail
[ ] coverage
[ ] retryFailedStep
[ ] screenshotOnFail
[ ] selenoid
[ ] stepByStepReport
[ ] stepTimeout
[ ] wdio
[ ] subtitles

Type of change

[ ] :fire: Breaking changes
[ ] :rocket: New functionality
[ ] :bug: Bug fix
[ ] :clipboard: Documentation changes/updates
[ ] :hotsprings: Hot fix
[ ] :hammer: Markdown files fix - not related to source code
[ ] :nail_care: Polish code

Checklist:

[ ] Tests have been added
[ ] Documentation has been added (Run npm run docs)
[ ] Lint checking (Run npm run lint)
[ ] Local tests are passed (Run npm test)

@DavertMik do you think you can release a new version of codecept with this fix?