Bug: URLSearchParams as a Fetch API body uses the wrong Content-Type

[Bug]
What
The Fetch API determines the wrong Content-Type header when its body is set to a polyfilled URLSearchParams instance.
Details
This occurs when the following statements are true:

The URLSearchParams object has been polyfilled.
A POST request is made using the Fetch API.
The POST request's body is set to an instance of the polyfilled URLSearchParams object.
The POST request's Content-Type header has NOT been set manually.

Safari on iOS seems to use the polyfilled URLSearchParams, so that's what I've used to debug the issue.
I've created a sample project (https://github.com/tobyaherbert/urlsearchparams-bug) and published it (https://urlsearchparams-bug.nialto.workers.dev) so you can see the problem.
Here are some screenshots of it working as expected (no bugs) in Google Chrome on macOS:

Also working in Safari on macOS:

But not working in MobileSafari on iOS:

I tried https://polyfill.io/v3/polyfill.min.js?version=v0.108.0&features=default,fetch
on Mozilla/5.0 (iPhone; CPU iPhone OS 15_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.1 Mobile/15E148 Safari/604.1.
Then Content-Type is text/plain;charset=UTF-8.
In the case of https://polyfill.io/v3/polyfill.min.js?version=v0.104.0&features=fetch
Content-Type is application/x-ww-wform-urlencoded;charset=UTF-8 as expected.

I was testing in older browsers that actually need the polyfills.
Thank you @en30 for that bit of info.
It seems as if the user agent is handled correctly.
Also tested with :
https://polyfill.io/v3/polyfill.js?version=3.108.0&features=Element.prototype.animate
Mozilla/5.0 (iPhone; CPU iPhone OS 14_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.1 Mobile/15E148 Safari/604.1
No polyfill should be served here : https://github.com/Financial-Times/polyfill-library/blob/v3.108.0/polyfills/WebAnimations/config.toml#L21
@JakeChampion I was pretty sure we fixed this :/
Maybe something went wrong in a release/deploy?

Aside from that URL and fetch polyfills should not break native implementations.
@en30 @tobyaherbert you can add the gated flag as a temporary fix : &flags=gated

I wasn't sure if I should open another issue on user-agent handling.

you can add the gated flag as a temporary fix : &flags=gated

Thank you for the workaround!

@romainmenke Yep, I'll give it a try 👍 Thanks

I think there are 3 separate issues here :

default feature alias includes URL but not fetch. For this feature to work both are required. (@tobyaherbert)
User agent parsing for the polyfill service doesn't seem to detect more modern Safari versions. (only iOS seems affected?)
Some unknown thing is breaking this feature for @en30.

1 and 2 are related, but 1 should be resolved by including fetch in the polyfill url.

@en30 I tried to verify if the URL or fetch polyfill break this feature if the browser has native support. For me it all seems to work.
My steps :

run the polyfill-library test suite for fetch
added a test endpoint that returns the Content-Type
added a test to send a POST request with URLSearchParams to this endpoint
modified the config for both URL and fetch so that the polyfills are served to newer Safari versions (those with native support)

(https://github.com/romainmenke/polyfill-library/pull/71/commits/4c37f51411081ee56bfe81766f595c17a15cbfee)
I tried both the polyfill bundle from the test suite as a hard coded url from the production service (https://polyfill.io/v3/polyfill.min.js?version=3.108.0&features=URL,fetch)
I was unable to to get a failure when both URL and fetch are polyfilled in Safari browsers (iOS and macOS)
Results from CI suite : https://github.com/romainmenke/polyfill-library/runs/4059057445?check_suite_focus=true (IE fails here because I was lazy and kept console.log statements)
Is it possible that you have other polyfills? For example core-js manually or via preset-env.

At this point only the user agent issue is actionable I think, but this should be moved to a new issue.

@romainmenke
Trying to create a minimal reproducible example, I found that the fetch polyfill ignored inferred Content-Type when the headers option is given as object.
So I opened another issue there.
https://github.com/github/fetch/issues/1076


Code release of using RoMa to compute overlap ratios

Dear devs,
I noticed in the paper that RoMA is used to compute overlap ratio between image pairs as a metric. I'm particularly interested in the implementation details of how you calculate the overlap ratio between images. Would it be possible to share this part of the code? Thanks!

Hi, the details of how to compute the image overlap ratio are described in Section A of the paper's appendix. We will release this part of the code soon.


Publish version 1.0 of Open Operations Manifesto

We should aim to finish a prerelease in cw 41/42 (Mid October).
A public launch (v1.0) should be released in cw 48 with a reasonable amount of signing companies and signees.
This epic consists of several sub-issues:

[ ] #1
[ ] #2
[ ] #3
[ ] #4
[ ] #5
[ ] #6
[ ] #7

Let's meet again on 2022-08-31 at 12:05 CEST. Eduard will create a public calendar item.

https://input.osb-alliance.de/p/2022-scs-sig-open-operations


Strips the hash from a URL in a couple of places

R: @addyosmani @gauntface
The discussion in #488 talked about putting as much of the logic as possible inside reusable plugins; some of the logic that was changed in this PR is inside the CacheExpiration plugin.
However, there's no concept of plugins for routing (only for request handlers), and we needed to adjust the routing logic for precached URLs inside of workbox-sw. So that part is just done inline.
Fixes #488

@wibblymat hi hi

PTAL.


[HTTP2] Handle exception scenario while writing contents

Description:
The HttpContents are written asynchronously to the channel at Http2OutboundRespListener and Http2TargetHandler. If there will be any Http2Exception thrown while writing a single HttpContent, it is logged and notified to the listener. But the next HttpContent will be written to the channel eventhough there was an error in previous HttpContent. This should be handled properly.
httpContent -> ctx.channel().eventLoop().execute(() -> {
    try {
        writer.writeOutboundResponse(outboundResponseMsg, httpContent);
    } catch (Http2Exception ex) {
        LOG.error("Failed to send the outbound response : " + ex.getMessage(), ex);
        inboundRequestMsg.getHttpOutboundRespStatusFuture().notifyHttpListener(ex);
    }
})

Suggested Labels (optional):
Component/stdlib
Component/HTTP
Type/Improvement
Suggested Assignees (optional):
@ldclakmal

This is fixed. >> https://github.com/wso2/transport-http/blob/f389ead50eeb1117b0fa5206591c330aa125e650/components/org.wso2.transport.http.netty/src/main/java/org/wso2/transport/http/netty/contractimpl/common/Util.java#L686


add Feature joomla Installation

Issue #40
modifed: cloudboz.yml
modified: group_vars/all.yml
configuration on: /cloudboz/roles/joomla/tasks/main.yml

Please make sure no conflict files @RizqyAlvindra

Have some conflict, you need to git fetch/git pull to make sure all code is newest.


Cors support

Cors support is open/lazy. By default if ANY cors support is configured with no parameters, then you get * and all methods.  However, if you call setters for allowed domain or allowed methods then you must be explicit with all.
This way by simply adding the CorsSupport to the decorator you get a basic development configuration that allows things like Angular and jQuery to 'just work'.
http://chris-mathias.blogspot.com/2016/01/cors-support-in-qbit-rest.html

Sorry it took so long. I missed it.


Add string types

[ ] Date formats: timestamp, mysql date/time/datetime, standard times
[ ] Email, ip, hash formats

how to get involve into this project ?

As the README says, the project is a type and format checker for PHP variables. An enhancement to be made is to add new types of string formats, which should be added to the StringS class


Taskcat not working with AWS SSO

Describe the bug
Taskcat not working with aws sso credentials.
To Reproduce
Steps to reproduce the behavior:
Using an aws sso login, try to run taskcat test run or aws2-wrap --profile default taskcat test run
aws2-wrap is what I use to get most other commands that depend on a traditional credentials file.
Either way, both commands fail with [ERROR  ] : NoCredentialsError Unable to locate credentials
Expected behavior
I would expect taskcat to be able to test my template against my aws account
**Version (Please make sure you are running the latest version of taskcat)

Taskcat Version 0.9.19

With the release of 0.9.0, we made the design decision to not honor credentials that were stored in environment variables. Looking over the documentation for aws2-wrap, it appears that it leverages environment variables as a primary mechanism for credential management.
We're willing to reconsider this in a future release, however in the interim, I see that aws2-wrap has a way to leverage it as an external credential process.
From their readme:

Use the credentials via .aws/config
If you are using a tool that works with normal AWS credentials but doesn't understand the new AWS SSO credentials, another option is to add a profile to .aws/config that calls the aws2-wrap script.
For example, add the following block to .aws/config:
[profile Wrapped]
credential_process = aws2-wrap --process --profile <awsprofilename>

From there, your taskcat config file would look like this:
general:
  auth:
    default: Wrapped

Please let me know what the results are. Thanks

That worked! Thank you for looking into that for me even though it was unrelated to taskcat.

Glad it worked! I'm leaving this open to capture in our documentation.


[17.09] backport fix to get static builds going

To address:

https://github.com/moby/moby/pull/34844 Fix fetching LVM2 sources

cherry-picked git commit moby/moby@a436d8a
$ git cherry-pick -s -x -Xsubtree=components/engine a436d8a

no conflicts with the cherry-pick

getting this going, builds are green


Add .ci.yaml configurations for documentation and packaging in the flutter/flutter repository

Dupe of https://github.com/flutter/flutter/issues/100806


Fixing run compare.sh to be able to find correct configs

Signed-off-by: Kedar Vijay Kulkarni<EMAIL_ADDRESS>Description
I saw recently all of my jobs running into error:

Fixes
This PR fixes the error by cloning github repo, creating soft-links to config dirs.
cc @chaitanyaenr @mffiedler @mohit-sheth

Can one of the admins verify this patch?

Lgtm


How change the css code

Hi,
I can't change the image and the color.
How to do ?
thx

You can either use the LESS files that come with the theme and recompile them into new CSS, or you can go through the CSS files and try to target each color manually and change them. Be aware the the theme by default loads the minified CSS called agency.min.css and if you're making changes to the agency.css file you need to load that one instead in the <head> tag of the page.

Good day, I downloaded startbootstrap-agency-master. gulp task runs well without errors , however gulp.js does not display results on browser.


Remove broken icon

Removes broken icon in resources page:
Before:

After:

Prevents unnatural stretch of xbox img in showcase
Before:

After:

Microsoft Reviewers: Open in CodeFlow

Removes broken icon in resources page

Screenshot of before/after?

Removes broken icon in resources page

Screenshot of before/after?

added to description


Add the support of the DUMP/RESTORE command

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
This issue considers to support the DUMP / RESTORE command.
Solution
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Hi @taiheyp, thanks for your report. Will add it to our community roadmap and update you if have any progress.


Fix the additional-guest-memory-overhead-ratio not synced on the initial installation

Fix the additional-guest-memory-overhead-ratio not synced on the initial installation
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:

The setting additional-guest-memory-overhead-ratio in not synced to kubevirt when the cluster is freshly installed.
Such differences are observed on a newly installed cluster:
settings.harvesterhci.io additional-guest-memory-overhead-ratio -oyaml
apiVersion: harvesterhci.io/v1beta1
default: "1.5"
kind: Setting
metadata:
  creationTimestamp: "2024-10-08T08:54:38Z"
  generation: 1
  name: additional-guest-memory-overhead-ratio
  resourceVersion: "6218"
  uid: 73403dca-f0a3-4c46-a29c-b8c353fe4a1f
status: {}

settings.harvesterhci.io kubeconfig-default-token-ttl-minutes -oyaml
apiVersion: harvesterhci.io/v1beta1
default: "0"
kind: Setting
metadata:
  annotations:
    harvesterhci.io/hash: d14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f
  creationTimestamp: "2024-10-08T08:54:38Z"
  generation: 4
  name: kubeconfig-default-token-ttl-minutes
  resourceVersion: "25686"
  uid: b89ca1aa-d389-497e-ab9a-287540657c5d
status:
  conditions:
  - lastUpdateTime: "2024-10-09T11:37:08Z"
    status: "False"
    type: configured

The handler has some complex mechanisms to deal with different cases:
https://github.com/harvester/harvester/blob/ca2960c777fe878086a2885446f8772cfbafe3c1/pkg/controller/master/setting/handler.go#L97
https://github.com/harvester/harvester/blob/ca2960c777fe878086a2885446f8772cfbafe3c1/pkg/controller/master/setting/handler.go#L109
Solution:

Add this setting to bootstrap list as well, sure it runs even on freshly installed cluster.
Related Issue:
https://github.com/harvester/harvester/issues/5768
Test plan:

Install a new cluster
check additional-guest-memory-overhead-ratio default value is synced to kubevirt

$ kubectl get kubevirt -n harvester-system kubevirt -oyaml | grep overhead -i
    additionalGuestMemoryOverheadRatio: "1.5"

@mergify backport v1.4

Local test:
(1) A newly installed cluster:
settings:
$ kubectl get settings.harvesterhci.io additional-guest-memory-overhead-ratio -oyaml
apiVersion: harvesterhci.io/v1beta1
default: "1.5"
kind: Setting
metadata:
  annotations:
    harvesterhci.io/hash: d14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f
  creationTimestamp: "2024-10-10T10:34:05Z"
  generation: 2
  name: additional-guest-memory-overhead-ratio
  resourceVersion: "5983"
  uid: 1dcb01f6-4c9d-4009-ab8e-ee747640f6b5
status:
  conditions:
  - lastUpdateTime: "2024-10-10T10:34:05Z"
    status: "False"
    type: configured

$ kubectl get kubevirt -n harvester-system kubevirt -oyaml | grep overhead -i
    additionalGuestMemoryOverheadRatio: "1.5"

A new VM:


Can't block interactions

Bug description
When PopochiuCharacter.walk_to_clicked is called, there's no way to block interactions until the action finishes, which causes undesired behaviors.
Steps to reproduce

Create a Hotspot and make the character walk to it when clicked and then say something.
Run the game and click the created Hotspot.
While the character is moving towards the Hotspot, click elsewhere.
The character will move to the last clicked position, and after that will say the dialogue line scripted for the Hotspot.

Expected vs observed behavior
There should be a way to block interactions when PopochiuCharacter.walk_to_clicked is called. Maybe the default behavior should block interactions, or maybe there should be an alternate method like PopochiuCharacter.walk_to_clicked_blocking.
Environment information (please complete):

OS type and version: Windows 11
Godot version: 4.2.1
Plugin version or branch: beta 1

Closed in #172


Dockerize backend

Added Dockerfile.
Updated README with instructions for building and using the new docker image.
Closes #18

I'm testing this, thank you


"UserWarning: Unknown ssh-rsa host key" in junit.xml when testing Vagrant box

When running testinfra --hosts=testinfra --ssh-config=.vagrant/ssh-config testinfra/* --junit-xml junit.xml I get the error UserWarning: Unknown ssh-rsa host key for [<IP_ADDRESS>]:2222: 987c6ae262c2748e47b9c20c4694485a in junit.xml:
<?xml version="1.0" encoding="utf-8"?>
<testsuite errors="0" failures="0" name="pytest" skips="0" tests="2" time="1.006">
    <testcase classname="test" file="test.py" line="0" name="test_hostname_file[testinfra]" time="0.887089014053">
        <system-err>/home/muffl0n/IdeaProjects/ansible-testinfra/venv/local/lib/python2.7/site-packages/paramiko/client.py:580: UserWarning: Unknown ssh-rsa host key for [<IP_ADDRESS>]:2222: 987c6ae262c2748e47b9c20c4694485a
            (key.get_name(), hostname, hexlify(key.get_fingerprint())))
        </system-err>
    </testcase>
    <testcase classname="test" file="test.py" line="4" name="test_dummy_file[testinfra]" time="0.105942964554"/>
</testsuite>

The output is only shown in the file junit.xml not in stdout:
======================================== test session starts =========================================
platform linux2 -- Python 2.7.9, pytest-2.8.2, py-1.4.30, pluggy-0.3.1
rootdir: /home/muffl0n/IdeaProjects/ansible-testinfra/testinfra, inifile:
plugins: testinfra-<IP_ADDRESS>a12
collected 2 items

testinfra/test.py ..

------------- generated xml file: /home/muffl0n/IdeaProjects/ansible-testinfra/junit.xml -------------
====================================== 2 passed in 1.00 seconds =====================================

.vagrant/ssh-config:
Host testinfra
  HostName <IP_ADDRESS>
  User vagrant
  Port 2222
  UserKnownHostsFile /dev/null
  StrictHostKeyChecking no
  PasswordAuthentication no
  IdentityFile /home/muffl0n/.vagrant.d/insecure_private_key
  IdentitiesOnly yes
  LogLevel FATAL

So it seems like StrictHostKeyChecking is ignored when calling paramiko.
I installed testinfra from git with pip install 'git+https://github.com/philpep/testinfra@master#egg=testinfra'
Other dependencies:
argparse==1.2.1
ecdsa==0.13
paramiko==1.15.3
py==1.4.30
pycrypto==2.6.1
pytest==2.8.2
six==1.10.0
testinfra==<IP_ADDRESS>a12
wsgiref==0.1.2

I have set up an proof of concept for testing role provision with Ansible and Vagrant here: https://github.com/muffl0n/ansible-testinfra. You can see the error when running that poc.

Yes without the -s option, pytest (thus testinfra) does not show stdout/stderr while running tests.
The paramiko backend just read and use Hostname, User, Port and IdentityFile from the ssh-config.
And there is also:
client = paramiko.SSHClient()
client.set_missing_host_key_policy(paramiko.WarningPolicy())

Maybe we could use the paramiko.client.AutoAddPolicy here, but I'm not sure it's a good idea yet...
Btw, your ansible-testinfra POC is nice. Maybe you will be interested by my example https://github.com/philpep/test-driven-infrastructure-example (including vagrant, ansible, travis-ci and testinfra).

Thanks for your quick response!
I played around a bit with the code and came up with PR #29. I agree with you that adding the host key is not the right way. But when connecting with paramiko the setting StrictHostKeyChecking no should be obeyed. Exactly the same way it is obeyed when you are connecting with vagrant ssh.
So I added IgnorePolicy that just silently ignores the missing host key.
What do you think?


Turn process classes into callables (unit-testing)

From discussion in #49, one big limitation of using classes to define model processes is that these are not easy to test.
One solution to this issue would be to programmatically create a callable from a process class. This should be relatively easy to implement.
For example, considering this process class
@xs.process
class MyProcess(object):
    in_var1 = xs.variable(intent='in', default=0)
    in_var2 = xs.variable(intent='in', default='a')

    out_var1 = xs.variable(intent='out')
    out_var2 = xs.variable(intent='out')

    # simulation runtime methods
    def run_step(self):
        # ...

there would be a xs.process_to_func helper
my_process = xs.process_to_func(MyProcess)

such that my_process is a callable equivalent to
def my_process(in_var1=0, in_var2='a'):
    # execute runtime code in class MyProcess...

    return (out_var1, out_var2)    # or use a dict instead

Regarding the implementation details, my_process would actually correspond to a callable class that encapsulates:

the creation of a minimal model based only on MyProcess
the creation of a basic store for the simulation data
the execution of one simulation (go through the execution of runtime methods of MyProcess)

We could also programmatically add the docstrings of my_process.

Just a quick thought:
inout variables can be supported when using functions.
For instance, the function
def f(a):
    a += 1
    return a

has an inout parameter.

Yes, I haven't considered all cases (e.g., on-demand and/or group variables) yet in my proposition above, but for inout variables this is indeed quite straightforward, they should be added as both input arguments and returned values.
I should also note here that the generated callables are not intended to be added as processes in a model (we could just use the process classes for that). As we discussed in #49, programmatically convert any callable to a process (i.e., MyProcess = xs.func_to_process(my_process)) would be very handy too! In the later case, inout variables do not always need to be returned by the callable, it could be mutable inputs such as lists or numpy arrays.


Bug in BoxBlur shader?

BoxBlur.swift, lines 35-36:
shaderString += "blurCoordinates[\((currentOptimizedOffset * 2) + 1)] = inputTextureCoordinate.xy + singleStepOffset * \(optimizedOffset);\n"
shaderString += "blurCoordinates[\((currentOptimizedOffset * 2) + 2)] = inputTextureCoordinate.xy + singleStepOffset * \(optimizedOffset);\n"

Shouldn't the 2nd offset be negative?

@BradLarson if you confirm I can prepare a pull request :)

So sorry it took so long to get back to you on this, but you're right, I did mistakenly copy the wrong line there. This should be fixed in the latest commit.
Thanks for pointing this out.


Vulnerability roundup 92: solr-8.4.1: 1 advisory [8.8]

search, files

[ ] CVE-2020-13941 CVSSv3=8.8 (nixos-20.03)

Scanned versions: nixos-20.03: 925ae0dee63.
Cc @aanderse
Cc @domenkozar

Merged in


Not able to get the prediction for Test.csv

Hi
I am just trying to run the code to get the predictions for the test.csv. i am trying with the pre trained model at https://transformer-models.s3.amazonaws.com/mimiciii_bert_10e_128b.zip.
While running code I am getting an error as AttributeError: 'BertConfig' object has no attribute 'tags'
Screen shot of my scree is as below

the pretrained model is pretrained on MLM, not on RE so it is not an out-of-box RE model for inference.
You need to first train a RE model on training data during which the tags and other configs will be generated based on the dataset and parameters, then you can run inference.


Doesn't work with Automatic Proxy Configuration

My setup uses Automatic Proxy Configuration rather than manually provisioning the proxy addresses in System Preferences. The plugin doesn't manage to populate http_proxy out of that.

PAC file is technically a JavaScript code. And I won't implement a JS engine from zsh/bash. So no.


Refreshing facets when text filter is created

During creation of text filter widget, there is no text, so no need to process/refresh facet(slow when working with lots of data).

The view is going to get refreshed on a per-character basis, so if it's slow initializing, it's going to be very slow as you try to use it.

My bad, this is about avoiding a refresh of the facets themselves, not of the grid, so the two are actually different.


Fixing TextEditing controller Issues and other Minor Issues in Complete profile Page

please Assign this issue to me under GSSoc'23 Contributor Program

please Assign this issue to me under GSSoc'23 Contributor Program

Kindly specify the issues with the file name in detail to get it assigned

in complete_profile.dart , two different fields have same controller.
we can go back to complete profile page after completing onboarding from homescreen , which should not happen.

Hey, can you please assign this issue to me
.

Hey, can you please assign this issue to me .

ok go ahead

Would like to work on this issue can you please assign me this issue? @m0hit-kumar

Would like to work on this issue can you please assign me this issue? @m0hit-kumar

its already been assigned go ahead with some other issues you find in the project that is not been assigned yet


Update CRDs to support k8s 1.18

What does this PR do?
Updates CRDs to workaround issue https://github.com/eclipse/che/issues/16791
Adds a script that does the required patch, depending on yq. This script is executed during make generate.
This PR is broken into three commits

76059d3 is a no-op formatting change -- I ran the existing CRDs through yq to make the formatting consistent and avoid spurious changes (in short, yq formats yaml differently than operator-sdk
121ef2b adds script patch/patch_crds.sh which will add protocol to the list of required fields in containerPorts
b618f6b regenerates CRDs and runs the script (make generate)

What issues does this PR fix or reference?
Workaround for https://github.com/eclipse/che/issues/16791
Is it tested? How?
Tested applying CRDs to minikube with kubernetes 1.18. Could not test full deployment/workspace start as my minikube network is borked for some reason.

Tested workspace starts on minikube (k8s 1.18), found no issues.


Restore api.flickr.com URLs and 'flickr.'... methods

See https://github.com/enyojs/enyo-docs/issues/27
and
http://forums.enyojs.com/discussion/2637/error-on-tutorial-building-a-moonstone-app

Thank you!  Really appreciate the PR.


[RELEASE] Data Prepper 1.2.0 Maven artifacts to Maven Central

Is your feature request related to a problem? Please describe
The Data Prepper team plans to release a Data Prepper artifact to Maven Central.
Planned release date: TBD. After Dec 2, 2021.
Maven Group Id: org.opensearch.dataprepper
Describe the solution you'd like
We discussed this with @peterzhuamazon . We are currently able to publish Data Prepper artifacts to a local Maven repository. We understand that the build automation will take those artifacts, sign them, and perform the upload the Sonatype staging repository.
Describe alternatives you've considered
This is related to #1106. The release of the Maven artifacts can come after the Docker release.
The Data Prepper work to support this effort is tracked at:
https://github.com/opensearch-project/data-prepper/issues/421
Additional context
No response

We did not release Data Prepper 1.2.0 as an archive. Data Prepper started supporting archives in 1.2.1. And now 1.3.0 has an archive as well.
This issue is obsolete.


Updating the scripts to only execute when they are called directly.

In their current state, the scripts are cannot be imported without being immediately run. This change allows scripts to be imported and run directly. This change not only useful for creating custom script packages that wrap react-scripts, but is also a start toward making the scripts themselves testable.
const buildReact = require('react-scripts/scripts/build');

buildReact();

It would be nice to add the ability to pass options or custom config to the scripts, but I wanted to open this PR first and see where the discussion leads.

The diff is messy, but it's simply wrapping blocks in function main() {...}, exporting the function, and calling it if the script is called directly.
See: https://nodejs.org/docs/latest/api/all.html#modules_accessing_the_main_module

Or just ignore white-space: https://github.com/facebookincubator/create-react-app/pull/1814/files?w=1

I'm not opposed to this, but it'll need more work, e.g. to remove all process.exits and consolidate them. We'll also need some integration tests specifically for this.


Add smallDisplayMode support to Gpx download dialogue

This is now done in CSS using media queries for #Gpx


Admin Conditional Groups not disabling children required or unique

Link to reproduction
https://github.com/ghardin1314/payload/pull/1
Describe the Bug
In previous versions of payload, when setting a group with a conditional statement, that conditional statement would also apply to all child fields. This means you could make a child text field with unique or required with no issues. This behavior seems to have changed in new versions of Payload
To Reproduce
Create a new Post with postType of external. The first one should be created no problem. When creating a second Post with postType of external you should get the following error:
The following field is invalid: internalProps.slug
Payload Version
v2.0.10
Adapters and Plugins
db-mongo

After further testing it seems like its just unique that causes an issue. required does seem to work as expected


os-igmp-proxy - crash with 18.7.7 / igmpproxy not working

I am running OPNsense 18.7.7 with os-igmp-proxy-1.3_1 for IPTV service.
The plugin was already running with 18.7.7 but since today i got a problem notification in the dashboard ("Unfortunately we have detected at least one programming bug.").
Service is no longer working and cannot be restarted.
Maybe it is because of the patch in 18.7.6 ( interfaces: replace get_configured_interface_list() usage).
PHP errors:
[18-Nov-2018 20:08:19 Europe/Berlin] PHP Fatal error:  Uncaught Error: Call to undefined function get_configured_interface_list() in /usr/local/etc/inc/plugins.inc.d/igmpproxy.inc:80
Stack trace:
#0 /usr/local/etc/inc/plugins.inc(213): igmpproxy_configure_do(true)
#1 /usr/local/etc/rc.bootup(118): plugins_configure('bootup', true)
#2 {main}
thrown in /usr/local/etc/inc/plugins.inc.d/igmpproxy.inc on line 80
[18-Nov-2018 20:10:04 Europe/Berlin] PHP Fatal error:  Uncaught Error: Call to undefined function get_configured_interface_list() in /usr/local/etc/inc/plugins.inc.d/igmpproxy.inc:80
Stack trace:
#0 /usr/local/etc/inc/services.inc(1963): igmpproxy_configure_do()
#1 /usr/local/www/status_services.php(45): service_control_start('igmpproxy', Array)
#2 {main}
thrown in /usr/local/etc/inc/plugins.inc.d/igmpproxy.inc on line 80
[18-Nov-2018 20:10:44 Europe/Berlin] PHP Fatal error:  Uncaught Error: Call to undefined function get_configured_interface_list() in /usr/local/etc/inc/plugins.inc.d/igmpproxy.inc:80
Stack trace:
#0 /usr/local/etc/inc/services.inc(1963): igmpproxy_configure_do()
#1 /usr/local/www/status_services.php(45): service_control_start('igmpproxy', Array)
#2 {main}
thrown in /usr/local/etc/inc/plugins.inc.d/igmpproxy.inc on line 80
[18-Nov-2018 20:10:54 Europe/Berlin] PHP Fatal error:  Uncaught Error: Call to undefined function get_configured_interface_list() in /usr/local/etc/inc/plugins.inc.d/igmpproxy.inc:80
Stack trace:
#0 /usr/local/etc/inc/services.inc(1963): igmpproxy_configure_do()
#1 /usr/local/www/status_services.php(45): service_control_start('igmpproxy', Array)
#2 {main}
thrown in /usr/local/etc/inc/plugins.inc.d/igmpproxy.inc on line 80
[18-Nov-2018 20:11:16 Europe/Berlin] PHP Fatal error:  Uncaught Error: Call to undefined function get_configured_interface_list() in /usr/local/etc/inc/plugins.inc.d/igmpproxy.inc:80
Stack trace:
#0 /usr/local/etc/inc/services.inc(1963): igmpproxy_configure_do()
#1 /usr/local/www/status_services.php(45): service_control_start('igmpproxy', Array)
#2 {main}
thrown in /usr/local/etc/inc/plugins.inc.d/igmpproxy.inc on line 80
Kind regards!

@rx-tx hi there, reinstalling the plugin should fix it. I forgot to bump the revision so it wasn't updated with 18.7.x when it should have. Will fix for 18.7.8. :)

See https://github.com/opnsense/plugins/commit/6b6c0d0 -- please close if that was indeed the issue.

@fichtner: Re-installhing the plugin helped. Thanks a lot for your fast support :)

super, thanks! 18.7.8 is planned for Thursday to fix it automatically on update for everyone else. :)


Fix #2357: Implement printing for ir.PropertyDef

Review by @sjrd

That's all.

Updated

LGTM

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3104/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4030/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3103/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4029/
Test PASSed.


New Features systems

The different feature computations now have their own types, namely
FeaturesAll
FeaturesAtoms
FeaturesPairs

and there is the FeaturesRandomPairs constructor for FeaturesPairs which selects n random features amongst the list

#fixed in 1b084f29ce0a4049973268a036ae342978425d79


Update vault structure macros to work with composite primary keys

Update vault structure macros (excluding PIT and Bridge) to work with composite primary keys.
AB#1937

Fantastic work Tim!!! Will review over the next few days. Thank you.

@DVAlexHiggs I can't get the Hub integration tests to pass. I have tried running them twice now and both times they have been cancelled after 60 minutes. Is it possible to increase the timeout for these, and also for links, please?

@DVAlexHiggs I can't get the Hub integration tests to pass. I have tried running them twice now and both times they have been cancelled after 60 minutes. Is it possible to increase the timeout for these, and also for links, please?

We can't increase timeout for the free version of Azure Pipelines. This is one of the many reasons we have split the tests into groups, so that the group of tests run in under 60 minutes. Each group runs in a single process which must be under 60 minutes.
The workaround for now would be to make new test subtypes and update the pipeline jobs and grouping dictionary accordingly.

@DVAlexHiggs I can't get the Hub integration tests to pass. I have tried running them twice now and both times they have been cancelled after 60 minutes. Is it possible to increase the timeout for these, and also for links, please?

We can't increase timeout for the free version of Azure Pipelines. This is one of the many reasons we have split the tests into groups, so that the group of tests run in under 60 minutes. Each group runs in a single process which must be under 60 minutes.
The workaround for now would be to make new test subtypes and update the pipeline jobs and grouping dictionary accordingly.

OK, I'll have a go at that, thanks.


merge from template-github-action

.github/workflows/ci.yml

chore(deps): add 22.4.0 remove 22.3.0 (jobs.test-node.strategy.matrix.node-version)
chore: add 22.4.0 (jobs.release.steps.with.node-version)

.github/workflows/codeql_analysis.yml

chore: add 22.4.0 (jobs.analyze.steps.with.node-version)

.github/workflows/update_package_lock.yml

chore(deps): add 22.4.0 remove 20.15.0 (jobs.update_package_lock.strategy.matrix.node-version)

.github/workflows/update_readme_api.yml

chore: add 22.4.0 (jobs.update_readme_api.steps.with.node-version)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.197%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
392

Relevant Lines:
411

💛  - Coveralls


Fix native includes

Redoes #7057 in a way that doesn't break the closed source world.

@dotnet-bot test OSX10.12 Debug and CoreFX tests please
@dotnet-bot test OSX10.12 Release please


[Feature request] Full file path in error messages

I am compiling a project with the -i src/ flag passed to RGBASM. I have an error in file src/engine/studio_screen.asm, which is included from src/engine.asm as INCLUDE "engine/studio_screen.asm".
RGBASM outputs the following line: ERROR: src/engine.asm(6) -> engine/studio_screen.asm(20): (error description).
My request is for RGBASM to instead output ERROR: src/engine.asm(6) -> src/engine/studio_screen.asm(20):
Upsides:

Removes ambiguity as to which file was compiled, useful if you have a large project and you somehow made two files under the same name
Improves analysis from external tools (I just discussed with the maintainer of the VS Code extension)

Downsides:

Breaks compatibility with any tools using the old syntax (although I'm not that sure any exist). Guess a flag could be used.

I don't think we should worry about compatibility in this case, to be honest...


(Type 61) Credit Record

adding recode type 61 (credit record)

Thanks @mfdeveloper508! I'll get this reviewed asap.
For the failed check, you can run make check locally before pushing your changes to run the same linters and the Go tests.

Codecov Report

Merging #247 (ff25629) into master (3c6d85e) will decrease coverage by 0.19%.
The diff coverage is 80.62%.

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   88.03%   87.84%   -0.20%
==========================================
  Files          35       36       +1
  Lines        4864     4993     +129
==========================================
+ Hits         4282     4386     +104
- Misses        384      402      +18
- Partials      198      205       +7

Thanks for your work on this @mfdeveloper508. This will be ready to merge once that ECEInstitutionItemSequenceNumber validation is added.

Shouldnt R61 be added to: https://moov-io.github.io/imagecashletter/file-structure/


Emotes/facial expressions UI accessible without opening character panel

Describe the bug
The emotes and facial expressions UI is accessible from the main screen without opening the character panel, just as we hover over to the top left corner.
To Reproduce
Steps to reproduce the behavior:

Hover your mouse over the top left corner, just above the avatar icon UI.

Expected behavior
This shouldn't happen. The emotes and facial expressions UI should be accessible from the character panel only.
Screenshots
https://user-images.githubusercontent.com/35926530/184640586-e87064d8-69c4-4dda-a06f-df7e88ae648c.mp4

Not happening anymore


[docs] Remove duplicate font icons instruction

The two examples given for installing the font icons are identical, so this removes the "JSX" example.

@hubgit It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!


How to upload only changed files?

Hi,
I have a shell script for the purpose of deployment. In that script after 'git pull' command I need to upload only the modified and new files to s3. How can I pass the list of files from 'git pull' command as an argument?

grunt-aws-s3 will only upload the new and/or different files to your bucket if you enable the differential option. It will work out what's different based on what's already uploaded on the bucket using MD5 hashes. You don't need to pass the list of the files that have been modified, rather just target the directories you want to upload and let grunt-aws-s3 do the rest.
Have a look at the documentation and examples to see how to enable differential in the options: https://github.com/MathieuLoutre/grunt-aws-s3#usage-examples

This still checks for each file whether or not it has been changed. This does not serve the purpose. Idea is not to hit the s3 server unnecessarily.

The call is very cheap. It's a single call for 1000 objects. So wether you have 10 or 500 objects, it's the same cost and is done with a single request. I guess if you have more than 10 000 files it can be interesting to bypass the check. However, we would still need to have a changeset/manifest of some kind that's generated by another task and feed it into this one which isn't practical at all. And even if you had that you could feed it to your grunt config and just target the right files directly so this task is independent from manifest formats.

Thank you for the info. I will try to find a solution and update. :)

Closing for now. Feel free to re-open if you found something :)


perf: selectively enable precompilation

This is an initial performance test on Linux. TODO:

[ ] test on macOS and Windows as well
[ ] adapt caching

!bench

We are trading 16s of native compilation and linking for 133s in total (task-clock) speedup, that's not a bad start

!bench

diff for ToAdditive only: http://speedcenter.informatik.kit.edu/mathlib4/compare/d87e2746-16d1-48a0-86a5-44d1ffec19f3/to/072b193d-ec23-4412-992c-4b86f3f6c83a - +85s compiling and linking, -554s task-clock total

At this point, I think it makes sense to tackle the fundamental TODOs mentioned above and then explore further precompilation in follow-up PRs. Are there any people interested in testing macOS (M1/x64?) or Windows? It could be as simple as checking out this PR and then running
lake clean && time lake build
git checkout 04155008c1bd958624d2184e1bd1f5a1cbdff452  # PR base commit
lake clean && time lake build

@Kha A potential style suggestion: You can set moreLeanArgs on the package to set arguments on all the package's targets e.g.,
package mathlib where
  moreLeanArgs := #[
    "-DwarningAsError=true",
    "-Dpp.unicode.fun=true" -- pretty-prints `fun a ↦ b`
  ]

Windows is not too happy yet: precompilation increases total build time from 29m12s to 29m47s. This might be, as pointed out before, because of the naive dlsym emulation in the interpreter that loops over all modules loaded into the process, i.e. scales linearly with the number of --load-dynlibs.

!bench

I tried benchmarking this (intel macos), but did two runs of this PR and got wildly different results (from lake clean && time lake build both times):
lake build  21737.87s user 1546.88s system 1204% cpu 32:12.56 total
lake build  16027.82s user 1224.07s system 1275% cpu 22:32.53 total

Not sure what to make of that. :-(
Benchmarking the base commit gives:
lake build  16414.45s user 1447.86s system 1239% cpu 24:00.93 total
lake build  17871.27s user 1564.50s system 1215% cpu 26:38.44 total

In light of #3632, I have removed the ToAdditive changes, leaving only the zero-dependencies Rename precompilation

@tydeu In order to keep the .olean traces platform-independent, we would have to stop including the contents of precompilation .o and .so files in the trace. This seems like a strict improvement, there is no conceivable scenario to me where hashing them would prevent rebuilds compared to hashing only the much smaller .c input files.

the .o files are generally smaller than the .c files

Ah, this indeed can be true for Lean's pre-optimized .c files. Though hashing only .c is of course still faster than .c + .o + .so.

I have definitely observe cases where the .o file is rebuilt but relinking is unnecessary

I didn't expect that, but fortunately linking is the fastest step anyway.

Furthermore, we rebuild the .o based on C compiler flags and the native libraries based on linker flags

Fortunately this should not be an issue for precompilation of pure-Lean projects like mathlib.
In any case, I would also be happy with making the native code hashing an opt-out.


Temporarily disable Socket Mode tests in CI builds

The Socket Mode related tests started failing today only in GitHub Actions environments for some reason. I know that this is not great at all even as the temporal treatment but for the following pull requests, let me disable those tests until the issue on the GitHub Action side (or we may be able to improve the stability of the tests by updating code).
Category (place an x in each of the [ ])

[ ] slack_bolt.App and/or its core components
[ ] slack_bolt.async_app.AsyncApp and/or its core components
[ ] Adapters in slack_bolt.adapter
[ ] Document pages under /docs
[x] Others

Requirements (place an x in each [ ])
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

[ ] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[ ] I've read and agree to the Code of Conduct.
[ ] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

Failed with another error:
==================================== ERRORS ====================================
_________ ERROR collecting tests/adapter_tests/aws/test_aws_chalice.py _________
ImportError while importing test module '/home/runner/work/bolt-python/bolt-python/tests/adapter_tests/aws/test_aws_chalice.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/adapter_tests/aws/test_aws_chalice.py:8: in <module>
    from chalice import Chalice, Response
E   ModuleNotFoundError: No module named 'chalice'
_________ ERROR collecting tests/adapter_tests/aws/test_aws_lambda.py __________
ImportError while importing test module '/home/runner/work/bolt-python/bolt-python/tests/adapter_tests/aws/test_aws_lambda.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/adapter_tests/aws/test_aws_lambda.py:5: in <module>
    from moto import mock_lambda
E   ModuleNotFoundError: No module named 'moto'
____ ERROR collecting tests/adapter_tests/aws/test_lambda_s3_oauth_flow.py _____
ImportError while importing test module '/home/runner/work/bolt-python/bolt-python/tests/adapter_tests/aws/test_lambda_s3_oauth_flow.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/adapter_tests/aws/test_lambda_s3_oauth_flow.py:1: in <module>
    from moto import mock_s3
E   ModuleNotFoundError: No module named 'moto'
=========================== short test summary info ============================
ERROR tests/adapter_tests/aws/test_aws_chalice.py
ERROR tests/adapter_tests/aws/test_aws_lambda.py
ERROR tests/adapter_tests/aws/test_lambda_s3_oauth_flow.py
!!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!!
============================== 3 errors in 0.16s ===============================
Error: Process completed with exit code 2.

After reinstalling all the dependencies, I managed to reproduce the same situation. Closing this PR and I will come up with fundamental fix on the issue.


Example in hidden_inputs_for_filter/1 not working as expected

Describe the bug
Hey @woylie,
I currently have a case where filter_fields/1 is a bit to static for us, since we need to render the filters in separate section, since there are so many that we want to group them nicely. The docs suggest that one can use https://hexdocs.pm/flop_phoenix/0.17.0/Flop.Phoenix.html#hidden_inputs_for_filter/1 in combination with inputs_for to render a single filter field, but I can't even get the example into a workable state and I suspect there is something wrong with it for using this with more than one filter.
<.form :let={f} for={@meta}>
  <.hidden_inputs_for_filter form={@form} />

      <%= for ff <- Phoenix.HTML.Form.inputs_for(f, :filters, fields: [:name]) do %>
        <.hidden_inputs_for_filter form={ff} />
        <.input label="Name" type="text" field={{ff, :value}} />
      <% end %>

      <%= for ff <- Phoenix.HTML.Form.inputs_for(f, :filters, fields: [:email]) do %>
        <.hidden_inputs_for_filter form={ff} />
        <.input label="E-mail" type="email" field={{ff, :value}} />
      <% end %>

</.form>

The example produces two form fields, both with the same name/id filters[0][value]/ flop_filters_0_value which obviously does not work.
This makes sense, since the to generate the fields we loop over the fields with Enum.with_index so both end up with 0
https://github.com/woylie/flop_phoenix/blob/0.17.0/lib/flop_phoenix/form_data.ex#L82-L114
To Reproduce
Steps to reproduce the behavior:
Implement the example from the docs
Expected behavior
Not sure if I just got something wrong, but I think flop currently does not allow what is outlined in the example.
Versions:

Flop.Phoenix: 0.16.0
Flop: 0.18.2
Elixir: 1.14.1
Erlang: 25.1.2
Phoenix.HTML: 3.2.0
Phoenix.LiveView: 0.18.2
Ecto: 3.9.1
Ecto SQL: 3.9.0

Additional context
Maybe we can get that to work if one could pass field: and index: as options to the inputs_for instead of fields, so one can actually implement something like the example suggests.
Thank you a lot in advance and for this great tool 💚
Cheers
Andi

I took the freedom to add an index option for now in a PR. Let me know what you think :).


Create 59-spiral-matrix-ii.py

(https://leetcode.com/problems/spiral-matrix-ii/)
59. Spiral Matrix IIMediumGiven a positive integer n, generate an n x n matrix filled with elements from 1 to n2 in spiral order.

Example 1:

Input: n = 3
Output: [[1,2,3],[8,9,4],[7,6,5]]

Example 2:
Input: n = 1
Output: [[1]]

Constraints:

1 <= n <= 20

I have added all the comments so that it's easy to read and understand the code along with the approaches.


fix: kill critical dependencies and module resolve error for webpack bundle

Thanks for doing this - I just had to do the same thing to get winston working with webpack.

This resolves #884, #861, #860, #917

Thank you for your contribution. This will land in a version very soon.


Support milestoned/demilestoned actions in IssuesEvent

When an issue is milestoned or demilestoned the issues event contains the associated milestone. https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads?actionType=milestoned#issues
I'm happy to raise a PR to add this to IssuesEvent if that's supported?

Sounds great, @matt-simons !
It's yours.


Release 0.2.0

Version 0.2.0 - June 25, 2020

Fix behavior of marks imported via htmlToSlate()
BREAKING: onContentChange() argument is now a raw EditorValue rather than a serialized JSON value so that clients can choose a serialization model.
add getContentHeight() function
fix style-handling bug in SlateEditor
Update dependencies

@mklewandowski  I'm going to go ahead and merge this so I can publish it but feel free to review after the fact.


Updated mitigation in section on arithmetic overflows

Describe your changes
The mitigation described in the section on arithmetic overflows is insufficient as it currently stands. Since LessThan only restricts the size of the difference |in[0] - in[1]| between the two inputs, a malicious user try to withdraw p - 1. As long as the current balance is non-negative this would satisfy the circuit, even though p - 1 is huge when viewed as an unsigned value.
The correct mitigation is to use LessThan, together with constraints restricting the size of the inputs to ensure that they are non-negative. This can be done using the Num2Bits template from Circomlib.
Common Vulnerabilities Addition Checklist

[x] Added example code of the vulnerability
[x] Gave an explanation of how the vulnerability works
[x] Added attack scenario section if applicable
[x] Added preventative techniques section if applicable

Great catch, thanks for making the PR! Looks good to me.


[Question]: can we use "rekor.tlog.dev" address as a value of the annotation "chains.tekton.dev/transparency"?

Feature request
In the meantime, Tekton Chains adds a transparency log server API URL which is "rekor.sigstore.dev"_ to the annotation "chains.tekton.dev/transparency" ^1 but the Chainguard team developed a UI project for Rekor called rekor-search-ui, so, I thought that should be a better experience for the end-users to change this URL with the UI one?
rekor.sigstore.dev => rekor.tlog.dev

I prefer the rekor.sigstore.dev URL so that people can easily know which tlog the entry is in.
Yeah, that makes sense to me either, but from the end-user perspective, when they display the details of the TaskRun, IMHO, it'd be better to see the UI link (https://rekor.tlog.dev/?logIndex=735223) instead of the API link because UI's are a super cool feature for the end-users 🙈

any other thoughts?

rekor.tlog.dev has no SLO and may be down or deleted at any time without warning.
The rekor.sigstore.dev annotation key is named like a URL not because it should be resolved in a browser, but just to namespace it.
The HTML served at rekor.sigstore.dev can presumably also go away at any time.
I recommend against using tlog.dev for this.

+1 to Jason / Priya w.r.t. the existing value.
If we really want this maybe we could put this in a separate configurable annotation? 🤔

If we really want this maybe we could put this in a separate configurable annotation? 🤔

This would be great if we could! I'm so thrilled to do that 🙈

based on the recent news that Chainguard contributes Rekor Search UI project to Sigstore, we might reconsider using this address in one of the Tekton Chains annotations about the transparency log server. WDYT @wlynch @imjasonh?
https://www.chainguard.dev/unchained/chainguard-contributes-rekor-search-project-to-sigstore


Abandoned?

Has this project been abandoned? If so I'd be willing to take on the responsibility.

邮件已收到。我会尽快回复！祝您一切顺利！兰雨田


Implement first set of APIs by writing example Django app

Should be done in "implement usage first".

already done


Menu Text

Ensure that the text of the menu is displayed, one to the right, the other to the left

Added styling so that the text was where I wanted it


Gh action pre commit

This action will validate terraform templates syntax, best practices and will generate documentation (readme files)
It will run:
https://github.com/antonbabenko/pre-commit-terraform
terraform_fmt
terraform_docs
terraform_tflint
terraform_tfsec
https://github.com/pre-commit/pre-commit-hooks

end-of-file-fixer

Main files to review:
.github/workflows/pre-commit.yaml
.pre-commit-config.yaml
pre-commit/action.yml
All other changes are included to test/fix gh action complaints


Add an example to README.md

This change adds a simple Geospatial  query example.

Thank you for adding more documentation! Unfortunately I wont be accepting this change as I am trying to keep the README simple and easy to read and I think if we start including examples for every term this would not be the case. Instead I have started writing examples in the godoc format which also has the added benefit that they are tested when you run go test.
Hope you understand, if you have any questions let me know.

Hi Dan,
You make a very valid point in wanting to keep the Readme clean, that does makes allot of sense.  On the other side of the equation, I spent hours trying to figure out how to perform a simple query that would have been solved within a couple of minutes if this little bit of documentation would have been available.  It gets so old trying to figure out even the simplest things with all of these partially documented libraries.  Don't get me wrong, I know you've worked very hard here, and it shows, but please keep in mind that your intimate knowledge of this library isn't magically transferred to others.  I didn't even see the tiny GoDocs badge until you mentioned it.  Please consider adding a more visible link to the GoDocs, and mention it at the top of the Readme to really point it out.  I would also suggest adding a couple of contributing sections, one for docs, and another for code,  in the Readme so that when people want to contribute they get started off in the right direction.  I would have been happy to have done my example in the GoDocs, but didn't know that's what I needed to.  I really appreciate your efforts in the Open Source community and I hope this perspective is helpful!
Thanks!
--Nick


clone step fails with dockerized agent running on windows with "can't resolve host"

Component
agent
Describe the bug
With the woodpecker server running on a raspberrypi and an agent on my windows pc the clone step fails with "Can't resolve host"
When using an agent on a linux pc everything works as intended.
Both agents are using the same exact docker compose file (see below, except for a different secret)
System Info
{"source":"https://github.com/woodpecker-ci/woodpecker","version":"1.0.3"}

Additional context
agent docker compose file:
version: "3"

volumes:
  woodpecker-agent-config:

services:
  woodpecker-agent:
    image: woodpeckerci/woodpecker-agent:v1.0.3
    container_name: woodpecker-agent
    command: agent
    environment:
      - WOODPECKER_SERVER=raspberrypi:8090
      - WOODPECKER_AGENT_SECRET=<secret>
      - WOODPECKER_FILTER_LABELS=host_os=windows
    restart: unless-stopped
    volumes:
      - woodpecker-agent-config:/etc/woodpecker
      - /var/run/docker.sock:/var/run/docker.sock

clone step log:
+ git init -b main
Initialized empty Git repository in /woodpecker/src/raspberrypi/pinna9001/repo/.git/
+ git config --global safe.directory /woodpecker/src/raspberrypi/pinna9001/repo
+ git remote add origin http://raspberrypi:3080/pinna9001/repo.git
+ git fetch --no-tags --depth=1 --filter=tree:0 origin +main:
fatal: unable to access 'http://raspberrypi:3080/pinna9001/repo.git/': Could not resolve host: raspberrypi
exit status 128

Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
[X] Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

I can ping external hostname like google.com but not my internal hostnames. Pinging the ip address also works.
The problems are only happening in the containers, that are started of the agent container.

Problem fixed by adding a dns entry to the daemon.json of docker. I don't really understand why the woodpecker-agent can resolve the hostname and the clone step can't. I also don't understand why the agent doesn't forward the information to the (clone) steps.


Limit the length of interface names.

Fixes #355.

So I am unsure we can fix this ourselves. The issue is the name of the interface on my machine is enx00e04c683700 which is very close to the maximum length already. Do you have a proposed alternative?

This is frustrating - I haven't seen the MAC in the interface name before. (I deleted all my hand wavy "what-ifs" comment concerning multiple NIC's with sequential MAC addresses - our usage should not be an issue).
Just thinking aloud?? We could do something funky like shorten the beginning of the MAC since that is the manufacturer code, leaving the trailing bytes which are generally more unique? But that is still not robust in the face of other naming schemes.
My actual suggestion is to reduce the message level to info. The message is not warning of a problem, it's really just an FYI.

I'll reduce the message level and I guess we just keep pondering the greater issue for now.


No ui login

I want to merge this change because it removes all UI login for login via request. It makes tests faster.

Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

I have no idea why tests on CI are failing ;(


Allow custom AuthenticationProvider on the TokenEndpoint when using @EnableAuthorizationServer

When using @EnableAuthorizationServer, it imports AuthorizationServerSecurityConfiguration which uses AuthorizationServerSecurityConfigurer to configure the /oauth/token, the /oauth/token_key and the /oauth/check_token endpoint security properties. A DaoAuthenticationProvider coupled with a ClientDetailsUserDetailsService is automatically injected with no easy way to configure.
I'm needing this customization to gracefully apply IP restriction based on OAuth Clients when they authenticate on the /oauth/token. The sets of IP will be different depending of the Client. I could inject a Filter before the BasicAuthenticationFilter but I would like to check the IP restriction once the client has been authenticated.
The PR #621 propose a solution to this by allowing a custom list of AuthenticationProvider to the AuthorizationServerSecurityConfigurer.

I've added another customization to provide a custom AuthenticationEventPublisher on the AuthenticationManager instantiated by the AuthorizationServerSecurityConfigurer. I've merged the two features in the same PR #621, hopefully it's fine with you and it can get merged upstream soon. If it's a problem, just say so and I'll split them.

@jebeaudet I'm going to close this based on this comment.

Hi @jgrandja
Unless I'm mistaken, adding an AuthenticationProvider in a distinct WebSecurityConfigurerAdapter will result in 2 authentication providers in the security chain, my custom one and the ClientDetailsUserDetailsService instance wired in AuthorizationServerSecurityConfigurer.
Depending on the order of things, if your custom authentication provider is not used before the default one in the AuthenticationManager, it will just not work.

@jebeaudet

Depending on the order of things, if your custom authentication provider is not used before the default one in the AuthenticationManager, it will just not work.

Have you tried configuring using HttpSecurity.authenticationProvider()? If not, please try it out to determine if it works or not. If it doesn't, then please provide a minimal sample demonstrating the issue and I'll take a look at it.

I looked at the source code, by doing what you suggest, a UserDetailsService will be always be set by AuthorizationServerSecurityConfigurer on the AuthenticationManagerBuilder. Setting that will instantiate a DaoAuthenticationConfigurer which will add an AuthenticationProvider the same way you suggest here.
This means you'll end up with 2 authentication provider, the default DaoAuthenticationProvider backed by the ClientDetailsUserDetailsService set by this project along with the custom I want.

@jebeaudet I will need a sample that reproduces the issue (if there is one). It is very difficult to go back and forth here with details without really trying it out. Please try it out first. If it doesn't work then send me a link to the GitHub sample.

I've played around the issue here and I think my conclusions stand, it's not possible to gracefully execute what I want.
Project classes
TestAuthProvider
This is a small class implementing AuthenticationProvider and representing the custom authentication provider I want to add.
AuthProviderTester
Little class inspired by the UTs I made for this PR that fetched the filter chain for /oauth/token, get the BasicAuthenticationFilter and get its AuthenticationManager. It then prints the list of AuthenticationProvider classes in the console. It also fetches the DaoAuthenticationProvider and print its class name if its present. It then exits the program.
WithEnableAuthorizationServer, WithEnableAuthorizationServerNotWorking and WithoutEnableAuthorizationServer
Configuration classes for the 3 test cases I'll be describing next.
SpringSecOauthExampleApplication
Main class to start the example.To execute each test case, simply uncomment the proper line.
Test cases
WithEnableAuthorizationServer
You will get the following output:
Authentication providers list :
class com.jebeaudet.TestAuthProvider
class org.springframework.security.authentication.AnonymousAuthenticationProvider
class org.springframework.security.authentication.dao.DaoAuthenticationProvider

UserDetailsService class of the DaoAuthenticationProvider instance :
class org.springframework.security.oauth2.provider.client.ClientDetailsUserDetailsService

As you can see, the DaoAuthenticationProvider is present. It is after my custom AuthenticationProvider so technically this would work but it's inelegant because this creates 2 filter chains, one with the order -1 and the other with the order 0 defined by AuthorizationServerConfigurerAdapter.
WithEnableAuthorizationServerNotWorking
You will get the following output:
Authentication providers list :
class org.springframework.security.authentication.AnonymousAuthenticationProvider
class org.springframework.security.authentication.dao.DaoAuthenticationProvider

UserDetailsService class of the DaoAuthenticationProvider instance :
class org.springframework.security.oauth2.provider.client.ClientDetailsUserDetailsService

As you can see this is not working because the order of the configurer is lower than the one define in AuthorizationServerConfigurerAdapter so the invoked filter chain for the /oauth/token path is not the one I want.
WithoutEnableAuthorizationServer
You will get the following output:
Authentication providers list :
class com.jebeaudet.TestAuthProvider
class org.springframework.security.authentication.AnonymousAuthenticationProvider
class org.springframework.security.authentication.dao.DaoAuthenticationProvider

UserDetailsService class of the DaoAuthenticationProvider instance :
class org.springframework.security.oauth2.provider.client.ClientDetailsUserDetailsService

This works and does not create additional useless filter chains like the two other examples. However, I think it's inelegant because I have to manually import the correct configuration classes (including my custom one). Also, there's still a DaoAuthenticationProvider present in there that could technically be invoked without my custom business logic that could break my security feature so I'd rather not have it there.
Conclusion
I think the presented solutions are inelegant because 1- multiple http filter chains might be created and 2- you always have the DaoAuthenticationProvider instance there.
I might have missed something so feel free to correct me.

@jebeaudet Thank you for the detailed sample. It was super helpful and I was able to come up with a solution that included your TestAuthProvider and removed the DaoAuthenticationProvider.
I will admit that it wasn't easy to get to this solution but here it is.
@Configuration
@ConditionalOnProperty(name = "test", havingValue = "withCustomAuthorizationServerConfiguration")
public class WithCustomAuthorizationServerConfiguration
{
    @ConditionalOnProperty(name = "test", havingValue = "withCustomAuthorizationServerConfiguration")
    @Configuration
    @Import({AuthorizationServerEndpointsConfiguration.class, CustomAuthorizationServerSecurityConfiguration.class})
    // This class @Import the same @Configuration as @EnableAuthorizationServer,
    // with the exception of the custom AuthorizationServerSecurityConfiguration
    public static class CustomAuthorizationServerConfigurer extends AuthorizationServerConfigurerAdapter {

        @Override
        public void configure(AuthorizationServerSecurityConfigurer security) throws Exception {
            super.configure(security);
        }
    }

    @Import({ ClientDetailsServiceConfiguration.class, AuthorizationServerEndpointsConfiguration.class })
    public static class CustomAuthorizationServerSecurityConfiguration extends AuthorizationServerSecurityConfiguration {

        @Override
        protected void configure(HttpSecurity http) throws Exception {
            super.configure(http);

            // IMPORTANT:
            // This configurer needs to be applied below `super.configure(http)`
            // to ensure it's order is after `AuthorizationServerSecurityConfigurer`
            http.apply(new AuthorizationServerAuthenticationManagerConfigurer());
        }
    }

    private static class AuthorizationServerAuthenticationManagerConfigurer extends SecurityConfigurerAdapter<DefaultSecurityFilterChain, HttpSecurity> {

        @Override
        public void init(HttpSecurity builder) throws Exception {
            AuthenticationManagerBuilder authBuilder = builder.getSharedObject(AuthenticationManagerBuilder.class);
            authBuilder.removeConfigurer(DaoAuthenticationConfigurer.class);
            authBuilder.authenticationProvider(new TestAuthProvider());
        }
    }
}

Let me know what you think?

Good thinking with using a SecurityConfigurerAdapter, didn't cross my mind when I was poking around with my POC. This does indeed work as intended.
However, TBH, I think this whole thing is a hack, including my POC examples. It's brittle. What if Spring Security decides to change the use of DaoAuthenticationConfigurer when setting a UserDetailsService? What if Spring Security OAuth starts injecting an AuthenticationProvider directly instead of relying on injecting a UserDetailsService? Both changes would make this hack fail silently. Playing with the HttpSecurity instance overriding other actions just doesn't feel right.
Moreover, I don't see how I could document this properly to someone who would like to do the same thing. Ditching the use of @EnableAuthorizationServer for this is sad I think and adds more brittleness to the solution. This library should bring sane defaults for the common use case and clean way to customize every aspect of it, with proper validations that the interaction of the moving parts are not broken by an override and clear documentation.
At this point, you get the last words on what to do here, I understand that this lib is EOL so if you want to leave it as it is, I don't really mind (I already maintain a fork with this PR, just wanted to contribute back upstream).
Thanks

@jebeaudet Agreed that the solution I provided works but it is complicated and it really should not be that complicated. Having gone through the exercise convinced me that it should be much easier. If you would like to resubmit your PR, we'll get it merged.

Thanks for the reconsideration! I've opened a new PR and merged the upstream master into it, it should be good to go.

@jebeaudet Can you please rebase on upstream master instead of merging.

Given the age of that branch and the fack that I had already merged master twice in it, it was simpler to just cherry pick my commits into a new branch and yet another new PR. Hopefully it's fine like this @jgrandja.


Document "fundamental differences of opinion"

This may appear to be a minor quibble but it actually has a technical purpose. Could you briefly clarify what your primary "fundamental differences of opinion" were with the authors of termbox-go?
It would help users like myself determine which solution we want to use, e.g. which technical philosophies the two of you differ on and which we more identify with.
In short, this is just a request for a brief overview of the advantages of tcell over termbox-go.

The largest ones seem to be the choice of SIGIO (termbox) vs timeouts (tcell), and using pure Go (termbox) vs cgo (tcell). cgo means tcell is cumbersome or outright forbidden in certain projects/teams/environments (like cross-compilation). SIGIO means termbox doesn't work on some platforms (Window Subsystem for Linux Ubuntu thing for example).

This is correct.  I needed to be able to use tcell or termbox in places where we could use termbox because of SIGIO.
cgo is indeed cumbersome, and I'd like to ditch it.  You'll note that cgo is not required to build the Windows port.  It is required for UNIX platforms to cope with setting terminal modes, and I also use it when updating the terminal database.  (Technically, the latter step doesn't needed to be performed by anyone except package maintainers -- specifically me.)

Oh so the runtime only needs cgo for Solaris build? I had totally missed that!


I created the turret subsystem.

I don't know why all of these other changes occured.

As far as I can tell, your copy of Master was from the very start of the project.  At least, that's what DriveTrain.java leads me to believe.
can you try doing a pull from master  and see if the file comes back to normal?
Something is wrong with the current version of the pull request, and we'll lose (at least) the entire contents of DriveTrain.java if I accept the submission.  Maybe.  or, perhaps merging on this end would fix that... but I'm not sure.

Many of the other changes are due to RobotBuilder rewriting files and changing the order of lines and some indentation.  The files ending in a tilde are backups, which change every time you save the file.  I'll look into whether I can remove them from the repo and get them to be ignored... I think there's a way to do that.

I think this is now merged cleanly.  took a couple hours of work, though.  Hope we figure out what happened.  At the very least, it seems you have not installed the CTRE CANTalon software locally, which is part of the problem.  I'll post something in spaces about that.


[CLOSED] Migration/7 25

 Issue by Wilson-Ding1
Thursday Sep 28, 2017 at 04:13 GMT
Originally opened as https://github.ibm.com/IBM-Swift/swift-watson-sdk/issues/32

 Issue by vherrin
Sunday Sep 18, 2016 at 18:15 GMT
Originally opened as https://github.com/IBM-Swift/swift-watson-sdk/pull/32

vherrin included the following code: https://github.com/IBM-Swift/swift-watson-sdk/pull/32/commits

 Comment by Wilson-Ding1
Thursday Sep 28, 2017 at 04:13 GMT

 Comment by vherrin
Sunday Sep 18, 2016 at 18:16 GMT

update to 7/25 for now which will move the project to xcode 8


Make the day16 of 2022 implementation fastish on Scala.js.

(and really fast on the JVM)
This is the best I could come up with, in a reasonable amount of time, and without changing the algorithm itself.

nice improvement!


Resolve ranger-examples-distro module compile error

When compile ranger with below command:
mvn -DskipTests clean compile package install assembly:assembly
Throws create assembly failed:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.6:single (default) on project ranger-examples-distro: Failed to create assembly: Error creating assembly archive sampleapp: You must set at least one file. -> [Help 1]
compile error.txt

I wanted to say thanks for putting this out there @PrivateLi , I hit the exact same problem and your patch got me to a successful mvn package step.
I did see this note in the readme, looks like they don't take Github PRs yet.

Why you don't merge it guys?
It resolved my problem.

While trying to build the Apache Ranger on Ubuntu 20.04, Using Java 1.8, I came across this issue. Not sure, whether this issue is related to maven or Ranger. It is failing on **Apache Ranger Distribution ** step. I am attaching the screenshot for reference.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.6:single (default) on project ranger-distro: Failed to create assem
bly: Error creating assembly archive schema-registry-plugin: Problem creating jar: jar:file:/home/swapnendu_b/apache-ranger-2.4.0/distro/target/ran
ger-distro-2.4.0.jar!/META-INF/maven/org.apache.ranger/ranger-distro/pom.properties: JAR entry META-INF/maven/org.apache.ranger/ranger-distro/pom.p
roperties not found in /home/swapnendu_b/apache-ranger-2.4.0/distro/target/ranger-distro-2.4.0.jar -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :ranger-distro

This is not an issue that needs to be merged, it happens when there is a mismatch in main Ranger version specified in ranger/pom.xml and  distro/pom.xml or ranger-examples/pom.xml, this causes unable to identify right project parent directory causing file path or no such file exception issue.

Actually, I was getting this issue. I didn't mean to merge it. Thanks for the clarification though. Will try with your fix.

I got the same error with Apache Ranger Distribution. Does anyone have a solution for this issue?


Handle image sizing on blog posts

Find a system to automagically size the images correctly on both the blog landing page and on individual blog posts

Are you looking for something like the eleventy-img plug-in for picture sizes and adaptable resolution? Or some CSS magic for responsiveness? Or both?

What would you advise/prefer?
I have no strong opinions.
I want to be able to use images without having to do a lot of heavy lifting of editing them for size before use. And for the sizes to look fine and somewhat responsive. That's the extent of it.


Use database locking (flock) for zsh

This PR adds support for locking the database (via advisory file locking) during update when zsh is used as shell. This is done via zsystem flock that is available in the zsh/system module. The lock is acquired before the database is read and kept until the (new) database has been written and the command has exited.
A separate code path is needed when updating the database entry because replacing the file (via mv) would cause any process waiting for a lock to fail. Here we simply clobber the database with the contents of the tempfile.
This is a partial fix for #198, more specifically, this only fixes the problem on zsh.
// ping @balta2ar

@rupa ping. Could you please review and merge this? I've been using it for two months and so far had no races and DB corruptions.

@rupa ping

@rupa ping

Yes please! Would love to see this get merged.

This would be very useful..

As this PR is coming up on two years, I'm closing it. If there's anything I can do to make it land, I'd be happy to fix. For example, if the use of mktemp is a problem, it would not be needed if we also landed https://github.com/rupa/z/pull/247.

sorry my friend, I haven't have a lot of bandwidth, I don't use zsh, and I am definitely slow on changes with this project for a variety of reasons. This is an issue though, and i'd prefer it stay open.
Thanks, and apologies

@rupa that's quite alright, I understand 😄. Rebased on master to get rid of the conflicts.


Documenting the use of sensitive data by Flux in the cluster

Currently Flux provides no central documentation on the security of Flux. This is an issue as a user might expose more data than anticipated and currently has to read the implementation to identify these concepts.

Document the security context of Flux in a central location. Topics that are useful to document on such a page include:

The sensitive data that Flux uses.
The attack surface of Flux.
What are the consequences of a compromise of Flux/component of Flux 4. Who should be allowed to administer Flux within an Organisation
Security hardening of Flux, i.e. Flux can be used in many ways and what are the best practices from a security perspective and what are some of the pitfalls that can happen

Open source projects that have examples of this:
● Docker: https://docs.docker.com/engine/security/
● Envoy: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/security/security
○ In particular the threat model

WIP for outlining how Flux correctly handles sensitive data during bootstrap, such as keys, and what the best practices are.
Bootstrapping

flux addresses 2 security:
source (git repo, helm, buckets etc)

we have to talk about the security here, and what bootstrap does.
asks for token for Github and GitLab etc
by default, we don't use token in cluster. it never leaves your machine
we use that to generate a deploy key, and we use that within the cluster
we're getting this question on slack a lot
but what if you do want flux to use a PAT? to give flux access to all repos in your org?

solution is you great a user for flux, and bootstrap using flux bot user token
then you can do this using the special flag in bootstrap --token and only if you do that, will flux use this in cluster
we must explain this in best practices

don't use your user PAT with --token
instead, use a Github machine user

Issue closed by #641 and #711.
Will open a follow-up issue to address possible enhancements as mentioned in https://github.com/fluxcd/website/issues/595#issuecomment-976151045.

What from https://github.com/fluxcd/website/issues/595#issuecomment-976151045 is still missing?

What from #595 (comment) is still missing?

Not necessarily missing. Elaborated here: https://github.com/fluxcd/website/issues/721#issuecomment-1021399424


Travel estimate differs from actual

When selecting an army to travel to a realm, a time estimate is given for when the army will arrive. This estimate differs from the actual travel time once the transaction has been mined.
Expected behavior: estimate and actual travel time should match.
Estimate:

Actual:

Could it be the Estimated travel time is from the realm the army is owned by, instead of the army's current location? (or vice versa)
For example army was created on realm id 126. Distance from 126 to 13 is 2.22hrs. But army is actually on realm 5000, and travel time is 7hr15min.

This is travel bug in contracts, which has been fixed


upgrade RRTMGP and remove redefining function

Purpose
Closes #1246

To-do

Content

[ ] I have read and checked the items on the review checklist.

bors r+


Morpheus Lumerin Model

A complete architecture guide for the Morpheus core node and ecosystem design (draft 1)

Great contribution. Thanks.


Cleanup of the CI

Split the cross compiling part and ordinary Rust checks.

Fixes #137

I'll close this because it's superseded by #149


Getting this issue

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':agora_rtc_engine:generateDebugRFile'.

Could not resolve all files for configuration ':agora_rtc_engine:debugCompileClasspath'.
Failed to transform annotation-experimental-1.1.0.aar (androidx.annotation:annotation-experimental:1.1.0) to match attributes {artifactType=android-symbol-with-package-name, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-api}.
Execution failed for ExtractAarTransform: /home/sirwaleed/.gradle/caches/transforms-3/7f587b29568a4f8e237b611e0650f5e3/transformed/jetified-annotation-experimental-1.1.0.aar.
/home/sirwaleed/.gradle/caches/transforms-3/7f587b29568a4f8e237b611e0650f5e3/transformed/jetified-annotation-experimental-1.1.0.aar (No such file or directory)
Failed to transform tracing-1.0.0.aar (androidx.tracing:tracing:1.0.0) to match attributes {artifactType=android-symbol-with-package-name, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-api}.
Execution failed for ExtractAarTransform: /home/sirwaleed/.gradle/caches/transforms-3/0140d387151ae272d8e07965c9802b02/transformed/jetified-tracing-1.0.0.aar.
/home/sirwaleed/.gradle/caches/transforms-3/0140d387151ae272d8e07965c9802b02/transformed/jetified-tracing-1.0.0.aar (No such file or directory)
Failed to transform window-java-1.0.0-beta04.aar (androidx.window:window-java:1.0.0-beta04) to match attributes {artifactType=android-symbol-with-package-name, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-api}.
Execution failed for ExtractAarTransform: /home/sirwaleed/.gradle/caches/transforms-3/4f9109c3f811837e3ff21356db532795/transformed/jetified-window-java-1.0.0-beta04.aar.
/home/sirwaleed/.gradle/caches/transforms-3/4f9109c3f811837e3ff21356db532795/transformed/jetified-window-java-1.0.0-beta04.aar (No such file or directory)
Failed to transform window-1.0.0-beta04.aar (androidx.window:window:1.0.0-beta04) to match attributes {artifactType=android-symbol-with-package-name, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-api}.
Execution failed for ExtractAarTransform: /home/sirwaleed/.gradle/caches/transforms-3/bfc2aa6059b1d5c609cbf9b2eee0b7a3/transformed/jetified-window-1.0.0-beta04.aar.
/home/sirwaleed/.gradle/caches/transforms-3/bfc2aa6059b1d5c609cbf9b2eee0b7a3/transformed/jetified-window-1.0.0-beta04.aar (No such file or directory)

The issue is most likely not relative to the agora_rtc_engine plugin. Maybe you can try clean and rebuild it.


Fixing null safety warning in flutter3

Small fix to fix null safety warning for WidgetsBinding.instance that was nullable before Flutter 3.0 but it's non-null in Flutter 3.0+. I also bumped the version from 0.1.2 to 0.1.3 to ensure that libraries that depend on this updates to the latest code.

Ping @jaumard please approve and push new version to pub.dev if you have some spare time.

Nice thanks for the PR, can you also update that part please:
environment:
  sdk: '>=2.12.0 <3.0.0'
  flutter: ">=1.7.8"

That will prevent people update the version if they have wrong flutter version.

Fixed.

perfect thanks a lot!


Fix tests for librdkafka 0.11.3+

Limit queued.max.messages.kbytes according to librdkafka cc43f4.
This will fix rdkafka tests on librdkafka 0.11.3+.
E       RdKafkaException: Configuration property "queued.max.messages.kbytes" value 102400000 is outside allowed range 1..2097151

Codecov Report

Merging #928 into master will decrease coverage by 7.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
- Coverage   83.21%   75.45%   -7.76%
==========================================
  Files          36       36
  Lines        3806     3806
  Branches      562      562
==========================================
- Hits         3167     2872     -295
- Misses        490      777     +287
- Partials      149      157       +8

Impacted Files
Coverage Δ

pykafka/rdkafka/simple_consumer.py
88.49% <ø> (-0.89%)
:arrow_down:

pykafka/rdkafka/helpers.py
20% <0%> (-73.34%)
:arrow_down:

pykafka/utils/compat.py
35.13% <0%> (-50.01%)
:arrow_down:

pykafka/managedbalancedconsumer.py
45.03% <0%> (-39.08%)
:arrow_down:

pykafka/broker.py
67.05% <0%> (-26.02%)
:arrow_down:

pykafka/handlers.py
73.52% <0%> (-19.12%)
:arrow_down:

pykafka/connection.py
64.35% <0%> (-18.82%)
:arrow_down:

pykafka/simpleconsumer.py
75.22% <0%> (-9.38%)
:arrow_down:

pykafka/topic.py
71.13% <0%> (-7.22%)
:arrow_down:

pykafka/utils/socket.py
75% <0%> (-6.25%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3893c46...72a12b3. Read the comment docs.


fix: do not fail when value set to file flag

Fixes typo in file flag value check
dagger call workflows run --source /Users/aweris/development/workspaces/github.com/aweris/gale --workflow-file "/Users/aweris/development/workspaces/github.com/aweris/gale/ci/workflows/job-outputs.yaml" result
✘ build "dagger call" ERROR [1.13s]
├ [0.78s] loading module
├ [0.35s] loading objects
• Engine: 61b34bf9d33e (version v0.9.0)
⧗ 2.14s ✔ 30 ∅ 12 ✘ 1
Error: parse flags: invalid argument "/Users/aweris/development/workspaces/github.com/aweris/gale/ci/workflows/job-outputs.yaml" for "--workflow-file" flag: file path cannot be empty

@aweris can you add a DCO Signed-Off-By to your commit?

@jedevc  done


Cannot decode www.google.com in base64 but http://www.google.com works

⚠IMPORTANT⚠ if you do not fill this out, we will automatically delete your issue. We will not help anyone that cannot fill out this template.

[ ] Have you read our Wiki page "Common Issues & Their Solutions"?

Describe the bug
A clear and concise description of what the bug is.
Plaintext
⚠IMPORTANT⚠ The below code is non-negotiable for "Ciphey didn't decrypt...." problems. If you do not tell us your plaintext, we will not help you.

 ✘  thezakman@SRV-WEB1 ~  echo "http://www.google.com" | base64
aHR0cDovL3d3dy5nb29nbGUuY29tCg==

 thezakman@SRV-WEB1  ~  ciphey -t "aHR0cDovL3d3dy5nb29nbGUuY29tCg=="
Possible plaintext: 'http://www.google.com\n' (y/N): y
╭───────────────────────────────────────────────────╮
│ The plaintext is a Uniform Resource Locator (URL) │
│ Formats used:                                     │
│    base64                                         │
│    utf8Plaintext: "http://www.google.com          │
│ "                                                 │
╰───────────────────────────────────────────────────╯
 thezakman@SRV-WEB1  ~  ciphey -t "aHR0cDovL3d3dy5nb29nbGUuY29tCg=="

  thezakman@SRV-WEB1  ~  echo "www.google.com" | base64
d3d3Lmdvb2dsZS5jb20K

 pedro@SRV-WEB-CRAWLER01  ~  ciphey -t "d3d3Lmdvb2dsZS5jb20K"
Possible plaintext: 'TyT DaLiOk\rmLc)' (y/N): n
Possible plaintext: ')cLm\rkOiLaD TyT' (y/N): n
🌒  Thinking... (crashed | forever waiting)

Version
⚠IMPORTANT⚠ We need this information because different environments will induce different bugs in Ciphey

OS/Distro: [e.g. Windows, Debian 11.0, Arch, OS X El Capitan]
Python version: [python3 --version]
Ciphey versions: [python3 -m pip show ciphey cipheycore cipheydists]
Did you use Docker?

Verbose Output
⚠IMPORTANT⚠ Verbose output will tell us why it's not working the way we expected it to be.
Run Ciphey with ciphey -vvv and paste the results into Pastebin.com or a GitHub Gist
To Reproduce
Steps to reproduce the behavior:

What input did you use?
What flags / arguments did you use?

Expected behavior
It should decode it and not crash the app like it's doing right now.
Any other information?
Add any other context about the problem here.

This isn't a bug with Ciphey. Update your pyWhat version with pip install pywhat -U as Ciphey uses pyWhat for identifying URLs, API keys, phone numbers, etc.


continue to issue #8

To add some points to issue #8:

[ ] I'm not sure which one is better, but I've seen that you wrote some of the Source part at the their space in tables and some as citation at the reference part. Consistency helps readability.
[x] Some parameters in DD1 need to be defined such as Q13.
[x] It can be helpful to add "Incidental solar radiation" definition.
[ ] Different Q are used in different DDs, I suggest to describe Qx in general and then use it in different numbers.
[x] The constraint defined on the input in IM1, is on the parameter which is not at the inputs.
[x] In IM1, Because Tf is the function of time, it's better to describe it as the temperature of Fluid f at the time of t.
[x] In the IM2, correct the reference T?? at description part.
[x] It's better to refer to A4, like you did at IM2, instead of explaining again about the using water as test.
[x] In 4.2.6, "and" between input and output missed.
[x] In Table1, what is n?
[ ] In Table1, What are min and max of the parameters? I couldn't find them at the document.

For last question: min and max are the minimum and maximum value for the particular thing. For example, L is a length of box and that should be not too big or too small. It should be between standard solar box's minimum and maximum length.

I am not clear with it: "Different Q are used in different DDs, I suggest to describe Qx in general and then use it in different numbers." All Q's have different meaning. So, I just clarified the meaning of each. I guess I don't need to add other details in it.

The mentioned links are the direct weblink and citation are the books/publications. So, I guess, it's good to separate it in source.

The updated SRS.pdf file which address to the given issues. 59d4b6e


Started renaming elem to \in

I started renaming elem to \in and notelem to \notin, but I encountered some problems:
when I used the tactic:
assert (x ++ [A0] ++ [A1] <> [A1] ++ [A0]).
then I get the following goal:
[A1] ++ [A0] \notin ((alphabet \in list) \in @eq) (x ++ [A0] ++ [A1])
Maybe there is something I need to unimport to not have this syntax,
because now I also cannot use contradiction in the Lemma test_notin_xI01_10
When I apply the newly assert hypothesis, after I proved it to False,
apply H.
I again get:
x ++ [A0] ++ [A1] = [A1] ++ [A0]
So I believe it has something to do with notin, maybe?
This is unfortunately not just syntactical actually influences which tactics we can use.
My first guess is that this syntax is already used in a somewhat standard library, see https://coq.inria.fr/library/Coq.ssr.ssrbool.html
It is quite possible that we end up using ssreflect, but for now, I would like things to keep on working until we get to that part of Coq Art and decide whether it is really appropriate.

I tried some latex, it seems \notin is the right syntax, if we can solve the other problems

Hm, strange.
I wonder how Coq decides when to use syntax and when not to use it. In the example you gave, it looks like Coq really replaced every application with \in and every not (some application) with \notin, which I suppose the new notation does allow in principle. But then the question is: why didn't Coq do that before?
It looks like ssreflect uses \in and \notin in the same as we do: it says
 If P is a predicate the proposition "x satisfies P" can be written
 applicatively as (P x), or using an explicit connective as (x \in P); in
 the latter case we say that P is a "collective" predicate. We use A, B
 rather than P, Q for collective predicates:
                 x \in A == x satisfies the (collective) predicate A.
              x \notin A == x doesn't satisfy the (collective) predicate A.

I haven't read the relevant section of the manual yet, but I did find that you can tell Coq to use a notation only for parsing (not for printing) (search for only parsing in this part of the manual). This issue has an example.

Another guess of mine is that maybe we accidentally changed the scope of the syntax by renaming it to something that already existed?

Another guess of mine is that maybe we accidentally changed the scope of the syntax by renaming it to something that already existed?

I also suspect it has something to do with scoping.
Maybe it might be worth holding off on this, until we have learned about SSReflect, since we might end up using it.

https://github.com/awalterschulze/regex-reexamined-coq/pull/146 supersedes this work.


Rd53cmd

Added RD53 command firmware module and test

Coverage increased (+0.6%) to 39.875% when pulling 8ef2fbb6b19d1c117c60d43fe36586818188afd0 on MarcoVogt:rd53cmd into 679a7ef4d916be284283967b5b9f1bb80839901e on SiLab-Bonn:rd53cmd.

Coverage increased (+0.6%) to 39.875% when pulling 8ef2fbb6b19d1c117c60d43fe36586818188afd0 on MarcoVogt:rd53cmd into 679a7ef4d916be284283967b5b9f1bb80839901e on SiLab-Bonn:rd53cmd.

Coverage increased (+0.6%) to 39.875% when pulling 78840bc88c9cbf85150c8a459220590f12095d5b on MarcoVogt:rd53cmd into 679a7ef4d916be284283967b5b9f1bb80839901e on SiLab-Bonn:rd53cmd.


wrong FPS shown in FF43 and only in FF

correct FPS is shown in other browsers.
it shows 1920p@30 in FF when it should show 1920p@60 on this video;
https://www.youtube.com/watch?v=46yDs3N6U6Y

turns out ff43 was the culprit. i updated ff to 44 beta and i see correct FPS


rego-cpp binaries are large

On x86-64 Ubuntu, even after strip, the rego binary created using GCC is 16M. When created using clang, after strip it is 6.5 MB.
anakrish@ubu ~/r/r/build (main)> tree -sh dist/bin
[4.0K]  dist/bin
├── [ 16M]  rego
├── [ 18M]  rego_test
├── [ 16M]  rego_trieste
└── [ 18M]  yaml_trieste

On OSX running Apple Silicon, the rego binary is 18M after strip.
anand@Anands-M3Max ~/r/r/build (main)> tree -sh dist/bin
[ 192]  dist/bin
├── [ 18M]  rego
├── [ 22M]  rego_test
├── [ 21M]  rego_trieste
└── [ 22M]  yaml_trieste

We're aware of the binary size issue. It is common across all Trieste-based solutions at the moment. We're working to solve it upstream.


Pug (jade) icon

Hello, first of all thanks for the awesome icons, my favorite !
As you may already know, pug is replacing jade from version 2 and now have the .pug file extension.
It would be nice for consistency to have the same icon for pug (jade's currently icon <>).

Closed via https://github.com/wyze/atom-seti-icons/commit/d1f70abce06b5c9e78e5a35d155865936642c2d4 and published in v1.0.0.

Awesome ! Love it ! Thanks a lot ;)


Specify Bootstrap Peer (fork recovery technique)

Discovery currently provides all peers. (good and bad potentially)
When a network is forked it is valuable to be able to specify a known-good peer who you wish to bootstrap from. (to avoid re-syncing with a bad fork)

could be collapsed in to an extension flag.
-peer a.b.c.d:8303 -bootstrap-from-peer

I see no reason why we can't add this, though I believe we should discourage users from using this and primarily only use this internally. Our bootstrap logic right now is simple and needs some improvements in order to help avoid syncing to bad forks. Furthermore, there shouldn't even be bad forks. We should focus our engineering effort (heavily + soon, imo) on making our nodes more resilient when bootstrapping and catching up rather than relying on a tool that we should discourage the use of during mainnet. Though, as I said at the beginning, we should at minimum add this for internal usage when we do experience forks on our networks and want to recover our nodes onto the correct fork.

The intent here is to do manual recovery from forks on testnets. We shouldn't require this in normal operation.

Closing this issue as it is stale for a long time.


Can't create android platform with cordova browser installed

After adding the platform as suggested in this issue https://github.com/driftyco/ionic-cli/issues/342 I have been able to finally proceed beyond that error but unfortunately I am getting another error
Error: ENOENT, no such file or directory '/Users/pencilcheck/Projects/workties/mobile/plugins/org.apache.cordova.engine.crosswalk/plugin.xml'

I assume the plugin is also in the engine/ folder, but why is it not installed automatically?

Nvm, fixed itself, I all did is to delete engine, plugins, platforms folders and rerun ionic browser add crosswalk


Could Window be marked Send

The Window is currently not Send which severely limits how it can be used in a multi-threaded environment. Is this limitation necessary due to the underlying OS-specific implementations or could this guarantee be given?
(For example, it seems that minifb::os::unix::x11::Window contains a *mut x11::xlib::XImage and hence just needs to be explicitly marked Send. Or does this pointer or the data contained in the XImage instance reference stack-local data after all?)

I know before I switched to Metal on macOS those API calls had to be done on the main-thread but right now I'm not sure. One would have to look at all the implementations to verify that they can be called in a safe fashion show then.
Right now I would recommend having worker threads that generates the data you want and then have one thread (main) that gets that data to be used for presentation.

One would have to look at all the implementations to verify that they can be called in a safe fashion show then.

Since Send is a build time guarantee, could this just be different between different platforms? I.e. Window is Send on Windows and Unix but not for macOS or would you consider this too much of a portability hazard?

I really want minifb to work the same on all platforms as this is what I as a user would expect on any library.

Understood, let's close this then.

It would be nice to have this implemented but needs research on all platforms. Right now I currently have the time to do so but if anyone want to look into it that would be great.