Change OSSL_PARAM return size to not be a pointer.

Instead of referencing the return size from the OSSL_PARAM structure, make the
size a field within the structure.

[x] documentation is added or updated
[x] tests are added or updated

param_test is currently failing, but this should give an idea of what this change requires.

doc-nits failure is valid.

Is there any interest in these changes?
If not, I'll close.

Hold ye 'orses...  I'll get back to this later today.

If not, I'll strip down to the return size removal for the native types .. only BN and the two strings need this.

Travis doesn't seem relevant.

Travis doesn't seem relevant.

I restarted the offending job, as it looks like the worker just got stuck somewhere in its own processing...

The restarted job passed...a random failure :(

Ping for review?

Merged, thanks.


question: how to preform query with variable length of param?

Assumes that I want to filter rows by checking if their ids are in the specific range.
In pure SQL, I can do something like
select * from foo where id in ('0', '1', '2');

But it seems like sqlx doesn't support that syntax:
sqlx::query!(
    "select * from foo where id in $1",
    vec!["0", "1", "2"] // error
);

So is there any workaround to perform such query, or this feature is not yet implemented?

Any idea when this might change? Currently evaluating sqlx for a project and this is kinda a deal breaker.

Principal implementation for arrays is in #110, I'm looking over it now. It will probably be rebased and merged into develop for inclusion in #111. When that will be done depends on if @mehcode gets a chance to finish up the refactors for MySQL this weekend since I'll be out of town (although I'm taking a laptop so I could potentially work on it).

master now has full support for arrays and vectors in parameter and result position

Hi, is there a plan to support this feature in mysql ?


Add option to change stretched mode UI scaling % when changing client size

Add option to change stretched mode UI scaling % when changing client size
Include chat notification as well, see #3

Added in 0245ca5a3c918639ed47336a2b009be198beea88


Implement new Tiler services for show-source management

Implement new Tiler  get/set services to get/set the Tiler's show-source property.
#define DSL_TILER_ALL_SOURCES NULL

DslReturnType dsl_tiler_source_show_get(const wchar_t* tiler, const wchar_t** source);
DslReturnType dsl_tiler_source_show_set(const wchar_t* tiler, const wchar_t* source);

done, needs documentation...

@rjhowell44 thanks for this, works like a charm for key events.  An improvement would be to get the source-id resolved from coordinates and passed through to the button handler attached with dsl_pipeline_xwindow_button_event_handler_add.
This would allow the user to then show the specific source on mouse-click like with the deepstream-app.  It would also then be required to pass through the button that was pressed. #290 would allow for displaying the source information.
Is it possible to have keyboard and/or mouse events with an overlay sink?

Hey @jlerasmus
RE:  An improvement would be to get the source-id resolved from coordinates
Yes, I agree... I've just been trying to think through the use cases. My original though was to have a second Tiler service to show a source based on x/y offsets,
But for the case where the window/button dimensions are scaled differently from Tiler, the client would need to do the scaling in the button-pressed callback.
Another option would be to provide a Pipeline service that returns the Source Id based on Window coordinates, and then the client could call the show-source with the Id. There may be other reasons for selecting a source, beyond just showing it.
Let me know your thoughts.
RE: Is it possible to have keyboard and/or mouse events with an overlay sink?
There is no way of adding a key event handler to the sink directly, that I'm aware of... but the overlay sink needs to overlay a window - the examples, as I'm sure you're aware of, all use the main window with Id "0" - so I'm assuming you can install your own main window key handler, or create a new xWindow and overlay the sink, or something like that.

@rjhowell44 my current use case is to show the source by clicking on the specific source's tile, and then show that source (as with the deepstream-app sample).  Basically the same as by pressing the source id on the keyboard (e.g. 0 through 7).
Another use case might be to show the source that triggered an action, e.g. when a person is detected show the source for 5 seconds (or until another source triggers an event), and then switch back to tiled mode.
I currently have something working in the python button-click-handler, but it only works if the window is not scaled/resized as that information is not available (only the xpos and ypos is passed).  Also, there is no indication of what button was pressed, therefore one can't have something like left-click to show the source, and right-click to return to tiled mode.
A pipeline service that resolves the source-id from the window coordinates should do the trick.

@jlerasmus I like the action Idea... will definitely include something.

This may be enhanced in the future. Going with the following for the v0.07.alpha release
/**
 * @brief Gets the current Show Source setting for the named Tiler
 * @param[in] name unique name of the Tiler to query
 * @param[out] source name of the current source shown by the Tiler.
 * A value of DSL_TILER_ALL_SOURCES (equal to NULL) indicates all sources are shown
 * @param[out] current remaining timeout value, 0 if showing all sources and the timer is not running.
 * @return DSL_RESULT_SUCCESS on success, DSL_RESULT_TILER_RESULT
 */
DslReturnType dsl_tiler_source_show_get(const wchar_t* name,
    const wchar_t** source, uint* timeout);

/**
 * @brief Shows a single source instead of all tiled sources - the default tile mode.
 * @param[in] name unique name of the Tiler to update
 * @param[in] source unique name of the source to show,
 * @param[in] timeout time to show the source in units of seconds, before showing all-sources again
 * A value of 0 indicates no timeout.
 * @param[in] has_precedence if true will take precedence over a currently show single source.
 * @return DSL_RESULT_SUCCESS on success, DSL_RESULT_TILER_RESULT
 */
DslReturnType dsl_tiler_source_show_set(const wchar_t* name,
    const wchar_t* source, uint timeout, boolean has_precedence);

/**
 * @brief Shows all sources and stops the show-source timer if running.
 * @param[in] name unique name of the Tiler to update
 * @return DSL_RESULT_SUCCESS on success, DSL_RESULT_TILER_RESULT
 */
DslReturnType dsl_tiler_source_show_all(const wchar_t* name);


Don't invoke the bundled protoc binary on non-gnu Linux hosts

Revisiting the problem reported in #182. Unfortunately, it percolates to builds that use tower-grpc-build and troubleshooting clues are currently less than ideal.
Is it possible to avoid running the bundled protoc on non-glibc (e.g. musl) Linux host environment and report that a binary needs to be supplied? Notably this is different from the build target.

Ah, is this coming up when using prost on Alpine Linux?  I don't think I fully grasped the significance of the report in #182; I thought it was a really oddball setup that I wouldn't be able to reproduce.  It should definitely be possible to hack support for dynamically detecting non-existence of glibc and falling back to the environment or path.  See https://github.com/danburkert/prost/blob/master/prost-build/build.rs for where this all happens.

Or, for a real challenge, convince upstream to ship fully static binaries :)

It should definitely be possible to hack support for dynamically detecting non-existence of glibc

There may be way too many corner cases; this would need to check if the libraries exist in the library path where the /lib*/ld*.so.? loaded by the binary would expect to find them, which is configurable (both in /etc and via ${LD_LIBRARY_PATH}). It may be easier to try to run ldd and parse its output.
I'd rather suggest checking the host tuple (available from ???) or uname -o. Unfortunately, env::consts::OS does not provide detailed information on the flavor of Linux.

I’m still somewhat confused why asking users to make protoc available in the environment and using it by default is an issue. Its a build too like any other.

I second @nagisa's question: why do we need to handle the case where protoc isn't installed? It's actually quite difficult to provide a reasonable error message when the loader is the problem, as opposed to protoc not being available, to which we could respond with protoc not found, please install or some such message.

A compromise might be to prefer the protoc from PATH before the bundled one.

@danburkert Would you accept a PR to move the order of preference from the bundled protoc to the one found in PATH?

Just hit this, had to strace to track down the issue. I don't quite understand why prost is using a pre-compiled binary blob at all?
This choice has serious security implications. I can audit the packages installed on my system, they can all be traced back to sources. I can audit all my rust dependencies, again, the produced binaries are linked to sources. What I cannot do is audit a random binary blob, I have to trust both the upstream maintainers (and their build servers) and the prost maintainers.
(Using the PROTOC/PROTOC_INCLUDE workaround now)

@danburkert Would you accept a PR to move the order of preference from the bundled protoc to the one found in PATH?

I still consider it a bug that prost fails to use the bundled protoc on alpine without falling back the $PATH, but it's not something that's high on my list to fix, I will accept PRs fixing that as well though.

@danburkert Hit the bug, is it acceptable not to use the bundled if target_env = musl for now? At least before there are musl-compatible binaries.

@xhebox I recommend setting env PROTOC=protoc to get the behavior you want.

This choice has serious security implications. I can audit the packages installed on my system, they can all be traced back to sources. I can audit all my rust dependencies, again, the produced binaries are linked to sources. What I cannot do is audit a random binary blob, I have to trust both the upstream maintainers (and their build servers) and the prost maintainers.

Just in case anyone stumbles across this and gets the wrong impression, the prost project is not shipping a 'random' protoc binary.  The bundled binaries are taken directly from the upstream protobuf project using this script.  The binaries can thus be audited against the upstream release.  If there are security concerns with the upstream release, I suggest you take it there.  Ultimately if this is unsatisfactory, the env escape hatch is recommended.

@danburkert Yeah, I can set PROTOC somehow. But that No such file or directory tip is just too confusing. E.g. tikv/pprof-rs is using this project, then that error poped up.
It is not working by default, and I don't even know how to fix it before digging deep. I would prefer adding some switches to move env-protoc before the bundled, or not to use the bundled one on musl(it is not working anyway).
BTW, there is github.com/AdelieLinux/gcompat, which can make protoc running under musl-host linux. Do you consider grab a binary from alpine/void linux? And use it by LD_LOAD_LIBRARY_PATH if target_env = musl?

Nice!

Yep sorry I forgot to update this thread - I figured out there's a pretty bullet-proof way to fall back to the protoc on the $PATH on musl build hosts.  I also updated the error that occurs when protoc isn't invocable.  Both implemented in #410 .

This continues to be a major pain on NixOS hosts, for what its worth. Even though a perfectly working protoc binary is available in the $PATH, prost just falls over trying to run its own copy.

@nagisa I'm not familiar with NixOS, is there a cfg that can detect it reliably, similar to how #410 uses target_env = "musl"?

For my own edification - what's different about NixOS?  Does it not ship glibc?

Also you may want to take this to a new issue, it's easy for this stuff to get lost in the noise of a closed issue.

I did file an issue in the past (https://github.com/danburkert/prost/issues/182). Just wanted to add that the fix for musl is not exhaustive and doesn't help on certain other systems (i.e. is not a fix for #182 which is mentioned here)

@nagisa
  PROTOC="${pkgs.protobuf}/bin/protoc";
  PROTOC_INCLUDE="${pkgs.protobuf}/include";

gets around the weird blob execution.
Want to reiterate that running a third party binary blob is a security issue, and it's also completely unnecessary.

@danburkert NixOS ships glibc, but it has a completely different filesystem layout than most distributions (package paths are basically prefixed with an integrity hash of the package build code, and are completely immutable). So much so that even if the upstream maintainers made the protobuf binary statically linked, it still wouldn't work because the linux loader's location is also at such a path, and the default burnt-in location (/lib64/ld-linux-x86-64.so.2) doesn't work.

prost is a 5th-order dependency of something I'm trying to build and I just lost several hours to this issue on an Alpine build host, with the cryptic "no such file or directory" with no context because the bundled binary has the wrong loader for Alpine. Why does prost prefer its bundled protoc even if there's one on PATH?
It's really unpleasant to have random broken binaries shipped inside crates overriding the perfectly-working ones I've already provided in the environment. To be honest, it's really unpleasant to have random binaries shipped inside crates overriding my environment even if they worked fine.

I just hit this issue on NixOS as well. Thanks for the env var fix, it works!
A better error message would be appreciated though, as it also took me looking though strace to find the culprit was prost_build and ending up in this issue. :sweat_smile:


FindBugs XML report

FindBugsXmlOutputReport has been added. Tests are included.

@arturbosch @schalkms Could you please take a look?

Is the checkstyle XML report not sufficient?

@3flex Checkstyle reports don't have issue descriptions, but FindBugs - have

@arturbosch
FindBugs XML report can handle classes and methods. But I haven't found a way to get classes and methods from Detekt. So I decided to output only files and file positions.
I've tested the report against my own parser, but I've not tested the report against these libraries. Maybe it makes sense to think about creating such test... WDYT?

@remal yes please use https://github.com/tomasbjerre/violations-lib as testImplementation for detekt-api and test the parsing. They spend quite a bit on parsing Findbugs.


Mobile: vote descriptions overflow in some cases

https://gardens-staging.1hive.org/#/xdai/garden/0xf7ac40a5d0933e13b346ee611d9072b6095f43fc/vote/0

@0xGabi Tried to test this but cannot find any example of overflow. Can you help me find this?

In the above link that I shared when I am open the decision vote on an iPhone, I see the overflow similar to the image I shared. Is not a super big deal. Just wanted to keep track of the issue anyways.


Use as a Normal ESP32 Programmer

Hello and apologies, this is not an issue more of a question.
I am looking to convert a ESP32 device with onboard USB to be a ESP32 programmer, to use the RX, TX, GPIO and ENable pins on the target device in order to flash the target device.
I believe that with the USB Serial adapters, DTR and CTS are used to toggle the GPIO and Enable pins to initiate programming, and I was hoping to find a solution to do this just by using an ESP32 and no USB serial convertor or additional components.
I am using Arduino and are able to convert the device to act as a Serial Monitor, and even though I added code to detect a serial connection and put the device into bootload mode (hold GPIO low and toggle reset) esptool seems unable to communicate with the device and program it.
I may also post similar thread on the Arduino forum so apologies if any duplication.
Many Thanks
PeterC

Hey, sorry for the delay I didn't see this email earlier , I would think this library would certainly be able to help, maybe not as it is in it's current state but then again I have not tested it, it's designed to flash an esp32 with a file from an SD card so I would imagine it could work for you assuming tye connections are made the same as they are on the Arduino board i tested this with the Arduino nano 33 iot
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: pacmac @.>
Sent: Sunday, March 17, 2024 8:19:21 PM
To: winner10920/ESPSerialFlasher @.>
Cc: Subscribed @.***>
Subject: [winner10920/ESPSerialFlasher] Use as a Normal ESP32 Programmer (Issue #2)
Hello and apologies, this is not an issue more of a question.
I am looking to convert a ESP32 device with onboard USB to be a ESP32 programmer, to use the RX, TX, GPIO and ENable pins on the target device in order to flash the target device.
I believe that with the USB Serial adapters, DTR and CTS are used to toggle the GPIO and Enable pins to initiate programming, and I was hoping to find a solution to do this just by using an ESP32 and no USB serial convertor or additional components.
I am using Arduino and are able to convert the device to act as a Serial Monitor, and even though I added code to detect a serial connection and put the device into bootload mode (hold GPIO low and toggle reset) esptool seems unable to communicate with the device and program it.
I may also post similar thread on the Arduino forum so apologies if any duplication.
Many Thanks
PeterC
—
Reply to this email directly, view it on GitHubhttps://github.com/winner10920/ESPSerialFlasher/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARVDXTS7OULD6UBOOQJ7RV3YYYXITAVCNFSM6AAAAABE2UDVVWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4TAOJYGIZTENQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Generated layout tests fail on Windows

Bindgen automatically generates layout tests that assume pointer size and other platform specific values. To ensure compatibility with Windows, these tests should be disabled via --no-layout-tests on the bindgen command. The specific thing that fails is c_long, which assumes i64 on Linux but i32 on Windows. This makes the size tests fail.

Thank you Genna ! I'll add this soon.


fixed caching issue for POST requests to /api/observations/series

Before: POST request for a stat var returns the the wrong result due to caching
Requested: Count_Person

Got: SDG variable

After cache key correction:

could also we file a bug to make a test for this? thanks!

Added tracking bug here: b/348713165


PowerToys Run is default set ti disable

Microsoft PowerToys version
0.35.0
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Whenever system startup, the slider in the "PowerToys Run" sectin in the settings is set to disable. I always need top open the settings and enable PT Run in order to use it.
✔ Expected Behavior
Should be enabled persistently
❌ Actual Behavior
It does not save enabled setting
Other Software
No response

can you include "Report bug" zip?
Are you running PT as a different user?

Hi Crutkas,
I am not running as a different user. I have attached the zip file as requested
PowerToysReport_2021-04-20-08-47-44.zip

lets track this in https://github.com/microsoft/PowerToys/issues/10195


TYPE_free() does not document that TYPE_free(NULL) does nothing

Like the title says.  It looks like the intent is that it's never necessary to check for NULL before calling a TYPE_free() function, but the documentation for TYPE_free() doesn't say that, and in particular for the case I'm looking at the documentation for ASN1_INTEGER_free() doesn't say it.  If it's not documented, it's not safe to rely on.
I'm using 3.0.13, but I checked against the web master docs.

It certainly seems like a reasonable idea, would you be willing to submit a patch for this?

Documentation changes, mostly yes.  Confirming that every single *_free() function properly handles NULL... less so.

Yes, I'm referring specifically to documentation for the api calls you are interested in checking.
I'll assign this to you as a community issue

Documentation changes, mostly yes. Confirming that every single *_free() function properly handles NULL... less so.

All our free functions should properly handle NULL. If they don't that's a bug IMO. I have no problem with a generic statement somewhere saying that all free functions properly handle NULL.  Perhaps a good place would be in the "Library conventions" section of this page:
https://www.openssl.org/docs/manmaster/man7/ossl-guide-libraries-introduction.html

I've done the work, but I realized (and confirmed) that I would need to do corporate paperwork to contribute it.  I'm looking into having somebody who has already done the paperwork take it over.
A central statement in a library conventions page would be good, but it should probably also be on each man page since that's where one will look first.  It's already there on about half of them.
BTW, my inspection said that OPENSSL_INIT_free() and OSS_LIB_CTX_free() in FIPS-140 mode did not handle NULL.

BTW, my inspection said that OPENSSL_INIT_free() and OSS_LIB_CTX_free() in FIPS-140 mode did not handle NULL.

Interesting. They definitely should handle NULL. However OPENSSL_INIT_free() is not a public API function so this doesn't impact anything from a public docs perspective.
The FIPS version of OSSL_LIB_CTX_free() is also not the version of OSSL_LIB_CTX_free() which is the public API function. My analysis suggests that in any case it does (kind of accidentally) handle NULL correctly anyway. It should handle it more explicitly (ossl_lib_ctx_is_default(ctx) returns 0; this ctx->ischild bit isn't compiled in FIPS; context_deinit returns NULL if its passed NULL)

BTW, my inspection said that OPENSSL_INIT_free() and OSS_LIB_CTX_free() in FIPS-140 mode did not handle NULL.

OSSL_LIB_CTX_free() handles NULL even with FIPS_MODULE defined (which is purely internal code so does not matter anyway). The reason is that both context_deinit() and OPENSSL_free() handle NULL argument gracefully.
You're right that OPENSSL_INIT_free() needs to be fixed. (#24681)

Ah, indeed.  I didn't look at it deeply enough.
It works in non-FIPS-140 mode because ossl_lib_ctx_is_default() returns true and so OSSL_LIB_CTX_free() returns before reaching the if (ctx->child).
It works in FIPS-140 mode because the if (ctx->child) is ifdef'ed out and then the underlying functions handle it as you say.

(Sigh, and that's exactly what Matt said, but I didn't notice that there were two comments.)

I derived my list of functions to inspect from the public documentation.  OPENSSL_INIT_free() is documented here:
https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_INIT_free.html

make that: https://www.openssl.org/docs/manmaster/man3/OPENSSL_INIT_free.html

I derived my list of functions to inspect from the public documentation

Oh - you're right! I misread the code. Yeah that definitely needs fixing.

My coworker Vita Bátrla @batrla has already done the relevant corporate paperwork and will be taking over this change.  Thanks, Vita!

@jordanbrown 0if you could have her add a comment here, i'm happy to reassign it

Hi Neil, I'm going to work with Jordan and get a PR filed (probably next week).

Thank you, and I apologize, I didn't even think about my pronouns above

No worries about pronouns. I've just opened a PR. The change is ready from our side (mine, Jordan's). The tests completed fine. They were run in CI pipeline yesterday in my forked repo.

Thanks!


fix width of chat on wider layouts

The chat was set to 325px width I think, so I changed it to 24.5vw to accommodate people with larger screen sizes.

We’re not changing this at the moment.


using power-off module.

What say?

@kesne Actually we don't even need that cmd

Ahah, small modules FTW :+1:
I'll merge later, thank you :)
There was also a bug with the code, as @aratramba spotted it https://github.com/typicode/stop-server/issues/3

@typicode Thanks ;)
BTW, I am not using poweroff but shutdown :+1:

Merged :)
May have missed something as I thought it would be automatically closed.

Cool.


REPL command deliminator

What should be the delimiter between top-level commands, if any?
normalize 5;

normalize 5;;

In case it helps, I may wish to use ; at some point in the tactic language. I would be ok with ;; as an optional delimiter for toplevel commands, that is looked for when using an interactive interface.
Also open to alternatives; I am even open to a non-ugly mandatory separator.

@jonsterling
normalize 2 ⸎
normalize 2 ⨾
normalize 2 ⨟

How about some cool kind of white space character LOL

Like this?
normalize 2

How about some cool kind of white space character LOL

Be careful about what you are wishing for...


More than one tag from same docker label or env not allowed

When we use the option to convert Docker labels into tag or docker env into tags we like to have more than one tag from the same label.
For example, we like to have a service tag but also an application tag for compatibility with other subsystems.
Now problem is that when we define custom label to tag conversion and we like to get both tags from the same label we get only last one tag and only one. Same behavior with env to tags.
https://github.com/DataDog/datadog-agent/blob/master/pkg/tagger/collectors/docker_extract.go#L91
https://github.com/DataDog/datadog-agent/blob/master/pkg/tagger/collectors/docker_extract.go#L147
My question is can we change this behavior because of some duplicates allowed in some parts of Datadog, but still, this will produce other tags based on same source.

Hi @szibis
Thank you for opening this issue. Just to make sure I understand correctly, are you referring to docker labels as tags?
It it's the case, then yes currently the Agent expects a string to string mapping, I guess having a string to array of strings mapping would resolve it and would allow you to define multiple tag keys for a single label.
This is not supported currently but could be a valid feature request, please reach out to the support team to open the feature request.
Please note that you can also use the label com.datadoghq.ad.tags, it allows you to define as many custom tags as you want for the container and supports passing multiple tags with the same keys or values (requires Agent v7.20+)
com.datadoghq.ad.tags: '["<TAG_KEY_1>:<TAG_VALUE>", "<TAG_KEY_2>:<TAG_VALUE>"]'

Thanks!


Installing HAXM fails on windows-latest runner

Description
When attempting to install the HAXM in order to utilize hardware acceleration as required for running Android x86_64 emulators, the install fails
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Version: 20220911.1
Is it regression?
No
Expected behavior
Installing Intel haxm succeeds
Actual behavior
The following message is displayed
Intel HAXM installation failed!
For more details, please check the installation log: C:\Users\RUNNER~1\AppData\Local\Temp\haxm_install-202209[16](https://github.com/SensoftInc/kotlin_demo/actions/runs/3070730312/jobs/4960753853#step:7:17)_2106.log

Repro steps
As part of the workflow:
    - name: Create Android emulator
      run: |
        Invoke-WebRequest "https://github.com/intel/haxm/releases/download/v7.7.1/haxm-windows_v7_7_1.zip" -OutFile ".\haxm-windows_v7_7_1.zip"
        Expand-Archive ".\haxm-windows_v7_7_1.zip" "." -Force
        .\silent_install.bat
        sdkmanager --install "system-images;android-31;google_apis;x86_64"
        echo "no" | avdmanager --verbose create avd --force --name testAVD --abi google_apis/x86_64 --package 'system-images;android-31;google_apis;x86_64'

Close as https://github.com/actions/runner-images/issues/4023#issuecomment-913576338


Ignore file lock errors if unsupported, on Windows

Not all file systems support file locking; WSL’s network file system doesn’t seem to, and I don’t think other network file systems will, either (though I haven’t checked them). ERROR_INVALID_FUNCTION is Windows’ equivalent to Unix’s ENOTSUP and Linux’s ENOSYS which are checked just above.
Fixes #7511.

r? @Eh2406
(rust_highfive has picked a reviewer for you, use r? to override)

I’ve said that this fixes #7511, but it doesn’t completely solve the problem: it gets the Cargo part working, but rustc ICEs for a similar reason if incremental compilation is enabled (which it is by default for non-release builds). I’ve filed https://github.com/rust-lang/rust/issues/66513 for that. (See also https://github.com/rust-lang/cargo/pull/4817 for how to disable incremental compilation.)

The Windows test failure looks to be unrelated to my change.

@bors: r+
Thanks!

:pushpin: Commit 60aa78e18426b45fabffe577805b5f2a048c5c62 has been approved by alexcrichton

:hourglass: Testing commit 60aa78e18426b45fabffe577805b5f2a048c5c62 with merge<PHONE_NUMBER>cc8229236902d1d9579c43674bbb7b...

:broken_heart: Test failed - checks-azure

@bors: retry

:hourglass: Testing commit 60aa78e18426b45fabffe577805b5f2a048c5c62 with merge<PHONE_NUMBER>5b810f356a9fced923a01141d29b6c...

:sunny: Test successful - checks-azure
Approved by: alexcrichton
Pushing<PHONE_NUMBER>5b810f356a9fced923a01141d29b6c to master...


preinstall script not working on windows

if(!/yarn\\.js$/.test(process.env.npm_execpath))throw new Error(\"Use yarn\") doesn't work on a windows machine that is correctly configured to use yarn
process.env.npm_execpath will return the yarn.js path but the regex doesn't match

found solution here

Fixed


Can not declaration merging for default exported class

TypeScript Version:  2.1.5
Code
// A *self-contained* demonstration of the problem follows...
// ===== file Foo.ts =====
export default class Foo {
  hello() {
    console.log('Foo');
  }
}

// ===== file Bar.ts =====
import Foo from './Foo';

declare module './Foo' {
  interface Foo {
    add(x, y);
  }
}

// ERROR: 'add' does not exist in type Foo.
Foo.prototype.add = function (x, y) { return x + y; };

let f = new Foo();
f.hello();
f.add(3, 4);   // ERROR: 'add' does not exist in type Foo.

Expected behavior:
If the class Foo is exported without default in file Foo.ts, and then import {Foo} from './Foo',
it works correctly as example in doc http://www.typescriptlang.org/docs/handbook/declaration-merging.html
Hope import Foo same as import {Foo} behaviors.
Actual behavior:
ERROR message showed.

If I write both export Foo and export default Foo in Foo.ts, its works (both import Foo and import {Foo} works)
// File Foo.ts export class Foo { ... } export default Foo;

You can only augment "exported" declarations. Class Foo is exported as default, and not as Foo. so the name Foo does not exist outside the module.
It just happens that default is a reserved word, and can not used as an interface declaration name.
The TS compiler needs to allow export { Foo as default} in module augmentation.

@Zaibot this feature (module augmentation)  did not exist back then. So no.

Would fixing this address my problem with defining inner classes and interfaces on a default export? I get "Merged declaration 'Outer' cannot include a default export declaration."
mymodule.ts:
export default class Outer {
    //...
}

namespace Outer {
    export class Inner {
        //...
    }
}

myconsumer.ts:
import Outer from 'mymodule';

function whatevs(innie: Outer.Inner) {
    //...
}

I'm trying to keep my consumer code succinct, so I don't have code like:
import MetaOuter from 'mymodule';

function whatevs(innie: MetaOuter.Outer.Inner) {
    //...
}

(Actually, my preference is to do this with an inner interface in my particular situation, but I can't get it to work with an inner class either.)

My interim solution is to move the inner class out to its own module. I can give it a reasonable import name and still keep class references succinct. I guess I don't really need inner classes and interfaces.

P.S. How did I automatically unassign @yuit?

Ugh. Here's a prevalent use case for nested interfaces:
export default class MyController {
    constructor(options?: Options) {
        //...
    }
}

namespace MyController {
    export interface Options {
        //...
    }
}

Except you can't do it yet on default exports.
Are people using a different pattern? Just not using default exports?

I've stopped using default exports in most cases - partly due to this, and
also to make refactoring less painful
On Thu, Sep 28, 2017, 10:49 Joe Lapp<EMAIL_ADDRESS>wrote:

Ugh. Here's a prevalent use case for nested interfaces:
export default class MyController {
constructor(options?: Options) {
//...
}
}
namespace MyController {
export interface Options {
//...
}
}
Except you can't do it yet on default exports.
Are people using a different pattern? Just not using default exports?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/14080#issuecomment-332912883,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAChnSJ6MAONZ-j5pwNsuxcaos8l6rNsks5sm9wpgaJpZM4MBduT
.

Thanks @nevir. Is the issue with defaults and refactoring that a class is less likely to have a single name across the entire application? Is that also an argument for not exporting functions directly but instead making stateless functions static methods on exported classes?

Any time you export a default, you're effectively creating a new name - so
if you want to rename something globally, you have to search/replace for
it, and track all the imports that re-export it.  But by sticking to named
exports, various refactoring tools can follow that name all the way through
the code base 👍
On Fri, Sep 29, 2017 at 12:57 PM Joe Lapp<EMAIL_ADDRESS>wrote:

Thanks @nevir https://github.com/nevir. Is the issue with defaults and
refactoring that a class is less likely to have a single name across the
entire application? Is that also an argument for not exporting functions
directly but instead making stateless functions static methods on exported
classes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/14080#issuecomment-333223811,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAChnR1J5GO4IAiJhnQGefZc5XcMO-WJks5snUu-gaJpZM4MBduT
.

Is there a way for augmenting a module exported with export = though? I wasn't able to get it working.
i.e
knex.d.ts
interface Knex {
  test1: string;
}

export = Knex;

file.ts
declare module 'knex' {
  interface Knex {
    test2: string;
  }
}

default is a keyword of JS. By the way, you can export a new variable temporarily.
node_modules -> knex.ts
interface Knex {
  test1: string;
}

export = Knex;

custom knex.ts
import $knex from "knex";

const knex = $knex as typeof $knex & {
  test2: string;
}

export default knex;

I just figured out a workaround for this while trying to augment chart.js, which is declared as a Class and namespace, and exported with export =
node_modules @types/chart.js/index.d.ts
declare class Chart { ... }
declare namespace Chart { ... }
export = Chart;
export as namespace Chart;

my-typings.d.ts
import * as Chart from 'chart.js';

declare global {
  interface Chart {
      panZoom: (increment: number) => void;
  }
}

usage in my-file.ts
import * as Chart from 'chart.js';

const chart = new Chart({...});
chart.panZoom(5);

I don't know exactly why, but it works even if in my file I import as a different name import * as ChartX from 'chart.js', so it will handle any refactoring/renames you make.
I haven't tested if this also works with default exports.

Was going a bit insane trying to figure our what was happening. Here's a small reproducible:
/** @typedef {import('stream').Readable} */
/** @typedef {import('stream').Writable} Writable */

export default class MyClassName {

}

Merged declaration 'MyClassName' cannot include a default export declaration. Consider adding a separate 'export default MyClassName' declaration instead.ts(2652)

That's because /** @typedef {import('stream').Readable} */ is incomplete. Once I change it to /** @typedef {import('stream').Readable} Readable */ the error goes away. This is the reproducible with JS. I'm not sure there's a Typescript analogy.

Was going a bit insane trying to figure our what was happening. Here's a small reproducible:
/** @typedef {import('stream').Readable} */
/** @typedef {import('stream').Writable} Writable */

export default class MyClassName {

}

Merged declaration 'MyClassName' cannot include a default export declaration. Consider adding a separate 'export default MyClassName' declaration instead.ts(2652)

That's because /** @typedef {import('stream').Readable} */ is incomplete. Once I change it to /** @typedef {import('stream').Readable} Readable */ the error goes away. This is the reproducible with JS. I'm not sure there's a Typescript analogy.

It seems to be working with the following convoluted setup:
some-library-you-cant-modify/Foo.ts
// This is the original class. You can't augment it directly because it's a default export.
export default class Foo {
  existingProperty: number;
}

my-library/typings/Foo.ts
import Foo from 'some-library-you-cant-modify/Foo'

// just reexporting the same class, but this time it's not a default export
export { Foo };

my-library/typings/Foo.d.ts
import { Foo } from './Foo';

declare module './Foo' {
  interface Foo {
    myProperty: string; // class Foo is now augmented with this added property
  }
}

my-library/consumer.ts
// Notice I'm importing from the original library, it works fine anyway.
// This means you don't have to update any existing code.
import Foo from 'some-library-you-cant-modify/Foo';

let foo = new Foo();
foo.existingProperty = 42; // we obviously can still access original properties
foo.myProperty = ""; // the added property works fine too, no compilation error

You'll have to add your Foo.d.ts file in my-library/tsconfig.json:
{
  "files": [
    "typings/Foo.d.ts"
  ]
}

@neuoy solution kind of worked, but for me it broke other things 😓 Like building with rollup plugin typescript

When will this issue be fixed ？


Quickfix to "MissingIncludes" adds absolute path to '#include' directive

[Linking the associated stackoverflow post here]
Problem / Bug
I am using clangd with VSCode. Clangd offers the possibility to add missing includes. When doing so, it (sometimes? couldn´t figure out when) automatically adds the relative or absolute path to the include directive.
The latter causes problems when compiling on different OS's (in my case Linux and Termux (on my mobile)) as the absolute (system) paths are obviously different.
For example, instead of
#include "Header.h"
it will add
#include "/home/user/path/to/the/Header.h"
Question on stackoverflow
Of course I can manually delete the path, but I wonder:
Does someone know if there is a possibility to disable this behavior and make it omit the path?
I tried to google it, but unfortunately I couldn't find anything...
Thanks in advance
Minimal example
Structure:
./
- .clangd
- compile_commands.json
- bin/
- build/
- include/
--- Header.h
--- Subheader.h
- src/
--- main.cpp`

Contents:
// .clangd
Diagnostics:
  UnusedIncludes: Strict
  MissingIncludes: Strict

// Subheader.h
#ifndef IG20240815185417
#define IG20240815185417

struct Subheader {
    int i{2};
};

#endif

// Header.h
#ifndef IG20240520170135
#define IG20240520170135

#include "Subheader.h"

struct Header {
  Subheader sh{};
};

#endif

// main.cpp
#include "Header.h"

int main() {
  Header h{};
  Subheader sh{};
  return 0;
}

Compile command (with compile_commands.json creation):
clang++ -o build/main.o -c src/main.cpp -MJ build/main.o.json -I./include && clang++ -o bin/main.exe build/main.o && sed -e '1s/^/[\n/' -e '$s/,$/\n]/' build/*.o.json > compile_commands.json

Note that compile_commands.json will be created via the compile command. If it does not work on your machine, here is the basic compile command and the final content of the .json file. You will have to adjust the directory to match your system!
Compile command (without compile_commands.json creation):
clang++ -o build/main.o -c src/main.cpp -I./include && clang++ -o bin/main.exe build/main.o

// compile_commands.json
[
{ "directory": "/ABSOLUTE/PATH/TO/WORKING/DIRECTORY", "file": "src/main.cpp", "output": "build/main.o", "arguments": ["/usr/bin/clang++", "-xc++", "src/main.cpp", "-o", "build/main.o", "--driver-mode=g++", "-c", "-I", "./include", "--target=x86_64-pc-linux-gnu"]}
]

Observation:
When viewing main.cpp (in VSCode) it shows a blue squiggle line below Subheader, hinting that the respective header is missing / not directly included (but known via Header.h).
Note: When hovering the Subheader type keyword, the hover info panel states: provided by: "/path/to/working/directory/include/Subheader.h".
Doing the same on Header states: provided by: "Header.h"
When choosing the QuickFix option, it adds the include-directive like this:
#include "/path/to/working/directory/include/Subheader.h"
Logs
I[22:36:06.146] <-- textDocument/codeAction(39)
I[22:36:06.146] --> reply:textDocument/codeAction(39) 0 ms
I[22:36:06.146] --> textDocument/clangd.fileStatus
I[22:36:07.822] <-- textDocument/documentHighlight(40)
I[22:36:07.822] --> reply:textDocument/documentHighlight(40) 0 ms
I[22:36:07.822] --> textDocument/clangd.fileStatus
I[22:36:07.831] <-- textDocument/didChange
I[22:36:07.831] --> textDocument/clangd.fileStatus
I[22:36:07.855] <-- textDocument/codeAction(41)
I[22:36:07.855] ASTWorker building file /home/arch/coding/local_projects/cpp/test (copy 1)/src/main.cpp version 24 with command
[/home/arch/coding/local_projects/cpp/test (copy 1)]
/usr/bin/clang++ -xc++ -o build/main.o --driver-mode=g++ -c -I ./include --target=x86_64-pc-linux-gnu -resource-dir=/home/arch/.config/Code/User/globalStorage/llvm-vs-code-extensions.vscode-clangd/install/18.1.3/clangd_18.1.3/lib/clang/18 -- "/home/arch/coding/local_projects/cpp/test (copy 1)/src/main.cpp"
I[22:36:07.857] --> textDocument/clangd.fileStatus
I[22:36:07.860] --> textDocument/clangd.fileStatus
I[22:36:07.860] --> textDocument/publishDiagnostics
I[22:36:07.860] --> textDocument/inactiveRegions
I[22:36:07.860] --> textDocument/clangd.fileStatus
I[22:36:07.861] --> reply:textDocument/codeAction(41) 5 ms
I[22:36:07.861] --> textDocument/clangd.fileStatus
I[22:36:07.862] Built preamble of size 224364 for file /home/arch/coding/local_projects/cpp/test (copy 1)/src/main.cpp version 24 in 0.00 seconds
I[22:36:07.862] --> workspace/semanticTokens/refresh(5)
I[22:36:07.862] --> textDocument/clangd.fileStatus
I[22:36:07.862] <-- reply(5)
I[22:36:07.865] <-- textDocument/documentHighlight(42)
I[22:36:07.867] --> textDocument/publishDiagnostics
I[22:36:07.867] --> textDocument/inactiveRegions
I[22:36:07.867] --> reply:textDocument/documentHighlight(42) 2 ms
I[22:36:07.867] --> textDocument/clangd.fileStatus
I[22:36:07.878] <-- textDocument/semanticTokens/full/delta(43)
I[22:36:07.878] --> reply:textDocument/semanticTokens/full/delta(43) 0 ms
I[22:36:07.878] --> textDocument/clangd.fileStatus
I[22:36:08.032] <-- textDocument/foldingRange(44)
I[22:36:08.032] --> reply:textDocument/foldingRange(44) 0 ms
I[22:36:08.129] <-- textDocument/codeAction(45)
I[22:36:08.129] --> reply:textDocument/codeAction(45) 0 ms
I[22:36:08.129] --> textDocument/clangd.fileStatus
I[22:36:08.184] <-- textDocument/documentSymbol(46)
I[22:36:08.184] --> reply:textDocument/documentSymbol(46) 0 ms
I[22:36:08.184] --> textDocument/clangd.fileStatus
I[22:36:08.196] <-- textDocument/documentSymbol(47)
I[22:36:08.196] --> reply:textDocument/documentSymbol(47) 0 ms
I[22:36:08.196] --> textDocument/clangd.fileStatus
I[22:36:08.833] <-- textDocument/documentLink(48)
I[22:36:08.833] --> reply:textDocument/documentLink(48) 0 ms
I[22:36:08.833] --> textDocument/clangd.fileStatus
I[22:36:09.105] <-- textDocument/inlayHint(49)
I[22:36:09.105] --> reply:textDocument/inlayHint(49) 0 ms
I[22:36:09.105] --> textDocument/clangd.fileStatus

System information
Output of clangd --version:
clangd version 18.1.8
Features: linux
Platform: x86_64-pc-linux-gnu
Editor/LSP plugin:
AUR: visual-studio-code-bin
Operating system:
Archlinux

As per the suggestions provided via my (stackoverflow)[https://stackoverflow.com/questions/78875589/add-missing-includes-without-path/78894352#78894352] post:
I removed UnusedIncludes: Strict from .clangd, after which it won't show any hint or quickfix option at all. Therefore unfortunately this does note solve the issue.
Note: When hovering the Subheader type keyword, the hover info panel states: provided by: "/path/to/working/directory/include/Subheader.h". Hovering over Header instead states: provided by: "Header.h".
Edit: I just found out that removing the MissingIncludes: Strict line, but keeping the UnusedIncludes: Strict produces the expected results

I just found out that removing the MissingIncludes: Strict line, but keeping the UnusedIncludes: Strict produces the expected results


[ACC] Fix unexpected token error typo

There was a typo in an error message

Coverage remained the same at 77.131% when pulling e3f6592da710155f41ddfde733daf83d9ea4f039 on acconrad:acc-fix-yamerl-typo into 296b399f99babadc3e5aa1fdfe17f6cd8ba844aa on yakaz:master.

Thank you! Sorry for taking so long to merge it...


Unable to make anything appear

Ive tried messing with the configuration settings for multiple skills but i cant seem to get anything to pop up onto the screen. Not sure if maybe im doing something wrong.

I figured out the problem. Unchecking the days of the week caused it to appear.

Having same issue

Sorry missed this. Should be fixed at this point.


Fix the concurrent map writes error on CompositeOutput.

Fix: https://github.com/istio/istio/issues/18657
Add a mutex to protect CompositeOutput.

In response to a cherrypick label: new pull request created: #526


test issue for Github <-> Tracker integration link

This is to test that a new story on the CF-Abacus Tracker is created from this issue.

Yes. Seems it worked.
/cc @jsdelfino

Woohoo!

Nice... Now I do not need to worry about not creating corresponding work item at Pivotal Tracker.


Fix spider pipeline api

Codecov Report

Merging #63 into develop will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #63      +/-   ##
===========================================
+ Coverage    97.32%   97.40%   +0.07%
===========================================
  Files           27       27
  Lines         1644     1654      +10
===========================================
+ Hits          1600     1611      +11
+ Misses          44       43       -1

Impacted Files
Coverage Δ

multi_imbalance/resampling/spider.py
98.69% <100.00%> (+0.77%)
:arrow_up:

multi_imbalance/resampling/tests/test_spider.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473fd87...6bbc304. Read the comment docs.


COUNT(*) does not work as expected

Search before asking

[X] I have searched the EvaDB issues and found no similar bug report.

Bug
COUNT(*) throws an invalid column id error.

Environment
No response
Are you willing to submit a PR?

[x] Yes I'd like to help by submitting a PR!

Hello, I am planning to take this issue if no one is currently working on it for 4420 evadb project. Thanks!

Hello, I am planning to take this issue if no one is currently working on it for 4420 evadb project. Thanks!

Sounds good, thanks!

@jkim3663 sounds good, thanks!

@xzdandy  @pchunduri6  Hey everyone, I just wanted to note that COUNT() was creating BindingError even without the GROUP BY. E.g., "SELECT COUNT() FROM MyPDFs;" was also causing error, but now it is resolved. I'll update my PR's name to be more generic to also reflect this fix.


remove support of hidden_deprecated_use_alpha

Signed-off-by: Abhay Narayan Katare<EMAIL_ADDRESS>Commit Message: Another PR of type remove_v2_support. first PR is #16274
Additional Description: Removing support of hidden_deprecated_use_alpha
Risk Level: LOW
Testing: unit (i.e. bazel test under bazel test test/extensions/filters/http/ext_authz/... )
Docs Changes: NA
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Thanks for working on this! unsolicited reviews here :)
Maybe we can consider to clean up the code base a bit  further in this PR. I just did a quick search for keyword use_alpha
Just a few examples:

get rid of use_alpha default arg from function getVersionedMethodPath, getVersionedServiceFullName() in file envoy/test/test_common/utility.h and related caller sites (e.g. envoy/test/integration/hds_integration_test.cc)
get rid of default arg use_alpha from function const Protobuf::MethodDescriptor& getMethodDescriptorForVersion(..)

@tyxia Thanks for review it.
i think Yes. ideally code related to v2/v2alpha should also be removed , however looking comments at #16274
i specifically looking at keywords  "hidden_envoy_deprecated_*"
@htuch please suggest.

Yeah, I think in the case of ext_authz, the *use_alpha code is truly dead and we can delete it everywhere.

@htuch Ok. Thanks. Will get back ASAP

@htuch sorry for delay due to bad health :( . i will push changes ASAP

Sorry, seems some format issue :( . push the changes ASAP

@htuch please review


Currency

Currency dto, can be used to input several types of currency into price.

Beside 0xeeee... for ETH, where could BTC 0xbBbBBB... be implemented?

Beside 0xeeee... for ETH, where could BTC 0xbBbBBB... be implemented?

in Token


Add files via upload

@maximilianosinski krsplus-kl.txt I am sorry, I have to close the request without merging, because you made a mistake in a request and did not specify any filepath. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for your understanding!


Floating IP handling for OpenStack may be incorrect

It looks like our assumption of taking the first available external network and connecting routers to that network does not work in NeCTAR. This is because, when floating ips are created, they are associated with a specific external network, as shown here:
+---------------------+--------------------------------------+
| Field               | Value                                |
+---------------------+--------------------------------------+
| created_at          | 2017-07-27T11:44:07Z                 |
| description         |                                      |
| fixed_ip_address    | None                                 |
| floating_ip_address | <IP_ADDRESS>                        |
| floating_network_id | 058b38de-830a-46ab-9d95-7a614cb06f1b |
| id                  | 00fb871e-3dfc-404a-ae54-124ee70ccd24 |
| name                | <IP_ADDRESS>                        |
| port_id             | None                                 |
| project_id          | 5a0ec9b9aa86427081b6643bf57ad926     |
| revision_number     | 1                                    |
| router_id           | None                                 |
| status              | ACTIVE                               |
| updated_at          | 2017-07-27T11:44:07Z                 |
+---------------------+--------------------------------------+
(openstack-tools)nuwans-mbp-2:openstack-tools Nuwan$ openstack floating ip show 3fd5b8f9-86bf-4e72-b06f-5c96b826b3c1
+---------------------+--------------------------------------+
| Field               | Value                                |
+---------------------+--------------------------------------+
| created_at          | 2017-07-27T11:45:39Z                 |
| description         |                                      |
| fixed_ip_address    | <IP_ADDRESS>                            |
| floating_ip_address | <IP_ADDRESS>                       |
| floating_network_id | e48bdd06-cc3e-46e1-b7ea-64af43c74ef8 |
| id                  | 3fd5b8f9-86bf-4e72-b06f-5c96b826b3c1 |
| name                | <IP_ADDRESS>                       |
| port_id             | 479825c0-66b8-4fa5-99f5-9cb5b540ab20 |
| project_id          | 5a0ec9b9aa86427081b6643bf57ad926     |
| revision_number     | 2                                    |
| router_id           | 9cb527b3-f340-4715-921b-f5fadd163fd2 |
| status              | ACTIVE                               |
| updated_at          | 2017-11-09T08:55:44Z                 |
+---------------------+--------------------------------------+

The floating_network_id appears to be the id of the external network. Therefore, if the external network of the router, and the external network of the floating ip do not match, the launch fails with the following error:
Task failed: Unable to associate floating IP <IP_ADDRESS> to fixed IP <IP_ADDRESS> for instance f6adfada-247a-401e-a2b2-75a2b51b4861. Error: External network 058b38de-830a-46ab-9d95-7a614cb06f1b is not reachable from subnet 214fc6b9-788d-4f3b-9ba0-1d002890e7d2.  Therefore, cannot associate Port 479825c0-66b8-4fa5-99f5-9cb5b540ab20 with a Floating IP.

It looks like maybe the solution is to move floating ips under the internet gateway?

Another solution may be to connect all external networks to each subnet. This means that a router has to be created for each external network and attached to the subnet.

To be clear, by move under the internet gateway, you mean provider.networking.gateways.<gateway>.floating_ips.*?
Could we instead require a network when creating a floating IP and ignore it with the other providers (no other provider requires the network)?

I'm not sure we can support a network parameter consistently across providers. That's because the only valid networks will be external networks.

Sure but we have the .external property on the networks and it would need to be clear in the docs that the supplied param needs to be an external network. We can do a check and raise an exception of that's not the case.

Right, we could probably do that. However, I'm not sure that's desirable - the main reason being - that's another concept to learn, filter by etc whereas we've already put in some effort to hide the "external" property because it's an openstack only concept. I think it would be great if we could structurally enable the right behaviour, so that when you do create a floating ip, you'd be naturally inclined to attach it via the correct network. Since an openstack gateway == external network, that almost seems like the right place. I guess we should have have a more in-depth design discussion to weigh the pros and cons.

Spent a good chunk of time on this and best way for me to reason about it was to run through a typical usage scenario (basically, the one documented here: http://cloudbridge.cloudve.org/en/latest/topics/networking.html (under step 2)

Create network netX

Create subnet snX

Create an instance within snX (netX)

Create a router for netX

AWS: route table associated with netX
OS: router where the net is ignored

Attach snX to the router

AWS: create subnet snX association with the route table, which implicitly removes the subnet from the Main route table for netX
OS: associate snX w/ the router

Get an inet gtw for netX

AWS: create internet gateway, attach it to netX
OS: netX param is ignored; return the first external network, netY (this cannot be netX because netX is private while the inet gtw must be attached to an external network). See comment below in Step 8b → just choosing the first external network will not work here because the value here is just returned but not actually used until step 7b and at that point we may get Bad router request: Incompatible network. exception if that first network is not suitable. The network object does not contain any (obvious) way to discern which network is allowed to be used here but we should somehow be able to figure out which network is the default.

Attach router to gtw

AWS: already attached to netX, adds route to inet gtw
OS: attach to gtw, netY

Create a floating IP

AWS: no association with a network
OS: must be associated with a network and the first external network is assumed, which may be netZ; however, for the routing to work, it must be on the same network as the router, netY. Possibly an additional problem arises here with NeCTAR where the external property is set on most of the networks when queried via the API, yet when using the dashboard, only 3 networks are presented as viable options.

To have this work consistently on OS, we’d need to parameterize step 6 (inet gtw) with an external network and use that same network in step 8 (fip). However, this external network is different from the private netX initially created and used on AWS across the board so it would require the user to be aware of this difference and take the additional step, which introduces cloud-specific code.

After much debating, the conclusion is to stick with the initial suggestion and move floating IPs under the internet gateway. It conceptually does make sense but requires the user to become aware of an additional concept, which is a drawback.

Given we're now parameterizing gateways with a network, would it make sense to move gateways (and hence FIPs) under network? This came up as I tried to implement this new structure in the CloudLaunch API as getting a gateway (or a FIP) now needs a network. WIP branch available here https://github.com/CloudVE/djcloudbridge/tree/networking

I can't quite remember why we need to parameterize the internet gateway with the network again. Is it to help with attaching to the router? However, if we do need to do this, I see what you mean in terms of it being necessary to implement the cloudlaunch endpoint. In which case, we probably should?

I believe the reason we decided to parameterize the gateway with a network was because of OpenStack so that when a floating IP is being created, it is created on the same network as the one the gateway is connected to, which is required with OpenStack. Without parameterizing it, the user would need to make sure the two networks are the same. The initial implementation assumed there is only one external network and used it but we discovered that doesn't work on NeCTAR in particular. The following is the usage pattern:
net = networking.networks.create(...)
subnet = net.create(...)
vm = instances.create(subnet, ...)
router = networking.routers.create(net, ...)
router.attach_subnet(subnet)
gtw = networking.gateways.get_or_create(net, ...)
fip = gtw.create()
vm.add_floating_ip(fip)

This now ensures the gtw is attached to the same as the network fip is being created under. If we don't supply a network to the gateway, the logic needs to infer automatically which network to use.
Having gone though this now, it feels like we can omit the network as long as the FIP is nested under a gateway so it can match it. This will require an explicit attaching of a router to a network, which we initially used, so the logic would become:
...
gtw = networking.gateways.get_or_create()
router.attach_gateway(gtw)  # This step is new from above as it was automatic there
fip = gtw.create()
vm.add_floating_ip(fip)

Would this create issues down the line though, for scenarios where a FIP/gateway wants to be reused (vs. being created and used right away)?
Something like this:
subnet = get_subnet...
vm = create(subnet, ...)
gtw = networking.gateways.get_or_create()
fip = gtw.floating_ips.list()[0]
vm.add_floating_ip(fip)

Wouldn't this cause an issue if the returned gateway is not associated with the same network as the subnet used to launch the VM?
One problem that arrises if we nest gateways under the network is how do we retrieve gateways that are not attached to a network? Subnets, as an example of a resource that exists under the network, require (at the provider level) to be parameterized/created under a network. Gateways do not so we could have orphan gateways that we cannot access.

After a bit more discussion, we realized why the network parameter is necessary for the gateway and it's because of AWS. Without it, the notion of get_or_create_inet_gateway had no way to 'discover' an existing internet gateway that's properly connected. So short of picking a random one, we need the network to be able to filter the internet gateways for it vs. always creating a new one (as we did initially). Creating a new one each time was not sustainable given a long running scenario (e.g., launch an instance via CloudLaunch and keep it alive for days) would not have a way to get back the launch context and cleanup (e.g., the instance is manually deleted vs. via CloudLaunch).
The conclusion is to nest the gateways under network. This will have the side effect of not showing gateways that are not connected to a network (for AWS) but at least CloudBridge's implementation will attach the gateway to a network as soon as a gateway is created so only externally-created gateways that are not attached will be omitted. In the future, if deemed desirable, we can also add a gateways property to networking that would list all gateways irrespective of a network.

Related issue reported on launchpad in: https://bugs.launchpad.net/neutron/+bug/1743480

A workaround for the OpenStack bug above have been made in: https://github.com/gvlproject/cloudbridge/commit/7688d283fd401857fb7449c7dadc118a19d915aa
and https://github.com/gvlproject/cloudbridge/commit/879117a2a123e79623e26e7da2833c806e7381fb
I think this issue can be closed now.


Inconsistent release binary file permissions

I realized that the etcd binary of the v3.2.19 release doesn't have read or execute permission for others, while that of v3.2.18 has (our pipeline failed due to a permission denied error).
v3.3.4 also has rx for others, and binaries built with the build script also has it. I therefore assume that v3.2.19 lost those permissions accidentally for some reason. v3.1.14 also lacks rx for others as well.
yudai@yudai01% ls -al etcd*/etcd
-rwxr-x--- 1 yudai yudai 16356384 Apr 24 13:35 etcd-v3.1.14-linux-amd64/etcd
-rwxr-xr-x 1 yudai yudai 17837888 Mar 29 10:49 etcd-v3.2.18-linux-amd64/etcd
-rwxr-x--- 1 yudai yudai 17850176 Apr 24 14:18 etcd-v3.2.19-linux-amd64/etcd
-rwxr-x--- 1 yudai yudai 16558624 Apr 24 14:19 etcd-v3.2.19-linux-arm64/etcd
-rwxr-xr-x 1 yudai yudai 19262720 Apr 24 13:31 etcd-v3.3.4-linux-amd64/etcd

I think it's better to recover those rx if there is no particular reason to remove them.

/cc @jpbetz
@yudai Thanks for report. Another release is planned for next week. We will double-check on this.

Having a look now.

@yudai Was this the etcd-v3.2.19-linux-amd64.tar.gz release binary from https://github.com/coreos/etcd/releases/tag/v3.2.19?

@jpbetz yes. The one at https://github.com/coreos/etcd/releases/download/v3.2.19/etcd-v3.2.19-linux-amd64.tar.gz

@yudai Okay, I suspect my default umask of 022 is at fault. I'll fix.

Confirmed that umask was the problem. I've fixed our release script to always set the correct umask. This will be correct in all future releases.


Displaying the date of the newest available build on the download page.

What I mean by this is while the site mentions the builds being done nightly. It is not always the case.
An example, the latest Win64 build was done a few days ago on the 6th, but you wouldn't know whether or not the build updated until after you download it and unzip the contents (and then looking at the last modified date next to the Godot binary).
In turn it would really help if the date the build was done was also mentioned (because like all automatic build algorithms, the build is not guaranteed to have the last day's commits 100 percent of the time).

Perhaps if the build date was part of the filename

I recently added JSON manifests for each build (<file name>.manifest.json), which include the commit, build date (currently being added) and SHA-256 hash. I'll try to find a way to expose this information on the web page soon :slightly_smiling_face:


Add nightwatch end-to-end test for sign up form

Fixes #110
This adds a Nightwatch.js end-to-end test for the sign up form. With the site running locally, you can run the test with yarn e2e. The test just fills out all the fields in the form with valid data, checks a hidden checkbox that skips API submission of the data, then submits and makes sure the success page appears. I also added a pull request Github action that runs the test.

@ClydeDroid doesn't look like e2e tests are passing on the GitHub PR check 🤔

@maya Yep, I'm looking into it.


add validation for dns round robin endpoints

Signed-off-by: Rama Chavali<EMAIL_ADDRESS>Please provide a description of this PR:

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
c73f91365aea34c485cde95f3f5941660665f6e0
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
c73f91365aea34c485cde95f3f5941660665f6e0
link
true
/test unit-tests-arm64

unit-tests_istio
c73f91365aea34c485cde95f3f5941660665f6e0
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hold for comment

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
c73f91365aea34c485cde95f3f5941660665f6e0
link
true
/test unit-tests

unit-tests-arm64_istio
596f1fc4a515dd4332d15376fb2f93cd0df2d3ca
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/cherry-pick release-1.16

@GregHanson: new pull request created: #41950

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Use either -std=c++03 or -std=c++11

No intermediate pseudo-standards should be used when compiling.
The option -std=c++11 is used by default now.
Compile with make defines=PUGIXML_NO_CXX11 to use -std=c++03 instead.

-std=c++0x is used specifically for Travis as indicated by the comment in the makefile.
Your change disables testing of C++11 features on Travis.
In addition to that, my understanding is that by default gcc/clang use c++98; if there are any incompatibilities between c++03 and c++98 (not that I know of, but still), this will hide them - not sure why explicitly specifying -std is valuable?

P.S. Is the purpose of your change to use -std=c++11 instead of c++0x?

Thank you for your thoughts!
I'm going to change my branch to reflect your doubts.

-std=c++0x is used specifically for Travis as indicated by the comment in the makefile.

Yes, I know.

Your change disables testing of C++11 features on Travis.

That's a good point. I did not notice that there are C++11 features in pugixml. (I only grep'ed for PUGIXML_NO_CXX11 and did not find any occurrence. However, there are occurrences of #if __cplusplus.) Thanks for pointing that out.
However, I think a better solution would be to keep -std=c++11 and just use a better travis configuration.

In addition to that, my understanding is that by default gcc/clang use c++98;
if there are any incompatibilities between c++03 and c++98 (not that I know of, but still),
this will hide them

Hm, C++98 is another good point but I thought this is not important since the standard is so old.

not sure why explicitly specifying -std is valuable?

Because the compilers can then effectively check for standard compliance which might be important in order to work with compilers you have not tested.
For example, one commit in my branch was to add a newline, which is necessary by C++03.

P.S. Is the purpose of your change to use -std=c++11 instead of c++0x?

The purpose is to explicitly use a standard. I'm opposed to -std=c++0x because it is a set of vaguely defined features, changing from version to version of the used compiler. Setting -std=c++11 does also not guarantee that the compiler implementation provides all features, but it is a fully defined standard the compiler should comply, too.


[TRANSLATIONS]

[ ] Base README.md
[ ] Quizzes
[ ] Introduction base README

[ ] Defining Data Science README
[ ] Defining Data Science assignment
[ ] Ethics README
[ ] Ethics assignment
[ ] Defining Data README
[ ] Defining Data assignment
[ ] Stats and Probability README
[ ] Stats and Probability assignment

[ ] Working with Data base README

[ ] Relational Databases README
[ ] Relational Databases assignment
[ ] Non-Relational Data README
[ ] Non-Relational Data assignment
[ ] Python README
[ ] Python assignment
[ ] Data Preparation README
[ ] Data Preparation assignment

[ ] Vizualization base README

[ ] Quantities README
[ ] Quantities assignment
[ ] Distributions README
[ ] Distributions assignment
[ ] Proportions README
[ ] Proportions assignment
[ ] Relationships README
[ ] Relationships assignment
[ ] Meaningful Visualizations README
[ ] Meaningful Visualization assignment

[ ] Data Science Lifecycle base README

[ ] Introduction README
[ ] Introduction assignment
[ ] Analyzing README
[ ] Analyzing assignment
[ ] Communication README
[ ] Communication assignment

[ ] Data Science in the Cloud base README

[ ] Intro README
[ ] Intro assignment
[ ] Low Code README
[ ] Low Code  assignment
[ ] Azure README
[ ] Azure  assignment

[ ] Data Science in the Wild base README

[ ] Real World Examples README
[ ] Real World Examples assignment

Hi there.
I would love to contribute for the translations in Telugu. Please let me know if you are willing to accept the Telugu translations. If yes then I would like to take forward our discussion on this and start working on it. Looking forward for your reply.
Have a nice day.😃

@FuseAkhi I would like to take this on...


[rlgl] Load one custom shader and one default shader in LoadShader()

The title is not very clear, but what I'd like to be able to do is to call LoadShader with one NULL pointer and one valid path, and have it load the default shader for the NULL argument and load the shader at the given path.
An example: say I want to write a custom fragment shader but keep the default vertex shader, I could just write LoadShader(NULL, "custom.fs") and have it return a shader program that has the default vertex shader and my custom fragment shader.
Right now AFAIK I have to copy the default vertex shader and load it myself, it isn't a major annoyance but I think this can be improved :)
If you are okay with this proposition I think I can implement it myself and submit a PR.

Shaders are usually loaded in pairs but supporting a default vertex/fragment shader could be considered...
Checking the code is not a simple implementation because default vertex and fragment shaders are loaded in an isolated way to be linked in shader program and immediately deleted... Supporting that feature would require some modifications on several functions...
How would you do that? I think keeping the default VS/FS compiled ids is the way to go, just re-link in new program the already compiled default shaders in case of NULL.

Yup, since LoadShaderProgram deletes the shaders after loading I can only think of two options:

don't use LoadShaderProgram in LoadShaderDefault, duplicate the code instead and just save the shaders instead of freeing them. Not very pretty, adds code duplication.
just load the default shaders from source every time instead of saving the compiled ids. It is a bit wasteful, but not more than the current solution which is to copy the default shader into a file and load it.
I think the second option is reasonable even if not fully optimal. There is also a third option which is to reject this feature if you think it's too much of a hassle :)

Thinking about two other options:

Creating new function to LoadShaderPartial() for vertex/fragment shader loading to also avoid duplicate code inside LoadShaderProgram(); modifying LoadShaderProgram() to recive already compiled vertex/fragment shaders ids. Review default shader loading from that point.

Just store vertex/fragment shader ids inside Shader struct.

Thanks @nounoursheureux for the PR, I'll review some naming before closing this issue.

Reviewed on commit https://github.com/raysan5/raylib/commit/09228752ce2695baf79cbc2edccc60fabb38f783


Update README.md

Do not merge.
The Allow edits from maintainers box is checked.
This is an experiment to see if seperry53test can create a pull request. As seperry53test, I do not evne have Read permissions.

This change is

@heckj Can you do a review. Just kidding. I just wanted to see if seperry53test could request a review.

reviewing! I could even merge this totally amazing piece of work :-)
/lgtm

This is interesting. Even though I have extremely limited permissions, I was able to influence the Assignees list. By asking @heckj a question, I triggered the bot, and it assigned heckj.
I'm just kicking the tires here to see what the options are for establishing a reviewer. I think the options are fairly open ended.

@seperry53test actually, when I invoked the /lgtm in my review it assigned me - so I think it was my action, not yours, that triggered that

@heckj Yeah, that makes sense.


Improve config.tpl, several config values added

Added the following values to config.tpl to enable more config options, some are really important like email settings
"EnableGifPicker": {{ .Values.global.features.enableGifPicker.enabled }},
"SiteName": {{ .Values.global.siteName }},
"EnableTeamCreation": {{ .Values.global.features.teamCreation.enabled }},
"EnableOpenServer": {{ .Values.global.openServer.enabled }},
"RestrictCreationToDomains": {{ .Values.global.features.restrictCreationtoDomains }},
"EnableCustomBrand": {{ .Values.global.enableCustonBrand.enabled }},
"CustomBrandText": {{ .Values.global.customBrandText }},
"CustomDescriptionText": {{ .Values.global.customBrandDescriptionText }},
"MinimumLength": {{ .Values.global.passwordLength }},
"EnableFileAttachments": {{ .Values.global.features.enableFileAttachment.enabled }},
"EnableSignUpWithEmail": {{ .Values.emailSettings.enableSignUpWithEmail.enabled }},
"SendEmailNotifications": {{ .Values.emailSettings.sendEmailNotifications.enabled }},
"RequireEmailVerification": {{ .Values.emailSettings.requireEmailVerification.enabled }},
"FeedbackName": {{ .Values.emailSettings.feedbackName }},
"FeedbackEmail": {{ .Values.emailSettings.feedbackEmail }},
"FeedbackOrganization": {{ .Values.emailSettings.feedbackOrganization }},
"SMTPUsername": {{ .Values.emailSettings.SMTPUsername }},
"SMTPPassword": {{ .Values.emailSettings.SMTPPassword }},
"SMTPServer": {{ .Values.emailSettings.SMTPServer }},
"SMTPPort": {{ .Values.emailSettings.SMTPPort }},
"ConnectionSecurity": {{ .Values.emailSettings.connectionSecurity }},

Thanks @pgold30 for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@cpanato  I see, do you have an estimated date for that, may i help you with something?

@cpanato Can't we take this then merge it into ours?

Yes off course. I will check the build failure.

@cpanato thanks for your guidelines , i will made the changes requested tomorrow.

I see that you applied the changes! will close this, sry for not following up was traveling, im in berlin now


resource id in hex in R class

#1171
Use hex for the resource ids, I think It makes RE experience better.

I see some flaws in this PR:

Values changed only for fields generated by jadx, exist fields in R classes not affected
EncodedValue type supposed to be a raw decoded type (that is why it placed in jadx.api.plugins module), so changing it just for format output is not a good idea.

I think a straight approach is fine here:
ClassNode parentClass = cls.getParentClass();
if (parentClass != null && parentClass.getShortName().equals("R")
		&& encodedValue.getType() == EncodedType.ENCODED_INT) {
	// force hex format for Android resources ids
	code.add(String.format("0x%X", ((Integer) encodedValue.getValue())));
} else {
	annotationGen.encodeValue(cls.root(), code, encodedValue);
}

instead line at https://github.com/skylot/jadx/blob/4e5fac4b88e2d4a0a2b1b0f7270b569dc4de651f/jadx-core/src/main/java/jadx/core/codegen/ClassGen.java#L405
Other options are:

Mark R classes with additianal flag (like ANDROID_R_CLASS)
Mark every resource field with FORMAT_AS_HEX flag

Anyway, we will need some custom case for render format choice.
Also, I want to notice that this code will be changed as soon as java-input branch get merged, check here: https://github.com/skylot/jadx/blob/317a260ec9cea7ec324f01f7ddb4e8c49456c3fc/jadx-core/src/main/java/jadx/core/codegen/ClassGen.java#L413-L421

Hello, I had considered just patching to check if the class is R and was thinking maybe we would need to apply hex to other classes as well so I add a new field to EncodedValue.
Looks like this java-input new branch got some exciting things going on, so I think should leave this hex formatting job to you.
Good day  :D


Temporary Variable

Hi All,
If we have checkbox in the tableView. How to retrieve the particular row number or section  number. While  func didTap(_ checkBox: BEMCheckBox) {} . I can retrieve row number by setting checkBox.tag = rowNumber. There should something name of the checkbox or description.where We can set the row and section number.
Any alternative to  when the func didTap(_ checkBox: BEMCheckBox) {} called How to retrieve row number and section number for the table.
Thanks,
Booma

Hi @BoomaRajan,
This is actually a very generic problem that you're trying to solve, and it's not related to BEMCheckBox.
For example, you would run into the same problem if you used UIButtons instead of a checkbox.
Take a look at this SO issue for example: https://stackoverflow.com/questions/1802707/detecting-which-uibutton-was-pressed-in-a-uitableview

Thanks for your reply.
I have solved my issue . Below lines of code
cell.checkBox.tag = indexPath.row
cell.checkBox.accessibilityIdentifier = String(indexPath.section).
I would be nice if you have some variable to identify the checkbox


Search service is unreachable during indexing

I'm not sure why, but in prod/staging, the search service is unreachable during indexing.
This is not super critical as indexing is only ~10 minutes every day, and we have a fallback to javascript search on the client side, but still, it's bad UX.
It's not because of database connections, because the pool is more than large enough, and search shouldn't need DB connections anyway.
It might be because of the CPU limits we have on OpenShift, as indexing is very intensive in that regard? I wouldn't know if the bottleneck is on the OpenSearch side or the app side, though.
Ideally we'd try to reproduce this in dev mode first and try to find a solution from there.

This is no longer true now that we've adjusted the resources (CPU/memory/db connections) of the app and OpenSearch.
Closing.


Widen the center column

I know this commit is largely a style preference. However, at 600px width, code blocks could not render 80 columns (actually, far less). I do think this problem needs to be addressed.

@digitalcraftsman There are now several important changes in this branch. Could you review and merge them?

@digitalcraftsman This is a friendly reminder to review this branch. :)

Hello @npmccallum,
thank you very much for submitting this improvements and please excuse the long delay. With multiple exams in a row it can sometimes a bit hard to keep up with all the stuff on GitHub.
Cheers
Digitalcraftsman


feat: add development mode to use local served remoteEntry.js from st…

In order to facilitate local testing of get-starknet we add the capability of loading the remoteEntry.js from localhost:8082 when doing pnpm run dev. The original behaviour is kept when doing pnpm run prod.

Thx for the work, this PR should be target to up stream master, instead of fork repo, you may have to re-create the PR


Rewrite from CoffeeScript to plain JS

I'd love to contribute to this module but seeing codebase maintained in CoffeeScript puts me away.
Any chance to have it in plain JS in near future? (In light of ES6, there seems to be no future for CS anyway)

Done. In master

Great to see that. Thank you!


Description of SSL related options is incomplete/confusing

insecure_ssl (bool)

Specifies whether an insecure SSL connection is allowed. If set to false, Splunk does not verify an insecure server certificate. This parameter is set to false by default. Ensure parameter ca_file is not configured in order to allow insecure SSL connections when this value is set to true.

The portion in bold would be better written as: "If set to false, the plugin will verify the TLS server certificate presented by Splunk against the CA certificates provided by the ca_file/ca_path options; if verification fails, the connection will fail."
The portion in italics remains a mystery to me. I think it would be best to remove it. Looking at the code I can't see why setting ca_file would override the value of ssl_insecure.

ca_file (string)

The path to a file containing a PEM-format CA certificate.

Would be better written as: "The path to a file containing CA cerificates in PEM format. The plugin will verify the TLS server certificate presented by Splunk against the certificates in this file, unless verification is disabled by the ssl_insecure option."

ca_path (string)

The path to a directory containing CA certificates in PEM format.

Would be better written as: "The path to a directory containing CA certificates in PEM format. The plugin will verify the TLS server certificate presented by Splunk against the certificates in this file, unless verification is disabled by the ssl_insecure option."

Hey @yrro, thanks for suggesting doc changes. Can you raise PR with suggested doc changes? Any help would be appreciated.

Of course. I made a couple of other README improvements in the linked PR.


MongoDB.shell fails to install, even as admin

Brief description of your issue
MongoDB.shell fails to install, even as admin.
Steps to reproduce
In a console, even run as administrator:
winget install mongodb.shell

Expected behavior
Installation should succeed.
Actual behavior
The program says:
Installer failed with exit code: 1603

The log file produced contains this:
MSI (s) (A8:14) [19:30:01:127]: Product: MongoDB 4.2.8 2008R2Plus SSL (64 bit) -- Configuration failed.

MSI (s) (A8:14) [19:30:01:127]: Windows Installer volvió a configurar el producto. Nombre del producto: MongoDB 4.2.8 2008R2Plus SSL (64 bit). Versión del producto: 4.2.8. Idioma del producto: 1033. Fabricante: MongoDB Inc.. Resultado de la nueva configuración: 1603.

Environment
[winget --info]
Windows Package Manager v0.2.2521 Preview
Windows: Windows.Desktop v10.0.19041.508
Package: Microsoft.DesktopAppInstaller v1.11.2521.0

Well, previously I installed MongoDB.server, which reported success:
winget install mongodb.server

But in fact I can't find it installed. Under Program Files\MongoDB\Server\4.2 I can see some text files (README, etc), but no executables. (?). Can this be related to the failure of installing the shell?

I believe that this has been fixed since #19881 with the switch to the new MongoDB shell, mongosh.
The following works for me:
winget install mongodb.shell
C:\Users\jbo\AppData\Local\Programs\mongosh\mongosh.exe

Thanks for letting us know.


Set default repositories type to sources

Enhancement #1048
Repositories tab:
@bfred-it?tab=repositories
Converted to:
@bfred-it?tab=repositories&type=source

Access a user's repositories by source type using the Repositories tab.

Will above text be appropriate for it in readme file?

I help

It can be in Declutter as
Forks are hidden from a user's Repositories list (but they can still be shown)

Updated readme file with above text and image.

Looks good. Thank you, @dutiyesh :)


fix: catch exception on file open and release handle

fixes #114
@manthey ... this look good?

hmm.. getting lots of segfaults in tests here, and can reproduce locally too

had to use a different approach in the cpdef function here...  it would be great if you could confirm that this still works for you.  Thanks again for all of your help

No.  This latest commit leaves the file handle open.  Specifically, the line comp_type = self._attributes().get('compressionType') doesn't throw an exception (because self._attributes() is an empty dict), so we pass through the exception handler and get to trying to get the attributes from self.attributes which fails.  Maybe comp_type = self._attributes()['compressionType'] would be better to raise.

Specifically, the line comp_type = self._attributes().get('compressionType') doesn't throw an exception

oh right of course 🤦♂  sorry!

Maybe comp_type = self._attributes()['compressionType'] would be better to raise.

don't want to assert that compressionType is always there ... but i can check that attributes is at least length 6
i updated again... when you have a moment

Yes, this most recent version works.  I get "Unknown error reading attributes in file" and the file handle is properly closed.

Excellent.  Thanks again for your time.  Much appreciated


Flickering with Bootstrap Table

Hi! Excited to use this library! But I'm having difficulty implementing it with a bootstrap table. Could you help? Here's a reproduction in a jsbin: http://jsbin.com/quxuwe/edit?html,js,output
The issue is that flicker that I get when I'm dragging an item from one row to the next. Not only does it look bad, but occasionally, items will get out of sync and not be dropped in the right place. Thanks in advance!

Hi why can't you make this as a 'div' or an ul>li

Is there a good reason that it wont work as a table? Here's my first attempt at using a div instead... Not sure what I'm doing wrong, but it's not working this way either... http://jsbin.com/bilefe/edit?html,js,output

Hi there are lot of examples already provided.. u need refer one.
Not any big reason for not doing it for 'table', we copy the CSS of original drag element and apply it to the element that gets dragged. so it breaks there for 'table' elements. though it requires a small fix. not yet applied.

Ashik

I see, that makes sense... I guess I'll just have to style divs to appear like a table. Thanks.

I could really use some help with this. What am I doing wrong? I just can't seem to get this working... http://jsbin.com/quxuwe/4/edit?html,css,output

Will help you If I get some time. thanks.

Having the same problem here. However it seems to happen only on Chrome; on FF it works decently. If you can point me to what you think is the portion of the code responsible for the problem, I can take a look and send a PR.

the PR from @jonathanhedren is merged to the source. please check If this solves the problem.

Awesome @jonathanhedren! If you look at the original jsbin, you'll see that now the table gets squashed. Not sure why that's happening. I'll look at it more later. Thanks.

.as-sortable-item, .as-sortable-placeholder {
   display: block;
}

Your tr elements are displayed as blocks...

I see  "Uncaught HierarchyRequestError: Failed to execute 'appendChild' on 'Node': The new child element contains the parent." in console when i am using ng-sortable for table. I could replicate this in http://jsbin.com/quxuwe/4/edit?html,css,output as well. For divs, no issue. Any work around to fix this?

this should be fixed with #237

It's not quite solved for my use case (unless I'm mistaken) https://jsbin.com/quxuwe/edit?html,output


Update django and ci

This PR updates django and the ci from the project.

@nezhar Please review :+1:


Make HMR request timeout configurable

What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Changed existed one
If relevant, link to documentation update:
N/A
Summary
Trying to solve this https://github.com/webpack/webpack/issues/1700
Does this PR introduce a breaking change?
Nope
Other information

Thanks


Failing to create M:N relation in project.prisma

I'm receiving the following error when I execute prisma2 generate: Did not find a relation for those for model ExchangeMarket and field quote.
The models look like this:
model ExchangeMarket {
  id        String        @id @unique @default(cuid())
  exchange  Exchange
  base      Coin          @relation(name: "CoinMarkets")
  quote     Coin          @relation(name: "CoinQuoteMarkets")
  ticks     MarketTick[]
}

model Coin {
  id            String            @id @unique @default(cuid())
  symbol        String
  name          String            @unique
  logo          String?
  description   String
  platform      Coin?
  max           Float?
  markets       ExchangeMarket[]  @relation(name: "CoinMarkets")
  qmarkets      ExchangeMarket[]  @relation(name: "CoinQuoteMarkets")
  aggregates    AggregateTick[]
}

Am I using the @relation attribute in the correct way? If not, is it an issue with the generator?
There's also an issue on StackOverflow about this. I thought it was more appropriate to ask here.

I can't reproduce this with version<EMAIL_ADDRESS>binary version: 52ef5caca6a0ada3460c4ba01c9a73edd07ae9f.
I think we have fixed some bugs related to self-relation so can you please try this again?

I've reverted to Prisma V1 until it comes out of preview so I no longer have a project on prisma2. This is quite a common feature so I'm going to assume it's been fixed.


aws_lambda example fails due to missing role

Following the aws_lambda readme (see link below) the app does not work. In slack I got a an error message, and the CloudWatch logs reported found [user id redacted]:
b'{
"Message": "User: arn:aws:sts:::assumed-role/bolt_python_lambda_invocation/bolt_py_function is not authorized to perform: lambda:InvokeFunction on resource: arn:aws:lambda:eu-west-2::function:bolt_py_function because no identity-based policy allows the lambda:InvokeFunction action"
}'
I resolved this by adding the "AWSLambdaRole" to the user. So I suggest the following line in the docs needs to be updated, from:

Check the "AWSLambdaBasicExecutionRole" and "AWSLambdaExecute" policies

to:

Check the "AWSLambdaBasicExecutionRole", "AWSLambdaExecute" and "AWSLambdaRole" policies

Please note I am no AWS expert, it might be that this extra role renders one of the others redundant, I do not know! But I know this change is sufficient to make the example work :)
The page URLs

https://github.com/slackapi/bolt-python/blob/main/examples/aws_lambda/README.md

Hey @cp2423, thanks for pointing this out! Indeed you are right, Invoke is a requirement. I will update the docs shortly!


Missing ' ( ' in ' enum ' replacement

The missing \( did break our schema with column name print_seitenumbruch. The string contains enum that got replaced to print_seittext  NOT NULL DEFAULT 0'.

Thank you for the catch!
Actually the PR https://github.com/dumblob/mysql2sqlite/pull/71 already solves this but I am really out of time and thinking I should move this in community hands by creating an org here on GitHub and inviting a few admins.
Could you maybe thoroughly review the PR I linked to speed up its merging? Especially the unit tests are of paramount importance. They are new to this repo and they are meant to be run by CI before merging any PR. Do you think you could add the required CI instruction files to the PR to make this all work?
If so, I would in the mean time move this repo under a new org I will create and invite you and others as admins in the org to keep the bus factor (https://en.wikipedia.org/wiki/Bus_factor ) as high as possible :wink:.

I added the CI file.
@cspiegel-zepf  if you want to review my PR, it would be nice to have it merged after so many years :))))


Prevent initial animation

I have ensured all button properties are set during setup and only animated properties are set/changed during animation. This prevents the animation of the initial color as described in your issue.
Fixes #1

Thanks for working on this 🙌

Looks great 👌

https://github.com/sindresorhus/CustomButton/releases/tag/v1.0.0


Page vertical scroll bar does not work for DialogBox

Bug type
Component
Component name
MudDialog
What happened?
I know about Dialog with scrolling feature, but I expect a page vertical scrollbar, scrolls dialog box! It is a bad experience not to have the page scroll bar. also sometimes it scroll the background instead of dialog.
Expected behavior
Page vertical scroll bat should scroll dialog
Reproduction link
https://try.mudblazor.com/snippet/wacFPPbAOzwisQxE
Reproduction steps

Open Dialog
Try to scroll the page

Relevant log output
No response
Version (bug)
6.0.2
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You want to scroll the background page while dialog is open?
That is not how its designed to work, i don't know if you are coming from a windows platform environment or where you get the idea that its bad experience but mui, vuetify, antdesign everyone does it like we do, or rather we do like they do. And it is a part of the Material Design Guidelines: https://material.io/components/dialogs#behavior

You want to scroll the background page while the dialog is open?
No!, I want to use the page scroll bar to scroll the dialog which is open not the background! In widescreen when a dialog with a long height is open, I see users always try to scroll down the open dialog by page scroll bar, but instead of dialog, they see the background page is scrolling instead of dialog! The problem is exacerbated if the dialog is open in FullScreen mode.
I see many times that users just try to scroll the open dialog by the page scroll bar until they find it is not possible than looking desperate to find a way to scroll down to reach the submit button.

I really dont understand what you mean, can you show a video?

OK, I will send another Reproduction link via  try.mudblazor.com and will let you know.

Hi @Garderoben,
I have my work cut out to find the real issue.
The problem was raised because we had MudOverlay in many dialogs DialogContent nested components. I am not sure it is our fault to have it inside Dialog Content or a bug.
You can check the following link, open the dialog and try to scroll.
https://try.mudblazor.com/snippet/mEwblPbBOTptmLMO

It is a reminder as you close the issue.
Have you seen the issue?
Please let me know if you believe this issue is not a problem.

It is a reminder as you close the issue. Have you seen the issue?
Please let me know if you believe this issue is not a problem.

ah thank you now i understand it after your new example. yes i agree.

I updated my css:
<MudDialog Class="mud-dialog-width-lg" Style="max-height: 80vh;">
or
.mud-dialog {
    max-height: 80vh;
}

Was fixed by https://github.com/MudBlazor/MudBlazor/pull/4132, not sure why the issue is still open. Closing.


MAVLink app: Enable protocol version handshaking

This allows the ground control station or any other communication partner to query the supported versions. The key aspect is to send the response in MAVLink 2 framing to test the link with a MAVLink 2 framed message.
Before connecting QGC:
instance #0:
	mavlink chan: #0
	no telem status.
	flow control:	OFF
	rates:
	tx: 23.215 kB/s
	txerr: 0.000 kB/s
	rx: 0.000 kB/s
	rate mult: 1.000
	accepting commands: YES
	MAVLink version: 1
	transport protocol: UDP (14556)

After connecting QGC with this extension:
instance #0:
	GCS heartbeat:	988721 us ago
	mavlink chan: #0
	type:		GENERIC LINK OR RADIO
	flow control:	OFF
	rates:
	tx: 30.495 kB/s
	txerr: 0.000 kB/s
	rx: 0.021 kB/s
	rate mult: 1.000
	accepting commands: YES
	MAVLink version: 2
	transport protocol: UDP (14556)

@mhkabir This hopefully makes your life easier on RTK and @bkueng I hope this makes geofencing easier to work with.

Looks good. I was expecting the handshake to be more involved.
While I was looking around I didn't see mavlink v1.0 actually being used anywhere. Is that correct or did I miss something? Can we drop it?

The simulator interfaces still depend on v1. They use some hacked serialization which assumes v1 and need to be converted to using the correct library calls.
Searching for "v1.0/"

src/drivers/pwm_out_rc_in/pwm_out_rc_in.cpp:
   52  #include <systemlib/pwm_limit/pwm_limit.h>
   53  #include <dev_fs_lib_serial.h>
   54: #include <v1.0/checksum.h>
   55: #include <v1.0/mavlink_types.h>
   56: #include <v1.0/common/mavlink.h>
   57
   58

src/drivers/snapdragon_rc_pwm/snapdragon_rc_pwm.cpp:
   54  #include <uORB/topics/actuator_controls.h>
   55
   56: #include <v1.0/mavlink_types.h>
   57: #include <v1.0/common/mavlink.h>
   58
   59  #include "drivers/drv_pwm_output.h"

src/modules/simulator/simulator.h:
   58  #include <uORB/topics/optical_flow.h>
   59  #include <uORB/topics/distance_sensor.h>
   60: #include <v1.0/mavlink_types.h>
   61: #include <v1.0/common/mavlink.h>
   62  #include <geo/geo.h>
   63  namespace simulator

Tools/sitl_gazebo/include/gazebo_mavlink_interface.h:
   45  #include <sdf/sdf.hh>
   46
   47: #include "mavlink/v1.0/common/mavlink.h"
   48
   49  #include "gazebo/math/Vector3.hh"