[incubator/keycloak] Provide a way to override the keycloak.sh file

Is this a request for help?:
No

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature request

Version of Helm and Kubernetes:
Helm v2.8.2
Kubernetes 1.8.10
Which chart:
incubator/keycloak
What happened:
At the current status I have a need to override the keycloak.sh file in order to provide some custom scripts to be executed before keycloak starts. In a specific case, I need a trust store set, which for some reasons is not provided by default on the JBoss image.
What you expected to happen:
Would be nice if this script could be overridden through the chart values.yaml entry
How to reproduce it (as minimally and precisely as possible):
N/A
Anything else we need to know:
Feel free to approach me if you have any question.

Would it work for you if you can configure a script that can be run before keycloak.sh?

/assign

Care to review?
#5372

Awesome! Took a look at it now, and I really appreciate the features you added on it. Some of them actually was also in my radar, but you covered them already ( like the extraVolumes mount and the PodDisruptionBudget ).
Thank you, Really appreciated :) feel free to close this issue as soon as your PR gets merged!


Separate, explicit mention of gcc symlinking needed?

Use case is linuxbrew for users to install software in homedirs on a shared HPC system running RHEL6/CentOS6. Lack of gcc-version symlink in OS gcc packages means brew won't install things until such a symlink is made. The symlink instructions are currently buried in the standalone installation page, leading to some people trying to follow the whole stand-alone procedure, which causes more confusion.
Should there be an explicit mention of just the symlinking for CentOS/RHEL on http://brew.sh/linuxbrew/ and README.md?
No pull request as I saw mention in some existing ssues of possible attempts to fix the gcc symlink problem in the installer / ruby... don't want to waste anyone's (or my) time if this is imminent.

Yes, good idea. Linking was only necessary before if you wanted to override the default /usr/bin/gcc provided by your system, but I believe it's mandatory now on systems that don't provide a /usr/bin/gcc-4.? compiler. Debian does. I think Fedora and CentOS does not.

Yes, mandatory on at least CentOS6/7 and Fedora20/21 that I've tried
recently. I can create a PR if wanted?
On Wednesday, January 14, 2015, Shaun Jackman<EMAIL_ADDRESS>wrote:

Yes, good idea. Linking was only necessary before if you wanted to
override the default /usr/bin/gcc provided by your system, but I believe
it's mandatory now on systems that don't provide a /usr/bin/gcc-4.?
compiler. Debian does. I think Fedora and CentOS does not.
—
Reply to this email directly or view it on GitHub
https://github.com/Homebrew/linuxbrew/issues/244#issuecomment-70013218.

--
Sent from Gmail Mobile

Sure. The installer should handle this eventually, but updating docs is quicker.

Fixed by 63b1cd37d84e6d1ce57d8a118edfa77e05d66162.


*: PersistentVolume for etcd data

issue ref: https://github.com/coreos/etcd-operator/issues/1323
substitute https://github.com/coreos/etcd-operator/pull/1434
This PR only handles non-failure cases.

I tried it and it worked with following spec:
apiVersion: "etcd.database.coreos.com/v1beta2"
kind: "EtcdCluster"
metadata:
  name: "example"
spec:
  size: 3
  pod:
    persistentVolumeClaimSpec:
      accessModes: ["ReadWriteOnce"]
      resources:
        requests:
          storage: 512Mi
      storageClassName: standard

@sgotti Do you have time to take a review?

@hongchaodeng I also prefer the use of a pvc template like done by statefulsets and it was my original idea but then I noticed that the backup spec used the PVSource so I adapted to it.

Clarification: In case N (where N > 1) etcd clusters (deployed in the same namespace) where all of them use the similar PVC spec (example 10GB, readwriteonce). Would this PR as it stands today creates a risk where cluster A uses PVs meant to be used (or worse previously used) by cluster B?

cluster A uses PVs meant to be used (or worse previously used) by cluster B?

No. PV of cluster A will be owned (ownerRef) and used by members of cluster A only. Owner hierarchy would provide a clear separation.

Any progress on merging this?


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
ce8fceb -> deab5dd

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.30.4 -> v1.30.5

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.30.5
Compare Source
Bug Fixes

deps: update gomod (#788) (3f7c30b)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This PR is included in version 1.7.6 :tada:
The release is available on:

GitHub release
v1.7.6

Your semantic-release bot :package::rocket:


nm: Choose interface with default gateway for DNS configuration

Choose interface for IPv4/IPv6 default gateway for desired DNS configuration via nm.dns.choose_interfaces_for_dns_conf().

New patch uploaded.
Changes:

Renamed function to nm.dns.find_interfaces_for_dns_conf().

New patch uploaded.
Changes:

The nm.dns.find_interfaces_for_name_servers() don't look on name server, just return two interface name for IPv4 and IPv6 nameserver.
Constant nm.dns.DNS_PRIORITY_STATIC_BASE would be use as first DNS priority and rest could increase 1 from it.

New patch uploaded.
Changes:

Moved the route specific code to nm/route.py.


SwiftTool: introduce --experimental-destination-selector option

Depends on #5911.
Motivation:
With support for listing cross-compilation destinations with new swift experimental-destinations list command, we also need a way to actually use those. New --experimental-destination-selector option is added, through which users can either select a destination via an ID or a target triple.
Modifications:
Added new crossCompilationDestinationSelector to BuildOptions. Modified SwiftTool to select a destination from this selector string. Implemented destination selection based on a selector in DestinationsBundle.swift. Refactored Workspace.Location to create shared locations in a unified way. Added a simple test for destination selection.
Result:
Cross-compilation destinations can be selected when building a package.

@swift-ci please smoke test

@swift-ci please smoke test

I think @swift-ci doesn't support stacked PRs yet? I don't have any other explanation for current CI failures.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci smoke test


Add test for optimizers test coverage

Adds an extra test for test coverage of optimizers.
Merge after  #7918

Rebased

Jenkins, test this please

Jenkins CI test (for commit 01679eaf7c828fc8ec139fa78ea0c22a6562335e, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit 01679eaf7c828fc8ec139fa78ea0c22a6562335e, target branch master) succeeded!


GitHub repository does not link to the project website url

As part of our ongoing effort to ensure all the websites within the CNCF meet the CLOMonitor guidelines, we noticed that parallaxsecond does not pass the website criteria on CLOMonitor.
To fix this:
Edit parallaxsecond/community repository details. See Notary for example:

In the website section, add the link to the parallaxsecond website. See Notary for example:

Once done, feel free to close this issue as CLOMonitor will recrawl the page and update accordingly.

Changed, thanks :)!


Added preprocessor directives to make the project compile with GHC 9.2.4

This makes cuddle compile with ghc-9.2.4. I'm still getting an 'impossible' panic with ghc-9.2.8 though.

I've done this without CPP for now, though if it's impossible to get 8.10.7 to work without, I'll probably revisit.


Having multiple Groups causes one of them to hang

Describe the bug
I have observed that after adding a certain number of groups (typically 4) one of them hangs. The group that hangs seems to be the last one in the configuration tree.
My definition for "hang" in this situation is the next: The monitoring channels for the group do not change (i.e. frequency shows inf and iteration shows 0) and the group does not send or receive channels.
The log in /tmp/dsf.log does not report any related error.
Removing one of the other groups (and in some cases 2) causes the previously hung group to run just fine.
Using UDP plugin. I haven't had the chance to debug the source to identify if the problem is in the Core or in the UDP Plugin.
To Reproduce
I can share a .dsf file that reproduces the problem if needed. Here are the steps for a simple scenario that reproduces the problem:

Create 2 threads.
Add 2 groups to thread 0, one Tx and one Rx.
Add one transfer to each group, and one channel to each thread.
Add 2 groups to thread 1, one Tx and one Rx.
Add one transfer to each group, and one channel to each thread.
Configure IP addresses and network ports for the different items.
Deploy.
The last added group Monitoring channels hang and transfer is not communicating.

Expected behavior
I would guess that groups are not expected to hang, unless my configuration is wrong for some reason.
Screenshots
Desktop (please complete the following information):

LinuxRT-x64.
DSF 20.3.

Additional context
Add any other context about the problem here.

It seems like the issue is caused specifically by having multiple groups in a thread. This also reproduces on Windows.


Add unique ID to each test

💡 Summary
Add unique ID to tests in the .rego files.
Motivation and context
I'd like to be able to distinguish each test somehow. As it looks today multiple tests share the same Control, which seems to be the closest thing to an ID there is for now.
E.g.:
https://github.com/cisagov/ScubaGear/blob/af31c45f5d16e6cb53c5a2969a805e20655066de/Rego/SharepointConfig.rego#L97-L105
and:
https://github.com/cisagov/ScubaGear/blob/af31c45f5d16e6cb53c5a2969a805e20655066de/Rego/SharepointConfig.rego#L119-L127
Implementation notes
By either adding a new field, or update the existing Control to Sharepoint 2.4.1, we would be able to have something unique to refer to.
Acceptance criteria

[ ] Each test has an unique identifier

Hello @leitzler we are currently working on a schema to label each policy with a unique identifier. The baselines and ScubaGear will be updated with this in the Emerald release.

Unique identifiers are a part of #212 for the next release. This issue will be closed as a duplicate.


support for vi editing mode.

Would it be possible to add vi-editing mode to Ammonite? It's a really good REPL, but using pedestrian editing makes it really hard to quickly edit code.

Possible but I doubt I'll ever work on it, as a non-pro vim user.
I would gladly take a PR that implements some of the vim functionality though. Take a look at the ammonite-terminal subproject and see how it implements Readline-like and GUI-like editing. The same techniques can be used to implement vim-style editing


[Feature] typing pass-through

It would be cool if there was a config option for "proxying" or passing-through when a client is typing [in the DM] into the corresponding thread by showing that the bot is typing.
Maybe also a config option for proxying the other way, eg. Support staff starts typing and modmail starts typing in the DM, however off by default.

Not a bad idea! I'll keep this open until it's implemented.


Creating contact us schema

Creating contact us schema and API for same.

I would like to work on this issue under GSSOC'22


LL-2645 Deprecated firmware banner

(Manager): deprecated firmware banner with support contact link added
HODL: needs a live-common bump

Type
Feature
Context
LL-2645
Parts of the app affected / Test plan
Manager

@LFBarreto can we please make it: Device firmware version too old to be updated. Contact Ledger Support for a replacement.

@LFBarreto you can upgrade live-common

blocked by https://github.com/LedgerHQ/ledger-live-mobile/pull/1319

@LFBarreto we can un-HODL?


Adding tests to verify support for Large Tensors in additional Ops

Description
Added new C_Apis to support 64bit indexing
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@mxnet-label-bot add [pr-work-in-progress]

@mxnet-label-bot add [pr-awaiting-review]

@apeforest @ChaiBapchya this is now ready for review

@ChaiBapchya could you please review?


When code sign app.asar not built properly preload.js not found or initialize error

app.asar is not built properly after code signing the mac app. without code sign app.asar is built properly and the desktop works fine.

@bhattrahul14 Can you provide some more information? Can you post error logs?

@devinbinnie

without sign preload initialize but after code sign preload not initialize error throw on app

NOT FIXED YET PRELOAD ERROR WHEN RUN THE APP AFTER CODE SIGN


Remove restoration of ui status after RequestUserPresence call

The reply_to method always restores the status to Idle anyway after the syscall returns
Close #129

Restoring the status in all cases could work by wrapping the loop in a closure, so we can get the result, always restore status, and only then return.

It would still be overridden by the reply_to method anyway.


Wrong type when using $ref into computed

Describe the bug
I'm not really sure if this is a bug or I'm just missing something but when I use $ref I'm unable to have the right type in computed values

selection.value is (property) Ref<"static" | "relative" | "dynamic">.value: "static" | "relative" | "dynamic"
selection2 is const selection2: ReactiveVariable<"static"> | ReactiveVariable<"relative"> | ReactiveVariable<"dynamic">
I'm using vue 2.7.16 with typescript 4.8.4
const selection = ref<('static' | 'relative' | 'dynamic')>('dynamic');
const selection2 = $ref<('static' | 'relative' | 'dynamic')>('dynamic');

const component = $computed(() => {
  switch (selection.value) {
    case 'statics':
      return StaticSettings;
    case 'relative':
      return RelativeSettings;
    case 'dynamic':
      return DynamicSettings;
    default:
      return null;
  }

  const component2 = $computed(() => {
  switch (selection2) {
    case 'statics': // this is wrong but typescript is not complaining
      return StaticSettings;
    case 'relative':
      return RelativeSettings;
    case 'dynamic':
      return DynamicSettings;
    default:
      return null;
  }
});

Reproduction
in issue
System Info
System:
    OS: macOS 14.4.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 24.25 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.12.1 - ~/.nvm/versions/node/v18.12.1/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 8.19.2 - ~/.nvm/versions/node/v18.12.1/bin/npm
    pnpm: 7.30.1 - /usr/local/bin/pnpm
  Browsers:
    Chrome: 124.0.6367.62
    Safari: 17.4.1

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Can you provide your tsconfig.json?

Sure thing
{
  "compilerOptions": {
    "target": "esnext",
    "module": "esnext",
    "strict": true,
    "jsx": "preserve",
    "importHelpers": true,
    "moduleResolution": "node",
    "experimentalDecorators": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "resolveJsonModule": true,
    "forceConsistentCasingInFileNames": true,
    "useDefineForClassFields": true,
    "sourceMap": true,
    "baseUrl": ".",
    "types": [
      "webpack-env",
      "jest",
      "vuetify",
      "node",
      "unplugin-vue-macros/vue2-macros-global"
    ],
    "paths": {
      "@/*": [
        "src/*"
      ]
    },
    "lib": [
      "esnext",
      "dom",
      "dom.iterable",
      "scripthost"
    ]
  },
  "include": [
    "src/**/*.ts",
    "src/**/*.vue",
    "tests/**/*.ts"
  ],
  "exclude": [
    "src/api/services",
    "node_modules"
  ],
  "vueCompilerOptions": {
    "target": 2.7,
    "plugins": [
      "@vue/language-plugin-pug",
      "@vue-macros/volar/define-options",
      "@vue-macros/volar/define-models",
      "@vue-macros/volar/define-props",
      "@vue-macros/volar/define-props-refs",
      "@vue-macros/volar/define-slots"
    ],
    "vueMacros": {
      "defineModels": {
        "unified": true
      }
    }
  }
}

it works well in my project.
Can you provide a minimal reproducible ?

Sure, there must be a misconfiguration on my repo


Use NEURON's Random123 for connectivity and cell locations

already using noiseFromRandom123() for NetStims

ramcdougal [2:15 PM]
so... you probably shouldn't use Python's random module for parallel network models; it doesn't have a good way of generating independent random streams where the randomness is independent of the number of processors you're using
sidmitra [2:26 PM]
That is indeed a concern. I found this on stackexchange - https://scicomp.stackexchange.com/questions/24916/how-do-i-reliably-generate-random-numbers-in-python-distributed-across-multiple
[2:26]
It suggests that Randomstate be used instead.
[2:26]
https://pypi.python.org/pypi/randomstate/1.10.1
billl [2:29 PM]
NEURON(namely hines) has put lot of effort into this issue so well supported
salvadord [3:06 PM]
I did have issues but think solved them — tested results reproducible and independent of num cores — but will check again, thx

Currently randomizer seed is the sum of the conn seed plus  the postsyn gid (convergence), presyn gid (divergence), or 1st gids of pre and post pops (probability). However this leads to several issues:

sums of gids may coincide leading to same random stream (eg. pregid=1, postgid=2 and pregid=2,postgid=1)
convergence conn rules to same postsyn gid will generate same random streams. This shouldn't be an issue if the presyn pop is different ?
divergence conn rules from same presyn gid will generate same random streams.
prob conn rules will generate same random stream for same pre and post gids

salvadord [1 hour ago]
ramcdougal: so just checked that random conns are independent of num of cores; basically different postsyn cells get assigned to different nodes, and randomizer seed is function of postsyn cell
salvadord [1 hour ago]
but you are saying also maybe the random streams are not completely independent when using py’s random?
salvadord [45 minutes ago]
but don’t see how this problem is dependent on num of nodes, instead of simply an issue with py’s random ?
ramcdougal [19 minutes ago]
short answer is that it probably doesn't matter
ramcdougal [15 minutes ago]
mathematical answer is that: if you're using the Mersenne Twister (Python's default prng) and you set, say, seed(1) vs seed(2) what you're doing is jumping into different places in a single random stream. (There's a scrambling that happens that makes the locations not adjacent, but it's still the same stream... pull enough bits and they'll align.)
salvadord [14 minutes ago]
aah ic, thx makes sense!
ramcdougal [13 minutes ago]
This is why NEURON uses Random123 which is a cryptographic quality generator (Mersenne Twister is not) that creates independent random streams based on 3 ints. The usual way to do this is to have a global seed and then a per cell stream id.
ramcdougal [11 minutes ago]
For the comp bio course here, I recommended the randomstate module which also provides mathematically independent random streams
ramcdougal [11 minutes ago]
(not part of standard Python; has to be installed separately)
salvadord [9 minutes ago]
thanks cool I’ll check randomstate, maybe can include package within netpyne
ramcdougal [9 minutes ago]
(and so yes: doing it the way you're doing it is free of any issues with how many compute nodes... but doesn't avoid the issue with the random module itself)
salvadord [8 minutes ago]
also I just realized that if seed depends on global seed + postsyn gid, if you create 2 sets of conns to same postsyn cell, they will generate same random stream, right?
ramcdougal [8 minutes ago]
sounds like it
ramcdougal [7 minutes ago]
there may not be a reason to use randomstate since NEURON has Random123 to solve this exact problem
ramcdougal [6 minutes ago]
and so then: that takes multiple identifiers to select the stream: so you have a seed, a pre-cell, and a post-cell
salvadord [6 minutes ago]
random123 - right, I use for netstims etc, but avoided for conn since prefer not using Vectors()
ramcdougal [5 minutes ago]
also if I'm understanding your current approach, then the stream being fed to global seed 1's cell 2 is the same as that going to global seed 2's cell 1... so your separate simulations wouldn't be independent
salvadord [5 minutes ago]
multiple, pre, post - ic, although for example to select the random presyn cells for convergence connectivity could only use the post gid
ramcdougal [4 minutes ago]
Vectors? checks the python documentation that exists now
ramcdougal [4 minutes ago]
nope. confused. why Vectors? https://www.neuron.yale.edu/neuron/static/py_doc/programming/math/random.html#Random.Random123
salvadord [3 minutes ago]
understand approach seed 1's cell2 - yes! I also realized that and have an issue in github to fix
salvadord [1 minute ago]
vectors - I had only used Random123 with h.Vectors(), but will check py doc
salvadord [1 minute ago]
thanks!

ramcdougal [24 minutes ago]
oh: yeah, you can fill a Vector from a NEURON random stream, but... you can also pull a single number at a time, much like you can from Python's Random
salvadord [22 minutes ago]
great, guess doesn’t have equivalent of random.sample() ?
ramcdougal [17 minutes ago]
no... it's either fill a vector or something like [r.repick() for i in range(sample_size)]
ramcdougal [15 minutes ago]
arguably filling a Vector is basically the equivalent of random.sample, but admittedly slightly annoying to work with in Python. Is building the random list NetPyNE's responsibility or the user's? If the user's, you could provide a netpyne.sample(r, n) or something

rationale for rand.Random123(sim.id32('conn_str'), sim.id32('%d%d%d%d'%(len(preCellsTags), len(postCellsTags), sum(preCellsTags), sum(postCellsTags)), sim.cfg.seeds['conn'])):

sim.id32('conn_str'): different random streams for 'probability' vs 'convergence' vs 'divergence (in cases when have same set of pre and postsyn cells

sim.id32('%d%d%d%d'%(len(preCellsTags), len(postCellsTags), sum(preCellsTags), sum(postCellsTags)): different random streams for different subsets of pre and post cells; also different if reverse pre and post; can have duplicate streams if sum of gids coincide (eg. 1+7 = 2+6)

sim.cfg.seeds['conn']: different but reproducible random streams for each conn seed

salvadord [4:10 PM]
are you aware of any advantage of NEURON’s h.Random() over python’s RandomState?
ramcdougal [4:12 PM]
yes
RandomState is Mersenne Twister
salvadord [4:18 PM]
ok so h.Random() arguably better for large-scale sims right?
guess this paper talks about that but haven’t read: http://www.thesalmons.org/john/random123/papers/random123sc11.pdf
its just that performance analysis showed that seeding h.Random() for each pair of pre- and post-gids was really time-consuming, so was looking at alternatives
ramcdougal [9:31 AM]
hopefully you're using the h.Random.Random123?
salvadord [9:31 AM]
y
ramcdougal [9:31 AM]
so basically, yeah Salmon et al addresses the algorithm we use
Mersenne Twister isn't cryptographic qualkity, 600-something observations gives you a predictable sequence
salvadord [9:37 AM]
ok thanks, I’ll stick with Random123 then

Optimized performance by:

using a single seeding for each conn rule
seeding based on 1) hash of all preGids, 2) hash of all postGids, 3) global conn seed
hashing based on array-based fast method
use vec.setrand(r) to create vector of values; then convert to list
random values then mapped to preGid,postGid in dict

`
def hashList(obj):
return int(hashlib.md5(array.array('L', obj)).hexdigest()[0:8],16)
def generateRandsPrePost(self, pre, post):
from .. import sim
# initialize randomizer using unique hash of pre and post gids and global conn seed
self.rand.Random123(sim.hashList(sorted(pre)), sim.hashList(sorted(post)), sim.cfg.seeds['conn'])  #

# obtain rand value for pre,post pairs
lenPre = len(pre)
lenPost = len(post)
vec = sim.h.Vector(lenPre*lenPost)  # create Vector
self.rand.uniform(0,1)  # set unfiform distribution
vecList = list(vec.setrand(self.rand))  # fill in vector
allRands = {(preGid,postGid): vecList[(ipre*lenPost)+ipost] for ipre,preGid in enumerate(pre) for ipost,postGid in enumerate(post)}  # convert to dict

return allRands

`


Fix: Setting properties "av_previous_position", "av_position" and "av_duration" correctly

The values for the properties av_previous_position, av_position and av_duration (coming from local private member variables previousCursorPositionMillis, currentCursorPositionMillis and eventDurationMillis) are modified correctly and quite often in the MediaHelper - class
However, when creating an event with options = true (e. g. when creating a seek - event), these values were not used.
This lead to sending always the value 0 for these properties in all events received at the Piano backend.
This small fix sets the correct values while creating the event.

Thanks for the fix, @felix-ulmer


FMA can't support for dot3d

Describe the bug
FMA can't support for dot3d
Environment details
Non-tensor core

hi @Jasonmessage!

FMA can't support for dot3d

It should be able to do it after #4516 PR
There are also some adjustments in progress: #5469
Could you try fresh Triton and post a minimal reproducer if problem still exists?

Thanks!

@binarman
In addition，I have some confused issue about FMA，Hope to get your help：
FMA.cpp:
int mIdx = m / mShapePerCTATile * mSizePerThread + mm;
int nIdx = n / nShapePerCTATile * nSizePerThread + nn;
        int z = isCRow
                    ? mIdx * N / nShapePerCTATile * mSizePerThread + nIdx
                    : nIdx * M / mShapePerCTATile * nSizePerThread + mIdx;

int z = isCRow
? mIdx * N / nShapePerCTATile * mSizePerThread + nIdx

I think that z should equal to mIdx * N / nShapePerCTATile * nSizePerThread + nIdx when is CRow = 1, but why is mSizePerThread
Sincerely thanks！

@Jasonmessage
To be honest, I am not sure why it was implemented this way, it seems your variant is correct.
Note that this is an old code, it is replaced now. Better to look into #5469, current implementation is still faulty in some cases.


[Streaming] create NodeWebSocketFactory, refactor code, new tests

Description

botframework-streaming library changes:

Add NodeWebSocketFactoryBase (Abstract class)
Add NodeWebSocketFactory

botbuilder library changes:

BotframeworkAdapter removed watershed requirement
BotFrameworkAdapter now uses NodeWebSocketFactory as default NodeWebSocketFactoryBase

And other assorted refactorings...

Pull Request Test Coverage Report for Build 84375

32 of 35 (91.43%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0007%) to 87.681%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botframework-streaming/src/webSocket/nodeWebSocket.ts
7
8
87.5%

libraries/botbuilder/src/botFrameworkAdapter.ts
7
9
77.78%

Totals

Change from base Build 84211:
-0.0007%

Covered Lines:
4867

Relevant Lines:
5339

💛  - Coveralls


NAVBAR ADDED

added a navbar as seen on the official website

You changes are creating conflicts in the file. Please check again..


Add "WhatFonts" Chrome Extension for web Develooper

Is your feature request related to a problem? Please describe.
I'm always find it hard and time consuming when I come across a font on a website that I like, but the current tools I use to identify fonts are either inaccurate or not user-friendly. The process of finding out detailed font information, such as font family, size, weight, and style, is often cumbersome and time-consuming.
Describe the solution you'd like
I would like the WhatFonts for Web Developer extension to provide an easy-to-use tool that accurately identifies and displays detailed information about any font on a webpage. By simply hovering over text, users should be able to see the font name, size, weight, style, line height, and color.
Describe alternatives you've considered
I've considered using browser developer tools and other font identifier extensions, but they often require multiple steps to get the information and may not provide all the details in one place.
Additional context

What problem is this feature trying to solve?
This extension resolved the issue for web designers and web developer by just hovering on the text it give whole information for the class, font family, color, font size and more each and eevery info about what typ of fonts are in which atyle they are

@Sulagna-Dutta-Roy It is very useful extension for web developers, especially when writing CSS the fonts play main source.
can please assign with suitable labels.


dontEnum bug

https://developer.mozilla.org/en/ECMAScript_DontEnum_attribute
Documented there. See es5-shim for fix.

Fixed in the latest version, thanks.


Enable automatic deployment to npmjs

It would be useful to provide the same kind of automatic deployment of packages to npmjs (from commits and release tags) as we provide for other Accord Project repositories.

Deploy scripts are included in PR #30 and tested for the commit-based timestamped releases. It will have to wait for a GitHub release for more testing.

Seems to work! See 0.83.0 release.


Termination Reason MAX_EVENTS

Problem description
Hi all,
currently there is a Termination Reason MAX_EVENTS_REACHED defined. I know this max event logic from the other APIs. However there is no option to define this value. For example in Device Location geofencing subscriptions you can define the value  using "subscriptionMaxEvents": 5 in your request.
Expected behavior
I would propose to add the request parameter.
Alternative solution
Alternatively the Termination Reason could be removed.

as far as I remember, we did not found a use case for subscripting to a fixed number of simswap events.
At the same time the implementation would  require a state (the counter) to be kept (this would impact horizontal scalability of the service). Therefore the decision was - do no support even counter based subscription, while termination reason was kept to keep alignment with the general commonalities design.

I understand. Thank you for explaining!

@gregory1g @daniel-dierich I convert this issue in discussion as it did not required code change.


Fix the type generation path

Packages impacted by this PR

@azure/maps-search

Issues associated with this PR
Describe the problem that is addressed by this PR

Correct the path for type definition files else the users are not able to consume them.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
NA
Are there test cases added in this PR? (If not, why?)
NA
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[x] Added impacted package name to the issue description
[x] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


Help I'm noob :-:

How to install it because there no phar file?
@Falkirks

https://github.com/Falkirks/MineReset/releases/download/v3.0.2/MineReset_v3.0.2.phar


Driver does not start anymore after editing config.default.ini

Describe the bug
hi , im new
Gerbo GX
after install once enter : nano /data/etc/dbus-serialbattery/config.default.ini
it works but second time only half the info is there ?
also when i add any thing : nano /data/etc/dbus-serialbattery/config.ini
after reboot driver doesnt work any more ?
also i can only add one name for 1 daly bms ( 1 of 3 )
CUSTOM_BATTERY_NAMES = /dev/ttyACM0:DalyBMS1
CUSTOM_BATTERY_NAMES = /dev/ttyACM1:DalyBMS3
CUSTOM_BATTERY_NAMES = /dev/ttyACM2:DalyBMS2
if add to : nano /data/etc/dbus-serialbattery/config.ini  ( after reboot driver stops working )
How to reproduce
after install once enter : nano /data/etc/dbus-serialbattery/config.default.ini
it works but second time only half the info is there ?
also when i add any thing : nano /data/etc/dbus-serialbattery/config.ini
after reboot driver doesnt work any more ?
also i can only add one name for 1 daly bms ( 1 of 3 )
CUSTOM_BATTERY_NAMES = /dev/ttyACM0:DalyBMS1
CUSTOM_BATTERY_NAMES = /dev/ttyACM1:DalyBMS3
CUSTOM_BATTERY_NAMES = /dev/ttyACM2:DalyBMS2
if add to : nano /data/etc/dbus-serialbattery/config.ini  ( after reboot driver stops working )
Expected behavior
after install once enter : nano /data/etc/dbus-serialbattery/config.default.ini
it works but second time only half the info is there ?
also when i add any thing : nano /data/etc/dbus-serialbattery/config.ini
after reboot driver doesnt work any more ?
also i can only add one name for 1 daly bms ( 1 of 3 )
CUSTOM_BATTERY_NAMES = /dev/ttyACM0:DalyBMS1
CUSTOM_BATTERY_NAMES = /dev/ttyACM1:DalyBMS3
CUSTOM_BATTERY_NAMES = /dev/ttyACM2:DalyBMS2
if add to : nano /data/etc/dbus-serialbattery/config.ini  ( after reboot driver stops working )
Driver version
latest master
Venus OS device type
Cerbo GX
Venus OS version
3.12
BMS type
Daly Smart BMS
Cell count
16s
Connection type
Serial USB adapter to RS485
Config file
[DEFAULT]

; If you want to add custom values/settings, then check the values/settings you want to change in "config.default.ini"
; and insert them below to persist future driver updates.

; Example (remove the semicolon ";" to uncomment and activate the value/setting):
; MAX_BATTERY_CHARGE_CURRENT = 50.0
; MAX_BATTERY_DISCHARGE_CURRENT = 60.0

CUSTOM_BATTERY_NAMES = /dev/ttyACM0:SerialBattery(Daly)

Relevant log output
?

Any other information that may be helpful
incomplete ??
( /data/etc/dbus-serialbattery/config.default.ini  )
[DEFAULT]

; --------- Set logging level ---------
; ERROR: Only errors are logged
; WARNING: Errors and warnings are logged
; INFO: Errors, warnings and info messages are logged
; DEBUG: Errors, warnings, info and debug messages are logged
LOGGING = INFO

; --------- Battery Current limits ---------
MAX_BATTERY_CHARGE_CURRENT    = 100.0
MAX_BATTERY_DISCHARGE_CURRENT = 100.0

; --------- Cell Voltages ---------
; Description: Cell min/max voltages which are used to calculate the min/max battery voltage
; Example: 16 cells * 3.45V/cell = 55.2V max charge voltage. 16 cells * 2.90V = 46.4V min discharge voltage
MIN_CELL_VOLTAGE   = 2.900
; Max voltage (can seen as absorption voltage)
MAX_CELL_VOLTAGE   = 3.450
; Float voltage (can be seen as resting voltage)
FLOAT_CELL_VOLTAGE = 3.375

; --------- SOC reset voltage ---------
; Description: May be needed to reset the SoC to 100% once in a while for some BMS, because of SoC drift.
;              Specify the cell voltage where the SoC should be reset to 100% by the BMS.
;                - JKBMS: SoC is reset to 100% if one cell reaches OVP (over voltage protection) voltage
;              As you have to adopt this value to your system, I reccomend to start with
;              OVP voltage - 0.030 (see Example).
;                - Try to increase (add) by 0.005 in steps, if the system does not switch to float mode, even if
;                  the target voltage SOC_RESET_VOLTAGE * CELL_COUNT is reached.
;                - Try to decrease (lower) by 0.005 in steps, if the system hits the OVP too fast, before all
;                  cells could be balanced and the system goes into protection mode multiple times.
; Example: If OVP is 3.650, then start with 3.620 and increase/decrease by 0.005
; Note: The value has to be higher as the MAX_CELL_VOLTAGE
SOC_RESET_VOLTAGE  = 3.650
; Specify after how many days the soc reset voltage should be reached again
; The timer is reset when the soc reset voltage is reached
; Leave empty if you don't want to use this
; Example: Value is set to 15
; day 1: soc reset reached once
; day 16: soc reset reached twice
; day 31: soc reset not reached since it's very cloudy
; day 34: soc reset reached since the sun came out
; day 49: soc reset reached again, since last time it took 3 days to reach soc reset voltage
SOC_RESET_AFTER_DAYS =

; --------- Bluetooth BMS ---------
; Description: Specify the Bluetooth BMS and it's MAC address that you want to install. Leave emty to disable
; -- Available Bluetooth BMS:
; Jkbms_Ble, LltJbd_Ble
; Example for one BMS:
; BLUETOOTH_BMS = Jkbms_Ble C8:47:8C:00:00:00
; Example for multiple BMS:
; BLUETOOTH_BMS = Jkbms_Ble C8:47:8C:00:00:00, Jkbms_Ble C8:47:8C:00:00:11, Jkbms_Ble C8:47:8C:00:00:22
BLUETOOTH_BMS =

; --------- CAN BMS ---------
; Description: Specify the CAN port(s) where the BMS is connected to. Leave empty to disable
; -- Available CAN BMS:
; Daly_Can, Jkbms_Can
; Example for one CAN port:
; CAN_PORT = can0
; Example for multiple CAN ports:
; CAN_PORT = can0, can8, can9
CAN_PORT =

; --------- BMS disconnect behaviour ---------
; Description: Block charge and discharge when the communication to the BMS is lost. If you are removing the
;              BMS on purpose, then you have to restart the driver/system to reset the block.
; False: Charge and discharge is not blocked on BMS communication loss
; True: Charge and discharge is blocked on BMS communication loss, it's unblocked when connection is established
;       again or the driver/system is restarted
BLOCK_ON_DISCONNECT = False

; --------- Charge mode ---------
; Choose the mode for voltage / current limitations (True / False)
; False is a step mode: This is the default with limitations on hard boundary steps
; True is a linear mode:
;     For CCL and DCL the values between the steps are calculated for smoother values (by WaldemarFech)
;     For CVL max battery voltage is calculated dynamically in order that the max cell voltage is not exceeded
LINEAR_LIMITATION_ENABLE = True

; Specify in seconds how often the linear values should be recalculated
LINEAR_RECALCULATION_EVERY = 60
; Specify in percent when the linear values should be recalculated immediately
; Example: 5 for a immediate change, when the value changes by more than 5%
LINEAR_RECALCULATION_ON_PERC_CHANGE = 5

                                                                                [ Read 332 lines ]
^G Get Help       ^O Write Out      ^W Where Is       ^K Cut Text       ^J Justify        ^C Cur Pos        M-U Undo          M-A Mark Text     M-] To Bracket    M-Q Previous      ^B Back           ^◀ Prev Word      ^A Home           ^P Prev Line      M-▲ Scroll Up     ^▲ Prev Block     M-( Beg of Par
^X Exit           ^R Read File      ^\ Replace        ^U Paste Text     ^T To Spell       ^_ Go To Line     M-E

hi , sorry for the late response
i found out that i did something wrong indeed , problem is fixed ( naming the batteries i did wrong )
but now i found out that, using  firmware : 1.0.20231117 dev
when i use battery aggregator 2.4  ( pulguero )  with 3 batteries ( daly bms ) soon 4 ;)
the gerbo GX restarts randomly  ( about 10 times a day ) already going to place 100uf 100V condensator to be sure
but today i changed the battery monitor in systemsetup to multiplusII , and it seems to fix this rebooting problem , but ofc i want to use the aggregated serrial drivers ( the controlling bms in dvcc still is aggregator )
its caused due high cpu load i monitored it for a while via vrm -> dbus round trip time and every time it reboots its at wel obove 100ms ( 852ms some times ) but those are peaks  most of it is around 10-30 ms
and it mostly happends when discharging the batterys
thes are my settings :
( nano /data/etc/dbus-serialbattery/config.ini )
MAX_BATTERY_CHARGE_CURRENT = 75.0
MAX_BATTERY_DISCHARGE_CURRENT = 100.0
CUSTOM_BATTERY_NAMES = /dev/ttyACM0:DalyBMS1,/dev/ttyACM1:DalyBMS3,/dev/ttyACM2:DalyBMS2
INVERT_CURRENT_MEASUREMENT = -1
SOC_LOW_WARNING = 0
SOC_LOW_ALARM = 0
BMS_TYPE = Daly
im going to do some test today , maybe going back to driver : 1.0.20231116 ?

Check the CPU usage with htop. See https://github.com/Louisvdw/dbus-serialbattery/issues/808#issuecomment-1723817057

after about 10 mins log

this is when i set : system setup -> monitor back to aggregator  ( and ess optimized withouit battery life )

node red and signalK are disabled
it seems to increase cpu load, when ess set to optimized with no battery life
with battery life the load drops  ...
same goes when i set to keep batterys charge cpu load increase

Maybe the latest Venus OS Beta can help you. There a new MQTT Broker was implemented that has a much lower CPU usage.

i was thinking to do factory reset on the gerbo gx and instal from defaults , something must be wroing with these cpu loads ?

I have (had) similar issues with the cpu load.In my case it is happening with Nodered on Cerbo large version and the serial driver. Both working alone fine but not together. I did a factory reset on the Cerbo as well and it is not rebooting so often but still a very high cpu load

first i try , the latest venus os beta
after that i will try factory reset  , but its insane such expensive equipment has this kind of problems
and is it better to install serial driver non beta ? ( or cant i give names to batteries then ? )
and is it with everyone using this setup or is it a specific batch of gerbo gx ?

i already did find out that in a single phase configuration like mine
setting the  ess singephase regulation to single helped lower cpu load about 10%

in my case it happens with all drivers of serial driver and Cerbo gx and i tried severals. I'm running a 3ph ESS

so in worse case i need to go via RaspberryPi device ....

i just installed latest beta small on gerbogx , and it did drop some cpu load now , but still 80-99 % ...  ;(
but i saw in your case the reset to default did help ?

in my case it helped a bit but still in that range what you described.  If you have still such a high cpu load with the small image you should give it a try to setup the Cerbo to default

You could also try to optimize your Node-RED configuration. In the Victron Nodes there is now an option to trigger only, if the value has changed instead of every few seconds.

yes but the thing i installed small pakkge beta , without node red now , and still that high
but it worked this night an morning witout reboots , i do see the monitor reacts very slow also the animations on the display are slow ..

i also disabled the wifi acces point and bms can
and that dropped cpu load 20% at least


⚠ Bofrost.at has degraded performance

In 2f2a19c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2471 ms

Resolved: Bofrost.at performance has improved in c9e3677 after 13 minutes.


UndefinedError: 'monthNameShort' is undefined

Hey!
I have those annoying errors in Logs for a quite long time now and see that it still persist after several HA and Custom Header updates so I'm reporting that.
It's not a functional issue, I did not notice any unexpected behaviour apart from those log entries that seem to reappear a few times a day.
Here's the whole entry:
Logger: homeassistant.components.websocket_api.http.connection.140067111809168
Source: helpers/template.py:230
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 9:12:18 (1 occurrences)
Last logged: 9:12:18

Error handling message: Unknown error
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 228, in async_render
    return compiled.render(kwargs).strip()
  File "/usr/local/lib/python3.7/site-packages/jinja2/environment.py", line 1090, in render
    self.environment.handle_exception()
  File "/usr/local/lib/python3.7/site-packages/jinja2/environment.py", line 832, in handle_exception
    reraise(*rewrite_traceback_stack(source=source))
  File "/usr/local/lib/python3.7/site-packages/jinja2/_compat.py", line 28, in reraise
    raise value.with_traceback(tb)
  File "<template>", line 1, in top-level template code
  File "/usr/local/lib/python3.7/site-packages/jinja2/sandbox.py", line 384, in getitem
    return obj[argument]
jinja2.exceptions.UndefinedError: 'monthNameShort' is undefined

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/connection.py", line 95, in async_handle
    handler(self.hass, self, schema(msg))
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 265, in handle_render_template
    state_listener()
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 253, in state_listener
    msg["id"], {"result": template.async_render(variables)}
  File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 230, in async_render
    raise TemplateError(err)
homeassistant.exceptions.TemplateError: UndefinedError: 'monthNameShort' is undefined

And here's my CH config:
custom_header:
  button_text:
    options: >-
      {{ time }}
{{ dayNum }}  {{ monthNameShort[0]|upper }}{{
      monthNameShort[1:] }}
  chevrons: false
  compact_mode: true
  editor_warnings: false
  hide_help: false
  menu_hide: true
swipe_nav:
  prevent_default: true
  swipe_amount: 30
  wrap: true

No relevant errors in browser. Latest HA and CH version. Installation via HACS.

Looking into it, but is there any reason that you're manually capitalizing monthNameShort?
It should already be capitalized, so this should result in the same:
  button_text:
    options: >-
      {{ time }}
{{ dayNum }}  {{ monthNameShort }}

Thanks for quick reaction!
Unfortunately I'm using polish language and it's not capitalized when I use {{ monthNameShort }} :(  That's why I capitalized it manually.

Please, try the latest pre-release ( 1.5.2 ) and let me know if it helps. To install pre-releases with HACS use the menu on the bottom right of Custom Headers listing to reinstall and turn on "Show beta versions".

Ok. I've just reinstalled the pre-release 1.5.2 and it seems that the issue did not re-appear. I will check on that also later today and let you know about the outcome. Thanks! :)

Unfortunately it just re-appeared, twice:
Logger: homeassistant.components.websocket_api.http.connection.140149204098256
Source: helpers/template.py:230
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 15:29:25 (2 occurrences)
Last logged: 15:29:25

Error handling message: Unknown error
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 228, in async_render
    return compiled.render(kwargs).strip()
  File "/usr/local/lib/python3.7/site-packages/jinja2/environment.py", line 1090, in render
    self.environment.handle_exception()
  File "/usr/local/lib/python3.7/site-packages/jinja2/environment.py", line 832, in handle_exception
    reraise(*rewrite_traceback_stack(source=source))
  File "/usr/local/lib/python3.7/site-packages/jinja2/_compat.py", line 28, in reraise
    raise value.with_traceback(tb)
  File "<template>", line 1, in top-level template code
  File "/usr/local/lib/python3.7/site-packages/jinja2/sandbox.py", line 384, in getitem
    return obj[argument]
jinja2.exceptions.UndefinedError: 'monthNameShort' is undefined

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/connection.py", line 95, in async_handle
    handler(self.hass, self, schema(msg))
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 265, in handle_render_template
    state_listener()
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 253, in state_listener
    msg["id"], {"result": template.async_render(variables)}
  File "/usr/src/homeassistant/homeassistant/helpers/template.py", line 230, in async_render
    raise TemplateError(err)
homeassistant.exceptions.TemplateError: UndefinedError: 'monthNameShort' is undefined

Can't seem to recreate this one. Have added your config to my setup since you first reported this issue and have yet to see this error. I changed up how templates are returned to make sure that they are always defined as I thought that might be an issue, but it seems that didn't do it for you.
Some suggestions that may sound silly, but:

Make sure you're not using this template outside of CH
Double check that all devices with HA open have been refreshed
Ensure that when looking in your browsers dev tools console (F12) that version 1.5.2 is being reported.

Beyond that, is there any pattern to when this error pops up? Like only when entering edit mode or when switching to a new tab, etc.

I've even added a fake template variable that definitely doesn't exist in the template called {{ doesntExist }} to try and force the error, but I still get none.

Okay so if I use the fake variable with modifications like: {{ doesntExist[1:] }} I can force the issue, and if I downgrade to 1.5.1 I can get this error with just {{ monthNameShort[0]|upper }}.
So definitely check that you have closed/refreshed tabs/devices that have been open before the update and ensure that your console dev tools report version 1.5.2

Ok, that was my bad. So I did close all the HA tabs running in background in my browser, cleared the cache. I also checked if I'm running 1.5.2.
It seems that this issue does not pop-up any more. I will let you know if it will show up again – hopefully it will not :) Thanks!

Going to close this for now as I was able to recreate the issue and it seems resolved in the latest, but feel free to continue to post here if this continues to be an issue. Thanks!


fix(sqs): set corret handler event type

Current dependencies on/for this PR:

main

PR #43

PR #44

PR #45

PR #46

PR #47

PR #48

PR #49   👈

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

main

PR #43

PR #44

PR #45

PR #46

PR #47

PR #48

PR #49   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: o2hXZcUGA7x4CULUTBXA


#745 - [Manual] - Previous search results from cache are displayed in offline mode for a new people search request - Implemented

#745 Implemented

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Vadim-Bulavin sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Use deleted timestamp for deleting report comments

Problem
We created a new pattern for marking any report action as deleted by setting a deleted timestamp in the action's message in this issue. We used the pattern for scenarios where we delete report preview actions, but deleting report comments does not use this pattern yet.
Why is this important?
We should continue unifying deleting report actions around this pattern
Solution
Update the DeleteComment API to use the deleted timestamp
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011c0a7916533d0bbf
Upwork Job ID:<PHONE_NUMBER>180318208
Last Price Increase: 2024-03-14

To do this we'll probably need to write a new MarkActionDeleted Auth command and use it in our DeleteComment API. That will affect both OldDot and NewDot so I'll need to push changes to handle message.deleted in Web-E first.

On second thought, I can just update the UpdateReportComment command set deleted instead. That will preserve some other logic and permission checks for we have edits.

Web-E PR is merged and on it's way to staging

PRs deployed to Prod and Auth on the 26th, setting 7 day hold

Are there any payments due? We ended up with no frontend PRs, so I had nothing to review.

Are there any payments due? We ended up with no frontend PRs, so I had nothing to review.

Yeah this is right. We only pushed backend PRs to address this. This also isn't a regression so no need for new regression tests and etc. Closing this out as done


BEL-143952 Remove duplicate fields issue between body and query params.

@harmanpa does it look alright to push to master now?


Branching strategy

One branch per minor/ major (?) version.
Patches will be merged to this branch
Documentation builds on pulls/ pushes to these branches
Documentation versions: 0.1, 0.2, etc., latest, stable
Documentation docs.superduperdb.com defaults to stable

@blythed Why do we need both latest and stable versions ?
I would propose:

Latest: the most recent minor (or major) release. That includes pypi, dockerhub, and docs.
Nightly: the most recent github commit. That may include pypi and dockerhub, but not docs as it is susceptible to continuous changes.

Duplicate of #2210.


Exit atuin when pressing down arrow on most recent entry

It'd be great if pressing ▼ when the most recent entry to the history is highlighted would exit atuin and return to the shell prompt, similar to how history works in most shells (press up to check last command, then down to return to prompt)

Sounds reasonable to me


chore: fix lint

Codecov Report

Merging #1446 (f3e03fa) into master (3a1df3c) will increase coverage by 0.15%.
The diff coverage is 95.65%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
+ Coverage   63.76%   63.91%   +0.15%
==========================================
  Files         116      116
  Lines        8500     8508       +8
  Branches     1895     1891       -4
==========================================
+ Hits         5420     5438      +18
+ Misses       2823     2814       -9
+ Partials      257      256       -1

Impacted Files
Coverage Δ

packages/transactions/src/builders.ts
77.66% <ø> (ø)

packages/auth/src/provider.ts
68.18% <33.33%> (+13.00%)
:arrow_up:

packages/auth/src/userSession.ts
54.54% <50.00%> (+0.75%)
:arrow_up:

packages/auth/src/index.ts
100.00% <100.00%> (ø)

packages/auth/src/messages.ts
83.09% <100.00%> (+0.24%)
:arrow_up:

packages/stacking/src/index.ts
90.94% <100.00%> (+0.66%)
:arrow_up:

packages/transactions/src/clarity/index.ts
100.00% <100.00%> (ø)

...ckages/transactions/src/clarity/types/booleanCV.ts
100.00% <100.00%> (ø)

packages/transactions/src/constants.ts
99.29% <100.00%> (+0.04%)
:arrow_up:

packages/transactions/src/transaction.ts
78.78% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Cleanup project with regard to documentation

Was inspired when reviewing .NET Core 3 support

/cc @robertmuehsig

@kant2002 "This branch has conflicts that must be resolved"

@GregorBiswanger please take a look.


Diffusers Support Request!

Amazing work first of all!
Is there any hope for a diffusers version of LoRA and ControlNet weights?

I find that LoRAs trained on Civitai follow the same format of XLabs, the naming is quite different from diffusers.
I carefully check with the implementation of attention processor at DoubleStreamBlockProcessor and FluxAttnProcessor2_0, they seem to be slightly different, for example, the gate operation cannot find in diffusers. Correct me if I missed something here.

Hi! Thank you, yes, we have plans to support our models in Diffusers.

Hi there 👋 Sayak here from the diffusers team.
We now support it: https://github.com/huggingface/diffusers/pull/9295#issuecomment-2315254821.
Cc: @apolinario @yiyixu for visibility.


fix inability to use switch components w/keyboard controls

the switch component was originally using a display: none to hide visually hide the native checkbox element. Using this method resulted in the checkbox being inaccessible to keyboard users.
By updating the .switch input selector to instead utilize a ruleset that will shrink and visually hide the checkbox from view (see html5 boilerplate’s visuallyhidden class), the checkbox will remain visually hidden, but now allow keyboards and assistive technology to access it.
A new selector .switch input: focus + label was also added to provide visual context for when a switch component has received keyboard focus.  Without this selector there would be no indicator, for sighted keyboard users, that a switch was the currently focused element.

Thanks for fixing this. I'm not a huge fan of the dotted outline, so I'll look into making that customizable or something later on.

thought that might be the case, but figured getting a browser default in there was at least a first good step.  thanks for the merge.


Update impersonation_microsoft_quarantine_image.yml

Description
Requiring more NLU entities to be found in order to fire.
Associated samples
https://platform.sublimesecurity.com/messages/f98aebab61c444119d5b8a431a18baaef390c7936f391b1c886dbd8c69d23e32

/mql-mimic-exempt 476900, 245222
Neither are quarantine notifications.


Generator needs to automatically add suppresion for AZC0014 if JsonElement is used in tsp

Current Customizations-TypeSpec project fails for this reason and is temporarily suppressed.

The root cause is the customization codes which change the type from string to JsonElement: https://github.com/Azure/autorest.csharp/blob/12c70bbb980316bbfe0b0da34f19bc9fd7ba1bce/test/TestProjects/Customizations-TypeSpec/src/Customizations/ModelWithCustomizedProperties.cs#L47
Tsp definition is string: https://github.com/Azure/autorest.csharp/blob/12c70bbb980316bbfe0b0da34f19bc9fd7ba1bce/test/TestProjects/Customizations-TypeSpec/Customizations-TypeSpec.tsp#L77

There are a few ways to suppress this warning.

Inline suppression using #pragma or [SuppressMessage]:

precise
most complex logic since we need to locate the exact lines of codes to suppress
have to modify Customize codes which is not a good idea

<NoWarn> in csproj file
.editorconfig or XXX.Build.Props or .analyzerconfig: those files are definitely out of scope of generator

So, looks like modifying csproj is the way to go

@m-nash We've discussed this issue, and we recommend just close it as is. Because:

JsonElement is not specified in tsp, it's specified by custom codes.
To suppress in codes, we need to suppress in both generated codes and custom codes. We feel it's not comfortable to modify custom codes.

If we only suppress in generated codes and expect users to suppress in custom codes, the whole experience looks weird.

Modifying csproje or .editorconfig or XXX.Build.Props is quite out of the scope of generator.

Considering it's a low-probability case, we thought it might be OK to just let users to suppress it.


Refactor: Update redirect logic in Controller Action

Fixes https://github.com/CircuitVerse/CircuitVerse/issues/4636
Describe the changes you have made in this PR -  Replaced redundant calls to Utils.mail_notice with a single assignment to the notice variable, improving code readability.
Screenshots of the changes (If any) -
notice = Utils.mail_notice(group_member_params[:emails], group_member_emails, newly_added)

respond_to do |format|
  format.html { redirect_to group_path(@group), notice: notice }
end

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@tachyons @tanmoysrt please review this


Feature request: taproot support with export relative xpub

Hello!
As the title says, it could be possible to add taproot support?
This descriptor was added 2 years ago, and I would try to sign txs using this new address.
Also, it could be fine to add xpub export for taproot.
Thank you in advance

Hi @Ciugam , I would also like the possibility of Taproot Support (BIP86)

I would also like to see and use that feature. +1

Yay me as well ^_^

I would alsko like to see and use it.

Although Taproot adoption is currently ~0.46% and P2WPKH is ~28%, there are some privacy features in Taproot that make it very attractive despite its low adoption. I am curious whether there exists a roadmap when Taproot will be implemented on Jade.

https://github.com/Blockstream/green_android/issues/233#issuecomment-2506809249
https://github.com/Blockstream/gdk/tree/taproot


Crash on iOS

**Crash on application build to TF. **
There is a weird crash in app, which is build to TestFlight after update of reCAPTCHA to version 18.0.3.
It will crash randlomly on random places. I have a lot of stacktraces and its all over the place.
Integration Method
Select the method used to integrate with reCAPTCHA Mobile.

[ ] SPM

**SDK Version (e.g. 18.0.1): 18.0.3 **
Xcode version (please complete the following information)

Version Xcode 14.2

Device (please complete the following information):

Model: iPhone12 mini, iPhone 13 Pro
OS: 16.1, 16.2
Only real device

Additional context
I can send you privatelly a lot of stackt traces

Huh, could be some new XCode incompatibility.  To confirm:

This is only testflight, not a regular release build?
Have you tried an older Xcode version?
This is only 18.0.3?  Does 18.0.2 similarly crash?

And yes, the stack traces may be helpful.   Mail to my<EMAIL_ADDRESS>We will try to replicate.

I just ran a local build on XCode Version 14.2 (14C18) with 18.0.3 and it ran fine.  So more digging will be needed.

I tried only TestFlight, i have no quick way to build release build directly to physical device. I can investigate more at the end of the month, now it does not have priority.
But i Will send You stacktraces to email and if you have any question dont hesitate to ask.
Thank You

If you have any more information about this, let us know.  We haven't been able to reproduce it.

Quick question: Do you still have the protobuf library included?  It is wrapped inside of 18.0.3 and 18.1.0 and I am wondering if there is something going on with that.  It really shouldn't...f
But how often does this happen?  Of course if you can reduce it to a small reproduction we would be able to track it down faster since we haven't seen this.

You are right, there is no protobuf on this version.
And its happening on every run of the app, usually in mather of minutes after startup.
I will try to reproduce it on small app

We have the same problem. Random crashes on iOS when using Recaptcha Enterprise. Sometimes it's a Heap Corruption, but other times it's a different crash.

I was not able to simulate it on small app in the short time.

We have run Address Sanitizer (https://developer.apple.com/documentation/xcode/diagnosing-memory-thread-and-crash-issues-early) which doesn't reveal any memory issues thus far.  Perhaps you can run it as well and let me know if you find anything.

@SurglogsGithubUser We did fix a race condition in 18.1.0 involving the code from your stack traces.   Use 'thread info -s' to get extended information about the report.

Awesome!   A few questions: what exact sdk version are you using?   This is a release build?  Real device or simulator?  Is there any way you could strip this down to just the problem and share the project with us privately?

SDK Version: 18.1.0 (but I got the crash also on 18.0.3)

duplicate #38

Please leave further comments in #38


Chart not found in index prints error but does not exit

Output of helm version:
version.BuildInfo{Version:"v3.12.0", GitCommit:"c9f554d75773799f72ceef38c51210f1842a1dea", GitTreeState:"clean", GoVersion:"go1.20.3"}
When running helm upgrade with a version that exists in the helm registry but not in the index I get the error
Error: chart "my-chart" matching 1.2.3 not found in my-helm-registry index. (try 'helm repo update'): no chart version found for my-chart-1.2.3
This is expected, but the code returns 0 which indicates success.

The question is why here https://github.com/helm/helm/blob/main/pkg/repo/index.go#L162 we just continue and don't fail?

Can you give some more concrete reproduction steps please. I think I understand what you mean, but e.g. reproduction steps would help to clarify.

@gjenkins8
This happens on an indexing issue.
e.g.
A Helm registry that has

my-chart-1.2.2
my-chart-1.2.3
my-chart-1.2.4

And the index looks like this (missing 1.2.3)
apiVersion: v1
entries:
  my-chart:
  - apiVersion: v2
    created: 2023-11-20T13:15:39.344285121Z
    name: my-chart
    urls:
    - https://my-helm-registry/my-chart/my-chart-1.2.2.tgz
  - apiVersion: v2
    created: 2023-1-21T10:15:39.344285121Z
    name: my-chart
    urls:
    - https://my-helm-registry/my-chart/my-chart-1.2.4.tgz

I think (guess) Helm is hitting generic registry processing code within helm upgrade. If the upgrade can proceed, then it is arguable that their should not be a hard error there (and perhaps the message should be a "warning")

I think (guess) Helm is hitting generic registry processing code within helm upgrade. If the upgrade can proceed, then it is arguable that their should not be a hard error there (and perhaps the message should be a "warning")

The upgrade cannot proceed in this case as it cannot download the chart.
That's why I think it should also return a failure return code instead of just throwing this error and continuing

Any updates here?


Console being flooded

What is the output link of /viaversion dump?
http://hastebin.com/avohufaxon.json
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
LilyPad
How does this error happen? login? Using an item?
Console on almost all servers on our network are being flooded with the following message - http://prntscr.com/d7e6sh
Is there an error in the console? Use pastebin.com. Is there a kick message?
http://pastebin.com/Kas2tyRf

Just to update on this issue,
From what we've found you're possibly using a bad id for armour stands which causes this issue and also causes our system not to shift your armour stands (the issues are the same).
From our tests armour stands should be spawned on 1.8 with a Spawn Object packet with the id 78. For some reason you're using id 30? Which is actually a entity id and not an object id.

Gonna move this to #548 as same issue.


Modrinth says this mod is MIT license but there is no LICENSE file.

https://modrinth.com/mod/delightful
The page says: License: MIT
If you intended to use a free/open source license, you forgot to include the LICENSE file in the repository.

Thanks


Improve Capacity Range Feedback in Sunstone

Description
There is currently no feedback in Sunstone about the capacity range (CPU / Memory lower and upper bound, if set), which leads to a poor user experience.
Improvements:

[ ] If capacity range is set, only show a slider, and show the current selected value
[ ] In vCenter, slider can only be incremented in 4MB steps

Progress Status

[x] Branch created
[x] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

PRs to merge:

https://github.com/OpenNebula/one-ee/pull/1824


Align danger alert to match the markdown notation

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
Multiple articles.
What part(s) of the article would you like to see updated?
The articles

Using GitHub Enterprise Server with a load balancer
Cluster network configuration

are using the \data\reusables\enterprise_clustering\proxy_xff_firewall_warning.md reusable to display the following alert:

and the article

Monitoring the health of your cluster

has the following alert:

I would suggest to use the > [!CAUTION] markdown notation to align this alerts with other alerts (also as described here).

Additional information
I could provide a PR with a fix.

@akordowski I'm in agreement with you 💛 Feel free to open a PR whenever you have time!

@nguyenalex836  Here you can see the changes:

Using GitHub Enterprise Server with a load balancer
Cluster network configuration
Monitoring the health of your cluster


Sctp.chained data chunks

This PR fixes sctp data chunk parsing and serialization mentioned in #347, when sctp has bundled data chunks.

@googlebot I signed it!
On Sun, Oct 18, 2020, 14:39 google-cla[bot]<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version https://opensource.google/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

ℹ Googlers: Go here
https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogle%2Fgopacket%2Fpull%2F835
for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/gopacket/pull/835#issuecomment-711135909, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AGH755RT5BE67GOP3DDDKSLSLKSUZANCNFSM4SU555QA
.

@nyrzhun is there a way to access sctpdata layers without looping on all layers in packet?


Support snapshot 08-04 and c7 0.12.1

some packages have an obsolete .travis.yml build instructions, could you also update it?
here is the new one: https://github.com/Zewo/Base64/blob/master/.travis.yml

@antonmes fixed
Can you also review Zewo/POSIXRegex#5?


Site url issue on installation (missing scheme)

Steps to reproduce:

Install new install of Helpy
In the onboarding screens, for the 'Site Url' field, enter your domain without a scheme (e.g. example.com)
After installation, go to Settings → General and edit some settings (e.g.  change the site name)
Click 'Save Settings'
Note the error on the top of the page "The given url is invalid"

You can fix this error by inserting a scheme (e.g. https:// or http://) Site URL field on that settings page. Suggested solutions:

Improve the message 'The given url is invalid'. Change to 'The Site URL entered is invalid. Ensure you also enter the URL scheme (e.g http:// or https://)'
In the onboarding screen, validate the field to ensure a scheme is entered (if a scheme isn't entered show an error saying "please enter your URL scheme (e.g. http or https)
In the onboarding screen use a placeholder text that contains a scheme (to give people a hing) For example, use a placeholder: e.g. https://www.example.com

Edit: I actually spent hours debugging this issue because I thought it was a reverse proxy (proxy_host) problem with my upstream NGINX proxy. Turns out it was as simple as adding a https to the url!

Thanks for submitting this @pjrobertson

No problem, glad to help (a tiny amount) to making this awesome OS platform a little bit better! Sorry I don't have the time to submit the patch myself.


Disk I/O error on NFS

When using the app on a cluster I occasionally get a disk I/O error (screenshot attached), suggesting an issue with the disk caching we're using to store the computed dataframes on NFS.

My 10c here is that the SQL based approach is adding some unnecessary complexity, with file locks and so on (which NFS doesn't like). A simple file-based approach would be simpler and more debuggable.


Update main.py

Clean up code.

This violates #3, it was PEP8 compliant earlier. Refer to: https://stackoverflow.com/questions/24271961/is-there-anything-bad-about-having-multiple-imports-on-one-line/25027300, I'm going to close this PR and you're free to put up a new one instead.

Sir
Thank you very much for this information. I'll take care from the next time.
Sudhansh
On Thu, 13 Dec 2018, 16:59 Vineet Jiji Cherian<EMAIL_ADDRESS>wrote:

This violates #3 https://github.com/vineetjc/pygame-Coin-Fall-/issues/3,
it was PEP8 compliant earlier. Refer to:
https://stackoverflow.com/questions/24271961/is-there-anything-bad-about-having-multiple-imports-on-one-line/25027300,
I'm going to close this PR and you're free to put up a new one instead.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vineetjc/pygame-Coin-Fall-/pull/42#issuecomment-446959829,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ap-CpoXIEXp-z0ztM4mWa_R4ZqUF_GA1ks5u4k8vgaJpZM4ZN6uC
.


[velodyne-decoder] New port

Adds a port for velodyne-decoder: https://github.com/valgur/velodyne_decoder

[x] Changes comply with the maintainer guide.
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

@microsoft-github-policy-service agree

The usage test passed on x64-windows (header files found):
velodyne-decoder provides CMake targets:

find_package(velodyne_decoder CONFIG REQUIRED)
target_link_libraries(main PRIVATE velodyne_decoder::velodyne_decoder)


PeoplePicker Suggested People not loading after first selection

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!
Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.
Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
Please specify what version of the library you are using: [1.8.0]
My package.json:
"dependencies": {
"@microsoft/sp-core-library": "~1.4.1",
"@microsoft/sp-lodash-subset": "~1.4.1",
"@microsoft/sp-office-ui-fabric-core": "~1.4.1",
"@microsoft/sp-webpart-base": "~1.4.1",
"@pnp/common": "^1.0.4",
"@pnp/logging": "^1.0.4",
"@pnp/odata": "^1.0.4",
"@pnp/sp": "^1.0.4",
"@pnp/spfx-controls-react": "1.8.0",
"@types/es6-collections": "^0.5.31",
"@types/react": "15.6.6",
"@types/react-dnd": "~2.0.36",
"@types/react-dom": "15.5.6",
"@types/webpack-env": ">=1.12.1 <1.14.0",
"immutable": "^3.8.2",
"moment": "~2.22.1",
"react": "15.6.2",
"react-dnd": "~2.6.0",
"react-dnd-html5-backend": "~2.6.0",
"react-dom": "15.6.2",
"react-redux": "^5.0.7",
"redux-logger": "^3.0.6",
"redux-thunk": "^2.2.0",
"reselect": "^3.0.1"
}
Expected / Desired Behavior / Question
The PeoplePicker should show a new list of suggested people after a selection was made.
Observed Behavior
Configured the PeoplePicker to allow 5 selections. The first selection works fine, a list of suggested people are shown and I am able to select. However, after this first selection, the suggested people list won´t reload and I need to enter the user email addresses manually. I imagine this is not the intended behaviour?
Steps to Reproduce
Place the marker in the PeoplePicker
A list of suggested people are shown
Select one user
Now the suggested people list is empty

The control seems to be working for version 1.7.0, haven't tested for 1.8.0.
However it is a little mis-leading because you have to click outside the control and then click inside the control to get the suggested people box back. This behaviour is inherited from Peoplepicker of Office Fabric UI - link
Hopefully this answers the query above.
I might follow up with the Fabric team with this change and get something on it but from SPFx react control it mightn't change much as we default the behaviour from parent Office Fabric component.
If that works, please let us know and we could close it.

Thank you @AsishP, I can see that in the Fabric demo. But the issue I have is not the same. Even if I click outside the box and then inside again, suggested people does not show up.

@mwahlia, ok. If possible and if you are not using any other SPFx react controls in it, could you try to decrease the SPFx React controls to 1.7.0 and check. Few of my contacts had issues with 1.8.0 and have to tell them to switch back to 1.7.0 for people picker till they are fixed.
To install a specific version, use npm install @ —save —save-exact

@AsishP, I can confirm that you are right. It works as you describe in with version 1.7.0. Unfortunately, this version is missing some valuable props... The documentation of 1.8.0 declares that a fix was done for this, bur for me this version does not work. I´m not using any other pnp controls.

This is indeed a bug which got introduced by leveraging v5.122.0 from Office UI Fabric. Will downgrade the Office UI Fabric version to the same level as the one being used in SPFx version 1.6.0 and test out this issue again + release a fix.

I just released a new beta version with the fix in place. Would you be able to test it out? More information about installing a beta can be found here: https://sharepoint.github.io/sp-dev-fx-controls-react/beta/

Thank you @mwahlia for verifying. Will be in the next release soon.

This will be available today in version 1.9.0.


Add request encoder/decoder in Explainer model wrapper

/kind feature
general description:
(correct me if I am wrong)
Model Explainer currently supports LIME as its default explainer engine, the very beginning requests will hit the explain() API with an HTTP request when you send a request to the explainer endpoint (usually with the following format http://istio-ingressgateway.istio-system/v1/models/:explain bundled with Kubeflow installation), and then the explainer will do its magic by perturbing the input data and sent them to the predictor with the API _predict()
so the flow would look like this:
HTTP request  ---> explainer endpoint ---> predictor endpoint
In the current explainer (aixexplainer), it decodes the request body into NumPy.array in explain API call https://github.com/kserve/kserve/blob/master/python/aixexplainer/aixserver/model.py#L73:
        try:
            inputs = np.array(instances[0])
            logging.info("Calling explain on image of shape %s", (inputs.shape,))
        except Exception as err:

and converting the tensor back to HTTP requests in _predict API calls
        scoring_data = {'instances': input_im.tolist()}

        loop = asyncio.get_running_loop()
        resp = loop.run_until_complete(self.predict(scoring_data))
        return np.array(resp["predictions"])

https://github.com/kserve/kserve/blob/master/python/aixexplainer/aixserver/model.py#L45
Using list of tensor is reasonable because the very beginning requests are sent with a list of tensors in the MNIST example
input_image = {"instances": [inputs.tolist()]}
input_image.update(parameters)
print("Sending Explain Query")

https://github.com/kserve/kserve/blob/master/docs/samples/explanation/aix/mnist/query_explain.py#L50
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
However, to be a more general purpose of usage, a proper encoder/decoder should be introduced to mitigate the different formats of sending to the predictor, one of the examples is the flower example which is widely used in the e2e test (https://github.com/kserve/kserve/blob/master/docs/samples/v1beta1/tensorflow/tensorflow.yaml#L8)
The Flower example is a good example to demonstrate how a proper encoder/decoder is required as the input looks differently from the MNIST example, the flower payload is defined below:
{
  "instances": [
    {
      "image_bytes": {"b64": <b64-string>},
      "key": <string>,
    }
  ]
}

As the requests should come with the same request format for one particular model, instead of detecting request codec dynamically, it make sense if we can determine the encoder/decoder format during the construction phase:
class AIXModel(kserve.Model):  # pylint:disable=c-extension-no-member
    def __init__(self, name: str, ..., request_encode_decoder: str):

then we construct the request_encode_decoder accordingly, beflow is a simple contracts of request codec for reference.
class AIXRequestEncodeDecoder():
  def Encode(input_im: np.ndarray):
    // coverting numpy.array into a HTTP requests to predictor
  def Decode(self, request:Dict):
    // converting the HTTP requerst into numpy.array

just want to hear your feedback and I got some bandwidth if you need more hands on this.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
No

Thanks @hsinhoyeh for the proposal I think this makes sense and MLServer implements the codec with similar ideas
https://github.com/SeldonIO/MLServer/tree/master/mlserver/codecs.
@drewbutlerbb4 Any thoughts on this?

This sounds like a great idea to me, I'd say go for it @hsinhoyeh
Also would like to loop in @Tomcli for his thoughts

Yes that make sense to me.


-D_GLIBCXX_USE_CXX11_ABI=1 increases a lot RAM usage

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow installed from: pip
TensorFlow version (use command below): 1.13.1
Python version: python3.7
CUDA/cuDNN version: 10.1
GPU model and memory: GTX 1080 ti

Describe the current behavior
Since g++7 is now the default version on Ubuntu 18 and most distributions, most builds will use  _GLIBCXX_USE_CXX11_ABI=1. It seems also that when tensorflow is built with  _GLIBCXX_USE_CXX11_ABI=0, it implies recompiling all other libraries of the project with this flag which can be unconvenient.
We noticed that building with _GLIBCXX_USE_CXX11_ABI=1 increases the RAM by a lot.
Describe the expected behavior
Both packages should consume the same amount of RAM.
Code to reproduce the issue
You can install tensorflow using python3.7 -m pip install tensorflow==1.13.1 (related to https://github.com/tensorflow/tensorflow/issues/27078) and makes sure
python3.7 -c "import tensorflow; print(tensorflow.sysconfig.get_compile_flags())" prints -D_GLIBCXX_USE_CXX11_ABI=1.
Then you can install it in python3.6 python3.6 -m pip install tensorflow==1.13.1 and make sure  python3.6 -c "import tensorflow; print(tensorflow.sysconfig.get_compile_flags())" prints D_GLIBCXX_USE_CXX11_ABI=0.
Now run this script with python3.6 and python3.7 and you will see that the second one consume a lot more (x3 on the model I use). Any saved_model.pb should work.
import io
import os
import sys
try:
    from urllib import urlopen
except ImportError:
    from urllib.request import urlopen

import numpy
import psutil
from PIL import Image

import tensorflow as tf
from tensorflow.core.protobuf import saved_model_pb2
from tensorflow.python.platform import gfile
from tensorflow.python.util import compat

process = psutil.Process(os.getpid())

def print_ram(prefix=''):
    print("RAM", prefix, process.memory_info().rss / 1024. / 1024.)

if __name__ == '__main__':

    if len(sys.argv) == 1:
        model_filename = 'saved_model.pb'
    else:
        model_filename = sys.argv[1]

    with gfile.FastGFile(model_filename, 'rb') as f:
        data = compat.as_bytes(f.read())
        sm = saved_model_pb2.SavedModel()
        sm.ParseFromString(data)
        if 1 != len(sm.meta_graphs):
            print('More than one graph found. Not sure which to write')
            sys.exit(1)

    img_url = 'https://i.dailymail.co.uk/1s/2019/11/23/09/21370544-7717313-image-a-1_1574501083030.jpg'
    image_data = urlopen(img_url).read()
    decoded_data = numpy.array(Image.open(io.BytesIO(image_data)))
    decoded_data = numpy.expand_dims(decoded_data, axis=0)

    print_ram('before graph import')
    graph = tf.import_graph_def(sm.meta_graphs[0].graph_def)

    print_ram('before device')
    with tf.device("/device:GPU:0"):
        with tf.Session(graph=graph, config=None) as sess:
            print_ram('after session')
            output = sess.graph.get_tensor_by_name('import/predictions:0')
            print_ram('before run')
            for i in range(10000):
                results = sess.run(output, feed_dict={"import/image_tensor:0": decoded_data})
                print_ram('after run')

Other info / logs
python3.6:
RAM before graph import<PHONE_NUMBER>5
RAM before device 856.59375
2019-12-16 17:51:27.400388: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2019-12-16 17:51:27.425979: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-12-16 17:51:27.426637: I tensorflow/compiler/xla/service/service.cc:150] XLA service 0x229fee0 executing computations on platform Host. Devices:
2019-12-16 17:51:27.426655: I tensorflow/compiler/xla/service/service.cc:158]   StreamExecutor device (0): <undefined>, <undefined>
RAM after session 860.25
RAM before run 860.25
RAM after run<PHONE_NUMBER>5
RAM after run 998.0
RAM after run 1022.2265625
RAM after run 1038.984375
RAM after run 1038.984375
RAM after run 1056.0
RAM after run 1092.1953125
RAM after run 1097.09375
RAM after run 1097.09375
RAM after run 1097.09375
RAM after run 1097.09375
RAM after run 1097.09375
RAM after run 1116.42578125
RAM after run 1116.42578125
RAM after run 1116.42578125
RAM after run 1116.42578125
RAM after run 1116.42578125

python3.7:
RAM before graph import<PHONE_NUMBER>5
RAM before device<PHONE_NUMBER>5
2019-12-16 17:26:00.118658: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2019-12-16 17:26:00.141979: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-12-16 17:26:00.142737: I tensorflow/compiler/xla/service/service.cc:150] XLA service 0x265aff0 executing computations on platform Host. Devices:
2019-12-16 17:26:00.142775: I tensorflow/compiler/xla/service/service.cc:158]   StreamExecutor device (0): <undefined>, <undefined>
RAM after session 756.5625
RAM before run 756.5625
RAM after run 2977.8515625
RAM after run 3030.1640625
RAM after run 3047.8046875
RAM after run 3090.08203125
RAM after run 3121.296875
RAM after run 3122.0703125
RAM after run 3123.1015625
RAM after run 3123.1015625
RAM after run 3135.9921875

@r4nt may have some input on this, any ideas?
@maingoh Could you confirm this is also the same at head, or a newer release?

This is at least the same until 1.14.0 which are built using -D_GLIBCXX_USE_CXX11_ABI=1 (for python3.7 package). For some reason the 1.15.0 is built with -D_GLIBCXX_USE_CXX11_ABI=0 (and thus does not have the issue).
I don't have much time to rebuild a tf 1.15 with -D_GLIBCXX_USE_CXX11_ABI=1 but I am quite sure it will be the same issue. I think the problem comes from the COW disabled on C++ strings in CXX11 ABI. Might also be related to the way protobuf handles strings ?

@maingoh,
As I see that the issue is related to TF 1.x which is not officially supported anymore. Can you try installing the latest stable version of tensorflow i.e 2.6.0 and lets us know if the issue still persists. You can follow this guide to build from source. Thanks!

I rebuilt tf 2.6.0 from source, the conclusion is the same. I am still using a saved_model trained using tf1 (I don't have one in tf2).
To be honest, I don't think it will magically be fixed without a proper debug or PR addressing it. It might come from a dependency or maybe it is not even fixable because of the way the new C++ ABI works.
The official docker images are still built using the old ABI. Probably when the tf team will build with the new one they will encounter the issue.
Here is my code (might not be totally perfect as I am very new to tf 2 API):
import os
try:
    from urllib import urlopen
except ImportError:
    from urllib.request import urlopen

import psutil

import tensorflow as tf

process = psutil.Process(os.getpid())

def print_ram(prefix=''):
    print("RAM", prefix, process.memory_info().rss / 1024. / 1024.)

if __name__ == '__main__':
    loaded = tf.saved_model.load('.')
    print_ram('after model loading')
    print(loaded)
    print(list(loaded.signatures.keys()))  # ["serving_default"]
    infer = loaded.signatures["serving_default"]
    print(infer.structured_outputs)

    img_url = 'https://i.dailymail.co.uk/1s/2019/11/23/09/21370544-7717313-image-a-1_1574501083030.jpg'
    image_data = urlopen(img_url).read()
    decoded_data = tf.io.decode_jpeg(image_data, channels=3)
    decoded_data = tf.expand_dims(decoded_data, 0)

    print(type(decoded_data))
    with tf.device("/device:GPU:0"):
        print_ram('after device')
        for i in range(10000):
            infer(decoded_data)
            print_ram('after run')

Note also that the new tf seems to take around ~500MB more than tf 1.x (both with -D_GLIBCXX_USE_CXX11_ABI=0).

Hi @maingoh ! This issue is not replicating. Attached gist for reference. Thank you!

Thank you for trying to reproduce the issue !
It look like you used a tensorflow built with the old ABI -D_GLIBCXX_USE_CXX11_ABI=0. The issue is when built with -D_GLIBCXX_USE_CXX11_ABI=1.

Ok @maingoh ! Could we move this to closed status then.

Thank you @mohantym. This PR changed the default ABI but I don't think it fixed the issue.
If I use the code above I a difference of RAM usage between tf 2.8 and 2.9. More people might complain now that it is the default.
Note that my testing network has been trained with tf 1 but I don't think it change much (I don't have a tf 2 trained equivalent).
Please try to reproduce it.

Can you reuse your gist and just use tensorflow 2.9.1 instead of 2.8 ?

I'm still seeing a similar high RAM usage on Tensorflow 2.10.1 which is compiled with the default ABI option, i.e. without the option of  -D_GLIBCXX_USE_CXX11_ABI=0.

@tomchen1000 !
Could we create a separate issue  as this thread is very old to overlap the effort in new versions.
Thank you!

Re-opening as requested.
Thank you!

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.

Removing the stale label since this has a clear reproduction and there has been no work to actually fix it.


Set the Time zone inside spark applicatioin

Hi Google Team,
How can I change the  time zone for spark application job?
My time zone is Hong Kong Time zone. When check with the spark-ui, all the time is UTC which is 8 hours behind.
I am not sure what to add inside the Dockerfile, or other way to modify it.
Thanks.

sparkConf:
    "spark.executor.extraJavaOptions": "-Duser.timezone=Asia/Shanghai"

Thanks a lot!


feat(login): add code login limit

We have a limit when signing-in with username and password but with code is not yet, which may be the script burst code.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@qianxi0410 @leo220yuyaodog @imp2002 plz review

@longit644 the code is a very long and random string, can it be bursted? Can you give some example about other auth providers do such restriction?

Hi @hsluoyz, we only use 6 chars random string with 0-9 charset, so it can be bursted. I not tried with other providers yet, but I got a limit times when I using some application, such as: Slack.