Interesting Paper -

Hello SerVal team,
Your work is indeed interesting. In the recent past, I have used SAX-VSM on my time-series dataset and it was useful in classifying instances of time-series embedded with recurring events (motifs) which are local to them. However, it fails to faithfully recognize those instances which lack distinct events (e.g. more steady level).
I was wondering if DSCo could help in such conditions in faithful classification?
On that note, I wanted to apply your model onto my dataset but I don't see a clear documentation/reference on where to start (e.g. where & how to feed by TS dataset)?
Any quick help would be much appreciated.
Best,
KMB

Hello,
Thanks for your interest. I'm not sure about the scenario you've mentioned, but I encourage to try it out with DSCo.
I also acknowledge that the current documentation is very limited, but to use it, just look at the following scripts:

prepare_datasets.py: it converts time series into sax strings.
build_corpus.py: it builds language models and save them on disk
segmentation.py/.sh: it calculates fitness scores
evaluation.py: it assigns class labels and generates classification reports

On the other hand, I'm working to further improve DSCo and more documentation will be available in the coming weeks.
Cheers,
Daoyuan

Hi Daoyuan,
Appreciate your earnest and kind response my friend.
BTW in connection with your N-gram Language Modeling for appliance electricity usage profiling, let me re-frame my question to you again.

How does your model capture/detect steady-states of appliances as well? As far as my understanding and experience with using SAX for feature extraction and characterizing time-series appliance energy data is concerned, it is VERY MUCH PROMISING in capturing those distinct signature patterns that are recurring in the input energy signature (e.g. periodic compressor cycles in refrigerator use). However, I don't think it can equally reliably mode/capture an appliance operation in its steady-state (e.g. an LCD monitor which is either ON or OFF) as their energy signatures won't exhibit any kind of distinct patterns.

Does your DSCo distinguish these two appliance states from input time-series energy signatures?
Also I would like to know what is the nature of your input time series dataset? Is it a matrix of rows & columns with each row being a labelled energy signature ? Pls throw some light on it.
Cheers & look forward..
KMB

A quick couple of question from your N-gram language modelling paper:

Understanding that several training time series dataset exhibit distinctly dissimilar energy signature patterns...how would you make an appropriate choice of SAX parameters such sliding window size(w), PAA size(p) & alphabet size(a)? It is cumbersome to do it manually. How does your model deal with this scenario? Is it done manually or automatically ? If automatic - any specific optimizing algorithms for parameter selection used?

The way you compute the likelihood of an unknown symbolized energy data to matching one of those trained appliance profiles (M) is described through a mathematical equation (4) and (5) in your paper. I really don't get to understand the logic behind this. Could you pls. clarify on this? Additionally, can you also refer to me appropriate lines in your code which implement this part?

Thanks in anticipation.
Best,
KMB

Hello,
In our appliance profiling paper, the readings span a specific period (e.g. 200 minutes), and we focus on readings that showed at least some variations. So as long as appliances are consuming energy (turned on), their electric readings will vary over time and then we can profile them. In this sense there is no such "steady phase" from our perspective.
In our MLDM paper, we showed with three different setups that the sliding window size does not have a big impact on the overall classification accuracy. But you're right that the alphabet size is difficult to come to a perfect one. We have contacted the author of SAX and was told this is indeed a problem. They usually go with certain arbitrary alphabet size or use some optimization methods. But in our case, this parameter has not really been tackled with. We're still working to find a good optimization method.
For the calculation of fitness scores, please refer to this page: http://norvig.com/ngrams/. Our algorithm is a modified version of the code provided by P. Norvig.
Hope this helps.
Cheers,
Daoyuan

Hi,
I've update the repo for a simplified and more accurate version of DSCo. Also, documentation is a bit more detailed. Please take a look and feel free to comment on the new version. Thanks!
https://github.com/serval-snt-uni-lu/dsco/tree/v2.0-ng
Cheers,
Daoyuan


add config for allowAutoTopicCreationType=partitioned in doc

add config for allowAutoTopicCreationType=partitioned in doc

@jiazhai @Anonymitaet can you also add this documentation to streamnative/streamnative-docs?

@jiazhai @Anonymitaet can you also add this documentation to streamnative/streamnative-docs?

Ok. will do it.


[Bug] - ParkUI Tailwind Styles are not inlcuded on NX Monorepo Workspace

parkwindPlugin does nothing on NX Monorepo.

Dependencies

"@park-ui/tailwind-plugin": "^0.20.1",
 "@ark-ui/react": "^2.2.3",

tailwind.config.js

const { parkwindPlugin } = require('@park-ui/tailwind-plugin');

const { createGlobPatternsForDependencies } = require('@nx/react/tailwind');
const { join } = require('path');

module.exports = {
  content: [
    join(
      __dirname,
      '{src,pages,components,app}/**/*!(*.stories|*.spec).{ts,tsx,html}',
    ),
    ...createGlobPatternsForDependencies(__dirname),
  ],
  theme: {
    extend: {},
  },
  plugins: [parkwindPlugin],
  darkMode: ['class'],
};

postcss.config.js

const { join } = require('path');

module.exports = {
  plugins: {
    tailwindcss: {
      config: join(__dirname, 'tailwind.config.js'),
    },
    autoprefixer: {},
  },
};

````javascript

Reference: https://nx.dev/nx-api/react/generators/setup-tailwind

With a heavy heart, I have decided to discontinue support for Tailwind as the initial maintainer no longer has time to maintain it.

With a heavy heart, I have decided to discontinue support for Tailwind as the initial maintainer no longer has time to maintain it.

Just posting for anyone if they need help, the solution is to add explicitly the projects that depend on tailwind on the app configuration
const { createGlobPatternsForDependencies } = require('@nx/react/tailwind');
const { join } = require('path');
const { parkwindPlugin } = require('@park-ui/tailwind-plugin');
/** @type {import('tailwindcss').Config} /
module.exports = {
content: [
join(
__dirname,
'{src,pages,components,app}/**/!(.stories|.spec).{ts,tsx,html}',
),
join('libs/theme/src/lib/**/*.{js,ts,jsx,tsx}'),
...createGlobPatternsForDependencies(__dirname),
],
theme: {
extend: {},
},
plugins: [parkwindPlugin],
darkMode: ['class'],
};


Hitting Control S deletes the entered line

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:
VS Code-1.64.2
OS Version: Ubuntu 21.10
While Developing an Golang Project in VS Code
1.while importing packages in golang enter the required packages in import
2.Save the unsaved changes but instead the written line disappears

/extGo


3.1.5 version not available on Maven Central

The 3.1.5 was tagged and released last week (over a week ago), but it looks like it's still not available on Maven Central. Maybe some publishing step has gone wrong? I noticed this because I was waiting for Scala Steward bot to pick it up in the Metals repository, but it hasn't happened so far. :thinking:

Thanks for the report, I'll try to publish it again today!

In progress: https://github.com/scalacenter/scala-debug-adapter/actions/runs/7044265993

Thank you! :+1: Although looking at the logs from the linked GitHub action it seems that artifacts were published to the Sonatype snapshot repository and with a 0.0.0+1-b6dadc54-SNAPSHOT version? Not sure, but it appears that the publishing job has used the main branch? :slightly_smiling_face:

Not sure, but it appears that the publishing job has used the main branch? 🙂

Oh my goodness, it seems you're right :face_exhaling:
Let's try it again: https://github.com/scalacenter/scala-debug-adapter/actions/runs/7046648490
Thanks for catching this.

The artifacts are now live on Maven Central, thank you so much! :ok_hand:

Looks like we are missing it for 2.13.12? https://repo1.maven.org/maven2/ch/epfl/scala/scala-expression-compiler_2.13.12/3.1.5/

I triggered a release for 2.13.12 in https://github.com/scalacenter/scala-debug-adapter/actions/runs/7084327432

Btw. would it make sense to set expression eval for older versions to static. For example not release for 2.13.5 and set the version to last one that was released?

That's an interesting idea. But it is going to freeze the API. Or we would need 2 interfaces, one for the older versions and one for the newer. I'll think about it.


Implement function canonicalization corner cases

The language team decided that function objects obtained from closurization or generic function instantiation of constant expressions should be canonicalized, cf. https://github.com/dart-lang/language/pull/1686.
Implementations have actually done that already for many years now, except that there are some corner cases where canonicalization does not occur.
These cases are detected by failures in the tests added by https://dart-review.googlesource.com/c/sdk/+/202243.

@eernstg @lrhn It is not clear to me from this issue (and from the language discussion) exactly what is intended to be implemented, and where.  In particular, the discussion seems to touch on four separate things:

non-instance method, not instantiated functions (top level, statics)
non-instantiated method, implicitly instantiated functions (top level, statics)
instance method, non-instantiated methods
instance method, implicitly instantiated methods

I believe that 1 and 2 are probably properly handled by the CFE, is that correct?  cc @johnniwinther
3 must be handled at runtime by the backends, and I think is well-specified (are there failures here?)
4 must be handled at runtime by the backends, but I don't think we have a clear specification of what is expected.  Specifically:

What equality will be used?

Normalization?  Identity? Mutual subtyping?

What about non-constant types?  I think it probably doesn't make sense to restrict this to constant types here, the implementation is going to have to just compare at runtime, so the notion of constant isn't visible (though if we use identity as the equality, constant-ness becomes relevant).

I don't think the tests landed cover 4.
Per discussion, in the language meeting, this change should be gated on ease of implementation in the tools.  cc @fishythefish @nshahan @sigmundch @a-siva @alexmarkov @johnniwinther @stefantsov

In the CFE we previously canonicalized static tear offs even in non-const context. Recently I added canonicalization of instantiated static tear offs in non-const context: https://dart-review.googlesource.com/c/sdk/+/204960 . This will also handle constructor tear offs when support for these is landed.

There's also local functions, which is a third category from static/top and instance methods.

tl;dr We may need to add a short paragraph to the NNBD spec, saying that we use the equality of reified types to compare the actual type arguments of function objects with generic instantiation at run time rd;lt
@leafpetersen wrote:

It is not clear to me from this issue (and from the language discussion) exactly
what is intended to be implemented, and where.

Right, I was relying on the existing specification to determine the desired semantics, and on the tests to point out known cases where the current behavior is different. So the actual text in this issue makes no attempt to spell it out.
I'm not 100% sure about the meaning of the four categories:

non-instance method, not instantiated functions (top level, statics)

I assume this would target those cases where we tear off a top-level function or a static method (aka static functions), and there is no generic instantiation.

non-instantiated method, implicitly instantiated functions (top level, statics)

Does this one cover instance method tearoffs without generic instantiation plus static function tearoffs with generic instantiation? Why would we want to consider those as related?

instance method, non-instantiated methods

This could be instance method tearoffs without generic instantiation, but it's confusing that it overlaps with the previous one.

instance method, implicitly instantiated methods

This could be instance method tearoffs with generic instantiation.
About the CFE and the static function tearoffs, with and without generic instantiation: The tests landed in https://dart-review.googlesource.com/c/sdk/+/202243 are all succeeding with cfe-strong-linux (and other, pure CFE configs). Of course, these configurations don't run the code. The VM fails in several cases, and this may or may not involve anything in the CFE:
103:  checkIdentical(cIntTopLevelFunction1, vIntTopLevelFunction2);
104:  checkIdentical(cIntStaticMethod1, vIntStaticMethod2);
105:  checkIdentical(vIntTopLevelFunction1, vIntTopLevelFunction2);
106:  checkIdentical(vIntStaticMethod1, vIntStaticMethod2);
280:    checkEqual(vXTopLevelFunction1, vXTopLevelFunction2);
281:    checkEqual(vXStaticMethod1, vXStaticMethod2);
284:    checkEqual(vXTopLevelFunction1, vIntTopLevelFunction1);
285:    checkEqual(vXStaticMethod1, vIntStaticMethod1);

The backends must be involved in the static function tearoffs in the case where there is a generic instantiation and the type argument is not a constant type expression (that is, cases involving vX above). They must also be involved when we are comparing two constant objects, but one or both are obtained by evaluating a variable (cases involving v above).
I believe the above list shows that the CFE-and-or-the-vm do not canonicalize constant expressions when they do not occur in a constant context (they occur as c in var v = c;, but presumably this happens in other con-constant contexts as well), and they involve a static function tearoff with generic instantiation.

3 must be handled at runtime by the backends, and I think is well-specified (are there failures here?)

No plain test failures. When I comment out all tests involving generic instantiation then the landed tests all succeed with dart (dartk-strong-linux-release-x64), dart2js (dart2js-hostasserts-strong-linux-x64-d8), and dartanalyzer (analyzer-asserts-strong-linux); dartdevk fails an inequality test (that's a crazy case, reported separately), but when that's commented out it also succeeds.

4 must be handled at runtime by the backends, but I don't think we have a clear specification of what is expected.

True, the language specification just says that the actual type arguments used in the generic instantiation must be the 'same types'.
We actually specify that operator == on instances of Type that reify types must return true if and only if the two types are mutual subtypes. However, that wasn't ever implemented (not fully, anyway), and that rule is now replaced by the one here.
So the question is whether it's appropriate to use the rule for equality of reified types in the case where we are comparing actual type arguments of function objects (nobody says that they are 'reified types').
Anyway, it seems reasonable to go that way, so I'd recommend that we add a short section to the NNBD spec to say so.

What about non-constant types? I think it probably doesn't make sense to restrict this
to constant types here, the implementation is going to have to just compare at runtime,
so the notion of constant isn't visible

Agreed, and this also matches what we have specified already.

@lrhn mentioned local functions: True, they are not covered by https://dart-review.googlesource.com/c/sdk/+/205081 nor https://dart-review.googlesource.com/c/sdk/+/202243.
The language specification explicitly says that no guarantees are given about the equality and/or identity of a function object obtained by closurization of a local function with generic instantiation. It says nothing about the plain case (without generic instantiation). I made a note that we should add that.
In any case, we should presumably only have tests concerned with these properties if we give some guarantees (other than the implied "localFunction1 == localFunction2 doesn't crash").
If we commit to a specific implementation (which may well be the one that we're using), namely that a local function works like a final local variable whose initializing expression is a function literal, then we can promise that two local tearoffs are identical (and hence equal) if and only if they are obtained during the same execution of the enclosing function.
However, if we wish to allow optimizations like lifting out local functions that do not use their innermost enclosing scopes (e.g., all the way to the top level, if possible), then we may be able to obtain substantial performance benefits, but they would then be identical across invocations of the enclosing function.
So do we want to give any guarantees about identity and/or equality for local functions? How often is that used? How important are those optimizations? Would it be OK to promise equality/identity per invocation, and actually have identity in all cases as the actual behavior with some local functions? (After all, we don't have to specify that == returns false in any particular situation!)

The CL I made only enables the eager canonicalization for the constructor-tearoffs experiment (since we need it for that). But as I understand from this (and the test added in https://dart-review.googlesource.com/c/sdk/+/202243) this should be enabled without experiments, right? This would fix the failures seen on the VM bot.

Yes, I'd say that this would be considered as a set of bug fixes, not an experiment.

It looks like dart2js had no issues on https://dart-review.googlesource.com/c/sdk/+/202243. I investigated the failures on https://dart-review.googlesource.com/c/sdk/+/205081 and created https://dart-review.googlesource.com/c/sdk/+/205764 in response. Pending review/hammering out any implementation details, this should address all of the known corner cases for dart2js.

this should address all of the known corner cases for dart2js.

Sounds good! This seems to be a strong hint that, for dart2js, it is not unbearably expensive (in terms of run-time performance, or in terms of implementation effort) to achieve the semantics that makes even the dynamic cases equal.


Provide an option to use provided file extensions instead of checking bytes

Microsoft office files with .docx, .xlsx, and perhaps others are identifed as archive file types i.e. MiniMagic.DetectFileType returns a type ZIP for them.  Now, they technically appear to be that i.e. you can unzip them apparently and they contain other files like xml docs etc. but for practical purposes they may not be the desired result i.e. the user is unlikely to expect them to be unzipped but treated like a single document.  It can lead to unexpected results and lost processing time.
Request: assess if the file type is a known document type earlier in the detection process which is accepted as a non archive type unless a new override flag is provided to ignore file extensions so similar effect.

If you provide a list of extensions to ignore I can add an optional argument that will change the behavior to look at the file extension against a list of known ones.

Updated: This should be a new option to provide a list of file extensions to trust are "not" archives.


Missing initialization of series_index when using OECD agency

Hi @dr-leo,
when using pandasdmx for a download of the OECD data, I am getting the following error.
To reproduce:
from pandasdmx import Request
symbol = "SNA_TABLE1/AUS+AUT+BEL+CAN+CZE+DNK+FIN+FRA+DEU+GRC+HUN+ISL+IRL+ITA+JPN+KOR+LUX+MEX+NLD+NZL+NOR+POL+PRT+SVK+ESP+SWE+CHE+TUR+GBR+USA+ARG+NMEC+BRA+BGR+CHL+CHN+COL+CRI+HRV+CYP+EST+IND+IDN+ISR+LVA+LTU+MKD+MLT+PER+ROU+RUS+SAU+SVN+ZAF+DEW+FRME+OTF+EU15+EU28+OECD+OECDE+EA19.B1_GA.C"
request = Request(agency='OECD', log_level=10)
response = request.data(symbol)
df = response.write()

The error:
UnboundLocalError                         Traceback (most recent call last)
<ipython-input-45-2617ddf5597f> in <module>()
      3 request = Request(agency='OECD', log_level=10)
      4 response = request.data(symbol)
----> 5 df = response.write()

/opt/virtualenv/develop/lib/python3.5/site-packages/pandasdmx/api.py in write(self, source, **kwargs)
    633         if not source:
    634             source = self.msg
--> 635         return self._writer.write(source=source, **kwargs)
    636
    637     def write_source(self, filename):

/opt/virtualenv/develop/lib/python3.5/site-packages/pandasdmx/writer/data2pandas.py in write(self, source, asframe, dtype, attributes, reverse_obs, fromfreq, parse_time)
    107                 series_list = list(s for s in self.iter_pd_series(
    108                     iter_series, dim_at_obs, dtype, attributes,
--> 109                     reverse_obs, fromfreq, parse_time))
    110                 if dtype and attributes:
    111                     # series_list is actually a list of pairs of series

/opt/virtualenv/develop/lib/python3.5/site-packages/pandasdmx/writer/data2pandas.py in <genexpr>(.0)
    105         else:
    106             if asframe:
--> 107                 series_list = list(s for s in self.iter_pd_series(
    108                     iter_series, dim_at_obs, dtype, attributes,
    109                     reverse_obs, fromfreq, parse_time))

/opt/virtualenv/develop/lib/python3.5/site-packages/pandasdmx/writer/data2pandas.py in iter_pd_series(self, iter_series, dim_at_obs, dtype, attributes, reverse_obs, fromfreq, parse_time)
    226             if dtype:
    227                 value_series = PD.Series(
--> 228                     obs_values, index=series_index, name=series.key)
    229
    230             if attributes:

UnboundLocalError: local variable 'series_index' referenced before assignment

I'm using the master branch. The url is produced correctly and the data seems to be available in the response. However, the parsing in the writer fails.
If I understand it correctly, in lines 163-167 the frequency key should be detected. However, the response data has no frequency in the OECD data, but there is no else case for that. Specifically, the if in line 169 has no else. Therefore, the variable series_index is still not set in line 228. In my understanding, the simplest solution would be to add an else case after line 214 in order to close the if in line 169. Since there is no frequency available, one could just create a simple Index:
else:
    series_index = PD.Index(obs_dim, name=dim_at_obs)

I tried in locally and it seems to work.
Regards Rudi

Hi Rudi,
thank you for your thorough analysis and proposal to fix this. While I wasn't able to reproduce the bug due to some http error (I didn't get the response), I leave this issue open for later. Your proposal seems to make sense provided the series contained in the dataset really does not contain a freq dimension or attribute.
Do you still encounter this bug? I have rewritten large parts of the relevant code for the forthcoming v0.9. - Reproducing the bug might be easier with less countries. I will retry in a few days.
Thanks again and best regards
Leo

I cannot reproduce the error due to some HTTP client error 400. But I've essentially done what you've suggested. So this should be fixed in v0.9 to be released very soon.
Thanks for spotting this.
Leo


Subject via Razor

If I want to use a Razor template for the subject, how can I do that?

Closing old issues.


feat: scheduler download tiny file with range header

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Scheduler download tiny file with range header and handle http error code.

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #1024 (9ee832d) into main (037b77d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage   45.96%   45.96%
=======================================
  Files         128      128
  Lines        9134     9142    +8
=======================================
+ Hits         4198     4202    +4
- Misses       4463     4467    +4
  Partials      473      473

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
45.96% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

scheduler/resource/peer.go
74.84% <100.00%> (+0.48%)
:arrow_up:

client/daemon/transport/transport.go
57.98% <0.00%> (-1.50%)
:arrow_down:

client/daemon/peer/peertask_conductor.go
56.91% <0.00%> (-0.42%)
:arrow_down:

client/daemon/proxy/proxy.go
9.74% <0.00%> (-0.04%)
:arrow_down:

client/daemon/peer/peertask_manager.go
44.30% <0.00%> (+0.14%)
:arrow_up:

cdn/supervisor/progress/progress.go
97.01% <0.00%> (+5.97%)
:arrow_up:


Table Domiciliation Journal Line

there is a bug in table Domiciliation Journal Line in the procedure CustUpdatePayment
line:
"Message 1" := CustLedgEntry."Document No.";
the field "Message 1" has a lenght of 15, but the CustLedgEntry."Document No." can be 20
the line should be like this:
"Message 1" := copystr(CustLedgEntry."Document No.",1,maxstrlen("Message 1"));
Or the "Message 1" field should be extended tot 20 characters.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 13710.

Availability update: We will publish a fix for this issue in the next update for release 23.
Build ID to track: 13736.


Upgrade sales reset on save reload

I have a save file where every time I load the save, the LGU store resets the sales to what they were at
Attached is 2 saves from my current game - One is from day 9, the other at day 14. I've had the same sales show up every time I re-host the game.
Even after the sales change, if I load the save file, the sales seem to reset back to "Bargain - 19%", "Climbing - 32%", "Efficient - 17%", "Sick Beats - 37%". (While double checking things, one time the save loaded with no sales at all - I exited and re-hosted the save and it went back to the same sales).
LCSaveFiles.zip
Profile: 018ee506-a3f3-16fc-cb09-a47631f42e61

The sales seem to differ between the saves.
So you're saying that you're seeing exactly the same sales on both saves?

The first screenshot is what I saw before I stopped playing. The second is what I saw after I hosted the save file again. - we restarted the server multiple times while actively playing, and each time it reset to those sales.
Today, I started up the files, and now neither of the files show any sales in the LGU store.

The sales not loading's probably due the implementation's amount of tries of acquiring what it needs to sync up the saves not sufficient and loads it under a default value.
And the sales only change after a quota is met. (I cannot tell from the saves alone this fact happened)
So either three things are happening with the sales:

Sales are not being generated every time a quota is met. (Means that GenerateSales is either failing or not being called)
Sales are not being saved after being generated (Means that ServerSaveFile is either failing or not being called)
Sales are not being loaded when rebooting from a game (Means that LoadSales is either failing or not being called)

So I would need you (if possible obviously, otherwise it would be after I'm done with my stuff to start testing this again) to try do the steps of generating the sales, leave and come back and see the results. After this, post the logs of this session so that I can have a look at what's going on.

Okay, the bug re-triggered this time. The days I'm tallying here might not be the correct numbers. But this time it actually loaded the first time with the sales in the LGU that didn't load this morning when I responded. This is the LCSaveFile2 from the first zip folder but landing on experimentation 3 times and then reaching the quota.
Day 10: Sales changed (LGU didn't) - Walkie 30% => radar-booster 20%
Day 11: Sales changed (LGU no) - Walkie 20%/extension 50%/radar 50%/spray-paint 10%
Day 12 (After quota ended): Sales unchanged - LGU changed: Better Scanner 16%/Locksmith 27%/Protein 12%/ Sick Beats 33%
Day 12: after loading: Bargain 19%/ Climbing 32%/ Efficient 17%/ Sick Beats 37%
Lines 1287-1290 show the initial sales loaded
[Info   :More Ship Upgrades] [LguStore] Loading SteamID:<PHONE_NUMBER>1076472
[Info   :More Ship Upgrades] [LguStore] Successfully loaded save data for ID:<PHONE_NUMBER>1076472
[Info   :More Ship Upgrades] [UpgradeBus] Loaded sale of 0.8088145 for Bargain Connections.
[Info   :More Ship Upgrades] [UpgradeBus] Loaded sale of 0.6842617 for Climbing Gloves.
[Info   :More Ship Upgrades] [UpgradeBus] Loaded sale of 0.8285989 for Efficient Engines.
[Info   :More Ship Upgrades] [UpgradeBus] Loaded sale of 0.6277798 for Sick Beats.

Lines 4063-4130 in the log shows the new LGU sales, then after I quit and re-loaded the same file,

4063-4130
[Info   :More Ship Upgrades] [LguStore] Generating sales with seed: 259081 on this client...
[Info   :More Ship Upgrades] [LguStore] Set sale percentage to: 0.6710415 for Aluminium Coils.
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Set sale percentage to: 0.7355092 for Fast Encryption.
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Received and updated save info for client:<PHONE_NUMBER>1076472
[Info   :GeneralImprovements] Applying surplus quota to fulfilled: $1798
[Info   :More Ship Upgrades] [LguStore] Generating sales with seed: 905470 on this client...
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Set sale percentage to: 0.843331 for Better Scanner.
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Set sale percentage to: 0.7315573 for Locksmith.
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Set sale percentage to: 0.8811426 for Protein Powder.
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Set sale percentage to: 0.6675756 for Sick Beats.
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Saving node into save
[Info   :More Ship Upgrades] [LguStore] Received and updated save info for client:<PHONE_NUMBER>1076472

lines 5012-5017 show the sales loaded are the ones that existed when I first loaded the save!
[Info   :More Ship Upgrades] [LguStore] Loading SteamID:<PHONE_NUMBER>1076472
[Info   :More Ship Upgrades] [LguStore] Successfully loaded save data for ID:<PHONE_NUMBER>1076472
[Info   :More Ship Upgrades] [UpgradeBus] Loaded sale of 0.8088145 for Bargain Connections.
[Info   :More Ship Upgrades] [UpgradeBus] Loaded sale of 0.6842617 for Climbing Gloves.
[Info   :More Ship Upgrades] [UpgradeBus] Loaded sale of 0.8285989 for Efficient Engines.
[Info   :More Ship Upgrades] [UpgradeBus] Loaded sale of 0.6277798 for Sick Beats.
[Info   :More Ship Upgrades] [LguStore] Applying loaded upgrades...

LGU Save issues.zip

In addition, just to double check on loading straight from game-load: The log shows that the sales loaded (the old ones, not what it should be here - this is the Day 12 file after the quota), but the UI shows no sales at all when I go to the LGU store (and the base store sales don't exist either).

bepinex.log
Hope this helps you figure out what's going wrong!


Add toggle to build fluentbit

Which issue this PR addresses:
Fixes: https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/10157198
What this PR does / why we need it:
This allows a user to decide if they want to build the fluentbit container during the bootstrapping pipeline.  It defaults to false and will skip building.
Versioning will remain in the pipeline template to require peer reviews.
Test plan for issue:
https://dev.azure.com/msazure/AzureRedHatOpenShift/_build/results?buildId=44742337&view=results (With Fluentbit)
https://dev.azure.com/msazure/AzureRedHatOpenShift/_build/results?buildId=44741921&view=results (Without Fluentbit)
Is there any documentation that needs to be updated for this PR?
No
NOTE: const.go is still hardcoded for version 1.7.8-1.  While that exists in our local ACRs, updating that file is outside of the scope of this pipeline work.

Requiring a user to provide a version allows this pipeline to run without the need of submitting future PRs to have a newer version to be built and then pushed to our local ACR.

But the downside is that now we have to go and find the version number to be able to run the pipeline. And we need to manually pick the correct one.
Sounds like having to subbmit a PR with a new version is less error prone process than the above.
Or do I miss something?

/azp run ci

https://msazure.visualstudio.com/AzureRedHatOpenShift/_wiki/wikis/ARO.wiki/172367/FAQ-ARO-in-Fairfax


Update bug report template with additional system information

Description
Update the bug report template to include all the system information details.
Issues
List the issues impacted by this PR:

Issue ID

#63

Checklist

[ ] I have performed a self-review of my own code
[ ] I have run 'make check' to ensure my code does not have any formatting, vetting, linting, or security issues
[ ] I have run 'make test' to ensure new and existing unit tests pass locally with my changes
[ ] I have not allowed coverage numbers to degrade
[ ] I have maintained at least 90% code coverage
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
N/A

e2e pass


[feb8: waiting for backend update] Storefinder view all stores returns an error

Navigating to http://dev-com-19.accdemo.b2c.ydev.hybris.com:4200/store-finder/country/JP returns a 404 error:

latest status feb8: looks like C3PO-1203 was merged, but there is still OCC PR E2EC-941 not merged yet.

are #1113 and #992 same issue?

@Xymmer it's a dupe of #992


Error while running app:install command.

I get this error while running the app:install command.
Installing the app
[Symfony\Component\Debug\Exception\FatalErrorException]
syntax error, unexpected ':', expecting ';' or '{'
Hard to tell where the problem is. Help?

I made a new installation downloading the master... I works fine.
The other one was via composer, which seems outdated.

Thanks @ivanjpolanco, I am going to check this as 3.0.1 is master and should not have any issues, by any chance did you see what version it downloaded?

@joselfonseca , same problem facing when clone no problem . but composer system give error
[Symfony\Component\Debug\Exception\FatalErrorException]
syntax error, unexpected ':', expecting ';' or '{'

that error is bellow
   public function setTransformer() :TransformerAbstract
    {
        return app(UserTransformer::class);
    }

It requires PHP 7, are you using php 5.6?
https://github.com/joselfonseca/laravel-api/blob/master/composer.json#L16

Have not been able to reproduce this issue in PHP 7+ if your using php 5.6 it won't work. A constraint for it has been added in composer.json
Thanks!


Feature - Implement Token Revoking mechanism for issued Tokens

Implement Token Revoking mechanism for issued Tokens
There are two ways that an issued  token could be revoked.

Re-creating / Rotating the RSA Key
Tracking the token in a client side Database  ( always checking existence for validity)

Globally recreating the RSA key invalidates all un-expired tokens as the signature has changed. This is not ideal as re-distributing / rotating public keys is harder to automate but possible if EasyAuthClients maintain an active connection to the EasyAuthServer, the server could push changes downstream.
Tracking & Updating a valid token is also difficult without introducing a implementing a locally cached "source-of-truth" for all workers, as performing a Database call against every request to check validity will reduce overall performance, and keeping this cache up-to-date would require a long-polling against the EasyAuthServer for changes.
Possible Solution
Maintain an active connection between EasyAuthClient & EasyAuthServer via EasyRPC protocol(duplexed websocket connection).
This could allow  EasyAuthServer to push updates to all connected EasyAuthClient's when a token has been revoked, but also enables a channel that would allow easier key rotation and could completely eliminate the need to distribute / manage client side public keys.

[x] Implement EasyRPC channel between EasyAuthServer & EasyAuthServer
[x] Using EasyRPC channel - allow public key to be pulled by EasyRPC clients
[x] Implement push mechanism using EasyRPC channel to invalidate issued tokens
[x] Create Token Admin GUI panel for issued Tokens
[ ] Create mechanism for rotating keys via EasyRPC channels

Token Revocation  / Service account  API / GUI usage completed in latest PR
Have a look via latest version:
https://pypi.org/project/easy-auth/0.136/
This was a pretty major update to the EasyAuthServer / EasyAuthClient - which added support for EasyAuthServer forking & a channel between EasyAuthServer & EasyAuthClient for token information exchange & reducing setup complexity.
Keep in mind that a new field is required for  EasyAuthServer / EasyAuthClient creation, 'auth_secret', this field allows the public key to be pulled and creates the channel for the server to push token updates to connected EasyAuthClient's.

server usage
client usage

Be sure to use the following to grab all new dependencies:
pip install -U easy-auth[all]

# run again to update( because pip is special)
pip install -U easy-auth[all]

#9


Wrong operate selection while selecting characters in Korean IME mode

VSCode Version: Code 1.12.2 (19222cdc84ce72202478ba1cec5cb557b71163de, 2017-05-10T13:13:11.413Z)
OS Version: Darwin x64 16.6.0
Extensions: none

Steps to Reproduce:

type korean some characters. ex)한글을입력합니다
and select a character in front of cursor
selected character replaced another character. ex)한글을입력합다다

@crom0406 There have been a lot of improvements to the way input is handled in the upcoming 1.13 version. Could you please check if this reproduces on the insiders version which contains these fixes -- you can download from https://code.visualstudio.com/insiders
Otherwise, may I kindly ask for more detailed steps (like I would be 5 years old) -- since I don't know Korean. Some examples of kind people that did it in the past e.g. https://github.com/Microsoft/vscode/wiki/IME-Test#windows-korean

fyi @rebornix


[tool_crash] DartDevelopmentServiceException

Command
flutter run -d chrome

Steps to Reproduce

If webpage does not load on browser
Copy paste localhost address to a new browser tab
Error should occur

Logs
DartDevelopmentServiceException
#0      DartDevelopmentServiceImpl._startDDSServer (package:dds/src/dds_impl.dart:144:7)
<asynchronous suspension>
#1      DartDevelopmentServiceImpl.startService (package:dds/src/dds_impl.dart:97:7)
<asynchronous suspension>
#2      DartDevelopmentService.startDartDevelopmentService (package:dds/dds.dart:82:5)
<asynchronous suspension>
#3      DebugService.startDartDevelopmentService (package:dwds/src/services/debug_service.dart:151:12)
<asynchronous suspension>
#4      DevHandler._createAppDebugServices (package:dwds/src/handlers/dev_handler.dart:424:7)
<asynchronous suspension>
#5      DevHandler.loadAppServices (package:dwds/src/handlers/dev_handler.dart:226:25)
<asynchronous suspension>
#6      Dwds.debugConnection (package:dwds/dwds.dart:82:28)
<asynchronous suspension>
#7      WebDevFS.connect.<anonymous closure> (package:flutter_tools/src/isolated/devfs_web.dart:651:15)
<asynchronous suspension>

[✓] Flutter (Channel stable, 2.0.2, on Microsoft Windows [Version 10.0.19041.867], locale en-IN)
    • Flutter version 2.0.2 at F:\flutter
    • Framework revision 8962f6dc68 (11 days ago), 2021-03-11 13:22:20 -0800
    • Engine revision 5d8bf811b3
    • Dart version 2.12.1

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0-rc4)
    • Android SDK at F:\android-sdk-windows
    • Platform android-30, build-tools 30.0.0-rc4
    • ANDROID_HOME = F:\android-sdk-windows
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] VS Code (version 1.54.3)
    • VS Code at C:\Users\Shubham\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.20.0

[✓] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 89.0.4389.90
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 89.0.774.57

• No issues found!

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: 8962f6dc68ec8e2206ac2fa874da4a453856c7d3
Plugins
cloud_firestore-1.0.1
cloud_firestore_web-1.0.1
firebase_analytics-5.0.15
firebase_auth-1.0.1
firebase_auth_web-1.0.2
firebase_core-1.0.1
firebase_core_web-1.0.1
google_sign_in-5.0.1
google_sign_in_web-0.10.0

Related issues: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+DartDevelopmentServiceException
Not duplicate since the stack trace are different.

possible duplicate of https://github.com/flutter/flutter/issues/77077

@jiaozebo
according to this message the issue might to be solved  in the latest stable, can you confirm?
cc @TahaTesser

@IamShubhamGupto
according to this message the issue may be solved in the latest stable, can you confirm?
cc @TahaTesser

Yes, I am currently on Flutter 2.2, have not faced this sort of crash.
Thank you !!


ReportPreview has replies, but there's no option to reply in thread when hovering.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login with any account.
Try to request money to any account.
Hover on the money request.
Notice that, it showed 1 reply but there's no option to reply in thread.

Expected Result:
There should be option to reply in thread when hovering or right click on money request.
Actual Result:
There's no action to reply in thread when hovering or right click on money request.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/b359c6e9-6eba-4ba3-99b9-efbcf73a13b4
https://github.com/Expensify/App/assets/43996225/6d053678-f3ec-49c4-96c1-590c0dba825f
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689606579815989
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
ReportPreview has replies, but there's no option to reply in thread when hovering.
What is the root cause of that problem?
We're checking here to show reply in thread option, we only showed "reply in thread" when our reportActions have type "ADDCOMMENT", but since we introduced report preview action and IOU which also had replies, we didn't add it in here yet.
https://github.com/Expensify/App/blob/7770b866bff96efa42c337fb5db8473d34102e71/src/pages/home/report/ContextMenu/ContextMenuActions.js#L121
What changes do you think we should make in order to solve the problem?

We should also include REPORTPREVIEW and IOU type in our shouldShow condition in here:

                    type === CONTEXT_MENU_TYPES.REPORT_ACTION &&
                    ((reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !ReportUtils.isThreadFirstChat(reportAction, reportID)) ||
                        reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW ||
                        reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.IOU)

Alternatively, we can replace reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW) with ReportActionUtils.isReportPreviewAction(reportAction)
What alternative solutions did you explore? (Optional)
N/A

@CortneyOfstad I'm OoO on Monday and Tuesday, so co-assigning this in case you can get to it before Wednesday!

My bad, sorry, I unassigned the wrong account here. Reproduced, all done:

@0xmiroslav There's a proposal from @hungvu193 to review above, fyi

@0xmiroslav Is that proposal workable?

@situchan Waiting for your review of this proposal, please

I think it's expected to show reply for IOUPreview.
We also show reply for TaskPreview.
https://github.com/Expensify/App/assets/108292595/017e5e30-7b0e-43fc-baf4-c8911289283e

Proposal looks good to me. This is straightforward fix.
@hungvu193 please comment here to get assigned.
🎀 👀 🎀 C+ reviewed

Agree with the proposal. Maybe we should create a helper func for all these actions that can be replied to.

Nice, looks like the PR is making progress and just got sent to Jules for review

From reading https://github.com/Expensify/App/issues/25688, this issue (#23377) wasn't the cause of the deploy blocker. So we are good to pay here, without urgency bonus

I think Melvin miscalculated timeline.
@hungvu193 was assigned on Aug 11
PR was C+ approved on Aug 16
PR was merged without further requests on Aug 16
Aug 12, 13 was weekend

@situchan That looks like more than 72 hours, when you exclude weekends. Can you share your maths for the timeline being less than 72 hours between assign and merge?

I updated comment - https://github.com/Expensify/App/issues/23377#issuecomment-1697348284 regarding timeline

@situchan In that example above, the Contributor created the PR around 9 hours after they were assigned to the issue, and the C+ 36 hours later. Then the engineer led discussed that didn't end up changing the PR for four days. I don't think that's the equivalent to here, when the engineer reviewed and merged the PR 8 hours after you approved it.
I'm sticking with no urgency bonus as a result

Thanks for the checklist too - I'm closing this out!


Removing jQuery from the repo

Changes

Modified CSS, HTML, and images to remove jQuery and non-responsive-header.js code.

Testing

Run grunt
Test that the addresses are parsed correctly.
Test that the routing works as expected.
Test that the error notifications are displayed correctly.

Screenshots
Notes

I tried not to modify an variable names of existing business logic. This was really a PR to move us closer to placing the code into cfgov-refresh and closing the security issue.

Todos

Write unit tests.

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the development playbook
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewer tool :arrow_right:

@awolfe76 I believe this is now in working order, could you take a look?


How to handle default arguments of solve

We need some default arguments of solve, e.g., save_everystep=false. With our coming MPI array type, we also need to think about how to handle the parallel norm computations for error-based step size control with MPI. Right now, we let length return a global length, but that comes with some problems, too.
See https://github.com/trixi-framework/Trixi.jl/pull/1104, especially https://github.com/trixi-framework/Trixi.jl/pull/1104#discussion_r840319907

We might also consider turning on multithreading in solve by default this way, couldn't we?

That's a bit more difficult since it's part of the algorithm, not a standard keyword argument (since not all algorithms support that).


[AMO-132268] - Modified title and description for the aggregated perf…

…ormane by Keyword Object
@prabhum2

For CLA certificate - here is the response
David Crompton, a member of the UIM group, has resolved your case and provided the following details: account jkshah12 deprovisioned, provisioned basic access to jishah-adobe, user will receive an invite.


feat: windows features

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[experiment 1] Gather some input on the permission denied issues with kvm

Try to gather some info on our CI failures regarding to denied permissions to devices.

/test pull-kubevirt-e2e-kind-k8s-1.17.0-ipv6

/test pull-kubevirt-e2e-kind-k8s-1.17.0-ipv6

/close
No insights and can't follow up right now.


Can't take a screenshot

Are you requesting a feature or reporting a bug?
Bug
What is the current behavior?
Well, I update the testcafe-browser-tools to v1.4.3.And I try to take a screenshot. But it occur to
Warnings (1):
 --
  Was unable to take a screenshot due to an error.

  Command failed: /Users/xxxx/project/test-cafe-demo/node_modules/testcafe-browser-tools/bin/mac/generate-thumbnail
  /Users/xxxx/project/test-cafe-demo/screenshots/my-fixture/test1.png
  /Users/xxxx/project/test-cafe-demo/screenshots/my-fixture/thumbnails/test1.png 240 130

I have set the screenshots directory through the cli : -s screenshots.
I use the testcafe get started test script to test:
fixture `My fixture`
    .page `https://www.baidu.com`;

test('Take a screenshot', async t => {
    await t
        .takeScreenshot('my-fixture/test1.png')
});

What is the expected behavior?
It can work it with screenshot function.
How would you reproduce the current behavior (if this is a bug)?
Provide the test code and the tested page URL (if applicable)
Tested page URL: https://www.baidu.com
Test code
fixture `My fixture`
    .page `https://www.baidu.com`;

test('Take a screenshot', async t => {
    await t
        .takeScreenshot('my-fixture/test1.png')
});

Specify your

operating system: mac 10.11.0
testcafe version: 0.17.0
node.js version: 8.0.0

Hi,
We've faced with the same issue and fixed it in the<EMAIL_ADDRESS>please check it.

Well , It doesn't work too.And the error message is :
 Warnings (1):
 --
  Was unable to take a screenshot due to an error.

  Command failed: /Users/xxx/project/test-cafe-demo/node_modules/testcafe/node_modules/testcafe-browser-tools/bin/mac/screenshot
  79919 /Users/xxx/project/test-cafe-demo/screenshots/my-fixture/test1.png
  There are no TestCafe windows

We're going to publish the<EMAIL_ADDRESS>version soon with updated testcafe-browser-tools

I'm sorry, the takeScreenshot function can't work properly now.I did nothing about the test script.

Can you install<EMAIL_ADDRESS>and check how it works there, please?

@AndreyBelym Hi, I had install 0.17.2, and the testcafe-browser-tools is 1.4.5 now.It didn't make it .
Os: Mac 10.11.
Node:  8.0.0

Is it the same error, can you post it here? What browser do you use?

Well, It log nothing in the terminal.And the process exit.

So you mean that you can't run tests with 0.17.2? Or that tests was finished, but screenshots hadn't been created and there was no warning in the log? Have you tried to perform a fresh install (remove the node_modules durectory and install TestCafe locally)?

Sorry, I rewrite the reporter plugin. I use the json reporter now.
And the terminal print the warning info:
 Warnings (3):
 --
  Was unable to take a screenshot due to an error.

  Command failed: /Users/XRene/project/test-cafe-demo/node_modules/testcafe-browser-tools/bin/mac/generate-thumbnail ../screenshots/fixture/login-success.png
  ../screenshots/fixture/thumbnails/login-success.png 240 130

 --
  Was unable to take a screenshot due to an error.

  Command failed: /Users/XRene/project/test-cafe-demo/node_modules/testcafe-browser-tools/bin/mac/generate-thumbnail ../screenshots/fixture/ticket-list.png
  ../screenshots/fixture/thumbnails/ticket-list.png 240 130

 --
  Was unable to take a screenshot due to an error.

  Command failed: /Users/XRene/project/test-cafe-demo/node_modules/testcafe-browser-tools/bin/mac/generate-thumbnail
  ../screenshots/2017-09-06_08-36-11/test-1/Chrome_60.0.3112_Mac_OS_X_10.11.0/errors/1.png ../screenshots/2017-09-06_08-36-11/test-1/Chrome_60.0.3112_Mac_OS_X_10.11.0/errors/thumbnails/1.png 240 130

Just to be sure, can you please post the output of testcafe -v and give me the exact command you use to run tests? Was the browser closed successfully by TestCafe after tests?

testcafe -v is : 0.17.2
and I run the test through the node api:
const createTestCafe = require('testcafe')
let runner = null
let testcafe = null

createTestCafe('localhost', 1337, 1338)
  .then(tc => {
    testcafe = tc
    runner = tc.createRunner()
  })
  .then(remoteConnection => {
    runner
      .src('fixtures/ticketbuyer.js')
      .browsers('chrome')
      .reporter(() => {
        return require('@my/testcafe-reporter-dtest')()
      })
      .screenshots('../screenshots', true)
      .run({
        skipJsErrors: true,
        assertionTimeout: 7000,
        speed: 0.3
      })
      .then(failedCount => {
        testcafe.close()
      })
      .catch(error => {
        console.log(error)
        testcafe.close()
      })
  })

After tests, the browser didn't close. But it show the disconnected info.

Hello again, unfortunately we couldn't be able to reproduce the problem. Can you please try to install a debug build (npm install testcafe@0.17.3-git201709131433), run your test, and post the contents of the testcafe-browser-tools.log and find-window.log files from your home directory?

Hello,  I did as you said, but it is always loading and last i got this error:
ERROR Unable to establish one or more of the specified browser connections. This can be caused by network issues or remote device failure.

and this is the content of testcafe-browser-tools.log, what should i do?
Thu Sep 14 2017 10:36:29 GMT+0800 (CST) find-window
Thu Sep 14 2017 10:36:29 GMT+0800 (CST) find-window before 1st exec
Thu Sep 14 2017 10:38:27 GMT+0800 (CST) close
Thu Sep 14 2017 10:38:27 GMT+0800 (CST) find-window
Thu Sep 14 2017 10:38:27 GMT+0800 (CST) find-window before 1st exec
Thu Sep 14 2017 10:38:27 GMT+0800 (CST) find-window Error: Command failed: /usr/bin/osascript /Users/xxx/node_modules/testcafe-browser-tools/bin/mac/find-window.scpt S1g74iPwcW
/Users/xxx/node_modules/testcafe-browser-tools/bin/mac/find-window.scpt: execution error: 文件许可错误。 (-54)

    at ChildProcess.exithandler (child_process.js:211:12)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:885:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
Thu Sep 14 2017 10:38:27 GMT+0800 (CST) close failed to get window

Do you have the "find-window.log" file in your home directory?

By the way, could you try<EMAIL_ADDRESS>please, and try to attach the find-window.<some number>.log files and the testcafe-browser-tools.log file, please?

I'm closing this since there were no activity here for a long time. Feel free to reopen the issue if it's still needed.
Also, you can try to run your tests on the latest TestCafe version.


Publish version 1.1

... with fixes and improvements.

Experiment -> Sample ref is optional. I think this is a bug.


Mono: Godot does not generate Generated directory

While glue generating, Godot does not generate Generated directory, but generates mono_glue.gen.cpp
I am using Windows 10,
Mono version: Mono JIT compiler version 6.10.0 (Visual Studio built mono),
Visual Studio 2019 Developer Command Prompt v16.7.0

I am typing the following commands:
scons p=windows tools=yes module_mono_enabled=yes mono_glue=no
--> bin/godot.windows.tools.64.mono.exe is created
bin/godot.windows.tools.64.mono.exe is created --generate-mono-glue modules/mono/glue
--> process exits without any problems
scons p=windows tools=yes module_mono_enabled=yes mono_glue=yes
--> fails because no 'Generated' directory found
MSBuild path: C:\Program Files\dotnet\dotnet.exe
Microsoft (R) Build Engine 16.7.0-preview-20360-03+188921e2f dla platformy .NET
Copyright (C) Microsoft Corporation. Wszelkie prawa zastrzeżone.

C:\Users\ketra\Downloads\godot-master\modules\mono\glue\GodotSharp\GodotSharp\GodotSharp.csproj(70,3): error MSB4019: Not found project: "C:\Users\ketra\Downloads\godot-master\modules\mono\glue\GodotSharp\GodotSharp\Generated\GeneratedIncludes.props".
...
scons: *** [bin\GodotSharp\Api\Debug\GodotSharp.dll] RuntimeError : 'msbuild' exited with error code: 1

File modules/mono/glue/mono_glue.gen.cpp IS GENERATED, but rest of api (modules/mono/glue/Managed/Generated) is not.
I spent many hours trying to rebuild Godot with Mono on many different ways, but still --generate-mono-glue option doesn't produce Generated directory. I even tried to enforce define:
#define DEBUG_METHODS_ENABLED
#define TOOLS_ENABLED
#define MONO_GLUE_ENABLED

but result was the same: mono_glue.gen.cpp is generated, but rest of api is not.

Does anybody know what am I doing wrong?
Can anybody send me a zip with 'Generated' directory?

@TheKetrab Which Godot version are you compiling? Please fill in the issue template instead of replacing it when creating issues.

bin/godot.windows.tools.64.mono.exe is created --generate-mono-glue modules/mono/glue

If that's what you typed, the "is created" part is wrong and this would likely fail.


Update Wcms.php

Minor comments copy changes.
Moved themes and plugins to the data directory.
Fixed 404 pages and visiting /logout throwing errors (removed array declaration in notFoundView also added isset for the token check to avoid the error).
Uncommented the plugin loading, as the Summernote editor works now (will be uploaded shortly).

Builds from devFixes do not work.
The folders themselves have yet to be moved into the data directory

@notcarbide thanks, files have been moved. 👍

Are they in the right directory? The code and comments imply that it should be in data rather than assets

🤦♂ (double facepalm). Will fix it when I get home.
Thanks again @notcarbide.

Should be fine now. All this folder "restructuring" got me thinking if "data" is the correct folder for these themes and plugins, since they don't contain any user generated data.
When the update functionality is going to be implemented, all the files will be overwritten, except the data folder, which will contain the users database.js and their respective uploaded files.
Does it make sense to mix the two?

possibly if the user has made a custom theme?

If getting the sense that this two should be probably separated (as they were before).
What do you guys think? @NicolasCARPi @notcarbide

I agree that data probably isn't the best place for them unless they are user downloaded/custom themes or plugins.

@notcarbide @NicolasCARPi would it still be possible to preserve custom themes and plugins if they are outside the data folder (when using the future "one click update")?
That's why my initial thought was to get them to the data folder and always preserve them, while we can still preform updates to those themes/plugins (through the URL to ZIP functionality).

The idea is that the data folder is only for the user generated content. All else should ship with the release.


ModuleNotFoundError: No module named 'scenic.projects.token_learner'

Hi, why this error occurs when trying to run the code with the command blow
"
python scenic/projects/token_learner/main.py --
--config=scenic/projects/token_learner/configs/im1k_token_learner_config.py
--workdir=token_learner/
"

@F-Yuan303 I think that this is due to relative imports.

I think a _init_.py is missing and I look at it later, but feel free to send a PR if you have a fix.

I think a __init__.py is missing and I look at it later, but feel free to send a PR if you have a fix.

Both vivit and token_learner can't be found whne imort them

Hello everyone, I was getting a similar issue when I tried to run the example included in the README file:
$ python scenic/main.py -- \
  --config=scenic/projects/baselines/configs/imagenet/imagenet_vit_config.py \
  --workdir=./

Traceback (most recent call last):
  File "/zfs1/home/userenv/Scenic/scenic-main/scenic/main.py", line 27, in <module>
    from scenic.train_lib import trainers
  File "/home/userenv/.conda/envs/scenic/lib/python3.9/site-packages/scenic/train_lib/trainers.py", line 18, in <module>
    from scenic.train_lib.transfer import transfer_trainer
ModuleNotFoundError: No module named 'scenic.train_lib.transfer'

It seems that I fixed it just by adding a blank __init__.py to both scenic\train_lib\transfer and  scenic\train_lib\transfer\tests folders, and redoing the installation with pip install .

I had the same problem，you can try insert:
" import os, sys
sys.path.append(os.getcwd())" before "from scenic import XXX".


add qformer model to torchmm/models

Summary: as title
Differential Revision: D50145316

Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b8226b9) 72.58% compared to head (0d7f15d) 73.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   72.58%   73.44%   +0.86%
==========================================
  Files         195      201       +6
  Lines       13248    13697     +449
==========================================
+ Hits         9616    10060     +444
- Misses       3632     3637       +5

Files
Coverage Δ

tests/models/blip2/test_qformer_layers.py
100.00% <100.00%> (ø)

tests/models/blip2/test_qformer_model.py
100.00% <100.00%> (ø)

tests/models/blip2/test_qformer_utils.py
100.00% <100.00%> (ø)

torchmultimodal/models/blip2/qformer_utils.py
100.00% <100.00%> (ø)

torchmultimodal/models/blip2/qformer_model.py
98.03% <98.03%> (ø)

torchmultimodal/models/blip2/qformer_layers.py
96.63% <96.63%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


OpenTelemetry versioning test

Purpose of this pull request
"OpenTelemetry versioning test"
Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions and updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

Closing - this was a test


BRS-653: A&R Login Page

Jira Ticket:
BRS-653
Jira Ticket URL:
https://bcparksdigital.atlassian.net/browse/BRS-653
Description:

Added a custom login page for Attendance and Revenue
Changed the existing Not Authorized page to use a single column layout (similar to the new login page)
Infers the selected Identity Provider from the JWT token after successful log in and stores it in sessionStorage so future login requests to Keycloak will use the same IDP, even if the application is reloaded and its state is lost.

This log in page is very laggy, especially when you open your console. I noticed that the loading bar is constantly firing on this page:

This corresponds with a pending request to fetch parks. This pending request is not resolving because it requires authentication to happen. Of course this isn't happening because you are in the process of logging in:

This fetch park is the result of the autofetcherService. The auto fetcher should run after your have been authenticated to prevent this endless pending request.


Automatic Type Acquisition does not work

TS Template added by @mjbvz
TypeScript Version: 3.8.3
Search Terms

automatic type acquisition / ATA
jest

VSCode Version: 1.43.2
OS Version: macOS Catalina 10.15.4 (19E266)

Steps to Reproduce:
$ mkdir test-jest-types
$ cd test-jest-types
$ npm init -y
$ npm i --save-dev jest
$ echo "describe('xxx')" > index.test.js
$ code --disable-extensions .

Now open the index.test.js file in VSCode, see there is TS error because jest type acquisition did not work and describe is missing type annotation.

Does this issue occur when all extensions are disabled?: Yes
I would like if the ATA work without the need for workarounds such as:

Creating a jsconfig.json or tsconfig.json with explicitly saying i want jest type definitions
Installing npm i --save-dev @types/jest as a dependency of the project
Installing the types globally npm i -g @types/jest

I used the empty jscongif.json with type acquisition:
// jsconfig.json
{
  "typeAcquisition": {
      "include": ["jest"]
  }
}

This is working fine for me with the provided repro steps + jsconfig file

It's kinda reproducible - requires 10-12s before Jest types will be added to program and I see any before that and no indication in status bar.
Steps:

Add index.test.js and jsconfig.json from steps above. Save jsconfig.json
See that there is Fetching data for better TypeScript IntelliSense in status bar and Jest types available when message is hidden.
Reload window while index.test.js is focus or open it after reload.
Initializing JS/TS language features shows for 1-2s.
Hover over describe - any
Wait for 10-15s and hover over describe again - var describe: jest.Describe

So I would say than in my case it's Fetching data for better TypeScript IntelliSense which is missing to notify me that not everything has been processed at this moment.

In case it helps anyone, setting the typeAcquisition.enable property to true worked for me for a similar problem.
{
  // ...
  "typeAcquisition": {
    "enable": true,
    "include": [
      "node",
      "vscode",
      // ...
    ],
  },
}

Oddly enough, it needed this only in tsconfig.json, not jsconfig.json. Maybe the default is different in those files?

Thank god you found this @geekley 🙏


RunTime Error with One Hot Encoding in training an scvi model

I'm training an scvi model on my AnnData matrix and it gives me a long Runtime error associated with the one-hot encoding

model.train()

There's a much bigger error above this. The last part is the following:
File ~/miniconda3/envs/singlecell/lib/python3.9/site-packages/scvi/nn/_utils.py:7, in one_hot(index, n_cat)
      5 """One hot a tensor of categories."""
      6 onehot = torch.zeros(index.size(0), n_cat, device=index.device)
----> 7 onehot.scatter_(1, index.type(torch.long), 1)
      8 return onehot.type(torch.float32)

RuntimeError: index -1 is out of bounds for dimension 1 with size 9

Versions:

'0.15.0'

Can you describe what model you're using, how you ran setup anndata, what your anndata contains, and the output of model.view_anndata_setup()?

Also if you could provide a script of how you initialize and train the model, that would be super helpful.

Actually - I found the problem. One of the categorical covariates that I specified in my model had 'Nan' in anndata.obs . When I removed them, the training went smoothly.
This is my code for training the model:
scvi.model.SCVI.setup_anndata(all_matrices_hg38 , layer="counts",
    categorical_covariate_keys=[ "sample", "phase", "run"],
    continuous_covariate_keys=["pct_counts_mt", "pct_counts_ribo"] )

In my data, the variable 'sample' had some Nan's in there that I hadn't removed by mistake. Maybe this could be a data check method we could build into scvi? like a piece of a code that makes sure that the input AnnData doesn't have any such missing data that would throw errors in the TensorFlow code?

Yes that is a very good thing we should add, I'll leave this issue open until we add this.

I am also happy to take care of this and make a pull request if you'd like.

If you'd like! We need to refactor a bit this part
https://github.com/scverse/scvi-tools/blob/a5a7c596d1057a9fcd46dafd2a935b8ebbfbbc8d/scvi/data/fields/_obsm_field.py#L309-L318
to use the checks found here:
https://github.com/scverse/scvi-tools/blob/a5a7c596d1057a9fcd46dafd2a935b8ebbfbbc8d/scvi/data/_utils.py#L123
Basically what happened is nan results in -1 in the categorical object codes, which this util picks up, but is not used for categorical_covariate_keys. I think we can lightly refactor the util a bit.... @jjhong922 might have a better idea.

Thanks for sending this! I will run this code line by line on my AnnData object with the nan's to see where the -1 appears. I will probably do this tomorrow and will follow up then.

@sohitmiglani we are on a sprint for the next patch release, @jjhong922 will take care of this and we will have a new release tomorrow or the next day. I would hope you can contribute something in the future!!


Fails to start

This error shows up in the runtime log:
'configuration.semanticTokenType.description' must be defined and can not be empty

Duplicate of #7.


Add redeployImplementation option

Adds the following option: redeployImplementation: ("always" | "never" | "onchange") Determines whether the implementation contract will be redeployed. Defaults to "onchange".

If set to "always", the implementation contract is always redeployed even if it was previously deployed with the same bytecode. This can be used with the salt option when deploying a proxy through OpenZeppelin Platform to ensure that the implementation contract is deployed with the same salt as the proxy.
If set to "never", the implementation contract is never redeployed. If the implementation contract was not previously deployed or is not found in the network file, an error will be thrown.
If set to "onchange", the implementation contract is redeployed only if the bytecode has changed from previous deployments.

Deprecates useDeployedImplementation which is equivalent to redeployImplementation = "never"

Ideally, if the user specifies salt, we only redeploy if the existing implementation was deployed with another salt. But I understand that we may not want to implement this right now. What do you think about forcing the user to use redeploy: 'always' when they specify a salt? If we do this, we can change the default behavior in the future.

What do you think about forcing the user to use redeploy: 'always' when they specify a salt

I don't think we should do this.  Users may want to run proposeUpgrade with a salt.  If they run it again with the same salt (for example, they want to propose an upgrade for another proxy), forcing redeploy: 'always' would result in a deployment error for the implementation because the resulting address would be the same.


Error spam when running the test suite

Godot version
4.2.dev (
System information
Mageia 9 - Vulkan (Forward+) - dedicated AMD Radeon RX Vega M GL Graphics (RADV VEGAM) () - Intel(R) Core(TM) i7-8705G CPU @ 3.10GHz (8 Threads)
Issue description
When compiling Godot with dev_build=yes tests=yes, running the test suite succeeds, but prints a lot of errors:
$ ./bin/godot.linuxbsd.editor.dev.x86_64 --test
[doctest] doctest version is "2.4.11"
[doctest] run with "--help" for options
ERROR: Condition "singleton != nullptr" is true.
   at: NavigationServer3D (./servers/navigation_server_3d.cpp:189)
ERROR: Resource was not pre cached for the resource section, bug?
   at: _write_resource (./scene/resources/resource_format_text.cpp:1848)
WARNING: Couldn't load resource (no cache): local://Resource_q0hwh
     at: parse_variant (./core/io/resource_format_binary.cpp:411)
ERROR: The object does not have any 'meta' values with the key 'next'.
   at: get_meta (./core/object/object.cpp:926)
ERROR: The object does not have any 'meta' values with the key 'next'.
   at: get_meta (./core/object/object.cpp:926)
ERROR: Condition "map == nullptr" is true. Returning: Vector3()
   at: map_get_closest_point (./modules/navigation/godot_navigation_server.cpp:241)
ERROR: Condition "map == nullptr" is true. Returning: Vector3()
   at: map_get_closest_point_normal (./modules/navigation/godot_navigation_server.cpp:248)
ERROR: Condition "map == nullptr" is true. Returning: RID()
   at: map_get_closest_point_owner (./modules/navigation/godot_navigation_server.cpp:255)
ERROR: Condition "map == nullptr" is true. Returning: Vector3()
   at: map_get_closest_point_to_segment (./modules/navigation/godot_navigation_server.cpp:234)
ERROR: Condition "map == nullptr" is true. Returning: Vector3()
   at: map_get_closest_point_to_segment (./modules/navigation/godot_navigation_server.cpp:234)
ERROR: Condition "map == nullptr" is true. Returning: Vector<Vector3>()
   at: map_get_path (./modules/navigation/godot_navigation_server.cpp:227)
ERROR: Condition "map == nullptr" is true. Returning: Vector<Vector3>()
   at: map_get_path (./modules/navigation/godot_navigation_server.cpp:227)
ERROR: Condition "map == nullptr" is true. Returning: r_query_result
   at: _query_path (./modules/navigation/godot_navigation_server.cpp:1161)
ERROR: Condition "!map" is true. Returning: Vector3()
   at: get_connection_pathway_end (./modules/navigation/nav_region.cpp:98)
ERROR: Condition "!map" is true. Returning: Vector3()
   at: get_connection_pathway_start (./modules/navigation/nav_region.cpp:92)
WARNING: NavigationServer3D::region_bake_navigation_mesh() is deprecated due to core threading changes. To upgrade existing code, first create a NavigationMeshSourceGeometryData3D resource. Use this resource with method parse_source_geometry_data() to parse the SceneTree for nodes that should contribute to the navigation mesh baking. The SceneTree parsing needs to happen on the main thread. After the parsing is finished use the resource with method bake_from_source_geometry_data() to bake a navigation mesh..
     at: region_bake_navigation_mesh (./modules/navigation/godot_navigation_server.cpp:468)
===============================================================================
[doctest] test cases:     816 |     816 passed | 0 failed | 1 skipped
[doctest] assertions: 2331757 | 2331757 passed | 0 failed |
[doctest] Status: SUCCESS!
WARNING: ObjectDB instances leaked at exit (run with --verbose for details).
     at: cleanup (./core/object/object.cpp:2049)

Some of those errors are intentionally caused by the tests, but they need to be silenced with ERR_PRINT_OFF and ERR_PRINT_ON macros in the test.
CC @smix8 as most are navigation related.
Steps to reproduce

scons dev_build=yes tests=yes
godot --test

Minimal reproduction project
n/a

CC @godotengine/tests

Those navigation related errors here will trigger when the functions are called without a navigation map sync. If those errors are unwanted basically all those newer navigation related tests (CC @Scony) need to be wrapped with ERR_PRINT_OFF / ERR_PRINT_ON to suppress them.

If this is possible to disable those logs, then it's good idea - I'll experiment with that

The navigation errors were fixed by #80833, so as of 8c1817f75 this is the output:
ERROR: Resource was not pre cached for the resource section, bug?
   at: _write_resource (./scene/resources/resource_format_text.cpp:1848)
WARNING: Couldn't load resource (no cache): local://Resource_q0hwh
     at: parse_variant (./core/io/resource_format_binary.cpp:411)
ERROR: The object does not have any 'meta' values with the key 'next'.
   at: get_meta (./core/object/object.cpp:926)
ERROR: The object does not have any 'meta' values with the key 'next'.
   at: get_meta (./core/object/object.cpp:926)

CC @KoBeWi

I've identified one of the parts, will open a PR for it


Uncaught TypeError: Cannot read property 'length' of undefined

Home Assistant release with the issue:

0.75.0
0.75.1
Last working Home Assistant release (if known):
0.74.2
Operating environment (Hass.io/Docker/Windows/etc.):

Ubuntu Docker
Component/platform:

https://www.home-assistant.io/components/frontend/
Description of problem:
After updating to 0.75.0 i receive the error when opening any view.
Then i updated tot 0.75.1 error appears here as well.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
looks like all switches and sensors are effected.
Traceback (if applicable):

Additional information:
Dev info log error:
Log Details (ERROR)

https://homeassistant_url/frontend_latest/app-c65b4028.js:2:32005 Uncaught TypeError: Cannot read property 'length' of undefined

Already cleared cache and recreated the view.
Chrome developers view shows:
core.js:192 Uncaught TypeError: Cannot read property 'length' of undefined
    at w._format (core.js:192)
    at w._format (core.js:216)
    at w.format (core.js:45)
    at HTMLElement.<anonymous> (app-localize-behavior.js:286)
    at relative_time.js:20
    at HTMLElement.updateRelative (relative_time.js:12)
    at HTMLElement.datetimeChanged (ha-relative-time.js:48)
    at Object.C [as fn] (property-effects.js:214)
    at x (property-effects.js:159)
    at w (property-effects.js:125)

It is l10n issue, which language are you using?
https://github.com/home-assistant/home-assistant-polymer/blob/e048060c72a3e16e63e7f88ed5e40e9d96971686/src/common/datetime/relative_time.js#L21

Hi @awarecan i use the dutch language.
Just switched to english and clicking around in the ui (old and lovelace) no error appears.

Can confirm same issue and resolve it by setting language to English .

I need some volunteer to help verify following languages have same problem
Dutch
Portuguese
Romanian
Slovenian (Slovenia)
Thanks in advance

I have updated related translation in Lokalise, will update them to frontend later.

i can confirm all these languages have the same problem
Dutch
Portuguese
Romanian
Slovenian (Slovenia)

/move to home-assistant/home-assistant-polymer


Switch to https for adaway.org source

Since adaway.org does support ssl. It is still on ssl v1 though.

I dig it.  Thanks @indrajitr !


Update README.md

Please mark as invalid and spam, this is an obvious attempt to get a free t-shirt by 'contributing'(hacktoberfest)
This will also ban the user for trying to abuse the system by doing marginal effort

Please mark as invalid and spam, this is an obvious attempt to get a free t-shirt by 'contributing'(hacktoberfest)
This will also ban the user for trying to abuse the system by doing marginal effort

With you demotivating people like this , open source is going to loose its meaning. Open source is a friendly society , let it remain so

Your intentions are clearly not friendly or meant to be contributing


[WIP] GH-188 - Added npm task to verify solidity contracts

Closes #188

it will be addressed in another PR due to new conflicts with master branch.


Slow compilation of SCSS

I experienced a significant performance decrease with SCSS compilation when moving from Elixir to Mix.
I wanted to ask if anyone has the same issue?
I do not have one project where I can test the performance of both solutions but I have quite similar setup on two different.
The main difference is VueJS version but the JS compilation is quite fast for both.
On both projects I use Bootstrap 3 and here are some numbers:
Laravel Mix without watching:

Whole process: 45 seconds
Only SCSS compilation(js commented out): 37 seconds

Laravel Mix with watching:

Initial full compilation(with JS): 36 seconds
SCSS and JS recompilation: 16 seconds
Initial SCSS only compilation: 32 seconds
Only SCSS recompilation: 15 seconds

Just a notice: All of the 15-16 seconds of SCSS recompilation, the console output is stuck at:
10% building modules 0/1 modules 1 active ...crm_cc\resources\assets\sass\app.scss

Laravel Elixir without watching:

Whole process: SASS 1.84s, Webpack 8.8s, all 11s
Only SCSS compilation: 1.89s

Laravel Elixir with watching:

Initial full compilation: 1.26s
SCSS and JS recompilation: ~40ms(Elixir doesn't show Webpack compilation time)
Initial SCSS only compilation: ~600ms
Only SCSS recompilation: 30-40ms

The changes I did to make it recompile was to add or remove one empty line either in app.scss or app.js.
I tried one project with Bulma framework and the compilation was a little bit faster but it's still ages compared to what I experienced with Elixir.
If you want me to investigate this further, I can setup two identical projects and test it properly.
Versions:

Node: 6.9.5
NPM: 3.10.10
Elixir: 6.0.0-15
Mix: 0.8.8(recently updated from 0.5.* with no difference in performance)
node-sass: 3.13.1 for Elixir, 4.5.0 for Mix
OS: Windows 10

Running yarn run watch or npm run watch makes no difference, but if it helps I have<EMAIL_ADDRESS>

Webpack is doing a lot more work than Laravel Elixir and Gulp, so you can't really compare the two.
You might try disable CSS url processing. This is a lengthy process that you may not need for your build. Just depends on how you've organized things. Give it a shot.
mix.sass('src', 'output')
    .options({ processCssUrls: false });

I have created an empty project with just Bootstrap 4 SCSS compilation and it completes in several seconds and recompiles in 1.5 second.
I'll have to look into existing projects to pinpoint the issue and get back to you once I have it figured out.

After a problem describe in this issue : https://github.com/JeffreyWay/laravel-mix/issues/538 and corrected by deleting the files public/mix-manifest.json, public/css/app.css and public/js/app.js I got exactly the same problem that you describe. Sass is very slow and stuck at 10%. Any idee why ?

Yup, I moved font-awesome styles and fonts out of the elixir compilation and it now takes 1.5s instead of 20+.

Holy glob, I disabled processCssUrls and build time went from 26460ms to 7268ms.

Here is my webpack.mix.js. It works perfectly fine on dev, but on production, takes a hell lot of time :(
On Production: DONE  Compiled successfully in 286391ms

mix.js('resources/assets/js/app.js', 'public/js')
.extract(['vue', 'jquery']);
mix.sass('resources/assets/sass/app.scss', 'public/css')
.options({
  processCssUrls: false
});

mix.combine([
    'public/css/app.css',
    'resources/assets/css/nprogress.min.css',
    'resources/assets/css/style.css'
], 'public/css/custom.css')
    .minify('public/css/custom.css');

mix.combine([
    'public/js/manifest.js',
    'public/js/vendor.js',
    'resources/assets/js/nprogress.min.js',
    'public/js/app.js',
    'resources/assets/js/main.js',
], 'public/js/custom.js')
    .minify('public/js/custom.js');

I am sure, something is drastically wrong, but can't figure out what.

@milanchheda Need more details on your production server.

@ruchern - Do you need server configuration or output of npm run prod command? What should be an ideal configuration?

@milanchheda, I think what @ruchern meant was: what is your operating system, what are the Node and NPM versions etc.

@KKSzymanowski - Here are the details:
OS: Ubuntu 16.04.2
Node: v6.10.3
NPM: 3.10.10
I am using Laravel Forge with AWS, having an EC2 instance with 1 GB RAM.

@milanchheda I think your RAM is quite low and might be resulting in slower build speeds.
Do you have a swap file of at least 2GB?
sudo swapon -s and tell me the size.

@ruchern - I upgraded my instance from t2.micro to t2.small and it worked.
It now takes: DONE  Compiled successfully in 13207ms. Much much faster than previous state. Previously, it took 286391ms.

I also have the same issue, it takes more than 20 seconds to compile the SCSS and around 17 seconds for a recompile when I am using watch. It's painful to work with this.

I also have the same issue, it takes more than 20 seconds to compile the SCSS and around 17 seconds for a recompile when I am using watch. It's painful to work with this.

same issue at here.

Webpack is doing a lot more work than Laravel Elixir and Gulp, so you can't really compare the two.
You might try disable CSS url processing. This is a lengthy process that you may not need for your build. Just depends on how you've organized things. Give it a shot.
mix.sass('src', 'output')
    .options({ processCssUrls: false });

Wow, thanks, I had these problems lately, it took me 13000ms+ for every scss file save, and just after using this options, it becomes no more than 700ms, lol.


fzf: 0.17.4 -> 0.17.5

Motivation for this change
Changes: https://github.com/junegunn/fzf/blob/master/CHANGELOG.md
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build fzf

Success on x86_64-linux (full log)
Attempted: fzf
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/i4yn2szfzixlv6730il87ybahp5q2dmv-fzf-0.17.5
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/i4yn2szfzixlv6730il87ybahp5q2dmv-fzf-0.17.5
checking for references to /build in /nix/store/i4yn2szfzixlv6730il87ybahp5q2dmv-fzf-0.17.5...
shrinking RPATHs of ELF executables and libraries in /nix/store/pdrnjc3hm1yj9jc2isb0azd4zpyyjjaw-fzf-0.17.5-man
gzipping man pages under /nix/store/pdrnjc3hm1yj9jc2isb0azd4zpyyjjaw-fzf-0.17.5-man/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/pdrnjc3hm1yj9jc2isb0azd4zpyyjjaw-fzf-0.17.5-man
checking for references to /build in /nix/store/pdrnjc3hm1yj9jc2isb0azd4zpyyjjaw-fzf-0.17.5-man...
/nix/store/b6gxqngpwhpa975wjvpi4kdpl9zzysng-fzf-0.17.5-bin

Success on aarch64-linux (full log)
Attempted: fzf
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/cb3waq5nm7yw8i14c55zar7v9jgfz69x-fzf-0.17.5
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cb3waq5nm7yw8i14c55zar7v9jgfz69x-fzf-0.17.5
checking for references to /build in /nix/store/cb3waq5nm7yw8i14c55zar7v9jgfz69x-fzf-0.17.5...
shrinking RPATHs of ELF executables and libraries in /nix/store/n0zp7h0cj45q51pxh9m0hr6a5cz3ghqa-fzf-0.17.5-man
gzipping man pages under /nix/store/n0zp7h0cj45q51pxh9m0hr6a5cz3ghqa-fzf-0.17.5-man/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/n0zp7h0cj45q51pxh9m0hr6a5cz3ghqa-fzf-0.17.5-man
checking for references to /build in /nix/store/n0zp7h0cj45q51pxh9m0hr6a5cz3ghqa-fzf-0.17.5-man...
/nix/store/jjgmk73hbc5w11q8v29jgzng94xxv7g7-fzf-0.17.5-bin

Success on x86_64-darwin (full log)
Attempted: fzf
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/kasnwx15d06bndqaqazgsp8ngidfrd96-fzf-0.17.5-bin/bin
patching script interpreter paths in /nix/store/kasnwx15d06bndqaqazgsp8ngidfrd96-fzf-0.17.5-bin
/nix/store/kasnwx15d06bndqaqazgsp8ngidfrd96-fzf-0.17.5-bin/bin/fzf-share: interpreter directive changed from "/bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/kasnwx15d06bndqaqazgsp8ngidfrd96-fzf-0.17.5-bin/bin/fzf-tmux: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/bash"
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/m9vkh55xah903jmzb3hm5rqj80akbzna-fzf-0.17.5
gzipping man pages under /nix/store/riwi28pa5ahpr2p3p9h7iz4nzfyf4n93-fzf-0.17.5-man/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/riwi28pa5ahpr2p3p9h7iz4nzfyf4n93-fzf-0.17.5-man
/nix/store/kasnwx15d06bndqaqazgsp8ngidfrd96-fzf-0.17.5-bin


nodemon: not found

After ran the command npm start I got the following error:
shahalom@microsolutionsbd ~/www/react-projects/React-Mini-Social-Network $ npm start

<EMAIL_ADDRESS>start /home/shahalom/www/react-projects/React-Mini-Social-Network
nodemon app.js

sh: 1: nodemon: not found
npm ERR! Linux 4.4.0-97-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start"
npm ERR! node v4.2.6
npm ERR! npm  v3.5.2
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>start: nodemon app.js
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'nodemon app.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the single-page-social-network package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     nodemon app.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs single-page-social-network
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls single-page-social-network
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/shahalom/www/react-projects/React-Mini-Social-Network/npm-debug.log
==================
FYI, here is the content of .env file:
PORT=YOUR_PORT
MYSQL_HOST="host"
MYSQL_USER="root"
MYSQL_PASSWORD="123456"
MYSQL_DATABASE="react_mini_social_network"
<EMAIL_ADDRESS>MAIL_PASSWORD="mypass"
SESSION_SECRET_LETTER="asecret"
Do you have any idea why i am having the error?

You should first install nodemon globally!!


toolbox turns of compass at launch

Elitar — Today at 22:35
why toolbox hides compass at launch ?

Having the same issue.
To Reproduce:

Start Guild wars
Log in to any char
Start Toolbox
Compass gets hidden, but can be rechecked in the Interface settings


Added the beforeDatasetsUpdate lifecycle hook in order to refresh the callbacks

Problem

If a chart's onDragStart, onDrag, or onDragEnd callbacks are changed as a form of data update and the chart.update() function is called then the old callbacks are still run instead of potential new ones.

Solution

The beforeDatasetsUpdate lifecycle hook was added as per the diagram found here. The documentation can be found here.
The callbacks are compared with the cached callbacks from the initial on afterInit hook. If the callbacks are different then the listeners are re attached.

Thanks for the contribution, yet after reading the code, I believe the proposed behaviour - without testing - would cause a problem with old callbacks still being called by listeners attached previously. This would mean the PR needs some rework.
Anyway, this will no longer be an issue since #146 fixed both this issue and #125; also, it seems like #125 is a duplicate of this.


Node-red simple property use

I am trying to create custom node, I am experimenting with very simple one. I need to use the node's property, chosen by the user from a dropdown, to send/output the value of that property with msg.payload.

This is the error msg in the debug tab:

4/7/2017 21.45.06node: lolo
msg : error
"ReferenceError: $ is not defined"

This is the desired out if I remove the line with $ in js file, it does not recognize jquey. I use this instead msg.payload = msg.payload +"[" + nodeName+":"+ node.axis +"]"; but the option value is undefined instead of value of one of the options from select dropdown :

5/7/2017 11.34.22node: 5aa4aa59.f9fa04
msg.payload : string[19]
"ppp[lolo:undefined]"

This is the html file for the node:

This is the js file for the node:

module.exports = function(RED) {
    function helloWorld(config) {
        RED.nodes.createNode(this,config);
        //var context = this.context();
		var nodeName = this.name;
		var axis = config.axis;
        var node = this;
		//var $ = require('jQuery');
		var x = $("#node-input-axis").val();
        this.on('input', function(msg) {
			msg.payload = msg.payload +"[" + nodeName+":"+ x +"]";
			//{payload: nodeName+" "+node.axis};
			node.send(msg);
        });
		//console.log(value);
    }
    RED.nodes.registerType("Hello World",helloWorld);
};

Hi, thanks for raising an issue.
To repeat what I suggested in my email.
If you check out our contribution guidelines you'll see we prefer to handle this sort of thing on the mailing list, slack team or you could ask a question on Stack Overflow and tag it node-red. That way the whole Node-RED user community can help, rather than rely on the core development team.
Thanks!

Just a quite hint on this. The .js file runs in the node.js runtime. It has no access to the browser environment, so you cannot access $("#node-input-axis").val();, there is no jquery etc.
After you have configured a node in the editor and hit the Deploy button, the configuration is sent to the runtime. It will then get passed into your helloWorld constructor function - where config.axis should contain the selected value from the edit dialog.
If config.axis is not set as you expect, I suggest you add an oneditsave function to your node's .html definition and add some debug to check the value of $("#node-input-axis").val(); when the edit dialog is closed.


checktools.go:PackVersion() : semver fails if pack version has no suffix

https://github.com/GoogleCloudPlatform/buildpacks/blob/3baeef333c57b23ceca2b9cb654080480396c049/internal/checktools/checktools.go#L79
On my system exec.Command("/usr/bin/pack", "--version") returns "0.35.0\n"
Passing this value to semver.NewVersion() fails with "Invalid Semantic Version" because of the trailing "\n"
Solution :
version, err := semver.NewVersion(strings.Split(strings.TrimSuffix(string(out), "\n"), "+")[0])

Fixed in commit 15042bf (Ensure clean version parsing by stripping trailing newline)