Use transifex to manage translations

It's really hard to manage translations if there are some new ones popping out. It would be good to use service as transifex to manage it.

I've just looked into this Transifex thing. My thoughts:

It's at least 79 USD / month.
The basic functionality is that it stores message files and shows two of them side by side in an editor. This does not worth 79 USD, either per month or per year. This functionality is already a part of (or able to be added as plugin) to the mainstream free IDEs, like IntelliJ IDEA [1] - and it highlights new messages that are incomplete (I've just tried it a moment ago). And also there are standalone tools which can be used by non-developers [2] [3]. I don't think we need more than this. :)
The other shiny feature of Transifex is "Live" which is an in-place editor/translator: one can edit texts on the website itself where it appears. But then (instead of language files) a JavaScript snippet is needed to display every text by Transifex in the appropriate language. This would make the site completely unusable without JS. Currently the site does use JS, but one can browse content without it - and I don't want to throw away this thing. :)

[1] https://www.jetbrains.com/help/idea/2016.2/resource-bundle-editor.html
[2] http://www.softteco.com/blog/java-resource-file-editor/
[3] https://marketplace.eclipse.org/content/properties-editor-3-standalone-java-i18n-tool

Transifex do offer a free option for open source projects. It looks like they've taken the direct application form for that off their site, but you can still contact them to request open source accounts.
There are also a range of self-hosted open source equivalent projects - though when we evaluated a few for Open Contracting Data Standard translation we found Transifex to be the easier option to integrate.

So Transifex + live editing on stage server for non-tech people (like procurement experts) would be nice-to-have (low priority imho).
As a dev I'm happy with what you Zsolt have provided - IDEA plugin I will try. :)


Not compatible with Bun

Making a new issue here in case the other gets buried as it's closed
https://github.com/apple/app-store-server-library-node/issues/173#issuecomment-2334604252
When I import the library for use within Bun and execute
const appleRootCAs: Buffer[] = await loadAppleRootCertificates();
const enableOnlineChecks = true;
const environment = env.APPLE_ENVIRONMENT === "PRODUCTION"
? Environment.PRODUCTION
: Environment.SANDBOX;

const appAppleId = env.APPLE_ENVIRONMENT === "PRODUCTION"
? Number(env.APP_APPLE_ID)
: undefined; // appAppleId is required when the environment is Production

const verifier = new SignedDataVerifier(
appleRootCAs,
enableOnlineChecks,
environment,
bundleId,
appAppleId,
);

I get the error:
Error processing transaction: 40 |     constructor(appleRootCertificates, enableOnlineChecks, environment, bundleId, appAppleId) {
41 |         this.JWSRenewalInfoDecodedPayloadValidator = new JWSRenewalInfoDecodedPayload_1.JWSRenewalInfoDecodedPayloadValidator();
42 |         this.JWSTransactionDecodedPayloadValidator = new JWSTransactionDecodedPayload_1.JWSTransactionDecodedPayloadValidator();
43 |         this.responseBodyV2DecodedPayloadValidator = new ResponseBodyV2DecodedPayload_1.ResponseBodyV2DecodedPayloadValidator();
44 |         this.appTransactionValidator = new AppTransaction_1.AppTransactionValidator();
45 |         this.rootCertificates = appleRootCertificates.map(cert => new crypto_1.X509Certificate(cert));
                                                                       ^
TypeError: undefined is not a constructor (evaluating 'new crypto_1.X509Certificate(cert)')
      at /Users/desktopuser/backend/node_modules/@apple/app-store-server-library/dist/jws_verification.js:45:67
      at map (1:11)
      at new SignedDataVerifier (/Users/desktopuser/backend/node_modules/@apple/app-store-server-library/dist/jws_verification.js:45:55)

I assume this has something to do with the crypto module however Bun I thought had support for node functions whether via
import { X509Certificate } from "node:crypto";
new X509Certificate(...);

or
Although the export exists it is marked as "missing" here https://bun.sh/docs/runtime/nodejs-apis#node-crypto , and when I try the following:
import { X509Certificate } from "node:crypto";

const certs = await loadAppleRootCertificates();

for (const cert of certs) {
	const x509cert = new X509Certificate(cert);
	console.log(x509cert);
}

I get the error: SyntaxError: Export named 'X509Certificate' not found in module 'crypto'. any thoughts on using a polyfill/library that doesn't depend on the node library itself and can bundle in support which doesn't call the node lib? A microservice? Forking to use node-forge replacing the "node native (but not supported elsewhere)" crypto package? Either that or should the transactions then be manually verified using JOSE/jsonwebtoken? If so can you provide an example of this?

As you stated, Bun does not appear to support X509Certificate at this time, which is part of the cryptographic verification process. As this is core cryptography to the process, we recommend using Node.js.

Fair enough @alexanderjordanbaker! I created a workaround with Bun I will edit this thread with. Thank you.

Fair enough @alexanderjordanbaker! I created a workaround with Bun I will edit this thread with. Thank you.

hi @Faolain could you share your workaround?

Yeah of course, you can spawn a node process within bun
async function verifyAndDecodeTransaction(jws: string): Promise<string> {
	const proc = Bun.spawn(["node", "process-cert.js", jws], {
		cwd: path.join(import.meta.dir, "../../node-scripts"),
	});

	const stdout = await new Response(proc.stdout).text();
	const stderr = await new Response(proc.stderr).text();

	if (stderr) {
		console.error("Error during process execution:", stderr);
		throw new Error(`Node process failed: ${stderr}`);
	}
	return stdout;
}

where your node script is just the normal implementation described within this library


Forward slash '/' in %title% creates a folder

Forward slash '/' in %title% creates a folder and a file in the lyrics directory
Steps to reproduce

Play a track with a title containing a '/' example "foo/bar"
Save lyrics using the default scheme "[%artist% - ][%title%]"
Notice the lyrics directory now has a new folder with "ArtistName - foo" and inside it a file called "bar.txt"

Expected behavior
The slash in the filename should be replaced by another character (example "ArtistName - foo_bar.txt")
Versions

foobar2000 version: 1.6.16
OpenLyrics version: 1.5

Additional information
I am using foobar on linux under wine

I don't consider this a bug at all, and applying a "fix" to a behavior intended by design would be counterproductive.
You should replace yourself those chars via TF. https://wiki.hydrogenaud.io/index.php?title=Foobar2000:Title_Formatting_Reference#.24replace.28str.2Csearch.2Creplace.29
That's how it works on every other plugin or instance where TF is used, so don't really understand what you were expecting here... and all other lyrics plugins work the same.

Thanks for the help @regorxxx, I'm content to point people to that as a workaround (I just wasn't sure if titleformat provided a nice way to do it).

Nevermind, I can't use spaces or apostrophes
This one works: [%artist% - ]$replace(%title%,/,_)

My recommendation:
$ascii($replace(%title%,,,/,))


Add benchmarks

For now, there's this fiddle, courtesy of 0x8890.

More benchmarks will be added soon.


Foul flag not saved when exiting the current game

When one loses a level and exits the game before the Foul message pops up, the game can be loaded and played normally. This makes people be able to cheat, which shouldn't be the case.

Fixed in https://github.com/jakubg1/OpenSMCE/commit/4503c480ed8598e8b9dafd5257aeeeb1dd14e58d

Fixed in https://github.com/jakubg1/OpenSMCE/commit/4503c480ed8598e8b9dafd5257aeeeb1dd14e58d


ci: add osv-scanner workflow

What this PR does / why we need it:

Added osv-scanner workflow in order to detect vulnerabilities in project dependencies.
This tool was chosen in order to be aligned with OpenSSF scorecard, which also uses it behind the scenes to determine vulnerabilities score.
The workflow is triggered on both PR and merge to main branch. When triggered from PR it inly fails in case new vulnerabilities are introduced as part of the PR. See more details here.
I fixed some of the detected vulnerabilities as part of this PR(let me know if you think this should be in a separate PR):

Updated sigs.k8s.io/controller-tools in tools/sec/controller-gen to v0.15.0.
Updated go version from 1.12 to 1.22.2 in site folder.
Updated github.com/bufbuild/buf to v1.31.0.
Updated google.golang.org/protobuf to v1.33.0
Updated sigs.k8s.io/controller-runtime/tools/setup-envtest to latest.

There is a single active vulnerability which will be resolved with the next google.golang.org/grpc/cmd/protoc-gen-go-grpc release. See related issue.
I also noticed that tools/src/protoc-gen-go and tools/src/protoc-gen-go-grpc  are missing from dependabot configuration. Is there any particular reason for that? If not I can add them in a separate PR.

Which issue(s) this PR fixes:

Fixes #3167

/retest


Support for interactive authentication using OS default browser

Any idea when this issue will be resolved ?

@hbjamil This will make it into release 1.4, which should be available next week.
Still testing, but the default approach will probably use java.awt.desktop. This will  be configurable, and you will be able to provide your own logic to open the browser. The behavior and API will be very similar to MSAL.NET, described here, except for that we don't support any of the mobile platforms.


Which metrics?

What metrics exactly are available through Intelligent Insights logs?
In particular, as shown here Managed Instance databases do not support the basic metrics or basic logs, but they do support Intelligent Insights.
https://docs.microsoft.com/en-us/azure/sql-database/sql-database-metrics-diag-logging
Can we get info such as per DB IOPS/CPU/memory for Managed Instance from these Intelligent Insights logs?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0d36001d-36c5-909f-7e5f-3b6ef05cd625
Version Independent ID: b9f0a304-3dfd-eab9-cbaf-57a47318aab5
Content: Intelligent Insights performance diagnostics log - Azure SQL Database
Content Source: articles/sql-database/sql-database-intelligent-insights-use-diagnostics-log.md
Service: sql-database
Sub-service: performance
GitHub Login: @danimir
Microsoft Alias: danil

Intelligent Insights are described on this page in detail. Intelligent insights are not raw metrics and they do not provide raw information you are looking for. This is a built in AI that can automatically troubleshoot performance issues listed on this page. Log entry is produced only in case a performance issue is detected, otherwise if all is running good, no log entries are provided.
In terms of your other question, Managed Instance (MI) actually provide IOPS/CPU/memory per instance through SQL analytics which is documented on this page. These metrics are just not exposed in the portal, but you can consume them through log analytics. In terms of your question for these metrics per database, that is not possible nor available as Managed Instance does not govern databases. This means that all databases can use full resources of the instance, and compete for it, hence no CPU/IOPS/memory as a concept of measure exists for MI databases. You would monitor MI performance per the entire instance.
For your monitoring needs for MI, you can also consider using CTP version of SCOM MP for MI which we have recently released.
Thanks.

Thanks @danimir! I understood that the platform metrics are offered per instance, not per DB in MI.
This Intelligent Insights page (that I reported the issue on) has a "Metrics" section - what are we getting there?
https://docs.microsoft.com/en-us/azure/sql-database/sql-database-intelligent-insights-use-diagnostics-log#metrics
DurationIncreaseSeconds and the other two examples that are mentioned at that link don't match any of the platform metrics offered for MI that we see here.
https://docs.microsoft.com/en-us/azure/azure-monitor/platform/metrics-supported#microsoftsqlmanagedinstances
And am I understanding correctly that these platform metrics are NOT shown through Azure Monitor or the SQL MI portal blade?
I'm assisting a customer with guidance but unfortunately I don't have an MI at hand myself and I didn't see any screenshots of the Metrics interface.

dcbrown16 You are making an assumption that instance level metrics and intelligent insights have a relationships - they do not. You cannot compare them the way you are describing as they are not related. Intelligent Insights is a separate product. Think of it as a completely separate system from the standard raw metrics. Intelligent Insight "metrics" in JSON is populated with 14-15 detectable performance that are documented on this page. This is not a raw metrics, but assessment from AI if there is a performance issue on your database, described in a human language. That's it. All available telemetry is already documented and really there is "nothing more" under the covers than already stated on the pages. Thank you.

Sorry @danimir, I understand that platform metrics and Intelligent Insights are not the same. I'm having trouble understanding the "Metrics" section on the page I reported this issue on, then.
That section gives these three possible values.
issue metric type – possible values: DurationIncreaseSeconds, CriticalErrorCount, WaitingSeconds
I don't see how that lines up with the categories of issues on the other page you linked.
The closest I see on that page is the intro sentence stating "Intelligent Insights automatically detects performance issues with SQL Database and Managed Instance databases based on query execution wait times, errors, or time-outs."
So should we understand that all of the 14-15 performance issue categories also include one or more of these three metric values? Are the "metrics" to be seen as supporting evidence for how Intelligent Insights concluded what the performance issue is, like a high value of WaitingSeconds leads to Increased Wait Statistic (just as an example)?


optimize: modify IdWorker position to make it reasonable

Ⅰ. Describe what this PR did
modify IdWorker position to make it reasonable
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

@xingfudeshi @zjinlei PTAL


⚠ Samsung has degraded performance

In 8f2253c, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2667 ms

Resolved: Samsung performance has improved in 10b9c90.


long range tortoise self-healing

self-healing in current software v1.3.* is supported only within tortoise window (4032 layers).
if nodes disagree on consensus result within this window they are expected to recover fast.
to implement self-healing for layers outside tortoise window we need to implement:

uncounted atxs weight tracker
re-loading data for a period that requires self-healing
vote encoding for ballots that allow to encode disagreement for long range (note that concern here is that we don't want to accept long votes during normal operations)

:facepalm: duplicate https://github.com/spacemeshos/go-spacemesh/issues/5122


"Retrieve token: invalid form" in a loged-in session window.

Both @nacx and @vikaschoudhary16 mentioned they run into issues that:

callback URL redirection fails with empty page, and 403.
the authservice prints out the error log such as retrieve token: invalid form.
after using a incognito window, it works.

After some instrumentation, @vikaschoudhary16 found that could be due to a encoding formation issue.

what happens is that if I am doing fresh login into google acount as part of getting authz code, then in the callback api, broswer provides code in the encoded format, which is expected by authservice and it works
if I am already logged in and I retry getting authorization code for a new session, this time browser provides authz code, in the query params of callback uri, in the decoded format which has charatcer like /
this fails in authservice as authservice expects only encoded format
like %2f for /
will it be okay if we, authservice,  look for reserved chaacters in the auth code and if found.. that means code is already in decoded form and skip decoding

Given this has appeared in two recent setup, I think it's worth looking a bit further.

@nacx  @vikaschoudhary16 You could try this image gcr.io/jianfeih-test-321318/authservice:0124a to replace with your authservice deployment. This should fix the problem.

I'll try this week. Thanks!
JFTR, I switched to Auth0 for my demo and the issue does not manifest there.

@nacx @vikaschoudhary16 You could try this image gcr.io/jianfeih-test-321318/authservice:0124a to replace with your authservice deployment. This should fix the problem.

It should work Jianfei. I trid a hack similar to the changes in the PR couple days back and that got it working.


Issue 129: increase docstring coverage

This addresses issue #129:

All methods in the api documentation have docstrings with working examples. Documentation was checked locally.
Interrogate has 97% coverage - only things missing are file level docstrings on some test files.
Interrogate failure threshold moved up to 85%

Potential future work:

some docstrings are still minimal, so they could be expanded - such as examples of data simulation functions
various plot methods don't have output examples in the API reference, links to static images could be added

Main items for review:

wording of documentation
consistency
docstring style

Wow, this is amazing -- much appreciated @jpreszler!

I've cleaned up the example output, added doctest to the CI workflow and all examples pass locally. I've also added examples for the new IV model and experiment added in #213 .
This is ready for a new review @drbenvincent when you have a chance.

Hi @jpreszler. Thanks for the updates. I'll try to carve out some time (I now have an 11 day old son now!) to review properly. But in the mean time I triggered the remote checks and it looks like we've got a failure. The test output looks like it could be just a missing import of statsmodels.

@drbenvincent , it looks like statsmodels wasn't being installed into the remote environment so I added it to the dependencies. That should fix the test failure.
Congratulations on the baby boy!

Looks like there's a little instability in the summary output that I'm looking into fixing.

I should have all the instability addressed, the doctests passed in the remote environment on my fork as well as locally.

@drbenvincent Thanks for the helpful comments. I've made the improvements so this is ready for another look when you have time.

I think there's definitely a bit of redundancy in the examples, and with doctest that adds a lot of time to running tests.
I've reduced the redundancy and moved all meaningful examples (like summary() calls) to a single example for each class and removed plot and a few other low value examples.

Those issues were not just local to you. I've fixed them and looked for other problems, but didn't spot much besides the same issue in WeightedSumFitter as in LinearRegression.
The tests have also passed on my fork after some small adjustments.

Quick question as I've never used doctest before...
As far as I can tell doctests are run with pytest --doctest-modules causalpy/.  At the moment I can only see these being triggered with the remote tests. Do you think it makes sense to add brief instructions to CONTRIBUTING.md either under "Pull request checklist" or "Building the documentation locally" to tell people that they should run the doctests locally (and how to do that) before a PR.

Good call. The same command can run all doctests locally, but I also added a make doctest command to the makefile. I've also added some details to the contributing doc about running all doctests or individual ones. This might be too much for the PR checklist.
This is my first venture into doctests, but the system is pretty straightforward. A good thing to note is that the +NUMBER option that is used by a number of the tests is a pytest extension of doctest. If you use doctest directly (not through pytest) these tests will fail.

This is great. When running the doctests I just noticed that it produces new files, ancova_data.csv and regression_discontinuity.csv. We should ideally either not produce those files, or have some clean-up.

That's from a few of the doctests for the simulated data, I've skipped the lines that write out the csvs, but leaving the example of how to do so.


export func IntoObject

export func IntoObject (changed from intoObject) so that we can inject istio sidecar into object directly, no extra unit test is needed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @john-deng. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign @andraxylia

master is frozen, could you please edit your PR and use release-0.8 as base?

@andraxylia @yusuoh please see https://github.com/istio/istio/pull/5497


Relax proconio requirement

In the AtCoder server, proconio v0.3.6 is used. However proconio has
been improved since then without changing server-side bahavior. These
changes are released on the v0.3 series.
proconio is developed and maintained for AtCoder, so we can keep its
behavior compatible with the judge server's behavior on v0.3 series. We
can safely relax its requirement from =0.3.6 to ^0.3.6.

AFAIK, Cargo attempts to preserve lock files as possible.
I'm worried about breaking changes in dependencies of dependencies (e.g. syn ^1) that we don't know yet...

Ah... I agree. That can cause a problem.
I removed Cargo.lock because Cargo hadn't automatically updated proconio-derive which proconio had depended on, and it was a correct behavior for Cargo, just as you said. I don't think it's better to specify more precise version in proconio since it works well with older version of proconio-derive as a library, but I'd be happy if I can offer improvements in proconio-derive here. Perhaps I should specify the version of proconio-derive in Cargo.toml or update Cargo.lock partially.

(sorry for late)
I misunderstood. This PR is for ja, not ja-all-enabled.

Then I think tt's reasonable to remove Cargo.lock.

Wait, proconio(-derive) still have a lot of dependencies and are possible cause problems.


Circular Dependency between Streaming Utils and Drm Engine

StreamingUtils depends on DrmEngine.
DrmEngine depends on StreamingUtils

We don't want this as it causes problems with the closure compiler.

It looks like this was addressed in a previous change. The circular dependency between StreamUtils and DrmEngine no longer exists. Currently the only connection between StreamUtils and DrmEngine is in StreamUtils.filterNewPeriod.


[packetlib] Add SAI P4 BMv2 packet_in header support in packetlib.  [SAI P4] Add version string to PkgInfo.

PR Description :
[packetlib] Add SAI P4 BMv2 packet_in header support in packetlib.
[SAI P4] Add version string to PkgInfo.
Build Results :
bibhuprasad@95f0faf36370:/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS p4rt_app/...
INFO: Analyzed 92 targets (0 packages loaded, 0 targets configured).
INFO: Found 92 targets...
INFO: Elapsed time: 0.368s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
bibhuprasad@95f0faf36370:/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS p4_pdpi/...
INFO: Analyzed 73 targets (0 packages loaded, 0 targets configured).
INFO: Found 42 targets and 31 test targets...
INFO: Elapsed time: 0.428s, Critical Path: 0.02s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
UT Results :
bibhuprasad@95f0faf36370:/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS p4_pdpi/...
INFO: Analyzed 73 targets (0 packages loaded, 0 targets configured).
INFO: Found 42 targets and 31 test targets...
INFO: Elapsed time: 15.947s, Critical Path: 15.55s
INFO: 2 processes: 1 internal, 1 linux-sandbox.
INFO: Build completed successfully, 2 total actions
//p4_pdpi:ir_tools_test                                         (cached) PASSED in 0.3s
//p4_pdpi/netaddr:ipv4_address_and_network_address_test         (cached) PASSED in 0.2s
//p4_pdpi/netaddr:ipv6_address_test                             (cached) PASSED in 0.2s
//p4_pdpi/netaddr:mac_address_test                              (cached) PASSED in 0.2s
//p4_pdpi/packetlib:packetlib_test                              (cached) PASSED in 0.1s
//p4_pdpi/packetlib:packetlib_test_runner                       (cached) PASSED in 0.1s
//p4_pdpi/packetlib:packetlib_unit_test                         (cached) PASSED in 1.3s
//p4_pdpi/string_encodings:bit_string_test                      (cached) PASSED in 0.2s
//p4_pdpi/string_encodings:byte_string_test                     (cached) PASSED in 0.5s
//p4_pdpi/string_encodings:decimal_string_test                  (cached) PASSED in 0.2s
//p4_pdpi/string_encodings:decimal_string_test_runner           (cached) PASSED in 0.0s
//p4_pdpi/string_encodings:hex_string_test                      (cached) PASSED in 0.1s
//p4_pdpi/string_encodings:hex_string_test_runner               (cached) PASSED in 0.0s
//p4_pdpi/string_encodings:readable_byte_string_test            (cached) PASSED in 0.2s
//p4_pdpi/testing:helper_function_test                          (cached) PASSED in 0.3s
//p4_pdpi/testing:info_test                                     (cached) PASSED in 0.1s
//p4_pdpi/testing:info_test_runner                              (cached) PASSED in 0.1s
//p4_pdpi/testing:main_pd_test                                  (cached) PASSED in 0.1s
//p4_pdpi/testing:mock_p4_runtime_server_test                   (cached) PASSED in 0.3s
//p4_pdpi/testing:packet_io_test                                (cached) PASSED in 0.0s
//p4_pdpi/testing:packet_io_test_runner                         (cached) PASSED in 0.0s
//p4_pdpi/testing:rpc_test                                      (cached) PASSED in 0.1s
//p4_pdpi/testing:rpc_test_runner                               (cached) PASSED in 0.0s
//p4_pdpi/testing:sequencing_test                               (cached) PASSED in 0.2s
//p4_pdpi/testing:sequencing_test_runner                        (cached) PASSED in 0.2s
//p4_pdpi/testing:table_entry_gunit_test                        (cached) PASSED in 0.3s
//p4_pdpi/testing:table_entry_test                              (cached) PASSED in 0.1s
//p4_pdpi/testing:table_entry_test_runner                       (cached) PASSED in 0.1s
//p4_pdpi/utils:annotation_parser_test                          (cached) PASSED in 0.2s
//p4_pdpi/utils:ir_test                                         (cached) PASSED in 0.3s
//p4_pdpi/packetlib:packetlib_fuzzer_test                                PASSED in 15.5s
Executed 1 out of 31 tests: 31 tests pass.
INFO: Build completed successfully, 2 total actions
bibhuprasad@95f0faf36370:/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS p4rt_app/...
INFO: Analyzed 92 targets (0 packages loaded, 0 targets configured).
INFO: Found 61 targets and 31 test targets...
INFO: Elapsed time: 0.418s, Critical Path: 0.01s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//p4rt_app/event_monitoring:app_state_db_port_table_event_test  (cached) PASSED in 0.5s
//p4rt_app/event_monitoring:config_db_node_cfg_table_event_test (cached) PASSED in 0.5s
//p4rt_app/event_monitoring:config_db_port_table_event_test     (cached) PASSED in 0.5s
//p4rt_app/event_monitoring:state_verification_events_test      (cached) PASSED in 0.5s
//p4rt_app/p4runtime:ir_translation_test                        (cached) PASSED in 0.4s
//p4rt_app/p4runtime:p4info_verification_schema_test            (cached) PASSED in 0.4s
//p4rt_app/p4runtime:p4info_verification_test                   (cached) PASSED in 0.4s
//p4rt_app/p4runtime:packetio_helpers_test                      (cached) PASSED in 0.6s
//p4rt_app/sonic:app_db_acl_def_table_manager_test              (cached) PASSED in 0.7s
//p4rt_app/sonic:app_db_manager_test                            (cached) PASSED in 0.3s
//p4rt_app/sonic:app_db_to_pdpi_ir_translator_test              (cached) PASSED in 0.4s
//p4rt_app/sonic:packetio_impl_test                             (cached) PASSED in 0.3s
//p4rt_app/sonic:packetio_port_test                             (cached) PASSED in 0.3s
//p4rt_app/sonic:response_handler_test                          (cached) PASSED in 0.3s
//p4rt_app/sonic:state_verification_test                        (cached) PASSED in 0.3s
//p4rt_app/sonic/adapters:fake_sonic_db_table_test              (cached) PASSED in 0.1s
//p4rt_app/tests:acl_table_test                                 (cached) PASSED in 1.0s
//p4rt_app/tests:action_set_test                                (cached) PASSED in 0.7s
//p4rt_app/tests:api_access_test                                (cached) PASSED in 0.6s
//p4rt_app/tests:arbitration_test                               (cached) PASSED in 0.7s
//p4rt_app/tests:fixed_l3_tables_test                           (cached) PASSED in 1.9s
//p4rt_app/tests:forwarding_pipeline_config_test                (cached) PASSED in 2.9s
//p4rt_app/tests:grpc_behavior_test                             (cached) PASSED in 5.0s
//p4rt_app/tests:p4_programs_test                               (cached) PASSED in 1.1s
//p4rt_app/tests:packetio_test                                  (cached) PASSED in 3.3s
//p4rt_app/tests:port_name_and_id_test                          (cached) PASSED in 0.8s
//p4rt_app/tests:response_path_test                             (cached) PASSED in 1.8s
//p4rt_app/tests:role_test                                      (cached) PASSED in 0.6s
//p4rt_app/tests/lib:app_db_entry_builder_test                  (cached) PASSED in 0.0s
//p4rt_app/utils:event_execution_time_monitor_test              (cached) PASSED in 0.2s
//p4rt_app/utils:table_utility_test                             (cached) PASSED in 0.3s
Executed 0 out of 31 tests: 31 tests pass.
INFO: Build completed successfully, 1 total action
bibhuprasad@95f0faf36370:/sonic/src/sonic-p4rt/sonic-pins$

Co-authored-by: Srikishen Pondicherry Shanmugam<EMAIL_ADDRESS>

Will Fix and raise it again


[Addition]: 148wWrbqyDarxwmdTJdQ5TTFzCN6hb1QerfmyTub1Jqxjvwjki2  Norway !

Hotspot b58 Addresses
112rYK7UhzchT3jbLUJVUFZDdTP7L2zLmnVuXVyTbV23y8n3cKWF
112UuPTmkAWwtMHpyHyZHpTK6NqDmfAniPfDYnDzRLHdTTPSpx8t
1123m5RVssXigiy1zpkE24QkqtnXLHQv8TH4DjYCqGHwi1SLxvg3
and more more in same wallet .
and they see each others , all shown in same day
and just popup in screen !
Discord Handle
No response
Reason(s)
and more more in same wallet .
and they see each others , all shown in same day
and just popup in screen !

This report is fraudulent.  Why would you do so, alkhatib22 ?
1123m5RVssXigiy1zpkE24QkqtnXLHQv8TH4DjYCqGHwi1SLxvg3 is mine. I have a single hotspot in my wallet 13QZFaQwYUBEg2SHkco97MRt1pkrrwK4QiVBfQd2jCrmmoR2kbm.

Looks like alkhatib changed his username on github to Rover1986. Why would you do that, @Rover1986 ?
If the report quality in this report (with obvious lies and incomplete data) and no verification by reviewers is the way forward then the denylist issue tracker will for sure get spammed from all the hotspots getting incorrectly placed on it. It seems like false reporting hotspots is the new way of gaming the system...

@abhay
If I were to guess, The process for this issue has gone like this:

@Rover1986 submitted a false claim
You didn't do any review and simply added the 3 mentioned hotspots to your CSV
You merged all the addition-proposals into PR https://github.com/helium/denylist/pull/409
The "Reviewers" didn't do any review, just added their signature to the PR based trusting that you had done a review

What a terribly flawed process. Hope you can bring some clarity to me. You can find me on Discord to discuss as well. Kuleramme#1570


Bug in the template of kubelet-container.j2?

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT
Descripiton:
In my main.yml in the role of kargo-default. I changed the docker_daemon_graph: /var/lib/docker to docker_daemon_graph: /dcos/docker. After deploying the cluster successfully, and all the pods were in the right stats. I found that the directory of /var/log/contaniers was empty.
As expected, there must be some files about the kubernetes components containers in the directory, and i ensured the contents of /dcos/docker is correct .
Just after testing ,I doubt the configure about the kubelet, which is parsed by kubelet-container.j2. At last ,I found the paramter about the volumn in  kubelet-container.j2  about  graph of the docker daemon was hardcoded.

Why the first volume parameter is configurable , the container's volumn is not designed to be configurable?
I did some change in the kubelet-container.j2, like the below picture:

At last i found files in the directory of /var/log/containers as expected. Here is the print screen of the result:

In the end, Sorry for my pool writing English. :)-
Environment:

Cloud provider or hardware configuration:

VM

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

Centos 7

Version of Ansible (ansible --version):

ansible <IP_ADDRESS>
Kargo version (commit) (git rev-parse --short HEAD):
master-a44a2c2
Network plugin used:
flannel
Copy of your inventory file:
k8s-1 ansible_ssh_host=<IP_ADDRESS>    ip=<IP_ADDRESS>
k8s-2 ansible_ssh_host=<IP_ADDRESS>    ip=10.132l46.128
[kube-master]
k8s-1
[etcd]
k8s-1
[kube-node]
k8s-2
[k8s-cluster:children]
kube-node
kube-master
Command used to invoke ansible:
ansible-playbook -i hosts/host-test cluster.yml -l
Output of ansible run:

Anything else do we need to know:

Hi @Tonyzhangl,
I had a similar issue. By modifying the template in the same way you proposed, it did the trick.
I think a fix should be proposed, can you provide a merge request for this issue ?


Filter out filetypes from buffer list

Sometimes I may get a rogue terminal or a filetype appear in my buffer list which I'd rather not see. In bufferline you can filter these out through a custom function. Is this something that can be done already in our beloved cokeline?

I've added an is_visible property to the buffers. Let me know what you think.

I've just pushed 20d3e205f64b23b98a91cac1d72e953a1c3d46b7 which should solve this in a more general way.
The <Plug>(cokeline-focus-prev), <Plug>(cokeline-focus-next), <Plug>(cokeline-switch-prev) and <Plug>(cokeline-switch-next) mappings should all work even for filtered buffers.
Let me know if you have any more problems.


Not an issue, but very nice to have if someone is trying to build a modded map

Hey, I wanted to thank you for creating a mapping mod I could actually use, and provide the files I've used to create a full map for the "Project Zomboid Maps" collection on steam. It consists of around 120 map mods and it took me around 8 hours to get this done, so it may be helpful to some in the future.
Thank you again, and if there is a better place I could put this, let me know
(Also, feel free to have this as an example or whatever in the git itself. Everything runs cleanly after the 1st run, no missing files or anything)
https://pastebin.com/ATpygf2X <- conf.yaml
https://pastebin.com/Tm2FmK5q <- map_data.yaml
edit: i only tested this with the 2d map, not isometric, as my computer would be at like 0 storage if i did. feel free to test if isometric works

Thank you for your hard work. I will merge the changes into the git repository after validating them.

Sounds good. I made a list of additions here

Good to know that.
Also you can make a push request to the https://github.com/cff29546/pzmap2dzi/blob/main/docs/tested_maps.md, and add some creadit to yourself in the change log.


Full Day calendar Events east of UTC start time incorrect with latest node-ical (12.3)

the start time  should be 00:00:00 (local time) , but for east of UTC they are incorrect (by the TZ offset),

same here: fixed by the PR or still under work?

should have been closed by pr merge


Implement the Gui for Native Desktop Apps in Flutter

Summary
Implement the GUI for Native Desktop Apps in Flutter
Description
This task involves designing and implementing the graphical user interface (GUI) for native desktop applications in the Flutter project. The GUI should provide an intuitive and user-friendly interface for users to interact with the application's functionalities.
Acceptance Criteria
Which criteria has to be reached to be accepted

[ ] GUI design is consistent with the project's design guidelines
[ ] All required GUI components are implemented and functional
[ ] GUI is responsive and compatible with various screen sizes and resolutions

Tasks
Which tasks are included to add this feature

[ ] Implement GUI components using the chosen framework
[ ] Integrate GUI with backend functionality

Dependencies
Which dependencies are introduced to the project

[ ] Integration with existing backend APIs
[ ] Compatibility with target platforms (Windows, macOS, Linux)
[ ] flutter
[ ] flutter_rust_bridge

Estimates
Estimated effort for completion: 20 hours
Additional Information
Any additional information relevant to the development.

implemented down to the last detail.
Since we will probably decide against Flutter, this ticket will not be merged for the time being and will remain on its own branch


设置qq邮箱接收不了 报错

Qinglong version
最新版本
Steps to reproduce

What is expected?
期待成功
What is actually happening?
显示接口报错
System Info
No response
Any additional comments?
No response

参数怎么填的


Add pipline custom configuration doc for AWS

Add more instructions to use KFP in AWS.

/cc @sarahmaddox

/assign @joeliedtke
Thanks @Jeffwan! I'm assigning this one to @joeliedtke as he's the tech writer for Pipelines.

/assign @joeliedtke
Thanks @Jeffwan! I'm assigning this one to @joeliedtke as he's the tech writer for Pipelines.

Thanks @sarahmaddox Sounds good

Preview: https://deploy-preview-1852--competent-brattain-de2d6d.netlify.com/docs/aws/pipeline/

@joeliedtke Please have another review on this revision. Address most of the feedbacks besides this one. We can consider these two variables AWS_ACCESS_KEY_ID  and AWS_SECRET_ACCESS_KEY as fixed values. They are key name of value and widely used in other examples.

@joeliedtke Address your latest comments. Please have another look

/lgtm
/approve
Thanks for adding this @Jeffwan, this looks looks like it will be very helpful for people who want to use Kubeflow Pipelines on AWS.


Change GasGiantsEnhanced Dependency

Change RSS to a recommendation instead of a dependency.

Mod name: GasGiantsEnhanced
Author(s): ballisticfox
License: CC-BY
Homepage: https://forum.kerbalspaceprogram.com/index.php?/topic/206773-gas-giants-enhanced-a-visual-mod-for-real-solar-system-and-ksrss/
Download: https://spacedock.info/mod/2969/Gas Giants Enhanced

This appears to be so KSRSS could be used instead. KSRSS is not in CKAN and is hosted on GitLab (see KSP-CKAN/NetKAN#2554).


draggable element child of list, iframe bug? aswell

http://jsbin.com/lexejociyi/edit?html,js,output
in my use case im making a page builder. each item has an iframe inside it to render "right" so the structure is something like
ul
    li
        iframe
        settings_input
        draggable_overlay

the issue im facing at the moment is if i drag the li Sortable.create(ul, {.... and i drag the item into the drop zones via clone it removes the content of the iframe (strange, cause its ment to clone)
http://jsbin.com/yefidofoko/1/edit?html,js,output (drag the list items into the drop zones at the bottom). the iframes content then gets removed on drop.
my "work around" fix for this would be to add the sortable element to the .draggy item instead of the li. could wrap the draggy in a parent i suppose but it gets messy
what i would ultimately like to do would be to change the "ghost" (i think thats what its called here) to some other element for dragging and drop it leaving the main structure totaly alone.
http://jsbin.com/lexejociyi/1/edit?html,css,js,output#convert
so when dragging from the list to the droppy zones, just the #list .list-group-item .draggy items get dragged and dropped
i tried binding the sortable to just the draggy items but sortable needs a list for turning the children into draggables not individual items.
any help with this?

my work around at the moment is to add a parent to the li and add sortable to all those divs instead with a single "child" inside it.


Ctrl + click to open link in new tab make current tab show loading forever

Describe the bug
When open a link in new tab using ctrl + click, loading animation is displayed forever.
To Reproduce
Steps to reproduce the behavior:
Click a next link with ctrl press
Expected behavior
Do not show loading animation

Thanks for reporting this. Of course the loading bar shouldn't appear as ctrl + click opens new tab and this is going to be fixed soon. Hopefully the next release will fix it

Its now fixed with latest version 1.1.0

@ndungtse Could you update more on this issue.  Press Alt key + click link (option key + click on MacOS) cause the same issue.


Unable to access CustomLearningAdmin.aspx after upgrading to version 5

PROVISIONING NOTE: If you are having issues with the SharePoint look book while trying to provision M365 learning pathways please do not post that issue to this repo as we cannot help you here. Please post all questions and issues for the SharePoint look book to SharePoint/sp-provisioning-service GitHub Issues List.

WEB PART NOT LOADING: If you are getting the error: "Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance". Please review the Diagnosing Pre-Check guidance before submitting your bug.

Describe the bug
After upgrading the SharePoint app in the Admin Centre to 5.0 as well as getting the new app in the Microsoft 365 Learning Pathways site contents following these instructions (https://github.com/pnp/custom-learning-office-365/blob/main/installation/UpdateV4-V5.md) I can access the main learning pathways site (...SitePages/Get-started-with-Microsoft-365.aspx) but the admin stie will not load (...SitePages/CustomLearningAdmin.aspx). There are no errors, there were no popups to upgrade so now I cannot modify the content anymore.  I've tried in cognito as well.  The page is blank with just hte heading.
To Reproduce

Steps to reproduce the behavior

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Learning Pathways version number

Please share the version number of learning pathways in your tenant app catalog.

Additional context

Add any other context about the problem here.

@luvsql we saw this issue in a few of our beta testers. The way to resolve the issue is to delete the sppkg file from the app catalog and add it again. I will add that to the documentation. Beta Install Notes

We have a very customized Learning Centre solution.  Is there any risk of losing any site details, pages, customizations, playlists if we delete the app completely?

You should only delete the sppkg file from the app catalog. Do not delete the site or any of the lists. If you do this then the app will come back.

Sorry to keep asking but to confirm, if I just delete the app from the app catalog, then upload 5.0 again, we will not lose any data, or access to the site or app itself?

@luvsql Deleting the app from the app catalog is separate from the data stored in the list so no you will not loose any data in the site.

@luvsql if you are nervous about potentially losing data you should follow the backup instructions. That said replacing the package will not touch the data.

Deleting and readding fixed the issue, thank you!


Error on phone number

Hello, trying to make shipments using the cload service but it always tells me that the number is wrong... but I already checked and it is correct.
usage +55 = Country code
and the rest of the phone

Hello!
Could you please provide the full text of the error message? You can check the status of the message by making a GET /message/{id} request.
From the logs, it appears that you attempted to use SIM cards №2 and №3, which do not exist in your phone. Additionally, when using SIM card №1, you encountered a system error RESULT_RIL_MODEM_ERR, which is beyond the scope of the app.
I recommend trying to send a message with the standard messaging app on your device, and then by API without specifying the SIM number in the request. This might help if the issue lies in SIM selection.


Emmet not working on latest version

VSCode Version: Code 1.15.0 (8b95971d8cccd3afd86b35d4a0e098c189294ff2, 2017-08-09T20:06:21.685Z)
OS Version: Darwin x64 15.5.0
Extensions:

Emmet not work when use tab key on document (php, html, twig,...) when i update to version 1.15.0
Please fix it, thanks 💯

@nguyen-tho-mulodo Please upgrade to VS Code 1.15.1 and set emmet.triggerExpansionOnTab to true
There have been quite a few changes to Emmet. Please read go through the below links
Emmet docs
Emmet 2.0 blog

@ramya-rao-a thanks very much! :)


Update dataset to the current ontology

Currently the ontology is a small step ahead of the dataset due to eccenca cmem issues.
Plan is to adjust the dataset to the current version of the ontology.
While a newer than current version is already in the works(adding catalogueoflife and classyfire), it only makes sense to publish that one after the taxonomy work has been finished.

Ontology has also been slightly improved and already prepared for the data to come
KG is ready at cmem, just needs to be added to virtusoso.
We are with nubbekg now. No "-" no "KG".


package the component to be used from reactjs

Objectives
improve the component so that it can be used from reactjs
Success Criterias
here we should

[ ] be able to access the burner from a reactjs application
[ ] be able to interact with the burner from a reactjs application

Additional Information
We can find some resources to do that, including:

react-svelte by Rich Harris
pngwn/svelte-adapter

As explained in #26 we will move the burner to Next.I am very bullish on Svelte for many reasons that I won't explain here but sadly, we think this move will force a full rewrite of the burner which is somehow needed.


General Purpose Support for any media playing

Similar to the "Now Playing" API that Apple natively serves on Mission Control, is something like that possible?
By the way, great job on your apps!

Would love to see it for all apps which implement the notification player.


Fix package.json to remove NPM warning

npm WARN<EMAIL_ADDRESS>dependencies field should be hash of <name>:<version-range> pairs

Fixed in #33.  Just republished v1.3.3, so you should be good to go.  thx.


Fix custom tabs

fix: Memory leak in custom tabs.  …
hardik124 committed 13 hours ago
Uses default util method to implement custom tabs . Deletes speaker intent util.
Fixes #1885

@Shailesh351, Please check now.

@iamareebjamal @Shailesh351 I implemented the suggestions. Please check.


[Dev][TL] Enhance TL Paser to support flexible tile lang kernel implementation

This pull request includes several changes to the bitblas/ops/general_matmul/tilelang/dequantize/block_primitive_tensorcore.py file, focusing on refactoring and enhancing the dequantization process. It also updates the bitblas/ops/base_scheduler.py file to add an assertion for function simplification and modifies test cases in testing/python/operators/test_general_matmul_tilelang_scheduler.py to include new dequantization scenarios.
Enhancements to Dequantization Process:

Refactored apply_config method to streamline the configuration process and removed redundant methods for different scaling and zero modes. (bitblas/ops/general_matmul/tilelang/dequantize/block_primitive_tensorcore.py, [1] [2]
Introduced _normal_dequant method for handling different dequantization scenarios based on scaling and zero modes. (bitblas/ops/general_matmul/tilelang/dequantize/block_primitive_tensorcore.py, bitblas/ops/general_matmul/tilelang/dequantize/block_primitive_tensorcore.pyR367-R488)
Added buffer shapes for LUT, Scale, Zeros, Qzeros, and Bias in the dequantization process. (bitblas/ops/general_matmul/tilelang/dequantize/block_primitive_tensorcore.py, bitblas/ops/general_matmul/tilelang/dequantize/block_primitive_tensorcore.pyR222-R226)

Code Quality Improvements:

Ensured the Simplify method returns a single function and added an assertion to enforce this. (bitblas/ops/base_scheduler.py, bitblas/ops/base_scheduler.pyL30-R32)
Corrected the zeros_mode default value to a tuple format. (bitblas/ops/general_matmul/tilelang/dequantize/block_primitive_tensorcore.py, bitblas/ops/general_matmul/tilelang/dequantize/block_primitive_tensorcore.pyL52-R52)
Formatted multiline expressions for better readability. (bitblas/ops/general_matmul/tilelang/dequantize/block_primitive_tensorcore.py, [1] [2] [3]

Test Cases:

Added new test cases to validate the dequantization scheduler with various configurations, including scaling and different zero modes. (testing/python/operators/test_general_matmul_tilelang_scheduler.py, testing/python/operators/test_general_matmul_tilelang_scheduler.pyR37-R92)

Submodule Update:

Updated the tvm submodule to a new commit. (3rdparty/tvm, 3rdparty/tvmL1-R1)

Also fix for pull request #221


tf.GradientTape.gradient raises error with tf.math.segment_max

System information

OS Platform and Distribution: Linux Ubuntu 16.04
TensorFlow installed from (source or binary): installed by pip
TensorFlow version (use command below): 1.13-rc1
Python version: 3.6

Code to reproduce the issue
import tensorflow as tf
import numpy as np

tf.enable_eager_execution()

inputs = np.random.randn(5)
inputs_tensor = tf.Variable(inputs, dtype=tf.float32)
seg_ids = tf.convert_to_tensor([0, 0, 0, 1, 1])
with tf.GradientTape() as tape:
    y = tf.math.segment_max(inputs_tensor, seg_ids)
    loss = (y - tf.convert_to_tensor([1., 1.], tf.float32)) ** 2
    loss = tf.reduce_mean(loss, 0)

grads = tape.gradient(loss, inputs_tensor)

Other info / logs
TypeError                                 Traceback (most recent call last)
<ipython-input-2-b33dd17ed2d8> in <module>
      6     loss = tf.reduce_mean(loss, 0)
      7 print(y)
----> 8 grads = tape.gradient(loss, inputs_tensor)

/anaconda3/envs/my-rdkit-env/lib/python3.6/site-packages/tensorflow/python/eager/backprop.py in gradient(self, target, sources, output_gradients, unconnected_gradients)
    944         flat_sources,
    945         output_gradients=output_gradients,
--> 946         unconnected_gradients=unconnected_gradients)
    947
    948     if not self._persistent:

/anaconda3/envs/my-rdkit-env/lib/python3.6/site-packages/tensorflow/python/eager/imperative_grad.py in imperative_grad(tape, target, sources, output_gradients, unconnected_gradients)
     70       sources,
     71       output_gradients,
---> 72       compat.as_str(unconnected_gradients.value))

/anaconda3/envs/my-rdkit-env/lib/python3.6/site-packages/tensorflow/python/eager/backprop.py in _gradient_function(op_name, attr_tuple, num_inputs, inputs, outputs, out_grads)
    129     return [None] * num_inputs
    130
--> 131   return grad_fn(mock_op, *out_grads)
    132
    133

/anaconda3/envs/my-rdkit-env/lib/python3.6/site-packages/tensorflow/python/ops/math_grad.py in _SegmentMaxGrad(op, grad)
    277 def _SegmentMaxGrad(op, grad):
    278   """Gradient for SegmentMax."""
--> 279   return _SegmentMinOrMaxGrad(op, grad)
    280
    281

/anaconda3/envs/my-rdkit-env/lib/python3.6/site-packages/tensorflow/python/ops/math_grad.py in _SegmentMinOrMaxGrad(op, grad)
    257   print('op:', op)
    258   print('op.outputs:', op.outputs)
--> 259   gathered_outputs = array_ops.gather(op.outputs[0], op.inputs[1])
    260   is_selected = math_ops.equal(op.inputs[0], gathered_outputs)
    261   num_selected = math_ops.segment_sum(math_ops.cast(is_selected, grad.dtype),

TypeError: 'NoneType' object is not subscriptable

I find that op.outputs for 'segment_max' is None, and is there any solution for that?

Can you see if this is fixed in master?

The issue persists with TF 1.13.0-rc2 and tf-nightly build.

I still see the same issue with unsorted_segment_max (and tf.reduce_max on ragged tensors).

I think if you look at the change I listed you can see the steps to fix
this issue.
On Wed, Feb 27, 2019 at 11:26 AM danecor<EMAIL_ADDRESS>wrote:

I still see the same issue with unsorted_segment_max (and tf.reduce_max on
ragged tensors).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/25666#issuecomment-467995374,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAATxa6GVkMaIswUBZoPVYwqkqMtWJMvks5vRtv1gaJpZM4a0MzS
.

--

Alex

I think if you look at the change I listed you can see the steps to fix this issue.

Sure


Nextcloud upgrade path from 19.09 to 20.03 broken

Describe the bug
NixOS 19.09 had Nextcloud 16, while NixOS 20.03 uses Nextcloud 18, which skips one version.
This is a problem, as Nextcloud only supports updating from 16 -> 17 -> 18 and refuses to skip a version.
To Reproduce
Steps to reproduce the behavior:

Install NixOS 19.09 with Nextcloud and set it up
Upgrade system to 20.03
Nextcloud is now unavailable and updating fails with this information:

# nextcloud-occ status
Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
  - installed: true
  - version: <IP_ADDRESS>
  - versionstring: 18.0.0
  - edition:

# nextcloud-occ upgrade
Nextcloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Set log level to debug
Exception: Updates between multiple major versions and downgrades are unsupported.
Update failed
Maintenance mode is kept active
Reset log level

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: pkgs.nextcloud
# a list of nixos modules affected by the problem
module: services.nextcloud

Marking as a blocker for now. In my experience, broken Nextcloud updates can cause very bad side-effects. (if I'm wrong, feel free to remove the label again).

To get around this issue I made an override with Nextcloud 17.0.3 and then used nextcloud-occ upgrade. Then I removed that override and made the final upgrade to Nextcloud 18.
The override in my configuration:
  nixpkgs.config.packageOverrides = super: let self = super.pkgs; in {
    nextcloud = super.nextcloud.overrideAttrs (oldAttrs: rec {version = "17.0.3"; src = pkgs.fetchurl { url = "https://download.nextcloud.com/server/releases/nextcloud-${version}.tar.bz2"; sha256 = "0i3lwk86xcz2qmqjjw69r6k706ygsfw8b9bxl0q2kps7iy4527ch"; }; });
  };

As I also executed a lot of other commands that lead to various errors I'm not sure that those two upgrade steps I mentioned are enough, but I really don't feel like restoring from backup to the old version and trying the upgrade again.

It may be possible to add a nextcloud-intermediate package and somehow warn a user when deploying to a system with an older state-version (or just document it in the release-notes).


Research how to test cellular modem connections

Is there a way we can mock this? Otherwise, can we (cheaply) test this for real?

Closing stale issues


Conditional element method calls

Similar to the existing magic attribute setters:
Form::text('meme')->lol('catz')
// <input type="text" name="meme" lol="catz">

This PR proposes conditional magic attribute setters:
Form::text('name')->disabledIf(true)
// <input type="text" name="meme" disabled="disabled">

Form::text('name')->disabledIf(false)
// <input type="text" name="meme">

Form::text('name')->maxlengthIf(true, '5')
// <input type="text" name="meme" maxlength="5">

Form::text('name')->maxlengthIf(false, '5')
// <input type="text" name="meme">

This works using the magic __call() method, detecting if last two characters in method call are If.  The first param being $condition (can be any expression), and the following params are just passed onto the desired method using call_user_func_array().

Coverage increased (+0.09%) to 94.848% when pulling 4b972951281be186a43109417915ad78ea042a66 on JesseLeite:conditional-element-method-calls into da9e21cf150d6356add0646d0242fcd1bdaabf81 on adamwathan:master.

This is very nice!

What about this :
{!! BootForm::open()->action(route('companies'))->multipart()->putIf($company->getKey()) !!}

So we don't have to do this:
@if($company->getKey())
    {!! BootForm::open()->action(route('companies'))->multipart()->put() !!}
@else
    {!! BootForm::open()->action(route('companies'))->multipart() !!}
@endif

@axyr Because my code is on Element, and because FormOpen extends Element, this is already possible:

Great!

@adamwathan can you merge some of the very very nice pull requests???

I know this was implemented in #99, but my case for magic method implementation here: https://github.com/adamwathan/form/pull/99#issuecomment-276850199
...That said, if you want to close this PR, I won't be sad :)


CAnt make it work with Event Visualizer

I'm not sure if it should work with scriptable object, but I tried selecting an scritableobject asset in project view and generate a event graph and nothing happened. Tried with scritableobject itself, also without luck.  With gameobjects it's working just fine.
On the article in http://mefistofiles.com/the-unityevent-visualizer, it says it works with Scritableobject and also as it was used for SmartData project, I also assume so.
Am I doing something wrong? If not, could this be a feature to be considered?

Sorry about that, I just realized that I was expecting it to show link references of scriptableObjects on the graph.
If I call a method of a scriptableObject on a event, it will show in the graph


Supported Scanner API for Swift

Add API on Scanner that can is idiomatic on Swift. This promotes some of the existing experimental API and deprecates the rest. The new API is intended to operate on graphemes, not single UTF-16 code units. This API is not experimental and will be supported going forward.

@swift-ci please test

@swift-ci Please test source compatibility

… worth a try.

@shahmishal is it possible to set up 'please test source compatibility' for s-c-f?

I bet the issue with the test is that one of the emoji isn't recognized as an emoji by ICU 61.

Are scanUInt(representation:) and scanUInt32(representation:) deliberately  missing? Seems a bit lopsided not to have those.

@millenomi because of https://bugs.swift.org/browse/SR-9699 the CI tests arent even building ICU so might be worth getting it fixed now ;)

@spevans it is indeed https://bugs.swift.org/browse/SR-9699 — I pinged @shahmishal about it.

@shahmishal is it possible to set up 'please test source compatibility' for s-c-f?

Yes, can you file a Jira bug?

@swift-ci test


Add Directive snippets to Webstorm Template (ng-d)

Webstorm Template miss the snippet for directive creation, in Sublime Text that snippet is bound to ngdirective

I'm looking for the same missing snippet today, so +1

Feel free to make a PR

Also Covered in #537

@johnpapa - this can be closed as it is covered with PR #544


Audio crackling using bluetooth devices when switching out of the browser app on Android devices.

Hey 👋
Describe the bug
When playing audio on Android Chrome and listening via a connected bluetooth device, switching apps or locking the phone will cause crackling in the audio. The crackling is constant, rather than pops or clicks. After around 30s, the audio will stop, presumably from some sort of crash, but there is no audible change to prove this.
This happens with even the simplest synth implementation.
Oddly, with no bluetooth device connected, this does not seem to happen.
To Reproduce
A reproducable sandbox is here. Connect to a bluetooth device. Press play on the sound, the switch apps from Chrome to anything other app, or lock the phone.
Phones tested are Pixel 2XL and Samsung Note 10. It doesnt seem specific to any bluetooth device.
Expected behavior
Switching apps does not degrade the performance while using bluetooth devices.
What I've tried
Doesn't seem to be a regular performance issue as this never happes while staying in the chrome app. Similarly, without a connected bluetooth device, I seem to be able to run this without issue.
I have tried using a Tone Context with a latencyHint of  'playback', to no avail.
Additional context
While I only named 2 devices, this seems like it could be fairly widespread, as I have had a couple of reports of the same bug.

Hi @andrewsrichardson, I vaguely remember that there were a couple of issues with certain Chrome / Bluetooth speakers combinations in the past. Could you try to play some audio with the Web Audio API to see if the problem persists? I guess a single Oscillator should be enough to trigger the bug.
Does your example work as expected in Firefox?

hey Chris
I tried the Web Audio API with Chrome (updated the sandbox) and the issue does indeed persist.
Oddly, I checked Firefox, and the issue does not persist using either Tone.js or the Web Audio API.
So I decided to also test Opera and Brave browser, both of which also produce the crackling issue for both Tone.js and the Web Audio API.

Thanks for checking this. I think it makes sense that Chrome, Opera and Brave have the same bug since they are all based on Chromium these days. Firefox has its own browser engine.
Maybe it's better to report this on Chromium's bug tracker. https://new.crbug.com/

Thanks for the direction Chris - I have opened a bug in the Chromium bug tracker here.
Happy to close this ticket!


can you upload a correct and usable image. The images I downloaded cannot be used correctly, the code output by AI cannot be written into Bolt.new.

I don’t understand, please use the bug report issue template and provide as much info as possible. Closing this issue.


[.NET Tutorial]: RazorPagesPizza project

URL
https://docs.microsoft.com/en-us/learn/modules/create-razor-pages-aspnet-core/5-exercise-create-new-razor-page-and-form
Hi, I'm failing in section Add form markup to the Pizza Razor page
When running dotnet run after replacing the markup contents of Pages/Pizza.cshtml, I get the below errors:
Please see screenshot.

Error message content:
'PizzaModel' does not contain a definition for 'NewPizza' and no accessible extension method 'NewPizza' accepting a first argument of type 'PizzaModel' could be found (are you missing a using directive or an assembly reference?) [RazorPagesPizza]
I need help to solve this issue to be able to proceed with the tutorial. Thanks.
Operating system
Windows
More information about your system
Windows 10, x64
Description
I'm following the tutorial for RazorPagesPizza project
Until now, I have copy and pasted all the content.
dotnet --info
.NET SDK (reflecting any global.json):
Version:   6.0.302
Commit:    c857713418
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.19043
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\6.0.302\
global.json file:
Not found
Host:
Version:      6.0.7
Architecture: x64
Commit:       0ec02c8c96
.NET SDKs installed:
6.0.302 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 6.0.7 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Download .NET:
https://aka.ms/dotnet-download
Learn about .NET Runtimes and SDKs:
https://aka.ms/dotnet/runtimes-sdk-info

Did you complete step 6 of the tutorial as well? That will create the NewPizza object on your model.
https://docs.microsoft.com/en-us/learn/modules/create-razor-pages-aspnet-core/6-handle-interactions-with-pagemodel-methods
You can also watch a video tutorial of this lesson with Hanselman and myselt at
https://docs.microsoft.com/en-us/shows/learn-live/create-web-ui-aspnet-core-modern-web-development-net-6-episode-1

Pizza.cshtml should look as follows:
@page
@using RazorPagesPizza.Models
@model RazorPagesPizza.Pages.PizzaModel
@{
ViewData["Title"] = "Pizza List";
}
Pizza List 🍕

Name

Size

Gluten Free

Add

Name
Price
Size
Gluten Free
Delete

    @foreach (var pizza in Model.pizzas)
    {

@pizza.Name
@($"{pizza.Price:C}")
@pizza.Size
@Model.GlutenFreeText(pizza)

Delete

    }

@section Scripts {

}

Pizza.cshtml should look as follows:
`@page
@using RazorPagesPizza.Models
@model RazorPagesPizza.Pages.PizzaModel
@{
ViewData["Title"] = "Pizza List";
}
Pizza List 🍕

Name

Size

Gluten Free

Add

Name
Price
Size
Gluten Free
Delete

    @foreach (var pizza in Model.pizzas)
    {

@pizza.Name
@($"{pizza.Price:C}")
@pizza.Size
@Model.GlutenFreeText(pizza)

Delete

    }

@section Scripts {

}`

Pizza-cshtml.txt


Add "hideout" screen

Create Hideout level. It should be the inside of a spaceship with areas for the different future upgrades. There should be a map area to select the next map along with a stash to store extra equipment between maps.
Every hideout system should have its own tab on the player inventory screen so you don't have to go to the station to do the action if you don't want to

[ ] Finish skybox
[ ] Model Cockpit
[ ] Add Nav Table
[ ] Model Hallwall
[ ] Add Stash Model
[ ] Add Stash UI


Extract common interface for Gradle caches

This is a preparation for using a Gradle Cache in IdentityCacheStep instead of a Guava cache.

@lptr Please take a look post-merge.


Safari 17 supports JPEG XL

Stopped reading the changelog as soon as I noticed:
https://developer.apple.com/documentation/safari-release-notes/safari-17-release-notes

Added support for JPEG XL. (100641584)

To quote this tweet

The irony will be strong when the first major browser to support the format that was developed by Google (and Cloudinary) will turn out to be... Safari!

🥳
I have no way of testing yet, so please, if you can, check https://tests.caniuse.com/jpegxl!
Thomas Steiner was so nice to test, via https://mastodon.social/<EMAIL_ADDRESS>
Seems to work on both mobile and desktop.

Confirming that JPEG XL will be supported by Safari 17 on macOS Sonoma, macOS Ventura and macOS Monterey, as well as iOS, iPadOS, watchOS, and visionOS.

That is so great to hear! 🤩🚀
https://gfycat.com/confusedvengefulindianabat-nod-zach-galifianakis

Thanks, awesome!

Currently the beta version of Safari 17 does not support animation(s) and supposedly also doesn't support embedded color profiles, I am unsure when and if this will be resolved so maybe it's worth it to have a note about the support not being full somewhere.

@Schweinepriester Animation(s) can be seen not working at the bottom of the website located here: https://jpegxl.info/test-page/ . I do not currently have a testcase on hand for color profiles not working but if needed I could eventually provide/get a example for them.


Xiaomi Aqara Motion Sensor, Every 5 sec a signal if there's motion

The Aqara motion sensor will by default only report a second motion, if the first motion detection timeout has finished. Sometimes this is handy, but sometimes I get a false positive, if for example some harse lighting is comming trought the window. That's why I use a counter in domoticz to see how many motions are detected in a certain time window.
But last time I had a burglar in my house and he was shorter then the motion timeout inside my room. So the motion alarm was not triggered.
I found a mod for the Aqara motion sensor here:
https://translate.google.com/translate?hl=&sl=ko&tl=en&u=https%3A%2F%2Flivebywant.tistory.com%2F13%3Fcategory%3D703455
Now the aqara will send from default (no motion) state the following command:
zigbee2mqtt/0x00158d00031b4e8c {'battery': 100, 'occupancy': False, 'illuminance': 187, 'linkquality': 89, 'voltage': 3055}
zigbee2mqtt/0x00158d00031b4e8c {'battery': 100, 'occupancy': True, 'illuminance': 187, 'linkquality': 89, 'voltage': 3055}
And when there's motion after the previous motion:
zigbee2mqtt/0x00158d00031b4e8c {'battery': 100, 'occupancy': True, 'illuminance': 185, 'linkquality': 89, 'voltage': 3055}
zigbee2mqtt/0x00158d00031b4e8c {'battery': 100, 'occupancy': True, 'illuminance': 185, 'linkquality': 89, 'voltage': 3055}
You see there is 2x the occupancy set to True. But domoticz doesn't see that as a devicechanged. Is there a way to support this behaviour?
Thanks

It would be hard to add such support as most other users have the default behavior.


[mock_testing, dif_plic] Introduce PLIC mock tests

This change introduces a set of PLIC mock tests to test the public API. The aim is to validate the API implementation in terms of different use-cases.

I will request from others when #1477 is in a near merged state.

This PR will be refactored to use new EXPECT_* macros from #1647 .

After #2224 lands I think this is ready to be merged!

Rebased the change with master, I think it is ready to be merged!

I think this is good to be merged.


Python: double check if unit tests cover all creation paths

Describe the bug
A clear and concise description of what the bug is.
We had a regression in the settings of the AI search connector, this want caught with unit tests, hence we want to make sure that we do have that for all ways of setting up. Will partially be solved when we further expand test coverage to include all memory services.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Platform

OS: [e.g. Windows, Mac]
IDE: [e.g. Visual Studio, VS Code]
Language: [e.g. C#, Python]
Source: [e.g. NuGet package version 0.1.0, pip package version 0.1.0, main branch of repository]

Additional context
Add any other context about the problem here.

Stale. Closing. Re-open if needed.


Project 2(elderly wearable webpage)

Tested locally. None of this code appears to work with the react app. Closing PR


Include tag prefix in commit message

Another PR that will help make this tool more useful when managing a packages monorepo. Including the --tagPrefix (if any) in the commit message will allow version bumps of different packages to be differentiated between if using a tag prefix scheme like packagename/v
Example output:
Version change for UPM release (packagename/v1.0.0)
and
UPM release (packagename/v1.0.0)

LGTM. We can merge it after you resolve the conflict.

Included in version 1.1.0


rust-analyzer-unwrapped: 2024-07-01 -> 2024-07-15

Diff: https://github.com/rust-lang/rust-analyzer/compare/2024-07-01...2024-07-15
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 327739 run on x86_64-linux 1

4 packages built:

ra-multiplex
rust-analyzer
rust-analyzer-unwrapped
vscode-extensions.rust-lang.rust-analyzer


Image Page Manipulation

This adds support for manipulating the virtual canvas of Images using object accessors (that call underlying C functions MagickImageGetPage and MagickImageSetPage). Both 4-tuple and individual item accessors are added.
It also fixes a previous limitation in the unit tests. The only testable difference between the Merge and Mosaic methods of merging layers is how they handle images with negative page offsets. This feature adds support for testing that difference, so the unit tests have been updated accordingly.

Coverage increased (+0.1%) to 85.413% when pulling b4b801706aed6c3abb9f23e930f02b8c4e30716d on nixscripter:feature/image-page-manipulation into ddb549fb1e8a70d304faa41f12276d93a17b84a6 on dahlia:master.

Thanks for your effort!  Could you add a changelog about this?  See also docs/changes.rst file.

Coverage increased (+0.07%) to 85.352% when pulling aa50c2f68cd8d99a5f0a0eff823a146272501bb4 on nixscripter:feature/image-page-manipulation into ddb549fb1e8a70d304faa41f12276d93a17b84a6 on dahlia:master.

Thank you!


DPG Projects <> Google Process

[x] Meet with Google to understand the current process around DPG asks and volunteer matching.
What works, what doesn't work, what can be improved? Ways in which progress could be tracked? Where can UNICEF come in for additional support, if needed?
[x] Update concept document accordingly

Updated V2 template. Main points from Google:

The project must be truly open-source (e.g. supported by a wide community, include documentation, have clear processes defined on how to contribute to project, allow others to contribute to them
The project must be well-maintained and the code must be in good quality


pd_client: prevent a large number of reconnections in a short time

What problem does this PR solve?
Issue Number: related #9799
Problem Summary:
Too many uninterrupted reconnection.
What is changed and how it works?
What's Changed:
Cancel some unnecessary reconnection.
Related changes

Need to cherry-pick to the release branch

Check List
Tests

Unit test
Manual test

3 PD / 3 TiKV / 1000 Region
Manually make PD no leader
Add metrics (will be in another PR)

Before
After

Release note

pd_client: prevent a large number of reconnections in a short time

/cc @BusyJay @rleungx @nolouch

What's the test result?

Updated test results (this metrics will be in another PR). Is it possible that the unit test of CI failure is caused by pd_client.get_store blocking?

/rebuild

/run-all-tests

/rebuild

/run-all-tests

/run-all-tests

/rebuild

/run-all-tests

/run-all-tests

/merge


fix: Better object checks

Closes #667.

@bitinn In that case, do we need isBlob to continue using duck-type checks?
URLSearchParams is not built into node v8 so we can either convert this to duck-type checks also or include the polyfill.

We've got enough reviews - time to merge this.


Board Review: Azure Communication Services (SPOOL) Custom Token Expiration GA

Complete Internal SDK Review for custom token expiration
Service name: ACS Developer Security
Key contact for this review: @Aigerim Beishenbekova @Maxim Rytych
Link to previous API version:
2021-03-07 azure-rest-api-specs/CommunicationIdentity.json at main · Azure/azure-rest-api-specs (github.com)
2022-06-01 azure-rest-api-specs/CommunicationIdentity.json at main · Azure/azure-rest-api-specs (github.com)
Description of the material to be reviewed/changed:
Adding the ability for customers to issue Communication Identity access token with a custom validity period in the range of [1-24] hours.
Champion scenarios that briefly explain how developers will use your API:
The main goal of this feature is to allow developers using ACS via the SDK  to customize Communication Identity access token expiration time. So far, ACS has only allowed customers to generate Communication Identity access token for a predefined period of 24 hours. This feature will provide clients with the ability to generate a Communication Identity access token with a custom expiration period in the range of [1-24] hours. The data type of the new parameter is TimeSpan for .Net, Duration for Java, timedelta for Python, number for Typescript. For the generation of the Communication Identity access token in our SDK we have two APIs:
getToken API to issue or refresh a token for an existing user
createUserAndToken  API to create a new user and issue a token in a single request
The Contoso developer will specify the custom expiration as follow:
let tokenExpirationInMinutes = 60;
let { user, token } = await client.createUserAndToken(["chat"], tokenExpirationInMinutes);

// or

let { token } = await client.getToken(user, ["chat"], tokenExpirationInMinutes);

TimeSpan tokenExpiresAfter = new TimeSpan(0, 60, 0);
Response<CommunicationUserIdentifierAndToken> response = await client.CreateUserAndTokenAsync(scopes: new[] { CommunicationTokenScope.Chat }, tokenExpiresAfter);

//or

Response<AccessToken> tokenResponse = await client.GetTokenAsync(user, scopes: new[] { CommunicationTokenScope.Chat }, tokenExpiresAfter);

The validity parameter will be optional. Customers who do not want to use this functionality will be able to issue Communication Identity access tokens in the same way as before. No breaking changes will be introduced.
Customers can make requests to issue a Communication Identity access token without specifying an expiration period in the same way as before. In this situation, the Communication Identity access token with a 24-hour expiration time will be generated.
let { user, token } = await client.createUserAndToken(["chat"]);
// or
let { token } = await client.getToken(user, ["chat"]);

Response<CommunicationUserIdentifierAndToken> response = await client.CreateUserAndTokenAsync(scopes: new[] { CommunicationTokenScope.Chat });
// or
Response<AccessToken> tokenResponse = await client.GetTokenAsync(user, scopes: new[] { CommunicationTokenScope.Chat });

Languages for this review: .NET, Java, Python, and TypeScript
Artifacts per language.
.NET - [Azure.Communication.Identity (<IP_ADDRESS>) - Created for PR 29806 - apiview.dev]
(https://apiview.dev/Assemblies/Review/0dcdf2df81434647a99052cd79bc1e56)
TypeScript - @azure/communication-identity(1.1.1) - Created for PR 22623 - apiview.dev
Java -  [azure-communication-identity (version 1.4.0-beta.1) - Created for PR 29981] apiview.dev(https://apiview.dev/Assemblies/Review/14ee9b90ecae43e7851a885337827fd5)
Python - azure-communication-identity - apiview.dev

#scheduled

Scheduled for 9/13 2p-4p PDT

Recording (MS INTERNAL ONLY)


Ownership model eliminator support for CopyValueInst and DestroyValueInst

The title says it all.
rdar://28851920

@swift-ci Please smoke test and merge


Changing the default system chart refresh time to 21600 seconds

Issue: https://github.com/rancher/rancher/issues/40805
Problem
Solution
Increase the time between refreshes
Testing

Engineering Testing
Manual Testing
Upgrade the rancher version and checked if the timer changed
Automated Testing
unit tests
QA Testing Considerations

Regressions Considerations

Hi @maxsokolovsky, thanks for the review! I made the changes you requested


Bundle size.

Hello. It is cool set of components, but I have some misunderstanding. When I include your components in clear application (I am using  react-bolierplate )  my 300 kb bundle turns into 1,7 mb bundle. Is not it too big? I am new in react, but I think, that set of components should not be so large. At first, it was 3 mb, but I replaced such imports:
import { Card, CardMedia, CardTitle, CardText, CardActions } from 'react-toolbox';

On this
import { Card, CardMedia, CardTitle, CardText, CardActions } from 'react-toolbox/lib/card';

Bundle became smaller (1.7 mb from 3 mb), but it is still too big

Hi! I didn't measure the final bundle size but you should always import as in your second example. In the first ase you'd be importing the whole library with every single component and every style, that's why the final build get's that big. I'm not sure why it's that big... the only dependencies we keep are classnames, core-js and react-css-themr. Maybe you are bundling two Reacts of something?

@Stalso If you're concerned about bundle size, react-toolbox works well with Preact. There's a full example here - bundle size for the entire app is only 60kb (14kb gzipped).  Generally, @javivelasco's work is portable to alternative implementations because it's well-written idiomatic React 🙇

I'm not sure about 1.7 mb, but the library does usually end up larger than it has to be.
Even when you import from react-toolbox/lib/Component, you still end up importing a bit more than you need (i.e. all of identifiers.js).
PropTypes also seem to not want to come off.  I had thought that it was just an issue with my build, but about a thousand of them are present on the demo site, as well.

@wtgtybhertgeghgtwtg @Stalso - you can profile your webpack build and drop the JSON output into webpack-visualizer. That will tell you exactly where the weight is.  CSS Modules have a cost, the various libs/utils all have cost - the list goes on.  Tree Shaking helps, though I'm not sure it's yet possible to get a perfect tree shake of react-toolbox since it likely wouldn't be supported via Rollup.

Tree Shaking would help, but currently the only way I see to do that with react-toolbox as is, at least as far as webpack@2 is concerned, to import from react-toolbox/components/Component with babel-loader.  Since transpiling node_modules isn't a particularly elegant solution, a jsnext:main might not be a bad idea.

The issue with jsnext:main is that preact-toolbox is more than just js - it contains sass, jsx, etc. It also relies on CSS Modules.

jsnext:main might be a somewhat misleading name, but it shouldn't cause any issues with non-Javascript assets.  It just points to a build that uses ES6 import, instead of the build main points to, which uses require().

It just assumes a lot about the bundle (like that a bundler is being used at all). I agree though, we are doing recursive module bundling at Synacor to apply client branding/config to all modules in a single build.

It assumes that, if the user has set up their bundler to use jsnext:main, that they want to use jsnext:main.  Nothing changes unless the user opts in to use it.

I will say though - doing this really increases the likelihood of breaking changes when updating dependencies. For example, react-toolbox changed their build process a bit to get rid of toolbox-loader, and I had to update a few of my own projects' Webpack configs since they had to be tightly coupled in order to know how to properly build the library.

If you don't add jsnext:main to your packageMains, it shouldn't affect your build process.  If you're running webpack@2 and want to see if it'll affect your build, redux and react-router have jsnext:main defined.

I know that, I've been using Webpack this way since late 2015 😋
It's just a very indirect means of achieving a smaller bundle size.

Indirect or not, it's an effective way to allow the user to achieve a smaller bundle size.

Thanks,  I will try all of your proposals,  and write about result.  By the way,  I am trying to use react-toolbox in this boilerplate https://github.com/mxstbr/react-boilerplate

Speaking of PropTypes, the new version of [babel-plugin-transform-react-remove-prop-types](https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types) wraps PropTypes in a NODE_ENV check, so they'll be removed in production.  I haven't checked exact numbers, but it should shave off a handful of kilobytes.

Great discussion! Since apparently there no actual issue I'm going to close. If some of you find useful to add a section in the docs with information about optimizing the bundle size, please refer to a new issue or open a PR, I'd really appreciate it! 😬


[auto-merge] branch-22.04 to branch-22.06 [skip ci] [bot]

auto-merge triggered by github actions on branch-22.04 to create a PR keeping branch-22.06 up-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.

FAILURE - Unable to auto-merge. Manual operation is required.
{'message': 'Pull Request is not mergeable', 'documentation_url': 'https://docs.github.com/rest/reference/pulls#merge-a-pull-request'}

Please use the following steps to fix the merge conflicts manually:
# Assume upstream is NVIDIA/spark-rapids remote
git fetch upstream branch-22.04 branch-22.06
git checkout -b fix-auto-merge-conflict-5198 upstream/branch-22.06
git merge upstream/branch-22.04
# Fix any merge conflicts caused by this merge
git commit -am "Merge branch-22.04 into branch-22.06"
git push <personal fork> fix-auto-merge-conflict-5198
# Open a PR targets NVIDIA/spark-rapids branch-22.06

IMPORTANT: Before merging this PR, be sure to change the merging strategy to Create a merge commit (repo admin only).
Once this PR is merged, the auto-merge PR should automatically be closed since it contains the same commit hashes

Working on this

close this PR manually as new commit come and conflict resolve PR merged w/o updating. will manual retrigger an auto-merge


Time-based Joins Example?

Summary
I'm very curious about this project and am wondering if the following usecase is implemented yet as I couldn't get it working from the quickstart docs:
$ oomcli import --input-file account0.csv --group account ... # contains information on day 0
$ oomcli import --input-file account1.csv --group account ... # contains information on day 1
$ oomcli import --input-file account3.csv --group account ... # contains information on day 3

In the account.csv provided in the docs, there is no event timestamp or created timestamp, so when you run omcli join it only takes information provided in account3.csv, irrespective of the event timestamp field provided.
On a related note, in a similar way after running oomcli sync, then oomcli get online only takes the very last imported file, although not a massive deal it would be "nice" QoL change if there is an option to propagate the previous revisions subject to TTL considerations (obviously not trivial).
This is a very interest library and approach to feature stores, and I wish the team best of luck!

@charliec443 First of all, welcome to our OOM land 🥳 We are glad to have you here!

This is a very interest library and approach to feature stores, and I wish the team best of luck!

Can't thank you enough! This is very encouraging to us :) BTW, do you mind joining our slack community? I am looking forward to building a long term connection with you and your use case :)

Regarding your questions on import+join and sync+get:
import+join

In the account.csv provided in the docs, there is no event timestamp or created timestamp ...

When running import, the timestamp of a "revision" is not given in the imported data file itself, instead, there are 2 sources:

oomcli import marks these data with timestamp t=(when import is run)
oomcli import --revision <user specified timestamp> marks these data with timestamp t=(user-specified timestamp)

so when you run omcli join it only takes information provided in account3.csv, irrespective of the event timestamp field provided.

When you run oomcli join, the joined result depends on the timestamps given in the label dataset (see label.csv) as well as the revision timestamp. For example, your label.csv contains a label with timestamp=day2, then that label should be able to join with data provided in account1.csv
sync+get

oomcli get online only takes the very last imported file

This is by design, since what people need for online serving are usually the latest feature values. Being able to read slightly outdated data - could you please explain when is that useful, and we are happy to learn!

@charliec443 Gonna close the issue, feel free to reopen or create a new one for any further questions.


Path separator compatibility problem

Using external files in MAC
@import '../../../css/common/_base.scss';

But there was a mistake on the window
Error: File "/css/common/_base.scss" not found

must change to this
@import '..\\..\\..\\css\\common\\_base.scss';

Please be compatible with this problem, otherwise you can't use the team.
thank you

I try to submit a change, please confirm

@GodD6366
Although your PR has been merged, the project owner has not released it. :(


MatDialog: When using in dynamically loaded component throws error No provider for MatDialog

Reproduction
When using MatDialog in a dynamically loaded component it doesn't work and throws error No provider for MatDialog.
Steps to reproduce:

Follow the instructions in this post (https://medium.com/angular-in-depth/lazy-load-components-in-angular-596357ab05d8 ) to create a dynamically loaded component
Add MatDialogModule to the imports array of NGModule for the dynamically loaded component.
ng serve and check the error in console.

Expected Behavior
It should work without throwing any error.
Actual Behavior
Throws below error:
zone-evergreen.js:659 Unhandled Promise rejection: R3InjectorError(AppBrowserModule)[MatDialog -> MatDialog -> MatDialog]:
  NullInjectorError: No provider for MatDialog! ; Zone: <root> ; Task: Promise.then ; Value: NullInjectorError: R3InjectorError(AppBrowserModule)[MatDialog -> MatDialog -> MatDialog]:
  NullInjectorError: No provider for MatDialog!
    at NullInjector.get (http://localhost:4200/vendor.js:34269:27)
    at R3Injector.get (http://localhost:4200/vendor.js:48199:33)
    at R3Injector.get (http://localhost:4200/vendor.js:48199:33)
    at R3Injector.get (http://localhost:4200/vendor.js:48199:33)
    at NgModuleRef$1.get (http://localhost:4200/vendor.js:65751:33)
    at Object.get (http://localhost:4200/vendor.js:63486:35)
    at getOrCreateInjectable (http://localhost:4200/vendor.js:38115:39)
    at Module.ɵɵdirectiveInject (http://localhost:4200/vendor.js:52134:12)
    at NodeInjectorFactory.MyDynamicallyLoadedComponent_Factory [as factory]

Environment

Angular: 10.0.0-next.6 (same behavior in other versions e.g. 9.x)
CDK/Material: 9.2.3
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

To reproduce the error, lazy load below component in AppModule
import { CommonModule } from '@angular/common';
import { Component, NgModule } from '@angular/core';
import { MatButtonModule } from '@angular/material/button';
import { MatDialog, MatDialogModule, MatDialogRef } from '@angular/material/dialog';

@Component({
  templateUrl: './my-lazy.component.html'
})
export class MylazyComponent {

  public dialogRef: MatDialogRef<any>;
  public dialogSub: any;

  constructor(public dialog: MatDialog) {

  }
}

@NgModule({
  imports: [
    CommonModule,
    MatButtonModule,
    MatDialogModule
  ],
  declarations: [MylazyComponent]
})
class MyLazyComponentModule {
}

Lazy import the above component in AppModule:
        const { MylazyComponent } = await import('./account/enable-notifications.component');
        const myLazyComponentFactory = this.cfr.resolveComponentFactory(MylazyComponent);
        this.myLazyComponentInstance = this.mylazyContainer.createComponent(myLazyComponentFactory, null, this.injector);

@naveedahmed1 any chance you could make a reproduction GitHub repo?

Thanks @jelbourn , can I add you to a private repo?

Sure

Thank you, I have added you to a private repo, just run ng serve and you will notice the error in the console. In AppComponent, I'm trying to dynamically load the EnableNotificationsComponent. Although the component file contains
@NgModule({
  imports: [
    CommonModule,
    MatButtonModule,
    MatDialogModule
  ],
  declarations: [
    EnableNotificationsComponent
  ]
})
class EnableNotificationsModule { }

its still throwing error Unhandled Promise rejection: R3InjectorError(AppBrowserModule)[MatDialog -> MatDialog -> MatDialog]:    NullInjectorError: No provider for MatDialog! ; Zone: <root> ; Task: Promise.then ; Value: NullInjectorError: R3InjectorError(AppBrowserModule)[MatDialog -> MatDialog -> MatDialog]:    NullInjectorError: No provider for MatDialog!

Same problem

I went to look today, but the invitation expired. The code you linked does look like it should work, though.

I added you again, can you please try it now?

@naveedahmed1 I still get a 404 from the invite

That's strange, I just removed you from collaborators and added again

Seems to have worked that time; I'll try to take a peek tomorrow during my weekly scheduled triage time

Thank you so much @jelbourn :)

Hello, any news on this?
I am having a similar issue.
Thanks.

I believe this is the same issue as https://github.com/angular/components/issues/19616. You can check it out for a better explanation.

@naveedahmed1 can you try what @devversion mentioned in #19616? The main thing is to ensure that you're using the MatDialog instance (to call dialog.open) that's provided/imported from the same NgModule in which the lazy-loaded component is declared.

@jelbourn thank you for your response.
If you take a look at my comment here https://github.com/angular/components/issues/19335#issuecomment-629696419 I am doing exactly the same, but the only difference is I am loading this component dynamically and not through router.

@naveedahmed1 I think the issue here is that you use the ComponentFactoryResolver from the root module and directly create the lazy component. It never goes through the lazy app module though, so the MatDialogModule with its's root providers (i.e. MatDialog service) are not having any effect.
The right solution would be to either:

Add the MatDialogModule to the root module so that the service is available in your whole application
Retrieve the ComponentFactoryResolver for the lazy module and instantiate the component through that.

If you go with (2), you might want to use Compiler#compileModuleSync, or directly work with NgModuleFactory. If the module is compiled with ngtsc, then the actual class is considered a factory in Ivy and you could wrap it in a NgModuleFactory, create an instance of it and then bootstrap a component with it. We have an example here (using Ivy factory shims though):
https://github.com/angular/components/blob/f0c7a25e0d58440029b4129188baa77d88ce5fc6/src/components-examples/private/load-example.ts#L14-L17
More general best-practices are probably in the Angular docs or in various great blog posts.

I've created a StackBlitz that shows the issue: https://stackblitz.com/edit/19335-before?file=src/main.ts. Here is an example with fix as per (2): https://stackblitz.com/edit/19335-with-fix?file=src/main.ts
The code responsible for loading the actual module with it's providers is the followed. Disclaimer: Can still be optimized with parallel loading but here it's sufficient for the example:
async loadComponent() {
  const lazyModule = await import('./app/lazy.module').then(d => d.LazyModule);
  const moduleFactory = this.compiler.compileModuleSync(lazyModule);
  const moduleInstance = moduleFactory.create(this.injector);
  const lazyComponent = await import('./app/lazy.component').then(d => d.LazyComponent);
  const factory = moduleInstance.componentFactoryResolver
    .resolveComponentFactory(lazyComponent);
  this.vcr.createComponent(factory, 0, this.injector);
}

Closing as this seems to work as expected. Please let us know if this does not work. An issue with an updated StackBlitz would be great. Thanks!


How to create poses_bounds.npy

Hi plz help me to find out the way to create poses_bounds.npy file.
Tnx in adv.

https://github.com/Fyusion/LLFF

Hi plz help me to find out the way to create poses_bounds.npy file. Tnx in adv.

General step-by-step usage    /     python imgs2poses.py <your_scenedir>
More details can be found at https://github.com/Fyusion/LLFF


Add documentation/configuration option about email verification

Right now, the README states that:

After you have entered a new password, you will receive a verification email.

However, for a fresh deployment of Nebari with the plugin, that's not the case. I'm assuming there's some kind of external configuration that has to be done (e.g., configuring a SMTP server in Keycloak) before the verification email gets sent.
Besides documenting this, would it make sense to expose it as a configuration option and potentially have the plugin configure the SMTP server automatically given some parameters?

Good catch.  For a first step, I will update the README so that it says the user will only receive a verification email if the email validation is currently enabled (with a link to the page I'm also working on about enabling outgoing SMTP)
Since email validation and SMTP configuration are core configuration items, I think it would make more sense for it to be configurable in the base Nebari config than through an extension.

This might be related @marcelovilla https://github.com/nebari-dev/nebari-docs/pull/463

Since email validation and SMTP configuration are core configuration items, I think it would make more sense for it to be configurable in the base Nebari config than through an extension.

This is reasonable. We might have already exposed a custom override capability to Keycloak's settings, but that is not well documented as we probably never used it.
Also, a bit out of the scope of this discussion, but regarding exposing some configuration to the user, I like the example HTML template Oauth0 provides. Maybe it would be a nice addition to enable styling or provide your own:

and the respective rendered email:

Also, a bit out of this discussion scope, but regarding exposing some configuration to the user here,  maybe it would be a nice addition to enable styling or provide your own custom email verification/token HTML:

Did a little digging here - it's possible to develop a custom set of email templates in Freemarker and then mount them at /opt/jboss/keycloak/themes/nebari .  We could also use the theme.jupyterhub portion of the config file to generate a template set with branding that matches the user's custom JHub theme.