Translate port probes into http probes

TCP probes do currently not work with istio sidecar, but there appears to be a need (#15178 #28737).
We have created this draft to collect feedback for a possible solution. It works the following way:

pilot-agent offers a HTTP endpoint e.g. under /check/{port}
If a request comes in, it checks if that port is opened in the running container
If it's open, return 200 - if not 404
Already present TCP probes would then be rewritten to HTTP based probes querying the above endpoint. As it's running as a sidecar, the check can go against localhost.

see #33491
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@googlebot I consent.

The high level concept seems like it could be a good idea. In the general case, it seems like an improvement for sure. My only concern is if there is some reason the users were using TCP probes instead of HTTP probes, where this would not work... I cannot really think of any. "Performance" I guess, but that doesn't seem like a real constraint here.
WDYT @ramaraochavali @incfly
In terms of implementation, we would want to follow https://github.com/istio/istio/blob/d5fd44e6f29f62969d6ed2e893a917a7ab429adc/pilot/cmd/pilot-agent/status/server.go#L530 and https://github.com/istio/istio/blob/cf657ff502e296ab9638248456e3ad7af2715e2e/pkg/kube/inject/app_probe.go#L63

Yeah. Idea in general makes sense to me as well.

Unfortunately, this part of the code is not unit tested at all. Please correct me if I am wrong. All private functions in the call stack.
I was thinking... How about refactoring webhook.go:applyRewrite() into an object (e.g. PodRewriter)?

The code should be unit testable
Additional functionality in that area would be easier to test
It seems to me that some of that existing code might be worth unit testing
I think the tests could be quite handy from a documentation point of view (i.e. this is how pods get rewritten by the webhook)

@howardjohn WDYT? Is it worth to put it into this draft to see how this would look like? Or have I missed something?

The code is a bit specific checking HTTP probes (e.g. ShouldRewriteAppHTTPProbers). Should we make it clearer that also TCP probes are affected? But there is this annotation sidecar.istio.io/rewriteAppHTTPProbers, which should only affect HTTP probes.

TestInjection has pretty extensive unit test coverage of the injection, it does it at a higher level (input yaml -> injected yaml). IIRC it has tests for probe rewrite. I think we can extend that with TCP probe?

TestInjection has pretty extensive unit test coverage of the injection, it does it at a higher level (input yaml -> injected yaml). IIRC it has tests for probe rewrite. I think we can extend that with TCP probe?

Sounds good. We will have a look.

Great idea and LGTM. We also have the integration test for probes, FYI, https://github.com/istio/istio/blob/4f1587eb64f9f6303f92dd4fa4771553fa0b4c01/tests/integration/security/mtls_healthcheck_test.go#L38

In the current state of the PR the TCP probe translation can be enabled and disabled via the sidecar.istio.io/rewriteAppHTTPProbers annotation. This is sub-optimal as it has "HTTP" in it's name. We see (at least) two alternatives here:

deprecate sidecar.istio.io/rewriteAppHTTPProbers and replace it with a sidecar.istio.io/rewriteAppProbers annotation, which will configure both HTTP and TCP rewrite. During the deprecation period rewriteAppHTTPProbers would probably also configure the TCP behavior.
add a separate sidecar.istio.io/rewriteAppTCPProbers annotation.

@c0d1ngm0nk3y and I are in favor of option 1, as we don't think there is a big use-case for having two separate settings.
@incfly @howardjohn WDYT?

I would just have rewriteAppHTTPProbers apply to both, and not rename/deprecate. The annotation is extremely niche - I would almost go as far as to say we should remove it.
if you read it like "rewrite app [probers, of any type] to HTTP probers [pointing to istio-agent]" it makes sense :slightly_smiling_face:

@c0d1ngm0nk3y: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test release-notes_istio

lint_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test release-notes_istio

lint_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test lint_istio

gencheck_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test release-notes_istio

lint_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test lint_istio

gencheck_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test gencheck_istio

unit-tests_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test release-notes_istio

lint_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test lint_istio

gencheck_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test gencheck_istio

unit-tests_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest-required

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test lint_istio

gencheck_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test gencheck_istio

unit-tests_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test integ-ipv6-k8s-tests_istio

release-notes_istio
024c6039dd0e2a654a316af27c1d1dd507bce850
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
0b6807abfe854b69cd277581d6a89eba480eaed6
link
/test integ-ipv6-k8s-tests_istio

release-notes_istio
024c6039dd0e2a654a316af27c1d1dd507bce850
link
/test release-notes_istio

lint_istio
024c6039dd0e2a654a316af27c1d1dd507bce850
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
024c6039dd0e2a654a316af27c1d1dd507bce850
link
/test release-notes_istio

lint_istio
024c6039dd0e2a654a316af27c1d1dd507bce850
link
/test lint_istio

integ-ipv6-k8s-tests_istio
024c6039dd0e2a654a316af27c1d1dd507bce850
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@googlebot I consent.

/test lint_istio
/test integ-ipv6-k8s-tests_istio

/test all

@c0d1ngm0nk3y: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
5ae202a6d8f082b5f7dd17854d4beb46a16a4347
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@c0d1ngm0nk3y: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test release-notes_istio

lint_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test release-notes_istio

lint_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test lint_istio

integ-pilot-multicluster-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test release-notes_istio

lint_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test lint_istio

integ-pilot-multicluster-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test release-notes_istio

lint_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test lint_istio

integ-pilot-multicluster-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest-required

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test lint_istio

integ-pilot-multicluster-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-cni-k8s-tests_istio

release-notes_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-cni-k8s-tests_istio

release-notes_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test release-notes_istio

unit-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-pilot-multicluster-tests_istio

integ-cni-k8s-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-cni-k8s-tests_istio

release-notes_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test release-notes_istio

unit-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-cni-k8s-tests_istio
ab7ff462df59a365afe05653011854b6488685f6
link
/test integ-cni-k8s-tests_istio

release-notes_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test release-notes_istio

unit-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test release-notes_istio

unit-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-multicluster-tests_istio

integ-cni-k8s-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y is this ready to go? If so, you can move it out of "draft" mode

@c0d1ngm0nk3y is this ready to go? If so, you can move it out of "draft" mode

The integration test is still failing for some reason. Once we figured that out, we will remove the "draft" from this PR.

/retest-required

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-multicluster-tests_istio

integ-cni-k8s-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-cni-k8s-tests_istio

release-notes_istio
ecbdd59ad9da87479538603525e4c590895a226b
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-multicluster-tests_istio

integ-cni-k8s-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-cni-k8s-tests_istio

release-notes_istio
ecbdd59ad9da87479538603525e4c590895a226b
link
/test release-notes_istio

lint_istio
ecbdd59ad9da87479538603525e4c590895a226b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-pilot-multicluster-tests_istio

integ-cni-k8s-tests_istio
39ee41cfcc8f036ddae6ef6553121489268de130
link
/test integ-cni-k8s-tests_istio

release-notes_istio
ecbdd59ad9da87479538603525e4c590895a226b
link
/test release-notes_istio

lint_istio
ecbdd59ad9da87479538603525e4c590895a226b
link
/test lint_istio

unit-tests_istio
ecbdd59ad9da87479538603525e4c590895a226b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest-required

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
ecbdd59ad9da87479538603525e4c590895a226b
link
/test lint_istio

unit-tests_istio
ecbdd59ad9da87479538603525e4c590895a226b
link
/test unit-tests_istio

release-notes_istio
76a4c21b11686f7207cb14584added2dd5843347
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
ecbdd59ad9da87479538603525e4c590895a226b
link
/test lint_istio

unit-tests_istio
ecbdd59ad9da87479538603525e4c590895a226b
link
/test unit-tests_istio

release-notes_istio
76a4c21b11686f7207cb14584added2dd5843347
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@c0d1ngm0nk3y: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
3215125059e758dfb716b4e8dbab4eef43e333f5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
3215125059e758dfb716b4e8dbab4eef43e333f5
link
/test release-notes_istio

lint_istio
3215125059e758dfb716b4e8dbab4eef43e333f5
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

/retest-required

@c0d1ngm0nk3y: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@c0d1ngm0nk3y: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-operator-controller-tests_istio

gencheck_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-operator-controller-tests_istio

gencheck_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-operator-controller-tests_istio

gencheck_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-operator-controller-tests_istio

gencheck_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-helm-tests_istio

release-notes_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-operator-controller-tests_istio

gencheck_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-helm-tests_istio

release-notes_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-notes_istio

analyze-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-operator-controller-tests_istio

gencheck_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-helm-tests_istio

release-notes_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-notes_istio

analyze-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-operator-controller-tests_istio

gencheck_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-helm-tests_istio

release-notes_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-notes_istio

analyze-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

lint_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test lint_istio

unit-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test unit-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-ipv6-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-operator-controller-tests_istio

gencheck_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-helm-tests_istio

release-notes_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-notes_istio

analyze-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-multicluster-tests_istio

integ-multicluster-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test release-test_istio

integ-distroless-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-cni-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-operator-controller-tests_istio

integ-telemetry-mc-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-helm-tests_istio

analyze-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test analyze-tests_istio

integ-pilot-multicluster-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-multicluster-tests_istio

integ-multicluster-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
16612c48a906c6e4586444ce7bfb0e5800469d1e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
d52eea4e446d1aa219689990f91260e5e44a4620
link
/test integ-security-multicluster-tests_istio

unit-tests_istio
16612c48a906c6e4586444ce7bfb0e5800469d1e
link
/test unit-tests_istio

integ-cni-k8s-tests_istio
16612c48a906c6e4586444ce7bfb0e5800469d1e
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@c0d1ngm0nk3y: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
6718a5d1d6da73ea513e9266920c6cf3d4b90d91
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@c0d1ngm0nk3y: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
6718a5d1d6da73ea513e9266920c6cf3d4b90d91
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

/test required

@c0d1ngm0nk3y: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test unit-tests_istio
/test release-test_istio
/test benchmark_istio
/test integ-pilot-k8s-tests_istio
/test integ-cni-k8s-tests_istio
/test integ-security-k8s-tests_istio
/test integ-telemetry-k8s-tests_istio
/test integ-telemetry-mc-k8s-tests_istio
/test integ-telemetry-istiodless-mc-k8s-tests_istio
/test integ-multicluster-k8s-tests_istio
/test integ-distroless-k8s-tests_istio
/test integ-ipv6-k8s-tests_istio
/test integ-operator-controller-tests_istio
/test integ-pilot-multicluster-tests_istio
/test integ-pilot-istiodless-multicluster-tests_istio
/test integ-security-multicluster-tests_istio
/test integ-security-istiodless-multicluster-tests_istio
/test integ-helm-tests_istio
/test integ-assertion-k8s-tests_istio
/test analyze-tests_istio
/test lint_istio
/test gencheck_istio
/test release-notes_istio

Use /test all to run the following jobs:

unit-tests_istio
release-test_istio
integ-pilot-k8s-tests_istio
integ-cni-k8s-tests_istio
integ-security-k8s-tests_istio
integ-telemetry-k8s-tests_istio
integ-telemetry-mc-k8s-tests_istio
integ-multicluster-k8s-tests_istio
integ-distroless-k8s-tests_istio
integ-ipv6-k8s-tests_istio
integ-operator-controller-tests_istio
integ-pilot-multicluster-tests_istio
integ-security-multicluster-tests_istio
integ-helm-tests_istio
analyze-tests_istio
lint_istio
gencheck_istio
release-notes_istio

In response to this:

/test required

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test all

/retest-required

We are trying to use tcp-based health and ready probes.
Istio seems to be listening to all ports.
This PR implies that this functionality is not available.

TCP probes do currently not work with istio sidecar, but there appears to be a need (#15178 #28737).

Doesn't this contradict this page however?


Hey, it looks like Go 1.24 branch is not created yet https://github.com/golang/go/branches/all. May I know what the next step is for this issue ^?

@smiletrl Right now we're working towards a Go 1.22.0 release. Nothing to do here until we get to the Go 1.24 dev cycle.

ah, I see. Thanks @dmitshur

cc @timothy-king

There's an order we'll need to follow for this.
First, the builders need to be configured to start using Go 1.22 as the bootstrap. I'll be working on this part.
After that's done, cmd/dist and more code in the main Go repo can start to require it and take advantage of it (CC @aclements).
I'll likely target Go 1.22.6 (to be out soon) as the initial concrete bootstrap version.

The builders are updated to provide a go1.22.6 bootstrap, and cmd/dist is updated to require it.
This is still open (but no longer a release blocker—that aspect of this issue is complete) to track any remaining opportunities in the Go tree to take advantage of the updated bootstrap requirement.

release note say:
Go 1.24 now requires Go 1.22.6 or later for bootstrap.
But master can now also bootstrap with 1.22.2.
go1.24 does require a minimum go1.22 bootstrap (by less than this version dist two source code declaration package names different enforcement), but currently does not enforce a minimum go1.22.6. I asked if go1.22.6 was the go team demanding more from themselves when developing it, or did the release notes mean something else?

currently does not enforce a minimum go1.22.6

We might be able to improve this in the future. We use go1.22.6 bootstraps in testing, so if there's a problem with using an older version, automated testing won't uncover it.
See https://go.dev/doc/go1.20#bootstrap and #54265#issuecomment-1268708470 for why we changed from selecting a .0 release to the latest available minor release (at the time we adopt the requirement) as the bootstrap.

We might be able to improve this in the future.

It can be improved. I've already written the code. I send CL 609762 .


om stage-product should be able to take a tile path

We briefly discussed this on slack. In short, we'd like to be able to say om stage-product --product-file /path/to/tile.pivotal instead of specifying --name and --version.
This helps us avoid having to re-specify information the system already knows when using this command in CI, and other times users use this right after upload-product.
Signed-off by @anEXPer

I'm a bit on the fence about this interface, and wondering if we could do something a little different that achieves the same goal.  For example, a command that prints the metadata for a tile which could be piped to stage-product.  Or maybe we're missing an flag on upload-product that attempts to stage it immediately...

Why on the fence?

UX-wise, my gut feel is that it seems odd to refer to a file on my local filesystem when I'm talking about a product that is in OM's list of available products

To me, it feels like the "feature" we are missing is the ability to omit the version from this request. In the Ops Manager UI, users don't get the choice of which version they want to stage; Ops Manager chooses the semantically latest version and that is what the user is presented with.
I know that that would still mean that you have to specify the product that you want to stage, which still ties your tooling to the specific product being staged, which is less than ideal. An alternative is to add om stage-all-available-products that would retrieve the list from the Ops Manager API and iterate through it.

@jtarchie for your use case, would this idea from @davewalter meet your needs?

To me, it feels like the "feature" we are missing is the ability to omit the version from this request. In the Ops Manager UI, users don't get the choice of which version they want to stage; Ops Manager chooses the semantically latest version and that is what the user is presented with.

I think I like that best so far, personally.

@mcwumbly, I'd rather explicitness on this, for our use case. The idea is that a client can specify a product version to stage. Just in case someone has done something from the UI. There is a config file that should be the source of truth of what product version to use. In the case of a pipeline, the .pivotal that they are uploading would be the source of truth for that version number.

--stage on the upload would also do it for us, I think. It's my favorite of the suggestions so far.

@anEXPer We can discuss in IPM, or you can submit a PR if you need this quickly.

I think we'd be happy with the separate metadata command @aegershman has sketched out, which we can use to get values to pass to stage-product. I'm closing this in favor of https://github.com/pivotal-cf/om/issues/231.


Update sample-single-page-app-vanillajs-sign-in.md

The part of the documentation is misleading. In the previous chapter you are told to create the path localhost:3000 as a redirect in the app registration. However, the cloned repository points to the path localhost:3000/redirect by default.
This PR adds an information that if you want to use the configured url (localhost:3000), you also have to delete the property in the repository so that the default value is used.
This information was previously missing in the list of adjustments to be made.

@OwenRichards1
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


ci: dynamic run expensive test

close: #87

remove docker feature
expensive test task set in .github/actions/(macos|windwos|ubuntu)/{lang}/action.yml
determine modified files using https://github.com/dorny/paths-filter

example: https://github.com/bxb100/pre-commit-rs/actions/workflows/ci-expensive.yml?query=branch%3ACI-demo2
test-branch: CI-demo CI-demo2

Thanks, gonna review soon!

This is a very clever approach. However, I'm hesitant to merge it right away, as our current Docker test isn't very costly and it's the only test that would benefit from this PR. I greatly appreciate your effort to improve this. In the future, if we have more expensive tests, I will definitely advocate for this change.

ok


Fixownerref4referredresouce

why do you always have sooooooooooo many commits?  something wrong with your personal repo?

/approve


Flamingo master

Make code can run on Android Studio Flamingo
• compileSdkVersion change 32 to 33
• targetSdkVersion 32 to 33
• sourceCompatibility change Java 8 to Java 17
• targetCompatibility change Java 8 to Java 17
• namespace add
• APG change 7.1.1 to 8.0.1
• Gradle change 7.2 to 8.1.1

Is this going to be merged?

I don't know it is going to be merged. I'm waiting approve.


init bug

hello there, I found a small bug, I'm opening this PR against main but if you prefer a different branch etc let me know :)
full error
$ k3ai init
☑	Checking requirements for local deployment...
☑	Installing infrastructure for local deployment...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    98  100    98    0     0    225      0 --:--:-- --:--:-- --:--:--   224
100   624  100   624    0     0    863      0 --:--:-- --:--:-- --:--:--   863
100 6660k  100 6660k    0     0  2970k      0  0:00:02  0:00:02 --:--:-- 5887k
ERROR: unknown command "cluster--namedemo-win-kind" for "kind create"
exit status 1
☑	Infrastructure ready, proceeding to plugins installation (if any)...
☑	Add Plugins to local deployment...
fork/exec bin/sh: no such file or directory
fork/exec bin/sh: no such file or directory
☑	Plugins added to local deployment...
🎉	Local deployment completed, have fun with k3ai!

pr fix
$ go run . init
☑	Checking requirements for local deployment...
☑	Installing infrastructure for local deployment...
	Selected deployment type: kind
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    98  100    98    0     0    114      0 --:--:-- --:--:-- --:--:--   114
100   624  100   624    0     0    543      0  0:00:01  0:00:01 --:--:--  609k
100 6660k  100 6660k    0     0  2552k      0  0:00:02  0:00:02 --:--:-- 6132k
[sudo] password for byron:
Creating cluster "demo-win-kind" ...
 ✓ Ensuring node image (kindest/node:v1.21.1) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
Set kubectl context to "kind-demo-win-kind"
You can now use your cluster with:

kubectl cluster-info --context kind-demo-win-kind

Have a nice day! 👋
☑	Infrastructure ready, proceeding to plugins installation (if any)...
☑	Add Plugins to local deployment...
☑	Plugins added to local deployment...
🎉	Local deployment completed, have fun with k3ai!

Codecov Report

Merging #92 (528364e) into main (843246e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   43.16%   43.16%
=======================================
  Files          13       13
  Lines         278      278
=======================================
  Hits          120      120
  Misses        131      131
  Partials       27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 843246e...528364e. Read the comment docs.


CI fails are hard to view

We now have 187 CI jobs. When a job fails one has to scroll through the list to find it, this is wearing out my mouse wheel and my patience - is there a better way to view the failed jobs?
(I did try a web search, unsuccessfully.)

You can enable github notifications on CI jobs. (Somehow I did this for rust-bitcoin, but I forget how.)
On failing PRs you can also click the "Actions" tab up top which I think gives you a more accessible view.

 It breaks down the moment things are no longer trivial.
Generally no matter where I go sooner or later I just have a handful of parallel CI machines/workflows for parallelism with distjoin workload each, then each executes bash script that actually takes care of running stuff with e.g. Gnu Parallel, outputting only things that failed, and doing all sorts of things that are too fancy to express in yaml.
In short: IMO the way to go is to try to avoid having to touch any Yaml, and use real programming to actually handle the problem in scalable and portable way.
E.g. just recently I changed our backward compatibility matrix test that runs all the tests against matrix of component versions to print only output of the test that failed:
https://github.com/fedimint/fedimint/pull/4526
because otherwise we would have to download it and analyze manually.
At this point I'm tempted to have a whole project with Rust command line tools for scripting CIs.

We have mostly done this - our Github CI pretty-much just sets variables and calls our shellscript. But we use it to set the variables because then we get parallelism in the Github UI and (I think) we get more compute than we would if we were doing local parallelism within a single CI runner.

Github will only allocate a fixed maxed amount of VMs running at the time for a project (I think 20?), so above certain number (depends on how many PRs typically run at the same) things are just start queuing and one needs to wait longer). In addition every VM has an initialization cost, so too many of them just makes things slower. But yeah - some VM-level (workflows, jobs) parallelism is great.
I now see rust-bitcoin has lots of jobs. IMO these would be better expressed as one GNU parallel run, with a benefit of that it would run in parallel locally as well.
See output from gnu parallel run that failed: https://github.com/fedimint/fedimint/actions/runs/8269976680/job/22626478246 . We get the output from ones that failed only + a summary. We could make the summary prettier or output only things that failed, but no one complained about it yet. :D
Another question is - do you really need to test so many of these on every PR. Possibly a PR could run a subset, and MQ (merge queue) the whole thing or something like that.

Anecdotally I've found CI way slower since we added the 180 odd jobs.

Another question is - do you really need to test so many of these on every PR. Possibly a PR could run a subset, and MQ (merge queue) the whole thing or something like that.

I'd really like to avoid getting green CI and having @apoelstra have to tell me when his local CI fails while trying to merge, that slows the process down. But I'd also like to run a more minimum set of CI jobs quickly to get better feedback. That is why I wrote just sane and it works pretty well but its missing some pieces (eg using the correct nightly version). This does beg the question that if devs are using local builds to check their work and the primary merge guy is using local builds to do pre-merge checks what is CI doing?

what is CI doing?

Proving to onlookers that the commit passes CI.
If I look back on a PR from years ago where some strange change to cargo or my OS causes attempts to build that commit to fail, but I see Github CI passed at that time... I am more likely to write it off as "old stuff breaks sometimes" instead of "DID U GAIZ ACKSHUALLY TEST THIS GARBAGE!" accusations.

Also, it catches the case where someone looks at the code, thinks "this should not affect anything" and tries to merge it with just a utACK.
Which doesn't really matter for this project in particular, but it's nice.

CI covers several things that my local CI doesn't -- notably stuff like msan/asan andtesting on other architectures. I might also not be testing examples; IIRC that was hard/manual to set up.
Conversely my local CI tests every commit and has a larger feature matrix for the unit tests.
I've seen many cases where one would pass but not the other.
As for having CI run a random subset ... Murphy's law says that literally the first PR after we do that will exhibit some intermittent CI failure that isn't detected and then master will be broken :).

Anecdotally I've found CI way slower since we added the 180 odd jobs.

Yeah, I think this is true. Certainly, waiting for any specific job to run is way slower. I think we should re-consolidate some of the jobs and paralellize them using parallel or something.

This is stale, CI is good now.


get() function in the python client to filter the concepts associated with a specific variable

Problem to Solve
Suppose we want to get the values of all the attributes of a certain EntityType. Based on this page https://dev.grakn.ai/docs/client-api/python I have two ways to execute a read transaction and reach my goal.
First approach:

Second approach:

Using the latter approach I noticed benefits in terms of performance when as a query I have a rule as discussed here https://github.com/graknlabs/grakn/issues/5227. However, the disadvantage is that I must specify the label (product in this case) of the EntityType of interest, while with the first approach I can always use the same variable x and formulate the query by associating the variable x with the EntityType of interest.
Proposed Solution
For this reason it would be useful to implement a get method similar to the following

@andreadegiorgi91
Maybe I'm missing something, but it sounds like you just want to collect all the Answers (not the Concepts, i.e. not use collect_concepts()).
You can just:
answer_iterator = read_transaction.query(query)
answers = list(answer_iterator)
for answer in answers:
    concept_something = answer.get('x')
.....


Should namespaces be passed down to child elements?

I'm having a bit of a problem, I may be overlooking something quite obvious, but here is the gist of my problem https://gist.github.com/IceDragon200/873139e6c7d395dfcd9793949f9b2246
What's happening here, I've created an element with a namespace and then child elements without a namespace, expecting the children to be as such (namespace-less), however nokogiri slaps the label on anyway.
Expected behaviour:
# WHERE xml is the top level builder
xml['namespace'].element do |builder_with_namespace|
  xml.element_without_namespace
  builder_with_namespace.element_with_namespace
end

Though judging from that, it wouldn't exactly be efficient, since you'd create a new builder context per element, unless checking the block's arity to avoid it.
tl;dr
Expected
<?xml version="1.0" encoding="utf-8"?>
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:emer="http://dashcs.com/api/v1/emergency">
  <soapenv:Header/>
  <soapenv:Body>
    <emer:validateLocation>
      <location>
        <address1>Some place over the rainbow</address1>
        <community>Community</community>
        <postalcode>PS</postalcode>
        <state>AR</state>
        <type>ADDRESS</type>
      </location>
    </emer:validateLocation>
  </soapenv:Body>
</soapenv:Envelope>

Actual
<?xml version="1.0" encoding="utf-8"?>
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:emer="http://dashcs.com/api/v1/emergency">
  <soapenv:Header/>
  <soapenv:Body>
    <emer:validateLocation>
      <emer:location>
        <emer:address1>Some place over the rainbow</emer:address1>
        <emer:community>Community</emer:community>
        <emer:postalcode>PS</emer:postalcode>
        <emer:state>AR</emer:state>
        <emer:type>ADDRESS</emer:type>
      </emer:location>
    </emer:validateLocation>
  </soapenv:Body>
</soapenv:Envelope>

Test
require 'nokogiri' # nokogiri (<IP_ADDRESS>)

result = Nokogiri::XML::Builder.new(encoding: 'utf-8') do |xml|
  xml['soapenv'].Envelope('xmlns:soapenv' => 'http://schemas.xmlsoap.org/soap/envelope/', 'xmlns:emer' => 'http://dashcs.com/api/v1/emergency') do
    xml['soapenv'].Header
    xml['soapenv'].Body do
      xml['emer'].validateLocation do
        # these do not require a namespace
        xml.location do
          xml.address1 'Some place over the rainbow'
          xml.community 'Community'
          xml.postalcode 'PS'
          xml.state 'AR'
          xml.type 'ADDRESS'
        end
      end
    end
  end
end.to_xml

# suddenly WILD NAMESPACES APPEAR!
puts result

Is this same as #425 ?

@akostadinov Yes, it appears so, I'm surprised this issue has been brought up before...

For a temporary workaround, have you tried explicitly setting the namespace nil?
The following is working for me:
result = Nokogiri::XML::Builder.new(encoding: 'utf-8') do |xml|
  xml['soapenv'].Envelope('xmlns:soapenv' => 'http://schemas.xmlsoap.org/soap/envelope/', 'xmlns:emer' => 'http://dashcs.com/api/v1/emergency') do
    xml['soapenv'].Header
    xml['soapenv'].Body do
      xml['emer'].validateLocation do
        xml.parent.namespace = nil # explicitly set namespace to nil
        xml.location do
          xml.address1 'Some place over the rainbow'
          xml.community 'Community'
          xml.postalcode 'PS'
          xml.state 'AR'
          xml.type 'ADDRESS'
        end
      end
    end
  end
end.to_xml

I had the same problem but setting the parent namespace to nil did not work for me.
This is what I initially did
Nokogiri::XML::Builder.new { |xml| xml["foo"].Root("xmlns:foo" => "localhost") { xml.Test "hello" } }.to_xml

<?xml version="1.0"?>
<foo:Root xmlns:foo="localhost">
  <foo:Test>hello</foo:Test>
</foo:Root>

But I only wanted the namespace on Root.
I then found this GH issue and tried the following
Nokogiri::XML::Builder.new { |xml| xml["foo"].Root("xmlns:foo" => "localhost") { xml.parent.namespace = nil; xml.Test "hello" } }.to_xml

<?xml version="1.0"?>
<Root xmlns:foo="localhost">
  <Test>hello</Test>
</Root>

The namespace then got removed from both Root and Test.
Ultimately I got the desired output by introducing a default namespace
Nokogiri::XML::Builder.new { |xml| xml["foo"].Root("xmlns:foo" => "localhost", "xmlns" => "default") { xml.Test "hello" } }.to_xml

<?xml version="1.0"?>
<foo:Root xmlns:foo="localhost" xmlns="default">
  <Test>hello</Test>
</foo:Root>

BUT the XML endpoint I was calling didn't want the default namespace, 😞 , soooo...
Nokogiri::XML::Builder
  .new { |xml| xml["foo"].Root("xmlns:foo" => "localhost", "xmlns" => "default") { xml.Test "hello" } }
  .to_xml
  .sub(' xmlns="default"', "")

<?xml version="1.0"?>
<foo:Root xmlns:foo="localhost">
  <Test>hello</Test>
</foo:Root>

The following workaround works if you need to keep the parent's namespace (set it to nil temporarily and then restore after you created all child elements that don't need a namespace):
require 'nokogiri'

result = Nokogiri::XML::Builder.new(encoding: 'utf-8') do |xml|
  xml['soapenv'].Envelope('xmlns:soapenv' => 'http://schemas.xmlsoap.org/soap/envelope/', 'xmlns:emer' => 'http://dashcs.com/api/v1/emergency') do
    xml['soapenv'].Header
    xml['soapenv'].Body do
      xml['emer'].validateLocation do
        # these do not require a namespace

        parent_namespace = xml.parent.namespace
        xml.parent.namespace = nil

        xml.location do
          xml.address1 'Some place over the rainbow'
          xml.community 'Community'
          xml.postalcode 'PS'
          xml.state 'AR'
          xml.type 'ADDRESS'
        end

        xml.parent.namespace = parent_namespace

      end
    end
  end
end.to_xml

puts result

Produces:
<?xml version="1.0" encoding="utf-8"?>
<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:emer="http://dashcs.com/api/v1/emergency">
  <soapenv:Header/>
  <soapenv:Body>
    <emer:validateLocation>
      <location>
        <address1>Some place over the rainbow</address1>
        <community>Community</community>
        <postalcode>PS</postalcode>
        <state>AR</state>
        <type>ADDRESS</type>
      </location>
    </emer:validateLocation>
  </soapenv:Body>
</soapenv:Envelope>

Apologies for not responding on this issue before now. This was originally reported at #425 and was fixed in #1712 for v1.12.0, but then modified in #2320 for v1.12.4.
Current behavior is controlled by Document#namespace_inheritance described at:

https://nokogiri.org/rdoc/Nokogiri/XML/Document.html#attribute-i-namespace_inheritance
https://nokogiri.org/rdoc/Nokogiri/XML/Builder.html?h=builder#class-Nokogiri::XML::Builder-label-Namespace+inheritance

which defaults to false for normal documents, but defaults to true for Builder-generated documents. You can opt out of this by passing namespace_inheritance: false to the Builder constructure:
b = Nokogiri::XML::Builder.new(encoding: 'utf-8', namespace_inheritance: false) do |xml|
  xml['soapenv'].Envelope('xmlns:soapenv' => 'http://schemas.xmlsoap.org/soap/envelope/', 'xmlns:emer' => 'http://dashcs.com/api/v1/emergency') do
    xml['soapenv'].Header
    xml['soapenv'].Body do
      xml['emer'].validateLocation do
        # these do not require a namespace
        xml.location do
          xml.address1 'Some place over the rainbow'
          xml.community 'Community'
          xml.postalcode 'PS'
          xml.state 'AR'
          xml.type 'ADDRESS'
        end
      end
    end
  end
end

b.to_xml
# => "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n" +
#    "<soapenv:Envelope xmlns:soapenv=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:emer=\"http://dashcs.com/api/v1/emergency\">\n" +
#    "  <soapenv:Header/>\n" +
#    "  <soapenv:Body>\n" +
#    "    <emer:validateLocation>\n" +
#    "      <location>\n" +
#    "        <address1>Some place over the rainbow</address1>\n" +
#    "        <community>Community</community>\n" +
#    "        <postalcode>PS</postalcode>\n" +
#    "        <state>AR</state>\n" +
#    "        <type>ADDRESS</type>\n" +
#    "      </location>\n" +
#    "    </emer:validateLocation>\n" +
#    "  </soapenv:Body>\n" +
#    "</soapenv:Envelope>\n"


subjectAltName, implement v3 Certificate Extensions

Chrome and other A-grade browsers now report Subject Alternative Name Missing for certificates that do not specify subjectAltName in v3 Certificate Extensions...
i've documented how to resolve this, here:
https://internal.10up.com/docs/self-signed-ssl-cert-w-subjectaltname-for-development-use/

@krisgale  note that we're archiving WP Local Docker in favor of the newer WP Local Docker v2, so please update to the v2 version and we can discuss any further issues you see in its respective repo.  Thanks!


remove old timeline JS from public

Remove outdated timeline code from the public folder

@miq-bot add_label ui, technical_debt

@miq-bot assign @dclarizio

cc @Fryguy

@miq-bot add_label technical debt

@miq-bot add_label euwe/no

cc @Fryguy ( @jrafanie will like this too )

+0 −7,854 wow
✂ 🔥 ✂ 🔥 ✂ 🔥
🍰  🍪 👏 🙇 😍 🎉

@miq-bot assign @dclarizio

The files are still referenced from app/views/layouts/application.html.haml..
       - if @timeline
        = javascript_include_tag '/javascripts/timeline/api/timeline-api.js'
        - if @timeline_filter
          = javascript_include_tag '/javascripts/timeline/api/scripts/miq_filters.js'
          = javascript_include_tag '/javascripts/timeline/api/scripts/miq_layouts.js'
          = javascript_include_tag '/javascripts/timeline/api/scripts/miq_painters.js'


Add setAttribute command for the profile module

Description
As a step towards #95 , add a command to update the attributes of an existing user NFT.  Since we already have another command for transferring the ownership of the NFT token, this command should not perform the transfer action, meaning, we should not be able to change the creatorAccount using setAttribute.
Acceptance Criteria

Throw an error if not the owner
Throw an error if NFT doesn't exist
Do not allow transfers
Add required unit tests

This is already resolved by #122


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/network/ddos-protection-plan
Module Details
CARML > AVM
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
segraef
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Hi @segraef,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team

NOTE:

This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @segraef,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
We just want to ask you to double check a few important things and take the next steps before you start the development.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - to name your module
TelemetryIdPrefix - to be used in your module's telemetry

For your module's repository:

Repository name and folder path are defined in RepoURL
Create the GitHub teams defined in the ModuleOwnersGHTeam and ModuleContributorsGHTeam columns and grant them permissions as described here.

In case of a Bicep module, please let the AVM core team know when you created these teams, and we'll help you with assigning the necessary permissions as described here.
In case of a Terraform module, follow the instructions here and assign the necessary permissions.

Grant the right level of permissions for  the AVM core team and PG teams on your GitHub repo as described here.
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment, once your module is ready to be published! 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

NOTE:

This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@segraef,
Due to a recent change in the naming convention for AVM Bicep modules, this module is getting an updated name.
The title and description of this GH issue has been updated to reflect the name change. Please make sure you adhere to the new naming convention when publishing your module!
Please see the new naming convention in:

RMNFR1 for resource modules
PMNFR1 for pattern modules

Please note that the Telemetry ID and name of GitHub Teams haven't changed.
If you feel uncertain about any details, please check the Bicep modules indexes.

in progress

https://github.com/Azure/bicep-registry-modules/pull/738

https://github.com/Azure/bicep-registry-modules/pull/738 merged and published.

[x] PR merged; Module published.
[x] GitHub teams are available and assigned to their parents.
[x] CODEOWNERS file updated.

Thank you for your work @segraef! I'm closing this issue now.


Add rosdep keys for gazebo9

If one package calls out gazebo7 and one package calls out gazebo9 they won't be able to be installed on the same system, and we'll end up with packages in the same rosdistro that are no longer compatible. Part of the role of our distro management is to specifically pick a single version that we know is compatible and enforce that.
We can merge this as is, but it's basically leaving a lot of corner cases for our users to foul up, and it's not just localized to them, if we get separate sets of packages with the conflicting dependencies, it can bifrucate the rosdistro(s).

Sound good to me this vision. I see two options: we remove the definitions to gazebo9and libgazebo9 and add a generic libgazebo-dev key in the same way that we have gazebo. Or we keep the xxx9 keys and I refine/fix the support platforms (I found this a bit redundant and see no real gain to be honest).

Sound good to me this vision. I see two options: we remove the definitions to gazebo9and libgazebo9 and add a generic libgazebo-dev key in the same way that we have gazebo.

How would that work for Debian Stretch ? (for Lunar it should resolve to gazebo7 and for melodic it should resolve to gazebo9). My guess was that introducing the gazebo9 key would allow gazeb_ros_pkgs to be released in melodic and using gazebo9 as a key to be sure to pick that version on Debian Stretch.
Gazebo 9 is available in the ros repositories for Ubuntu Artful and Debian Stretch (http://packages.ros.org/ros/ubuntu/pool/main/g/gazebo9/). I agree this doesnt resolve the situaton for the other platforms though.

How would that work for Debian Stretch ? (for Lunar it should resolve to gazebo7 and for melodic it should resolve to gazebo9).

Ummm, that is probably the reason why it was created in the first place and the reason why I found it redundant while it is not. Good point.

Thanks Jose for iterating on this! this looks good to me now +1

Thanks for tips Mika. I'll wait for Tully no problem.


Implement Task delete functionality

Tasks can now be deleted with a taskdeletecommand. Deleted tasks will also be removed from view in the task panel.


More tests and refactorings

Code Coverage

File
Coverage [90.05%]
:white_check_mark:

shared/component/tab/editor/child/attachments/src/commonMain/kotlin/com/sedsoftware/tackle/editor/attachments/domain/EditorAttachmentsManager.kt
96.97%
:white_check_mark:

shared/component/tab/editor/child/attachments/src/commonMain/kotlin/com/sedsoftware/tackle/editor/attachments/store/EditorAttachmentsStoreProvider.kt
97.09%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/AccountMapper.kt
97.37%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/ApplicationMapper.kt
100.00%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/CustomEmojiMapper.kt
100.00%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/FieldMapper.kt
100.00%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/FilterResultMapper.kt
0.00%
:x:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/InstanceMapper.kt
100.00%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/MediaAttachmentMapper.kt
96.88%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/PollMapper.kt
0.00%
:x:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/PreviewCardMapper.kt
100.00%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/RoleMapper.kt
100.00%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/RuleMapper.kt
100.00%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/SearchMapper.kt
100.00%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/StatusMapper.kt
100.00%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/TagMapper.kt
100.00%
:white_check_mark:

shared/network/src/commonMain/kotlin/com/sedsoftware/tackle/network/mapper/TokenMapper.kt
100.00%
:white_check_mark:

Total Project Coverage
94.76%
:white_check_mark: