Template doesn't work in nativescript 6.2.0

Template in listView doesn't work in nativescript 6.2.0
after "tns update"
Couldn't determine component to use for item at 299

Yikes!, I'll look into this asap

I have shipped svelte-native 0.7.0 that resolves this. I didn't make any changes to the svelte native code apart from compiling against the newer version of the core modules (even though they should be external), but confirmed the problem goes away.

Hi @halfnelson,
with the newest svelte-native-template as of 20191124 I get this error building the todoapp:
TypeError: Object(...) is not a function
File: (file:///data/data/org.nativescript.preview/files/app/vendor.js:891:10)

StackTrace:
c(file:///data/data/org.nativescript.preview/files/app/bundle.js:132:76)
	at init(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte/internal/index.js:1298:19)
	at App(file:///data/data/org.nativescript.preview/files/app/bundle.js:232:63)
	at createProxiedComponent(file:///data/data/org.nativescript.preview/files/app/vendor.js:1207:9)
	at ProxyComponent(file:///data/data/org.nativescript.preview/files/app/vendor.js:806:89)
	at Proxy<App>(file:///data/data/org.nativescript.preview/files/app/vendor.js:863:11)
	at resolveComponentElement(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte-native/dom/index.js:1279:22)
	at navigate(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte-native/dom/index.js:1292:35)
	at svelteNative(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte-native/index.js:38:26)
	at (file:///data/data/org.nativescript.preview/files/app/bundle.js:331:67)
	at ./app.ts(file:///data/data/org.nativescript.preview/files/app/bundle.js:344:30)
	at __webpack_require__(file:///data/data/org.nativescript.preview/files/app/runtime.js:751:30)
	at checkDeferredModules(file:///data/data/org.nativescript.preview/files/app/runtime.js:44:23)
	at webpackJsonpCallback(file:///data/data/org.nativescript.preview/files/app/runtime.js:31:19)
	at (file:///data/data/org.nativescript.preview/files/app/bundle.js:2:57)
	at require(:1:266)

TypeError: Object(...) is not a function
	at com.tns.Runtime.runModule(Native Method)
	at com.tns.Runtime.runModule(Runtime.java:674)
	at com.tns.Runtime.run(Runtime.java:666)
	at com.tns.NativeScriptApplication.onCreate(NativeScriptApplication.java:21)
	at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1155)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5954)
	at android.app.ActivityThread.access$1200(ActivityThread.java:200)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1673)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:201)
	at android.app.ActivityThread.main(ActivityThread.java:6815)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:873)

Commenting out the Template tag the error disappears...

@okrad I am having trouble replicating the problem. I created a repo with the todoapp from the tutorial
https://github.com/halfnelson/svelte-native-todo-tutorial
and ran it with a fresh version of the template, it works as expected. Maybe it is something to do with your implementation?

Hi @halfnelson,
I'm just starting out with nativescript so I could be missing something...
I cloned the svelte-native-todo-tutorial repo, run npm install and then tns preview.
After scanning the QR code I get this error on the phone:
com.tns.NativeScriptException: Error calling module function TypeError: Object(...) is not a function
File: (file:///data/data/org.nativescript.preview/files/app/vendor.js:891:10)
StackTrace: c(file:///data/data/org.nativescript.preview/files/app/bundle.js:192:76)
at init(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte/internal/index.js:1298:19)
at App(file:///data/data/org.nativescript.preview/files/app/bundle.js:363:63)
at createProxiedComponent(file:///data/data/org.nativescript.preview/files/app/vendor.js:1207:9)
at ProxyComponent(file:///data/data/org.nativescript.preview/files/app/vendor.js:806:89)
at Proxy<App>(file:///data/data/org.nativescript.preview/files/app/vendor.js:863:11)
at resolveComponentElement(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte-native/dom/index.js:1279:22)
at navigate(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte-native/dom/index.js:1292:35)
at svelteNative(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte-native/index.js:38:26)
at (file:///data/data/org.nativescript.preview/files/app/bundle.js:463:67)
at ./app.ts(file:///data/data/org.nativescript.preview/files/app/bundle.js:476:30)
at __webpack_require__(file:///data/data/org.nativescript.preview/files/app/runtime.js:751:30)
at checkDeferredModules(file:///data/data/org.nativescript.preview/files/app/runtime.js:44:23)
at webpackJsonpCallback(file:///data/data/org.nativescript.preview/files/app/runtime.js:31:19)
at (file:///data/data/org.nativescript.preview/files/app/bundle.js:2:57)
at require(:1:266)

TypeError: Object(...) is not a function
at com.tns.Runtime.runModule(Native Method)
at com.tns.Runtime.runModule(Runtime.java:674)
at com.tns.Runtime.run(Runtime.java:666)
at com.tns.NativeScriptApplication.onCreate(NativeScriptApplication.java:21)
at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1155)
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5954)
at android.app.ActivityThread.access$1200(ActivityThread.java:200)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1673)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:201)
at android.app.ActivityThread.main(ActivityThread.java:6815)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:873)

and in the terminal I get the same error as before.
I'm starting to believe it's a problem with my nativescript installation...

It could be, does tns --version say 6.2?
On Mon, 25 Nov 2019, 6:01 pm okrad<EMAIL_ADDRESS>wrote:

Hi @halfnelson https://github.com/halfnelson,
I'm just starting out with nativescript so I could be missing something...
I cloned the svelte-native-todo-tutorial repo, run npm install and then
tns preview.
After scanning the QR code I get this error on the phone:
com.tns.NativeScriptException: Error calling module function TypeError: Object(...) is not a function
File: (file:///data/data/org.nativescript.preview/files/app/vendor.js:891:10)
StackTrace: c(file:///data/data/org.nativescript.preview/files/app/bundle.js:192:76)
at init(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte/internal/index.js:1298:19)
at App(file:///data/data/org.nativescript.preview/files/app/bundle.js:363:63)
at createProxiedComponent(file:///data/data/org.nativescript.preview/files/app/vendor.js:1207:9)
at ProxyComponent(file:///data/data/org.nativescript.preview/files/app/vendor.js:806:89)
at Proxy(file:///data/data/org.nativescript.preview/files/app/vendor.js:863:11)
at resolveComponentElement(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte-native/dom/index.js:1279:22)
at navigate(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte-native/dom/index.js:1292:35)
at svelteNative(file:///data/data/org.nativescript.preview/files/app/tns_modules/svelte-native/index.js:38:26)
at (file:///data/data/org.nativescript.preview/files/app/bundle.js:463:67)
at ./app.ts(file:///data/data/org.nativescript.preview/files/app/bundle.js:476:30)
at webpack_require(file:///data/data/org.nativescript.preview/files/app/runtime.js:751:30)
at checkDeferredModules(file:///data/data/org.nativescript.preview/files/app/runtime.js:44:23)
at webpackJsonpCallback(file:///data/data/org.nativescript.preview/files/app/runtime.js:31:19)
at (file:///data/data/org.nativescript.preview/files/app/bundle.js:2:57)
at require(:1:266)
TypeError: Object(...) is not a function
at com.tns.Runtime.runModule(Native Method)
at com.tns.Runtime.runModule(Runtime.java:674)
at com.tns.Runtime.run(Runtime.java:666)
at com.tns.NativeScriptApplication.onCreate(NativeScriptApplication.java:21)
at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1155)
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5954)
at android.app.ActivityThread.access$1200(ActivityThread.java:200)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1673)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:201)
at android.app.ActivityThread.main(ActivityThread.java:6815)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:873)
and in the terminal I get the same error as before.
I'm starting to believe it's a problem with my nativescript installation...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/halfnelson/svelte-native/issues/98?email_source=notifications&email_token=AAEGS5HOKBZHZ5JIA7PVI73QVOA5FA5CNFSM4JMPTUU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFBPR5A#issuecomment-558037236,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEGS5AEUMF7M4O2DYKTKF3QVOA5FANCNFSM4JMPTUUQ
.

Kind of... It's 6.2.2...
Sorry, I didn't realize it before. Maybe I should downgrade to 6.2.0?

Nah, 6.2.2 should work. Does it work with tns run ?
On Mon, 25 Nov 2019, 6:51 pm okrad<EMAIL_ADDRESS>wrote:

Kind of... It's 6.2.2...
Sorry, I didn't realize it before. Maybe I should downgrade to 6.2.0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/halfnelson/svelte-native/issues/98?email_source=notifications&email_token=AAEGS5CDJYNETNY4XEGMMVLQVOGYXA5CNFSM4JMPTUU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFBTQRI#issuecomment-558053445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEGS5ASI6H7A2EONQUE4XLQVOGYXANCNFSM4JMPTUUQ
.

Yes, it works both with the android emulator and with the actual phone...
The only problem is in preview mode... I guess I'll just use "tns run" then...

Thanks for helping debug the issue. I don't usually use preview, the camera
on my phone can't focus so scanning the we code is a pain
On Mon, 25 Nov 2019, 8:33 pm okrad<EMAIL_ADDRESS>wrote:

Yes, it works both with the android emulator and with the actual phone...
The only problem is in preview mode... I guess I'll just use "tns run"
then...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/halfnelson/svelte-native/issues/98?email_source=notifications&email_token=AAEGS5CLIUCVPAVC32H3E4TQVOSWRA5CNFSM4JMPTUU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFB5KAY#issuecomment-558093571,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEGS5CEG67GZGLGYOQGZBDQVOSWRANCNFSM4JMPTUUQ
.

Thank you for taking the time of looking into it!

I tried preview with latest version of the Nativescript Playground and Nativescript Preview apps on my phone and couldn't reproduce. If you update your Playground and Preview Apps and clone the latest todoapp repo do you still get the same behaviour?

I think this was finally resolved after managing to reproduce with latest nativescript. The latest version of the preview app combined with latest svelte-native (and updated webpack.config from the template) should fix this.

Sorry, I have been quite busy in recent days...
I can confirm that the problem is fixed with the new version of nativescript.


Add possibility to set babel 7 config file path

I am trying to use mocha with Babel7 and I came across the following problem. Babel 7 can be configured via babel.config.js however, there seems to be no way to pass babel config file path to mocha. I asked a question at stackoverflow but got no answer.
If it is possible to do, then, please, say how. If not, then, please, add such possibility.

From Babel's config file docs:

New in Babel 7.x, Babel has as concept of a "root" directory, which defaults to the current working directory. For project-wide configuration, Babel will automatically search for a "babel.config.js" in this root directory. Alternatively, users can use an explicit "configFile" value to override the default config file search behavior.

So why would you need to pass anything?

@plroebuck
This is my project structure:
script4j
|
|-modules
|   |-script4j.base
|   |-script4jfx.base
|   |-script4jfx.graphics
-babel.config.js

So, I have three ES6 modules. Module script4jfx.graphics depends on other two modules. The problem with Babel 7 is that it is not so easy to make it compile files outside current folder. To solve this problem I try using babel.config.js.
I think that it is not referenced because after removing all .babelrc from modules and adding babel.config.js to project root mocha doesn't use babel - I get import/export unexpected token error.
What about debugging I didn't find way how to enable it while using mocha. If you say, I would be thankful to you.

Forget Mocha for the moment. What happens when you enable debugging and run Babel by hand? Does that show your "babel.config.js" settings being used?

This is my babel.config.js:
module.exports = function (api) {
    api.cache(true);
    const presets = ["@babel/preset-env"];
    console.log("Point XXX"); //NOTE THIS LINE
    return {
        babelrcRoots: [
            '.',
            './modules/*',
        ],
          ignore: [
            './node_modules/*',
        ],
        presets//plugins
    };
}

Here we go:
$ pwd
/home/Pavel/script4j/modules/script4jfx.graphics

$ npx babel ./tmp/script4jfx.graphics.spec.js
import { ArrayList } from 'script4j.base';
import 'script4jfx.base';
import { describe, it, beforeEach } from 'mocha';
describe('NodeTest', () => {
  beforeEach(function () {});
  it('test', () => {
    let l = new ArrayList();
    console.log(l);
    console.log("test");
  });
});

$ npx babel ./tmp/script4jfx.graphics.spec.js --config-file ./../../babel.config.js
Point XXX
"use strict";

var _script4j = require("script4j.base");

require("script4jfx.base");

var _mocha = require("mocha");

(0, _mocha.describe)('NodeTest', function () {
  (0, _mocha.beforeEach)(function () {});
  (0, _mocha.it)('test', function () {
    var l = new _script4j.ArrayList();
    console.log(l);
    console.log("test");
  });
})

As you see without setting config-file it doesn't work.

@plroebuck
This is my babel.config.js:
module.exports = function (api) {
    api.cache(true);
    const presets = ["@babel/preset-env"];
    console.log("Point XXX"); //NOTE THIS LINE
    return {
        babelrcRoots: [
            '.',
            './modules/*',
        ],
          ignore: [
            './node_modules/*',
        ],
        presets//plugins
    };
}

Here we go:
$ pwd
/home/Pavel/script4j/modules/script4jfx.graphics

$ npx babel ./tmp/script4jfx.graphics.spec.js
import { ArrayList } from 'script4j.base';
import 'script4jfx.base';
import { describe, it, beforeEach } from 'mocha';
describe('NodeTest', () => {
  beforeEach(function () {});
  it('test', () => {
    let l = new ArrayList();
    console.log(l);
    console.log("test");
  });
});

$ npx babel ./tmp/script4jfx.graphics.spec.js --config-file ./../../babel.config.js
Point XXX
"use strict";

var _script4j = require("script4j.base");

require("script4jfx.base");

var _mocha = require("mocha");

(0, _mocha.describe)('NodeTest', function () {
  (0, _mocha.beforeEach)(function () {});
  (0, _mocha.it)('test', function () {
    var l = new _script4j.ArrayList();
    console.log(l);
    console.log("test");
  });
})

As you see without setting config-file it doesn't work.

From Babel's docs, it says:

The primary downside of this project-wide config is that, because it relies on the working directory, it can be more painful to use in monorepos if the working directory is not the monorepo root.

(not claiming any Babel expertise)
So I would try the following first:
$ MONOREPO="/home/Pavel/script4j"
$ MODULES_DIR="${MONOREPO}/modules"
$ MOD_BASE="${MODULES_DIR}/script4j.base"
$ MOD_FXBASE="${MODULES_DIR}/script4jfx.base"
$ MOD_FXGRAPHICS="${MODULES_DIR}/script4jfx.graphics"
$ cat << EOF >> "${MOD_BASE}/.babelrc"
{ "extends": "../../babel.config.js" }

EOF
$ ln -s "${MOD_BASE}/.babelrc" "${MOD_FXBASE}/.babelrc"
$ ln -s "${MOD_BASE}/.babelrc" "${MOD_FXGRAPHICS}/.babelrc"

After that, rerun your "Point XXX" test from above. The RC files should allow Babel to pickup config when running npx from various locations.

@plroebuck
I've already tried what you suggest. The problem is that .babelrc doesn't extend well babel.config.js. But to make it clear for you I repeat, so :
I added .babelrc to /home/Pavel/script4j/modules/script4jfx.graphics with the following content:
{ "extends": "../../babel.config.js" }
And now:
$ npx babel ./tmp/script4jfx.graphics.spec.js

Point XXX
Error: .babelrcRoots is not allowed in .babelrc or "extends"ed files, only in root programmatic options, or babel.config.js/config file options
    at Object.keys.forEach.key (/home/Pavel/script4j/modules/script4jfx.graphics/node_modules/@babel/core/lib/config/validation/options.js:100:15)
    at Array.forEach (<anonymous>)
    at validateNested (/home/Pavel/script4j/modules/script4jfx.graphics/node_modules/@babel/core/lib/config/validation/options.js:83:21)
    at validate (/home/Pavel/script4j/modules/script4jfx.graphics/node_modules/@babel/core/lib/config/validation/options.js:74:10)
    at file (/home/Pavel/script4j/modules/script4jfx.graphics/node_modules/@babel/core/lib/config/config-chain.js:179:34)
    at cachedFunction (/home/Pavel/script4j/modules/script4jfx.graphics/node_modules/@babel/core/lib/config/caching.js:33:19)
    at mergeExtendsChain (/home/Pavel/script4j/modules/script4jfx.graphics/node_modules/@babel/core/lib/config/config-chain.js:299:35)
    at /home/Pavel/script4j/modules/script4jfx.graphics/node_modules/@babel/core/lib/config/config-chain.js:279:12
    at buildRootChain (/home/Pavel/script4j/modules/script4jfx.graphics/node_modules/@babel/core/lib/config/config-chain.js:120:22)
    at loadPrivatePartialConfig (/home/Pavel/script4j/modules/script4jfx.graphics/node_modules/@babel/core/lib/config/partial.js:85:55)

As far as getting Mocha to work with your base config file, dunno if above is sufficient or not.
If not...
Assuming somewhere, you're using something like this in "package.json".
"scripts": {
  "test": "mocha --register @babel/register"
}

Instead, I'd create a standalone registration file.
$ cd ${MODULES_DIR}
$ cat << EOF >> "registerbabel7.js"
require("@babel/register")({
  rootMode: "upward"
});
EOF
$

and use it instead (so Babel will search towards $MONOREPO for the "babel.config.js" file)...
"scripts": {
  "test": "mocha --register registerbabel7.js"
}

@plroebuck Thank you very much for your solution - require("@babel/register")({rootMode: "upward"}); + mocha --require registerbabel7.js - it seems to work.

How about this?
$ npx babel --root-mode upward ./tmp/script4jfx.graphics.spec.js

@plroebuck It works either. But I need babel only to run mocha tests. However, solving problem with mocha I still can't make babel compile file outside working folder (as I've said before this is a feature of babel 7). Could you take a look at the following question, maybe you can suggest something https://stackoverflow.com/questions/54695624/how-to-configure-babel-config-js-for-for-testing-modules-with-mocha

This is a completely valid question, especially with the advent of mono-repos.  I have been struggling with this for a while, and plroebuck's answer worked perfectly 🙏


Spec Tidy Suggestion: Don't Double Construct A

As written, the spec -may- double counstruct A:
It will be constructed first as part of Step 3.{e,f}; then if iteratorRecord is undefined, it's constructed again in Step 3.k.{iv,v}.
Probably that first construction could be sunk into 3.j.

I found this as well, while writing test262 tests. Here's a code snippet showing how it's observable from JS:
class MyArray {
  constructor(...args) {
    console.log('called with', args);
  }
}
await Array.fromAsync.call(MyArray, {
  length: 2,
  0: 1,
  1: 2
});

This logs:
called with
called with 2

My apologies for being absent from the discussion. This is a great catch, and #41 looks good to me (@michaelficarra).


Exhaustion not applying with failed death save in v1.2.0, worked in v1.1.0

Foundry v11.315
DND53 3.1.2
Module v1.2.0
Hey, thanks so much for adding the failed-death save option! I did some basic tests and it's working with v1.1.0, but I noticed that when I updated to v1.2.0 it stopped working.  The added con-save option appeared to still work. Here's a screenshot of the console error I see on v1.2.0 when I fail a death save:

That's interesting. what are you exact setting in the module?

Oh I see what I've done. I'll fix it up and send out a new release

Should be fixed, however I'll leave this open until I get home and thoroughly test it.

Reminder to thoroughly test this or close this issue


Organisation offerings shows no offerings

On the Organization offering page, even if i unselect the two filters that are set by default i do not see any offering from my organisation, on the admin Offering page i do see them, they are also created from the add new offering button on the screenshot below:

actually, the bug is that the buttons are shown
My Offerings is a bit complex thing, they represent "bulk purchases" done by organizations. I.e. organization can create resources from them - e.g. VMs in OpenStack Tenant - but they will not be billed to organization.
Thanks for reporting, it is some regression, at the moment we do not allow direct registration of such offerings, they are created in a workflow if specific offering supports it.

Ah i see, no problem :) just thought id report what i find hahaha : )


Fix cache deletion on Windows 1

Fixes #25752 via close-immediately-after-open

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build


adds stream attributes to streamEvent

Description
Updating stream attributes object of a stream, set its attributes to undefined instead.
This is because when creating the streamEvent Object, it doesn't pull the attrs from the spec property passed to it. Thus it gets set to undefined.

Already merged in #1038


[GPT-1] chore: update read me

Includes more information regarding

Folder structure
Key technologies used

Would be good to add some supplementary info on Tailwind and Alpine.js (just a few lines of summary)

Also add details on importing content from existing website.


refactor: github.com/alibaba-> github.com/dragonflyoss

Ⅰ. Describe what this PR did
github.com/alibaba-> github.com/dragonflyoss
Ⅱ. Does this pull request fix one issue?
NO
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
NO
Ⅳ. Describe how to verify it
go build ...
Ⅴ. Special notes for reviews

Thanks a lot for your work. This is exactly what we need. Just need some minor change there. @liuhengloveyou

I polish the commit logs and have merged this pull request via command line. merge commit

Why not merge it just on website? @lowzj
Is this because the multi commits?

@allencloud Not only multi commits, it's a little mess to see commit history by using git log --graph if we just merge pull request on website.
merge just on website

via command line


Add feature for creating default constructors and getter/setter methods

As of now I don't see any feature to create default constructors and getter/setter methods. This would be really helpful.

This is a feature that I already plan to add in the v2.0.0 (Developers/DevelopersNote.md). However, this would might take a really long time before v2.0.0 to be stable since I barely have time to add a new feature. On the other hand, bug fixes still the first priority that I would invest my time on.

Great to know that this is already planned. This feature would really make Java development faster on Sublime.


Passing values and context from Java to evaluate during runtime

We currently have a configuration language which allows to override default value for a given config key based on user passed context. As an example our config looks something like this:
button_color=blue
If (cityId == 5) button_color = red
If (cityId == 10) button_color = green
In the above example, default value for button_color is blue. But based on user context, which is cityId in this case, the value for button_color could be red or green depending on cityId. The user context is passed as input parameter which is determined during runtime in our Java application. How could w achieve the same using cue? I am very new to cue. I have seen this is possible by injecting values or using go apis fill() method. This capability of runtime evaluation based on user input/context to override is heavily used. So I would like to understand what are the options here? Any examples and usage would help. This will determine whether to take dependency on cue or not.thanks for your help in advance.

I see that you asked your question on Slack already, so I'm going to close this one as a duplicate for now. If you prefer to use GitHub for questions instead of Slack, feel free to use the Q&A category in the Discussions tab. Thanks!


Search SO libs in default path

Now, it is not necessary to add LD_PRELOAD or LD_LIBRARY_PATH before irohad binary.
It is enough to have the following structure:
.
|-- conf
|   |-- example.genesis.block
|   `-- example.iroha.conf
|-- iroha-cli
|-- irohad
`-- lib
    |-- libc.so.6
    |-- libcares.so.2
    |-- libcrypto.so.1.0.0
    |-- libdl.so.2
    |-- libed25519.so
    |-- libgcc_s.so.1
    |-- libgrpc++.so.1
    |-- libgrpc.so.3
    |-- libm.so.6
    |-- libpq.so.5
    |-- libprotobuf.so.13
    |-- libpthread.so.0
    |-- librt.so.1
    |-- libssl.so.1.0.0
    |-- libstdc++.so.6
    |-- libtbb.so.2
    |-- libuv.so.1
    `-- libz.so.1

Codecov Report

Merging #566 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #566   +/-   ##
=======================================
  Coverage     80.2%   80.2%
=======================================
  Files          310     310
  Lines        12276   12276
=======================================
  Hits          9846    9846
  Misses        2430    2430

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5fd9d...b77b20f. Read the comment docs.


Update Tinkerbell to latest version

Signed-off-by: Mateusz Gozdek<EMAIL_ADDRESS>

Hmm, that might still not work without updated Tinkerbell Terraform provider.

Hmm, that might still not work without updated Tinkerbell Terraform provider.


Pulsar - K8S : admin pod should use the broker service instead of proxy service to discover brokers

Motivation
Currently, the pulsar-admin pod uses the service provided in proxy.yml to discover broker pods and interact with them. Here is the part of the admin.yml script I am talking about :

    env:
     - name: webServiceUrl
       value: "http://proxy:8080/"
     - name: brokerServiceUrl
       value: "pulsar://proxy:6650/"
     - name: PULSAR_MEM
       value: "\"-Xms64m -Xmx128m\""

The first problem is that you need to deploy the proxy service (proxy.yml) in order to make your pulsar-admin pod work. If you don't, your pulsar-admin pod will not be able to locate broker pods and, for example, perform the tests showed in the kubernetes deployment docs.
The second problem is that you may not want to expose your brokers to the outside world (= the whole internet for some managed kubernetes cluster like the ones from Digital Ocean).
Proposed solution
The idea is to use the headless broker service defined in broker.yml to perform broker pods discovery. Replace the previous part of the admin.yml script with this one :

   env:
     # Use the broker headless service to discover broker pods
     - name: webServiceUrl
       value: "http://broker:8080/"
     - name: brokerServiceUrl
       value: "pulsar://broker:6650/"
     - name: PULSAR_MEM
       value: "\"-Xms64m -Xmx128m\""

This way, you can directly deploy the pulsar-admin pod after deploying the brokers and perform simple tests using the Pulsar Client CLI tool.
Testing coverage
The solution has been successfully tested on a fresh Digital Ocean K8S Cluster on which I deployed the zookeeper cluster, the bookies, the brokers and the admin pod (no monitoring stack yet).
The test consisted in producing messages at a 100 msg/s rate and consume them using the pulsar-perf command on the admin pod (as provided in the documentation).

@guillaume-braibant +1

Pull request : #4995


Specify hugr-cli extensions

@ss2165 :

Proposal:

Adopt the cargo subcommand model for hugr cli. Move validation and visualisation to builtin sub commands. If hugr-<subcommand> is in PATH hugr subcommand works. Extension subcommands are independent binaries.
Publish hugr-runllvm binary from hugr-llvm repo (or perhaps hugr-llvm with optional --run option, without it just outputs LLVM bitcode)
Guppy specific compilation passes can be added to hugr build builtin subcommand. Customisable as hugr build --passes "guppy_pre" "guppy_opt_2" "guppy_post", or something similar.
Guppy runner python package takes guppy module and strings together subprocess calls to hugr cli as appropriate. (edited)

Questions:

Does hugr do anything except delegate to subcommands?
The subcommands must control which extensions are used. This means every "leaf" downstream, which is where extensions are known, needs it's own subcommand.
Should hugr-cli provide helpers to parse + validate a hugr? What else?

Maybe the first two questions can answer each other? i.e. hugr main commands only job is attach extensions to hugrs before calling subcommands?

From @zrho in duplicate issue  #1311

Currently the hugr-cli binary can just validate hugrs. To allow for more tooling to be consolidated into the CLI tool, I propose we use subcommands (like cargo and git do). The current functionality can be moved to a validate subcommand, so that it would be run with hugr validate [...]. Clap has good support for this.

#1312 makes a start on this so closing. Follow up for binary extensibility in #1343 .


Feature request - return index of currently set layer

One thing I've wished for a long time is an on-desktop indication of what layer I'm on.  Some quick status message from the Keymapp API would be very helpful here. Keymapp seems to know the active layer.  Can I request this feature?

Hi @tcb678
Sure that makes sense, something like kontroll current-layer that would return whatever the current layer is ?

@fdidron That would be ideal.  Though for the maximalist, it would be good to just get a dump of the current state in a JSON object for easy parsing.  For instance, firmware version, layer, RGB animation mode, and any other interesting information that might be relevant.

Got it, I like the idea of having the whole state, what I'm thinking of is :
$ kontroll status
Kontroll version: v1.x.x
Keymap version: v1.3.2
No keyboard connected OR
Keyboard: Voyager
Firmware version: default/latest
Current layer: 0

With an optional --json param to dump as json.
Then we can add more info as Keymapp, the firmware and kontroll evolve.
This will require a new version of Keymapp to be released, I'm going to plan this.

This is pretty much coded, I need to release a new version of Keymapp to go along this. I have a release planned next week, I'll keep you posted.

This is released: https://github.com/zsa/kontroll/releases/tag/1.0.3
Make sure you update Keymapp to version 1.3.2.


Add support for Flink 1.19

Fixes #32646

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Failing test is broken at HEAD and doesn't touch Flink.

My intention is to follow this up with Flink 1.20 support as well, since I want to get us caught up with current. So then the whole "drop 1.15, 1.16, 1.17 support" issue needs some proper handling and not too rushed.

take a look and see if the dockerhub thing is low-hanging fruit or more difficult (maybe you already know?)

Unfortunately no. I'm not too much familiar with how we build the job server images, but I suppose, it should be only changing the image name and bundling Flink version into the tag. There are reference to "latest' though, which would be meaningless. We would likely have to stop pushing those and create tags like '1
19_dev', which would be pushed for every version as we do with 'latest' now. But that's all I have.

take a look and see if the dockerhub thing is low-hanging fruit or more difficult (maybe you already know?)

Unfortunately no. I'm not too much familiar with how we build the job server images, but I suppose, it should be only changing the image name and bundling Flink version into the tag. There are reference to "latest' though, which would be meaningless. We would likely have to stop pushing those and create tags like '1 19_dev', which would be pushed for every version as we do with 'latest' now. But that's all I have.

OK. I will think about this as a background task.
On the subject of the Flink versions, I do see that in the past we added one version and removed two all in the same Beam release. Since the Flink site themselves only even has the downloads for 1.18 and later, I think we can move quickly eliminating versions that are not longer supported by Flink. So I will do 1.15 and 1.16 now, and also add 1.20. I don't think I'll remove 1.17 until after 2.61.0 is released.


regression: Re-add railway logs --verbose

Need to add this flag back
CC @nebulatgs

https://github.com/railwayapp/cli/blob/e3bd751b88d95c71c03252cd94a2bc509e248753/main.go#L257

Closing for now as apparently the old CLI didn't have a verbose flag


travis: remove deprecated sudo keyword

Close #181.

Travis is happy now. The problem is the FL being fulled, tests pass in any case. Therefore setting the descriptor flag of STDOUT to 0, so travis does not catches that it got filled.
References:

https://github.com/travis-ci/travis-ci/issues/8982
https://github.com/astropy/astroquery/pull/1661
https://github.com/travis-ci/travis-ci/issues/8920
https://github.com/conda/conda/issues/6481

Closed in favor of #183


feat(2252): removed explicit pfe dependency on op-feedback

Closes

2252

Explain the feature/fix

Removed pfe dependency from using op-feedback

Does this PR introduce a breaking change
No
Screenshots

View Screenshots

Ready-for-merge Checklist

[x] Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
[x] Does the change have appropriate unit tests?
[x] Did tests pass?
[x] Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
[x] My changes generate no new warnings
[x] I have performed a self-review of my own code
[x] I have documented my code, particularly in areas like todo, complex logic, quick fix, temporary patch, etc.

If it is a new component

[x] Does your component follow One Platform style guidelines?
[x] Does your component web accessibility standards? Helper Doc
[x] Does your component support desktop screen sizes (350px, 720px, 1150px ,1920px)

Browsers you have tested in

[ ] Latest two versions of Mozilla Firefox and Google Chrome supported by Red Hat Enterprise Linux distribution
[x] Google Chrome [Latest 2 versions]
[x] Mozilla Firefox [Latest 2 versions]
[ ] Microsoft Edge [Latest 2 versions]
[ ] Apple Safari [Latest 2 versions]
[ ] Microsoft Internet Explorer 11

To reviewers. I have copied the pfe root global variables to host in web component because lit elements expects the variables to be in host rather than root. Then only it works on firefox.

@akhilmhdh does this remove the dependency with patternfly? if so can you add the same changes in the scaffolding as well?

@akhilmhdh can you also check the RH font??

@akhilmhdh can you check why the test is failing

@hybridx fixed


[FLINK-4613] [ml] Extend ALS to handle implicit feedback datasets

This extension of the ALS algorithm changes some parts of the code if implicitPrefs flag is set to true. Mainly the local parts parts are changed: the Xt * X computation takes into consideration the confidence, thus computing Xt * (C - I) * X instead (see the paper by Hu et al. for details). The Xt * X matrix is precomputed and broadcasted, and that is the only thing that affects distributed execution.
Note, that we use a temporary directory in the test, because there would not be enough memory segments to perform a hash join for prediction. I assume that memory segments are not freed up after the training if no temporary directory is set, but I did not investigate the issue as using a tempdir is a simple workaround.

@gaborhermann @jfeher Could you share results where you benchmarked the algorithm against other implementations, please?

We did not measure performance against Spark or other implementations yet. Those would reflect the performance of Flink ALS implementation, as there is not much difference between the implicit and explicit implementations.
Instead, we compared the implicit case with the explicit case in the Flink implementation on the same datasets, to make sure the implicit case does not decrease the performance significantly. (Of course, we expected the implicit case to be slower due to the extra precomputation and broadcasting of Xt * X.)
        expl  impl
100     8885   9196
1000    7879  11282
10000   8839   9220
100000  7102  10998
1000000 7543  10680

The numbers in the left column indicate the size of the training set (I'm not sure about the measure, but @jfeher can tell about it). The numbers are the training time in milliseconds in the explicit and implicit case respectively. We did the measurements on a small cluster of 3 nodes.
It seems, there is a large constant overhead, but it's not significantly slower in the implicit case.
We could do further, more thorough measurements if needed, but maybe that would be another issue. Benchmarking more and optimizing both the original ALS algorithm and the specific Xt * X computation in the implicit case could be a separate PR.
What are your thoughts on this?

Hello @gaborhermann thank you for your contribution!
Are the numbers here non-zero entries in a matrix?
If that is the case do you think it would be possible to test this on some larger scale datasets?
This would bring it closer to actual use cases someone using Flink might have.

Hi @thvasilo, thanks for reviewing my code.
You are right, @jfeher told me that the numbers in the left column indicate the number of non-zero elements in the rating matrix. We are actually planning to do experiments on a larger data set, but not right now.
Do you think it's important to do so before merging the PR? If so we'll do it ASAP.
Thanks for the suggestion, I marked the PR with the [ml] tag.

I did some minor changes according to user suggestions, and put it in a separate commit (Minor fixes in IALS), so you can see my fixes. Note that before merging I'd prefer to squash the commit with the previous one in order to have proper commits.

@gaborhermann I think have a larger scale test would boost our confidence in the implementation, and maybe point out some problems that do not manifest with small data, which is very common.
If you plan to do it anyway we might as well do it before merging the code, but it's not a blocker.

@gaborhermann @thvasilo I would definitely like to see a test on a larger dataset, that is actually what I was asking for when I mentioned "benchmark", maybe I was not clear then.

Okay, we're on it.
@thvasilo thanks for the dataset suggestion.

Hi, we have measured the training time of als and ials with the given dataset.
After filtering the data to unique item user pairs we got approximatly 64 million rankings.
We measured on a cluster with four nodes and on yarn. All of the nodes had 16 GB of memory.
The taskmanagers got 12 GB and the jobmanager got 2 GB.
We had four taskmanagers, one four each node.
After some testing it looked like a block number between 100 and 1500 is the most optimal.
And between 100 and 300 the running times were steadily low.
For ials we got the following measurments:
The average time for block numbers between 100 and 1500 and 1 iteration in seconds: 2000.33s
The average time for block numbers between 100 and 300 and 1 iteration in seconds: 1729.44s
More detailed results by block sizes on the diagram: http://imgur.com/LjJavti
For als with the same configurations we got the following measurments:
The average time for block numbers between 100 and 1500 and 1 iteration in seconds: 1694.04s
The average time for block numbers between 100 and 300 and 1 iteration in seconds: 1465.77s
So the ials version was 300 s slower on this data than the als.
When we increased the iteration number for 10 the time difference stayed under 1000 s which is less than ten times 300.
This is because the fix time cost for the whole training is big.

Thank you @jfeher!
Could you clarify what you mean by filtering the data to get unique item-user pairs? Is this because the iALS algorithm only supports binary interactions (i.e. number of interactions does not play a role)?
Any idea how these runtime numbers compare to alternative implementations (Spark, Cython)?

Thanks @jfeher for the measurements! :)
@thvasilo The filtering referred to having distinct (user,artist) pairs. It's only because the input of the iALS is a sparse matrix, and it would not make much sense to have more than one values for the same element of the matrix. E.g. to aggregate multiple listenings for the same (user,artist) pair, one could count them, and use the count as the implicit rating. We simply used the value 1.0 for every user-artist pair, but the algorithm works with any (positive) values, not only binary interactions.
We've only measured Flink against itself, as the main ALS algorithm is already in Flink. It would be interesting to measure against Spark and other solutions, but that might not reflect the performance of our iALS extension, but rather the performance of ALS itself. That seems to be another issue for me. Do I see this right?

Hello @gaborhermann,
Yes I think you are right in that respect, just wanted to note that we should perform some comparative benchmarks in the future.
So the benchmarks look good IMHO, we now need to address the couple of comments I had, namely splitting up the tests and deciphering why a java.Iterable was used in that spot if possible.
I was also wondering: For the expected results in the test, where did you get the reference data?

Hi @thvasilo,
Thanks for your thoughts! I agree we should perform a benchmark in the future. Furthermore, based on the results we could optimize the algorithm.
I split up the test, and rebased to the current master. I checked the java.Iterable again, and commented at your original concern. I am afraid we'll have to use the java.Iterable.
Regarding the expected results, I've only generated the small input data by hand. Before that I checked whether the Spark and Flink implementations converged to approximately same factor matrices (I only checked the value of the objective function, not the whole matrices). Because of the random initialization we cannot guarantee to have the same results, but there were 2-3 points that both Spark and Flink converged to.
There might be better methods for testing, but I considered this sufficient as the original ALSITSuite did nothing more. Of course, this test only checks whether the algorithm works the same way after some modifications (e.g. optimization), and does not check whether the algorithm initially works or not, but it's the same case with the original ALS. Do you know what is the assurance for the explicit ALS working good? (It must be good, as I also checked the results of the explicit ALS against Spark on toy-data.) AFAIK Spark generates random matrices of known rank, factorizes them, and checks whether the error is low (see their ALSSuite). In the future, it might be worth to follow their approach.

@gaborhermann Yup the approach taken by the Spark community for testing is closer to what we would like to have for non-deterministic algorithms, but what you have implemented now should suffice on the assumption that the ALS implementation is correct.
@tillrohrmann Initially implemented ALS so I'm not sure how he arrived at the expected results. It would be a good idea for the future to document how we generate test data so it's easy to replicate and validate the process. That should be enough for deterministic algorithms, and for non-deterministic we should have proxies like measuring the error of reconstruction etc.
I'll take a look at the code again now, and will add comments if I find something. Otherwise I hope @mbalassi can find some time to review and merge if no objections come up.

Okay. Thank you again @thvasilo for reviewing our code!

@thvasilo you're right in the future we should make sure that we properly document how we came up with the testing data.
What I've done to come up with the testing data for the ALSITSuite is to factorize the given recommendation matrix with Matlab with the given parameters (factors, iterations, etc). I've implemented ALS in Matlab for that. Ideally, we use a library for that so that others can reproduce the test results. I can share the ALS implementation if you like.
Ideally we do something similar for iALS.

@tillrohrmann thanks for clarifying!
Beside testing against Spark, I also did a small NumPy implementation, to make sure iALS works well. Although, I did not make efforts to imitate the initial random factor generation of Flink, so the results cannot be exactly the same. I am also happy to share that if needed.

For tests it would be good to fix the random seed at least. Otherwise we might not have stable tests depending on the seed.

I agree. I already fixed the seed at the ImplicitALSITSuite. At the ALSITSuite the seed is unset, but by default it's 0, that's why ALSITSuite is deterministic, so I don't think it's a problem. Although, I would reconsider setting the default seed, because that way two training for the same parameters yields the same result, and that might not be what do user expects. The user might expect truly randomized result.
Do you think we should modify the default optional seed Some(0L) to be None, and use the system random generator by default? Again, this is in the original algorithm. Should we do it in this PR or create another issue for refactoring ALS?

Yes I think you're right. We shouldn't fix the seed per default. I think you can include this change in this PR since it's a minor change.

Okay, I've made the seed optional. I also removed the generateRandomMatrix function as it wasn't used at all.

Thank you @thvasilo for your thorough review :)
@mbalassi I think this PR is ready to merge. Could you do a review when you have some time?

Yes @gaborhermann , I finally got here. 😄

Closing since flink-ml is effectively frozen.


Fully integrate missing modules

At the moment there is reference to cwica, callback and cwfees. They need to have every related message fully implemented. In addition to this cwerror and fee_grant need to be implemented (if needed).

Reviewed and the existing code should account for all of these


unassigned path will redirect to homepage/404; payment route should be protected

unassigned path

unprotected payment route

please assign @Varinder-Dhillon0

you can do the unassigned path one @Aastha1316


Apply ocp secrets to every namespace in tests

/kind user-story
/area testing
Acceptance Criteria

[ ] every random project created during test should have access to the secrets

@prietyc123 is this issue still relevant? In case this issue is still relevant, can you add more information in a comment.


⚠ Bofrost.lu has degraded performance

In ab779cd, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1146 ms

Resolved: Bofrost.lu performance has improved in 27fa089 after 10 minutes.


:fr: Add French Localization

Had a bit of time to spare. Have a nice day and keep up the good work 😉 🇫🇷
Signed-off-by: Guillaume Broder<EMAIL_ADDRESS>

Current coverage is 22.96% (diff: 100%)

Merging #22 into swift3.0 will not change coverage

@@           swift3.0        #22   diff @@
==========================================
  Files            55         55
  Lines          3235       3235
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            743        743
  Misses         2492       2492
  Partials          0          0

Powered by Codecov. Last update 09c1436...69d0c75

Thanks man! :+1:


Running Telpot on python2.6

Hi,
Is there any way by which i can run telepot on python2.6.
Thanks,

No, unfortunately. I am not prepared to go back in time to support 2.6.


observer(ticdc): add unit tests in observer module

What problem does this PR solve?

Issue Number: ref #8045
What is changed and how it works?

Add unit tests in observer module.
Add NewObserverOption in observer.

Check List
Tests

Unit test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/run-verify

/test ?

/label xxx

/merge

/merge

/run-all-tests

/merge

/run-engine-integration-test


Update notifications

There should be a notification or a system message when an update is available. If on a released version, then when a new version is available. On a master commit, it should show when more than 10 commits are added.

Do you mean #518 ?

This would still be a great idea

if implemented, it should be able to disable this with compile flag (for gitea instances deployed by package managers)

This can be closed.


tag, versioning?

This repository has no tags at all.  This makes it hard to establish the versioning scheme (the git hash is not a version).
Could it be tagged now, and again on each release?

Hello @jrmarino,
There's been no release of this project so far, so no tag nor branch. I believe there should be 24.0 and 24.1 release branches by the end of the year.

The ada language server list specific comments on several repositories for each release.  Ideally every one of those commits would be tagged.   It's been a packaging issue and I've been fudging the versions (treating most as patched 23.0.0) but in the case of adasat, I had to invent the version.
We're trying to help but Adacore's lack of tagging is making things extremely challenging.

see what I mean?  the ada language server has a release (e.g. 23.0.21) but the dependencies that it requires are not released.  At least they should have a tag that could be treated as a version for packagers.

Hello @jrmarino - we understand that the lack of versioning is a hassle. Our plan is to transition progressively all these dependencies to use Alire, hopefully this should help a lot.

b) Doesn't Alire still need versioning?

Exactly, which means the release manifests in the Alire index will link version number and commit id.

Please avoid this kind of comments, as it sounds disrespectful towards to work done by Alire contributors. As far as I can tell, you are the only person who expressed interest in Reprology, which understandably doesn't make it a high priority for the Alire project.

It would probable take 2 hours tops to generate an index periodically for repology to read, but nobody is putting any importance on it.

Given your knowledge and interest on the matter, you are probably the best candidate to make this happen.

Exactly, which means the release manifests in the Alire index will link version number and commit id.

If version numbers are created in the process, great.   But a commit id, while unique, cannot be compared to other commit id to determine which one is greater, so they can't serve as version numbers.

As far as I can tell, you are the only person who expressed interest in Reprology, which understandably doesn't make it a high priority for the Alire project.

Repology would be for the Alire project, not for me.  While the benefits to the project should be obvious, for some reason they are not.  This was not meant as an insult, just the truth.  The real projects are listed there.  so what does it mean if it isn't?  And it's not just perception.

Given your knowledge and interest on the matter, you are probably the best candidate to make this happen.

Fine.  Hand me the credentials to the database and the credentials to the webserver, one that has the authority to start cron jobs.


fix(oas-utils): added safe parsing to oauth example generation

This is a quick to the problem, long term solutions have been added to the canvas such as:

proper error handling
removing these oauthexamples

closes #3624

@hanspagel just added safety for now, but lets nail down our error strategy soon!


Oni Melee Overhaul

I've been told that Oni are rather weak and a shite pick in a game where most people have guns and have a rather large front and side profile that lends to them being rather easy targets. Especially when they can't actually shoot back due to their genetics. All right, I say. I'll overtune the Melee race into being a decent pick, and so I have.
To that end I've added following 'abilities' to Oni:

Their punches do real good damage and have a real low cooldown. (Firing a gun's still probably faster.)
The lower their health gets, the faster they get, until they're zooming all over the place. They're also quite faster than a base human, too. This is so they can actually close the distance between them and their opponents.
They're slightly smaller than their old size, but still larger than a human.

I think these changes'd make Oni a race people'll actually pick rather than simply ignore save for meme rounds where guns are scarce and melee is king.

'tis done my liege.

base oni faster than felinid

at least make felinid faster too so they arent just a weaker human lol

Why lol, I liked oni when they were big hulking brutes that used melee to their advantage. This is just making them a more powerful felinid atp. If people aren't playing onis right then that's on them.

good to merge once you fulfill MLG's requests

They've been fulfilled, my liege.

@MLGTASTICa

"Hmmm this race seems a bit weak, lets tweak it asthough it is a weapon" Buddy...

Why lol, I liked oni when they were big hulking brutes that used melee to their advantage. This is just making them a more powerful felinid atp. If people aren't playing onis right then that's on them.

Onis are dogshit because meelee is dogshit.  This is just making them a more powerful felinid atp. If people aren't playing onis right then that's on them.

Onis are dogshit because meelee is dogshit.

I agree with this sentiment personally
I believe the goal would be to make Oni 'the best' at melee, rather than the only viable way to play melee
In my opinion the increased speed when wounded is a great pick for buffing oni specifically, but the general minor movespeed buff would be better placed on onehanded melee weapons in general rather than relegated to one race

Ive decided that Oni in their current state do not really need a buff.


add purge_extract_dir option to Client

This uses a purge.manifest file to prevent accidental deletion of unrelated files...
Note: Perhaps this is too complicated? Should we simply rely on a namespaced extract_dir?
fixes #56

Again with the windows alias: C:\Users\runneradmin\... vs C:\Users\RUNNER~1\...
See https://github.com/dennisvang/tufup/pull/78#issuecomment-1706646830


RFC: Add paramter to process/next for frontend to warnings to ignore

Currently we ignore all warnings on process/next, but that means that some warnigns will never be seen and confirmed by the end user.
This adds an optional list that frontend can specify so that warnings that are not explicitly ignored is not ignored.
Related Issue(s)

#{issue number}

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@olemartinorg seems to prefer that we just ignore warnings when the validation system fails to present them to the user before hitting submit.


[CLI] Refactor the CLI result

Refactor the CLI result support output json to every command.
Currently, we support output json in some commands, such as account list. But we sometimes need to parse the command output, such as in the integration test(cmd.feature).

[x] #1895

May I handle this issue?

This is finished by adding the execute_serialized function to the CommandAction.
https://github.com/rooch-network/rooch/blob/2910febd4b9b6717e229a0bfe9b46e8bbe746b54/crates/rooch/src/cli_types.rs#L28-L40
If you have a better solution, you can promote a refactor suggestion. @feliciss


Make ECoG and sEEG size defaults more realistic

Reference issue
Fixes issue #12472
What does this implement/fix?
Makes a minor change to the ECoG and sEEG default electrode sizes in defaults.py so they are more realistic (2e-3 instead of 5e-3). This makes it so sEEG and ECoG electrodes do not overlap one another and better reflect the actual size of electrodes in real devices.
Additional information
The original size was 5e-3 and new size is 2e-3. This reflects a 2mm contact size, which is closer to the typical 0.8-2.5 mm contact sizes for ECoG and sEEG. This also means that electrodes with spacing <5mm (which is quite typical) will not overlap in the visualizations.

@alexrockhill ok for you?

@alexrockhill ok for you?

If not, I can also go back to implementation (2) in issue #12472 and just have it as an option to pass electrode size instead. Thanks for any thoughts you have!

both would work for me but maybe a better default is enough?

Message ID: @.***>

Looks like a good default size to me! Glad you're using this @libertyh!

@libertyh please add a new file doc/changes/devel/12474.bugfix.rst with a changelog entry. View other files in that folder for formatting/content inspiration. (I'm suggesting calling this a bugfix and not enhancement based on "unrealistically large to the point of visual overlap").

test failures are unrelated --- we're testing against pre-release of NumPy 2.0 which has some API changes, and a dependency (pandas) hasn't yet accomodated. So I'll go ahead and merge; thanks @libertyh!


broadcast update reason

Is there any way to make the broadcast show the update reason, like ark update or xxxxx mod update, have seen this with others and would be great

We used this for our server. 60% of the time, it works every time!
# Update warning messages
# Modify as desired, putting the %d replacement operator where the number belongs
#msgWarnUpdateMinutes="This ARK server will reboot for an update in %d minutes"
#msgWarnUpdateSeconds="This ARK server will reboot for an update in %d seconds"
#msgWarnRestartMinutes="This ARK server will restart in %d minutes"
#msgWarnRestartSeconds="This ARK server will restart in %d seconds"
#msgWarnShutdownMinutes="This ARK server will shutdown for maintenance in %d minutes"
#msgWarnShutdownSeconds="This ARK server will shutdown for maintenance in %d seconds"
msgWarnCancelled="Reboot cancelled by player request"

msgWarnReason="This ARK server will {reason} in {time}"
msgTimeMinutes="{minutes} minutes"
msgTimeSeconds="{seconds} seconds"
msgReasonUpdateApp="restart for an update to ARK"
msgReasonUpdateMod="restart for an update to mod(s): {modnamesupdated}"
msgReasonUpdateAppMod="restart for an update to the game and an update to mod(s): {modnamesupdated}"
msgReasonRestart="restart"
msgReasonShutdown="shutdown for maintenance"

Pretty sure @FezVrasta posted this in a previous post/issue. So far it has worked flawlessly, though as of writing this, we're having and update to nothing... not sure what that is... might be a conflict with my test-server and using staging-dir...


documentation error in FutureSignal?

https://dartsignals.dev/async/future/

By default the callback will be called once and the future will be cached unless a signal is read in the callback.

await s.future; // 0
count.value = 1;
await s.future; // 1

This would make a lot more sense if the bottom was // 0. As it stands, the documentation seems to be saying that dependencies makes no difference.

For this?
final count = signal(0);
final s = futureSignal(
    () async => count.value,
    dependencies: [count],
);
s.value; // state with count 0
count.value = 1; // resets the future
s.value; // state with count 1

The count value is directly related to s.

No, this
final count = signal(0);
final s = futureSignal(() async => count.value);

await s.future; // 0
count.value = 1;
await s.future; // 1

This is expected behavior! That resets the future callback

I can't tell whether the issue is resolved because the documentation wasn't sufficient for me to understand what the documentation was supposed to mean.
It's not clear what dependencies is for. The first example shows a signal already tracking count as a dependency without the use of dependencies.

Dependencies are a manual set of additional signals to track. It already tracks the ones listened to.
You need to add passion signals anytime you are reading a signal across an async/await gap because it is not longer sync and cannot auto track.


Add JAR plugin for easy installation

Closes #178.
Should automate the copying process I hope.
Most users are so-called "script kiddies" and need a guide just to install this.
JAR package process is as simple as cd java && mvn package & cd .. in command line.

A version bump to 2.0.0-beta-5 is necessary once this ships. Would a Maven test job be welcome in the CI?

Interesting idea, didn't think about using a plugin for installation. Will take a proper look at this when I get the time.

Update - I found a way to extract them off the JAR directly :) very hyped for this!

Ready for QA and ship!

Theres a lot of merge commit noise I notice, and I do recommend that this pull blocks the others to prevent more!

Appreciate the work on this. Will setup an action for it.


SSH invalid connections DDoS attack

Hi! I just discovered the CrowdSec project today. How difficult would it be to handle logs like these:
Dec  1 18:59:33 hostname sshd[1189573]: banner exchange: Connection from <IP_ADDRESS> port 34388: invalid format
Dec  1 18:59:33 hostname sshd[1189575]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:33 hostname sshd[1189575]: banner exchange: Connection from <IP_ADDRESS> port 44105: invalid format
Dec  1 18:59:33 hostname sshd[1189580]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:33 hostname sshd[1189580]: banner exchange: Connection from <IP_ADDRESS> port 45164: invalid format
Dec  1 18:59:33 hostname sshd[1189581]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:33 hostname sshd[1189581]: banner exchange: Connection from <IP_ADDRESS> port 37374: invalid format
Dec  1 18:59:33 hostname sshd[1189582]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:33 hostname sshd[1189582]: banner exchange: Connection from <IP_ADDRESS> port 44400: invalid format
Dec  1 18:59:33 hostname sshd[1189578]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:33 hostname sshd[1189578]: banner exchange: Connection from <IP_ADDRESS> port 54840: invalid format
Dec  1 18:59:33 hostname sshd[1189583]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:33 hostname sshd[1189583]: banner exchange: Connection from <IP_ADDRESS> port 58531: invalid format
Dec  1 18:59:33 hostname sshd[1189585]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:33 hostname sshd[1189585]: banner exchange: Connection from <IP_ADDRESS> port 43044: invalid format
Dec  1 18:59:34 hostname sshd[1189589]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:34 hostname sshd[1189589]: banner exchange: Connection from <IP_ADDRESS> port 59435: invalid format
Dec  1 18:59:34 hostname sshd[1189584]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:34 hostname sshd[1189584]: banner exchange: Connection from <IP_ADDRESS> port 32881: invalid format
Dec  1 18:59:34 hostname sshd[1189586]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:34 hostname sshd[1189586]: banner exchange: Connection from <IP_ADDRESS> port 38587: invalid format
Dec  1 18:59:34 hostname sshd[1189588]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:34 hostname sshd[1189588]: banner exchange: Connection from <IP_ADDRESS> port 46876: invalid format
Dec  1 18:59:34 hostname sshd[1189587]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:34 hostname sshd[1189587]: banner exchange: Connection from <IP_ADDRESS> port 60945: invalid format
Dec  1 18:59:34 hostname sshd[1189590]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:34 hostname sshd[1189590]: banner exchange: Connection from <IP_ADDRESS> port 41351: invalid format
Dec  1 18:59:34 hostname sshd[1189591]: error: kex_exchange_identification: banner line too long
Dec  1 18:59:34 hostname sshd[1189591]: banner exchange: Connection from <IP_ADDRESS> port 47642: invalid format

The IP is on a separate line to "error: kex_exchange_identification: banner line too long", but they're both logged from the same PID (eg. 1189580).
I suspect the connections are just flooding SSH with random junk.
fail2ban handles some kex_exchange_identification errors out of the box with their ddos preset: https://github.com/fail2ban/fail2ban/blob/02525d7b6f96c2841c24c4dbfcfe14e4a3d1ef63/config/filter.d/sshd.conf#L74 but unfortunately not the one I'm seeing, and I haven't been able to get it working as a fail2ban regex, so I'm looking at alternatives to fail2ban. It would be ideal to have something that handles all the SSH DDoS patterns that fail2ban has :)

Hello,
It would be rather trivial to deal with the Dec  1 18:59:33 hostname sshd[1189573]: banner exchange: Connection from <IP_ADDRESS> port 34388: invalid format. However, crowdsec doesn't yet support multi-line parsers, and you would be able to specifically react to an IP triggering the error: kex_exchange_identification: banner line too long.

I have added a PR to help with that : https://github.com/crowdsecurity/hub/pull/294
However, please beware that it's only going to ban the IP if they do several attempts (it will be detected as a normal bruteforce attempt, so more than 5). If you want to ban on first attempt, it would be a custom scenario on the side, but I would be too afraid of false positives to add it to the generic collection.


UI: Some labels cannot be obtained in Links.

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[X] I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?
In the markdown title & description issue workflows.argoproj.io/name and others are enabled, but setting ${metadata.labels.workflows.argoproj.io/name} will set them to null.
For example, add the following settings.
- name: Datadog
  scope: workflow
  url: https://app.datadoghq.com/dashboard/q5s-6jz-xyr?tpl_var_environment[0]=production&tpl_var_workflow_name[0]=${metadata.labels.workflows.argoproj.io/name}

https://app.datadoghq.com/dashboard/q5s-6jz-xyr?fromUser=false&refresh_mode=sliding&tpl_var_environment[0]=production&tpl_var_workflow_name[0]=null&view=spans&from_ts=1721613850051&to_ts=1721786650051&live=true

This datadog dashboard is only visible to us, but you can see that the retrieval is failing.
Version(s)
v3.5.8
Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
#
metadata:
  name: fantastic-tiger
  namespace: default
  labels:
    example: 'true'
    workflows.argoproj.io/name: fantastic-tiger
spec:
  arguments:
    parameters:
      - name: message
        value: hello argo
  entrypoint: argosay
  templates:
    - name: argosay
      inputs:
        parameters:
          - name: message
            value: '{{workflow.parameters.message}}'
      container:
        name: main
        image: argoproj/argosay:v2
        command:
          - /argosay
        args:
          - echo
          - '{{inputs.parameters.message}}'
  ttlStrategy:
    secondsAfterCompletion: 300
  podGC:
    strategy: OnPodCompletion

Logs from the workflow controller
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container
kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

In the markdown title & description issue workflows.argoproj.io/name and others are enabled

To clarify, those are annotations (not labels) and they predate the markdown feature: #6529, #9805
This is also a duplicate of #11741

It seems that they just didn't find the previous issues well.
Thanks.


zstd: Add my GitHub ID

Follow up on https://github.com/bazelbuild/bazel-central-registry/pull/1730#discussion_r1552125173

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (zstd) have been updated in this PR. Please review the changes.


JSONHTTPCLIENT DEPRECATED IN LATEST RELEASE

JSONHTTPClient is deprecated in your latest release.
POSTJSONFROMURLWITHSTRING also deprecated. Please tell me what to do. URGENT!

All JSONModel networking has been deprecated since v1.3.0 back in July.
Consider using NSURLSession or another library like AFNetworking instead.


undo doesn't remember cursor position/selections

It seems pretty common that if you undo past a selection edit it restores the selection.  XiEditor doesn't seem to do that.
Steps to reproduce:

Select a block of text
Delete
Undo

Expected:
Deleted text re-appears selected
Actual:
Deleted text re-appears but not selected.  In fact cursor position doesn't change ever on undo.

I think this is the same as #326. It's not simple because undo is done in the CRDT, and selection is not stored in the CRDT, but it could be. One thing to keep in mind is that there will be multiple views to the same buffer, and each view has its own selection.

You're right.  That is a dupe.  As for the multiple views, I'm not sure you need to track each selection/caret move.  Since undo/redo is a modification, on undo/redo you'd change the caret/selection for all views & just make sure the scroll point isn't changed.  At least that's how Xcode, IntelliJ & VS code generally seem to work.

I don't think this is a duplicate of #326. This issue is about extending the functionality of the existing undo command whereas #326 is about implementing a new soft undo command.

@eyelash 👍


Add inspector for supercapacitor.

I have a problem with matplotlib so I can't run any tests... I will use the PR to run the tests, so don't merge this.

Somewhere in your test please pass an equivalent circuit to the inspector and make sure in throws the appropriate exception.

Current coverage is 93.35% (diff: 80.00%)

Merging #242 into master will decrease coverage by 0.06%

@@             master       #242   diff @@
==========================================
  Files            72         72
  Lines          4999       5014    +15
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           4670       4681    +11
- Misses          329        333     +4
  Partials          0          0

Diff Coverage
File Path

••••••     66%
...on/source/wrappers/energy_storage_device_wrappers.cc

•••••••••• 100%
python/test/test_energy_storage_device_wrappers.py

•••••••••• 100%
...thon/source/wrappers/export_energy_storage_device.cc

Powered by Codecov. Last update d4bf68d...8a16cf7

OK this is ready for review.

You should check that the docker compose works for you.

Ready for re-review.

Done


Upgrades

Hey Gaurav,
In this PR I’ve updates many things mostly around the development/build processes.  Let me take a moment to explain them.
I upgraded all node pages to their latest versions.  Gives latest features and security updates.
I added eslint to the project.  I’ve been using eslint for the last couple of years and it makes things really nice to develop with because you can define rules so that code style stays the same across multiple developers.  I’ve integrated it with webpack to help find bugs at compile time.  I created rules based on your current coding style.
I’ve updated the react-sidenav package along with the demo site to use es6 standards and have babel trans-piling them down to es5, which you had in there before, it’s just updated.  Along with that update I’ve condensed several places in the code and made some class method calls more efficient.
I updated babel and put it’s configuration inside of the package.json
I added a .nvmrc file.  This allows you to have multiple versions of node installed on your system.  I have my current system setup so that when I change into a project directory with a .nvmrc file it will automatically change to that version of node.
I updated the config for webpack and added in the webpack-dev-server.  This update allows you to start a local dev server and run it on localhost:9000 in your browser by default.  This will also auto reload upon changes being save.  This will help with development speed and efficiency.  Localhost:9000 runs the demo project in the browser so any changes/updates can be seen real-time.  I also added map files which allows you do debug in the browser’s console (set breakpoints, inspect function calls, etc).  You can also build the project to see the contents of the dist/ directory.
With the update to webpack and that build process I also updated the publish functionality.  So that it only includes the files needed for the module.
One thing I’m not sure how you want to handle is the demo site from github.  How I’ve done that in the past is I had a separate branch for a github page where I had dist/ directory checked in so that I could publish to github pages branch and the dist/ in the master branch wouldn’t be checked in.  You don’t want to include your build directories into master because it makes your repo really big/bloated.  I see that you have a github page setup already, I’m assuming you have that setup off the master branch?
Let me know if you have any questions, concerns or suggestions.  One thing to mention is I didn’t change any of the functionality or styling of the side-nav itself.  Just the build/deploy processes and package updates.
Seth

Hi @ironLink21,
It's been a long time, I completely forgot about this PR. I really owe an apology and thank you so much for the work you have done.
Coming back to the library I've upgraded the react and completely changed the build setup using rollup. Closing this PR as in favour of new changes.
Thanks again for your contribution.


GPT3GF Not Defined

This looks cool, but when I installed Gen and GenGPT3 and ran your script, I got the above error:
using Gen, GenGPT3
ENV["OPENAI_API_KEY"]="<my key>";
# Construct GPT3GenerativeFunction
gpt3 = GPT3GF(model="text-davinci-002", max_tokens=256)
UndefVarError: GPT3GF not defined

Stacktrace:
 [1] getproperty(x::Module, f::Symbol)
   @ Base ./Base.jl:31
 [2] top-level scope
   @ Untitled-4.ipynb:2

I must be missing something
Thanks for any help.
Update.  It may not have installed properly.    I restarted Julia, then
julia> using Gen, GenGPT3

[ Info: Precompiling GenGPT3 [bf5e1513-8b89-42fc-a2bc-387c809df403]
ERROR: LoadError: SystemError: opening file "artifacts/vocab.json": No such file or directory
Stacktrace...

I guess it is still 'work in progress'.

Sorry just noticed this! This issue should be fixed now.


Refresh view

I'm trying to refresh the view based on changes to the calendar data by another app.  I'm hooking the event store like so:
[[NSNotificationCenter defaultCenter] addObserver:self
                                         selector:@selector(refreshCalendar:)
                                             name:EKEventStoreChangedNotification
                                           object:[self.calMgr getEventStore]];

The problem is, I'm not sure how to refresh the view.  I've tried various things but there doesn't seem to be 1 call that I can use to refresh the view controllers REGARDLESS of the view type I'm using at this point (Week, Month, Year).
Is there a call that will reload the data and views?

I use [self.dayPlannerView reloadAllEvents]; in my controller (which inherits from MGCDayPlannerViewController)


1.9.x AssertionError: ('pywin32', 'Unknown')

Nuitka crashes on Windows assuming it's a linux package ?
<?xml version='1.0' encoding='utf8'?>
<nuitka-compilation-report nuitka_version="1.9.1" nuitka_commercial_version="not installed" completion="exception">
  <exception exception_type="AssertionError" exception_value="('pywin32', 'Unknown')">
Traceback (most recent call last):
  File "C:\Users\abdelouahab\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\MainControl.py", line 1116, in main
    _main()
  File "C:\Users\abdelouahab\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\MainControl.py", line 1008, in _main
    detectUsedDLLs(
  File "C:\Users\abdelouahab\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\freezer\Standalone.py", line 335, in detectUsedDLLs
    _detectUsedDLLs(
  File "C:\Users\abdelouahab\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\freezer\Standalone.py", line 282, in _detectUsedDLLs
    allow_outside_dependencies = Plugins.decideAllowOutsideDependencies(
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\abdelouahab\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\plugins\Plugins.py", line 1391, in decideAllowOutsideDependencies
    value = plugin.decideAllowOutsideDependencies(module_name)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\abdelouahab\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\plugins\standard\DllFilesPlugin.py", line 418, in decideAllowOutsideDependencies
    if not isDistributionSystemPackage(getDistributionName(distribution)):
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\abdelouahab\AppData\Local\Programs\Python\Python311\Lib\site-packages\nuitka\utils\Distributions.py", line 266, in isDistributionSystemPackage
    assert isLinux(), (
AssertionError: ('pywin32', 'Unknown')

Latest 1.8.6 works fine, only crashes with 1.9.0 and 1.9.1

In the template, I have made it clear, that not filling out the issue template is not acceptable. I am closing this kind of report as invalid. The main reason is that I do not want to be left guessing. For you it's easy to erase the issue template and expect me to ask you questions only as necessary, but I cannot do that. I would much rather wait for you to create a new report, fill out the template, or wait for somebody with the necessary skill to do it.
In short: No issue template, no fun. Therefore I am likely just deleting the issue, as it serves as a bad example and detraction for searches.  And even worse, it might keep good reporters from reporting as is this "already known."


Auto-accept challenges from challenge target

Context: https://www.smogon.com/forums/threads/fixing-simultaneous-challenges.3653287/
I don't think this precludes us from also improving the UI, but defense in depth is never a bad thing.
[09:51] Zarel: we might also want to think more about this, to see if we can think of better solutions
[09:51] Zarel: simultaneously displaying a challenge box and a being-challenged screen would help
[09:52] Zarel: so when you saw you were being challenged, you would stop challenging your opponent

I have a feeling this will create complaints such as "challenged with the wrong team and it auto-accepted before I could cancel".
Personally, I would have just sent the 2nd challenger an error popup saying X is already challenging you to a Y game.

I have a feeling this will create complaints such as "challenged with the wrong team and it auto-accepted before I could cancel".

This is always a risk with any 'cancel' mechanism - there's no guarantee your opponent wont make a decision before you decide to cancel

Personally, I would have just sent the 2nd challenger an error popup saying X is already challenging you to a Y game.

This is also an option. Feel free to change L222-L224 where we accept the challenge and instead return a popup. The tradeoff is then you force the player to navigate through their teams and find the exact same team they just issued the challenge with before accepting. Both options have tradeoffs.


Add Philips Hue eventstream

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (4c033b8) to head (9936487).

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #18    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           29        29
  Lines         1041      1180   +139
==========================================
+ Hits          1041      1180   +139

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Segmentation CPP generate annotations

Implemented getting contour from segmentation
In order to do this I suggest a small rewrite from postprocessing.
Current implementation has some duplication and it does not allow soft prediction to be returned when the soft_threshold with blurring is disabled (soft_threshold = inf || blur_strength = -1).
Secondly I fixed a couple of issues with row/minor major and enable the segmentation test in ModelParameterize tests.

Thank you very much for the review. The main reason for the changes is that we want as much preprocessing to be done inside model_api. My goal is to be able to easily include it inside our mediapipe. Whilst it is relatively easy to implement these changes as a separate calculator I believe this is useful as a general solution.
I can imagine that you'd want this behind a configuration to save performance. But I'll leave that up to you.

Thank you very much for the review. The main reason for the changes is that we want as much preprocessing to be done inside model_api. My goal is to be able to easily include it inside our mediapipe. Whilst it is relatively easy to implement these changes as a separate calculator I believe this is useful as a general solution.
I can imagine that you'd want this behind a configuration to save performance. But I'll leave that up to you.

How about having create_annotation_from_segmentation_map() as a stand alone function. So model wrapper produces outputs without contours, but if someone needs them, they can call create_annotation_from_segmentation_map() on the model output?

There are 6 hidden conversations which you didn't react anyhow to

There are 6 hidden conversations which you didn't react anyhow to

I agreed and applied the feedback.

Some of the conversions hidden by GitHub UI are still applicable. For example https://github.com/openvinotoolkit/model_api/pull/57#discussion_r1189979625

Well that was a messy PR. Sorry, there was quite a lot to figure out and learn. Thank you for the patience.

FYI https://github.com/openvinotoolkit/model_api/pull/67#issuecomment-1570481771

https://github.com/openvinotoolkit/model_api/pull/72 is merged. Please, resolve merge conflicts.

What is applicable?

I added the throw error when soft_prediction only has one layer.
I however left the usage of hard_prediction in get_contours. Using only soft prediction is possible, but it would generally mean creating the hard_prediction again. It makes more sense to use the already calculated version.


Ensure mongodb uri for replica sets work

We currently support <IP_ADDRESS>/db,<IP_ADDRESS> but I need to make sure mongodb://<IP_ADDRESS>,<IP_ADDRESS>/db works

I'm in the process of adding connection error checking (#24). When I do so I notice that the replicaset connection tests fail with error Error: Could not locate any valid servers in initial seed list. Both array and string versions fail.
Looking at Mongoskin's README it looks like you actually have to use the native lib's objects when defining a replica set:
var Server = mongo.Server;
var Db = mongo.Db;

var replSet = new ReplSetServers([
        new Server('localhost', 30000),
        new Server('localhost', 30001),
        new Server('localhost', 30002),
]);

var db = new Db('integration_test_', replSet, {w:0, native_parser: (process.env['TEST_NATIVE'] != null)});

Do we need to update monk with this then?

Actually that is't the problem - it works with a real replica set. The test fails because the servers specified in the test code aren't setup for replication.

Another point I've realised is that a lot of the tests don't explicitly close db connections once done. And this also makes me wonder why connecting to a db isn't made to return a promise. Wouldn't it be nice to have that work the same as the rest of monk?

Agreed
On Tue Jan 06 2015 at 1:49:14 AM Ramesh Nair<EMAIL_ADDRESS>wrote:

Another point I've realised is that a lot of the tests don't explicitly
close db connections once done. And this also makes me wonder why
connecting to a db isn't made to return a promise. Wouldn't it be nice to
have that work the same as the rest of monk?
—
Reply to this email directly or view it on GitHub
https://github.com/Automattic/monk/issues/19#issuecomment-68845610.


fix(notion GC): dont reprocess DBs we already have

Description
Due to this bug, databases were always upserted during GC runs.
Prior to structured data, this was a minor issue as we were not actually upserting anything. Now, it's a much bigger issue because we:

upsert the structured data to Tables
upsert the structured data to Documents

This causes the upserts to increase quite a bit.
Risk

Deploy Plan

CPU :money_with_wings:


Testing parallel blocks

Hey,
I'm trying to test a pipeline with parallel stages, e.g.
parallel: 'lint' { // ... }, 'unit tests' { //... }
In the mocked invocations, I can see the mock for parallel -
getPipelineMock("parallel").call(['lint':pythonApiPipeline$_call_closure1$_closure5@5f254608, 'Unit tests':pythonApiPipeline$_call_closure1$_closure6@2eeb0f9b)
But I cannot figure how to make the test actually perform the closures, as right now it skips them.
Any help would be appreciated.

jenkins-spock doesn't do this for you.
You would need to stub the parallel step, and iterate through its input map's keys, evaluating each one whose value was a closure, something like (probably pseudocode):
setup:
    getPipelineMock("parallel")(_as Map) >> { _args ->
        _args.each { _key, _value ->
            if( _value instanceof Closure ) {
                _value()
            }
        }
    }
}

I think it's defensible to argue that jenkins-spock should do this for you. jenkins-spock does do this for whenever a Mock object's final argument is a Closure (which is indicative of the Jenkins pipeline DSL syntactic sugar for "passing a body block to a step that takes one).
That code is here: https://github.com/homeaway/jenkins-spock/blob/master/src/main/groovy/com/homeaway/devtools/jenkins/testing/JenkinsPipelineSpecification.groovy#L515-L520
In the short-term, you can try to turn the above pseudocode into real code and include it in the setup: of all your tests.
In the mid- to long-term, you could send a PR to jenkins-spock to add this functionality, or wait on us to get around to it.
In either case,
would you please create a new, dedicated feature-request issue for jenkins-spock asking for the parallel step's closures to be executed automatically? Please use the "feature request" issue template.

The pseudo-code from @awittha can be called this way :
mockDSL.parallel(_) >> { _args ->
            _args.each { Map _args2 ->
                _args2.each { _key, _value ->
                    if( _value instanceof Closure ) {
                        _value()
                    }
                }
            }
        }

Or however you're mocking your stages


[MB-15791] add initial sit destination address column

Jira ticket
Summary
This PR includes a migration to add the new sit_destination_original_address_id column to the mto_service_items table along with a reference to the address table where the actual value will be stored similar to the sit_destination_final_address_id column.
Verification Steps for the Author
These are to be checked by the author.

[x] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Run make db_dev_migrate
Check the mto_service_items table with your favorite db software and you should see the the column now exists 🎉
You can also run make server_test to verify all tests still pass

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots
How it appears in Postico:

Messages

:book:
:link: MB-15791

  Generated by :no_entry_sign: dangerJS against bacead58fd1c0cf44cb6aba0b22a90611e3669b9


Enable even larger images with one simple torch.nn.functional.silu import

Fixes:
File "stable-diffusion/ldm/modules/diffusionmodules/model.py", line 37, in nonlinearity
return x*torch.sigmoid(x)
RuntimeError: CUDA out of memory. Tried to allocate 1.56 GiB [..]
Now up to 1536x1280 is possible on 8GB VRAM.
Also remove unused SiLU class.
silu is x * torch.sigmoid(x) is the swish function
https://pytorch.org/docs/stable/generated/torch.nn.functional.silu.html

Just cuda or mps too?

VRAM error only happens on cuda. On mps there might be a small speed benefit, but it only happens once at the end of generation.


Fixed the WordPress link

[X] Have you followed the contributing guidelines?
[X] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

The WordPress link was bad.
- [WordPress] (https://github.com/WordPress)
+ [WordPress](https://github.com/WordPress)

🍴


Vimeo - Unable to extract info section (caused by RegexNotFoundError)

With command: youtube-dl --verbose https://vimeo.com/156448904 on OS X
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'https://vimeo.com/156448904']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Git HEAD: 80dbeba
[debug] Python version 2.7.10 - Darwin-15.3.0-x86_64-i386-64bit
[debug] exe versions: avconv 11.4, avprobe 11.4, ffmpeg 2.8, ffprobe 2.8, rtmpdump 2.4
[debug] Proxy map: {}
[vimeo] 156448904: Downloading webpage
[vimeo] 156448904: Extracting information
ERROR: Unable to extract info section (caused by RegexNotFoundError(u'Unable to extract \x1b[0;34minfo section\x1b[0m; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/youtube_dl/extractor/vimeo.py", line 263, in _real_extract
    flags=re.DOTALL)
  File "/usr/local/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 484, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract info section; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 554, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 242, in extract
    return self._real_extract(url)
  File "/usr/local/lib/python2.7/site-packages/youtube_dl/extractor/vimeo.py", line 274, in _real_extract
    cause=e)
ExtractorError: Unable to extract info section (caused by RegexNotFoundError(u'Unable to extract \x1b[0;34minfo section\x1b[0m; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Seems to work on version from master (2016.02.22)

You are using an outdated version of youtube-dl. Read our FAQ if you have troubles updating.


Only way to enable automatic deploys is to delete production?

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d2ihfergif0nj1
Region
us-north-1
Amplify Hosting feature
Backend builds
Describe the bug
We have previously set up a manual deploy to production, mainly using Amplify publish.
Now we want to deploy from Github. But pressing "Reconnecting repository" only causes the below button to spin.

And attempting to use the command aws amplify update-app --app-id APP_ID_HERE --repository REPOSITORY_URL --access-token ACCESS_TOKEN yields the error "An error occurred (BadRequestException) when calling the UpdateApp operation: Cannot connect your app to repository while manually deployed branch still exists. Please delete all branches and try again.".
And pressing "disconnect branch" here

Tells us that this will delete the associated hosted app, which is our production environment.
Is the only solution to set up CI/CD in Amplify to tear down our production environment?
Expected behavior
Able to connect repository and enable auto deploys.
Reproduction steps
See description
Build Settings
No response
Additional information
No response

Hi @PederAaby 👋🏽 thanks for raising this issue. There currently isn't a way to convert a manually deployed app to CI/CD. What you can do instead is create a new app that uses your repository and connect that app to the backend environment associated with your manually deployed app.
Here is a guide for connecting an app to a backend environment in another app: Edit an existing frontend to point to a different backend


Indexer INX plugin

2.0 compatible indexer including AccountOutput and DelegationOutput available here https://github.com/iotaledger/inx-indexer/tree/feat/iota-core


Fix comment error

Fix some comment error in schema-edges.md.

Thanks for the contribution @hantmac!


Prevent docker scripts to spawn yet another process

The exec replaces the current process with the new process, so we don't have yet another process running in the process tree.

Makes sense!  Thanks!!


Empty collection responses should produce empty collection object

This PR goes through 3 points:

If the program asks about a collection, it should get a collection even
being empty.
In case of an empty hash, implies an empty object, so makes sense to
still return nil for this case.
In case of nil as response from the Query object, does not make sense to
treat this as an expected case, so it will be treated as unexpected
response.

@acadavid can you review please?