Uncaught TypeError: Parameter "url" must be a string, not undefined

Steps to reproduce:

Open any webpage with links which are of blank type
Click any of blank links
Watch out the newly opened tab, it misses the address bar view + its height is trimmed + raising the exception below

OR

Open any web pages with links
Try to open any link in new tab
Watch out the newly opened tab, it misses the address bar view + its height is trimmed + raising the exception below

Atom Version: 1.12.9
Electron Version: 1.3.13
System: Mac OS X 10.12.1
Thrown From: atom-webbrowser package, v2.1.4
Stack Trace
Uncaught TypeError: Parameter "url" must be a string, not undefined
At url.js:87

TypeError: Parameter "url" must be a string, not undefined
    at Url.parse (url.js:87:11)
    at Object.urlParse [as parse] (url.js:81:5)
    at Page.module.exports.Page.update (/Users/mabdurrahman/.atom/packages/atom-webbrowser/lib/page.coffee:54:29)
    at Page.module.exports.Page.locationChanged (/Users/mabdurrahman/.atom/packages/atom-webbrowser/lib/page.coffee:39:6)
    at webview.<anonymous> (/Users/mabdurrahman/.atom/packages/atom-webbrowser/lib/page-view.coffee:32:18)
    at webview.dispatch (/Users/mabdurrahman/.atom/packages/atom-webbrowser/node_modules/jquery/dist/jquery.js:4435:9)
    at webview.elemData.handle (/Users/mabdurrahman/.atom/packages/atom-webbrowser/node_modules/jquery/dist/jquery.js:4121:28)
    at WebViewImpl.dispatchEvent (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/web-view/web-view.js:192:29)
    at dispatchEvent (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/web-view/guest-view-internal.js:57:11)
    at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/web-view/guest-view-internal.js:66:7)
    at emitTwo (events.js:106:13)
    at EventEmitter.emit (events.js:191:7)

Commands
     -0:50.3.0 application:new-file (div.panels)
     -0:44.1.0 browser-plus:open (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "telemetryConsent": "limited"
  }
}

Installed Packages
# User
atom-beautify, v0.29.16 (inactive)
atom-typescript, v10.1.13 (inactive)
atom-webbrowser, v2.1.4 (active)
browser-plus, v0.0.87 (active)
browser-plus-open-new-window, v0.0.1 (active)
browser-plus-zoom, v0.0.2 (active)
custom-title, v1.0.1 (active)
open-recent, v5.0.0 (active)
Sublime-Style-Column-Selection, v1.7.2 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.45.0 (inactive)
base16-tomorrow-dark-theme, v1.3.0 (inactive)
base16-tomorrow-light-theme, v1.3.0 (inactive)
one-dark-ui, v1.6.2 (active)
one-light-ui, v1.6.2 (inactive)
one-dark-syntax, v1.5.0 (active)
one-light-syntax, v1.5.0 (inactive)
solarized-dark-syntax, v1.0.5 (inactive)
solarized-light-syntax, v1.0.5 (inactive)
about, v1.7.0 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.13.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.4 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.2 (active)
command-palette, v0.39.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.202.2 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.158.8 (active)
metrics, v1.1.2 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.1 (inactive)
settings-view, v0.243.1 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.4 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.2 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.210.0 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.54.0 (active)
language-clojure, v0.22.1 (active)
language-coffee-script, v0.48.0 (active)
language-csharp, v0.13.0 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.47.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (active)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.0 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (active)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages

[Enter steps to reproduce:]

once the URL has changed, it will report this error.

Atom: 1.18.0 x64
Electron: 1.3.15
OS: Unknown Windows version
Thrown From: atom-webbrowser package 2.1.4
Stack Trace
Uncaught TypeError: Parameter "url" must be a string, not undefined
At url.js:87

TypeError: Parameter "url" must be a string, not undefined
    at Url.parse (url.js:87:11)
    at Object.urlParse [as parse] (url.js:81:5)
    at Page.module.exports.Page.update (/packages/atom-webbrowser/lib/page.coffee:54:29)
    at Page.module.exports.Page.locationChanged (/packages/atom-webbrowser/lib/page.coffee:39:6)
    at /packages/atom-webbrowser/lib/page-view.coffee:32:18)
    at webview.dispatch (/packages/git-plus/node_modules/jquery/dist/jquery.js:4435:9)
    at webview.elemData.handle (/packages/git-plus/node_modules/jquery/dist/jquery.js:4121:28)
    at WebViewImpl.dispatchEvent (~/AppData/Local/atom/app-1.18.0/resources/electron.asar/renderer/web-view/web-view.js:192:29)
    at dispatchEvent (~/AppData/Local/atom/app-1.18.0/resources/electron.asar/renderer/web-view/guest-view-internal.js:57:11)
    at EventEmitter.<anonymous> (~/AppData/Local/atom/app-1.18.0/resources/electron.asar/renderer/web-view/guest-view-internal.js:66:7)
    at emitTwo (events.js:106:13)
    at EventEmitter.emit (events.js:191:7)

Commands
     -8:48.3.0 core:save (input.hidden-input)
     -3:41.6.0 tree-view:add-file (span.name.icon.icon-repo)
     -3:37.1.0 core:confirm (input.hidden-input)
     -3:34.7.0 intentions:highlight (input.hidden-input)
     -3:34.2.0 fuzzy-finder:toggle-buffer-finder (input.hidden-input)
     -3:32.8.0 intentions:highlight (input.hidden-input)
     -3:32.6.0 core:paste (input.hidden-input)
     -3:31.3.0 intentions:highlight (input.hidden-input)
     -3:30.9.0 core:save (input.hidden-input)
     -3:25.8.0 intentions:highlight (input.hidden-input)
     -3:24.6.0 application:new-window (input.hidden-input)
  3x -3:12.6.0 intentions:highlight (input.hidden-input)
     -3:05.7.0 emmet:merge-lines (input.hidden-input)
     -2:46.9.0 intentions:highlight (input.hidden-input)
     -2:46.7.0 command-palette:toggle (input.hidden-input)
     -2:40 markdown-preview:toggle (input.hidden-input)

Non-Core Packages
activate-power-mode 2.0.0
angularjs 0.4.0
angularjs-styleguide-snippets 0.9.1
angularjs-styleguide-webpack-snippets 1.1.0
atom-angular-material-snippets 1.3.0
atom-angular-snippets 1.0.0
atom-autocomplete-php 0.25.6
atom-beautify 0.29.24
atom-clock 0.1.12
atom-material-syntax 0.4.6
atom-material-ui 1.3.9
atom-text-transformer 0.7.0
atom-transpose 0.3.4
atom-webbrowser 2.1.4
atom-zh-dictionary 0.4.4
autoclose-html 0.23.0
autocomplete-angular-material 0.4.0
autocomplete-java 1.2.5
busy-signal 1.4.3
color-picker 2.2.5
dash-ui 0.4.0
emmet 2.4.3
git-log 0.4.1
git-plus 7.3.3
git-plus-plus 1.1.0
git-time-machine 1.5.9
intentions 1.1.2
java-generator 2.2.3
java-importer 1.4.1
jshint 1.8.6
language-markdown 0.20.0
linter 2.2.0
linter-php 1.3.2
linter-ui-default 1.6.2
linter-write-good 0.9.0
loved-syntax 1.0.1
markdown-pdf 1.5.0
markdown-preview-plus 2.4.9
markdown-scroll-sync 2.1.2
markdown-themeable-pdf 1.2.0
markdown-writer 2.6.4
minimap 4.26.8
node-debugger 1.10.1
open-in-browser 0.4.7
php-cs-fixer 4.1.0
pristine-ui 1.0.15
script 3.14.1
seti-syntax 1.1.2
seti-ui 1.4.0
Tia-ui 1.0.3
trans-en-zh 0.2.5


Support ESP32 devices with and without std feature

Description
During preparation of arnauorriols/iota-streams-esp32, several changes have had to be done in Streams to be able to run it in the ESP32 target, with and without std feature enabled. This PR includes all such changes. The following is the list of the most relevant:

Make wasm-bindgen feature of rand only enabled when wasm-client feature of app-channels is enabled (it was always enabled)
Derive Debug in a bunch of types, notably BucketTransport, TangleMessage and Keccak1600
Get rid of chrono dependency. I've taken the assumption that the timestamp in TangleMessage was a leftover
from pre-chrysalis, so I've removed it completely. Now TangleMessage<F> is an alias of BinaryMessage<F, TangleAddress>
Make futures dependency pulled only when a *-client feature is enabled (it was always enabled)
Use StdRng::from_entropy() instead of thread_rng when target_os == espidf

Type of change

Enhancement (a non-breaking change which adds functionality)

How the change has been tested

[x] cargo check --no-default-features && cargo check && cargo check --all-features
[x] cargo clippy --no-default-features && cargo clippy && cargo clippy --all-features
[x] run arnauorriols/iota-streams-esp32 example
[x] run examples
[x] run wasm examples
[x] run c examples
[ ] run no-std examples

Change checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] New and existing unit tests pass locally with my changes

those 2 commits are causing problems with the node.js bindings -

Derive Clone, Debug, PartialEq and Eq for MessageContent
https://github.com/iotaledger/streams/pull/138/commits/016f61c5c704494995e2b30eb080b201589c6eae

Fix unused warning for prng::rng when no_std in x25519 wrap command
https://github.com/iotaledger/streams/pull/138/commits/3dffdf63136590debaa8a2dc99e8fb4a90dc2638
again the mio that complains ( and its dependency chain if i remember correctly, had the exact same stuff X times )..

Here's some uncompleted fork, that tried to get the lib working with WASI / WASM, but discontinued efforts:
https://github.com/Thomasdezeeuw/mio/commit/2a792afb1bccab27df8366404c135c605ac825f9
This might be interesting too, something with the core cargo toml dependencies + features declaration is doing weird things, especially with tokio / mio, maybe some helpful hint inside here:
https://github.com/rust-lang/cargo/issues/9176
I remember actually fixing this issue by tweaking around with the dependencies, overwriting / patching some with that [patch] toml syntax, downgrading a few crates, and using the new feature resolver v2 function on the rust nightly channel ..
https://doc.rust-lang.org/nightly/cargo/reference/features.html#feature-resolver-version-2
But with so many different tries and outdated clones of the streams repo, i cannot remember which exact changes fixed that following build error, that keeps hunting us again and again :D @jlvandenhout
deso@nuc /tmp/foo (master *) $ cargo build --target wasm32-unknown-unknown
   Compiling mio v0.7.7
error[E0432]: unresolved import `crate::sys::IoSourceState`
  --> /tmp/cargo-home/registry/src/github.com-1ecc6299db9ec823/mio-0.7.7/src/io_source.rs:12:5
   |
12 | use crate::sys::IoSourceState;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^ no `IoSourceState` in `sys`

Otherwise, +1 for your no-std efforts, can't wait to spin up my xargo / cargo xtensa llvm esp32 custom target ^^
Hella fun to completely use cargo instead of pio / arduino / idf.py / esptool.py to build, flash and serial monitor code on ESPs
cargo espflash --chip esp32 --example esp32 --speed 115200 --release  --features="xtensa-lx-rt/lx6,xtensa-lx/lx6,esp32-hal" /dev/tty.usbserial-0001
Ive been using this nice crate for it, ive got the Qemu installed but i tend to run it directly on the hardware

cargo install cargo-espflash

Hey @sascha1337 sorry for the late reply! We were focused on releasing 1.2.0 and this PR got backburnered. I've sync'ed this branch with develop, and the wasm build works now.

About the timestamp removal. Im all up for it, but when we add it back later (I believe in stardust we get one again?) what is the plan? Or will we be timestamp agnostic, and let the user use iota.rs to fetch timestamps?

Not sure about Stardust, but definitely will in Coordicide. What I'm not convinced of is if this timestamp will be relevant from Streams point of view... Will Streams use the timestamp of the TX for any logic? what will the semantics of this timestamp be? will it be relevant for the subscriber of the Stream?
In any case, in the present this timestamp is not there, and it is not used, and just adds up to the general confusion. That's why I propose to remove it and deal with it once it makes sense

Will Streams use the timestamp of the TX for any logic? what will the semantics of this timestamp be? will it be relevant for the subscriber of the Stream?

I think it's safe to say that as we currently have it implemented it really doesn't provide much benefit. The only way I could see the timestamp being relevant/beneficial is if it was added to the header so that we can sort multiple messages at a given index by this timestamp, which arguably we shouldn't need to do because (I'm not 100% sure on the stardust side specifically but in corrdicide yes) will contain their own timestamping process that we should be able to use since the timestamps will be embedded into the Tangle Message anyways.


fix(sector): fix a case in which the angle is NaN.

In #870, we fixed the animation bug caused by the NaN value. But that only works in canvas renderer. In SVG renderer, the path can't be successfully built because of the NaN value.
The related test case is the same as #870, that is, the last test case in echarts/test/pie-animation.html

BTW, I found another bug related to label & labelLine. It should be related to these three places.

https://github.com/apache/echarts/blob/release/src/chart/pie/labelLayout.ts#L395-L399
https://github.com/apache/echarts/blob/release/src/chart/pie/labelLayout.ts#L552-L555
https://github.com/apache/echarts/blob/release/src/chart/pie/labelLayout.ts#L564-L567

It didn't take into account the case in which the data becomes normal from NaN value.
Here is an online test case: https://codepen.io/plainheart/pen/ZEXNQVy

I think shape with NaN value should be not displayed. If we treat it same with 0. Border will still show.

@pissang You're right. Fixed.


⚒[FEATURE] Subtitles Loader Integration

Describe the feature you'd like
Subtitles Loader Integration
Docs: https://js.langchain.com/docs/modules/indexes/document_loaders/examples/file_loaders/subtitles
✅Tasks

[ ] Add Subtitles Loader node

🎯Acceptance Criteria

[ ] Subtitles Loader node should be able to load data from subtitle file

👨💻How to contribute
Follow this guide for step by step on how to fork, commit, and submit PR.
👨💻Reference code

Text Loader

More info
Like to work on this issue? Let us know, and we will assign it to you 🚀
If you need any help or just want to hangout, reach out to us on our Discord server👾

@HenryHengZJ  can you assign this to me?

#324 merged, closing this


HIVE-26937: Batching incremental events to avoid O.O.M during repl load

What changes were proposed in this pull request?

Make repl dump, dump events in batches so that repl load does not load all the events in staging directory into memory.
Why are the changes needed?

To avoid O.O.M incase of large number of events dumped by repl dump.
Does this PR introduce any user-facing change?

No
How was this patch tested?

+1 LGTM.


fix(config): force default output.filename

This PR contains a:

[x] bugfix
[ ] new feature
[ ] code refactor
[ ] test update
[ ] typo fix
[ ] metadata update

Motivation / Use-Case
this prevents karma-webpack from failing and also
prints out a useful error message explaining why
the webpack output.filename is ignored.
Fixes N/A
Breaking Changes
N/A
Additional Info
N/A

Hello,
why this change ?
it was previously working fine.
karma-webpack does not currently support customized filenames via
webpack output.filename, if this is something you need consider opening an issue.
defaulting apps/[name]/assets/js/[name].bundle.js to [name].js


Adding ZK configs for All cluster types - not just hbase, storm

Due to changes in HA sending of ZK info is now required.

Can one of the admins verify this patch?

Hi @nemanja88, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (nemadj). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


bump minikube to 0.26.1

Checksum for windows image calculated from both github release and GCS downloads. Others are the sha256 files available on the github release page.

thanks! I'll have to fix that CI flake at some point.


Origin of data

Should we display the origin of the data when using data entered through the API ?
For example if it comes from the Bund, display a small Bund logo with a link ?

I would. I think the source deserves to be mentioned. Maybe there is a small legal issue in using official logos.


Support for cram files?

Hi,
This is a question rather than an issue. I was wondering if there is current support for cram files as input (instead of bams) or whether this is to come in a subsequent version?
Cheers,
Loukas

The installation of htslib is a bit hassle, so we don't have it directly in the package. But, after cloning T1K package, you can manually download the htslib-1.15.1 to the folder. Then you can run "htslib=1 make". Then, T1K can work with CRAM file.
If you want to use another htslib version or change the htslib path, you can modify the Makefile and the header of the "alignments.hpp".

Thank you for your reply. Would it then run with the same command as for a bam file, e.g.
run-t1k  --preset hla-wgs
-c /path/to/hla_dna_coord.fa -f /path/to/hla_dna_seq.fa -b /path/to/genome.cram --od /path/to/output
--alleleDigitUnits 2 --alleleDelimiter ":"
or does the bam-extractor function need to be modified?
Cheers,
Loukas

Yes, the command would be the same as running with a bam file.

Does it require any particulr command? I don't see any change if only downloading this package and run the command.

@alicekiki It does not require particular command options. All you need to do is to compile T1K with htslib as instructed above.

Thank you! It worked out.

@mourisl, could you please help me out? I am encountering some errors while using a .cram file as an import. The .cram file I am using is from the 1000 Genomes Project. The .bam files are too large, and if possible, I would like to use the .cram files to run t1k.
Here is the code I ran:
./run-t1k -t 20 --preset hla-wgs -c ./t1k_resources/hlaidx/hlaidx_dna_coord.fa -f ./t1k_resources/hlaidx/hlaidx_dna_seq.fa -b path/to/cram/file//HG00138.final.cram -o ./../t1k_resources/t1k_output/NA19625
I encountered the following errors:
[bam_header_read] EOF marker is absent. The input is probably truncated.
[bam_header_read] invalid BAM binary header (this is not a BAM file).
Can not open path/to/cram/file//HG00138.final.cram
I followed the instructions to install htslib and then ran htslib=1 make, which I think worked successfully (see attached screenshot).

I think all necessary files were created after running "htslib=1" make.
I have a question: doesn't the .cram file only store information that is different from that of the .fa file used during the alignment, resulting in a smaller file size compared to the .bam file? Wouldn't this mean that we need to use the .fa file (used during the alignment) somewhere in the run-t1k process?
@alicekiki, how did you manage to get this working?
Thanks, and I look forward to your reply.

@Bondada20

Modify Between step1 and step2. Dont have publicly available cram file for the moment.

Have you modified the header in the alignment.h file to match your htslib version?
I think for the CRAM file, htslib will internal try to download the reference genome and it will be cached for future use. If you already have the reference genome, maybe the tutorial in the end of https://www.htslib.org/workflow/cram.html is useful.

After some trial and error, I finally got it to work. See how I got it to work below for anyone having issues setting it up.
Note: I am working on a server with restrictions on what I can do.

As @mourisl mentioned above, if you already have the reference genome, follow the instructions under "The REF_PATH and REF_CACHE" here: https://www.htslib.org/workflow/cram.html
Clone the T1K package.
Edit line 9 of the Makefile by changing htslip=0 to htslip=1.
Download htslib-1.15.1 to the T1K folder. Find releases here: https://github.com/samtools/htslib/releases
Change directory into htslib-1.15.1 and run:
autoreconf -i
./configure
make
Add HTSlib to the standard library path: export LD_LIBRARY_PATH=/path/to/htslib:$LD_LIBRARY_PATH

Thank you for sharing the steps. There is no need to explicitly edit line 9 of the Makefile. When running "make", run it like "htslib=1 make" should set the value of htslib to 1.


Bug: SimpleMesh breaks for larger mesh sizes

Current Behavior
I'm using SimpleMesh to stretch an image based on a grid that defines the distortion. I had a working solution but when I increased the grid size from 5x5 to 10x10, I started getting the cryptic error

WebGL warning: drawElementsInstanced: Indexed vertex fetch requires<PHONE_NUMBER> vertices, but attribs only supply 100.

The number 100 in "attribs only supply 100" comes from the number of vertices (10x10), but I have no idea where<PHONE_NUMBER> is from.
The mesh then doesn't render at all.
Expected Behavior
The mesh should render for any (reasonable) grid size.
Steps to Reproduce
https://codepen.io/V-clav-Volhejn/pen/jOXMBax?editors=0010
Increase the MESH_SIZE constant for the grid to break. It's possible that the threshold at which the bug occurs will be different for you. A 9x9 grid didn't work in my original version but did work in the Codepen that I made. For me, the Codepen breaks at 10x10.
Environment

@pixi/react version: 7.1.1 (the Codepen uses 6.8.0 because I couldn't figure out the imports, but locally I get the bug with 7.1.1 too)
pixi.js version: 7.2.4
React version: 17.0.2
ReactDOM version: 17.0.2
Browser & Version: Firefox 117.0
OS & Version: MacOS Monterey 12.4
Running Example: https://codepen.io/V-clav-Volhejn/pen/jOXMBax?editors=0010

Possible Solution
No response
Additional Information
No response

I managed to reproduce this in vanilla PIXI so I'm closing the issue here.


B14.1 System Integration & Test

💡 Description

Fri 4/12/24 - Wed 5/22/24

[ ] Perform System Testing
[ ] Generate Test Report
[ ] Update EN Node webpage with Test Report

Getting ready for the TRR next week.

📆 05/2024 status: In work. On schedule.

I&T completed.


implement conditional constant/copy propagation

https://www.cs.utexas.edu/~lin/cs380c/wegman.pdf
proc foo {
  x = false;
  if x {
     y = 10;
  else {
     y = 11;
  end
  use(y);
}

we should fold 11 into use(y)

this did happen


Adding users

Codecov Report

Merging #10 (65ad25a) into main (8318e6b) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main       #10   +/-   ##
===========================================
  Coverage     100.00%   100.00%
- Complexity         4         8    +4
===========================================
  Files              4         6    +2
  Lines              9        20   +11
===========================================
+ Hits               9        20   +11

Impacted Files
Coverage Δ

app/Http/Controllers/Auth/LoginController.php
100.00% <100.00%> (ø)

app/Http/Requests/Auth/LoginRequest.php
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8318e6b...65ad25a. Read the comment docs.


Explicit require template engine to prevent warning

Implicit require engine seem to be a non thread-safe way
WARN: tilt autoloading 'tilt/erb' in a non thread-safe way; explicit require 'tilt/erb' suggested.
WARN: tilt autoloading 'tilt/haml' in a non thread-safe way; explicit require 'tilt/haml' suggested.

Changes Unknown when pulling 20d6ff6ed08ed5398a943e5462fba48cea1fed43 on huydx:master into ** on lotus:master**.

:+1:

Changes Unknown when pulling c7685bd105c950ceebf929ea08e2765ad44fe64e on huydx:master into ** on lotus:master**.

Changes Unknown when pulling 6f95a0878ed699ed0f9c09078eb9a4276615cfc3 on huydx:master into ** on lotus:master**.

@huydx I don't think suppressing an eventual exception is a good idea. Suppose that we want to use HAML, but we haven't included it in the Gemfile. We want the application to stop at that point.
You make the assumption that the file extension corresponds to the library. This isn't a general rule of thumb. Please check Tilt README and you'll find soon that files with .coffee ext are handled by coffee-script library.
If we want to have a solid implementation for this we should introspect Tilt.default_mapping. It's a registry which holds those informations about exts, libs and engines.

@jodosha i agree that handling this behavior in all cases seems not to be a good way. We need warning to tell user to require the library explicitly.
However, warning display in the test case is not good either. I think at least we should require 'tilt/erb' and 'tilt/haml' in the test cases. How do you think about that?

@huydx TL;DR This is only an annoying issue for the test suite.
Lotus loading model
When Lotus::View is used in standalone mode, we explicitly ask developers boot the framework in a thread-safe context.
When we load a Lotus application, the internal loader wraps all those operations with a Mutex.
In both the production scenarios above, adapters are autoloaded, but in a safe context. Tilt isn't aware of this sane way that we use to load it. Its vision of the world is limited to the autorequire, which is a worrying issue in case you don't design those mechanisms carefully.
Test suite
Why we don't explicitly require those adapters in tests? Because we don't need to. As mentioned above, Lotus has a safe way to load frameworks and applications.
At the same time, we want to assert the Tilt will keep to autoload those adapters. Leaving tests as they are, lets us to notice ASAP if something in Tilt has changed.
What to do
Because those warnings are only generated during the tests, I'm for leaving the things as they are.
An alternative would be to silence those warnings during for test fixtures. But this may hide other important messages that come from Tilt.
/cc @joneslee85

@jodosha FYI it does appear in app, not just in test suite

@jodosha as lotus loader already wrapped all loading progress in a mutex, i think it's ok to leave things as they are. As well as warning display exactly explicit what it should be, this issue should be closed.

@joneslee85 This is all yours :dancer:

Also remember that 'require' is rather expensive operation and it's better to avoid it inside methods, especially rather often called initializer. I was going to prepare benchmarks for this, but I see it's not going to be merged anyway ; )

@KillaPL please feel free to bench this, I'd love to see the difference. And yes, this is likely to be merged after another round of review ;)

@KillaPL @joneslee85 Please remember that Template#initialize is called n times only when the application is loaded. Where n is the number of templates in an application.

Slowing down the startup is a legitimate concern. I will compile down a benchmark for this (hopefully) tomorrow.

@KillaPL I agree, but it's less worrying of a runtime overhead, where you pay performances for each request.
Anyway, do you folks have news about this?
/cc @huydx @joneslee85

A quick benchmark results in:
20000 times without require  0.600000   0.080000   0.680000 ( 0.671526)
20000 times with require     0.780000   0.060000   0.840000 ( 0.841235)

Which is around 25% slowdown, or in another words, 0.16s for 20k template loads. This is the case in ruby 2.0.0 and 2.1.3, problem I was thinking must have been relevant in older rubies.
I suppose this kind of performance regression is ok if it solves an actual problem.
Also, sorry for the delay, builders cut of my internet connection for a couple of days: (

@KillaPL In other words a ~0.00008 sec perf penalty multiplied the number of templates for an application, each time the application starts.
Real world example. At work we have 572 templates, the cost of this would be 0.04576 sec each time the app starts (production, tests, console, etc..).

In one of my previous projects we used this method:
http://www.ruby-doc.org/stdlib-1.9.3/libdoc/pathname/rdoc/Pathname.html#method-i-mkpath

And we found out that using just
FileUtils.mkpath

is way faster beacuse of require. But this was millions of calls and 1.9.3 times, where #require was O(n) if I remember correctly.
Well, better checked then sorry: )

@KillaPL I'm confused, what's the relationship between mkpath and this topic?

There is a require call in mkpath, just like this PR is adding.

I think the solution here is to have devs to explicitly require the tilt engine during the loading of the code.


Documentation for C++

Tracks the documentation work in C++

@ahsonkhan , please take a look to Docs and add any issue to this epic (if required) so we can closed or consider Docs as ready for release

Closing, this is tracked in the Azure::Core Epic


Fix readme.md

Just fixed the readme

Add removed the .DS_Store and added gitignore so it doesn't come back

closing pr as no activity


Unable to ignore: UIImagePickerController

There does not seem to be a way to not apply the Button NUI style to the buttons within the UIImagePickerController.
It would appear the only way is to avoid using Button as a class altogether?  Anyone know a good solution here?  I do not want the buttons in this screenshot to take on any style at all:

Couldn't you solve this using exclude-subviews?

I can now that the comma-separation issue is fixed... I also discovered that, as it turns out, presenting a UIImagePickerController does not actually put a UIImagePickerController into the view hierarchy, but rather a bunch of other things like PUCollectionView and (the one pictured above) PLCropOverlay... finding the right one of those views to exclude-subviews from was the key.


Question: why not using bevy_rapier?

Hi @wynss,
I love this project! You came up with great solutions to get Bevy+Rapier working as a robotics simulator :heart_eyes:
I was wondering, what are the reasons behind writing a custom rapier integration instead of using bevy_rapier? Does bevy_rapier has some restrictions that prevent from using it in a simulator?
This is probably not the perfect place for questions. Please let me know if i should use another channel.

Hi and thanks, glad you enjoyed it!
Very reasonable question. :) The reason is quite simple, when I started to work on Kesko I had not written any Rust so I wanted to get deep into it and become fluent, so my plan was to do everything from scratch. Regarding the physics integration I wanted to try and combine the best of bevy_rapier and another framework called heron. I've always had in the back of my head that a migration to bevy_rapier probably makes sense long term so I can focus on more high level features, but when that will happen is very unclear. Recently started a new job so will not have so much time in the near future. Hopefully that will change further down the road.

That makes perfect sense, thank you for the answer! :)


Bug 2089827: Refix backward compatibility patch

The path of the file was not accurate, metallb_dir refers to
metallb/openshift_ci. We need to raise a level.
To cut me some slack, I did not see the error in the previous CI run because it was finishing before patching the file.
Temporarily removing the -e flag to see if patching finally works or not.

Worked, the file was patched correctly and the only failed test was the bfd webhook one.

/bugzilla refresh

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

bfd profile webhook is expected to fail, all the rest looks good.

/lgtm

/override backward_compatible

/retest

/lgtm

/override ci/prow/metallb-e2e-metal-ipi

/override ci/prow/metallb-e2e-metal-ipi-ovn


default grey line on top of sliding panel which needs to expand or collapsed

Use this to remove the shadow
app:umanoShadowHeight="0dp"


Steam: games cannot find libsteam_api.so in root of game folder

Issue description
Some games need the libsteam_api.so which is in the root of the game folder, but cannot find it.
I currently work around this issue by manually creating in the game folder a wrapper for the executable, prepending . to LD_LIBRARY_PATH.
cc @abbradar

Hitting this as well when trying to run SteamVR

Any progress on this one? I tried to play CS2D but it does not start and reports linker cannot find libsteam_api.so. But CounterStrike (different game, but also in Steam) works - perhaps it doesn't need that library.

Got the same error with Euro Truck Simulator 2

I believe this has been fixed by valve upstream, as pressure-vessel should be adding pinned runtimes now


Warn when transaction entered without calling start_transaction

This change should prevent confusion like what led to #2990 being opened.

Made the requested change @antonpirker


[Function] Refactor code of datetime comparetion and delete some unless code

Proposed changes

Refactored the logic of DateTime comparison size, and does not depend on the endianness of the type. Need to be compatible with the logic of the old version of doris, but it will cause the performance of DateTime comparison to decrease
Delete the useless code logic in the comparison function, and modify the format
Fixed the core problem of in/cast in function context

Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[x] Code refactor (Modify the code structure, format the code, etc...)
[ ] Optimization. Including functional usability improvements and performance improvements.
[ ] Dependency. Such as changes related to third-party components.
[ ] Other.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If these changes need document changes, I have updated the document
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

整体datetime改动这个块代码上没问题了；functionContext部分辛苦硕哥@wangshuo128 有空看下吧


Fix the IG home page

Merging branches made the IG home page go weird.
The mpd-r4b branch IG link  is in some of the deliverables that are circulating.
Please fix it or help me fix it at least for my branch, as it does not look good to have a broken landing page.

I just took a quick look at the source of the page and there is something weird going on:

If you are familiar with HTML you know that those are not valid HTML tags. To me looks as if some kind of HTML pre-processor (I can't tell which one) failed, or wasn't run at all.

I created a new page in the IG for regulatory data use case (branch mpd-r4b). Most of what I had on the UNICOM IG home page was transferred there, so now the home page is more or less empty.
Once the home page is fixed, we can give it new and more broader content.

see discussion here
https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/Formatting.20Errors.20-.20Sushi.20and.20Latest.20Publisher
On Sun, Jan 1, 2023 at 10:45 AM Rutt Lindström @.***>
wrote:

I created a new page
https://build.fhir.org/ig/hl7-eu/unicom-ig/branches/mpd-r4b/regulatory.html
in the IG for regulatory data use case (branch mpd-r4b). Most of what I had
on the UNICOM IG home page was transferred there, so now the home page is
more or less empty.
Once the home page is fixed, we can give it new and more broader content.
—
Reply to this email directly, view it on GitHub
https://github.com/hl7-eu/unicom-ig/issues/70#issuecomment-1368399473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD3HUUHMADKAL5AJYXSJEIDWQFGZ3ANCNFSM6AAAAAAS6DEFEE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This is fixed.


patch crafting system upgrade item, upgrade item to player level without intermediate steps

This still doesn't fix excessive upgrade cost, but it at least reduces it somewhat and skips all those minimal-improvement steps and hopefully makes upgrading feel more substantial. Provides another syntax example, for switch in this case, and shows that users can add their own functions and not just @replaceMethod ones

that's really neat 💯


Fixing file

Docs Build status updates of commit eeea1b5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azureadps-2.0/AzureAD/Set-AzureADMSGroup.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


arch/riscv/riscv_features.c: fix uclibc build

Fix the following uclibc build failure raised since version 2.1.4 and https://github.com/zlib-ng/zlib-ng/commit/6ff8b52cefe56a824fae1d53fdd687bcde2e53c9:
/home/autobuild/autobuild/instance-2/output-1/build/zlib-ng-2.1.6/arch/riscv/riscv_features.c:4:10: fatal error: sys/auxv.h: No such file or directory
    4 | #include <sys/auxv.h>
      |          ^~~~~~~~~~~~

Fixes:

http://autobuild.buildroot.org/results/06a7d8e59ec4de7c711d3f4a4624f67b97d78afe

Not all toolchains have sys/auxv.h, but the same information might be available in other headers... Just disabling the feature detection doesn't really count as a "proper" fix, it should be the last resort if anything else doesn't work.

Sorry but I don't understand your comment, I'm basically patching riscv_features.c as already done for other architectures in e1baa6b439c06f3d0e6be3e381cc746ffb55aee1. If getauxval is not available, there is no way to do any runtime detection. Did I missed something?

Sorry but I don't understand your comment, I'm basically patching riscv_features.c as already done for other architectures in e1baa6b. If getauxval is not available, there is no way to do any runtime detection. Did I missed something?

Latest uclibc release is very old, uclibc-ng does have sys/auxv.h. As long as the Linux distribution uses ELF binaries, auxiliary vector (auxv) does exist, even with latest available uclibc version. The issue is only getting the start address of auxiliary vector.

getauxval and sys/auxv.h have been added very recently to uclibc-ng. It was done 15 months ago by https://github.com/wbx-github/uclibc-ng/commit/d869bb1600942c01a77539128f9ba5b5b55ad647. This means that most of the "not so old" uclibc-ng toolchains used for embedded systems  will raise a build failure. If this PR is not acceptable, I can also disable zlib-ng with uclibc-ng on buildroot side.

There still exist small issue for systems that have neither getauxval function or ISA_V_HWCAP defined, which would essentially be very old systems (uclibc is very old, uclibc-ng is more recent) or possibly any non-Linux system running on RISC-V (We pretty much only support BSD-compatible or Linux on non-x86/ARM platforms). I'm not really worried about supporting non-ELF systems on RISC-V with this PR... As I said before, this seems incomplete fix.
As I've said before preprocessor should evaluate undefined preprocessor tokens in expressions as 0, but this depends on if the warnings are suppressed or not, or treated as warnings or errors.


Draft: feat: extend prometheus metrics

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


WFLY-18995 Remove illegal uses of Operation.hasOptionalCapability(String, null, null) from Infinispan subsystem

https://issues.redhat.com/browse/WFLY-18995

Thanks @pferraro


Add Article for Hello World in Google Apps Script

@ApCoder123 just added this solution in #160. I'll have to remember to reference them in the article.

Releasing this one tomorrow: May 22nd, 2018.

Added article link to README: 0c09c014e26053ac2bb7db60589e1f363fbe0ebd
See y'all tomorrow!


fix: add pending intent immutable flag to NotificationIntentAdapter

Google Play's target API level requirement increased to API 31:
https://developer.android.com/google/play/requirements/target-sdk#pre12
One of the requirements is to always specify the mutability of each PendingIntent object:
https://developer.android.com/google/play/requirements/target-sdk#pre12:~:text=Pending intent mutability%3A You must specify the mutability of each PendingIntent object that your app creates.
This PR adds the PendingIntent.FLAG_IMMUTABLE to the only place where it was needed.

I'm having the same issues with upgrading to api 31, awaiting fix PendingIntent.FLAG_IMMUTABLE

We identified the problem was in the "react-native-notifications" library
https://github.com/invertase/react-native-firebase/issues/6759


top-level DataProcessing would require a different uniqueness level for data_processing_id

The current DataProcessing object is a sub-object within Repertoire so it's data_processing_id only needs to be unique within a repertoire. If we want to make DataProcessing a top-level object, or at least generalize it beyond Repertoire so that it can describe operations on RepertoireSet, Clone and etc., then it's uniqueness level should change so that the id can be used across multiple objects.

I am thinking that changing this is not really necessary for v2.0 - unless it is necessary for the RepertoireGroup and Manifest objects. @schristley thoughts?

Not necessary for v2.0 as we won't be re-designing DataProcessing for v2.0. Still an issue to be considered so I've moved forward to v2.1


infinite loading

hosting my own instance, for some reason when I open a new page, it seems to load indefinitely, followed install instructions, and if I refresh the page, the loading circle goes away, and I can use the site normally, but I can't seem to recreate this on the demo site.
EDIT: I cannot use the site normally on some pages, such as the goals page, I cannot add a new goal.
is there a difference between using a release and using a standard git clone?

Hello,
So this EDIT: is this case also happening on demo or only on Your instance?
Are you using it on chrome?
Can You check if there are some errors in Your browser console?

I've just cloned the main branch, ran composer install, created user, logged in and added goal so I wonder what errors You got.
In case of no errors in chrome dev tool - please check also the backend logs.

okay so I am running it on Chrome, I cannot reproduce these issues on the demo, I tried creating a goal after restarting the server and making a goal works, the site seems to work fine except I have to reload it constantly from browser, I'll try the app_debug = true and see if I can find the issue.

prod.deprecations.log
prod.log
prod.security.log
dev.log
I've provided logs here, I don't really understand whats going on too much, but it doesn't look great.

Ok so, You have at least one problem to fix on Your side.
[2020-05-21 22:37:30] request.CRITICAL: Uncaught PHP Exception Twig\Error\RuntimeError: "An exception has been thrown during the rendering of a template ("An exception occurred while executing '           SELECT              mnc.name AS category,             mnc.icon AS icon,             mnc.color AS color,             mnc.id AS category_id,             mnc.parent_id AS parent_id,              ( -- get children categories                SELECT GROUP_CONCAT(DISTINCT mnc_.id)                FROM my_note_category mnc_                WHERE mnc_.parent_id = mnc.id                AND mnc_.parent_id IS NOT NULL               ) AS childrens_id           FROM my_note mn           JOIN my_note_category mnc                         WHERE mn.deleted  = 0             AND mnc.deleted = 0            GROUP BY mnc.name         ':  SQLSTATE[42000]: Syntax error or access violation: 1055 Expression #2 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'management.mnc.icon' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by")." at /var/www/personal-management-system/templates/page-elements/components/sidebar/menu-nodes/notes.twig line 31 {"exception":"[object] (Twig\\Error\\RuntimeError(code: 0): An exception has been thrown during the rendering of a template (\"An exception occurred while executing '\n          SELECT \n            mnc.name AS category,\n            mnc.icon AS icon,\n            mnc.color AS color,\n            mnc.id AS category_id,\n            mnc.parent_id AS parent_id,\n             ( -- get children categories\n               SELECT GROUP_CONCAT(DISTINCT mnc_.id)\n               FROM my_note_category mnc_\n               WHERE mnc_.parent_id = mnc.id\n               AND mnc_.parent_id IS NOT NULL\n              ) AS childrens_id\n          FROM my_note mn\n          JOIN my_note_category mnc\n            \n\n          WHERE mn.deleted  = 0\n            AND mnc.deleted = 0\n\n          GROUP BY mnc.name\n        ':\n\nSQLSTATE[42000]: Syntax error or access violation: 1055 Expression #2 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'management.mnc.icon' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by\"). at /var/www/personal-management-system/templates/page-elements/components/sidebar/menu-nodes/notes.twig:31, Doctrine\\DBAL\\Exception\\DriverException(code: 0): An exception occurred while executing '\n          SELECT \n            mnc.name AS category,\n            mnc.icon AS icon,\n            mnc.color AS color,\n            mnc.id AS category_id,\n            mnc.parent_id AS parent_id,\n             ( -- get children categories\n               SELECT GROUP_CONCAT(DISTINCT mnc_.id)\n               FROM my_note_category mnc_\n               WHERE mnc_.parent_id = mnc.id\n               AND mnc_.parent_id IS NOT NULL\n              )

Exactly here
GROUP BY clause and contains nonaggregated column 'management.mnc.icon' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by\")

Please follow this point in my documentation:

https://volmarg.github.io/installation/#problems-tips  -> Can't login/sql_mode

With APP_ENV set to dev You should be able to generate another log

If this fix with mysql wont work then please turn Dev env and recreate that issue on Your self hosted instance.
Warning do not instert any personal data with this as log will contain all the inserts etc, exceptions on mysql side etc.

Also please check if You have some 400+/500 error codes when creating the goal as this is happening via ajax. If You will see some error (red) then click on it, also try preview and send me the results.

Chrome dev tool:

also in other tab check for some js errors (red)

Fixed the issue with mysql, didn't help.
I have no new logs and no errors in CDT

you can test out my instance here: division25.xyz with admin/admin
maybe you can figure out what I can't.

It wont let me in with admin/admin
Invalid credentials.
Also please make sure that You got dev dependencies also installed, just make sure You got profiler package in the vendor and u got ENV dev with Debug on, this will help me.

ah you are correct, it's mayhem/admin
also as far as I can tell I do have profiler installed and debug on

lI just created

goal visible on dashboard,

subgoal to this

goal not visible on dashboard,
note category,

with note in that category

Had no errors.
My tests were ran in:
Wersja 72.0.3626.119 (Oficjalna wersja) (64-bitowa) Incognito mode
Can You check that in Incognito mode then as well? Maybe You got some plugin which breaks something.

okay, so from what I can tell, it seems to have something to do with going to goals, or dashboard, and them not loading correctly, looking in Doctrine
App\Entity\Modules\Goals\MyGoals | The mappings App\Entity\Modules\Goals\MyGoals#mySubgoal and App\Entity\Modules\Goals\MyGoalsSubgoals#myGoal are inconsistent with each other.
-- | --
App\Entity\Modules\Goals\MyGoalsSubgoals | The association App\Entity\Modules\Goals\MyGoalsSubgoals#myGoal refers to the inverse side field App\Entity\Modules\Goals\MyGoals#myGoal which does not exist.

I see this, if I avoid goals/list and dashboard, the site works fine otherwise.

Yeah that's what there is in the profiler but i also got this in my dev. This cannot be the issue as Your instance, my dev, my prod work fine for me.
I thinks this has something to do with Your environment.
Can You check it on other browsers but all in incognito/private?

the same thing happens in incognito in Chrome.

What version of chrome are You using?

Version 83.0.4103.61

Ok, so I will check that out tommorow on windows. I have older version on Linux

But now that i think. It still makes no sense.
You are playing with demo with the same browser and there are no such problems.
Anyway will think tommorow. This is interesting case.

Like i thought - no sense as with latest chrome version works also fine on windows.
I have actually other idea.
While keeping the Dev Tool open, go to some page which is loading endlesly and check the tab Network. Watch if there is some endleslly running request, i used to have such problem on my dev instance when i keept debugger on and this slowed down each ajax call badly.

No long running requests, but it seems like the requests get cut short, as if they don't load at all

I assume that You still got 200 for that requests.

I can't even consider chown/chmod as these would return 400+/500.
It cannot be cache as data is cached in one dir and then served for You and for me.
No network issues, no js issues, no browser based issue.
No frontend issues/no backend issues, no exceptions.

I got 3 more idea, - let's go with the most simple one:

if the spinner won't dissapper,
open the browser console, type that in:
ui.widgets.loader.hideLoader();

there is also method responsible for showing it:
ui.widgets.loader.showLoader();
Check if after hiding loader - it works correctly.
I mean the point is if the loader is the only problem, if the page in browser finish loading (X near search bar) and the spinner is there then this is a bit other issue.
Now if this will work, with hiding spinner manually then it will give me some hint.

I mean, i had a one case... very rare thing where 1st ajax calls interfered and spiner was never shown for next call. Maybe this is case the other way around.

it hides the loader and I can continue on normally.

Ok so i will take a look in free time if I maybe have some case with showLoader() without hide but i doubt it as it works fine on demo/dev/prod. Eventually You can zoom the network tab loading graph and see if there are some 2 interfering ajax calls - i wonder how is this possible but it might be the case.

is there something I can do in the meantime other than having to manually open console and send that command everytime?
I plan on putting this on a touch screened pi that won't have a keyboard so it'll make it a bit difficult to paste it all the time

Well there is a dirty temporary workaround solution for this, but You need to make sure if all works fine after that, cuz in worst case js might scream that dom element was not found and will break all front logic.
Open file:
templates/base.html.twig

Go to line:
102-104
Remove:

go to CLI and run:
sudo -u www-data bin/console cache:clear
and
sudo -u www-data bin/console cache:warmup
You can do this after turning env back to prod to hide the dev profiler.
It might just work.

that didn't fix the issue either.

This is really something, i just removed loader from dom on demo in dev tool and then opened some pages alongside with calling the hide/show and spinner is no more there.
You are sure that cache clearing went fine?

yes it did, I got no errors on my end

just to compare, what version of node and npm are you using?

Can't answer that question now as I'm on windows now and my dev is on linux - ain't going on linux today anymore.
But node/npm should've nothing to do with this unless... You called --watch, production with webpack then it might've broken the output files, otherwise there is just one big output compiled bundle.

there were some errors with nodesass, I was just curios if maybe that had something to do with it, it fell back to a binary and claimed all was okay, but I wasn't sure if that had maybe caused an issue. if you manage to figure out which node you are using let me know so I can double check against what I am using.

Check this: https://volmarg.github.io/developer-mode/
NodeJS - on disco dingo installing NodeJS via package manager didn't worked well. Generally it's recommended to use NodeJS 9, but this solution also worked:

good luck - im out for today. I wonder what's going on anyway.

I have fixed the issue, it's node 12. I downgraded back to node 10, rebuilt PMS and the infinite loading is gone.

Oh, so You did compiled the Output js/css anew with webpack. This makes sense now as i Also provide both bundles for production.

Well if I compiled with node 12 it errors out, I did this several time just confirm, then switched to node 10 and did it a few more times and it work every single time I tried it.
It seems a couple packages either aren't compatible with node 12, or it's just one that messes up the rest of the build.
Either way I'm closing this issue, and I'd like to thank you for taking so much time to try to help me figure it out.


JS incorrect assignment to super reference value

This code prints "sub sub", but should print "sub super".
shared void run() {
    class Super(shared actual default String string = "super") {}
    class Sub() extends Super() {
        shared actual String string;
        string = "sub";
        shared void test() {
            print(string);
            print(super.string); // should print "super"
        }
    }
    Sub().test();
}

It works correctly if 1) Super.string is defined in the class body rather than as a parameter, or 2) if Sub.string's value is provided as part of the declaration.
A slight variation is to have Sub.string be a variable.

This is gonna be a tough one... the problem only occurs with shared attributes; the private field name is string_ so it's overwritten in the subclass (they don't work like private fields in Java). So field names should always be private.

Using private attribute names for all fields causes a lot of breakage. Perhaps this can be done only for actual attributes that refine a formal or default one...

The problem with JS may be similar to what I had with Dart. From memory, the issue was:

We want attribute initialization to be non-polymorphic
But due to constructors, default args, etc, attribute initialization is often performed in a separate statement than attribute declaration. The result is that the override gets initialized, and there is no way to explicitly target the original declaration.

So, in Dart, two attributes are declared.

The first is private with a unique name. This one can be explicitly assigned for initialization.
The second is public and delegates to the first. This one can be overridden, and is the one used for everything except initialization.

It's somewhat similar. Attributes in JS are backed by fields, as in Java. The problem with refined attributes is if the field name remains the same, the value is effectively overridden. By using a private generated name for all fields, this is solved, but it causes a lot of breakage in metamodel code which relies on the current naming scheme for attribute fields. That's why I want to limit this naming scheme to actual attributes...

Well you can have a long chain of default overrides.
I don't see how the metamodel would be affected. Having a private (uniquely named) backing field should be an implementation detail that cannot be seen outside the class.

It's affected because of the mix of native and generated code.


Change "Trixi" to "Trixi.jl" in all textual contexts

Are the Windows MPI failures spurious? I can’t tell from the test output.

Yeah, Windows MPI seems to be crashing every time....


GUI Application Extension

Application
README

Quick update because I intended to solve this issue myself but I've become lazy:
The application won't launch due to the usage of local paths.
This is when it is installed via pip. If you'd like to try and solve this too, you can install local packages via pip by python -m pip install -e /local/dir


Make generated files adhere to prettier

Is your feature request related to a problem? Please describe.
If you lint your markdown files with prettier, then often the generated changelog entries are raising errors and one has to manually run prettier on the generated/modified files to ensure everything is compliant.
Describe the solution you'd like
All generated files (Changelog, contributing, release manifest) should be compliant with prettier.
Describe alternatives you've considered
Manually running prettier on the modified files after the PR is generated and commit fixes, e.g. as in https://github.com/remarkablemark/release-please-extra-files-demo/blob/master/.github/workflows/release-please.yml. This however is rather involved and has the drawback that the linter-commit doesn't trigger a workflow run.
Additional context
Has been originally raised at https://github.com/google-github-actions/release-please-action/issues/542.

Similar to https://github.com/googleapis/release-please/issues/2085, this is not something we are in a position to maintain. Formatting is a personal choice and we cannot feasibly configure formatting for every file type, nor do we plan to run any post-processing binaries.
Users are free to run post-processing on the release-please PRs to "clean up" formatting.


resultTypes option has no effect

Using the resultTypes option with getViolations makes no difference. The only array that gets generated is a violations array, even if resultTypes is set to include passes and/or incomplete.

just stumbled across this as I also tried to retrieve the "needs review" aka "incomplete" items and didn't see anything in the result array ... getViolations currently only returns the violations part of the results but not the full structure (https://github.com/abhinaba-ghosh/axe-playwright/blob/cafba4148aecb9ef3f1b24110d28a3765c12f1e8/src/index.ts#L61), hence everything else is left out even when adding it in the options.


How about an "any" built-in type for arbitrary YAML-compatible data structures?

Have we some use cases illustrating that having "any" should be a good solution?

I have a translator that generates TOSCA profiles from YANG modules. An ‘any’ type would be useful when translating YANG unions.
From: Philippe Merle @.>
Sent: Friday, March 11, 2022 5:27 AM
To: oasis-open/tosca-community-contributions @.>
Cc: Subscribed @.***>
Subject: Re: [oasis-open/tosca-community-contributions] How about an "any" built-in type for arbitrary YAML-compatible data structures? (Issue #76)
Have we some use cases illustrating that having "any" should be a good solution?
—
Reply to this email directly, view it on GitHubhttps://github.com/oasis-open/tosca-community-contributions/issues/76#issuecomment-1065111953, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AASPLIOF5ZGEMCZWRV6T4KLU7NC2DANCNFSM5QNLM6RA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>


Merge to master

https://ledgerhq.atlassian.net/browse/B2CA-1685

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.43%. Comparing base (9b2bc9e) to head (91db9ed).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   64.43%   64.43%
=======================================
  Files           8        8
  Lines         464      464
=======================================
  Hits          299      299
  Misses        165      165

Flag
Coverage Δ

unittests
64.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

https://ledgerhq.atlassian.net/browse/B2CA-1685
Merging despites the Stax and Flex snapshots are not correct for some tests (to keep consistency between Prod P1 provider and master branch)


Animating breaks css padding?

I'm using animate translate x to move an element 100 to the right. Then after that I do the same thing but -100 in an attempt to return it to the original position.
But the final position of the card is off because the original css padding is not acknowledged.
Code:

function drawCard() {
  animate({
    el: "#card",
    translateX: 100,
    opacity: 0,
    duration: 500,
    complete: animateCard
  });
}

function animateCard() {
  animate({
    el: "#card",
    translateX: -100,
    opacity: 1,
    duration: 500
  });
}

Please read the documentation, the problem you're experiencing is just a wrong usage of the API.

You mean the 1 page README that says this javascript animation library is a css animation library? That's where I copied the function from.


[BUG] Settings not used

Version
<IP_ADDRESS>
What platform are you using?
Android
OS Version
Android 10
What happened?
First start, set auto-scan to false and flash is auto-false. Though deslite of these settings, both are somehow enabled and the app crashing as soon as I try to scan.
Relevant log output
?

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@cd-FileX ok not good. Will try to reproduce
THanks

@cd-FileX i tried to reproduce your issue but could not on my phone.

is that only happening on first run? Or is flash always triggering without it being enabled?
same thing for auto Scan?
if you switch flashmode then put it back to "noFlash" does it work?

@cd-FileX could you please try with that build for the auto scan crash https://github.com/Akylas/OSS-DocumentScanner/releases/tag/test_android ? With this one i would get a bug report (dont forget to restart the app after the crash for the log to be sent).
As for the flash it is really weird indeed. Have you tried that app https://github.com/GrapheneOS/Camera ? Does it work with it ? We use the same camera lib

@cd-FileX ok it tells me the autoScan crashes "depending" on the scan it sees with the camera.
As for flash issue very weird!

@cd-FileX the flash issue might be fixed in 1.4.6

@cd-FileX that s strange that is actually the flashlight toggle that i fixed :s
Could you again please try with this build https://github.com/Akylas/OSS-DocumentScanner/releases/tag/test_android ? (restart the app after the crash)
Really sorry for the trouble

@cd-FileX great i got the crash and it is something i already partially fixed.
the issue comes from trying to draw an image too big. Your phone seems to have 48mp camera => ~180mb image. Quite big :D
In the build you have i already added a limit to the capture image size. THought that would be enough. Do you remember if the crash happened while capturing a new image or while "browsing" already captured (with older builds) images?
I am starting to think i wont put a cap to the capture image size but instead try to reduce image before drawing it in case it is too big. Just a bit afraid there might be other issues with such big images

@cd-FileX i rewrote big parts of the app for better memory management. I will close this for now but please dont hesitate to open if you still face an issue


[release]: Resign the JDBC driver and the TACO (expires on 2024-04-16)

Did you read the on-boarding document
Yes
What is the name of your component?

OpenSearch JDBC driver
OpenSearch Tableau Connector

What is the link to your GitHub repo?
https://github.com/opensearch-project/sql-jdbc
Targeted release date
The signer certificate expires on 2024-04-16. Resigning should be before that.
Where should we publish this component?
artifacts: https://artifacts.opensearch.org/
download page: https://opensearch.org/downloads.html#drivers
What type of artifact(s) will be generated for this component?
Signed shadow jar and signed taco file.
Have you completed the required reviews including security reviews, UX reviews?
N/A
Have you on-boarded automated security scanning for the GitHub repo associated with this component?
Yes
Additional context
This is just a reminder to renew signer certificate before 2024-04-16 and publish resigned artifacts.

@GumpacG I believe this issue covers it? https://github.com/opensearch-project/opensearch-build/issues/3468

@gaiksaya https://github.com/opensearch-project/opensearch-build/issues/3468 is for renewing the OpenSearch PGP key while this issue is for the jarsigner specifically.

@GumpacG If I understand correctly the sign is valid till 2024-04-16 and since JarSigner team owns the signing infra, they will have to update the signer dates on their side.
Is the signed artifact not acceptable?

The artifacts are valid. I created this issue here as a reminder to get it resigned before expiration as this is where we got the driver and taco signed (https://github.com/opensearch-project/opensearch-build/issues/3614 & https://github.com/opensearch-project/opensearch-build/issues/3631). This issue is also going to be on the website for signature changelog similar to the PGP keys. Sorry, I'm not too sure what the protocol is for updating the website. Please let me know if this should be done a different way.

Based on Tableau's documentation, I don't think that they do. With that being said, I actually got the dates wrong. The signer certificate expires on 2024-04-16, however the artifacts have timestamps valid until 2031-11-09.
To get this off opensearch-build's plate, what I can do is close this issue and create a tracking issue in https://github.com/opensearch-project/sql-jdbc/ in case we don't release new artifacts before 2031 to get artifacts resigned.
Does that sound alright?

Closing this issue to move to sql-jdbc repo. https://github.com/opensearch-project/sql-jdbc/issues/97


Add issue/PR template.

Add Issues/PR templates to the repo.

I have some templates and add those to the repository so, can you make me a collaborator on this project.

@SAMAD101 Done added a universal default template.


fix check for postgres password

Properly check whether POSTGRES_PASSWORD environment variable is empty.

"Properly" ?  I think you're going to have to expound a little bit. :smile:
$ help test
...
      -n STRING
         STRING      True if string is not empty.
...

(ie, the two are equivalent)

@tianon PEBCAK.. I think I hit another problem and I thought it was the password check... Sorry for the noise

No worries! :+1:


iOS Hosted UI Still Not Working

Describe the bug
Please see https://github.com/aws-amplify/amplify-ios/issues/1276
It still fails the same way when trying to use hosted UI, so I'm not sure how you closed it...
I waited to try with the latest libs, just in case.

Steps To Reproduce
Steps to reproduce the behavior:
Try logging in with :
    func webSignIn() {
            _ = Amplify.Auth.signInWithWebUI(presentationAnchor: window) { result in
                switch result {
                case .success:
                    print("Signed in")

                case .failure(let error):
                    print(error)
                }
            }
    }

Expected behavior
Login works with hosted UI.
Amplify Framework Version
2.25.0
Amplify Categories
Auth
Dependency manager
Swift PM
Swift version
5
CLI version
1.13.4
Xcode version
12.5.1
Relevant log output
Swift runtime failure: Unexpectedly found nil while unwrapping an Optional value

Is this a regression? (i.e. was this working before a version upgrade)
No response
Device
iPhone12 Pro Max simulator
iOS Version
14.5
Specific to simulators
No
Additional context
No response

Actually the full code is:
`    private var window: UIWindow {
guard
let scene = UIApplication.shared.connectedScenes.first,
let windowSceneDelegate = scene.delegate as? UIWindowSceneDelegate,
let window = windowSceneDelegate.window as? UIWindow
else { return UIWindow() }
    return window
}

func webSignIn() {
        _ = Amplify.Auth.signInWithWebUI(presentationAnchor: window) { result in
            switch result {
            case .success:
                print("Signed in")

            case .failure(let error):
                print(error)
            }
        }
}`

Also tried with the code from Amplify for IO13+:
func signInWithWebUI() -> AnyCancellable {     Amplify.Auth.signInWithWebUI(presentationAnchor: self.view.window!)         .resultPublisher         .sink {             if case let .failure(authError) = $0 {                 print("Sign in failed \(authError)")             }         }         receiveValue: { _ in             print("Sign in succeeded")         } }

It isn't being caused by a missing WebDomain in the OAuth section, as mentioned in #1276
Our awsconfiguration.json looks like this (with actual values replaced by ...)
{     "UserAgent": "aws-amplify-cli/0.1.0",     "Version": "0.1.0",     "IdentityManager": {         "Default": {}     },    "CredentialsProvider":{       "CognitoIdentity":{          "Default":{             "PoolId":"...",             "Region":"..."          }       }    },    "CognitoUserPool":{       "PoolId":"...",       "AppClientId":"...",       "AppClientSecret":"...",       "Region":"..."    },    "Auth":{       "OAuth":{          "WebDomain":"...",          "AppClientId":"...",          "AppClientSecret":"...",          "SignInRedirectURI":"...",          "SignOutRedirectURI":"...",          "Scopes":[             "openid",             "email"          ]       }    } }

awsconfiguration.json is used by the legacy SDK AWSMobileClient. Can you please make sure that your amplifyconfiguration.json has the required parameters?

Yes it does as the contents are identical...

I'm assuming that  signIn(username: username, password: password) uses the same JSON configuration and changing to this rather than singInWithWebUI() works, so hosted UI is definitely broken.
Before you ask, we also have the plist changes.

Hi @meavydev, can you clarify, HostedUI not working at all, right? If that's the case, then there may be a configuration issue.
Here's the doc for parameters required when using your own configuration: https://docs.amplify.aws/lib/auth/existing-resources/q/platform/ios/ we should definitely take this opportunity to improve it once we are able to identify what configuration is mismatched.
To get a working HostedUI backend and configuraiton, you can follow these steps: https://docs.amplify.aws/lib/auth/signin_web_ui/q/platform/ios/ It will also help with cross checking against your current configuration/backend set up.
The image with the AWSMobileClient crash at 570 corresponds to https://github.com/aws-amplify/aws-sdk-ios/blob/main/AWSAuthSDK/Sources/AWSMobileClient/AWSMobileClient.swift#L570 . There seems to be some confusion around which file should be used, could you provide the configuration code that you are doing? amplifyconfiguration.json should be used with Amplify. You can make sure by deleting awsconfiguration.json.

I don't have permission to run Amplify to do the push, but I can say that the hosted UI works fine from Android and as I said using signIn works fine on iOS.
I don't have any confusion about JSONs, as I said that the contents are identical.

The same configuration works on Android but not iOS? Can you show us the configuration for amplifyconfiguration.json? The doc here shows the structure of auth.plugins.awsCogntioAuthPlugin.Auth.Deafult.OAuth. If your amplifyconfiguration.json is the same as the awsconfiguration.json you mentioned earlier then this looks incorrect:
"Auth":{
      "OAuth":{

Might need to update it to
"Auth":{
    "Default": {
         "OAuth":{

Damn... that was it.
Shame the error wasn't more useful ;)
The Android app is using the AWSConfig JSON BTW.


bug/Navigation

Year Screen to Month Screen [Always navigate to April].
Journal Edit Screen Route.
Pop up on Delete Journal Dialogue [On pop from dialogue box we need to skip dialog box as well as journalDetailScreen]

year screen route fixed


While installing infer on Ubuntu 20.04

Please make sure your issue is not addressed in the FAQ.
Please include the following information:

[ ] The version of infer from infer --version.
[ ] Your operating system and version, for example "Debian 9", "MacOS High Sierra", whether you are using Docker, etc.
[ ] Which command you ran, for example infer -- make.
[ ] The full output in a paste, for instance a gist.
[ ] If possible, a minimal example to reproduce your problem (for instance, some code where
infer reports incorrectly, together with the way you run infer to reproduce the incorrect
report).

./autogen.sh
generating m4/__GENERATED__ac_check_infer_man_last_modified.m4... ./autogen.sh: line 37: m4/__GENERATED__ac_check_infer_man_last_modified.m4: Permission denied
how to solve this error?

Hi @Vishrutidesai, sorry for the delay in replying. This looks like a problem specific to your setup where the user with which you are running ./autogen.sh does not have permission to write inside the infer repo. Did you manage to solve your issue? Optimistically closing this issue.


pydantic v2 with shim for v1

Following pattern in https://github.com/AngellusMortis/pyunifiprotect/pull/297

Codecov Report

Merging #670 (d6223f0) into main (6f68777) will decrease coverage by 0.27%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   92.51%   92.24%   -0.27%
==========================================
  Files          19       19
  Lines        1978     1987       +9
==========================================
+ Hits         1830     1833       +3
- Misses        148      154       +6

Impacted Files
Coverage Δ

google_nest_sdm/event.py
98.17% <50.00%> (-0.72%)
:arrow_down:

google_nest_sdm/model.py
88.88% <50.00%> (-11.12%)
:arrow_down:

google_nest_sdm/structure.py
88.00% <50.00%> (-7.46%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Investigate why the swagger doc, in all microservices shows the DataService "read" calls

Visiting a microservice end point with a browser shows the Swagger generated pages. For some reason they all seem to include the DataService "read" calls at the moment. This obviously shouldn't be here. Any attempt to use them on other services generates a HTTP 404 error correctly.

The Policy end-point has both POST and PUT on /, is this correct? It doesn't appear to be so from the REST spec.
All services seem to expose the DataService read calls.

Policy service is correct.
DataService being exposed due to dependency in example-model module.

merged into develop


updates to host profile for llnl systems

Description
Update to llnl host profiles for launching.
Added --exclusive to interactive srun profiles for toss4.
Removed older profiles.

[ ] Bug fix~~
[ ] New feature~~
[ ] Documentation update~~
[x] Other~~

host profile updates
How Has This Been Tested?
Testing by launching on various systems
Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

- [ ] I have commented my code where applicable.
- [ ] I have updated the release notes.
= [ ] I have made corresponding changes to the documentation.
- [ ] I have added debugging support to my changes.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] I have confirmed new and existing unit tests pass locally with my changes.
- [ ] I have added new baselines for any new tests to the repo.

[x] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

Note: --exclusive is in the wrong place in these, working on testing

the latest invocations are working, I also made a few tweaks to the proc nums


v3 release notes are nowhere to be found a month after the release

complete lack of release notes and migration guide is concerning for major breaking change bump

@iamstarkov,
Sorry for that. I just added the release note.
Thank you for pointing that out.

@meeroslav thank you


Feature request: Adding label to a vertex

I am using Ferma with JanusGraph. JanusGraph allows to set a label to a vertex. It would be awesome if Ferma could assign labels to vertices. Right now Ferma always assigns vertex label to all vertices.

I didn't find it in the Ferma documentation but found in Tinkerpop documentation. Here is how to create vertices with custom labels:
Animal animal1 =
framedGraph.addFramedVertex(new DefaultClassInitializer<>(Animal.class), T.label, "animal");


Implementing TIDE in neuralforecast

Description
Did the team consider implementing TIDE? is seems to be getting a lot of traction recently confirming its performance vis-a-vis the one in TIDE paper and it has been also implemented in Darts. Would be great to have it in neuralforecast.
Long-term Forecasting with TiDE: Time-series Dense Encoder https://arxiv.org/abs/2304.08424
Use case
No response

Sure, we'll have a look!

Duplicate of Issue #610


newResponse overwrites existing headers (e.g. set-cookie) on the local response (c.res)

What version of Hono are you using?
4.2.7
What runtime/platform is your app running on?
Cloudflare Workers
What steps can reproduce the bug?
 // file: context.test.ts

  it('Should extend the cookie headers when res already has cookie headers', () => {
    c.res.headers.append('set-cookie', 'foo=bar; Path=/')
    setCookie(c, 'foo2', 'bar2', { path: '/' })

    const res = c.json({ message: 'Hello' })

    const cookies = res.headers.getSetCookie()

    expect(cookies.includes('foo=bar; Path=/')).toBe(true)
    expect(cookies.includes('foo2=bar2; Path=/')).toBe(true)
  })

What is the expected behavior?
In my opinion, when an existing header with set-cookie exists in the response, this header shouldn't be overwritten, but added too.
file: src/context.ts:384
    if (this.#res) {
      this.#res.headers.forEach((v, k) => {
        // NOTE: Maybe only append like in `set res = (_res) ...`
        this.#headers?.append(k, v)
      })
      setHeaders(this.#headers, this.#preparedHeaders)
    }

What do you see instead?
I see the set-cookie header being completely overwritten.
Additional information
I think a discussion is needed whether we actually want to fix this or not, and what the impact might be on existing projects.
In my case, I want to be able to share the c.res to a library which might manipulate it's cookies, but these will be overwritten if I later set my own cookies.

As mentioned in additional information, a way for me to fix this after learning about some of the code in context.ts would be to do the following:

  const myLibrary = (res?: Response = new Response()) => {
    res.headers.append('set-cookie')
    return res;
  }

  it('Should extend the cookie headers when res already has cookie headers', () => {
    c.res = myLibrary(c.res);
    setCookie(c, 'foo2', 'bar2', { path: '/' })

    const res = c.json({ message: 'Hello' })

    const cookies = res.headers.getSetCookie()

    expect(cookies.includes('foo=bar; Path=/')).toBe(true)
    expect(cookies.includes('foo2=bar2; Path=/')).toBe(true)
  })

Fixed and merged https://github.com/honojs/hono/pull/2555


Not allowing to change existing number to 0

@RobinHerbots ,
Please, visit your demosilte
Now enter any amount in Currency input. After that select that amount and press 0. It will not allow, But it is working for other than 0.
I want to change entered amount into 0.
I extended Aliases as below:
Inputmask.extendAliases({
currency: {
prefix: "",
groupSeparator: "",
alias: "numeric",
placeholder: "0",
autoGroup: false,
digits: 4,
digitsOptional: true,
positionCaretOnClick: "none",
clearMaskOnLostFocus: false,
removeMaskOnSubmit: true,
autoUnmask: true
}
});

One more thing, If value is zero then we get blank while posting data. If I forcefully enter zero value then it should work. Rather it sholud always return zero insted of blank. Because, I am using numeric masking.

@RobinHerbots , If you have in work around to fix this issue please tell me. I am stuck due to this issue.
Thanks

@GaikwadVikas ,
I will fix this, when time allows.

+1 to this issue. This is the only pain point I've found so far using this plugin for doing currency input masks. For the application I'm working on, zeroing out an input is a common need.
Current workaround is "highlight and hit delete". This return 0 when the unmask() is called with the default placeholder of "0" and "unmaskAsNumber" set to true

@BLSully , thanks buddy.

Hi, does this issue have a fix or a workaround? I'm still experiencing it as a problem. Tab into a currency field and you can't enter a 0, which is a common task.

Same here. using $field.val(0); and getting an empty field.


Consider following crates.io's own semver flavour

I see in the changelog file that this crate attempts to follow semver.
AFAIK, 0.10.0 was released with no breaking changes, only a new feature.
Filing this only in case you are not aware of a couple of facts.
Semantic Versioning itself says that 0.y.z has no rules at all, and that you should not expect any 0.y.z version to be compatible with another 0.y.z version.
On the other hand, the crates ecosystem and cargo both state that it considers the leftmost non-zero number to be the major version. So 0.1.1 is compatible with 0.1.0, but 0.2.0 is not compatible with 0.1.1.
So for example, AFAIK 0.10.0 should have been 0.9.4, if the changelog file is correct.

AFAIK the important part about this is that for cargo event before version 1 patch versions shouldn't introduce breaking changes. This part is already followed by the project.
While changing the minor version is treated like a major version by cargo, this doesn't particularly hurt either.
Anyways thank you for bringing this to attention. I think we will probably update to 1.y.z in the foreseeable future at which point this all becomes irrelevant anyways.


difference between ormdantic and sqlmodel?

Great! but could you show the key difference between this library and sqlmodel?

This should probably be a discussion instead, but I'll give it a try (disclaimer: I have not spent too much time reading through both code bases, so this is not very detailed and I might be wrong in some aspects). These are the main differences I can see after a brief study:

ormdantic uses a wrapper/decorator to make pydantic BaseModels behave like database tables as well, whereas sqlmodel inherits from pydantic BaseModel and uses a modified SQLAlchemy base model as its metaclass to achieve the same thing.

In sqlmodel, the database connection is not built into the main class (SQLModel), but handled by separate equivalents of SQLAlchemy classes and functions (Session and create_engine).
Since the async equivalents are not available in sqlmodel yet, one has to use the original SQLAlchemy ext versions, which is certainly possible, but imho a bit cumbersome until SQLAlchemy 2.0 is released (type checking doesn't really work for me atm).
ormdantic takes the engine as a constructor parameter instead and creates sessions internally where needed. It is "async by default" one might say.

The aforementioned difference leads to another difference: in sqlmodel, you typically interact with both a Session object and a SQLModel object, e.g.:
...
hero = Hero()   # Hero inherits from SQLModel
session.add(hero)
await session.commit()
...

In ormdantic, you just interact with the database abstraction:
...
hero = Hero()   # Hero inherits from pydantic BaseModel and is decorated as database table
await database["Hero"].insert(hero)
...

I find the latter to be a bit more elegant/intuitive, but that's of course subjective and probably because I am used to writing SQL.

ormdantic adds pypika to the mix, sqlmodel does not seem to include it or anything similar, but that's probably an internal difference. It is an added dependency though for those who care about it.

Another difference is of course that sqlmodel is a bit more established and has the benefit of being authored by the creator of FastAPI, so on paper it should be the ORM to use with FastAPI. Unfortunately said creator has a lot on his plate and sqlmodel hasn't seen a new release for some time now. ormdantic on the other hand is of course brand new and thus unproven, but could be an exciting alternative imho.

Well, Thank you @iron3oxide for the Amazing explanation for both SQLModel and Ormdantic 🙏🏻
I will add a few things for you @0xsirsaif , is ormdantic similar to PonyORM a (Pure python queries) and that's mean the ability to write queries to the database using Python generator expressions and lambdas, Its make the close structure to writing SQL Queries but making it more easy and easy for new people to integrate it!.

Hey @iron3oxide I add your Comment to the docs, cause I find it more clear and more good comparison between the two packages!
https://ormdantic.yezz.me/faq/#difference-between-ormdantic-and-sqlmodel
Thank you so much 🙇🏻♂


shows error page when user presses on RateNow

I am very new to android, I was checking the app using an emulator (not uploaded in playstore). Am I have to add the link of playstore to open the store when the user clicked on RateNow button or it will directly go to playstore when user clicked by checking packages

Check if the image you are using is the google play version.

thanks for replying Carlos-Ferreira,
I have not understood what image I have to check the google play version.
I have checked it on the normal device its showing item not found and a button below "Retry".
is going to search in play store based on the package we are using.

Is your application already uploaded to google play store?

Could you test it on Vorlonsoft/AndroidRate Release 1.1.7. There many Appstore's options.

@TheOneMonkey  Could you please test it on Vorlonsoft/AndroidRate Release 1.1.7. There many Appstore's options.

@TheOneMonkey  Could you please test it on Vorlonsoft/AndroidRate Release 1.1.7? There many Appstore's options.


Adds UMD headers to core, display and shared files.

Now each file is a module. There are some benefits: we can track dependencies between files and various module loading systems can be used, e.g. requirejs or node. Not so good news that we have some circular dependencies to deal with (I fixed/patched couple of them), e.g. colorspace uses image and image uses colorspace. I tried not to fix or refactor anything in this PR (only stuff to make modules dependencies valid). That's just an intermediate step the clean up the dependencies.
jshint globals directives were removed where was possible. I kept only PDFJS, however in the future we can refactor that too. Notice that we may try to turn "unused" on now.
There is validation tool 'external/umdutils/verifier.js' that helps to maintain UMD headers valid. See for UMD format definition there.
Future work might include: use module loading system for the viewer, remove UMD module headers during bundling, remove src/expose_to_global.js (which was created for unit tests), split some files into smaller (e.g. core/fonts.js), refactor PDFJS global more. After this is done we can individually refactor each module and even migrate to some e.g. ES6 translator.

After this patch you can execute the following in the node.js:
var api = require('./src/display/api.js');
PDFJS.displayWorker = true; // remove that in the future
var data = require('fs').readFileSync('./web/compressed.tracemonkey-pldi-09.pdf');
var loadingTask = api.getDocument(new Uint8Array(data));
loadingTask.promise.then(function (doc) {
  console.log(doc.numPages);
});

Dependo generated graph:

Questions:

The module names are repeated 5+ times:

once in AMD
once in CommonJS
once without module loader
once in the function expression's parameters
at least once in the function body

Does your tool enforce that all of these names are consistent and follow the same convention (and briefly be documented somewhere)?

There is lots of boilerplate. Can the build tool be updated to automatically trim the duplicate information when a single-file build is generated? E.g. by only using AMD, CommonJS or the module pattern (whatever is the easiest for you).

Does your tool enforce that all of these names are consistent and follow the same convention (and briefly be documented somewhere)?

The validation of the names is done by node make lint command (see also https://github.com/yurydelendik/pdf.js/blob/module-core/external/umdutils/verifier.js#L18). It also tracks circular dependencies. The AMD names (for module id and dependencies) looks like a good candidates to be selected as primary names (it easy to map them to CommonJS path and JS object name).

Can the build tool be updated to automatically trim the duplicate information when a single-file build is generated?

Yes. The intent will be eventually to build without UMD headers -- those can be replaced by regular function closure, e.g.
(function (root, (exports, sharedUtil, displayWebGL) {
  ...
})((root.pdfjsDisplayPatternHelper = {}), root.pdfjsSharedUtil, root.pdfjsDisplayWebGL);

where root can be some local object instead of window.
Also, I think we shall remove all links to core/display/shared files and use module loaders instead (e.g. RequireJS).
(IHMO it's out of scope of this PR ATM -- I don't want to touch our build system without real need to)

Let me also re-iterate how to choose names:

for AMD module name:

almost all files at 'src/' folder shall start with 'pdfjs/' prefix followed by the relative path excluding the extension, e.g. 'src/core/pattern_helper.js' file will have 'pdfjs/core/pattern_helper' AMD module name
The dependencies shall use full module names
the name, as well as file name, shall be only lower case ASCII letter and digits, and '_' can be used

for CommonJS reference:

all references to the required modules must be relative the the current one, e.g. if 'src/core/pattern_helper.js' refers 'src/shared/util.js' the path shall be '../shared/utils.js'
the path shall start from '.' or '..' and ends with '.js'

for global/root name:

the name is based on AMD name: after each '/' character the letter is upper cased and the '/' and '_' characters removed (it's possible to uppercase other letter inside the name, e.g. pdfjsCoreColorSpace or pdfjsCorePatternHelper, but shall be consistent for a module name and its references)

import name:

the name is part of the corresponding global/root name, but without 'pdfjs' prefix and first letter is in lower case

A testing related nit: shouldn't test/unit/obj_spec.js be renamed to test/unit/primitives_spec.js, since that unit test covers code no that is moved from obj.js?

Aside from the nit above, this PR needs a rebase too after the recently landed PRs.

@yurydelendik Could you rebase this PR again? I think we should land this soon as it keeps on needing a rebase and it looks good to have modules and to drop most of the globals.

/botio-linux preview

/botio test

New 'evaluator' on 'function' dependency is added by #6723 -- fixed.

/botio test


Incremental updates

Allow incremental updates for updating systems
Outline

Use a "client-side registry" to push images to hosts.
On a bootstrap build pull all images from the deployment machine
Generate a "genesis patch" for the initial deployment
Generate incremental patches by diffing the images in the genesis patches
Upload incremental patches into running deployment servers

Patch file format
Patch files are zip files with the following contents

A VERSION file, currently with the content "floto patch v1"
A patch-descriptor.json file describing the patch itself (detailed below)
An images directory containing the docker images
a conf directory containing the root description files folder

fixed in 2.0.0


Rename fields in BeaconAlleleRequest

Rename them to:
start
referenceName
referenceBases
alternateBases
assemblyId
datasetIds

This is already a part of the draft schema as listed in #33.

Closing as there have been no objections.


IoTGoat as a container

Run IoTGoat within a docker container https://github.com/openwrt/docker

maybe see https://github.com/lefanous/iotgoat

Thank you for the pointer @Bierchermuesli :D Created an issue linked in this thread. Cheers!