Ledger Transport

Onboard.js currently defaults to the U2F transport, but this transport is broken for Windows 10 users.
Instead of defaulting to the U2F transport, we can detect the user's browser/os combination when initializing the Ledger module and dynamically import the ideal transport for that combination.
The possible scenarios and the corresponding transport:

OS: Windows 10, Browser: Firefox | IE -- Display error message informing the user to switch to a compatible browser
OS: macOS, Browser: Safari | Firefox -- Use U2F transport
All other combinations default to using the WebUSB transport

That's correct - you can also deal with Linux the same way you'd deal with macOS
Also note that while being more convenient, the U2F tunnel is still a hack, and could be deprecated at any time by the browser implementation. It is also the only transport that can be initialized without a user action on browser (typically clicking a button) - so it'd be a good practice to suggest that the websites require a user action (I believe most do)

Thanks for the additional info @btchip. The modal within Onboard.js that allows user's to select a wallet requires a user action, and that is when the transport will be initialized, so we should be all good on that front 👍


Added Sample Queries for DB Views

Let me know what other info should be useful as a view. Open to any other suggestions/feedback.

Highest winrate agent with more than x games? (finds best agent)
Highest winrate over the last x games with at least x games? (finds best recent agent)
Most improved agent? (check first x games vs current x games: must be at least x games playtime)


ollama models corrupted?

I've noticed that after running a few models, sometimes the models don't behave normally.  This is a session where that was occurring. I had first tried with bakllava but it wasn't being helpful either. But notice that after I did the systemctl restart ollama the results were much better.
Is something being corrupted in memory? I'll do what I can to help debug this.
ollama run llava
>>> look at ./classic.jpg
Added image './classic.jpg'

>>> what is it?

>>> what is ./classic.jpg
Added image './classic.jpg'

>>> hello

>>> /bye
chris@FORGE:~/ai/aiprojects/OllamaPlayground/createnotes$ systemctl restart ollama
chris@FORGE:~/ai/aiprojects/OllamaPlayground/createnotes$ ollama run llava
>>> look at ./classic.jpg
Added image './classic.jpg'
1. The Underwood typewriter is an old fashioned machine that appears to be made of wood and metal components.
2. It has a black keyboard with silver numbers on the side, giving it a vintage appearance.
3. There are several keys visible, including letters such as A, B, C, D, E, F, G, H, I, J, K, L, M and N along with numeric keys 1 through 9.
4. The typewriter sits on a table and is placed underneath the desk.

hi @iplayfast
I played and if you add image in your prompt, it's working well without restarting Ollama neither llava

what is ./image.png
Added image './image.png'

look at ./image.png
Added image './image.png'
4:01:37 PM

what is the size of ./image.png
Added image './image.png'
50,000 bytes

what is the size of this picture ./image.png
Added image './image.png'
1024x768

look at ./image.png
Added image './image.png'
6

(base) igor@MacStudiodeIgor ~ % look at ./image.png
(base) igor@MacStudiodeIgor ~ % ollama run llava

look at ./image.png
Added image './image.png'
10:54 AM

describe ./image.png
Added image './image.png'

You

describe: ./image.png
Added image './image.png'

The main class is "class AdminPanelProvider".
The code is written in C++ language.

describe: /Users/igor/image.png
Added image '/Users/igor/image.png'

COLOR: Blue

describe this image: /Users/igor/image.png
Added image '/Users/igor/image.png'

I see a large amount of computer code, which is being displayed on a black
background. The code appears to be written in a purple and yellow color
scheme, with multiple colors filling the screen. The code appears to be
written in C++ programming language, and it has a specific focus on the
administration panel. There are several instances of the word "panel"
throughout the code, indicating that this is a key element within the
program.

describe this image ./image.png
Added image './image.png'

The image is a close-up of code in black and purple, likely written using
Python. The code appears to be related to an email system, with sections
such as the "app" and "page" parts being prominent features. There are
also lines for the "frame" and "data" components within this programming
setup.

No, I've been adding images. It seems to be a corruption that accumulates over time, on the server.
The code at https://github.com/iplayfast/OllamaPlayground/tree/main/createnotes goes through all models and asks questions of them. By the time it gets to the end of the list the Ollama server is pretty much braindead.

@iplayfast I will try to run your script on a MacStation with lot of memory and see if I can reproduce the problem.

close issue as it is covered elsewhere

@iplayfast I could run your script createnotes on my Mac and Ollama stop working and my fan is on since.
Ollama is taking 97,8% of the GPU. I will test again with Ollama 0.1.18 when released to see if the issue is resolve
(modelnotes) igor@macigor-2 createnotes % python CreateNotes.py
Attempting to load each model to see if they can be loaded
attempting to load model codellama:34b
model codellama:34b loaded in 34.7 seconds
attempting to load model codellama:latest
model codellama:latest loaded in 7.9 seconds
attempting to load model deepseek-coder:6.7b-base-q5_K_M
model deepseek-coder:6.7b-base-q5_K_M loaded in 38.9 seconds
attempting to load model deepseek-coder:latest
model deepseek-coder:latest loaded in 2.4 seconds
attempting to load model dolphin-phi:latest
model dolphin-phi:latest loaded in 3.4 seconds
attempting to load model falcon:latest
model falcon:latest loaded in 7.6 seconds
attempting to load model llama2:13b
model llama2:13b loaded in 16.1 seconds
attempting to load model llama2:latest
model llama2:latest loaded in 7.0 seconds
attempting to load model llama2-uncensored:latest
model llama2-uncensored:latest loaded in 6.7 seconds
attempting to load model llava:13b
model llava:13b loaded in 14.0 seconds
attempting to load model llava:latest
model llava:latest loaded in 9.7 seconds
attempting to load model medllama2:latest
model medllama2:latest loaded in 7.7 seconds
attempting to load model mistral:latest
model mistral:latest loaded in 7.5 seconds
attempting to load model neural-chat:latest
model neural-chat:latest loaded in 7.8 seconds
attempting to load model orca2:13b
model orca2:13b loaded in 15.8 seconds
attempting to load model stablelm-zephyr:3b-q6_K
model stablelm-zephyr:3b-q6_K loaded in 6.3 seconds
attempting to load model starling-lm:latest
model starling-lm:latest loaded in 8.4 seconds
attempting to load model wizard-math:7b
Timed out after 300 seconds for question: are you there


response of the bot

Hi,
when executing a command to which to bot reacts/responses, I always get back the "id" of the bot-user first before the actual result follows.
For example: p93qj5g13tyj9fxktzg7ekctsr
Is it possible to disable this behaviour, for example with an additional environment variable? I only want the bot to reply with the result of my request.
Regards,
Simon

@smnmtzgr this should not be happening. Can you share the hubot script that you are using that exhibits this behaviour? Thx!

I am experiencing the same behaviour:
14:32 @january help
January Jones:
14:32
@gg65tw6izifspgn31p44ipbioy january adapter - Reply with the adapter
january animate me <query> - The same thing as image me, except adds a few parameters to try to return an animated GIF instead.
january echo <text> - Reply back with <text>
january help - Displays all of the help commands that Hubot knows about.
january help <query> - Displays all help commands that match <query>.
january image me <query> - The Original. Queries Google Images for <query> and returns a random top result.
january map me <query> - Returns a map view of the area returned by query.
january mustache me <url|query> - Adds a mustache to the specified URL or query result.
january ping - Reply with pong
january pug bomb N - get N pugs
january pug me - Receive a pug
january the rules - Make sure hubot still knows the rules.
january time - Reply with current time
january translate me <phrase> - Searches for a translation for the <phrase> and then prints that bad boy out.
january translate me from <source> into <target> <phrase> - Translates <phrase> from <source> into <target>. Both <source> and <target> are optional
ship it - Display a motivation squirrel

All I have done is followed the instructions from https://hubot.github.com/docs/ + https://github.com/loafoe/hubot-matteruser. No custom scripts.

@gajus @smnmtzgr ah I see. I've been using an older version of hubot-help which used the send method instead of the reply method in 0.2.0. However, this version should use Mattermost username instead of the actual user id.

Which version of Hubot are you using? 2.19.0?
Which version of MatterMost server are you using? 3.5.0?

The latest version of both.

@gajus @smnmtzgr can you try to master branch of hubot-matteruser?
git://github.com/loafoe/hubot-matteruser.git#master
It contains some changes specifically for the reply behaviour.

I will try this... stay tuned.

@smnmtzgr did it work?

It works. Thank you very much.


Do you consider Ant-Design?

Emmm.... Ant-Design is a very pretty component library, and I think webpack.js.org is not so prerry. Do you consider Ant-Design?

Using another component library will greatly bloat the pages, I think improving our own SASS would be a better and quicker option to reach any desired UI.

I am -1 for this proposal.
cc @montogeek  @EugeneHlushko

Will be great to migrate on https://github.com/facebook/docusaurus

This website doesn't need a component library, but thanks for the recommendation.


The phony option allows typing

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux

Shell

[x] bash

Problem / Steps to reproduce
Using ls | fzf --phony allows typing. If the phony option makes fzf becomes a simple selector it should not allow any typing. Is there any combo with --phony that blocks typing?

what you want is -f / --filter (filter mode . do not start interactive finder. when used with --no-sort, fzf becomes a fuzzy-version of grep) phony you can still type in the query string which lets you do stuff like searching within the contents of highlighted file for specific matches {} and other nifty stuff.i feel this is working as intended.

You might want to read #1750 to understand why we added --phony option in the first place.
Having said that, you could try something like this:
fzf --phony --bind change:clear-query

Hi, I had a question which I feel is relevant,
Is there a way to have phony mode without any prompt eg. for a simple yes/no select menu?
$ echo "yes\nno" --phony | fzf

  yes
> no
  (2/2) <<<< without these 2 lines
>|      <<<< without these 2 lines

No. You might want to check out something like https://github.com/p-gen/smenu instead.

No. You might want to check out something like https://github.com/p-gen/smenu instead.

Is there a way to copy/store the contents of the preview window? This would be useful when using {+} option and collecting chunks of text from various files.

Have you removed change-prompt as a valid action? used in many of your examples and very useful too.


{AKS} Fix azdev style issues for diagnostics & draft

This checklist is used to make sure that common guidelines for a pull request are followed.

Fix azdev style issues for diagnostics & draft (may refer to PR #7112).

Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

AKS


Reporting Page: Quick guide modals Needs actual text

Reusing this Ticket, update modal when actual text is figured out by design.
Same modal is shown for these two buttons/text blocks
icon isn't included

Designated Reporting Quick Guidebutton
https://www.figma.com/file/aAzKHh4cA6OT2t7WFv2BQ7fB/Reporting-and-Disputing?node-id=630%3A7024

Disputing Quick Guide button
https://www.figma.com/file/aAzKHh4cA6OT2t7WFv2BQ7fB/Reporting-and-Disputing?node-id=218%3A10732

There is the text for Quick guide modal
https://www.figma.com/file/aAzKHh4cA6OT2t7WFv2BQ7fB/Reporting-and-Disputing?node-id=631%3A36120

modal view over UI
https://www.figma.com/file/aAzKHh4cA6OT2t7WFv2BQ7fB/Reporting-and-Disputing?node-id=631%3A36120

@Chwy5 -- Can you add this to your radar?

Yup, is on the list for @BenDavidow to work on

@petervecchiarelli @Chwy5 @bthaile -- this got written but never included, yes?

addressed here https://github.com/AugurProject/augur/issues/4848


Translated in de-DE and de-CH

Translated ~80 spots in de-DE
Translated ~8 spots in de-CH

@Ashirg9 Could you sign our CLA so we can accept your PR?

Didn't know i had to. Thx

Thanks! merged.


ZoneAwareError

Hey guys, i've been trying to just implement the simple tutorial app with Angular2 and firebase.
Been following the guide to setting this up at https://github.com/angular/angularfire2/blob/master/docs/1-install-and-setup.md
No errors throw until I start my constructor in my app.component.ts:  :
import { Component } from '@angular/core';
import { AngularFire, FirebaseListObservable } from 'angularfire2';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.less']
})
export class AppComponent {
	title = 'app works!';
	artists: FirebaseListObservable<any[]>;

  constructor(private af: AngularFire) {

  }
}

Pretty sure everything in my app.module.ts is set up correctly:
import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { HttpModule } from '@angular/http';
import { firebaseConfig } from './../environments/firebase.config';
import { AngularFireModule } from 'angularfire2';

import { AppComponent } from './app.component';

@NgModule({
  imports: [
    BrowserModule,
    FormsModule,
    HttpModule,
    AngularFireModule.initializeApp(firebaseConfig)
  ],
  declarations: [
    AppComponent
  ],
  providers: [],
  bootstrap: [AppComponent]
})
export class AppModule { }

The error I am receiving is:
error_handler.js:54EXCEPTION: Cannot read property 'substring' of undefined
ErrorHandler.handleError @ error_handler.js:54
(anonymous) @ application_ref.js:261
ZoneDelegate.invoke @ zone.js:242
onInvoke @ ng_zone.js:273
ZoneDelegate.invoke @ zone.js:241
Zone.run @ zone.js:113
(anonymous) @ zone.js:535
ZoneDelegate.invokeTask @ zone.js:275
onInvokeTask @ ng_zone.js:264
ZoneDelegate.invokeTask @ zone.js:274
Zone.runTask @ zone.js:151
drainMicroTaskQueue @ zone.js:433
error_handler.js:59ORIGINAL STACKTRACE:
ErrorHandler.handleError @ error_handler.js:59
(anonymous) @ application_ref.js:261
ZoneDelegate.invoke @ zone.js:242
onInvoke @ ng_zone.js:273
ZoneDelegate.invoke @ zone.js:241
Zone.run @ zone.js:113
(anonymous) @ zone.js:535
ZoneDelegate.invokeTask @ zone.js:275
onInvokeTask @ ng_zone.js:264
ZoneDelegate.invokeTask @ zone.js:274
Zone.runTask @ zone.js:151
drainMicroTaskQueue @ zone.js:433
error_handler.js:60TypeError: Cannot read property 'substring' of undefined
    at Object.stripTrailingSlash [as a] (http://localhost:4200/vendor.bundle.js:81224:14)
    at _getDefaultFirebase (http://localhost:4200/vendor.bundle.js:82448:92)
    at AppModuleInjector.get (/AppModule/module.ngfactory.js:161:79)
    at AppModuleInjector.get (/AppModule/module.ngfactory.js:201:93)
    at AppModuleInjector.getInternal (/AppModule/module.ngfactory.js:272:51)
    at AppModuleInjector.NgModuleInjector.get (http://localhost:4200/vendor.bundle.js:53931:44)
    at CompiledTemplate.proxyViewClass.AppView.injectorGet (http://localhost:4200/vendor.bundle.js:72141:45)
    at CompiledTemplate.proxyViewClass.DebugAppView.injectorGet (http://localhost:4200/vendor.bundle.js:72569:49)
    at CompiledTemplate.proxyViewClass.View_AppComponent_Host0.createInternal (/AppModule/AppComponent/host.ngfactory.js:15:63)
    at CompiledTemplate.proxyViewClass.AppView.createHostView (http://localhost:4200/vendor.bundle.js:72097:21)
    at CompiledTemplate.proxyViewClass.DebugAppView.createHostView (http://localhost:4200/vendor.bundle.js:72553:52)
    at ComponentFactory.create (http://localhost:4200/vendor.bundle.js:38612:25)
    at ApplicationRef_.bootstrap (http://localhost:4200/vendor.bundle.js:36546:57)
    at http://localhost:4200/vendor.bundle.js:36365:89
    at Array.forEach (native)
ErrorHandler.handleError @ error_handler.js:60
(anonymous) @ application_ref.js:261
ZoneDelegate.invoke @ zone.js:242
onInvoke @ ng_zone.js:273
ZoneDelegate.invoke @ zone.js:241
Zone.run @ zone.js:113
(anonymous) @ zone.js:535
ZoneDelegate.invokeTask @ zone.js:275
onInvokeTask @ ng_zone.js:264
ZoneDelegate.invokeTask @ zone.js:274
Zone.runTask @ zone.js:151
drainMicroTaskQueue @ zone.js:433
zone.js:420 Unhandled Promise rejection: Cannot read property 'substring' of undefined ; Zone: <root> ; Task: Promise.then ; Value: TypeError: Cannot read property 'substring' of undefined
    at Object.stripTrailingSlash [as a] (http://localhost:4200/vendor.bundle.js:81224:14)
    at _getDefaultFirebase (http://localhost:4200/vendor.bundle.js:82448:92)
    at AppModuleInjector.get (/AppModule/module.ngfactory.js:161:79)
    at AppModuleInjector.get (/AppModule/module.ngfactory.js:201:93)
    at AppModuleInjector.getInternal (/AppModule/module.ngfactory.js:272:51)
    at AppModuleInjector.NgModuleInjector.get (http://localhost:4200/vendor.bundle.js:53931:44)
    at CompiledTemplate.proxyViewClass.AppView.injectorGet (http://localhost:4200/vendor.bundle.js:72141:45)
    at CompiledTemplate.proxyViewClass.DebugAppView.injectorGet (http://localhost:4200/vendor.bundle.js:72569:49)
    at CompiledTemplate.proxyViewClass.View_AppComponent_Host0.createInternal (/AppModule/AppComponent/host.ngfactory.js:15:63)
    at CompiledTemplate.proxyViewClass.AppView.createHostView (http://localhost:4200/vendor.bundle.js:72097:21)
    at CompiledTemplate.proxyViewClass.DebugAppView.createHostView (http://localhost:4200/vendor.bundle.js:72553:52)
    at ComponentFactory.create (http://localhost:4200/vendor.bundle.js:38612:25)
    at ApplicationRef_.bootstrap (http://localhost:4200/vendor.bundle.js:36546:57)
    at http://localhost:4200/vendor.bundle.js:36365:89
    at Array.forEach (native) TypeError: Cannot read property 'substring' of undefined
    at Object.stripTrailingSlash [as a] (http://localhost:4200/vendor.bundle.js:81224:14)
    at _getDefaultFirebase (http://localhost:4200/vendor.bundle.js:82448:92)
    at AppModuleInjector.get (/AppModule/module.ngfactory.js:161:79)
    at AppModuleInjector.get (/AppModule/module.ngfactory.js:201:93)
    at AppModuleInjector.getInternal (/AppModule/module.ngfactory.js:272:51)
    at AppModuleInjector.NgModuleInjector.get (http://localhost:4200/vendor.bundle.js:53931:44)
    at CompiledTemplate.proxyViewClass.AppView.injectorGet (http://localhost:4200/vendor.bundle.js:72141:45)
    at CompiledTemplate.proxyViewClass.DebugAppView.injectorGet (http://localhost:4200/vendor.bundle.js:72569:49)
    at CompiledTemplate.proxyViewClass.View_AppComponent_Host0.createInternal (/AppModule/AppComponent/host.ngfactory.js:15:63)
    at CompiledTemplate.proxyViewClass.AppView.createHostView (http://localhost:4200/vendor.bundle.js:72097:21)
    at CompiledTemplate.proxyViewClass.DebugAppView.createHostView (http://localhost:4200/vendor.bundle.js:72553:52)
    at ComponentFactory.create (http://localhost:4200/vendor.bundle.js:38612:25)
    at ApplicationRef_.bootstrap (http://localhost:4200/vendor.bundle.js:36546:57)
    at http://localhost:4200/vendor.bundle.js:36365:89
    at Array.forEach (native)
consoleError @ zone.js:420
_loop_1 @ zone.js:449
drainMicroTaskQueue @ zone.js:453
zone.js:422 ZoneAwareError {__zone_symbol__error: Error: Uncaught (in promise): TypeError: Cannot read property 'substring' of undefined
TypeError: Ca…, rejection: TypeError: Cannot read property 'substring' of undefined
    at Object.stripTrailingSlash [as a] (ht…, promise: ZoneAwarePromise, zone: Zone, task: ZoneTask}
consoleError @ zone.js:422
_loop_1 @ zone.js:449
drainMicroTaskQueue @ zone.js:453
bridge.js:1 Connecting to PORT_NAME_SYMANTEC_PKI_CLIENT_CONTENT_TO_BACKGROUND...
bridge.js:1 Connected: Port {}
bridge.js:1 Done.
detection.js:1 +content/detection.js
detection.js:1 -content/detection.js

It only seems to break when I pass in af into the constructor argument. Any help would be greatly appreciated. Or if more details are needed please let me know.
Thanks!

@Orkish You're not following issue template, so it's difficult to analyse your problem. I just followed the tutorial and it works absolutely fine for me.
This is my configuration on windows 7 operating system
angular-cli: 1.0.0-beta.28.3
node: 6.9.1
os: win32 ia32

"angularfire2": "^2.0.0-beta.7",
"firebase": "^3.6.9"

What's your's ? It will be easy, if you can follow the issue template and provide all information.

@mukesh51 Sorry about that:
angular-cli: 1.0.0-beta.28.3
node: 7.4.0
os: darwin x64

"angularfire2": "^2.0.0-beta.7",
"firebase": "^3.6.9"

So I think this may be an issue with how I initially installed it. Tried it on a different machine and it worked just fine. Just confused by the zone issue. Maybe I need to update my zone js?
Thanks!

@Orkish Great to hear, it's working. If everything is OK, I guess you can close this issue.

@mukesh51 It's still not working on my local machine and I cannot figure out why. I've done same step on a different machine and it works. Let me try to figure this out then i'll create an in depth review of my issue/solution

Fair enough. This is how my package.json looks like and is working locally. let me know, how it works out for you.
"dependencies": {
    "@angular/common": "^2.3.1",
    "@angular/compiler": "^2.3.1",
    "@angular/core": "^2.3.1",
    "@angular/forms": "^2.3.1",
    "@angular/http": "^2.3.1",
    "@angular/platform-browser": "^2.3.1",
    "@angular/platform-browser-dynamic": "^2.3.1",
    "@angular/router": "^3.3.1",
    "angularfire2": "^2.0.0-beta.7",
    "core-js": "^2.4.1",
    "firebase": "^3.6.9",
    "rxjs": "^5.0.1",
    "ts-helpers": "^1.1.1",
    "zone.js": "^0.7.2"
  },
  "devDependencies": {
    "@angular/compiler-cli": "^2.3.1",
    "@types/jasmine": "2.5.38",
    "@types/node": "^6.0.42",
    "angular-cli": "1.0.0-beta.28.3",
    "codelyzer": "~2.0.0-beta.1",
    "jasmine-core": "2.5.2",
    "jasmine-spec-reporter": "2.5.0",
    "karma": "1.2.0",
    "karma-chrome-launcher": "^2.0.0",
    "karma-cli": "^1.0.1",
    "karma-jasmine": "^1.0.2",
    "karma-remap-istanbul": "^0.2.1",
    "protractor": "~4.0.13",
    "ts-node": "1.2.1",
    "tslint": "^4.3.0",
    "typescript": "~2.0.3"
  }

I dont think it's my package json, it might be something deeper. Am looking.

Seems like my work computer is behind some sort of endpoint protection which prevents the completion of the handshake with firebase API. Even after shutting down my firewall and syematec protection, the connection was still refused.
This has nothing to do with the actual library or the tutorial.
Thanks for bearing with me.
Closing issue

Having the same problem:
TypeError: Cannot read property 'substring' of null
    at stripTrailingSlash (main.js:4)
    at _getDefaultFirebase (main.js:5)
    at t.get [as _FirebaseConfig_56] (main.js:115)
    at t.get [as _AngularFire_64] (main.js:115)
    at t.get [as _FirebaseProvider_93] (main.js:115)

only when I am building Ionic2 bundle in the release/prod mode.
"angularfire2": "2.0.0-beta.7",
"firebase": "3.4.0"

Hi, I am also having similar zone aware error.
package.json
"dependencies": {
"@angular/common": "~2.4.0",
"@angular/compiler": "~2.4.0",
"@angular/core": "~2.4.0",
"@angular/forms": "~2.4.0",
"@angular/http": "~2.4.0",
"@angular/material": "^2.0.0-beta.2",
"@angular/platform-browser": "~2.4.0",
"@angular/platform-browser-dynamic": "~2.4.0",
"@angular/router": "~3.4.0",
"angular-in-memory-web-api": "~0.3.1",
"angularfire2": "^2.0.0-beta.8",
"core-js": "^2.4.1",
"firebase": "^3.7.2",
"rxjs": "5.2.0",
"systemjs": "0.20.10",
"zone.js": "^0.7.8"
},
"devDependencies": {
"concurrently": "^3.2.0",
"lite-server": "^2.2.2",
"typescript": "~2.2.1",
"canonical-path": "0.0.2",
"tslint": "^4.5.1",
"lodash": "^4.16.4",
"jasmine-core": "~2.5.2",
"karma": "^1.3.0",
"karma-chrome-launcher": "^2.0.0",
"karma-cli": "^1.0.1",
"karma-jasmine": "^1.0.2",
"karma-jasmine-html-reporter": "^0.2.2",
"protractor": "~5.1.1",
"rimraf": "^2.5.4",
"@types/node": "^7.0.8",
"@types/jasmine": "2.5.46"
},

Just started with Angular2, MD, Firebase.  Able to run the initial app running but without firebase.  The moment I import angularfire2 then the app fails with the above screenshot of 404 (not found).
Appreciate any help to resolve.  I am running in Mac.

So if you made sure your packages all matched up with what I have and what the above commenter has first. If you're still getting the zone issue then I would recommend you nuke your node_modules directory and reinstall everything.
My issue was a bit unique in that my work laptop prevents certain connections for happening. Even after I've disabled my firewall and symtec protection, the connection to the firebase api was still not connecting. If you read into the actual error, it should say which service is blocking it.
I tried on a coworker's computer starting the same project from scratch and he ran into the issue as well with firebase. However, when I ran it on my personal machine, I was able to successfully retrieve data from firebase no problem.
So, if all else fails, see if it's a security issue that's throwing the error.
Thanks, hope this helps.

Did the following:
rm -rf node_modules
npm clean cache
npm install
npm start

The web browser started but throws the above screenshot error again.   For some reason the app is not able to find angularfire2 to load.  Not sure where to specify to look for angularfire2.
In fact today morning only I created a new repository and installed one by one AJS2, MD2, FB2.  without FB2 the app works fine.

I did managed to run the app after a few try.
I tried to follow the link https://medium.com/codingthesmartway-com-blog/angular-2-firebase-introduction-b4f32e844db2#.89d12414s which worked perfectly fine without any issue.
Thanks.

I had an issue with loading angularfire2 with Ionic. I had my config messed up, instead of databaseURL I had databaseUrl. Only figured it out when I looked at the Javascript file that produced the error.

I experienced the same issue. Was using 0.7.6. Rolling back to "zone.js": "^0.7.2" fixed the issue. Eventually, rolled back to 0.6.8 to match the same version that Angular had listed in its dependencies.
I suspect that if you install a version that is different from the one that Angular depends on, it's going to cause issues.


[mesheryctl] Docker Extension release broken: bad .zip bundle reference

See mesheryctl Command Tracker for current status of commands.
Current Behavior

Desired Behavior

Screenshots/Logs

Environment

Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

📚 mesheryctl Contributing Guide
📺 Beginner's guide to contributing to Meshery and mesheryctl
⌨ mesheryctl Command Tracker
⌨ Meshery CLI Commands and Documentation
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@nishantwrp heads-up

Fixed by #5983


Smart field completion for arrays

macOS Mojave 10.14.6 (18G95)
Install LSP via Package Control
Sublime Text 3.2.1 3207
Reproduction

Install LSP
Install typescript-language-server via npm install -g typescript-language-server (must be this one as javascript-typescript-langserver does not support field completion).
Copy boilerplate code below, and observe the same.

Descriptiom
In VSCode the default Typescript completion converts access to array indices into their proper syntax [n] from variable.n.
Expected behaviour (VSCode)

Actual behaviour (Sublime Text)

Could you enable "log_payloads": true and "log_debug": true in your LSP settings and post the payload of the completions here? The extra debugging output is sent to the SublimeText console.

One completion:
{
'sortText': '0', 'label': '0', 'kind': 10, 'insertText': '[0]',
'textEdit': {
  'newText': '[0]',
  'range': {'start': {'line': 76, 'character': 3}, 'end': {'line': 77, 'character': 0}}}
}

LSP would like to fix the edit, but doesn't recognise the leading ..
LSP: could not find completion item for inserted ".[0]"
This feels similar to #714 where skipping the trigger character when looking for inserted text has the right effect.


Pass TimetableItem instead of passing many parameters

Issue

close #326

Overview (Required)

Pass TimetableItem instead of passing many parameters

Links

Nothing

Screenshot
There is no change in layouts.
Japanese

before
after

English

before
after

Can you resolve the confict?

@takahirom
Could you review this again?
I resolved the conflicts and run ./gradlew spotlessKotlinApply.


Pagination

Is there a way to request different pages? I know we can set a limit for searches and other things, but it'd be nice to set a limit and page. We'd like to be able to get the first 100 results, then the 2nd 100 results is a separate call. Is there any way to do that currently? If not, are there plans to add this in?

The problem is that Pinterest doesn't provide pagination. With every request it returns bookmarks - an offset string to get the next batch of the results. There is no way to get the second batch, without going through the first one.
I think I can implement something like this:
$results = $bot->pins->search('query', 100)->skip(100)->get();

But behind the scenes, a bot will go through the first 100 results.

@codingmusician, done! In version 5.1.2 you can use pagination as I mentioned above:
// to skip first 100 results
$results = $bot->pins->search('query', 100)->skip(100)->get();

Awesome! Thanks!


Added documentation to Utils; improved readability

Improved readability of the magic numbers being used in background color algorithm

4 is now colorSectionMax (maximum amount of characters in each section)
1 is now colorSectionMin (minimum amount of characters in each section)

lgtm


Add a stack trie for unknown compile id compile sites

Signed-off-by: Edward Z. Yang<EMAIL_ADDRESS>

Stack from ghstack (oldest at bottom):

(to be filled)


Fix notebook_launcher

The decorators in the Accelerator object still were initialing the Accelerator on import, leading to issues when using the notebook_launcher (as seen in https://github.com/huggingface/accelerate/issues/1119). This PR fixes https://github.com/huggingface/accelerate/issues/1119 by rewriting the decorators again to follow the _inner pattern. Note that this is only needed on the Accelerator, for the self-decorators. This isn't needed for the PartialState elsewhere.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Separate optional packages by JDK versions

Separate optional packages into different modules with explicit jdk versions to compile against. JVM vendor specific implementations must be supported as well.

merged via #1824


Alternative to CRNA - Update Documentation

The Quick Start recommends using create-react-native-app, though it has been merged with expo CLI. I really want to build my first RN app, but without using expo. So, how do we get started now? Any tips? Please update the documentation 😄

create-react-native-app now is deprecated in favor of expo-cli. But expo-cli by default builds your app on their servers, which is a no-go for most companies.
I normally use react-native init to start, but wonder why this isn't reflected in the react-native docs.

create-react-native-app now is deprecated in favor of expo-cli. But expo-cli by default builds your app on their servers, which is a no-go for most companies.

It doesn't default to this, you can do this if you need an account but if you'd like to build it on your own you can do this stuff or detach/eject.
I don't think it's a no-go for most companies to do this either, many companies use CI services like CircleCI to run builds, it's no different in this case.

@nicostuhlfauth I think you can close this issue


LiveStream behavior with pause() and start()

I implemented the livestream and want to be able to pause and restart Quagga without reloading my page. Leaving Quagga running after I've accepted a code makes my UI very laggy on my target device (Low end android tablet with limited specs).
I call Quagga.pause() which seems to go normally, but then when I attempt to call Quagga.start() again Quagga throws an exception. I'm running Quagga in an Angular 2 component, so my workaround right now is to get rid of the entire component when scanning is done and then reinitialize every time I've finished processing the scanned code. This is not a good solution because Quagga then has to request permission to access the camera every time.
Error:
ORIGINAL EXCEPTION: _framegrabber is undefined
Last few calls in the stack:
update@https://cdnjs.cloudflare.com/ajax/libs/quagga/0.11.5/quagga.js:4244:14
frame@https://cdnjs.cloudflare.com/ajax/libs/quagga/0.11.5/quagga.js:4272:18
startContinuousUpdate@https://cdnjs.cloudflare.com/ajax/libs/quagga/0.11.5/quagga.js:4267:16
_start@https://cdnjs.cloudflare.com/ajax/libs/quagga/0.11.5/quagga.js:4281:10```

I've been working on a reproduction to see what causes this, and it seems related to using Angular's @ViewChild decorator to call functions inside the Quagga component. Calling pause() and start() in the component work just fine, but calling from the parent breaks things.

Can you told me how you start using quaggaJS I dont understand... :(


Better debug routes

w.r.t #2568
Description
made changes to make it live on Monday 24th Feb
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

Thanks @atishamte and @enix-app


Make Named Operation parameters appear in vertical list

Wrapping the Named operation parameters means that space is wasted in the UI. For Named views, this parameter wrapping is okay because of the limited space available. However for Named operations, we should use a vertical layout as this creates a more natural flow for the user.

Hey, I would like to work on this issue.

Go for it!

Hi, I'd like to try this.

I have the road traffic example ui loaded up but there are no named operations for this. How do I get a named operation so I can see what the UI currently looks like for named operations. Is there another ui script I can run that has named operations? Otherwise #288 needs completing first.

You can add a named operation via the REST service (which is hosted at localhost:8080/rest when you run the start script).
There's some examples of NamedOperations in the docs:
https://gchq.github.io/gaffer-doc/getting-started/operations/namedoperation.html

Merged into develop


May I ask how to specify the quantity of comments displayed by default?

I want to specify the quantity of comments displayed by default, so that I can make the comment area not so long.
However, I didn't find where to do this.

There is no such option and I'm not planning to add it.

Ok I see, thanks.


Long press IR button

Hi,
Sorry if this is the wrong place to ask this.
My aircon units have a single power button on the remote - for turning on and off.  I can turn the aircon on using the BASE64 code I learnt.  However, I cannot turn it off again.  I can actually replicate this manually using the remote control.  To turn the unit off I need to hold the power button down for twice as long as when turning it on.  I have no idea why this is, but it happens on two of the same brand units (Daikin).
Is there a way to simulate a long press of the power button?  I have tried larger values of 'repeat' in the json as below but it doesn't seem to have any effect
msg.payload = {
    "mac": remote.mac,  // Optional if configured in the RM node
    "host": remote.ip,  // Optional if configured in the RM node
    "action": "send",
    "data": command.power,
    "repeat":2
};

Thanks very much!
Adrian

Actually, the repeat function had never been set up to do anything as far as I can see from the original code. I will need to look into it and see.
In the meantime, had you tried tying two RM Nodes together and send it twice? Just to see if that works? Or had you tried recording the long press command in case it does something different?

Thanks for the reply :)
I hadn't tried stringing two nodes together.  Good idea... I'll give that a go.
I've tried recording the long press via HomeAssistant before and it just gets the same code.
Cheers,
Adrian

Update:  Tried chaining a bunch of nodes together but the aircon unit sees them as lots of single press events and it doesn't turn off :(

Not sure if this will work for you, but when I use a long press with my Samsung TV, it's so long that it gets truncated by node-red's debug. BUT, when you are watching the console, the entire message comes through, and that worked for me! Long press was definitely a different code than multiple presses.


docs(readme): refer pure to React.PureComponent

See React.PureComponent.
May also consider removing the reference to the deprecated PureRenderMixin.

Codecov Report

Merging #454 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   88.86%   88.86%
=======================================
  Files          53       53
  Lines         386      386
=======================================
  Hits          343      343
  Misses         43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c3fb48...b89cb2f. Read the comment docs.

Thanks! I'll accept the PR after removing PureRenderMixin.

@wuct Removed reference to PureRenderMixin. Thanks!

@AndersDJohnson merged, thank you!


Console extra Proxy and JX improvements

Tolerate Proxy setup errors in case Proxy throws (= disabled).
Fix bug in JX encoding error handling.  Incorrect quote marks caused value to be number coerced (+v) rather than string coerced (''+v).

No releases entry because bug not published.


Update .eslintrc.js

Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements (place an x in each [ ])

[ ] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[ ] I've read and agree to the Code of Conduct.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello, did you intentionally create this pull request? Please allow us to close this after waiting for your response for a while.

Hello, did you intentionally create this pull request? Please allow us to close this after waiting for your response for a while.

Thanks a lot for your interest on the contribution to this project. If you have an idea for making this project better in the future, we are always happy to know your thoughts!


Make NLogTarget's TelemetryClient accessible

For example, I'd like to be able to do this:
ApplicationInsightsTarget ai = (ApplicationInsightsTarget) LogManager.Configuration.FindTargetByName("ai");
ai.TelemetryClient.GetMetric(...);

I don't see anything wrong with this as an enhancement.
As a workaround so no one is blocked,
You can create your own TelemetryClient in the same way that we do:
https://github.com/Microsoft/ApplicationInsights-dotnet-logging/blob/5dcd1168d7ed24adb14a9473cb73d2b52b9c3c64/src/NLogTarget/ApplicationInsightsTarget.cs#L113-L122

@dorfire what's wrong with @MS-TimothyMothra suggestion of creating your own telemetry client off the same config?

Nothing particularly wrong with it, but I'd like to re-use the existing client.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Sergey Kanzhelev<EMAIL_ADDRESS>Sent: Tuesday, November 20, 2018 9:31:40 AM
To: Microsoft/ApplicationInsights-dotnet-logging
Cc: Dor Fire; Mention
Subject: Re: [Microsoft/ApplicationInsights-dotnet-logging] Make NLogTarget's TelemetryClient accessible (#234)
@dorfirehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdorfire&data=02|01|dorfire%40microsoft.com|5d2641dba2714361656808d64f0e08d1|72f988bf86f141af91ab2d7cd011db47|1|0|636783319026630801&sdata=jZ4rvDvx0uTAIBhWdi3MrwNtM%2FI6ZUy7U1d3i4UalEY%3D&reserved=0 what's wrong with @MS-TimothyMothrahttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMS-TimothyMothra&data=02|01|dorfire%40microsoft.com|5d2641dba2714361656808d64f0e08d1|72f988bf86f141af91ab2d7cd011db47|1|0|636783319026630801&sdata=bPM8So3b%2FMQ1BTsu%2BezCMLeGfPSop6UvT7VFhAC5YFA%3D&reserved=0 suggestion of creating your own telemetry client off the same config?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FApplicationInsights-dotnet-logging%2Fissues%2F234%23issuecomment-440361253&data=02|01|dorfire%40microsoft.com|5d2641dba2714361656808d64f0e08d1|72f988bf86f141af91ab2d7cd011db47|1|0|636783319026630801&sdata=d%2B7XVe%2FqeQnYfyJtdKdFxG1jB3Gvfyle%2BnP6G7ybtkI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABbgq6t-9TOvjqPQFD_mQiWkU_Jr4QqXks5uxDx8gaJpZM4Yp9bI&data=02|01|dorfire%40microsoft.com|5d2641dba2714361656808d64f0e08d1|72f988bf86f141af91ab2d7cd011db47|1|0|636783319026630801&sdata=ZNcmwY4r%2BcpJyfqEiuOhJTcqrmxGdABp68jLjtfpqtM%3D&reserved=0.

Created  #235 as an attempt to resolve this

Reusing is not a good idea as that telemetry client sets specific SDK version which helps troubleshoot. So if you remote metrics with the same client - it will be identified as NLog metrics which will confuse everybody. TelemetryClient is intentionally very cheap to instantiate.
I'm closing this PR and issue. Please let me know if you have a reason to reuse.


Update add_fields.md

Thanks for pull request!

The default search field will be fields.mapping.message irrespective of fields specified in message_format. So specifying fields.mapping.message is mandatory. If the user want to search/filter by additional fields specified in message_format, she/he needs to explicitly specify the field name in search box . e.g. info.Component:value


drag-and-drop feature

Very interested in the evolution of this project, I use Hammerspoon at the moment, but would love to switch once the experience more closely resembles that of awesome wm, which I use on Linux. I do have a question.
From the README:

The other option is to make the window floating and manually move it with the mouse, then un-float it.
Moving a window directly with the mouse WILL BREAK the window-trees of both monitors.

Why not check if the window is already in floating state when mouse dragging is initiated and switch to floating state automatically if it isn't to prevent tree breakage? Is it a technical limitation, conflict with another feature or just hasn't been done yet?

Haven't looked into it too much, however I'm pretty sure there is a technical limitation. The moment the user initiates mouse dragging, the mouse move event that I track using event taps no longer gets called.

I did some testing and if the window is simply dragged to another monitor, the window tree of the monitor that the window was previously on, will be incorrect - the new monitor tiles as expected.
However, what you can do is move the window on the current screen to make it floating, instead of using a hotkey.


issue with mix-blend-mode on canvas element

Hi,
I came across an issue using mix-blend-mode: multiply on the canvas element. Everything works fine except for the first seconds. Here's a quick .GIF to show the issue:

Pretty strange, I have to admit.. After some time (like a few seconds without dragging) or at the end of the first drag, the mix-blend-mode takes effect and the white is being removed. Then we don't have this clearRect 'looking-like' issue.
Any ideas? Thank you a lot!

I don't know about putting mix-blend-mode on the canvas, but it seems to work fine when you put it on the containing div you give to OpenSeadragon. Here is a Codepen:
http://codepen.io/iangilman/pen/GoLxdX
Works great for me from the first moment (tested on Mac Chrome and Firefox).

Thank you for your quick answer! Figured out to make it work by applying the CSS property with JS.
I'm going to close this as I think it might be a bug that's maybe not related to OpenSeadragon...
Thank you :)


Add logger for FindCommandParser and update find sequence diagram

Changed find sequence diagram as well

Looks good to merge


[W05][W09-4]Sim Jia Zhi

Added PersonSorter Comparator to sort records by name
Added case-insensitive Sort command
Updated User Guide to include section for Sort command
Added JUnit and CLI test cases for Sort command

A good and concise application making use of Java's built in sorting function of collections.
A well attempt to add a new feature while maintaining the overall structure of code and OOP principles.

@simjiazhi
Some comments added. Please take note and close the pull request.


fix: event poster build error on doc workspace

Fixes: #[Add issue number here]
An exception occurs when building an event poster in the docs workspace and the Hooks need to be removed.
Changes:

Screenshots of the change:

wait, some build error

@guoqqqi need any update?

At the moment I can't use Hook in the documentation, which is causing me some pain when using window.session, do you have time to troubleshoot this further?


Add github action to automatically build and publish latest docker images on new tags

Done, creating a github tag like 1.0.3 will start the github action to build and publish the docker image


Update helix instructions

I helped someone on Reddit with setting up ols/odinfmt with helix today.
The instructions on the website aren't quite right, and can actually be simplified as per this PR.
I don't use Odin myself, just helping out.

Thanks for the help!


Replace tabs with 8 empty spaces in integration tests

Signed-off-by: Chun Chen<EMAIL_ADDRESS>

@chenchun It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to https://github.com/docker/libnetwork/issues/1926


Fix test runner (npm test)

This fixes npm test. We need to use react-scripts 2+ to be able to use jest + enzyme, per
https://github.com/facebook/create-react-app/issues/4215#issuecomment-378330144. They won't be fixing it for the react-scripts 1.x branch.

FYI I tested npm test and npm run-script build. No problems with the react-scripts upgrade 👍

@mynameistechno are you comfortable doing a major version change for react-scripts? and to a non-released version? I looked through the changes in the package-lock file and there appear to be some pretty extensive changes as a result of the update. Not against this but would like to be sure we are not taking on some additional risks. For example, the creators note of the alpha builds warning: they're somewhat unstable in the cited issue.
They also note that there are some other workarounds. Can we use some of them? Is there a different way to run the tests?

@jeffmcaffer we've been using it with a couple projects no problem (so far). That unstable comment was from April though. I think they are waiting for Babel 7 to go stable to release 2.0 at the same time. If you can wait a few days I can try something else that I think may work.

What was the exact issue?
If the tests were not passing, at the moment they do.
2a4b4c22928f376ea591e2fceeb135ec5d433e11 (last commit on master)
 PASS  src/components/__tests__/App.test.js (6.866s)
 PASS  src/components/__tests__/PageInspect.test.js (6.883s)

Test Suites: 2 passed, 2 total
Tests:       12 passed, 12 total
Snapshots:   0 total
Time:        7.896s
Ran all test suites.

This is what I get when on master (running on mac os):
~/p/c/website ❯❯❯ npm test
><EMAIL_ADDRESS>test /Users/mmatyas/projects/clearlydefined/website
> react-scripts test --env=jsdom

2018-08-14 16:34 node[33942] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2018-08-14 16:34 node[33942] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2018-08-14 16:34 node[33942] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2018-08-14 16:34 node[33942] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:183
      throw er; // Unhandled 'error' event
      ^

Error: Error watching file for changes: EMFILE
    at _errnoException (util.js:1024:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1351:9)
npm ERR! Test failed.  See above for more details.

https://github.com/facebook/create-react-app/issues/4215#issuecomment-378330144
Appears to be related to the watch functionality. As gaeron mentions, upgrading to react-scripts (which upgrades jest) fixes the issue. Am I the only seeing the error? You guys using linux/windows?

@dabutvin can you try a run of npm test in the website repo on you Mac and see if you can repo @mynameistechno 's problem?

well "good" I guess. At least it is reproducible. So we need to ensure that Mac-based devs can work on the website. I'm just not sure how to really validate that the upgrade to the alpha react-scripts is the right thing.  There could be so many subtle side effects and it is still alpha. Sucks not having a decent test suite.

FWIW I've been using the alpha version of react-scripts internally for a few weeks and the test and build commands have been working fine so far.
There is another work around that is not ideal, but might do until react-scripts 2 is out of alpha. The react-scripts repo has added a note on this issue in their readme with a suggestion: https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-test-hangs-on-macos-sierra
Several people reported that installing watchman using brew , i.e.  brew install watchman fixed it for them. I can confirm this works. So maybe we just add a note for mac users that links to the above section in our readme?

I tried on a Docker container (Node 10.x) to test if it tests worked on my laptop environment because I had some special version of watchman or something else:
$ docker pull node
...
Status: Downloaded newer image for node:latest
$ docker run -it node bash
@4c383e1c819e:/#

# (now we are inside the docker container)

$ git clone https://github.com/clearlydefined/website.git
$ cd website/
$ npm install
$ npm test
# all fine and dandy 🙂

$ exit
# (back on your host)

# to remove the container
$ docker rm __the_docker_container__

@mynameistechno have you tried to (re)install watchman?

https://github.com/facebook/jest/issues/3436#issuecomment-299894570
https://stackoverflow.com/a/41661452/728287

I have the latest (released in Aug 2017):
$ brew info watchman
watchman: stable 4.9.0 (bottled), HEAD

https://facebook.github.io/watchman/docs/release-notes.html

Could it be because jest is not a dependency?

Due to the fact that we used create-react-app, react-scripts manages jest as it's own dependency. To get around this we'd have to "eject" react-scripts, but then we might have other concerns to worry about, like having to manage the webpack config ourselves, and we'd lose out on any benefits react-scripts 2.0 will get us for free. I guess we might be able to use npm shrinkwrap to force jest to be a certain version.

I tried on a Docker container (Node 10.x) to test if the tests worked on my laptop environment because I had some special version of watchman or something else:

The issue in only present in OS X (I think Sierra only?)

@mynameistechno have you tried to (re)install watchman?

Yes installing watchman fixes it, but this is more of a hack, and less than ideal as the real issue appears to be a bug in the version of Jest that react-scripts v1 is pinned to. They won't upgrade jest in v1 due to a change that breaks BC, so they recommend upgrading to react-scripts v2 (which is in alpha), or try one of the workarounds, like installing watchman.
At this point the easiest thing to do is for me to just add a note to the readme website about this issue on mac os, and point them https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-test-hangs-on-macos-sierra, which recommends installing watchman. Once react-scripts 2.0 ships we can remove the note. @jeffmcaffer thoughts?

At this point I'd rather document the issue and workaround than take all the change and then the risk associated with being on an alpha of a foundational piece. I think in a few weeks we should regroup and consolidate a bunch of refactorings and version upgrades. This should be one of the things considered.
Do you want to just change this PR to add the doc in the README? We should also add some notes in https://github.com/clearlydefined/clearlydefined where we talk about the easy setup (https://docs.clearlydefined.io/contributing-code). Perhaps just a pointer there to the canonical guidance in the README here?

Do you want to just change this PR to add the doc in the README? We should also add some notes in https://github.com/clearlydefined/clearlydefined where we talk about the easy setup (https://docs.clearlydefined.io/contributing-code). Perhaps just a pointer there to the canonical guidance in the README here?

Sounds good.

Added a note to https://github.com/clearlydefined/clearlydefined/issues/80 to update the doc fro this.
closing this PR


Allow upgrade app

Small update to allow upgrade application with Winget-Install if application is already install.
I use this patch to upgrade application with GLPI.
Regards,
PS : congratulations on this project

Nice trick :) thanks. May I ask you the same changes on the WAU repo? This way you get credited automatically ;)
https://github.com/Romanitho/Winget-AutoUpdate/blob/main/Sources/WAU/Winget-AutoUpdate/Winget-Install.ps1


Make prow job system architecture configurable

Issue #, if available:
https://github.com/aws/eks-distro-internal/issues/240
Description of changes:
Add an option to specify an architecture to EKS-D prow jobs. This defaults to AMD64.
This will specify a node selector which corresponds to the architecture of the underlying node.
A forthcomming PR will include full support for ARM64 node selectors and updates to the docs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


EDM-649: Update CSR error codes to be more expressive and accurate

This is built on #616 - the only new commit in this PR is ad51a197548aaf1c36beea02532dd28f56c9bd42.
Will probably remove the error conversion (commented out) because it doesn't preserve the original error message. Instead of this we can choose an error code to represent the range of errors possible from Approve: 400, 401, 404, 409, 500. Thoughts?
The new 500 error on POST may or may not be necessary depending on the decision on above.

Will probably remove the error conversion (commented out) because it doesn't preserve the original error message. Instead of this we can choose an error code to represent the range of errors possible from Approve: 400, 401, 404, 409, 500. Thoughts?
The new 500 error on POST may or may not be necessary depending on the decision on above.

A "500 - Internal Server error" means we've got a programming error, we should never deliberately return that and when we return it when catching an exception we must not leak implementation details by returning Golang error from deep down the service.
Let's think through the error cases:
When a user creates a CSR (POST to /api/v1/certificatesigningrequests), the only return codes can be

200 - OK
400 - Bad Request: only when the request did not pass Validation().
401 - Unauthorized
When a user updates a CSR (PUT/PATCH to /api/v1/certificatesigningrequests/{name}), the only return codes can be
200 - OK
201 - Created
400 - Bad Request: only when the request did not pass Validation(), including trying to modify immutable fields.
401 - Unauthorized.

Everything to do with approval and signing normally happens asynchronously. That we currently do it synchronously as a hack should not change the API. Result is that any errors from approval or signing cannot be returned via HTTP response codes. Instead, we need to surface them through a .status.condition of type "Failed".

Thanks @fzdarsky .

Result is that any errors from approval or signing cannot be returned via HTTP response codes. Instead, we need to surface them through a .status.condition of type "Failed"

Yes, exactly why I was struggling to represent this with the response code. I had not considered the Failed .status.condition, that's a great alternative so I will do that.
ACK re: only using 500 as a catch-all and not returning the error in those cases.
Btw, this isn't as relevant since we can use the .status.condition, but we do have more response codes available currently for CSRs than those you listed (201, 202, 208 for POST and 404 and 409 for PUT/PATCH). I believe this was the result of a union between the codes K8s uses and what we were using for enrollment requests.

Actually it looks like we can just return nil, err if the CSR cannot be approved. But in the case of a newly created CSR that cannot be auto-approved, I've also added a Failed Condition.

@fzdarsky This could use a review as well, it is one in a series of bug fix PRs with others to be built on top of it.


Mixin conflict prevents Wither Skeletons from spawning in the world.

A mixin conflict with the mod sihytcamd prevents wither skeletons from spawning in the world.
[main/WARN]: Method overwrite conflict for method_5693 in sihywtcamd.mixins.json:WitherSkeletonMixin, previously written by artifality.mixin.common.extension.WitherSkeletonMixinExtension. Skipping method.
[main/WARN]: Method overwrite conflict for method_5749 in sihywtcamd.mixins.json:WitherSkeletonMixin, previously written by artifality.mixin.common.extension.WitherSkeletonMixinExtension. Skipping method.
[main/WARN]: Method overwrite conflict for method_5652 in sihywtcamd.mixins.json:WitherSkeletonMixin, previously written by artifality.mixin.common.extension.WitherSkeletonMixinExtension. Skipping method.

fixed in 0.5.1


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-source-version-target/pull/123 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-source-version-target.git

Docs Build status updates of commit 2a6bf99:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_yml-archive-test-branch_2021-06-02-03-58-48 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add better support for using dispatch queues

This has two main pieces: Realms which are confined to a dispatch queue rather than a thread, and notifications which are delivered to a scheduler other than the current one (currently only implemented for dispatch queues, but could support other things).
Queue-confined threads replace the check for if we're on the correct thread for a check if we're on the correct queue, using dispatch_queue_set_specific()/dispatch_queue_get_specific() to set some queue-local state to perform the checking. Notifications are done via a dispatch_async() to the queue rather than a signal in the target runloop. Because we can't automatically detect which queue we're running on (dispatch_queue_get_current() is inherently broken and doesn't really work), the queue to bind to has to be passed in when the Realm is opened.
A potentially surprising implication of this is that it's possible to have both a thread-confined and a queue-confined Realm instance usable at the same time, and they potentially could be at different versions.  This hopefully will not be too confusing for users? The main queue is special-cased to actually give the main thread's Realm instance, which hopefully will eliminate the most common place where this would arise (and makes it so that registering for notifications delivered to the main thread from a background thread works sensibly).
Notifications delivered to a queue are done by adding an optional queue parameter to observe(). Implementation-wise this is just a dispatch_async() to the queue with the notification registered there, but with some extra logic to be able to return a token synchronously.
I changed asyncOpen() to produce a queue-confined Realm mostly because it seemed weird for it not to be. I'm not sure if it's actually a functionally useful change.

just want to say @tgoyne this is fantastic work! I've been waiting for this improvement for a while


Add velocity functions for different equations

Trixi.jl has functions to compute density and pressure for all equations, but most equations do not have those for velocity. This PR adds those functions to CompressibleEuler, MultiComponentEuler, PolytropicEuler, IdealMHD, ShallowWater equations.

Two of the GLM MHD 2D tests are failing: https://github.com/trixi-framework/Trixi.jl/actions/runs/11035734678/job/30652521365?pr=2086#step:7:1405

The ShallowWaterEquations in 1D and 2D already have a velocity function, e.g., here that returns each Cartesian directions velocity. The normal direction velocity is then computed within the function if necessary.


FORTECH-44 Add RangePicker to Agate

Feature Added
Added new component RangePicker
Moved common logic with the Picker component to an internal component
Enact-DCO-1.0-Signed-off-by: Daniel Stoian<EMAIL_ADDRESS>

I put a question on Zeplin regarding this matter
Solved
If the others agree with this, I  don't have a problem applying it

Don't we need to support "wheel up/down" and "drag up/down"? From the comment, From the GUI comment it ways The operation of the Picker is the same as the iOS Date Picker.
GUI guide shows upper 2 items and lower 2 items. How can we show?

Hello, Yes, this will need to support "wheel up/down" and "drag up/down" in the end.
BUT, I put the question on the GUI egarding the transition after I gave this PR for review.
The comment flow on the GUI is not finished yet, some other screens being expected to be sent.
At this moment, I want to receive feedback regarding the implementation without "wheel up/down" and "drag up/down" functionality because The PR is quite big as it is.

Hello @daniel-stoian-lgp
There are some visual regression which break some skins except silicon.
DateTimePicker

Agate Gallium

Diff

develop Sampler

your branch Sampler

Checklist
npm run parse - Failed

[ ] Known parse errors: ThumbnailItem, useChainRefs
[ ] Invalid reference: agate/Picker.PickerDecorator: type: mixes - Picker in /Users/yb.sung/Documents/_Work/docs/raw/agate/Picker/Picker.js:128

npm run test-ss - Failed

[ ] DateTimePicker - Agate Gallium

npm run test-ui - Passed

Invalid reference: agate/Picker.PickerDecorator: type: mixes - Picker in /Users/yb.sung/Documents/_Work/docs/raw/agate/Picker/Picker.js:128

Please check my commit to fix js doc parse errors.
https://github.com/enactjs/agate/commit/1ad4ba6a801eabab73cc5489fa9bdab4c693b930

Hello @daniel-stoian-lgp
There are some visual regression which break some skins except silicon.
DateTimePicker

Agate Gallium

Diff

develop Sampler

your branch Sampler

Reverted to the original colors

Remark:
Module: =====================
Component: -----------------------------
⇧: HoC
↓: Composition
+: public prop
-: private prop

Before PR
Picker module
=====================
Picker module
=====================
+ Picker
+ PickerBase
+ PickerDecorator
=====================

Picker
IdProvider, Changeable, Skinnable
⇧
-----------------------------
PickerDecorator
-----------------------------
@ mixes IdProvider
@ mixes Changeable
@ mixes Skinnable
-----------------------------
⇧
-----------------------------
Picker
-----------------------------
↓
-----------------------------
PickerBase
-----------------------------
+ children
+ 'aria-valuetext'
+ decrementAriaLabel
- id
+ incrementAriaLabel
+ value: 0
-----------------------------
↓
div
↓
child ( from props.children )

After PR
Picker module
=====================
Picker module
=====================
+ Picker
+ PickerBase
+ PickerDecorator
=====================

Picker
IdProvider, Changeable, Skinnable
⇧
-----------------------------
PickerDecorator = internal/Picker.PickerDecorator
-----------------------------
⇧
-----------------------------
Picker
-----------------------------
↓
-----------------------------
PickerBase
-----------------------------
+ children
+ disabled
+ onChange
+ orientation
+ value: 0
-----------------------------
↓
internal/Picker
↓
PickerItem
↓
Marquee
↓
div
↓
child ( from props.children )

internal/Picker module
=====================
internal/Picker module
=====================
+ Picker
+ PickerDecorator
=====================

internal/Picker.Picker
-----------------------------
internal/Picker.PickerDecorator
-----------------------------
@ mixes IdProvider
@ mixes Changeable
@ mixes Skinnable
-----------------------------
⇧
-----------------------------
internal/Picker.Picker
-----------------------------
↓
-----------------------------
internal/Picker.PickerBase
-----------------------------
+ index
+ max
+ min
+ 'aria-valuetext'
+ children
+ className
+ decrementAriaLabel
+ disabled
- id
+ incrementAriaLabel
+ onChange
+ orientation: 'vertical'
+ step: 1
+ value: 0
-----------------------------
↓
PickerViewManager

Hello @daniel-stoian-lgp
Before reviewing your code in detail,
I'd like to share some comments because your patch affects other skins.

We hope that we do not break any APIs until we make a decision.

In agate/Picker.Picker,
aria-valuetext, decrementAriaLabel, and incrementAriaLabel are removed from the its propTypes. Pickers might work properly because those props are handled in agate/internal/Picker.Picker. But app developers could think that some APIs are removed. In this case, please leave the related comments.
If those props are not handled in the agate/Picker.Picker, then we could define them out of it.
const PickerBase = kind({
	name: 'Picker',

	propTypes: /** @lends agate/internal/Picker.Picker.prototype */ {
	...
});

/**
 * Sets the hint string read when focusing the decrement button.
 *
 * name decrementAriaLabel
 * @memberof agate/Picker.Picker.prototype
 * @default 'previous item'
 * @type {String}
 * @public
 */

agate/RangePicker.RangePicker's orientation prop is also not handled in the RangePicker. So you could define its JSDoc out of the RangePicker.

Please preserve the previous behavior in other skins.
The child from the props.children was wrapped with just div. But now it is wrapped with Marquee. I don't know that we should apply Marquee to all Picker's content for all skins.

internal/Picker becomes heavy including PickerViewManager.
I think that it might be better to provide any type so that some special logics could be applied depending on the type.

@daniel-stoian-lgp
I know that we need to change lots of tests and jsdocs when changing component hierarchy. For me as a reviewer, it's fine to defer to update them until the hierarchy has been concreated.

Depending on the picker item content, the picker item width changes. It might not be changed.

When launching the RangePicker sampler, the content with 4 has focused even though not hovering on it.

I fixed minor things.

Reroder exported modules internal/Picker/Picker.js.
Remove the step default value, paddings in RangePicker sampler.
Define defaultValue in RangePicker sampler. If not, there is a warning because the value prop is required As roy mentioned, I don't allow to modify the default value.

defaultValue shouldn't be used in samplers. Use value and control it or don't modify the default value for already created controls.

@daniel-stoian-lgp, this PR was complaining about the CLA. I know you've set it up in the past, because this is the first time it's showed up, so maybe it needs to be re-issued? We're ok now, but if you could look into it, that'll help us out. Thanks!


The blue dot has disappeared from the Drive page

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Hello,
In Drive details, if i'm right, there was a blue point on the map that moved when you moved the cursor in the graph.
This point was usefull and has disappeared a few month ago.
Could it be possible to fix this ?
Thanks !
Expected Behavior
The blue point pust follow the drive on the map when you move your cursor on the graph.
Steps To Reproduce
Go to Drive
Click on a drive
Relevant log output
NA

Screenshots

Additional data
NA
Type of installation
Docker
Version
1.27.1

Duplicate of #2770

Also a duplicate of #2866 and #2887


Question about dataset of ClozeTesting-maxmin

Hi,
I am looking through the ClozeTesting-maxmin dataset. However, I did not see the ground truth labels for the dataset anywhere. Can someone help clarify the dataset and its usage?
Many thanks!

Hi,
Thanks for your interest in our dataset!
First of all, we do not plan to publicize the answers for ClozeTesting-maxmin. Since it’s our policy of the CodeXGLUE challenge. If you want to see the performance on ClozeTesting-maxmin, you can send the predictions to<EMAIL_ADDRESS>following the format in the website. We will report the results back to you as soon as possible.


Event, document,window, navigator is not defined

I am getting
Event, document,window, navigator is not defined angular universal
'removeAttribute' of undefined

⚠ Closed as invalid issue. Please, fill the issue template when opening new issues in order to help us track the bug.
Cheers!


Compiler error when changing the package path

In java.util.regex, when changing the package path of SplitTest.java from package org.apache.harmony.regex.tests.java.util.regex; to package org.apache.harmony.tests.java.util.regex;, there is a compiler error to build the test with message: Exception in thread "main" com.sun.tools.javac.util.Abort.

Did you also move the file
to android/platform/libcore/harmony-tests/src/test/java/org/apache/harmony/tests/java/util/regex/SplitTest.java?
javac may fail if the package and the relative source file's path are
different.
On Tue, Jun 23, 2020 at 11:43 AM maryqyh<EMAIL_ADDRESS>wrote:

In java.util.regex, when changing the package path of SplitTest.java
https://github.com/google/j2objc/blob/master/jre_emul/android/platform/libcore/luni/src/test/java/org/apache/harmony/regex/tests/java/util/regex/SplitTest.java
from package org.apache.harmony.regex.tests.java.util.regex; to package
org.apache.harmony.tests.java.util.regex;, there is a compiler error to
build the test with message: Exception in thread "main"
com.sun.tools.javac.util.Abort.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/j2objc/issues/1346, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW2JL3LYQJVWWS762X5ZY3RYDZTZANCNFSM4OF55UYQ
.

Also try running "make clean" in case javac's old state is the issue.
On Wed, Jun 24, 2020 at 3:26 PM Tom Ball<EMAIL_ADDRESS>wrote:

Did you also move the file
to android/platform/libcore/harmony-tests/src/test/java/org/apache/harmony/tests/java/util/regex/SplitTest.java?
javac may fail if the package and the relative source file's path are
different.
On Tue, Jun 23, 2020 at 11:43 AM maryqyh<EMAIL_ADDRESS>wrote:

In java.util.regex, when changing the package path of SplitTest.java
https://github.com/google/j2objc/blob/master/jre_emul/android/platform/libcore/luni/src/test/java/org/apache/harmony/regex/tests/java/util/regex/SplitTest.java
from package org.apache.harmony.regex.tests.java.util.regex; to package
org.apache.harmony.tests.java.util.regex;, there is a compiler error to
build the test with message: Exception in thread "main"
com.sun.tools.javac.util.Abort.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/j2objc/issues/1346, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW2JL3LYQJVWWS762X5ZY3RYDZTZANCNFSM4OF55UYQ
.

I didn't move the file into the corresponding package location, and I guess that would be the problem. I just never thought it would directly cause a translator error (seems like an error we always want to avoid). I tried "make clean" and the error always exists with that one line change.

Okay, I'll file a bug with the javac team, since that's where it's failing.
On Thu, Jun 25, 2020 at 7:45 AM maryqyh<EMAIL_ADDRESS>wrote:

I didn't move the file into the corresponding package location, and I
guess that would be the problem. I just never thought it would directly
cause a translator error (seems like an error we always want to avoid). I
tried "make clean" and the error always exists with that one line change.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/j2objc/issues/1346#issuecomment-649594952, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW2JL3TMDPMQKWCDAHIOTTRYNPHTANCNFSM4OF55UYQ
.


Updagrade dependency version

Using the latest version from github/afex/hystrix-go.

Coverage remained the same at 91.105% when pulling 1e94c8ba8bed0ad82cca4e4bd49b289c4526f7b8 on Nydan:update_dep_hystrix-go into ca8c352034e638e32e00f1aaf3d01ff4625dd9af on gojek:master.


[Analyzer] Improvement on mutable classes with later fields

Dart SDK Version (dart --version)
Dart SDK version: 3.0.0 (stable) (Thu May 4 01:11:00 2023 -0700) on "windows_x64"

Whether you are using Windows, MacOSX, or Linux (if applicable)
Windows

Whether you are using Chrome, Safari, Firefox, Edge (if applicable)
n/a

Dart analyzer works wonderfully when we're writing immutable code such as:
@immutable
final class Something {
  const Something({required this.propA});

  final int propA;

  final int propB;
}

Error:
All final variables must be initialized, but 'propB' isn't.

Wonderful! I know what I must do to fix my code.
But, some libraries, such as Isar (https://pub.dev/packages/isar) ask for mutable types. Since I don't want some fields to be nullable, the only option is to add the later keyword: they are mutable, but they must have a value on init:
final class Something {
  Something({required this.propA});

  late int propA;

  late int propB;
}

The problem is: now the error is gone (I know propB can be set outside the constructor).
What I'm suggesting is:
a) With some hint (such as liter rules), force the same behavior of immutable classes, issuing an error or warning because those late props are not initialized in the constructor.
b) If the constructor is not empty and it's partial (such as this example), then automatically turn on some warning saying: ok, you either don't initialize anything on the constructor or initialize them all!
c) add a new keyword on constructor, so the variables MUST be initialized on it and still be nullable:
final class Something {
  Something({late this.propA, late this.propB});

  int propA;

  int propB;
}

This would be the same as required, but not requiring final modifier.

All of a), b) and c) seem to assume some specific use-cases, which makes assumptions about how late variables are used.
Also, late variables should be used very rarely. If at all possible, avoid using late variables.
In complete generality, avoid public late variables. (That's a lint I'd get behind!)
The a) lint is possible, if it states that all public late instance variables must be initialized by all constructors.
Presumably some of them will be initialized by the constructor body, because otherwise you don't need late to begin with.
It does require the analyzer to determine whether a late variable is initialized by all paths of a constructor body. We'd probably just require that it's easy, and the assignment must happen inside the body itself, not through calling some other method, otherwise it's too hard to check.
(If the late field is final, I'd still say to make it private, and expose a public getter, because otherwise you're exposing a public setter which throws when called.)
The example itself seems a little worrisome, like it's trying to do two things in the same object: Be a fully initialized object with non-nullable mutable fields, and be a builder for that kind of object, which can be uninitialized. That's fine, if you handle the uninitialized objects carefully, but the entire point of such a design would be that the fields can stay uninitialized for a while, so requiring the constructor to initialize them seems overly restrictive. (Unless the entire point of the late initialization is to create an object cycle, but then a dummy value used to initialize the non-final field would work just a as well as a late field.)
The b) warning is too specific. Why allow initializing no fields, or all fields, but not some? Seems like a very specific use-case is intended, but that's so specific it's probably not very reusable.
I don't understand the c) example. That looks like it should just be:
final class Something {
  Something({required this.propA, required this.propB});
  int propA;
  int propB;
}

Parameters required, all fields initialized, no nullables, no late. That's perfect.
(A required parameter doesn't require any final modifier.)

Makes sense.
Changing the classes to use required variable on constructor and removing all late makes the analyser useful again and doesn't break anything (disclaimer: the late additions were because of the documentation of such package).
The only remaining issue is that the author of Isar doesn't allow some types to have required, so those had to keep using late:
Constructors of embedded objects must not have required parameters.

Although this is an issue that can be resolved with Isar author, still, Dart allows it and has no meaning of warning if some field is not set correctly. But, as you said, this is an extremely exceptional case and should not even be used in the first place.
Nevertheless, thank you for your time.


Fix lint config

Our lint config hasn't been working correctly since the vite conversion. This should fix it. The diff for the eslint file is pretty crazy because it switched line ending style from CLRF to LF

This one isn't quite ready for review yet, couple more commits incoming

ESlint really isn't there yet with fully supporting the


Divide maps to subtract on German keyboard layout (Windows)

Version
2.3.0
Short overview
When calling pressKey(Key.Divide) Numpad Subtract is pressed on Windows using a German keyboard layout.
Detailed error description
I have a small program mapping the input of an external hardware device to keyboard actions. I started to map the NumPad on a Windows PC with a German keyboard layout. All keys except for divide are correctly mapped.  When calling keyboard.pressKey(Key.Divide");  the key subtract is pressed instead.
Steps to reproduce error
Set keyboard to German Layout.
Running following code:
import { keyboard, Key } from "@nut-tree/nut-js"; keyboard.pressKey(Key.Divide);
will call '-'.
Additional content
I couldn't figure out what cause the problem, but I found another Issue on a different repository describing the same problem.
https://github.com/FreeRDP/FreeRDP/issues/446

Hi @rgutt 👋
which OS are you using? (I should finally add that question to the issue template…🤦♂)


🔄 Synced file(s) with jhudsl/DaSL_Course_Template_Bookdown

Synced local file(s) with jhudsl/DaSL_Course_Template_Bookdown.

Changed files

Synced local  .github/workflows/transfer-rendered-files.yml with remote  .github/workflows/transfer-rendered-files.ymlSynced local directory scripts/ with remote directory scripts/

This PR was created automatically by the repo-file-sync-action workflow run #1266038648

Please carefully review these changes and decide which are useful for your course.
See the release notes: https://github.com/jhudsl/DaSL_Course_Template_Bookdown/wiki/Release-Notes

If you don't want the changes from a particular file, you can always revert that particular commit before merging the sync PR.
If you will not want any updates on this file in the future, you may want to remove a file from being synced in your repo by reconfiguring the sync file.

If you want only some changes, but they are not on a whole file basis, you could check out the branch and make manual edits.

To checkout the branch, navigate to your own repository you should be able to run:
git checkout repo-sync/DaSL_Course_Template_Bookdown/default

If you don't want any of the changes you can close the PR entirely.
You may want to unenroll your repository from the sync github actions by deleting your repo name from this file if this will continue to be the case.


Errors on Build

There is a 99% chance these errors stem from my own failures. It's 5am and the issues likely stem from the user (me).

I have the MemoryPack dependency package installed. I have .NET 8.0 SDK installed. I have visual studio 2022 with the .NET Desktop Development Workload. I have my editor in Godot set to Visual Studio, it properly opens up with the project and everything. I installed the addon in-editor through the Asset Library, it installed all the files underneath addons/TCPMaid. Did I miss a step?

Apologies for the inconvenience. While the TCPMaid source is available in the Godot asset library, it's not designed to be dropped into a project (because of project settings). You should install it with NuGet.

Ah, okay, that makes a lot more sense. I was curious why there were assets for the icon etc. if it's only dropped into project files, makes sense now though. I really appreciate the quick reply, everything works now.

Ah, okay, that makes a lot more sense. I was curious why there were assets for the icon etc. if it's only dropped into project files, makes sense now though. I really appreciate the quick reply, everything works now.


Site to be added under social

Good afternoon,
Sorry I don't normally use GitHub but a new site should be added under social.
<IP_ADDRESS> datememe.com
This is also listed as a chrome extension. I normally keep my network locked down but my daughter who is six years old was able to use this from her school issued Chromebook. One click sign up (daughters school login) added her real name, location, school email as well as her picture.

That is very disturbing,concidering that it's a dating site (aka 18+ or older !!!!) and their front page looks more like
coloring book for kids then anything else. So...let's lock down this for good:
<IP_ADDRESS> www.datememe.com
<IP_ADDRESS> admin.datememe.com
<IP_ADDRESS> blog.datememe.com
<IP_ADDRESS> bn.datememe.com
<IP_ADDRESS> c1.datememe.com
<IP_ADDRESS> c2.datememe.com
<IP_ADDRESS> c3.datememe.com
<IP_ADDRESS> datememe.com
<IP_ADDRESS> de.datememe.com
<IP_ADDRESS> en.datememe.com
<IP_ADDRESS> es.datememe.com
<IP_ADDRESS> fr.datememe.com
<IP_ADDRESS> hi.datememe.com
<IP_ADDRESS> id.datememe.com
<IP_ADDRESS> ja.datememe.com
<IP_ADDRESS> jv.datememe.com
<IP_ADDRESS> ko.datememe.com
<IP_ADDRESS> pt.datememe.com
<IP_ADDRESS> ru.datememe.com
<IP_ADDRESS> th.datememe.com
<IP_ADDRESS> vi.datememe.com
<IP_ADDRESS> zh-cn.datememe.com

That is very disturbing,concidering that it's a dating site (aka 18+ or older !!!!) and their front page looks more like
coloring book for kids then anything else. So...let's lock down this for good:
<IP_ADDRESS> www.datememe.com
<IP_ADDRESS> admin.datememe.com
<IP_ADDRESS> blog.datememe.com
<IP_ADDRESS> bn.datememe.com
<IP_ADDRESS> c1.datememe.com
<IP_ADDRESS> c2.datememe.com
<IP_ADDRESS> c3.datememe.com
<IP_ADDRESS> datememe.com
<IP_ADDRESS> de.datememe.com
<IP_ADDRESS> en.datememe.com
<IP_ADDRESS> es.datememe.com
<IP_ADDRESS> fr.datememe.com
<IP_ADDRESS> hi.datememe.com
<IP_ADDRESS> id.datememe.com
<IP_ADDRESS> ja.datememe.com
<IP_ADDRESS> jv.datememe.com
<IP_ADDRESS> ko.datememe.com
<IP_ADDRESS> pt.datememe.com
<IP_ADDRESS> ru.datememe.com
<IP_ADDRESS> th.datememe.com
<IP_ADDRESS> vi.datememe.com
<IP_ADDRESS> zh-cn.datememe.com

A few more from their certificate:

blog.d8.io
d8.io
www.d8.io

A few more from their certificate:

blog.d8.io
d8.io
www.d8.io

Should these go in the default list, I wonder?  Thoughts, Dan @dnmTX and Shreyas @shreyasminocha?

Should these go in the default list, I wonder?  Thoughts, Dan @dnmTX and Shreyas @shreyasminocha?

Should these go in the default list, I wonder?

I'd say NO,unless you want to deal with bunch of crybabies(which...in my opinion is inevitable,considering the broad userbase here) and eventually their whole team and CEO poping up here and japing how honest the platform is.

Should these go in the default list, I wonder?

I'd say NO,unless you want to deal with bunch of crybabies(which...in my opinion is inevitable,considering the broad userbase here) and eventually their whole team and CEO poping up here and japing how honest the platform is.

....but it's...should i say past due to list @Sinfonietta's repo in the front page as the source for blocking social/gambling/porn...sites
😄

....but it's...should i say past due to list @Sinfonietta's repo in the front page as the source for blocking social/gambling/porn...sites
😄

I know Dan @dnmTX I wrestle with this.
We have 17 different readme in this repo.  @sinfonietta is included in all readme where his lists are included.  None of his lists are included in the default list, which is our homepage.
I'd love to figure a better way to present all this.  GitHub kind of limits what we can do here...
alternates/fakenews/readme.md
alternates/fakenews-gambling/readme.md
alternates/fakenews-gambling-porn/readme.md
alternates/fakenews-gambling-porn-social/readme.md
alternates/fakenews-gambling-social/readme.md
alternates/fakenews-porn/readme.md
alternates/fakenews-porn-social/readme.md
alternates/fakenews-social/readme.md
alternates/gambling/readme.md
alternates/gambling-porn/readme.md
alternates/gambling-porn-social/readme.md
alternates/gambling-social/readme.md
alternates/porn/readme.md
alternates/porn-social/readme.md
alternates/social/readme.md
extensions/readme.md
readme.md

I know Dan @dnmTX I wrestle with this.
We have 17 different readme in this repo.  @sinfonietta is included in all readme where his lists are included.  None of his lists are included in the default list, which is our homepage.
I'd love to figure a better way to present all this.  GitHub kind of limits what we can do here...
alternates/fakenews/readme.md
alternates/fakenews-gambling/readme.md
alternates/fakenews-gambling-porn/readme.md
alternates/fakenews-gambling-porn-social/readme.md
alternates/fakenews-gambling-social/readme.md
alternates/fakenews-porn/readme.md
alternates/fakenews-porn-social/readme.md
alternates/fakenews-social/readme.md
alternates/gambling/readme.md
alternates/gambling-porn/readme.md
alternates/gambling-porn-social/readme.md
alternates/gambling-social/readme.md
alternates/porn/readme.md
alternates/porn-social/readme.md
alternates/social/readme.md
extensions/readme.md
readme.md

Steve @StevenBlack i hear you,or maybe i'm not....complicated i know....
What i meant in my post that his repo is missing here:

....where everyone is listed and for me personally if i have some concern to open issues i look there for guidance as i assume most of us here do.
Is it possible to list him there,i mean,every other repo is?

Steve @StevenBlack i hear you,or maybe i'm not....complicated i know....
What i meant in my post that his repo is missing here:

....where everyone is listed and for me personally if i have some concern to open issues i look there for guidance as i assume most of us here do.
Is it possible to list him there,i mean,every other repo is?

Hello @StevenBlack I have added these domains to my social medial list.

Hello @StevenBlack I have added these domains to my social medial list.

Thank you @Sinfonietta!
Closing.

Thank you @Sinfonietta!
Closing.


[Community]: GitHubAction Tool Parameter Error Fix

Github Action Tool had an error in parameter passing for _run which was causing the failure of tool(s) invoking. This was identified in the following issue: #18406

@baskaryan


htmx config should model the data folder ?

anything that is stateful on disk like nats, DB normally is  mapped to a folder that might later be a volume when used with docker.
I tend to use .data, because it indicates its a special folder.
saw this also in dockside, where it uses "data" folder", which would normally be a volume when dockerised.
What do you think about qualifying it as a config to standardise this ?
standard config is this:

# htmgo configuration

# if tailwindcss is enabled, htmgo will automatically compile your tailwind and output it to assets/dist
tailwind: true

# which directories to ignore when watching for changes, supports glob patterns through https://github.com/bmatcuk/doublestar
watch_ignore: [".git", "node_modules", "dist/*"]

# files to watch for changes, supports glob patterns through https://github.com/bmatcuk/doublestar
watch_files: ["**/*.go", "**/*.css", "**/*.md"]

# files or directories to ignore when automatically registering routes for pages
# supports glob patterns through https://github.com/bmatcuk/doublestar
automatic_page_routing_ignore: ["root.go"]

# files or directories to ignore when automatically registering routes for partials
# supports glob patterns through https://github.com/bmatcuk/doublestar
automatic_partial_routing_ignore: []

# url path of where the public assets are located
public_asset_path: "/public"

Are you just referring to application specific data? since htmgo doesn't have any stateful data, it would be up to the application itself to decide those details


Enforce Workstation GC for .NET apps in Hellman

What: According to the mentioned blog article using Workstation GC in k8s will lead to less memory usage and thus more loads pr. node
Why: More efficient use of our Hellman cluster

[ ] Read @ https://blog.markvincze.com/troubleshooting-high-memory-usage-with-asp-net-core-on-kubernetes/
[ ] Switching from Server GC to Workstation GC to ensure lower memory usage in Hellman
[ ] Figure out how to enforce Workstation GC on all .NET Core workloads in Hellman
[ ] Test & demo

See here how to set ENV value to control GC settings @ https://docs.microsoft.com/en-us/dotnet/core/run-time-config/garbage-collector


Add  tags to knative provided reconcile metrics

This is related to Issue https://github.com/knative/pkg/issues/1894

/cc yanweiguo

This explodes the cardinality of these metrics doesn't it? We had huge issues with memory pressure due to this and I think in general prometheus wants you to keep the labels on the metrics relatively bounded.

Hmm without these tags these metrics does not have enough information to be in sync with knative_revision metric schema. https://github.com/knative/pkg/blob/master/metrics/metricskey/constants_serving.go#L43-L51
Without that we are not able to ingest these metrics into our system.

Is it fine if this is behind a config map setting to add these tags?
CM: https://github.com/knative/serving/blob/master/config/core/configmaps/observability.yaml#L25
Saying metrics.controller-add-knative-revision-tags

This is pkg so it is used outside of Knative Serving proper, so the flag should be more generic enable-detailed-flags, or along those lines (I am notoriously bad with naming).
Now, question is also how this is going to be consumed downstream, e.g. do you have in mind how activator or autoscaler will receive this flag, and attach the additional tags. A POC would be super useful.
Generally speaking, I like more dimensions than fewer, but we have to balance against system capabilities as well.

I chatted a bit with Rushabh; my $0.02 is that it probably makes sense to include a namespace in the controller metrics (so that you can determine if a particular customer is stuck), but it may not make sense to add resource tags to every controller metric, since a lot of monitoring systems do struggle with high cardinality, and these metrics are likely to be infrequently updated.

@vagababov and @markusthoemmes
If we only add namespace, do you think we can avoid needing to make this a toggle? I worry about adding configuration knobs that need to be set one way or another to be able to get useful information, but I also don't want to introduce large amounts of memory growth for no reason.

Namespace should be alright I think.
I think @julz might be more interested, since they run multitenant systems, so might have many more namespaces (so both more useful and more resources :))

I think we'd be ok with namespaces since they're 1 per customer (more granular than that would indeed be bad I think, see https://github.com/knative/serving/issues/8609 for previous context). Reserve the right to plead to add a toggle after all if I turn out to be wrong, though 😅.
@cdlliuy does adding just namespace sound reasonable to you, too?

Updated the PR by remove resource_name tag. PTAL

@julz , thank you for bringing me into the discussion.
I do agree that the detail metrics are valuable to knative users, and I do agree as well the huge amount of metrics will bring more pressure to metric systems.   It depends on the different user case of knative.  so there should be some trade-off, .
So,  personally,  I support the idea to make the key configurable by the knative operator  to define the level of metric that we would like to retrieve, i.e.
metrics.controller-add-tags: "" (as default)
metrics.controller-add-tags: "namespace"
metrics.controller-add-tags: "namespace, services"
metrics.controller-add-tags: "namespace, service, configuration"
metrics.controller-add-tags: "namespace, service, configuration, revision"

That means the pkg level need to open a func to initialize the key dynamically, then in serving side , we can call the metric init according to the config map values.
And, on the other side,  the metric "reconcile_latency" is a histogram, then we can think of the metric type as well to see whether it really need to be a histogram.
# HELP controller_reconcile_latency Latency of reconcile operations
# TYPE controller_reconcile_latency histogram

If we only expose "reconcile_latency" metric without any namespace, services and etc tags, definitely, it need to be a histogram , so that we can understand the latency behaves in the large scope.
When adding namespace as the tag,  maybe histogram is still making sense.
But if it is service, configuration, revision level,  whether it is still worth to be as a histogram,  considering the count of reconcile on the detail level is not big enough .. maybe providing an avg value as gauge is good enough ..

Thanks alot for all these insights.
As per I read, adding just namespace as additional field should be a good addition to these metrics. Other tags are added to the metrics to be in par with knative_revision metric schema expectation and they are set as always unknown.
Do we feel configuration proposed by @cdlliuy is something we want for such changes to metrics? If yes I will go with proposal above and try to execute on this. Thanks

So we set unknown in order to clump them together by default but perhaps initialize with precise values downstream at the call site?

removed all unknown tags. PTAL

/lgtm
/assign @evankanderson

/approve
/hold From the discussion above, we're fine to add a namespace key. But add a hold label just in case if someone has more comments.

ah, i though it was in pkg/metrics. Actually I don't have permission to approve.
/hold cancel. will let @evankanderson to approve

/hold cancel