B-Tax UI at /btax

This is a work-in-progress for a user interface for B-Tax.  See attached screenshot below:
Welcome to TaxBrain _ TaxBrain.pdf
TODO:

[ ] logos (404 currently)
[ ] remove unused code that was cut and pasted over from /webapp/apps/taxbrain to webapp/apps/btax
[ ] fix the checkbox and radio button styling (put them all in one row) for the different asset year blocks within the Deprecation section
[ ] tests similar to those in webapp/apps/taxbrain/tests
[ ] logic related to POST requests (so far this is just a UI that supports GET requests)

cool, thanks @PeterDSteinberg. @jdebacker and @bfgard please have a look at the attached PDF and see if this aligns with your ideas on interface.

Thanks @PeterDSteinberg!  I think the layout looks good.  Would it be possible to consolidate the depreciation items into a table in order to condense things a bit?  The same options are available for each of the variously lived assets, so there is a lot of repetition here.  It might also make sense to allow the user to apply changes to all classes easily (e.g. switch to expensing of investment for all assets could be done with one click, rather than having to do it for each class individually).
@MattHJensen any thoughts?

@jdebacker I can work on consolidation of the deprecation asset year parameter groups into a table-like structure with a toggle on check/uncheck a given parameter for all years.

Would it be possible to consolidate the depreciation items into a table in order to condense things a bit? The same options are available for each of the variously lived assets, so there is a lot of repetition here. It might also make sense to allow the user to apply changes to all classes easily (e.g. switch to expensing of investment for all assets could be done with one click, rather than having to do it for each class individually).

@MattHJensen any thoughts?

Makes sense to me too.

This commit converts the Deprecation section of B-Tax to more compact table with a row to check-all.  See below:

On-click actions like checking all rows in a column have not been added yet.

@PeterDSteinberg , this looks good!  Seeing this now, let me propose a few small changes:

Change "Asset year life" to "Property class"
Change "Check all asset years" to "Check all property classes" or just "Check all"
Make the last column the 4th and retitle- so columns 2-4 are GDS, ADS, Economic ("Economic" will replace "Tax=Economic?").
Make the Economic radio button a round one like the GDS and ADS.
Ensure that only one of the radio buttons in the first 3 columns (GDS, ADS, Economic) can be selected at one time.
Let's replace the "full expensing" column to one that reads "Bonus" and has fields to enter values rather than radio buttons.  The mouse over info button will alert the user that this is the bonus deprecation rate and that if one wants to move to full expensing, they will enter a rate of 100% in this field.

Let me know if you have questions.  Thanks.

@jdebacker So on item in 6) in your list above, do you mean that the to-be-renamed Bonus column should have just a single text box for a percentage?  Is 100% the default there?

Yes.  The default will be 50% for 20 year and less property.  0% for longer-lived property.

The latest commit reorganizes the table based on the discussion in the last couple comments, @jdebacker .  There is still work to be done on getting the right defaults in the table and on-click actions.  The last commit also removes a lot of the unused code that I had cut and pasted over from /taxbrain (except fro views.py which still needs to be cleaned up). Here's how it looks now:

@PeterDSteinberg thanks.  This looks good to me.

With the new parameter jsons from @jdebacker, this is what it looks like now:
Welcome to TaxBrain _ TaxBrain.pdf

Currently with last commit's code I am getting an error when I try to create a separate class from OutputUrl that is like an OutputUrl for B-Tax.  I cannot run migrate now because of this problem.  It seems to relate to pk (primary key).
$ python manage.py migrate -v 3
Operations to perform:
  Synchronize unmigrated apps: gunicorn, staticfiles, messages, humanize, import_export, storages
  Apply all migrations: account, sessions, admin, flatblocks, register, dynamic, sites, auth, taxbrain, contenttypes, btax, hermes, pages
Synchronizing apps without migrations:
Running pre-migrate handlers for application admin
Running pre-migrate handlers for application auth
Running pre-migrate handlers for application contenttypes
Running pre-migrate handlers for application sessions
Running pre-migrate handlers for application sites
Running pre-migrate handlers for application taxbrain
Running pre-migrate handlers for application dynamic
Running pre-migrate handlers for application pages
Running pre-migrate handlers for application register
Running pre-migrate handlers for application btax
Running pre-migrate handlers for application flatblocks
Running pre-migrate handlers for application account
Running pre-migrate handlers for application hermes
Running pre-migrate handlers for application import_export
  Creating tables...
    Running deferred SQL...
  Installing custom SQL...
Loading 'initial_data' fixtures...
Checking '/Users/psteinberg/Documents/AEI/webapp-public' for fixtures...
No fixture 'initial_data' in '/Users/psteinberg/Documents/AEI/webapp-public'.
Loading 'initial_data' fixtures...
Checking '/Users/psteinberg/Documents/AEI/webapp-public' for fixtures...
No fixture 'initial_data' in '/Users/psteinberg/Documents/AEI/webapp-public'.
Loading 'initial_data' fixtures...
Checking '/Users/psteinberg/Documents/AEI/webapp-public' for fixtures...
No fixture 'initial_data' in '/Users/psteinberg/Documents/AEI/webapp-public'.
Loading 'initial_data' fixtures...
Checking '/Users/psteinberg/Documents/AEI/webapp-public' for fixtures...
No fixture 'initial_data' in '/Users/psteinberg/Documents/AEI/webapp-public'.
Loading 'initial_data' fixtures...
Checking '/Users/psteinberg/Documents/AEI/webapp-public' for fixtures...
No fixture 'initial_data' in '/Users/psteinberg/Documents/AEI/webapp-public'.
Loading 'initial_data' fixtures...
Checking '/Users/psteinberg/Documents/AEI/webapp-public' for fixtures...
No fixture 'initial_data' in '/Users/psteinberg/Documents/AEI/webapp-public'.
Running migrations:
  Rendering model states...Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/core/management/__init__.py", line 338, in execute_from_command_line
    utility.execute()
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/core/management/__init__.py", line 330, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/core/management/base.py", line 390, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/core/management/base.py", line 441, in execute
    output = self.handle(*args, **options)
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/core/management/commands/migrate.py", line 221, in handle
    executor.migrate(targets, plan, fake=fake, fake_initial=fake_initial)
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/db/migrations/executor.py", line 104, in migrate
    state = migration.mutate_state(state, preserve=do_run)
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/db/migrations/migration.py", line 83, in mutate_state
    operation.state_forwards(self.app_label, new_state)
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/db/migrations/operations/fields.py", line 51, in state_forwards
    state.reload_model(app_label, self.model_name_lower)
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/db/migrations/state.py", line 152, in reload_model
    self.apps.render_multiple(states_to_be_rendered)
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/db/migrations/state.py", line 262, in render_multiple
    model.render(self)
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/db/migrations/state.py", line 546, in render
    body,
  File "/Users/psteinberg/miniconda3/envs/webapp/lib/python2.7/site-packages/django/db/models/base.py", line 254, in __new__
    'base class %r' % (field.name, name, base.__name__)
django.core.exceptions.FieldError: Local field u'id' in class 'OutputUrl' clashes with field of similar name from base class 'OutputUrl'

This SO post:
http://stackoverflow.com/questions/2344751/in-django-model-inheritance-does-it-allow-you-to-override-a-parent-models-a
leads me to believe the error might be due to the unusual inheritance model you are using with the class I mentioned above. I'll keep digging but just a heads up.

@talumbau  I fixed the problem by removing the inheritance and also rm -rf my migrations folders.
Now it has place holders for running btax.  You can change a parameter, then run, then wait, then get redirected to the tables page, but the tables are not existing there yet.  I'll see what it takes to get this PR working with the two B-Tax PRs:

https://github.com/open-source-economics/B-Tax/pull/40 and
https://github.com/open-source-economics/B-Tax/pull/38

Hmm.. we definitely don't want to remove existing migrations, so the removal of those migrations should not be part of the PR. But I'm glad it's working. The other thing I noticed in this PR is that the number of files is quite large and it seems like larger than is necessary. I will comment on certain files but we might need to do a screenshare so I can understand the rationale for some of the files

TODO:

[ ] logos (404 currently)
[x] remove unused code that was cut and pasted over from /webapp/apps/taxbrain to webapp/apps/btax
[x] fix the checkbox and radio button styling (put them all in one row) for the different asset year blocks within the Deprecation section
[ ] tests similar to those in webapp/apps/taxbrain/tests
[x] logic related to POST requests (so far this is just a UI that supports GET requests)
[ ] results.html work in Bootstrap.  Here is an example of the table data that will be accessible to Bootstrap when making results tables:
btax_table_format_check.txt
[ ] after the work on results.html, see if more template files in templates/btax can be removed in favor of using templates/taxbrain items, such as not_ready.html.

@PeterDSteinberg one thing to mention about TravisCI on this repo: we have a few private environment variables set for testing. The private environment variables are only available in Travis CI for PRs where the originating branch is on this repo.  One way to fix this is to push your branch to this repo and do the PR that way, or I can push your branch to this repo, although for ease of development we should probably make sure you can push a branch to this repo. Let me know what happens when you try it.

@talumbau Looks like I don't have write access to this repo (just tried to push here).

ok, I'll work on this. Shouldn't take too long.

Closing.  Re-opened as #304


Ability to Sell Legal Documents

Hello Tech Team,
I work independently in teaching others about their Political Status, and have developed very important documents that I sell as a result of my 40 years of studying. I was wondering if OpenBazaar can have the ability to host securely these documents on their server. I need to have complete control over who gets to buy these documents, because education is strongly needed before the use of these files I own. So I was thinking, maybe, that I can have some sort of permission settings, like my clients having to enter a special code or link, sent by email from me, to have the purchase button available to them to purchase. That way not just anybody can purchase this. If just anyone can obtain these without my guidance first, they might end up in jail for a long time with serious repercussions. So this method of purchasing for such occasions that I have mentioned, as you can see, is very important. If a better method can be thought of let me know. I am very serious in this issue. Let me know what you think. Thank you for your time.
Respectfully yours
Red
PS: These Documents I have are many. So a bundle purchase will be the way I will go about selling these. Again I don't want just anyone being able to purchase these. Thank you.

Red are you from Nigeria ?

United States

I'm gonna drop this issue as its out of scope for the product.


Docs use incorrect URL parameter

What happened?:
I followed the walkthrough doc to test my configuration, but couldn't get selectors to work as expected.
What did you expect to happen?:
I expected the walkthrough document to be accurate :)
Anything else we need to know?:
The docs demonstrate one URL query parameter, selector, but this isn't a supported parameter. There are two different selector URL query parameters available: labelSelector for selecting Kubernetes objects by their labels and metricLabelSelector for selecting metrics by their labels.
After much frustration and thinking there was something wrong with my config, I figured this out by stepping through the apiserver code and finding this: https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/v1.21.0/pkg/apiserver/installer/conversion.go#L46-L62

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale
Same issue with me. metricLabelSelector saves my life. The document should be updated for accuracy.


feat: load components pages to build the doc

Signed-off-by: shiipou<EMAIL_ADDRESS>
#__
Checklist

[x] I didn't over-scope my PR
[x] My PR title matches the commit convention
[ ] I did not include breaking changes
[ ] I included unit tests that cover my changes
[ ] I added/updated the documentation about my changes
[x] I made my own code-review before requesting one

Description of the changes

Technical highlight/advice

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0

Your semantic-release bot :package::rocket:


HDDS-4543. Failed to list keys when there are two bucket names with s…

https://issues.apache.org/jira/browse/HDDS-4543
This task fixes the bug that bucket listKeys operation returns empty list,  when there are two buckets with same prefix names, such as "hadoop" and "hadoop-ozone".

Thanks @bharatviswa504 for the code review.


How does one figure out a product ID?

Hi!
I've a Viomi Smart Kettle SK-152A that integrates with the Xiaomi Mi Home app.  It shows up on htmgmt find as "MiKettle" (MAC B8:7C:6F:xx:xx:xx).  Attempts to talk to it using the known Xiaomi MiKettle product IDs (275 or 131) fail with Exception: Authentication failed when I run python demo.py connect $MAC $PID.
Now I'm not 100% sure it uses the same protocol (although the "MiKettle" name is very telling), but if it is, how would I go about figuring out the right product ID to use?  Random guessing doesn't seem very productive.

You iterate over a lot of them until it starts working.
Try 1116

1116 makes it beep before I get a
bluepy.btle.BTLEDisconnectError: Failed to connect to peripheral B8:7C:6F:xx:xx:xx, addr type: public

error, which is very interesting.  (It doesn't always beep, sometimes I just get the disconnect error.)

Beeping means that the handshake was successful so the remaining connectivity issues are most likely not caused by a wrong productId

I only just now noticed that not only does it beep, it also manages to report the firmware version:

FW: 7.5.10

before disconnecting.

Ooh, if I comment out the firmware_version() call, then the name() call succeeds

Name: yunmi.kettle.v7

And if I comment out both, then kettle.parameter_value(MI_CURRENT_TEMPERATURE) succeeds:
DEBUG:mikettle.mikettle:Init Mikettle with mac B8:7C:6F:xx:xx:xx and pid 1116
Authenticating
Getting data from mi Kettle
DEBUG:mikettle.mikettle:Filling cache with new sensor data.
DEBUG:mikettle.mikettle:Connect
DEBUG:mikettle.mikettle:Auth
DEBUG:mikettle.mikettle:Subscribe
DEBUG:mikettle.mikettle:Wait for data
DEBUG:mikettle.mikettle:Status update:
DEBUG:mikettle.mikettle:Parse data: b'\x00\xff\x00\x00PN\x00\x00\x00\x01\x18\x00'
DEBUG:mikettle.mikettle:data parsed {'action': 'idle', 'mode': 'none', 'set temperature': 80, 'current temperature': 78, 'keep warm type': 'warm up', 'keep warm time': 0}
Current temperature: 78

v7 🤔
Any idea if there is more functionality in the app now?
There seems to be a preset function which you can use by just interacting with the kettle and pushing the "WARM" button a few times.
I wonder if we could program those and/or see them in the current state

TBH I'm not sure what the app allows since it wants me to create an account or something silly like that.  A coworker did that (this is an office kettle) but they already left so I can't ask.
The instruction manual mentions four preset modes (50/70/80/90 deg C) that you can choose by repeatedly pressing the Warm button.
A github search on yunmi.kettle.v7 leads me to https://github.com/liguobingh/com.viomi.kettlepro/blob/d69a5de3978c6902f20c6404d6d62b3696c86706/src/main/java/com/viomi/kettlepro/UMGlobalParam.java, but there don't seem to be any checks that distinguish MODEL_KETTLE_V7 from other versions in that codebase.

I've fixed the issues with disconnections: it seems that every helper method was re-connecting and re-authenticating, and my kettle doesn't appear to like that.  I've created #5 for this.
I'm going to close this issue because my question was answered in https://github.com/drndos/mikettle/issues/4#issuecomment-572125171.


Clarify invalid values in fit_curve

Hey @clausmichele, as you've implemented this... I stumbled across this and maybe I'm misunderstanding, but shouldn't finite numbers be valid?

@ValentinaHutter you know this better than I do! :)

It was meant to cater for invalid values in the input data, but not sure whether and how we should cater for other cases?

This process must be able to handle invalid data internally and should not return an error if some invalid points are present in the time series.

@clausmichele So you are saying we should remove the InvalidValues exception and all mentions of it and instead say that invalid values must be dealt with smoothly? Is this possible in all cases?

Indeed. I can't think about all the possible scenarios, but the one for which we created this process, fitting an harmonic curve to each pixel of a raster-cube, must handle NaNs occurring due to cloud masked or or invalid pixels along the time series.
Should we make this part explicit? Adding a default ignore_nodata = true ? I don't know if there could be a case where the user wants to be warned if there are invalid values in the raster-cube/time series.

Doesn't it actually all depend on how the callback provided in the function parameter works?
https://github.com/Open-EO/openeo-processes/blob/0dd3ab0d81f67506547136532af39b5c9a16771e/proposals/fit_curve.json#L38-L43
If that function properly supports handling invalid data, then the whole fit_curve call will work. If it doesn't, then fir_curve will fail when given data that contains invalid values.
So this seems like to user's responsibility to make it work with or without invalid data support?
Or,  would it be a feature of fit_curve  to skip parts of the raster data cube with invalid values and only provide function  the parts where the x input is fully valid?

@soxofaan yes exactly! So fit_curve shouldn't check the input data, but it's the fitting function that takes care of it.

I cherry-picked the single word change from this PR which seemed okay. The issues that came up now are somewhat related, but not strictly related to the intial PR. So having the first action done, we can now discuss additional changes here independantly.

Example from discussions:
labels = dimension_labels(datacube)
seconds = array_apply(labels, fn = to_seconds)
cube2 = apply_dimension(datacube, fn, "t", seconds)
fn fit:
params = fit_curve(context.seconds, [1,1,1], fn);
predictions = predict_curve(cube2)


[patch] Streamline validations

sails-hook-rom will now handle moving top-level properties like isEmail into a validations property on an attribute, so Waterline now just has to read that property instead of doing all the merging/checking itself.  Also, required isn't handled by anchor anymore so the code related to that has been removed.  And Waterline can just defer to anchor to complain about unknown validation rules.

Sorry @sailsbot !


Data table closes #20

Coverage remained the same at 100.0% when pulling 51d7d833832484e317a2b04db39e8539007e7c60 on data-table-#20 into e3ef01c9f382f7c88f6ad89071767f7bb9baa843 on develop.


[0.9] when I move a dom-repeat element from one parent to another, the items will gone

<dom-module id="custom-element">
  <template>
    <template is="dom-repeat">{{users}}

  </template>
</dom-module>

In the

<custom-element id="my-list"></custom-element>

When I use Polymer.dom(element("#second")).appendChild( element("#my-list") ), the whole list inside it will be removed.

Well, I check the Polymer latest code and found this issue relative with the code here: https://github.com/Polymer/polymer/blob/0.8-preview/src/lib/template/dom-repeat.html#L199
In the dom-repeater there is a detached callback that will clear all the list when the dom detached. I think it should add an attached callback to recover this, otherwise the dom list will gone, but the Polymer element still have that data keep on it.
Q: When will people detached a list and attach it some where again?
A: I have a panel system that can freely dock itself from one parent to another. If there is a dom-repeat list in it, when the panel move, the items in the dom-repeat will be detached based on the code I found above, but never recover again when the panel dock to other element.

Yes, dom-repeat needs balanced re-attachment logic to re-insert stamped nodes back into the DOM after having been detached.  This will be the fix.


allow for any pre-1.0 version of apiclient-services

@bshaffer This would solve a ton of issues with changes to API methods without having to wait for library updates. +1 for getting this merged in ASAP!


[BUG] - Input in Modal does not update contents

NextUI Version
2.4.6
Describe the bug
Input control in a Modal component does not update the content.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
'use client';

import { Modal, ModalContent, ModalHeader, ModalBody, Button, useDisclosure, Input } from '@nextui-org/react';
import { useState } from 'react';

export default function Page() {
	const { isOpen, onOpen, onOpenChange } = useDisclosure();
	const [text, setText] = useState('');
	return (
		<div>
			<Button onPress={onOpen} color='primary'>
				Open Modal
			</Button>
			<Modal isOpen={isOpen} onOpenChange={onOpenChange} placement='top-center'>
				<ModalContent>
					{(onClose) => (
						<>
							<ModalHeader className='flex flex-col gap-1'>Log in</ModalHeader>
							<ModalBody>
								<Input value={text} onValueChange={setText} />
							</ModalBody>
						</>
					)}
				</ModalContent>
			</Modal>
		</div>
	);
}

Click "Open Modal" button.
Type in the Input.

Note that the input control does not update.
Expected behavior
Input control should work. The characters typed in should be updated.
Screenshots or Videos
No response
Operating System Version
Windows 11
Browser
Chrome

@jim-king-2000  I tried with your code and things are working completely fine.
see here
There may be some other issues like configuration or dependency.
Kindly check and confirm again.  I used the NextUI App Template for test purpose
https://github.com/user-attachments/assets/c5038b7a-b5e3-4725-883c-0a68a82799cd

I have the same problem too, there aren't work on windows 11 and macOS. the problem was triggered after updated new version.

@aokihu  @jim-king-2000  can you provide codesandbox  or stackblitz showing the issue.
So that I can help you better,  bcz I am not able to reproduce the bug

@abhinandan-verma https://github.com/qmonmert/reactapp you can reproduce the bug here 🙂

Not Just Input Control the useState used inside modal is not working at all, all my previously working forms inside the modals are broken now

@shabanbx  can  you share some relevant code of form, package.json and NextUI configuration,
More preferably a sandbox showing the error
I will be able to debug it efficiently

@abhinandan-verma this happened after upgrading from 2.3.6 to 2.4.6  but you uploaded the video above with the same version and its working for you. so what i did was
rm -rf node_modules
rm -rf package-lock.json
then
npm cache clean --force
after that installed again with 2.4.6 (npm i) and the issue is gone and the useState is working again inside the modal

@shabanbx  its good if the issue is resolved
@jim-king-2000  @qmonmert   you may follow the similar steps
And see if your issue is resolved
(do only if doesn't harms your app in any other way)
Kindly confirm if the issue is resolved

@abhinandan-verma I confirm, issue is resolved, thanks

@jim-king-2000 you can also rebuild your app  cleaning the npm cache.
confirm if error still exists
else kindly close the issue as completed
Thank you

Confirmed and closed.


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20211122163356622 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20211122163356622 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.599%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27082

Relevant Lines:
59040

💛  - Coveralls


WIP Less CPP

Trying to reduce the amount of CPP in the code.

Closed.  My try again at some future point.


Requesting HTTPS over an HTTP proxy doesn't work

When requesting an HTTPS url over an HTTP proxy, LuaSocket tries to initiate a TLS session with the proxy server.
This works with mitmproxy, but not with other proxies.
Is it intended behavior ?
Otherwise, I can submit a PR to use the HTTP create function when an HTTP proxy is used.

I don't have much time to research the current or correct behavior, but will help facilitate a PR if one comes. From reading the issue at least that situation does sound like a bug.

It seems to me most clients requesting HTTPS over an HTTP proxy would simply ask for a TCP tunnel with CONNECT.
However, doing a GET https://[...], like for HTTP over HTTP proxy, works on the proxies I tested.

for inspiration; lua-resty-http does include proxy support; https://github.com/ledgetech/lua-resty-http

Thanks for the insiration.
Some features lua-resty-http supports:

Proxied HTTP is requested with a request like GET http://... while proxied HTTPS is requested with a CONNECT host:port
Two different proxy settings when proxying HTTP or HTTPS
A no_proxy setting, to specify which hosts shouldn't be reached over a proxy

For now, I do not intent to provide any of these features in the PR.
It seems sufficient to send a GET https://... to the proxy server. I just read the RFCs and it seems this does not break the specifications, but don't take my word for it.
I'll also test this against some proxies I find to check if this works in practice.


[stable/nextcloud] Bump to Nextcloud 17

Special notes for your reviewer:

Also fixed compatibility with Kubernetes 1.16 (kubernetes.io)

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/lgtm

/retest

link in robot comment is wrong / not working [1].

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/helm_charts/18170/pull-charts-e2e/1186968697391026182/


[issue #3895] fix non-partitioned topics create error

<--
Contribution Checklist

Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where XYZ should be replaced by the actual issue number.
Skip Issue XYZ if there is no associated github issue for this pull request.
Skip component if you are unsure about which is the best component. E.g. [docs] Fix typo in produce method.

Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

Each pull request should address only one issue, not mix up code from multiple issues.

Each commit in the pull request has a meaningful commit message

Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

(The sections below can be removed for hotfixes of typos)
-->
(If this PR fixes a github issue, please add Fixes #<xyz>.)
Fixes #3895
Motivation
non-partitioned topics create failed
Modifications

add validateTopicName function assignments topicName value.
remove getOrCreateTopic avoid exceptions ：

CompletionException: org.apache.pulsar.broker.service.BrokerServiceException$ServiceUnitNotReadyException: Namespace bundle for topic (persistent://public/default/topic_1) not served by this instance. Please redo the lookup. Request is denied: namespace=public/default

fix internalCreateNonPartitionedTopic function non-partitioned topics create correctly.

./pulsar-admin topics create persistent://public/default/topic_1
$ ./pulsar-admin topics partitioned-stats  persistent://public/default/topic_1
Partitioned Topic not found

Reason: Partitioned Topic not found
./pulsar-client produce -m "hello world test again" -n 10 topic_1
./pulsar-client consume -n 0 -s test topic_1
----- got message -----
hello world test again
----- got message -----
hello world test again
...

Verifying this change

[✔ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

PR #3910 is better resolve this issue, thanks.


Add stateful backend service in service broker module

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@xing-yang @wisererik It's ok to be reviewed now

lgtm


Write Parts section of report

Base off of "parts section" in the report from last semester
Write in full paragraphs

I copied the parts section from last semester and removed the voltage divider circuit from the heart rate sensor part


Display additional resource types in tree

Original request from @doggy8088: https://github.com/brendandburns/vs-kubernetes/issues/41
There are 4 types now ( Deployments, Jobs, Pods, Services ). Would you like to add support for ConfigMaps?

We should more broadly review what to put in the tree view, and whether there are specific editing experiences what would be useful for particular resources such as ConfigMaps.

Config

Config Maps
Secrets

Closed via #47.


Support for go modules (automatically infer module path)?

Hi,
at $company, we have a bunch of Go projects named gitlab.$company.com/$project.
All projects use Go modules, i.e. there's a go.mod containing module gitlab.$company.com/$project.
$ head -1 go.mod
module gitlab.$company.com/$project

However, gci doesn't seem to make use of this information, compare the output of the following gci runs (with and without -local flag):
$ gci -d -local gitlab.$company.com/$project queue/client.go
[no output]
$ gci -d queue/client.go
--- queue/client.go.orig        2021-01-25 11:25:02.582529319 +0100
+++ queue/client.go     2021-01-25 11:25:02.582529319 +0100
@@ -11,7 +11,6 @@

        ws "nhooyr.io/websocket"
        "nhooyr.io/websocket/wsjson"
-
        "gitlab.$company.com/$project/turn"
 )

The client.go contains this import block:
import (
	"context"
	"encoding/json"
	"errors"
	"fmt"
	"log"
	"sync"
	"time"

	ws "nhooyr.io/websocket"
	"nhooyr.io/websocket/wsjson"

	"gitlab.$company.com/$project/turn"
)

Would this be a valid feature request? I'd like gci to lookup and use the module path when invoked without -local.

It is why -local exists, automatically check to infer module path works for some cases, while if repos use custom domain rather than  Github, it would do harm.

It is why -local exists, automatically check to infer module path works for some cases, while if repos use custom domain rather than  Github, it would do harm.

automatically check to infer module path works for some cases

Hmm... Looking at the code (ProcessFile → processFile → newPkg → getPkgType in gci.go), I don't see how that would work. Only if I provide a -local flag, getPkgType will return local: https://github.com/daixiang0/gci/blob/7eb50f3def6fe64ad9acc134b09a7d353035bc0a/pkg/gci/gci.go#L159-L171
For example, with this directory structure:
./
+-- go.mod               (module foo)
+-- internal
|   +-- service
|       +-- service.go   (package service)
+-- main.go              (package main, imports foo/internal/service)

there should be no difference between gci -local foo ./ and gci ./. Do you know what I mean?
For this to work, gci would need to find a go.mod, extract the module path from its module directive, and wire the module path down to getPkgType. I'd be OK if this only works if -local is not present on the command line.
I'll try to come up with a better example/PR later when I'm back home.

automatically check to infer module path works for some cases

Hmm... Looking at the code (ProcessFile → processFile → newPkg → getPkgType in gci.go), I don't see how that would work. Only if I provide a -local flag, getPkgType will return local: https://github.com/daixiang0/gci/blob/7eb50f3def6fe64ad9acc134b09a7d353035bc0a/pkg/gci/gci.go#L159-L171
For example, with this directory structure:
./
+-- go.mod               (module foo)
+-- internal
|   +-- service
|       +-- service.go   (package service)
+-- main.go              (package main, imports foo/internal/service)

there should be no difference between gci -local foo ./ and gci ./. Do you know what I mean?
For this to work, gci would need to find a go.mod, extract the module path from its module directive, and wire the module path down to getPkgType. I'd be OK if this only works if -local is not present on the command line.
I'll try to come up with a better example/PR later when I'm back home.

I have started an example in #31. Some notes:

The implementation of type moduleResolver might be incomplete,  I haven't written any tests (yet, I'll add some tomorrow)

I'm not sure if this works properly on Windows
it also doesn't deal with symlinks

The important bit is the integration in gci.processFile, where modCache.Lookup happens only if set.LocalFlag is empty.
ClearModCache is virtually superfluous in main.go, but I've kept it there for completeness.

I have started an example in #31. Some notes:

The implementation of type moduleResolver might be incomplete,  I haven't written any tests (yet, I'll add some tomorrow)

I'm not sure if this works properly on Windows
it also doesn't deal with symlinks

The important bit is the integration in gci.processFile, where modCache.Lookup happens only if set.LocalFlag is empty.
ClearModCache is virtually superfluous in main.go, but I've kept it there for completeness.

I also think this is confusing that gci does not find local module name automatically.

Hello, i have the same need :)
This issue still in progress ? Or always planned ?

I find myself hard-pressed to continue the work started in #31, feel free to take over :)

There are some packages that might help resolving the module name:

https://pkg.go.dev/golang.org/x/mod/modfile
https://pkg.go.dev/golang.org/x/tools/go/packages


please change xubuntu logo

@ekto whats wrong with the current one?

@elkowar can we close this? I think that the logos should all stay as text-logo, and plus OP doesn't use xubuntu anymore.

Sure!


Is it possible to specify a response type if expecting a response from the upload method

Looking at a answer here which would allow to download a BLOB of a file and display it in browser:
http://stackoverflow.com/questions/21628378/angularjs-display-blob-pdf-in-an-angular-app
It specifies that we would have to specifically declare the responseType (in my case an 'arraybuffer').
Is it possible to do something like:
```
$scope.upload = Upload.upload({
        url: "../api/Upload", // webapi url
        method: "POST",
        file: controllerFile,
        responseType: 'arraybuffer'
    }).progress(function (evt) {
        // get upload percentage
        console.log('percent: ' + parseInt(100.0 * evt.loaded / evt.total));
    }).success(function (data, status, headers, config) {
        // file is uploaded successfully
        console.log(data);

        var fileBack = new Blob([(data)], { type: 'application/pdf' });
        var fileURL = URL.createObjectURL(fileBack);
        $scope.content = $sce.trustAsResourceUrl(fileURL);

    }).error(function (data, status, headers, config) {
        // file failed to upload
        console.log(data);
    });

Without the line: 'responseType:'arraybuffer' nothing throws any warnings or anything but with that line upon reaching this controller in the console I see:

GET http://localhost:54170/Client/{{content}} 404 (Not Found)

Add it to the headers.

@danialfarid, @admsugar  The responseType property on the Angular $http service options object doesn't set HTTP headers, it sets the underlying property on the XMLHttpRequest. This property, as detailed further here.
Setting that property doesn't result in any change to the HTTP headers in the request, but changes how the response is processed. In the case of 'arraybuffer', that means the response object will be of type ArrayBuffer.
With the Upload.upload function, the data property on the response object appears to always be formatted as a string. But if the response from the server was binary, that effectively destroys the data.

Hi Just replace responseType: 'arraybuffer' with options:{responseType: 'arraybuffer'} .


Use inttypes.h for 32 bit signed/unsigned format specifiers.

This fixes commit<PHONE_NUMBER>55c5dacf60fb6b18930c288336dce1 on 32-bit ARM with GCC 8.3.0 (among others).

This introduces need for C99 compiler. I have no idea if we already need one?
Can someone please give me a second opinion on that?

Hi Martin , snprintf is part of C99 standard.


(change) event not triggered in ng2-selectize

Hi,
(change)=onValueChange($event) does not seem work with ng2-selectize. The onValueChange function is never called even after a change occurs.
Thanks.

Hey @nanya, could you please try using (ngModelChange) instead and see if that works for you? Please reference the sample here: https://github.com/NicholasAzar/ng-selectize-demo/blob/master/src/app/home/multi-select-example/multiSelectExample.component.html#L5

Hi Nicholas, yes the (ngModelChange) works, however, there are cases when a change occurs in the select component (e.g. when a new item is added to the options list dynamically) and the $event (that is the value of the model) of the (ngModelChange) is "" which raises an error in my code. It would be nice to have an (change) event that does not make the ngModel equals to "". Thanks.

Hey @nanya, from my testing I wasn't able to replicate the scenario where adding a new option to the dropdown triggers the ngModelChange with an empty value. If there is a change in the selected value though, if the currently selected value is removed as an option for example, reflecting that the value has changed is correct. I'm struggling to understand why an entirely new event would be preferable to just adding an empty value check in the callback.
I'm going to close this issue for now, but if i'm not understanding the issue properly let's please continue the conversation and maybe it would help if you provided a example of when this event is necessary.

Hi @NicholasAzar, I believe adding a change event would be helpful and also to keep things consistent with Angular2 (I am not sure but I think Angular 2 has a change event and an ngModelChange event).
Thanks for your help.


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
7a7fcefb2a4b5ff9f9e58e26d6f4d98d76ac4343
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


WIP: update settings for MathJax v3

This is a draft to play around with https://github.com/sphinx-doc/sphinx/pull/8971.
Currently, this raises a spurious warning when using the above PR.
Hopefully this can be improved.
See also https://github.com/sphinx-doc/sphinx/issues/8195.

Hello @mgeier! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file doc/conf.py:

Line 77:13: E201 whitespace after '{'

Superseded by #558.


Custom parser other than sscanf()/sprintf()

🚧 In progress
Building a custom itoa/ftoa/atoi/atof functions.
It is because in some compiler in embedded system does not support printf("%f");, due to program and memory size.

Currently NUCLEO example is not working.
Arduino, x86/64 are working well. I have to figure out why.


Upgraded to Go 1.18.

Dependencies upgraded.
Signing method parameter changed to more granular signing algorithm.

Codecov Report

Merging #43 (54b6a70) into master (7d48bf1) will increase coverage by 1.86%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   82.26%   84.12%   +1.86%
==========================================
  Files           6        6
  Lines         327      315      -12
==========================================
- Hits          269      265       -4
+ Misses         48       47       -1
+ Partials       10        3       -7

Impacted Files
Coverage Δ

services/config_parser.go
100.00% <ø> (ø)

main.go
31.34% <16.66%> (-2.00%)
:arrow_down:

services/authenticator.go
94.44% <100.00%> (+13.49%)
:arrow_up:

services/authorizer.go
96.92% <100.00%> (+0.69%)
:arrow_up:

services/server.go
100.00% <0.00%> (ø)

services/route_matcher.go
100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Triplet loss

This PR is only the triplet loss from #1225

Great!! Please fix the reference manual. https://github.com/pfnet/chainer/blob/master/docs/source/reference/functions.rst

LGTM!


Config file seems to gets overwritten in 0.5.0

Doesn't happen with the latest (main branch) version of snakebids, so not sure it is worth investigating, but would be nice to have a release that fixes this behavior.

Do you know what code change in the main branch leads to this behaviour change? I'm putting together a 0.5.1 release anyway, but I'm not sure what exactly you're referring to.

Never mind, I figured out the problem. We had a PR way long ago about this #121, but it got lost in the v0.5.0 release and only redone in the 6th.


Retrieving artifacts from this action

Hi,
First thank you for the nice action, it worked where the container/uses approach failed.
But how would I best upload the result of doing work inside the container to either a next step or for the artifacts?
-Morten

Hi @mbogh,
There a couple of ways you can do this.

If it's a file you want to output, mount the github workspace as a volume like in the README example. Any files created should be available in the workspace of following steps that run outside of the docker-run-action.
If you want to output parameters, you can also do that by echoing the output parameter like so https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-output-parameter

I hope that answered your question.

Problem with the volume mounting is permissions. The image I use, does not use the root user and it fails to write to the volume. I ended up simply adding  --user 0:0 as a workaround :(
But thanks 🦦

@mbogh That's odd. Good to know that you've found a workaround. I'm just curious - if the docker image is public, can you share it with me and also the workflow steps with your fix? I'd like to test it and maybe document it in the README.


fix exception during locale detection

Under certain circumstances for example if $LANG is unset in the
environment, getdefaultlocale can return the tuple (None, None).
This in turn would cause an Exception to be raised by join at least
in Python 3.6, as it expects the iterable to contain strs. The result
was the following error message:
Error (locale): sequence item 0: expected str instance, NoneType found

Unfortunately the tests for the system info detection would then crash
making the test-suite fail. To mitigate this, we now cast everything
returned by getdefaultlocale to str to make sure that the call to
join will succeed. The output will then be None.None which is fine
as it indicates that no default locale was detected.

This is a fix for changes introduced in #5591. Additional bugs were detected by the internal build farm and are fixed by this.

Internal build-farm ID: numba_175

Pulled this into https://github.com/numba/numba/pull/5791 too.

Closing this as it got merged as part of #5791. Thanks for fixing @esc.

🍰


Z-wave service component sends wrong value for parameter

Home Assistant release (hass --version):
0.44.1
Python release (python3 --version):
Python 3.4.2
Component/platform:
"Call a service from a component" tab.
Description of problem:
Trying to issue Z-wave command to set a parameter, but HA send a different value than entered.
Domain:
zwave
Service:
set_config_parameter
Service Data (JSON, optional):
{
"node_id": 8,
"parameter": 100,
"value": 0,
"size": 1
}
Value logged in OZW_Log.txt is 1 instead of 0.
Values entered; values sent to dimmer.
0; 1
1; 2
2; 3
3; 4
4; 5
5; 6
6; 0
7; 9
The values sent to the dimmer correlates with the order the parameters are written in the z-wave configuration XML file for the dimmer instead of the "value" in each row of the XML.
Expected:
I expect the value entered in the JSON to be sent to the slave.
Additional info:
Controller: z-wave.me
Slave: Qubino dimmer, ZMNHDD1
Z-wave configuration XML:
<Value type="list" genre="config" instance="1" index="100" label="Enable / Disable Endpoints I2 or select Notification Type and Event" units="" read_only="false" write_only="false" verify_changes="false" poll_intensity="0" min="0" max="9" vindex="7" size="1">
  <Help>Enabling I2 means that Endpoint (I2) will be present on UI. Disabling it will result in hiding the endpoint according to the parameter set value. Additionally, a Notification Type and Event can be selected for the endpoint. Endpoint device type selection: notification sensor (1 - 6) sensor binary (9). NOTE: After parameter change, module has to be re included into the network in order setting to take effect! Default value 1.</Help>
  <Item label="Home Security; Motion Detection, unknown location." value="1" />
  <Item label="Carbon Monoxide; Carbon Monoxide detected, unknown location." value="2" />
  <Item label="Carbon Dioxide; Carbon Dioxide detected, unknown location." value="3" />
  <Item label="Water Alarm; Water Leak detected, unknown location." value="4" />
  <Item label="Heat Alarm; Overheat detected, unknown location" value="5" />
  <Item label="Smoke Alarm; Smoke detected, unknown location" value="6" />
  <Item label="Endpoint, I2 disabled" value="0" />
  <Item label="Sensor binary" value="9" />
</Value>

OZW_Log.txt

Not much to add but I can confirm this is happening.


RKE2ControlPlane have no IP Address available - stuck in WaitingForRKE2Server

What happened:
I'm trying to combine the Syself Hetzner CAPI Provider with RKE2 Bootstrap / Control-Plane Provider. My RKE2ControlPlane get's never ready because of a missing ExternalIP in the object.
My machines get created successfully but RKE2 is unable. I'm getting the following error from the rke2-control-plane-controller-manager pod on my clusterapi-mgt-cluster
E0720 14:15:42.233283       1 controller.go:326]  "msg"="Reconciler error" "error"="some Control Plane machines exist and are ready but they have no IP Address available" "RKE2ControlPlane"={"name":"hetzner-capi-rke2-demo-control-plane","namespace":"default"} "controller"="rke2controlplane" "controllerGroup"="controlplane.cluster.x-k8s.io" "controllerKind"="RKE2ControlPlane" "name"="hetzner-capi-rke2-demo-control-plane" "namespace"="default" "reconcileID"="61571849-1712-43d1-af9f-2b7f2860948f"

The cluster is therefore stuck in the "WaitingForRKE2Server"-State
~/kube/hetzner-clusterapi-rke2 on  main ⌚ 16:20:16
$ clusterctl describe cluster hetzner-capi-rke2-demo
NAME                                                                                READY  SEVERITY  REASON                SINCE  MESSAGE
Cluster/hetzner-capi-rke2-demo                                                          False  Info      WaitingForRKE2Server  16m
├─ClusterInfrastructure - HetznerCluster/hetzner-capi-rke2-demo
└─ControlPlane - RKE2ControlPlane/hetzner-capi-rke2-demo-control-plane                  False  Info      WaitingForRKE2Server  16m
  └─Machine/hetzner-capi-rke2-demo-control-plane-zs76h                                  True                                   18m
    └─MachineInfrastructure - HCloudMachine/hetzner-capi-rke2-demo-control-plane-wvhml

On the node-itself, i can see that the Node is ready
root@hetzner-capi-rke2-demo-control-plane-wvhml:~# /var/lib/rancher/rke2/bin/kubectl  get nodes
NAME                                         STATUS   ROLES                       AGE    VERSION
hetzner-capi-rke2-demo-control-plane-wvhml   Ready    control-plane,etcd,master   6m8s   v1.24.6+rke2r1

It seems like the ExternalIP is available in the machine object gets populated correctly.
$ k get Machine hetzner-capi-rke2-demo-control-plane-zs76h -o yaml
apiVersion: cluster.x-k8s.io/v1beta1
kind: Machine
metadata:
  annotations:
    controlplane.cluster.x-k8s.io/rke2-server-configuration: '{"disableComponents":{},"cni":"calico","etcd":{"backupConfig":{}}}'
  creationTimestamp: "2023-07-20T14:01:03Z"
  finalizers:
  - machine.cluster.x-k8s.io
  generation: 3
  labels:
    cluster.x-k8s.io/cluster-name: hetzner-capi-rke2-demo
    cluster.x-k8s.io/control-plane: ""
  name: hetzner-capi-rke2-demo-control-plane-zs76h
  namespace: default
  ownerReferences:
  - apiVersion: controlplane.cluster.x-k8s.io/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: RKE2ControlPlane
    name: hetzner-capi-rke2-demo-control-plane
    uid: 3a252df3-1dc7-492c-b6fc-dbdfa82154ec
  resourceVersion: "15555"
  uid: cbb181b8-ab14-4c69-b50c-ad4a7601d3ce
spec:
  bootstrap:
    configRef:
      apiVersion: bootstrap.cluster.x-k8s.io/v1alpha1
      kind: RKE2Config
      name: hetzner-capi-rke2-demo-control-plane-cp9bn
      namespace: default
      uid: d1a75f0c-9b1d-4c43-a003-1398d361b6d1
    dataSecretName: hetzner-capi-rke2-demo-control-plane-cp9bn
  clusterName: hetzner-capi-rke2-demo
  failureDomain: nbg1
  infrastructureRef:
    apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
    kind: HCloudMachine
    name: hetzner-capi-rke2-demo-control-plane-wvhml
    namespace: default
    uid: 74f3be66-56cb-457e-af5a-319e38e7ff09
  nodeDeletionTimeout: 10s
  nodeDrainTimeout: 2m0s
  providerID: hcloud://35073299
  version: v1.24.6
status:
  addresses:
  - address: <IP_ADDRESS>
    type: ExternalIP
  - address: 2a01:4f8:c2c:f2c6::1
    type: ExternalIP
  bootstrapReady: true
  conditions:
  - lastTransitionTime: "2023-07-20T14:01:28Z"
    status: "True"
    type: Ready
  - lastTransitionTime: "2023-07-20T14:01:03Z"
    status: "True"
    type: BootstrapReady
  - lastTransitionTime: "2023-07-20T14:01:28Z"
    status: "True"
    type: InfrastructureReady
  - lastTransitionTime: "2023-07-20T14:02:37Z"
    reason: NodeProvisioning
    severity: Warning
    status: "False"
    type: NodeHealthy
  infrastructureReady: true
  lastUpdated: "2023-07-20T14:01:39Z"
  observedGeneration: 3
  phase: Provisioned

but is then missing from the RKE2ControlPlane object.
$ k get RKE2ControlPlane hetzner-capi-rke2-demo-control-plane -o yaml
apiVersion: controlplane.cluster.x-k8s.io/v1alpha1
kind: RKE2ControlPlane
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"controlplane.cluster.x-k8s.io/v1alpha1","kind":"RKE2ControlPlane","metadata":{"annotations":{},"name":"hetzner-capi-rke2-demo-control-plane","namespace":"default"},"spec":{"agentConfig":{"version":"v1.24.6+rke2r1"},"infrastructureRef":{"apiVersion":"infrastructure.cluster.x-k8s.io/v1beta1","kind":"HCloudMachineTemplate","name":"hetzner-capi-rke2-demo-control-plane"},"nodeDrainTimeout":"2m","replicas":1,"serverConfig":{"cni":"calico"}}}
  creationTimestamp: "2023-07-20T14:01:00Z"
  finalizers:
  - rke2.controleplane.cluster.x-k8s.io
  generation: 1
  labels:
    cluster.x-k8s.io/cluster-name: hetzner-capi-rke2-demo
  name: hetzner-capi-rke2-demo-control-plane
  namespace: default
  ownerReferences:
  - apiVersion: cluster.x-k8s.io/v1beta1
    blockOwnerDeletion: true
    controller: true
    kind: Cluster
    name: hetzner-capi-rke2-demo
    uid: 2dac05ba-0c65-46fa-9b5d-0a695513d2f2
  resourceVersion: "15860"
  uid: 3a252df3-1dc7-492c-b6fc-dbdfa82154ec
spec:
  agentConfig:
    version: v1.24.6+rke2r1
  infrastructureRef:
    apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
    kind: HCloudMachineTemplate
    name: hetzner-capi-rke2-demo-control-plane
  manifestsConfigMapReference: {}
  nodeDrainTimeout: 2m0s
  privateRegistriesConfig: {}
  replicas: 1
  serverConfig:
    cni: calico
    disableComponents: {}
    etcd:
      backupConfig: {}
status:
  conditions:
  - lastTransitionTime: "2023-07-20T14:03:50Z"
    reason: WaitingForRKE2Server
    severity: Info
    status: "False"
    type: Ready
  - lastTransitionTime: "2023-07-20T14:01:03Z"
    reason: WaitingForRKE2Server
    severity: Info
    status: "False"
    type: Available
  - lastTransitionTime: "2023-07-20T14:01:02Z"
    status: "True"
    type: CertificatesAvailable
  - lastTransitionTime: "2023-07-20T14:03:50Z"
    status: "True"
    type: MachinesReady
  - lastTransitionTime: "2023-07-20T14:03:50Z"
    status: "True"
    type: Resized
  initialized: true
  observedGeneration: 1
  readyReplicas: 1
  replicas: 1
  updatedReplicas: 1

Thanks in advance!
What did you expect to happen:
RKE2ControlPlane should switch to ready state
How to reproduce it:
Clone the following repository https://github.com/localleon/hetzner-clusterapi-rke2  and apply  hetzner-capi-rke2-demo.yaml to you're clustesr.
Anything else you would like to add:
I would think this issue lies in this function of
func getIPAddress(machine clusterv1.Machine) (ip string, err error) {
	for _, address := range machine.Status.Addresses {
		switch address.Type {
		case clusterv1.MachineInternalIP:
			if address.Address != "" {
				return address.Address, nil
			}
		case clusterv1.MachineExternalIP:
			if address.Address != "" {
				ip = address.Address
			}
		}
	}

	if ip == "" {
		err = fmt.Errorf("no IP Address found for machine: %s", machine.Name)
	}

	return
}

[Miscellaneous information that will assist in solving the issue.]
Environment:
providers:
  - name: "rke2"
    url: "https://github.com/rancher-sandbox/cluster-api-provider-rke2/releases/v0.1.0-alpha.1/bootstrap-components.yaml"
    type: "BootstrapProvider"
  - name: "rke2"
    url: "https://github.com/rancher-sandbox/cluster-api-provider-rke2/releases/v0.1.0-alpha.1/control-plane-components.yaml"
    type: "ControlPlaneProvider"
  - name: "docker"
    url: "https://github.com/belgaied2/cluster-api/releases/v1.3.3-cabpr-fix/infrastructure-components.yaml"
    type: "InfrastructureProvider"

OS (e.g. from /etc/os-release): Hetzner Cloud Ubuntu 22.04

This seems to be fixed in the newest version and i was just confused why an old version of the CAPI-Provider was in the README


New release

We'd like to make a new release so we can get #307 in. However there have been changes to the native library as well which means we need to make a new release of Askar as well. I'm not sure if #291 introduced breaking changes? So do we need to go to the next 0.3.x, or to 0.4.x?

@andrewwhitehead

@TimoGlastra — can you or @berendsliedrecht weigh in on #312 and particularly, the NDK version that can be used for Android.  We need that PR merged before a new release — and we also want a new release.
Thanks

@TimoGlastra no breaking changes in #291 - just change to default behaviour that fetched records are now ordered by id.
ACA-Py PR is also waiting for a new release: https://github.com/hyperledger/aries-cloudagent-python/pull/3173
We've merged that ordering functionality to our ACA-Py fork (with forked askar release), and everything's working well :-)

What's holding up the publishing of a new release? Something we can help with?

Yes!!  The hold up is the android build of the react-native wrapper and a dependency mess, where some dependencies require a higher version of Rust, and other dependencies require a lower one (1.67 and 1.74).  I don’t really understand it all, but I know that the build is failing, and no one has had the time to get it resolved.  @cvarjao has a repo “aries-builder-images” that is related, but I don’t know the details.
My goal is to get that sorted out, and to get some documentation about the steps to do a release, so we are less dependent on individuals (although I’m not sure that is the issue here).  Documentation is good.

The main issue is that underline libraries such as askar, vdr, etc needs to align/agree on target android NDK (and minimum android version support). I am definitely not opposed with keeping the NDKs up-to-date.
Google Play services v23.30.99+ (August 2023) drops support for API levels below 21, so going to ndk 25+ (28 is the most recent), I think should be fine

Rust 1.68 moved to NDK 25 as the minimum supported version and it looks like that is the minimum for Bifold at the moment, so I don't think we need to increase it further (for now).

I discussed this with @berendsliedrecht and he said the approach should just be to try it with newer NDK versions and make sure all the SDKs still work


bug: usePostList type cannot be overridden by declare

this is correct
import { Post } from 'valaxy'

this is wrong
import { usePostList } from 'valaxy'
const posts = usePostList()
posts.value[0]

I didn't find a good way to cover it. Is there an example can refer to?

Got it. If i import if from root and then export, it will works.


[GOBBLIN-1507] Prevent orchestrator removals when unscheduling flows

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1507

Description

[x] Here are some details about my PR, including screenshots (if applicable):

When demoted from leader, GaaS removes all flows from orchestrator. We need to ensure that fail over events are not disruptive or destructive to currently running flows, we only want the new leader node to handle scheduling responsibilities from that point forward.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3353 (df1e158) into master (f468bb0) will decrease coverage by 3.43%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3353      +/-   ##
============================================
- Coverage     46.42%   42.99%   -3.44%
+ Complexity    10115     1940    -8175
============================================
  Files          2052      394    -1658
  Lines         79626    16877   -62749
  Branches       8889     2076    -6813
============================================
- Hits          36970     7257   -29713
+ Misses        39216     8821   -30395
+ Partials       3440      799    -2641

Impacted Files
Coverage Δ

.../org/apache/gobblin/cluster/GobblinTaskRunner.java
63.46% <0.00%> (-0.33%)
:arrow_down:

.../apache/gobblin/runtime/task/TaskIFaceWrapper.java

...ecker/row/RowLevelPolicyCheckerBuilderFactory.java

...runtime/mapreduce/GobblinWorkUnitsInputFormat.java

...bblin/metastore/ZkStateStoreConfigurationKeys.java

...e/modules/flowgraph/datanodes/fs/SftpDataNode.java

.../java/org/apache/gobblin/writer/WriterWrapper.java

...n/converter/avro/UnsupportedDateTypeException.java

...bblin/metrics/context/filter/AllContextFilter.java

...lin/compaction/event/CompactionSlaEventHelper.java

... and 1648 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f468bb0...df1e158. Read the comment docs.


Cache info compatibility with APCu

From what I read in the code, this tool is not compatible with APCu.
Env

PHP Version 7.0.7
APC Compatibility	1.0.3
APCu Version 5.1.4
cachetool 2.0.6 (because I use Symfony 2) but master have the same issue

The issue
The apc:cache:info command fails:
$ ./bin/cachetool apc:cache:info --fcgi=/var/run/php-fpm.sock

Fatal error: Uncaught TypeError: Argument 1 passed to CacheTool\Command\ApcCacheInfoCommand::normalize() must be of the type array, null given, called in vendor/gordalina/cachetool/src/CacheTool/Command/ApcCacheInfoCommand.php on line 60 and defined in vendor/gordalina/cachetool/src/CacheTool/Command/ApcCacheInfoCommand.php:101

This is because this statement return null:
$this->getCacheTool()->apc_cache_info('system');

I'm not sure why exactly but the fact is that signatures for this method are different between APC and APCu, but the CacheTool always tries to call the old signature.
        $code->addStatement(sprintf(
            'return apc_cache_info(%s, %s);',
            var_export($cache_type, true),
            var_export($limited, true)
        ));

As the command expect both a "user" and a "system" cache infos from APC, maybe it should be fixed with a new command apcu:cache:info, because APCu only expose user cache. WDYT?
APCu
http://php.net/manual/fr/function.apcu-cache-info.php

array apcu_cache_info ([ bool $limited = false ] )

APC
http://php.net/manual/en/function.apc-cache-info.php

array apc_cache_info ([ string $cache_type = "" [, bool $limited = false ]] )

Ok blames on me, there is already a nice PR about this: https://github.com/gordalina/cachetool/pull/36

Someone should open again this PR as the fix of #36 did not solve the issue. I downloaded the 2.1.0 and the bug is still there.

Fatal error: Uncaught TypeError: Argument 1 passed to CacheTool\Command\ApcCacheInfoCommand::normalize() must be of the type array, null given, called in phar:///vagrant/cachetool.phar/src/CacheTool/Command/ApcCacheInfoCommand.php on line 61 and defined in phar:///vagrant/cachetool.phar/src/CacheTool/Command/ApcCacheInfoCommand.php on line 102
TypeError: Argument 1 passed to CacheTool\Command\ApcCacheInfoCommand::normalize() must be of the type array, null given, called in phar:///vagrant/cachetool.phar/src/CacheTool/Command/ApcCacheInfoCommand.php on line 61 in phar:///vagrant/cachetool.phar/src/CacheTool/Command/ApcCacheInfoCommand.php on line 102`

With the changes in #36 you have to call apcu:cache:info for it to work, and not apc:cache:info as I assume you did?


[stdlib] Rewrite UTF8._isValidUTF8()

What's in this pull request?

A rewrite of UTF8._isValidUTF8(), which further improves performance (mainly by removing branches) and reduces code size.

Non-ASCII: 35-45% speed-up
Invalid sequences: ~15% speed-up
ASCII: identical performance

Tested against original implementation for all input values (0...0xffffffff), results are identical.

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the github user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci Please test

@PatrickPijnappel There's a build failure, would you mind taking a look?

@gribozavr My bad! Will take a look and resolve.

@PatrickPijnappel This is brilliant!  Please fix the build issue, and I'll run the benchmarks.

@PatrickPijnappel Great stuff! :+1:

@gribozavr Ok fixed the issues and added some validation tests as well!

@swift-ci Please test

Added @testable and fixed the failing test, it now passes on my machine.

@swift-ci Please test

Running benchmarks.

I'm seeing >10% improvements for ErrorHandling, NSError, NSStringConversion, and SevenBoom.
@PatrickPijnappel If you have a targeted microbenchmark, feel free to contribute it to a new file under benchmarks.

@gribozavr Added a UTF-8 benchmark (#1493). I'm in the process of simplifying/optimizing the other parts of UTF-8 decoding so it'll be useful to have a benchmark!


Change docs in relation to moving Content

Content is not in GeonBit.UI anymore so the README should be updated.

Done, thanks


Infrastructure for Launching contracts to Test Network

For the 0.1.0 Computable launch, we'll need to launch our contracts onto a test network (ropsten, kovan, etc.). We've done a bit of this already, but it would be good to get this into the repo and documented so we have a standard launch process.
Marking this a blocker for 0.1.0 so we set up a standard launch process we can use in future releases.

Assigning to @robrobbins who's launched a few contracts onto test networks already.

Doing some reading, the most common way people do this is via truffle migrate:
https://truffleframework.com/docs/getting_started/migrations
Not clear yet if there's an easy way to just break out the migration code we need directly. Will do some more digging.


Starting nodes crash when the control plane is not available

They should not crash and wait for the control plane to become available. In the meantime, they should appear live but not ready.

Duplicate of #4647.


Fix/conditional rendering tabs item

[x] I have followed the Your First Code Contribution section of the Contributing guide

Summarize the changes made and the motivation behind them.
Reference related issues using # followed by the issue number.
If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.

@rluders Hi, should I rebase changes?

@rluders Hi, should I rebase changes?

Yes. No merge should be added to PR :)

Sorry! I closed the pull request. can you please re-open it?
@rluders

@paghar I actually can't re-open it. Just create a new PR.


Update documentation: Deprecating recursion

[ ] ~Tests added for any new code~
[ ] ~Ran make fmt-fix (or had formatting run automatically on all files edited)~
[x] Documentation added for any new functionality
[x] Entry added to UNRELEASED.md for any new functionality

Closes #1564.

Codecov Report

Merging #1565 (da1b1ef) into unstable (982447b) will increase coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head da1b1ef differs from pull request most recent head ea4e6b0. Consider uploading reports for the commit ea4e6b0 to get more accurate results

@@            Coverage Diff            @@
##           unstable    #1565   +/-   ##
=========================================
  Coverage     74.86%   74.87%
=========================================
  Files           360      360
  Lines         11554    11554
  Branches        544      544
=========================================
+ Hits           8650     8651    +1
+ Misses         2904     2903    -1

Impacted Files
Coverage Δ

.../forsyte/apalache/tla/pp/ConstSimplifierBase.scala
97.64% <0.00%> (+1.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982447b...ea4e6b0. Read the comment docs.

Preliminary question: Have we done anything yet to deprecate it in code? Is there a corresponding issue?

Preliminary question: Have we done anything yet to deprecate it in code? Is there a corresponding issue?

Nope, this will happen together with the follow-up to #1525, since Unroller currently uses InlinerOfUserOper.kStepInline.

Are we settled on this PR?

Are we settled on this PR?

Idk, @Kukovec can you mark resolved what has been resolved?


Integrate with My People app in Windows 10

Operating system: Windows 10 1709
Messenger for Desktop version: Newest available I guess, does not matter this is a feature proposal

Would it be possible to integrate this app with My People app in Windows 10? In the newest version of Win10 there is this possibility, however I am not sure if it would be possible to add this integration to this application. Could someone look into it?

Yes, that will be one of the best features for that app!


Not approved courses are public visible

Courses are visible in the public registry although they are not approved (by moderator)

solved in 2022-10

solved in 2022-10


docs: [IAC-2518]: IaCM Best Practices

Description

New reference doc to highlight the best practices for IaCM usage
JIRA

Screenshot / Preview
https://github.com/user-attachments/assets/a48a4028-bd9c-4844-9773-048d805dc2c5
PRs must meet these requirements to be merged:

[x] Successful preview build.
[x] Code owner review.
[x] No merge conflicts.
[x] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66f43334327f311066e9fd1a--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66f57cd953bccb00ef9b8c77--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66faabe5b1c9a80d56a2d1fc--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66fac138a1fee606b40fa46c--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66fac66fcc43f509eef3193f--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66fbb3fb59784ae95d07dbc8--harness-developer.netlify.app


Self-adaping background color for custom color palette

The self adaping bg color implemetation is great, but that doesn't work for custom color palette has only main colors, so I fetch these custom colors before the bg colors are calculated.

@fnune Thanks, but all it did is just make sure the priority is custom config > get_fg > hard code, I didnt add anything to the config, just read them.
And the reason I make this is when the custom highlights has only main colors,
        highlight = {
            red       = "#E06C75",
            orange    = "#ffcb6b",
            yellow    = "#FFE082",
            green     = "#C3E88D",
            cyan      = "#89ddff",
            blue      = "#82AAFF",
            purple    = "#C792EA",
        },

the rest background colors are caculated by the get_fg() values or the hard code ones instead of the custom highlight.

The defaults could be moved there, including get_fg("Error").

yep, the defaults table would base on priority custom > get_fg > default now, but I don't know why get_fg("Error") would be changed.
One last, we do can make a whole new color table just like default if you all think that is better.

I see, highlight is already a config option. I was looking for highlights and as nothing turned up I thought it wasn't there. MB!

yeah, the documents highlight part was just added few hours ago.

@CKolkey Hi, this commit will never change any colors or any thing whether users has no custom colors or users have their own custom color palettes as the last table merging:
https://github.com/NeogitOrg/neogit/blob/bae3412ea9ac31292e14e9090dde7cb118cd52c1/lua/neogit/lib/hl.lua#L131
it only affect users who want to customize or use the default primary color but don't want to configure the entire color palette, as it's kind of complex(#1499).
If this commit has any unintended side effects or if something related is in progress, please let me know. Thanks.

Hey, this is great! Thanks for the contribution.


First attempt at publishing the module from CI

Followed these to add my forge credentials so the CI can publish directly.
https://puppet.com/docs/puppet/6.17/modules_publishing.html#modules_publish_with_travis
https://docs.travis-ci.com/user/encryption-keys/
Most of the changes were done by:
travis encrypt --add ENCRYPTED_FORGE_PASSWORD="..."

For some reason, Travis didn't try and build that branch, maybe because the only changes are to its config file. I'm hoping making this a pull request will force it to process it and least show me I didn't bork it entirely...

OK, that's weird, Travis didn't do any tests before, you merged it into master. I must have messed something up...

OK, that's weird, Travis didn't do any tests before, you merged it into master. I must have messed something up...

Even weirder, it built my branch when I pushed a README change.


[CARBONDATA-3199]"show datamap" represents preaggregate datamap

[Problem] "show datamap" command doesn't represents preaggregate datamap, it only represents bloom filter datamap
[Solution]PreAggregateDataMapProvider save datamap schema on hdfs or s3, so that CarbonDataMapShowCommand can get all datamap
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
saveDataMapSchema

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/1942/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2151/

retest this please

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10198/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2154/

@qiuchenjian currently pre-aggregate datamap is not following the datamap interfaces as it was implemented before datamap framework. That is why not all datamap DDL works with pre-aggregate.  It is better to keep the pre-aggregate datamap untouched in this area until we decide whether to take MV datamap or pre-aggregate datamap.

@qiuchenjian currently pre-aggregate datamap is not following the datamap interfaces as it was implemented before datamap framework. That is why not all datamap DDL works with pre-aggregate. It is better to keep the pre-aggregate datamap untouched in this area until we decide whether to take MV datamap or pre-aggregate datamap.

@ravipesala  OK, I will close this PR. But "show datamap" can't return preaggregate ,but it's still called datamap,  which is strange.

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/10202/


Allow boolean_value_map to be passed in to plot_benefit

As well as order.
@arahuja

Coverage decreased (-0.1%) to 58.274% when pulling 02a41e39123bc31fa5bf29d3a850a8d7695f51c1 on benefit_function_fix into fc224c55cd4ebefe3f18c779043f715a2f0c69f9 on master.


Code-Block Widening

First, Thank you so much for this theme! It's amazing!
Second, My code blocks seem to be too narrow.

Is there anyway to adjust the width?
I will look through the sass code to find a solution.
Again, Thank you so much for the theme!

The width of the code blocks is governed by the width of the overall content, defined in style.sass line 72. Changing this will affect the width of the whole post.
With some refactoring, .highlight elements ([_elements.sass]) could be broken out to have an independent width.


README improvements

@bentiss
I made github mirroring and git-recepies for auto-build, when you make changes on github in source code it's automatically syncing to Launchpad and build debs in ppa.

@muzena want to update the README file to point to your PPA? seems like the best choice for the Ubuntu entry then (not sure if you'd be debian compatible too?)

@whot
I think it should work in debian too, I use debian files for building from Debian experimental and Debian is systemd distro too like ubuntu, so it should work on Debian.
If you want or you gave me permission, I can register on Launchpad ratbag, piper project then make ratbag, piper team, and make ppa insdide project team.
like this:
https://launchpad.net/nightingale
https://launchpad.net/~nightingaleteam

@whot
New Piper, libratbag nightly git build PPA repo:
https://launchpad.net/~libratbag-piper/+archive/ubuntu/piper-libratbag-git

@muzena  updated the wiki, thanks.

@whot
On Ubuntu is install command 'sudo apt install ratbagd' on Debian 'apt install ratbagd'
And you can update piper wiki for PPA and Piper installation 'sudo apt install piper' on Debian 'apt install piper'

@muzena updated, thanks. You should have wiki edit permissions btw. If not, let me know and I'll figure out where the missing toggle is...


Select CH profiles by name ?

Continuing some of the discussion that started in #1705.

But can't this be simplified enormously if we just give every profile that a GraphHopper instance supports (not only every CHProfile; every profile) a name in the configuration file?

But isn't this the case already ? For example we have graph.flag_encoder=foot,car|turn_costs=true. Not thinking about CH for a moment this means we can do routing for foot and car and for car we also get a turn cost extension (i.e. we can route with turn restrictions from OSM). Also we can use the different query parameters, like heading, alternative etc. And you mean all the different combinations should be listed upfront ?
For CH we have to list this upfront because the preparation needs to be done prior to the routing. One thing that def. can be improved is how these preparations are specified, #493. The other question is then how the request parameters are mapped to the preparations afterwards.
Say somebody sets up a GH server for a new app that has two CH profiles for two different user groups: one group moves around a city using bicycles preferring roads with bicycle lanes and another uses trucks and can only drive to certain parts of the city. I imagine the best to do would be to have a nice way to specify all the parameters that go into the CH preparation like the road weights, the blocked areas etc. (making this easy to configure is #493), then give this profile some (arbitrary) name, and afterwards select the profile using this name (maybe the app that is used knows the user group via login). So here it would be useful to give a profile a name/id and use this on the request.
Or thinking about the GH directions API: It is running for some fixed set of profiles. It would be easy to document what these profiles are and give them an id/name and then choose the profile by name on the request. This seems a lot more intuitive than having to specify the weighting, encoder, u-turn-costs and all this just so the request 'matches' one of the profiles (and in case it does not getting an error / or a slow algorithm if falling back to non-CH). Or even better add an endpoint to the server that lists all the available profiles.
Even for flexible CH it would be similar I think. Say there is the possibility to build a CH preparation 'on the fly'/while the server is running (which I very much hope it will be at some point). This will certainly take a lot of memory and the preparation needs to be stored or kept in memory etc. To use it later it has to have some name and to me its also the most obvious way to use nothing but this name to refer to this preparation.
Right now I cannot come up with a case where it would not be feasible to 1) lookup the documentation/special endpoint etc. of whatever GH server is running, 2) check what profiles are supported and find the name of the one that should be used, 3) run a route request with the name of the desired profile attached ?

What kind of request parameter should be used to select the profile: From #1838:

the configuration (with which the CH preparation is done) could be picked up via the vehicle and/or weighting parameters (?)

vehicle
weighting
a new one, e.c. ch.profile ?

Have now a use case that uses the configurable Weighting for CH preparation and without other bigger modifications and I better understand the requirements:
https://github.com/graphhopper/graphhopper/commit/40c2bbee03871a9d85fddd5ee15e526cb0709973#diff-34c31269f729871c0059410df746e62dR46
It was required to directly use the weighting=flex|truck as the CH profiles and the "base FlagEncoder" for vehicle parameter, which is a bit ugly. It would be cleaner if the vehicle parameter is not required. And using the weighting parameter only is not easily possible as just weighting=fastest is not sufficient and we would need weighting=fastest|car in general, which could break backward compatibility.
If we need to introduce a new parameter I would introduce a profile parameter, instead of a CH specific ch.profile parameter. As we would otherwise need a xy.profile parameter for all pre-calculated algorithms (like lm.profile)?

Fixed via #1934


created the user interface using CSS

Changes made to CSS files.
Note that the CSS is written inside the HTML.
You can add that to the CSS file and link the file path to the HTML through link tag.
Also now your app is completely responsive in mobile devices.

All work done


Doesn't show popup when adding a new document on relationship field with autosave enabled

Link to reproduction
No response
Describe the Bug
If a collection has relationship field, it shows Select input with + button attached in the edit view. When we are to add a new relationship item by clicking + button, the expected behavior would be showing popup to create a new document.
But when the related collection is configured with autosave enabled, the popup quickly disappears and the page is navigated to the new document page of the related collection.
To Reproduce
Define a category collection with autosave enabled:
    ...
    versions: {
        drafts: {
            autosave: true,
        },
    },
    fields: [
        {
            name: 'title',
            label: 'Title',
            type: 'text',
            required: true,
        },
    ],
    ...

And define category field in pages collection
{
    name: 'category',
    label: 'Category',
    type: 'relationship',
    relationTo: 'category',
};

In Pages edit view, click + button in Category field.
Payload Version
2.19.3
Adapters and Plugins
No response

@tigersoft6084 the fix for this will be available in the next 2.x release.


Dynamic agent label with hw.arch.x86&&sw.os.linux&&ci.agent.dynamic doesn't work

If no idle agent we'd like to trigger a dynamic agent for linux-x64 if specify label [hw.arch.x86&&sw.os.linux&&ci.agent.dynamic](https://ci.adoptium.net/label/hw.arch.x86&&sw.os.linux&&ci.agent.dynamic/). However no agent was triggered [hw.arch.x86&&sw.os.linux&&ci.agent.dynamic](https://ci.adoptium.net/view/Test_grinder/job/Grinder/8689/console) as expected. If the dynamic agents configuration has been changed?

Believe it is unrelated to https://github.com/adoptium/aqa-tests/pull/4931/ which is dockerAgents versus dynamicAgents, but assume it is more likely related to the Azure plugin being deprecated https://github.com/adoptium/infrastructure/issues/3199

https://github.com/adoptium/infrastructure/issues/3199 mentioned Azure VM Agents plugin was left at version 825.v470cb_9e7361a_, which worked before? Feel like the configuration of Azure VM Agent Template has changed. Not sure as I don't have permission to see the configuration.

CC @sxa and @gdams - might need a closer look here

The ability to dynamically provision from Azure has been broken for quite some time so we have not been able to use it. 3199 will need some time on it in order to recover it. This was initially notices as part of https://github.com/adoptium/infrastructure/issues/2988 (so dates back to March 2023) when the Alpine builds were dependent on it (we removed that dependency to resolve the problem)
Since the faulty plugin is being deprecated soon an alternative needs to be evaluated as per issue 3199 if the functionality needs to be reinstated for anything.

Also I'm not certain which version of the plugin we last used successfully. Updating it to the new version would be an option, but it would need analysis of the options and settings as per the warning in 3199.
I suggest we continue any further conversation in that issue.

Can I just check what the reason is for wanting this functionality enabled as it's not clear from this issue. We have previously had lots of agents available and we haven't moved any as part of the equinix migration yet. Are we seeing capacity issues somewhere or is something else driving this request?


fix(logo-grid): adding bottom margin to logo-grid-item, resolves #9005

Related Ticket(s)
fix #9005
Description
Adding spacing under each grid in small screen
Changelog

I have read the DCO document and I hereby sign the DCO.


Diff failing on Windows

On Windows 7 and Windows server 2012, the code didn't work as expected. Even when two completely different files were passed, the diff returned success. On digging further, noticed that the crop function called on gm always produced a one by one pixel file.
this.crop(params.toWidth, params.toHeight, 0, 0);
After using gm without imagemagick, (so using graphicsmagick instead) the code succeeded.
Any ideas about this?
If we have the option to use imagemagick or graphicsmagick from this module, that will solve the problem.

Can you explain how you used gm with Graphics Magick? I want to make sure I'm not assuming anything

Just had to change the line
var gm = require('gm').subClass({imageMagick: true});
to
var gm = require('gm');
Thanks!

Cool, thought so but wanted to make sure it wasn't you running gm compare on the CLI =P
I think adding an option for disabling ImageMagick sounds reasonable. Let's go with the name imageMagick for consistency with gm (we can make it default to true for backwards compatibility).
imageDiff({imageMagic: false, actualImage, ...})

Would you be interested in writing a PR for this?

Sounds good, will do, thanks!

After getting the problematic images, we were able to track down the source of the problem and open a PR that seems to patch the issue. More specific details can be found on the PR itself
#34
If you would like to try out the PR locally, then it can be installed via a git URL via npm:
https://docs.npmjs.com/files/package.json#git-urls-as-dependencies
"image-diff": "git://github.com/twolfson/image-diff#ef3aa9f"