remove VtGateExecutor and add TabletExecutor

Stop applying schema changes through VtGate, using tabletmanager instead.
Update Executor api to not accept a list of shards as input. Schema
changes need to apply to all shards.
Fix topo in SimpleDataSourcer.

LGTM

add one more test case and TabletExecutor.Validate should return err when sql syntax is invalid.


Specify maxparallel in chmod

Motivation:
Some OS limit the number of files which a chmod can change in once.
So we have to limit the number not to raise an error.

Thanks, @minwoox !


Please make child components to be able to redeclare parent's component layout defined in NuxtLayout

Describe the feature
I saw a lot of similar issues about that (for example - https://github.com/nuxt/nuxt/issues/19762) but there is still a problem with redeclaring nuxt layouts in child components.
I created a reproduction for example - https://stackblitz.com/edit/github-bzckfe-r7uiho?file=layouts%2Fparentlayout.vue,pages%2Fparent%2Fchild2.vue,layouts%2Fcustom.vue,pages%2Findex.vue
As you can see in my reproduction build, component named "child2" has it's own NuxtLayout defined and it's rendering inside parent's layout.
And it's the same problem if I use condition check in parent component
<NuxtLayout name="$route.meta.layout || 'parentLayout'"></NuxtLayout>
and in child component by using definePageMeta({ layout: 'custom' });
it still rendering inside parent's layout.
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

I'm not sure I understand the issue.

@danielroe I think the idea is that the child component should be able to change the layout of the page (which I don't think is possible with SSR being rendered top to bottom).

You can use setPageLayout in a plugin or middleware to set the layout before the parent starts to render. Or you can use definePageMeta to override the layout from the child.
If you explicitly set <NuxtLayout name="parentlayout"> then this is not overrideable. (Passing an explicit layout name is the override in this case.)


Add support for Linux primary selection (copy&paste) in PyCharm plugin

Heya, this throws me every time, even though I've been using Supermaven happily for quite a while now:
In contrast to how basically everything else works in PyCharm, when I make a selection in the Supermaven chat window I can't just paste it with the middle mouse button into any destination, I have to manually copy & paste using the clipboard selection.
It would be great if Supermaven would align with the default OS selection type(s).

it's the vim plugin repo

Ups, sorry 🙄


Support writing text to the host's clipboard

Describe the feature
It would be useful to be able to send text to the host OS clipboard.
To Reproduce
Steps to reproduce the behavior:

As per PICO-8: printh('test','@clip').
Command seems to execute, but no text is written to clipboard.

Expected behavior
Feature not implemented.
Software (please complete the following information):

OS: [macOS
Version: v0.1.0b

Seems to be supported with set_clipboard("foo") ...?

Re-tested with release v0.1.0g on macOS. Problem still exists.


Remove sync.WaitGroup from production code in adsc

sync.WaitGroup is only present because tests depend on this. Tests can be written in a way that will not require this by using retry with backoff. This is a much safer solution with a built in timeout. This will remove the risk of production code changing in a way that will cause this particular test to wait forever.
Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Hi @afterlook. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afterlook: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0bf42801ef635987d675e46f7cfcb375aee5de4d
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@afterlook: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0bf42801ef635987d675e46f7cfcb375aee5de4d
link
true
/test lint

gencheck_istio
0bf42801ef635987d675e46f7cfcb375aee5de4d
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@afterlook: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f1a6f92ab3452cb9a67266b32cfc2c2221dd15c9
link
unknown
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


[WIP] Error fixes and improvements

I'm not done with this branch so not ready to merge yet! Noting down the current status and next steps to keep everyone in loop.
What's done:

Fixed overflow error
TWAP based on an hour, rather than last 6 points (which might not be an hour)

What's left:

Include tolerance parameter for TWAP window
Do not accept duplicate values from brownie. Otherwise/additionally, explore graph implementation for robustness.

@mikeyrf should we close this for now since Sushi is de-prioritised?


fix(cli): authenticate to get keys

Summary by CodeRabbit

New Features

Enhanced authentication logic for cloud key retrieval to ensure valid session checks before accessing device-specific keys.

Bug Fixes

Improved error handling to prevent attempts to access cloud keys when authentication fails, reducing potential API misuse.

Tests

Added an asynchronous test for _get_keys to validate key retrieval and caching behavior under various scenarios, improving overall test coverage.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.57%. Comparing base (179eae2) to head (c35efb7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   37.55%   37.57%   +0.02%
==========================================
  Files          84       84
  Lines        7446     7449       +3
==========================================
+ Hits         2796     2799       +3
  Misses       4650     4650

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[spi_device] Instantiate spid_addr_4b on SPI_DEVICE

This commit revises CSR to change CFG.addr_4b_en to be sw/hw read/write.
Also the commit creates spid_addr_4b instance on SPI_DEVICE HWIP.
Now, cfg_addr_4b_en that is broadcasted to multiple submodules
(readcmd, passthrough) is generated from spid_addr_4b module. The HW
control path (set/clear of cfg_addr_4b_en) is not implemented yet.
Cmdparse submodule will receive the opcodes for the two commands and
generates event signals to change cfg_addr_4b_en value.
This PR contains #9649

Merging now.


hostname resource will continually reboot if Windows and domain member

Description
new Chef 14 hostname will continually detect drift on name if node is domain member
Chef Version
v14.1.1
Platform Version
Windows Server 2012 R2
Replication Case
Set hostname resource on a Windows node that is a domain member
I believe this is because of this:
https://github.com/chef/chef/blob/92d85cf4c67680d778cbe8bc5c676f9a10fa1442/lib/chef/resource/hostname.rb#L220
# update via netdom
declare_resource(:powershell_script, "set hostname") do
  code <<-EOH
    $sysInfo = Get-WmiObject -Class Win32_ComputerSystem
    $sysInfo.Rename("#{new_resource.hostname}")
  EOH
  notifies :request_reboot, "reboot[setting hostname]"
  not_if { Socket.gethostbyname(Socket.gethostname).first == new_resource.hostname }
end

The guard should probably look at either the output of the command hostname or the environment variable ENV['COMPUTERNAME'].  Either way Socket.gethostname will return the FQDN in Windows which will not match the requested hostname.

I "solved" my problem like this ( please notice that node['name'] is properly set for me during chef bootstrap, but you can use any other variable instead) :
if node['hostname'] != node['name']
  # without this IF, we get a reboot loop. lovely !
  # and it seems this is a known 2 year old bug
  # https://github.com/chef/chef/issues/7255
  hostname 'chef_hostname' do
    hostname node['name']
    windows_reboot true
    action :set
  end
end


wrong link

In card.astro the href in

leads to general oeaw and not specific nomad project site (https://www.oeaw.ac.at/about - should be probably - https://www.oeaw.ac.at/iran/nomansland/about) as in the href to img above.

thanks for reporting! should be fixed now!


Experimental flag for allowing/disallowing assignment casts

The experimental analyzer --no-implicit-casts flag disallows all implicit casts.  We should have a --[no-]assignment-casts flag that affects only assignment casts (A x = e).  Specifying --assignment-casts should allow assignment casts, but no others.
cc @Hixie

Flutter would use this to see if we have any implicit casts we aren't expecting. (We currently use assignment implicit casts as a work-around for "as" introducing new checks in release builds; we plan to move those to "as" once the VM has strong mode.)

https://codereview.chromium.org/2976963002/


node-gyp issue when npm is updated.

Node Version: Node 8.11.3 and npm 6.1.0
Platform: Linux, Centos
Compiler: Linux, Centos
Module: nodejs project.

Upgraded npm version from 5.7.1 to  6.1.0 and started getting following issue when I ran
npm install
[r-7B4TXMWRMQ] Running shell script
+ **npm install**

><EMAIL_ADDRESS>install /home/build-user/workspace/r-7B4TXMWRMQ/node_modules/get-cursor-position
> node-gyp rebuild

make: Entering directory `/home/build-user/workspace/r-7B4TXMWRMQ/node_modules/get-cursor-position/build'
  CXX(target) Release/obj.target/pos/src/pos.o
make: g++: Command not found
make: *** [Release/obj.target/pos/src/pos.o] Error 127
make: Leaving directory `/home/build-user/workspace/r-7B4TXMWRMQ/node_modules/get-cursor-position/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at emitTwo (events.js:126:13)
gyp ERR! stack     at ChildProcess.emit (events.js:214:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System Linux 3.10.0-862.3.2.el7.x86_64
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/build-user/workspace/r-7B4TXMWRMQ/node_modules/get-cursor-position
gyp ERR! node -v v8.11.3
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>license should be a valid SPDX license expression
npm WARN The package botbuilder-timeout is included as both a dev and production dependency.
npm WARN The package express is included as both a dev and production dependency.
npm WARN The package auto-bot is included as both a dev and production dependency.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/build-user/.npm/_logs/2018-06-13T19_14_36_140Z-debug.log

make: g++: Command not found

That's not a node-gyp or npm issue and neither is it related to the upgrade, you simply don't have a C++ compiler installed.

I am not sure why I would need c++ computer. I am building nodejs project.

What do you think node-gyp is?  A tool for building C++ modules for Node.js.


RPC client generation doesn't work with dart >=1.14

When trying to build a library with dart >= 1.14 that imports a library in the same package with package: the builder fails. If the import is replaced with a local import it works.
I have built a small demo app that shows the problem: https://github.com/enyo/rpc-error
This currently makes it impossible to build an rpc client, without changing all imports to relative imports (which is discouraged).
The error when building with pub global run rpc:generate discovery -p 8082 -i lib/api.dart:
in ShutdownIsolate: Unhandled exception:
IsolateSpawnException: Unable to spawn isolate: Unhandled exception:
Could not import "package:test/foo.dart" from "file:///Volumes/CaseFS/xxx/lib/api.dart": Failure getting http://localhost:53394/packages/test/foo.dart:
  404 Not Found
#0      _asyncLoadErrorCallback (dart:_builtin:162)
#1      _asyncLoadError (dart:_builtin:573)
#2      _handleLoaderReply (dart:_builtin:390)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)
#0      Isolate.spawnUri.<spawnUri_async_body> (dart:isolate-patch/isolate_patch.dart)
#1      _asyncErrorWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:34)
#2      _RootZone.runBinary (dart:async/zone.dart:1142)
#3      _Future._propagateToListeners.handleError (dart:async/future_impl.dart:579)
#4      _Future._propagateToListeners (dart:async/future_impl.dart:641)
#5      _Future._completeError (dart:async/future_impl.dart:432)
#6      _SyncCompleter._completeError (dart:async/future_impl.dart:56)
#7      _Completer.completeError (dart:async/future_impl.dart:27)
#8      Isolate._spawnCommon.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:439)
#9      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)

Thanks for the reproduction.
The way package:rpc generates a json description of your API (in the form of a discovery document) is that it makes a small temporary helper dart script (which is launched via a Isolate.spawnUri) which imports your code (in this case lib/api.dart) and uses dart:mirrors to get all classes with an @ApiClass() annotation. From there finds all of your schema/data classes and methods and can generate an API description.
Since this helper script is importing your code (in order to find your APIs) it also needs to use the exact same version of package:rpc as your package is using. I therefore think you should replace pub global run with pub run (which will use the rpc version of your package).
=> Doing this in the reproduction repository you provided makes the issue go away for me.
I think there were some changes to Isolate.spawnUri regarding the packages directory / .packages file in 1.14 which might have caused this issue. So I'm not sure if your issue is completely resolved.
@sgjesse Maybe you know more about the Isolate.spawnUri changes that happened?

You're our hero! :heart_eyes:

Could the readme be updated with this (to use pub run instead of pub global run) as I struggled with this issue for a bit before I checked here and found this thread :)


Add aquasecurity/trivy

https://github.com/aquasecurity/trivy
Scanner for vulnerabilities in container images, file systems, and Git repositories, as well as for configuration issues

trivy has been added from v0.6.0. https://github.com/suzuki-shunsuke/aqua-registry/pull/120


 Need to make it cleaner at some stage

This one is closed, no?

Adding the ability for the user to configure the cleanup


Display quotes from vault

Instead of having to add quotes to Beautitab's settings, it'd be amazing if it could pull quotes from the vault somehow. I personally have lots of quotes that I've imported from Kindle Highlights, among others.
Of course, I don't think there's a standardized way to store quotes, so maybe something simple could be possible, like indexing all blockquotes from notes with a certain tag, or something.

Or at least pulling quotes from a particular note in the vault.
I second this REQUEST!!

I support the request to finalize this feature. I've long been looking for a tool that could remind me of random quotes not from somewhere on the internet, but my own that resonated with me personally.
I'll throw a few thoughts on it. Hopefully they will be helpful.
The tag or tag mask idea looks handy. Admittedly, I'm not entirely familiar with Obsidian's plugin development, and I can't say how complicated it is or whether it would require integration with dataview, for example.
Entering quotes manually is a non-functional feature. Storing all the quotes in one file is not. It is possible to pull from a directory, but then you need a specific format: callout quote/cite or standard quote, but again, everyone has their own methodology for keeping quotes.
Seems like a daunting task))
Translated with DeepL.com (free version)


Amend options encoding

Former version would leave leading zeroes which isn't correct Ethereum JSON RPC encoding.

Ah! Nice catch!
I'm planning on adding #7 and #14 to 0.1.6 release so this can be in there as well. I've finished #7 already, so I'll have to see about #14. And then I can get this patch right out.


Relative path errors

I have got the following error:
XLSX_C ERROR: "\xl\styles.xml" can't be parsed or doesn't exist.
XLSX_C ERROR: Index out of bounds.
I think it is because of these:
#define REL_PATH_TO_STYLES "\xl\styles.xml"
#define REL_PATH_TO_SHARED_STRINGS "\xl\sharedStrings.xml"
#define REL_PATH_TO_WORKBOOK "\xl\workbook.xml"
#define REL_PATH_TO_WORKSHEETS "\xl\worksheets\"
On linux, the paths use forward slashes '/'.
I have changed to the following and it seems to work:
+#define REL_PATH_TO_STYLES "/xl/styles.xml"
+#define REL_PATH_TO_SHARED_STRINGS "/xl/sharedStrings.xml"
+#define REL_PATH_TO_WORKBOOK "/xl/workbook.xml"
+#define REL_PATH_TO_WORKSHEETS "/xl/worksheets/"

Hello @tfarina , thanks for reporting this problem, and also for providing the fix. It's implemented on this commit. Also, a release with this commit included was done.


Make it possible to pipe utilities

At a shell prompt, it's really convenient to be able to pipe the output from one command into another. The current toolshed commands don't let you do this. Here's an example that would be nice to support:
iex> cat("/etc/services") |> grep(~r/ntp/)
... all lines with `ntp` in them...

The refactor branch has a start at implementing this.

Does this boil down to letting functions return an Elixir representation instead of printing the result and returning :"do not show this result in output"?

cat/1 can return a string
Some functions like dmesg/0 might be OK as is...

Maybe we want to think of specific scenarios where pipe-ability is handy like cat + grep. Is there anything else?

Ah wrapping the result in a standardized struct, nice!
I think pipe-ability will be a huge appeal to Elixir programmers. Also if you yourself want to do the piping all the time, that is a good reason to implement the feature since you are one of the Nerves heavy users.

I could inherit your work if you rebase it on the latest main. There seem to be some major merge conflicts.

I rebased the refactor branch into the pipes branch. It's definitely part complete. This looks like a decent amount of work since there are a lot of commands and some of them look like they need some thought to pipe nicely. I'm wondering if it might be easier to tackle a couple easier issues before this one. Perhaps we should strategize on this after you get a chance to look over the branch more.


add completion for quit command

Mostly serves as a reminder that the quit command exists :)

@matchai are there any issues with this PR?


Remove github-pages dependency from hip repo

Based on https://github.com/LFDT-Hiero/tsc/issues/4 we currently depend on github-pages, but the dependency is not used at all. Next to that the dependency brings in transtive dependencies that are GPL licensed. Based on that we need to remove the dependecy.

PR: https://github.com/hashgraph/hedera-improvement-proposal/pull/1057/files


Try to detect if pac is installed via operator

When installing via openshift-pipelines "downstream" operator. PAC would
get installed in openshift-pipelines.
Strategy to detection is then :
if user has a -n ns flag, try to see if pac is installed in ns
try to detect pac in openshift-pipelines ns (downstream)
try to detect pac in pipelines-as-code ns  (upstream)
The way to detect it is to check the configmap installed in the
openshift-pipelines namespace. This makes this detection compatible with
old way (via taskrun) and the new way via controller.
As far goes for for permissions usually the folks who tries to do
bootstrap will have to have anyway right access to that ns to be able to
bootstrap so we should be good.
Still no tests in that code flow, and still too annoying to add tests there 🤷🏻
Signed-off-by: Chmouel Boudjnah<EMAIL_ADDRESS>
Changes

Submitter Checklist

[X] ♽  Run make test lint before submitting a PR (ie: via pre-push github hook no need to waste CPU cycle on CI
[X] 📖 If you are adding a user facing feature or make a change of the behavior, please make sure to document it
[X] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[X] 🎁 If that's something that is possible to do please make sure to check if we can add a e2e test.
[X] 🔎 If there is a flakiness in the CI tests then make sure to get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it.

See the developer guide for a bit more details.

Codecov Report

Merging #482 (fa8b096) into main (7eb5161) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   67.50%   67.53%   +0.03%
==========================================
  Files          54       54
  Lines        2960     2963       +3
==========================================
+ Hits         1998     2001       +3
  Misses        771      771
  Partials      191      191

Impacted Files
Coverage Δ

pkg/resolve/resolve.go
88.17% <0.00%> (-0.72%)
:arrow_down:

pkg/templates/templating.go
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb5161...fa8b096. Read the comment docs.


Google.com, pub<PHONE_NUMBER>689588, direct, f08c47fec0942fa0

<EMAIL_ADDRESS>

https://github.com/InteractiveAdvertisingBureau/ads.txt-parser/pull/3#issue-1995206470

You will need to implement this in an ads.txt or app-ads.txt txt file on your own website.  This repository won't accept this type of change related to a personal website, nor will we create duplicate copies of the documentation.


pop-count: rename to eliuds-eggs

We are renaming the pop-count exercise to eliuds-eggs. See https://github.com/exercism/problem-specifications/pull/2382 for more information.

This PR renames pop-count to eliuds-eggs. We have attempted to rename everything that is automatable, but you may need to make specific changes in the files.
If you could prioritise finishing and merging this, we would be grateful, so we can get the exercise in the correct state across Exercism. Please let me know if you have any questions.
Thanks! 🙂

CI is failing, but I think I know the issue. I’ll try and fix today.


Is  gsconfig_url undefined when try statement fails

https://github.com/mitwelten/mitwelten-geo-backend/blob/9b0b8f5ff0a984254357b71bbe0ffc8271722150/ogr2pg2gs.py#L155
Hi,
I was wondering if the try gives an exception, then the program seems to continue the flow until line 155 when the gsconfig_url is accessed as it is only defined when no exception happens.

Yes, you have understood correctly. That is a bit of a logic error on my part. I should re-raise the exception after logging.


Graceful handling of queue panics + add df row bugfix

Tested withpanic! 😱 locally and we recover now 😌


Redo usage of bungee's async event intents (possibly fix #2)

It's not tested at all, but should work

Thanks!


fromCodePoint

Hi there,
Nice library! Just a quick suggestion: you may consider using fromCodePoint rather than fromCharCode so UTF-8 characters can be supported. :)

That's not necessary. Supplementary plane code points are already supported. What's not working for you?

When I set the default range to a high integer (e.g. 18943) it doesn't produce a character.
Seems obvious, since fromCharCode doesn't support the highest Unicode values.
Compare these:
document.write(String.fromCodePoint(194564));
document.write(String.fromCharCode(194564));


Code cleanup

I was trying to look at the API documentation to find out the format of this:
    elif myarg in [u'driveversiondate']:
      body[u'query'].setdefault(u'driveOptions', {})[u'versionDate'] = sys.argv[i+1]
      i += 2

https://developers.google.com/vault/reference/rest/v1/matters.exports
but I get page not found

I think there's an issue with removing restrictions on the api docs. I'll check. Details I have on versionDate are:
Search the versions of the Drive file as of the reference date. These timestamps are in GMT and rounded down to the given date.
A timestamp in RFC3339 UTC "Zulu" format, accurate to nanoseconds. Example: "2014-10-02T15:01:23.045123456Z".

fyi docs should be fully accessible now.

Jay,
Thanks. This lets me confirm that driveOptions.versionDate is a full
timestamp.
Ross
On Fri, Aug 3, 2018 at 11:48 AM Jay Lee<EMAIL_ADDRESS>wrote:

fyi docs should be fully accessible now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jay0lee/GAM/pull/773#issuecomment-410343631, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIU8L5dwNqdKJzcKDbD8ouoD2NY0c5Fvks5uNJsPgaJpZM4VuH3E
.

--
Ross Scroggs
<EMAIL_ADDRESS>


Added the search button beside the SearchBar and added validation

Fixes Issue
This closes #793

Changes proposed
Added the search button and add validate in the search-box
Screenshots

@rupali-codes Again the errors are coming
Can you tell me in which file the error is?

@Soumyajit2825

Also, please update the PR title to something meaningful :)

@rupali-codes Finally it works!!!!!
You can check the changes in the preview now

@CBID2 Have you checked my work ? 😀

Just saw it @rupali-codes! Looks great @Soumyajit2825

Just saw it @rupali-codes! Looks great @Soumyajit2825

Thanks 😄
I am happy to work with you in this project

@rupali-codes @CBID2 It looks good in web view and normal mobile view but I think for medium screen size and desktop view in mobile, there is a issue if i am not wrong !
Like the search button should be aligned right taking a specific max-width of total side-menu and in remaining space we should have the search bar.
But when I am trying to open this in medium size screens it looks like this :

So ideally, shouldn't the search bar and button be stretched to cover the side menu ? specially, the search button should be aligned on the right side like the other icons (roll-up/roll down, close icon)
what do you think about it ?

@rupali-codes @CBID2 It looks good in web view and normal mobile view but I think for medium screen size and desktop view in mobile, there is a issue if i am not wrong !
Like the search button should be aligned right taking a specific max-width of total side-menu and in remaining space we should have the search bar.
But when I am trying to open this in medium size screens it looks like this :

So ideally, shouldn't the search bar and button be stretched to cover the side menu ? specially, the search button should be aligned on the right side like the other icons (roll-up/roll down, close icon)
what do you think about it ?

That does make sense

@ujjawaltyagii @CBID2 @rupali-codes I don't think that it will look good if I aligned the search button in the right side
Now it's upto you
I will make changes according too you

@rupali-codes @CBID2 It looks good in web view and normal mobile view but I think for medium screen size and desktop view in mobile, there is a issue if i am not wrong !
Like the search button should be aligned right taking a specific max-width of total side-menu and in remaining space we should have the search bar.
But when I am trying to open this in medium size screens it looks like this :

So ideally, shouldn't the search bar and button be stretched to cover the side menu ? specially, the search button should be aligned on the right side like the other icons (roll-up/roll down, close icon)
what do you think about it ?

That does make sense

Hey @ujjawaltyagii! :) I just checked out the button on both screens and I changed my mind. Having it stretched out would look unattractive, so I agree with @Soumyajit2825's current design.

😀

okay !! then it looks good to me 👍

@rupali-codes waiting for your review now!

okay !! then it looks good to me 👍

@rupali-codes waiting for your review now!

I guess it's still better the way it is, as of now we are making the search when user starts typing, after adding the button they would have to click on button to perform the search which may not be good for user experience

okay !! then it looks good to me 👍

@rupali-codes waiting for your review now!

I guess it's still better the way it is, as of now we are making the search when user starts typing, after adding the button they would have to click on button to perform the search which may not be good for user experience

As of user experience there is button for searching in most of the cases.
😞 OK then invalid contribution it is
I said to you previously then all said that it's looking great 😀

@rupali-codes This is also good
But this is also a button right !!
You just change the design of the button to a logo and added placeholder text ❓

@Soumyajit2825 @CBID2 @ujjawaltyagii how's lookin' now?

It's looking great !! 💯

@Soumyajit2825 @CBID2 @ujjawaltyagii how's lookin' now?

It's looking great @rupali-codes !! 💯

@rupali-codes @CBID2 @ujjawaltyagii So what I have to now?
Remake the button as you have made?

LGTM! :)

We were about to make some changes Chrissy, the button color also doesn't match with our theme 🙂

I tried this @rupali-codes @CBID2
Thanks for merging 😄

LGTM! :)

We were about to make some changes Chrissy, the button color also doesn't match with our theme 🙂

Oops

LGTM! :)

We were about to make some changes Chrissy, the button color also doesn't match with our theme 🙂

I tried to revert the changes but couldn't @rupali-codes.

LGTM! :)

We were about to make some changes Chrissy, the button color also doesn't match with our theme 🙂

I tried to revert the changes but couldn't @rupali-codes.

@CBID2 @rupali-codes I have done the changes
Should I create a new issue on this?
If yes the please let me know I have already done the changes

LGTM! :)

We were about to make some changes Chrissy, the button color also doesn't match with our theme 🙂

I tried to revert the changes but couldn't @rupali-codes.

@CBID2 @rupali-codes I have done the changes
Should I create a new issue on this?
If yes the please let me know I have already done the changes

That would help

Ok @CBID2 I'm creating new issue
Please assign me

Ok @CBID2 I'm creating new issue
Please assign me

Make sure you reference this one in your new issue. It's for context

@CBID2 I have created the issue describing what the prblm is!
Should I have to edit anything?

@CBID2 I have created the issue describing what the prblm is!
Should I have to edit anything?

In the issue report?

@CBID2 I have created the issue describing what the prblm is!
Should I have to edit anything?

In the issue report?

Yes

@CBID2 I have created the issue describing what the prblm is!
Should I have to edit anything?

In the issue report?

Yes

Adding Rupali's comment to the issue would suffice @Soumyajit2825.

@CBID2 PR done please check the changes

LGTM! :)

We were about to make some changes Chrissy, the button color also doesn't match with our theme 🙂

Hey @rupali-codes. @Soumyajit2825 created a new issue for the button. Check it out here


Can't fill in model with pdf-lib

Hello!
i am having an issue when I try to fill a pdf form from model that contains some text fields, but i can't see my changes in the pdf, can you help me ? i see issues with same problem but i have not find a solution .
thanks @Hopding

Hi @cherifa-ghersi  I'm new to this library and am finding on my Mac that my changes to a form with text fields can be seen when viewing the resultant PDF in Chrome or Acrobat but not in Safari or Preview (I'm on Catalina 10.15.4).  What OS are you using?
Also, when I looked through all the various issues related to this problem, there was one solution that I found consistently that was required in order to make this work in the PDF viewers I mentioned above:
acroForm.set(PDFName.of('NeedAppearances'), PDFBool.True);

@cherifa-ghersi I've created a similar issue here: https://github.com/Hopding/pdf-lib/issues/401  In that PR you'll see a link to the GH repo where I've had at least partial success.  Maybe that would be a good starting point for you.

I was able to close my GH issue here due to a one-liner change.  Now I'm able to fill PDF text fields and have it render properly in all PDF viewers (the ones I've checked on my Mac, that is).  Sample code is here: https://github.com/BigGillyStyle/pdf-form-fill-app

Hello @cherifa-ghersi!
The solution suggested by @BigGillyStyle is a good one that I'd recommend you try. However, if that solution doesn't suit your needs, there's another approach you can take that I've explained in https://github.com/Hopding/pdf-lib/issues/205#issuecomment-568938999.
I hope this helps! If you're still unable to get things working then please share some sample code and a document that I can use to reproduce your issue.


usage/layout doesn't carry meaning

http://semantic-ui.com/usage/layout.html
this page should have links to download source code, and the frontpage example must have some kind of accompanying js with it which is isn't in examples folder of repository

also music player won't work (sound cloud pop up player)

I shit you not, there're 3 menus in there (the front page usage).

Closing, tone.


create new repo for chef-icinga*

@dnsmichi As per #293 , we have decided to move web and classic ui resources to a separate cookbook.
Please create another git repo chef-icinga2ui.
This new cookbook will depend on icinga2 cookbook for common attributes/resources/etc.
@vills

Currently working on #293

@dnsmichi We need to create GitHub repositories listed below.

chef-icinga2repo - cookbook for icinga2 package yum/apt repository
chef-icinga2classicui - cookbook for icinga2 classic ui setup
chef-icingaweb2 - cookbook for icingaweb2 setup
chef-icinga2 - core icinga2 server setup
chef-icinga2client - icinga2 client setup

@vills ^^

Perfect! :-)

See my comment in #293 - I agree on everything except for classicui.

https://github.com/Icinga/chef-icinga2repo
https://github.com/Icinga/chef-icingaweb2
https://github.com/Icinga/chef-icinga2client
Same permissions as here, please try it out @vkhatri

Btw - @bobapple should be your first contact with infrastructure requirements. I did not read your initial issue, sorry about that.

@vkhatri is chef-icinga2repo cookbook should do something except adding repositories?

@vills Yes. chef-icinga2repo is the icinga2 yum/apt repository shared among the cookbooks.
@dnsmichi Thank you for creating the repositories.

@vills It does not do anything else other than repository management.


Using ApplicationInstance.registry.register is deprecated since Ember 2.1

I'm getting a depecration warning on latest Ember on these lines
registry.register('adapter:-active-model', _activeModelAdapter['default']);
registry.register('serializer:-active-model', _activeModelAdapterActiveModelSerializer['default']);

http://emberjs.com/deprecations/v2.x/#toc_ember-application-registry-ember-applicationinstance-registry

instance initializer is only removed in 2.0.3. What version are you using?

Same here on E/ED 2.2.x.

same here

For people +1'ing can you please tell us what version of ActiveModelAdapter and Ember Data you are using?

I used Ember 2.1, ember-data 2.1 and ActiveModelAdapter 2.0.1. Same on Ember 2.2 and ember-data 2.2.

"active-model-adapter": "2.0.1"
and E/ED: 2.2

Can you try ActiveModelAdapter 2.0.3?

Jip, that worked for me! Thx


Update JetStream grpc proto to support I/O with text and token ids

Update gprc proto to support

Request: token id or text (one of).
Response: token id, text or both of them.
When input token id, return only token ids. (client tokenization (MLPerf) mode)
When input text, return both text and token ids.

Refactored detokenization handling and Tokenizer API to decouple the logics.
Added complete support for SentencePiece tokenizer streaming decoding (ensured output text correctness).
Added and update unit tests for token utils, orchestrator, and server.
Benchmark script client-side tokenization is enabled.

Any reason to add text back, I suggested we keep both str and id in response in #40. The answer is " don't want to decode it to str (or piece) in jetstream". Would you like to share the reasons to do make the total different decision in just two weeks?
Below are comment from PR 40:

@FanhaiLu1 FanhaiLu1 [2 weeks ago]
Can we still keep a str as option? The internal keep both text and token id.
@[JoeZijunZhou] [2 weeks ago]
I guess we don't want to decode it to str (or piece) in jetstream, since it would have some off in the final result.

Mainly for our customer's request, they would like to have server-side detokenization support. This PR will include the complete support. " don't want to decode it to str (or piece) in jetstream" is due to the incorrect streaming detokenization previously.

Any reason to add text back, I suggested we keep both str and id in response in #40. The answer is " don't want to decode it to str (or piece) in jetstream". Would you like to share the reasons to do make the total different decision in just two weeks?
Below are comment from PR 40:

@FanhaiLu1 FanhaiLu1 [2 weeks ago]
Can we still keep a str as option? The internal keep both text and token id.
@[JoeZijunZhou] [2 weeks ago]
I guess we don't want to decode it to str (or piece) in jetstream, since it would have some off in the final result.

Mainly for our customer's request, they would like to have server-side detokenization support. This PR will include the complete support. " don't want to decode it to str (or piece) in jetstream" is due to the incorrect streaming detokenization previously.

Thanks, can you create a issues and add the customer's request details? It will be good context for readers.

Addressing #79 .

Any reason to add text back, I suggested we keep both str and id in response in #40. The answer is " don't want to decode it to str (or piece) in jetstream". Would you like to share the reasons to do make the total different decision in just two weeks?
Below are comment from PR 40:

@FanhaiLu1 FanhaiLu1 [2 weeks ago]
Can we still keep a str as option? The internal keep both text and token id.
@[JoeZijunZhou] [2 weeks ago]
I guess we don't want to decode it to str (or piece) in jetstream, since it would have some off in the final result.

Mainly for our customer's request, they would like to have server-side detokenization support. This PR will include the complete support. " don't want to decode it to str (or piece) in jetstream" is due to the incorrect streaming detokenization previously.

Soon, there could be another customer ask both token id an text support? I feel we should predict what are the customer's requirements and do it in once. Support token id, text and both is one solution for all the customers.

Any reason to add text back, I suggested we keep both str and id in response in #40. The answer is " don't want to decode it to str (or piece) in jetstream". Would you like to share the reasons to do make the total different decision in just two weeks?
Below are comment from PR 40:

@FanhaiLu1 FanhaiLu1 [2 weeks ago]
Can we still keep a str as option? The internal keep both text and token id.
@[JoeZijunZhou] [2 weeks ago]
I guess we don't want to decode it to str (or piece) in jetstream, since it would have some off in the final result.

Mainly for our customer's request, they would like to have server-side detokenization support. This PR will include the complete support. " don't want to decode it to str (or piece) in jetstream" is due to the incorrect streaming detokenization previously.

Soon, there could be another customer ask both token id an text support? I feel we should predict what are the customer's requirements and do it in once. Support token id, text and both is one solution for all the customers.

This already supports token id, text and both as response. User will not input both text and tokens at the same in 1 request right? Why will user input both text and tokens to request JetStream API?
I was thinking simplified it to 2 mode:

For MLPerf, return token ids only
Other cases, always return text + token ids + score (to be added to Sample)

Any reason to add text back, I suggested we keep both str and id in response in #40. The answer is " don't want to decode it to str (or piece) in jetstream". Would you like to share the reasons to do make the total different decision in just two weeks?
Below are comment from PR 40:

@FanhaiLu1 FanhaiLu1 [2 weeks ago]
Can we still keep a str as option? The internal keep both text and token id.
@[JoeZijunZhou] [2 weeks ago]
I guess we don't want to decode it to str (or piece) in jetstream, since it would have some off in the final result.

Mainly for our customer's request, they would like to have server-side detokenization support. This PR will include the complete support. " don't want to decode it to str (or piece) in jetstream" is due to the incorrect streaming detokenization previously.

Soon, there could be another customer ask both token id an text support? I feel we should predict what are the customer's requirements and do it in once. Support token id, text and both is one solution for all the customers.

This already supports token id, text and both as response. User will not input both text and tokens at the same time in 1 request right? Why will user input both text and tokens to request JetStream API?
I was thinking simplified it to 2 mode:

For MLPerf, return token ids only
Other cases, always return text + token ids + score (to be added to Sample)

Looks good to me for these setting:
Request: token id or text (one of)
Response: token id, text or both of them.

When input text, return both text and token ids.

Is it still a streaming mode?

When input text, return both text and token ids.

Is it still a streaming mode?

Yes, each streaming content contains a token_id and its text piece with greedy decode strategy.


[ENH] Add _ConditionalRefitForecaster and refactor UpdateRefitsEvery to subclass it

Reference Issues/PRs
Initial steps of #652.
What does this implement/fix? Explain your changes.
This adds a _ConditionalRefitForecaster as mentioned here, to be used in implementations of different refitting forecasters.
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
The API design - is this okay and can it be exposed to the public?
PR checklist
For all contributions

[ ] I've added myself to the list of contributors.
[ ] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[ ] I've added unit tests and made sure they pass locally.
[ ] The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Nice! May I suggest:

make the ConditionalRefitForecaster a separate estimator
don't start with an underscore, or tests framework will not detect it
leave UpdateRefitsEvery unchanged per functionality, as we have already released it. Fine if you refactor it (subclass or common superclass) but please ensure that the functionality does not change, at least for the next deprecation cycle.

Thanks for the quick response! To make sure I understand:

make the ConditionalRefitForecaster a separate estimator
Do you mean putting it in a separate file?

don't start concrete estimators with an underscore, or tests framework will not detect it. Joint superclasses can be private, of course.
So we are making ConditionalRefitForecaster public, and users would subclass it? (see this comment as well)

leave UpdateRefitsEvery unchanged per functionality, as we have already released it. Fine if you refactor it (subclass or common superclass) but please ensure that the functionality does not change, at least for the next deprecation cycle.
I'd love to add some tests for it to make sure the functionality doesn't change. Maybe I can file a ticket for adding tests and refactoring?

Do you mean putting it in a separate file?

No, just a separate class.

So we are making ConditionalRefitForecaster public, and users would subclass it? (see this comment as well)

answering there

I'd love to add some tests for it to make sure the functionality doesn't change. Maybe I can file a ticket for adding tests and refactoring?

good idea. Please note that generic tests already cover the forecaster, so the only things that need to be tested are whether the functionality is correct.

Thanks @fkiraly! I've updated the PR to remove the refactoring and added a public class ConditionalRefitForecaster, which just takes in a bunch of functions and pass them into _ConditionalRefitForecaster. Hope this makes some sense and further discussions are most welcome!
@fkiraly - you mention although there may be a case for or against having a joint parent class in the comments in #652 - can you elaborate a bit? There are currently both the parent class and the public class in the PR, but I'll be happy to remove one of the classes if it proves to be not of much use.

@fkiraly - you mention although there may be a case for or against having a joint parent class in the comments in https://github.com/alan-turing-institute/sktime/issues/652 - can you elaborate a bit? There are currently both the parent class and the public class in the PR, but I'll be happy to remove one of the classes if it proves to be not of much use.

I thought the parent could be a parent of UpdateRefitsEvery as well, or be disconnected of it. Not sure what is better.

I'll change this to ready for review - I'll add tests for this but want to make sure it looks reasonable at least.

Hm, overall looks nice!
I think though the logic of the condition and data retrieval can be simplified, could be wrapped in less functions.
Is it not possible to achieve the same effect by a single function that checks the condition, for the simplest version?
And perhaps second function for the data memory or subsetting.
Could you explain what the _set_refit_condition and _update_refit_condition are meant to do?


Dask crashes with certain masked arrays

Hello!
I think I found an issue, but I'm not completely sure who's to blame: dask or numpy.
Here it is:
I'm trying to submit a simple computation using "dask.distributed" (local):
future = client.submit(f, a)

and it crashes:
Traceback (most recent call last):
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/numpy/ma/core.py", line 3150, in view
    if issubclass(dtype, ndarray):
TypeError: issubclass() arg 1 must be a class

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/dask/base.py", line 878, in normalize_array
    data = hash_buffer_hex(x.ravel(order="K").view("i1"))
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/numpy/ma/core.py", line 3156, in view
    output = ndarray.view(self, dtype)
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/numpy/ma/core.py", line 3375, in dtype
    self._mask.shape = self.shape
ValueError: cannot reshape array of size 1 into shape (8,)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/numpy/ma/core.py", line 3150, in view
    if issubclass(dtype, ndarray):
TypeError: issubclass() arg 1 must be a class

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/distributed/client.py", line 1487, in submit
    key = funcname(func) + "-" + tokenize(func, kwargs, *args)
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/dask/base.py", line 658, in tokenize
    return md5(str(tuple(map(normalize_token, args))).encode()).hexdigest()
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/dask/utils.py", line 506, in __call__
    return meth(arg, *args, **kwargs)
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/dask/base.py", line 880, in normalize_array
    data = hash_buffer_hex(x.copy().ravel(order="K").view("i1"))
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/numpy/ma/core.py", line 3156, in view
    output = ndarray.view(self, dtype)
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/numpy/ma/core.py", line 3375, in dtype
    self._mask.shape = self.shape
ValueError: cannot reshape array of size 1 into shape (8,)

I managed to reproduce it with minimum effort - it seems that this happens only when "a" is a masked array. But not just any masked array.
This masked array works fine:
import numpy.ma as ma
a = ma.zeros(1)
a

# masked_array(data=[0.],
#              mask=False,
#        fill_value=1e+20)

but as soon as I "update" its mask:
a.mask = False
a

# masked_array(data=[0.0],
#              mask=[False],
#        fill_value=1e+20)

... it makes Dask client.submit misbehave, as shown above.
I tracked the issue down to numpy's core (which Dask ends up calling):
a = ma.zeros(1)
a.view('i1')

# masked_array(data=[0, 0, 0, 0, 0, 0, 0, 0],
             mask=False,
       fill_value=999999,
            dtype=int8)

a = ma.zeros(1)
a.mask = False      # converts the mask from False to [False]
a.view('i1')

Traceback (most recent call last):
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/numpy/ma/core.py", line 3150, in view
    if issubclass(dtype, ndarray):
TypeError: issubclass() arg 1 must be a class

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/numpy/ma/core.py", line 3156, in view
    output = ndarray.view(self, dtype)
  File "/home/cordawyn/projects/p1/venv/lib/python3.7/site-packages/numpy/ma/core.py", line 3375, in dtype
    self._mask.shape = self.shape
ValueError: cannot reshape array of size 1 into shape (8,)

So it raises ValueError, as "documented" in the comments in core.py. But Dask does not catch ValueError in https://github.com/dask/dask/blob/666b53affac3ba475bd94c7ff4d29752bfa133de/dask/base.py#L880 (although it does it a bit earlier).
If numpy's exception is "valid", then we have a Dask bug. If not, it's probably numpy's. Numpy works a bit confusing in this particular case, so I'm not sure if it's really intended.
Testing environment:
Python: 3.7.3
Dask: 2.15.0 (also tested with 2.12.0)
Numpy: 1.18.3 (also tested with 1.18.1)

Thanks for raising an issue and providing some code snippets @cordawyn! As you pointed out, I'm able to reproduce ValueError: cannot reshape array of size 1 into shape (8,) with NumPy alone:
In [1]: import numpy.ma as ma

In [2]: a = ma.zeros(1)
   ...: a.mask = False
   ...: a.view('i1')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
~/miniforge3/envs/dask-dev/lib/python3.8/site-packages/numpy/ma/core.py in view(self, dtype, type, fill_value)
   3132             try:
-> 3133                 if issubclass(dtype, ndarray):
   3134                     output = ndarray.view(self, dtype)

TypeError: issubclass() arg 1 must be a class

During handling of the above exception, another exception occurred:

ValueError                                Traceback (most recent call last)
<ipython-input-2-62201ee087d5> in <module>
      1 a = ma.zeros(1)
      2 a.mask = False
----> 3 a.view('i1')

~/miniforge3/envs/dask-dev/lib/python3.8/site-packages/numpy/ma/core.py in view(self, dtype, type, fill_value)
   3137                     output = ndarray.view(self, dtype)
   3138             except TypeError:
-> 3139                 output = ndarray.view(self, dtype)
   3140         else:
   3141             output = ndarray.view(self, dtype, type)

~/miniforge3/envs/dask-dev/lib/python3.8/site-packages/numpy/ma/core.py in dtype(self, dtype)
   3357             # This raises a ValueError if the dtype change won't work.
   3358             try:
-> 3359                 self._mask.shape = self.shape
   3360             except (AttributeError, TypeError):
   3361                 pass

ValueError: cannot reshape array of size 1 into shape (8,)

If you're submitting the above code to Dask to execute I would also expect an error to be raised, though I may be missing something something about your use case. What is the function f?

Thanks for checking it out!
It doesn't matter what is behind this f function, because it doesn't even get to handling it. But if you really have to use anything, you can use:
def f(x):
  return x

I hope this helps.

I am able to reproduce raising the numpy error with:
from dask.distributed import Client
client = Client()

import numpy.ma as ma
a = ma.zeros(1)
a.mask = False

def f(x):
    return x

future = client.submit(f, a)

So I think this is a pure numpy bug and dask is behaving correctly.


Support 0.12/io.js

Hi! I refactored this module to use nan so that it's supported by Node 0.12, and io.js. This will make keeping up compatibility easier in the future as well, since nan will keep support on all versions.
Fixes GH-15.

hey! would you mind publishing a new version to npm?


⚠ Spryr has degraded performance

In eb63cf4, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5959 ms

Resolved: Spryr performance has improved in bf2a2c5 after 7 minutes.


fix spelling of "targetting"

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Multi-edit command properties

Edit common properties and drag and drop multiple commands.
Requested on forum

I think the link is wrong. @chrisgregan do you still have an original link?
I understand what "multi-edit" means, I just need to clarify what is "drag and drop multiple commands" in this case. Drag-n-drop for copying? Or drag-n-drop for in-command properties?


fixed download drop-down

Fixes:#345 Download drop-down in the "Editor" section not working properly
Before:

after:

Awesome!
In the next PR, try changing the color of the control options bar. Make it different from the nav bar color

Awesome!
In the next PR, try changing the color of the control options bar. Make it different from the nav bar color

This effect on hove is an overkill. We need neither the change of background nor the underline effect

This effect on hove is an overkill. We need neither the change of background nor the underline effect

Raise separate issues for each and fix them one followed by the other

Raise separate issues for each and fix them one followed by the other

Raise separate issues for each and fix them one followed by the other

ok sir

Raise separate issues for each and fix them one followed by the other

ok sir

This effect on hove is an overkill. We need neither the change of background nor the underline effect

@smaranjitghose sir do I need to remove this hove effect from the home page nav also

This effect on hove is an overkill. We need neither the change of background nor the underline effect

@smaranjitghose sir do I need to remove this hove effect from the home page nav also

Raise separate issues for each and fix them one followed by the other

@smaranjitghose sir can I directly raise PR for that after committing changes.

Raise separate issues for each and fix them one followed by the other

@smaranjitghose sir can I directly raise PR for that after committing changes.

This effect on hove is an overkill. We need neither the change of background nor the underline effect

@smaranjitghose sir do I need to remove this hove effect from the home page nav also

Ya that would be nice too

This effect on hove is an overkill. We need neither the change of background nor the underline effect

@smaranjitghose sir do I need to remove this hove effect from the home page nav also

Ya that would be nice too


Update SDK to beta.10

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/135/ : SUCCESS in 1m 10s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-oss-check/111/ : SUCCESS in 3s

LGTM

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-merge-compliance-check/49/ : SUCCESS in 12s
https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/136/ : SUCCESS in 51s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-fossa-scanning-zuul-el7/14/ : FAILURE in 4m 45s (non-voting)


Garena support

Garena LoL installations does not include lol.launcher.exe. Because of that, I've added a check for League of Legends.exe in addition to lol.launcher.exe so Garena installation can be detected.

Was actually about to start working on this myself! Thanks for that. :)
I'm just verifying something with how Garena works before accepting. I'm trying to make it as easy as right click on the League shortcut, hit open file location, paste, and run for users without default install directories. What you wrote looked a little different than a screenshot I received of a Garena installation. Though if the screenshot was wrong, I'll accept your request ASAP. :)

Ah I see what you did, you put it next to the actual EXE instead of the Garena Launcher EXE. Still good! I'm going to accept this and add the one next to the Garena launcher myself. Thakns buddy!

Thanks for accepting my PR.
For easier approach to users, you can detect game installation directory from C:\ProgramData\GarenaMessenger\app.ini. Read the file and get value from [game] section.
Each region has its own key. So you might want to ask the user about which one they want to use.

That's a good idea!
I'm currently building the GUI, I don't think it'll take me too long as it's going to be dead simple with little design. I'll get around to adding it in there. :)


Build of 1.13 //tensorflow/python/eager:pywrap_tfe_lib fails with internal compiler error: unexpected expression ‘I’ of kind template_parm_index

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Fedora 28
cuda-cusparse-10.0.130-1.fc28.x86_64
cuda-cufft-devel-10.0.130-1.fc28.x86_64
cuda-nvjpeg-devel-10.0.130-1.fc28.x86_64
cuda-cublas-10.0.130-1.fc28.x86_64
cuda-nvrtc-devel-10.0.130-1.fc28.x86_64
cuda-gcc-c++-7.3.1-2.fc28.x86_64
nvidia-driver-cuda-libs-415.27-1.fc28.x86_64
cuda-cublas-devel-10.0.130-1.fc28.x86_64
cuda-extra-libs-10.0.130-1.fc28.x86_64
cuda-nvtx-10.0.130-1.fc28.x86_64
cuda-cusparse-devel-10.0.130-1.fc28.x86_64
cuda-cupti-10.0.130-1.fc28.x86_64
cuda-gcc-7.3.1-2.fc28.x86_64
cuda-cudart-devel-10.0.130-1.fc28.x86_64
cuda-nvjpeg-10.0.130-1.fc28.x86_64
cuda-curand-10.0.130-1.fc28.x86_64
cuda-npp-devel-10.0.130-1.fc28.x86_64
cuda-cudnn-devel-<IP_ADDRESS>-1.fc28.x86_64
bazel-0.21.0-1.fc28.x86_64
cuda-nvgraph-devel-10.0.130-1.fc28.x86_64
cuda-nvgraph-10.0.130-1.fc28.x86_64
cuda-cusolver-devel-10.0.130-1.fc28.x86_64
cuda-npp-10.0.130-1.fc28.x86_64
cuda-cudart-10.0.130-1.fc28.x86_64
cuda-nvml-devel-10.0.130-1.fc28.x86_64
nvidia-driver-cuda-415.27-1.fc28.x86_64
cuda-cusolver-10.0.130-1.fc28.x86_64
cuda-cupti-devel-10.0.130-1.fc28.x86_64
cuda-devel-10.0.130-1.fc28.x86_64
cuda-libs-10.0.130-1.fc28.x86_64
cuda-nvtx-devel-10.0.130-1.fc28.x86_64
cuda-10.0.130-1.fc28.x86_64
cuda-curand-devel-10.0.130-1.fc28.x86_64
cuda-nvrtc-10.0.130-1.fc28.x86_64
cuda-cufft-10.0.130-1.fc28.x86_64
cuda-cudnn-<IP_ADDRESS>-1.fc28.x86_64

TensorFlow version (use command below): 1.13

Python version: 3.6

Bazel version (if compiling from source): bazel-0.21.0-1.fc28.x86_64

GCC/Compiler version (if compiling from source): cuda-gcc-7.3.1-2.fc28.x86_64

CUDA/cuDNN version: cuda-cudnn-<IP_ADDRESS>-1.fc28.x86_64

GPU model and memory: NVIDIA Corporation GP102 [GeForce GTX 1080 Ti] 11GB RAM

Exact command to reproduce:

./configure

WARNING: Running Bazel server needs to be killed, because the startup options are different.
WARNING: --batch mode is deprecated. Please instead explicitly shut down your Bazel server using the command "bazel shutdown".
INFO: Invocation ID: fdbe3c4d-e72c-4726-a665-e2bc04669f74
You have bazel 0.21.0- (@non-git) installed.
Please specify the location of python. [Default is /usr/bin/python]: /usr/bin/python3
Found possible Python library paths:
/usr/local/lib/python3.6/site-packages
/usr/lib64/python3.6/site-packages
/usr/lib/python3.6/site-packages
Please input the desired Python library path to use.  Default is [/usr/local/lib/python3.6/site-packages]
Do you wish to build TensorFlow with XLA JIT support? [Y/n]: n
No XLA JIT support will be enabled for TensorFlow.
Do you wish to build TensorFlow with OpenCL SYCL support? [y/N]:
No OpenCL SYCL support will be enabled for TensorFlow.
Do you wish to build TensorFlow with ROCm support? [y/N]:
No ROCm support will be enabled for TensorFlow.
Do you wish to build TensorFlow with CUDA support? [y/N]: y
CUDA support will be enabled for TensorFlow.
Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 10.0]:
Please specify the location where CUDA 10.0 toolkit is installed. Refer to README.md for more details. [Default is /usr/local/cuda]: /usr
Please specify the cuDNN version you want to use. [Leave empty to default to cuDNN 7]:
Please specify the location where cuDNN 7 library is installed. Refer to README.md for more details. [Default is /usr]:
Do you wish to build TensorFlow with TensorRT support? [y/N]:
No TensorRT support will be enabled for TensorFlow.
Please specify the locally installed NCCL version you want to use. [Default is to use https://github.com/nvidia/nccl]:
Please specify a list of comma-separated Cuda compute capabilities you want to build with.
You can find the compute capability of your device at: https://developer.nvidia.com/cuda-gpus.
Please note that each additional compute capability significantly increases your build time and binary size. [Default is: 3.5,7.0]: 6.1
Do you want to use clang as CUDA compiler? [y/N]:
nvcc will be used as CUDA compiler.
Please specify which gcc should be used by nvcc as the host compiler. [Default is /usr/bin/gcc]: /usr/bin/cuda-gcc
Do you wish to build TensorFlow with MPI support? [y/N]:
No MPI support will be enabled for TensorFlow.
Please specify optimization flags to use during compilation when bazel option "--config=opt" is specified [Default is -march=native -Wno-sign-compare]:
Would you like to interactively configure ./WORKSPACE for Android builds? [y/N]:
Not configuring the WORKSPACE for Android builds.
Preconfigured Bazel build configs. You can use any of the below by adding "--config=<>" to your build command. See .bazelrc for more details.
--config=mkl            # Build with MKL support.
--config=monolithic     # Config for mostly static monolithic build.
--config=gdr            # Build with GDR support.
--config=verbs          # Build with libverbs support.
--config=ngraph         # Build with Intel nGraph support.
--config=dynamic_kernels        # (Experimental) Build kernels into separate shared objects.
Preconfigured Bazel build configs to DISABLE default on features:
--config=noaws          # Disable AWS S3 filesystem support.
--config=nogcp          # Disable GCP support.
--config=nohdfs         # Disable HDFS support.
--config=noignite       # Disable Apacha Ignite support.
--config=nokafka        # Disable Apache Kafka support.
--config=nonccl         # Disable NVIDIA NCCL support.
Configuration finished

bazel build --local_resources 2048,6,1.0 --config=opt --config=cuda //tensorflow/tools/pip_package:build_pip_package

...
...
ERROR: /home/spryor/git/tensorflow/tensorflow/python/eager/BUILD:10:1: C++ compilation of rule '//tensorflow/python/eager:pywrap_tfe_lib' failed (Exit 1)
tensorflow/python/eager/pywrap_tfe_src.cc: In function ‘void TFE_Py_Execute(TFE_Context*, const char*, const char*, TFE_InputTensorHandles*, PyObject*, TFE_OutputTensorHandles*, TF_Status*)’:
tensorflow/python/eager/pywrap_tfe_src.cc:685:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int i = 0; i < inputs->size() && TF_GetCode(out_status) == TF_OK;
^~~~~~~~~~~~~~
In file included from tensorflow/python/eager/pywrap_tfe_src.cc:23:0:
external/com_google_absl/absl/types/variant.h: In substitution of ‘template<long unsigned int I, class T> using variant_alternative_t = typename absl::variant_alternative::type [with long unsigned int I = I; T = absl::variant<tensorflow::TensorShape, _object*>]’:
external/com_google_absl/absl/types/variant.h:581:7:   required by substitution of ‘template<class T, long unsigned int I, class Tj, typename std::enable_if<(std::is_assignable<Tj&, T>::value && std::is_constructible<Tj, T>::value), void>::type*  > absl::variant<tensorflow::TensorShape, _object*>& absl::variant<tensorflow::TensorShape, _object*>::operator=<T, I, Tj,  >(T&&) [with T = const absl::variant<tensorflow::TensorShape, _object*>&; long unsigned int I = ; Tj = ; typename std::enable_if<(std::is_assignable<Tj&, T>::value && std::is_constructible<Tj, T>::value), void>::type*  = ]’
tensorflow/python/eager/pywrap_tfe_src.cc:914:20:   required from here
external/com_google_absl/absl/types/variant.h:581:7: internal compiler error: unexpected expression ‘I’ of kind template_parm_index
class Tj = absl::variant_alternative_t<I, variant>,
^~~~~
Please submit a full bug report,
with preprocessed source if appropriate.
See https://gcc.gnu.org/bugs/ for instructions.
Target //tensorflow/tools/pip_package:build_pip_package failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 600.890s, Critical Path: 104.25s
INFO: 3259 processes: 3259 local.
FAILED: Build did NOT complete successfully
Describe the problem
Attempting to build r1.13 on Fedora 28 with the given packages/etc results in a build error
tensorflow_build.log

The one I ran into is more around this one:
http://eigen.tuxfamily.org/bz/show_bug.cgi?id=1647
This is I think fixed with  patch releases to GCC.
Not sure about the compiler error reported on this issue.

I'm having the same issue when trying to compile Tensorflow 1.13.1, I'm using bazel 0.21.0 on amazon linux.
I've tried with gcc versions 7.3.0, 7.3.1, 7.4.0, 8.3.0 and got the same error on all of them. Do anyone have a solution for this?

Managed to build it for skylake(-march=skylake-avx512) , using:
bazel: 0.19.2
protobuf: 3.5.2
python: 3.7
gcc: 8.2.0

I'm getting the same compiler error, using:

Fedora 29 and the NVidia Drivers + Cuda 10.0 libraries from Negativo 17
bazel: 0.19.2
protobuf: 3.5.0
python: 3.7.3
gcc: 7.3.1
cuda: 10.0
cudnn: 7.4.2
nccl: 2.4.2

I've attempted to match my versions as closely as possible to the tested build configurations but still bombing out with similar output:
ERROR: /path truncated for privacy/tensorflow-r1.13/tensorflow/compiler/xla/service/BUILD:3025:1: C++ compilation of rule '//tensorflow/compiler/xla/service:maybe_owning_device_memory' failed (Exit 1)
In file included from ./tensorflow/compiler/xla/service/maybe_owning_device_memory.h:20:0,
                 from tensorflow/compiler/xla/service/maybe_owning_device_memory.cc:16:
external/com_google_absl/absl/types/variant.h: In substitution of 'template<long unsigned int I, class T> using variant_alternative_t = typename absl::variant_alternative::type [with long unsigned int I = I; T = absl::variant<xla::OwningDeviceMemory, stream_executor::DeviceMemoryBase>]':
external/com_google_absl/absl/types/variant.h:501:7:   required by substitution of 'template<class T, long unsigned int I, class Tj, absl::enable_if_t<std::is_constructible<Tj, T>::value, void>* <anonymous> > constexpr absl::variant<xla::OwningDeviceMemory, stream_executor::DeviceMemoryBase>::variant(T&&) [with T = absl::variant<xla::OwningDeviceMemory, stream_executor::DeviceMemoryBase>; long unsigned int I = <missing>; Tj = <missing>; absl::enable_if_t<std::is_constructible<Tj, T>::value, void>* <anonymous> = <missing>]'
./tensorflow/compiler/xla/service/maybe_owning_device_memory.h:29:7:   required from here
external/com_google_absl/absl/types/variant.h:501:7: internal compiler error: unexpected expression 'I' of kind template_parm_index
       class Tj = absl::variant_alternative_t<I, variant>,
       ^~~~~
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.
Target //tensorflow/tools/pip_package:build_pip_package failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 506.735s, Critical Path: 50.03s, Remote (0.00% of the time): [queue: 0.00%, setup: 0.00%, process: 0.00%]
INFO: 3097 processes: 3097 local.
FAILED: Build did NOT complete successfully

I'm getting the same compiler error, using:

Fedora 29 and the NVidia Drivers + Cuda 10.0 libraries from Negativo 17
bazel: 0.19.2
protobuf: 3.5.0
python: 3.7.3
gcc: 7.3.1
cuda: 10.0
cudnn: 7.4.2
nccl: 2.4.2

I've attempted to match my versions as closely as possible to the tested build configurations but still bombing out with similar output:
ERROR: /path truncated for privacy/tensorflow-r1.13/tensorflow/compiler/xla/service/BUILD:3025:1: C++ compilation of rule '//tensorflow/compiler/xla/service:maybe_owning_device_memory' failed (Exit 1)
In file included from ./tensorflow/compiler/xla/service/maybe_owning_device_memory.h:20:0,
                 from tensorflow/compiler/xla/service/maybe_owning_device_memory.cc:16:
external/com_google_absl/absl/types/variant.h: In substitution of 'template<long unsigned int I, class T> using variant_alternative_t = typename absl::variant_alternative::type [with long unsigned int I = I; T = absl::variant<xla::OwningDeviceMemory, stream_executor::DeviceMemoryBase>]':
external/com_google_absl/absl/types/variant.h:501:7:   required by substitution of 'template<class T, long unsigned int I, class Tj, absl::enable_if_t<std::is_constructible<Tj, T>::value, void>* <anonymous> > constexpr absl::variant<xla::OwningDeviceMemory, stream_executor::DeviceMemoryBase>::variant(T&&) [with T = absl::variant<xla::OwningDeviceMemory, stream_executor::DeviceMemoryBase>; long unsigned int I = <missing>; Tj = <missing>; absl::enable_if_t<std::is_constructible<Tj, T>::value, void>* <anonymous> = <missing>]'
./tensorflow/compiler/xla/service/maybe_owning_device_memory.h:29:7:   required from here
external/com_google_absl/absl/types/variant.h:501:7: internal compiler error: unexpected expression 'I' of kind template_parm_index
       class Tj = absl::variant_alternative_t<I, variant>,
       ^~~~~
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.
Target //tensorflow/tools/pip_package:build_pip_package failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 506.735s, Critical Path: 50.03s, Remote (0.00% of the time): [queue: 0.00%, setup: 0.00%, process: 0.00%]
INFO: 3097 processes: 3097 local.
FAILED: Build did NOT complete successfully

Same error here. This occurs on an Amazon Linux x1.32xlarge instance, in the stock Python 3.6 conda environment.

@Xaenalt We are checking to see if you still need help on this issue, as you are using an older version of tensorflow(1.x) which is officially considered as end of life. We recommend that you upgrade to 2.6 which is latest stable version of TF and let us know if the issue still persists in newer versions. Thanks!

I haven't tried in a while, I'll close it to get it out of the queue, I'll reopen a diff issue for new versions if I hit anything


Target v1 CRD API

Closes #65.

Codecov Report

Merging #66 (bba801d) into master (259818b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   77.72%   77.72%
=======================================
  Files           8        8
  Lines         395      395
=======================================
  Hits          307      307
  Misses         60       60
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259818b...bba801d. Read the comment docs.


Add-in error, the content is blocked because it isn't signed by a valid security certificate

Can you guys guide in signing a valid certificate? where to install it from?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b98fcab-f608-d0dd-08ab-633d4772f699
Version Independent ID: ad0a00c9-e5c2-fdfc-732e-f14869088f4a
Content: Tutorial: Build a message compose Outlook add-in - Outlook Developer
Content Source: docs/add-ins/addin-tutorial.md
Product: outlook
Technology: add-ins
GitHub Login: @o365devx
Microsoft Alias: o365devx

@SaiKoduri3: Sorry that you are facing an issue with the certificate. Can you share some more details about your platform, Office version, etc.? Did you receive a prompt to install the certificate (see note in the tutorial)?

@ElizabethSamuel-MSFT Thanks for reaching out. I did get it when I ran it for the first time in my machine. The addin works fine in my computer at my local host. When I try to export the development folder to other computer and run with other user credentials. I am getting this error. Now I am not getting a prompt to install the certificate. Now how do I install the certificates in the other user's computer and get it worked. Once again thanks for your help. Office version is 2016 and above.

@SaiKoduri3: Thanks for providing more info. I'll check into this and get back to you. Thanks.

@SaiKoduri3 If I understand correctly, you're trying to run the add-in on another computer (Computer2) with other credentials with the server on that other machine (Computer2). Or is the server still on the first machine (Computer1)?
If the server is on Computer2, maybe you can try installing the dev cert using npx office-addin-dev-certs install. See this other issue for a little context.
Do let us know which scenario applies.
Thanks.

@SaiKoduri3 You can also take a look at these testing options and use the one that applies to your configuration/setup.
I'll go ahead and close this issue now but if you're still facing a problem, let us know and we can reopen it.

I seen this issue close, but I have exactly the same problem on my computer. I install and run the npx office-addin-dev-certs install, but Outlook still consider that is not sign by trust certificate. How really fix that ?

@teken Thanks for your comment, I actually changed port from 3000 to 4001 and my certificates were installed on 3000 port, so with help of your comment I deleted and reinstalled certificated by running 'npm run dev-server'


Root phone

Describe the bug
A clear and concise description of what the bug is.

The version of utilcode:
The device:
The version of device:

The code of bug

put your code here

The stack of crash

put the stack of crash here

Screenshots
If applicable, add screenshots to help explain your problem.
Please delete the current line and the followings.
Thank you for supporting AndroidUtilCode.

How to get it？


Change level of "Unsupported Language" message to prevent pop-up dialog spam

The following toast a.k.a. pop-up dialog appears each time an editor instance is opened where the initial language mode is set to anything that isn't defined in languageConfig.yaml (which, by default, includes even plaintext):
language is not supported by Colorful Comments, please add it to languageConfig.yaml

As it's an error level message, the aforementioned pop-up must be explicitly dismissed by the user as opposed to it dismissing itself after a short period of time.
I feel like it would be a good idea to change the level to something of less priority, such as info or even debug (which doesn't trigger a toast at all). That, and/or have the extension keep track of which languages it's already displayed this message for.

Thank you for the feedback ! I am new to developping VS-Code extensions, this is indeed not a good idea, I will make sure to change that !
The main idea is to make people aware of being able to add languages that are not yet supported by the extension
Should be done this weekend 😉

temporary solution
// sinon il s'agit de "default"
    else {
      this.supportedLanguage = false;
      const error_msg = "\"" + languageCode + "\"" + " language is not supported by Colorful Comments, please consider opening an issue on allemand-instable/Colorful-Comments github repository for language support.";
      vscode.window.showInformationMessage(error_msg)
    }

For now I will just make it as information level message, looking forward for a solution :

That, and/or have the extension keep track of which languages it's already displayed this message for.

I didn't find how to have a debug level message, if you know the syntax for that I would like to know ;)
Hope it gets it better though, sorry for the time spent, I am currently busy in my PHD

It looks like there are only three types of Display Notifications available: Information, Warning, and Error.
This article contains a helpful UX design flowchart:

It's important to limit the number of notifications sent in order to respect the user's attention. To help guide your decision on whether or not you should show a notification, please follow our notification decision tree:
Image

My recommendation would be to go with one of the following:

Keep the message's level at informational as you have done, but also have the extension keep track of which languages it has already displayed this message for so that it can avoid repeatedly nagging the user.
Combined with the first suggestion, also log the message via VSCode's extension host. Start by having the extension create an output channel for logging, and then go from there (LogOutputChannel, LogLevel, et cetera). To quote the section for window.createOutputChannel in the API documentation:

createOutputChannel(name: string, options: {log: true}): LogOutputChannel

Parameter
Description

name
Human-readable string which will be used to represent the channel in the UI.

options
Options for the log output channel.

Return
Description

LogOutputChannel
A new log output channel.

Same as the second suggestion, but don't show a message to the user at all and set the message's LogLevel to 2/Debug.

Personally (personally!) I would go with a combination of one and two.
Also, if it's worth mentioning: Extension logs can be accessed from within VSCode via Ctrl+Shift+P ➜ Developer: Show Logs… ➜ Extension Host (it opens up a console panel). They can also be accessed through Ctrl+Shift+P ➜ Developer: Open Extension Logs Folder, although this isn't as straightforward.

thx for the details
I will see what I can do later on


[Experiment] Unsafe queryset (non)copying

I thought it would be interesting to check what performance would look like if we were to disable certain safety mechanisms the ORM imposes. I've done this by adding an unsafe queryset method which, currently, only disables the copy procedure when chaining queryset methods together.
I benchmarked the following queryset using djangobench, and it's consistently about 1.3 - 1.4 times faster. Note that no actual SQL is being generated and sent to the server. Improvements diminish as soon as you interact with the database because it's responsible for a larger percentage of overall time. I also benchmarked the memory usage which is close enough to 1kb less.
qs = Book.objects.unsafe().filter(
        pages__lte=1000
    ).filter(
        author__region__startswith='region_'
    ).values('author__name').annotate(
        pagesum=Sum('pages'),
        counted=Count('*'),
        avgpg=Avg('pages')
    )

I think for querysets where the number of chained methods grows quite large there's value in looking to provide opt-in optimisations. Would anyone else be interested in something like this?

I think this is similar to the inplace() method Anssi proposed in https://code.djangoproject.com/ticket/20880. I rebased that patch a week or so ago and plan to send a PR when I get some time to clean it up a little more.

I've optimized this problem in the past by having a module level queryset object like:
the_books = Book.objects.filter(
    pages__lte=1000
).filter(
    author__region__startswith='region_'
).values('author__name').annotate(
    pagesum=Sum('pages'),
    counted=Count('*'),
    avgpg=Avg('pages')
)

def fetch_the_books():
    return the_books.all()

This avoids all the work of copying plus the work of constructing the filters etc. And if the queryset can't be created at import time it can always be cached in a module global.
unsafe() seems a bit too unsafe to me, there is a lot of code (e.g. paginators) that relies on the copying behaviour and unsafe would lead to hard to troubleshoot bugs.

I guess we can close this for now. Feel free to reopen if you continue work on it, Josh.

It was just an experiment to see what overhead could be avoided. The inplace patch you've linked to should do the same thing. I'd just be wary of Adams comments above, and provide a way to escape out of inplace for things like the paginator.


feat(threads): add mutex with priority inheritance

Description
Add a mutex implementation analogous to the existing Lock, with additional priority inheritance.
Unfortunately I don't think we can directly reuse Lock, because we need access to the inner ThreadList.
The PR also moves all synchronization primitives into a new sync submodule. Any objections?
Issues/PRs references
Issue: #321.
Depends on

#370
#381
#452

Open Questions
Change checklist

[ ] I have cleaned up my commit history and squashed fixup commits.
[x] I have followed the Coding Conventions.
[x] I have performed a self-review of my own code.
[x] I have made corresponding changes to the documentation.

I've rebased now, and moved the threading-mutex example into a threading-mutex test instead, analogous to the thread-lock test.

The PR also moves all synchronization primitives into a new sync submodule. Any objections?

No objections. How hard is it to chop that into another PR that we can merge right away?

The PR also moves all synchronization primitives into a new sync submodule. Any objections?

No objections. How hard is it to chop that into another PR that we can merge right away?

Not hard at all :slightly_smiling_face: #452.

On another note, when should we use that new mutex? Should we replace our uses of embassy_sync::mutex::Mutex with it?

Tldr: embassy_sync::mutex::Mutex is for usage inside of async tasks, riot_rs_threads::sync::Mutex for threads without an embassy executor.
embassy_sync::mutex::Mutex is the correct choice if we have (multiple) async tasks, because it only blocks only the waiting task, and other tasks on the same executor can still run. The riot_rs_threads::sync::Mutex can a) only be used with a executor_thread (otherwise it'd panic when its not inside a thread context, e.g. in case of the executor-interrupt), and b) always block the whole thread and thus also all other tasks that are running on the same executor.
The riot_rs_threads::sync::Mutex  is for non-async contexts. This could also be realized with the embassy Mutex + block_on, but the new Mutex has a smaller overhead and the priority inheritance feature.

This LGTM. Let's update to current main, fix linting issues and merge!

Thanks a lot @elenaf9!


Menu not working on mobile (Pixel XL or MotoG4)

Could someone test on i-phone?

Ready for testing in test2

Also available to test in test3

Working perfectly, thank you @Vino-S


🚀 : Support For KaiOS

Is your feature request related to a problem? Please describe.
Yes, the problem is that our application currently does not support KaiOS, which is a popular operating system for smart feature phones. This limits our reach to a significant user base.
Describe the solution you'd like
I would like our application to be fully compatible with KaiOS. This includes proper rendering, performance optimization, and compatibility with KaiOS-specific features.
Describe alternatives you've considered
An alternative could be creating a web-based version of our application that is optimized for the KaiOS browser. However, this might not provide as smooth a user experience as a native KaiOS app.
Additional context
KaiOS is used by millions of users worldwide, especially in emerging markets. Supporting this platform could significantly increase our user base.
https://developer.kaiostech.com/
Contributor: @pizofreude
If you want speed up process of this issue, please send 🚀 as a reaction.

Based on my personal research kaiOS has huge potential for adoption in developing countries since it allows for low spec devices to operate kaiOS. Other than Duolingo, I'm not aware any other language apps listed there. So First Mover advantage is for LangX is very strong there.

@pizofreude

*So First Mover advantage for LangX is very strong there.


[Bug] Segmentation violation when running workflow list

What are you really trying to do?
I am starting a development server in our CI system to run some tests. To check that the server is ready before starting the tests, I use ./temporal workflow list --address localhost:{port} command with the selected port substituted. The idea is to check the exit code of the command and to proceed once I get a zero.
Describe the bug
The command always fails in the CI with the following output.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x181efcc]

goroutine 1 [running]:
github.com/temporalio/tctl-kit/pkg/config.(*Config).EnvProperty(0x2601760?, {0x266d4ac, 0x7}, {0xc000bb65f8, 0x5})
	/home/runner/go/pkg/mod/github.com/temporalio/tctl-kit@v0.0.0-20230328153839-577f95d16fa0/pkg/config/config.go:89 +0x2c
github.com/temporalio/cli/env.loadEnv(0xc000d0c980)
	/home/runner/work/cli/cli/env/env.go:221 +0x22c
github.com/temporalio/cli/common.AddBeforeHandler.func1(0x2?)
	/home/runner/work/cli/cli/common/util.go:548 +0x4b
github.com/temporalio/cli/common.AddBeforeHandler.func1(0xc000dd2dc0?)
	/home/runner/work/cli/cli/common/util.go:542 +0x34
github.com/urfave/cli/v2.(*Command).Run(0xc000dd2dc0, 0xc000d0c980, {0xc000bb2330, 0x3, 0x3})
	/home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.23.6/command.go:211 +0x502
github.com/urfave/cli/v2.(*Command).Run(0x4720680, 0xc000d0c800, {0xc000d0c840, 0x4, 0x4})
	/home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.23.6/command.go:264 +0xcd7
github.com/urfave/cli/v2.(*Command).Run(0xc0008dedc0, 0xc000d0c680, {0xc0000500a0, 0x5, 0x5})
	/home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.23.6/command.go:264 +0xcd7
github.com/urfave/cli/v2.(*App).RunContext(0xc0005183c0, {0x3399900?, 0xc00005a068}, {0xc0000500a0, 0x5, 0x5})
	/home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.23.6/app.go:333 +0x665
github.com/urfave/cli/v2.(*App).Run(...)
	/home/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.23.6/app.go:310
main.main()
	/home/runner/work/cli/cli/cmd/temporal/main.go:14 +0x45

Note that it works on my laptop running Ubuntu 22.04.
Upd: I believe, an absent HOME environment variable may be the culprit. An error message or a fallback would be a fix.
Minimal Reproduction
Unfortunately, I cannot reproduce the environment we have in our cloud CI.
Environment/Versions

OS and processor: Linux, Ubuntu, amd64
Temporal Version:

temporal --version
temporal version 0.9.0 (server 1.20.2) (ui 2.15.0)

Are you using Docker or Kubernetes or building Temporal from source?
I am using the CLI binary from the official website.

Additional context
Hopefully, this bug is obvious from the stack trace. Let me know if you need more details, I may be able to extract more information from our CI system.

yes the logs seem to be enough. Should be a quick fix getting back shortly

Are you use that --env flag was not set with your command? I believe it shouldn't reach /home/runner/work/cli/cli/env/env.go:221 according to https://github.com/temporalio/cli/blob/f8c84edae78379ad3716ed51c84120c923db9388/env/env.go#L212

I am pretty confident that it was not. Here is my Python code
subprocess.run(['./temporal', 'workflow', 'list', '--address', 'localhost:{}'.format(port)])

BTW we are now using temporal operator cluster health to check the development server startup in the tests. It seems to be more appropriate.

Testing I could not reproduce this on the CLI rewrite branch I could not reproduce this be unsetting the HOME env variable

Just want to report that I'm facing the same error. If an environment is passed in, but it doesn't contain the HOME variable, the panic occurs.
I think it would be better to catch the error and explain what's going on instead.


[FLOC-3108] A big composeable AMP argument type

Fixes: https://clusterhq.atlassian.net/browse/FLOC-3108

I merged forward to deal with some conflicts.

OK, merge when green.


ResultCache's path should include RUBY_VERSION

The parser gem chooses which parser to use based on RUBY_VERSION. Because of this, it is possible, if the same version of rubocop is installed under two different versions of ruby on the same machine, to get different results from each. But because of the caching in rubocop 0.34, one set of results would be masked/hidden.
To work around this issue, RUBY_VERSION should be included in the ResultCache's path.

I agree. There are some offenses that are not reported for all ruby versions, so we should add RUBY_VERSION to the path.


IAM permissions

maybe something for the next release?

An example minimal IAM policy, so that the key + secret can only be used for the functionality of this script
IAM role / credential file support (since you can see the paramaters given on the system if you do a "ps auxf")

I'm rolling the second item (IAM role / credential file support) into an issue that will involve allowing all configurations to be specified in a file rather than on the command line.


Feat:  Include blogs and articles

Describe the feature
Include book-related blog and articles to inspire and motivate users  to develop a better reading culture.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Vin205 Assigned


Create a requirements.txt and document pip dependencies of each interviewer

While reviewing #70, which adds a dependency on litellm, I realized that this repo hasn't actually got an explicit list of it's dependencies.
It probably makes sense to include both a generic requirements.txt with global dependencies (yaml, jinja, etc..) as well as add a column to the list of available interviewers in README.md with notes on which packages each interviewer requires.

hey @the-crypt-keeper what would an explicit list of dependencies here look like - i would assume this was covered by our pyproject.toml - https://github.com/BerriAI/litellm/blob/d0ec8446295d86f72c17e1c9c1b430f866ae1cc9/pyproject.toml#L9

as part of #180 there's now requirements.txt for the base scripts as well as transformers, vllm and litellm


Add support for binding to static value in MultiBinding

<DropDown.IsVisible>
    <MultiBinding Mode="OneWay" Converter="{Static converters:ObjectEqualityMultiConverter.Instance}">
        <Binding SourcePropertyPath="Editor.CurrentTool"/>
        <Binding SourcePropertyPath="{Static core:Tool.Path}"/>
    </MultiBinding>
</DropDown.IsVisible>

this part of code currently does not work:
<Binding SourcePropertyPath="{Static core:Tool.Path}"/>

This will require Binding.Source: the syntax will be:
<Binding Source="{Static core:Tool.Path}"/>

or
<Binding Source="{Static core:Tool}" Path="Path"/>


Help in creating stanzaio.bundle.js

Hi,
I am using Windows and I am trying to build stanzaio.bundle.js. Please correct me if my steps are wrong. The server I am using are Openfire v4.1.0

mkdir Install
cd Install
git clone https://github.com/legastero/stanza.io.git
cd stanza.io
npm install
As I am using Windows, i have edited package.json scripts "build : make build" to  "build : browserify index.js > stanzaio.bundle.js"
npm run build
stanzaio.bundle.js is generated
When i try to run demo.html, I have enter
JID: username@domain
Password: xxx
Websocket/Bosh Url: http://domain:7070/http-bind/
The console in the browser show this error:
Uncaught ReferenceError: XMPP is not defined at HTMLFormElement.loginInfo.onsubmit       (demo.html:139)

What should I do to established the connection correctly? And if I do established correctly, what will I see in the browser? In the steps provided, there is this step:

Use the JS console to play with the XMPP client (var client).

How should I go with this step?
Thanks for the guidance.
Regards
Kenneth

try
browserify --full-paths --standalone XMPP index.js > stanzaio.bundle.js
in step 6 (as its done in the Makefile)

Hi,
Thanks for the quick response. After i generate the bundle again, there is no error in the console. However it seems not able to connect. I received this in my browser:
raw:outgoing

streamFeatures
{
"sasl": {
"mechanisms": [
"PLAIN",
"SCRAM-SHA-1",
"EXTERNAL",
"CRAM-MD5",
"DIGEST-MD5"
]
},
"bind": {
"jid": ""
},
"session": {
"optional": true
},
"lang": "en"
}
stream:data
{
"sasl": {
"mechanisms": [
"PLAIN",
"SCRAM-SHA-1",
"EXTERNAL",
"CRAM-MD5",
"DIGEST-MD5"
]
},
"bind": {
"jid": ""
},
"session": {
"optional": true
},
"lang": "en"
}
raw:incoming
PLAINSCRAM-SHA-1EXTERNALCRAM-MD5DIGEST-MD5
raw:outgoing

raw:outgoing

raw:incoming

auth:failed
stream:error
{
"condition": "policy-violation",
"text": "Failed to negotiate stream features: authentication failed"
}
raw:outgoing

sasl:failure
{
"lang": "en",
"condition": "not-authorized"
}
stream:data
{
"lang": "en",
"condition": "not-authorized"
}
raw:incoming

bosh:terminate
{
"ack":<PHONE_NUMBER>,
"from": "",
"to": "",
"type": "terminate",
"version": "1.0"
}
stream:end
disconnected
Client instance: {
"rid":<PHONE_NUMBER>,
"wait": 30,
"maxRetries": 5,
"useStreamManagement": true,
"transports": [
"bosh"
],
"sasl": [
"external",
"scram-sha-1",
"digest-md5",
"plain",
"anonymous"
],
"jid": "username@domain",
"boshURL": "http://domain:7070/http-bind/ ",
"server": "domain name",
"credentials": {
"password": "xxx"
}
}
raw:incoming

Any idea where went wrong?
Best Regards
Kenneth

I am facing the same problem.

Your client and server are negotiate SASL EXTERNAL authentication mechanism (which mean you need to provide client certificate issued to your xmpp address) but authentication was failed (you didn't provide any certificate, right?). Just disable EXTERNAL mechanism for now in server and/or client (and I think it should not be enabled by default)

@ken8891 I built in the following way: https://github.com/earayo/stanza.io-demo
I hope it can help you.


Fix annotation folding

Small improvement on #137
This should improve the amount of times substract_fold_lines is called per annotation.

Thank you for your code!