Make "This workspace has extension recommendations." more useful

Right now this message shows even if I have already all the suggested extensions installed.
It should show only if someone from the team add a new extension to the json file.

Duplicate of #31345


PNGs used at the moment are huge

Introduce a task to minify/optimise the image assets of the site

Done, manually resized for now


Module build failed: Error: Can't find closure dependency goog.xxx

Followed the example in es6-webpack2 I've found I can't make closure-loader work:
ERROR in ./node_modules/google-closure-library/closure/goog/crypt/sha1.js
Module build failed: Error: Can't find closure dependency goog.crypt.Hash
my webpack.config.js is:
var HtmlWebpackPlugin = require('html-webpack-plugin'),
    webpack = require('webpack'),
    pathUtil = require('path');

module.exports = {
  entry: {
    app: './src/index.js'
  },
  output: {
    filename: 'bundle.js',
    path: __dirname + '/dist'
  },
  resolveLoader: {
    modules: ['closure-loader', pathUtil.resolve(__dirname, 'node_modules')]
  },
  module: {
    rules: [
      {
        test: /\.js$/,
        loaders: ['closure-loader'],
      },
    ]
  }
};

my js file is very simple:
import Sha1 from 'google-closure-library/closure/goog/crypt/sha1';

import _ from 'lodash';

function component() {
  var element = document.createElement('div');
  var sha1 = new Sha1();
  sha1.update("foobar");
  var hash = sha1.digest();

  element.innerHTML = _.join(['Hello', 'webpack', hash], ' ');

  return element;
}

document.body.appendChild(component());

Thanks!

I'll see if I can take a look at it later today!

I got your example to work. Your configuration is missing some parts, take a look at the closure lib examples.
Try this configuration (you will need imports-loader and exports-loader for this to work):
var HtmlWebpackPlugin = require('html-webpack-plugin'),
    webpack = require('webpack'),
    pathUtil = require('path');

module.exports = {
  entry: {
    app: './src/index.js'
  },
  output: {
    filename: 'bundle.js',
    path: __dirname + '/dist'
  },
  resolveLoader: {
    modules: ['closure-loader', pathUtil.resolve(__dirname, 'node_modules')]
  },
  module: {
    rules: [
      {
        test: /google-closure-library\/closure\/goog\/base/,
        use: [
          'imports-loader?this=>{goog:{}}&goog=>this.goog',
          'exports-loader?goog',
        ],
      },
      {
        test: /google-closure-library\/closure\/goog\/.*\.js/,
        loader: pathUtil.resolve(__dirname, '../..'),
        options: {
          paths: [
            pathUtil.resolve(__dirname, 'node_modules/google-closure-library/closure/goog'),
          ],
          es6mode: true,
        },
        exclude: [/google-closure-library\/closure\/goog\/base\.js$/],
      },
      {
        test: /\.js$/,
        loaders: ['closure-loader'],
      },
    ]
  },
  plugins: [
    new webpack.ProvidePlugin({
      goog: 'google-closure-library/closure/goog/base',
    }),
  ],
};

Thanks eXaminator with you suggestion and after adding exclude rule for project files it works!
      {
        test: /\/src\/.*\.js/,
        loaders: ['closure-loader'],
        exclude: [/node_modules/, /test/],
      },


"Access Denied" Error

Hi! I'm trying to set up an Allure report deploy for my project, and have encountered this error.
When the action ran for the first time, everything went fine - the data deployed correctly on the s3-bucker. But the second and subsequent launches for some reason gave an Access Denied error on "Generating allure report" step.

I've checked several times, the problem is definitely not file system permissions or bucket accesses.

@e965 Sorry for late response.
There is an option to enable debug logging, You can try that to see if it will show a bit more info where this error is coming from. At the moment, it' s hard to tell what could be the reason for this.


Does detectHomebrew support styled-components?

Apologies if this is the wrong place to ask the question and also really great effort writing a static analyser for detecting design system adoption - this is very valuable.
We know a lot of our DS consumers will be using styled-components for their "homebrew" components, as you call them, will radius-tracker be able to work with this? I saw that in your talk it will be focusing on lower-case elements to determine "homebrew".
Another question along a similar line: what about when components are built with other tooling that is not the design system you are measuring adoption for?

Will radius-tracker be able to work with [styled-components]?

Good question. At the moment, styled components won't be detected. You can see a range of things detected as homebrew in tests: https://github.com/rangle/radius-tracker/blob/fb8287c17011c1f10849e8c44252b23e6c197870/src/lib/detectHomebrew/detectHomebrew.spec.ts
CSS-in-JS libs tend to create component via function calls or tagged literals — those are easy enough to find for specific css-in-js lib, the problem is with number varieties of those libs.
If you have a project using styled components or similar that you want to analyze right now, your best bet is using the tool programmatically, instead of CLI. That way you can use filterImports from resolveDependencies to find imports from the styled components, and then track usages of those imports.
Long term, a plugin system could work for CSS-in-JS libs.

what about when components are built with other tooling that is not the design system you are measuring adoption for?

I'm not sure I understand the question. Could you elaborate?

Thanks the answer! The tests file makes your current coverage very clear ^_^

That way you can use filterImports from resolveDependencies to find imports from the styled components, and then track usages of those imports.

Okay, thanks for the headsup on this approach!

I'm not sure I understand the question. Could you elaborate?

Sure! However you already answered the question with the link to tests.
But for clarity - I was wondering that if a file has the following code, would it be able to determine these homebrew cases:
import { Button } from 'my-design-system' // all good
import { Select } from 'legacy-internal-component-library' // can this be detected as "homebrew"
import { Filter } from 'chakra-or-something' // also this

As these would also be rendered as capitalised custom elements

Long term, a plugin system could work for CSS-in-JS libs.

I think a plugin system would be beneficial for many use-cases of determining both homebrew and adoption

It's only been a year!
There's no support for styled components for the purpose of homebrew detection. E.g. in the code below Component is now detected as homebrew, because it directly outputs a DOM element.
import styled from "styled-components"
const Div = styled.div`background: red`
const Component = () =>
Hello, World!

On top of that, tracker supports detection of multiple targets for a while, so imports from multiple component libraries can be tracked separately. See "Multi-target configuration" in the config docs: https://rangle.github.io/radius-tracker/configuration_file#multi-target-configuration
This covers the use case you brought up earlier:

I was wondering that if a file has the following code, would it be able to determine these homebrew cases:
import { Button } from 'my-design-system' // all good
import { Select } from 'legacy-internal-component-library' // can this be detected as "homebrew"
import { Filter } from 'chakra-or-something' // also this

Let me know if you'd like help setting up the tracker, I'm happy to jump on a call and guide you through configuration steps.

Hiya! Just as a follow-up to @beamery-tomht, what we'd like to do is check multiple repos with the report generation script, and we wondered about a way to convert the SQLite data into JSON, if possible. Any tips/advice on that?

@smoogly we've chatted about it and have a few concerns - I think I haven't communicated our needs well enough. It'd be easier over a call I think, if you're still willing to do that - which timezone are you based in?

I am still happy to help! I've reached out on LinkedIn, but also feel free to drop me a message at<EMAIL_ADDRESS>— let's find a good time for a call.


no init method

there is no init method in last version but there is a connect which I think does the same

Thank you for your feedback, all documents are updated Now, check it out here:  https://github.com/cafebazaar/flutter_poolakey
Fixed in #16


[agent] mojo publishes when Thread is not started

Describe the bug
mojo publishes when Thread is not started.
To Reproduce

Stop wpantund or wpanctl leave
start otbr-agent
use avahi-browse -arp to check services published by the DUT

Expected behavior
No service being published.
Console/log output
Thread is published with network empty and extended pan id all zero.
Additional context
None

Resolved by #329.


Option to Play a Beep/Sound Alert Upon Command Completion

Would be nice to have an option for an alert when a youtube-dl command completes at the command line.
I'm downloading hundreds of differently-sized videos with custom commands one by one. Noticing when each command ends would be easier with an alert.
Thanks for your consideration.

Try using --exec option.


Error in watch_repos

Installation information

jumpscale version: 9.0
operating system: Linux

Detailed description
The error shown in the stack trace occurs when starting AYS server
Steps to reproduce
start ays server
Relevant stacktraces
Traceback (most recent call last):                                                                 │- ardb                      cluster_0cc47a3aad5a_bigmomma_sdf_data_26 | install         (ok)
  File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner                            │- ardb                      cluster_0cc47aab6702_bigmomma_sdb_data_29 | install         (ok)
    self.run()                                                                                │- ardb                      cluster_0cc47aab670a_bigmomma_sdc_data_37 | install         (ok)
  File "/usr/lib/python3.5/threading.py", line 862, in run                                         │- ardb                      cluster_0cc47aab6444_bigmomma_sdb_data_57 | install         (ok)
    self._target(*self._args, **self._kwargs)                                                      │- ardb                      cluster_0cc47a3b3d6a_bigmomma_sde_data_46 | install         (ok)
  File "/opt/code/github/jumpscale/ays9/JumpScale9AYS/ays/AtYourServiceFactory.py", line 141, in _w│- ardb                      cluster_0cc47a3b3d98_bigmomma_sdg_data_20 | install         (ok)
atch_repos                                                                                │- ardb                      cluster_0cc47aab6702_bigmomma_sde_data_32 | install         (ok)
    i = AYSNotify([d.encode() for d in [j.dirs.VARDIR, j.dirs.CODEDIR]], mask=mask)                │- ardb                      cluster_0cc47a3b3d98_bigmomma_sdd_data_17 | install         (ok)
  File "/usr/local/lib/python3.5/dist-packages/inotify/adapters.py", line 261, in __init__         │- ardb                      cluster_0cc47aab6702_bigmomma_sdf_data_33 | install         (ok)
    self.__load_trees(paths)                                                                       │- ardb                      cluster_0cc47aab66e2_bigmomma_sda_data_49 | install         (ok)
  File "/usr/local/lib/python3.5/dist-packages/inotify/adapters.py", line 264, in __load_trees     │- ardb                      cluster_0cc47aab6702_bigmomma_sdc_data_30 | install         (ok)
    _LOGGER.debug("Adding initial watches on trees: [%s]", ",".join(paths))                        │step:5 (ok)
TypeError: sequence item 0: expected str instance, bytes found

@zaibon seems that you have installed the inotify library from other source than our gigforks (which is installed with ays9 by default). Please try to install it from: https://github.com/gigforks/PyInotify

The js9 installer need to be updated then cause I use https://github.com/Jumpscale/developer to install

@zaibon The js9 installer already uses this fork when you build the container normally:
https://github.com/Jumpscale/ays9/blob/master/setup.py#L17

Why is this installed like that in the first place ? This line should part of the install_requires  in the setup function.
but other then that, if we indeed install the correct version, then it's indeed a bug

I just tested with the correct lib installed, error is gone.
So we need to validate the correct lib if installed

I didn't get the reason for using pip3 install  instead of adding it to install_requires
https://github.com/Jumpscale/ays9/commit/ac8dfcb6db734a008402c289764ff42d6d2946e6
I have tested normal installation and it installed and worked with the correct version


Senec Systems APP Api

As the latest Senec Home 4 System don't have a local interface (lala.cgi) at all and for other System with latest firmware update data such as Statistik have been removed. I made the effort to document the REST Services that are used by the current stable Senec APP v 4.3.3 and the upcoming version 4.4.0_beta01.
The Dokumentation will be constantly updated. So just an information if it's ever planned to include Senec Home 4 Systems
https://documenter.getpostman.com/view/932140/2s9YXib2td

As the latest Senec Home 4 System don't have a local interface (lala.cgi) at all and for other System with latest firmware update data such as Statistik have been removed. I made the effort to document the REST Services that are used by the current stable Senec APP v 4.3.3 and the upcoming version 4.4.0_beta01. The Dokumentation will be constantly updated. So just an information if it's ever planned to include Senec Home 4 Systems https://documenter.getpostman.com/view/932140/2s9YXib2td

So is it possible to access the Home 4 via API? My latest info was, that the API was removed?

So is it possible to access the Home 4 via API? My latest info was, that the API was removed?

@oakdesign could you comment? Would you want to try a PR for a new template using the HTTP plugin?

No new information- closing.


FIX chan locs in create_info

If you don't do this, all the channel locations will be same even if you modify them

LGTM. +1 for merge

thanks @jasmainak


[CircleGraph] as circle model graph viewer

Current CircleGraphPanel was introduced as development for GUI node selection like Partition Editor.
As basic feature is to show .circle model, we can provide this panel as .circle model viewer.
Roughly we need to

add a mode in CircleGpaphCtrl as just a viewer and as a node selector
provide same feature like netron for viewer mode

I'll work on this after partition editor feature is enabled.

How to set mode?

mode related switches are for menu
menu creation is done at startup
this, need to set mode in global when loading

CircleViwer to do features

[ ] update view when file has changed
[ ] ...

done for now


DO NOT MERGE: Python vKit snippet gen

This is a WIP for early review and feedback. FYI @vchudnov-g, @tbetbetbe, @pongad, @garrettjonesgoogle, @geigerj, @tcoffee-google, and @saicheems.
It currently just does basic snippet gen for PythonCodeGeneratorTest.PythonNoPathTemplatesBaseline. Next steps are to get it working with PythonLibraryBaseline (currently disabled), and then to try it out on real APIs like PubSub and Logging.
Part of this PR is factoring out code from Java snippet gen that is also useful for Python. Another part is separating the part of Java main.snip that does vKit snippet gen into its own file (method_sample.snip), to make it easier to follow (Java main.snip currently has almost 800 lines of code on master; this change separates out the 150 lines that pertain to vKit snippet gen).

This PR and my PR (https://github.com/googleapis/toolkit/pull/148) were published literally 1 minute from each other (3:14 vs 3:15). There are a substantial number of conflicts. I will discuss with @bjwatson how to resolve them.

@garrettjonesgoogle walked me through his PR. Since he will almost certainly merge first (he's functionality complete whereas I'm not), I will proactively merge his branch into mine and resolve the conflicts.
Nevertheless, this is ready for early feedback if y'all want to take a look.

Left a few comments, but mostly just nitpicky stuff, so feel free to ignore if you're looking for more structural feedback at this point.

Thanks @geigerj!

This is nearly done. It should be properly merged with the refactoring done by @garrettjonesgoogle. I still need to add support for Python Protobuf message arguments and update the Python library test.

This is functionally complete, but the devil's in the details. I've compared my generated samples against Tim's hand-written samples (http://pythonhosted.org/gax-google-pubsub-v1/), and identified a few remaining issues:

Formatted var names are kind of funky (see PublisherApi.delete_topic() and LibraryApi.merge_shelves())
Protobuf messages should be properly imported (see FIXMEs in PythonGapicContext.java for LibraryApi)
Tim’s formatted variable arguments are a little friendlier looking than mine (e.g. ‘my-foo’ rather than "[FOO]")
Should we skip optional parameters? (see SubscriberApi.create_subscription())

I also need to review the usability study results to incorporate appropriate feedback, and finally update the baseline file for the Python library test. Looks like this will be done sometime next week.

@tbetbetbe @geigerj I spent some time today getting Sphinx doctest working with the auto-generated snippets. It looks like it's triggering a bug in the surface, but it could be a user error (especially given that this has already been through a usability study).

The error is in the call to api = PublisherApi() (which every snippet does)
An example error occurs in publisher_api.py, line 183, in __init__
The error is TypeError: construct_settings() takes at least 6 arguments (7 given)

Let's discuss next week to figure out what's going on.

Regarding formatting of variable arguments: we specifically chose the format "[FOO]" instead of "my-foo" to avoid the problem with project, where my-project is actually a real project that exists, so if people try to run the sample code with that project, they will get a permission denied error, which is confusing.

FYI @bjwatson @jmuk The TypeError Brian is seeing looks like it may come from googleapis/gax-python#103. It looks like the code generator was not updated after this change to GAX.

Thanks @garrettjonesgoogle. I now remember that discussion. I will keep the current format for example values.

@geigerj @jmuk Thanks for the analysis of the error I saw. When do you think it could be fixed?

Well, the code generator was updated already. I think that's because the gax package in PyPI wasn't updated yet.
For now, please fetch the HEAD of googleapis/gax-python and install it locally.

Also -- we need to update the package dependency on packman -- filed https://github.com/googleapis/packman/issues/37

Let me know if using HEAD for gax-python fixes the issue. If it does, I can push the latest version to PyPI.

gax-python repository is up to date
(see https://github.com/googleapis/gax-python/blob/master/google/gax/api_callable.py#L317), and the version is also updated to 0.11.0.

I've confirmed that updating GAX fixes the TypeError issue.
I've pushed Python GAX 0.11.0 to PyPI and filed PR googleapis/packman#38 to update the Packman configuration.

@geigerj @jmuk Agreed about that fix. Now I'm seeing this error:
Document: gcloud.pubsub.publisher_api
-------------------------------------

Warning, treated as error:
WARNING: **********************************************************************
File "gcloud.pubsub.publisher_api.rst", line 10, in default
Failed example:
    api = PublisherApi()
Exception raised:
    Traceback (most recent call last):
      File "/usr/local/google/home/brianwatson/.linuxbrew/Cellar/python/2.7.11/lib/python2.7/doctest.py", line 1315, in __run
        compileflags, 1) in test.globs
      File "<doctest default[1]>", line 1, in <module>
        api = PublisherApi()
      File "/usr/local/google/home/brianwatson/src/gapi-dev/gapi-pubsub-python/.tox/docs/lib/python2.7/site-packages/gcloud/pubsub/publisher_api.py", line 189, in __init__
        pubsub_pb2.beta_create_Publisher_stub,
    AttributeError: 'module' object has no attribute 'beta_create_Publisher_stub'

Just to check, can you confirm that you are loading the right pubsub_pb2.py? There are actually two of these floating around after you've run generation. One is the "real" file, generated by protoc, and one is a "fake" file templated by messages.snip, which is used only to generate documentation (which therefore wouldn't have the expected attribute beta_create_Publisher_stub).

Thanks @geigerj. I did not realize two of these are created. I'll take a closer look today to check.

@geigerj Your theory is correct. I didn't realize this because I wasn't running PythonGrpcClientPipeline; just PythonGapicClientPipeline. Unfortunately, when I substitute the pubsub_pb2.py generated by the former into gapi-pubsub-python, I get different errors running tox:
brianwatson@brianwatson0:~/src/gapi-dev/gapi-pubsub-python$ tox -e docs
GLOB sdist-make: /usr/local/google/home/brianwatson/src/gapi-dev/gapi-pubsub-python/setup.py
docs inst-nodeps: /usr/local/google/home/brianwatson/src/gapi-dev/gapi-pubsub-python/.tox/dist/gax-google-pubsub-v1-1.0.13.zip
docs installed: alabaster==0.7.8,Babel==2.3.4,docutils==0.12,enum34==1.1.6,futures==3.0.5,gax-google-pubsub-v1==1.0.13,google-gax==0.11.0,googleapis-common-protos==1.1.0,grpc-google-pubsub-v1==1.0.15,grpcio==0.13.1,httplib2==0.9.2,imagesize==0.7.1,Jinja2==2.8,MarkupSafe==0.23,oauth2client==2.1.0,ply==3.8,protobuf==3.0.0b3,pyasn1==0.1.9,pyasn1-modules==0.0.8,Pygments==2.1.3,pytz==2016.4,PyYAML==3.11,rsa==3.4.2,six==1.10.0,snowballstemmer==1.2.1,Sphinx==1.4.2,sphinx-rtd-theme==0.1.9
docs runtests: PYTHONHASHSEED='411169849'
docs runtests: commands[0] | python -c import shutil; shutil.rmtree('docs/_build', ignore_errors=True)
docs runtests: commands[1] | python -c import shutil; shutil.rmtree('docs/generated', ignore_errors=True)
docs runtests: commands[2] | sphinx-build -W -b doctest -d docs/_build/doctrees docs docs/_build/html
Running Sphinx v1.4.2
making output directory...
loading pickled environment... not yet created
[autosummary] generating autosummary for: apis.rst, foo.conf.rst, gcloud.pubsub.publisher_api.rst, gcloud.pubsub.subscriber_api.rst, google.protobuf.timestamp_pb2.rst, google.pubsub.v1.pubsub_pb2.rst, index.rst, starting.rst
Failed to import 'google.pubsub.v1.pubsub_pb2': no module named google.pubsub.v1.pubsub_pb2
Failed to import 'gcloud.pubsub.publisher_api': no module named gcloud.pubsub.publisher_api
Failed to import 'gcloud.pubsub.subscriber_api': no module named gcloud.pubsub.subscriber_api
Failed to import 'google.protobuf.timestamp_pb2': no module named google.protobuf.timestamp_pb2

Warning, treated as error:
WARNING: [autosummary] failed to import u'gcloud.pubsub.publisher_api': no module named gcloud.pubsub.publisher_api

ERROR: InvocationError: '/usr/local/google/home/brianwatson/src/gapi-dev/gapi-pubsub-python/.tox/docs/bin/sphinx-build -W -b doctest -d docs/_build/doctrees docs docs/_build/html'
_________________________________________________________________________________________________ summary __________________________________________________________________________________________________
ERROR:   docs: commands failed

I've spent enough time on this today. I'm going to punt on doctest for now and finish up the other issues that have been raised for this PR. Perhaps we can discuss this issue in more detail on Friday.

Yup, let's chat about this Friday.
I'm not sure specifically what's causing your issue, but the short answer is that the "real" pubsub_pb2 shouldn't be in gapi-pubsub-python; instead, it should get pulled in with the package grpc-google-pubsub-v1 as a dependency. So if you also have a module called google.pubsub.v1.pubsub_pb2 in addition to the module of the same name in that package, your local package is likely shadowing the dependency.

@geigerj and I got doctest working today, but it required a lot of manual changes. I think this can be automated, but it will take some time and is out of scope for this feature. I will write up a design document next week.
Now I'm focused on fixing the remaining issues with these snippets.

@geigerj @garrettjonesgoogle All I have left to do tomorrow is fixing the imports for proto messages, and adding sample code to python_main_library.baseline (and re-enabling that test). Then this is ready for final review.

@pongad @garrettjonesgoogle @geigerj This is ready for final review!

I have addressed all of Jacob's comments. PTAL

LGTM. I just had a small optional thing; I think we should prioritize getting this committed soon because it enables other languages to do sample gen for vkit too.

LGTM

Woo hoo! Squashing and merging now. :)


Add Snowflake structured data types to unmodifiable Data Types

Add Snowflake structured data types in the unmodifiable Data Types list to avoid the incorrect results of the diffChangeLog command
Impact

[x] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Structured data types are compared incorrectly.
Structured data types in the Snowflake can not be created with parameters: https://docs.snowflake.com/en/sql-reference/data-types-semistructured.html

But the result of comparing tables with these types of columns with the diffChangeLog command will be
CREATE OR REPLACE TABLE TEST_SEMI_STRUCTURED(
	var VARIANT(0),
	arr ARRAY(0),
	obj OBJECT(0));

because by default Liquibase returns data type name + parameters
And the simplest way to avoid it is adding data types in the unmodifiable types list:
https://github.com/liquibase/liquibase/blob/master/liquibase-core/src/main/java/liquibase/snapshot/jvm/ColumnSnapshotGenerator.java#L435
Steps:

Create a table in schema1:

CREATE TABLE TEST_SEMI_STRUCTURED(
	var VARIANT,
	arr ARRAY,
	obj OBJECT);

Compare schema1 with an empty schema.

If I need to add tests - please, give me advice on how to do it better. Maybe like MSSQLDatabaseTest#isUnmodifiable?
If I need to create a ticket for the issue first - tell me also.

Initial/Pre-Review Thoughts
The change makes sense to me. I appreciate the detail in your PR.
There is no need for an issue for specific bugfixes like this. It can be nice to track and discuss the feature request (issue) independently from implementation options for that feature (PR) for more complex things, but for "X doesn't work unless we do Y" type bugs it's generally not worth the hasstle.
I'd tend to think this fix doesn't need a test. Tests should be reserved for "non-trivial code" especially "logic that can have bugs in it", but this basically just a declarative statement with no logic itself. The test would end up really just being "Is java able to correctly handle an array literal" which the answer is yes. We have tests elsewhere which check that "unmodifiable" values are being used correctly.
What could be useful as a test is more of an overall test that those newly-added datatypes are handled correctly, either through test-harness based tests in the liquibase-snowflake module or in the integration-tests module. But, neither are well set up for that right now on snowflake and I don't think it's worth blocking this PR for getting that going.
Questions I have:

None

Potential risks:

None

What could make the full review difficult:

Nothing

Thanks for the detailed response @nvoxland

@filipelautert If we talk about us, we had the Snowflake extension fork with all these fixes :)


HTML Template Should Be Per-slide

Users can pass their own HTML template file through the --html-template flag, but this overrides even the boilerplate HTML necessary to run Remark. It would be nicer if they could pass a template that would be used as the basis for each slide, but not for the presentation itself.

This needs to be rethought since I refactored things. Closing.


Make readable_id searchable in CMS

Steps to Reproduce

In the CMS, search for a readable_id in the search field (e.g. course-v1:MITxT+14.310x)

Expected Behavior

course-v1:MITxT+14.310x | Data Analysis for Social Scientists will be returned in the search results

Actual Behavior

No results are returned.
The search is not searching the readable_id field

Related Issues
https://github.com/mitodl/mitxonline/issues/322
Screenshot or Screencast

@briangrossman Can we close this? Just checking in to make sure that we've verified this in production as well since it has a prerequisite, which is to run ./manage.py wagtail_update_index. However, there a many details on https://github.com/mitodl/mitxonline/pull/352.

@arslanashraf7
Thank you for the reminder to run this! I just ran it. The search it working.


Integration tests don't run locally

Environment

Python version: 3.7.12
Nautobot version: 1.3.0a0

Running invoke integration-test fails to initialise Selenium properly and run the tests
Steps to Reproduce
run invoke integration-test
Expected Behavior
Expect to see the Selenium tests run successfully
Observed Behavior
Traceback (most recent call last):
  File "/source/nautobot/utilities/testing/integration.py", line 214, in setUpClass
    browser_profile=profile,
  File "/usr/local/lib/python3.7/site-packages/splinter/browser.py", line 92, in Browser
    return get_driver(driver, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/splinter/browser.py", line 70, in get_driver
    raise err
  File "/usr/local/lib/python3.7/site-packages/splinter/browser.py", line 66, in get_driver
    return driver(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/splinter/driver/webdriver/remote.py", line 47, in __init__
    self.driver = Remote(command_executor, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/selenium/webdriver/remote/webdriver.py", line 157, in __init__
    self.start_session(capabilities, browser_profile)
  File "/usr/local/lib/python3.7/site-packages/selenium/webdriver/remote/webdriver.py", line 252, in start_session
    response = self.execute(Command.NEW_SESSION, parameters)
  File "/usr/local/lib/python3.7/site-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python3.7/site-packages/selenium/webdriver/remote/errorhandler.py", line 208, in check_response
    raise exception_class(value)
selenium.common.exceptions.WebDriverException: Message: <!DOCTYPE html>

  <meta charset="UTF-8">
  <link rel="stylesheet" type="text/css" href="/assets/displayhelpservlet.css" media="all"/>
  <link href="/assets/favicon.ico" rel="icon" type="image/x-icon" />

Selenium  v.

      Whoops! The URL specified routes to this help page.

      For more information about Selenium  please see the
      docs and/or visit the wiki.

        Or perhaps you are looking for the Selenium  console.

      Happy Testing!

      Selenium is made possible through the efforts of our open source community, contributions from
      these people, and our
      sponsors.

----------------------------------------------------------------------
Ran 0 tests in 0.156s

@briddo Can you confirm if this was fixed with this: https://github.com/nautobot/nautobot/pull/1361


Will  provide i18n?

Can you please be more descriptive with your suggestion? The more descriptive you are, the more likely people will discuss it.
Here are some pointers as a starter: https://medium.com/nyc-planning-digital/writing-a-proper-github-issue-97427d62a20f


BasemapGallery.AvailableBasemaps items not displaying after object instantiation

There is a lag in displaying BasemapGallery.AvailableBasemaps after setting it to a List<Basemap> or ObservableCollection<Basemap>. The gallery will keep displaying old basemaps. BasemapGallery.AvailableBasemaps will update just fine, as verified by comparing the old count to the new count - the issue is displaying the basemaps in the gallery immediately after. It requires setting BasemapGallery.AvailableBasemaps to two objects (List or ObservableCollection) before the UI is up to date. Simply waiting patiently for the gallery to update will not work.
The issue persists in these two cases:

instantiating the object to a var galleryItems, then setting AvailableBasemaps to galleryItems
directly setting AvailableBasemaps to a new object.

The gallery will update as expected if calling:
BasemapGallery.AvailableBasemaps.Clear(); BasemapGallery.AvailableBasemaps.Add();
See the reproducer:
testgeonet.zip

I noticed that, in MAUI, you may set the AvailableBasemap property correctly, but the default gallery loading task takes some time to perform, so that in the end the new (default) gallery completely overwrites the old (custom) one. I think a check on whether a value is already given or not should be performed before loading default basemaps (also to eventually improve performances).

@dturrina This issue has been fixed and merged (see #492)! Now when applying the template, the ListView uses the controller as the source and a path of available basemaps.


Build problem for Tag v1.28.0.  Checksum of quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz was changed

Description:
While trying to build Envoy from v1.28.0 build fails with error:
WARNING: Download from https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
     Loading:
     ERROR: An error occurred during the fetch of repository 'com_googlesource_googleurl':
        Traceback (most recent call last):
     	File "/root/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
     		download_info = ctx.download_and_extract(
     Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /root/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/com_googlesource_googleurl/temp13642137462680158237/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
     Loading:
     ERROR: /workspace/WORKSPACE:24:19: fetching http_archive rule //external:com_googlesource_googleurl: Traceback (most recent call last):
     	File "/root/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/repo/http.bzl", line 132, column 45, in _http_archive_impl
     		download_info = ctx.download_and_extract(
     Error in download_and_extract: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /root/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/com_googlesource_googleurl/temp13642137462680158237/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51
     Loading:
     ERROR: @com_googlesource_googleurl//build_config:system_icu :: Error loading option @com_googlesource_googleurl//build_config:system_icu: java.io.IOException: Error downloading [https://storage.googleapis.com/quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz] to /root/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/com_googlesource_googleurl/temp13642137462680158237/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz: Checksum was fc694942e8a7491dcc1dde1bddf48a31370a1f46fef862bc17acf07c34dc6325 but wanted 59f14d4fb373083b9dc8d389f16bbb817b5f936d1d436aa67e16eb6936028a51

Repro steps:

Checkout to v1.28.0
Run bazel build

Latest commit: b5ca88acee3453c9459474b8f22215796eff4dde

It's the same with all tags though. Branches were fixed because of https://github.com/envoyproxy/envoy/commit/2ed8986f72dcdfabd9e48df67b3b73ac5914d753. But it makes envoy build n other idempotent. I do believe idempotency is the main goal of using Bazel. Do you have any insight why quiche-envoy-integration was changed? Do we have any workaround for it?

hi @svagner this was due to an upstream dependency change that has now been fixed on all branches
the latest commit for the release/v1.28 branch is 2ed8986f72dcdfabd9e48df67b3b73ac5914d753
1.28.0 is a release tag and will never change
there was another dep change last week that was not backported to 1.28 on the basis that it goes EOL in the next couple of days
if you want to raise a PR to backport that fix im happy to land it - mainline fix is here https://github.com/envoyproxy/envoy/commit/06ea5be1a0919908948dfb04a9262e1ba7bf922c

Hi @phlax , Is there a plan to make a 1.31 release with this change. We are pulling the 1.31.2 and it is failing.

Hi!
Same here, but with v1.28.7, any plan to do release for another 1.28.x with this fix in? in the project we use envoy we cannot afford at this moment uplift to a different major version and we always prefer use released versions and not specific commits.
Thank you!

hi @sokaran unfortunately 1.28 is about to go EOL so we are unlikely to cut another release for that branch
i will be cycling a set of patch releases with these fixes for the other supported branches (1.29-31) either this week or next tho - so you will have the option of updating to a supported release branch - or if you want to stay on 1.28 for some reason then using the latest commit on the rlelease/v1.28 branch

Hi @phlax , Is there a plan to make a 1.31 release with this change. We are pulling the 1.31.2 and it is failing.

I think release branch 1.31 has already included these two changes #36515 and #36540. Just 1.31.3 has not been released yet. You may use the last commit of release branch 1.31 to build envoy or wait for 1.31.3

all of the branches 1.28-1.31 have the fix

@phlax
We are using 1.25.4 envoy version, is it safe to fix this issue with this commit ？

its probably safe with a couple of caveats
firstly 1.25 has been EOL for some time - so its your responsibility to pick any security patches from later versions that might effect your build, and relatedly we cant guarantee that no others are needed
picking the googleurl hash fix should be safe in itself assuming its the same version (i think it is)


@eessex => Stop redirect to MG on articles

This can be merged after we handle the signup modals which we'll get results for tomorrow! Just wanted to get this ready and mergeable.

Gonna merge this one 😈


Bump prometheus and thanos versions

Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
This is bumping thanos version to 0.24.0 (closing #1038) and also bumps prometheus to 2.31 (I couldn't make 2.32 work :shrug: ). The change is also modifying imports of prometheus packages due to changes in repository layout (https://github.com/prometheus/prometheus/pull/9478).
Purely internal change with nothing to communicate in changelog.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR:

[ ] CHANGELOG entry for user-facing changes
[ ] Updated the relevant documentation

Lots of CI errors, will review once resolved

I missed that upstream prometheus wrapped unit64 type as storage.SeriesRef and this affected some of our code, hence CI issues. This is fixed now and PR is ready for review.


Typography classes: Auto-generating or not?

I don't see how we can easily get a 1-1 with Figma and css if we don't autogenerate this.
If we autogenerate classes based on settings that come from Figma, we make sure these are always in sync, and makes it easy for consumers to use typography classes wherever they want to.
Another plus is that we can expose a script that also does this for our consumers, should they want to change anything about typography

This was solved in #2429


Does this image depend on the host os version (libc, X11 version, ...)?

I like the basic idea of this image and use it successfully on several Ubuntu machines.
However I could only get it to work with the same Ubuntu version. The reason may be
that I am using the graphics drivers ppa for the proprietary NVidia drivers, and not the
official driver download.
My question: is it supported to run a different Ubuntu version in the docker container
than in the host OS, as long as the NVidia driver is the exact same version? Or are
there other dependencies, like same libc version, same libstdc++ version, same X11
version, ...?

I have successfully used Debian host with Ubuntu image for example. I would not expect that different versions of Ubuntu would have issues.
It would be interesting to know if using the official NVidia driver on your host addresses the issue.

Ok I will test this with the official NVidia driver and report back. Thanks!

I guess this can be closed now.


Ensure things work on windows.

When running experiments I got this warning from git-lfs
Encountered 1 file that may not have been copied correctly on Windows:
	pytorch_model.bin

See: `git lfs help smudge` for more details.

I assume that because we are using git-lfs-smudge under the hood we are also seeing this warning but it is not being surfaced. Check if it is and if it is we should propagate it to the user.

We think this particular error is just a hold out from FAT32's 4Gb files limit, it should not effect modern window's users.

I tried adding windows-latest to our unittest action. It timed out trying to install dependencies. It looked like pip was stuck backtracking through some dependencies. This might mean windows usage would be hard to setup.

For basic windows test support we probably need batch script versions of some of the bash based end2end tests, unless we leverage the linux sub-system for windows somehow?

I think we can specify windows to use bash, see https://github.com/r-three/git-theta/pull/188#discussion_r1157378347


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#468 7778127 Thanks @jevakallio! - Allow passing a function to YPartyKitProvider options.params

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix Toolbar layout on iOS 10

Task/Issue URL: https://app.asana.com/0/856498667320406/1167759866468833
Tech Design URL:
CC:
Description:
Fix Toolbar buttons on devices with iOS 10.
Steps to test this PR:

Run on a device with iOS 10, all Toolbar buttons should be visible and working.
Rotate to landscape, after Toolbar height changes, buttons should be relayout.
Make sure iOS 11+ is not be affected.

Internal references:
Software Engineering Expectations
Technical Design Template

No problem!


Added support for google analytics

Task link : https://trello.com/c/XFl0wTdk/21-add-google-analytics-to-the-web-page

This PR requires addition of an environment variable which will be completed as a part of task - https://trello.com/c/PtXUsrcI/28-add-react-env-vars-in-aws-run-scripts

 Add Google Analytics to the web page


Build failure: haskellPackages.unordered-containers checks are freezing

Steps To Reproduce
No idea how to track it down yet because it doesn't happen with nix build .#pkgsi686Linux.haskellPackages.unordered-containers or nix build .#haskellPackages.unordered-containers
Possible to reproduce by cloning https://github.com/surfaceflinger/flake, reverting 7e302a5031895b779f0e813d736142ba15402730 and running nixos-rebuild build --flake .#blahaj
Build log
unordered-containers> [10 of 10] Linking dist/build/unordered-containers-tests/unordered-containers-tests
unordered-containers> Running phase: checkPhase
unordered-containers> Running 1 test suites...
unordered-containers> Test suite unordered-containers-tests: RUNNING...
unordered-containers> All
unordered-containers>   Properties
unordered-containers>     Data.HashMap.Lazy
unordered-containers>       instances
unordered-containers>         Eq
unordered-containers>           ==:                              OK
unordered-containers>             +++ OK, passed 100 tests.

Additional context
https://github.com/haskell-unordered-containers/unordered-containers/issues/491
Someone else also spotted it in https://discourse.nixos.org/t/help-using-overlays-with-flake-parts/54321
Maybe the package could get rolled back to an older version or if it works fine after building, just turn off checks for now?
Notify maintainers
idk for now
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.11.2, NixOS, 24.11 (Vicuna), 24.11.20241009.65d98cb`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Lix, like Nix) 2.91.0
System type: x86_64-linux
Additional system types: i686-linux, x86_64-v1-linux, x86_64-v2-linux, x86_64-v3-linux
Features: gc, signed-caches
System configuration file: /etc/nix/nix.conf
User configuration files: /home/nat/.config/nix/nix.conf:/etc/xdg/nix/nix.conf:/home/nat/.nix-profile/etc/xdg/nix/nix.conf:/nix/profile/etc/xdg/nix/nix.conf:/home/nat/.local/state/nix/profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/nat/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf:/nix/store/0nrvyvki12xmq6ccidgrin0k0c9hf136-gnome-settings-daemon-46.0/etc/xdg/nix/nix.conf
Store directory: /nix/store
State directory: /nix/var/nix
Data directory: /nix/store/cfl6rqw64ndbh2m0qapg410jf4xmycia-lix-2.91.0/share`
 - nixpkgs: `/nix/store/y4rmd9g036gmgz5xjiplw1zcbi16fqdr-source`

Add a :+1: reaction to issues you find important.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/help-using-overlays-with-flake-parts/54321/4

This was also happening on my system, could build the package fine but when the checks came it would freeze at the same step.

Can confirm that #349081 helped, but ig this package is still problematic for now and might break something again until the upstream issue is fixed or is somehow worked around in nixpkgs

Can confirm, unordered-container tests did hang for me at:
Test suite unordered-containers-tests: RUNNING...
All
  Properties
    Data.HashMap.Lazy
      instances
        Eq

Disabling obs-vkcapture in home-manager did the trick. Thanks!

I've had this issue for a while due to wanting to run the i686 version of etlegacy, which mysteriously pulls in haskell/unordered-containers.
I was using an overlay with doCheck = false but that's no longer working, as now the entirety of haskell seems to require compilation, and the hackage-security tests are failing on my system.

I tried to patch the overflow mention in the upstream issue and got the tests passing with that on 64bit but adding the patch to nix and building it 32bit did not a lot still hangs.
Full disclaimer im not a haskell program nor do i fully understand how the haskell stuff is packaged in nix.
From 4612dc3147b6f2da3fa76927b04acf78f02f811f Mon Sep 17 00:00:00 2001
From: fliiiix<EMAIL_ADDRESS>Date: Wed, 30 Oct 2024 09:08:08 +0100
Subject: [PATCH] wip: fix haskel

---
 .../haskell-modules/configuration-common.nix        |  2 ++
 .../haskell-modules/hackage-packages.nix            |  2 ++
 .../patches/unordered-containers-overflow.patch     | 13 +++++++++++++
 3 files changed, 17 insertions(+)
 create mode 100644 pkgs/development/haskell-modules/patches/unordered-containers-overflow.patch

diff --git a/pkgs/development/haskell-modules/configuration-common.nix b/pkgs/development/haskell-modules/configuration-common.nix
index ac803a879211..b267faaf31f3 100644
--- a/pkgs/development/haskell-modules/configuration-common.nix
+++ b/pkgs/development/haskell-modules/configuration-common.nix
@@ -1382,6 +1382,8 @@ self: super: {
   # Fix build with attr-2.4.48 (see #53716)
   xattr = appendPatch ./patches/xattr-fix-build.patch super.xattr;

+  unordered-containers = appendPatch ./patches/unordered-containers-overflow.patch super.unordered-containers;
+
   esqueleto =
     overrideCabal
       (drv: {
diff --git a/pkgs/development/haskell-modules/hackage-packages.nix b/pkgs/development/haskell-modules/hackage-packages.nix
index 8439316bbc99..77eb7ba2ccd3 100644
--- a/pkgs/development/haskell-modules/hackage-packages.nix
+++ b/pkgs/development/haskell-modules/hackage-packages.nix
@@ -322110,6 +322110,8 @@ self: {
        ];
        description = "Efficient hashing-based container types";
        license = lib.licenses.bsd3;
+       #TODO
+       #doCheck = false;
      }) {};

   "unordered-containers-rematch" = callPackage
diff --git a/pkgs/development/haskell-modules/patches/unordered-containers-overflow.patch b/pkgs/development/haskell-modules/patches/unordered-containers-overflow.patch
new file mode 100644
index<PHONE_NUMBER>00..fbc43eb40469
--- /dev/null
+++ b/pkgs/development/haskell-modules/patches/unordered-containers-overflow.patch
@@ -0,0 +1,13 @@
+Index: unordered-containers/tests/Util/Key.hs
+===================================================================
+--- unordered-containers.orig/tests/Util/Key.hs
++++ unordered-containers/tests/Util/Key.hs
+@@ -56,7 +56,7 @@ moreCollisions :: Int -> Int
+ moreCollisions w = fromIntegral (w .&. mask)
+
+ mask :: Int
+-mask = sum [bit n | n <- [0, 3, 8, 14, 61]]
++mask = sum [bit n | n <- [0, 3, 8, 14, 31]]
+
+ keyToInt :: Key -> Int
+ keyToInt (K h x) = h * fromEnum x
--
2.34.1

Currently seeing this issue on both unstable and unstable-small channels, seems to be coming from haskellPackages.ShellCheck, which is littered all over my system flake. I haven't been able to update for a few weeks now, going to try out overriding unordered-containers in an overlay and see if that fixes it for now. Will update back here later.

I am encountering this issue as I try to build an installer image for a 32bit system.
I do not have obs-vkcapture installed. My environment is running in an LXC container (it's a build grunt) so I'm wondering if it's something in the kernel that causes the issue.
Here is the output of nix-shell -p nix-info --run "nix-info -m".
 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.12-4-pve, NixOS, 24.05 (Uakari), 24.05.6668.e8c38b73aeb2`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.8`
 - channels(root): `"nixos-24.05"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Update: after figuring out that another host built with the same flake was not having any issues, I was able to narrow down my issue to v4l-utils, which I had included as an extra lib for a couple of programs (Lutris and Bottles). Removing that lib has allowed me to build my system properly again.

I do not have v4l-utils installed, however I do find it interesting that now two of the packages discovered to cause this problem have something to do with video capture. I am wondering if there is a common dependency between those two (I could see obs depending on v4l in general) causing the issue. Searching through the dependency tree manually, I didn't find v4l-utils in obs-vkcapture's dependencies, but my search wasn't exhaustive.
v4l-utils has a dependency on libjpeg, which I did find on my system. I didn't find any of v4l-utils' other dependencies on my system.

#359690 got merged and should be available in unstable soon https://nixpk.gs/pr-tracker.html?pr=359690
@sternenseemann maybe it should also get backported to 24.11?


fix log level setting

log level does not set correctly when not capitalised, + no support for int based log levels


start-date highlight.

Hello,
When i provide a start date shouldn't the calendar highlight the selected dates /times?
(not sure if its just not working or if it just doesn't do this)
Thanks ( am using inline)

Never mind.. I think its because i give the time as now so the minutes dont match the intervals. Date and hours highlighting works fine.

The inline option is really neat BTW.. I didnt want to use any other library because they didnt match the angular material inputs that i use else where but being inline gets rid of that. Thumbs up to an awesome library. Thanks

How did you solve this? Even official demo can't initialize date using this directive https://embed.plnkr.co/rjFk9d


Builder broken - Undefined array key "type"

Package
filament/filament
Package Version
v3.0.7
Laravel Version
v10.17.1
Livewire Version
No response
PHP Version
PHP 8.2
Problem description
Simple Builder setup causes error Undefined array key "type" when saving/deleting.
Error: https://flareapp.io/share/87ne66yP
Expected behavior
Adding and removing blocks without error.
Steps to reproduce

Add to resource form:

Forms\Components\Builder::make('builder')
                    ->blocks([
                        Forms\Components\Builder\Block::make('block')
                            ->schema([
                                Forms\Components\Toggle::make('enabled'),
                                Forms\Components\TextInput::make('title'),
                            ]),
                    ])

Add Block
Remove Block
Add Block
Remove Block --> Error Undefined array key "type"

Reproduction repository
https://github.com/martin-ro/f3
Relevant log output
https://flareapp.io/share/87ne66yP

I'm also running into the same issue. I've been pulling my hair out silently trying to determine if the issue is on my end! I'll see if I can reproduce with your provided repository.

I'm digging into this a bit and I suspect it could be a bug in Livewire. Here's a breakdown of the update requests that happen in the Network tab of my dev tools when I'm following the steps described in the issue description:

yes, I saw exactly the same thing.

Just to let you know we are looking into this. I believe that #7421, #7450, #7475 and #7485 (and other duplicate issues) are all the same bug, related to Livewire's entangle feature.

livewire/livewire#6289

Still not worked on liveware 3.0.0-beta10

I believe livewire/livewire#6521 is a failing test for this

I'm getting this error from just creating the example at https://filamentphp.com/docs/3.x/forms/fields/builder
any suggested workaround?

Upgrade Livewire and Filament

I'm still experiencing this bug on v3.1.14

Also encountering this on with Filament v3.1.14 and livewire v3.2.6.

Should be fixed in the next release. 5e58bea68018a02a904d9377a3a3baa0b08956a8

Is there a fix/workaround for this in filament v2.0? I'm running the newest version.

Feel free to submit a PR and I will merge/release it.


Ruby 3 compatibility specs

Hi dear maintainers 👋 ✌
Thank you for your work on this gem 🙇
As technically gem is already compatible with Ruby 3, this PR just brings a bit of confidence on its compatibility.
Also it improves the development experience for those who use Ruby >= 3.0 by:

Bumping rspec version to Ruby 3 compatible one (includes https://github.com/rspec/rspec-mocks/pull/1407 )
Increasing spec coverage by returning a nice & working assertion that was removed in https://github.com/jetruby/apollo_upload_server-ruby/commit/6c61ada01cd7904de733738b7409918f626372db (probably because of the same issue https://github.com/rspec/rspec-mocks/issues/1396 as ☝ )
Replacing travis-ci config (which seem not to be used anymore) with GH actions (🎉 It runs specs using Ruby 3 too 🎉)

Just in case, here you can find the GH actions logs

Looks good! Thank you!


Vagrant fails when removing from chef server

I can successfully run vagrant up and vagrant provision on a machine with no issue.  However when I run vagrant down I get the following error:
==> default: Terminating the instance...
==> default: Running cleanup tasks for 'chef_client' provisioner...
==> default: Deleting node "test-www1" from Chef server...
The provider for this Vagrant-managed machine is reporting that it
is not yet ready for SSH. Depending on your provider this can carry
different meanings. Make sure your machine is created and running and
try again. Additionally, check the output of `vagrant status` to verify
that the machine is in the state that you expect. If you continue to
get this error message, please view the documentation for the provider
you're using.

Note that I am provisioning this via amazon AWS.  The aws instance is destroyed as expected, however it is not removed from the chef server.
Here is my Vagrantfile:
# -*- mode: ruby -*-
# vi: set ft=ruby :

hostname = "test-www1"

Vagrant.configure(2) do |config|

  config.vm.box = "dummy"
  config.vm.box_url = "https://github.com/mitchellh/vagrant-aws/raw/master/dummy.box"

  config.vm.provider :aws do |aws, override|
    aws.access_key_id = ENV['AWS_ACCESS_KEY']
    aws.secret_access_key = ENV['AWS_SECRET_KEY']
    aws.region = "us-west-2"
    aws.monitoring = true
    aws.keypair_name = "my_keypair"
    aws.ami = "ami-47465826"

     # Tag each instance with developer name.
    aws.tags = {
      'Name' => hostname
    }

    override.ssh.username = "ubuntu"
    override.ssh.private_key_path = "~/.ssh/sfmoma-aws.pem"
  end

  # Provision Chef Server
  config.vm.provision "chef_client" do |chef|
    #chef.log_level = :debug
    chef.chef_server_url = "https://path-to-chef-server"
    chef.validation_key_path = "/usr/lib/ssl/certs/sfmoma-validator.pem"
    chef.validation_client_name = "sfmoma-validator"

    chef.node_name = hostname
    chef.delete_node = true
    chef.delete_client = true

    chef.environment = "sfmoma-web"
    chef.add_role "sfmoma_web_general"
    chef.add_recipe "sfmoma_web::www"
  end
end

This is probably happening because the aws provider runs provisioner cleanup after the instance has been terminated (at least, as of v0.7.0):
https://github.com/mitchellh/vagrant-aws/blob/v0.7.0/lib/vagrant-aws/action.rb#L56
If the chef cleanup routine is trying to read state from the agent, then it's out of luck because everything is gone at this point.
In contrast, core vagrant switched to running cleanup actions for VirtualBox et. al. before termination in v1.8.0:
https://github.com/mitchellh/vagrant/blob/master/CHANGELOG.md#180-december-21-2015
This also appears to be when the Chef provisioner was changed to read state from the agent.

Looks like PR #452 may address this.


[Bug]: media files are not updated when exporting

What happened?
in obsidian I have image and video files in a media folder inside the vault. When I export (with only modified files selected as option) a document with images these imagea are not placed in the media folder in the exported material.
Also it seems the relevant content in the bin folder is not updated, as only the last document appears in the left column.
Search only works within the last exported document.
Reproduction
export mode: online server.
I already have exported a number of documents so there already exists several html documents, a media folder and the lib folder. When I export another document I discover that the image files are missing when testing the html file in a browser. Also I am not able to access the other documents, as only the latest exported document appears in the left column.
Workaround is to delete the media and bin folder before export, but this is very cumbersome when just doing incremental exports.
Last Working Version
this is the first version I use
Version
1.8.01
Operating System
macOS
Obsidian Version
1.5.12
Which browsers can you reproduce this in?
Firefox
Relevant log output
Log:
[WARNING] 	No existing export metadata found. All files will be exported.
[WARNING] 	No existing search index found. All files will be exported.
[WARNING] 	No existing RSS feed found. All files will be exported.
[INFO] 	Closing render window
[INFO] 	Closing render window
[INFO] 	Closing render window
[INFO] 	Closing render window
[INFO] 	Closing render window

Settings:
	settingsVersion --------- 1.8.01
	makeOfflineCompatible     false
	inlineAssets ------------ false
	includePluginCSS          1 plugins included
	includeSvelteCSS -------- true
	titleProperty             title
	customHeadContentPath ---
	faviconPath
	documentWidth ----------- 40em
	sidebarWidth              20em
	minOutlineCollapse ------ 2
	startOutlineCollapsed     false
	allowFoldingHeadings ---- true
	allowFoldingLists         true
	allowResizingSidebars --- true
	logLevel                  warning
	minifyHTML -------------- true
	makeNamesWebStyle         true
	onlyExportModified ------ true
	deleteOldFiles            false
	addThemeToggle ---------- true
	addOutline                true
	addFileNav -------------- true
	addSearchBar              true
	addGraphView ------------ true
	addTitle                  true
	addRSSFeed -------------- true
	siteURL                   http://localhost:3000/
	authorName --------------
	vaultTitle                testvault
	exportPreset ------------ website
	openAfterExport           false
	graphAttractionForce ---- 1
	graphLinkLength           10
	graphRepulsionForce ----- 150
	graphCentralForce         3
	graphEdgePruning -------- 100
	graphMinNodeSize          3
	graphMaxNodeSize -------- 7
	showDefaultTreeIcons      false
	emojiStyle -------------- Native
	defaultFileIcon           lucide//file
	defaultFolderIcon ------- lucide//folder
	defaultMediaIcon          lucide//file-image
	exportPath -------------- /Users/hcg/lab/localserver
	filesToExport             1

Enabled Plugins:
	Webpage HTML Export
	Templater
	Dataview
	Update modified date

Additional Info

This is the structure of my folder:  html files + media folder and bin folder. Media folder is not being updated when exporting

this is the structure of my vault

How are you selecting files to export? You should always have all the files you wish to have in your export selected in the left hand file selector. That selector should always represent every file you want to exist in the exported vault, not just new files! It will figure out which ones need to be updated for you.

I did it wrong first by only selecting the new file, but then I did it again with everything selected (except the templates folder) but still the media folder is not updated with new content

Can you first delete everything that was ahead exported (especially the lib folder) and try again?

I did this now, but get the same result.
The new html file is showing up, but it is missing the image.

Hmmm, so, you could try the beta version.  It's likely that you're not doing anything wrong and it's just a bug.

This is what it looks like in obsidian before export

ok, will try to install the beta later today

I am happy to say that with the beta version it works as it should, the media content is included when exporting


How to write a custom Method Regex validation

Hi sorry if I am being obviously stupid, can you point in the direction of how to write a custom Regex validation? example validation should contain Alphanumeric and special characters.

+1
I really want to be able to do something like this.
_id: "required|regex:'^[0-9a-fA-F]{24}$'"

Will add support for custom regex

Added as of v1.2.7

Make sure to use it without quotes.
Use it this way
_id: "required|regex:^[0-9a-fA-F]{24}$"

Thank you, much appreciated!

Wow great thanks


Rotate Image (Leetcode #48 Medium)

You are given an n x n 2D matrix representing an image, rotate the image by 90 degrees (clockwise).
You have to rotate the image in place, which means you have to modify the input 2D matrix directly. DO NOT allocate another 2D matrix and do the rotation.
Example 1:
Input: matrix = [[1,2,3],[4,5,6],[7,8,9]]
Output: [[7,4,1],[8,5,2],[9,6,3]]

Please assign this is issue to me, I want to solve it as a part of hacktoberfest-2021


property name version breaks api

It took me forever to figure out that naming a entity's property version completely destroys the implementation because the findEntity method of ProjectResource uses $routeParams to determine additional criterias. Because apigility sends the api version through routeParams apigility-doctrine automatically adds this property as a criteria :-( causing No result was found for query although at least one row was expected. errors.
https://github.com/zfcampus/zf-apigility-doctrine/blob/master/src/Server/Resource/DoctrineResource.php#L718

Sorry for your frustration.  Will you post an example route?
Apigility promotes Media Type versioning: https://apigility.org/documentation/api-primer/versioning
So I'm suspicious that the version is a route parameter in a Media Type implementation.

Ja at least its an easy workaround by renaming the property.
I'm using a standard generated route:
     'api.rest.doctrine.project' => array(
                'type' => 'Segment',
                'options' => array(
                    'route' => '/project[/:project_id]',
                    'defaults' => array(
                        'controller' => 'api\\V1\\Rest\\Project\\Controller',
                    ),
                ),
            ),

Allowing for versioned media types of course :-)
    'accept-whitelist' => array(
            'api\\V1\\Rest\\Project\\Controller' => array(
                0 => 'application/vnd.api.v1+json',
                1 => 'application/hal+json',
                2 => 'application/json',
            ),
     ),

Beats me why they would need to inject version into the params.

Does this help?
https://github.com/zfcampus/zf-versioning/blob/master/src/VersionListener.php#L76
There's a preferred name of zf_ver_version there which is coming from the routeParams.  It may be where the route Params are assembled that is to blame.

I wonder if we change this https://github.com/zfcampus/zf-versioning/blob/master/src/PrototypeRouteListener.php#L34 to 'zf_ver_version' would it fix it?
Is your app in a position to test this idea, @jensstalder ?

Oh ok? So setting a version parameter is still supported if no version is specified in Accept. Didn't know that.
Does seam like if zf_ver_version takes precedence it should be defaulted instead of version. I'l give it a shot.

Nä, I changed it, but apparently its being set somewhere else.
Odd even explicitly setting Accept to application/vnd.api.v1+json still sets the version param anyways even though it should then be retrieved through zf_ver_version instead.
But thanks for the help, I will just rename the prop. Just wanted a heads-up for people that could run into this in the future.

Or one could simple extend over ProjectResource->findEntity and set the criterias explicitly.

I strongly recommend you don't add code to the extended resources, ever.  Anything you need to do should be handled outside the resource.
I think you've found a bug in the versioning of zfcampus.  If you don't want to track it down I'll take it and put in a patch.

@jensstalder try setting all 'version' to 'zf_ver_version' in https://github.com/zfcampus/zf-versioning/blob/master/src/PrototypeRouteListener.php
That carried through for me and worked on my single version API.

Yup!!! that acually works. I forgot to change $this->versionRouteOptions['defaults']['version'] last time.


feat: add a news article about the Baby Bliss Bot project

@agamba, could you review this news article. Pinging you here as your github id is not showing up in the reviewers list.

@klown thanks for the comment. It has been addressed and ready for another look.

Thanks for comments, @agamba. I've addressed them all and pushed to the main branch.


feat: Allow specifying additional labels to be applied to all helm chart resources

Why is this PR required? What issue does it fix?:
There is currently no way to specify additional labels to be applied to the resources in the chart - only the pod itself, not even the deployment that creates those pods.
What this PR does?:
Adds a top-level labels map within the values file. If it is populated, these labels will be added to the storageclass directly, and also to the 'localpv.labels' variable, which is already included within every resource besides the storageclass.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
I rendered the yaml with helm template ./deploy/helm/charts with both an empty and populated labels map, and validated that labels were created in the approprate places.
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Fixes #
[ ] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>.
Where:
Most common types are:
* feat        - for new features, not a new feature for build script
* fix         - for bug fixes or improvements, not a fix for build script
* chore       - changes not related to production code
* docs        - changes related to documentation
* style       - formatting, missing semi colons, linting fix etc; no significant production code changes
* test        - adding missing tests, refactoring tests; no production code change
* refactor    - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes
* cherry-pick - if PR is merged in master branch and raised to release branch(like v0.4.x)
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Is this something that you would consider?

We shall take a look. Thanks for this.

Sounds good, thank you for the review/approval/promise of future merging!

@laverya -- I've taken up your change in #194. It'll be included in v4.1.0. I've made some minor changes to support upgrades with --reuse-values. You should be still able to label all of the chart resources though. Closing this PR.

Thank you, and have a happy Fourth of July!

Thank you, and have a happy Fourth of July!

Thank you, and wish you the same :)


Documenting response received on accessing API endpoints

The documentation here, http://django-rest-auth.readthedocs.io/en/latest/api_endpoints.html
only shows what input parameters each API endpoint accepts.
However, the response of these endpoints is not documented and the user is expected to access the endpoints and explore. It would be really helpful to document the response received when these API endpoints are used.

Can you show example of response. And you plans about using that doc? How it can be useful for you?

Most auth endpoints only return status messages. I added the response values for the endpoints that return more data https://github.com/Tivix/django-rest-auth/issues/280. Also, there's additional information in docstrings https://github.com/Tivix/django-rest-auth/blob/master/rest_auth/views.py.


Fix phpdoc typo

This PHP Doc typo break some analysis tools(scrutinizer PHP Analyzer).

Thanks for the PR, but I'm going to close this since this repo has been EOL for a while now.


Reformat into ES6 and a more standard style

I generally just modernized the code by taking advantage of the fact that node uses ES6. This allowed to make the code more functional and on the whole easier to read. No breaking changes or any significant changes in functionality.

Closing, since this PR has unadressed requested changes and desperately needs a rebase


Removes permission for TIO to be able to update MTOServiceItem status.

Summary
During a user exercise we had a TIO make a change to an MTOServiceItem status. The feedback we got was that they shouldn't be able to do that, so this removes the update.MTOServiceItem permission from the TIO role.
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the Storybook locally.
make storybook

Terminal 2
Start the UI locally.
make client_run

Terminal 3
Start the Go server locally.
make server_run

Additional steps

Access the
Login as a

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

Screenshots

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against b27b03a6e73c7ddaa42a90e5c22e493925ae94bf

@Ryan-Koch LGTM. Functionally this works as expected. I am not seeing the accept or reject options after this change.
As someone who hasn't really looked or touched the permissions code, I am a bit confused as to why we don't need to have a permission on the endpoint that is actually being called to update the service item status. Is there a quick explanation that would explain this?
I spent a few minutes looking at the above, would this fix just not show the options on the UI but still theoretically allow them to hit the API to update the status?

We make use of these tags at the end point level in swagger. In this case we have this x-permissions tag under the end point for updating MTO service item status:
      x-permissions:
        - update.MTOServiceItem

So it should make it non-visible in the UI and ensure they can't hit the end point as well.

We make use of these tags at the end point level in swagger. In this case we have this x-permissions tag under the end point for updating MTO service item status:
      x-permissions:
        - update.MTOServiceItem

Aren't there two different end-points here? /move-task-orders/{moveTaskOrderID}/service-items/{mtoServiceItemID}/ and  /move-task-orders/{moveTaskOrderID}/service-items/{mtoServiceItemID}/status. Afaict the status endpoint is being used for the update of the MTO service item status. And this permission exists on the generic /move-task-orders/{moveTaskOrderID}/service-items/{mtoServiceItemID}/ end point.
Or am I off the mark/misunderstanding things?

Oh you're right there. It looks like we missed adding this to the end status end point but attached it to the generic one (as you noted). I'll try fixing that and seeing if there's any issue afterward.

Fwiw, there might need to be some accompanying FE changes as well. Right now the FE, the approve/reject buttons rely on update.MTOServiceItem permissions.

Fwiw, there might need to be some accompanying FE changes as well. Right now on the FE the approve/reject buttons rely on update.MTOServiceItem permissions.

I wound up using the same permission (both things are about modifying MTOServiceItems), so I think we're good on the frontend.

LGTM! Is there a ticket associated with this? I assume there isn't since this was supposed to be a quick change.

There isn't, but I'm going to make one to document the change ASAP so we don't lose context for why the change happened.


UI - Merge experiments

Allow experiments to be merged. Keep both merged and original experiments around.

Added merge. Updated backend.


Generalize

It's about time to merge "generalize" into "main", in my opinion.

By the way, I'd suggest doing "Merge" instead of "Squash and merge", so we don't lose the history.


Support Service Bus topics names with hyphens

When creating a new function triggered by service bus topic, the validation on topic name field refuses hyphenated, which are actually valid for topic names.
From: https://feedback.azure.com/forums/355860/suggestions/17819737

fixed in #398


Fix Multitenancy docs

Purpose
This PR includes the multi-tenancy docs.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add NSMI v2 codes to topics table(s)

Add NSMI version 2 codes to the topics table or tables, associated with each level: Parent, Child 1, Child 2 and Child 3.

ON HOLD - Requirements Spike

On 5/1/2019, LSC decided to continue with NSMI v2 - https://nsmi.lsntap.org/browse-v2


Create: 441-Arranging-Coin.py

File(s) Modified: 441-Arranging-Coin.py
Language(s) Used: python
Submission URL: https://leetcode.com/submissions/detail/814999069/

Thanks for contributing!


Consider Elimination of autoDeclareContext

Currently, beans (queues, exhanges, bindings) are added to an internal application context.
Instead, we could add them to the main context and use the default Boot RabbitAdmin.
Note that since we wish to ignore declaration exceptions, we would have to set AbstractDeclarable.ignoreDeclarationExceptions to true since the default rabbit admin does not have it set by default.
https://github.com/spring-cloud/spring-cloud-stream-binder-rabbit/pull/41#discussion_r100457141

We can just perform setIgnoreDeclarationExceptions() on the injected RabbitAdmin.
Not sure that it may be a problem since we are in a "simple" one-function microservice...

Well, we don't know that for sure - we have no idea what the user might be doing in the app - that's why I added the flag on the Declarables themselves, for exactly this reason.


Support: Acceleration of rotation (angular acceleration)

see #99

This looks good, although you'll need to update Emitter to set the acceleration on each particle it creates.

@andrewstart  I've update it

Excellent!


TypeError: Cannot read properties of undefined (reading 'vector')

Describe the bug
Defining a new canvas sprite by copying another one that doesn't exist causes a editor crash.
Reproduction Steps
Load https://david-pfx.github.io/PuzzleScriptNext/src/editor.html
Load example game ABRACADABRA
change lines 68 so it is a copy of something that doesn't exist. E.g.
  5 canvas:
  copy: blah

What did you expect would happen?
dev-release behaves like stable. Red warning message saying "blah" does not exist.
OS & Browser version, desktop/mobile
MAC/Chrome (not relevant)
Screenshots, example projects, other relevant issues, etc.
This is a regression issue on dev-release only.

Thank you. Reproduced. Fixed.


:zap: Test(bench): Add lotsOfMemory benchmark

Description
Add test that accesses a lot of memory
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #949   👈

This stack of pull requests is managed by Graphite.


Integrate github actions

Connect to travis CI

shall do all parts from jenkins CI pipeline
represents a quick CI visible for community, Jenkins still necessary for own builds

Link images from travis builds to README.md in root folder

Done, see
https://github.com/Daimler/sechub/blob/develop/README.md which is linked to Java & Go CI


[REVIEW] Project Makes Math Easy

Project Link:
https://github.com/makesmatheasy/makesmatheasy
Hosted Link:
https://makesmatheasy.github.io/makesmatheasy
You can also join the Discord community here
Feel free to check out other cool repositories of the EddieHub Community here

Thanks for sharing :) The project is really cool few suggestions from my side

You can remove release and packages if not used
You can create a separate file for the feature list maybe coz the readme became a bit long
Maybe nest files under single project to make
You can remove project board tab and wiki tab if not using

@kaiwalyakoparkar
Thanks for suggestions, will surely look into it

Take a look at the lighthouse scores of the deployed website

think particlejs is draining a lot of performance
Nice use of labels in the project!
I suggest using conventional commit messages.
Otherwise I agree with @kaiwalyakoparkar s points.

Take a look at the lighthouse scores of the deployed website

think particlejs is draining a lot of performance
Nice use of labels in the project!
I suggest using conventional commit messages.
Otherwise I agree with @kaiwalyakoparkar s points.

Thanks for giving your valuable time to review this Project, Will surely look into it.

Thank you for sharing, we will review on a live stream soon 👍

Looks good

README is very long, maybe make some of them collapsable
Repo description to have 1 more sentence
create releases
hide wiki if not used
hide packages if not used


[Kotlin 1.4] Update to Kotlin 1.4

Description

This PR updates related dependencies to support Kotlin 1.4
Type of change
Check all that apply

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (a change which changes the current internal or external interface)
[ ] This change requires a documentation update

How Has This Been Tested?
In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation, if necessary
[x] My changes generate no new compiler warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Inspect the bytecode viewer, including reasoning why

We hurt the test coverage percentage a bit, but I think it is okay 💦 💦 💦

Let's merge this then? This would be the last major update for Fuel version 2 before moving to version 3


Remove internal module

Rationale
The guts of the internal module were moved elsewhere with platform PR #4015.  Now we remove it entirely.
Related Pull Requests

https://github.com/LabKey/gradlePlugin/pull/166
https://github.com/LabKey/server/pull/398
#4015

Changes

Remove references to BuildUtils.getInternalProjectPath

I haven't tried running this yet, but Container and ModuleLoader both seem to reference the internal module by name (search for "internal")

I haven't tried running this yet, but Container and ModuleLoader both seem to reference the internal module by name (search for "internal")

Yeah, tests are not happy at the moment, likely because of this. I'll investigate in a bit.


PR: Accept event if Shift+Tab is pressed in the CodeEditor keyPressEvent to avoid losing focus

Issue(s) Resolved
Fixes  #8056
Description of Changes
We need to accept the event in the keyPressEvent of the editor when the hardcoded Shift+Tab key sequence is pressed to unindent code, else the editor is loosing focus.
Developer Certificate of Origin Affirmation
By submitting this Pull Request or typing my name below, I affirm the
Developer Certificate of Origin
with respect to both the content of the contribution itself and this post,
and understand I am releasing it under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: Jean-Sébastien Gosselin

Hello @jnsebgosselin! Thanks for submitting the PR.

There are no PEP8 issues in the file spyder/plugins/editor/widgets/codeeditor.py !


Ability to create Slider without margins on both sides

Duplicate Check

[x] I have searched the opened issues and there are no duplicates

Describe the requested feature
it's just a small edit in Slider class to add new parameter that indicates how much margins/padding should be on all sides instead of that fixed pixel (idk how much is it).
i want to create a widget like this:

but as what you can see , all what i can do is this:

with that all padding/margins on top and both sides , i can't do it;
i have searched alot for plugins and other stuff.
i think it should add that ability for the ease of building layouts. thanks
Suggest a solution
No response
Screenshots
No response
Additional details
No response

Is you share button works ?

Is you share button works ?
I haven't set any events for the buttons yet.

Is you share button works ?

I haven't set any events for the buttons yet.

Try to use Stack and set Slider's absolute position.
Something like a:
Stack([
    ImageExample(),
    Slider(top=50),
    ContainerExample()
])

or
Column([
   ImageExample(),
   Stack([
        Slider(top=0),
        ContainerExample()
    ])
])


Search range

It would be nice if there was a way to set the address range of a search. Sometimes if you're searching for a super common number like the float 1 you'll never get to within 1000 results to actually see any addresses.

agreed. this kind of option is very important. especially if we're trying find widescreen hack codes.

Implemented in #61


RSDK-4335 - Default to dynamic proto generation

Major Changes
Flips default behavior of dynamic proto generation and offline proto generation.

@acmorrow note that I updated defaults for OFFLINE_PROTO_GENERATION in addition to USE_DYNAMIC_PROTOS. Both flags have been necessary for me to compile, so I erred on the side of simplifying the cmake invocation as much as possible. Happy to chat if you had a preference against default enabling offline proto generation.

@acmorrow note that I updated defaults for OFFLINE_PROTO_GENERATION in addition to USE_DYNAMIC_PROTOS. Both flags have been necessary for me to compile, so I erred on the side of simplifying the cmake invocation as much as possible. Happy to chat if you had a preference against default enabling offline proto generation.

That seems reasonable to me given that without OFFLINE=ON you are likely to fail due to the missing protobuf version binding. I somewhat hope that once that is sorted out that we can revert OFFLINE to default OFF. The problem with offline mode is that it makes you dependent on the local tooling which is of unknown sanity. Can you add a comment on the ticket for fixing the missing version binding that we should evaluate restoring OFFLINE=OFF as the default as part of that work?


Fine-grained security

Now that Docker supports --cap-add and --cap-drop, it would be good to know which security settings to use with dind in case you wanted to make a public-facing docker instance.
Dealing with CAP_NET_SYSADMIN is going to be tricky.

That's a good idea, but there is still a long way to go — specifically because of CAP_NET_SYSADMIN.
If someone wants to experiment and confirm which set of caps will allow dind to run properly, I'll be happy to update the documentation!


User name switches to unknown

Describe the bug
When there is a new manual incident created there is some issue in the user fetch. It gets converted to Unknown even after updating the user multiple times.
To Reproduce
Steps to reproduce the behavior:

Go to settings
Click on Project and add individual
Click on Incident and report a new incident filling up all the details with the same added individual
Post incident creation the user name in reporter/incident commander becomes unknown

Expected behavior
The username should remain the same as it was added into the individuals
Screenshots

Desktop (please complete the following information):

OS: IOS
Browser Chrome
Version 112.0.5615.137

Thanks for reporting this. Can you confirm that you do not have a contact plugin enabled?

Are you still encountering this issue on the latest release?


Node.js version quesition

Hello, the engine requires Node.js version 22 or higher. Is there a specific feature that needs this? The current default LTS version of Node.js is 20.

@ExpandOcean,
Thanks for the question.
As mentioned in the 0.14.0 release notes, the change to need Node v22 is for Promise.withResolvers. If you polyfill Promise.withResolvers you should be able to use a lower Node version.
I think it may be a good idea to add the polyfill in ZenFS since it is tribal and would save this headache. Especially since the engine field of the NPM package wouldn't need to be 22 then.
Just to show how easy the polyfill is:
Promise.withResolvers ??= function<T>(): PromiseWithResolvers<T> {
    let resolve, reject;
    const promise = new Promise((_resolve, _reject) => {
        resolve = _resolve;
        reject = _reject;
    });
    return { promise, resolve, reject };
}

The TS lib types from ESNext.Promise would also need to be included.


opw_kinematics::parameters for UR5 Universal Robot

Hi, I want to use this with UR5 Universal Robot, but I dont see parameter values for UR5 in the paper. Kindly please guide me.

Closing as due to the kinematics of UR robots this is impossible.


Picking broken for DistanceRepresentation

Bear with me (alex might be used to this by now)
I've a collection of items I'm showing as a DistanceRepresentation and trying to pick and I've found something odd when I whittle the DistanceRepresentation down to just a few items - specifically one of the bonds is not pickable
I have a structure with 9205 atoms and 2 bonds in the distance representation, these two bonds have the gids' 9206 and 9207. The gid pool has a range of [1, 17000+]
By adding some console.logs, I see when I ask getByGid for 9207 it returns a BondProxy, when I ask for 9206 it returns an AtomProxy
The best i can figure out what's happening is:
It appears the code in https://github.com/arose/ngl/blob/95ad73498250c7394fa00f36c286fcd6e663ca22/src/utils/gid-pool.js#L184
first makes an offset var by subtracting the bottom gid range value (1) from 9206 to make 9205
It then does a less than or equal to comparison against the atom count (9205) to decide if it's an atom. Since 9205 <= 9205 is true it returns an AtomProxy.
I think it should just be a less to comparison (not an equal as well)?
And that would probably apply to the subsequent comparisons for the various bond types?
Sorry if this is a bit long-winded and doesn't have a test case but I'm still trying to get something together for you Alex :-)

Sadly picking is broken for DistanceRepresentation (just removed picking to avoid confusion, see 1aa939db4436a5274c43b37ff88c986b2e090b09).

Hi Alex, this isn't so much that picking is broken, but that getbygid will return an AtomProxy for the first bond in the gid list, whether it's in a distance representation or not.  I think the comparator in getbygid needs to be a "<" rather than a "<="

@martingraham you are right, sorry for not looking closely enough. It is hopefully fixed with e072310bf24ec5a826fd4c702581d262593d68fe. Also, added some tests.

@martingraham Is it good for you?

yes, that seems fixed as far as I can tell, thanks


[Screen Reader - Open and close New Tab]: Same name as "Close Tab" is defined for all the close button present at each tab.

User Experience:
Users who rely on screen reader would be impacted and not able to get on which tab close button focus is present as same name "Close Tab" is defined for all the tabs close button.
Test Environment:
OS: Win 10 2004 Build (20262.1010)
App: Windows Terminal
App version: 1.4.3243.0
Tool: Accessibility Insights for Windows
Repro Steps:

Open Windows terminal app.
Press "Ctrl+Shift+T" to open multiple tabs.
Now check the name defined for close button of each tab using accessibility insight tool.
Observe the issue.

Actual Result:
Same name as "Close Tab" is defined for all the close button present at each tab. So when screen reader focus navigates to any tab close button then narrator announces it as "Close tab button".
Expected Result:
Descriptive and unique name should be defined for each tab close button like "Close Tab 1".
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={248054a6-5e68-4771-9e1e-242fb5025730}&cid=e71aec14-4173-423e-aecb-2472bbc751e8
MAS4.1.2_Close tab button name should be descriptive.zip

Huh, can we even set the automation name of that button at runtime? IIRC it's defined in XAML. That one might actually be defined in the TabViewItem itself, I'm not sure we're customizing that at all. This might need to be filed upstream.

This is true of Chromium as well. Why should Terminal be any different?

Feature team disagrees. WinUI2 team disagrees.
The WinUI team thinks that this would be audible clutter. Because you can only get to the Close button using “Items” navigation, it will read the contents of the tab header (“Windows PowerShell”) before you get to “Close Tab”. Therefore, it would say “Windows powershell. Close Tab Windows Powershell”.
Hence, Closing the bug.


Makes mypy a seperate CI job

[x] Closes (https://github.com/zarr-developers/VirtualiZarr/issues/253)

Type checking is failing, but it's the same three.

Should we keep the python version matrix for mypy?
Installing all of the deps listed in test seems pretty overkill just for some typing library stubs. Is there a better alternative?

Should we keep the python version matrix for mypy?

Nah.

Installing all of the deps listed in test seems pretty overkill just for some typing library stubs. Is there a better alternative?

Is there any other way? I mean if that breaks surely our actual tests will also break?


Be able to translate the popup content with WPML

Hello,
thank you for this amazing plugin.
We use it in an international context (our translations are managed with the WPML plugin).
Unfortunately, we are not able to provide a different version for every language: the popin is always in English.
Could you make it compatible with WPML?
Kind regards

Hi @mattmary, thank you reaching out. The modal content technically supports being translated (https://github.com/kevinweber/wbounce/blob/master/frontend/class-frontend.php#L37) using the ´wbounce´ translation string (https://github.com/kevinweber/wbounce/blob/master/wbounce.php#L30). But maybe it doesn't really work – it's been a while since I worked on this – and it would certainly be nice to have a UI that makes adding translations easy. At this point though, I'm not available to develop new features. If someone from your team would like to make a contribution to this open source project, I'm happy to review and publish the improvement.
Best,
Kevin

Hi @kevinweber
Unfortunately, I was expecting so far a different approach than using a WordPress network approach (WPML is not configured like that).
I'll close this issue then, as I managed it through JavaScript variables.


mysql manual creation

Hey there, I need to generate the PermissionsEx mySQL structure manually. The feedback messages tell me to look for mysql.mysql but there is no mysql file there ready for me to import into my database.
I know mysql well and I just need to get the code inside the mysql file, if anyone has it so I can structure my database and tables it would be much appreciated.

Yes Thanks!

Excellent.  :dart:


KAFKA:4706 - Unify StreamsKafkaClient instances

KAFKA:4706 - Unify StreamsKafkaClient instances

@sharad-develop Can you please update the PR title to KAFKA-4706: Unify StreamsKafkaClient instances -- this allows the bot to link this PR to the JIRA automatically. Thx.

There is a bunch of streams test failures

AdminClient is already used by core (https://issues.apache.org/jira/browse/KAFKA-3265) - so not sure if the same name is a good choice.  This raised the question, if we (at some point) could get rid of StreamKafkaClient and use AdminClient only?
I like the KafkaClientSupplier idea, however, this will require a KIP.

@dguy I like your idea, and I think the name of AdminClient is fine: for example we can add another method named getAdmin in KafkaClientSupplier which can then be used in both KafkaStreams then passed into each of the thread's StreamsPartitionAssignor.

BTW I think we can also piggy-back this with KIP-117 which will introduce an admin client in common package that is can be generally used. Today we have different impls of such client in streams and connect, and that KIP is aimed to condense all these clients.

@guozhangwang Do you suggest to delay this PR until KIP-117 is done? This might take some time, as the KIP is not even voted yet.

That's a good point: let's not wait for KIP-117 then, and we can do the merge in a separate JIRA after that is done.

Sounds good to me. I did create a JIRA for this: https://issues.apache.org/jira/browse/KAFKA-4857
@sharad-develop Can you follow up with this PR and address the comments. Thanks.