Python 2 sunsetting in Jan 2020

Python 2 will officially sunset January 1st, 2020 according to the Python maintainers https://www.python.org/doc/sunset-python-2/
Since Aurora relies pretty heavily on Python to run tasks in critical spots, I think it would be quite dangerous to run with no further security patches.
At the same, I don't think we have the man power to move all our Py2 code to Py3. Any ideas on what our path forward should be?

@rdelval I'm familiar with pants and have moved some internal projects from python2 to 3 ... I can help with this effort, however you'd like to proceed.

That would be a fantastic and much welcome contribution. Even moving a few things here and there would be a big help!

We have looked into Python 3, a bit as we consume Aurora 's API from within Python.
Code wise there will not be too many hurdles. However there is a bit of pain with Thrift: Aurora's API require Sets in many places and this requires Thrift objects to be hashable in Python. Unfortunately Thrifts generated code by default comes without suitable hash methods for Python 3.
We have resorted to this nasty hack for now:
# With python 3 objects need a hash method to put them inside of sets. This was not the
# case in python 2. We monkeypatch a hash method on to the the thrift objects to make them
# compatible with python 3 code without having to make any changes to the thrift api
# itself.
def __hash__(self):
    return hash(self.__class__) ^ hash(1)

setattr(Resource, "__hash__", __hash__)
setattr(Metadata, "__hash__", __hash__)
setattr(Constraint, "__hash__", __hash__)

Thrift have a few options to change how code is generated. This might be something worth exploring. Another potential option could be to migrate to https://pypi.org/project/thriftpy2/

Thanks Stephan! That's a lot of really great information.
So it sounds like we need to weigh our options between helping the Apache Thrift project fix this issue or switching to thriftpy2
Do we have any idea what it would take to switch to thriftpy2? I will try reaching out to the Thrift devs and see if they're open to working with us on fixing this bug.

Hey @StephanErb Does this seem like a reasonable way to solve the unhashable thrift structure issue?  https://github.com/JustinVenus/aurora/commit/3757b726660e186a83fba4cca2d3a4d65aeb50db

An update on the python 3 hash situation: https://github.com/apache/thrift/pull/1835

With the recent patch that landed for mutable exceptions, I've been running Thrift with Python 3 for quite some time very successfully. Is there something else that prevents the move to Python 3 for you? I want to make sure we aren't silently being bitten by it.

For us, we have a bunch of dependencies on libraries (graciously) donated to the OSS project by Twitter that haven't received an update to make them fully compatible with Python 3. Thrift support was a big concern though so thanks for landing that patch @cjbarth !


Update create-mongodb-nodejs.md

In bash, folder names like drive letters are not appropriate.

@kuniteru : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Since it was bash, I was expecting it to run on Linux, but was it written for Windows?

#please-close
see comment in https://github.com/MicrosoftDocs/azure-docs/pull/41075#issuecomment-544871516


Modify the bitcoin example with sensible values

In the example of bitcoin crate, specifically the CoinselectOpt was generated randomly.
But those should  be crafted according to the bitcoin transaction fields and are to be determined deterministically.

@NeoZ666 please fix this issue.

#84 here

We can close this now


Add bindgen::Builder::derive_copy

Fixes https://github.com/rust-lang-nursery/rust-bindgen/issues/948

Thanks for the PR @mchlrhw ! The code looks great, but we need a test before we merge this.
Can you add something like this to tests/headers/do-not-derive-copy.hpp:
// bindgen-flags: --no-derive-copy

class WouldBeCopyButWeAreNotDerivingCopy {
    int x;
};

And then verify that the generated tests/expectations/tests/do-not-derive-copy.rs file doesn't add a derive(Copy).
Thanks again!

Cool, thanks for pointing me in the right direction. I wasn't quite sure how testing worked, but your message and CONTRIBUTING.md really helped!

Cool, thanks for pointing me in the right direction. I wasn't quite sure how testing worked, but your message and CONTRIBUTING.md really helped!

Glad to hear that :)

@bors-servo r+

:pushpin: Commit 537a49e has been approved by fitzgen

:hourglass: Testing commit 537a49ef5268c9d6546e84579c3c5441652da1e5 with merge 1e49750a4effcc1d773e667aabf821dde2cebfab...

:sunny: Test successful - status-travis
Approved by: fitzgen
Pushing 1e49750a4effcc1d773e667aabf821dde2cebfab to master...


Repair results

It appears that the 3.results folder had not been updated with the outputs of the notebooks.
I've rerun the notebooks and now have the latest results in the folder.

The issue appears to be that running the notebooks as python scripts gives slightly different plots than when running the notebooks via Jupyter. In particular, this caused the offset in matplotlib to not be correctly calculated.
Also, some of the labels were overlapping due to the use of long-form units (centimetre). I've adjusted the scripts to use short-form units (cm).


ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Checklist

[ ] I'm reporting a broken site support issue
[ ] I've verified that I'm running youtube-dl version 2021.12.17
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

Description

youtube-dl -v -F https://www.youtube.com/watch?v=j-VB9opKzgY
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-F', 'https://www.youtube.com/watch?v=j-VB9opKzgY']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.10.8 (CPython) - Linux-6.0.8-100.fc35.x86_64-x86_64-with-glibc2.34
[debug] exe versions: ffmpeg 4.4.3, ffprobe N-51556-ge278500
[debug] Proxy map: {}
[youtube] j-VB9opKzgY: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/sdb3/home/jd/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 815, in wrapper
return func(self, *args, **kwargs)
File "/sdb3/home/jd/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 836, in __extract_info
ie_result = ie.extract(url)
File "/sdb3/home/jd/bin/youtube-dl/youtube_dl/extractor/common.py", line 534, in extract
ie_result = self._real_extract(url)
File "/sdb3/home/jd/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1794, in _real_extract
'uploader_id': self._search_regex(r'/(?:channel|user)/([^/?&#]+)', owner_profile_url, 'uploader id') if owner_profile_url else None,
File "/sdb3/home/jd/bin/youtube-dl/youtube_dl/extractor/common.py", line 1012, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

#30839!


Giroscope is not working on iOS 13.4.1 and 13.5

It seems it is a common problem with new versions, where the giroscope does not update the view, also appearing in A-frame and WebVR-polyfill:
https://github.com/aframevr/aframe/issues/4542

Following your link, it was fixed in
https://github.com/immersive-web/cardboard-vr-display
and https://github.com/immersive-web/webxr-polyfill
So using updated polyfill should work.
Until we'll fix it here, you can replace vendor/webxr-polyfill.min.js in webxr.js to<EMAIL_ADDRESS>

Thanks for your answer!
I tried to manually download and use the updated version of the polyfill files, and also with your proposal, more direct, but it still doesn't work. Polyfill samples are not working either (https://immersive-web.github.io/webxr-samples/), but A-frame samples (https://aframe.io/aframe/examples/) are properly working after requesting access in a pop-up window. I'll try to know how to fix it.

You can try this method, it worked for me : https://github.com/MozillaReality/unity-webxr-export/pull/425


Mamba problem on installing mss

Hey there!
I tried following the instructions for installing MSS in the README, namely:
$ conda config --add channels conda-forge
$ conda config --add channels defaults
$ conda create -n mssenv python=3
$ conda activate mssenv
$ conda install mamba
$ mamba install mss

Everything works fine until the last step, mamba install mss.
I tried doing it on a relatively new Linux system, as well as on Windows 10.
Both receive the following output, and error:
Looking for: ['mss']

pkgs/msys2/win-64        [====================] (00m:00s) Done
pkgs/main/noarch         [====================] (00m:00s) Done
pkgs/r/noarch            [====================] (00m:00s) Done
pkgs/msys2/noarch        [====================] (00m:00s) Done
pkgs/r/win-64            [====================] (00m:00s) Done
pkgs/main/win-64         [====================] (00m:01s) Done
conda-forge/noarch       [====================] (00m:01s) Done
conda-forge/win-64       [====================] (00m:04s) Done
Encountered problems while solving.
Problem: nothing provides basemap 1.0.7 needed by mss-1.2.1-py27_0

I guess there is a reason the old instruction was changed, but using conda install mss instead seemed to install and work fine.

that's interesting. it seems to try to install a py27 version mss-1.2.1-py27
The reason may an old catalogue. Which version of anaconda was used?

that's interesting. it seems to try to install a py27 version mss-1.2.1-py27
The reason may an old catalogue. Which version of anaconda was used?

I installed anaconda fresh on both systems today, I checked a few versions which might be relevant:
mamba 0.7.6
conda 4.9.2
anaconda Command line client (version 1.7.2)
Nothing was done with anaconda other than the few lines provided in the installation instructions.
Something, somewhere must be outdated then, I think.

I installed anaconda fresh on both systems today, I checked a few versions which might be relevant:
mamba 0.7.6
conda 4.9.2
anaconda Command line client (version 1.7.2)
Nothing was done with anaconda other than the few lines provided in the installation instructions.
Something, somewhere must be outdated then, I think.

reproduced
we have to use for mamba
conda create -n mssenv python=3.8
mamba seems not to be able to decrease the python version. And currently we have not a mss build for python=3.9

reproduced
we have to use for mamba
conda create -n mssenv python=3.8
mamba seems not to be able to decrease the python version. And currently we have not a mss build for python=3.9

I can confirm specifying python=3.8 has solved the issue for me.

I can confirm specifying python=3.8 has solved the issue for me.

Hi @Marilyth thanks for trying mamba.
Indeed, the error message is slightly confusing.
The problem is that conda & mamba handle Python in a special way: the minor version is pinned, so that mamba will always keep python 3.9 unless explicitly asked to change the python version.
You can work around this by either specifying mamba install mss python=3.8.
The error message comes from the fact that mamba tries all available versions of mss, from "top-to-bottom" (mss-..-py38, mss-..-py37, .., mss-..-py27) and then emits the error message for the last package it could not install (because of the pinning of python 3.9 in the environment).
I hope we can further improve the error messaging in such cases.
Is there anything holding back a python 3.9 release for mss?

Hi @Marilyth thanks for trying mamba.
Indeed, the error message is slightly confusing.
The problem is that conda & mamba handle Python in a special way: the minor version is pinned, so that mamba will always keep python 3.9 unless explicitly asked to change the python version.
You can work around this by either specifying mamba install mss python=3.8.
The error message comes from the fact that mamba tries all available versions of mss, from "top-to-bottom" (mss-..-py38, mss-..-py37, .., mss-..-py27) and then emits the error message for the last package it could not install (because of the pinning of python 3.9 in the environment).
I hope we can further improve the error messaging in such cases.
Is there anything holding back a python 3.9 release for mss?

Is there anything holding back a python 3.9 release for mss?

I think this is something @ReimarBauer is more qualified to answer than me.

Is there anything holding back a python 3.9 release for mss?

I think this is something @ReimarBauer is more qualified to answer than me.

Hi @wolfv thanks for helping ;)
In the past a dependency by a used library was not ready for 3.9. I do recheck this currently.
It looks to me that the "conda install" focuses on the newest package wanted and makes this the major dependency while mamba does this on the pinned python version.
May be both can be resolved by first doing a fast lookup, checking if there is a match and the newest package can be installed. If there is no match the user can be asked to try with a specified python version, or maybe the user could enable this.
Currently we usually have on newer python versions also newer package versions. Only if something is not finished we may have on newer python versions some packages missing. I am thinking about if there is a need to show a user that there is a newer version he can't install with current setup.

Hi @wolfv thanks for helping ;)
In the past a dependency by a used library was not ready for 3.9. I do recheck this currently.
It looks to me that the "conda install" focuses on the newest package wanted and makes this the major dependency while mamba does this on the pinned python version.
May be both can be resolved by first doing a fast lookup, checking if there is a match and the newest package can be installed. If there is no match the user can be asked to try with a specified python version, or maybe the user could enable this.
Currently we usually have on newer python versions also newer package versions. Only if something is not finished we may have on newer python versions some packages missing. I am thinking about if there is a need to show a user that there is a newer version he can't install with current setup.

We have now a python-3.9 release.  Possibly it occurs again with > py 3.9.

We have now a python-3.9 release.  Possibly it occurs again with > py 3.9.


[Popper] Expose the sx prop

Modified material Popper with default styled-component (so that the consumer can pass sx prop to it).
closes #29604

[x] I have followed (at least) the PR section of the contributing guide.

@hbjORbj I guess everything is good to go then? Anyway thanks a lot for guiding me through this (my first time contributing to open source haha).
I actually want to keep contributing more to the project, I am looking at issue 27170 (Unstyled components progress), seems like something I'd be interested in working on, but I am having trouble deciding which to work on. Any advice on which component I should take (or any other issues I should work on) that's relatively easier?

Hey @ivan-ngchakming, let me chime in here. I'm glad you'd like to help with the unstyled components. We haven't prioritized the remaining ones yet, but likely we will like to focus on the remaining form controls first (checkbox, radio button). However, they may be a bit tricky to finish if you're new to contributing.
Alternatively, you can tackle some bugs in the existing components - this work is equally important. See https://github.com/mui/material-ui/issues?q=is%3Aopen+is%3Aissue+label%3A"package%3A+base"+-label%3Aumbrella+-label%3Adiscussion for the list of known issues in unstyled components and take one that hasn't been claimed by anyone yet. I'll happily provide assistance if needed.


where can I found Slot Auction staking?

I staking 10 KSM to karura Parachain Auction using polkawallet, But I can't found where can I found the auction info?


fix: drop wee malloc to remove memory leaks

Repeatedly calling this library causes unbounded memory growth. Wee-alloc has known memory leak issues.
See https://github.com/rustwasm/wee_alloc/issues/106
Rust's standard library allocator can be used instead.
resolves #16

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Amazing work, thanks @RossWilliams! Hunting that down would have taken me absolutely ages, thank you so much :clap: :clap: :clap:
Seems like all the tests still work nicely, and the resulting package size is almost identical (+2KB on each 1.4MB binary) so really no downside at all. I'll merge now & push a new release shortly.
By the way, in case you're not aware, HTTP Toolkit Pro is completely free for all contributors to the repos in this org, and this definitely counts! If you're interested, just let me know your email and I'll set you up with an account. More info: https://github.com/httptoolkit/httptoolkit/#contributing-directly


Annotate custom_vjp and custom_jvp

@shoyer What errors are you seeing?  It works on my end, except for this problem: https://github.com/python/mypy/issues/10299

@shoyer What errors are you seeing? MyPy passes on my code using these annotations, except for this problem: python/mypy#10299.

I'm noting the "lint_and_typecheck" continuous integration failure:
jax/_src/lax/control_flow.py:2069: error: Argument 1 to "defjvp" of "custom_jvp" has incompatible type "Callable[[Any, Any, Any, Any], Any]"; expected "Callable[[Tuple[Any, ...], Tuple[Any, ...]], Tuple[ReturnValue, ReturnValue]]"  [arg-type]
jax/custom_derivatives.py:159: error: Incompatible types in assignment (expression has type "Callable[[Tuple[Any, ...], Tuple[Any, ...]], Tuple[ReturnValue, ReturnValue]]", variable has type "None")  [assignment]
jax/custom_derivatives.py:414: error: Name 'Optional' is not defined  [name-defined]
jax/custom_derivatives.py:414: note: Did you forget to import it from "typing"? (Suggestion: "from typing import Optional")
jax/custom_derivatives.py:415: error: Name 'Optional' is not defined  [name-defined]
jax/custom_derivatives.py:415: note: Did you forget to import it from "typing"? (Suggestion: "from typing import Optional")
jax/_src/numpy/linalg.py:316: error: Argument 1 to "defjvp" of "custom_jvp" has incompatible type "Callable[[Any, Any, Any], Any]"; expected "Callable[[Tuple[Any, ...], Tuple[Any, ...]], Tuple[ReturnValue, ReturnValue]]"  [arg-type]
jax/_src/numpy/lax_numpy.py:1074: error: Argument 1 to "defjvp" of "custom_jvp" has incompatible type "Callable[[Any, Any, Any], Any]"; expected "Callable[[Tuple[Any, ...], Tuple[Any, ...]], Tuple[ReturnValue, ReturnValue]]"  [arg-type]
jax/_src/scipy/special.py:234: error: Argument 1 to "defjvps" of "custom_jvp" has incompatible type "None"; expected "Callable[..., Any]"  [arg-type]
jax/_src/scipy/special.py:598: error: Argument 1 to "defjvp" of "custom_jvp" has incompatible type "Callable[[Any, Any, Any], Any]"; expected "Callable[[Tuple[Any, ...], Tuple[Any, ...]], Tuple[ReturnValue, ReturnValue]]"  [arg-type]
Found 8 errors in 5 files (checked 176 source files)

@shoyer Oh, sorry for not checking that output myself! I think I might have fixed the problems, but let's see.
By the way, I noticed that custom_jvp.defjvps doesn't document passing None.

@shoyer Is this okay with you?

Thank you!!


I don't understand how update Internationalization 🤷♂

Hi 👋,
First of all, thank you for your widget. It's exactly what I need.
I'm just stuck on the local date. My settings language device are set to French and my Region too.
I use  Locale myLocale = Localizations.localeOf(context); print(myLocale);to check the value.
Everything look like ok, but the date format don't change.
Have you any ideas ?

@Smartiiez Hi, did you manage to solve Internationalization. I have the same problem and I am stuck also.


support for GCP auth

This is not an issue so much as a pointer that might help others. I have created a fork of this repo that performs the Vault GCP auth using a Google Cloud instance's instance identity token
https://github.com/pantheon-systems/vault-gcp-authenticator
The code and process is almost identical to the K8S authentication with the exception of reading the JWT token from the metadata API instead of from a file as in the K8S auth.
I also made some changes that were desirable for our environment such as using the Vault Go client lib so that all of the standard VAULT_* environment variables are available.
It might be nice to combine the k8s and gcp auth mechanisms into a common binary at some point. Or maybe both will end up in the new Vault agent code.

Hey @joemiller
Thanks for reaching out. I think this is HashiCorp's idea behind https://www.vaultproject.io/docs/agent/index.html (a single agent that does it all). For now, I'm trying to keep this super duper simple in case people want to build something on top of it (legos and all).


Bug: URL-response using upload-path instead of URL-path

What happened?
When using the URL-shortener API, the returned URL uses the upload path (zconfig.uploader.route) instead of the url-path (zconfig.url.route)
See here
Version
upstream (ghcr.io/diced/zipline:trunk)
What browser(s) are you seeing the problem on?
No response
Zipline Logs
No response
Browser Logs
No response
Additional Info
No response

just seen that this was already included in issue 255


feat(DafnyGo): Adds support for basic structs

Issue #, if available:
Description of changes:

Creates the structure for Go polymorph support.
Implements the Go codegen plugin.
Implements the basic structure support for Smithy - Go.

Pending:

Interface changes for all the Smithy-X generators.

Base GoCodegen Commit
7f8b3b99628aa810894bd866caa1998421c807e0 from https://github.com/aws/smithy-go/commits/main/codegen/smithy-go-codegen
Note: This is first PR for Go codegen so open to any fundamental design changes. Would like to close on those first so that there's a solid base structure and minimize future refactoring.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I have left many questions and a hand full of blocking issues.
I am most concerned about the service shape discovery method, which seems particularly fragile...
But there are also many commented out lines with out any explanation...

As mentioned in the description, this PR is supposed to build the foundation and fail fast since we are copying over an existing implementation which is not a perfect fit for our use case. The idea here is to do rapid prototype integrations and sort out any blocking issues in Integrating with Dafny transpiled code. This will only be merged when it's stable enough :)

Closing this, this the final implementation: https://github.com/smithy-lang/smithy-dafny/pull/650


VB Import support

The 'Import' item should stay

I have a PR #213 to fix it, but I need to know where we remove the 'Reference "System"', to also remove the 'Import "System"'


master supports deleting miss copies

Is your feature request related to a problem? Please describe.

Due to the non-atomic nature of offline operations, there will be a scenario where three hosts and two replicas are recorded on the master. This need will be able to offline an abnormal copy.
If there are 3 copies of a partition, and the node to which a copy belongs is stopped for more than one minute (downtime), the partition on this abnormal node cannot be migrated and needs to be repaired

Describe the solution you'd like
The number of copies is N.
To

Under the premise that the number of available copies is greater than >= N/2 +1, it is supported to delete missed copies.
When adding copies, the total number of copies (including those that have been missed) cannot exceed N.
Support meta and data.

fixed by #1285


feat: allow restricting what types can be passed in as parameters

BREAKING CHANGE: The order of the generics of deepmergeCustom
and deepmergeIntoCustom have changed. If you are passing generics
to these functions you need to update them.
fix #305

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#448  👈
#447
#446
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on  Graphite

Merge activity

May 19, 6:59 AM EDT: @RebeccaStevens started a stack merge that includes this pull request via Graphite.


qt starts ok, but it needs to test many features.

Qt starts ok, but console shows errors. To test is needed in many features.
Kivy doesn't have been tested yet.

I have a doubt in lib/blockchain.py:
In version 2.3.3 there are 5 lines commented in functions verify_chain and verify_chunk ( see here )
But in version 2.6.4. the asserts are done in a different way ( see here )
Is it necessary to comment something in the new version?

Here logs: in fact, function verify_chunk() fails, but I don't understand why.
electrum directory /home/xavi/.electrum-fair
[Plugins] registering wallet keepkey: ('hardware', 'keepkey', u'KeepKey wallet')
[Plugins] registering wallet ledger: ('hardware', 'btchip', u'Ledger wallet')
[Plugins] registering wallet trezor: ('hardware', 'trezor', u'TREZOR wallet')
[Plugins] registering wallet trustedcoin: ('twofactor', '2fa', u'Wallet with two-factor authentication')
[profiler] __init__ 0.0101
[Network] starting network
[Network] connecting to chain.fair-coin.org:51002:s as new interface
[Blockchain] 251351 blocks
[WalletStorage] wallet path /home/xavi/.electrum-fair/wallets/default_wallet
[profiler] load_transactions 0.0008
[profiler] build_reverse_history 0.0001
[profiler] check_history 0.0002
[fairlectrum.fair-coin.org] connected
[chain.fair-coin.org] connected
[Network] switching to chain.fair-coin.org:51002:s
[Network] sending subscriptions to chain.fair-coin.org:51002:s 0 0
[fairlectrum.fair-coin.org] requesting chunk 124
[ElectrumWindow/default_wallet] Notifying GUI
[profiler] save_transactions 0.0006
[Blockchain] verify_chunk failed bits mismatch: 486604799 vs 487323889
[fairlectrum.fair-coin.org] requesting chunk 123
Traceback (most recent call last):
  File "/home/xavi/Documents/faircoin2/dev-proves/electrum-fair/gui/qt/main_window.py", line 537, in timer_actions
    self.update_wallet()
  File "/home/xavi/Documents/faircoin2/dev-proves/electrum-fair/gui/qt/main_window.py", line 610, in update_wallet
    self.update_status()
  File "/home/xavi/Documents/faircoin2/dev-proves/electrum-fair/gui/qt/main_window.py", line 590, in update_status
    text =  _("Balance" ) + ": %s "%(self.format_amount_and_units(c))
  File "/home/xavi/Documents/faircoin2/dev-proves/electrum-fair/gui/qt/main_window.py", line 549, in format_amount_and_units
    text = self.format_amount(amount) + ' '+ self.base_unit()
  File "/home/xavi/Documents/faircoin2/dev-proves/electrum-fair/gui/qt/main_window.py", line 559, in base_unit
    assert self.decimal_point in [2, 4, 6]
AssertionError
[Blockchain] verify_chunk failed First part of bits should be in [0x03, 0x1d]
[fairlectrum.fair-coin.org] requesting chunk 122
[Blockchain] verify_chunk failed bits mismatch: 469870383 vs 488005796
[fairlectrum.fair-coin.org] requesting chunk 121
[Blockchain] verify_chunk failed bits mismatch: 486604799 vs 487680067
[fairlectrum.fair-coin.org] requesting chunk 120
[Blockchain] verify_chunk failed bits mismatch: 486604799 vs 487919296
[fairlectrum.fair-coin.org] requesting chunk 119
[Blockchain] verify_chunk failed bits mismatch: 469840764 vs 486812100
[fairlectrum.fair-coin.org] requesting chunk 118
[Blockchain] verify_chunk failed bits mismatch: 486604799 vs 469801955
[fairlectrum.fair-coin.org] requesting chunk 117
[Blockchain] verify_chunk failed bits mismatch: 469810991 vs 487373119
[fairlectrum.fair-coin.org] requesting chunk 116
[Blockchain] verify_chunk failed bits mismatch: 486604799 vs 487518021

Sorry, it's so basic that I'm a little embarrassed. Of course, PoS doesn't use bits nor target, so commenting lines 54 and 56 there's no more verify_chunck errors.
I continue with the port.


Delete an obsolete TODO.

Codecov Report

Merging #11080 (2059fb4) into master (1651d98) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #11080     +/-   ##
=========================================
  Coverage    0.11%    0.11%
=========================================
  Files        2201     2147     -54
  Lines      118091   115576   -2515
  Branches    17872    17567    -305
=========================================
  Hits          137      137
+ Misses     117934   115419   -2515
  Partials       20       20

Flag
Coverage Δ

integration1temurin11
?

integration1temurin17
?

integration1temurin20
?

unittests1temurin17
?

unittests2temurin11
0.11% <ø> (ø)

unittests2temurin17
0.11% <ø> (ø)

unittests2temurin20
0.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...erator/transform/function/InTransformFunction.java
0.00% <ø> (ø)

... and 54 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


DateTime Picker: No FormControl support

Bug Description
Cannot use formControl and need to set value as formatted date and then parse back to a date if changed (need to mark control as touched manually).
More Information to be added..
Expected Behavior

Steps to Reproduce

Go to '...'
...
...

Isolated Example

Context

UI5 Web Components version: {...}
UI5 Web Components for Angular version: {...}
Angular Version: {...}
OS/Platform: {...}
Browser: {...}
Affected component: {...}

Log Output / Stack Trace / Screenshots
{...}

Priority

[ ] Low
[x] Medium
[ ] High
[ ] Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Breaks entire application or system - High or Very High
Accessibility issue - Medium or High
Functional issue - Medium or High
Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.
Stakeholder Info (if applicable)

Organization: {...}
Business impact: {...}

The value(string) is set to be a value provider for that component and change and input are events for an update. If we want to communicate with a date picker on a different language(Date object for example), we need to update the api.json so that it says that for the form usage purposes, the dateValue should be used. Otherwise, it will always take value as a updated value provider and you'll always need to parse that for getting the desired Date type.
As for how it works with given configuration, I could not find any problem with it, it works both for ngModel and for the formControl and properly sets initial value and properly reports the updates.

Sandbox updated with example
DatePicker only works with FORMATTED DATE STRING instead of date object
-> All dates need to be formatted in the correct pattern and then parsed back after a date was selected, as formatted date string have no value to be used in logic.
For whatever reason in the sandbox the format-pattern is broken (I had that working before in another repo. Maybe related to this version)
-> Uncaught TypeError: Configuration_js__WEBPACK_IMPORTED_MODULE_1_.default.getCalendarWeekNumbering is not a function

Additionally sometimes there is a error "The given date instance isn't valid. -" in the console

Hello @timogeib
Using DatePicker, DateTimePicker components "value"
There is a public method formatValue that converts a date to a value in the correct format. You can use it and then pass the string as DatePicker, DateTimePicker's value
/**

Formats a Java Script date object into a string representing a locale date
according to the formatPattern property of the DatePicker instance
@public
@method
@name sap.ui.webc.main.DatePicker#formatValue
@param {Date} date A Java Script date object to be formatted as string
@returns {string} The date as string
*/
formatValue(date: Date) {
return this.getFormat().format(date);
}

Afterwards if you want to read the value, but not as  a string, but as a date object, you can use the dateValue public read-only getter

/**

Currently selected date represented as a Local JavaScript Date instance.

@public
@readonly
@name sap.ui.webc.main.DatePicker.prototype.dateValue
@type { Date }
*/
get dateValue(): Date | null {
return this.liveValue ? this.getFormat().parse(this.liveValue) as Date : this.getFormat().parse(this.value) as Date;
}

For the issue with the exception
-> Uncaught TypeError: Configuration_js__WEBPACK_IMPORTED_MODULE_1_.default.getCalendarWeekNumbering is not a function
Did you try with the latest RC of ui5-webcomponents-ngx, combined with ui5-webcomponents 1.19, because I believe it's fixed by this change https://github.com/SAP/ui5-webcomponents/pull/7684
I hope this helps - we can also discuss these problems offline.
BR,
ilhan

Update:
Hello guys,
after we once more discussed the problem with Timo, it turns out that the issue is not related to FormControl support itself, but how one sets value to the DatePicker.
In Timo's case, he prefers to work only with date objects while the DatePicker expects and provides a string "value" property. We presented to Timo how the date object can be properly converted to date string and vice verca (see the previous message showing the usage of formatValue and dateValue public methods).
Although the suggestion works, before just closing the issue, we will take more time to think for more convenient solution
and what complications might be if we allow setting the value via date objects.
@timogeib feel free to add more on this.
BR,
ilhan


Tensorflow 2.4.0 ( tf has no attribute placeholder)

I am running the tool  with all the the requirements installed along with tensorflow-gpu=2.4.0, However, I get an error
for the following line
Placeholders
indices = tf.placeholder(tf.int32, shape=(batch_size, None, 2), name="indices")
is_training = tf.placeholder(tf.bool, name='is_training')
pts_fts = tf.placeholder(tf.float32, shape=(batch_size, max_point_num, setting.data_dim), name='points')
######################################################################

It seems the file "predicting_point_segmentation.py" still uses a functionality of tensoflow 1.X  .
Could you please suggest a fix?

You have to change version of tensorflow-gpu to 1.7.0. It is best to look to closed pull-requests and see what bot updated and to change it back.


[WIP] Druid 0.9.1 Release Notes

Druid 0.9.1 adds the experimental Kafka Index Task to support exactly-once consumption from Apache Kafka. Druid 0.9.1 additionally adds support for cluster-wide query-time lookups (QTL). The segment balancing algorithm for Druid has also been improved, to enable much more even segment distribution within a cluster. There are hundreds of additional performance and stability improvements, and bug fixes.
Full list of changes is here: https://github.com/druid-io/druid/issues?q=milestone%3A0.9.1+is%3Aclosed
Updating from 0.9.0
The standard Druid update process described by http://druid.io/docs/0.9.0/operations/rolling-updates.html should be followed.
There is a small backwards incompatible change for any folks that may have their own QueryGranularity library:
https://github.com/druid-io/druid/issues?q=milestone%3A0.9.1+is%3Aclosed+label%3AIncompatible
New Features
#2602 implement special distinctcount
#2220 Appenderators, DataSource metadata, KafkaIndexTask
#2424 Enabling datasource level authorization in Druid
#2410 statsd-emitter
#1576 [QTL] Query time lookup cluster wide config
Full list: https://github.com/druid-io/druid/issues?q=milestone%3A0.9.1+is%3Aclosed+label%3AFeature
Improvements
#2972 Improved Segment Distrubution (new cost function)
#2931 Optimize filter for timeseries, search, and select queries
#2753 More consistent empty-set filtering behavior on multi-value columns
#2727 BoundFilter optimizations, and related interface changes.
#2711 All Filters should work with FilteredAggregators
#2577 Implement native in filter
Full list: https://github.com/druid-io/druid/issues?q=milestone%3A0.9.1+is%3Aclosed+label%3AImprovement
Bug Fixes
Full list: https://github.com/druid-io/druid/issues?q=milestone%3A0.9.1+is%3Aclosed+label%3ABug
Documentation
Full list: https://github.com/druid-io/druid/issues?q=milestone%3A0.9.1+is%3Aclosed+label%3ADocumentation
Thanks to everyone who contributed to this release!
@fjy
@gianm
@jon-wei
@dclim
@acslk
@xvrl
@drcrallen
@nishantmonu51
@pjain1
@himanshug
@b-slim
@rasahner
@guobingkun
@navis
@binlijin
@sirpkt
@skilledmonster
@shekhargulati
@spektom
@javasoze
@du00cs
@mrijke
@kilida
@JonStrabala
@jisookim0513
@erikdubbelboer
@gaodayue
@sascha-coenen
@jaehc
@bjozet
@pdeva
@michaelschiff
@se7entyse7en
@harshjain2
@lizhanhui

I need to do a short blurb about the QTL caching extension and incompatible changes. Will write when https://github.com/druid-io/druid/pull/2926 is in master

The prior druid-namespace-lookup  extension has been moved to the Lookups framework and is now druid-lookups-cached-global. Documentation can be found at https://github.com/druid-io/druid/blob/master/docs/content/development/extensions-core/lookups-cached-global.md
The prior druid-kafka-extraction-namespace has undergone some changes as well. Updated documentation is available at https://github.com/druid-io/druid/blob/master/docs/content/development/extensions-core/kafka-extraction-namespace.md

A change was made to QueryGranularity to prevent a potential deadlock. A side effect is that most of the static fields are now in QueryGranularities. Please update any extensions accordingly. See https://github.com/druid-io/druid/pull/2980

@drcrallen added to release notes. Can you edit them?

@fjy Yes, and I'll add directly to them if you want :) since you took initiative to write them up I

Didn't want to step on your toes with managing the release notes
Wanted to make the formatting pretty much done.

But If you want I can just edit the notes directly if I think of any more.

@fjy I added these notes from issues marked "release notes"

The default value for maxRowsInMemory has been set to 75,000 across the board for all forms of ingestion. This is in line with previous defaults for Hadoop tasks and Tranquility-based ingestion. If you were creating realtime index tasks directly (without Tranquility) then this is lower than the previous default of 500,000.
The /druid/coordinator/v1/datasources/{dataSourceName}?kill=true&interval={myISO8601Interval} REST endpoint is now deprecated. The new /druid/coordinator/v1/datasources/{dataSourceName}/intervals/{interval}?kill=true REST endpoint can be used instead.
druid.indexer.runner.separateIngestionEndpoint is now deprecated. If you were using this functionality to isolate event-push requests and query serving requests for realtime tasks, you can accomplish something similar with druid.indexer.server.maxChatRequests.
For developers of Druid extensions, note that the QueryGranularity constants (ALL, NONE, etc) have been moved to io.druid.granularity.QueryGranularities in #2980. Query syntax is not affected.

added a short blurb on the Kafka indexing service

added this note to QTL:

Static configuration via the druid.query.extraction.namespace.lookups property is no longer supported. Instead, lookups can be configured at runtime via dynamic configuration.

updated QTL section to:
Query time lookup (QTL) functionality has been substantially reworked in this release. Most users will need to update their configurations and queries.
The druid-namespace-lookup extension is now deprecated, and will be removed in a future version of Druid. Users should migrate to the new druid-lookups-cached-global extension. Both extensions can be loaded simultaneously to simplify migration. For details about migrating, see Transitioning to lookups-cached-global in the documentation.

Added
* Some cache keys have changed their calculation methodology. Deployments with centralized caching (like memcached or redis) can expect a drop in cache hit rate until all nodes are upgraded

https://github.com/druid-io/druid/releases/tag/druid-0.9.1


[TwigComponent] Fix full context is stored in profiler

Q
A

Bug fix?
yes

New feature?
no

Issues
Fix #1540

License
MIT

As $event->getVariables() get the full context for non-embed components, this led to huge data stored for every component called during the request. (see #1540)
As this is internal data, and the "variables" was not used in the profiler, I believe we should consider this a bug and simply remove it.

Thanks Simon!

Thanks Simon !


resolved the navbar alignment issue

Issue Number

ISSUE #391
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Made the navbar alignment precise to the window height
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
A clear and concise description of it.
NA
Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.
When window is stretched

When the window is a bit small

Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
How someone can test your code?
Checklist

[x] I have mentioned related issue number in PR description.
[x] I have added screenshots and related demo links of my changes..
[x] The title of my pull request is a short description of the requested changes.
[ ] I have added my name in the contributors list at the end of README.md file.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here) LGMSOC

Resolve conflicts

Done! @QAZIMAAZARSHAD


reverseString: Replace spread operator with split() for compatibility

@wojtekmaj  I think It needs to be decided once and for all
spread VS. split('')

@wojtekmaj, @iamsoorena Honestly, we have changed half the snippets that use either back and forth like 10 times. I need a definitive answer, so we can add it to the contribution guidelines. I am primarily a Firefox user and spread is definitely faster on Firefox. It's also easier to read, however if split is significantly faster, we should opt to use that. If the difference is like very minor, we should only use the optimal one of the two if we expect huge inputs and operations are costly (for example anagrams). Can one of you test this consistently and give us some results for all browsers? I would be glad to finalize the guideline on this.

I think we can all still agree that the rest operator is still fine to use in most(99.99%) cases though

Right maybe I'm not used to github just yet, but for future reference how do you just do a comment on code and not a review? Did I miss a button somewhere?

@skatcat31 there's a button that says Add single comment instead of Start a review. But it's fine either way, don't worry about it.

From the test results presented in #200, split() is faster, so we should stick with that as much as possible, especially if we anticipate the input and processing of a function to be significant.


enable mistral

mistral needs flash attention and a decent dtype to be finetuned on a 40GB GPU

I agree that --use-flash-attention-2 would be the optimal way. Where would you pass it? Is it part of the model config? Or where would it go?


Add Docker / Docker build stuff.

One of these days I swear to god I will change the target correctly first.


Add more libraries to Beaker-Libraries.md

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2327/
Test PASSed.

@DavidS we like to prepend PR's like this with a (maint) prefix; otherwise all other PR's need to have BKR tickets associated with them. Once that is in, I can merge this update. Thanks!

Done.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/2339/
Test PASSed.


MansoryPaneController

I Can't find the problem

i think jfoenix.jar is not included in your classpath properly.


Support to custom quota project

Feature Description
Add param to allow an user to define a custom quota project when connecting to CloudSQL Admin APIs.

@ruyadorno this is already supported, by using GOOGLE_CLOUD_QUOTA_PROJECT env var:
https://github.com/googleapis/google-auth-library-nodejs/blob/5f296c37390ba71aa3aa1e4259ff7c525eeaad7c/src/auth/googleauth.ts#L339

Nice find! We should document that here, but also add an explicit API option too to match the other Connectors.

If I did not miss something, there is currently no other way to pass quotaProjectId to google-auth-library. It either reads it from the credentials JSON, or overrides it from the GOOGLE_CLOUD_QUOTA_PROJECT env var.

@edosrecki you're right it doesn't look like there's a programmatic API support to it other than the environment variable.
I believe that there's a case to be made to contributing a new API to google-auth-library to add that support.

In that case, we might let this sit for now. I'd suggest folks upvote the original comment if they want this and we'll prioritize accordingly.

Caught up with @danielbankhead last week that showed me https://github.com/googleapis/google-auth-library-nodejs/pull/1663 which normalized a quotaProjectId option for all auth clients. I believe that with that shipped in<EMAIL_ADDRESS>we should be unblocked now to add programmatic API support to it.

Given that https://github.com/GoogleCloudPlatform/cloud-sql-nodejs-connector/pull/238 enabled using any custom auth to be set I believe that a reliable way to support this is to document setting the value via auth property, e.g:
import {GoogleAuth} from 'google-auth-library';
import {Connector} from '@google-cloud/cloud-sql-connector';

const connector = new Connector({
  auth: new GoogleAuth({
    quotaProjectId: "<custom quota project>",
  }),
});

Any thoughts @danielbankhead ?


Cloning Materials results in darker Materials

When running wackydb_save_material [materialname], the expected behavior is that the material is cloned from the existing material to be an exact copy. Applying this new material to an item without any alteration to the Material file will result in an item that is overall darker than using the donor material. It's as if the cloned textures are overlaying the donor textures, resulting in a darker texture.
To further test this, I cloned a cloned material, and cloned that material again, and applied it to weapons each step of the way. At every interval the weapon got darker and darker. This example is using meteorite as the material.

It might be an issue with a linear color space being interpreted as SRGB when the material is cloned, just a guess.

Some further research found interesting results.
The albedo map derived from Wacky's clone command produces a much darker image than one derived straight from Unity.
These are both from the weapon Krom.

Issue should be fixed in latest version


Liveness probe support for calico-kube-controller

As of now, liveness probe is not added to calico-kube-controller pod's. Is there a reason why it is not having liveness probe on calico-kube-controller?
Expected Behavior
Can we add liveness probe to call the check-status script (used in readiness probe) to trigger a restart of the pod when check-status fails as part of liveness probe trigger.
Current Behavior
There is no liveness probe on calico-kube-controller pod.
Possible Solution
Add liveness probe which triggers the same check-status script that is called in Readiness probe of calico-kube-controller.
Steps to Reproduce (for bugs)
Below are couple of scenario's which might lead to the liveness probe fail and which needs pod restart to overcome check-status failure:

status.json file reading fail's. which might get fixed after pod restart
One of the component/controller (wep,policy,namespace,etc) health check fails might lead to check-status failure and a restart might help to overcome this.

Context
Incase check-status fails as part of readiness probe failure, calico-kube-controller will be stuck in non-operation state. So we need some mechanism (liveness probe) to restart the pod to come out of this situation.
Your Environment

Calico version : v3.4.0
Orchestrator version (e.g. kubernetes, mesos, rkt): Kubernetes v1.11.6
Operating System and version: Ubuntu kernel 4.15.0-47-generic
Link to your project (optional):

Are you seeing problems with the kube-controllers where a liveness probe would help?
As best I could tell currently the readiness check is only checking access to the datastore and the kube-apiserver, so monitoring it with the check-status is not going to catch many problems but would probably be safe to do.
I do believe it would be nice if we added in liveness checks into each of the controllers incase one of them has a problem. As for a reason why it does not have liveness checks is probably because no one has added them and there have not been reports of problems with it, so it hasn't been high on the list of priorities.
If you want to add liveness checks we would be happy to discuss and review.

Hi Erik,
Thanks for your response.
As per my understanding, calico-kube-controller's primary job is to sync the kubernetes objects related to namespace, policy, node, service account, and wep with the calico datastore.
I hope if we add the liveness probe with the same trigger (check-status -r) might help to overcome the readiness probes failures (which needs a restart of the pod).
As mentioned readiness failure can occur while checking access for datastore ("Error Verifying datastore" and the access to kube-apiserver Healthcheck ("Error reaching apiserver").
From my netpol, namespace, policy, node and serviceaccount controller code walk through it seems the controller sync's with K8s API before starting resource cache (deals with kube-apiserver) or syncToDataStore to sync the given update to the Calico datastore.
Because "check-status -r" already addresses the healthcheck with k8s-apiserver and calico datastore, we can add "check-status -r" for liveness probe also.
I hope adding the liveness probe with the below params will be ideal way:
Trigger: /usr/bin/check-status -r
If the readiness probe has:

initialDelaySeconds: 5
periodSeconds: 10
failureThreshold: 2
We can configure the liveness probe as below:
initialDelaySeconds: 25
periodSeconds: 1
failureThreshold: 1

With the above Readiness and liveness probe configuration on calico-kube-controller, readiness check fails 2 times ( time lapsed is 25 sec) and immediately liveness probe (check-status -r) is triggered and restart the calico-kube-controller pod.
Please let me know
Regards,
Bharani..


API locations shows incorrectly when deployed to subdirectories

Actual behaviour
API endpoint location offered assumes application is deployed to docroot, subdirectories are left out.
In my example, https://localhost/fever and https://localhost/jsonrpc.php are shown, however the app is in http://localhost/miniflux/
Expected behaviour
Show correct API locations, in my example:
https://localhost/miniflux/fever
https://localhost/miniflux/fever
Steps to reproduce

Install miniflux to your docroot/miniflux directory
Setup, but do not create a the config.php file (don't provide BASE_URL), keep it as defaults
Login and view /miniflux/?action=api
Observe locations offered.

Configuration

Deployment location: https://localhost/miniflux

Miniflux version: 1.2.1

Database type and version: sqlite3, 3.13.0

PHP version: 5.6.30

OS: Gentoo LInux

Browser: Safari

Also, try this one:

setup miniflux to your host/miniflux/
connect with fever via host/miniflux/fever - this will be ok.
create a config.php based on config.default.php

Observe that fever sync breaks on any client (no new items retrieved, no errors thrown in nodebug).

Facing this issue.

An issue has been fixed in config.default.php, the path need to be absolute. You can check the diff here: https://github.com/miniflux/miniflux/commit/6e8d175202f3dcec2ee6c1aea361d9c6e1d80815#diff-9f6ff47d1bc0b582739011e569839d32


Update wiki with actual messaging and positioning.

File Location(s)
No response
Proposal
subj

Done in https://github.com/gear-tech/wiki/pull/15


Dashed line for polyline

Hi!
I'm using polyline to create lanes and lanemarkings on streetscape. The lines are appearing as solid lines right now and I was wondering if there is a style property that I could use to make them dashed.
Thanks and regards
Goksan

@goksanisil23  The current polyline does not support dashed lines.
However we do have an example implementation that does.
https://github.com/uber/streetscape.gl/blob/master/modules/layers/src/lane-layer/README.md
This is demonstrated as a custom layer here: https://github.com/uber/streetscape.gl/blob/master/test/apps/layers/src/custom-layers.js
Currently the custom layer approach is a bit awkward because it is out-of-band of the XVIZ message (meaning it's not handled well in the current XVIZ flow to add custom extensions that could be replaced or handled by client code).  So you have to handle it directly.
Since this touches on mapping data which is a bit different from autonomy data in that it is relatively static it's not been a significant area of development. We are getting better in this area  with some of the more recent additions like the scene graph and persistent streams.

Thanks for pointing out the lane layer. It seems that it would do the job for me.


ImageSeriesReader reading images incorrectly

Hi,
I am using SimpleITK <IP_ADDRESS> build py37h82bb817_0. I am trying to read a DICOM series with python containing a binary mask from a segmentation. ImageSeriesReader returns an empty image with only zeroes. The image can be correctly opened with 3D Slicer or ImageJ. Using ImageFileReader on a single slice, the resulting image is better, although instead of zeros and ones I get zeros and 0.9999.... which is also surprising, given that the RescaleSlope of the file is 1. Here is the code I use:
import SimpleITK as sitk
import os

test_path = '.\\SE5'

reader = sitk.ImageSeriesReader()
dicom_names = reader.GetGDCMSeriesFileNames(test_path)
reader.SetFileNames(dicom_names)
image = reader.Execute()

reader2 = sitk.ImageFileReader()
reader2.SetImageIO('GDCMImageIO')
reader2.SetFileName(os.path.join(test_path, '0000006K'))
image2 = reader2.Execute()

filt = sitk.MinimumMaximumImageFilter()
filt.Execute(image)
print(filt.GetMaximum()) #0.0

filt.Execute(image2)
print(filt.GetMaximum()) #0.9999999975098001

Here are the relevant DICOM attributes of the image (I have omitted attributes unrelated to pixel data):
[0020,0032]	ImagePositionPatient -348.632812, -348.632812, -872.330017
[0020,0037]	ImageOrientationPatient	 1, 0, 0, 0, 1, 0
[0028,0002]	SamplesPerPixel	1
[0028,0004]	PhotometricInterpretation	MONOCHROME2
[0028,0010]	Rows	256
[0028,0011]	Columns	256
[0028,0030]	PixelSpacing 2.734375, 2.734375
[0028,0100]	BitsAllocated	16
[0028,0101]	BitsStored	16
[0028,0102]	HighBit	15
[0028,0103]	PixelRepresentation	1
[0028,1050]	WindowCenter	0.5
[0028,1051]	WindowWidth	1
[0028,1052]	RescaleIntercept	0
[0028,1053]	RescaleSlope	1
[0054,0081]	NumberOfSlices	259

Hello @six6egrees,
Please see if this FAQ entry addresses your question. Is the volume really all zeros or is it just the visualization?
With respect to the 0.9999... value vs. 1, this looks like the reading is interpreting the image as having floating point values (rescale slope can be any decimal string 1.0, 0.1 etc).

Hi @six6egrees,
There is no resampling when the image is just read.
The only thing I can think of is that the series is potentially corrupted, multiple slices occupy the same location. When you read them in, a slice without a segmentation "overwrites" the one with segmentation (they are both in the same physical location). This is just an educated guess.
Can you share the DICOM series so that we can reproduce the issue and debug it? Otherwise, I can only guess and that won't get you very far.

Thank you, @zivy
That could be the case. I'm having some problems with Slicer now: while Slicer can load and correctly visualize the image, when I tried to export the data as a DICOM series the exported files become empty. Which is very strange.
I will check tomorrow if the data can be shared. Meanwhile I'll try to look into the files, maybe I can reproduce this error with synthetic data which I can share.

@zivy Turns out the source of the problem was a very low RescaleSlope that only occurs if the slice has non-zero pixel values, essentially setting the whole image to zeros. Slicer and ImageJ must have ignored it.
Thank you for your help, and sorry to waste your time!

Dear @zivy
Although changing the rescale slope of my files solved my problem, I had some more time to look into this and there is indeed a very unexpected behaviour from SimpleITK. It all boils down to DICOM image series with variable RescaleSlope parameters. I am now attaching a zip archive containing a file set created with SimpleITK using the method described in the documentation with slight modifications.  All other voxels are set to zero in the entire series. After saving these files with RescaleSlope = 1, I modified the RescaleSlope of '0.dcm' to 10, '4.dcm' to 0.9 and all the other slices to 4.5.
test_files.zip
The behaviour is the following: if the first slice in the series has an integer RescaleSlope value, than any other slice following it will have their RescaleSlope value rounded down to the nearest integer when ImageSeriesReader scales them during reading. In the above example, the slice corresponding to '4.dcm' will be empty and the slice corresponding to '5.dcm' will have values equal to 4 instead of 4.5. Setting the RescaleSlope of '0.dcm' to a non-integer value eliminates this problem. It also doesn't matter what type I use in python to set the value (using float(10.0) and int(10) gives the same results), the value representation of the attribute in the DICOM file stays exactly the same.

Hello @six6egrees,
Can confirm that this is indeed a bug.
When reading an image series, the pixel type of the image series is deduced from the pixel type of the first slice. This works 99% of the time, but it is not a correct assumption as you've shown (the DICOM standard allows for this, so it is not a contrived example). A quick workaround is to explicitly specify the pixel type when reading.
Code illustrating the problem and workaround:
import SimpleITK as sitk

series_files = sitk.ImageSeriesReader_GetGDCMSeriesFileNames("test_files")
print(f"Pixel type deduced from volume (equivalent to using image 0): {sitk.ReadImage(series_files).GetPixelIDTypeAsString()}")
print(f"Pixel type deduced from image 0: {sitk.ReadImage(series_files[0]).GetPixelIDTypeAsString()}")
print(f"Pixel type deduced from image 1: {sitk.ReadImage(series_files[1]).GetPixelIDTypeAsString()}")

sitk.Show(sitk.ReadImage(series_files), "automatically determined pixel type from first slice")
sitk.Show(sitk.ReadImage(series_files, sitk.sitkFloat32), "user defined pixel type")

@blowekamp can you take a look at this?
I suspect the issue arises here, but not sure.

@zivy Can you please make a PR adding your code to reproduce the issue as a test? Then I can work on a fix.


Pttp 3736/cloudwatch exporter

This adds an alertmanager instance to the EKS cluster with a few initial metrics, with metrics being retrieved for their respective accounts for dev and pre-production but in production retrieving metrics from dev, pre-production and production.

Adds a policy to give access to cloudwatch for the worker nodes, I refactored all the policies into a separate file whilst doing this.
Creates roles for production account to assume that allow it to get metrics in the other accounts

We will flesh out the production config file for the exporter in a later PR.

I dont believe deploying this change without the kubernetes changes in https://github.com/ministryofjustice/staff-infrastructure-monitoring-config should break anything as it mostly just adds roles so i think this should be deployed before adding cloudwatch exporter to kubernetes


Error install

bash rtsetup
fatal: unable to access 'https://github.com/arakasi72/rtinst.git/': Problem with the SSL CA cert (path? access rights?)
rtsetup: line 27: cd: /etc/rtinst: No such file or directory
fatal: unable to access 'https://github.com/arakasi72/rtinst.git/': Problem with the SSL CA cert (path? access rights?)
rtsetup: line 38: cd: /etc/rtinst: No such file or directory
fatal: Not a git repository (or any of the parent directories): .git

after install ca-certificates
error :
bash rtsetup
Already on 'master'
Your branch is up-to-date with 'origin/master'.

OK your second post is not errors it is working.
rtsetup now checks and installs ca-certificates if not already installed
Thanks


Global Reviews - On click not working as expected

When we click on global review it should take you to the project/home page .

changed ui-sref to point to 'projects.project.home'


Display connection error if front end cannot connect to API server

Whenever a component in React is loaded, call the api/health endpoint with a short (10 seconds) timeout to check if the front end is able to connect to the API server.
If the connection is not successful, return an error page component with any details about the connection error.
We currently don't have an error page component but can make one quickly.

@ciminelli would you provide more info about this issue, would love pick up this issue. Thanks

@ciminelli @mpatin would you provide more info about this issue, would love pick up this issue. Thanks

That sounds great, I just added more to the description. I think we could add a universal useEffect call on each component to do this. Let me know how else I can help!

@ciminelli @mpatin would you provide more info about this issue, would love pick up this issue. Thanks

That sounds great, I just added more to the description. I think we could add a universal useEffect call on each component to do this. Let me know how else I can help!

Thanks, I was looking for backend, this seems to frontend  task.

hello is this issue still open. would love to pick up this issue

@ciminelli kindly let me know if this issue is still open? Thanks

@kingsoo123 it is not, I'll close it out. We'll be working on some issues in the near future to onboard to contributing and I can keep you updated on Slack. Thanks for your support!


fix(package): update dependecies to fix sshpk security issue, https:/…

…/nodesecurity.io/advisories/606
fixes #64

Coverage remained the same at 97.473% when pulling f4313749fba6f1cbb0e8089d8d31674c57633727 on lholmquist:64-sshpk-nsp into 204f3a424cdc965240a1f8c9a25de4b8dab61429 on bucharest-gold:master.


chore: Update generated code

Because #607 was merged before #597, the generated protobuf code is not up-to-date on main
Signed-off-by: Charith Ellawala<EMAIL_ADDRESS>

Codecov Report

Merging #610 (2bb023e) into main (353dce0) will increase coverage by 0.04%.
The diff coverage is 68.08%.

@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   54.31%   54.36%   +0.04%
==========================================
  Files          82       83       +1
  Lines        8454     8485      +31
==========================================
+ Hits         4592     4613      +21
- Misses       3437     3446       +9
- Partials      425      426       +1

Impacted Files
Coverage Δ

internal/util/hash.go
0.00% <0.00%> (ø)

internal/policy/policy.go
9.67% <80.00%> (+9.67%)
:arrow_up:

internal/compile/compile.go
91.62% <100.00%> (+0.15%)
:arrow_up:

internal/policy/io.go
32.35% <0.00%> (+14.70%)
:arrow_up:


Keras Keypoint detection example doesn't converge

Issue Type
Bug
Source
source
Keras Version
Keras 3
Custom Code
No
OS Platform and Distribution
Linux
Python version
3.9
GPU model and memory
No response
Current Behavior?
There is a keypoint detection guide on the Keras website at https://keras.io/examples/vision/keypoint_detection/, the example walks through training a key point detection model on the stanford dogs dataset. At the end of the example, it shows some of the example key points predicted by the model, with the comment "Predictions will likely improve with more training.":

I have tried running additional training, but the results are the same, and don't seem to improve. I've tried training on a custom dataset using the model architecture from the example, and the results are similar - the predicted key points don't correlate to the image.
That makes me suspect that there an issue with the model architecture proposed in the example:
def get_model():
    # Load the pre-trained weights of MobileNetV2 and freeze the weights
    backbone = keras.applications.MobileNetV2(
        weights="imagenet",
        include_top=False,
        input_shape=(IMG_SIZE, IMG_SIZE, 3),
    )
    backbone.trainable = False

    inputs = layers.Input((IMG_SIZE, IMG_SIZE, 3))
    x = keras.applications.mobilenet_v2.preprocess_input(inputs)
    x = backbone(x)
    x = layers.Dropout(0.3)(x)
    x = layers.SeparableConv2D(
        NUM_KEYPOINTS, kernel_size=5, strides=1, activation="relu"
    )(x)
    outputs = layers.SeparableConv2D(
        NUM_KEYPOINTS, kernel_size=3, strides=1, activation="sigmoid"
    )(x)

    return keras.Model(inputs, outputs, name="keypoint_detector")

Is it possible that the model architecture suggested is not suitable for key point detection? I'm very interested in a basic keypoint detection architecture, but the example/guide is unfortunately not helpful.
If you can provide some pointers, I can take a pass at improving the example.
Thanks in advance
Standalone code to reproduce the issue or tutorial link
examples/vision/keypoint_detection.py

Relevant log output
No response

Hi,
The tutorial is for demonstration purpose only, and it is not fine tuned to return the best outcome.
Feel free to fine tune the model as per the suggestion in the comment below.

Going further
Try using other augmentation transforms from imgaug to investigate how that changes the results.
Here, we transferred the features from the pre-trained network linearly that is we did not fine-tune it. You are encouraged to fine-tune it on this task and see if that improves the performance. You can also try different architectures and see how they affect the final performance.

If you get the bettewr convergence with the modification in the model architecture, you can create a PR to make the same changes. Thanks!


Improved model for references

This PR removes the (redundant) XML based model for references from the internal article model,
and adapts the other implementation accordingly.
There are regressions introduced by this PR.

We will fix the regressions later on.


[TensorIR][UX] Type annotation-based runtime type checking

Addressed the UX issue raised in #9551.
To address the first issue (cryptic error message on packed function boundary), this PR introduced a decorator @type_checked to do runtime type checking and generate more user-friendly error messages. In our example:

The second issue is mainly wording. This PR rephrasing the error message to:
ValueError: The loop no long exists in the IRModule

However, I cannot find any environment variable to disable stacktrace printing. It was there months ago but no longer exists...Weird...
The notebook: https://gist.github.com/junrushao1994/cd0a33dc966da3b3f1abfa50a14e6d2c
CC: @tqchen

Looks like we need at least python 3.7 to run the decorator…

on the c++ stacktrace side, perhaps the main thing is to update the trace formatter to simplify and skip some of the less informative traces(e.g. unpackcall_dispatcher) but keep the rest of the useful traces

on the c++ stacktrace side, perhaps the main thing is to update the trace normalizer to simplify and skip some of the less informative traces(e.g. unpackcall_dispatcher) but keep the rest of the useful traces

Alternatively, there are other metaprogramming tricks to completely avoid recursion and could potentially generate significantly better error message.

Update with a py36 compatible implementation

The error message is improved to:
TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_307968/1279557970.py in <module>
      5 i = sch.get_loops(block_c)
      6 # Tile the loop nesting.
----> 7 i_0, i_1, i_2 = sch.split(i, factors=[None, 4, 4])
      8 print(sch.mod.script())

~/Projects/tvm-dev/python/tvm/tir/schedule/_type_checker.py in wrap(*args, **kwargs)
    147                 )
    148                 if error_msg is not None:
--> 149                     raise TypeError(error_msg)
    150         return func(*args, **kwargs)
    151

TypeError: In "Schedule.split", "loop" has wrong type. Expected "LoopRV", but gets: "list"


Run url as output

Description
I can see that you generate the run url  and add it as a notice.
Would be very useful if it can be added to the outputs instead of a notice
Use case
As part of our CI/CD we want to run UI Tests on device farm and notify our engineers in case of failure with the run url so our engineers can go to the run on AWS Console and find the failing tests
Expected
Have the run url as an output from the action
Actual
I need to compute it in my job through extracting the run_id & project_id from the arn output and generating the url
Suggested solution
Add the run_url as an output instead of a notice

Yep, that makes sense.

@mina-kleid Thank you for your feedback. We have incorporated this request into the v2-beta pre-release, please review and feedback as required:
https://github.com/aws-actions/aws-devicefarm-mobile-device-testing/releases/tag/v2-beta

@danjhd Thanks for your fast response. Looks good 🚀

@danjhd Thanks for your fast response & changes. Looks good to me 🚀

Closing this with release of v2.0


Bug remove some exception title on regression case

Proposed changes
Caused by: java.lang.AssertionError: Expect exception msg contains '[INVALID_ARGUMENT]Conversion from UInt8 to BitMap is not supported', but meet 'java.sql.SQLException: errCode = 2, detailMessage = [CANCELLED][INVALID_ARGUMENT][<IP_ADDRESS>]Conversion from UInt8 to BitMap is not supported'
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


it appears rails comes with sprockets. this fixes  CVE-2014-7819

@whereismyjetpack I took out sprokets in 4e5c43388ccbd54917d68575ca57b30b6125525c. Is it still lurking around somewhere?

Looks like rails depends on sprockets-rails but at least now a patched version is resolvable


Add blink option

Would be very handy if the text could also blink.

Can write your own implementation with something like:
componentDidMount(){
  this.blinkInterval = setInterval(() => {
    this.setState({ blink: !this.state.blink })
  }, 1000)
}

...

render(){
  return(
    <View>
      <TextTicker style={{ opacity: this.state.blink ? 0 : 1 }}>
        Amazing blink example
      </TextTicker>
    </View>
  )
}


Container Native MySQL

As a user of Forseti, I would like to experimentally deploy Forseti with a container native MySQL data store.

@kevensen Can you provide some more info about this ticket? Is this project related?


Payload missing on chatbot custom component

Hi @FredrikOseberg, I noticed that by trying to setup a payload object with custom information for a bot message (I have a custom component for this) the only props that I receive are "message: string, loader: Comp", I was under the impression that payload should be present as prop here as well
 <ConditionallyRender             condition={!!customComponents?.botChatMessage}             show={callIfExists(customComponents?.botChatMessage, {.               message,               loader: <Loader />,             })}
I saw this on the codebase of the bot message component, Is it intentional or is this a bug?

I propose an implementation here: https://github.com/FredrikOseberg/react-chatbot-kit/pull/178

@FredrikOseberg any chance this can be reviewed?

hi @FredrikOseberg Please review this. I think this is very necessary.
Thanks!

Hi @FredrikOseberg, can you please review this? I agree with everyone else that it's incredibly useful, in my case to integrate this chatbot with react-markdown to parse responses with markdown content.


Data loading time has increased since Spring boot update

The data loading time has significantly increased after the recent spring boot update.

The increased time is related to model persisting, see testing log snippet:
Reading file /Users/csaba/PDXFinder_data/pdxfinder-data/data/UPDOG/IRCC-CRC/expression/IRCC-CRC_expression_CRC0598LM.tsv finished after 0 second(s) :227ms
Domain object creation finished after 0 second(s) :216ms
Persisting finished after 20 second(s) :20280ms

This is fixed now


Resolve https://github.com/dswah/pyGAM/issues/301

Instead of filling with zeros in _flatten_mesh and generate_X_grid create an X matrix with constant rows given by the midpoint of the edge_knots so they values will be valid.
-Also centered output of partial_dependence as the Y-axis is meaningless.

thanks for this!!
im updating master to use the latest build dependencies...


Remove version: ProtonTechnologies.ProtonVPN version 2.3.2

duplicate
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/ProtonVPN/win-app/releases/download/2.3.2/ProtonVPN_win_v2.3.2.exe
OK
(Automated message - build 882)


Sending an empty body will bypass the validation

Sending a POST request with an empty body will bypass the validation and still call the controller, even if your DTO has #[Assert\NotBlank] decorators. This is counter intuitive and can lead to bugs since the controller is expecting a filled DTO.

I'm going to reproduce and push a fix soon. Thanks, @Alexandre-Fernandez to report it.

@Alexandre-Fernandez I couldn't reproduce this issue. If you could provide me with these details that would be great
PHP version
RequestInputBundle version
Request ContentType
A snippet code of invocable or action controller
Meanwhile, I can see 4 ways to bypass resolving and validating the input argument:
RequestInputBundle is disabled (it's enabled by default)
skip_validation config option is enabled  (it's disabled by default)
the input DTO class not implemented the interface "InputInterface"
the request content type is not one of the supported formats "application/json, application/xml, multipart/form-data"

I tried making a reproduction repository and after further testing it seems that this only happens when the Content-Type header is missing.
If possible it would be nice to still have an error for this such as ["title" => "Deserialization Failed", "detail" => "Wrong format"].

Thanks @Alexandre-Fernandez, You're right this is actually a bug. I will fix it and release a patch soon

Issue fixed.
throw UnsupportedMediaTypeHttpException in case Content-Type header is missing or unsupported.

great thanks


[feature] #3941: Remove expressions

Description

The main idea was to move all expressions into executor. After a discussion with @mversic we decided not to implement any of them inside default_executor, but to have an example executor to show PoC.

All expressions were removed
#[model] together with ffi have become useless for data_model because in future clients should link against executor_data_model. So I partly removed them. This might need future investigation

I wii squash all my commits before merge.
Linked issue

Closes #3941

Benefits

Much less code
No stillborn expression system inside data_model and core
Types for ISI now can't contain unsupported parameters

Follow up tasks

Reconsider ffi for data_model
Make block content opaque
Write example executor with expressions or even DSL

Checklist

[x] I've read CONTRIBUTING.md
[x] I've used the standard signed-off commit format (or will squash just before merging)
[x] All applicable CI checks pass (or I promised to make them pass later)
[ ] (optional) I've written unit tests for the code changes
[ ] I replied to all comments after code review, marking all implemented changes with thumbs up

#[model] together with ffi have become useless for data_model because in future clients should link against executor_data_model. So I partly removed them. This might need future investigation

I'm not sure about that because executor and host has to interact somehow and in this case ffi could be a way to go, no?

#[model] together with ffi have become useless for data_model because in future clients should link against executor_data_model. So I partly removed them. This might need future investigation

I'm not sure about that because executor and host has to interact somehow and in this case ffi could be a way to go, no?

no, the point of FFI was to reduce smart contract size. Executor size is irrelevant because upgrading it is a rare operation. So we will use FFI only for communication between smart contract and executor

@mversic @Arjentix
Ok, i realized that i probably confuse things.
Ffi would be used to dynamically link smart contract to data model, but interaction between host and smart contract would still by encoding and decoding data in wasm  linear memory. Is that correct?

So this means that iroha data model should be ffi compatible as well?

Yes, looks like we are back. Also noted by Marin here

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

165 of 1045 (15.79%)  changed or added relevant lines in 34 files are covered.
6579 unchanged lines in 125 files lost coverage.
Overall coverage decreased (-3.0%) to 56.394%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cli/src/torii/mod.rs
0
1
0.0%

core/src/smartcontracts/isi/account.rs
1
2
50.0%

core/src/smartcontracts/isi/asset.rs
0
1
0.0%

core/src/smartcontracts/isi/domain.rs
1
2
50.0%

core/src/smartcontracts/isi/tx.rs
1
2
50.0%

core/src/smartcontracts/isi/world.rs
0
1
0.0%

schema/gen/src/lib.rs
6
7
85.71%

genesis/src/lib.rs
12
14
85.71%

schema/derive/src/lib.rs
16
18
88.89%

smart_contract/src/lib.rs
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

config/base/derive/src/view.rs
1
99.37%

config/src/block_sync.rs
1
95.0%

config/src/network.rs
1
93.75%

config/src/torii.rs
1
95.45%

config/src/wasm.rs
1
87.5%

config/src/kura.rs
2
79.41%

config/src/lib.rs
2
0.0%

ffi/src/option.rs
2
71.43%

config/src/genesis.rs
3
72.92%

data_model/derive/src/has_origin.rs
3
95.16%

Totals

Change from base Build<PHONE_NUMBER>:
-3.0%

Covered Lines:
22081

Relevant Lines:
39155

💛  - Coveralls


[PRP-253] Fixes from live UAT on 2023-03-22

Ticket
https://wicmtdp.atlassian.net/browse/PRP-253
Changes

What was added, updated, or removed in this PR.

Generally:

Switch all cases of t() to <Trans> where possible to support basic html tags in i18n strings
Enable support of <em> tags in i18n strings
Swap <div> tags around paragraph content to <p> tags
Alphabetize sections in en/common.json
Remove hard line break in site name
Change font from Source Sans Pro to Public Sans
Update body line height to 1.5em
Create a .intro class for intro paragraphs on pages
Create a .legend-large and .label-large class for our large labels/legends
Adjust misc spacing

Components:

AdjunctiveInput: Use new <List> component
DateInput: Support optionally setting the input as required fields
ParticipantCard: Support optionally setting the <AdjunctiveInput>, <DateInput>, and <RelationshipInput> components as required fields
RequiredQuestionStatement: Add new component for the help text that explains required fields have asterisks
TextField: Support optional className argument

Pages:

Add <RequiredQuestionStatement> to all pages with required fields
Count: Use type=number, set max width on the input field, use the .label-large class
Details: Make all fields required except for preferred name, turn on date hint, turn on preferred name input, add missing i18n strings
Name: Remove extra content

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

These changes came out of our Live UAT session on 2023-03-22.
Testing

Screenshots, GIF demos, code examples or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Review the chromatic storybook

The spacing between the DOB field and "Are they enrolled in these other programs"? is very tight.

Can we overwrite the line length for "How many people..." so it's similar to measure-6?

@makaelastephens

The spacing between the DOB field and "Are they enrolled in these other programs"? is very tight.

🤔 I'll take a look at that.

Can we overwrite the line length for "How many people..." so it's similar to measure-6?

This is the USWDS standard form label max-width. Do you want to change it across the board?

@rocketnova

This is the USWDS standard form label max-width. Do you want to change it across the board?
Yes, we want to change it across the board. Checking the galaxy brain notes, unfortunately we didn't write down what we wanted the override to be so let me know if you need more eyes later.

@makaelastephens

The spacing between the DOB field and "Are they enrolled in these other programs"? is very tight.

🤔 I'll take a look at that.

@makaelastephens Turns out this is a known USWDS bug when you use legends without labels in fieldsets 😞 I'll do some custom CSS'ing to fix

The changes noted in the comments above now look as expected to me 👍.


Enhance support for structured data

At the moment there is only support for Organization (as the owner of the site) and Article/ BlogArticle.
It would be nice to be able to select a structured data type per post type.

This is already handled in #14 and #15


Add support for viewing the canvas at a point in the past

Just a matter of using the ledger version.

This is not possible with the current indexer based solution, it'd have to be some funky time series DB.


luci-mod-admin-full: update IPv4/IPv6 list views

For better view of 'Interface Overview' IPv4/IPv6 addresses for
interfaces should be displayed as lists, but not as comma separated
strings.
Signed-off-by: Alexander Logger<EMAIL_ADDRESS>

Not sure if lower case for IPv6 is correct, but almost everywhere I see IPv6 it is lower-cased.

I applied your patch to the file in a live router, and the address list looks better (especially the multiple ipv6 addresses)  ;-)


Added package provider and alias declarations to composer.json

Added package provider and alias declarations to composer.json to take advantage of the auto discover feature in Laravel >= 5.5. Updated README.md to reflect this change.
https://medium.com/@taylorotwell/package-auto-discovery-in-laravel-5-5-ea9e3ab20518

Awesome, thanks! I created a new release, 2.1.


Add a failed test for new line style sample

Ref https://github.com/redpen-cc/redpen/issues/840

Coverage decreased (-0.01%) to 91.303% when pulling 06a01eac40781befe6cf72b49039da502241656c on takahi-i:new-line-style-rest into 31aff57a34bc3b1de3f4dcde7f4af9d4d5e11c96 on redpen-cc:master.

Coverage decreased (-0.01%) to 91.303% when pulling 06a01eac40781befe6cf72b49039da502241656c on takahi-i:new-line-style-rest into 31aff57a34bc3b1de3f4dcde7f4af9d4d5e11c96 on redpen-cc:master.


Add commands for web

This PR:

integrates commands into the example app
maps the suggestions output from the useWysiwyg hook to make them easier to use on the JS side of things
adds test for the new functions relating to suggestions
adds types for the new MappedSuggestion type

LGTM
BTW, any idea what changed with sonarcloud ? It seems to complain way more than before, including on main

Sonarcloud will now always complain about coverage, because it isn't run with coverage turned on (so it gets a 0).
Unfortunately, the upgrades I did to various pieces to get the coverage running ok stops us being able to use the output from this repo in element web, so I had to revert the changes.
When I get a chance, I'll do that upgrade again as a single job, making sure it works for element web too, then we'll be able to get the coverage turned back on.


last update - still continued?

hi
SCIPIO seems a great ERP!
last update was in 2019, is it still maintained?
🤞

Hey,
Glad you asked - yes absolutely!
We just haven't made it an official release yet, as we have worked so hard on many major changes that are all adding at the same time (new annotation based service definitions, major changes to the CMS, various add-ons, a new Bulma based default theme etc etc).
There's going to be a release coming shortly.
If you take a look at the news from our website you'll also see how busy we've all been with these changes, so bear with us :)

So for now we recommend to go with the master/main branch and take it from there. It is stable :)

nice to read! so you reckon the 2019 version of scipio is safe enough to be installed today.
Quid of the docker image? You still don't recommend to use scipio with docker?

We do encourage you to fork from the main branch, however, and update from there occasionally.
Like I said, the 3.0 release will be coming out shortly and it's been years in between, so master is probably a better candidate by now.
That said, in the future we will probably move away from long release cycles and rather tag releases more often. Simply because otherwise er fall into the trap that we keep adding new things (as we did now).
You can use Scipio in docker too. We got a docker branch that sets you right up. So that's all good by us. Really depends on your own CI flow.

I have to add: in most cases you really do want to fork and regularly pull from us, simply because you will eventually want to add your own application and modifications to it.
If you add your own code in customs apps under hot-deploy, you won't really have to deal with difficult merges at all (except for the occasional properties file you have changed on your end to fit your need better, like cache.properties or default.properties).
So it becomes easier to stay up to date and really turn the system into your own.

hey thanks a lot @madppiper for all those information and your concern
i'm afraid i'm not ready yet to do so, cause i've never done this
I usually use Portainer to deploy apps, but I'm not competent to fork, update, personnalise ..
I can just take things the way they are, and work around their installation
I guess I need to update my skills to be able to use SCIPIO once !
thanks again ✌


IOError: [Errno 19] No such device

Hi,
When I run the following script, an error occurs, can you help me solve it，thanks！
python GetHostInfo.py
Traceback (most recent call last):
File "GetHostInfo.py", line 18, in
print(getHwAddr('eno1'))
File "GetHostInfo.py", line 10, in getHwAddr
info = fcntl.ioctl(s.fileno(), 0x8927, struct.pack('256s', ifname[:15]))
IOError: [Errno 19] No such device

Hi,
This appears to be an error caused by a mismatch in network card types.
Use the ifconfig command to see what type of network card you have, and then replace it in the GetHostInfo.py line16.

Thank you, I got the MAC address by UUID to solve this problem

I've tried to get the MAC address using UUID, but in python2 and python3 the MAC address is not the same.

The following code obtains the MAC code by UUID. The test results on python2.7 and python3.6 are the same.
import uuid def get_mac_address():     node = uuid.getnode()     mac = uuid.UUID(int = node).hex[-12:]     return mac


UX issues

From the feedback on Reddit thread:

Click the top right hand button to show a bottom sheet? That makes no sense and feels really strange. Perhaps that button should close the right hand pane. A user of that site might not always need to see the messages, so giving them more screen real estate for content that matters would be much better.
Also, the menu directive that pops up when you click on the user's name is misplaced. It should be aligned to something, not just arbitrarily thrown in the mix. You can use the ng-offset directive to move it around to a better position.

The 'Remove Completed' on the task list. It sits next to the plus Icon. It looks like the label for the plus icon. I was confused as to why a plus meant remove. They need to be more clearly two separate controls.

Not being able to remove the messages list is annoying

Clicking on the add task button adds an empty task that can't be edited. I had no feedback that I should enter text before clicking that button, and I shouldn't be able to click it when there is no text. The button and the text input should be better combined into a single control. And you should be able to edit the text of tasks.

I propose this layout changes: http://gaykov.github.io/angular-material-dashboard/site/#/dashboard
@micrum give your feedback please

@gaykov looks good, especially TODO-list! Please, prepare PR
One comment: overlay and sidebar not covers all screen height upon scroll.

@gaykov this look great.
I've noticed one more thing: when moving between pages  (for example from Dashboard to Profile) in bottom right corner we can see notification showing current page (md-toast). Unfortunately on pages without scroll-bar when notification is showing scroll-bar appear when notification is showing and hiding
This is visible on Profile page.
Could You fix this?

@Misiu hello, thank you for your comment! But I can't reproduce this error. Could you please tell which browser do you use?

I see on demo page that toast are showing in top right corner (this was recently changed). Now all scrollbars are showing correctly.
Thanks for fix :smile:


create a markdown file to put the courses in alphabetic order

The courses must be in order
Which course must have
Name | Topic | Languague | Content | year

Hi I am going to start this one, ok ?

I would like to contribute, can you elaborate the issue and which courses?


Add support for common DifftestTopIO

Add LogPerfControl
Force all DiffTest IOs to have prefix of difftest_

It seems Perf and Log IOs are coupled with the simulation framework in DiffTest. We should move them from utility to DiffTest to allow anyone who do not use utility but want to use the log/perf interfaces. Probably we can migrate the XiangShan log/perf interface code to this new Top IO provided by Difftest. @Tang-Haojin
I'm now using difftest like this:
For customized perf/log IO:
object PerfAccumulate {
  def apply(perfName: String, perfCnt: UInt) = {
    val control = LogPerfControl()  // call DiffTest.LogPerfControl to get the control bits from difftest

    val counter = RegInit(0.U(64.W)).suggestName(perfName + "Counter")
    val next_counter = WireInit(0.U(64.W))
    next_counter := counter + perfCnt
    counter := Mux(control.clean, 0.U, next_counter)

    when (control.dump && control.logEnable) {
      printf(p"[cycle=${control.timer}] $perfName: $next_counter\n")
    }
  }
}

For the top (SimTop):
    val difftest = DifftestModule.finish("Piper") // It will instantiate the top IOs to interact with DiffTest
    difftest.uart <> mmio.io.uart


Set stretches to the minimum cost supported by the bcrypt algorithm in tests

During generating and setting encrypted_password by default BCrypt::Password.create is used. At the moment in the test environment the cost is set to 1. It is passed to BCrypt::Password.create and later set to 4 (BCrypt::Engine::MIN_COST) (1 -> 2). Observing encrypted_password being generated with the cost 4 while the cost 1 is specified via stretches may be confusing.

I rebased over the latest master to resolve minor merge conflicts.

@carlosantoniodasilva all checks have passed, no merge conflicts. Can you merge this?


Add wss protocol to the whitelist

Test Studio was not running in my tenant.
It began working when my team added a specific URL to the wss protocol on the whitelist.
Test Studio need wss communication and it is not included on this document ( Required services )
https://learn.microsoft.com/en-us/power-apps/limits-and-config#required-services
Hope that helps.
Fernando Hunth

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6fdf0872-929b-e44a-dedd-eb6a759915f2
Version Independent ID: 0b65b025-62f8-fc2a-0026-3cb96b7b4554
Content: Power Apps system requirements and limits - Power Apps
Content Source: powerapps-docs/limits-and-config.md
Service: powerapps
Sub-service: canvas-maker
GitHub Login: @lancedMicrosoft
Microsoft Alias: gregli

Thanks for your comment, @fhunth. This issue has been assigned to the doc author for review.


F5 to start debugging not working with Extension debugging

VSCode Version: 1.1.0-alpha
OS Version: Windows 10

Steps to Reproduce:

Use yo code to generate a Code extension (Javascript)
Open the extension folder
Navigate in Explorer to extension.js and open it (you can make changes, but it is not necessary)
Press F5

Nothing happens. It works before opening extension.js but after the key just doesn't work to start debugging.

Can not repro on win10 neither on mac.
Are you still seeing this, if yes can you start debugging by clicking on the green play icon?
Can you start debugging if you bind some other keybinding to start debug action?


Please proof-read the Doc on the Website

I understand the challenge has just started and the developer team has a lot of things to do, but as someone who just came to this competition, the current intro on the main website is not showing itself as a "high-quality" competition because of the typo/grammar issues. I believe this can be changed with little effort.
Some of the easily noticed grammar issues:

These are just some that I noticed, but I'm sure a simple proof read by a native speaker will suffice and make the website looks more professional!

thanks for finding these! we will fix soon

Do you have a suggestion for the first screenshot actually? It doesn't appear to be a grammar issue.

Do you have a suggestion for the first screenshot actually? It doesn't appear to be a grammar issue.

I actually didn't get exactly what does it mean until I re-read it now several times.
I would say sth like:
"Each game, you are given a pool of 60 seconds to compensate for the excessive time beyond the 3-second limits. After the pool is used up, your agent will freeze when going over the limits again and can no longer ..."
Also, "3-second" (with a -) limit, if you'd like to use it as adj to describe the limit.


Inadequate number of connections

As reported by Karl:

The number of total connections and the number of outgoing connections isn’t correct.
The node is configured to have 50 warm peers, and it has one client.
lsof confirms the expected 51 connections.

slack thread

This might be due to the bug that @karknu found on ConnectionManager (slack thread)

I suspect that this is a separate issue.

I think they might be related, it boils down to a problem in the connection manager state since the counters calculation is pure

@karknu this has happened again, right? Any new info you can provide?

It hasn't happened since I upgraded the devnet to 27d01fb0c15e2c092b3642fc7ec0303716739595 , it is possible that #3167 fixed the issue.

Fixed in #3167 .


make sure the tooltip stays in window-space when loading positions

When skinnytip is used in an iframe, it often happens that the tooltip floats out of the iframe-window.
This fix checks the current window-width and repositions the tooltip if nessesary

Thanks @danielsun174 - merged!


pick_random in action_selectors

Thanks to the author for the open source code, I have a question when I was reading the source code.
In the action_selection operation, Qmix add a pick_random * random_actions,
I guess this is a disturbing term, But, I'm not chear that why the random_numbers only come from agent_inputs[:,:,0], I think the value of agent_inputs[:,:,0] point to the probability of action 0?
Anyone could help me to make it clear. Thanks

picked_actions = pick_random * random_actions + (1 - pick_random) * masked_q_values.max(dim=2)[1]
https://github.com/oxwhirl/pymarl/blob/master/src/components/action_selectors.py
def select_action(self, agent_inputs, avail_actions, t_env, test_mode=False):

	# Assuming agent_inputs is a batch of Q-Values for each agent bav
	self.epsilon = self.schedule.eval(t_env)

	if test_mode:
		# Greedy action selection only
		self.epsilon = 0.0

	# mask actions that are excluded from selection
	masked_q_values = agent_inputs.clone()
	masked_q_values[avail_actions == 0.0] = -float("inf")  # should never be selected!

	random_numbers = th.rand_like(agent_inputs[:, :, 0])
	pick_random = (random_numbers < self.epsilon).long()
	random_actions = Categorical(avail_actions.float()).sample().long()

	picked_actions = pick_random * random_actions + (1 - pick_random) * masked_q_values.max(dim=2)[1]
	return picked_actions

I got it, move to close. :)


.Net: Add home automation example to demonstrate how to use DI in a real app

Motivation and Context
We want to give a template or starting point for people to get a solid idea of how to use SK in their own apps.
Description
Add the Home Automation example
Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

Could we add a .vscode folder with the necessary files so a developer can press the run button to test the sample