bug: LazyGit not working with latest version and neovim-ayu theme

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.9.5
Operating system/version
Arch Linux
Describe the bug
E5108: Error executing lua: ...cal/share/nvim/lazy/LazyVim/lua/lazyvim/util/lazygit.lua:42: standard file is closed
stack traceback:
	[C]: in function 'write'
	...cal/share/nvim/lazy/LazyVim/lua/lazyvim/util/lazygit.lua:42: in function 'set_ansi_color'
	...cal/share/nvim/lazy/LazyVim/lua/lazyvim/util/lazygit.lua:47: in function 'update_theme'
	...cal/share/nvim/lazy/LazyVim/lua/lazyvim/util/lazygit.lua:32: in function 'lazygit'
	...l/share/nvim/lazy/LazyVim/lua/lazyvim/config/keymaps.lua:128: in function <...l/share/nvim/lazy/LazyVim/lua/lazyvim/config/keymaps.lua:128>

Steps To Reproduce
Use LazyGit with space + gg when in a Git repo with the latest LazyVim version. (commit: 20efdd44da9473b23aba503de2865fb0b1868fd4)
I also have this in my plugins dir:
return {
    {
        "Shatur/neovim-ayu",
    },
    {
        "LazyVim/LazyVim",
        opts = {
            colorscheme = "ayu",
        },
    },
}

Expected Behavior
LazyGit to open successfully.
Repro
No response

Can't reproduce. This is what I get with your configuration
return {
    {
        "Shatur/neovim-ayu",
    },
    {
        "LazyVim/LazyVim",
        opts = {
            colorscheme = "ayu",
        },
    },
}

That seems to fail becasue your stdout stream of Neovim is closed.
No idea why that might be.
Just updated this to pcall it instead. Should no longer error (but you'll be missing one color override)

Have installed the #2831 release and there still might be an issue going on with the LazyGit change. I can't see the error message when I use gg because the window disappears too quickly but if I open a term split and try to type lazygit here, in the same directory mind you, it says "2024/03/26 09:51:02 CreateFile WARNING: at : The filename, directory name, or volume label syntax is incorrect."

You should have a file created in the equivalent for Windows ~/.cache/nvim/lazygit-theme.yml. Does it get created? Maybe it has to do with the different Windows path separator and it should be accounted for in the M.theme_path?

You should have a file created in the equivalent for Windows ~/.cache/nvim/lazygit-theme.yml. Does it get created? Maybe it has to do with the different Windows path separator and it should be accounted for in the M.theme_path?

This directory did exist but was empty when I checked it just now.

What does :echo stdpath("data") show for you in Windows?

@dpetka2001  C:\Users\MyUserName\AppData\Local\nvim-data

In that folder can you open the file lazy/LazyVim/lua/lazyvim/util/lazygit.lua and change line 10 to M.theme_path = vim.fn.stdpath("cache") .. package.config:sub(1, 1) .. "lazygit-theme.yml" and check if it then works?

copy and pasting my current line just in case I typoed something but with this change, no dice.
M.theme_path = vim.fn.stdpath("cache") .. package.config:sub(1, 1) .. "/lazygit-theme.yml"

Remove the forward slash from string lazygit-theme.yml. It should just be M.theme_path = vim.fn.stdpath("cache") .. package.config:sub(1, 1) .. "lazygit-theme.yml"

right, that might be it.
Your issue reported you used Arch Linux, but so this is on Windows?
Did @dpetka2001's edit fix it?

@folke This is a different user than OP, hence the different OS (Windows).

Yes, different user, yes Windows 10, sorry for the confusion thought it would be better than spamming a new issue of the same type. did not fix, going to revert to yesterday's lazyvim version quick to make sure I didn't do something else.

It would be useful if you could provide the error that happens then. This was just an assumption from my part since you use Windows.

After trying to invoke lazygit, what does :=vim.env.LG_CONFIG_FILE show?

Same Error as initially posted,

2024/03/26 09:51:02 CreateFile WARNING: at : The filename, directory name, or volume label syntax is incorrect.

New breakthrough in debugging.
Lazygit does not work with this new option set
LazyVim.terminal.setup("pwsh")
if I comment that out, restore to the latest version of lazyvim without all the above suggested changes and instead use the following...Lazygit now works
vim.o.shell = "C:/Users/ARK010/scoop/apps/git/current/bin/bash.exe"
local gitbash_options = {
  shell = vim.fn.executable("C:/Users/ARK010/scoop/apps/git/current/bin/bash.exe") == 1
    and "C:/Users/ARK010/scoop/apps/git/current/bin/bash.exe",
  shellcmdflag = "-c",
  shellredir = ">%s 2>&1",
  shellpipe = "2>&1| tee",
  shellquote = "",
  shellxquote = "",
}

for option, value in pairs(gitbash_options) do
  vim.opt[option] = value
end

After trying to invoke lazygit, what does :=vim.env.LG_CONFIG_FILE show?
I am sorry for how ugly this output looks, there appears to be some escaping issues.

10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[33;1mWARNING: at <ScriptBlock>, C:\Users\ARK010\Documents\Powershell\Microsoft.PowerShell_profile.ps1: line 116
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE at <ScriptBlock>, <No file>: line 1
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[31;1mSet-PSReadLineOption: ^[[0mC:\Users\ARK010\Documents\Powershell\Microsoft.PowerShell_profile.ps1:116^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[31;1m^[[0m^[[36;1mLine |^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[31;1m^[[0m^[[36;1m^[[36;1m 116 | ^[[0m ^[[36;1mSet-PSReadLineOption -PredictionViewStyle ListView^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[31;1m^[[0m^[[36;1m^[[36;1m^[[0m^[[36;1m^[[0m^[[36;1m     | ^[[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[31;1m^[[0m^[[36;1m^[[36;1m^[[0m^[[36;1m^[[0m^[[36;1m^[[31;1m^[[31;1m^[[36;1m     | ^[[31;1mThe handle is invalid.^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[33;1mWARNING: at <ScriptBlock>, C:\Users\ARK010\Documents\PowerShell\Microsoft.PowerShell_profile.ps1: line 116
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE at <ScriptBlock>, <No file>: line 1
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[31;1mSet-PSReadLineOption: ^[[0mC:\Users\ARK010\Documents\PowerShell\Microsoft.PowerShell_profile.ps1:116^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[31;1m^[[0m^[[36;1mLine |^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[31;1m^[[0m^[[36;1m^[[36;1m 116 | ^[[0m ^[[36;1mSet-PSReadLineOption -PredictionViewStyle ListView^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[31;1m^[[0m^[[36;1m^[[36;1m^[[0m^[[36;1m^[[0m^[[36;1m     | ^[[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE ^[[31;1m^[[0m^[[36;1m^[[36;1m^[[0m^[[36;1m^[[0m^[[36;1m^[[31;1m^[[31;1m^[[36;1m     | ^[[31;1mThe handle is invalid.^[[0m
10:58:40 AM msg_show   vim.env.LG_CONFIG_FILE C:\Users\ARK010\AppData\Local\lazygit/config.yml,C:\Users\ARK010\AppData\Local\Temp\nvim/lazygit-theme.yml

Here is that line of code from the Powershell Profile that was referenced as line 116 Set-PSReadLineOption -PredictionViewStyle ListView
When I commented this line out, Lazygit started working with LazyVim.terminal.setup("pwsh") being set again.

Instead of just commenting out
Set-PSReadLineOption -PredictionViewStyle ListView
I changed it to
Set-PSReadLineOption -PredictionViewStyle InlineView for now and Lazygit works inside of neovim. I am fine with this fix. I know it can be difficult to make things work across all these platforms.

Can this be passed as shellcmdflag in LazyVim.terminal.setup()? Unfortunately, I don't know much about Windows. Also, is my suggestion still needed or it works without it? You should undo the change you did in the data folder of LazyVim, so you don't have any problems with updating.

I just logged in on my Windows machine, also using pwsh and everything works as expected for me

Also in Microsoft docs it says

Sets the style for the display of the predictive text. The default is InlineView.
InlineView - the style as existing today, similar as in fish shell and zsh. (default)
ListView - suggestions are rendered in a drop down list, and users can select using UpArrow and DownArrow.

Is it safe to assume this is the default option and you changed it yourself?

Correct, I changed the default InlineView to ListView in my Powershell profile, since everything works just fine with InlineView I am good with the current self-fix. I am also okay with using git-bash as well! I have reverted all of my changes that you suggested @dpetka2001 because they were not needed to fix the issue. At least this information is here in case another windows user comes nocking. Thank you both for the help!

Closing, since op's original issue can no longer happen


Remove unecessary Ord bound

Hello, I noticed that this bound is not actually required anywhere, and it makes it harder to diff custom types. Please tell me if I'm missing something and that it can't be removed.

Ok, sorry for the noise.


Dots keep appearing even if it's one slide Version 1.7.1

short description of the bug / issue, provide more detail below.
Dots keep appearing even if it's one slide "this problem if not mistaken appears only on 1.7.1 version I had to downgrade to 1.6.0 to get rid of the dots. thanks and all the best to slick team nice job!! "
====================================================================

[  paste your jsfiddle link here  ]
This is my jsfiddle-link:
http://jsfiddle.net/fmo50w7n/1350/
use this jsfiddle to reproduce your bug:
http://jsfiddle.net/simeydotme/fmo50w7n/
we will likely close your issue without it.
====================================================================
Steps to reproduce the problem

Add a single slide to the slider
set dots: true
Run the script ;)

====================================================================
What is the expected behaviour?
For single-slide sliders the dot-navigation should be hidden
====================================================================
What is observed behaviour?
Dot-navigation are added, even if there is only one slide in the slider.
====================================================================
More Details

Which browsers/versions does it happen on? *
Which jQuery/Slick version are you using? 1.7.1
Did this work before? When downgrading to 1.6 it works as expected.

I updated my bug-descreption. Thx.

it seems like it thanks for your effort Sir!

Should be fixed now. Thanks!

Uhm, I still get it with version 1.8.1

Version 1.8.1 solves this problem. However, OP has only updated slick.js and not slick.min.js. Use slick.js in your stack for now.

Use ":only-child"  selector

This issue still persists in the min.js versions hosted on various CDNs.
I do find it hard to understand why the two files are not identical.

Noting this issue still persists in the min.js version. Works perfectly - even with slidesToShow settings at different breakpoints with the slick.js (non minified) version.

I can confirm that this issue still presists in the distributed minified version.

Thanks for posting a solution for this. The min.js version problem still exists.

Hello to all!
Do you have an idea when the minified version will be available?
Thanks!

Just to let you know... We've used the non minified version but our custom inline styles on each of our slides were removed between 768px and 1199px by the slick scripts... The minified version of slick does not have the bug... Can anyone confirm?

What about to release the functionality in the minified version too?

This is still a bug - switching to the non-minified version resolves the issue for us. We compile everything using Yarn so we don't necessarily need the minified version but that was a decent hour I'll never see again! 🙃

The problem is with the slick-dotted class which is getting added even if there is one item in the slick. and slick-dotted class is adding margin-bottom of 30px.
@wecreatedigital Thanks for the suggestion, switching to the non-minified version resolves the issue for me as well.

This is still a bug - switching to the non-minified version resolves the issue for us. We compile everything using Yarn so we don't necessarily need the minified version but that was a decent hour I'll never see again! 🙃

Thanks! I just grabbed the non-minified .js file (https://raw.githubusercontent.com/kenwheeler/slick/master/slick/slick.js) and ran it through https://javascript-minifier.com and now it works perfectly.

Hi
This issue has been solved in the master branch but there is no new tag released with the fixed minified version. Can we please reopen this until there is a new tag release.


Add world id sign in

Add world id sign in
add faqs

#366  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jvmi7 and the rest of your teammates on  Graphite


add elasticsearch ci

Checklist

[ ] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[ ] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

I'm not sure why we should add this here

Is it because it's not used often?
Just curious

It's just used for one module. It should stay in that repo.

Its just an offer. Probably would remove that github action in the corresponding repo and replace it with the service entry in the github workflow.

It's just used for one module. It should stay in that repo.

This is also the case with the MongoDB, Postgres, and MySQL workflows
Now, following the same logic, it makes sense to move them to the repos where they're used; however, if we merge https://github.com/fastify/workflows/pull/124 and centralize most library CIs too, it could be more efficient in the long term to take it one step further and centralize everything as much as possible
Right now, there is no consistency to when we put a workflow here or to a dedicated repo
Benefits:

When creating a new repo that will use kafka, mysql, etc., maintainers will know where to look first before thinking about creating a custom workflow
When the time comes to modify the generic workflow, it will be easier to also update its flavors

So I propose that we:

centralize all workflows that follow this generic structure and add one simple thing/feature to it
only create a dedicated workflow in a repo if it requires significant modifications to the generic workflow

So, in summary, I believe we should merge this and and #113, or remove the other workflows from this repo as well...

I would not have this here, but in the elasticsewrch repo

Please see the arguments and reasoning at https://github.com/fastify/workflows/pull/114#issuecomment-2067776753
In this repo, there already exists the MongoDB, MySQL, and PostgreSQL workflows that are only used once — in fastify-mongodb, fastify-mysql, and fastify-posgres respectively, we should remove those from here as well then
But I'm arguing that it's actually easier to manage this way, look at https://github.com/fastify/workflows/pull/116 where all it took was one PR to add BlueOak support to the main workflow and all its flavors, this is just another flavor of that main workflow
If a repo really requires a custom workflow radically different from the main workflow, then I'm not against putting it in its repo, but in general things will become easier to manage in my opinion


Unique numbering

Hello, please how do i generate a unique numbering for an entity, example creating member registration number or an account number for a client
something like (DDMMYYY001BRCODE) --><PHONE_NUMBER>18DF009)

See https://github.com/volkanceylan/Serene/tree/master/Serene/Serene.Web/Modules/BasicSamples/Dialogs/SerialAutoNumber


[FEATURE] Add KTO

🚀 Feature
Implement Kahneman-Tversky optimization, see https://github.com/ContextualAI/HALOs
Motivation
In contrast to DPO, KTO allows for unpaired preferences (see e.g. here: https://github.com/ContextualAI/HALOs/blob/main/trainers.py#L518C1-L519C98), e.g. using a dataset with each model response rated thumbs up/thumbs down.
From https://github.com/ContextualAI/HALOs/blob/main/assets/report.pdf

Todos:

Compare DPO/KTO models from https://github.com/ContextualAI/HALOs
Compare different implementation possibilities. Easiest is probably to add a new column to the Dataframe ("thumbs up/ thumbs down") and either add a sampler or do grouping in the dataset directly (ensuring that ratio preferred vs non-preffered is fixed in each training batch).

Things to consider:

Evaluation when validation dataset contains non preferred data
Handling unbalanced datasets w.r.t. preference

Closed in https://github.com/h2oai/h2o-llmstudio/pull/599


Added support for nanoserver based windows containers

Nanoserver has a much smaller footprint than window server core which make it a great option for any IoT scenario but also perfect anytime a full Windows Server core image is really not needed

The official images do not yet support multistage builds. See https://github.com/docker-library/official-images/issues/3383.  Thanks, the Dockerfiles can still be useful for users that want to build their own nanoserver based images.


Text Cursor issue

After i add text and try to edit it by long click, the cursor on text is positioned to starting instead of this it should be positioned to the end of text. please solve this issue

It's not a library issue.
The TextEditorDialogFragment dialog is implemented as a sample to showcase the use of the libraries API
You can change this behaviour by simply setting cursor position to the end of the of the Edittext like this in TextEditorDialogFragment dialog
mAddTextEditText.setText(getArguments().getString(EXTRA_INPUT_TEXT));
mAddTextEditText.setSelection(getArguments().getString(EXTRA_INPUT_TEXT).length());

Thank you very much..... it worked perfectly

Please close the issue if its resolved


Can't access Ubuntu VM created on ZOS (using flist) when using "mount"

Steps:
Create VM on ZOS using 0-core Client:
name = 'ahmed'
flist = 'https://hub.grid.tf/tf-bootable/ubuntu:latest.flist'
nics = [{'type': 'default'}]
port = {24:22}
config = {'/root/.ssh/authorized_keys': 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDrxj7aUpIFrrmMoKqf07z0k6GY5mt/42ND8cBU1h1PED2L3pZAEWaViQPhHsP77XKQo2W9+TD4BIai65m9Ib4jZy5zbCSIDMlL9ukRaWKuC4QcFl2+Ge2nH1imrn9ZYy2pPMwNvES17Fo9xZIWI8R5KFyZpAsrL5Je1AWFi3aTbtHqPwAKDzyiyqekh8yyMehmRsi3wm17F6M0PJ4r5mlfkCycIMRR3W62UoQM2eQjYKVa1gqN3ZeLrRClmBrF7mIXOzJywdX1tfh+ayZ36F2fFUcm6G8X/xpfQpFbEDds/ohcwvMbYR6JYxC/Ugn4KSeTXk4534wAVtS9xpXDX9oR ahmed@ahmed-HP-ProBook-450-G1'}
mount = [{'source': '/ahmed', 'target': 'share', 'readonly': False}]
client.kvm.create(name=name, flist=flist, nics=nics, port=port, config=config, mount=mount)

Issue:
The VM created with default network but I couldn't access the VM using (ssh).
After searching, the problem was:
Predictable Network Interface Names
when I used 'mount', it added new PCI interface and took name (ensX) which result in the default network interface name changed.
If I don't use mount, I can access it using (ssh).
To solve:
This problem should be handled on the build code of Ubuntu flist (PrefabUbuntu.py) or disable it and go back to unpredictable kernel-native (ethX) naming.

https://github.com/threefoldtech/0-core/pull/135/commits/02093b3bc0a874a099a66946e8043a6f74c4ba8e


Remove redundant elements and code

Found redundant elements and blocks of code. Either remove them or enhance them depending on the functionality.

removed redundant elements and enhanced the user interface


[ApiManagement] Missing 202 Accepted as HTTP response code

In the current stable version of the API Management Service, when doing a PUT on an existing API Management Service, a HTTP 202 Accepted is returned. However, 202 is not defined as a valid HTTP return code for this service. The correct return codes are listed in the preview version, but maybe the stable version should be updated?
Spec in question: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2017-03-01/apimdeployment.json#L206 (missing 202)

Solved with PR #3952


ERROR: Could not find a version that satisfies the requirement clip==1.0 (from versions: none) ERROR: No matching distribution found for clip==1.0

ERROR: Could not find a version that satisfies the requirement clip==1.0 (from versions: none)
ERROR: No matching distribution found for clip==1.0

(controlvideo) G:\GitFork\ControlVideo>pip install -r requirements.txt
Looking in indexes: https://mirrors.aliyun.com/pypi/simple
Collecting accelerate==0.17.1 (from -r requirements.txt (line 1))
Using cached https://mirrors.aliyun.com/pypi/packages/0a/ca/96a50d122bd07d06c66e20e6bd275b5c8829602398f4e141f8755a25e31e/accelerate-0.17.1-py3-none-any.whl (212 kB)
Collecting addict==2.4.0 (from -r requirements.txt (line 2))
Using cached https://mirrors.aliyun.com/pypi/packages/6a/00/b08f23b7d7e1e14ce01419a467b583edbb93c6cdb8654e54a9cc579cd61f/addict-2.4.0-py3-none-any.whl (3.8 kB)
Collecting basicsr==1.4.2 (from -r requirements.txt (line 3))
Using cached https://mirrors.aliyun.com/pypi/packages/86/41/00a6b000f222f0fa4c6d9e1d6dcc9811a374cabb8abb9d408b77de39648c/basicsr-1.4.2.tar.gz (172 kB)
Preparing metadata (setup.py) ... done
Collecting bitsandbytes==0.35.4 (from -r requirements.txt (line 4))
Using cached https://mirrors.aliyun.com/pypi/packages/d4/82/5067d044f7c1c7ddd4f285bfeb062ce3a60f7e39e2a2968df5a06a237b24/bitsandbytes-0.35.4-py3-none-any.whl (62.5 MB)
ERROR: Could not find a version that satisfies the requirement clip==1.0 (from versions: 0.0.1, 0.1.0, 0.2.0)
ERROR: No matching distribution found for clip==1.0

pip install ftfy regex tqdm
pip install git+https://github.com/openai/CLIP.git
it work！

@KaiJia2017 Thanks for pointing it! Fixed it!


NullPointerException

Plugin is throwing null pointer exceptions to the console, noticed this while developing my own plugins while having your plugin enabled.

Checked your code out, variable visibleCompostBin is null, I recommend using @Nullable or Optional<CompostBin>.

Fixed, thanks for letting me know!


How to sync only manually?

Is it possible to sync only manually? I am using the Chronology plugin as well ( https://github.com/Canna71/obsidian-chronology ) and the voicenotes imports make this very cluttered. I would be content with a manual sync whenever I need it.

Added ability to turn off automatic sync with a toggle in settings now in 0.0.18


Problem with the compatible version of mixlib-shellout gem

Good day, im having this problem when im trying to execute any command like chef-solo, knife, etc.
Could you help me with this please ?
C:/Ruby193/lib/ruby/site_ruby/1.9.1/rubygems/specification.rb:1638:in raise_if_ conflicts': Unable to activate ohai-7.6.0, because mixlib-shellout-1.4.0-x86-min gw32 conflicts with mixlib-shellout (< 3.0, >= 2.0.0.rc.0) (Gem::LoadError)         from C:/Ruby193/lib/ruby/site_ruby/1.9.1/rubygems/specification.rb:747:i n activate'
from C:/Ruby193/lib/ruby/site_ruby/1.9.1/rubygems/specification.rb:781:i
n block in activate_dependencies'         from C:/Ruby193/lib/ruby/site_ruby/1.9.1/rubygems/specification.rb:767:i n each'
from C:/Ruby193/lib/ruby/site_ruby/1.9.1/rubygems/specification.rb:767:i
n activate_dependencies'         from C:/Ruby193/lib/ruby/site_ruby/1.9.1/rubygems/specification.rb:751:i n activate'
from C:/Ruby193/lib/ruby/site_ruby/1.9.1/rubygems.rb:1232:in gem'         from C:/Ruby193/bin/knife:22:in '

Its nothing to do with knife-solo.  We also don't support gem installs into user maintained rubies on windows at all, please use omnibus chef or chef-dk artifacts.

Thanks for confirmation @lamont-granquist !


Scroll when selecting text inside debug console

Enable the same behavior as code views inside debug consoles (terminal outupts)
That you are able to auto-scroll when selecting text so you can select huge chunks of the terminal output

Dup of #2163


Rename Graph -> MainGraph

Since Graph is becoming an interface (#7), the current Graph implementation needs to be moved to MainGraph.

Landed in 4f30fda1c7c941cbd5f2bb5e6202da7dcfd77bf3


Adding Persimmon 8B -- apparently the best LLM of that size at the moment

According to some people (and the official release) Persimmon 8B appears to be the most capable LLM of that size class at the moment. It's also fully open-source.
The base model might be particularly interesting to NeurIPS challenge participants. Here are the checkpoint files if we want to add this:

persimmon-8b-chat
persimmon-8b-base

The model definition is at https://github.com/huggingface/transformers/tree/main/src/transformers/models/persimmon
There are some key unimplemented things required:

MLP dropout
QK layernorm in attention
Squared ReLU

We might want to gauge interest first before adding these just for this model.

It's interesting, but maybe not a high priority. Thanks for looking into that!


Bump to Dataproc 2.2 and Flink 1.17 for load tests

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

example workflow
go - https://github.com/apache/beam/actions/runs/11149867620/job/30989710180
python - https://github.com/apache/beam/actions/runs/11150575728/job/30992023968


Support select .. FROM 'parquet.file' in datafusion-cli

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I want to use datafusion-cli to quickly explore a parquet file with minimal typing
Today I first have to type a verbose CREATE EXTERNAL TABLE... command
❯ CREATE EXTERNAL TABLE all_types_tiny_pages STORED AS PARQUET LOCATION './parquet-testing/data/alltypes_tiny_pages.parquet';

❯ select * from all_types_tiny_pages limit 10;
+-----+----------+-------------+--------------+---------+------------+-----------+--------------------+-----------------+------------+-------------------------+------+-------+
| id  | bool_col | tinyint_col | smallint_col | int_col | bigint_col | float_col | double_col         | date_string_col | string_col | timestamp_col           | year | month |
+-----+----------+-------------+--------------+---------+------------+-----------+--------------------+-----------------+------------+-------------------------+------+-------+
| 122 | true     | 2           | 2            | 2       | 20         | 2.2       | 20.2               | 01/13/09        | 2          | 2009-01-13T01:02:05.410 | 2009 | 1     |
| 123 | false    | 3           | 3            | 3       | 30         | 3.3       | 30.299999999999997 | 01/13/09        | 3          | 2009-01-13T01:03:05.430 | 2009 | 1     |
| 124 | true     | 4           | 4            | 4       | 40         | 4.4       | 40.4               | 01/13/09        | 4          | 2009-01-13T01:04:05.460 | 2009 | 1     |
| 125 | false    | 5           | 5            | 5       | 50         | 5.5       | 50.5               | 01/13/09        | 5          | 2009-01-13T01:05:05.500 | 2009 | 1     |
| 126 | true     | 6           | 6            | 6       | 60         | 6.6       | 60.599999999999994 | 01/13/09        | 6          | 2009-01-13T01:06:05.550 | 2009 | 1     |
| 127 | false    | 7           | 7            | 7       | 70         | 7.7       | 70.7               | 01/13/09        | 7          | 2009-01-13T01:07:05.610 | 2009 | 1     |
| 128 | true     | 8           | 8            | 8       | 80         | 8.8       | 80.8               | 01/13/09        | 8          | 2009-01-13T01:08:05.680 | 2009 | 1     |
| 129 | false    | 9           | 9            | 9       | 90         | 9.9       | 90.89999999999999  | 01/13/09        | 9          | 2009-01-13T01:09:05.760 | 2009 | 1     |
| 130 | true     | 0           | 0            | 0       | 0          | 0         | 0                  | 01/14/09        | 0          | 2009-01-14T01:10:05.850 | 2009 | 1     |
| 131 | false    | 1           | 1            | 1       | 10         | 1.1       | 10.1               | 01/14/09        | 1          | 2009-01-14T01:11:05.850 | 2009 | 1     |
+-----+----------+-------------+--------------+---------+------------+-----------+--------------------+-----------------+------------+-------------------------+------+-------+
10 rows in set. Query took 0.039 seconds.

Describe the solution you'd like
I would like to be able to select "directly" from the parquet file in duckdb style
https://duckdb.org/docs/data/parquet.html
SELECT * FROM 'test.parquet';

Describe alternatives you've considered
We could also add the read_parquet UDF that duckdb (and I think clickhouse) support: https://github.com/apache/arrow-datafusion/issues/3773
I actually think it is fine to do both
Additional context
Add any other context or screenshots about the feature request here.

I have the basic plumbing figured out in https://github.com/apache/arrow-datafusion/pull/4581
I now need to polish / etc that PR when I have some more mental capacit


Please add support for H5104 Thermometer/Hydrogmeter

{"device":"CE:1E:D9:38:31:39:27:7B","deviceName":"Basement Thermometer","model":"H5104","httpInfo":{"groupId":12795807,"device":"CE:1E:D9:38:31:39:27:7B","sku":"H5104","spec":"","versionHard":"3.01.01","versionSoft":"1.00.05","deviceName":"Basement Thermometer","deviceExt":{"lastDeviceData":"{}","deviceSettings":"{"temMin":-2000,"temMax":6000,"temWarning":true,"fahOpen":false,"temCali":0,"humMin":0,"humMax":6500,"humWarning":true,"humCali":0,"netWaring":true,"battery":87,"wifiLevel":0,"bleName":"GVH5104_277B","address":"D9:38:31:39:27:7B","secretCode":"eyc5MTjZAAA=","bdType":1,"deviceName":"Basement Thermometer"}","extResources":"{"skuUrl":"","headOnImg":"","headOffImg":"","ext":"","ic":0}"},"share":0,"goodsType":154}}
Thermometer/Hydrogmeter

Hi @davidjbullock
Please install and try the beta version of the plugin:
https://github.com/bwp91/homebridge-govee/wiki/Beta-Version
Thanks!

That seems to do the trick!  The device now shows up.


Could you please tell me how to deduce equation 4 in your paper

Could you please tell me how to deduce equation 4 in your paper?

Hi there, sorry for the late reply.
The most intuitive way to understand that equation is too look at how pairs are aggregated, see code here.


CI: Use v4 of cache actions

GitHub Actions warns us that v3 of this action uses a deprecated version of Node.js.  Upgrading to v4 fixes this issue, and there are no documented compatibility issues between the two versions.  This patch upgrades all cache actions to v4 from v3.

Sounds good!


[Loc] Added all fields required message for sql-migration

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 41.305%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
26184

Relevant Lines:
57501

💛  - Coveralls


Input (feat): add event by clicking icon - [merged]

In GitLab by @victorandre957 on Apr 25, 2022, 19:06
Merges feature/add-event-of-click-in-the-icon-of-input -> 52-add-event-of-click-in-the-icon-of-input

In GitLab by @victorandre957 on Apr 25, 2022, 19:07
mentioned in commit 5c81aeab1050ec2794bf2e99043d9f55250b8170


[hw,uart,sival] Add SiVal testplan for UART

Could you also move the uart-related tests that are currently in chip_testplan.hjson into the new chip_uart_testplan.hjson? We're kind of hoping that we can save effort by using some existing tests to do both :-)

Merged existing integration tests in to chip_uart_testplan.hjson

LGTM modulo the CI errors

I've chopped this around a little bit and will commit everything in #19989, which does something similar. Thanks for doing all the planning work in the first place.


🚀 Feature: Add an option to automatically include built in actions when adding a custom scaffolder actions

🔖 Feature description
This is more of an enhancement than a feature request. This feature would allow users to include built in scaffolder actions when defining a custom action. This will be done via an extra option in the createRouter method of the scaffolder-backend.
🎤 Context
Right now, if I am defining a custom scaffolder action and want to include the built-in actions too, I will need to
const builtInActions = createBuiltinActions({
  integrations,
  catalogClient,
  config: env.config,
  reader: env.reader,
});

const actions = [...builtInActions, myCustomAction()];

return await createRouter({
  actions,
  logger: env.logger,
  config: env.config,
  database: env.database,
  reader: env.reader,
  catalogClient,
  identity: env.identity,
});

This seems a bit redundant to me. Instead of calling createBuiltinActions, which takes in most of the options taken by createRouter, one can pass an extra option to createRouter which then handles the build in actions accordingly.
✌ Possible Implementation
Imagine if we passed an option like includeBuiltinActions: true
return await createRouter({
  actions,
  includeBuiltinActions: true,
  logger: env.logger,
  config: env.config,
  database: env.database,
  reader: env.reader,
  catalogClient,
  identity: env.identity,
});

And in the router.ts at
https://github.com/backstage/backstage/blob/0870577bd4ac6922ff999a0207c2aed71512d499/plugins/scaffolder-backend/src/service/router.ts#L230-L240
we can add something like the following
if (includeBuiltinActions) {
  actionsToRegister.push(
    ...createBuiltinActions(
      integrations,
      catalogClient,
      reader,
      config,
      additionalTemplateFilters,
      additionalTemplateGlobals,
    ),
  );
}

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

I agree the registration of custom actions might be a bit redundant. However, one advantage of the current pattern is you could  override an existing builtin action. This gives the integrator full control over what is used for better or worse.

but this couples the 2 params behaviourally which may be undesirable?

Yeah, that is indeed my only gripe. I would even prefer if I can generate the builtin actions by a function call without passing parameters but I don't see how that can be done. I really don't want to pass the same parameters 2 times in functions that are related to each other.

I haven't been following the new backend system work in too much detail, but it's possible this could be done different as I recall there is the concept similar to the apiRef which might make it more feasible to have a factory function that takes less arguments.

Yep I think it makes sense to leave this for the shape of the scaffolder plugin in the new system tbh.

shape of the scaffolder plugin in the new system tbh.

Do you mean next release of scaffolder?

@SayakMukhopadhyay nah the new backend system, there will be more info about that next week

Personally, I had a good time when I removed most of the built-in actions from our installation. For the most part, because the installed actions page is tricky enough to use as is. And limiting that to the actions that are actually useful is good. We also ordered the actions, so that they have a flow, which doesn't work if you just concat upstream and downstream ;-) .
My goal was to pay a little on the setup cost to boost DX for template authors. Not that I got more template authors yet ;-)

@SayakMukhopadhyay nah the new backend system, there will be more info about that next week

@Rugvip Is this new backend system getting tracked somewhere (as an issue or PR)? I would like to follow up with it. Maybe attach this issue there.

Not stale

@SayakMukhopadhyay The backend system as such is in place since some time back. Now it's up to each plugin to design their interaction surfaces around the new backend system. For the scaffolder specifically, it has this extension point:
https://github.com/backstage/backstage/blob/54f741d1f0229f0b7026f485d48307a8cb33ba8f/plugins/scaffolder-node/src/extensions.ts#L25
You'll find that in its current basic form, it can only do exactly what you wanted, which is to add actions on top of the default ones.
I think this issue might be worth closing, possibly replacing it with a new issue or PR adjusting the extension point if it is found to be insufficient.

I agree on closing this one. I'd like to have the option to define the actually relevant actions, and I also see value in being able to order them. That said, I think ordering is just a cheap way of discoverability and search.

@SayakMukhopadhyay The backend system as such is in place since some time back. Now it's up to each plugin to design their interaction surfaces around the new backend system. For the scaffolder specifically, it has this extension point:

@freben Not sure how to use that extension point in my app though. I can see that https://github.com/backstage/backstage/blob/e0506af8fc54074a160fb91c83d6cae8172d3bb3/plugins/scaffolder-backend/src/ScaffolderPlugin.ts exists which uses the extension point. Right now, I am using createRouter to handle scaffolder just like how the create-app generated
export default async function createPlugin(
  env: PluginEnvironment,
): Promise<Router> {
  const catalogClient = new CatalogClient({
    discoveryApi: env.discovery,
  });
  const integrations = ScmIntegrations.fromConfig(env.config);

  const builtInActions = createBuiltinActions({
    integrations,
    catalogClient,
    config: env.config,
    reader: env.reader,
  });

  const actions = [...builtInActions, runCustomAction({ config: env.config })];

  return await createRouter({
    actions,
    logger: env.logger,
    config: env.config,
    database: env.database,
    reader: env.reader,
    catalogClient,
    identity: env.identity,
    permissions: env.permissions,
  });
}

But I see that ScaffolderPlugin.ts has an implementation of the ScaffolderActionsExtensionPoint interface and is exposing a scaffolderPlugin method which calls the createRouter. And on digging deeper I find that this scaffolderPlugin method is getting called in BackendNext package.
Do I need to use BackendNext for this?


Reserve FactorUpdates Late August

@defijesus does it make sense to increase the Reserve Factor for USDC on the gnosis chain as we had a new USDC listing on gnosis instance.


Bug 2033404: Add source in event

Add source as a required attribute in event.
Update the resource under event.data.values to be resource type instead of the source.

Signed-off-by: Jack Ding<EMAIL_ADDRESS>

/lgtm


Does Agora support user mentioning?

I would like to know if the SDK supports when any of the users is mentioned by his/her name in the chat section?
For e.g. Consider that I'm in a channel with 50 other users. I wanted to mention a user by their name (@ symbol followed by their mobile number)  and then type my message and submit.

i think you will need to do this by you own.


fix: correct argument order

The order of arguments for dvc remote rename is reversed in the old version.
According to the page @ dvc remote rename -h, the old remote name comes first followed by the new remote name argument.

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.
Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Thanks @GavinMasterson !


Sometimes the api reports generic stat selectable gear

Sometimes the api reports stat selectable gear instead of the actual one, also no infusions.
Happens with ascended gear at least, first found on tpot's  'sinister teapot' template 4.
Might be the same issue as #14 .
No clue on how to solve this tbh. maybe the deprecated endpoints report better information ?

Actually this seems to be a known issue: https://github.com/gw2-api/issues/issues/12 . Only proper workaround seems to be to just use the old endpoints, at least the date seems to be correct on those -_-.


Improved the description of Pinot token usage in Swagger

Improved the description in Swagger to include "Basic " or "Bearer " to emphasize the prefix in Authorize screen. The value in authorize must be "Basic tokenblahblah" not just "tokenblahblah"
cleanup
After fix

The description is a CommonMark String, so I have escaped the  to make it visible, check THIS for CommonMark formatting details.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (24a1f9a).
Report is 742 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (24a1f9a). Click for more details.
HEAD has 48 uploads less than BASE

Flag
BASE (59551e4)
HEAD (24a1f9a)

integration
7
2

integration2
3
2

temurin
12
2

java-21
7
1

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
1

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13587       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2483       +47
  Lines        133233   137294     +4061
  Branches      20636    21313      +677
=============================================
- Hits          82274        0    -82274
- Misses        44911   137294    +92383
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
0.00% <ø> (-61.71%)
:arrow_down:

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <ø> (-61.75%)
:arrow_down:

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Extend with an optional help to visualise specific use cases

Hello Johann
First of all: Thanks for your work – clean, well documented and lots of output. I extended your plugin for a project. Basically I added the possibility of an optional help to visualise specific use cases. The whole section content is inside a table to show label, buttons and use cases side by side. Drop me a word if a pull request sounds interesting for you.

Hi Jakob, thanks for the flowers. Much appreciated.
Sounds like a great addition to the plugin. How did you solve it? Adding an example key to the category field set? A PR is the way to go, feel free to open one. 🙂

I decided to go with help instead of example. Keeping the keyword generic and logically similar to Kirby’s solution for various fields – even though it’s slightly different, since help is available on each category:
type: punctuation
headline:
  de: Kleine Interpunktionshilfe
  en: Lil Punctuation Helper
fieldsets:
  - category:
    label:
      de: Apostroph
      en: Apostrophe
    help:
      de: "Alex’ Sachen"
      en: "Alex’ things"
    chars:
      - "’"
  - category:
    label:
      de: Gedankenstrich
      en: Dash
    chars:
      - "–"
  - category:
    label:
      de: Deutsche Anführungszeichen
      en: German Quotation Marks
    help:
      de: "„Das ‚Zitat‘ im Zitat“"
      en: "„The ‚quote‘ inside a quote“"
    chars:
      - "„"
      - "‚"
      - "‘"
      - "“"

Similar to Kirby’s native help we can as well use html e.g. to style it with panel.css:
fieldsets:
  - category:
    label:
      de: Apostroph
      en: Apostrophe
    help:
      de: "Alex’ Sachen"
      en: "Alex’ things"
    chars:
      - "’"

Absolutely! Didn't think of help. Like it a lot. Yes, as native as possible is my approach as well. That's why I re-used the fieldset property.

Just realised that the table is not working on small screen sizes. Maybe flex or grid. I’ll have a look and make a new pull request. Hope everything was okay with my last request, I’m really not that into a GitHub workflow.

That was my initial thought as well. Feel free to update the PR, no need to create a new one! I think you're doing great with GitHub.

This has to be re-implemented for v3. Preferably with container queries.


Feat: fixing css of  companies page

Describe the feature
i can make page look more good by editing css please assign this to me under gssoc @PatilHarshh
Add ScreenShots

i can make this look good
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Go Ahead ! @dhairyagothi

Go Ahead ! @dhairyagothi

Thanku so much


Router unable to match wildcard filter in the middle of a URL

I'm trying to use the :path wildcard filter (as described here) to match part of my URL, which includes a forward slash character. For example, if I have the URL:
/resources/adfs89s7/container/asdf%2Fasdf/items

(where %2F is the forward slash), I want to match it to the route:
/resources/<resource_id>/container/<container_name:path>/items

However, this is currently returning a Not Found error. I have similar URLs where the wildcard filter is at the end of the URL, e.g.
/resources/<resource_id>/container/<container_name:path>

and that seems to work fine.

The two strings %2F and / are equivalent in an URI path. You can encode any character this way. a equals %61 for example.

@claire-lee What you are trying is probably better suited for regexes, because, afaik, :path wildcard will consume the rest of the path including escaped and unescaped slashes.

Oh, the :path filter works just fine. I cannot reproduce the error.
>>> import bottle
>>> app = bottle.Bottle()
>>> app.route('/resources/<resource_id>/container/<container_name:path>/items', callback=True)
>>> app.match(dict(PATH_INFO='/resources/adfs89s7/container/asdf%2Fasdf/items', REQUEST_METHOD='GET'))
(<GET '/resources/<resource_id>/container/<container_name:path>/items' True>, {'resource_id': 'adfs89s7', 'container_name': 'asdf%2Fasdf'})
>>> app.match(dict(PATH_INFO='/resources/adfs89s7/container/asdf/asdf/items', REQUEST_METHOD='GET'))
(<GET '/resources/<resource_id>/container/<container_name:path>/items' True>, {'resource_id': 'adfs89s7', 'container_name': 'asdf/asdf'})

The follow will 404 when using %2F, but works fine with a literal forward slash
http://something.com/test/123/asd -> 123/asd
http://something.com/test/123%2Fasd -> 404
@route("/test/<test:re:.+>", method='GET')
def test(test):
    return test

I still cannot reproduce this bug in master or release-v12:
>>> import bottle
>>> app = bottle.Bottle()
>>> app.route('/test/<test:re:.+>', callback=True)
True
>>> app.match(dict(PATH_INFO='/test/123/asd', REQUEST_METHOD='GET'))
(<GET '/test/<test:re:.+>' True>, {'test': '123/asd'})
>>> app.match(dict(PATH_INFO='/test/123%2Fasd', REQUEST_METHOD='GET'))
(<GET '/test/<test:re:.+>' True>, {'test': '123%2Fasd'})

I tried the exact script you posted (plus import statements and a run() at the end). It works as intended:
$ curl http://<IP_ADDRESS>:8080/test/123/asd
123/asd
$ curl http://<IP_ADDRESS>:8080/test/123%2Fasd
123/asd

I'm facing the same issue. As an explanation, URI encoding the slash should have the effect that it is not interpreted as a hierarchical component in contrast to a literal forward slash. The point of encoding is to remove the semantic meaning. That is I would expect that:

/test/123%2Fasd refers to the document 123%2Fasd located at test. As such, it should not match the path /test/123/:doc.
/test/123/asd refers to the document asd located at /test/123. As such, it should match the path /test/123/:doc.

However given this service:
def print_all(*args, **kwargs): print(*args, kwargs)

import bottle
app = bottle.Bottle()
app.get("/test/123/:doc")(print_all)
app.run()

curl -o http://localhost:8080/test/123%2Fasd
# Server log: {'doc': 'asd'}, should return a 404
curl -o http://localhost:8080/test/123/asd
# Server log: {'doc': 'asd'}

It seems that the URI-encoding is already removed prior to the call to match hence those are both matched as /test/123/asd. This would explain all observations:

match and route when called with encoded route information work as intended and do not match the still encoded /%2F.
a running app will never really call those methods with the anticipated parameters.

How this can be resolved is a difficult question. It certainly makes some sense to do URL decoding after having isolated the pure path component as this makes it far more ergonomic to match paths with special characters such as spaces or question marks. And indeed matching /test/doc?cheeky would match a document named doc?cheeky (encoded as /test/doc%3Fcheeky) and not a get with a query. The handler should most definitely get the URI decoded path components as well. However this scheme means that / is always semantically interpreted even if it shouldn't and there is no way to escape it for the client.


[Spark] Update build pipeline to use Python 3.9. (3.7 is deprecated)

Which Delta project/connector is this regarding?

[X] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Description
Python 3.7 is deprecated. This PR changes the build pipeline to use v3.9, matching Spark: https://github.com/apache/spark/blob/6ca45c52b7416e7b3520dc902cb24f060c7c72dd/.github/workflows/build_and_test.yml#L414
Also updated setuptools to v41.1.0 for Python 3.9 compatibility:

How was this patch tested?
I temporarily commented the if: steps.git-diff.outputs.diff to run the tests: https://github.com/delta-io/delta/actions/runs/5665363510/job/15350071847?pr=1940
Does this PR introduce any user-facing changes?
No

It seems tests are not running

Closing it. It has been updated to 3.8 in another PR


larger wysiwyg toolbar

48px buttons
material design icons
trello ticket

ZOOM AND ENHANCE!

👍

Nice, +1

Coverage decreased (-0.1%) to 79.184% when pulling 2b8d2cd35eeda4fce561ed67a05ada6c0063aa2f on wysiwyg-tooltips into e7143a2083441bb7d16a48014418a2d3a12cd0b5 on master.


Support system-wide spell check on macOS

Description
Please add support for system-wide spell check on macOS.  Chrome and Safari both support it, making it difficult to use sites like Gmail in Nativefier without spell check.
Steps to Reproduce Issue
Use Nativefier to make a Gmail app.
Compose an email and include spelling mistakes.
No red line is shown.
Send embarrassing typos to your friends and colleagues.  Try to explain how your special version of Gmail doesn't have spell check because you used Nativefier.
Specifications

Version of Nativefier 7.4.0
Version of Node.jsv6.9.1
OS: macOS 10.12.5
Architecture x86
Stack trace from the error message (if any)

Closing as duplicate of #283


Incorrectly flag property "cwd" as not allowed for node attach in launch.json.

VSCode Version: 1.14.2
OS Version: Windows 10

Steps to Reproduce:

Add configuration to launch.json for node attach
Type "cwd" as property.

VSCode would say "Property cwd is not allowed".  Actually, the property is required for node attach to work properly with Meteor 1.6-beta.  Without it, break points would not be recognized.  The property should be allowed and intellisense should offer it.

What is the semantics of setting the "cwd" for attach? Since node.js is launched I cannot set its cwd.

Here is the launch.json that works with Meteor 1.6-beta.  Without cwd, all breakpoints would show up grayed out, saying "Breakpoint ignored because generated codes not found (source map problem?)."
    {
      "type": "node",
      "request": "attach",
      "name": "Server: attach",
      "port": 9229,
      "sourceMaps": true,
      "protocol": "inspector",
      "restart": true,
      "cwd": "${workspaceRoot}/"
    }

@roblourens are you actually using "cwd" in attach mode?

Yes, for resolving magic webpack:// and meteor:// sourcemap paths.
https://github.com/Microsoft/vscode-node-debug2/blob/master/src/nodeDebugAdapter.ts#L23
and
https://github.com/Microsoft/vscode-node-debug2/blob/master/src/nodeDebugAdapter.ts#L212

Ok, then I will make "cwd" a proper attribute for "attach" (and update doc).

@roblourens when trying to document cwd in the release notes and node debugging doc, it occurred to me that using cwd for sourcemap paths is a bit strange.
Currently we use this description (which is clearly for the launch case):
"launch the program to debug in this directory."
I have a hard time to adapt this explanation so that it works for both the "launch" and "attach" case.
It looks like that you are using cwd in your sourceMapPathOverrides because it happens to have the same value as workspaceRoot (and because the extension ensures that cwd is set to workspaceRoot when not explicitly set by the user).
But you are not really using cwd in the same semantics as the cwd used in a "launch" config.
What you probably need is a "workspaceRoot" or "projectRoot", correct?
I suggest that we introduce a new optional attribute "workspaceRoot" or "projectRoot" or "sourceMapRoot" (or whatever you suggest)
And in the extension we make sure, that this attribute always has a value (like cwd).

Yes, I guess that's actually what I need.

Hi, in 1.17.1both cwd and sourceMapPathOverrides work today.  When you resolve this issue will you provide indicators in the launch.json editor?
e.g. "cwd no longer supported for attach, maybe you want to define projectRoot"
Thanks

Another comment:
I notice that sourceMapPathOverrides has a useful characteristic:
    "sourceMapPathOverrides": {
      "meteor://💻app/packages/*": "${workspaceFolder}/packages/*",  // Example: "meteor://💻app/main.ts" -> "c:/code/main.ts"
      "meteor://💻app/*": "${workspaceFolder}/meris/*"  // Example: "meteor://💻app/main.ts" -> "c:/code/main.ts"
    },

Works as I intend.  In Meteor I can place my packages in a location outside of my project via an environment variable METEOR_PACKAGE_DIRS.
I believe that being able to define different paths for multiple sub-paths is a feature worth keeping.  Currently in the 1.17.1 UI I get green sqigglies and a rollover error for the property sourceMapPathOverrides:
Property sourceMapPathOverrides is not allowed

Will this property continue to exist?  I am hoping so.
Thanks

I guess I need to add that property to node-debug too... it's not going anywhere soon :)

Since we got a new JavaScript debug extension "js-debug", and the old "node-debug" has become obsolete, we do not plan to work on this issue.


More typings

I'm porting pixi-projection. Here's small number of typings. I'll put special hooks for plugin in another PR.

Codecov Report

Merging #5803 into dev will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #5803      +/-   ##
==========================================
+ Coverage   70.56%   70.57%   +<.01%
==========================================
  Files         205      205
  Lines       10371    10371
==========================================
+ Hits         7318     7319       +1
+ Misses       3053     3052       -1

Impacted Files
Coverage Δ

packages/mesh/src/Mesh.js
59.86% <ø> (ø)
:arrow_up:

packages/core/src/textures/TextureMatrix.js
31.37% <ø> (ø)
:arrow_up:

packages/core/src/utils/QuadUv.js
28.57% <ø> (ø)
:arrow_up:

packages/core/src/geometry/Geometry.js
41.79% <ø> (ø)
:arrow_up:

packages/ticker/src/Ticker.js
88.7% <0%> (+0.8%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c684f...6b9d7de. Read the comment docs.


Question about a line in the dino forward code

Hi,
There is a line in the dino forward code hs[0] += self.label_enc.weight[0,0]*0.0. The comment above it says  "# In case num object=0" what does that mean and what is this line doing?

Is this leftover code from something else, because it just adds 0 to hs[0]?


Return all claims for a search term and not only from winning claim.

If I search for one it should show all the claims not only the winning claim. That's how content which is not winning could be discovered. I remember bringing it up earlier, but I forgot what was the verdict on it.
Additional input from @tzarebczan and @kauffj..?
Might be related to #32.

This is correct. All standing and valid claims should be searched. Being
the winning claim can be a weight.
On Oct 12, 2017 11:17 AM, "hackrush"<EMAIL_ADDRESS>wrote:

If I search for one it should show all the claims not only the winning
claim. That's how content which is not winning could be discovered. I
remember bringing it up earlier, but I forgot what was the verdict on it.
Additional input from @tzarebczan https://github.com/tzarebczan and
@kauffj https://github.com/kauffj..?
Might be related to #32 https://github.com/lbryio/lighthouse/issues/32.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lighthouse/issues/36, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgZVvyAksNQy8WvJqxiFHPxDa4Gf28Cks5sri1rgaJpZM4P3LHw
.

I think we pull everything from the claimtrie(just resolvable and standing claims) as of now, as doing it the other way contained a lot of problems (from our internal meeting), we prob would need to write a big function to grab us all claims that can currently be resolved(old claims aswell?), this needs some thinking.

Talked with jack and tom on slack and we should be able to get the claimtrie and then use getclaimsforname for all claims in claimtrie, this would give us all claims resolvable.

This will be fixed in the upcoming release of the big update to lighthouse which will index the whole chain and resolve this error.

This is already corrected with the search updates to lighthouse. It will now show results for all claims not just controlling claims. In a future update with ChainQuery we will be able to also search expired claims too.


Deployment commit for prod-stable

Merged prod-beta branch to prod-stable.
Use latest commit to update namespace ref in app-interface repo. Don't use merge commit, SHAs must be unique when images are created for each branch.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.00%. Comparing base (b0cb5c5) to head (09206c1).

Additional details and impacted files
@@             Coverage Diff              @@
##           prod-stable     #357   +/-   ##
============================================
  Coverage        70.00%   70.00%
============================================
  Files               81       81
  Lines             1080     1080
  Branches           244      216   -28
============================================
  Hits               756      756
- Misses             313      324   +11
+ Partials            11        0   -11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


make unit and make allunit failed

I did not make any changes on the code. Tested in windows wsl.
make unit error:
=======================
Wrong result hash! (test/sql/copy/csv/test_quoted_newline.test:19)!
================================================================================
SQL Query
SELECT a FROM test ORDER BY a;
================================================================================
Expected result:
================================================================================
???
Actual result:
================================================================================
a
VARCHAR
[ Rows: 2]
hello
world
what,
 brings, you here
 , today

make all unit error
[456/946] (48%): test/sql/copy/csv/test_quoted_newline.test                     ================================================================================
Wrong result hash! (test/sql/copy/csv/test_quoted_newline.test:19)!
================================================================================
SQL Query
SELECT a FROM test ORDER BY a;
================================================================================
Expected result:
================================================================================
???
Actual result:
================================================================================
a
VARCHAR
[ Rows: 2]
hello
world
what,
 brings, you here
 , today

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
unittest is a Catch v2.4.0 host application.
Run with -? for options

-------------------------------------------------------------------------------
test/sql/copy/csv/test_quoted_newline.test
-------------------------------------------------------------------------------
/mnt/d/code/duckdb/test/sqlite/test_sqllogictest.cpp:1506
...............................................................................

test/sql/copy/csv/test_quoted_newline.test:19: FAILED:

[942/946] (99%): Test write lock with multiple processes                        -------------------------------------------------------------------------------
Test write lock with multiple processes
-------------------------------------------------------------------------------
/mnt/d/code/duckdb/test/persistence/test_locking.cpp:16
...............................................................................

/mnt/d/code/duckdb/test/persistence/test_locking.cpp:48: FAILED:
  REQUIRE_THROWS( db = make_unique<DuckDB>(dbdir) )
because no exception was thrown where one was expected:

[943/946] (99%): Test read lock with multiple processes                         -------------------------------------------------------------------------------
Test read lock with multiple processes
-------------------------------------------------------------------------------
/mnt/d/code/duckdb/test/persistence/test_locking.cpp:56
...............................................................................

/mnt/d/code/duckdb/test/persistence/test_locking.cpp:96: FAILED:
  REQUIRE_THROWS( db = make_unique<DuckDB>(dbdir) )
because no exception was thrown where one was expected:

[946/946] (100%): Test that sequence never returns the same value twice even ...
===============================================================================
test cases:    946 |    943 passed | 3 failed
assertions: 472658 | 472655 passed | 3 failed

Makefile:99: recipe for target 'allunit' failed
make: *** [allunit] Error 3

From the error message, the error of quoted new line test: expected results is some how "???" but not the value from csv.

Indeed we have no tests yet on WSL. For now I suggest you use the normal Windows build setup with Visual Studio. Both issues look like issues with newlines and file system IO, which is not too surprising on a sort-of-windows platform.

Indeed we have no tests yet on WSL. For now I suggest you use the normal Windows build setup with Visual Studio. Both issues look like issues with newlines and file system IO, which is not too surprising on a sort-of-windows platform.


feat: add sideEffects; part 2

Добавлены sideEffects: false. Часть 2.
(Общий пр застрял - будем кусочками, чтобы полегче https://github.com/core-ds/core-components/pull/1394
ч.1 https://github.com/core-ds/core-components/pull/1480)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 82.307%

Totals

Change from base Build<PHONE_NUMBER>8:
0.005%

Covered Lines:
10630

Relevant Lines:
11790

💛  - Coveralls


Fix MQTT retained message not being re-dispatched

Description:
Fix MQTT retained message not being re-dispatched. See #12003 for a detailed explanation.
Fixes #12003
Unfortunately, I have very limited knowledge of the test framework Home Assistant uses and I haven't found a way to create tests for this PR - if somebody with more knowledge could help out that would be great.
Checklist:

[x] The code change is tested and works locally.

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass.
[x] Tests have been added to verify that the new code works.

Your tests look great 👍

Thanks for the detailed review!

Sorry everybody! I accidentally merged instead of rebased...

Your previous comments should now have been taken care of. To summarise the changes:

MQTT._grouped_subscriptions has been removed and the subscriptions list is now simply iterated over without any grouping. Some of that code now resides in _mqtt_on_connect though, but the comments should explain what's going on well enough.
async_fire_mqtt_message in the tests/common emulates MQTT messages by calling the _mqtt_on_message callback in the MQTT client and doesn't use the dispatcher any more.
To make all tests work with above change, the MQTT class is now wrapped inside a MagicMock.
Tests that previously used mock_calls on the MQTT client to find out whether a MQTT message was fired had to be updated (with an overly complicated regex...). The updated tests also have the added benefit of being a bit easier to read:

# before
self.assertEqual(('alarm/command', 'ARM_HOME', 0, False),
                 self.mock_publish.mock_calls[-2][1])

# after
self.mock_publish.async_publish.assert_called_once_with(
    'alarm/command', 'ARM_HOME', 0, False)

(Side note: the mock mqtt client is stored as self.mock_publish in all test cases, that name seems a bit misleading to me.)

Done 🎉


Add Google Auth and email verification options to login and env

Add option for Google Auth
Add option for email verification

Holding off on merging for now because I'm doing a RSC migration and auth changes a bit. Will add and convert as needed once that's done.


Autocompletion should perhaps track upcast dynamic function literal parameter types

Related to #25490
void f(List<Person> people) {
  final byName = people.fold({}, (map, next) => map.^); // want to autocomplete "putIfAbsent"
}

Here, we're able to infer that the fold is over type Map. However, the parameter a is inferred to be dynamic. This is correct behavior for the spec, but not ideal behavior.
We can potentially improve this situation while still following the spec. By recognizing the upcast function literal and providing Map autocompletions on a.
Note that this only works for dynamic. For any other type, suggesting members that are not members of the static type will lead to an error:
f<T extends num>(T constraintParam, void Function(T) f) { ... }

void main() {
  f(0, (x) => x.bitLength)); // error: bitLength is not a member of num
}

Here the correct solution is to make the type parameter (int) explicit.
Making this better requires probably a lint or a language change.

filed https://github.com/dart-lang/linter/issues/1726 as a linter idea

Under Null Safety, map is now inferred to be Object? rather than dynamic, which means that upcasting wouldn't help here. It isn't clear that there are enough cases left where we could upcast to improve completion to make it worth the effort, so I'm going to close this. If we find one we can always re-open this issue or create a new one.

Under Null Safety, map is now inferred to be Object? rather than dynamic, which means that upcasting wouldn't help here. It isn't clear that there are enough cases left where we could upcast to improve completion to make it worth the effort, so I'm going to close this. If we find one we can always re-open this issue or create a new one.


Error: "Map Container not found" when using ngfor

Environment:
Angular 9,
Leaflet 1.6.0
Background:
I can build multiple maps by creating individual "div" and "options" without any issue. -- commented portion of html
Get the above error when using ngfor to create multiple maps in same page.
Code Snippet:
realtimedashb.component.html
`

{{widgets | json}}

`

realtimedashb.component.ts
`import * as L from 'leaflet';
@component
leafletoptions(widget){
// this code works fine for hardcoded div's
/*         const map = L.map('testmap').setView([50.6311634, 3.0599573], 4);
L.tileLayer('http://{s}.tile.osm.org/{z}/{x}/{y}.png', {
attribution: 'Test Map',
maxZoom: 12
}).addTo(map);
var marker = new L.Marker(new L.LatLng(40.6311634, 3.0599573), {
});
map.addLayer(marker);
map.invalidateSize(true);
const map2 = L.map('testmap2').setView([50.6311634, 3.0599573], 4);
L.tileLayer('http://{s}.tile.osm.org/{z}/{x}/{y}.png', {
attribution: 'Test Map',
maxZoom: 12
}).addTo(map2);
var marker = new L.Marker(new L.LatLng(40.6311634, 3.0599573), {
});
map2.addLayer(marker);
map2.invalidateSize(true);
*/
// Fails when I switch to ngfor and in this case parameter within L.Map is dynamic coming from backend, which is also used in the div.
var testmap = L.map(String(widget.name)).setView([50.6311634, 3.0599573], 4);
L.tileLayer('http://{s}.tile.osm.org/{z}/{x}/{y}.png', {
attribution: 'Test Map',
maxZoom: 12
}).addTo(testmap);
var marker = new L.Marker(new L.LatLng(50.6311634, 3.0599573), {
});
// testmap.invalidateSize(true);
testmap.addLayer(marker);
}`
ERROR reported in Console.
Error: Map container not found.
at NewClass._initContainer (leaflet-src.js:4097)
at NewClass.initialize (leaflet-src.js:3131)
at new NewClass (leaflet-src.js:301)
at Object.createMap [as map] (leaflet-src.js:4718)
at RealtimeDashbComponent.leafletoptions (realtimedashb.component.ts:1749)
at RealtimeDashbComponent.setWidgetData (realtimedashb.component.ts:2076)
at realtimedashb.component.ts:1718
at Array.forEach ()
at SafeSubscriber._next (realtimedashb.component.ts:1715)
at SafeSubscriber.__tryOrUnsub (Subscriber.js:183)
I have also tried the following combinations

hardocded div and options -- works
hardcoded div and server derived options loop -- works
switching from hardcoded div to ngfor is where the problem occurs. I can see that the div is assigned to proper id passed in widget.name and is also reflected in the image below.

I have attached a snapshot from Chrome dev-tools which shows the state info.

Any guidance in getting this resolved is greatly appreciated.
Thanks

Hi, and thanks for taking the time to open a bug report in Leaflet.
However, in this repository we only handle bugs in "vanilla" Leaflet. This means that we do not handle bugs which are specific to frameworks such as:

React
Ractive
AngularJS
Bootstrap
Leaflet for R
Joomla
Wordpress
Ionic
Cordova
Vue
Electron
Polymer
TypeScript
D3
Folium
...etc

Please understand that we only have the time and energy to test Leaflet in plain web browsers.
Please try to either reproduce the bug without using any frameworks, or submit a bug to the appropriate repo.


ochttp should provide a way to pass route info

According to the spec the path should be used as a span name only if route can't be determined.
I haven't found any way pass route name,  which is unfortunate for REST-like apis.
I imagine something like this for api:
// ochttp.Handler
type Handler struct {
   ...
   RouteName string
   ...
}

I wished that mux had a way to report the matched route. Putting this on the Handler as a field might not be ideal because it will require to initiate a new Handler for each route even though our primary recommendation is to wrap the entire mux with it.

Maybe what we need is a way to override the Span name of an active Span:
trace.FromContext(req.Context()).SetName("...")

Gorilla's Mux allows for pulling route information from Request Context. Here's an example of a Go kit serverBefore handler using this i.c.m. zipkin-go and overriding the default span name.
func ZipkinHTTPRoute(ctx context.Context, r *http.Request) context.Context {
	if span := zipkin.SpanFromContext(ctx); span != nil {
		if route := mux.CurrentRoute(r); route != nil {
			if tpl, err := route.GetPathTemplate(); err == nil {
				zipkin.TagHTTPRoute.Set(span, tpl)
				span.SetName(r.Method + " " + tpl)
			}
		}
	}
	return ctx
}

+1 for FormatSpanName callback in Handler

Fixed by #796


perf: Try using a closure for creating API rather than a class

Would remove the need to lookup self._routes, callable may be faster?

I'm guess this can be closed, since I don't think it's feasible


Team5 station test coverage

Description
Added tests for the spawn recipe commands.
Fixes / Closes # (issue)
Type of change

[x] Test coverage

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Add labels and ticket


Error. UI periodically is frozen if I am using looped route

From @gladiussdv on May 21, 2018 7:44

Environment:

tns --version: 4.0.0
npm packages tns module: "tns-core-modules": "~4.0.0",
android (7.1): emulator and real device (zte axon 7 with android 7.1.1).

Reproduce.

a. Create basic application with 2 components and routing between they.
b. Create Labels with tap action on the first and on the second component.
c. Don't use "this.routerExtensions.back();" this code for going back to the previous page.  Instead of it use following code for both Labels: "this.router.navigate(['/firstComponent']);" and "this.router.navigate(['/secondComponent']);"
d. Click a few times on labels and transit between components a few times.

The result:

I notice that UI has freeze after this steps. And the more you execute the call of looped routes then more you will see freezes.

Addition info:

I have tried the following solutions that I have find in the internet:
a. remove gc() in onActivityDestroyd method:
onActivityDestroyed: profiling_1.profile("onActivityDestroyed", function (activity) {
if (activity === androidApp.foregroundActivity) {
androidApp.foregroundActivity = undefined;
}
if (activity === androidApp.startActivity) {
androidApp.startActivity = undefined;
}
androidApp.notify({ eventName: ActivityDestroyed, object: androidApp, activity: activity });
// gc();  !!!
}),
b. add following code to package.json
"android": {
"markingMode": "none"
}
they don't help. I should just avoid this looped routes somehow. But it is not comfortable.
Also in my project I have lists and ActionBar on both components. And one component has tabs.
Copied from original issue: NativeScript/NativeScript#5843

related to #1215


Custom session duration

A customer has reported that they're getting SignatureDoesNotMatch errors while running multiple CloudWatch logs queries in parallel. They're using AWS SDK Default auth and they're assuming a role. We have not been able to repro this issue, but the theory is that the logs query is started using temporary STS credentials that lasts for 15 minutes. The query then runs for more than 15 minutes, so once it's completed different credentials are being used compared to when the query started.
Once this is released, the customer will be able to test this by setting the new environment variable AWS_SESSION_DURATION to a duration longer than the default value (currently 15 minutes in STS).
This PR is still in draft mode because we're waiting for approval from the customer to help us test this in future 9.0 patch release.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add a flag to classic network to prevent IP probing

What would you like to be added:
add a flag to classic network to prevent IP probing

全局配置增加禁止ping开关-v3.9


Defining list of lists

Is it possible to define a field of output type list of lists of custom type?

This is possible via list: array:
t.float('coords', {
  list: [true, true]
})
// coords: [[Float!]!]

Where the boolean exists to indicate whether the type is non-nullable or not. This API is a little confusing, I may look to allow for something closer to graphql-js with wrapping types in the future.

@tgriesser, This is indeed very confusing. We are using nexus for quite some time now and I just understood why the list property is an array of booleans!


[Hotfix][Connector-V2] Fix connector source snapshot state NPE

clickhouse
kudu

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.


Extend the netcdf API to support programmatic changes to the plugin search path

Replaces PR https://github.com/Unidata/netcdf-c/pull/3024 and PR https://github.com/Unidata/netcdf-c/pull/3033
re: https://github.com/Unidata/netcdf-c/issues/2753
As suggested by Ed Hartnett, This PR extends the netcdf.h API to support programmatic control over the search path used to locate plugins.
I created several different APIs, but finally settled on the following API as being the simplest possible. It does have the disadvantage that it requires use of a global lock (not implemented) if used in a threaded environment.
Specifically, note that modifying the plugin path must be done "atomically". That is, in a multi-threaded environment, it is important that the sequence of actions involved in setting up the plugin path must be done by a single processor or in some other way as to guarantee that two or more processors are not simultaneously accessing the plugin path get/set operations.
As an example, assume there exists a mutex lock called PLUGINLOCK. Then any processor accessing the plugin paths should operate as follows:
lock(PLUGINLOCK);
nc_plugin_path_get(...);
<rebuild plugin path>
nc_plugin_path_set(...);
unlock(PLUGINLOCK);

Internal Architecture
It is assumed here that there only needs to be a single set of plugin path directories that is shared by all filter code and is independent of any file descriptor; it is global in other words. This means, for example, that the path list for NCZarr and for HDF5 will always be the same.
However internally, processing the set of plugin paths depends on the particular NC_FORMATX value (NC_FORMATX_NC_HDF5 and NC_FORMATX_NCZARR, currently). So the nc_plugin_path_set function, will take the paths it is given and propagate them to each of the NC_FORMATX dispatchers to store in a way that is appropriate to the given dispatcher.
There is a complication with respect to the nc_plugin_path_get function. It is possible for users to bypass the netcdf API and modify the HDF5 plugin paths directly. This can result in an inconsistent plugin path between the value used by HDF5 and the global value used by netcdf-c. Since there is no obvious fix for this, we warn the user of this possibility and otherwise ignore it.
Test Changes

New tests
a. unit_test/run_pluginpaths.sh -- was created to test this new capability.
b. A new test utility has been added as unit_test/run_dfaltpluginpath.sh to test the default plugin path list.
New test support utilities
a. unit_test/ncpluginpath.c -- report current state of the plugin path
b. unit_test/tst_pluginpaths.c -- test program to support run_pluginpaths.sh

Documentation

A new file -- docs/pluginpath.md -- provides documentation of the new API. It includes some
material taken for filters.md.

Other Major Changes

Cleanup the whole plugin path decision tree. This is described in the docs/pluginpath.md document and summarized in Addendum 2 below.
I noticed that the ncdump/testpathcvt.sh had been disabled, so fixed and re-enabled it. This necessitated some significant changes to dpathmgr.c.

Misc. Changes

Add some path manipulation utilities to netcf_aux.h
Fix some minor bugs in netcdf_json.h
Convert netcdf_json.h and netcdf_proplist.h to BUILT_SOURCE.
Add NETCDF_ENABLE_HDF5 as synonym for USE_HDF5
Fix some size_t <-> int conversion warnings.
Encountered and fixed the Windows \r\n problem in tst_pluginpaths.c.
Cleanup some minor CMakeLists.txt problems.
Provide an implementation of echo -n since it appears to not be
available on all platforms.
Add a property list mechanism to pass environmental information to filters.
Cleanup Doxyfile.in
Fixed a memory leak in libdap2; surprised that I did not find this earlier.

Addendum 1: Proposed API
The API makes use of a counted vector of strings representing the sequence of directories in the path. The relevant type definition is as follows.
typedef struct NCPluginList {size_t ndirs; char** dirs;} NCPluginList;

The API proposed in this PR looks like this (from netcdf-c/include/netcdf_filter.h).

int nc_plugin_path_ndirs(size_t* ndirsp);
Arguments: ndirsp -- store the number of directories in this memory.
This function returns the number of directories in the sequence if internal directories of the internal plugin path list.

int nc_plugin_path_get(NCPluginList* dirs);
Arguments:  dirs -- counted vector for storing the sequence of directies in the internal path list.
This function returns the current sequence of directories from the internal plugin path list. Since this function does not modify the plugin path, it does not need to be locked; it is only when used to get the path to be modified that locking is required.  If the value of dirs.dirs is NULL (the normal case), then memory is allocated to hold the vector of directories. Otherwise, use the memory of dirs.dirs to hold the vector of directories.

int nc_plugin_path_set(const NCPluginList* dirs);
Arguments: dirs -- counted vector for providing the new sequence of directories in the internal path list.
This function empties the current internal path sequence and replaces it with the sequence of directories argument. Using an ndirs argument of 0 will clear the set of plugin paths.

Addendum 2: Build-Time and Run-Time Constants.
Build-Time Constants

Table showing the build-time computation of NETCDF_PLUGIN_INSTALL_DIR and NETCDF_PLUGIN_SEARCH_PATH.
--with-plugin-dir--prefixNETCDF_PLUGIN_INSTALL_DIRNETCDF_PLUGIN_SEARCH_PATH
undefinedundefinedundefinedPLATFORMDEFALT
undefined<abspath-prefix><abspath-prefix>/hdf5/lib/plugin<abspath-prefix>/hdf5/lib/plugin<SEP>PLATFORMDEFALT
<abspath-plugins>N.A.<abspath-plugins><abspath-plugins><SEP>PLATFORMDEFALT

Table showing the computation of the initial global plugin path
HDF5_PLUGIN_PATHInitial global plugin path
undefinedNETCDF_PLUGIN_SEARCH_PATH
<path1;...pathn><path1;...pathn>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: DennisHeimbigner:x: Dennis HeimbignerDennis Heimbigner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @DennisHeimbigner I'll take a look at it tomorrow, along with playing catchup on other PR's which cropped up last week while I was at the retreat & committee meetings.

Dennis, did you want me to take a look at merging the changes in re: a custom prefix?

I am in the process of fixing things, so hang on a bit.

Ok, I fixed things to include the use of CMAKE_INSTALL_PREFIX that you suggested.
I also fixed up configure.ac to do the same thing for automake.
I turned out to be a more extensive change that I originally thought
because there was internal plugin code that also needed to be fixed
to properly hand this case.

Thanks Dennis, reviewing!

I don't understand the question. Can you elaborate?

Before this PR, CMakeLists.txt (for example) would check for HDF5_PLUGIN_PATH environmental variable, and if it is defined, would use it in the plugin directory logic.  With your PR, the environmental variable HDF5_PLUGIN_PATH is no longer checked for or used when computing anything.  Is that by design?

For better or worse, changed the rules.
Using HDF5_PLUGIN_PATH at build-time seems incorrect.
So, at build-time I use the install directory (as per your request)
plus the HDF5 defaults
to create the initial plugin path.
At run-time, it makes sense to use HDF5_PLUGIN_PATH.
So if it defined at run-time, then it completely replaces the
build-time path.
Then finally, any programmatic changes (using the API defined in this PR)
are applied to get the final set of directories to search for plugins.
If any of this seems incorrect to you, let me know.

BTW at build-time, there is an option --with-plugin-path that can be used instead of HDF5_PLUGIN_PATH

Sounds good, thanks! Given the size of this PR, I just wanted to make sure something hadn't been overlooked.

Well, now that I've merged this and have moved on to some other things, I now have to wonder what the impact of this on netcdf-fortran will be. I'll test that tomorrow, but I suspect we will need to make some changes there as well, if we want Fortran to continue to use plugins. Currently, at configure time, netCDF-Fortran looks for HDF5_PLUGIN_PATH environmental variable.  Ideas welcome @DennisHeimbigner @edwardhartnett

I always forget about fortran and C++.
One simple solution is to add the option --with-plugin-dir=$HDF5_PLUGIN_PATH (automake)
or -DNETCDF_PLUGIN_DIR=$HDF5_PLUGIN_PATH (cmake) to the build process.

Ideally Dennis, we can add the interface to netCDF-Fortran to invoke these pathing calls you added to the C library.  In the meantime, as I prep the next release, we'll have to rely on setting HDF5_PLUGIN_PATH as we've been doing in Fortran.  But that may not actually be the correct thing at this point, we'll need to sort that out.

I just noticed that nc-config also isn't working quite right, I'm going to put up a PR here after I untangle this a bit and then we can figure out netcdf-fortran.

ok, we can talk about it at the next netcdf meeting (or some other time if you prefer).


Handle errors when walking the fs in tf instance provider

When walking the directory we need to check if an error is passed in and, if so, not process that entry since the associated os.FileInfo is nil.
This appears to happen when a file has been removed after the directory listing has completed.
Signed-off-by: Steven Kaufer<EMAIL_ADDRESS>

So, when testing this, I ran with the message at an INFO level, the files associated with the error are things like this:
time="2017-10-12T07:44:47Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T07:45:46Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T07:50:47Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T07:51:06Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T07:55:06Z" level=info msg="Ignoring file /infrakit_files/030932466 due to error: lstat /infrakit_files/030932466: no such file or directory"
time="2017-10-12T07:57:06Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T07:57:06Z" level=info msg="Ignoring file /infrakit_files/.nfs0000000000005cf1000000bd due to error: lstat /infrakit_files/.nfs0000000000005cf1000000bd: no such file or directory"
time="2017-10-12T07:59:26Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T08:00:46Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T08:03:46Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T08:04:26Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T08:07:06Z" level=info msg="Ignoring file /infrakit_files/.nfs0000000000005cf2000000cb due to error: lstat /infrakit_files/.nfs0000000000005cf2000000cb: no such file or directory"
time="2017-10-12T08:09:07Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T08:17:46Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T08:20:46Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T08:24:26Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T08:30:26Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T08:34:06Z" level=info msg="Ignoring file /infrakit_files/tf-apply.lck due to error: lstat /infrakit_files/tf-apply.lck: no such file or directory"
time="2017-10-12T08:40:46Z" level=info msg="Ignoring file /infrakit_files/.nfs0000000000005cf1000000f7 due to error: lstat /infrakit_files/.nfs0000000000005cf1000000f7: no such file or directory"

The tf-apply.lck file is used to lock terraform; I'm guessing that when the lib read the directory that that file was there and then, when it walked each file, that file was removed because the lock was released.
The other files appear to be NFS metadata files, I'm not exactly sure what those are.
Either way, these clearly aren't files that we would want to process and should ignore them.


Be able to input special character

I use Vaddin 7.4.1 and the maskedTextField addon 0.1.6. I have a problem with special character. I have a numeric mask ( "(##) ####-####"). But we are able to input special characters ( $ ,', ").

others characters are accepted (the numeric mask): { } ! $ | \ ^ @

All of it, uses SHIFT key right? except by "" ?
Eduardo Frazão
2015-05-05 10:54 GMT-03:00 marinasp<EMAIL_ADDRESS>
others characters are accepted (the numeric mask): { } ! $ | \ ^ @
—
Reply to this email directly or view it on GitHub
https://github.com/andersonfreitas/vaadin-masked-textfield/issues/19#issuecomment-99084185
.

I use Alt GR and french keyboard.


[Discussion] Question about prompt

Discussion
Hello,
Congratulations on the amazing work! I have a query about prompts for custom dataset. In the evaluation.md (https://github.com/haotian-liu/LLaVA/blob/main/docs/Evaluation.md) there is an example prompt for multiple choice question. Does this prompt has to be appended to the original prompt:
"A chat between a curious human and an artificial intelligence assistant. The assistant gives helpful, detailed, and polite answers to the human's questions. USER: <image>" + "<question> A. <option_1> B. <option_2> C. <option_3> D. <option_4> Answer with the option's letter from the given choices directly."
My task is given an image and list of choices, select the most probable choice.

Hi. Not the code author but what do you mean by original prompt? You can use the prompt you showed above and get the generated token which will be the predicted option.

Valid point @copperwiring. I am also wondering


SBML export annotations

It looks like the package lost the ability to export annotations to SBML from c0763d8, possibly during the conversion from manual xml generation to using libSBML. I believe libSBML supports annotations to at least some degree (see RDFAnnotationParser, CVTerm, add CVTerms example) so it should be possible to add that back in.

Thanks for pointing this out and linking to the relevant libSBML API!


Refactoring ens lookup without go-ens.Name

Fixes #539

created a new issue for this: https://github.com/trustwallet/blockatlas/issues/541


Android-Kotlin: 04.1 Loops in Kotlin

I want to create and make the documentation for this topic. Kindly assign me this issue @rahulsain
Myself Sakalya Mitra(Batch 3 Android Dev with Kotlin)

@Sakalya100 please change the number from 04.1 to 02.3

Done @sitamadex11

Hey @rahulsain , I would like fix the Audio part of this issue .
Assign me this issue


Partial inference specifically when declaring variables

Suggestion
I frequently end up with the following pattern in my code.
type Item = {
    some: 'internal'
    structure: boolean
}

const untypedMapOfItems = {
  idA: {
    some: 'internal',
    structure: true
  },
  idB: {
      some: 'internal',
      structure: false
  }
}

const mapOfItems: {[Key in keyof typeof untypedMapOfItems]: Item} = untypedMapOfItems

The goal of this pattern is to avoid having to repeat the ids in some type, so that they will just be carried through to the type of mapOfItems, while still validating that the values of untypedMapOfItems have to be Item. This is very useful to me in that it maintains type safety while avoiding boilerplate types, where we need to write a series of ids twice. However, it feels pretty boilerplatey itself, and I would like a shorthand to carry through some part of the type of an assignment while still maintaining some invariants. Something like;
type Item = {
    some: 'internal'
    structure: boolean
}

const mapOfItems: {[Key in (infer K)]: Item} = {
  idA: {
    some: 'internal',
    structure: true
  },
  idB: {
      some: 'internal',
      structure: false
  }
}

This would mirror the syntax from conditional types, and effectively be a shorthand for
type Item = {
    some: 'internal'
    structure: boolean
}

const untypedMapOfItems = {
  idA: {
    some: 'internal',
    structure: true
  },
  idB: {
      some: 'internal',
      structure: false
  }
}

const mapOfItems: typeof untypedMapOfItems extends {[Key in infer K]: Item} ? {[Key in K]: Item} : never = untypedMapOfItems

Both my current go to solution and the conditional type analogy example currently produce relatively hard to understand type errors or produce type errors in strange places. Hopefully this new syntax could produce type errors more similar to the following code, but keep the tighter type.
type Item = {
    some: 'internal'
    structure: boolean
}

const untypedMapOfItems: {[Key in string]: Item} = {
  idA: {
    some: 'internal',
    structure: true
  },
  idB: {
      some: 'internal',
      structure: false
  }
}

This is a sandbox exploring the various examples that are currently valid typescript.
🔍 Search Terms
inference, partial inference, infer syntax, conditional types, boilerplate reduction
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

This looks like a different solution to the same problem that https://github.com/microsoft/TypeScript/issues/7481 tries to solve.

Also reminds me of https://github.com/apple/swift-evolution/blob/main/proposals/0315-placeholder-types.md

Placeholder types do seem like a pretty close comparison. I do think #7481 would largely address this for me, though I've never really felt the need for this pattern other than at assignment, so I have a slight preference to the syntax I suggest above.

Is this significantly different from #38349 (which was closed as a duplicate of #7481 also)?


packaging: fix patch name

the make_spec.sh script expects a gem in the name of the patch
follow up for #1202
@mssola thanks for merging the patches, there was just this detail with the patch identifier in the name that was recently introduced in 89b118a97d775321a6d190239592985f77c30f40

Got it, thanks 👍


Build wheels first in development version tests

This is an experiment to build wheels first, then run tox in parallel.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
297

Relevant Lines:
297

💛  - Coveralls

I like this a lot.  It's a lot more transparent than just letting tox handle everything.