Not compatible with the version GoLand 2024.2.2

Not compatible with the version of your running IDE (GoLand 2024.1.6),
I added envfile inside debugger process, when run the debugger it complained some of my envs keys could not be found.
Log inside the debugger console:
Got a connection, launched process /Users/shawnzhang/Library/Caches/JetBrains/GoLand2024.2/tmp/GoLand/___go_build_code_in_spdigital_sg_sp_digital_beaver_api_cmd_serverd (pid = 70006).
2024-09-23T04:30:26Z error layer=debugger error loading binary "/Users/shawnzhang/Library/Caches/JetBrains/GoLand2024.2/tmp/GoLand/___go_build_code_in_spdigital_sg_sp_digital_beaver_api_cmd_serverd": error reading debug_info: decoding dwarf section info at offset 0x4560bf: DW_FORM_strx with no .debug_str_offsets section
Exiting.
could not launch process: error reading debug_info: decoding dwarf section info at offset 0x4560bf: DW_FORM_strx with no .debug_str_offsets section
Debugger finished with the exit code 1

Can help to fix it?

Ok found an issue, because of macos upgrade cause the GoLand IDE issue, will close this issue.
https://youtrack.jetbrains.com/issue/GO-17477/macOS-Sequoia-debugger-finishes-with-could-not-launch-process-no-debugstroffsets-section


Why css animation is disabled in css?

https://github.com/dvtng/react-loading-skeleton/blob/a514b42bcfd3fef53818a6af3aef436f57b7a093/src/index.css#L11
I just wondering, why you disabled this line.
This can be used to enable animation right?

It was commented out when the duration prop was added. Now the animation is applied as an inline style.


Correct --for parameter

Default is 1 day i.e. 60 * 24
fixed typo from --from to --for

Signed-off-by: Abhijeet Kasurde<EMAIL_ADDRESS>

Hi @Akasurde
yes default is 1 day but we want the default value to be in seconds. thats the reason we see what we see there.
About the typo, can you please get that in the other PR.

Hi @Akasurde
yes default is 1 day but we want the default value to be in seconds. thats the reason we see what we see there.
About the typo, can you please get that in the other PR.


WIP: fixing tests and updating list representation

Updates tests and helper methods to deal with bounded and unbound arrays

Same as https://github.com/ros-visualization/qt_gui_core/pull/211#issuecomment-606839789
@mlautman I have deleted the newly created branch eloquent-devel. Please redo the contribution targeting the latest ROS 2 branch if there is no reason to branch.


[Candidate 2v2 Tournament D ZH v1] Right team Supply Piles offer more build space than left team

Observed behavior
Right team Supply Piles offer more build space than left team.
Expected behavior
Mirrored Supply Piles offer about equal build space.
Screenshots

I will sort this out

It still offers slightly better build opportunities. But as much anymore.


Corrected spelling

https://github.com/CSSEGISandData/COVID-19/issues/124#issuecomment-592957638

@ChooseYourPlan Thank you so much.

@all-contributors please add @ChooseYourPlan for spelling checking

@all-contributors please add @ChooseYourPlan for translation


BBB Customizing via UserData modification -> 404 Not Found (nginx)

In attempt to apply BBB settings customization. I took the following steps:

added a folder with desired version of settings and copied this into S3 via setup.sh
echo "copy BBB code source file"
...
aws s3 sync --profile=$BBBPROFILE --exclude=".DS_Store" ./savvy_settings s3://$SOURCE

copy these files in after "wget...bbb-install.sh | bash... " in the UserData section of bbb-on-aws-bbbappscalable.template.yaml
   wget -qO- https://ubuntu.bigbluebutton.org/bbb-install.sh | bash -s -- -v xenial-220 -s $instance_fqdn -e ${BBBOperatorEMail} -c $turn_fqdn:$turnsecret

   # Customize BBB instance for savvy
   mv /usr/share/meteor/bundle/programs/server/assets/app/config/settings.yml /usr/share/meteor/bundle/programs/server/assets/app/config/settings_original.yml
   aws s3 cp s3://${BBBStackBucketStack}/settings.yml /usr/share/meteor/bundle/programs/server/assets/app/config/settings.yml
   bbb-conf --restart

Without the "bbb-conf --restart" the changes do NOT take affect

With "bbb-conf --restart"  it appears that nginx is not starting

Greenlight is up but start a room leads to 404
Tried to connect to EC2 but not sure what the user name is (default "ubuntu" does not work)

per BBB installation many parameters are set in settings. Therefore cannot simply replace file. Must use sed and replace desire settings only.


Issue55: Use backoff strategy for all polling

Use Backoff strategy for all polling. Move the backoff
code to util and integrate it with the other places where
polling is done in entire codebase.

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #89   +/-   ##
=====================================
  Coverage      77%    77%
=====================================
  Files          14     14
  Lines        1231   1231
=====================================
  Hits          940    940
  Misses        196    196
  Partials       95     95

Impacted Files
Coverage Δ

adapter/util/backoff.go
78% <ø> (ø)

adapter/product/manager.go
76% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc1ebc...81cf78b. Read the comment docs.


Mat-select listens window 'resize' event inside the zone

Reproduction
1- Open the dev tools.
2- Resize the window.
3- See the console.log('Tick') being fired multiple times.
Stackblitz: https://stackblitz.com/edit/angular-nuyaqc
Expected Behavior
I expect that on window resize there isn't any CD run fired by mat-select component
Actual Behavior
Somehow mat-select component is listening window 'resize' event inside the zone, this fires a CD run on every 'resize' event. This CD run is not necessary since mat-select, as far as I know, doesn't react on window changes, and if so, it should do it outside the zone and detecting changes locally IMO.
Environment

Angular: ~9.0.0
CDK/Material: ~9.0.0
Browser(s): Chrome (latest)
Operating System (e.g. Windows, macOS, Ubuntu): Windows

I bet the culprit is the cdk overlay code. It positions the overlay depending on how much space is left, but I don't think it needs to be listening inside the NgZone

Closing since this should've been resolved by https://github.com/angular/components/pull/15814 a long time ago.

Closing since this should've been resolved by https://github.com/angular/components/pull/15814 a long time ago.


Feature: adding utility/command example in help

How to add a utility/command example in help. OR a Examples section in command help. For example, let's say, I created a command: sayHello, which takes an argument NAME.

Expectation
So, when I say,
sayHello --help
It shall display something like,
Usage: sayHello [OPTIONS] NAME

Options:
  --help Show this message and exit.

Examples:
  sayHello Aniket
  Output: Hello, Aniket     ## This output things can be optional, to show what would happen, is that example is run

I searched the documentation and couldn't find any text on how to do this. Not sure if this feature is available ?

Either write it in the doc string, or the epilog parameter. https://click.palletsprojects.com/en/7.x/api/?highlight=epilog#click.Command
Please use Stack Overflow for questions about your own code. This tracker is for issues related to the project itself. Be sure to include a minimal, complete, and verifiable example.


this.project is not a function

RxJS version: 5.4.0
Code to reproduce:
import { Observable } from 'rxjs/Rx';
const SEND_RESET = "sr";
function successOf(x) { return `${x}_SUCCESS` }
const WaitUntilRedirect = 10;
export function resetRedirectAfterSend(action$: Observable) {
  return action$.ofType(successOf(SEND_RESET)).concatMap(
    Observable
      .range(0, WaitUntilRedirect)
      .delay(
        Observable.timer(1000),
        x => Observable.timer(x * 1000))
      .timeInterval()
      .map(x => setUntilRedirect(WaitUntilRedirect - x.interval * x.value))
      .concatMap(action => push({
        pathname: '/accounts/login',
        query: {
          scent: 'forgot'
        }
      }))
  );
}

Expected behavior:
No crash
Actual behavior:
VM224378:242 Uncaught TypeError: this.project is not a function
    at MergeMapSubscriber._tryNext (eval at ./node_modules/rxjs/operator/mergeMap.js (app.js:9085), <anonymous>:120:27)
    at MergeMapSubscriber._next (eval at ./node_modules/rxjs/operator/mergeMap.js (app.js:9085), <anonymous>:110:18)
    at MergeMapSubscriber.Subscriber.next (eval at ./node_modules/rxjs/Subscriber.js (app.js:7269), <anonymous>:89:18)
    at FilterSubscriber._next (eval at ./node_modules/rxjs/operator/filter.js (app.js:8957), <anonymous>:88:30)
    at FilterSubscriber.Subscriber.next (eval at ./node_modules/rxjs/Subscriber.js (app.js:7269), <anonymous>:89:18)
    at Subject.next (eval at ./node_modules/rxjs/Subject.js (app.js:7253), <anonymous>:55:25)
    at eval (eval at ./node_modules/redux-observable/lib/es/createEpicMiddleware.js (app.js:7078), <anonymous>:69:16)
    at eval (eval at ./app/components/logging/mixpanel.js (app.js:713), <anonymous>:157:16)
    at eval (eval at ./node_modules/react-router-redux/es/middleware.js (app.js:6680), <anonym

Additional information:

.concatMap(
    Observable
      .range(0, WaitUntilRedirect)

->
concatMap(project: (value: T, index: number) =>  ObservableInput<I>) (https://github.com/ReactiveX/rxjs/blob/master/src/operator/concatMap.ts#L68)

You're right. What threw me off is the error message; while I did not properly use the functions, it should not crash internally like this.

it's quite similar cases to https://github.com/ReactiveX/rxjs/issues/2144#issuecomment-261801399. Nature of javascript is dynamic and you can provide / call nearly every possible way, in most cases we can't prevent all cases in runtime check. That's reason we're providing TS definition as documented api interface - even user of javascript can refer those interfaces.

@kwonoj What's wrong with the code you linked? Your docs state I can supply an observable to concat map (third example here https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/concatmap.md#rxobservableprototypeconcatmapselector-resultselector-thisarg)

document you referred is rxjs4, 5 has breaking changes and not compatible.


Extracted code for i63mul yields syntax issue

@lthms I've just seen your comment https://github.com/coq/coq/issues/12109#issuecomment-716360087 linking to the Int.v file, so I wanted to report that one line raises a syntax issue:
https://github.com/coq-community/coqffi/blob/d89e1d5da1d37b739b0c42a7cbb15b0730a654f3/theories/Data/Int.v#L130
should write
  Extract Inlined Constant i63mul => "( * )".

to workaround the similarity with OCaml comments (* … *)
Also, maybe some (extraction) test could be added to coqffi's CI build at some point?

Thank you for reporting! It turns out my tests only including (+) and (-) (: Will try to push a fix today.

Also, maybe some (extraction) test could be added to coqffi's CI build at some point?

You are right again. Thanks for suggesting it. I will create an issue to that end.


This browser or app may not be secure.

OS: Windows 10
GPMDP Version: 4.6.1
Issue Descriptions:  See Screen snip

The screen is displayed after completing the login process. I can still access menu items from the icon in the taskbar (See screen snip)

I've tried uninstalling & reinstalling with and without anti-virus active.
This issue is occuring on my personal laptop and the laptop I use at work.
I was not able to create a log file.

Please follow the issue template. Duplicate of #3545.


plugin crashes on creating gcp connection

for
  # ciphertrust_gcp_connection.connection will be created
  + resource "ciphertrust_gcp_connection" "connection" {
      + cloud_name = "gcp"
      + id         = (known after apply)
      + key_file   = ".thales_sa.json"
      + name       = "gcp-connection-34fc52d466077c6a"
    }

Stack trace from the terraform-provider-ciphertrust_v0.10.6-beta plugin:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x1c0 pc=0x10797e5]
goroutine 53 [running]:
thales.com/terraform/terraform-provider-ciphertrust/provider.testGcpConnectionParams({0x16f5240, 0xc0009e1420}, 0x1f961a0, {0xc00017f500, 0x935}, 0x16f5240?)
thales.com/terraform/terraform-provider-ciphertrust/provider/resource_gcp_connection.go:229 +0x85
thales.com/terraform/terraform-provider-ciphertrust/provider.resourceGcpConnectionCreateContext({0x16f5240, 0xc0009e1420}, 0xc000a1a600, {0x136db20, 0x1f961a0})
thales.com/terraform/terraform-provider-ciphertrust/provider/resource_gcp_connection.go:80 +0x1aa
doing the same via webUI -> works

Hi Tom,
Thank-you for bringing this to our attention.
Unfortunately I'm not able to reproduce with a either a filename of that name, a filename that doesn't exist with that name or invalid data in the file.
Seems to work fine with valid data in the file.
Can you share what version of the provider you are using and what is the version for CipherTrust Manager so I can compare apples with apples.
Thanks Sarah.

the environment, I am using
Terraform v1.9.8
on linux_amd64
+ provider registry.terraform.io/hashicorp/google v6.11.2
+ provider registry.terraform.io/hashicorp/random v3.6.3
+ provider registry.terraform.io/thalesgroup/ciphertrust v0.10.6-beta

key_file   = ".thales_sa.json" is the service-account-json, which works inside the WebUI

Hi Tom,
Thanks for the info. Same versions of terraform and the provider I was testing with.
You didn't mention the version. Can you click on the info button on the top bar of the UI and let us know what it says.
That being said the only thing I can see which could result in a nil pointer dereference on that line of code is the client used for calling the API functions. Are you able to create other resources?
Regards Sarah

Hi,
https://github.com/ThalesGroup/terraform-provider-ciphertrust/issues/16
crashes as well
the ui is the WebUI https://ciphertrust.dpondemand.io/?tenant=onpier-gmbh-ciphertrustmanager
I have not seen any version number there
Has it something to do with the authentication?
We using
cat ~/.ciphertrust/config
address = https://ciphertrust.dpondemand.io/?tenant=onpier-gmbh-ciphertrustmanager
username = {email}
password = {password}
domain =

Best
Tom

Hi Tom,
Sorry, I thought you were working with an instance of the CipherTrust Manager,
Unfortunately somebody else will have to help you as I work with Cloud Key Manager resources.
Regards Sarah

Hi @TomSp,
I think this issue should also be linked to your broken provider configuration from issue #15 . Please update this issue, if a fixed provider config also fixes this issue.
Please be aware that our terraform provider is still in Beta and therefore seems to handle non-perfect configurations quite roughly  (as we can see with the whole exception stack trace).
Best regards, Martin

fix due to https://github.com/ThalesGroup/terraform-provider-ciphertrust/issues/15


STORM-2610: Fixed the metrics

I still need to add these to the docs, but I wanted to capture my progress before the long weekend.

It looks good overall. This change doesn't touch critical path so don't need to consider performance side.

We didn't document individual builtin metric so maybe no need to document the change or document whole builtin metrics. It is breaking change in point of builtin metrics (for users who use metrics consumer) indeed.
+1

@HeartSaVioR I filed STORM-2616 to document all of the built in metrics, and I'll try to get a pull request for that up some time soon.
For now I will leave this as a 2.x change, and if someone really wants/needs this for 1.x I can add the ms metrics and fix the count metrics.


CrowdSourceManager Web app references external code.jquery.com

See following line in index.html file:

@nfeuerstein I checked the portal and there are no items which reference the custom versions of CrowdSourceManager or CrowdSourceReporter apps under SolutionsWeb\Apps\NationalIntel so there is no reason to fix the issue with the external reference.
In fact, if you don't have any objections, I would like to move the files for these custom versions of the apps out of the SolutionsWeb folder so they are not included in the Ops Server release. Ok with that?

@nfeuerstein Is it ok to remove these apps from the SolutionsWeb\Apps\NationalIntel IIS folder?

@nfeuerstein Moved out these two web apps outside of the SolutionsWeb\Apps\NationalIntel. Closing this issue.


{azure-sdk-for-go} | Updating default and accepted values

Fixes https://github.com/Azure/azure-sdk-for-python/issues/24164

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

/check-enforcer override


Update Tauri code after search endpoint changes

We changed the search response type, but I forgot to update the Tauri part to reflect it.

webapp.io is failing. Not sure why, as I can't see the logs.  @AlexMikhalev, maybe you can have a look.
But the tests pass now, so merging.


Centre of force layout not in centre of panel

Centre of force layout is not in centre of panel when displayed in Complex Portal webpage.

Fixed by pull #36


createSelector type signature prevents use of generic curried functions.

I'm trying to create a generic, curried selector for taking values out of a props argument. The curried function is type safe, but it isn't compatible with the type signature of createSelector.
type TRootState = {
  foo: { [id: string]: number };
};

export function createPropSelector<K extends string>(key: K) {
  return function<T extends { [key in K]: T[K] }>(state: TRootState, props: T) {
    return props[key];
  };
}

const state = { foo: { a: 1, b: 2 } };

const propSelector = createPropSelector("id");
/* `propSelector` has a inferred type:
<T extends {
    id: T["id"];
}>(state: TRootState, props: T) => T["id"]
*/

// In a connected component:
function mapStateToProps(state: TState, { id }: { id: string }) {
  return {
    /*
    The inferred type of `fooSelector` should be
    `(state: TRootState, props: { id: string }) => number` (see below)
    */
    a: fooSelector(state, { id })
  };
}

However, it isn't possible to compose createPropSelector:
const selectFoo = (state: TRootState) => state.foo;

export const mySelector = createSelector(
  selectFoo,
  createPropSelector("id"),
  (foo, key) => foo[key]
);
/* Assignment fails with the error:
Argument of type '<T extends { id: T["id"]; }>(state: TRootState, props: T) => T["id"]' is not assignable to parameter of type 'ParametricSelector<{}, {}, unknown>'.
  Types of parameters 'state' and 'state' are incompatible.
    Property 'foo' is missing in type '{}' but required in type 'TRootState'.ts(2345)
*/

Since the generics T and T[K] are not yet defined, the returned function can't be cast to ParametricSelector:
export function createPropSelector<K extends string>(key: K) {
  return function<T extends { [key in K]: T[K] }>(state: TRootState, props: T) {
    return props[key];
  } as ParametricSelector<TRootState, any, any>; // This works, but we lose the types of `props` and the return value.
}

Fortunately this isn't a big deal since it's easy enough to write (state: RootState, props: { id: string }) => props.id when a props value is required, but it would be nice to be able to abstract this since I use it quite a bit in my javascript codebases.

Meh, I settled on adding a type parameter, which I guess isn't too ugly.
export function createPropSelector<T>(key: keyof T) {
  return function(state: RootState, props: T) {
    return props[key]
  } as ParametricSelector<RootState, T, T[typeof key]>
}


Loading parameters for multiple ign_ros2_control plugins

I'm trying to run two different robots simultaneously in Fortress (ROS2 Humble) using ign_ros2_control. Each robot is namespaced and launches its own instance of the ign_ros2_control plugin, and both a Diff Drive controller and Joint State Broadcaster. Each robot has its own namespaced parameter file for the controllers. The nodes and topics are all being namespaced correctly, but the issue I am seeing is that when I spawn the second robot, the controller manager seems to be loading the parameter file of the first robot.
Each robot defines the plugin like so:
<gazebo>
  <plugin filename="libign_ros2_control-system.so" name="ign_ros2_control::IgnitionROS2ControlPlugin">
    <parameters>/path/to/robot/param.yaml</parameters>
    <ros>
            <remapping>~/odom:=platform/odom</remapping>
            <remapping>~/cmd_vel_unstamped:=platform/cmd_vel_unstamped</remapping>
            <remapping>/tf:=tf</remapping>
            <remapping>/tf_static:=tf_static</remapping>
            <remapping>/diagnostics:=diagnostics</remapping>
            <remapping>joint_states:=platform/joint_states</remapping>
            <namespace>robot_namespace</namespace>
    </ros>
  </plugin>
</gazebo>

The parameter file path and namespace is unique to each robot.
If I add the parameters of both robots to the parameter file of the first, then everything loads and runs well. Similarly, if I use the /** wildcard for the namespace in the parameter file, then both robots will load the first robots parameters.
Is there a workaround to this issue?

This is exactly what I have noticed. Same ROS and gazebo version. Please fix it.

Have you found a workaround @roni-kreinin ?

Hey Roni @roni-kreinin
I have the same issue. Launch the script with gazebo sim and spawning two different robots. Each of the robot has the gz ros2 control plugin but with its corresponding namespace. I can see both controller managers get started. However, the second controller managers does not get its configurations from the file.
After the investigation of the code, I assume the problem is here https://github.com/ros-controls/gz_ros2_control/blob/889837d682c6cad9c6c481b1eb119dacb1aaa9a6/ign_ros2_control/src/ign_ros2_control_plugin.cpp#L326
Since one single gz plugin manages all controller manager, the rcl Context will be initialized once and with the arguments, that contain the parameter file from the first controller manager. Therefore, the solution would be to reinitialize Context or to update the parameter before the controller manager could be created.
Could it be fixed, since the workaround does not scale-up?

I'm still facing this issue as mentionned by @roni-kreinin . Is there any progress on this ?

@roni-kreinin Could you please provide a detailed procedure for implementing this workaround?

@lklimkiewicz7 Either have all parameters in the file passed to the first robot, or us a wildcard if all robots use the same parameters.


fix circular reference

My only concern is to change files out of the scope to the PR.

I agree. I'm going to consider it in next PRs.


Coordinate test explorer documentation changes

Prepare a list of things we want the docs to mention (tips, workarounds, settings, etc) and work with the documentation writer.
Update https://aka.ms/VSTestExplorerPython to point to the documentation when the changes are in. Right now it points to the blog entry.

The aka.ms URL will need to be changed to point back to the documentation page, it is currently pointing to the blog post.


DAC ADC Test STM32H7

Some boards have a pin that is both DAC output pin and ADC input pin. So starting the DAC on this pin and then stealing the peripheral again to initialise the ADC on the same pin, we can measure the ADC output.

I would patch metapac to a rev, if possible.

I would patch metapac to a rev, if possible.

done

Closing in favor of #1697.


ci: add GitHub Workflow to copy labels in Mergify created PRs

When Mergify creates a PR, the ok-to-test label needs to be added before CI runs. Not all PRs need complete testing, and they may have some ci/skip/.. labels too. With this new GitHub Workflow, the labels get copied from the original PR into the newly created PR.
See-also: https://github.com/Mergifyio/mergify/discussions/5088

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

@nixpanic we remove the ok-to-test label once Jobs are started but we still need to add ok-to-test label when Mergify creates the PR

Right, that is true. ok-to-test is not a good example in the description. Ideally mergify adds the ok-to-test label when it creates a PR, or labels it accordingly (tried that in the config already, it is not working as expected).


BUG: fix input label accessibility

Description
When I click on label near input, I expect this input get focus, a select gets open.

The solution:
the id should be assigned to input directly, not to the wrapper

What ucc-gen version are you using?
splunk=add-on-ucc-framework==5.32.0
Additional System Info
No response

Reverted in #1061


Fetch duration takes "maxWaitTimeInMs" even when consumer is lagging behind a lot

Hi,
I'm using KafkaJS to consume a topic that has 192 partitions, and during peak hours it receives around 100 MB/s of data, that is being distributed across the partitions more or less evenly, so we can assume that each partition contains around the same amount of data.
The application using KafkaJS streams events into another system (namely, BigQuery).
The consumer is configured to operate on pretty large batches: i.e. minBytes is set to 10000000 (around 10MB) and maxWaitTimeInMs is set to 15 seconds.
During peak hours the consuming application starts to lag behind a lot. The odd thing I'm seeing in the monitoring is that even taking into account huge lag, and the fact that there are plenty of unprocessed events in the partitions, it still takes around 15 seconds for the consumer to fetch a batch of messages:

This metric is implemented based on duration value of a FETCH instrumentation event (https://kafka.js.org/docs/instrumentation-events).
I'm pretty sure that there is enough of data in partitions for the consumer to return batches immediately, since at the time of writing, the consumption of each partition lags behinds for at least 600k of records (which is around 1.2GB of data).
So I'm wondering whether:

The duration value of FETCH event can be used to monitor actual wait time for fetching batches.
In case the metric is correct then why would it wait for 15 seconds, even though there is plenty of data to return immediately.

Probably I'm missing something. So I would appreciate any help in understanding this.

I would be confident in trusting the duration field of the FETCH event, but you can also verify it against the duration of the REQUEST event. They should be roughly equal.
The behavior for this is implemented entirely on the broker side, we just pass along the configuration values in the fetch request and then the broker decides when to respond with data based on those configuration values. Based on the symptoms you're describing, it does sound an awful lot like the data is not spread out across partitions and that there's some partition that doesn't have enough data to reach maxBytesPerPartition - are you 1000% sure that this is not the case?
The way I understand it, the algorithm is in a nutshell:

Take all the partitions in the fetch request
For each partition:

if you have not reached maxBytesPerPartition, allocate up to maxBytesPerPartition of the response to data from that partition.
If you reach maxBytes, return the data accumulated up to this point.

If you have reached minBytes, return the data
If you have reached maxWaitTimeInMs, return the data
Otherwise go back to the start

@Nevon I also had similar idea about the algorithm. But something doesn't add up for me in this case.
I've tried decreasing maxWaitTimeInMs from 15 seconds to 1.5 seconds and interestingly it:

Didn't change fetched batch sizes. Before the change it fetched around 5000 records per batch, and after the deploy it remained on the same level.
The metric tracking the fetch duration started showing smaller values (around 3 seconds):

I wonder if there could be some kind of prefetching mechanism that starts fetching next batch while previous batch is still being processed (the app uses eachBatch function).
Another thing that looks odd is that after I increased minBytes to 20MB (instead of 10MB) actual size of fetched batches remained the same: around 5000 which translates into around 10MB for our events. So I wonder if there is some upper limit for the batch size (maybe some broker property controlling this). I made sure to increase maxBytesPerPartition as well (it's set to 30MB).
Just for the record, the Kafka cluster is Confluent Cloud enterprise cluster.

@Nevon I've reread you comment again, and realized that:

I don't explicitly set maxBytes and by default it's 10MB (which explains the limit for batch size I saw).
maxBytesPerPartition set to 30 MB may be too large so I will try setting it to be not much larger than minBytes.

Thank you. I will update later.

I did one more experiment to test the behavior of consumers in relation to maxWaitTimeInMs.
I've stopped one of the consumers for around an hour, in order to accumulate some lag and make sure that each partition has plenty of data to return per batch without the need to wait for maxWaitTimeInMs.
The topic has 192 partitions and at the time of testing the production rate into the topic was on relatively constant level of 20 MB/s:

While the consumer was stopped the accumulated lag reached around 250k records for each partition, which translates into around 500MB per partition in our case:

After the pause the consumer was resumed with the following config:
{
            minBytes: 20000000,
            maxBytes: 24000000,
            maxBytesPerPartition: 24000000,
            maxWaitTimeInMs: 15000
        }

The consumer consisted of 24 replicas each set to have partitionsConsumedConcurrently = 8.
Once I resumed the consumer I've got the following results:

Minimal values for Kafka fetch durations were way below maxWaitTimeInMs (just a few seconds). In a couple of minutes once the consumer processed the lag the fetch durations returned to values close to maxWaitTimeInMs. So in this case the consumer's behavior was expected in regards to maxWaitTimeInMs setting.

For some reason I wasn't able to get through 10MB ceiling per batch, even though I set minBytes, maxBytes and maxBytesPerPartition to values close to 20MB, and there was plenty of data in the partitions at the moment I resumed the consumer.

So I guess the original question regarding maxWaitTimeInMs is answered. On the other hand, I don't understand why it wouldn't let me use batches larger than 10MB, but it's not that critical since 10MB batches also work good in our case.

@thereisnospoon there are also server caps, can you double-check that your cluster can accept the values you expect? Another thing is that maxBytes will cap maxBytesPerPartition, so it's worth taking in account the number of partitions processed per consumer.

@tulios would you be able to elaborate regarding:

maxBytes will cap maxBytesPerPartition

Suppose one consumer processes 8 partitions then it makes sense to set maxBytes to be 160MB and maxBytesPerPartition to be 20MB if I want 20MB batches.

can you double-check that your cluster can accept the values you expect?
Yesterday I tried googling for broker properties that would cap returned batch sizes. I found https://kafka.apache.org/documentation/#consumerconfigs_fetch.max.bytes, but it says that by default it's 50MB. I will try to check the value for this property.

I see that for Confluent clusters Fetch Bytes is 55MB: https://docs.confluent.io/cloud/current/clusters/cluster-types.html


Metal compute tests

This PR adds support for running compute tests with the new metal backend.
The current state is:

280 tests pass
18 tests fail (generate unexpected result)
155 tests fail to compile (in the metal downstream compiler)

All tests that fail to compile are disabled using
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl

See #4291 for more details.

I don't quite understand why this change leads to the following failing tests:

tests/compute/matrix-layout-structured-buffer.slang.3 syn (dx12)
tests/compute/matrix-layout-structured-buffer.slang.4 syn (dx12)
tests/compute/buffer-layout.slang.5 syn (cuda)

Also there is one COMPARE_HLSL_RENDER test that fails on metal:

tests/bugs/texture2d-gather.hlsl

@csyonghe ?

The texture2d test may be using a vertex-fragment shader and we seem to be generating invalid vertex shader code for metal, causing the test to fail.

It sure about the matrix layout tests. None of the changes here seemed to be relevant.

I "fixed" the tests by specifying the actual APIs they should run on instead of disabling for metal.

Looks good! We can clean up the test discovery logic later to make this more elegant, but we don't have to do that now.


Update to add where IP find/search

Required items, please complete
Change(s):

Create specific search for type: ip to prevent an empty value which will cause detection to not fire and potentially not capture a real event.

Reason for Change(s):

Something has changed around Feb 6th or 7th (from some of my tenants) and now many AAD-IP (Azure Active Directory Identity Protection) events have a different data structure that causes LN36 | extend IpAddress = tostring(parse_json(Entities)[2].Address) to be moved to | extend IpAddress = tostring(parse_json(Entities)[3].Address)
There is a new value with Type: cloud-logon-request at | extend IpAddress = tostring(parse_json(Entities)[2].Address)
To work around this, the simplest fix seems to be another mv-expand with where for type of ip as suggested here.

Version Updated:

No, request PR to branch pending PR by @gitj121 https://github.com/Azure/Azure-Sentinel/pull/7360

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @devikamehra @vakohl @rushriva, please provide your feedback. Thanks

Hi @devikamehra @vakohl @rushriva, could you please provide your feedback on this. Thanks

@

@microsoft-github-policy-service agree company="Microsoft"

@microsoft-github-policy-service agree

@devikamehra that is a littler nicer; thanks for showing a better way!
@v-atulyadav version bumped
Also, since the scope of the deleted item was expanded to cover other resources, added a new entity for ResourceId so it is more clear to analyst and can populate the investigation graph


Error running process: E:\ai\stable-diffusion-webui\extensions\sd-dynamic-prompts\scripts\dynamic_prompting.py

Error running process: E:\ai\stable-diffusion-webui\extensions\sd-dynamic-prompts\scripts\dynamic_prompting.py Traceback (most recent call last):   File "E:\ai\stable-diffusion-webui\modules\scripts.py", line 451, in process     script.process(p, *script_args)   File "E:\ai\stable-diffusion-webui\extensions\sd-dynamic-prompts\sd_dynamic_prompts\dynamic_prompting.py", line 449, in process     all_prompts, all_negative_prompts = generate_prompts(   File "E:\ai\stable-diffusion-webui\extensions\sd-dynamic-prompts\sd_dynamic_prompts\helpers.py", line 93, in generate_prompts     all_prompts = prompt_generator.generate(prompt, num_prompts, seeds=seeds) or [""]   File "E:\ai\stable-diffusion-webui\venv\lib\site-packages\dynamicprompts\generators\randomprompt.py", line 70, in generate     gen = self._context.sample_prompts(template, 1)   File "E:\ai\stable-diffusion-webui\venv\lib\site-packages\dynamicprompts\sampling_context.py", line 119, in sample_prompts     command = parse(prompt, parser_config=self.parser_config)   File "E:\ai\stable-diffusion-webui\venv\lib\site-packages\dynamicprompts\parser\parse.py", line 454, in parse     tokens = get_cached_parser(parser_config).parse_string(   File "E:\ai\stable-diffusion-webui\venv\lib\site-packages\pyparsing\core.py", line 1141, in parse_string     raise exc.with_traceback(None) pyparsing.exceptions.ParseException: Expected end of text, found '_'  (at char 357), (line:3, col:147)
On latest a1111 update.
Did the branch check / checkout main / etc - commands referenced in another post to make sure I was really up to date on the latest.
I've uninstalled/reinstalled DP like 10 times now.
For the latest attempt I deactivated it, deleted the folder, deleted venv, deleted python's cache, and archived my main config files for config.json and ui-config.json
Still the error/issue persists.
Also getting double wildcard tabs in the UI even after all that, which I don't know why that's happening or if it's related.

only one tab works, and it displays double the content:

I have also re-tested with every single extension besides defaults and SD disabled and same exact error:

pyparsing.exceptions.ParseException: Expected end of text, found '_'

Please show us your prompt – this is related to it.

Found the issue based on that clue.
It was the presence of a LORA with a double underscore in the front of it.
I think I was using this exact prompt before the a1111 update, so I didn't even consider the prompt itself as an issue.
Can confirm that running it without the lora worked, and editing the file name worked.
Thanks for the help getting this working again. :)
Any idea what's causing the double wildcard manager tab?
It's something in either my config.json or ui-config.json I just can't figure out what/why I'd be seeing double tabs. (After figuring out what was causing the error I reverted to the old config files and the double tabs returned lol)

Figured this one out too.
While troubleshooting I backed up "Wildcards" from the DP folder up a level into the extensions folder - this was then detected as an extension and for some reason made another tab appear
(This one really made no sense because it's literally just a folder with a bunch of text files but mystery solved. Hope this helps someone else in the future XD)


Make FetchEvent.prototype.client nullable

E.g. for sendBeacon() or ping="" there might no longer be a client environment to expose.
(Incidentally, those also do not really care about a response, do we want to expose that differently?)

Also consider the case of navigating to a URL controlled by the service worker. There's no client environment created to receive messages from until the service worker responds. In that case there cannot be a Client object either, right?

E.g. for sendBeacon() or ping="" there might no longer be a client environment to expose.

As the type of the client concept is defined as an environment settings object. Either null or empty environment setting object seems to work here.

Also consider the case of navigating to a URL controlled by the service worker. There's no client environment created to receive messages from until the service worker responds. In that case there cannot be a Client object either, right?

It's confusing. Although the client environment for this requested resource (client request) has not been created, shouldn't FetchEvent.prototype.client return a Client object that represents the event's request's client?

What is an empty environment settings object? And what does that mean for client?

Although the client environment for this requested resource (client request) has not been created, shouldn't FetchEvent.prototype.client return a Client object that represents the event's request's client?

How does that work? What does postMessage() do? (I see in the specification you have linked postMessage() to the definition for window's postMessage(). That's bogus. You need to define it yourself.

Where does the specification define the steps to create a Client object? Surely you cannot create one before you have created the environment?

What is an empty environment settings object? And what does that mean for client?

Just an empty object in case it makes more sense to give it a symbolic name than null. It should mean null for client I think.

How does that work? What does postMessage() do?
My question is not about how it works but what the client should be conceptually? And you can postMessage() to a Client object that represents the event's request's client like as you can with the Client objects gotten from self.clients.matchAll({ includeUncontrolled: true }).

(I see in the specification you have linked postMessage() to the definition for window's postMessage(). That's bogus. You need to define it yourself.

Agreed.

Where does the specification define the steps to create a Client object? Surely you cannot create one before you have created the environment?

Yes, you cannot create one before having a client environment. My thought for the 'FetchEvent.prototype.client's value for client requests` was not about creating one without a client environment, but creating one for the event's request's client. (rather than the one for the requested resource.)
Re the steps to create WindowClient, Capture Window Client does that.
For Client objects need to be created during Handle a Fetch, I found I need to update the related text.

We haven't really explored navigation in detail yet, but I guess across origins we can't reveal the client so request's client would be null. That's something that's not clearly defined at the moment of course...

(Conceptually Client objects are not an exact match for request's client, for one because the latter can be a service worker at the moment. Perhaps we should align that somehow, but I'm not sure how. Call mine request's environment?)

Having a client for sendBeacon() or ping="" seems fine to me. Yes, the client may be gone, but that's always possible with clients. You can clients.getAll(c => c[0].focus()) and have the client shut down before it works (meaning the promise rejects).
For navigations, I agree the client should be null. If you respond with a Content-Disposition header, a scriptable client isn't created.

That seems reasonable, but in the case of sendBeacon() et al you might have to synthesize it out of thing air. Might not be too hard though but at least some of the internal slots the Client object has now need some tweaking.

Can a beacon request be initiated after https://html.spec.whatwg.org/#discard-a-document of the client?

Why not? That's the whole point no?

F2F:

Need change to nullable for navigation

Closing this issue in favor of the resolution https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-123516555. We'll not synchronously get the client in a newly designed API. The nullable state that the prospective async API will possibly return will be addressed during the algorithm work.


[FEATURE] Add GitHub Action Workflow for Unit Testing

Changes

Introduces a new GitHub Action workflow which runs unit tests when...

Commits are pushed to master
Commits are pushed to branches with PRs into master
When triggered manually in the Actions tab.

Adds a badge to the README which shows the status of unit tests on master.
Adds a zig version compatibility table to the README.

Validation Steps

See the last workflow run succeeding against the corresponding branch on the fork.

Screenshots

Description
Image

Unit Test Badge

Unit Test Workflow

Thank you for this. In hindsight I should have setup CI sooner, but better late than never.


[Gekidou] Update dependencies

Summary
Update dependencies
NONE

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/22792
https://circleci.com/gh/mattermost/mattermost-mobile/22791

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/22796
https://circleci.com/gh/mattermost/mattermost-mobile/22795


Update Dependency Walker for Windows 7/10

Environment

Item
Value

OS, Version / Build
All Versions of Windows 7 & Windows 10

Processor Architecture
All

Processor Type & Model
All

Memory
All

Storage Type, free / capacity (e.g. C: SSD 128GB / 512GB)
All

Relevant apps installed
All

Description

Microsoft's API-sets aren't supported by the last release version of Dependency Walker, so it reports dozens of false missing dependencies.
Steps to reproduce

Download the latest version of dependency walker
Load DLL or EXE in depends.exe

Expected behavior

Should not see missing API-set DLLs listed as missing dependencies

Actual behavior

See missing API-set DLLs listed as missing dependencies

There is a .NET rewrite here: https://github.com/lucasg/Dependencies

There is a .NET rewrite here: https://github.com/lucasg/Dependencies

You can get the very last version of Dependency Walker here: https://zzz.buzz/2017/05/18/download-dependency-walker/

Thanks @nmoinvaz and @rahan-crao for the assistance here 😀. I'll be closing the issue since there is an updated version of Dependency Walker.

@AvriMSFT The issue still exists with the updated version of dependency walker


Examples code in pulumi/pulumi doc comments getting dropped

The code example in the doc comments here:
https://github.com/pulumi/pulumi/blob/6f386567f6a8494853bee8fccdb455b3be1a993b/sdk/nodejs/output.ts#L70
Is not present here:
https://pulumi.io/reference/pkg/nodejs/@pulumi/pulumi/#Output-apply
It appears our doc generation is stripping out the code example

The issue seems to stem from the fact that the language is specified as ts instead of typescript. Haven't gotten into the details yet, but for some reason when ts is used, the HTML is emitted, but it has display: none on the element, which hides it.

The problem is with our langchoose.js. It sees tabs at the top of the page for JavaScript and TypeScript, and goes through and hides all code snippets that aren't the selected language (and JavaScript is selected by default). All our doc comment examples are in TypeScript, so they're all hidden by default.
Even if you select TypeScript, the snippets remain hidden because the doc comment examples use ts as the language and the langchoose.js is only looking for typescript. We could go fix those examples in pulumi/pulumi be typescript but a more general fix would be to make langchoose.js recognize that ts is the same as typescript.


antlr submodule github action issue

I wanted to temporary remore antlr from the list of submodules, until @hs-apotell  provides a full solution.... but
there is an error that happens only on the github actions (Not when checking out).
It stills mention antlr in the .gitmodules but there is no definition for it, there is some sort of caching happening.

No clue what's happening here. Looks like the .git folder got cached somehow. You might want to try removing the caching in the workflow file. Caching was a recent change and might have something to do with it (don't see how but nevertheless worth a shot).

Fixed, somehow the directory was still there with no definition in the .gitmodules, that was creating this issue


StateHasChanged() needs to be called on every component

I setup a handler like so in the main top level component.
@functions
{
    protected override void OnInit()
    {
        state.OnChange += StateHasChanged;
    }
}

However I had to add this code to every component that cared about state, which is most components.
I would have thought being at the top level that it would have rerendered and diffed the whole tree but it only seems to do component by component (which is obviously great for performance).
In which case, the component should really subscribe to state it is interested in.

In which case, the component should really subscribe to state it is interested in.

Exactly - that is the expected design. It makes sense for your state class to expose different events corresponding to different state changes, and then your presentation components can subscribe to the ones they care about.
I hope that in the near future there will be .NET state container frameworks that make this simpler to achieve, including some kind of hierarchy of state where you could subscribe at a given level and receive notifications when changes are posted at any child level.
Right now if you really want to have a single state change event, and have all your components re-render when it changes, you could create a custom base class for all your components whose Init method adds the event handler. Remember to implement IDisposable and unregister the event handler on disposal, otherwise you'll be leaking memory as the set of components changes over time.

Where should I remove the subscription to the event though?
I have implemented IDisposable on a component, and Disposed is not called when I close the browser tab.
Implementing IDisposable on a Transient service, I cannot get Disposed to be called at all.
I have impemented IDisposable on a Scoped service, and Disposed is not called either, when I close the tab.
I have no idea where and when I am supposed to clean up resources.

@FrikkinLazer You might be hitting https://github.com/aspnet/AspNetCore/issues/9893

That definitely looks like part of the problem. There seems to be a lot of work left before Blazor serverside code can be written that guarantees that no memory leaks occur.
I have a question about this  StateHasChanged() on components though.  Since every control needs to be aware of all the places where every value it binds to can change, so that it can call StateHasChanged(), how can components be made truly reusable? Every time you use it somewhere, you will have to change the controls code, to subscribe to some event somewhere, otherwise it will not update. I am propably missing something.

@FrikkinLazer Yeah, server-side Blazor is still a work in progress. One of our major focuses right now is getting server-side Blazor ready for production usage. The team is shifting focus from feature work to fundamentals like stress, perf, security, etc.
The StateHasChanged() method is the signal used to indicate that some state the component's rendering logic depends on has changed and the component should be rerendered. Typically the component's state is completely under it's own control. If you need to pass state into a component you do that with component parameters. if the component subscribes to some event that it uses to then update its state, then that's a common case where you need to call StateHasChanged() manually.
We have quite a few folks building reusable components for Blazor today (e.g. Telerik, DevExpress, Syncfusion. Some of these components are pretty elaborate.
I'd be interested to know what are the cases where you are finding this model unusable.  Please open an issue on the https://github.com/aspnet/aspnetcore repo describing the component you're trying to implement and we'll see if we can help you out.


SylvainRougeaux.Metatogger version <IP_ADDRESS>

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

The url has already been validated in previous PR. Thanks for approval.


Unable to decode instruction

The issue I am having occurs during the process of setting the mint instructions from candymachine v2 using the MintNFT struct specifically from the v2 package from this library. The error generates a message stating: cannot decode instruction for<PHONE_NUMBER>1111111111111111111111 program: unable to decode instruction: no known type for type [211 57 6 167 0 0
0 0]
Any help would be appreciated

Did you call candy_machinev2.SetProgramID(candyMachineProgramID)?
Something like this (but for v2): https://github.com/gagliardetto/metaplex-go/blob/5814aedc5ee8a0d679ddd0354d70c51cd73c4427/examples/candy/main.go#L111-L114

You can call the SetProgramID func just once. Make sure it's not called somewhere else.


Split up pipeline s3 syncing into separate steps

Currently the copy-s3-buckets step in concourse pipelines includes multiple s3 sync commands.  The final one, which conditionally runs for ocw-www only, could be split into a separate step that uses the s3-sync resource.  https://mitodl.slack.com/archives/G01JPJZQX8E/p1637763373291400?thread_ts=1637685129.280200&cid=G01JPJZQX8E

On second thought, this might increase the number of containers used in each pipeline build, increasing the odds of hitting the max containers reached error.


Having a compile error with the ST7735

When I compile I get this error:
D:/vsarm/school/pico_effects/main.c: In function 'main':
D:/vsarm/school/pico_effects/main.c:238:31: error: incompatible type for argument 1 of 'busy_wait_until'
238 |         busy_wait_until(start + US_PER_FRAME_60_FPS);
|                         ^~~~~~~~~~~~~~~
|                               |
|                               uint64_t {aka long long unsigned int}
In file included from D:/vsarm/sdk/pico/pico-sdk/src/common/pico_time/include/pico/time.h:11,
from D:/vsarm/sdk/pico/pico-sdk/src/common/pico_stdlib/include/pico/stdlib.h:12,
from D:/vsarm/school/pico_effects/main.c:32:
D:/vsarm/sdk/pico/pico-sdk/src/rp2_common/hardware_timer/include/hardware/timer.h:106:38: note: expected 'absolute_time_t' but argument is of type 'uint64_t' {aka 'long long unsigned int'}
106 | void busy_wait_until(absolute_time_t t);
|                      ~~~~~~~~~~~~~~~~^
D:/vsarm/school/pico_effects/main.c: At top level:
I am using the latest GCC compiler.

You are compiling in debug mode. This is one of my pet peeves of Pico SDK. It changes datatypes of some functions when enabling debug. It should not be enabled by default so you are probably turning debug mode on by yourself. If something has changed in Pico SDK and debug mode is now default, you can turn it off by defining NDEBUG.
target_compile_definitions(firmware PRIVATE
  NDEBUG
  HAGL_HAL_USE_SINGLE_BUFFER
...

I just tested with latest Pico SDK and debug mode is not enabled by default. There was one othe minor issue though. I will merge the fix soonish:
https://github.com/tuupola/hagl_pico_mipi/pull/33

No feedback, closing.


Add virtual packages in run into the hash

That is a relatively recent thing in conda-build.

Discussion here: https://github.com/conda/conda-build/pull/4606
The idea is that this enables building platform specific noarch packages.

The way this should be done in our case is that we add the __osx: <matchspec> or other virtual package specifiers to the variant table and then it will be automatically part of the hash. That is also simpler for the implementation.
We can also make it specific to only happen when building noarch packages.

I reached this issue when I used a platform-specific noarch package saxon-he.
I would appreciate it if rattler-build could also handle this feature.
In the meantime, I will manually manage the build hash in the recipe.

I already have some parts of the implementation in https://github.com/prefix-dev/rattler-build/pull/1122 - I will add a test to make sure it works!

Thank you for your prompt reply, @wolfv!
I'm excited for its release!


"is trying to connect to clients3.google.com" on app start?

I have LuLu running on my mac OS to monitor outgoing connections and just noticed that every time I launch the app, LuLu pops up saying that RN App is trying to connect to google!
It stopped warning me once I commented out my useNetInfo() line
Just curious why it's trying to ping google if I'm only checking whether the connection type is wifi not (not internet connection)?

This is related to the internet connectivity feature. It used Chrome's captive portal detection URL to work. There is an open PR to make this configurable.

@matt-oakes was that PR merged or closed? A url ref would be really useful 👍🏼

👋 It was fixed and the details are in the README:
https://github.com/react-native-netinfo/react-native-netinfo/tree/371acf957cb25275395a268fd61a285e60a01acf#netinfoconfiguration

@matt-oakes what should the response for reachabilityUrl be in order for the hook to return isConnected: true.
I've tried different endpoints, and even if the status is 404, isConnected is returned true

My bad. It's not about the status or what format the response has. It's about the time of the response and if any. Correct?


Expose API to listen to performed commands

Similar to atom.commands.onWillDispatch and atom.commands.onDidDispatch. This would be useful for extensions wanting to perform some action before or after a command is performed.
Being able to determine the source of the event would be useful in such an API (mouse vs keyboard vs command palette).

duplicate of #1431


Behaviour of Type Methods in Multi

If Multi is holding an IPv4-embedded address, should that IP be treated purely as IPv4 or should it treated as potentially both IPv4 and IPv6?
Example
The address <IP_ADDRESS> (when using the compatible embedding strategy) is a loopback address if viewing as IPv6 (::1), but also not a loopback address (127.x.x.x) if viewing as an IPv4-embedded address.
Implementation
The type methods can be implemented as either of the following two examples, depending on what is decided:
// Checks if it a loopback address according to IPv6, if not try rechecking
// as IPv4 (if it's embedded). This is the current (4.0.1) behaviour.
return parent::isLoopback()
    || $this->isEmbedded()
    && (new IPv4($this->getShortBinary()))->isLoopback();

// Try as both IPv4->isLoopback() and IPv6->isLoopback().
Multi::factory('<IP_ADDRESS>', new Strategy\Compatible)->isLoopback(); // bool(true)

// If it's an IPv4-embedded address, check as IPv4 only.
// If it's not, check as IPv6.
return $this->isEmbedded()
    ? (new IPv4($this->getShortBinary()))->isLoopback()
    : parent::isLoopback();

// Try only as both IPv4->isLoopback() because it's an IPv4-embedded address.
Multi::factory('<IP_ADDRESS>', new Strategy\Compatible)->isLoopback(); // bool(false)

Solution: use second implementation (IPv4-embedded is treated as IPv4 only) to make behaviour consistent across helper and type methods, and document change.


"Framework 'CsoundLib' not found" error. AudioKit v2.3

macOS Version(s) Used to Build
macOS 13 Ventura
Xcode Version(s)
Xcode 14
Description
I have an old objective-C project where is using AudioKit v2.3 https://github.com/AudioKit/AudioKit/releases/tag/v2.3.
Could not launch on Xcode 15.0.1. I've made all steps described in INSTALL-iOS.md. Tried as dynamic/static lib. But all the time got error "Framework 'CsoundLib' not found". How can I fix this error?
Xcode 15.0.1
OS Ventura 13.6.1
P.S. using the latest release not suitable - because API has changed globally. I need only launch project on Xcode 15.
Crash Logs, Screenshots or Other Attachments (if applicable)

AudioKit 2 is no longer supported, sorry.


Aspire Testing: the ability to collect Aspire AppHost logs

Is there an existing issue for this?

[x] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
I'm trying out writing integration tests with Aspire for an application involving a number of microservices and a SQL Server resource. So far the impression is very positive. However, when I attempted to run the tests on Azure DevOps, they failed due to timeout during the initialisation of SQL Server. I'm trying to debug the issue but I can't get the logs from Aspire apphost. The logs are posted to console when I run Aspire as an application. But when it's the a test project that initializes the Aspire apphost, the logs are not appended to the test host's own logs and aren't displayed when running dotnet test.
Describe the solution you'd like
It would be good to have an ability to automatically collect Aspire apphost logs (and optionally resources' own logs) and dispatch them to the test host so that they would be displayed by dotnet test.
Additional context
I'm using Aspire 8.2.1 on .Net 8.0.403 on Ubuntu 22.04.5 LTS.

What test framework are you using?

I use NUnit 4.2.2

I don't know if it's possible to circumvent the test framework. Associating output with a test AFAIK is test framework specific.

Ok, got it. I'll close the issue then.


feat(extension): build tooling for different browsers

Fix #202

:tada: This PR is included in version 3.31.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update system actor

Issue summary

https://github.com/filecoin-project/specs-actors/tree/master/actors/builtin/system
Other information and links

Very simple actor to implement, only a constructor. Will leave this for anyone who wants an easy intro into actor implementations


[DO-NOT-MERGE] Latest paradox deps test

This PR is just here to demonstrate what is said here, specifically that even though sbt-paradox-material-theme may be compiled against sbt-paradox/sbt-paradox-theme 0.9.2, it will work completely fine with sbt-paradox/sbt-paradox-theme 0.10.6
In order to demonstrate this, check out the PR's branch and make sure to set JDK to 11 (since sbt-paradox/sbt-paradox-theme 0.10.6 only supports JDK 11+) and run the following command
sbt "sbt-paradox-material-theme/scripted paradox/latest-paradox-deps"

Ideally we would actually add this as a scripted test to the repo but unfortunately there isn't an easy way to do this since the rest of the tests only run on JDK 8 and this scripted test needs to be run with JDK 11 specifically (this is why the CI is failing)

Closing PR since it was just a demonstration


MSBuild parameter /p:GenerateDocumentation=false getting ignored

Hi,
I use TFS Build agen on premise and I have configured my solution build to include the MSBuild parameter /p:GenerateDocumentation=false (as this is an internally deployed solution). However I notice that the XML documentation files are still being generated by the Roslyn compiler.
Do I need to use another MSBuild swith to (globally) disable the XML documentation generation?
Command line :
"D:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\15.0\Bin\msbuild.exe" "D:\Agent1_work\12\s\Build\A\Solutions\MyBuild.sln" /nologo /nr:false /dl:CentralLogger,"D:\Agent1_work_tasks\VSBuild_71a9a2d3-a98a-4caa-96ab-affca411ecda\1.119.0\ps_modules\MSBuildHelpers\Microsoft.TeamFoundation.DistributedTask.MSBuild.Logger.dll";"RootDetailId=f4898fed-92af-4959-8a0a-a738cf06b707|SolutionDir=D:\Agent1_work\12\s\Build\A\Solutions"*ForwardingLogger,"D:\Agent1_work_tasks\VSBuild_71a9a2d3-a98a-4caa-96ab-affca411ecda\1.119.0\ps_modules\MSBuildHelpers\Microsoft.TeamFoundation.DistributedTask.MSBuild.Logger.dll" /p:OutDir=D:\Agent1_work\12\b\MyBuild /p:AllowedReferenceRelatedFileExtensions=".pdb" /p:GenerateDocumentation=false /p:platform="Any CPU" /p:configuration="Release" /p:VisualStudioVersion="15.0" /p:_MSDeployUserAgent="TFS_f34008ba-370e-492f-9e2b-88fef545c6c0_build_1073_50124"
In the MSBuild output I find following info :
CoreCompile:
  D:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\15.0\Bin\Roslyn\vbc.exe /noconfig /imports:Microsoft.VisualBasic,System,System.Collections,System.Collections.Generic,System.Data,System.Diagnostics,System.Linq,System.Xml.Linq /doc- /optioncompare:Binary /optionexplicit+ /optionstrict+ /optioninfer+ /nostdlib /rootnamespace:AA /sdkpath:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2" /highentropyva+ /doc:obj\Release\A.xml /define:"CODE_ANALYSIS=-1,CONFIG=\"Release\",TRACE=-1,_MyType=\"Windows\",PLATFORM=\"AnyCPU\"" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Core.dll","C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Data.dll","C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.dll","C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Runtime.Serialization.dll","C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.ServiceModel.dll","C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Xml.dll","C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5.2\System.Xml.Linq.dll" /debug:pdbonly /filealign:512 /optimize+ /out:obj\Release\A.dll /subsystemversion:6.00 /resource:obj\Release\A.Resources.resources /target:library /utf8output MyCode.vb "My Project\AssemblyInfo.vb" "My Project\Application.Designer.vb" "My Project\Resources.Designer.vb" "My Project\Settings.Designer.vb" "C:\Users\TFSBUILD\AppData\Local\Temp\.NETFramework,Version=v4.5.2.AssemblyAttributes.vb" /warnaserror+:41999,42016,42017,42018,42019,42020,42021,42022,42032,42036
  Using shared compilation with compiler from directory: D:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\15.0\Bin\Roslyn

CopyFilesToOutputDirectory:
  Copying file from "obj\Release\A.dll" to "D:\Agent1\_work\12\b\MyBuild\A.dll".
  A -> D:\Agent1\_work\12\b\MyBuild\A.dll
  Copying file from "obj\Release\A.pdb" to "D:\Agent1\_work\12\b\MyBuild\A.pdb".
  Copying file from "obj\Release\A.xml" to "D:\Agent1\_work\12\b\MyBuild\A.xml".

With kind regards,
Hans

The documentation file is created by the Vbc task if the item DocFileItem has a value. That item is created if the property $(DocumentationFile) is defined. The default templates generally populate that property in the .vbproj file explicitly.
You could edit your project files to make the DocumentationFile definition conditional, if you wanted to, but there doesn't appear to be a built-in off switch if your projects declare that they want documentation.
I don't see any reference in a preprocessed .csproj to a property named GenerateDocumentation. How did you find that? Did you see it in documentation somewhere?

On the Common MSBuild project properties page (https://docs.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties) you can find the property GenerateDocumentation:

A boolean parameter that indicates whether documentation is generated by the build. If true, the build generates documentation information and puts it in an .xml file together with the name of the executable file or library that the build task created.

Together with the MSBuild command line reference (https://docs.microsoft.com/en-us/visualstudio/msbuild/msbuild-command-line-reference) speficiation that you can use /p:name=value to override project properties:

Set or override the specified project-level properties, where name is the property name and value is the property value. Specify each property separately, or use a semicolon or comma to separate multiple properties, as the following example shows:
/property:WarningLevel=2;OutDir=bin\Debug

And thus, I expected that adding the /p:GenerateDocumentation=false to the MSBuild command, that no XML documentation files would be generated.

Thanks! That explains why I didn't see it: this is a Visual Basic-only parameter.
I can see in your command line that the Vbc task is passing /doc-, but it appears to be overridden by the (later) /doc:obj\Release\A.xml.
That task is built from the Roslyn repo so I'm going to move this bug over there. I also sent a PR to the docs repo to clarify when this property is used.

This issue was moved to dotnet/roslyn#21371

@rainersigwald  Thanks for the clarification and directing this issue to the correct repo.


Support for google analytics

Using https://github.com/react-ga/react-ga

Looks like I'll have to deploy this to test, due to url checking.


[SwaggerSchema("The date it was created", Format = "date")] in README not working

I've added [SwaggerSchema("The date it was created", Format = "date")] to a property, and enabled the annotation c.EnableAnnotations();. But it doesn't seem to work. When applyin a schema filter to the class level, I don't get the enriched information from SwaggerSchema attribute.
v5.6.3

Please create a minimal app (i.e. starting from an empty project) that repro's the issue and post to github so I can pull down and troubleshoot

Please create a minimal app (i.e. starting from an empty project) that repro's the issue and post to github so I can pull down and troubleshoot

Created a minimal example at https://github.com/arisliang/SwaggerSchemaExample, SwaggerSchema attribute is at https://github.com/arisliang/SwaggerSchemaExample/blob/9ffc049125813ae9b3e63ab8a7f2b419c7febae0/SwaggerSchemaExample/WeatherForecastGet.cs#L15

Created a minimal example at https://github.com/arisliang/SwaggerSchemaExample, SwaggerSchema attribute is at https://github.com/arisliang/SwaggerSchemaExample/blob/9ffc049125813ae9b3e63ab8a7f2b419c7febae0/SwaggerSchemaExample/WeatherForecastGet.cs#L15

I'm able to get needed information from SchemaFilterContext now.

I'm able to get needed information from SchemaFilterContext now.

Hey @arisliang did you ever get this attribute working? I specified "date" format but it appears as 2021-05-26T13:38:40.441Z


HTML5 and CSS template only

Hi,
I need to use this template without node environment.
How to convert this template to HTML, CSS and JS only..?

Hi, currently it works without the need of nodejs, just download the repo and look at the build folder for the css and js and for html at the production folder for the html examples

Thanks for the reply @William-H-M :)
Cheers :+1:


[DESIGN] Map Issues

Currently multiple pins are being hidden if they're entered with the same general location, ie: Canada.
Pins also fall directly in the centre of the country, which may be unavoidable, but stands out for some (ie: why are all the "Canada" entries in the middle of Alberta?).
"Featured" entries are not visible on the map if they're older entries, they are covered by black pins. If only featuring 4 entries, it doesn't seem functional/efficient to use the red pin colour for this on the map.

This issue can be used for design ideas to solve these problems. There's been some discussion of clustering, etc. to show the number of entries in particular locations (similar to the map on the legacy website). I'll post a quick sketch of another idea I had, where if one of those "central" pins are clicked, there would be a popup over the map area which offers a slideshow/scrolling interaction to see all of the entries behind that pin. Makes me think we should make those "central" pins or any pin with multiple entries larger, or use the red for that maybe. Thoughts welcome from team members.

couple sketches from my notebook, saving here:


parse XML & js

parse XML & js

how to parse xml data in js?

https://stackoverflow.com/questions/17604071/parse-xml-using-javascript
https://stackoverflow.com/questions/7949752/cross-browser-javascript-xml-parsing
https://stackoverflow.com/questions/649614/xml-parsing-of-a-variable-string-in-javascript/8412989#8412989

parse XML & JSON & js

how to parse xml data into json in js?

https://stackoverflow.com/questions/1773550/convert-xml-to-json-and-back-using-javascript
https://www.fyneworks.com/jquery/xml-to-json
http://www.xml.com/pub/a/2006/05/31/converting-between-xml-and-json.html

https://github.com/abdmob/x2js
https://davidwalsh.name/convert-xml-json
https://www.sitepoint.com/how-to-convert-xml-to-a-javascript-object/

https://codepen.io/craigbuckler/pen/yPqLXW

FishEye
https://en.wikipedia.org/wiki/FishEye_(software)

Fisheye is a revision-control browser[1] and search engine owned by Atlassian, Inc.

https://www.atlassian.com/software/fisheye
https://source.jboss.org/browse

https://davidwalsh.name/convert-xml-json

XML-to-JSON
https://codepen.io/webgeeker/pen/LgOGWZ


Optimize Dockerfile for cache usage

Saves lots of developer time running make / docker build, by
reordering instructions to better use the cache when we make changes to
scripts, and also reduce number of layers leading to a smaller time to
build.
For instance, a developer might run the command below multiple times in
a row while making changes to the scripts that are copied into the
image:
make VERSION=3.2 SKIP_SQUASH=1

Tired of slow builds while working on #184, I've made these changes to the Dockerfile.
@hhorak @omron93 @bparees @php-coder PTAL
If we have agreement on the changes for the 3.2 Dockerfile I'll apply similar changes the other Dockerfiles before merge.

LGTM.

@rhcarvalho Why not to move ENV before RUN? (it would same build time even more)

Why not to move ENV before RUN? (it would same build time even more)

Yes, it wouldn't change anything for now.
Because the first RUN instruction doesn't depend on any of the variables set in the ENV instruction, I put the ENV after RUN so that we can add/remove/edit variables without invalidating the cache for the yum install, which is definitely the one that benefits the most from a cache hit.

Because the first RUN instruction doesn't depend on any of the variables set in the ENV instruction, I put the ENV after RUN so that we can add/remove/edit variables without invalidating the cache for the yum install, which is definitely the one that benefits the most from a cache hit.

It depends what we think that changes more often ;-)

It depends what we think that changes more often ;-)

Yes, I agree, that's not science.
They are probably similarly (un)likely to change. Since they don't depend on each other, my logic was to put the most "expensive" instruction first, as I explained.

my logic was to put the most "expensive" instruction first

You are right. LGTM

@bparees PTAL

Once we get to an agreement with the 3.2 Dockerfile, I still need to change the other image versions and RHEL.

@rhcarvalho RHEL7 tests are failing because in result image
bash-4.2$ ls -l /var/lib/mongodb/ -a
total 4
drwxrwxr-x.  3 mongodb root   17 Oct 10 09:37 .
drwxr-xr-x. 14 root    root 4096 Oct 10 09:38 ..
drwxr-xr-x.  2 root    root    6 Oct 10 13:40 data

RHEL7 tests are failing because in result image

There are no changes to the RHEL Dockerfile so far ;)
Doesn't that mean that tests do not pass with current master?

@omron93 @hhorak could you help me understand why the RHEL7 check is failing? There are no changes to the RHEL Dockerfiles (yet). I want to see it green before pushing changes to the RHEL images to match the 3.2 CentOS.

could you help me understand why the RHEL7 check is failing? There are no changes to the RHEL Dockerfiles (yet). I want to see it green before pushing changes to the RHEL images to match the 3.2 CentOS.

@rhcarvalho There was an problem in RHEL7 testing - it tested centos version (only in RHEL environment). And in this PR it failed.
For me, local centos testing also failed.

From mongod log
2016-10-11T07:01:30.925+0000 I STORAGE  [initandlisten] exception in initAndListen: 98 Unable to create/open lock file: /var/lib/mongodb/data/mongod.lock errno:13 Permission denied Is a mongod instance already running?, terminating

see https://github.com/sclorg/mongodb-container/pull/193#issuecomment-252622123

@omron93 how to re-run the tests? I want to see the RHEL7 check green, to avoid wasting time trying to fix the test execution later.

Alright, VOLUME needs to come after the RUN instruction that creates directories and changes permissions. Updated.

@rhcarvalho sorry, merged this prematurely.


GitHub Action to add/remove triage labels as-needed

resolves #69
Description & motivation
What?
When the maintenance team triages, we sometimes need more information from the issue creator.  In
those cases we remove the triage label and add the awaiting_response label.  Once we
receive a response in the form of a comment, we want the awaiting_response label removed
in favor of the triage label so we are aware that the issue needs action.
Why?
To help with out team triage issue tracking
When?
This will run when a comment is added to an issue and that issue has the awaiting_response label.

@dbeatty10 Is there a preference to use this over https://github.com/dbt-labs/dbt-adapters/pull/70?


Docs page says Private Endpoint for Service Bus still in preview but Azure Update says GA

[Enter feedback here]
The note at the bottom of this doc page says Private Endpoint is in Preview (page updated June 2020). However this page https://azure.microsoft.com/en-us/updates/azure-private-link-is-now-available-for-multiple-new-azure-services/ from May 14 2020 says Private Link is GA for services including Service Bus.
Could you please check if the note on the doc page is still accurate or if it needs to be updated?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c362e8fa-107b-8aa6-ae81-d1d622a74498
Version Independent ID: 56b83f30-3937-6a3c-e21b-b0c005d6240d
Content: Network security for Azure Service Bus - Azure Service Bus
Content Source: articles/service-bus-messaging/network-security.md
Service: service-bus-messaging
GitHub Login: @axisc
Microsoft Alias: aschhab

Hello @axisc, Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

#reassign:spelluru

Thank you @plzm
The page is updated now.
#please-close


Feature Request: Add more options to make output log a bit narrower

I would really liked it if those features were implemented:

[ ] Omit function parameters, only print the namespace/name
[ ] Add source base dir.
So it does not print D:\Programming\GitHub\Project\src\stuff\abc\main.c
But rather                src\stuff\abc\main.c
[ ] Omit std functions

Maybe add a struct of all those settings to the print() method.
Depending on how fancy those settings should be definable you can do something like this
// default settings
cpptrace::generate_trace().print();

// custom settings
auto base_dir = cpptrace::current_file("../../.."); //?
cpptrace::generate_trace().print(
    cpptrace::trace_print_settings()
        .set_output(std::cout)
        .set_color(false)
        .set_project_dir(base_dir)
        .set_omit_out_of_project_functions(true)
);

Hi thanks for opening this. I'm wondering whether this is something that should be done on the library side or the user side of things.
In one of my other libraries, libassert, which uses cpptrace I do a bunch of trace processing to make things look nice (like shortening file paths, folding recursive frames etc, and cleaning up type names in the signatures). I always envisioned this as being how the library would be used; cpptrace does all the "hard work" of generating the trace and the user figures out what to do with it.
That being said, I can see how it might be useful to provide some helpful trace cleaning utilities that are generally useful. I'm not immediately sure how best to go about doing this and where to draw the line between generally useful and more project-specific. I'd be interested in your thoughts

I understand and appreciate the work that this library does, but I feel like a bit of customizations or at least some helpers would be a nice addition.

I thought about modify the frames by myself,
    for (auto it = trace.frames.begin(); it != trace.frames.end(); ++it)
    {
        auto frame = *it;
        if (ShouldBeSkipped(frame))
        {
            it = trace.frames.erase(it);
            continue;
        }

        frame.filename = MakeNiceFilename(frame.filename);
        frame.symbol = MakeNiceSymbol(frame.symbol);
    }

but then I have to parse the filename and symbol by myself.
It would be much easier if the symbol would not be a std::string and had at least a custom data type like
struct cpptrace::function_symbol {
    std::string declaration_owner; // namespace / class path
    std::string name;
    std::vector<cpptrace::function_parameter> parameters;

    std::string to_string() const;
}

struct cpptrace::function_symbol {
    std::string type_declaration_owner; // namespace / class path
    std::string type_name;
    // std::string parameter_name; // impossible to get?

    std::string to_string() const;
}

Thanks for the thoughtful response. I'm inclined to agree cpptrace should do much more on the formatting side of things. I was just running into a use where it would have been really convenient to be able to turn off the Stack trace (most recent call first): header but of course there's no option for that.
I think some sort of cpptrace::trace_print_settings builder is a great idea. I'll give this some more thought. At the very least options to control:

The header
Color
Filtering parameters
Filtering template parameters

would make sense. Additionally:

Maybe some std:: type name filtering (though that's a big can of worms)
Maybe some sort of .filter([](const auto& frame) { return !frame.symbol.starts_with("std::"); }) instead?

Path stuff too makes a lot of sense, though it adds a fair bit of complication on the library side of things. I think stack traces typically have absolute paths, though this isn't a guarantee. Everything is at the mercy of what the compiler decided to output. Handling symbolic links would probably be out of the question, paths in a trace aren't guaranteed to exist. I think trying to add some known base directories would make sense. Possibly the out of source exclusion stuff you mentioned as well, though that might be a little trickier.
On my other library, libassert, I do some path disambiguation stuff. E.g. /home/foo/bar/baz.hpp becomes baz.hpp if it's the only baz.hpp. That's usually sufficient in a trace. If there's another baz.hpp, e.g. /home/foo/bar2/baz.hpp, then they'd be bar/baz.hpp and bar2/baz.hpp as much as is needed for differentiating the two.
Regarding parsing of the symbol, unfortunately cpptrace usually gets the symbol name as a string so that's just carried through instead of doing any parsing and whatnot :)


TypeError in /clan/bd-frands-j9y2pjl2

Error in ClashLeaders
TypeError in /clan/bd-frands-j9y2pjl2
Cannot read property '__symbol@@0.615243984158711' of undefined
View on Bugsnag
Stacktrace
https://www.clashleaders.com/static/js/vendors.8d68595a3daede5c357b.js:13 - s.Et.Ht.get [as __symbol@@0.615243984158711]

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
TypeError in /clan/bd-frands-j9y2pjl2


Enable checkstyle

Currently several checkstyle rules are disabled as there are violations
against those rules in our code. I'll submit follow-up PRs to fix the
violations and turn on the rules.

Current coverage is 66.57% (diff: 100%)

Merging #8 into master will not change coverage

@@             master         #8   diff @@
==========================================
  Files            39         39
  Lines          2576       2576
  Methods           0          0
  Messages          0          0
  Branches        463        463
==========================================
  Hits           1715       1715
  Misses          727        727
  Partials        134        134

Powered by Codecov. Last update ab79d32...b5c8766

LGTM


Bug: Tower Picker Dropdown Not Updating

Tower Picker dropdown isn't always updating correctly. It should update when:

A Tower the user has access to is DELETEd or INSERTed into the database.
The user leaves a Tower
The user is invited to a Tower (this should also trigger a toast)

This is a larger 'header not rerendering' issue. It also affects the user avatar and other such things. Trying to figure out a fix for it, the dropdown and user icon should be easy (just subscribe to updates on the database). I'm thinking using revalidate somewhere is probably the answer, but not sure where it should go exactly.


Do not throw when localVolumnes is not defined on marathon task

Fixes this issue:

Reviewer: @pierlo-upitup


WIP: Vacuum: Added support for STATES

Description:
Frontend changes: https://github.com/home-assistant/home-assistant-polymer/pull/1497
Added support for states as agreed upon in: https://github.com/home-assistant/architecture/issues/29
The xiaomi_miio platform has been updated to support the new states as part of this PR.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

Your title is 'Added support for STATES', but what you done is change STATUS -> STATES, that will break too many platforms. I would suggest you just add STATES, keep old STATUS feature aside, and allow each platform retire STATUS feature one by one.

Sounds good. That is what supported features meant to.

This should make for a better PR.
I changed it so that it hopefully will be backwards compatible and I moved the Xiaomi Vacuum platform to it's own PR.

Thanks for your quickly action. Please change demo vacuum for your new design and include it into this PR. So that we can know how the new design works.
Also add test for the demo vacuum.

Not sure if you saw the edit:
Should I keep it as ToggleEntity or should I make it an Entity? As it seems like I would have to reimplement a lot of the stuff from ToggleEntity if I change it to Entity.

I think the states for this should be discussed in https://github.com/home-assistant/architecture first.
SUPPORT_STATE is a bad name for a feature

Already done: https://github.com/home-assistant/architecture/issues/29

I changed it such that states are in a new class, which avoids touching old platforms at all.
I added a demo vacuum and added tests for the demo vacuum.
I'm pretty happy with the current code.
@awarecan ping if you want to look though it?

I'm not sure I understand your drawing.
Should I create a BaseVacuum that uses BaseVacuum.StateVacuumDevice and BaseVacuum.VacuumDevice depending on supported_features?

@awarecan I'm pretty sure I did everything you asked for except the **kwargs thing as that would require me to change all vacuum platforms, which is what we are trying to avoid. This can be done in another PR.

@awarecan any more changes needed or are we good to go?

I am okay with this change. @balloob would you mind look at it?

@MartinHjelmare Is that what you wanted? :-)

Yes!

I added a PR for the start_pause split-up, because as @arbreng pointed out, if there is ever a Vacuum that does not support pausing, there is no way to turn it on in the StateVacuumDevice I'm not sure if I did the PR correctly, as I build it on this branch and it therefor includes all of the code from this PR on top of the changes to start_pause.


Allow for getting WSDL files via HTTPS

The current code is using httpc:request only on URIs which begin with 'http://', so I cannot access a WSDL which is only served via HTTPS.
https://github.com/mjooms/scrub/blob/master/src/scrub.erl#L514

May also need to add an option to ignore invalid certificates.

I'm working on a patch in my own fork.


get_disk_details: cargo fmt + use format!().

I am splitting #7 in order to reduce the change surface of the PR. Might get access to a machine to test it, Checked jbod it's harder that I thought to install at home.

Thanks for the patch!


EAD mechanics using separate crate and enabled via features

Addressing #67.
This PR introduces a new crate, edhoc-ead, which has two subcrates: edhoc-ead-none and edhoc-ead-zeroconf. The former is a default placeholder that provides mocked functions to satisfy Rust's compiler, while the latter provides a skeleton implementation for the lake-authz draft. This structure is just like what is used with edhoc-crypto to enable multiple crypto backends.
Some remarks:

achieved goal of keeping stack-only allocations
in the current approach, only one EAD handler implementation is supported, e.g., edhoc-rs can be compiled with one of: ead-none, ead-zeroconf, ead-foobar, etc.
currently, the EAD state is global and mutable, and not in a thread safe way -- should not be a problem for now since we only have single-threaded code, but could be improved.

Finally working, I think the main goal of this PR has been reached.
Since some features changed, here are some of the updated commands to build/run/test (might add them to the README).
Test without ead (ead-none, the default):
cargo test --package edhoc-rs --package edhoc-crypto --package edhoc-hacspec --package edhoc-ead  --features="hacspec-psa" --no-fail-fast

Test with ead-zeroconf:
cargo test --package edhoc-rs --package edhoc-crypto --package edhoc-ead --no-default-features  --features="rust-psa, ead-zeroconf" --no-fail-fast

Note that --no-default-features is needed.
Flash to device with zeroconf:
cargo embed --target="thumbv7em-none-eabihf" --no-default-features --features="rust-cryptocell310, ead-zeroconf, rtt" --release

PR is merged (see here), although GitHub UI seems to disagree :upside_down_face:. Let's wait a bit, might be a temporary bug on GitHub side.

The GitHub UI insists it is not merged yet. Should I just close it?

Yes, please do


Sign in page popup for login.

How to integrate login page to UI.

Don't know.

this Chatbot UI doesn't have support for login form

see i try something like that with after click current one

after click

see this look like this

this widget is fully customizable & I see you have designed the login form, so what's the issue?

issue is that i want validations from custom action take those parameter(login_id,pass) from user and pass to custom action.

since you have added the login form I don't know the design of it, you need to handle those things, I can't help you with this but I can suggest that you can pass the parameters to rasa, you can add rules for the same in which you can can call the custom actions, calling custom actions directly will affect the conversation flow

I am closing this issue since this is not the feature of my widget, thanks

ok thanks


[dv] Add macro DV_LC_TX_DIST and update get_rand_lc_tx_val

lc_tx_pkg::On/Off is different than Mubi4True/False
Add a macro so that users can use DV_LC_TX_DIST in constraint
And update get_rand_lc_tx_val to use this constraint macro
Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

It's not that this patch is wrong but I don't really understand it: I think the existing code already did the same thing. Any particular reason to rip it out? (@sriyerg, since you were involved in the previous version)

It's not that this patch is wrong but I don't really understand it: I think the existing code already did the same thing. Any particular reason to rip it out? (@sriyerg, since you were involved in the previous version)

nothing wrong on the previous code. just because I added DV_LC_TX_DIST macro, so that we can directly use it in the constraint. I feel it's better to use DV_LC_TX_DIST in get_rand_lc_tx_val, which is more consistent with other get_rand_mubi functions. WDYT?

Oh, now I understand. Looks good to me!

LGTM.


Make ShapedArray imports compatible with jax==0.4.14 deprecation.

Jax <IP_ADDRESS> deprecated importing ShapedArray from jax. Changed all ShapedArray imports to come from jax.core.

@sschoenholz @ekindogus We might want to bump up the version on PyPi again because this error currently persists.


coverageThreshold to support negative zero values

🚀 Feature Proposal
I understand that a coverageThreshold of 0 translates into 0% and that's all fine and good, but seeing as negative values express uncovered lines, it stands to reason that a value of -0 should relate to zero uncovered lines, which is the same as 100%.
Object.is(0, 0)
// true
Object.is(0, -0)
// false

Motivation
It was just unexpected behavior when I put a -0 in there and expected it to mean "zero uncovered lines."
Example
It makes a lot of sense if all your values are negatives.
    "coverageThreshold": {
      "global": {
        "statements": -42,
        "branches": -0,
        "lines": -100,
        "functions": -31
      }
    },

Pitch
Unexpected behavior is all I got. I wouldn't quite call it a 🐛, but it's kind of gray area here, I think.

I think that negative values could make sense if the thresholds were related to absolute numbers but they currently represent percentages. How would this look when codebases grow and you want to guarantee a percentage of code covered?

I think the request is about percentages as usual (not absolute numbers), just that if the threshold T is negative, it should become 100 + T (e.g. 100 + -42 = 58).
Not sure if this provides that much value though. Things like this are already often handled differently (scale 0 to 1 or 0 to 100 etc.), so making it more complex is probably not a good idea.
If you configure Jest in JS, you can already make it 100 - 42 if you want to specify a percentage of lines not to be covered.

Perhaps I wasn't clear about the existing feature of negative values, which have nothing to do with percentages, but lines "uncovered."

Thresholds specified as a negative number represent the maximum number of uncovered entities allowed.

https://jestjs.io/docs/en/configuration#coveragethreshold-object
Negative zero is just a way of telling Jest that we want a maximum number of zero uncovered entities allowed instead of 0% coverage, which is a totally different thing.

Oh wow, looks like neither @mattphillips or I knew that this feature existed 😅

I forgive you!

I still need this and run into this issue on a regular basis. I’m forced to use -1 for now, which isn’t ideal.


Import tests issues

There are some issues with tests framework:

[x] simpleif_0 - intermediate check tries to interpret boolean values as floats. fails.
[x] unstack - intermediate passes, but output check fails with npe. somthing off with naming?
[x] simple_while and simple_cond complaint about same variable greater. To be investigated.

Can't confirm fix. I still see the same exceptions.

Made more fixes. Other than unstack (which I can confirm is a test issue) I see all the conditionals passing. Please confirm.

Confirmed.