Add Visual Basic 6.0 as its own language

Description
This pull request adds VB6 as its own language and removes the aliases for VBA that were related to VB6.
This PR aims at solving issue #5824 and takes major inspiration from PR #4725.
For the color, I went with a green close to the green from the VB6 logo.
The extensions provided aren't shared with any languages in languages.yml, so no additional grammar or heuristic is necessary. The VB.NET grammar should suffice for now as it was also the grammar used when adding VBA.
Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3Actl+End+Sub+NOT+nothack
https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3ADsr+End+Sub+NOT+nothack

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

https://github.com/kellyethridge/SimplyVBUnit/blob/master/Source/Component/UIListBox.ctl
https://github.com/jaygadhave/BCA-BCS-MANAGEMENT-SYSTEM/blob/ebaed2ee5141dff5a3573a358d5440eb1dc0cd70/DataReport1.Dsr
https://github.com/bmbodj/ECSE437-Project/blob/fd28fdbe07bd1c7a1ea60650fc91ef18e49d1bef/main/migrationanalysis/src/wizard/Wizard.Dsr

Sample license(s):

kellyethridge/SimplyVBUnit: MIT
jaygadhave/BCA-BCS-MANAGEMENT-SYSTEM: MIT
bmbodj/ECSE437-Project: Apache License 2.0

[ ] I have included a syntax highlighting grammar: [URL to grammar repo]
[ ] I have updated the heuristics to distinguish my language from others using the same extension.

And regarding the .Dsr sample, I was a little bit limited by the fact that a license is needed. The problem with the current sample is that it has no sub procedures defined in it. We only have designer metadata. This is representative of a good portion of .Dsr files, but for completeness, I think might be useful to add another sample with a few sub procedure definitions.

Thanks @lildude!

Does the new modification make an association between ".vbp" and Visual Basic 6.0, or ".vbw" and Visual Basic 6.0?
If it doesn't, can you please make this possible? Because if you look at my own Visual Basic 6.0 projects, there are no ".ctl" or ".dsr" files at all. But all the Visual Basic 6.0 projects that I have seen so far have something in common: files with the extension ".vbp" and ".vbw". More than likely for this reason we do not see any change.

Does the new modification make an association between ".vbp" and Visual Basic 6.0, or ".vbw" and Visual Basic 6.0?

No. You'll need to use a manual override. I see this has also been asked and answered in https://github.com/github/linguist/issues/5824

Does the new modification make an association between ".vbp" and Visual Basic 6.0, or ".vbw" and Visual Basic 6.0?

No. You'll need to use a manual override. I see this has also been asked and answered in #5824

Thanks for the replay. In my view it is not ok to use manual override for VB6 projects on GitHub. I personally am curious how many VB6 projects are on GitHub. This language is among the most important languages produced by our civilization. I mean, there are new languages that no one has ever heard of that are listed by the linguist, while VB6 is not. VB6 was the most popular computer language in the world for a long time and today it is used by a large mass of scientists and engineers for prototyping projects. Recognizing the VB6 language by default is a decent thing to do on GitHub. I am certain in the end this will be resolved.

Recognizing the VB6 language by default is a decent thing to do on GitHub. I am certain in the end this will be resolved.

Indeed. As I mentioned in the issue, a heuristic would be needed to do this. Please feel free to submit a PR that implements such a heuristic.
Locking this as the discussion should be taking in place in issues now this PR has been merged.


skeleton es-next details

Application source code is maintained in https://github.com/aurelia-auth0/auth-templates/tree/master/skeleton-esnext

Summary
This application (based on the Aurelia skeleton navigation original sample) illustrates the simplest use of Auth0 PaaS - in order to gain access to the GitHub Users page, it requires authentication:

Implementation details
Since this document (as well as others in the same collection) is created not only to introduce other libraries and services of interest to Aurelia developers, but to also suggest some of the best Aurelia practices to utilize these services and libraries.
1. Application structure
2. Separation of concerns
2. Proper use of Aurelia DI
x. Deployment at gh-pages

Application structure

2. Separation of concerns

3. Proper use of Aurelia DI

4. App navbar  and "authentication state"
Some details on implementing the behavior mentioned in the Item 3 above:

5. Deployment at gh-pages

6. Issues that need more discussion

Looking good.
It would be great to show how to access a protected server resource. Perhaps one way to do this, while keeping in line with the skeleton sample, is to shift the call to GH from the client to the server. To get the GH user listed, a call would need to be made to some REST endpoint that you create on your own server, and only if you send a valid access token in the request will that endpoint be accessible. That endpoint would then just make a server-server request to GH for the users list and then send it back to the client.
What do you think?

Now I do know that we work well together and I do look forward to our future work. What you proposed below is precisely (to the point) what I already did, just not published on the form to share with you. To prove this claim please check the following:
The sample at https://github.com/aurelia-auth0/auth-templates/tree/master/skeleton-esnext-fs consists of two “projects” where the ‘be’ stands for back-end and ‘fe’ denotes front end

The front end application is functionally identical to deployed sample at https://aurelia-tools.github.io/esnext-auth0/ - the difference is only in obtaining JWT token from Auth0 PaaS and using it to get the GitHub Users data that the back end will deliver only to authenticated users.
The back end (https://github.com/aurelia-auth0/auth-templates/tree/master/skeleton-esnext-fs/be)  itself is a simple aspnet core application where the only important action takes place in the ApiController class: https://github.com/aurelia-auth0/auth-templates/blob/master/skeleton-esnext-fs/be/Controllers/ApiController.cs#L14-L48
So, I do not need to explain the genesis of my plan, really:

I am starting with the well known Aurelia skeletons (https://github.com/aurelia/skeleton-navigation), slightly “shortened” (removing Child Routers demo as not relevant in this context)
The simplest case is the authentication of the SPA alone (while this is always a dubious action as one can easily hack a browser based application, it is the introduction into the full stack version that is considered next)

This sample set is further augmented by showing Typescript versions and then using various loaders (Webpack, RequireJS /  Aurelia CLI, etc)
Having this done, I expect these samples to find their home in the Aurelia official set of skeletons – indicating the special relationship between Auth0 and Aurelia.
At this point, we should start discussing the plan how to best fit this in the new home – Auth0 hosted Aurelia samples as the expectations there might be different.
Making sense?

@chenkie
Please check the three outstanding issues above and do your best to help resolving them. It will likely take a team effort from both Aurelia and Auth0 folks, so if you something that "belongs to Auth0 backyard" please see of some of your colleagues can help as well.


MINOR: [C++] Style enhancement for CompressedInputStream

Rationale for this change

This patch is a minor pr because it doesn't change any logic and it's just 3lines. It fix some style problem in cpp/src/arrow/io/compressed.cc
What changes are included in this PR?

Using std::move rather than new
remove duplicate return

Are these changes tested?
no and I think no need

Are there any user-facing changes?
no

@felipecrv Let me first checkin this, I'll draft another patch for decompress buffer reusing

LGTM, but just include this as a separate commit of another (bigger) PR because since there are code changes it can't really be considered a MINOR PR.

LGTM, but just include this as a separate commit of another (bigger) PR because since there are code changes it can't really be considered a MINOR PR.
Ok, let me do it


Counts Not Respected When Retrieving Tweets

When using client.get_user_tweets or user.get_tweets, the counts I set are not being respected. Regardless of what number is set, the number of tweets returned is unchanged.
In previous Issues I've seen that this is potentially an issue with the Twitter API. Is that still the case? Is there a way to return more tweets than the default amount?

@0xVeta
No, it is not possible to get more results than the default amount. Instead, use next method to fetch more results.


Use colours in terminal output of CLI

Using https://pypi.python.org/pypi/blessings or https://pypi.python.org/pypi/colorama

Fixed in 86ccdbd9668aaa87bfa30b0bfbc2dcff821cc6f8


Append module name to codestar notification rule to allow creating a unique name

This allows multiple notifications module instances to be attached to the same codepipeline instance.

Hi @kjagiello any chance you can review this one? Thanks!

Thanks for your contribution and sorry for a very late review!

No problem!

Looking good! There are some issues with the failing CI and outdated docs. Would you mind checking the "Allow edits by maintainers" box on your PR so that I can fix that for you?

Looking good! There are some issues with the failing CI and outdated docs. Would you mind checking the "Allow edits by maintainers" box on your PR so that I can fix that for you?

I opened this from an org repo so that doesn't work unfortunately. I will reopen from another fork and close this one.

Replaced by #25


Quicker way to change ticket status from list

Just checked the status of 48 tickets like this:

Select the ticket from the list
Click ticket header to edit ticket
change state
Click Update
Click on the project
Scroll down and find the next ticket in the list

To speed up the daily work.
I suggest we let the developer/manager change the ticket state directly in the list.

You can change the status of an issue from the Kanban view with drag and drop

Well actually you're right.
My programmer is using the kanban directly while working on the tickets. (He's the who wished for a quick ticket detail popup). I myself am using the kanban view to get a good view of what's going on and also while working on something myself. But today I simply had to change the status of 20 tickets from "Finished" to "Released". I could have done that in the kanban but since the list was very long I wish I could've done that also in the list.

It might be good idea to have search field at the top of each column in kanban view. Similar idea to what you ask for to filter the left side projects list?
having popup details of the issue in Kanban is also good idea to have. You can create this in a seperate issue.

mmmh.... I'd say one single searchfield for the complete kanban view would be best.

Again I just moved the status for 10 issues to RELEASE in quick order while talking to the programmer on the phone. I really wish we'd let the user change the status directly from within the list via dropdown or (which is better to prevent mistakes) with a button [ Set Status ] and a popup window where I can select a status or cancel.


How to set up shared secret for webhook?

Hi,
I filled in a value for 'shared secret' in the '/configure' page of my jenkins, and put the same value for the 'secret' in the webhook token, but I just get 403 when I test the webhook from github:

I tried things like:

shut jenkins down, remove the org.githubAuth.org.secret node from org.jenkinsci.plugins.ghprb.GhprbTrigger.xml , bounce jenkins
shut jenkins down, set the org.githubAuth.org.secret node to blank from org.jenkinsci.plugins.ghprb.GhprbTrigger.xml , bounce jenkins
shut jenkins down, set the org.githubAuth.org.secret node to the same secret I put in github from org.jenkinsci.plugins.ghprb.GhprbTrigger.xml , bounce jenkins
... but results were identical, when testing the webhook from github.

Thoughts?

Figured it out, thanks to http://stackoverflow.com/questions/7427557/jenkins-and-github-webhook-http-403/7431548#7431548  Cos I need to auth as a user too, and have a secret.

what is meant by auth as a user?
I'm currently unable to use my shared secret...


[Documentation]: Conda install Towhee via the towhee-io channel but v0.4

Is there an existing issue for this?

[X] I have searched the existing issues

What kind of documentation would you like added or changed?
https://docs.towhee.io/Getting Started/install/#installing-towhee-with-conda
When I install towhee via conda install -c towhee-io towhee, it will install towhee0.4.0. Does the latest version in the default channel?
Why is this needed?
No response
Anything else?
No response

@shiyu22
The channel is not right, please use channel "conda-forge".
conda install -c conda-forge towhee

@shiyu22 The channel is not right, please use channel "conda-forge".
conda install -c conda-forge towhee

It works in my Mac, but still towhee0.4 in Ubuntu.

When I use the command pip install towhee towhee.models, it occurs error in MacOS
In file included from src/blob.c:30:
  src/blob.h:33:10: fatal error: 'git2.h' file not found
  #include <git2.h>
           ^~~~~~~~
  1 error generated.
  error: command 'gcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for pygit2
Failed to build pygit2
ERROR: Could not build wheels for pygit2 which use PEP 517 and cannot be installed directly

BTW, when the python version is 3.6, conda install -c conda-forge towhee will take a long time to prepare the environment

When I use the command pip install towhee towhee.models, it occurs error in MacOS
In file included from src/blob.c:30:
  src/blob.h:33:10: fatal error: 'git2.h' file not found
  #include <git2.h>
           ^~~~~~~~
  1 error generated.
  error: command 'gcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for pygit2
Failed to build pygit2
ERROR: Could not build wheels for pygit2 which use PEP 517 and cannot be installed directly

@SuperSupeng
Thanks for the issue.
@Chiiizzzy
Could you please take a look here? Thanks.

When I use the command pip install towhee towhee.models, it occurs error in MacOS
In file included from src/blob.c:30:
  src/blob.h:33:10: fatal error: 'git2.h' file not found
  #include <git2.h>
           ^~~~~~~~
  1 error generated.
  error: command 'gcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for pygit2
Failed to build pygit2
ERROR: Could not build wheels for pygit2 which use PEP 517 and cannot be installed directly

Hi, @SuperSupeng, which version of python are you using? pygit2 supports 3.7 - 3.10 only, If you are using python 3.6, pygit2 will fail to install. If you are using python 3.7+, could you please try:
$ brew update
$ brew install libgit2
$ pip3 install pygit2

You can refer to https://www.pygit2.org/install.html#installing-on-os-x

I use python 3.6 version. Suggest to change the description in the documentation to python 3.7 and above.


ffado: port to qt5

Motivation for this change
https://github.com/NixOS/nixpkgs/issues/33248
Closes: https://github.com/NixOS/nixpkgs/issues/56712
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Now, at least, the file is produced:
$ file result/lib/python3.7/site-packages/dbus/mainloop/pyqt5.so
result/lib/python3.7/site-packages/dbus/mainloop/pyqt5.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, not stripped

but I cannot use it:
$ nix-shell -p python3 python3.pkgs.pyqt5 --run 'python3 -c "import dbus.mainloop.pyqt5"'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'dbus.mainloop.pyqt5'


Muscle Path Wrapping not implemented in visualizer

The main leftover issue with current visualization.  This issue is a placeholder to this known missing functionality.

Easily to see as implemented now. Closing

Wrapping appears to not be working anymore. This is in recent Windows build: OpenSim-43c1be65-2018-05-30

VS in 3.3:

@aseth1 the issue here was a placeholder for the fact that wrapping was not implemented at all. There's likely an issue specific to this model, can you point me to the model, and clarify if that worked in previous builds of 4.0 (broke by latest changes) or if it was never tried? Thanks


OutOfMemoryError on 300 KB image

From the repo, the image got_s was able to load successfully but larger images aren't able to load,
Please have a look

Due to inactivity closing the issue


Math

Hi. I defined a math folder in order to include all math theory - concepts in it.
I would also suggest folders (in /Theory) for:
/Algorithms
[Topological Sorting]
[DAGger Hashimoto]
[Create DAGger Hashimoto]
[Dijkstra] (this is something optional / personal: I would like to review  Dijkstra on Topological Sorting)
[ETHASH]
[RSA]
This is one is very basic but will support the idea of the dev / doc - website:
/Tries
[Merkle Patricia Trie]
[Patricia Trie]
[Radix Trie]
Let me know what do you want in or out so I can begin to write it, so I can move forward on to coding or "pratical examples".
Question: Do you have a specific/defined writing style or should I just follow what is written as a model (just to be sured).

According to our latest conversation, this would be the proposal for the repo additions (/Theory/):
/Algorithms
[DAGger Hashimoto]
[Create DAGger Hashimoto]
[Dijkstra] (this is something optional / personal: I would like to review Dijkstra on Topological Sorting)
[ETHASH]
[RSA]
/Tries
[Merkle Patricia Trie]
[Patricia Trie]
[Radix Trie]
Please let me know if this is Ok. Ty.

Hi,
Apologise if I was not clear, I think the algorithms section is nice to have though the table of topics, do not seem relevant to verkle tries. They do seem relevant to Ethereum as a whole though!
[DAGger Hashimoto]
[Create DAGger Hashimoto]
[Dijkstra] (this is something optional / personal: I would like to review Dijkstra on Topological Sorting)
[ETHASH]
[RSA]

Verkle trees do not use RSA and have nothing to do with Ethash for example.
The section on tries can be added, though we probably don't want to go into too much detail on the current MPT as verkle tries are a new construction with a lot of complexity already. Hmm but it may be nice to bridge the gap between the two.

No Problem, my mistake !
We will go with the /math section and with the section of /tries (not too much detail on it).
Correct ?

Yep that sounds good!

Thinking about it, this structure is strictly superior to what I had thought of before


Slate is completely broken

I don't even now where to begin with the problems I am experiencing with my FRESH install of slate, see image:

The Stylesheet for the theme is loading but it is completely blank. The icons are not loading even though HTTPS is enabled just fine. There is no functional javascript since the "preview" buttons at the bottom don't work. And half the translations were missing (although I figured out how to add those).
I need to develop, I got deadlines and I really can't work with this. I'm following the documentation exactly and this is what I get. I must be doing something wrong because there's no way that shopify developers would ship a development kit with this many problems.

You gotta put your big boy pants read the readme and figure it out pal you got this!

You gotta put your big boy pants read the readme and figure it out pal you got this!

Thank you for the valuable input, this is extremely helpful and exactly the kind of support I have come to expect from Shopify developers.

@masterShake that's exactly what Slate's supposed to look like. The entire point of Slate is to provide a blank slate for you to work from.


chore: cleanup Cargo.toml

there's a conflict in Cargo.toml, can you take a look about this?
the ci failure can be ignored imo, let's merge this pr first :)

thank you for the contribution!


Problem with Ubuntu installation

Hi,
I'm trying to use the gem in Ubuntu 16.04 and I'm not having luck. I always get the following message:
irb(main):002:0> Vips::Image
Unable to load Vips
  Check that the vips library has been installed and is
  on your library path.
  Check that the typelib `Vips-8.0.typelib` has been
  installed, and that it is on your GI_TYPELIB_PATH.
GLib::Error: Typelib file for namespace 'Vips' (any version) not found

I have tried installing from package (v8.2.2) and building from source (v8.4.2). In any of both cases I can't manage to find the Vips-8.0.typelib file.
root@90f3f863b951:/# find . -name "*.typelib"
./usr/lib/x86_64-linux-gnu/girepository-1.0/Gsf-1.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/GModule-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/Rsvg-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/cairo-1.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/fontconfig-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/PangoFT2-1.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/DBusGLib-1.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/PangoXft-1.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/GdkPixbuf-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/xrandr-1.3.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/libxml2-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/GLib-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/Pango-1.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/xlib-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/DBus-1.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/freetype2-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/Gio-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/xfixes-4.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/PangoCairo-1.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/GL-1.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/xft-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/GObject-2.0.typelib
./usr/lib/x86_64-linux-gnu/girepository-1.0/GIRepository-2.0.typelib
./usr/lib/girepository-1.0/Gtk-2.0.typelib
./usr/lib/girepository-1.0/GdkX11-2.0.typelib
./usr/lib/girepository-1.0/Atk-1.0.typelib
./usr/lib/girepository-1.0/Gdk-2.0.typelib
./usr/lib/girepository-1.0/SpiceClientGLib-2.0.typelib

Hi, Ubuntu 16.10 has the typelib in package called gir1.2-vips-8.0, I think I remember something like that on 16.04. If you start synaptic and type vips in the search bar, it should come up.
When building from source, you need  gobject-introspection installed for the typelib to be built. Check the summary at the end of the configure output, you should see something like:
gobject introspection: 			yes

@jcupitt Thanks for the help!
The gir1.2-vips-8.0 package works but I need to build it form source now. The ./configure output show  gobject introspection: no but I have it installed.
Anything im missing ?

Maybe you are missing the .pc file? Try:
$ pkg-config gobject-introspection-1.0 --modversion
1.50.0

libvips needs 1.30 or later.

Looks like that file is in libgirepository1.0-dev.
$ dpkg -S /usr/lib/x86_64-linux-gnu/pkgconfig/gobject-introspection-1.0.pc
libgirepository1.0-dev:amd64: /usr/lib/x86_64-linux-gnu/pkgconfig/gobject-introspection-1.0.pc

@jcupitt I am running into same issue pre-installing libvips with ruby-vips on TravisCI – so that I could run tests of a lib that's using ruby-vips:
https://github.com/tomasc/dragonfly_libvips
https://travis-ci.org/tomasc/dragonfly_libvips/builds (tried a lot of things to make this work …)
Would you have a suggestion please? Thank you.

@jcupitt, @bilby91 solved like this:
sudo apt-get update
sudo apt-get install -y gobject-introspection libgirepository1.0-dev
curl -O http://www.vips.ecs.soton.ac.uk/supported/8.4/vips-8.4.5.tar.gz
tar zvxf vips-8.4.5.tar.gz && cd vips-8.4.5 && ./configure && sudo make && sudo make install
export GI_TYPELIB_PATH=/usr/local/lib/girepository-1.0/
sudo ldconfig

@tomasc I ended up building a custom Dockerfile for running the app. Let me know if need it I can send it to you.

@bilby91 thank you, please do share the Dockerfile, thanks!

@tomasc
Here it is :).
ADD Gemfile* $APP_HOME/

# Install ruby dependencies
RUN bundle install

# COPY app to container
COPY . $APP_HOME

# Expose puma port
EXPOSE 3000

@bilby91 thanks – I ended up with similar solution – see my post above.
One slightly annoying thing is, that in order to use ruby-vips I have to make sure to have the GI_TYPELIB_PATH defined in all my apps. Is there any solution to this @jcupitt ?

You should only need to set the typelib path if you build your own libvips. If you use the bundled one, it should be fine without.
You could maybe just add ENV['GI_TYPELIB_PATH'] = ENV['VIPSHOME'] + '/lib/girepository-1.0' before require-ing vips. I've not tested it though.

Thanks.
What do you mean by bundled one @jcupitt ?

apt-get install one I believe

I see – using apt-get install gave me only 7.x version, so unfortunately I always have to build from scratch.

Yes, the system one. Sorry, sounds like your Linux is a little too old. There was an API break for 8.0, but there shouldn't be another for many years, so hopefully this problem will go away eventually.

Ok, no problem.
I am using pre-built ruby 2.2.5 Docker image as a base and I guess that comes with older Linux.
No problem rebuilding the libvips, the only bummer is having to remember setting the GI_TYPELIB_PATH.
Is there a way that ruby-vips or libvips could use some default – for example as you pointed above?


Write an RFC about Stratum V2 proxy to allow clients to do merged mining without depending on the pool

Relevant links:

Landing page: https://stratumprotocol.org/
Live specs: https://docs.google.com/document/d/1FadCWj-57dvhxsnFM_7X806qyvhR0u3i85607bGHxvg/edit
"Official" miner implementation with V2 support: https://github.com/braiins/braiins

The basic explanation on Stratum v2's website is pretty simple to understand, so I'll focus here on the parts that we would use.
[Please read Protocol Overview on the website before continuing]
At the center of it there's the Job Negotiation protocol. The idea is having this Job Negotiator (JN) role performed by a third-party node, not a miner directly. The JN communicates with the pool to negotiate a block template to be mined. This block template contains the transaction set included in the block and can also include some coinbase outputs (proposed_coinbase_outputs). For Hathor, that would be the place to add the merged mining info. It's important to notice that the pool will always add its own coinbase outputs, making final_coinbase_outputs = proposed_coinbase_outputs + pool_outputs. The mining rewards, therefore, go to the pool.
When JN and pool agree on a block template, the pool provides a mining_job_token that identifies this template. The JN then notifies the interested miners about the mining_job_token, which miners use to request a job directly from the pool.

In Hathor's case, there's the need for an additional proxy between miners and pool, for 3 reasons:

if a mining share is solved for Hathor's target difficulty, we should propagate the block on Hathor's network;
most miners won't have v2 support immediately, so our proxy can provide v2 -> v1 translation;
miner has to provide both it's pool miner id (for the btc pool) and an HTR address, in case it finds a block. This is similar to what is being implemented in this MR.

Unfortunately, v2 is still not completely developed, even though Slush pool already has a v2.stratum.slushpool.com endpoint. Actually, the spec is still a draft and can suffer modifications.
There's no page from Slush pool with more information about development or ETA. I sent a message on a Braiins (the company behind Slush pool and stratum v2) Telegram group and got a response from its CEO that only standard channel has been implemented, so no support for extended channels yet. There's also no ETA for completion.

Good description. It is a shame that extended channels are not available yet.

There's nothing we can do right now. We should monitor v2 development and possibly implement this later. Will move this to our backlog.


Support multi-use parameters in leaf modules (whether tracing or sequential frontend)

Currently, only for the tracing frontend, we detect parameters that are used in more than one module and emit different code depending on the policy that the user specified (TRANSMIT or REPLICATE):
https://github.com/jamesr66a/PiPPy/blob/527af1fd8123d35bd81b9fe304a8d0ed29c9fd8d/pippy/IR.py#L465
We should generalize this to work on:

Leaf modules in fx tracing
Modules that share parameters in the sequential frontend

Concretely, these things are already supported by default with the REPLICATE mode. To support the TRANSMIT mode, we could emit code at the end of the first stage that uses the parameter that fetches the parameter value and transmits it to the subsequent use stages.

Not clear if anyone is using TRANSMIT; Investigate if that is useful. If so, up priority.


List<...> not queryable

I've been trying to work on some bug repros, but I've having trouble getting a minimal example with EntityGraphQL up and running.
I figured I'd set up a context that has List<User> inside it, instead of using DbSet<User>, but whenever I query the user, I get no fields back.
Here's the full code:
public class User
{
    public string Name { get; set; }
}

public class UsersContext
{
    public List<User> Users { get; set; }
}

public class Program
{
    public static void Main(string[] args)
    {
        var builder = WebApplication.CreateBuilder(args);

        builder.Services.AddControllers();

        builder.Services.AddGraphQLSchema<UsersContext>();

        var app = builder.Build();
        app.UseHttpsRedirection();
        app.UseCors(builder =>
        {
            builder
            .WithOrigins("*")
            .WithMethods("GET")
            .AllowAnyHeader();
        });
        app.UseAuthorization();
        app.MapControllers();
        app.Run();
    }
}

[ApiController]
[Route("[controller]")]
public class GraphQLController : Controller
{
    private readonly SchemaProvider<UsersContext> _schemaProvider;
    public GraphQLController(SchemaProvider<UsersContext> schemaProvider)
    {
        _schemaProvider = schemaProvider ?? throw new ArgumentNullException(nameof(schemaProvider));
    }

    [HttpPost]
    public async Task<object> Post([FromBody] QueryRequest query)
    {
        var usersContext = new UsersContext
        {
            Users = new List<User>
            {
                new User
                {
                    Name = "test user"
                }
            }
        };

        return await _schemaProvider.ExecuteRequestAsync(query, usersContext, HttpContext.RequestServices, HttpContext.User);
    }
}

And my query:
{ users { name } }

I get back an array with one element (as expected), but it doesn't have a name field, which is unexpected:
{"data":{"users":[{}]}}

The strange thing is that if I trace through the code, SchemaProvider::ExecuteRequestAsync() is returning what I'd expect:

(Note the red dash sign next to the "name" property. Not sure what VS is trying to tell us, there. Maybe that it's a private member?)
I'm using the latest version of HEAD, but I'm also encountering this issue on 4.0.
Any ideas? 🙂  Is directly having List<...> in the GraphQL context not supported, or am I missing something obvious?
Thanks! 🙂

By default the JSON serialiser does not serialise fields.
https://entitygraphql.github.io/docs/getting-started#configuring-systemtextjson
Same for JSON.NET if you are using that.

Thanks, that fixed it!


feat: add Builder::out_dir to set output directory

Rationale
Allow overriding the output directory, as does tonic_build, lets us target different locations for building
Add an API mirroring tonic_build  to explicitly override the output directory
See reference https://docs.rs/tonic-build/0.5.2/tonic_build/struct.Builder.html#method.out_dir
Changes:
copy/paste implementation from tonic-build:https://docs.rs/tonic-build/0.5.2/src/tonic_build/prost.rs.html#261-267

cc @tustvold


netlink: fix race condition when adding links

when running with '-race' against k8s code which is under graph.Lock() I discovered a RACE condition of READ by topology.AddOwnershipLink(..)  (topology/probes/netlink/netlink.go:242)
        if !topology.HaveOwnershipLink(u.Graph, u.Root, intf) {
                topology.AddOwnershipLink(u.Graph, u.Root, intf, nil)
        }

No this is a PR which exposes the issue ... i will update this is
reproduced on a current PR branch
On Wed, Jul 11, 2018, 13:48 Sylvain Afchain<EMAIL_ADDRESS>wrote:

@safchain commented on this pull request.
In topology/probes/netlink/netlink.go
https://github.com/skydive-project/skydive/pull/1170#discussion_r201645626
:

@@ -460,6 +460,9 @@ func (u *NetNsNetLinkProbe) addLinkToTopology(link netlink.Link) {
metadata["BondMode"] = link.(*netlink.Bond).Mode.String()
}

u.Graph.Lock()

reading the traceback you doesn't seems to be on master
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/skydive-project/skydive/pull/1170#discussion_r201645626,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACogI-LiWNzud3HUR80xr3bgBimi55rDks5uFdgAgaJpZM4VKlu7
.

adding real k8s functional test will detect/reproduce this kind of race easily

Does not reproduce - closing


Typo "Azure function"→"Azure Function"

https://docs.microsoft.com/en-us/sharepoint/dev/spfx/use-aadhttpclient-enterpriseapi
Category

[x] Content fix
[ ] New article
[ ] Example checked item (delete this line)

DELETE THIS LINE BEFORE SUBMITTING | For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.

Related issues

fixes #issuenumber
partially #issuenumber
mentioned in #issuenumber

DELETE THIS LINE BEFORE SUBMITTING | If this fixes (aka: closes) or references an issue, please reference it here. This helps maintaining the issue list as it will (1) link the PR to the issue & (2) automatically close the issue when this PR is merged in.

What's in this Pull Request?

DELETE THIS LINE BEFORE SUBMITTING | Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

Submission guidelines

!!IMPORTANT!! - All submissions must complete the baseline sections included in this template. Ignoring or deleting this template may result in closing the issue with the label type:incomplete-submission.
Follow our guidance on How To Create Good Pull Requests.
Target the master branch of this repo. Released documents are in live branch.

DELETE THIS SECTION BEFORE SUBMITTING

Docs Build status updates of commit e18f2b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/use-aadhttpclient-enterpriseapi.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 28c1f5f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/use-aadhttpclient-enterpriseapi.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Cant share word from RichEditorView

Hello.
When I try to use "share" button from context menu(long tap on the any word) and choose Twitter or Messages and tap on Cancel button on Share Controller - I cant can no longer interact with application.
I tried to disable share button by creating UIWebView child with canPerformAction method that returns false but it doesn't work too.
How can I disable button or fix this behaviour?

Oh wow, nice catch. This is a problem.
I haven't found a way to prevent it yet, but I have confirmed that it happens in a sample app with nothing but a web view with a content editable div. Normal divs seem to be OK.
This is something happening to more than just RichEditorView... I hope we can find a workaround.

I've submit a bug to Apple, as well as listed it on Open Radar
This bug doesn't seem to happen in Safari, so there is probably some kind of way around it :/

Closing this, because it seems to be a problem with the system, and I haven't been able to find a workaround :cry:


clients does not work well on linux

Mqttx often doesn't work under linux, especially when sending messages regularly and opening multiple clients.

Hi! Could you please provide details of the reproduction procedure and the specific environment in which it will be used?

The environment is ubuntu22.04 lts with 9700k cpu. No matter whether the package in deb format or the package in snap format is used, there are cases where there is no response when you open it and cases where you can't click the interface when you send it regularly, but the data is still being sent. Deb-formatted packages are stuck in a more ordinary way.

2022年6月29日 22:02，YuShifan @.***> 写道：
Hi! Could you please provide details of the reproduction procedure and the specific environment in which it will be used?
—
Reply to this email directly, view it on GitHub https://github.com/emqx/MQTTX/issues/974#issuecomment-1170021595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHTJINVD3Q5RE66V2JUAFZLVRRJQTANCNFSM52EUWVKQ.
You are receiving this because you authored the thread.

Thanks for the feedback, you can download AppImage directly to use or use MQTT X CLI, feel free to try again with https://github.com/emqx/MQTTX/releases/tag/v1.8.3


chore: remove libp2p-crypto-secp256k1

DEPRECATED: libp2p-crypto-secp256k1
https://github.com/libp2p/js-libp2p-crypto-secp256k1

@bluelovers Sorry it took me so long to review this. I just applied the patch and it looks like I'm getting some test failures locally. Can you run make rebuild and let me know if you're seeing the same?


Create a Workflow Definition Using an External Service

Tutorial URL: https://developers.sap.com/tutorials/cp-wf-01-create-definition.html
Please specify the step you are referring to
I get an error on Step 8
Error message:
The destination 'Northwind' could not be found. Create it or check the spelling.
GET unknown /V3/Northwind/Northwind.svc/Products(1)?$format=json
Step 7
is where this URL is provided. I made sure the spellings are correct no spaces
URL
/V3/Northwind/Northwind.svc/Products(${context.ProductID})?$format=json

Destination was missing. Followed this tutorial and it fixed the problem.
https://developers.sap.com/tutorials/hcp-create-destination.html

@qmacro FYI

That's the right course of action @AbhijitNilegaonkar.
@thecodester the hcp-create-destination tutorial is already listed as a pre-requisite for this one.


Fix issue https://github.com/google/gopacket/issues/668#issue-459392815

Please check this fix for issue https://github.com/google/gopacket/issues/668#issue-459392815 (OSPF Layer not parsing OSPFv2 Type 2 LSAs properly).

I just signed the CLA

OK, let me do this with the proper account so I can get past the CLA check... closing for now.


Error in month count when continuous use nextMonth or prevMonth

When I use prevMonth and prevMonth, the month count calculate mistake.
See the log pic:

I want to implement switching time periods. If nextMonth is wrong, I'll have to do it some other way.

Since 4.1.7 nextMonth and prevMonth properties are deprecated and replaced by:
(for DateInRegion):
- public func prevMonth(at time: TimeReference = .auto) -> DateInRegion
- public func nextMonth(at time: TimeReference = .auto) -> DateInRegion

and (for plain Date):
- public func prevMonth(at time: TimeReference = .auto) -> Date
- public func nextMonth(at time: TimeReference = .auto) -> Date

TimeReference allows you to specify the way in which the date is calculated:

.auto: evaluated date is calculated by adding one time component (month/week) to the current date.
.start: result date is the first day of the next time component (month/week) (at 00:00:00).
.end: result date is the last day of the next time component (month/week) (at 23:59:59).

So, coming back to your issue you can get the first day of each month by using:
let gmt = Region(tz: TimeZoneName.gmt, cal: CalendarName.gregorian, loc: LocaleName.english)
llet startDate = DateInRegion(string: "2017-07-16 16:00:00 +0000", format: .iso8601Auto, fromRegion: gmt)!
var nextDate = startDate.prevMonth(at: .start) // move at the start of previous month
for _ in 0..<10 {
  nextDate = nextDate.nextMonth(at: .start) // get the first day of the next month (use .end to get the last day)
  print(nextDate.string(format: .iso8601Auto))
}

I've also added prevWeek() and nextWeek() both to Date and DateInRegion.
Thank you for your report.
These fixes will be included in 4.1.7.

Reference commits:

https://github.com/malcommac/SwiftDate/commit/c500dfa97e2497a0f24cf9ae579deb93dabcfb38 for nextMonth() and prevMonth()
https://github.com/malcommac/SwiftDate/commit/4ccc2960caaf86cae96b84c4e9857edd1f017c9c for nextWeek() and prevWeek()

and finally https://github.com/malcommac/SwiftDate/commit/d6bbfd022c867250176f1b1cf3437741be9bb5cb for unit tests.


Improve perf

Few small fixes for perf:

avoid calling logging in the hot path when not needed
avoid resolving paths multiple times
Reduces runtime by ~50%.

Is missing the set option.


No GUI build

Describe the feature and if there are any other alternatives (if applicable)
It would be nice to have also a no GUI build if you want to use the slicing feature only
Does this feature resolve a problem?
You would be able to slice files also if your embedded system has no display at all
Additional context (screenshots, diagrams, links to external documentation etc)
https://github.com/prusa3d/PrusaSlicer/issues/7521 should explain how it can be done. I tried to compile it on my Raspberry Pi 3 with 32-bit Bullseye installed, but the compilation process always got stuck.

Hi there,
PrusaSlicer (and this 3rd party AppImage) ships with the ability to use no GUI, but it is not primarily supported upstream as the linked issue shows. While I've used this functionality in the past for experiments, I think it would be best to stay as close to upstream offerings as possible, continuing to offer both the combined GUI+CLI in one.
If it helps, this shows the current AppImage with the CLI being used for slicing, along with the gcodeviewer showing the result:

Thanks for the clarification, I didn't expect that it's a combined image executing either CLI or GUI depending on the parameters called with.


JupyterLab git push interface throws error

Hello,
since a while, every time I try to use the JupyterLab interface to push changes to the remote repository, I get the following error

From the command line, git push does work without errors.
Also @MarvinMosel is experiencing the same problem.

we just checked - we have a quite recent version of https://github.com/jupyterlab/jupyterlab-git installed
13:19 $ jupyter labextension list
        @jupyterlab/git v0.43.0 enabled OK (python, jupyterlab-git)

also also later versions (like 0.44 resp. 0.50) won't change anything in behavior
The main "problem" is not the generic git extension but the fact that github as specific git provider disabled https and just allows push via ssh (note: the extension only allows git clone via https so the subsequent push is also using https!)
so to work with git against github repos you need to

create ssh key (without passphrase) and upload to github as well as your JupyterLab workspace
do a git clone via command line
now you can use the extension to browse through branches and commit/push

this workflow has been verified by @mallingerb above

With the ssh key it now works, thanks for looking into this.


fix: text colour on github button hover

Description of PR
Currently, the text on the GitHub button in the footer is difficult to read on hover. This PR fixes that.
Type of PR

[x] Bugfix
[ ] New feature

Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots
Before

After

Seems like this has now been fixed. Closing PR.


Use json file to import and export sections

To help reusing models, it would be nice have implemented import and export sections.
One way to do it is by using a JSON file, that defines points, curves, materials and the sections

[x] Create file dataio.py that contains functions to handle input and output, import and export
[ ] Import

[x] Create a function to read a .json file
[x] Use jsonschema example to validate the input
[ ] Class method from_dict to transform dictionary into sections instances
[ ] Class method from_json to create a instance from a json file

[ ] Export

[ ] Create a function in dataio.py to save
[ ] Create instance method to_dict to transform the object into a dictionary
[ ] Create instance method to_json to save a json file

Example
{
    "nodes": [
        [1, 1, 1],
        [2, -1, 1],
        [3, -1, -1],
        [4, -1, -1]
    ],
    "curves": [
        {"label": 1000,
        "degree": 1,
        "knotvector": [0, 0, 0.25, 0.5, 0.75, 1, 1],
        "ctrlpoints": [1, 2, 3, 4, 1]}
    ],
    "shapes": {
        "square": [1000]
    },
    "materials": {
        "steel": {
            "young_modulus": 210e+3,
            "poissons_ratio": 0.3
        }
    },
    "sections": {
        "square": {
            "shapes": ["square"],
            "materials": ["steel"]
        }
    }
}

[ ] Create file dataio.py that contains functions to handle input and output, import and export
[ ] Create a function to read a .json file
[ ] Use jsonschema example to validate the input
[ ] Add internal verifications to handle cases which jsonschema can't handle, like verifying if knotvector is ordered

The import and export functions/methods should be implemented in the used objects.
It's not possible to circular import: If the file section.py imports dataio.py, it's possible to call from_json or to_json. But to dataio.py's functions create instances of objects, it should import other files (like section.py), meaning circular import.
It's easier and cleaner to, in each class, implement method from_json and to_json, which in fact load/saves an instance from/to a dictionary.


dont take up full width for big team row

@keybase/react-hackers
Not sure if this is a legit way to do this, but it fixes the problem of the orange dot not being shown on mobile.

i've ticketed in desktop

I have a ticket already: https://keybase.atlassian.net/browse/DESKTOP-4838


Add building cs.sln and running unit tests in Travis.CI

This is updated version of previous pull request. Maybe cabal sandbox should be cached too (like it's done on AppVeyor) to improve build time (I'm not familiar with Haskell and do not know how to do it properly).
Here are two workers:
OS X worker: build cpp solution, run cpp unit tests, build cs solution.
Linux (Ubuntu 12.04) worker:  build cpp solution, build cs solution, run cs unit tests.


Does not work with Ruby 2.6.6, bundler 2.1.4

Not sure which update caused problems, but with this combination it outputs:
bundle diff
ERROR: gem name required

This seems to be happened because of the gem you'd installed was https://github.com/readysteady/bundle-diff, not this gem. I've faced the same but just uninstalling readysteady/bundle-diff fixed the problem.

Indeed. Thank you.


ADD INTEGRATION HAM Radio Propagation

Hello everyone,
I installed HAM Radio Propagation via HACS.

I now wanted to add the integration

Unfortunately, the integration is not offered to me for selection.
When I open the Botten from the side, the following message appears in the Home Assistant

Übersetzter Text :-)
Mistake
This integration does not support UI configuration. If you followed this link from the Home Assistant website, make sure you're running the latest version of Home Assistant.
If I understand your instructions correctly, I'm not making a mistake.
Maybe you can help me?
Thanks says Dirk DL4DP

Hi Dirk ,
did you have restart Home Assistant after HACS installation?
What Home Assistant version did you have?

hi emicd, since the new update it works.THX 73 de Dirk DL4DPAm 04.05.23, 11:40 schrieb Emiliano @.***>:
Hi Dirk , did you have restart Home Assistant after HACS installation? What Home Assistant version did you have?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Hi Dirk. Thanks for reply.
enjoy


How-to for Adorner in ScrollViewer - adorned elements of dynamic/changing position

A how-to on how Adorners can/should be used within a ScrollViewer would be quite helpful, introducing and documenting both the handling of AdornerLayer in the context of scrolling/changing adorned elements and handling of positioning on changing content/content position, or more generally changing reference position/size or the adorned element.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 75447836-d6d7-9edc-ad13-2e58f3d058a6
Version Independent ID: 58b6e291-bcf2-5b11-4f18-5dc9205ed7dc
Content: Adorners How-to Topics
Content Source: docs/framework/wpf/controls/adorners-how-to-topics.md
Product: dotnet-framework
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

//cc @OliaG @SamBent a new topic request.
Thanks for the suggestion, @ite-klass. We've added it to our backlog.


Class refactor #1

Created MlbDataAdapter which is an interface to call ends points and receive JSON
Created Mlb class which is the base class of the wrapper. Currently, it contains class functions to get Person, Persons, personId, Team, Teams, and teamId.
Tests added are not using mocking and talking to the external endpoint.

@knilssen Let's keep this open for the time being. I want to get things working with stats before merging to development. Then let's try and adapter Game? Let's start with just a class for holding game information and then work our way up. Let's start in steps instead of swinging for a homerun.


chore (Set.Pointwise.Basic): avoid importing ordered rings

We shouldn't need to import ordered algebraic classes for basic properties of pointwise multiplication of sets.

bors merge


improved generated docstrings

This (hopefully) resolves #233
This is my first time looking through the prost source, so it's entirely possible I didn't understand something, review with the assumption that I'm missing the obvious.

@dunmatt the test issue is that you need to check in the changes to prost-types; whenever code-gen changes this happens.  They are somewhat akin to snapshot tests, however they are actually load bearing code.

Which should be as simple as running the test suite, which modifies the files

I get:
   Compiling criterion v0.2.11
error: failed to run custom build command for `protobuf v0.0.0 (/home/mrd/code/prost/protobuf)`

Caused by:
  process didn't exit successfully: `/home/mrd/code/prost/target/debug/build/protobuf-c5fd84c2727b695e/build-script-build` (exit code: 101)
--- stderr
+ mkdir -p third_party/googletest/m4
+ autoreconf -f -i -Wall,no-obsolete
configure.ac:104: error: possibly undefined macro: AC_PROG_LIBTOOL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1
thread 'main' panicked at 'protobuf autogen.sh failed', protobuf/build.rs:150:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

when I try to run the tests.  Any idea what I should do?

That's a failure to build protobuf, which is required by the tests suites.  For a bit more context this is the test that matters: https://github.com/danburkert/prost/blob/master/tests/src/bootstrap.rs.  I'm not really going to be able to help debug why protobuf isn't building correctly via GH issues, but it's probably something along the lines of a missing build tools or the wrong versions.

I see.  So here's the thing, chasing down C++ build issues is obnoxious enough that I've almost completely abandoned the language.  If I send you a .patch file that does what this PR is supposed to do can you apply it and use the tests to generate the remainder of the PR?

Yeah I can take over just based on this PR, no need to send a patch.  Thanks for the PR!

Thanks for your help with it!

@dunmatt I've opened up #250 to land just the getter/setter method doc changes.  The docs for generated modules as implemented in this PR are just copying the outer struct documentation, which I don't think is appropriate.  I think it'd be better to have a docstring for generated modules be along the lines of

Nested message and enum types in Foo.

where Foo is the outer message type.

So the bulk of this landed a year ago, I'm going to close this out since I suspect there's nothing more to do here.  If I'm wrong please feel free to re-open or send a new PR.  Thanks!

No, thank you
On Sun, Nov 15, 2020, 13:00 Dan Burkert<EMAIL_ADDRESS>wrote:

So the bulk of this landed a year ago, I'm going to close this out since I
suspect there's nothing more to do here. If I'm wrong please feel free to
re-open or send a new PR. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/danburkert/prost/pull/234#issuecomment-727627398, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIN7SYNFWJFLPQLQ77TU33SQAXPHANCNFSM4JCK42VQ
.


[improve][pulsar-client-tools][ISSUE-16082] - Updated set retention time description and added test cases including default time

Fixes #16082
Motivation

The help option for set retention indicates -t option is Retention time in minutes but if no time unit is specified, it is assumed to be seconds.

Modifications

Updated description for time option and added unit test cases with default value (without time unit suffix) and with seconds time unit.

Verifying this change

[x] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Added unit tests for to PulsarAdminToolTest with and without time unit suffix.

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): no
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: no

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
This is a change in argument description.

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@Anonymitaet  -
Can you please review this PR regarding issue (https://github.com/apache/pulsar/issues/16082)  ?  It clarifies that the default time unit (without time unit) is seconds. I have added supporting unit test cases with and without time unit.
From my understanding the failing unit tests (TEST-org.apache.pulsar.broker.service.RackAwareTest.xml) is not related this PR or it's tests.
Please let me know if there is anything else required.
Thanks for your time.

@horizonzy
could you please review this PR from the technical perspective? Thank you!

@Anonymitaet, @horizonzy - Please let me know if you have any feedback on this PR.  Thanks

@Anonymitaet, @horizonzy - Please let me know if you have any feedback on this PR. Thanks

Fine.

Hi @horizonzy  -
Thanks for your feedback.
I've updated description for size parameter and added test cases as you had recommended.
Please let me know if you have any additional advice.
Thanks again for your time.

/pulsarbot run-failure-checks

@horizonzy  - Thanks for your thorough feedback.  I've updated the code based on your recommendations.

/pulsarbot run-failure-checks

@Anonymitaet ping

@Anonymitaet -
I have updated the description based on your recommendations.  Please let me know if there is anything else required.
Thanks again for your advice/time.

Thanks for your contribution! LGTM from the technical writing perspective 😊

@Anonymitaet  - It looks like PR is pending your review feedback (1 pending reviewer above).  Please let me know if there is anything I can address.  Thanks again for all your advice.

@Anonymitaet @horizonzy  - Please let me know if there is anything required for this PR to be merged to master. Thanks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@Anonymitaet @horizonzy  - The failing tests (Pulsar CI/CI - Unit Broker - Flaky, Pulsar CI/ CI - System Pulsar Connectors,  CI - CPP, Python Tests / System-PULSAR_CONNECTORS_THREAD, CI - CPP, Python Tests / Unit-BROKER_FLAKY Tests) are not related this PR and are still failing despite invoking pulsarbot run-failure-checks.
Please let me know if there is anything required from my side to merge this to master.
Thanks again for your time and advice.

@mans2singh your PR can not be merged since some required tests failed. Can you get all required tests passed?

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

Hi @Anonymitaet -
All checks are passing now.
Please let me know if there is anything else required.
Thanks again for your guidance.

Thanks @Anonymitaet @horizonzy for your help.


Update browser_extensions.md

Added a new Chrome Extension

Hi, thanks for the PR. However, we have stopped adding derivate works to the webpage as we couldn't do justice to all the requests. We've removed all entries from the api main-page. Hope you'll understand.


Dialogue canvas rotation is all wrong

Actually not sure what triggered the bug...

I think it's good?

No it's not! Dialogue canvas position and rotation seems to drift with time

Closed by #174


How to implement event receivers could be clarified and possible DEPR

The how-to for receiving events documents two options (see https://github.com/openedx/openedx-events/blame/main/docs/how-tos/using-events.rst#L10-L53).

Connecting signals using regular django syntax, and
Connecting signals using apps.py plugin configuration.

Please help me check my understanding. Is the following accurate?
I believe that the second option, using apps.py plugin configuration, pre-dates the use of openedx-events. In the earliest version of plugins, they needed to reach into a signal definition that was defined in edx-platform (as an example), and was not exposed to the plugin. Now that openedx-events signals exist, the signal can instead be imported from openedx-events, and regular django syntax can be used. In fact, the earlier mechanism of using apps.py should probably be deprecated, in favor of transitioning any necessary signals to an openedx-event.
Inside edx-platform, there are many uses of apps.py to listen to signals. See https://github.com/search?q=repo%3Aopenedx%2Fedx-platform+plugin_app&type=code. I find this very confusing, because it is using "plugin" syntax for non-plugin apps that live inside the repo. Is there any good reason to do this, or is this just a lot of copy/paste of something that doesn't make as much sense?
One proposal is to deprecate the apps.py plugin way of listening to signals. If the signal is an OpenedxSignal, then the warning could simply ask to refactor to use simple django syntax. Otherwise, the deprecation warning could note that the simple django syntax should be accessible for any signal inside the same repo, or if this is truly for a plugin, then a new signal should be added to openedx-events to expose the event.
Thoughts?

@robrap I have not written a plugin with openedx-events, but I agree that if we have two equally-powerful ways of implementing receivers, one which uses idiomatic Python/Django and the other of which has a bespoke stringly-typed config syntax, then we should keep the former and depr the latter.

Inside edx-platform, there are many uses of apps.py to listen to signals. See https://github.com/search?q=repo%3Aopenedx%2Fedx-platform+plugin_app&type=code. I find this very confusing, because it is using "plugin" syntax for non-plugin apps that live inside the repo. Is there any good reason to do this, or is this just a lot of copy/paste of something that doesn't make as much sense?

Yes, I find that confusing too. This all predate ADRs, but I believe that the reasoning at the time was something like:

If we turn built-in edx-platform djangoapps into plugins, then it'll make them easier to extract.
If edx-platform repo developers dogfooded the django plugin system, they would learn it and contribute to it.
Built-in XBlocks are still XBlocks, so built-in Django apps should still be plugins.

I could write more about why I disagree with each of those, but to be brief, I think that building internal apps as django plugins has just led to a stranger, more-indirect codebase with a higher barrier to entry for new maintainers.

If we turn built-in edx-platform djangoapps into plugins, then it'll make them easier to extract.

That (and the rest of your comment) is great context. I turned this into a new edx-platform issue: https://github.com/openedx/edx-platform/issues/35898.
We'll need to decide if a DEPR makes sense, and if so, I guess that would belong in edx-django-utils with the plugin code. Does that also make sense to ticket now or at some point?
That said, improving the documentation in this repo may be a less expensive step in the right direction if we all agree. I think we simply want to drop the string-based plugin pattern from these docs altogether, right?

There still would be references in edx-django-utils for legacy usage. I don't know if those docs need to be improved as well, but maybe that could all be related to this issue.

I believe that the second option, using apps.py plugin configuration, pre-dates the use of openedx-events. In the earliest version of plugins, they needed to reach into a signal definition that was defined in edx-platform (as an example), and was not exposed to the plugin. Now that openedx-events signals exist, the signal can instead be imported from openedx-events, and regular django syntax can be used. In fact, the earlier mechanism of using apps.py should probably be deprecated, in favor of transitioning any necessary signals to an openedx-event.

I don't have a very good reason to explain why we went with the suggested way of listening to signals in plugins back then for the docs - this is the method I remember when I started experimenting with Django plugins. Even though the advantages of having a separate library to implement signals, we didn't question whether this should still be the recommended way after the library's implementation and consequent adoption. So, thank you for bringing this up!
Although I have a few concerns about deprecating this approach, it's mainly related to that openedx-events are not a drop-in replacement of signals in edx-platform. So, before deprecating it, we should offer a migration path for users of those signals.
As for the docs, a few months back I created this list of docs improvements to gradually implement this year. I added this one to it, so I plan to work on it in December or January at the latest.

Here is a proposed doc change for this repo: https://github.com/openedx/openedx-events/pull/422
I found https://github.com/openedx/edx-platform/blob/73ba58ae11a9b1a896cdeeb515d1818c207f6b21/docs/hooks/events.rst, which is a slightly redundant doc. Do we want DRY docs in this case, or not?

Although I have a few concerns about deprecating this approach, which is mainly related to the fact that opened-events are not a drop-in replacement to Django signals in the edx-platform - so we still have a few of them to support. So, before deprecating it, we should offer a migration path for users of those signals.

@mariajgrimaldi: I believe this can be deprecated sooner-rather-than-later to avoid the contagion factor. That doesn't mean the feature will be removed until it is no longer needed. I think the "replacement" path for any legacy signal that is already in use in this way would be to introduce an openedx-event, which is a process that would take time, and could be tracked separately. Does this address your concern, or do you have other concerns? Thank you.

Thank you! As I mentioned, I'll also use the recommended method when updating the docs.
Yes! This PR with a centralized approach was recently merged, so I'll now drop outdated (duplicated) docs.
You're absolutely right. However, developers also consume signals from the edx-platform. I believe the replacement path should be enough to address this. Thank you.

@mariajgrimaldi: Regarding the first point, its unclear whether you plan on reviewing my proposal? If we like it, we can land this change now, and not have to wait for your larger doc effort.

See https://github.com/openedx/openedx-events/pull/422
Or @kdmccormick, if you end up reviewing it.

@robrap: I'm sorry for not being clear. The PR is ready to merge. Thank you.

Proposed action items left for this ticket:

[ ] Clean up https://github.com/openedx/edx-platform/blob/73ba58ae11a9b1a896cdeeb515d1818c207f6b21/docs/hooks/events.rst, or confirm that this is tasked with the upcoming docs work. @mariajgrimaldi: Can you confirm this is tasked?
[ ] Create a DEPR ticket in edx-django-utils. Although it may not be announced soon, it is a better place to capture some of these details and allow this ticket to be closed. I’ll take care of this.

@robrap: confirmed! I'll take care of it on Monday. Thank you!

Clean up PR merged: https://github.com/openedx/edx-platform/pull/35921


FEATURE(DN-1374): Allow underscores in linkedin links

I also added tests, but I don't know how to run them, sorry! -- nevermind, they're showing up (~and failing~ fixed)

Thanks, Vittorio!


Autotile doesn't support uncommon bitmasks

Godot version:
Godot 3
Issue description:
Uncommon bitmasks do not work.

I wanted to only get a stair when there was a filled cell in the bottom-right, and a edge when there was not.

CC @MarianoGnu

Fixed by #18619.


"Pitoi", "Valea Mare" are listed in the drop-down menu

Description:
When user writes "Pitoi" and "Valea Mare" the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Pitoi"

Expected results
The location appears in the drop-down menu as "Pitoi, Argeș (Priboieni)"

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Valea Mare"

Expected results
The location appears in the drop-down menu as "Valea Mare, Argeș (Priboieni)"


FAQ: Remove reference to --enable-bar that does not exist

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

--enable-bar is a placeholder for a formula option. Instead of removing the line, it should be updated to say --with-bar to match the recommended option format.

Thank you for the quick reply. I see, here are my misunderstanding:

"Bar" is a special term/function in Homebrew system like tap, bottle, and so on. And --enable-bar enables it.
Homebrew stopped supporting formula options long time ago.

Assuming that other users can get confused in a similar way, I would suggest several changes:

Change "bar" to "foo" because it is much less confusing as a placeholder in the Homebrew context.
Explicitly say "formula options" not just "options".
Change "i.e." to "for example" so that users can see it is just an example of giving a formula option.
Move this item to the bottom of the list. Formula options are not so common now even though they are still supported technically.

Assuming that other users can get confused in a similar way, I would suggest several changes:

Change "bar" to "foo" because it is much less confusing as a placeholder in the Homebrew context.

Explicitly say "formula options" not just "options".

Change "i.e." to "for example" so that users can see it is just an example of giving a formula option.

Move this item to the bottom of the list. Formula options are not so common now even though they are still supported technically.

Strongly agree with all this. 👍


AsyncWrapper  + BufferingWrapper with throttled mode

Right now the AsyncWrapper and BufferingWrapper will attack the wrapped target as hard as possible. Without waiting for the previous batch to complete before starting the next.
This works fine for sync-targets where write-operation is instant. For async-targets then it can be useful not to pile up, but instead throttle while waiting for the previous batch to complete. See also #2537
Having a throttled mode on the wrapper requires ones to use the AsyncContinuation to hook into a LogEvent to monitor its state. This gives an unwanted delegation-capture-allocation overhead. But if just adding a hook into a single item of a batch, then this allocation should be minimal.

Closing this since the improvements to AsyncTaskTarget in Nlog 4.6 covers most of the things asked for.


data-* custom attributes throws a TypeError

This issue I think that is a bug.
If you fill a select tag name with a customized data-* attribute, console throws this error:

TypeError: b.dataAdapter is null

or

TypeError: this.dataAdapter is null

Depending on the scope.
The code example is like this:
<select multiple data-placeholder="Search here" data-activate-after="some-value"></select>

Please, note that "data-placeholder" doesn't works.
"data-activate-after" makes the crash that I describe in top of this issue.

I have two different code branches, where I have the same issue on the first one and unable to reproduce it on the second ;)

Select2 should be ignoring extra data attributes, and without an actual traceback (from the unminified version) there isn't much to work from here.

A jsbin/jsfiddle which reproduces this issue would also make things easier (so we don't have to hunt for the bug). Alternatively, answers to these questions could help

What steps can be used to reproduce the issue?
What browser(s) and Operating System have you tested with?
Does the bug happen consistently across all tested browsers?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

Currently in my code this happens at the following code fragment:
        $select.off ( "select2:open" ).on ( "select2:open", function( e ) {
            if ( $ ( this ).data ( "state" ) === "unselected" ) {
                $ ( this ).removeData ( "state" );
                setTimeout ( () => $ ( this ).select2 ( "close" ), 1 );
            }
        } );

The error appears when $ ( this ).select2 ( "close" ) is executed. The solution was taken from here: http://stackoverflow.com/questions/29618382/disable-dropdown-opening-on-select2-clear
This happens only when I use select2 from inside React component. That event handler is attached inside React's componentDidUpdate handler.
Investigating further.

What steps can be used to reproduce the issue? See below
What browser(s) and Operating System have you tested with? Chrome. Windows 7 Professional
Does the bug happen consistently across all tested browsers? Yes (firefox, IE, Chrome)
What version of jQuery are you using? And what version of Select2? jQuery: jquery-1.10.2.js. Select2:4.0.1
Are you using Select2 with other plugins? No
I’ve had the same problem as this issue dictates but under different circumstances. I’m using a Select2 select box with this clientside code:

Category

When I invoke the select box it gives me the error:
“Uncaught TypeError: Cannot read property 'length' of undefined” wrapper @ Select2.full.js:3502(anonymous function) @ Select2.full.js:3441(anonymous function) @ jquery-1.10.2.js:3218fire @ jquery-1.10.2.js:3062self.fireWith @ jquery-1.10.2.js:3174done @ jquery-1.10.2.js:8249callback @ jquery-1.10.2.js:8792
It is receiving the url information back from the C# Method but not passing it to the wrapper function.
Here is the Server side code:
[WebMethod()]
public static string LoadData()
{
System.Diagnostics.Debug.WriteLine("Went into the subroutine ");
    string strcon = ConfigurationManager.ConnectionStrings["sqlclienttest"].ConnectionString;
    SqlConnection con = new SqlConnection(strcon);
    SqlCommand cmd = new SqlCommand("select * from CatType", con);
    cmd.CommandType = CommandType.Text;
    SqlDataAdapter da = new SqlDataAdapter(cmd);
    DataSet ds = new DataSet();
    da.Fill(ds);
    string jsondata = JsonConvert.SerializeObject(ds.Tables[0]);
    System.Diagnostics.Debug.WriteLine(jsondata);
    return jsondata;
}

Here’s what is being returned:
[{"CatID":1,"Category":"Documentation  "},{"CatID":2,"Category":"DTSC           "},{"CatID":3,"Category":"General        "},{"CatID":4,"Category":"Hardware       "},{"CatID":5,"Category":"HMI            "},{"CatID":6,"Category":"Network        "},{"CatID":7,"Category":"Programming    "}]

I'm commenting this code again, it didn't go through in the last comment.

Category

I've encountered this bug while rewriting select contents on select2:unselecting event. In my case just adding event.preventDefault(); to the event handler function helped.

Hi guys,
How is this issue going? Have you got some updates?
Thanks!

Hi,
I get the same message on a multiselect. It works fine but still throws this message when selecting an option. And I found that select2:unselect and select2:select does not fire event with multiselects.

I'm closing this issue, because discussion seems to have gone completely off topic from the original issue (i.e., looks like people are dumping anything with TypeError here, even if it is a completely unrelated problem).


Adding fix for issue where Region was not correctly passed on NonInteractiveMode. Changing strategy to check for deployment success.

Fixes for regression test script:

Adding fix for issue where Region was not correctly passed on NonInteractiveMode.
Changing strategy to check for deployment success.

Will submit a new PR directly with attribution


Potentially inconsistent messaging for what APIs are available for what Skype for Business offering...

My company just moved to Skype for Business via Office 365, and I'm trying to get a feel for what APIs are available for the hosted SFB. There are quite a few names over the years for everything in the Skype ecosystem, so the confusion could easily just be on my end
At the top of the UCWA 2.0 doc, it states:

Microsoft Unified Communications Web API 2.0 is a REST API that exposes Skype for Business Server 2015 instant messaging (IM) and presence capabilities.

Applies to: Skype for Business 2015, Skype for Business Online

And a little bit further down on the same document:

UCWA 2.0 is available only to customers who have an on-premises deployment.

On the Skype Developer Platform page the table states "Skype for Business Online" is available for this API.
I'm assuming that Skype for Business Server is on-premises, but Skype for Business Online is the Office 365 version, that is fully hosted by Microsoft?

UCWA 2.0 is available for onprem and has been recently release (this April) for Skype for Business online. I have fixed the doc inconsistency.


Batch Stock Quotes

Can you provide an example on how to do batch quotes?

Hi @Engietoday, I am sorry for the late reply. What do you mean by batch quotes?

Hello, thanks for getting back. So in https://www.alphavantage.co/documentation/ there is a section on Batch Stock Quotes, how do I use that?

@Engietoday I hadn't seen that call before (I have been so busy with other things). I am going to implement the call in the next days.
Happy holidays
Romel


⚠ Punto de Fuga has degraded performance

In b679bbd, Punto de Fuga (http://puntodefugapodcast.com) experienced degraded performance:

HTTP code: 200
Response time: 13089 ms

Resolved: Punto de Fuga performance has improved in 72fb798.


Improve the existing REST API docs

Description:
Amila Maha Arachchi reported as follows:
This doc needs a bit more improvement IMO. For example,
What does [ Base URL: apis.wso2.com/api/am/publisher/v1.0 ] mean? Isn't it confusing because there is no such URL?
Also, it would be good to have a bit more info on what this API does rather than just saying " This specifies a RESTful API for WSO2 API Manager - Publisher."
https://docs.wso2.com/display/AM260/apidocs/publisher/index.html

We will not be fixing this as this issue is based on an older version of the product.


Include .key, .pem, .sh extension file ?

How to add file like extension with .pem or .key or .crt etc. into binary ?
Is it possible to add private/public key content into binary ?
Actually, .pem file start with content with
----------BEGIN PRIVATE KEY-----
and it breaks.
Error:
Parsing error: Invalid left-hand side in prefix operation
How to avoid checking/parsing content of one file but include it ?
Please somebody help.

Please include your package.json file
I have included a basic template below that might solve your problem but it is hard to be sure if I don't know the specifics of your package
package.json
{
  "name": "myapp",
  "version": "1.0.0",
  "description": "This is your app description",
  ...
  "pkg": {
    "scripts": [] // JavaScript files you want to package into your app. Will be parsed and checked and all required files will also be parsed and checked
    "assets": [ // Misc files you want to package into your app. Will not be parsed. Certain file extensions will not be allowed (like .node)
      "/my_keys/private_key.pem"
    ]
  },
  "licence": "" // If you leave license as "ISC" as is default then your packaged files might be readable
}

If you want to copy the example into your code please take out the "..." and the comments as they are not valid JSON


Ashton Sixth Form

@ma4cas First stage of verification passed, official domain is asfc.ac.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@ma4cas Pull request merged. Thank you.


Additional: Fixed validation for specific case for Spanish NIFs.

Fixed bug in validation of Spanish nif for specific case of temporary foreign NIFs.
Added test for specific case.
Closes #1913
Thank you!

Thank you @jarey, your code fixes the issue. Well done! 👍

Very useful. Thank you @jarey

Build restarted... lets see

Awesome, was a build issue. Thx for the PR.


bug: doesn’t play nicely with tailwindcss preflight styles

Adding park-ui has broken my existing TailwindCSS components, since it alters the preflight styles.
A default focused form field looks like:

While park-ui changes the styles to:

More focusing on the size and outline radius of the form field, the fonts are different and that’s due to testing.
Related to https://github.com/cschroeter/park-ui/issues/195 this time, instead of park-ui’s styles breaking, my existing styles are breaking.
"@park-ui/tailwind-plugin": "0.20.1",

With a heavy heart, I have decided to discontinue support for Tailwind as the initial maintainer no longer has time to maintain it.


CLI completed

Major step that is very challenging. This equates to v1.0

We are nowhere close to getting this done. I am suspending this task until future notice.


Handle non-resolvable node names

This should address the comment at https://github.com/ubuntu/microk8s/issues/1127#issuecomment-648415386
Note that this is a partial fix because the first node to which other nodes connect does not set the --hostname-override automatically. The admin should do that. The same is expected in the current (non-ha) clustering.

I am merging this @joedborg . Please review when you get some time.


Error during decoding

The script crashes when trying to decode a message where the quoted message is of type 'location'.
Console error: Script snippet no. 1:287 could not decode message "message id" unimplemented wire type 1

These are probably "lat" and "lng" fields, I'll add the wire type decoding.

https://github.com/bitonic/wadump/commit/0121931ca082bced1aedfe671b49f377380893f6 should fix it, can you test?

Sorry, but it still doesn't work.
New console error from line 329:
could not decode message "message id" unimplemented wire type 0

91e9be9e15111b1c1ef71b5a1727312f4ce6aff3 should fix that, could you try again?

I confirm that now it works properly.
Thank you very much


Add scope to target property macros

Addresses #307 #305.  This won't fix any registered targets from being PUBLIC that is a lot trickier and will be solved with imported targets.  I actually started working on that when I realized this would simplify some of the work there.
Docs to come later in this PR...

I have updated the documentation both for the private macro (in file) and the API docs. Which can be seen here:
https://llnl-blt.readthedocs.io/en/feature-white238-targetpropertyscopes/api/target_properties.html
After discussing the PR with @gzagaris and @kennyweiss , I think we came to an agreement about this being okay now.

Thanks @white238. The docs look good.
Minor issue: The note for blt_add_target_definitions looks a bit weird with the code box outside the note. Is there any way to include it in the note?


Add an implementation for SlowDocumentation. [phab:D862]

Created by zarko at 2016-04-27 23:49:22:
This diff builds documentation using doc nodes, which
were introduced in #1143.

zarko wrote at 2016-05-02 17:45:02:
ping

shahms commented inline (context lost during migration) at 2016-05-02 19:42:42:
please to break this into smaller functions

zarko wrote at 2016-05-02 20:10:26:

Address comments.

shahms accepted this revision at 2016-05-02 20:13:32

zarko closed via commit 8931eb9c6338b3cd18909d2ede3f996cd96bbae4 at 2016-05-02 20:34:29


Gene count summary across passages

Need to determine how variants within genes travel across passages. This will require the generation of a matrix that looks like this:

Gene
Only F0
Both
Only F5

KRAS
X
Y
Z

...

I will also do something for the unique patients that have multiple mets and mouse mets sequenced

Additional thoughts on table structure. Given what the output data looks like (all_cosmic_variants.tvs), a more realistic updated table could look like:

Gene
Mutation
Cosmic Info
Only F0
Both
Only F5
None

KRAS
p.G12D
COSM521
X
Y
Z
A

...

An extended table could also include more details about the COSMIC calls, including alternative IDs, number of times they were included in the database and in which tissue. Each cosmic ID will form the rows and the 4 passage columns will store how many "groups" of samples were observed to have the given variant. The sum of those 4 columns must be 30.
My current strategy is to clean the input data for each group (the first 3 columns) and then create the last 4 columns through set intersections.


Issue with k8s.io/ko/docs/concepts/storage/volumes/

This is a Bug Report

Problem:
Line 73:

fc (파이버 채널))
There is extra bracket symbol in the link.

Proposed Solution:
Line 73:

fc (파이버 채널)

Page to Update:
https://kubernetes.io/ko/docs/concepts/storage/volumes/

/language ko

/assign

/close


Improve naming and sorting of generated PDFs

This PR partially addressed #24 by putting the PDFs in subdirectories according to the file structure of the markdown files. This should make it easier to find the correct PDF for each section and also should avoid name collisions.

Great! I will try to quickly merge the two scripts into one that take some input parameters. The code duplication that we have at the moment was already leading to stupid mistakes when introducing the changes.


Fix Globe double render

Fixes #7816.
Right now, the pick and render passes are mutually exclusive, so this doesn't cause a double render. There are plans to have multiple passes in the same render. For example, use multiple render targets where we render the color to one buffer and the pick id to another.
I removed the pass check since the QuadtreePrimitive handles the passes.

Thanks for the pull request @bagnell!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.


Verify if tunnels can be setup on Gateway node

This PR validates if tunnels can be successfully established on the
Gateway node of local cluster. Validation is done by spawning a sniffer
pod on the local cluster Gateway node and a client pod on the non-Gateway
node of a remote cluster. The clientPod sends some UDP traffic to the
local Gateway node on the tunnelPort while tcpdump is executed in the
sniffer Pod. Finally, when both the Pods finish their execution, the
Pod output is compared with expected values and appropriate message
is displayed to the user.
Fixes issue: https://github.com/submariner-io/submariner-operator/issues/1147
Signed-Off-by: Sridhar Gaddam<EMAIL_ADDRESS>

@mangelajo @tpantelis addressed the review comments. Can you please take a re-look. Thanks.


Remote filesystem

I have setup a remote adapter with flysystem, and a local, using replicate adapter.
Now that I want load image from remote adapter, how to setup glide?
Thanks!

Hello, I'd recommend looking through the "source & cache" documentation on the Glide website: http://glide.thephpleague.com/1.0/config/source-and-cache/
You'll do something like this:
<?php

use Aws\S3\S3Client;
use League\Flysystem\AwsS3v3\AwsS3Adapter;
use League\Flysystem\Filesystem;
use League\Glide\ServerFactory;

// Setup S3 client
$client = S3Client::factory([
    'credentials' => [
        'key'    => 'your-key',
        'secret' => 'your-secret',
    ],
    'region' => 'your-region',
    'version' => 'latest|version',
]);

// Setup Flysystem adapter for S3
$adapter = new AwsS3Adapter($client, 'your-bucket-name', 'optional-prefix');

// Setup Glide server
$server = ServerFactory::create([
    'source' => $adapter
]);

Good luck!

Thanks!
However, seem that you missing to init filesystem, this work for me:
$server = ServerFactory::create([
    'source' => new Filesystem($adapter)
]);

Ahh yes, sorry. That's correct. I was going too quick. ;)

No problem, I was able to sort out quickly.
I have a question. I am using replicate adapter.
Now file are stored both on local and remote.
As I understand, with replicate adapter, all read are from source (in my case S3).
But when I setup a CDN that serve images from S3, how Glide handle this?
Does image are served via CDN or from my local cache?
Thanks!

The way Glide works is that all requests must be handled by PHP. This is a requirement of the library, since the library determines if the manipulated image already exists, of it is needs to create it. It has no special features to work with CDNs. For example, just because your manipulated images could be saved on S3, doesn't mean you can easily serve them directly from there. Glide is still a required "middleman".

Oh, this I had not expected ...
I did a quick search if anyone has found a way to integrate CDN with Glide and I don't find nothing.
I only found this tutorial: http://www.sitepoint.com/easy-dynamic-on-demand-image-resizing-with-glide/
where the author provide a workaround to serve cached file without php (check under A Note on Saving with Glide).
He propose this solution:
    public function renderImage($image)
    {
        $width = $this->getWidth($image);

        $imageSource = str_replace('-'.$width, '', $image);

        $imagePath = $this->glide->makeImage($imageSource, ['w' => $width]);
        $imageBase = $this->glide->getCache()->read($imagePath);
        $this->glide->getCache()->put($image, $imageBase);
        $this->glide->outputImage($imageSource, ['w' => $width]);
    }

makeImage creates and saves the image, but returns only its path. We then read the image’s contents with said path from the cache. Finally, we re-save the image under its originally requested name, and then output like we did before. Thus, only this first call will be expensive (several I/O operations and a conversion), and all future calls to this image URL will go straight to the image – bypassing PHP completely. In fact, if you power down PHP with sudo service php-fpm stop, the image will still load.
What do you think?
I read also one your comment on a article, where you said that you design Glide for small project, and that you suggest for large project to prepare all sizes and then store on S3 and serve via CDN.
Maybe I need to get this way, since I am working on a project where user share images, so there will be many traffic.


How to get all users repos

I am newer to ember and I am trying to figure out how i can get access to all of my repositories through this ember data adapter. So far i am able to get ahold of my user data (and get authenticated) like so
// in /routes/profile/index.js
Ember.Route.extend({
  model() {
    return this.get('store').findRecord('github-user', '#');
  }
});

And then in my repos route (where i plan to show a list of repos)
// in routes/profile/repos.js

Ember.Route.extend({
  model() {
    const user = this.get('store').findRecord('github-user', '#');
    let repos = user.githubRepositories;

    return repos;
  }
});

Now I understand that user.githubRepositories will return an ember DS.PromiseManyArray promise, but I do not understand what type of promise code to use to actually get a hand on the repository data.
Any help would be appreciated, thanks!

Try this
model() {
  this.get('store').findRecord('github-user', '#').then((user) => {
    return user.githubRepositories;
  });
}

Awesome thanks for the quick reply! looks like that is working. I also found out too that if I just mess with the base user object in the templates I can loop through my repos doing something like
{{#each model.githubRepositories as |repo|}}
{{repo.name}}
{{/each}}

Awesome!


incompatible with @material-ui/core": "4.10.1

see https://github.com/mui-org/material-ui/pull/21201
<EMAIL_ADDRESS>Module not found: Can't resolve '@material-ui/core/Modal/TrapFocus' in '/Users/michaelli/Workspaces/jtd-admin/node_modules/@material-ui/pickers'

A downside of splitting the repositories, version distribution is harder to coordinate and easier to forget about. Same as: #1619.

What's the resolution for this? Just updated @material-ui/core and got this.

4.0.0-alpha.8 worked for me 👍

solution?

solution?


Metadata fields for Template:Book misrepresented

Dear Pawel,
Thanks for Pattypan 17.05, it is great! Extending the Simple Manual with some examples, I just hit upon your use of the metadata Template:Book https://commons.wikimedia.org/wiki/Template:Book/doc and it appears something is wrong with the data fields presented in the field selection menu.

At the end the fields License and Partnership occur 2 times.
The names of the fields sometimes differ slightly from their definition, e.g., "Page overview" instead of "Pageoverview" and "Home category" instead of "Homecat". I didn't test if this a problem with an upload.

Yours sincerely, Hans Muller
https://commons.wikimedia.org/wiki/User:Hansmuller

At the end the fields License and Partnership occur 2 times.

You are totally right

The names of the fields sometimes differ slightly from their definition

This one should be fine. "Page overview" is just a label in Pattypan and in the future it will be translatable.

Fixed in 17.12.


Prompt responder

Some commands prompt for input. For example sudo ... can ask for a root password.
How can I provide it through chopsticks? Is there any helper?
BTW: great library! I have few simple scripts in Fabric and moving them to Chopsticks, as it's easier to orchestrate tasks on remote.

ups, wrong repo. closing, sorry


gocyclo: Update gocyclo to upstream v0.3.1

Motivation for this change
Update gocyclo to a more recent version that support ignoring of vendor-directory and recursive iteration
Things done
The original repository used in this package was a fork from https://github.com/fzipp/gocyclo but the upstream is a way more updated. So i switch this package to https://github.com/fzipp/gocyclo

Built on platform(s)

[x] x86_64-linux
aarch64-linux
x86_64-darwin
aarch64-darwin

For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
(Module updates) Added a release notes entry if the change is significant
(Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

What to do when nobody is there for an review ? 🤔

I will close this MR in favour for #157227

I will close this MR in favour for #157227


Implementation of Brute force string search algorithm

🚀 Feature
Align the pattern against the first m characters of the text and start matching the corresponding pairs of characters from left to right until either all m pairs of characters match or a mismatching pair is encountered. In the latter case, shift the pattern one position to the right and resume character comparisons, starting again with the first character of the pattern and its counterpart in the text.
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
Its one of the easy method to implement string search.  Helps for beginners to learn and implement basic codes first.
Pitch
We can implement according to the below algorithm.
Brute_Force_String_Match (T[0…n-1], P[0…m-1])
// Implements brute force string match
// Input:- An array T[0…n-1] of n characters representing a text and an array P[0…m-1] of m characters representing a pattern
// Output:- The index of the first character in the text that starts a matching substring or -1 if the search is unsuccessful

for i from 0 to n-m do
       j = 0
      while j < m and P[ j ] = T [ i + j ] do
            j = j + 1
      if j = m
           return i
return -1

I would like to work upon this in C @Kajol-Kumari @Abhijit2505 @SKAUL05 @plazzy99

i will do it in python3,Pls assign it to me.

Hey @prasadvpatil let's not go with the brute force algorithm for this as it's quiet naive! Maybe go for Rabin–Karp or Boyer–Moore string-search algorithm for this.

I will work upon it in C++ @Kajol-Kumari @SKAUL05


[FEATURE] allow golb for alias

I have defined paths in my tscongif  that i can import from src subfolders like "components", "containers"
"compilerOptions": {
    "baseUrl": ".",
    "paths": {
      "*": ["src/*"]
    }
  }

right now i have to define all folders as aliases in snowpack config..

For vite I found a package vite-tsconfig-paths that solves this issue.
there is a similar one for snowpack tsconfig-paths-snowpack-plugin, but I couldn't make it work.


Add product block resource to graphql root Query

Closes: #303

Codecov Report

Merging #316 (3c8e88d) into main (3945848) will increase coverage by 0.05%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   76.68%   76.74%   +0.05%
==========================================
  Files         165      168       +3
  Lines        8501     8557      +56
  Branches     1370     1373       +3
==========================================
+ Hits         6519     6567      +48
- Misses       1789     1799      +10
+ Partials      193      191       -2

Files Changed
Coverage Δ

orchestrator/db/filters/process.py
71.42% <ø> (ø)

orchestrator/db/filters/product_block.py
100.00% <100.00%> (ø)

orchestrator/db/sorting/product_block.py
100.00% <100.00%> (ø)

orchestrator/graphql/__init__.py
92.18% <100.00%> (+0.25%)
:arrow_up:

orchestrator/graphql/resolvers/__init__.py
100.00% <100.00%> (ø)

orchestrator/graphql/resolvers/product_block.py
100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more