v1.13 Endgame

Release team
Release lead: @JoshVanL
Release lead shadow(s): @mikeee
Perf test lead:  @yaron2
Longhaul test: TODO
Build manager: TODO
Read about the Dapr release lifecycle
Feature definition starts: 2023-10-24
Feature definition ends: 2023-11-07
Feature freeze: 2023-12-19
Code freeze (Endgame starts ~2 weeks stabilization): TBD
Release day: ~2024-01-30~ TBD
Announcement day: TODO
Release Tasks:

[ ] Code freeze at : 2024-01-16

[ ] Remaining Changes for 1.13:

[x] https://github.com/dapr/dapr/pull/7521
[x] https://github.com/dapr/dapr/pull/7539
[x] https://github.com/dapr/dapr/pull/7537
[x] https://github.com/dapr/dapr/pull/7527
[x] https://github.com/dapr/dapr/pull/7524
[x] https://github.com/dapr/dapr/pull/7462
[x] https://github.com/dapr/dapr/issues/7468
[x] https://github.com/dapr/dapr/issues/7295
[x] https://github.com/dapr/dapr/issues/7411
[x] https://github.com/dapr/dapr/issues/7412
[x] https://github.com/dapr/dapr/issues/7409
[x] https://github.com/dapr/dapr/pull/7286
[x] https://github.com/dapr/dapr/pull/7399
[x] https://github.com/dapr/dapr/issues/7422
[x] https://github.com/dapr/dapr/issues/7408
[x] https://github.com/dapr/dapr/issues/7413 (P0)
[x] https://github.com/dapr/dapr/issues/6393
[x] https://github.com/dapr/js-sdk/issues/463
[x] https://github.com/dapr/js-sdk/issues/545
[x] https://github.com/dapr/dapr/pull/7214
[x] https://github.com/dapr/dapr/pull/7041
[x] https://github.com/dapr/dapr/issues/7203
[x] https://github.com/dapr/dapr/pull/7401
[x] https://github.com/dapr/dapr/pull/7400

[ ] Docs:

[x] https://github.com/dapr/dapr/issues/7149
[x] https://github.com/dapr/docs/issues/3857
[ ] https://github.com/dapr/docs/issues/3907
[x] https://github.com/dapr/docs/issues/3914
[x] https://github.com/dapr/docs/issues/3945
[x] https://github.com/dapr/docs/issues/3948
[x] dapr/docs#3949
[x] dapr/python-sdk#661
[ ] dapr/dotnet-sdk#1226

[ ] SDK:

[x] https://github.com/dapr/python-sdk/issues/635
[ ] https://github.com/dapr/docs/issues/3868
[x] https://github.com/dapr/docs/issues/3869
[x] https://github.com/dapr/docs/issues/3921

[ ] Quickstarts:

[ ] https://github.com/dapr/quickstarts/issues/965
[ ] https://github.com/dapr/quickstarts/issues/964
[x] https://github.com/dapr/quickstarts/issues/978

[x] Check all new components are registered in dapr/dapr @JoshVanL
[ ]  E2E, certification and perf tests are passing @yaron2
[x] Create release-1.13 branch and cut RC 1.13.0-rc.1 for component-contrib
[x] Update dapr/component-contrib pkg to 1.13.0-rc.1 in dapr/dapr master branch
[x] Create release-1.13 branch for Dapr runtime
[x] ~Verify helm chart and ~ Cut the 1.13.0-rc.1 release for Dapr runtime
[x] Create release-1.13 branch for CLI
[ ] Update dapr/dapr pkg to 1.13.0-rc.2 in dapr/cli release-1.13 branch @yaron2
[ ] Cut the 1.13.0-rc.1 release for CLI @yaron2
[ ] Trigger GitHub actions in dapr/homebrew-tap (GitHub disables Actions after 1mo without commits) @artursouza
[x] Notify users about dapr/dapr 1.13.0-rc.1 via Discord @artursouza
[ ] Validate the upgrade path from the previous release -- CRDs updated, no deletion of components/configs etc. @elena-kolevska
[ ] Create RC for installer-bundle @shivamkm07
[ ] Validate RC for installer bundle @shivamkm07
[x] Update proto and cut the rc release for Java SDK @artursouza @cicoyle
[x] Update proto for Python SDK @elena-kolevska
[ ] Update proto for Go SDK @mikeee
[ ] Update proto and cut the rc release for dotnet SDK @philliphoff
[x] Update proto cpp SDK @JoshVanL
[x] Update proto for rust SDK @elena-kolevska
[ ] Cut the rc release for Dashboard @yaron2
[ ] Update longhaul tests with RC for runtime and dotnet SDK @philliphoff @halspang
[ ] Update quickstarts/tutorials automated validation and check it works - covers Linux Standalone/ K8s / Darwin MacOS. @paulyuk
[ ] Create PR for quickstarts to point to RC SDKs/Dev package? if it is available @paulyuk
[x] Test and validate tutorials in Linux ARM64 k8s and self-hosted @yaron2
[ ] Test and validate tutorials in Windows @mukundansundar
[ ] Validate Dapr CLI non-slim scenarios on Windows - @mukundansundar
[ ] Validate Multi app run K8s on Windows @mukundansundar
[ ] Validate longhaul metrics @halspang
[ ] Test and validate the .NET SDK - run through samples @philliphoff
[ ] Test and validate the Java SDK - run through samples @artursouza
[x] Test and validate the Python SDK - run through samples @elena-kolevska
[ ] Test and validate the Go SDK - run through samples @yaron2
[ ] Test and validate Dashboard, local mode and kubernetes hosted @cicoyle
[ ] Update certification tests in components-contrib release branch (prior to merge back into master) to use the RC (and Go SDK RC/release if possible). @ItalyPaleAle
[ ] Confirm with maintainers that each repo has milestone set for all relevant issues & PRs, then generate release notes

[x] CLI - @yaron2 @mukundansundar
[x] runtime - @JoshVanL @yaron2
[x] components-contrib - @ItalyPaleAle  @berndverst
[x] .NET SDK - @philliphoff
[x] Java SDK - @artursouza
[ ] JS SDK - @XavierGeerinck
[ ] Python SDK - @berndverst @elena-kolevska
[x] Go SDK - @yaron2
[ ] Check all milestones for each repo above are up to date before cutting the release notes.

[ ] Validate FOSSA on each repo

[ ] CLI - @yaron2 @mukundansundar
[ ] runtime - @JoshVanL @yaron2
[ ] components-contrib -  @ItalyPaleAle  @berndverst
[ ] .NET SDK - @philliphoff
[ ] Java SDK -  @artursouza
[ ] ~JS SDK~ -
[ ] Python SDK -  @berndverst @elena-kolevska
[ ] Go SDK - @yaron2

[ ] Edit and complete release-notes on HackMD (everyone)
[ ] Verify 1.13 documentation - @msfussell

ETA for all above: ~
RELEASE DAY:

[ ] Release Dashboard - @yaron2
[ ] Validate breaking changes section in release notes (everyone)
[ ] Merge release notes into release branch @JoshVanL
[ ] Cut tag for components-contrib @ItalyPaleAle
[ ] Release Dapr 1.13 @JoshVanL
[ ] Release CLI 1.13 @mukundansundar  @yaron2
[ ] Release Installer Bundle 1.13 @shivamkm07
[ ] Create blog post @hhunter-ms
[ ] Release cpp-sdk: @yaron2 @elena-kolevska
[ ] Release js-sdk: @XavierGeerinck @shivamkm07
[ ] Release go-sdk: @mikeee @yaron2
[ ] Release java-sdk: @artursouza
[ ] Release python-sdk: @berndverst @elena-kolevska
[ ] Release rust-sdk: @JoshVanL
[ ] Release dotnet-sdk and release nuget packages: @philliphoff @paulyuk
[x] Create release-1.13 branch for quickstarts, update version tag in the images, create v1.13.0 tag: @paulyuk
[ ] Create components-contrib release from Tag. Copy components release notes section into the description of the release. @ItalyPaleAle @yaron2
[ ] Validate DevContainers in following repos

[ ] dapr/dapr: @salaboy
[ ] dapr/components-contrib: @salaboy
[ ] dapr/cli: @salaboy
[ ] dapr/quickstarts: @salaboy

[ ] Update certification tests in components-contrib release branch (prior to merge back into master) to use latest runtime and Go SDK release. @yaron2 @ItalyPaleAle
[ ] Generate new Java docs based on the release version of the Java SDK: @artursouza @mukundansundar

POST RELEASE DAY

[ ] Update Dapr K8s Operator https://operatorhub.io/operator/dapr-kubernetes-operator @salaboy
[ ] Update Dapr Kratix Marketplace https://github.com/syntasso/kratix-marketplace/tree/main/dapr @salaboy
[ ] Update Dapr Test Containers Module https://github.com/diagridio/testcontainers-dapr @salaboy

@JoshVanL Please add the following docs and SDK issues above:
https://github.com/dapr/docs/issues/3949
https://github.com/dapr/python-sdk/issues/661
https://github.com/dapr/dotnet-sdk/issues/1226

@artursouza These are the PRs which are blocking the release candidate:
https://github.com/dapr/dapr/pull/7433
https://github.com/dapr/dapr/issues/7295
https://github.com/dapr/dapr/pull/7441
https://github.com/dapr/dapr/pull/7399

A yet to be opened PR for fixing MacOS test runners

@JoshVanL Please mark this issue https://github.com/dapr/dapr/issues/7468 as P0 and a blocker for cutting RC. The fix PR is created: https://github.com/dapr/dapr/pull/7467

@msfussell @JoshVanL I didn't want to edit the text, but for the Post Release day can we just refer to this issue: https://github.com/dapr/dapr/issues/7364 Instead of having a duplicate list here?

@JoshVanL The protos have been updated and a RC (v1.13.0-rc02) released cut/published for the Dapr .NET SDK.

FOSSA's license check is passing for Java-SDK. The original FOSSA scope was for license and not security, for that reason I am reporting the FOSSA task as complete for Java-SDK. Although I did update some dependencies, FOSSA still flags some for Java SDK. I will update more of those in the next release. If we want to clear both for this release, I ask @cicoyle to help with update of dependencies in Java SDK. I am OOO in the next 7 days with limited Internet access.

Dapr CLI non-slim scenarios have been validated on Windows with both Docker and Podman (test plan: https://github.com/dapr/cli/issues/1078).

Create RC for installer bundle https://github.com/dapr/installer-bundle/releases/tag/v1.13.0-rc.6

Validated installer bundle darwin, by downloading and following the README for init using --from-dir flag.
Validated for others using the logs in the run https://github.com/dapr/installer-bundle/actions/runs/7990899692/job/21820768843#step:10:62 for each platform and arch.

@JoshVanL are all of these steps complete?
Can this be closed if so?


kubeflow.org SEO needs some love

Part of the confusion with new users is that outdated material is showing up first in searches. We need to pump up the SEO to make sure the current getting started/user guide is what they see first.
/assign @abhi-g
/assign @ewilderj

https://keithpblog.org/post/hugo-website-seo/

/unassign @ewilderj
/unassign @abhi-g
/assign

https://support.google.com/webmasters/answer/9128669?hl=en

https://developers.google.com/search/docs/guides/

Most fitting Schema.org category seems to be: WebSite
https://schema.org/WebSite

https://developers.google.com/search/docs/guides/intro-structured-data

I'm going to try building our site with the env variable set to production, to index the site. Evidently we've never done that. Could help our SEO as well as fix the search box.

We should target specific words on the relevant docs. Examples:
tutorial
install/installation/deploy/deployment

Our SEO is already better, 2 days after setting the Hugo environment to "production". Here are some "before" and "after" screenshots, all taken from an incognito window.
Search for "kubeflow" before - the website does not appear:

Search for "kubeflow" after - the website is the 3rd result, after GitHub and Twitter:

Search for "kubeflow install ksonnet" before:

Search for "kubeflow install ksonnet" after:

Search for "kubeflow ml pipelines" before:

Search for "kubeflow ml pipelines" after:

Awesome job. Thank you Sarah!
Abhishek
On Wed, Feb 13, 2019 at 12:50 PM Sarah Maddox<EMAIL_ADDRESS>wrote:

Our SEO is already better, 2 days after setting the Hugo environment to
"production". Here are some "before" and "after" screenshots, all taken
from an incognito window.
Search for "kubeflow" before - the website does not appear:
[image: screenshot-search-kubeflow-2019-02-12 04-59-36]
https://user-images.githubusercontent.com/6138251/52742753-508fb400-2f8d-11e9-9dc3-ff6c5e66494d.png
Search for "kubeflow" after - the website is the 3rd result, after
GitHub and Twitter:
[image: screenshot-search-kubeflow-2019-02-13 12-42-54]
https://user-images.githubusercontent.com/6138251/52742796-67cea180-2f8d-11e9-9397-084a3ec34121.png
Search for "kubeflow install ksonnet" before:
[image: screenshot-search-kubeflow-install-ksonnet-2019-02-12 05-00-59]
https://user-images.githubusercontent.com/6138251/52742828-7e74f880-2f8d-11e9-8683-00784a2cfc14.png
Search for "kubeflow install ksonnet" after:
[image: screenshot-search-kubeflow-install-ksonnet-2019-02-13 12-41-38]
https://user-images.githubusercontent.com/6138251/52742854-90ef3200-2f8d-11e9-9942-efb198e6aa9f.png
Search for "kubeflow ml pipelines" before:
[image: screenshot-search-kubeflow-ml-pipelines-2019-02-12 05-02-57]
https://user-images.githubusercontent.com/6138251/52742887-a82e1f80-2f8d-11e9-9200-42afef198355.png
Search for "kubeflow ml pipelines" after:
[image: screenshot-search-kubeflow-ml-pipelines-2019-02-13 12-37-49]
https://user-images.githubusercontent.com/6138251/52742905-b67c3b80-2f8d-11e9-8e6c-f862b5b6483a.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/website/issues/98#issuecomment-463364298,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALOqZh9rYNP6CusQffQ-yonjY9CnhgOxks5vNHqEgaJpZM4VYlRO
.

Great work Sarah!

Thanks folks :)


HDDS-2547. Sonar: remove volatile keyword from BlockOutputStream bloc…

…kID field (#79)
What changes were proposed in this pull request?
fixes issue reported by sonar
https://sonarcloud.io/project/issues?id=hadoop-ozone&open=AW5md-_2KcVY8lQ4ZsVd&resolved=false&types=BUG
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2547
How was this patch tested?
Ran project unit tests

+1. Thanks for the contribution. I will commit this now.

@mohammadjkhan  Welcome to Ozone. Thank you for the contributions.

Thanks @anuengineer


How to customize jsproxy domain of cf worker?

I add a CNAME record to the jsproxy of cf worker,
add a routes on cf worker manage panel
Then visit https://proxy.buildtest.club/
show me:
Failed to register a ServiceWorker: A bad HTTP response code (523) was received when fetching the script.

How do you config your cf worker's route?  It should be filled in like this https://proxy.buildtest.club/*.  The * at the back is indispensable.

您如何配置cf工作者的路由？应该这样填写https://proxy.buildtest.club/*。将*在后面是必不可少的。

How do you config your cf worker's route? It should be filled in like this https://proxy.buildtest.club/*. The * at the back is indispensable.

I try to add /*,It works,thanks

能告诉我怎么做到自定义域名的吗？我直接在另一个域名上加cname好像不行的样子，需要修改什么地方吗？我的cf work域名是google.cqupt.workers.dev，然后我想自定义域名google.cqupt.site 做一个cname指向google.cqupt.workers.dev，但是他报错了
下面是google翻译的英文版，希望您能看懂：
The following is the English version of google translation, I hope you can understand:
Can you tell me how to do a custom domain name? I don't seem to be able to add cname directly to another domain. What needs to be modified? My cf work domain name is google.cqupt.workers.dev, then I want to customize the domain name google.cqupt.site to make a cname pointing to google.cqupt.workers.dev, but he Wrong

能告诉我怎么做到自定义域名的吗？我直接在另一个域名上加cname好像不行的样子，需要修改什么地方吗？我的cf work域名是google.cqupt.workers.dev，然后我想自定义域名google.cqupt.site 做一个cname指向google.cqupt.workers.dev，但是他报错了
下面是google翻译的英文版，希望您能看懂：
The following is the English version of google translation, I hope you can understand:
Can you tell me how to do a custom domain name? I don't seem to be able to add cname directly to another domain. What needs to be modified? My cf work domain name is google.cqupt.workers.dev, then I want to customize the domain name google.cqupt.site to make a cname pointing to google.cqupt.workers.dev, but he Wrong

好了我解决了，想要自定义域名还是得开个服务器

能告诉我怎么做到自定义域名的吗？我直接在另一个域名上加cname好像不行的样子，需要修改什么地方吗？我的cf work域名是google.cqupt.workers.dev，然后我想自定义域名google.cqupt.site 做一个cname指向google.cqupt.workers.dev，但是他报错了
下面是google翻译的英文版，希望您能看懂：
The following is the English version of google translation, I hope you can understand:
Can you tell me how to do a custom domain name? I don't seem to be able to add cname directly to another domain. What needs to be modified? My cf work domain name is google.cqupt.workers.dev, then I want to customize the domain name google.cqupt.site to make a cname pointing to google.cqupt.workers.dev, but he Wrong

你需要将域名的DNS托管在Cloudflare上. Cloudflare的dashboard上面有worker相关的配置, 需要在里面配置route之后, CNAME记录才会正常生效.
详细信息可以参考这个页面:

https://developers.cloudflare.com/workers/about/routes/#matching-behavior

@JimmyTinsley You need add a worker route,and the address need add /, example:www.bulidtest.club/


fix: visible component fix breakpoint class names

Description
Issues
Closes
DEV-XXX:
Related
Testing
Automated tests
Manual testing
Screenshots
Additional notes

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr114.dev.hel.ninja :rocket::rocket::rocket:

Sports-Helsinki branch is deployed to platta: https://liikunta-pr114.dev.hel.ninja :rocket::rocket::rocket:

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr114.dev.hel.ninja :rocket::rocket::rocket:


Update ModLenses Integration (Hide Whitespace Changes required)

I went through an updated the MoreLenses integration, including adopting the current folder structure used by ML.  The primary difference between this CQUI integration and the ML integration is in the filename casing:  ML currently has all references to filenames lowercased, however, it does not look like (at least in my Git repo) that the files are actually lowercased.
I verified this loaded and worked on Exp2.  I'm setting this as a draft request right now as I want to take time later to verify a bit more, though I think it'll work just fine, at least on Windows.  I'm hoping @RustyD or @chaorace can give this branch a go on Linux and see if the Minimap Panel and lenses will at least load.
Note: Git appears to have not liked the "git move" for the files.  Lame.  By and large, there's no code to specifically review since it's just integrating an already released mod.  The "CQUI Specific" sections were marked previously and remain so in this instance.

Can we please wait for a proper access to lua.log from Linux? Without it this is going to be a blind chase.

is why it's a draft - just here to be available, etc.  more lenses needed updating anyway, so eventually this becomes a thing.  no rush on this one

Well, I've just had another quick check, and there is no 'lua.log' in my Logs folder.
So, unless there is a lua expert who might be able to suggest why this is missing from my installation, then it seems like my contribution is of low value? That would be a shame.

On Win, there are 2 files with config options, AppOptions.txt and UserOptions.txt. There are many logging and debug options in them. If you find them, then pls. post and we'll see if nothing is missing in them.

The "rework folder structure" commit in ML's github is from 1 Jun. The latest release on Steam is from 23 May.
So, the new folder structure has not yet been released.

On Win, there are 2 files with config options, AppOptions.txt and UserOptions.txt. There are many logging and debug options in them. If you find them, then pls. post and we'll see if nothing is missing in them.

Ok, attached. I've tried turning on some of the 'debug options' - not sure if that has made a difference.
Options.zip

AppOptions seems ok. In UserOptions, set to 1 all "AI...Log" params and GameEffectsLogLevel = 2. Also you may try ProfileEnabled  = 1, I don't remember if I have it on 1 or 0. Same with GameHistoryLogLevel - not sure what it does.
Imho, lua.log is like a default file. I think it should on everyone's system by default. So idk, check again that Civ6 can write into that folder, etc. Also, I'd like other Linux guys to help with that issue.

AppOptions seems ok. In UserOptions, set to 1 all "AI...Log" params and GameEffectsLogLevel = 2. Also you may try ProfileEnabled = 1, I don't remember if I have it on 1 or 0. Same with GameHistoryLogLevel - not sure what it does.
Imho, lua.log is like a default file. I think it should on everyone's system by default. So idk, check again that Civ6 can write into that folder, etc. Also, I'd like other Linux guys to help with that issue.

I tried all those settings you suggested, and also made the 'Logs' folder writable by all. Still no joy. It must be something else about my system somewhere.
Actually, thinking about it, I may be able to try it out on my old desktop system and see if I get the same issue there. I'll probably need a day or two to get around to that, but maybe I'll have more joy there.

I am closing this for now, will re-do the integration update at some point in the future.

I am closing this for now, will re-do the integration update at some point in the future.


Model Limitations

I would like to give a simple suggestion. There could be support or some way to add custom models instead of just using the OpenAI model. There are projects that use third-party platforms that use the Chat-GPT model and can be accessed via API. The reason for this is the cost of the API from the platforms offered, especially from OpenAI. This option would provide a cost-free and more accessible path.
Here is a list of some projects with this theme:
OpenGPT
GPT4FREE

Have you tried any of the other LLM integrations yet? https://python.langchain.com/en/latest/modules/models/llms/integrations.html
Huggingface, llama, anthropic, cohere , and gpt4all are all popular models people use

Yeap. Now it is 26? integrations with different LLM providers. Several of them provide many LLM. Several others use popular OS or SaaS models.
Examples:

https://docs.cohere.com/docs/models
https://docs.ai21.com/docs/jurassic-2-models
etc.

But maybe you mean something different?


This did not install on VS Code for Mac

Going to close this for now, feel free to open another issue if not resolved.


Errors are not reported to Bugsnag

Laravel Version: 5.6.28
PHP Version: 7.2.2

Description:
I open this issue because it is not clear if the error is only caused to laravel-bugsnag or laravel itself.
As described in this issue https://github.com/bugsnag/bugsnag-laravel/issues/311 errors are not or only a fraction of the errors are sent to Bugsnag.
Steps To Reproduce:
Using laravel valet (installed a fresh copy of laravel 5.6.28)
laravel new bugsnagtest
composer require "bugsnag/bugsnag-laravel:^2.0"

followed these instructions: https://docs.bugsnag.com/platforms/php/laravel/
added Bugsnag\BugsnagLaravel\BugsnagServiceProvider::class, to the providers array in app/config.php
added BUGSNAG_API_KEY=your-api-key-here to my .env with an api-key of an new / empty Bugsnag project
updated as mentioned in the docs my config/logging.php
and finally as mentioned in the docs Bugsnag::notifyException(new RuntimeException("Test error"));
The error is only sent the first time to bugsnag.

I understand that you're desperate to find the cause of the problem, but what makes you think it's a problem in laravel/framework? Is there anything at all that points to it?
Is it even possible for any Laravel developer to reproduce or track down this issue without being bugsnag customers and having a bugsnag api key?
Can we do anything at all with this issue as-is?

I don't know, and since bugsnag hasn't been able to trace the problem so far, it would be interesting if someone with more experience of the laravel core could look at it.
No, without Bugsnag account you won't be able to reconstruct this, but since Bugsnag is extensively used in the whole laravel community, it affects some people (see also issue above, where others have the same problem).
Bugsnag has worked without any problems until now. The problems occurred only since the logging changes in 5.6.

I will say that my Bugsnag has been working just fine on v5.6, so this is most likely an issue with your application.  I would close this issue and try asking in a forum for better help.

I also occurs on a fresh laravel installation as described above.

@Sladewill on laravel 5.6 it is set in config/logging.php

@Sladewill as mentioned in the docs, this is now done in the BugsnagServiceProvider and no longer in the AppServiceProvider.

I believe we are running an older version of bugsnag laravel and haven't got it running through the logger on our 5.6 projects. Which appears to be working.

@grund3g Are you sure that the error is being sent only one time? Bugsnag collapses all errors of the same kind. You can see how many occurrences an error had, I believe this is your case.

@jmarcher, yes it is sent only one time. Always "1" in the "Events" row in my Bugsnag Inbox

I also checked if the "error request" is sent at all or not to the bugsnag server with a network analyzer, but it seems that the error never leaves my app


chore: Make sure ini scan dir is extended

Description
This will ensure that if the flag --with-config-file-scan-dir is set, it won't override it but extend it.
Type of change

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] New feature / enhancement (non-breaking change which adds functionality)
[ ] Security fix
[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] Documentation has been updated
[ ] This change requires changes in testing:

[ ] unit tests
[ ] E2E tests

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding cross-ontologies relations to BP terms: GO:0042352, GO:0042351 and GO:0061619

Hello,
Would it be possible to add the missing cross-ontologies relations to the following GO terms:
GO:0042352 GDP-L-fucose salvage
To add:
has_primary_output CHEBI:18287 L-fucose
GO:0042351 de novo GDP-L-fucose biosynthetic process
To add:
has_primary_input  CHEBI:21168  GDP-mannose
has_primary_output CHEBI:57984  GDP-L-fucose(2-)
GO:0061619 glycolytic process from mannose through fructose-6-phosphate
To add:
has_primary_output CHEBI:15361  pyruvate
Thank you
Rossana
@sjm41
@ukemi

Hi @rozaru
Can you please tell me how you'd like to use this? We have not typically put outputs for degradation processes or inputs for synthesis processes; it's easy enough to add these three, but that seems to make the ontology inconsistent, so I'd like to understand if you specifically need these, or if we need a more global project to review what we capture WRT links to ChEBI.
Thanks, Pascale

Hi @pgaudet,
I didn't realise that it was not a standard process to add them when the boundaries of a pathway are clear. It's just that most of the specific GO terms for a pathway that I looked at they tend to have primary input/output so I thought that they were necessary for the GO term.
For example:
GDP-mannose biosynthetic process from mannose
mannose to fructose-6-phosphate catabolic process
I don't have a usage so far for them. They are normally mention in the definition, but maybe in the future to have them in an ontology as well could help to search for them.
Mainly, I just wanted to be consistent with the other pathways. If it's causing problems, I can close the ticket.
Thanks
Rossana

The problem is that our guidelines are not exhaustive enough.
For the logical definition of a term, we need only to include how it's different from the parent, so for example 'glucose catabolic process' is a catabolic process with primary input glucose.
With respect to start and ends, I always assumed this referred to MFs, but again the guidelines are not explicit about this.
For example for GO:0061621 canonical glycolysis, the logical definition is
'glycolytic process through glucose-6-phosphate'
and ('has part' some 'glyceraldehyde-3-phosphate dehydrogenase (NAD+) (phosphorylating) activity')
and ('starts with' some 'glucokinase activity')
and ('has primary output' some 'NADH(2-)')
and ('has primary input' some D-glucopyranose)
and ('has primary input' some 'NAD(1-)')
So, we have start and end reactions, but no output chemical.
(I also understand from @cmungall that this logical definition has more in it than what is strictly necessary and sufficient, but we dont yet have clear guidelines.
Thanks, Pascale

Yes, it would definitely be helpful to have more guidelines and consistency with these logical defs.
I suppose if the main guideline is "necessary and sufficient", then there's always going to be variation in whether a LD has a 'primary input/output' or 'starts/ends with', just depending on what's needed to distinguish the term.
For GO metabolic pathway terms, it's extremely useful to have a specific (CHEBI) metabolite and/or enzyme logically defined as the start and end point in order to specify pathway boundaries and ensure consistent usage and clear meaning.

We can do this for now, but I think a less ambiguous solution would be to use 'de novo' biosynthetic process (no term yet, as far as I can tell) and GO:0043094 '(cellular) metabolic compound salvage' (Edith is currently removing 'cellular' from all these terms) as the genus, so we would have

GDP-fucose biosynthesis : is_a biosythetic process, has primary output some GDP-fucose
de novo GDP-fucose biosynthesis : is_a do novo biosythetic process, has primary output some GDP-fucose
GDP-fucose salvage : is_a metabolic compound salvage, has primary output some GDP-fucose

This way is still allows is to distinguish between pathways that really do start with different compounds. I just dont think that using primary input and primary output to distinguish salvage and de novo pathways will be robust enough.
What do you think ?

That's an interesting idea. I guess we could go down that road.
Though I thought that most metabolic 'biosynthetic processes' were implicitly 'de novo biosynthetic processes' anyway - it's just that the 'de novo' prefix is explicitly added to distinguish those cases where a 'salvage' pathway is also described.
True?
I think mine and Rossana's main aim for this example (and more generally, wherever possible) is to have a clearly defined start (input) and end (output) as CHEBI IDs in the relationship/intersection lines.
Here, the  'de novo' GDP-L-fucose biosynthetic process term has a GO textual def, MetaCyc xref and Reactome xref that all agree on the start and end of the pathway, so it would be good if the GO term relationship/intersection clearly indicated this - then curators will be able to use such terms consistently, and computation over the annotations can happen accurately.
This is part of the wider discussion that's currently happening about how/when GO specifies the start/end of pathways - and whether that's specified as inferred/asserted classes, and whether we do this using chemicals (has_input/has_output) and/or activities (starts_with, ends_with)

Though I thought that most metabolic 'biosynthetic processes' were implicitly 'de novo biosynthetic processes' anyway - it's just that the 'de novo' prefix is explicitly added to distinguish those cases where a 'salvage' pathway is also described.
True?

Yes, absolutely.

I guess my point is that from the LD you propose:
intersection_of: GO:0009058 ! biosynthetic process
intersection_of: has_primary_input CHEBI:57527 ! GDP-alpha-D-mannose(2−)
intersection_of: has_primary_output CHEBI:57273 ! GDP-beta-L-fucose(2−)
I dont know how to tell that this is a de novo pathway. This is why it would be clearer to be if that were the genus.

I guess my point is that from the LD you propose
I dont know how to tell that this is a de novo pathway. This is why it would be clearer to be if that were the genus.

Yes, good point.
But if we add a new 'de novo biosynthetic process' term for this purpose, would we then need to review all current 'biosynthetic process' terms to see which should change to using the new term as an inferred/asserted parent?


[BanyanDB] Package ctl binary separatedly.

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
DB ctl tool is included in server binary and image, which is not convenient and easier to trggier cli.
Use case
We should package ctl out of database server binary with signed asc and sha code.
Then, from the experience of OAP, we should not include ctl in the server image too.
Related issues
No response
Are you willing to submit a pull request to implement this on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Then, from the experience of OAP, we should not include ctl in the server image too.

The health-checking procedure depends on bydbctl to check the health of HTTP and gRPC services. Should we add a bydbctl sidecar to each node? What are your main concerns about incorporating bydbctl?

Recently, we add simply http endpoint in OAP for health check to simplify this case.
You should consider that too. Rely on ctl Makes things tricky.
https://skywalking.apache.org/docs/main/next/en/api/health-check/
For k8s, we don't need that complex and complete health check. It should be simply true or false.

What are your main concerns about incorporating bydbctl?

Lower cve maintenance in deployment. Less is better from my past years experiences.
Healthy check should be easy and to be done through http endpoint. It limits features, but k8s pod check doesn't need those. We will be able to use ctl when we need it.


fix(docker-compose.yml): remove illegal whitespace

fixed for:
ERROR: environment variable name 'KONG_PG_USER ' may not contain whitespace

:+1:

Thank you very much for your support. Sorry to see it now.😃


Generic zero inflated random variable

Hi and thanks for this package!
I'm curious would it be possible to create a zero-inflated random variable generically?
For example, suppose d1 & d2 are existing random variables.
d3 = MixtureModel([d1, d2], [0.5, 0.5]) returns a new random variable
d4 = Truncated(d3, 0.25, 1.8) returns a new random variable
Is it possible to do something like:
d5 = ZI(d4, p)
I realize there may not be some properties that automatically work for some new ZI random variables..
Btw, isn't ZI essentially a special case of MixtureModel?
Check out discussion here.

Thanks for the suggestion!
Since the package was originally designed for insurance application (where zero inflation is prominent), zero inflation is separated out as a special case of expert functions.
For this reason, in the current version, the optimization function for zero inflation probability is separated from the parameters in the positive part. Looking back, this is not the best design, as zero probability should be treated just as a parameter of expert functions.
To make the package more suited for adding general MixtureModel distributions, what I have in mind is:

I will first restructure some optimization procedures, so that zero inflation is optimized within each expert function.
Make the expert type more general, so that ZI is not separated out as a special case.
Afterwards, I think it should be easy to add general MixtureModel distributions as new expert functions.


Improve jsonwsp parser tests.

Our parser tests are only checking if the input was "validated" i.e. has expected structure and not if the parsing results are as expected. We may want to improve upon it.
Originally posted by @adamczykm in https://github.com/Plutonomicon/cardano-browser-tx/issues/130#issuecomment-1044695957

some info on the original parser testing plan @ngua this may make it into the test plan

we used Medea for these so that we could document the structure in the form of a medea Schema
we collect a series of example json which should both pass the Medea Schema and our parser.
as parsing bugs are found, you add the json of the bug-inducing data to your fixtures, correct the medea schema if necessary, and then adjust the parser as needed.

this really helps prevent regressions in my experience.

We don't really care about particular values, only about the format.


[Chatdown] Suggestions are not displayed

Version
<IP_ADDRESS>450
Describe the bug
[Suggestions=] command from chatdown is not displayed.
To Reproduce
Steps to reproduce the behavior:

Create a test.chat file
Write:

bot: some suggestions
bot: [Suggestions=yes|no]

convert it to transcript: chatdown test.chat > test.transcript
open test.transcript in Bot Framework Emulator

Expected behavior
Bot Framework Emulator should display the suggestions "yes" and "no" after the text "some suggestions".
Additional context
The message is logged and the inspector displays the JSON which seems to be well formatted:
...
{
  "channelId": "chatdown",
  "conversation": {
    "id": "4b008870-45a4-11e9-8f60-15ac963992b1|transcript"
  },
  "from": {
    "id": "bot",
    "name": "bot",
    "role": "bot"
  },
  "id": "2",
  "recipient": {
    "id": "494e802e-2570-4d16-90b3-7051f6e190b1",
    "name": "user",
    "role": "user"
  },
  "showInInspector": true,
  "suggestedActions": {
    "actions": [
      {
        "title": "yes",
        "type": "imBack",
        "value": "yes"
      },
      {
        "title": "no",
        "type": "imBack",
        "value": "no"
      }
    ]
  },
  "text": "",
  "timestamp": "2019-03-13T15:25:03.100Z",
  "type": "message"
}

I am able to repro this and it looks like a WebChat regression.
@corinagum, @compulim - I can see the json is formatted correctly and webchat does show the message in a faint line but no suggested actions are rendered.

@cytops - talking with @corinagum we've confirmed that suggested actions do not show up in WebChat when in "transcript" mode. When using a live sample bot, suggested actions display as expected:

I'm closing this as WAD.

Thanks @justinwilaby for your answer.
But...is it an expected behavior on transcript mode? If the answer is positive, should I create another issue as a "feature request" to request this (very) useful feature?

@cytops Thanks for the suggestion. The current behavior is actually a limitation with the webchat component. We are discussing as a team how to proceed. We may end up tracking that work in the webchat project.


Crash when using PowerToys Run

Microsoft PowerToys version
<IP_ADDRESS>
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Invoke PT Run and type "terminal". Crashes when I get to "r".
✔ Expected Behavior
Show and filter suggestions without crashing
❌ Actual Behavior
Crashes and displays three (not sure if this means anything just yet) "Something went wrong." windows. I've attached the logs and bug report for this:
2021-05-20.txt
PowerToysReport_2021-05-20-09-54-22.zip
Other Software
No response

Hi @karanrajpal14
Thank you for reporting this.
Looks like a duplicate of https://github.com/microsoft/PowerToys/issues/9143
Can you try to disable the Windows Search plugin and check if the issue still occur?

Hello @davidegiacometti, thank you for pointing me to the issue. Disabling Search does resolve the issue and I've commented on the main issue that you mentioned hoping I can help resolve this. Is there anything else I can do to help?

Closing as duplicate of #9143


.

Challenge Change the Color of Text has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/601.7.7 (KHTML, like Gecko) Version/9.1.2 Safari/601.7.7.
Please describe how to reproduce this issue, and include links to screenshots if possible.

Thank you @irismdz I think I was confused on the switching of the blue and red texts.

Thanks for the report. The issue tracker is for reporting bugs only.
Please use the chat rooms:

HTML/CSS help chat room
JavaScript help chat room
Other Official Rooms

or try looking through our forum for help with a specific challenge.
Happy Coding!


Questions about 'SCCA_SCCA' function

Thank you for your code sharing! The data I'm analyzing now drives me to use sparse CCA. While I was reading 'SCCA_SCCA.m', some augments confused me:

Augment Spar1 and Spar2 were annotated as 'sparsity constraint', and '0.5' was set for both of them in the published paper (Ing, 2019). I'm wondering why is this and how to select these number according to different type of data;
Furthermore, I also a bit doubt the augment w1_sign and w2_sign, and expect some further explanation if it's convenient.
Looking forward to your reply!

Hi Faxin,
Thanks for your interest in the code.
First speaking very broadly for context: Spar 1 and Spar 2 are user defined hyper parameters. They are often set by grid search e.g. you could use 10 different values for Spar 1 and 10 for Spar 2, giving 100 possible choices, you could then select the hyper parameters that resulted in the highest correlation and use these. The best way to do this would be using some kind of cross-validation procedure. The crucial consideration here is to take appropriate steps to separate the hyper-parameter selection procedure from any statistical inferences you carry out on the data. This is exactly the same process that would be used to select hyper-parameters in e.g. a LASSO regression (see any introductory Machine Learning book for more information).
To be more specific about our choices here: We found that stability selection helped to produce more robust results (please see the paper referenced in our study for more details). As this procedure is reasonably insensitive to the L1 (here labelled Spar 1 and Spar 2 for data-views 1 and 2 respectively), you can just set the L1 value at a set level. Here, we selected 0.5 simply as this is the mid point of the regularisation path (i.e. mid way between 0 and 1). We then selected a conservative stability selection threshold of 0.9 (the higher end of what is recommended, again see the referenced paper for more details).
w1_sign and w2_sign are simply constraints you can put on the weights if you want them to be all positive or all negative. E.g. if you expect an inverse relation between two data-sets (as we did, expecting grey matter to be inversely associated with psychiatric symptoms), you can set one of them to positive (1) and one to negative (-1). If you do not have a hypothesis like this, just set them to 0.
I hope this helps?
All the best,
Alex

Hi Alex,
Thank you for your patient reply, that helps me a lot! (And sorry for my carelessness when I skimmed the method part, really missed so much useful information.)
And another tricky thing for me is that I'm now processing a subject-level time series data (i.e. the row of the dependent/independent data matrix is 'time point' rather than 'subject'). It seems impractical to use the cross-validation procedure as well as the stability selection procedure you mentioned, because it is unreasonable to resample. Thus wondering if there's any intuition on stability control of time series sCCA modeling?

HI Faxin,
Unfortunately, I am not aware of anything like that. Note that I am now closing this as an 'issue'. If you have further questions, please email me at<EMAIL_ADDRESS>and reserve this 'issues' section for any problems with the code.
Best
Alex

Get that, thank you anyway!


fix(block-storage): not able to change storage size

not able to change storage size using keyboard
This issue was in oui-numeric component. I have fixed the component and the fix is available in 3.5.1 release.  I have updated PCI with this release.
MBP-505

Even if this fixes the issue, it would be easier if the commit mentions the version bump instead imho

updated commit message


remove timestamp in java version

fixes: #275
Signed-off-by: Yixin Qian<EMAIL_ADDRESS>

FYI @llxia

Can we use removeTimestamp() function?


[WIP] Release version 0.7

Cleanup of warts I have encountered while trying to write a better example for the readme. #411 was a rather large diversion but I should be back on track now.

Btw, it might be worth looking at porting https://github.com/elm-tools/parser/ at some stage - seems to be a nicer approach than traditional parser combinators.

Btw, it might be worth looking at porting https://github.com/elm-tools/parser/ at some stage - seems to be a nicer approach than traditional parser combinators.

It has some good ideas to steal but also some issues so probably should port it straight up (remember looking at it a while back but can't remember where I wrote this down, delayedCommit is encourages inneficient code is one thing I believe).
It may also be worth rewriting the parser into CPS now that universal quantification is implemented as that is how both parsec and attoparsec are implemented.

This should be 0.7 🎉 . I had hoped to get this out with bit more of a bang but since I am not done with the post I was writing for this and we now enter the holidays I figure it will be better to wait with that until after new years instead (with a probable 0.7.1) and just publish this as is. Just one last nit on the language server then I am done.


SNS event's new SqsSubscription option does not follow recommended configuration

When setting SqsSubscription: true on an SNS event, SAM will put a queue without any properties set in front of the lambda function.
According to AWS docs, the VisibilityTimeout should be set to give lambda's retry logic a chance to retry twice before the message becomes available:
https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html

To allow your function time to process each batch of records, set the source queue's visibility timeout to at least 6 times the timeout that you configure on your function. The extra time allows for Lambda to retry if your function execution is throttled while your function is processing a previous batch.

Would also be nice if there were optional properties to build a redrivePolicy and a DLQ so messages don't retry relentlessly for 4 days.

@ljacobsson Thanks for bringing this up. The current SqsSubscription: true feature was part of the solution proposed in #854. There is additional work to do to support further configuration of SQS, but it should be tracked under that issue. You bring up a good point though that SAM should allow use cases where more advanced SQS queue configuration is needed. I'll update #854 with this additional requirement.


Trash (Demo) - Main menu broken up into blocks and shuffles around when mouse is moved

Describe the bug

Main menu and introduction splash screen is broken up into blocks and shuffles around when mouse is moved.
0.1.1
Nvidia GeForce RTX 3060 Laptop
531.79
Demo Version: 05Sep1, Internet Archive (download Trash_demo.exe)

Attach logs!

NvRemixBridge.log
d3d9.log
Trash_d3d9.log

To Reproduce
Steps to reproduce the behavior:

Start game.
Left-click past introduction splash screen.
Move mouse around screen.
See error.

Expected behavior
Main menu and introduction splash screen is not broken up into blocks and does not shuffle around at any point, regardless of mouse movement.
Screenshots

Note

Used dxWrapper as configured for D3D8 acquired from here (download dxwrapper_dx8.7z) to convert DX8 calls to DX9 calls suitable for the RTX Bridge.

Hello! Will you please test this on the latest release and let us know if the issue persists? Thank you!

This issue no longer occurs when using the release versions of dvk-remix a911c31-540 and bridge-remix-c062326-70 alongside using the version of D3D8to9 included with Remix 0.5.0.


Nested forms strange behavior

Summary:
I have found, that If modal located inside form and there is another form in modal, they behavior intersects. If I click on submit button in inner form - outer is submitted, if there are errors in inner form, onInvalid event handler of outer form is invoked. This is strange behavior, given that forms are not nested in result html.
Here is example - https://codesandbox.io/s/1qjlzm6k87. Open console to see logs.
Steps to reproduce:

click on submit button -> "invalid" in logs
open modal
click on submit button in modal -> "invalid" in logs, but no invalid handler on modal form
put something in input in modal and click on submit button -> "submit" in logs, but no submit handler on modal form

Expected behavior:
Forms work independently

Hi @ramusus. According to W3 - The form element:
4.10.3. The form element
....
Content model:
Flow content, but with no form element descendants.

It's seems that it's not a good idea to nest form elements, not sure why.

@diasbruno, forms are not nested in a result DOM, they are nested only in React component hierarchy.

Oh...Sorry about that. You are correct.
I think this is related to the propagation of synthetic events in react.
The form elements are on different nodes, but they have a direct path for the synthetic event propagation. I think this can explain why you are getting those logs.

@diasbruno you are right. I have added e.stopPropagation() to modal form handlers and behavior straightened up immediately. Here is updated example: https://codesandbox.io/s/9qmy6507vy
Thanks.


[RoboVM]Textures with MipMaps not drawn

It seems like using a MipMap TextureFilter with the RoboVM backend on IOS prevents the textures from being drawn on the screen. Instead black squares get rendered. Switching the filter to Linear or Nearest fixes the problem. I can only test this in the IPhoneSimulator on OS X, maybe its no issue with real devices.

I took the demo project supplied with the gdx-setup and added the TextureFilter to create a minimal example of the bug. You can download it here

How would we implement this if we are loading these with the asset manager (like suppose to load textures)?
The config option of specifying a mipmap doesn't work.
Example that works, but iOS is still blurry as hell.
param.genMipMaps = true;
    if(Gdx.app.getType() == com.badlogic.gdx.Application.ApplicationType.iOS){
        param.minFilter = Texture.TextureFilter.Linear;
        param.magFilter = Texture.TextureFilter.Linear;
    }
    else{
        param.minFilter = Texture.TextureFilter.MipMapLinearNearest;
        param.magFilter = Texture.TextureFilter.Nearest;
    }

    for(String eachTextureName : this.listOfTextureNames){
        this.assetManager.load(eachTextureName, Texture.class, param);
    }


feature(content-band-list-spacing-issue): Content band list spacing issue.

Issue
Fixes #MERATIVE-862
Description
When authoring the product family pages and adding the content band list with icons, there is no spacing/padding between the first and second row if more than three cards are added into this section.
Changed

Figma Link - https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=1459-14993&mode=design&t=BbstBwzZqcXHN2Aw-0

Test URLs

Before (Changes from main): https://main--merative2--hlxsites.hlx.page/merge-imaging
After (Changes from this PR): https://content-band-list-spacing-issue--merative2--nimithshetty17.hlx.page/merge-imaging

Testing Instruction
To test the content band list spacing and its responsiveness with respect to the design across all devices.

@sharathmrft - The mobile icon alignment issue is fixed.

@sharathmrft - Image alignment issue is fixed.

Checking the content band only, the watch video CTA play icon is wrong

Rest looks good to me.
@proeung @nimithshetty17 @sharathmrft


installation

hello, do i have to create a client id and secret for the plugin to let it work?

not at all

I added this text to my page "[github-issue username="MannusEtten" repository="BikeTouringGIS"]" and activate the plugin. But the result is that the plugin tells me "no issues".

Use github-issues :
[github-issues username="MannusEtten" repository="BikeTouringGIS"]
Single issue is fetch by ID like this :
[github-issue username="seinoxygen" repository="wp-github" number="14"]


Add function definition blocks

These blocks allow the creation of named lambda's (functions).

Test failure seems to be caused by Travis having a slightly outdated version of JavaFX which doesn't come with input dialogs.

Can we fix Travis? If so, please do.
Code seems fine, but please add the missing javadoc. Good job! :+1:

Thanks for taking a look. I've added some Javadoc.
There are a few ways to fix Travis:

Wait until Travis updates their Java 8 JRE to 8u40.
Force a Java update ourselves.
Write our own input dialog. (We already have our own message dialog in CustomAlert).
Find some library that does input dialogs and port our stuff to that library.
Use some sort of combination of Swing and JavaFX that would impress Dr. Frankenstein.

...but neither is quick or painless, I'm afraid.

Turns out option 2 is relatively painless, see https://github.com/travis-ci/travis-ci/issues/3259. Trying that now.

I think that the first option should be OK, maybe drop Travis a line?
I'll merge, thanks!


Resizing and readjusting of every components

give @Tushardeepak 25 points

Remove the debug.log file in the next commit.


Windows Executable Alpha

This only really supports SQLite, but will add some type of user/pass fields into gooey for pg and mysql

Also the output is garbage but whatever, there is a loading bar that makes it look like it hasn't frozen.


Update testify failures

Code Review
Testify (our testing framework) made some breaking changes and tests were showing failures of the form
0x0 != 0
0x7 != 7
0x5 != 5

and so on. This was caused by a type mismatch: int64 != int and so on. Fix these broken tests by adding explicit type annotations to our calls of assert.Equal()
Reviewers
@dustinhiatt-wf @tannermiller-wf @beaulyddon-wf @stevenosborne-wf @tylertreat-wf

+1

+1

+1

@dustinhiatt-wf are you okay with https://github.com/alexandercampbell-wf/go-datastructures/commit/6034e869e4d7795878f17314214fa1199ab17733 ?

@alexandercampbell-wf, yeah, going to get back and make the corrections not noted in the paper as soon as possible :).


fill sample_genotype_counts table

gemini stats --gts-by-sample CCGO.2016-12-09.db

Traceback (most recent call last):
  File "/usr/local/bin/gemini", line 6, in <module>
    gemini.gemini_main.main()
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/gemini/gemini_main.py", line 1227, in main
sample  num_hom_ref     num_het num_hom_alt     num_unknown     total
    args.func(parser, args)
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/gemini/gemini_main.py", line 573, in stats_fn
    gemini_stats.stats(parser, args)
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/gemini/gemini_stats.py", line 299, in stats
    get_gtcounts_by_sample(conn, metadata, args)
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/gemini/gemini_stats.py", line 250, in get_gtcounts_by_sample
    res = conn.execute(query)
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/sqlalchemy/orm/session.py", line 1034, in execute
    bind, close_with_result=True).execute(clause, params or {})
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 914, in execute
    return meth(self, multiparams, params)
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/sqlalchemy/sql/elements.py", line 323, in _execute_on_connection
    return connection._execute_clauseelement(self, multiparams, params)
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1010, in _execute_clauseelement
    compiled_sql, distilled_params
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1146, in _execute_context
    context)
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1341, in _handle_dbapi_exception
    exc_info
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/sqlalchemy/util/compat.py", line 202, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1139, in _execute_context
    context)
  File "/usr/local/share/gemini/anaconda/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 450, in do_execute
    cursor.execute(statement, parameters)
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such table: sample_genotype_counts [SQL: u'SELECT *,              (num_hom_ref + num_het + num_hom_alt + num_unknown) as total              FROM sample_genotype_counts']

I find this useful to get a rough overview of variants called for each sample. Occasionally a weird samples gets through QC which has too many or too few variants.

did you load this with vcf2db?

Oh, yes I did.

... oh, I assume so since you opened on this repo.

ok. that should be fairly straightforward to add. I might not get to it right away.

cool, thanks

this if fixed in master


Inspect Back2Work feed

http://5by5.tv/b2w
is malformed

the Back To Work feed presents it's character encoding wrongly, and therefore causes feedparser to throw an exception.


Change docs generate in tox file to use python3.5

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


[Bug] Linechart with multiple series using dataset only renders the total amount of points of the first series

Version
5.5.1
Link to Minimal Reproduction
https://echarts.apache.org/examples/en/editor.html?c=line-simple&version=5.5.1&code=PYBwLglsB2AEC8sDeAoWsAmBDMWDOApmAFzJrqx7ACuATgMYGmoUUYCMpA2uwDQBMAXV7lWGftwAsA4aIoB6eR259-vAMyzW6ReKkDeANi3aM67gFYjvAOwmxk_QE4ZcgL7k3I9AA8Agj4QeMxyYACeIEywAOQAblgANtQE0d4UeAAWwADupGC0yZ5pYQFBIazhkaRxicmpcpk5eQUEReSEtBAEwbBccizaBND0wBhRA9qwPtUc9ZPoYTP80XLoXquwlVHRCRDQKe5p6BMUQyNj5fPTMWZz84s3kiuT65Nb1bv7zxQe6CZgwGACUgIEu6EauU2LTa6CwnSwYNgQywACMEgQMM1CmsUG4ANxAA
Steps to Reproduce
The issue can be seen in the Minimal Reproduction Link.
Current Behavior

I have a linechart with two series.
Series 1 has 2 data and series 2 has 3 data.
The data are declared in datasets like the following:

dataset: {
source: {
d1: [1,2],
d2: [4,2],
d3: [5,6,7],
d4: [4,9,2]
}
}

Series 1 will take in d1 and d2 using encode:

encode: {
x: 'd1',
y: 'd2'
}

Series 2 will task in d3 and d4 using encode:

encode: {
x: 'd3',
y: 'd4'
}

When rendered, it only display a total of 2 data for both series. Series 2 is missing the last data which is (7,2).

Expected Behavior
Expected result:
Series 1 to display 2 data: (1,4) and (2,2)
Series 2 to display 3 data: (5,4), (6,9), and (7,2)
Environment
- OS:MacOS
- Browser:Google Chrome
- Framework:

Any additional comments?
No response

dataset defines rows and columns which implies that it is a rectangular matrix. Your matrix is not rectangular hence the problem. Solution is to fill missing values with null:
      d1: [1,2,null],
      d2: [4,2,null],

📌 please close issue if problem solved.

Thank you!


Fix shared build

Fixes https://github.com/google/cpu_features/issues/108

also related to #108 we should add CMP0077
At the beginning of the file:
# option() honors normal variables.
# see: https://cmake.org/cmake/help/git-stage/policy/CMP0077.html
if(POLICY CMP0077)
  cmake_policy(SET CMP0077 NEW)
endif()


Use _ret variants of mbedtls functions introduced in 2.7.0

Change mbedtls_sha256_update and mbedtls_sha256_finish to mbedtls_sha256_update_ret and mbedtls_sha256_finish_ret, respectively. the non-_ret versions were depreciated in 2.7.0 according to the documentation.
I get a error: void value not ignored as it ought to be when trying to compile with the deprecated functions. Switching to the _ret versions fixed this for me.

Hi @atfox98! Thanks for the contribution. Beginning with MbedTLS v3.0.0, the variants of those functions that return void were removed and subsequently the variants that return an integer value were renamed to remove the _ret suffix. We recommend updating MbedTLS in your system to the latest version.
Our first-party ports to ESP-IDF and Zephyr are both using MbedTLS v3.6, the latest version. In reviewing this change, we've determined that these specific hashing functions should be part of the platform port rather than making the assumption that all ports that use FreeRTOS are also using MbedTLS. That should make it easier for you to override the hashing functions in your custom port, although we still recommend updating to the latest version of MbedTLS to ensure you have the latest safety and security enhancements.
Because our supported ports are using the latest version of MbedTLS, we'll be closing this Pull Request, but please post on our Forum if you have any further questions or need assistance with anything!


Updated HEVC support status to make it more accurate

Actually macOS and Android also bundled a software decoder, on these platforms, as long as the system version meets the requirements, all devices will support it.
Linux and ChromeOS's support is very limited, since Chromium currently only support VAAPI for HEVC.

Thanks!


Fixed typo on For Users > Download page

Within the OS X section, I changed Offical to Official.

Thanks @jasonferrier


(FACT-1494) facter.conf with external-dir and custom-dir

Acceptance test for default facter.conf file having external-dir and custom-dir defined.
This PR to ensure that facter will search for external facts and custom facts
in the directory paths defined with external-dir as an array of paths and custome-dir as a single path in the facter.conf file
Default path for facter.conf:

on *nix: /etc/puppetlabs/facter/facter.conf
on Windows version older than 6.0: C:\Documents and Settings\All Users\Application Data\PuppetLabs\facter\facter.conf
on Windows version is 6.0 or newer: C:\ProgramData\PuppetLabs\facter\facter.conf

[skip ci]

CLA signed by all contributors.

Two more nits:
To spare travis/appveyor bandwidth, can you include [skip ci] in the commit message body for changes to acceptance (which are a no-op for what travis/appveyor actually test on this repo)

https://docs.travis-ci.com/user/customizing-the-build#Skipping-a-build
https://www.appveyor.com/docs/how-to/filtering-commits/#skip-directive-in-commit-message

Can you put the commit message in the imperative, e.g. as discussed here https://github.com/puppetlabs/facter/blob/master/CONTRIBUTING.md
Thanks!

Thanks @kylog , I added [skip ci] in the commit message body

All of this functionality already has tests written for it, though they are more broken up (see default file location, custom dir, and external dir). The duplication seems unnecessary to me. Since Phong's tests are more concise, maybe we should use this file and remove the other three.

Though come to think of it, that will remove the tests for the disable options (no-external-facts and no-custom-facts). @phongdly do you feel like those tests have a place in this one you've written, or should they be covered elsewhere?

@Magisus thanks for the review. I think we should keep those existing tests because as you mentioned about the tests for disable options, and I might be wrong but they are a little bit different from the test in this PR.
[default file location] (https://github.com/puppetlabs/facter/blob/master/acceptance/tests/options/config_file/default_file_location.rb) verify facter.conf is loaded as default but does not test it with external-dir and custom-dir paths.
custom dir, and [external dir] (https://github.com/puppetlabs/facter/blob/master/acceptance/tests/options/config_file/external_facts.rb) test the custom and external facts when facter is used with --config flag.
This PR is to test facter will search external and custom facts in the paths provided in facter.conf  and when facter is used without --config flag

Arguably we should refactor all the existing config file tests to use the default location. The only reason they currently don't use it is because that functionality didn't work on all platforms when those tests were written. That refactor, in combination with a test in the command line section that verifies the functionality of the --config flag, would make more sense than what we currently have and be a lot cleaner than all these kind-of-overlapping tests.
As a side note: was this ticket (FACT-1494) intended to be a follow up to FACT-1460 which causes the config file to be loaded when Facter is called from Ruby? I only ask because this test deals with pieces of that functionality without actually testing the "loading from Ruby" bit. We currently don't have any tests for that behavior, which is kind of scary because that's the part that will impact Puppet.
So if possible, I would be in favor of repurposing THIS test verify that the config file is respected when calling Facter from Ruby, refactoring the existing tests to use the default location, and adding a separate test for the --config flag. Since that's kind of a lot of things, I'd also volunteer to do it, if QA has better things to do :P
Short of that, I think the test itself looks fine :)

@Magisus sounds great if we can also cover the  'loading from Ruby' testing in this test.

This appears to be have been pulled into another PR that I merged. Can I close this one?

Yes I incorporated this into my refactor. I'll close this.


Admin fixes

token service can now handle user deletation requested by admin user

user role is now included in the user jwt

settings page is now hidden from header if user is non-admin
user management page shows "Not authorized", if non-admin user is attempting to access the page by direct url
attempted to fix flakyness of "reset file" test by slightly increasing the wait when reset button is pressed
some comment clean up done

Token service throws "Error fetching refresh token", when user connects to Gitlab and attempts to view repos in Repositories page.

Refresh token error above was fixed locally by updating .env-variables. Remotely should be ok!

Looks good, nice job


Setting up an environment for Python 3

Proposed title of the article
Setting up an environment for Python 3
Introduction paragraph (2-3 paragraphs):
When dealing with any programming language, the first step is to create an environment that will allow you to run your code. You may examine your work for syntax errors through a well environment. In addition to Python 3, you'll need an interpreter to translate your code to a machine-readable language for execution.
The environment paths on Windows, Mac OS, and Linux are all distinct. The environment for python 3 code execution should be compatible with the device operating system. This article will provide programmers with basic knowledge that will enable them to obtain the necessary software to run the codes on a new device.
Key takeaways:

Local environment setup
Getting python
Setting up python
Running python

References:
N/A

@Muchiri021
Good afternoon and thank you for submitting your article for publishing.
Your article has been entered into our queue and should be reviewed (and published pending any changes) as soon as a peer reviewer is finished with the ones in the queue before it. 🚀
Thank you.

Good evening @Muchiri021. Thank you for submitting the topic suggestion form. This topic has been covered in this article. I encourage you to submit another issue. I will be closing this issue for now. Thank you.
Lalith


Add theme method for separatorColor

Removes static defaultSeparatorColor and use separatorColor from theme.

Thank you!! :+1:


Walking Skeleton:

dotnet new console -n EchoServer
dotnet new xunit -n EchoServer.Tests
added .gitignore
updated README

Renamed repo and had to close this PR and open a new one


Uplaod the pytorch models in Google Drive

I do not have access to baidu pan website , can somebody plz uplaod this models on Google Drive

https://drive.google.com/drive/folders/13gHnD71800HjtVrRnHvCHLzEj6sWXMNo?usp=sharing

@shanudhawale
https://drive.google.com/drive/folders/13gHnD71800HjtVrRnHvCHLzEj6sWXMNo?usp=sharing


Automated Package Upgrade

:tada: This PR is included in version 25.5.34 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚠ Bofrost.at has degraded performance

In f38d55a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1777 ms

Resolved: Bofrost.at performance has improved in 66c1edb after 6 minutes.


How to use?

I'm not sure how to use this in my addons. For example, I have ember-sinon-qunit, which depends on ember-sinon, which has imports that need to execute on the app. However, I can't seem to figure out where/how to include this addon to make sure that all apps consuming ember-sinon-qunit will have ember-sinon's index.js execute properly.

Add this as a dependency. That is all you should need to do.

@rwjblue do I call this.import instead of app.import now? I'm not sure how to trigger the new prototype method.
For example, trying this threw an error that this.import didn't exist:
included: function (app) {
    this._super.included.apply(this, arguments);
    this.import('vendor/ember-sinon/shim.js', {
      type: 'test',
      exports: { 'sinon': ['default'] }
    });
  }

You may have to list the polyfill as a 'before' in your package.json to ensure it is loaded first.

err don't you mean after? I thought addons listed as after specified all addons that must run before your addon can run

Optionally, you may specify whether your ember-addon must run "before" or "after" any other Ember CLI addons.

I also have issues using this.
I have an engine addon running Ember 2.6 that is dependent on another regular addon, lets say AddonB [also 2.6]. AddonB uses app.import, so when I run my engine I get an error TypeError: Cannot read property 'import' of undefined. This is pointing to the index.js file of AddonB where a app.import call is being made for a bower dependency.
I tried installing the polyfill in AddonB and in my engine and changed the call in AddonB to this.import but it still didn't work.

Unless you're using ember-cli 2.7.0, you must install the polyfill for your app, even if the add-ons already have it.
This is because the code in the add-ons is run with the models from the app.
If it doesn't work, it would be great to have a repo that reproduces the issue.

@xcambar Yes I have installed the polyfill in my engine as well. The engine here is consuming the addon that has the import statement in its index.js.
I dont have a small repo for this right now...working on an internal company project.
@elwayman02 Did you manage to get this working by any chance?

The polyfill is intended for apps with ember-cli older than 2.7.
The whole point of the polyfill was making it so we don't need to make changes in a lot of addons. Addons do not need the polyfill. Addon authors should be telling users to upgrade to ember-cli 2.7 or install the polyfill.

ok based on this I just upgraded my consuming engine to ember-cli 2.7 and left all addons as is.
I am consuming ember-perfectscroll as a dependency. It is now giving me an error -
The Broccoli Plugin: [SourceMapConcat: Concat: Vendor /assets/vendor.js] failed with:
Error: ENOENT: no such file or directory, stat '/Users/rpanthak/git_workspace/ciena-uac-engine/tmp/source_map_concat-input_base_path-JMJjNLkd.tmp/0/undefined/perfect-scrollbar/js/perfect-scrollbar.js'

Which seems like its due to app.bowerDirectory not being found? https://github.com/imanhodjaev/ember-perfect-scroll/blob/master/index.js#L17

ok I had to add another if block guard inside an addon that was pulling in perfectscroll to get it to all be happy, which doesn't seem very clean -
if (typeof app.import === 'function' && app.bowerDirectory) {
    this.import(app.bowerDirectory + '/perfect-scrollbar/js/perfect-scrollbar.js')
    this.import(app.bowerDirectory + '/perfect-scrollbar/css/perfect-scrollbar.css')
  }

@rox163 you're right, this change didn't account for bowerDirectory. There is some discussion about fixing that too. https://github.com/ember-cli/ember-cli/pull/6111

Thanks. Looking forward to seeing the RFC for this.

@rox163 @ef4 See the RFC here: https://github.com/ember-cli/rfcs/pull/63


TypeScript: Refactor BFast to use Fetch and Stream API

TODO

[ ] Consume VIM file HTTP stream using the Fetch API

https://developer.mozilla.org/en-US/docs/Web/API/Streams_API/Using_readable_streams

[ ] Unblock the 2GB VIM file loading issue: https://vimdevelopment01storage.blob.core.windows.net/snapshots/V1281-SkanskaTower-R20.vim

Possibly do this in the context of .vimx


how to change text color in android

By default the text color is black and the black color does not blend with my background nor colors for my app


Graph nodes flocking to single point

Description
Nodes in graphs are shown correctly for a second before flocking to a single point, usually happens when inserting Cyto-components using callbacks. It is independent of any particular layout. This happens often.
Looks like this:

Steps/Code to Reproduce
Not deterministic. Happens when having multiple graphs, shown at different times in the Dash app.
Expected Results
A graph with properly placed nodes.
Actual Results
This.

Versions
Dash 2.3.1
/Users/niels/Documents/GitHub/test/test.py:3: UserWarning:
The dash_html_components package is deprecated. Please replace
`import dash_html_components as html` with `from dash import html`
  import dash_html_components; print("Dash Core Components", dash_html_components.__version__)
Dash Core Components 2.0.2
/Users/niels/Documents/GitHub/test/test.py:4: UserWarning:
The dash_core_components package is deprecated. Please replace
`import dash_core_components as dcc` with `from dash import dcc`
  import dash_core_components; print("Dash HTML Components", dash_core_components.__version__)
Dash HTML Components 2.3.0
Dash Renderer 1.9.1
Dash HTML Components 0.2.0

This even happens in the examples in the documentation.

I have not yet looked into any of the code in this repo, but investigating from the outside; I have been able to stop this behaviour by disabling updating of Cyto-components from callbacks. This is not sustainable.

Furthermore, it happens in Safari, Chrome and Firefox - both when hosted locally and in a pod.


Problems with ESM and electron

Hello,
I'm using p-waterfall within electron (Typescript project). With p-waterfall v2.1.1 everything works fine. When I upgrade to v3.0.0 I get the following error:
"require() of ES modules is not supported"

https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
You should probably stay on the previous version until Electron support for ESM improves.


Section on deailing with extracts and data products

From Mikel:
I'd also add a section to dealing with extracts and data products ... ie finding stuff on GeoFabrik, using Overpass Turbo.
Reference: http://lists.openstreetmap.org/pipermail/hot/2013-July/003370.html

Oldie but goodie!
Good stuff @maning. This could use a refresh, now that there's a HOT export tool relaunch. And Overpass Turbo is a key tool to include too.
What do you think @russdeffner? Someone on the Training Working Group willing to help with this?

There's actually already great stuff here to point to for Overpass
https://www.mapbox.com/guides/overpass-turbo/

Yes, I think we should look at expanding and/or combining http://learnosm.org/en/osm-data/getting-data/ and http://learnosm.org/en/osm-data/geofabrik-and-hot-export and include information on Overpass and maybe other export/extracts like Garmin, etc.


PR for issue #52 - part 2

Support for mixed-endian operations.

My comments:
Adding the section "Endianness of in-memory data structures" is fine, but I think it's still helpful to keep the text elsewhere that says

The byte order of each of the doublewords in memory, little-endian or big-endian, is the endianness as determined by ___.

In the new section "Endianness of in-memory data structures", I fear the second paragraph that starts "The byte order of each double word in memory, ..." sounds initially like it's talking about every doubleword of memory in the address space, because it follows a paragraph that was talking about the entire address space.  Maybe the transition would be clearer as, "For the IOMMU's in-memory data structures, the byte order of each doubleword, ..."
Otherwise, I'm okay with the PR.

Approved by IOMMU TG - 10/6/2022


Compression video manual: not doing anything

Current behavior
When I compress video in 'auto', it does work pretty well.
HOWEVER, since the 'auto' only gets triggered with file >16Mb, I had to go the 'manual' way.
But unfortunately, WHATEVER parameters I put, I see the compress being triggered and the progress value moving up to 100%; BUT the resulting file is literally the SAME size as the original one.
I really don't understand why?
Expected behavior
Platform

[X] Android

React Native Version
0.66.0
React Native Compressor Version
1.5.2
Reproducible Steps And Demo
Use any parameters in manual, and the result file is literally the same size as original in spite of progress showing something is happening.
await VideoCompressor.compress(path, {
        compressionMethod: 'manual',
        maxSize: 640,
        minimumFileSizeForCompress: 1,
        bitrate: 200000 // whatever I put here is not changing, like the above. Only parameter working is minimumFileSizeForCompress it seems
      },

There are 3 issues on android which prevent the video compression.
1 : The bitrate variable is not passed down to native module (no bitrate switch case) => here
Fix
        case "bitrate":
          options.bitrate = (float) map.getDouble(key);
          break

2 : MaxSize is just not used as parameter => here
Fix
int maxSize = (int) options.maxSize

3 : It goes down to VideoCompressor library => here
This condition does not compress video if dimensions haven't changed. So it's not possible to just reduce bitrate without changing dimensions of the video. Unless removing this condition.
Fix => remove the condition

That's awesome, thank you for your investigation @nikonhub !
I such with Github unfortunately; contributors @numandev1 any way you could merge the change above?
That would be great!

@pierroo did you manage to solve the issue?

@RAIERIN unfortunately not, I forgot videos entirely because of this issue.
I guess you might be able to patch-package the library here applying the fix from nikonhub above, although I haven't tried it myself.

@pierroo auto get triggered with file >16Mb but we can change it to > 0mb by adding minimumFileSizeForCompress:0
Note: in next version, i am adding minimumFileSizeForCompress:0 by default


[4.6]CLOUDSTACK-8912: Fixed listGuestOsMapping doesn't list by id or ostypeid.

How to test:

Try to listGuestOsMapping by id -> should return the correct entry.
Try to listGuestOsMapping by ostypeid -> should return the correct entry.

LGTM

@borisroman Can you rebase against current master? Then we can run some tests. Thanks!

@remibergsma Done.

Thanks @borisroman I'll run soms tests today.

@borisroman,
Is this PR intended to fix the ordering of the response of listGuestOsMappingCommand?
I did not see where you changed the ordering on the SC used. Looking at the changed files list, I just see you changing types from Long to String.
I noticed that the order by is done in ascending order, using the field “hypervisorType”, is “hypervisorType” that same as “ostypeid”? Moreover, I could not find a field called “ostypeid”.
Interesting that the filtering and the order by was already there, this PR seems to be related to something else.Is it really a problem to let those field as they are (Long types)?

why not add 'uuid' column in guest_os_type table?

I tested this api just now,
It works fine.


cmd/vet: check for improper use of t.Run and t.Parallel

Consider the following test:
func Test(t *testing.T) {
	for _, name := range []string{"foo", "bar", "baz"} {
		data := name // This line is necessary
		t.Run(name, func(t *testing.T) {
			t.Parallel()
			t.Log(data)
		})
	}
}

Without the name := name line to capture the name variable, the subtest will execute with the wrong values as the testdata. Worst yet, the tests will run with the correct names, but the wrong data, completely misleading the user that the test is executing as expected.
The blog on subtests explicitly warns that this must be done:

Note that we need to capture the range variable to ensure that tc gets bound to the correct instance.

I propose that vet check for this mis-use. One possible algorithm:

If t.Parallel is called within a t.Run
and the body of t.Run following the t.Parallel references a variable scoped to the range of some outer loop (i.e., not captured)
then flag as potential issue.

\cc @dominikh

What is the frequency with which this occurs?

this is just one possible manifest of
https://golang.org/doc/faq#closures_and_goroutines. If we can do a generic
vet check for all occurrences, then it's fine. But I don't think checking
only this single case is appropriate.

For the record it just happened to us at Social Point. Maybe a rule in https://github.com/dominikh/go-staticcheck would make it too if in vet is not possible. cc/ @dominikh

#16520 is the generalization of this. This is marked as NeedsDecision but really it needs a concrete proposal of what gets checked and how, and an argument for why that will have approximately no false positives.

Just found this via search. For the record, this landed as #55972.


.github/workflows/ci-sage.yml: New

This adds integration testing with SageMath, on several Linux distributions with a wide range of versions of GNU make.
Preview of the workflow run: https://github.com/mkoeppe/gnumake-tokenpool/actions/workflows/ci-sage.yml

no, 4x 1 hour is too much
to compare py/test/test.sh takes 20 seconds

Sure, I'll reduce it

please avoid integration tests
synthetic tests that run few seconds are enough
were just reading/writing some bytes between pipes
and the few edge cases can be simulated


Missing dependency on xutils-dev

Attempting to build on Ubuntu 14.04, I ran into the following failure when building libdrm:
arm@chrome~/tegra-nouveau-rootfs$ ./scripts/build-drm
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4 ${ACLOCAL_FLAGS}
configure.ac:33: error: must install xorg-macros 1.12 or later before running autoconf/autogen
configure.ac:33: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: echo failed with exit status: 1
autoreconf: aclocal failed with exit status: 1

Running sudo apt-get install xutils-dev fixes the issue.  This should be in the list of prereqs.

Fixed that, thanks!


Can't use -log and --config together

Reproduce:
mupx logs -f  --config=mup-dev.json
Meteor Up: Production Quality Meteor Deployments
------------------------------------------------
Using custom configuration/settings file
Configuration file : mup-dev.json
Settings file      : settings.json

[<IP_ADDRESS>] flag provided but not defined: --config
[<IP_ADDRESS>] See 'docker logs --help'.

As a workaround for this, I added an npm script to my package.json:
{
   "scripts": {
       "logs": "ssh USER@HOST -i PRIVATE_KEY \"docker logs -f \\`docker ps -a | grep APPLICATION_NAME |  awk '{print \\$1}'\\`\"",
   }
}

so you can tail logs using npm run logs.
Just replace the variables in CAPS with your values.


Creating a new widget page (in addition to home page)

I would like to add a new widget page to my Academic themed site.
For example: I'd like to keep the default home page, but have a separate CV page where each widget is a part of a CV (education, past institutions, publications, etc.).
My attempt:
I have created a content\CV\_index.md file and a corresponding layouts\CV\list.html file with the following content:
{{ partial "new_widget_page.html" . }}

The corresponding layouts\partials\new_widget_page.html is a copy of \themes\academic\layouts\partials\widget_page.html, but now I'd like to modify it so that it runs over a separate set of widgets that should not appear on the homepage.
I know that most of the work is in this block of code:
{{ range $index, $page := where (where .Data.Pages "Section" $section) ".Params.active" "!=" false }}
  {{ $params := dict "root" $ "page" $page }}
  {{ $widget := printf "widgets/%s.html" ( or $page.Params.widget "custom" ) }}

      {{ partial $widget $params }}

{{ end }}

Unfortunately I'm trying to figure out how to modify this so that this runs over a "CV only" set of widgets. For now each of these widgets can be generic custom widgets, but eventually I'd like to be able to make new widget layouts for this CV page.
Apologies for the newbie question---thank you very much for this theme and for the discussions, I have been learning a lot by playing with it.

There is no need to code your own widget page, the feature already exists and is documented here: https://sourcethemes.com/academic/docs/managing-content/#create-a-widget-page

Thank you---I'd completely missed that part of the documents.

There is no need to code your own widget page, the feature already exists and is documented here: https://sourcethemes.com/academic/docs/managing-content/#create-a-widget-page

The webpage linked is no longer available. Is there an equivalent page in the new documentation with Wowchemy? Thanks!

There is no need to code your own widget page, the feature already exists and is documented here: https://sourcethemes.com/academic/docs/managing-content/#create-a-widget-page

The webpage linked is no longer available. Is there an equivalent page in the new documentation with Wowchemy? Thanks!

https://wowchemy.com/docs/content/landing-pages/
Rodrigo Alcaraz de la Osa
https://rodrigoalcarazdelaosa.me/

El 28 ene 2021, a las 16:57, Orr Paradise<EMAIL_ADDRESS>escribió:

There is no need to code your own widget page, the feature already exists and is documented here: https://sourcethemes.com/academic/docs/managing-content/#create-a-widget-page
The webpage linked is no longer available. Is there an equivalent page in the new documentation with Wowchemy? Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

https://wowchemy.com/docs/content/landing-pages/
Rodrigo Alcaraz de la Osa
https://rodrigoalcarazdelaosa.me/

El 28 ene 2021, a las 16:57, Orr Paradise<EMAIL_ADDRESS>escribió:

There is no need to code your own widget page, the feature already exists and is documented here: https://sourcethemes.com/academic/docs/managing-content/#create-a-widget-page
The webpage linked is no longer available. Is there an equivalent page in the new documentation with Wowchemy? Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Style/RedundantRegexpCharacterClass wrong suggestion on v0.93.0+

There was introduced a little bug on v0.93.0 that it is suggesting wrong auto-corrections on certain regex scenarios even when using rubocop -a (safe auto-correct).
[Corrected] Style/RedundantRegexpCharacterClass: Redundant single-element character class, [\-]{1} can be replaced with \-]{1.
            format: { with: /\A[a-z0-9]+([\-]{1}[a-z0-9]+)*\z/, message: I18n.t('alias.is_invalid') }
                                         ^^^^^^^

Steps to reproduce the problem
Environment
$ ruby -v
ruby 2.6.6p146 (2020-03-31 revision 67876) [x86_64-darwin19]
$ ls
$ echo 'regex = /\A[a-z0-9]+([\-]{1}[a-z0-9]+)*\z/' > test.rb
$ ls
test.rb

v0.92.0 (working fine)
$ ls
test.rb
$ gem install rubocop -v 0.92.0
Fetching rubocop-0.92.0.gem
Successfully installed rubocop-0.92.0
Parsing documentation for rubocop-0.92.0
Installing ri documentation for rubocop-0.92.0
Done installing documentation for rubocop after 9 seconds
1 gem installed

$ rubocop --only Style/RedundantRegexpCharacterClass
Inspecting 1 file
C

Offenses:

test.rb:1:22: C: Style/RedundantRegexpCharacterClass: Redundant single-element character class, [\-] can be replaced with \-.
regex = /\A[a-z0-9]+([\-]{1}[a-z0-9]+)*\z/
                     ^^^^

1 file inspected, 1 offense detected, 1 offense auto-correctable

v0.93.0 (bug)
$ ls
test.rb
$ gem install rubocop -v 0.93.0
Fetching rubocop-0.93.0.gem
Successfully installed rubocop-0.93.0
Parsing documentation for rubocop-0.93.0
Installing ri documentation for rubocop-0.93.0
Done installing documentation for rubocop after 9 seconds
1 gem installed

$ rubocop --only Style/RedundantRegexpCharacterClass
Inspecting 1 file
C

Offenses:

test.rb:1:22: C: Style/RedundantRegexpCharacterClass: Redundant single-element character class, [\-]{1} can be replaced with \-]{1.
regex = /\A[a-z0-9]+([\-]{1}[a-z0-9]+)*\z/
                     ^^^^^^^

1 file inspected, 1 offense detected, 1 offense auto-correctable

RuboCop version
$ rubocop -V
0.93.0 (using Parser <IP_ADDRESS>, rubocop-ast 1.0.0, running on ruby 2.6.6 x86_64-darwin19)

The bug seems to be introduced when the cop was updated to use regexp_parser (PR https://github.com/rubocop-hq/rubocop/pull/8625).

Hi @cetinajero - thanks for the report, and apologies for the bug. I think this will be fixed by #8913

Great to know there is already an in-progress PR @owst!

#8913 has been merged and released with the latest RuboCop. Thank you.


Removed parentheses from the titles

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Minor text changes

This contains all of the latest content changes for the June 8 content review.


Photos overflow in feed

Android only.

fixed for now by just cropping same as ios https://github.com/textileio/textile-mobile/pull/980


Detect if the browser supports pthreads to pick the most suitable execution mode

Hi. A feature request. Add the ability to create a lovejs bundle which would contain both the pthread version and the compatibility version, and at the beginning of the execution, it'd detect if your browser supports pthreads in order to pick the best version.

I've looked around. I don't know if it's relevant here, but I've found this: https://github.com/whatwg/html/issues/4732
Some people suggest ways to detect SharedArrayBuffer support, but I'm not even sure that it's the same as pthread support.

https://github.com/whatwg/html/issues/4732#issuecomment-589255468
https://github.com/whatwg/html/issues/4732#issuecomment-598470434

If that is not useful, here's another idea: maybe it'd be simpler to just call some dummy pthread init code on startup to know right away if it's supported or not by the browser, so you don't have to bother trying to catch exceptions that might arise later while playing the game.

window.SharedArrayBuffer === undefined does seem to coincide with browsers where the compat version is required in my limited testing. Seems like a good enough heuristic. I'd want to fall back to compat aggressively to ensure things run.


[sbt 1.0] Add first round of DSL checks to sbt

This pull request adds the necessary infrastructure to run sbt checks.  The
purpose of the PR is to allow sbt to prohibit DSL usages that are dangerous and
yield unexpected results.  One of these cases is the use of value inside if
expressions (though there are more).
This will make it easier both to learn sbt and to use it. I am very optimistic
about the result of these changes in the close future.
For the review, I suggest having a look at the independent commits to get an
idea of what I am doing in every one of them.

The error messages are inspired by those of Rust and those of Dotty.
In the future, for sbt DSL checks that are warnings and not errors, I'd like to add a showError $ERROR_ID where $ERROR_ID corresponds to an identifier shown in the message that elaborates on the reported error, the consequences, et cetera.

An example of the sbt check:

So, after I have implemented the first two checks, I want to give a summary of what this PR is about.
I feel that sbt authors have a hard time writing sbt code because it's not predictable -- sometimes it does not behave like Scala code.
These checks are the first step to disallow dangerous code that misbehaves. The most common scenario is the use of a task invocation inside the body of an if expression. People may think the task in the body won't be executed if the predicate is false, but this is not the case -- sbt macros hoist up that value and evalute the task no matter what the if predicate is.
In order to address this issue, I think it's utterly important to give good feedback and explain sbt users in the spot why that construct is dangerous. This is also a good time to familiarize with the most complicated parts of sbt.
Feedback on the error message format is very much welcome.

given all the ways not to get a conditional task execution right, the "use a dynamic task" warrants a link to a more detailed explanation.
(tell me where to put it and I'll make a PR for the doc)

given all the ways not to get a conditional task execution right, the "use a dynamic task" warrants a link to a more detailed explanation.
(tell me where to put it and I'll make a PR for the doc)

Totally agreed. There are several ways we could improve this. I would like to give every error an identifier, and then allow users to browse a full explanation of everything via help. Then we can cross-link between error messages.
@jastice As this is not high priority, I suggest that we synchronize on an issue on the best ways to do so before the RC1.

Merged! Thanks for the contribution.

Thanks @eed3si9n.

Is the error here accurate? Are you not preventing the behavior that the error claims will happen with the error? Would it not be more accurate to say "regular tasks cannot conditionally depend on other tasks"?

Wonderful idea, by the way

Is the error here accurate? Are you not preventing the behavior that the error claims will happen with the error? Would it not be more accurate to say "regular tasks cannot conditionally depend on other tasks"?

Which error do you mean? :smile:

Sorry! The one that's called out in the screenshot:
It states that "Regular tasks always evaluate task inside the bodies of if expressions", which has historically been true. However: The fact that a check for this is being added means that this is no longer true, I would think. Regular tasks won't evaluate tasks inside the bodies of ifs because (due to this patch) putting a call to .value inside of an if is now disallowed, right?

Ah! @clhodapp I see what you mean.
Yes, you're right! The reason why we still tell users that is because users can bypass this check with @sbtUnchecked. So they can do something like:
if (condition) foo.value: @sbtUnchecked
else ""

Another reason why that error message is useful is because it helps sbt users realise what and why they were doing wrong. If someone migrates to 1.0 and all of a sudden gets that message, he'll get a good reason why the previous code was rejected.
@clhodapp I'm totally open to change the error message, what do you think would be a better wording? As a user, what would you like to see?

Hrm, I feel like it's kind of weird to allow it at all (even with @sbtUnchecked) but I understand now that the intent with this change is not to prevent things that we don't like from being possible but rather to make sure that users know and have opted into confusing behaviors. Given that, the only changes I would make would be to word things a bit more strongly and to tell the user how to make the error go away. More like "You should generally not do this because it is confusing. If you want to do it anyway, you'll need to add @sbtUnchecked".
Perhaps:
s"""${startBold}The evaluation of `$task` happens always inside a regular task.$reset
   |
   |${ProblemHeader}: `$task` is inside the if expression of a regular task.
   |  Regular tasks always evaluate calls to `.value` inside both the branches of `if` expressions, regardless.
   |  of whether the predicate is true or false. Because this can cause confusion, calling `.value` on tasks
   |  inside of `if` branches has been disabled by default.
   |
   |${SolutionHeader}:
   |  1. If you only want to evaluate it when the if predicate is true or false, use a dynamic task.
   |  2. If you are fine with `$task` being evaluated regardless of the value of the predicate, you can make this
   |     explicit by evaluating `$task` outside the `if` expression and assigning the result to a `val`.
   |     For example, you could write `val result = $task.value; if (condition) result else ""`.
   |  3. If you understand the evaluation model and would like sbt to simply allow you to call `.value` inside
   |     of the `if` branch, you can also annotate your call to `.value` with `@sbtUnchecked`. For example, you
   |     could write `if (condition) $task.value: @sbtUnchecked else ""`. Be aware that this may be confusing
   |     for others who try to read your build definition.

""".stripMargin

Note: I edited my last comment so if you are reading it in an email, you'll have to come over to GitHub to see the updated text. Sorry!

Hrm, I feel like it's kind of weird to allow it at all (even with @sbtUnchecked) but I understand now that the intent with this change is not to prevent things that we don't like from being possible but rather to make sure that users know and have opted into confusing behaviors.

There are two reasons what explain the existence of @sbtUnchecked:

We, the developers of sbt, may have missed valid use case scenarios.
Or there's a regression in the DSL linter and valid code is recognised as invalid. To avoid keeping users awaiting a new sbt release to fix their builds, the annotation helps them continue with their life.

That being said, I really like the problem statement that you've done. Thank you, I will update this message before RC1! :smile:.
The only thing I'm not sure about is to put the use of sbtUnchecked in the solution header. To me, this should be kind of secret -- only available to people that really want to work around the DSL check. I would prefer to have only one or two solutions, instead of three, which may be confusing for users and forces them to read them all. @sbtUnchecked is an advanced use case so I feel comfortable leaving it to the docs. Does this make sense @clhodapp ?

I’m a bit late but why not forbid this by construction instead of letting users write what they want and then checking that it makes sense?

@jvican hrm, I feel like having features like @sbtUnchecked exist but not be publicized is going to reinforce sbt's reputation for being confusing/having bad documentation. If we feel the need to hide part of our api from the user, it probably shouldn't exist. Further, without the solution text explaining @sbtUnchecked the problem text is confusing because it explains a theoretical scenario that feels impossible; It reads as "We don't let you do this but if we did here's what would happen."