read_holding_registers returns None

I show a minimal code example indicating problem and output which I receive using pymodbus-1.2.0 and pymodbus3-1.0.0. to_string() is omitted for clarity. It's just a magic function to convert array of registers to a readable string. The question is why read_holding_registers() returns None when using pymodbus3?
Thanks
#! /usr/bin/env python3

from pymodbus3.client.sync import ModbusSerialClient as ModbusClient

pymc = ModbusClient(method="ascii", port="/dev/ttyUSB2", baudrate=9600, timeout=0.25)
ret = pymc.read_holding_registers(0x130, 13, unit=1)
print(ret)
print(to_string(ret.registers[1:]))

pymodbus-1.2.0 response:
ReadRegisterResponse (13)
Meradat-VIT19IT1

pymodbus3-1.0.0 response:
None
Traceback (most recent call last):
  File "./test_pymodbus3.py", line 33, in <module>
    print(to_string(ret.registers))
AttributeError: 'NoneType' object has no attribute 'registers'

Had a similar issue which was solved by adding sleep(1) to give the slave
time to respond, would be interested to see if this helps.
On Tue, Feb 28, 2017 at 2:19 AM, al37919<EMAIL_ADDRESS>wrote:

I show a minimal code example indicating problem and output which I
receive using pymodbus-1.2.0 and pymodbus3-1.0.0. to_string() is omitted
for clarity. It's just a magic function to convert array of registers to a
readable string. The question is why read_holding_registers() returns None
when using pymodbus3?
Thanks
#! /usr/bin/env python3
from pymodbus3.client.sync import ModbusSerialClient as ModbusClient
pymc = ModbusClient(method="ascii", port="/dev/ttyUSB2", baudrate=9600, timeout=0.25)
ret = pymc.read_holding_registers(0x130, 13, unit=1)
print(ret)
print(to_string(ret.registers[1:]))
pymodbus-1.2.0 response:
ReadRegisterResponse (13)
Meradat-VIT19IT1
pymodbus3-1.0.0 response:
None
Traceback (most recent call last):
File "./test_pymodbus3.py", line 33, in
print(to_string(ret.registers))
AttributeError: 'NoneType' object has no attribute 'registers'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/uzumaxy/pymodbus3/issues/3, or mute the thread
https://github.com/notifications/unsubscribe-auth/ATosu5OBfkIFSxSrqw_EQRBOe8sd5A8lks5rgs1vgaJpZM4MNGA8
.

unfortunately, time.sleep(1) between ModbusClient() and read_holding_registers() doesn't help.
The response stays None

try after read_holding_registers() i.e.
client = ModbusSerialClient(method='rtu',
port='/dev/ttySC0',
timeout=1,
baudrate=115200,
retry_on_empty=1)
res = client.read_input_registers(0x3100, 8, unit=mb_address)
time.sleep(1)
On Thu, Mar 2, 2017 at 10:38 PM, al37919<EMAIL_ADDRESS>wrote:

unfortunately, time.sleep(1) between ModbusClient() and
read_holding_registers() doesn't help.
The response stays None
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/uzumaxy/pymodbus3/issues/3#issuecomment-283604297,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATosu9p-7Nag0oW4NQD5k6pF-uuR_35eks5rho4TgaJpZM4MNGA8
.

I experienced the issue you are describing (serial client returning None when reading registers), when using pymodbus3 installed via pip. When instead running a (newer) version cloned from master, the issue was solved.
I think this was addressed in #5.

I used @perkarlberg way, and succeed!
In pypi.python, pymodbus3 1.0.0 was uploaded on 2014-07-18, and #5  was merged on 04-04, so I think you had install a old version by pip.

Fixed now,


Add --force-string flag to generic update.

Adds support for the --tags convenience argument to group update. Also, adds global support to generic update for --force-string which signals the code to not try and evaluate the contents of a supplied string, but simply to treat the input as a string.  Fixes #6605.

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[X] I adhere to the Command Guidelines.

You have trailing whitespace.  From the logs:

./src/command_modules/azure-cli-cognitiveservices/azure/cli/command_modules/cognitiveservices/_help.py:32:32: W291 trailing whitespace

./src/command_modules/azure-cli-cognitiveservices/azure/cli/command_modules/cognitiveservices/_help.py:55:14: W291 trailing whitespace

./src/command_modules/azure-cli-cognitiveservices/azure/cli/command_modules/cognitiveservices/_help.py:87:110: W291 trailing whitespace

3     W291 trailing whitespace


Take into account synchronous GraphQL client in Spring GraphQL 1.3.x

https://github.com/spring-projects/spring-graphql/releases/tag/v1.3.0-M1
https://github.com/spring-projects/spring-graphql/issues/771

Released in 1.3.1, see example https://github.com/nkonev/multipart-graphql-demo/tree/1.3.x/client-webmvc


added expected Timer behavior

removed redundant std::move()
added expected Timer behavior

Merged into develop. commit


Test that docker hash is not looked up for backends that don't support it

:+1:

@cjllanwarne is this better ?

:+1:

👍


Update base Docker image to Python 3.11.3

🗣 Description
This pull request upgrades the Docker base image to Python 3.11.3.
💭 Motivation and context
The latest version of Python should contain security and bug fixes and may also be more performant.
🧪 Testing
All automated tests pass.  I also performed a full BOD 18-01 run with these changes without incident.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

I used these changes for this weekend's BOD 18-01 run and they functioned as expected.


Raise HttpError on 400 response

raise BadRequest error as same as other http error like Unauthorized error.

LGTM

Thank you :yum:


Action: US0001 add working cmake project for googletest to repository

OBE: Full cmake build system imported from another project


Use numeric class variables instead of binary classes in defect data set.

Include Config data and compare against Issue #31 and #32

RESULTS:
rank ,         name ,    med   ,  iqr
----------------------------------------------------
   1 ,          Ivy ,    0.18  ,  0.18 (*              |              ), 0.18,  0.18,  0.37
   2 ,       Lucene ,    0.53  ,  0.21 (            -* |              ), 0.51,  0.53,  0.72
   2 ,          Ant ,    0.57  ,  0.11 (           ----*              ), 0.47,  0.57,  0.58
   2 ,        Jedit ,    0.65  ,  0.05 (               | -*           ), 0.63,  0.65,  0.68
   2 ,          ant ,    0.67  ,  0.40 (    -----------|---*          ), 0.29,  0.67,  0.69
   3 ,        jedit ,    0.68  ,  0.14 (               |  -*          ), 0.66,  0.68,  0.79
   3 ,          Poi ,    0.69  ,  0.12 (               | ---*         ), 0.63,  0.69,  0.75
   3 ,       lucene ,    0.72  ,  0.04 (               |    -*        ), 0.70,  0.72,  0.74
   3 ,          poi ,    0.72  ,  0.18 (               | ----*        ), 0.64,  0.72,  0.82
   4 ,          ivy ,    0.85  ,  0.09 (               |          *   ), 0.85,  0.85,  0.94

@timm Thoughts??

Damn. V.cool
some questions:

[] but i thought you were not doing continuous classes cause u lost smote?
[] does your data set include continuous AND discrete classes and you smote on the discrete and plan on the continuous (which would be a reasonable approach) btw.
[] where are the change graphs? still only moving a small number of attrbites?

@timm

Regarding smote: I realized that smote only take majority/minority classes into account, which means with discrete number of bugs like 0,1,2.... smote undersamples the majority class (0 Bugs) and oversamples the minority classes (all others). This creates a runtime overhead, but results are cool.

I haven't thought of the second approach, seems plausible, will give it a shot.

Change graphs, on their way. Taking too long.

take the result and run.do i have this right:

[ ] while smoting u used two classes false=0 and true>0.
[ ] while planning you selected the sibling leaf with lowest bugs , and that  "lower than" used the raw numerics

So, I take the training data and SMOTE everything, all classes so there are at least 100 '0' bugs, 50 each of 1,2,3,… bugs.
For instance, say I had a data set with:
Two hundred instances of '0' bugs,
Forty instances with '1' bug,
Twenty instances with '2' bugs, and
One instance with '3' bugs.
After I SMOTE the data, it will now have:
Hundred instances with '0' bugs,
Fifty instances with '1' bug,
Fifty instances with '2' bugs,
Fifty instances with '3' bugs. (Since I had only one instance of 3 bugs, I duplicate that row 50x)

See https://github.com/ai-se/Transfer-Learning/wiki/Week-of-July-20th


Remove stray dependencies from files

Discussion with @travs:
When we re-factored the PyOpenWorm test suite to breakdown individuals tests into files, we included most dependencies just to be safe and to make sure the suite ran as expected.  Many of these dependencies might not be needed, so it seems worth it to prune them away for future readability.
@travs says there are automated tools to help with this process (SnakeFood).

I got snakefood working and was able to generate a basic dependency graph.  I will probably need to go through all of the files manually and prune away the stray imports.  I'm not quite sure how snakefood generates these graph, so I might be misunderstanding exactly what the output is.

It looks like snakefood doesn't do what I thought it was doing.  The dependency graphs are inferred from import statements, not by running the code and looking at which modules are actually imported.  Unfortunately, this is not so useful to us at the moment, but is a nice tool to know about.

@gsarma I think this may still serve a useful purpose! There are kind of two issues here: one is finding dependencies that are installed in setup.py but never used in the rest of the code; The other is finding import statements that pull in code that is never used.
For the first one, if you use the --follow option in sfood, apparently, it follows the sub-dependencies of each direct dependency, so it should give us a full graph, even if it accesses these statically by import statements.
If we can just get a list of all dependencies imported in the project, we can find the unnecessary dependencies in setup.py quite easily.
Unfortunately, I haven't gotten this to work yet (maybe because my venv has all kinds of unnecessary stuff in it).
And as for the second issue of finding stray imports, I think you are right. There may be other tools to help with this though.
Quickly searching leads me to gluttony and this other package.

Ooh, it looks like pylint may actually do the second thing as well!

@travs, yes the approach you described will definitely help us find stray dependencies in setup.py.  That's a great idea.
But we still need a way to find stray dependencies in each of the testing files- it does look like pylint will take care of that.  We need to get a linter setup anyway, so maybe this is a good reason to get this started.

@mwatts15 thanks! can you explain how you went about this?  @travs and I were looking into some static analysis tools some time ago but never came back to it.


Inconsistencies with buf_token

This was reported in the Slack channel.

The documentation claims the default value for buf_token is ${{github.token}}. This seems incorrect.
It seems that there is some inconsistency between some of the GitHub Actions. buf-setup-action uses the name buf_api_token whereas this and some other actions use buf_token. We should probably unify these at some point?

Please see buf-action config. Consolidated to token.


Problem launching Ubuntu Focal container

@JasonAlt I'm seeing an error pop up when attempting to run the ubuntu:focal container. This shows up at the bottom of where the normal output should be showing the launching of the different services.
GLOBUS_CLIENT_SECRET="...secret" ./docker-run-gcs <local_image_id> <client UUID> <path_to_deployment_key>

To activate the new configuration, you need to run:
service apache2 reload
Launching GCS Manager
/entrypoint.sh: line 99: sudo: command not found

Is this using a container that resulted from docker-build-gcs or a customization on the image?

I incorrectly wrote where the error is occurring, I'll paste my exact steps:
cd globus-connect-server-deploy/
git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
git pull origin master
From https://github.com/globus/globus-connect-server-deploy
 * branch            master     -> FETCH_HEAD
Already up to date.
cd docker
./docker-build-gcs.sh ubuntu:focal
#0 building with "default" instance using docker driver

#1 [internal] load .dockerignore
#1 transferring context: 2B done
#1 DONE 0.0s

#2 [internal] load build definition from Dockerfile.debian
#2 transferring dockerfile: 257B done
#2 DONE 0.0s

#3 resolve image config for docker.io/docker/dockerfile:1.3-labs
#3 DONE 0.3s

#4 docker-image://docker.io/docker/dockerfile:1.3-labs@sha256:250ce669e1aeeb5ffb892b18039c3f0801466536cb4210c8eb2638e628859bfd
#4 CACHED

#5 [internal] load metadata for docker.io/library/ubuntu:focal
#5 DONE 0.2s

#6 [1/2] FROM docker.io/library/ubuntu:focal@sha256:c9820a44b950956a790c354700c1166a7ec648bc0d215fa438d3a339812f1d01
#6 DONE 0.0s

#7 [2/2] RUN <<EOF1 (apt update...)
#7 CACHED

#8 exporting to image
#8 exporting layers done
#8 writing image sha256:465308946adea212f647bf97da5d1e74febed0c34b6963ec9c491358918e2122 done
#8 naming to docker.io/globus/tmp/ubuntu-focal.stage.0 done
#8 DONE 0.0s
#0 building with "default" instance using docker driver

#1 [internal] load .dockerignore
#1 transferring context: 2B done
#1 DONE 0.0s

#2 [internal] load build definition from Dockerfile.ansible
#2 transferring dockerfile: 383B done
#2 DONE 0.0s

#3 resolve image config for docker.io/docker/dockerfile:1.3-labs
#3 DONE 0.1s

#4 docker-image://docker.io/docker/dockerfile:1.3-labs@sha256:250ce669e1aeeb5ffb892b18039c3f0801466536cb4210c8eb2638e628859bfd
#4 CACHED

#5 [internal] load metadata for docker.io/library/fedora:37
#5 DONE 0.3s

#6 [internal] preparing inline document
#6 DONE 0.0s

#7 [1/3] FROM docker.io/library/fedora:37@sha256:99bb2c54ce20c9cdbd28af25cb497dfe289aa0a9ccf8ff0485be037f75fa6130
#7 DONE 0.0s

#8 [2/3] RUN <<EOF (yum install -y docker...)
#8 CACHED

#9 [3/3] COPY <<EOF /ansible/playbook.yml
#9 CACHED

#10 exporting to image
#10 exporting layers done
#10 writing image sha256:6a12728d27b884c3b23d92066306382ce27c471e3cbe88aee6194b2ab54b1beb done
#10 naming to docker.io/globus/tmp/ansible done
#10 DONE 0.0s
b73201b6081e57b8208eff57d3d0ebe2dec69cfd8e3d072079584767a8a72f99

PLAY [all] *********************************************************************

TASK [Gathering Facts] *********************************************************
ok: [globus-tmp-ubuntu-focal.install_gcs.39515]

TASK [globus-connect-server : Install GCS packages] ****************************
included: /ansible/roles/globus-connect-server/tasks/install_debian.yml for globus-tmp-ubuntu-focal.install_gcs.39515

TASK [globus-connect-server : Install the GCS repository definitions] **********
changed: [globus-tmp-ubuntu-focal.install_gcs.39515]

TASK [globus-connect-server : Enable the Globus Connect Server stable repositories] ***
skipping: [globus-tmp-ubuntu-focal.install_gcs.39515]

TASK [globus-connect-server : Disable the Globus Connect Server stable repository] ***
skipping: [globus-tmp-ubuntu-focal.install_gcs.39515]

TASK [globus-connect-server : Enable the Globus Connect Server pre-stable repository] ***
skipping: [globus-tmp-ubuntu-focal.install_gcs.39515]

TASK [globus-connect-server : Enable the Globus Connect Server pre-stable proxy] ***
skipping: [globus-tmp-ubuntu-focal.install_gcs.39515]

TASK [globus-connect-server : Update the APT cache] ****************************
changed: [globus-tmp-ubuntu-focal.install_gcs.39515]

TASK [globus-connect-server : Install the Globus Connect Server] ***************
changed: [globus-tmp-ubuntu-focal.install_gcs.39515]

PLAY RECAP *********************************************************************
globus-tmp-ubuntu-focal.install_gcs.39515 : ok=5    changed=3    unreachable=0    failed=0    skipped=4    rescued=0    ignored=0

sha256:3d4233a01968c6281325dbcad9cc71acf476930bc3a01ada7ceac3f989c12c27
#0 building with "default" instance using docker driver

#1 [internal] load build definition from Dockerfile.gcs
#1 transferring dockerfile: 591B done
#1 DONE 0.0s

#2 [internal] load .dockerignore
#2 transferring context: 2B done
#2 DONE 0.0s

#3 [internal] load metadata for docker.io/globus/tmp/ubuntu-focal.gcs:latest
#3 DONE 0.0s

#4 [1/2] FROM docker.io/globus/tmp/ubuntu-focal.gcs
#4 DONE 0.0s

#5 [internal] load build context
#5 transferring context: 35B done
#5 DONE 0.0s

#6 [2/2] COPY entrypoint.sh /entrypoint.sh
#6 DONE 0.0s

#7 exporting to image
#7 exporting layers 0.0s done
#7 writing image sha256:5d5b419249cd736b2f89e563d454b751b0d3e40c2e9010dec9abffcb5bbfd4d7 done
#7 naming to docker.io/globus/globus-connect-server:ubuntu-focal-5.4.65 done
#7 DONE 0.0s
The final image is globus/globus-connect-server:ubuntu-focal-5.4.65
docker image list
REPOSITORY                                         TAG                   IMAGE ID       CREATED          SIZE
globus/globus-connect-server                       ubuntu-focal-5.4.65   5d5b419249cd   13 seconds ago   629MB
GLOBUS_CLIENT_SECRET="...secret" ./docker-run-gcs 5d5b419249cd   <client UUID> <path_to_deployment_key>
77b3dab...some long hash...bf1e163a

Nothing happens after this point, and the container is not running so I cannot get the logs.
docker container list
CONTAINER ID   IMAGE     COMMAND   CREATED   STATUS    PORTS     NAMES

I tried debugging so I tried launching the image directly.
docker run
-e GLOBUS_CLIENT_ID="579c1b5c-6b33-4747-a0cd-637f21de7125"
-e GLOBUS_CLIENT_SECRET="fgDQorq8ORJIdqZCR2dOJGQr7C3+VrXPnxNLJQEoRLw="
-e DEPLOYMENT_KEY="${DEPLOYMENT_KEY}"
--network=host
-it 5d5b419249cd
This is where I got the above error.
./docker_run_gcs_minimal.sh
IP address not specified, using <IP_ADDRESS>
Configuring endpoint
 [####################################]  100%
Starting services
Enabling module headers.
To activate the new configuration, you need to run:
 service apache2 restart
Enabling module proxy.
To activate the new configuration, you need to run:
 service apache2 restart
Considering dependency proxy for proxy_http:
Module proxy already enabled
Enabling module proxy_http.
To activate the new configuration, you need to run:
 service apache2 restart
Enabling module rewrite.
To activate the new configuration, you need to run:
 service apache2 restart
Considering dependency setenvif for ssl:
Module setenvif already enabled
Considering dependency mime for ssl:
Module mime already enabled
Considering dependency socache_shmcb for ssl:
Enabling module socache_shmcb.
Enabling module ssl.
See /usr/share/doc/apache2/README.Debian.gz on how to configure SSL and create self-signed certificates.
To activate the new configuration, you need to run:
 service apache2 restart
Enabling conf tls-mod-globus.
To activate the new configuration, you need to run:
 service apache2 reload
Launching GCS Manager
/entrypoint.sh: line 99: sudo: command not found

Ok, looks like the base image is shipped without sudo. Easy fix, you can verify if you like.
In globus-connect-server-deploy/docker/data/Dockerfile.debian, change the EOF lines to this:
RUN <<EOF1
    apt update
    apt install -y python3 python3-venv sudo
EOF1

You'll have to rebuild the image.

This is fixed in the latest push.


Properly resolving target file location for block macros

Fixes #446

Thanks, would it be possible to revert the version bump and add a test with an example that wasn't working?

@zeldigas I rebased your branch on master because the CI was running the JavaScript build instead of the Ruby build 😒

Thanks, would it be possible to revert the version bump and add a test with an example that wasn't working?

@ggrossetie I'll revert version bump, and will try to add test for issue. Will let you know if I have problem with the latter

@zeldigas let me know if you need or guidance on adding a test.

@zeldigas let me know if you need or guidance on adding a test.

Thank you, I'll prepare change, but most likely tomorrow or on weekend. Workdays are usually stuffed with work activities.

@ggrossetie  test added

Looks good, thanks!


Remote Simulator Tests Update

Summary
Update remote simulator tests so that they are both running and passing.
Details and comments

Reverted in 4c6dbebbc2b6b2dec4e2eac1208fbb2bdfad0a92. This tests were not prepared to run in master branch.


Behavior of Performance traffic-routing when all endpoints in closest region are degraded

According to this doc:
The default behavior for the 'Performance' traffic-routing method is designed to avoid over-loading the next nearest endpoint and causing a cascading series of failures. When an endpoint fails, all traffic that would have been directed to that endpoint is evenly distributed to the other endpoints across all regions.
According to https://docs.microsoft.com/en-us/azure/traffic-manager/traffic-manager-routing-methods#a-name--performanceaperformance-traffic-routing-method
If all enabled endpoints in the closest Azure region are degraded, Traffic Manager moves traffic to the endpoints in the next closest Azure region.
These are contradictory statements. One (or both!) must be wrong.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8633649e-b2d4-6a36-7752-08bb1e0b3365
Version Independent ID: 073df024-9a05-2554-e476-d301f21f5bcd
Content: Nested Traffic Manager Profiles
Content Source: articles/traffic-manager/traffic-manager-nested-profiles.md
Service: traffic-manager
GitHub Login: @KumudD
Microsoft Alias: kumud

@jtuliani Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

#in-progress

We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Rule suggestion: no unused exports

TS has knowledge of where a variable or function is used in a project, so theoretically it should be possible to implement a rule to warn when an export is not used.
This would be quite useful for modules containing lots of functions (like helpers), where it's not immediately clear when they stop being used due to a refactor, for example.
What do you think? :-)

See https://github.com/palantir/tslint/issues/780 and https://github.com/pzavolinsky/ts-unused-exports

#780 references this issue and is now closed. Is this issue still open or shall I use ts-unused-exports ?
Thanks in advance :)

#780 is not closed?

@OliverJAsh oh apologies, I misread the Closed label on the line Feature Request: Typescript dead code cleanup #3223

Yup, duplicate of #780. +1 to this idea!

you can also use ts-purne https://github.com/nadeesha/ts-prune, less buggy


사전 전환에 단축키 사용

영어사전 Command + 1
국어사전 Command + 2
등등..

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
sonnyfournier, @fireflyfolio, @oguzparlak, @pandakingli, @empongpat, @shiyunjie, @avorio, @alardizabal, @lawrencesong, @volkerw00, @toufikImk, @Halicea, @azeemba, @Phonbopit, @gustavringblom, @kk9six, @jaxlifu, @AllanWang, @suncle, @huanantiger


Bug: Connect a Wallet

Once I connect the Metamask wallet, I can't change the account after that, is this expected ?

@maryjaf if you click on your wallet address, you can disconnect.


Created a new section for Signedness

Proposed changes
Created a new section for Signedness under DataTypes
Edited, as some of the datatype sizes were wrong and ambiguous
Types of changes
What types of changes does your content introduce to this project?
Put an x in the boxes that apply (without "`")

[x] Proofreading (fix spelling, grammar, punctuation, accuracy) Proofreading
[x] New content (new section, new readme, etc.)
[x] Modifications (modifying existing content)
[ ] Other (please describe)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. Don't hesitate to ask if you're unsure about any of them. We're here to help! This simply reminds us of what we will look for before merging your code.
Note: If you submit code make sure to test it

[x] Tested any code that was added/modified in this PR
[ ] Added external links
[ ] Added internal links
[ ] Added images
[ ] Added videos
[x] Added code snippets

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Adding your name to the contributor's list
Comment "@all-contributors please add @your_username for content" to add your name to the contributor's list.
You can change the "content" with any of this
Reviewers:

[ ] @username

Please ensure that you are not adding any sensitive information like API keys, secrets, passwords, tokens, usernames, or other credentials. Refrain from adding your name, email, or other personal information.

@shhossain Can u please help in this, dont know why it failed the test , when I have mostly added and edited Text, and entered 2 codes.

@ZRX-SIGMA, this is not your concern. The code was committed before creating test.py. I will review your content as soon as possible.

@ZRX-SIGMA, this is not your concern. The code was committed before creating test.py. I will review your content as soon as possible.

ok thanks

@shhossain   It will be helpful if you could add this in hacktoberfest-accepted ..

@all-contributors add @ZRX-SIGMA for content


PVC with small storage capacity request will not bind

Describe the bug
I create a simple small PVC with a storage request of 10MiB.  This PVC will not be bound since Trident does not support PVCs smaller than 20MiB.  According to kubernetes [documentation|https://kubernetes.io/docs/concepts/storage/persistent-volumes/#binding] the storage must provision at least what was requested but may provision a larger volume.  I would expect Trident to provision a volume of 20MiB and bind to this PVC.
Environment
Provide accurate information about the environment to help us reproduce the issue.

Trident version:
Trident installation flags used:
Container runtime:
Kubernetes version: v1.27.8+4fab27b
Kubernetes orchestrator: OpenShift 4.14
Kubernetes enabled feature gates:
OS: RHCOS-4.14
NetApp backend types: ONTap
Other:

The bug should be reproducible on any supported version of Trident.
To Reproduce
Create the following PVC:
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: small-pvc
  namespace: default
spec:
  accessModes:
  - ReadWriteMany
  resources:
    requests:
      storage: 10Mi
  storageClassName: trident-iscsi
  volumeMode: Block

The PVC will remain pending indefinitely.  I do not believe the access mode or volume mode are relevant to the issue.  The expected behavior is a bound pvc to a volume of the minimum allowed size.
Expected behavior
The PVC should bind to a PV of the minim allowable size.

this commit does exactly that:
https://github.com/NetApp/trident/commit/7cbcccf204aa0755c9ce48812c7c92c8e61d0146
seems to be part of version 24.06

@pidreher is correct, this fix is available in 24.06.  ONTAP-backed PVs (except Flexgroups) may be as small as 20 MiB, which is ONTAP's lower limit for Flexvols.  PVCs smaller than that will be bound to 20 MiB volumes.


function outdated

PHP-Whois version: current version from the main branch
PHP version: 7.2
Description
domain availability check
How to reproduce
Deprecated: idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in /www/wwwroot/www.mydomain.com/vendor/io-developer/php-whois/src/Iodev/Whois/Helpers/DomainHelper.php on line 32
Possible Solution
function outdated
Additional context

Seems like floating bug...
Please provide results of this code in your PHP 7.2:

var_dump(defined("INTL_IDNA_VARIANT_UTS46"));'
'phpinfo()'

bool(false)
2 php-intl  is active in php

https://wiki.php.net/rfc/deprecate-and-remove-intl_idna_variant_2003

Please attach full output of phpinfo();


Sliding overlay Actionbar

Hi.
How do I do when the layerPosition = "TOP" working overlaying ActionBar?
Thanks.

ya how to do over/above ActionBar?

Hello @jamesmartins, @mkaarthick.
This is unrelated to how the layer operates itself. You do this externally in your layout similar to how you'd do with any other view (eg.: DrawerLayout).
The first thing you need to do is make sure the are of influence of your view is the entire screen. There are a few ways to do that. You can use a theme such as FullScreen or NoTitleBaror properties in your xml view like fitsSystemWindow.
Once your view expands to the entire surface of your window you can control the hierarchical position of your actionBar by using the new Toolbar component available in support v7 libraries. To display your toolbar below the sliding layer, simply place it properly in your xml file.
Here is a related post in StackOverflow addressing a similar issue, using the DrawerLayout. Check the answer marked as correct by Chris Banes.
Please note that I have not tried that myself yet. It'd be very interesting to see your results. Could you please share them once you get the desired effect?


[IT-2356] Setup secrets rotation

Setup DB secrets on a rotation schedule for enhanced security.

Thanks @zaro0508  for your PRs to nextflow-infra. I just wanted to acknowledge that we received these PRs and that we will be reviewing them soon.
We are currently testing the wave feature in Tower so wanted to hold off on these.

Amazon Aurora recently added integration with Secrets Manager to manage master user passwords for DB clusters[1].  This PR has been replaced with that implementation in PR #177
[1] https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/rds-secrets-manager.html


Running ES service causes issues

On Windows 10 with the elasticsearch-service-x64 version 6.2.4 running I'm unable to get Elastic.Xunit.ExampleMinimal to work as expected. However, with the service stopped it works great.
I'm guessing this is related:
Caused by: org.elasticsearch.http.BindHttpException: Failed to bind to [9200]

Thanks for raising this @kendaleiv
By default the nodes Elastic.Xunit spin up run on 9200 like any elasticsearch node. This can be changed however e.g if we alter the constructor in the Elastic.Xunit.ExampleMinimal MyTestCluster cluster.
		public MyTestCluster() : base(new XunitClusterConfiguration("6.2.0")
		{
			StartingPortNumber = 9201
		})
		{
		}

I'm inclined to keep it this way rather than trying to do something clever, @codebrain @russcam thoughts?

I would be inclined to leave it the way it currently is, otherwise we'd have to start inspecting the local environment to determine available ports and that seems like overkill at this stage.

@Mpdreamz Setting ClusterConfiguration.StartingPortNumber = 9201; doesn't seem to work and port 9200 is still used. Any ideas?

However, setting it like
public MyTestCluster() : base(new XunitClusterConfiguration("6.2.0") { StartingPortNumber = 9251 })

does work.

This is somewhat expected as everything materializes in the constructor chaining.
It oughta be a constructor argument really :)
Are you already using any of the code in this repository @kendaleiv ?

Yeah, we moved to this from https://github.com/poulfoged/Elasticsearch-Inside. I understand it's prerelease. :smiley:

Yeah, we moved to this from https://github.com/poulfoged/Elasticsearch-Inside. I understand this project is prerelease. :smiley:

Yeah, we moved to this from https://github.com/poulfoged/Elasticsearch-Inside. I understand this project is currently prerelease. :smiley:


SHM Buffer recovery mechanishm <1.10.x> [8220]

To merge after #1147
This PR solves SHM transport issues when there are mutiple subscribers and one of them freezes or is super slow processing messages. This could provoke the "slow" subscriber holds all the publisher buffers leading to a cotinuous publisher's segment overflow, so all subscribers stop receiving messages.

Changes buffer-node / buffer-data allocation structure. Now buffer-nodes are allocated (at the segment creation stage) as fixed buffer-node pool independent from the buffer-data. This way, a node never doesn't change its address.

The node contains an atomic validity counter so all subscribers can check whether its reference to the buffer has been invalidated. The node also contains atomic status counters to know how many subscribers are processing the buffer and in how many ports is it enqued.

Implement mecanishms to invalidate buffers already enqueued or beign processed by remote subscribers, although only buffers not beign processed are invalidated in this version.

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows


[ bug ] sliders flicker when the controller is refreshed

Sliders flicker when I click the refresh button.
But this does not happen in all controllers.
It seems the last controller to be created it's the one that flickers.

Here, I took a screenshot, when I was clicking on the refresh button.
The Controller on the left does not flicker, but it still updates successfully.

Even wih the same nodes, only some Controllers flicker.

I can confirm, I created 4 windows displaying the same KSampler, and always the last one is flickering.
https://github.com/user-attachments/assets/54ec5a8d-7c7f-47d0-be80-8be9067ccb3d

should be fixed on dev

Tested on dev, seems fixed!


Adding monitoring capability to lvm-operator

Signed-off-by: Arun Kumar Mohan<EMAIL_ADDRESS>

Please follow the commit lint format for the commit messages :
feat:
Long Description

Requesting a review from @umangachapagain  as he knows monitoring.

Something went wrong (completely)... and whole of my changes are gone now.... =(

Ya, just observed that
Use git reflog to checkout at commit e0f1e92 (referred from above github commits)

@aruniiird can you please do a rebase?


[QUERY] Azure Identity package is generating a lot of errors during local debugging

Library name and version
Azure.Identity 1.12.0
Query/Question
Hello
We have Asp.Net core application that is using multiple Azure resources (KeyVault, App configuration, App Insights, Service bus, Blob Storage). Previously we used connection strings and secrets to connect to all Azure Resources.
We have a requirement, to start using managed identity to connect to Azure resources. After the switch, we have a problem during local development and debugging. Below you can see the startup code, which is set up logging for Azure identity, ClientSecretCredential, and all Azure resources.
WebApplicationBuilder builder = WebApplication.CreateBuilder(args);

using Stream stream = new<EMAIL_ADDRESS>FileMode.OpenOrCreate, FileAccess.Write);

using StreamWriter streamWriter = new StreamWriter(stream)
{
    AutoFlush = true
};

using AzureEventSourceListener customListener = new AzureEventSourceListener((args, message) =>
{
    streamWriter.WriteLine(message);
    streamWriter.WriteLine("---");
}, EventLevel.LogAlways);

ClientSecretCredentialOptions options = new()
{
    IsUnsafeSupportLoggingEnabled = true,
    Diagnostics =
    {
        IsAccountIdentifierLoggingEnabled = true,
        IsLoggingContentEnabled = true,
        IsLoggingEnabled = true,
        IsDistributedTracingEnabled = true,
        IsTelemetryEnabled = true
    },
    Retry = {
        NetworkTimeout = TimeSpan.FromSeconds(60)
    }
};

TokenCredential tokenCredential = new ClientSecretCredential(
    builder.Configuration[TENANT_ID],
    builder.Configuration[CLIENT_ID],
    builder.Configuration[CLIENT_SECRET],
    options
    );

builder.Services.AddAzureClients(azure =>
{
    azure.UseCredential(tokenCredential);

    azure.AddSecretClient(new Uri(kvUri));

    azure.AddServiceBusClientWithNamespace(serviceBusNamespace)
        .WithName("name1");

    azure.AddServiceBusAdministrationClientWithNamespace(serviceBusNamespace)
        .WithName("name2");

    azure.AddBlobServiceClient(new Uri(storageEnpoint));
});

builder.Configuration.AddAzureAppConfiguration(options =>
{
    options.Connect(new Uri(appConfigurationUrl), tokenCredential)
           .Select(KeyFilter.Any, ConfigKeys.ALL_SERVICES_LABEL);
});

builder.Services.Configure<TelemetryConfiguration>(config =>
{
    config.SetAzureTokenCredential(tokenCredential);
});

builder.Services.AddApplicationInsightsTelemetry();

First of all, it looks like the logic is working as expected, so our application is working. Unfortunately, during the debug session in Visual Studio, we are receiving plenty of errors in our logs and it looks like, all of them are from the Azure identity package OR MSAL package used by Azure Identity.
Here are 2 errors, together with all additional logs with correlation Identity
1.
CorrelationId = 78e6aed6-ce5a-4b87-89e6-7de062bf2bee

False MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:19Z - 78e6aed6-ce5a-4b87-89e6-7de062bf2bee] MSAL MSAL.NetCore with assembly version '<IP_ADDRESS>'. CorrelationId(78e6aed6-ce5a-4b87-89e6-7de062bf2bee)
----
False MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:19Z - 78e6aed6-ce5a-4b87-89e6-7de062bf2bee] === AcquireTokenForClientParameters ===
SendX5C: False
ForceRefresh: False
-----
False MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:19Z - 78e6aed6-ce5a-4b87-89e6-7de062bf2bee]
=== Request Data ===
Authority Provided? - True
Scopes - https://management.azure.com//.default
Extra Query Params Keys (space separated) -
ApiId - AcquireTokenForClient
IsConfidentialClient - True
SendX5C - False
LoginHint ? False
IsBrokerConfigured - False
HomeAccountId - False
CorrelationId - 78e6aed6-ce5a-4b87-89e6-7de062bf2bee
UserAssertion set: False
LongRunningOboCacheKey set: False
Region configured:
---
False MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:19Z - 78e6aed6-ce5a-4b87-89e6-7de062bf2bee] === Token Acquisition (ClientCredentialRequest) started:
	 Scopes: https://management.azure.com//.default
	Authority Host: login.microsoftonline.com
---
False MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:19Z - 78e6aed6-ce5a-4b87-89e6-7de062bf2bee] [Region discovery] Not using a regional authority.
---
False MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:19Z - 78e6aed6-ce5a-4b87-89e6-7de062bf2bee] [Instance Discovery] Skipping Instance discovery because it is disabled.
---
False MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:19Z - 78e6aed6-ce5a-4b87-89e6-7de062bf2bee] [ClientCredentialRequest] Acquiring a token from the token provider.
---
False MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:20Z - 78e6aed6-ce5a-4b87-89e6-7de062bf2bee] Exception type: Azure.Identity.CredentialUnavailableException
---> Inner Exception Details
Exception type: System.Threading.Tasks.TaskCanceledException
---> Inner Exception Details
Exception type: System.Threading.Tasks.TaskCanceledException
---> Inner Exception Details
Exception type: System.Threading.Tasks.TaskCanceledException
To see full exception details, enable PII Logging. See https://aka.ms/msal-net-logging
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.HttpConnectionWaiter`1.WaitForConnectionWithTelemetryAsync(HttpRequestMessage request, HttpConnectionPool pool, Boolean async, CancellationToken requestCancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.DiagnosticsHandler.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)

=== End of inner exception stack trace ===
To see full exception details, enable PII Logging. See https://aka.ms/msal-net-logging
   at System.Net.Http.HttpClient.HandleFailure(Exception e, Boolean telemetryStarted, HttpResponseMessage response, CancellationTokenSource cts, CancellationToken cancellationToken, CancellationTokenSource pendingRequestsCts)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at Azure.Core.Pipeline.HttpClientTransport.ProcessSyncOrAsync(HttpMessage message, Boolean async)
   at Azure.Core.Pipeline.HttpPipelineTransportPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline)
   at Azure.Core.Pipeline.RequestActivityPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.ResponseBodyPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)

=== End of inner exception stack trace ===
To see full exception details, enable PII Logging. See https://aka.ms/msal-net-logging
   at Azure.Core.Pipeline.ResponseBodyPolicy.ThrowIfCancellationRequestedOrTimeout(CancellationToken originalToken, CancellationToken timeoutToken, Exception inner, TimeSpan timeout)
   at Azure.Core.Pipeline.ResponseBodyPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.LoggingPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RedirectPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RetryPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.RetryPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Identity.ManagedIdentitySource.AuthenticateAsync(Boolean async, TokenRequestContext context, CancellationToken cancellationToken)
   at Azure.Identity.ImdsManagedIdentitySource.AuthenticateAsync(Boolean async, TokenRequestContext context, CancellationToken cancellationToken)

=== End of inner exception stack trace ===
To see full exception details, enable PII Logging. See https://aka.ms/msal-net-logging
   at Azure.Identity.ImdsManagedIdentitySource.AuthenticateAsync(Boolean async, TokenRequestContext context, CancellationToken cancellationToken)
   at Azure.Identity.ManagedIdentityClient.AuthenticateCoreAsync(Boolean async, TokenRequestContext context, CancellationToken cancellationToken)
   at Azure.Identity.ManagedIdentityClient.AppTokenProviderImpl(AppTokenProviderParameters parameters)
   at Microsoft.Identity.Client.Internal.Requests.ClientCredentialRequest.SendTokenRequestToAppTokenProviderAsync(ILoggerAdapter logger, CancellationToken cancellationToken)
   at Microsoft.Identity.Client.Internal.Requests.ClientCredentialRequest.GetAccessTokenAsync(CancellationToken cancellationToken, ILoggerAdapter logger)
   at Microsoft.Identity.Client.Internal.Requests.ClientCredentialRequest.ExecuteAsync(CancellationToken cancellationToken)
   at Microsoft.Identity.Client.Internal.Requests.RequestBase.<>c__DisplayClass11_1.<<RunAsync>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.Identity.Client.Utils.StopwatchService.MeasureCodeBlockAsync(Func`1 codeBlock)
   at Microsoft.Identity.Client.Internal.Requests.RequestBase.RunAsync(CancellationToken cancellationToken)

2.

CorrelationId = d0130522-ad03-47d3-ac7a-17c786552d46

True MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:20Z - d0130522-ad03-47d3-ac7a-17c786552d46] MSAL MSAL.NetCore with assembly version '<IP_ADDRESS>'. CorrelationId(d0130522-ad03-47d3-ac7a-17c786552d46)
---
True MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:20Z - d0130522-ad03-47d3-ac7a-17c786552d46] === AcquireTokenForClientParameters ===
SendX5C: False
ForceRefresh: False
---
True MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:20Z - d0130522-ad03-47d3-ac7a-17c786552d46]
=== Request Data ===
Authority Provided? - True
Client Id - ****
Scopes - https://monitor.azure.com//.default
Redirect Uri - https://replyUrlNotSet
Extra Query Params Keys (space separated) -
ClaimsAndClientCapabilities -
Authority - https://login.microsoftonline.com/****/
ApiId - AcquireTokenForClient
IsConfidentialClient - True
SendX5C - False
LoginHint -
IsBrokerConfigured - False
HomeAccountId -
CorrelationId - d0130522-ad03-47d3-ac7a-17c786552d46
UserAssertion set: False
LongRunningOboCacheKey set: False
Region configured:
---
True MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:20Z - d0130522-ad03-47d3-ac7a-17c786552d46] === Token Acquisition (ClientCredentialRequest) started:
	Authority: https://login.microsoftonline.com/****/
	Scope: https://monitor.azure.com//.default
	ClientId: ****
---
True MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:20Z - d0130522-ad03-47d3-ac7a-17c786552d46] [Region discovery] Not using a regional authority.
---
True MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:20Z - d0130522-ad03-47d3-ac7a-17c786552d46] Access token is not expired. Returning the found cache entry. [Current time (07/09/2024 10:19:20) - Expiration Time (07/09/2024 11:12:46 +00:00) - Extended Expiration Time (07/09/2024 11:12:46 +00:00)]
Request [575875e1-114c-4754-b4ba-687862c24a13] exception System.Threading.Tasks.TaskCanceledException: The operation was cancelled because it exceeded the configured timeout of 0:00:01. Network timeout can be adjusted in ClientOptions.Retry.NetworkTimeout.
 ---> System.Threading.Tasks.TaskCanceledException: A task was canceled.
 ---> System.Threading.Tasks.TaskCanceledException: A task was canceled.
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.HttpConnectionWaiter`1.WaitForConnectionWithTelemetryAsync(HttpRequestMessage request, HttpConnectionPool pool, Boolean async, CancellationToken requestCancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.DiagnosticsHandler.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   --- End of inner exception stack trace ---
   at System.Net.Http.HttpClient.HandleFailure(Exception e, Boolean telemetryStarted, HttpResponseMessage response, CancellationTokenSource cts, CancellationToken cancellationToken, CancellationTokenSource pendingRequestsCts)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at Azure.Core.Pipeline.HttpClientTransport.ProcessSyncOrAsync(HttpMessage message, Boolean async)
   at Azure.Core.Pipeline.HttpPipelineTransportPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline)
   at Azure.Core.Pipeline.RequestActivityPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.ResponseBodyPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   --- End of inner exception stack trace ---
   at Azure.Core.Pipeline.ResponseBodyPolicy.ThrowIfCancellationRequestedOrTimeout(CancellationToken originalToken, CancellationToken timeoutToken, Exception inner, TimeSpan timeout)
   at Azure.Core.Pipeline.ResponseBodyPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
   at Azure.Core.Pipeline.LoggingPolicy.ProcessAsync(HttpMessage message, ReadOnlyMemory`1 pipeline, Boolean async)
---
True MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:20Z - d0130522-ad03-47d3-ac7a-17c786552d46]
	=== Token Acquisition finished successfully:
---
True MSAL <IP_ADDRESS> MSAL.NetCore .NET 8.0.6 Microsoft Windows 10.0.22621 [2024-07-09 10:19:20Z - d0130522-ad03-47d3-ac7a-17c786552d46]  AT expiration time: 9. 7. 2024 11:12:46 +00:00, scopes: https://monitor.azure.com//.default. source: Cache

So I cannot find the root cause for both of the errors. As we are executing multiple calls to Azure, I am not able to see which Azure calls can cause exceptions. Is it possible that both errors are from Azure Identity directly and are not caused by any additional Azure call?
For the first one, I tried to enable PII Logging. According to source code, MSAL enable PII logging flag should be set by IsUnsafeSupportLoggingEnabled according to this changelog
But although I set this property to true, the result is still the same. Do you know what I am doing wrong? Maybe if I can see PII details, the error message can give me more info.
For the second issue, I also tried to extend network timeout by setting NetworkTimeout in the Retry object in TokenCredentialOptions, but again, nothing changed and the error message is still the same.
So can anyone please help me to better understand these errors and to check what can be done and how to avoid them?
As I mentioned, looks like the app logic is working, so one solution how to get rid of those errors will be to set the minimal log level to Fatal for Azure.Identity, but I would like to understand what is the problem.
Thank you very much for any help
Environment
Windows 11, .NET 8.0.300, Visual Studio 17.10

Hi @pavoldecky -
Are you using Microsoft.Identity.Web in your application? If so, I believe this comes from that using our DefaultAzureCredential internally. If not, are you using DefaultAzureCredential in your app directly?
Regardless, these errors are expected and harmless. They are an artifact of the DefaultAzureCredential environment detection logic, which tries to determine if a managed identity is available before moving on to other credentials. This behavior is explained here.

Hi @christothes
Thank you very much for your hint and explanation.
I wanted to avoid using DefaultAzureCredential, so I am using ClientSecretCredential for local debugging and WorkloadIdentityCredential in Release mode inside AKS. But there was still one place in the code, which I used DefaultAzureCredential. If I changed it to ClientSecretCredential all errors disappear.
But the funny thing here is that the errors with DefaultAzureCredential are shown only if I used it with ArmClient from Azure.ResourceManager package, If I use DefaultAzureCredential in other Azure packages, no errors are shown. So I will check what I am doing wrong.
Thank you very much for your help. This issue be closed.


Convert all the values for TXT to strings

As mentioned in https://github.com/balthazar/react-native-zeroconf/issues/124#issuecomment-617085761
Adds the ability to handle the values other than strings for
TXT. Previously any other values, like integer, boolean would be ignored.
On iOS, non string values would ensure that the TXT value would not be set at all, even if any other key/value pairs contained strings.
On Android, it would throw an error if the values weren't strings.

@FrankFundel can you please try this?
I've tried it on both iOS & Android and I got no issues.
Thanks

Thanks!

0.12.2 published


Adding ability to remove all keys

Fixes https://github.com/tweedegolf/sequential-storage/issues/47 by adding a remove_all_items() function to map to erase all of the saved keys using an overwrite mechanism. This prevents needing to erase device flash, which could take a long time.
The benefit of this approach is that flash erasure counts are minimized, as you need to loop through all of flash before anything ever needs to be erased.
I haven't tested this on hardware yet, so leaving it as a draft.

It turns out our platform is not capable of remove_item calls, so I cannot test this, but it seems that we could still add this if desired.

I think it's a nice API to have. So let's leave the PR open for now until I have time to pick it up.
Thanks for the work so far!


chore(blockifier): implement staknet_api class_info to match blockifier class_info

…er class_info

This change is

crates/starknet_api/src/contract_class.rs line 48 at r4 (raw file):

/// and other parameters derived from the original declare transaction required for billing.
#[derive(Clone, Debug, Deserialize, Eq, PartialEq, Serialize)]
pub struct ClassInfo {

Suggestion:
// TODO(Ayelet,10/02/2024): Change to bytes.
pub struct ClassInfo {

crates/starknet_api/src/contract_class.rs line 9 at r8 (raw file):

// Ethereum constant.
pub const WORD_WIDTH: usize = 32;

move to core.rs
Code quote:
// Ethereum constant.
pub const WORD_WIDTH: usize = 32;

crates/starknet_api/src/contract_class.rs line 9 at r6 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Please use this constant in the blockifier crate (and remove it from eth_gas_constants.
Consider defining it in a different file (maybe core.rs?)
(can be done in a separate PR)

Done

-- commits line 5 at r8:
Previously, ArniStarkware (Arnon Hod) wrote…
Why is this PR comprised of two commits?
There is no

impl .into()
in this PR - or am I missing something?

fixed. I'm trying Graphite and still learning.. :)

crates/starknet_api/src/core.rs line 468 at r10 (raw file):

// Ethereum constant.
pub const WORD_WIDTH: usize = 32;

Constants should be at the start of the file.
Another issue is that the constant WORD_WIDTH 's name is non-informative in this context.
Suggestion:
// Ethereum constant.
/// One Felt fits into 32 bytes.
pub const WORD_WIDTH: usize = 32;

#1688
#1858
#1702  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @avivg-starkware and the rest of your teammates on  Graphite


Give player a way to move the whole squad between levels at once

Split off the conversation recorded in #82.

variant of squad combat where all team members move at once and follow the leader (or his target). [...]
we need to think about a way to move the whole squad between levels at once.

This is related to an effect idea I had: "Call N friends (party member or also allies) to actor's side, one variant would be within level, another from adjacent levels, another from all levels. Perhaps make it free, embedded in some kinds of stairs/lifts."

Another factor: perhaps consider only selected actors. If so, perhaps make it a part of the command that makes all selected actors run to a given tile (stairs in this case).

Perhaps make this particular tile bumping action not take any time to avoid either arriving at the new level and immediately taking number_of_actors hits or taking as many hits on the old level. Or suffering hits on both levels and ending up with only a portion of the party at each level.
However, beware of timeless actions, because they may lead to a time loop: if slippery tiles near the stairs send an actor back onto the stairs, the actor may be caught changing levels without any hope of another actor interrupting that.


Highlight element on mouse over

The highlighter still shows up for components that aren't actually visible in the DOM.

LGTM :+1:


Code document for "Allow unauthenticated requests" is missing

On the section where they mention that you can "Allow unauthenticated requests" the documentation mention the following:
"This option defers authorization of unauthenticated traffic to your application code. For authenticated requests, App Service also passes along authentication information in the HTTP headers."
However, no link to where an example of that code can be found is given.
Some further guidance about how to do this would be very appreciated.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 75e17529-8b8a-1d67-f0e1-840d1d3ca990
Version Independent ID: 265645df-ef21-4631-1744-7014b3ee681a
Content: Authentication and authorization - Azure App Service
Content Source: articles/app-service/overview-authentication-authorization.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@magoicochea, Apologies for the delayed response.
Here the application code is your Website code itself. With App Service you can chose to leverage the built-in authentication and authorization (Easy Auth) or sign in users and access data by writing minimal or no code in your web app.
That is, the server code manages the sign-in process, so it is also called server-directed flow or server flow.
Referencing from the Azure Portal options:

You may see some samples here:
https://github.com/Azure-Samples/app-service-web-dotnet-get-started
https://github.com/Azure-Samples/app-service-dotnet-manage-authentication-for-web-apps
Since there is no doc update on this, we will close this for now. Thanks for sharing your feedback.


marker centering on click

Hi!
Is there possibility to somehow horizontally center, veritcally put on the to 20% of the map a marker after I click on it (moving the map not the marker).
Thanks a lot!

Please translate

When i click a makrer (A) i can center it (c), but i would like to position is vertically not in the middle, but offset a little bit (like t)

As I understand your problem that you don't know the way how to calculate lat offset for center prop.
Do you need something like this?
center = {lat: marker.lat - 100px, lng: marker.lng}
So you need some math to convert px to lat, it's easy:
You have in onChange event bounds and size
bounds = {
  nw: {
    lat: 50.01038826014866,
    lng: -118.6525866875
  },
  se: {
    lat: 32.698335045970396,
    lng: -92.0217273125
  }
};

So to convert 100px to lat offset your just need
latOffset = 100 * (nw.lat - se.lat) / size.height

Now you can  center = {lat: marker.lat - latOffset, lng: marker.lng}

thanks! how do i get the bounds?

At onChange event you will get bounds and size

thankyou!
On change trigers initially also so this is perfect :+1:

just curious: is there a way to animate map centering?


Update Azure Monitor Ingestion authZ scope

For context, see https://github.com/Azure/azure-sdk-for-net/issues/38998.

Task Completed<EMAIL_ADDRESS>


Add "format" support for mustParse test helpers 🧙

Changes
Allow using mastParse in a similar fashion to fmt.Sprintf, adding
support for formating and replacing variables in there.
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>/cc @tektoncd/core-maintainers @imjasonh
The alternative (which is also really viable) is to not change it and rely on users doing fmt.Sprintf prior to passing the yaml.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
NONE

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-alpha-integration-tests

The longer the YAML gets the more frustrating ordered format specifiers are going to be wrt update and maintenance.
Also agree strongly with:

The alternative (which is also really viable) is to not change it and rely on users doing fmt.Sprintf prior to passing the yaml.

@imjasonh very good point, didn't really realized that (I had small yaml 😅).  Then I think we shouldn't touch these function but we could provide some based off of text/template indeed.

Let's close this one for now.
/close


Error 0xC000005 in MSVC

Currently I'm testing mimalloc for our internal neural network inference engine. I'm using the overriding method (linking mimalloc-override.lib). Error 0xC000005 is reported by MSVC.
Our engine uses JIT (xbyak) to generate kernels, and for one certain model, the whole program crashes at one of the operators. Notably, every time it happens, it is at the very beginning of accessing the JIT kernel, and the starting address always ends with 0000.
This implies that the kernel is aligned to 64KB, right? Any thoughts why the crash might happen?

Setting mi_option_decommit_delay to 50 avoids the crash

Hmm, the error means memory is accessed that was just decommitted..  it looks like there is a "use after free"  (and mimalloc already decommitted the underlying OS memory once it was accessed again; since it disappears when increasing the delay, it really looks like a use-after-free bug).
If you are able to trap into the debugger on the crash, you may be able to see what access caused this and check that you didn't  already free that memory?


Where to trigger UI javascript

Hi,
I wonder where I should trigger javascripts when document is rendered and ready , e.g.
$('#side-menu').metisMenu();

The metisMenu can be triggered only when side-menu elements are generated.
In Jquery, it is simply putting the codes in
$(document).ready(...)

which does not work in ember as the DOM itself are not rendered yet.

To wait DOM rendering, Ember.View#didInsertElement is useful.
BTW: This is a question, not an ember-rails issue.
In such case, you can ask on Stack Overflow in the next time.


Node 18 doesn't run the project

The current project run correctly with node 14.x we should make it run with the new version node 18.x (LTS)
git checkout release/0.7
git pull
git checkout -b 'feature/suppot-node18'

closed by #402


Cleanup prototype kernel signatures

Addresses https://github.com/pytorch/vision/pull/6646#discussion_r979981814. The second commit in the PR renames all instances of img to image on the prototype kernels. This was not discussed in the comment linked above, but goes in the same direction of aligning the kernel signatures as much as possible.

You can merge first and I will fix them.


Support OL's attributes start, reversed

Use built-in counter in OLs
Motivation and Context
Attributes start, reversed set up a built-in counter named list-item. Using this counter allows such customization.
How has this been tested?
```
<FormatText>
    <ol start="3">
        <li> this item should have a "marker" 3 </li>
    </ol>
</FormatText/>
```

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Nice improve.

Checklist:

[ ] My code follows the code style of this project.
[ ] I have updated the documentation accordingly or it's not required.
[ ] Unit tests are not broken.
[ ] I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
[ ] I have added new unit tests on added of fixed functionality.

Hi, the checklist is not completed. Please, either reopen PR as a draft if you are going to do every checklist's step or open an issue.

The issue: https://github.com/semrush/intergalactic/issues/685


Cow: Blacklist 93929.60295(?#NO NorAm)

Cow requests the blacklist of the number 93929.60295(?#NO NorAm). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by tripleee in Charcoal HQ


New Coverage API & Simplified Assertions API

This PR implements some of the comments found in #30.
The idea here is to have a unified Functional Coverage API. This means that all of the different cover constructs are created using a single function:
cover(name: String, ports: Data*)(bins: Bin*)

Will generate a CoverPoint or a CrossPoint.
cover(name: String, ports: Data*)(delay: DelayType)(bins: Bin*)

Will generate a TimedCross.
cover(name: String, ports: Data*)(conditions: Condition*)

Will generate a CoverCondition.
Above this, the bin and cross functions can be used to generate Bin, Condition and CrossBin.
bin(name: String, range: Range, condition: Seq[BigInt] => Boolean, expectedHits: BigInt) //Generates a Bin
bin(name: String, condition: Seq[BigInt] => Boolean,  expectedHits: BigInt) //Generates a Condition
cross(name: String, ranges: Seq[Range], expectedHits: BigInt = 0) //Generates a CrossBin

Now the Functional coverage interface is independent from the internal implementation details.

Discovered a bug that needs fixing before this can be merged.


Make encoders registration optional

Fixes https://github.com/aspnet/StaticFiles/issues/139
@Tratcher

:shipit:

@pakrym Any reason this is open?


  There were 4 files that also had extra characters at the end, that have already been fixed (see PR #41498), so If you search all the files located in curriculum/challenges/english with the following regex, you will find all the instances remaining to be fixed.
NOTE:  Do not include the Python challenges. The single line code blocks are in the Answers section which we do not want to change at this point.
/^`[^`]+?`$/gi

Each replacement should make sure to reference the applicable language of the code.  See the following examples:
HTML Code
Before:
`<button accesskey="b">Important Button</button>`

After:
```html
<button accesskey="b">Important Button</button>
```

CSS Code
Before:
`animation-iteration-count: 3;`

After:
```css
animation-iteration-count: 3;
```

JavaScript Code
Before:
`myVar = myVar * 5;`

After:
```js
myVar = myVar * 5;
```

JSX Code
Before:
`<div style={{color: "yellow", fontSize: 16}}>Mellow Yellow</div>`

After:
```jsx
<div style={{color: "yellow", fontSize: 16}}>Mellow Yellow</div>
```

Tasks:

[x] Replace any single inline code blocks with characters at end with multi-line code blocks (see PR #41498)

[ ] Replace all single inline code blocks with multi-line code blocks by creating a separate PRs for each certification affected.

[ ] Responsive Web Design - 46 code blocks in 36 challenges (assigned to @Sembauke)
[ ] JavaScript Algorithms and Data Structures - 35 code blocks in 25 challenges (assigned to @ieahleen)
[ ] Front End Libraries - 28 code blocks in 25 challenges(assigned to @LaurentLabine)
[ ] Data Visualization - 9 code blocks in 9 challenges (assigned to ???)
[ ] Coding Interview Prep - 25 code blocks in 9 files (assigned to ???)

To get this task accomplished quickly, we are fine with multiple contributors taking on this issue.  Please let us know which section(s) you plan to create PRs for, so others will know not to work on those sections. We are limiting this issue to contributors who have already contributed in the past.

I can help with this,, I can do JavaScript

I can help with the Responsive Web Design one

I'll go ahead and attack the Front End one!

if someone else wants to do the JS one, I have not been able to yet, my dev environment is not behaving nicely

if someone else wants to do the JS one, I have not been able to yet, my dev environment is not behaving nicely

Take your time @ieahleen :)

Maybe I can redeem myself for the few mistakes i've made...  Do you need help with setting up?  What is the issue you are having?  Maybe I can help?

@LaurentLabine GitPod is having issues, I will try again tomorrow, for today I'm stopping here

Ahh Alright I cannot assist you then I have set it up using VSCode and downloaded all the code locally ...  Tomorrow is another day! :)

I'll go ahead and take on Data Vis and Coding Interview Prep

@ieahleen In an effort to get this issue closed, I created PR (#41576).

When that PR merges, we should be good to close this right?

@nhcarrigan Once mine is merged, the issue can be closed.

Closing this issue as all related PRs have been merged.


fix: do not escape html in Argo Events payload

do not unnecessarily escape html characters in argo events payload.

linked to https://github.com/WGBH-MLA/chowda/issues/204


Add planned enhancements

Can consider adding these bugs which we couldn't fix for 1.4:  invisible scrollbar, help menu issue, colour of grades in summary and delete one group.


Automated Package Upgrade

:tada: This PR is included in version 7.7.39 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Game window and save fails when show TileMap

Godot version:

OS/device including version:

Ubuntu Mate 18.04 (updated).

Issue description:

Steps to reproduce:
New project with only a TileMap doesn't reproduce well when start. And if the project is save, saves only the tiles that show in the game window.
Minimal reproduction project:

New project with a Node and MapTile. Using this tutorial basically: https://docs.godotengine.org/en/latest/tutorials/2d/using_tilemaps.html

I can reproduce this on commit https://github.com/godotengine/godot/commit/eef2625ae5a8be8a4aa89a6443acfd5b6184c668.
Editor:

Running project:

The window part looks like a bug that was already reported, might've been a driver issue?

Please upload a project that breaks so I can test, I have no time right now to set one up.

@reduz https://github.com/Calinou/game-off-2018 :slightly_smiling_face:

Fixed by #23625.


Move a few JS files

src/explore/stores/store - > src/explore/store
src/explore/stores/visTypes -> src/explore/visTypes
src/visualizations/main.js -> src/visualizations/index.js

Codecov Report

Merging #4841 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4841   +/-   ##
=======================================
  Coverage   76.96%   76.96%
=======================================
  Files          44       44
  Lines        8534     8534
=======================================
  Hits         6568     6568
  Misses       1966     1966

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 860a4d9...908ef52. Read the comment docs.


[HOLD for payment 2023-07-20] [$1000] Not able to invite an email when it's a substring of the selected email

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to Settings => Workspaces => Select a Workspace => Members => Invite new members
Search an email [abcde<EMAIL_ADDRESS>and select it
Then search another email [bcde<EMAIL_ADDRESS>which is a substring of the selected email

Expected Result:
We should be able to search the second email [bcde<EMAIL_ADDRESS>and select it after selecting the first email
Actual Result:
We can't search for the second email [bcde<EMAIL_ADDRESS>after selecting the first email
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.31-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/67b9411f-593b-4da7-a5b3-7e5da9627133
Expensify/Expensify Issue URL:
Issue reported by: @eh2077
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687699081649209
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012c7b7da0a7c6f9b3
Upwork Job ID:<PHONE_NUMBER>144259072
Last Price Increase: 2023-06-30

Proposal
From @eh2077
Please re-state the problem that we are trying to solve in this issue.
Not able to invite an email when it's a substring of the selected email.
What is the root cause of that problem?
The root cause of this issue is that we concat logins of selected options to a string filterText and check by !filterText.includes(login) if a login is unselected, which is wrong, see below snippet
https://github.com/Expensify/App/blob/820fa93ad1e799c12d8b639b98018b5350ea17af/src/pages/workspace/WorkspaceInvitePage.js#L153-L155
What changes do you think we should make in order to solve the problem?
To fix this issue, we can save logins of selected options to an array selectedLogins and use method !_.contains(selectedLogins, login) to check if a login is unselected.
To achieve it, we can change
https://github.com/Expensify/App/blob/820fa93ad1e799c12d8b639b98018b5350ea17af/src/pages/workspace/WorkspaceInvitePage.js#L153-L155
to
const selectedLogins = _.map(this.state.selectedOptions, ({login}) => login);
const personalDetailsWithoutSelected = _.filter(this.state.personalDetails, ({login}) => !_.contains(selectedLogins, login));
const hasUnselectedUserToInvite = this.state.userToInvite && !_.contains(selectedLogins, this.state.userToInvite.login);

What alternative solutions did you explore? (Optional)
N/A

I feel like the steps are not clear - asking here: https://expensify.slack.com/archives/C049HHMV9SM/p1687989728056769?thread_ts=1687699081.649209&cid=C049HHMV9SM

Cool, questions resolved and I can repro!

The proposal from @eh2077  here https://github.com/Expensify/App/issues/21783#issuecomment-1611209494 looks good and works well. The root cause is correct and it is very weird we have created a string with all the logins and searching with it.
@eh2077  Could you kindly paste the proposal again from your login, just for reference in PR sake?
🎀👀🎀
C+ Reviewed
🎀 👀 🎀 C+ reviewed
cc: @jliexpensify

@deetergp C+ approved comment is here - https://github.com/Expensify/App/issues/21783#issuecomment-1616704679

Proposal
Please re-state the problem that we are trying to solve in this issue.
Not able to invite an email when it's a substring of the selected email.
What is the root cause of that problem?
The root cause of this issue is that we concat logins of selected options to a string filterText and check by !filterText.includes(login) if a login is unselected, which is wrong, see below snippet
https://github.com/Expensify/App/blob/820fa93ad1e799c12d8b639b98018b5350ea17af/src/pages/workspace/WorkspaceInvitePage.js#L153-L155
What changes do you think we should make in order to solve the problem?
To fix this issue, we can save logins of selected options to an array selectedLogins and use method !_.contains(selectedLogins, login) to check if a login is unselected.
To achieve it, we can change
https://github.com/Expensify/App/blob/820fa93ad1e799c12d8b639b98018b5350ea17af/src/pages/workspace/WorkspaceInvitePage.js#L153-L155
to
const selectedLogins = _.map(this.state.selectedOptions, ({login}) => login);
const personalDetailsWithoutSelected = _.filter(this.state.personalDetails, ({login}) => !_.contains(selectedLogins, login));
const hasUnselectedUserToInvite = this.state.userToInvite && !_.contains(selectedLogins, this.state.userToInvite.login);

What alternative solutions did you explore? (Optional)
N/A

@eh2077 Could you kindly paste the proposal again from your login, just for reference in PR sake?

Sure! Added https://github.com/Expensify/App/issues/21783#issuecomment-1616710314

@deetergp Pending on your approval.

@eh2077's proposal sounds like the right one. Let's do it!

@abdulrahuman5196 The PR https://github.com/Expensify/App/pull/22319 is ready for review, thanks.

Nice one, @abdulrahuman5196 don't forget the checklist :)

BZ checklist:

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://github.com/Expensify/App/pull/7986#issuecomment-1646589116

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. Edge case issue. So wouldn't be beneficial to create a test case for the same.

@jliexpensify BZ checklist is complete here - https://github.com/Expensify/App/issues/21783#issuecomment-1646589371

Paying everyone now! @eh2077 - $1250, @abdulrahuman5196 - $1000.

@jliexpensify I think speed bonus should be applied here. See below timeline
Assign: 2023-07-05T20:16:12Z
C+ engineer @abdulrahuman5196 reviewed and approved: 2023-07-07T19:36:57Z
Internal engineer @deetergp merged: 2023-07-10T21:28:55Z

Hmm yes, good point - there were 2 days of the weekend

New job here - https://www.upwork.com/jobs/~015be223583ed610b4

@eh2077 and @abdulrahuman5196 have invited you for the bonus payout

@jliexpensify Accepted thanks!

@jliexpensify accepted the invite

Paid, thanks!


Fix DataOutputAgent so that it can output items with multiple categories

The to_xml method encodes { "category": ["a", "b"] } as follows:
<item>
 <category>
  <category>a</category>
  <category>b</category>
 </category>
</item>

Instead of this:
<item>
 <category>a</category>
 <category>b</category>
</item>

Even if category is a singular noun.  This feature prevents DataOutputAgent from emitting multiple <category> elements (or <enclosure>, etc.) properly, so I've added a tweak to fix the resulted XML document.
I know the code in the current form is far from optimal, so I think we'll have to revisit here soon or later...

Thanks for the review.  These gsub calls should be safe and would never raise exceptions.

I think we should implement a new XML generator that generates a DOM tree you can manipulate before serializing to the final string form.  The to_xml method is too wild to handle.

That sounds like a good idea but also some work 😄 This could also allow us to add special tags to  embed HTML/XML in CTAGS

I have a question about the current implementation here. As far as I can see, arrays are only handled as described above if they are defined in the agent configuration at design time.
However when an array is passed from an incoming event it is always implicitly joined within a single "category" element instead of there being multiple "category" elements.
Is this by design or am I doing something wrong?

@mightymt Are you accessing the array with the as_object filter like in the spec here? If you are using {{ some_key }} liquid will join the array into a string.

@dsander Thanks for your reply, that's what I was looking for! Didn't know about this filter.


Calling all(), when using the RedisStorageDriver class, throws error: strlen() expects parameter 1 to be string, null given

Describe the bug
I'm writing my own custom driver, which uses this package DatabaseStorageDriver and RedisStorageDriver. This is because I like to cache tenant data, but mainly store my tenant in my MySQL database.
Now, when I call the all() function from the RedisStorageDriver, I get this error:
strlen() expects parameter 1 to be string, null given
Steps to reproduce

Add new custom driver.
Inject DatabaseStorageDriver & RedisStorageDriver classes into the new custom driver.
Call the RedisStorageDriver's all() method.
Configure config/tenancy.php (storage_driver => cache, storage_drivers => add CacheDriver)
It's worth mentioning that I've setup a custom Redis connection with these params:

'cache' => [     'host' => env('REDIS_HOST', '<IP_ADDRESS>'),     'password' => env('REDIS_PASSWORD', null),     'port' => env('REDIS_PORT', '6379'),        'database' => env('REDIS_CACHE_DB', '5'), ],
6. I've also set the connection param of the RedisStorageDriver to this connection in config/tenancy.php
Expected behavior
I should get an (empty) array of cached tenants.
Your setup

Laravel version: v6.14.0
stancl/tenancy version: v2.2.7
Storage driver: Custom 'Cache' Driver, that uses both DatabaseStorageDriver & RedisStorageDriver

Thanking you in advance.

This is because I like to cache tenant data, but mainly store my tenant in my MySQL database.

This feature is not documented yet, but you can do this already. Look at the latest releases: https://github.com/stancl/tenancy/releases/tag/v2.3.0
https://github.com/stancl/tenancy/blob/2.x/assets/config.php#L19
It's also well explained in #348

Thank you! :)


TEMP_CELSIUS warning

Describe the bug
Warning in logs with "TEMP_CELSIUS was used from hon, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.CELSIUS instead"
To Reproduce
Steps to reproduce the behavior:

Restart HA
Go to logs

Expected behavior
The warning should not appear
Environment (please complete the following information):
Core 2024.2.2
Supervisor 2024.02.0
Operating System 11.5
Frontend 20240207.1
hon 0.10.1
Home Assistant Logs
Check System -> Logs if you can find any logs related to this integration and post it here.
Device Log
Logger: homeassistant.const
Source: helpers/deprecation.py:205
First occurred: 6:00:53 PM (1 occurrences)
Last logged: 6:00:53 PM

TEMP_CELSIUS was used from hon, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.CELSIUS instead, please create a bug report at https://github.com/Andre0512/hon/issues

Hi, thanks for reporting. It's already fixed in the latest version, see #141 :slightly_smiling_face:


Implement Role Tags to display roles tagged to each company

Update UI to display roles tagged to a company
Update UI such that box containing roles is not displayed when there are no roles available

LGTM 👍


Add a .stylua.toml file and ensure all Lua files match format

Thoughts @ldelossa ?
If you're into the idea, I can submit a PR and set up checking via GitHub Actions. I can write the workflow.yml, and then you'd just need to set it as a required workflow to pass for PRs in repo settings.

I usually just use the LSP's formatter. Maybe this will be better as I think most use the same Lua lsp, and it would have all developers formatting the code similarly, without additional tools.

Ah, gotcha. I have my editor using stylua by default but I can tweak my config to use LSP formatter if no .stylua.toml is found 👍


add "See All" for transactions

https://www.figma.com/proto/rH7A7NquSsXEH7v8eGuYM7/Blink-(BBW)-Mobile-App-Design?page-id=5871%3A96345&type=design&node-id=7693-1871&viewport=-980%2C1006%2C0.74&t=47NqV5btpaxwNBBC-1&scaling=min-zoom&starting-point-node-id=6160%3A97622&show-proto-sidebar=1&mode=design

Simple solution to problem is to change "Transactions" (non intuitive) to "All transactions" and color it accent color:

Hi I'd like to work on this. Should I wait for this to be assigned/approved? Not sure what the system you use is for green-lighting proposed changes.
PS I've tried to contact someone on Mattermost over a month ago to no avail. Is there someone I could talk to about this project? I'm a Canadian but I used to live in El Salvador for a summer. I used this app all the time in El Zonte. I'd be really cool to chat with someone about how I could get further involved. @nicolasburtey @designsats

you can just open a PR for that one @MaxwellDG . it's a simple one.


kubectl not apply changing spaces in file

What happened:  We made a mistake in specifying the version of the image in deployment
    containers:       image: { IMAGE_NAME }:"MISTAKE_SPACE"{ IMAGE_VERSION }
we tried to fix it - removed the space and using the command - kubectl apply -f deployment.yaml, but the changes were not applied.
What you expected to happen:
we expected, what "kubectl" noticed the change in spaces and applied it.
How to reproduce it (as minimally and precisely as possible):
deployment with mistake
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx-deployment
  labels:
    app: nginx
spec:
  replicas: 3
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
      - name: nginx
        image: nginx: 1.14.2
        ports:
        - containerPort: 80

fixed deployment
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx-deployment
  labels:
    app: nginx
spec:
  replicas: 3
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
      - name: nginx
        image: nginx:1.14.2
        ports:
        - containerPort: 80

Environment:

Kubernetes client and server versions (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.4", GitCommit:"d360454c9bcd1634cf4cc52d1867af5491dc9c5f", GitTreeState:"clean", BuildDate:"2020-11-11T13:17:17Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"linux/amd64"}
OS (e.g: cat /etc/os-release):

NAME="Ubuntu"
VERSION="18.04.3 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.3 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

Thanks for raising that issue @sobolevskaya-k.
I tested in on latest version(1.25) and it returned validation error for the yaml includes spaces. This problem seems to be fixed in newer versions.

/close


Thermostat HomeKit Display does not respect unit

Describe The Bug:
In the thermostat accessory settings, when the unit is changed to F, the HomeKit display does not respect it, the physical thermostat does however.
To Reproduce:
Choose a thermostat in the Home App, go to its accessory settings, change then unit to F and notice it's still in C in the home app display.
Expected behavior:
We expect the display to follow the chosen unit.

Same Issue here

@naftaly , @subdigital This is expected behavior. That unit setting can only control the units displayed on the physical thermostat (and Daikin app), not the Home app. To change how it displays in the Home app, you'll need to go to the iOS settings and change it there: Settings>General>Language&Region>Temperature


PooledMemory object as no attribute ptr

I'm trying to get spaCy working with CUDA backend, not too sure if it's an issue in Cupy or spaCy's Thinc backend:
Error points to: https://github.com/cupy/cupy/blob/bad41820a4247a4bf9871b58eda662c24f5b60cf/cupy/cuda/memory.pyx#L481
cupy, spacy and thinc build from master on Nov 17.
Traceback:
Created blank 'en' model
Loading IMDB data...
Using 2000 examples (1600 training, 400 evaluation)
Exception ignored in: <bound method PooledMemory.free of <cupy.cuda.memory.PooledMemory object at 0x7f363dd2d128>>
Traceback (most recent call last):
  File "cupy/cuda/memory.pyx", line 481, in cupy.cuda.memory.PooledMemory.free
AttributeError: 'PooledMemory' object has no attribute 'ptr'
Traceback (most recent call last):
  File "cupy/cuda/driver.pyx", line 72, in cupy.cuda.driver.check_status
cupy.cuda.driver.CUDADriverError: CUDA_ERROR_INVALID_VALUE: invalid argument

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "spacy_imdb_classification_gpu.py", line 132, in <module>
    plac.call(main)
  File "/usr/lib/python3.6/site-packages/plac_core.py", line 328, in call
    cmd, result = parser.consume(arglist)
  File "/usr/lib/python3.6/site-packages/plac_core.py", line 207, in consume
    return cmd, self.func(*(args + varargs + extraopts), **kwargs)
  File "spacy_imdb_classification_gpu.py", line 57, in main
    optimizer = nlp.begin_training(device=0) # GPU / Cuda training
  File "/usr/lib/python3.6/site-packages/spacy/language.py", line 456, in begin_training
    sgd=self._optimizer)
  File "pipeline.pyx", line 859, in spacy.pipeline.TextCategorizer.begin_training
  File "pipeline.pyx", line 778, in spacy.pipeline.TextCategorizer.Model
  File "/usr/lib/python3.6/site-packages/spacy/_ml.py", line 527, in build_text_classifier
    >> zero_init(Affine(nr_class, width, drop_factor=0.0))
  File "/usr/lib/python3.6/site-packages/thinc/api.py", line 296, in with_flatten
    model = layerize(begin_update, predict=predict)
  File "/usr/lib/python3.6/site-packages/thinc/api.py", line 74, in layerize
    return FunctionLayer(begin_update, predict=predict, *args, **kwargs)
  File "/usr/lib/python3.6/site-packages/thinc/api.py", line 22, in __init__
    Model.__init__(self)
  File "/usr/lib/python3.6/site-packages/thinc/neural/_classes/model.py", line 83, in __init__
    self._mem = Memory(self.ops)
  File "/usr/lib/python3.6/site-packages/thinc/neural/mem.py", line 13, in __init__
    self._mem = self.ops.allocate((2, size))
  File "ops.pyx", line 158, in thinc.neural.ops.Ops.allocate
  File "/usr/lib/python3.6/site-packages/cupy/creation/basic.py", line 146, in zeros
    a = cupy.ndarray(shape, dtype, order=order)
  File "cupy/core/core.pyx", line 95, in cupy.core.core.ndarray.__init__
  File "cupy/cuda/memory.pyx", line 441, in cupy.cuda.memory.alloc
  File "cupy/cuda/memory.pyx", line 915, in cupy.cuda.memory.MemoryPool.malloc
  File "cupy/cuda/memory.pyx", line 936, in cupy.cuda.memory.MemoryPool.malloc
  File "cupy/cuda/memory.pyx", line 693, in cupy.cuda.memory.SingleDeviceMemoryPool.malloc
  File "cupy/cuda/memory.pyx", line 759, in cupy.cuda.memory.SingleDeviceMemoryPool._malloc
SystemError: <class 'cupy.cuda.memory.PooledMemory'> returned a result with an error set

The test file is spaCy IMDB example modified for CuPy backend, i.e. https://github.com/explosion/spaCy/blob/c3051e95f718c4ff5983197e0bdaea691cd67ea2/examples/training/train_textcat.py#L58 changed from:
optimizer = nlp.begin_training() to optimizer = nlp.begin_training(device=0) according to https://github.com/explosion/spaCy/issues/1530

I'm sorry that we failed to respond :bow: As the issue seems out-dated, let me close this issue. Please feel free to reopen if needed. Thank you.


c-lib: parseSyntaxDictionaryEntry fails on Linux if "gs1-syntax-dictionary.txt" was checked out with \r\n line endings

If the file "gs1-syntax-dictionary.txt" was checked out with \r\n line endings under Linux. the function call parseSyntaxDictionaryEntry fails to parse the file with:
*** Failed to parse Syntax Dictionary file: gs1-syntax-dictionary.txt
*** Syntax Dictionary line 106: AI has wrong width

This seems to be due to strtok_r(linebuf, " \t", &saveptr); returning the \r character on Linux. On Windows there seems to be no issue either way.
It can be circumvented by inserting a comment char at the start of line 106 or checking out with Linux-style line endings.

@RemotelyChaotic Thanks for the report.


Update Broadcaster.java

Increase broadcast concurrency to avoid exceptions:
org.apache.kylin.job.exception.ExecuteException: org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:178)
at org.apache.kylin.job.impl.threadpool.DistributedScheduler$JobRunner.run(DistributedScheduler.java:111)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.kylin.job.exception.ExecuteException: java.lang.NullPointerException
at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:178)
at org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:69)
at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:163)
... 4 more
Caused by: java.lang.NullPointerException
at org.apache.kylin.source.hive.CreateFlatHiveTableStep.getCubeSpecificConfig(CreateFlatHiveTableStep.java:92)
at org.apache.kylin.source.hive.CreateFlatHiveTableStep.doWork(CreateFlatHiveTableStep.java:97)
at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:163)
... 6 more

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 4031

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 26.849%

Totals

Change from base Build 4025:
0.005%

Covered Lines:
18615

Relevant Lines:
69333

💛  - Coveralls

Codecov Report

Merging #427 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master     #427      +/-   ##
============================================
- Coverage     24.38%   24.38%   -0.01%
- Complexity     4937     4939       +2
============================================
  Files          1143     1143
  Lines         69331    69333       +2
  Branches       9879     9881       +2
============================================
  Hits          16906    16906
  Misses        50722    50722
- Partials       1703     1705       +2

Impacted Files
Coverage Δ
Complexity Δ

...g/apache/kylin/metadata/cachesync/Broadcaster.java
51.51% <33.33%> (-0.53%)
23 <0> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33edddf...ba75053. Read the comment docs.


Stop scdaemon if it is holding exclusive access to a YubiKey

Closes str4d/age-plugin-yubikey#82.

I tested this PR succesfully on Ubuntu 20.04 (against gpg --card-status) and Windows 11 (against Kleopatra's "Manage Smartcards" GUI).

Codecov Report

Merging #89 (15c53e4) into main (5d6b618) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main     #89      +/-   ##
========================================
- Coverage   1.33%   1.26%   -0.07%
========================================
  Files          6       6
  Lines        375     395      +20
========================================
  Hits           5       5
- Misses       370     390      +20

Impacted Files
Coverage Δ

src/key.rs
2.22% <0.00%> (-0.21%)
:arrow_down:

src/format.rs
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks a lot, I tested it on macOS 13.1 and can confirm that it works as expected!


You can check if a Dict belongs to a Table by using in

Coverage remained the same at 100.0% when pulling c67d7462e6b13f4e282e63813010bea7194ef369 on feature/table-contains into f8f22c18043229af4b046341736b06b807cfbe27 on master.


DRILL-4517: Support reading empty Parquet files

Modified flat and complex parquet readers to output schema only when requested number of records to read is 0. In this case readers are not initialized to improve performance.
Allowed reading requested number of rows instead of all rows in the row group (DRILL-6528).
Fixed issue with nulls number determination in the row group (fixed IsPredicate#isAllNulls method).
Allowed reading empty parquet files via adding empty / fake row group.
General refactoring and unit tests.

Jira - DRILL-4517.

@vvysotskyi thanks for the code review, addressed code review comments.


Update .pre-commit-config.yaml

Maybe you made this PR by error? In this repo, no dirs like in your regex

@IaroslavR  maybe you correct me here, what I wanted to do is to ignore the libs|scripts|modules folders and its content from this step,   is this the right way to do?

@IaroslavR
according to @amaalzohny , for viewer lambda, it did not exclude libs|scripts|modules. Is this not the right way to solve it?

@IaroslavR  @limcheehow  :
at viewer its already done here  https://github.com/tapway/terraform-aws-lambda-viewer/blob/de7b9fe88e57bdce7eac9e29d9dd934f02ea737d/.pre-commit-config.yaml#L19
but somehow it's not running  with me to exclude the libs folder ,
that's why i added this PR to the main ansible,
if it's not useful here, plz close the PR , or correct me

@amaalzohny precommit config should be run for each repo only. Don't think this plays any role whatsoever. If you talk about Github Actions to run precommit, you should update it here - https://github.com/tapway/terraform-aws-lambda-viewer/blob/de7b9fe88e57bdce7eac9e29d9dd934f02ea737d/.github/workflows/pre-commit.yml
Please go ahead and do it.