when second time enter the page,the payment button ,it will disappear,or can not  display.

When  i first click payment button is OK ，will enter login page ,but back to  home page ,second enter payment page，the  payment button is just loading ,and  can not display.

this is logcat shows

SDK Version 0.4.3

Hi @jcnoriega i can confirm that even with the latest sample project changing activity or fragment causes the button to be stuck in loading and then disappear

Hi @jcnoriega  I upgrade to 0.4.4 and it's still there.

this is log

me too, please help me @jcnoriega

The same error. plz fix it thank you

The same error. plz fix it thank you

The same error with more log

I was having the same issue until i downlgraded to 0.20 version
implementation'com.paypal.checkout:android-sdk:0.2.0'

Hi! Thank you so much for reporting. A pull request to fix this has been created and it will be included on the next release next week.
The bug happens when PayPalCheckout.setConfig() is called in the Application class. A quick workaround this, is to call setConfig() on the same activity that renders the PaymentButton.

Version 0.4.5 is deployed with the fix. Please confirm if issue persists


Correct UTF8 decoding via Decoder class

When TcpClientNetworkOperations reads data from TcpClient it uses UTF8 encoding. Current implementation uses Encoding.GetString() method to transform byte to string. This approach contains potential bug because UTF8 chars can be represented by several bytes. In such case they would be treated wrong. In this pull request we use Decoder class which can keep track of "partial symbols" and decode them without error.
I've tested suggested fix only with GMail which doesn't seem to use UTF8 symbols (I've tested using emails in Russian) but I think it's safer to use this approach just to avoid possible nasty encoding bugs.

Great!
Thks for the improvement in the reading process!


Use secure websockets (wss://)

Light clients in the browser need to connect to other nodes via websockets. Unfortunately, you can't use an insecure websocket on a secure (https://) page. To fix this, we should use secure websocket connections, and supply a security certificate. This default cert should be overridable. This will mostly require changes to jsonrpc/jsonrpsee.

The certificate needs to be good enough for a browser to accept connecting to it. Which means that every single full node would need to register a domain name and asks a certificate from a registrar.
That doesn't look very realistic to me.

Yeah, we were considering that in the past as well, but to be honest it's much easier (and safer) to just document how to set up a reverse proxy that terminates ssl in front of the node than to implement it with all needed details.

Closing because this probably isn't achievable.


add '--client-certificate some.pem' to authenticate a site user to the remote machine

Checklist

[X] I'm reporting a feature request
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS> (update instructions) or later (specify commit)
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
Some sites offer the feature of higher format downloads to selected users with a certificate.pem
Verbose log
No response

Related https://github.com/ytdl-org/youtube-dl/pull/29590

Related ytdl-org/youtube-dl#29590

I'm thinking we implement this within the SSLContext
https://docs.python.org/3/library/ssl.html?highlight=ssl#ssl.SSLContext.load_cert_chain
Think we might also need options for:

providing password to decrypt private key (if required)
private key file (if it is not included in the certfile. though upstream PR makes the requirement they must be combined, not sure if we should do this same).


Create Binary Search.cpp

Hello sir, please assign this issue to me as i already worked on it in past.


Enable support for TensoRT 10.5

This change include following commit:
https://github.com/microsoft/onnxruntime/pull/22374

Hey Misha!
Observing that the pipeline run has introduced new test failures. Is this related to the cherry pick change?

Hey Misha! Observing that the pipeline run has introduced new test failures. Is this related to the cherry pick change?

These failures are not related to current change.


bug fix for setting up remote route from linux

attempting to resolve issue #66 (or dereiative of)
The simple solution appears to be to swap hostname and route_name, this works for TWINCAT 3.1.3024. and 3022. However I don't have TWINCAT 2 or 3.1.3020 so not sure how this will affect that.
@Adrian-at-CrimsonAuzre I'm not sure your thoughts on this? What version of TwinCat did you implement in?
possibly Beckhoff they have switched these bytes around?
Does anyone know how we would tell what version of TwinCat is running?

Pull Request Test Coverage Report for Build 274

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.806%

Totals

Change from base Build 271:
0.0%

Covered Lines:
2163

Relevant Lines:
2382

💛  - Coveralls

Pull Request Test Coverage Report for Build 274

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.806%

Totals

Change from base Build 271:
0.0%

Covered Lines:
2163

Relevant Lines:
2382

💛  - Coveralls

Pull Request Test Coverage Report for Build 274

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.806%

Totals

Change from base Build 271:
0.0%

Covered Lines:
2163

Relevant Lines:
2382

💛  - Coveralls

thanks for such a quick response @Adrian-at-CrimsonAuzre, I shall maybe at some point have a look at #75 to see if I can get something to work for both TC2 and TC3 but I'm the other way to you, I've not access to TC2 ha

Sorry for my absence, just changed jobs...however that has given me access to TC2 and I can confirm that this fix works for me on TC2, TC3 4022 and 4024.

Could you please rebase your PR on the current master branch and add a changelog entry?

I'll take a look at this shortly.

one sec, accident...

sorry, when I squashed, I forgot I had already pushed to a remote, so it caused a merge error, I handled this incorrectly and accidentally pushed all the old commits into my remote. So had to correct this, hence the new PR.


TEPHRA-263 Enforce TTL, regardless of any in-progress transactions.

https://issues.apache.org/jira/browse/TEPHRA-263
Instead of filtering data that is older than tx.getVisibilityUpperBound - TTL, we now filter data that is tx.getTransactionId - TTL.
This PR also makes two additional changes:

A large TTL (50 years, for instance) previously caused an exception since HBase start timestamps can not be negative.
TTL is now more accurately applied for TransactionVisibilityFilter, where readNonTxnData is true.

I'll apply the diff to the other hbase compat modules once these changes pass review.

LGTM from my side, please wait for @poornachandra 's opinion, too, for the last commit.

Got LGTM on changes for 1 compat module, so squashed commits.

Changes look the same to me in all modules. LGTM

Squshed commmits.


TypeError: clean() got an unexpected keyword argument 'styles'

clean of bleach does not have styles but why it is passing here I do not understand! return bleach.clean(             value, tags=ALLOWED_TAGS, attributes=ATTRIBUTES, styles=STYLES)
Below is the clean of bleach:
def clean(     text,     tags=ALLOWED_TAGS,     attributes=ALLOWED_ATTRIBUTES,     protocols=ALLOWED_PROTOCOLS,     strip=False,     strip_comments=True,     css_sanitizer=None, ):

I am using an older version of the bleach library. To resolve the issue, I uninstalled it and then reinstalled version 4.1.0 using the command
pip install bleach==4.1.0

An alternative to pinning to an older version of bleach is to re-implement the summernote field using bleach's updated API:
import bleach
from bleach.css_sanitizer import CSSSanitizer
from django.forms import fields
from django_summernote import settings as summernote_settings
from django_summernote.widgets import SummernoteWidget

class RichTextField(fields.CharField):
    def __init__(self, *args, **kwargs):
        kwargs.update({"widget": SummernoteWidget()})
        super().__init__(*args, **kwargs)

    def to_python(self, value):
        value = super().to_python(value)

        return bleach.clean(
            value,
            attributes=summernote_settings.ATTRIBUTES,
            css_sanitizer=CSSSanitizer(allowed_css_properties=summernote_settings.STYLES),
            tags=summernote_settings.ALLOWED_TAGS,
        )

Bleach no longer accepts the style argument, and instead accepts a css_sanitizer argument.
This is most likely what the SummernoteFormTextField would like once updated

In PR #499, bleach was replaced by nh3.


chore: fix CI failures

Fixes a few compilation errors, test failures and linting warnings from master due to the mat- switch.

Can you rebase?


Cannot use structs as inputs to circuit in TypeScript

Aim
An external developer wanted to pass a struct into the circuit using TS. Example JSON input:
{
  "values": [
    90, 20, 30, 90, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
    0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
  ],
  "query": {
    "slot": 3,
    "operator": 1,
    "thresholds": [90, 20, 30, 90, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
  },

  "signatureData": {
    "hashed_message": [
      84, 112, 91, 163, 186, 175, 219, 223, 186, 140, 95, 154, 112, 247, 168, 155, 238, 152, 217, 6,
      181, 62, 49, 7, 77, 167, 186, 236, 220, 13, 169, 173
    ],
    "pub_key_x": [
      77, 75, 108, 209, 54, 16, 50, 202, 155, 210, 174, 185, 217, 0, 170, 77, 69, 217, 234, 216, 10,
      201, 66, 51, 116, 196, 81, 167, 37, 77, 7, 102
    ],
    "pub_key_y": [
      42, 62, 173, 162, 208, 254, 32, 139, 109, 37, 124, 235, 15, 6, 66, 132, 102, 46, 133, 127, 87,
      182, 107, 84, 193, 152, 189, 49, 13, 237, 54, 208
    ],
    "signature": [
      100, 235, 162, 94, 185, 111, 28, 107, 66, 168, 87, 57, 125, 222, 85, 114, 140, 61, 161, 105,
      140, 229, 209, 158, 178, 38, 160, 164, 142, 171, 167, 202, 46, 231, 34, 171, 10, 190, 86, 37,
      238, 245, 49, 189, 207, 208, 54, 107, 61, 247, 167, 163, 157, 86, 108, 223, 78, 8, 252, 169,
      61, 158, 6, 42
    ]
  }
}

Expected behavior
Expected the proof to be generated correctly
Bug
The prover fails with "unknown object type in abi". Apparently, the old npm packages use a completely separate ABI encoding instead of the encodings in noirc_abi
To reproduce

Create a circuit that expects a Struct as an input
Pass a JSON to the prover in JS, with the required structure

Installation method
None
Nargo version
No response
@noir-lang/noir_wasm version
0.3.2-bcdfd526
@noir-lang/barretenberg version
github:noir-lang/barretenberg#39a1547875f941ef6640217a42d8f34972425c97
@noir-lang/aztec_backend version
0.1.0-0c3b2f2
Additional context
No response
Submission Checklist

[X] Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.

This is unrelated to https://github.com/noir-lang/aztec_backend/issues/97. That issue is just for defining more compact representations of the program's ABI whereas this is due to the old TS packages not doing proper ABI encoding and falling behind nargo.

Closing this issue as https://github.com/noir-lang/acvm-simulator (which will form the basis of the new typescript packages) has parity with rust ABI encoding.


Add some additional rendering options from xmlbuilder to the documentation

There are two newer rendering options on xmlBuilder. Adding them to the documentation for xml2js to surface them explicitly for users of xml2js
See https://github.com/oozcitak/xmlbuilder-js/wiki#converting-to-string

Coverage remained the same at 97.633% when pulling dee520fc4605c6be16f96d43a9ecb2fd3f5e715b on abd3:master into e8540dcafaa115484543d8016df39dca8a18d245 on Leonidas-from-XIV:master.

Coverage remained the same at 97.633% when pulling dee520fc4605c6be16f96d43a9ecb2fd3f5e715b on abd3:master into e8540dcafaa115484543d8016df39dca8a18d245 on Leonidas-from-XIV:master.

Coverage remained the same at 97.633% when pulling dee520fc4605c6be16f96d43a9ecb2fd3f5e715b on abd3:master into e8540dcafaa115484543d8016df39dca8a18d245 on Leonidas-from-XIV:master.

Coverage remained the same at 97.633% when pulling dee520fc4605c6be16f96d43a9ecb2fd3f5e715b on abd3:master into e8540dcafaa115484543d8016df39dca8a18d245 on Leonidas-from-XIV:master.

This needs to be also added in /lib/defaults.js.
When can we expect this to be merged?


UI: Dashboard shows incorrect count of virtual routers

ISSUE TYPE
BUG
Component Name
UI
CLOUDSTACK VERSION
Cloudstack version 4.19
SUMMARY
UI: Dashboard shows incorrect count of virtual routers
Steps to reproduce the issue

Create a Project

Change into project view and launch a vpc network  and make sure the virtual router is running

Change back to default view , Launch a isolated network , make sure the router is running for the network

Click on Dashboard, you will see the count of virtual routers will be 1. The virtual routers associated with a project are not shown

Cloudstack is executing the following api here
https://cloudstack.apache.org/api/apidocs-4.19/apis/listRouters.html

The issue is not observed if the user clicks on  Infrastructure > Summary

Cloudstack is executing the following api here
https://cloudstack.apache.org/api/apidocs-4.19/apis/listInfrastructure.html
Actual Behaviour
Admin user should  is not seeing the correct count of virtual routers
Expected Behaviour
Admin user should see the correct the count of virtual routers

Fixed by https://github.com/apache/cloudstack/pull/8807


fix: storage class name

In default ARO 4.12 setup the name of the storage class is managed-csi, not managed-premium

Thanks @pysiekytel, we're still seeing a lot of clusters not having the csi-drivers yet however. Suggest we take these as a separate variant so each env can pick which ever makes the most sense.


CP-21805: ContainsEdge() with UndirectedGraph not recognizing reverse direction

From unknown CodePlex user on Saturday, 19 November 2011 20:30:46
Hi all!

This may be a problem:

var g = new UndirectedGraph<int, UndirectedEdge>();

g.AddVerticesAndEdge(new UndirectedEdge(1, 2));

var c = g.ContainsEdge(2, 1); // false

The last line returns false, however since this is an undirected graph, IMHO should really return true. Am I wrong?

Form unknown CodePlex user on Friday, 13 January 2012 09:12:11
Any new whether you want to fix this? Thanks.

Form unknown CodePlex user on Monday, 25 June 2012 16:20:10
I would appreciate a solution as well.

Form unknown CodePlex user on Friday, 23 May 2014 12:10:13
As far as I can tell, adding an undirected edge to an undirected graph has precisely the same effect as adding a directed edge to a directed graph.  Is there any way at all that the QuickGraph UndirectedGraph reflects the mathematical definition of an undirected graph?


Clicking 'Open skills page for configuration details' disables menu options

Describe the bug

This loads the skill configuration page, but i cannot figure out how to get out of it without restarting Composer. Menu options are disabled:

Version
nightly

Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

Additional context
Navigating to skills settings directly, works fine.

@EricDahlvang Thanks for reporting! As part of the Multibot expansion work we are doing in R11, we are planning to remove the skills page. Subsequently that link to the skills page was recently removed in #4207.
https://github.com/microsoft/BotFramework-Composer/pull/4207/files#diff-709a57c1f9ba4c513dd93b40c9620ecaL142.


Add support for Shelly smart meters

System export examples are required for systems with shelly smart meter configured.
The responses must be evaluated whether all info is compatible with Anker smart meter provided info.
When the exports are done with the main account, it may be required to export a snapshot at various situations, e.g.

during grid export in smart meter mode
during import in smart meter mode
using manual mode while shelly is installed

Example export in https://github.com/thomluther/ha-anker-solix/issues/152

Verified that all fields are filled correctly with Shelly smart meter.
Only device name is not provided via Api.
Proper/default device name per model type will be added in a future release with #145


AttributeError: module 'sqlmodel.sql.sqltypes' has no attribute 'GUID'

I get the following error when trying to run either poetry run createdb or poetry run runserver.
❯ poetry run createdb
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/byronrode/.pyenv/versions/3.12.3/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/Users/byronrode/Code/Personal/Python/moutaineer-test/moutaineer_test/cli.py", line 5, in <module>
    from mountaineer.migrations.cli import handle_apply, handle_generate, handle_rollback
  File "/Users/byronrode/Library/Caches/pypoetry/virtualenvs/moutaineer-test-EcWe_Swf-py3.12/lib/python3.12/site-packages/mountaineer/migrations/cli.py", line 14, in <module>
    from mountaineer.migrations.generator import MigrationGenerator
  File "/Users/byronrode/Library/Caches/pypoetry/virtualenvs/moutaineer-test-EcWe_Swf-py3.12/lib/python3.12/site-packages/mountaineer/migrations/generator.py", line 15, in <module>
    from mountaineer.migrations.db_memory_serializer import DatabaseMemorySerializer
  File "/Users/byronrode/Library/Caches/pypoetry/virtualenvs/moutaineer-test-EcWe_Swf-py3.12/lib/python3.12/site-packages/mountaineer/migrations/db_memory_serializer.py", line 13, in <module>
    from mountaineer.migrations.handlers import (
  File "/Users/byronrode/Library/Caches/pypoetry/virtualenvs/moutaineer-test-EcWe_Swf-py3.12/lib/python3.12/site-packages/mountaineer/migrations/handlers.py", line 589, in <module>
    sa.UUID | sqltypes.GUID | sa.Float | sa.String | sa.Boolean | sa.Integer | sa.JSON
              ^^^^^^^^^^^^^
AttributeError: module 'sqlmodel.sql.sqltypes' has no attribute 'GUID'

I used the quickstart pipx run create-mountaineer-app
This happens both with the Docker version of Postgres, as well as with my actual Postgres.app.
Poetry Version: 1.8.3
Python Version: 3.12.3

Packages

Hi @byronrode, this should be addressed in the latest dev release at https://github.com/piercefreeman/mountaineer/releases/tag/v0.5.2.dev1. It was caused by an internal change that SQLModel used to align with the new postgres conventions.
Let me know if you still see it in the latest version. There should be a fully baked new 0.6.0 with more functionality and this fix coming soon.

Thanks @piercefreeman - installing the dev version worked. Appreciate the update.

@byronrode This is now launched in stable 0.6.0, alongside with some other nice-to-haves around typehinting:
https://github.com/piercefreeman/mountaineer/releases/tag/v0.6.0

Amazing. I'll remove the pin to dev over the weekend.


rust: 1.60.0 -> 1.61.0

Description of changes
nix-build -p fd passes on x86_64-linux
Waiting for Firefox and Thunderbird.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I started an aarch64 build

Building & testing both firefox and thunderbird.

I started an aarch64-linux build as well.

firefox and thunderbird are fine on x86_64-linux

Built fd on x86_64-darwin.

Haven't checked any of these on master; all are darwin-aarch64. First tranche:
bsnes-hd-10.6-beta:
Error: builder for '/nix/store/rizpmhl6zqk2nql21ak8hq8iqln418v1-bsnes-hd-10.6-beta.drv' failed with exit code 2;
       last 10 log lines:
       >     ^~~~~~~~~~~~
       >     Application
       > ../hiro/core/application.hpp:2:8: note: 'Application' declared here
       > struct Application {
       >        ^
       > fatal error: too many errors emitted, stopping now [-ferror-limit=]
       > 20 errors generated.
       > make: *** [../hiro/GNUmakefile:73: obj/hiro-gtk3.o] Error 1

g-ario:
error: builder for '/nix/store/m6690w3bbshd5n3m7l6ci11w9g851l7g-ario-1.6.drv' failed with exit code 2;
       last 10 log lines:
       >       _ario_filesystem_init in ario-filesystem.o
       > ld: symbol(s) not found for architecture arm64
       > clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
       > make[3]: *** [Makefile:492: libfilesystem.la] Error 1
       > make[3]: Leaving directory '/private/tmp/nix-build-ario-1.6.drv-0/ario-1.6/plugins/filesystem'

cargo-watch:
error: builder for '/nix/store/jff549glvi4rh4543y5z935r8v1q367x-cargo-watch-8.1.2.drv' failed with exit code 101;
       last 10 log lines:
       >   cargo:warning=8 errors generated.
       >   exit status: 1
       >
       >   --- stderr
       >
       >
       >   error occurred: Command "/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-fmodules" "-o" "/private/tmp/nix-build-cargo-watch-8.1.2.drv-0/source/target/aarch64
-apple-darwin/release/build/mac-notification-sys-ecb4ee1922ea5572/out/objc/notify.o" "-c" "objc/notify.m" with args "cc" did not execute successfully (status code exit status: 1).

coq8.15-InfSeqExt, and indeed large tracts of coq which just seems extremely borked:
error: builder for '/nix/store/hb3kpbnh4hhfhy4171g6bg91jp49abfr-coq8.15-InfSeqExt-20200131.drv' failed with exit code 2;
       last 10 log lines:
       > patching sources
       > updateAutotoolsGnuConfigScriptsPhase
       > configuring
       > patching script interpreter paths in ./configure
       > ./configure: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/lkw407y1x1v5bg6hc290c5ry1qaabbgl-bash-5.1-p16/bin/bash"
       > configure flags: --prefix=/nix/store/jsd7bf802fapdzbk2srgpv2r4ahr3p2k-coq8.15-InfSeqExt-20200131
       > building
       > build flags: -j10 -l10 SHELL=/nix/store/lkw407y1x1v5bg6hc290c5ry1qaabbgl-bash-5.1-p16/bin/bash
       > coq_makefile -f _CoqProject -o Makefile.coq
       > make: *** [Makefile:17: Makefile.coq] Killed: 9

Lighthouse:
error: builder for '/nix/store/jp798jjyayzjb0sdcmasa9yarqpr3g1s-Lighthouse-unstable-2021-03-28.drv' failed with exit code 101;
       last 10 log lines:
       > warning: unused import: `Peripheral`
       >  --> src/main.rs:1:38
       >   |
       > 1 | use btleplug::api::{BDAddr, Central, Peripheral, WriteType};
       >   |                                      ^^^^^^^^^^
       >
       > Some errors have detailed explanations: E0412, E0433.
       > For more information about an error, try `rustc --explain E0412`.
       > warning: `lighthouse` (bin "lighthouse") generated 2 warnings

MozWire:
error: builder for '/nix/store/qc1s4r54br04xjjiz2wp37n02kg7n6ih-MozWire-0.7.0.drv' failed with exit code 101;
       last 10 log lines:
       >   ^
       >   /private/tmp/nix-build-MozWire-0.7.0.drv-0/MozWire-0.7.0-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:403:1: error: unknown directive
       >   .size GFp_aes_hw_ctr32_encrypt_blocks,.-GFp_aes_hw_ctr32_encrypt_blocks
       >   ^
       >   /private/tmp/nix-build-MozWire-0.7.0.drv-0/MozWire-0.7.0-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:407:19: error: unexpected token in '.section' directive
       >   .section .note.GNU-stack,"",%progbits
       >                     ^
       >   thread 'main' panicked at 'execution failed', /private/tmp/nix-build-MozWire-0.7.0.drv-0/MozWire-0.7.0-vendor.tar.gz/ring/build.rs:664:9
       >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

elfcat:
error: builder for '/nix/store/47mrd63jml82bcj4axbr6wg81h8bhgyz-elfcat-0.1.7-vendor.tar.gz.drv' failed with exit code 1;
       last 10 log lines:
       > configuring
       > no configure script, doing nothing
       > building
       > There is no dependency to vendor in this project.
       > Traceback (most recent call last):
       >   File "/nix/store/vnifbm7k6jxf3r0r2a7gpwp7ihsp9dw7-cargo-vendor-normalise/bin/.cargo-vendor-normalise-wrapped", line 42, in <module>
       >     main()
       >   File "/nix/store/vnifbm7k6jxf3r0r2a7gpwp7ihsp9dw7-cargo-vendor-normalise/bin/.cargo-vendor-normalise-wrapped", line 17, in main
       >     assert list(data.keys()) == ["source"]
       > AssertionError

cargo-generate:
error: builder for '/nix/store/xd6gikpdzfwvrgfmncy5bysigwznaxpv-cargo-generate-0.12.0.drv' failed with exit code 101;
       last 10 log lines:
       >     = note: consider importing this function:
       >             std::env::args
       >
       >    Compiling liquid-core v0.23.2
       >    Compiling liquid-lib v0.23.1
       >    Compiling git2 v0.13.25
       >    Compiling liquid v0.23.1
       > For more information about this error, try `rustc --explain E0425`.
       > error: could not compile `rhai` due to 47 previous errors
       > warning: build failed, waiting for other jobs to finish...

cobalt:
error: builder for '/nix/store/9hfd8v743228cpq09ssd2hb2m6r3vw5g-cobalt-0.17.5.drv' failed with exit code 101;
       last 10 log lines:
       >   cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_aarch64_apple_darwin
       >   cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
       >   cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
       >   cargo:rustc-link-search=native=/private/tmp/nix-build-cobalt-0.17.5.drv-0/source/target/aarch64-apple-darwin/release/build/sass-sys-8ce8ec035831d48e/out/build/lib
       >   cargo:rustc-link-lib=static=sass
       >
       >   --- stderr
       >   thread 'main' panicked at 'no c++ library found', /private/tmp/nix-build-cobalt-0.17.5.drv-0/cobalt-0.17.5-vendor.tar.gz/sass-sys/build.rs:80:9

eccodes:
error: builder for '/nix/store/1iwvgxbcm8p4zy9vlhdk83c1xxkfjlxg-eccodes-2.24.2.drv' failed with exit code 1;
       last 10 log lines:
       >
       >   CMake will not be able to correctly generate this project.
       > Call Stack (most recent call first):
       >   cmake/ecbuild_enable_fortran.cmake:46 (enable_language)
       >   CMakeLists.txt:144 (ecbuild_enable_fortran)
       >
       >
       > -- Configuring incomplete, errors occurred!

alfis:
error: builder for '/nix/store/3zxl3bvij93zm7lz4f4najlm9ck1wbp0-alfis-0.7.3.drv' failed with exit code 101;
       last 10 log lines:
       >   cargo:warning=20 errors generated.
       >   exit status: 1
       >
       >   --- stderr
       >
       >
       >   error occurred: Command "/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "webview.h" "-Wall" "-Wextra" "-x" "objective-c" "-std=c11" "-w" "-DDEBUG" "-DOBJ
C_OLD_DISPATCH_PROTOTYPES=1" "-o" "/private/tmp/nix-build-alfis-0.7.3.drv-0/source/target/aarch64-apple-darwin/release/build/webview-sys-74e297695eb3c632/out/webview_cocoa.o" "-c" "webview_cocoa.c" with args "cc" did not execute successfully (status code exit statu
s: 1).

gbl:
error: builder for '/nix/store/03wjypdfs7bhipfzxfa9sjh6qzk087hs-gbl-0.3.1.drv' failed with exit code 101;
       last 10 log lines:
       >   ^
       >   /private/tmp/nix-build-gbl-0.3.1.drv-0/gbl-0.3.1-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:223:1: error: unknown directive
       >   .type GFp_aes_hw_ctr32_encrypt_blocks,%function
       >   ^
       >   /private/tmp/nix-build-gbl-0.3.1.drv-0/gbl-0.3.1-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:402:1: error: unknown directive
       >   .size GFp_aes_hw_ctr32_encrypt_blocks,.-GFp_aes_hw_ctr32_encrypt_blocks
       >   ^
       >   thread 'main' panicked at 'execution failed', /private/tmp/nix-build-gbl-0.3.1.drv-0/gbl-0.3.1-vendor.tar.gz/ring/build.rs:638:9
       >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

geoclue:
error: builder for '/nix/store/kqcmv39idy6cxwpf2i7scmi23gzwmwfn-geoclue-2.5.7.drv' failed with exit code 1;
       last 10 log lines:
       > [71/76] Generating demo/geoclue-where-am-i.desktop with a custom command
       > [72/76] Compiling C object demo/agent.p/meson-generated_.._.._interface_geoclue-agent-interface.c.o
       > [73/76] Compiling C object demo/agent.p/gclue-service-agent.c.o
       > FAILED: demo/agent.p/gclue-service-agent.c.o
       > clang -Idemo/agent.p -Idemo -I../demo -I. -I.. -Ipublic-api -I../public-api -Iinterface -I/nix/store/c5ch1qzhd6vhiy1cdzjyj9siwchn90k1-glib-2.72.1-dev/include/glib-2.0 -I/nix/store/vclpi6g4pcwxnsiigiyqch2pgwsvyyg9-glib-2.72.1/lib/glib-2.0/include -I/nix/sto
re/c5ch1qzhd6vhiy1cdzjyj9siwchn90k1-glib-2.72.1-dev/include -I/nix/store/c5ch1qzhd6vhiy1cdzjyj9siwchn90k1-glib-2.72.1-dev/include/gio-unix-2.0 -I/nix/store/b59z7z3sa17zg3p492wb37790qykqin0-libnotify-0.7.12-dev/include -I/nix/store/gsyr8dyxyg7fkwpzc63j676w8j5f0s1s-g
dk-pixbuf-2.42.8-dev/include/gdk-pixbuf-2.0 -fcolor-diagnostics -Wall -Winvalid-pch -O0 -MD -MQ demo/agent.p/gclue-service-agent.c.o -MF demo/agent.p/gclue-service-agent.c.o.d -o demo/agent.p/gclue-service-agent.c.o -c ../demo/gclue-service-agent.c
       > ../demo/gclue-service-agent.c:26:10: fatal error: 'gio/gdesktopappinfo.h' file not found
       > #include <gio/gdesktopappinfo.h>
       >          ^~~~~~~~~~~~~~~~~~~~~~~
       > 1 error generated.
       > ninja: build stopped: subcommand failed.

dotter:
error: builder for '/nix/store/2hys10lkn5vphyp3395zj7pi7c6r02s9-dotter-0.12.10.drv' failed with exit code 101;
       last 10 log lines:
       >    --> /private/tmp/nix-build-dotter-0.12.10.drv-0/dotter-0.12.10-vendor.tar.gz/rhai/src/packages/math_basic.rs:539:62
       >     |
       > 539 | gen_conversion_as_functions!(num_128_to_int => to_int (i128, u128) -> INT);
       >     |                                                              ^^^^ not found in this scope
       >     |
       >     = note: consider importing this function:
       >             std::env::args
       >
       > For more information about this error, try `rustc --explain E0425`.
       > error: could not compile `rhai` due to 47 previous errors

gssdp:
error: builder for '/nix/store/4yr9z967ss06rapmsadbgfsql0v9v2h4-gssdp-<IP_ADDRESS>.drv' failed with exit code 1;
       last 10 log lines:
       > Expected Fail:      0
       > Fail:               1
       > Unexpected Pass:    0
       > Skipped:            0
       > Timeout:            0
       >
       > Full log written to /private/tmp/nix-build-gssdp-<IP_ADDRESS>.drv-0/gssdp-<IP_ADDRESS>/build/meson-logs/testlog.txt
       > FAILED: meson-test
       > /nix/store/k0kx1w6k5q9nsaabjkx1jzky2an6fvmm-meson-0.61.2/bin/meson test --no-rebuild --print-errorlogs
       > ninja: build stopped: subcommand failed.

dotenv-linter:
error: builder for '/nix/store/5gc6nk01mzkdckp03mcg8c5x81gfyalj-dotenv-linter-3.2.0.drv' failed with exit code 101;
       last 10 log lines:
       >    Compiling update-informer v0.2.0
       >    Compiling dotenv-linter v3.2.0 (/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source)
       > error: linking with `/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc` failed: exit status: 1
       >   |
       >   = note: "/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc" "-arch" "arm64" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/aarch64-apple-darwin/release/deps/dotenv_linter-11c79816badd5ec2.dotenv_linter.21a199c0-cgu.
0.rcgu.o" "-L" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/aarch64-apple-darwin/release/deps" "-L" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/release/deps" "-L" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target
/aarch64-apple-darwin/release/build/ring-09384eed980ec2c8/out" "-L" "/nix/store/3s9l3yn4zzhz1i9vs0j6zmbvlipal3yh-rustc-1.61.0/lib/rustlib/aarch64-apple-darwin/lib" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/rustckSCCmY/libring-432b2b54ba9542e2.rlib" "/nix/st
ore/3s9l3yn4zzhz1i9vs0j6zmbvlipal3yh-rustc-1.61.0/lib/rustlib/aarch64-apple-darwin/lib/libcompiler_builtins-2c3a0cc128bcaaa8.rlib" "-framework" "Security" "-liconv" "-lSystem" "-lresolv" "-lc" "-lm" "-liconv" "-L" "/nix/store/3s9l3yn4zzhz1i9vs0j6zmbvlipal3yh-rustc-
1.61.0/lib/rustlib/aarch64-apple-darwin/lib" "-o" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/aarch64-apple-darwin/release/deps/dotenv_linter-11c79816badd5ec2" "-Wl,-dead_strip" "-nodefaultlibs"
       >   = note: ld: framework not found Security
       >           clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
       >
       >
       > error: could not compile `dotenv-linter` due to previous error

gurk-rs:
error: builder for '/nix/store/6yl80wmv6paa5ykw2rf36b3i6mjpvcgb-gurk-rs-0.2.3.drv' failed with exit code 101;
       last 10 log lines:
       >   cargo:warning=1 error generated.
       >   exit status: 1
       >
       >   --- stderr
       >
       >
       >   error occurred: Command "/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-fmodules" "-o" "/private/tmp/nix-build-gurk-rs-0.2.3.drv-0/source/target/aarch64-app
le-darwin/release/build/mac-notification-sys-734da0cc56354164/out/objc/notify.o" "-c" "objc/notify.m" with args "cc" did not execute successfully (status code exit status: 1).

jsonwatch:
error: builder for '/nix/store/rj16ijakbqnjkfwgncnq1cxz5750m5d7-jsonwatch-0.6.0.drv' failed with exit code 101;
       last 10 log lines:
       >   ^
       >   /private/tmp/nix-build-jsonwatch-0.6.0.drv-0/jsonwatch-0.6.0-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:223:1: error: unknown directive
       >   .type GFp_aes_hw_ctr32_encrypt_blocks,%function
       >   ^
       >   /private/tmp/nix-build-jsonwatch-0.6.0.drv-0/jsonwatch-0.6.0-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:402:1: error: unknown directive
       >   .size GFp_aes_hw_ctr32_encrypt_blocks,.-GFp_aes_hw_ctr32_encrypt_blocks
       >   ^
       >   thread 'main' panicked at 'execution failed', /private/tmp/nix-build-jsonwatch-0.6.0.drv-0/jsonwatch-0.6.0-vendor.tar.gz/ring/build.rs:643:9
       >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

jetbrains-jdk:
error: builder for '/nix/store/rj16ijakbqnjkfwgncnq1cxz5750m5d7-jsonwatch-0.6.0.drv' failed with exit code 101;
       last 10 log lines:
       >   ^
       >   /private/tmp/nix-build-jsonwatch-0.6.0.drv-0/jsonwatch-0.6.0-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:223:1: error: unknown directive
       >   .type GFp_aes_hw_ctr32_encrypt_blocks,%function
       >   ^
       >   /private/tmp/nix-build-jsonwatch-0.6.0.drv-0/jsonwatch-0.6.0-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:402:1: error: unknown directive
       >   .size GFp_aes_hw_ctr32_encrypt_blocks,.-GFp_aes_hw_ctr32_encrypt_blocks
       >   ^
       >   thread 'main' panicked at 'execution failed', /private/tmp/nix-build-jsonwatch-0.6.0.drv-0/jsonwatch-0.6.0-vendor.tar.gz/ring/build.rs:643:9
       >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

(darwin-aarch64)
Lua:
error: builder for '/nix/store/x4lc9133ypkc2y311gnkkkwmixi5qf4s-lua-2.1.0.drv' failed with exit code 1;
       last 10 log lines:
       > No pkg-config found
       > Using runghc version 9.0.2 found on system at:
       > /nix/store/hba3lasnwfq1ibhdvf3kjxcm8fb1b75s-ghc-9.0.2/bin/runghc
       > Using strip found on system at:
       > /nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/strip
       > Using tar found on system at:
       > /nix/store/xvl9fyl923ac1h2m19hb9qcvg06ia00l-gnutar-1.34/bin/tar
       > No uhc found
       > building
       > Preprocessing library for lua-2.1.0..

Luarocks:
error: builder for '/nix/store/hxj1i98a2rb5z9qpd3y02bgy7dmdadr7-luarocks-3.8.0.drv' failed with exit code 2;
       last 10 log lines:
       > mkdir -p .luarocks
       > cp ./build/config-.lua .luarocks/config-.lua
       > rm -f src/luarocks/core/hardcoded.lua
       > echo "#!/bin/sh" > luarocks
       > echo "unset LUA_PATH LUA_PATH_5_2 LUA_PATH_5_3 LUA_PATH_5_4 LUA_CPATH LUA_CPATH_5_2 LUA_CPATH_5_3 LUA_CPATH_5_4" >> luarocks
       > echo 'LUAROCKS_SYSCONFDIR="/nix/store/m2kif3dkmm350f5x8cf98zk02r6krpq5-luarocks-3.8.0/etc/luarocks" LUA_PATH="/private/tmp/nix-build-luarocks-3.8.0.drv-0/source/src/?.lua;;" exec "/nix/store/wd8hrv7ddw7ls82hmy1bssj5ilgyi90p-lua-5.1.5/bin/lua" "/private/tmp
/nix-build-luarocks-3.8.0.drv-0/source/src/bin/luarocks" --project-tree="/private/tmp/nix-build-luarocks-3.8.0.drv-0/source/lua_modules" "$@"' >> luarocks
       > chmod +rx ./luarocks
       > ./luarocks init
       > make: *** [GNUmakefile:57: luarocks] Killed: 9
       > make: *** Deleting file 'luarocks'

a52dec:
error: builder for '/nix/store/2sv4c9r6fa06ni7s6sbgrvw8fkdk4295-a52dec-0.7.4.drv' failed with exit code 2;
       last 10 log lines:
       >     a52dec.o
       >     ../libao/libao.a(audio_out_peak.o)
       > duplicate symbol '___sputc' in:
       >     a52dec.o
       >     ../libao/libao.a(audio_out_peak.o)
       > ld: 28 duplicate symbols for architecture arm64
       > clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
       > make[1]: *** [Makefile:210: a52dec] Error 1
       > make[1]: Leaving directory '/private/tmp/nix-build-a52dec-0.7.4.drv-0/a52dec-0.7.4/src'
       > make: *** [Makefile:152: all-recursive] Error 1

mate-menus:
error: builder for '/nix/store/rkqw1ymvcfy6wsd7530ibk6riys9783x-mate-menus-1.26.0.drv' failed with exit code 2;
       last 10 log lines:
       > In file included from desktop-entries.c:23:
       > ./desktop-entries.h:24:10: fatal error: 'gio/gdesktopappinfo.h' file not found
       > #include <gio/gdesktopappinfo.h>
       >          ^~~~~~~~~~~~~~~~~~~~~~~
       > 1 error generated.
       > make[2]: *** [Makefile:556: desktop-entries.lo] Error 1
       > make[2]: Leaving directory '/private/tmp/nix-build-mate-menus-1.26.0.drv-0/mate-menus-1.26.0/libmenu'
       > make[1]: *** [Makefile:465: all-recursive] Error 1
       > make[1]: Leaving directory '/private/tmp/nix-build-mate-menus-1.26.0.drv-0/mate-menus-1.26.0'
       > make: *** [Makefile:397: all] Error 2

mikutter:
error: builder for '/nix/store/1q00cvw2gjfmda100yf45iv0d7px32fa-mikutter-4.1.4.drv' failed with exit code 137;
       last 10 log lines:
       > post-installation fixup
       > rewriting symlink /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4/Applications/mikutter.app/Contents/MacOS/mikutter to be relative to /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4
       > strip is /nix/store/bi8ya5scc3305x4wa4nay5gmvriq4pxv-cctools-port-949.0.1/bin/strip
       > stripping (with command strip and flags -S) in /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4/bin
       > patching script interpreter paths in /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4
       > /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4/opt/mikutter/core/miku/miku.rb: interpreter directive changed from "#! /usr/bin/ruby" to "/nix/store/qnqacjkzxmzkwhbvn45a3cz05yywjiqk-wrapped-ruby-mikutter-gems/bin/ruby"
       > /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4/opt/mikutter/.mikutter.rb-wrapped: interpreter directive changed from "#!/bin/sh" to "/nix/store/lkw407y1x1v5bg6hc290c5ry1qaabbgl-bash-5.1-p16/bin/sh"
       > /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4/opt/mikutter/test.rb: interpreter directive changed from "#! /usr/bin/ruby" to "/nix/store/qnqacjkzxmzkwhbvn45a3cz05yywjiqk-wrapped-ruby-mikutter-gems/bin/ruby"
       > running install tests
       > /nix/store/3zqj93rzxlff2945pn58wwdd6g5v655q-stdenv-darwin/setup: line 1386: 53481 Killed: 9               $out/bin/mikutter --confroot="$testDir" --plugin=test_plugin --debug

freeciv:
error: builder for '/nix/store/gjab97jzhmgapr96az83nkr0951rnsz7-freeciv-2.6.6.drv' failed with exit code 2;
       last 10 log lines:
       > clang-11: error: linker command failed with exit code 137 (use -v to see invocation)
       > make[4]: *** [Makefile:641: tolua] Error 137
       > make[4]: Leaving directory '/private/tmp/nix-build-freeciv-2.6.6.drv-0/source/dependencies/tolua-5.2/src/bin'
       > make[3]: *** [Makefile:610: all-recursive] Error 1

@Smaug123 many of these packages don't even depend on Rust. Sorry but this is just not useful at all.
I would rather not block this for a long time because of aarch64-darwin failures. If anyone can deliver actually useful failure reports on aarch64-darwin we could keep 1.60 packaged and as default for aarch64-darwin.
Otherwise I would merge this as-is.

Fair enough; there are a few Rust ones in there, but they can presumably be cleared up after the fact.

Useful would be "x does build on master but does not build with this change". If you can re-test all of these on master and filter out those that also fail there we could actually derive some meaning from it.

Certainly, I was intending to do this all over again on master afterwards, but this PR takes many days to build; my M1 Max has been maxed out for two days now, so "afterwards" is not yet.
(For what it's worth, the number of times I've been rescued by random snippets of nix build traces on apparently unrelated GitHub issues makes me strongly prefer to default to putting them somewhere, and there's not really any official place to do it.)

The official place for build failures that are not related to any PR would be creating a seperate issue for that (title could be "lua does not build on aarch64-darwin").
Maybe do each package on master first, and then if it builds on master test it on this branch?  That could save you a lot of build time, because you don't even have to attempt to build those that already failed on master with this PR. And prevents noise in the PR.

There is also nix-review, which determines by evaluation which packages are affected by this change and only builds those.

This is nix-review in action, by the way.

Ah, then this might be because this branch is based on staging, but nix-review compared to master?

nixpkgs-review's docs say that it "will merge the pull request into the pull request's target branch (most commonly master)", and it's definitely working against staging because the most recent commit in ~/.cache/nixpkgs-review/pr-173631 is https://github.com/NixOS/nixpkgs/commit/aac2235e79c449667b357e83c1b0b934ca299799 . But 🤷

A friend reports that fd builds fine from this PR on aarch64-darwin

This is the ones which work on master darwin-aarch64 but were broken according to nixpkgs-review, and which appear to be Rust-related. Apparently I can't hide the above comments containing the ones which are broken on master, or which nix-review thinks are newly broken but don't appear to be Rust-related.
Ignore if desired.
elfcat (works on master):
error: builder for '/nix/store/47mrd63jml82bcj4axbr6wg81h8bhgyz-elfcat-0.1.7-vendor.tar.gz.drv' failed with exit code 1;
       last 10 log lines:
       > configuring
       > no configure script, doing nothing
       > building
       > There is no dependency to vendor in this project.
       > Traceback (most recent call last):
       >   File "/nix/store/vnifbm7k6jxf3r0r2a7gpwp7ihsp9dw7-cargo-vendor-normalise/bin/.cargo-vendor-normalise-wrapped", line 42, in <module>
       >     main()
       >   File "/nix/store/vnifbm7k6jxf3r0r2a7gpwp7ihsp9dw7-cargo-vendor-normalise/bin/.cargo-vendor-normalise-wrapped", line 17, in main
       >     assert list(data.keys()) == ["source"]
       > AssertionError

cargo-generate (works on master):
error: builder for '/nix/store/xd6gikpdzfwvrgfmncy5bysigwznaxpv-cargo-generate-0.12.0.drv' failed with exit code 101;
       last 10 log lines:
       >     = note: consider importing this function:
       >             std::env::args
       >
       >    Compiling liquid-core v0.23.2
       >    Compiling liquid-lib v0.23.1
       >    Compiling git2 v0.13.25
       >    Compiling liquid v0.23.1
       > For more information about this error, try `rustc --explain E0425`.
       > error: could not compile `rhai` due to 47 previous errors
       > warning: build failed, waiting for other jobs to finish...

dotter:
error: builder for '/nix/store/2hys10lkn5vphyp3395zj7pi7c6r02s9-dotter-0.12.10.drv' failed with exit code 101;
       last 10 log lines:
       >    --> /private/tmp/nix-build-dotter-0.12.10.drv-0/dotter-0.12.10-vendor.tar.gz/rhai/src/packages/math_basic.rs:539:62
       >     |
       > 539 | gen_conversion_as_functions!(num_128_to_int => to_int (i128, u128) -> INT);
       >     |                                                              ^^^^ not found in this scope
       >     |
       >     = note: consider importing this function:
       >             std::env::args
       >
       > For more information about this error, try `rustc --explain E0425`.
       > error: could not compile `rhai` due to 47 previous errors

dotenv-linter (works on master):
error: builder for '/nix/store/5gc6nk01mzkdckp03mcg8c5x81gfyalj-dotenv-linter-3.2.0.drv' failed with exit code 101;
       last 10 log lines:
       >    Compiling update-informer v0.2.0
       >    Compiling dotenv-linter v3.2.0 (/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source)
       > error: linking with `/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc` failed: exit status: 1
       >   |
       >   = note: "/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc" "-arch" "arm64" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/aarch64-apple-darwin/release/deps/dotenv_linter-11c79816badd5ec2.dotenv_linter.21a199c0-cgu.
0.rcgu.o" "-L" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/aarch64-apple-darwin/release/deps" "-L" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/release/deps" "-L" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target
/aarch64-apple-darwin/release/build/ring-09384eed980ec2c8/out" "-L" "/nix/store/3s9l3yn4zzhz1i9vs0j6zmbvlipal3yh-rustc-1.61.0/lib/rustlib/aarch64-apple-darwin/lib" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/rustckSCCmY/libring-432b2b54ba9542e2.rlib" "/nix/st
ore/3s9l3yn4zzhz1i9vs0j6zmbvlipal3yh-rustc-1.61.0/lib/rustlib/aarch64-apple-darwin/lib/libcompiler_builtins-2c3a0cc128bcaaa8.rlib" "-framework" "Security" "-liconv" "-lSystem" "-lresolv" "-lc" "-lm" "-liconv" "-L" "/nix/store/3s9l3yn4zzhz1i9vs0j6zmbvlipal3yh-rustc-
1.61.0/lib/rustlib/aarch64-apple-darwin/lib" "-o" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/aarch64-apple-darwin/release/deps/dotenv_linter-11c79816badd5ec2" "-Wl,-dead_strip" "-nodefaultlibs"
       >   = note: ld: framework not found Security
       >           clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
       >
       >
       > error: could not compile `dotenv-linter` due to previous error

aarch64-linux and aarch64-darwin can build fd.

Regarding cargo-generate, we should first try if simply upgraded to https://github.com/cargo-generate/cargo-generate/releases/tag/v0.13.1 fixes the build again.

elfcat looks like the vendoring in buildRustPackage is broken. The code run there is before any rustc binary is involved.

cargo-generate: /cc maintainer @turboMaCk
Parent PR: #175150


[BugFix] ignore star mgr's OP_STARMGR journal write only in submitLog

Why I'm doing:
What I'm doing:
do not check whether global state mgr is leader when writes star mgr's journal
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

https://github.com/StarRocks/starrocks/pull/45968，branch-3.2

https://github.com/StarRocks/starrocks/pull/45962, branch-3.1


Operator (OLM) 1.4 fails installing on Openshift - webhook failed to update certificate from disk

So far we were using the operator 1.1 from the redhat certified operator catalog, but as we encountered dfferences with the expiry date of CertManager and the real expiry of the certificate (checked via openssl), we thought it would be good to update to the latest image (in hope this was fixed).
So, we tried to install the operator 1.4 via the Openshift Operator catalouge (OLM) - from the community operators.
1st difference is, that there is not operator instance CR needed, but all the available objects are 2-3 times listes in the OLM overview (seems to be another bug of the operator)
The operator container gets deployed, and spinns up 3 additional containers:
cert-manager
cert-manager-cainjector
cert-manager-webhook
the webhook pod gets never healthy, as it fails with the error listed below.
We retried it on another cluster as well, but same behaviour.
Was tested on Openshift OKD 4.6
Describe the bug:
cert-manager-webhook pod fails to get healthy.
E0809 20:47:26.508937       1 file_source.go:101] cert-manager/webhook "msg"="failed to update certificate from disk" "error"="failed to read keyPath: open /tmp/k8s-webhook-server/serving-certs/tls.key: no such file or directory"  "failures"=3
I0809 20:47:29.707969       1 server.go:408] cert-manager/webhook "msg"="Health check failed as CertificateSource is unhealthy"

Expected behaviour:
Sucessfull deployment of CertManager operator from community operator catalog
Steps to reproduce the bug:
In the Openshift operator catalog, select community-operators and click install of certManager 1.4 for all namespaces
Anything else we need to know?:
Environment details::

Kubernetes version: Openshift OKD 4.6
Cloud-provider/provisioner: AWS
cert-manager version: 1.4
Install method: Operator OLM

I have found the problem in the code:
https://github.com/jetstack/cert-manager-olm/blob/471685559b7d753527006e731cee6bb7f72d927c/github.com/operator-framework/community-operators/1.4.3/manifests/cert-manager.clusterserviceversion.yaml#L680-L681
                - --tls-cert-file=/tmp/k8s-webhook-server/serving-certs/tls.crt                 - --tls-private-key-file=/tmp/k8s-webhook-server/serving-certs/tls.key
according to this site:
https://olm.operatorframework.io/docs/advanced-tasks/adding-admission-and-conversion-webhooks/
, for backword compatibilty following should use instead:

@dan1el-k @timroster @miminar Apologies for not replying sooner.
I'm really struggling to create an OpenShift 4.6 cluster to recreate this. CRC 1.22 gives me a 4.6 cluster where the community-operators catalog is broken:

https://github.com/code-ready/crc/issues/2827

I have however checked that the cert-manager community-operator works in OpenShift 4.7, 4.8, and 4.9.
Because those newer versions do mount the  /tmp/k8s-webhook-server/serving-certs/ directory.
And I've checked that the backwards compatible path is still mounted in OpenShift 4.9, it appears that it is.

So it should be safe for me to change the mount path, as you suggested, and the community-bundle should then work with 4.6,4.7,4.8 and 4.9
I will try and make this change before the next community-operators release.


try fix can not open new page again when show bottomsheet，#1523

#1523
this issue still exists in 4.6.1, I tried to fix this bug, after testing it was fixed

@jonataslaw Please check this BUG and look forward to fixing it.


Generate sitemap with CLI

Currently it seems like /sitemap.xml is a dynamic route that the Nuxt server resolves rather than an actual file. This might be fine for most use cases but for example on Vercel this will resolve to a 404 page, issue: https://github.com/nuxt-modules/sitemap/issues/256
It would be nice if the sitemap can be generated as a file in the build step by CLI, e.g. nuxt build && nuxt-sitemap generate. This would fix the issue above.

Hi, sorry for the delay.
I'm not exactly sure what is going on with Vercel Edge that it doesn't work, but you should just be able to add the sitemap path to the pretender routes and it will generate it statically.
export default defineNuxtConfig({
  nitro: {
    prerender: {
      routes: ['/sitemap.xml']
    }
  }
})

I'm happy to enable the static generation by default on Vercel if you can make a minimal reproduction.


Is there a SQL-Script for mySQL existing?

I have 3 printers and i want to use one database for all spools.
mySQL is installed on a Windows PC, spoolman on RPI.
.env is created:
DB Type: sqlite, mysql, postgresql, cockroachdb
Default if not set: sqlite
SPOOLMAN_DB_TYPE=mysql
DB Setup, if not using sqlite
SPOOLMAN_DB_HOST=192.168.1.xx
SPOOLMAN_DB_PORT=3306
SPOOLMAN_DB_NAME=spoolman
SPOOLMAN_DB_USERNAME=
SPOOLMAN_DB_PASSWORD_FILE=
SPOOLMAN_DB_PASSWORD=
SPOOLMAN_DB_QUERY=mysql
Logging level: DEBUG, INFO, WARNING, ERROR, CRITICAL
Default if not set: INFO
SPOOLMAN_LOGGING_LEVEL=DEBUG
Automatic nightly backup for SQLite databases
Default if not set: TRUE
SPOOLMAN_AUTOMATIC_BACKUP=TRUE
Host and port to listen on
SPOOLMAN_HOST=<IP_ADDRESS>
SPOOLMAN_PORT=7912
when i test the mysql client "mysql -u  -p -h 192.168.1.xx spoolman" it works fine.
But there is no table created during installation.
Is there a script existing for manually installation of tables and columns?

The tables should be added automatically when spoolman starts. If they don't you have some connection issue. See the spoolman logs if you got any errors

where do i find the logs?

Seems like it's crashing over and over. Try setting the LOGGING_LEVEL env variable to debug and see if you see any further errors

i have done, spoolman stopped, changed .env, spoolman started, same log entries
2023-10-29 10:48:46:INFO:Starting Spoolman v0.13.1 (commit: None) (built: None)
2023-10-29 10:48:46:INFO:Setting up database...
2023-10-29 10:48:50:INFO:Starting Spoolman v0.13.1 (commit: None) (built: None)
2023-10-29 10:48:50:INFO:Setting up database...
2023-10-29 10:48:54:INFO:Starting Spoolman v0.13.1 (commit: None) (built: None)
2023-10-29 10:48:54:INFO:Setting up database...
2023-10-29 10:48:58:INFO:Starting Spoolman v0.13.1 (commit: None) (built: None)
2023-10-29 10:48:58:INFO:Setting up database...
2023-10-29 10:49:02:INFO:Starting Spoolman v0.13.1 (commit: None) (built: None)
2023-10-29 10:49:02:INFO:Setting up database...

I got it via daemon.log
It tells me : ValueError: bad query field: 'mysql'
What should I use for the query?

Ah I didn't even notice you had that set. You should probably leave it empty if you don't know what it's for.
I also think you need to setup a user in your database and fill that in the USERNAME and PASSWORD env vars.

I have done, you can see at the beginning of this messages, I only blanked it to show the rest
The mySQL server is not running on the rpi but on a windows pc

now it created the database tables but the another error appeared:
Oct 29 15:25:37 raspberrypi start.sh[16602]: INFO:     Application startup complete.
Oct 29 15:25:37 raspberrypi start.sh[16602]: ERROR:    [Errno -2] Name or service not known

got it finally.
the entries must be commented, not only kept empty.
Hope it could help others too
Thank you very much for your time :)


fix(deployment): exposed service doesn't propagate namespace (#882)

Backport
This will backport the following commits from k8s-24/main to k8s-22/main:

fix(deployment): exposed service doesn't propagate namespace (#882)

Questions ?
Please refer to the Backport tool documentation

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 886

Questions ?
Please refer to the Backport tool documentation


Remove Prometheus metrics from the operator

Which Issue(s) this Pull Request Resolves

Resolves #325
Release Note

NONE

Notes for Reviewers

Given that we are using OpenTelemetry metrics and not Prometheus metrics, instead of replacing the RBAC proxy which is meant to protect the Prometheus endpoint that the operator offered we just remove the whole Prometheus endpoint.

Isn't there another issue dealing with the RBAC proxy?

Isn't there another issue dealing with the RBAC proxy?

I don't think we have another GitHub issue that references the RBAC proxy.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/92601

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/93825

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/94917

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/111277

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114447


chat example using flutter and superstate ?

Seems like a logical architecture marriage ?

This is in progress, just haven't had time yet!
But this is meant to be framework agnostic, so it could work with anything. Super State is just one example of a state management framework which it would work with

ok thanks. Will close this as that answers my question


Consider providing safetensor files

Long story short, I'd love to try your model and finetune it for my work but I outright can't without compromising company policy (as loading pickle files is unsafe). I believe in the long run there will be many more people with similar problems.
In theory, one could load the file in a sandboxed VM and then export the safetensor file themselves but that's a large hurdle for adoption.
Would you consider uploading safetensor files to huggingface too?

The latest one but it looks like safetensors are there already. I'll close the issue


ANSYS-HSD_V1 is invalid

🔍 Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

🐞 Description of the bug
The solder mask dielectric is 0.
📝 Steps to reproduce
Check the EDB stackup. Run the example in PyAedt 14_edb_create_parameterized_design.py. The simulation model is not valid.
💻 Which operating system are you using?
Windows
📀 Which ANSYS version are you using?
23R2
🐍 Which Python version are you using?
3.10
📦 Installed packages
All dev packages are installed.

This looks like an issue with the specific example. The original EDB is valid. I will close this issue.


Update dependencies

Feature: Develop EV3Dev-lang-java

    Scenario: Update dependencies
        Given Latest development of ev3dev-lang-java
        Then It is necessary to upgrade dependencies

Report:
https://www.versioneye.com/user/projects/58ff6d856ac171426c4147eb

Fixed


Update allocator.md

@astronautthis , @Gala-G
Please take a look

I think this looks fine, once you're happy it's no longer draft feel free to merge


If user doesn’t exists still hitting endpoint

With ref to issue #194  if user doesn’t exists on db and still tries to hit the hit the url should be redirected to login page
Adding a check for user in code

I think this is fixed now


Feature request: Add "--option" as a supported argument passed to nix-build

I think the title pretty much explains the feature I would like to request.
My personal usecase for this is specifying the builders that will be used, however I imagine this should be useful for a multitude of other things.

I'm not certain I understand what you are looking for. Please update the title to include information about where you would like to have --option, what you would expect it to do, and ideally also a could of examples.

Right,I  hope the following explains what I would like to see:
What
Most, nix commands (eg. nix-build, nix-env, nix) support a --option argument. Using it many lower-level nix-related options like which builders to use, whether to build in the sandbox, ..., can be configured.
Full reference in the nix manual
Where
Nix allows this flag before and after positional arguments, so I think it would make sense to mimic that behavior.
Examples
home-manager --option builders '' switch # build everything locally
home-manager --option cores 1 switch # use only one core for building

Thanks for the clarification! I think this should be fixed now.


Add metrics tracking number of recently loaded crates/versions/platforms

These metrics are intended to be useful for evaluating changes for #1004. Knowing how many different crates get accessed over short timespans could help us know things like the potential memory cost of keeping cached indexes around short term.
I'm not sure what the performance impact of these might be in production. The most likely issue would be a large memory usage if the number of different platforms requested per-hour is very high, leading to a lot of small strings kept around to track these.
(based on #1017, so to review the lockfile changes look at the last commit in isolation)

The most likely issue would be a large memory usage if the number of different platforms requested per-hour is very high, leading to a lot of small strings kept around to track these.

We already run high at about 5 GB in prod. I find it hard to think the number of crate/version/platform pairs would take up anything close to that, do you have a guesstimate for 'lot of small strings'?

I think we can avoid the problem with strings by not storing them at all. My understanding is we don't care about the crate names/versions, so we can just store i32s:

For crates we could map the crate ID with the instant.
For versions we could map the release ID with the instant.
For targets we could map (release ID, interned target name) with the instant.

When you get a chance, please rebase over master so the diff no longer shows up as 1500 lines changed ;)

Other than Joshua's comments, this looks good to me!

Looks good to me after a rebase :)


az webapp up reads in the SKU as an int, but then calls string methods on it.

This is autogenerated. Please review and update as needed.
Describe the bug
I was following this tutorial and was ready to deploy.
When I deployed, the az CLI had trouble parsing the SKU
Command Name
az webapp up
Errors:
'int' object has no attribute 'upper'
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 206, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 603, in execute
    raise ex
cli/core/commands/__init__.py, ln 661, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 652, in _run_job
    cmd_copy.exception_handler(ex)
...
cli/command_modules/appservice/custom.py, ln 2993, in webapp_up
    create_app_service_plan(cmd, rg_name, plan, _is_linux, False, sku, 1 if _is_linux else None, location)
cli/command_modules/appservice/custom.py, ln 1390, in create_app_service_plan
    sku = _normalize_sku(sku)
cli/command_modules/appservice/utils.py, ln 20, in _normalize_sku
    sku = sku.upper()
AttributeError: 'int' object has no attribute 'upper'

The last line of the error is strange, as I used "F1" as the SKU, which I figured would be parsed as a string. I also tried "FREE" per the MS Docs
To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

az configure --default location="West US 2"
az webapp up --sku F1 -n {myappname}

("myappname" is just a place holder. I did try to use "F1" as the sku though)
Expected Behavior
Expected the small web app to be deployed to the a free tier
Environment Summary
Linux-4.4.0-18362-Microsoft-x86_64-with-debian-buster-sid
Python 3.6.5
Shell: bash

azure-cli 2.0.76

Additional Context
None

This is a known issue with the latest version of CLI we have a new build with the fix that will roll out in the mean time you can use the following version
pip intall azure-cli==2.0.75

Fixed by https://github.com/Azure/azure-cli/pull/11019

thanks @panchagnula !

For anyone else who comes across this, here's how to downgrade on Ubuntu/Debian:
sudo apt-get update
sudo apt-get install -y --allow-downgrades azure-cli=2.0.75-1~stretch

also btw the changes are merged to dev so feel free to use the edge builds https://github.com/Azure/azure-cli#edge-builds

Please update to the latest version of CLI https://pypi.org/project/azure-cli/ version 2.0.77 and re-try. there was a known regression with version 2.0.76


Request for IDAGIO support

Thank you for the extension. Please add support also for IDAGIO, because it seems like audio ads there cannot be blocked in other ways.

I just published a new release with IDAGIO support. I didn't know this site, very cool.
As of now, only Firefox has the latest version published in their Webstore, but it shouldn't take too long for the other browsers to catch up.
I did some testing for an hour or so and all ads were successfully muted.
Nevertheless, please do your own tests as well, and create a new issue if you encounter any problems.
Thanks.

It works, thank you.


CLOUDSTACK-9298: Improve performance of resource retrieval that have tags associated and target volumes, VMs and templates

JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9298
Description of the problem
When retrieving a large number of resources which have tags associated with, retrieval methods took too long. Our goal is to improve performance of this methods avoiding query the database for each tag, managing that information in memory.
API methods to improve: listTemplates, listVolumes, listVirtualMachines
To achive it, it's necessary to include new columns in template_view, volume_view and user_vm_view:

tag_account_name
tag_domain_name
tag_domain_uuid

@nvazquez ,
Lines 191-195 and 261-265 are duplicated, could you extract it to a method? And maybe even document it.
At the “ResourceTagJoinVO”, why did you create that new constructor?
Additionally, have you tested that view select? It looks ok, but I did not check clause per clause.

Hi @rafaelweingartner,
Sure, I changed it to a method and added javadoc to it.
I added the new constructor at ResourceTagJoinVO to set all that fields in a single call instead of many setter methods. Which way could be better?
Yes, I tested template_view and it retrieves data.
Thanks,
Nicolas

@nvazquez, nice changes.
So, I guess that a test cases for these new methods will be important to detect future changes in these methods behavior.
Another thing, is this new constructor really necessary? do you use this constructor in any part of the code? or do you just created this constructor to improve future codes calling only this constructor instead of lots of setters as you said?
In my opinion, a constructor with many params is a bit ugly, I prefer to use no params in the constructor and use some factory pattern to create this object (lots of setters called inside a factory class), this is just my opinion.
Ty.

Hi @pedro-martins thanks for your comments!
About test cases you mean unit tests or an integration test for this changes?
I planned to use that constructor in similar methods which lists volumes, templates and vms, but I can remove it and follow your suggestion

@nvazquez
I mean unit tests for each new method.
I think that use the Builder to get an instance with all variables initialized is a good way.
Thanks.

@nvazquez and @pedro-martins,
I am ok with the code now, expect the constructor bit.
The question you should ask about the constructor is, is it used NOW? If not, why create it. In the future when the need appear, we can create it; this way we can avoid unused code that may be left aside and never used.
Additionally, I am with @pedro-martins, if you like, tests cases would be pretty welcome here.

@rafaelweingartner @pedro-martins thanks for your comments! I deleted the constructor and used setters instead and not included the Builder pattern, but if you want I can include it.
I also included unit tests for new methods.

@nvazquez I have reviewed your code.
Class “VolumeJoinDaoImpl” at line 46, why did you change the get Logger method to use “VolumeJoinDaoImplTest”?
The method “updateTemplateTagInformation” is duplicated (I would say triplicated) at “VolumeJoinDaoImpl”, “UserVmJoinDaoImpl” and “TemplateJoinDaoImpl”. I know, you may argue that the method “updateTemplateTagInformation” has a conditional in “TemplateJoinDaoImpl” and “VolumeJoinDaoImpl”; still, that conditional is executed with some additional checks in “UserVmJoinDaoImpl”. The point here is that you should let that conditional out of the method scope, and then extract the method to a place that can be reused in all of those classes. All of them (VolumeJoinDaoImpl, UserVmJoinDaoImpl, and TemplateJoinDaoImpl) extend “GenericDaoBase” class. You can easily create a new class that extend “GenericDaoBase”, with that “updateTemplateTagInformation” and make all of those classes extend this new one. Please, keep that in mind in your next PRs.
That same is happening for VolumeJoinVO, UserVmJoinVO, and TemplateJoinVO classes. All of them have attributes “tagAccountName”, “tagDomainUuid” and “tagDomainName” and their respective getters and setters. They all extend “BaseViewVO”, you can do that same trick I mentioned you above here.
Now about the tests. First, when writing tests, you should ask yourself, “What am I going to test?”, “If this method changes the behavior would I like to catch it?”, “What is the behavior I want to monitor the behavior of?”. Those are the basic questions.
I believe your tests, should test the method “updateTemplateTagInformation” that you wrote. So, what do you want to detect if that method stops setting a property? Do you want to detect if it sets a property in a wrong place? If you want that, your tests now are not adequate, if you do not want that, you should delete the tests classes.
I personally believe that the method deserves tests, to check if it is working as expected. Meaning, that it sets the properties you want in the right place.
Additionally, when writing tests try to code as little as possible. Variables “accountService” and “configDao” are not needed to test the “updateTemplateTagInformation”; keep in mind that is a unit test. To test “updateTemplateTagInformation” you only need a simple instance of “TemplateJoinDaoImpl” and a mock of “ApiDBUtils.newResourceTagResponse(vtag, false)”

@rafaelweingartner @pedro-martins I followed your suggestions and made a big refactor, hope this would be better now. I'm planning to run integration tests and post the results later.
Thanks!

@nvazquez.
Could you squash all of yours commits into one? It's hard to compare the original code with your current modifications. If you do not know how to squash here goes a link with a little tutorial

@pedro-martins Sure, I'll push some changes that @rafaelweingartner pointed out and squash them all into one

Done @pedro-martins

Hi @rafaelweingartner @pedro-martins,
I see continuous integration check is still failing due to this error, I made some changes in setup/db/db/schema-481to490.sql:
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on project cloud-developer: An exception occured while executing the Java class. null: InvocationTargetException: Unable to upgrade the database: Unable to execute upgrade script: /home/travis/build/apache/cloudstack/developer/target/db/db/schema-481to490.sql: Access denied; you need (at least one of) the SUPER privilege(s) for this operation -> [Help 1]

@nvazquez the code is ok now.
I believe the problems you are having are due to lines 27, 28 and 29; I think you can remove them.

Thanks @rafaelweingartner
I removed those lines but still not working:
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on project cloud-developer: An exception occured while executing the Java class. null: InvocationTargetException: Unable to upgrade the database: Unable to execute upgrade script: /home/travis/build/apache/cloudstack/developer/target/db/db/schema-481to490.sql: Table 'user_vm_view' already exists -> [Help 1]

Now the error changed.
It is in another table and probably is not related to your work.
Now the problem is with "user_vm_view"
Could you track who added that to the script?
On Fri, Mar 11, 2016 at 7:01 AM, Nicolas Vazquez<EMAIL_ADDRESS>wrote:

Thanks @rafaelweingartner https://github.com/rafaelweingartner
I removed those lines but still not working:
[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:java (create-schema) on project
cloud-developer: An exception occured while executing the Java class. null:
InvocationTargetException: Unable to upgrade the database: Unable to
execute upgrade script:
/home/travis/build/apache/cloudstack/developer/target/db/db/schema-481to490.sql:
Table 'user_vm_view' already exists -> [Help 1]
—
Reply to this email directly or view it on GitHub
https://github.com/apache/cloudstack/pull/1425#issuecomment-195303532.

--
Rafael Weingärtner

@rafaelweingartner it was my mistake, I had writen user_vm__view instead of user_vm_view on the script. I fixed it and pushed again

@nvazquez now everything seems ok
Could you run integration tests?

I post my test results for test_vm_lifecycle.py
[root@ussarlabcsmgt41 cloudstack]# nosetests --with-marvin --marvin-config=setup/dev/advanced.cfg test/integration/smoke/test_vm_life_cycle.py

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /tmp//MarvinLogs//Mar_11_2016_08_59_15_NX2IH0. All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
===final results are now copied to: /tmp//MarvinLogs/test_vm_life_cycle_QS5H2K===

[root@ussarlabcsmgt41 cloudstack]# cat /tmp/MarvinLogs/test_vm_life_cycle_QS5H2K/results.txt
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Tests for basic zone virtual router ... === TestName: test_basicZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
ok
Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
ok
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
ok
Test for attach and detach ISO to virtual machine ... === TestName: test_10_attachAndDetach_iso | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 12 tests in 858.458s

OK

@nvazquez thanks for running the functional tests...
I was wondering, is there any Marvin tests for templates and volumes (backup, creation and others)?
Because your changes also affect them.

Hi @rafaelweingartner, I also ran test/integration/smoke/test_templates.py, I post its results:
[root@ussarlabcsmgt41 cloudstack]# cat /tmp/MarvinLogs/test_templates_LRM26P/results.txt
Test create public & private template ... === TestName: test_01_create_template | Status : SUCCESS ===
ok
Test when createTemplate is used to create templates having the same name all of them get ... === TestName: test_CreateTemplateWithDuplicateName | Status : SUCCESS ===
ok
Test Edit template ... === TestName: test_02_edit_template | Status : SUCCESS ===
ok
Test delete template ... === TestName: test_03_delete_template | Status : SUCCESS ===
ok
Test for extract template ... === TestName: test_04_extract_template | Status : SUCCESS ===
ok
Update & Test for template permissions ... === TestName: test_05_template_permissions | Status : SUCCESS ===
ok
Test for copy template from one zone to another ... SKIP: Not enough zones available to perform copy template
Test only public templates are visible to normal user ... === TestName: test_07_list_public_templates | Status : SUCCESS ===
ok
Test System templates are not visible to normal user ... === TestName: test_08_list_system_templates | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 9 tests in 5671.295s

OK

@nvazquez that is great. I can give an LGTM now.

Thanks @rafaelweingartner!
@pedro-martins could you review the last changes?

@nvazquez, Nice changes, great job refactoring your implementation. I found no more troubles in this PR, then LGTM.
Ty.

Great!!! 2 LGTM received. Can we have this merged?

I guess so, if no one objects.
The code was extensively reviewed, test cases (unit ones) were written, functional test were executed. For me this PR is ready to be merged. I would be able to do that latter today.

Did we run the whole BVT test suite on it as well?  I see a few integration test run, but not many.  If we think it is ready to go, I can merge it in...

I am running tests against real hardware right now for this.  Assuming everything goes will I will merge it right after.  Thx...

ok thanks ;)

Testing my first PR with my shiny new CI environment.  :P

Out of curiosity, is it running automatically testing all of the opened PRs?
Curiosity 2, is it real hardware or a buble?

I have to manually kick off the PRs for now, I have not automated it yet.  Still getting going.
It is deployed as hypervisor on hypervisor using bubble, so it is running against a physical environment.  Does that answer your question?

Sure it answered ;)

I am hoping to get things more automated as I get more comfortable with everything, but I just had to get something in place so I can start getting through this PR backlog and start getting stuff merged in.

That is cool. This will certainly be a great benefit to our community.
What are the resources (CPU, memory, HD) requirements to run this appliance?

Minimal
CPU Intel 4 core 64-bit processor with virtualization extensions
RAM 16GB
HDD 20GB
Recommended
CPU Intel Skylake 4 core 64-bit processor with virtualization extensions
RAM 32GB
SSD 20GB (root) + 100GB (data)
SBP has kindly open sourced all of their work on this, so checkout the following links.  If you have questions, ping the dev list and I will try to make sure your questions are answered.
Setup an environment from scratch without an existing chef server:
https://github.com/MissionCriticalCloud/bubble-blueprint
The above link runs this cookbook:
https://github.com/MissionCriticalCloud/bubble-cookbook
This sets up the environment for you.  Once that is setup, you can use the following to configure ACS environments and run tests:
https://github.com/MissionCriticalCloud/bubble-toolkit

nice thanks

My tests verified that this was ready to merge.  Merged...

@swill Congrats on the first bubble-tested PR :-) I would recommend posting the results though, the results.txt file shows which tests were run. If later we want to check, it's documented here.

Yes I meant to post the results, but I was too quick trying to get thing setup for the next run and I blew away my environment.  :(  Im a noob...  I will be posting the results going forward.


clamav: fix build break

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Fix build break in clamav:
ERROR - CMake Error at cmake/FindSYSTEMD.cmake:123 (message):
INFO -   SYSTEMD_UNIT_DIR was defined but pkg-config was not able to find systemd!

Change Log

Fix build break in clamav

Does this affect the toolchain?

NO
Test Methodology

Pipeline build id: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=552474&view=results

Note: the tests are broken, but this is not a regression. The tests are failing in the same manner on 2.0 as well.


Check if branch protection is enabled

this is an example using github graphql
{
repository(owner: "dworac", name: "cli") {
description
branchProtectionRules(first: 10) {
nodes {
lockBranch
id
pattern
allowsForcePushes
allowsDeletions
isAdminEnforced
restrictsPushes
requiresCodeOwnerReviews
}
}
}
}


Update anchor.md

Job d2l-zh/PR-834/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-834/

Job d2l-zh/PR-834/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-834/


Remove NamedIndividuals section if non present

Fixed in commit https://github.com/RDFLib/pyLODE/commit/f119f3a8095d1752236b4607025d3b7343a3f1e8


Migrating chain-mon from optimism

Description
Migrating chain-mon from optimism
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata

Fixes #[Link to Issue]

Just wondering if there are any updates on this getting merged

Following up here, just wondering the status of this

What is the status here? I am also really looking forward to this migration out of the mono-repo.

Following up on this as there are some nice CI improvements to speed things up in the protocol monorepo once this is merged and we can remove it from the protocol monorepo

Going to close this PR as we are not going to merge chain-mon in monitorism.


[ICON REQUEST] - Banano

I tried adding these via a PR myself but I'm getting issues with bun run add-icons command so I figured I should just open an icon request. There are 2 sets of icons one for BAN one for BANANO unfortunately because some exchanges decided to give our ticker away to some other very new project. However, our ticker is still BAN on CMC. The SVGs are SVGO optimized and fitted to the icon grid you shared.
BAN - Branded

BAN - Mono

BANANO - Branded

BANANO - Mono

Here is the project home page for reference: https://banano.cc. Banano has been active since 2018.

ah, seems like for some reason inquirer is failing. I've seen this before, will try to replace that too. Thank you!


NPM dependency warnings

First time running the project in a while as been busy with family 😄
When getting setup again, I can see a lot of warnings on the npm install step around:

dependency conflicts
unsupported node engine
security warnings

Would be prudent to clean these up and possibly, once it's clean add a PR check to make sure new PR's don't introduce any new warnings.

I could fix the issues if you'd like (I assumed other contributors will take it but it's been a while...)

I could fix the issues if you'd like (I assumed other contributors will take it but it's been a while...)

That would be awesome, thanks!


[Feature] Would you consider using Turborepo and bun to optimize your workflow

Description
Use bun to replace npm, and introduce turborepo to better manage ci and other workflows.
Reason
I've seen projects using primitive methods to manage different packages. I think using bun workspaces and turborepo might bring better results.

bun cannot fully replace node currently.
but i support use pnpm workspace.

I will try to commit a replacement 😊.

btw i'm not in behalf of dev team. maybe ask @unitwk

We will only consider using pnpm at most


Documentation for migrating from version 2 to 3?

Were there breaking changes in version 3? Are they documented anywhere?

Yes, I wrote about it in the wiki.
Major change was that all entries are sorted to have the same order on Linux and Windows.

Gotcha, might be a good idea to add that to tags for "Releases", as that's where I usually go to understand package updates.

Good idea, I changed the 3.0.0 tag


Feature to scrollTo a position in the page

Like the scrollTo method for a ScrollView, it'd be useful to be able to scroll to a specific part of a page without having to inject JS.
Currently, I'm recording the viewport position relative to the page using onScroll and would like to return a user to that exact position at a later time.

I have the same need, in my case I can't inject javascript into my webview

Same issue

It is necessary to have this feature.

Is there a way to just get/set the scroll value of the webview scroller ?


Refactor MQTT system tests to use Paho MqttClient API directly so that it is possible for tests to excert precise control over MQTT interaction

New tests added for issues 1499/1503 but marked as ignored for now

I retained the ideas behind the the original tests.   There are quite a few gaps in the tests, for instance pub/sub to hierarchal topic trees, subscriptions to > 1 topics, multiple subscribers etc.  I intend to add these later a separate task


new proj response text includes owner

What Git revision are you using?
What operating system are you using, and which version?

[ ] Linux / Ubuntu
[ x] Linux / Other
[ ] macOS
[ ] Windows

Describe what the problem is?
$aiken new proj
Error:
  × proj is not a valid project name: It is malformed.
  │
  │ Projects must be named as:
  │
  │ 	{owner}/{project}

$aiken new my/proj

Your Aiken project my/proj has been successfully created.
The project can be compiled and tested by running these commands:

    cd my/proj
    aiken check

but the dir is just ./proj
What should be the expected behavior?

aiken 1.0.2-alpha
i dont think this existed in 0.29


WIP: Add instrumentation to reconciler to track wasted renders

Wasted renders may be contributing significantly to performance issues in Roact apps. This is a pretty basic check to get high level stats on how much extra work the UI is doing.  Hopefully this can be expanded to provide more specific information as well.

There's also some kind of weird behavior here. This code will report that 50% of all primitive renders are wasted:
local Roact = require(game.ReplicatedStorage.Roact)
Roact.setGlobalConfig({
	trackWastedRenders = true
})

local TestComponent = Roact.Component:extend("Test")

function TestComponent:init()
	self.state = {
		pos = 1
	}
end

function TestComponent:render()
	return Roact.createElement("Frame", {
		Position = UDim2.new(0, self.state.pos, 0, 0),
	}, {
		Roact.createElement("Frame", {
			Position = UDim2.new(0, 1, 0, 0)
		})
	})
end

function TestComponent:didMount()
	spawn(function()
		while true do
			wait(1)
			self:setState({
				pos = math.random(-100, 100),
			})
		end
	end)
end

Roact.reify(Roact.createElement(TestComponent), workspace)

This isn't the best behavior - while the parent is changing, the child is exactly the same, and Roact ends up only setting a property, since that's the only thing that changed. This code implies that the child's render is wasted, but it's not - it's exactly where it should be.

Thanks for the feedback!  I'm going to start with finding a way to adjust this to account for what @AmaranthineCodices mentioned in regards to primitive elements; it may be better to disregard them altogether, since it's stateful/functional components we're really concerned with.
It may also be best to focus on building in tracking capabilities without necessarily attempting to log them in any intelligent way, but later integrate them into a more full-featured dev tool.

Worth noting: that's not exclusive to primitive elements. This has the same incorrect behavior:
local Roact = require(game.ReplicatedStorage.Roact)
Roact.setGlobalConfig({
	trackWastedRenders = true
})

local function Dummy(props)
	return Roact.createElement("Frame", {
		Position = UDim2.new(0, 1, 0, 0)
	})
end

local TestComponent = Roact.Component:extend("Test")

function TestComponent:init()
	self.state = {
		pos = 1
	}
end

function TestComponent:render()
	return Roact.createElement("Frame", {
		Position = UDim2.new(0, self.state.pos, 0, 0),
	}, {
		Roact.createElement(Dummy)
	})
end

function TestComponent:didMount()
	spawn(function()
		while true do
			wait(1)
			self:setState({
				pos = math.random(-100, 100),
			})
		end
	end)
end

Roact.reify(Roact.createElement(TestComponent), workspace)

With the output being
UI settled. Render stats:
	Functional: 1 wasted, 0 valid; Amount valid = 0%
	Primitive: 1 wasted, 1 valid; Amount valid = 50%

I had some more thoughts on this.
Firstly, I'm not sure that outputting render stats when renders cease is the best solution. We have all the information to know immediately whether a render is wasted, so we can output it immediately with a stack trace (if elementTracing is enabled). This will help with locating unnecessary renders. It will also allow error checking when Roact is re-rendering something faster than the current frame limit - right now this prints nothing when that happens!
Secondly, on the subject of "what is a wasted render"...it's complicated. I'm not entirely sure how to differentiate between "supposed to have the same properties every time" and "wasted render/bug" without extra hinting.


News tutorial documentation is incorrect

In the CodeIgniter documentation on the news tutorial is is saying:
$this->load->helper('url_helper');
it should be:
$this->load->helper('url');

Both work.


Add docker specific instructions

As a result of switching from Commento to Commento++ for the time being I've setup a small pipeline that will create Commento++ docker images.
They can be found on gitlab and hub.docker.com, they are mirrored.
I've added this to the documentation as I thought this repo would benefit from this.
Links

https://hub.docker.com/r/caroga/commentoplusplus
https://gitlab.com/caroga/commentoplusplus-docker

Thanks Roberto! Looks good to me 👍🏽
I might end up merging the docker image building with the CircleCI integration I have in this repo at some later date just to streamline the new release deployment process but I think this is great!

Thanks Roberto! Looks good to me 👍🏽
I might end up merging the docker image building with the CircleCI integration I have in this repo at some later date just to streamline the new release deployment process but I think this is great!

Great, thanks for merging!
Yeah I hope eventually all your work could be merged upstream. I don't expect my pipeline to have a long life, I just needed the images containing the patched commento version.
Anyways, thanks again!

Great, thanks for merging!
Yeah I hope eventually all your work could be merged upstream. I don't expect my pipeline to have a long life, I just needed the images containing the patched commento version.
Anyways, thanks again!

No worries! I hope so too, if the original author becomes active again I have a lot more merge requests with improvements ready for him!

No worries! I hope so too, if the original author becomes active again I have a lot more merge requests with improvements ready for him!

Hey @souramoo, @Caroga has been keeping me up to date with his efforts to contact the original author. For my own usage of commento I maintain a Helm chart over at https://github.com/WyriHaximusNet/helm-charts/tree/master/charts/commento for using with Kubernetes. Does your fork container any database migrations? Considering (temporary) switching to @Caroga's image and have all the sweet new features I've been missing. But I don't want to risk database issues because of migrations when potentially switching back to the official image.

Hey @souramoo, @Caroga has been keeping me up to date with his efforts to contact the original author. For my own usage of commento I maintain a Helm chart over at https://github.com/WyriHaximusNet/helm-charts/tree/master/charts/commento for using with Kubernetes. Does your fork container any database migrations? Considering (temporary) switching to @Caroga's image and have all the sweet new features I've been missing. But I don't want to risk database issues because of migrations when potentially switching back to the official image.

Hey! I've added one migration at https://github.com/souramoo/commentoplusplus/blob/master/db/20200730134007-comment-count-update.sql - this is to fix the comment counting bug in the original repo when deleting comments, but it doesn't do anything major (just recounts all the comments and adds back in the trigger function when comments are deleted).
You should be able to switch back and forth without any database issues!

Hey! I've added one migration at https://github.com/souramoo/commentoplusplus/blob/master/db/20200730134007-comment-count-update.sql - this is to fix the comment counting bug in the original repo when deleting comments, but it doesn't do anything major (just recounts all the comments and adds back in the trigger function when comments are deleted).
You should be able to switch back and forth without any database issues!

Thank you @souramoo, that looks safe to me indeed :+1: ! Will look into trying out commento++ soon :tada: .

Thank you @souramoo, that looks safe to me indeed :+1: ! Will look into trying out commento++ soon :tada: .


Add Costa Rica to the list of countries/regions

Hello! I noticed that Costa Rica is not included in the list of countries/regions for the most active GitHub users. This is unfortunate as Costa Rica has an active developer community, and it would be great to see our contributions reflected on the platform.
Would it be possible to add Costa Rica as a location? I believe many developers here would appreciate being included and would actively use this tool.
If there's anything I can do to help facilitate this, like testing or providing data, please let me know. Thanks in advance for considering this addition, and thank you for your work on this great tool!
Best regards,
Fabs

Hello, again!
I just realized that I can contribute this change myself by submitting a pull request. I'll be closing this issue now as I plan to implement the addition of Costa Rica directly.