"a.validator.methods[d] is undefined"

I'm trying to make the  not required but I get a a.validator.methods[d] is undefined in my console.Everything works fine if file:{required: is true. But in my case, a file is not required.
I tried using ignore: ".ignore" with file:{required:true and . It still validates on submit. And if I set file:{required: to false then I still get a a.validator.methods[d] is undefined error in console.
I have these files included:

$('#message').validate({
ignore: "",
rules: {
message:{required: true,},
file:{required:false, accept: "png|jpe?g|gif", filesize: 1048576 }
},
messages:{
message:"Please type your message",
file:{required:"File is required", accept: "Hello"},
},
});

Please provide a jsfiddle which demonstrates the problem

Closing because no repro jsfiddle availabe.
If you still experience the issue, please comment and provide a jsfiddle or other kind of simplied code sample to reproduce.
Thanks for the report.


As a library member I want to know if an item is available for requesting

What is it and who's it for?
Library users
User story
Feature: 1. As a library member I want to know if an item is available for requesting
Acceptance criteria
Scenario: I'm viewing a work page
Given the work has a requestable item
And it’s available to request
Then I can see a that it's requestable
Scenario: I'm viewing a work page
Given the work has a requestable item
And it’s unavailable to request
Then I can see a that it's temporarily unavailable
Scenario: I'm viewing a work page
Given the work has no requestable items
Then I can see a that it's not requestable and why (closed or open shelves or unknown)
Implementation
Testing and tracking

Have you talked to Tacey?
Test plan
Will you need to set up additional tracking?
What is the expected life span for tracking?

Measurement
Related KPIs (e.g. breadth of collection accessed, reading time, etc.)
Other considerations
<---Delete as appropriate--->

Impact on URL design
Cardigan documentation

Links to zeplin wireframes
Scenario 1 (item available): https://app.zeplin.io/project/5aab926b4b6efde01259e959/screen/5e568a35deafd9662acdd215/
Scenario 2 (item temporarily unavailable):
https://app.zeplin.io/project/5aab926b4b6efde01259e959/screen/5e568a3572ead876e1493115/
Scenario 3 (open shelves/closed):
https://app.zeplin.io/project/5aab926b4b6efde01259e959/screen/5e568a35f9503e7360d94a55/
https://app.zeplin.io/project/5aab926b4b6efde01259e959/screen/5e568a35bb57d361c1de3950/

@gestchild Can this be closed now?


Change function open() to use binary mode

Currently Convert Engine uses function open() in text mode causing corruption of binary image files on Windows.

Thanks!!


Extend feature flag framework

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/AM-1385
Change description
Extend BEFTA framework to support additional Feature Flag Toggles.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Hi @MSancaktutar Let me fix this.

This work will be tracked in PR-162.


confusing term in slims "nitrogen compound metabolic process"

GO:0006807
nitrogen compound metabolic process
Definition
The chemical reactions and pathways involving organic or inorganic compounds that contain nitrogen, including (but not limited to) nitrogen fixation, nitrification, denitrification, assimilatory/dissimilatory nitrate reduction and the interconversion of nitrogenous organic matter and ammonium. Source: GOC:go_curators, CHEBI:51143, GOC:jl, ISBN:0198506732
Comment
Note that amino acid and derivative metabolism should not be annotated here. Instead use the 'amino acid and derivative metabolism' node.
What do we actually mean by this term?
The definition  and comment looks as though it is trying to describe another term where nitrogene is acted upon directly
GO:0071941 - nitrogen cycle metabolic process
Definition	Parents
A nitrogen compound metabolic process that contributes to the nitrogen cycle. The nitrogen cycle is a series of metabolic pathways by which nitrogen is converted between various forms and redox states; it encompasses pathways in which nitrogen is acted upon directly, such as nitrification, denitrification, nitrogen fixation, and mineralization.
To illustrate the problem, "nitrogen compound metabolic process" encompasses pretty much every annotated process (translation, DNA metabolism, etc etc)
http://amigo.geneontology.org/amigo/term/GO:0006807
S. cerevisiae has 22684 annotations to 3645 gene products annotated to this term.
If it  is required for grouping I suggest it be made "not for direct annotation" it just isn't useful... and probably people should reconsider its inclusion in slims. It is not needed for annotation coverage.
PomBase slim uses GO:0071941 - nitrogen cycle metabolic process
which covers the things which are not covered by other processes (provided of course that annotation is  as specific as it can be).

This term and its children are determined by the ChEBI cross-products (nitrogen molecular entity). So the structure is reflective of the ChEBI ontology. This includes a lot of biological compounds. In the context of the chemical structure, it is correct. Maybe it is not so useful as a slim term?

That's my point!  It should not be a slim term ;)
I think sometimes it is used instead of
GO:0071941 - nitrogen cycle metabolic process
because of  the wording
So the suggestions are
-[ ] clarify meaning
(the comment does not make sense because this term DOES include
amino acid and derivative metabolism- its an ancestor)

[ ]  remove this clause
" including (but not limited to) nitrogen fixation, nitrification, denitrification, assimilatory/dissimilatory nitrate reduction and the interconversion of nitrogenous organic matter and ammonium" because it is making people think that this term is for this
"GO:0071941 - nitrogen cycle metabolic process"

-[ ] Make this term not for direct annotation, its too broad to be useful since most  biolofgical compounds contain nitrogen

[ ] suggest that people swap their slim term  from
GO:0006807nitrogen compound metabolic process
to
GO:0071941 - nitrogen cycle metabolic process

(You need  GO:0071941 - nitrogen cycle metabolic process in the  slim to capture some gene products which invoved in nitrification/denitrification etc)

Do we have contact information for GO-Slims? We need a documented SOP for making changes to subsets.

We could add metadata directly in the OWL, or have a separate yaml file - @dosumis ?

Actually the term is only used in only used in 2 slims
goslim_pir	456
goslim_metagenomics	116
It is probably a redundant term in these slims, but they are quite extensive slims anyway so it isn't really a problem as such. Many slims contain terms like this.
I'd like to write some guidelines for creating and testing slims  for different purposes
For example for  biological relevance, for non-redundant coverage, for comparisons, for QC  at some point.....
Although how well a species gene products slim non-redundantly  (or even at all) is ultimately  dependant on the depth of a species annotation.
I'm using them a lot at tpresent to asses core conserved unknown proteins and there are a lot of well -studied proteins which do not slim at all for some species.

We could add metadata directly in the OWL, or have a separate yaml file - @dosumis ?

If in the ontology we could annotate subsetdef axioms with orcids - but that's a bit obscure and would need extensions to OBO-OWL translation. It would be much easier as a separate YAML.  Then easy for anyone to edit.


The split tabs are inconsistent if apply 'Filter by prefix' in the original view all containers explorer

Storage Explorer Version: 1.35.0-dev (99)
Build Number: 20240720.1
Branch: main
Platform/OS: Windows11/Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.5(Apple M1 Pro)
Architecture: arm64/x64/x64/x64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Right click the 'Blob Containers' node -> Click 'View All'.
Type a character in the 'Filter by prefix' field.
Split the tab -> Observe the split tab.
Check whether the split tabs are consistent.

Expected Experience
The split tabs are consistent.
Actual Experience
The split tabs are inconsistent.

Closing as by design, same reason as #8068.

Hi @craxal, For blob containers, the split tabs are consistent if apply 'Filter by prefix' in the original tab.

And there is an open bug for file share about this issue: 4944. Maybe it should be consistent, could you help to take a look?

@JasonYeMSFT Can you look into this? Not sure why we are preserving prefix search when a tab is split, but I assume this was a discussion point some time ago. Whatever we're doing, let's make sure we're consistent.

Blob explorer writes the search prefix in the tab state data, which is why it is preserved in the split tab. I don't think it's critical for us to also preserve that for the view all containers explorer. I am going to close this issue as not planned. We can revisit this if there are customer issues for this.


Missing contact form

A bit shame we don't have a contact form for this lovely e-commerce theme :-(

Hey, thanks for the suggestion! We don't plan to add this into the template, but this could be handled in a number of ways. Something hooked up to your database, or to your CMS, or even sending an email.


Accept multiple files in inclusions using globs and add 'exclude' argument

Contributes to #49

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

81 of 81 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
205

Relevant Lines:
205

💛  - Coveralls


Clock.shouldAnimate default value

My application abnormal after update cesium version. Eventually I found it in Clock.shouldAnimate, which was the default true in previous releases(1.36), but false in the new release(1.42). But it does not seem to be updated in the API documentation.

Hi @xuncanzhe, sorry this change caught you off guard.  We did make note of it in the Breaking Changes section of CHANGES.md for the 1.42 release: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CHANGES.md#breaking-changes-mega-1
You can set it back to true by passing in shouldAnimate: true as an option to Viewer
I couldn't find anywhere any errors in the documentation where it says shouldAnimate defaults to true, but if you see any please let us know so we can update it.  Thanks!

HI, https://cesiumjs.org/Cesium/Build/Documentation/Clock.html?classFilter=cloc . and the same situation in source code Comments.

@hpinkos

Ah, thanks @xuncanzhe!  I looked at the doc for the params at the top of the file, but I forgot to look at the doc for the property.
I've updated that in https://github.com/AnalyticalGraphicsInc/cesium/commit/7a86dcf871bf994b50da6decb42adcf6d8f0a6b8 and the doc will be fixed in the Cesium 1.44


Support the heartbeat

@roman-kashitsyn leaked on the forum that the canister_heartbeat entry point is now supported by application subnets. The Interface spec doesn’t list it yet, but once it’s there we should probably support it from Motoko.
Unless we take the stance (from the discussion on the feature in the ic-ref at https://github.com/dfinity-lab/ic-ref/issues/245, which I can’t read any more) that canister_heartbeat is a low-level feature meant to be used mainly by canisters providing cron services to other canisters, and that Motoko canisters should not use this (inefficient, inflexible) interface, but should rather use dedicated cron-as-a-service-canisters.
But the pragmatic thing is probably to expose the canister_heartbeat entry point.

Shouldn't be too hard to support.

Yeah, the straight forward exposition should be almost trivial.
Is our type system strong enough to express a context that allows calls (i.e. can await), but does not allow responses? That might new, or affect the default reject handler.

Not entirely sure, but it sounds like the same restrictions we enforce on oneways by forcing the ignore async {...} abomination.

Hi Claudio, any chance we can get this added? Right now I have to install a separate rust heartbeat canister to call my motoko ones, this isn't very ideal 😅

Here is my very naive & hacky attempt at implementing it https://github.com/ninegua/motoko/commit/6a0a645b467dbaf5e4d1d6da7d6aed66dc60b8a1
Probably made a lot of mistakes, and I don't have time to write any test case. It is better wait for official implementation.

@ninegua thanks for that! Looks quite plausible (skimming only)
@rossberg shall we add support for the heartbeat method?

(I would probably make it just return (0), not async(), like a oneway though.)

Fine by me!

(I would probably make it just return (), not async(), like a oneway though.)

That was my first try. But with only () I cannot make it pass the type checker if I have await .. in the function body. Maybe you can help?
Also my suggestion is to rename upgrade { .. } record to system { ... } to better match the intention.

Any update on this? Thanks!

Please give my canister a heartbeat.


Disable annotations & automatic consumption of reviewed cases

This PR disables the possibility of making annotations through the monitoring tool, to avoid people encountering the bug with annotations. It also disables extracting finalized cases from tarballs to avoid integrating bugged annotations.

@aristizabal95 This is looking good, nice work! I will test it and let you know.
I may not be aware of all corners of the monitoring tool code, but everything looks great! Just one small thing that I want to double check with you:
https://github.com/aristizabal95/medperf-2/blob/52957db89f7dbf7a4edac38e3e3c6408c69a9678/scripts/monitor/rano_monitor/handlers/reviewed_handler.py#L75-L92
In the code above, I see on_modified is handled correctly. However, the __init__ would still run anyway right? and it looks to me it is "moving assets". Is that expected?

Good catch! I'll fix that tomorrow

closing as it is no longer relevant


As a ward nurse/doctor moving a patient, I want to view important notes about a patient, such as being a fall risk etc.

So that I can be reminded about each patient's unique needs without having to dig through records

This is not essential as this can technically be satisfied by the patient's full details sections, albeit less conveniently

Not implementing. Fulfilled by view command.


Fabricator Plugins

Hey @LukeAskew -
Has there been any thoughts put into adding the ability to make plugins for fabricator that we might not want to have in core, but might want in different circumstances?
Just wanted to spit ball that idea out.
Thanks!

Yeah definitely been kicked around. Not sure what it looks like, but I'm open to a brainstorm.
What kind of things is everyone thinking?

When you say plugin do you mean a JavaScript utility like moment.js or pikaday.js that's used in this toolkit but not the next? Or a Fabricator plugin like commenting on a component for example?

I think the latter.
Working on #165 now, and I'm thinking it is a good candidate for plugin status. Not something everyone wants, but enough people seem to find it useful.

Great, yes that plugin would be appreciated! We've got a LOT of components & the navigation is getting a little unwieldy in it's current state.
(really enjoying Fabricator!)

Idea for a Fabricator plugin – Resizable components: every component lives in it's own iframe, with a width resize handle. This would provide RWD testing (iframe hitting breakpoints) per component rather than resizing the whole window/viewport & losing your scroll position.

:+1: for https://github.com/fbrctr/fabricator/pull/165 , although I personally think that should be included in core.
Continuing from @jameswragg 's point about resizable components, I really liked ish, which is included in PatternLab.


fix(plugin-chart-table): Include time control

SUMMARY
The "Include time" control in Table chart is not working properly when GENERIC_CHART_AXES is enabled because of lack of the time column in chart settings.
This PR bremoves the include_time checkbox and if include_time was true before and granularity_sqla was set, it moves the granularity_sqla column to dimensions. The end result is the same as with the checkbox, except that the label of the time column is actual column name rather than "Time".
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TESTING INSTRUCTIONS

Disable GENERIC_CHART_AXES
Create a table chart and check "Include time", add a time column
Enable GENERIC_CHART_AXES
The "Include time" checkbox should disappear, the time column should now be added to Dimensions
Nothing should happen if "Include time" was not checked before enabling the feature flag

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

CC @yousoph


OSX?

Is there anything to be wary of on OSX.  I noticed it's not listed in the supported platforms. Thanks.

Maybe fixed.


Real booleans not supported in pyproject.toml

Using a real boolean in pyproject.toml for flake8 config breaks pflake8:
[tool.flake8]
count = true

Traceback (most recent call last):
[...]
  File<EMAIL_ADDRESS>line 1165, in _convert_to_boolean
    if value.lower() not in self.BOOLEAN_STATES:
AttributeError: 'bool' object has no attribute 'lower'

As a workaround booleans have to be written as string:
[tool.flake8]
count = "true"

Just bumping


Unable to drag drop nodes into script when script has errors.

Tested versions

4.2.1 stable

System information
Windows 11 23H2
Issue description
When you drag drop nodes into script. The code is not generated, but a toast notification error happens "Can't drop nodes because script <script_name> does not inherit from Node."
https://github.com/godotengine/godot/assets/84369217/a9dabd0e-4421-4782-9693-c5bdca8fd064
Steps to reproduce

create a scene with few nodes in tree
attach a script to the root
write an empty function (without having any lines under it) (an example of error creation)
save and restart/reload the project (Important Step)
now open the scene and try dragging nodes into the script.
It does not work.

Note: If you immediately drag after saving the erroneous script. it will work.
Workaround: Fix the issues, and then drag drop will start working
Minimal reproduction project (MRP)
Not required as it is not project specific.

It is no more reproducible in 4.3.rc3


Feature Request:  Add Environment details to crash issues - reported by @Santhosh-Sellavel

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Problem:
From the crash issue description we are unable to distinguish which environment it occurred.
Solution:
If possible we should add environment details to the issue description for crash issues, if possible let's update environment-wise stats there.
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1659981562906149
View all open jobs on GitHub

@Santhosh-Sellavel what do you mean by environment? cc @AndrewGable

I believe it means Dev/Staging/Prod

I believe it means Dev/Staging/Prod
Yes

@flodnv no one is assigned here

@AndrewGable I don't think this can be External...?

I agree, seems internal to me too.

@AndrewGable there is no one assigned here

@flodnv or @AndrewGable No one is assigned here

What is your point @Santhosh-Sellavel?

Can you rephrase @AndrewGable?

I'm wondering why you are commenting saying that it's unassigned? If it's an internal issue, an Expensify engineer will pick it up and work on it when they have time. Otherwise, it will just sit unassigned, so there is no need to comment on it.

The reason I was bumping is that I think this could be useful information. Recently on this issue it seemed that it occurs during development. this one also.

Got it! That is valuable information for sure, thank you! 🙏

I'm going to close this per this conversation.


Macro: System allow to connect block to already occupied connection (that cases invalid saved files)

Steps to Reproduce

Switch to Macromolecules view
Load this file: repro3.zip
Establish connection from "(R2) - Right only" to (R1, R2,R3) using center-to-connection(R2) way
R1 connection of (R1, R2,R3) remain unoccupied - this is ok.
Establish connection from "(R1) - Left only" to (R1, R2,R3) using center-to-center way

https://github.com/epam/ketcher/assets/26869421/ed49e671-2901-452b-a999-8f8c8f462b4f
Actual behavior
R1 connection remain unoccupied. Since that moment if you export canvas to ket file - it will be invalid

Expected behavior
System establishes R1-R1 connection between "(R2) - Left only" and (R1, R2,R3)
Desktop (please complete the following information):

OS: win10
Browser Chrome 120.0.6099.130 (Official Build) (64-bit)

Ketcher version [e.g. v2.4.2].

Documentation
https://kb.epam.com/display/EPMLSOP/Types+of+connections

Fixed.


Unbundle the l18n library

This was previously bundled in #4721 to avoid installation errors on non-Unicode locales. As of v2018.5, this has now been fixed upstream: https://bitbucket.org/tkhyn/l18n/issues/4/setuppy-raises-unicodedecodeerror-trying

Rebased and resolved via 6ce9f3a717abd3cb7a9ae35364ae274f141c267b


[docs] Add controller flow docs

What is the purpose of the change
Add detailed documentation for the core operator controller flow
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency):no
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed:no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? docs

+1 I was unable to render the pictures on this PR.

Sorry @morhidi , I should have posted some screenshots. Unfortunately I don’t have the laptop on me

+1 I was unable to render the pictures on this PR.

Sorry @morhidi , I should have posted some screenshots. Unfortunately I don’t have the laptop on me
hm.. it is supposed to work without screenshots. I checked and the svgs are not formatted properly. The <?xml version="1.0" encoding="UTF-8"?> tag is duplicated in them.

I will remove them once back from holiday , this is not urgent. Thank you!


Open last project

I would like a new feature: to open the last project, instead of searching for the path, because normally you work on a project for some days. I guess the path can be saved on the config file every time CATS is closed.

Actually there is already some support:

You can open any recent project from the main menu: Project -> “Recent Projects” ->
I use this myself all the time

You start CATS with the —restore option that will restore your last open project (and its open editors). Don’t use this myself too much, so might still be some glitches.

You start CATS with the —project  option. I also use this a lot. You can create a shortcut so you don’t have to type it all the time of course.

On 06 Apr 2015, at 00:54, David Trillo<EMAIL_ADDRESS>wrote:
I would like a new feature: to open the last project, instead of searching for the path, because normally you work on a project for some days. I guess the path can be saved on the config file every time CATS is closed.
—
Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/147.

Thank you for the options!
I'm surprised for the CATS IDE. Congrats!


cannot find symbol (Android)

Hi!
when I try to build my app in Android Sudio I get this error message:
error: cannot find symbol add(SmsManagerPlugin.class)
I think that I've to import the class but in the documentation doesn't say nothing about that. Can you help me?

Hi,
as a Java developer I did thought leaving that from the docs might be a problem.
You have a few possibilities:

You just need press ALT + Enter when the cursor is in the class name in Android Studio. It will import the class automatically
Add import com.byteowls.capacitor.sms.SmsManagerPlugin; to imports sections of class
Use the full qualified name add( com.byteowls.capacitor.sms.SmsManagerPlugin)

I adapted the docs to address that.


Snowflake Dialect

Hello! We are hoping to use this package to sync data from Canvas to our data warehouse that is in Snowflake. Does the team currently have plans to add Snowflake as a provided dialect, or should we start on adding the dialect ourselves given the provided instructions? Thanks!

Unfortunately, we don't have any short-term or mid-term plans to integrate a Snowflake connector, and thus add Snowflake as a supported dialect to pysqlsync. However, if you are open to contributing, I am more than happy to help with hints or code review.

Got it, thanks so much for the response ! We have decided to move forward with the Data2 API instead of the Sync for now, with plans to revisit the sync option in the future, so will be in touch in the coming months. Thanks again!


Possible inconsistent method: parse

I've run into some trouble while trying to customize the way response bodies are parsed -- specifically on the client.
From these tests, it appears that the parse method of the node library is used to customize how response bodies are parsed.
This test shows that the parse method of the client library is used to customize how request bodies are serialized.
Is this inconsistency intentional?  If not and a maintainer would like to specify the intended behavior, I'd be happy to open a PR.

I'm not sure, but it looks like unintentional inconsistency. The guiding principle is that superagent should have the same API on client and server.

Yeah, the node tests predate the client tests and are also much more robust.  If I prepare a PR which changes the client library to be consistent with the node library, would that breaking change be accepted?

I'd rather avoid breaking if possible. How about adding parseRequest, parseResponse accordingly?

Sounds reasonable.  Add those methods to both libs and deprecate the current parse?

Yes, that's what I had in mind: create new unambiguous methods for parsing that work the same client- and server-side, and leave the old confusing one for backwards compatibility and eventually remove the old one in 2.x.
I'm not entirely sure about parseRequest and parseResponse names though.
Another approach could be to add arguments to the existing parse to disambiguate? req.parse({response:fn, request:fn})?

Sadly, it looks like request.parse indeed sets a request body serializer and then this._parse in the browser request instance is indeed a function used for serializing request bodies. Thus I don't think the confusion is request vs. response but rather parse vs. serialize. I'd like to see a PR for the following changes:

rename the private var this._parser to something more clear like this._serializeBody in the browser client code
Add a new clear public API to set the request body serializer. Perhaps req.serializeBody() (open to more concise suggestions for the name). This can be an alias of the current req.parse in the client code.
I don't see any functionality in the node code to provide a custom body serializer. It seems to all just be hard coded in exports.serialize which presumably can be overridden in a straightforward way if a user has read the source, but maybe we should make an explicit API to keep parity with the browser code.
deprecate existing request.parse with corresponding doc updates

The term serialize is used in Superagent's codebase, so for 2.0 I suggest:

parse(fn) for parsing response body only (this is a breaking change)
serialize(fn) for generating data to send in the request


Add google dictionary API.

Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide
[x] Your additions are ordered alphabetically
[x] Your submission has a useful description
[x] The description does not end with punctuation
[x] Each table column should be padded with one space on either side
[x] You have searched the repository for any relevant issues or pull requests
[x] Any category you are creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Also the dictionary entry I added is open source, source code can be found here https://github.com/meetDeveloper/googleDictionaryAPI.

@meetDeveloper can you please check the suggestion from @matheusfelipeog and update your record accordingly?

Git//ElWeroRanchero

@ElWeroRanchero  This has already been added, closing this PR.


npm no longer supports Node.js <4, stop updating it to the latest there

Expected behaviour
npm shouldn't be updated to a version not supported in a particular environment.
Actual behaviour
npm gets updated to the latest version on all Node versions, including 0.10 & 0.12 which it no longer supports. This causes lots of warning messages and in some time it will most likely stop working:
https://travis-ci.org/karma-runner/karma/jobs/225953592
Environment Details

Karma version (output of karma --version): master
Relevant part of your karma.config.js file: N/A

Steps to reproduce the behaviour

Open https://travis-ci.org/karma-runner/karma/jobs/225953592
See warnings.

When is it planned to drop support for Node.js <4 in Karma? That would solve this issue for now.
If that's not planned soon, we should perhaps:

Update npm to v3 in Node 0.10/0.12/4.
Not touch npm in newer Nodes. This means we'll get stronger coverage as we'll be testing on Node 3 & 4 and soon on v5 as well - which is what people use as most of them don't update the built-in npm version.

There is already a task open for that #2490. The main thing here is getting all modules ready for this for v2.0, which should include other breaking changes that we want to do.

See https://github.com/karma-runner/karma/milestone/9

I think we should update npm in Node 0.10/0.12/4 to npm@3 as that we know is officially supported and leave the other Nodes as they are. Then we'll only test on npm>=3 but where such npm is already available by default we'll use the included version. That's the version most people will use so I think that's preferable.
PR: #2715.


fix: ensure Signature is ethereum scheme

treat v != {27,28} as an error
ref:
https://github.com/ethereum/go-ethereum/blob/2adce0b06640aa665706d014a92cd06f0720dcab/internal/ethapi/api.go#L549-L551

Codecov Report

Merging #2183 (401d3e1) into main (d83c07c) will decrease coverage by 13.42%.
The diff coverage is 75.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #2183       +/-   ##
===========================================
- Coverage   72.21%   58.80%   -13.42%
===========================================
  Files         459      459
  Lines       55322    55325        +3
===========================================
- Hits        39950    32532     -7418
- Misses      15372    22793     +7421

Flag
Coverage Δ

integration-tests
16.65% <75.00%> (-2.21%)
:arrow_down:

unit-tests
54.74% <75.00%> (-12.36%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/primitives/src/transaction/signature.rs
73.72% <75.00%> (-20.31%)
:arrow_down:

... and 165 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Multistep cover learned equivalent ground truth

This PR adds two more options to cover_multistep_options: LearnedEquivalentPick and LearnedEquivalentPlace. These options use the same parameterization that the options learned through _SimpleOptionLearner use. Corresponding "ground truth" samplers for these two options are added to oracle_approach. A few minor changes are made to update the control flow for how the cover NSRTs are defined in oracle_approach, as well as a few runtime bug fixes such as the cover_multistep_option non-learned-equivalent samplers not properly doing relative positioning (it was over-constraining the support of the uniform distribution).

I'll review after @tomsilver 's suggested refactor!


Bulk add reverse records

Hi all,
Im moving from bind to pdns with this awesome admin tool.
I've been searching but found nothing about having a way to add bulk PTR records for reverse zones
Like the $generate from bind.
For example, I have like 10 reverse zones for /22 prefixes. That means ~10k PTR records.
Thanks in advance!

https://doc.powerdns.com/md/authoritative/migration/
zone2sql --named-conf=/path/to/named.conf --gmysql | mysql -u pdns -p pdns-db

@openmsk Thanks for your answer, but I mean after the first migration.
If tomorrow I need to generate reverses, or the forward for a new prefix, there is no way.
Also, I cant load our main forward zone (10k+ records), after some time loading, nginx throw an error

PowerDNS-Admin is a backend for managing pdns-daemon and communicating with him over the API.
for this you should not try to load into the control panel, I gave an example from the documentation for pens-daemon where work with the load goes to the mysql of the zone values.
If tomorrow you need to create a new empty zone, then you can do it through the web interface PowerDNS-Admin

As my english is very poor, I may expressed it incorrectly.
I know I can import named zones to sql. And I know I can create empty zones, but how can I bulk polulate it like the $generate from bind?
I mean, our main forward domain has arround 12k records that corresponds with 12 reverse zones that has the PTR records.
So IP <IP_ADDRESS> resolves to 88.77-66-55.mydomain.net and vice-versa. And same with all our prefixes.
In bind, you can just add a $generate line. Is there something similar in powerdns-admin?

my english is also not native :) but I think I understand you.
https://doc.powerdns.com/authoritative/manpages/zone2sql.1.html
zone2sql understands the Bind master file extension $GENERATE and will also honour $ORIGIN and $TTL.
in other words, you can create a BIND file, then zone2sql send it to the database.

Ooook, now I did understood you. You are saying that instead of creating it from powerdns-admin, just create a "fake" bind zone and then import...
Its perfectly valid, but such an option in powerdns-admin would be awesome

I think this is not the task of the management interface =)

Why not? Its adding records, in a bulk way but adding records.

at least for this:
''' Also, I cant load our main forward zone (10k+ records), after some time loading, nginx throw an error'''
По-русски я бы объяснил что если есть инструменты упрощающие жизнь, для чего усложнять схему, и жаловаться что не работает

Well... I have mixed one question with one problem.
The question was if there were any way to add bulk records. There isnt, its ok. Just though it could be a nice feature, as adding records is part of the management.
The problem, or issue, is in an already imported zone with 10k+ records, Im unable to manage from powerdns-admin. In error log it shows ...upstream prematurely closed connection while reading response header from upstream...
Im not complaining, and if it sounds like that Im sorry.

show me an example of your config using the 10 million record $generate
I will try to reproduce your terms

Not 10 million!! 10 thousands.
They are just a bunch of $generate, one for each /24 reverse we manage. So each reverse has 255 records and our main forward 255 records for each reverse, making it with thousands records

oh, 10,000 entries - not a lot :)
solution for you :)
bash script:
pdnsutil create-zone 168.192.in-addr.arpa

for i in {1..254}; do
    for o in {1..254}; do
        pdnsutil add-record 168.192.in-addr.arpa $o.$i PTR test.example.com
        done;
done;

Its long
Start create 10000 records Sat Feb 23 23:25:20 MSK 2019
Finish Sat Feb 23 23:30:56 MSK 2019
If it is long, then you can write a MySQL request that will make it a little faster :D

Oh, thats really nice for our new zones!
But that was not the point. I can just do it in php to insert directly in database. Sorry for making you work due to my poor english :(
When I say load error, I mean in the already imported zone with zone2sql, I get that nginx error when I try to edit that zone from powerdns-admin.
I think is for the time it takes to load all the records. Is there any kind of timeout? I've used the nginx tutorial.

I think that the problem is not in the PowerDNS-Admin, but in the size of the responses from the pdns.service API

@TheGreatDoc I am currently in the stages of migrating from bind to pdns.. what a headache with 20+ years of domains which may or may not be valid anymore!! Anyways... our backend is mysql, which I gather yours is too because I think you used zone2sql... at any rate another idea would be that you could use a script to generate your records and then insert them to mysql db instead of using the powerdns-admin api.

Hello,
This request is stale for too long. Regarding our policy to cleanup this project, we are closing it. Feel free to open a new issue later.
Regards
PowerDNS Admin Team
See https://github.com/PowerDNS-Admin/PowerDNS-Admin/issues/1153 for the policy


Delete the refresh cache?

After updating the plug-in to the latest version I am still not seeing wall switches. I was wondering if deleting the cache and have it reload might resolve the issue? Is there another fix?
Thanks!

Is this still the case?


Do not want to receive comments from action

Hello, I used this action, it is very convenient to replace now bot. I don't want to receive comments under commit every time I deploy to now. I removed github-token and it can be deployed to now, but ci reports an error. I hope that github-token can be turned into an optional item.

@nb5p Hi, thank you for your good feedback. I will work on it next week.


Docker install

System information (Please provide as much relevant information as possible)

Windows 10 Pro
Docker

Problem and solution:
When following the docker install tutorial found here (https://google.github.io/mediapipe/getting_started/install.html#installing-using-docker) I would receive this error "(specified in /mediapipe/.bazelversion), but it wasn't found in /usr/local/lib/bazel/bin." when trying to run the line "root@bca08b91ff63:/mediapipe# GLOG_logtostderr=1 bazel run --define MEDIAPIPE_DISABLE_GPU=1 mediapipe/examples/desktop/hello_world". I remedied this issue by removing the CRLF in the .bazelversion file. Please update the main branch to prevent others having this issue!

Hi @Linduri ,
Could you provide steps to reproduce this issue.

Create a new docker image using the steps found here "https://google.github.io/mediapipe/getting_started/install.html#installing-using-docker"
Run the image in a new contained using "docker run -it --name mediapipe mediapipe:latest"
Try to run the hello world using "GLOG_logtostderr=1 bazel run --define MEDIAPIPE_DISABLE_GPU=1 mediapipe/examples/desktop/hello_world"

Hi @Linduri ,
Run without CACHE, "--no-cache", show the logs from that docker build.
otherwise, unclear why this docker image would lack a working "bazel"

I have since fixed the issue but I did try using "--no-cache" when I had the error and it still reported the same error. I have fixed the problem by removing the CRLF in the .bazelversion file.


Robot rules

My unofficial hackathon project :)
Will allow us to dynamically decide what we want to do with jobs -- for now clear, retry, retry, retry with incrementing the retry attempt count extra. Criteria include job class, error class, error message, etc.,and a possible expiry so we don't become dependent on it.
Silo peeps: it can also be used in conjunction with Swappable to send BSC jobs to the API if processing them normally fails with a certain error.
Be aware that this is a public PR.
I still have to add a couple tests but wanted people to see this before the weekend.
@davidann @tony-bye

@evanbattaglia close this.  it's stale.

@evanbattaglia, you shouldn't have listened to him :D.

@peaches will take over this PR from here, please send him your comments and feature requests.
(Nice github handle by the way, I guess you were an early adopter!)


Send Sluggish

Hi
Thanx for the code, I improved it and added "to_name" and also changed mktime() to time() as that results is some warnings , time() more efficient for timestamp 'now', my research suggests.
Ok I have 30 000 emails queued and it is sending at about 3/sec, am using SendGrid API Free with 40 000 emails free to test, by this rate I will finish sending in 25 hours, now I have a list of 120 000 subscribers, this would take I think3-4 days, how to speedy things up?
Delivery:
I am calling the delivery.php directly via wget from cron job (not secure), my server wont fire the bash file, is the bash script file calling better that calling the delivery.php directly? If so why?
My setting are the default:
EnvironmentProduction
Maximum delivery timeout50 seconds
Delivery interval100 ms.
Maximum retry attempts3
Maximum delivers per call1,500
SMTP serversmtp.sendgrid.net

The main reason sendgrid throttles your emails is because your sender/domain is "greylisted". You can check your reputation with MxToolbox (there is some stuff in sendgrid too). Open a ticket with sendgrid if you want to know why, their support is top notch even with their free plan.

Hi @numediatechnologies , it's also well known that some smtp service providers would limit your delivery rate if you're using some kind of trial account, check with sendgrid to see if they apply delivery rate limits to free accounts.
Emailqueue tries to stablish a persistent connection to the SMTP server by using the "SMTPKeepAlive" parameter of the PHPMailer library. As long as the persistent connection is stablished (no way to check with PHPMailer), this should discard emailqueue as the bottleneck.
Also, as @roselan suggested, check out if your sender IP is blacklisted/greylisted somewhere.
Let us know your solution once found!
Thanks both!

Additionally, SMTP services like Amazon SES and many others limit your delivery rate based in their trust in you. For example,  If I remember right, Amazon SES starts you with a low delivery rate and raises it automatically over time if your bounce/spam rate is low enough.
meow.

BTW, @numediatechnologies, I do not recommend at all to call the delivery.php via wget. This means an instance of your web server is being used to deliver the emails, and this leads to lots of serious problems (note I said "leads", not "may lead"!)
For instance, your web server sure has some kind of maximum execution time limits, memory limits ... when calling delivery.php with a web request, this limits apply and might end the delivery execution unexpectedly just after a few seconds, or give other kind of errors related to web-serving.
It's strongly recommended that you execute the provided script, which is actually really simple: it just executes deliver.php vie the PHP CLI.
It might not work straightaway in your system because the "delivery" script has some hardcoded paths, just edit it to suit your environment and it should work ok.
Cheers!

Thank you guys.
Increasing Send Rate of the Delivery Script:
@roselan It is not greylisted its a new free account on their shared IP.
@tin-cat I cant access their support as fast as I wish on this free trial account.
Solution and problem:
SendGrid allows one to submit up to 10 000 recipients per time using their  SMTP-API custom header, https://sendgrid.com/docs/API_Reference/SMTP_API/using_the_smtp_api.html , they recommend 1000 though.
Problem arising is that each body of the email is personalised and has different content each week, so there is no way to also submit the body with each connection using this SMSTP-API of Sangrid, which means, I will have to modify the delivery php file to not include the body when sending to that 1000 batch per sending request, I have not investigated, but I presume, SendGrid possibly has templating system of the message body, so that I include that one body and SendGrid replaces certain variables for personalisation, including the unsubscribe URL.
I will investigate this further.
I will also investigate using "BCC" but in my ad hoc analysis now that option fails for the body reason.
Last complication is, with these methods , how do I include the List-Unsubscribe custom header that @tin-cat rightfully includes.
My Server refuses to fire my bash cron job only wget http it fires which causes problems as @tin-cat mentioned, maybe something to do with the server or how I setup the cron?

/[ROOT_DIRECTORY]/emailqueue/scripts/delivery.sh

Hi @numediatechnologies, I haven't dived deep into the sendgrid documentation you linked, but it seems you're trying to use some kind of pattern-based email sending service that just happens to have an API implemented via SMTP (if I understood well).
If that's the case, please note EmailQueue is not built to work with that kind of non-standard SMTP services, it is just built to send normal emails via standard SMTP requests. This means you have to provide the complete PlainText/HTML body of your message everytime you send an email, and you'll have to stick to the standard headers provided by the EmailQueue functionalities (like the unsubscribe URL header you mention), or provide your own via the additional headers capabilities.
My recommendation if you still want to work with Emailqueue is to use just Sendgrid's regular SMTP Relay service, not their advanced API, which is definitely aimed to more specific environments and provides lots of advanced functionalities outside of the scope of EmailQueue.
Cheers!

@tin-cat Thank you for your assistance, you certainly make sense.
However, I was using SMTP so am basically trying to solve the problem of the script being too slow for my intended use, eg send to 100 000 email list will take many days  at 1 email/3-4 sec. I have used Amazon SES before and they allow 50 emails/sec , the  delivery system worked well if I used BCC field, so am trying to find a way to increase the delivery rate.


Add core module with commonMain

Sets up the initial multiplatform project with just the common code. Intended to establish the foundation for Kable's public API. More PRs to follow with the platform specific implementations.
Design
Naming generally follows Bluetooth Low Energy naming conventions.

The following guide provides a good overview: https://embedded.fm/blog/ble-roles
General usage flow

Create Coroutine scoped Central
Acquire Scanner from Central
Scan for nearby peripherals by collecting Advertisements from Scanner's peripherals Flow
Use Central to convert Advertisement to a Peripheral
Connect to peripheral via Peripheral's connect function
Communicate with peripheral via Peripheral functions

Example usage
(example OS X command line app)
fun main() = runBlocking<Unit> {
    val central = central()
    val advertisement = central.scanner()
        .peripherals
        .first { /** todo: Search criteria. */ }
    val peripheral = central.peripheral(advertisement)

    peripheral.connect() // suspends until connected
    peripheral.discoverServices()
    val characteristic = peripheral
        .services["f000aa80-0451-4000-b000-000000000000"]
        .characteristics["f000aa81-0451-4000-b000-000000000000"]

    sensorTag
        .observe(characteristic)
        .onEach { data -> /** todo: Process characteristic change. */ }
}

While discussing design, it was proposed that requestPeripheral function could be promoted to live in the common API (and not be specific to Javascript). Unfortunately after thinking about it further, I'm not sure of a good design for Android / iOS for this function. On Javascript, the browser displays a UI to the user of potential matches and the user picks the peripheral to pair with.
As a low level library, I don't anticipate providing UI for such user selection. It was also proposed that we return a List but them the question arrises, how long do we scan for before we decide that it's time to return the list of matches?
I'm sadly leaning towards keeping the divided API design (with requestPeripheral being specific to Javascript). 😢

As a low level library, I don't anticipate providing UI for such user selection. It was also proposed that we return a List but then the question arrises, how long do we scan for before we decide that it's time to return the list of matches?

Return a Flow of Lists? It's probably not even necessary to decide the frequency as the underlying systems may return scan results periodically anyhow (iOS does for sure, not looked at the BluetoothLeScanner class in detail yet).

As a low level library, I don't anticipate providing UI for such user selection. It was also proposed that we return a List but then the question arrises, how long do we scan for before we decide that it's time to return the list of matches?

Return a Flow of Lists? It's probably not even necessary to decide the frequency as the underlying systems may return scan results periodically anyhow (iOS does for sure, not looked at the BluetoothLeScanner class in detail yet).

I'll leave this functionality out for now. Tracking via #4.


change navbar

change navbar for which i use component to do the leftButton and aRightButton

every style should be customizable

@aksonov you can close


IGNITE-17748 TC check

According to the issue, the branch is already merged to main. I'm closing the PR.