ScaleDetector doesn't work when a Component with DragCallbacks is added

Current bug behavior
ScaleDetector doesn't work when a Component with DragCallbacks is added.
Expected behavior
Scale gesture (pinch-to-zoom) should work regardless if a Component with DragCallbacks is registered. I'd expect to distinguish between two-finger scale gestures from one-finger tap and drag gestures.
In the example below you can drag the green rectangle but you cannot scale the board. When you remove DragCallbacks mixin, scale gesture starts working.
Steps to reproduce

Use ScaleDetector with FlutterGame
Add a child with DragCallbacks
Notice onScaleUpdate is not being called after scale gesture
Remove DragCallbacks mixin and notice onScaleUpdate is now being called

import 'package:flame/components.dart';
import 'package:flame/events.dart';
import 'package:flame/game.dart';
import 'package:flame/input.dart';
import 'package:flame/palette.dart';
import 'package:flutter/material.dart';

class ScaleDragGame extends StatelessWidget {
  const ScaleDragGame({super.key});

  @override
  Widget build(BuildContext context) {
    final game = ScaleDragFlameGame();

    return GameWidget(game: game);
  }
}

/// `onScale` methods are not called when a Component with DragCallbacks is added as a child.
/// Green rectangle can be dragged around but scale gestures don't work. But if I remove DragCallbacks from
/// [DraggableRectangle] scale gestures start to work.
class ScaleDragFlameGame extends FlameGame with ScaleDetector {
  late final CameraComponent cameraComponent;
  late double startZoom;

  ScaleDragFlameGame();

  @override
  Color backgroundColor() => Colors.yellow;

  @override
  Future<void> onLoad() async {
    final world = World();
    cameraComponent = CameraComponent(world: world)
      ..viewfinder.anchor = Anchor.center
      ..viewport.anchor = Anchor.center;
    addAll([world, cameraComponent]);

    world.add(DraggableRectangle(
      size: size / 4,
      position: size / 6,
      paint: BasicPalette.darkGreen.paint(),
    ));
  }

  @override
  void onScaleStart(ScaleStartInfo info) {
    startZoom = cameraComponent.viewfinder.zoom;
  }

  @override
  void onScaleUpdate(ScaleUpdateInfo info) {
    /// not called when Component with DragCallbacks was added

    final currentScale = info.scale.global;
    if (!currentScale.isIdentity()) {
      final newZoom = (startZoom * currentScale.y).clamp(1.0, 6.0);
      cameraComponent.viewfinder.zoom = newZoom;
    } else {
      final delta = info.delta.game;
      cameraComponent.viewfinder.position.translate(-delta.x, -delta.y);
    }
  }
}

/// Remove [DragCallbacks] and see that pinch-to-zoom gestures start working
class DraggableRectangle extends RectangleComponent with DragCallbacks {
  DraggableRectangle({
    super.position,
    super.size,
    super.paint,
  });

  @override
  void onDragUpdate(DragUpdateEvent event) {
    super.onDragUpdate(event);
    position += event.delta;
  }
}

Flutter doctor output

[✓] Flutter (Channel stable, 3.10.5, on macOS 13.2.1 22D68 darwin-arm64, locale en-US)
    • Flutter version 3.10.5 on channel stable at /Users/wojciechplesiak/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 796c8ef792 (7 weeks ago), 2023-06-13 15:51:02 -0700
    • Engine revision 45f6e00911
    • Dart version 3.0.5
    • DevTools version 2.23.1

More environment information

Flame version: 1.8.1
Platform affected: android
Platform version affected: android 13

More information
I want to have draggable components placed on the zoomable board. Imagine you have a puzzle board and you want to zoom in to be able to drag the smaller pieces with precision. DragCallbacks is taking over all touch inputs even when they happen outside of the Component. I see under the hood that whenever a Component with DragCallbacks is added ImmediateMultiDragGestureRecognizer is registered as one of the gestureDetectors (here).

This is a really tricky limitation in Flutter, since scale is a superset of pan.
We could possibly work around it by using the scale detector for panning too, but I don't think that multi touch would work properly if we did that.
If anyone has a good solution for this we are all ears!

With regular Flutter widgets you can put Draggable inside InteractiveViewer and both drag and scale gestures work in the same time. I'm sure there is a way to do this and keep multitouch functional.
For now I was forced to stop using Flame for this very reason as I was unable to find a workaround on my end. What I tried was adding at first non-draggable Component, and then replacing it with a draggable Component after it was touched. Then on tapping outside - replacing draggable with non-draggable. This worked but only one time, looks like adding a Component with DragCallbacks will register a listener, but removing this component won't unregister that listener and this listener will steal the touch inputs after even though it's not doing anything.
I also tried adding/removing listeners manually, but part of the Flame impl is internal and I couldn't do it.

@spydon, I read my previous message and I see it's confusing, apologies

put Draggable inside InteractiveViewer and both drag and scale gestures work in the same time

what I meant is you can either drag a Draggable or scale with InteractiveViewer - depending what takes the touch input first, but you can perform both actions. My use case is being able to position elements on the screen with precision, and since elements can vary in size I need to be able to zoom in to be able to grab the smaller ones.

When you put a Draggable inside of an InteractiveViewer, you don't have multi touch support anymore, right?
Because the scale events will always (or a lot of the time) win on the gesture arena as soon as there are multiple fingers involved.
So what I'm suggesting is to create a new event dispatcher that registers a DragGestureRecognizer (monodrag) which should be possible to use together with a ScaleDetector/ScaleGestureRecognizer.
It should be fairly easy, mostly copying the current MultiDragDispatcher implementation and create something like MonoDragDispatcher and then add a boolean to DragCallbacks that indicates whether it should register a mono- or multi-dispatcher. And probably have an assertion if it finds out that there are different types trying to be registered at the same time.

No, you still get multitouch working, it just depends on what you click on first. From my experience:
Interesting, there must be some really delicate work done in the gesture arena for that to work.

Thanks for the hints how to implement similar behavior with Flame.
If you want to implement it in Flame, do you want to make a PR with it? In that case i can assign you to the issue. :)
You can of course ask me if you need any pointers too.

We moved away from Flame for now, I used at first to get the collision detection for free, but after I stumbled upon this issue I switched over to standard Flutter to be able to move forward. Down the road we might need some Flame magic, but util that happens I need to focus on other things.

Linking #2726 here since it is related.

Is there a workaround for this?

I faced the opposite of the original issue -- i.e. DragCallbacks on a child component does not work properly with ScaleDetector  as a parent component.
Details
In the video snippet below, you'll notice after zooming in then zooming out, dragging with a single finger invokes onScaleStart instead of onDragStart most of the time. In some cases, even tapping on on the game invokes onScaleStart.
https://github.com/flame-engine/flame/assets/46427323/f8e5ef77-7a94-4bc6-a2df-dcea0f767847
Minimal Code sample to reproduce:
 Expand To View
import 'package:flame/components.dart';
import 'package:flame/events.dart';
import 'package:flame/game.dart';
import 'package:flame/input.dart';
import 'package:flutter/material.dart';

void main() {
  final game = ZoomExample(viewportResolution: Vector2(500, 500));
  runApp(
    MaterialApp(
      debugShowCheckedModeBanner: false,
      color: Colors.yellow,
      home: Center(
        child: Container(
          height: 500,
          width: 500,
          child: GameWidget(game: game),
        ),
      ),
    ),
  );
}

class ZoomExample extends FlameGame with ScrollDetector, ScaleDetector {
  ZoomExample({
    required Vector2 viewportResolution,
  }) : super(
          camera: CameraComponent.withFixedResolution(
            width: viewportResolution.x,
            height: viewportResolution.y,
          ),
        );

  @override
  Color backgroundColor() {
    // TODO: implement backgroundColor
    return Colors.blue;
  }

  @override
  Future<void> onLoad() async {
    world.add(SomeComponent());
  }

  void clampZoom() {
    camera.viewfinder.zoom = camera.viewfinder.zoom.clamp(0.05, 3.0);
  }

  static const zoomPerScrollUnit = 0.02;

  @override
  void onScroll(PointerScrollInfo info) {
    camera.viewfinder.zoom += info.scrollDelta.global.y.sign * zoomPerScrollUnit;
    clampZoom();
  }

  late double startZoom;

  @override
  void onScaleStart(_) {
    print('onScaleStart');
    startZoom = camera.viewfinder.zoom;
  }

  @override
  void onScaleUpdate(ScaleUpdateInfo info) {
    final currentScale = info.scale.global;
    if (!currentScale.isIdentity()) {
      camera.viewfinder.zoom = startZoom * currentScale.y;
      clampZoom();
    } else {
      final delta = info.delta.global;
      camera.viewfinder.position.translate(-delta.x, -delta.y);
    }
  }
}

class SomeComponent extends RectangleComponent with DragCallbacks {
  SomeComponent() : super(size: Vector2.all(50), position: Vector2.all(0));

  @override
  // TODO: implement paint
  Paint get paint => super.paint..color = Colors.red;

  @override
  void onDragStart(DragStartEvent event) {
    print('onDragStart');
    super.onDragStart(event);
  }

  @override
  void onDragUpdate(DragUpdateEvent event) {
    // TODO: implement onDragUpdate
    position += event.localDelta;
  }
}

Additional Info
For reference, I've already faced a similar issue with InteractiveViewer before and I've a bug filed in flutter repo: https://github.com/flutter/flutter/issues/136622

Just to follow up:
The issue I reported above was a bug in the engine and it was fixed in:

https://github.com/flutter/engine/pull/49424

Also, not sure if it'll help here, but the pointerCount for the trackpad was also updated:

Now trackpad gestures will count as pointerCount=2 instead of 1. It makes it easier for people who want to have different behaviour for single-finger drag vs two-finger pan/zoom.

https://github.com/flutter/flutter/pull/140745

both fixes should be in master by now.
Cheers

Thanks for the update @osaxma, this should have a separate issue though since it's not the same as the one OP describes.

Is there a workaround for this?

You can try the below code, I didn't tested it in MobileDevices, but in Web this works as expected. Instead of using ScaleDetector or MultiTouchDragDetector on FlameGame use this mixin
// ignore_for_file: implementation_imports
// ignore_for_file: invalid_use_of_internal_member

import 'package:flame/events.dart';
import 'package:flame/game.dart';
import 'package:flame/src/events/flame_game_mixins/multi_drag_dispatcher.dart';
import 'package:flutter/gestures.dart';

// This Kanged from `Flutter` [InteractiveViewer] widget
enum _GestureType {
  pan,
  scale,
  rotate,
}

/// An helper mixin that should be used instead of `Flame`
/// default detectors in order to make both game & components
/// receive guestures.
///
/// <br>
/// This is need due to fact of how `Flutter` GestureArea
/// works under the hood.
/// https://github.com/flame-engine/flame/issues/2635
mixin GestureDetector on FlameGame {
  _GestureType? _gestureType;

  static int _id = 0;

  @override
  void onMount() {
    gestureDetectors.add(
      () {
        return ScaleGestureRecognizer();
      },
      (ScaleGestureRecognizer instance) {
        instance.onStart = _handleScaleStart;
        instance.onUpdate = _handleScaleUpdate;
        instance.onEnd = _handleScaleEnd;
      },
    );
  }

  @override
  void onRemove() {
    gestureDetectors.remove<ScaleGestureRecognizer>();
  }

  void onDragStart(int pointerId, DragStartInfo info) {}

  void onDragUpdate(int pointerId, DragUpdateInfo info) {}

  void onDragEnd(int pointerId, DragEndInfo info) {}

  void onScaleStart(ScaleStartInfo info) {}

  void onScaleUpdate(ScaleUpdateInfo info) {}

  void onScaleEnd(ScaleEndInfo info) {}

  void _handleDragStart(int pointerId, DragStartDetails details) {
    onDragStart(pointerId, DragStartInfo.fromDetails(this, details));
  }

  void _handleDragUpdate(int pointerId, DragUpdateDetails details) {
    onDragUpdate(pointerId, DragUpdateInfo.fromDetails(this, details));
  }

  void _handleDragEnd(int pointerId, DragEndDetails details) {
    onDragEnd(pointerId, DragEndInfo.fromDetails(details));
  }

  void _handleScaleStart(ScaleStartDetails details) {
    _id++;
    _gestureType = null;
    final dragDetails = DragStartDetails(
      sourceTimeStamp: details.sourceTimeStamp,
      globalPosition: details.focalPoint,
      localPosition: details.localFocalPoint,
    );
    final dragEvent = DragStartEvent(_id, this, dragDetails);
    findByKey<MultiDragDispatcher>(const MultiDragDispatcherKey())
        ?.onDragStart(dragEvent);
    if (dragEvent.continuePropagation) {
      _handleDragStart(_id, dragDetails);
    }
    onScaleStart(ScaleStartInfo.fromDetails(this, details));
  }

  void _handleScaleUpdate(ScaleUpdateDetails details) {
    if (_gestureType == _GestureType.pan) {
      // When a gesture first starts, it sometimes has no change in scale and
      // rotation despite being a two-finger gesture. Here the gesture is
      // allowed to be reinterpreted as its correct type after originally
      // being marked as a pan.
      _gestureType = _getGestureType(details);
    }
    switch (_gestureType ??= _getGestureType(details)) {
      case _GestureType.pan:
        final dragDetails = DragUpdateDetails(
          sourceTimeStamp: details.sourceTimeStamp,
          delta: details.focalPointDelta,
          globalPosition: details.focalPoint,
          localPosition: details.localFocalPoint,
        );
        final dragEvent = DragUpdateEvent(_id, this, dragDetails)
          ..continuePropagation = true;
        findByKey<MultiDragDispatcher>(const MultiDragDispatcherKey())
            ?.onDragUpdate(dragEvent);
        if (dragEvent.continuePropagation) {
          _handleDragUpdate(_id, dragDetails);
        }
        break;
      case _GestureType.scale:
      case _GestureType.rotate:
        onScaleUpdate(ScaleUpdateInfo.fromDetails(this, details));
        break;
    }
  }

  void _handleScaleEnd(ScaleEndDetails details) {
    final dragDetails = DragEndDetails(velocity: details.velocity);
    final dragEvent = DragEndEvent(_id, dragDetails);
    findByKey<MultiDragDispatcher>(const MultiDragDispatcherKey())
        ?.onDragEnd(dragEvent);
    if (dragEvent.continuePropagation) {
      _handleDragEnd(_id, dragDetails);
    }
    onScaleEnd(ScaleEndInfo.fromDetails(details));
  }

  // Decide which type of gesture this is by comparing the amount of scale
  // and rotation in the gesture, if any. Scale starts at 1 and rotation
  // starts at 0. Pan will have no scale and no rotation because it uses only one
  // finger.
  _GestureType _getGestureType(ScaleUpdateDetails details) {
    if ((details.scale - 1).abs() > details.rotation.abs()) {
      return _GestureType.scale;
    } else if (details.rotation != 0.0) {
      return _GestureType.rotate;
    } else {
      return _GestureType.pan;
    }
  }
}

Hello is this issue solved I also trying to use dragcallbacks with scaledetector for camera zoom and its reading zero scale values unless I remove the dragcallbacks.

Hello is this issue solved I'm also trying to use dragcallbacks with scaledetector for camera zoom and its reading zero scale values unless I remove the dragcallbacks.

Have you tried using my custom mixin, (shared above) on FlameGame instead of using default mixin?

I've tried it on Anroid works perfectly thanks man. It would be nice though to be able to use onDrag on children objects not just the flame game class. Great work nonetheless.

I've tried it on Anroid works perfectly thanks man. It would be nice though to be able to use onDrag on children objects not just the flame game class. Great work nonetheless.

This works on Child Components too, use this mixin on Flame class and use default DragCallbacks on component. This will mixin will take care of passing the drag to the child components too.

No it doesn't work on children whenever any child with DragCallbacks is in the scene. The scale value goes to zero. Only works if the onDrag event is on the flame game class.

No it doesn't work on children whenever any child with DragCallbacks is in the scene. The scale value goes to zero. Only works if the onDrag event is on the flame game class.

Strange, can you please share me some reproducible code using the mixin i provided i will have a look once.

Here is the zoon example from Flame documentation with CustomScaleDetector. Notice when you add "flameLogo" sprite component the code runs. However, If you add "flameLogo_draggable" - Which has a DragCallbacks - instead, an error occurs telling you the zoom should not be zero (Which means the scale has gone to zero).
import 'customScaleDetector.dart';
import 'package:flame/components.dart';
import 'package:flame/events.dart';
import 'package:flame/game.dart';

class ZoomExample extends FlameGame with CustomScaleDetector {
  @override
  Future<void> onLoad() async {
    final flameSprite = await loadSprite('flame.png');

    DraggableHud flameLogo_draggable = DraggableHud()
      ..sprite = flameSprite
      ..size = Vector2.all(150)
      ..anchor = Anchor.center;

    SpriteComponent flameLogo = SpriteComponent(
        sprite: flameSprite, size: Vector2.all(150), anchor: Anchor.center);

    world.add(flameLogo_draggable);
  }

  void clampZoom() {
    camera.viewfinder.zoom = camera.viewfinder.zoom.clamp(0.5, 3.0);
  }

  late double startZoom;

  @override
  void onScaleStart(_) {
    startZoom = camera.viewfinder.zoom;
  }

  @override
  void onScaleUpdate(ScaleUpdateInfo info) {
    final currentScale = info.scale.global;
    if (info.rotation != 0) {
      camera.viewfinder.angle = -info.rotation;
    }
    if (!currentScale.isIdentity()) {
      camera.viewfinder.zoom = startZoom * currentScale.y;
      clampZoom();
    } else {
      final delta = info.delta.global;
      camera.moveBy(-delta);
    }
  }
}

class DraggableHud extends SpriteComponent with DragCallbacks {
  @override
  void onDragUpdate(DragUpdateEvent event) {
    super.onDragUpdate(event);
  }
}

@ahmed-salh  Thank you for providing the reproducible code, its my mistake that i should have tested the code in atleast one mobile device.  I am working with Flame on web so there I didn't noticed the issue you were referring to. I tested your code on an android device & got the error.
Please use the latest code snippet I shared above (edited the same one), it will fix the issue but please make sure to have a condition to check whether the scale is greater than 0 or not while using it, because i seen the ScaleUpdateDetails class that comes from Flutter in the comments they mentioned that both scale & rotation will be greater than or equal 0 but not less. So you need make sure to have that condition for not getting errors for safe side.
In case if you still find anything please feel free to comment.

Works flawlessly thanks.  Anyways I hope flame updates this in the future and thanks again for your help.

My team has moved away from Flame for our purposes and gone with a custom implementation involving InteractiveViewer due to this issue. However, we confirmed that this custom gesture handler resolves our issue. If this were to make its way upstream, we'd consider moving back.

Thank you @tejHackerDEV, you custom mixin worked beautifully.
I had problems combining InteractiveViewer and DragCallbacks.  The DragCallbacks components became unresponsive and it is hit or miss when clicking on the components.
Hope this get merge in to the main branch soon.

@tejHackerDEV would you be interested in working on a PR to get this into Flame? :)

@tejHackerDEV would you be interested in working on a PR to get this into Flame? :)

I can do that, no problem


Fix color highlighting in CHANGELOG.md

Clearly not a very significant PR 😅 The devil is in the detail I guess

[ ] Tests and linter pass
[ ] ~Code coverage does not decrease (if any source code was changed)~
[ ] ~Appropriate docs were updated (if necessary)~

I signed it!

Nice!
@JustinBeckwith can we make manual edits to the CHANGELOG?

Yeah I think that should be fine.  Thanks for the fix!

You're welcome, it didn't take me too long 😬 Congrats for v2


Command already exists: add ! to replace it: MANPAGER call s:ManPager()

Steps to reproduce
When I vim a file, no matter new one or existed one, I will encounter an error:
Error detected while processing /usr/share/vim/vim90/plugin/manpager.vim:
line    6:
E174: Command already exists: add ! to replace it: MANPAGER call s:ManPager()
Press ENTER or type command to continue

It seems Apple M1 Max brings the problem. But how can I fix it?
Expected behaviour
No more annoying error alert
Version of Vim
9.0.217
Environment
macOS Monterey 12.6
Apple M1 Max
Logs and stack traces
No response

What does :verbose command MANPAGER show?

Name              Args Address Complete    Definition
MANPAGER          0                        call s:ManPager() | delcommand MANPAGER

Did you use :verbose? It will show where the MANPAGER command is defined.

Sorry. Should it be like this:?
    Name              Args Address Complete    Definition
    MANPAGER          0                        call s:ManPager() | delcommand MANPAGER
        Last set from ~/.vim/plugin/manpager.vim line 5

Last set from ~/.vim/plugin/manpager.vim line 5

Okay, so you have installed manpager.vim locally. How about uninstalling it?

BTW, I think that  a guard should be added to manpager.vim:
--- a/runtime/plugin/manpager.vim
+++ b/runtime/plugin/manpager.vim
@@ -2,6 +2,11 @@
 " Maintainer: Enno Nagel<EMAIL_ADDRESS> " Last Change: 2022 Sep 30

+if exists('g:loaded_manpager_plugin')
+  finish
+endif
+let g:loaded_manpager_plugin = 1
+
 " Set up the current buffer (likely read from stdin) as a manpage
 command MANPAGER call s:ManPager()

BTW, I think that a guard should be added to manpager.vim:
--- a/runtime/plugin/manpager.vim
+++ b/runtime/plugin/manpager.vim
@@ -2,6 +2,11 @@
 " Maintainer: Enno Nagel<EMAIL_ADDRESS> " Last Change: 2022 Sep 30

+if exists('g:loaded_manpager_plugin')
+  finish
+endif
+let g:loaded_manpager_plugin = 1
+
 " Set up the current buffer (likely read from stdin) as a manpage
 command MANPAGER call s:ManPager()

So you mean ~/.vim/plugin/manpager.vim should be removed instead of the one from vim90？
But if it's so, I cannot modify the one in directory vim90 to add any guard because of lacking root permission.

Last set from ~/.vim/plugin/manpager.vim line 5

Okay, so you have installed manpager.vim locally. How about uninstalling it?

Finally I fix this by removing ~/.vim/plugin/manpager.vim. Thank you!

The above patch should be useful for avoiding this kind of errors in the future. Not necessary for this time.

closing for #11390


[Menu, Select] Add the modal prop

Added the modal prop to Menu and Select
Refactored the Menu to be more in line with Select regarding click-drag-release support

Converting it back to draft as there are issues with nested menus

This requires https://github.com/floating-ui/floating-ui/pull/3160 to be released to fully work properly.

<EMAIL_ADDRESS>is out


Feature request : Support Server 2003 and XP

For the sake of completeness, is it possible to support XP and 2003 (R2) ?
These system are loved for running old software, and official activation methods are harder to use over time for these old operating system.
Unofficial methods documentation gets lost (links are now 404). The cleanest way would be to use slmgr.vbs /skms
Of course, I do not recommend running these system on something else than an air gaped network without internet.

I'm pretty sure that KMS was introduced with Vista, so XP and 2003 can't activate against a KMS.

You can't activate XP against KMS so by extension you can't activate server
2003 either
W dniu śr., 18.05.2022 o 10:05 rijenkii @.***>
napisał(a):

I'm pretty sure that KMS was introduced with Vista, so XP and 2003 can't
activate against a KMS.
—
Reply to this email directly, view it on GitHub
https://github.com/Py-KMS-Organization/py-kms/issues/70#issuecomment-1129699710,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADTM4XZNLQ5OM5GR7E3RAHLVKSQEJANCNFSM5V7W27BA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thank you very much @rijenkii and @luky92 for your explanation! Sadly, these old versions can't be activated with this project. I would recommend you to look for ways of modifying the OS directly (no links here!).


Ability to make hyperparameters constant

For some experiments, we may want to set certain hyperparameters to be constant. This currently can be done if we want to include components for ex,  include={'trainer': ['StandardTrainer']} or for categorical hyperparameters by simply sending a single value into the value_range parameter of an update, for ex, HyperparameterSearchSpaceUpdate(node_name="network_backbone",                    hyperparameter="ShapedResNetBackbone:resnet_shape",                    value_range=['brick'],                    default_value='brick').
However, for integer or float hyperparameter, ConfigSpace gives an error if we want to set the lower and upper to the same value. This can be done either via another parameter such as 'make_constant' in the HyperparameterSearchSpaceUpdate or as decided earlier we can encapsulate ConfigSpace by introducing a search_space module that can handle such an update elegently

We can also follow the technique used in https://github.com/automl/Auto-PyTorch/blob/7c95381d5345498ddbe026d3b8b8ae41264644c9/autoPyTorch/utils/config_space_hyperparameter.py


lxrun.exe /setdefaultuser fails if Windows username contains spaces

If the Windows user's directory contains a space in the path (in my case the path is C:\Users\FIRSTNAME LASTNAME),  setdefaultuser fails to create user during install and subsequent runs. LXSS directories in AppData are also not created.
A test account was created on the PC, ensuring a user directory path with no spaces in it. Issue was not observed.
A second test account was created on the PC, this time ensuring a user directory with a space in it, resulting in the issue described.
Microsoft Windows [Version 10.0.14393]
Expected results
C:\Users\FIRSTNAME LASTNAME>lxrun /setdefaultuser USERNAME
Enter new UNIX password:
Retype new UNIX password:
passwd: password updated successfully
Default UNIX user set to: USERNAME

Actual results (with terminal output if applicable)
User
Initial attempt
C:\Users\FIRSTNAME LASTNAME>lxrun /setdefaultuser USERNAME
Enter new UNIX password:
Retype new UNIX password:
passwd: password updated successfully
/bin/bash: /mnt/u/Users/FIRSTNAME: Permission denied
Creating UNIX user failed, this can be done later by running lxrun.exe /setdefaultuser

Admin
Clear "Permission denied" by elevating privileges
C:\Users\FIRSTNAME LASTNAME\Documents>lxrun /setdefaultuser USERNAME
Enter new UNIX password:
Retype new UNIX password:
passwd: password updated successfully
Creating UNIX user failed, this can be done later by running lxrun.exe /setdefaultuser

Notice the lack of a "Permission denied" line? Admin was able to make a file C:\Users\FIRSTNAME (not a directory). That file contains this:
/usr/bin/id: extra operand ‘LASTNAME/AppData/Local/Temp/uid.txt’
Try '/usr/bin/id --help' for more information.

Created Linux user by hand and attempt to set as default
Potential workaround building on Bash logging in as root until the default user is set
Bash on Ubuntu on Windows:
root@desktop:~# useradd USERNAME -m
root@desktop:~# passwd USERNAME
Enter new UNIX password:
Retype new UNIX password:
passwd: password updated successfully

cmd.exe:
C:\Users\FIRSTNAME LASTNAME>lxrun /setdefaultuser USERNAME
Found UNIX user: USERNAME
/bin/bash: /mnt/u/Users/FIRSTNAME: Permission denied
Creating UNIX user failed, this can be done later by running lxrun.exe /setdefaultuser

Reproduction

Create a new user account. Ensure the username has one or more spaces in it.

Settings > Accounts > Family & other people
Add someone else to this PC
"I don't have this person's sign-in information"
"Add a user without a Microsoft account"

Login as the test account created in Step 1.
Install LXSS: lxrun \install \y.
Set/Create a new default Linux user by launching Bash on Ubuntu on Windows or running lxrun \setdefaultuser.

This is a very similar issue to #598.

Look like it.

I've fixed this issue and #598, look for the fix in an upcoming Windows Insider build.  Thanks again for reporting!


add unit test to prove the behaviour for string equality

Thanks for helping address #432 :)

This patch was committed before you heard back from the Python Dev team?  That seems premature.
It's also a useless test since the only thing stringy about OurCustomString is the name.  To be a correct test you need to add the __eq__ method that Max-Volger showed in his example:
def __eq__(self, other):
    if isinstance(other, (str, newstr)):
        return self.string == other
    else:
        return NotImplemented

You should probably also add a test to make sure OurCustomString compares correctly to a regular string:
self.assertTrue(our_str == 'foobar')

Hi @ethanfurman!  I asked @shivapbhusal to write a unit test to confirm the behavior of the design of the function until the design was able to be discussed.  I'm sorry this wasn't shared publicly.  If you have further comment after the changes made since that conversation has ended please file a new bug.
@shivapbhusal thanks for your first open source contribution.  You've done a great job and I look forward to hearing more from you :) See you at the next PyCon!

Hi @jmadler, Thanks a lot for helping me get started. I look forward to making more contributions in the future. See you at the next PyCon!


feat(http): added support to Deprecation header for deprecated operat…

Addresses #1563
Summary
Responses receive "Deprecation" header once operation is deprecated.
Checklist

The basics

[x] I tested these changes manually in my local or dev environment

Tests

[x] Added or updated
[ ] N/A

Event Tracking

[ ] I added event tracking and followed the event tracking guidelines
[x] N/A

Error Reporting

[ ] I reported errors and followed the error reporting guidelines
[x] N/A

good job


Zend template empty

Hi, i have a trouble when i use zend template i got and empty page, but when i use the responsive-twig template i can view the class methods and other info.
Also, in the responsive-twig template the tag @link and @see doesn't display the links to interactive navigation when the target is an external link like that:
@link http://silex.sensiolabs.org/doc/providers.html Silex provider documentation
I doing something bad?

I just had an internal report from @mbed67. She reported the same thing. I'm investigating this.

@javiertrejo could you please check if the version of phpdocumentor in master fixes your issue? Please reopen/comment on this issue when it was not solved.


Feature/conda check and conda update

Almost lost track of this, but I think it's good and will go ahead and merge


Allow DocumentNode in OperationParams#query

In WPGraphQL we want to parse the GraphQL queries to DocumentNode by ourselves before passing it to the graphql-php Server instance via OperationParams. This would allow us to add an filter on which userland plugins can hook into for AST inspection, transformation and caching.
But unfortunately the current validateOperationParams in the Helper class does not allow it to be a DocumentNode.
But later in the file the it can skip parsing if it is already a DocumentNode:
https://github.com/webonyx/graphql-php/blob/1f0ec2408010e01879b1f980afac65de2344c631/src/Server/Helper.php#L279-L285
Here's the WPGraphQL PR for the filters https://github.com/wp-graphql/wp-graphql/pull/1302
I realize this implementation might not be ideal since OperationParams is mean to represent "HTTP parameters" where AST does not necessarily make sense but I could not figure any other way to do this without larger refactoring. Other ideas would be very welcome.
Thanks!

Coverage remained the same at 86.128% when pulling 0204253f65bdc36112d7e87301675cecfade9395 on esamattis:allow-document-node into 1f0ec2408010e01879b1f980afac65de2344c631 on webonyx:master.

To be honest I don't understand why the PHPStan check started failing with

Only booleans are allowed in a negated boolean, GraphQL\Language\AST\DocumentNode|string given

It wasn't a boolean to begin with just made it into a union 🤔

@esamattis it's because the error message changed for already ignored errors.

Oh right, makes sense! Thanks @simPod! Updated the ignore file.

Sorry for the late reply.
On this PR. This doesn't sound right to me. We already have persisted query support for cases like this via persistentQueryLoader option of the server. So what you can do instead:
$server = new StandardServer([
    'persistentQueryLoader' => function($queryId, OperationParams $params) {
        return $whateverDocumentNodeYouWant;
    }
]);

It should work for you without any changes. Thoughts?

Ah! It probably can be used for this.

A function which is called to fetch actual query when server encounters queryId in request vs query.

I guess we'll have add some kind of dummy queryId id to actually trigger it but it's totally doable. I'll experiment with it soon.

@esamattis Did it work for you? If so, can we close this PR?

On a vacation ATM. I but I should be able to check this during next week when I return.

Closing for now, feel free to reopen if your issue persists.


Errors don't surface when starting a consumer fails to authenticate

Errors don't surface when starting a consumer fails to authenticate
Fixes #104
Signed-off-by: azerr<EMAIL_ADDRESS>

This PR improves the start / stop consumer:

by managing state launch (starting, started, stopping, stopped) which is used by code lens (ex : when a consumer is starting,the start and stop lenses are not displayed)
by executing start / stop consumer with progress. It's very helpful when you start a consumer in a cluster which cannot be accessed (you see on the bottom of vscode the progress state)

display error when start consumer cannot be executed (ex : cluster cannot be accessed)
improve consumer view to display consumer options when it is started + display error

Thanks @angelozerr!


UI fixes

Fixes https://github.com/aspnet/AspNetCore/issues/11749 and https://github.com/aspnet/AspNetCore/issues/6200
Will need to update scaffolding with these changes as well

Also fixes https://github.com/aspnet/AspNetCore/issues/11523 (removing glyphicons which no longer are a part of bootstrap4)

Manage/Email each button (SendVerificationEmail / ChangeEmail) has its own handler, so send verification email no longer triggers the OnPost (which was change email before), fixes https://github.com/aspnet/AspNetCore/issues/11524

Updated added a new private helper that both OnGet/Post call to load the data


Exit as failure if warnings are present?

In 0.54.0 (commit) unused suppressions ($FlowFixMe) became warnings. My use-case for suppressions is to assert flow errors where those should exist (in __flowtests__ files). These tests give me confidence in my local flow-typed interfaces when upgrading flow (and vice-versa).
Is there a way to get failure exit code if warnings are present? (either via .flowconfig or command-line arguments)?
Alternatively, do you have other recommendations?
Thank you!

I think this is pretty serious problem for flow-typed: https://github.com/flowtype/flow-typed/issues/1385

FWIW, our current workaround is to enable warnings in flow config (via include_warnings=true) and run a slightly modified script in CI:
[[ $(flow check) == 'Found 0 errors' ]]

instead of just
flow check

Similar solution was introduced for flow-typed.

This was resolved in 0.66.x via https://github.com/facebook/flow/commit/d6682b2422515c294710e4a1a84cc01b316806b4
To get flow to exit with failure if errors are present, use
flow --max-warnings 0

Thank you @nmote!

Is it possible to specify max_warnings in the .flowconfig file?


Merging release-2108 branch to dev

Update module versions
Change module dependencies for az.resources
PSD1 dependency moved from individual metadata to the top level readme.azurestack.md

closing in favor of https://github.com/Azure/azurestack-powershell/pull/148


update COVER token address

Yes, we want to go forward with this.
Once we register a ENS domain, we will switch over in the future, but we would like to use this method for now.

Yes, we want to go forward with this.
Once we register a ENS domain, we will switch over in the future, but we would like to use this method for now.


Fix ImGui not working when Slate Global Invalidation is enabled

With Imgui being immediate mode, it needs to re-render every frame but Slate Global Invalidation will only re-render widgets when they invalidate or if they are volatile, so this change makes the ImGui widget volatile.

Thanks!


Can't deploy. NoMethodError

This is new. I was able to deploy yesterday.
$ nanobox deploy
Root privileges are required to start the server. Your system password may be requested...
[sudo] password for localusername:
Skipping (already running) :
Preparing environment :

Compiling application :
  Starting docker container :
  Preparing environment for compile :
    - Copying ssh keys into the build environment...
    - Setting up directories and permissions...
    /opt/gonano/hookit/lib/hookit/hook.rb:91:in `method_missing': undefined method `each_pair' for nil:NilClass (NoMethodError)
    	from /opt/nanobox/hooks/lib/hash.rb:7:in `deep_merge!'
    	from /opt/nanobox/hooks/lib/hash.rb:3:in `deep_merge'
    	from /opt/nanobox/hooks/boxfile:51:in `<main>'

Error   : failed to execute hook (boxfile) on 4b0f45c2154dd34a524205bc7e9406879e9d1f456b5c0b6480da9bd7854fcf54: util:Exec:/opt/nanobox/hooks/boxfile: bad exit code(1):
Context : failed to compile the code -> failed to run the (compile)boxfile hook

boxfile:
run.config:
  engine: ruby
  engine.config:
    runtime: ruby-2.4

  # add extra packages
  extra_packages:
    - nginx
    - nodejs
    - gettext-tools

  build_triggers:
    - Gemfile
    - Gemfile.lock

deploy.config:
  before_live:
    web.main:
      - rake db:schema:setup_or_migrate
  transform:
    - chown -R gonano:gonano /app/tmp
    - envsubst '$S3_BUCKET:$NGINX_PORT' < /app/deployment/nginx.template.conf > /app/deployment/nginx.conf

# PG DB
data.db:
  image: nanobox/postgresql
  cron:
    - id: backup
      schedule: '0 3 * * *'
      command: 'bash /app/deployment/production/backup-db'

# CACHE
data.redis:
  image: nanobox/redis:3.0

# API
web.main:
  start:
    puma: bundle exec puma -C ./config/puma.rb -b unix:///app/sockets/puma.sock
    nginx: /app/deployment/start-nginx

  writable_dirs:
    - tmp
    - log
    - sockets
    - public

  # the path to a logfile you want streamed to the nanobox dashboard
  log_watch:
    rails: 'log/production.log'
    nginx: 'log/nginx.access.log'
    nginx_error: 'log/nginx.error.log'

# SIDEKIQ
worker.jobs:
  start: bundle exec sidekiq

  # add writable dirs to the web component
  writable_dirs:
    - tmp
    - log

  log_watch:
    sidekiq: 'log/sidekiq.log'

looks like doing
nanobox build-runtime fixed it.
weird. :-\


[EPIC] Generalize App: Make the App More Inclusive (Update Diaper Language)

Tossing my idea into the hat for names.
GivingBank? Or GivingBase?

Wasn't this decided during the PHR thing? "Human Needs" or something along those lines?
Are there specific pages that need language updating?


Warnings in Parcel

I'm getting the following warnings when using timeago.js in a webapp build with Parcel:

because of npm package do not contains src file?

@hustcc correct, but then there should be no references to the src folder at least.

may be I should release a new version which contains src, or remove all the sourcemap files.

Still seeing this. Any updates?

@hustcc I could give it a try if you decide which route you want to go, i.e. what you want to be done.


fix NPE if queueBufferLength is null in KafkaEightSimpleConsumerFireh…

…oseFactory
 Preconditions.checkArgument(queueBufferLength > 0, "queueBufferLength must be positive number");
should be
 Preconditions.checkArgument(this.queueBufferLength > 0, "queueBufferLength must be positive number");

👍

:+1:


Broadphase; Basic Button Interaction

The standard Hover now takes into account spaces, so curved elements may now be be considered transparently with real ones for hovering. If the primary hovered UI element occurs within a curved space, the interaction hand will warp to that space for interactions (this includes brush hands, soft contact, and the grab classifier).
Additionally, this PR adds a test scene with 50 buttons to stress-test the new collision system. The buttons are based off of the "PhysicsUI.cs" buttons, but do away with the complicated hierarchy and springs. Additionally, they only enable their own contact-ability when they are the "primary hover" (visualized by the red tinting).

Oh boy, the above doesn't look good...


Disable IPv6 if it's not route-able

This is definitely not an optimal solution, because if one IPv6 address is not route-able, then IPv6 is permanently disabled for that process.
Does anyone have better ideas?

See #44 instead.


Adapt to Terra's new Qubit class

Ignis needs to be updated for Terra's new Qubit and Clbit classes as well.

current failures are due to test_hhl's usage of ignis' tomography
will be fixed if this PR is merged: https://github.com/Qiskit/qiskit-ignis/pull/200

on hold because this
https://github.com/Qiskit/qiskit-terra/pull/2499


"npm install steroids -g" fails with npm 3

CURRENT WORKAROUND: Use npm v2.x by running npm install<EMAIL_ADDRESS>-g
DESCRIPTION OF PROBLEM
Trying to run npm install steroids -g with npm v3.x results in the following error log:
  SOLINK_MODULE(target) Release/.node
ld: library not found for -lgcc_s.10.5
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Release/.node] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/harsa/.nvm/v0.12.7/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Darwin 14.5.0
gyp ERR! command "node" "/Users/harsa/.nvm/v0.12.7/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/harsa/.nvm/v0.12.7/lib/node_modules/steroids/node_modules/fsevents
gyp ERR! node -v v0.12.7
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok
/Users/harsa/.nvm/v0.12.7/lib
└── (empty)

npm WARN EPEERINVALID<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm ERR! Darwin 14.5.0
npm ERR! argv "node" "/Users/harsa/.nvm/v0.12.7/bin/npm" "install" "steroids" "-g"
npm ERR! node v0.12.7
npm ERR! npm  v3.3.6
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the fsevents package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls fsevents
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/harsa/tmp/npm-debug.log
npm ERR! code 1

The steroids command is still available and e.g. steroids create works fine. However, the grunt-steroids peer dependencies don't install correctly with npm v3.x, leading to steroids connect failing.

Hi Harsa -
I downgraded my npm version 3 to npm version 2 but I still get the below error when installing Steroids:
Yeoman Doctor
Running sanity checks on your system
✔ Global configuration file is valid
✔ NODE_PATH matches the npm root
✔ Node.js version
✔ No .bowerrc file in home directory
✔ No .yo-rc.json file in home directory
✖ npm version
Your npm version is outdated.
Upgrade to the latest version by running:
npm install -g npm
Found potential issues on your machine :(
/usr/local/bin/steroids -> /usr/local/lib/node_modules/steroids/bin/steroids


Should be an option for rotating the barcode in the object that are passed into JsBarcode

Maybe an option where you define degrees?

is there any workaround ?


Unable to add option when using setPlayerImpl(VideoInfo.PLAYER_IMPL_SYSTEM)

Hello Tcking,
I use the option "setPlayerImpl(VideoInfo.PLAYER_IMPL_SYSTEM)" to get rid of issue playing some HTTPS links, it works perfect, but i'm unable to add user-agent when using this option

                 GiraffePlayer.play(getContext(), new VideoInfo(LinkValue.get(position))
                                    .setTitle(item.getShowName() + ", " + item.getSeason() + " - " + item.getName())
                                    .setFullScreenOnly(true)
                                    .setPlayerImpl(VideoInfo.PLAYER_IMPL_SYSTEM)
                                    .setBgColor(Color.BLACK)
                                    .addOption(Option.create(IjkMediaPlayer.OPT_CATEGORY_FORMAT, "headers",  LinkCookie.get(position) != null ? LinkCookie.get(position).replaceAll(";", "") : null))
                                    .addOption(Option.create(IjkMediaPlayer.OPT_CATEGORY_FORMAT, "user-agent", GLOBAL_GIRAFFE.USERAGENT))
                    );

the option ".addOption(Option.create(IjkMediaPlayer.OPT_CATEGORY_FORMAT, "user-agent", GLOBAL_GIRAFFE.USERAGENT))" has no effect, but when i remove ".setPlayerImpl(VideoInfo.PLAYER_IMPL_SYSTEM)", then user-agent works fine.
I was not able to test cookie as well, i think it will have same issue when using default android media player.
Please advise how i use the two options at same time.
Thanks a lot

this is a bug that addOptions "headers" not work for MediaPlayer, it will fixed at next version


Virtual EMR clusters

Hi
Has anyone tried using dbt-spark against a virtual EMR. Luster running on EKS. Or do you know what the process might be?
Thanks
Mark

Hi there pixie! Have you found a solution? Have you asked in db-spark on the dbt Slack by chance?


Fix: Updated install-and-setup.md (typo)

Removed unnecessary comma in comment

@ZionDials mind resubmitting? The PR was stuck in a bad state.


about: minor grammatical fixes

Changes

The Git -> Git
In some cases, adding a comma after an introductory phrase helps with readability ;-)

Thanks, both changes look good to me!


Search SDK: Adding missing descriptions to preview SDK

Description
Adding comments to generated code that were missing from the Swagger spec. See related PR https://github.com/Azure/azure-rest-api-specs-pr/pull/54
FYI @Yahnoosh @mhko

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] I have read the contribution guidelines.
[X] The pull request does not introduce breaking changes.

General Guidelines

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[X] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[X] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
[X] The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

:shipit:


Feedback in the lab

Some problems in visualization:

More informative labels
The prediction visualization is not effective
The x-axis in the plots should be more clear: do not use decimal numbers, and adjust the angle

I have  addressed all the issues above.
Prediction plot has been changed.
Decimal places has all been removed.


Add CLAP demo (semantic audio search app)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

This is awesome. Thank you


[MAPREDUCE-7193] Review of CombineFile Code

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
25
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
13
Maven dependency ordering for branch

+1
mvninstall
1060
trunk passed

+1
compile
109
trunk passed

+1
checkstyle
39
trunk passed

+1
mvnsite
67
trunk passed

+1
shadedclient
719
branch has no errors when building and testing our client artifacts.

+1
findbugs
85
trunk passed

+1
javadoc
34
trunk passed

_ Patch Compile Tests _

0
mvndep
10
Maven dependency ordering for patch

+1
mvninstall
56
the patch passed

+1
compile
106
the patch passed

+1
javac
106
the patch passed

-0
checkstyle
37
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 4 new + 56 unchanged - 20 fixed = 60 total (was 76)

+1
mvnsite
65
the patch passed

-1
whitespace
0
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
674
patch has no errors when building and testing our client artifacts.

+1
findbugs
99
the patch passed

+1
javadoc
30
the patch passed

_ Other Tests _

+1
unit
300
hadoop-mapreduce-client-core in the patch passed.

-1
unit
8326
hadoop-mapreduce-client-jobclient in the patch failed.

-1
asflicense
33
The patch generated 1 ASF License warnings.

11928

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 637ab6457183 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 091a664

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/whitespace-eol.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1615 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
52
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
36
Maven dependency ordering for branch

+1
mvninstall
1214
trunk passed

+1
compile
138
trunk passed

+1
checkstyle
47
trunk passed

+1
mvnsite
81
trunk passed

+1
shadedclient
823
branch has no errors when building and testing our client artifacts.

+1
findbugs
103
trunk passed

+1
javadoc
37
trunk passed

_ Patch Compile Tests _

0
mvndep
11
Maven dependency ordering for patch

+1
mvninstall
70
the patch passed

+1
compile
135
the patch passed

+1
javac
135
the patch passed

-0
checkstyle
44
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 4 new + 56 unchanged - 20 fixed = 60 total (was 76)

+1
mvnsite
74
the patch passed

-1
whitespace
0
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1
shadedclient
794
patch has no errors when building and testing our client artifacts.

+1
findbugs
123
the patch passed

+1
javadoc
33
the patch passed

_ Other Tests _

+1
unit
312
hadoop-mapreduce-client-core in the patch passed.

-1
unit
7559
hadoop-mapreduce-client-jobclient in the patch failed.

-1
asflicense
36
The patch generated 1 ASF License warnings.

11761

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 003f60fc4836 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 091a664

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/artifact/out/whitespace-eol.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1174 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
24
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
29
Maven dependency ordering for branch

+1
mvninstall
972
trunk passed

+1
compile
111
trunk passed

+1
checkstyle
40
trunk passed

+1
mvnsite
67
trunk passed

+1
shadedclient
706
branch has no errors when building and testing our client artifacts.

+1
findbugs
86
trunk passed

+1
javadoc
30
trunk passed

_ Patch Compile Tests _

0
mvndep
10
Maven dependency ordering for patch

+1
mvninstall
59
the patch passed

+1
compile
113
the patch passed

+1
javac
113
the patch passed

-0
checkstyle
37
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)

+1
mvnsite
65
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
691
patch has no errors when building and testing our client artifacts.

+1
findbugs
98
the patch passed

+1
javadoc
31
the patch passed

_ Other Tests _

+1
unit
309
hadoop-mapreduce-client-core in the patch passed.

-1
unit
8229
hadoop-mapreduce-client-jobclient in the patch failed.

-1
asflicense
42
The patch generated 1 ASF License warnings.

11790

Reason
Tests

Failed junit tests
hadoop.mapred.TestLazyOutput

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux bcb1af03ac72 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 2627dad

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1599 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
38
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
13
Maven dependency ordering for branch

+1
mvninstall
1058
trunk passed

+1
compile
114
trunk passed

+1
checkstyle
33
trunk passed

+1
mvnsite
71
trunk passed

+1
shadedclient
731
branch has no errors when building and testing our client artifacts.

+1
javadoc
36
trunk passed

0
spotbugs
42
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
109
trunk passed

_ Patch Compile Tests _

0
mvndep
10
Maven dependency ordering for patch

+1
mvninstall
60
the patch passed

+1
compile
112
the patch passed

+1
javac
112
the patch passed

-0
checkstyle
32
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)

+1
mvnsite
66
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
694
patch has no errors when building and testing our client artifacts.

+1
javadoc
29
the patch passed

+1
findbugs
123
the patch passed

_ Other Tests _

+1
unit
313
hadoop-mapreduce-client-core in the patch passed.

-1
unit
7568
hadoop-mapreduce-client-jobclient in the patch failed.

-1
asflicense
43
The patch generated 1 ASF License warnings.

11297

Reason
Tests

Failed junit tests
hadoop.mapred.TestTaskCommit

hadoop.mapred.TestMerge

hadoop.mapred.TestMiniMRChildTask

hadoop.mapred.TestYARNRunner

hadoop.mapred.TestMiniMRClientCluster

hadoop.mapred.TestMRTimelineEventHandling

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 9f95aa6a18ee 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cd967c7

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1575 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
10
Maven dependency ordering for branch

+1
mvninstall
1035
trunk passed

+1
compile
118
trunk passed

+1
checkstyle
31
trunk passed

+1
mvnsite
75
trunk passed

+1
shadedclient
744
branch has no errors when building and testing our client artifacts.

+1
javadoc
38
trunk passed

0
spotbugs
43
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
104
trunk passed

_ Patch Compile Tests _

0
mvndep
10
Maven dependency ordering for patch

+1
mvninstall
58
the patch passed

+1
compile
109
the patch passed

+1
javac
109
the patch passed

-0
checkstyle
29
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)

+1
mvnsite
63
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
700
patch has no errors when building and testing our client artifacts.

+1
javadoc
30
the patch passed

+1
findbugs
134
the patch passed

_ Other Tests _

+1
unit
310
hadoop-mapreduce-client-core in the patch passed.

-1
unit
8148
hadoop-mapreduce-client-jobclient in the patch failed.

-1
asflicense
34
The patch generated 1 ASF License warnings.

11853

Reason
Tests

Failed junit tests
hadoop.mapreduce.TestMRJobClient

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 38445c7fe622 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c0a0c35

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1663 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
80
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
16
Maven dependency ordering for branch

+1
mvninstall
1336
trunk passed

+1
compile
145
trunk passed

+1
checkstyle
44
trunk passed

+1
mvnsite
94
trunk passed

+1
shadedclient
944
branch has no errors when building and testing our client artifacts.

+1
javadoc
41
trunk passed

0
spotbugs
47
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
121
trunk passed

_ Patch Compile Tests _

0
mvndep
11
Maven dependency ordering for patch

+1
mvninstall
72
the patch passed

+1
compile
139
the patch passed

+1
javac
139
the patch passed

-0
checkstyle
38
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)

+1
mvnsite
81
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
854
patch has no errors when building and testing our client artifacts.

+1
javadoc
36
the patch passed

+1
findbugs
142
the patch passed

_ Other Tests _

+1
unit
331
hadoop-mapreduce-client-core in the patch passed.

-1
unit
8417
hadoop-mapreduce-client-jobclient in the patch failed.

-1
asflicense
41
The patch generated 1 ASF License warnings.

13005

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 439e02a873ae 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e20b195

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1189 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
11
Maven dependency ordering for branch

+1
mvninstall
1167
trunk passed

+1
compile
127
trunk passed

+1
checkstyle
40
trunk passed

+1
mvnsite
77
trunk passed

+1
shadedclient
850
branch has no errors when building and testing our client artifacts.

+1
javadoc
40
trunk passed

0
spotbugs
47
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
127
trunk passed

_ Patch Compile Tests _

0
mvndep
10
Maven dependency ordering for patch

+1
mvninstall
86
the patch passed

+1
compile
118
the patch passed

+1
javac
118
the patch passed

-0
checkstyle
37
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)

+1
mvnsite
65
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
832
patch has no errors when building and testing our client artifacts.

+1
javadoc
34
the patch passed

+1
findbugs
122
the patch passed

_ Other Tests _

+1
unit
314
hadoop-mapreduce-client-core in the patch passed.

-1
unit
7536
hadoop-mapreduce-client-jobclient in the patch failed.

-1
asflicense
40
The patch generated 1 ASF License warnings.

11713

Reason
Tests

Failed junit tests
hadoop.mapred.TestMerge

hadoop.mapred.TestMiniMRClientCluster

hadoop.mapred.TestReduceFetch

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 0c06a6e9e650 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 70b4617

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1187 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
82
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
10
Maven dependency ordering for branch

+1
mvninstall
1115
trunk passed

+1
compile
105
trunk passed

+1
checkstyle
33
trunk passed

+1
mvnsite
61
trunk passed

+1
shadedclient
749
branch has no errors when building and testing our client artifacts.

+1
javadoc
35
trunk passed

0
spotbugs
37
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
99
trunk passed

_ Patch Compile Tests _

0
mvndep
12
Maven dependency ordering for patch

+1
mvninstall
58
the patch passed

+1
compile
98
the patch passed

+1
javac
98
the patch passed

-0
checkstyle
30
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)

+1
mvnsite
56
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
745
patch has no errors when building and testing our client artifacts.

+1
javadoc
30
the patch passed

+1
findbugs
115
the patch passed

_ Other Tests _

+1
unit
334
hadoop-mapreduce-client-core in the patch passed.

-1
unit
7298
hadoop-mapreduce-client-jobclient in the patch failed.

-1
asflicense
42
The patch generated 2 ASF License warnings.

11153

Reason
Tests

Failed junit tests
hadoop.mapred.TestReduceFetch

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4d31fe2ae987 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e356e4f

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1604 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
65
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
9
Maven dependency ordering for branch

+1
mvninstall
1123
trunk passed

+1
compile
97
trunk passed

+1
checkstyle
31
trunk passed

+1
mvnsite
58
trunk passed

+1
shadedclient
699
branch has no errors when building and testing our client artifacts.

+1
javadoc
34
trunk passed

0
spotbugs
39
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
105
trunk passed

_ Patch Compile Tests _

0
mvndep
11
Maven dependency ordering for patch

+1
mvninstall
60
the patch passed

+1
compile
111
the patch passed

+1
javac
111
the patch passed

-0
checkstyle
39
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)

+1
mvnsite
63
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
717
patch has no errors when building and testing our client artifacts.

+1
javadoc
28
the patch passed

+1
findbugs
111
the patch passed

_ Other Tests _

+1
unit
334
hadoop-mapreduce-client-core in the patch passed.

-1
unit
6917
hadoop-mapreduce-client-jobclient in the patch failed.

-1
asflicense
34
The patch generated 2 ASF License warnings.

10703

Reason
Tests

Failed junit tests
hadoop.mapreduce.lib.output.TestJobOutputCommitter

hadoop.mapreduce.v2.TestUberAM

hadoop.mapreduce.lib.join.TestJoinDatamerge

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7cf1e633f128 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 094d736

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1562 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
10
Maven dependency ordering for branch

+1
mvninstall
1161
trunk passed

+1
compile
104
trunk passed

+1
checkstyle
38
trunk passed

+1
mvnsite
67
trunk passed

+1
shadedclient
763
branch has no errors when building and testing our client artifacts.

+1
javadoc
45
trunk passed

0
spotbugs
44
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
113
trunk passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
64
the patch passed

+1
compile
102
the patch passed

+1
javac
102
the patch passed

-0
checkstyle
32
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)

+1
mvnsite
58
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
784
patch has no errors when building and testing our client artifacts.

+1
javadoc
38
the patch passed

+1
findbugs
117
the patch passed

_ Other Tests _

+1
unit
336
hadoop-mapreduce-client-core in the patch passed.

-1
unit
7092
hadoop-mapreduce-client-jobclient in the patch failed.

-1
asflicense
34
The patch generated 1 ASF License warnings.

11057

Reason
Tests

Failed junit tests
hadoop.mapred.TestJobSysDirWithDFS

hadoop.mapred.TestMiniMRClasspath

hadoop.mapred.TestMRTimelineEventHandling

hadoop.mapred.jobcontrol.TestLocalJobControl

hadoop.mapred.TestNetworkedJob

hadoop.mapred.TestReduceFetch

hadoop.mapred.TestJobName

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux bec3cb8d15a6 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 69ddb36

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/testReport/

asflicense
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1582 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/10/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
13
Maven dependency ordering for branch

+1
mvninstall
1105
trunk passed

+1
compile
110
trunk passed

+1
checkstyle
37
trunk passed

+1
mvnsite
76
trunk passed

+1
shadedclient
796
branch has no errors when building and testing our client artifacts.

+1
javadoc
43
trunk passed

0
spotbugs
44
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
108
trunk passed

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

+1
mvninstall
68
the patch passed

+1
compile
110
the patch passed

+1
javac
110
the patch passed

-0
checkstyle
35
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 56 unchanged - 20 fixed = 59 total (was 76)

+1
mvnsite
64
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
788
patch has no errors when building and testing our client artifacts.

-1
javadoc
19
hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-1
findbugs
25
hadoop-mapreduce-client-core in the patch failed.

-1
findbugs
19
hadoop-mapreduce-client-jobclient in the patch failed.

_ Other Tests _

-1
unit
24
hadoop-mapreduce-client-core in the patch failed.

-1
unit
20
hadoop-mapreduce-client-jobclient in the patch failed.

+1
asflicense
32
The patch does not generate ASF License warnings.

3612

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3e5be9795b52 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3329257

Default Java
1.8.0_222

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/patch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-610/11/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 23s
trunk passed

+1 :green_heart:
compile
2m 14s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
1m 56s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 45s
trunk passed

+1 :green_heart:
mvnsite
1m 17s
trunk passed

+1 :green_heart:
shadedclient
16m 12s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 50s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 48s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
0m 46s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 56s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  1s
the patch passed

+1 :green_heart:
compile
2m  7s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
2m  7s
the patch passed

+1 :green_heart:
compile
1m 50s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
1m 49s
the patch passed

-0 :warning:
checkstyle
0m 34s
hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 3 new + 55 unchanged - 20 fixed = 58 total (was 75)

+1 :green_heart:
mvnsite
1m  0s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 59s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 40s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
2m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
6m 48s
hadoop-mapreduce-client-core in the patch passed.

+1 :green_heart:
unit
140m 46s
hadoop-mapreduce-client-jobclient in the patch passed.

-1 :x:
asflicense
0m 47s
The patch generated 1 ASF License warnings.

230m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/610

JIRA Issue
MAPREDUCE-7193

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a9508182a1ba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e5fe3262702

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-610/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-610/1/artifact/out/patch-asflicense-problems.txt

Max. process+thread count
1320 (vs. ulimit of 5500)

modules
C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-610/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


fixed misspelling

fixed misspelling: Autoriesierung > Autorisierung

Thanks for the PR.
The Apache Tomcat project manages translations via POEditor. Anyone is free to create an account an contribute there:
https://poeditor.com/projects/view?id=221603
I have applied this fix to the German translations at poeditor.com and will import it shortly.


Add Grandine support to the DB

We should support Grandine in the DB. This will be a breaking schema change unfortunately, as it introduces a new column (pr_grandine). We could provide a simple migration script to upgrade existing DBs so they don't need to be rebuilt from scratch.

Implemented in #27


Not working with Venice

When I call socket.receiveString() in a Venice Coroutine, the app blocks inside the coroutine.
Example
When I run the following code, it prints running coroutine and then blocks.
import ZeroMQ
import Venice

let context = try Context()

let inbound = try context.socket(.Pull)
try inbound.bind("tcp://<IP_ADDRESS>:5555")

co {
    print("running coroutine")
    do {
        while let data = try inbound.receiveString() where data != "Bye!" {
            print(data)
        }
    } catch {
        print("An error occured")
    }
}

print("sending messages outside the coroutine")

let outbound = try context.socket(.Push)
try outbound.connect("tcp://<IP_ADDRESS>:5555")

try outbound.sendString("Hello World!")
try outbound.sendString("Bye!")

Am I using Venice wrong or is this a bug?

@Dev1an
Because in example above it don't used venice polling. So it's blocks a thread.
To avoid this you should use Venice.poll
E.g.
public class ZmqConnection {
    let socket: ZeroMQ.Socket
    let address: String
    var polled: Venice.PollEvent? = nil
    var fd: Int32 {
        return try! socket.getFileDescriptor()
    }
    init(address: String, type: SocketType) {
        self.address = address
        socket = try! context.socket(type)
    }
    public func connect() throws {
        try socket.connect(address)
    }
    func read() -> [Data]? {
        if polled == nil {
            polled = try! Venice.poll(fd, for: .reading)
            guard polled!.contains(.reading) else {
                return nil
            }
        }
        let events = try! socket.getEvents()!
        if events.contains(.In) {
            var msg_parts: [Data] = []
            while true {
                guard let array = try! socket.receive() else {
                    break
                }
                msg_parts.append(array)
                if !(try! socket.getReceiveMore()) {
                    break
                }
            }
            return msg_parts
        } else {
            polled = nil
            return nil
        }

    }
}

But I'm not sure it's works 100%


Unifying generic type names, removing redundant annotations and more consistency in code

This just cleans up the resumable code a bit in an effort to make all the type aliases more consistent, using same type names throughout, and removing redundant type annotations (less clutter, better readability).
No functional changes here.

The main change here is that people will get cleaner tooltips, and that the code is a tad more readable now. Part of the 0.4.0 push.