un-@Ignore all tests in SchedulerJobsTestResults using FINERACT-922 [FINERACT-857]

using FINERACT-922 for FINERACT-857

@ptuomola if this actually passes on Travis (I'm curious...) I'm sure you're in favour of merging this? :smile_cat:
@xurror @awasum feel free to do the honours (if it passes the build; it worked locally, but let's see).

@vorburger unfortunately failed on Travis. My guess (based on no further analysis than looking at the Travis log) is that some other tests insert crap data (missing office_id?) that then breaks the scheduled jobs. If that's the case, shouldn't be too hard to find which tests insert the broken data...

This may not be related to this PR but travis keeps showing pending on the UI when the CI already ran. Also our language on the Travis config is showing Ruby: https://travis-ci.org/github/apache/fineract/jobs/695680352/config . This may not be important but I just saw that and was curious.

@awasum I think the "ruby" in the config is due to our .travis.yml no longer having any language tag in it. We install Java manually as the default Java version that you get by specifying java as language is broken for HTTPS certificate handling.
But instead of having no language defined (defaulting to ruby), we could try "language: minimal" or "language: generic" - those may be more appropriate?
And yes, I also noticed the "pending" status for Travis in Github - but no idea why that happens...

My guess (based on no further analysis than looking at the Travis log) is that some other tests insert crap data (missing office_id?) that then breaks the scheduled jobs. If that's the case, shouldn't be too hard to find which tests insert the broken data...

@ptuomola I don't know when I'll have to properly debug this.. if you are looking for ways to contribute, and didn't have any other plans already, and would enjoy doing this, and... (your constraints here), please by all means feel free to jump into this! I would, very gladly, let you do this.
PS: The .travis.yml was addressed in #1008.

@vorburger I looked into this, and interestingly it wasn't a test or test data issue at all, but actually two real bugs in Fineract.
I've created a new PR that includes both moving to executeAndAwaitJob() as well as fixes to the bugs: https://github.com/apache/fineract/pull/1049. Let's see if that passes the Travis build.

==> 1049


SetMembers configurable origin

It makes setMembers origin configurable in pallet_collective, with the goal of configuring an OpenGov origin that is able to change collective members
polkadot companion: https://github.com/paritytech/polkadot/pull/6620
cumulus companion: https://github.com/paritytech/cumulus/pull/2136

Will open that PR too

@ggwpez can we get a review/merge for this one please ? :)

Do we expect Collective pallet to keep being used after OpenGov? Anywhere in particular?

@gavofyork yes, mostly for parachains for which the fellowship system is not suitable, or for non governance ones

bot merge

bot merge


esp_get_idf_version() gives incorrect SDK version (IDFGH-10229)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
Release v5.0.2
Operating System used.
Linux
How did you build your project?
VS Code IDE
If you are using Windows, please specify command line type.
None
Development Kit.
ESP32-WROOM-32E
Power Supply used.
USB
What is the expected behavior?
In the esp-idf v5.0.2, the command esp_get_idf_version() gives 5.0.1 but ESP_IDF_VERSION_MAJOR, ESP_IDF_VERSION_MINOR, ESP_IDF_VERSION_PATCH gives 5.0.2
Seems to be some sort of bug on esp_get_idf_version()
What is the actual behavior?
That esp_get_idf_version() and ESP_IDF_VERSION_MAJOR, ESP_IDF_VERSION_MINOR, ESP_IDF_VERSION_PATCH gave the same esp-idf version
Steps to reproduce.
printf the output of esp_get_idf_version() and ESP_IDF_VERSION_MAJOR, ESP_IDF_VERSION_MINOR, ESP_IDF_VERSION_PATCH and compare the outputs
Debug Logs.
esp_get_idf_version() gives 5.0.1

ESP_IDF_VERSION_MAJOR, ESP_IDF_VERSION_MINOR, ESP_IDF_VERSION_PATCH gives 5.0.2

More Information.
No response

Not sure how you would end up with 5.0.1, esp_get_idf_version() just gets the output from git describe (and gives 5.0.2 on v5.0.2 when I tested right now).
What do you get when you run git describe in your esp-idf repo?  Thank you so much for your fast response. Closing.


[GF UI] Create Infotip Button component

Description
Create a Figma component infotip button.  The button toggles the visibility of the overlay. The overlay contains the info content.
Technical Details
-create infotip button: text+Button Icon (with "info" icon)
-create tooltip component
-variants (states): default, hover, pressed
-Variant: Large screen=true/false
-guide (use case): usage
-guide (use case): positioning
Spec Acceptance Criteria

[ ]  Guide has three sections : Anatomy, Dimension, Use Cases. ( Can omit boards not applicable)
[ ]  Guide’s anatomy contains all necessary component references & links.
[ ]  Each visual variants ( types, states) have a visual representation, so dev can inspect.
[ ]  Visual references have correct tokens & styles applied (color, shadow, text).
[ ]  Component is added to Notion table with matching name, with Figma link.
[ ]  Resolve old/outstanding comments.
All Figma components & Boards have consistent & correct Namings
(Component Naming System : https://www.notion.so/Component-Naming-System-Draft-6d59eb23d42b483f9f4648506fdb1c29)

Design Component Acceptance Criteria

[ ]  Components have necessary variants with consistent naming, and clear labeling.
[ ]  Components have correct Design Tokens assigned: Color, typography, shadows and spacing.
[ ]  Components are responsive with text overflow handled.
[ ]  Components are tested in a prototype and viewed in its respective context (mobile or extension)
[ ]  Resolve old/outstanding comments.
[ ]  Component is added to Notion table with status set to “ Figma Done”, and has a Figma link.
[ ]  Add update details to the “Upcoming” release note.

References

https://ebay.gitbook.io/mindpatterns/disclosure/infotip
-https://clarity.design/documentation/signposts

Created a Data component for figma design
component called "Key + Value"
https://www.figma.com/file/HKpPKij9V3TpsyMV1TpV7C/DS-Components?node-id=9790%3A37079


Show event name in finishTimingEvent warning

Another quick fix. I found it useful to see actual event name in finishTimingEvent method warning so I can track down the problem easily. :bug:

For sure!


Documentation about Yaml, mention it as discouraged to use?

Q
A

BC Break
no

Version
2.6

Summary
The documentation page about Yaml does not mention anything about it being removed/unsupported in the future. I think it's a good idea to mention on here that it's discouraged to use Yaml as configuration.
Whenever I see people suggest to not use Yaml because it's going to be removed as core supported configuration, the response is usually "oh I did not know that".

@doctrine/team-documentation can we do something about this one?

I would be +1 for removing it on the latest minor version docs. Basically, because it is now deprecated, why show it at all? Older versions of the docs will still exist for existing users to reference. We can cleanup the new version right now.

It's already known to be deprecated and 2.6 is the current documentation. If a developer takes a look at the documentation, and doesn't see a deprecation, chances are that everything is going to be created in Yaml. This is a waste of time for the developer because it's already known to disappear with 3.0. Not letting the developer know this as soon as possible, will thus result in extra work while it was not necessary.

@iltar I've created PR #7374. Does it cover this issue?

#7374 has been merged into 2.6.
https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/yaml-mapping.html#yaml-mapping


Trackers bypasses not working

Domain
https://bit.ly
Link
https://bit.ly/3tpucsF
Version
0.0.0
What browsers are you seeing the problem on?
Chrome
What OS are you seeing the problem on?
Windows
Anything else?
when I enter a bit.ly link, FastForward doesn't bypass it. (continues with "bypassed 11 sites for you")

I'm still redirected to youtube... But yes, the API has been discontinued, this is currently out of our hands.
If anyone knows a similar api that we could use, replacing apimon.de

Maybe unshorten.me could be used? https://unshorten.me/api

https://bypass.vip/

Maybe unshorten.me could be used? https://unshorten.me/api

Doesn't seem to resolve new URLs anymore

What do you mean? Works fine?

try https://t.co/BJCe4w8BPR which is a new one and isn't stored in their database

try https://t.co/BJCe4w8BPR which is a new one and isn't stored in their database

It works with other websites, twitter links probably don't work because of Musk's dumbass view restrictions.

try https://t.co/BJCe4w8BPR which is a new one and isn't stored in their database

You know what the funniest thing about twitter short urls is? Their internal API which the website uses serves them, as well as the unshortened url itself

So we drop support for t.co and use unshorten.me ?

Does anyone know how I can get a full list of domains bypassed by unshorten.me?

Unpinning since this is done.

Unshorten.me now requires users to login for api requests

Merging with #1297


master - Strange message on Add stack page

Version  - master 4/15
Steps to Reproduce:

Add a stack

Results: Strange message at bottom

Expected: Not sure what that message is for

https://github.com/rancher/ui/pull/585

Message is no longer there.  Closing


python310Packages.python-xz: 0.4.0 -> 0.5.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.python-xz is: Pure Python library for seeking within compressed xz files
meta.homepage for python310Packages.python-xz is: https://github.com/Rogdham/python-xz
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.5.0 with grep in /nix/store/0wyb4sihm95a0znlnh9a39g4j0r8h0iq-python3.10-python-xz-0.5.0
found 0.5.0 in filename of file in /nix/store/0wyb4sihm95a0znlnh9a39g4j0r8h0iq-python3.10-python-xz-0.5.0

Rebuild report (if merged into master) (click to expand)

7 total rebuild path(s)

7 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.python-xz
python310Packages.ratarmount
python310Packages.ratarmountcore
python311Packages.python-xz
python311Packages.ratarmount
python311Packages.ratarmountcore
ratarmount

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0wyb4sihm95a0znlnh9a39g4j0r8h0iq-python3.10-python-xz-0.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.python-xz https://github.com/r-ryantm/nixpkgs/archive/5ba0241edfa35a1de253bd83ee61df0ab1d21ecd.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/5ba0241edfa35a1de253bd83ee61df0ab1d21ecd#python310Packages.python-xz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0wyb4sihm95a0znlnh9a39g4j0r8h0iq-python3.10-python-xz-0.5.0
ls -la /nix/store/0wyb4sihm95a0znlnh9a39g4j0r8h0iq-python3.10-python-xz-0.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

python310Packages.python-xz
ratarmount (python310Packages.ratarmount)
python310Packages.ratarmountcore
python311Packages.python-xz
python311Packages.ratarmount
python311Packages.ratarmountcore

Maintainer pings
cc @mxmlnkn for testing.

Looks good to me. Ratarmount depends on 0.4.x, will that still work after this change?

Was updated in https://github.com/NixOS/nixpkgs/pull/271586


Course browser by subject

Adds a course by subject browser which allows users to view a list of all courses of a given subject. Also includes navigation fixes and allows reviewers to edit the name and description of a dossier.
closes #521
closes #520
closes #519

Because you added a new button for the subject browser, we have a redundant button on the Browser page that doesn't actually work when clicked that should be removed.

Everything looks good except the 2 bits of feedback I gave, nice work.


DBT Image failed to build

Hi,
When i am going to run your terraform code, the DBT image is going to be failed by giving the below error! Could you please help to resolve it.
"dbt No module named 'jinja2._compat'"
The above error comes when building image using dockerfile at last step of running "dbt deps"
Thanks.

This does not make any difference in my case. I put your line under requirements.txt but still.
FROM python:3.7.4-slim-stretch
MAINTAINER nicor88
COPY requirements.txt .
RUN pip install -r requirements.txt
RUN pip install Jinja2
COPY config/profiles.dist.yml /root/.dbt/profiles.yml
WORKDIR /dbt
COPY dbt_project.yml /dbt/dbt_project.yml
COPY macros /dbt/macros
COPY models /dbt/models
COPY tests /dbt/tests
install dbt deps
RUN dbt deps


Resolve external context id if not DSpace URL

Resolves #30

if notification context id is an external URL attempt to resolve using HEAD request

We appear to have test failures: https://github.com/DSpace/DSpace/actions/runs/2253695317

Noted. Will look into tests.


Fix text centering for multi-line buttons including breaking long words.

The modification at lines 794 thru 824 fixes the issue of centering the text for the 2nd line of a button that has 2 lines of text.  The modification at lines 595 thru 607 fixes the issue of breaking and centering a long word to fit on a 2 line button.  This happens commonly with Japanese character strings, where the string contains no spaces.

@dotnet-policy-service agree company="Technotects, Inc."

Hey, would you be willing to send this to https://gitlab.winehq.org/mono/libgdiplus ?

Forwarded to https://gitlab.winehq.org/mono/libgdiplus/-/merge_requests/3 and merged there.


cmd: restic: clean up sort.SliceStable usage

The older API is still available in the Go stdlib (and will remain there
forever, thanks to Go's backwards compatibility guarantees). By
switching back to the pre-1.8 API this allows restic to be built on
older distributions that don't have a newer Go compiler (though it turns
out some of our vendors use the newer API, this is something
distributions can patch out themselves).
It also (in my opinion) makes the code much more readable (since
time.Time implements sort.Interface, there's no need to explicitly
implement it using .After and .Before). We've been carrying this patch
in openSUSE for a couple of releases and nobody seems to have noticed an
issue with it.
Signed-off-by: Aleksa Sarai<EMAIL_ADDRESS>Checklist

[x] I have read the Contribution Guidelines
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

Hey, thanks for your contribution!
I must admit that I don't particularly like it, because the order of the list now depends on the implementation of the sort.Interface of the restic.Snapshots type, here:
https://github.com/restic/restic/blob/beb208e1597a4b7d18705c12f045413056eafcdb/internal/restic/snapshot.go#L204-L220
Which is, unfortunately, very far away from the code that uses the list. I think that restic.Snapshots still has the functions is more an oversight than a conscious decision 😉
That it works at all has nothing to do with time.Time implementing sort.Interface (which is not the case).
So, I'm willing to merge this patch, but please be aware that the lowest version of Go that we will support is Go 1.9, mostly because of dependencies (see https://github.com/restic/restic/commit/67933008502a72d579f325584f3566535f63ccf1).

Ah, what's the version of Go you're using?

Ah, what's the version of Go you're using?

This was originally meant to fix building on Go versions as old as Go 1.7, but since writing this patch a few months ago, openSUSE Leap now has Go 1.9 -- meaning this is no longer required for us.
Personally I still prefer using sort.Interface because it reads more like idiomatic Go, but if you prefer using SliceStable specifically because it isn't "idiomatic" that's also fine. Feel free to close this. :smile_cat:

Ok, thanks for the feedback! I'm closing this issue :)


Avoid holding NR app lock during periodic redeployment

There's a missing commit before this one.

Thanks @jonmv. Yes, this one should come first: https://github.com/vespa-engine/vespa/pull/9159


Distributed channel no longer needs to watch secrets

Describe the bug
Originally, the distributed channel had a requirement to support multiple Kafka auth secrets, which were dynamically watched and resulted in the creation and deletion of Receiver services and deployments based on those credentials.  The use case for this has been deprecated but the kafkasecret controller remains in the controller code.
Expected behavior

Secret watching should be removed from the controller - modifying the (single) secret should adjust the behavior of existing and future dispatcher and receiver deployments (as it does now), but deletion and creation of secrets should not have any immediate effect on resources.
When a kafkachannel is reconciled, a missing secret should continue to cause the single reconciler service and deployment to be removed, but this should now also return a reconciliation error (as the single secret is mandatory).  Conversely, if the secret is present but the Receiver resources are missing, they should be created.
The default secret should no longer have the "eventing-kafka.knative.dev/kafka-secret" label as there is no need to locate them in this manner.
The secret should be located via new entries in the config-kafka configmap under the eventing-kafka.kafka field, named 'authSecretName' and 'authSecretNamespace' (to be consistent with similar consolidated channel behavior), with defaults of 'kafka-cluster' and 'knative-eventing' respectively.
The Receiver service and deployment should have a constant name ("kafka-cluster-receiver") instead of the current hash-based name

To Reproduce
Create multiple Kafka secrets and observe that multiple Receiver deployments and services are created.
Knative release version
0.22.1
Additional context
If customers are using the original multi-Kafka ability, this cleanup will break that, so a hefty release note would be a good plan

/assign


Module closure notification

Is there an idiomatic way to get notified of module closure (e.g. a panic, or WASI proc_exit)?
My use case is releasing resources (closing a file) when the module crashes. I could check the return value of every function call but im wondering if there's a better way.
On a related note, and I haven't tested it yet, does WASI close files when the module closes? I'd consider it a bug if not (but haven't read the specs on it), and looking over the code I couldn't find anything ensuring FSContext.Close gets called.

right now, the only thing that shows you if something exited is in the experimental logger, which has LogScopeExit. This logs that the function was called, but it isn't about the fact that the underlying module was closed.
To know a module was closed even when not from a function (ex. defer closing it), we'd need a non-function hook like #1150
In any case, files are closed when the module is (syscontext does this or we'd have windows errors galore)

If I understood your second point correctly, this gets called always when the module closes:
https://github.com/tetratelabs/wazero/blob/a9b3301862be7bb33f8123898c84c63242f9e596/internal/wasm/call_context.go#L165-L181
I guess my RFE, if it makes sense, would be to be able to inject something like CodeCloser in there.
Unfortunately, I open my own files, from Go, not just because WASI overhead was considerable, but because I need file locking.
As for your first suggestion, it seems the idiomatic way (if this was not an experimental API) would be to follow this example, and check for errors on After.
I wonder what's the overhead of doing that, vs. wrapping all calls in my own function, which I think I'm already doing (mostly for ergonomic reasons).
Thanks, as always!

I guess my RFE, if it makes sense, would be to be able to inject something like CodeCloser in there.

I think this plumbing will be similar in nature to the request around a memory.grow hook. Basically the scope is anything, so it will get notified twice for folks using WASI, once for explicit close inside proc_exit and an implicit redundant close due to a defer rt.Close(ctx), unless we choose to not notify after closed.

I wonder what's the overhead of doing that, vs. wrapping all calls in my own function, which I think I'm already doing (mostly for ergonomic reasons).

IMHO the main plus on interceptors is decoupling vs performance of self-rolled, basically that you can make instrumentation code and have it hook in, and hook in on code you can't control.

Thanks, as always!

Thanks for the feedback and let us know how your thoughts progress. We'll likely revisit this after 1.0, as interceptors aren't intended to be permanently experimental :)

oh, so your main use case is to close module-scope resources, am I right?
If so, we have this in other places as well. Sometime soon after 1.0, we'll make a thing in hostmodulebuilder to allow hooks when a module is instantiated (allocate something on instantiate which is closed on close). This is needed for adding new types of sys calls, as some have different types of resources that should be module scoped (e.g. if someone wants to play with pre-opened sockets). cc @achille-roussel @Pryz

I know things change over time, so asking again for that reason. Does knowing if a module exited helped (#1573) or do we still need to expose a notification hook?

from @ncruces we should still pursue this

As Clifton, I'm solved with a wrapper, but there's still stuff I need to (or should) close as soon as the module exits for any reason and it'd make it easier:

like WASI I need to close file handles
I now also have generic handles (for callbacks, Go memory the WASM should force alive, etc) which could be GCed with the module, but were I special case io.Close to allow users to themselves open files or connections in there.

This would still be useful for the same reason ensureResourcesClosed still exists internally.
https://github.com/tetratelabs/wazero/blob/15fa5c4de50b628a3b979956e01184ecde9ee286/internal/wasm/module_instance.go#L143
This can be solved with a wrapper, though, and we can decide not to expose it.

PTAL https://github.com/tetratelabs/wazero/pull/1574


Add provisioning-fronternd integration script

The provisioning-wizard is a separate frontend app which is consumed for launching images in image-builder. In some cases, developers would like to develop and integrate both apps at once.
run npm run dev:hms
this script will
-  git clone provisioning-frontend and cloud-services-config to parent directory (if needed)
-  copy files and install npm modules
-  add local routes to webpack-proxy
-  run provisioning-frontend as federated module
-  run http server to serve the cloud-config locally
-  run image builder in stage-beta

@amirfefer can we close this now, given we are going the container compose way? :)

Stale PR, closing.


Etcd nodes need fluent-bit for logging

Since etcd is not hosted by k8s, we will not be able to capture its logs using the fluent-bit dameonset. One solution would be to render systemd units to deploy fluent-bit on etcd nodes.

Closing in favor of https://github.com/samsung-cnct/kraken-lib/issues/825

This issue was closed in favor of itself.  I am re-opening so we don't lose this as an issue.

So I did some preliminary work on this.
Using a simple kraken-fluent-bit.service unit file:
[Unit]
Description=Kraken fluent-bit for monitoring non-kubernetes nodes
After=kraken-networking.service
Requires=kraken-networking.service
[Service]
EnvironmentFile=/etc/network-environment
TimeoutStartSec=0
RestartSec=15
Restart=always
KillMode=none
ExecStart=/usr/bin/rkt run --net=host \
 --stage1-path=/usr/lib/rkt/stage1-images/stage1-fly.aci \
 --insecure-options=image \
 --inherit-env=true \
 --volume resolv-conf,kind=host,source=/etc/resolv.conf \
 --mount volume=resolv-conf,target=/etc/resolv.conf \
 quay.io/samsung_cnct/fluent-bit-container:latest
ExecStopPost=/usr/bin/rkt gc --mark-only

We get these errors:
Nov 05 20:38:06 ip-10-0-100-240.ec2.internal rkt[1814]: [2017/11/05 20:38:06] [ info] [filter_kube] https=1 host=kubernetes.default.svc port=443
Nov 05 20:38:06 ip-10-0-100-240.ec2.internal rkt[1814]: [2017/11/05 20:38:06] [error] [filter_kube] cannot open /var/run/secrets/kubernetes.io/serviceaccount/namespace
Nov 05 20:38:06 ip-10-0-100-240.ec2.internal rkt[1814]: [2017/11/05 20:38:06] [ info] [filter_kube] not running in a POD
Nov 05 20:38:06 ip-10-0-100-240.ec2.internal rkt[1814]: [2017/11/05 20:38:06] [error] [TLS] Invalid CA file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt | PK - Read/
Nov 05 20:38:06 ip-10-0-100-240.ec2.internal rkt[1814]: [2017/11/05 20:38:06] [ info] [filter_kube] testing connectivity with API server...
Nov 05 20:38:06 ip-10-0-100-240.ec2.internal rkt[1814]: [2017/11/05 20:38:06] [error] [filter_kube] could not get meta for POD (null)

There (at least) two ways to fix this

Modify the default fluent-bit.conf in https://github.com/samsung-cnct/container-fluent-bit to not assume a kubernetes cluster and then use ConfigMaps in https://github.com/samsung-cnct/chart-fluent-bit to configure the kubernetes nodes. One downside of this approach is that the container would not be useful for kubernetes nodes without a ConfigMap. I am not sure if this is really a downside, since we should be using ConfigMaps anyway.

Pass a non-kubernetes fluent-bit.conf into the systemd invocation of fluent-bit. One downside of this approach is that we would have to pass the config through our already crowded cloud-init.

I lean towards the former solution.

huge +1 to the first option.  we should be using configmaps for everything.

As an aside... cloud-config user_data is no longer all that crowded.


Documentation Metadata

Request
As a Contributor and Consumer of this project, I'd like to have API documentation available in the form of JSON abstracted from inline documentation within the source files.
Analysis
Implement a flow to convert from inline TSDoc to JSON metadata to be consumed locally. This will likely include using the following packages:

eslint-plugin-tsdoc

Should enforce the requirements for commonly needed tags. May need to also use eslint-plugin-jsdoc

api-extractor
api-documenter

Requirements

[x] Generates consumable JSON articles based on TSDoc within source code
[x] Produces documentation within the ./docs/metadata folder for each package

#55


instanceof AbstractClass.constructor should narrow to typeof AbstracClass

Please try to reproduce the issue with typescript@next. It may have already been fixed.

TypeScript Version:  3.3.0-dev.20181208

Search Terms: static instanceof constructor
Code
type Meta = {foo: string};
abstract class Abstract {
  static meta: Meta;
  public abstract toString(): string;
}

const getMeta = (fromModule: any): Meta | undefined => {
  return fromModule instanceof Abstract.constructor
    ? fromModule.meta : undefined;
};

Expected behavior:
Narrow the type of fromModule to typeof Abstract, so that static fields can be accessed.
(In Typescript versions <= 3.1.6 the above code didn't raise an error, my guess is that the type was not narrowed at all)
Actual behavior:
The narrowed type of fromModule is {}:
Error:(10, 18) TS2339: Property 'meta' does not exist on type '{}'.

Playground Link:
https://www.typescriptlang.org/play/index.html#src=
type Meta %3D {foo%3A string}%3B
abstract class Abstract {
  static meta%3A Meta%3B
  public abstract toString()%3A string%3B
}

const getMeta %3D (fromModule%3A any)%3A Meta | undefined %3D> {
  return fromModule instanceof Abstract.constructor
    %3F fromModule.meta %3A undefined%3B
}%3B

Related Issues:
I found the following potentially related issues but they didn't seem to be an exact match or to old (because this problem only exists since 3.2.1):
- #27276
- #23274
- #16035
Workaround
Creating a type guard is of course doable for a single abstract class.
const extendsAbstract = (FromModule: unknown): FromModule is typeof Abstract =>
  FromModule && FromModule instanceof Abstract.constructor;

(Or maybe it could even be written in a generic way?)

Ref #3841, which is related


fix/sft-trainer

Since trl>=0.13.0.dev0, we need to move ['max_seq_length', 'dataset_num_proc', 'packing', 'dataset_text_field'] to SFTConfig .
Hence, we need to implement patch into SFTTrainer for backward compatibility. Here's an example of using old API on newest trl. Note that I give warning if it possible to user to move to SFTConfig instead.

And here's using the new API :

Old API working in Colab using Old version

Old API working in Colab using new version

SFTTrainer old API

SFTTrainer new API

DPOTrainer old API

DPOTrainer new API

ORPO is also working

@Erland366 I added an auto import so it patches all TRL modules - if it works, we can merge everything in :) Thanks for helping again! And great work!


"Filename has already been used" when uploading

I have a package called fbs on PyPI. Every once in a while, I get the following error while trying to upload a new version with twine:
HTTPError: 400 Client Error: This filename has already been used, use a different version. See https://pypi.org/help/#file-name-reuse for url: https://upload.pypi.org/legacy/

The error occurs even though I have never uploaded the respective version before. To work around it, I have to use a different version number.
What's curious: The version numbers for which this happens exhibit a strange pattern. The problem has so far occurred for versions 0.2.1, 0.2.2, 0.2.3, 0.3.1, 0.3.2 and 0.3.3. Notice the pattern .1, .2, .3. But probably it's coincidence.
Out of curiosity, I tried pip install for one of the versions which PyPI claims already exist. (Eg. pip install fbs==0.3.1.) But I got
No matching distribution found for fbs==0.3.1

My suspicion is that someone else had control of this package on PyPI before me, then deleted it. This left over some "old" releases, which now conflict with my new ones. If PyPI lets you delete packages, then I believe it should also clean up any old files so future owners of that package can use it as if it were new.
I'm using twine 1.12.1 and the following commands for uploading:
python setup.py sdist
twine upload dist/fbs-x.y.z.tar.gz

twine upload --verbose dist/fbs-0.3.1.tar.gz gave:
Uploading distributions to https://upload.pypi.org/legacy/
Uploading fbs-0.3.1.tar.gz
Content received from server:

  <title>400 This filename has already been used, use a different version. See https://pypi.org/help/#file-name-reuse</title>

400 This filename has already been used, use a different version. See https://pypi.org/help/#file-name-reuse

  The server could not comply with the request since it is either malformed or otherwise incorrect.

This filename has already been used, use a different version. See https://pypi.org/help/#file-name-reuse

HTTPError: 400 Client Error: This filename has already been used, use a different version. See https://pypi.org/help/#file-name-reuse for url: https://upload.pypi.org/legacy/

I'm on Ubuntu Linux 16.04 with Python 3.5.3, in case that's relevant.
Thanks!

Looks like this is related to pypa/packaging-problems/#74. But it's also somewhat different in that the scenario there is to re-upload after deleting a file. The present issue is likely about re-uploading after deleting the entire package.

Also seems like what I'm experiencing is pypa/packaging-problems/issues/188. Except that there, the owner deleted the package himself. I seem to have unknowingly inherited a package from a previous author.

@mherrmann You are correct, the fbs project has deleted releases from a previous owner. You can see the list of all actions done to the project, including which files/versions have already been uploaded at https://pypi.org/manage/project/fbs/history/.
This is essentially a duplicate of #4440, which proposes to fix this confusion by "soft" deleting projects, releases and files, and having them persist across ownership changes. As such, I'm going to close this issue, but thanks for the report!

Makes sense. Thanks :-)


[ALLUXIO-1947] Throw an exception when delete fails

https://alluxio.atlassian.net/browse/ALLUXIO-1947

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9707/
Test PASSed.

@aaudiber thanks, left some minor comments

@jsimsa I've addressed your comments, PTAL

LGTM

LGTM.


Fixed command to list keys for unmanaged disks

@dwrightmsft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@dwrightmsft : Thanks for your contribution to the Azure documentation! The author, @cynthn, has been notified to review your proposed change.

@dwrightmsft have you tried to use this? I get an error on --account-name and --name doesn't error, but it also doesn't return the keys for me. Can you let me know which version you are running and I will contact the dev. Thanks!

Hi,
Yes I tested this – I have attached a screen grab showing the results and versions – hope this helps!
From: Cynthia Nottingham<EMAIL_ADDRESS>Sent: 08 March 2017 17:51
To: Microsoft/azure-docs<EMAIL_ADDRESS>Cc: Darren Wright<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/azure-docs] Fixed command to list keys for unmanaged disks (#968)
@dwrightmsfthttps://github.com/dwrightmsft have you tried to use this? I get an error on --account-name and --name doesn't error, but it also doesn't return the keys for me. Can you let me know which version you are running and I will contact the dev. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/azure-docs/pull/968#issuecomment-285115168, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATvofbK3nupQphRJ37JzViAGhhXaNat-ks5rjuqhgaJpZM4MW4dJ.

Also here is the text output:
darren@MININT-QGES0VG:~$ az storage account keys list --resource-group rg-core --account-name dwcorefiles --output tableKeyName    Permissions    Value

key1       Full           +nCEORYIVB4lryM[REMOVED]
key2       Full           UkkIehdGrIdEMFA[REMOVED]
darren@MININT-QGES0VG:~$ az storage account keys list --resource-group rg-core --name dwcorefiles --output table        az storage account keys list: error: argument --account-name/-n is required
usage: az storage account keys list [-h] [--output {json,tsv,table,jsonc}]
[--verbose] [--debug] [--query JMESPATH]
--resource-group RESOURCE_GROUP_NAME
--account-name ACCOUNT_NAME
darren@MININT-QGES0VG:~$ az --version
azure-cli (2.0.0)
acs (2.0.0)
appservice (0.1.1b5)
batch (0.1.1b4)
cloud (2.0.0)
component (2.0.0)
configure (2.0.0)
container (0.1.1b4)
core (2.0.0)
documentdb (0.1.1b2)
feedback (2.0.0)
iot (0.1.1b3)
keyvault (0.1.1b5)
network (2.0.0)
nspkg (2.0.0)
profile (2.0.0)
redis (0.1.1b3)
resource (2.0.0)
role (2.0.0)
sql (0.1.1b5)
storage (2.0.0)
vm (2.0.0)
Python (Linux) 2.7.6 (default, Oct 26 2016, 20:30:19)
[GCC 4.8.4]
From: Cynthia Nottingham<EMAIL_ADDRESS>Sent: 08 March 2017 17:51
To: Microsoft/azure-docs<EMAIL_ADDRESS>Cc: Darren Wright<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/azure-docs] Fixed command to list keys for unmanaged disks (#968)
@dwrightmsfthttps://github.com/dwrightmsft have you tried to use this? I get an error on --account-name and --name doesn't error, but it also doesn't return the keys for me. Can you let me know which version you are running and I will contact the dev. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/azure-docs/pull/968#issuecomment-285115168, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATvofbK3nupQphRJ37JzViAGhhXaNat-ks5rjuqhgaJpZM4MW4dJ.

#sign-off @dwrightmsft Cool, thanks for the fix!


Rememberable does not work if neither password nor email is supplied

Warden 1.2.3
Devise 3.3.0
Rails 4.1.1
If you set password_required? and email_required? both to false, Rememberable does not remember the user.
For set up your user model is as follows:
class User < ActiveRecord::Base
  devise :database_authenticatable, :registerable,
     :recoverable, :rememberable, :trackable, :validatable

  def password_required?
    false
  end

  def email_required?
    false
  end

  def remember_me
    true
  end

If the email and password are both blank, the remember token will also be blank, causing an internal Devise comparison (secure_compare) to fail. This will result in the session being lost and the remember_user_token cookie to be destroyed.
See Stack Overflow http://stackoverflow.com/questions/27477048/rails-4-with-devise-how-can-i-authenticate-a-user-just-based-on-user-id for a work around.

Do you have a remember_token column?


[MINOR] Add fmt:check to check style

What is this PR for?
Adding a new simple travis profile to check style only
What type of PR is it?
[Improvement]
Todos

[x] - Add a new profile

New travis profile has been passed. https://travis-ci.org/jongyoul/zeppelin/builds/421893674 Will merge it


Inga/multiple colors

when market is closed, there is no drop shadow and nothing is clickable

Making multiple choice market options much smoller. I'm trying to make smaller PR's so this is just a part of a bigger change I want to make, where only the top 5 markets are colored and the rest are gray. I've picked lighter colors for @mqp to incorporate, but for now I've just used a lower opacity for the background colors.

@mqp I'm pretty sure the colors match what's on the chart but if you could take a look/know a more better way I could do this please let me know!


Issue when importing MAGIK

When trying the MAGIK example notebook, it fails when importing the modules :
ModuleNotFoundError                       Traceback (most recent call last)
[<ipython-input-8-bcd0be12bc00>](https://localhost:8080/#) in <module>()
      1 import deeptrack
      2 print(dir(deeptrack.models))
----> 3 from deeptrack.models.gnns.generators import GraphGenerator
      4
      5

ModuleNotFoundError: No module named 'deeptrack.models.gnns.generators'

When printing dir(deeptrack.models), it does not list "GNN".
I also noticed that deeptrack/models/init.py does not list from .gnns import *, could that be the issue ?

Hello @BptGrm!
Thanks for letting us know about the issue with the tutorial!
The error comes from the fact that MAGIK was not yet available via pip install. However, we´ve released deeptrack 1.1.0, which contains all the features of MAGIK.
The problem should be solved by updating your version of deeptrack!

Works on Colab, thanks !


Implement get_peer_[address|port] in ENet/WSServer

Also implement get_connected_host and get_connected_port in WebSocketPeer
(not supported in HTML5 due to browser limitation).
Add shorthand disconnect_peer(id) for get_peer(id)->close() like in ENet to
WebSocketServer.
Closes #17798

Looks good! And works, build & tested it locally. :) Can be merged I think.


Create data attribute for containers to morph

Create a data attribute to allow the plugin to identify nodes to morph, e.g. data-swup-morph
This would allow adding new nodes without touching the plugin config all the time
Elements would be matched using the value of the attribute: [data-swup-morph="filter-form"]

Closed via #18 and released in 1.2.0.


"Restart" button in Homebridge UI used to invoke reboot of the Raspbery Pi, but now just restarts the Homebridge service only.

Describe The Bug

In the attached image the button that I'm referring to has been identified. Clicking this used to reboot the entire Raspberry Pi, but now it only restarts the Homebridge service. I would like for it to behave as it previously did.
Logs
No response
Config
No response
Homebridge UI Version
1.60 - not sure, see screenshot.
Homebridge Version
1.60
Node.js Version
18.13
Operating System
Raspberry Pi OS / Raspbian
Environment Info

[ ] Using Docker?
[ ] Using Hyper-V?
[ ] Using hb-service?

Raspberry Pi Model
Raspberry Pi 4 B

In the three or so years I've used Homebridge, I believe that button has always worked just as it does today (restarts the homebridge application not the hardware running homebridge).  Regardless please do NOT change this feature since other applications could be running on the same platform and it makes no sense to restart the hardware (and all applications) to restart just one application.  If a user wants to reboot the hardware (in this case the raspberry pi) it's easy enough to login to the pi with ssh and do it that way.


.form-control-static isn't the same height as .form-control

In Bootstrap 4 Alpha 4 the form-control-static isn't the same size as form-control.
See example:
http://v4-alpha.getbootstrap.com/components/forms/#static-controls

The form-control-static element's height is 24 pixels plus 8 pixels vertical padding making 40 pixels of height.
The form-control element's height is 20 pixels plus 8 pixels vertical padding plus 1 pixel border making 38 pixels of height.

The issue is that if I use form-control-static and form-control side by side (like in multi-column form layout), the result will not be aligned nicely.
In v3, the form-control-static and form-control were both the same height.

I'm using Chrome 53 right now.

Hi, @tompazourek I tried replicating the condition you mentioned to the best of my understanding and could to find a problem as to the alignment in case of a multi-column form.
The result I obtained was aligned incorrectly on all browsers I checked, namely: Chrome 53, Edge 20, Internet Explorer 11.
You can see example for further info: http://codepen.io/knk-here/pen/BLLBRE
At first I thought using the p tag along with form-control-static was causing the problem, so I modified it to a anchor tag. Say, you wanna use it with a link.
That definitely worsens the issue. 26px vs 40px.

Hi @knkhere!
You appear to have posted a live example (http://codepen.io/knk-here/pen/BLLBRE.html), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 33, column 35 thru column 42: Stray end tag input.
line 39, column 7 thru column 93: Duplicate ID inputPassword.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

@knkhere: I always use the form-control-static on a plain div tag to ensure it's not conflicting with styles specific to a or p tag.
What I had in mind was something like this: http://codepen.io/tompazourek/pen/XjjpqP (you can see that due to different heights the alignments are wrong). Of course to maintain alignment, I could just make a new row for each row of the form, but still they should be the same height, otherwise form-control-static loses its purpose.
Also note that the difference isn't 26px vs 40px, but rather 40px vs 38px.

Its because the min-height and line-height. Set min-height:auto;line-height:normal;


Update PetClinicApplication.java

Testing a TBS trigger

@timmers-io Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@timmers-io use your own fork for experiments.


Added GreaterThanStateTrigger and LessThanStateTrigger

Added two triggers for checking if a value has gone above or below a value

Thanks! However there's already triggers for this: CompareStateTrigger - in addition it'll work with more than just integer values.


PoptoRootViewContoller shows empty screen

After you pushed another viewcontroller to your detail view controller , if you want to poptoRootViewController i see empty white screen.
Ho to fix that ?

Just setting view.alpha = 1.0 fixed my problem.
Thanks


Fixing a serialization issue

@RamjotSingh,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


add -d flag to specify delimiter

pick between '\t', '\n', ',',  and ' '. default to comma.

trouble is, there will be one final delimiter at the end because of the trailing newline; this is unwanted.

http://stackoverflow.com/questions/11290616/sed-conditional-merge-of-multiple-lines

this feature is unlikely to be useful


Bump popover version after refactor event listening on document

@mseemann I have bumped wrong package version in previous PR

Coverage remained the same at 92.029% when pulling c3761c80dd14a8f095b4c008d41e8c3663481b1b on tb:onDocumentClick into 6650b83bea3e822b98e36f0199e4500d28b57392 on mseemann:master.

np problem!

<EMAIL_ADDRESS>published


feat: add key_in_props to avoid importing react for modern JSX

fixes #6987

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Might need some help with the API naming and tests, happy to add that with some input

This is a critically important issue for us, months before it was not that much, but now we are forcing developer to always use key, this is triggering this issue way more offen. Happy to focus time and energy to get it fixed!

Trying to come up with the last impact PR, so it's more likely to get merged. Happy to remove it all together, but not sure it would break some react code.

Can you sign the CLA?

And actually, I consider this a bigger change than the solution suggested by @magic-akari and I'm not going to accept this PR

Closing as #6987 is fixed in the correct way


Change App name and logo

Hi,
Is it possible to change the name of the app and logo after the deployment.
Thanks,

Hi @raghav-nie ,
It is possible to change the name and logo of the app after the deployment.
It can be achieved in 2 ways.

We can change the Manifest ID in Physical folder do the upload and redeployment.
We can modify the Icon and Display Name under Resource Group > Bot Profile.

Hi @SankarMicrosoft can you please confirm if this still works? I tried testing it out and seems like it is not possible to change it just in Azure (Your option 2) for it to be reflected. Please see how I have configured this below:

However, after waiting for 2-3 days it is still using the default logo as shown below in Teams

I can confirm also that the logo is using a 30k max png as instructed in Azure Bot Profile configuration. Thanks


Change the number of nodes

Hi, can I do this with the code rn? If yes pls tell me how, this would be very useful for my project.

Yes, the Weaver.pde file by default uses the example03 function defined in example.pde file.
Open example.pde and modify the example03 function, you should see the current value 256. Replace it with the value you wish.
I'll try to make the code easier to update the number of pins and lines as it has been a common issue.


Evaluation view: OpenAI rate limitation error when running evaluations.

Description:
Running evaluations with lots of data using an app that uses openai does not work due to rate limitation error.
The issue is that this is neither solved in the frontend through exponential backoff, nor is the error shown solmewhere

Same as #199 . Closing this since the other ahs more detail


Communication: Announcement channel name displayed wrongly

Describe the bug
When searching for posts or in the "All messages" tab, the announcement channel name is displayed with too much padding in-between the elements.
To Reproduce

Go to course with communication enabled
Go to the communication tab
Create an announcement
Search for a word in announcement
See that the icon is displayed without padding, and the channel name is displayed with too much padding

Expected behavior
The channel name and "announcement" keyword should not have a padding. The icon however should.
Screenshots

Which version of Artemis are you seeing the problem on?
7.7.3
What browsers are you seeing the problem on?
Chrome
Additional context
No response
Relevant log output
No response

Addressed in #9927


JLL Registration: JuliaBinaryWrappers/SymEngine_jll.jl-v0.5.0+1

Autogenerated JLL package registration

Registering JLL package SymEngine_jll.jl
Repository: https://github.com/JuliaBinaryWrappers/SymEngine_jll.jl
Version: v0.5.0+1

Now this is a degenerate package version.


Exclude pages/posts/or page template

Is there a way to exclude pages from firing the modal? Thanks for sharing this plugin it works well.

Hi Jacob,
yes, you can find a meta box next to every post/page editor

And you can define a default template type on the admin panel.
However, there's no extra option to exclude the popup from just the home page or just the archives.
– Kevin

Perfect. Thank you Kevin. One more question.
Is it possible to have it disabled globally and then selectively turn it on? Or do you have to have it on globally and then selectively turn it off?

Yes, you can turn it off globally on the admin panel and then selectively override that setting (thus, turn it on).

Thank you Kevin.


Docs.MS Release Updates for Azure.Core

Update docs metadata and targeting for release of Azure.Core

Docs Build status updates of commit ac4c93a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/overview/azure/latest/core-readme.md
:warning:Warning
View
Details

api/overview/azure/latest/core-readme.md

Line 2, Column 1: [Warning-ms-prod-and-service] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'core'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 2, Column 8: [Suggestion-duplicate-titles] Title 'Azure Core shared client library for .NET - Azure for .NET Developers' is duplicated in: 'api/overview/azure/core-readme.md(2,8), api/overview/azure/latest/core-readme.md(2,8)'. Titles must be unique within a docset.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ac4c93a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/overview/azure/latest/core-readme.md
:warning:Warning
View
Details

api/overview/azure/latest/core-readme.md

Line 2, Column 1: [Warning-ms-prod-and-service] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning-ms-service-subservice-invalid] Invalid value for 'ms.service': 'core'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 2, Column 8: [Suggestion-duplicate-titles] Title 'Azure Core shared client library for .NET - Azure for .NET Developers' is duplicated in: 'api/overview/azure/core-readme.md(2,8), api/overview/azure/latest/core-readme.md(2,8)'. Titles must be unique within a docset.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


#810 Add goto button to searchbox

PR Checklist:

[x] Link to related issues: closes #810
[x] Add changelog entry linking to issue, describe API changes
[ ] Add tests (optional)
[ ] (If new feature) add to description / readme

LGTM, GJ, FLG, YOLO


Hi, how can i convert to this coordinate?

Hello. thanks for your wonderful work.
I have some points , which coordinate use top left vertex as origin. How can i convert my coordinate to yours?Thanks.
I call this function 'isect_segments_include_segments'.  it find correct intersections. but segments it returns are not correct. I think it due to the mismatch coordinate.


[BUG] -

Describe the bug
PHP Warning:  file_get_contents(../../env.php): Failed to open stream: No such file or directory in /home/uavirtual/domains/vms.uavirtual.org/public_html/cars/0.3.6/handlers/phpvms7/environment.php on line 6
PHP Warning:  Undefined array key 1 in /home/uavirtual/domains/vms.uavirtual.org/public_html/cars/0.3.6/handlers/phpvms7/environment.php on line 9
PHP Warning:  Undefined array key 1 in /home/uavirtual/domains/vms.uavirtual.org/public_html/cars/0.3.6/handlers/phpvms7/environment.php on line 10
PHP Warning:  Undefined array key 1 in /home/uavirtual/domains/vms.uavirtual.org/public_html/cars/0.3.6/handlers/phpvms7/environment.php on line 11
PHP Warning:  Undefined array key 1 in /home/uavirtual/domains/vms.uavirtual.org/public_html/cars/0.3.6/handlers/phpvms7/environment.php on line 12
PHP Warning:  Undefined array key 1 in /home/uavirtual/domains/vms.uavirtual.org/public_html/cars/0.3.6/handlers/phpvms7/environment.php on line 13
How do you reproduce this bug?
Attempt to make use of SmartCars 3 to login as pilot
API preview call (ie .../api/phpvms7)
Expected behavior
Allow SmartCars 3 to login
Screenshots
No response
API Version
0.3.6
PHP Version
8.1.23
Database & version
MariaDB version 10.6.12
Webserver version
Apache version 2.4.52 ubuntu 22.04
Browser
Vivaldi 6.2 & Chrome 117.0.5
Handler
phpvms7
Additional context
No response

Please close this with an update to:
environment.php
change the call from
file_get_contents(../../env.php)
to
file_get_contents(../../.env)

This call is already made by the API. I highly suggest updating phpVMS 7 and the API.


Added new inflow from boundary condition options

New feature: changing inflow boundary - this PR allows the inflow velocity to change through time.
I rewrote reading from *.dat file:

now bvel_velin can be an array instead of a scalar and it writes to a different array.
The time is given in a different array velin_time_delims which takes the corresponding velocity and assigns it as bc.velin.

The same function calculates bc.velout as before. It is all similar to function BCGetBGStrainRates.
I also added separate folder in tests (t32_BC_velocity) with an example of how to use it. This function doesn't change any workflow in usual models with only one velocity.
To use it:

specify velin_num_periods (INT) for a numbers of changing periods

velin_time_delims (ARRAY) in Ma for an age when to change for a next period (one less than period number!)

bvel_velin (ARRAY) velocities for specified period

With changing face_out parameter to -1, 0 or 1 it is possible to change the behaviour of opposite boundary

"-1"  can move the same way (e.g. compress from both sides or pull from both sides),
"0"  don 't move opposite direction (as before)
"1" move the same direction (as before)

lamem_input file has been updated accordingly

Should I do new PR with new description and close this?

no, this is fine. I initially didn't see your description, but I now reformatted this a little bit to make it more readable.
I have assigned Anton as reviewer.

I promise to review it promptly, within next three months or so :)


Cannot generate API key via UI

Describe the bug
When trying to generate an API key through the UI, I get an error toast that displays as "Unknown". The underlying log generated is 2024-02-01T00:57:41 ❌ - Database error: Record not found.
Alternatively, I also cannot get the invite links from the "Copy URL" button when generating an admin user. Upon inspecting the button I also wasn't able to find any relevant link from it.
For what it's worth, I have basic authentication enabled.
Reproduction
Use SQLite docker-compose example, add basic auth, log in through web UI, and try to generate API key for logged in user.
System Info
Synology NAS running via Docker. My relevant compose file is below:

version: '3'
services:
  podfetch:
    image: samuel19982/podfetch:latest
    container_name: podfetch
    user: <my_uid>:<my_gid>
    ports:
      - <external_port>:8000
    volumes:
      - ./podcasts:/app/podcasts
      - ./db:/app/db
    environment:
      - POLLING_INTERVAL=60
      - SERVER_URL=http://localhost:8000
      - BASIC_AUTH=true
      - USERNAME=<my_username>
      - PASSWORD=<my_password>
    network_mode: <my_custom_network>
    restart: unless-stopped

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

I added a better exception message. The admin user should be used mostly for administration purposes.

I see, thank you -- the fix works great and I'm already off and running. I appreciate the help!


Readiness probe never passes when updating nats-operator deployment

When making changes to nats-operator deployment, the pod in the new replicaset from updated deployment never passes readiness probe until previous nats-operator pod is manually deleted.
Example
For example, I apply the updated deployment (with a newer nats-operator image version):
kubectl apply -f ./nats-operator/ --namespace my-namespace

I observe a new pod is created:
kubectl get pods -l app=nats-operator --namespace=my-namespace
NAME                             READY   STATUS    RESTARTS   AGE
nats-operator-68856b7bb6-tlghf     1/1     Running   0          4h17m
nats-operator-68856b7bb6-ntpwj     0/1     Running   0          15m

But the pod is failing the readiness probe:
kubectl describe pod nats-operator-68856b7bb6-ntpwj --namespace=my-namespace

Name:           nats-operator-68856b7bb6-ntpwj
Namespace:      my-namespace
…
Conditions:
  Type           Status
  Initialized    True
  Ready          False
  PodScheduled   True
…
Warning  Unhealthy              3m29s (x149 over 28m)  kubelet, gke-my-cluster-default-pool-xxx  Readiness probe failed: HTTP probe failed with statuscode: 500

If I delete the old pod:
kubectl delete pod nats-operator-5fc7849b6-tlghf --namespace=my-namespace

The new one becomes Ready:
kubectl get pods -l app=nats-operator --namespace=my-namespace
NAME                             READY   STATUS    RESTARTS   AGE
nats-operator-68856b7bb6-ntpwj   1/1     Running   0          33m

Potential Solution
Change nats-operator deployment to use Recreate strategy (default is a Rolling Update) so the old pod is deleted first:
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy
But this would mean nats-operator might not exist for a short period, is that actually a problem?  The NATS cluster should still be in place and functional during that time.

There wouldn't be an issue if the operator is temporarily down since this will not affect the running clusters, so think we could adopt recreate strategy in this case.

I think a more robust solution would be for the readiness probe to pass, by having the operator ignore whether it's the leader or not, when computing readiness. I'll be working over the coming days.

Thanks for reporting, @dijitali!


Verify that "Uioara de Sus" is listed in the dropdown menu when searched

Description:
"Uioara de Sus" should appear in the dropdown menu with correct spelling and locality information.
Preconditions:
The website is up and running.

Step 1
Type "Uioara de Sus" in the search bar.
Expected results:
The dropdown is listing "Uioara de Sus" as the first location in the dropdown menu.

Step 2
Observe the dropdown menu.
Expected results:
"Uioara de Sus" is displayed and selectable from the dropdown menu.


WIP: quntstamp.com

Fake Quantstamp airdrop site
https://urlscan.io/result/90415d45-1547-477d-a786-9c74e74157ab#summary

Closed PR since other PR is merged 👍


⚠ Bofrost.lu has degraded performance

In 97b24ea, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1916 ms

Resolved: Bofrost.lu performance has improved in 4da04a2 after 13 minutes.


Oracle 12 c

Okay, finally... :-)
First of all: Thanks for this incredible amount of effort you put into this community plugin!
I learned so much doing these changes and really appreciate your work!
A word of warning: The MySQL Tests didn't quite work after I rebased to 2.6.3, I was always running into timeouts within the Actor tests...
Also please have an extra extra careful look at this PR, since I am not really sure I knew exactly what I was doing all the time and relied mostly on the existing tests... so be warned! ;-)
To summarize what I did:

changed the bash scripts to not just delete all not running docker containers but instead use docker-compose - for people running docker natively that might have been a big surprise in the past
added host-config for cases when not using boot2docker
went back to Oracle 11g, since I ran into problems with the 12c docker image (took years to start)
switched the eventsByTags logic to use ordering as offset instead of rownum
changed logic of fullTableName so that the . doesn't appear in front of the tableName when there's no schemaName
added bintraySbt plugin because sbt wouldn't build on my machine
renamed the sequence index, because Oracle 11g only allows 35 chars in names (...)
fixedup Oracle db-cleanup for unit-tests (e.g. it didn't reset the sequence so the offset was wrong for tests down the line)
removed @ignore from OracleJournalPerfSpec

Things i'd really like you to check before merging anything:

There have been quite some changes regarding deleted and created etc. Not sure if the Oracle schema/code is actually up-to-date now - e.g. there's still the deleted_to table and I didn't remove it sorry, just realized actually I did
I am not sure how good the test-coverage actually is, so I am not sure if I broke corner cases with my changes so you might be the way better judge on this
If I did anything stupid, please tell me - I'm really new to this field (Scala, FP, Typesafe Reactive Platform etc.) so the more I can learn from way more experienced guys like you, the better for me :-)

Ok, I just realized that the Oracle test-cases haven't been executed on travis.
I added the Oracle to build.sh (which I completely ignored previously) but the tests aren't able to connect to the db. Is this because you run the DB servers via travis and not via docker?

Hi, you have been busy! It would be great to have oracle support back in the plugin and thanks to you this may actually be the case, thank you very much! I will take a look at the PR and let you know if I find anything. Stay tuned!

Looks good to me!


Implement search history.

Implement a basic search history which will show the latest searches. The number of searches shown in history can be decided upon later. As of now no need to think about GUI in details. May be a simple label which on clicking shows the history of most recent searches as a drop down. GUI can be finalised later.

@Debpriya1997 are you working on this issue. Please confirm ASAP as one of the students wants to take this up as his GSOC heat project. So if you are not working on this, then I will be asking him to move forward with this.

Yes I am working on it


[cli] Include the git commit hash into cli version

Include the git commit hash into the cli version

I think this's okay for me but is there any other big issue or a series of issues and projects?


Sprockets-ES6 compatibility?

Hey there! Sorry to be a bother again---what with Angular in the past and ES6 now, I feel like the queen of the edge cases---but I've been having some trouble persuading Teaspoon to work with sprockets-es6. I added the es6 and js.es6 extensions to the suite.matcher setting, then tried running Teaspoon with a dummy spec file:
describe('the thing', function() {
  it('does the thing', function() {
    (1 + 1).should.equal(2);
  });
});

But Teaspoon kept looking for the asset at /javascripts/dummies/dummySpec.es6.js, whereas it should have been looking in /assets/dummies/dummySpec.js. So I forked the repo and tweaked normalize_js_extension to include the ES6 extensions. Teaspoon was then able to find and ask for the asset, but Sprockets complained that dummies/dummySpec.js wouldn't be compiled in production. Do you have any idea what steps I might be missing to get .es6 files included in the precompilation list?
Thanks in advance for your thoughts!

100% sprockets-rails' fault. Color me surprised.


cleaned up a little remove the ViewDecoratorMiddleware

cleaned up a little remove the ViewDecoratorMiddleware
/cc @marcusmartins @shin- please review.

Coverage increased (+0.17%) to 100.0% when pulling 333fb2d8ec94d1b7fa6083c7e0976d1579c7a150 on cleanuo into 10d6b50f098ff987e2d6d3ad517e77a5410ca111 on master.

Coverage increased (+0.17%) to 100.0% when pulling a6eb683ea1b1263eb4614c714fbe4b3f6f8a98e5 on cleanuo into 10d6b50f098ff987e2d6d3ad517e77a5410ca111 on master.

@kencochrane Made a comment other than that It looks good to me.

resolves #23

LGTM


[BUG] injecting Ctx doesn't bring request info in graphql resolvers. Cannot access any request header in a resolver method.

I have a default installation of Ts.ED application using Prisma, TypeGraphql, Koa selected. It created a standard config for graphql like this:
export const config: Partial<TsED.Configuration> = {
  version: pkg.version,
  envs,
  logger: loggerConfig,
  graphql: {
    default: {
      path: "/graphql",
      buildSchemaOptions: {
      },
    }
  },
  // additional shared configuration
};

I have a user resolver and a simple signup mutation;
@ResolverService()
export class UserResolver {
  // ...

  @Mutation(() => User)
  async signUp(
    @Arg('username') username: string,
    @Arg('email') email: string,
    @Arg('password') password: string,
  ): Promise<User> {
    // const ipAddr = ... <- trying to get ip address of requester
    return this.userService.signUp(ipAddr, email, password, username)
  }

}

I tried to inject @Ctx() but it doesn't have request data in it (or I couldn't find).
Also when I use a service injectable along request, I can set a field of it to context by help of a middleware. But when I tried to access it from resolver its field of context become null.

Hello @Romakita
Isn’t a bug. Typegraphql use its own DI and it’s another framework. All resolver are outside the Ts.ED execution context.
Also`@Context()ˋ can only be used on a Ts.ED controller.
A potential alternative is to use getContext function.
I close this issue ;)
See you
Romain

Maybe ˋInjectContext()` will works.

Or accessing to the request.ctx if typegraphql have a decorator to inject the nodejs request.


Jitclass with List crashes when pop element

I have following code:
from numba import jitclass, int32, float32, types, njit
from numba.typed import List
import numpy as np

_spec = [
    ('sigma',types.int32),
    ('Y_rf', types.ListType(float32[::, ::1])),
]

@jitclass(_spec)
class DensityRatioEstimation:
    def __init__(self, sigma):
        self.sigma = sigma
        l = List()
        l.append(np.array([[0.]], dtype=float32))
        self.Y_rf = l

    def add_arr(self, arr):
        self.Y_rf.pop(0) # <--- crashes here
        self.Y_rf.append(arr)

inst = DensityRatioEstimation(12)
inst.add_arr(np.array([[1.]], dtype=np.float32))
print(inst.Y_rf)

When called self.Y_rf.pop(0) in DensityRatioEstimation.add_arr python crashes (I think it is due numba) without no error logged.
Python 3.7.3 and numba 0.46.0

Thanks for the report, I can reproduce.

I have the same proble with a very similar code. With Numba 0.48 and python 3.7.6, llvmlite-0.31 I got this error with the code of @elch10 :
python(44439,0x11cda35c0) malloc: *** error for object 0x7fbd73a4c630: pointer being freed was not allocated
python(44439,0x11cda35c0) malloc: *** set a breakpoint in malloc_error_break to debug
Abort trap: 6

My use is with an instance of jitclass in an List() :
import numpy as np
from numba import njit,jitclass,float64
from numba.typed import Dict,List

person_spec = [("age",float64)]
@jitclass(person_spec)
class person():
    def __init__(self,age):
        self.age= np.float(age)

@njit()
def simulation(n):
    pop = List()
    for i in range(n):
        pop.append(person(np.random.randint(0,100)))
    print(len(pop))
    to_remove = List()
    for i in range(n-5,n):
        to_remove.append(i)
    to_remove.sort(reverse=True)
    print(to_remove)
    for i in to_remove:
        print(i)
        pop.pop(i)
simulation(10)
## Error msg:
python(38925,0x1130025c0) malloc: *** error for object 0x7fb1326f9cd0: pointer being freed was not allocated
python(38925,0x1130025c0) malloc: *** set a breakpoint in malloc_error_break to debug
Abort trap: 6

There is now a potential fix for this issue in #5602 -- although that one deals with NumPy arrays specifically, it should be good for this issue too.

I tried #5602 with both snippets listed in this issue and both no longer segfault. @elch10 @francoislauger -- would you have some spare cycles to test and confirm?

@esc Should probably push these through valgrind to make sure that the segfault hasn't just disappeared by accident?

I am still struggling to create a minimal reproducer. My initial assumption was that it has something to do with doing a pop on a list of jitclass instances. But that doesn't seem to suffice:
from numba import njit, jitclass, int32
from numba.typed import List

@jitclass([('value', int32)])
class Simple(object):
    def __init__(self, value):
        self.value = value

@njit
def foo():
    l = List((Simple(23),))
    l.pop()
    return l

print(repr(foo()))

With the pull request (0.50.0.dev0+117.g8d4c4f4df) both the minimum reproducer and my snippets are working.

@francoislauger excellent, thanks very much for trying this out and reporting back!  Thanks also for the reproducer, I will probably include it as a test case!
Note to self: https://numba.pydata.org/numba-doc/latest/developer/debugging.html#memcheck

closing via #5602


Feature/irsa removal

Remova IRSA from Kong Pod
Bring AddOn installation in Module
Hygiene
Removing SA creation for GW

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix #3571: Always load reflective call return types

I have manually verified that the test fails without the fixes.

It seems like this surfaces a bad interaction between default methods and reflective proxies:
Caused by: java.lang.AssertionError: assertion failed: Trying to dynamically reach the non-class method ju_Comparator.reversed__ju_Comparator

The method that causes the assertion is selected by findProxyMatch with the new code.
@sjrd any idea about this?

The method that causes the assertion is selected by findProxyMatch with the new code.

Seems this was a bug in the new code where it attempted to reach the reflective target and not the generated proxy.

@sjrd I need some help here: The CI shows that the new code erroneously tries to load primitives types. So I'm unsure what to do when I encounter a name of a primitive type; It seems like I'd need something like isSubtype in ir.Types but for TypeRefs?
Note that whatever fix we'll find here will probably have to be backported to 0.6.

Hum, it's true that the code does not seem to handle primitive types. That's weird. In any case, if it encounters any primitive type, then isMoreSpecific should always answer false. At the IR/JVM level, primitive types are always unrelated to each other. (so short is not more specific than int, for example)

Even w.r.t. Object? Wouldn't e.g. Int be more specific than Object especially in view of generics and bridges?

Yes, even with Object:
scala> class A { def foo(): Any = "foo"; def foo[X](): Int = 2 }
defined class A

scala> classOf[A].getMethod("foo")
res3: java.lang.reflect.Method = public java.lang.Object A.foo()

And also with java.lang.Integer:
scala> class A { def foo(): Integer = 1; def foo[X](): Int = 2 }
defined class A

scala> classOf[A].getMethod("foo")
res4: java.lang.reflect.Method = public java.lang.Integer A.foo()

This is ready for final review.


Added the zeroes extension method to array

used this method in AKTable extensively instead of append
for an array of 4096 elements this  is ~10x faster than appending one-by-one

Excellent!

Excellence

The one thing I should have commented but didn't notice is that you should make pull requests from forks of the develop branch back to the develop branch so that changes can get tested thoroughly before releasing onto master.  I've since merged this change back to develop.  I hope to see more awesome pull requests from you so that's why I am mentioning it after the fact.  Thanks again.

Alright, thanks for the heads up. Yeah I do plan on committing a bunch actually, I think I'm going to use AudioKit for a project. I'm going to start with some stuff with the MIDI part of the codebase (at least for starters).
Are you guys doing anything unusual with the build system btw? I tried to install the framework system wide (I do that a bunch so that I can write quick programs to try stuff out) but I keep getting an error that it was build for a target with a different name. I haven't seen this error before and the internet didn't help.
Also where do you guys stand on the "good practices" vs speed spectrum? I'm guessing in the swift part it's more towards legibility, in the c/c++ part it's more towards speed?
Also are there currently any parts that are yet to be ported to swift?

Well, the MIDI stuff is working well, but is definitely in the need of some careful inspection.  At least we can probably write more midi tests on 3.3 to ensure any changes don't break anything.  Stephane has a fix-frameworks.sh in the Frameworks folder that might give some clues.  We're eventually going to speed up compilation by using a precompiled soundpipe and sporth, but that will only help with the post-swift compilation which is slow to begin with.
As for best practices, we try to be as swifty as possible without throwing the baby out with the bathwater, so speed and efficiency are still the most important.   I know we can do better in that department too.
When you're ready I can invite you to the AudioKit slack group if you want quick access to the core team members.

It's possible the current OS X framework is somewhat broken if that's the one you are trying to install globally. That's probably why we don't have it in CocoaPods right now but fortunately I have a fix for it that will be in 3.3.1.
For iOS/tvOS there are requirements when submitting binaries to the App Store (including embedded frameworks) so that we need to strip out the simulator slices from them. This is the main purpose of the fix-frameworks scripts, though it has the added benefit of also making the binaries smaller.

Also, as far as porting to Swift, there are a few things to do on that front.  What types of things are you interested in?  If you're into physical models a la the AKMandolin, lots of work to be done on that front.

@aure: Ok, I would really appreciate the invite to the slack group. You might also want to consider setting up a public one. Google Groups is so 2005 :-).  My email is @gmail.com
The midi part works fine but it could be cleaned up. There's quite a lot of duplication in the event iteration (c.f. the isEmpty and clearMetaEvents) that could be wrapped up in some a sequencetype.
What's your migration plan toward swift 3.0?
Also, I was considering wrapping up all the error handling code in a function using autoclosure. Something to the tune of (I can't think of a good name though):
func tryCall(@autoclosure f: () throws -> T, _ args: Any..., _ msg: String = #function) throws -> T {
do {
return try f()
}
catch let error as NSError {
print("error (error) (msg) (args)")
throw error
}
}
and you'd call it with "try tryCall(throwingFunction())" and "tryCall(throwingFunction())" in swift 3.0.
So I'm actually not super good at synthesizer development, so I'm probably going to start with things other than modeling but I'm planning to learn.
@megastep Yeah, I was. Do you think you could commit it to a new branch or something? Or send me the diff?

@adamnemecek This is the commit that fixes it: https://github.com/audiokit/AudioKit/commit/aa1e759630ddbf7f7229d61f3882f2e747b1a65b
You'll still need to rebuild the OS X library yourself with the build_frameworks.sh script there, alternatively you could even use the current OS X binary and simply move out the .dSYM file that's inside the framework. It's the cause of the problems.

Drop me an email to my audiokit address and I'll send you a slack invite

@megastep I can't get this to work, still the same error. I build it with the build_frameworks.sh script. I moved out the dsym file but it seems to be taking the project name from AudioKit.framework/Modules/AudioKit.swiftmodule/x86_64.swiftmodule which is a folder with binary files.

I think what would really help me is like the intended development workflow. Like how do you guys develop this?

I just build using AudioKit for whateverOS.xcodeproj and build playgrounds to test additions to the framework.

On slack we can also do a screenshare and share setups and such.

@aure ok i sent you my email


Delete OWNERS

OWNERS files have no meaning on github :)

@bsiegert Thank you for noticing and for the for the PR.

Not that you necessarily want to use them, but just as an fyi, Github has a new-ish (https://github.com/blog/2392-introducing-code-owners) feature that allows for CODEOWNERS files, which was inspired by Chromium's OWNERS (which were inspired by Google's, presumably):
https://help.github.com/articles/about-codeowners/


Comma separated media selectors

Hello,
I have dictionary of breakpoints:
const breakpoints = {
    phone: '(max-width:600px)',
    tabletPortrait: '(min-width:601px and max-width:900px)',
    tabletLandScape: '(min-width:901px and max-width:1200px)',
    desktop: '(min-width:1201px and max-width:1800px)',
    fullHD: '(min-width:1801px)'
};

and this component:
export default function Combined({ children, ...props }) {
    const { phone, tabletPortrait, tabletLandScape, desktop, fullHD } = props;
    const query = useMemo(() => getQueryFromSelectedBreakpoints({ phone, tabletPortrait, tabletLandScape, desktop, fullHD }), [phone, tabletPortrait, tabletLandScape, desktop, fullHD]);
    return <MediaQuery query={query}>{children}</MediaQuery>;
}

usage:
<Combined phone desktop>
{content}
</Combined>

getQueryFromSelectedBreakpoints return comma separated string from selected breakpoints.
const getQueryFromSelectedBreakpoints = ({ phone, tabletPortrait, tabletLandScape, desktop, fullHD }) => {
    const query = [];
    if (phone) query.push(breakpoints.phone);
    if (tabletPortrait) query.push(breakpoints.tabletPortrait);
    if (tabletLandScape) query.push(breakpoints.tabletLandScape);
    if (desktop) query.push(breakpoints.desktop);
    if (fullHD) query.push(breakpoints.fullHD);
    const result = query.join(',');
    return result;
};

I tried pure css approach and it worked. But with MediaQuery it is selecting only first part (before first comma).
Did someone has similiar problem?

Can you show an example of the output from getQueryFromSelectedBreakpoints?

getQueryFromSelectedBreakpoints({ phone: true, tabletPortrait: true, tabletLandScape: false, desktop: false, fullHD: false });
Output:
(max-width:600px), (min-width:601px and max-width:900px)

Just letting you know I'm still planning on getting to this - work has been crazy lately and I haven't had much time for my OSS projects, but hope to have some more time soon.

Closing since no feedback


Error installing extension behind corporate proxy

VSCode Version: 1.6.1
OS Version: Win7 SP1

Error message:

write EPROTO 0:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:c:\jenkins\workspace\electron-win-ia32\vendor\node\deps\openssl\openssl\ssl\s23_clnt.c:794:

Steps to Reproduce:

Added http.proxy in workspace settings
added http.proxyStrictSSL= false
Click to install an extension from marketplace

What I've tried:

Tried npm config set registry http://registry.npmjs.org/
Tried with and without "http.proxyStrictSSL": false
both npm and git works with the http.proxy settings, only VS code is not working

What does your http.proxy setting look like?

It is just like what is in the screenshot, however, I can't give you the exact proxy url due to company policy. And I used the same proxy for github and npm. They both work so I'm not sure why it doesn't for vs code.

Make sure that if you have an HTTPS proxy you use that instead of the HTTP proxy. Confirm the http.proxy value with your network administrator.
More reading:

http://stackoverflow.com/questions/15421050/node-request-getting-error-ssl23-get-server-hellounknown-protocol
https://github.com/request/request/issues/478
http://stackoverflow.com/questions/15166950/unable-to-establish-ssl-connection-how-do-i-fix-my-ssl-cert

Thanks, I will check with my network admin, but can you please help me understand what the issue is by answering my several questions?

Is the vs code extension (e.g. the C# extension) installed via npm?
If it is npm, does vs code use a shipped version of npm instance or the one already installed in my OS? If it is the former case, can I directly configure proxy to that shipped version of npm and make it work? If it is latter case, why it doesn't work for vs code when my local copy of npm is already configured with proxy and works in visual studio 2015 and command line.
Does vs code extension installation have to be a https request? which means I have to have a https proxy to make it work?

The issue seems to be that you configured an HTTP proxy, but Code is accessing HTTPS resources. So there is a protocol error (EPROTO).
Extensions are not installed via npm, but via Code itself.

Got it. So does it mean I have to use a https proxy and configure "https.proxy" in order to in order to install extensions? Does Code have a http resource for extension installation?

No, just http.proxy will do. Just make sure your proxy handles HTTPS.

I have the same problem..   workspace setting is:
// Place your settings in this file to overwrite default and user settings.
{
"http.proxy": "http://myproxy:8080",
"http.proxyStrictSSL": false
}
VS Code: 1.8.1

I have the same problem under my Windows and vscode 1.10.
Seems,

gallary use internet explorer proxy configuration, and need to input username and password.
buf vscode doesn't have such dialog. so always failed.
http.proxy and http.proxyStrictSSL configuretions will be used only for installling extention...

Can you help us out in #22214 ?


PHPRedisMutex not working

I have a simple piece of code:
$mutex = new \malkusch\lock\mutex\PHPRedisMutex([$app['redis']], "lock.".$guid, 8);
            $mutex->synchronized(function () use ($object) {
                echo 'test';
                sleep(3);
            });

but it throws the following exception:
LockReleaseException in SpinlockMutex.php line 94:
Failed to release the lock.
I am running PHP Version 7.0.15 with Redis extension 3.0.0
Seems that the problem is with the file PHPRedisMutex.php, at line 63:
return $redis->eval($script, $arguments, $numkeys);
At https://github.com/phpredis/phpredis#eval we can read:

Return value
Mixed. What is returned depends on what the LUA script itself returns, which could be a scalar value (int/string), or an array.

So, I have replaced the code at line 63 with:
$redis->eval($script, $arguments, $numkeys);
            return $redis->getlasterror() == 0;

In that way it seems to work properly. I think that with the new php redis extension the return of the eval function has changed, and becouse of that it returns an unexpected value. So I have changed the code in a way that it returns a boolean, checking if redis encountered an error.
I'm not sure if that's the best way to fix that trouble, but with my tests it seems working.

After a more deep check, seems that the problem is not there, but related to the function release on file RedisMutex.php
        $script = '
            if redis.call("get",KEYS[1]) == ARGV[1] then
                return redis.call("del",KEYS[1])
            else
                return 0
            end
        ';
        $released = 0;
        foreach ($this->redisAPIs as $redis) {
            try {
                if ($this->evalScript($redis, $script, 1, [$key, $this->token])) {
                    $released++;
                }

The problem is that the execution of $script returns always 0, becouse the value stored on Redis is a number, while the argument is a string. I am not good at LUA scripts, never used them, but if I change
if ($this->evalScript($redis, $script, 1, [$key, $this->token])) {
to
if ($this->evalScript($redis, $script, 1, [$key, 'i:'.$this->token.';'])) {
it seems working properly. I have found that checking the output of redis.call("GET",KEYS[1]) that was different from $this->token.

Could be related to #14.

I've had a look, do you have OPT_SERIALIZER enabled and set to something else than Redis::SERIALIZER_NONE?

it seems working properly. I have found that checking the output of redis.call("GET",KEYS[1]) that was different from $this->token.

The call to SET will also be serialized, so it works fine for me. I've tested using ext-redis 4.0.0.

Found the problem and was resolved in 845d29e6d517ccf93cd68d440dd8dc22084669d7.


Memory leak in Test Cases?

 In order to get some statistics on runtime, I added a loop to fixed tests (resulting in 20000 test cases). After some tries my browser complained about slow execution of content and the tab froze.
I use firefox-esr on a debian linux. Looking into this problem with top I found, that memory usage for the tab/WebContent grows by approximately 0.7gb with each run of the test cases.

The freeze and slow down of your browser is a known problem related to large amount of assertions, which are handled poorly by test output panel. Every red and green line in the panel requires some processing in DOM, and in some testing frameworks, when you have many assertions, you get many green (or red) lines and browser does a lot of work processing them. I think the performance problem is noticeable with just as many as 1000 assertions, so 20000 is definitely killing it.
It's a known issue and workaround is to not have many assertions in languages with noisy testing frameworks ;) Just call your function many times in a loop, but do not call cr_assert_eq.
Rising memory usage is (I believe) not related to this issue of output panel, but rather to memory management of the browser itself. Browser decides when to release memory and it probably decided there's still plenty to work with. Unless there's something strange happening, like green/red entries not being properly detached from the DOM tree, so they cannot be collected, but I do not recall anything like this being noticed before.

Thanks for the info. It is definitely the calls to cr_assert_eq. I don't know about "being properly detached from the DOM tree", but the problem disappears with only one call to cr_assert_eq.


Support http proxy

It is common for enterprise orgs to require from their users to use an http proxy.  Sometimes there is no way to use the internet without using the org proxy.
To be clear I am not talking here about a need to inspect requests payload which is a lot more complex.

We may be able to adopt the Connector from here: https://github.com/hyperium/tonic/discussions/1206


Migrate Nuget to known project

When an assembly is detected to be part of a Nuget package and we have the source code of the package then:
1- remove dependency on this Nuget package
2- add a dependency on the project

done.


Download the app?

Which confusingly named folder of the vast repository corrosponds to this stage of the tutorial?  I've tried to follow the instructions 3 times but I keep getting the same error at the same place. Online forums report the same issue with no clear fix so I had to try to 'download the app'.
I finally worked out how to 'fork the repository' but you can't execute it...I have to replace my code with the sample code...update-database...not, that's .net 5, this one it too early, this one doesn't work....
The link should ideally go to git folder containing the package that corrosponds to that stage of the tutorial.
It's a great tutorial, but I've spent 3/4 of my time working to make things work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8f592059-3328-88a8-5c6c-43121ac8a0a5
Version Independent ID: f8a63abf-824b-5b80-e03d-abcb2c162b95
Content: Part 2, Razor Pages with EF Core in ASP.NET Core - CRUD
Content Source: aspnetcore/data/ef-rp/crud.md
Product: aspnet-core
Technology: aspnetcore-data
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Thanks for the comment.


Increase controller memory to 6GB

This should avoid issues during shutdown caused by
https://bugzilla.suse.com/show_bug.cgi?id=955770

+1

+1

+1


Chart is not based on ‘Grand Total’ column when using pivot table with ‘Pivotcolumns’

I can create a chart based off of a pivot table correctly.  However, when I add PivotColumns to the pivot table, the chart's series is no longer based off of the "Grand Total" column, but is rather based off of the second column in the pivot table (or rather the first column of the detailed state section of the pivot table).
In this example:
Import-Module ImportExcel
rm -Force .\demo.xlsx -ErrorAction Ignore
$data = Get-Service | Select-Object Status, Name, DisplayName, StartType | Sort-Object StartType
$p = @{Show = $true; AutoSize = $true; AutoFilter = $true; IncludePivotTable = $true;}
$p.PivotRows = 'StartType'
#Commenting out the next line fixes the series in the pie chart, but eliminates the pivot table detail
$p.PivotColumns = 'Status'
$p.PivotData = 'StartType'
$data | Export-Excel .\demo.xlsx @p -IncludePivotChart -ChartType PieExploded3D -Activate
The chart is created, but if you hover over the pie chart, you will see that the values for Series 1 are obtained from column B (the number of services running), rather than column D (the Grand Total).
Commenting out the following line fixes the graph, but eliminates the desired detail from the pivot table:
$p.PivotColumns = 'Status'
I'm not sure if this is a bug, or if I need to specify additional parameters for the chart to use the 'Grand Total' column when using the PivotColumns feature of the pivot table.

I've been looking at this in Excel and it looks like , if the data is not split into columns you have one series to graph. When you split it into columns total isn't a series; you get "Running" and "Stopped" as series instead -if you chart it with Pie it can only show one series, but with column (etc) you can chart all of them
I couldn't find a way to get Excel to chart just the totals. If you can ,could you post a file with what you want and I'll see if I can get EPPlus to make it :-)

Originally I was after a pie chart based just off of the far right "Grand Total" column in the pivot table.  This appears difficult to accomplish when splitting out the data into different columns.  Thanks to your comment, I've switched my graph from PieExploded3D  to ColumnStacked3D, and it gives the desired results.
Now I'm trying to figure out how to apply a different "Style" to the graph, such as Style 1 - 8, or how to apply a color palette, such as Colorful Palette 1 - 4, or Monochromatic Palette 1 - 13.  If this isn't yet possible, let me know and I'll open up a separate issue.  Thanks again for your reply,

Styles and Palettes not currently supported at the PowerShell level. Don't know if EPPlus exposes that.