[ZEPPELIN-2339] Change 'see more' -> 'enable' next to the older ver of interpreter type pkg

What is this PR for?
Currently "see more" is placed next to the older version of INTERPRETER type of Helium pkg. But other type of Helium pkg(e.g. SPELL or VISUALIZATION) has "enable". And if we click "enable", can see the dialog for asking if you want to enable the package or not. So I changed INTERPRETER type pkg's "see more" to "enable" for the consistency in this patch.
What type of PR is it?
Improvement
What is the Jira issue?
ZEPPELIN-2339
How should this be tested?

Run Zeppelin web under zeppelin-web with

$ yarn run dev

Go to Helium menu and click any interpreter type of package
Click versions
there should be "enable" not "see more"

Screenshots (if appropriate)

Before

After

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

LGTM

@felixcheung @Leemoonsoo Thanks.
Merge into master if there are no further comments on this.


[MGDOBR-849] Prapare CI for testing of Ansible Tower action

MGDOBR-849
Add environment variables for Ansible instance to CI.

@jiripetrlik Given the new focus on v2, I would suggest that we close this PR now and don't progress with this?
cheers,
Rob

@robpblake
Understand. I'm closing the issue.


Unable to move after using printer toggle hotkey

Sometimes after turning off the printer with the hotkey your character will be frozen and unable to move. In order to move again you have to toggle the printer on and off again.

? its seems its not my printer issue, its https://github.com/aleksilassila/litematica-printer
because I don't have option to turn off printer.


(WIP) add checks to show balance and earned counter

Checklist

[x] I have read the CONTRIBUTING guide
[x] Good naming (as clear and simple as possible)
[ ] Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
[x] I tested desktop/mobile resolution
[x] I tested light/dark theme
[ ] I tested different languages
[ ] I checked the functionality once again (AFFECT MONEY)
[x] I checked the PR once again

Original issue

Video / screenshot proof

[ ] swap history тоже скрыть если чел только пришел


Tutorial for RBC/Omnisci

[ ] Document and illustrate how to enforce target devices (devices kw of Signature, __cpu_ and __gpu_ prefixes)
[ ] etc.

Missing from docs:

[ ] Document is_null for columns and arrays (#239)
[ ] Template signature: @omnisci('int32(Column<T>, RowMultiplier, OutputColumn<T>)', T=['double', 'float']) (#220)
[ ] String support. Tests are located in rbc/tests/test_omnisci_text.py (#225)
[ ] Document sizer argument: RowMultiplier, Constant and ConstantParameter (#201)
[ ] Redefine UDF/UDTF functions (#199)
[ ] Support multiple columns in a single cursor argument (#195)

Missing from docs:

[ ] Document is_null for columns and arrays (#239)
[ ] Template signature: @omnisci('int32(Column<T>, RowMultiplier, OutputColumn<T>)', T=['double', 'float']) (#220)
[ ] String support. Tests are located in rbc/tests/test_omnisci_text.py (#225)
[ ] Document sizer argument: RowMultiplier, Constant and ConstantParameter (#201)
[ ] Redefine UDF/UDTF functions (#199)
[ ] Support multiple columns in a single cursor argument (#195)


Training code for optical flow and point tracking

Thank you for open-sourcing this impressive work.
The publicly available pre-trained weights contain retrained optical flow and point tracking models, are there any plans to open source the corresponding training code? It would be great to have a good code framework compatible with training for these tasks!

Hi @danqu130, thank you for your interest in our work!
The point tracking models are off-the-shelf models (not retrained) so you may refer to the original works (e.g., CoTracker, TAPIR...) for training details.
The optical flow models are indeed retrained and we already include the training code https://github.com/16lemoing/dot#training
Hope that helps!

Thanks for your reply!


Fix #20 Subscription::cancelImmediately

Fix #20 with @tomw1808 's proposed fix

Hello. Thank you for fixing the issue with a pull request.
I had to change the target branch from master to develop since we do not accept pull requests directly into master. You can see the replacement pull request here. https://github.com/chargely/chargify-sdk-php/pull/25
I have created a new release with these changes so and tagged it as v0.1.4 so you can get the update with composer.
Thanks again for the fix.


Add support for Julia

I have used Spyder with Python for several years, and I really like its Matlab style features, I was wondering if you have considered adding support Julia.

We have thought about that in the past, but:

It'd be a very big endeavor to support Julia right now.
We have very limited resources.
None of the core developers work with Julia.
There's Juno for Julia, which is very similar to Spyder but supported by Julia developers.

Of course, if you were willing/able to fund it, or could work on (and maintain) it yourself, we would be glad to consider it. If not, your best bet is probably finding someone/some people in the Julia community to work on or fund it, if there is either significant interest in the features/functionality Spyder provides over what Juno currently offers, and/or in an IDE that fully supported Python as well as Julia, or the desire to help grow Julia's still-small community by exposing hundreds of thousands of users to the language via an established IDE for the most popular current data science (and beyond) platform.
Particularly on that second point, it seems Julia has a bit of a "chicken or the egg" problem right now, where the benefits over existing languages (Python, R, C++, Fortran) for many applications are considerable on their own, but just not quite enough (or perceived as such) to motivate large scale adoption vs. more familiar languages. users don't want to invest without the packages and ecosystem to support them, while package developers aren't as inclined to spend similar effort as Python on a language with a far smaller current community. Perhaps Spyder could help boostrap things? At least, you could pitch that as an idea...


Add DroidKaigi 2021 Article item in FeedScreen

Kind (Required)

Improvement

Overview (Required)

We want to make it easy for users to navigate to the DroidKaigi2021 timetable from the FeedScreen.
Right now I'm showing the first Feed article, but I'd like to show DroidKaigi2021 until November.

Links

https://www.figma.com/file/IFlrbfmBSdYvUz7VmSzfLV/DroidKaigi_2021_official_app?node-id=2313%3A772

@Aqua-ix
This issue has a milestone date of 10/4. If you have any problems, please let me know! 🙏

Thank you for following me. I'm sorry it took a long time to this issue.
Since this is my first time using Jetpack Compose, it took me a while to understand the code.
There is one thing I am wondering about.
I understand that I need to replace the feedItem, which is the argument of the FirstFeedItem called in the following location, with the data of the timetable, but I'm a little confused about where to write the data of the feedItem to be replaced here. .. Please let me know if there is any good way.
https://github.com/DroidKaigi/conference-app-2021/blob/a33c1fa7b2/uicomponent-compose/feed/src/main/java/io/github/droidkaigi/feeder/feed/FeedScreen.kt#L324-L331

I think it would be a good idea to add a composable function like "DroidKaigi2021ArticleItem".
If it is difficult to implement in FeedList, how about adding a DroidKaigi2021ArticleItem that can be seen in Preview? 💭
I'm sure we can come up with the FeedList logic later.
I think some refactoring is needed to separate the items in FeedList. 👀

Thank you for your advice.
I was able to display the article on the FeedScreen.
One of the problems at the moment is that it is difficult to implement the process of saving Favorite to DB with the current implementation.
Send a draft pull request once because the rest of the implementation task is just that favorite. I would appreciate it if you could take a look at the code and give me an idea.


Filter cells from TRUST4 result

Hi, recently i analyze the same sample data by Cellranger and TRUST4. Although i have used barcoderep-filter script, the cell number of TRUST barcode report (6k Bcells) is still much higher than expect (3k Bcells).
I have refered https://github.com/liulab-dfci/TRUST4/issues/82#issue-996603391.
Do you have any suggestions for further filtering cells in order to get the expected cell number?

Is this BCR amplified library? If it is, you can also filter based on the number of reads for each cell in the barcode_report.tsv file.

Thank you for your reply.
Yes, it's amplified library. However, i have got the annot.fa(full length result), the cell number in full length result is too high. So, can i use the filtered cell barcode after using barcoderep-filter script to match the cell barcode in full length result in order to reduce the cell number?
by the way, what does the secondary-chain1 and secondary-chain2 mean in filtered barcode report?

I mean i have extracted the cell barcode list from full length result. and i also have extracted cell barcode from the filtered barcode report to match the cell barcode list to get a new cell barcode list. But the cell number is still higher(about 4k). So how to further filter the cell number based on this new cell barcode list?

The secondary-chains mean the other CDR3 assembled in that cell. But because their abundance is relatively lower, so I put them in the secondary category.
Full-length assemblies usually require more number of reads to support, therefore these are not likely to be false positive. Do you see those cells in the cellranger raw contig files? For amplified data, there could be other tricks in cellranger to further filter the cells, but I need some time to look into those.

Yes, i used GetFullLengthAssembly.pl script to get full length result and i found trust4 full length result may not filter other cell types.
Therefore, i kept the cell barcodes of full length results which are identified to B cells in filtered-barcode-result report. Then, i filtered cell numbers again based on the number of reads for matched cell barcodes in the trust-report.out file. Finally, the cell numbers meet my expectation. is that sensible?

In the recent versions of TRUST4, I put the full length indicator in the barcode report file as well: "V_gene,D_gene,J_gene,C_gene,cdr3_nt,cdr3_aa,read_cnt,consensus_id,CDR3_germline_similarity,consensus_full_length" for each chain. So you don't need to run GetFullLengthAssembly.pl, which could save future efforts.
What is the number of reads cutoff you are using? Just want to make sure, are you filter the number of reads in trust_report.tsv or trust_barcode_report.tsv file? The trust_report.tsv is for the count of each CDR3 not for cell barcodes.
Overall, you can run filtered-barcode-result , and then again filter the cells with too few read support, the result should be good.  I don't think there is need to do the filter with full-length assemblies given you will filter based on the number of reads.

Thank you for your explanation.
Only "barcode, cell_type, chain1, chain2, secondary_chain1, secondry_chain2" information shown in my barcode report file, so i have to run GetFullLengthAssembly.pl script to get full length information. Do you mean i don't need to run GetFullLengthAssembly.pl after i get the cdr3 result, the trust-report and the barcode-report based on cdr3.out result is enough?
Yes, i filtered again based on trust_report.tsv read_ count and the cutoff value is 4 after i matched B cell_type cell barcode from barcode-report to cell barcode which is extracted from full length result file.  Because i only find barcode information related to read count in trust-report.tsv

The comma-split fields mentioned above are for chain1 and chain2 respectively. After the amino acid sequence, there are a few other numbers including the read count you used. The last number is 0 or 1 indicating whether the corresponding assembly is full-length or not.
I think cutoff value 4 for BCR amplified library looks good (or even a bit conservative).


When user settings is opened, focus should default to search input

Almost every time I open user settings, I'm going to search for a command.  It would be a better flow if the focus would default to the search input box.

Not sure everybody has this flow. Users also open settings to edit which needs focus to be in editable settings editor. IMO the right flow is

By default focus the editable settings editor
A key binding to focus search box.

This is the common flow when an editor is opened and user wants to find for something.

@sandy081 I don't like binding cmd+f to focus the search box, because I have a large settings file in no particular order and I like to search within it. Unless we plan to filter settings.json based on the settings file as well, maybe we should pick a different default for this command?

I would prefer defaulting to the search box and just hitting tab to jump focus to the editable settings editor.  Probably would be even more ideal if both views were filtered by the search box.

@roblourens Search functionality in Settings editor searches across Default (LHS) and editable (RHS) settings. So, you could be able to still find in settings.json using Search functionality. I know the find widget supports much advanced functionality like Match case, Reg ex etc, but I think this is not very commonly used and Search will support all basic requirements. Please let me know if you are missing something there so that I can look at it.
This functionality makes it consistent across LHS and RHS settings editor.
FYI: If you do not want to open the full settings editor you can disable it using the setting  workbench.settings.openDefaultSettings.
@dakaraphi IMO majority of the use cases, users would like to edit settings editor rather than searching. Hence, I focussed the settings editor by default. I would wait to get more feedback to see if this is not the case to switch.
Thanks

Ok, I hadn't noticed exactly how it worked. I also can't search settings values now, only names. I think that's ok though. I opened https://github.com/Microsoft/vscode/issues/22159 and https://github.com/Microsoft/vscode/issues/22157 which would make it much more usable for me. Would be awesome to have a solution for https://github.com/Microsoft/vscode/issues/17129 too.

verified cmd+f focuses the search field


July gems

Here's the July Community Gems PR- will update link to comments & image shortly.
I have 3 DVC questions and 4 CML questions and the length seems right to me. But if you have a favorite DVC question or two to add, please suggest.
@dmpetrov would appreciate your quality check on CML answers :)

do we have more DVC/CML question - if we remove the huge YAML (and I would keep it in docs only) we won't have enough content to my mind

@shcheklein yep, we've got some more questions pinned in Discord. Let's move the big yaml snippet to docs and add another 2 questions or so.


[BUG] Session concurrency not firing concurrently with service bus azure function trigger

Library name and version
Microsoft.Azure.WebJobs.Extensions.ServiceBus 5.5.1
Describe the bug
The session concurrency functionality for a service bus triggered function does not appear to be behaving as I'd expect. What I'm seeing in my testing is that it will receive for a single session in the correct order (FIFO), once all of the messages for that session have processed and the receive link for that session closes (after a minute), it will pick up the next session.  I'd expect that these sessions would process concurrently based on my settings.
I'm wondering if there is some problem with how I have configured my function and/or settings. This is a new project, we have a lot of volume on SQL Service Broker we're looking to eventually migrate onto service bus via service bus triggered functions with concurrent session processing.
Expected behavior
Sessions are processed concurrently up to the number set by the maxConcurrentSessions value
Actual behavior
Sessions are handled one after another, not at the same time. Messages within a session are processed in the correct order.
Reproduction Steps
I've included a sln with a function and a sender.

You'll need to set the service bus conn str in the sender Program.cs, and the SessionFunction > local.settings.json
The sender sends messages interleaved for one of two sessions (odd, even)
The function receives all for odd first, a minute passes for the receive lock to release, then the even session messages are handle
SessionConcurrency.zip
d

Environment
Windows Azure Function
Reproducible locally with Function Runtime Version: <IP_ADDRESS>83

Hi @LouisGordon,
Unfortunately the concurrency options are not supported when using functions that receive a batch of messages.
See https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.webjobs.servicebus.servicebusoptions.maxconcurrentsessions?view=azure-dotnet#microsoft-azure-webjobs-servicebus-servicebusoptions-maxconcurrentsessions for more info.

Thanks for the quick response.


AddBotApplicationsInsights requires use of .bot file

Version
4.3
Describe the bug
AddBotApplicationInsights() in Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ServiceCollectionExtensions.cs has no implementation that does not require the BotConfiguration.
Work around being tested:
// The following line enables Application Insights telemetry collection.
//services.AddBotApplicationInsights(services.GetRequiredService<IConfiguration>());

services.AddApplicationInsightsTelemetry();

services.AddSingleton<IBotTelemetryClient>(options => new BotTelemetryClient(new TelemetryClient()));

[bug]

I think this is already fixed with the new sample..

Hi @cleemullins  I already did a PR to fix this which is pending approval.


WSL should report an error if you try to create an operator overload that will never be called

Migrated from https://bugs.webkit.org/show_bug.cgi?id=177092:
At 2017-09-18T18:59:23Z<EMAIL_ADDRESS>wrote:
Like:
Wrong number of args: int operator+(int, int, int)
Type parameters that cannot be inferred: int operator+(int, int)
Probably other things.

At 2017-09-22T03:03:13Z<EMAIL_ADDRESS>wrote:
Created attachment 321509
even more tests

At 2017-09-22T02:30:42Z<EMAIL_ADDRESS>wrote:
Created attachment 321506
more tests
Adding tests for the checks I added.

At 2017-09-22T01:37:07Z<EMAIL_ADDRESS>wrote:
Created attachment 321503
possible patch
It passes tests but I need to write a lot more tests.

At 2017-09-22T04:49:27Z<EMAIL_ADDRESS>wrote:
Created attachment 321514
more tests

At 2017-09-22T03:16:23Z<EMAIL_ADDRESS>wrote:
Created attachment 321511
more tests!

At 2017-09-22T05:30:46Z<EMAIL_ADDRESS>wrote:
Created attachment 321518
more tests

At 2017-09-22T18:52:29Z<EMAIL_ADDRESS>wrote:
Created attachment 321572
the patch
My test hacking spree ended up uncovering some bugs in type instantiation.  I then fixed those bugs.
Basically, even if we instantiate a Func, we need its CallExpressions to retain the original uninstantiated types for the purpose of reresolving protocol function calls.

At 2017-09-22T18:55:06Z<EMAIL_ADDRESS>wrote:
Created attachment 321573
the patch

At 2017-09-22T21:33:50Z<EMAIL_ADDRESS>wrote:
Comment on attachment 321573
the patch
Attachment 321573 did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4631211
New failing tests:
http/tests/cache-storage/cache-representation.https.html

At 2017-09-22T21:33:52Z<EMAIL_ADDRESS>wrote:
Created attachment 321593
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

At 2017-09-22T23:24:59Z<EMAIL_ADDRESS>wrote:
(In reply to JF Bastien from comment #11)

Comment on attachment 321573 [details]
the patch
View in context:
https://bugs.webkit.org/attachment.cgi?id=321573&action=review
r=me

Tools/WebGPUShadingLanguageRI/FuncInstantiator.js:97

   class InstantiationInstantiateImmediates extends InstantiateImmediates {

InstantiationInstantiateImmediates 🤔

Tools/WebGPUShadingLanguageRI/Prepare.js:32

       parse(standardProgram, "/internal/stdlib", "native", 28 - 1, standardLibrary);

What's that number?

I'll add a comment.

Tools/WebGPUShadingLanguageRI/StandardLibrary.js:27
+// NOTE: The next line is line 28, and we rely on this in Prepare.js.

Ah OK.

At 2017-09-22T23:28:47Z<EMAIL_ADDRESS>wrote:
Landed in https://trac.webkit.org/changeset/222413/webkit

At 2017-09-22T23:23:43Z<EMAIL_ADDRESS>wrote:
Comment on attachment 321573
the patch
View in context: https://bugs.webkit.org/attachment.cgi?id=321573&action=review
r=me

Tools/WebGPUShadingLanguageRI/FuncInstantiator.js:97

   class InstantiationInstantiateImmediates extends InstantiateImmediates {

InstantiationInstantiateImmediates 🤔

Tools/WebGPUShadingLanguageRI/Prepare.js:32

       parse(standardProgram, "/internal/stdlib", "native", 28 - 1, standardLibrary);

What's that number?

Tools/WebGPUShadingLanguageRI/StandardLibrary.js:27
+// NOTE: The next line is line 28, and we rely on this in Prepare.js.

Ah OK.

At 2017-09-27T19:29:22Z<EMAIL_ADDRESS>wrote:
rdar://problem/34693367


Endocrinology hypoglycemia - b33

Linda - please review the KNART b33 located at:
https://github.com/preston/vha-kbs-knarts/tree/master/content/endocrinology_hypoglycemia/b33

OBE. Note that the validation report is available and checked in.


Create request_id directive #1590

1. What does this change do, exactly?
Provides a request_id directive which when present in Caddyfile will populate a {request_id} placeholder which can then be used to follow a request through proxies etc.
2. Please link to the relevant issues.
This implements #1590
3. Which documentation changes (if any) need to be made because of this PR?
I will add documentation to Caddyserver for this.
4. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I am willing to help maintain this change if there are issues with it later

Other details
I use a third party library to generate the UUID used as the request id.  With Vendor inclusion we may need to judge if this is the right library to uses.
Caddyfile example
courgette.kinchik.ie{

  gzip
  log / d:\caddy\logs\courgettelog.log   "[{when}] {request_id} {path}  {uri}"
  root d:\Development\websites\courgette
  browse

  # add upstream header with request_id
  header /  "X-Request-Id" {request_id}

  # Switch on request_id generation
  request_id

}

if request_id is not present {request_id} will be blank
I am not sure whether tests are required.

I'll have to leave this now, I have too much other stuff on.  I'll come back to it in the Autumn (Fall!) or if anyone else wants to move it forward feel free.

I will work on this 😄

@mholt please take a look at my changes 😄

AppVeyor fails randomly, I fixed (I hope so) the Test in caddy_test.go 😄

@elcore Thank you.  I didn't really expect anyone to take it up, but I am delighted you are.  I will make a few comments on the code I hope you dont mind.

Thanks @elcore Great to get this in.

It was a pleasure @tobya

@tobya I forgot to add the docs page for request_id. Would you want to propose a PR and then I can review/refine it? https://github.com/caddyserver/website

@mholt  I'll do that.

@mholt While I'm at it the works here are a bit confused.  I changed request_id to requestid but not in both places.
The directive is requestid but the placeholder is {request_id} .  Should I update the placeholder to be {requestid} or does it not matter now?
sample working Caddyfile
root c:\website
requestid
header /  "X-Request-Id" {request_id}

Probably best to make a decision before doing the docs

@tobya Oh, man. I somehow missed that.
This is the first standard directive that's more than one word. That's why I was thinking of changing it to requestid but I don't remember actually confirming that we should. We used to have a multi-word directive (maxrequestbody) but it was removed and changed to limits which is still one word. The wiki says that directives should be underscore_convention when there are multiple words.
Anyway, either the change from request_id to requestid went unnoticed by me, or I don't remember confirming that we should change it. (Totally my bad either way.) Since it's not documented yet, we can still change it.
Do you think we should make the name of the directive request_id to be consistent with the context key, then?

I dont mind, I can make both request_id . I will submit a PR today.  and update the changes to documentation also.


Support for provider profile

Add support for provider profile and --profile.

Any plans on implementing this?


Allow mediator to access jvm truststore certs

Needed for outbound ssl from mediator to wss:// endpoints
Signed-off-by: Ozzy Osborne<EMAIL_ADDRESS>

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Detect device failure

Hi,
I simulate a Grid meter with an Shelly 3EM and everything is working fine.
The Shelly is polled using HTPP request.
But when stop polling the Shelly, the last valid values are still used by the Venus OS and operating continues.
Is there a possibilty to detect such an issue?
I would expect that the ESS stops working like with an original EM24 grid meter,

Hi, please supply code and log files. Check the troubleshooting section of the README.

Hi, am not sure what exactly do you need.
My question was more a general behaviour of the driver.
What I have figured out that if I recognize that the source of data is not responding (Shelly 3EM) I set the "Connected" state tp "0" of this client. Then this is recognized by the Venus OS and the system stops working.

There isn't enough information here to understand what you are trying to do or the issue you are encountering. Often sharing your code is easier that trying to describe it. Please read the troubleshooting section of the readme. There is also a sample Arduino project that may help you understand how to use the driver.
Please be aware, this driver only handles the registering of a custom or 3rd party device to the Venus OS DBUS, any data values you read or write is handled by Victron's dbus-Mqtt service.


Upgraded version number for releasing 1.12.0

Rolling the version, as a new release branch has been cut.

Tests failing..

Fixed issues with pull request.


⚠ Bofrost.fr has degraded performance

In d5883db, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1153 ms

Resolved: Bofrost.fr performance has improved in 2e9e02b after 13 minutes.


Keychain sharing enable?

Is there a way how i can enable Keychain sharing in the Keychain.swift?

Keychain sharing enable? #224


Lipara inscriptions edited

Dear David, I have edited these files directly on the PR, in order to get the changes implemented and incorporate the files, as I'd really like to get things moving at this point. Do hope all is well.
very best
Jonathan


Update index.html

Fixing HTML validation error, you should not have a <div>  inside a <h1>

could you adjust the other HTML files too?

Yes, I should have time after Thanksgiving to finish.


[AutoPR compute/resource-manager] ToBeDetached added in Json and an example added

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5704

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/4629


Can't download Namespace icon

I tried to download the Namespace icon from Clarity website and received the following message:
This page contains the following errors:
error on line 1 at column 1: Document is empty
Below is a rendering of the page up to the first error.

MacBook
OS: High Sierra
Browser: Chrome & Safari

@Shijir
What do we need to do to get those downloads working? Is there a script that needs to be run?

We need to add the icons into the https://github.com/vmware/clarity-assets repository for them to be downloadable, we might have missed this step. We need to get a good document drawn up for adding icons.

I did miss this step. I forgot about the assets repo having the icons in it. Do I just push them up there then?

Yes, that can solve it because the website redirects to GitHub to download, if its not there you get 404.

Got it. I'm loaded down with meetings today. But I will try to push those up when I get time.

Fixed by https://github.com/vmware/clarity-assets/commit/865169f6ceeaa06152b653bb9d22d2b316bc7ba9


Feature Request: Skip Field Generation

Is it possible with lombok to generate only the getter and setter related to a field and not the field?
Possible use case, I have a parent class A, I have a class B that extends A. In class B I want to ovveride the annotations of the getters/setters of some fields of A.
Essentially I have 2 possibilities for doing this:

I can override the interested getter and setter adding the annotations
exploiting java field hiding, I redeclare the interested fields, adding the annotations over them and annotating class B with the annotation Data.

The second solution is much more cleaner and readable then the first one thanks to lombok. I prefer the second solution since in some cases I would have dozens of getters/setters.
Nevertheless I would like to avoid field hiding.
What I'm looking for is something like GenerateField(value=false) annotation. That at compile time will not generate the field (no field hiding so) but will generate the getters and the setters of this field together with the annotations added to the field.
Something like this:
@Data
public class A{
  private String id;

  private String name;
}

@Data
public class B extends A{

  @Id
  @GeneratedField(value=false)
  private String id;
}

I don't think the field is "generated" insomuch as "left alone". So what
you're asking lombok to do is remove the field after the fact.
On Thu, Jun 28, 2018 at 11:26 AM, Jacopo Rigoli<EMAIL_ADDRESS>wrote:

Is it possible with lombok to generate only the methods related (@getter
https://github.com/getter, @setter https://github.com/setter) to a
field and not the field?
Possible use case, I have a parent class A, I have a class B that extends
A. In class B I want to ovverride the annotations of the getters/setters of
some fields of A.
Essentially I have 2 possibilities for doing this:

I can override the interested getter and setter adding the
annotations
exploiting java field hiding, I redeclare the interested fields,
adding the annotations over them and annotating class B with the annotation
Data.

The second solution is much more cleaner and readable then the first one
thanks to lombok. I prefer the second solution since in some cases I would
have dozens of getters/setters.
Nevertheless I would like to avoid field hiding.
What I'm looking for is something like @generatefield(value=false). That
at compile time will not generate the field (no field hiding so) but will
generate the @getterS https://github.com/getterS and the @setters of
this field together with the added annotations.
Something like this:
@Data
public class A{
private String id;
private String name;
}
@Data
public class B extends A{
@Id
@GeneratedField(value=false)
private String id;
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rzwitserloot/lombok/issues/1746, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKCRQOHtQsXy7K9E0cVLxs3lRciOdZQks5uBKE8gaJpZM4U7C8T
.

--
"Don't only practice your art, but force your way into it's secrets, for it
and knowledge can raise men to the divine."
-- Ludwig von Beethoven

Also, what exactly do you expect the generated getter and setter code to do
in that case, if the underlying field is not  there? Use the corresponding
fields from the superclass, I take it?
But .. that's a problem. Because that requires resolution. And resolution
.. well, read it yourself:
https://github.com/rzwitserloot/lombok/wiki/LOMBOK-CONCEPT:-Resolution
On Thu, Jun 28, 2018 at 1:20 PM, Floris Kraak<EMAIL_ADDRESS>wrote:

I don't think the field is "generated" insomuch as "left alone". So what
you're asking lombok to do is remove the field after the fact.
On Thu, Jun 28, 2018 at 11:26 AM, Jacopo Rigoli<EMAIL_ADDRESS>wrote:

Is it possible with lombok to generate only the methods related (@getter
https://github.com/getter, @setter https://github.com/setter) to a
field and not the field?
Possible use case, I have a parent class A, I have a class B that extends
A. In class B I want to ovverride the annotations of the getters/setters of
some fields of A.
Essentially I have 2 possibilities for doing this:

I can override the interested getter and setter adding the
annotations
exploiting java field hiding, I redeclare the interested fields,
adding the annotations over them and annotating class B with the annotation
Data.

The second solution is much more cleaner and readable then the first one
thanks to lombok. I prefer the second solution since in some cases I would
have dozens of getters/setters.
Nevertheless I would like to avoid field hiding.
What I'm looking for is something like @generatefield(value=false). That
at compile time will not generate the field (no field hiding so) but will
generate the @getterS https://github.com/getterS and the @setters of
this field together with the added annotations.
Something like this:
@Data
public class A{
private String id;
private String name;
}
@Data
public class B extends A{
@Id
@GeneratedField(value=false)
private String id;
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rzwitserloot/lombok/issues/1746, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKCRQOHtQsXy7K9E0cVLxs3lRciOdZQks5uBKE8gaJpZM4U7C8T
.

--
"Don't only practice your art, but force your way into it's secrets, for
it and knowledge can raise men to the divine."
-- Ludwig von Beethoven

--
"Don't only practice your art, but force your way into it's secrets, for it
and knowledge can raise men to the divine."
-- Ludwig von Beethoven


Prepare script for deployment.

Can anybody prepare a shell script for deployment in coding.net webide or c9.io? Thanks.

忘了有Dockfile，可以支持用Docker。


PR for issue #57

Introduce fctl.ADFD
fctl.ADFD controls fault behavior on A/D bits

Approved in IOMMU TG with comments to be resolved - 10/6/2022


JAMES-3389, add api to webadmin server for receiving mail over rest i…

Made the neccessary changes

@chibenwa : can you please check on Linagora's CI for this time ?

Was my plan ;-)

Thinking about it, we might want, within the mailet container, to be able to identify emails submitted by this API - in order for instance to allow their relay to remote mail server.
The way we addressed this problem, for instance within the JMAP code base, is to position a mail attribute on the email, which can then be matched on.
See for instance MailSpool::send method && SentByJmap matcher.
I think this work would benefit to adapt a similar approach - this can of course be done as a separate PR.

Hi @andrevka ,
I just merged this (great!) peace of work. This PR can thus be closed.
Would you find some energy to handle https://github.com/apache/james-project/pull/256#issuecomment-722141233 ?
Cheers,
Benoit

Thinking about it, we might want, within the mailet container, to be able to identify emails submitted by this API - in order for instance to allow their relay to remote mail server.
The way we addressed this problem, for instance within the JMAP code base, is to position a mail attribute on the email, which can then be matched on.
See for instance MailSpool::send method && SentByJmap matcher.
I think this work would benefit to adapt a similar approach - this can of course be done as a separate PR.

Hi @andrevka ,
I just merged this (great!) peace of work. This PR can thus be closed.
Would you find some energy to handle #256 (comment) ?
Cheers,
Benoit

I think i will find the energy

I think i will find the energy

Many thanks!


One unique redistributable style: RedHat

To redistribute the style in a form consumable by the GitHub Action, we must create a ZIP archive containing one single directory with all rules, including the Spelling rules.

Move all rules to one unique style: RedHat.
Reimplement Vocabulary into a Spelling rule that can be distributed with the RedHat Style. Vocabulary should be used by users to modulate the style.
Clean up the .vale.ini file: use only the RedHat style.
Create a .vale.ini file suitable for the GitHub Action.
Create a release.yml workflow to release a RedHat.zip file on push to main.
Write tests for some rules: ProductNames, Spelling, url, yaml.
Fix vale errors on random files.

Linting with Vale failure is expected, as the required ZIP and configuration file are not yet available.


Aligned elements: attempting to set alias_expression

I am trying to set the values for layouts found here:
https://docs.sqlfluff.com/en/stable/layout.html#aligned-elements
Specifically, I am trying to set 'align_within = select_clause'
I haven't been able to set this in the settings.json for my workspace.
Am I able to do so? Is this feature supported in the VS-code extension?
Thank you so much!

You will have to set that within a sqlfluff configuration file. You can then set the config file with the "sqlfluff.config": "${workspaceFolder}/.sqlfluff" setting if it is not automatically recognized.

I have that set in my settings.json and here is my .sqlfluff config file:

But I still do not see the proper alignment when I format a file.

confirmed that it's picking up the config file.
Thank you for your assistance!


React Build Failed When There Is Axios Import Statement

I tried to create new react app in my local computer using npx create-react-app. I installed axios and pushing my codes to github repository. Then I created static-web-app in azure using my github account. It was all fine, Github CI/DI workflow done succesfully, web was deployed and I can see it through the browser.
Then I made slight change in my code, I added axios import library statement import axios from 'axios'; and push it to Github, the CI/ID workflow failed to build my code.
it says:
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: react-scripts build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /github/home/.npm/_logs/2021-03-22T03_41_53_537Z-debug.log
---End of Oryx build logs---
Oryx has failed to build the solution.

@slefved Is your repo public? We might be able to help if you can share the repo? If not, can you share your package.json and how you are using axios?

@anthonychu this is my public repo https://github.com/slefved/pustaka-react
This is just a plain react project with only axios installed. All was fine untill I import "import axios from 'axios';" in app.js file.

@slefved Axios isn't in your package file - that I can see.

The branch in use is development, and axios is in package.json.
The problem here is that the build will treat warnings as errors when it's running in a CI environment, which includes GitHub Actions. There's a warning by the linter:
Creating an optimized production build...

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

src/App.js
  Line 2:8:  'axios' is defined but never used  no-unused-vars

Once you use axios in your code, the error will disappear. There are more details here: https://github.com/facebook/create-react-app/issues/3657


Added link_inputs switch to DynamicMap clone

In PR #1384 while reviewing the linked streams tutorial, I noticed that Dynamic was being used to effectively make a clone, the only reason being to set link_inputs=False.
We could allow DynamicMap.clone to support this argument so Dynamic isn't used to make clones this way. We could also support this switch everywhere in clone and it would just do nothing for things that aren't dynamic.

@philippjfr Like the idea? Just add the switch to DynamicMap.clone?

Yes, I think that's a good idea.

Addressed in the PR mentioned above (#1464). Closing.


[DE] Update translation to upstream

Updated to newest additions from upstream.

Thank you @Lechindianer 👍


"static pages" wording in the README.md

Hello!
I don't want to be nitpicky, but I think the meaning of this term is much more specific than what you meant there. A few examples (there are more):

If I’m going to write a static page, I use regular controllers + views/HTML modules.

But if we're testing a page is static, we have to resort to controller testing:

Dynamic web pages that are server-side rendered using regular Phoenix controllers ("dead views") are affected by the same problems as you describe. I'm sure that you use them as well and this exact more general category of such non-liveview pages is what you meant by "static pages" there, but I think calling them "static pages" may be confusing (especially to less experienced developers)

I like "non-liveview" as well. Maybe it'll be sounding a bit repetitive to talk about LiveView and non-LiveView pages/views all the time, but I also can't think of a better alternative. For me personally those are also "normal" / "regular" Phoenix views/pages, but maybe for someone else LiveViews are the "normal" ones, I don't know. "Traditional" also comes to mind

@michallepicki I opted for adding a note in the README to clarify what "static" means and what it doesn't. Since we can't find a better term for now, I'll stick with static. But I realize it's easily confused with static-site generated pages (e.g. Jekyll, Gatsby, etc.).


Host on Github Pages

Go to repository Settings and set up GitHub Pages (from the main branch), update repository description with the proper website link. Follow the link to check if everything is fine - you should see your index.html content.

The homepage was hosted via the link:
https://annarybak04.github.io/homepage/


Display amounts in user chosen units (GB/GBB) when approving multisig transactions

Currently, it is always the smallest units (bytes/blackbytes)

done in https://github.com/byteball/byteball/pull/142


Explain how to run a substory twice.

Don't
Write a story that operates on a collection of data.
Steps should not contain for loops.
They are hidden in the entity methods like Events.

Duplicate of #126


[Bug] Filter is incompatible with eth_subscribe

Component
provider, pubsub
What version of Alloy are you on?
v0.1.2
Operating System
macOS (Apple Silicon)
Describe the bug
When using Provider::subscribe_logs, the subscription always starts from the latest block. It is not possible to subscribe to logs from past blocks.
let ws = WsConnect::new(rpc_url);
    let provider = ProviderBuilder::new().on_ws(ws).await?;

    let usdc_token_address = address!("af88d065e77c8cc2239327c5edb3a432268e5831");
    let filter = Filter::new()
        .address(usdc_token_address)
        .event("Approval(address,address,uint256)")
        .from_block(223598985);

    let sub = provider.subscribe_logs(&filter).await?;
    let mut stream = sub.into_stream();

This feature is crucial for use cases where both historical and real-time data are needed.

@zerosnacks we likely configure the request wrong, could be debugged by looking at traces, let's also convert this to an example in the process

ah right eth_subscribe is only applied to newly added blocks not historical blocks, hence the range filter is is ignored for < current height

Marking as wontfix due to it being an inherent limitation of how the eth_subscribe API works, unrelated to the Filter implementation in Alloy.
Users are recommended to configure the Filter accordingly:

eth_subscribe (logs): https://docs.chainstack.com/reference/ethereum-native-subscribe-logs (i.e. not defining a block range or block hash).
eth_getLogs: https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getlogs


sync to live

Docs Build status updates of commit 65a1b82:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/index.yml
:white_check_mark:Succeeded

windows-iotcore/manage-your-device/Overview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Question] When using go-sdk to subscribe all RouterTraffic CR in current namespace, what 'app' param should be?

// NewSubscribeKey returns an instance of SubscribeKey which is constructed by parameters.
func NewSubscribeKey(namespace string, app string, configKind configkind.ConfigKind) *SubscribeKey {
	return &SubscribeKey{
		namespace: namespace,
		app:       app,
		kind:      configKind,
	}
}

How I can subscribe all crs in current ns?

In most scenes, RouterTraffic CRs were defined in a certain application scope, so we have a convention that, the label app in CR is required.
So in current version you should give both namespace and app to defined your target CR, and you should subscribe all configKind one by one in your framework or application if you want to subscribe all CRs in the given namespace and app.
We also welcome you to append your opinions and your designs in this ISSUE 😃


Remove extra "are"

Current coverage is 48.13%

Merging #886 into master will increase coverage by +0.05% as of 96c1a64

@@            master    #886   diff @@
======================================
  Files          271     271
  Stmts        12853   12853
  Branches      1650    1650
  Methods          0       0
======================================
+ Hit           6181    6187     +6
- Partial        467     468     +1
+ Missed        6205    6198     -7

Review entire Coverage Diff as of 96c1a64

Powered by Codecov. Updated on successful CI builds.


ddev v1.19.0 test plan - community help requested!

It's testing time again here in the DDEV-Local factory. We love community help with every item that is interesting or relevant to you, and just using the release candidates is hugely helpful, because you may stumble across something in your regular workflow. Please use ddev v1.19.0-rc1 or later for your testing (or brew install --HEAD ddev).
I don't think in general you'll have trouble using this in your daily workflow, so would love you do do that. You can switch back and forth , see How can I install a specific version of DDEV in the FAQ.
If you find a bug that you're pretty sure is a bug, then [just open an issue for it](https://github.com/drud/ddev/issues/new?assignees=&labels=&template=Bug_report.md&title=).
To give feedback or ask questions, please just reply on this issue or discuss in [discord](https://discord.gg/hCZFfAMc5k) or another other support channel.
I am maintaining the provisional release notes for v1.19.0 and would love any comments on those.

ddev debug dockercheck

ddev debug test

$PATH change inside web container using homeadditions/.bashrc.d/path.sh (docs)

ddev exec and custom web commands can behave much better in combination with quotes, see https://github.com/drud/ddev/issues/2547

ddev get --list and ddev get --list --all

ddev get now provides access to tested and supported services/recipes (see docs). Try each official recipe:

ddev get --list
ddev get drud/ddev-beanstalkd
ddev get drud/ddev-memcached
ddev get drud/ddev-redis
ddev get drud/ddev-drupal9-solr

ddev service enable and ddev service disable swap docker-compose.<service>.yaml in and out of the .ddev directory. Test out.

Database configuration changes from mariadb_version and mysql_version to database: mariadb:10.5 and database: mysql:5.7 and database: postgres: 14.

Test several items in .ddev/config.yaml
Test several items using ddev config --database=postgres:13 for example
Existing config.yaml usages of mariadb_version and mysql_version should still work.

Postgresql support: Use database type postgres:9 through postgres:14 and make sure it works where needed. (Snapshots not allowed on postgres:9)

ddev export-db
ddev import-db
ddev snapshot
ddev snapshot restore
General usage.

macOS: Use ddev with Colima

windows WSL2: Use ddev with inside-wsl2 installation of docker and with Docker Desktop turned off. (docs

Test with remote docker instance (docs). You may want to try this with a VM running docker.

Bare in-container hostnames: You can (once again) use in-container hostnames like db or solr without having to use fully-qualified names like ddev-<project>-db.  Verify that ddev web container has no ambiguity even without links. See testing instructions in https://github.com/drud/ddev/pull/3403

Test improved WordPress setup per https://github.com/drud/ddev/pull/3468. See manual testing instructions there.

Gzipped database snapshots:

Test snapshot and snapshot restore
Test restoring an existing directory-based snapshot

ddev start now tests available disk space against an absolute value (5GB) rather than a percentage.  Test to make sure that it does flag low values. This can be done with artificially using space or by altering the value in nodeps/values.go (Also see https://github.com/drud/ddev/pull/3646)

Verify that graphicsmagick is installed in web container

Fresh Drupal 10 install should get PHP Version 8.1

Fresh Laravel install should get PHP Version 8.0

ddev tableplus should work for both mysql/mariadb and postgres projects

nodejs and nvm support

Override nodejs version in .ddev/config.yaml
Use ddev nvm to get any nodejs version.

Gitpod users should be able to use Xdebug, #3597

ddev delete should delete any volume named in any docker-compose.*.yaml

when mutagen_enabled, ddev now mounts upload_dir into container using regular docker bind-mount.

Verify that segment/amplitude reporting is working adequately.

A new ddev project should be able to start up even if there’s no internet (assuming images have been downloaded already)

ddev debug download-images should download default images (maybe more???) and also get docker-compose and mutagen.

New ddev php command

New ddev debug clean command (WIP, not in v1.19.0-rc1)

Ability to use ddev config global --no-bind-mounts to not use docker bind mounts at all (for remote machines, where $DOCKER_HOST is used, etc.) Test with a remote machine.

Casual Webhosting: Verify that casual webhosting feature is working OK.

Just started to test Magento 2.4. My test project started without any issues and without any modification.

✅ ddev debug dockercheck worked fine on WSL2. The first time I tried it I did see Error response from daemon: Get "https://registry-1.docker.io/v2/": dial tcp: lookup registry-1.docker.io on <IP_ADDRESS>:53: no such host but I've seen that before on Docker Desktop (quite a lot) and it didn't repeat later.
✅ ddev debug test worked fine (WSL2). The launch took a little longer than expected because I had the WSL2 set up to use X instead of launching on the Windows browser.

On my Arch Linux (amd64) machine.
:white_check_mark: ddev get drud/ddev-beanstalkd
:white_check_mark: ddev get drud/ddev-memcached
:x: ddev get drud/ddev-redis
:white_check_mark :ddev get drud/ddev-drupal9-solr
Redis service -> "No releases found for ddev-redis"

Tested on MacOS 10.13.6, Docker  <IP_ADDRESS>. and Mutagen activated.

✅ worked fine. excellent addition.
✅ works fine. an indepth option checking the setup. love it. the only question i wonder. i've ran the command in the directory of an already running project. if i take a look at the .ddev/config.yml file there is no indication of the debug project that is recommended deleting.
❌ .ddev/homeadditions/.bashrc.d/path.sh with contents export PATH=$PATH:/some/random/path in my projects homeadditions like you did in your example @rfay but the file got removed on startup. not sure why it gets removed. the file had no #ddev-generated statement in it neither. there is also some odd behaviour with .bash_aliases as well i'Ve tried along the line
✅ works. only the indefinte running of the command after successfully finishing the task remains but that seems something fringe on my installation somehow.
✅ works. one feedback about the current iteration. i wouldn't place the asterisk at the end of the description line. the user has to scan the whole description line figuring out if it is an official or community add on. the information has to be front loaded and the goal should be to have the important information within the first ~11 characters which equals roughly 2 words. therefor i still thing a dedicated third column would be worth to consider with either an empty cell or a cell containing an asterisk. and the column order asterisk, add-on and description.
❌ i can confirm that the redis release couldn't be found No releases found for ddev-redis
beanstalked:

ddev get drud/ddev-beanstalkd
Downloading https://api.github.com/repos/drud/ddev-beanstalkd/tarball/v1.1.1
v1.1.1_191959826.tar.gz 6.32 KiB / ? [-------------------------------------=------------------------------------------------------------------]  64.72% 0s
if [ "$(arch)" = "arm64" -o "$(arch)" = "aarch64" ]; then echo "This package does not work on arm64 machines"; exit 1; fi

Installed file /Users/danton/Sites/toolbartest/.ddev/docker-compose.beanstalkd.yaml
Downloaded add-on drud/ddev-beanstalkd, use `ddev restart` to enable.
For more information about this add-on visit the source repo at https://github.com/drud/ddev-beanstalkd

the if statement shoulnd't be shown imho
solr:
$> ddev get drud/ddev-drupal9-solr
Downloading https://api.github.com/repos/drud/ddev-drupal9-solr/tarball/v1.0.1
v1.0.1_1256256353.tar.gz 1.22 MiB / ? [----------------------------------------------------------------------------------=------------------] 12805.27% 0s
docker volume rm ddev-${DDEV_PROJECT}_solr 2>/dev/null || true

Installed file /Users/danton/Sites/toolbartest/.ddev/solr
Installed file /Users/danton/Sites/toolbartest/.ddev/docker-compose.solr.yaml
Executed post-install action chmod +x solr/docker-entrypoint-initdb.d/solr-configupdate.sh.
Downloaded add-on drud/ddev-drupal9-solr, use `ddev restart` to enable.
For more information about this add-on visit the source repo at https://github.com/drud/ddev-drupal9-solr

the docker volume rm line should also be hidden imho. and when restarting the project after ddev get ddev isnt that chatty anymore but now there is no progress indication anymore at all:
beanstalkd Pulling
solr Pulling
memcached Pulling
beanstalkd Pulled
memcached Pulled
solr Pulled

so as a user you have no idea if the dl is stalled or not and if things still advance correctly. after installing and downloading all available images i've applied ddev get for memcached in another project and the image hasn't downloaded a second time. so no surprises and everything behaves as expected.
7. ✅ works. only nitpick. without taking a look at the documentation i first tried ddev service disable drud/ddev-memcached then ddev service disable ddev-memcached and finally ddev service disable memcached. i would have expected ddev-memcached and memcached was kind of unexpected. would it be better to stay consistent with the naming maybe?
8.
9. ❌ tested with drupal installations.  it took forever until the network...line  showed:
$> ddev start
Starting postgres...
Network ddev-postgres_default  Created
``` probably the postgres 12 container got downloaded for the first time. same for postgres9
     **Postgres 12**
          i. ✅ `ddev export-db --file=postgres12.sql.sz` worked
         ii. ❌ `ddev import-db --src=postgres12.sql.sz`, `ddev import-db --src=./postgres12.sql.sz` and i tried also `ddev import-db` with path `~/Sites/postgres/postgres12.sql.sz` but i always get `Failed to import database db for postgres: open : no such file or directory` but the file is there
         iii. ✅ `ddev snapshot` worked
         iv. ✅  `ddev snapshot restore postgres_20220302132857` worked
         v.  ✅  Manually installed drupal instead of using drush site install and everything went without any problem as well as after restoring a snapshot. only nitpick the `ddev pgsql -c 'CREATE EXTENSION pg_trgm;'` command you mentioned in another issue doesnt work since postgres 12 doesnt come with the pgsql command
     **Postgres 9** minimum requirement for drupal 9 is postgres 10 the
      **Postgres 10**
          i. ✅ `ddev export-db --file=postgres10.sql.sz` worked
         ii. ❌ `ddev import-db --src=postgres10.sql.sz`, `ddev import-db --src=./postgres10.sql.sz` and i tried also `ddev import-db` with path `~/Sites/postgres/postgres10.sql.sz` but i always get `Failed to import database db for postgres: open : no such file or directory` but the file is there
         iii. ✅ `ddev snapshot` worked
         iv. ✅  `ddev snapshot restore postgres_20220302132857` worked  but the first time i got `Failed to restore snapshot postgres10_20220302141731 for project postgres10: failed to start project for RestoreSnapshot: web container failed to become ready: web container failed: log=, err=health check timed out: labels map[com.ddev.site-name:postgres10 com.docker.compose.service:web] timed out without becoming healthy, status=` probably too much load workwise for my computer that lead to the timing issue. retried the command then it worked properly
         v.  ✅  Manually installed drupal instead of using drush site install and everything went without any problem as well as after restoring a snapshot. only nitpick the `ddev pgsql -c 'CREATE EXTENSION pg_trgm;'` command you mentioned in another issue doesnt work since postgres 9 doesnt come with the pgsql command
      **Postgres 11**
              ❌ dont know why but somehow the postgres 11 project fails to become health `Failed to restart postgres11: web container failed to become ready: web container failed: log=, err=health check timed out: labels map[com.ddev.site-name:postgres11 com.docker.compose.service:web] timed out without becoming healthy, status=

@rpkoller thanks so much for your testing! It's going to be a little too messy to discuss these in the issue here, so could we discuss in Discord or slack (Already created thread in discord).  Some of the things are misunderstandings (the one about ddev import-db not finding file). Others like not becoming healthy definitely need discussion. I imagine they have to do with the timeout value and your ancient machine, but definitely need discussion.  Better to confirm in another venue and open separate issues.

Testing in Gitpod (empty workspace-full environment, Docker version 20.10.12, build e91ed57, Ubuntu 20.04.4 LTS)
Installed ddev with brew install --HEAD drud/ddev/ddev

✅
✅

❌  nodejs and nvm support - nvm doesn't seem to work right at all. The nvm version set doesn't persist even for a minute.

I set nodejs_version: 12 and ddev restart and ddev exec node --version: v12.22.10 (OK)
Use ddev nvm to get any nodejs version: ddev nvm install 6 : This seems to work, but then when you ddev ssh it's back to the system version. And I see inside /usr/local/nvm an additional version of everything, /usr/local/nvm/d9-web.
❌  I also happened to notice that ddev isn't populating the .ddev/web-build or .ddev/db-build directories with the expected README and examples. It seems these are (oddly) only populated during ddev config

Not sure how this new Option was finally implemented. I use a custom implementation for a longer time, which just sets the environment variable NODE_VERSION in config.yaml and uses a custom post-start script. In this post-start script I then run
curl -s -o- https://raw.githubusercontent.com/nvm-sh/nvm/master/install.sh | bash

which on the other hand then again reads NODE_VERSION and installs the desired node version on each restart.

@h1nds1ght I hope you'll test it and report your findings. If you don't like it a new issue or a discussion in Discord would be great. What it does is the regular install.sh for nvm, but the primary system node version is set with nodejs_version. Docs at https://ddev.readthedocs.io/en/latest/users/cli-usage/#nodejs-npm-nvm-and-yarn.

I tested it. For me it works perfect within its limits. I can change to node versions 12, 14, 16 and 17 and ddev ssh as well as ddev exec show me the most recent version of the according major version.
This is much better than before, of course, but there also might be people still using deprecated versions like 8. You might say, they can use the new ddev nvm, but I thought it might be nice to set whatever node version you want in config.yaml, therefore I shared my approach with NODE_VERSION. But if that is for some reason no option just ignore my post...

Thanks - in that case you haven't tried nvm, which allows anything. Please try out ddev nvm or just nvm inside the container.

K, I see because it writes to /mnt/ddev-global-cache/nvm_dir/${DDEV_PROJECT}-web, you can restart and the node version is stored, at least for ddev ssh, ddev exec keeps the global node version.
Therefore one has to use ddev nvm one time to change to another version than 12, 14, 16 and 17. Right?
And there is no way for you to implement that automatically to nodejs_version? I.e if node version is not within [12, 14, 16, 17] install the given version with nvm on ddev start?

I'm working on ddev exec recognizing the nvm version, that will be in rc2. Yes, you have to use ddev nvm if you want an unsupported node version. This works the same as on a server. Typically there's a "system" node version, installed with apt or whatever, and then nvm takes over if you need more.

And there is no way for you to implement that automatically to nodejs_version? I.e if node version is not within [12, 14, 16, 17] install the given version with nvm on ddev start?

The nodejs_version is implemented at image build time, before nvm can even exist. There's probably some way to do what you ask, but we'll see how this goes for now. I suspect that even just the config.yaml option will work great for lots of people, and then nvm users will probably be happy too.

Rerun of most of the steps with RC3 - Tested on MacOS 10.13.6, Docker  <IP_ADDRESS>. and Mutagen activated.

✅
✅ i would extend ddev is working output. You will want to delete this project with ddev delete -Oy tryddevproject-22972 to something like ddev is working. You will want to delete this project and associated docker files with "ddev delete -Oy tryddevproject-22972" and manually remove the source files with rm -r ~/tmp/ tryddevproject-22972 until https://github.com/drud/ddev/issues/3679 has landed. that way the user is informed that there is a new directory and php file created when running ddev debug test
✅
❌ ddev . drush role-add-perm authenticated 'administer comment types' returns Too many arguments, expected arguments "command" "machine_name" "permissions". Failed to execute command drush role-add-perm authenticated administer comment types: exit status 1 while ddev drush role-add-perm authenticated 'administer comment types' works (without the hang repeatedly ironically). ddev exec --raw mysql -e "SHOW DATABASES;" and ddev mysql -e "SHOW DATABASES;"also works ( the examples from the comment of @rfay) BUT

$> ddev . mysql -e "SHOW DATABASES;"
ERROR 1044 (42000): Access denied for user 'db'@'%' to database 'DATABASES'
Failed to execute command mysql -e SHOW DATABASES;: exit status 1

seems the . shortcut causes issues in the context of ddev exec and quotes
6.

Calling this one good. Thanks to all of you for testing - it made a huge difference. Followups are welcome, of course. If you thing something should still be addressed, feel free to comment here or open a new issue.


Custom Domain Hosting Issue

Before opening, please confirm:

[X] I have checked the custom domains troubleshooting guide.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d20pac6vlfjqwd
Region
ap-south-1:430596722621
Step
Custom Domain TrobleShoot
Status
Active but not viewable
Issue or question
I Wanted to host my react app on amplify so I created an amplify app which worked perfectly and I have Godaddy as my DNS provider so I finished all the SSL configuration which included adding a CNAME to the cloudnet url then adding the CNAME AWS provides with the respective name subdomain and value. After finishing this about an hour later my site show's active but when I click on the link to my site it shows connection not secure so I created an SSL certificate for it from AWS certificate management still in vain.  I tried my URL on whtatsmydns.com and it shows configuration active but on the site it shows connection not secure.
Error message
Connection not secure.
Additional information
No response

Hi @shutupfaezan 👋🏽 when adding a custom domain for your Amplify application, we issue an SSL certificate that is generated by AWS Certificate Manager. You have to create a CNAME record that points to the ACM validation server.
We outline how to do this in step 6 of our user guide: Add a custom domain managed by GoDaddy.
Did you follow these steps to setup your custom domain?

I'll check it out. Thanks !!!


Warning should contain absolute path to the file

Now it has only file name:
{"WARN": 10, "content": "N/A", "filename": "4_7_a_code_should_be_incapsulated_warning_.py", "message": "All top-level code should be encapsulated in functions or classes. Wrap it into if __name__ == '__main__' block."}

closed in #2


[QUESTION] Only 500 response being received from middleware

First check

[ YES ] I used the GitHub search to find a similar issue and didn't find it.
[ YES ] I searched the FastAPI documentation, with the integrated search.
[ YES ] I already searched in Google "How to X in FastAPI" and didn't find any information.

Description
I am trying to use middleware for Authorization ( Like Express JS in Node ). My middleware throws an exception which I am trying to send a custom response ( like 401 ) for, But I am only receiving 500 from the server.
From what I understand, The "middleware" raises an internal error that is not being over-ridden by my custom response. How can I over-ride the middleware's default 500 response and send my own response?
Additional context
The middleware is below:
       @add.middleware("http")
              def validate_all_routes( request: Request, call_next):
                   try:
                         validate_route(request.headers) # Unauthenticated req --> Raises exception
                          response = call_next(request)
                          return { ... } # This return is received by client
                  except Exception as e:
                        return { "exception": "server_error" } # Not received by client
                        raise HttpException(status_code=401)   # Not received by client
                        raise Response(status_code=401)
                       # ONLY IF I DO THIS
                        response = call_next(request)
                        return { ... } # Is the response that I sent received
`
Can someone please advise me on what I'm doing wrong and how I will be able to make the middleware send a custom response ( with custom HTTP_status) without invoking the
        response = call_next(request)
Thanks for the help in advance! Let me know if I can provide any other context/ clues.

First check

[ YES ] I used the GitHub search to find a similar issue and didn't find it.
[ YES ] I searched the FastAPI documentation, with the integrated search.
[ YES ] I already searched in Google "How to X in FastAPI" and didn't find any information.

Description
I am trying to use middleware for Authorization ( Like Express JS in Node ). My middleware throws an exception which I am trying to send a custom response ( like 401 ) for, But I am only receiving 500 from the server.
From what I understand, The "middleware" raises an internal error that is not being over-ridden by my custom response. How can I over-ride the middleware's default 500 response and send my own response?
Additional context
The middleware is below:
`
@app.middleware("http")
def validate_all_routes(request: Request, call_next):
try:
validate_route(request.headers) # If request is unauthenticated, an exception is raised
response = call_next(request)
return { ... } # This return block works fine
except Exception as ex:
return { ... } --> This line is never returned
raise HttpException(...) OR raise Response(status_code=401) ---> Lines never executed
          # Yet, When I do the below, I am able to return a response
           response = call_next(request)
           return { ... } # This return block works as expected

`
Can someone please advise me on what I'm doing wrong and how I will be able to make the middleware send a custom response ( with custom HTTP_status).
Thanks for the help in advance! Let me know if I can provide any other context/ clues.

Have you tried return Response(content="", status_code=401)?

@phy25 Your suggestion worked! When I send Response(status_code=401), I am able to send the response.
Thanks a bunch :+1:

Thanks for your help here @phy25 ! :bowing_man:
Thanks for reporting back and closing the issue @subritc :+1:

this is definitely unexpected behaviour that FastApi's own class HttpException is not handled in middleward

@vancouverwill I'm not sure how pertinent it may be, I was reading a discussion where a few people discuss how, at the middleware level, exceptions are not something that is raised, the reason being that all cases are expected to be explicitly handled. I don't remember the reason why,
But maybe it's because exceptions at the middleware level could be critical to the application and there should be no option for something unexpected here... Just my opinion.

yeah not saying it is super important but it is less than ideal. Expected behaviour is to handle errors in a similar manner across the FastApi handling code otherwise have to manually create a 401 response in middleware and use different implementation if triggered elsewhere.

But maybe it's because exceptions at the middleware level could be critical to the application and there should be no option for something unexpected here...

Regarding unexpected exceptions that does sound bad, I'm not saying all exceptions should be safely handled rather the inbuilt HTTPException class which contains status_code be handled the same way as in the query functions.


Assertion errors and throws in async tests breaks TCP connection to gauge core

This is linked to how the VM executes code. An error in test implementation code is unfolding up to the runner execution layer at the present. This needs to be blocked at the VM level and any error needs to be trapped and reported back to gauge.

This cannot be fixed directly. The only way around is to wrap possible failures in async tests in a try-catch block. This happens because if an asynchronous function errors out, there is no way to trap that from the promises layer that invokes that asynchronous function.
Like this:
gauge.step("I am run async and I may fail", function (done) {
    setTimeout(function () {
        try {
            assert.equal(true, false);
        } catch (e) {
            done(e);
        }
    }, 1000);
});

Information has been updated in the documentation for step implementations.
For a detailed use-case, see the implementations in Gauge JS Swagger demo.
Mocha has identical issues and the workaround proposed is the same.


Various quality of life changes and bug fixes

This branch is a collection of various ease-of-life changes and bug fixes. Many of these were issues listed in the GitHub and will be linked below.
Changes:

Fixed sentence display error:
https://github.com/center-for-threat-informed-defense/tram/issues/126
With the attack-object refactor, there was a bug that caused sentences in the technique_sentences page to not display.

Fix mapping deletion error in analyze
https://github.com/center-for-threat-informed-defense/tram/issues/110
The mapping deletion didn’t work at all previously (always deleted the last mapping in the list)
When deleting mappings in technique_sentences page, the sentence is removed since it no longer is included in that technique

Allow for mappings to be added in technique_sentences
Was completely broken before, changes here will also carry over to analyze page

Added search bar when adding mappings to make locating given mappings/groups easier

Added multiselect- allows for multiple mappings to be added in one go

Allow for plain text reports to be uploaded
https://github.com/center-for-threat-informed-defense/tram/issues/120

Advance to next sentence on accept (for analyze/technique_sentences page)
https://github.com/center-for-threat-informed-defense/tram/issues/88

Added retrain button on ml_admin page
Retrains given model and reloads page when done
https://github.com/center-for-threat-informed-defense/tram/issues/124

Added docx report feature
https://github.com/center-for-threat-informed-defense/tram/issues/99
Exports report and document as a docx, providing statistics including number of sentences (total/accepted/reviewing), number of techniques found (and their names/codes), all IP addresses/emails/urls found, and all sentences with mappings with their mappings
Sample report attached.
report-for-aa20-302a_1_k7et9qatxt.docx

Add DocuScrub tool to clean documents and extract important data (ips/emails/urls)
I worked on this tool for the old model last summer, it essentially finds data containing periods and converts it into a token/extracts it, so when the tokenizer runs on the document, the periods don’t split up the sentences as much.
I added this into the pipeline before the model predicts mappings– from some testing I found that models performed better and sentences were much easier to read (many less useless sentences of purely symbols or numbers).

Added keydown events on analyze and technique_sentence pages
Makes it much easier to scroll through the sentences, can just key up to progress to previous sentence and key down to progress to the next one

Add numbers to show how many mappings a sentence has (on analyze page)
https://github.com/center-for-threat-informed-defense/tram/issues/87

Added ability to redownload original reports
https://github.com/center-for-threat-informed-defense/tram/issues/43

Updated TRAM to use newest version of Bootstrap

Notes:
I attempted to remove all bugs in the front end of TRAM-- the only one listed in issues that I didn't fix was the username not uploading when uploading a report.
I can't figure out how to view the tests on SonarCloud-- I assume the multi-select commit fails since I changed the addMappings method to take a list of mappings rather than a single mapping.

Ben, That's a ton of changes!  Do you know how to make sonar cloud happier with the submission?
Hope you have a great next semester.  It was great working with you over break. -- woody


Graphical handler panics when span endpoints are not aligned to char boundaries

This is another regression introduced by #202.
Steps to reproduce
Source: source\n  👼🏼text\n    here
Span: (10, 5)
Result:
thread 'single_line_with_wide_char_unaligned_span_start' panicked at 'byte index 3 is not a char boundary; it is inside '👼' (bytes 2..6) of `  👼🏼text`', library/core/src/str/mod.rs:127:5

Expected Behavior
When the span boundaries are inside a char, the rendered highlight should extend to include that char instead of panicking.
This is almost the same as the current behavior of the narratable report handler. The current narratable report handler behaves differently when the start of the span is not char-aligned. In this case, the reported span does not include the char that the span start is inside. I think it makes more sense for the start of the span to be extended backwards, and and then end to be extended forwards. This way, whenever a span endpoint lies inside a char, that char is always included.

Unit tests for this
#[test]
fn single_line_with_wide_char_unaligned_span_start() -> Result<(), MietteError> {
  #[derive(Debug, Diagnostic, Error)]
  #[error("oops!")]
  #[diagnostic(code(oops::my::bad), help("try doing it better next time?"))]
  struct MyBad {
      #[source_code]
      src: NamedSource,
      #[label("this bit here")]
      highlight: SourceSpan,
  }

  let src = "source\n  👼🏼text\n    here".to_string();
  let err = MyBad {
      src: NamedSource::new("bad_file.rs", src),
      highlight: (10, 5).into(),
  };
  let out = fmt_report(err.into());
  println!("Error: {}", out);
  let expected = r#"oops::my::bad

× oops!
 ╭─[bad_file.rs:1:1]
1 │ source
2 │   👼🏼text
 ·   ────┬───
 ·       ╰── this bit here
3 │     here
 ╰────
help: try doing it better next time?
"#
  .trim_start()
  .to_string();
  assert_eq!(expected, out);
  Ok(())
}

#[test]
fn single_line_with_wide_char_unaligned_span_end() -> Result<(), MietteError> {
  #[derive(Debug, Diagnostic, Error)]
  #[error("oops!")]
  #[diagnostic(code(oops::my::bad), help("try doing it better next time?"))]
  struct MyBad {
      #[source_code]
      src: NamedSource,
      #[label("this bit here")]
      highlight: SourceSpan,
  }

  let src = "source\n  text 👼🏼\n    here".to_string();
  let err = MyBad {
      src: NamedSource::new("bad_file.rs", src),
      highlight: (9, 6).into(),
  };
  let out = fmt_report(err.into());
  println!("Error: {}", out);
  let expected = r#"oops::my::bad

× oops!
 ╭─[bad_file.rs:1:1]
1 │ source
2 │   text 👼🏼
 ·   ───┬───
 ·      ╰── this bit here
3 │     here
 ╰────
help: try doing it better next time?
"#
  .trim_start()
  .to_string();
  assert_eq!(expected, out);
  Ok(())
}

Originally reported in https://github.com/zkat/miette/pull/221#issuecomment-1301777735.


⚠ ClamAV has degraded performance

In 2443a6c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 51 ms

Resolved: ClamAV performance has improved in c53cbd5.


Error Mapping on sd3, sdxl and upcoming flux controlnet training scripts in diffusers

Describe the bug
Map:   6%|██████                                                                                | 8000/138120 [19:27<5:16:36,  6.85 examples/s]
Traceback (most recent call last):
  File "/workspace/diffusers/examples/controlnet/train_controlnet_sd3.py", line 1416, in <module>
    main(args)
  File "/workspace/diffusers/examples/controlnet/train_controlnet_sd3.py", line 1132, in main
    train_dataset = train_dataset.map(compute_embeddings_fn, batched=True, new_fingerprint=new_fingerprint)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/datasets/arrow_dataset.py", line 560, in wrapper
    out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs)
                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/datasets/arrow_dataset.py", line 3035, in map
    for rank, done, content in Dataset._map_single(**dataset_kwargs):
  File "/usr/local/lib/python3.11/dist-packages/datasets/arrow_dataset.py", line 3461, in _map_single
    writer.write_batch(batch)
  File "/usr/local/lib/python3.11/dist-packages/datasets/arrow_writer.py", line 567, in write_batch
    self.write_table(pa_table, writer_batch_size)
  File "/usr/local/lib/python3.11/dist-packages/datasets/arrow_writer.py", line 579, in write_table
    pa_table = pa_table.combine_chunks()
               ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "pyarrow/table.pxi", line 4387, in pyarrow.lib.Table.combine_chunks
  File "pyarrow/error.pxi", line 155, in pyarrow.lib.pyarrow_internal_check_status
  File "pyarrow/error.pxi", line 92, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: offset overflow while concatenating arrays
Traceback (most recent call last):
  File "/usr/local/bin/accelerate", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/accelerate/commands/accelerate_cli.py", line 48, in main
    args.func(args)
  File "/usr/local/lib/python3.11/dist-packages/accelerate/commands/launch.py", line 1174, in launch_command
    simple_launcher(args)
  File "/usr/local/lib/python3.11/dist-packages/accelerate/commands/launch.py", line 769, in simple_launcher

Steps to reproduce the bug
The dataset has no problem training on sd1.5 controlnet train script
Expected behavior
Script not randomly erroing with error above
Environment info

datasets version: 3.0.0
Platform: Linux-6.5.0-44-generic-x86_64-with-glibc2.35
Python version: 3.11.9
huggingface_hub version: 0.25.1
PyArrow version: 17.0.0
Pandas version: 2.2.3
fsspec version: 2024.6.1

training on A100

this is happening on large datasets, if anyone happens uppon this i was able to fix by changing
train_dataset = train_dataset.map(compute_embeddings_fn, batched=True, new_fingerprint=new_fingerprint)

to
train_dataset = train_dataset.map(compute_embeddings_fn, batched=True, batch_size=16, new_fingerprint=new_fingerprint)


quick start docs changes

was there a problem with the doctests?

yes... some sort of import error. can you take a look at those?


[Extension] Store and keep wallet wallet state persistent

Is your feature request related to a problem? Please describe.
Parent task: https://github.com/CasperDash/casperdash-client/issues/10

[ ] Store application state in a persistent storage. (Solution to be researched and applied)
[ ] Without Locking, User can see the last state where User last visited.
[ ] When Locked, User must enter password for authentication.

Describe the solution you'd like
N/A
Describe alternatives you've considered
N/A
Additional context
N/A

hi @djhahe , please update the requirements if it's still missing st. a @duc-q please do the solution research first and confirm with me and @djhahe before implementation. Cheers.

hi @gaupoit ,
Please review and merge new update when you finish.
Thanks


HADOOP-17608. Fix TestKMS failure

HADOOP-16524 removed the reloader thread, so the related tests in TestKMS fail. Remove these.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 16s

trunk passed

+1 :green_heart:
compile
20m 45s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
17m 57s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
0m 58s

trunk passed

+1 :green_heart:
shadedclient
14m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 23s

the patch passed

+1 :green_heart:
compile
20m 11s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
20m 11s

the patch passed

+1 :green_heart:
compile
18m  0s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
18m  0s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 36s
/results-checkstyle-hadoop-common-project_hadoop-kms.txt
hadoop-common-project/hadoop-kms: The patch generated 2 new + 92 unchanged - 2 fixed = 94 total (was 94)

+1 :green_heart:
mvnsite
0m 42s

the patch passed

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m  5s

the patch passed

+1 :green_heart:
shadedclient
14m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 38s

hadoop-kms in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

154m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2880

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 15b1100655be 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b2359e8bb76bcec375cf8e44b3d76b94391d1379

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/1/testReport/

Max. process+thread count
690 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m  0s

trunk passed

+1 :green_heart:
compile
20m 31s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
18m  1s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
0m 56s

trunk passed

+1 :green_heart:
shadedclient
14m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 21s

the patch passed

+1 :green_heart:
compile
19m 55s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
19m 55s

the patch passed

+1 :green_heart:
compile
18m  6s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
18m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 36s

hadoop-common-project/hadoop-kms: The patch generated 0 new + 92 unchanged - 2 fixed = 92 total (was 94)

+1 :green_heart:
mvnsite
0m 43s

the patch passed

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
1m  4s

the patch passed

+1 :green_heart:
shadedclient
14m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 39s

hadoop-kms in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

155m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2880

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ae25abb66d5a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 62ceeaa27fac595c0d4fd77af7a91a9e6dc6b28c

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/2/testReport/

Max. process+thread count
718 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2880/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thank you @iwasakims!
SSL_MONITORING_THREAD_NAME is different from the truststore reloader thread, so those tests pass. However, I think the tests are flaky due to the same reason as #2828, and we should fix them.

TestTimelineClient -> YARN-10568


parse failure: docs comment between function and where

haddock fails to parse a file that has a docs comment between a function and where
module Main where

main = print "hi"
  where
    {- | docs for foo here -}
    foo = id

function = id
    {- | broken docs for foo here -}
  where
    foo = id

On GHC 9.0 with -Winvalid-haddock -haddock (https://ghc.gitlab.haskell.org/ghc/doc/users_guide/using-warnings.html#ghc-flag--Winvalid-haddock), ghc will now report the following error:
1172.hs:5:5: warning: [-Winvalid-haddock]
    A Haddock comment cannot appear in this position and will be ignored.
  |
5 |     {- | docs for foo here -}
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^

1172.hs:9:5: warning: [-Winvalid-haddock]
    A Haddock comment cannot appear in this position and will be ignored.
  |
9 |     {- | broken docs for foo here -}
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I assume the first doc comment not associating to foo is intentional?

On GHC 9.0 with -Winvalid-haddock -haddock (https://ghc.gitlab.haskell.org/ghc/doc/users_guide/using-warnings.html#ghc-flag--Winvalid-haddock), ghc will now report the following error:
1172.hs:5:5: warning: [-Winvalid-haddock]
    A Haddock comment cannot appear in this position and will be ignored.
  |
5 |     {- | docs for foo here -}
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^

1172.hs:9:5: warning: [-Winvalid-haddock]
    A Haddock comment cannot appear in this position and will be ignored.
  |
9 |     {- | broken docs for foo here -}
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I assume the first doc comment not associating to foo is intentional?


enable wizard from odf-console

/hold
Remove usage of kubevirt before actually doing this.

/hold cancel

/lgtm
Depends on https://github.com/red-hat-storage/odf-console/pull/187

/hold cancel

/override ci/prow/odf-console-e2e-aws


Implemented psalm, cs-check, static analysis & fixed psalm errors

#2

LGTM! 👍
If you would also fix the issues reported by Symfony Insight, the library would also be eligible for green badge.

@SergiuBota1 Before merging this PR, I just noticed one more issue that should be fixed:

[ ] In README.md file, the issues, network and stargazers URLs are incorrect (using dot-social-auth instead of dot-auth-social).

(when done, you can check this the above checkbox to mark this issue fixed)


building spark-history in local-universe --include fails

It fails with
resource.json no such file or directory and the entire build of local-universe.tar.gz fails
Traceback (most recent call last):
  File "/root/universe/docker/local-universe/../../scripts/local-universe.py", line 413, in <module>
    sys.exit(main())
  File "/root/universe/docker/local-universe/../../scripts/local-universe.py", line 135, in main
    dcos_version)):
  File "/usr/lib64/python3.4/concurrent/futures/_base.py", line 549, in result_iterator
    yield future.result()
  File "/usr/lib64/python3.4/concurrent/futures/_base.py", line 395, in result
    return self.__get_result()
  File "/usr/lib64/python3.4/concurrent/futures/_base.py", line 354, in __get_result
    raise self._exception
  File "/usr/lib64/python3.4/concurrent/futures/thread.py", line 54, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/root/universe/docker/local-universe/../../scripts/local-universe.py", line 107, in handle_package
    args.nonlocal_cli
  File "/root/universe/docker/local-universe/../../scripts/local-universe.py", line 334, in prepare_repository
    with source_resource.open(encoding='utf-8') as source_file, \
  File "/usr/lib64/python3.4/pathlib.py", line 1086, in open
    opener=self._opener)
  File "/usr/lib64/python3.4/pathlib.py", line 960, in _opener
    return self._accessor.open(self, flags, mode)
  File "/usr/lib64/python3.4/pathlib.py", line 326, in wrapped
    return strfunc(str(pathobj), *args)
FileNotFoundError: [Errno 2] No such file or directory: '/root/universe/docker/local-universe/../../repo/packages/S/spark-history/0/resource.json'
make: *** [local-universe] Error 1

[root@universe-builder local-universe]# cat Makefile
REPO_BASE_DIR ?= $(shell pwd -P)/../..
static_version ?= 0.2-2
static_image ?= universe-static:$(static_version)

.PHONY: certs base clean

certs:
	mkdir certs && openssl req					\
		-newkey rsa:4096 -nodes -sha256 -keyout certs/domain.key	\
		-x509 -days 365 -out certs/domain.crt			\
		-subj "/CN=master.mesos"

base: clean certs
	docker build -t universe-base -f Dockerfile.base .

clean:
	rm -rf certs &&							\
	rm -f local-universe.tar.gz || 0

static-build:
	docker build -t $(static_image) -f Dockerfile.static .

static-online:
	docker pull mesosphere/$(static_image) && \
		docker tag mesosphere/$(static_image) $(static_image)

static-base:
	docker build -t universe-base -f Dockerfile.static.base .

local-universe: clean
	python3 $(REPO_BASE_DIR)/scripts/local-universe.py			\
		--repository $(REPO_BASE_DIR)/repo/packages/	\
		--include="marathon-lb,jenkins,cassandra,spark,spark-history,beta-confluent-kafka,confluent-kafka,beta-kafka,chronos,etcd,grafana,influxdb,kafka,kibana,mariadb,postgres,mongodb,mysql,neo4j,neo4jreplica,redis" &&							\
	docker save -o local-universe.tar mesosphere/universe:latest &&		\
	gzip local-universe.tar

I have the same issue failed to build spark-history is there any fix or work around for this issue?

For the time being we packaged up spark-history ourselves and serve it to the cluster via artifactory.


How to write a method that uses basic data type?

Suppose I want to define a method which accepts a float and returns a float,
I can do it like this:
message Number {
    float value = 1;
}

service Calculator {
    rpc SquareRoot(Number) returns (Number) {}
}

But it means that I need to define message for every basic data types like double, int, bool, etc.
Is there a way to define the method to use basic data types like float without defining a new message?
E.g. rpc SquareRoot(float) returns (float) {}

I'm not sure why this issue didn't get assigned to the default assignee, but that's why no one noticed it until now.
You could use the existing wrappers that ship with the protobuf library:
https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/wrappers.proto
If you have further questions, please ask on the grpc.io mailing list.  Thanks!


No need to clone the whole repo ...

see http://stackoverflow.com/a/3489576
This should speedup execution time and reduce network load.

nobody seems to take care -> close


Make option for manual start of synchronization

Would be a good idea to add option for non-automatic synchronization trigger.
For example: Host sits on server, another joins. When it joined, now it would automatically start synchronization.
With that feature, i can launch synchronization when i want.
This needed for example when you have to do local stuff before actual synching and you need to make sure that you are actually connected to server right now.

I think as part of this cleaning up the game synchrnoizer a bit and maybe adding a new player object and state.
Right now the game synchronizer just reacts to events such as player join / leave and it also contains a bunch of seperate lists containing information about each player. These lists should be combined into one and rather add some sort of player information object that contains the data. If possible most of the logic could be moved into this player information class and the synchronizer could function in a similar manner as the MDReplicator where these info objects just use the game synchronizer to pass messages. While the actual handling of the messages happens within the object.
So what I would like to see is something like,

New PlayerSynchObject and move logic from GameSynchronizer into this object
This object tracks everything for that player and handles all the logic
This object will have a state, (New, SynchInProgress, Synched, etc...)
Object can be controlled with simple methods such as StartSynch, etc..
Object should read configuration through GameSynchronizer to see if things are automatic or not.
This object sends all networked messages and events through the GameSynchronizer

I think this would really help make the GameSynchronizer and the logic within more readable and easier to understand. This will also make this feature easier to implement.

I have completed the refactoring mentioned above, the pull request for this has been filed. This does not fix this issue but it should make it easier to fix this issue.


Introduce heading and text block select menus

Introduce a select helper and use it to create heading and text block select menus menu.
Use the custom handler to prevent the default behaviour and listen to the 'change' event on the select instead.
Introduce an update callback for menu items and use it to programatically enable and disable the options in the select.
Reinstate testing now that we have all of the block types in the menu again.

https://trello.com/c/w4HwXw42/2606-h3-h6-toolbar-dropdown
https://trello.com/c/9JnXLroA/2600-text-block-menu-component
Screenshot

Couple of comments, but they're more feedback for Nadeem than you! Would be interested to know if you agree though

Thanks! I've schedule some time with Nadeem today to discuss these