The build process should include git commit ID

Scripts will create a vnmr/adm/sha1 directory with git ID and sha1
checksums of all files.

Does this put the git commit SHA1 in a file too? Like
git rev-parse HEAD
That would be good for tracking the build source code

Yes it does although I forgot about git rev-parse. I use git log -1 to get
the sha1 number of the last commit
On Wed, Aug 31, 2016 at 11:16 AM, Timothy Burrow<EMAIL_ADDRESS>wrote:

Does this put the git commit SHA1 in a file too? Like
git rev-parse HEAD
That would be good for tracking the build source code
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/OpenVnmrJ/OpenVnmrJ/pull/44#issuecomment-243853035,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANelBiLFm0kj7gGvgF4t3oIY8HDUFidnks5qlcUWgaJpZM4Jx5hx
.

I am also going to fix the common/SConstruct so that it automatically
creates the vnmr/vnmrrev file with the correct version and date
On Wed, Aug 31, 2016 at 11:16 AM, Timothy Burrow<EMAIL_ADDRESS>wrote:

Does this put the git commit SHA1 in a file too? Like
git rev-parse HEAD
That would be good for tracking the build source code
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/OpenVnmrJ/OpenVnmrJ/pull/44#issuecomment-243853035,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANelBiLFm0kj7gGvgF4t3oIY8HDUFidnks5qlcUWgaJpZM4Jx5hx
.


FEATURE: SSO--expire sessions

1] If a user logs out explicitly of the Portal, expire all related sessions including SSO.
2] If a user's session is older than 24h, require reauthentication.

Just revised the wording.


Issue/444 mapdl element commands

Moved element commands to a new class
Homogenised return of run to Optional[str]
Added typehints to all methods moved over
added an Exception to a load of bare excepts I found (if this needs to be reverted it can)
Created two new custom types: MapdlInt and MapdlFloat which could be developed further in the future.
I intend to make unit tests for all of these, but they will go into a separate PR.

Argh, this is on the wrong branch again. I will make a new PR on the correct one


update htlc contracts

Codecov Report

Merging #171 into release-rc2 will increase coverage by 0.38%.
The diff coverage is 11.42%.


⚠ Bofrost.de has degraded performance

In b053b85, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1424 ms

Resolved: Bofrost.de performance has improved in 3500b88.


Help: Add a chapter for the yum command

Please fill out this template
Add a chapter for the yum command:
https://github.com/bobbyiliev/101-linux-commands-ebook/blob/main/ebook/en/content/053-the-yum-command.md
Additional context
Make sure to check out the Guidelines.md file on how to contribute!

I'd like to work on this, could you assign to me? Thanks!

Absolutely! Just assigned you to this issue


User feedback: Javascript isn't appealing to click

Hour of Code, 07/12/16, Darrington HS
The JavaScript button isn't highlighted enough. From my observation, no kid clicked on it. Maybe it should show something else, like: "Code", or maybe it needs to be a different color. For many, Javascript was a little foreign.
Let's discuss / experiment.

@pelikhan has been looking at showing the code alongside the blocks and I think this might be a great way to entice people into editing it too.

That's a good idea.
Another thing we could do is make it more of a toggle switch. So instead of being a button, it could be something like this:

If the name "javascript" is foreign to them, then the text inside the javascript editor is going to be foreign as well. We need to make the JS editor friendlier before trying to bring users to it more aggressively.

@microsoftsam Code instead of JS will be confusing because kids see the blocks as code.  Never going to fit on the average screen in the schools I work with. The editor is already cramped as it is.
1280px wide is about as big as it gets still.
I like the toggle button idea, assuming the view toggles without losing all the blocks layout, positioning, zoom, etc

@EdNutting  not a fan at all of the side by side blocks/javascript.

When described by the researchers we talk to, the point of the side-by-side stuff is to invite people towards understanding text based coding as a follow on from blocks, not a jump.  I think the idea is that it It teaches them about code as they go...
The common thing we hear is that kids have to go back and re-learn text-based coding after moving on from blocks, and many people never do, and teachers are scared of it too. The idea of seeing "this block maps to that text" might be able to help there. I agree, there are big UI complexities.
@EdNutting and @pelikhan what do you think about the 'slider' in the bottom of the CodeKingdoms editor?

-->

play here: https://www.microbit.co.uk/app/#create:tomwku

The problem is that teachers want "scratch"-like blocks with a canvas where you can drop blocks anywhere. No sliders from there.
In PXT, blocks and js are built on two different editor stack, sliders highly unlikely to happen.

I agree with the idea of moving people along by allowing block editing while they see the effect on the text based code.
The reality sadly though is that screen sizes and cheap hardware setup means computers used in classrooms either aren't big enough or aren't fast enough to make it work properly.
The slider on Code Kingdoms is good. But as @pelikhan says, that might be hard to reproduce for the PXT editor.
Is there a way to do a "highlight box" or something, that when you select a block, it shows you the JS just for that block? (without its contents). That clear separation of code and direct link from one block to specific lines of code would solve the transfer problem and solve the problem of teachers/students being overwhelmed by the mass of JS produced by lots of blocks.

(Without its contents meaning the loops and conditional blocks just shown "while (xyz) {...} where xyz is the actual condition from the code but '...' is literally "...".
Statements / expressions could then show their action in bold and sub-blocks in non-bold)

Is there a way to do a "highlight box" or something, that when you select a block, it shows you the JS just for that block?

We could render javascript in the codecard in the bottom right.

Yep, with a switch to turn that on/off that could work quite well.

That would be nice per block but I would love not to lose sight of the desire to see the whole program change as a block goes in/ moves etc.
--
Please excuse brevity and typos, this was sent from a phone

On 9 Dec 2016, at 20:06, Edward Nutting<EMAIL_ADDRESS>wrote:
Yep, with a switch to turn that on/off that could work quite well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I would love not to lose sight of the desire to see the whole program change as a block goes in/ moves etc.

As soon as you have more than a few blocks, I don't see how a kid could correlate changes in blocks and changes in a second pane of containing dozens of lines of JavaScript.

--
Please excuse brevity and typos, this was sent from a phone

On 9 Dec 2016, at 20:13, Peli de Halleux<EMAIL_ADDRESS>wrote:
I would love not to lose sight of the desire to see the whole program change as a block goes in/ moves etc.
As soon as you have more than a few blocks, I don't see how a kid could correlate changes in blocks and changes in a second pane of containing dozens of lines of JavaScript.

What about highlighting/colouring the currently selected block and/or recently changed blocks?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Proposal:

simple item in the advanced that has word Javascript with different colors for each letter that performs the function of the really boring Javascript menu item
removal of Block Menu item when in Blocks anyway
removal of the really boring Javascript menu item when in Blocks (see rainbow Javascript proposal)
what ever you fancy to get back to Blocks from Javascript
complement with Javascript exposure whilst in Blocks: eg. expose in help card for block

Background:

Screen area: useless Blocks and Javascript menu items
Those who will go forward will go forward, and be attracted by Advanced

In general,
Please remember that all forms of automatic popup eg help or whatever, have a context under self learning.
However, if a teacher is showing a pupil "something", all forms of popup will distract the eye of the pupil from the what the teacher may be trying to show.
Self-learning contra being taught mode switch as a concept.

Except I forgot the hamburger menu beside the stop button
And I like in these times of python v's javascript that our old favorit programming language is back: basic.forever !

Screen shot of 1024x768 with the new toolbox for the javascript editor.
The work done to obtain a road for going from blocks to javascript with recognisable elements is great.
However, losing space on the right of the screen and javascript can be written with short lines, but tabulation for clear indentation gives hell in the long run.
The race is between getting out of beta and schools moving to higher resolution screens with the pupils progress from going from blocks to javascript (and the world ending).

Removal of code card https://github.com/Microsoft/pxt/pull/987

We have moved Javascript\Blocks as tabbed interface grouped together. Fixed from our end.


Better support for transitive deps in Maven/Java (pom.xml)

Currently pom.xml support does not support resolving the full dependency graph.

I can't find any documentation on the Maven integration for the scanner. Can anyone point me to it?

@oliverchang Can data from deps.dev be used to resolve transitive dependencies from direct dependencies identified from pom.xml? If so, no external tool/plugin will be required to get full list of dependencies.

Could it have something to with an effective pom?
https://maven.apache.org/plugins/maven-help-plugin/effective-pom-mojo.html
https://medium.com/@harun_ergul/what-is-effective-pom-5c278fe53031

mvn dependency:list might also help (found in https://github.com/opensbom-generator/spdx-sbom-generator/search?q=mvn)

Also there's a need to configure maven profiles, as some project build different artifacts based on the profile, see https://github.com/GoogleCloudDataproc/spark-bigquery-connector for example

Based on the suggestion by @h4sh5 above, my current work-around is to run something like this:
mvn help:effective-pom -Doutput="${TMPDIR}/pom.xml"
osv-scanner --lockfile="${TMPDIR}/pom.xml"

Thanks for the suggestions all!
I think it may make sense to support a mode to use ecosystem-specifc tooling (e.g. mvn) to achieve this, but we're hoping to avoid adding additional dependnencies, and there are additional complexities around profiles/environments as pointed out in @davidrabinowitz.
We're also exploring approaches using deps.dev as well to resolve this natively without requiring external tooling. We'll keep this bug updated with any new info!

I found that, since I really care about the dependencies (including transitive dependencies) that will be on the classpath at runtime, and required by any consuming packages, the approach that actually works for me is to generate a Software Bill of Materials (SBOM) and run OSV-Scanner against that SBOM instead of the POM file.
I currently have the CycloneDX Maven plugin configured in a profile within my POM file:
<profile>
  <id>sbom</id>
  <build>
    <plugins>
      <plugin>
        <groupId>org.cyclonedx</groupId>
        <artifactId>cyclonedx-maven-plugin</artifactId>
        <version>2.7.9</version>
        <configuration>
          <includeCompileScope>true</includeCompileScope>
          <includeProvidedScope>false</includeProvidedScope>
          <includeRuntimeScope>true</includeRuntimeScope>
          <includeSystemScope>false</includeSystemScope>
          <includeTestScope>false</includeTestScope>
        </configuration>
        <executions>
          <execution>
            <phase>package</phase>
            <goals>
              <goal>makeAggregateBom</goal>
            </goals>
          </execution>
        </executions>
      </plugin>
    </plugins>
  </build>
</profile>

I use this to generate the SBOM, then run OSV-Scanner run against the SBOM:
mvn --activate-profiles sbom -DskipTests install
osv-scanner --sbom=target/bom.json

If anyone has a better solution, I would really like to hear it.

Hi @oliverchang, are there any news re Maven support for transitive dependencies?
Thanks in advance! :)

Hi @LironJit, we are actively working on this! The changes to resolve Maven projects are on their way. :)

@cuixq with https://github.com/google/deps.dev/tree/main/util/resolve/maven now being available, do we just need to integrate that into OSV-Scanner?

@oliverchang yes, I think so - I just started working on this!


Dropdown inside reveal modal causes issues

Seems like putting a dropdown inside a modal will cause issues. If you open the dropdown and click outside to close it (but not close the modal), the "closed" event will be triggered for the dropdown.
I think this bubbles up, firing off the modal's "closed" behavior as well, which causes the modal to semi-close (really, it shifts around).
I believe this is the code causing the issue:
https://github.com/zurb/foundation/blob/master/js/foundation/foundation.dropdown.js#L105
It was recently changed to add [dropdown], but I don't believe that fixed the problem.
Currently, I solve this by adding the following code for each drop down. This prevents the aforementioned bubbling:
  $("#drop").on('closed', function() {
    return false;
  });

I'd love to try and fix this, but I don't currently know enough about event triggering and namespaces.

Hi, I see this issue still pops up in V5.5.0. @silviogutierrez your solution has worked for me. Thanks.

The answer from @sylvaiin is the best solution, cause it is now the official fix.
https://github.com/zurb/foundation/blob/master/js/foundation/foundation.dropdown.js#L153


Feature/fix azure openai

Description
Changed the import of AzureChatOpenAI from langchain_community.chat_models to langchain_openai
Merged code from openai.py to support streaming
Changed default api_version to newest 24-02-01
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.

[X] Test Script embedchain/examples/chat-pdf/app.py with 'llm.provider' = 'azure_openai' and available deployment_name and environment variabls AZURE_OPENAI_ENDPOINT and AZURE_OPENAI_API_KEY set.

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[X] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

Hi @r3dl3g Thanks a lot for adding the changes. Can you please check why tests are failing and also please add a test for streaming output?
You can use this as reference: https://github.com/embedchain/embedchain/blob/main/tests/llm/test_openai.py#L52

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@r3dl3g Can you please check fix the conflicts and check the failing tests?

thanks for your contribution @r3dl3g
Closing this PR as there are so many merge conflicts. Please feel free to raise another PR.


MCMultipart Support for 1.8.8

See: https://github.com/amadornes/MCMultiPart
Sadly this is only for 1.8 - we will have to wait til CC gets updated for that.

Interesting! I might jump back in for this. I'll have to check out the API. I'd love to contribute to that as well

You'll have to wait a bit - its only for 1.8.8 which CC hasn't updated to yet. :frowning: I'd love your help when the time comes though!

Yea I know. I can look at the API and maybe do some work on that though.

CC has been updated to 1.8.9: Hoping to get most of the code working later today. Some things to note though with the new API:

The part converter allows returning multiple parts from one so there is no need for PartModemWithCableIntermediate.
There is also a reverse converter, which means we can revert simple multiparts back into CC cables/modems.
We will have to use blockstates. Though we can probably hook onto CC's own modem models.

This should also close #36.

Looks like MCMultiPart could have more potential than FMP. Exciting.

I think LexManos is considering integrating it with Forge, so it is an official API which is even better: there is pretty much guaranteed continuity for 1.8.9+. This API and blockstates should make the code much nicer & smaller. :smile:

Fantastic. The FMP code was... Annoying, to say the least.

Closed in #80


Update AGAttributeInfo API

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (071384c) 11.52% compared to head (1b5d7f2) 11.54%.

Files
Patch %
Lines

Sources/OpenGraph/Attribute/OGAttribute.swift
0.00%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   11.52%   11.54%   +0.01%
==========================================
  Files          38       38
  Lines         772      771       -1
==========================================
  Hits           89       89
+ Misses        683      682       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix for documentation of the [form]TruncatingRemainder methods.

The result of these methods was incorrectly documented as having
the same sign as other (the divisor) rather than self (the
dividend). This patch corrects the documentation, and also fixes
the capitalization of formTruncatingRemainder in one location.
Resolves SR-2782.

@swift-ci Please smoke test and merge.


move the repository to GeoRust

Hi,
we've done some work on your repository to add a rust-geo conversion.
I think this project will have more visibility if it's moved to the GeoRust organisation.
Would you be willing to move it ?
else I can either:

move our fork in GeoRust, but then it would be marked as a fork thus It will be a bit more difficult for users to know it's the 'main' repository
push our fork in GeoRust as a new project (and mentioning this repository in the readme), this way it won't be a fork, but I feel that it would be better for your original project to  become the official one

If you agree to move this repository, I'll ask the GeoRust guys to add you in the GeoRust organisation
Thanks for your great work,
Antoine

Hi,
I took a look and tried your fork: great job (which will also allow me to learn from the mistakes I made in my original code)!
Thank you for your proposal, I am totally inclined to move my directory to the GeoRust organization (by the way I am already a member of the organization but I don't know if I have the rights to add / move a repository).
I will try to move it and I'll let you know.
Thanks!

great 👍 !
Thanks for your great work, I realized when I try to add some stuff that it's always painful to interact with C 😆


Add hipStructKernel test - passing struc to kernel

This test will pass a structure filled with values to kernel, then verify the values in int array.

@aaronenyeshi @Srinivasuluch I believe the test in this PR is covered by #511. If so, we should be able to close this. Can you confirm that?

Yes, I think it's covered there, Thanks!


Deprecate Helmfile.yaml and kiam scripts

what

Deprecate the helmfile.yaml

why

Moved to https://github.com/cloudposse/helmfiles

@goruha @MoonMoon1919 heads up


links to extendr-fn and extendr-impl macros broken in docs

In the docs page here:  https://docs.rs/extendr-macros/0.7.1/extendr_macros/attr.extendr.html
The links to the extendr-fm and extendr-impl macros are broken

Thanks. I have had a very hard time making links between crates, and it has also caused an ICE once... I'll take a look again, most likely, this will remain broken unfortunately.

thanks @CGMossa, my main issue was that I couldn't find the docs for extendr_impl, how do you get to these from the docs.rs page? I eventually just looked at the doc comments in the code


Add warning when --limit pattern has no matches

If you set a --limit pattern that has no matches, then there is no warning that there are no matches in the CLI output, and you'll get something like:
pyinfra -v --limit "foobar" inventories/something.py
--> Loading config...
--> Loading inventory...
--> Connecting to hosts...

--> Preparing operations...
    Loading: something.py

--> Proposed changes:

--> Beginning operation run...
--> Results:

which really gives no clue that you have no matching hosts. If this is done by accident, you might be left groping in the dark (like I was, I set the wrong inventory file in my case in the CLI flag). So just add a little message saying
Nothing matched in `--limit` pattern

or something similar.

Just added this in https://github.com/Fizzadar/pyinfra/commit/ac4fee853c9e4c24fa9cd0f8f51576712c722b91 & released in v1.4.18.


Image width follows content width

On 0.11.10:

On 1.0.0-beta.2:

It will be nice to have the image displayed with correct dimensions that makes more sense for a blog.

Good catch! Fixing


Writes the test properties, CSSProjectStructure, CSSIteration, WorkItemIds and Description to the TRX log

Description
Writes the description, CSS*, test properties and workitem ids to the TRX log in accordance with the vstst.xsd schema
Related issue
The missing traits were discussed in this issue: https://github.com/Microsoft/vstest/issues/98
This PR addressing the lack of CssProjectStructure, CssIteration, Description, Properties/traits and WorkItemIds. The generated TRX has been validated against the schema.
Here's an example of TRX output from a test with 4 properties, where 3 of them have special places to go in the TRX:
        [TestMethod]
        [Priority(4)]
        [TestProperty("Test prop", "Prop val")]
        [WorkItem(1234)]
        [Owner("Morten")]
        [Description("This test contains 4 properties and a priority")]
        [CssProjectStructure("cssprojectstruct_goes_here")]
        [CssIteration("iteration_goes_here")]
        public void TestWithProperties()
        {
        }

TRX:
<?xml version="1.0" encoding="utf-8"?>
<TestRun id="1dbc39c8-cd68-4684-aae1-3cf98dc97760" name="mort5161@MNIELSEN1 2018-10-17 22:48:14" runUser="AVWORLD\mort5161" xmlns="http://microsoft.com/schemas/VisualStudio/TeamTest/2010">
  <Times creation="2018-10-17T22:48:14.4655780-07:00" queuing="2018-10-17T22:48:14.4655784-07:00" start="2018-10-17T22:48:11.1260893-07:00" finish="2018-10-17T22:48:14.6676358-07:00" />
  <TestSettings name="default" id="61058af8-5506-4b9d-b8f2-1d263543cf12">
    <Deployment runDeploymentRoot="mort5161_MNIELSEN1_2018-10-17_22_48_14" />
  </TestSettings>
  <Results>
    <UnitTestResult executionId="49d87ce0-a1b6-4497-a848-9df61cd0d438" testId="40b0cd91-e3c2-d2c7-c9de-8d3b3d7e3bd1" testName="TestWithProperties" computerName="MNIELSEN1" duration="00:00:00.0128826" startTime="2018-10-17T22:48:13.8234820-07:00" endTime="2018-10-17T22:48:13.9008950-07:00" testType="13cdc9d9-ddb5-4fa4-a97d-d965ccfc6d4b" outcome="Passed" testListId="8c84fa94-04c1-424b-9868-57a2d4851a1d" relativeResultsDirectory="49d87ce0-a1b6-4497-a848-9df61cd0d438" />
  </Results>
  <TestDefinitions>
    <UnitTest name="TestWithProperties" storage="unittests.dll" priority="4" id="40b0cd91-e3c2-d2c7-c9de-8d3b3d7e3bd1">
      <Css projectStructure="cssprojectstruct_goes_here" iteration="iteration_goes_here" />
      <Description>This test contains 4 properties and a priority</Description>
      <Owners>
        <Owner name="Morten" />
      </Owners>
      <Execution id="49d87ce0-a1b6-4497-a848-9df61cd0d438" />
      <Properties>
        <Property>
          <Key>Test prop</Key>
          <Value>Prop val</Value>
        </Property>
      </Properties>
      <WorkItemIDs>
        <WorkItem id="1234" />
      </WorkItemIDs>
      <TestMethod codeBase="UnitTests.dll" adapterTypeName="executor://mstestadapter/v2" className="UnitTests.Tests" name="TestWithProperties" />
    </UnitTest>
  </TestDefinitions>
  <TestEntries>
    <TestEntry testId="40b0cd91-e3c2-d2c7-c9de-8d3b3d7e3bd1" executionId="49d87ce0-a1b6-4497-a848-9df61cd0d438" testListId="8c84fa94-04c1-424b-9868-57a2d4851a1d" />
  </TestEntries>
  <TestLists>
    <TestList name="Results Not in a List" id="8c84fa94-04c1-424b-9868-57a2d4851a1d" />
    <TestList name="All Loaded Results" id="19431567-8539-422a-85d7-44ee4e166bda" />
  </TestLists>
  <ResultSummary outcome="Completed">
    <Counters total="1" executed="1" passed="1" failed="0" error="0" timeout="0" aborted="0" inconclusive="0" passedButRunAborted="0" notRunnable="0" notExecuted="0" disconnected="0" warning="0" completed="0" inProgress="0" pending="0" />
  </ResultSummary>
</TestRun>

@dotMorten , will this change existing trx schema? I'll take a deeper look once I'm back on Monday.

@mayankbansal018 ping on this one.

I don't see any tests for these changes. Can we please add.

It's not clear to me how you test the output of a trx report. Please advice/help

I would really like to help to get output of traits implemented in trx. Can I create a new PR using  @dotMorten's code that only outputs traits as key/value elements as he proposed, and thus skipping special handling of Description, WorkItem, CssIteration and CssProjectStructure? I will add some tests as mentioned in @singhsarab's last comment.

@agehrke I am sure @dotMorten would like that.
Please let me know if you need any help.

This part of the resulting XML seems to be wrong/other than former MSTest.exe created it. VS2019 is not able to show the Associated Work Items in its Test Result viewer.
Actual:
...
    <WorkItemIDs>
        <WorkItem id="1234" />
    </WorkItemIDs>
...

Expected:
...
   <Workitems>
       <Workitem>1234</Workitem>
   </Workitems>
...

Apart from my former comment, what's the status of this PR? We look forward to get support for the work items in trx file.


Error when specifying exclude_labels

When I specify the exclude_labels property in the .github_changelog_generator file, I get the following error:
generator_processor.rb:9:in `&': no implicit conversion of String into Array (TypeError)
from generator_processor.rb:9:in `block in exclude_issues_by_labels'
from generator/generator_processor.rb:8:in `select'
...

I tried different syntaxes in the config file, but none work:
exclude-labels=duplicate,on hold,wontfix
exclude-labels=[duplicate,on hold,wontfix]
exclude-labels=["duplicate","on hold","wontfix"]

This does not occur when I specify it on the command line:
github_changelog_generator --exclude-labels=wontfix,duplicate

I'm having a slightly different error installing, both from rubygems and master on GH.  This is on OSX 10.11.4 (beta), ruby 2.0.0p648, gem <IP_ADDRESS>.
Building native extensions.  This could take a while...
ERROR:  Error installing github_changelog_generator:
	ERROR: Failed to build gem native extension.

    "/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby" -rubygems /Library/Ruby/Gems/2.0.0/gems/rake-10.4.2/bin/rake RUBYARCHDIR=/Library/Ruby/Gems/2.0.0/gems/github_changelog_generator-1.11.0/lib RUBYLIBDIR=/Library/Ruby/Gems/2.0.0/gems/github_changelog_generator-1.11.0/lib
fatal: Not a git repository (or any of the parent directories): .git
rake aborted!
LoadError: cannot load such file -- rubocop/rake_task
/Library/Ruby/Gems/2.0.0/gems/github_changelog_generator-1.11.0/Rakefile:2:in `<top (required)>'
(See full trace by running task with --trace)

Gem files will remain installed in /Library/Ruby/Gems/2.0.0/gems/github_changelog_generator-1.11.0 for inspection.
Results logged to /Library/Ruby/Gems/2.0.0/gems/github_changelog_generator-1.11.0/./gem_make.out

@jlambert121 try again. It should work now.

Continued work on this in #354.


Missing H1 check

Add H1 check:

Check if function content is in a header file
Check if non-global variable is in a header file
Check if a structure is in a source file
Check if a DEFINE is in a source file

TODO 👍

Added function content check in a header files

Added define check in source files

Added structure check in source files


rename walkthrough id

renames the walkthrough id from azure-get-started to get-started

Closing because we were able to work around the character limit


When deployed on hosting

When i deployed on hosting i got an error
On PC all works
NotificationChannels \ Discord \ Exceptions \ CouldNotSendNotification
Discord responded with an HTTP error: 401: 401: Unauthorized

Can you post the full stack trace?

I do the connect on the hosting via shell access but it not helps

what i  can do if the artisan discord:setup on host not works

Do you get an error when running discord:setup on your server?

If you haven't solved this, the token is the Bot's token rather than the App's. Prior to running php artisan discord:setup I would get 401 Unauthorized when using the App's token and 400 Unauthorized with the Bot's token. While using the Bot's token, I ran php artisan discord:setup and my problems were fixed.
Make sure you have the right token.

Close this. No response.


doc: update docstring external Faithfulness methods

Hi, how can I fix the codestyle_check check? The issue is with base.py:10:45 where that I have not touch it at all. This happens to my other PR too. Can you please take a quick look at it (and this one)?

closing this one too but thanks again - I'm left a note in one of the other commits you posted, hope you take a look at that 🙂
and I hope you I see you around too ❤


Frends.SFTP.UploadFiles bug in filemasks

Filemask in the task is not working correctly. All regex attributes like brackets '[ ]' are not valuated correctly. This needs to be tested more to find out if this is the case.

This has been fixed in the newest version


add current_time option to out_stdout

Current out_stdout outputs messages as
2010-05-04 12:02:01 +0900 test: {"test":"test"}

where the time expresses the time parameter of messages, i.e., the time when the message is created or, the time written in application logs.
current_time option enables to output the current time of logging which looks like
2014-04-24 18:49:23 +0900 2010-05-04 12:02:01 +0900 test: {"test":"test"}

so that we can tell the latency between receiving (logging) and sending (creating) of messages.
PS. I am still wondering the log format and the option name.

@kiyoto @repeatedly @tagomoris ping

It seems to be not so general that OutStdoutFormatter exists ... but I also found OutFileFormatter. Ooooooops.
I think better that output plugin specific formatter exists in out_xxx.rb.

@sonots The code itself looks good to me.
@tagomoris agree with the lack of generality of out_stdout/out_file formats. As a matter of fact, I think both formats are pretty unpopular/confusing for the newcomers (see, for example, "Problem #2" in this blog post. That said, I am against breaking out just out_file and out_stdout formatters. If we are going to break out individual parsers/formatters, we should apply the same principle as output/input plugins and put them all under lib/fluent/plugin with the prefixes parser_ and formatter_.

I completely agree that out_file and out_stdout formatter are not general, but this was my compromise to support old version compatibility.

out_file format is also used in out_s3 so this format cannot be located in out_file.rb.

So, need to move to out_stdout.rb or not?

stdout filter has this feature so close this PR.


Set user agent to 'Coursier/2.0'

I guess the version should stay at '2.0' for the time being - not to leak the full coursier version, or details about the OS, all around.

Related: #2246


fix(discordeno)!: Fix some errors in DiscordenoConfig

Fix typo in DesiredProprietiesBehavior
Remove the RecursivePartial from DiscordenoConfig.desiredProperies.properties as it makes the object just harder to work with, as it is "lying" since the object should always be constructed with all the props

[!WARNING]
This is breaking since it is renaming a type

Could you actually go through entire codebase and replace all proprieties with properties while you’re at it?


Infinite login loop caused by Auth0 Rule error (Next.js - SPA mode)

Describe the problem you'd like to have solved
We have a custom rule setup that throws an unauthorized error if the user does not belong to a specific email domain (code here, sample snippet below)
function emailDomainWhitelist(user, context, callback) {
    // Access should only be granted to users that verify their email
    if (!user.email || !user.email_verified) {
        return callback(
            new UnauthorizedError('Access denied, only internal employees can access this app')
        );
    }

    const whitelist = ['sample-domain.co'];

    const userHasAccess = whitelist.some(function (domain) {
        const emailSplit = user.email.split('@');
        return emailSplit[emailSplit.length - 1].toLowerCase() === domain;
    });

    if (!userHasAccess) {
        return callback(
            new UnauthorizedError('Access denied, only internal employees can access this app')
        );
    }

    return callback(null, user, context);
}

In our Next app (using SPA mode), we protect page with the following syntax:
import { withAuthenticationRequired } from '@auth0/auth0-react'

export default withAuthenticationRequired(PageComponent);

Because the rule itself throws an error, the app is failing to receive a new authorization code, but is receiving new state each time (explained in good detail here).
This causes an infinite loop in the useEffect hook here.
Alternatives and current work-arounds
Currently, we have reverted to using custom claims in the rule rather than throwing an error.
I believe this could also be fixed by wrapping the withAuthenticationRequired HOC differently so that the app doesn't re-render (and thus restart the login flow) endlessly.  I have not explicitly tested this, and would prefer not to use it as a workaround since it is not very intuitive.
Describe the ideal solution
Ideally, I would expect this library to handle the ?error=&error_description= params and throw a login error.
I see that these are handled here, but the problem I'm seeing is that client is re-rendering over and over again, and thus, this line is never reached.
My initial thought is that this line should check to see if a code param is present, and if not, throw an error immediately.  Instead, it checks to see if there is an error OR code, which always returns true and causes the loop.
Thanks for any and all help!

Hi @zachgoll - it sounds like the route you redirect to requires authentication.
You need to catch any callback error before you try to render a page that requires authentication.
If you can share a repo that demonstrates the issue I can make some more concrete suggestions

Hi @zachgoll - it sounds like the route you redirect to requires authentication.
You need to catch any callback error before you try to render a page that requires authentication.
If you can share a repo that demonstrates the issue I can make some more concrete suggestions

Yep, that was it!  Thanks for the help here.
My entire app is protected (index page included), so ideally, I'd like to:

On successful auth, redirect to the page the user was previously on
On failure, redirect to an explicit error page, say /not-authenticated

Is this the correct way to do this?  I'm having a bit of a hard time distinguishing between the redirectUri and onRedirectCallback here:
return (
  <Auth0Provider
      domain={auth0Domain}
      clientId={auth0ClientId}

      // Should this line
      redirectUri={(typeof window !== 'undefined' && window.location.origin) || 'not-authenticated'}
      audience={auth0Audience}
      onRedirectCallback={(appState) => {
          Router.replace(appState?.returnTo || 'not-authenticated')
      }}
  >
      {children}
  </Auth0Provider>
)

Hi @zachgoll - apologies for the delay in response

My entire app is protected (index page included), so ideally, I'd like to:

This is the likely the issue for the infinite loop. The page that processes your callback needs to be accessible before you're logged in.
The code you've shared looks fine. If you can share a working example repo that demonstrates the issue I could debug it for you

Hi @zachgoll - closing due to inactivity. Feel free to share an example repo that demonstrates the issue if you want me to reopen this.


Fix human readable task_runtime

Refs: #2010
This fixes 3 issues introduced by adding human readable task_runtime:

commented code left out
double "seconds" word in the logs
inconsistent and difficult-to-parse format of task_runtime in the results log yaml

Description
(name of issue/change)
Issues:
Refs: #NNN
How has this been tested:

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Verified all A/C passes

[ ] develop
[ ] master
[ ] tag/other branch

[ ] Test environment

[ ] Shared Packet K8s cluster
[ ] New Packet K8s cluster
[ ] Kind cluster

[ ] Have not tested

Types of changes:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:
Documentation

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] No updates required.

Code Review

[ ] Does the test handle fatal exceptions, ie. rescue block

Issue

[ ] Tasks in issue are checked off

Build passing - https://github.com/cnti-testcatalog/testsuite/actions/runs/8980928494


Update phpunit allowed versions

To have namespace used since 4267a75cb5c3555319f17b35f5031f5590560345

hmm interessting that travis builds didn't error for 4267a75

hmm interessting that travis builds didn't error for 4267a75

composer pull 4.8.36 so it works.

Thanks

yeah, unless you use --prefer-lowest, composer will choose the highest version (and so will not validate that your lower bound is the right one)


add the device feature

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (234b6d7) 91.09% compared to head (c8e79f7) 90.68%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   91.09%   90.68%   -0.41%
==========================================
  Files          19       19
  Lines         730      741      +11
==========================================
+ Hits          665      672       +7
- Misses         65       69       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


model_kwargs aren't successfully passed in predict method

In core.py, line 211, model_kwargs are not being successfully passed through the _model internal wrapper:
BaseNumpyroModel._model() got an unexpected keyword argument 'sample_obs'

I've created the above PR #3 that will fix this issue.


Combine DscResource.LocalizationHelper and DscResource.Common into xActiveDirectory.Common

We should combine the helper modules DscResource.LocalizationHelper and DscResource.Common into xActiveDirectory.Common.
We need to name the new module xActiveDirectory.Common so it does not conflict with another resource modules helper module if both resource modules would be using the same generic name.
That could result in missing helper functions if both moduels are used in the same configuration.

Hi,
So basically what needs to happen here is to merge the code from both modules into a new module and then update all script module files and all pester test files(are they called like that or just unit test files?), where the the old modules are referenced(imported)?

I made an attempt to combine them and I've create a PR. Let's see how that goes..
One question though - do I need to do some sort of testing on my machine first? Or is only the CI pipeline used for that part?

Combining the modules like that will require some forklifting in the unit tests as well, as those are part of what is validated during the pipeline.


Apps in progress dashboard table updates

 [QAE16IMP] Applications in progress dashboard table

Well done :+1:


⚠ Bofrost.de has degraded performance

In 4bb3787, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1434 ms

Resolved: Bofrost.de performance has improved in b9e124c.


Bug: Splunk HEC rejecting ingestion due to invalid keys "reingest" and "frombucket" in event metadata

I have tested the whole setup of firehose-reingest option in 2 different environments.  In both cases the events are failing to reach Splunk.  The error message is: "The data is not formatted correctly.....".  This needs to be fixed urgently otherwise the aws-splunk-firehose-error-reingest/firehose-reingest option won't work.
The event metadata sent to Splunk HEC contains 2 additional keys "reingest" and "frombucket" which is causing the problem.  These additional fields are causing the Splunk HEC to reject the event.
cURL command including keys "reingest" and "frombucket" fails:
[ec2-user@ip-xxx-xx-xx-xx ~]$ curl -k -H "Authorization: Splunk <Authentication token>" http://xx.xxx.xx.xxx:8088/services/collector/event -d '{"sourcetype": "test-sourcetype", "source": "aws:firehose", "event": "This is a test event", "reingest": "reingest:1", "frombucket": "test-bucket"}'
{"text":"No data","code":5}

cURL command excluding keys "reingest" and "frombucket" succeeds:
[ec2-user@ip-xxx-xx-xx-xx ~]$ curl -k -H "Authorization: Splunk <Authentication token>" http://xx.xxx.xx.xxx:8088/services/collector/event -d '{"sourcetype": "test-sourcetype", "source": "aws:firehose", "event": "This is a test event"}'
{"text":"Success","code":0}

I ran a simple test to confirm this.  I removed the below lines from aws-splunk-firehose-error-reingest/firehose-reingest/kinesis_lambda_function.py and the events are getting written to Splunk index successfully.
        if data.get('reingest')!=None:
            return_event['reingest'] = data['reingest']
        if data.get('frombucket')!=None:
            return_event['frombucket'] = data['frombucket']

Removing these lines is not the solution as:

The function will go to an infinite loop if the ingestion to Splunk fails
The reingest key is used to store the number of time the reingest has happened and frombucket key is used to store the S3 bucket from which the event data has been fetched.

A solution is needed that does not send these keys in the event metadata to Splunk but passes these values to the next iteration in case of a failed delivery to Splunk through any other means.

@SidMallya - can you confirm that you are using the Event endpoint for HEC with your firehose vs Raw

@pauld-splunk - I confirm that I am using the Event endpoint for HEC with my firehose.

@SidMallya updated and fixed


it seems the repman-io/composer-plugin doesn't respect the url for self hosted repman.

the notification url is still https://repo.repman.io/downloads, not ourself  https://main.repo.acme.net
composer.lock
-            "notification-url": "https://packagist.org/downloads/",
+            "notification-url": "https://repo.repman.io/downloads",

composer.json
 "repositories": [
      {
            "type": "composer",
            "url": "https://repo.magento.com/"
        },
        {
            "type": "composer",
            "url": "https://main.repo.acme.net"
        },
        {
            "packagist": false
        }
    ],

To do this, you need to slightly modify the configuration in composer.json:
    "extra": {
        "repman": {
            "url": "https://repman.your.company/"
        }
    }

https://github.com/repman-io/composer-plugin#self-hosted-repman-server


Do not merge, this is a test pull-request

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing it as it should not be merged.


questions about operating service

For stable operating service, I have questions.

on ironfunctions, dose it support redundancy?
Does it support ssl https? If possible, let me know path of document about that
Additionally, we use ELB or ALB for secure line.

I did ask to iron.io service team. I couldn't get answer.
so I leave here.

https should be possible with Caddy straight out of the box.  Define the iron hosts and proxy via Caddy.
https://github.com/iron-io/functions/tree/master/examples/caddy-lb
Edit the Caddyfile and it'll auto-generate via letsencrypt so you're SSL cert is done?


Mechanism to register event hooks with a lambda?

I've got a lambda written that I want to hook up with an SNS topic. I didn't see any way to do this via the documentation? Is this a planned feature in the future by any chance or did I just miss something in the documentation?

Generally we suggest using Terraform for anything besides Lambda funcs. We don't what to rewrite existing tools. You can get function ARNs via list command http://apex.run/#listing-functions

Understandable... I guess I prefer a more integrated solution, but the design decision makes sense. Wondering if this could be addressed by creating an apex-recipes type repository that's a bit more in depth than the examples and shows how to do stuff like glue Apex together with Terraform to build a SNS notification processor.
Anyways great tool and the first one I think that actually makes Lambda feel "easy".

We do plan on having tighter integration with TF, and potentially provide generators and/or TF modules to help in situations like you mention. There's definitely a reasonably large barrier for getting up and running right now.
I'm going to close, but keep an eye on #253!


use codecov

I discovered something very weird on my local machine.
When I run the tests with coverage:
$ py.test -v --cov=pangeo_forge --cov-config .coveragerc --cov-report term-missing -s -k test_fixture_http_files

This test fails:
tests/test_fixtures.py::test_fixture_http_files[2D]
...
E               FileNotFoundError: http://<IP_ADDRESS>:8080/000.nc

However, it works without the coverage options!
Will the same happen on CI?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@bba0be8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage          ?   76.68%
=========================================
  Files             ?        6
  Lines             ?      326
  Branches          ?        0
=========================================
  Hits              ?      250
  Misses            ?       76
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba0be8...e4e4777. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@bba0be8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #61   +/-   ##
=========================================
  Coverage          ?   76.68%
=========================================
  Files             ?        6
  Lines             ?      326
  Branches          ?        0
=========================================
  Hits              ?      250
  Misses            ?       76
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba0be8...e4e4777. Read the comment docs.

So actually those tests skip (see #33), so we don't have a chance to see the error here.

So actually those tests skip (see #33), so we don't have a chance to see the error here.

Blosc error again! #58

Blosc error again! #58


Visual Studio should discover and auto-connect ADB to WSA

Is your feature request related to a problem? Please describe
When installing WSA and enabling developer mode, WSA is not offered as a run-target in VS.
You first have to open the ADB prompt and manually connect, while trying to remember the command to do so (and before this learn that you need to do this).
Describe the solution you'd like
I'd want Visual Studio to auto-detect that WSA is installed, and automatically offer WSA as a run-target. If WSA isn't running, first time you launch your application, Visual Studio will run the ADB connect command, and deploy the application to WSA. This saves the step from having to manually connect every single time you launch Visual Studio and put the work on the tooling side to do this step. It would help discovery for any developer who wants to deploy to Android.
With Android devices, all you do is plug them into the USB port and they are auto-offered as a target. WSA should be just as easy, if not easier, since it is already installed and available.
Describe alternatives you've considered
No response
Have you set this feature request's Milestone field to Future Release?

[ ] I have set this issue's milestone to Future Release

Hi, this currently isn't on our roadmap but this is an excellent feature request for us to look at given the demand for it!

Would like that too

While you wait for this feature in Visual Studio, there is an extension that makes it a little easier: Windows Subsystem for Android Barista

This is something we're working on. If you have WSA installed and Developer Mode turned on, it will automatically show up under Android Local Devices when you open a MAUI project in Visual Studio 17.8 Preview 2.

As a Flutter developer, I would appreciate it if it works in Visual Studio code independent of the project type.


How to show multidimensional data?

How to deal with multidimensional data like this:
tableData: [{
            id: "1",
            name: "Sidney Brakus",
            age: 113,
            books: [{
                    title: "Harry Potter",
                    price: "$10"
               },
               {
                    title: "Digital Fortress",
                    price: "$20"
               }]
        }, {
            id: "2",
            name: "Jovan Koepp",
            age: 33,
            books: [{
                    title: "Harry Potter",
                    price: "$10"
               },
               {
                    title: "Digital Fortress",
                    price: "$20"
               }]
        }]

Stucked from morning... Any help?

Not supported at the moment

@matfish2 Is it supported now?


Hydration error using <PrismicLink/>

Versions
"@prismicio/client": "^6.7.1",
"@prismicio/helpers": "^2.3.3",
"@prismicio/next": "^0.1.5",
"@prismicio/react": "^2.5.0",
"@prismicio/slice-simulator-react": "^0.2.2",
"next": "12.3.0",
"react": "18.2.0",

Reproduction
When using PrismicLink to render internal links it will create an a element inside an a element.
{menu.data?.links.map((menuLink, index) => (
                       <PrismicLink field={menuLink.link}>                                                    test                                                </PrismicLink>
                   ))}
What is expected?
This gives a hydration error in React 18 since an a element cant be a child of another a element. I did follow the docs and guides and I have no clue why this bug did occur in my app.

@angeloashmore Never mind! Found the issue and that is that I followed the docs and set an internal link component through the PrismicProvider like this:
    internalLinkComponent={({ href, ...props }) => (         <Link href={href}>                    </Link>       )}
This is still the way to go according to the example repo's and the documentation, but this will cause Hydration errors.

Hi @DennisKraaijeveld, thanks for the report!
The documentation should be correct unless you have the experimental.newNextLinkBehavior Next.js option enabled in `next.config.js. Details on that option are available in vercel/next.js#36436.
Do you have newNextLinkBehavior enabled in your app?
If so, you can set internalLinkComponent like the following example if you haven't already. Note that Link can be passed directly to internalLinkComponent.
// pages/_app.js

import Link from "next/link";
import { PrismicLink, PrismicProvider } from "@prismicio/react";
import { PrismicPreview } from "@prismicio/next";

export default function App({ Component, pageProps }) {
  return (
    <PrismicProvider internalLinkComponent={Link}>
      <PrismicPreview repositoryName="your-repo-name">
        <Component {...pageProps} />
      </PrismicPreview>
    </PrismicProvider>
  );
}

When Next 13 is released with newNextLinkBehavior enabled by default, we will update the documentation with a note on how to configure it for Next 12.


Suppress updates while text fields are active

It appears that, with this plugin enabled, Redmine performs a GET on the issue every ~5 seconds. If you happen to be editing a text field while this happens, characters can be 'dropped', leading to typos.
Would it be possible to suppress those GETs when a text input field is active?
I'm using the latest Redmine docker image (4.2.3) and version 0.8.0 of the plugin. No other plugins are installed.

Hi @korla-plankton
Thank you for the feedback. This GET call is performed to check if any update has been made on the issue while editing it (avoiding conflict and modification erasure)
I've found the problem causing random laggy input delay.
Into issue_dynamic_edit.js (L209) you have to remove the parameter async : false, and instead set global : false,
Second possibility is to update issue_dynamic_edit_configuration_file.js (L60) to set this option to false (as described into the README and last commit ...). It will prevent repetitive AJAX calls and conflict check while editing your issue
I will commit the fix tomorrow

If you find this plugin helpful, please take a minute to star it on Github and rate it 5 stars on http://www.redmine.org/plugins/redmine_issue_dynamic_edit thank you very much 👍

Sorry for the delayed response. Thank you for the update, the latest version is working well. And thank you for this very useful plugin!


buffer overflow vulnerability

Hi,
the sprintf function is used in several places
including here in raft_server.cxx :
        sprintf( temp_buf,
                 "peer %d: DC ID %d, %s, %s, %d\n",
                 (int)cur_srv->get_id(),
                 (int)cur_srv->get_dc_id(),
                 cur_srv->get_endpoint().c_str(),
                 cur_srv->is_learner() ? "learner" : "voting member",
                 cur_srv->get_priority() );

The echo_server in the examples folder provide a vulnerable code:

Regards

Yes, need to replace sprintf with snprintf, or just get rid of it and use stringstream instead.

https://github.com/eBay/NuRaft/pull/409


Fixed #29663 -- Fixed admin change view to redirect to changelist with view permission.

https://code.djangoproject.com/ticket/29663

Rebased to use new has_view_or_change_permission function.


Spurious failures due to ports being unavailable

Sometimes we get random failures such as the one at https://dev.azure.com/endjin-labs/Corvus.Testing/_build/results?buildId=12318&view=logs&j=ca395085-040a-526b-2ce8-bdc85f692774&s=d654deb9-056d-50a2-1717-90c08683d50a&t=c58e8551-6b20-5658-7a75-0283b3f97acb&l=137
StdErr: "Port 50239 is unavailable. Close the process using that port, or specify another port using --port [-p].

I think #428 is the root cause of this


[PL-58627]: PL 1.65.x RN

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: PL 1.65.x RN
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6737077857170d42ae2ac091--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67372e1b2072ae8c9d838eae--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67455028325c71b42d84868b--harness-developer.netlify.app


RPCs with CallSettings.Timing always fail with StatusCode=DeadlineExceeded.

The code in this test:
https://github.com/GoogleCloudPlatform/dotnet-docs-samples/compare/retryFails?expand=1
Always fails with:
Test Name:	GoogleCloudSamples.PubsubTest.TestRpcRetry
Test FullName:	GoogleCloudSamples.PubsubTest.TestRpcRetry
Test Source:	C:\Users\Jeffrey Rennie\gitrepos\dotnet-docs-samples\pubsub\api\PubsubTest.cs : line 351
Test Outcome:	Failed
Test Duration:	0:00:16.962

Result StackTrace:
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Grpc.Core.Internal.AsyncCall`2.UnaryCall(TRequest msg)
   at Grpc.Core.Calls.BlockingUnaryCall[TRequest,TResponse](CallInvocationDetails`2 call, TRequest req)
   at Grpc.Core.DefaultCallInvoker.BlockingUnaryCall[TRequest,TResponse](Method`2 method, String host, CallOptions options, TRequest request)
   at Grpc.Core.Internal.InterceptingCallInvoker.BlockingUnaryCall[TRequest,TResponse](Method`2 method, String host, CallOptions options, TRequest request)
   at Google.Pubsub.V1.Subscriber.SubscriberClient.CreateSubscription(Subscription request, CallOptions options)
   at Google.Api.Gax.ApiCallExtensions.<>c__DisplayClass0_0`3.<MapArg>b__0(A a, CallSettings callSettings)
   at Google.Api.Gax.ApiCallRetryExtensions.<>c__DisplayClass1_0`2.<WithRetry>b__0(TRequest request, CallSettings callSettings)
   at Google.Api.Gax.ApiCallExtensions.<>c__DisplayClass0_0`3.<MapArg>b__0(A a, CallSettings callSettings)
   at Google.Api.Gax.ApiCall`2.<>c__DisplayClass6_0.<Sync>b__0(CallSettings callSettings)
   at Google.Api.Gax.ApiCall`2.Call[T](TRequest request, CallSettings perCallCallSettings, Func`2 fn)
   at Google.Api.Gax.ApiCall`2.Sync(TRequest request, CallSettings perCallCallSettings)
   at Google.Pubsub.V1.SubscriberClientImpl.CreateSubscription(String name, String topic, PushConfig pushConfig, Int32 ackDeadlineSeconds, CallSettings callSettings)
   at GoogleCloudSamples.PubsubTest.RpcRetry(String topicId, String subscriptionId, PublisherClient publisher, SubscriberClient subscriber) in C:\Users\Jeffrey Rennie\gitrepos\dotnet-docs-samples\pubsub\api\PubsubTest.cs:line 228
   at GoogleCloudSamples.PubsubTest.TestRpcRetry() in C:\Users\Jeffrey Rennie\gitrepos\dotnet-docs-samples\pubsub\api\PubsubTest.cs:line 354
Result Message:	Grpc.Core.RpcException : Status(StatusCode=DeadlineExceeded, Detail="Deadline Exceeded")

One point to note in passing: if it's worth having a "maximum count of retries" we should put that in RetrySettings itself.

Another point to note: this code won't compile when we've got the new GAX running again - the settings are immutable.
But other than that, it looks like it should be okay.
Assigning @chrisdunelm to have a look... I may give this a try with the updated code to see if I can figure it out.

Looking at the code again, it's not clear what you're expecting to happen here - in particular, before this test started, did the topic exist? If not, I'd expect a failed with StatusCode=NotFound.
After creating the topic, the broadly equivalent new code worked for me - although I explicitly specified a MaxTimeout and an Expiration:
        static CallSettings CreateRetryCallSettings(int tryCount)
        {
            var backoff = new BackoffSettings(TimeSpan.FromMilliseconds(500), TimeSpan.FromMilliseconds(5000), 2);
            return CallSettings.FromCallTiming(CallTiming.FromRetry(new RetrySettings(backoff, backoff, Expiration.None,
                (RpcException e) => e.Status.StatusCode != StatusCode.AlreadyExists && --tryCount > 0,
                RetrySettings.NoJitter)));
        }

It's not clear why you'd want to retry the operation if the subscription (or topic) already exists - surely it's not going to succeed later.
My guess is that the deadline error you ran into was due to a single RPC taking more than 500ms, and so being cancelled by the client side. Hard to know for sure though.

Delay, MaxDelay, Expiration, TotalExpiration....
I can't make sense of all these parameters from the documentation.  I can't paint a mental picture of the loop and what each parameter does.

All I want to say is, "try three times."  And that is very difficult with the current API.

Rather: "try 3 times, but stop retrying if the status code is AlreadyExists."

But "try three times" doesn't express anything about how long you're prepared for each operation to take, or how long to delay between attempts, or how long you're prepared for the overall operation to take - that's what those values are about. We can definitely improve the docs, of course.
It does sound like it would be worth adding a "max # attempts" to the configuration though.

I have something that works now:
https://github.com/GoogleCloudPlatform/dotnet-docs-samples/compare/retryFails?expand=1

Can we provide default values for all those operation timeouts?

They vary by call. We provide a set of (hopefully reasonable) defaults for each specific call, so maybe the thing to do is make it easy to create a new RetrySettings with a specific number of attempts and/or filter.

Are you still able to reproduce this with the latest packages? (I don't think I ever quite got to the bottom of what the preconditions were for your sample.)

Ping for recent repro. (Unless you're blocked on #595 of course. Chris and I will add some more docs for settings.)


Choose a Python linter and formatter

Would be nice to have from the start which we can just include in the conda dependencies once Aron's branch is merged to master.
I've only used black as a formatter and I suggest we use it as well. Pylint is also a nice linter.

Should maybe also consider isort for sorting imports.


Adding FORGOT PASSWORD functionality in Sign In section.

Users often forget passwords. A "Forgot Password" option enables them to quickly reset it, making it easier to regain access without contacting support.

Already there #228


DSA 2.2.3 Monotonic functions

Description
Give an introduction and explain the working of monotonic functions in the context of binary search and bisection method.
Task

[ ] Documentation
[ ] Audio
[ ] Video

Note

While requesting the issue to be assigned, please mention your NAME & BATCH NUMBER.
Kindly refer to Issue Guidelines.
In case you see that the issue has already been assigned, try to request for a different task within the same issue.
Changes should be made inside the DSA/directory & DSA branch.
Name of the file should be same as the issue.
This issue is only for 'GWOC' contributors of 'DSA' Domain.

/assign Eshan Gupta Batch-9

/assign

\assign

Please assign me this @pjdurden

/assign

@eshan1925 Not assigned to you, I have already said don't do this.
Now I have to talk with higher authourity to take strict action regarding this

@eshan1925 Not assigned to you, I have already said don't do this.
Now I have to talk with higher authourity to take strict action regarding this

Ok dont assign...wont ask again...

@eshan1925 Not assigned to you, I have already said don't do this.
Now I have to talk with higher authourity to take strict action regarding this

Ok dont assign...wont ask again...

Thankyou @Subhradeep10

Can I work on the document part @pjdurden @Subhradeep10
Name - Jaya Dubey
Batch - 3

@jaya6400 Assigned to you, Go for it

@eshan1925 kindly dont abuse the assign bot. First submit pr for the open issues you have and then ask for new issues.

@eshan1925 kindly dont abuse the assign bot. First submit pr for the open issues you have and then ask for new issues.

Already done....i was assigned to an issue whose PR was already merged...

By the way i dont want to get assigned to this issue for now😁
Thankyou


Style/RedundantRegexpCharacterClass unintentional changes in specific case

Style/RedundantRegexpCharacterClass is problematic under in specific case:
def escape(text)
  text.gsub(/.[\b]/, '')
end

# Style/RedundantRegexpCharacterClass: Redundant single-element character class, [\b] can be replaced with \b..
but, \b [\b] behave differently.
https://docs.ruby-lang.org/en/2.7.0/Regexp.html#class-Regexp-label-Anchors

\b - Matches word boundaries when outside brackets; backspace (0x08) when inside brackets

Expected behavior
Ignore [\b] case.
Actual behavior
Change [\b] to \b.
RuboCop version
$ [bundle exec] rubocop -V
0.86.0 (using Parser <IP_ADDRESS>, rubocop-ast 0.0.3, running on ruby 2.7.1 x86_64-darwin18)

@owst Can you take a look?

Aha, I missed this difference in behaviour, apologies - I'll have a look this evening UK time 👍

thx!


techtask/Separation-of-credentials-from-endpoints

Refactored code and added unit tests

Let's introduce JUnit tests with this improvement.

Done. Code refactored and unit tests added.


Steam provider

Steam DEV page says the following:
Steam can act as an OpenID provider. This allows your application to authenticate
a user's SteamID without requiring them to enter their Steam username or password
on your site (which would be a violation of the API Terms of Use.) Just download an
OpenID library for your language and platform of choice and use
http://steamcommunity.com/openid as the provider. The returned Claimed ID will
contain the user's 64-bit SteamID. The Claimed ID format is:
http://steamcommunity.com/openid/id/<steamid>

This library is listed with OpenID certification, so I think this might work, but I can't make it happen. Steam page says something about setting the provider, but couldn't find where to configure this.
I'm trying to use the sample provided to work with Steam.

You'd have to ask Steam.


segmentation fault on app exit after resuming application when using DDB

Reproduction steps

start database backend dist/bin/actondb -p 32000 -m 34000 -s <IP_ADDRESS>:34000
run examples/count ./count 3 --rts-ddb-host localhost
stop it with ^C after it has counted beyond 0
restart count ./count 3 --rts-ddb-host localhost
count will proceed counting to 3 and should then exit...
but we get a segmentation fault, why?

Outcome
kll@Boxy:~/terastream/acton/examples$ ./count 3 --rts-ddb-host localhost
0
1
^C
kll@Boxy:~/terastream/acton/examples$ ./count 3 --rts-ddb-host localhost
2
3
Segmentation fault

Expectation
no segfault
Meta
actonc --version:
acton <IP_ADDRESS>11<IP_ADDRESS>
compiled by ghc 8.10 on linux x86_64
cc: cc (Debian 11.2.0-10) 11.2.0

Assigning to @aagapi as he is the gdb guru... maybe this falls more in the RTS / @nordlander domain, let's see...

I see this:
(lldb) run 3 --rts-ddb-replication 1 --rts-ddb-host localhost
Process 90467 launched: '/Users/kll/terastream/acton-mbp/test/count' (x86_64)
2
Assertion failed: (0), function send_packet_wait_replies_async, file backend/client_api.c, line 602.
Process 90467 stopped
* thread #3, stop reason = hit program assert
    frame #4: 0x00000001000969fb count`send_packet_wait_replies_async + 107
count`send_packet_wait_replies_async:
->  0x1000969fb <+107>: movq   -0x28(%rbp), %rax
    0x1000969ff <+111>: movq   0x8(%rax), %rax
    0x100096a03 <+115>: movq   0x8(%rax), %rax
    0x100096a07 <+119>: movq   0x10(%rax), %rax
Target 0: (count) stopped.

Pretty sure the assert here is https://github.com/actonlang/acton/blob/main/backend/client_api.c#L602 which checks that mc is not NULL

send_packet_wait_replies_async is called from:
send_packet_wait_replies_sync which is called from:
remote_enqueue_in_txn which sets mc = NULL

Is this code correct?
Trying to replicate this error I seem to be getting other failures, so maybe this isn't the one true cause but since it looks weird (or I don't understand it) I'm posting it... @aagapi comment? :)

More specifically, pretty much every other time I've run the program I am seeing something like:
(lldb) run 3 --rts-ddb-replication 1 --rts-ddb-host localhost
Process 91545 launched: '/Users/kll/terastream/acton-mbp/test/count' (x86_64)
1
2
3
Process 91545 stopped
* thread #6, stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
    frame #0: 0x00000001000022a6 count`count$$main$_work(__self__=0x0000600002c00080, c$cont=0x00000001000bf2e0) at count.c:117:24
Target 0: (count) stopped.

(lldb) bt all
  thread #1, queue = 'com.apple.main-thread'
    frame #0: 0x00007ff81f56420a libsystem_kernel.dylib`__ulock_wait + 10
    frame #1: 0x00007ff81f5a0c8d libsystem_pthread.dylib`_pthread_join + 362
    frame #2: 0x0000000100033b41 count`main(argc=6, argv=0x00007ff7bfeff8a8) at rts.c:1658:9
    frame #3: 0x000000010012d4fe dyld`start + 462
  thread #2
    frame #0: 0x00007ff81f56ae4a libsystem_kernel.dylib`__select + 10
    frame #1: 0x0000000100095479 count`comm_thread_loop + 601
    frame #2: 0x00007ff81f59f514 libsystem_pthread.dylib`_pthread_start + 125
    frame #3: 0x00007ff81f59b02f libsystem_pthread.dylib`thread_start + 15
  thread #3
    frame #0: 0x00007ff81f565506 libsystem_kernel.dylib`__psynch_cvwait + 10
    frame #1: 0x00007ff81f59fa89 libsystem_pthread.dylib`_pthread_cond_wait + 1224
    frame #2: 0x0000000100096921 count`wait_on_msg_callback + 129
    frame #3: 0x0000000100096b0b count`send_packet_wait_replies_sync + 91
    frame #4: 0x000000010009a91e count`remote_new_txn + 286
    frame #5: 0x00000001000279bd count`handle_timeout at rts.c:849:29
    frame #6: 0x0000000100025670 count`$eventloop(arg=0x0000000000000004) at minienv.c:1156:9
    frame #7: 0x00007ff81f59f514 libsystem_pthread.dylib`_pthread_start + 125
    frame #8: 0x00007ff81f59b02f libsystem_pthread.dylib`thread_start + 15
  thread #4
    frame #0: 0x00007ff81f565506 libsystem_kernel.dylib`__psynch_cvwait + 10
    frame #1: 0x00007ff81f59fa89 libsystem_pthread.dylib`_pthread_cond_wait + 1224
    frame #2: 0x000000010002a0aa count`main_loop(idx=0x0000000000000000) at rts.c:1289:13
    frame #3: 0x00007ff81f59f514 libsystem_pthread.dylib`_pthread_start + 125
    frame #4: 0x00007ff81f59b02f libsystem_pthread.dylib`thread_start + 15
  thread #5
    frame #0: 0x00007ff81f565506 libsystem_kernel.dylib`__psynch_cvwait + 10
    frame #1: 0x00007ff81f59fa89 libsystem_pthread.dylib`_pthread_cond_wait + 1224
    frame #2: 0x000000010002a0aa count`main_loop(idx=0x0000000000000001) at rts.c:1289:13
    frame #3: 0x00007ff81f59f514 libsystem_pthread.dylib`_pthread_start + 125
    frame #4: 0x00007ff81f59b02f libsystem_pthread.dylib`thread_start + 15
* thread #6, stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x00000001000022a6 count`count$$main$_work(__self__=0x0000600002c00080, c$cont=0x00000001000bf2e0) at count.c:117:24
    frame #1: 0x0000000100001a58 count`count$$l$1lambda$__call__(p$self=0x0000600000004cd0, c$cont=0x00000001000bf2e0) at count.c:8:12
    frame #2: 0x000000010002948b count`main_loop(idx=0x0000000000000002) at rts.c:1169:20
    frame #3: 0x00007ff81f59f514 libsystem_pthread.dylib`_pthread_start + 125
    frame #4: 0x00007ff81f59b02f libsystem_pthread.dylib`thread_start + 15
  thread #7
    frame #0: 0x00007ff81f565506 libsystem_kernel.dylib`__psynch_cvwait + 10
    frame #1: 0x00007ff81f59fa89 libsystem_pthread.dylib`_pthread_cond_wait + 1224
    frame #2: 0x000000010002a0aa count`main_loop(idx=0x0000000000000003) at rts.c:1289:13
    frame #3: 0x00007ff81f59f514 libsystem_pthread.dylib`_pthread_start + 125
    frame #4: 0x00007ff81f59b02f libsystem_pthread.dylib`thread_start + 15
  thread #8
    frame #0: 0x00007ff81f565506 libsystem_kernel.dylib`__psynch_cvwait + 10
    frame #1: 0x00007ff81f59fa89 libsystem_pthread.dylib`_pthread_cond_wait + 1224
    frame #2: 0x000000010002a0aa count`main_loop(idx=0x0000000000000004) at rts.c:1289:13
    frame #3: 0x00007ff81f59f514 libsystem_pthread.dylib`_pthread_start + 125
    frame #4: 0x00007ff81f59b02f libsystem_pthread.dylib`thread_start + 15

It is in the generated code so.. not sure what to think ;)

After a mob debug with @nordlander and @aagapi we've nailed this down; the env actor is never serialized and saved to the database! It is the call to env.exit() that segfaults and this is because the env actor is nil after resuming, since the env actor was never saved to the DB in the first place!


bug: Renamed krew to kubectl-krew to be accessible as kubectl plugin

Kubectl plugins must be named "kubectl-<name>"  (https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/).
In order to use krew directly without linking the binary to the needed name it was renamed to kubectl-krew.

Thanks a lot. This again show that there is some work in this area to be done so we can select multiple binaries and install them remapping the name if necessary.
In the meantime, thanks for this !


An error occurred while creating datasets: Fatal error

Envs: docker superset 1.4.1  + clickhouse
when add dataset from clickhouse, An error occurred while creating datasets: Fatal error
clickhouse database created by :  MaterializeMySQL from mysql
2022-02-27 10:53:51,412:ERROR:root:'NoneType' object has no attribute 'reflect'
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/flask_appbuilder/api/init.py", line 85, in wraps
return f(self, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/superset/views/base_api.py", line 85, in wraps
raise ex
File "/usr/local/lib/python3.8/site-packages/superset/views/base_api.py", line 82, in wraps
duration, response = time_function(f, self, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/superset/utils/core.py", line 1468, in time_function
response = func(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/superset/utils/log.py", line 242, in wrapper
value = f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/superset/datasets/api.py", line 252, in post
new_model = CreateDatasetCommand(g.user, item).run()
File "/usr/local/lib/python3.8/site-packages/superset/datasets/commands/create.py", line 46, in run
self.validate()
File "/usr/local/lib/python3.8/site-packages/superset/datasets/commands/create.py", line 86, in validate
if database and not DatasetDAO.validate_table_exists(
File "/usr/local/lib/python3.8/site-packages/superset/datasets/dao.py", line 81, in validate_table_exists
database.get_table(table_name, schema=schema)
File "/usr/local/lib/python3.8/site-packages/superset/models/core.py", line 645, in get_table
return Table(
File "", line 2, in new
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/util/deprecations.py", line 139, in warned
return fn(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/schema.py", line 563, in new
metadata.remove_table(name, schema)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/util/langhelpers.py", line 68, in exit
compat.raise(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/util/compat.py", line 182, in raise_
raise exception
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/schema.py", line 558, in new
table._init(name, metadata, *args, **kw)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/schema.py", line 647, in _init
self.autoload(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/sql/schema.py", line 670, in autoload
autoload_with.run_callable(
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 2212, in run_callable
return conn.run_callable(callable, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 1653, in run_callable
return callable(self, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/clickhouse_sqlalchemy/drivers/base.py", line 829, in reflecttable
self._reflect_engine(connection, table.name, table)
File "/usr/local/lib/python3.8/site-packages/clickhouse_sqlalchemy/drivers/base.py", line 841, in _reflect_engine
engine = engine_cls.reflect(table, **e)
AttributeError: 'NoneType' object has no attribute 'reflect'

^_^

Hey Did you solved the problem? Could I know how?

I am also facing the same problem but instead of fatal error I am getting 422 status (Unprocessable Entity).

如何解决的啊？求解决方案

How to solve it? I also encountered this problem

@balsilliy How did you solve this problem?


(WIP) Use filenames from S3 for Demos

This PR would update our CSV naming convention to use the name of the CSV on S3. I've marked it as WIP because we should consider adding a step to explicitly hunt down old file names from their csv_save_location and delete old CSVs. The current branch only downloads a new file with the new name.

Codecov Report

Merging #207 into master will decrease coverage by <.01%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   93.36%   93.36%   -0.01%
==========================================
  Files          70       70
  Lines        7743     7741       -2
==========================================
- Hits         7229     7227       -2
  Misses        514      514

Impacted Files
Coverage Δ

featuretools/demo/retail.py
100% <100%> (ø)
:arrow_up:

featuretools/tests/demo_tests/test_demo_data.py
100% <100%> (ø)
:arrow_up:

featuretools/demo/flight.py
88.37% <50%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d220e...e4d9e21. Read the comment docs.

Looks good to me


Removed: unused css rule background-repeat from the menu.css file

We have already defined no-repeat in the background css property so the background-repeat is duplicate so removed that property.

Thanks @ymaheshwari1 for your contribution!


Sample size independence

We probably want to construct plots so that patterns spotted in them are independent of the sample size. It is probably worthwhile trying the various plots out with simple simulations using sample sizes of 10, 100, 1000, 10,000, and 100,000, just to check that different patterns are not simply a feature of the sample size.

I agree, that would be very helpful. As I mentioned in the meeting, I think it would also be useful to check what happens when we introduce sequencing/phasing errors. Perhaps we could also do it with real data, e.g. from the unified genealogy paper.

I don't think we want this for the initial version. Would it make sense for SARS-Cov-2 ARGs? The intuitions here are firmly rooted in the coalescent, so could well be misleading outside of that setting.
The coal here is to present the information in the supplied tree sequence without prejudice towards any particular model or species.

Sorry, maybe I put that wrong. I don't mean sample independence under a coalescent assumption, but something much more wooly. I'm thinking, for example, of the plot of mutation times. As we take more samples, under any model (pretty much), we start finding the rarer mutations. In this case, I suggested weighting the mutation time by the number of samples in a histogram.
We can test the (relative) sample non-independence of any plots by taking a large inferred tree sequence (e.g. the sc2ts one), and randomly subsampling it. If we create a plot with the subsample, and it is radically different in conclusion from the original plot, we should think about whether there is an alternative metric of weighting that would alleviate this.
So, I think this should probably be left open, as a reminder?

I think we want to keep the plots as simple and descriptive as possible, until we find a clear example where this isn't working and being misleading.


Set browser timezone

What is the recommended way to change the WebClient's timezone?
I can change the jvm's timezone by altering the system variable, but what if I only need to alter the client, or have multiple clients running in parallel, each with its own timezone.
The use case is accessing sites that set their content based on the timezone the browser advertises or even generate and download files with different timestamps inside the data depending on the timezone.
Chrome dev tools protocol supports a way of defining this (have not tested yet, but its in the dev tools protocol).

You can create your own BrowserVersion, set the timezone and then use it for creating your webclient.
BrowserVersion ffBerlin = new BrowserVersion.BrowserVersionBuilder(BrowserVersion.FIREFOX)
                                            .setSystemTimezone(TimeZone.getTimeZone("Europe/Berlin"))
                                            .build();

But i fear there are not that many methods using this. Please open issues for all the places you find that are ignoring this info.

So thats how you use the builder, could you add mention of this option in your documentation?
You have a few examples on how to set an attachment handler or toggle javascript, it could be listed there as an option too.

@skyhirider updating the docu is always a good point.
Maybe you can have a look at https://www.htmlunit.org/webclient.html#Imitating_a_specific_browser, hopefully this is a bit better now.

Thanks for updating the docs!
It mentions us always being default. How do the other browsers do it, isn't it OS specific?
You could query the JVM to get the timezone and language.
Thou could be a breaking change if people are used to English.

For real browsers this is OS Specific (or depending on a setting of the TZ var for the current session.
For Chrome/Edge there is a way to change the timezone using the dev api.
As HtmlUnit is (also) for testing i think it should be possible to simulate every timezone/locale you like to test. Therefore there was the decision (long long ago) to always start with a fixed setting and allow to change that if needed.
At the moment this is something that has to be done before starting the WebClient but maybe there is no good reason for this. Will have a look - maybe we can move this to the options to make it simpler for the user to change.

After a bit more thinking....
I like to stay with the current way - it is not really possible to change the locale of a browser at runtime and i think it makes also no real sense to change these setting of a running HtmlUnit WebClient. I guess every test case starts with a fresh browser and does not change the locale/language during the test session.

I can see your point, what I meant was HtmlUnit taking on the timezone and local of the jvm when its initially launched, thou that would be a breaking change and not sure either if its a good idea or not.
Not being able to change it during runtime makes sense, thou if there was a use case when a quick switch was needed the whole driver would need to be re-loaded and initialized instead of a simple switch.
Thou having the driver immutable is logical.
For me personally, its enough to know this can be done and how (thank you for updating your documentation!).
Was surprised it was not with the rest of the webclient options, but works just a well with the browser settings.

Have added some more words, hope this is sufficient now.
Thanks for pointing at this.


Setting ODWCommonDataContext on ODWPrivacyGuardInitConfig crashes

Describe your environment.
Crash is happening on iOS, both device and simulator.
Steps to reproduce.
This code is able to reproduce the crash on the last line:
let pgInitConfig = ODWPrivacyGuardInitConfig()
pgInitConfig.scanForUrls = false
pgInitConfig.useEventFieldPrefix = true
pgInitConfig.dataContext = ODWCommonDataContext()  //Crash here.

What is the expected behavior?
pgInitConfig.dataContext set correctly.
What is the actual behavior?

The issue potentially lies with @property(readwrite, copy, nonatomic) ODWCommonDataContext* dataContext;. This property should be assign instead of readwrite.

copy attribute in ODWPrivacyGuardInitConfig needs to be removed. Sending a PR for this shortly.


[Bug] ProtocolSecurityWrapper WIP

Pre-check

[X] I am sure that all the content I provide is in English.

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache Dubbo Component
Java SDK (apache/dubbo)
Dubbo Version
Dubbo 3.2.6 linux: Linux 5.15.80
i check code in branch 3.3
Steps to reproduce this issue
deploy a dubbo reference with 2000 providers for test .
It is a 10s addition time cost when i try to update config 'timeout' in client.
these provider url when i use new code in 3.2.6  zookeeperRegistry used and last version of code.
// old code
URL url = URL.valueOf(providerUrl)
// new code
URL url = new DubboServiceAddressURL(rawProvider.getUrlAddress(), rawProvider.getUrlParam(), copyOfConsumer, overrideUrl))

There are some reflection operation and do not be cached .
it is ok in export but refer process this cost will be long when 'proverider size'  and 'methods length' grow
//  org.apache.dubbo.common.utils.SerializeSecurityConfigurator#registerInterface
 if (!autoTrustSerializeClass) {
            return;
        }

        Set<Type> markedClass = new HashSet<>();
        checkClass(markedClass, clazz);

        addToAllow(clazz.getName());

        Method[] methodsToExport = clazz.getMethods();

        for (Method method : methodsToExport) {
            Class<?>[] parameterTypes = method.getParameterTypes();
            for (Class<?> parameterType : parameterTypes) {
                checkClass(markedClass, parameterType);
            }

i want to know is it necessary to be fixed？
and if i work on it should it is will to use existed service cache in dubbo like ‘watch org.apache.dubbo.rpc.model.ReflectionServiceDescriptor '
or some dependency like  org.springframework.util.ReflectionUtils.
What you expected to happen
there are 2000 instance in registry。
when i change timeout config in config center。
client do refrer all client to repalace this url。
expected to happen ： urls update in 10s when netty client do not changed
actual : it takes more than 20 milites to update url
in my machine it take 5ms * 2000 times to process SerializeSecurityConfigurator addition
Anything else
No response
Are you willing to submit a pull request to fix on your own?

[X] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

We may can use cache here. ReflectionServiceDescriptor might be not detailed enough for security check.


add side menu to use page

Is there a way to preview?

@eddelbuettel Yes, I think you should be able to preview by clicking on the "Details" tab above where it says "All checks have passed" (the check is the preview-deploy success state for netlify).  It's possible I may need to add you to the netlify deploy first??

You may have too.  I see no link.  But I trust you on this and other issues :)

ok, lemme know if you can see the preview here: https://deploy-preview-2--rocker.netlify.com/

I see, when I'm logged in I get one of those "All checks have passed" boxes like you see from Travis-CI on pull requests, and it just gives me that deploy URL.  I've added you to the admin list on netlify, though not sure if that will generate the preview urls for you.
Anyway, I'll go ahead and merge, this is all a bit of a work in progress anyway and this is a small edit.


Cudnn failed to initialize

Hello, thanks for sharing this code.
I tried to run the demo but I failed building the environment. I use the docker as tensorflow doesn't match but I still have some issues. I used python 3.5 (because of the docker), Cuda 11.0 and Cudnn 10.2.
It is the first time I use docker and Cudnn and I'm not sure how to proceed to install the versions of CUDA and Cudnn you used to run the project.
The error message is the following one.
W0816 09:34:40.781714<PHONE_NUMBER>92320 deprecation_wrapper.py:119] From HDNet_Inference.py:15: The name tf.logging.set_verbosity is deprecated. Please use tf.compat.v1.logging.set_verbosity instead.

W0816 09:34:40.781880<PHONE_NUMBER>92320 deprecation_wrapper.py:119] From HDNet_Inference.py:15: The name tf.logging.ERROR is deprecated. Please use tf.compat.v1.logging.ERROR instead.

------------------------------
Hourglass Architecture
------------------------------
------------------------------
Hourglass Architecture
------------------------------
Model DR restored.
Model NP restored.
Processing file:  0043
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1356, in _do_call
    return fn(*args)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1341, in _run_fn
    options, feed_dict, fetch_list, target_list, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1429, in _call_tf_sessionrun
    run_metadata)
tensorflow.python.framework.errors_impl.UnknownError: 2 root error(s) found.
  (0) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
	 [[{{node hourglass_normal_prediction/conv1/Conv2D}}]]
  (1) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
	 [[{{node hourglass_normal_prediction/conv1/Conv2D}}]]
	 [[hourglass_normal_prediction/conv18/BiasAdd/_177]]
0 successful operations.
0 derived errors ignored.

Thanks in advance.

Hi. If you want to use docker, you may want to get the tensorflow-docker image from here.
If you already have docker installed you can just follow and run this
Note that you don't need to do anything else if you use this environment. Just install requirements.txt after that.
If you don't want to use docker, the code is tested under this cuda, cudnn and tensorflow that is mentioned.
Please read the readme file carefully to follow the installation correctly.

I read it carefully and I tried to use it with docker, the error appears while I use docker. I though that I had to install Cudnn in docker because of the error bellow and that's what I did but it is still not working, the error is exactly the same. (Obviously I installed the requirements in docker)
´´´(0) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.´

Thanks for reaching out.
This docker image already has the cudnn and cuda installed. You can see the available libraries coming with this container here. This is an example of how the code runs in the container:

However, If there are still problems with the installation, I have added the google colab notebook as well that you can check out.


V 0.13 posted

In the controllers section, size of the lists are hard-coded and don't scroll up/down to view more rows.

After entering my info in peers all I get is a.spinning ring when trying to view probes and outlets using rooted kindle fire.

Peers =prefs

same thing as waverz.  However, if I hit the refresh from the main screen I get:
"Sync error: Unexpected server response HTTP/1.1 401 Unauthorized GET response from http://myaddy.com/cgi-bin/status.xml HTTP/1.1"

Different results on both v2.2 and v2.3.6  for version v0.13 (I have 2 controllers installed on both phones)
V2.3.6 results;
Under controllers;
Apex shows some probes; 4 of 7, and some outlets; 3 of 60+ as well as “fix this”
AC3 shows the one probe and “fix this” for outlet
Under outlets;
Apex shows the first 4 of 60+ outlets
AC3  none are present
Under probes;
Apex show the first 3 of 7
AC3 show the one probe it has
V2.2 results;
Under controllers;
Apex shows some scrolling wheel under probes, indicating It is loading, it never loads; it shows “fix this” under outlets
AC3 shows the one probe and “fix this” for outlet
Under outlets;
Apex none are present - scrolling wheel is present indicating It is loading, it never loads
AC3  none are present
Under probes;
Apex none are present
AC3 show the one probe it has

After and uninstall/reinstall on the v2.2 phone it acts almost identical to the 2.3.3 phone.  The only notable difference is the AC3 probe which shows up under controller->probe, does not show up under probes icon.
One other note,  if I select controller->outlet then touch any outlet I get a force close on both phones.  I do not get a force close at any other screen or action.


Unexpected Behavior with SlackOAuthApp's stateStore, onStateValidationError, and callback Functions

I have been using the stateStore setting in SlackOAuthApp and noticed some surprising behavior.
When the consume function returns false, I would expect the onStateValidationError function in the oauth options to get executed, which does occur as expected.
However, the process seems to proceed further than anticipated, and the callback function in the oauth options gets executed as well. Is this the intended behavior or could this possibly be a bug?

@abc123931 Thanks for reporting this and sorry that you ran into the silly bug 🤦
I just resolved it and shipped a new pathc version including the change. Note that the fix might miss something because I didn't have time to do manual tests now. Pleaset let me know if the issue still remains.


ShipStation

Trying to set up Shipstation, you know any way to link that to this shopping cart?

Is this something that is possible?

What specific features of Shipstation do you want to utilize with Community Store? Do you only need to send orders to Shipstation, or integrate beyond that?

I get the impression from a quick look that Shipstation is a bit like Easypost, in that it's a shipping aggregator.
I'd say it's another case of having to write a custom shipping method, very similar to the Easypost one, where it hooks into their API.

I believe you are correct.
I will check out Easypost, maybe that will do what we want already, but if not, what all would you need to quote this?

It's going to be about listing the features of ShipStation you'd want to use and describing a typical process. You could either put this out onto the jobs forum, or contact those that have worked on community store directly.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_8230p7goib/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_8230p7goib/clone/recipe/meta.yaml:22: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_8230p7goib/clone/recipe/meta.yaml:25: python_build_tool_in_run: The python build tool setuptools is in run depends
ERROR: /tmp/abs_8230p7goib/clone/recipe/meta.yaml:42: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, reference https://spdx.org/licenses/
ERROR: /tmp/abs_8230p7goib/clone/recipe/meta.yaml:45: missing_dev_url: The recipe is missing a dev_url
WARNING: /tmp/abs_8230p7goib/clone/recipe/meta.yaml:45: missing_description: The recipe is missing a description
ERROR: /tmp/abs_8230p7goib/clone/recipe/meta.yaml:45: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_8230p7goib/clone/recipe/meta.yaml:45: http_url: http://blockdiag.com/ is not https
ERROR: /tmp/abs_8230p7goib/clone/recipe/meta.yaml:45: missing_documentation: The recipe is missing a doc_url or doc_source_url
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_e7h1xj4i0q/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_e7h1xj4i0q/clone/recipe/meta.yaml:22: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_e7h1xj4i0q/clone/recipe/meta.yaml:25: python_build_tool_in_run: The python build tool setuptools is in run depends
ERROR: /tmp/abs_e7h1xj4i0q/clone/recipe/meta.yaml:42: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, reference https://spdx.org/licenses/
ERROR: /tmp/abs_e7h1xj4i0q/clone/recipe/meta.yaml:45: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_e7h1xj4i0q/clone/recipe/meta.yaml:45: missing_description: The recipe is missing a description
ERROR: /tmp/abs_e7h1xj4i0q/clone/recipe/meta.yaml:45: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_e7h1xj4i0q/clone/recipe/meta.yaml:45: http_url: http://blockdiag.com/ is not https
ERROR: /tmp/abs_e7h1xj4i0q/clone/recipe/meta.yaml:45: missing_license_family: The recipe is missing the about/license_family key.
Errors were found