Remove unused params in examples.json and add Readme to API strategy

Changes proposed in this pull request:

Remove the symbol and decimal parameters from example.json. This was probably copied from erc20 strategy but it's not used at all for the api strategy.
Add a readme to explain how the api strategy is used.

Verified the api strategy passes all tests

@ChaituVR , seems like i've been testing the strategy incorrectly, I was using --strategy:api instead of --strategy=api.
Now that I'm actually testing the API strategy, it seems to be failing. Am I missing something, or has this been broken for a while?
Here's the URL that it's hitting: https://gateway.pinata.cloud/ipfs/QmQnW3TtpN8WS2YMXtWB1p7DFcVjetfZmMfJvXm5yAZ6QN
Here's the output:
c:\code\snapshot-strategies\src\strategies\api>git branch
* master

c:\code\snapshot-strategies\src\strategies\api>git log
commit 7d706f7826a2a69d3d5c9e251cf2cd8c19a60715 (HEAD -> master, origin/master, origin/HEAD)
Author: renovate[bot]<EMAIL_ADDRESS>Date:   Fri Feb 3 01:07:24 2023 +0530

    fix(deps): update dependency @snapshot-labs/snapshot.js to ^0.4.61 (#1040)

    Co-authored-by: renovate[bot]<EMAIL_ADDRESS>
    c:\code\snapshot-strategies\src\strategies\api>npm run test --strategy=api

><EMAIL_ADDRESS>test
> jest -i strategy.test.ts

 FAIL  test/strategy.test.ts (19.59 s)

Test strategy "api" with example index 0
    √ Strategy name should be lowercase and should not contain any special char expect hyphen (2 ms)
    √ Strategy name should be same as in examples.json
    √ Addresses in example should be minimum 3 and maximum 20 (1 ms)
    √ Must use a snapshot block number in the past (229 ms)
    × Strategy should run without any errors (177 ms)
    × Should return an array of object with addresses (2 ms)
    × Should take less than 10 sec. to resolve (1 ms)
    × File examples.json should include at least 1 address with a positive score
    × Returned addresses should be checksum addresses
    × Voting power should not depend on other addresses (86 ms)

Test strategy "api" with example index 0 (latest snapshot)
    × Strategy should run without any errors (128 ms)
    × Should return an array of object with addresses (1 ms)

Test strategy "api" with example index 0 (with 500 addresses)
    ○ skipped Should work with 500 addresses
    ○ skipped Should take less than 20 sec. to resolve with 500 addresses

Other tests with example index 0
    ○ skipped Check schema (if available) is valid with examples.json
    ○ skipped Strategy should work even when strategy symbol is null

Others:
    √ Author in strategy should be a valid github username (297 ms)
    √ Version in strategy should be a valid string

@ChaituVR , So I think this strategy's example.json has been broken for a while. I've uploaded my own json to IPFS and updated the example to match it. https://gateway.pinata.cloud/ipfs/QmbmhTivxYuLE5uhNEALoBmvP7Yg9acA2Lkw9V9PqaEmw6
Here's the current experience:
c:\code\snapshot\snapshot-strategies\src\strategies\api>git branch
  master
* ori/updateApiStrategy

c:\code\snapshot\snapshot-strategies\src\strategies\api>git log -n 1
commit 432c005de53272699297c1b78de076d733267353 (HEAD -> ori/updateApiStrategy, origin/ori/updateApiStrategy)
Author: ori-wagmi<EMAIL_ADDRESS>Date:   Thu Feb 2 14:25:35 2023 -0800

    make decimals optional, update example.json to working IPFS endpoing

c:\code\snapshot\snapshot-strategies\src\strategies\api>npm run test --strategy=api

><EMAIL_ADDRESS>test
> jest -i strategy.test.ts

  console.log
    [
      {
        '0xeD2bcC3104Da5F5f8fA988D6e9fAFd74Ae62f319':<PHONE_NUMBER>00000000000,
        '0x3c4B8C52Ed4c29eE402D9c91FfAe1Db2BAdd228D': 7.469258545106344e+24,
        '0xd649bACfF66f1C85618c5376ee4F38e43eE53b63':<PHONE_NUMBER>801245,
        '0x726022a9fe1322fA9590FB244b8164936bB00489': 2.1798961394615612e+21,
        '0x6eF2376fA6e12Dabb3a3ED0Fb44E4ff29847Af68': 100420
      }
    ]

      at Object.<anonymous> (test/strategy.test.ts:74:15)

  console.log
    Resolved in 0.17 sec.

      at Object.<anonymous> (test/strategy.test.ts:75:15)

  console.log
    Scores with latest snapshot [
      {
        '0xeD2bcC3104Da5F5f8fA988D6e9fAFd74Ae62f319':<PHONE_NUMBER>00000000000,
        '0x3c4B8C52Ed4c29eE402D9c91FfAe1Db2BAdd228D': 7.469258545106344e+24,
        '0xd649bACfF66f1C85618c5376ee4F38e43eE53b63':<PHONE_NUMBER>801245,
        '0x726022a9fe1322fA9590FB244b8164936bB00489': 2.1798961394615612e+21,
        '0x6eF2376fA6e12Dabb3a3ED0Fb44E4ff29847Af68': 100420
      }
    ]

      at Object.<anonymous> (test/strategy.test.ts:160:15)

  console.log
    Resolved in 0.07 sec.

      at Object.<anonymous> (test/strategy.test.ts:161:15)

 PASS  test/strategy.test.ts (22.628 s)

Test strategy "api" with example index 0
    √ Strategy name should be lowercase and should not contain any special char expect hyphen (3 ms)
    √ Strategy name should be same as in examples.json (1 ms)
    √ Addresses in example should be minimum 3 and maximum 20 (1 ms)
    √ Must use a snapshot block number in the past (396 ms)
    √ Strategy should run without any errors (224 ms)
    √ Should return an array of object with addresses (1 ms)
    √ Should take less than 10 sec. to resolve
    √ File examples.json should include at least 1 address with a positive score
    √ Returned addresses should be checksum addresses (2 ms)
    √ Voting power should not depend on other addresses (104 ms)

Test strategy "api" with example index 0 (latest snapshot)
    √ Strategy should run without any errors (576 ms)
    √ Should return an array of object with addresses (1 ms)

Test strategy "api" with example index 0 (with 500 addresses)
    ○ skipped Should work with 500 addresses
    ○ skipped Should take less than 20 sec. to resolve with 500 addresses

Other tests with example index 0
    ○ skipped Check schema (if available) is valid with examples.json
    ○ skipped Strategy should work even when strategy symbol is null

Others:
    √ Author in strategy should be a valid github username (287 ms)
    √ Version in strategy should be a valid string

Test Suites: 1 passed, 1 total
Tests:       4 skipped, 14 passed, 18 total
Snapshots:   0 total
Time:        23.633 s
Ran all test suites matching /strategy.test.ts/i.


Fixed some small changes in the language file

I have fixed some incorrect sentences, and translated a few who was still in English.

Why did you close this?

Why did you close this?

I was trying to make another fork of the project, until I saw that you only could make one fork per account. Because I'm running my instance of Umami via a fork of this repo. Therefore i was afraid that it would make my instance not work... So I closed the pull request until I found another way of doing it.


8312.7 Check that core services aren't being re-initialized

Shippable/pm#8312
The logic should already be in place. Verify that, when /api/initialize is called, the vault, rabbit, gitlab, and redis POST routes aren't being called if they are already initialized (as determined by the result of the GET call).

verified by repeatedly clicking intiailzie in the UI. the post DB does a lot of stuff each time (create dirs, run migrations, brings up fake api), but the other services are skipped after doing a GET to check the database flags.


Refactor script samples to expose them in Microsoft solution gallery. Closes #4168

Refactor script samples to expose them in Microsoft solution gallery
The aim of this PR is to refactor the structure of each script sample so that each sample will have its own sample.json file with metadata to make them ready to be exposed in Microsoft solution gallery page. At the same time it is very important that this change will have no impact in the script sample URL on the CLI docs page so that we are sure we don't break any existing links.
👉 Important
This change has to be merged at the same time as changes done in script-sample repo so that we coordinate removing them from script-sample repo and exposing them from CLI repo on the same day
🧪 Best way to check the PR is
to build the mkdocs locally and recheck every script sample page if works properly and if its URL is the same as the one on the original site
🤔 Open point
Also before we merge we need to decide (together with @pkbullock how we will change the titles of the scripts which already have PnP PowerShell version in script-sample repo and will be also visible in solution gallery with the same name as CLI sample. I suggest we add prefix "CLI for Microsoft 365 - ... ".
Linked Issue
Closes #4168
Linked to https://github.com/pnp/script-samples/issues/398

@pkbullock the PR is ready to make the needed refactoring in CLI repo for making the samples visible in solution gallery.
Please feel free to jump into the review and let me know of your feedback 👍

Hi @Adam-it
Looking at the sample.json file the URL for the sample is the repo url, not the url of the generated site sample section.
Is this intended?

Hi @Adam-it
Looking at the sample.json file the URL for the sample is the repo url, not the url of the generated site sample section.
Is this intended?

good comment. That is the same way we move the initial sample for test but I do agree pointing at the docs page not the file coming from github would be a better approach 👍
I will refactor that

@pkbullock thank you for your feedback. I updated the urls

Strong work @Adam-it! 💪

For the preview images, maybe it's an idea to work with the updated version we've been using lately. Eg. https://github.com/pnp/blog/blob/main/content/cli-for-microsoft-365/cli-for-microsoft-365-v6-0/images/banner-cli-m365.png

Will do

For the preview images, maybe it's an idea to work with the updated version we've been using lately. Eg. https://github.com/pnp/blog/blob/main/content/cli-for-microsoft-365/cli-for-microsoft-365-v6-0/images/banner-cli-m365.png

done ✅

@pnp/cli-for-microsoft-365-maintainers lets decide what should be the prefix to add in titles for the samples which will have duplicates written in PnP PowerShell that will be synced to the solution gallery from script sample repo.
@pkbullock the PR is almost ready. Do you have any date you would like to make the 'switch' and sync our PRs?

I think CLI -  is a clear prefix. I've got no arbitrary date that we should aim at. Let's get it merged when ready. Awesome work folks 👏

ok @pkbullock I will do my best to add the prefix and merge this PR today 👍. Thanks for you awesome work and help along the way 👍.
you rock 🤩

merged manually


Write a C# program to print multiplication table

Description
Write a C# program to print multiplication table
Input  : 2

2 x 1 = 2
2 x 2 = 4
2 x 3 = 6
2 x 4 = 8
2 x 5 = 10
2 x 6 = 12
2 x 7 = 14
2 x 8 = 16
2 x 9 = 18
2 x 10 = 20

How to contribute

Save the solution in PrintMultiplicationTable.cs file
Add PrintMultiplicationTable.cs file in print-multiplication-table folder

!assign


ng-transition

I was thinking of creating an sm-transition for a merge request.  Any guidance on how you think this should be implemented?

So I think I'll just follow the sm-dimmer example and pass in types of transitions as options.


New version: ApproxFunOrthogonalPolynomials v0.6.28

Registering package: ApproxFunOrthogonalPolynomials
Repository: https://github.com/JuliaApproximation/ApproxFunOrthogonalPolynomials.jl
Created by: @jishnub
Version: v0.6.28
Commit: d169c6ac0d0940ee3d960bb9f6ad5269885f54ff
Reviewed by: @jishnub
Reference: https://github.com/JuliaApproximation/ApproxFunOrthogonalPolynomials.jl/commit/d169c6ac0d0940ee3d960bb9f6ad5269885f54ff#commitcomment-111184300
Description: Support for orthogonal polynomial-based spaces in ApproxFun

don't merge yet


colon is display as a flying trashcan on MacOs

What did you expect to happen?
to display :
What actually happened?
a trashcan is display in its place:

Additional details:

my config: https://github.com/shackra/emacs/blob/master/config.org

System information:
SYSTEM  type       darwin
        config     x86_64-apple-darwin19.5.0
        shell      /bin/zsh
        uname      Darwin 19.6.0 Darwin Kernel Version 19.6.0: Mon Aug 31 22:12:52 PDT 2020; root:xnu-6153.141.2~1/RELEASE_X86_64 x86_64
        path       (~/.emacs.d/bin/ ~/.cask/bin ~/.gem/ruby/2.4.0/bin ~/.gem/ruby/2.6.0/bin ~/.emacs.d/bin ~/.local/bin ~/opt/prey-node-client/bin ~/.node_modules/bin ~/go/bin ~/go ~/protoc/bin /usr/local/bin /usr/bin /bin /usr/sbin /sbin /usr/local/opt/node@14/bin /Library/Apple/usr/bin ~/.zplug/bin<EMAIL_ADDRESS>EMACS   dir        ~/.emacs.d/
        version    27.1
        build      Nov 14, 2020
        buildopts  --disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp<EMAIL_ADDRESS><EMAIL_ADDRESS>--with-xml2 --with-gnutls --without-dbus --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained
        features   RSVG IMAGEMAGICK GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS JSON PDUMPER LCMS2 GMP
        traits     (gui server-running envvar-file)
DOOM    dir        ~/.doom.d/
        version    2.0.9
        font       #<font-spec nil nil Fira Code nil nil nil nil nil 15 nil nil nil nil>
        theme      doom-gruvbox
        build      grafted, HEAD -> develop, origin/develop, origin/HEAD 2ad1eab 2021-01-18 19:59:18 -0500
        elc-files  0
        modules    (:completion (company +childframe) (ivy +childframe +prescient +icons) :ui doom doom-dashboard doom-quit hl-todo hydra (ligatures +fira +extra) modeline nav-flash ophints (popup +defaults) treemacs unicode vc-gutter vi-tilde-fringe window-select workspaces :editor file-templates fold (format +onsave) lispy multiple-cursors snippets :emacs dired electric undo vc :term vterm :checkers syntax (spell +flyspell) grammar :tools (eval +overlay) lookup (lsp +peek) magit pdf :os macos :lang data (dart +flutter) emacs-lisp (gdscript +lsp) (go +lsp) json (javascript +lsp) (latex +lsp) markdown (org +dragndrop +pretty) (python +lsp) (rust +lsp) (sh +lsp) (web +lsp) yaml :config literate (default +bindings +smartparens))
        packages   ((reformatter))
        unpin      (n/a)
        elpa       (n/a)

Probably related to doom-font and doom-big-font in your config. Maybe try removing this setq?

Probably related to doom-font and doom-big-font in your config. Maybe try removing this setq?

I had this issue using the Fira Code font with ligatures before (which appears to be your case). You need to get a version of the font patched for symbols IIRC.

I had this issue using the Fira Code font with ligatures before (which appears to be your case). You need to get a version of the font patched for symbols IIRC.

Probably related to doom-font and doom-big-font in your config. Maybe try removing this setq?

how then do I set the font I want to use or is this done automagically done by Doom?

Probably related to doom-font and doom-big-font in your config. Maybe try removing this setq?

how then do I set the font I want to use or is this done automagically done by Doom?

Probably related to doom-font and doom-big-font in your config. Maybe try removing this setq?

did that, didn't work 🤔

Probably related to doom-font and doom-big-font in your config. Maybe try removing this setq?

did that, didn't work 🤔

I had this issue using the Fira Code font with ligatures before (which appears to be your case). You need to get a version of the font patched for symbols IIRC.
EDIT: found it.
(alternatively, you can also try using Emacs 28/HEAD, which has proper ligature support through Harfbuzz)

Installing the font on that linked issue addressed the issue. Leaving (or removing, for that matter) my setq for doom-font and doom-big-font did nothing to produce the bug.

I had this issue using the Fira Code font with ligatures before (which appears to be your case). You need to get a version of the font patched for symbols IIRC.
EDIT: found it.
(alternatively, you can also try using Emacs 28/HEAD, which has proper ligature support through Harfbuzz)

Installing the font on that linked issue addressed the issue. Leaving (or removing, for that matter) my setq for doom-font and doom-big-font did nothing to produce the bug.


manager.js performs unsafe iterations without hasOwnProperty

In several places in manager.js loops like this are performed:
for(var key in obj) {
var val = obj[key];
}
This isn't very safe as if anyone has modified the Object prototype with additional items, socket.io fails.
It's pretty standard practice to add a check:
if(!obj.hasOwnProperty(key)) { continue; }
Yes, I know that people shouldn't be modifying the Object prototype, but it does happen and socket.io should be coded robust enough to work in these situations.
I'm sure there are probably several other places in socket.io code other than manager.js where unsafe access is taking place.

It can be issue on client-side, because sio-client can't be sure, whether site-scripts doesn't use extention of Object prototype. But on server-side, it's not an issue.

cris, I agree that it is much more of an issue client side, but I disagree that it's not an issue on the server side.
I have personally witnessed server side node.js code that extends the Object prototype with a .values() method to go along with the .keys() method.
This then breaks socket.io badly.
I'd be glad to submit a simple pull request with the proper property checks, but I'm not sure if it would be accepted.

@Sembiance a pull request for this would be more than welcome in my opinion. As it's still possible for third party modules to extend the prototypes of build in Objects, which could create undesired results here.

Ok, I've made the necessary code changes.
Tested it locally, before my changes socket.io fails with Object prototype modifications. After my changes, socket.io works fine.
Pull request is ready for merge.

IMO if you're adding enumerable stuff to Object.prototype you're kinda asking for it, being paranoid is a slippery slope, next we'll be freeze() and seal()ing things haha :p

I would agree that replacing undefined or hasOwnProperty is crazy and not something to protect code against :)
But adding new things to the Object prototype does happen and will continue to happen (even on the server).
For example, Object.keys() is a very useful method, but only exists in JavaScript 1.8.5
v8 added this method in Feb 2011, but before then if you wanted to use it in Node you needed to add it to the prototype yourself (https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Object/keys#Compatiblity)
A JavaScript programmer should already be used to adding hasOwnProperty checks on client side code where it is almost required you do so due to the wild wild west nature of client side libraries.
But Node is surging in popularity and a lot more wild-wild-west client side programmers will be coding node as time goes on :)
It should be second nature to always use it when iterating over objects, and with some code being sharable between client and server, one should just always check hasOwnProperty when enumerating objects.
The cost is so very little to do so and the benefit is a more robust module as Node continues to evolve.
Anyways, those are my thoughts on the matter :)


Add support of Json5

It would be great to extend Json.NET to support Json5 as well as standard json. There is a .NET
library on GitHub, but it does not have many features that Json.NET can offer:
https://github.com/json5/json5-dotnet

Json.NET already supports most of Json5, especially the parts people care about: comments and trailing commas.
There is no reason someone couldn't create a NuGet package with an implementation of JsonReader that has full support for Json5, i.e. Json5TextReader. I don't have time to write it.

Thanks @JamesNK! I didn't realise that it already partially supports json5, I will check this out and try to implement missing json5 features myself.
Would you consider it a good idea to mention supported html5 features in documentation?

Json.NET already supports most of Json5, especially the parts people care about: comments and trailing commas.
There is no reason someone couldn't create a NuGet package with an implementation of JsonReader that has full support for Json5, i.e. Json5TextReader. I don't have time to write it.

No reason

Maintenance. They'll likely update it and leave it to die.


[Relay] Fix CUDA batchmatmul strategy to allow mixed precision

In the past, mixed precision workloads for cuda-batchmatmul were removed for some reason. This allows this to occur. Honestly don't know why its this way but we need this for https://github.com/apache/tvm/pull/9186

Superseded by https://github.com/apache/tvm/pull/9186


How to build this?

I don't see any build instructions. How can I build for Linux?

I've added it, you can check here:
https://github.com/jpcima/spectacle#build-instructions

This can be closed.


CSS Changes to clean up blog

Hi team!
I have added some CSS that is only specific to blog posts. I am hoping that it will clean things up a lot.
I tried running this locally, but our current instructions are not great. I would appreciate being able to see a dev/stage version if that is possible. What would you guys recommend?

I renamed the config.toml file to hugo.toml based on the recommendation here: https://gohugo.io/getting-started/configuration/#hugotoml-vs-configtoml

We may want to adjust the date depending on when you do the next release.

I went a bit overboard and did a small rework of the entire blog post css, changes made:

Fix backtick indentation
Lighten inline code styling (similar to your change, but keeps white text instead of switching to black text)

Make all inline code styling the same

reformat SCSS file
Make a lot of pieces have the same border radius (4px)
Removed html rendering as a css only solution seems to work
Make the blog "list" page and each article share the same css to avoid inconsistencies
Made the links on the blog list page the same blueish colour that we use inside the blog post. (Might be controversial, want some feedback on what people think about this)
Use the "native" code rendering theme, seems to match pretty well with out site theme: https://xyproto.github.io/splash/docs/longer/native.html
Indent code with tabs, set tab width to 2 spaces
Fix mobile scaling/responsive design

Some screenshots and videos:

Screencast from 2023-07-21 12-53-25.webm


Will JSForce support Lightning Component usage?

I tried to refactor an existing JSForce / Visualforce application I have to work in Lightning components.  Most of the refactoring was pretty straight-forward, until I get to the actual callouts.  Then, I get an error: "Refused to connect to xxxx because it violates the following Content Security Policy directive: "connect-src 'self'". It looks like it can't connect to the proxy service ( I have proxyUrl: '/services/proxy' set in Connection).
Any thoughts?

Unfortunately lightning component does not allow to invoke API endpoint from component JavaScript. Additionally, there's no proxy endpoint available in the lightning domain. You need to prepare a Apex class that proxies API request as written here, but JSforce is not supporting it currently.

Well, that is a shame.  Lightning seems like the perfect use case for the
JSForce libraries. Hopefully, they will come out with a proxy, or, will at
least allow callouts to their own domain (salesforce's) APIs.
Thanks for the response!

Is it still not possible to use JsForce even with Content Security Policy Trusted Sites?


Decouple az_log_classifications

Currently, all az_log_classifications, for all modules, are the elements of the same enum, and have to live in one header file.
We should typedef int32 az_log_classification instead, and move IoT classification to IoT header, and so on.

Ahson already created an issue to track this: #1190


docs: Update SSG documentation to run build instead of preview

Overview
This PR aims to correct the documentation for SSG, specifically to suggest running build instead of preview.
What is it?

[ ] Feature / enhancement
[ ] Bug
[X] Docs / tests / types / typos

Description
This PR updates the SSG documentation to replace the recommendation of using the preview command with the build command for generating static pages. This change is important to highlight because the preview command currently does not generate any HTML static files, whereas the build command does. This ensures developers are fully aware of what each command will yield.
Use cases and why

Clarity: The documentation should accurately guide the developer in generating static pages, which is achieved by using build.
Avoiding Confusion: Mentioning that preview does not generate HTML static files clarifies its limitations.

Checklist:

[X] My code follows the developer guidelines of this project
[X] I have performed a self-review of my own code
[X] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Would it not be better to have preview generate the SSG pages instead?

Would it not be better to have preview generate the SSG pages instead?

I'm on the same page with you; having the preview command generate SSG pages would be ideal. I've already brought up this issue on Discord, and @mhevery suggested updating the documentation for now (Discord conversation link).
Additionally, when I attempted to remove the --ssr flag from the preview command in package.json, it resulted in the following error:
Could not resolve entry module "src/entry.preview.tsx/index.html".
error during build:
RollupError: Could not resolve entry module "src/entry.preview.tsx/index.html".
    at error (file:///Users/issambousfiha/Projects/qwik-app/node_modules/rollup/dist/es/shared/node-entry.js:2287:30)
    at ModuleLoader.loadEntryModule (file:///Users/issambousfiha/Projects/qwik-app/node_modules/rollup/dist/es/shared/node-entry.js:24881:20)
    at async Promise.all (index 0)

I can open a separate issue to address this problem. Would that be a good next step?

Thanks! Yes, an issue for fixing preview would be good.


Refactoring - switch to React Spring

Taken by @idoberko2
For most spring animations in the project, we're using React Motion.
Recently, we introduced React Spring. It does the same kind of thing, but is more powerful, and has a simpler API. It can also be more performant, with its new native option (React Motion will re-render the component tree every frame, whereas React Spring can do it without the overhead of React's lifecycles, somehow)
We should remove React Motion from the project, converting current spring animations to React Spring.

[ ] BigClickableButton
[ ] MainPane
[ ] Modal
[ ] ProgressBar
[x] SettingsButton
[ ] Sidebar
[ ] Toggle (this one should probably switch to CSS animations, actually, for performance)
[ ] TwoPaneModal

I think this is probably a great first issue for folks looking to contribute :) SettingsButton can be used as a template (at least, once #235 is merged in).
Happy to help clarify any questions!

Hi @idoberko2! Sure thing, all yours.
Some notes:

When possible, I'd like to use the native setting (see SettingsButton for an example).
It'd be awesome if you could record the performance before/after the conversion, using the devtools (really just to check that the FPS isn't worse with Spring). I expect it'll be an improvement, but good to check as you go
Don't worry about CircularOutline. I'm in the middle of reworking that component anyway

Oh, one other thing!
When dealing with springs, we run into the issue of "shadowed" variable names:
const { something } = this.props;

return <Spring to={{ something }}>
  {({ something }) =>
}
</Spring>

Our linter will complain because something is already defined in the upper scope.
So far we've dealt with this by renaming the interpolated one:
const { something } = this.props;

return <Spring to={{ something }}>
  {({ something: interpolatedSomething }) =>
}
</Spring>

I think maybe a better pattern is to leave the interpolated values non-deconstructed:
const { something } = this.props;

return <Spring to={{ something }}>
  {interpolated =>
}
</Spring>

This way, we're not shadowing the variables, and we clean up a lot of syntactic cruft as well. So I think we should do this, as part of the refactor to Spring.
Let me know if this is unclear, happy to elaborate!

Hi @joshwcomeau, will you have a time to look at my first commit just to make sure I got your intention (it's working)?
Additionally, can you lead me to an article about how to measure FPS of an animation accurately? The only material I found used the FPS graph for measurements and I can't have any numbers pulled out of it...

Hi @idoberko2!
Thanks for checking :) great idea to get an early commit checked!
I had actually imagined this first version just replacing <Motion> instances with <Spring> instances. Consolidating the react-transition-group and react-motion into a single layer is a good idea using Transition, although the animation doesn't look right, for a few reasons:

The modal drops down instead of rising up
The background fade animation happens at the same speed as the modal translate
The spring settings are different

If you wanted to take the time to convert to <Transition>, that'd be awesome! But I'm afraid it would be a fair bit more trouble. The settings need to be different between background opacity and the modal translate, and I'm not sure if that's possible with Transition.
It might be simpler for this first change to just convert the <Motion> to <Spring>, but it's your call :)
For perf testing, I mean using the devtools like so:

It's not really very scientific, but mostly I just want to make sure the average performance isn't worse, by checking that the animation starts as quickly, and has roughly the same amount of frames per second during the animation.
(I'm aware that it's already quite bad for some of our modals :/ I'm working on some changes that should improve it)
Hope that helps! Lemme know if anything is still unclear

hi @idoberko2,
Ah, super sorry for the delay!
That new commit looks good! I learned a couple tricks from it, like passing a function to config and using animated as a wrapper around styled components.

hey @joshwcomeau, that's completely fine, I didn't wait for the response and went on with the refactor, I'm glad it looks good to you. I finished refactoring all of the components beside SideBar, I might need to add it to storybook in order to be able to verify my changes and avoiding regressions.
One thing I did notice was some sort of an "ease-out" effect in the master version of ProgressBar that I think isn't working anymore in my version, but I'm not sure. Was there any such effect? Can you take a look on the refactored ProgressBar when you have time and let me know if it's OK (if not, I'd be happy for a lead on what might got broken since I spent quite a lot of time on that and couldn't find anything)?

I finished refactoring all of the components beside SideBar, I might need to add it to storybook in order to be able to verify my changes and avoiding regressions.

Don't worry too much about storybook - we're thinking about moving to Docz, so while stories would be helpful, they might not be worth the effort at this point. The surface area of the app is small enough that I can run through all the functions in a few minutes - when you open a PR I'll clone it and take it for a spin :)

One thing I did notice was some sort of an "ease-out" effect in the master version of ProgressBar that I think isn't working anymore in my version, but I'm not sure. Was there any such effect? Can you take a look on the refactored ProgressBar when you have time and let me know if it's OK (if not, I'd be happy for a lead on what might got broken since I spent quite a lot of time on that and couldn't find anything)?

Ah, so we're actually not using the ProgressBar component anymore (we do plan to bring it back at some point, but it was removed from the BuildPane, which was the only place it was being used).
But yeah, I don't believe there was anything other than React Motion's spring physics affecting it, so I'm surprised to hear it's different

On a more meta thing, shall we use Assignees when someone is working on a PR so that it's clear on the issue list? I don't really like the term Assignee but /shrug

@joshwcomeau, PR submitted: #299

Closing since this was completed in #299.


[master] Upgrade to latest dependencies

Produced via:
./hack/update-deps.sh --upgrade
./hack/update-codegen.sh

Justification, Pushing release branch of knative/hack repo, staging for 0.19 release cuts. -n3wscott
/cc knative-sandbox/source-wg-leads
/assign knative-sandbox/source-wg-leads

/lgtm
/approve


Game freezes after round 1

Georgios Konstantopoulos:
After completing phase 1, game freezes

Confirmed!

Level 2 now starts, but no invaders drawn. Then crashes when player fires.

Added wave. Corrected invaders starting lower down.


Setting direction to PCAP_D_OUT is not supported on BPF

I am trying to capture outbound traffic on my M1 Mac, and setting the direction to out:
cap.direction(Direction::Out).unwrap();

results in an error:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: PcapError("Setting direction to PCAP_D_OUT is not supported on BPF")'

That's an error from the underlying libpcap library. That's what PcapError is indicating.
To resolve the error, please consult the libpcap documentation. However, a brief inspection of the underlying libpcap call reveals the following:

pcap_setdirection() isn't necessarily fully supported on all platforms; some platforms might return an error for all values, and some other platforms might not support PCAP_D_OUT.

It does not appear like we can help here.

If you show you can achieve this with the tcpdump program though then this would be an issue in the pcap crate and I'll reopen it.


How to set the account prompt to be hidden

VS Code Version:1.54.1
After login my account, the account will always prompt for synchronous change,how to  turn off the prompt, let it update itself directly, instead of prompting me often and letting me update manually。Or the user can set no prompt

Closing as a duplicate of https://github.com/microsoft/vscode/issues/118668


[FEATURE] Handle raw data with the connector (topics without schema)

I would like to use the connector without schema in my topics.
Currently we have to provide a schema otherwise the connector fails to send the data from the topics to S3 buckets.
Like for the Kinesis Sink, it would be great to be able to handle raw data. Among the existing format types: json, avro and parquet we could have the raw type. The field to update is formatType.
I am currently using the connector to sink JSON data without schema, like I did with the Kinesis Sink. My current configuration is formatType: "json". For each message produced, the connector raises an exception:
16:05:43.437 [public/default/s3connector-0] ERROR org.apache.pulsar.functions.instance.JavaInstanceRunnable - [public/default/s3connector:0] Uncaught exception in Java Instance                        │
│ java.lang.NullPointerException: null                                                                                │
│     at org.apache.pulsar.client.impl.schema.AutoConsumeSchema.generateSchema(AutoConsumeSchema.java:154) ~[org.apache.pulsar-pulsar-client-original-<IP_ADDRESS>.jar:<IP_ADDRESS>]                                │
│     at org.apache.pulsar.client.impl.schema.AutoConsumeSchema.decode(AutoConsumeSchema.java:91) ~[org.apache.pulsar-pulsar-client-original-<IP_ADDRESS>.jar:<IP_ADDRESS>]                                         │
│     at org.apache.pulsar.client.impl.schema.AutoConsumeSchema.decode(AutoConsumeSchema.java:40) ~[org.apache.pulsar-pulsar-client-original-<IP_ADDRESS>.jar:<IP_ADDRESS>]                                         │
│     at org.apache.pulsar.client.api.Schema.decode(Schema.java:103) ~[java-instance.jar:?]                                                                                │
│     at org.apache.pulsar.client.impl.MessageImpl.getValue(MessageImpl.java:299) ~[org.apache.pulsar-pulsar-client-original-<IP_ADDRESS>.jar:<IP_ADDRESS>]                                                         │
│     at org.apache.pulsar.functions.source.PulsarRecord.getValue(PulsarRecord.java:76) ~[org.apache.pulsar-pulsar-functions-instance-<IP_ADDRESS>.jar:<IP_ADDRESS>]                                                │
│     at org.apache.pulsar.functions.instance.JavaInstanceRunnable.readInput(JavaInstanceRunnable.java:400) ~[org.apache.pulsar-pulsar-functions-instance-<IP_ADDRESS>.jar:?]                                  │
│     at org.apache.pulsar.functions.instance.JavaInstanceRunnable.run(JavaInstanceRunnable.java:237) [org.apache.pulsar-pulsar-functions-instance-<IP_ADDRESS>.jar:?]                                         │
│     at java.lang.Thread.run(Thread.java:748) [?:1.8.0_275]                                                                                │
│ 16:05:43.443 [public/default/s3connector-0] INFO  org.apache.pulsar.functions.instance.JavaInstanceRunnable - Closing instance                                                                          │
│ 16:05:43.447 [pulsar-client-io-1-1] INFO  org.apache.pulsar.client.impl.ConsumerImpl - [persistent://public/default/s3connector] [auniquename] Closed consumer

@jianyun8023 Could you please help take a look at this issue?

Could you please help take a look at this issue?
@codelipenghui This is the requirement of Pulsar function, right? When using AutoConsumeSchema, Topic must have a schema. I can create this issue in the pulsar warehouse.

@jianyun8023 @Damien137  I see. We are work on the schema improvement for now, I can take this part to allow AutoConsumeSchema can consume data with any schema types.


Add some integration tests to detect bad network behaviour

Add an integration test that checks what policy and value is predicted for some board positions with the following features:

Big dead dragon (with one eye), check that it scores the game correctly.
Broken ladders, check that the policy does not suggest playing it out.

Some suggested SGF files containing either broken ladders (both from leela-zero, but we should check them anyway) or big dragons that are dead.
big_dead_dragon.sgf.gz
ladder_1.sgf.gz
ladder_2.sgf.gz

I just added the following game, based on one I played between Leela 0.11.0 and some internal weights. In the actual game the network misjudged the final board position significantly because of the random black stones that are placed in whites territory, as soon as they were removed the situation improved:
end_1.sgf.gz

Added one more ladder test from a leela-zero game that was posted on cbaduk:
ladder_3.sgf.gz

Added one more game with some large dead dragons that doesn't register. This seems to be a consistent problem where it doesn't detect that a big dragon is dead in the value network and it affects everything when it comes to value of play.
Part of the reason for this might be the reinforcement learning algorithm that we are using, as it does not generate very high quality games for the value network. It might also be the 0.01 coefficient for the MSE component of the loss function.
dead_dragon_2.sgf.gz

I tweaked the regularization coefficient a little bit (which is equivalent to increasing all of the other coefficients) and we got a network with (very) slightly better value loss (~0.02). However it still has issues identifying large dead groups:
dead_dragon_3.sgf.gz

After some investigation into the linked game one can make the following observation:

The dead dragon is considered alive by the scoring engine. This means we teach the neural network that said dragon is alive, which could explain the issues it is having with determining that the group is dead.

I added a few more that I've had laying around from when I revamped the scoring engine. They mostly deal with seki, dead dragons, or bent four in the corner.
In general the neural network fails them horribly, but with the recent advances using dilation we might start seeing less failure soon™ (I hope, since preliminary results were not too promising).
bent_four_1.sgf.gz
dead_dragon_4.sgf.gz
seki_1.sgf.gz
seki_2.sgf.gz
seki_3.sgf.gz
seki_4.sgf.gz


Include wait_for_update on the setDefaultConsent Call

https://github.com/OrbeeInc/orbee-consent-template-gtm/blob/4460dadd0c49473bda7073381692fbf335e24e46/template.tpl#L202
When reviewing your template we've noticed that the setDefaultConsentState call does not include the wait_for_update option. This is required for any asynchronous consent management script load to delay tag execution.

@semisight I have added the wait_for_update option to the setDefaultConsentState call.


Entity Collision FPS Fix Refabricated

Mod name
Entity Collision FPS Fix Refabricated
CurseForge link
https://www.curseforge.com/minecraft/mc-mods/entity-collision-fps-fix-fabric
Other links
https://github.com/CorgiTaco/No-Client-Side-Entity-Collision-Checks
What it does
Improve FPS when entities collide, e.g. mob farms
Why should it be in the modpack
Similar FPS improvement to FastChest/Entity Block.. whatever, just for mobs
Why shouldn't it be in the modpack
Modrinth? Could get included in Debugify as well.
Categories
Performance optimization
Additional details
https://github.com/W-OVERFLOW/Debugify/issues/93

It does not seem to bring any perfomance on a multiplayer server. Possibly because of iris. That's a very rough test, but with what the mod claims to do it should not matter whether you are in multiplayer or singleplayer.

Why iris ?

Iris included batched entity models

Does removing iris makes the mod work and we get better performance

Patched in Debugify ( See https://github.com/isXander/Debugify/commit/7b8d40fde17fc3a51122b992f6aacf3b412b9dae )

Enabled Debugify bugfix in 3.9.0.


[WIP] Charge resource tokens for rented side chain.

[x] Maintain resource usage information in Configuration Contract

Four main actions:

[x] RentResourceTokens

[x] UpdateRentedResourceTokens

[x] InitialTotalResourceTokens

[x] UpdateTotalResourceTokens

[x] Update resource usage information during creating side chain. (Call RentResourceTokens in CreateSideChain)

[x] Config resource usage information in Economic Option and update to Token Contract in side chain.

[x] Update rental of resource tokens after launching side chain. (UpdateRental in Token Contract)

[x] Calculate rental in system tx DonateResourceToken.

:x: Build AElf <IP_ADDRESS>26 failed (commit https://github.com/AElfProject/AElf/commit/75ef356fef by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>29 failed (commit https://github.com/AElfProject/AElf/commit/46874844bc by @EanCuznaivy)

:white_check_mark: Build AElf <IP_ADDRESS>39 completed (commit https://github.com/AElfProject/AElf/commit/c4d8f59bfc by @EanCuznaivy)

:white_check_mark: Build AElf <IP_ADDRESS>50 completed (commit https://github.com/AElfProject/AElf/commit/6e34323129 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>53 failed (commit https://github.com/AElfProject/AElf/commit/260151adb8 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>74 failed (commit https://github.com/AElfProject/AElf/commit/95f2af2d6b by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>79 failed (commit https://github.com/AElfProject/AElf/commit/1219938e6a by @EanCuznaivy)


Add support for TLS connections with self-signed cert on validator gRPC interface

Client side to follow in a future PR.

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:
[ ] REST API:

Would it be possible to add a client impl so that we can test the tls part added in this pr?

I was hoping to keep it smaller for review purposes but we could just do it all at once if you prefer


IterableDataset does not work in validation

🐛 Bug
Colab to Reproduce: https://colab.research.google.com/drive/1YEdFCv0_VkdOG9FVibPzGAOv3tH-vpki
Validation datasets cannot use IterableDatsets because Lightning still needs the __len__ method of the validation dataset. I tracked the __len__ call to the line I reference below.
https://github.com/PyTorchLightning/pytorch-lightning/blob/48e808c20e55fae47fc58b3e2c4e2056883b88b4/pytorch_lightning/trainer/data_loading.py#L222
Particularly, the if dl statement implicitly calls the __len__ function of the dataset.

A fix is in the works in PR #1560


the number of control qubit and length of binary

'The amount of control qubit does not match the length of binaries.'

fixed


Add class to bindmount the ephemeral /mnt to /localscratch

Add class to bindmount the ephemeral /mnt to /localscratch

fix site.pp

Should be fixed now


Created note for curl not installed warning

@saitorhan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@prmerger19: Hi! I'm new at Microsoft docs making a contribution. May I ask that, what can I change for merging my this pull request?
Thanks.

@saitorhan
The author of this article has received a request to review your suggested changes. If they approve, the PR can be merged.

@v-andreaco
So much thanks for explanation :)

Thanks @saitorhan! We appreciate the additions. I'll approve this change.
#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


doc change to correct key name in mii opss wallet password secret

@jshum2479, make the same change under "documentation/3.4" so that the correction goes live now.


Add ql-dsp plugin

This PR adds  :

ql-dsp plugin, which embeds a function that packs adder into QL_DSP when synthesizing a mac_unit design, it is called during synth_quicklogic multiplier stage.
Testcases for the ql-dsp functions are located in the ql-qlf folder, since the function is meant to be used during synth_quicklogic, I think it is easier to maintain to regroup all testcase under one plugin folder. I can move them to ql-dsp test folder if you prefer.
Corrects a typo on dfflegalize call during synth_quicklogic.

@tpagarani @kkumar23 FYI.

@samycharas : let us know your views on the comments from Maciej.

@acomodi @tmichalak Could you look into this PR? It now requires Yosys' pmgen.py which is not installed along with Yosys to build the pattern matcher for the plugin. Do you have any other ideas how to deal with it other than manually fetching it from GitHub using eg wget ?

@mkurc-ant Another option might be to add yosys as a third_party submodule and directly use the pmgen.py script from there.

@mkurc-ant @acomodi so the question here is whether pmgen.py will change from where you wget it. Making it part of third_party will ensure that won't change without somebody explicitly updating the submodule.

I've done the following change in the new commits :

pmgen.py is now being downloaded from symbiflow's yosys repository
Added generated files to .gitignore for 2 reasons, to avoid anyone to commit them, especially the pmgen.py which we are not cleaning ( the file shouldn't change after it's been downloaded, so I did not add it to clean rule ) and because they were failing format pass.
rebased on top of the master, there should be no conflict with the branch now.
Waiting for CI.


Incorrect badge count

Hi! i use 0.7.0-beta.4 version ,keep channelShowBadge: true, to get badge, when i decrease badge in code and receive one more notifications app-badge increased by 1 and show 2.

Hi! Sorry for taking so long to respond to your issue on GitHub. I was focused on releasing the new 0.7.0 version of awesome_notifications and awesome_notifications_fcm and i didn't had time enough to do both. But now I can answer all your questions.
So now i'm asking you to recreate this topic using the new issue template. There's a lot of missing informations that i need to understand your problem, and all the instructions are already in the new issue template. Also, remember to check beforehand if your issue was posted by another user.
So I will automatically close all previous issues so far.
Sorry for the inconvenience and i will be waiting for your new issue request.
Thank you so much for your support!


Search bar problem

I'm having this weird problem when combining the Search bar and cell editing.
My code looks like:
Edit: I have problems with posting code here, so here it is:
https://pastebin.com/AH1jyq08
The problem is that when I reload the page where this table is in, and then I try to edit some cell, that cell is not showing the new value, but my state and my database are updating properly.
However, when I use this code without the Search Bar, everything works fine.
https://pastebin.com/52k4Jwwb
I don't know if there's something wrong with my code or this is a bug.

@ipetrini did you enable the remote mode? I saw you didn‘t enable it, so I'm curious how you update the data after editing a cell.  Would you please put a minimal, simple and dummy example on codesandbox.io?  That will be very helpful for me to reproduce this issue.  here is an example you can take it.

Hi @AllenFang. No, I didn´t enable the remote mode.
Here is an example that looks similiar to my code https://codesandbox.io/s/nnrqoox274?fontsize=14

HI @ipetrini sorry, I can not reproduce your issue. Please give me more information so that I can reproduce it.  btw, how do you update the cell? any information is appreciated.

@AllenFang well, the cell was updating by default, now I've changed to remote mode and it works perfectly. Sorry for the confusion and thanks!


⚠ TROJAN 🇸🇬 Singapore SGO 1 has degraded performance

In 3460bdd, TROJAN 🇸🇬 Singapore SGO 1 (https://sgt-2.opensvr.net/) experienced degraded performance:

HTTP code: 200
Response time: 27703 ms

Resolved: TROJAN 🇸🇬 Singapore SGO 1 performance has improved in 8817763.


More Custom Resources

Signed-off-by: Steven Murawski<EMAIL_ADDRESS>windows_task is now a custom resource.
Still certificate, certificate_binding, and http_acl to go.

Not sure how far along https://github.com/chef/chef/pull/5886 is but if its imminent, it may make sense to deprecate this resource.

@mwrock Once we ship task in core we'll still need to keep it here for probably a year plus. We will want to get some deprecation warnings similar to what was done with the package resource when that went into core though.


[WIP] Tree hash computation without extraction.

Implements #19. Hashing works but testing and top level interface is missing.

Cool! My first very casual reaction is that it shares more code with extract than I’m happy with so I might want to figure out a common abstraction that both can be implemented in terms of. And for the gen_static.jl script in PkgServer.jl I just needed something that got access to each file as an I/O handle instead of as an extracted file, so I think there’s a commonality there: get each header with an I/O handle you can read from for each file—to extract, write it to a file; to hash, call a hash function on it. The only question is how to handle non-files, i.e. symlinks and directories.

Yeah, I intentionally started it as a copy of extract to see how much needed to be replaced.
My first thought was to replace the predicate function of extract with an action function. Feeding it with header + io should be good, but you would probably want to wrap the io in a view that can only see the current part of the file and yields eof when you reach datalen. In that case non-files would get an io object that effectively works like an empty file.

API function and a test added. Questions:

Is testing against the "test tarball" sufficiently demanding or are there edge cases that aren't covered enough?
How interesting is it to support alternative hashes? Currently the support is about as partial as in GitTools and should either be removed or completed.

I spent some time refactoring the tarball reading logic so that the same core can support both extract_tarball and hash_tree, which I implemented here: https://github.com/JuliaIO/Tar.jl/pull/36. Sorry for sniping your PR! I also added a lot of tests and wrote the docs, so it's pretty complete at this point 😬

I added support for the classic git-sha1 algorithm and the upcoming git-sha256 algorithm, but I made the algorithm selection argument a string to eliminate the external coupling with the SHA package. That way support for non-git tree hashing algorithms could be added at some point.

Thank you for spurring me to implement this. Sorry I didn't use your version 😢

No problem. I'm just trying to understand why your SHA-256 doesn't give the same result as mine for non-empty tarballs.

Hmm. That's troubling. Do you have an example?

I'm looking at a tar archive containing a single file named "foo" with content "foo".

I was looking for a place where one of us forgets to pass an optional HashType argument, but I don't see that in either of our code (I made the HashType non-optional in all internal methods). I wonder if we can figure out how to use git as a reference here—put it in SHA256 mode.

Could it be that this part of the GitTools implementation:
    for (n, h, m) in entries
        content_size += ndigits(UInt32(m); base=8) + 1 + sizeof(n) + 1 + 20
    end

is incorrect for other hash types than the default? Specifically, should "20" rather be a function of the length of the hash?

That's definitely what differs. Changing 20 to 32 for SHA256 gives the same results. Would certainly be good to verify with git, but this looks unlikely not to be a GitTools bug.

Ah yes! That would do it. That 20 is 20 bytes == 160 bits of SHA1 hash. My version doesn't have this issue because instead of computing the length like that, I just write the data to a buffer and take its length, which is much more foolproof. Doesn't really matter for performance either since the size of the buffer for directory info is never going to be large enough to matter. For file data, I optimized the hashing in https://github.com/JuliaIO/Tar.jl/pull/37, so that it does the hashing incrementally instead of writing everything to a buffer just to measure the length.

I'm working on a separate package that factors out all the content tree logic anyway, so Pkg.GitTools will go away at some point (it's kind of a motley collection of random stuff anyway). It might make sense to factor common git hashing code into a standalone package, but for now it's such a small amount of code that just duplicating it here and there seems ok. No one is actually using GitTools.tree_hash with any non-default hash type at this point, so it's fine to leave it as is.


The read model throw Event Store concurrency exception

The bug was on the memento. It was set to internal set, and was not loaded the actual version. The memento object was deserialized with value zero, throwing a concurrency exception.


Replacement of neo4j with an in-memory resource registry

@stewartshea You should double-check the changes I made to the Dockerfile. Obviously we don't use a neo4j image as the base image anymore. The only way I was able to get it to work was to use one of the standard node docker images as the base image. With that I disabled the stuff in the Dockerfile that was installing node, but it was doing some other stuff with certs and gpg which I didn't understand, so you should check if any of that is still needed.
I also tried using a python bullseye slim image as the base image (which is what we use for several other things), but with that I was getting errors with the npm commands, which I couldn't figure out. I think it probably makes sense to use a node image anyway, though.
Sadly the image size seems to be pretty much the same as it was before :-(. Not sure why the elimination of all of the neo4j stuff didn't buy us anything. Maybe the standard node image has more other stuff in it than the neo4j image?
I did some basic testing with the image and verified that I could run the workspace builder and that I could navigate around a bit in the cheat sheet pages. But I definitely didn't do a super thorough QA pass. I think it would be good if we could do some more testing with these changes before publishing a new image, i.e. go ahead and commit the PR but defer pushing the image.
Details from the commit comment are below.

in-memory data structures mostly mimic the old neo4j models
main difference is that I added a platform hierarchy, so that each platfrom has it's own scope and set of resources
this is in preparation for the upcoming changes to support multiple cloud platforms, not just Kubernetes
there's still a bunch of Kubernetes-specific logic in the core workspace builder code, e.g. in the generation rules and match predicate logic, which really should be indexer/platform-agnostic. So there's still some more work that needs to be done to clean up that code
made some tweaks to the entrypoint.sh and run.py to remove the neo4j related code, i.e. starting up neo4j and checks that neo4j is running
patched up the Dockerfile to not be based off of a neo4j image. Instead I use a node image as the base image and removed some of the commands that were installing node. I'm not 100% sure I got this exactly right though, so Shea should look at this a bit more.

Thanks @vaterlaus -- I'll have a look as soon as possible and will do a dive into the image layers to see if we can find some more storage savings... I would have expected to save a few hundred MB from the neo4j removal, so I'll see what we can do there. We won't bump/release until it's been tested thoroughly.

I was able to refactor my code to avoid the use of the resource dump for now, though maybe it's not a scalable approach.


Build warning in process_moc.cpp

This build warning in process_moc.cpp should be easy to fix, I hope:
src/process_moc.cpp: In function ‘void create_moc_release_context(void*, Smoc*, pgs_error_handler)’:
src/process_moc.cpp:624:17: warning: declaration of ‘n’ shadows a previous local [-Wshadow=compatible-local]
  624 |    rnode_iter n(moc_data, m.layout[k + 1].level_end);
      |                 ^~~~~~~~
src/process_moc.cpp:580:14: note: shadowed declaration is here
  580 |   rnode_iter n(moc_data, m.layout[1].level_end);
      |              ^

Can we closed it?

PR https://github.com/postgrespro/pgsphere/pull/47 has been merged, addressing this issue. Closing.


Hearbeat

This change is

r? @vinipsmaker
(maidsafe_highfive has picked a reviewer for you, use r? to override)


Fix Get Dataset Table Overview for Non-Dataset Owners

Feature or Bugfix

Bugfix

Detail

If a User who is not Dataset Owner, Env Admin, or Dataset Steward tries to view a dataset table from the Catalog they cannot view the any of the tabs for: Preview, Overview, Columns, or Metrics and receive an error: An error occurred (UnauthorizedOperation) when calling GET_DATASET_TABLE operation

This PR:

Removes GlueTableProperties from being returned in the getDatasetTable query as it is not required for any Dataset Table operations on data.all's UI

Resolves Requester User can see Overview Tab

Adds Check on Dataset Confidentiality Tag to determine to show data in Columns Tab or not and removes checks on

Resolves Requester User can see Column Tab (for Unclassified Datasets)

Removes Resource Permissions checks on Metrics Tab queries to only handle check on Dataset Confidentiality Tag

Resolves Requester User can see Metrics Tab (for Unclassified Datasets)

Fix bug in update column description

Resolves Dataset Owner being able to update Column Description

Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?

Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?

Does this PR introduce any functionality or component that requires authorization?

How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?

Are you using or adding any cryptographic features?

Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?

Are you introducing any new policies/roles/users?

Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Tested in AWS:
Dataset Owner w/ Dataset Unclassified

[ ] Can view Table Preview Tab
[ ] Can view Table Overview Tab
[ ] Can view Table Column Tab + Edit Column Description
[ ] Can view Table Metrics Tab

Requestor User w/ Dataset Unclassified

[ ] Can view Table Preview Tab
[ ] Can view Table Overview Tab
[ ] Can view Table Column Tab but NOT Edit Column Description
[ ] Can view Table Metrics Tab but NOT start profiling run

Dataset Owner w/ Dataset Official

[ ] Can view Table Preview Tab
[ ] Can view Table Overview Tab
[ ] Can view Table Column Tab + Edit Column Description
[ ] Can view Table Metrics Tab

Requestor User w/ Dataset Official

[ ] Can NOT view Table Preview Tab
[ ] Can view Table Overview Tab
[ ] Can NOT view Table Column Tab
[ ] Can NOT view Table Metrics Tab


Automatically post the results of coverage somewhere

This can probably be accomplished with Webhooks pretty easily.

This sounds fun! Let me know if you need anything set up in the repo from me.

I think we could use it to generate paste-ready snippets for the wiki too :)

Does it make sense to implement the server as a another subcrate? Or should I make it in another repo somewhere?

Definitely.

First run at this: http://euclio.github.io/rosetta-coverage/
Feedback welcome! It's not automated yet, but I'll probably set up a Heroku instance to poll the wiki/repo every 24 hours (or more, depending on how long the report takes).

Whooo looks like the arewewebyet.org site. I dig it! Wow, thanks for doing this. Is there no way to get notified by the wiki of changes? I think the repo can be done with hooks.
While it'd be cool if we could build status for windows/linux on it I can see how that would be rather difficult. :)

I don't think we can add any sort of hook to the wiki without actually modifying the RosettaCode source itself. And yeah, while we could use GH hooks I'm not sure it's worth it if we are going to have to do polling anyways.
I can investigate adding a run of each crate to the test, at least for linux, but again, due to the increased complexity I'm not sure it's worth it.
Once I automate the task status pull, I'll go ahead and add a link to the wiki and close out this issue.


chore: fix kotlin doc

Codecov Report

Merging #328 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   83.81%   83.81%
=======================================
  Files          74       74
  Lines        4151     4151
  Branches      672      672
=======================================
  Hits         3479     3479
  Misses        398      398
  Partials      274      274

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ae244...83f9b7a. Read the comment docs.


Remove dead links from free-programming-books-langs.md

What does this PR do?
Remove resource(s)
For resources
Description
Fixes Issue #9687
Why is this valuable (or not)?
Saving other people's time and keeping the file clean and updated
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Removed author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

@eshellman Would you be so kind as to review this pull request and, if it aligns with our project's standards and requirements, consider merging it?

@Royalty252 some check are failing. You can resolve them. Check what the error says.

Thanks, and welcome to free-programming-books!


Add ability to bypass staging during git xet repo migrate.

This PR adds the ability to bypass staging during git xet repo migrate, uploading new data to CAS directly.
To use this, run with XET_CAS_BYPASS_STAGING=1
XET_CAS_BYPASS_STAGING=1 git xet repo migrate

Instead of low level changes, probably better and easier to do it from config like in
https://github.com/xetdata/xet-core/blob/dd4af199c5b1f932174fcf19ab3e2088e3e4db77/rust/gitxetcore/src/xetblob/xet_repo.rs#L205

Doesn't this just cause it to use a tmp directory instead of bypass staging altogether?  Let me look...

Doesn't this just cause it to use a tmp directory instead of bypass staging altogether? Let me look...

No.. this makes it use PassthroughStagingClient: https://github.com/xetdata/xet-core/blob/dd4af199c5b1f932174fcf19ab3e2088e3e4db77/rust/cas_client/src/staging_client.rs#L97


Import/Export Integration to e.g. Labelstudio (and Prodigy)

Is your feature request related to a problem? Please describe.
I want to use the data from labelstudio in refinery or the other way around
Describe the solution you'd like
when exporting records (not the project snapshot). I want to be able to select an export format (current, for labelstudio, ....), maybe what to export (e.g. only data, specific tasks etc.) and what file type (.csv, .json ,....)
Describe alternatives you've considered
crating a parser on my own
Additional context
-

Hey team! Please add your planning poker estimate with Zenhub @JWittmeyer @SirDegraf

##Idea proposal
Preparations (imo can be done in parallel):

[ ] Analyze format Label Studio and prepare Mapping Document (6 h)
[ ] Think of UI Design (2 h)
[ ] Think of Backend Design (4 h)
[ ] Create Issues/PRs for Repos (best guess: UI, Gateway, Submodule model, Proxy & SDK) (1h)

Findings Analyzation (classification)

Only one "labeling task" per project in Label Studio?
Task Information (settings) isn't part of the label studio export but can be prepared for copy paste
Task Values are only correctly transferred/assigned to the task in label studio if the .json format is chosen, csv treats the label column as normal text column
Import can be prase from csv to kern.ai import only if we can "select" what columns are the label values
Import of .json unproblematic, however slight loss of values (e.g. modified at)
annotators need to be mapped (export only holds an id)

Design UI
Export records should be able to select what we want to export and how.
What:

(Rows) static slice, dynamic slice or current data browser selection
(Columns) key (UUID or row number), "attribute data", N labeling tasks

How:

File Type (.json, .csv, .excel sheet)
Format (current, Labelstudio,...)

E.g. Label studio only allows one labeling task selected (or multiple files)

Import

Select between import templates (current, Label Studio csv, Label Studio json, ...)
Decide on update behavior (can be a different issue/sprint)

(atm all columns need to be present to add new columns)
"overwrite" mode -> all values present in the given document are used to update existing values
"append" mode -> only values != "" || None are used to replace values / appended

Depending on the template different options are possible

current -> file import option ala pandas
Label Studio csv
-> "Columns that should be treated as label"
-> Map label studio user-id to kern user-id
Label Studio json
-> Map label studio user-id to kern user-id

Maybe store presets of import configurations so one doesn't need to reapply them every single time?
Maybe we should also add some logic to analyze the selected file before processing it

csv first 100 lines
json if < 5 MB completely and remove all but 100 entries?
or sent the file to the backend and analyze it there? (probably best option)

Design Backend

Approach:

first we only do the export from kern (including export options from kern to import into label studio)
Depending on the time passed we start with the import this or next sprint
UI @JWittmeyer
Backend @SirDegraf
SDK & Proxy (after UI and Backend)

Steps:

[ ] Analyze extraction label studio tasks
[ ] Interface decision (between UI & Gateway)
[ ] concept UI
[ ] concept Gateway
[ ] implement
[ ] QA

Export changes are included in PR https://github.com/code-kern-ai/refinery-gateway/pull/69.
New issue will be created for import & other integrations than label sutdio


[BEAM-13229] [Website] bug side nav

[BEAM-13229]

change offset to 10px to activate an element via bootstrap's scrollspy library

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

R: @AydarZaynutdinov

I still can reproduce this bug on the documentation page

R: @riteshghorse - could you do a first pass review and tag a committer after that?

It solves the original problem but introduces new orange lines under the side section

@bullet03 Thanks for the PR. It solves the original problem of changing sections on side nav. However, it looks like the orange scroll bar in side nav gets collapsed as horizontal lines before moving to its original position.
Could you do another pass? Would be happy to get this change in once the orange lines are gone.

@bullet03 Thanks for the PR. It solves the original problem of changing sections on side nav. However, it looks like the orange scroll bar in side nav gets collapsed as horizontal lines before moving to its original position. Could you do another pass? Would be happy to get this change in once the orange lines are gone.

The arrow images are not shown on staging in any PR, so it is not caused by the changes in 17260. They are shown correctly on localhost, so we couldn't reproduce the bug there.
There is a high probability that, when we merge the code to master, this issue will be fixed.
Which means, there might be another issue - with CI/CD - that is worth investigating. Should we create another ticket in Jira and describe the issue there?

Sounds good to me. I'll tag a committer and let's see their take on it.
R: @kileys

@pabloem I heard that Kiley is OOO for this and next week, can you please help with merging this PR? :)

Run Website_Stage_GCS PreCommit

let's just make sure that the issue does not reproduce once merged...

LGTM

like I said, please let's make sure that the issue that ritesh caught did not just get merged

@pabloem Ritesh's issue with arrow images not being displayed on staging is not present on the master branch after the merge. We will create a separate Jira ticket describing this CI/CD issue.
We have created PR #17503 to revert the changes from this branch because the menu still works incorrectly.

Created a  Jira ticket  to investigate issue with CI/CD.


feat: LEAP-1199: Add drag and drop functionality on DM tabs

PR fulfills these requirements

[ ] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[ ] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[ ] Backend (Database)
[ ] Backend (API)
[ ] Frontend

Describe the reason for change
(link to issue, supportive screenshots etc.)
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[ ] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

/git merge develop

/git merge develop

/git merge develop

Good morning!
Does the drag and drop funcitonality has to be enabled or enteprse version is required? I am running Label studio v 1.13.1 deployed using helm chart. I am using Version 130.0.6723.91 (Official Build) (64-bit)


ShouldBeAssignableTo

Potential matcher: a.ShouldBeAssignableTo<T>
Would throw if a is not a subtype of T.

@sksamuel @Kerooker a.shouldBeInstanceOf<T>() doesn't work in this case?

I think my idea was that a was a type rather than an instance.

Actually shouldBeInstanceOf is exactly the same :)
Closing.

My bad I meant like Cat.shouldBeAssignableTo().
So reopening and implementing.

@sksamuel can't we use the reflection methods?
Cat::class.shouldBeSubtypeOf<Animal>()

or
Animal::class.shouldBeSupertypeOf<Cat>()

Absolutely of course! Closing my PR.


Add reading of factory calibrated parameters in the driver of BMP085

Fixes #327
In the driver of the baro BMP085, the calibration data (used to compute pressure from raw sensor data) were the example values given in the datasheet. I added a method to read the calibration data from EPROM. This method is called in the init function.
Before the change, I got raw pressure of about 129 119hPa, which translates to an estimated altitude of -2092m with sea level pressure of 101 325hPa. Now, I get a pressure of 97 960hPa, which gives an altitude of 284m. This is still much closer to reality !

@jlecoeur
Why do you change mavlink submodule ?

I forgot to update the submodule after I switched from dev/mission_planner.

@GregoireH I fixed it


Convert current price of any cryptocurrency in any other currency that you need.

This also fixes the requirement of https://github.com/ExodusMovement/cryptocompare/issues/25

This endpoint is already covered by price(), correct?


Example readme from branch example

Updates
I updated the readme file. Please review and accept it.

Great work mate
:+1: :+1: :100:


Disable InPlace option in Cast filter

Test for potential cause of  BasicFilters.Cast of Float to VectorInt8

Test fixed with: #1680


MINOR: Disable scoverage in 2.0

The scoverage plugin is causing the build to fail with recent versions of gradle. I see the following error:
* What went wrong:
A problem occurred evaluating root project 'kafka'.
> Failed to apply plugin [id 'org.scoverage']
   > Could not create an instance of type org.scoverage.ScoverageExtension.
      > You can't map a property that does not exist: propertyName=testClassesDir

This patch disables the plugin since we are not typically checking coverage for old branches anyway.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

retest this please

retest this please


Nameless script file and weird behavior around script file generation

OS: Windows 7 64bit
Godot Version: 3.0 beta1
It's possible to make a script without name (".gd") in editor. I'm not sure this is a good thing.
Also I found some (unrelated) weird behavior while playing around this. This occurs whether a script has name or not:

Make a non-built-in script file in editor.
Manually remove the file in your file manager.
Make another script file with the same name.
Then Godot will make two scripts -- a script file you asked for and a nameless built-in script.

If you made the script via Attach Node Script dialogue, Godot will attach the built-in script to the node while seemingly ignoring the non-built-in one.
If you made the script via Script Editor, the built-in script goes nowhere. But you can save it manually as a file it seems.

I guess this behavior is so obscure that probably will bother nobody but I think it's worth reporting anyway.

@willnationsdev can you check this one?

Yeah, I'll look into it.

I haven't been able to recreate the other bug, so I am thinking that this Issue can be closed:
If you create a script BY attaching it to a Node in your scene, and THEN you delete the script from the project, the original copy of the GDScript text is deleted, but the node still has the script. To preserve the data, the Editor shifts to storing it as an inlined script in the scene. However, creating another script with the same name will never replace the code on the Node in the scene, so there is no perplexing movement of script data happening.

If you create the second script, anywhere, then it will simply make another script file, without affecting the built-in script. This is intended behavior.
If you click the "Attach Script" button with the built-in one already on the Node, the ScriptCreateDialog will give you an error when it validates the Inherits field, saying that the built-in script's name doesn't represent a valid inheritance path. Again, intended behavior.
The only way to switch the node's script around would be to manually remove the built-in script that was preserving the initial deletion for the script in the scene and then follow it up with manually attaching or creating the second script on the Node. Again, intended behavior.


Session question including provider accessToken

What are your thoughts on including something like this in the session object?
in session.js
const user = await getUser(session.userId)
const accounts = await getAccounts(session.userId);

        let providers = {}

        accounts.forEach(account => {
          providers[account.providerId] = {
            ...providers,
            accessToken: account.accessToken,
          }
        })

        // Only expose a limited subset of information to the client as needed
        // for presentation purposes (e.g. "you are logged in as…").
        //
        // @TODO Should support `async seralizeUser({ user, function })` style
        // middleware function to allow response to be customized.
        response = {
          user: {
            name: user.name,
            email: user.email,
            image: user.image
          },
          accessToken: session.accessToken,
          expires: session.sessionExpires,
          providers: providers
        }

``

Hey great question! Someone actually asked about that recently.
To support this without adding too much to the current session object, I've been planning endpoints similar to v1, to return linked accounts - and to explicitly link/unlink.
Example routes

GET /api/auth/accounts – Return JSON object (as above) for current user

GET /api/auth/link – Basically same as sign in page, but different wording on buttons
(e.g. would support routes like POST /api/auth/link/google to link)

GET /api/auth/unlink – Basically same as sign in page, but different wording on buttons
(e.g. would support routes like POST /api/authunlink/google to unlink)

NB: These pages would all require a user to already be signed in with a valid session.
I was planning on account linking in 2.1, to keep scope of 2.0 down. There isn't an issue to track this yet though! Would welcome any assistance here.

@iaincollins My use case may be different than most where I already have an identity provider that supports SSO and issues a JWT. I will only have one provider/maybe two, and the front end micro-service (next js) needs to talk to the ambassador API gateway. I thought maybe it makes sense to add an attribute to the provider that it allows it to come down in the session object. The session object would be small, which would not require another API call. I am happy to elaborate a little more on the use case if I need to.
 Providers.IdentityProvider({
      clientId: IDENTITYPROVIDER_ID,
      clientSecret: IDENTITYPROVIDER_SECRET,
      clientProviderAccessToken: true
    }),

I have been working on the /api/auth/refresh-token/provider endpoint. (Which should be ready soon)

Hmm I think probably adding support for a custom function as an option to NextAuth when creating the API route is probably the way to go for folks who want this in the session object, rather than adding an option to each provider.
That would give a lot of flexibility (for regular sessions and for JWT) with a single approach that should work for a lot of folks.  It sounds like the /api/auth/accounts endpoint would also meet this need for most people too. The plan is to add being able to specify middleware functions for signin and signout as well as session, so the convention would be easy to follow and consistent.
I envisage /api/auth/accounts  returning a list of all linked providers, each with access tokens and expiry times (and ultimately handling using the RefreshToken for each service to update the AccessToken for it when it expires).
There would  be a NextAuth.accounts() in the client to call this endpoint (the similar function in v1 was called linked()).
I am not sure I'd want to create something that exposed a RefreshToken to the front end though, I would probably not accept a patch for that as I don't want to create a footgun in a library that's intended to lower the barrier to adding authentication (but of course folks could create their own API endpoints that look up the session object and do that).
I'm interested to here more about the use case though.

@iaincollins  Thanks for taking the time to elaborate on your design.  Maybe it makes sense to jump on a call next week?  I like to help you push this project forward.
Can you give this code a glance? Provide any comments that you would change.
https://github.com/geraldnolan/next-auth/commit/d4c8f7cd03886f715814ec2bd7b8a334a160b647
I thought it would be nice to have comments in the DB based on the model, but I don't think that's an option of TypeORM, so I thought the next best thing is to put them in code?
** I haven't tested the softDelete on the user but I think it would be a nice feature.

A call would be great! I'm pretty busy during the day, but am free most days after 5 PM GMT (6PM BST, 7PM CEST), or at weekends. Feel free to reach out at<EMAIL_ADDRESS>Many thanks for your help in testing things out and reporting issues with recent changes!


Added reflection-free API for weak events

What does the pull request do?
Adds special WeakEvent type that's constructed from the usual event pattern and manages weak subscriptions for that particular event
What is the current behavior?
WeakSubscriptionManager and WeakEventHandlerManager both rely on reflection, which is not really compatible with trimming and performance

Visual and Pen will be updated in a separate PR.

You can test this PR using the following package version. 0.10.999-cibuild0017702-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 0.10.999-cibuild0017725-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


Video load refactoring

A much needed refactoring:

Added more Editor & Play Mode tests
Fixed issue with VimeoVideo not fetching lowest resolution properly
Decoupled Autoplay, Load, and Play logic. No longer hacks autoPlay
Playing a video will automatically try to load it first.
Removed LoadVimeoVideoById and LoadVimeoVideoByUrl and replaced with:

LoadVideo(string) and LoadVideo(int) which just load up the video, but not play (unless autoplay is on)
PlayVideo(string) and PlayVideo(int) which automatically load and play a video.

Added tests for AVPro Video and resolved issues with setup
Fixes #41

Also seems to be an issue with recording in 2017.1.4f1


Individual: Notification when switching roles from AC to CC or vice versa

When the individual user switches roles from AC to CC or vice versa, please add a warning notification at the top of the page that says: "Please review your profile. There is some information for your new role that you will have to fill in." [link to go to edit profile].

Causes error: https://flareapp.io/errors/2009969-foreach-argument-must-be-of-type-arrayobject-null-given/latest#F83


Multiplex tests based on MediaProduct arguments via @Parameterized

This reduces the code required per test. However, since some tests require a single MediaProduct while others require 2, I have refactored the current class to be specific to the former (since all of its current tests only use a single MediaProduct) and then we can have another class for the tests that will use two MediaProducts to avoid worthless (repeated) test runs.

The tests get too long when introducing the second MediaProduct while using this approach due to the combination of said MediaProduct lasting a minute and how many runs need to occur, so I'm closing this and just keeping the single MediaProduct variant as defined in the spec.


Create *.inspired.is-cool.dev.json

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.

Description

Rammerhead wildcard
Link to Website
*.inspired.is-cool.dev

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

48 hour warning before this ticket is closed for inactivity.


change default SOAP datatype to float64

Hello,
I started working with the refactored new versions 1.0.x  this week and found my perfect ML examples with SOAP descripters broke. lapack solver from sklearn complained and crashed for the optimal paramaters I had before. After spending quite some time investigating the issues I found the issue is casued by the change in default datatype in your soap routine  to "float32" conclusively.  Changing it to float64 again made the problem gone. I think I was lucky to have a problem in the right time to discover this crucial borderline issue which otherwise would have been hard to detect and diaganose.  I would strongly recommend to make the default datatype back to float64 and let the user decide if they want to change it to float32 to save memory.   As this choice potentiallly makes or brakes  your application.
Thanks.
Best Regards
Sandip

Hi @sandipde!
Thank you very much for bringing this up. You are right in that we should set float64 as the default for all descriptor values, since it is the safer option. I can do this as I add the dtype-parameter to other descriptors as well.

Now changed in 1.1.0.


avoid a race condition in Base58

Multiple simultaneous callers could initialize the same map from
different threads.
See @gabriel's https://keybase.atlassian.net/browse/CORE-2819.
r? @maxtaco

This one needs another look! A race is less likely but still possible
Thanks!

@patrickxb do you have time to take a look today, since @maxtaco is out?

looks safe to me :+1:

:+1:  Very go-y too

"goughy" :)


Property enabled doesn't accept a boolean value

In the documentation, you specify that the property enabled of a menu can accept a boolean value and a function :
enabled - [Function/Boolean] A function returning whether the option is enabled or not, or a boolean
But, when I define a boolean value, I obtain this stacktrace :
TypeError: item.enabled.call is not a function
    at isOptionEnabled (contextMenu.js:468)
    at processItem (contextMenu.js:136)
    at contextMenu.js:339
    at Object.forEach (angular.js:321)
    at renderContextMenu (contextMenu.js:318)
    at contextMenu.js:571

@josetaira, your fix doesn't work when item.enabled = false.
I checked the code and I have found the problem :
At line 140 : currItemParam.enabled = resolveBoolOrFunc(item.enabled || item[2], params);
If enabled is false, so item[2] is used as enabled value but it is undefined. So the true value is returned by the fonction.
I think, you must check if item.enabled is defined outside the resolveBoolOrFunc function. I propose this :
currItemParam.enabled = resolveBoolOrFunc(item.enabled !== undefined ? item.enabled : item[2], params);

My bad. This should be fixed in https://github.com/Templarian/ui.bootstrap.contextMenu/commit/2154df7f886aae9b16f8b5069db29e5455ada309
Thanks for testing it out!


Org profile picture

I'm guessing we can't just reuse the bazelbuild logo so we'll need some one to design something to have as our org profile picture.

@pcj has the wireframe version of the Bazel logo he has used for some of his products, maybe we could adopt that?

Since you'll want some sort of 'identity' for #28 docs pages, I doodled some letters from the org initials:

Or you could go wtih an odd abstract hybrid for something more compact:

Take it if you want it. I won't be offended if you don't. Colour scheme is flexible. Needs tidying. I'm sure the folded style has come from somewhere but I can't think where.

Works for me as a placeholder, I think it's better than the GitHub-generated one anyhow.

Here's the files with a proper export rather than a screen grab. Also I fixed the broken gradient on the left of the compact one
logo-inkscape.zip

Thanks, the transparency looks better too.


Publish 1.0.2 to Maven Central

Looks like 1.0.1 and 1.0.2 haven't made it to Maven Central.

Ack, forgot to sync bintray to maven central. should be up momentarily.

It looks like something got messed up with 1.0.2, so I've released 1.0.3 and updated the documentation accordingly. Thanks.


Change to-toml to no longer use .perl

This resulted in incorrect TOML when used with an email address, as it
would escape the @ inside the string.

Thanks.


[DRAFT] Support for MID360 cpu/gpu based simulation

tbd

sorry, opened the PR in the wrong repo, want to merge it in our fork first :)


Pre-1.11 versions do not set --apiserver-count with --endpoint-reconciler-type master-count

While 1.11 changed the reconciler type to lease from master-count, previous supported versions need to have --apiserver-count set to the number of kubernetes-master units.
https://github.com/kubernetes/kubernetes/blame/master/CHANGELOG-1.11.md#L417
https://github.com/kubernetes/kubernetes/pull/63383
Otherwise 2 or more masters are not aware of each other and are in conflict for making changes to etcd state.
https://github.com/kubernetes/kubernetes/issues/24327#issue-148618205
https://github.com/kubernetes/website/pull/6695/commits/97c9d23e30e49cad2c763706a873274f1230b1c8#diff-f1740b3dc59376d8eeb5d86fbb755bb6R207

"If you do not add the --apiserver-count flag, the value defaults to 1. Your cluster will work correctly, but each apiserver replica will continuously try to add itself to the list of endpoints while removing the other ones, causing a lot of extraneous updates in kube-proxy and other components."

Here are the options:

No code changes, document workaround

At this point we only support 1.9 - 1.11, and 1.11 is fixed, so in 2 releases this problem will phase itself out
The misconfiguration is wasteful in that it generates extra traffic and etcd activity in the cluster, but not catastrophic (does not cause data loss or corruption). The impact is minimal enough that the problem itself has gone largely unnoticed until now.
For those who do care, we will document the workaround, which is to set kube-api-extra-args appropriatly via charm config.
This is the quickest and easiest option.

Add a peer-relation so we can count the number of units

Adds complexity for an issue that no longer exists in Kubernetes.
Time-consuming - requires new code and testing

Use goal-state to determine the number of units

Requires juju >= 2.4
Feels like a tiny subset of older Kubernetes installations would have newest juju
Have to wait and monitor number of units to catch additions/removals

Set reconciler to lease for older Kubernetes.

Easy to do and quick
Lease reconciler wasn’t bug-free back then

workaround would be
juju config kubernetes-master api-extra-args="apiserver-count=<number of kubernetes master units>"

For new installations we would go for 1.11 anyway, however, if 1 is the easiest option for pre-1.11 it needs to be communicated through support channels and documented until 1.9 and 1.10 go EoL.

1.9 and 1.10 are EoL now.


Librealsense cannot Cmake for building files

| Camera Model                       | { D400 } |
| Firmware Version                   | (Open RealSense Viewer --> Click info) |
| Operating System & Version |   Linux (Ubuntu 16) |
| Kernel Version (Linux Only)    |  (e.g. 4.14.13)                                         |
| Platform                                 | PC  |
| SDK Version                            |  { librealsense2 }                          |
| Language                            |  {C/C#/labview/nodejs/opencv/pcl/python/unity }                          |
| Segment			|  {Robot/Smartphone/VR/AR/others }                          |
Issue Description
Hello,
When I want to CMAKE in the librealsense source folder, I got the following error:
-- The CXX compiler identification is GNU 5.4.0
-- The C compiler identification is GNU 5.4.0
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Info: REALSENSE_VERSION_STRING=2.16.5
-- Performing Test COMPILER_SUPPORTS_CXX11
-- Performing Test COMPILER_SUPPORTS_CXX11 - Success
-- Performing Test COMPILER_SUPPORTS_CXX0X
-- Performing Test COMPILER_SUPPORTS_CXX0X - Success
-- Setting Unix configurations
-- Checking internet connection...
-- Internet connection identified, enabling BUILD_WITH_TM2
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")
-- Checking for one of the modules 'libusb-1.0'
-- Found OpenGL: /usr/lib/x86_64-linux-gnu/libGL.so
-- Checking for module 'gtk+-3.0'
--   Found gtk+-3.0, version 3.18.9
-- Building with TM2

-- Product versions:
-- - HOST <IP_ADDRESS>5 (Default from versions.cmake)
-- - Remote FW <IP_ADDRESS>52 (Default from versions.cmake)
-- - Remote CENTRAL APP <IP_ADDRESS>9 (Default from versions.cmake)
-- - Remote CENTRAL BL <IP_ADDRESS> (Default from versions.cmake)

-- Downloading FW <IP_ADDRESS>52 from 'http://realsense-hw-public.s3.amazonaws.com/Releases/TM2/FW/target/<IP_ADDRESS>52/target-<IP_ADDRESS>52.mvcmd'
^[[A^[[A^[[B^[[B-- Downloading FW <IP_ADDRESS>52 completed - status 28;"Timeout was reached"
CMake Error at third-party/libtm/resources/CMakeLists.txt:92 (message):
Download error
http://realsense-hw-public.s3.amazonaws.com/Releases/TM2/FW/target/<IP_ADDRESS>52/target-<IP_ADDRESS>52.mvcmd
-- Configuring incomplete, errors occurred!
See also "/home/mgs/librealsense/build/CMakeFiles/CMakeOutput.log"
I checked the Internet setting and everything is fine. Thanks.

hey @Yaosirrr @. I followed the guidance #2767 issue to solve this problem. Hope it helps.

What should I do? #2767 is just this issue.


Analyzer does not resolve comment reference with generics

Analyzer is unable to resolve a reference in a comment of the form
/// This is a reference to [List<int>]

Blocking https://github.com/dart-lang/dartdoc/issues/99

Still an issue I'd love solved.


PWA-256 prices are not aligned

Pull Request Test Coverage Report for Build 1173

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 44.338%

Totals

Change from base Build 1170:
0.0%

Covered Lines:
1856

Relevant Lines:
4030

💛  - Coveralls


Move to org

This project should live under an org to ease maintenance and increase the busfactor.

This is something that the team will solve internally by now. We'll keep the repo updated with any news regarding that.


WIP: Docs fixes arising from testing the local deployment workflow for mobile.

Description
Docs fixes arising from testing the local deployment workflow for mobile.
Tests
I manually executed these steps as a customer would, and I rendered all altered pages in improbadoc.
Documentation
This is documentation.
Primary reviewers
@jessicafalk

The buildkite failues on this branch are because the test script it's looking for does not exist on docs/improbadoc-conversion, where this was forked from. It sucks and we should fix it by not using docs/improbadoc-conversion, but it's not a blocker.


Photo can't be overlayed on SwiftyCamViewController

Trying to overlay the resulting photo from func swiftyCam(_ swiftyCam: SwiftyCamViewController, didTake photo: UIImage) {} method and it's failing. The photo object is returned but can't be placed in an imageHolder on top of the previewLayer. Have tried async and calling the method after a specific delay. Can this be achieved?

@TheSwiftyCoder Not sure I understand the exact issue here, can you submit upload a project somewhere that reproduces this issue?