When people join after the bot sometimes they cant hear it.

i love this been using for it ages, only an issue when people join sometimes they can't hear the sound from the bot. The fix i've found to it is leave and join back with the bot by joining none on the channels list then rejoining the voice chat
Theres no solid way to reproduce it which is also what makes it annoying because its so random.
Friend joins VC after the bot and they cant hear it.
Error log
next time it happens i will update this bit.
System Info

Windows 11
Python or Executable - i dont know
v2.3

Also would be really useful if you could add an option for preset servers and preset audio devices as another .exe - because i use the same server and same audio input every time so its a little bit tedious picking the server, channel and audio device.

ive only just realised someone else already reported this


Cross-build for Scala 2.12

fixes #23

Thanks a lot!

Please release build with 2.12 support.

@jastice any plans to release this 2.12 build?

@twistedpair I'll try to get around to it this weekend. If somebody is willing to take care of it more regularly, please let me know and I'll add you to the org.

@jastice Any chances for release?

I'm a bit late, but... there's continuous releases to bintray for now:
https://bintray.com/jastice/maven/scredis/
resolvers += Resolver.bintrayIvyRepo("jastice","maven")
libraryDependencies += "com.github.scredis" %% "scredis" % "<version>"


URL_PATH not working on breadcrumbs HOME link

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

1.URL_PATH not showing on Breadcrumbs as pic shows when in settings page.
2.a JS erro showing in web console in home page.
ENV:
VIRTUAL_HOST=te.xxxx.cn
URL_PATH=/test
Expected Behavior
click on HOME go to https://te.xxxx.cn/test .
Steps To Reproduce
1.go to Settings page.
2.click/hover on home instead of Teslamate logo on Navi
Relevant log output
teslamate-1  | 2024-05-22 13:47:08.481 [info] Migrations already up
teslamate-1  | 2024-05-22 13:47:10.423 [info] No tzdata release files found in custom data dir. Copying release file from tzdata priv dir.
teslamate-1  | 2024-05-22 13:47:10.524 [info] System Info: Erlang/OTP 26 (jit)
teslamate-1  | 2024-05-22 13:47:10.524 [info] Version: 1.29.1
teslamate-1  | 2024-05-22 13:47:10.810 [info] POST https://auth.tesla.cn/oauth2/v3/token -> 200 (263.530 ms)
teslamate-1  | 2024-05-22 13:47:10.810 [info] Refreshed api tokens
teslamate-1  | 2024-05-22 13:47:10.814 [info] Scheduling token refresh in 6 h
teslamate-1  | 2024-05-22 13:47:10.818 [info] Running TeslaMateWeb.Endpoint with cowboy 2.10.0 at :::4000 (http)
teslamate-1  | 2024-05-22 13:47:10.819 [info] Access TeslaMateWeb.Endpoint at http://te.xxxx.cn
teslamate-1  | 2024-05-22 13:47:11.327 [info] Starting logger for 'xxxx'

Screenshots

Additional data
No response
Type of installation
Docker
Version
v1.29.1

Do your URL settings match your environment configuration?

Do your URL settings match your environment configuration?

YES.

Does this also happen on the Geofence page?

Does this also happen on the Geofence page?
yes.

and as mentioned before, a javascript erro showed in web console but no erro showed in geofence or settings page.

@brianmay @jlestel - are either of you proficient in Elixir by chance? I believe the following lines for both settings and geo fences is the root of the issue.
Settings https://github.com/teslamate-org/teslamate/blob/31cdaac395aa0ad0d59f764d34fb01899c838ce8/lib/teslamate_web/live/settings_live/index.html.heex#L3
Geo-fences
https://github.com/teslamate-org/teslamate/blob/31cdaac395aa0ad0d59f764d34fb01899c838ce8/lib/teslamate_web/live/geofence_live/index.html.heex#L3
Both codes reference / to go home. But that does not respect if the user has a subfolder configured. Or maybe it should be handled in the users Docker configure since it is in the environment.
Speculating here, but seeking further guidance. Thanks.

I am a bit vague here apologies if I got this wrong:
I think the problem is live_redirect just uses the URL we supply it "as is". We give it a URL of "/", so that is what gets used.
Rather you need to pass it the full path returned by the appropriate helper function, e.g. here is an example I copied from some range page:
<%= live_redirect String.capitalize("#{city}") , to: Routes.energy_raters_path(@socket, :show, city) %>

Obviously you need to use the appropriate helper function.
In addition, recent versions of Pheonix support compile time checking of routes - called verified routes. I don't think TeslaMate uses these at present, but I think they are probably worth it. See links such as https://elixircasts.io/phoenix-verified-routes and https://hexdocs.pm/phoenix/routing.html#verified-routes
I am assuming this should also expand to the correct thing (not checked).

I am a bit vague here apologies if I got this wrong:
I think the problem is live_redirect just uses the URL we supply it "as is". We give it a URL of "/", so that is what gets used.
Rather you need to pass it the full path returned by the appropriate helper function, e.g. here is an example I copied from some range page:
<%= live_redirect String.capitalize("#{city}") , to: Routes.energy_raters_path(@socket, :show, city) %>

Obviously you need to use the appropriate helper function.
In addition, recent versions of Pheonix support compile time checking of routes - called verified routes. I don't think TeslaMate uses these at present, but I think they are probably worth it. See links such as https://elixircasts.io/phoenix-verified-routes and https://hexdocs.pm/phoenix/routing.html#verified-routes
I am assuming this should also expand to the correct thing (not checked).

I do believe you are spot on @brianmay, but I do not know Elixir or Phoenix well enough to know a resolution. @swiffer is this an area you are aware of and or can propose a fix?

@b1c1l1 Can you please take a look into this, as it is related to your PR #3771. Ty.

In addition, recent versions of Pheonix support compile time checking of routes - called verified routes. I don't think TeslaMate uses these at present

I do think we already use it: https://github.com/teslamate-org/teslamate/blob/63b76779e6d2b59e7e839e550017b8004e9acf29/lib/teslamate_web.ex#L106

I don't have a lot of time right now, but I imagine something like this should work:
diff --git a/lib/teslamate_web/live/charge_live/cost.html.heex b/lib/teslamate_web/live/charge_live/cost.html.heex
index f40b23e7..0c15e8b4 100644
--- a/lib/teslamate_web/live/charge_live/cost.html.heex
+++ b/lib/teslamate_web/live/charge_live/cost.html.heex
@@ -1,6 +1,6 @@

-
<%= live_redirect(gettext("Home"), to: "/") %>

+
<%= live_redirect(gettext("Home"), to: ~p"/") %>

<%= live_redirect(gettext("Charge Cost"), to: "") %>

diff --git a/lib/teslamate_web/live/geofence_live/form.html.heex b/lib/teslamate_web/live/geofence_live/form.html.heex
index 17baeddd..245c84c8 100644
--- a/lib/teslamate_web/live/geofence_live/form.html.heex
+++ b/lib/teslamate_web/live/geofence_live/form.html.heex
@@ -1,7 +1,7 @@

-
<%= live_redirect(gettext("Home"), to: "/") %>

-
<%= live_redirect(gettext("Geo-Fences"), to: "/geo-fences") %>

+
<%= live_redirect(gettext("Home"), to: ~p"/") %>

+
<%= live_redirect(gettext("Geo-Fences"), to: ~p"/geo-fences") %>

         <%= case @action do
diff --git a/lib/teslamate_web/live/geofence_live/index.html.heex b/lib/teslamate_web/live/geofence_live/index.html.heex
index 8bad39d5..0e7e026b 100644
--- a/lib/teslamate_web/live/geofence_live/index.html.heex
+++ b/lib/teslamate_web/live/geofence_live/index.html.heex
@@ -1,7 +1,7 @@

-
<%= live_redirect(gettext("Home"), to: "/") %>

-
<%= live_redirect(gettext("Geo-Fences"), to: "/geo-fences") %>

+
<%= live_redirect(gettext("Home"), to: ~p"/") %>

+
<%= live_redirect(gettext("Geo-Fences"), to: ~p"/geo-fences") %>

diff --git a/lib/teslamate_web/live/import_live/index.html.heex b/lib/teslamate_web/live/import_live/index.html.heex
index f1becf81..2e398dc8 100644
--- a/lib/teslamate_web/live/import_live/index.html.heex
+++ b/lib/teslamate_web/live/import_live/index.html.heex
@@ -1,6 +1,6 @@

-
<%= live_redirect(gettext("Home"), to: "/") %>

+
<%= live_redirect(gettext("Home"), to: ~p"/") %>

<%= live_redirect(gettext("TeslaFi Import"), to: "") %>

diff --git a/lib/teslamate_web/live/settings_live/index.html.heex b/lib/teslamate_web/live/settings_live/index.html.heex
index 41715530..30d97a27 100644
--- a/lib/teslamate_web/live/settings_live/index.html.heex
+++ b/lib/teslamate_web/live/settings_live/index.html.heex
@@ -1,7 +1,7 @@

-
<%= live_redirect(gettext("Home"), to: "/") %>

-
<%= live_redirect(gettext("Settings"), to: "/settings") %>

+
<%= live_redirect(gettext("Home"), to: ~p"/") %>

+
<%= live_redirect(gettext("Settings"), to: ~p"/settings") %>

Did I miss anything?
Ideally old links that look like Routes.live_path(@conn, TeslaMateWeb.SettingsLive.Index) would be replaced by something like ~p"/settings" but that isn't important as far as this bug is concerned.

Did I miss anything?

I have not found any other places either. I opened #4052


OData entity schema missing version and conflict properties

Bug noticed by QA:
"! DataSource.Error: Data: The property 'version' does not exist on
type 'org.opendatakit.entity.metadata'. Make sure to only use property names that are defined by the type or mark the type as open type."

version probably needs to be come __version in the __system object
For .5, we’ll also need to update the schema to add the conflict property.

It's also missing the __system/conflict property.

version probably needs to be come __version in the __system object

I don't think the name of the property needs to change (it's already part of an __ property). If it did change, then Frontend would have to change as well.


apphook docs talk about mptt

The apphook docs talk about mptt: http://docs.django-cms.org/en/develop/how_to/apphooks.html
Does that make sense? As I understood it, the project does not use mptt anymore.

Well that's actually an example on how to create a category model which happens to use mptt. It's not related to the cms itself. But I agree that we can better move the example to treebeard

Oh sure.. just saw that now. Thanks for the clarification. This issue is fixed. :)

AFAIK @evildmp is working on some additional clarifications there.


Runtime CR examples updated

Description
Changes proposed in this pull request:

Exemplary Runtime CR yamls fixed
Status condition contains detailed error message from Gardener (temporary solution, in the future we must provide error category in the CR's status)

Related issue(s)
#332

I've managed to test succesfully the examples for

aws-freemium
azure-lite ( I had to do this change in order to make it work)
gcp

Azure, GCP and CCEE contains additionalOidcConfig: sections while other examples do not. Is it intentional?

The following yamls : aws, azure, gcp, sap-converged-cloud are supposed to contain all the fields that KEB can specify. Examples prefixed with trial, freemium, lite, or minimal are supposed to be smaller so they doesn't contain additionalOidcConfig section on purpose.


NavigationBar control

https://api.flutter.dev/flutter/material/NavigationBar-class.html

https://pub.dev/packages/circular_bottom_navigation
Interesting..


[Feature request] Creative Inv

The creative inventory is a mess with the new blocks. Sorting the modded items with vanilla items (e.g. putting the Azalea boats next to the other boat types, etc) and perhaps making a seperate creative tab with the modded items would be nice.

I don't want to create new tab, because i want the mod to feel as much vanila as possible, but i will look into sorting the items.

Fair enough ig


Use public registry.

Since Ember 2.1 registry is public.
See emberjs/ember.js#11440.
Closes #141

:beers:


[Suggestion] Add notation to output dice in ascending numerical order rather than "as they are rolled"

Several games using die pools - most urgent for me being Exalted 3rd Edition - run on die pools of d10s where 7 and up are successes but 10 counts as 2. Adding additional notation to the end of the normal Xd10>=7 notation to define this behavior would make rolls excessively tedious.
Other games I play use a system called "One Roll Engine" where matching dice is significant with no significance at all to the sum of the roll or values above a given number. For example, out of 10d10, it may be significant if a user rolls three 8s, but there's no significance at all to the lone 10 or the lone 1 in the roll.
In both cases, the ideal behavior would be to be able to define a die pool of a given size, with dice of given shape, and simply have the results displayed in ascending order of die value with no sum given at the end. Perhaps the output could introduce a mark such as | at regular intervals to make it easier to manually count up the results.
Notation-wise, I think using "a" as a suffix could work. For example, "/roll 20d10a" could result in "@Username: 20d10a = (1, 1, 2, 3, 3 | 4, 4, 4, 5, 5 | 5, 5, 6, 7, 9 | 9, 9, 9, 10, 10)
This way users that care about counting up successes can count them up starting at whichever value is relevant for their system (as well as handle things like certain values counting for more than others), and users that care about matched sets can easily spot them in the output as well.

Roll20 does something similar but their syntax is s (sort ascending) and sd (sort descending) so it would look like /r 20d10s

:+1: need this for OVA to more easily sum multiples, where the total sum isn't used. i'm not sure a divider is necessary, though.


Question regarding the scdata dataset

Hi! Thank you so much for this very useful tool!
I have a question regarding the scdata object provided as an example dataset. It contains bc_patient and bc_cluster where each individual cell is labelled according to its barcode. May I know how these two lists can be added to the immunarch object please? I would like to do something similar with my Seurat clusters, and add cluster information (according to barcode) to my immunarch object.
Thank you!
Samuel

Would also be very interested in clarification on this :)
Appreciate it!
Best Niklas

Hi just wondering if this was addressed, I have the same needs.
Thanks!
Leeana

Hi all, nope this hasn't been answered! Please could someone help us? Thank you!!

大家好，不，这还没有得到回答！请问有人可以帮助我们吗？谢谢！！

Can this link help you?
https://immunarch.com/articles/web_only/v21_singlecell.html

Closing this issue for now. It will be implemented in the next version of Immunarch.
More details on the next version of Immunarch are here: https://b-t.cr/t/immunarch-will-significantly-evolve-but-it-will-break-things-and-we-need-your-help/1123


Add logging for events

In many cases, event messages are one of the main parts of debugging. So I'm proposing a new flag that logs the events received by the informer to stdout.

@nabokihms Hi!
I've looked and fixed all your suggestions and move event log only for "debug" log-level

Also, I've hardcode json-formatted log style

There are a couple of things to do to release a new chart, but I think I can do it myself. Besides it, LGTM!


Default text in search box

Since the node search API only searches identifier and name fields in a Node now, the default text in search box probably should be identifier or name instead of id, name, or metanode:

Closed by https://github.com/greenelab/hetmech-frontend/pull/92


BBG --> USAGM

Broadcasting Board of Governors changed their agency name to the 'United States Agency for Global Media'.

Fiddlesticks!  This repo must be skeletonized before the tests can run.  TravisCI is no longer as free as it once was.
I vote that we un-require the tests until #50 can be resolved.

I vote that we un-require the tests until #50 can be resolved.

Seconded!

I removed the TravisCI check requirement for now.


Editing/Cancel environment from details page takes me back to list page

Version - v1.0.0
Steps to Reproduce:

Go to Manage Environments
Add an Environment
Click on environment to get to details page
Click on Edit from menu
Click on Save or Cancel

Results: Takes me back to list view
Expected: Take me back to details page

@tfiduccia can we close this? Its not a valid scenario anymore. Env details is no more.

Version - console 7/5
No details page for environment anymore


NodeJS Bindings: Add JS Implementation for i2c.

This provides the implementation for i2c JavaScript bindings
based on the Soletta i2c API.
Replaces #1913
Signed-off-by: Sudarsana Nagineni<EMAIL_ADDRESS>Signed-off-by: Srinivasa Ragavan<EMAIL_ADDRESS>

Nit fix: Renamed output buffer to input buffer in the write callbacks.
@edersondisouza Could you please have a final look and merge this? Thanks!

lgtm


Implement git diff support (i.e. hunk start with content on same line)

This is related to issue #2

thanks for the contribution. I will release a new version with this fix shortly

new version 1.4 with that change is now released. took a little longer since I was playing around with different release mechanisms :). note that in the new version the package org.wickedsource has been replaced with io.reflectoring since the old domain is no longer valid.


Insert a row at a specific position in google sheet

Hi @theoephraim , I wanted to inserted a row at specific position (row number A,B,C,etc) in the sheet using add row function. I guess it always appends the row after the last filled row.

The addRows function internally uses sheets API append functionality which really is looking for a "table" of data  within you sheet and then appending to the end, so unfortunately it wouldnt work.
Looks like to add rows in the middle of the existing data, you'd need to use the insertDimension api endpoint which I have not yet implemented.
PRs welcome!

Sure , I'll try to find a solution for this. I was able to get a workaround to this problem some time ago for implementation in a project. I'll try to revisit this thing in some days.

@theoephraim  , #428 Seems to have added insertDimension.


Rely on index checksum for HelmRepository reconcile operation

Fixes #256

Should be ready to merge, sorry for all the back and forth. ;)

Should be ready to merge, sorry for all the back and forth. ;)


handle non ascii classpath with system classloader

fixes #1194 fixes #1222
Note that the encoding problem appears to effect anything that isn't ascii. I tested the ParseUtil with the unicode_à😎 right in Java code (utf-8) and it didn't encode the url correctly.

I'm not sure what the deal is with the remaining tests.

I will give it a look though it is looking like Wednesday at best.  Lost 16 hours to a network problem 4 days before my critical project demo. So I have a heavy workload this weekend.

I will give it a look though it is looking like Wednesday at best. Lost 16 hours to a network problem 4 days before my critical project demo. So I have a heavy workload this weekend.

I wish you best of strength and endurance, and of course a good demo! I will have a look as wel. Maybe we can sort this out already.

@astrelsky I turned on trace logging of all JVM subsystems and stumbled upon this one:
[0.459s][info   ][exceptions             ] Exception <a 'java/io/FileNotFoundException'{0x000000008ba44ca8}: /workspaces/jpype/test/test/classes;test/jar/late/late.jar>
This actually looks like the paths are not properly being split prior passing it to open(), what do you think?

@astrelsky I turned on trace logging of all JVM subsystems and stumbled upon this one:
[0.459s][info   ][exceptions             ] Exception <a 'java/io/FileNotFoundException'{0x000000008ba44ca8}: /workspaces/jpype/test/test/classes;test/jar/late/late.jar>
This actually looks like the paths are not properly being split prior passing it to open(), what do you think?
It is also confusing that a semicolon is used as path separator on Linux, right? It should be a colon!

Oh, that's interesting.  I must have copied the classpath from the testAddClassPath run and not seen the semicolon when setting the arguments in the new test.
But now, how could the mac tests have passed? As far as I know windows is the outlier and the only one that uses ;.

Maybe the mac did something clever - I cannot tell, dont use that stuff. Thanks for fixing it!
@Thrameos does this solution fit our needs?

Is this ready to go?

Is this ready to go?

Yes. Services work as expected so I think everything is good if you don't have any other objections.

Thanks for the hard work on this.  I will trigger test and release scripts in my next open session.

Thanks for the hard work on this.  I will trigger test and release scripts in my next open session.

Sounds good, thank you.

@Thrameos I don't mean to be a pain but would #1224 be included? I only ask because without it building it in free threaded mode will fail with a compile error or unexpectedly build the normal gil mode wheel.

Sure I see no reason to exclude it.


opam depext wants deprecated openblas package on os x

homebrew says: Use openblas instead of deprecated homebrew/science/openblas

Thanks! Yes-- I noticed this yesterday in fact :) I have a PR in to opam-repository to update conf-openblas to fix this, see https://github.com/ocaml/opam-repository/pull/11804


Remove version: CrystalDewWorld.CrystalDiskInfo.ShizukuEdition version 9.4.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: Duplicate;


After deleting mqAdminExt subscriptionGroup,Again Automatically creating same Group

I'm using RocketMQ with c#. After deleteSubscriptionGroup from mqAdminExt, again automatically creating the group with the same name whatever I deleted.
Here is the code:
public class Test {
 public DefaultMQProducer _producer;
 public DefaultMQAdminExt rocketMqAdmin;
 public DefaultMQPushConsumer _consumer;
 public WebSocket websocket;

 string tag = "4-0-00-00-000-0000-456";
 string NameServeruri = "localhost:9876";
 string consumerId = tag + "-Sessions-Consumer";

 onServicStart() {

  var adminId = this.Context.NodeContext.NodeName + "-rocketmqAdmin";
  rocketMqAdmin = new DefaultMQAdminExt(adminId);
  rocketMqAdmin.start();

  var producerId = this.GetType().Name.ToString() + "-" + this.Context.NodeContext.NodeName + "-Producer";
  _producer = new DefaultMQProducer(producerId);
  _producer.setNamesrvAddr(RocketMQBaseURL);
  _producer.start();

 }

 consumer() {
  _consumer = new DefaultMQPushConsumer(consumerId);
  _consumer.setNamesrvAddr(NameServeruri);
  _consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_LAST_OFFSET);
  _consumer.subscribe(topic, tag);

  MQMessageListener listener = new MQMessageListener(websocket, tag);
  _consumer.registerMessageListener(listener);
  _consumer.start();
 }

 remove() {
  DefaultMQPushConsumer consumer = _consumer;
  consumer.shutdown();

  var id = tag + "-Sessions-Consumer";
  rocketMqAdmin.deleteSubscriptionGroup(RocketMQBrokerURL, id);
 }
}

below are the broker logs:

2018-06-20 13:38:11 INFO BrokerControllerScheduledThread1 - register broker to name server localhost:9876 OK
2018-06-20 13:38:41 INFO BrokerControllerScheduledThread1 - register broker to name server localhost:9876 OK
2018-06-20 13:38:58 INFO ClientManageThread_6 - auto create a subscription group, SubscriptionGroupConfig [groupName=4-46e7-911f-913ec76bdb17-Sessions-Consumer, consumeEnable=true, consumeFromMinEnable=true, consumeBroadcastEnable=true, retryQueueNums=1, retryMaxTimes=16, brokerId=0, whichBrokerWhenConsumeSlowly=1, notifyConsumerIdsChangedEnable=true]
2018-06-20 13:38:58 INFO ClientManageThread_6 - create new topic TopicConfig [topicName=%RETRY%4-46e7-911f-913ec76bdb17-Sessions-Consumer, readQueueNums=1, writeQueueNums=1, perm=RW-, topicFilterType=SINGLE_TAG, topicSysFlag=0, order=false]
2018-06-20 13:38:58 INFO ClientManageThread_6 - register broker to name server localhost:9876 OK
2018-06-20 13:38:58 INFO ClientManageThread_6 - new consumer connected, group: 4-46e7-911f-913ec76bdb17-Sessions-Consumer CONSUME_PASSIVELY CLUSTERING channel: ClientChannelInfo [channel=[id: 0x2aa59625, L:/<IP_ADDRESS>:10911 - R:/<IP_ADDRESS>:63488], clientId=<IP_ADDRESS>@30892, language=JAVA, version=252, lastUpdateTimestamp=1529473138639]
2018-06-20 13:38:58 INFO ClientManageThread_6 - subscription changed, add new topic, group: 4-46e7-911f-913ec76bdb17-Sessions-Consumer SubscriptionData [classFilterMode=false, topic=%RETRY%4-46e7-911f-913ec76bdb17-Sessions-Consumer, subString=, tagsSet=[], codeSet=[], subVersion=1529473138565, expressionType=null]
2018-06-20 13:38:58 INFO ClientManageThread_6 - subscription changed, add new topic, group: 4-46e7-911f-913ec76bdb17-Sessions-Consumer SubscriptionData [classFilterMode=false, topic=251122b1-fec6-491d-969a-44a87138fc21, subString=4-46e7-911f-913ec76bdb17, tagsSet=[4-46e7-911f-913ec76bdb17], codeSet=[-487735314], subVersion=1529473138531, expressionType=null]
2018-06-20 13:38:58 INFO ClientManageThread_6 - registerConsumer info changed ConsumerData [groupName=4-46e7-911f-913ec76bdb17-Sessions-Consumer, consumeType=CONSUME_PASSIVELY, messageModel=CLUSTERING, consumeFromWhere=CONSUME_FROM_LAST_OFFSET, unitMode=false, subscriptionDataSet=[SubscriptionData [classFilterMode=false, topic=%RETRY%4-46e7-911f-913ec76bdb17-Sessions-Consumer, subString=, tagsSet=[], codeSet=[], subVersion=1529473138565, expressionType=null], SubscriptionData [classFilterMode=false, topic=251122b1-fec6-491d-969a-44a87138fc21, subString=4-46e7-911f-913ec76bdb17, tagsSet=[4-46e7-911f-913ec76bdb17], codeSet=[-487735314], subVersion=1529473138531, expressionType=null]]] <IP_ADDRESS>:63488
2018-06-20 13:38:58 INFO ClientManageThread_7 - subscription changed, group: 4-46e7-911f-913ec76bdb17-Sessions-Consumer OLD: SubscriptionData [classFilterMode=false, topic=%RETRY%4-46e7-911f-913ec76bdb17-Sessions-Consumer, subString=, tagsSet=[], codeSet=[], subVersion=1529473138565, expressionType=null] NEW: SubscriptionData [classFilterMode=false, topic=%RETRY%4-46e7-911f-913ec76bdb17-Sessions-Consumer, subString=, tagsSet=[], codeSet=[], subVersion=1529473138787, expressionType=null]
2018-06-20 13:39:10 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 0 bytes
2018-06-20 13:39:10 INFO BrokerControllerScheduledThread1 - Slave fall behind master: 0 bytes
2018-06-20 13:39:11 INFO BrokerControllerScheduledThread1 - register broker to name server localhost:9876 OK
2018-06-20 13:39:41 INFO BrokerControllerScheduledThread1 - register broker to name server localhost:9876 OK
2018-06-20 13:40:07 INFO ClientManageThread_22 - unregister a consumer[4-46e7-911f-913ec76bdb17-Sessions-Consumer] from consumerGroupInfo ClientChannelInfo [channel=[id: 0x2aa59625, L:/<IP_ADDRESS>:10911 - R:/<IP_ADDRESS>:63488], clientId=<IP_ADDRESS>@30892, language=JAVA, version=252, lastUpdateTimestamp=1529473204921]
2018-06-20 13:40:07 INFO ClientManageThread_22 - unregister consumer ok, no any connection, and remove consumer group, 4-46e7-911f-913ec76bdb17-Sessions-Consumer
2018-06-20 13:40:07 INFO AdminBrokerThread_8 - deleteSubscriptionGroup called by <IP_ADDRESS>:50735
2018-06-20 13:40:07 INFO AdminBrokerThread_8 - delete subscription group OK, subscription group:SubscriptionGroupConfig [groupName=4-46e7-911f-913ec76bdb17-Sessions-Consumer, consumeEnable=true, consumeFromMinEnable=true, consumeBroadcastEnable=true, retryQueueNums=1, retryMaxTimes=16, brokerId=0, whichBrokerWhenConsumeSlowly=1, notifyConsumerIdsChangedEnable=true]
2018-06-20 13:40:10 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 0 bytes
2018-06-20 13:40:10 INFO BrokerControllerScheduledThread1 - Slave fall behind master: 0 bytes
2018-06-20 13:40:11 INFO BrokerControllerScheduledThread1 - register broker to name server localhost:9876 OK
2018-06-20 13:40:21 INFO PullMessageThread_8 - auto create a subscription group, SubscriptionGroupConfig [groupName=4-46e7-911f-913ec76bdb17-Sessions-Consumer, consumeEnable=true, consumeFromMinEnable=true, consumeBroadcastEnable=true, retryQueueNums=1, retryMaxTimes=16, brokerId=0, whichBrokerWhenConsumeSlowly=1, notifyConsumerIdsChangedEnable=true]
2018-06-20 13:40:21 WARN PullMessageThread_8 - The consumer's group info not exist, group: 4-46e7-911f-913ec76bdb17-Sessions-Consumer

But while deleting from RocketMQ console it working properly and also unregister producer group from channelTableInfo and not calling PullMessageThread auto create.But in case of c# above code AdminExt with PullMessage Thread auto create also calling.
Any help.

@lizhanhui

I'd like to help but here are two issues to clarify first.

Can you provide the version of C# SDK? Best if you could give a git hash.
Your log looks inconsistent with your code.  Can you renew your log output thereafter?

1.Actually i am not using .Net SDk for RocketMQ.
I have used IKVM to convert rocketmq-4.2 jars in Dll.
Before i used rocketmq-client-4.2.0-incubating.dll, rocketmq-common-4.2.0-incubating.dll, rocketmq-remoting-4.2.0-incubating.dll for producer and consumer client code.
For delete topics and subscription group, used rocketmq-tools-4.2.0-incubating.dll.
As client and common are present in tools dll, so currently using only remoting and tools dll.
(All dlls were converted from jars. Because i started working on rocketMQ almost 2017 octobar.And that time i faced many issues(some functionality missing) in .Net SDK).
Can you tell me that currently .Net SDk has all the support same as java liabrary? Then i will try with .Net SDK.Because i am facing new issue in .Net core when using IKVM.
2.When remove() method is invoke in my code below is the log for that
2018-06-20 13:40:07 INFO ClientManageThread_22 - unregister a consumer[4-46e7-911f-913ec76bdb17-Sessions-Consumer] from consumerGroupInfo ClientChannelInfo [channel=[id: 0x2aa59625, L:/<IP_ADDRESS>:10911 - R:/<IP_ADDRESS>:63488], clientId=<IP_ADDRESS>@30892, language=JAVA, version=252, lastUpdateTimestamp=1529473204921]
2018-06-20 13:40:07 INFO ClientManageThread_22 - unregister consumer ok, no any connection, and remove consumer group, 4-46e7-911f-913ec76bdb17-Sessions-Consumer
2018-06-20 13:40:07 INFO AdminBrokerThread_8 - deleteSubscriptionGroup called by <IP_ADDRESS>:50735
2018-06-20 13:40:07 INFO AdminBrokerThread_8 - delete subscription group OK, subscription group:SubscriptionGroupConfig [groupName=4-46e7-911f-913ec76bdb17-Sessions-Consumer, consumeEnable=true, consumeFromMinEnable=true, consumeBroadcastEnable=true, retryQueueNums=1, retryMaxTimes=16, brokerId=0, whichBrokerWhenConsumeSlowly=1, notifyConsumerIdsChangedEnable=true]
2018-06-20 13:40:10 INFO BrokerControllerScheduledThread1 - dispatch behind commit log 0 bytes
2018-06-20 13:40:10 INFO BrokerControllerScheduledThread1 - Slave fall behind master: 0 bytes
2018-06-20 13:40:11 INFO BrokerControllerScheduledThread1 - register broker to name server localhost:9876 OK
2018-06-20 13:40:21 INFO PullMessageThread_8 - auto create a subscription group, SubscriptionGroupConfig [groupName=4-46e7-911f-913ec76bdb17-Sessions-Consumer, consumeEnable=true, consumeFromMinEnable=true, consumeBroadcastEnable=true, retryQueueNums=1, retryMaxTimes=16, brokerId=0, whichBrokerWhenConsumeSlowly=1, notifyConsumerIdsChangedEnable=true]
2018-06-20 13:40:21 WARN PullMessageThread_8 - The consumer's group info not exist, group: 4-46e7-911f-913ec76bdb17-Sessions-Consumer

From your provided log, the " auto create a subscription group, " is executed by PullMessageThread, aka, PullMessageProcesssor. PullMessageProcessor.java line #106 indeed examines existence of the mentioned subscription group through findSubscriptionGroupConfig(group) as below:
    public SubscriptionGroupConfig findSubscriptionGroupConfig(final String group) {
        SubscriptionGroupConfig subscriptionGroupConfig = this.subscriptionGroupTable.get(group);
        if (null == subscriptionGroupConfig) {
            if (brokerController.getBrokerConfig().isAutoCreateSubscriptionGroup() || MixAll.isSysConsumerGroup(group)) {
                subscriptionGroupConfig = new SubscriptionGroupConfig();
                subscriptionGroupConfig.setGroupName(group);
                SubscriptionGroupConfig preConfig = this.subscriptionGroupTable.putIfAbsent(group, subscriptionGroupConfig);
                if (null == preConfig) {
                    log.info("auto create a subscription group, {}", subscriptionGroupConfig.toString());
                }
                this.dataVersion.nextVersion();
                this.persist();
            }
        }

        return subscriptionGroupConfig;
    }

This is the only method that may output such log. Apparently, it should not run into branch of creating new subscription and the follow-up log output confirms this: __The consumer's group info not exist, __.
I am wondering if the conversion tool, IKVM, made some errors such as reorder the log statement out of the if-guard.

@CP-Ram Looks the IKVM supports debug https://www.ikvm.net/devguide/concepts.html you may follow instructs there to build a debug version and step into the code I mentioned to figure out the mysterious part.

@CP-Ram ping


ReadOnly config keys

Hi 👋
Thanks as always for this great library.
I've run into a bit of an issue with the following two config keys.
leader.replication.throttled.rate
follower.replication.throttled.rate

I'm adding them to all brokers in a cluster using the AlterConfigsRequest and not specifying ResourceName so it updates the cluster-wide dynamic config. Then if I do a DescribeConfigsRequest for the cluster-wide dynamic config I'm seeing the above two config keys have been added, but they are marked as ReadOnly = true. These are dynamic keys which can definitely be altered at any time, so I'm not sure why they are marked as read-only. I've successfully altered/deleted these keys multiple times using this library's APIs. I was hoping to use the ReadOnly flag to filter out actual read-only config, but it filters out these dynamic config keys that I care about.
Is the read-only status of a key coming from the Kafka cluster itself, or is that something this library has configuration for?

The ReadOnly field is set by the cluster itself, but it is odd that this isn't showing dynamic. What does the ConfigSource field say?

ConfigSource is 3 (ConfigSourceDynamicDefaultBrokerConfig)

I remember when I added this that some values can only be set on a per-resource basis. It is possible that in this case, ResourceName would need to be specified. I'm not 100% sure on the semantics of when or why Kafka requires this.
Looking at Kafka's source, when describing configs, if the resource name is empty when describing, then it returns dynamic default broker config.
 Does it show the config value as non-dynamic in that case? If so, then it may be that the config is read only when describing the cluster, but is actually dynamic. If not, then it may be that the config needs to be set on a per-broker basis.
Config describing isn't too obvious because I think it quickly gets into zookeeper code behind the scenes. Let me know what the above shows and if things aren't working out, I could maybe try to dig in a bit more?

I just tried adding/describing in exactly the same way (cluster-wide) with a different dynamic key, background.threads. That one works fine.
Here's a bit of debug output:
leader.replication.throttled.rate is readonly=true, source=3
follower.replication.throttled.rate is readonly=true, source=3
background.threads is readonly=false, source=3

I also tried what you suggested, querying the broker directly, and it still returns readonly=true, source=3.
Perhaps the *.throttled.rate keys are special in some way because I noticed that they aren't listed under Broker Configs in the documentation. Instead, they appear in a separate section about limiting bandwidth. So it may be a bug with those keys due to them being treated in some special way.

Well, these keys certainly are special, but checking the source, they're especially dynamic: https://github.com/apache/kafka/blob/361b7845c6e6badc4be19fec596380a3de7a5c98/core/src/main/scala/kafka/server/DynamicConfig.scala#L31-L40
It looks like the truly "dynamic" configs are their own static set: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/DynamicBrokerConfig.scala#L80-L86
And when describing, if the config being described is not in that set, it is ReadOnly: https://github.com/apache/kafka/blob/0888953e0e834bf849751a36ae5adf92b20ec0a5/core/src/main/scala/kafka/server/ConfigHelper.scala#L158
Not sure why that is. The keys your setting aren't in that set, so they're being returned as read only.
The KIP itself, although old, mentions "brokers don't have any dynamic configs currently": https://cwiki.apache.org/confluence/display/KAFKA/KIP-133%3A+Describe+and+Alter+Configs+Admin+APIs. However it also mentions that altering a read only config returns an error, and you didn't experience that.
AFAICT the logic around ReadOnly looks pretty questionable, and the ConfigSource field may be a better bet to determine whether something is dynamic.

Good find! So these three config keys are especially dynamic because they "have no physical manifestation in the server.properties and can only be set dynamically."

the ConfigSource field may be a better bet to determine whether something is dynamic

Ah, yes. That does seem like the best way to proceed. I'll try that for the solution.
Thanks for your quick response!

Turns out that just using ConfigSource isn't good enough. Take these two keys as an example:
controller.socket.timeout.ms is readonly=true, source 5
min.insync.replicas is readonly=false, source 5

Both are defaults (ConfigSourceDefaultConfig), but a dynamic key overriding the default can only be created for min.insync.replicas.
To solve the problem I added a new "super-dynamic" category and just made an exception for these three config keys. It seems to work ok. 🤞

With fresh eyes the next day I did figure out a way to use the ConfigSource to filter out readonly (non-dynamic) keys, without resorting to a list of exceptions. 👍
Just something I wanted to add that I noticed. In addition to these three "super-dynamic" keys, there are other keys which behave the same way. There are a number of broker keys that require the listener.name.{listenerName}. prefix when altering configs. The resulting key is "super-dynamic," i.e. is readonly=true, but source=ConfigSourceDynamicBrokerConfig.

After reading that comment three times now, I think I still am not making sense of exactly why Kafka is operating that way... heh. Glad you figured it out though :)
If I knew what to translate into docs, I would, but I'm not sure I do.

I don't really understand why Kafka behaves this way either, but not trusting the ReadOnly property seems to be the best way to handle it. I think if you wanted to add something to the docs you could say that the ReadOnly property returned by Kafka is not always correct. I've not investigated further, but my suspicion is that it was an oversight that some of these dynamic keys aren't set to ReadOnly=false, and perhaps it's not easy to fix now.

Awesome, easy enough to mention that and this issue, I've gone ahead and done that in https://github.com/twmb/franz-go/commit/16677574439f08b19530e5dc346d0dba0fbc3616.

Thanks again for this great library and for answering a number of my questions late last year. I had a lot of fun working on my project using franz-go. Just made it public and thought you might be interested.
https://github.com/peter-evans/kdef

Some of the option handling there looks a bit familiar ;)
Very cool though! Happy to see another OS project using this one!


[Codelab Issue] Testing Codelab 5.2, Step 9 - Wrong class name

Describe the problem
After Step2-6
'TasksFragment.kt' should be changed to 'StatisticsViewModel.kt' & 'AddEditTaskViewModel.kt'
(See the attatched file with a highlighted word)
In which lesson and step of the codelab can this issue be found?
5.2, Step 9

How to reproduce?
What are the exact steps to reproduce the problem?
Versions

What version of Android Studio are you using?

Additional information
Add any other context about the problem here.
codelab: advanced-android-kotlin

Duplicate #169


Metadata Banner

What problem are you facing?
While running KNCP CLI commands is not clear which version and where to find detailed information about project.

How could KNDP help solve your problem?
Create a CLI banner for display name of tool, small description, version, link to website, before every command run.

@ca7alindev Please use Charm Lipgloss framework for that: https://github.com/charmbracelet/lipgloss


test: fix flaky IT testExecuteSelectWithCredentials

Use priority instead of job timeout to force non-fast query in executeSelect.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #3471 ☕

Thanks for the review.


Upgrade from 1.2.0-rc3

1.2.0 is a new stable version which, according to the release notes, includes all new features/fixes introduced by the release candidates. In our environment we're using the 1.2.0-rc3 version. Is it worth doing an upgrade to 1.2.0 given the fact there haven't any major updates released since the 1.2.0-rc3 (correct me If I'm wrong)?
Plus, I've noticed that the upgrade page hasn't been updated since 2019. Do we need always the same upgrade steps regardless the aad-pod version (there are some breaking changes starting from 1.6.0)? Preferred order? (ingress -> aad-pod I guess)

Anyone?

Hi @rlevchenko , I would recommend to upgrade to 1.2.0 even if it's equivalent to rc3.
helm repo update
helm upgrade \
  <release-name> \
  application-gateway-kubernetes-ingress/ingress-azure

AKS recommends to use AAD Pod Identity with version >= 1.6.0, to support the recommended version, you will need to upgrade your AGIC to at least 1.2.0-rc2 or the release 1.2.0.
We have doc updated in a PR, should available soon.

@3quanfeng thanks. In short, 1.2.0 rc3 and 1.2.0 are indistinguishable.  In that case, I don't see any reasons to upgrade)
We have doc updated in a PR, should be available soon.
Thanks!


Help installing Terminus

I’m having problems installing Terminus. I’m on a Mac Yosemite 10.10.5
I downloaded composer with:
mkdir -p /usr/local/bin
curl sS https://getcomposer.org/installer | sudo php - —install-dir=/usr/local/bin —filename=composer
Then
composer require pantheon-systems/cli
Then tried
terminus auth login
but got -bash: terminus: command not found
I then tried
curl https://github.com/pantheon-systems/cli/releases/download/0.9.3/terminus.phar -L -o /usr/local/bin/terminus && chmod +x /usr/local/bin/terminus
but got
Failed to create the file /usr/local/bin/terminus: No such file or
Warning: directory
curl: (23) Failed writing body (0 != 16384)
I’m sorry the directions said it’s straight forward but I’m still fairly new and terminal commands.
Thank you!

Hi @chikaramike, the first attempt - via Composer - probably failed because you do not currently have an alias or a bin file set for "terminus." To see that it is properly installed, please go to the directory you were in when you tried to install it (I'll call it /install/dir for simplicity.) and list its contents. You'll see a vendor directory that Composer created. Inside, you can drill down through bin which contains a file called terminus. This is the one you want to run. If vendor, bin, or terminus are not present, then they did not install (properly). Try running this:
/install/dir/vendor/bin/terminus and if you get a help man page, then it's installed successfully! To use this with the simple command terminus, you will need to add this to your ~/.bash_profile file and then source it. This is a shortcut to do just that:
echo 'alias "terminus=/install/dir/vendor/bin/terminus"' >> ~/.bash_profile ; source ~/.bash_profile
In the second attempt, I'm not sure exactly what along the way may have gone wrong (perhaps your user has to sudo to write to /usr/local/bin), but if you would like to use the PHAR file, you can download it from https://github.com/pantheon-systems/cli/releases/download/0.9.3/terminus.phar, and then move it into your bin directory yourself and change the permissions to permit execution. For example, if the PHAR file was downloaded to ~/Downloads/terminus.phar, you would use:
mv ~/Downloads/terminus.phar /usr/local/bin/terminus ; chmod +x /usr/local/bin/terminus. If this does not work, try sudo !! to repeat the previous action using your administrator privileges.

Awesome!  Thank you!  I got a permission denied with the first attempt.  Was able to login with the extra instructions on the second attempt.


Update README.md

Improve README.md for windows.
I have edited English version only as I don't know other languages and localizations.

/assign @bradtopol

/assign @bradtopol

Related #22995.

/approve

Hi @forvaidya do you still working on this? 👋

Hello @forvaidya .
I plan on closing this pull request.
Feel free to reopen this PR to make further updates.
/close


CZO controlled vocabulary Subject Keywords don't populate

Description of the bug
The controlled vocabulary from http://vocabulary.odm2.org/ used to make type-ahead recommendations for Subject Keywords when editing a resource doesn't add the keyword when selected.
This occurred while demoing with @martinseul on production.
I could not reproduce it on v.1.54 local dev setup.
Steps to reproduce the bug:

Login as a member of one of the CZO groups
Edit a resource
Start typing in a Subject Keyword
Select one of the odm2 recommendations (in our attempt, we used "Absorbance"
The tag populates with ${k}

Expected behavior
The selected keyword should populate into the tag
Issue observed on production v1.54:

No issue on a fresh dev build of 1.54:

https://user-images.githubusercontent.com/17934193/160892611-82ce42c0-86e9-4368-b4de-ffcbfaee815c.mov
Believe this is a regression that @devincowan introduced via this PR #4519

Deemed lower priority and unable to reproduce so moving to backlog

@martinseul I just ran most recent versions of browsers and OS on Browserstack. All of them populate keywords for https://www.hydroshare.org/resource/5949aec47b484e689573beeb004a2917/
I still believe this is a cache issue. I created #4571 earlier today addressing--will add some more comments to that ticket
Screenshots:

we are leaning toward not prioritizing this as a hotfix and solving the underlying cache issue instead


Pending deprecate M,Q,W,V matrix setters in QEOMResult

Summary
Closes #1013
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 85.871%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
17565

Relevant Lines:
20455

💛  - Coveralls


Fetch error and autocompletion not working

since 1 week, copilot doesn't fetch autocompletion anymore, there is just chat who is working
also while sometime toggle seem to work to re enable autocompletion, now it's just won't disable

VS Code Version: 1.87.2
OS Version: Sonoma 14.4
Logs:

2024-03-15 14:49:55.130 [info] [fetcher] Using Helix fetcher, Electron fetcher is not available.
2024-03-15 14:49:55.130 [info] [code-referencing] Public code references are enabled.
2024-03-15 15:18:35.571 [info] [fetcher] Using Helix fetcher, Electron fetcher is not available.
2024-03-15 15:18:35.571 [info] [code-referencing] Public code references are enabled.
2024-03-15 15:43:37.096 [info] [fetcher] Using Helix fetcher, Electron fetcher is not available.
2024-03-15 15:43:37.096 [info] [code-referencing] Public code references are enabled.
2024-03-15 15:47:40.942 [error] [default] github.copilot.toggleCopilot: Error: TypeError: Cannot assign to read only property '*' of object
    at Object.set (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:153:47905)
    at fM.updateEnabledConfig (/home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/config.ts:75:31)
    at toggleCopilotEnablement (/home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/config.ts:121:30)
    at fn (/home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/extension.ts:73:15)
    at /home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/telemetry.ts:24:26
    at u.h (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:150:184839)
    at u.g (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:150:183831)
    at u.executeCommand (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:150:183738)
    at Object.executeCommand (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:160:21654)
    at /home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/statusBarPicker.ts:43:26
    at new Promise (<anonymous>)
    at OU.handleItemSelection (/home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/statusBarPicker.ts:36:16)
    at p.value (/home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/statusBarPicker.ts:29:18)
    at n.y (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:1902)
    at n.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:2119)
    at s._fireDidAccept (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:150:157843)
    at n.$onDidAccept (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:150:156072)
    at s.S (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:147:5519)
    at s.Q (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:147:5285)
    at s.M (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:147:4375)
    at s.L (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:147:3454)
    at p.value (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:147:2241)
    at n.y (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:1902)
    at n.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:2119)
    at r.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:14091)
    at p.value (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:173:8050)
    at n.y (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:1902)
    at n.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:2119)
    at r.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:14091)
    at u.z (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:17156)
    at p.value (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:16561)
    at n.y (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:1902)
    at n.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:2119)
    at p.acceptChunk (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:11865)
    at p.value (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:11152)
    at n.y (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:1902)
    at n.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:2119)
    at n.z (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:170:19748)
2024-03-15 15:47:43.920 [error] [default] github.copilot.toggleCopilot: Error: TypeError: Cannot assign to read only property '*' of object
    at Object.set (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:153:47905)
    at fM.updateEnabledConfig (/home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/config.ts:75:31)
    at toggleCopilotEnablement (/home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/config.ts:121:30)
    at fn (/home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/extension.ts:73:15)
    at /home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/telemetry.ts:24:26
    at u.h (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:150:184839)
    at u.g (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:150:183831)
    at u.executeCommand (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:150:183738)
    at Object.executeCommand (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:160:21654)
    at /home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/statusBarPicker.ts:43:26
    at new Promise (<anonymous>)
    at OU.handleItemSelection (/home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/statusBarPicker.ts:36:16)
    at p.value (/home/thomas/.vscode-server/extensions/github.copilot-1.173.0/extension/src/statusBarPicker.ts:29:18)
    at n.y (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:1902)
    at n.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:2119)
    at s._fireDidAccept (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:150:157843)
    at n.$onDidAccept (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:150:156072)
    at s.S (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:147:5519)
    at s.Q (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:147:5285)
    at s.M (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:147:4375)
    at s.L (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:147:3454)
    at p.value (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:147:2241)
    at n.y (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:1902)
    at n.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:2119)
    at r.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:14091)
    at p.value (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:173:8050)
    at n.y (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:1902)
    at n.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:2119)
    at r.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:14091)
    at u.z (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:17156)
    at p.value (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:16561)
    at n.y (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:1902)
    at n.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:2119)
    at p.acceptChunk (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:11865)
    at p.value (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:105:11152)
    at n.y (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:1902)
    at n.fire (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:80:2119)
    at n.z (/home/thomas/.vscode-server/bin/863d2581ecda6849923a2118d93a088b0745d9d6/out/vs/workbench/api/node/extensionHostProcess.js:170:19748)

@digitarald Should be transferred to Github-Copilot

This should be fixed in 1.174.0

Copilot

Version: 1.187.0
Build: prod
Editor: vscode/1.89.0

Environment

http_proxy: http://<IP_ADDRESS>:7890
https_proxy: http://<IP_ADDRESS>:7890
no_proxy: <IP_ADDRESS>,login.microsoftonline.com,192.168.,172.31.,172.30.,172.29.,172.28.,172.27.,172.26.,172.25.,172.24.,172.23.,172.22.,172.21.,172.20.,172.19.,172.18.,172.17.,172.16.,10.,127.*,localhost,
SSL_CERT_FILE: n/a
SSL_CERT_DIR: n/a
OPENSSL_CONF: n/a

Feature Flags

Send Restricted Telemetry: enabled
Chat: enabled

Node setup

Number of root certificates: 141
Operating system: Linux
Operating system version: <IP_ADDRESS>-microsoft-standard-WSL2
Operating system architecture: x64
NODE_OPTIONS: n/a
NODE_EXTRA_CA_CERTS: n/a
NODE_TLS_REJECT_UNAUTHORIZED: n/a
tls default min version: TLSv1.2
tls default max version: TLSv1.3

Network Configuration

Proxy host: <IP_ADDRESS>
Proxy port: 7890
Kerberos SPN: n/a
Reject unauthorized: enabled
Fetcher: HelixFetcher

Reachability

github.com: HTTP 200 -
copilot-proxy.githubusercontent.com: HTTP 200 -
api.githubcopilot.com: HTTP 200 -
default.exp-tas.com: HTTP 200 -

VS Code Configuration

HTTP proxy:
HTTP proxy authentication: n/a
Proxy Strict SSL: true
Extension HTTP proxy support: override

Extensions

Is win-ca installed?: false
Is mac-ca installed?: false

Authentication

GitHub username: aqlkzf

Copilot

Version: 1.187.0
Build: prod
Editor: vscode/1.89.0

Environment

http_proxy: http://<IP_ADDRESS>:7890
https_proxy: http://<IP_ADDRESS>:7890
no_proxy: <IP_ADDRESS>,login.microsoftonline.com,192.168.,172.31.,172.30.,172.29.,172.28.,172.27.,172.26.,172.25.,172.24.,172.23.,172.22.,172.21.,172.20.,172.19.,172.18.,172.17.,172.16.,10.,127.*,localhost,
SSL_CERT_FILE: n/a
SSL_CERT_DIR: n/a
OPENSSL_CONF: n/a

Feature Flags

Send Restricted Telemetry: enabled
Chat: enabled

Node setup

Number of root certificates: 141
Operating system: Linux
Operating system version: <IP_ADDRESS>-microsoft-standard-WSL2
Operating system architecture: x64
NODE_OPTIONS: n/a
NODE_EXTRA_CA_CERTS: n/a
NODE_TLS_REJECT_UNAUTHORIZED: n/a
tls default min version: TLSv1.2
tls default max version: TLSv1.3

Network Configuration

Proxy host: <IP_ADDRESS>
Proxy port: 7890
Kerberos SPN: n/a
Reject unauthorized: enabled
Fetcher: HelixFetcher

Reachability

github.com: HTTP 200 -
copilot-proxy.githubusercontent.com: HTTP 200 -
api.githubcopilot.com: HTTP 200 -
default.exp-tas.com: HTTP 200 -

VS Code Configuration

HTTP proxy:
HTTP proxy authentication: n/a
Proxy Strict SSL: true
Extension HTTP proxy support: override

Extensions

Is win-ca installed?: false
Is mac-ca installed?: false

Authentication

GitHub username: aqlkzf


Fix timeout method

Based on PR https://github.com/knex/knex/pull/2527 - rebased and added the fix for postgres too:

KILL commands have to be sent on a seprate connection, and transaction Clients override acquireConnection to always return the same connection.
Furthermore, it is plausible that some applications may never be able to Acquire a pooled connection for cancellation becuase a query which is Exceeding the timeout may coincidentally exhaust the connection pool.
For example, if a DDL operation is blocking writes, a connection pool May be quickly exhaused by write operations.

Timeout cancellation during transaction is fixed by using acquireRawConnection and _query to bypass the transaction connection and cancel the query from a separate connection.
fixes #2211

@elhigu @maximelkin @briandamaged This needs a careful review.

The CI error seems unrelated. When I run the worflow on my fork, CI passed. Perhaps just hit the re-run button (I don't have access to it, so I can't re-run the workflow for the PR).

Released in 0.95.3.


store the model type on the stack

the render block is instance evaled, so it doesn't have access to the
controller.  We store the model on the stack so that we don't need
access to the instance in the render block.
Fixes Bug 1207313
https://bugzilla.redhat.com/show_bug.cgi?id=1207313
/cc @dclarizio

@tenderlove Need to fix the same issue when canceling from Edit . . . in update_button_cancel method.

@dclarizio I've updated the patch to fix that method too.  I didn't write a test for it though because I can't figure out what values I need to put in @edit to make it fail.

@tenderlove @edit (same as session[:edit]) is cleared out by the update_button_cancel method, so it's contents are not important since the user is canceling.  So the test can just verify that it redirects with the flash message I think.

Well the problem is that I couldn't write a failing test.  I was able to write a test, but I couldn't get it to 500 in the test framework.

@tenderlove I think we're good to go then . . . I will retest and merge if all is well . . . Thx!


Xamarin.Mac support

Xamarin.Mac version doesn't work proper way(for example, LocalStorage returns ~/../Library, which incorrect by definition). Here you can find fork, which repairs Mac compatibility

I see that the fork creates a separate project which specifically targets Xamarin.Mac.  As far as I know, it's not currently possible to build a project targeting Xamarin.Mac on Windows.
I think that libraries targeting .NET Framework 4.5 will probably work on Xamarin.Mac.  So what I'd like to try is to just compile the library for .NET Framework with the code that uses the correct path for LocalStorage, and see if it can be used from Xamarin.Mac.
Would you be willing to see if this works and send a PR for it?

Sorry for delay, i was rly busy this weekend. As temporary solution, i use PCLStorage, PCLStorage.Abstractions & PCLStorage.FileSystem.Desktop source code in xamarin.mac project:

with some changes(just remove #if derectives & use Filesystem || MAC || Portable code), for example
static IFileSystem CreateFileSystem()
{
    return new DesktopFileSystem();
}

My mac project use Xamarin.Mac Mobile as Target Framework, not Xamarin.Mac .Net 4.5
I can try to build everything u want on mac, if it'll help you :smile:

I'm now getting this error with the LocalStorage on mac. Are there plans to implement a solution in the main branch and publishing an updated version? Thanks.

So what do you think? Can we get this fixed soon?
Thanks

@Sparksteam Still using temp solution ¯_(ツ)_/¯

@haritowa Hope not too much longer.

@Sparksteam we have switched to native, so this doesn't make me suffer any more :joy:
You can use source from this fork

Thanks @haritowa, I may have to use that fork eventually. Did you build a binding class for OS X, or are you going native across-the-board?

@Sparksteam fully native both for iOS & OS X

To be able to produce a package with Mac support, I need a way to be able to build a library that can run on Xamarin.Mac on a Windows machine. Possible ways of doing this include:

Build a library which targets .NET Framework 4.5, and rely on the fact that it should "just work" when running on Xamarin.Mac
Build against the Xamarin.Mac reference assemblies.  Xamarin would need to release them in a publicly consumable form (preferrably a NuGet package)
Target the .NET Platform Standard v1.3.  Xamarin.Mac would need to support .NETStandard v1.3, which I don't think it does yet.

Why would it need to run on Windows? Is there bait-and-switch going on in the NuGet?

@Sparksteam It doesn't need to run on Windows, but I need to be able to build it on Windows.  I don't own a Mac, so I can't use one to build the library for Xamarin.Mac.  Even if I did, I would strongly prefer to enable everything to be built on a single machine, instead of having to build some of the files on Windows, some on a Mac, and then copying them together and creating a NuGet package out of them.

@Sparksteam And yes, PCL Storage is a canonical example of bait-and-switch.  The NuGet package contains a portable "reference assembly" that PCLs can compile against, and then implementations compiled for each platform supported.

Yeah Daniel, it is somewhat cumbersome. And expensive to buy a MAC. I’d be more than happy to build binaries for you and upload them somewhere.
Allan
From: Daniel Plaisted<EMAIL_ADDRESS>Sent: Thursday, March 17, 2016 4:12 PM
To: dsplaisted/PCLStorage<EMAIL_ADDRESS>Cc: Sparksteam<EMAIL_ADDRESS>Subject: Re: [PCLStorage] Xamarin.Mac support (#28)
@Sparksteam https://github.com/Sparksteam  It doesn't need to run on Windows, but I need to be able to build it on Windows. I don't own a Mac, so I can't use one to build the library for Xamarin.Mac. Even if I did, I would strongly prefer to enable everything to be built on a single machine, instead of having to build some of the files on Windows, some on a Mac, and then copying them together and creating a NuGet package out of them.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/dsplaisted/PCLStorage/issues/28#issuecomment-198123575 https://github.com/notifications/beacon/AL--vEEDUozYGk7Eubgik-lNiMP4KSnLks5pud_cgaJpZM4G1ges.gif

@haritowa - Is this only change you had to make to the master code, in DesktopFileSystem.LocalStorage?
#elif MAC
var documents = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
var localAppData = Path.Combine(documents, "Library");
#else
and adding the necessary MAC preprocessor symbol, of course.
Thanks

@Sparksteam unfortunately, i can't remember all details, i just remove all #IF sections for other platforms :)

PCLStorage.Mac.zip
@Sparksteam Try this

Thanks @haritowa . I diff'd the files with the current master and although there were some differences, it doesn't look like any of them contain any MAC specific changes. The one change I referenced last week in your DesktopFileSystem.LocalStorage might be all that's required. I will give that a try and let you know.

@haritowa - I worked around this problem in my code by simply implementing my own GetStorageFolder with this code;
IFolder storageFolder;
#if _MAC
var documents = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
var localAppData = documents + "/Library";
storageFolder = await FileSystem.Current.GetFolderFromPathAsync(localAppData);
#else
storageFolder = FileSystem.Current.LocalStorage;
#endif
@dsplaisted  - My offer still stands if you'd like me to build some binaries for you. The fix seems simple enough, but you will need that MAC project.
Thanks guys.

@Sparksteam Can you send a PR to add support for building on the Mac?  Once we have that merged then you can build the Mac DLL and send it to me.
Thanks,
Daniel

Ok Daniel - PR #38 with the changes I think are required. I'm not sure how to go about testing it though. I have all the release binaries for PCLStorage.OSX. Let me know how you would like me to get them to you. If you build and publish a pre-release NuGet package with these changes I would be more than happy to test it for you.
Thanks,
Allan

ITNOA
Is there any update?

Is it working?


firebase: add library

Add Firebase library and update all the other libraries
Added Google Service Framework support for supporting Firebase functions (OAuth, Firebase tokens...)

This change is

Do we need a config file for this so that it references the correct firebase account?


Unable to clear client certificate preferences

Adding a clearClientCertPreferences method similar to the one the
Android system webview has.  When called it will clear any client
certificate preferences stored in response to proceeding/cancelling
client cert requests.
BUG=XWALK-6297

Can you add more details in the commit message? It should be possible to understand the change without having to read the Jira issue.
Also, our Android team is currently on Lunar New Year holiday, the actual code will be reviewed next week. @lincsoon
Thanks for the patch!

Would it be possible to add a test case similar to https://github.com/crosswalk-project/crosswalk/blob/master/test/android/core_internal/javatests/src/org/xwalk/core/internal/xwview/test/SetDomStorageEnabledTest.java to make sure it works.
Thanks for the contribution.

@wuhengzhi Could you help to review this pull request?

Yes, thanks.

@marcuspridham For the test case, you can refer to AwContentsStaticsTest.java

Please add [Android] before Unable to clear client certificate preferences.
How about change Unable to clear client certificate preferences to Implement embedding API of clearClientCertPreferences().?

Thanks for the feedback.  I have added the changes in the latest commit.

@marcuspridham Thanks for your commit.
Did you run ./build/android/test_runner.py instrumentation --release --test-apk=XWalkCoreTest --test-filter=ClearClientCertPreferenceTest.* on your device?

I ran the command you mentioned.  The test passes.  Thanks.
i827005@ubuntu-vm:~/dev/crosswalk-src/src$ ./build/android/test_runner.py instrumentation --release --test-apk=XWalkCoreTest --test-filter=ClearClientCertPreferenceTest.*
W    1.278s Main  Creating 1 test runner.
W    1.279s fa93  Creating shard 0 for device 04ab28240025fa93.
W    2.121s fa93  Unable to enable java asserts for 04ab28240025fa93, non rooted device
W    3.770s Main  Running tests with 1 test runner.
C    6.581s Main  ********************************************************************************
C    6.581s Main  Summary
C    6.581s Main  ********************************************************************************
C    6.581s Main  [==========] 1 test ran.
C    6.581s Main  [  PASSED  ] 1 test.
C    6.581s Main  ********************************************************************************

LGTM, +@wuhengzhi @axinging @fujunwei

LGTM, thanks.

I guess we're finally good to go then. Thanks for the patch, Marcus!


How to get a Perfect-Elastic-Collision system？

I tried to get a system of one particle within a container.
I am sure that the options of the particle and the wall is set correctly, such as friction is 0, restitution is 1. But, I found the velocity of the particle became slow when it collided with the container wall（the wall is a rectangle).It means that the kinetic energy of particle reduce when the collision happen.
So why and how to make the collision between particle and wall Perfect Elastic Collision?

This is an issue I am struggling with myself. Not sure why this is the case, but the problem may be to be related to rounding errors (in the Verlet integration engine of matter.js?).
The workaround I devised is to transfer velocity manually at each collision. Kinda works, but is very hacky and won't work as expected if masses of collided particles differ (unless you take it under consideration in your custom, perfectly-elastic velocity transferring function). Not to mention the performance impact of such calculations on top of what matter.js is doing...

See thread #256, which discusses this with some suggestions around this issue. Please leave any further comments there as I'm closing this as a duplicate, thanks for raising though.


Validator not working with hidden forms #317

Fix for validation for hidden forms as well

Thanks for the PR, but this functionality was added because some people wanted to split the same form between multiple pages (like a wizard).
You can work around your issue by initializing the validator on the tab shown event, or putting  $.fn.validator.Constructor.INPUT_SELECTOR = ':input:not([type="submit"], button):enabled' somewhere in your code.

thanks a lot, i have been solving this for the hole day!

Glad I could be of some help :)


Makeup and expect

What are the links to relevant tickets?
None - no changes to functionality, just bringing the repo up to some more recent standards.
What does this PR do?
Updates to latest make-up (6.0)
Swaps out the use of should to expect as per the current culture guidelines https://github.com/holidayextras/culture/blob/master/testing-standard.md
What functional/unit tests does this PR have?
Same as before, what were you expecting?
How should a developer review this?
Read through
Any background context you want to provide?
Screenshots (if appropriate)

Quality checklist (for PR author to complete BEFORE code review):

[x] I've checked there is appropriate unit test coverage.
[ ] I've updated documentation with any changes to procedures.
[ ] I've checked this work against the requirements of the Jira.
[x] This change passes all necessary tests (cross browser, automated or otherwise).
[x] I am ready for this to be code reviewed, merged and tested.

Reviewer 1 @kevinhodges

[x] I agree with the assumptions made in the quality checklist.
[x] I’ve witnessed the work behaving as expected.
[x] I’ve checked for appropriate test coverage.
[x] I’ve checked for coding anti-patterns.
[x] I've checked this work against the requirements of the Jira.
[x] I don’t believe this work introduces unnecessary technical debt.
[x] +1 from me!

Reviewer 2

[ ] I agree with the assumptions made in the quality checklist.
[ ] I’ve witnessed the work behaving as expected.
[ ] I’ve checked for appropriate test coverage.
[ ] I’ve checked for coding anti-patterns.
[ ] I've checked this work against the requirements of the Jira.
[ ] I don’t believe this work introduces unnecessary technical debt.
[ ] +1 from me!

I have 0 problems with this work :+1:


Provide a faster single sign-on experience for logged-in users

Currently, casdoor supports the function of automatically logging in when visiting another site after logging in on one site. But the current login experience is not good.

When a user visits site A and completes the login using single sign-on. At this time, if he visits site B, site B will also redirect him to the login interface. After the redirection, the following things will happen:

Load the home page and static resources
Load the login interface
Display logged in user information
Login detected and automatically redirected

（The picture above shows a login page. Note that the user has clearly logged in, but he has stayed on this page for more than 10 seconds, waiting for the entire page to load and automatically redirecting back to the site he wishes to log in to.）
The entire redirection process may last for more than 10 seconds, and a login box that requires entering the account and password appears. The user even mistakenly thinks that he needs to enter the account and password again to log in. As a result, the redirection is triggered when the account and password are entered halfway. This greatly affects the single sign-on experience.
For comparison, CAS is unaware of single sign-on. When site B redirects to CAS, CAS will find that the user has logged in and will directly initiate a 302 jump instead of loading the login box first and then slowly triggering the jump logic.
Therefore I want to implement the following logic:
When the application redirects to Casdoor, it should be determined as early as possible whether the user is logged in. When it is found that the user is logged in, the current login logic is interrupted, the login process is directly completed and redirected back to the application. Users should not perceive the existence of Casdoor when they visit site B after logging in, but just feel that they have been redirected several times.

@HanadaLee can you make a PR to fix it?

@HanadaLee can you make a PR to fix it?

Sorry, I am not familiar with golang code or frontend. I am just an operation and maintenance engineer. This is just a suggestion for my current login process.

@HanadaLee fixed by: https://github.com/casdoor/casdoor/commit/6ef2b5178225f657f09e7960e1a8d7a70e2ea068


Change Async await example to embrace async\await?

Hi. Thanks for Chrome Remote Interface!
It's been a great help.
One question about
https://github.com/cyrus-and/chrome-remote-interface/wiki/Async-await-example
The point of this example is to embrace promises and async\await.
Wanted to ask if in this case it should be re-written as:
CDP().then(client => {
  const {Network, Page} = client;
  //...
}, err => {
  console.error('Cannot connect to browser:', err);
});

Thanks!

Glad to hear that! :)
Well, not exactly, the main example already uses Promises the point of this wiki example was to show how to avoid then/catch in favour of async/await.
I didn't use then/catch in the main example because I find it less clear to catch connection errors (for the sake of the example).
If anything, I'd rewrite that wiki example using async/await for everything but I'd need to wrap it in an async function, which is kind of ugly, but really shows the full potential:
const CDP = require('chrome-remote-interface');

async function example() {
    try {
        // connect to endpoint
        var client = await CDP();
        // extract domains
        const {Network, Page} = client;
        // setup handlers
        Network.requestWillBeSent((params) => {
            console.log(params.request.url);
        });
        // enable events then start!
        await Promise.all([Network.enable(), Page.enable()]);
        await Page.navigate({url: 'https://github.com'});
        await Page.loadEventFired();
    } catch (err) {
        console.error(err);
    } finally {
        if (client) {
            await client.close();
        }
    }
}

example();

What do you think?

Yes, exactly. This is much neater IMHO.
Also, I wouldn't worry too much about the "ugly" wrapping function. Anyone who is familiar with asynchronous/await will be familiar with why it's required and won't judge.

Alright then, I updated the wiki. Thanks for pointing this out.


Fix bugs related variable scopes not being considered

Thanks for the fixes. looks good. please close the associated issues also.

Thanks!


add some docs for emailblock, integerblock, decimalblock and floatblock

Thanks @OktayAltay!
We need to be really careful about the order in which we introduce concepts on this page, since it needs to work as a tutorial for people learning about StreamField for the first time, as well as being a reference document.
The BlogPage example is meant to be a simple, real-world example of how a Wagtail developer can benefit from StreamField. If we try to introduce too many block types into that initial example, we risk making it more confusing, and less representative of real-world situations. It's easy to understand a blog post as being a series of headings, paragraphs and images - if we add things like 'email' and 'integer' to that list, people will rightly start wondering "why would I want to insert an integer in a blog post?"
In practice, EmailBlock etc are probably only going to be used within a StructBlock, so we can't really give a meaningful example of them until after we've introduced StructBlock. So perhaps the solution is to work these block types into the StructBlock documentation, using an example like:
class CityBlock(blocks.StructBlock):
    name = blocks.CharBlock()
    population = blocks.IntegerBlock()
    temperature = blocks.FloatBlock()

Alternatively, perhaps a dedicated 'Examples' / 'Recipes' section at the end of the page would work...

Hey Gasman,
You are right, i will change my pull request and make a new section at the end of the page on how to implement blocks into a StructBlock.

Have added your updated example in bc7739e104aa0dbacfd704608bf5332c292c4a31 - thanks!
Just so you're aware - your master branch is now out of sync with the main torchbox/wagtail repo, as you've merged the new changes from torchbox/wagtail on top of yours. You'll probably want to delete and recreate your copy of the repo, and ensure that any pull requests you create in future are done on branches rather than master.


build gerber files as part of the pipeline

investigate if gerber files can be built as part of the pipeline

This should be possible with Python bindings shipped with Kicad https://github.com/KiCad/kicad-source-mirror/blob/master/demos/python_scripts_examples/gen_gerber_and_drill_files_board.py


null check operator used on a null value

Hi, i am trying to deploy app with tflite_flutter.
But when i test the code like below, it, log out error null check operator used on a null value though as i see input and output of model is not null
Can anyone explain why

provide all code its not coming from the code you provide

I am having the same issue.  The issue is coming from runForMultipleInputs() in interpreter.dart
Model: blaze_face_short_range.tflite
The interpreter outputShape is [1,896,16] but the outputTensors in runForMultipleInputs() is [ 2, 896, 16]
final output = [
            List.filled(isolateModel.outputShape[1],
            List.filled(isolateModel.outputShape[2], 0.0))
];
interpreter.run(input, output);

interpreter.dart:
void runForMultipleInputs(List<Object> inputs, Map<int, Object> outputs) {
   if (outputs.isEmpty) {
     throw ArgumentError('Input error: Outputs should not be null or empty.');
   }
   runInference(inputs);
   var outputTensors = getOutputTensors();
   for (var i = 0; i < outputTensors.length; i++) {
     outputTensors[i].copyTo(outputs[i]!);
   }
 }

I am also getting the same error.

I am also getting the same error.
I think the reason behind this error is package implementation how the package is handling run method of interpreter.
/// Run for single input and output
  void run(Object input, Object output) {
    var map = <int, Object>{};
    map[0] = output;
    runForMultipleInputs([input], map);
  }

  /// Run for multiple inputs and outputs
  void runForMultipleInputs(List<Object> inputs, Map<int, Object> outputs) {
    if (outputs.isEmpty) {
      throw ArgumentError('Input error: Outputs should not be null or empty.');
    }
    runInference(inputs);
    var outputTensors = getOutputTensors();
    for (var i = 0; i < outputTensors.length; i++) {
      outputTensors[i].copyTo(outputs[i]!);
    }
  }

In run method, map is initialized with only first index data from the output list, then this map is passed on the runForMultipleInputs method.
In that method, there is a for loop which runs upto length of outputTensors which may be 3 or 4. It also access outputs[i]! which length is only 1 irrespective how long list we are passing as output in void run(Object input, Object output). That's why we are getting null check operator used on a null value.

getting the same issue here with DeepSpeech 0.9.3 tflite model.


ImportError: No module named 'Cython'

Pip install pydtw throws import error.
Collecting pydtw
  Downloading pydtw-1.0.0.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-16ffmgc7/pydtw/setup.py", line 3, in <module>
        from Cython.Distutils import build_ext
    ImportError: No module named 'Cython'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-16ffmgc7/pydtw/

fix it on #5


Delete tarnow.txt

Website of the town of Tarnów.

@aaapl Thank you for the update! Pull request merged.


offset_of is unsound

With the implementation in:
macro_rules! offset_of {
    ($parent:ty, $($field:tt)+) => (unsafe {
        let x: &'static $parent = $crate::Transmuter::<$parent> { int: 0 }.ptr;
        $crate::Transmuter { ptr: &x.$($field)+ }.int
    });
}

you are constructing a &'static T at address 0. This is undefined behavior because Rust may assume that you have a valid &'static T but you do not.
Moreover, in the old pre-1.33.0 implementation you have:
macro_rules! offset_of {
    ($father:ty, $($field:tt)+) => ({
        #[allow(unused_unsafe)]
        let root: $father = unsafe { $crate::mem::uninitialized() };

        let base = &root as *const _ as usize;

        // Future error: borrow of packed field requires unsafe function or block (error E0133)
        #[allow(unused_unsafe)]
        let member =  unsafe { &root.$($field)* as *const _ as usize };

        $crate::mem::forget(root);

        member - base
    });
}

Note that when you say &root you have already triggered undefined behavior because again, you assert with &root that you have a valid reference but you do not in fact.
See https://github.com/rust-lang/rfcs/pull/2582 and https://github.com/rust-lang/unsafe-code-guidelines/issues/77 for a discussion.
As for your comment about // Future error, do note that unsafe { ... } here does not make what you are doing any less undefined behavior. Instead, while you might not get an error from the compiler, you might get miscompilation should LLVM or rustc's behavior change.
cc @RalfJung

Note that when you say &root you have already triggered undefined behavior

Actually, mem::uninitialized already triggers UB (for most $father types). But that cannot be avoided until MaybeUninit hits stable -- which should happen in less than 2 weeks!

This already goes wrong in practice on aarch64. I compiled the example below with --target=aarch64-unknown-linux-gnu --release and ran the result on a Raspberry Pi 3B.
use memoffset::offset_of;

struct Foo {
	foo: i32,
}

fn main() {
	println!("foo: {}", offset_of!(Foo, foo));
}

The result of running the compiled binary on a Raspberry Pi 3B is that it hits a brk instruction which zsh reports as a trace trap:
./memoffset-minimum-example
zsh: trace trap (core dumped)

A stacktrace with lldb:
lldb ./memoffset-minimum-example
(lldb) target create "./memoffset-minimum-example"
Current executable set to './memoffset-minimum-example' (aarch64).
(lldb) r
Process 20353 launched: '/home/dronebox/memoffset-minimum-example' (aarch64)
Process 20353 stopped
* thread #1, name = 'memoffset-minim', stop reason = signal SIGTRAP
    frame #0: 0x0000aaaaaaaad944 memoffset-minimum-example`memoffset_minimum_example::main::h4461b5e7e8206c6c
memoffset-minimum-example`memoffset_minimum_example::main::h4461b5e7e8206c6c:
->  0xaaaaaaaad944 <+0>: brk    #0x1

memoffset-minimum-example`main:
    0xaaaaaaaad948 <+0>: str    x30, [sp, #-0x10]!
    0xaaaaaaaad94c <+4>: mov    x3, x1
    0xaaaaaaaad950 <+8>: adrp   x8, 0
(lldb) bt
* thread #1, name = 'memoffset-minim', stop reason = signal SIGTRAP
  * frame #0: 0x0000aaaaaaaad944 memoffset-minimum-example`memoffset_minimum_example::main::h4461b5e7e8206c6c
    frame #1: 0x0000aaaaaaaad984 memoffset-minimum-example`std::rt::lang_start::_$u7b$$u7b$closure$u7d$$u7d$::h87f1335357fe260f + 12
    frame #2: 0x0000aaaaaaab40d8 memoffset-minimum-example`std::panicking::try::do_call::he785b49af8496835 [inlined] std::rt::lang_start_internal::_$u7b$$u7b$closure$u7d$$u7d$::h6c6ea72b9d5d834b at rt.rs:49:12
    frame #3: 0x0000aaaaaaab40d0 memoffset-minimum-example`std::panicking::try::do_call::he785b49af8496835 at panicking.rs:294
    frame #4: 0x0000aaaaaaab58b4 memoffset-minimum-example`__rust_maybe_catch_panic at lib.rs:85:7
    frame #5: 0x0000aaaaaaab4998 memoffset-minimum-example`std::rt::lang_start_internal::h8c1220cbac1ca21e [inlined] std::panicking::try::h6bc78e31cf4d4a00 at panicking.rs:273:12
    frame #6: 0x0000aaaaaaab4970 memoffset-minimum-example`std::rt::lang_start_internal::h8c1220cbac1ca21e [inlined] std::panic::catch_unwind::h3e6ede07014eedd5 at panic.rs:388
    frame #7: 0x0000aaaaaaab4970 memoffset-minimum-example`std::rt::lang_start_internal::h8c1220cbac1ca21e at rt.rs:48
    frame #8: 0x0000aaaaaaaad970 memoffset-minimum-example`main + 40
    frame #9: 0x0000ffffbf5146e4 libc.so.6`__libc_start_main + 228
    frame #10: 0x0000aaaaaaaad86c memoffset-minimum-example`_start + 52
(lldb)

Compiled using rustc --version:
rustc 1.37.0-nightly (02564de47 2019-06-10)

That probably has the memoffset_constant_expression feature enabled because you used Rust 1.33 or newer? In that case it's "just" creating a NULL reference, which has been causing traps several times already.

Indeed, it's compiled with the memoffset_constant_expression feature enabled.

Btw, another way in which this is unsound is that it does not protect against auto-deref: Something like offset_of!(Box<Foo>, foo) will return utter garbage, and also cause UB.

@Gilnaa btw, see this thread on IRLO for a version of the macro that fixes most of these problems. The comment about references to uninitialized data being okay is incorrect though, but they currently cannot be avoided until the lang team makes progress on https://github.com/rust-lang/rfcs/pull/2582.
This macro doesn't work in const, but I am afraid that's just not a possibility right now. Also note that your macro does not work in const fn either, it only works in const items.

I'll try to take care of it over the weekend.
The version they use doesn't allow for all kinds of use cases the macro uses now, so I'll have to see if I can modify it.
I apologise for the delay.

AFAICT, there's no way to currently implement this correctly.
Using the pointer math is obviously not working.
I guess I should probably revert it to the older version by default.

Note that when you say &root you have already triggered undefined behavior because again, you assert with &root that you have a valid reference but you do not in fact.
cc @RalfJung

Why is that? Isn't it a valid reference to an invalid T?
Ignoring Deref, why is that UB?

@Gilnaa By "valid reference" here I mean that the answer to both questions in https://github.com/rust-lang/unsafe-code-guidelines/issues/77:

does &T have to point to allocated memory (with at least size_of::() bytes being allocated)? If yes, does the memory have to contain data that satisfies the validity invariant of T?

is "yes".
(Answering both "yes" renders "valid reference to an invalid T" a contradiction in terms)

I see.
So how does the MaybeUninit version solves this UB?

It doesn't. That's why I said above that implementing offsetof currently is impossible.
However, with MaybeUninit you can at least make a version that works, without causing SIGILL on ARM and other "fun" things.

Ignoring Deref, why is that UB?

One of the reasons we want it to be UB is that some people ask that a function like fn foo(x: &!) should be removed as dead code. We can only do that if &! is a type that cannot be inhabited, not even by safe code, without causing UB.
But that means &*MaybeUninit::<!>::zeroed().as_ptr() must be UB. We cannot allow a reference to an invalid !.

I've removed the unsound impl and yanked the affected version from crates.io

Thanks!
The remaining impl is also still unsound. If you wait until Thursday, you can make it use a version with MaybeUninit at least on newer rustc that support that? I can help review this if you want.
And probably, on old rustc the following is safer than mem::uninitialized:
let base_ptr: &$father = NonNull::dangling().as_ref();
let field_ptr = &base_ptr.$field;
let offset = (field_ptr as *const _ as usize) - (base_ptr as *const _ as usize)

Do you have any ideas for fixing the problem with auto-deref? TBH I am not sure if the API you want (that supports any number of nested fields) can be implemented correctly. And I am not talking about UB here, I am talking about:
struct S { x: u32 };
type Father = Box<S>;

let offset = offsetof!(Father, x); // *oops*

I don't think anyone is actually using the nested field syntax, but it's probably pretty easy to check.
If it's as I suspect, I'd rather drop this feature completely in favour of soundness.

Humm, it seems as if discord_game_sdk by @ldesgoui uses the nested version:
https://github.com/ldesgoui/discord_game_sdk/blob/master/mock/src/macros.rs#L20
$ rg from_ptr!
discord_game_sdk/mock/src/instance.rs
46:    from_ptr!(Instance, from_core, sys::IDiscordCore, interfaces.core);
47:    from_ptr!(Instance, from_application, sys::IDiscordApplicationManager, interfaces.applications);
48:    from_ptr!(Instance, from_user, sys::IDiscordUserManager, interfaces.users);
49:    from_ptr!(Instance, from_image, sys::IDiscordImageManager, interfaces.images);
50:    from_ptr!(Instance, from_activity, sys::IDiscordActivityManager, interfaces.activities);
51:    from_ptr!(Instance, from_relationship, sys::IDiscordRelationshipManager, interfaces.relationships);
52:    from_ptr!(Instance, from_lobby, sys::IDiscordLobbyManager, interfaces.lobbies);
53:    from_ptr!(Instance, from_network, sys::IDiscordNetworkManager, interfaces.networking);
54:    from_ptr!(Instance, from_overlay, sys::IDiscordOverlayManager, interfaces.overlay);
55:    from_ptr!(Instance, from_storage, sys::IDiscordStorageManager, interfaces.storage);
56:    from_ptr!(Instance, from_store, sys::IDiscordStoreManager, interfaces.store);
57:    from_ptr!(Instance, from_voice, sys::IDiscordVoiceManager, interfaces.voice);
58:    from_ptr!(Instance, from_achievement, sys::IDiscordAchievementManager, interfaces.achievements);

Hello!
I can probably update to not use the nested function anymore, I might have the time to do that tomorrow.
Please don't wait on _mock to get updated, I don't think anyone is using it aside from me as it's extremely incomplete, I think it's fine broken for the time being.
Thank you for checking which libraries would be affected though!

Oh, this is probably the reason why offset_of! was throwing SIGILLs in very particular cases (IIRC it only happened in threads), I had fixed the issue by binding the result to a const rather than to a let

Wait. Wouldn't forcing the constness inside the macro fix this? @ralfjung

What is the concrete proposal?

Declare a const  inside of the macro to force compile time evaluation, and return it.

But which implementation do you want to use in the const? The union-based one?
Not sure how I feel about that... UB during CTFE can't really propagate to run-time, at least currently. However, we reserve the right to make CTFE complain loudly and fail if your const-code causes UB.  We consider the fact that such code does not error a bug. So, your code would basically not be subject to Rust's stability guarantee.

Should this not be kept open until the soundness issue is resolved entirely (and not just the exploitable UB)?

Also, I have not looked closely at span_of but it's use of a Transmuter makes me suspect it has similar problems.

I think spanof originally used offsetof and it probably still can

I'll close this issue and open a new one discussing the remaining soundness problems. Most of the discussion here is not relevant any more.

New issue is at https://github.com/Gilnaa/memoffset/issues/24.