Middleware

During DPC @clue and I had a long chat about how to handle body parsers without loosing the current flexibility. We came to the conclusion that middlewares are the way to go. The following proposal is inspired by the WIP PSR-15 but doesn't implement it (I'll get back on that later in this PR).

Suggested reading order
This PR contains a lot of changes, how ever most of those changes are in examples and tests. Here is a recommended reading order:

README.md
MiddlewareInterface.php
MiddlewareStackInterface.php
MiddlewareStack.php
Server.php
Middleware/Callback.php
Middleware/LimitHandlers.php
Middleware/Buffer.php
The rest

Major changes
Where 0.7 only requires you to pass a callable to handle incoming requests, this PR proposes to use middleware for that. One way to setup middleware by passing an array with middlewares implementing MiddlewareInterface:
$server = new Server([
    new Buffer(),
    new Callback(function ($request) {
        return new Response(200);
    }),
]);

Or by passing in a concrete implementation of MiddlewareStackInterface:
$server = new Server(new MiddlewareStack([
    new Buffer(),
    new Callback(function (ServerRequestInterface $request) {
        return new Response(200);
    }),
]));

The latter is done automatically when doing the former internally in the server. But you can create your own middleware stack implementation and use that instead.
Included middlewares
This PR includes three middlewares Buffer, Callback, and LimitHandlers.
Buffer
Buffers the request body until it is fully in or when it reach the given size:
$middlewares = [
    new Buffer(),
];

Callback
Handles request just like 0.7 using a callback:
$middlewares = [
    new Callback(function (ServerRequestInterface $request) {
        return new Response(200);
    }),
];

LimitHandlers
Limits the number of concurrent request being handled at the same time:
$middlewares = [
    new LimitHandlers(10),
];

Body parsing
Currently one of our main issues with body parsing is the memory usage. But with the LimitHandlers we can pause the incoming request stream until we're ready handle it thus limiting the amount of memory needed to handle request. And with Buffer we can first stream the body in, parse it with for example BodyParser, and then hand it to the next middleware on the stack.
PSR-15
While the middleware implementation in this PR is inspired by the work done for the coming PSR-15 it doesn't implement it due to a small but major different. This implementation relies on promises where PSR-15 always assumes a response to be returned. An adapter for PSR-15 is beyond the scope of this PR but not for a Friends of ReactPHP packages and thus I've created for/http-middleware-psr15-adapter that utilizes RecoilPHP and on the fly PHP parsing and rewriting of PSR-15 middlewares.
With that package you can wrap the adapter around a PSR-15 as follows:
$middlewares = [
    new PSR15Middleware(
        $loop,
        'Namespace\MiddlewareClassname',
        [/** Constructor arguments */]
    ),
];

*Note: I've added last section to show how easy it can be to add PSR-15 middlewares, with the rewriting there is no guarantee for success

Ping: @clue @jsor @andig @marcj

Would it make sense- in terms of backwards compatibility- to allow the server to apply a bit of magic? If the parameter is a callable, wrap it in a Callback. If it's not an array, wrap it in an array? This would also allow for a bit less code and indents for something like the 95% use case?

@andig that does make a lot of sense to me, I'll update the PR with that later today 👍

@andig, @mdrost, and @jsor I've updated the PR with your suggestions and comments

Passing a Callback without array is not supported yet?

@andig it is, I've reverted that change and you can now pass in a callable, an array with middlewares or a middleware stack to handle your request.

@jsor Updated with your suggestions, had a lot of fun with the cancellation forwarding

Updated the PR (except documentation, examples and readme) turning all middlewares into invokables and also the MiddlewareStack. The idea behind it is that it doesn't require any code changes and thus is backwards compatible from the consumer end. Whilest still allowing us to add middleware
Ping @clue

@jsor updated your points and the examples

Extracted the Middleware Runner into #215

Extracted the Buffer middleware into #216

Let me start with saying awesome! :tada:  It's really nice to see how our discussion and our very quick prototype at this year's DPC turned out in this PR!
I'd love to get this feature in ASAP, but this PR contains quite a few changes, so it's really hard to review in its current state. I see you've started splitting this into smaller PRs (#215 and #216), which I think makes perfect sense, so let's get this rolling! :shipit:

@WyriHaximus thanks for all your efforts. Looking at react/http from consumer side I've been wondering why you're not using PSR-15?

@andig One of the reasons is that PSR-15 requires a response from the middleware where we return either a response or a promise (we wrap the response in a promise anyway). Also going with callable's opens up a lot more flexibility letting you use closures just as easily as [$class, 'method'] or $class that has a __invoke. In case you want PSR-15 I've crafted https://github.com/friends-of-reactphp/http-middleware-psr15-adapter so you can use PSR-15 middleware as react/http middleware.


Confusing account balances

I have 3 accounts: default, mixed11, Unmixed like screenshot bellow, I have DCR on Unmixed:

I set mixed is Unmixed account and unmixed is default account in stakshuffle page:

after that, I sent some dcr from Unmixed account like bellow:

after sent, all DCR balance in Unmixed move to default account and stakshuffle page show like bellow

@dreacot Is it a bug ?

i don't think so since, the balances now reflect what you set them to, i.e sending from mixed (unmixed) to unmixed (defualt)

i don't think so since, the balances now reflect what you set them to, i.e sending from mixed (unmixed) to unmixed (defualt)

I talking about why can balance move between 2 accounts while mixer is not running, i did not transfer money between those 2 accounts

Do you have the txid? It looks like the change address was taken from default and it spent one UTXO sending all the change as well back to default. What behavior was expected? Dealing with multiple accounts is kind of confusing.

it seems logical that after sending an amount, uxto will return the money to the mixed wallet, but would that make it confusing for users?


Please add install pulumi by binenv

Hello! Thanks for binenv.
Please add install pulumi by binenv.

I try add later
After https://github.com/devops-works/binenv/pull/97

Add by https://github.com/devops-works/binenv/pull/99


how to select the specific edge between both vertexs

OrientDB Version:
Java Version:
OS:
Expected behavior

Actual behavior

Steps to reproduce

hi @flyrainkey
do you have more details about this?
Thanks

hi @maggiolo00
Vertex v_Cookbook with name"A",Vertex v_Food with name "B" and Edge with label "e_CookWith".
I want to find out the edges that connect these two vertices ,to judge if the edge exist

hi @flyrainkey
with SQL or JAVA API?

SQL  and I use Python API

hi @maggiolo00
SQL and I use Python API

hi @flyrainkey
you can use the match statement
match { class : Cookbook , where : (name = 'A'), as : cook }
	.out('CookWith') { class : Food, where : (name = 'B') , as : food }
return cook.name,food.name

Thank you very much @maggiolo00
sql = "LET $good_cook = select from v_Cookbook WHERE name = '%s';" \                       "LET $food0 = select from v_Food WHERE name = '%s';" \                       "LET $food1 = select from v_Food WHERE name = '%s';" \                       "create edge e_CookWith from $food0 to $good_cook;" \                       "create edge e_CookWith from $food1 to $good_cook;" \                       % (foods, food0, food1)                         client.batch(sql)
I want to judge if  e_CookWith exist before create edge e_CookWith

hi @maggiolo00
How can I use your code insert into my code. if the edge exist I will not create edge ,else I will createedge

hi @maggiolo00
How can I use your code insert into my code. if the edge exist I will not create edge ,else I will create edge

hi @flyrainkey
with batch you can do something like this
let $good_cook = select from v_Cookbook where name = 'A'
let $food0 = select from v_Food where name = 'B'
let $food_edge = ( select from (select expand(inE('e_CookWith'))  from $good_cook)  where out = $food0[0].@rid)
if($food_edge.size() = 0){
	let $food_edge= create edge e_CookWith from $food0 to $good_cook
}
select expand(unionAll($good_cook,$food_edge,$food0))

Thank you very much @maggiolo00
This method works. you help me a lot .  and I want to ask one more question. why orientdb  documentation don't have these content or examples. I don't know where can I search method to solve these problem like these. Do you have any good suggestions or documentation ?

Hi @flyrainkey
OrientDB docs is under continuous development. We know it's far from being perfect, but we are committed to make it better every day. For now that's the main reference, so we cannot suggest any other resources
Thanks
Luigi


Detect old .dep/releases file to find out next release (and delete old file)

Just a suggestion for a smoother upgrade path - why not detect the presence of an already existing .dep/releases file to determine the last release number from v6.x and then clean up afterwards by deleting it?
I'm assuming the .dep/releases file is safe to remove after upgrading to v7?

It's possible to write such migration code, but instead, I wrote migration documentation. Why? Because it's easier. =)
I work on Deployer only on my spare time, and only because of my supporters on https://github.com/sponsors/antonmedv, so...
I have a big backlog of other important stuff to do too, like finally releasing v7. If you would like to write such code yourself? +tests of cause, it pretty complex actually. Might be lots of hidden underwater rocks.

Completely understand, it was just a feature suggestion. I love Deployer by the way.

I have created simple task for this, without tests, so use it with caution.
<?php declare(strict_types = 1);

namespace Deployer;

task('deploy:custom:deployer-migration', function (): void {
	$v6FileExists = test('[ -f {{deploy_path}}/.dep/releases ]');
	$v7FileExists = test('[ -f {{deploy_path}}/.dep/latest_release ]');

	if ($v6FileExists && !$v7FileExists) {
		$releasesLastRow = run('tail -n 1 {{deploy_path}}/.dep/releases');

		[, $lastReleaseNumber] = explode(',', $releasesLastRow);

		run(sprintf('echo %s > {{deploy_path}}/.dep/latest_release', $lastReleaseNumber));
		run(sprintf('rm -f {{deploy_path}}/.dep/releases'));

		writeln(sprintf('Migrated deployer v6.x releases file to v7.x latest_release file.'));
	}
});

And need to create .dep/releases_log with at least one row to have correctly set up previous_release in recipe/deploy/release.php

I created a small PHP script to convert the release files: https://gist.github.com/retiolum/1fa9a7511bc5095b33dc8c09224306a9


Selecting the Language model once prisma has been installed as an extension on Visual studio code

Once installed, make sure to select the appropriate language model to use it within Visual Studio Code.

Could we get this added in the docs (docs/content/200-orm/800-more/500-development-environment/100-editor-setup.mdx) ?  I'm sure a senior developer would probably know this but it confused me as a beginner.
I tried to create a PR, but I do not have permission to do so.

@jharrell

You should be able to fork the repo, make changes on your fork, and then submit those changes in a PR to our repo.
If you want to try that, please feel free to do so! But regardless, thank you for opening an issue 🙏

Hey @smashbrick, I created a PR with your suggestion: https://github.com/prisma/docs/pull/6307
I assumed you wanted to add this sentence in the VS Code section, right?

@smashbrick I took the liberty to merge the PR. Feel free to open another one if you still think it can be improved 🙏

You should be able to fork the repo, make changes on your fork, and then submit those changes in a PR to our repo.

Also, here's an article the explains how to create a PR in an open-source project 😄


chore(api): add rchash

Checklist

[x] I have read the coding guide.
[ ] My change requires a documentation update, and I have done it.
[ ] I have added tests to cover my changes.
[x] I have filled out the description and linked the related issues.

Description
Adding rchash endpint which will be used for testing.

my impression was that stuff that we use for testing should go into /debug?

@notanatol  yeah, but sooner or later all endpoints should be under same API, because debug API should be merged with main, right? Having this in mind this endpoint was added to main API.


Node Classification with Multiple Graphs

Hi, I am trying to do an implementation which requires to input multiple graphs for node classification task. All the examples I've seen so far was for graph classification for this case. Although I've seen building block diagonal adjacency matrix, I'm not sure if it is for graph classification or node. Also I didn't understand whether should I create a block diagonal matrix with feature matrix and labels too or not.
Let's suppose I have 20 different graphs(with different number of nodes, edges, features). And each node of every graph is labeled.
All the nodes in first 10 graphs are for training, all the nodes of the next 5 graphs are for val, and all the nodes of last 5 graphs are for test. What I'm trying to do is predicting labels of the nodes for the graphs in test-set. How can I input multiple graphs into GAT(or any other GNN) with these conditions for node classification task(not for graph classification).? If the solution is block diagonal adj. matrix, should I do the same for labels and feature matrix too?

Why you closed this issue? Have you found a solution?

hello, I also meet such problem. Do you know how to solve it? I have confused for one month


how to use ugc query ?

I'm new guy for rust, the query function not work, can some on explain it ,very thanks.
@Thinkofname @james7132 @ColonelThirtyTwo
    #[test]
    fn query_item() {
        let (client, single) = Client::init().unwrap();
        let a = client.ugc().subscribed_items();
        println!("{:#?}",a[0]);
        let test = client.ugc().query_item(a[0]);
        let mut f = match test {
            Ok(file) => file,
            Err(error) => panic!("Problem opening the file: {:?}", error),
        };
        f.fetch(|x| match x {
            Ok(_) => {println!("a")}  //not print
            Err(_) => {println!("b")}  //not print
        })
    }

The Steamworks SDK uses a callback mechanism to handle asynchronous tasks, like fetching User Generated Content. For the callbacks to work, you need to drive them through SingleClient::run_callbacks. You need to call this many times over a period of time, while the content is being fetched. Check the example in the README for how to do this


Update default docker files

Update the Dockerfiles in Rasa.

Add an image for ConveRT
Change the pipeline for the Dockerfile_full to not use pretrained embeddings (?)

Closing to issues with ConvertModel license

Closing to issues with ConvertModel license


Problem trying tesseract with other languages

I've just installed tesseract to try to write a python script. It works fine except when I try to use other languages. In windows 10 terminal I tried to see what kind of results it obtains with english and it works fine except for a few german letters. So I installed a few other languages to do some tests:
tesseract --list-langs
List of available languages in "C:/Program Files/Tesseract-OCR/tessdata/" (12):
chi_sim
chi_tra_vert
deu
ell
eng
equ
grc
ita
jpn
lat
osd
spa

But when I give the command...
tesseract german.jpg stdout -l deu

result:
Error opening data file C:/Program Files/Tesseract-OCR/tessdata/deu.traineddata
Please make sure the TESSDATA_PREFIX environment variable is set to your "tessdata" directory.
Failed loading language 'deu'
Tesseract couldn't load any languages!
Could not initialize tesseract.
I set the tessdata_prefix manually but it's like it doesn't recognize it.

TESTDATA_PREFIX
C:\Program Files\Tesseract-OCR\tessdata
What could be the problem?

yes, now it works. Thanks a lot!


Change starting position of buttons?

Is there any way to change the position of the Button Bar View to match this picture?

Notice how the text "Daily Top 10" is not all the way to the left to begin with even though that is the first View Controller. It starts off centered. Can I control this position as well with this library?

Hi @larrynatalicio
In order to achieve this, if you are using the ButtonBarPagerTabStripViewController, there's a property inside Style struct inside ButtonBarPagerTabStripSettings called buttonBarLeftContentInset. This float value represents the left inset for the first element in the button bar.
Remember to set it before the super.viewDidLoad() is called in your viewDidLoad.
`
class ButtonBarExampleViewController: ButtonBarPagerTabStripViewController {
override func viewDidLoad() {
    settings.style.buttonBarLeftContentInset = //inset goes here
    super.viewDidLoad()

}
`
Hope it helps! Regards,

I'm closing this due to the lack of an answer, but feel free to open more issues if you have further questions!

@fedeojeda95 I'd like to put the strip somewhere in the middle of the screen.. how do i do that ?


Audit ISSUES evm grpc

ISSUE 8: INTEGER OVERFLOW BREAKS gRPC COMMUNICATION FOR LARGE BLOCK HEIGHTS
The file x/crosschain/keeper/grpc_zevm.go contains an endpoint that allows for querying information about a block using its height. An unsigned integer is converted to a signed integer in two locations here, resulting in an overflow.
Typically, when a value for height is higher than the current block height, an error is thrown. However, when an overflow occurs, the code does not return an error and instead returns information about the latest block.
This could result in usability issues:
Other software that interacts with the node should correctly assume that they will get an error message on illegal block heights. They will for blockHeight < x <= MAX_INT64 but outside of this range they will get unexpected behaviour
All queries will break for very large block heights as it will be impossible to query any blocks with a height > MAX_INT64. The latest block will always be returne.

SOLVED: The ZetaChain team solved the issue by implementing necessity
checks.
Commit IDs :
•a5aa77681ced5ea20cacdcfb6bbd5bdb385bdd2c
•37de781c228c08fa79ef3c1ce45da9d8a685e2a7


WSL Win10 instructions accidentally removed in recent PR

#2969 accidentally undid the work of #2952. (See https://github.com/neuropoly/spinalcordtoolbox/pull/2969/files)

thank you for catching this @joshuacwnewton 😅


refactor: use newly renamed core library

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.107%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
111

Relevant Lines:
112

💛  - Coveralls


Empty LD file on missing build tools

Hi,
This is probably going to be a gotcha for beginners, it took me a while to figure out.
Building the blink example for the CH32V003 and i was getting a weird error on the ELF:
~/projects/ch32v003fun/examples/blink$ make clean
rm -rf blink.elf blink.bin blink.hex blink.lst blink.map blink.hex || true

~/projects/ch32v003fun/examples/blink$ make
riscv64-unknown-elf-gcc -o blink.elf ../../ch32v003fun/ch32v003fun.c blink.c   -g -Os -flto -ffunction-sections -fdata-sections -fmessage-length=0 -msmall-data-limit=8 -march=rv32ec -mabi=ilp32e -DCH32V003=1 -static-libgcc -I/usr/include/newlib -I../../ch32v003fun/../extralibs -I../../ch32v003fun -nostdlib -I. -Wall  -L../../ch32v003fun/../misc -lgcc -T ../../ch32v003fun/generated_ch32v003.ld -Wl,--gc-sections
riscv64-unknown-elf-size blink.elf
   text	   data	    bss	    dec	    hex	filename
      0	      0	      0	      0	      0	blink.elf
riscv64-unknown-elf-objdump -S blink.elf > blink.lst
riscv64-unknown-elf-objdump -t blink.elf > blink.map
riscv64-unknown-elf-objcopy -O binary blink.elf blink.bin
riscv64-unknown-elf-objcopy: error: the input file 'blink.elf' has no sections
make: *** [../../ch32v003fun/ch32v003fun.mk:146: blink.bin] Error 1

The source turned out to be an empty generated_ch32v003.ld:
total 788
drwxrwxr-x  2 _________ _________   4096 Mar  3 14:49 ./
drwxrwxr-x 14 _________ _________   4096 Mar  3 13:17 ../
-rw-rw-r--  1 _________ _________   3604 Mar  3 13:10 ch32v003fun-bootloader.ld
-rw-rw-r--  1 _________ _________  56470 Mar  3 13:10 ch32v003fun.c
-rw-rw-r--  1 _________ _________ 720100 Mar  3 13:10 ch32v003fun.h
-rw-rw-r--  1 _________ _________   4658 Mar  3 13:10 ch32v003fun.ld
-rw-rw-r--  1 _________ _________   5130 Mar  3 14:49 ch32v003fun.mk
-rw-rw-r--  1 _________ _________      0 Mar  3 13:10 generated_ch32v003.ld

I think I caused this by running build before installing the toolchain.
There are probably a few solutions to this, but I dont think it would hurt to check the generated LD is not empty in the build scripts.
That seems like a reasonable sanity check.
Kind Regards.

same as #283

Weird that did not come up when I searched.
This can be closed as a duplicate.


[ ] Branch.Helpers :: Converters

[ ] Branch.Helpers :: Database

[ ] Branch.Helpers :: DocumentDb

[ ] Branch.Helpers :: Extensions

[ ] Branch.Helpers :: Services

[ ] Branch.Helpers :: TagHelpers

[ ] Branch.Service.Halo4 :: Database

[ ] Branch.Service.Halo4 :: DocumentDb

[ ] Branch.Service.Halo4 :: Exceptions

[ ] Branch.Service.Halo4 :: Extensions

[ ] Branch.Service.Halo4 :: Models

[ ] Branch.Service.Halo4 :: Services

[ ] Branch.Service.XboxLive :: Database

[ ] Branch.Service.XboxLive :: DocumentDb

[ ] Branch.Service.XboxLive :: Extensions

[ ] Branch.Service.XboxLive :: Services

[ ] Branch.Service.Xuid :: Database

[ ] Branch.Service.Xuid :: Exceptions

[ ] Branch.Service.Xuid :: Extensions

[ ] Branch.Service.Xuid :: Models

[ ] Branch.Service.Xuid :: Services

And for the love of god, please write docs as I go from now on.


ccma fix date parsing

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[x] Read adding new extractor tutorial
[x] Read youtube-dl coding conventions and adjusted the code to meet them
[x] Covered the code with tests (note that PRs without tests will be REJECTED)
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
This PR fixes the date to the way ccma provides it as well as fixing some broken tests
closes #30961

The download tests are failing. Please check if this is happening locally. Both in Py 2.7 and Py 3.9 there's 403 on extraction in one test, and failing to get the timestamp/upload_date in others. Possibly the webpage is somehow not being decoded into UTF-8.


JobCN feature

This pull requst is for JobCN feature #185

add FFaker::JobCN module
add job_cn/job_nouns
add unit tests

@rocknruby changes on gemspec has been reverted, please review.

:+1: from here


Please add the support of Xiaomi Gateway 3

Hello! Would you please add the support of Xiaomi Gateway 3. There is a 'Mi Aqara' plugin on homebridge but it can just support the gateway 2. Hope you can write a plugin for gateway 3.
model: lumi.gateway.mgl03
the photo: https://sc04.alicdn.com/kf/H4a6227477676432ab8d3ed5c378a62b4R.jpg
the homeassistant plugin: https://github.com/AlexxIT/XiaomiGateway3

Hi,
I was wondering why would you like to have the gateway in homekit? What would you like to control on it?

Oh, there are many sub devices under the gateway, like motion sensor and outlet. I want this plugin to support the sub devices mainly, not just the gateway : )

This as far as i saw is not possible. You can only control the gateway like enable/disable some settings (led, alarm) but there is no access to the bridge sub devices.

You can now add the gateway to this plugin and use the propertyControl to expose any functionally which you want as of version 1.0.0.


Investigate: Improve the performance of success and error responses

Per Heath's comment: https://github.com/Azure/azure-sdk-for-net/pull/9080#discussion_r356843416

work with service team to document result sort order, if possible
reimplement merge algorithm

FYI @mssfang

Hopefully with the work on https://github.com/Azure/azure-sdk-for-net/issues/8704 we might be able to see if this is a concern or not

I believe that we are good for now. We have added performance tests. If we see a regression we will start looking here.
I will close this issue and will reopen when needed


feat: improve banner to have optional body

Issue
Improve banner to have optional body
Description

Additional context

📚  View the storybook of this branch here

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Gravitee.io Automatic Deployment
A prerelease version of this package has been published! 🚀
To use it in your project run the following lines:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:tada: This PR is included in version 4.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


stopped_as_optional should handle void senders

 Issue by ericniebler
Friday Oct 22, 2021 at 00:55 GMT
Originally opened as https://github.com/NVIDIA/stdexec/issues/222

... by mapping void to some unit (monostate?) type.

Yes


fix mingw build issue [skip travis]

[ ] Did you create an Apache Jira ticket?  (not required for trivial changes)
[ ] Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?  (not required for trivial changes)
[ ] Did you squash your changes to a single commit?
[ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"

I am able to reproduce this locally on my laptop, working on it.


Update RxSwift dependency to 4.0.0

Sets RxSwift dependency to ~> 4.0.

Codecov Report

Merging #1385 into 10.0.0-dev will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           10.0.0-dev    #1385   +/-   ##
===========================================
  Coverage       88.41%   88.41%
===========================================
  Files               5        5
  Lines             164      164
===========================================
  Hits              145      145
  Misses             19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a951eea...ef13598. Read the comment docs.

@devxoul Thanks! We should also update Package.swift I believe.

@sunshinejr sure! Did it :)

SwiftLint found issues
Warnings

File
Line
Reason

Package.swift
44
Lines should not have trailing whitespace.

Package.swift
9
Collection literals should not have trailing commas.

Package.swift
15
Collection literals should not have trailing commas.

  Generated by :no_entry_sign: Danger


CAMEL-15195: Camel-netty - RequestTimeout seems not working as expected

add back the codes which removes the "timeout" handler after receiving the response
add the "timeout" handler when activating from the connection pool

https://issues.apache.org/jira/browse/CAMEL-15195

Backport this to the 3.4.x branch as well

@zhfeng can you open a PR on 3.4.x too? The backport action still has some troubles.

@oscerd sure, I will do.


remove preview from host.json and docs

remove preview from docs and host.json

Going to keep it as draft until the GA.


add utilities for cli custom plugins

Talked to Shawn on slack and figured stdin is the best way to proceed for now because of the following:
given that the unstructured data can sometimes be long JSON string, passing that in with a reader (stdin now, could be a protocol on the wire in the future, http/grpc idk whatever makes sense in the future) is better because
1. you dont have to debug long string in a command line flag
2. makes transitioning to any of the reader type system easier in the future if there is indeed a need


Removed checks for user properties in MQTT v3 and instead ignore them.

Fixes https://github.com/chkr1011/MQTTnet/issues/848. For me, the argumentation under the issue seems valid.

Please add an entry at the nuspec file so that this change is documented.

@chkr1011 I have updated the .nuspec file.


Git builder should reject the push in case of an error

If the build step (kontena build) exits with an error, the push should be rejected.
PR attached https://github.com/kontena/kontena-git-builder/pull/6

The attached PR is merged, closing


Session reset

No visual ui changes.

I'm not sure how the start_url code could have ever worked. We are clearing it out of the session before we even read it.
session_reset now resets the session, and session_init now sets it.
Logic about what is wrong with a session is moved into user_validation_service, the code that actually uses this information.

I split this up into 3 commits to show the steps of the refactoring. Let me know if this is not clear.
/cc @dclarizio

thanks. change the name of the variable and the method

@kbrock Any chance of getting a spec around this code?  Or is the level of difficulty too high?
Nice PR - I am ready to merge it pending answer of question about specs.

@kbrock I verified that this PR fixes the issue when accessing the UI from a URL directly pointing to an object (i.e. http://<IP_ADDRESS>:3000/host/show/1r11), the incoming URL was not being saved and the user would end up at the Dashboard after login.  With this PR, this now works again, so the user ends up on the screen from the target URL.  I'm wondering if we should open a BZ and apply this fix to 5.4.z?

@dclarizio that is a 1 line fix, I could put in a smaller fix for that.

yes. :+1:


Add Nginx.NginxPlus swagger version 2021-05-01-preview

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[x] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
5/24/2022
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
5/2022
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[x] SDK of .NET (need service team to ensure code readiness)
[x] SDK of Python
[x] SDK of Java
[x] SDK of Js
[x] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Please not to merge it until 5/23/2022. Thanks!

Hi @honghr, could you please merge this PR? We are ready for the swagger to be public. Thanks!

The swagger in private repo: https://github.com/Azure/azure-rest-api-specs-pr/tree/RPSaaSMaster/specification/nginx/resource-manager/NGINX.NGINXPLUS/preview/2021-05-01-preview


[InAppMessaging] Ignores target and scheduling & always shows message, at least on test device

[READ] Step 1: Are you in the right place?
yup
[REQUIRED] Step 2: Describe your environment

Xcode version: 11.3.1
Firebase SDK version: 6.15.0
Firebase Component: InAppMessaging
Component version: 0.16.0

[REQUIRED] Step 3: Describe the problem
Steps to reproduce:

Create first campaign:

set type as banner
in "Target" set App = this app, and User Property "pro" does not contain "true"
in "Scheduling" remove the default event onForeground, and add a custom event. Set a breakpoint in the code at the only place this custom event is ever reported
set start date as now, end date as Feb 1
save campaign as draft

On simulator: erase all content & settings
Start app on simulator: make sure custom event breakpoint is never hit [ok], make sure user property "pro" is set to "true" [ok]
Verify in web console's DebugView that simulator's user property "pro" = "true" [ok]
Stop app on simulator
Get instance ID from xcode console, re-open draft campaign from step #1, add instance ID as Test Device, hit test
Start app on simulator, verify custom event breakpoint is never hit [ok]

Expected behavior:
On the first screen of the app no message is shown because the custom event was never reported and also the user property excludes this user from being targeted
Actual behavior:
The banner/message is immediately shown on the first screen of the app, ignoring targeting and scheduling.
I have also tried on real devices, no difference from simulator.
Is this a bug or expected functionality of test devices? If the latter, how to test it? I cannot launch this campaign/code without testing that it works.

This is a larger project to consider targeting in our test on device flow. We are adding it to our roadmap.

Closing this because this behavior is working as intended.


ImportError with libcblas on macOS

When attempting to import the pyccl library after installation, I encounter the following ImportError related to the libcblas library not being loaded:
import pyccl
File ~/anaconda3/lib/python3.11/site-packages/pyccl/init.py:22
from . import ccllib as lib
File ~/anaconda3/lib/python3.11/site-packages/pyccl/ccllib.py:16
from . import _ccllib
ImportError: dlopen(/Users/qijingzhao/anaconda3/lib/python3.11/site-packages/pyccl/_ccllib.so, 0x0002): Library not loaded: @rpath/libcblas.3.dylib
Referenced from: <85EFA90A-BE88-35A7-AD9E-F20432CD4AFA> /Users/qijingzhao/anaconda3/lib/libgsl.25.dylib
Reason: tried: '/Users/qijingzhao/anaconda3/lib/libcblas.3.dylib' (no such file), '/Users/qijingzhao/anaconda3/lib/python3.11/site-packages/pyccl/../../../libcblas.3.dylib' (no such file), '/Users/qijingzhao/anaconda3/lib/python3.11/site-packages/pyccl/../../../libcblas.3.dylib' (no such file), '/Users/qijingzhao/anaconda3/bin/../lib/libcblas.3.dylib' (no such file), '/Users/qijingzhao/anaconda3/bin/../lib/libcblas.3.dylib' (no such file), '/usr/local/lib/libcblas.3.dylib' (no such file), '/usr/lib/libcblas.3.dylib' (no such file, not in dyld cache)
I would greatly appreciate any guidance on resolving this issue.

Looks like some dependency is missing, maybe try to install openblas conda install anaconda::openblas.

Looks like some dependency is missing, maybe try to install conda install conda-forge::libcblas.

Thank you for your reply, but it's still not working.

I am having the same issue - how did you manage to resolve this?

I have the same issue - please can you let me know how you resolved this?

Installing cmake and swig might solve this problem pip install swig

Thank you for your reply. Unfortunately I'm still getting the same error.

We did have some success with this same issue by first installing libcblas (conda install -c conda-forge libcblas) and then installing pyccl (conda install -c conda-forge pyccl). It may be worth ensuring pyccl is completely uninstalled before trying though...


VSCode Insiders integration

I've started using insiders because of the multi-folder projects (workspace). In traditional VSCode I'd set and simple .vscode/settings.json with the following:
{
  "phpmd.rules": "my/ruleset.xml",
}

The thing is that as now I'm working on multiple folders, and every one have its own .vscode/settings.json my rulesets are not being read.
It'd be nice that every project folder read it's own .vscode/settings.json in order to check the PHPMD rules. Right now, under this config that custom rulesets are not being loaded at all.
Thanks in advance

What I've done temporarilly is to point to a global ruleset in the general settings. That way the ruleset I need are being check the way I need. Anyway, I rather use particular ruleset.xml per project. But just for all people know if they have the same issue

Thank you Nahuel for your feedback and feature request. This would indeed be a big improvement. Once I get some spare time and start working on the next version of the extension I will look into this.

This can be achieved with ${workspaceFolder} sinc PR #51


Refactoring.

remove unnecessary code.
change method names in Router. (withDevTools)
simplify server method.
explain reason for render twice on client method.

I have published v0.0.2-alpha2 what applied recent changes.


⚠ Exoticaz has degraded performance

In 4dcaa43, Exoticaz ($EZ) experienced degraded performance:

HTTP code: 200
Response time: 9322 ms

Resolved: Exoticaz performance has improved in 59b9b64.


Possible incompatibility with chat mod

Minecraft version 1.21
Loader fabric, version 0.15.11
When installed on a server alongside styled chat the player gets kicked out with the error "io.netty.handler.codec.DecoderException: Failed to decode packet 'clientbound/minecraft:system_chat"
Steps to reproduce

have magic particles installed and the chat mod too
apply any particle effect

Full stack trace
https://gist.github.com/xela-the-proto/0ac707c7a78450eacd86266b4fd64266

nvm it aint the mod i tested after posting the issue and it still crashes im a dumb dumb


Active nav state missing on migrating>guide>design/develop pages

Bug🐛: Active nav state missing on migrating>guide>design/develop pages
Page: https://next.carbondesignsystem.com/migrating/guide/design, https://next.carbondesignsystem.com/migrating/guide/develop
Browser:
Suggestion: Add hasTabs: true to nav-data.js file for those two pages
Originally posted by @alisonjoseph in https://github.com/carbon-design-system/carbon-platform/discussions/1268#discussioncomment-3663651

Hey team! Please add your planning poker estimate with Zenhub @andreancardona @francinelucca @jdharvey-ibm


Suggestion/Question: Incorporate @apideck/better-ajv-errors option

@apideck/better-ajv-errors is a pretty popular library for parsing ajv errors, at the time of writing this npmjs.com shows it at roughly ~2.8m downloads a week (https://www.npmjs.com/package/@apideck/better-ajv-errors).
The main function exposed by that library is betterAjvErrors() which needs to be passed not just the errors from ajv but the schema and the data that was used with ajv's validate function.
Being that this package (express-json-validator-middleware) sits in the middle of ajv & express by the time we can access the errors it is too far downstream to have on hand references to the data or the schema that was passed to the validate middleware method.
Would there be appetite for officially supporting an option to have the errors that are passed to next() be parsed by @apideck/better-ajv-errors?
Some pro's & con's I can think of quickly:
Pros: 1) this is already a library that is very convenient so seems to double down on the purpose  2) currently missing any flexibility on errors that make it to next() so it puts users in a position of having to incorporate parsing retroactively in the error handler rather than error creation  3) May bring some new life into this package as better-ajv-errors is pretty popular
Cons: 1) adds a dependency to @apideck/better-ajv-errors 2) I believe @apideck/better-ajv-errors only supports JsonSchema6 (I think this currently allows 5, 6, or 7).
I've taken a really quick & dirty stab at roughly what it could look like here (most likely missing somethings or not 100% right. Contains some breaking changes regarding constructor/middleware parameters as well.):
https://gist.github.com/shane-js/58f1765e62ce6a170d3113e71c9b492c

If there is no interest in the above:
If we didn't want to couple express-json-validator-middleware to that specific ajv error parsing package, perhaps instead we can look at a way to at least rework what gets passed to next() to include the data + schema that was used to produce the errors? That way at least downstream users could rework the errors as they see fit and to the needs of whatever they are exposing the errors to.

Thanks for putting together this detailed proposal and proof of concept, and sorry for the delayed reply.
Unfortunately as @apideck/better-ajv-errors only supports JSON Schema Draft-06, and this library uses Ajv v8, which supports Draft-07 by default (docs), I don't think it's a good idea to integrate @apideck/better-ajv-errors.
I'd love to see a PR which adds data and schema into the error object that is passed to next() though. That would be a nice improvement and make things much more flexible for end users, who can then chose to integrate a library like @apideck/better-ajv-errors if they wish.


GUI Interface

On the GUI Admin screen connection status there is a status for the wireless.  Is there a way to get the statistics of the ethernet aka hardwire?

Edit line 46 of /var/www/html/index.php: change the "false" to "true".  Then reload the GUI admin page.  You'll see a "LAN connection status" link on the left.
Please let me know how it goes, especially if you click on the "Stop eth0" button.  That hasn't been thoroughly tested.
Eric

Eric,
my line 46 had this listed in it
  " 46 define('RASPI_HOSTAPD_CONFIG', '/etc/hostapd/hostapd.conf');"

this is my version number
" 13  * @version    0.0.1"
Thanks
Mike

Mike,
Do you have the new code that was uploaded a few days ago?
If not, you might want to download all three pieces: "allsky" (the bulk of AllSky), "allsky-website" (optional website), and "allsky-portal" (the GUI).
If you do, you'll need to change permissions of script/copy_notification_image.sh to 775, and may need to increase your "USB Bandwidth".
Eric

I uploaded to the newest version of allsky.  I do see the "LAN Dashboard"  the Stop eth0 button does not appear to do anything or at lease I am still seeing activity on the stats.  I click the stop etho button and click on the refresh button and the statistics updated.  is there a way to change the interface name it is currently set to "wlan0"
A big thanks to  all the developers and testers who keep making updates enhancements to the software.

Ooops.  That was a copy/paste error.  Line 65 of includes/dashboard_eth0.php has "wlan0" - change to "eth0".
I'm pretty sure the problem is that the "pi" user doesn't have permission to turn eth0 on and off.  Add a couple lines to /etc/sudoers.d/allsky that look like the "wlan0" lines but say "eth0" instead.  You'll need to sudo in order to edit the file.
Then try the "Stop eth0" and "Start eth0" and let me know how it goes please.
Eric

I made the changed and now it show correctly.
I added the lines to the allsky file, rebooted the pi and still unable to stop the eth0.  not a show stopper.

Mike,
Thanks for trying.
I just ordered another Pi to play around with, so I'll see if I can get it to work. I'm sure the fix is trivial, once I determine what it is.
Eric

Eric,
I still have to modify this line
"Line 65 of includes/dashboard_eth0.php has "wlan0" - change to "eth0"."
Mike

That line is FYI and doesn't actually do anything but changing it is a good idea.

closing this due to it working correctly.

Mike,
are you saying it now stops / starts eth0?  If so, that's great - what did you do to get it working?

nope that still does not work.  I am closing it because the original issue of the eth0 not showing up.  the start and stop was a after thought.

Mike,
My test Pi arrived today so I can test it myself.  Thanks for the initial test of the page.  I'm glad at least that's working.  I'm sure I'll be able to get the start/stop working, too.
Eric


Create GitHub Pages  #6

Create GitHub Pages  #6

Coverage remained the same at 100.0% when pulling 5a1f129d21688808106d0c3ae41ec2d429242f96 on joseph-mccarthy-patch-2 into 948207e69c517e101033b32aa4c651e5288061c5 on master.


Add movie counter

In this pull request I have implemented the item counter to count all of the movies and displaying it in the home page
@Boku52500 please take a look

Great job Muzzafer. Everything looks great! It is ready to merge.


Change name, version and add LICENSE

Closes #281

I've changed the license and updated every occurrence of the old name which means that it'll fail to build until we rename the repo.
@ngua

@adamczykm The build issue is because you changed the haskell.nix selector without changing the project name. I can fix that, it should build after that. We'll change the actual repo name soon


Expose parseTimeString method and move it to companion object of TimeRangePicker.Time

This PR changes the implementation of parseTimeString (parsing time is not something complex like parsing e-mail and it can be replaced to simpler implementation). For testing and architectural reasons, it can be exposed and moved to companion object of TimeRangePicker.Time. To ensure that new method works in corrent way, tests was added.

Thank you a lot again! Looks good and is definitely an improvement!
I am sure there are definitely way more improvements that can be made.


add  tag in comments.

Proposed changes
This PR beautify SDK javadoc.

add  "<p>" tag that required new line.

Types of changes
Please put an x in the boxes related to your change.

[ ] Bugfix
[ ] New feature or enhancement
[x] Others

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING GUIDELINES doc
[x] I have signed the CLA
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Related issues

Please leave the issue numbers or links related to this PR here.

Is this made from swagger codegen? Did you apply latest yaml file?


Increase TextField font size from 13px to 16px

Backwards Compatibility Implications
None
New Features

TextField font size increase from 13px to 16px

Bug Fixes
None

This should be released on it's own, to allow people to rollback if they increase in size breaks layouts


Downloading jboss logging jar for keycloak login module support

Describe the bug
As the new broker distribution migrated its logging from jboss logging to slf4j/log4j 2, the jboss logging jars are not shipped.
However the keycloak client(12.0.3) still depends on jboss-logging. The init container should added those jars in case the keycloak login module is configured.
To Reproduce
Steps to reproduce the behavior:

Get X version of the source
'...'

Platform (please complete the following information):

OS: [e.g. Fedora]
Version [e.g. 32]
Container build tool [e.g. Podman]

Expected behavior
Optional, use if not obvious. A clear and concise description of what you expected to happen.
Screenshots
Optional, add screenshots to help explain your problem.
Additional context
Optional. Add any other context about the problem here.

@gaohoward  based on @brusdev comment above I think this one should be closed. Do you agree?

After discussing it with @gaohoward we agreed that it can be closed.


Emulator simulation is User Terminals version 2 or User Terminals version 3 ?

Hello，Could you tell me which version the emulator simulated，thank you !

The provided Device Tree is the one of version 2 (rev2_proto3), as you can see here


Separate font cache per renderer instance

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Introduce support for correlation ids

What does this PR do?
This PR adds the possibility to add correlation id headers to a frontent. If enabled, every incoming request will have a X-Correlation-ID header added containing a random UUID. If the header is already present, it will not get changed. The header name and content are also configurable.
Motivation
In our environment we make heavy use of correlation ids to track requests throughout our mircoservice infrastructure. We recently moved from Nginx to Traefik and it brought us a lot of benefits, but the possibility to add custom headers is somewhat limited compared to Nginx. We need to add a new random UUID to every requests that comes in from outside our infrastructure to properly track it's path through the enviroment. This could have been done with the help of custom request headers, but those have some disadvantages:
If the header is already present, it will get overwritten. Also you cannot generate a new random UUID for every request. All you could do is generate a random UUID for every frontend each time Traefik reloads the configuration ( with the help of the spring template library ) but then you can have a lot of requests with the same correlation id. This is why we wrote a http middleware that adds these headers to every incoming request and would like to add it here.

FYI, we accept only bug fixes on 1.7 https://github.com/containous/traefik#release-cycle

Hi and thank you for your contribution and hard work on improving Traefik.
Unfortunately, we cannot accept this pull request “as is” since, as announced previously (and stated by ldez before), the 1.7 branch doesn’t accept new features any more (only master does).
That being said, since it will require quite some work, we encourage you to write and submit a proposal before rebasing this on master because even if it works and meets some  use cases, it’s not guaranteed that every maintainer will agree on the feature being included in the project. We’ve already had related PRs that were rejected (#2290 ), so it’s best to discuss this beforehand.
Thanks again! Looking forward to discussing this further with you!

@JanMa
So I found a workaround.  You can enable the Jaeger tracer and set the sampling rate to 0, but it will still send the header.  Some quick benchmarks show that it doesn't add any significant overhead.
[tracing]
  [tracing.jaeger]
    samplingParam = 0
    traceContextHeaderName = "X-Correlation-ID"

or if you use enviroment variables like me:
TRAEFIK_TRACING: "true"
TRAEFIK_TRACING_JAEGER_SAMPLINGPARAM: 0
TRAEFIK_TRACING_JAEGER_TRACECONTEXTHEADERNAME: "X-Correlation-ID"


Pressing enter in terminal find searches backwards.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.62.0
OS Version: Windows NT x64 10.0.19042 (20H2)

When using the find functionality in the terminal, pressing enter moves the search to the previous item (updards) instead of to the next item (downwards), like using the find options elsewhere
Steps to Reproduce:

Open a terminal inside VS Code
Run some commands in the terminal
Open the find menu in the terminal using ctrl+f
Enter a term that occurs more than once in the terminal into the find bar
Press enter to cycle through the found occurrences of the search term

This is intended. In terminal most recent info is at the bottom so Find highlight most recent match at the botto. Enter navigates to next most recent match - therefore from bottom to top.
You can change this behavior by swapping keybindings for workbench.action.terminal.findPrevious and workbench.action.terminal.findNext, however I don't think that it's possible to start matching from the top (first highlighted match will be at the bottom).


Bootloader

Add "advanced" menu with flash bootloader option.
Allow for automatic flashing of binaries compiled for the bootloader

Did a pretty full test:

Used Programmer to flash EraseQSPI bin file via system bootloader
Used programmer to flash custom bootloader
Connected to custom bootloader
Flashed Aurora firmware as test.

Everything works fine!
I don't love where the Advanced button is, but I think for the time being it's okay. Once we add some more thorough documentation and actually release the bootloader I'd kind of like to do a visual update on the whole programmer site in general. So I think it's fine for now.


Fix for #430

Oh, great catch! Wonder if they are just outdated examples or I messed up :wink:
:+1:

too fast... cool thanks


fixed race conditions by waiting for promise to complete.  updated tests

I believe that this fixes the race conditions that we were seeing.  I have also updated the tests to ensure that save is working correctly by testing values.
I am not sure that this resolves the issue that I saw where random blank records showed up in the model.  They seem to disappear when the app is reloaded.  Without the ember inspector it is hard for me to debug this any further.
Next to do will be to actually test the storage url before saving it.

I looked at the AppVeyor details but I can't figure out what went wrong.

@traceyt: Not your fault, we still have trouble with automated Windows testing. Should be resolved once #318 is closed.
Code looks very good to me, I have just one comment: You have a lot of var self = this in there. That's only needed if you switch scope (usually with a function callback, eg: myAsyncTask().then(function(result) { });. However, whenever you use the fat arrow notation myAsyncTask().then((result) => { }), there's no context switch - this remains the same :)

I will go back and look that the self = this.  I might be mistaken but I thought I did this because I did lose context.  Probably not given the recommendation to take them out :-).
Happy to abstract the code block.  I was not sure what the guidance was and actually meant to ask one of you guys.  Now I know.

I am going to need some help in resolving my conflicts :-(.


[HUDI-5058] HoodieCatalog#getTable sets primary key with hoodie.datasource.write.recordkey.field for table initialized via Spark

Change Logs
HoodieCatalog#getTable should use hoodie.datasource.write.recordkey.field to set the primary key of the table initialized via Spark.
Impact
HoodieCatalog gets the table with the primary key initialized via Spark.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[x] Adequate tests were added if applicable
[x] CI passed

@danny0405, I have updated the TestHoodieCatalog#testGetTable to verify whether the primay column is correct for HoodieCatalog#getTable. PTAL.


Testing update

👷 Deploy Preview for sit-cybersecurity processing.

Name
Link

🔨 Latest commit
d501b71f204fe691f2ff9968aa96c08432b9540d

🔍 Latest deploy log
https://app.netlify.com/sites/sit-cybersecurity/deploys/64be13b4db3dbc00070d1fdd


Collect Mozilla

Fixes #78. ~Most of~ the work is done. Here's the checklist

[x] Parsing for mozilla data source
[x] Working mozilla importer
[x] Migrate to GitDataSource
[x] Write test cases
[x] More verbose comments
[x] Update dependencies

Currently, it requires ~two~ extra dependencies: ~PyGithub~ and markdown
~I would eliminate the PyGithub dependency next but~ I think markdown has
to stay.
~Final dependencies would be comitted later.~
I would also really like advices on

The FIXMEs present in current code.
Should we mark all the pks <= resolved pkg as vulnerable as mozilla doesn't ship that information

This is how it looks for now

Signed-off-by: Hritik Vijay<EMAIL_ADDRESS>

@sbs2001 any update ?

@Hritik14  are you sure, you pushed the changes ?

@sbs2001 ah, not yet. I actually replied on the requested changes. I'm not sure if you get notifications for those replies. Do let me know and I'll leave a comment next time as well.

I've refactored as suggested and also added a helper functions to split markdown and the front matter. I'd add it to the istio importer after this PR is merged.

rebased

@sbs2001 any update ?

@pombredanne Thank you for the through review. Please check unresolved conversations and I'll push the updated code.

@Hritik14 done :) Thank you for having looked at all these in details!

@pombredanne  re zip files: see https://github.com/nexB/vulnerablecode/issues/442#issuecomment-822368195 .
@Hritik14  IMHO mocking the whole GItDataSource's logic of collecting changes is redundant, since there are thorough tests of that already. There is some mock db things which IMHO is also not required . Instead you could just test the to_advisories and see whether correct Advisory objects are returned.  It's fast (no need to setup DB and such) and easy to implement.
Something like https://github.com/nexB/vulnerablecode/blob/main/vulnerabilities/tests/test_retiredotnet.py . There are tests which do check what ends up in db, but I think those should be limited and ideally should write small amounts of data.

@Hritik14 do you mind to rebase?