Automated cherry pick of #5922

Cherry pick of #5922 on release-5.27.
/cc  @nevyangelova

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: acef7629bdb455a66d92f064525d426c17dcac4b


Backup / Restore does not recover everything

In my configuration of the i-gate when doing backup/restore it does not recover:

second wifi; only the first wifi will get restored  (I did not try more then two wifi)
Longitude and latitude will be empty after restore
some other fields for example "TX" enabled.   (I did not check all of them)

Thanks a lot,
Werner

Can you try the manual insert of the data ? Sometimes when new things are added , the restore process won't work with old restore JSON files that have less variables

It's not old data. Backup and restore was both today with same version of firmware.

Can you test with github firmware and install it with vscode (this has the latest updates ) lot more than web installer that's gets updated tomorrow (hopefully)

Could this be related to the WebUI config parsing issue that I reported in https://github.com/richonguzman/LoRa_APRS_iGate/issues/58#issuecomment-2126659847 ?

I did not load the latest firmware with vscode. Still have the problem when restore the backup that for example the 2nd wifi is missing. But could also be a refresh problem of the browser. Could be that just after the restore it does not display all the values in the browser. When clicking a bit around the 2nd wifi suddenly was displayed. But I did not check further...

because of lately mods to the code the full download from github (as full and last updates are there) is needed
or use the "old" 2024-04-13 firmware from web installer


feature: add html_tag conceal & arrows rendering?

Is your feature request related to a problem? Please describe.
Hi, really nice plugin.
Could it possible add conceal for:

html_tag, I can find it useful especially in some <u>Hello World</u> to be just 'Hello World’ underlined or other similar usages
arrows in markdown replaced by default icons or chosen by user:

→: →
←: ←
↑: ↑
↓: ↓
↔: ↔
⇆: ⇆

Describe the solution you'd like
For the arrows, I was already using these queries for treesitter for markdown_inline:
((entity_reference) @conceal (#eq? @conceal "→") (#set! conceal ""))
((entity_reference) @conceal (#eq? @conceal "←") (#set! conceal ""))
((entity_reference) @conceal (#eq? @conceal "↑") (#set! conceal ""))
((entity_reference) @conceal (#eq? @conceal "↓") (#set! conceal ""))

..and this for the html_tag:
(inline (html_tag) @conceal (#set! conceal “”))

Describe alternatives you've considered
Use a custom query for markdown_inline as I’m already doing
Additional information
No response

I gave it some thought, kind of went back and forth, but I think for now I'm going to stay out of the HTML parsing space.
I appreciate the idea, and there's nothing wrong with it, other than I don't put HTML in markdown and don't want to open up that can of worms. Currently the plugin stays pretty tightly connected to basic markdown syntax and I think that's where I'm going to keep it.
The various arrow entities living in users highlight extensions is probably the right way to go. You can potentially try to put this in nvim-treesitter where there are some entity replacements already: https://github.com/nvim-treesitter/nvim-treesitter/blame/master/queries/markdown_inline/highlights.scm#L100, though maybe since these are icons as opposed to standard characters they might also prefer to have users configure it themselves.
This plugin does offer an extension point if you want to try adding the HTML concealing yourself: https://github.com/MeanderingProgrammer/markdown.nvim/blob/main/doc/custom-handlers.md, happy to help if you wanna try it out.


video player in https://immerjs.github.io/immer/ is shaky when moving timer

Chrome Version 79.0.3945.130 (Official Build) (64-bit)
OS ubuntu 18.04

I created a small pull request to fix this

:tada: This issue has been resolved in version 5.3.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix cmake export files to allow cross-compilation with sysroot

Pinocchio version: from 2.7.0 and previous to the current.

Bug description
In the case of cross-compilation with sysroot, cmake export generated files have bad paths to be imported into another project. This doesn't allow to link to it when you import it as dependence in another project.
Expected behavior
Cmake exports have to allow to cross-compilation with sysroot.
(cf. for more description and an example https://github.com/humanoid-path-planner/hpp-fcl/issues/542#issuecomment-1979026071 ). Paths have to be relatives.
Code
Please first fix the following
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index f2c30958..cdbeb5d4 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -97,12 +97,12 @@ ADD_HEADER_GROUP(${PROJECT_NAME}_CORE_GENERATED_PUBLIC_HEADERS)

 INSTALL(TARGETS ${PROJECT_NAME}
   EXPORT ${TARGETS_EXPORT_NAME}
-  LIBRARY DESTINATION ${CMAKE_INSTALL_FULL_LIBDIR}
-  ARCHIVE DESTINATION ${CMAKE_INSTALL_FULL_LIBDIR}
-  RUNTIME DESTINATION ${CMAKE_INSTALL_FULL_BINDIR})
+  LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
+  ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
+  RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})

 INSTALL(TARGETS ${PROJECT_NAME}_headers
   EXPORT ${TARGETS_EXPORT_NAME}
-  LIBRARY DESTINATION ${CMAKE_INSTALL_FULL_LIBDIR}
-  ARCHIVE DESTINATION ${CMAKE_INSTALL_FULL_LIBDIR}
-  RUNTIME DESTINATION ${CMAKE_INSTALL_FULL_BINDIR})
+  LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
+  ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR
+  RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})

But it is not enough, in your sources you have another place where lib paths are forced as absolute. My current workaround is to modify manually the generate export files after build of pinocchio to allow to use it as dependence in another project, this files are:

[…]/pkgconfig/pinocchio.pc
[…]/cmake/pinocchio/pinocchioConfig.cmake
[…]/cmake/pinocchio/pinocchioTargets.cmake

Please fix also the cmake file which generates them.
Thank you in advance

Thanks @aurelien-enchanted-tools for raising this issue.
@MegMll Could you handle this task on the devel branch?

Solved via #2202.


Handle passing serverengine config in from runner

The #run method now accepts serverengine configuration options and
merges them against the server engine prior to the serverengine instance
having #run called on it.
Also support block acceptance on #server_engine(&block) which gives you
access to the runner that has #server_engine if you need to access that.
An internal, but an important one maybe worth sharing without too much
magic on the consumer side.

Increased overall coverage & handled a couple TODOs which were solved
by these changes.

  General coverage
     before: 91.78%
   new code: 91.34%
  new tests: 91.90%
      delta:  0.12%

  Coverage on lib/sneakers/runner.rb
     before: 73.81%
   new code: 72.00%
  new tests: 78.00%
      delta:  4.19%

I think this is an excellent and gives more control over the concurrency. Is this the direction you want to go or do you want some of this to be handled by sneakers.conf.rb?

@gabrieljoelc I just wanted to ping you to let you know I'm braining on your
last question. I think that it merits a thought out response, since it
seems to cross public/internal/private API boundaries in ways that we might
need to really own later and not drop if we expose them publicly.
Sorry for the delay, and thank you for the review! If any part of this might be
easier to initially discuss in some other way (hangouts, screenhero, IRC,
whatever) and then recapture here later, I'd love to chat or pair.
I have a few more bunny-related pull requests incoming for some fixes, features
(TLS mutual auth and friends support? You betcha.), and then some
architectural stuff that might even be more worthy of discourse. I'll get back
with my digested answer to your question.
~Spaceghost

@arfrank I think the most correct thing to add after squashing the last two would be ~> 2.2 unless there's some features that are depended on in versions greater than 2.2.
That would be applicable for everyone, and if your temporary version doesn't match into the 2.x.y.alpha pattern then you'd maybe want to use your own version of them gem installed whichever way works best into you workflow.

@Spaceghost can you please rebase this against master?

@michaelklishin I'll have to close this one and open one from my own github account. I'll update this with the new pull request.


Rework build system

build in local directory instead of user homedir
use count of git revisions as version -> constantly increasing
build via src.rpm so that production use can build rpm from src.rpm in mock environment
add support for direct uploading to yum repo server (https://github.com/immobilienscout24/yum-repo-server)

@paulegan, I was recently looking at this and I have to say I am agree with @schlomo, or at least we should have options to build this base on any release/version or latest code and a good README instructions.

Outdated


Close bottom dock when pressing ESC

A minor UX enhancement, could pressing Esc close the bottom dock if nothing else listens to that key?
I was inspired by the way you can press Esc to close docks in QtCreator, and found myself mechanically press Esc to close those in Godot too, but was annoyed to have to take my mouse and close them manually.

Fixed by #15862.


[IOTDB-2304]Library-UDF Data Repairing Functions

Description
Functions, tests and documents for data repairing.
Function List
TimestampRepair
ValueFill
ValueRepair

This PR has:

[x] been self-reviewed.

[ ] concurrent read
[ ] concurrent write
[ ] concurrent read and write

[x] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods.
[ ] added or updated version, license, or notice information
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
[x] added integration tests.
[ ] been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

    <artifactId>library-udf</artifactId>
    <version>2.0.0</version>

The version is better to be the same as its parent's pom.

Coverage decreased (-0.3%) to 67.741% when pulling 4897d3abce2f06601cce518c01f900165e29a56b on trin1t:library-drepair into 2f49925eb06055e85bc2495838783b01d6dc192b on apache:master.


Better error message in event of token revokation

At present if a token is revoked, the user will see the following message on attempting to access the channel:
Fetching package metadata: .Error: HTTPError: 401 Client Error: UNAUTHORIZED: https://conda.binstar.org/t/pqVskkFiygzj/anaconda-server/osx-64/

Probably it would be good to make it clear in this message that the user's access has been revoked, and that this is not any kind of server error.

Which user?  The client or the token-revoker?   I get something similar with:
   $ conda install -c https://conda.binstar.org/jjhelmus pyproj
Fetching package metadata: ....Error: HTTPError: 401 Client Error: UNAUTHORIZED: https://conda.binstar.org/jjhelmus/noarch/


[FLOC-3024] Slower agent loop

Slows the dataset agent loop to 3 second iterations (up from 1).
We may or may not want to keep this change pending the performance change results from FLOC-3036.
In testing against AWS, this change did not break any acceptance tests and resulted in a small decrease in CPU usage of the control service, as well as a more considerable decrease in the CPU usage of the dataset agents.

I merged forward to resolve conflicts and force a new build.

Some of the changes introduced in master have added agent loop tests that affect this branch, so I've updated those tests to reflect this branch's 3 second delay.

Can someone verify this PR?

We did slow down the container agent loop and fixed a bug in the dataset agent that was causing it to wake up too quickly.


BlazorStyled can be registered twice

If BlazorStyled is registered with isDevelopement = true, and also BlazorPrettyCode is registered with isDevelopment = false, BlazorStyled gets added with isDevelopment = false.

Fixed in 1.0.0-preview6-05

I still see this in BlazorTypography


Improvements in the Packages + GitHub Actions

Description
This PR includes several quality of life improvements

fixed setup.py and incorporate a dev installation with black, flak8 and isort
Makefile with code quality routing
Github Actions to test the code on PR on main

List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?
pip install -e ".[dev]"
python -m unittest

Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs

[x] Docs updated? What were the changes: On the README

Thanks a lot @Jacobsolawetz for the review!


Test Coverage for Csv

Add test cases to ensure bug free code.

Ensure no duplicates when writing to Csv
Remove record when pattern is not followed

Resolved with #88


Prettier Pre-Commit always return failed

What happened?

I think https://github.com/pre-commit/mirrors-prettier is not stable we should rollback to latest version

What's the error?

there is no error message to trace, I try v4.0.0-alpha.4 still working fine

The pre-commit version of prettier is now v4.0.0-alpha.8.
I just ran it without any problems.
Maybe that new version solved it already @riso-tech?


[WIP] Linux sign

Why
Follow Splunk security guidelines.
Write Python code for signing as it is known for other devs than C#
SFx Agent, Splunk OTel Collector, Splunk Enterprise also use Python scripts for signing.
The signing code could be later extracted and put into some dedicated repository. We could then create and push a container image so that it could be reused by other teams.
What

GitLab release workflow to sign the RPM package and checksum.txt

Tests
Manual tests and GitLab Pipelines

@pjanotti Thanks for the review. Now, I have spotted that I have forgotten to remove all the Python scripts 🤦 As of right now everything comes thanks to
include:
  # repo: https://cd.splunkdev.com/core-ee/signing/api-integration/-/tree/develop/
  - project: core-ee/signing/api-integration
    ref: develop
    file: /templates/.sign-client.yml

which is reusued in the sign-deb , sign-rpm, checksums jobs


Typo in Dataset viewer error message

Dataset viewer issue for 'name of the dataset'
Link: link to the dataset viewer page
short description of the issue
When creating an empty dataset repo, the Dataset Preview provides a helpful message that no files were found. There is a tiny typo in that message: "ressource" should be "resource"

Am I the one who added this dataset ?
N/A

Fixed, thanks


Profile chart does not show on Production

cc @ChaelKruip. I also experienced the same malfunction yesterday. A refresh helped back then, not today :grin:

Do you have an example of this?

Closing. Cannot reproduce. Let's keep an eye out for it anyways.

Awesome. Thanks! Already see what it is though.

:+1:


Can't open multiple DSMapStudio applications at the same time.

Merging Regulation files in Elden Ring would be a lot easier if I could open two DSMapStudio projects at once.
Every time I try and open a second DSMapStudio window, the new one just instantly closes on me.

Is there any reason you can't use the Compare menu to compare params?

This has been fixed.


Add TensorRT-LLM Whisper Tiny.en/Base.en/Small.en/Medium.en/Large-v1/Large-v2 Models

Hello,
As the TensorRT-LLM Whisper-large-v3 Whisper-large-v3-turbo are ready, I wanted to add the remaining Whisper models.
To convert the checkpoint, I followed and used the scripts provided here: https://github.com/NVIDIA/TensorRT-LLM/tree/main/examples/whisper
And to run evals, I reused the scripts in https://github.com/huggingface/open_asr_leaderboard/tree/main/tensorrtllm
The results I had are significantly worse than what It should be, the results below are with weights in float16:
Filtering models by id: tiny.en

Results per dataset:

whisper_tiny.e/whisper_tiny.en | hf-audio-esb-datasets-test-only-sorted_ami_test: WER = 99.98 %, RTFx = 658.40
whisper_tiny.e/whisper_tiny.en | hf-audio-esb-datasets-test-only-sorted_earnings22_test: WER = 99.69 %, RTFx = 1719.86
whisper_tiny.e/whisper_tiny.en | hf-audio-esb-datasets-test-only-sorted_gigaspeech_test: WER = 100.08 %, RTFx = 1538.20
whisper_tiny.e/whisper_tiny.en | hf-audio-esb-datasets-test-only-sorted_librispeech_test.clea: WER = 99.49 %, RTFx = 1760.50
whisper_tiny.e/whisper_tiny.en | hf-audio-esb-datasets-test-only-sorted_librispeech_test.other: WER = 99.77 %, RTFx = 1570.98
whisper_tiny.e/whisper_tiny.en | hf-audio-esb-datasets-test-only-sorted_spgispeech_test: WER = 99.93 %, RTFx = 2171.81
whisper_tiny.e/whisper_tiny.en | hf-audio-esb-datasets-test-only-sorted_tedlium_test: WER = 99.71 %, RTFx = 1926.79
whisper_tiny.e/whisper_tiny.en | hf-audio-esb-datasets-test-only-sorted_voxpopuli_test: WER = 99.78 %, RTFx = 2215.32
whisper_small.e/whisper_small.en | hf-audio-esb-datasets-test-only-sorted_ami_test: WER = 21.67 %, RTFx = 308.40
whisper_small.e/whisper_small.en | hf-audio-esb-datasets-test-only-sorted_earnings22_test: WER = 19.81 %, RTFx = 689.10
whisper_small.e/whisper_small.en | hf-audio-esb-datasets-test-only-sorted_gigaspeech_test: WER = 14.89 %, RTFx = 654.89
whisper_small.e/whisper_small.en | hf-audio-esb-datasets-test-only-sorted_librispeech_test.clea: WER = 4.60 %, RTFx = 739.03
whisper_small.e/whisper_small.en | hf-audio-esb-datasets-test-only-sorted_librispeech_test.other: WER = 8.06 %, RTFx = 669.27
whisper_small.e/whisper_small.en | hf-audio-esb-datasets-test-only-sorted_spgispeech_test: WER = 11.02 %, RTFx = 866.02
whisper_small.e/whisper_small.en | hf-audio-esb-datasets-test-only-sorted_tedlium_test: WER = 9.75 %, RTFx = 795.86
whisper_small.e/whisper_small.en | hf-audio-esb-datasets-test-only-sorted_voxpopuli_test: WER = 9.61 %, RTFx = 930.41
whisper_large/v2 | hf-audio-esb-datasets-test-only-sorted_ami_test: WER = 21.54 %, RTFx = 93.02
whisper_large/v2 | hf-audio-esb-datasets-test-only-sorted_earnings22_test: WER = 20.38 %, RTFx = 199.15
whisper_large/v2 | hf-audio-esb-datasets-test-only-sorted_gigaspeech_test: WER = 12.62 %, RTFx = 176.35
whisper_large/v2 | hf-audio-esb-datasets-test-only-sorted_librispeech_test.clea: WER = 4.88 %, RTFx = 200.96
whisper_large/v2 | hf-audio-esb-datasets-test-only-sorted_librispeech_test.other: WER = 7.38 %, RTFx = 184.10
whisper_large/v2 | hf-audio-esb-datasets-test-only-sorted_spgispeech_test: WER = 9.83 %, RTFx = 230.22
whisper_large/v2 | hf-audio-esb-datasets-test-only-sorted_tedlium_test: WER = 14.30 %, RTFx = 201.43
whisper_large/v2 | hf-audio-esb-datasets-test-only-sorted_voxpopuli_test: WER = 9.20 %, RTFx = 249.95

Composite Results:

whisper_tiny.e/whisper_tiny.en: WER = 99.80 %
whisper_tiny.e/whisper_tiny.en: RTFx = 1760.43
whisper_small.e/whisper_small.en: WER = 12.43 %
whisper_small.e/whisper_small.en: RTFx = 732.23
whisper_large/v2: WER = 12.52 %
whisper_large/v2: RTFx = 198.94

I tried with bfloat16 but did not increased the performance.
Are there specific considerations when converting/evaluating smaller models (e.g., tiny, base, small) for TensorRT-LLM?

cc @Vaibhavs10

Fix #46.


how to handle multipart form using facil.io

Thank you for making this nice web application framework package available.
I am working on a simple web application which posts a multipart form, with three string fields, a file upload, and a submit button. I am able to get the body and print it (or print the request header), but I am not able to get the individual name-value pairs, after the parsing.
Does facil.io have support for this, or do I need to use a separate third-party parser? Is there an example of how to use facil.io with a multipart form including input fields and file upload?  Thank you.

Found a solution using https://github.com/iafonov/multipart-parser-c

Hi @rajesh-krishnan ,
Thank you for opening this issue.
Depending on which version of facil.io you might be using, you might be interested to read the HTTP data parsing documentation at facil.io.
Besides functions such as http_parse_query and http_parse_body you might consider using an external multipart form parser if it better fit your app.
For example, this HTTP response callback will print out the parsed data in JSON format to the terminal:
static void on_http_request(http_s *h) {
  http_parse_query(h);
  http_parse_body(h);
  FIOBJ json = fiobj_obj2json(h->params, 1);
  fprintf(stderr, "%s\n", fiobj_obj2cstr(json).data);
  /* set a response and send it (finnish vs. destroy). */
  http_send_body(h, "Hello World!", 12);
}

Pease note that uploaded files will create a "sub-group" / FIOBJ Hash with the following keys:

data - a FIOBJ String with the content of the file.
type - a FIOBJ String with the mime type of the file as provided by the client.
filename - a FIOBJ String with the original filename as provided by the client.

Good Luck!
Bo.

Thank you. That worked splendidly; I have no need for an external parser.

Cool 😎
I'm happy to have helped :)


[ADAM-536] Add support for scala 2.11

Resolves #536. Doesn't quite work yet; still working to resolve this issue with the scala 2.11 build:
[ERROR] /Users/fnothaft/IdeaProjects/adam/adam-core/src/main/scala/org/bdgenomics/adam/rdd/ShuffleRegionJoin.scala:94: diverging implicit expansion for type ((org.bdgenomics.adam.models.ReferenceRegion, Int)) => Comparable[(org.bdgenomics.adam.models.ReferenceRegion, Int)]
starting with method orderingToOrdered in object Ordered
[ERROR]       keyedLeft.repartitionAndSortWithinPartitions(ManualRegionPartitioner(bins.value.numBins))
[ERROR]       ^
[ERROR] /Users/fnothaft/IdeaProjects/adam/adam-core/src/main/scala/org/bdgenomics/adam/rdd/ShuffleRegionJoin.scala:94: value repartitionAndSortWithinPartitions is not a member of org.apache.spark.rdd.RDD[((org.bdgenomics.adam.models.ReferenceRegion, Int), T)]
[ERROR]       keyedLeft.repartitionAndSortWithinPartitions(ManualRegionPartitioner(bins.value.numBins))
[ERROR]                 ^
[ERROR] /Users/fnothaft/IdeaProjects/adam/adam-core/src/main/scala/org/bdgenomics/adam/rdd/ShuffleRegionJoin.scala:96: diverging implicit expansion for type ((org.bdgenomics.adam.models.ReferenceRegion, Int)) => Comparable[(org.bdgenomics.adam.models.ReferenceRegion, Int)]
starting with method orderingToOrdered in object Ordered
[ERROR]       keyedRight.repartitionAndSortWithinPartitions(ManualRegionPartitioner(bins.value.numBins))
[ERROR]       ^
[ERROR] /Users/fnothaft/IdeaProjects/adam/adam-core/src/main/scala/org/bdgenomics/adam/rdd/ShuffleRegionJoin.scala:96: value repartitionAndSortWithinPartitions is not a member of org.apache.spark.rdd.RDD[((org.bdgenomics.adam.models.ReferenceRegion, Int), U)]
[ERROR]       keyedRight.repartitionAndSortWithinPartitions(ManualRegionPartitioner(bins.value.numBins))

@laserson I was trying to figure out where the ordering for (ReferenceRegion, Int) was defined/is coming in from, but I wasn't able to grok that from the ShuffleRegionJoin code. Do you know where that is coming from/would you be able to take a look?

Also, it looks like this problem is related to a regression in Scala 2.11, but I believe we should be able to WAR the regression.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/534/Build result: FAILUREGitHub pull request #547 of commit 8964be2118bd55dbd0f58b61067052551a343bed automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/547/merge^{commit} # timeout=10Checking out Revision 4e793485b2775933eda4de8450a4b98ffa5f5295 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 4e793485b2775933eda4de8450a4b98ffa5f5295 > git rev-list b409bd0004a00c2dac712b5c567963b3e013c8e3 # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILURE
Test FAILed.

Just submitted a PR against your branch that fixes the Ordering problem.  Mo' problems to solve, though...

(Also, I'm not sure where the Ordering was coming from to begin with, at it appears Tuples don't have default Orderings.)

Thanks @laserson! I was confused as well...

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/536/Build result: ABORTEDGitHub pull request #547 of commit 0fc67a6f3dd49fff6585475d80a30f9b1953eef9 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/547/merge^{commit} # timeout=10Checking out Revision 39b52365cb08a003be136f42f4c40b40d5084331 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 39b52365cb08a003be136f42f4c40b40d5084331 > git rev-list b409bd0004a00c2dac712b5c567963b3e013c8e3 # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result ABORTEDADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILURE
Test FAILed.

Jenkins, retest this please.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/541/Build result: FAILUREGitHub pull request #547 of commit 0fc67a6f3dd49fff6585475d80a30f9b1953eef9 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/547/merge^{commit} # timeout=10Checking out Revision 39b52365cb08a003be136f42f4c40b40d5084331 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 39b52365cb08a003be136f42f4c40b40d5084331 > git rev-list d8e02d9f8f96c10595d575b7d0c5729f61cd8edc # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILURE
Test FAILed.

Jenkins, test this please.

This approach looks good to me. I'd like to hear from @heuermh too since he's strong with the maven fu.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/542/Build result: FAILUREGitHub pull request #547 of commit 0fc67a6f3dd49fff6585475d80a30f9b1953eef9 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/547/merge^{commit} # timeout=10Checking out Revision 39b52365cb08a003be136f42f4c40b40d5084331 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 39b52365cb08a003be136f42f4c40b40d5084331 > git rev-list d8e02d9f8f96c10595d575b7d0c5729f61cd8edc # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILURE
Test FAILed.

It looks like there are a few places where 2.10 is still hard-coded, e.g.
$ find . -name "pom.xml" | xargs grep "2.10"
./adam-cli/pom.xml:      <artifactId>scalate-core_2.10</artifactId>
./adam-cli/pom.xml:      <artifactId>scalatra-json_2.10</artifactId>
./adam-cli/pom.xml:      <artifactId>scalatra_2.10</artifactId>
./pom.xml:    <scala.version>2.10.4</scala.version>
./pom.xml:    <scala.artifact.suffix>2.10</scala.artifact.suffix>
./pom.xml:        <artifactId>scalate-core_2.10</artifactId>
./pom.xml:        <artifactId>scalatra-json_2.10</artifactId>
./pom.xml:        <artifactId>scalatra_2.10</artifactId>

we should probably update this to use $scala.artifact.suffix

This doesn't build on my Mac, e.g.
$ mvn -P scala-2.11 clean package

Throws the following error:
[ERROR] /Users/matt/workspace/berkeley/adam/adam-core/src/main/scala/org/bdgenomics/adam/models/VariantContext.scala:84: in class VariantContext, multiple overloaded alternatives of constructor VariantContext define default arguments.
[ERROR] class VariantContext(
[ERROR]       ^
[WARNING] 5 warnings found
[ERROR] one error found

Things build fine when I remove the scala-2.11 profile.
Are others seeing the same issue?

Let me take a look; this built on my end when I opened the PR, not sure if there's been a change since then that'd break it...

Er, duh! The 2.10 would build; 2.11 wouldn't build because the error in the original PR post wasn't fixed yet. I'll take a look at this locally now.

This should work for Scala 2.11 now. Can someone test on their own machine?

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/546/Build result: FAILUREGitHub pull request #547 of commit 5cc2b324c9d8860a8698296191236846996e1915 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/547/merge^{commit} # timeout=10Checking out Revision 0fe3c16f9095857626da1b5730225470c1fcd11e (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 0fe3c16f9095857626da1b5730225470c1fcd11e > git rev-list d8e02d9f8f96c10595d575b7d0c5729f61cd8edc # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILURE
Test FAILed.

Also fails for me, see https://gist.github.com/heuermh/14f7b33def990f4eb7a2

Ah! Looking at this again...

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/550/Build result: FAILUREGitHub pull request #547 of commit feedc7c1e01f7246f9d7cae595475eb2f81af1e5 automatically merged.[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/547/merge^{commit} # timeout=10Checking out Revision 2e338548cd91f7f3141dfc433dc6e5d42eba21bd (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 2e338548cd91f7f3141dfc433dc6e5d42eba21bd > git rev-list d8e02d9f8f96c10595d575b7d0c5729f61cd8edc # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 1.0.4,centosTriggering ADAM-prb ? 2.3.0,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILURE
Test FAILed.

Closing this. Will open a new PR tomorrow that builds on https://github.com/bigdatagenomics/utils/pull/36.


Add tests for random numbers

Add tests for rand/randn

So randn fails on 1.8 with a type-inference issue @wsmoses  and on 1.6 it fails since we want do differentiate through seeding

https://gist.github.com/vchuravy/ba8a055321fc1f4a8fcfd265650bd465 for the randn issue

replaced by #333


Document external uptime probes

Describe the bug
This page does not tell how to monitor the Compliant Kubernetes environment. It should talk about the what uptime probes are needed.
Acceptance criteria

The page has a section called "Operate" which makes it clear how to set up external uptime probes.

@anders-elastisys and @Elias-elastisys Is this something you can look into? Or do I need to ask the scrummasters to prioritize this?

@cristiklein yes we can look into this


Neovim crash when writing set map

Neovim 0.7.2 will crash when writing the following:
set_map == {x + y + z : x, y,

It does not crash if the closing curly brace is typed before typing the generator. Possibly something in the external scanner?

It will also crash when writing:
func_literal ≜ ∧ [x

but not:
func_literal == [x

lending credence to this being an external scanner issue.

As of neovim 0.8.2 this no longer seems to occur.

Reopening, occurs with following input:
---- MODULE Test ----
op == [ ]
THEOREM TRUE
<*> 1
<*> QED
====

Another one causing a crash:
---- MODULE Test ----
THEOREM A
  <1> QED BY B
  <1> QED
=====================

Seems best practice to harden the external scanner by checking whether we are in a jlist/proof/pcal block by looking at the relevant stacks, rather than relying on the parser to give us accurate expected symbol information.


[Request]: Adding the sensitivity percentage

Plugin
sensors_plus
Use case
hi,
I am using accelerometerEventStream. This sensor is constantly vibrating much more with the smallest vibration. Please add the sensitivity percentage to this package so that the received numbers change more smoothly.
Proposal
aaaa

This sensor is constantly vibrating much more with the smallest vibration. Please add the sensitivity percentage to this package so that the received numbers change more smoothly.

You have an option to set sensor sample rate since 4.0.1 version, so pick the latest version and set the sampling rate you need. No other configurable options available. Moreover, you can filter your stream in your app as you wish.

aaaa

That is not the best way to fill in requests.


Is there a way to use a single JLED to control a bicolor led?

How can I make a single RED/GREEN bicolor led to work with JLED but using the Yellow color? Both Red and Green lit, to show yellow effects?
Also, can I create an "Yellow" Object that sets the max brightness different for each color (RED and GREEN) , so I can tune the best "yellow" appearance?
Is there a way for this to be done?
Thanks!

Currently only single-color LEDs are supported.But you could create a JLedSequence with 2 JLed objects, one for red and for the green LED and control the LEDs in parallel together.


Still using Node14

Despite #47, images are still using node14, which among other things, is causing https://github.com/nektos/act/issues/1681.
$ docker run --entrypoint /usr/local/bin/node ghcr.io/catthehacker/ubuntu:full-latest --version
> Unable to find image 'ghcr.io/catthehacker/ubuntu:full-latest' locally
> full-latest: Pulling from catthehacker/ubuntu
> Digest: sha256:598b616a8c7ce86d98ee63871cec532f4ff645125b563a8798f2ae1c98928ec7
> Status: Downloaded newer image for ghcr.io/catthehacker/ubuntu:full-latest
> v14.17.6

I also tried docker run --rm --entrypoint node catthehacker/ubuntu:full-latest -v with the same outcome.
Off topic: any idea why docker run --rm catthehacker/ubuntu:full-latest node -v doesn't work? I had the impression that the next argument after the docker image is taken as the entrypoint, and everything else as cmd arguments?

Do you agree pushing tar layers of GitHub Hosted Runners to full-latest?

Sure, thank you for all your work 🎉


Rows removed when cannot set lines

I'm not sure why, but we're seeing this error:
Uncaught TypeError: Cannot set property '0' of undefined
    at Terminal.write (term.js:188)
    at Socket.<anonymous> (terminal-application.js:18)
    at Socket.Emitter.emit (socket.io.js:35)
    at Socket.onevent (socket.io.js:16)
    at Socket.onpacket (socket.io.js:15)
    at Manager.<anonymous> (socket.io.js:29)
    at Manager.Emitter.emit (socket.io.js:35)
    at Manager.ondecoded (socket.io.js:8)
    at Decoder.<anonymous> (socket.io.js:29)
    at Decoder.Emitter.emit (socket.io.js:35)
term.js:133 Uncaught TypeError: Cannot read property '0' of undefined
    at Terminal.refresh (term.js:133)
    at term.js:126
term.js:129 Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at Terminal.refresh (https://katacoda.com/javascripts/term.js:129:185)
    at https://katacoda.com/javascripts/term.js:126:33
term.js:129 Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at Terminal.refresh (https://katacoda.com/javascripts/term.js:129:185)
    at https://katacoda.com/javascripts/term.js:126:33
term.js:129 Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at Terminal.refresh (https://katacoda.com/javascripts/term.js:129:185)
    at https://katacoda.com/javascripts/term.js:126:33
term.js:129 Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at Terminal.refresh (https://katacoda.com/javascripts/term.js:129:185)
    at https://katacoda.com/javascripts/term.js:126:33

When it happens, the xterm rows are removed.

I believe this is a duplicate of https://github.com/sourcelair/xterm.js/issues/385


Remove expire argument for url method and do not generate signed url for public/public-read bucket

Trying to solve #2 #9. url method is not compatible with django's default Storage class since it should has only one required positional argument.

Environment variable OSS_EXPIRE_TIME in seconds can be set for url expire time.

If OSS_EXPIRE_TIME is not set, default value is 60*60*24*30 which is 30 days will be used.

For public/public-read bucket, there is no need to use signed urls since it will generate unique url (Signature parameter in url will change each time) each time. This makes CDN or brower cache unavailable. Since OSS ususally serves as static/media file serving purpose, it is better to use constant urls for public/public-read buckets.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

没人在维护吗？这么严重的Bug 5个月了还没合入的说 =。=

已经根据 修改内容 合入到 dev-1911 分支

Same with https://github.com/aliyun/django-oss-storage/pull/11, why this PR is merged without my author information :cry:

Because they made the same changes instead of merge your PR... Quite interesting.


2d flow

Support for 2D flow

I opened the VDC file WRF/2D and vapor crashed when I created a flow renderer

@sgpearse  could you take a look at VSliderEdit.cpp ?
It appears the the GUI wants to set a range to the slider where min is greater than max... Is it a data specific issue?

@shaomeng I'm seeing the problem and I think this requires some discussion about our pathline length parameter (aka unsteady flow length).
The maximum length is currently the number of timesteps-1 (numTS-1).  The minimum value was changed to be 1 in the commit noted below.
In the case that there is only one time step, the max (numTS-1) is 0, and the minimum is 1.  When max is less than min, we see the this assertion.
I believe that the renderer should accept a value of 0 for pathline length, and just display a point instead of a line.  We can also special-case this widget for when the data only has one time step.  We should probably have a discussion about the tradeoffs between having a minimum value of 0 vs 1.
3e9e398be2196e22ba0818c51631aa1876cd0036

I opened the VDC file WRF/2D and vapor crashed when I created a flow renderer

I believe this crash is resolved. Can you give it another try?

I opened the VDC file WRF/2D and vapor crashed when I created a flow renderer

I believe this crash is resolved. Can you give it another try?

Will do. Sam, just an FYI that if you click the rotating arrows next to the reviewer’s name GitHub will notify them that the PR is ready to be reviewed again.

On Jan 3, 2020, at 3:01 PM, Samuel Li<EMAIL_ADDRESS>wrote:
@clyne @StasJ This PR is ready to be reviewed again!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

John Clyne
National Center for Atmospheric Research
303.497.1236 (w),<PHONE_NUMBER> (c)
<EMAIL_ADDRESS>

I cannot get anything to render with WRF/2D. I tried messing with every setting, increasing the number of seeds, different seeding methods and I made sure all of the referenced variables were valid.

@StasJ if you increase the velocity multiplier from 1 to 100K, then you'll see something. This particular data set uses different units.

I cannot get anything to render with WRF/2D. I tried messing with every setting, increasing the number of seeds, different seeding methods and I made sure all of the referenced variables were valid.

@StasJ if you increase the velocity multiplier from 1 to 100K, then you'll see something. This particular data set uses different units.

Do we expect the user to have to scale by 100,000 to see anything at all? I mean thats 100 times what the limit was before you just increased it. Also, I tried re-testing but I cannot because vapor freezes when creating a flow renderer again.

I cannot get anything to render with WRF/2D. I tried messing with every setting, increasing the number of seeds, different seeding methods and I made sure all of the referenced variables were valid.

@StasJ if you increase the velocity multiplier from 1 to 100K, then you'll see something. This particular data set uses different units.

Do we expect the user to have to scale by 100,000 to see anything at all? I mean thats 100 times what the limit was before you just increased it. Also, I tried re-testing but I cannot because vapor freezes when creating a flow renderer again.

Regarding your first question, I don't have a good answer too. The full domain is in the order of 1e+6 and the particles were moving at a scale of 1e-2 before the adjustment. Or in an extreme case, the velocity field that the user chooses happen to have all zeros, and the particles don't move anywhere. I don't have a good solution for either of these situations.
Regarding your 2nd question, I personally cannot reproduce it on cisl-vapor. Maybe 1) you provide a more detailed steps, and 2) @sgpearse can try it on a macbook?

I cannot get anything to render with WRF/2D. I tried messing with every setting, increasing the number of seeds, different seeding methods and I made sure all of the referenced variables were valid.

@StasJ if you increase the velocity multiplier from 1 to 100K, then you'll see something. This particular data set uses different units.

Do we expect the user to have to scale by 100,000 to see anything at all? I mean thats 100 times what the limit was before you just increased it. Also, I tried re-testing but I cannot because vapor freezes when creating a flow renderer again.

Regarding your first question, I don't have a good answer too. The full domain is in the order of 1e+6 and the particles were moving at a scale of 1e-2 before the adjustment. Or in an extreme case, the velocity field that the user chooses happen to have all zeros, and the particles don't move anywhere. I don't have a good solution for either of these situations.
Regarding your 2nd question, I personally cannot reproduce it on cisl-vapor. Maybe 1) you provide a more detailed steps, and 2) @sgpearse can try it on a macbook?

Regarding mismatched units: I don't believe that there is any way that we can automatically perform a unit conversion (i.e. pick an appropriate scaling factor). We could calculate something that would result in pathlines progressing, but unless the scaling factor chosen is correct the resulting pathlines will be wrong. Bottom line: users have to know their data, and if they're mixing units they will have to address this themselves by either selecting an appropriate scaling factor or deriving new variables. That said, we should not place limits on the scaling factor.
One thing that we might consider to reduce confusion is to render glyphs (e.g. spheres, diamonds) at the seed locations. Let's discuss f2f.

Alright, the multiplier upper limit is removed in commit
0e1fd05 . Happy testing everyone!

Alright, the multiplier upper limit is removed in commit
0e1fd05 . Happy testing everyone!

Terrific. Thanks. Just need @StasJ to approve


feat(Browser): add url param to newPage, default value is 'about:blank'

I signed it!

Thanks for the PR. Unfortunately this is a more complicated change that it might appear to be at first. Determining when a page has finished navigating to a URL is a difficult question. We have a bunch of options in all of our navigation methods to deal with this.
Currently in your patch, the initial navigation is not awaited. This means that the page could be in a volatile state when it is returned from newPage. If we add the navigation options, a new problem arises. The page exists, but the user wont be notified of its existence until after the first navigation.
Leaving things as is, with about:blank as the default page, keeps our API and implementation simple.

Yes, adding custom url to the "newPage" will require adding all the navigation options, e.g. waitUntil. I'd rather hold off from that; the page.newPage(), followed by page.goto() seems good enough.


Git Unbearably Slow

Myself and a few co-workers have fully switched over to Code and so far so good, except for git speed. The git integration works, but it's ridiculously slow. I'm talking 5+ minutes to sync. Just connecting to a very small private GitHub repo. I'm not sure how to fix this or how to narrow down what the possible issues could be on our end. Is there any way to get a verbose logout of what's happening, perhaps?
Running the latest release of VS Code, and Windows 7.

What version of git do you have?  Is it in a network share or locally? Is it slow just for you or for your co-workers as well? What exactly is slow, showing the list of modified files, staging files, committing, pushing, pulling?

Ahh, ok. Fair enough.
Latest version of Git for Windows is installed. The repo is very small, just a small angular app and it's stored on GitHub. It's slow for all of us. Basically any of the actions are slow. Syncing in particular.

What version exactly of git do you have? Is it also slow in the command line: when you open the Command Prompt and run some git commands there, for example? Can I have access to the repository?

You can close this. I appreciate the help, though, considering it didn't appear to be anything really Code related :).
My git install actually was older, and i don't believe i had the cache option before. In addition to that my global .gitconfig was stored on a very slow network drive (admin set $HOME that can't be changed), which has since been moved. Everything is moving along nicely now!

Very happy to read that! Keep the feedback coming!


[1.1.x] build: use cctols ranlib on Darwin

This complements the change in #105 and allows to build with a CMake
newer than 3.19.6.
Addresses rdar://99435188
(cherry picked from commit 7ba978bbd451e2f831f84a805c73393b331e0aa8)

Checklist

[ ] I've run tests to see all new and existing tests pass
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

If you've made changes to gyb files

[x] I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:
Attempting to use CMake 3.22 to build this project as part of the swift toolchain in CI
Modifications:
Adjust the path to ranlib on Darwin
Result:
We should be able to build swift-crypto on Darwin using a CMake newer than 3.19.6

@swift-server-bot test this please


"active" field does not appear in PromotionTier

Hello,
We have a feature where we want to check whether a tier is active or not. However, the boolean "active" field is not defined in PromotionTier.
Im taking about PromotionTier interface defined here: https://github.com/voucherifyio/voucherify-js-sdk/blob/main/packages/sdk/src/types/PromotionTiers.ts
Can you guys please expose this field if possible?

Dear @redjolr new version of SDK 2.1.8 has just been released and should be available in NPM registry shortly.
This release contains fix fot your issue.
Related changes: https://github.com/voucherifyio/voucherify-js-sdk/pull/195
Related PR that triggered release: https://github.com/voucherifyio/voucherify-js-sdk/pull/196
I am going to close this issue, please freel free to re-open if you feel like it


Fix per https://github.com/haproxytech/dataplaneapi/issues/147

I've made this change locally, rebuild the dataplaneapi binary using the changed spec file and indeed the issue here:
https://github.com/haproxytech/dataplaneapi/issues/147
is solved. 307 redirects are created without error.

hi @june07
thx for this.
I have just renamed the commit so it follows our contribution guide


BUGFIX: SD-3022 fixing typos dataset

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/199/ : SUCCESS in 14s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-oss-check/206/ : SUCCESS in 3s

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/200/ : SUCCESS in 10s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-oss-check/207/ : SUCCESS in 3s

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/202/ : SUCCESS in 4s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-oss-check/208/ : SUCCESS in 3s

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/203/ : SUCCESS in 7s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-oss-check/210/ : SUCCESS in 3s

LGTM

Sonar scan result

No issue found. Congratulations!

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-public-demos-gate-PR87
To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/gooddata-public-demos/job/gooddata-public-demos-validation/205/ : SUCCESS in 6s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-merge-compliance-check/77/ : SUCCESS in 9s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-sonarqube-scan-zuul-gate/75/ : SUCCESS in 36s
https://checklist.intgdc.com/job/compliance/job/gooddata-public-demos-fossa-scanning-zuul/38/ : FAILURE in 5s (non-voting)


When an absolute path is used for an IdP image, Console renders a broken image

Describe the issue:

When an absolute path is used for an IdP image, Console renders a broken image.
How to reproduce:

Send a PATCH request to update an IdP.
URL: https://localhost:9443/t/carbon.super/api/server/v1/identity-providers/<IDP_ID>
[
    {
        "operation": "REPLACE",
        "path": "/image",
        "value": "https://upload.wikimedia.org/wikipedia/commons/e/e3/KakaoTalk_logo.svg"
    }
]

See the broken image on Console

Expected behavior:

Users should be able to use absolute image URLs.

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Analysis
We seem to be maintaining the IdP images used in Console under <IS_HOME>/repository/deployment/server/webapps/console/resources/connections/assets/images/logos/github.svg.
And in login portals the images are resolved from libs/themes/default/assets/images/identity-providers/github-idp-illustration.svg.
⭐ Login portal already has the capability to pull the IdP image from the API.
So only if an IdP doesn't have a logo, then we can look for any fallback images.
And the same set of images should be distributed to both Console and Login Portals.
ex:
@wso2is/theme
- images
    - connections
         - github.svg

Districute to Console & Authentication endpoints.


kokoro clang-format check erroring out but passing

See https://source.cloud.google.com/results/invocations/9151a1a8-3873-457a-b747-63ad3c860d21/log

++ date
+ echo Fri Jul 6 10:38:08 PDT 2018: Check formatting...
Fri Jul 6 10:38:08 PDT 2018: Check formatting...
+ ./utils/check_code_format.sh
Traceback (most recent call last):
  File "./utils/clang-format-diff.py", line 121, in <module>
    main()
  File "./utils/clang-format-diff.py", line 104, in main
    stderr=None, stdin=subprocess.PIPE)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
All source code in PR properly formatted.
++ date

fixed via #1710


Is there any way to set up an option to make it check the internet first if the cache is say, 15 minutes old (But get it from the cache if unable to fetch the data)? If it's less than 15 minutes it gets it from the cache without checking the internet..

Sorry, I seemed to have had missed the maxStale parameter when I was going through the documentation. The issue is solved now.


Format of input must be MM/DD/YYYY!

Format of input must be MM/DD/YYYY!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0968b5c6-69dd-0573-bd10-810d65b8f57f
Version Independent ID: 9e66f17a-0d64-07a3-0313-e64a0c2074c3
Content: RangeValidator.MaximumValue Property (System.Web.UI.WebControls)
Content Source: xml/System.Web.UI.WebControls/RangeValidator.xml
Product: dotnet-api
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

@Rick-Anderson @scottaddie can you follow up on this feedback? A format of MM/DD/YYYY woulnd't be culture neutral though.

@drwebmonkey can you clarify what the problem is with this doc?
Hardcoding dates into validation is problematic and is discouraged.


Dutch translation is available but not load

The German translation is being loaded due to the NL translation file not being properly included, leading to incorrect language display on the site.

@wdebusschere Your fix is in the newest release


[Event Request] Codeunit 90 "Purch.-Post" – New Event “OnAfterCalcInvDiscount”

Could we please have a new publisher “OnAfterCalcInvDiscount” in Function “CalcInvDiscount”, Codeunit 90 "Purch.-Post”?
    local procedure CalcInvDiscount(var PurchHeader: Record "Purchase Header")
    var
        PurchaseHeaderCopy: Record "Purchase Header";
        PurchLine: Record "Purchase Line";
    begin
        with PurchHeader do begin
            if not (PurchSetup."Calc. Inv. Discount" and (Status <> Status::Open)) then
                exit;

            PurchaseHeaderCopy := PurchHeader;
            PurchLine.Reset();
            PurchLine.SetRange("Document Type", "Document Type");
            PurchLine.SetRange("Document No.", "No.");
            OnCalcInvDiscountSetFilter(PurchLine, PurchHeader);
            PurchLine.FindFirst;
            CODEUNIT.Run(CODEUNIT::"Purch.-Calc.Discount", PurchLine);
            RefreshTempLines(PurchHeader, TempPurchLineGlobal);
            Get("Document Type", "No.");
            RestorePurchaseHeader(PurchHeader, PurchaseHeaderCopy);
            if not (PreviewMode or SuppressCommit) then
                Commit();
        end;
*** start new code ***
        OnAfterCalcInvDiscount(PurchHeader, TempPurchLineGlobal);
*** stop new code ***
        exit;
    end;
…
*** start new code ***
    [IntegrationEvent(true, false)]
    local procedure OnAfterCalcInvDiscount(PurchHeader: Record "Purchase Header"; var TempPurchLine: Record "Purchase Line" temporary)
    begin
    end;
*** stop new code ***

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Add Windows Web Account Manager (WAM) Brokered Authentication Support

This is a tracking work item for creating/finishing the new Azure.Identity.BrokeredAuthentication client library (separate package from the existing Azure Identity client library).
Related:

https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity.BrokeredAuthentication/README.md

Dependencies:

MSAL WAM is supported (Beta) in .NET and Python today
MSAL WAM support (Beta) for Java and Javascript is not yet available but is expected to be available in time for this scheduled development milestone.

Link to dependency - https://github.com/AzureAD/microsoft-authentication-library-for-java/issues/455

@billwert Let's default to a silent auth experience that doesn't show the account picker UX if a user is already logged in. See https://github.com/Azure/azure-sdk-for-net/issues/36178


Improves equal check for account and container

Now checks every field of account and container for equality. Account
also checks its containers.
Test: clean build

Codecov Report

Merging #723 into master will decrease coverage by <.01%.
The diff coverage is 57.89%.

@@             Coverage Diff              @@
##             master     #723      +/-   ##
============================================
- Coverage     65.82%   65.82%   -0.01%
  Complexity     3801     3801
============================================
  Files           328      328
  Lines         25147    25162      +15
  Branches       3156     3159       +3
============================================
+ Hits          16553    16562       +9
- Misses         7712     7714       +2
- Partials        882      886       +4

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/com.github.ambry/account/Account.java
90.29% <45.45%> (-4.39%)
30 <0> (+1)

.../main/java/com.github.ambry/account/Container.java
87.95% <75%> (-1.66%)
25 <1> (+1)

.../com.github.ambry.router/GetBlobInfoOperation.java
79.86% <0%> (-1.39%)
30% <0%> (-1%)

...ava/com.github.ambry.router/NonBlockingRouter.java
81.66% <0%> (-0.84%)
34% <0%> (ø)

.../main/java/com.github.ambry.router/PutManager.java
84.13% <0%> (-0.69%)
22% <0%> (ø)

.../main/java/com.github.ambry.store/HardDeleter.java
81.93% <0%> (-0.65%)
42% <0%> (-1%)

...in/java/com.github.ambry.store/BlobStoreStats.java
85.61% <0%> (-0.24%)
93% <0%> (ø)

...m.github.ambry.clustermap/HelixClusterManager.java
94.3% <0%> (+0.71%)
33% <0%> (+1%)
:arrow_up:

...github.ambry.rest/AsyncRequestResponseHandler.java
90.81% <0%> (+2.29%)
23% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d68f05d...c316c26. Read the comment docs.


move annotations to separate project

this allows consumers to use morphia annotations in projects that
merely contain domain objects without forcing dependency on morphia and
transitively its dependencies.
this resolve #220 which was "gone away" for unclear reasons.

Thanks for the pull request. Unfortunately, it's too late in the cycle to consider this for inclusion in 1.0. However, it begins to make more sense with certain future plans for Morphia and the Java driver. I've opened #782 to track this. By the time this enhancement is done, this pull request is extremely unlikely to merge cleanly so I'm going to mark this as closed and we can readdress it once other features are in place.

are there not going to be any more releases beyond 1.0 ? seems like this could get on that next train.

because waiting for a speculative feature request seems silly when this is already done.


Write a Ruby program to convert weeks to seconds

Description
Write a Ruby program to convert weeks to seconds
1 week = 7 days = 168 hours = 10080 minutes = 604800 seconds
Input  : 5
Output : 3024000

How to contribute

Save the solution in program/ConvertWeeksToSeconds.rb file
Add ConvertWeeksToSeconds.rb file in convert-weeks-to-seconds folder

!assign


add: dynamic token icons - v0.1.0

What functionality needs to be added?

Create a public icon repository
Link the icon image to the image in this repository passing the name or assetId

 Adicionar imagens dos tokens


Issue escaping Single quote

Below is the plural message being used. But, when generating the ARB file, the single quote is not escaping. Similary, I also used double quotes to use the single quotes. That didn't give desired result  either.
Intl.plural(
        numberOfOranges,
        zero: "You\'ve got zero orange.",
        one: "You\'ve got $numberOfOranges orange.",
        other: "You\'ve got $numberOfOranges oranges.",
        name: 'getOrangesText',
        args: [numberOfOranges],
      )

ARB: app_en.arb
{
  "@@last_modified": "2021-12-23T12:15:56.804292",
  "appTitle": "Home",
  "@appTitle": {
    "description": "Application title/name",
    "type": "text",
    "placeholders": {}
  },
  "helloWorld": "Hello World!",
  "@helloWorld": {
    "description": "Hello World message",
    "type": "text",
    "placeholders": {}
  },
  "getOrangesText": "{numberOfOranges,plural, =0{You''ve got zero orange.}=1{You''ve got {numberOfOranges} orange.}other{You''ve got {numberOfOranges} oranges.}}",
  "@getOrangesText": {
    "type": "text",
    "placeholders": {
      "numberOfOranges": {}
    }
  }
}

I am unsure what the problem is - the quotes do look escaped to me, as ICU escapes by adding another single quote per their docs. What behavior would you expect?


Adjust format constants

The format constants used by PyCaprio could be a bit misleading. I'll propose an adjustment in a PR.

Thank you for the contribution!


Slot attribute is not removed from compiled HTML.

Vue.js version
1.0.16
Reproduction Link

http://vuejs.org/examples/modal.html
Steps to reproduce

Open http://vuejs.org/examples/modal.html and view the source of the resulting HTML. This also works in the latest version. I noticed that vue attributes are removed from compiled HTML. slot is not removed.

View result:

What is Expected?
The slot attribute should be removed from compiled HTML.
What is actually happening?
The slot attribute is included in compiled HTML

This is intentional to allow styling slot elements.


Spacebar always focused on video

Whenever I press the Spacebar on a Video page, the spacebar will be focused on the video, causing it to play/pause. This makes me unable to type any comment that is more than one word, and no matter where I try to click, or focus, it always focuses on the video itself.
Or have I missed a setting somewhere?
Firefox 36.0.1 - Dev Version 492

That's weird. Are you using the Flash or HTML5 player? Try switching to the other and see if it makes a difference.

It's set to Standard, but it also happens if I specifically set it to Flash/HTML5/Aggressive Flash

I'm having this issue as well on Firefox with the HTML5 player, as well.
It also only happens when I click the "Reply" link to post a comment. If I try to post a comment from the comment box above the comments display, the space bar works normally.

YTC has a global shortcut option which allows users to use player shortcuts without having to directly click on the player. If this is the case with you then try disabling this feature which can can be found in YouTube Center Setting > Player > Shortcuts > Enable shortcuts on page

I didn't recall having that issue when I had that enabled in Firefox some time ago. :/

https://github.com/YePpHa/YouTubeCenter/wiki/Features#Enable_YouTube_Player_Shortcuts

Disabling YT Player Shortcuts did fix it, but seems like a weird turn-around for a fix.
It really shouldn't trigger the spacebar when selecting the Reply field (can say it doesn't happen in the normal comment box), as it really makes the function... bad

YouTube might have changed something in their comment section which is causing this problem because this kind of issue was already account for by the author.

I suspect it was a recent change in YouTube. This only started happening a couple days ago.

Yes, Youtube certainly did some sort of change to the comment area recently, because a theme I use doesn't work with it anymore, rest of YT is dark but the comment area is now white! So #BlameYT
But I am not seeing this issue however, if I comment or reply, space works as normal!

Well, so we can all say a change in YouTubes comment section is the cause of this, so wonderful. A workaround has been found until it gets fixes, so issue resolved :) Kinda

It would be best to leave this open so that YePpHa can be informed of this issue and correct it.

Well good point

This is really weird, because the global shortcuts don't trigger when an input, textarea, object, embed or button is focused. Recently, YouTube have changed from using the iframe for comments to embedding comments directly in the page. This change might be what have caused this. However, the comment field is a textarea and therefore the global shortcuts should not trigger.
I will upload a new developer version which will have the iframe added to the ignore list, but it will probably not fix it.

ok, this is still an issue as it just started for me (41.0.2272.101 / dev build 495) No biggy for me tho as i dont need the shortcut function enabled.

This issue just started occurring for me today.
I turned off "Extend shortcuts to page" and that fixed it. :) It's a fine enough work-around for me for now.

FYI: Using dev build 497 - issue is still present (with "Enable shortcuts on page" checked)
Whenever the focus refers to an input field, YTC should just ignore the space bar, or loop it through. Same goes for the arrow keys.

To add on to Harl's "FYI" I am also using devel. build 501 and having the issue if shortcuts on page is selected, also another weird thing.. not only does the space bar not work for commenting, it also won't allow me to type numbers haha

Wow, this has been driving me insane for days.  Didn't even realize shortcuts worked on the page at all, never seen it until now.
I'm still on the stable build on both Chrome, Firefox and Palemoon.  Don't know why it started happening all of a sudden after Youtube's latest layout update ~2 weeks ago?  Only happens when typing in the comment REPLY section; typing out a brand new comment works just fine.

still having this problem in the latest dev build. using chrome.

@YePpHa

This is really weird, because the global shortcuts don't trigger when an input, textarea, object, embed or button is focused. Recently, YouTube have changed from using the iframe for comments to embedding comments directly in the page.

This seems to be exactly where the problem is. I am now, too, experiencing this issue, and for me, the comment reply box isn't a textarea. It's a div with id "yt-commentbox-text" and "contenteditable=true". So all that should be neccessary, is to check if document.activeElement.isContentEditable is true. I have created a pull request with that fix.

@Inyokus That will fail when users try to reply to other comments or edit theirs, or when YouTube decides to change the comment system again.
The best way is to do the way I suggested in https://github.com/YePpHa/YouTubeCenter/issues/1688#issuecomment-96109914 which is to check if the activeElement is inside the comment section.

It exactly doesn't fail then, when one is replying to a comment, since only then the comment box is in the YouTube page. The comment box on the the top is still in an iframe and isn't affected by this issue, even without this fix (but it would work, too, if they just copied the code they're currently embedding to the main page, since it's also a contentEditable div).
I don't get why this shouldn't work, when users try to edit their comments. The edit box is a contentEditable div with even the same class (just realized that I wrote id instead of class in my first comment).
That at least is the page as YouTube delivers it to me. It should hurt adding this fix, however, even if only few people have contentEditable divs instead of textareas in the comment area. I did, of course, test it, by the way. It does work.


Delete Account

Currently when the user signs in using cognito pool, I have a lambda function Post email confirmation so a a field on DynamoDB is created.
Apple is soon going to enforce account deletion. How can I do the same but backwards so when I hit delete on the app, it deletes the cognition account? The dynamodb part doesn't seem complicated, but how would I delete the cognito email?
Thanks

Thanks for the question.  We are preparing a feature to support Cognito User Pool account deletion in Amplify to enable compliance with Apple's mandate.  We hope to have this functionality ready for release within the next week.  We will post an update here when it's available.

Amplify v1.19.0 was just released with support for Cognito User Pool account deletion.  Additional documentation will be released soon, but in the meantime, here's an example usage:
        Amplify.Auth.deleteUser { result in
            switch result {
            case .success:
                print("Successfully deleted user")
            case .failure(let error):
                print("Failed to delete user with error: \(error)")
            }
        }

Amplify v1.19.0 was just released with support for Cognito User Pool account deletion. Additional documentation will be released soon, but in the meantime, here's an example usage:
        Amplify.Auth.deleteUser { result in
            switch result {
            case .success:
                print("Successfully deleted user")
            case .failure(let error):
                print("Failed to delete user with error: \(error)")
            }
        }

Excellent! Thank you

Is there any trigger for this? I see we have a post verification signup trigger (which is what I'm using to create the dynamodb table):
Do you want to configure Lambda Triggers for Cognito? Yes
Which triggers do you want to enable for Cognito?  Post Confirmation

Do we have anything like this for deletion? If not how can I implement it?
@ameter @royjit


CMake policy CMP0072

Environment

OS Version: Ubuntu Focal
Source or binary build? Source
CMake 3.16

Description

Expected behavior:  Builds with no warnings
Actual behavior:

CMake Warning (dev) at /usr/share/cmake-3.16/Modules/FindOpenGL.cmake:275 (message):
  Policy CMP0072 is not set: FindOpenGL prefers GLVND by default when
  available.  Run "cmake --help-policy CMP0072" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  FindOpenGL found both a legacy GL library:

    OPENGL_gl_LIBRARY: /usr/lib/x86_64-linux-gnu/libGL.so

  and GLVND libraries for OpenGL and GLX:

    OPENGL_opengl_LIBRARY: /usr/lib/x86_64-linux-gnu/libOpenGL.so
    OPENGL_glx_LIBRARY: /usr/lib/x86_64-linux-gnu/libGLX.so

  OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY", so for
  compatibility with CMake 3.10 and below the legacy GL library will be used.
Call Stack (most recent call first):
  /home/chapulina/dev_focal/ws_fortress/install/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:189 (find_package)
  CMakeLists.txt:58 (ign_find_package)

Steps to reproduce

Compile from source with a CMake version higher than 3.10
Solution
If we want to keep compatibility with CMake 3.10, I think we should explicitly set the policy to OLD.

Further reference: https://cmake.org/cmake/help/git-stage/policy/CMP0072.html
I think the better behavior is to check if the policy exists and make use of the newer version.  This shouldn't have any impact on our current cmake mechanisms, as far as I can tell:
if (POLICY CMP0072)
  cmake_policy (SET CMP0072 NEW)
endif(POLICY CMP0072)

I believe we also need to propagate it out to the ignition-renderingXX-ogre-config and ignition-renderingXX-ogre2-config to make sure that downstream users don't also get the warning.

A bit more background on what this error mean (to make a better informed decision):
The context is switchable graphics. Eons ago drivers would replace libGL.so with their own and call it a day.
But today it is very normal to have multiple GPUs installed (specially laptops with switchable graphics between Intel and NVIDIA; AMD + Intel combo isn't a problem because they are both provided by Mesa so it's the same libGL.so)
So a new library was made, libOpenGL.so, which decides at launch time which libGL.so to launch. This interface is known as GLVND.
If configured properly launching:
__NV_PRIME_RENDER_OFFLOAD=1 __GLX_VENDOR_LIBRARY_NAME=nvidia glxinfo
__GLX_VENDOR_LIBRARY_NAME=mesa glxinfo

Today it works out of the box if using the NVIDIA installer (no need to mess with xorg.conf), but Ubuntu 20.04's packaged NVIDIA drivers broke this (maybe on purpose?) as trying to use mesa will give X11 interface errors.
So basically the error is saying link against libOpenGL instead of libGL to better support switchable graphics.
Ogre 2.1+ uses dlopen( "libGL.so.1", RTLD_LAZY | RTLD_LOCAL) at runtime rather than relying on the linker and it seems GLVND at that time can already intercept the call and choosing Mesa vs NVIDIA it seems to work (I use it all the time on gazebo to test NV and AMD discrete GPUs)
Ogre 1.x uses a very similar way to load OpenGL so it should be working, but I didn't check it.
Hence this CMake warning probably can be safely ignored because we don't actually link against libGL or libOpenGL during build time; unless you have other tools (other than Ogre) linking against GL directly.

I tried a few things here but I wasn't able to silence the warning while still using ign_find_package(OpenGL...). The cmake_policy command has complicated scoping. These didn't work:
  if (POLICY CMP0072)
    cmake_policy (SET CMP0072 NEW)
  endif(POLICY CMP0072)
  ign_find_package(OpenGL
    REQUIRED_BY ogre ogre2
    PKGCONFIG gl)

  if (POLICY CMP0072)
    cmake_policy (SET CMP0072 NEW)
  endif(POLICY CMP0072)
  ign_find_package(OpenGL
    REQUIRED_BY ogre ogre2
    PKGCONFIG gl
    EXTRA_ARGS NO_POLICY_SCOPE)

  if(POLICY CMP0072)
    cmake_policy(PUSH)
    cmake_policy(SET CMP0072 NEW)
  endif()
  ign_find_package(OpenGL
    REQUIRED_BY ogre ogre2
    PKGCONFIG gl)
  if(POLICY CMP0072)
    cmake_policy(POP)
  endif()

This does work, but we lose the REQUIRED_BY and PKGCONFIG:
  if (POLICY CMP0072)
    cmake_policy (SET CMP0072 NEW)
  endif(POLICY CMP0072)
  find_package(OpenGL)

Other things that I thought of trying:

Adding a POLICY parameter to ign_find_package
Hardcoding the policy in ign-cmake's ign_find_package
Creating a custom FindOpenGL.cmake where the policy is set

Does anyone have a better idea? Now that Jenkins CI is using Focal  (https://github.com/ignition-tooling/release-tools/pull/565) this warning is turning the build yellow.

What about setting OpenGL_GL_PREFERENCE variable?
I guess push/pop policy doesn't make sense in this case because once FindOpenGL has executed, the effects are irreversible (variables are set with OGL libs and folders), even if the policy is popped

What about setting OpenGL_GL_PREFERENCE variable?

Thanks, that does it! https://github.com/ignitionrobotics/ign-rendering/pull/528
That's still not propagated to downstream projects though, not sure if ign-cmake provides a way to propagate the variable to the config files like @mjcarroll mentioned above.

Fixed by https://github.com/gazebosim/gz-rendering/pull/528


Mac: Add version information to kext and PrjFS logging daemon

Resolves #1181
The changes in this PR set the CFBundleVersion and CFBundleShortVersionString of the kext and the kext logging daemon.
Apple uses a slightly different versioning scheme than we do, and I applied the following mapping:

CFBundleVersion -> Our version numbers are W.X.Y.Z, and CFBundleVersion is set to Y.Z.  I went with Y.Z as it's the build number portion of the VFS4G version.

CFBundleShortVersionString -> Officially only versions of the format [Major].[Minor].[Patch] are supported, but based on what I've found on StackOverflow as best I can tell this is only enforced when uploading to the app store.  For now I've left this as our usual version number, and it displays in the "Info" dialog of the kext and logger:

@jrbriggs, @nickgra, @jeschu1, @alameenshah, @pmj
I arrived at the changes in this PR using a lot of trial and error.  I don't have experience with the versioning schemes used by Apple, and if you have any recommendations for better choices for CFBundleVersion or CFBundleShortVersionString please let me know.
If in the future we need to move to a [Major].[Minor].[Patch] for CFBundleShortVersionString I was thinking we could apply the following transformation to our versions:
W.X.Y.Z ->  W.X.YZ (adding padding to Z so that it's always at least 3 digits).
Example:
1.0.19175.3 -> 1.0.19175003

Sorry, only just got around to taking a look at this. Those version numbers look like they'll conflict with some of the limits Apple places on the various positions of the bundle version string:

The build version number should be a string comprised of three non-negative, period-separated integers with the first integer being greater than zero—for example, 3.1.2. The string should only contain numeric (0-9) and period (.) characters. Leading zeros are truncated from each integer and will be ignored (that is, 1.02.3 is equivalent to 1.2.3). The meaning of each element is as follows:

The first number represents the most recent major release and is limited to a maximum length of four digits.
The second number represents the most recent significant revision and is limited to a maximum length of two digits.
The third number represents the most recent minor bug fix and is limited to a maximum length of two digits.

If the value of the third number is 0, you can omit it and the second period.
While developing a new version of your app, you can include a suffix after the number that is being updated; for example 3.1.3a1. The character in the suffix represents the stage of development for the new version. For example, you can represent development, alpha, beta, and final candidate, by d, a, b, and fc. The final number in the suffix is the build version, which cannot be 0 and cannot exceed 255. When you release the new version of your app, remove the suffix.

I suspect the OS isn't very fussy about enforcing these limits for apps and dylibs, but as far as I'm aware, the limits are enforced to some extent for kexts. I'm sure we can dig up the extent to which they're enforced in the kexttools source or similar, but it's probably best to stick with the published limitations. The only thing I wouldn't worry about is the first number being greater than 0 - the OS definitely accepts versions starting with 0.
Is the "Z" in our version number important to include in all public releases? If not, we could use it in only development builds by using a W.X.YdZ versioning scheme, and just W.X.Y for release builds.
That leaves the limit of 4 digits for W and X and 2 digits for Z. I don't know how our version numbers are generated, so I'm not sure to what extent that'll be a problem. If necessary, we'll need to subdivide the version number differently.

@pmj thanks for the details on the version number limitations!  It explains why I'm seeing our official build pipeline fail with these changes (the version numbers are too long in that pipeline).
I think for now we can simplify the versioning scheme to:
CFBundleVersion -> [Major].[Minor]
CFBundleShortVersionString -> Our usual version number.
The main purpose of this PR is to get the version to appear correctly in Finder, and I'm seeing the behavior that you mentioned (it uses CFBundleShortVersionString).
Our versioning scheme frequently has 5 digits in the Y field of W.X.Y.Z (and the Z value is important) and so unless we find a technical reason for adjusting CFBundleVersion I don't think it's worth the complexity of mapping our version number to the format enforced by Apple.
The kext uses our regular version string for its interface version, and so that will protect us from kext <-> lib version mismatches.

I think for now we can simplify the versioning scheme to:
CFBundleVersion -> [Major].[Minor]
CFBundleShortVersionString -> Our usual version number.

cc: @jrbriggs as FYI


RD2: Display Elevate Information widget

We created a new Elevate Information widget that is displayed on a Recurring Donation detail page on an org connected to Elevate. To view this form, enable Apex class "RD2_ElevateInformation_CTRL" for required profiles.

Critical Changes
Changes

For Elevate and Enhanced Recurring Donations customers, we created an Elevate Information component a Recurring Donation detail pages. To enable the component, you must assign the RD2_ElevateInformation_CTRL Apex class to your user profiles and assign at least read permissions on the Elevate Recurring Id, Status and Status Reason fields.

Issues Closed
Community Ideas Delivered
New Metadata

Custom Labels:

RD2_ElevateCancelInProgress
RD2_ElevateDisabledHeader
RD2_ElevateInformationHeader
RD2_ElevateInformationStatusSuccess
RD2_ElevateRecordCreateFailed
commonErrorPrefix
commonViewErrorLog

Apex Class:

RD2_ElevateInformation_CTRL
RD2_ElevateInformation_TEST

Lightning Component Bundle:

rd2ElevateInformation

Deleted Metadata

Tracking W-7865061

Great work, @RadSFDeveloper!


optional checksum validation, bugfix in fix_perf - the message were empty / not parsing anything

FLAG_PARSE_FAST would skip checksum validation
buffer_append was flawed parse benchmark did nothing as the input was empty

@penberg thanks for comments, done


Never seen this. What environment are you using? Can you update the drivers?

Thanks,
I use Ubuntu 16.04,
tf 1.14
python 3.7
you mean which driver to update?
On Sun, Feb 7, 2021 at 5:12 PM iuri frosio<EMAIL_ADDRESS>wrote:

Never seen this. What environment are you using? Can you update the
drivers?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NVlabs/GA3C/issues/44#issuecomment-774639888, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFHQXQPS52IRGERV45VVRXLS5ZKRBANCNFSM4XHG23PQ
.

GPU driver

Ok, I will try.
Do you mind telling me what does the args "$@" mean in the _train.sh?
python GA3C.py "$@"
this line in ga3c.py will return a valueerror since no '=' is given:
x, y = sys.argv[i].split('=')
Thanks
On Sun, Feb 7, 2021 at 5:40 PM iuri frosio<EMAIL_ADDRESS>wrote:

GPU driver
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NVlabs/GA3C/issues/44#issuecomment-774643288, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFHQXQNMM5JEAAXYKMJ5VWDS5ZNXNANCNFSM4XHG23PQ
.

$@ is all of the parameters passed to the script in the sh file.
Please also double check that your config file contains correct parameters.
It may be that your GPU does not have enough RAM - what GPU are you using?
You can try directly modifying the script parameters when calling train.sh - see the docs.

ah, I am using 2080. I might be the ram problem since I'm running a couple of training tasks as the same time. I will try  again once those tasks are done. Thanks


JavaSMT term transforming: inproper handling of function declarations

Currently in JavaSMTTermTransformer#transformApp, we are depending on the name of the function declaration to match in the environment variable. I believe (might not be true) that this is not standardized across solvers, for example some names back from mathsat5:

`not` while we are expecting not
`<=int` while we are expecting <=

JavaSMT helps however through FunctionDeclaration#getKind which returns a value from FunctionDeclarationKind. We should probably switch from String keys to FunctionDeclarationKind keys in the environment map, and use the getKind as lookup instead of getName.

You're right, we should not be using the string keys. Can you possibly send in a fix?

My next PR will include the proposed fix, but won't be perfect - for some of our existing cases I could not find the proper counterpart, and many of their options will be unhandled.

Please document these cases here, and we'll ask @baierd for some help. Thanks!


Impossible to see columns in hover tooltip in Influx Dashboard

Steps to reproduce:

Create a measurement with 10 tags
Create a cell with that graph
Hover over a point on the graph

Expected behavior:
The tooltip collapses or moves to fit all values in the screen
Actual behavior:
The tooltip i placed wrong and the values are off the screen making it impossible to see them
Environment info:
Version 2.0.4 (4e7a59b)

@doivosevic there is a graph config option for displaying the legend horizontally now. You can find it in the gearbox icon next to the graph type.


Feature Request: @PartyAdd

Could be useful a trigger that fires when a member is added to a party.
For example to add some effect on party members, like an aura, always active on party members.

thank you, it works but i think i found a bug.
If you invite 2 player to your party, with the context menu, before the party exists, and the second player accept the invite, the first invite is canceled but the player can still accept and he join a phantom party.

Another request: is it possible to invite player with the context menu even if the party already exists? right now you can invite with the context menu only the first member, but it would be convenient to invite other members with the context menu.

The problem is, this party context menu totally client-side. What I mean is we can't change it's design, because it's not designed in Server. The buttons automatically removed from the context when you join the party, for the invites, you can join parties after 1st player joined so it's expected behaviour but probably client doesn't parse that correctly and context updated wrongly, I can check the send packets to see if we have anything wrong from server-side about sending information for joined players, but probably it's typical client-side bugs which UO owners Osi/Bloodblabla never care to fix.

The problem is that the player who accepts the invitation last, doesn't join the party where he was invited.
The party system for that player become broken. As you can see in the screenshot, the "leave the party" button is visible (as if he were in a group) with no party members. .xshow party or .xshow isinparty return 0 and the player can't accepts further invitations. He can only logout to fix the problem.
About the context menu, isn't Sphere telling the client what entries to show in the menu? The context menu is customizable by scripts

I see, but I am testing on latest client and sphere, I have no issue about it, it probably client-side issue, or I don't know but seems like you only can invite 1 player to party same time, when you invite second person, it cancels automatically, and when I accept it says no invite for me. Even I joined party for 3 people still can see them in party without any issue. Probably the client you use doesn't parse it correctly,


Add custom frontend build

This will allow developers to easily replace the frontend code with their own built versions, thereby more flexibly customizing the UI.

Thanks for your contribution, this looks great! I would love to see a test with a simple html file in the dist folders. This would help make sure the feature work in the long term, and help document the target location.

Ok, I have added a test. Thanks to this, I found a mistake in the configuration I added. Tests do matter.


Refactor the fix for Custom Fields Overwriting

Bug Description
#2766 addressed an issue where an unset custom field was overwriting an already set one.
For 2.8.0 we shipped an immediate patch to get this functional but we want to address the code with a slightly more refined viewpoint
Steps to Reproduce
The issue is resolved but a better PR is required to clean it up
Expected behavior
The same thing but cleaned up
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

Version:
OS:
Python Version:
Docker Version:

Additional context
Add any other context about the problem here.

closing


Update Account API Documentation

Once #171  and #120 have been implemented, we should update the Account documentation here (see https://app.gitbook.com/@interledger/s/java-ilp-connector/)

Dup of #409


Auth Refresh fails and soft locks users out of the system

Expected Behaviour
When logging back into an app after a refresh token has expired login should work correctly. The user should then be authenticated and be able to access data according to their role.
In the case of a renewal token that has expired, I'd expect the SDK to attempt to login using the usual method at the auth/login endpoint.
 Even after calling:
sdk.auth.storage.removeLoginData();

Steps to Reproduce

Set up your Directus instance to have an auth token expire quickly
for example:

ACCESS_TOKEN_TTL=1m
REFRESH_TOKEN_TTL=2m

Use the SDK to log into your system using valid credentials:

sdk.auth.login(email: email, password: password)

Once you've logged in kill the app
Wait for 3 minutes, or enough time for the tokens to expire
Try to log in again in the same app

note: clearing out the data from the app fixes the issue.
Context
Building machine: Windows 10
Flutter Doctor output:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.3.10, on Microsoft Windows [Version 10.0.19045.2486], locale en-NZ)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.4.2)
[√] Android Studio (version 2021.3)
[√] VS Code (version 1.74.3)
[√] Connected device (4 available)
[√] HTTP Host Availability

• No issues found!

directus sdk version: 0.9.3
Detailed Description
Our testers have noticed that occasionally when trying to log in they'll get locked out of the app and we've worked out it's when the SDK is trying to use an expired renewal token. Since the default renewal token expiry is 7 days this only happens occasionally (until we set the expiry to much shorter).
Looks like the stored token is continued to be attempted and the login never reverts to the normal login methods, even after trying to clear out the stored user auth data.

@apstanisic Yes I've tried logging off and now this update does not fix the issue.
I've had a deeper dig into the code and the issue is centered around the
refreshExpiredTokenInterceptor method/callback in auth_handler.dart
This is called on all network calls.
The fix above adds in a check on failure (for example when the refresh token expires) and attempts to log out, which calls the above and attempts to auth/refresh which then fails and tries to log out, repeating forever.
By adding this line above the current fix:
tokens == null;

Stops the above infinite loop, but doesn't address the root issue.
What I'd expect is if I'm calling login() with an email and password it should just work regardless of token or refresh token status.
that is if logging in fails, then it should automatically clear out the stored, problematic data, and attempt to log in again from scratch.
I can see from network monitoring that if there are stored tokens, the auth/login is never hit, only auth/refresh (which continues to fail since the refresh token has expired).
Am I missing some core security consideration or is this the expected behavior?
So here's what I did to fix this;
in the login function of auth_handeler.dart
I expanded the catch to automatically clear out the current tokens and try again with this:
 } catch (e) {
      if(tokens != null){
        tokens = null;
        return login(email: email, password: password, otp: otp);
      }
      throw DirectusError.fromDio(e);
    }

This seems to work as I'd expected, but I'm not sure if it introduces any additional security holes.

Yeah, I thought to reuse login method, but it's not possible, since it causes loop, and _refreshClient is locked.
You fix is good, just need to remove remaining properties.
Can you try 0.9.5. This fix should delete all stored data on fail without trying to logout, and delete it just in case before trying to login like in your example

@apstanisic Yep looks like 0.9.5 sorts the issue for me.
Thank you!


Wrong link usage in Bug report template

Description
There's a wrong link used for the code of conduct link
Expected Behaviour
No response
Contact Details
No response
What happened?

Version
.yaml
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I would like to fix this


Debug not working with yarn 3 workspaces

Describe the bug
When using yarn 3 workspaces, test debugging might not work, depending on the location of the vitest executable.
To Reproduce
I opened #83 and added the samples/multi-root-workspace-no-root sample, and made a fix.
Without the last commit of my pr with the fix, the following error will happen when trying to debug a test:

Expected behavior
Debug should work.

This should work in the latest versions.


"attribute android:requestLegacyExternalStorage not found."

Android resource linking failed
D:\Code\Playgrounds\NsCameraTest2\platforms\android\app\src\main\AndroidManifest.xml:17:2-38:16: AAPT: error: attribute android:requestLegacyExternalStorage not found.

Command gradlew.bat failed with exit code 1

This is because<EMAIL_ADDRESS>contains android:requestLegacyExternalStorage="true", which is no longer supported in later APIs.

https://stackoverflow.com/questions/58976425/aapt-error-attribute-androidrequestlegacyexternalstorage-not-found
in your app.graddle
defaultConfig {
minSdkVersion 17
versionCode 8
generatedDensities = []
compileSdkVersion 29
}

This did resolve this particular issue for me, thank you


Prepend jdbc: to DatabaseMetaData.getURL result

Current DatabaseMetaData.getURL implementation returns without jdbc:, but it should be included it as other databases do it.
Related post on Stackoverflow: https://stackoverflow.com/questions/56488588/url-must-start-with-jdbc-error-while-connecting-to-presto-using-spring-boot

Merged, thanks!


How to add one data point into index after createIndex?

i am using nmslib for vector searching. I find that the addDataPoint function will not working if the index is already created. I have to add a createIndex function after addDataPoint to enable the single data point, which will be time consuming because my data points number is large.
How to solve this problem?
My code is something like this:
import nmslib
import numpy as np

a = np.array([[1.0,0,0], [0,1.0,0], [0.1, 0, 1.0]])
b = np.array([0,0, 1.0])
c = np.array([0,0, 0.9])

nmsl = nmslib.init(method='hnsw', space='l2')
nmsl.addDataPointBatch(a)
nmsl.createIndex({'post': 2}, print_progress=True)
nmsl.addDataPoint(3, b)
id, dist = nmsl.knnQuery(c, 2)
print id, dist

Hi @universewill this is not supported yet.

Is it very difficult to support this feature with nmslib? Cause I think it is a really good feature if nmslib is used in product scene. @searchivarius

@universewill Probably hnswlib (https://github.com/nmslib/hnsw/) is a good match for your tasks. It supports incremental indexing.

@yurymalkov Yeah! that's cool. Thanks.