Cant get maps out of the bundle on 1.20.6

idk why, no error in console, nothing

survival too, not creative

I believe it's on purpose.
This issue is from some months now, but I leave this here for any other person who might end up looking for help on the same issue:
You can't get the maps out of the bundle. However, right-clicking the bundle on an item frame will place the maps automatically. You have to make the specific frame size for it to fit, and you can not retrieve the maps back. The bundle disappears too.
I believe this is a measure to avoid having players dupe bundles.


Discuss: Add don't_escape to strings and don't escape HTML if it is true

Or maybe the raw helper is already enough?

After thinking about this, I think the raw helper can handle this just fine


Avoid using Set, to save 27K in polyfills

Can we remove the usage of Set in DayPickerRangeController and DayPickerSingleDateController ?
Currently, many browsers still don't support Set and the polyfills are quite big (for example, es6-set is 27K after minification, because it also includes Symbol and other polyfills).
Set is currently only used in modifiers, so maybe the prop could be changed to accept a Set or an array. And convert to an array, and use only an array internally.
Internally wrapping the array to have a ".has" and ".add" method would be quite easy and certainly smaller than 27 Kilobytes.
I can make the pull request if you find this interesting.

We recommend https://npmjs.com/airbnb-browser-shims; we don’t recommend es6-set, nor can symbols be faithfully polyfilled anyways.
The benefits of Set are more than the API; they’re also the O(1) lookup and the uniqueness.


Dockerfile installs Python 3.6 but uses 3.8

Tentative fix: https://github.com/red-hat-data-services/ods-ci/pull/404
However, this fails later, failing to find robotframework-openshift==1.0.0:
Collecting robotframework-OpenShiftCLI==1.0.1
  Downloading robotframework-OpenShiftCLI-1.0.1.tar.gz (14 kB)
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'
ERROR: Could not find a version that satisfies the requirement robotframework-openshift==1.0.0 (from ods-ci) (from versions: none)
ERROR: No matching distribution found for robotframework-openshift==1.0.0

I don't really understand the problem, this is latest available release.
Is that Dockerfile even used?

The original description was a bit off. Rewriting it:
Installing any RPM-packaged Python application will pull Python 3.6 on RHEL8/Streams8 because 3.6 is the system default.
This, in turn, will break building the ods-ci container because ods-ci has been using Python 3.7 features since commit ff7ac1f7.


Parse escaped values

Based on https://github.com/tonerdo/dotnet-env/pull/7 so need that to get merged before this can be properly diffed.  Just adds one more arg and a method to handle it.

Rebased and ready for review of this new feature

Thanks for this @rogusdev, will take a look at it soon. Once this gets merged in I'd do a new release

Can we get this merged?

@rogusdev sorry I missed this. Your contributions have been quite impressive and your input on other PRs very useful, are you interested in becoming a collaborator?

Sure @tornedo, I'm happy to help :)

Here you go: https://github.com/tonerdo/dotnet-env/invitations. Now you should be able to merge PRs


implement awaitAll

please review

Looks good!
Could you please also bump library version in hxasync/blob/main/haxelib.json?


Yet another type safe implementation of event emitter

Consider move mpp::timer to timer.hpp,
as utility is not a good name for timer.


"YAMLException: The incoming YAML document exceeds the limit: 3145728 code points."

Whiile testing PR #692, I came across the following issue with files >3MB:

Error parsing signing metadata file /tmp/test.yaml: YAMLException: The incoming YAML document exceeds the limit: 3145728 code points.

Is there a reason for this limit, or can it be increased?
Ping @usmansaleem

Hi @gg718, this "limitation" was not intended and got introduced due to underlying SnakeYaml implementation (1.32) which is used by Jackon dataformat libraries. See https://github.com/FasterXML/jackson-dataformats-text/tree/2.15/yaml#maximum-input-yaml-document-size-3-mb
We will make some modifications in Web3Signer to set the default value to 1GB and also make it configureable using a cli option as well.


[Fix] (ccr) Wrong result of tosql for add column with comment

What problem does this PR solve?
ccr increment sync problem, ccr-syncer also will be fixed and add test case
alter table t add column col1 varchar(20) NULL COMMENT "xxx\"xx\""

[2024-12-11 17:48:30.737]  WARN job sync failed, job: test, err: [normal] Error 1105 (HY000): errCode = 2, detailMessage =
mismatched input 'xx' expecting {<EOF>, ';'}(line 1, pos 64)
exec sql ALTER TABLE `t` ADD COLUMN `col1` varchar(20) NULL COMMENT "xxx"xx"" failed
github.com/selectdb/ccr_syncer/pkg/ccr/base.(*Spec).DbExec
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/base/spec.go:1166
github.com/selectdb/ccr_syncer/pkg/ccr/base.(*Spec).LightningSchemaChange
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/base/spec.go:1242
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).handleLightningSchemaChange
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/job.go:2107
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).handleBinlog
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/job.go:2725
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).handleBinlogs
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/job.go:2662
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).incrementalSync
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/job.go:2839
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).dbSync
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/job.go:2900
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).sync
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/job.go:2917
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).run
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/job.go:2975
github.com/selectdb/ccr_syncer/pkg/ccr.(*Job).Run
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/job.go:3096
github.com/selectdb/ccr_syncer/pkg/ccr.(*JobManager).runJob.func1
    /mnt/disk2/wangyixuan/ccr-syncer/pkg/ccr/job_manager.go:166
runtime.goexit
    /mnt/disk2/wangyixuan/go_1_23/go/src/runtime/asm_amd64.s:1700 job=test line=ccr/job.go:2980

Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[ ] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall

run buildall

run buildall


Signal containing object need a copy to update value

Hello,
First of all, thank you for your great work on this repo, it simplifies my code and my development work so much.
However, I encountered a problem when using signals. Unless I'm mistaken, it's not possible to update the value of an object stored in a signal without making a copy.
Example:
const data = signal({
    id: 4,
    name: "John",
    surname: "Doe",
    age: 32,
});

// won't trigger a re-render
data.value.age = 33;

// will trigger a re-render
data.value = {
    ...data.value,
    age: 33,
};

This isn't an issue for very small objects, but the performance of my application quickly degrades when I have larger objects (dict with ~100 keys): I therefore had to separate my object into several signals, but this results in rather messy code.
Is there a way to solve this problem?
Many thanks

You could do something along the lines of deeply setting the object to be a signal, I know there are already libs like https://github.com/luisherranz/deepsignal

Thank you ! I will look into it

I've ported full vue deep reactivity tracking for preact signals: preact-signals/utils

Going to close this out, I don't think there's anything here that we need to address.


libp2p as a Tor pluggable transport

Brief talk: https://www.bamsoftware.com/talks/30c3-pt/index.html
Wiki: https://trac.torproject.org/projects/tor/wiki/doc/PluggableTransports
Spec: https://gitweb.torproject.org/torspec.git/plain/pt-spec.txt

[ ] Investigate for technical feasability
[ ] How exactly to do it
[ ] Who could help with implementation and testing
[ ] Who in the Tor team can guide us

libp2p as a Tor pluggable transport or Tor as a libp2p transport?
OpenBazaar created the later https://github.com/OpenBazaar/go-onion-transport

libp2p as a Tor pluggable transport or Tor as a libp2p transport?

The question is answered by the issue's title and the provided links (?)

@diasdavid I think it's about using circuit relay to circumvent tor blockades.

@lgierth it as the title and links and knowing how libp2p works + how the integration by the open bazaar team was built that got me confused :)

@diasdavid I think it's about using circuit relay to circumvent tor blockades.

No it's quite simply about using libp2p as a Tor pluggable transport, i.e. as a network transport for Tor :) See the three links at the top.

Is there still work being done on this? If so, has it been decided to have libp2p as a pluggable Tor transport or have Tor as a libp2p transport?

This issue is about running tor over libp2p. There's also an onion transport for libp2p: https://github.com/OpenBazaar/go-onion-transport/.


feat: new templating API

🤖 Generated by Copilot at f48d393
Summary
🐛🛠♻

This pull request refactors the bare-template app to use the plate function for generating code from templates, which improves the flexibility and readability of the code. It also fixes some syntax and formatting errors, removes unused files, simplifies the build and test process, and adds a new dependency for testing.

The bare-template app got a makeover
With plate function to make it smoother
It fixed some syntax
And added some tricks
To generate code like no other

Walkthrough

Update main and types fields in package.json to point to template files instead of config files (link)
Add tmp-promise dependency to package.json for testing (link)
Use @nx/js:tsc executor instead of custom build-tsc target in project.json to simplify build process (link)
Add test target to project.json to run mocha tests with coverage and output options (link)
Remove extra backtick in README.yml code block (link)
Delete src/.npmrc.t.ts file (link)
Set strict-peer-dependencies to false in src/.npmrc file to avoid errors when installing dependencies (link)
Use plate function instead of text function in various files to allow for better interpolation of expressions and imports (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
Use InputOf type instead of ExtractInput type in package.json.t.ts to be consistent with new plate API (link)
Use template variable instead of config variable in package.json.t.ts to be consistent with new plate API (link)
Use template.define.text method instead of defineTemplate function in package.json.t.ts and project.json.t.ts to be consistent with new plate API (link, link, link)
Add missing commas in package.json.t.ts and dx.yml.t.ts to fix syntax errors (link, link, link, link, link, link, link, link, link, link)
Remove extra space in dx-dev.yml.t.ts to fix syntax error (link)

ok @wittjosiah so nx apidoc docs fails here because it looks like the apidoc api template is built for esnext for some reason (maybe because it builds together with the docs site?) and when the template goes to execute it actually has to load the modules in it with ts-node on the fly https://github.com/dxos/dxos/blob/zhenya/plate-better/packages/common/plate/src/util/loadModule.ts and it's confused when it encounters a .ts file... clearly doing this wrong... what's the best way we should execute template code?


JSONLDSettings should permit setting the DOCUMENT_LOADER for the new (Titanium = Hasmac) DocumentLoader

Current Behavior
One cannot set a custom (new) no.hasmac.jsonld.loader.DocumentLoader on JSONLDSettings in v5.0.1 - because DOCUMENT_LOADER is still the (old) com.github.jsonldjava.core.DocumentLoader instead.
Expected Behavior
You would either want to switch DOCUMENT_LOADER from com.github.jsonldjava.core.DocumentLoader to no.hasmac.jsonld.loader.DocumentLoader (preferred), or alternatively introduce some sort of DOCUMENT_LOADER_NEW or something (ugly).
Version
5.0.1
Are you interested in contributing a solution yourself?
Perhaps?
Anything else?
The more general issue here is that, coming from #4907, I've found that the "switch" from jsonldjava to Titanium/Hasmac JSON-LD is still somewhat partial, only; there's still a legacy implementation (in a separate artifact; fine, of course) but the RIO API still depends on com.github.jsonld-java:jsonld-java - because of the use of com.github.jsonldjava.core.DocumentLoader in JSONLDSettings.
The way I personally would solve this modularity conundrum is by moving those settings into separate e.g. LegacyJSONLDSettings (for jsonld-java) - but have neither in the API artifact; so move JSONLDSettings (without the com.github.jsonldjava.core.DocumentLoader) from core/rio/api/src/main/java/org/eclipse/rdf4j/rio/helpers to core/rio/jsonld/src/main/java/org/eclipse/rdf4j/rio/jsonld.
(This would be a backwards incompatible API change, of course.)
This issue (probably) isn't going to block me, as in my application (I'll share the code, once I push it) I can just directly use EXPAND_CONTEXT which already uses no.hasmac.jsonld.document.Document.
But this (to me) somewhat mix of old/new JSON-LD libraries still seems like something perhaps worth cleaning up, some day.
Let me know if you would welcome a PR about this (but it's probably better to discuss and agree upon the "design" here beforehand).

Some relevant discussion: https://github.com/eclipse-rdf4j/rdf4j/discussions/5068

Originally we had copied over all the settings into the various Rio modules. This way we could allow for a migration path for users where they would have time to adopt the new settings before we removed them.
The use of enums had complicated this for our JSON-LD Rio module, so we didn't have any migration options for users in RDF4J 4.3.x.
I didn't want to break too many applications that depend on RDF4J, so I opted to not split out the settings for JSON-LD in RDF4J 5.
Not adding support for configuring a document loader with the new JSON-LD implementation was an oversight on my part though. I should have added a new setting for that.
We can get this added for RDF4J 5.1. Would appreciate some inspiration for what we should call the new setting.
Maybe

CUSTOM_DOCUMENT_LOADER
OVERRIDE_DOCUMENT_LOADER
JSON_LD_DOCUMENT_LOADER
DOCUMENT_LOADER_HASMAC

Or we could expose the entire json-ld options object from HASMAC JSON-LD.

Hmz, what about keeping the name of setting, but just make it a plain Object instead of a com.github.jsonldjava.core.DocumentLoader ?
That way both the old and the new JSON-LD parser would be able to use it (I guess), and it would remove the old jsonld-java library as a direct depency from the rio helpers package ?

This issue (probably) isn't going to block me, as in my application (I'll share the code, once I push it)

FYI this is about RdfReaderConverterInto.java in https://github.com/enola-dev/enola/pull/796 (WIP).

Would appreciate some inspiration for what we should call the new setting.

DOCUMENT_LOADER_HASMAC is my favorite among the options you listed, because with that strongly typed API, this settings is de-facto specific to HASMAC anyway - so I like that name clearly expressing it. And you already have a "hard" dependency from API to HASMAC anyway (because of that FRAME and EXPAND_CONTEXT), so it's just one more.

Or we could expose the entire json-ld options object from HASMAC JSON-LD.

I'm not 100% sure what you mean by "the entire json-ld options object", but just having e.g. an HasmacJsonLdSettings only in <artifactId>rdf4j-rio-jsonld instead of <artifactId>rdf4j-rio-api to me seems the best because cleanest way to solve this modularity conundrum! The way it's currently done feels a little bit like "cheating," to me... 😃  as in, why have modules at all, then?

Hmz, what about keeping the name of setting, but just make it a plain Object instead of a com.github.jsonldjava.core.DocumentLoader ?

That would work as well, of course; just a less type-safe, seems a tiny bit like a shame having that RioSetting<T extends Object> design but then not actually using it? Using the same setting for both the old and new implementation also makes errors when upgrading more difficult to catch (runtime type cast exception only, instead of clear compile time). Ultimately this is probably more your (maintainers) choice than mine.. it's a trade-off on backwards compatibility and all. But if you are cool with breaking API in 5.1.0 anyway, then personally I would not do this, but go for an HasmacJsonLdSettings - if it was up to me.
This could also be done in 2 stages, of course.

This is the JSON-LD options object: https://github.com/HASMAC-AS/hasmac-json-ld/blob/main/src/main/java/no/hasmac/jsonld/JsonLdOptions.java
We can't make any breaking changes until RDF4J 6.

This is the JSON-LD options object

Oh, I see; yeah I guess exposing it as RioSetting<JsonLdOptions> via an HASMAC_OPTIONS setting would make great sense.

We can't make any breaking changes until RDF4J 6.

Right, so then probably best in 2 stages:

For a 5.1.0 add an RioSetting<JsonLdOptions> to a new class org.eclipse.rdf4j.rio.jsonld.HasmacJsonLdSettings extends org.eclipse.rdf4j.rio.helpersJSONLDSettings in rdf4j-rio-jsonld (NOT to rdf4j-rio-api)

For a future 6.0.0 clean this up and remove the remove the old jsonld-java library as a direct dependency of the API module.

Does that sound reasonable? Let me know if you would welcome a (1st) PR about this.

I'm not completely sure if we should create a new settings class or not. The way that we've done it for the other settings classes is that we have duplicated them within their respective Rio modules. And we kept the same class name as before.  When we tried the same for the json-ld settings we ran into issues with the use of enums.
I think I want to play around with it a bit to see what makes sense. If you want to make a PR it would be great, just keep in mind that we might need some changes. Hope that's ok :)


I want to install NVM with .nvm being installed in a different directory than ~

Long story here - normally .nvm goes to ~/.nvm
I would like to write .nvm to a different directory. How can I do that?
When I try
HOME=. && curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.1/install.sh | bash

NVM still tries to put .nvm in the original $HOME directory.

ha ok this worked
export HOME=. && curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.1/install.sh | bash

But I get this:

nvm is not compatible with the npm config "prefix" option: currently set to "/var/lib/openshift/emsa-k76pvx3istg-1/app-root/runtime/repo/.nvm/versions/node/v6.10.0"
Run `nvm use --delete-prefix v6.10.0` to unset it.

I want to use that prefix and it should work as is, why do you think nvm wants me to unset it?

Simply set $NVM_DIR before running the install script - you should not overwrite $HOME.
The npm prefix option is incompatible with nvm because it, not you, manages your node install (as well as where global modules are installed). However, looking at the error, is any part of that path a symlink, or a network mount?

It might be part of a symlink, let me verify that

Specifically, $NVM_DIR can't be a symlink.
Why don't you want it inside $HOME?

 The only place to put .nvm is
in our source code, sounds crazy but should work.
On Mar 18, 2017 12:05 AM, "Jordan Harband"<EMAIL_ADDRESS>wrote:

Specifically, $NVM_DIR can't be a symlink.
Why don't you want it inside $HOME?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/creationix/nvm/issues/1436#issuecomment-287521787,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKn56AtlDvxLU4FnUsxNTEx1ByTX6u-Uks5rm4JEgaJpZM4MhK7g
.

So instead of:
export HOME=${DIRNAME} && curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.1/install.sh | bash
we will just set:
 export NVM_DIR=${DIRNAME}/.nvm curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.1/install.sh | bash

Yes, exactly.

ok cool thank you


Refactor ObjC dependencies in definite_init_diagnostics tests

This change moves functionality that requires ObjC interop into a new file and
removes the XFAIL on Linux. Partially resolves SR-216.
--
Tested on Ubuntu 14.04 & OS X 10.10.

Thank you!

Thank you!


react-aria/useComboBox Error when typing

Provide a general summary of the issue here
i have that error whenever i type something at the input
stopPropagation is now the default behavior for events in React Spectrum. You can use continuePropagation() to revert this behavior.
🤔 Expected Behavior?
no errors
😯 Current Behavior
console.error('stopPropagation is now the default behavior for events in React Spectrum. You can use continuePropagation() to revert this behavior.')
💁 Possible Solution
just remove it or comment it
🔦 Context
No response
🖥 Steps to Reproduce
      stopPropagation() {         // console.error('stopPropagation is now the default behavior for events in React Spectrum. You can use continuePropagation() to revert this behavior.');       },
Version
@react-aria/interactions v 3.20.1
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
windows
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Can you provide a codesandbox or stackblitz demonstrating where you are running into this? I'm not seeing it in any of our examples.


Feature export problem with Mapsui.Rendering.Skia.MapRenderer().RenderToBitmapStream

Hello!
I'm using Mapsui Version 4.1.7 wpf and Windows 10.
I exported MyMapControl.Map.Layers with
Mapsui.Rendering.Skia.MapRenderer().RenderToBitmapStream(MyMapControl.Map.Navigator.Viewport, MyMapControl.Map.Layers,MyMapControl.Map.BackColor);
In general that works well, but if I use data as PictureFeature in Features of a layer, then this layer is not exported.
(see also discussion #1867 for PictureFeature)

This is a sceenshot of the Debugger, showing two layers of  MyMapControl.Map.Layers. Layer 1 contains my data in Features and is not exported. Layer 2 contains a circle, which is exported. I don't see a difference. Layer 0 is background map, which is exported as well.
Thanks for your help!

If you get only a partially rendered map, I found often, that there is an error while rendering. Did you add logging to see, if any errors occurred?

The Mapsui.Logging.Logger.LogDelegate has no output.... It exports an image, but one layer is missing (s. second image).


Simplify contribute tab

The contribute tab has to be simplified to fit what has been done in the iOS app

Light
Dark

Resolves #120

Actually I changed the wording a bit:
https://github.com/boolder-org/boolder-ios/blob/dd0cf9f2819b02e80835e038c30bcba862acd732/Boolder/fr.lproj/Localizable.strings#L188

@nmondollot Good catch! I adjusted that and here is the result:

Light
Dark


Conversion of array of bidirectional channels into directional fails

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.10.1
go version go1.10.1 darwin/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64" GOBIN="" GOCACHE="/Users/...../Library/Caches/go-build" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/...../go" GORACE="" GOROOT="/usr/local/Cellar/go/1.10.1/libexec" GOTMPDIR="" GOTOOLDIR="/usr/local/Cellar/go/1.10.1/libexec/pkg/tool/darwin_amd64" GCCGO="gccgo" CC="clang" CXX="clang++" CGO_ENABLED="1" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/sr/ljc7d6x12dd9872r0rzxw38r0000gn/T/go-build603898073=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?
func fail(x []chan int) []chan<- int {   return x }
https://play.golang.org/p/VPeStoH7PiL
What did you expect to see?
Successful build
What did you see instead?
cannot use x (type []chan int) as type []chan<- int in return argument

@nerd2 This is how Go types (and slices) work. chan int and chan<-int are different types. Just like interface{} and int32 are different types. A int32 can satisfy an interface{} in the same way a chan int add direction, but they are different types.
For a similar example, see:
https://play.golang.org/p/trjuRvqRzHU
Questions should be directed to: https://github.com/golang/go/wiki/Questions


segfault when using all 100000 bodies

Actually it sefaults with 64000 as well...but works for 32000. Weird.


Cache also remembers and retrieves invalid results

Describe the Bug

We use functools.lru_cache at least for lookup_hix_score() to cache the HIX calculations for the last 512 unique evaluation requests. We return the value obtained from the Textlab API, or None, when this was not successful (by try…except). However, to lru_cache, None is a perfectly normal result that is cached and will now be retrieved for requests trying to evaluate the same content as long as it is not flushed out by 512 new unique consecutive requests.
This means that even if the API is not available for a short time span and only affects this one request, the non-result can stick around in the system for a substantial amount of time and seriously frustrate users.
Steps to Reproduce
>>> from functools import lru_cache
>>> api_dead = True
>>>
>>> @lru_cache(maxsize=8)
... def f(arg):
...   global api_dead
...   if api_dead:
...     print("Oops!")
...     api_dead = False
...     return None
...   else:
...     print("Evaluating")
...     return arg*2
...
>>> f(1)  # error, result None is cached anyway
Oops!
>>> f(1)  # cache hit
>>> f(2)  # api works again
Evaluating
4

Further calls
>>> f(3)
Evaluating
6
>>> f(4)
Evaluating
8
>>> f(5)
Evaluating
10
>>> f(6)
Evaluating
12
>>> f(7)
Evaluating
14
>>> f(1)  # cache hit, and (1, None) is the most recent entry again
>>> f(8)
Evaluating
16
>>> f(9)
Evaluating
18
>>> f(10)
Evaluating
20
>>> f(1)  # cache hit, because (1, None) is still not flooded out
>>> f(11)
Evaluating
22
>>> f(12)
Evaluating
24
>>> f(13)
Evaluating
26
>>> f(14)
Evaluating
28
>>> f(15)
Evaluating
30
>>> f(16)
Evaluating
32
>>> f(17)
Evaluating
34
>>> f(18)  # now (1, None) is discarded from cache
Evaluating
36
>>> f(1)  # can properly evaluate for the first time
Evaluating
2

Expected Behavior

Unsuccessful results are not cached
Actual Behavior

Unsuccessful results are cached
Additional Information

Offending code section: integreat_cms/cms/views/utils/hix.py:25

@lru_cache(maxsize=512)
def lookup_hix_score(text):
  """
  This function returns the hix score for the given text.
  It either performs an api request or returns the value from cache.

  :param text: The text to calculate the hix score for
  :type text: str

  :return: The score for the given text
  :rtype: float
  """
  try:
      return TextlabClient(
          settings.TEXTLAB_API_USERNAME, settings.TEXTLAB_API_KEY
      ).benchmark(text)
  except (URLError, OSError) as e:
      logger.warning("HIX benchmark API call failed: %r", e)
      return None

A naive approach to solve this might be to have an inner and an outer function, caching the inner and catching exceptions only in the outer function

We could also use cacheops instead of the @lru_cache and use something along the lines of:
import hashlib
from cacheops import cache, CacheMiss

def lookup_hix_score(text):
    cache_key = hashlib.md5(text.encode()).hexdigest()
    try:
        hix_score = cache.get(cache_key)
        logger.debug("HIX score loaded from cache")
    except CacheMiss:
        try:
            hix_score = TextlabClient(
                settings.TEXTLAB_API_USERNAME, settings.TEXTLAB_API_KEY
            ).benchmark(text)
            # Cache result for 24h
            cache.set(cache_key, hix_score, timeout=(60 * 60 * 24))
        except (URLError, OSError) as e:
            logger.warning("HIX benchmark API call failed: %r", e)
            hix_score = None
    return hix_score


Add QA checks through PHPStan and Psalm

To Do

[ ] Add missing hints;
[ ] Re-visit several generics.

Lint errors were found. A patch is also available.
Please see the report: https://flintci.io/repositories/8593/analyses/64084
This comment was posted by FlintCI. It can be disabled in the repository settings.

Lint errors were found. A patch is also available.
Please see the report: https://flintci.io/repositories/8593/analyses/64085
This comment was posted by FlintCI. It can be disabled in the repository settings.

Lint errors were found. A patch is also available.
Please see the report: https://flintci.io/repositories/8593/analyses/64088
This comment was posted by FlintCI. It can be disabled in the repository settings.

Lint errors were found. A patch is also available.
Please see the report: https://flintci.io/repositories/8593/analyses/64090
This comment was posted by FlintCI. It can be disabled in the repository settings.

Lint errors were found. A patch is also available.
Please see the report: https://flintci.io/repositories/8593/analyses/64104
This comment was posted by FlintCI. It can be disabled in the repository settings.

Lint errors were found. A patch is also available.
Please see the report: https://flintci.io/repositories/8593/analyses/64105
This comment was posted by FlintCI. It can be disabled in the repository settings.

Lint errors were found. A patch is also available.
Please see the report: https://flintci.io/repositories/8593/analyses/64106
This comment was posted by FlintCI. It can be disabled in the repository settings.

Lint errors were found. A patch is also available.
Please see the report: https://flintci.io/repositories/8593/analyses/64108
This comment was posted by FlintCI. It can be disabled in the repository settings.

Lint errors were found. A patch is also available.
Please see the report: https://flintci.io/repositories/8593/analyses/64109
This comment was posted by FlintCI. It can be disabled in the repository settings.

Could you please rebase your PR and fix merge conflicts?


Generator does not create one of three concrete types defined in the schema

I've labeled this as a "question" just in case the following is expected behavior.
The schema in question defines a ProviderInterface, which looks something like the following:
interface ProviderInterface {
    activeImageUrl: String
    boardCertifications: [BoardCertificationType!]!
    # ... additional fields
    uid: ID!
}

That interface has three implementations defined in the schema:

Strangely, the Apollo generator only generates two of those:
public static class AsNonPhysicianType implements Provider {}

public static class AsPhysicianType implements Provider {}

I have been informed that the iOS generator is doing the same thing.
The only major difference between the FacilityType and the other two types is that the FacilityType has the same fields as the ProviderInterface. It does not define any extra fields.
Is that expected behavior? Why isn't the FacilityType generated?
A third concrete implementation is generated:
/**
   * Base interface type for facilities, physicians, and non-physician providers
   */
  public static class AsProviderInterface implements Provider

Presumably, this is the type that should be named FacilityType. Strangely, it's named AsProviderInterface and even has the comment defined on the original ProviderInterface:

If the behavior described is expected, an explanation would be greatly appreciated.

Hi @Orbyt . This is expected. In order to keep the codegen size small, Apollo Android only generates types for models that are used in queries. Looking at your example, it means you most likely have fragments on PhysicianType and NonPhysicianType ? Something like:
{
  provider {
    ... on Physician {
      field
    }
    ... on NonPhysician {
      otherField
    }
  }
}

The 3rd AsProviderInterface model is used as a fallback model for FacilityType but also any other new type that could be added to the schema without recompiling the app.

You're correct, FacilityType is not referenced in the query:
provider {
     activeImageUrl
     # ... additional fields
     uid
     ... on NonPhysicianType {
       firstName
       gender
       lastName
     }
     ... on PhysicianType {
       firstName
       gender
       graduationYear
       lastName
       patientRetention
       # ... additional fields
     }
}

Is there any sort of setting or configuration that can be used to generate the concrete FacilityType?

Is there any sort of setting or configuration that can be used to generate the concrete FacilityType?

There isn't because we haven't found a use case for this. How would you use it?

@martinbonnin It seems more appropriate to have generated types match the concrete types that implement an interface. Having an implementation generated for an interface (e.g. AsProviderInterface) seems quite odd. Do you disagree?

This implementation is a fallback class for potentially new objects in your schema that implement ProviderInterface. Imagine someone adding this in the server:
type Hospital implements ProviderInterface

Now your query can yield a response like:
{
  "provider":  {
     "__typename": "Hospital",
     "activeImageUrl": "https://...",
     "uid": "foo"
  }
}

Without AsProviderInterface, you'd only have Physician and NonPhysician which wouldn't work. But you might still want to access activeImageUrl and uid so this is made possible through the AsProviderInterface fallback type.
More generally,  there is no 1:1 mapping between GraphQL types from the schema and their equivalent Kotlin class. Apollo Android generates models based on the GraphQL queries, and not the schema. Meaning if you have two different queries:
query QueryWithOneField {
  field1
}
query QueryWithTwoField {
  field1
  field2
}

You will end up with 2 generated models:
class QueryWithOneField.Data(val field1: String)
class QueryWithTwoFields.Data(val field1: String, val field2: String)

This is nice because you can't access field2 from the context of QueryWithOneField. In this regard Apollo Android gives you type safety straight from the server to the client.
We could think of generating classes from the GraphQL schema but that will lose a lot of type safety. Basically every field would become nullable.

type Hospital implements ProviderInterface

Now your query can yield a response like:
{
  "provider":  {
     "__typename": "Hospital",
     "activeImageUrl": "https://...",
     "uid": "foo"
  }
}

Without AsProviderInterface, you'd only have Physician and NonPhysician which wouldn't work.

With regards to this example, why not have a Hospital class generated?

With regards to this example, why not have a Hospital class generated?

It will be generated if you recompile the app but mobile apps have a long lifetime and we must account for apps in the wild running an older version of the generated models. We don't want these to crash if a new type is added on the server.

It will be generated if you recompile the app but mobile apps have a long lifetime and we must account for apps in the wild running an older version of the generated models. We don't want these to crash if a new type is added on the server.

Wouldn't an "old" app not have the updated schema nor updated queries and therefore not be querying for the new type anyway?

That's the thing with querying an interface (like provider here), you can't tell in advance what is going to be returned by the server.
An old app doing this query:
provider {
     activeImageUrl
     # ... additional fields
     uid
     ... on NonPhysicianType {
       firstName
       gender
       lastName
     }
     ... on PhysicianType {
       firstName
       gender
       graduationYear
       lastName
       patientRetention
       # ... additional fields
     }
}

Might very well receive an Hospital object that it now has to handle.

Might very well receive an Hospital object that it now has to handle.

Ok, thank you. It seems like there are two options to maintain the naming convention between the three concrete types:

Modify the query so that the third type is referenced in some manner: ... on FacilityType {
   uid
 }

Map the generated "fallback" class to a local model named "Facility".

Are there any other options you'd recommend?

If you need a Facility class, I'd recommend option 1. as option 2. is taking the risk of another type of object being named Facility in the future which could create some confusion.

@martinbonnin Great, thank you. Your prompt responses to my questions have been appreciated. I hope this thread is helpful to future readers who find themselves with similar questions.
I'll close this thread.

Reader-from-the-future here.
I wasn't searching for fragments, instead I was trying to figure out why Apollo wasn't also generating types that were already there in my schema.

Apollo Android generates models based on the GraphQL queries, and not the schema.

Turns out, it is by design. Alright. I'm not sure how that would have helped my cause but it did feel like a good start.
Anyway, coming to the real problem.
So, I have a mutation that creates a new record of type A and returns the same in its response => I send A, I get back A.
Then, there's another mutation that returns queried records of type A => I send something, I get back A.
The response from either call returns the same thing => A, yet, because of the way Apollo works, the generated class for each response is different => Operation1.Data & Operation2.Data.
Same same but different :(
I want to know how can I avoid this duplication? I'm consuming A in my UI. I can't really afford to have 2 different classes for it, neither do I want to ignore the A returned by Op1 to always run Op2 and get back my newly created A.
I can imagine creating my own class TheOneAndOnlyA and defining mappers to it for either response but that feels like a lot of overhead. Creating my own class also means losing out on server-side guarantees provided by generated code which hand written code may not always have, courtesy lazy dev.


Add "--check" flag to detect stale code

Is your feature request related to a problem? Please describe.
I need some way to check whether the generated code is up-to-date with the source code, so that I can check before every commit with husky and during CI.
Describe the solution you'd like
There could be a --check flag in the CLI that would generate all the code in memory, compare to what's in my working directory and exit with an error if they are different.
Describe alternatives you've considered
None.
Additional context
It would be similar to how prettier --check or prettier --list-different works.

This is so heavily needed. Amazing idea!!!

We are currently doing
npm run codegen
git status --porcelain
git diff-index --quiet HEAD

in gitlab CI to make a pipeline fail if the generated code differs from what was commited.

I see benefit on a check as part of my pre commit hook while in development as well.

@ajotaos we recommend not to commit your generated files. It bloats the git repo with files that would change anyway...

You’re right I misread the issue, I was thinking about checking on the schema.prisma file.

You’re right I misread the issue, I meant that I could check whether the generated files are up to date with my configuration and schema. Like it could try to generate the files and if it succeeds, exits with zero and nothing gets created but if it runs and doesn’t match the in-memory doesn’t the generated file, it exists with non-zero.

At the moment we don't.
You can implement it with a git-hook (using husky or similar tools). And just run codegen and then run git add to the generated files. This way it will make sure you are always committing the updated files.
In most setups, running codegen takes less than a second, so it shouldn't be an overhead for running this during commit or push hooks.

Wouldn’t that end up commuting the generated files to git?

I thought that was your goal, and the author of that issue.
As I said, I don't recommend to commit the generated files, but if you decide to, some actions should be taken to make sure it's always in sync.

I’ll open up another issue, it’s true it’s no the same from the author.

As an alternative, we made a general-purpose CLI which verifies that a command generates a file equivalent to the file on disk: https://github.com/Yolk-HQ/diff-verify-cli
e.g.
$ diff-verify -p ./graphql-types.ts -- node_modules/.bin/graphql-codegen --config codegen.yml

@elliottsj @mkaraula  @gustavopch @ajotaos
Hi all!
Sorry for the delay in handling this feature request.
As part of our work on codegen v3, we started by improving the CLI.
Your feature request is now fulfilled with the --check cli flags as part of the following canary release<EMAIL_ADDRESS>Could you give it a try and let us know? 🙏🏼

The dry-run mode is now available via the --check CLI flag, from<EMAIL_ADDRESS>📦

i tried the --check flag. it doesn't seem to work with afterOneFileWrite hook. 🤔
hooks:
  afterOneFileWrite:
    - prettier --write

Hi @leethree,
This is expected, the --check dry run mode is not writing any file to disk; it just checks if there are any stale files.

@charlypoly understood. thanks!

Sorry my earlier comment wasn't very clear. Our generated files in working directory are formatted with prettier. So they will always be different from the code generated in memory.
Essentially --check will always fail because the files were manipulated with afterOneFileWrite hook even if the files are up-to-date. Is there a way to get around this?

Okay, I get the problem!
I'll look at existing hooks and if needed, add a new one dedicated to the check mode, like "beforeCheck".

@leethree, could you try with the beforeAllFileWrite hook as follows (in addition to your afterOneFileWrite hook):
hooks:
  beforeAllFileWrite:
    - prettier --write
  afterOneFileWrite:
    - prettier --write

@leethree I just tried it and it doesn't seem to work. It still says I have stale files and exits with 1.

After thinking more about it, it makes sense.
I don't see any solution here since we can't apply prettier to files that are not written to disk.
I guess, in the same way, we recommend not committing generated files; prettier should not be run against generated files; otherwise, it makes codegen CLI "file changes" mechanism obsolete (also for the watcher).

@charlypoly yeah that makes sense to me. it would be great to include this caveat in the documentation. https://www.graphql-code-generator.com/docs/integrations/prettier

@leethree, you are right, I've pushed some doc changes: 749fcc064f7770ebfe28bd22b71670e8c563dece
Will be deployed in a few minutes 🕐


Improve the opening hours preset, like in StreetComplete

As iD is a "beginner" OSM editor, I think the opening hours preset is a bit difficult to apprehend. Maybe it could be easier if there was a screen to help ? The StreetComplete quest "What are the opening hours of " is a very good example of easy and complete ux. Screenshots are below.

If it's more complex (ie differs for months) we can specify it :

Thanks everyone for maintaining iD ! :)

Or show UI similar to https://projets.pavie.info/yohours/

@letypequividelespoubelles Thanks, this is #974.


Unnable to invoke function called 'then'

Is there a way to invoke methods called then like in the following example
($.when "foo").then(\x ->
  console.log x
)

I was hoping it would compile to something like
$.when("foo").then(function(x){console.log(x);});

but I get the following error
Error: Parse error on line 2: Unexpected 'THEN'

Fixed in 9fce2052e3badd8747e9df788af38cf8fc3333f7

Awesome thanks!


Support 2022.1

Upgrades to the 2022.1 version of the IntelliJ platform. There are, unfortunately, backwards-incompatible changes to the Markdown API, meaning this version of the plugin won't be compatible with previous versions of the platform.
😅 Having absolutely zero experience with IntelliJ plugins, I have puzzled together my changes based on the changes that were made in commit 31647e1ae9cfb469dbb78f050643ee73a81f5530 of the JetBrain Markdown plugin. There is probably one small change in behavior with respect to the AtxHeaderProvider constructor. The platform API change notes say

AtxHeaderProvider now always requires at least one space between # and its content as specified by the CommonMark spec.

I updated snapshot tests to match new names of AST nodes. (e.g., MarkdownParagraphImpl becomes MarkdownParagraph). No other changes to the AST snapshots were necessary.
Also:

update the Gradle IntelliJ Plugin (org.jetbrains.intellij) to the recommended version 1.5.2
Update the Kotlin support Gradle plugin to version 1.6.10

I have

successfully tested the new version of the Plugin with JetBrains Rider (Build #RD-221.5080.72, built on March 25, 2022)
run the runPluginVerifier task (output included below)

Thank you for maintaining the MDX plugin ❤. It makes writing high-quality documentation with Docusaurus fun 🦕🥳. This PR/a new release of the plugin absolutely not urgent for me. I'm perfectly content using my locally built version of the plugin 😄 (for anyone else reading this: build the project with gradle assemble and install the plugin ZIP from the build/distributions directory)
2022-04-03T18:59:51 [main] INFO  verification - Task check-plugin parameters:
Scheduled verifications (1):
mdx.js:1.0.221 against IU-221.5080.93

2022-04-03T18:59:53 [main] INFO  verification - Finished 1 of 1 verifications (in 1.9 s): IU-221.5080.93 against mdx.js:1.0.221: Compatible. 12 usages of deprecated API
Plugin mdx.js:1.0.221 against IU-221.5080.93: Compatible. 12 usages of deprecated API
Deprecated API usages (12):
    #Deprecated method com.intellij.formatting.FormattingModelBuilder.createModel(PsiElement, CodeStyleSettings) is overridden
        Deprecated method com.intellij.formatting.FormattingModelBuilder.createModel(com.intellij.psi.PsiElement element, com.intellij.psi.codeStyle.CodeStyleSettings settings) : com.intellij.formatting.FormattingModel is overridden in class org.intellij.plugin.mdx.format.MdxFormattingModelBuilder
    #Deprecated field com.intellij.lang.javascript.DialectOptionHolder.JSX access
        Deprecated field com.intellij.lang.javascript.DialectOptionHolder.JSX : com.intellij.lang.javascript.DialectOptionHolder is accessed in org.intellij.plugin.mdx.js.MdxJSLanguage.<init>()
        Deprecated field com.intellij.lang.javascript.DialectOptionHolder.JSX : com.intellij.lang.javascript.DialectOptionHolder is accessed in org.intellij.plugin.mdx.highlighting.MdxEditorHighlighter.<init>(EditorColorsScheme)
    #Deprecated method com.intellij.psi.templateLanguages.TemplateDataElementType.getTemplateDataInsertionTokens() is overridden
        Deprecated method com.intellij.psi.templateLanguages.TemplateDataElementType.getTemplateDataInsertionTokens() : com.intellij.psi.tree.TokenSet is overridden in class org.intellij.plugin.mdx.lang.psi.MdxTemplateDataElementType
    #Deprecated field com.intellij.lang.javascript.JavaScriptSupportLoader.JSX_HARMONY access
        Deprecated field com.intellij.lang.javascript.JavaScriptSupportLoader.JSX_HARMONY : com.intellij.lang.javascript.JSLanguageDialect is accessed in org.intellij.plugin.mdx.js.MdxJSLanguageParser.<init>(PsiBuilder)
        Deprecated field com.intellij.lang.javascript.JavaScriptSupportLoader.JSX_HARMONY : com.intellij.lang.javascript.JSLanguageDialect is accessed in org.intellij.plugin.mdx.js.MdxJSLanguage.<init>()
    #Deprecated method com.intellij.lang.javascript.JSLanguageDialect.createParser(PsiBuilder) is overridden
        Deprecated method com.intellij.lang.javascript.JSLanguageDialect.createParser(com.intellij.lang.PsiBuilder builder) : java.lang.Object is overridden in class org.intellij.plugin.mdx.js.MdxJSLanguage
    #Deprecated method com.intellij.formatting.FormattingModelBuilder.createModel(PsiElement, CodeStyleSettings, FormattingMode) is overridden
        Deprecated method com.intellij.formatting.FormattingModelBuilder.createModel(com.intellij.psi.PsiElement element, com.intellij.psi.codeStyle.CodeStyleSettings settings, com.intellij.formatting.FormattingMode mode) : com.intellij.formatting.FormattingModel is overridden in class org.intellij.plugin.mdx.format.MdxJsFormattingModelBuilder
    #Deprecated method com.intellij.lang.javascript.JSLanguageDialect.getFileExtension() is overridden
        Deprecated method com.intellij.lang.javascript.JSLanguageDialect.getFileExtension() : java.lang.String is overridden in class org.intellij.plugin.mdx.js.MdxJSLanguage
    #Deprecated method com.intellij.lang.javascript.frameworks.modules.JSBaseModuleReferenceContributor.isSoft(PsiElement, String, boolean) invocation
        Deprecated method com.intellij.lang.javascript.frameworks.modules.JSBaseModuleReferenceContributor.isSoft(com.intellij.psi.PsiElement host, java.lang.String modulePath, boolean isCommonJS) : boolean is invoked in org.intellij.plugin.mdx.js.MdxModuleReferenceContributor.getReferences(String, PsiElement, int, PsiReferenceProvider, boolean) : FileReference[]
    #Deprecated class com.intellij.psi.impl.source.tree.injected.InjectedLanguageUtil reference
        Deprecated class com.intellij.psi.impl.source.tree.injected.InjectedLanguageUtil is referenced in org.intellij.plugin.mdx.js.MdxTagNameSynchronizer.TagNameSynchronizer.findSupport(RangeMarker, PsiFile, Document) : RangeMarker
    #Deprecated method com.intellij.formatting.FormattingModelBuilder.createModel(PsiElement, CodeStyleSettings) invocation
        Deprecated method com.intellij.formatting.FormattingModelBuilder.createModel(com.intellij.psi.PsiElement element, com.intellij.psi.codeStyle.CodeStyleSettings settings) : com.intellij.formatting.FormattingModel is invoked in org.intellij.plugin.mdx.format.MdxFormattingModelBuilder.createModel(PsiElement, CodeStyleSettings) : FormattingModel
    Plugin can be loaded/unloaded without IDE restart

2022-04-03T18:59:53 [main] INFO  verification - Total time spent downloading plugins and their dependencies: 0 ms
2022-04-03T18:59:53 [main] INFO  verification - Total amount of plugins and dependencies downloaded: 0 B
2022-04-03T18:59:53 [main] INFO  verification - Total amount of space used for plugins and dependencies: 339.42 KB

Thank you for the contribution! I will check and publish the plugin ASAP.


error when run ds_generator

7 ...
Enter simple dce...
8 ...
-I/usr/local/lib/gcc/x86_64-unknown-linux-gnu/4.9.4/include/
mv ./__merlinkernel_gemm.c merlinkernel_gemm.c
ds_generator: Cxx_GrammarNewConstructors.C:16298: SgValueExp::SgValueExp(): Assertion `isSgValueExp(this) != __null' failed.
Aborted (core dumped)

It's hard to find the problem without seeing the source code and the complete log files, but if you installed Merlin from Xilinx repo, be sure to use its compatible ds_generator.


Android 10( some of devices) and 11 app getting crash not working camera , after changing android targetSdkVersion 28 to 29

Bug Report
Problem
What is expected to happen?
What does actually happen?
Information

Command or Code

Environment, Platform, Device

Version information

Checklist

[x] I searched for existing GitHub issues
[x] I updated all Cordova tooling to most recent version
[x] I included all the necessary information above

I'll try to add a little bit more information for this tickets based on observations from our users. Some of the devices have "Access denied" error when image is saved. We still cannot identify which devices are affected and which not but this is a blocker issue which affects very badly our users.

Thanks a lot for your issue, however the issue template exists for a reason. 😊
It helps us to debug the issue further and to provide a solution much faster. With important information missing, we unfortunately can't help you.
Therefore, please edit this issue accordingly or close and create a new one and make sure to provide all the required information.


Possible typo in documentation

Issue in ./help/tags/ui/managing-resources/data-elements.md
If you use a data collector object as party of your data layer
I assume it's a typo and party should be part

Thank you for submitting this issue. We will review the documentation and make the necessary updates as quickly as possible. Tracking internally in PLAT-165832.

We've updated the documentation to remove the typo. Closing this issue.


Source/add google ads

Created a branch from add_google_ads.
Merged master into it
Commented out tests

Needs the readme


Update Composer dependencies (2021-12-06-00-12)

Visual regression test passed!
View the visual regression test report


loops problem

What problem are you facing?
I'm experimenting with crossplane and function-kcl, creating an composition with multiple resources the same type, I'm obtaining this error.
How can we reproduce it?
I am using function-kcl:v0.10.8
with a simple composition:
apiVersion: apiextensions.crossplane.io/v1
kind: Composition
metadata:
  name: multiazwordpressinfra-composition
spec:
  compositeTypeRef:
    apiVersion: segoja7.example/v1alpha1
    kind: MultiAzWordpressInfra
  mode: Pipeline
  pipeline:
  - step: normal
    functionRef:
      name: function-kcl
    input:
      apiVersion: krm.kcl.dev/v1alpha1
      kind: KCLRun
      metadata:
        name: basic
      spec:
        target: Resources
        source: |
          projectName = option("params")?.oxr?.spec.parameters.projectName or "nodefined"
          vpccidrBlock = option("params")?.oxr?.spec.parameters.vpccidrBlock or "<IP_ADDRESS>/16"
          count = 2
          region = option("params")?.oxr?.spec.region or "us-east-1"
          providerConfigName = option("params")?.oxr?.spec?.providerConfigName or "segoja7"

          vpc = [{
              apiVersion = "ec2.aws.upbound.io/v1beta1"
              kind = "VPC"
              metadata.name = "vpc"
              spec.forProvider = {
                  region = region
                  cidrBlock = vpccidrBlock
                  enableDnsSupport = True
                  enableDnsHostnames = True
                  tags = {
                    "app" = "wordpress"
                    "Name" = metadata.name+"-"+projectName
                  }
              }
              spec.providerConfigRef.name = providerConfigName
          } for i in range(count)]

The error is the following:
Message:               cannot compose resources: pipeline step "normal" returned a f ││ atal result: failed to run kcl function pipelines: wrong node kind: expected MappingNode ││  but got SequenceNode: node contents:

Hi @Peefy thanks.
This is m firsts steps with crossplane and kcl, I have a doubt with this part.
        name: basic
      spec:
        target: Resources #Do you remove this line for something in special?

thanks for the support


match via call

Match via String.prototype.match.call for wider support

before this change the error for null would be

TypeError: set.match is not a function

after this change it becomes

TypeError: String.prototype.match called on null or undefined


Renaming the Brand - Ideas and thoughts

When we started the brand of SQL Saturday, the idea was to not intrude on business days and ensure the event was open to all, as most organizations do not require work on Saturdays, There have been events on most days of the week, though some people have found an issue with the name.

Should we rename the brand to not link this to Saturday.
Suggestions?

Data Days
Data Inspiration
??

Isn't this a duplicate of #11?

Branding is expensive. New signs will not be affordable for many events.

I bought dataplatformdays.org for these reasons

the data platform is more than SQL, and more than MS
avoiding trademark issues with xxSaturday
community org, not really owned by anyone

That being said, I'm open to anything. I do think a brand matters, and while I hate to ask people to spend $$$ on new signs, shirts, etc., I am not hopeful that SQL Saturday can be purchased and kept going by 1 Feb 2021. If it cannot, then events may as well start moving to something new. Hence, I opened this issue.

It may be possible to get some support from a vendor or offer a sponsorship for signs, so the cost might not be a big issue. I suspect some generosity on this point from vendors.

Data Days is a name we've been discussing in Norway as both an option for opening up more on the weekday the event is held, as well as opening up for those who want to branch out a bit more. I fully agree that a lot of us branch out into more than just MS and more than just SQL these days, and this is more sensible. As for signs and stickers and other branding, as long as we're not enforcing branding like PASS tried to, does it really matter?

I honestly think that if this site is DataSaturday, but event 1045 is a redirect to DataDays.org in Norway, that's fine. I think multiple brands for an event can help it grow, and help different audiences find it. SQL Sat Cambridge was combined with SharepointSat Cambridge, and they jointly managed a schedule and marketed separately.
I think doing the same here is great.

Using SQL in the name closes many of the options to bring in new technology, in speakers, attendees and sponsors.  I like the idea of focusing the branding on data instead of SQL.

I slightly disagree with Kellyn. Most attendees, sponsors, speakers recognize that SQL in a SQL Saturday is just part of the brand. As an example, our SQLSatLA event had sessions on NoSQL, sharepoint, and excel. SQLSatLA event is not the only event with not SQL related sessions. That being said, if SQL Saturday brand could not be regained, Data is the way to go. BTW, http://datasaturday.com is owned by C&C.

Most regular attendees, sponsors and speakers recognize SQLSaturday is a brand. But branching out to new tech, sponsors and audiences who don't recognize the SQLSaturday brand is just as important. The regulars will understand, and the new ones will get onboard easier if we're not limiting to SQL

I’ll make a suggestion of Data Community Days (datacommunitydays.com and .org)

I think the shortlist of ideas is:

Use xxx saturday.com (or multiple domains pointing to the same place) as a recognized brand
use something else that is more inclusive.

Likely we need to come up with some voting mechanisms. Datacommunitydays.org and com are taken.

I registered the datacommunitydays domains. Happy to have over after any voting.

My five cents: Sql Saturday is likely not an option. If it is sold to commercial actor we don’t want a name that is too close. I thought of sqlfamily with sub domain for events. But that domain was registered 3 days ago it seems. By Contact Privacy Inc in Canada.

dataplatformdays.org is off the table. The Data Platform Geeks use this for free events, so I will be gifting them the domain.
I do like datacommunitydays as a general, not RDBMS focused name

I'm in strong favor of dropping "Saturday" from the branding.

It creates brand confusion when xxxSaturday events are held on Friday for cultural/scheduling reasons.
For locations & communities where Saturday is Sabbat or otherwise an impossible/impractical day of the week, it will create a distinct sense of otherness for organizers & attendees.
There is already a history of international SQLSaturday events needing to be held on a different day, and this is our chance to "fix" the othering.
DataSaturday.com is owned by C&C according to domain registration info. If they choose to launch or include this domain in the SQLSaturday sale, it may lead to brand confusion or copyright issues.

Some variation on "Data Day" gives the alliterative vibe which can be the hat tip to the alliterative SQL Saturday, while also being more inclusive.
Brainstorming

The plain "Data Day" is already in use by the broader Data community

"Data Platform Day" or "Data Platform Days" is already used by the Data Platform Geeks

"Data Community Day" or "Data Community Days" is available and @datahai owns the DataCommunityDays.com domain

Look for available domains & brands that use "Day----" or "----day" compound words.

DataDaylight (.com is taken but unused. Other TLDs available)
DataEveryday  (.com is taken but unused. Other TLDs available)
DataMayday  (.com is taken but unused. Other TLDs available)

Look for available domains & brands that use data puns, or data keywords.

Datapoint Conference (DataPointConf.com & other domains available
Table Value conference (a bad pun on the value of data, and TVFs)

Consider .global, .pro, .tech, .community, .training TLDs in addition to a traditional .org or .com

Added a discussion for this - https://github.com/sqlcollaborative/DataSaturdays/discussions/113
Closing this as it isn't an issue

Added a discussion for this - https://github.com/sqlcollaborative/DataSaturdays/discussions/113
Closing this as it isn't an issue


Define own templates

Hey,
Thanks for creating this awesome project! I just integrated it into our development environment for generating the types our WebApi exposed for our Typescript project. It was exactly was I was looking for!
I am currently generating only types, not xhr class definitions because we use a framework (Aurelia) for our Typescript project and do not use jquery. Also, we would like some other code bits injected in our xhr's (for example for file upload progress etc).
I dug into your source code and noticed you use template files to generate the code (you currently use it to differentiate between Callbacks and Q). Would it be possible to add a method for us to allow us to use our own custom template file?
It's not a "must" in our current sprint so I don't have time to impelment it myself. If you don't have time, I might implement this in the future if we would require the functionality. However, I think this might be usefull for many others using NSwag to be able to define how they would like thier xhr request code to be generated (especially if you don't want to use the default jquery interface, or for people who would like to use the new fetch api instead of xhr).
Regards,
Maarten

Of course, you can create a pull request with a new template for Aurelia... My next template will be for Angular 1.x... I do not know how Aurelia handles HTTP but writing a new template should be pretty simple...

I think we're going to do that in the future. I'll have to discuss it with my team first how we are going to approach this, but if it comes to it ill make a pull request for it.

So, you need an option to generate this?
export enum WebcamImageOrientation
{
	Default = 0,
	Rotate90 = 1,
	Rotate180 = 2,
	Rotate270 = 3,
}

E.g. EnumAsInteger

Yes, exactly.
I believe, if i understand the typescript documents correctly (we've only just begun using typescript in our project so its still a learning curve for us). if you omet the "=0, =1" etc, typescript will auto-generate the numbers for you in sequence starting with 0.

Correct, but the numbers may not be in order so we should generate them...

(ah, this is the wrong issue for discussing this)

XD

Btw: I just created the angular template draft im 1 hour...

Yes i saw, very nice. As soon as we have defined the way we want to work with http-requests in aurelia, I will add a template for that aswell.

Are you still interested in an Aurelia template?

We're still using NSwag, but at the moment only for interface generation. I think you can close this issue for now. If we ever decide we are going to use automatic method generation I will create a PR with the template.

What do you think? https://github.com/NJsonSchema/NJsonSchema/issues/119

Btw. there is now a window.fetch template whose client can  be easily injected into aurelia view models... (im using it for an aurelia project right now). For me the aurelia scenario is covered.
Please create specific issues if required...

Just FYI: Now Aurelia has its own template, uses the injected HttpClient:
https://github.com/NSwag/NSwag/commit/5f89cd4149a2fa73f7cf2f3f31b9affa49cacb53


Fix import logic

Fix https://github.com/streamlit/streamlit/actions/runs/5940633711/job/16115470908?pr=7193#step:18:2855

Ah, sorry, I think this was something else. I should've been keeping a closer eye on the CI there—thanks for raising. I think this commit should fix

Yup, awesome :)
Also need the mypy ignore in the other PR.


HHH-16085 Test using @JdbcTypeCode(Types.VARBINARY) on arrays to revert to pre-6.1 behavior

https://hibernate.atlassian.net/browse/HHH-16085

Thanks man, much appreciated.

The failure looks unrelated:
Build / s390x_h2 / Test / testSessionFactorySetting – org.hibernate.orm.test.jdbc.internal.SessionJdbcBatchTest

Thanks!


Order files

#ISSUE-NO #256
What does this PR do?
Organize folders as agreed.
Description of Task to be completed?
None
How can this be manually tested?
Local host.
Any background context you want to provide?
None
What is the relevant issue link?
#256
Screenshots (if appropriate)
Questions:
Are we comfortable with this structure?

Oh, I shouldn't have merged it yet.
I'm sorry for not waiting for others reviews.
Also, I just noticed you didn't follow exactly the structure provided by @schmelto
But @schmelto and everyone is this new structure okay?
Once again, I'm sorry for merging it without thoroughly checking

Oh, I shouldn't have merged it yet.
I'm sorry for not waiting for others reviews.
Also, I just noticed you didn't follow exactly the structure provided by @schmelto
But @schmelto and everyone is this new structure okay?
Once again, I'm sorry for merging it without thoroughly checking

It's alright Jome. We can still update it accordingly. @schmelto and @namangupta1399 what do you think, is this structure okay?

I think what @schmelto  meant was moving the index.html in the src folder. Then changing gh-pages settings to use src folder for deployment of the website.
Like this

src

index.html
assets

img1.png
img2.png

js

script.js

css

style.css

Is this fine, @schmelto ?

I think what @schmelto  meant was moving the index.html in the src folder. Then changing gh-pages settings to use src folder for deployment of the website.
Like this

src

index.html
assets

img1.png
img2.png

js

script.js

css

style.css

Is this fine, @schmelto ?

Yes

@Evavic44 i suggest using closes #issuenumber in the pr description thus it link the issue better to the pr

Yeah, truly said.

@Evavic44 i suggest using closes #issuenumber in the pr description thus it link the issue better to the pr

Yeah, I didn't know it wasn't added. Will fix that.

I think what @schmelto meant was moving the index.html in the src folder. Then changing gh-pages settings to use src folder for deployment of the website.
Like this
* src

  * index.html
  * assets

    * img1.png
    * img2.png
  * js

    * script.js
  * css

    * style.css

Is this fine, @schmelto ?

Okay, now I understand. Will fix that ASAP


OSM Buildings loads two ，The second stretching deformation has shadows

What happened?
OSM Buildings loads two ，The second stretching deformation has shadows。
cesium version 1.115.0
Reproduction steps

Sandcastle example
No response
Environment
Browser:
CesiumJS Version:1.115.0
Operating System:

viewer.scene.primitives.add(await Cesium.createOsmBuildingsAsync({
enableShowOutline: false,
}))
second osm Add enableShowOutline: false,


chore: use node-fetch instead of got

closes #35

Can you review this, @Hazmi35?

@Hazmi35 updated; can you review again? 🙂

@Hazmi35 updated; can you review again? 🙂

Looks good, thanks for this change, sorry if I bother you because I didn't make the PR myself because I was late


python 3.8.0 AttributeError: module 'cgi' has no attribute 'escape'

   pisaStatus = pisa.CreatePDF(html, dest=file)   File "/Users/disonds/PycharmProjects/PythonHomework/venv/lib/python3.8/site-packages/xhtml2pdf/document.py", line 136, in pisaDocument     doc.build(context.story)   File "/Users/disonds/PycharmProjects/PythonHomework/venv/lib/python3.8/site-packages/reportlab/platypus/doctemplate.py", line 1056, in build     self.handle_flowable(flowables)   File "/Users/disonds/PycharmProjects/PythonHomework/venv/lib/python3.8/site-packages/reportlab/platypus/doctemplate.py", line 915, in handle_flowable     self.afterFlowable(f)   File "/Users/disonds/PycharmProjects/PythonHomework/venv/lib/python3.8/site-packages/xhtml2pdf/xhtml2pdf_reportlab.py", line 122, in afterFlowable     cgi.escape(copy.deepcopy(flowable.text), 1), AttributeError: module 'cgi' has no attribute 'escape'
update pip please

I can see it was fixed with #443. Could you please make a release?

How long do things like these usually take?

Any update on this?


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.17.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix!: emit event with blob sizes

Closes https://github.com/celestiaorg/celestia-app/issues/1271

Codecov Report

Merging #1354 (e374cfe) into main (990c720) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main    #1354   +/-   ##
=======================================
  Coverage   48.31%   48.31%
=======================================
  Files          79       79
  Lines        4425     4425
=======================================
  Hits         2138     2138
  Misses       2107     2107
  Partials      180      180

Impacted Files
Coverage Δ

x/blob/types/events.go
0.00% <0.00%> (ø)

x/blob/keeper/keeper.go
82.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


xcp: 0.21.3 -> 0.22.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Pinging @legendofmiracles as you're the maintainer

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 355776

x86_64-linux

:white_check_mark: 1 package built:

xcp

The maintainers section mentions @lom


Add Sakoe Chiba constraint to SoftDTW

Currently, it seems there is no way to add a Sakoe Chiba constraint to the SoftDTW functions.
This would be really convenient as it would speed up the already slow code a bit.

Hi @p3trus
This is a good idea indeed. Though, I am not sure when this can be implemented.


error when connect to sharepoint list

Hi team, could you help to solve the error when I tried to connect to sharepoint list by following the guidance? The error popped up after step 6 on part1, and it said that "Access to the resources is forbidden." Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d57e8911-0181-d93e-4bd6-ebb6b86324c9
Version Independent ID: 2cce7962-5ee9-5f67-af93-2c67bb10911f
Content: Create a report on a SharePoint List - Power BI
Content Source: powerbi-docs/desktop-sharepoint-online-list.md
Service: powerbi
Sub-service: powerbi-desktop
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Hi @Jessicaoo - I couldn't reproduce your experience and believe it's a permissions issue to the resource. I'm adding the author to take a look and verify. You may want to try asking the community here: https://community.powerbi.com/

Hi,Kate,
Thanks for replying. The list is based on a folder I created under Teams. It’s a private one. Is it the matter that making connection failed? How can I solve this? Thanks for help.
Regards
Jessica
发自我的iPhone
在 2020年4月3日，07:04，Kate Follis<EMAIL_ADDRESS>写道：

Hi @Jessicaoohttps://github.com/Jessicaoo - I couldn't reproduce your experience and believe it's a permissions issue to the resource. I'm adding the author to take a look and verify. You may want to try asking the community here: https://community.powerbi.com/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/powerbi-docs/issues/2012#issuecomment-608136191, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMGQ4NFBJEP2RENGATBSGUTRKUKWPANCNFSM4L2ECU4A.

Hi
I have the same issue. "Details: "Access to the resource is forbidden.".
The first time I tried to Connect to Sharepoint folder. I entered the URL code for specific the sharepoint site.
The next window was Share point access screen. Here I chose Windows. And then it denied after click on Connect.
Now I will tried again and use Microsoft Account. After enter URL code again. It just write "Access to the resource is forbidden.".
The Share Point Access screen doesn't appear so I can change my choice.
Some who can help ?

@jessicaoo

Hi @kfollis.
Out from my describtion. Do you have any idea how to get the Share Point Access screen visible again.

I found a similar question in the Power BI Community - it's a great resource! Does this https://community.powerbi.com/t5/Desktop/Access-Forbidden-connecting-to-SharePoint-Online-List/m-p/604255#M287613 thread help to resolve the problem?

Hi  @kfollis
Many thank you for your guide.
It was just the issue.
I have been sought  and sought and did never come to this post in the community.
I'am curious which search text you wrote.
Can you remember that ?

I'm pretty sure my search criteria was "SharePoint access forbidden" - I'm very happy that the post helped with your issue!


FLINK-7368: MetricStore makes cpu spin at 100%

Flink's MetricStore is not thread-safe. multi-treads may acess java' hashmap inside MetricStore and can tirgger hashmap's infinte loop.
Recently I met the case that flink jobmanager consumed 100% cpu. A part of stacktrace is shown below. The full jstack is in the attachment.
{code:java}
"ForkJoinPool-1-worker-19" daemon prio=10 tid=0x00007fbdacac9800 nid=0x64c1 runnable [0x00007fbd7d1c2000]
java.lang.Thread.State: RUNNABLE
at java.util.HashMap.put(HashMap.java:494)
at org.apache.flink.runtime.webmonitor.metrics.MetricStore.addMetric(MetricStore.java:176)
at org.apache.flink.runtime.webmonitor.metrics.MetricStore.add(MetricStore.java:121)
at org.apache.flink.runtime.webmonitor.metrics.MetricFetcher.addMetrics(MetricFetcher.java:198)
at org.apache.flink.runtime.webmonitor.metrics.MetricFetcher.access$500(MetricFetcher.java:58)
at org.apache.flink.runtime.webmonitor.metrics.MetricFetcher$4.onSuccess(MetricFetcher.java:188)
at akka.dispatch.OnSuccess.internal(Future.scala:212)
at akka.dispatch.japi$CallbackBridge.apply(Future.scala:175)
at akka.dispatch.japi$CallbackBridge.apply(Future.scala:172)
at scala.PartialFunction$class.applyOrElse(PartialFunction.scala:123)
at scala.runtime.AbstractPartialFunction.applyOrElse(AbstractPartialFunction.scala:28)
at scala.concurrent.Future$$anonfun$onSuccess$1.apply(Future.scala:117)
at scala.concurrent.Future$$anonfun$onSuccess$1.apply(Future.scala:115)
at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:32)
at java.util.concurrent.ForkJoinTask$AdaptedRunnable.exec(ForkJoinTask.java:1265)
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:334)
at java.util.concurrent.ForkJoinWorkerThread.execTask(ForkJoinWorkerThread.java:604)
at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:784)
at java.util.concurrent.ForkJoinPool.work(ForkJoinPool.java:646)
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:398)
{code}
There are 24 threads show same stacktrace as above to indicate they are spining at HashMap.put(HashMap.java:494) (I am using Java 1.7.0_6). Many posts indicate multi-threads accessing hashmap cause this problem and I reproduce the case as well. Even through MetricFetcher has a 10 seconds minimum inteverl between each metrics qurey, it still cannot guarntee query responses do not acess MtricStore's hashmap concurrently.

The problem is that the MetricFetcher isn't synchronizing on the MetricStore´ object in MetricFetcher#addMetrics()` as it should.

@zentol Thanks for replying. Indeed, the problem is caused by MetricFetcher isn't synchronizing on the MetricStore object in MetricFetcher#addMetrics(). But in my opinion, synchronizing on the MetricStore  is less efficient. MetricStore wrapps more than one metric stores and they serves different components(e.g Jobmanager，Taskmangers)  individually. If synchronizing on the MetricStore , call of addMetrics() on Jobmanger's metric may wait for addMetrics() on another taskmananger's metric done as they both acquire the same lock, which is unnecessary.

I do see the benefit of a more fine-grained synchronization. What I dislike about using plain ConcurrentHashMaps everywhere is that accesses to the metrics 99% of the time are done in batches, and I don't really want to pay the synchronization cost every time.
That said, the whole "you have to synchronize manually" is a rather big source of bugs so we may just have to bite the bullet.


fuse: bind connections into mount pod

to support fuse abort in container

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.18% :tada:

Comparison is base (bab665a) 38.12% compared to head (d7a853a) 38.30%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   38.12%   38.30%   +0.18%
==========================================
  Files          33       33
  Lines        4092     4104      +12
==========================================
+ Hits         1560     1572      +12
  Misses       2385     2385
  Partials      147      147

Files Changed
Coverage Δ

pkg/config/config.go
0.00% <ø> (ø)

pkg/juicefs/mount/builder/common.go
50.23% <100.00%> (+2.97%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


hetzner-kube: support for bash completion

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Fails on darwin:
installing
2020/11/23 22:03:29 open /Users/user/.hetzner-kube/config.json: no such file or directory

Result of nixpkgs-review pr 103665 run on x86_64-linux 1

1 package built:

hetzner-kube

Fails on darwin:
installing
2020/11/23 22:03:29 open /Users/user/.hetzner-kube/config.json: no such file or directory

That's a usage error, not our fault.

Thanks for running nixpkgs-review on this.


Update all dependencies to latest version

PR updates all dependencies to their latest version.
Tests are passing.

Ah shoot, for some reason I thought CI had run on this, but it has a rustfmt bug.


Downgrade platform requirements

note: I haven't tried macOS yet

Hi @aehlke!
Thank you for using our framework and contributing to it.
Related with downgrading to iOS15, there are issues with that when working with BarButtonStyle styles (is not showing the navBar).
So we won't update the framework with this PR.

Hi @mlorenze your library works just fine on iOS 15 with the segmented style, which is the only way I use your lib. So I'd like to be able to continue to use the bar styles that do work on iOS 15. I noticed that your iOS 16 requirements were isolated to specific bar styles rather than various features scattered throughout, so I saw an opportunity to allow per style OS compatibility. Thanks.


generic-armel-iproc: remove local workaround for GO linuxloader

Now that upstream has backported the fix for kirkstone [1], we can drop our local workaround for the issue.
This reverts commit 622ae9b19c47a47f18b8f90ea2ee3321476cceea.
[1] https://github.com/openembedded/openembedded-core/commit/c7426629245db2ea8d9f3cf25b575ac31b5a83b0

This doesn't break anything, it just hardcodes the value to the expected one, so merging this isn't critical for the release.


clean matlab folder

Trying to address issue #112 about organizing the matlab code folder

moved files into sub-folders as suggested in the issue
change scripts so they still run
run scripts
update the content of the template folder with the output

One question: I did put the script to create the JSON for fmap into the func folder. Does that make sense or should we have into a specific fmap folder?

@dorahermes I can't assign reviewers but I suspect you would be the likely one to look into this. :-)

Thanks @Remi-Gau ! It seems that fmap has a different folder in all scenarios here so I believe that is the only correction

Thanks @Remi-Gau ! It seems that fmap has a different folder in all scenarios here so I believe that is the only correction

Yup that's what I thought after the fact but just wanted to make sure we agreed on this. :-)

lgtm :-)

resolved issue #112 Cleaning up the Matlab code


Add common tags for crafting recipes/mechanics/blocks

I'm currently running into a problem where there is very little compat between mods in crafting recipes so I'm requesting devs to make more use of the common tags found here: https://fabricmc.net/wiki/tutorial:tags
In the case of BetterEnd I've come across a few different cases:

the wooden chests don't use the c:wooden_chests tag
the wooden barrels don't use the c:wooden_barrels tag (or the c:barrel tag)
the workbenches don't have the c:workbench tag

That's all I've come across so far. Thanks in advance.

c:saplings and is missing as well, as is c:leaves, which while not listed on the site Kukelekuuk linked to, is apparently used by Promenade, Tech Reborn, Charm, Woods and Mires, Blockus, and Traverse.


Type hints introduced a bug in build_indexes

This commit: 695f9368362bb13dae00a7119d8265ad7c41f5af introduced some bug in when building indexes:
$ git checkout a2897d2
(Note: a2897d2 is the commit just before the bug)

$ pypy3 build_indexes.py corpora/bnc-01M --clean -c -f lemma pos --max-dist 1

$ pypy3 search_corpus.py --debug corpora/bnc-01M '[lemma="the"] [pos="ADJ"] [pos="SUBST"] [lemma="be"]'
    0.04 s |    Index:lemma0-pos1 = the ADJ --> 9486
    0.05 s |    Index:pos0-pos1 = ADJ SUBST --> 26297
    0.05 s |    Index:pos0-lemma1 = SUBST be --> 8191

$ git checkout 695f936
(Note: the problematic commit)

$ pypy3 search_corpus.py --debug corpora/bnc-01M '[lemma="the"] [pos="ADJ"] [pos="SUBST"] [lemma="be"]'
    0.04 s |    Index:lemma0-pos1 = the ADJ --> 9486
    0.05 s |    Index:pos0-pos1 = ADJ SUBST --> 26297
    0.05 s |    Index:pos0-lemma1 = SUBST be --> 8191
(Note: nothing changes in the search, so that's not where the problem is)

$ pypy3 build_indexes.py corpora/bnc-01M --clean -c -f lemma pos --max-dist 1

$ pypy3 search_corpus.py --debug corpora/bnc-01M '[lemma="the"] [pos="ADJ"] [pos="SUBST"] [lemma="be"]'
    0.02 s |    Index:lemma0-pos1 = b'the' b'ADJ' --> 9425
    0.03 s |    Index:pos0-pos1 = b'ADJ' b'SUBST' --> 26109
    0.03 s |    Index:pos0-lemma1 = b'SUBST' b'be' --> 8130

Note that the sizes of the result sets are smaller! So build_indexes must have done something wrong here.

Here's debugging info when building the indexes.
The corpus index seems to be the same, but the search indexes have problems. Before the bug:
    0.11 min |  --> created instance database, 825403 rows, 30953 instances, 48438 sentences
    0.13 min | Built index for Index:lemma0, with 30953 keys, 856357 set elements

compared to after the bug was introduced:
    0.27 min |  --> created instance database, 820457 rows, 30897 instances, 48127 sentences
    0.29 min | Built index for Index:lemma0, with 30897 keys, 851355 set elements

Here's the full trace.
Before the bug (commit a2897d2):
$ pypy3 build_indexes.py corpora/bnc-01M --clean -c -f lemma pos --max-dist 1 --debug
    0.00 min | Removed all indexes
    0.00 min | Building corpus index...
    0.01 min |  --> read 76255 distinct strings
    0.04 min | Built corpus index, 951538 words, 48438 sentences
    0.04 min | Created the corpus index
    0.04 min | Building index for Index:lemma0...
    0.11 min |  --> created instance database, 825403 rows, 30953 instances, 48438 sentences
    0.13 min | Built index for Index:lemma0, with 30953 keys, 856357 set elements
    0.13 min | Building index for Index:pos0...
    0.16 min |  --> created instance database, 385582 rows, 15 instances, 48438 sentences
    0.17 min | Built index for Index:pos0, with 15 keys, 385598 set elements
    0.17 min | Building index for Index:lemma0-lemma1...
    0.27 min |  --> created instance database, 891545 rows, 280779 instances, 48438 sentences
    0.37 min | Built index for Index:lemma0-lemma1, with 280779 keys, 1172325 set elements
    0.37 min | Building index for Index:lemma0-pos1...
    0.46 min |  --> created instance database, 846354 rows, 77496 instances, 48438 sentences
    0.49 min | Built index for Index:lemma0-pos1, with 77496 keys, 923851 set elements
    0.49 min | Building index for Index:pos0-lemma1...
    0.58 min |  --> created instance database, 850365 rows, 78668 instances, 48438 sentences
    0.61 min | Built index for Index:pos0-lemma1, with 78668 keys, 929034 set elements
    0.61 min | Building index for Index:pos0-pos1...
    0.66 min |  --> created instance database, 675555 rows, 202 instances, 48438 sentences
    0.67 min | Built index for Index:pos0-pos1, with 202 keys, 675758 set elements
    0.67 min | Created 6 query indexes

After the bug (commit 695f936):
$ pypy3 build_indexes.py corpora/bnc-01M --clean -c -f lemma pos --max-dist 1 --debug
    0.00 min | Removed all indexes
    0.00 min | Building corpus index...
    0.01 min |  --> read 76255 distinct strings
    0.21 min | Built corpus index, 951538 words, 48438 sentences
    0.21 min | Created the corpus index
    0.21 min | Building index for Index:lemma0...
    0.27 min |  --> created instance database, 820457 rows, 30897 instances, 48127 sentences
    0.29 min | Built index for Index:lemma0, with 30897 keys, 851355 set elements
    0.29 min | Building index for Index:pos0...
    0.33 min |  --> created instance database, 383108 rows, 15 instances, 48127 sentences
    0.34 min | Built index for Index:pos0, with 15 keys, 383124 set elements
    0.34 min | Building index for Index:lemma0-lemma1...
    0.43 min |  --> created instance database, 886341 rows, 279590 instances, 48127 sentences
    0.51 min | Built index for Index:lemma0-lemma1, with 279590 keys, 1165932 set elements
    0.51 min | Building index for Index:lemma0-pos1...
    0.58 min |  --> created instance database, 841361 rows, 77297 instances, 48127 sentences
    0.62 min | Built index for Index:lemma0-pos1, with 77297 keys, 918659 set elements
    0.62 min | Building index for Index:pos0-lemma1...
    0.69 min |  --> created instance database, 845328 rows, 78484 instances, 48127 sentences
    0.73 min | Built index for Index:pos0-lemma1, with 78484 keys, 923813 set elements
    0.73 min | Building index for Index:pos0-pos1...
    0.78 min |  --> created instance database, 671392 rows, 202 instances, 48127 sentences
    0.80 min | Built index for Index:pos0-pos1, with 202 keys, 671595 set elements
    0.80 min | Created 6 query indexes

The problem seems to be when building the corpus index and the search indexes at the same time:
$ pypy3 build_indexes.py corpora/bnc-01M --debug -c -t pos.0
    0.04 min | Built corpus index, 951538 words, 48438 sentences
    0.08 min | Built index for Index:pos0, with 15 keys, 383124 set elements

383124 is too low.
But, if we now build the search index, we get the correct size (355598):
$ pypy3 build_indexes.py corpora/bnc-01M --debug -t pos.0
    0.04 min | Built index for Index:pos0, with 15 keys, 385598 set elements

Also if we build the corpus first and the the search index:
$ pypy3 build_indexes.py corpora/bnc-01M --debug -c
    0.04 min | Built corpus index, 951538 words, 48438 sentences
$ pypy3 build_indexes.py corpora/bnc-01M --debug -t pos.0
    0.04 min | Built index for Index:pos0, with 15 keys, 385598 set elements


Suggest to set basic read and write timeout on http.Server

https://github.com/apache/kvrocks-controller/blob/f3a58b9bb7b26d8137454ffff7b2b1496c81e3b5/server/server.go#L94C1-L97C3

close it, no need to set.


Fix documentation typo for download_all_artifacts

Please revise squash the commit and fix the message. My bad

Please revise squash the commit and fix the message. My bad