Add script to build XCFramework

We don't have to assemble our own Fat binaries anymore using lipo.
Fixed a newline warning also.

Cool. Will look at this tomorrow.


Calling Formula.sha1 is deprecated!

this is broken in homebrew
Warning: You are using OS X 10.12.
We do not provide support for this pre-release version.
You may encounter build failures or other breakages.
Please create pull-requests instead of filing issues.

Warning: Calling Formula.sha1 is deprecated!
Use Formula.sha256 instead.
/usr/local/Library/Taps/michaeldfallen/homebrew-formula/git-radar.rb:7:in `<class:GitRadar>'
Please report this to the michaeldfallen/formula tap!

Warning: Calling SoftwareSpec#sha1 is deprecated!
Use SoftwareSpec#sha256 instead.
/usr/local/Library/Taps/michaeldfallen/homebrew-formula/git-radar.rb:7:in `<class:GitRadar>'
Please report this to the michaeldfallen/formula tap!

Warning: Calling Resource#sha1 is deprecated!
Use Resource#sha256 instead.
/usr/local/Library/Taps/michaeldfallen/homebrew-formula/git-radar.rb:7:in `<class:GitRadar>'
Please report this to the michaeldfallen/formula tap!

Also on my machine.
$ brew config
HOMEBREW_VERSION: 0.9.9
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 604f4b6a0785e0295e548e6d033823303da19061
Last commit: 5 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: dbea1f92e77299620413719aa33f3423c34fe474
Core tap last commit: 4 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_REPOSITORY: /usr/local
HOMEBREW_CELLAR: /usr/local/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://homebrew.bintray.com
CPU: octa-core 64-bit haswell
Homebrew Ruby: 2.0.0-p648
Clang: 7.3 build 703
Git: 2.9.2 => /usr/local/bin/git
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /Users/stefanscheidt/.rbenv/shims/ruby => /Users/stefanscheidt/.rbenv/versions/2.0.0-p648/bin/ruby
Java: 1.8.0_92
OS X: 10.11.6-x86_64
Xcode: 7.3.1
CLT: N/A
X11: N/A

This is a duplicate of https://github.com/michaeldfallen/homebrew-formula/issues/5.

michaeldfallen/homebrew-formula#5 is closed, this should fix this issue.
Sorry I hadn't addressed it, I'm not using a Mac atm and so don't often see brew issues pop up. Thanks for addressing it.
Closing/

👍


Milestone 1: Create data model

Milestone 1: Create a data model
In this milestone I :

Created users table
Created posts table
Created likes table
Created comments table
Added Index to all foreign keys

Thanks for the review @1GORDON, and I will fix it 🙏

Thanks for the review @Rustamxon7, very appreciated 🙏


Empty drop-down lists

Hi Philippe,
The package was working correctly but later on found that the columns and operators drop-down are empty:

Maybe the reason is a Nova update currently I have the latest version v1.3.2
here is the filter code:
namespace App\Nova\Filters;

use Illuminate\Http\Request;
use philperusse\Filters\ColumnFilter as Filter;

class UserColumnFilter extends Filter
{
    /**
     * Set the displayable name of the filter.
     *
     * @return string
     */
    public function name()
    {
        return __('User Query');
    }

    /**
     * Apply the filter to the given query.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Illuminate\Database\Eloquent\Builder  $query
     * @param  mixed  $value
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function apply(Request $request, $query, $value)
    {
        $args = collect($value)->values()->filter(); //Remove any empty keys.
        if($args->isEmpty()) return $query;
        if($args[1] == 'LIKE') $args[2] = '%' . $args[2]. '%'; //Add the surrounding % if needed;

        return $query->where(...$args);
    }

    /**
     * Get the filter's available options.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return array
     */
    public function options(Request $request)
    {
        return array_merge(parent::options($request), [
            'columns' => [
                'id' => 'ID',
                'code' => 'Code',
                'name' => 'Name',
            ],
            'operators' => [
                'LIKE' => 'Contains',
                '=' => '=',
            ]
        ]);
    }
}

Thanks.

The issue was resulting due to changes in Nova v1.3.2 a possible fix #8


PEPREC file can have different separators

I ran into issues when I get spec_id from an mgf where the TITLE has " " in it; in these situations it's convenient for me that the PEPREC file can deal with different separators. This is still compatible with space-separated files as before so shouldn't create any compatibility issues.

(need additional changes for this to work completely)


#3529 Captions/depictions are not saved to Commons

Description (required)
Fixes #3529
What changes did you make and why?
Type our api calls to ease understanding and reduce misuse.
Captions are broken but now actually being invoked, I am opening this PR to be able to discuss this better.
Tests performed (required)
Tested ProdDebug on Nexus5x with API level 8.1.0.

@nicolas-raoul I am getting
{
  "errors": [
    {
      "code": "badtoken",
      "text": "Invalid CSRF token.",
      "module": "wbsetlabel"
    }
  ],
  "docref": "See https://www.wikidata.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes.",
  "servedby": "mw1287"
}

When I try to upload captions
    @SuppressLint("CheckResult")
    private void wikidataAddLabels(final Long fileEntityId, final String languageCode,
        final String captionValue) {

      csrfToken()
          .subscribeOn(Schedulers.io())
          .switchMap(editToken -> captionInterface.addLabelstoWikidata(fileEntityId, editToken, languageCode, captionValue))
          .subscribe(mwPostResponse -> onAddCaptionResponse(fileEntityId, mwPostResponse),
              throwable -> {
                Timber.e(throwable, "Error occurred while setting Captions");
                ViewUtil.showLongToast(context, context.getString(R.string.wikidata_edit_failure));
              }
          );
    }

Do you know if I need some particular token to upload captions? I

There are mostly two Mediawiki servers: Commons and Wikidata.
Both embed a Wikibase.
While existing Wikibase-related Commons app source code communicates with Wikidata's Wikibase, captions/descriptions/depictions must be sent to Commons' Wikibase.
Maybe tokens are mixed somewhere?

@nicolas-raoul sounds very likely, thank you

Codecov Report

Merging #3588 into structured-data will decrease coverage by 0.10%.
The diff coverage is 7.57%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec68ed...977c156. Read the comment docs.

I tried moving the caption creating call into the same interface that creates the depictions successfully but to no avail
{
  "errors": [
    {
      "code": "invalid-entity-id",
      "text": "Invalid entity ID.",
      "data": {
        "messages": [
          {
            "name": "wikibase-api-invalid-entity-id",
            "parameters": [],
            "html": "Invalid entity ID."
          }
        ]
      },
      "module": "main"
    }
  ],
  "docref": "See https://commons.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes.",
  "servedby": "mw1394"
}

I can see no reason why depicts should succeed yet captions fail.
I am going to be off this project for a week so if anyone wants to take this up then go for it.

I can see no reason why depicts should succeed yet captions fail.

It is a perfect timing for posting the question (explaining the situation, ideally with a tiny sample Java program) to Stack Overflow and https://www.wikidata.org/wiki/Wikidata:Project_chat. Within a week I am sure there will be some helpful answer.

Perhaps we could also ask on wikitech-l since this isn't an Android-specific question.

Apparently the id needs to be prefixed with M. I'll be swearing for a couple more minutes and then hopefully we can get to reviewing this.
{
  "errors": [
    {
      "code": "failed-save",
      "text": "The save has failed.",
      "module": "wbeditentity"
    },
    {
      "code": "editconflict",
      "text": "Edit conflict.",
      "module": "wbeditentity"
    },
    {
      "code": "failed-save",
      "text": "The save has failed.",
      "data": {
        "messages": [
          {
            "name": "wikibase-api-failed-save",
            "parameters": [],
            "html": "The save has failed."
          },
          {
            "name": "edit-conflict",
            "parameters": [],
            "html": "Edit conflict"
          }
        ]
      },
      "module": "wbeditentity"
    }
  ],
  "docref": "See https://commons.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes.",
  "servedby": "mw1404"
}
E/WikidataEditService: Error occurred while setting DEPICTS property

This error happened on the upload that had a successful caption added which hasn't been an issue up to now so hopefully that was a once off. I'll investigate further.
I really hope that requesting a new edit token doesn't invalidate the old token? That might cause issues

caption and description are added now with the requests all done one after the other.

I switched to using branchmacgills/3529-depiction-caption-uploads.
Captions and depictions are correctly uploaded! 🎉
As you might or might not be aware of, I am getting this error afterwards:
04-08 23:38:41.271  7780  8459 D OkHttp  : {"upload":{"result":"Success","filename":"Two_airliners_heading_to_Haneda_over_Ebisu.jpeg","warnings":{"badfilename":"Two_airliners_heading_to_Haneda_over_Ebisu.jpeg"},"imageinfo":{"timestamp":"2020-04-08T14:37:30Z","user":"Syced","userid":27103,"size":2819696,"width":4032,"height":3024,"parsedcomment":"Uploaded using Commons Mobile App","comment":"Uploaded using [[COM:MOA|Commons Mobile App]]","html":"
\n

File:Two airliners heading to Haneda over Ebisu.jpeg
Existing file

\n
A file with this name already exists; please check the existing file if you are not sure whether you want to change it. Please choose another filename, unless you are uploading a technically improved version of the same file.
Do not overwrite an image with a different one of the same topic (see file naming).\n
\n

\n
","canonicaltitle":"File:Two airliners heading to Haneda over Ebisu.jpeg","url":"https://upload.wikimedia.org/wikipedia/commons/3/3f/Two_airliners_heading_to_Haneda_over_Ebisu.jpeg","descriptionurl":"https://commons.wikimedia.org/wiki/File:Two_airliners_heading_to_Haneda_over_Ebisu.jpeg","sha1":"b8ec2e1d90f7960f07dfefeb1afcf081c13ebdb1","metadata":[{"name":"YResolution","value":"72/1"},{"name":"XResolution","value":"72/1"},{"name":"ImageWidth","value":4032},{"name":"ImageLength","value":3024},{"name":"YCbCrPositioning","value":1},{"name":"Orientation","value":1},{"name":"ResolutionUnit","value":2},{"name":"DateTime","value":"2020:04:07 17:22:37"},{"name":"ExifVersion","value":"0220"},{"name":"ApertureValue","value":"252/100"},{"name":"ExposureBiasValue","value":"0/100"},{"name":"ExposureProgram","value":2},{"name":"ColorSpace","value":1},{"name":"ImageUniqueID","value":"L12XLLD00SM"},{"name":"ISOSpeedRatings","value":50},{"name":"MaxApertureValue","value":"252/100"},{"name":"FocalLengthIn35mmFilm","value":26},{"name":"BrightnessValue","value":"2091/100"},{"name":"DateTimeOriginal","value":"2020:04:07 17:22:37"},{"name":"DigitalZoomRatio","value":"100/100"},{"name":"WhiteBalance","value":0},{"name":"DateTimeDigitized","value":"2020:04:07 17:22:37"},{"name":"MeteringMode","value":2},{"name":"FocalLength","value":"432/100"},{"name":"ExposureMode","value":0},{"name":"ExposureTime","value":"1/920"},{"name":"Flash","value":0},{"name":"SceneCaptureType","value":0},{"name":"FNumber","value":"240/100"},{"name":"LightSource","value":0},{"name":"GPSLatitude","value":35.6453069},{"name":"GPSLongitude","value":139.7173592},{"name":"MEDIAWIKI_EXIF_VERSION","value":2}],"commonmetadata":[{"name":"YResolution","value":"72/1"},{"name":"XResolution","value":"72/1"},{"name":"ImageWidth","value":4032},{"name":"ImageLength","value":3024},{"name":"YCbCrPositioning","value":1},{"name":"Orientation","value":1},{"name":"ResolutionUnit","value":2},{"name":"DateTime","value":"2020:04:07 17:22:37"},{"name":"ExifVersion","value":"0220"},{"name":"ApertureValue","value":"252/100"},{"name":"ExposureBiasValue","value":"0/100"},{"name":"ExposureProgram","value":2},{"name":"ColorSpace","value":1},{"name":"ImageUniqueID","value":"L12XLLD00SM"},{"name":"ISOSpeedRatings","value":50},{"name":"MaxApertureValue","value":"252/100"},{"name":"FocalLengthIn35mmFilm","value":26},{"name":"BrightnessValue","value":"2091/100"},{"name":"DateTimeOriginal","value":"2020:04:07 17:22:37"},{"name":"DigitalZoomRatio","value":"100/100"},{"name":"WhiteBalance","value":0},{"name":"DateTimeDigitized","value":"2
04-08 23:38:41.271  7780  8459 D OkHttp  : 020:04:07 17:22:37"},{"name":"MeteringMode","value":2},{"name":"FocalLength","value":"432/100"},{"name":"ExposureMode","value":0},{"name":"ExposureTime","value":"1/920"},{"name":"Flash","value":0},{"name":"SceneCaptureType","value":0},{"name":"FNumber","value":"240/100"},{"name":"LightSource","value":0},{"name":"GPSLatitude","value":35.6453069},{"name":"GPSLongitude","value":139.7173592}],"extmetadata":{"DateTime":{"value":"2020-04-08 14:37:26","source":"mediawiki-metadata","hidden":""},"ObjectName":{"value":"20200408143725!php5yKpcG","source":"mediawiki-metadata","hidden":""},"CommonsMetadataExtension":{"value":1.2,"source":"extension","hidden":""},"Categories":{"value":"","source":"commons-categories","hidden":""},"Assessments":{"value":"","source":"commons-categories","hidden":""}},"mime":"image/jpeg","mediatype":"BITMAP","bitdepth":8}}}
04-08 23:38:41.271  7780  8459 D OkHttp  : <-- END HTTP (4852-byte body)
04-08 23:38:41.277  7780  8459 D UploadService: Stash upload response 2 is UploadResult(result=Success, filekey=null, filename=Two_airliners_heading_to_Haneda_over_Ebisu.jpeg, sessionkey=null, imageinfo=org.wikipedia.gallery.ImageInfo@cdd93bb)
04-08 23:38:41.287  7780  8479 D OkHttp  : --> GET https://commons.wikimedia.org/w/api.php?format=json&formatversion=2&errorformat=plaintext&action=query&prop=info&titles=File%3ATwo_airliners_heading_to_Haneda_over_Ebisu.jpeg
04-08 23:38:41.287  7780  8479 D OkHttp  : --> END GET
04-08 23:38:41.291  7780  8479 D CookieManager: Domain:commons.wikimedia.org
04-08 23:38:41.294  7780  8459 W UploadService: Exception during upload
04-08 23:38:41.294  7780  8459 W UploadService: java.text.ParseException: Unparseable date: "2020-04-08T14:37:30Z"
04-08 23:38:41.294  7780  8459 W UploadService: 	at java.text.DateFormat.parse(DateFormat.java:362)
04-08 23:38:41.294  7780  8459 W UploadService: 	at fr.free.nrw.commons.upload.UploadService.saveCompletedContribution(UploadService.java:302)
04-08 23:38:41.294  7780  8459 W UploadService: 	at fr.free.nrw.commons.upload.UploadService.onSuccessfulUpload(UploadService.java:294)
04-08 23:38:41.294  7780  8459 W UploadService: 	at fr.free.nrw.commons.upload.UploadService.onUpload(UploadService.java:279)
04-08 23:38:41.294  7780  8459 W UploadService: 	at fr.free.nrw.commons.upload.UploadService.lambda$uploadContribution$5$UploadService(UploadService.java:264)
04-08 23:38:41.294  7780  8459 W UploadService: 	at fr.free.nrw.commons.upload.-$$Lambda$UploadService$x9tbkRB5vII9AHlajyFfh2faWnY.accept(Unknown Source:8)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.observers.LambdaObserver.onNext(LambdaObserver.java:63)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.operators.observable.ObservableFlatMap$MergeObserver.tryEmit(ObservableFlatMap.java:265)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.operators.observable.ObservableFlatMap$InnerObserver.onNext(ObservableFlatMap.java:562)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.operators.observable.ObservableMap$MapObserver.onNext(ObservableMap.java:62)
04-08 23:38:41.294  7780  8459 W UploadService: 	at retrofit2.adapter.rxjava2.BodyObservable$BodyObserver.onNext(BodyObservable.java:51)
04-08 23:38:41.294  7780  8459 W UploadService: 	at retrofit2.adapter.rxjava2.BodyObservable$BodyObserver.onNext(BodyObservable.java:37)
04-08 23:38:41.294  7780  8459 W UploadService: 	at retrofit2.adapter.rxjava2.CallExecuteObservable.subscribeActual(CallExecuteObservable.java:44)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.Observable.subscribe(Observable.java:12267)
04-08 23:38:41.294  7780  8459 W UploadService: 	at retrofit2.adapter.rxjava2.BodyObservable.subscribeActual(BodyObservable.java:34)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.Observable.subscribe(Observable.java:12267)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.operators.observable.ObservableMap.subscribeActual(ObservableMap.java:32)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.Observable.subscribe(Observable.java:12267)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.operators.observable.ObservableFlatMap$MergeObserver.subscribeInner(ObservableFlatMap.java:165)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.operators.observable.ObservableFlatMap$MergeObserver.onNext(ObservableFlatMap.java:139)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.operators.observable.ObservableDoFinally$DoFinallyObserver.onNext(ObservableDoFinally.java:80)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.drainNormal(ObservableObserveOn.java:201)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.run(ObservableObserveOn.java:255)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
04-08 23:38:41.294  7780  8459 W UploadService: 	at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
04-08 23:38:41.294  7780  8459 W UploadService: 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
04-08 23:38:41.294  7780  8459 W UploadService: 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
04-08 23:38:41.294  7780  8459 W UploadService: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
04-08 23:38:41.294  7780  8459 W UploadService: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
04-08 23:38:41.294  7780  8459 W UploadService: 	at java.lang.Thread.run(Thread.java:764)

I am aware. That is an issue on master I opened a fix for that has been merged

Structured Commons data is perfectly filled, and no more error. :-)
Wonderful job, thanks Seán!
It might be too early to ask, but are you going to work on other aspects of Structured Commons, such as the ones found at https://github.com/commons-app/apps-android-commons/labels/structured-data ? :-)

Absolutely. With the imminent release of the next Commons version I will be trying to get this merged and then the structured data branch so we will not be out of step anymore. I am sure I will work on structured data tickets in the down time between these events


Why the hessian vector product is calculated by mini-batch?

Hi, I found the hessian vector product in the file genericNeuralNet.py is implemented with mini-batch (https://github.com/kohpangwei/influence-release/blob/578bc458b4d7cc39ed7343b9b271a04b60c782b1/influence/genericNeuralNet.py#L529-L537). Why don't we directly compute the accurate hessian vector?

You can compute the accurate hessian vector product, but it turns out that it's just not necessary and would slow down the computation drastically. A mini-batch sample of the HVP within each iteration is sufficient to get good results. I encourage you to do some experiments with varying mini-batch sizes, let us know what you find out!

@markus-beuckelmann Thank you for your kind reply. I am confused about why is mini-batch way faster? If we compute the whole hessian, the loss costs O(n), the hessian costs O(p^2), the hvp costs O(p^2). The code divides the data set into k groups, the lost costs O(n/k), the other stay the same for an iteration. I don't think it is even faster.

In this case, IIRC, it's just to make sure it fits within the GPU memory.


Configure Azure Pipelines

[skip ci]
This pipeline configuration builds the application and produces a build for the Release configuration.

done?

Ok. Done.

Stop it.


Make a create-impvis batch script for windows users

At the moment we have a create-impvis.sh script which allows the older create-impvis command to still be used even though it has been depreciated and replaced with impvis create. This however only supports systems running an "sh" based shell which typically are found only on Unix based OS's (think Mac + Linux). Thus windows users are unable to take advantage of this script at the moment, as the windows equivalent is the batch script.
If someone is interested in making a batch script equivalent that would be greatly appreciated.

This was fixed by creating a cross platform node script using the execa pacakge to execute impvis create in the relevant shell fir the operating system. There are a couple of hacks to this, most notably the fact that we discard any exceptions that are thrown by the spawned shell which seems like a bad practice, however for the few people that still use create-impvis, this should suffice for now


Provider setState() or markNeedsBuild() called during build

I want to update a book state from a page, but I got this error.

flutter: ══╡ EXCEPTION CAUGHT BY FOUNDATION LIBRARY ╞════════════════════════════════════════════════════════
        flutter: The following assertion was thrown while dispatching notifications for Book:
        flutter: setState() or markNeedsBuild() called during build.

class BookCard extends StatelessWidget {
  final String img, filename, url;
  Book book;
  BookCard(
      {Key key,
      @required this.img,
      @required this.url,
      this.filename,
      this.book})
      : super(key: key);

@override
  Widget build(BuildContext context) {
    final BookProvider = Provider.of<BookProvider>(context);
    BookProvider.setEntry(book);
    return Container(
    child:  BookProvider.downloaded
                    ? GestureDetector(
                        onTap: () => {
                                     //Read the book without trying to download it*
                                      }
                    : GestureDetector(
                        onTap: () => {
                                       //Download it*
                                      }

And in the Provider Class
class BookProvider extends ChangeNotifier {
  final database = DownloadsDB.instance;
  bool downloaded = false;
  Book book;

void setEntry(value) {
    book = value;
    notifyListeners();
  }
...
}

Any help please ?

Hey, seems your isn't relating to my code but i will try my best to help.
You seem to be getting this error because you are updating the book while the widget is still building.
You should consider adding a timer to this:
final BookProvider = Provider.of<BookProvider>(context);
    BookProvider.setEntry(book);

making it something like this :
Timer(Duration(seconds: 1), (){
      final BookProvider = Provider.of<BookProvider>(context);
      BookProvider.setEntry(book);
    });

OR you can find another way to update the book state.
I hope it helps

Hi @JideGuru
Thanks for your answer.
Yeah, I tried the Timer but it doesn't work.
Because, the downloaded variable is called when the widget is building
child: bookProvider.downloaded          ? GestureDetector()
And if bookProvider is null, the app crashes
`
@override
Widget build(BuildContext context) {
BookProvider bookProvider  = null;
Timer(Duration(seconds: 1), () {
bookProvider= Provider.of(context);
  bookProvider.setEntry(book);
});`

Why not try
BookProvider bookProvider = BookProvider();

This one too.
It doesn't crash the app, but shows my logs permanently so fast.  I can't do anything except killing the app

Your app never crashed When you just write this ?
BookProvider.setEntry(book);

Your app never crashed When you just write this ?
BookProvider.setEntry(book);

I didn't do anything like this. you can check my code.
i personally don't think you need to use Provider for BookCards

I have this in my code and they were used in an onTap.
Provider.of<DetailsProvider>(context, listen: false).setEntry(entry);
 Provider.of<DetailsProvider>(context, listen: false).getFeed(entry.author.uri.t);

But if you do this, how can you know if the book is already downloaded  before tapping the OnTap button ?
I mean this:
child: bookProvider.downloaded ? GestureDetector()

i think you can make you BookCard a StatefulWidget instead and in the initState of the BookCard you can check if the book is downloaded and update a boolean value for your GestureDetector. That way is Feasible

I tried that this morning but it didn’t work, I think it was because I didn’t put the Timer.
So I’ll try the Stateful and Timer at the same time and will go back to you.

Okay. Good luck with that!

Yeah thank you

@JideGuru
I tried the stateful Widget and it seems like it works, but I'm confused with something.
 class BookCd extends State<BookCard> { @override   void initState() {     BookProvider bookProvider = BookProvider();     BookProvider.getDownload(widget.book.id).then((c) {       if (c.isNotEmpty) {         setState(() {           downloaded = true;         });       } else {         setState(() {           downloaded = false;         });       }     });     super.initState();   }
You know, it's a Book Card, so normally it is only the book tapped which has to be called or to be used in this whole class ?
But my prolem is when I print the book inside the BookCard class, I see all the books from the API.
That's why, when I tap to download a book, it download another one, or when I try to get I downloaded book, I get another one.
Do you understand what I'm saying ?

But the Timer doesn't work, the stateful widget method yes.

@JideGuru
I tried the stateful Widget and it seems like it works, but I'm confused with something.
 class BookCd extends State<BookCard> { @override void initState() { BookProvider bookProvider = BookProvider(); BookProvider.getDownload(widget.book.id).then((c) { if (c.isNotEmpty) { setState(() { downloaded = true; }); } else { setState(() { downloaded = false; }); } }); super.initState(); }
You know, it's a Book Card, so normally it is only the book tapped which has to be called or to be used in this whole class ?
But my prolem is when I print the book inside the BookCard class, I see all the books from the API.
That's why, when I tap to download a book, it downloads another one, or when I try to get a downloaded book, I get another one.
Do you understand what I'm saying ?

I don't get you.
Since this Issue is not related to this repository, why dont we talk about it else where?

Ok, but where can we talk, so I can close the issue with the stateful Widget method


Initial support for Hailo devices

Add some examples using hefs from /usr/share/hailo-models.
Improve handling of networks with multiple outputs so that they can be used with or without batching. The pose network post-processing is updated slightly to cope with these changes.

@naushir I think I'm in principle ready to merge this if you're happy too...

Looks good to me!


Getting UnparsedFlagAccessError with example code

Hi there,
I'm trying to run the demo code from the README, but am getting an UnparsedFlagAccessError error.
Code:
from vizier.service import clients
from vizier.service import pyvizier as vz

# Objective function to maximize.
def evaluate(w: float, x: int, y: float, z: str) -> float:
    return w**2 - y**2 + x * ord(z)

# Algorithm, search space, and metrics.
study_config = vz.StudyConfig(algorithm='GAUSSIAN_PROCESS_BANDIT')
study_config.search_space.root.add_float_param('w', 0.0, 5.0)
study_config.search_space.root.add_int_param('x', -2, 2)
study_config.search_space.root.add_discrete_param('y', [0.3, 7.2])
study_config.search_space.root.add_categorical_param('z', ['a', 'g', 'k'])
study_config.metric_information.append(vz.MetricInformation('metric_name', goal=vz.ObjectiveMetricGoal.MAXIMIZE))

# Setup client and begin optimization. Vizier Service will be implicitly created.
study = clients.Study.from_study_config(study_config, owner='my_name', study_id='example')
for i in range(10):
    suggestions = study.suggest(count=1)
    for suggestion in suggestions:
        params = suggestion.parameters
        objective = evaluate(params['w'], params['x'], params['y'], params['z'])
        suggestion.complete(vz.Measurement({'metric_name': objective}))

Error:
---------------------------------------------------------------------------
UnparsedFlagAccessError                   Traceback (most recent call last)
Cell In[21], line 20
     18 study = clients.Study.from_study_config(study_config, owner='my_name', study_id='example')
     19 for i in range(10):
---> 20     suggestions = study.suggest(count=1)
     21     for suggestion in suggestions:
     22         params = suggestion.parameters

File ~/Projects/cppflow/venv/lib/python3.8/site-packages/vizier/_src/service/clients.py:143, in Study.suggest(self, count, client_id)
    138 def suggest(
    139     self, *, count: Optional[int] = None, client_id: str = 'default_client_id'
    140 ) -> List[Trial]:
    141   return [
    142       self._trial_client(t)
--> 143       for t in self._client.get_suggestions(
    144           count, client_id_override=client_id
    145       )
    146   ]

File ~/Projects/cppflow/venv/lib/python3.8/site-packages/vizier/_src/service/vizier_client.py:168, in VizierClient.get_suggestions(self, suggestion_count, client_id_override)
    165 num_attempts = 0
    166 while not operation.done:
    167   sleep_time = PollingDelay(
--> 168       num_attempts, FLAGS.vizier_new_suggestion_polling_secs
    169   )
    170   num_attempts += 1
    171   logging.info(
    172       'Waiting for operation with name %s to be done', operation.name
    173   )

File ~/Projects/cppflow/venv/lib/python3.8/site-packages/absl/flags/_flagvalues.py:481, in FlagValues.__getattr__(self, name)
    479   return fl[name].value
    480 else:
--> 481   raise _exceptions.UnparsedFlagAccessError(
    482       'Trying to access flag --%s before flags were parsed.' % name)

UnparsedFlagAccessError: Trying to access flag --vizier_new_suggestion_polling_secs before flags were parsed.

Specs:

Ubuntu 20, python3.8, google-vizier=0.1.5

Any ideas on how to fix this? I looked around online but didn't find anything helpful.
Thanks,
Jeremy

The project has some hidden CLI flags that need to be parsed, setting them to a default value.
Adding the following at the top of my script worked for me.
from absl.flags import FLAGS
import sys
FLAGS(sys.argv)

Would be good to see the project either document the step or make it redundant.

Thanks it's working now. I was getting an error UnrecognizedFlagError: Unknown command line flag 'f' when running FLAGS(sys.argv). My sys.argv is ['/home/.../venv/lib/python3.8/site-packages/ipykernel_launcher.py', '-f', '/home/.../.local/share/jupyter/runtime/kernel-ead04449-484c-47c8-9f40-a6ded4d1e08a.json']. I changed the code to the following and it worked:
from absl.flags import FLAGS
import sys
FLAGS([sys.argv[0]])

Should this change by submitted as a PR to the readme? happy to do so

Another thing, this call suggestions = study.suggest(count=1) is hanging. Any idea why that is? Do I need to update the client_id parameter or something?
thanks

I recall running into this as well. It fixed itself when I followed the read-the-docs documentation rather than the readme https://oss-vizier.readthedocs.io/en/latest/guides/user/running_vizier.html. Sorry, I can't remember what exactly fixed it.

This code works for me
from vizier.service import clients
from vizier.service import pyvizier as vz

from absl.flags import FLAGS

FLAGS([""])

problem = vz.ProblemStatement()
problem.search_space.root.add_float_param("x", 0.0, 1.0)
problem.search_space.root.add_float_param("y", 0.0, 1.0)
problem.metric_information.append(
    vz.MetricInformation(name="maximize_metric", goal=vz.ObjectiveMetricGoal.MAXIMIZE)
)

def evaluate(x: float, y: float) -> float:
    return x**2 - y**2

study_config = vz.StudyConfig.from_problem(problem)
study_config.algorithm = "QUASI_RANDOM_SEARCH"

study_client = clients.Study.from_study_config(
    study_config, owner="owner", study_id="example_study_id"
)

for i in range(10):
    suggestions = study_client.suggest(count=1)
    for suggestion in suggestions:
        x = suggestion.parameters["x"]
        y = suggestion.parameters["y"]
        objective = evaluate(x, y)
        print(
            f"Iteration {i}, suggestion ({x},{y}) led to objective value {objective}."
        )
        final_measurement = vz.Measurement({"maximize_metric": objective})
        suggestion.complete(final_measurement)

Hi, this should be fixed now in v0.1.6. Thanks!


Visual Studio 2015 CTP 6: Cannot install some packages.

Launch VS 2015 CTP 6
Create a new class library project.
Manage NuGet Packages For Solution.
Install xunit
Package source: api.nuget.org
Filter: All
Include prerelease: unchecked
Search box: xunit
Show preview window
Action: Installe
Version: Latest stable 2.0.0
Dependency behavior: Lowest
File conflict action: Propmpt

First signs of a problem appear with dependency resolution taking a long time.  Once the Preview window does come up it only shows xunit.assert 2.0.0.  The expectation is that xunit, xunit.core xunit.extensibility.core and xunit.assert should all be installed.
I believe the problem is likely the fact that xunit and xunit.core don't have a lib folder or add any references.  They do however contain build tools and have references that must be installed.
Is this an expected behavior change?  If so, what is the correct way to build packages like this?

@zoltu, Created https://github.com/NuGet/Home/issues/320 for tracking this.
Please file visual studio client issues in https://github.com/NuGet/Home/issues


Use robust orient2d predicate

From the project's README:

In comparison, the Delaunator.jl package seeks to mirror the javascript Delauantor packages that give good enough triangulations for many pixel-level graphics applications and are fast for 2d problems, rather than those that might be suitable for those with computational geometry applications that need better guarantees (although we do hope to improve this in the future).

This behavior no longer mirrors Delaunator in JS — the latter is using robust orient2d predicate as of v4 (see https://github.com/mapbox/delaunator/pull/68) to guarantee robust triangulation.

Thanks for the comment and apologies about the confusion. The readme has been updated now. Hope we can get this improved to use the exact predicates sometime soon!

https://github.com/vchuravy/AdaptivePredicates.jl/ covers the same surface as that JS library, so Delaunator could use that...

Oh that's nice! I really would rather avoiding StaticArrays as a dependency -- and indeed, any dependencies at all :)
Let me take a look at what it'd take to modify it to get to a point where we could use this.

FYI @dgleich The rest of https://github.com/JuliaGeometry/AdaptivePredicates.jl has been ported over now in case you are interested on using it for incircle as well.


Errors when running the code

When running python3 train.py with the preprocessed dataset, I have this error message:
AttributeError: 'Word2Vec' object has no attribute 'vocabulary'
When running python3 preprocess.py, encounters an error message:
[Errno 2] No such file or directory: '../preprocessed_data/app_reviews/appstore.json'

Dear RicciWoo,
The first error is related to gensim package version. Please make sure that you have meet the requirements in your environment: gensim<=3.1
The second error is related to the missing data, you could run the preprocess.py with other domain data, as described in readme. But thank you for pointing out, I will change the default domain value.


Added custom video player

Related Issue
Made a Custom Video player using Javascript
Closes: #[#463]
Describe the changes you've made
I added the necessary javascript, html and css files corresponding to the project and tested them.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation.
[X] New and existing unit tests pass locally with my changes.

Screenshots
Put any screenshot(s) of the project here.

Please review my pr @ridsuteri

Ok

Made the changes please review @ridsuteri

ok

Done @ridsuteri

Thank you @ridsuteri . Please add gssoc and level tags else I cannot receive my pts :)


App is not compatible with 2FA

The app logs me out after enabling 2FA and I am not able to log in with 2FA enabled.

Nevermind it works, however I'm not sure why it did not work previously


Node.js 18 Support

This lib causes errors in my build. It'd be great if we could get support for the latest LTS (18.12.1) at least.
node js release page
Are there any known blockers for 18+ node support?

Hi @Bug-Reaper,
Did you test the last version of the library, node 18 and 19 has added in that version, if you have found any bug let me know.
Best regards.


Russian Translation of React Projects.

Closes #6808

@rfprod thanks for the translation. When you finish editing, squash commits into one and we'll be ready to merge.

@bugron All changes are done, now I'm not sure what to do with this:
(add/RU-translation-react-projects) $ git rebase -i HEAD~n
fatal: Needed a single revision
invalid upstream HEAD~n

After making a final commit and preparing to squash commits before push, I discovered that I did not do git pull --rebase upstream staging before making changes.
Provide further instructions, please.

@rfprod we can pair by Screenhero if you want.

@bugron Screenhero does not accept new signups according to statement on the login page. I created slack.com account, but the are offering Screenhero to paid accounts only. And I'm not really comfortable with anyone gaining control over my computer in general. If you provide any helpful links, it will be enough, I think.

Ok, it seems commits are squashed:
[detached HEAD 26dd3d9] Russian Translation of React Projects. Closes #6808
 1 file changed, 82 insertions(+)
Successfully rebased and updated refs/heads/add/RU-translation-react-projects.

@rfprod OK, now just force push your branch to your fork. git push -f YOUR_UPSTREAM YOUR_BRANCH.

@rfprod thank you for this awesome translation. It's really great. Would love to QA more translation PRs from you. And thank you for your patience :)
Verified and merged!

@bugron I will make another translation after current backend challenge is finished. This will happen soon. Thank you for your assistance.


04-chaining-selectors: Replaced 404'd credit URL for Katho Mutodo with their IG link

Complete the following REQUIRED checkboxes:

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check

Complete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:

[x] I have ensured that the TOP solution files match the Desired Outcome image

1. Because:

The credit URL for Katho Mutodo for Pexels 404s. Upon doing some research, it seems they post their photos on Instagram now.
2. This PR:

Removed the 404'd URL and added their Instagram URL.
3. Additional Information:

I noticed they have a link to their Linktree page. I went through all the options, and they seem to post most on their Instagram which is why I supplied the link to that, as opposed to 500px (last post 6 months ago).

@nicholasmercurio just wanted to check on whether you'd like to continue working on this?


Fonts missing in installation instructions

Thanks for all the work on this project. I just wanted to give it a try but first had to
apt-get install fonts-freefont-ttf

before the calibration images were saved. Otherwise, the program crashed.

Thanks pf
I will add to the install instructions although I have never run across this problem on either Jessie or Wheezie.  Have not tried with Jessie Lite.  It may be that this gets installed with Pillow or PIL and I install imaging with pi-timolo.  Also I install opencv from source so might be installed at that time.  Let me know what OS version you are running on your RPI.  I do not do very much error trapping in the code but have started doing it where ever it makes sense.  The motion-track code is just a demo I did as a fun exercise. and later wrote a prototype hotspot game and of course speed-track that has more application.  I also find issues with python2 and python3 syntax differences especially with opencv.
Regards Claude ...

Thank you!
I've used Raspbian Jessie Lite (https://www.raspberrypi.org/downloads/raspbian/), cloned your repository, and executed your speed-track script. After installing the fonts everything seems to work fine.

OK.  Thanks for the information.  I have had a few previous issues with Jessie Lite not having some expected libraries.  I guess that is why they call it lite.  I have used Jessie Lite on a few machines that run headless.  The regular Raspbian does have a lot of stuff that I don't use but when you need a desktop for testing opencv it is essential.  Thanks for your help.

FYI I have a newer Faster version using threading at
https://github.com/pageauc/motion-track/tree/master/speed-track-2
Let me know what you think.  Note this is still just a demo
On Wed, Apr 13, 2016 at 6:46 AM, Dennis Pfisterer<EMAIL_ADDRESS>wrote:

Thank you!
I've used Raspbian Jessie Lite (
https://www.raspberrypi.org/downloads/raspbian/), cloned your repository,
and executed your speed-track script. After installing the fonts everything
seems to work fine.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/pageauc/motion-track/issues/2#issuecomment-209363387

--
See my YouTube Channel at http://www.youtube.com/user/pageaucp

Instructions contain details for installing missing fonts in Jessie lite per
sudo apt-get install fonts-freefont-ttf


Success report: Noname 2.4" ILI9341 display

Hi there, this isn't a bug -- it's a success report. Not sure if you're interested in those?
I successfully got a noname display ("Surenoo Technologies" was the seller on Aliexpress), 2.4" with ILI9341 to work using fbcp-ili9341. The seller referenced the documentation here. Built it using:
cmake -DSPI_BUS_CLOCK_DIVISOR=6 -DILI9341=ON -DGPIO_TFT_DATA_CONTROL=22 -DGPIO_TFT_RESET_PIN=27 -DSTATISTICS=0 ..

Extremely straightforward, ran immediately. Very smooth installation, extremely well-documented project, thank you so much. I'm so happy that I have a display running using code I trust instead of some arbitrary binblob :-)
Take care, Johannes

Very nice, thanks for the writeup. Makes me happy to read that the project is useful to you!

Also really cool project with BeatSaber, that game is awesome :)


[4.1] Stricter enforcement of the "large space" heuristic

Explanation: Pairs with #12818 on master.

The Space Engine includes a heuristic that attempted a combinatorics-
based check to see if a pattern covered an insufficient amount of cases.
In straight-line switches this avoided computing a subspace match that
would have been quite expensive computationally. However, when
expressive patterns (like tuple patterns) are used, it can fool the
check because the covered space is much larger than the actual size of
the space due to pattern overlap that counting like this simply can't detect.
Instead weaken the heuristic to diagnose large spaces as "uncheckable" and suggest a default clause. This requires disabling SILGen's warning for unreachable default clauses which is itself incomplete.

Scope: Affects users that write complex switch statements with (large) tuple types.
Issue: (Needs radar post-nomination: see rdar://problem/35389001 and SR-6316)
Reviewed by: @jckarter
Risk: Low. Improves on a broken heuristic and does some diagnostics QoI work too.
Testing: Added compiler regression tests.

@swift-ci please test

Okay to merge or is there something more you wanted to do here?

Does this need a nomination?

@swift-ci Please test source compatibility

⛵
I’d appreciate if someone could close out the linked radar.


Update README

Unfortunately, this PR doesn't preserve the 80x40 dimensions.

Unfortunately, this PR doesn't preserve the 80x40 dimensions.


feat: use more function coercions in apply_fun

When apply_fun f is applied to the main goal, it creates the expression Function.Injective f, which requires that f be a function. Now apply_fun will insert a function coercion here if needed. Furthermore, apply_fun is now aware of Equiv.injective.

bors merge


Waiting for the Managed Server to accept requests-SOA Managed Server

I have used the Oracle provided container registry .When i create a seperate Managed servers ...
when inspecting the logs it hangs here ...
INFO: creating boot.properties for soa_server1
INFO: Starting the managed server soa_server1
INFO: Waiting for the Managed Server to accept requests...

It hangs at above lines when managed server is not able start successfully. One reason may be its not able to connect to Adminserver.
To triage further, please provide the below details:

Oracle SOA Suite version
Environment details used to start Adminserver and Managed servers (adminserver.env.list, soaserver1.env.list and soaserver2.env.list)
Commands used to start admin and managed server containers.
Managed server logs available at mount path "$data_volume/SOA/domains/${DOMAIN_NAME}/logs/${MANAGED_SERVER}". Inside containers logs are available at "${DOMAIN_HOME}/logs/${MANAGED_SERVER}/ms.log"


Fix page flicker on load

Proposed Changes

useEffect => useLayoutEffect so that it runs just before painting

Someone tell me if this is a bad idea, all I know is it seems fixed
https://github.com/CovidEngine/vaxxnz/issues/234

No actually that makes a lot of sense, useEffect runs after render while use useLayoutEffect runs immediately after any DOM changes, so any scroll changes due to the DOM will be counteracted.
Nice thinking


feat(pow): adds a bunch more powergate info to the docs

This includes some reorg such that "introductions" /hub/introduction are now just the root dir /hub/. The main stuff to review can be found in the /powergate/ folder


chore: Disable Sonar on PRs from forks

Fix #512
There was a bit of a bug in skipping Sonar on PRs from fork (read: it didn't skip Sonar on PRs from forks). With this PR, that's fixed.

You can see here that with this PR running from a fork, the Sonar step doesn't run
And in this PR (which originates from within this repo), the Sonar step does run

LGTM.


SetPlayerSkin causes random crash

SetPlayerSkin should be replaced with SetSpawnInfo and SpawnPlayer functions.

Post the code you wrote for this cause it might help later.

http://pastebin.com/ju9qut82

Fixed on my version.


[Automated] FinalTrigger

Author name
Author: MrDomocle
About your game
What is your game about?
Play as Frog from Chrono Trigger and jump around 3 platforming levels!
How do you play your game?
A/D: move
J: jump
K: reset level

Very cool game, nice platformer.  The rickroll was a nice touch.  If you're a teenager, and if you haven't already received one, please fill out this form to receive a Sprig of your very own.  Also, feel free to join Hack Club's #sprig channel and share your creation!


JS-0001 add details to readme and right click to handle lingers

Add details to readme for setup
Add handling of right click for attendees with lingers

Boom! That was fast!


Update to webgl2?

https://github.com/KhronosGroup/WebGLDeveloperTools has been updated to support WebGL2, which is great, but I just realized that the corresponding npm module is independent and published from this repo instead.
Any chance we could get an update published on npm? If it helps, I could try putting together a PR, let me know.
FWIW, we have been using this module for debugging with great success, but it doesn't cover WebGL2 functionality which we are increasingly relying on.

@vorg
Due to lack of response I assume this is repository is no longer maintained.
I'm considering forking the repo and publishing as a separate npm module.
Or if you prefer, you could add me to your repo/npm module and I could take over the maintenance.

Hi, i just saw you issue. Let me have a look and try updating it tomorrow.


orb start always escalates to ask about the docker sock

Is your feature request related to a problem? Please describe.
I'd like to automate orb start but it always does an (optional) escalation prompt:

I know I can say "no", and that's fine. But to automate orb start there is no human around.
Describe the solution you'd like
Either don't do this or make it optional via config for a flag. (DDEV uses docker contexts so doesn't need this in the first place)
Describe alternatives you've considered
Don't know any
Additional context
DDEV is considering explicit support for OrbStack,

https://github.com/ddev/ddev/issues/4858

But we need to figure out automated testing before that can happen.

我也有这个问题，每次开机都会重新弹出这个窗口

The plan is to make this configurable, but not until #281 is implemented.

It's worth noting that this also happens when OrbStack doesn't run, and one executes ssh orb. It's of course a great feature to auto-run the application which already seems to be aware that it should run without opening a window (or only as menu-icon). When that happens, the popup current shows as part of application startup apparently. I think it would be less surprising if this popup only shows when the application window is visible, or doesn't show when ssh orb is used to start the application.

I love OrbStack to death but having to enter my PW every login is a bit much :(

Released in v0.16.1.

Thanks so much!


Add Azure Active Directory?

Is it possible add Azure Active Directory as a Microsoft in-scope cloud services to make it easier to find? The answer was buried in the Overview of Microsoft Azure compliance doc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b545aa0d-ba68-3113-413b-0c0b176b08bd
Version Independent ID: bb2ce8e1-7f40-e5ed-60c4-f8bb0912661d
Content: Health Insurance Portability and Accountability (HIPAA) & HITECH Acts
Content Source: microsoft-365/compliance/offering-HIPAA-HITECH.md
Product: microsoft-365-enterprise
GitHub Login: @robmazz
Microsoft Alias: robmazz

@chadhasbrook  - Thank you for submitting feedback.
I will get this issue over to the Microsoft 365 writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@chadhasbrook - thanks for this feedback, we are talking through updates to the content architecture and I'll incorporate this feedback.


Stop working on the buildrun if build.registered=false

The buildrun controller is able to check the build's registered status.
If build.Status.Registered is false, it should stop working on further service account and taskrun.

@SaschaSchwarze0 please also help me to review this PR, which shall fix the issue #301

/ok-to-test

Let me share more details about this PR:
$ kubectl get build
NAME                       REGISTERED   REASON                                  BUILDSTRATEGYKIND      BUILDSTRATEGYNAME   CREATIONTIME
kaniko-golang-build        False        secret icr-knbuild-non does not exist   ClusterBuildStrategy   kaniko              5m22s
kaniko-golang-build-test   True         Succeeded                               ClusterBuildStrategy   kaniko              104s

$ kubectl get br
NAME                          SUCCEEDED   REASON                                                                               STARTTIME   COMPLETIONTIME
kaniko-golang-buildrun-non    False       Invalid TaskSpec: translating TaskSpec to Pod: secrets "icr-knbuild-non" not found   5m20s
kaniko-golang-buildrun-test   False       Invalid TaskSpec: translating TaskSpec to Pod: secrets "icr-knbuild-non" not found   49s

Even the br kaniko-golang-buildrun-test referred to the corrected secrets, the one from build : kaniko-golang-build-test.
But it still fails because the sa continues to refer the non-existing secret created in kaniko-golang-build-non.
To fixes this, This PR checks the build's registered status before working on the buildrun.
The logs would look like the following, in the case our build was referring to non-exist secrets.
2020-07-30T10:25:30.935+0200	ERROR	controller-runtime.controller	Reconciler error	{"controller": "buildrun-controller", "request": "default/kaniko-golang-buildrun-non", "error": "Build is not ready, registered status: False, reason: secret icr-knbuild-non does not exist"}

/lgtm


[Unblock clean CI] Remove the CI step to restore vcpkg from the cache and remove the analyze flag for MSVC

Testing out some stopgap solution to https://github.com/Azure/azure-sdk-for-c/issues/1142 by removing the restore from cache step.
Also, remove the analyze flag for MSVC to get clean CI to test out a stopgap which unblocks existing PRs while investigation is pending for https://github.com/Azure/azure-sdk-for-c/issues/1137

Why did the analyze flag create the problem?  Was it newly added, or did something underneath change?

Why did the analyze flag create a problem? Was it newly added, or did something underneath change?

The MSVC compiler on the build machines upgraded which brought in new (possibly false positive) analysis capabilities.
See https://github.com/Azure/azure-sdk-for-c/issues/1137#issuecomment-681078133
Nothing was changed recently from the SDK code perspective that caused these new warnings.


Add manual tests for a variety of database types

We need a standardized test suite that exercises all of the validation step functions with a variety of database types. The databases and their drivers should be: MySQL (with RMariaDB), PostgreSQL (with RPostgres), SQLite (with RSQLite).

This is done and the .R files for the agent tests are available in tests/manual_tests.


Update docs.md

Added to the scope to include using inclusive language and maintaining internal consistency of the doc styles

I agree with the change and approved in case you want to merge it.

Thanks!


Removed non-generic ILogger interface methods

Justification: methods defined in ILogger-v1 and ILoggerBase-v1 partial classes are redudant since for each of them there does exist a generic counterpart.
Consider for example void Debug(string message, decimal argument) or void Debug(string message, long argument) or void Debug(string message, sbyte argument): there is one void Debug<TArgument>([Localizable(false)] string message, TArgument argument) which covers them all.
Why these methods are initially in the Logger class and why they shouldn't be introduced to the ILogger interface is explained in detail in this comment: https://github.com/NLog/NLog/issues/119#issuecomment-68323685

Nice. Less is more. But i'm curious if this is has impact on the performance.

@304NotModified Good catch, I must admit that interface generic method call is almost 5 times slower than interface non-generic method call with the same signature.
I've created microbenchmark to measure method call times. The results show no difference for concrete class instance method calls, but for interface method calls there is noticeable slowdown.
Instance Generic: 3,28 ns/call
Instance NonGeneric: 3,62 ns/call
Interface Generic: 14,58 ns/call
Interface NonGeneric: 3,78 ns/call

Thanks for the benchmark.  Could you post the benchmark code for future reference?
With thousands of log statements,  5 times slower isn't good idea.
I'm curious what problem were trying to solve. Improve maintainability?


Add SetStdout SetStdin

I saw that I cannot easily convert the string path in SetStdoutFile(path string) to the io.ReadWriter on wasmtime-go, so this is a suggestion to wasmtime.
io.ReadWriter is an interface which implemented by os.File and bytes.Buffer. With an io.ReadWriter as the parameter for WASI config, golang can operate its favor bytes without filesystem-level io, which means the WASI call will be more easy safe and stable.
buf := bytes.NewBuffer(nil)
config := wasmtime.NewWasiConfig()
config.SetStdin(buf)
config.SetStdout(buf)

// then instaniate the wasi with the config

go func(){
	b, err buf.ReadBytes('\n')
	// handle this
}()
go instance.GetExport("_start").Func().Call()
// now intance request a stdin
buf.Write("continue exec")

This is similar to https://github.com/bytecodealliance/wasmtime-py/issues/34 where there's support for this in the Rust wasmtime API but support has yet to be added to the C API

Bumping this, as it would be extremely useful to be able to pass stdin and get stdout from modules :)
@alexcrichton if you have any advice on how we could help implement this, we'd love to contribute.

Implementing this would first need to start out at the Wasmtime C API layer. There's not a ton of Wasmtime-specific prior art to choose from unfortunately, so the APIs for this at the C layer need to be designed from scratch and implemented. Once that's landed then the Go support can be built on top of that.

Bumping this as well, I think it would be pretty handy to have this functionality implemented as in the Rust implementation.


Space added to make main content visible

Please merge my request for hacktoberfest

Please merge my request if everything is ok or u can ask me to make any changes if necessary


Use time-compat, add instances for DayOfWeek, Month etc

time-compat provides the missing types and instances for time package,
such one don't need to upgrade it (which is sometimes difficult).
In longer run, I'd be happy to provide hashable instances
in time-compat itself. Yet I think first introducing dependency
to hashable-time would allow better migration story.
(FWIW time-compat is used by aeson etc.)

Thanks for the invitation. I'm not sure what it's about. If you are ok for me to make actual releases as well, then you'd need to add me as a maintainer on https://hackage.haskell.org/package/hashable-time/maintainers/, I have the same username there.

Hi @phadej, I added you to maintainers on hackage as well. Overall I barely use Haskell or Github nowadays, so it's best if you just take over the package. I also don't mind moving the instances to time-compat, and then deprecating this package I guess.


mat-undefined class getting applied on select panel instead of mat-primary

panel which gets open for formly-field-mat-select  is having mat-undefined class instead of mat-primary. in earliear version it used to be mat-primary
Your Environment

Angular version: 15.0.0
Formly version: 6.0.2

Additional context

This issue has been fixed and released as part of v6.1.0 release.
Please let us know, in case you are still encountering a similar issue/problem.
Thank you!


Template

Please provide the template for the card, I'd like to contribute to other languages.

@mhasan341 sure, I've now provided the template here as a Figma file: https://github.com/vandadnp/flashcards/tree/main/dart/v1.0


Rcc reset+pcm fixsupport

Hi, the main target of this branch is to support correctly "PCM" standards (see issue #7 ). it's also integrate feature from #6

adapt calculations related to sample rate (WIP, it need some measurement but i don't have the tool at the moment)
adapt I2sTransfert to support PCM (mostly done)
Other changes:
factorize I2sTransfert by making it more generic. This have a some consequences:

the internal representation of frame is visible through trait i used to make thing more generics.
I think in many occasion, the compiler cannot infer types used with read/write methods.
generic handling of overrun error in master receive transfer is not optimal.

TODO

determine calculation to get/set sample rate with "PCM"mode (currently, it's panics with unimplemented message)
handle overrun error in master receive transfer (i think i will return an error for this one)

sorry, i finished this since a while. I wanted update my testbench porgram before to fully test HALs, but writing such program is actually more difficult and longer to write than the abstraction itself, so some configuration, especially in PCM mode, have not been tested.

Thanks for contributing. I don't have time to fully test this myself, but the code looks good and I trust that you have done enough testing yourself.
Let me know if you'd like me to publish a new version.


Style change causes @font-face files to be re-requested from server

Bug report
Describe the bug
Whenever styles change, the browser re-requests any fonts loaded with @font-face.
To Reproduce
Minimal test case here: https://codesandbox.io/s/lively-tdd-v09pj
It's easiest to tell if you open the preview in its own tab/window and have the network inspector open when you load the page. That way, you can see the initial request(s) for font files alongside the subsequent one when clicking the button in the preview.
Expected behavior
The browser should not request fonts it has already downloaded in the same page load.
System information

OS: macOS
Browser (if applies): Firefox, Chrome, probably others
Version of Stitches: 0.1.9

Additional context
It seems like styled-components ran into this same issue (https://github.com/styled-components/styled-components/issues/1593). They considered splitting out @font-face rules into their own style tag, but ultimately decided to encourage people to set cache headers rather than addressing it (https://github.com/styled-components/styled-components/issues/1593#issuecomment-508748098).
Not sure whether or not y'all will want to make the same tradeoff, but bringing it to your attention anyway.

@jakelazaroff thanks for that, we'll investigate.

Fixed in ^0.2.0
demo: https://codesandbox.io/s/tvzpz
npm i @stitches/react@latest

I've just spent an hour debugging what seemed to be a related issue. However, it turned out it was caused by use of ref preload.
<link
  as='font'
  crossOrigin='anonymous'
  href='/fonts/segoe-ui-regular.woff2'
  rel='preload'
  type='font/woff2'
/>

For whatever reason presence of preload was causing fonts to flicker any time Stitches regenerates global styles.
I didn't find a solution, just removed preload tag.


TensorFlow issue

2024-03-29 13:15:53.388917: I tensorflow/core/util/port.cc:113] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable TF_ENABLE_ONEDNN_OPTS=0.
2024-03-29 13:15:55.249489: I tensorflow/core/util/port.cc:113] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable TF_ENABLE_ONEDNN_OPTS=0.

This is a warning message and should not affect the working of Devika.

Thanks for your reply.
It works now . But just chat after devika chats and say thanks nothing
happens 🥲
Is there a problem in my installation process or something else....
On Sat, 30 Mar, 2024, 12:33 pm Mufeed VH, @.***> wrote:

This is a warning message and should not affect the working of Devika.
—
Reply to this email directly, view it on GitHub
https://github.com/stitionai/devika/issues/240#issuecomment-2027947296,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHJYXYZ7TYA26L7ZHMGMELTY2ZPUZAVCNFSM6AAAAABFOCMF4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHE2DOMRZGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


First Playlist Added

BRL Trainee 2nd year

Add your second playlist again after creating a new a PR

Also help other member's too to pull their successful PRs!


Bluetooth device name not being resolved while scanning

I am using the observer to scan for nearby BLE devices and  seeing a lot of BLE traffic but their device names are always 'None'. There are Apple TVs and plenty BLE devices around which show up in complete local name when I use other tools
Any suggestions what can I do to resolve names of devices?
Thanks!

I suspect it is because there isn't a scan response being requested.
https://stackoverflow.com/questions/25159222/bluethooth-4-0-scan-response
As the local Name will be added at the end of the scan response data.
This is often referred to as passive and active scanning.
Some more background information at:
http://microchipdeveloper.com/wireless:ble-link-layer-discovery
The seems to be some support for the different scan types.
https://github.com/TheCellule/python-bleson/blob/8566949729706159d6cc11c0c07c63d86f74f9f3/bleson/core/hci/constants.py#L7-L8
Which platform are you on?

I am using the repo as it is without any changes, and isn't the scan type set to ACTIVE in here by default?
https://github.com/TheCellule/python-bleson/blob/8566949729706159d6cc11c0c07c63d86f74f9f3/bleson/providers/linux/linux_adapter.py#L116

Which platform are you on?
I am on ubuntu 16.04


Error on first initialization

When running 'whatsapp-fzf-init' it shows a error: 'chown: User: illegal group name'
Any advice?

Hi @Bellavene . I have attempted a fix in the latest version. It should be fixed now.

Strangely it gives two codes at start, first one is smaller than second one and whatsapp accepts only the second one. But still it gives an error:
‘Error: Multi-device is not yet supported by whatsapp-web.js. Please check out https://github.com/pedroslopez/whatsapp-web.js/pull/889 to follow the progress.
at Client.initialize (/opt/homebrew/lib/node_modules/whatsapp-fzf/node_modules/whatsapp-web.js/src/Client.js:225:19)’
But I have ‘multi device’ turned on in whatsapp.


Add options section for simple request matcher.

And add first option matchByPath. It's useful, when you have e.g. requests with query params and you want to mock them equally

@pimterry Yes, make sense. But unfortunately I don't have much time to implement this features. Maybe I will have some time next week

Sure, that's fine, there's no hurry at all. Thanks for all your help!

I've now implemented this independently, so I'm going to close this PR. Thanks for the inspiration!
In Mockttp, from 0.9.0:

Passing any path that includes query parameters to .get(path) (and similar) will throw a nice & helpful error.
By default query parameters are ignored when matching requests.
You can use .withQuery({ paramA: value1, paramB: value2, ... }) to explicitly check for specific query parameters in request URLs.

I've left it there for now - I'm open to other matchers like withExactQuery to refuse queries with extra params, or to allow passing a string formatted query, rather than an object, but for now I think this'll do. Thanks again :+1:


23.1.5 not create new connection or connect to existing connections

Description
23.1.5 not create new connection
DBeaver Version
23.1.5
Operating System
Win10
Database and driver
No response
Steps to reproduce
Try create new connection...
Additional context
No response

I'll wait for the fixed version, but for now I rolled back to 23.1.4...


[parallel_executor] Handle unestimated read in the executor

Motivation
Handle the unestimated read case of parallel executor on the executor side instead of the client with a dirty bit. With this the task thread won't need to propagate the read estimation error back to the executor.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Modified the test and make sure unestimated reads can still be handled correctly.


Add all missing German translations.

Coverage remained the same at 50.809% when pulling 615eacf333b22acb9ab55b8ee2cf5657975a9704 on german-translations into d6f91cd0eb12505942db602523f2406a0a291284 on master.


Removed Deprecated JS Component

Orbit is deprecated, so i removed it from humans.txt file. Nothing special

Why? Why you deprecated Orbit if Orbit is very useful? I try use other sliders but are very hard, i only need the all slider with the same height, but they put me the slider in different heights :'(

I removed it from humans.txt file. It was just an example. You can use older foundation version if you really need it badly.

Hm, I suppose for that line to make sense, it needs to include every JavaScript component, of which there are about a dozen.
I'm not really sure why we have a humans.txt there anyway, though. That file doesn't get copied to the Foundation marketing site or docs, and it's not meant to be used in Git repos. It's supposed to be at the root of a website where a robots.txt would be.

Closing this in favor of just deleting the humans.txt, because this repository isn't a website, it's a codebase.


Update Document updatedAt to only include Document.Root modifications

Description:
Currently, modification to Document.Presence updates the Document's updatedAt, even if there are no changes to Document.Root content. This behavior can lead to unnecessary updatedAt updates and may not accurately reflect the actual content changes.
Why:

@binary-ho Sure! I think you will need basic understanding of document editing in Yorkie :)

Hello!
I'm interested in working on this issue. Could I take on this issue?

@window9u Sure! No problem. I think this issue is related to CRDT operation, so it will be good to get more context from the community.


Use mixins instead of html classes

This could be done either with Bootstrap's mixins or by using native css mixins. but presently the html markup are cluttered with bootstrap classnames. This could be much cleaner, if styles were applied to <p> and <aside> directly.

This is mostly addressed by c477b67 so closing this.
Copied relevant css from bootstrap rather than to move over to css preprocessing. Just seemed simpler that way. Plan to do likewise to address #3.


Allow DestinationCidrBlock to be Token[CidrBlock] for routes.

Fixed #13

Hey! So my git-fu is too weak to move this contribution over to develop instead of master (our new flow for our Monsanto repos is to only commit to develop and then PR that to master on releases), but I've manually reapplied and tested your changes and pushed them to develop, and also added you to our contributors file (MAINTAINERS) if thats OK with you? Thank you again!

Yeah, totally. Thanks for responding so quickly.


Published Bot won't work via Direct Channel. Bot responds "Value cannot be null. (Parameter 'key')"

A bot created and published by the Bot Framework Composer will work fine with the default Web Chat channel.
When adding the Direct Line channel and then performing requests against the API REST endpoint, the Bot will give the initial greeting and then onward responds only with "Value cannot be null. (Parameter 'key')".

Version
1.01
Browser

[X] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[X] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

download the Bot Composer project from this tutorial
remove the two HTTP requests (they are not needed for testing this issue)
deploy it accordingly and add the Direct Line channel
do a conversation via Postman or other means to talk with Direct Line channel

Expected behavior
The bot should give proper response and not the error message.
Screenshots
This is how the Resources on azure look like after deployment:

Could it be that an App setting is missing on the App Service?

Additional context
This is a continuation from this bug report: https://github.com/microsoft/BotFramework-Composer/issues/2240

@rubit0 , I have dowloaded your bot and tested it. It works fine in my side, the only change I did is to remove the httpsteps to the azure functions, because I don't have a azure function example. Could the issue be caused by the http request to azure functions? could you share more details on that? do you use any key to access the azure function urls?

Hey @rubit0 I was facing the exactly for a couple of days and luckly I could find out why this morning.
In my case what fixed was adding the "locale" field in the json request body when creating an activity. Here is how my POST request looks like:
POST https://directline.botframework.com/v3/directline/conversations/{conversationId}/activities
{
"from": {
"id": "customId",
"name": "customName",
"role": "user"
},
"locale": "pt-BR",
"recipient": {
"id": "bot",
"name": "Bot",
"role": "bot"
},
"text": "some text",
"textFormat": "plain",
"type": "message"
}
Hope this helps you somehow

@viivalerio I'm glad to hear that you got it sorted out on your side. Sadly I don't quite understand what you mean, when you start a new conversation, you simply do a POST request with no body: https://docs.microsoft.com/en-us/azure/bot-service/rest-api/bot-framework-rest-direct-line-3-0-start-conversation?view=azure-bot-service-4.0
Are you using a different API? I can't find anything where it says that you need to provide a json in the body of the request.

@viivalerio Oh wow now it works! Thank you!

@luhan2017 @@DDEfromOR I did submit the problem and solution to the documentation page: https://github.com/MicrosoftDocs/bot-docs/issues/1806
Big thanks again to @viivalerio in providing the fix!

@Danieladu @boydc2014 Do you have more comments for this issue ? sounds like LG language policy issue.

https://github.com/microsoft/botbuilder-dotnet/issues/4219 sdk fixed the issues . composer will adopt latest sdk fix.

composer has updated the sdk version to 4.10.0, so close this.


fix: progress bar is not shown for unauthorized user

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #51407

Thanks for your interest in contributing!
The linked issue has not been triaged and opened for contribution, yet. Thanks for your patience while we determine the best approach.

Thanks for your interest in contributing!
The linked issue has not been triaged and opened for contribution, yet. Thanks for your patience while we determine the best approach.
It's okay, thanks 👍

Thank you for your pull request.
The related issue has been closed, so I am closing this pr accordingly.
Please let me know if you think this PR has been closed by mistake.


Problem with Linter plugin setting display

Linter setting when Pieces plugin is off

Linter setting when Pieces plugin is on

Related to https://github.com/pieces-app/obsidian-pieces/issues/9#issuecomment-1642583920?

@nhan000 is this still happening for you?

Yes

Hello, so sorry for the late response on this. I believe this issue has been fixed by version 1.5.1. Going to close this issue now, please let me know if it is still broken! Thank you for reaching out about this.


Add PartiallyInvalid Route condition

What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
Fixes documentation on HTTPRoute filters for when incompatible filters are present.
Adds PartiallyInvalid Route condition with one example Reason, "IncompatibleFilters"
This condition can be used in cases where cases where some configuration is valid but some is not (so Accepted=True, but not everything is valid/supported)
Which issue(s) this PR fixes:
Fixes #1521
Fixes #1696
Does this PR introduce a user-facing change?:
Add PartiallyInvalid Route condition to reflect Route status that is partially unsupported or invalid for an implementation.

/ok-to-test

@sunjayBhatia just wanted to check in on the status of this one: is there any assistance we can provide to help move this one forward, as it's been sitting for some time?

@sunjayBhatia just wanted to check in on the status of this one: is there any assistance we can provide to help move this one forward, as it's been sitting for some time?

just lost track of it, should make some more changes soon 👍🏽

just lost track of it, should make some more changes soon 👍🏽

Ok! Thanks Sunjay 🤜🤛

would it make sense to also consider how reporting incompatible filters would work when filters are part of an HTTPBackendRef? Will conditions and reasons be the same?

Just checking in again @sunjayBhatia, do you need any help here to move this one forward?

@sunjayBhatia it appears to me in order to move this one forward there's some comments you'll need to look over. Sorry about how long it's taking, I'm doing a roundup of older PRs to see if we can start shoring some of these up. Let us know how we can best help you in this :vulcan_salute:

Hi @sunjayBhatia Please see my review.
In addition to the inline comments:
Currently, in httproute_types.go, there are a number of comments like below:

// Unknown values here must result in the implementation setting the
// Accepted Condition for the Route to status: False, with a
// Reason of UnsupportedValue.

Considering the new PartiallyInvalid condition, would it make sense to update them?

Feels like we should find a place to abstract this sort of thing out in the top-level Route documentation or otherwise rather than having to say this on each individual field, similar for the existing UnsupportedValue docs

Hi @sunjayBhatia Please see my review.
In addition to the inline comments:
Currently, in httproute_types.go, there are a number of comments like below:

// Unknown values here must result in the implementation setting the
// Accepted Condition for the Route to status: False, with a
// Reason of UnsupportedValue.

Considering the new PartiallyInvalid condition, would it make sense to update them?

Feels like we should find a place to abstract this sort of thing out in the top-level Route documentation or otherwise rather than having to say this on each individual field, similar for the existing UnsupportedValue docs

for reviewers, take a look at https://github.com/kubernetes-sigs/gateway-api/pull/1540/commits/9b37a3e6da23b5dfe07ae7f3becce8f54085d2c5, put the documentation about partial invalidity in the route status section doc

One thing for reviewers/participants on this issue, do we have a document where we state explicitly that implementations "MUST" try to reconcile/program/process a whole resource, regardless of whether they encounter an invalid value etc?
Seems like that is missing from https://gateway-api.sigs.k8s.io/concepts/guidelines/ but could be a worthy addition

I'm happy with this as it stands today, so I'll approve and hold.
/approve
/hold

@sunjayBhatia from what I can tell, there's a couple open comments holding this up and we need a rebase in order to move forward. Let us know how we can be helpful with this one to keep it progressing? It's more than half a year old now and if there are some ways we can help pull this one over the finish line let us know? :thinking:

https://github.com/kubernetes-sigs/gateway-api/pull/2150 supercedes this so can close this one

re: this comment: https://github.com/kubernetes-sigs/gateway-api/pull/1540#discussion_r1239173818


[EnzymeTestUtils] Mark 1.8 batch test as failing

1.9+ fix requires jll bump with https://github.com/EnzymeAD/Enzyme/pull/1823

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.43%. Comparing base (90e07c1) to head (8fc3d1f).
Report is 4 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1379       +/-   ##
===========================================
+ Coverage   75.39%   93.43%   +18.03%
===========================================
  Files          35        7       -28
  Lines       10653      259    -10394
===========================================
- Hits         8032      242     -7790
+ Misses       2621       17     -2604

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Lint code to conform with pep8

Overview
This PR lints the code so it would conform to pep8 by doing the following:

Ran ooipy/ and setup.py through black
Ran ooipy/ and setup.py through isort
Ran ooipy/ through flake8 and fix as needed.
Updated .pre-commit-config.yaml for lint test to run with updated tools.

@John-Ragland and @FelixSchwock now the pre-commit works great. In your development environment you should install pre-commit. This way, everytime you make changes and try to commit, it will lint the whole code for you before you can commit.
Installing pre-commit:

$ conda install -c conda-forge pre-commit
$ pre-commit install


Error in render: "TypeError: Cannot read property 'Queue' of undefined"

I get the following error:
Error in render: "TypeError: Cannot read property 'Queue' of undefined"

I have same issue! @rahmanusta and how about app list? Does it rendered?

just install latest version and all is ok


typescript: Allow line breaks between switch cases

Input:
switch (n) {
  case 1:
    break;

  case 2:
    break;
}

dprint output:
switch (n) {
  case 1:
    break;
  case 2:
    break;
}

Prettier output: (preserves)

One deviation... I thought it was appropriate to remove the blank line when the switch case has no body. For example:
switch (n) {
  case 1:
    break;

  case 4:

  case 2:

  case 3:
    break;
}

// formats as
switch (n) {
  case 1:
    break;

  case 4:

  case 2:
  case 3:
    break;
}


chore: use async_sessionmaker

See: https://docs.sqlalchemy.org/en/20/orm/extensions/asyncio.html#synopsis-orm.
This allows mypy to properly see types returned by session.execute() as being async, etc.
/deploy

You can access the deployment of this PR at https://renku-ci-ds-89.dev.renku.ch

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 21 (85.71%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.06%) to 90.365%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

components/renku_data_services/crc/db.py
16
17
94.12%

components/renku_data_services/storage/db.py
2
4
50.0%

Files with Coverage Reduction
New Missed Lines
%

components/renku_data_services/crc/db.py
1
89.05%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
2598

Relevant Lines:
2875

💛  - Coveralls

Tearing down the temporary RenkuLab deplyoment for this PR.


Create correlation plot function

I'm working on the documentation for the python version of the function! 😀

Let's think of adding some auxiliary inputs as well to the function

For e.g. 'shape = "circle"' could be a non-mandatory input with default value as circle. This would plot filled circles as the correlation matrix. The user could switch to squares (heatmap style) by passing 'shape = "square"'


feat(ci) add line size checking to the CI

closes #359
My idea with the exclude list is that we'll slowly take files off of it as time goes on. Currently, there are 343 lines in violation left after the current changes. I'll get through the rest of them in a follow-up PR.
Also, excuse the Graphite thing, I was just curious to see what it'd look like. Maybe this could be thought of as a micro-stack lol, where I implement the base feature as one stack, and fix up the lines as a second 🤔 .
I don't think there's much point in going through Graphite right now unless the PR is a much larger feature set than this small tidying PR.

#360  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Rexicon226 and the rest of your teammates on  Graphite

if we add this to CI, wont we need to fix all of the line lengths so that CI will pass on main (otherwise it will fail and we wont be able to merge anything?)

if we add this to CI, wont we need to fix all of the line lengths so that CI will pass on main (otherwise it will fail and we wont be able to merge anything?)

no, see the exclude list. i don't think it's reasonable to move everything in one go, I'll slowly be moving files over to the new style.


[DOCS]: Create Tutorial for configure GitHub Protected branches for test automation.

Describe alternatives you've considered
Would you please share your clear and concise description of any alternative/similar documentation you've considered.
Additional context
Would you please share any other context or screenshots about the documentation request here.
Prevent harmful code hitting the main branch by having passing tests as a requirement.

The GitHub Protected Branches tutrorial is now in the document framework.
Content needs creating.


Investigate grouping media queries together

The size of generated bundles can be reduced by grouping media queries together. For example, the following snippet:
const Box = styled.div`
  :hover {
    @media (min-width: 600px) {
      color: red;
    }
  }

  :first {
    @media (min-width: 600px) {
      color: blue;
    }
  }
`;

Could be transformed into the following code during build (possibly by Babel):
const Box = styled.div`
  @media (min-width: 600px) {
    :hover {
      color: red;
    }

    :first {
      color: blue;
    }
  }
`;

Good idea. At the moment https://github.com/thysultan/stylis.js is what we use to handle preprocessing the CSS, maybe bring it up over there?

@probablyup Thank you for the suggestion, I've just opened an issue over there.


Wait for Database to initialize if managed DB

Environment
k3s version v1.25.4+k3s1
Ubuntu 22.04.1 LTS
AWX Operator: 1.1.3
Description
While deploying AWX getting below error
"Wait for Database to initialize if managed DB"
--------------------------- Ansible Task StdOut -------------------------------
TASK [installer : Wait for Database to initialize if managed DB] ***************
task path: /opt/ansible/roles/installer/tasks/database_configuration.yml:206

{"level":"info","ts":1673530585.4271903,"logger":"proxy","msg":"cache miss: /v1, Kind=PodList err-Index with name field:status.phase does not exist"}
{"level":"info","ts":1673530590.96029,"logger":"proxy","msg":"cache miss: /v1, Kind=PodList err-Index with name field:status.phase does not exist"}
{"level":"info","ts":1673530596.5346725,"logger":"proxy","msg":"cache miss: /v1, Kind=PodList err-Index with name field:status.phase does not exist"}
{"level":"info","ts":1673530602.0591655,"logger":"proxy","msg":"cache miss: /v1, Kind=PodList err-Index with name field:status.phase does not exist"}
......................
........................

@ccie29824
To ensure your PostgreSQL is up and running. Please provide following information.
kubectl -n awx get pod,pv,pvc
kubectl -n awx describe pod awx-postgres-13-0

In addition to above, if you have made any customization on your awx.yaml or other yaml files, please clarify your customization.

I am using K3s with 2 worker nodes with Ubuntu as OS. K3s is customized by using MetalLb & Nginx Ingress instead of default K3s.

AWX Hostname: awx.website.local (Not using any SSL certs)
using default passwords - Ansible123!

@ccie29824
Thanks, I believe you can see the error about /data/postgres-13 that has to be fixed in your screenshot.
In the first place, since you are on multi-noded cluster, you should use any shared storage like NFS, iSCSI, Ceph, or GlusterFS.
I mean, the hostPath based PV that used in my guide can work without trouble in single-node cluster only, and can not work in multi-noded cluster. You can not use the PV in my guide as-is.
Refer to the Kubernetes documentation to know what PV is and what hostPath is.

https://kubernetes.io/docs/concepts/storage/persistent-volumes/#types-of-persistent-volumes
https://kubernetes.io/docs/concepts/storage/volumes/#hostpath

It's difficult for me to provide step-by-step guide to solve your issue since the type of PV that should be used in your cluster is highly depends on your environment.

Thanks. I tried using Longhorn-based storage but not working.

Hmm Longhorn should work. Maybe you're missing something.
You just said "not working" but this doesn't give any details; if your Longhorn is working properly, then the cause is completely differ from /data/postgres-13.
In any case, you should investigate the cause first with the kubectl describe command and read Events carefully (not just copying and pasting it here).
This is completely out-of-scope of my repo, but ensure *_storage_class are specified correctly.
I've never tried that but here is an example.
spec:
  ...
  postgres_storage_class: longhorn
  postgres_storage_requirements:
    requests:
      storage: 8Gi

  projects_persistence: true
  projects_storage_class: longhorn
  projects_storage_size:  2Gi
  # Below is not required to use longhorn
  # projects_existing_claim: awx-projects-claim
  ...

It is important to build on small successes.
I recommend starting with a small test Pod and Longhorn to make sure Longhorn is working properly before using it with AWX.


添加gpg插件

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.党参 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove horizontal scrolling in mobile

That typical problem where the site is scrolling horizontally due to some weird padding or margin.

I've fixed this by reworking the mobile menu completely.

I've fixed this by reworking the mobile menu completely.


Added save time feature to stopwatch, changed ram bar graph color to red

Nice, though I found one bug in the stopwatch change: if you save some times, then reset the watch, the times will be cleared out, which is expected. But as soon as you save another time, all the times that were cleared re-appear.

Ah, yes thanks for the report. Gonna fix it real quick


CHP: Add explicit width and height for image elements.

Add height and width for images improves page rendering.
I presume there is a Hugo feature to assist with this.

@pdpinch yes, we can achieve this via Hugo image processing and in order to process an image we must access the image as either a page resource or a global resource (as stated here).
Images can be accessed as global resources if they are placed in assets/ directory but our images (of base-theme and www theme) are placed in static directory, outside assets so I'm not sure whether we will be able to process these images via Hugo


Failing to Launch node in docker container

Hello everyone, I am hoping that you guys can help me out. I have a 2 BFLY-U3-23S6C-C. I have a research robotics project where I need to use these cameras to take photos. Currently the main ROS instance is Ubuntu 22 running ROS Humble Hawksbill. Since this driver is not compatible with that configuration, I want to build a docker container to run it and then I can pipe the photos out from there.
Here is my Dockerfile:
# This based off an auto generated Dockerfile for ros:ros-base
# generated from docker_images/create_ros_image.Dockerfile.em
FROM ros:kinetic-ros-base

# install bootstrap tools
RUN apt-get update && apt-get install --no-install-recommends -y \
	apt-utils		\
    build-essential \
    python-rosdep \
    python-rosinstall \
    python-vcstools \
    && rm -rf /var/lib/apt/lists/*

# bootstrap rosdep
RUN useradd -ms /bin/bash sparkslab
RUN rm /etc/ros/rosdep/sources.list.d/20-default.list
RUN rosdep init
RUN runuser -l  sparkslab -c 'rosdep update'
# install ros packages
RUN apt-get update && apt-get install -y --no-install-recommends \
    ros-kinetic-ros-base \
	usbutils		\
	tree			\
	vim				\
	udev	   		\
	wget    		\
	libunwind-dev		\
	ros-kinetic-cv-bridge   \
	ros-kinetic-image-transport

RUN rm -rf /var/lib/apt/lists/*

#getting the Spinnaker SDK installed in the container
#the readme lists these dependencies
RUN sudo apt-get update && apt-get install -y --no-install-recommends \
	libavcodec-ffmpeg56		\
	libavformat-ffmpeg56	\
	libswscale-ffmpeg3		\
    libswresample-ffmpeg1	\
	libavutil-ffmpeg54		\
	libusb-1.0-0

#get the ROS & SDK driver into the container
COPY ./src/spinnakerSDK /spinnakerSoftware/spinnakerSDK
COPY ./src/install_driver.sh /spinnakerSoftware/install_driver.sh
RUN chmod +x /spinnakerSoftware/install_driver.sh

System Description
Camera Name and Model: BFLY-U3-23S6C-C
Operating System:  Docker ROS kinetic image has ubuntu 16
Spinnaker Version:  <IP_ADDRESS>
ROS Version: Kinetic
Computer details
Processor: Intel 1165G7
RAM: 32GB
For USB 3.0 cameras:
On same USB 3.0 bus or different buses?
Same Bus
Is the USB 3.0 hub externally powered?
No Hub yet
Do the cameras work with SpinView?
Yes on baremetal Ubuntu 22. No in docker, cause I don't want to install it. Correct me if this is a folly.
Describe the bug
A clear and concise description of what the bug is.
I load up the Container with all the software that is mentioned by the spinnaker SDK README, then I load all the software for this driver.
I start up the container and install spinnaker SDK. Then I go through the README for this driver and follow the install and run instructions.
Error Messages
# roslaunch spinnaker_sdk_camera_driver acquisition.launch
[acquisition.launch] is neither a launch file in package [spinnaker_sdk_camera_driver] nor is [spinnaker_sdk_camera_driver] a launch file name
The traceback for the exception was written to the log file

if you can tell me where this log file is I would appreciate it.
Any help is much appreciated! I hope that this benefits others as well.

This sounds like a very fundamental Ros issue. Could be something as simple as sourcing the right setup.bash or running the command from the correct folder.
I'd suggest making sure you are able to run everything first, maybe in a Virtual Box...

Turns out a bunch of stuff was out of whack. Wrong version of ROS, wrong version of spinnaker SDK, wrong version of Ubuntu. I decided to build my own driver. I was woefully ignorant when I made this issue and now I'll just close it up


feat: refactoring to the new schema

❯ grpcurl -plaintext  localhost:8080 list
grpc.reflection.v1.ServerReflection
grpc.reflection.v1alpha.ServerReflection
schema.v1.ServerAnalyzerService
schema.v1.ServerConfigService

This PR is pinned against buf.build remote schema update to this version
✅ Checks

[ x] My pull request adheres to the code style of this project
[x ] My code requires changes to the documentation
[x ] I have updated the documentation as required
[x ] All the tests have passed

ℹ Additional Information

Great work ! Left 1 comment/suggestion and the linter report 2 failure checks

Thanks, update


Motions: set filters reset themselves

Describe the bug
If you work with several tabs, filters in motions may be reset when switching between tabs.
How to Reproduce
The reproduction is not clear. I encountered this problem during an event. I had a filtered motion list (by category) open in one tab, a motion detail view in the second and the amendment list of the open motion in the third. It happened several times that the filtering was lost when switching to the motion list. I could still briefly see how it disappeared when the tab was opened.
Assumption: It could be due to the reactivation of a tab that is in sleep mode because it has not been used. It is possible that the filtering disappears when it is reactivated.
If I find a clean reproduction, I will add it.
Expected behavior
Filtered lists should stay active, if a user switches between tabs. Important, this should not affect the possibility to use different filters on different lists.
Also I'm not sure, that this only affects the motion list with the category filter. I guess it's a general problem.

Updated reproduction/description:
Some of the filters are not saved over more than one tab/with a reload
Repro:

in motion list select a filter
Open a election-list in a new tab
in the new tab navigate to the motion-list
The Filter is not selected anymore

These filters are affected (as far as I can see):

Category
Motion block
Comment
Tags
Motion editor
Spokesperson

I can reproduce the problem and looked and debugged a bit. But I didn't find the reason of this failure.


Bug Report

Report Message

Some commands still have the paginate argument.

Report Metadata
Bug Reported By: PokestarFan#8524<PHONE_NUMBER>14224641)
Bug Reported At: Monday, February 7, 2022, 5:28:42 PM Eastern Standard Time

Fixed.