[SPARK-32785][SQL] Interval with dangling parts should not results null

What changes were proposed in this pull request?
bugfix for incomplete interval values, e.g. interval '1', interval '1 day 2', currently these cases will result null, but actually we should fail them with IllegalArgumentsException
Why are the changes needed?
correctness
Does this PR introduce any user-facing change?

yes, incomplete intervals will throw exception now
before
bin/spark-sql -S -e "select interval '1', interval '+', interval '1 day -'"

NULL NULL NULL

after
-- !query
select interval '1'
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.catalyst.parser.ParseException

Cannot parse the INTERVAL value: 1(line 1, pos 7)

== SQL ==
select interval '1'

How was this patch tested?

unit tests added

cc @cloud-fan @MaxGekk @maropu @HyukjinKwon thanks for reviewing

Test build #128248 has started for PR 29635 at commit 6d27597.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32876/
Test PASSed.

Test build #128248 has finished for PR 29635 at commit 6d27597.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128248/
Test FAILed.

Test build #128254 has started for PR 29635 at commit eb99bd5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32882/
Test PASSed.

Test build #128261 has started for PR 29635 at commit ae6d9be.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32889/
Test PASSed.

Test build #128254 has finished for PR 29635 at commit eb99bd5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128254/
Test PASSed.

Test build #128261 has finished for PR 29635 at commit ae6d9be.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128261/
Test PASSed.

can we add a migration guide?

OK, are you targeting this to 3.0 or not?

OK, are you targeting this to 3.0 or not?

Test build #128293 has started for PR 29635 at commit daed4e6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32919/
Test PASSed.

Test build #128293 has finished for PR 29635 at commit daed4e6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

thanks, merging to master!


Refine Websocket reconnection

[ ] Query the server and initialize the data ( or update if any) on every WebSocket connection
[ ] Implement Observable and use buffer

I added WebSocketService under service. This basically wraps ReconnectingWebSocket  and takes care of the unsent data so that it sends all of them on the successful reconnection.


Adding a Volume increase or decrease extension

User can increase or decrease his/her tab volume

Closing this as exists #1224


Remove file_scan_ignore_directories

The Problem/Issue/Bug:
The setting for file_scan_ignore_directories is Drupal default settings.php. There is no need to override it in ddev.
How this PR Solves The Problem:
Manual Testing Instructions:
Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I configured an existing project with ddev config. The file_scan_ignore_directories was configured in settings.php with an additional folder. It was overwritten by settings.ddev.php.

I guess that stanza is directly from default.setting.php. It could certainly be left out here, but as noted above, many projects don't have a settings.php, so ddev generates one for them. Using this same template.
I'm sure you're already aware that there are a couple of easy ways for you to deal with this for your project:

Take over the settings.ddev.php by just removing the #ddev-generated line and making it your own.
Make the change to this section after the include of settings.ddev.php

If it's reasonable to have a default file_scan_ignore_directories, then we should probably leave it in there, because it serves many people as it is.

Thanks for the hint. I didn't know that.

I think this is the correct thing to do. The stuff shown as defaults is just an example config, and we have no business adding it to settings.ddev.php


add guzzle

Please review.
I'm not really sure about some solutions in tests (but they are green, at least :wink: )

Superseded by #6


Give 'AzureWebJobsDashboard' property more descriptive name

Hi,
currently in local.settings.json we have a property called AzureWebJobsDashboard. From my understanding(and what people connected to Azure Functions say) it allows you to disable logging data to the Monitor tab(and probably breaks the dashboard of a Function App if not provided?).
Is it possible to somehow fix its name so it better describes its purpose? In the current shape it seems to make lots of confusion.
Best regards,
Kamil

I agree the name is not ideal but we're going to leave it as is. Over time this setting will be less important as app insights becomes the default monitoring experience.


[RSDK-1155] remove build target conflicts

Changes:

Update Makefile to support building concurrently for multiple platforms
Update .canon.yaml to have own unique names to prevent conflicting with rdk canon config & use same images as RDK
Add FFmpeg directory to .gitignore
Remove make test target as it didn't work (likely due to CGO_LDFLAGS). It is also unnecessary as go test works just fine when run outside of make

LGTM.
Should we update the README build instructions?

Good call, Done


Cluster ‘xxx’ Not Found Error When Adding Fluentd Access Log to Listener

Hi everyone,
I’m encountering an issue when trying to add a Fluentd access log to a listener in Envoy. I receive the following error:
[2024-10-09 18:05:42.405][75338004][warning][config] [source/extensions/config_subscription/grpc/grpc_subscription_impl.cc:138] gRPC config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) testlstnrnaJDny: cluster 'abc' was not found

However, the Fluentd cluster abc is clearly added, as shown below:
{
    "dynamic_active_clusters":
    [
        {
            "cluster":
            {
                "@type": "type.googleapis.com/envoy.config.cluster.v3.Cluster",
                "alt_stat_name": "aasdaa",
                "load_assignment":
                {
                    "cluster_name": "abc",
                    "endpoints":
                    [
                        {
                            "lb_endpoints":
                            [
                                {
                                    "endpoint":
                                    {
                                        "address":
                                        {
                                            "socket_address":
                                            {
                                                "address": "<IP_ADDRESS>",
                                                "port_value": 80
                                            }
                                        }
                                    }
                                }
                            ]
                        }
                    ]
                },
                "name": "abc",
                "type": "STATIC"
            },
            "last_updated": "2024-10-09T15:05:42.392Z",
            "version_info": "12a56d24a2dca4e5778852ecdf1aa919a78e9ca35f729bdb9a7c71998cc288dc"
        }
    ]
}

Despite the cluster being active and correctly configured, Envoy fails to recognize it when applying the listener configuration.
Any insights or suggestions on what might be causing this discrepancy would be greatly appreciated. Thanks in advance for your help!
Note: When I assign the same cluster abc to a route, it works without any issues.

yeah I'm not sure but I could imagine checkActiveStaticCluster being too narrow of a check
https://github.com/envoyproxy/envoy/blob/main/source/extensions/access_loggers/fluentd/config.cc#L42
cc @ohadvano @wbpcode

yeah I'm not sure but I could imagine checkActiveStaticCluster being too narrow of a check https://github.com/envoyproxy/envoy/blob/main/source/extensions/access_loggers/fluentd/config.cc#L42 cc @ohadvano @wbpcode

Yeah, I think the checkActiveStaticCluster is too strict for the logger.
Hi, @sefaphlvn I think this feature require you config the cluster in the bootstrap directly. It is typically too strict for this feature.
Hi @ohadvano could you take a look, thanks?

Thank you for the clarification!
If configuring the cluster in the bootstrap is indeed a requirement for this feature, it would be great to mention this explicitly in the documentation to help avoid similar confusion for other users.
Thanks again for your support!

Thank you for the clarification!
If configuring the cluster in the bootstrap is indeed a requirement for this feature, it would be great to mention this explicitly in the documentation to help avoid similar confusion for other users.
Thanks again for your support!

Yeah, I will try to release this limitation. If it's impossible, then we will update the docs. And thanks for the report. :)

Hi @ohadvano could you take a look, thanks?

@wbpcode, I'm out for a while so can't work on a fix at this moment. If possible, please update docs that it's only supported for with static clusters. I can try see how to make it work with dynamic after I'm back.

Would this be a beginner-friendly issue? Would it be just a matter of creating a more relaxed check (disregarding the "staticness" of a cluster)? Like, just checking if it's in the active clusters collection in the cluster manager?
Given that @ohadvano is out for now, I'd be happy to give it a shot if it's a simple issue.


Allow executing non 'all-in-one' binary software. Fixes #1

This PR also includes some bash style improvements

Example: ./docker-execute-amiga.sh reshoot reshoot_rc2.exe

Thank you, Sebastian!


/balance doesnt work

Whenever i try the /balance command nothing happens. Ive looked in the console and it doesnt show any errors. The mods on the server are: anti-ghost, appleskin, architectury, balm fabric, buildguide, c2me fabric, crafting tweaks, diggusmaximus, fabric api, language kotlin, fly command, gp base, gp currency, gp market, gp signshop, gp utilities, high level enchants, lazy dfu, lithium, luckperms, minecraft command permissions, mining cooldown fix, pal, plasmavoice, shulker box tooltip, speed carts, starlight, stendhal, world edit mod, Xareros minimap and world map mod.
[04:57:37] [Server thread/INFO]:  testing the command /balance
[04:57:38] [Server thread/INFO]: [STDOUT]: Enchant scn start
[04:57:38] [Server thread/INFO]: [STDOUT]: Enchant scn start
[04:57:39] [Server thread/INFO]: [STDOUT]: Enchant scn start
[04:57:39] [Server thread/INFO]: [STDOUT]: Enchant scn start
[04:57:39] [Server thread/INFO]: [STDOUT]: Enchant scn start
[04:57:42] [Server thread/INFO]: [STDOUT]: Enchant scn start
[04:57:42] [Server thread/INFO]: [STDOUT]: Enchant scn start
[04:57:44] [Server thread/INFO]: [STDOUT]: Enchant scn start
[04:57:44] [Server thread/INFO]: [STDOUT]: Enchant scn start
[04:57:52] [Server thread/INFO]:  test done
latest.log

Please provide a full log that starts from server start
Provide the version of the mod alongside the Minecraft version

I am also having this issue, here is my log from server start.
Mod Versions:
Gunpowder Base: <IP_ADDRESS>
Gunpowder Currency: 1.0.8
Minecraft: 1.18.1
Im also running Fabric 1.18.1 with Fabric API 0.46.6
latest.log

Does the issue persist if you remove all other mods?

I removed everything and it still does not work.


influx cli cmd tested

At thsi time we have no tests around the root cli cmd. This is no bueno. This issue is to track this to make sure we touch that up and provide that test coverage to catch issues with root lvl persisted flags/env vars like token.
would catch issues like the ones found here: #16875

note: refactored a bunch of influx cli to use the entire cmd to test. Meaning we test influx bucket find instead of bucket find, tieing that missing link.
What's not donezo?

adding tests to validate the token/host/globals
remove global dependencies al-togehter from child cmds


[plplot] add support for pango and Cairo

Is your feature request related to a problem? Please describe.
I would like to start testing my project Gtkmm-PLplot with an MSVC based workflow using Vcpkg but its PLplot port doesn't come with the extcairo device, which is a requirement for my project.
Proposed solution
Add support for the extcairo device to this port. I am not familiar with Vcpkg at all, so I naively added pango and Cairo as dependencies to the CONTROL file as well as -DPLD_extcairo=ON to portfile.cmake, but the device doesn't get built as it cannot find the pango and Cairo dependencies due to pkg-config missing...
Describe alternatives you've considered
Nothing really: building the entire gtkmm3 and plplot stacks during each CI run doesn't sound like a good solution.
Additional context
Thanks in advance for looking into this. I will gladly try any suggestions or fixes.

Hi @tschoonj
Thanks for posting this issue.
Could you please help post the errors that you met?

Hi @NancyLi1013
The output log shows the following lines:
-- WARNING: pango not found because pkg-config not available.
-- WARNING: pkg-config not found. Setting cairo drivers to OFF.

Note that this doesn't make the build fail: it will just proceed without trying to build the Cairo drivers.
I applied the following diff:
diff --git a/ports/plplot/CONTROL b/ports/plplot/CONTROL
index 67a70e365..1225c86e4 100644
--- a/ports/plplot/CONTROL
+++ b/ports/plplot/CONTROL
@@ -1,9 +1,9 @@
 Source: plplot
 Version: 5.13.0
-Port-Version: 9
-Build-Depends: freetype, zlib, libpng, bzip2
+Port-Version: 10
+Build-Depends: freetype, zlib, libpng, bzip2, cairo, pango
 Description: PLplot is a cross-platform software package for creating scientific plots whose (UTF-8) plot symbols and text are limited in practice only by what Unicode-aware system fonts are installed on a user's computer.

 Feature: wxwidgets
 Build-Depends: wxwidgets
-Description: plplot wxwidgets module
\ No newline at end of file
+Description: plplot wxwidgets module
diff --git a/ports/plplot/portfile.cmake b/ports/plplot/portfile.cmake
index 4e7a55799..b418cef11 100644
--- a/ports/plplot/portfile.cmake
+++ b/ports/plplot/portfile.cmake
@@ -37,6 +37,7 @@ vcpkg_configure_cmake(
         -DDRV_DIR=${CURRENT_PACKAGES_DIR}/debug/bin
     OPTIONS_RELEASE
         -DDRV_DIR=${CURRENT_PACKAGES_DIR}/bin
+	-DPLD_extcairo=ON
 )

 vcpkg_install_cmake()

Many thanks for looking into this!


value is not a function

Hi. I've just get an error:
TypeError: value is not a function     at DialogflowApp.invokeIntentHandler_ (/path/to/project/node_modules/actions-on-google/assistant-app.js:2308:31)
It happend after user chose some option from List. What is it and how to fix this?

 I just forgot to set appropriate action name and handler for my action. And everything works fine.


improve the training of the analysis server snapshot

We currently train the analysis server by analyzing //pkg/analyzer_cli. This my yield inconsistent results depending on the state of the analysis driver cache - we could either be optimizing the code path that involves parsing source, or the path for deserializing summary files.
We should likely enhance the --train-with param to ignore reading from the driver cache initially, and then make another pass where we do read from the driver cache. Perhaps we can do this by using a random value for the analyzer driver seed.

Another option here is to use a new, temporary directory for the analysis driver cache when running with --train-with.

fixed


[fixes #6541]. omit prefix to avoid doubling up when key gets set

Fix for issue: https://github.com/balderdashy/sails/issues/6541.
The prefix was being included twice in the redis store.

@johnabrams7 has this been discussed/reviewed yet for merge?

@travispwingo Sorry for the delay, we reviewed and confirmed this resolves the duplicate prefix for the redis session key in redis-cli console. Tested it with multiple simultaneous sessions without issues. Will have this included with a sails update shortly.


Refs #32339 -- Deprecated default.html form template.

This should be the last part of #15241:

Deprecate the default.html template.
Add a Div* renderer so folks can opt-into to the new div.html with a single setting.

[x] Deprecate form default template.
[x] Deprecate formset default template.
[x] Add new (transitional) renderer
[ ] Make sure release notes and docs make sense.

Plus bonus:

[ ] Update examples in docs and tests (if needed.)

@smithdc1: I added you as a collaborator on my fork, so we can push this forwards together.

Hi @carltongibson -- so the commits I've pushed are intended to resolve the formset action and make the code changes to add the new transitional renderer.
Therefore I think there's just doc changes left. A couple of comments here.

Release notes: This section is getting quite big, if it takes this much to explain what's going on is it still a small change? I grimace at making this suggestion, as it could be seen as me trying to push up my own PR. That's not my intent.
I made many of the doc changes in the original PR to change all the table based outputs to div ones. Maybe we just need a setting note at the top of each page, then we can bring across those changes. However, given there are many of them I suspect review time may be the issue here and I don't think we need them before the feature freeze?

@smithdc1 — thanks for the commits and comments. This is next™ on my list, and main focus now before next week.

I grimace at making this suggestion...

😄 No problems. For me, https://github.com/django/django/pull/15241 was getting too big to action, so multiple smaller steps is easier to get in. Let me have another look but, I suspect merging the deprecations, and then taking on the docs is easier than doing it all at once. We can continue to make docs fixes in the pre-release phase.

Let me know your thoughts. (Am I missing anything? Probable.)

I think the minimal viable product is (is this a term that's used more widely or just that I come across in my day job!):

To document the transitional renderers and to link the release notes to them. I envisaged this being something like [1]
To review for Nick's remaining comments (more release notes, maybe?)

Then I think a session or two (or three 😜) on the docs as a follow-up would round this off nicely — but that can be done more leisurely.

Super, let's take our time with those. The current docs are correct until Django 5.0 (so sometime in the next year? Ish?). Maybe 5.0 is the best time to get these in to avoid confusion of folk on the default renderer during 4.1/4.2. Opinions welcome.

Edit: I foolishly pushed before the PY38 failure showed up again, so I have that change pending.

I also spent time arguing with Black and formatting, I did not  find the solution to make this work :confused:
Thank you for pushing this forward. :superhero_man:
[1]
DjangoDivFormRenderer
---------------------

.. class:: DjangoDivFormRenderer

The same as :class:`DjangoTemplates` with :attr:`BaseRender.form_template_name` and :attr:`BaseRenderer.formset_template_name` set to ``'django/forms/div.html'`` and ``'django/forms/formset/div.html'`` respectively. This render allows for early opt-in to use new templates which render forms in ``<div>`` tags. These templates will become the default in Django 5.0 at which point this transitional renderer will be deprecated for removal in Django 5.2.

Jinja2DivFormRender
------------------

.. class:: Jinja2DivFormRenderer

As per :class:`DjangoDivFormRenderer` but inherits from :class:`Jinja2` to enable compatibility with the Jinja2 backend.

OK, so I think we're Not Far Off™.
Three commits (last two to be squashed, but left for easier reading):

5cfe4aa5731dc8eacc9b6949a21154b13a48da1b — Everything so far squashed, and rebased, and passing.
d37574307355e3869d830d478e6e73dfe09022ca — Suggestion for the docs for the transitional renderers and the release notes for that.
An alternate suggestion for the deprecation warning, which, whilst long, is I think clearer, and points folks to the release notes for more.

I tried thinking of a better way to capture possible extensions/uses of the default.html template, but I'm not sure we can do much better. Given both newness, and weirdness of possible extensions, I suspect heroic efforts to catch additional usages won't be paid back in terms of number of cases caught. However, still open to ideas.
I'll leave this for now. Still time for final tweaks 😃

possible extensions/uses of the default.html template

I think the only way we'd capture it is if we put something in the template to raise the warning. However, we previously discounted that approach see https://github.com/django/django/pull/15241#pullrequestreview-934786953
Anything else seems too much effort and even then I'm not sure we capture all cases. I guess we could try and capture elsewhere in the template logic but what if... custom tag or jinja or ....
I've left a few minor comments.

OK, thanks both. Updated, squashed, rebased.

Merged in d126eba3637d84caa80fa4258e2e59ef07a8260c


Message Bus Integration

Happy to help, or if you wanna talk through designs etc - just come grab me :)

Great, I've got a few ideas and it would be great to have some feedback :-)

Azure Service Bus integration released with version 5.0.0.


Report search results in a treeview

VSCode Version: 1.11.1
OS Version: Windows 10

It would be nice if the search results panel had the ability to show search results in a a tree view that matches the layout of the folder structure of your project.
I'm working in a JS React project and a lot of the search results will report back the file index.js.  A file with that name is all over the place by necessity.  The location of the file is listed next to the name, but it's not as intuitive as a treeview would be.
Thanks,
Matt B.

#20224

Thanks for directing me to the duplicate.  It's good to know I'm not the only one who recommended it.


"First" filter fails with expressions

Given this data:
$scope.types = [
    {
        "name": "type1",
        "default": false
    },
    {
       "name": "type2",
       "default": true
    }
];

This failed:

I had to revert to:

As a test I also did:

but didn't seem to work either
This was working on 0.4.5 but not in 0.5.2

Can you please provide some jsbin/fiddle example, @thisischrisj ?

Here you go
0.4.4: http://jsfiddle.net/jg1k73xm/1/
0.5.2: http://jsfiddle.net/jg1k73xm/2/
I know I mentioned v0.4.5 but I couldn't link to the src. I checked with 0.4.6 but got the same result as 0.5.2

Thanks @thisischrisj,
It's been changed after this discussion: https://github.com/a8m/angular-filter/issues/19#issuecomment-55025048
Thoughts?

I can see the logic and my second example shows that reasonable workarounds exist. I would just recommend updating the documentation as this still references the ability to use expressions with first, last, etc...
It probably wouldn't hurt to mention your decision on "only filter without an arguments return an object" too. This would help users understand expected return types.

Awesome @thisischrisj, thanks!
Feel free to PR.

While 'first' seems to be fixed, the same problem seems to apply to 'last' when it's an array of objects not a simple array. Using version 0.5.17.


Very slow requests ?

Hello!
I have tried your API wrapper but it looks very slow with the example code from here
You had 800ms without burst mode and I get about 10000ms to 20000ms, here is my code:
const express = require('express')
const cors = require('cors')
const app = express()

app.use(cors())

const { Kayn, REGIONS } = require('kayn')

const kayn = Kayn('RGAPI-my-api-key')({
  region: REGIONS.EUROPE_WEST,
  locale: 'en_US',
  debugOptions: {
    isEnabled: true,
    showKey: false
  },
  requestOptions: {
    shouldRetry: true,
    numberOfRetriesBeforeAbort: 3,
    delayBeforeRetry: 1000,
    burst: false,
    shouldExitOn403: false
  }
})

app.get('/summoner', async function (req, res) {
  try {
    console.time('kayn')
    const kalane = await kayn.Summoner.by.name('Kalane').region(REGIONS.EUROPE_WEST)
    const { matches } = await kayn.Matchlist.by
      .accountID(kalane.accountId)
    const gameIds = matches.slice(0, 10).map(({ gameId }) => gameId)
    const requests = gameIds.map(kayn.Match.get)
    const results = await Promise.all(requests)
    console.log(results[0], results.length)
    console.timeEnd('kayn')

    res.send(kalane);
  } catch (error) {
    console.log(error)
  }
})

app.listen(3000, function () {
  console.log('Example app listening on port 3000!')
})

Thanks a lot if you have any idea. (The previous code takes about 1500ms in burst mode).

Strange..
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/summoner/v4/summoners/by-name/Kalane +0ms
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/summoner/v4/summoners/by-name/Kalane +0ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matchlists/by-account/GVq0P4iqcbjrnCnyYv1svMosAiMiPMxrBaOAnIX81aDAXQ +883ms
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matchlists/by-account/GVq0P4iqcbjrnCnyYv1svMosAiMiPMxrBaOAnIX81aDAXQ +720ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matches/4162849766 +721ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matches/4162862179 +1ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matches/4161907704 +1ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matches/4161893073 +0ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matches/4146287779 +1ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matches/4146237421 +0ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matches/4146149969 +1ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matches/4146128826 +0ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matches/4145234282 +0ms
  kayn:request:outgoing [GET] => https://euw1.api.riotgames.com/lol/match/v4/matches/4145157629 +1ms
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matches/4162849766 +1s
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matches/4162862179 +3s
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matches/4161907704 +3s
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matches/4161893073 +3s
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matches/4146287779 +3s
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matches/4146237421 +3s
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matches/4146149969 +3s
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matches/4146128826 +2s
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matches/4145234282 +3s
  kayn:request:incoming:success https://euw1.api.riotgames.com/lol/match/v4/matches/4145157629 +3s
kayn: 25992.704ms

Using DEBUG=kayn:* I was able to determine where the requests were taking a while. I'll look into it. Thank you for the issue.

Actually, are you using the development key?
20 requests every 1 seconds(s)
100 requests every 2 minutes(s)
It would be slow in this case. Spread's better for higher limits.

Yes I currently only have a dev key. So should I always use burst mode with dev key ?

Yeah. I personally like doing burst: !(NODE_ENV === 'production).


[Backport - Newton] Override the check_firewall var in ceph role

This variable is required for ceph.ceph-common to function properly as
our ceph playbooks are not suppported by Ansible 2.1.5.
Connects rcbops/u-suk-dev#1552
(cherry picked from commit f03f90970d5fb514b9837c1546fc340d9bda7549)

recheck_cit_xenial

recheck_cit_xenial


Enable cooperatives to fund raise on open collective

I've personally participated in a few fundraising for different cooperatives in Brussels.
There is no platform for it. So people are building customs online forms to subscribe to their shares (e.g. Wilfried in Brussels).
And it seems like a natural fit for Open Collective.
A cooperative is effectively an open collective. They share the values of openness, transparency and participation. The only difference is that the backers actually get shares of the underlying legal entity and get a voice in its general assembly.
There isn't much missing for them to be able to use Open Collective. They could create a tier to buy shares of the cooperative. People should be able to select the quantity (which we already support with the Tier type ticket). The only thing missing is that they need the legal information of the subscriber of the shares, that is: legal address, national registry number, date of birth and phone number (note: this was for Belgium, different countries may have different requirements).
I talked earlier this week to @peteratomic from Resonate, a community owned music network. It's a cooperative and they just created an Open Collective.
They would be up to work with us to adapt Open Collective so that they could give their backers official shares of their cooperative. I think this could be a very cool experiment and story. I fundamentally believe that cooperatives are the new startups (slides from 2015 and a few twitter threads [1], [2], [3]). And we can help here.
So the only thing to make this happen is to add the option to request more user information when people want to order a special tier. That information should be stored at the user level and at the user-collective-tier relationship (because legal address may change over time and we need to keep a record). This feature will also be useful for people who want to give a physical reward for a given tier (typically asking the user's address to ship stickers, tshirts, and other swags).
In terms of interface, it's not clear to me if we want to ask for that info when selecting the profile or when filling the details of the order. The jury is out. Maybe @cuiki and @raulgrafico can chime in here.
I made some sketches:
Option 1: when selecting profile:

Option 2: when filling order details

@peteratomic can you confirm the minimum set of information that you would need to collect to be able to give your backers shares of the cooperative?

We already have a cooperative host on the platform. Graham is on our Slack - @xdamman maybe you should have a discussion with him about how they manage this?
I think we'd be better off building a generalisable feature, where Collective admins could set the info Collected, because co-op regulations will be different in different countries, and because this need is applicable to other situations, such as #1798, about collecting info like postal address from backers of tiers where they get a t-shirt as a reward.

Hi. Agreed - the requirements will be different in different jurisdictions. We've talked within Platform 6 about the possibility of using Open Collective for share issues (in the UK a co-op fundraise exercise is commonly called a "community share issue").
Three things came up for us as potential blockers:
One is the cost - OC is a bit more expensive to use than some of the other crowdfunding platforms that could be used (an example in the UK is crowdfunder.co.uk who I think handle some share issues for co-ops, and they will generally charge 3-5% over and above the payment processing fee, whereas if we did it through the Platform 6 host (where we are only taking 2%) that would be 7% plus the processor fees and other hosts charge 5%).  Also we could probably set up a share issue on our own website (Drupal and CiviCRM) pretty quickly and potentially only charge a fairly modest set-up fee plus processor costs. Whilst cost is not a blocker, it is a disincentive. Larger scale co-op share raises in the UK might use ethex
Secondly was the implicit transparency of the OC model. Some investors may prefer to be discreet, as is their right. AFAIK on OC that's not an option.
Thirdly was the need to collect additional data, and that's what this issue addresses primarily.
So, i think it's fair to say that we are very open to making this happen, interested and keen to engage and do whatever we can to help, because we like OC and what it is all about, and we want to see lots more cooperative economy activity.

Our current approach to using OC is to encourage pre-start cooperative projects (particularly where they don't yet have legal structure or bank account) to use the facility to fundraise and begin to pull their crowd together, and the plan is that this forms part of a wider package of support, so enabling a share raise on the same platform certainly makes sense.

And as @alanna is aware, we're keen to do more in partnership with OC over time, in terms of moving beyond simply finance-as-a-service and more into governance-as-a-service, especially Cooperation-as-a-Service, which we think may be of interest/value to soem of the open source projects already working with OC in terms of creating a sustainable business model.

I'd echo Graham's comments above. Here's an example of a share offer launched today for Equal Care Co-op - a platform co-op that I'm working with. https://www.ethex.org.uk/equalcare

It would be good if an existing open collective were able to morph(upgrade?) to a share offer enabled collective. This would allow the co-op to build a community of potential investors.

Another useful funactionality of an OC share offer would be the ability of the collective to act like an Escrow account - the host only releasing funds on the hitting of the target for minimum rise. You would also need the ability to return funds to applicants if the offer fails to meet the target; or the co-op rejects some or all of the application - it's common to cap applications and only issue some of shares applied for if a share offer is over-subscribed.

Happy to take part in any further discussion and as a licensed UK community shares practitioner can offer a UK perspective.

@Upperholme thanks for the feedback.

We offer the option for people to pay directly the host via bank transfer. In that case, the host has to manually record the transaction as paid when they received the funds. Because it’s a semi manual process, there is no 5% platform fee.

You can be anonymous/pseudonymous on Open Collective. You can create a different profile and use that to make the donation.

Exactly, hence the point of this issue :-) What info did you have to ask for the UK? Can you share the form that you used and an example of a receipt / official document that shows the ownership of the shares?

Thanks for responding to the points raised.
Regarding the issue of anonymity, to confirm, any additional data collected would need to not be publicly accessible, so that all that would be visible would be a username and the amount invested.
On the issue of what data is needed, @coopsmark would know chapter and verse as regards any regulatory requirement, but I think we'd need name and postal address as an absolute minimum, with the ability to handle for example an organisational investor (org name, name of nominated individual - the person holding the vote), and where a return on the investment might be being offered perhaps we'd want to collect bank account details in order to make interest/dividend payments. Date of birth and nationality may also be a requirement.
And then in specific projects may want to be able to collect other data (I'm thinking maybe gender, occupation, special needs, etc.) but this wouldn't necessarily be a must-have.

I wouldn't know what a "National Registry number" might be. In the UK individuals have a national insurance number, and incorporated organisations would have an ID number (although not unincorporated organisations).

Here is a generic share certificate, although there is no legal requirement in the UK to issue a certificate. Note that when we are talking about co-operatives issuing shares in the UK, we are only using the Co-operative Society or Community Benefit Society legal form and issuing withdrawable (not tradeable shares). Using a Company structure for a public offer of anything but publically tradeable shares would be illegal.
Generic Share certificate.docx

Typical information asked for on a share application:

Name, Address, Phone no., email

If applying on behalf of an organisation, the name of that organisation, registered no. and the name of a nominated individual.

The no./value of shares applied for

There would also normally be a check box to indicate that the applicant agrees to some statements, for example:
I have read the share offer document, including the risk factors.
[ ] I agree to be bound by the Terms and Conditions included in the Share Offer Document and Rules of xxxx Limited
[ ] I understand that the Board of xxxx Limited may reject my application, and are not obliged to tell me why it has been rejected
[ ] I consent to receiving formal notices by email and links to formal documents on xxxx's website.

You would also generally include a statement along the lines of:
"It is a condition of the offer that to ensure compliance with the Money Laundering Regulations 2003, xxxx Limited may at its absolute discretion require verification of identity of any person seeking to invest. "

If you want an accessible overview and reference of the use of withdrawable share capital in co-ops, then I recommend www.communityshares.org.uk

Just posting this too in case you haven't seen it. It's looking to revive an historic method of co-op finance of worker co-ops in the UK- using retained profit to gradually buy out investors by replacing their share capital with that of members who trade with the co-op. https://www.nesta.org.uk/report/platform-co-operatives/


Explosives crates

[ ] surplus explosives crate (claymore mine x5, M40 HIDP x2, M40 HEDP x2, M15 Frag x2, M12 Blast x2) Cost: $4000
[ ] claymore mines crate (x10) Cost: $3000
[ ] M15 fragmentation grenades crate (x6) Cost: $4000
[ ] plastic explosives crate (x3) Cost: $3000
[ ] breaching charge crate (x4) Cost: $4000
[ ] M74 Airburst Grenade Munition incendiary grenades crate (x6) Cost: $4000
[ ] M40 HEDP blast grenades crate (x6) Cost: $3000
[ ] M40 HEDP blast grenade box crate (x25) Cost: $10000
[ ] M40 HPDP white phosphorus grenades crate (x6) Cost: $3000
[ ] M40 HPDP white phosphorus grenade box crate (x25) Cost: $10000
[ ] M40 HEFA fragmentation grenades crate (x6) Cost: $3000
[ ] M40 HEFA fragmentation grenade box crate (x25) Cost: $10000
[ ] M74 airburst grenades crate (x6) Cost: $4000
[ ] M74 Airburst Grenade Munition fragmentation grenade box crate (x25) Cost: $10000
[ ] M74 Airburst Grenade Munition smoke grenades crate (x6) Cost: $3000
[ ] M74 AGM-Hornet Grenade Crate (x6) Cost: $4000
[ ] M74 AGM-Star Shell Grenade Crate (x6) Cost: $4000
[ ] M40 HIRR Baton Slug Crate (x6) Cost: $1000

Might try the breaching charge crate.


[Windows] After power loss OpenOrCreate fails

This happens because Windows does not remove the file despite DeleteOnClose.
The behavior on Linux and MacOS is unknown.

Universal fix is blocked by https://github.com/dotnet/runtime/issues/52700
See failure of https://github.com/lostmsu/PIDFile/commit/8734c011860bc8dba1337162c74f1cd4b49de641


BMC dump download test

[x] Create BMC dump

curl -c cjar -b cjar -k -H "Content-Type: application/json" -d "{\"data\": []}" -X POST  https://$BMC_IP/xyz/openbmc_project/dump/action/CreateDump

[x] Download BMC dump

curl -O -J -c cjar -b cjar -k -X GET https://$BMC_IP/download/dump/$ID

[ ] In review https://gerrit.openbmc-project.xyz/#/c/openbmc/openbmc-test-automation/+/23725/


Release on F-Droid

It would be nice if tudo is available on F-Droid too.

I think tudo doesn't currently pass the "no proprietary libraries" rule because of the mobile_scanner and in_app_update packages.
To be fair, neither of those packages are essential but removing them for F-Droid would require creating and maintaining an active branch.

Or even if you provide a direct .apk download, that would help.


Help popup everywhere

Implementation of a  component that takes links and labels
Add links on every page of a workspace
Remove usage sections of connections & database
Add a Help icon in the "create a connection" dialog

How/what to test
The easiest thing to do is to checkout the branch and check all pages

Hey @qgerome , I've just tested it and it works great.
Regarding wiki links :

for the connections section we should have three links (about connections / using in notebooks / using in pipeline)
for the notebooks section, I would replace the current links by a single entry to the dedicated notebooks wiki page

Apart from that, I would suggest the following (very minor) copy changes :

Replace "Based on the page you are on, we have selected some help topics that might be relevant to you." by "Suggested help topics", displayed as a title
Replace "Or visit the OpenHexa wiki for more help" by "OpenHexa wiki homepage" or "Visit the OpenHexa documentation homepage"

Done


fixed unsubscribe handler exception

Unsubscribe request for a topic that hasn't been subscribed is not handeld.

Great! Would you mind to add a little unit test?

Thanks so much!!


PCI-E support with x86_64/qemu example

Summary
This patch adds a PCI-E subsystem and implemented a backend on x86_64 platform.
It also includes a driver for QEMU's pci-testdev for testing purpose.
Impact
Additional PCI-E feature will be provided.
Testing
By enabling

CONFIG_PCIE
CONFIG_QEMU_PCIE
CONFIG_VIRT_QEMU_PCI_TEST

Booting x86_64 qemu build on QEMU/KVM with -device pci-testdev will have verbose message during OS initialization about PCI-E devices.
The driver will be probed and read/print out the test support by qemu's pci-testdev.
However, at the current stage, no further testing around pci-testdev is implemented.
Possible issues
(1)
I ported this from Jailhouse inmate library.
Most of the APIs were rewritten, but the MSI/MSI-X registration routine and MARCO definitions were copied.
Although Jailhouse is GPLv2, the inmate library is BSD licensed.
I think we are good. I did included BSD headers on affected files.
(2)
I am not a pro on PCI-E, This is originated from my research artifact.
The API might not be properly definded.
Suggestions and instructions are welcome.

Did the PR checks fail to start for this one too?

@sonicyang are the qemu_pci* files the only ones that came from jailroot?
I have some PCI code I wrote in the past that maybe could serve this purpose and avoid the license questions. We already need to make a fair amount of changes for code style.

Did the PR checks fail to start for this one too? There was a rumor that if you rebase then force push the branch, the checks will start. Can you try that?
Seems like if there is any issues on github's side you get stuck having to re push to trigger https://github.community/t5/How-to-use-Git-and-GitHub/Is-it-possible-to-manually-force-an-action-workflow-to-be-re-run/m-p/54996/highlight/true#M11604

@patacongo  @btashton
I will try to force push it, but where should I rebase to?
About the licensing problem, if we have another implementation, it will be great.
Let's first find a way to cooperate.
The affected files are the  driver/pcie and board/ files.
Not all of them were copied, though. I tried to rewrite most of them based on the same logic.
I should be able to identify those and make a list.

The affected list

pre-processor definitions
pci_find_cap()
qemu_pci_enumerate()
qemu_pci_msix_register()
qemu_pci_msi_register()
Whole qemu_pcie_readwrite.h file
driver/virt/qemu_pci_test.c has a structure definition taken from qemu documentation.

I can do a full rewrite, but I doubt those has a totally different implementation though.

Oh, good. It's running now.
I did some cosmetic changes.

I need suggestion on this, should we use pci or pcie as the function prefix?
I am kind of mixing these 2 at the moment, but I want to unify it.

@sonicyang I did some work here https://github.com/btashton/incubator-nuttx/tree/pci-btashton
I have ported over a good chunk of the code that I wrote before in place of the Jailhouse code.  I have not pulled in any of my msi/msix code.  I did change the logic around enumeration to support bridges as well as be smarter about traversing the space.
https://github.com/btashton/incubator-nuttx/tree/pci-btashton
Let me know what you think and I can keep porting over more of the logic if it makes sense.

@btashton Sounds fantastic! I will take a look, but I am kinda of exhausted today.
I will reply on weekend

Seems quite good.
I will try it out on my jailhuose machine with a serial PCI-E card on weekend.
Hope it works.

I am quite uncertain that pci_cfg_read should directly return the value or not.
Need suggestions.
Yes, it more convenient to use and the semantics are much better if we driectly return the content.
However, I get quite paranoid about the fact that someone might give an invalid size to read.
Of course, we can make 4 functions: read8, read16, read32 and read64, but the code will bloat.

I am quite uncertain that pci_cfg_read should directly return the value or not.
Need suggestions.
Yes, it more convenient to use and the semantics are much better if we driectly return the content.
However, I get quite paranoid about the fact that someone might give an invalid size to read.
Of course, we can make 4 functions: read8, read16, read32 and read64, but the code will bloat.

For what it is worth freebsd uses basically the same prototype.
uint32_t
     pcie_read_config(device_t dev, int	reg, int width);

I think if we put a debug assert in we should be fine since the code is broken either way.  I don't see a case where the read or write length should be dynamic.

@btashton It sounds good to me.
Should we support 64bit r/w natively?

@btashton I have checked your modifications.
I didn't make it work with my serial card because of lacking find_cap and msi/msix routines.
But I did confirmed that it did scan the bus without crashing my Intel Xeon machine.
I did noticed this "smart" way of scanning bus didn't work with Jailhouse, because Jailhouse didn't have a full PCI hierarchy, e.g. root device, etc. Devices are passed to the cells via VT-d separately.
I am currently working on ivshmem device driver for Jailhouse, I hope we can take this problem into account.
I purpose that we should open a PCI feature branch, cooperate there with PR.
Of course, we need some one with permission to do this.
What do you think?

@sonicyang -- First off sorry I clicked edit on your comment instead of reply, should have restored it back to what you had.

@btashton I have checked your modifications.
I didn't make it work with my serial card because of lacking find_cap and msi/msix routines.

This is to be expected. I am reworking those right now, but should have that done this weekend.

But I did confirmed that it did scan the bus without crashing my Intel Xeon machine.

Great! I have only been messing with this via QEMU partially because it lets be create custom bus hierarchies.

I did noticed this "smart" way of scanning bus didn't work with Jailhouse, because Jailhouse didn't have a full PCI hierarchy, e.g. root device, etc. Devices are passed to the cells via VT-d separately.

This should not be a problem, but I did see that Jailhouse breaks the PCI spec in a way I did not check for. They let you pass individual device functions which means that when I check func 0 I will stop looking. I bet this is where things went wrong. I added a patch to work around this to my branch. I it would be great if you could see if it finds your devices.

I am currently working on ivshmem device driver for Jailhouse, I hope we can take this problem into account.

We certainly should handle this case. I made a note in my patch about how to detect Jailhouse to work around this issue (for now I hard coded it on)

I purpose that we should open a PCI feature branch, cooperate there with PR.
Of course, we need some one with permission to do this.

I created the branch off of what was in this PR called pci. https://github.com/apache/incubator-nuttx/tree/pci
I think this is a great starting point and we can review it more as a whole once we have it more mature. I also don't want to block you while I am working on some more of the low level primitives without the jailroot code. I also have a PCIe FPGA board that should be here in a few weeks that will allow me to test some of this against a RISC-V softcore.

@btashton Thank you.
Let's continue there.

I also have a PCIe FPGA board that should be here in a few weeks that will allow me to test some of this against a RISC-V softcore.

It's good that we can test it on some other architectures.
Looking forward to it.
Personally, I only have a Intel Xeon machine and a R-Pi 4 at the moment.

I think I can now close this and continue to work with other on pci branch.


1000x1000

main is 1250x1250=1562500 and the macros with halos are 1177191.9, so this design is dominated by macro + halo area.
[ERROR MPL-0016] The instance area considering the macros' halos 1177191.9 exceeds the core area 991699.3
19:25:52  Error: macro_place_util.tcl, 75 MPL-0016

nope.
10:59:00  [INFO DPL-0035]  wire17412
10:59:00  [INFO DPL-0035] message limit reached, this message will no longer print
10:59:00  [ERROR DPL-0036] Detailed placement failed.
10:59:00  Error: detail_place.tcl, 37 DPL-0036
10:59:00  Command exited with non-zero status 1


No syntax highlighting

Result from CocInfo
versions
vim version: NVIM v0.5.0-dev+1048-g69103ff0c
node version: v15.8.0
coc.nvim version: 0.0.80-5cd38e9462
coc.nvim directory: /home/axel/.local/share/nvim/plugged/coc.nvim
term: xterm-kitty
platform: linux
Log of coc.nvim
2021-02-16T12:07:53.550 INFO (pid:3438935) [services] - registered service "highlight"
2021-02-16T12:07:53.567 INFO (pid:3438935) [language-client-index] - highlight started with 3438946
2021-02-16T12:07:53.583 INFO (pid:3438935) [language-client-index] - Language server "kotlin" started with 3438954
2021-02-16T12:07:54.574 INFO (pid:3438935) [plugin] - coc.nvim 0.0.80-5cd38e9462 initialized with node: v15.8.0 after 1084ms
2021-02-16T12:07:55.469 INFO (pid:3438935) [attach] - receive notification: showInfo []
Description
There is no syntax highlighting. Completion, linting etc is working.
Extension version
0.0.4
Additional context

It's my mistake, because coc is unlikely to port the highlight of vscode. So this plugin does not support highlighting. You should use https://github.com/udalov/kotlin-vim or treesitter

I see, thanks for the information @weirongxu


VelocityBallToGoalReward in rlgym.utils.reward_functions.common_rewards.ball_goal_rewards breaks ball speed after it is called

If you use velocityballtogoal as a reward, and then try to print the goal speed or print the ball speed after using that reward, the ball speed returns as 0.0.

Fixed this in the latest version


Build against Play 2.5?

Silhouette fails to build against Play 2.5, giving these failures after changing the Play version in plugins.sbt to 2.5.0:
[error] [...]/play-silhouette/silhouette/app/com/mohiva/play/silhouette/api/services/AuthenticatorService.scala:46: too many arguments for constructor Result: (header: play.api.mvc.ResponseHeader, body: play.api.http.HttpEntity)play.api.mvc.Result
[error] class AuthenticatorResult(result: Result) extends Result(result.header, result.body, result.connection) {
[error]                                                   ^
[error] [...]/play-silhouette/silhouette/app/com/mohiva/play/silhouette/api/services/AuthenticatorService.scala:59: not found: value HttpConnection
[error]     connection: HttpConnection.Connection = this.connection) = {
[error]                 ^
[error] [...]/play-silhouette/silhouette/app/com/mohiva/play/silhouette/api/services/AuthenticatorService.scala:61: too many arguments for method copy: (header: play.api.mvc.ResponseHeader, body: play.api.http.HttpEntity)play.api.mvc.Result
[error]     AuthenticatorResult(super.copy(header, body, connection))
[error]                                   ^
[error] [...]/play-silhouette/silhouette/app/com/mohiva/play/silhouette/api/services/AuthenticatorService.scala:58: type mismatch;
[error]  found   : play.api.http.HttpEntity
[error]  required: play.api.libs.iteratee.Enumerator[Array[Byte]]
[error]     body: Enumerator[Array[Byte]] = this.body,
[error]                                          ^
[error] [...]/play-silhouette/silhouette/app/com/mohiva/play/silhouette/api/services/AuthenticatorService.scala:59: value connection is not a member of com.mohiva.play.silhouette.api.services.AuthenticatorResult
[error]     connection: HttpConnection.Connection = this.connection) = {
[error]                                                  ^
[error] 5 errors found
[error] (play-silhouette/compile:compileIncremental) Compilation failed
[error] Total time: 9 s, completed 08.03.2016 11:48:06

These errors seem to be related to Play 2.5 using akka-streams.
As things stand this prevents us from using Silhouette with Play 2.5, because Play 2.4 builds are incompatible with Play 2.5.

I work on the build and I plan to release it this afternoon.

I've just released Silhouette 4.0.0-BETA. Please visit the documentation for more information.

@akkie Thank you very much, that's awesome! :clap:


Adding credits notebook 01

Per suggestions by @fkiraly

I am not sure what you mean again Franz?  I went ahead and merged though


fix symbolic link

travis fails because CMakeLists.txt cannot be found.

https://travis-ci.org/ros/catkin/jobs/439639963

It's because the way to create a symbolic link of CMakeLists.txt is not correct.

Also the current state still seems to fail Travis CI.

sorry, it's my misunderstanding...
(I thought that ${from_path} and ${to_path} have to be absolute path with ln -s ${from_path} ${to_path}, but it's not.)
Currently, origin/indigo-devel fails Travis CI as follows.

origin/kinetic-devel
origin/indigo-devel

status
pass
fail

evidence
https://github.com/ros/catkin/pull/967
https://github.com/ros/catkin/pull/968


Added support Parquet deserialize LargeList and Uint data types

Add support Parquet deserialize LargeList and Uint data types

Thanks @b41sh !


Returning 404 rather than failing on a non-existent file

I'll need this for the icons and overall makes sense.

Yep.
LGTM, +1.

@Kami Had to add headers, too. It just sent 'text/plain' for every file (most browsers can ignore it, but it still presents problems, also it's just plain wrong). Looks good?

I feel that just bluntly abandoning jsexpose might break a few things in most unexpected places. I don't see anything in particular, but would very much like someone from the @StackStorm/team to give it another look

Yeah, we do a some parameter type checking and other stuff in jsexpose, but I think we should be fine now since most of the error handling and translation has been moved to the JSONErrorResponseHook.
This means we should still return JSON in case something goes wrong.


TextField textbaseline ignores padding with outline border

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
Create a textfield with an outlined input border and text align top. Give the content padding more padding on the top than the bottom. e.g. 50 top, 10 bottom
Ways to workaround this issue and get the expected result: Set "isCollapsed" to true, then it behaves like that because of this code:

Class: _RenderDecoration
Method: _isOutlineAligned -> return !decoration.isCollapsed && decoration.border.isOutline;
Why does this work?

Class: _RenderDecoration

Method: performLayout -> baseline = _isOutlineAligned ? layout.outlineBaseline : layout.inputBaseline;

With isCollapsed: true the textfield uses the inputBaseline, not the outlineBaseline. But why is outlineBaseline wrong?
I suspect this piece of code:

Class: _RenderDecoration
Method: _layout

    // The three main alignments for the baseline when an outline is present are
    //
    //  * top (-1.0): topmost point considering padding.
    //  * center (0.0): the absolute center of the input ignoring padding but
    //      accommodating the border and floating label.
    //  * bottom (1.0): bottommost point considering padding.
    //
    // That means that if the padding is uneven, center is not the exact
    // midpoint of top and bottom. To account for this, the above center and
    // below center alignments are interpolated independently.
    final double outlineCenterBaseline =
        inputInternalBaseline + baselineAdjustment / 2.0 + (containerHeight - (2.0 + inputHeight)) / 2.0;
    final double outlineTopBaseline = topInputBaseline;
    final double outlineBottomBaseline = topInputBaseline + maxVerticalOffset;
    final double outlineBaseline = _interpolateThree(
      outlineTopBaseline,
      outlineCenterBaseline,
      outlineBottomBaseline,
      textAlignVertical,
    );

See the last call to _interpolateThree
    if (textAlignVertical.y <= 0) {
      // It's possible for begin, middle, and end to not be in order because of
      // excessive padding. Those cases are handled by using middle.
      if (begin >= middle) {
        return middle;
      }
      // Do a standard linear interpolation on the first half, between begin and
      // middle.
      final double t = textAlignVertical.y + 1;
      return begin + (middle - begin) * t;
    }

This forces the baseline in outlineBorders to be center if the top padding pushes the baseline to be further south than the center. It just doesn't really make sense to me. I can force the baseline to be down with my padding and just set isCollapsed to true, but I don' want that, as I need the label and hint texts in my textfield. With isCollapsed true, they are gone.
Expected results
The text should be padded top with 50 pixels and bottom with 10.
Actual results
The text is centered
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Scaffold(
        body: Center(
            child: TextField(
          decoration: InputDecoration(
            border: OutlineInputBorder(),
            contentPadding: EdgeInsets.fromLTRB(10, 50, 10, 10),
          ),
          textAlignVertical: TextAlignVertical.top,
        )),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
Expected:

Actual:

Logs
No response
Flutter Doctor output
Doctor output
PS D:\Entwicklung\Flutter\flutter_jvx> flutter doctor -v
[√] Flutter (Channel stable, 3.7.10, on Microsoft Windows [Version 10.0.19044.2846], locale de-AT)
    • Flutter version 3.7.10 on channel stable at C:\tools\Flutter\Flutter_aktuell
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4b12645012 (10 days ago), 2023-04-03 17:46:48 -0700
    • Engine revision ec975089ac
    • Dart version 2.19.6
    • DevTools version 2.20.1

[X] Windows Version (Unable to confirm if installed Windows version is 10 or greater)

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\theiss\AppData\Local\Android\sdk
    • Platform android-33, build-tools 31.0.0
    • Java binary at: C:\tools\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2020.3)
    • Android Studio at C:\tools\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19044.2846]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 111.0.5563.148
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 111.0.1661.44

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

It also seems like it is not actually centered. It seems off by a few pixels more north than it should.
Here a few examples with different configurations:
isDense: True, Border: InputBorder.none, contentPadding: (0, 10, 0, 10); textAlignVertical: center

Code example
import 'package:flutter/material.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Scaffold(
        body: Center(
            child: TextField(
          decoration: InputDecoration(
            border: InputBorder.none,
            contentPadding: EdgeInsets.fromLTRB(0, 10, 0, 10),
            isDense: true,
          ),
          textAlignVertical: TextAlignVertical.center,
        )),
      ),
    );
  }
}

´

isDense: True, Border: OutlineInputBorder, contentPadding: (0, 10, 0, 10); textAlignVertical: center

Code example
import 'package:flutter/material.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: Scaffold(
        body: Center(
            child: TextField(
          decoration: InputDecoration(
            border: OutlineInputBorder(),
            contentPadding: EdgeInsets.fromLTRB(0, 10, 0, 10),
            isDense: true,
          ),
          textAlignVertical: TextAlignVertical.center,
        )),
      ),
    );
  }
}

´

As you can see, without an OutlineInputBorder, the text baseline is correctly centered. Having one suddenly shifts the text upwards by a small amount. Even with TextAlignVertical.center.

The bug is reproducible using the code sample provided above.

recording
https://user-images.githubusercontent.com/88313112/231986193-2ae8b976-9853-4528-b270-f843c1f038cb.mov

updated code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    const contentPadding = EdgeInsets.fromLTRB(10, 50, 10, 10);

    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: Padding(
            padding: const EdgeInsets.all(8.0),
            child: Column(
              mainAxisAlignment: MainAxisAlignment.center,
              children: const [
                Text('TextField With OutlinedInputBorder'),
                TextField(
                  decoration: InputDecoration(
                    border: OutlineInputBorder(),
                    contentPadding: contentPadding,
                  ),
                  textAlignVertical: TextAlignVertical.top,
                ),
                Text('TextField With OutlinedInputBorder & isCollapsed: true'),
                TextField(
                  decoration: InputDecoration(
                    border: OutlineInputBorder(),
                    isCollapsed: true,
                    contentPadding: contentPadding,
                  ),
                  textAlignVertical: TextAlignVertical.top,
                ),
                Text('TextField With UnderlineInputBorder'),
                TextField(
                  decoration: InputDecoration(
                    border: UnderlineInputBorder(),
                    contentPadding: contentPadding,
                  ),
                  textAlignVertical: TextAlignVertical.top,
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.7.11, on macOS 13.3.1 22E261 darwin-arm64, locale en-GB)
    • Flutter version 3.7.11 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f72efea43c (3 days ago), 2023-04-11 11:57:21 -0700
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9619390/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9619390/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1)
    • IntelliJ at /Users/nexus/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 73.0.4
    • Dart plugin version 231.8109.91

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.8109.175/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.77.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (3 available)
    • Pixel 7 (mobile) • 28291FDH2001SA • android-arm64  • Android 13 (API 33)
    • macOS (desktop)  • macos          • darwin-arm64   • macOS 13.3.1 22E261 darwin-arm64
    • Chrome (web)     • chrome         • web-javascript • Google Chrome 112.0.5615.49

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[!] Flutter (Channel master, 3.10.0-5.0.pre.26, on macOS 13.3.1 22E261 darwin-arm64, locale en-GB)
    • Flutter version 3.10.0-5.0.pre.26 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e1722859ec (2 hours ago), 2023-04-14 01:49:32 -0400
    • Engine revision 4f86a05ac9
    • Dart version 3.1.0 (build 3.1.0-2.0.dev)
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9619390/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode-14.3.0.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/221.6008.13.2211.9619390/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1)
    • IntelliJ at /Users/nexus/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 73.0.4
    • Dart plugin version 231.8109.91

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1)
    • IntelliJ at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/231.8109.175/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.77.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (3 available)
    • Pixel 7 (mobile) • 28291FDH2001SA • android-arm64  • Android 13 (API 33)
    • macOS (desktop)  • macos          • darwin-arm64   • macOS 13.3.1 22E261 darwin-arm64
    • Chrome (web)     • chrome         • web-javascript • Google Chrome 112.0.5615.49

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Hi @ToniHeiss, thanks for filing the issue. Can you also file a separate issue for https://github.com/flutter/flutter/issues/124789#issuecomment-1507049394?

cc @justinmc from triage

This is somewhat related to: https://github.com/flutter/flutter/issues/86093

It also seems like it is not actually centered. It seems off by a few pixels more north than it should.
Here a few examples with different configurations:
isDense: True, Border: InputBorder.none, contentPadding: (0, 10, 0, 10); textAlignVertical: center
Code example
isDense: True, Border: OutlineInputBorder, contentPadding: (0, 10, 0, 10); textAlignVertical: center
Code example
As you can see, without an OutlineInputBorder, the text baseline is correctly centered. Having one suddenly shifts the text upwards by a small amount. Even with TextAlignVertical.center.

I've observed the same thing
My workaround for the moment is to manually set the line height (1.8 in my case) to nudge to the center. Unfortunately, this has a side effect of making the blinking cursor extra tall. (I'm using FlutterFlow atm, otherwise I'd probably just use something like VerticalTextAlign top with top content padding to manually center it, and thus get around the oversized cursor.)


Earlgrey: prim_generic_ram_1p.sv doesn't work in verilator

For target uhdm/verilator/opentitan Verilator throws the following error message:
%Error: Extracting 72 bits from only 32 bit number
                : ... In instance top_earlgrey_verilator.top_earlgrey.u_rv_core_ibex.u_core.if_stage_i.gen_icache.icache_i.gen_rams[0].data_bank.gen_generic.u_impl_generic
%Warning-WIDTH: Operator ASSIGN expects 32 bits on the Assign RHS, but Assign RHS's SEL generates 72 bits.
                        : ... In instance top_earlgrey_verilator.top_earlgrey.u_rv_core_ibex.u_core.if_stage_i.gen_icache.icache_i.gen_rams[0].data_bank.gen_generic.u_impl_generic

ram module is parsed correctly by Surelog. It was added to flow with Surelog
https://github.com/antmicro/verilator/pull/71


move_and_collide() does not work if there is a wall left and right

Godot version: 3.2.1 stable
OS/device including version: Win64
Issue description:

The Player would collide as expected when moving head on against a Tilemap collisionshape, but does not collide with the same collisionshape head on, if there is also another collisionshape reft and right from the direction the player is moving to
Code:
extends KinematicBody2D

var gridsize = 16
var inputs = {
	"ui_up": Vector2.UP,
	"ui_down": Vector2.DOWN,
	"ui_left": Vector2.LEFT,
	"ui_right": Vector2.RIGHT
}

func _unhandled_input(event):
	for dir in inputs.keys():
		if event.is_action_pressed(dir):
			var velocity = inputs[dir] * gridsize
			move(velocity)

func move(velocity):
	var collision = move_and_collide(velocity, true, true, true)
	if collision:
		print("colliding with ", collision.get_collider().name)
	collision = move_and_collide(velocity)
	print(collision)

Related:
https://github.com/godotengine/godot/issues/36432
Minimal reproduction project:
Grid_Movement_issue.zip

Duplicate of #37798 actually...


ANC @ Health Center - Add Malaria Prevention and Medication as Activities [4h]

Issue
The activity "Patient Provisions" is being removed completely from ANC. "Malaria Prevention" and "Medication" are moving from sub-activities to activities in the main tray.

Malaria Prevention should have the question that is currently under Patient Provisions > Resources sub-activity.
Medication should have the questions that are currently under Patient Provisions > Medication sub-activity.
The current logic for sub-sequent encounters should remain the same.
Assets
https://www.figma.com/file/nKKYxDmnEPm7CiXSXO1pq7/E-Heza-2021?node-id=292%3A5188
To Do

Create medication activity
Create Malaria Prevention activity
Adjust to keep current logic for sub enc.
Order in main activity tray per design

@LudmilaGoichman
Please retest on Nutrition env/

@isapisa @anvmn

https://nutrition-ihangane.pantheonsite.io/app
tablet

Checked and Approved:

the Icon is displayed:


Change default fallback impact_index.json address

This still points to the old impact.modelica.org location which no longer is getting updated.

As of v0.8.1 the URL is set to http://impact.github.io/impact_index.json


Partners page updates

New listings for kubernetes.io/partners

cc // @zacharysarah

@kbarnard10 is this for 1.10? If so, can you please rebase against the release-1.10 branch? If that's problematic, we can hold off on merging until release day.
/assign

@Bradamant3 this is independent of the 1.10 release and can be merged at any time.


fix: Only the last two digits can be deleted via BNP when input is not focused

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/50315
PROPOSAL: https://github.com/Expensify/App/issues/50315#issuecomment-2404787481
Tests

Precondition:
User has been assigned a physical Expensify card.

Launch New Expensify app.
Go to Account settings > Wallet.
Tap on the Expensify card.
Tap Get physical card.
Tap Ship card on the comfirmation page.
Tap Activate physical card.
Enter any 4 digits.
After the error shows up, tap < button on the BNP to delete the digits (do not focus on the input, remove the focus on the input if it is focused).
Verify the digits can be deleted completely via < button on the BNP when the input is not in focus.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/1ecd93ee-2da3-4f94-9303-cfbd99ae206f

Android: mWeb Chrome

https://github.com/user-attachments/assets/5e373d20-df1f-4e58-ae31-f17a164cbeef

iOS: Native

https://github.com/user-attachments/assets/f55546af-32ff-4e28-854a-9973047fcc94

iOS: mWeb Safari

https://github.com/user-attachments/assets/56073773-c86d-4bea-864a-5930e3d9ec2e

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/f3a2925f-9bcd-4cce-a028-2a5c7e198901

MacOS: Desktop

https://github.com/user-attachments/assets/25cabd48-004c-4bd9-abb2-c20fff7d1837

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


anno_boxplot AttributeError for colors parameter usage due to .copy() in check_colors

Describe the bug

Cannot pass single colors to anno_boxplot in latest version (from 1.6.8 onwards?).
Most likely due to _check_colors method for anno_boxplot class trying to copy the input colors string when setting self.colors
Strings are immutable and do not have a .copy() method.
Raises an AttributeError: 'str' object has no attribute 'copy'
Fix: remove .copy()

To Reproduce
Steps to reproduce the behavior:
Create anno_boxplot with colors="white" or any single color
Expected behavior
Produce single color boxplot, with no TypeErrors

Thanks for reporting this bug; it has already been fixed and pushed to GitHub.
You can install the latest version from GitHub, which will be released in the next version.


[Coloring] Current line colorization is almost always broken after editing

I've observed this bug for at least a month or so.

Edit a line of code
Wait until colorization is updated
The current line is all black (in most cases) or colorized in a wrong way (symbols are partially colorized / colorized in wrong colors)
To fix the colorization you have to change a line below the broken one

I think we loose a "test changed" event (broken throttling?)

I believe it's fixed in https://github.com/fsprojects/VisualFSharpPowerTools/pull/933
If it's not the case, it's better to open a new issue.


Why do we ship src on npm?

Does anyone remember why do we ship the src folder in our npm package? It's leading to some issues with Flow (because we use __DEV__ which is not defined anywhere).
@atomiks do you have some context?

You added it here https://github.com/popperjs/popper-core/commit/f8adb24d7af7b05424e137f4888a4c291fb9dd45 🤷

Maybe I used it in place of flow-copy-source? 🤷♂ Are everybody okay if I remove that folder from the npm package right?


Command line and values option to lock chart to be applied only to the specific K8s context

I'm looking for something that is similar to the terraform's [allowed_account_ids] - (Optional) List of allowed AWS account IDs to prevent you from mistakenly using an incorrect one (and potentially end up destroying a live environment).
It would be nice if I could specify in the my-values.yaml some K8s context and if it differs from some I am currently on - it would fail to apply with an error: you are trying to deploy into the wrong cluster.
I understand that it's not the case when you are using CI/CD but when you have more than one cluster and by mistake apply changes to the wrong one. I am also aware of the helm diff plugin or --dry-run, it's just another safety fuse I'd like to have. Moreover, it can fail much faster because there is no need to get any information from the k8s but just check the context locally.

This sounds like it could be able to be implemented as a plugin. You might give the plugins guide a look and see if you can implement something there. Could be a good project.

It could work but require adding an alias to the helm command to call the helm with the plugin name instead. I don't see other ways how to call some plugin each time if it's just installed.
Anyway, thx for the idea, will check how to implement it.

Since there was an answer and no further discussion, I'm going to close this as solved.


Delete manifests/k/krishisrani/appel/<IP_ADDRESS> directory

Needs to be deleted because as the developer, on install, the application name is mismatched causing the final name of the instlled app to be game

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

URL: https://krishisrani61.github.io/Appel-Game/winget/AppelSetup.exe
Status Code: 200
(Automated message - build 808)

Hi @krishisrani61,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 808.)

URL: https://krishisrani61.github.io/Appel-Game/winget/AppelSetup.exe
Status Code: 200
(Automated message - build 812)

URL: https://krishisrani61.github.io/Appel-Game/winget/AppelSetup.exe
Status Code: 200
(Automated message - build 812)

URL: https://krishisrani61.github.io/Appel-Game/winget/AppelSetup.exe
Status Code: 200
(Automated message - build 813)

URL: https://krishisrani61.github.io/Appel-Game/winget/AppelSetup.exe
Status Code: 200
(Automated message - build 813)


Using models

[x] MDNet
[ ] yolo3
[ ] Faster rcnn

We will use other shared CNN Layers

[x] VGG16
[ ] InceptionNet
[ ] ResNet


fix(dropdown): fixed DropDown focus on page load

DropDown was getting focused for some unwanted scenarios,
For example: on page load, if any parent component of DropDown updated, DropDown was getting focus,  as updates of DropDown was also getting called that was causing DropDown to get focus.
Issue reference: Story

Coverage increased (+0.1%) to 99.067% when pulling 557801e6bdcddce91b23b0ce14e554fa3a6a9f6d on hammad/dropdown-fix-default-focus into 3629dc603042583ba518d868f3d6f730e127e307 on master.

:tada: This PR is included in version 3.7.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Setup error data for easier overriding of URL variables

See https://github.com/18F/api.data.gov/issues/285 and associated pull request: https://github.com/NREL/api-umbrella-gatekeeper/pull/21

The test failures on this branch are expected (unfortunately). There's a bit of a chicken and egg problem, since the router needs the associated gatekeeper changes in place first in order to pass. So I think the simplest approach is just make sure everything passes once all this gets merged back into master and we release a new npm version of the gatekeeper.


WackysDB causing connection problems

A friend and I are trying to play 'Epic Valheim', which naturally includes wacky's database, via a listen server. IE: non-dedicated. me hosting and he joins via steam. The issue is, he continually gets this error:
"mod wackysdatabase requires a maximum of 0.0.1, current version 1.2.7"
We have tried disabling WackysDB in the mod list (using thunderstore.io launcher) which solves the issue, but unfortunately it breaks a load of recipes and progression related items in the process; so that won't work. I have also set the config to NOT force server sync to no avail. The last thing I see when I load into map is "[Warning:WackysDatabase] You will be kicked from multiplayer servers! 0.0.1" which consequently is the version my friend is being told he needs. I see no setting in the config to change this requirement.
My question is, how do I go about still using the mod, which is required for all the recipes to function properly, but still be able to play together? Is there a work around? A setting I've missed in the long list of config files it touches?

Forgot to mention that crossplay is OFF since we have tried with crossplay on and this error occurs:

Should be fixed in 1.2.8


How to merge to jumbotron using css and html

Challenge Name
https://www.freecodecamp.com/challenges/build-a-personal-portfolio-webpage
Issue Description
I can't merge two jumbotron using one container having one jumbotron and another container haaving another jumbotron  just below one another
Browser Information
google chrome

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:

Your Code
HTML PART

      Portfolio Page

I'am a web devloper having a littele bit knowledge in the web devlopment part ,and wanted to learn as much as i can .

I actually specialised in some programming anguages like c++,c,and in devlopment side i used to work on the html,javascript,css,bootstrap

  <section class=

CSS PART
.line {
border-color: #fff;
border-top: solid 5px;
}
}
.img-circle {
border-radius:50%;
padding-left:40px;
margin-bottom:50px;
}
h2 {
margin-top:20px;
text-align:center;
}
#portfolio {
padding:40px 0px;
margin-top:20px;
}
.green {
background-color: #9f9;
}```

Hi @killerkaran
Thanks for the report. The issue tracker is for reporting bugs only.
Please use the chat rooms:

HTML/CSS help chat room
JavaScript help chat room
Other Official Rooms

or try looking through our forum for help with a specific challenge.
Happy Coding!


Fixed typos in about.md

Fixed 2 typos in about.md:
her -> the (could also be EHR instead of her that was originally intended)
terminologu -> terminology

Thanks!


A property to accompany mobilitydcatap:grammar

mobilitydcatap:grammar uses a vocabulary that specifies a schema format used to deliver the data. For instance, a JSON Schema. However, I couldn't find where in the metadata I could add a URL that points to the schema itself. So I would like to write something like this:
<http://example.com/my_distribution>
  a dcat:Distribution ;
  [...]
  mobilitydcatap:grammar <https://w3id.org/mobilitydcat-ap/grammar/json-schema> ;
  someProperty <URL_TO_THE_ACTUAL_SCHEMA> .

Is there some property that could be used here?

Hi @Joonas-M-S you can express it as a MobilityDataStandard

<http://example.com/my_distribution>
  a dcat:Distribution ;
  [...]
  mobilitydcatap:grammar <https://w3id.org/mobilitydcat-ap/grammar/json-schema> ;
  mobilitydcatap:mobilityDataStandard <http://example.com/my_json_schema> .

<http://example.com/my_json_schema> a mobilitydcatap:MobilityDataStandard ;
  owl:versionInfo "VERSION" ;
  mobilitydcatap:schema "...URL leading to schema file(s)..." .

Thanks, this helped!


browser version

It would be grate to use this module in browser with single file output.
P.S.
How about publishing to bower?

I agree, basically just hasn't been done cause I don't need it and no one had requested it yet. :smile:

@zhakhalov now available via bower, you can also download it directly here https://github.com/jayphelps/core-decorators-artifacts

@zhakhalov btw just in case you hadn't heard, bower is almost certainly on its way out so I would consider alternatives (npm being the most obvious, combined with something like webpack or browserify).
Also--isn't a bit weird to use decorators syntax...but not have the ability to import modules directly instead of globals? :trollface:


FIT Count website - survey filter not needed?

At the moment, the download pages on the FIT Count website (e.g. https://fitcount.ceh.ac.uk/regional-results) allow the user to choose between the app survey, or the UK PoMS survey, or the UK 1 km square survey. I don't think we need to provide any option other than the app survey.
@CCarvell please can you confirm that anyone accessing data via the FIT Count website only needs to see data that has come from the app. I think the only people who need to use this route will be app users and regional coordinators.

Agreed.  All other countries only collect data through the app afaik

@andrewvanbreda not urgent, but we would like to restrict the reports on the FIT Count website so that they only show samples from the FIT Count app (survey_id = 641). Therefore, the functionality for filtering by survey is not needed.

@andrewvanbreda has fixed this - closing.


Speedup travis

Improves travis execution time by ~3mins per task
Pings:
@cheerfulstoic
@subvertallchris

Coverage decreased (-19.8%) to 72.253% when pulling 89b7ae0577aacc9e79d7178a192f236c32214c12 on speedup-travis into fd0c3b5738f46e17983f8832111c783e5bf2492d on master.


What is the role of the textKey option when defining a new Pinecone store, and Is it possible to circumvent it being used as a filter?

What is the proper usage of the Pinecone textKey field? It's described as an option for storing the text of the document a vector represents.
The way it's used however , when executing a query request, is more like a filter.  It excludes document matches once the query to Pinecone has completed. In the following snippet results are excluded if they don't contain a metadata field that matches what was provided as a textKey. If no textKey is provided a default textKey ("text") is used. There doesn't appear to be a way to make a request without filtering the resulting documents.
	docs := make([]schema.Document, 0, len(response.Matches))
	for _, match := range response.Matches {
		pageContent, ok := match.Metadata[s.textKey].(string)
		if !ok {
			return nil, ErrMissingTextKey
		}

Documents that match the textKey filter are placed in a slice of type schema.Document however the metadata field is empty when returned from restQuery.  match.Metadata is assigned to the Metadata field in the Document slice however it has already been deleted and no longer points to anything.

      delete(match.Metadata, s.textKey)

      docs = append(docs, schema.Document{
	  PageContent: pageContent,
	  Metadata: match.Metadata,
})

This might be a issue with my understanding of how textKey should be used but it is a little unclear. Another of the fields returned from the Pinecone query request is ID, which helps associate each vector with its corresponding document. This would also be useful to include in the Document struct ( although it is very specific to Pinecone)

Ya metadata struct is definitely one option. Metadata is an optional param when calling Pinecone's query endpoint but here in restQuery func its hardcoded to true.
func (s Store) restQuery(
	ctx context.Context,
	vector []float64,
	numVectors int,
	nameSpace string,
) ([]schema.Document, error) {
	payload := queryPayload{
		IncludeValues:   true,
		IncludeMetadata: true,
		Vector:          vector,
		TopK:            numVectors,
		Namespace:       nameSpace,
	}

It kinda conflicts with the idiomatic structure of the Pinecone API which returns ID has a separate field. It probably could confuse things further by adding a new ID field to schema.Document, it's really a pinecone thing. So maybe the MetaData field is a happy medium, and just some comments to explain the nuance. I can work on a PR for that change.
On the textKey you are right , it only removes that specific key from the metadata struct. It still seems restrictive that I have to limit Pinecone results to only those documents containing a specific metadata field. The Pinecone query API has a filter option for this type of use case. If this is the way, then the docs probably just need more explicit instructions.  Right or wrong when I tried to build a similarity search I was relying on consistency with the Pinecone api

Going to close this issue, nether of the JS or Python versions of langchain return the id field and instead place the content in the metadata struct.

Going to close this issue, nether of the JS or Python versions of langchain return the id field and instead place the content in the metadata struct.