Mandd/et import analysis

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #422
What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?

I have added Dan to the reviewer; he did most of the work contained in this PR

By talking with Conjiang and Andrea, this PP does not handle certain OpenPSA ET features such as

and:

I need a bit more time to address this before addressing the comments

Ok.
Let us know when you are ready for the second review.

I extended the capabilities and addresses the comments of the reviewers.
I suggest a second round of review since a lot of things has changed

Job Mingw Test on 230621c : invalidated by @mandd

@mandd I did my review... In addition there are a lot of .DS_Store files that should be removed.

I have completed the addressing of this second round of review

file name has been updated: checking tests

The last comments from @wangcj05 were removed from github but I have addressed them as follows:
@wangcj05 requested changes on this pull request.
I have some comments, in addition, I suggest rename the file framework/PostProcessors/ETimporter.py to framework/PostProcessors/ETImporter.py
In framework/PostProcessors/ETimporter.py:

 @ In, paramInput, ParameterInput, the already parsed input.

 @ Out, None

"""
fileFormat = paramInput.findFirst('fileFormat')
self.fileFormat = fileFormat.value
if self.fileFormat not in self.allowedFormats:

 self.raiseAnError(IOError,

                     'ETImporterPostProcessor Post-Processor ' + self.name + ', format ' + str(self.fileFormat) + ' : is not supported')

def run(self, inputs):
"""

 This method executes the postprocessor action.

 @ In,  inputs, list, list of file objects

 @ Out, None

"""
#self.outputDict = self.runOpenPSA(inputs)
remove the commented line
@mandd: DONE
In framework/PostProcessors/ETimporter.py:

 dictionary as follows:

     dep.keys =

                * link_seqID  : ID of the link in the master ET

                * ET_slave_ID : ID of the slave ET that needs to be copied into the master ET

                * ET_master_ID: ID of the master ET;

 The slave ET is merged into the master ET; note the master ET contains the link in at least one

 <define-sequence> node:

    <define-sequence name="Link-to-LP">

      <event-tree name="Link-to-LP-Event-Tree"/>

    </define-sequence>

 @ In,  None

 @ Out, None

update the doc string here
@mandd: DONE
In framework/PostProcessors/ETimporter.py:

     dep = {}

     dep['link_seqID'] = copy.deepcopy(seqID[idx])

     dep['ET_slave_ID'] = copy.deepcopy(val)

     dep['ET_master_ID'] = copy.deepcopy(root.get('name'))

     linkList.append(dep)

return linkList

def checkETstructure(self,links,listETs,connectivityMatrix):
"""

 This method checks that the structure of the ET is consistent. In particular, it checks that only one root ET

 and at least one leaf ET is provided. As an example consider the following ET structure:

    ET1 ----> ET2 ----> ET3

     |------> ET4 ----> ET5

 Five ETs have been provided, ET1 is the only root ET while ET3 and ET5 are leaf ET.

 @ In,  None

 @ Out, None

update doc string here
@mandd: DONE
In framework/PostProcessors/ETimporter.py:

if len(zeroColumns)>1:

 self.raiseAnError(IOError, 'Multiple root ET')

if len(zeroColumns)==0:

 self.raiseAnError(IOError, 'No root ET')

if len(zeroColumns)==1:

 rootETID = listETs[zeroColumns]

 self.raiseADebug("ETImporter Root ET: " + str(rootETID))

leafs = []
for index in np.nditer(zeroRows):

 leafs.append(listETs[index])

self.raiseADebug("ETImporter leaf ETs: " + str(leafs))

return rootETID

remove extra empty line
@mandd: DONE
In framework/PostProcessors/ETimporter.py:

if len(zeroColumns)==1:

 rootETID = listETs[zeroColumns]

 self.raiseADebug("ETImporter Root ET: " + str(rootETID))

leafs = []
for index in np.nditer(zeroRows):

 leafs.append(listETs[index])

self.raiseADebug("ETImporter leaf ETs: " + str(leafs))

return rootETID

def analyzeMultipleET(self,inputs,links,listRoots,listETs,rootETID):
"""

 This method executes the analysis of the ET if multiple ETs are provided. It merge all ETs onto the root ET

 @ In,  input, list, list of file objects

update doc string here
@mandd: DONE
In framework/PostProcessors/ETimporter.py:

 leafs.append(listETs[index])

self.raiseADebug("ETImporter leaf ETs: " + str(leafs))

return rootETID

def analyzeMultipleET(self,inputs,links,listRoots,listETs,rootETID):
"""

 This method executes the analysis of the ET if multiple ETs are provided. It merge all ETs onto the root ET

 @ In,  input, list, list of file objects

 @ Out, xmlNode, xml.etree.Element, root of the assembled root ET

"""

1. for all ET check if it contains SubBranches

ETset = []
for fileID in inputs:

 EventTree = ET.parse(fileID.getPath() + fileID.getFilename())

should be eventTree?
@mandd: DONE
In framework/PostProcessors/ETimporter.py:

indexRootET = listETs.index(rootETID)
return listRoots[indexRootET]

def analyzeSingleET(self,masterRoot):
"""

 This method executes the analysis of the ET if a single ET is provided.

 @ In,  masterRoot, xml.etree.Element, root of the ET

 @ Out, outputDict, dict, dictionary containing the pointSet data

"""
root = self.checkSubBranches(masterRoot)

These outcomes will be encoded as integers starting at 0

outcomes = []

These self.variables will be mapped into an array where there index

self.variables = []
state variable should be avoided.

In framework/PostProcessors/ETimporter.py:

       if state not in values[event]:

         values[event].append(state)

Iterate through the sequences and gather all of the possible outcomes

so we can numerically encode them latter

for node in root.findall('define-sequence'):

 outcome = node.get('name')

 if outcome not in outcomes:

   outcomes.append(outcome)

etMap = self.returnMap(outcomes, root.get('name'))

self.raiseADebug("ETImporter variables identified: " + str(format(self.variables)))

d = len(self.variables)
n = len(self.findAllRecursive(root.find('initial-state'), 'sequence'))
self.pointSet = -1 * np.ones((n, d + 1))
state variable should be avoided

@mandd by the way, you can still see my comments, just click "Show outdated"

When all tests are green, I will do the checklists. Great Job!

Everything looks good now. The checklists are satisfied. This PR is good to go.
In addition, an email is preferred to the users for this new feature. @mandd do we have a place to document this feature in order to accelerate the new release process?

Happy thanksgiving, and enjoy the holiday. Merging


Make KiCad the latest 8.0 version in the dockerfile

In Dockerfile, the KiCad version is specified as 8.0.2, forcing KiCad to that specific version.
Dockerhub allows kicad/kicad to be set at the latest 8.0 version by simply specifying "8.0".
Would it be possible to change the version number, as KiCad is now at version 8.0.4?

Originally I wanted to allow pinning a specific version in the job configuration, however I haven't found an easy way of doing it. Using the major 8.0 release seems like a good compromise. Will do it, thanks!

Closing because I've created a pull request for this


MI - ADMIN AND OBSERVABILITY section (Initial draft and Navigation structure)

This issue is to get started on the 'Administration and Observability' section [1] of the Micro Integrator docs.

Move all the related content to github. This content is taken from the EI650 doc space [2][3] and the Admin Guide [4].
Update the yaml with the navigation structure [5].

[1] https://github.com/wso2/docs-ei/tree/master/en/micro-integrator/docs/administer-and-observe
[2] https://docs.wso2.com/display/EI650/Product+Administration
[3] https://docs.wso2.com/display/EI650/WSO2+Micro+Integrator
[4] https://docs.wso2.com/display/ADMIN44x/Monitoring
[5] https://github.com/wso2/docs-ei/blob/master/en/micro-integrator/mkdocs.yml

Done.


Update description for imageDigestsPath task input parameter

The description for imageDigestsPath task input must be updated. Provided link for Docker task in the description seems no longer available https://go.microsoft.com/fwlink/?linkid=848006.
Also, looking at the latest version of docker task, it doesn't look like it supports generation of imageDigestsFile where I think it was possible for the previous versions.
Best regards,
Nikolay

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b41ba27-633a-37d4-ce78-a1444a99b5b1
Version Independent ID: 387739fb-276b-d0c9-4848-45426b6e2319
Content: Update Service Fabric Manifests task - Azure Pipelines
Content Source: docs/pipelines/tasks/utility/service-fabric-versioning.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

Thanks for letting us know. This issue is fixed in our new task reference here:
https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/service-fabric-update-manifests-v2?view=azure-pipelines&viewFallbackFrom=azure-devops
Please check it out and let us know what you think. Thank you.


ci: fix uninstall to work around lingering pod

Bug in the handling of CAS-651 failure in the
uninstall test.
If lingering pods are found nuke them,
otherwise the test execution hangs on
deleting the namespace.

bors merge


Definition for rule 'react/no-will-update-set-state' was not found

I am getting the following error thrown in the terminal:

1:1  error  Definition for rule 'react/no-will-update-set-state' was not found react/no-will-update-set-state

what does this mean?
p.s. my rule definition in .eslintrc is "react/no-will-update-set-state": "error"

Any chance you're using the airbnb eslint config (which doesn't yet support v7 of eslint-plugin-react) and v7 of eslint-plugin-react? If so, npm ls should tell you your dependencies are invalid.
If not, what version of eslint-plugin-react are you using?

I have the following packages installed:

"eslint-config-airbnb": "^14.0.0"
"eslint-plugin-react": "^6.10.3"

That rule only exists in v7 - it was added in #1139.
You won't be able to enable it until eslint-config-airbnb releases a new semver-major that supports v7 of eslint-plugin-react.

ok, thanks for that.


fix: event handlers error

For some scenarios, if a user error in a libp2p event handler is thrown, the handler execution fails silently and the user has no way of knowing about the error.
The best solution according to the EventEmitter docs is to throw all the side effects of the emit in the global context, as it happens in node.js out of the box. Several browser shims for the EventEmitter I looked into leave this to the user and do not throw in the global context. Examples:

https://github.com/protobufjs/protobuf.js/blob/master/lib/eventemitter/index.js#L81
https://github.com/browserify/events/blob/master/events.js#L158

As JS has a variety of shims for each building tool, it is not feasible to fix this upstream.  I created proper-event-emitter that extends Event Emitter and wraps the super.emit with a try catch and throw it in the global context using setTimeout
Closes #751

Closing due to staleness


Add epinio to brew

It will be nice to install epinio with Homebrew.

https://github.com/Homebrew/homebrew-core/pull/97204


Complete the edits the .dat for 10Jul2017

An error is popping up when attempting to concatenate the 10Jul2017 data for VCSS. Most likely the cause is the fact that there is a subset of columns that have an extra row. This can happen when the machine is not shut down properly.
Likely Solution:

[x] open the set of .dat files
[x] delete the last row or any rows where there is not a complete entry across all columns
[x] double check that the hard coded datetimes are still valid
[x] copy the .dat file to the matching OneDrive directory

See current error:

Error using table
All table variables must have the same number of rows.

Error in importPicDat (line 112)
TBL = table(dataArray{1:end-1}, 'VariableNames',
{'DATE','TIME','FRAC_DAYS_SINCE_JAN1','FRAC_HRS_SINCE_JAN1','EPOCH_TIME','ALARM_STATUS','INST_STATUS','CavityPressure','CavityTemp','WarmBoxTemp','EtalonTemp','DasTemp','MPVPosition','solenoid_valves','OutletValve','MeasurementMode','species','HP_12CH4','HP_12CH4_dry','HP_13CH4','HR_13CH4','Delta_iCH4_Raw','HP_Delta_iCH4_Raw','HP_Delta_iCH4_30s','HP_Delta_iCH4_2min','HP_Delta_iCH4_5min','HR_12CH4','HR_12CH4_dry','HR_Delta_iCH4_Raw','HR_Delta_iCH4_30s','HR_Delta_iCH4_2min','HR_Delta_iCH4_5min','ChemDetect','H2O','CO2','CO2_dry','CO1','Delta_Raw_iCO2','Delta_30s_iCO2','Delta_2min_iCO2','Delta_5min_iCO2','peak87_baseave_spec','peak88_baseave','peakheight_5','peak0_spec','ch4_splinemax','peak30_spec','peak_30','SSIMPressure','PPF_res','PPF_base_offset','PPF_slope_offset','PPF_shift','PPF_CH4_conc','PPF_H2O_conc','PPF_C2H6_conc','PPF_C2H4_conc','PPF_NH3_conc','PPF_H2S_conc'});

Error in Merge_PicData_Fxn (line 78)
    tableout            = importPicDat(filename);

Error in VCSS_10Jul2017_DataAnalysis (line 85)
 Merge_PicData_Fxn(directory, 'America/Denver');

Details in commit 16ef1b2 demonstrate that issue can now be closed


viewMode: "years" and format: 'YYYY', lowest year not pickable?

It seems that when the datepicker is set to "Years", the lowest available Year (minDate) is never pickable, isValid looks like this:
 if (options.minDate && targetMoment.isBefore(options.minDate, granularity)) {                     return false;                 }
The targetMoment is (i.e. when selecting 2014) Jan 1, 00:00:00 2014, so the minDate object for the year 2014 can never be before that. If I pass 31.12.20013, 2013 is not disabled but again, it can't be picked. But 2014 now can be picked.

Hi, the latest version, 4.17.47, doesn't have this error.
and if you set up this option will work too:
  format: 'YYYY',
  minDate: moment('2014', 'YYYY')


You might be of great help at our organization.

I'll be happy to help.

I'll be happy to help.

please reach out: WhatsApp and close PR :)


Add Tracibility and Anti-Affinity ADRs

What
We're adding some extra complexity into the system, in order to mitigate
some of the risks outlined by NCSC. We should be documenting the
decisions and approaches we have taken, in order to reflect on these in
the future and keep the context alive.
How to review

Read through, seek sense

FYI rebase off master to fix the Travis build


Auto Updating the Height

For my own purposes, I've left in a global reference to iScroll and I can easily do iscroll.refresh() any time something predictable happens, like
$(document).on("click", ".reveal-comments-button", iscroll.refresh );

But (for me) there are times when I have no idea what is going to happen with the end-product, since I'm developing Wordpress themes that other people use and install ( for example ) - Disqus comments.
Disqus then comes in, and at some asynchronous point loads in comments changing the document height, but iScroll has no idea that it has chnaged. Yes, of course I can figure out a way to listen for when Disqus has done it's thing, and do a iscroll.refresh, but the issue isn't exclusive to Disqus.
At any point - anything could modify the DOM and iScroll isn't listening for changes, which sometimes results in bugs where a part of the content isn't accessible. Is there some reasonable way to fix it ?

Hey, guys,
I ran into the same issue, so firstly I tried the refreshOnContentResize. However, I want to have scrollbars as well, and they get messed up with that solution.
So, I ended up with this:

Included the css-element-queries library.
Listen for change of dimensions of the element that actually changes. (In my case was a form element.)
When it changes - just triggers the refresh method of the iScroll.

The final code was like this:
<script type="text/javascript" src='/js/vendor/ResizeSensor.js'></script>
<script type="text/javascript" src='/js/vendor/ElementQueries.js'></script>

// and later, when the iScroll inits ..
var the_iScroll = new IScroll(...);
new ResizeSensor(document.querySelector('form#my-form'), function(){
    the_iScroll.refresh();
});

Hope this helps someone else :)
Regards,
Petar


Can not save tasks

Need to implement a way to save the tasks into a txt file.

Used open() method to write the tasks into the tasks.txt file


to_regclass signature is different on Postgres 9.6

I confirm that this fixes the data import process on the li3ds server.


v1.6, CreateSweepGradient, iOS crash

Description
A crash occurs on iOS only when using CreateSweepGradient SkiaSharp/SkiaSharp.Forms v1.6+ to draw a path with DrawPath.  The issue does not occur on Android or for SkiaSharp/SkiaSharp.Forms 1.5.  The issue only seems to occur if more than 2 colors/points are specified in the gradient.
Code

SKPath lArcPatch = new SKPath();
lArcPatch.AddArc(
    new SKRect(
        mCenterX - (mInnerRadius - mArcOffset),
        mCenterY - (mInnerRadius - mArcOffset),
        mCenterX + (mInnerRadius - mArcOffset),
        mCenterY + (mInnerRadius - mArcOffset)),
    90 + ((360 - mArcDegrees) / 2),
    mArcDegrees);

SKShader lArcShader = SKShader.CreateSweepGradient(
    new SKPoint(mCenterX, mCenterY),
    new SKColor[]
    {
        SKColors.Red, SKColors.Red,
        new SKColor(0x00, 0xff, 0x00),
        SKColors.Red, SKColors.Red
    },
    new float[]
    {
        (float)0.0 + lPositionAddr,
        lMinWarnInArc + lPositionAddr,
        (float)((lMaxWarnInArc + lMinWarnInArc) / 2.0) + lPositionAddr,
        lMaxWarnInArc + lPositionAddr,
        (float)1.0
    });

e.Surface.Canvas.DrawPath(
    lArcPatch,
    new SKPaint() { Style=SKPaintStyle.Stroke, Shader = lArcShader, StrokeWidth = mArcWidth, IsAntialias = true });

Expected Behavior
The path draws with the given gradient.
Actual Behavior
Application crashes
2018-06-27 13:21:41.121 MMR.iOS[4532:7618522] critical: Stacktrace:

2018-06-27 13:21:41.121 MMR.iOS[4532:7618522] critical:   at <unknown> <0xffffffff>
2018-06-27 13:21:41.121 MMR.iOS[4532:7618522] critical:   at (wrapper managed-to-native) SkiaSharp.SkiaApi.sk_canvas_draw_path (intptr,intptr,intptr) <0x00007>
2018-06-27 13:21:41.121 MMR.iOS[4532:7618522] critical:   at SkiaSharp.SKCanvas.DrawPath (SkiaSharp.SKPath,SkiaSharp.SKPaint) [0x0002e] in <dda4dd89ebba425f9972e6db0728b9e9#F95EFE24-1F0F-8FFF-FCDC-11423293DE24>:0
2018-06-27 13:21:41.121 MMR.iOS[4532:7618522] critical:   at XamarinHelpers.Controls.NepGauge.OnPaintSurface (SkiaSharp.Views.Forms.SKPaintSurfaceEventArgs) [0x00609] in C:\Users\jnisewonder\source\repos\CSharp\CommonLibraries\XamarinHelpers\Controls\NepGauge.cs:188
2018-06-27 13:21:41.121 MMR.iOS[4532:7618522] critical:   at SkiaSharp.Views.Forms.SKCanvasView.SkiaSharp.Views.Forms.ISKCanvasViewController.OnPaintSurface (SkiaSharp.Views.Forms.SKPaintSurfaceEventArgs) [0x00002] in <506b88fe480b428d8aa18dffa13375f7#F95EFE24-1F0F-8FFF-FCDC-11423293DE24>:0
2018-06-27 13:21:41.121 MMR.iOS[4532:7618522] critical:   at SkiaSharp.Views.Forms.SKCanvasViewRendererBase`2<TFormsView_REF, TNativeView_REF>.OnPaintSurface (object,SkiaSharp.Views.iOS.SKPaintSurfaceEventArgs) [0x00021] in <506b88fe480b428d8aa18dffa13
375f7#F95EFE24-1F0F-8FFF-FCDC-11423293DE24>:0
2018-06-27 13:21:41.122 MMR.iOS[4532:7618522] critical:   at SkiaSharp.Views.iOS.SKCanvasView.DrawInSurface (SkiaSharp.SKSurface,SkiaSharp.SKImageInfo) [0x00013] in <6bb7f15ce3894ef3bd7d052a3b2395f2#F95EFE24-1F0F-8FFF-FCDC-11423293DE24>:0
2018-06-27 13:21:41.122 MMR.iOS[4532:7618522] critical:   at SkiaSharp.Views.iOS.SKCanvasView.Draw (CoreGraphics.CGRect) [0x0004b] in <6bb7f15ce3894ef3bd7d052a3b2395f2#F95EFE24-1F0F-8FFF-FCDC-11423293DE24>:0
2018-06-27 13:21:41.122 MMR.iOS[4532:7618522] critical:   at (wrapper runtime-invoke) object.runtime_invoke_dynamic (intptr,intptr,intptr,intptr) [0x0001e] in <b238a3153e534349ad10ed0787f2157a#F95EFE24-1F0F-8FFF-FCDC-11423293DE24>:0
2018-06-27 13:21:41.122 MMR.iOS[4532:7618522] critical:   at <unknown> <0xffffffff>
2018-06-27 13:21:41.122 MMR.iOS[4532:7618522] critical:   at (wrapper managed-to-native) UIKit.UIApplication.UIApplicationMain (int,string[],intptr,intptr) <0x00007>
2018-06-27 13:21:41.122 MMR.iOS[4532:7618522] cr
itical:   at UIKit.UIApplication.Main (string[],intptr,intptr) [0x00005] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/UIKit/UIApplication.cs:79
2018-06-27 13:21:41.122 MMR.iOS[4532:7618522] critical:   at UIKit.UIApplication.Main (string[],string,string) [0x0002c] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/UIKit/UIApplication.cs:63
2018-06-27 13:21:41.122 MMR.iOS[4532:7618522] critical:   at MMR.iOS.Application.Main (string[]) [0x00001] in C:\Users\jnisewonder\source\repos\CSharp\MobileMeterReading\MMR\MMR.iOS\Main.cs:17
2018-06-27 13:21:41.122 MMR.iOS[4532:7618522] critical:   at (wrapper runtime-invoke) object.runtime_invoke_dynamic (intptr,intptr,intptr,intptr) [0x0001e] in <b238a3153e534349ad10ed0787f2157a#F95EFE24-1F0F-8FFF-FCDC-11423293DE24>:0
2018-06-27 13:21:41.122 MMR.iOS[4532:7618522] critical:
Native stacktrace:
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	0   MMR.iOS                             0x0000000104bf4a40 MMR.iOS + 42912320
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	1   MMR.iOS                             0x0000000104bffe5c mono_pmip + 9944
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	2   libsystem_platform.dylib            0x0000000182097b50 _sigtramp + 52
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	3   libSkiaSharp                        0x0000000105511ce0 gr_glinterface_has_extension + 1347152
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	4   libSkiaSharp                        0x0000000105498124 gr_glinterface_has_extension + 848532
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	5   libSkiaSharp                        0x0000000105498028 gr_glinterface_has_extension + 848280
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	6   libSkiaSharp                        0x00000001054adc4c gr_glinterface_has_extension + 937404
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	7   libSkiaSharp                        0x000000010543e0b4 gr_glinterface_has_extensio
n + 479780
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	8   libSkiaSharp                        0x000000010543e38c gr_glinterface_has_extension + 480508
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	9   libSkiaSharp                        0x00000001053d0e90 gr_glinterface_has_extension + 32768
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	10  libSkiaSharp                        0x00000001053e7600 gr_glinterface_has_extension + 124784
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	11  MMR.iOS                             0x00000001039283c0 MMR.iOS + 23200704
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	12  MMR.iOS                             0x00000001038eb1b0 MMR.iOS + 22950320
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	13  MMR.iOS                             0x00000001023bfbf0 MMR.iOS + 752624
2018-06-27 13:21:41.125 MMR.iOS[4532:7618522] critical: 	14  MMR.iOS                             0x00000001039535f0 MMR.iOS + 23377392
2018-06-27 13:
21:41.126 MMR.iOS[4532:7618522] critical: 	15  MMR.iOS                             0x0000000103958968 MMR.iOS + 23398760
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	16  MMR.iOS                             0x000000010396efb4 MMR.iOS + 23490484
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	17  MMR.iOS                             0x000000010396e780 MMR.iOS + 23488384
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	18  MMR.iOS                             0x0000000102a41b48 MMR.iOS + 7576392
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	19  MMR.iOS                             0x0000000104c02eb0 mono_pmip + 22316
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	20  MMR.iOS                             0x0000000104c6aac4 mono_pmip + 447296
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	21  MMR.iOS                             0x0000000104c6e084 mono_pmip + 461056
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	22  MMR.iOS
  0x000000010231070c MMR.iOS + 34572
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	23  MMR.iOS                             0x000000010233520c MMR.iOS + 184844
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	24  UIKit                               0x000000018baaec74 <redacted> + 408
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	25  QuartzCore                          0x00000001864b751c <redacted> + 296
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	26  QuartzCore                          0x00000001863ae954 <redacted> + 232
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	27  QuartzCore                          0x00000001864bd2ac <redacted> + 52
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	28  QuartzCore                          0x00000001864b6f48 <redacted> + 1672
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	29  QuartzCore                          0x00000001864283d4 <redacted> + 520
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical:
	30  QuartzCore                          0x000000018644fb40 <redacted> + 540
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	31  QuartzCore                          0x00000001863a174c <redacted> + 928
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	32  QuartzCore                          0x0000000186455c0c <redacted> + 240
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	33  CoreFoundation                      0x0000000182401090 <redacted> + 188
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	34  CoreFoundation                      0x000000018241be00 <redacted> + 56
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	35  CoreFoundation                      0x000000018241b504 <redacted> + 440
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	36  CoreFoundation                      0x0000000182418fd8 <redacted> + 2196
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	37  CoreFoundation                      0x0000000182338c58 CFRunLoopRunSpecific + 436
2018-0
6-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	38  GraphicsServices                    0x00000001841e4f84 GSEventRunModal + 100
2018-06-27 13:21:41.126 MMR.iOS[4532:7618522] critical: 	39  UIKit                               0x000000018ba915c4 UIApplicationMain + 236
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	40  MMR.iOS                             0x00000001036b2cd0 MMR.iOS + 20622544
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	41  MMR.iOS                             0x000000010363991c MMR.iOS + 20125980
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	42  MMR.iOS                             0x00000001036398dc MMR.iOS + 20125916
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	43  MMR.iOS                             0x0000000102683d80 MMR.iOS + 3652992
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	44  MMR.iOS                             0x0000000102a41b48 MMR.iOS + 7576392
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	45  MMR.iOS
                  0x0000000104c02eb0 mono_pmip + 22316
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	46  MMR.iOS                             0x0000000104c6aac4 mono_pmip + 447296
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	47  MMR.iOS                             0x0000000104c6fcc8 mono_pmip + 468292
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	48  MMR.iOS                             0x0000000104beb300 MMR.iOS + 42873600
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	49  MMR.iOS                             0x0000000104d14fbc _Z9__isctypeim + 47160
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	50  MMR.iOS                             0x0000000102339014 MMR.iOS + 200724
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical: 	51  libdyld.dylib                       0x0000000181e5856c <redacted> + 4
2018-06-27 13:21:41.127 MMR.iOS[4532:7618522] critical:
=================================================================
Got a SIGSEGV while executing native c
ode. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.
=================================================================

Basic Information

Version with issue:  1.60.1
Last known good version:  1.59.3
IDE:  Visual Studio 2017
Platform Target Frameworks:

iOS:  11.1

Target Devices:
iPad Pro

Screenshots
Reproduction Link

VS bug #738687

I was not able to reproduce this. Are you able to attach a small repro or maybe the values that it crashes on?
It may be the case that something is zero or out of order. If this is the case, I probably need to add some more error checking to make sure it doesn't just crash randomly, but does so with a real .NET exception.

This is something that we will be looking at in the future.

All right. I finally managed to reproduce this. It has to be a physical device running the later versions of iOS.
In an effort to find out what was crashing, I enabled the generation of the dSYM (https://github.com/mono/SkiaSharp/pull/742) - which is actually good for everyone.
Now, the app no longer crashes. No idea what caused the crash, but it is "fixed". Once the PR builds and is merged, then I will release a preview to see if that solves all the problems for everyone.
Thanks for reporting this issue, the world is soon going to be (hopefully) a better place.

Appears so. That is very worrying. But, I did update Xcode on my local machine. I'm building on CI now. If the problem comes back from that artifacts, then it may be a clang optimization issue that was fixed on the new Xcode. I shall check and track it.
This has happened before, mostly on Android though. And Linux.

Sadly, no deal. I am still having a look at this - I thought things were working, but it is very deceiving. The crashes are very random, and the app still seems to "run" (more like just exist) after the crash.
Very random. Sometimes the app will run fine for a minute, other times it crashes before the timer even ticks. I am trying to isolate the cause, maybe something is getting disposed mid-draw.
Will keep you updated.

RIGHT! Solutions!
So, I figured out what was happening - at least on my side. I believe that the NuGet update was not actually going through and it was still using v1.60.x. As a result, the issue was still from the previous release. I am not sure what the fix was since it is 8 releases later, and many compiler changes, but v1.68.x is working.
When you update the NuGet, make sure to delete the obj/bin from all the solution projects. I am not sure if this is a NuGet or Visual Studio issue, but it actually does not use the new native files.
The way I found this out was when trying a SKGLView view to see if this was just a raster bug or affects GPU as well. I then got an "entrypoint not found" exception for something that should be there as it was added to the initial 1.68.x release.

If this is still an issue, just re-open.

For those either 1. Still suffering from this issue or 2. Using an older version of SkiaSharp and cannot update for whatever reason:
On a project where I work, we were running into this (We are forced to user an older version of SkiaSharp). It seems to be something with the handling of floating point handing under the hood.
Our solution was to use something along the lines of:
float CenterX = (float)Math.Round(bounds.Width / 2.0, 2, MidpointRounding.ToEven); float CenterY = (float)Math.Round(bounds.Height / 2.0, 2, MidpointRounding.ToEven); var shader = SKShader.CreateSweepGradient(new SKPoint(CenterX, CenterY), colors, new float[] { 0.0F, (float)Math.Round(<SomePercentage>, 2, MidpointRounding.ToEven) });
Our use case is a circle where the color changes depending on a percentage. We've noticed that older versions of SkiaSharp don't handle certain floating point numbers very well. We've had fairly good success with this rounding method though (even though it's obviously not ideal).


Automated cherry pick of #11148: feat(ansible): add rolePublic and timeout options

Cherry pick of #11148 on release/3.7.
#11148: feat(ansible): add rolePublic and timeout options

Codecov Report

Merging #11149 (d6791e6) into release/3.7 (0ff3997) will decrease coverage by 0.17%.
The diff coverage is 2.17%.

@@               Coverage Diff               @@
##           release/3.7   #11149      +/-   ##
===============================================
- Coverage         5.98%    5.81%   -0.18%
===============================================
  Files              848      901      +53
  Lines           131795   138945    +7150
===============================================
+ Hits              7887     8077     +190
- Misses          123206   130163    +6957
- Partials           702      705       +3

Flag
Coverage Δ

aFlag
5.81% <2.17%> (-0.18%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/auth_totp.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/idp.go
1.84% <0.00%> (ø)

pkg/apigateway/handler/init.go
100.00% <ø> (ø)

pkg/apigateway/handler/misc.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/resource.go
0.00% <0.00%> (ø)

pkg/apis/const.go
0.00% <0.00%> (ø)

pkg/apis/input.go
0.00% <0.00%> (ø)

pkg/apis/list.go
0.00% <ø> (ø)

pkg/appsrv/appsrv.go
44.32% <0.00%> (-4.35%)
:arrow_down:

... and 284 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14f3d77...d6791e6. Read the comment docs.


python39Packages.pytest-xdist is non-deterministic

Describe the bug
My ulteriour goal is o track down why python-xdist's tests fail occasionally for me. A step in that direction is to try to rebuild a package locally a few times. Unfortunately the package is not deterministic:
$ nix build -f . python39Packages.pytest-xdist --rebuild
error: derivation '/nix/store/vxlbh98pfhzvwpyq1xqmd1wgdj0zk6c9-python3.9-pytest-xdist-2.3.0.drv' may not be deterministic: output '/nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0' differs

Notify maintainers
@dotlambda
Metadata
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.14.3, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.4pre20210908_3c56f62`
 - channels(root): `"nixos-21.11pre317242.bc9b956714e"`
 - channels(slyfox): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: python39Packages.pytest-xdist

The only diff is in some pycache files .../python3.9/site-packages/xdist/__pycache__/__init__.cpython-39-pytest-6.2.5.pyc:
$ diffoscope '/nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0' '/nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0.check'
--- /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0
+++ /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0.check
│   --- /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0/lib
├── +++ /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0.check/lib
│ │   --- /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0/lib/python3.9
│ ├── +++ /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0.check/lib/python3.9
│ │ │   --- /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0/lib/python3.9/site-packages
│ │ ├── +++ /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0.check/lib/python3.9/site-packages
│ │ │ │   --- /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0/lib/python3.9/site-packages/xdist
│ │ │ ├── +++ /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0.check/lib/python3.9/site-packages/xdist
│ │ │ │ │   --- /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0/lib/python3.9/site-packages/xdist/__pycache__
│ │ │ │ ├── +++ /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0.check/lib/python3.9/site-packages/xdist/__pycache__
│ │ │ │ │ │   --- /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0/lib/python3.9/site-packages/xdist/__pycache__/__init__.cpython-39-pytest-6.2.5.pyc
│ │ │ │ │ ├── +++ /nix/store/vgdj386fvjdk3fjjpb70swibmly2r38f-python3.9-pytest-xdist-2.3.0.check/lib/python3.9/site-packages/xdist/__pycache__/__init__.cpython-39-pytest-6.2.5.pyc
│ │ │ │ │ │ @@ -1,8 +1,8 @@
│ │ │ │ │ │ -00000000: 610d 0d0a 0000 0000 bd10 3561 3101 0000  a.........5a1...
│ │ │ │ │ │ +00000000: 610d 0d0a 0000 0000 ae81 4d61 3101 0000  a.........Ma1...
│ │ │ │ │ │  00000010: e300 0000 0000 0000 0000 0000 0000 0000  ................
│ │ │ │ │ │  00000020: 0002 0000 0040 0000 0073 4a00 0000 6400<EMAIL_ADDRESS>│ │ │ │ │ │  00000030: 6401 6c00 5a01 6400 6401 6c02 6d03 0200  d.l.Z.d.d.l.m...
│ │ │ │ │ │  00000040: 0100 6d04 5a05 0100 6400 6402 6c06 6d07  ..m.Z...d.d.l.m.
│ │ │ │ │ │  00000050: 5a07 6d08 5a08 6d09 5a09 6d0a 5a0a 0100  Z.m.Z.m.Z.m.Z...
│ │ │ │ │ │  00000060: 6400 6403 6c0b 6d0c 5a0d 0100 6700 6404  d.d.l.m.Z...g.d.
│ │ │ │ │ │  00000070: a201 5a0e 6401 5300 2905 e900 0000 004e  ..Z.d.S.)......N

What are they? Could it an effect of missing propagated pytest inputs (and thus cache is built against different version of pytest)?

Looks like the only change is timestamp difference:
--- /dev/fd/63  2021-09-24 09:46:15.642812835 +0100
+++ /dev/fd/62  2021-09-24 09:46:15.642812835 +0100
@@ -1,5 +1,5 @@
 magic b'610d0d0a'
-moddate b'bd103561' (Sun Sep  5 19:47:25 2021)
+moddate b'ae814d61' (Fri Sep 24 08:43:42 2021)

Python-3.9 should already honor SOURCE_DATE_EPOCH. I wonder why it does not work here.

Might be an effect of pytest-xdist-2.3.0/setup.py: use_scm_version={"write_to": "src/xdist/_version.py"},? I see other python packages in nixpkgs sed it out:
pkgs/development/python-modules/FormEncode/default.nix:    sed -i 's/use_scm_version=.*,/version="${version}",/' setup.py

Might want to check out #22570

Might want to check out #22570

Oh, nice! It has some hints about manual bytecode generation. I'll take a closer look.
Meanwhile filed request against diffoscope to get better default rendering of .pyc diffs: https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/278

Aha, now I get it a bit better: pytest only mimics python in how it writes bytecode (for better assertion handling), but does not exactly follow it. The hint is that deviations always happen in .*-pytest-.*.pyc files.
pytest generates it's own headers in https://github.com/pytest-dev/pytest/blob/2aaea20cb219e7d66751f51508ba2a5f80c4c009/src/_pytest/assertion/rewrite.py#L279-L295
Which is: u32(MAGIC) | u32(0) | u32(mtime) | u32(size). mtime is an unstable bit here.
cpython generates headers in https://github.com/python/cpython/blob/2f180ce2cb6e6a7e3c517495e0f4873d6aaf5f2f/Lib/importlib/_bootstrap_external.py#L694-L712
Which is (assuming SOURCE_DATE_EPOCH is set): u32(MAGIC) | u32(0x3) | u64(source_hash) | u32(size). No unstable bits here.

I noticed that pytest itself works it around by wiping out pytest bytecode for it not being stable: https://github.com/NixOS/nixpkgs/blob/6bb29572e4dc9410401bd6b6d166549be8427c78/pkgs/development/python-modules/pytest/default.nix#L71-L72
Is it desirable to install those file? (suppose we fix determinism for them) Or it's always a sign of unexpected leftovers?
Casual scan on my local system shows quite a few -pytest-.*.pyc files:
$ find /nix/store -name '*-pytest-*.pyc' | unnix | tr '/' ' ' | awk '{print $2}' | uniq | sort -u | uniq
python3.9-aiohttp-3.7.4.post0
python3.9-async_generator-1.10
python3.9-Bottleneck-1.3.2
python3.9-debugpy-1.4.3
python3.9-et_xmlfile-1.0.1
python3.9-flaky-3.7.0
python3.9-hypothesis-6.17.3
python3.9-nbval-0.9.6
python3.9-numpy-1.21.2
python3.9-pandas-1.3.2
python3.9-pytest-6.1.2
python3.9-pytest-flake8-1.0.7
python3.9-pytest-forked-1.3.0
python3.9-pytest-mock-3.6.1
python3.9-pytest-randomly-3.10.1
python3.9-pytest-timeout-1.4.2
python3.9-pytest-xdist-2.3.0
python3.9-pytest-xdist-2.3.0.check
python3.9-pyzmq-22.2.1
python3.9-scipy-1.7.1
python3.9-SQLAlchemy-1.4.22
python3.9-SQLAlchemy-1.4.23
python3.9-SQLAlchemy-1.4.25
python3.9-tables-3.6.1
python3.9-typeguard-2.12.1

Proposed bytecode cleanup as https://github.com/NixOS/nixpkgs/pull/140179.
It does not fix all the packages above as some of them bypass pytest hook and run py.test directly. We can either port them to a hook or do the same manual cleanup.

Was fixed by #140179


Add cloning for Shopify demo

Hey Vercel Team, first off thank you for releasing the Shopify provider for Next Commerce, we've been really looking forward to this!
I noticed that you cannot clone into Vercel with the Shopify demo, you are forced to install BigCommerce. Is the demo for Shopify available somewhere that lets us clone it into Vercel?
It would be great to link it up to a development store and have a good starting point.
Thanks!

Hello @nikushx ! Thank you for the kind words!
The integration for Vercel is pretty close to be done, we need an approval on Shopify's Marketplace because this is an official public app. So, this will land hopefully soon!

@okbel Are you able to provide any insight as to what the App will do? As far as I can see, Next Commerce can pull from all the data it needs via Storefront API. What will the App allow us to do additionally? Trying to see how this all fits into using Next.js to host a Shopify frontend.


Jetbrains Debugging - PhpStorm, Webstorm, etc

Do you have any idea on how you can get the debugging for the Node side to work in phpstorm or webstorm?
It successfully launches the program but I can't breakpoint any of the electron side.

I was able to successfully debug the node.js side by doing the following.

For the Run / Debug configuration I run Node (not NPM) and run this file. .vscode\.debug.script.mjs

I had to disable the vite-electron customStart by commenting out the following lines in vite.config.ts
 // ...(process.env.VSCODE_DEBUG
 //   ? [
 //     // Will start Electron via VSCode Debug
 //     customStart(debounce(() => console.log(/* For `.vscode/.debug.script.mjs` */'[startup] Electron App'))),
 //   ]
 //   : []),

After that I can set breakpoints in main/index.tsx and it works great.

You can find a way to inject process.env.VSCODE_DEBUG

When the customStart plugin is provided, it is possible to disable autostart without doing anything else.
plugins: [customStart()],


[Minor] Reformat ClassLoaderTest

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (677bdb2).
Report is 1291 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (677bdb2). Click for more details.
HEAD has 48 uploads less than BASE

Flag
BASE (59551e4)
HEAD (677bdb2)

integration
7
2

integration2
3
2

temurin
12
2

java-21
7
2

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14394       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <ø> (-61.75%)
:arrow_down:

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Improve ConstraintAction Error Messages

Tickets addressed: Hotfix
Review: By commit
Merge strategy: Merge (no squash)

Description

Follow up to #1169.
The action will now correctly distinguish between a plan never being simulated and a specified sim dataset not existing when erroring on resultsHandle$ being empty.
Additionally, the serializer for SimDatasetMismatch now refers to the correct extension.
Verification

A bindings test has been added. The bindings test fo the SimDatasetMismatch exception has been updated.
Documentation

No docs changes needed.

I'm highly supportive of improving these error messages 🚀 I was preparing for a demo this morning, and ran into "input mismatch exception". I think longer term we'll want the UI to specially handle these messages.
As far as this PR is concerned, I want to workshop the messages to make sure they are accurate enough to be actionable. The two cases seem to be:

The provided simulation dataset id either doesn't exist, or it does exist, but isn't associated with this plan. Can we put this succinctly?
No simulation dataset id was provided, and the latest revision of the plan has never been simulated

The two cases seem to be:

There are three cases, actually:

There was a simulation dataset id specified, but that dataset doesn't exist
There was a simulation dataset id specified, and that dataset exists, but it's a dataset for a different plan
There was no simulation dataset id specified, and the plan has never been simulated (note that plan revision is not actually used, it only still exists as a param due to the unused UncachesSimulationService. All checking a plan revision does is prove that the plan exists)


Simplify the logic of inputstream to bytebuffer, and move the helper to FluxUtils

Follow up: https://github.com/Azure/azure-sdk-for-java/pull/5716

@sima-zhu can you explain why this is blocking Preview 5?

Removing from blocking-release for now; please re-add if this is a must-have API breaking change or another critical bug blocking a mainline scenario

This is not a blocking release change. Thanks for taking action.

Closing this in favor of #9716 as the issues are the same but that has more discussion.


Log only dirty fields doesn't behave as expected when used with scope

I'm updating a video status by using this code
$video = Video::identifier()->addSelect("status")->where("id", "15")->first();
$newStatus = ($video->status != "active" ? "hidden" : "active");

$video->update(["status" => $newStatus]);

In the properties column of the activity_log table I'm getting this
{
  "attributes": {
    "slug": "MPnMwgXCU48YogB",
    "title": "Video Tile Placeholder",
    "duration":<PHONE_NUMBER>,
    "status": "hidden",
  },
  "old": {
    "slug": null,
    "title": null,
    "duration": null,
    "status": "active",
  }
}

instead of expected
{
  "attributes": {
    "status": "active"
  },
  "old": {
    "status": "hidden"
  }
}

If I remove the scopeIdentifier it works expectedly.
I'm using:

Laravel: 5.8.10
laravel-activitylog: 3.4.0

Hey,
could you provide your settings in the model?
I expect you have static::$logOnlyDirty = true!? But what have you set static::$logFillable, static::$logUnguarded, static::$logAttributes and static::$logAttributesToIgnore to?
I would like to reproduce it in a unittest and after this try to solve the issue.

I am using these settings:
protected static $logOnlyDirty = true;
protected static $logUnguarded = true;

I think the problem is with the $model->fresh() method. The fresh method reloads without the scopes & selected columns. It's just a guess though.

Hey @Gummibeer, were you able to reproduce the problem?

@istiak-tridip sorry, not yet and I have a lot of tasks for the next two weeks.
So I think that I won't find time to debug, fix, release or discuss anything.
I will pass the ball to @spatie team.
I hope you understand it - for sure feel free to fix it yourself and send a PR.

I am using these settings:
protected static $logOnlyDirty = true;
protected static $logUnguarded = true;

I think the problem is with the $model->fresh() method. The fresh method reloads without the scopes & selected columns. It's just a guess though.

Please provide a steps to reproduce this error... cant manage to reproduce it!

@istiak-tridip in best case a PR with a failing Testcase. This way we have a real goal and way to check if we've solved it.

$model->fresh()

Thanks for the quick response and the PR.
I'm currently working on solving this but since I'm kinda new to the codebase I wish that you enlighten me more about why we use fresh  in this situation, particularly in this
        $properties['attributes'] = static::logChanges(
            $processingEvent == 'retrieved'
                ? $this
                : (
                    $this->exists
                        ? $this->fresh() ?? $this
                        : $this
                )
        )

Answer: this is one of the oldest parts of this package - sometimes re-arranged but never changed.
It was part of this package before I've joined in. So it's in since Laravel 5 versions.
I would remove it and check if/which tests fail. The names of the failing tests will/should explain it more.^^
If nothing fails: it should be safe to remove it.
I think that this was added to get database default values - as they wouldn't be part of the saved model instance.
If this has to be changed I will reject supporting attribute subsets as, for me, it's the less common case of both we have to decide between and it's also the one that would require breaking code changes.
Personally I've never used attribute subsets on model queries and primary not for manipulating the model instance. The only way I could think about to solve this would be to access, if available, the attribute subset of the original select() query and pass it down to the fresh() one or to a Arr::only() call. Possibly even worth an issue to the laravel framework itself that the limited attribute selection isn't removed during a fresh() call.

I tend to agree more with @Gummibeer since I spent more than 5 hours across multiple days fiddling around with this issue.
I tried to remove
        $properties['attributes'] = static::logChanges(
            $processingEvent == 'retrieved'
                ? $this
                : (
                    $this->exists
                        ? $this->fresh() ?? $this
                        : $this
                )
        )

and replace it with
        $properties['attributes'] = static::logChanges(
                    $this
                )
        )

8 test have failed, the common failure between them was that the package was relaying on fresh() to fetch all columns from database then filter them based on static attributes (options) and what not.
I think this is an edge case that only 1% of people will fall into because local scopes isn't designed to handle filtering columns on the query.
Plus Laravel doesnt support passing scopes nor selected attributes to the fresh method, based on Mohamed Said's response on this issue on laravel repo.

Fresh doesn't use scopes by default, this is by design, if you want a different behaviour you can add your own version of fresh in a base model.
To me that scope you're adding is not the best approach, using am eloquent mutator is a better approach.

Based on all of the above, we may close this issue considering it an edge case that will probably wont affect users who use scopes as they intended. (no offence @istiak-tridip :smile:).

I agree with you, @nagi1.
I only needed this use case for a specific project and I bypassed this issue by creating a fork (with failing tests 😳).
You guys can go ahead and close this at your convenience.

@nagi1 THANKS A LOT for your work on this! 🤩🥳
🙏🚀🎉
You did a great job in verifying my opinion.^^


Enhancement: Make file name visible for Labcam User

Right now, there is no possibility to check if foto was uploaded but to check the foto itself.
If the fotos of the upload are quite similar it would be helpful to display the name of the file somewhere in Labcam, e.g in the detailed view where the note is displayed.

The Filename of the picture now is displayed in the detailed view.


Level Loader

The game should have a level load Manager so that it does not store all levels information on memory. This should replace the assets.AvailableLevels array, so we could said to the level loader load level for index and doing that will drop references to other level information that it has.

Last commit addresses this issue.


file extention not working on tentaclerape.net

Bug description
the file extention are messed up for image file (video seems fine)
Steps to reproduce
simply download any tentaclerape image.
Expected behavior
a dot jpg, gif, png file.
Context
[12:20:05.187][Info] [tentaclerape.net][Html] Parsed page https://tentaclerape.net/post/list/1: 26 images (28), 15 tags (15), -1 total (130300), 2606 pages (2606)
[12:20:06.183][Info] Loading image from https://tentaclerape.net/_thumbs/25679375fdf5cdea8839d81acc985b43/thumb.jpg
[12:20:06.185][Info] Loading and saving image from https://tentaclerape.net/_thumbs/25679375fdf5cdea8839d81acc985b43/thumb.jpg in C:\Users\Moi\AppData\Local\Temp\Grabber\fbec583d-5da3-42c3-a027-3b04ce0278d5.php
[12:20:06.189][Info] Image received from https://tentaclerape.net/_thumbs/25679375fdf5cdea8839d81acc985b43/thumb.jpg
[12:20:08.431][Info] Loading and saving image from https://tentaclerape.net/./index.php?q=/image/83786.jpg in D:\Avatars\tentaclerape.net\und\und\anonymous - - 83786 - 25679375fdf5cdea8839d81acc985b43.php

query is : %websitename%\%search%\%copyright%\%character%\%artist% - %rating% - %id% - %md5%.%ext%
So rating don't work too, not a big problem

I just pushed a fix for the extension, good catch! :+1:
Seems like they

So rating don't work too, not a big problem

AFAIK, ratings are simply not supported by Shimmie websites.

Fixed, goodjob !


[REG2.067a] Issue 14130 - ICE following error in template parameter default value

https://issues.dlang.org/show_bug.cgi?id=14130

There's a mismatch in the error message check.

Oh, it's a difference in slash and backslash. Fixed.

Auto-merge toggled on


enable podman-remote pod rm

add the ability to delete a pod from the remote client.
Signed-off-by: baude<EMAIL_ADDRESS>

No luck tonight @baude, another merge victim.

LGTM
@vrothberg @rhatdan @TomSweeneyRedHat PTAL

/lgtm
Also tested locally :+1:


Give feedback on Blaze Components

I am asking the community to give some feedback on how you are using Blaze Components. Examples of apps you build them? Patterns you like? But most importantly what are possible issues you are having? All that would help guide the future of the project.

Well, first thank you for blaze-components! I used it for Wekan which is the kind of application that inherently requires a number of UI components to work together (with the ability to compose them) and Blaze didn’t have the long awaited API to handle that. I've been considering the switch to React (and I still do, see https://github.com/wekan/wekan/issues/299) but React still misses a good integration with the Meteor ecosystem, and keeping the Blaze runtime was more easy. So I decided to give Blaze-components a try.
I've been pretty happy with that choice. Since you are asking for issues, here are the one I encountered:

Fighting with Blaze data context, say I have a popup that display a list of member and I use it in 3 different places. With React props I can call it with the appropriate data, eg.<MemberPopup members={board.activeMembers()} />

With Blaze I have to rely on the blaze data context (eg ../members) which was rely fragile during the UI refactoring — modifying one thing somewhere always broken something else somewhere else.

I would kind of like to define a component in a single file, not a .js, .jade and .styl, ie the way it work with React + JSX + inline style. I'm currently playing with React Native, and I really find this model convenient mostly because (1) related things are in the same place (2) css isolation (3) the same Turing complete language (JS) for all usages (logic, views, and style).

I'm not sure how to create “abstract” components, for instance I have a concept a number of fields (the list title, the card title, the card
description) that can be edited with a click on them. This display a form with a input field and a submit button. If the user close these inlined forms by mistake I also want to keep his draft in some sort of global storage (I already implemented for the card description by the way). I'm not sure what the canonical way to handle this should be.

Max

The main reason to use it for me personally is the OOP approach of coding. It's what felt natural (and logical) to me. I don't use mixins at all though, although I appreciate what their goal and meaning are, I just didn't felt the need and rather went for an inheritance approach.
Something that might become more clear once I start using BC's in more specific use cases, but for now what feels "fuzzy" is a right way for inter-component communication. I come from an Adobe Flex/AS3 world. Where a lot of these challenges have been fixed by relying on event dispatching a lot more. I know BC's support all this as well at it's core, but falls back to DOM events. Just like Blaze (I guess? Correct me if I'm wrong). So something that would allow for direct events/listeners on component level would feel comfortable for me (taking my background into account).
A small (very small) "huh" moment I had, was why I need to register components after defining them. But that might just be js-related.
Cheers!

Thanks for the feedback! My thoughts:

With Blaze I have to rely on the blaze data context (eg ../members) which was rely fragile during the UI refactoring — modifying one thing somewhere always broken something else somewhere else.

That is so interesting to me that people have so much issues with this. I must say that I do not get it. :-) I think maybe the issue is that I have not made it clear enough what is the way to use that in Blaze Components, over Blaze, and people get stuck with Blaze issues? I really do not get the issue. :-)
See my comment here for another take on answer this concern.
The point with Blaze Components is that you should not be using ../members to access the data context, but you use componentParent().data().members (in code). So I find navigating the component tree much more stable than navigating data context tree. Also, internally, I also use some helper functions to find ancestors and descendants based on component class, and then use data context there. So then things work pretty well as you move things around.
This is also why there is no parentData method, because you do not need it in my view. You move between components and then you ask for data context of that component you want.
Maybe I should provide more functions and instructions for this.
Is this addressing what you are talking? Or not? Why are props still better in your opinion?
There is another way to communicate between components and this is to expose APIs between them (methods). And then call them.
Hm, I am seeing that this assumes all those goodies for navigating the tree. Maybe I should really or put this into a package or add it to core Blaze Components. So imagine a jQuery selectors for selecting ancestor or descendant components.

I would kind of like to define a component in a single file, not a .js, .jade and .styl, ie the way it work with React + JSX + inline style.

With new build system this is something you could develop on top of Blaze Components, no? See meteor-sideburns (and my comment). So this could probably work in the other direction as well?
I prefer separate files, but I think this can probably be doable? A package would be welcome. :-)

If the user close these inlined forms by mistake I also want to keep his draft in some sort of global storage

Why global storage? Why not component state? So I could imagine a component like:
<template name="FormInput">
  {{#if editing}}
    <input type="text" value={{value}} />
  {{else}}
    <div>{{value}}</div>
  {{/if}}
</template>

And you switch between editing and non-editing mode, but keep the state of the value as a state of the component?

I am trying to find actionable items, so have also in mind to suggest what concretely to open (tickets welcome).

And you switch between editing and non-editing mode, but keep the state of the value as a state of the component?

So something similar to examples from the tutorial?

On the first point, I actually do use the componentParent method. My issue is that a component has to have some knowledge about its external context (in this case, the parent component) instead of the caller explicitly giving the child component the data through props. It also happen that different instances of the component have to get the data from different places, for instance on the board view I get the members using this.getMembers() but on the card I have one level of indirection this.getBoard().getMembers. I believe it is a good separation of concerns for the caller to give the data the components needs to render, without the child having to make assumptions about the parent context.
For the second question, I put the drafts in the global storage and not in a local component state (as I was formerly) because often the component get destroyed and I still want to keep the data, for instance if I'm editing a card description and inexpediently close the card (or if I open another card B on purpose and still expected my draft on A to be there).
Generally speaking I tend to think that component local storage aren’t a good idea, I think that a global storage tree from which each component only see its assigned branch is a more powerful concept because it allows things like serializing the whole state and restore the application in the exact same state, and other things. There are quite a few discussions about this idea in the Redux and Clojurescript communities.

Where a lot of these challenges have been fixed by relying on event dispatching a lot more.

OK, I see I will have to discuss this a bit more in the README. :-)
So no, I am pretty against the event-based communication because it is really hard to manage it as system grows. You have to then make sure about event propagation, stopping and so on.
What I think is a better approach is that you traverse a tree of components and call methods on them.

was why I need to register components after defining them. But that might just be js-related.

You do not have to. You have only if you want them to be accessible from templates. So {{> Foo}}. For that, Foo has to be registered.
And yes, that is a bit of a JavaScript limitation. Open to suggestions, but I think this is the cleanest one.
(BTW, if you do not register them, then you have to still name them by calling componentName.)

I explained a bit about ideas of inter-component communication here: #82

I believe it is a good separation of concerns for the caller to give the data the components needs to render, without the child having to make assumptions about the parent context.

Isn't this what data context is then about? Giving data to a child? Not sure anymore what is then a problem. (Sorry, I would really like to understand the problem.)

Generally speaking I tend to think that component local storage aren’t a good idea, I think that a global storage tree from which each component only see its assigned branch is a more powerful concept because it allows things like serializing the whole state and restore the application in the exact same state, and other things.

Oh, I will ask if we can open source a mixin for this. :-) So we have this, a mixin which ads serializable state to each component, and then store them in a tree structure into the database. So even if you reload the page, you get back the same UI state. We use that for our in-site window manager made with Blaze Components. You do not want for user to reopen all windows all the time when things gets reloaded. I think you could use that as well. You can imagine even storing into it things like scrolling position, which cards are expanded, and also any form input state.
So then you have local state which you do not want to store, and seriazable local state which is stored and populated for you automatically when component is created.
BTW, this is a pretty short piece of code. :-)

Not sure if this has been asked before, but, I'm wondering if it is somehow possible to pass data-* attributes to a component without those attributes explicitly being defined in the component itself.
E.g. currently I need to explicitly define the attributes in my component if I want those attributes to be rendered in the page:
<template name="TextInputComponent">
  <input name={{name}} id={{id}} />
</template>

In case of my TextInputComponent I might want to augment it with a data-* attribute so that when it's value changes, in it's listener, I can find out more context to where and what the TextInputComponent actually belongs to. E.g. I might have a table with hundreds of TextInputComponent instances.
The only option I currently have is to create a specialised subclass component that is data-* attribute aware which, as a nasty side effect, has the problem that I have to duplicate it's corresponding template. As you might understand, my actual component isn't as simple as in the example above.
Any ideas and insights much appreciated.

@northern: I think this discussion should be more suited for a dedicated ticket.

Thanks for all the feedback. Closing the ticket for now.


retire old commands

retire all commands replaced by iab, so that we have less duplicate code.
BREAKING CHANGE!

done


Design and Build KPT: Article Left Menu Page

[ ]  Design in Figma
[ ]  Build in Codepen
[ ]  Review

will address in page templates project


Move default Link Resolver into its own package

Looks good to me! Could look better, but still looks good!


update to pixi 5

Update required to support Pixi 5.

Did you ever get this working for pixi v5?

https://github.com/siri4/revolt-fx


uniform=false does not remove element from the dom

It seems that I need to set uniform=true in order for the previous elements to be removed from the DOM.

This is intentional. We can't ensure the height of elements when uniform is false, so we must keep them in the DOM. It isn't sufficient to store the height they were last seen at, because that height could very likely change in the event of a window resize, and then everything is busted.

that makes sense.


🐔[Release 1.4.170 BUG] Importing any builds not working!

dervish build
imports
Lovel 100 Ascendant
Lejel 91 Ascendant
Error:
In 'OnFrame': Modules/Bulld.lua:133: attempt to index field 'malnOutput' (a nil value)
stack traceback:
Modules/Build.lua:133: in function 'GetProperty
Classes/Control.lua:80: in function 'Getsize'
Modules/Build.lua: 124: In function 'GetProperty
Classes/Control.lua:57: In function 'GetPos'
Classes/Controllua:60: In function 'GetPos!
Classes/Edit Control.lua:186: in function 'Draw
Classes/ControlHost.lua:77: In function 'DrawControls'
Modules/Build.lua:807: In function 'Call Mode'
ModulesMain.lua:254: in function <Modules/Main.lua:233>
[C]: in function 'PCall'
tal Tools\POWER-Tools\Path of Building\Launch.lua:99: In function <...ync Sync Total Tools\POWER-Tools\Path of Building\Laun
Press Enter/Escape to Dismiss, or F5 to restart the application.

I'm having the same problem

That is happening to me as well. Tried updating/uninstalling and reinstalling. Still happening.

Having the same problem here, this needs to be addressed ASAP! This is basic functionality, this should be caught by automated tests (i'm a dev myself so I know what I'm talking about).... Added screenshot of the error as well

Having the same problem here, this needs to be addressed ASAP! This is basic functionality and should be caught by automated tests (i'm a dev myself so I know what I'm talking about).... Added screenshot of the error as well

same here

The problem still exists, does anyone know sollution for this?

The problem still exists, does anyone know sollution for this?

https://pathofbuilding.community/


Rfontanarosa new rule form

Purpose

Related Issues
fix #1219
Closes CEO-133
Submission Checklist

[x] Commits include the JIRA issue and the #review hashtag (e.g. CEO-### #review <comment>)
[x] Code passes linter rules (npm run eslint/clj-kondo --lint src)

Testing
As an Admin, When I create or review a project, And I clicked on "Survey Rules", Then the New Rule section is renewed, responsive and working.
Screenshots

src/css/custom.css
599-601, This does not appear to be used
src/js/project/SurveyRules.js
9, Use destructuring for state, props, and context. This has not been enforced in the past, but moving forward its important to start doing. const {setProjectDetails, surveyRules} = useContext(ProjectContext);
138, 153, Use destructuring for state, props, and context.
206, 220 Use destructuring for state, props, and context.
209 You could use destructuring here
210, 288, 378, 467, 482, 589, 601, 616, 628 use question.id instead of uid.
{availableQuestions.map(({id, question}) =>
                                <option key={id} value={id}>{question}</option>)}

285, 299, 309 Use destructuring for state, props, and context.
376, 390 Use destructuring for state, props, and context.
465, 480, Use destructuring for state, props, and context.
585, 597, 600, 612, 624, 627 Use destructuring for state, props, and context


feat(Analysis.Distribution.BoundedContDiffMap): space of smooth functions with all derivatives bounded

Note to the potential reader: the goal of this was to have an intermediate step before defining the space of smooth functions with support in a fixed compact. However I decided to go straight to that in #5912, so I'll close this PR.


Ubuntu downloads - linking to ubuntu appdb?

Since Minetest 0.4.13, the ubuntu download page (stable) has linked to http://packages.ubuntu.com/search?keywords=minetest, rather than https://code.launchpad.net/~minetestdevs/+archive/ubuntu/stable/+packages.
These packages are not recent!
Why has this link changed, and why not direct users to use the ppa?
I think the ppa is ppa:minetestdevs/stable.

Ubuntu is well aware of the fact that there is a new minetest release. However, due to their own release freezing rules it won't appear in 15.10.
Their latest package is 0.4.12 which is fairly recent, and people should usually prefer using their own distro's package repository before trusting third parties.
What about linking to both? As in:
* Ubuntu / Linux Mint
* Ubuntu / Linux Mint (PPA)

There would need to be a clear warning that the PPA is up-to-date, but the other is not. Also mention the PPA name.

There is already one, right above the list. The ppa name can be retrieved if clicking the link.


Player UI partially unavailable in fullscreen on iPad Pro

Describe the bug
Going into fullscreen mode with the web player on an iPad Pro (with rounded corners) will render the buttons in the lower left and right corners (skip 10s back, leave fullscreen) unusable.
Also, using the progress slider in the center to skip in a VOD isn't always possible on the iPad Pro since it's partially obscured by iPadOS's "homebar".
To Reproduce
Steps to reproduce the behavior:

Open website with Safari on an iPad Pro (2018+)
Open VOD
Go into fullscreen mode
Try using the skip back button, leave fullscreen button or the progress slider.

Screenshots

Smartphone (please complete the following information):

Device: iPad Pro 11" (2018)
OS: iPadOS 14.4.1
Browser: Safari

Yikes, thanks for letting me know!

This is weird:
On my iPad Pro (12.9-inch) (3rd gen, released in Late 2018) everything works fine.
I don't see how the admittedly a bit larger display could fix the issues you described. For example the scrollbar works for me and that should not be size-specific.

The buttons are a bit small on mobile in general though..
Maybe this is the issue?

For me (IPad Pro 5. gen) the UI is visible as well, just not clickable. I'm considering a different player, until then I'll add a margin for iPads and maybe resize the UI later today.

Seems fixed


uploaded gif 1st frame glitched

this is a great utility, thank you. i'm using it to upload gifs to the pixoo 64 and it's working great except for the 1st frame of each gif gets glitched - meaning colors are slightly off, sharpness too. super noticeable with looped gifs.
i wonder if there's some fine tuning to that process that needs to take place?

Glad you like the project.
As mentioned in the README, pixoo-rest makes use of the pixoo-library.
So all the heavy-lifting (image conversion, etc.) is being done there.

So all the heavy-lifting (image conversion, etc.) is being done there.

Let me take that back (I just checked the code). :smirk:
Actually, the GIF-conversion is the one exception where things a handled without the pixoo-library.
Check:
https://github.com/4ch1m/pixoo-rest/blob/c5a97ccee5511af42e78af329068c3d99f347ead/app.py#L240
However, there's not that much magic involved.
Simple usage of pillow.
I can't reproduce the issues you describe.

Can you provide a sample GIF?

I found that section last night and was playing around with it. It looks like we need to use thumbnail instead of resize. But when I try that the Divoom crashes. And I can't figure out how to convert the thumbnail to RGB.
Here's a sample gif that is normal, but when uploaded the first frame is glitchy

Awesome! So far so good. I had about 20 gifs I was testing with and all of them look great now.
Another quick question - are you aware of a method to create a playlist of gifs without using their app?
I see that you can assign a PicId, which I guess are slots to store animations. I don't see a way to cycle through them though?
https://github.com/4ch1m/pixoo-rest/blob/master/app.py#L229

Another quick question - are you aware of a method to create a playlist of gifs without using their app?

Nope. Sorry.

I see that you can assign a PicId, which I guess are slots to store animations. I don't see a way to cycle through them though?

There's an "official" documentation available here: http://doc.divoom-gz.com/web/#/12?page_id=93
The PicID is described there. However, I haven't looked into this in detail.


Bug: “Buy me coffee” button does not work when out of gas

Describe the bug and the steps to reproduce it
The "Send 1 Coffee for 0.001ETH" don't return anything while out-of-gas.
What's the expected behavior?
Could be great to add an alert or visual notification when trying to use it.
Other buttons open Metamask pop-up, but this one don't.
What version of the libraries are you using?
No response

Great catch! Thank you @leo5imon
That's for sure a missing experience that we need to cover.
@leo5imon if you catch more of those, please let them coming, those notes are pure gold ✨

@leo5imon thanks for reporting! This merged PR should fix this issue: https://github.com/coinbase/build-onchain-apps/pull/311


Create new gist from file

I might be missing on some of the semantics of gists, but it would be rather cool to allow the quick creation of a new gist from a file... right in the shell. Something like git gist file.rb would come to mind.

This is outside of the scope of this project. Take a look at https://github.com/defunkt/gist


only run tests on postgres 12

https://trello.com/c/XjcK0K3g/737-upgrade-environments-to-postgres-12
Update CI to reflect we are now running Postgres 12 on all environments.

Holding off merging this for now as we are still running Postgres 10 as it turns out!


too many values or values with long names causes the bar chart to be displayed poorly

As shown in the attached picture -- potential solution would be to allow the chart to display as horizontal bars

Thanks for the report!
PRs welcome, but at this point I'd probably recommend switching to D3. In fact I should probably deprecate this whole library... (D3 didn't exist when I wrote it.)


Upload Images

Hi, first, Thank you for this framework, its so helpful
i need to upload selected images, have one method to do this ?

One method is to upload to backend server or to a 3rd party file hosting system like Cloudinary

you can use your backend to generate PRE SIGNED URL ,
send this back to front end , and use it to POST images to this PRE SIGNED URL
in this way you go from
Upload from Client > server > server upload to Cloudinary > server return urls to client
to
Client ask Url from server > server return urls (take some 100-200ms ? ) > client upload directly to cloudinary
Good luck , this is not an issue , your welcome to join my discord channel i will give support and ideas there
https://discord.gg/6XZ7Aqd2yK

Thank you guys, this resolve my problem
i send file path in my request using loopback 3 storage component and my photo upload with success, thank you


"Invalid cross-device link" error from process_all.py

Excuse me, sir, I need help! I allow process in this place_ There is a problem with all.py. Cut the pictures that are not cropped out in the corresponding folder (S11)
Originally posted by @HOH980820 in https://github.com/anibali/h36m-fetch/issues/52#issuecomment-929047831

I believe that this can happen if /tmp is located on a different file system to the destination directory (processed/). Try replacing this code:
https://github.com/anibali/h36m-fetch/blob/99a723f5fbd2a5f00766385b84ad157871005d5f/process_all.py#L117-L120
with this code:
                import shutil
                move(
                    path.join(tmp_dir, filename),
                    path.join(frames_dir, filename),
                    copy_function=shutil.copy
                )

Let me know if this works for you.

Same issue here. Your suggestion works for me. Thank you a lot.


v1/api: Add on prem boolean to blueprints metadata

This way we might be able to track how much are people using the on prem blueprints using.
HMS-4980

Can you also add it to the floorist query pls? :)

Woah! You are quick! Yeah, that is a good point. I did that:) I think we agreed on this, if you feel like there are better ways, feel free to comment.

Amazing, thanks!


tf import CLI command could use some rework

The Problem

cd operations
make TF_ENV=dev tf-01-network (environment and module do not matter)
az login
tf import <resource> <id>

The last command fails.
Background
What it should be doing is using the tf script and essentially issuing this command:
terraform import \
  --var-file <var-file> \
  -var="terraform_caller_ip_address=${PUBLIC_IP_CIDR?}" \
  <resource> \
  <id>

However, somewhere the format is getting messed up and not issuing the script call as above. The logic for this command is here: https://github.com/CDCgov/prime-reportstream/blob/master/operations/app/src/environments/tf#L247
Original Context
I think I get it, is it because we do: ./tf -e ${ENV_NAME} -c "import a b"? And thus, it's "import a b" (note the quotes around the whole value) that we need to key off of, and not "import".
That seams odd... could we not instead use ${*} for the ${TFCMD_AFTER} and take advantage of the -- breaker on line 90 so that you do: ./tf -e "${ENV_NAME?}" -c import -- resource_type resource_name?
So this would then turn into a
    import)
        # Some commands require arguments in a different location
        EXPECTED_RESULTS="${EXPECTED_RESULTS?}0"
        TFCMD_BEFORE=$(echo "${TFCMD?}" | cut -d' ' -f 1)
        terraform ${TFCMD_BEFORE?} \
            --var-file "${TFVARS?}" \
            ${*}
        ACTUAL_RESULTS="${ACTUAL_RESULTS?}${?}"
        ;;

Originally posted by @td-usds in https://github.com/CDCgov/prime-reportstream/pull/1868#r690594220

@cwinters-usds
It turns out that a few import commands for azure have known to fail unless the resource path is quoted. This isn't always true, but better to play it safe.
Since ./tf.sh -c "" expects input within double quotes, whoever is entering the import command should use single quotes instead: ./tf -e ${ENV_NAME} -c "import a 'b'" (note 'b')
I cannot confirm that this is the ENTIRE issue until I have az access.
I'll discuss on a standup, but we can do a screen-share where we run tf import and try with/without quotes to see if resolved.
Shown in documentation:
terraform import
Reported issue:
issue


Support for analyzing opened documents only

Hi,
Is it possible to use analyzers only for opened documents instead of the whole solution?
"enableAnalyzersSupport": true
This line enables the analyzers for the whole solution, which in a larger project has very slow load time and bumps up my CPU usage by a lot.
Just for comparison, without the analyzers, my solution ~40 projects loads in around 40s. With analyzers enabled, it takes up 10+ minutes with constant high CPU usage.

There is "omnisharp.analyzeOpenDocumentsOnly": true option in settings


signatures, cs: sign messages and links

This is needed so we can use indigocore signatures package in indigotrace.

This change is

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

cs/signature.go, line 52 at r1 (raw file):

	}
	if payload == nil {
		return nil, errors.New("JMESPATH query does not match any link data")

nit: I think it's good to define our custom errors as vars at the package level.
This way clients (and tests) can test for that specific error which is handy.

cs/signature_test.go, line 63 at r1 (raw file):

		sig, err := cs.NewSignature(sig.Ed25519, payloadPath, priv[:], link)
		assert.NoError(t, err)
		assert.NoError(t, sig.Verify(link), "signature verificdation failed")

nit: typo

cs/signatures/schemes.go, line 129 at r1 (raw file):

	case Ed25519:
		if len(privateKey) != ed25519.PrivateKeySize {
			return "", "", errors.Errorf("%s private key lenght must be %d, got %d", Ed25519, ed25519.PrivateKeySize, len(privateKey))

nit: length

cs/signatures/schemes.go, line 133 at r1 (raw file):

		pk := ed25519.PrivateKey(privateKey)

		publicKey = base64.StdEncoding.EncodeToString(pk.Public().(ed25519.PublicKey))

Shouldn't we directly use EncodeToString(pk.Public().Marshal()) or something equivalent to "Marshal"/"Bytes"? I don't think we should dive to the concrete ed25519.PublicKey type but rather use a Marshaling offered at the PublicKey interface level (if there is one).

Comments from Reviewable

I am currently redoing the Trace pki part where I have tried to use standards for key encoding.
IMO we should not use custom signatureType strings to define what type of signature is used. Instead we should use the existing standards (https://tools.ietf.org/html/rfc5958). The private keys should be encoded using DER ASN.1, where key algorithm (and curves if necessary) are directly encoded with the actual key.

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

Comments from Reviewable

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.

cs/signature_test.go, line 63 at r1 (raw file):

		sig, err := cs.NewSignature(sig.Ed25519, payloadPath, priv[:], link)
		assert.NoError(t, err)
		assert.NoError(t, sig.Verify(link), "signature verificdation failed")

typo: verificdation

cs/signatures/schemes.go, line 119 at r1 (raw file):

// _______________________________________
// Private keys must be encoded as follows:
// - Ed25519: no encoding necessary, private key length should be 64 bytes.

typo: lenght

cs/signatures/schemes.go, line 129 at r1 (raw file):

	case Ed25519:
		if len(privateKey) != ed25519.PrivateKeySize {
			return "", "", errors.Errorf("%s private key lenght must be %d, got %d", Ed25519, ed25519.PrivateKeySize, len(privateKey))

typo: lenght

Comments from Reviewable

After coordinating with @piedup, we decided to extract the key / signatures / certificate code to a dedicated repository.
I'll merge this one and wait for the new repo before updating indigotrace.

Review status: 0 of 4 files reviewed at latest revision, 8 unresolved discussions.

cs/signature.go, line 52 at r1 (raw file):
Previously, t-bast (Bastien Teinturier) wrote…
nit: I think it's good to define our custom errors as vars at the package level.
This way clients (and tests) can test for that specific error which is handy.

Done.

cs/signature_test.go, line 63 at r1 (raw file):
Previously, t-bast (Bastien Teinturier) wrote…
nit: typo

Done.

cs/signature_test.go, line 63 at r1 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…
typo: verificdation

Done.

cs/signatures/schemes.go, line 119 at r1 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…
typo: lenght

I know I'm quite bad at spelling length correctly but I believe I succeeded there !

cs/signatures/schemes.go, line 129 at r1 (raw file):
Previously, t-bast (Bastien Teinturier) wrote…
nit: length

Done.

cs/signatures/schemes.go, line 129 at r1 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…
typo: lenght

Done.

cs/signatures/schemes.go, line 133 at r1 (raw file):
Previously, t-bast (Bastien Teinturier) wrote…
Shouldn't we directly use EncodeToString(pk.Public().Marshal()) or something equivalent to "Marshal"/"Bytes"? I don't think we should dive to the concrete ed25519.PublicKey type but rather use a Marshaling offered at the PublicKey interface level (if there is one).

I would agree if such a function existed ! https://golang.org/pkg/crypto/#PublicKey
However, since the PublicKey interface covers multiple crypto schemes, there is no general marshaling, although several kinds of serialization may be used (ASN1, PEM...)

Comments from Reviewable

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

cs/signatures/schemes.go, line 119 at r1 (raw file):
Previously, simonvadee (Simon Vadée) wrote…
I know I'm quite bad at spelling length correctly but I believe I succeeded there !

:D

cs/signatures/schemes.go, line 133 at r1 (raw file):
Previously, simonvadee (Simon Vadée) wrote…
I would agree if such a function existed ! https://golang.org/pkg/crypto/#PublicKey
However, since the PublicKey interface covers multiple crypto schemes, there is no general marshaling, although several kinds of serialization may be used (ASN1, PEM...)

If we don't have a choice then of course it's fine :)
And anyway if we adopt what Pierre suggests this issue will disappear

Comments from Reviewable

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

cs/signatures/schemes.go, line 119 at r1 (raw file):
Previously, t-bast (Bastien Teinturier) wrote…
:D

It might be my eyes which has crossed letters and words ;)

Comments from Reviewable


Typescript definitions

Thanks for the project. I found it helpful. Would you be interested in taking a patch that will help Typescript users use easy-button?
I've also written up how it is done here: https://stackoverflow.com/questions/44472856/how-do-i-add-typescript-defitions-for-leaflet-plugins/44472857#44472857

yeah, this is great.  Thanks!


adding golang solution for 238. product of array except self

File(s) Modified: 238-Product-Of-Array-Except-Self.go
Language(s) Used:  Golang
Submission URL: https://leetcode.com/submissions/detail/780416625/

Thanks, @therollingambit!

Welcome :)


[Bugfix][Kernel] Promote another index to int64_t

In segmented_max_reduction, i is an index over the number of elements, so can exceed the max size of an int32_t. It's not biting us now, but this will prevent issues from arising here in the future.

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

/ready

@WoosukKwon I don't think we should always do it since there may be performance implications, but this is exactly why I was talking about cranking up the warnings and also potentially turning on -Werror for many warnings when compiling our kernels
For this case specifically, I think we should set the compiler flags so that implicit conversions like this won't compile.
See also https://github.com/vllm-project/vllm/pull/6649

Wow 😮 Nice find

Thanks -- I was staring at the kernels looking for bugs in the vicinity of AllGather -> RMSNorm -> Quantize -> Up_Gate proj and saw this 🙃


FEATURE REQUEST: Add scroll bar to text input/chat field

If you're having trouble with the input field's size I recommend resizing your sidebar to make it larger, or open Claude Dev in your editor using Cmd + Shift + P > Claude Dev: Open in New Tab.


Fix

Correct database intergration(wont interrupt game if one is not present)
Includes code to log incorrect passwords
Theres probably some other stuff i added in here but i cant remember(i mean it took 4 months for the first commit to be accepted)

[ ]   General Comment
 Please fix merge conflicts
Also, you appear to have added your AWS credentials to config.json, probably should remove those
 And please for god's sake, squash it.
 Fixed conflicts//Added comments to config// Removed my auth vals
 :shipit:
 fixed
[ ]   File: config.json:L32-44
 Comments are not valid JSON, please remove them
[ ]   File: src/server/server.js:L6-25
 You should be using the config option here, not an environment variable

This pull request is now managed with CodeReviewHub. Refresh.

Please fix merge conflicts
Also, you appear to have added your AWS credentials to config.json, probably should remove those

And please for god's sake, squash it.

Fixed conflicts//Added comments to config// Removed my auth vals

:shipit:

fixed

Resolved conflicts now ready to be deployed!!

Needs to be merged to fix database issues introduced in last pull request

And let's squash this pull request into a single commit :D

When I find some free time I will work on adding a level up system perhaps based on a timeAlive/avgMass?


Error while Downloading and configuring the .NET Core Debugger

VSCode Version: 0.10.11
OS Version: ubuntu 14.04-x64

After installing csharp extension, I'm getting message 'installation is successful'. But after that, there is this error,
error: File '/home/dhananjay/.vscode/extensions/ms-vscode.csharp-0.3.6/NuGet.config' does not exist.
dotnet exited with error code 1
Error while installing .NET Core Debugger.

But C# is present in installed extensions list.

This issue was moved to OmniSharp/omnisharp-vscode#96


Add missing information to SSPR reveview section

"All Users" is missing from one of the navigation trees and a second navigation tree is completely missing to help people find the scope of SSPR.

@Justinha

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@TheFiZi thanks for adding this correction and sorry for delay. I added it on my side to work around the merge conflict. #please-close


Error: Member not found: 'SystemChrome.setEnabledSystemUIOverlays'.

.pub-cache/hosted/pub.dev/chewie-1.0.0/lib/src/chewie_player.dart:144:18: Error: Member not found: 'SystemChrome.setEnabledSystemUIOverlays'.
SystemChrome.setEnabledSystemUIOverlays(
^^^^^^^^^^^^^^^^^^^^^^^^^^
             .pub-cache/hosted/pub.dev/chewie-1.0.0/lib/src/chewie_player.dart:161:20: Error: Member not found: 'SystemChrome.setEnabledSystemUIOverlays'.


Unit tests failing in a clean environment.

Running inside the official golang:1.6 Docker image, using stretchr/testify revision 1f4a1643a57e (on master), the unit tests are failing:
docker run -it --rm golang:1.6
$ /go# go get github.com/manucorporat/sse
$ /go# go get github.com/stretchr/testify/assert
$ /go# cd src/github.com/manucorporat/sse
$ /go/src/github.com/manucorporat/sse# go test .
--- FAIL: TestEncodeOnlyData (0.00s)
        Error Trace:    sse_test.go:31
    Error:      Not equal: []sse.Event{sse.Event{Event:"message", Id:"", Retry:0x0, Data:"junk\n\njk\nid:fake"}} (expected)
                    != []sse.Event{sse.Event{Event:"", Id:"", Retry:0x0, Data:"junk\n\njk\nid:fake"}} (actual)

            Diff:
            --- Expected
            +++ Actual
            @@ -2,3 +2,3 @@
              (sse.Event) {
            -  Event: (string) (len=7) "message",
            +  Event: (string) "",
               Id: (string) "",

--- FAIL: TestEncodeWithEvent (0.00s)
        Error Trace:    sse_test.go:52
    Error:      Not equal: []sse.Event{sse.Event{Event:"t\\n:<>\\r\test", Id:"", Retry:0x0, Data:"junk\n\njk\nid:fake"}} (expected)
                    != []sse.Event{sse.Event{Event:"t\n:<>\r\test", Id:"", Retry:0x0, Data:"junk\n\njk\nid:fake"}} (actual)

            Diff:
            --- Expected
            +++ Actual
            @@ -2,3 +2,3 @@
              (sse.Event) {
            -  Event: (string) (len=12) "t\\n:<>\\r\test",
            +  Event: (string) (len=10) "t\n:<>\r\test",
               Id: (string) "",

FAIL
FAIL    github.com/manucorporat/sse 0.003s

I can confirm this issue still exists. Is this an issue with the tests or an actual problem?

this issue still exists, my 2¢:
TestEncodeOnlyData
This is an issue with test. The event type will be set to message if it's empty, which complies with the spec.
TestEncodeWithEvent
This is an actual decoder problem. CRLF/CR/LF are all line ending signal. If t\n:<>\r\test appeared after event:, it should be parsed into those tokens:

event:t: event type was t
\n: event type line ends
:<>: ignored
\r: ignored line ends
\test: "using the whole line as the field name, and the empty string as the field value."
(ref)


Redirect http to https

Fix #106

Deployed to Heroku: http://respass-heroku-test.herokuapp.com/ now redirects to
https://respass-heroku-test.herokuapp.com/

Thanks @seanchas116!
I think this behavior should be documented, because there may be probability of demand to use this application without SSL. I will add some notes.