Get Data in Efficient Frontier

Hi there, slowly learning how to utilize PyPortfolioOpt. Thanks so much.
What are you trying to do?
I need the data underlying the efficient frontier as there additional analytics and plotting I want to do.
What have you tried?
tried looking in source file info and trying to pull out various objects.
What data are you using?
What asset class, how many assets, how many data points. Preferably provide a sample of the dataset
MAS_Returns_Qrtly_2021-06_quad0.csv
as a csv attachment.
Thanks,
Phil

@pebennett what data are you talking about specifically? Below you can find an example showing how to get weights and some performance metrics (expected return, volatility and Sharpe ratio) from the optimized portfolio.
ef = EfficientFrontier(mu, S)
raw_weights = ef.max_sharpe()
cleaned_weights = ef.clean_weights()
ef.portfolio_performance(verbose=True)

Thanks for getting back to me, and sorry for not being specific enough. What I'm trying to get is the data (i.e. vol, return & weights) for all points on an efficient frontier.
BTW, can you please explain the difference between raw weights and cleaned weights.
Thanks,
Phil


K8s - UI - pods from across namespace gets listed in services pages.

Server version - v1.1.4-rc1
K8s template from https://github.com/rancher/qa-catalog.
Steps to reproduce the problem:
Create namespace test1.
Create services/pods/ingress in this namespace.
Create namespace test2.
Create the same set of services/pods/ingress as test1 in test2.
Services list view for test1 list the pods from services of the same name that belong to namespace test2 .
Same behavior is also seen with service in test2.

> kubectl get pods --namespace test1
NAME            READY     STATUS    RESTARTS   AGE
k8test7-4y4jz   1/1       Running   0          50m
k8test7-51yk9   1/1       Running   0          50m
> kubectl get pods --namespace test2
NAME            READY     STATUS    RESTARTS   AGE
k8test7-2l33b   1/1       Running   0          50m
k8test7-jny8a   1/1       Running   0          50m
> kubectl get pods --namespace test3
> kubectl get pods
NAME            READY     STATUS    RESTARTS   AGE
k8test5-2h6em   1/1       Running   0          2h
k8test5-jcpsl   1/1       Running   0          2h
k8test6-ckulj   1/1       Running   0          1h
k8test6-wsywc   1/1       Running   0          1h
k8test7-emvlq   1/1       Running   0          1h
k8test7-le22j   1/1       Running   0          1h

This issue is not reproducible using  rancher server version - v1.1.4-rc2


how to run a demo for my image

thanks for your sharing. i want to run a demo for my images and visualize the result. i have already downloaded the models from your website. How should i do? Thanks very much.

@rowanz thanks for your efforts for _visualize.py, and online visualization demo.
But, I am looking for generating scene graph for my own custom image (and not from VG dataset). Looking forward for your response.

Hey @rowanz, can you please provide SG visualization (sgdet mode) code for custom datasets too? The thing is https://github.com/rowanz/neural-motifs/blob/master/models/_visualize.py generates SG for VG images only.
So, I am looking forward for a custom data loader that can load my test images and run sgdet on it to generate scene graphs for my test images.

Hey @rowanz, can you please provide SG visualization (sgdet mode) code for custom datasets too? The thing is https://github.com/rowanz/neural-motifs/blob/master/models/_visualize.py generates SG for VG images only.
So, I am looking forward for a custom data loader that can load my test images and run sgdet on it to generate scene graphs for my test images.

Hi，I also want to test my images,did you solve the problem?

Hey @rowanz, can you please provide SG visualization (sgdet mode) code for custom datasets too? The thing is https://github.com/rowanz/neural-motifs/blob/master/models/_visualize.py generates SG for VG images only.
So, I am looking forward for a custom data loader that can load my test images and run sgdet on it to generate scene graphs for my test images.

Hi，I also want to test my images,did you solve the problem?

Hi. Is anyone able to test it on your own images? Do we have a visualize.py for SGDet?

So, Is anyone  solve the problem?


[Cartridge,Header, Scroll] Console Log pollution

Can you remove this for the next iteration ? :)

Hello @Pandakls.
Yes, it has to be removed.
Github blames you :)

Can you please submit a pull request yourself to remove it ?
Thanks a lot.

fixed in this commit : https://github.com/KleeGroup/focus-components/commit/b7a3491dd4f041180d7a07308f89545ac966b78a#diff-47ea64765ca80da6ab8a881e5b6b395d


How do I do the task fallback？

Hey @xiyan1120 , can you provide more details with an example please?


Cubes charging in the GUI of Induction Matrix disappear after exit

Mekanism <IP_ADDRESS>1
Minecraft 1.10.2
Energy cube will disappear after exit game if I put it charging in the gui of Induction Matrix.
I tested several times and found the problem may be that a Quantum Entangloporter is next to the Matrix.
but it happend even if the QE without any setting.

Seems to be fixed in 1.11.


Bug? tabindex -1 on form elements?

Great plugin, thanks!
http://jsfiddle.net/JNsu6/439/
I would expect to not have my form elements modified with a tabindex.
Seeing this happening in latest Chrome/macOS. Featherlight 1.7.6.

I'm really sorry about this, it's a known bug I'm eager to fix but haven't quite finished. Closing in favor of #285.


Add Execute() extension method to simplify usage with EnumInstructions

The callback is not invoked and all existing methods use int result and typeof(TEnum). Do we need a generic extension or is it sufficient to restore that signature?

The motivation was sparked when I wrote the migration guide, specifically these lines:
// MORYX 6
VisualInstructor.Execute("Some Title", someInstructions, new EnumInstructionResult(typeof(AskRotationPermissionResult), SomeAction));

// MORYX 8
VisualInstructor.Execute("Some Title", someInstructions, EnumInstructionResult.PossibleResults(typeof(AskRotationPermissionResult)),
  param => SomeAction(EnumInstructionResult.ResultToEnumValue(typeof(ArticleMountingStrategy), param.Result)));

The generic extension should drastically simplify this solid two-liner of a method call 😅

Anything left here and can we merge into dev?

I like it and would merge it 😊

Well, as it turns out: This never compiled...

But why could you merge it, github should have prevented that since the build step failed...

Well, since there was no updated approval, I had to merge with admin priviliges anyway - which also overwrites the CI build check.


open data

Hi there,
great work! I wonder if the pertaining dataset is available? Would love to have a visual inspection of those sequences?

Hi,
Thanks!
Yes, the data and checkpoint are being uploaded to Zenodo. I will update the README.md as soon as they become available!

Also, another question regarding the training sets linked in the README (which are still not uploaded at the moment I guess): are they the filtered versions of the original databases? What I mean is: did you already filered them using this https://github.com/chandar-lab/AMPLIFY/blob/rc-0.1/data-pipeline/README.md or not?

Thanks!

@damiano-sg and @pengzhangzhi, I've added the links to the data and checkpoints in the README.md! I'll let you close the issue if that is working on your side.


Build parser from grammar at runtime

Hi!
Can I build a parser from grammar at runtime without generating any dll, bin etc?

Hi, yes this kind of scenario is supported, but only on the .Net platform. If you are using the Java or Rust runtime you will be out of luck.
There is a example of exactly this in the documentation at: https://cenotelie.fr/projects/hime/recipes/sdk

Unfortunately, it's not what I need.  if I understood correctly CompilationTask generates dll. I want to get the objects only in memory and nothing should be saved on a disc. I want to create a natural language parser like https://github.com/natasha/yargy only on c#. I thought I could use hime  RNGLR parser for it and simply by rewriting lexer. Now I know that it is more of a challenge than I thought. In any case, thank you for answering.


Not implemented: window.alert

Inside the code I have this line window.alert('Please try again'). When testing the code I get a warning Not implemented: window.alert How do I resolve this and test the code? I am runin the new v10 version of jsdom and nevest version of jsdom-global

@Igor-Vuk See https://github.com/tmpvar/jsdom#intervening-before-parsing
'use strict';

const { JSDOM } = require('jsdom');

const options = {
  resources: 'usable',
  runScripts: 'dangerously',
  beforeParse(window) {
    window.alert = window.console.log.bind(window.console);
  }
};

const dom = new JSDOM(`
  <!doctype html>
  <html>
    <head>
      <meta charset="UTF-8">
      <title></title>
    </head>
    <body>
      <script>
        window.alert('Please try again');
      </script>
    </body>
  </html>
`, options);

dom.window.close();

Please try again

@bochen2014 Try setting the alert function to undefined first and then assign your function to it. This is what solved the issue for me

@bochen2014  thanks, it work

@bochen2014 This works, but when I try to debug my test I get this error:
TypeError: Cannot assign to read only property 'testEnvironmentOptions' of object '#<Object>'

@bochen2014 second solution worked for me!


No more copyright header file?

Hi,
Followed the whole tutorial until https://mzmine.github.io/mzmine_documentation/contribute_intellij.html#copyright-header and could not find the template.
Did I overlook it or has it been deleted in the meantime?

They somehow got lost in the change of the license.
I added them again


Promise as argument of Collection add, remove, reset, set methods

What would you say if add ability to pass to Collection methods not only plain objects, arrays and models, but also promise. Just add code like this to each method
add: function(models, options) {
  //...
  if (typeof models.then === 'function') {
    var self = this;
    return models.then(function (models) {
      return self.set(models, options);
    });
  }
  //..
}

and so we can do
users.add($.get('/users'));

very useful if you decided to change some of your methods from sync to async like
User = Model.extend({
  getProducts: function () {
    // was
    return products.where({user_id: this.get('id')});
    // become
    return $.get('/products', {user_id: this.get('id')});
  }
});

// but code same for sync and async
bag.add(user.getProducts());

How about user.getProducts().then(products => bag.add(products))?
I think if we're going to add Promises to Backbone we should do so holistically (like #3729, #3651), not in fits and starts.


Adding ssh-keys for libby molina

Conflicts:
templates/ssh/authorized_keys

@libbymo - I noticed this PR has been open for a while. If it's still valid, please rebase.

Rebased! It only took me 5 months! Thank you.


Centralized motion detection

Implemented motion handler in pipeline and use Position_KEY_MOTION for event generation and trips detection.

Sorry, added unrelated to PR one small fix to Stops detector.

Merged, thanks.


board support

ability to run multiple boards/instances similar to 2ch.  todo

Possibly do this via tag system

could do categories that are defined in backend

Yeah I definitely wanna implement #31

See also #121


[Nlakh-multi] [Download] Failed to download dataset.

It says the file is in the user's trash, can you fix this please?

Sorry for the late reply. It should work now.


Missing Dafny.dll after updating to 3.9.1

VSCode automatically updated my Dafny version to 3.9.1, and since then I can't compile my code (verifying is still working though).
Dafny installation output:
Starting Dafny installation
deleting previous Dafny installation at /Users/roydavidson/.vscode/extensions/dafny-lang.ide-vscode-2.8.6/out/resources/3.9.1
Found a non-supported architecture OSX:arm64. Going to install from source.
Installing Dafny from source in /Users/roydavidson/.vscode/extensions/dafny-lang.ide-vscode-2.8.6/out/resources/3.9.1/custom/arm64.

Executing: git clone -b v3.9.1 --depth 1 --recurse-submodules https://github.com/dafny-lang/dafny.git
Executing: PATH=/opt/homebrew/bin:$PATH /opt/homebrew/bin/dotnet build Source/DafnyLanguageServer/DafnyLanguageServer.csproj
Executing: brew update
Could not run `brew update` but this step is optional (Error: Command failed: brew update
rm: /opt/homebrew/.git/TMP_FETCH_FAILURES: is a directory
/opt/homebrew/Library/Homebrew/cmd/update.sh: line 667: /opt/homebrew/.git/TMP_FETCH_FAILURES: Is a directory
rm: /opt/homebrew/.git/TMP_FETCH_FAILURES: is a directory
Error: Fetching /opt/homebrew failed!
Updated 2 taps (homebrew/core and homebrew/cask).
)
downloading Z3 from https://github.com/Z3Prover/z3/releases/download/Z3-4.8.5/z3-4.8.5-x64-osx-10.14.2.zip
0%...10%...20%...30%...40%...50%...60%...70%...80%...90%...100%
extracting Z3 to /Users/roydavidson/.vscode/extensions/dafny-lang.ide-vscode-2.8.6/out/resources/3.9.1
0%...10%...20%...30%...40%...50%...60%...70%...80%...90%...100%
Executing: mv /Users/roydavidson/.vscode/extensions/dafny-lang.ide-vscode-2.8.6/out/resources/3.9.1/z3-4.8.5-x64-osx-10.14.2 z3
Executing: mkdir -p ./dafny/
Executing: cp -R /Users/roydavidson/.vscode/extensions/dafny-lang.ide-vscode-2.8.6/out/resources/3.9.1/custom/arm64/dafny/Binaries/* ./dafny/
Starting Dafny from /Users/roydavidson/.vscode/extensions/dafny-lang.ide-vscode-2.8.6/out/resources/3.9.1/dafny/DafnyLanguageServer.dll
Language server arguments: /Users/roydavidson/.vscode/extensions/dafny-lang.ide-vscode-2.8.6/out/resources/3.9.1/dafny/DafnyLanguageServer.dll --documents:verify=onchange --verifier:timelimit=20 --verifier:verifySnapshots=0 --verifier:vcscores=0 --ghost:markStatements=true --verifier:gutterStatus=true
the installed Dafny version is the latest known: <IP_ADDRESS>027 = 3.9.1
Dafny is ready

Dafne compile output:
roydavidson@Roys-MacBook-Air Playground Dafny % "/opt/homebrew/bin/dotnet" "/Users/roydavidson/.vscode/extensions/dafny-lang.ide-vscode-2.8.6/out/resou
rces/3.9.1/dafny/Dafny.dll" "/Users/roydavidson/VSCodeProjects/Playground Dafny/playground.dfy" /verifyAllModules /spillTargetCode:1 /compile:3 /out:bi
n/playground
Could not execute because the specified command or file was not found.
Possible reasons for this include:
  * You misspelled a built-in dotnet command.
  * You intended to execute a .NET program, but dotnet-/Users/roydavidson/.vscode/extensions/dafny-lang.ide-vscode-2.8.6/out/resources/3.9.1/dafny/Dafny.dll does not exist.
  * You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH.

See also #294
Same issue I think.

Fixed in the last release of Dafny and VSCode plugin


setBufferSize() does not work.

I'm trying to send packets that are bigger than the default 256 bytes. If I change the #define MQTT_MAX_PACKET_SIZE 256 to #define MQTT_MAX_PACKET_SIZE 1024 everything works, but if I call setBufferSize(1024) after the connect()method the function appears to have no effect, even though getBufferSize() returns 1024, the publish()method returns false due to the packet being too long.

There are bits of an answer in #685 .

Thanks for you quick reply, but version 2.8 according to CHANGES.TXT "Add setBufferSize() to override MQTT_MAX_PACKET_SIZE" which in my understanding should be used to do what I want to do.

Thanks @sebashb for the heads up, I wasn't aware of this change. Sorry to have mislead you.
Does it work if you call the function before connect() ?
Thanks @knolleary too.

No it does not work also.

For me PSclient.setBufferSize(1024*5); works fine. When issued just after PSclient.connect(). I can verify it by looking at PSclient.getBufferSize() just before whenever I am ready to transmit a message.
And this works for messages of bigger than than the default 256 bytes.
However, when I try to submit a string that is about 3kB it simply doesn't transmit it at all.
Is there a hard limit? If yes, what it it?
I am using an ESP32.
thank you

Some more details:
I am trying to send a list of files as a JSON string over MQTT.  It has 33 entries. If I add one more similar entry in my code, PSclient.publish fails.
Just before I the PSclient.publish line I added this:
SerialMon.printf("Buffer size:\t%u\r\nJSON size:\t%u\r\nFree heap size:\t%u\r\n", PSclient.getBufferSize(), myJsonString.length(), ESP.getFreeHeap());

The output of it in case the JSON string has 33 item:
Buffer size:    5120
JSON size:      1411
Free heap size: 287100

The output of it in case the JSON string has 34 item:
Buffer size:    5120
JSON size:      1451
Free heap size: 292096

I hope this helps troubleshooting it....

I have tried both before and after PSclient.connect() and none of them worked. The published messaged got truncated.

I'm not currently in a position to debug any PubSubClient issues and unlikely to be for a couple weeks at least.

@sebashb Interesting... For me it's either there or not at all. Never truncated...

Well I have tried multiple things, I'm sure that I have seen both behaviours ( not being published and being truncated), but I can't remember which code produce each one of them.

I add my experience to this issue. I'm using a ESP32-POE board to connect to AWS via MQTT. Some messages I'm going to receive are quite big (over 9 kbytes). So I set the buffer large enough:
#define MQTT_PACKET_SIZE  16384

WiFiClientSecure networkClient;
PubSubClient mqtt(mqttServer, 8883, MQTT_Callback, networkClient);
...

mqtt.setBufferSize(MQTT_PACKET_SIZE);
Serial.println(mqtt.getBufferSize());

It outputs 16384.
When the message is published by the server, all other clients (that don't use this library) receive the payload correctly. Instead my ESP32 board doesn't receive anything (if the message is shorter it works, though).
I also tried to play with MQTT_MAX_TRANSFER_SIZE without any improvement.
Actually, the behavior is the following:

12:43:26.725 -> [MQTT] Connecting...connected
12:43:32.085 -> [MQTT] Subscribed to: $aws/things/mything/shadow/update/#
12:43:32.085 -> [MQTT] Subscribed to: $aws/things/mything/shadow/get/#
12:43:32.085 -> [MQTT] Publish $aws/things/mything/shadow/get:
12:43:32.085 -> [MQTT] Publish result: 1
12:44:17.084 -> [MQTT] Connecting...connected
12:44:31.276 -> [MQTT] Subscribed to: $aws/things/mything/shadow/update/#
12:44:31.276 -> [MQTT] Subscribed to: $aws/things/mything/shadow/get/#
12:44:31.276 -> [MQTT] Publish $aws/things/mything/shadow/get:
12:44:31.276 -> [MQTT] Publish result: 1
12:45:46.290 -> [MQTT] Connecting...failed, rc=-2 try again in 5 seconds
12:45:55.291 -> [MQTT] Connecting...failed, rc=-2 try again in 5 seconds
12:46:00.287 -> [MQTT] Connecting...failed, rc=-2 try again in 5 seconds
...

It's quite repeatable. After publishing the request message it should receive the answer (the "big" payload). Instead, after some dozens of seconds disconnects and reconnects. Doing this a couple of times leads to a failure to connect anymore, until I reset the board.


Rename py.test to tests.

It says here, to use a tests folder. And also, you can use a class for each and every test for better debugging, as mentioned here

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/23049046-rename-py-test-to-tests?utm_campaign=plugin&utm_content=tracker%2F7646105&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F7646105&utm_medium=issues&utm_source=github).

I'll go ahead and rename +py.tests+ to +tests+ for convention. However, I am aware you can use classes for tests, but I am explicitly avoiding that, at the moment.
Thank you very much for your contributions, your interest, and time. :) You'll be seeing the rename in the next release. I'll close this issue once such has happened.

I've made the update! https://github.com/lillian-lemmer/hypatia/commit/30834aad3eb1a0fc82117bd5ce1651562209e121


Using map to list plugins in node description

This PR ports some SwarmKit executor code into the Docker executor.

LGTM

Ping @tiborvass

LGTM


Layout-dependent methods need to call layout() first.

A deficiency found in TomasMikula/RichTextFX#238.
Basic idea from Tomas:

Methods of VirtualFlow whose result depends on the layout should themselves call layout() as the first thing. [Otherwise, the returned results aren't always valid. (I added this)] Such methods would include getCellIfVisible, visibleCells and hit. The fact that they first call layout() should be documented in their Javadoc.

Thanks for tracking this.

You're welcome.

Fixed by #20.


Add upToDate param for dtTileCache::update

This changes dtTileCache::update to add an optional parameter that
indicates whether the tile cache is up to date. This is useful to
determine whether calling the function again would do anything.

Looks good - maybe just add a comment explaining the upToDate parameter?

Good idea, added!

Nice; :+1: from me! I'll leave it to you to merge how you like, or wait for more input :)


jetty-9.2 image misconfigured for Stackdriver Debugger

Hello,
First of all, is jetty-9.2 image (JDK7/Jetty9.2, gcr.io/google_appengine/java-compat) still active? I believe this image is in the jetty-9.2 branch.
There is a reference to this image in this doc. I assume the image is active and mainly for migration from standard to flexible. This doc also points the image to this repo.
Given that this image is active, we need to fix an issue. I discovered that it is misconfigured for Stackdriver Debugger.
Internal bug number: 27900546

Opened another bug to track this Java7/Jetty9.2 issue: 28217727

JDK7/Jetty9.2, gcr.io/google_appengine/java-compat is active (we want to deprecate it but it is active)
and developed inside Google, not on GitHub, so if we want to fix the debugger, it has to be done inside Google repo, not here.

Thanks, Ludo. I'm closing this issue.


background app stops receiving positions

the problem occurs when the smartphone lost connection will the app is in background, for example you could open the app, put it on the Background and change connection from wifi o 4g wait for a moment an reopen the app from the background, the data won't be fetched until you restart the app. the problem occurs on both iphone and android TRACCAR MANAGER APP

Are you sure there's no existing ticket for this? I'm pretty sure we discussed similar problems before.


impl FromIterator<(usize, T)> for Slab<T>

for deserialize Slab with fixed key/value pair, resolve #41

Sorry for the delay. I am OK with accepting a FromIterator implementation. However, as far as I can tell, this implementation is buggy if the iterator is not ordered. Would you be able to add some tests for loading a slab when the indices are decrementing and in random order?

I would really like this functionality so I can more easily serialize Slab. I think it is okay to accept a slow version that sorts and then create an issue to track the completion of a more efficient implementation that can be completed later.

The changes provided by this PR are covered by #62.
Thanks for getting the ball rolling 👍


read a map or a list of lists with the table data after filtering anything

hi
Im trying to export an excel file as the current state of the pluto table after filtering some columns. Is it possible to get the current state of the data as a map, or something like that so I can work on it with other things?

The rows and refRows properties of stateManager are lists according to the current state of PlutoGrid.
The difference between the two is whether refRows is a reference or not.
If both values are filtered, the filtered result is returned.
Also, if pagination is performed, the list of the current page is returned, not the entire list.
stateManager.rows - Refers to rows on the current page, not all rows.
stateManager.refRows - Refers to rows on the current page, not all rows.
stateManager.refRows.originalList - Refers to all rows, whether filtering or paging.
stateManager.refRows.filteredList - If it is filtered regardless of whether it is paging or not, it refers to the filtered result rows.

Deployed in version 2.10.0.
Contributed by @henry2man.

@ldsouza93 I think this can be closed now. Current export feature do takes into consideration filtered data and visible columns.


UnexpectedDataValueLength { tag: Tag(0x0002, 0x0001) }

Hello everyone!
I have a little question about dicom_object crate. I'm trying to read a valid DICOM file exported from NewTom scanner using, for example, this snippet of code:
use std::error::Error;

use dicom_object::OpenFileOptions;

fn main() -> Result<(), Box<dyn Error>> {
    let obj = OpenFileOptions::new().open_file("test.dcm")?;
    let patient_name = obj.element_by_name("PatientName")?.to_str()?;
    println!("{patient_name}");
    Ok(())
}

But there is such error: Error: ParseMetaDataSet { source: UnexpectedDataValueLength { tag: Tag(0x0002, 0x0001), length: Length(0),... I tried some other different read options but no positive result. All DICOM tags in a file are presented except this one which is empty, that's the feature of DICOMs made on this type of scanner and never had problems reading DICOMs from other manufacturers.
Is there a way to read all DICOM tags anyway, ignoring this error (emptiness of such tags)? Or maybe turn of Snafu to make logs clear?
Glad to hear you solutions, thanks :)

Hello! From that description, it appears that the DICOM file has an empty File Meta Information Version (0002, 0001). This field must have a value containing two bytes (00h, 01h) for compliant DICOM files as per PS3.10 sectin 7,1.

Is there a way to read all DICOM tags anyway, ignoring this error (emptiness of such tags)?

Not right now, but I suppose we could change this to provide a default for the meta attribute with a tracing warning when it is empty or missing. It might affect future-proofing in the event that DICOM defines a second version of the file information version, but in the worst case it might just break in subsequent reading, so this may be a good compromise.

Or maybe turn of Snafu to make logs clear?

You can use Snafu reporting capabilities to improve the readability of that error. More info on this here.
#[snafu::report]


Fix typo in documtation

Hello! Since I committed in https://github.com/frankie567/fastapi-users/pull/344#issue-493698991 , It's been almost 1yrs! I've been always grateful for your art of work!

It's simple fix typo
jwt_authentication = JWTAuthentication(secret=SECRET, lifetime_seconds=3600))
there is doubled round bracket! so I edited!

Indeed! Time flies my friend 😄
Thank you for the typo fix, much appreciated 👍

@allcontributors add @lill74 for docs


fixes typo in 'Single Route' section

Second last line of code changes. There should be an array in value of key-value pair.

Thanks a lot for the PR! Much appreciated.


Minor coding enhancement

as suggested here: https://github.com/lycheeverse/lychee/pull/570#discussion_r835931903

The Docker workflow of course is expected to fail on forks, unless they have DockerHub login credentials stored as secrets as well. Probably all DockerHub related steps, or the whole workflow, should be skipped on pull requests from forks? E.g.
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login == github.event.pull_request.base.repo.owner.login

Thanks @MichaIng. 😃

The Docker workflow of course is expected to fail on forks, unless they have DockerHub login credentials stored as secrets as well. Probably all DockerHub related steps, or the whole workflow, should be skipped on pull requests from forks? E.g.
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login == github.event.pull_request.base.repo.owner.login

@MichaIng, sounds reasonable. Could you create a PR for that? Then we can test if it works right away. 😄


Add uniswap support

This PR...

adds uniswap v3 trade support

plenty of supporting boilerplate included

refactors some provider implementation details (we now have two primary examples folders: examples/with-ethers and examples/with-uniswap)

Re Socket Security report, I'm not too sure they're avoidable given @uniswap/v3-sdk is a necessity
Followups:

rethink ergonomics
create CLI tool easily clone examples
more integrations!

Shoutout to Uniswap -- SDK is excellent

@SocketSecurity ignore<EMAIL_ADDRESS>@SocketSecurity ignore<EMAIL_ADDRESS>@SocketSecurity ignore<EMAIL_ADDRESS>


Bug: In 13.9, HttpClient is disposed in FileResponse regardless of "Dispose HttpClient" setting

In 13.9 (nswag and nswag studio), the HttpClient is disposed of in FileResponse, even when "Dispose HttpClient" setting is not selected. This was supposedly fixed by commit https://github.com/RicoSuter/NSwag/pull/3016/commits/a2c09f2d8b629f0af1cd89904eeb4a51714d1e90 for bug https://github.com/RicoSuter/NSwag/issues/2981, but the issue is still occuring.

This should be passing in null instead of client, according to the PR fix.

@jeremyVignelles  Any thoughts on why this still doesn't work correctly in 13.9? Your fix looks correct. I assume DisposeHttpClient isn't set correctly somewhere else in the code.

Probably. This needs investigation, but I don't have any idea yet. You should clone the repo and try to debug.

I'm not sure whether liquid supports "!" or whether you need to use "== false"

Indeed i think "!var" is not allowed as i used "== false" everywhere...

Sorry then, not sure I tested that properly 🤔
Could you fix that @rbedell99 ?

It's already fixed...
I wonder why there are no exceptions - no idea what liquid actually does with this - at least it doesnt throw an exception.
Will release v13.9.1 now...

Seriously impressive, I appreciate the dedication and quick turn around!

Ref: https://github.com/RicoSuter/NSwag/pull/3164

Verified that this issue is fixed in v13.9.1.
Thanks!


connecting to older mssql from linux

i have azure data studio on my mac as well as my windows pc and i connect to my mssql 2008 server with no problem,
today i install azure data studio on my ubuntu 18 linux and i can connect to my 2019 db but the 2008 one sending this error
connection was successfully established with the server, but then an error occurred during the pre-login handshake. (provider: SSL Provider, error: 31 - Encryption(ssl/tls) handshake failed)
note that my 2008 doesn't support new version of ssl/tls,
updated to last version of openssl and firewall allow the 1433 port
is this work around to connect to older version of the sql server using azure data studio and linux ?

@hpourmahdi Azure Data Studio only officially supports SQL Server 2014+.  We have this issue to add a warning when connecting to a previous version of SQL Server https://github.com/microsoft/azuredatastudio/issues/16856 (we don't block these connections in the case that ADS may work for the subset of features the user is trying to use on a  particular version).
In this case, you can try to set the "Trust server certificate" to True which may help with the handshake error.  Otherwise, I'm not sure how to troubleshoot this connectivity scenario.

Closing based on previous comment.  Hopefully the suggested workaround works for you.  Thanks!

this suggestion issue not working, it is the issue with handshake and tls version and not working with this issue
currently working on dbeaver to connecting to lagacy databases


trashy: Generate and install man page

Description of changes
Adds a man page for the trash command from the trashy package.
Since this is fairly insignificant I did not add a release note.
Tested with nix shell --sandbox --file ./default.nix trashy on a local nixpkgs branch with the added changes.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

It's probably not a big deal, but there seems to be a clash with https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/os-specific/darwin/trash/default.nix#L23-L24. Not sure if something should be done about it


Remove json files for config-client-new

Fixes gh-354
/cc @ryanjbaxter @aclement

I don't see additional hints in this PR, maybe you have them locally?

So far, for config client new it didn't need them. Config client likely will.

I did a quick test, with the native config config-client-new is green, if I remove the META-INF/native-image directory and then run build-without-server-build.sh it fails. Could you please double check?

You have to do ./build.sh the first time. Only then, can you call build-without-server-build.sh

Yeah that's what I did and build-without-server-build.sh failed.

You'll notice I also made a change to the sample app itself

I've fixed the problem that necessitated changing the client app - either should work (separate commandlinerunner or simple bean). And can confirm deleting the config for the '-new' variant leaves you with a working app now.

Closing due to the move of the samples directory.


"System error" on a6500

I'm not sure whether this is caused by OpenMemories-Tweak or just coincidental, but I'm getting a "system error" when I try to record 4K video on my a6500. The camera completely locks, and I can't even turn it off and on again using the power switch. I have to take out the battery.
The camera will record one 4K video, but if I want to record another one, it results in this error. It's previously had no problem recording 4K - even after installing OMT. This is a problem that's only started in the past couple of days.

I don't think this is related to the tweaks app. As a note: Make sure to reset all tweaks back to their default settings before uninstalling the app.


Expose top-level size attributes on SVGs

As discussed in #16

Good job!
While there are some ESLint errors, please run npm run lint and fix them.


Permission Issue

I create a user with this permission:

And the user can't delete and modify the own server

(Version 2.1.1 on ubuntu 20.04.1LTS)

Same behaviour, here 👍🏻


Add Android Lint and artifacts

Closes #50

https://github.com/marketplace/actions/github-action-for-android-lint will give you feedback in the PRs


tests: thread_api: increase stack for test

Add more stack for this test, it was failing and hidden by sanitycheck
(which needs to be fixed somewhere else).
Fixes #9664
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

Codecov Report

Merging #9672 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9672   +/-   ##
=======================================
  Coverage   52.31%   52.31%
=======================================
  Files         212      212
  Lines       25937    25937
  Branches     5589     5589
=======================================
  Hits        13569    13569
  Misses      10122    10122
  Partials     2246     2246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c5d51...a5f8a14. Read the comment docs.


Links in gophermap not displayed

Either, my gophermap is malformed or there is an issue with links in gophermap in the desktop version of Lagrange.
Tested gophermap (gopher://sdf.org/1/users/kristof/linktest):
Link test

HTTP
hAn http link   URL:http://kristof.sdf.org

HTTPS
hAn https link  URL:https://sdf.org

Gopher
hA gopher link  URL:gopher://sdf.org

Gemini
hA gemini link  URL:gemini://sdf.org

Rendered result (Lagrange v1.2.3, macOS 11.2.3):

Lagrange (1.3.0) for iOS renders it correctly:

Interestingly, links on gopher://sdf.org are rendered but I don't have access to the corresponding gophermap:

If I understood it correctly, it is already addressed in the next release with https://github.com/skyjake/lagrange/commit/5d3567bd26ad1031e4ec08ccd2c36f5f1f646ca7. My bad! Feel free to close the issue, if this is the case :-)

Just to add my 2p-worth, the links don't currently display on the Win 10 desktop either.
(Hi Kristof, Steve here!)

Thanks for reporting! This has indeed been fixed for v1.3. The previous report is #208 (although the title is about git links, it's the same Gopher line type).


Update mockserver-netty to 5.7.2

Updates org.mock-server:mockserver-netty from 5.6.1 to 5.7.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.mock-server", artifactId = "mockserver-netty" } ]

labels: semver-minor

superseded by #293


fix: [VR-14258] Merge tag 'v1.9.2' into verta/main

Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)
Description

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes unit tests
[ ] Adds integration tests if needed.

See the contribution guide for more details.
Reviewer Notes

[ ] The code flow looks good.
[ ] Unit tests and or integration tests added.

Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.
Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

!rebuild

!rebuild


[Improvement] Optimize Api calls on the search page

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?
production
Version of BioDrop (for example "v1.2.3")
v2.97.6
Description
Currently on Search Page, when we select a tag, it directly makes an api call. Which is fine till only 1 tag is being selected. But incase when multiple tags are getting select, a new api call is made after adding the new tag with already selected tags.
Steps to Reproduce
NA
Screenshots
No response
Do you want to work on this issue?
Yes
If "yes" to above, please explain how you would technically implement this
I would like to resolve this issue to reduce the number of api calls made. I would use debouce technique or AbortController method to address this issue, which will help us to reduce the number of API calls.

Thank you for raising.  However this would make the search appear slower, when only using one tag.  This is likely to be an over optimisation for now, as we have not had any issues  - so I shall close for now.


python310Packages.socid-extractor: allow later beautifulsoup4 releases

Description of changes
Fix build (https://hydra.nixos.org/build/174942911)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 170864 run on x86_64-linux 1

3 packages built:

maigret
python310Packages.socid-extractor
python39Packages.socid-extractor


AttributeError: module 'tensorflow.tools.api.generator.api.estimator' has no attribute 'SessionRunHook'

This template is for miscellaneous issues not covered by the other issue categories.
For questions on how to work with TensorFlow, or support for problems that are not verified bugs in TensorFlow, please go to StackOverflow.
If you are reporting a vulnerability, please use the dedicated reporting process.
For high-level discussions about TensorFlow, please post to<EMAIL_ADDRESS>for questions about the development or internal workings of TensorFlow, or if you would like to know how to contribute to TensorFlow, please post to<EMAIL_ADDRESS>

Please provide details about what platform you are using (operating system, architecture). Also include your TensorFlow version. Also, did you compile from source or install a binary?
Make sure you also include the exact command if possible to produce the output included in your test case. If you are unclear what to include see the issue template displayed in the Github new issue template.
We ask for this in the issue submission template, because it is really difficult to help without that information. Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


feat: strip custom referencing mechanism from Channel Item

Refs #699

Link checker is producing errors in CI. Seems to be unrelated with my changeset.

/dnm

/rtm


fix: support nvim-cmp floating window

Changed in https://github.com/hrsh7th/nvim-cmp/pull/224.
This just replaces the if condition and nvim_replace_termcodes.

Thanks so much!


[Bug]: Pushing forever with no result nor error

Describe the bug
Hi, I have an odd problem. The commit process is working properly but it is not pushing the files. My repository stays unchanged and in the console it just says Pushing... forever. No success, no error. Any ideas? Thank you!
Relevant errors (if available)
No response
Steps to reproduce
Backup command or Push command
Expected Behavior
No response
Addition context
No response
Operating system
macOS
Installation Method
None
Plugin version
2.19.1

Sorry for not replying earlier. I think it was just an issue with my network (which somehow persisted for 5+ days...). The moment I switched to a different wifi at work, it started working again. Back at home, it still works. No idea what has happened.
However, I still experience the issue that it sometimes just stops doing backups but this is a different bug, I guess.


Use elasticsearch_data nodes in Logstash output

Hey! This PR changes the default hosts configuration in logstash elasticsearch output. Instead of collocating ElasticSearch and Logstash on the same VM we can point Logstash output plugin to the DNS name of ElasticSearch data nodes. This will decrease the amount of RAM used by Ingestor instances, check the graph below:

I will also create a separate PR which will allow to configure Elasticsearch coordinating nodes in a high load environments.
/cc @pommi @diogomatsubara

From my point of view - having a local ES drain for Logstash was a great idea, and keeps cluster configuration simpler. To resolve memory issues, we can just increase amount of memory for instance, and maybe change heap calculating formula here.
Anyway, I'd prefer to keep this conversation for a couple of weeks to hear from other active Logsearch users.

Hi @axelaris ! I changed the PR and now by default Logstash will forward to local ES host. I've added link support to ingestor_syslog job and now operator can optionally configure forwarding to remove ES host. I've also added ops file for this ingestor-forward-to-elasticsearch-data.yml . Is it works for you?

Merged.
Thank you @Infra-Red!


Upcoming motor 3.0 (& already existing pymongo 4) compatibility?

Hi,
I understand the current version of the motor dependency relies on pymongo 3.
Since pymongo 4 was released for a while now, motor 3.0 will be migrated to pymongo 4: https://jira.mongodb.org/browse/MOTOR-643
Do you know if migration work will be required for beanie to work with motor 3.0 (& pymongo 4)?
Many thanks

Hey! I don't think there will be a compatibility problem, but even if yes I'll migrate Beanie to motor3 as soon it will be released.

Great news, thanks for the information! I'll be patiently waiting for motor 3 to be able to use use beanie on some project that depends on pymongo 4 :)


No tests shown

Hi,
I'm running arch and I can't display any tests, it always comes up empty.
I've tried with Rust & Python and the same results
using cargo test & python unittests and no joy
$ cat /etc/os-release
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://www.archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
LOGO=archlinux

$code -s
Version:          Code - OSS 1.51.1

Test Explorer UI - v2.19.3

Found hat that the issue is related to rust, working fine in python!


Mixed refined to an object produces a read-only object, which breaks a lot of existing code.

Flow version: 0.98
https://flow.org/try/#0GYVwdgxgLglg9mABMOcAUAjAhgJwFyIC2MAHgKYAmAlIgN4BQiiMwiaUAngA5lyvY5EAQgC8IxAHI4GAFZloExAB8lwgTQZMmOMlBA4kYEABtjAbkaIAvvUss2AgHRQAFjDABzRGPESAznCEum6eEhqWTE6u7l6+OFiuZDgSFkw2VkA
function foo(bar: mixed) {
  if (typeof bar !== 'object' || !bar) {
    return null;
  }

  if (bar.thing === 'something') {
    bar.thing = 'rather';
  }
}

Expected behavior
No Errors

Actual behavior
7:     bar.thing = 'rather';
           ^ Cannot assign `'rather'` to `bar.thing` because property `thing` is not writable.

Also #7684

https://github.com/facebook/flow/commit/0983bd041c6289897c9b33d86e9e14d2b686c2e5

@dsainati1

Can Flow refine writable property if there is if with typeof obj.field?

It is unsafe even if you refine type, because original type may have been string literal
const m: {a: 'foo'} = {a: 'foo'}
function unsafeWrite(obj: mixed) {
   if (typeof obj === 'object' && obj !== null) {
      if (typeof obj.a === 'string') {
        obj.a = 'bar' // unsafe
      }
   }
}
unsafeWrite(m)
m.a // bar

Yes, this is an intentional change. Consider the example in the linked commit:
function bad (x : mixed) {
  if (typeof x === "object" && x !== null) {
    x.a = 3;
  }
}

let obj : {a : string} = {a : "oops"};
bad(obj); // yikes

It is rarely necessary to use mixed, your example could easily be rewritten as:
function foo(bar: ?{thing : string}) {
  if (typeof bar !== 'object' || !bar) {
    return null;
  }

  if (bar.thing === 'something') {
    bar.thing = 'rather';
  }
}

Alternatively you could use generics or bounded generics if your function needs to be able to acept a variety of inputs.

It is rarely necessary to use mixed, your example could easily be rewritten as:

We're adding flow to a large code base, and mixed is a useful and practical tool to enforce refinements when it's woefully difficult to hunt down the type of function arguments.
Sure, I can simply replace mixed with an explicit type based on already written refinements, but that's something that the type system should be doing for me automatically, which is exactly what mixed used to do.
Why not have a warning instead when attempting to write properties of objects of mixed types?


How to reproduce results from the paper?

Is it just the testing result in the last epoch using default parameters? I have tried to run add_test.py and below is the result i get for the 10 epochs.
Test set: Average loss: 0.168699
Test set: Average loss: 0.001142
Test set: Average loss: 0.000922
Test set: Average loss: 0.000345
Test set: Average loss: 0.000143
Test set: Average loss: 0.000188
Test set: Average loss: 0.000121
Test set: Average loss: 0.000028
Test set: Average loss: 0.000244
Test set: Average loss: 0.000042
Which one should I use for benchmarking? In the paper, the result of TCN was 5.8e-5 but it seems like we can use 2.8e-5 or 4.2e-5 here.

Hi @johnsyin ,
Thanks for your interest in our work!
In our paper, I took the average of the test set results from the last 3 epochs. In your case, I think you can also do the same. An alternative way is to use annealing learning rate; after the learning rate is annealed to the bottom, the test result will also converge (whose result you can then report).
But given the numbers you provided, I think you have already reproduced the results :-)

Hi Jerry,
Loved you paper, very appreciate you open sourced the work! I am a MS student researching this method.

The last 3 numbers I provided has a mean of 1e-4, why is it considered as result reproduced (5.8e-5)?
If I can have your advice, do you think multivariate TCN with Squeeze-and-excitation weighted temporal block will work?

Regarding your questions:

It's mainly a problem of training instability, 2.8e-5 and 4.2e-5 are already below what I reported.  Note that these are MSE errors and random guess gives you only ~0.17.

Not sure what exactly your design is, but multivariate TCN has already been widely applied and I think it'd be (generally) a good direction to pursue.

Thank you for your reply!


Formalizeapiforcomputationobject

Added consume_gas function to the computation class

I will sync with the master branch then make a pull request

If you're not already familiar with it, git rebase is the standard workflow for when you need to catch your work up with what's in master.  If you run git rebase master in most cases it will just work.  You will need to force push after the rebase, git push -f ....


Add rule for .z

Thanks @Grafcube . What is this app?

https://github.com/rupa/z/
It's a command that lets you quickly jump to your most frequent or recent directories. so instead of cd path/to/directory you can do z dir and it will cd to the full directory. The .z file contains a list of the known directories and it is 'learnt' as you use your usual cd commands.


Create compiled figure 2

Closes #43
Stacking on #49
This PR adds in a compiled version of Figure 2 as an AI file and PDF file.

I updated the script for creating Figure 2B to save as a pdf.
I resized the overview figure and made sure all the labels for the icons were size 6 and the bigger labels were size 8 (the SCE output and AnnData output labels).
I did not edit any of the icons in the overview or the text inside the icons. I can do that if we think that's necessary.
For the mini QC plots, all the axes titles are size 8 and the facet labels are size 6. I also adjusted the facet boxes so the linewidth is 1 instead of 2. Are we okay with the size of these smaller panels? I could make them bigger if we want them to take up the whole page, but I don't think that's necessary.

I assume this was supposed to go to me for review.

Yes that's correct.

@jaclyn-taroni I made the same organizational changes here as mentioned in https://github.com/AlexsLemonade/scpca-paper-figures/pull/49#issuecomment-1938884084.
I also updated the font size for the overview figure to be as big as I could get it without the text being overcrowded. I made the QC plots take up more space and thus increased the font size.


[SPARK-30000][SQL] Trim the string when cast string type to decimals

What changes were proposed in this pull request?
https://bugs.openjdk.java.net/browse/JDK-8170259
https://bugs.openjdk.java.net/browse/JDK-8170563
When we cast string type to decimal type, we rely on java.math. BigDecimal. It can't accept leading and training spaces, as you can see in the above links. This behavior is not consistent with other numeric types now. we need to fix it and keep consistency.
Why are the changes needed?
make string to numeric types be consistent
Does this PR introduce any user-facing change?
yes, string removed trailing or leading white spaces will be able to convert to decimal if the trimmed is valid
How was this patch tested?

modify ut

Benchmark
/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.apache.spark.sql.execution.benchmark

import org.apache.spark.benchmark.Benchmark

/**
 * Benchmark trim the string when casting string type to Boolean/Numeric types.
 * To run this benchmark:
 * {{{
 *   1. without sbt:
 *      bin/spark-submit --class <this class> --jars <spark core test jar> <spark sql test jar>
 *   2. build/sbt "sql/test:runMain <this class>"
 *   3. generate result: SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain <this class>"
 *      Results will be written to "benchmarks/CastBenchmark-results.txt".
 * }}}
 */
object CastBenchmark extends SqlBasedBenchmark {

  override def runBenchmarkSuite(mainArgs: Array[String]): Unit = {
    val title = "Cast String to Integral"
    runBenchmark(title) {
      withTempPath { dir =>
        val N = 500L << 14
        val df = spark.range(N)
        val types = Seq("decimal")
        (1 to 5).by(2).foreach { i =>
          df.selectExpr(s"concat(id, '${" " * i}') as str")
            .write.mode("overwrite").parquet(dir + i.toString)
        }

        val benchmark = new Benchmark(title, N, minNumIters = 5, output = output)
        Seq(true, false).foreach { trim =>
          types.foreach { t =>
            val str = if (trim) "trim(str)" else "str"
            val expr = s"cast($str as $t) as c_$t"
            (1 to 5).by(2).foreach { i =>
              benchmark.addCase(expr + s" - with $i spaces") { _ =>
                spark.read.parquet(dir + i.toString).selectExpr(expr).collect()
              }
            }
          }
        }
        benchmark.run()
      }
    }
  }
}

string trim vs not trim
[info] Java HotSpot(TM) 64-Bit Server VM 1.8.0_231-b11 on Mac OS X 10.15.1
[info] Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
[info] Cast String to Integral:                  Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
[info] ------------------------------------------------------------------------------------------------------------------------
[info] cast(trim(str) as decimal) as c_decimal - with 1 spaces           3362           5486         NaN          2.4         410.4       1.0X
[info] cast(trim(str) as decimal) as c_decimal - with 3 spaces           3251           5655         NaN          2.5         396.8       1.0X
[info] cast(trim(str) as decimal) as c_decimal - with 5 spaces           3208           5725         NaN          2.6         391.7       1.0X
[info] cast(str as decimal) as c_decimal - with 1 spaces          13962          16233        1354          0.6        1704.3       0.2X
[info] cast(str as decimal) as c_decimal - with 3 spaces          14273          14444         179          0.6        1742.4       0.2X
[info] cast(str as decimal) as c_decimal - with 5 spaces          14318          14535         125          0.6        1747.8       0.2X

string trim vs this fix
[info] Java HotSpot(TM) 64-Bit Server VM 1.8.0_231-b11 on Mac OS X 10.15.1
[info] Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
[info] Cast String to Integral:                  Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
[info] ------------------------------------------------------------------------------------------------------------------------
[info] cast(trim(str) as decimal) as c_decimal - with 1 spaces           3265           6299         NaN          2.5         398.6       1.0X
[info] cast(trim(str) as decimal) as c_decimal - with 3 spaces           3183           6241         693          2.6         388.5       1.0X
[info] cast(trim(str) as decimal) as c_decimal - with 5 spaces           3167           5923        1151          2.6         386.7       1.0X
[info] cast(str as decimal) as c_decimal - with 1 spaces           3161           5838        1126          2.6         385.9       1.0X
[info] cast(str as decimal) as c_decimal - with 3 spaces           3046           3457         837          2.7         371.8       1.1X
[info] cast(str as decimal) as c_decimal - with 5 spaces           3053           4445         NaN          2.7         372.7       1.1X
[info]

cc @cloud-fan @maropu @wangyum, the decimal is left behind and this pr is aiming to fix this. the benchmark also shows great performance improvement. thanks for reviewing in advance.

Test build #114297 has started for PR 26640 at commit ed4de79.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19137/
Test PASSed.

Test build #114297 has finished for PR 26640 at commit ed4de79.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114297/
Test PASSed.

Test build #114345 has started for PR 26640 at commit da1c828.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19184/
Test PASSed.

Test build #114345 has finished for PR 26640 at commit da1c828.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114345/
Test PASSed.

thanks, merging to master!


Removed Assertion.expectedError.

Description:
Removed Assertion.expectedError in the callFailing method.  Doing so allows the proper error to be caught and the test to pass.
Related issue(s):
Fixes #1199
Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Patch and project coverage have no change.

Comparison is base (f3bd80b) 74.41% compared to head (38e8df0) 74.41%.

:exclamation: Current head 38e8df0 differs from pull request most recent head 24ac674. Consider uploading reports for the commit 24ac674 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.23    #1200   +/-   ##
=============================================
  Coverage         74.41%   74.41%
=============================================
  Files                31       31
  Lines              2204     2204
  Branches            435      435
=============================================
  Hits               1640     1640
  Misses              444      444
  Partials            120      120

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Added check to avoid debounce altogether if unnecessary

Even when setting -d 0 the command execution is still debounced enough that filesystem move events do not fire commands correctly (on MacOS 10.13.3) - a move will register an unlink and an add, but only fires the command for the add:
With -c echo {path} {event}:
mv test test1
unlink:test
add:test1
test1 add

This PR fixes the problem by checking if debounce is required at all (based on a non-zero debounce time) and if not required, launches the command with only throttling. This results in what I assume is the correct behaviour:
With -c echo {path} {event}:
mv test test1
unlink:test
add:test1
test unlink
test1 add

I hope this is helpful and many thanks for this project.

Can you rebase this?

I think this is effectively resolved (albeit with a different API of --debounce 0) in #90, which has been merged. This PR can probably be closed.


[FR] recursiveDelete also for firebase-admin

problem
There is no easy way to delete a document and all its nested elements (subcollections and documents as well as deeper nested elements) with the firebase-admin package.
Describe the solution you'd like
A function to delete a document and all its descendant elements, similar to firestore.recursiveDelete() from the google-cloud/firestore package.
Describe alternatives you've considered

1: using both firestore-admin and google-cloud/firestore packages simultaniously. Seems overkill to have that much duplicate functionalities.
2: creating a cloud function as described here. I would prefere to not have a publically accessible function that lets you delete data from the database. Although you can secure it with authentication, this would not let me sleep peacfully at night.

Additional context
firebase is the best 🔥

Hey @dcts ,
The Admin SDK uses google-cloud/firestore so you should be able to do the following:
import { initializeApp } from 'firebase-admin/app'
import { getFirestore } from 'firebase-admin/firestore';

const app = initializeApp()

const fs = getFirestore()
fs.recursiveDelete(...)

Please provide a repro if this is not what you expected. Thanks!

Awesome, this indeed does work! Thanks for your answer! I realized that I was using version 9, and this seems to only work with v10. I guess will need to update to v 10 soon :)


plugin v3.3.1 not visible in menu. gimp 2.10.6 ubuntu16.10

I read the comments about problems seeing the plugin in the file menu, after upgrading gimp.
I removed old version, installed latest version of plugin (v3.3.1), reset GIMP, but keeps invisible for me..
I am using ubuntu 16.10

hi @khalim19 thanks for the quick reply!

I didn't found any error.log file inside the export_layers folder.
I am not sure about the previous plug-in version, I removed both the export_layers and export_layers.py and override with latest one.
I didn't removed the parasiterc file, but checking it, it only has a couple of comments, either with gimp opened or closed.
the directory for plugins is ~/.config/GIMP/2.10/plug-ins, in this folder there are both the export_layers.py and the export_layers folder.

Thanks for the information, looks like the previous plug-in version somehow interfering with the new version is not the problem.
A couple of other things to check:

Run Filters -> Python-Fu -> Console. The Python version should be 2.7.
Go to Edit -> Preferences -> Folders -> Plug-Ins and check if the directory ~/.config/GIMP/2.10/plug-ins is listed. If not, add the folder and restart GIMP.

If the plug-in still doesn't display in the File menu, then you could try installing GIMP 2.10.8 (flatpaks or AppImages should be available).

I've been having this same issue for a while, and just found the reason (and solution), on this forum thread.
It turns out that GIMP (from the Ubuntu repository) no longer marks the gimp-python package as a dependency, only recommended. I just installed it, and now export-layers works fine!

still not working for me
ubuntu 18.04 here

Closing this issue due to inactivity.
I found a guide applicable for Ubuntu 20.04. It appears this fails for later versions of Ubuntu such as 22.04, though.
Using an AppImage or flatpak GIMP installer should make Python plug-ins work, including Export Layers. The official GIMP site provides a flatpak. A custom-made AppImage for Ubuntu 22.04 is available e.g. here.


cpp_str() impossible to be used with u8string

Hello,
while using object with tiny_utf8::u8string type there is a problem with compilation while cpp_str() and/or cpp_str_bom() is being in use by a code.
Compiler: g++-10, 10.3.0-1ubuntu1~20.04
With -std=c++2a flag.
../../libs/tiny-utf8/include/tinyutf8/tinyutf8.h:3404:46: error: conversion from ‘basic_string<char>’ to non-scalar type ‘basic_string<char8_t>’ requested
 3404 |   std::basic_string<data_type> result = std::string( size() + 3 , ' ' );
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~

https://github.com/DuffsDevice/tiny-utf8/blob/cab426cc57686c418e422b0e2941a4ff5355bc72/include/tinyutf8/tinyutf8.h#L3404

Hi Patryk,
Thanks for submitting a bug report, I'll fix it right away!

Let me know, if everything works for you now. If not, please feel free to re-open the ticket :)


Documentation update for v1beta1 api

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Documentation update necessary for v1beta1 api graduation.
Which issue(s) this PR fixes:
Special notes for your reviewer:

/assign @alculquicondor

Also please update config/samples

cc @cortespao

/lgtm
/approve


Automated Builds For Windows Seem Broken

The https://github.com/uNetworking/uWebSockets.js/tree/binaries branch has not had a windows .node update in 5 months. When I forked the project to add a custom version no .node binary was emitted to the dist folder in the build-windows job. It would appear that Windows CI builds are broken.

Everything but Linux is broken because the code currently do not compile on anything but Linux.


Run http server on <IP_ADDRESS> instead of localhost

This commit:

Modifies the http server to listen on <IP_ADDRESS> to be able to query
for the go/no-go signal using the public hostname/ip of the host
on which the tool is running.
Adds chaos testing for OpenShift as a use case.

Will rebase the PR once https://github.com/openshift-scale/cerberus/pull/14 gets merged. Thanks.

Can one of the admins verify this patch?

Maybe we need to specify that Cerberus will only support ipv4 for the time being?

@jtaleric updated the PR to convey that it supports only ipv4 at this moment. PTAL. Thanks.


Blog post content updates and Quick Demo name change

going to wordsmith the Quick Demo piece a bit. Will create a new PR for this.


[Bug] Kitsu tracking is not working right now, due failed to resolve the API url (?)

Device information

Tachiyomi version: Stable 1.6.1
Android version: 10
Device: Realme 7 pro

Steps to reproduce

Open any manga
Click the Tracking
Use Kitsu Tracking

Expected behavior
Search working normally
Actual behavior
Get failed to connect to the API url instead
Other details
Login or Logout kitsu service from the app working fine tho no problem,
already tried to clear cookies as well, the api url somehow still same no matter what i do
attached file :

SY does not edit the kitsu tracker from Tachiyomi, test it in tachiyomiorg/tachiyomi, as it's likely not SY specific

ah yes, tried it with the vanilla ones, it seems its their end, thanks for pointing it out, gonna report it there

👍


Fix a listening message typo

Description

Fix a small type in listening message for node16 and node17 templates
Motivation and Context

[ ] I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #
How Has This Been Tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Version change (see: Impact to existing users)

Impact to existing users

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Thanks for the PR @AbderrahimSoubaiElidrissi
I don't think we've met before, how/where are you using OpenFaaS?

Hi @alexellis
I'm actually following you on Twitter and I like the work you're doing here guys. I used OpenFaaS in PoC at work to demonstrate how we can pipeline functions as middleware. and Lastly for educational purpose I cloned TravisCI and the build part was serverless


"add destination" form

Value Proposition
As a user, I want to add a new destination to my trip, so that i can plan the details for visiting the destination.
Description

Acception Criteria

[ ] Displays an add destination button on destinations page
[ ] Displays an input field to enter a new destination name
[ ] It creates a new destination in the destinations list with entered name

Tasks

[ ] Create a form with a styled add button and styled input form element
[ ] Place the form inside the destinations list (below the last destination if exists)
[ ] Create a function "addDestinationHandler", that adds a new destination with auto generated destinationId, the entered name and associated tripId to the destinations state
[ ] Show the new destination as the last item in the destination list

What do you mean by default values? You might also display two input fields next to the + button where you add the destination and date. That would not inflate this user story too much.

My first thought was to just create a new item with default name "New Destination" on button click. To change the values you click on the name to open a new page where you can enter more details like dates, hotels, etc.
But i changed my mind to make this page more simple. I removed all the dates in this list. They will be shown in a different way (maybe as days) in the future.

This looks already very professional, I like it a lot!


Gradle build-cache mess up with our tests on Widows

Expected Behavior
When I execute the test in different OS the gradle task doesn't use the build-cache from other OS
Observed Behavior
It does: https://ge.detekt.dev/s/rhgcpvrympk7w/timeline?name=:detekt-api:test
Context
I started this reasearch after this comment: https://github.com/detekt/detekt/pull/6829#issuecomment-1890788295
The issue is that some PRs are failing on the Windows CI. It seems that #6829 introduced the problem. But, the CI on that PR is green and the CI once that PR was merged on main is green too (3c6eee5df6d7cea00055d3bf258393a0b2108812). And this second one doesn't use PTS so that's not the problem.
And if you check the build scans of the merge on main you can see that the 3 excutions on Windows have detekt-cli:test FROM-CACHE.

https://ge.detekt.dev/s/rhgcpvrympk7w/timeline?name=:detekt-api:test
https://ge.detekt.dev/s/5ubb3oyfqkdr6/timeline?name=:detekt-api:test
https://ge.detekt.dev/s/3s5rpvi7gtb6g/timeline?name=:detekt-api:test

Possible solution
I imagine that we should add an input for all the test tasks that defines the OS. This way gradle will not share the build-cache between them.
Your Environment

Version of detekt used: main

An alternative would be to use something like jimfs for the tests that deal with path handling, and have separate unit tests for Windows & *nix that will run on any OS.
If we do instead add the OS as a cache key as proposed I think that should be done alongside splitting test sources so the tests that are OS-dependent are in a separate source set from everything else. Unit tests shouldn't depend on the OS they run on.

Here we have another instance of this issue: #7104 is failing for something that, I guess, was introduced at #7092
And I don't know how we could spot that this test was OS dependant.

I don't know how we could spot that this test was OS dependant.

The test deals with path input - that's the common issue. But I'm also not sure how best to spot this and make sure it's consistently identified and handled appropriately, other than just fixing it as it comes up. There's so much change at the moment that it's causing issues but it should settle once 2.0 is out the door.

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

This issue was closed because it has been stalled for 7 days with no activity.


UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 100: ordinal not in range(128)

Hi,
I am running to an "ascii error" whenever I use the library with models loaded from HFTransformers. The code runs perfectly with other llms like OpenAI or MistralAI.
Example code:
with DataDreamer("./test"):
  hrs_dataset = DataSource('hrs_documents', Dataset.from_list([{'text':'article 1 text'}, {'text':'article 2 text'}]))
  model  = HFTransformers("tiiuae/falcon-40b-instruct", device_map="auto")

  hrs_dataset = hrs_dataset.take(10)
  output_dataset = ProcessWithPrompt(
      "Mine arguments from texts",
      inputs={"inputs": hrs_dataset.output['text']},
      args={
          "llm": model,
          "Temperature": 1.2,
          "instruction": (
              "summarize the text"
          ),
      },
      outputs={"inputs": "fullText", "generations": "summaries"},
  )

  output_dataset.save()

Solved by setting the LC_ALL environment variable (some Linux machines don't have this configured properly):
export LC_ALL=C.UTF-8

For my own future reference, I added a block of code here:
https://github.com/datadreamer-dev/DataDreamer/commit/b48b58e048950ba9c2d693d8edbc399b0d64171c
That sets the locale/encoding to utf8 for users who many have a system that is not properly configured, without them having to use the LC_ALL environment variable. This is difficult to test for, so it may or may not work for everyone.


CarouselView animation stops working after rebuild

Steps to reproduce
Create a CarouselView
Get the widget to reload (through setState(…) or hot reload, etc.)
this is the same issue as in 153694 that was fixed? in 153805
Expected results
Expected results
The CarouselView should still work and animate properly after a rebuild
Actual results
Actual results
The CarouselView behaves like a horizontal ListView instead and all the items keep the same width.
Code sample
Code sample
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';

/// Flutter code sample for [Carousel].

void main() => runApp(const CarouselExampleApp());

class MyCustomScrollBehavior extends MaterialScrollBehavior {
  @override
  Set<PointerDeviceKind> get dragDevices => {
        PointerDeviceKind.touch,
        PointerDeviceKind.mouse,
        PointerDeviceKind.trackpad
        // etc.
      };
}

class CarouselExampleApp extends StatelessWidget {
  const CarouselExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      scrollBehavior: MyCustomScrollBehavior(),
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Carousel Sample'),
        ),
        body: const CarouselExample(),
      ),
    );
  }
}

class CarouselExample extends StatefulWidget {
  const CarouselExample({super.key});

  @override
  State<CarouselExample> createState() => _CarouselExampleState();
}

class _CarouselExampleState extends State<CarouselExample> {
  @override
  Widget build(BuildContext context) {
    return Center(
      child: ConstrainedBox(
        constraints: const BoxConstraints(maxHeight: 200),
        child: CarouselView(
          itemExtent: 330,
          shrinkExtent: 100,
          children: List<Widget>.generate(20, (int index) {
            return UncontainedLayoutCard(index: index, label: 'Item $index');
          }),
        ),
      ),
    );
  }
}

class UncontainedLayoutCard extends StatelessWidget {
  const UncontainedLayoutCard({
    super.key,
    required this.index,
    required this.label,
  });

  final int index;
  final String label;

  @override
  Widget build(BuildContext context) {
    return ColoredBox(
      color: Colors.primaries[index % Colors.primaries.length].withOpacity(0.5),
      child: Center(
        child: Text(
          label,
          style: const TextStyle(color: Colors.white, fontSize: 20),
          overflow: TextOverflow.clip,
          softWrap: false,
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
✓] Flutter (Channel stable, 3.24.4, on macOS 15.1 24B83 darwin-arm64, locale en-US)
    • Flutter version 3.24.4 on channel stable at /Users/marshallbuck/Dev/flutter_sdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 603104015d (2 weeks ago), 2024-10-24 08:01:25 -0700
    • Engine revision db49896cf2
    • Dart version 3.5.4
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/marshallbuck/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16B40
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] IntelliJ IDEA Ultimate Edition (version 2<IP_ADDRESS>)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 81.1.3
    • Dart plugin version 242.20629

[✓] VS Code (version 1.95.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.100.0

[✓] Connected device (5 available)
    • brokeassipad (mobile)           • 00008027-001965D40AB8802E • ios            • iOS 18.0.1 22A3370
    • iPhone (mobile)                 • 00008020-000474D00142002E • ios            • iOS 18.0.1 22A3370
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 15.1 24B83 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 15.1 24B83 darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome 130.0.6723.117

[✓] Network resources
    • All expected network resources are available.

Hi @marshall-buck, the fix for #153694 has not yet landed in the stable channel. It is currently on the beta/master channel.
Can you check on either of these channels to see if you still experience this issue? If you do, please provide the version of either beta/master that you used.
Thank you

Seems to work in Beta channel, thanks.


Stray oddities from bookmark refactor/iCloud integration

Relating to #2483 bookmark refactor, we’ve seen cases where bookmarks are:

losing prior ordering
new bookmarks add to bottom , not top of list (if intended, 👌, just curious if you intentionally wanted to reverse that)
lost bookmarks-perhaps mostly coinciding with private repos

Ok so I downloaded an older build off of TF and a few things of note:

Should we delete the local storage of bookmarks once they're migrated? One big nit I have with some apps is when they store files that can't be deleted without reinstalling the app and risk losing other things. I know the file is small in this case but yano?

I've just checked which ones disappeared and I think it looked more dramatic because I have an issue bookmarked which wraps onto 10 lines so takes up a lot of the screen and has since been deleted (Fully understand this one being gone)!

The main thing though is the removal of one of my private repos stored in a 2FA org.
On v1.26 this same repo is unavailable, it says 'There was an error loading the repository.' which is likely why it's not showing with the new live updating logic. However on v1.25 I can access this repo with no issues - wonder what change caused this as it doesn't seem related to bookmarks refactor? @rnystrom

It’s related. I moved the repo “has issues enabled” and “default branch” settings to a fetch in the repo VC. This API auth difference between 3 and 4 is really frustrating.
Sent with GitHawk

Details:
https://github.community/t5/GitHub-API-Development-and/Getting-quot-OAuth-App-access-restrictions-quot-for-GraphQL/m-p/14556#M262

I'm honestly thinking about requiring PAT login as the only option.

Hmm yeah that's really frustrating!
I mean I'm completely up for just using PAT if it gives us more flexibility and less issues - but I do think we need to work out a nice way to explain this to users when shipping the update.
Wouldn't jump to my mind to switch to using PAT and don't want it to look like we've just logged users out or something!

Nope def wouldn't do that. Another option would be that when we get an OAuth error, show a more detailed alert on how to add a PAT to your account (requires updating account settings so you can override current login w/ a PAT tho).
Unfortunately I'm pretty burnt out on this project atm after this setback and the API hiccups w/ the inbox redesign. It'll be a while before I get back to anything.

100% agree, it's these sorts of things outside of your control that send you completely crazy. The fact it feels like the V4 API is really a setback in some aspects versus the V3.
I do think your idea of showing a more detailed error with suggestions is definitely a great idea! Should we break this down into a separate issue for tracking and leave this for the reordering question?


Update Bumbershoot to 3.0.20290

@bgruening Where is the conda log? I'm not sure why these commands aren't being found. The tests worked in bioconda.

@chambm have a look under "Actions" here on this page. It will bring you to https://github.com/galaxyproteomics/tools-galaxyp/actions/runs/316310819   than search for All tool test results download the tarball and look at the HTML.

I had already checked that. That's where I saw the failures due to the commands not being found. I don't see any conda output there. The commands are definitely inside the conda package. The new package size is basically the same as the old one.
But I just noticed I changed the underscore in the package name to a dash inadvertently. That's almost certainly the issue (but it would've been nice to see the conda output to be sure).

@bgruening Seems something changed with the environment since the last time I updated this. That idpAssemble command works fine on a local Ubuntu instance, even when I make the filepaths the exact same.

What is different now is that it is running in containers. Can it be that the container is not working?
You can test with planemo test --docker ...

I don't have planemo handy to run at the moment. Does the container do something different with /tmp?

Does the container do something different with /tmp?

Oh this can also be -- mh, damn. I will put it on my to do list but no promises :(

Hey @chambm maybe you can cherry-pick this one https://github.com/galaxyproteomics/tools-galaxyp/pull/520
should solve the tmp problem. We did the same for some tools at IUC recently https://github.com/galaxyproject/tools-iuc/pull/3315


Updates GCS, Spanner and BigQuery source plugin widget jsons to have …

…browse widget associated with projectId

@albertshau Good point. Right now it does throw an exception but this will not be visible to the user nor will it be blocking the user flow. It should be fine if the plugin is used in earlier versions of CDAP (6.0). Have filed a JIRA-CDAP-15592  anyways to fix this in 6.0 and 6.1


[PORT]Add fullName to resource class and keep resource consistent across lg…

issue reference: https://github.com/microsoft/botbuilder-dotnet/issues/4152
The issue previously is, assuming such a structure:
1.lg import 2.lg
The id of 1.lg is set to the file full path, -> xxx/yy/1.lg,
But the id of 2.lg is set to the file name, -> 2.lg
which is not consistent
What this pr did:

change ImportResolverDelegate from
(string sourceId, string resourceId) => (string content, string id) to (LGResource resource, string resourceId) => LGResource and LGResource contains Id, Content and FullName properties.

Add ParseResource function which a more generic LGResource into LGParser to replace ParseText  (ParseText would be deprecated and marked as [deprecated])

Add TemplateEngineLanguageGenerator(Resource resource,  resourceMapping) constructor,
filePath and lg text format constructor would be deprecated in the next version. Mark them with [deprecated]

Move FullName property from FileResource to abstract class Resource

Use lgResource.Id as the id of the unified templates to call

Add Source property in Templates which means the source of current lg file. (which would be absolute file path for file resource.)

Adjust corresponding tests.

Pull Request Test Coverage Report for Build 156456

61 of 66 (92.42%)  changed or added relevant lines in 8 files are covered.
12 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.08%) to 82.901%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-lg/src/templatesParser.ts
34
39
87.18%

Files with Coverage Reduction
New Missed Lines
%

libraries/adaptive-expressions/src/builtinFunctions/getNextViableTime.ts
1
87.3%

libraries/adaptive-expressions/src/builtinFunctions/getPreviousViableTime.ts
1
88.89%

libraries/botbuilder-lg/src/templates.ts
1
93.11%

libraries/botframework-streaming/src/webSocket/webSocketTransport.ts
2
80.65%

libraries/botframework-streaming/src/webSocket/webSocketServer.ts
7
66.67%

Totals

Change from base Build 156333:
-0.08%

Covered Lines:
15032

Relevant Lines:
17245

💛  - Coveralls


Running GATK-HaplotypeCaller from Java

Hi Everyone,
I have a use case where I need to directly call HaplotypeCaller from Java code. I can pass the required command line arguments (as String array). I am wondering how to call the main class with the required arguments.
I have tried calling org.broadinstitute.hellbender.Main with arguments but I get "HaplotypeCaller is not a valid command" (HaplotypeCaller works from the command-line prompt). Is this the correct class? Or should I create object of some other class and call its methods directly? Is there some way to load the list of available commands before hand?
Thank you very much for your time.
Abhishek

Hi @virtuabhi, this is out of scope of what we normally support so I can't guarantee you'll get an answer. However, if you post a bit more detail (like, what the surrounding code looks like and what you're ultimately trying to do) our engineers may be able to suggest a solution.

Hi @vdauwera, @lbergelson
I spent some more time on the issue and I believe that the problem is at my end with some incompatible versions of libraries and environment variables. I will try to fix it and let you know if I get errors from the GATK side.
Thank you for your time.

@virtuabhi What are you trying to do exactly?  If you can explain your goal in a bit more detail I can probably help you accomplish it.  If you want to directly run an instance of HaplotypeCaller with an arg array then the easiest thing is probably:
  new HaplotypeCaller().instanceMain(args);

That's going to work better than trying to invoke Main.main() since that will eventually call System.exit() and kill your program.

Thanks @lbergelson . I have added a new ReadsDataSource which reads files from HDFS in the GATK source code.
I edited the build file of GATK and added a dependency to Hadoop JAR files of version 2.5.2 (the version installed on my cluster). The GATK JAR already includes a dependency to Hadoop version 2.7.2. So I was ending up with a GATK JAR with libraries from two versions of Hadoop which was causing the error.
While finding the cause for this error, one of the things I tried was calling the main function from external GATK JAR using Java reflection and that's when I got the "command not found" error. However, calling the GATK-protected JAR from command line (as a different process) has always worked. Also, by importing the GATK JAR and calling the main function with an array of arguments, I was able to start the program.
I have fixed this issue now (changed all Hadoop versions to 2.5.2) and am calling GATK from command line which works without any issue. Will keep the information in mind about calling instanceMain to avoid the System.exit call.
Thank you for your help!
Abhishek


[Bug] Fixed Label cluster has no FeatureMap attribute on certification test device

Describe the bug
When running certification tests for a controller, certain test cases (e.g. TC-CC-3.4) require to commission a device that is running on Raspberry PI (TH) to the controller (DUT).
Fixed Label cluster (0x0040) has no feature map on that device. This can be seen with chip-tool as a controller.
Steps to reproduce the behavior

Open TH UI
Enter PICS files
Create a project
Add a new test
Start with just FirstAppSuite enabled
Pair the device with chip-tool
Try reading the feature map (or all) attribute from the commissioned device

Expected behavior
The feature map should be read from the device.
Log files
chiptoolpairing.log
chiptoolreadfixedlabel.log
chiptooltracepairing.log
chiptooltracereadfixedlabel.log
PICS file
controllerpics.zip
Screenshots
Reading Fixed Label from chip-all-clusters-app:

Reading Fixed Label from certification tool:

Environment

TH version: (TH Fall2023) and (2.10-beta3+spring2024 Sha: e182d0f)
OS version: (Linux ubuntu 5.15.0-1038-raspi) and (Ubuntu 22.04 on PC)

Additional Information
No response

Hello, .
Thanks for the feedback. Looking at the log I noticed that you are using an old version of TH. Could you update to version v2.10+spring2024 and check if the problem still occurs?
If you don't have any related problems, could you close the issue?

Closing as the originator seems to have lost interest.


Add fixup commands

WHAT
Add fixup commands
WHY
Try a manual workflow instead of automatic.
HOW
Checklist :clipboard:

[ ] Add explicit visibility modifier and explicit return types for public declarations
[ ] Run spotless check
[ ] Run tests
[ ] Update metalava's signature text files

@luizgrp going to land to test, I have a broken PR


Additional data needed in s.auth.login for friend requests and ignored users

Current:

Needed data:

outgoing_friend_requests: userIds this user has sent friend requests to but haven't been accepted or declined yet
incoming_friend_requests: userIds of users that have sent friend requests to this user but that haven't been accepted or declined yet
ignored_users: userIds this user has set to ignore

A imo scrap friend_requests because it's not clear if this is for incoming or outgoing requests

:+1:


Symlink icons

This MR symlinks icons instead of copy pasting them. This helps avoiding the need of duplicating icons (and thus duplicating size too). Here are all the changes:

symlink to all well-known names
move all icon names to reverse-dns equivalents
remove duplicated icons

A little tip: you can run the following commands from the terminal to symlink:
cd PATH/TO/DIR
ln -s SOURCE.svg DESTINATION.svg

so should we have a system as to which should be primary icon? like for instance if there is flatpak then we will name by that name if not then snaps or something and so on ?

This is up to you on what you want to decide as the primary icon. It was a bit cocky of me to move everything to reverse-dns without any discussion, so I want to apologize for that. My goal was to have a standard so we can easily reference the source icons by using reverse-dns instead of fiddling around (which I suggest). If you prefer something else, I will gladly change it.
And yes, it's like that. Many desktop entries like Firefox's specify different icon names, which can cause tons of problems with compatibility. In Firefox's case, Firefox from Flathub uses Icon=org.mozilla.firefox. Firefox from system package managers uses Icon=firefox in the desktop entry. So I symlinked org.mozilla.firefox to firefox. Without the symlink, if I was to use Firefox from my distro repos, which comes with a desktop entry containing Icon=firefox, then the icon theme wouldn't apply the Firefox icon. With the symlink, it does. The same goes with many of the symlinks I have done in this MR
I symlinked many of these icons to maximize compatibility. For example, org.mozilla.firefox symlinks to org.mozilla.Firefox, because the former is used by Flathub, but the latter is used by Fedora Flatpaks. Even a casing distinction can cause issues.

@TheEvilSkeleton yea this is good. Actuallly I was thinking of doing something along the same line with flatpaks names as primary as it is easy names for me to find than distro specific names. so yea lets do reverse-DNS as primary icons and symlink to others.
Also lets make a list of icons that are common and add new icon requests to that thread.