Home page About us section

Is your feature request related to a problem? Please describe.
It's not actually a problem, but a feature that I can add to make it look amazing
Describe the solution you'd like
Add carousel(sliding effect) in the about us section on the home page. It would look great with that auto sliding effect
Describe alternatives you've considered
The sliding is automatic as well as control.
Additional context

can you explain what feature u wnat to add ?? @SurabhiSuresh22

can you explain what feature u wnat to add ?? @SurabhiSuresh22

I would like to add a carousel(sliding effect) using bootstrap in the about us section on the home page using 2 more images and quotes. It would look great with that auto sliding effect. It can be automated as well as controlled, a simple image is shown in the issue.
Thankyou

@SurabhiSuresh22 this is the new design we have redesigned are you up for designeg this ???

@SurabhiSuresh22 u can check home page as well

@Ayan-thecodeking I can design this, if the image is being provided to me.

@RiyaGupta89 sure you can work ...let me know you are up or not
comment on #200


NXP 5746C run program/ecda fail

Description

Type: Bug
Priority: Major

Bug
OS
rtos
mbed TLS build:
Version: 2.26.0
OS version: x.x.x  01.00
plateform: NXP 5746C big endian
Expected behavior
Run progam/ecdsa
mbedtls_ecdsa_read_signature() should return 0
Actual behavior
mbedtls_ecdsa_read_signature() return  MBEDTLS_ERR_ECP_INVALID_KEY
Steps to reproduce

run ecdsa
mbedtls_ecdsa_read_signature() return  MBEDTLS_ERR_ECP_INVALID_KEY

Hi @shengxiang200788 ,
It is possible that you are seeing an arithmetic bug since we do not test on PPC architecture. In order to help I will need more information, please.
Can you tell me what compiler you are using? And also any compiler flags would be helpful too.
Additionally I will need the contents of your config.h file so please send that over as well.
Thanks,
Tom

I use S32DS to compile the mbedtls
compile flags are: -std=c99 -DCPU_MPC5746C  -O0 -g3 -Wall -c -fmessage-length=0 -msdata=eabi -mlra -funsigned-bitfields -ffunction-sections -fdata-sections -fno-common -mcpu=e200z4 -specs=ewl_c9x.specs -mbig -mvle -mregnames -mhard-float
config.zip

#3855 may be relevant for improving testing on PPC

I add memset in function  mbedtls_mpi_grow( mbedtls_mpi *X, size_t [nblimbs](url) ) to
zeroize the memory allocated by mbedtls_calloc( nblimbs, ciL ) , like:
memset(p, 0 , nblimbs * ciL);
It works now.

to zeroize the memory allocated by mbedtls_calloc

I'm glad you found the problem!
Your fix is incomplete, however. mbedtls_calloc must zeroize the memory. That's the job of calloc (as opposed to malloc which leaves the memory contents undefined). If mbedtls_calloc doesn't zeroize the memory, you'll have a lot of other problems. So you need to fix the library integration (or the platform library).

I'm closing this issue since it turned out not to be a bug in Mbed TLS.

Good, thanks for your reply.

I'm closing this issue since it turned out not to be a bug in Mbed TLS.


users.users.<name>.autoSubUidGidRange = true creates overlapping Ids for normal and system users

Describe the bug
Setting users.users.<name>.autoSubUidGidRange = true for a few normal and a few system users creates overlapping Ids, where it appears that the "counter" starts at the beginning for the system and normal user category.
Steps To Reproduce
Steps to reproduce the behavior:

Set users.users.<name>.autoSubUidGidRange = true for a few normal users
Set users.users.<name>.autoSubUidGidRange = true for a few system users
Observe overlapping IDs in /etc/sub*id

Expected behavior
ID ranges count linearly to avoid overlap, considering both system and normal users the same.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.5.5-zen1, NixOS, 23.11 (Tapir), 23.11.20231004.7131f3c`
 - multi-user?: `yes`
 - sandbox: `relaxed`
 - version: `nix-env (Nix) 2.17.0`
 - nixpkgs: `/nix/store/hcdnrkjkrm30lg62aakdiah076iwjxhl-9gzb6bb0ghi5njm63sghyl7ia47n1ncn-source`

I noticed that here (https://github.com/NixOS/nixpkgs/blob/81e8f48ebdecf07aab321182011b067aafc78896/nixos/modules/config/users-groups.nix#L355C27-L355C27) the default for normal users is to generate sub*ids if none are specified and not explicitly disabled, which is ok (most system users wouldn't need to run podman), but I coundn't find where the actual generation script resides...

Yep, ran into this too. The bit that updates user info is here by calling this perl script.


People to invite

https://x.com/saxenauts/status/1869037984215122411

lol yeah, a big problem with the mimetic culture is enforced uniformity on perspectives.
people, and especially academicians would be better off questioning the ontology behind their epistemology.
we are taught that the perspectives are the reality itself.
faber book of science is a good book to unlearn the indoctrination.

I'm just inviting people now as I find them, no need for this ticket


Service discovery client

The discovery service combines at two features:

discovery services
distribute these discovered services and allow to query/filter them

Extract the discovery logic in a client so it can be used without the service.

You mean extracting a lookup interface and publisher interface ?
Most of the service-based system don't do this distinction.

I mean a way to make discovery of such clients without the service and the replication.
for example:
// Just discovert thing, don't start a service just to be aware of what service can be found
DiscoveryClient client = createClient(config);
client.performDiscovery(results -> {
  // Get what has been discovered
});

I still don't get it, when you have your instance of DiscoveryService, you don't do the lookup right away, you do your lookup when you call getRecords. The only benefits there is the "config".
Actually it's close to what we called service locator:
locator = ServiceLocator.create(discovery, filter);
locator.locate(result -> {
});

However, I've dropped this idea, maybe we should consider it again.

this idea is about making the discovery in a client, so it can be controlled by the code that uses the client.
the service discovery will use this client, i.e periodically it will call the client to refresh its data and republish things in the distributed and emits events on the bus.
for other needs I just need a simple client for discovery, I don't need a shared data structure + event bus.

basically the client idea is very simple, you create a client and call it. This client wraps the DockerClient, etc... nothing more. So it is more or less a trivial refactoring of the current existing code.

I'm still confused.
Do you mean for bridges ? Instead of using a bridge, it would use a "client" ?
If this is the case, bridges are a bit more complicated than raw clients as it should detect leaving services and update the discovery service, while a client would just locate the service. So, I don't think it's a refactoring, it's a new feature, having "discovery client" that act as simple locator for a specific discovery mechanism.
If you need a client without the shared data structure + event bus, you can just have your own discovery backend that is just a map (it's actually the fallback when vert.x is not in cluster mode). However, it would only get the services directly registered on it (either explicitly or by bridges registered on this discovery service instance).

when I was looking at the code, I only looked at the docker client implementation that manages itself the removed container so I thought it was a general mechanism, but the K8S bridge uses the watch service of the K8S api. So it means indeed that the bridge manage the life cycle (i.e it watches) and cannot be a pure client.
So yes it would be more or less the ability to run bridges without the discovery service.
So we could see that as having the bridges publishing in a subset of the DiscoveryService that only does the publish/unpublish part and not the rest.

I think we can improve the bridge API to be much easier to implement and avoid duplication.
There are 3 types of discovery (the type depends on the underlying discovery infrastructure):

static discovery - a bridge implementing such kind of discovery that would publish a set of services in its start method and unpublish it in the stop method. Implementations would have a single method: List<Record> get();
periodic discovery - a bridge that periodically scans something and adapts the set of record based on the scan result. Implementations would have a single method: List<Record> get() that it periodically called. The caller (that need to be determined) would keep track of the returned records to unpublish the ones that are gone, publish the new ones... On stop all imported services are withdrawn.
dynamic discovery - a bridge using a listener ability of the discovery technology that notify it when services are published or withdrawn.

my point is to decouple the bridge from the ServiceDiscovery interface that provides several concerns and only keep part used by the bridge which is publish/unpublish.

oh you mean not registering the bridge on the discovery service but initialize the bridge with a discovery service instance ?
Instead of:
DiscoveryService.create().registerBridge(....);

Doing something like:
DiscoveryService svc = ....
ConsulBridge bridge = ConsulBridge.create(svc, conf);

right now it's made like that because there is a link between the discovery service lifecycle and bridge lifecycle.

the second but you replace DiscoveryService by :
interface BrideListener {
   void publish();
   void unpublish();
}

and then the DiscoveryService expose an impl of BridgeListener to its managed bridges

That's just for importer bridge. Bridges are bi-directional (even if the second direction has not been implemented in any of the bridge for now).

oh right I see, can we split that in two interfaces that and the bridge that export use this other interface ?
so BridgeImporter / BridgeExporter

+1

Has been fixed by @vietj
closing this issue.


No file named "polymer_smiles.csv.gz" found in the folder "database"

When launching the jupyter notebook for the regression model and pretraining descriptor data from SMILES data, the file path "database/polymer_smiles.csv.gz" in the file "settings.yaml" does not exist. I think it might be "database/compounds.csv" instead.

Thanks for your comment.
I noticed that the file "database/polymer_smiles.csv.gz" was not uploaded because of the wrong setting of .gitignore.
Now, it's available in the "database" folder!

Thank you!


change(gridsome): fix missing logos

The logo_url field is optional in the yaml format, but the fact that is missing is a problem for rendering images for some plugins.
When the logo_url is not provided, we can calculate it in the graphql layer so that the pages don't need to consider this business logic while rendering the logo itself.

Here is the if/then I wrote for Search.vue. This logic on the page could be removed if we put similar logic upstream:
                <g-image
                  v-if="plugin.node.logo_url"
                  :src="
<EMAIL_ADDRESS>                      '/assets/logos/',
                      ''
                    )}`)
                  "
                />
                <g-image
                  v-else
                  :src="
<EMAIL_ADDRESS>                  "
                />

Resolved by #829


Docs: Update Linux build environment

Adding more info about Linux build environments using pyenv to readme.

@antirotor update it in the docs as well please


Add automated testing

Wooooooops, meant to PR my fork, not the upstream source, sorry about this mess 💀


test drop file

That is a good idea to have it open directly.  We would want to go through the Drop event instead of directly accessing glfw, which is not used on all platforms.

That is a good idea to have it open directly.  We would want to go through the Drop event instead of directly accessing glfw, which is not used on all platforms.

I deleted the previous way of forking the image repository to other websites, resetting the gitlab repository is too troublesome: you need the first step to sync github, the second step is to rebase to the last commit if you have a commit or lag behind your commit, in fact, it is to delete all my operations and keep it close to your last commit to solve the problem of too much difference when merging PR, The third step is to write PR code to push to gitlab, and at the same time automatically push to the github repository I fork through the gitlab image function, and the fourth step is to click the PR button... It's a hassle, and using a VPN saves half of the steps, but it's not free. The PR tests the drag-and-drop files and also tests whether the multi-person development is standardized. It's a hassle to use github fork directly for pr and sync in China, you have to use a vpn to do it, otherwise you can't access sites like github and Google, if you know of any code hosting platforms that are accessible in China and offer sync one-click reset and push mirroring for free, please let me know, I want to do this process in a simple way.

I do not know of any code hosting platforms that can do that, sorry. You don't have to go through the GitHub website for resetting your fork to the main branch; instead you can set up an upstream remote and fetch from that, but I'm not sure whether that would be any better, as you would still be going through the GitHub servers.

I do not know of any code hosting platforms that can do that, sorry. You don't have to go through the GitHub website for resetting your fork to the main branch; instead you can set up an upstream remote and fetch from that, but I'm not sure whether that would be any better, as you would still be going through the GitHub servers.

Let's use the VPN method first, the other methods are too cumbersome

I do not know of any code hosting platforms that can do that, sorry. You don't have to go through the GitHub website for resetting your fork to the main branch; instead you can set up an upstream remote and fetch from that, but I'm not sure whether that would be any better, as you would still be going through the GitHub servers.

The other way is for you to maintain a real-time synchronization of the GitHub-to-Gitlab repository, but this adds complexity to your work and is not worth it. It is accessible in China gitlab.com but not github.com and Google.com etc.

You shouldn't sync your fork when you have an active PR because it resets it. As long as you sync your fork every time before you start a PR, you should be fine and we shouldn't have merge conflicts.


Add iPhone 14, 14 Plus, 14 Pro and 14 Pro Max

https://www.apple.com/iphone-14/
https://www.apple.com/iphone-14-pro/

Duplicate #1552


chore Fix the db name of the restored view

Previously, during restore, the database name in the CREATE VIEW statement was not modified, causing the restored view to be unviewable with the SHOW VIEW command. This PR retains the original cluster's database name in the BackupMeta and manually replaces it with the new cluster's database name in the CREATE VIEW statement during restore.

run buildall

run buildall

run buildall


Allow single NOT operator in Table Query

Addresses issues in the query parser, specifically allowing a single NOT operator.
Updates the unit and integration tests
Fixes: #1828

@EmmaZhu
@XiaoningLiu
please take a look once you get some time. Thank you.


Version incompatibility with typing_extensions.deprecated.

Describe the Bug
The latest version imports typing_extensions.deprecated, which was added in v4.5. Pyproject.toml only requires version >=4.1.
.venv/lib/python3.11/site-packages/strawberry/types/types.py:16: in <module>
    from typing_extensions import Self, deprecated
E   ImportError: cannot import name 'deprecated' from 'typing_extensions'

System Information

Operating system: any
Strawberry version (if applicable): 0.187.0

thanks! I'll bump the requirement now 😊


Remove use of nwb build tool

Closes #93 - Move away from nwb, the magical build tool.

Add npm keywords for users to find the package more easily
Replace nwb with webpack and babel
Use two separate webpack configs for demo vs. actual component
Move devDependencies where they belong
Remove the unused react-highlight.js package

@dharness Can you have a good look? I'm not entirely confident about this.

@heatherbooker there's got to be a way to publish from a branch to npm and see if we can install it - that would give me a lot more confidence

This is nice 👍 I'm going to have to checkout and try it to confirm it all works though

there's got to be a way to publish from a branch to npm and see if we can install it - that would give me a lot more confidence

Yeah eh? Agreed. Maybe npm pack, scroll down here? https://medium.com/@vcarl/problems-with-npm-link-and-an-alternative-4dbdd3e66811

@dharness Could you check this one out again?


Refactor mock engine support with strategies

This is currently supporting PHPUnit and Prophecy.

Sure! I have to complete the work on stub return values, and we should also think if we want to provide specific traits for each strategy.

Please, @xzhavilla review my updates on README.md. I think we should now push the fact that we support multiple generator engines. Do you agree?


Gmail::Label.all hangs when you have lots of labels

For some reason I'm getting a hang on the label.all method I only have 150 or so labels, so not sure that should be hanging...

However,
Gmail.request(Gmail::Label.base_method.send("list"))
(Is there a better way of doing that request there, I sort of feel like I'm cheating).

Hi Carpela,
I made you contributors on this gem as you're contributing a lot and I don't really have time to improve it myself.
Thanks for the help.


tracing: Move custom-tag application after common tags

resolves  https://github.com/envoyproxy/envoy/issues/20635.
I can't imagine this matters, but when compiling I had to use bazel build source/exe:envoy --define=wasm=disabled to get it running on my M1 Max processor (thanks @keith!). I don't think this would make the code/testing less comprehensive, but figured I'd let reviewers know

Commit Message: Ensure that configurable custom_tags are applied after the common tags. This guarantees that user configuration takes precedence over the hard-coded tags that envoy sets automatically in setCommonTags
Additional Description: n/a
Risk Level: Low
Testing: Unit testing
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:] n/a
[Optional Fixes #Issue] https://github.com/envoyproxy/envoy/issues/20635
[Optional Fixes commit #PR or SHA] n/a
[Optional Deprecated:] n/a
[Optional API Considerations:] n/a

sorry, PR is still in draft, not sure what my rebase + force-push did to tag a bunch of people 🙈

@wrowe @markdroth are you the right reviewers to be assigned to this PR, or did that happen accidentally due to my rebase flagging certain files under your domain?
if not, should we change the reviewers? cc @Shikugawa , who commented on the original issue https://github.com/envoyproxy/envoy/issues/20635

And could you check DCO signoff?

Hi, thanks for your contributions. It's LGTM. Can you check your DCO? Looks like only the latest commit lose the sign. 😄

/wait

urgh sorry thought I got the DCO, fixing now

Okay, fixed the DCO and some tests that were broken by moving request/response tags into setCommonTags. Will make sure tests are passing, but then think things are looking good

Thanks for you updates. But it seems that the tests still failed. Can you check it again?
/wait

The changes causing the failure were due to how I modified the request/response tags to be in setCommonTags, so now both upstream and downstream spans would see those emitted. Removed those changes to reduce noise in this PR and pushed things back up. Will monitor as tests run today

looks like a timeout in the envoy-presubmit job, doubt it was anything related to this PR? will push a noop commit to trigger a fresh CI run

/retest


Fix build for Bazel v0.1.2rc2 [phab:D623]

Created by schroederc at 2015-12-01 23:37:35:
In the new Bazel version, the target //external:android/sdk is expected to exist and the java_library rule has become more strict about its srcs attribute.

schroederc closed via commit 4ea99012b0d92b0f208cf9f58a4365e4b5698f79 at 2015-12-01 23:42:18


[RMP] Add Wide & Deep ranking model to Merlin Models

Problem:
A clear description of the problem and how it impacts the customer experience of Merlin users.  Why is this important?  Why/Should we prioritize this work?  Note that this is problem singular.  Please try to ensure that we're trying to solve one problem and not many.
Goal:

What are the goals of this work.
This can also include anti-goals of what this work does not include.
Ideally this takes the form of a bulleted list.

Constraints:

What are the constraints that might impact the choice of solution?
This can also include non-constraints to clarify if something that would normally be a constraint is not a consideration.
Ideally this takes the form of a bulleted list.

Starting Point:
[ ] What tasks need to be completed in order for this work to be considered complete?
[ ] This takes the form of a series of checkboxes where we can track the work.
Description of outstanding issues and questions:
https://docs.google.com/document/d/1aWNUirxAKsisEUv7fBUqWe6O1vskdRGfRpWkLJOELKQ/edit
From the discussion here, the end state of Wide&Deep should include:

One line to create the model: PR in progress
Support different optimizers for wide & deep parts
Feature crossing as part of the modeling code

Are we adding model to the ranking notebook: https://github.com/NVIDIA-Merlin/models/blob/main/examples/03-Exploring-different-models.ipynb


Production app takes longer when moving from bookmark to home icons

In production app, use the icons bar at the bottom to switch from search icon to home icon. It shows that only when moving from bookmark icon to home icon that the app takes a bit longer.
Acceptance Criteria

[ ]  moving through the icons take the same amount of time.

https://user-images.githubusercontent.com/89798867/142709196-61c05a87-5c14-4f33-b76d-0bb7e667566c.MP4
Steps for QA:

There is a small delay due to the complexity of the home page, but it's minor and not high priority to optimize at this time


Include language in the README.md about ways of using GitHub Issues

For all of the following:

Questions
Feedback
Features
Ideas
Bugs in scripts
Corrections in dictionaries
Corrections to READMEs
Style suggestions or common conventions for scripts, dictionaries, or READMEs
Anything else that isn't a code contribution or pull request

Fixed with 15f58a864f34e95938bda719f4484518f1595b02.


License

No license is provided. If others are permitted to use or contribute to this project, a LICENSE file tells them what is allowed. GitHub's Choose a License website is a good resource explaining various different options.

Thanks for bringing this up. I added a license.


No alvr window after launching

Description

After launching alvr, the steamvr window shows but there is no alvr settings window.
General Troubleshooting

[x] I carefully followed the instructions in the README and successfully completed the setup wizard
[x] I read the ALVR Wikis here and here

Environment
Hardware
https://linux-hardware.org/?probe=472a3f2707
Installation
ALVR Version:
v19
SteamVR Version:
1.24.6
Install Type:

[ ] Packaged (exe, deb, rpm, etc)
[ ] Portable (zip)
[x] Source

OS Name and Version (winver on Windows or grep PRETTY_NAME /etc/os-release on most Linux distributions):
Arch Linux

I didn't have chromium installed


Activity log event categories

This page states that "category" is used in the context of log profiles to refer to the types of actions (like Write) instead of the log entry category (like Administrative). How are the log entry categories reflected in the export procedure, though?
I don't see any place indicating the log entry category or any settings that would allow you to choose which ones are saved. Also, the presence of authorization information in the schema makes it differ a bit from some of the log entry categories, like Resource Health or Recommendation. Do all of the log event categories get exported through log profiles with the same schema, or are some categories missing?
To clarify again, I'm referring to the log entry categories that each have different schemas on the page below.
https://docs.microsoft.com/en-us/azure/azure-monitor/platform/activity-log-schema

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a5a53f9b-0235-a221-f3c8-dccb3d7109a7
Version Independent ID: cf6c67e8-1942-9eeb-2523-70c4a54b782d
Content: Export the Azure Activity Log
Content Source: articles/azure-monitor/platform/activity-log-export.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

Thanks for your comment. We are actively investigating and will get back to you shortly. Thanks for your patience.

Assigning @bwren for visibility
@bwren Please provide your insights

Forwarding to engineering team.  #in-progress

@dcbrown16 All log categories are not exported now, and you can't currently specify categories in the log profile.  There are some significant changes coming soon in this process though that we will be documenting.

We will now close this issue. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

From the documentation for upgrading Activity Log export:

Some categories are not collected using legacy method.

Which specific categories are missing from the old method? In determining whether to upgrade from the legacy experience, it seems important to know what categories are not included.


Deep links to sideloaded app do not work in some channels

We have a custom app which is manually installed by customers by publishing it in the organization's app catalog via "Manage Apps". The app is using deep links in action cards using Action.OpenUrl following the scheme as documented in https://github.com/MicrosoftDocs/msteams-docs/blob/master/msteams-platform/concepts/build-and-test/deep-links.md
https://teams.microsoft.com/l/entity/${appId}/${entityId}?label=${entityLabel}&context=${deepLinkContext}
According to the documentation, appId should be "The ID from your manifest" and this is also the value which we are using. In 95% of the cases, the created deep links work as expected and everything is fine. However, in the remaining 5%, clicking the deep links does not work at all and only reloads the Posts tab instead of opening our app's tab. A similar experience as when the tab has been removed. In our experience, if deep links work in a channel, they always work for every user - but in some channels they never work, regardless of the user creating or opening the deep link. We have not been able to identify a pattern in which channels deep links work and in which not.
However, if we do not use the app ID from the manifest but instead build the deep link using the app catalog's app ID, deep links always work - even in channels where they previously did not work using the manifest's app ID.
Our workaround is now to always use the app catalog's app ID after fetching it using the /teams/[GUID]/installedApps endpoint as described in https://github.com/microsoftgraph/microsoft-graph-docs/blob/main/api-reference/v1.0/api/team-list-installedapps.md#example-3-get-the-app-installation-resource-based-on-the-manifest-id-of-the-associated-app
It would be great if either deep links using the manifest's app ID would work 100% reliable or the documentation would be updated that the app catalog's app ID should be used.
When searching the other issues, this one could be related to the same problem: https://github.com/MicrosoftDocs/msteams-docs/issues/2552

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 45541337-ecd7-5cf6-cbe4-3f0d2f39aa79
Version Independent ID: 6b4203f0-2844-06c9-eaa3-9cc03e6f76c0
Content: Create deep links - Teams
Content Source: msteams-platform/concepts/build-and-test/deep-links.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

Hi @Robert-F - Thanks for bringing up this issue, I will repro at my end and will let you know.

@Robert-F - In tab deeplink https://teams.microsoft.com/l/entity/<appId>/<entityId>?webUrl=<entityWebUrl>&label=<entityLabel>&context=<context>,  all query parameters are properly URI encoded. Please change webUrl and context  to encoded format and let me know if you still persist the issue.

@Mamatha-MSFT Yes, all query parameters properly encoded - we only use the label and context parameters, but no webUrl. This is the relevant code:
  const entityLabel = 'AppName';
  const deepLinkContext = encodeURI(JSON.stringify({ subEntityId: userId, channelId: context.channelId }));

  return `https://teams.microsoft.com/l/entity/${appId}/${entityId}?label=${entityLabel}&context=${deepLinkContext}`;

When using the app catalog's app ID all deep links work as expected.

@Robert-F -webUrl  optional field with a fallback URL to use if the client does not support rendering the tab. Even though mentioned as optional add webUrl to your deeplink.


AriesOpenAPIDemo Docs need to be updated

The doc on this link: https://github.com/hyperledger/aries-cloudagent-python/blob/main/demo/AriesOpenAPIDemo.md is outdated. It still shows faber and alice as two agents will set up 1st connection step by step whereas the latest code shows this process can be automated when attributes "--auto-accept-invites" is enabled. Please update this doc.

I suspect that you might have omitted the --no-auto parameter as the doc prescribes.
Regardless, as of https://github.com/hyperledger/aries-cloudagent-python/pull/992, the error message notes that the connection record is not available in the invitation state, when the (RFC160) responder double-taps the accept-invitation step for a received invitation.


capitalizing cell type names during assignment

Very small changes made to these files, just to capitalize the cell types according to paper's comments.

EXP2_pseudos_pbm.ipynb: deleted unnecesary plots that showed redundant gene expression differences per cell type, not needed.
validation_processing.py: added one function to capitalize
Other notebooks: added a couple of lines to capitalize cell types using the function above.

the parameters cell is parametrized through papermill, so i gotta do it after that cell so it works through papermill

View entire conversation on ReviewNB

removed, it was for something else.

View entire conversation on ReviewNB

the parameters cell is parametrized through papermill, so i gotta do it after that cell so it works through papermill

View entire conversation on ReviewNB

nice catch

View entire conversation on ReviewNB

ah, older version of the notebook. good catch.

View entire conversation on ReviewNB

same thing, parameters are set in papermill in this cell. the os.getcwd comes after

View entire conversation on ReviewNB

ah i should have done that. once i'm adressing reviewer comments i'll add that.

View entire conversation on ReviewNB

i hypothesize it's the cytoplasmic RNA vs. only nuclear that's dirivng the difference. along with dissociation responses. but cant know for sure

View entire conversation on ReviewNB

not gonna use it but good to know

View entire conversation on ReviewNB

comments addressed, merging PR


can not  get  the  online designer when i  follow your arcitle

I follow this  https://opensource.fast-report.com/2019/07/how-to-use-online-designer-with.html
But I get someting wrong

This error is usually caused by an incorrectly specified route. Tell us more about the project, for example, what platform it is on, etc.

Hello!
You need to specify this in setupProxy.js:
const context = [
    "/Home",
    "/_fr",
    "/WebReportDesigner"
];

You also need to add Online Designer to the wwwroot of your project
and write this in the controller:
WebReport webReport = new WebReport();

webReport.Mode = WebReportMode.Designer;
webReport.Width = "1000px";
webReport.Height = "1000px";

ViewBag.WebReport = webReport;
return View();

Best regards
Marat


Feature request:  built-in "join" helper

I couldn't figure out a way to use a built-in helper to join a list of items with a delimiter.  If there is already a built-in helper or combination of built-in helpers that can do this, please let me know.  Otherwise, I suggest that you add a built-in helper called "join" that has a parameter for the delimiter.
For example, the template would contain something like this:
 {{join myArray delimiter=", "}}

I ended up registering my own helper for my immediate needs:
Handlebars.registerHelper("join", function(context, block) {
     return context.join(block.hash.delimiter);
});

This should be modified to handle cases when context is null, the context is not an array, the delimiter is null, etc.

I just did this for myself today:
Handlebars.registerHelper('join', function(val, delimiter, start, end) {
    return [].concat(val).slice(start, end).join(delimiter);
});

If val is not an array it has the effect of just returning val. The 2nd-4th parameters are entirely optional (default delimiter is ","). I've only tested on Chrome so far.

I have incorporated ceberle's suggestions:

//Handlebars "join" block helper that supports arrays of objects or strings.
//If "delimiter" is not speficified, then it defaults to ",".  You can use "start",
//and "end" to do a "slice" of the array.

Handlebars.registerHelper('join', function(items, block) {
    var delimiter = block.hash.delimiter || ",",
        start = start = block.hash.start || 0,
        len = items ? items.length : 0,
        end = block.hash.end || len,
        out = "";

        if(end > len) end = len;

    if ('function' === typeof block) {
        for (i = start; i < end; i++) {
            if (i > start) out += delimiter;
            out += block(items[i]);
            if('string' === typeof items[i])
                out += items[i];
            else
                out += block(items[i]);
        }
        return out;
    } else {
        return [].concat(items).slice(start, end).join(delimiter);
    }
});

Oops, I meant to take out one line:
//Handlebars "join" block helper that supports arrays of objects or strings.
//If "delimiter" is not speficified, then it defaults to ",".  You can use "start",
//and "end" to do a "slice" of the array.

Handlebars.registerHelper('join', function(items, block) {
    var delimiter = block.hash.delimiter || ",",
        start = start = block.hash.start || 0,
        len = items ? items.length : 0,
        end = block.hash.end || len,
        out = "";

        if(end > len) end = len;

    if ('function' === typeof block) {
        for (i = start; i < end; i++) {
            if (i > start)
                out += delimiter;
            if('string' === typeof items[i])
                out += items[i];
            else
                out += block(items[i]);
        }
        return out;
    } else {
        return [].concat(items).slice(start, end).join(delimiter);
    }
});

@jlubean: what version of handlebars are you using? I am unable to get it to work with up to beta 4.  I get the following error when using syntax like:
{{join list_of_words delimiter=","}}

The error:
Uncaught Error: Parse error on line 35:
..._of_words delimiter=","}}</tex
-----------------------^
Expecting 'STRING', 'INTEGER', 'BOOLEAN', 'ID'

I was using beta 3.  Take a look at my working example at http://jsfiddle.net/jlubean/YS3EV/

I wrote this: http://mametipsum.herokuapp.com/. I'd rather not require that people have to specify a helper like this (see the "Template" tab). I'd like to keep it simple. I'd like spaces to be the default when printing an array. I'm happy to override the default array helper, but how do I do that? Thanks.

Personally, I think Handlebars is best kept simple. If someone would like to put together a repo/gist with useful helpers then we could probably link to it or otherwise highlight it.


Deprecated HostRegexTableLoadBalancer

The HostRegexTableLoadBalancer (HRTLB) allows the user to define regular expressions (for hostname or ip) for tables. HRTLB creates groups based on these regexes, with a default group containing tservers that do not match any regex. HRTLB passes only the tservers in the table's group to the tablet load balancer when performing assignments or balancing.
In the elasticity branch we have (tserver|sserver|compactor).group properties that can be used to assign specific processes to logical groups of resources. sserver.group has existed since 2.1. compactor.queue was added in 2.1, but renamed to compactor.group in elasticity. tserver.group was created in elasticity. TableLoadBalancer was modified in elasticity to be group aware, allowing a user to configure a table to be assigned to tservers with a specific group name.
I don't know how useful HRTLB will be in an orchestrated (k8s-like) environment as tservers could be moved on-demand.


chore: add uuid supported path

Description
Use the path variable from routes that supports both mongo object ids and UUIDs of pg.
Fixes
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!WARNING]
Invalid tags. Please use /ok-to-test<EMAIL_ADDRESS>or /test all in the PR body to run all tests.
Tags documentation.
List of valid tags.
Tue, 10 Sep 2024 07:02:20 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features

Introduced new constants for viewer paths to enhance clarity in path matching.

Refactor

Simplified logic for extracting base page IDs by replacing the old constant with more descriptive ones.

/ok-to-test<EMAIL_ADDRESS>


Installation Troubles

When installing from the zip addon reports as successfully installed, but does not appear in the add-ons list.
Using Blender 2.9.1
Also, does not appear in the 2.9.1 addons folder.
It appears if you manually copy the .py to the addons folder. And it works for there on out!

I have not been able to reproduce this issue. When I choose 'install' from the Add-Ons panel of the Preferences window, it copies the .py file to the Add-Ons folder and adds it to the list in the Prefs window. Another user confirmed this process worked yesterday as well.
Can you check the permissions for the file prior to choosing install, or permissions Blender may have to write to the program folder? On Windows it may not allow editing of Program Files directories without administrator permissions. Running Blender as Administrator once may allow it to make these changes, and once installed the Add-On should work without running as admin.

I have the same problem, but copying the file into the addons directory doesn't work either. It doesn't show up in the addons list.
Tried running Blender in admin mode. file has permissions rights etc.

im getting this weird stuff if i press the wireframe button

Deadpixel can you help me out with my problem pls??

Deadpixel can you help me out with my problem pls??

I am also having the same issue tool not showing up.
tried 2.91
2.80
admin mode, install from inside blender and copying into addon folder manually.
I previously had this working fine on a previous windows install.
any help would be great


Cannot find a note - notify user, and provide hint/suggested next steps

client initiating action

client receiving or observing action (or lack thereof)
Gossip
Damus
or pretty near all other apps
timestamp
https://njump.me/nevent1qqsw4cycxsnl8xq5zwfw238slazpc8n4rvex58nrqevl8apcfsw92wgpzemhxue69uhhyetvv9ujumn0wd68ytnzv9hxgqgswaehxw309ahx7um5wgh8w6twv5q3kamnwvaz7tmrdpexjum5wp5kcmpwdehhxarjxyhxxmmdqy08wumn8ghj7en9v4j8xtnwdaehgu3wvfskuep0wphhqatvv9eqp68wj5
https://njump.me/nevent1qqsquyg3n8vtk77plrhmzhsu9wjm7kq36sxj33gzgf3nygjxhtuuggq47k2ww
what happens

sometimes notes are not found due to lack of outbox, imperfect outbox implementation, and/or limitations of outbox
various apps either
a) don't display notes
b) display stress inducing perpetually loading animations

suggestion/question
How might we design "note not found" "warning" message?
What (manual) action might the user be prompted to take in order to find the said note?
related
Damus design request: note not found https://github.com/damus-io/damus/issues/2278

@karnagebitcoin

I am not sure on a technical level what the user can do at that point.
In terms of design, I think the stress could be alleviated a bit with some lightly humorous copywriting and visual. One I had in mind:
"Oooof, it appears da moose could not find this elusive note"
This could be coupled with a cute / funny moose icon or small visual that fits to the left of the message.
In terms of what the user can do next: We could offer a link to open an area that explains why the note may not have been found. If we can't give users an action to take, perhaps just explaining it would help - and maybe within that area we can offer them to report this to developers. Despite not much that we can do, at least they can get a sense of doing something for a sense of "closure". TLDR; give them some info or something to do to feel useful.

We need:

better loading screen
more algorithms for finding notes in different ways
damoose failure screen

This is distinct from the loaded note but unknown note screen. we should definitely have that as well.

Maybe it's helpful, here's what I came up with for Nosta so far. First there's a loader, represented by an emoji and a piece of text. It gets more and more impatient the longer it takes. It gives the user feedback and emphasizes with them. Then at some point it gives up and says that it couldn't find anything.
What I haven't implemented is the "search harder" part. By default, it tries to find any relays related to the profile it's looking for (like something baked into an nprofile). It falls back to a series of default relays that I have deemed worthy. "Search harder" would then expand that to more relays, and potentially third-party service APIs that may have a broader cached index. You could also automatically search harder instead of asking the user to request it.

I recently added a "LOADING..." (I'll let the UI guys spruce that up), but what will be much harder (given how gossip is coded currently) is detecting if loading has failed (when all relays give back EOSE without the event being found).
https://github.com/mikedilger/gossip/issues/776


Delete account pops up when it shouldn't

Steps to reproduce.

Create account
Delete account
Create account

The delete account popup shows again,

fixed in 921f80dc96f14da1f2a5e1d244985d1b6e51a67c


Hi from Roboto Studio 👋

This looks awesome, we’ll be implementing it on a project fairly soon 👍

Revalidate


fix: support for non-string types in object fields

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

New Features

Enhanced handling of map-type values for improved data accuracy in search documents.
Added support for various data types (boolean, long, float, double, integer) in TestEntityInfo, expanding its functionality.

Bug Fixes

Improved type-specific value assignment to ensure correct data representation based on schema definitions.

Tests

Increased test coverage with additional assertions to validate data types in the transformed JSON objects.

Documentation

New fields in TestEntityInfo now support more complex data structures and are queryable.

@david-leifker  can you please review the above PR?

@Nbagga14 - Please rune ./gradlew spotlessApply --rerun-tasks

@david-leifker  - I have formatted the code. Could you please review? Please let me know if anything further needs to be done. Many thanks.

@vignesh-hbk - Please take a look at the CI test failures. The tests can be run with ./gradlew locally with the following arguments. Linked to the failure logs for reference if you can view them.
:entity-registry:test
:metadata-io:test

Hi @david-leifker  - We ran both these tests and they passed. Please see below screenshots. Please let me know if further actions or info is needed from me. Thanks.

@david-leifker - addressed the failing test cases and tried triggering the tests. Could you please check ? Many thanks.

Updated with latest master and still seeing failures in metadata-io:test, try running with ./gradlew :metadata-io:test --rerun-tasks
Per the failure log, these are the kinds of failures I am seeing:
metadata-io > nonsearch > com.linkedin.metadata.search.indexbuilder.MappingsBuilderTest > testMappingsBuilder FAILED
    java.lang.AssertionError: expected [22] but found [27]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:1419)
        at org.testng.Assert.assertEquals(Assert.java:1383)
        at org.testng.Assert.assertEquals(Assert.java:1429)
        at com.linkedin.metadata.search.indexbuilder.MappingsBuilderTest.testMappingsBuilder(MappingsBuilderTest.java:34)

metadata-io > nonsearch > com.linkedin.metadata.search.utils.BrowsePathUtilsTest > testGetDefaultBrowsePath STANDARD_OUT
    [Test, A, B]

metadata-io > nonsearch > com.linkedin.metadata.search.query.request.SearchQueryBuilderTest > testGetStandardFields FAILED
    java.lang.AssertionError: expected [22] but found [27]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:1419)
        at org.testng.Assert.assertEquals(Assert.java:1383)
        at org.testng.Assert.assertEquals(Assert.java:1429)
        at com.linkedin.metadata.search.query.request.SearchQueryBuilderTest.testGetStandardFields(SearchQueryBuilderTest.java:379)

metadata-io > nonsearch > com.linkedin.metadata.search.query.request.SearchQueryBuilderTest > testQueryBuilderFulltext FAILED
    java.lang.AssertionError: expected [9] but found [14]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:1419)
        at org.testng.Assert.assertEquals(Assert.java:1383)
        at org.testng.Assert.assertEquals(Assert.java:1429)
        at com.linkedin.metadata.search.query.request.SearchQueryBuilderTest.testQueryBuilderFulltext(SearchQueryBuilderTest.java:114)

metadata-io > nonsearch > com.linkedin.metadata.search.query.request.SearchQueryBuilderTest > testQueryBuilderStructured FAILED
    java.lang.AssertionError: expected [22] but found [27]
        at org.testng.Assert.fail(Assert.java:111)
        at org.testng.Assert.failNotEquals(Assert.java:1578)
        at org.testng.Assert.assertEqualsImpl(Assert.java:150)
        at org.testng.Assert.assertEquals(Assert.java:132)
        at org.testng.Assert.assertEquals(Assert.java:1419)
        at org.testng.Assert.assertEquals(Assert.java:1383)
        at org.testng.Assert.assertEquals(Assert.java:1429)
        at com.linkedin.metadata.search.query.request.SearchQueryBuilderTest.testQueryBuilderStructured(SearchQueryBuilderTest.java:212)

@david-leifker - Hi David - Took the latest changes post merge and addressed the failing changes. Please review. All of the tests seem to have passed here as well. Please review and let us know if anything further needs to be done on our end. Many thanks for you help and patience.


[release-ocm-2.9] MGMT-18332: Download rpm packages in a different stage at the build of Dockerfile-build

Download rpm packages in a different stage at the build of Dockerfile-build as golang image is based on centos 7 which cannot reach its repositories as it is EOL

/test lint test

/override ci/prow/e2e-ai-operator-ztp

/cc @pastequo @AlonaKaplan

Compared to this one https://github.com/openshift/assisted-image-service/pull/253, here we are keeping the hack file (and the associated Makefile target which isn't called anymore in prow pipeline).
Any opinion on that ?

/override ci/prow/e2e-ai-operator-ztp

thanks @pastequo

/lgtm
/approve


SunEditor: sanitizing audio/video

Using the audio and video links check the sanitizer settings

Looks like the URL was being scrubbed.  Check the sanitizer settings


Passing 404 to view() method

When We pass 404 as the third arugument to the view function, the view is not being rendered.I think that causes problem to render the custom 404 page in the laravel 5 application. Would like to Discuss.

Hmmm. This pull is wrong as it stands.

We can't return 200 OK for an error page. This looks like you've missconfigured your server.

Even If We pass 404 as the third arugument from anywhere else in the application or just return a response()->view('users.login',[],404) anywhere the same default 404 page is displayed.

I can't replicate this.

Current code is working as expected.

@rajankarthiks What exactly do you see? An empty page or the browser's default 404 page? If I remember correctly, some browsers show their default 404 page if the output sent from the server is shorter than a certain threshold. Maybe that's the problem?

I am really sorry guys.. I think it was my server problem.  When I tested it in forge it is working fine. I don't know why it didn't work even though I used homestead.


Add activity with Picture In Picture mode

It would be nice to have an example for PIP mode as well.
The documentation at https://developer.android.com/preview/features/picture-in-picture.html is not very explicit.
I tried to show a webview with a web cam stream but entering pip mode made caused full screen single color screen instead of showing the small pip.

I tried to show a webview with a web cam stream but entering pip mode made caused full screen single color screen instead of showing the small pip.

This is a known issue on Nexus Player. Are you trying with the Nexus Player? You may wish to test with the emulator at this time.
In the meantime, I'm working to get a PIP example out on the leanback sample. I'll update here when that is done.

What about the documentation is unclear? Do you have any specific suggestions that we could make to improve the docs? Thanks! :smile:

I was missing information

about the multi-window lifecycle (as I started reading at PIP page)
where/when to handle the resizing of the activity/video view.
where the onPictureInPictureChanged() is located in the lifecycle and how it is different to onConfigurationChanged()

The comments in onPause() code do not match the recommendations in the multi-window doc, i.e. "pause playback if not in PIP". In multi-window doc it is said to generally pause playback in onStop()

@friedger Thanks for the feedback. Here's how we added PIP to the leanback sample: https://github.com/googlesamples/androidtv-Leanback/commit/403d42f7c495f175a14ca6fd7f14951981b94a61.
Closing, as this should resolve your question. In the future, any PIP related questions should be directed to the Leanback sample issues: https://github.com/googlesamples/androidtv-Leanback/issues


As a user, I would like  the apply with navigation portion to show if Spanish is an available language for that navigator

https://docs.google.com/spreadsheets/d/1r8oIfRVldFr1scj3uSlE3-O9k1BlORqGYkc5liK8QjY/edit#gid=0
Add front-end so that users can see if Spanish is available
Check for accessibility

Only show a flag if they do have Spanish available.


How to setup the permissions required to execute the automated functional test orchestrator

💡 Summary
This issue describes the permissions needed to run the functional test orchestrator for each product. This is for interactive login, as well as with a service principal.
*** This is currently a work in progress. Do not execute the implementation action items below. Those are for the engineer assigned to this issue. The setup notes for setting up with a service principal are done. I'm currently working on testing and documenting the interactive login setup.
Implementation Actions
*Our goal is to assign the least permissions needed for each product.
Perform the following actions for each product (AAD, Defender, EXO, Teams, Sharepoint/OneDrive, PowerPlatform)

[ ] Create a new test user account to use for interactive login. Determine the Azure AD role necessary to run the product. This is based on the specific Cmdlets used in the functional test YAML script for that specific product. Assign the AD role to the test user and then login as the test user to ensure that the orchestrator functions.
[ ] Create a new service principal. Determine the API permissions needed by the principal to execute the Cmdlets in the YAML script. Assign the API permissions to the principal and test them. To test you must create a client certificate and then upload it as a credential inside the service principal in the AAD portal.
[ ] Document the necessary permissions for both user types in this issue.

Setup the Functional Test Orchestrator service principal and associated permissions
Go to Azure AD > App Registrations and click New registration

Enter the name "Scuba Functional Test Orchestrator"
Under Who can use this application or API select Single tenant
Click Register

Click on the API permissions page
Add the permissions listed below which are required for AAD:

Directory.Read.All
GroupMember.Read.All
Organization.Read.All
Policy.Read.All
RoleManagement.Read.Directory
User.Read.All

Setup the Functional Test Orchestrator for Interactive login and associated permissions
This section describes how to setup an AAD group and permissions in the tenant when you want users to run the test orchestrator using an interactive login (i.e. with user credentials). Setup for non-interactive login is documented in a separate section.
Go to Azure AD and create a new Group named Scuba Testers.
Group description = Users in this group have the minimum permissions to update the Scuba M365 product settings per the baselines, run ScubaGear and run the functional test orchestrator
Group type = Security
Microsoft Entra roles can be assigned to the group = Yes
Membership type = Assigned

Click on the Assigned Roles page for the new group and assign the following AAD Roles as Active assignments:

Exchange Administrator
Compliance Data Administrator
Global Reader
Teams Administrator
Power Platform Administrator
Sharepoint Administrator

Setting up a user to be able to leverage these permissions and execute the functional test orchestrator with interactive login
Click on the Members page for the Scuba Testers group
Click Add members and select the user(s) that you are onboarding to the group, then click the Select button to add them
Below shows an example where I added a couple of users to the group

Cleaning up unnecessary old permissions
In many cases the users that you add to the Scuba Testers group may have already had role assigned directly assigned to them. You should delete those direct assignments (the ones that are no longer necessary) and rely on the group role assignment for simplicity and better security management of the tenant.

Onboarding a user to be able to execute the functional test orchestrator with Interactive Login
Click on the Members page for the Scuba Testers group
Click Add members and select the user(s) that you are onboarding to the group, then click the Select button to add them
Below shows an example where I added a couple of users to the group

Cleaning up unnecessary old permissions
In many cases the users that you add to the Scuba Testers group may have already had role assigned directly assigned to them. You should delete those direct assignments (the ones that are no longer necessary) and rely on the group role assignment for simplicity and better security management of the tenant.

Onboarding a user to be able to execute the functional test orchestrator with a Service Principal
Download the user's client certificate (.cer file that contains their public key)
Go to Azure AD > App registrations
Click on the All applications tab and select the Scuba Functional Test Orchestrator application
Click on the Certificates & secrets page
For each user, click on Upload certificate, select their file and make sure to enter a Description that is unique to each user (e.g. Lacey's cert)

Guidance for helping users run the orchestrator with unique service principal parameters for each tenant
Once a user's certificate has been uploaded, the user will need to enter an AppId and Thumbprint in their Pester script file that executes the functional test orchestrator. They must change the Thumbprint value to their unique value in their certificate. You will provide them with the AppId which can be found on the Overview page in the Application (Client) ID field for the service principal.

Closed as this issue is just used for documentation reference.


replace lgtm badges by codeql badge

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.003%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5209

Relevant Lines:
5483

💛  - Coveralls


Header IDs should use same deduping as the contained anchors

For example, in https://prometheus.io/docs/introduction/comparison/, half of the links are pointing at the wrong anchor.

Also, on https://prometheus.io/docs/introduction/faq, the last link ("Why does Prometheus use a custom storage backend rather than [some other storage method]? Isn't the "one file per time series" approach killing performance?") is broken.

How is this related to the TOC? It just uses the ids defined on each heading.

@grobie Ah, didn't notice that the IDs were not properly deduped either. Only the anchors themselves are! Ok, so this is not TOC-related. Will fix title.

I'd suggest to use the full heading path, so h2 "Prometheus vs. Graphite" -> h3 "Storage" becomes #prometheus-vs-graphite-storage.

This will break existing links, but users would still end up on the same page. This change will help to provide more descriptive links in the long run though, so I'd rather do that then extend on the *-{counter} model.

Yeah, that'd be better. You still have to have deduping ontop of it just to be sure...


How to add other wallets to Web3-onbord and main panel?

our company want to add a wallet , but web3-onbord wallets list is not support yet.
dose web3-onbord support to set another wallet?
forgive my english is bad.

@crazySadSoul we have some documentation around adding a wallet here
Please let me know if this documentation suits your needs or if there is anything else I can help with. Thanks!

@Adamj1232 Hi, this document showed how to add a wallet to "injected" wallet, does web3-onbord support add to the panel like the picture show.

@Adamj1232 is this it?  i click the link of the "See here for an example of a pull request.", i saw the pull request info.
Can you guys provide a clearer documentation? Thank you~~~~~

@crazySadSoul we have some documentation around adding a wallet here Please let me know if this documentation suits your needs or if there is anything else I can help with. Thanks!

thank you ! thats clear! i see!
should i create a new branch for the new wallet and push it?

@crazySadSoul It would be best to fork the project and then create a PR when ready. Please let me know if you run into any challenges around this. I will close this issue but feel free to keep this conversation going for any support 😄

@Adamj1232 Hi， i've add the wallet in the web3-onbord of my native environment. i want to test it on my native environment. what should i do next~~~~

You can use yarn link to link projects locally - https://classic.yarnpkg.com/lang/en/docs/cli/link/
Generally you can run yarn link within the injected-wallets package of onboard and then in you app using onboard run yarn link "@web3-onboard/injected-wallets" or something close to that and you will be able to use the local instance in your app.
Alternatively you can test with the local demo project that is part of the web3-onboard app under packages/demo
To do this Just update the version of the injected-wallets package package.json and the injected-wallets package within the package/demo/package.json

@crazySadSoul you wont need to do that. The project used yarn workspaces so just bumping the version within the demo package and the injected-wallets package and running yarn will handle all that for you

@crazySadSoul you wont need to do that. The project used yarn workspaces so just bumping the version within the demo package and the injected-wallets package and running yarn will handle all that for you

Hi, i've success test the project~~~. i want to create the PR next, but i dont have the permission to push. help~~~~

@crazySadSoul you wont need to do that. The project used yarn workspaces so just bumping the version within the demo package and the injected-wallets package and running yarn will handle all that for you

Hi, i've success test the project~~~. i want to create the PR next, but i dont have the permission to push. help~~~~

@crazySadSoul you will need to fork the project and create a PR from the fork of the project rather than pushing a branch. Are you familiar with forking github projects?

@crazySadSoul you will need to fork the project and create a PR from the fork of the project rather than pushing a branch. Are you familiar with forking github projects?

ok, thanks, i see . its my first time to create pr :)

other question: why metamask dont have a package like @web3-onboard/xxx

@crazySadSoul Awesome! Glad you are creating your first PR!
MetaMask is an injected only wallet, they dont have an SDK and their team or the community has not created a MM package. A separate MM package would only add the ability to see  the MetaMask option if a wallet wasnt available and then on click would take the user to MM download

got it~~~~

@crazySadSoul Awesome! Glad you are creating your first PR! MetaMask is an injected only wallet, they dont have an SDK and their team or the community has not created a MM package. A separate MM package would only add the ability to see the MetaMask option if a wallet wasnt available and then on click would take the user to MM download

Got it~~~~


Required Fields nested inside ListBlock inside StructBlock inside StreamField missing asterisk

Issue Summary
We have a page that uses StreamField, to include a custom StructBlock, which has a ListBlock, with a CharBlock. The CharBlock cannot be null, therefore required. However, there is no indication on the page that the CharBlock field cannot be empty.  Issue on our side
Steps to Reproduce

Start a new project with wagtail start myproject
Edit home/models.py as follows...

from django.db import models

from wagtail.core.models import Page
from wagtail.core.fields import StreamField
from wagtail.core.blocks import CharBlock, ListBlock, StructBlock
from wagtail.admin.edit_handlers import StreamFieldPanel

class MyStructBlock(StructBlock):
    tags = ListBlock(CharBlock(required=True), help_text='CharBlocks missing asterisk')

class HomePage(Page):
    body = StreamField([
        ('thing', MyStructBlock())
    ])

    content_panels = Page.content_panels + [
        StreamFieldPanel('body'),
    ]

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?
Seems to be similar to #5983

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: (yes / no)
Yes

Technical details

Python version: Run python --version. 3.6 -> 3.9
Django version: Look in your requirements.txt, or run pip show django | grep Version. 2.2 -> 3.2
Wagtail version: Look at the bottom of the Settings menu in the Wagtail admin, or run pip show wagtail | grep Version:. 2.13 -> 2.15.4
Browser version: You can use https://www.whatsmybrowser.org/ to find this out. Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.102 Safari/537.36

Thank you for the report @jslay-excella! It was so clear-cut that none of us replied 😅
This should be fixed as of #9319, to be released in Wagtail 4.1.

I had to re-read all of it to remember what it was even about :P
Thanks!


DefiniteInitialization: correctly handle implicit closures in initializers of derived classes.

Support for implicit closures was already added in https://github.com/apple/swift/pull/35276:
    init() {
      bool_member1 = false
      bool_member2 = false || bool_member1 // implicit closure
    }

But this didn't work for initializers of derived classes.
rdar://66420045

@swift-ci test

Build failed
Swift Test OS X Platform
Git Sha - a263263f9e9beb499488676afa3aae1193383a88

@swift-ci test macOS

@swift-ci test macOS


[Bug]: fix typo in documentation

Tremor Version
3.6.1
Link to minimal reproduction
https://www.tremor.so/docs/components/daterangepicker
Steps to reproduce

What is expected?
The value or defaultValue for MultiSelect component should be of type array string [] instead of string.
What is actually happening?
Now the doc shows string type. This may create unnecessary misunderstandings.
What browsers are you seeing the problem on?
Chrome
Any additional comments?
No response

Thanks for catching this!

Thanks for the prompt action and reply. However, as I'm checking the doc today, it doesn't get completely corrected.

For the defaultValue, we should give Values: E.g. ["1", "2"]
For the value, we should give Type: string[] and  Values: E.g. ["1", "2"]
They are just minor typos anyway. Really thanks for your efforts!


Improve containers to use slots

If I understood the idea correctly, containers should have:

A number of fixed items, comparable to an ORM Model like peewee for example
These Items should have read-only metadata and defaults
It should not possible to create new instance members

This was currently implemented by raising an error in __setitem__, if the key was not a class member.
It involved a lot of look ups in the instance and class __dict__s.
I think I found a more concise way to do it, using a metaclass setting __slots__.
Instances of Item will be added to the __slots__ along with a meta dictionary for the metadata.
Every other class variable will become a read only class instance.
This is meant as a proposal and as bases for further discussion ;)
Let me know your ideas on this.
Working further on the Idea that a Container should be like a ORM Model, I think one should start to subclass Item to do static typing, which will help in the serialisation.
So, for instance introduce FloatItem, DoubleItem, StringItem, DateTimeItem etc.

Thanks, this does look good. I originally tried doing it with __slots__ in fact, but couldn't quite figure out how to do it correctly.  This is much cleaner.

also +1 for implementing it as a metaclass (which is how it should have been done from the start)

I'm actually happy to merge this in now, but I can wait if you want to keep this open and also implement the Item subclasses (or that can be a separate PR)

By the way, I'm thinking of dropping/refactoring the Serializer and Writer classes and implementing them more like TableWriter (with a common base class), since it follows the actual use cases better and has features like preservation of units and column transforms, etc, so don't worry about breaking them (TableWriter/TableReader and subclasses should still work however)

it occurs to me that using descriptors (e.g. http://nbviewer.jupyter.org/urls/gist.github.com/ChrisBeaumont/5758381/raw/descriptor_writeup.ipynb)  might be a good way to implement the Item sub-classes.  In any case, I'll merge this change in now, and you can look into improving the Items separately.


Integrated Terminal is slow when wrapping very long line

VSCode Version: 1.47.1 & 1.48.0-insider
OS Version: Windows NT x64 10.0.19042

Steps to Reproduce:

generate a long line in terminal, exemple (javascript):

let data = [];
for (let i = 0; i<20000; i++) {
    data.push(Math.floor(Math.random() * 16).toString(16));
}
console.log(data.join(''));

observe how slow it is (scrolling up into the middle of the text makes it even worse)

This issue appears with --disable-extensions also with --disable-gpu or with any choice of terminal.integrated.rendererType.
This issue is independent of the shell (powershell, cmd, wsl.... all have the issue)
VsCode also freezes when the terminal freezes (If the line is very long, it might trigger notification to "kill or wait vscode")
During the freeze, CPU is at around 10% (high considering there are 8/16 cores), GPU at 0%
Keeping the terminal visible (without any changes in its content) makes VSCode slow. The more of the lines is displayed, but also the longer the text is (outside of the visible area), the slower it gets.
Hiding the terminal by switching to another one restore the UI responsiveness to the normal.
I suspect this is related to the computation of the line wrap.

+1 same exact issue here, any very long line printed to the integrated terminal sends 1 thread to 100% and locks up the entire IDE.

/duplicate https://github.com/microsoft/vscode/issues/74620

@Noh3choo you might be using the dom renderer, try this setting "terminal.integrated.rendererType": "experimentalWebgl"

@Tyriar, it is still failing with "terminal.integrated.rendererType": "experimentalWebgl"

@crystalin your issue is likely the Windows-specific https://github.com/microsoft/vscode/issues/74620

@crystalin your issue is likely the Windows-specific #74620

I don’t think it is, this is a recent regression and not a duplicate.
I am not using the DOM renderer and setting experimentalWebgl has not affect on the bug.

@Noh3choo on Linux if you have problems scrolling, it's renderer related. You can try launching with --disable-gpu, changing the renderer or updating your gpu drivers. Your issue is different to @crystalin's.

Thanks Tyriar,
I have tried all of your suggestions and none change the behavior.


Custom error with position

I have complex struct with custom serde::Deserialize.
In its implementation sometime I return custom error (E::custom("error text")),
The problem is that the error does not show where in the file it occurred:
Error { inner: ErrorInner { kind: Custom, line: None, col: 0, message: "error text", ... } }
There way to create error from current position of deserializer?

This isn't currently possible, but I'd be totally down for creating a method to do so!

Maintenance of this crate has moved to the https://github.com/toml-rs/toml repo.  As a heads up, we plan to move toml to be on top of toml_edit, see https://github.com/toml-rs/toml/issues/340.
Closing this out.  If this is still a problem, feel free to recreate this issue in the new repo.


Make 1.19 version of Create mod and Flywheel

Dear Create mod,
Please make a 1.19 version of Flywheel and Create.

This isn't what this is for.  It's for reporting bugs.  Not bugging the mod authors.
I've got a tip for you.  It's considered rude to bug developers about updates to their mod.  This is a hobby project and they will release an update when it's ready.  It's not like they didn't know Minecraft got an update.


feat(dropdown): update style vue3

PR Title
:hammer_and_wrench: Type Of Change

[ ] Fix
[x] Feature
[ ] Refactoring
[ ] Documentation

:book: Description
Style updates to Dropdown, and one minor update to List item
:bulb: Context
Dialtone 7 style uptake
:pencil: Checklist

[x] I have reviewed my changes
[ ] I have added tests
[ ] I have added all relevant documentation
[x] I have validated components with a screen reader
[x] I have validated components keyboard navigation
[x] I have considered the performance impact of my change
[x] I have checked that my change did not significantly increase bundle size
[ ] I am exporting any new components or constants in the index.js in the component directory
[ ] I am exporting any new components or constants in the index.js in the root

:camera: Screenshots / GIFs

@braddialpad, @josedialpad This is my first time PR'ing to Vue, so I think I did it correctly between Vue2 and Vue3.

Hmm seems like this is missing a lot from the vue 2 PR. Only 3 files changed vs 9 in the vue 2. Looks like you maybe only brought in 1 commit?

@braddialpad

...only 3 files changed vs 9 in the vue 2. Looks like you maybe only brought in 1 commit?

🤷♂ idk


why markdown2 rather than markdown

Hi, I'm in the process of packaging this library for Debian (see https://bugs.debian.org/843882).
I noticed that ramlfications depends on markdown2 (https://pypi.python.org/pypi/markdown2, https://github.com/trentm/python-markdown2) rather than markdown (https://pypi.python.org/pypi/Markdown, https://github.com/waylan/Python-Markdown).
It turns out that only the latter is packaged in Debian (https://packages.qa.debian.org/p/python-markdown.html). There are three solutions:

I patch ramlfications to depend on markdown only for the purpose of Debian packaging
you change ramlfications to depend on markdown
we package markdown2 in Debian as well (why not if there's a good reason).

ATM I took option 1, it was easy: https://gitlab.com/simevo/python-ramlfications/blob/master/debian/patches/0000-markdown2.diff. The only side-effect is that some tests fail for some silly newlines (which is also easy to patch: https://gitlab.com/simevo/python-ramlfications/blob/master/debian/patches/0001-test_newlines.diff).
Is there any specific reason why you depend on markdown2 rather than markdown?

Bump ?


Support Summerset Isles

When and if you get around to it, remember that there are actually 3 worlds, Summerset, Artaeum and Sheo (weather is monsoon and no sun for Sheo)

Done.


⚠ Bofrost.at has degraded performance

In f06c8c9, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1315 ms

Resolved: Bofrost.at performance has improved in 16b815e.


use netty as http client, out of memory when run with big payload

Our application use netty as http client, and run in kubernetes platform.
The application works fine with small payload, like less than 10K. This has been tested for 72h and no out of memory issue.
But when we test with big payload, 200tps and 1M payload, OOM occur after several hours.
We test with leak detection level paranoid, and no error was found.
We enable NMT, and the part that can track with NMT seems normal.
We have try the following, and the memory issue is gone:

disable direct memory by -Dio.netty.allocator.numDirectArenas=0 -Dio.netty.noPreferDirect=true
rebuild the image with native library excluded, such as netty-transport-native-epoll
add environment variable MALLOC_ARENA_MAX=1

Any clue of what is causing the issue?
Or tools/guides to identify the root cause？
Thanks.
# jvm parameters
4Gi memory is assigned to the container, both request and limit set to 4Gi.

-XX:MinTLABSize=4096 -XX:+UnlockDiagnosticVMOptions -XX:GuaranteedSafepointInterval=0
-XX:+UseCountedLoopSafepoints -XX:-UseBiasedLocking -XX:MetaspaceSize=256m
-XX:MaxMetaspaceSize=512m -XX:+PrintFlagsFinal -XX:+PrintCommandLineFlags
-XX:-OmitStackTraceInFastThrow -XX:+CrashOnOutOfMemoryError -XX:+DebugNonSafepoints
-XX:InitialRAMPercentage=70.000000 -XX:MinRAMPercentage=50.000000 -XX:MaxRAMPercentage=70.000000

# We use PooledByteBufAllocator.DEFAULT allocator
content = PooledByteBufAllocator.DEFAULT.buffer(available);

Native Memory Tracking:

Total: reserved=4425712KB, committed=3418588KB
-                 Java Heap (reserved=2936832KB, committed=2936832KB)
                            (mmap: reserved=2936832KB, committed=2936832KB)

-                     Class (reserved=608747KB, committed=102123KB)
                            (classes #15939)
                            (  instance classes #14880, array classes #1059)
                            (malloc=2539KB #49899)
                            (mmap: reserved=606208KB, committed=99584KB)
                            (  Metadata:   )
                            (    reserved=90112KB, committed=88320KB)
                            (    used=86554KB)
                            (    free=1766KB)
                            (    waste=0KB =0.00%)
                            (  Class space:)
                            (    reserved=516096KB, committed=11264KB)
                            (    used=10223KB)
                            (    free=1041KB)
                            (    waste=0KB =0.00%)

-                    Thread (reserved=369000KB, committed=48392KB)
                            (thread #358)
                            (stack: reserved=367992KB, committed=47384KB)
                            (malloc=590KB #2150)
                            (arena=418KB #714)

-                      Code (reserved=251970KB, committed=72078KB)
                            (malloc=4282KB #17460)
                            (mmap: reserved=247688KB, committed=67796KB)

-                        GC (reserved=161090KB, committed=161090KB)
                            (malloc=18954KB #50940)
                            (mmap: reserved=142136KB, committed=142136KB)

-                  Compiler (reserved=2585KB, committed=2585KB)
                            (malloc=2453KB #1877)
                            (arena=133KB #5)

-                  Internal (reserved=27618KB, committed=27618KB)
                            (malloc=27586KB #5724)
                            (mmap: reserved=32KB, committed=32KB)

-                     Other (reserved=40386KB, committed=40386KB)
                            (malloc=40386KB #4057)

-                    Symbol (reserved=20344KB, committed=20344KB)
                            (malloc=17332KB #220741)
                            (arena=3013KB #1)

-    Native Memory Tracking (reserved=6320KB, committed=6320KB)
                            (malloc=575KB #8136)
                            (tracking overhead=5745KB)

-               Arena Chunk (reserved=188KB, committed=188KB)
                            (malloc=188KB)

-                   Logging (reserved=4KB, committed=4KB)
                            (malloc=4KB #189)

-                 Arguments (reserved=21KB, committed=21KB)
                            (malloc=21KB #576)

-                    Module (reserved=262KB, committed=262KB)
                            (malloc=262KB #2383)

-              Synchronizer (reserved=336KB, committed=336KB)
                            (malloc=336KB #2724)

-                 Safepoint (reserved=8KB, committed=8KB)
                            (mmap: reserved=8KB, committed=8KB)

Attaching to process ID 14, please wait...
Debugger attached successfully.
Server compiler detected.
JVM version is 11.0.18+0-suse-150<IP_ADDRESS>-x8664

using thread-local object allocation.
Garbage-First (G1) GC with 2 thread(s)

Heap Configuration:
   MinHeapFreeRatio         = 40
   MaxHeapFreeRatio         = 70
   MaxHeapSize              =<PHONE_NUMBER> (2868.0MB)
   NewSize                  = 1363144 (1.2999954223632812MB)
   MaxNewSize               =<PHONE_NUMBER> (1720.0MB)
   OldSize                  = 5452592 (5.1999969482421875MB)
   NewRatio                 = 2
   SurvivorRatio            = 8
   MetaspaceSize            = 268435456 (256.0MB)
   CompressedClassSpaceSize = 528482304 (504.0MB)
   MaxMetaspaceSize         = 536870912 (512.0MB)
   G1HeapRegionSize         = 1048576 (1.0MB)

Heap Usage:
G1 Heap:
   regions  = 2868
   capacity =<PHONE_NUMBER> (2868.0MB)
   used     = 715865928<PHONE_NUMBER>239258MB)
   free     =<PHONE_NUMBER> (2185.297050476074MB)
   23.80414747294023% used
G1 Young Generation:
Eden Space:
   regions  = 13
   capacity = 211812352 (202.0MB)
   used     = 13631488 (13.0MB)
   free     = 198180864 (189.0MB)
   6.435643564356436% used
Survivor Space:
   regions  = 1
   capacity = 1048576 (1.0MB)
   used     = 1048576 (1.0MB)
   free     = 0 (0.0MB)
   100.0% used
G1 Old Generation:
   regions  = 673
   capacity =<PHONE_NUMBER> (2665.0MB)
   used     = 701185864<PHONE_NUMBER>239258MB)
   free     =<PHONE_NUMBER> (1996.2970504760742MB)
   25.09204313410603% used

USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root        14  145 12.2 8683040 4041576 ?     Sl   Nov21 1375:17 java

Netty version
Try both netty 4.1.89 and 4.1.101
JVM version (e.g. java -version)
Try both openjdk 11.0.18 and 17.0.9
java -version
openjdk version "11.0.18" 2023-01-17
OpenJDK Runtime Environment (build 11.0.18+0-suse-150<IP_ADDRESS>-x8664)
OpenJDK 64-Bit Server VM (build 11.0.18+0-suse-150<IP_ADDRESS>-x8664, mixed mode)
OS version (e.g. uname -a)
Linux 5.14.21-150400.24.63-default #1 SMP PREEMPT_DYNAMIC Tue May 2 15:49:04 UTC 2023 (fd0cc4f) x86_64 x86_64 x86_64 GNU/Linux

can you show your pipeline,or JVM heap dump Analysis！i have oom too! and i used ChunkedWriteHandler ,ChunkedWriteHandler.queue make oom. then i update netty version to 4.1.108.Final ,in this version overwrite write()! so show your  JVM heap dump Analysis!

can you show your pipeline,or JVM heap dump Analysis！i have oom too! and i used ChunkedWriteHandler ,ChunkedWriteHandler.queue make oom. then i update netty version to 4.1.108.Final ,in this version overwrite write()! so show your JVM heap dump Analysis!

Heap dump doesn't show any leaks. Our app use netty native library also, and our issue is related to direct memory managed by glibc. Solve this by add environment variable MALLOC_ARENA_MAX=2. Doesn't know what exactly causes this.

The reason for that is that likely 1 MB is not using the pooled allocation, and just relies on malloc/free. In this case you can either tune Netty to still use pooled allocations there or replace the glibc allocator with jemalloc which is usually better at non fragmenting, new/free on different threads and sizing thread locals arenas.
You can easily track what is going on (with glibc)  by using async profiler -e mprotect or using the jemalloc profiler.


Update macOS build instructions with gRPC specifics

The macOS build instructions do not mention/link to how to install the gRPC dependencies.
The "default" CMake command should also include -DBOND_ENABLE_GRPC=FALSE to make getting a successful build more likely.

Given that Bond-over-gRPC is being deprecated and removed, I'm going to close this as "Won't Fix"


Teensy 3.5 and 3.6 support

The loader does not seem to recognize the new 3.6. Would you be able to support it with this great utility?

The Teensy Loader in the Teensyduino 1.30 works with Teensy 3.5 and Teensy 3.6 boards.
TyQt supports them too in the dev builds: https://bintray.com/koromix/ty/ty#files (TyQt-0.7.5-210-g00e62b8 is the most recent at this time). These builds are just as stable as the released versions.

The 0.8.0 release should work with the new Teensy models. I'm closing this bug.


Type checking regression

How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
Which OS are you using?
Linux
What is the issue affecting?
Type Checking
Expected Behaviour
It seems to be a regression, as it worked just fine a few weeks ago.
The parameters I used should be accepted.
Actual Behaviour

Reproduction steps
Try something like this:
---@class some_thing
---@field test string|string[]

---@param s some_thing
function test(s)
end

test({test = {"dd"}})

Additional Notes
None
Log File
file.log

I cannot reproduce this with your example code.

Here is the exact code I used:
---@meta

---@class craft_recipe
---@field type '"shaped"'|'"shapeless"'|'"toolrepair"'|'"cooking"'|'"fuel"'
---@field output string
---@field recipe string|string[]|string[][]
---@field replacements string[][]
---@field additional_wear number
---@field cooktime number
---@field burntime number

---Register a craft recipe
---@param recipe craft_recipe
function minetest.register_craft(recipe) end

The example code should be:
---@type string|string[]|string[][]
local t = {{'a'}}

:+1::+1::+1:


Remove ocaml-extlib from .gitmodules and nix dependencies

Remove ocaml-extlib from two places where it was missed. CC @Firobe

Ah, well spotted!


Gate WebAssembly validation behind a new 'validate' feature

This commit moves all of the validation logic of wasmparser behind a new Cargo features named validate. This cuts down the dependency tree for users who only need to parse wasm files. For example wasmprinter doesn't need to validate, it only needs to parse.
Closes #1528

cc @Robbepop this'll likely cause conflicts with https://github.com/bytecodealliance/wasm-tools/pull/1521, but I can help rebase too


Define a version regex

This came up in https://github.com/matrix-org/complement/pull/260, while defining a strict regex for validating /versions responses with, it became clear that that is more a spec issue.
The regex in question is;
^(v[1-9]\d*\.\d+|r0\.\d\.\d)$
A bit more exploded;
Matches;
 - v1^.*
   where 1^ is 1 through 9 for the first digit, then any digit thereafter,
   and * is any single or multiple of digits
 - r0.?.?
   where ? is any single digit

(
  # v1^.*
  v[1-9]\d*
    \.
    \d+
  # r0.?.?
  |r0
    \.
    \d
    \.
    \d
)

(Regexr link)
Would this regex satisfy all historical and future version notations?

Support questions like this are best asked in rooms.
The versions are specified as follows:
rX: https://github.com/matrix-org/matrix-doc/blob/client_server/r0.6.1/specification/index.rst#specification-versions
vX: https://spec.matrix.org/v1.1/#specification-versions


Only show "The internet connection appears to be offline" message when relevant

When using VS Code while not connected to the internet (eg. while traveling), the message stating The internet connection appears to be offline quickly becomes an annoyance.
This message ought to only appear when the user actively performs an action which requires an internet connection, for example searching the extension marketplace. Alternatively, it could be replaced with a small icon in the status bar that's much more subtle.

VSCode Version: 1.10.2
OS Version: macOS 10.12.3

Steps to Reproduce:

Disconnect from the internet
Launch VS Code

#21601


Page number progression indicator (reflow and fixed layout)

Was this feature added ?

@mahag  Not yet.  It is a remarkably complex feature.  Are you interested in working on it?

At Bibliotheca, I took the approach generally recommended by Adobe -- For each section of the book, determine the number of bytes (this is generally available if the book is in an unexploded epub format).  We then said that a "page" is approximately 2K bytes.  We divided the number of bytes in a chapter by our page size, rounding up.  This gives you a page count (almost completely arbitrary, of course; it works well for pages that are almost entirely text, but not so well for pages that are mostly images, as you can imagine).
So, before any content is loaded into the viewer, we know how many "pages" a particular section has.  Once the section is loaded into the view, we know how many columns readium takes to display that section; a little math helps break (or group) individual columns up into pages.
So if you're looking at a text-heavy section on a large-screen browser, you may view several "pages" all at once (that is, you might have 6K bytes of text on the screen, so that would be 3 "pages".  If you have a lot of images, you might get just a few hundred bytes of text on a screen; in that case a single "page" may span several screenfuls.
It's not perfect, but it's pretty close to whatever Adobe is using; and it doesn't require the entire book to be loaded into readium -- in fact, you can assign pages to sections without loading any content at all.


Refactor help component in basics example to maintain consistency

💥 Proposal
All React components in the basics example template are class components except for Help. Can we refactor the Help component into a class component to maintain consistency throughout all of the components? I'm not sure if there was a specific reason behind using a functional component there, but if not, I don't see why refactoring it into a class component will hurt. I can send a PR if this seems like a reasonable fix.
Have you read the Contributing Guidelines on issues?
Yes

In fact we want to encourage using functional components instead of classes as you can use hooks in them. So we'd wanna go the opposite direction instead.

@yangshun Would you want to migrate all of the components to functional components? If so I could work on this :)

Are you talking about v1 or v2? Sure but let's do one component at a time

It's up to you, but I can start on v1.

Almost all the v2 code is using functional components already.
Not sure it's really worth to convert v1, as we are in maintainance mode and want to move all users to v2 soon.

Yeah I'd say not to bother with v1 code anymore.


Bump to ruby-2.5.1

Trello card

@barrucadu I think we may as well just temporarily disable simplecov until the bug is fixed, and I've put this change in https://github.com/alphagov/publisher/pull/885


Add new Joystick

Refactored some UI elements to improve design
Updated package name to reflect new product name
Added new joystick in manual screen, will be improved in the future once speed control is added

Currently there is an issue where part of the circle is cut off when you move the joystick too high or low. I think this is an issue with the positioning of the elements, and should be fixed when the manual screen is updated again, with the new design.

I agree with Irina about removing unused code. We can always check history if we want to bring something back. I think a good idea would be that; If we comment something out then we have to also make a comment about why it should still be in the code. 🤔
I don't get the issue where the joystick is cutting of btw. Looks great! 💪🏻


gio: correctly free argument list items

Correctly free items from ArgumentList.
Extend tests a bit.
Fix #1330

The Windows test failure looks relevant:
---- subclass::application::tests::test_simple_application stdout ----
thread 'subclass::application::tests::test_simple_application' panicked at gio\src\subclass\application.rs:422:17:
assertion `left == right` failed
  left: ["D:\\a\\gtk-rs-core\\gtk-rs-core\\target\\debug\\deps\\gio-0cfcd1b38448b701.exe"]
 right: ["--global-1", "--global-2"]

Huh? There must be something fundamentally different how arguments are handled in windows, right? Or is the test setup just platform dependent?

I don't know, it seems very strange that the explicitly passed arguments get dropped and instead argv[0] is passed through (which is not passed by the test at all!).
It's a bug (or feature?) in GLib though: https://gitlab.gnome.org/GNOME/glib/-/blob/e64a93269d09302d7a4facbc164b7fe9c2ad0836/gio/gapplication.c#L2605
This originally comes from https://gitlab.gnome.org/GNOME/glib/-/commit/e5f91951a132b4a7daa848887a87ba22f96568bc.
This seems very unexpected but is documented:
Note that on Windows, argc and argv are ignored, and g_win32_get_command_line() is called internally (for proper support of Unicode commandline arguments).

Can you special case this in the test for Windows for now, i.e. skip the test on Windows with a comment about the above?

Hope the cfg attrs are correct, I don't have windows machine to test on.

I don't have windows machine to test on

Me neither, that's why we have CI :rofl:


feat(core): implement auto-flush mode

WIP
Closes #2359

Codecov Report

Merging #2491 (dd0a27c) into master (84b5d1b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2491   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          190       190
  Lines        10869     10923   +54
  Branches      2486      2493    +7
=========================================
+ Hits         10869     10923   +54

Impacted Files
Coverage Δ

packages/core/src/drivers/IDatabaseDriver.ts
100.00% <ø> (ø)

packages/core/src/enums.ts
100.00% <ø> (ø)

packages/core/src/typings.ts
100.00% <ø> (ø)

packages/core/src/EntityManager.ts
100.00% <100.00%> (ø)

packages/core/src/entity/BaseEntity.ts
100.00% <100.00%> (ø)

packages/core/src/entity/EntityFactory.ts
100.00% <100.00%> (ø)

packages/core/src/entity/EntityHelper.ts
100.00% <100.00%> (ø)

packages/core/src/entity/WrappedEntity.ts
100.00% <100.00%> (ø)

packages/core/src/unit-of-work/UnitOfWork.ts
100.00% <100.00%> (ø)

packages/core/src/utils/Configuration.ts
100.00% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b5d1b...dd0a27c. Read the comment docs.


Rename to helix-dispatch

Fixes #58

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #70   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         141    141
=====================================
  Hits          141    141

Impacted Files
Coverage Δ

src/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb6ff0...35f5cf6. Read the comment docs.


Put the all the details in the JIRA ticket in one code block

For the alerts that are collecting lots of information from the index it is hard to read the details.
It would be good to have the ticket details listing the match values to be wrapped with {code:json} block.

@Qmando suggested this may be already done in scope of https://github.com/Yelp/elastalert/pull/114

I have added this functionality to https://github.com/Yelp/elastalert/pull/114.

This was merged by @Qmando in #114.


Improves Generate Prompt & Add Examples

echo "${TITLE}"
This PR aims to improve the efficacy of the generate command by improving the prompt being used, as well as introduce more examples.
This PR also implements the ability to write to the disk. copilot-ops will attempt to extract a filename if OpenAI provided one, otherwise it will save to a pre-determined filename: generate-by-copilot-ops/generated-by-copilot-ops.yaml

@guymguym The requested changes have been addressed in #31


Update tagging

What is the problem / what does the code in this PR do

Fix issue #369, let ajax log
Be consistent with https://github.com/XENONnT/nodiaq/pull/10

Can you briefly describe how it works?
We need to agree which people and how can delete bad (abandoned) data.

@darrylmasson converting this PR to a draft until we get the green light on the website-side


fix precedence of 'is' operator

The following code should work without the parens around the 'is' operator in the assert function,
load "io".
load "util".

class A with

    data x.
    data y.

    function __init__
      with self, a, b do
        let self@x = a.
        let self@y = b.
      orwith self do
        let self@x = 1.
        let self@y = 2.
      end function
    end class

let obj1 = A("hello","world").
print obj1.
let obj2 = A(none).
print obj2.

assert((obj1@x is "hello") and (obj1@y is "world")).
assert((obj2@x is 1) and (obj2@y is 2)).

This is simpler code that proves the point:
structure A with
    data a.
    data b.
    end

let a = A(1,2).
assert(a @a is 1 and a @b is 2).

I think this has to stay this way -- that is the 'is' operator has to have a lower precedence that any other operator so that we can write patterns in a very natural way as right operand to 'is' without parentheses.

on second thought perhaps the right thing to do is to have the 'is' operator at a higher precedence level that the logical operators but at a lower precedence than all the other operators that still would allow you to write patterns in a natural way but also would allow you to combine multiple 'is' expressions into a single logical expression without using parens.

Nope...after looking at this some more the 'is' operator needs to be parenthesized when used in and conjunction or disjunction otherwise we loose the ability to write patterns in a natural way.