Safer parse_str() usage

Description of the change
parse_str() reports warning if parsed items exceeded over thanmax_input_vars. Rollbar Logger logs this internal error instead of user errors.
Type of change

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance
[ ] New release

Related issues
None
Checklists
Development

[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers assigned
[ ] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer

I just read #565, which adds a little more context about your thought process. Can you think of a scenario where we would have an error generated from parse_str() inside the Rollbar SDK that would not be generated elsewhere as well?

Thanks @danielmorell . I actually experienced that no original errors reported while 100+ of parse_str() warnings.
function badTypeFunction(string $str): string
{
    return preg_replace(..., $str, ...); // returns null when internal error occurred.
}

We got a massive data violation to this function like below:
ด็็็็็็็็็็็็็... (more than 1000 strange pattern)

I think that PHP native functions don't have proper error handling. For example, fopen() and fclose() should be used with @ and return value for unexpected IO error. Though ignoring items after 1001 is bad idea, parse_str() never do so correctly even if @ removed. This is not general better practice but special case for this PHP behavior. (This is just my opinion. It's OK that someone else don't think same.)

My another idea is like below:
final class Utilities
{
    public static function saferParseStr($string)
    {
        try {
            parse_str($string, $result);
        } catch (\Throwable) {
            @parse_str($string, $result);
            $result = array_merge($result, ["...more than max_input_vars items"]);
        }
        return $result;
    }
}


add: Ken-Musau

Description

add Ken-Musau profile
Related Issues

Changes Proposed

Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@Ken-Musau Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and help us grow even further!


Spellcheck

Codecov Report

Merging #36 (e70ec91) into main (652f356) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   99.67%   99.67%
=======================================
  Files          13       13
  Lines         610      610
=======================================
  Hits          608      608
  Misses          2        2

Files
Coverage Δ

src/evapotranspiration.jl
95.23% <ø> (ø)

src/filter_data.jl
100.00% <ø> (ø)

src/meteorological_variables.jl
100.00% <ø> (ø)

src/stability_correction.jl
100.00% <ø> (ø)

src/sun_position.jl
100.00% <ø> (ø)

src/surface_conductance.jl
100.00% <ø> (ø)

src/unit_conversions.jl
100.00% <ø> (ø)

src/util.jl
100.00% <ø> (ø)


Silk.NET D3D Discussion

So we can chat about the Direct3D Silk.NET switch here
related to PR
#1123

I'm at a point where we could use the latest specification for direct x (version is 1.6). Originally Stride is handling only 1.0 to 1.2. (that's the feature level values).
Should we keep the same feature levels, add 1.3 to 1.6 or just keep 1.6?
From what i can tell, this would either add more preprocessor conditions in classes :
#if DIRECTX11_0
OutputDesc desc;
#elif DIRECTX11_1
OutputDesc1 desc;
#elif DIRECTX11_2
OutputDesc2 desc;
#elif DIRECTX11_3
OutputDesc3 desc;
// ...

My opinion would be that we should support the latest D3D11 specification only (since windows 11 is rolling out and a lot of older hardware do not seem to besupported)
and focus on VK/DX12/OGL since the three of them have official support mesh and ray shaders. So i'd love to know any other opinions for confirmation

Another thing I want to point out here is that there are no DX11 Era GPUs in support anymore from Nvidia with the exception of MAYBE a few GT cards. AMD has done much the same as well, I am fairly certain that there are no DX11 only cards either from that point. Pretty much every GPU that even the manufacturers support for gaming are DX12 capable and most were made when the DX12 spec was out, not to mention to support DX12 to begin with you only need FL0/1 and FL1/2

Great. Less historical baggage means faster R&D and promotion.


Add more 'use case' help files

the new look releasing.md really helped understand the direction of the task and how it might be used.  We should use this technique for each of the other tasks

See PR #91

fixed by #91


update publication date format in the citation template

This PR will fix https://github.com/antleaf/nims-mdr-development/issues/434 .

Memo: This fixed NIMS issues 295, 384, and 529.


How To Slide Left panel after setSlidingEnabled(true)?

Hello Sir,
I have set  setSlidingEnabled(true) for disable sliding in Sliding Menu by doing this am unable to slide left pane.
Or
Can you please provide Sliding status like PanelSlideListener in Sliding Menu.
Thanks
Alok Pandey.

In my case, I need to setTouchModeAbove(SlidingMenu.TOUCHMODE_FULLSCREEN) in order to make the swipe gesture (slide) works


⚠ Bofrost.com has degraded performance

In 1d89e69, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 667 ms

Resolved: Bofrost.com performance has improved in c8f10bf.


Field Level Validation not working in android

i am using redux-form 6.4.1 for field level validation.
i am using my own component in FIELD.
it's  working perfectly for IOS bt not working for android.
i got the error

it works good if i remove validation
my code is
<Field
              name="myname"
              validate={[ required ]}
              component={myname =>
                <View>
                  <SegmentedControls
                  options={ product_myname }
                  selectedIndex={myname.input.value}
                  extractText={ (option) => option.name }
                  onSelection={ (value)=>{
                    myname.input.onChange(value.taste_id);
                  }}
                  tint= {StyleCommon.COLOR_GREEN}
                  selectedTint= {StyleCommon.COLOR_WHITE}
                  notSelectedTint= {StyleCommon.COLOR_TITLE}
                  borderColor={StyleCommon.COLOR_BORDER}
                  />
                <View style={styles.errorCard}>
                { myname.meta.touched && ((myname.meta.error && <Text style={styles.error}>{myname.meta.error}</Text>) )}
                </View>
              </View>
              }/>

You're going to need to do some more debugging on this.
Is your required function being called? With what? What is it returning?

Im experiencing the same issue, if the remove the validator it works fine.
Also, if i connect the debugger to it, the error no longer exists

Ok did a little more looking into it, I pulled down the latest version from git, and pointed to the source instead.
When using the source it works correctly, however when pointing to the node module it fails

Ok so more details, it is inside of generatorValidator.js, however its in the Converter JS so not the ES6 file based in the source code.
it resides on line: 28 of that file namely this snippet
var _iterator = toArray(validators)[Symbol.iterator]()
it appears that when not debugging in Android i can run this code
alert(Symbol.iterator), and shows @@Iterator, however on iOS it states it cannot convert to string, however when debugging android it throws the same error as iOS, so it appears that when debugging its using chromes js engine? and thus able to eval the code correctly? however when running on the device it fails
Still looking at it.

Not sure of the ramifications, but..
As part of the build process if you use babel-present-es2015-loose this will remove the dependency to the Symbol.Iterator and the code it generators will then work in android.

further to this looking at libraries like react-redux they are using loose flags when using babel
see: https://github.com/reactjs/react-redux/blob/master/.babelrc
Hope this helps!
Mitch

Same issue here on IE 11, check https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol, please note IE does NOT support Symbol. How can I make redux-form work on IE11?

@mitch-tofi  @erikras   so how can i put field level validation in android ??
which is batter way ??

@nilaybrahmbhatt, ideally @erikras would just update the npm package to use the loose settings, that way you can rely on npm for pulling down updates etc.
however if you need to get something live ASAP, the easiest solution would be to pull down the source and include in your project, keep it seperate from your src folder. once @erikras updates npm, you can remove that folder and continue as normal

@mitch-tofi  after pull down source from git i have to update it in node_modules??

I am also experiencing this! Normal validation function work but when using Field level validation it does not work on Android. Only when using remote debugger it works on Android :/. Any updates on this?

@mitch-tofi Can you post PR to @erikras if you know how to fix it? :)

this not only happens on android, but also on other browsers with older webkit engine. For me, PhantomJs is failing. Symbol.iterator is the problem, which is first part of ES6

@cmjartan So if there would be only ES5 this would work? ping @erikras

@henrikra I'm not an expert in browser compatibility, but yes, this would increase compatibility. As to the discussion at https://github.com/paulmillr/es6-shim/issues/182, Symbol.iterator is also not fully "shimmable". Shimming ES5-features seems to be easier

Same issue I'm straggling with but the latest code is not solving the problem.
Without validation works perfectly.
Please advice!

I use bable-runtime and core-js, see https://babeljs.io/docs/plugins/transform-runtime/
That page lists the good reasons why I should use babel-runtime if I already use babel to compile my es2015 code. Then it's natural to use core-js because "The transformer will alias these built-ins to core-js so you can use them seamlessly without having to require the polyfill."
core-js provides all the shim I need on different browsers (System.iterator, Promise ....). so es6-shim could be removed.

Thank you, everyone, for your help.
I've managed to handle it by adding into my index.android.js file the following lines:
import 'core-js/es6/symbol';
import 'core-js/es6/array';

Running on the following packages versions:
"react-native": "0.39.2",
"redux": "^3.6.0",
"redux-form": "^6.5.0",
"core-js": "^2.4.1",

@mrova's solution works well. Thank's a lot. Only one point to add: these lines MUST be put before React import, let's say in first lines of the index.android.js

@cmjartan Yes. iOS 8 is also failing.

Same here on android.

The core-js fix works, but is this fixed ?

@erikras I woul also know if there has been actual fix for this :)

@erikras @henrikra Hi guys, is there an actual fix for this?
I'm using version 7.0.1 and I still get this error on Android and imports fix isn't working for me.

This is working for me on 6.8.0 version.
Please close the issue if it is fixed.

@deepaksisodiya You mean without these hacks in this thread?


Add list of programs currently supported in docs

QCEngine supports executing a variety of quantum chemistry, semiempirical, and molecular mechanics programs. The programs currently supported appear to be:
> from qcengine import list_all_programs
> list_all_programs()
{'dftd3',
 'entos',
 'molpro',
 'mopac',
 'mp2d',
 'psi4',
 'rdkit',
 'terachem',
 'torchani'}

The docs do not currently indicate what QCEngine supports. I propose we add a docs page with the list of currently-supported programs, possibly with comments as to what is and is not supported for each.

I'm happy to build a stub for this if desired. I don't have enough insight yet to fill in the meat for each program harness (as to what the limits of support are), but have some things I've built that fit the bill structurally.

The meat is harder to define than it ought to be, partially because many people are writing the interfaces and because, in scope, QCEngine should run any QCSchemus, and 99.5% of any program's capability should be definable by QCSchema.
Ideally, I'd like the tests to scrape program, method, driver, and maybe frozen-core & reference and build its own capabilities list that autoupdates.
Practically, I think two sentences in the docs somewhere with an overview of what's known to work and not work will serve good purpose and keep everyone away from rabbit holes. If you've a stub in mind, I'm all for it.

A simple checklist should be good enough. Energy/gradient/Hessian/properties/Wavefunction would cover a pretty high level overview.

In this checklist should we specifically say which methods of the target program are supported? And do we document that each program will have it's own set of keywords?

I envision that we could have a grid with programs as rows and "energy", "gradient", "Hessian", "properties", "wavefunction" as columns. Each cell would be one of Full support, no support, or partial support. Details about exactly what is available can live in the docs.

We have this now: http://docs.qcarchive.molssi.org/projects/QCEngine/en/stable/program_overview.html. Let us all endeavor to actually keep it up to date...


Process to attach JCCP test reports with submitted material

As commented here: https://github.com/cta-wave/Test-Content/pull/47#issuecomment-1551976627
We would like to know a bit more details about the process please?

Where to attach the JCCP test reports
In which format
Which version on JCCP should we use? - we have run with latest release on master

We have used http://beta.conformance.dashif.org/ and summaery of report is attached here.
CTA WAVE_AAC streams_JCCP DASH-IF Conformance Tool Results_300523.xlsx

@yan please discuss with Nicholas.

Would it be acceptable to upload these reports to the server? I feel they belong more to the media than this git repository (which is for the front-end).
Also I had envisioned that the validation script would be eventually called automatically at the end of the generation process. It already has an option to call JCCP and to emit a report.

@yanj-github @rbouqueau
Can this issue be closed?

@rbouqueau This is not a blocker. On 12-5-23 we agreed to use @rbouqueau proposal for a location. He can proceed.

Deferred to V2. Waiting for additional/new content to be generated and posted before reports are attached to the new content.

Integrating JCCP validation in test content generation.


Run pose_camera.py in WSL2

Description
Hello,
I am using the CoralDevBoard with the coral camera on a Windows 10 computer; to view graphics and run GUI programs, I use vcxsrv. I am working with WSL2 (Windows Subsystem for Linux) and I have successfully installed all the requirements. I was able to run the simple_pose.py module, but I have not been able to run the pose_camera.py example. The output is attached.
I then ran the gstreamer.py file and got the same error of not being able to display.
Can I actually get a display through WSL2?   If not, is there a way to stream this through a sever, in the same way, that the demo for the coral camera set up does (https://coral.ai/docs/dev-board/camera/#view-with-a-streaming-server)?
I appreciate your help
Click to expand!

Hello @jorgemmar10 we haven't tested coral devices on WSL. Can you please tell us why you are using WSL as you can connect to the Dev Board through Windows itself.

Hello,
I used WSL for convenience purposes; I was able to get it to work using the instructions provided online. Thank you for your help.


Server side in Create React App

Has anyone done server-side rendering with Curi in Create React App? I'm getting a little lost. Content is showing but the styles and data from the router isn't showing. This is my code, pretty much copied from  https://github.com/pshrmn/curi/blob/2dca9d5b41fd6924d6221dd334710646f1c11ea5/examples/misc/server-rendering/renderer.js.
import React from 'react';
import { renderToString } from 'react-dom/server';
import InMemory from '@hickory/in-memory';
import curi from '@curi/core';
import { CuriProvider } from '@curi/react';
import App from '../../src/containers/App';
import routes from '../../src/routes';

export default function(req, res) {
    const history = InMemory({ locations: [req.url] });
    const router = curi(history, routes);

    router.respond(() => {
        const markup = renderToString(
            <CuriProvider router={ router }>
                {({ response }) => {
                    const { body: Body, params } = response;
                    return (
                        <App>

                        </App>
                    );
                }}
            </CuriProvider>
        );
        res.send(renderFullPage(markup));
    });
}

function renderFullPage(html) {
    return `
        <!DOCTYPE html>

                <meta charset="utf-8">
                <meta name="viewport" content="width=device-width, initial-scale=1">

                    You need to enable JavaScript to run this app.

${ html }

                ]

    `;
}

Any help would be appreciated. Thanks!

Content is showing but the styles and data from the router isn't showing.

Can you expand on what styles/data you are referring to? I assume you are styling your components with CSS-in-JS because you don't have a <link> to a .css file in your .

I'm using Sass. So I have the basic markup showing, but no data (rather, props) such as the router, response and navigation from the Curious element.

Would you be able to upload your code to a repo? It would be easier to help if I could see your routes/where you are using the <Curious> component.
Is your SASS compiling to CSS or is Webpack bundling it with your JS (I haven't really used Create React App, so I'm not sure how it does this). If you have a CSS file, you should modify the string returned by renderFullPage to include that.

  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <link rel="stylesheet" href="/static/css/index.css" />

Also, as an aside, you can tag code blocks as js/jsx for prettier highlighting
```jsx
// your code here
\``` (ignore the leading slash)

It's compiling to CSS but I just realized there is no bundled CSS. I will take a look at what you mentioned. Thank you for your help. If I can't get anywhere, I will see about getting you a repo. But I'm trying not to bother you much :-)

I finally found a way to do it. Someone was gracious enough to document how to do SSR in Create React App and once I replaced <App /> (their code) with Curi's Provider code, I was in business. Here's the link to the project: https://github.com/kriasoft/react-app
Thanks for your help!


Add swipe to Course Selection for 1st question

It's not possible to go back to the course selection by 'swiping back' on the screen of the 1st question , instead the screens stays the same.

fixed. Course Selection is now part of the Pager Viewer and no seperate activity anymore


Copy of @slchow edits, attempt to fix git branch/pull request.

This should be a valid replacement for KhronosGroup/glTF-Tutorials#7, applying @slchow's edits to @javagl's tutorial.

@javagl note that if/when you click merge on this request, the changes will be brought into your fork, and thus automatically become part of your main pull request to the Khronos repo.

Thanks @emackey for fixing the PR issue!


09:03:22 CRITICAL: panic: runtime error: invalid memory address or nil pointer dereference

Doing the pub / sub tutorial for Go on Google App Engine Flexible environment listed here:
https://cloud.google.com/appengine/docs/flexible/go/writing-and-responding-to-pub-sub-messages
Follow everything as best as I can (which I believe is exact).  When I run it locally it will run, however when i try to create a message to send in the web interface it gives me the error above ( with other things).  Main code snippet below, though you can view total snippet at the above url.  Full Error below.
`func main() {
ctx := context.Background()
client, err := pubsub.NewClient(ctx, mustGetenv("GOOGLE_CLOUD_PROJECT"))
if err != nil {
log.Fatal(err)
}
// Create topic if it doesn't exist.
topic, _ = client.CreateTopic(ctx, mustGetenv("PUBSUB_TOPIC"))

http.HandleFunc("/", listHandler)
http.HandleFunc("/pubsub/publish", publishHandler)
http.HandleFunc("/pubsub/push", pushHandler)

appengine.Main()

}`

09:03:22 CRITICAL: panic: runtime error: invalid memory address or nil pointer dereference
goroutine 26 [running]:
google.golang.org/appengine/panic(0x149d8c0, 0x17ef8e0)
/usr/local/go/src/runtime/panic.go:491 +0x283
cloud.google.com/go/pubsub.(*Topic).initBundler(0x0)
/Users/ruben/go/src/cloud.google.com/go/pubsub/topic.go:327 +0x37
cloud.google.com/go/pubsub.(*Topic).Publish(0x0, 0x17ba580, 0xc4200160d0, 0xc4201d04d0, 0x0)
/Users/ruben/go/src/cloud.google.com/go/pubsub/topic.go:248 +0x11d
main.publishHandler(0x17b8880, 0xc4201fccc0, 0xc4201a0200)
/Users/ruben/go/src/github.com/GoogleCloudPlatform/golang-samples/appengine_flexible/pubsub/pubsub.go:101 +0x117
net/http.HandlerFunc.ServeHTTP(0x155d1c0, 0x17b8880, 0xc4201fccc0, 0xc4201a0200)
/usr/local/go/src/net/http/server.go:1918 +0x44
net/http.(*ServeMux).ServeHTTP(0x17ffac0, 0x17b8880, 0xc4201fccc0, 0xc4201a0200)
/usr/local/go/src/net/http/server.go:2254 +0x130
google.golang.org/appengine/internal.executeRequestSafely(0xc4201fccc0, 0xc4201a0200)
/Users/ruben/go/src/google.golang.org/appengine/internal/api.go:153 +0x77
google.golang.org/appengine/internal.handleHTTP(0x17b9d00, 0xc4202dc1c0, 0xc4201a0200)
/Users/ruben/go/src/google.golang.org/appengine/internal/api.go:121 +0x249
net/http.HandlerFunc.ServeHTTP(0x155cd40, 0x17b9d00, 0xc4202dc1c0, 0xc420258400)
/usr/local/go/src/net/http/server.go:1918 +0x44
net/http.serverHandler.ServeHTTP(0xc4202904e0, 0x17b9d00, 0xc4202dc1c0, 0xc420258400)
/usr/local/go/src/net/http/server.go:2619 +0xb4
net/http.(*conn).serve(0xc4200a1220, 0x17ba540, 0xc4201aa940)
/usr/local/go/src/net/http/server.go:1801 +0x71d
created by ne
2018/01/18 09:03:22 Metadata fetch failed: Get http://metadata/computeMetadata/v1/instance/attributes/gae_project: dial tcp: lookup metadata: no such host
exit status 1

The problem is that if following the tutorial here:
or the README.md here  then you should've already created a Topic and therefore as it is using the method CreateTopic
it will return that error. The file pubsub.go should use the method Topic instead.

Needs the same fix as #363.


Update index.md

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@goswamimohit
This seems to be opened by accident, so I am going to close it now :yellow_heart: Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions :sparkles:


Question about "createDocumentFromSource" method

Hi,
I use your (great...) library in a nodeJS module.
My goal is to create a new document from an already existing one (and I have to keep the source content).
So I use the "createDocumentFromSource" and it seems I have to give a parameter (the 3rd) with some content...
First, I try with null, empty and undefined keyword, but I got an error.
So I try with an empty string, so I don't get an error, but the created document has an empty source (ok, logical...).
So my question is, how can I manage to keep the original content of the source document ?
Of course, I can get the content of the source document and put it in 3rd parameter but it's not very pretty because of the "goings and comings" on network...
Weird thing : If I use the library outside of nodeJs, it seems that I can omit the 3rd parameter then it works as wished...
Thx in advance for your job and your help.
BR
Wiser.

Thank you for closing your issues (and for fixing my bugs)


TypeError: No implicit conversion of false into Integer

I get the follow error when trying to start/quit a bluepill process that is not yet running yet.
 /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/system.rb:23:in `kill' : no implicit conversion of false into Integer (TypeError)
 from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/system.rb:23:in `pid_alive?'
 from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/controller.rb:89:in `block in cleanup_bluepill_directory'
 from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/controller.rb:87:in `each'
 from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/controller.rb:87:in `cleanup_bluepill_directory'
 from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/lib/bluepill/controller.rb:15:in `initialize'
 from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/bin/bluepill:77:in `new'
 from /somewhere/shared/bundle/ruby/2.1.0/gems/bluepill-0.0.70/bin/bluepill:77:in `<top (required)>'
 from /somewhere/shared/bundle/ruby/2.1.0/bin/bluepill:23:in `load'
 from /somewhere/shared/bundle/ruby/2.1.0/bin/bluepill:23:in `<main>'

Reading the code, I assume the following test next if pid || System.pid_alive?(pid) (https://github.com/bluepill-rb/bluepill/blob/master/lib/bluepill/controller.rb#L89) should rather use && then ||, right? -> otherwise we're potentially calling pid_alive? with false :/
(Using bluepill 0.70 & ruby 2.1)

Anything happen with this ?

changing ||to && is fixing the following error for me:
/var/lib/gems/2.1.0/gems/bluepill-0.1.1/lib/bluepill/system.rb:23:in `kill': no implicit conversion of false into Integer (TypeError)
        from /var/lib/gems/2.1.0/gems/bluepill-0.1.1/lib/bluepill/system.rb:23:in `pid_alive?'
        from /var/lib/gems/2.1.0/gems/bluepill-0.1.1/lib/bluepill/controller.rb:89:in `block in cleanup_bluepill_directory'
        from /var/lib/gems/2.1.0/gems/bluepill-0.1.1/lib/bluepill/controller.rb:87:in `each'
        from /var/lib/gems/2.1.0/gems/bluepill-0.1.1/lib/bluepill/controller.rb:87:in `cleanup_bluepill_directory'
        from /var/lib/gems/2.1.0/gems/bluepill-0.1.1/lib/bluepill/controller.rb:15:in `initialize'
        from /var/lib/gems/2.1.0/gems/bluepill-0.1.1/bin/bluepill:77:in `new'
        from /var/lib/gems/2.1.0/gems/bluepill-0.1.1/bin/bluepill:77:in `<top (required)>'
        from /usr/local/bin/bluepill:23:in `load'
        from /usr/local/bin/bluepill:23:in `<main>'

Thanks @akzhan 👍

👍 @akzhan


Fixed link to CONTRIBUTING.md

Please correct all four occurrences, thanks:
$ grep -rI --exclude-dir=Taps '\.github/CONTRIBUTING.md'
.github/PULL_REQUEST_TEMPLATE.md:- [ ] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/.github/CONTRIBUTING.md) document?
docs/FAQ.md:Read [CONTRIBUTING.md](/.github/CONTRIBUTING.md).
docs/Formula-Cookbook.md:Before submitting a new formula make sure you read over our [contribution guidelines](https://github.com/Homebrew/brew/blob/master/.github/CONTRIBUTING.md).
docs/README.md:Read [CONTRIBUTING.md](/.github/CONTRIBUTING.md).
README.md:We'd love you to contribute to Homebrew. First, please read our [Contribution Guide](https://github.com/Homebrew/brew/blob/master/.github/CONTRIBUTING.md) and [Code of Conduct](https://github.com/Homebrew/brew/blob/master/CODEOFCONDUCT.md#code-of-conduct).

Missed these, thanks. Yeh, if you could get all of them that'd be amazing, thanks.

Just grabbed them quickly myself but thanks for submitting a PR ✨

Sure. Here it comes: https://github.com/Homebrew/brew/pull/1042


[ACPROX] : (JS-0089) Comparisons found where both the sides are exactly the same

Description
Comparing a variable against itself is usually an error, either a typo or refactoring error. It is confusing to the reader and may potentially introduce a runtime error. The only time you would compare a variable against itself is when you are testing for NaN.
Occurrences
There is 1 occurrence of this issue in ACPROX.
See all occurrences on DeepSource → app.deepsource.com/gh/dswan36/acprox/issue/JS-0089/occurrences/

Bad Practice
const x = 10;
if (x === x) {
    x = 20;
}

Recommended
if (x == y) {
    x = y + 10
}

Eg replace === with = and != w/ !=== afaik


updateSheet props not working

The updateSheet function is not working.

Rendering the Workbook
When I give an example sheet data to the updateSheet function, it does not set (it works when I give the data normally, so the data is not wrong)

Normally when I use this function it should render the whole sheet (according to the api document)

using:

have you ensured that celldata which is being passed in the second useEffect is an array? (as you are manually putting it inside an array in Workbook props)

@ozlemkcr i needed to do something like https://github.com/ruilisi/fortune-sheet/issues/451 to get it to work

@sanchit3008 thank you, i fixed. @guiziii thank you for your solution i will try but i want to set all sheet property. In the development environment, useEffect is triggered twice and the updateSheet function crashes. I didn't have such a problem with the applyOp function. Do you have any knowledge about this issue??
Errors:

Can you post your updated code? Not sure if I am following what the exact problem is now.

Of course, I am sure that the data is correct because when I trigger the same action with the button it works.

closing this as this is not a fortune sheet issue, please follow the suggestions posted by @guiziii in #451


Add an ES6 test runner.

We should have a test runner that:

can run locally, from the command line.
can be used by a CI server.
that understands ES2015, same as the target code.
has a DOM, when required.

Some background to the development of Karma in the authors thesis: JavaScript Test Runner.

Contacted BrowserStack regarding a license for 'Automate Pro', to use virtualized desktop/mobile browsers for testing with Karma.


Added carbon intensity API

Insert URLs to the project here:
carbonintensity-api
In one sentence, explain what the project is about:

Rust library to retrieve regional carbon intensity data from the UK National Grid.

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

@jnioche Thank you so much for your contribution!


multi-types instead  of ArgumentTransformtionAttribue

with  ParameterSets and ArgumentTransformtionAttribue we can change  the type of one or more attribute but its lots of typing and sometimes its not easy
Given the dynamically typed nature of Powershell there are lots of cases where multi-types can be useful. multi  types are a collection of two or more types which indicate that either one of those can be used.

#  prototype
function foo {
  param(
    [unionType('int','datetime','string')]
    $myhappyparam
  )

}

When would you use this in a practical case? PowerShell is pretty permissive when it comes to converting types, but in general I'd pretty much expect that you're only going to end up duplicating code that would otherwise go in the transformation attribute, so I'm not sure what this would really be adding overall?

for example:
function foo {
  param(
    [unionType('int','System.Management.Automation.PSModuleInfo')]
    $module
  )
  proceess {

     # code
  }
}

works in all caases
PS>  get-module mymodule
PS> foo -module  mymodule
PS> 'mymddule'  |  foo

A string and a PSModuleInfo are pretty different.  How would you use them as if they were the same?

@SeeminglyScience
the idea is like  ArgumentTransformtionAttribue transform type of attribbute but in easy way

Right but with that attribute you're transforming it into the real expected type.  Here it's just going to be any one of those without any transformation.  So since $module will either be string or PSModuleInfo, can you give an example of how you would expect interacting with it to look?

the logic in body of this  function is same as the logic of body of ArgumentTransformtionAttribue.
we tests the type of  $module
if string then ... else if PSmoduleInfo ....
also with parametersets is the same mechanism we tests the parametersets
this is a prototype...maybee samee chaange  occuurs...
the goal  is to simplify  the convertion between multiple type
sorry  for my english

That's not how types work with parameter
[String]$p1
[int]$p2
[system.io.file]$p3

Says "Convert P1 to a string" , "Convert P2 to an int"  and "Convert p3 to a file"
The third case does some really stupid things (like creating a reference to a non-existent read only file in \windows\system).
If you say $p4 might be a string or an int , what does it do with 3.14 ? Make it a "3.14" or 3
[int]$p2 says if it is a string try to make it an int. If that fails we get an error.
If you want to say $P might be a name, and ID or an object (which is good !) then you specify no conversion attribute and check inside the function to see what you were passed and proceed accordingly.

pseudo-code
if string then ... else if PSmoduleInfo ....

If you need to do that logic manually anyway, I think typing the parameter as [psobject] will do what you want.  I could see the value in an attribute that describes the types that a [psobject] typed parameter can accept, but if it was anything other than purely documentation it would make parameter binding really hard to reason about.

sorry for my english

No worries, your english is excellent 🙂

@SeeminglyScience
thanks you.
but why [psobject] work and the baseobject [object] not work ?

It looks like there are two distinct aspects:
(a) Making argument type transformation easier - where, as with ArgumentTransformationAttribute, you always end up with the single declared parameter type.
Taking the System.Management.Automation.PSModuleInfo / string example, I can see how it would be nice to have a simpler way to implement a transformation, namely via  a script block:
function foo {
  param(
     # Wishful thinking: If a [string] with a module name or path is given,
     # transform it to a PSModuleInfo instance.
     [Transform([string], { Get-Module -ListAvailable $_  })]
     [System.Management.Automation.PSModuleInfo] $Module
  )
}

(Of course, you could argue that [System.Management.Automation.PSModuleInfo] '/path/to/module' should be supported by default, but that's a separate issue.)

(b) Allowing a parameter to be limited to a fixed set of types, with command-internal logic to examine the type ultimately passed.
Given the manual effort needed to examine the type inside the function anyway, and given @SeeminglyScience's point about how enforcing the set of types would make parameter binding hard to reason about, I think this would call for a different solution:
Distinct, strongly typed, mutually exclusive parameters.
Of course, that's what parameter sets are for - but implementing this logic is currently quite cumbersome.
For instance, the following implements two mutually exclusive, positional parameters that target something either by a numeric ID or a name string, so that you can call foo 42 or foo bar, and the former will bind to -ID, the latter to -Name (as an aside: Wait-Process already works that way, but not Get-Process / Stop-Process - see #6551).
function foo {
  [CmdletBinding(DefaultParameterSetName='Name')]
  param(
    [Parameter(Position=0)]
    [int] $ID
    ,
    [Parameter(Position=0, ParameterSetName='Name')]
    [string] $Name
  )
  "[$ID] [$NAME]"
}

That's a lot of ceremony, and I wonder if we should allow a more succinct expression of this concept.
We have thought about this before, namely in the context of this since-withdrawn RFC: https://github.com/PowerShell/PowerShell-RFC/blob/master/X-Withdrawn/RFC0001-Mutual-Exclusion-Parameters-and-Properties.md

why [psobject] work and the baseobject [object] not work ?

[object] would work, and in fact I suggest using it rather than [psobject], because from a scripter's perspective [psobject] should really be considered an invisible helper type not to be used directly.

[object] would work, and in fact I suggest using it rather than [psobject], because from a scripter's perspective [psobject] should really be considered an invisible helper type not to be used directly.

I usually recommend psobject because in some circumstances object can strip ETS properties, and in others it can result in (a very minor) amount of overhead when unwrapping and rewrapping. Plus that's typically what cmdlets type their parameters as so I like the consistency.

(If what was originally discussed here is to go anywhere, I feel (a) and (b) would have to become new issues anyway, so I hope it's OK to continue the tangent here):
I think the presence of [psobject] in PowerShell code is ultimately more confusing and harmful than beneficial.
Even in cmdlets I wish parameters - and especially output objects - weren't PSObjects - see #5551 and #5579.
Note that not typing a parameter does not result in an extra [psobject] wrapper.
That is, omitting a type is equivalent to [object] typing, not [psobject]:
# Ditto with `[object] $p`
PS> & { param($p) $p -is [psobject] } 42
False

# vs.
PS> & { param([psobject] $p) $p -is [psobject] } 42
True

As for ETS members getting stripped; @lzybkr alludes to that here, but I can't actually get that to happen:
PS> (Get-Item / | add-member -passthru  -NotePropertyName foo -NotePropertyValue bar),
('other' | add-member -passthru  -NotePropertyName foo -NotePropertyValue bar),
(42 | add-member -passthru  -NotePropertyName foo -NotePropertyValue bar),
($false | add-member -passthru  -NotePropertyName foo -NotePropertyValue bar) | % {
    & { param($p) $p.foo } $_
  }

# ETS property .foo was passed through in all cases.
bar
bar
bar
bar

Are there still cases where they get stripped?

I think the presence of [psobject] in PowerShell code is ultimately more confusing and harmful than beneficial.

Eh I see where you're coming from but I disagree.  I remember very early on just thinking "oh it's a PowerShell object, it makes objects do PowerShell things".  I know that's just anecdotal but I don't think most ps users would think about it much last that. Though I could understand it being confusing for C# folks maybe.

Are there still cases where they get stripped?

The one that comes to mind is method parameters where the object will not be rehydrated the same (such as when StoreTypeNameAndInstanceMembersLocally is true).  I believe there are more, but none other readily remember-able.
class Test {
    static [object] GetMembers([object] $obj) {
        return Get-Member -InputObject $obj
    }
}

[Test]::GetMembers($profile) | ? MemberType -eq  NoteProperty

In that example only certain types and pso instances will be stripped of ETS properties because in most cases they will be rehydrated correctly.  That said, if the method is binary it will not. That's why PSSerializer.Serialize always strips ETS.
The reason for that (and the reason it can't be fixed) is because most dotnet API's have no awareness of psobject.  They won't know that they need to (or if they don't need to) unwrap it.  They also don't typically know how to enumerate the properties since just using straight up reflection won't yield much useful.
Is it super likely that you'll ever run into one of these scenarios? Nah, but if it does it'll be real hard for most to troubleshoot and I personally don't think there's a downside.

Thanks, @SeeminglyScience.

I don't think most ps users would think about it much last that.

With the presumably accidental extra words in that sentence I'm not sure I got the gist of this. Did you mean to say that most PS users don't think about it much and are accustomed to using [psobject]?
I know that historically [psobject] was often used, notably with New-Object PSObject - before the [pscustomobject] @{ ... } syntax sugar was introduced in v3. Even before that, New-Object PSCustomObject would have made more sense conceptually.
Still, I think we would benefit in the long run if [psobject] became a truly invisible, transparent-to-the-scripter type. The way it currently peeks from behind the curtain - situationally, in ways that are virtually unpredictable to the casual user - will remain a pain point.

In that vein (thanks for the method example): Do you think it's possible in principle to make a non-breaking change that prevent the occasional loss of ETS member without having to use [psobject] variables explicitly?

In that example only certain types and pso instances will be stripped of ETS properties

What causes the loss with $PROFILE, specifically? Looking at the source code, it appears not to use StoreTypeNameAndInstanceMembersLocally
Also,  StoreTypeNameAndInstanceMembersLocally appears to be a v2 legacy feature anyway (see https://github.com/PowerShell/PowerShell/issues/7768#issuecomment-426154780), and its continued use causes the problem in #7937, for instance.

Thanks, @SeeminglyScience.

I don't think most ps users would think about it much last that.

With the presumably accidental extra words in that sentence I'm not sure I got the gist of this.

Supposed to be past instead of last, I'll fix that ty :)

Did you mean to say that most PS users don't think about it much and are accustomed to using [psobject]?

I think they won't think much about it other than "use psobject instead of object because it does ps things".

Still, I think we would benefit in the long run if [psobject] became a truly invisible, transparent-to-the-scripter type. The way it currently peeks from behind the curtain - situationally, in ways that are virtually unpredictable to the casual user - will remain a pain point.

It's a nice thought, but I fear that would end up being a more impactful and confusing version of what happened to AutomationNull.

In that vein (thanks for the method example): Do you think it's possible in principle to make a non-breaking change that prevent the occasional loss of ETS member without having to use [psobject] variables explicitly?

Unfortunately no.  If you change the member binder to pass the PSObject wrapper instead of the base object, a whole lot of code will still failing.

What causes the loss with $PROFILE, specifically? Looking at the source code, it appears not to use StoreTypeNameAndInstanceMembersLocally

Strings are treated like that member is true implicitly, probably because of string interning.

Also, StoreTypeNameAndInstanceMembersLocally appears to be a v2 legacy feature anyway (see #7768 (comment)), and its continued use causes the problem in #7937, for instance.

I don't see where in that issue (including the linked comment) where that's said, did you link the right one?

As always, I appreciate the deep dive, @SeeminglyScience.

Strings are treated like that member is true implicitly, probably because of string interning.

Let's try to narrow this down: Is [string] the only type to which that applies?
That does appear to be the case:
class Test {
    static [object] GetMembers([object] $obj) {
        return Get-Member -InputObject $obj
    }
}

# .foo resurfaces; ditto with `$true | Add-Member ...`
[Test]::GetMembers((42 | Add-Member foo bar -PassThru)) | ? MemberType -eq  NoteProperty

I think the larger point is that attaching ETS instance members to strings and value types is generally a bad idea, and the $PROFILE implementation - a string with NoteProperty members - always struck me as awkward and obscure.
If a [string] instance with NoteProperty members is the only case where [psobject] is needed, I'd say that hardly warrants its use.

I don't see where in that issue (including the linked comment) where that's said, did you link the right one?

The linked comment states:

in V3 when we changed the underlying representation of instance members.

That suggests to me that a better mechanism was introduced that supersedes the old one was introduced, and the linked comment details the improvements.
Conversely, the old mechanism is both obscure and can cause problems, as #7937 demonstrates, and as summarized int this comment by someone I implicitly trust (just kidding):

Generally, the - seemingly legacy - mechanism of associating instance member with a - usually invisible - [psobject] wrapper rather than the wrapped object itself strikes me as highly obscure

Let me ask the opposite: why do you think it's still useful (leaving aside true edge cases)?

Let's try to narrow this down: Is [string] the only type to which that applies?

Think so

I think the larger point is that attaching ETS instance members to strings and value types is generally a bad idea, and the $PROFILE implementation - a string with NoteProperty members - always struck me as awkward and obscure.

🤷 won't stop folks from doing it.

If a [string] instance with NoteProperty members is the only case where [psobject] is needed

Also pso's with StoreTypeNameAndInstanceMembersLocally.

I'd say that hardly warrants its use.

Between the two psobject handles some niche cases better.  If you personally don't like psobject for style or philosophical reasons, yeah the world for sure isn't going to end if you use object.

The linked comment states:

in V3 when we changed the underlying representation of instance members.

That suggests to me that a better mechanism was introduced that supersedes the old one , and the linked comment details the improvements.

He's saying that they added resurrection tables and then describes the benefits of them. StoreTypeNameAndInstanceMembersLocally is how you purposefully skip resurrection tables.

Let me ask the opposite: why do you think it's still useful (leaving aside true edge cases)?

No matter how I feel about it personally, it's still used.
I do kinda wish it was used more though.  Resurrection is really annoying with types that are cached for instance.  For example, making a provider that outputs Type objects, now every literal has PSPath attached to it.  You could argue that you should create a wrapper type, but then you have to reimplement all of the methods on Type, etc.  Or lets say you're just trying to add a property or type name for formatting, now everywhere that instance is used is changed.

Let's try to summarize:

For function parameters (the premise of this issue) omitting a type constraint or using [object] works fine in all cases - ETS members are never  lost, so there's no need for [psobject].

For method parameters in PowerShell classes, omitting a type constraint or using [object] works fine, except in the following edge case:

PSObject instances that have instance ETS members and whose private StoreTypeNameAndInstanceMembersLocally property is true, i.e. whose ETS instance members are associated with the incidental PSObject wrapper rather than the wrapped objects themselves (via the v3+ resurrection tables); to  support such objects, you must declare your parameter as [psobject]. Such objects are created under the following conditions:

Invariably, for technical reasons (the CLR's string interning), when attaching ETS instance members to [string] instances.

It is generally not advisable to create such wrapped [string] instances, because the ETS properties are hard to discover, given that the [psobject] wrapper still prints like a string by default; it is unfortunate that the automatic $PROFILE variable uses this technique; similarly, the strings output by Get-Content are wrapped this way, currently without an opt-out - see #7537. Such wrapped strings can conversely surface their ETS instance members in unexpected situations - see #5797.

For the same reasons it is not advisable to add instance ETS members to instance of .NET primitive types (such as most number types, [char], and  [bool]) (even though they are passed through to methods); additionally, the engine caches certain literals, so $v = 42; $v | Add-Member foo bar doesn't just make $v.foo return 'bar', but also associates the property with the literal:
& { param($p) $p.foo } 42 then prints 'bar'.

Potentially, by engine-internal code that opts-into the v2 behavior; the - sensible - default in v3+ is to leave StoreTypeNameAndInstanceMembersLocally  at false, i.e. to associate the ETS instance members with the the wrapped object themselves. (Note that user code cannot opt-into v2 behavior, because the static method that creates a PSObject with StoreTypeNameAndInstanceMembersLocally set to true is internal.) See below.

Note that for a method in compiled code the only way to receive an object with ETS members - whether instance or type-level, whether with StoreTypeNameAndInstanceMembersLocally set to true or not - is to declare the parameter as PSObject.
By contrast, a cmdlet's parameters - which are implemented as .NET type properties - do receive PSObject wrappers as such even for object-typed parameters = properties (not just for PSObject-typed ones).

Instances of wrapper-only instance members  in the engine code as of PowerShell Core 7.1.0-preview.1 (StoreTypeNameAndInstanceMembersLocally set to true):
Note: Obtained via regex PSObject.AsPSObject([^)]+?,.+?), with false positives weeded out.
https://github.com/PowerShell/PowerShell/blob/022c14917f266818ca5d1e9c08955d85a0b70a87/src/Microsoft.PowerShell.Commands.Utility/commands/utility/Get-Error.cs#L79

Or lets say you're just trying to add a property or type name for formatting, now everywhere that instance is used is changed

The above use avoids that, and constitutes  the aforementioned edge case; it is a legitimate use that should have no impact on user code and is unlikely to raise questions, given that the context is for-display formatting.
https://github.com/PowerShell/PowerShell/blob/022c14917f266818ca5d1e9c08955d85a0b70a87/src/Microsoft.PowerShell.Commands.Utility/commands/utility/Select-Object.cs#L536
https://github.com/PowerShell/PowerShell/blob/022c14917f266818ca5d1e9c08955d85a0b70a87/src/Microsoft.PowerShell.Commands.Utility/commands/utility/Select-Object.cs#L553
This is the bug reported in #7937.

I do kinda wish it was used more though. Resurrection is really annoying with types that are cached for instance. For example, making a provider that outputs Type objects, now every literal has PSPath attached to it.

I think we can cross that bridge when we get to it. Instance members showing up on cached instances is already a problem with cached number literals, as shown above, but adding instances members to instance of such types is ill-advised anyway.
Overall, I think it is important not to use per-wrapper instance members anymore, so as to spare users the confusion of members disappearing in ways that are hard to reason about and may seem inexplicable altogether to the casual user.
It's technically different, but the behavior described in #4347 sows similar confusion.

In the light of this discussion what is the better (preferred,safe,right...) way of using generic.list?
[System.Collections.Generic.List[psobject]] or [System.Collections.Generic.List[object]]?

Use [System.Collections.Generic.List[object]] - there is no need for [psobject] wrappers around the elements.

In PowerShell code, the wrappers will mostly not be noticeable (though can cause side effects, as shown in #5579), but they're unnecessary.

In compiled code, if you pass something like [System.Collections.Generic.List[psobject]] @(1, 2) to a System.Collections.Generic.List<object>-typed parameter, that code will see the list elements as [psobject], not [int].

Let me try to summarize at a higher level (my personal assessment):

From the perspective of code written in  PowerShell, [psobject] should never have entered the picture: it should always have been an invisible helper type, used only behind the scenes (Compiled (C#) code for cmdlets, by contrast, does need to be aware of PSObject and use it on occasion - by no means always - see #5551). To put it differently: The presence of [psobject] in Powershell code amounts to a leaky abstraction.

There are unfortunate historic reasons that promoted the visibility and use of PSObject:

The unfortunate technical conflation of [pscustomobject] and [psobject]: they both point to System.Management.Automation.PSObject - even though there is a distinct System.Management.Automation.PSCustomObject type (see #4344). Only the latter should be visible to PowerShell code. The conflation causes a number of problems, such as #4343 and #11921

Early PowerShell code - before the availability of syntactic sugar [pscustomobject] @{ ... }, which notably does not work in the form [psobject] @{ ... } - often used New-Object PSObject, even though New-Object PSCustomObject would have been the conceptually appropriate form from the beginning.

Syntax diagrams for cmdlets with "untyped" parameters show <PSObject> (which is technically correct, but from a PowerShell user's perspective <Object> would make more sense - it would be a beneficial "lie", just like ([psobject] 42) -is [int] being $true is).

(Note that hidden members such as .psobject are obviously useful for advanced tasks, but, given that they're automatically available on any value directly, they don't require dealing with [psobject] as a whole.)

While [psobject] cannot technically be banished anymore from PowerShell code due to backward compatibility concerns:

we can fix the aforementioned bugs resulting from the conflation of [pscustomobject] and [psobject], as well as the bugs that cause different behavior in the presence of incidental [psobject] wrappers.

we can document that direct use of [psobject] is virtually never necessary (see below), thereby discouraging its use.

Eliminating [psobject] from PowerShell code simplifies the "object ontology" for PowerShell users: Objects fall into only one of two categories:

instances of .NET types that PowerShell optionally decorates with additional members, the implementation of which you needn't know or care about.

dynamically constructed ad hoc objects ("property  bags") in the form of [pscustomobject] / System.Management.Automation.PSCustomObject instances.

That both these features are ultimately implemented via [psobject] is purely an implementation detail.

To recap the only  scenario in which you currently truly need [psobject] in PowerShell code:

If you define a method in a PowerShell class that accepts what is conceptually a [string] parameter and that parameter needs access to a given string's ETS instance members (which would apply if you pass $PROFILE and need access to the AllUsersAllHosts property, for instance, or if you pass a Get-Content-output string and need access to the .ReadCount property, for instance), you must define that parameter as [psobject].

This conceptually obscure requirement solely exists due to a technical limitation that is outside PowerShell's control.

As stated, [psobject]-wrapped instances of other types work fine (except, potentially, due to the bug described in  #7937), and in functions / scripts / script blocks even [string] works fine, so there is never a need to type a parameter [psobject] there.

@mklement0 thanks for a detailed response. It is clear and cool.

I'm glad to hear the comment was helpful, @scriptingstudio, and I appreciate the feedback.
@SeeminglyScience, per the protocol we had agreed on - expressing  an overall sentiment of dissent via a thumbs-down emoji - I've already marked your previous comment accordingly, but, given that the follow-up comments were lengthy, perhaps a focused summary is helpful:

I remember very early on just thinking "oh it's a PowerShell object, it makes objects do PowerShell things".

That something has a long history of usage is not per se justification for continuing that usage.

🤷 won't stop folks from doing it.

Showing indifference toward ill-advised usage is problematic in general, but especially in the context of recommending related usage explicitly on the grounds of accommodating the ill-advised usage.

I do kinda wish it was used more, though.

Advocating for increased use of a feature that represents a step backward and decreases the predictability of the language for end users is problematic.

P.S., @SeeminglyScience: perhaps you can shed light on the behavior described in #12411.


RobotName exercise test problem

I submitted a solution and got this on the editor:
We received the following error when we ran your code:
/mnt/exercism-iteration/Tests/RobotNameTests/RobotNameTests.swift:41:13: warning: variable 'robot' was never mutated; consider changing to 'let' constant
var robot = Robot()
~~~ ^
let
[8/12] Merging module RobotNameTests
[10/13] /tmp/E5A0AADD-1294-4DFB-9859-20B554A41836/x86_64-unknown-linux-gnu/debug/RobotNamePackageTests.derived/main.swift
[11/13] Wrapping AST for RobotNameTests for debugging
[12/15] Compiling RobotNamePackageTests main.swift
[13/15] Compiling RobotNamePackageTests RobotNameTests.swift
[15/17] Merging module RobotNamePackageTests
[17/18] Wrapping AST for RobotNamePackageTests for debugging
[18/18] Linking RobotNamePackageTests.xctest
[18/18] Build complete!
Test Suite 'All tests' started at 2022-05-07 14:22:16.222
Test Suite 'debug.xctest' started at 2022-05-07 14:22:16.285
Test Suite 'RobotNameTests' started at 2022-05-07 14:22:16.285
Test Case 'RobotNameTests.testDifferentRobotsHaveDifferentNames' started at 2022-05-07 14:22:16.285
Test Case 'RobotNameTests.testDifferentRobotsHaveDifferentNames' passed (0.002 seconds)
Test Case 'RobotNameTests.testHasName' started at 2022-05-07 14:22:16.287
Test Case 'RobotNameTests.testHasName' passed (0.002 seconds)
Test Case 'RobotNameTests.testNameSticks' started at 2022-05-07 14:22:16.289
Test Case 'RobotNameTests.testNameSticks' passed (0.0 seconds)
Test Case 'RobotNameTests.testResetName' started at 2022-05-07 14:22:16.289
Test Case 'RobotNameTests.testResetName' passed (0.0 seconds)
Test Suite 'RobotNameTests' passed at 2022-05-07 14:22:16.289
Executed 4 tests, with 0 failures (0 unexpected) in 0.004 (0.004) seconds
Test Suite 'debug.xctest' passed at 2022-05-07 14:22:16.289
Executed 4 tests, with 0 failures (0 unexpected) in 0.004 (0.004) seconds
Test Suite 'All tests' passed at 2022-05-07 14:22:16.289
Executed 4 tests, with 0 failures (0 unexpected) in 0.004 (0.004) seconds
This appears to be a problem with the test code rather than my own code.
Also, when I tried with a different submission using String.padding it says String has no member padding which doesn't sound right.

Thank you for filing this.  Making a note here so that it more directly alerts me when activity occurs.

@stt106 Would you be willing to submit a PR? The code can be found here: https://github.com/exercism/swift/blob/main/exercises/practice/robot-name/Tests/RobotNameTests/RobotNameTests.swift#L41

There is nothing critical here, it's just a warning, not an error.
About String.padding: you need to import Foundation.

@2Grey  I know it's a warning but the online editor considers it as an error and blocks my submission.

@stt106 Would you be willing to submit a PR? The code can be found here: https://github.com/exercism/swift/blob/main/exercises/practice/robot-name/Tests/RobotNameTests/RobotNameTests.swift#L41

Will try when time allows.


[web] release build not running

I get an error when I try to run flutter web in release mode (both local and hosted with firebase). It works in debug mode.
Error while fetching an original source: NetworkError when attempting to fetch resource.
Source URL: org-dartlang-sdk:///sdk/lib/_internal/js_runtime/lib/js_helper.dart

I do not get any outputs other then the error above from the browser console.

Duplicate of #49500 #issuecomment


main_2024.py detect target

Checked detect target worker integration in main_2024.py.
What changed

Changed return type to Detections and Time
Added CLI option to display annotated image

Files changed

main_2024.py
detect_target.py
detect_target_worker.py

Reviewed. The tolerances may need to be relaxed, since the unit test isn't passing on GitHub.

Ya it's weird because the tests pass on my computer. Maybe it has something to do with the override precision?


"Status: Host is powered off" in Compute -> Nodes

Hi,
4.3.0-0.okd-2019-11-15-182656 on vSphere.
In Menu 'Compute -> Nodes' in column 'Status': alle Nodes have status "Host is powered off" but obviously they aren't.
Greetings,
Josef

Fixed in https://github.com/openshift/console/pull/3283

Thx.


Remove from 01

Removing remove_from work
This exposed several problems:

union in FROM doesn't set outputs of second and subsequent selects which results in
accessing null input rows and exception.
conflicting output names in the final query.
more renamed columns than the output columns. Probably related to (2).
Can't bind column e1 to table.
table scan having a filter requiring columns of two tables. This works if unnesting is enabled.
tpcds/q23.sql. PhysicNode x) Line 88
genuine group by expression raising error as non grouping expression.
The failing query is:
select d1, sum(d2) from (select c1/2, sum(c1) from (select b1, count(*) as a1 from b group by b1)c(c1, c2) group by c1/2) d(d1, d2) group by d1;

This checkin contains fix for (7). Other problems will be resolved one after another as separate fixes.
This pull request is only for code review not an actual merge request.
All tests affected by change of query plan are updated (except) Cardinality test.
The fix is to remember the last position of output required by the parent, it is not an error
if the offending occurs after this position.

6 tests failed - is that expected?

Yes they are expected failures. The exact list I know is as follows:
Failing queries:
select count(c1), sum(c2) from (select * from a union all select * from b) c(c1,c2);
select * from (select * from a union all select * from b) c(c1,c2) order by 1;
select max(c1), min(c2) from(select * from(select * from a union all select *from b) c(c1, c2))d(c1, c2) order by 1;
Reason:  union in FROM. Only first select has output set, others produce no output which results in accessing null at execution time.
select b1+c100 from (select count() as b1 from b) a, (select c1 c100 from c) c where c100>1;
select a.b1+c.b1 from (select count() as b1 from b) a, (select c1 b1 from c) c where c.b1>1;
Reason: count(*) on scan node. I will fix this today.
select a1,a2,b2 from b, a where a1=b1 and a1 < (select a2 from a where a2=b2);
Reason:  conflicting output name c2 is not allowed. It fails only from test framework. It works from command line. I just noticed this difference. It might be because in command line enable_subquery_unnest_, enable_cte_plan_, use_memo_ are set to true, along with remove_from.
I think enable_subquery_unnest_=true "corrects" the plan, as you said, this "correction" may actually be hiding a bug elsewhere.
select b.a1 + b.a2 from (select a1 from a) b
This is a genuine error.  This should work if all derived tables name their columns, as follows:
SELECT e1 FROM ( SELECT d1 FROM  ( SELECT sum(ab12) FROM ( SELECT e1 * b2 ab12 FROM ( SELECT e1 FROM ( SELECT d1 FROM ( SELECT sum(ab12) FROM ( SELECT a1 * b2 ab12 FROM  a JOIN b ON a1 = b1) b(ab12)) c(d1)) d(e1)) a(e1) JOIN b ON e1 = 8*b1) b(ab12)) c(d1)) d(e1);
But this also fails because it triggers the assertion "Debug.Assert(!list.Contains(null));" in reqlistGetAggrRefs method.
select a1 from c,a, b where a1=b1 and b2=c2 and a.a1 = (select b1 from(select b_2.b1, b_1.b2, b_1.b3 from b b_1, b b_2) bo where b2 = a2 and b1 = (select b1 from b where b3 = a3 and bo.b3 = c3 and b3> 1) and b2<5) and a.a2 = (select b2 from b bo where b1 = a1 and b2 = (select b2 from b where b4 = a3 + 1 and bo.b3 = a3 and b3> 0) and c3<5);
Minimal repro which has no result set:
select b1 from(select b_2.b1, b_1.b2, b_1.b3 from b b_1, b b_2) bo(b1, b2, b3) where b2 = b3 and b1 = (select b1 from b where b3 = bo.b3 and bo.b3 = b3 and b3> 1);
Reason: Bad plan. A join filter is needed on b_1 and b__2 but without unnesting enabled the plan has non-join filter on b__2, requiring columns from b_1 and b__2.
tpcds/q23.sql. I haven't looked into exact reason this is failing. It triggers the assert "Debug.Assert(!mustHaveOutput.Contains(phyType) || VisitEachExists(x => x is PhysicNLJoin));" in PhysicNode, line #88

Should I comment out the tests known to fail in remove_from_01 branch

By default, we shall pass all tests at merge time.


Allow to use file: directive for requirements.

Fix #1074.

I think there are some important design considerations that first need to be addressed. I've raised those in the parent ticket. I'm going to close this PR for now, but hang onto it as it may form the basis for an acceptable solution once the design concerns are addressed.


Sleep in Graph Generation Test

There wasn't any sleeping in the graph generation test. I'm not sure why it didn't give us problems before, but it is now. This PR adds a quarter second sleep between starting the server and using it.

@rebeccaskinner increased. It passes, etc.


Build Setting for Configuration

Is it possible to read a build setting for a specified configuration?
xcproj read-build-setting PRODUCT_BUNDLE_IDENTIFIER -c=Release

same issue

I haven’t tagged a new version yet but it’s available on develop since 22e509d7c0929d7858bfecbcda46790086b45e74.

The --configuration option is now available in version 0.2.


How to solve tabindex etc deprecations?

Now that ember-bootstrap has deprecated <el.control @tabindex="1"> in favor of passing the raw HTML attribute tabindex, deprecations are thrown when using this addon. It does not seem to be possible to remove the @ because the arg needs to be passed into power-select. Any advice on getting around these deprecations? Will this addon be updated to support the same syntax as ember-bootstrap?

Are you using the latest release (2.0) of this addon? #89 applies ...attributes to the power-select component, so if power-select itself applies the attributes correctly, I would expect it to work!?

@simonihmig power select does not apply the attributes though, is what I suppose I am getting at. They have to be passed as arguments for power select to apply them.

There is an ...attributes in power select, but I don't think it does what we think https://github.com/cibernox/ember-power-select/blob/v3.0.6/addon/templates/components/power-select.hbs#L16
disabled has a separate value set here https://github.com/cibernox/ember-power-select/blob/v3.0.6/addon/templates/components/power-select.hbs#L32
And the same with tabindex https://github.com/cibernox/ember-power-select/blob/v3.0.6/addon/templates/components/power-select.hbs#L12
I think we are going to have to allow @ for attributes when the controlType is power-select or they are not going to be applied.
cc @jelhan

@rwwagner90 are you sure that <el.control @tabindex="1"> does trigger a deprecation?
<form.element @type="power-select" @tabindex="1"> should, but IIRC the yielded el.control should actually not (for internal reasons).

Haven't considered that some plugins may need that arguments to be honest. But at least for Power Select that is hopefully fixed upstream soon. The limitation is tracked in this issue https://github.com/cibernox/ember-power-select/issues/1203 and a pull request is provided in https://github.com/cibernox/ember-power-select/pull/1331. I would ignore the deprecation until that landed.
@simonihmig I think we should make sure that using HTML attributes is supported by Power Select before releasing v4.

same issue with @placeholder

@jelhan I think my recommendation would be to update this addon to pass through the attributes as if they were arguments. Then we could enforce passing them as attributes to this addon, and it would change them back to args. So internally you would, I think, have to do something like this to pass to power-select:
@placeholder={{attributes.placeholder}}

As far as I know the attributes passed in with angle bracket invocation couldn't be accessed from within a component.

@jelhan so ..attributes is the only way to use them?

@jelhan so ..attributes is the only way to use them? If so, we probably need to make this addon not require everything to be attributes.

As far as I'm aware: yes.

I think this has been fixed upstream. Please let me know if it is still an issue.


Unable to access speaker

While I am running the executable file getting error like Unable to access speaker and WebSocket. How to resolve this error can someone  help me to resolve this error.
while trying to run demo application provide by aws chime
/my_cli --attendee_id=<ATTENDEE_ID> --audio_host_url=<AUDIO_HOST_URL> --external_meeting_id=<EXTERNAL_MEETINIG_ID> --external_user_id=<EXTERNAL_USER_ID> --join_token=<JOIN_TOKEN> --log_level=<LOG_LEVEL> --meeting_id=<MEETING_ID> --signaling_url=<SIGNALING_URL> --send_audio_file_name=<SEND_AUDIO_FILE>
Error Logs
attendee Name: aa
Attendee ID: xxxx
Meeting Name:
Meeting ID: aaaaaa
Audio Filename: k_16bit.pcm
Current Log Level: error
[INFO]: Creating DefaultSignalingClient
[INFO]: Creating WebsocketSignalingTransport
[ERROR]: (adm_helpers.cc:48): Unable to access speaker.
[ERROR]: (audio_device_generic.cc:18): BuiltInAECIsAvailable: Not supported on this platform
[ERROR]: (audio_device_generic.cc:28): BuiltInAGCIsAvailable: Not supported on this platform
[ERROR]: (audio_device_generic.cc:38): BuiltInNSIsAvailable: Not supported on this platform
Starting keypress handler
[2024/08/07 12:05:33:3666] E: Error while trying to connect the websocket: read failed
[ERROR]: Signaling has received error Error while trying to connect the websocket: read failed

Hi ,
we are trying to build in Linux, if we are not following the commands to set the Linux as true, it won't work. can you suggest step to overcome issue while building in ubuntu 22(Linux).

Hi ,
we are trying to build in Linux, if we are not following the commands to set the Linux as true, it won't work. can you suggest step to overcome issue while building in ubuntu 22(linux).

I have pushed a change that fixes most build issues and also adds a script chime-sdk-signaling-cpp/demo/cli/run_with_serverless_demo.sh that should bootstrap the demo better. You can try that branch as is or wait for it to reach main.
My guess is that the configuration was not set up correctly. I will also see if I can updated the demo/SDK to fail faster and with a clearer message.

if we are not following the commands to set the Linux as true

What is this in reference to?

As per your suggestion we made the changes in Cmake file but we are facing errors related to Protobuf. For your reference I have added the error screenshot.

Sorry for the possibly confusing suggestion. My changes/readme updates have been merged to mainline. Can you use those and try again? Additionally can you provide me the cmake command used to generate the files?

Now I am able to build using the latest readme file, but when running the demo application, I am getting an error related to the web socket. For your reference I have added the error screenshot.

Have you uploaded a Serverless demo and set the --url flag? You can alternatively run the browser demo (https://github.com/aws/amazon-chime-sdk-js/blob/main/demos/browser/README.md) and set --url to http://localhost:8080/, but I have not tried that myself. I will update the readme/script to make this easier to run after this issue is resolved.

Following the steps mentioned by you, I am able to overcome the WebSocket error, but the output window is not displaying for the same. For your reference I have added the error screenshot.

Can you upload full logs to this ticket? A few of those logs imply that you are connected.
By 'output window' i assume you mean that you have the browser demo open and joined to the same meeting. I assume you ensured that the --meeting value is the same as you picked in the browser demo? When you retest, can you also provide the meeting ID in the bottom left of the browser demo?

when we are executing below command it is not displaying any media control for audio and video window.
export SERVERLESS_DEMO_URL= # ...
./run_with_serverless_demo.sh --meeting test-meeting --attendee cli-attendee --url $SERVERLESS_DEMO_URL
In our case SERVERLESS_DEMO_URL is deployed in AWS which is providing browser demo and server.
For your reference I have added the logs below:
from the command --meeting and --attendee are not already created.

we are expecting audio and video controller by following this command export SERVERLESS_DEMO_URL= # ...
./run_with_serverless_demo.sh --meeting test-meeting --attendee cli-attendee --url $SERVERLESS_DEMO_URL
is it correct way or any different build is required?

I just ran the steps in the CLI README and did not have any issue.
It looks like WebRTC is failing to gather the TURN candidate. What platform are you using to build? Is this on AWS? Have you configured the network access properly?

I am trying to build SDK again on a different system. getting error as mentioned below:
-- Looking for HMAC_CTX_new
-- Looking for HMAC_CTX_new—not found
By following the below export command, it is reflecting the above error. Can you suggest how to resolve the same
export BORING_SSL_LIB=$CHIME_SDK_DEMO_DIRECTORY/webrtc-build/webrtc/out/Default/obj/libwebrtc.a
export BORING_SSL_INCLUDE_DIR=$CHIME_SDK_DEMO_DIRECTORY/webrtc-build/webrtc/third_party/boringssl/src/include

When we are running the cmake from this step Pull and build C++ SDK Signaling Client getting error related to websocket.

When we are running the cmake from this step Pull and build C++ SDK Signaling Client getting error related to websocket.

I just ran the steps in the CLI README and did not have any issue.
It looks like WebRTC is failing to gather the TURN candidate. What platform are you using to build? Is this on AWS? Have you configured the network access properly?

Here we need to initiate a call from the Ubuntu (Linux) and retrieve the call from the web application. How to check  configured the network access ?

-- Looking for HMAC_CTX_new—not found

Is not necessarily an indication of a failure unless you see other SSL issues down the line.

Here we need to initiate a call from the Ubuntu (Linux) and retrieve the call from the web application. How to check configured the network access ?

It depends on whether you are running on a local device or a cloud instance. This usually isn't relevant on a local device though.
For the rest of the issues, I cannot assist, unless you provide the actual text of the failure. Please run a clean build and redirect the output to a log file (e.g. cmake /* ... */ > ~/build.log 2>&1.

We are running the cloud instance. How to check the required configuration.
when we are performing this command  cmake -S . -B build
-DLWS_OPENSSL_LIBRARIES=$BORING_SSL_LIB
-DLWS_OPENSSL_INCLUDE_DIRS=$BORING_SSL_INCLUDE_DIR
-DLWS_WITH_BORINGSSL=ON
-DLWS_HAVE_OPENSSL_STACK=OFF
-GNinja
getting below errors.
-- Looking for openssl/ecdh.h
-- Looking for openssl/ecdh.h - found
-- Looking for SSL_CTX_set1_param
-- Looking for SSL_CTX_set1_param - not found
-- Looking for SSL_set_info_callback
-- Looking for SSL_set_info_callback - not found
-- Looking for X509_VERIFY_PARAM_set1_host
-- Looking for X509_VERIFY_PARAM_set1_host - not found
-- Looking for X509_VERIFY_PARAM_set1_host
-- Looking for X509_VERIFY_PARAM_set1_host - not found
-- Looking for RSA_set0_key
-- Looking for RSA_set0_key - not found
-- Looking for X509_get_key_usage
-- Looking for X509_get_key_usage - not found
-- Looking for SSL_CTX_EVP_PKEY_new_raw_private_key
-- Looking for SSL_CTX_EVP_PKEY_new_raw_private_key - not found
-- Looking for SSL_CTX_get0_certificate
-- Looking for SSL_CTX_get0_certificate - not found
-- Looking for SSL_get0_alpn_selected
-- Looking for SSL_get0_alpn_selected - not found
-- Looking for SSL_set_alpn_protos
-- Looking for SSL_set_alpn_protos - not found
-- Looking for EVP_aes_128_cfb8
-- Looking for EVP_aes_128_cfb8 - not found
-- Looking for EVP_aes_128_cfb128
-- Looking for EVP_aes_128_cfb128 - not found
-- Looking for EVP_aes_192_cfb8
-- Looking for EVP_aes_192_cfb8 - not found
-- Looking for EVP_aes_192_cfb128
-- Looking for EVP_aes_192_cfb128 - not found
-- Looking for EVP_aes_256_cfb8
-- Looking for EVP_aes_256_cfb8 - not found
-- Looking for EVP_aes_256_cfb128
-- Looking for EVP_aes_256_cfb128 - not found
-- Looking for EVP_aes_128_xts
-- Looking for EVP_aes_128_xts - not found
-- Looking for EVP_aes_128_ofb
-- Looking for EVP_aes_128_ofb - not found
-- Looking for EVP_aes_128_ecb
-- Looking for EVP_aes_128_ecb - not found
-- Looking for EVP_aes_128_ctr
-- Looking for EVP_aes_128_ctr - not found
-- Looking for RSA_verify_pss_mgf1
-- Looking for RSA_verify_pss_mgf1 - not found
-- Looking for HMAC_CTX_new
-- Looking for HMAC_CTX_new - not found
-- Looking for EVP_PKEY_new_raw_private_key
-- Looking for EVP_PKEY_new_raw_private_key - not found
-- Looking for SSL_SESSION_set_time
-- Looking for SSL_SESSION_set_time - not found
-- Looking for EC_KEY_new_by_curve_name
-- Looking for EC_KEY_new_by_curve_name - not found
-- Performing Test LWS_HAVE_SSL_EXTRA_CHAIN_CERTS
-- Performing Test LWS_HAVE_SSL_EXTRA_CHAIN_CERTS - Failed
-- Performing Test LWS_HAVE_EVP_MD_CTX_free
-- Performing Test LWS_HAVE_EVP_MD_CTX_free - Failed
-- Looking for ECDSA_SIG_set0
-- Looking for ECDSA_SIG_set0 - not found
-- Looking for BN_bn2binpad
-- Looking for BN_bn2binpad - not found
-- Looking for EVP_aes_128_wrap
-- Looking for EVP_aes_128_wrap - not found
-- Looking for EC_POINT_get_affine_coordinates
-- Looking for EC_POINT_get_affine_coordinates - not found
-- Looking for TLS_client_method
-- Looking for TLS_client_method - not found
-- Looking for TLSv1_2_client_method
-- Looking for TLSv1_2_client_method - not found

Those are not errors, just optional features that don't exist in boring SSL. I will update README to not call them out as fatal
Looking for openssl/ecdh.h - found

Btw you can upload text files to github instead of copy pasting :).

While I am executing the following command:. "/run_with_serverless_demo.sh --meeting 12 --attendee 2 --url $https://XXXXXX.execute-api.us-east-1.amazonaws.com/Prod/ "
application is executing, but the output of the browser is not displayed(video
videocall.txt
and audio controller of the caller ). For the same, I attached the logs. please check.

Can you please suggest how I can perform video call in Linux system using this same sdk? Can you please explain in brief the steps.

This is a low level component and thus does not currently have information on how to make a linux GUI, which is not straightforward to do or maintain. You need to also be familiar with how to use a WebRTC implementation, which is not bundled with the SDK, though we use it in our example.
Unfortunately i think you are asking for too much info outside the scope of this SDK. If you are a enterprise customer you can reach out to AWS premium support for more assistance.

While i am running the below command getting error:
cmake -S . -B build
-DLWS_OPENSSL_LIBRARIES=$BORING_SSL_LIB
-DLWS_OPENSSL_INCLUDE_DIRS=$BORING_SSL_INCLUDE_DIR
-DLWS_WITH_BORINGSSL=ON
-DLWS_HAVE_OPENSSL_STACK=OFF
-GNinja
Make Error: The source directory "/chime-sdk-signaling-cpp-demo/amazon-chime-sdk-cpp" does not appear to contain CMakeLists.txt.

You probably need to re-set CHIME_SDK_DEMO_DIRECTORY as described in the readme.


Support select a subset of features from a constructed dataset

Summary
Support select a subset of features from a constructed dataset.
lgb.Dataset.subset(used_indices: List[int], used_columns: List[str]=None, params=None) -> lgb.Dataset

Motivation
The Dataset object of LightGBM is awesome because it's super memory-efficient. So I build a workflow around the Dataset like this:

Construct Dataset from a huge dataframe with many features, via the lgb.Sequence API.
Train a LightGBM model on the Dataset, and select the top features from the huge dataframe.
Construct another Dataset on the selected dataframe.
Train a LightGBM model on the selected Dataset.

However, the step 2 and 3 require many I/O operations and become the bottleneck in my experiments, so I wonder if we can directly select a subset of features from a constructed dataset. If we have that API, the above workflow will be:

Construct Dataset from a huge dataframe via the lgb.Sequence API.
Train a LightGBM model on the Dataset, then select the top features from the Dataset directly and construct a new smaller Dataset.
Train a LightGBM model on the selected Dataset.

Description
I think this feature selection demand is common on handling huge number of features after a dataset is constructed. In my case, because the dataframe is too large to live in the RAM, it takes a long time to select the raw dataframe (~30 min) and reconstruct another dataset from it (~30 min), while the final training only takes about 20 min.
I've read through the existing parameters and APIs. And I think the closest 3 features are:

Dataset parameter: ignore_column. But it works only in case of loading data directly from text file. I've read the source code and it skips columns before constructing them.
Python API: lgb.Dataset.add_features_from(). But it can only add features, not remove features.
Python API: lgb.Dataset.subset(). But it only works for selecting rows, not columns.

I think it's reasonable to implement this feature as an optional argument for the existing .subset() API. So it looks like:
lgb.Dataset.subset(used_indices: List[int], used_columns: List[str]=None, params=None) -> lgb.Dataset

And a toy example will be:
df = pd.DataFrame(np.array([[1,2,3],[4,5,6]], columns=[f'feat_{i}' for i in range(3)])
dataset = lgb.Dataset(df).construct()
dataset_selected = dataset.subset(columns = ['feat_1', 'feat_3'])

Thoughts on implementation
On one side, I understand this request is non-trivial, because there are special handling on sparse features and catergorical features. In my case, all features are dense and numeric, so selecting some of them makes sense.
I think to support this API, we need at least to check that:
is_enable_sparse == False
enable_bundle == False

On the other side, I think the request is not impossible. Because AddFeaturesFrom in dataset.cpp has already implemented many functionalities like resize the feature_names and feature_map.

Hi, I found this request useful as well.
My main goal is to evaluate using a group field, similar to this issue posted here 4995.
My problem is that I want to ignore this additional "id" field in the attached post as it is not a feature I can train on.
As mentioned in this post and in your python package documentation:
"ignore_column  works only in case of loading data directly from text file" (which is not possible in my use of loading parquet files)
I Would appreciate your advice or a workaround for this issue.

Can we not do lgb.Dataset.data.drop(columns=[list of columns to remove])?


Linux Kernel versions

On the endoflife.date website it does not list all Linux kernel versions that are out there.  For example, v5.10 and v5.15 are listed, but v5.14 is not which is a fairly heavily used version in RHEL based distros.  I understand listing every single Linux version would make the website for Linux Kernel's very very long and probably unusable, but would it be possible to continue to have a limited subset on the website and expose all kernel versions through the API? Maybe have a flag for exposing all kernel, major, and minor versions.

Hi @mattboston, versions still widely used must appear on the page and be available from the API, no need for a flag IMO.
 I believe it's enough to have just RHEL over at https://endoflife.date/rhel
https://ciq.com/blog/why-a-frozen-linux-kernel-isnt-the-safest-choice-for-security/


Authentication

I'm using this library for a project and was wondering if you knew how I can implement authentication into it? Should I just drop the request if certain criteria doesn't match, other is there a better way to go about this?
Thanks,
Sam

It depends on how you plan to implement authentication really, do you want it to be with headers or just in the payload?


Bms

Add support for BQ78350 in the batt_smbus driver. Correct readings have been verified at different currents drawn from battery while logging.

All comments except unit testing should be resolved

Con lost messages tested by unpluggig and replugging BMS data cable to flight controller


no scheme found with name: X in workspace: X in version 2.4.16

Hi,
i use the xcode-archive 2.4.16 with the following setting:
- xcode-archive:
        inputs:
        - project_path: "$BITRISE_PROJECT_PATH"
        - xcodebuild_options: "-allowProvisioningUpdates -UseModernBuildSystem=NO"
        - configuration: Beta
        - export_method: ad-hoc

the step automatically throws the following error:
Exporting ipa from the archive...

Exporting ipa with ExportOptions.plist
No custom export options content provided, generating export options...
export-method specified: ad-hoc
no scheme found with name: XX in workspace: XX.xcworkspace

However, if i use version 2.4.15 the step is properly executed. Is it a bug or am i missing some configuration?

I downgraded to version 2.4.15 and it still fails.

Hi @v3n3 !
Sorry for the inconvenience.
We got reports about this issue from other users as well.
https://github.com/bitrise-io/steps-xcode-archive/issues/129
Could you please send us the last failed build's URL, and the .xcodeproj, .xcworkspace files of your project via the on-site chat?
It would help us figure out what is the problem.

Hi @GalKeidar10 !
Is your project's scheme shared?

Did the step work with an older version?

@BirmacherAkos Yes, everything is shared. and it did not work with 2.4.10

@BirmacherAkos same here

Same with us — our schemes are all shared, but 2.4.16 broke in the same way. Rolling back to 2.4.15 works for our project. I've reached out to Bitrise support.

One issue we encountered was that it was setting scheme/configuration incorrectly when running xcodebuild (version 10.0):
to be specific, if our env vars are set as follows:
BITRISE_SCHEME='MyScheme'
BITRISE_IOS_CONFIGURATION='MyConfiguration'

The build step runs with the following flags:
xcodebuild ... "-scheme" "MyScheme MyConfiguration" ...

It should be running the command with the following flags
xcodebuild ... "-scheme" "MyScheme" "-configuration" "MyConfiguration" ...

downgrading to 2.4.15 resolved this particular issue

@BirmacherAkos Same issue here. Downgraded to 2.4.15 which is working.

Hi @v3n3 ,
we released a new step version which fixes this issue: https://github.com/bitrise-io/steps-xcode-archive/releases/tag/2.4.17
I'll close this issue, but if you need more info/help just open a new issue!


Unarmed Feats

This package contains a few new unarmed feats. With the exception of Flying Kick and Zen Archery, all other feats are interacting with Stunning Fist Charges. Due to this, I created a Stunning Fist Extender and reworked Extra Stunning to work with the new extender. I think @doug1234 originally did Extra Stunning. The idea behind the new extender is basically to work like turn undead feat interaction.
The new Stunning Fist Extender does:

ET_OnNewDay queries for for charge-increasing feats and adds them to the number of daily charges
Reacts to a Python Signal to reduce Charges of Stunning Fist
Answers to a Python Query that asks for remaining charges
Adds a tooltip for remaining charges (mouseover only)

Charge Increasing Feats:
Basically all Feats from the PHB II increase Stunning Fist charges by one and Extra Stunning by 3 (the latter can be taken multiple times)
New Feats:

Axiomatic Strike
Fiery Strike
Fiery Ki Defense
Fists of Iron
Flying Kick
Freezing the Lifeblod
Ki Blast (Missing)
Zen Archery

I will add the missing feats on monday, ran out of time, but I'd like to get a feedback if the changes to the Stunning Fist/Extra Stunning are ok.

Good stuff!  I totally agree with what you have here.  I wish I had done stunning fist the same way I did turn undead initially.

Sadly Ki Bolt is still missing, will add it tomorrow. On the plus side, I sneaked in Zen Archery :)

Added Ki Blast
This packages is now finished, barring the below listed Known Issue.
Known Issues:
Ki Blast spell doesn't end properly, though I do not know why. In OnEndProjectile spell_end is called properly, spell.target_list is empty and that point and number of projectiles reduced to 0.
Ki Blast could benefit from a code review.

Ok, so I replaced Stunning Fist. Side effect bonus: Stunning Fist does not trigger an full attack anymore, so now you can choose to just do a single attack and then move afterwards. Ofc you still can trigger a full attack normally after activating Stunning Fist.
I am unsure what bug @dolio was referring to, so I am not sure it is fixed by the redo.

@doug1234 fyi I switched Brutal Throw to use integer 180 instead of 0 as bonus_type so it will not stack with Zen Archery
Bonus I added a help file entry for Burtal Throw and Power Throw :)

Sounds good.  I agree with the change to brutal throw and thanks for adding the help entry.


command-working-directory is not obeyed

Example:
[
        {
                "id": "runscript",
                "execute-command": "/path/to/script.sh",
                "command-working-directory": "/tmp",
                "pass-environment-to-command": [
                        {
                                "source": "payload",
                                "name": "env1",
                                "envname": "ENV1"
                        },
                        {
                                "source": "payload",
                                "name": "env2",
                                "envname": "ENV2"
                        }
        }
]

script.sh
#!/bin/sh
pwd

In my log, I see the following
[webhook] 2020/09/24 16:09:40 [d92f25] executing /path/to/script.sh (/path/to/script.sh) with arguments ["/path/to/script.sh"] and environment [ENV1=a ENV2=b] using /path/to as cwd
/path/to

This is with the latest version of webhook: 2.7.0

sorry, my bad! I had been editing the wrong hooks.json. Turns out that there is no problem with command-working-directory. 👍


Allow inheriting Furo as a Sphinx theme

To inherit Furo, the new Sphinx theme needs to call the setup code from furo/__init__.py's setup. See https://github.com/pradyunsg/furo/pull/648 for an example.
However, currently, these setup helper functions will not run if the theme is not set to Furo. (That's a good default behavior because it avoids Furo doing undesired things when you have Furo installed but aren't actually using it.)
So, this adds the argument validate_furo: bool = True to both _html_page_context and _builder_inited. That allows plugins to use functools.partial to set the argument to False, as done in https://github.com/pradyunsg/furo/pull/648.
The default behavior is unaffected because the default is set to True.

Superseded by https://github.com/pradyunsg/furo/commit/48c0bf2aa983fb1ccd79b4167fe85387249afedf. Thank you! 🎉


Feature request: preview elm-doc document comment locally

Current Elm-tool chain lacks the way to preview document comment of elm source, locally and quickly.
You can extract information from Elm source to a json file by elm-doc command, but to view it, you have to publish the Elm project includes the newest json to github and change and run catalogs in elm-get as an Elm program in some way. If you want to check document before release, it is inconvenient.
I wish we could preview document in easy and quick way, and locally (before push to github).

Agreed; a way to generate the HTML locally would be useful.

It should be easier with how things work on package.elm-lang.org now. All the pages are .elm files that bring in some JSON (like this one), so I think it's plausible to break that out into a thing that generates HTML for anyone. Perhaps package.elm-lang.org could just be a consumer of that tool rather than owning it?

I added this project to this list https://github.com/elm-lang/projects so that someone can potentially get to it before me!

Thanks!

I'm gonna close this issue because this repo will never resolve it. I think it's possible to generate docs with the existing elm-doc tool. It will spit out everything as JSON, so someone can create a little tool that formats that into an HTML page. I think that is a plausible way to go.


Adds detection logging messages at info level

Summary
This PR adds additional logging when Detect returns false for this buildpack. This is to provide more information about why the detection failed for this buildpack when verbose/debug logging is enabled.
As of lifecycle v1.16.0, if the detect phase fails as a whole, log messages are printed at info level by default, without the need for the verbose flag.
Use Cases

Checklist

[ ] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[ ] I have reviewed the styleguide for guidance on my code quality.
[ ] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

can you please the confirm the integration tests fail because of a failure to retrieve the an apache archive? it's not super obvious to parse :-/ thank you


Allow jobs that will never fire to appear at /sidekiq/cron

Hello @ondrejbartas,
Thank you for the gem =)
Here's my request:
I have a schedule.yml
never_fire_job:
  cron: "0 0 31 2 *" # At 00:00 on 31 Feb. It will never run
  class: "OneWorker"

two_job:
  cron: "0 0 * * *" # everyday at 00:00
  class: "TwoWorker"

Notice that never_fire_job's corn will never run, because of of 31 Feb.
But I notice that at http://mydomain.com/sidekiq/cron, never_fire_job does not appear.
How can i make the never_fire_job appear at http://mydomain.com/sidekiq/cron?

@chongivan consider adding status: "disabled" to the never_fire_job's configuration. It'll still show up, but won't ever run. This setup allows the gem to continue checking the cron string for validity.


path sqlite | question

Hello, I have a question. I have an external database, which path I need to specify in the "path" configuration

Can you be more specific? Is the DB sitting on the same machine? What is the OS? Can you access the file from the web host using OS commands or do you need to do some kind of FTP?

Hi, the path configuration is only for SQLite. The Minecraft server with .db file must be on the same server as the webserver to use the path option.
If you're using MySQL, you do not need to configure path, as this will be ignored.
Let me know if this clears it up. Thanks!

Hi, the path configuration is only for SQLite. The Minecraft server with .db file must be on the same server as the webserver to use the path option.
If you're using MySQL, you do not need to configure path, as this will be ignored.
Let me know if this clears it up. Thanks!