Implement Navbar Component

Please do work for this task in a branch named issue-9.

I added the logo, and changed the Add & List "Stuff" to "Courses".


Template validation error for evaluated variables

The following template causes two template validation errors with ARM Tools v0.8.1. The validation errors are against the template object, not the specific place where the error occurs.
1.) The template variable "default" is not found. We do not reference a variable called default.
2.) If a variable called default is created, a new validation error occurs, "The template variable NSGRules is not valid. The language expression property "WebPorts" can't be evaluated.
Template:
{
    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {
        "Environment": {
            "type": "string",
            "metadata": {
                "description": "Name of the Environment"
            }
        }
    },
    "variables": {
        "PRD": {
            "WebPorts": [
                "8510",
                "8520",
                "8530",
                "8540",
                "8550",
                "8560"
            ]
        },
        "TST": {
            "WebPorts": [
                "8010",
                "8020",
                "8030",
                "8040",
                "8050",
                "8060",
                "8510",
                "8520",
                "8530",
                "8540",
                "8550",
                "8560"
            ]
        },
        "NSGRules": {
            "WEBNSGRule": [
                {
                    "name": "[concat('Allow-In-',variables(parameters('Environment')).WebPort[1],'-To-Web')]",
                    "properties": {
                        "access": "Allow",
                        "direction": "Inbound",
                        "priority": 101,
                        "protocol": "*",
                        "sourcePortRange": "*",
                        "sourceAddressPrefix": "VirtualNetwork",
                        "destinationAddressPrefix": "VirtualNetwork",
                        "destinationPortRange": "[variables(parameters('Environment')).WebPort[1]]"
                    }
                }
            ]
        }
    },
    "resources":[]
}

I know this is an odd example, we do a lot of dynamic generation of rules based on parameters and this is just a contrived example.
Running:
Test-AzDeployment -TemplateFile .\Test.json -Location uksouth -TemplateParameterObject @{Environment="PRD"} -Verbose
is successful, as is running a real deployment.
Thanks.

That's pretty weird, but we essentially understand the problem and are looking at solutions.  Thanks for letting us know!

https://dev.azure.com/devdiv/DevDiv/_boards/board/t/ARM Template Authoring/Stories/?workitem=1017615

This was fixed by https://github.com/microsoft/vscode-azurearmtools/pull/383 and was released as a hotfix today as 0.8.2.

Thanks a lot for sorting so quickly.


Use C++ linker when building with libicu

ICU is a C++ library, event though it has C interface. This means that it depends on C++ standard library internally. When ICU is built as dynamic library we can link to it using C linker without issues because it is already linked to C+ standard library (I'm not sure how portable is this but it works). However, if ICU is built as static library, we must link to C++ standard library manually or use C++ linker, or else we will get linking errors.
This commit does this for Meson. I'm not sure how to do this properly for autotools (I was able to find this in the automake manual though).

Thank you !


Fix Makefile syntax

Closes #25.
cc @SuperQ @johanneswuerbach

It seems that we still have an issue with the images. They're all labelled for amd64 architecture. @johanneswuerbach any idea?


(Internal Compiler Error) Sanity check failed for collapseProperties?

This issue was imported from Closure Compiler's previous home at http://closure-compiler.googlecode.com
The original discussion is archived at:
http://blickly.github.io/closure-compiler-issues/#1012

The code is:
// crash.js
var ss = {};
ss.isUndefined = function ss$isUndefined(o) {
	return (o === undefined);
};

Repro command:
java -jar build/compiler.jar  -O ADVANCED --jscomp_dev_mode=EVERY_PASS --js crash.js

Likely fixed by now.
https://closure-compiler-debugger.appspot.com/#input0%3Dvar%2520ss%2520%253D%2520%257B%257D%253B%250Ass.isUndefined%2520%253D%2520function%2520ss%2524isUndefined(o)%2520%257B%250A%2520%2520%2520%2520return%2520(o%2520%253D%253D%253D%2520undefined)%253B%250A%257D%253B%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_SYMBOLS%3D1%26CHECK_TYPES%3D1%26COLLAPSE_PROPERTIES%3D1%26LANG_IN_IS_ES6%3D1%26MISSING_PROPERTIES%3D1%26PRESERVE_TYPE_ANNOTATIONS%3D1%26PRETTY_PRINT%3D1%26TRANSPILE%3D1

@MatrixFrog I think you need --jscomp_dev_mode=EVERY_PASS to trigger yet. It was still crashing for me yesterday.


Downloading jar-with-dependencies from Maven using gradle

Is this even possible?
I tried many variants, and with no luck. Is there a way to do it?

As soon as I get a chance I'll add an example of how to do this.

Have you checked to correctly use a classifier for downloading that artifact in Gradle? Would you like to download the artifact only ? I can remember there is something like `"groupId:artifactId:version:classifier@jar" (for the classifier I'm not sure).

I have now added documentation for this, the website will be updated in the next few days when the next release is done.


Response: Missing functionality

Following problems were identified:

At the moment we have no methods to get Status Line (no methods to get status code, only via variable response.status.code - is it needed?)
Not possible to send Form Params with POST request
No dark methods to get body (only if use public ‘body’ field)
No dark methods to parse body as xml, json, html, get asByteArray/InputStream etc. All possible only via raResponse() method that redirects to RestAssured methods.

Expected:

Check if every bullet is actual and cannot be resolved with existed framework API
Find solution for every identified problem remaining in list
Discuss proposed solution w/Team if someone from review team agrees, create a dedicated task for implementation  and link it to the current issue (that include implementation of the proposed solution, test covering and documentation creation)

Demo has been done.


bug: On clicking View content it doesn't open

Describe the bug
On clicking on the "View Content" button of Harnoor Android course and ML + MLOps course it redirects to https://harkirat.classx.co.in/
To Reproduce
Expected behavior
It should open the course content
Screenshots or GIFs

Browser [e.g. chrome]
Version [e.g. 22]

This bug I have also faced
@Abhijit-Jha For now you can go to link
view content -> view details -> at last you would see both course

@t007rushi I perform the same steps you mentioned. Thanks.
but I thought it should be resolved, so I raised the issue.

I don't thinks it's a bug, He just redirected it to the where we can actually view there videos. I guess for now only we can play Harkirat's videos in app.100xdevs.com

While resolving this issue, I noticed that the videos from these two courses are not playable on the app.100xdevs.com video players. I suspect it's due to an authentication-related issue with classx, which redirects users to the classx website.

For now, you can follow these steps:

Visit https://harkirat.classx.co.in/
Navigate to your purchased course (select the course you purchased from the listed options).
Scroll down to find the courses.

Yes doing that only lastly @SOUMITRO-SAHA


https://frigg.io/docs/ is broken

Since we moved the documentation to the landing page that link has not worked. We could add a redirect, if we should please open an issue on the frigg.github.io :)


MCC calculations

Yair,
Do you think that you will post an update to correct how the MCC is calculated on the test set?  (see my comments in this issue: https://github.com/kuleshov-group/caduceus/issues/38)
it would be so helpful.
Thank you
LeAnn

It would also be so useful to have all of the performance metrics instead of just one (ie accuracy MCC, f1 precision, recall)

I don't think we planned on updating the dataloader there, but it seemed like in #38  that you had resolved the issue. Do you want to open a PR here with you fix?

I don't think it is necessary, as long as you shuffle the test files then the problem does not occur. It is only a problem in the Genomic Benchmark fine tuning because their test files are not shuffled.


COO-451: fix: use expected plugin console names

This PR uses the plugin names the console expect so the routing for resources and proxies works correclty

/hold cancel


Consider CLI mode

It might be useful to have a cli mode.
Something like:
> impact https://example.com/api/pokedex --term "Pikachu" --properties "name"

I'm gonna close this issue. This plugin will not offer the ability on cli mode to search without the explicit use of Lyra.


huemagic only for hue bridge?

Does huemagic only work with a Hue Bridge or even with virtual bridges like Phoscon? If not, could you please patch this up?
I own many Hue devices, but these are connected via phoscon and not with a Hue Bridge. Phoscon also offers the possibility of a virtual button push.

Please try it out with your virtual bridge. I never heard about "phoscon", but if it imitates the official Hue Bridge and it's API, then I don't know why this shouldn't work with HueMagic.
Let us know if it worked :)!

I pressed the connect button in the Phoscon app. This is the equivalent of the Hue button. An API key was automatically obtained. Nevertheless, I get the error message "The selected Hue Bridge is invalid"

As long as your virtual bridge is supporting the latest CLIP/V2 API from Philips Hue, it shouldn’t be the case any longer.


Move copyright addition so that it is above the terms and it is clear that the same terms apply

Thanks

I'm going to hold off on this, because really, I don't want to leave the choice to use GPL in there.  In fact, my modifications are exclusively under the Less License.
And that leading text is incorrect as well, because the README file doesn't contain anything about licenses... in fact with the rename there is no more README.md.
My inclination is to just provide new boiler plate.  I want to edit the README.less file a bit, because its now entirely misleading; it may be better to just rip it out.

You know what, I've changed my mind on this... I'll go ahead take your commit as is.  I'm going to follow up with some fixes to the README files though.

Rebased as:
commit ce585c0f37c53c8f596e82d2abcd2872a4650ca5
Author: Nicholas Marriott<EMAIL_ADDRESS>Date:   Fri Nov 6 15:39:53 2015 +0000
Move copyright addition so that it is above the terms and it is clearer that
the same terms apply.


Improve grammar

This was fixed in a previous patch but was accidentally undone when a later patch was applied.

...as noted in https://github.com/gbdev/pandocs/pull/129#issuecomment-778705393 :p


shaka-player works when loaded from localhost, but not when loaded from another machine

Have you read the FAQ and checked for duplicate issues:
What version of Shaka Player are you using: 2.1.0-debug, also tried on 2.1.x branch
Can you reproduce the issue with our latest release version:Yes
Can you reproduce the issue with the latest code from master:Yes
Are you using the demo app or your own custom app:demo app
If custom app, can you reproduce the issue using our demo app:NA
What browser and OS are you using:Chrome on Linux and MacOS
What are the manifest and license server URIs:
(you can send the URIs to<EMAIL_ADDRESS>instead, but please use GitHub and the template for the rest)
What did you do?
git clone https://github.com/google/shaka-player.git
cd shaka-player
python build/all.py
cd ..
sudo cp -R shaka-player /var/www/html
load the URL: http://localhost/shaka-player/support.html -> shows that Widevine is supported
try to load the URL from another machine : http:///shaka-player/support.html -> shows that Widevine is not supported
Looks like some javascript works when loaded from localhost but not from another machine
What did you expect to happen?
shaka player should work from localhost and any other machine
What actually happened?
worked on localhost (Widevine menu items enabled), but does not work on another machine (Widevine menu items grayed out)

@prasadkhambete What happens if you try accessing it via https (your example is using http)?

@vaage - Yes, it seems to work when accessed through https. This is not convenient though, because it requires additional steps to set up ssl for apache2 (apt-get install ssl-cert; a2enmod ssl; a2ensite default-ssl) - Why does it work through https but not http ?

@prasadkhambete, this https requirement is outside of our control.  The EME spec states that EME is only available from a secure context (https or localhost).  We just today added a new FAQ entry about this, closing #867.  The new entry will appear in the nightly build in a few hours, but I have reproduced it here for your convenience:
EME and http URLs
EME requires a secure URL to use.  This means you have to use https or be on localhost.  Currently only Chrome enforces it, but other browsers will in the future.  Also, because of mixed content requirements, if your site is using https, then your manifest and every segment will also need to use https too.
See: Chrome's announcement, Firefox's intent to remove, and how to disable for testing.

Does this help?

@joeyparrish - yes that makes it clear.Thanks! We will transition to use https for our internal test servers. The Chrome browser option to disable secure origin requirement for testing is useful, and will help in the mean time with test servers from external third parties (serving test content on the web) until they get transitioned to use https instead of http

Glad we could help!  Feel free to comment if you need anything else on this topic, and we can reopen the issue if needed.


[Typed throws] Properly reabstract closure types with originally-indirect errors

Big thanks to @rjmccall for helping me debug this

@swift-ci please smoke test

Only the last commit is new, on top of https://github.com/apple/swift/pull/69758


Add server side render

I think we need SSR to seo...

same issue.

there is currently no plan to do it


feat(web): Set musicbrainzid as parameter for MagicISRC

Same as https://github.com/kepstin/magicisrc/pull/15.
This prevents false positives on browsers that remove trackers in URLs

Thank you, the change itself is trivial enough.
When I tested this change, I noticed that the MagicISRC website seems to rewrite the alternative parameter name musicbrainzid to the problematic mbid immediately after the page loads...
Have you tested whether this actually solves the problem for your browser? I can't test this myself as I never had this issue, but it looks like the updated MagicISRC may only delay the problem.

I just tested the live version which is different from my PR, and it does works.
The only bug is after login in MusicBrainz, the redirection also glitches out. I'll try another PR, but this one is good to go


Update Go dependencies to 1.31

Major chains:

The Fake client was deprecated, just move to the new one. This triggers one error in our test since it starts populating more fields and we did a Diff on it
Workaround https://github.com/kubernetes/kubernetes/issues/126664
Workqueue types are deprecated. Currently we are explicitly using multiple different types, so explicitly [any] type them

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
64c85f1a4953d3d749be1a73175c537cd0307704
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
64c85f1a4953d3d749be1a73175c537cd0307704
link
true
/test lint

gencheck_istio
64c85f1a4953d3d749be1a73175c537cd0307704
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
64c85f1a4953d3d749be1a73175c537cd0307704
link
true
/test gencheck

lint_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test lint

gencheck_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test lint

gencheck_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test gencheck

unit-tests_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test unit-tests

unit-tests-arm64_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test lint

unit-tests_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test unit-tests

unit-tests-arm64_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test unit-tests-arm64

gencheck_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test unit-tests

unit-tests-arm64_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test unit-tests-arm64

gencheck_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test gencheck

lint_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
e43baf2f10493d28bf2412910715da5f8d175196
link
true
/test unit-tests

gencheck_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test gencheck

lint_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test lint

unit-tests-arm64_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test gencheck

lint_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test lint

unit-tests-arm64_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test unit-tests-arm64

unit-tests_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test gencheck

lint_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test lint

unit-tests-arm64_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test unit-tests-arm64

unit-tests_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test unit-tests

integ-security-istiodremote_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test lint

unit-tests-arm64_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test unit-tests-arm64

unit-tests_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test unit-tests

integ-security-istiodremote_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test integ-security-istiodremote

gencheck_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test unit-tests-arm64

unit-tests_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test unit-tests

integ-security-istiodremote_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test integ-security-istiodremote

gencheck_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test gencheck

lint_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test unit-tests-arm64

integ-security-istiodremote_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test integ-security-istiodremote

gencheck_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test gencheck

lint_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test lint

unit-tests_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
43bdbed462ca68f0799625a5210660318146e941
link
true
/test integ-security-istiodremote

gencheck_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test gencheck

lint_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test lint

unit-tests_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test unit-tests

unit-tests-arm64_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test unit-tests

unit-tests-arm64_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test unit-tests-arm64

gencheck_istio
8330af91cff8ed7fcb91f5cef5db56475ecf86cf
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
5ac1d3bad16e0e0da9aac68b8f526a49f91a1561
link
true
/test unit-tests-arm64

gencheck_istio
8330af91cff8ed7fcb91f5cef5db56475ecf86cf
link
true
/test gencheck

unit-tests_istio
8330af91cff8ed7fcb91f5cef5db56475ecf86cf
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
8330af91cff8ed7fcb91f5cef5db56475ecf86cf
link
true
/test gencheck

unit-tests_istio
8330af91cff8ed7fcb91f5cef5db56475ecf86cf
link
true
/test unit-tests

unit-tests-arm64_istio
8330af91cff8ed7fcb91f5cef5db56475ecf86cf
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test unit-tests-arm64

lint_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test unit-tests-arm64

lint_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test lint

integ-ambient_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-ambient

gencheck_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test gencheck

integ-cni_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-basic-arm64

unit-tests-arm64_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test unit-tests-arm64

lint_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test lint

integ-ambient_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-ambient

integ-cni_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-cni

integ-pilot-multicluster_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-pilot-multicluster

integ-telemetry_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-telemetry

integ-security_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-security

integ-telemetry-discovery_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-telemetry-discovery

integ-ds_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-ds

integ-telemetry-istiodremote_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-telemetry-istiodremote

integ-security-istiodremote_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-security-istiodremote

integ-pilot-istiodremote_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-pilot-istiodremote

integ-distroless_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-distroless

integ-ipv6_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-ipv6

integ-pilot_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-pilot

macbuildcheck_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test macbuildcheck

integ-pilot-istiodremote-mc_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-pilot-istiodremote-mc

integ-helm_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-helm

integ-security-multicluster_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-security-multicluster

release-test_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test release-test

unit-tests_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test unit-tests

integ-telemetry-mc_istio
0bd79b3dc8b8e87b1fb7a012044f8eace7c14afe
link
unknown
/test integ-telemetry-mc

gencheck_istio
fabb6094b3bfe648ccdb4bfccaf46bb0a926ae1f
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


Elyra does not redirect to the correct URL after submitting a pipeline run

Description of problem:
After submitting a pipeline run, Elyra will show a popup with a link to the run details:

The URL in Run Details is: https:///pipelineRuns/luca/#/runs/details/
However, when clicking this link, the Dashboard page that loads is the main Runs page of the DS Pipelines section:

I noticed that moving between the Scheduled and Triggered pages did not change the URL of the page, and in fact the URL could be trimmed down to [https:///pipelineRuns/luca/] and we would be looking at the same page(s).
When clicking the name of one of the Triggered runs, we get sent to the actual Run details page of that run, and this is the URL that is used: https:///pipelineRuns/luca/pipelineRun/view/ (notice that the run ID from the first URL is the same here, assuming we're looking at the same run)
Prerequisites (if any, like setup, operators/versions):
RHODS 1.28 RC
Steps to Reproduce
Spawn image with Elyra
Submit pipeline run
Click on Run Details link in success popup
Actual results:
You are redirected to "main" page of DS Pipelines Runs for your project
Expected results:
You are redirected to the run details of the run you submitted
Reproducibility (Always/Intermittent/Only Once):
Always
Build Details:
Workaround:
Go to Triggered -> Last pipeline run manually
Additional info:
The fact that the URL https:///pipelineRuns/luca/#/runs/details/ does not uniquely identify a page and is equivalent to [https:///pipelineRuns/luca/] might be a bug of its own
JIRA: https://issues.redhat.com/browse/RHODS-9335

Pre-requisites knowledges:

Elyra
odh-dashboard
data-science-pipeline

Install on the RHODS/ODH on cluster
Steps to fix the issue:

Patch this path by removing the /runs/details/ from
https://github.com/elyra-ai/elyra/blob/3c27ada25a27b719529e88268bed38d135e40805/elyra/pipeline/kfp/processor_kfp.py#L438
https://github.com/elyra-ai/elyra/blob/3c27ada25a27b719529e88268bed38d135e40805/elyra/pipeline/kfp/processor_kfp.py#L454

Include view to odh-dashboard:
https://github.com/opendatahub-io/odh-dashboard/blob/e7f3931144fa6ed0a6b23e9678614bf502fe0d05/frontend/src/concepts/pipelines/elyra/utils.ts#L66C32-L66C32

How to test the changes:

Makes the change  and the build images
Apply those PR images in an RHODS/ODH cluster
Running the DSP examples.
Check the path the prompt re-direct.

Both PR's are merged in

https://github.com/opendatahub-io/notebooks/pull/137
https://github.com/opendatahub-io/odh-dashboard/pull/1461

screen cast of results.
Screencast from 2023-07-14 03-07-03.webm
Thanks for the work :+1:


Container log improvements (1/n)

Make the following improvements to container logs:

Fetch container logs from both current and previous deployment (will require a uffizzi_controller change)
Remove quotes around log output in our UI
Add support for rendering ANSI escape color codes

Can we also change the logs to a monospaced font, it would be more developer friendly

@gadkins We might want a little design for how the current and previous containers should be displayed. Maybe toggle between? Or combined but with a clear delineation between? There should be at least a little visual separation.

Depends upon https://github.com/UffizziCloud/uffizzi_controller/issues/30

Duplicate of https://github.com/UffizziCloud/uffizzi_platform/issues/419


Fix typo to prevent duplicit projects

Fix typo that is causing creating duplicit project entries with invalid
URL while reacting to GitHub App installation event.
Fixes #797
Fixes packit/dashboard#114
Signed-off-by: Matej Focko<EMAIL_ADDRESS>

@mfocko Will you please take care of the problematic data we've already saved?

Will you please take care of the problematic data we've already saved?

@lachmanfrantisek yes, once it gets deployed to make sure there are no more :)


Python locator exe does not launch due to permissions issue in Python extension

The Pet exe doesn't seem to launch (basically nothing seems to be going on),
I think this might be related,
When trying to run the exe in the terminal, i get the following error
/Users/donjayamanne/.vscode-insiders/extensions/ms-python.python-2024.9.11761016-darwin-arm64/python-env-tools/bin/pet

When pet is built locally it works as expected.

This looks like after native_build we might need to add chmod step to add executable permissions.

This should be addressed now.


docs(1.x/routerViewPort): updates directive naming

:+1: Thanks so much, @PascalPrecht!

You're very welcome @btford :)


Implement is_layout_initialized for ImmutableImage

The default implementation always returns false. However, in
ImmutableImage's case, by the time we are doing operations with
ImmutableImage, the layout should have already been initialized by
ImmutableImageInitialization.
Without this function, vulkano thinks the image referenced by the
ImmutableImage isn't initialized, and will insert a pipeline
transition from Undefined to self.layout, which isn't incorrect; the
command buffer created to initialize the image had a
final_layout_requirement of the final layout, and thus had already
transitioned the layout to the correct layout.
See, for example, the discussion in #1578.

I also want to address this comment from #1578 a bit:

So I am quite puzzled how this hasn't caused obvious problems until now, and I'm hesitant to make any changes in case it turns out it was made this way for a reason.

First, I've had good luck running the examples, and my best guess is that it is due to their simplicity that they're not affected. In my current (local) example, I have both a blit & a shader, and I think seems to be enough complexity to require that layout transitions happen correctly. (I originally started with just a blit, and even getting that to work properly was a bit of a struggle. There are more changes that need to happen to ImmutableImage for blits to work, but I wanted to keep the scope of this PR small.)
If without the implementation of is_layout_initialized, this is what I get:

With it:

(A note about the images: the part in the upper left corner is a blit. The blit slightly into the window and about 1/3 the way down is a pair of triangles textured to the same image with a shader.)
About blits
Blits require the transfer_source usage, and there's no good way to set that with ImmutableImage's interface currently. (You can generate mipmaps as a hacky way to do it.) ImmutableImage also presumes that the layout will be ShaderReadOnlyOptimal, which if you want a blit, isn't what you want. (But, vulkano is smart enough to realize during the blit that the image is in the wrong layout & transition it, but this generates some unnecessary pipeline barriers if that's all you plan to use the image for.)
In my case, blits were the wrong solution for what I wanted to do (which is why my example here also now has a shader on it.)

This looks ok in principle, but I have to ask what happens if the ImmutableImageInitialization hasn't been used yet?

@thanatos Thank you for your work. Can you please address @Rua's question?

but I have to ask what happens if the ImmutableImageInitialization hasn't been used yet?

I'm not 100% sure how to answer this. "Nothing good" would be the short version. It's otherwise kinda complicated, I think.
The biggest problem, I think, would be that layout transitions would be wrong, if they were attempted (but see my notes below about try_gpu_lock; IDK if they would be). I think they're wrong in either case, though.
Prior to my PR, I think Vulkano would get false from is_layout_initialized. Any use of the image would then attempt to transition it to whatever layout is required. (Which would depend on the command the image appears in.) But on subsequent uses of the image, it would continue to return false, and still continue to transition the image out of VK_IMAGE_LAYOUT_UNDEFINED into the desired layout, and that violates this part of Vulkan, AFAICT:

VUID-VkImageMemoryBarrier-oldLayout-01197
If srcQueueFamilyIndex and dstQueueFamilyIndex define a queue family ownership transfer or oldLayout and newLayout define an image layout transition, oldLayout must be VK_IMAGE_LAYOUT_UNDEFINED or the current layout of the image subresources affected by the barrier

Here, we're in the "or oldLayout and newLayout define an image layout transition" case.
The spec also mentions,

The old layout must either be VK_IMAGE_LAYOUT_UNDEFINED, or match the current layout of the image subresource range. If the old layout matches the current layout of the image subresource range, the transition preserves the contents of that range. If the old layout is VK_IMAGE_LAYOUT_UNDEFINED, the contents of that range may be discarded.

So, "the contents of that range may be discarded". Since uses of the image would continue to see that false, Vulkano would set up transitions from undefined to the target layout (if needed), each time discarding the contents. (But as the initializer is not used in this scenario, there aren't really any contents. I presume you'd get memory garbage.)
After my change, we'd always return true … so we'd either not transition the image properly (if the desired layout matched self.layout — we'd accidentally assume we were already in the correct layout) or we'd issue a transition from self.layout to the desired layout, which would also be wrong, as the image would still be in undefined. The common case for ImmutableImage is that self.layout is VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL, so if, say, we used it in a blit, we'd issue a pipeline barrier to set up a layout transition from VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL to something like VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL. But the image would be in undefined, so we'd again violate the spec's requirement that oldLayout be the old layout.
Honestly, I'm still figuring out how try_gpu_lock gets called & why. (It seems like it happens sometimes when I don't expect it.) But that function does do some checking of expectations in ImmutableImage, so I am wondering if it would catch this case, in particular, b/c self.initialized would still be false. So that might lead to a runtime error.

I am working on overhauling the buffer and image synchronisation, so a lot of current things may change anyway. I merged your PR for the 0.29 release.


Gitlab private repo

Please add a support for gitlab repository.
as of not the available is http and github only.
Thanks

Hello @codedge ,
i may can get you an hand. We have already setup our own private gitlab. We can sponsor the dev and/or I can’t help you with my pho knowledge. Contact me to discuss details
regards

+1
@codedge any chance you’re gonna plan this implementation in the short term?
Thanks a lot

@scramatte Sorry for being late here. If you want to sponsor this, just go on, even some small amount helps :) Happy to implement this

@codedge , sorry for late reply too.  Does it posible to implement gitea private repository too?  Gitlab requires  quite a lot of resources  and  knowledge to maintained  compared to gitea.  Anyways it would be nice to have support for both.

I think this is also possible. I don't have a Gittea instance runnning. So if you can provide one to seet the API response I could check what needs to be done.

@codedge , I'm going to prepare you gitea repository for testing.
I've just  sponsor you.  Thank you to make  so useful tool available for whole Laravel users community

@codedge  I've sponsored too for the Gitlab version :)
Thank you!

@z3d0 You might want to check out version 3.4 - support for Gitlab is ready.
For this to work, you need to create a release for your project in Gitlab and tag it.

@scramatte Please open a separare ticket for Gitea. Thanks you!


Generation of class does not generate a constructor with mappings

Hi,
Got the latest Studio (v12.0.6) and generated my service files and encountered a massive issue. We rely on the constructor of many of our classes to build the classes. But since v12.0.6, the constructor does not have the mappings. Is that an issue or have you changed the way it works?
Previous
constructor(data?: className) {
        super(data);
}
// Super
constructor(data?: ICommand) {
    if (data) {
        for (var property in data) {
            if (data.hasOwnProperty(property))
                (<any>this)[property] = (<any>data)[property];
        }
    }
}

Now
constructor(data?: className) {
        super(data);
}
// Super
constructor(data?: ICommand) {}

Thanks

Probably a regression of this PR: https://github.com/RSuter/NJsonSchema/pull/831
Is it correct that this code is missing in the root dto?

Ah i need to remove the properties.size check

NSwag v12.0.7

Thank you!


Add 'Close All Test Suites' Ability

In this commit I added a new context menu option for test suites whereby you can choose to close all test suites at once.  This option still allows the user to save each test suite that has changes before it is closed.  I also added the name of the test suite in the save confirm pop-up.

Sorry if I did this wrong.  Not sure why those three other commits are in the pull request, since I think those changes are already in your master.  I know I had tried to merge those latest changes into my master, which I may have done incorrectly and resulted in that.


Train, Test and Val TFRecords files partitions always created

Describe the bug
Train, Test and Val TFRecords files always created even if I only specify TRAIN on CSV file
To Reproduce
Change Split to only TRAIN
split,image_uri,label
TRAIN,../tfrecorder/test_data/images/cat/cat-640x853-1.jpg,cat
TRAIN,../tfrecorder/test_data/images/cat/cat-800x600-2.jpg,cat
TRAIN,../tfrecorder/test_data/images/cat/cat-800x600-3.jpg,cat
TRAIN,../tfrecorder/test_data/images/goat/goat-640x640-1.jpg,goat
TRAIN,../tfrecorder/test_data/images/goat/goat-320x320-2.jpg,goat
TRAIN,../tfrecorder/test_data/images/goat/goat-640x427-3.jpg,goat
Expected behavior
Only create a partitions for TRAIN TFRecords
Screenshots

System (please complete the following information):

OS: [ iOS]
Python Version: [3.7.4]
TensorFlow Version: [2.2.0]

Additional context
Not sure if this a Bug or this indeed is expected behavior. But as a user If my CSV partitions file only specified TRAIN is strange to create the other files (test and val) are also created, but without images.

This behavior makes sense, knowing the code, but it does seem unexpected/weird to a user. I think we should probably address it. We are getting ready to add some features for 0.2's input schema parsing.  I think it would be good to address this as part of that change. @cfezequiel awareness.

Hi @jmarrietar , thanks for the feedback. Yes it makes sense to just write TFRecord files for splits with data. I've created a fix in #25 .
One caveat is that Apache Beam doesn't really support conditional pipeline transforms (e.g. if dataset is not empty, run transform), so the check for train/validation/test counts is done at the input (DataFrame) level. The issue is that when the pipeline is run, it may flag some erroneous samples in a split as 'discarded', which may still result in an empty TFRecord file.
For instance, let's say all samples in the test dataset are erroneous. The pipeline may still generate a test*.tfrecords.gz file as there were valid samples in the test dataset when it was counted, even though all samples were marked as 'discarded'. This would probably not be a common case however, and it would be up to the user to ensure that their data is correct.


make LocalHistoryRoute a proper super-mixin

It is a super-mixin and therefore must be declared using mixin and must not allow extensions.
/cc @leafpetersen

Breaking change announcement: https://groups.google.com/forum/#!topic/flutter-dev/09seO_9arzA


Allow backup via adb

I regularly flash the OS on my phone, wiping all data. I use adb backup to ensure my app data is backed up. This will allow otp-authenticator to be backed up and restored. Of course, handling the backup securely is up to the user to do correctly ;-)

An alternative to this (if there's a downside I'm missing) is to implement a export/import function inside the app. This could automatically encrypt the backup and whatnot for security.

Hi @srguglielmo !
Thanks for your pull request, but it's intentional that OTP Authenticator doesn't support any export or backup feature.
All data is encrypted with a device specific + non extractably key and therefore I am pretty sure you wouldn't be able to restore a backup after  wiping your device.
Also I would like to make the secret extraction has hard as possible and a backup/export feature would be the exact opposite of that.

I understand that. However, this makes the app entirely unusable anyone who wipes/upgrades their phone even just once, let alone on a regular basis. There's really no way to save the OTP seeds? Some websites don't have backup codes to use.


Update composer.lock

I got 2 warnings after running composer create-project on the master branch:

Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.

And :

Deprecation Notice: The callback Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::installAssets declared at symfony-standard/vendor/sensio/distribution-bundle/Composer/ScriptHandler.php accepts a Composer\Script\CommandEvent but post-install-cmd events use a Composer\Script\Event instance. Please adjust your type hint accordingly, see https://getcomposer.org/doc/articles/scripts.md#event-classes in phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:289
Deprecation Notice: The callback Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::installRequirementsFile declared at symfony-standard/vendor/sensio/distribution-bundle/Composer/ScriptHandler.php accepts a Composer\Script\CommandEvent but post-install-cmd events use a Composer\Script\Event instance. Please adjust your type hint accordingly, see https://getcomposer.org/doc/articles/scripts.md#event-classes in phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:289
Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::installRequirementsFile
Deprecation Notice: The callback Sensio\Bundle\DistributionBundle\Composer\ScriptHandler::prepareDeploymentTarget declared at symfony-standard/vendor/sensio/distribution-bundle/Composer/ScriptHandler.php accepts a Composer\Script\CommandEvent but post-install-cmd events use a Composer\Script\Event instance. Please adjust your type hint accordingly, see https://getcomposer.org/doc/articles/scripts.md#event-classes in phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:289

Maybe something like an auto-build of this lock file could be set up ?

The lock file is updated on each new Symfony release by @fabpot , IIRC

I've updated composer.lock. Everything looks good now.


Add collation of GDPR records

Adds a function which combines & collates the records extracted by getStreamingData into a Map that can easily be used as input to the chart

hmm personally I liked the helper functions cause there was less lines, but both make sense.


Debain is not installing: "debain does not belong to any supported distribution."

name: precise
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/precise...
/usr/local/bin/enter-chroot: 511: cannot create /run/crouton/mnt/stateful_partition/crouton/chroots/precise/etc/crouton/name: Directory nonexistent

Description of the issue:
Debain is not installing. I already have a chroot. But I also want to install Debain (core) but It is saying that "debain does not belong to any supported distribution." Please someone help.
*Note: I am using a HP Chromebook 14 (intel) and I already have a chroot (ubuntu-unity).

is it as simple as a typo? ie debian rather than "debain" ?

@CapKenway,

Debain is not installing. I already have a chroot. But I also want to install Debain (core) but It is saying that "debain does not belong to any supported distribution."

I'm not sure I understand what you're trying to do. It looks like your 'precise' chroot is failing or broken.
Do you want to install another chroot in addition to 'precise' or do you want to replace it?
If you want to install another 'debian' release you can choose from the ones that 'crouton' offers, see below:
Recognized debian releases:
    potato* woody* sarge* etch* lenny* squeeze* wheezy jessie stretch sid

Releases marked with * are unsupported, but may work with some effort.

You select a 'release' when installing the crouton chroot using the '-r' option, similar to:
sudo sh ~/Downloads/crouton -r sid -t xfce,...
Specify any targets/desktop you prefer above after the '-t' option.
Hope this helps,
-DennisL


Pan and Tilt of camera gimbal

The Pan and Tilt of camera gimbal works fine as expected on the ground with the def setServo.
However in flight, the servo 8 which pan's the gimbal, now yaw's the craft.
Land again, this works perfectly,
So now the craft doesn't pan the camera but does tilt the camera,
If you yaw normally the craft yaw's twice, either with the setServo direction or against the direction.
Tried using the Mav ROI instead, that doesn't move the gimbal at all.
If the gimbal pan was set to an awkward angle on take off, this cannot be corrected in flight, even though the tilt can.
Any ideas on how to fix this?

Thank you, this is a new one I was not aware of. It must be a DJI sdk thing. I too will need this so I’ll investigate.
If any other have any idea’s please share.
Best regard
Terje Nilsen
9Tek AS
Norway

On Jul 4, 2020, at 11:23, BkMak16<EMAIL_ADDRESS>wrote:

The Pan and Tilt of camera gimbal works fine as expected on the ground with the def setServo.
However in flight, the servo 8 which pan's the gimbal, now yaw's the craft.
Land again, this works perfectly,
So now the craft doesn't pan the camera but does tilt the camera,
If you yaw normally the craft yaw's twice, either with the setServo direction or against the direction.
Tried using the Mav ROI instead, that doesn't move the gimbal at all.
If the gimbal pan was set to an awkward angle on take off, this cannot be corrected in flight, even though the tilt can.
Any ideas on how to fix this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Seems the gimbal must be inn YawFollow mode, and not in FREE mode.
It is suppose to change mode automatically.
Try changing the code like this and test:
/********************************************
* Motion implementation                    *
********************************************/
void do_set_Gimbal(float channel, float value)
{
    Rotation.Builder builder = new Rotation.Builder().mode(RotationMode.ABSOLUTE_ANGLE).time(2);
    float param = (value-(float)1500.0)/(float)5.5;
    if (channel == 9) {
        builder.pitch(param);
    } else if (channel == 8) {
        builder.yaw(param);
    }
    if (mGimbal == null) {
        return;
    }

    **mGimbal.setMode(GimbalMode.FREE,djiError -> {
        if (djiError != null)
            parent.logMessageDJI("Error: " + djiError.toString());
    });**

    mGimbal.rotate(builder.build(), djiError -> {
        if (djiError != null)
            parent.logMessageDJI("Error: " + djiError.toString());
    });
    util.safeSleep(500);
}

It might not be that easy:

FREE
The gimbal can move independently of the aircraft's yaw. In this mode, even if the aircraft yaw changes, the camera will continue pointing in the same world direction. This mode is only available for the Ronin-MX when the M600 or M600 Pro landing gear is retracted.

FPV
The gimbal's work mode is FPV mode. In this mode, the gimbal yaw will follow the aircraft's heading, and the gimbal roll will follow the RC's roll channel value. The pitch will be available to move. This mode is only available for the Ronin-MX when the M600 landing gear is retracted.

YAW_FOLLOW
The gimbal's work mode is such that it will follow the yaw. In this mode, the gimbal yaw will be fixed, while pitch and roll will be available to move.

UNKNOWN
The gimbal's work mode is unknown.

Will do new builds and see what works best.
Thanks

Okay,
Last question then I'll be able to give you my findings.
Is there a way to change the modes (sports, p-mode and tripod) without using the slider on the controller.  An app button, setting or line of code?

On the first bootup:
P-Mode or Tripod:
Collision Detection		Front and Rear Only
Movement (X,Y,Z)		Yes
Yaw				        No
Gimbal 				Tilt and Pan
User Controller Input	No
Sport:
Collision Detection		No
Movement (X,Y,Z)		Yes
Yaw				        No
Gimbal 				Tilt and Pan
User Controller Input	No
After Switching Modes:
P-Mode:
Collision Detection		Front and Rear Only
Movement (X,Y,Z)		No
Yaw				        No
Gimbal 				Tilt
Pan makes drone Yaw
User Controller Input	Yes
Tripod:
Collision Detection		Full
Movement (X,Y,Z)		No
Yaw				        No
Gimbal 				Tilt
Pan makes drone Yaw
User Controller Input	Yes
Sports:
Collision Detection		No
Movement (X,Y,Z)		No
Yaw				        No
Gimbal 				Tilt
Pan makes drone Yaw
User Controller Input	Yes
On all modes and first boot, Gimbal Pan works properly only on the ground.
There is no way to get movement and full collision detection. To get full detection you must switch modes even if booted in tripod as you only get front and rear, switching modes causes the loss of movement and gimbal pan. To regain these, the drone must be rebooted.
Yaw does not respond in any mode regardless of gimbal build. A form of Yaw is after a mode switch the pan becomes the Yaw, leaving no way on panning.
A way to solve the everything except for the Yaw, is to do the system check that happens when switching to tripod which activates the remaining sensors, if the controller is booted/connected already in tripod mode so that you don’t have to switch out of tripod and back in to get the sensors, thereby losing movement.

Rosseta.docx
Heres the WordDoc version

My workaround is to rotate the entire drone, and only use pitch on the camera controller. One can move in any direction while pointing the head in another.

I have investigayed a bit more, on Inspire this does not happen, seems I can not get around it on the Mavics ...

Dear rosettadrone friends and @The1only ,
I was wondering if someone tried DroneKit's Gimbal control function. We are trying to use DroneKit to change the pitch of gimbal, but not very sure if it is compatible with rosettadrone.
-- Luke

Dear rosettadrone friends and @The1only ,
I was wondering if someone tried DroneKit's Gimbal control function. We are trying to use DroneKit to change the pitch of gimbal, but not very sure if it is compatible with rosettadrone.
-- Luke

Yes this is a big problem. It all depends on what DJI drone you use, the Inspire and Matrice shuld work as expected, however the Mavic has this issue, and if you read the DJI SDK manual there seems to be no way around it. Any suggestions are welcome. I too got issues with camera not pointing forward and it can not be adjusted in air.
I’ll fix it as soon as someone works out why!

Yes this is a big problem. It all depends on what DJI drone you use, the Inspire and Matrice shuld work as expected, however the Mavic has this issue, and if you read the DJI SDK manual there seems to be no way around it. Any suggestions are welcome. I too got issues with camera not pointing forward and it can not be adjusted in air.
I’ll fix it as soon as someone works out why!

Hopefully soon I'll be able to get back to working on the Mavic.

Hopefully soon I'll be able to get back to working on the Mavic.


Update Stamen source

Stamen tiles are moving: https://docs.stadiamaps.com/guides/migrating-from-stamen-map-tiles/
This will be a breaking change since the tiles will require an API key or registered domain to work.

Hey @tschaub, Ian from the Stadia Maps team here. I'd be happy to help with a PR for this. I'm already working with the Leaflet Providers team on a similar PR (https://github.com/leaflet-extras/leaflet-providers/pull/520), and a similar question came up about semver breaking changes.
If the OL team is OK with making this a semver breaking change, it might make sense to rename the source and add our other styles as well. Otherwise it's technically possible to patch the existing provider in a way that will work (our domain auth doesn't need an API key or any other config from the OL side). Let me know your thoughts on how to proceed and I'd be happy to contribute.

Thanks for reaching out, @ianthetechie.  We have some other breaking changes queued up, so I think it would be ok to go with a renamed source.  Curious to hear if others have thoughts (@openlayers/core).

I know this issue is closed, but just wanted to check on the status of the OL 8.0 release. We originally planned to start serving a certain proportion of "warning tiles" letting users on the old endpoints to upgrade starting in early September, but might need to shift our timeline if the major libraries still don't have a clear migration path.

We can definitely publish v8.0.0 by September 1st. This means @openlayers/core have 1 week to create pull request for removal of deprecated things etc.

Cool; thanks. I'll keep an eye on progress both here and in other libs, and both we and Stamen will do some more comms to make sure as wide an audience as possible has a chance to do a disruption-free migration.


Turbulence Index

A better way to use turbulence Index is to apply Mahalanobis Dist.. on returns timeseries rather than the levels as you are doing...

Mahalanobis Dist

That's a great idea! Please join our open-source community:
https://join.slack.com/t/ai4financeworkspace/shared_invite/zt-jyaottie-hHqU6TdvuhMHHAMXaLw_~w


ES2017: Use URL to refer to the specification

Once ECMA-262 2017 edition is finalized, the parser code should use URL instead of section number when referring to the grammar production.
Example: instead of ECMA-262 12.2 Primary Expressions, use http://ecma-international.org/ecma-262/8.0/#sec-primary-expression.
(As suggested by @mathiasbynens)

Alternative suggested by @michaelficarra: link the living spec (https://tc39.github.io/ecma262).

A possible hybridapproach: link to the living spec in the master branch, switch to the more permanent URL in the release branch.


i18n(es): update translation for styling.md

What kind of changes does this PR include?

New or updated content
Translated content

Description

What does this PR change? Translated content for latest updated on #1648

Please label for hacktoberfest-accepted.

LGTM! Thank you @fredoist and @agustinmulet


IconThemeData.size

Fixes https://github.com/flutter/flutter/issues/4440
Prereq for https://github.com/flutter/flutter/issues/4494


Debounced select

Hoist P/R Checklist
Review and check off the below. Items that do not apply can also be checked off to indicate they
have been considered. If unclear if a step is relevant, please leave unchecked and note in comments.

[x] Up to date with develop branch as of last change.
[x] Ready for review (or open as a draft PR / add wip label).
[x] Added CHANGELOG entry (or N/A)
[NA] Reviewed for breaking changes (add breaking-change label + CHANGELOG if so, or N/A)
[NA] Updated doc comments / prop-types (or N/A)
[NA] Reviewed and tested on Mobile (or N/A)
[NA] Created Toolbox branch / PR (link provided here, or N/A)

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Hope this simplification makes sense?  Please let me know if I missed something?  We are capturing a fixed value of the queryBuffer prop in any case....

Thank you, much better.


flip-link: 0.1.8 -> 0.1.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/knurling-rs/flip-link/releases.
meta.description for flip-link is: Adds zero-cost stack overflow protection to your embedded programs
meta.homepage for flip-link is: https://github.com/knurling-rs/flip-link
meta.changelog for flip-link is: https://github.com/knurling-rs/flip-link/blob/v0.1.9/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.1.9 with grep in /nix/store/1243v72pdysj4ck4yy3gfnvxnw5jdzhb-flip-link-0.1.9
found 0.1.9 in filename of file in /nix/store/1243v72pdysj4ck4yy3gfnvxnw5jdzhb-flip-link-0.1.9

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

flip-link

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1243v72pdysj4ck4yy3gfnvxnw5jdzhb-flip-link-0.1.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flip-link https://github.com/r-ryantm/nixpkgs/archive/72d285c0794685254238167af811afc83338bdb0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/72d285c0794685254238167af811afc83338bdb0#flip-link

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1243v72pdysj4ck4yy3gfnvxnw5jdzhb-flip-link-0.1.9
ls -la /nix/store/1243v72pdysj4ck4yy3gfnvxnw5jdzhb-flip-link-0.1.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

flip-link

Maintainer pings
cc @FlorianFranzen @newAM for testing.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 334737 run on x86_64-linux 1

1 package built:

flip-link


Login Stopped Working

Before submitting a bug report...

[X] This bug wasn't already reported.
(I have checked every bug report on GitHub)

[X] I've cleared the sessions folder.

Branch
develop
Commit
494c9d
Describe the bug
Been working flawlessly for a while, now login does not work.
Copy and paste your error
Windows:
Traceback (most recent call last):   File "C:\Users\xxx\Desktop\MS-Rewards-Farmer-develop\main.py", line 236, in executeBot     Login(desktopBrowser, args).login()   File "C:\Users\xxxx\Desktop\MS-Rewards-Farmer-develop\src\login.py", line 71, in login     self.execute_login()   File "C:\Users\xxx\Desktop\MS-Rewards-Farmer-develop\src\login.py", line 176, in execute_login     self.utils.waitUntilVisible(By.NAME, "kmsiForm")   File "C:\Users\xxx\Desktop\MS-Rewards-Farmer-develop\src\utils.py", line 125, in waitUntilVisible     return WebDriverWait(self.webdriver, timeToWait).until(            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\site-packages\selenium\webdriver\support\wait.py", line 105, in until     raise TimeoutException(message, screen, stacktrace) selenium.common.exceptions.TimeoutException: Message: Stacktrace:
linux (docker) - Session not cleared:
File "/app/main.py", line 39, in main
earned_points = executeBot(currentAccount, args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/main.py", line 236, in executeBot
Login(desktopBrowser, args).login()
File "/app/src/login.py", line 71, in login
self.execute_login()
File "/app/src/login.py", line 83, in execute_login
emailField = self.utils.waitUntilVisible(By.ID, "i0116")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/src/utils.py", line 125, in waitUntilVisible
return WebDriverWait(self.webdriver, timeToWait).until(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/selenium/webdriver/support/wait.py", line 105, in until
raise TimeoutException(message, screen, stacktrace)
`
linux (sessions folder cleared)
Traceback (most recent call last):   File "/app/main.py", line 39, in main     earned_points = executeBot(currentAccount, args)                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/app/main.py", line 236, in executeBot     Login(desktopBrowser, args).login()   File "/app/src/login.py", line 71, in login     self.execute_login()   File "/app/src/login.py", line 176, in execute_login     self.utils.waitUntilVisible(By.NAME, "kmsiForm")   File "/app/src/utils.py", line 125, in waitUntilVisible     return WebDriverWait(self.webdriver, timeToWait).until(            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/usr/local/lib/python3.12/site-packages/selenium/webdriver/support/wait.py", line 105, in until     raise TimeoutException(message, screen, stacktrace)
Screenshots
chrome window didn't load for me
Value of dashboard variable
xxxx

Same thing happens to me on master

Run it with -v | You most likely have a prompt on the screen that has not been accounted for yet such as the "We are updating our TOS"

Figured out issue. There is an update of the terms of service dialog. I am sure there is a way to check for it, but for now.

On a desktop, clear all your data on a browser
log into rewards.bing.com
It will prompt you to agree to the new terms
Continue to log in
Now start the rewards farmer. Even on another computer, it will now login since you already accepted the new terms

But I am now getting an error that
File "/app/src/browser.py", line 281, in getRemainingSearches     pcSearch: dict = counters["PCSearch"][0]
but at least log in works.


Reload source maps in the debugger when reloading the script environment

As a Minecraft script developer, I want the VSCode debugger to automatically reload source maps when the game is reloaded using the /reload command so that my breakpoints and other debugging tools continue to work correctly without requiring manual intervention.
Description
Currently, when I use the /reload command in Minecraft, the VSCode debugger does not reload the source maps. This causes breakpoints and other debugging tools to become misaligned or ineffective, which interrupts my workflow and requires me to manually reload the extension.
Acceptance Criteria

Given I have the Minecraft script debugger VSCode extension running and attached to a Minecraft game,
When I execute the /reload command in Minecraft,
Then the VSCode debugger should automatically reload the source maps.

Given I have set breakpoints in my script files before executing the /reload command,
When the source maps are reloaded automatically,
Then the breakpoints should remain accurate and functional without requiring manual adjustment or extension reload.

To implement a reload command for a Minecraft script debugger in VSCode, you need to extend the functionality of the VSCode extension. Here’s a basic outline of the code snippets you might use to accomplish this, focusing on detecting the /reload command and reloading source maps.
Step 1: Detect the /reload Command
You'll need to listen to the output of the Minecraft console to detect when the /reload command is executed. This can be done by extending the VSCode extension's functionality to listen for specific console output or events.
Example Code (Listening for /reload Command):
const vscode = require('vscode');

function activate(context) {
    const debugSession = vscode.debug.activeDebugSession;

    if (debugSession) {
        const outputChannel = vscode.window.createOutputChannel('Minecraft Debugger');

        // Event listener for receiving output from the Minecraft console
        debugSession.addEventHandler('output', (output) => {
            // Check if the output contains the '/reload' command
            if (output.includes('/reload')) {
                reloadSourceMaps();
            }
        });
    }
}

function deactivate() {}

function reloadSourceMaps() {
    const debugSession = vscode.debug.activeDebugSession;

    if (debugSession) {
        debugSession.customRequest('reloadSourceMaps')
            .then(() => {
                vscode.window.showInformationMessage('Source maps reloaded successfully.');
            })
            .catch(err => {
                vscode.window.showErrorMessage(`Error reloading source maps: ${err.message}`);
            });
    }
}

module.exports = {
    activate,
    deactivate
};

Step 2: Implement Reload Source Maps
In VSCode, there is no direct API for reloading source maps, so you may need to manually handle this by reloading or refreshing the relevant files or breakpoints.
Example Code (Refreshing Breakpoints):
function reloadSourceMaps() {
    const debugSession = vscode.debug.activeDebugSession;

    if (debugSession) {
        // Refresh the breakpoints manually
        const breakpoints = debugSession.breakpoints;

        breakpoints.forEach(bp => {
            // Assuming you have a method to re-apply breakpoints
            debugSession.addBreakpoints(bp);
        });

        // Inform the user
        vscode.window.showInformationMessage('Source maps reloaded and breakpoints refreshed.');
    }
}

Step 3: Update launch.json for Custom Request
Ensure that your launch.json configuration allows for custom requests. This might be necessary for the reloadSourceMaps function to work as intended.
Example launch.json Configuration:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Minecraft Debug",
            "type": "minecraft",
            "request": "launch",
            "program": "${workspaceFolder}/path/to/your/script",
            "preLaunchTask": "build",
            "customRequest": "reloadSourceMaps"
        }
    ]
}

Step 4: Handling Debugger Requests
In your extension, you should define how the custom request for reloading source maps is handled. This typically involves setting up a debug adapter that responds to custom requests.
Example Code (Debug Adapter Handling):
const vscode = require('vscode');

class MinecraftDebugAdapter {
    // ... other methods

    handleCustomRequest(request, response) {
        switch (request.command) {
            case 'reloadSourceMaps':
                this.reloadSourceMaps();
                response.success = true;
                break;
            default:
                response.success = false;
                response.message = `Unknown command: ${request.command}`;
        }
    }

    reloadSourceMaps() {
        // Logic to refresh source maps
    }
}

// Register the debug adapter
vscode.debug.registerDebugAdapterDescriptorFactory('minecraft', new MinecraftDebugAdapterFactory());

Conclusion
These code snippets provide a starting point for implementing a reload command feature in a VSCode Minecraft debugging extension. The actual implementation may vary based on your specific debugging setup and the VSCode API capabilities. Ensure to adapt and extend these snippets as needed to fit the exact requirements of your extension and debugging environment.

Fixed with #248


[fzf-tmux] Allow opening fzf on any position (up/down/left/right)

is opening fzf on any position only possible with tmux?
I'd like to use it in my vim integration but can't figure out how to have the query prompt on top instead of at the bottom...is this possible?

Hmm, did you try --reverse option? (it's not related to this PR)

thanks @junegunn !! all I needed!
fzf is such a great idea! love it! slowly I migrate more and more functionality that I used unite for...it's insanely fast!


Only start writing the ivf on a keyframe.

Description
The ivf writer would write useless packets from the RTP stream because there was no preceding keyframe. Now the ivfwriter waits until it sees a keyframe then begins writing.

Awesome! Thank you so much @tmiv this is a great improvement. Before  I merge would you mind

Fixing golangci-lint errors
Add a test to confirm behavior
Add yourself to README
Maybe do seenKeyFrame or keyframeWritten just to make a little more clear

Sure. No problem as soon as I figure out what is golangci-lint.
On Sun, Aug 23, 2020, 1:06 PM Sean DuBois<EMAIL_ADDRESS>wrote:

Awesome! Thank you so much @tmiv https://github.com/tmiv this is a
great improvement. Before I merge would you mind

Fixing golangci-lint errors
Add a test to confirm behavior
Add yourself to README
Maybe do seenKeyFrame or keyframeWritten just to make a little more
clear

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pion/webrtc/pull/1382#issuecomment-678818550, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWPYR4CFDSB72WS5FUQJM3SCFZE3ANCNFSM4QIYWHNQ
.

Hey @tmiv did you mean to close this? I would love to merge this into master!
If you don't have the time to finish the PR I can take it in a day or two. thanks

I did. My keyframe detection method is not working properly. I withdrew the
PR so it wouldn't get merged before I make it bullet proof.
On Sun, Aug 23, 2020 at 9:51 PM Sean DuBois<EMAIL_ADDRESS>wrote:

Hey @tmiv https://github.com/tmiv did you mean to close this? I would
love to merge this into master!
If you don't have the time to finish the PR I can take it in a day or two.
thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pion/webrtc/pull/1382#issuecomment-678901629, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWPYRZWIIIYCP2CZDD5RXLSCHWTVANCNFSM4QIYWHNQ
.

--
TMIV

Hi @Sean-Der, not sure what's up with the test here. Do you think you could take a look?

I just filed https://github.com/pion/webrtc/issues/1384
Not your issue at all! I will get a fix in for this today!

The PR looks fantastic! Test coverage is good. Let me fix the other issue and then we can rebase.

Merged with f53607d657446c88ad5803aff178f5698f838338
Really fantastic work @tmiv I hope you continue to stay involved. If there is anything I can do to improve Pion I would love to hear! Always looking to make it better.


host this using github pages

follow this instructions and make your work accessible via pages
github pages

Sure sir in about a moment


Split vendor toggles into separate toggles for consent and legitimate interest

Is your feature request related to a specific problem?
Vendor toggles need to be two separate toggles instead of one toggle.
Describe the solution you'd like
Render two toggles instead of just one toggle for vendors. One controls vendor legitimate interest, and one controls vendor consent. Not all vendors will have both though.
We will need to save this to the TC string/cookie and read from it since the backend won't be quite ready yet.
Describe alternatives you've considered, if any
A description of any alternative solutions or features you've considered.
Additional context
https://www.figma.com/file/dmEwdK3xZwjKfGVQ9t66xe/Fides-v.2-Master-Working-Files?node-id=10555%3A605238&mode=dev
Split out of this ticket: https://github.com/ethyca/fides/issues/4166

moving to done


Fix VR usage: use camera projection matrix by current camera

This is a solution for the VR-issue described by users. It was tested using HTC Vive in Unity 2017.

Enabling shadows for spotlights works as well.

The pull request now only adresses the matrix issue for vr.
With regards to the spotlight issue. The CommandBuffers are simply not executed on the right eye. The reason: They are attached to shadowmap generation, which is only executed once (for the left eye) in a single camera setup. I have filed a bug report: https://fogbugz.unity3d.com/default.asp?968854_gmmukio2rnkjgibv

@kwnetzwelt Great initiative! Which version of Unity have you been using to get this to work? best scenario on SteamVR so far after trying a bunch of Unity betas have been correct rendering on my left eye only. Is there something i need to do beyond the normal steps for this package?

Unity also accepted the bug and will fix it sometime soon, so we can potentially do this with one camera in an upcoming unity release. I used Unity 2017.3.0b9 for this. As far as additional steps are concerned: For now you need to basically duplicate the camera and set each camera to render to one eye only.

But as you said in the other thread, if you duplicate you will have two SteamVR_camera components. So do you remove SteamVR_camera from the duplicate camera?