nbest API for getting n-candidates for each node

Changing the "nbest" API to return the n-best candidates for each node in the query (the previous implementation was the same as "infer").
The calculation is done for each node separately, by fixing the labels of all the other nodes except for the current node, getting candidates for this node, sorting them descendingly according to their score, and taking the top n.
The meaning is - given the others labels, what are the top candidates for the current node.
Added an option whether to perform MAP inference or not before calculating the candidates.
This API can be useful in cases where there are several semantically similar options (like "count", "count", "totalCount", "cnt" etc.), and we are running automatic accuracy evaluations, and we don't want to count a prediction as totally-incorrect, in case that the correct prediction is not first, but is in the top-n candidates.
I would be happy if @vraychev could verify that I did not make any mistakes.

Thanks

Thanks, fixed all comments


Default verbose to true when passing in callbackManager

This isn't an ideal api but that's a different problem

Is there a discussion somewhere on moving it towards an ideal API?
Some issues encountered top of my mind:

Should execute handlers regardless of verbose flag
Handlers should respect verbose flag and handle accordingly
Chat models are currently emitting the messages as concatenated string (why?)

Yeah, I think the ideal api wold be to execute all handlers and use the verbose flag within the handler itself.
@ruqqq -- we're in the middle of changing the way callbacks work to better support concurrency and solve other issues. We can group this work in with that: https://github.com/hwchase17/langchainjs/pull/381
For your third point, it might be worth introducing a separate callback for chat models if you actually want to work with the message objects


Distinguish between regular and extended app describe

Description of change

Fixes https://github.com/meroxa/turbine-project/issues/111
Type of change

[ ]  New feature
[ ]  Bug fix
[x]  Refactor
[ ]  Documentation

How was this tested?

[ ]  Unit Tests
[x]  Tested in staging

Demo

Additional references

Documentation updated

Yesterday I was chatting with @jayjayjpg about this one, and I was wondering if this information could be returned by the API directly, so we wouldn't need to fetch for each of the resources. Possibly having even two different endpoints such as:

GET /v1/applications/:uuid (no --extended)
GET /v1/applications/:uuid?extended (with --extended).

What do you think?
P.S..: This question is not a blocker just an alternative implementation in case the list of connectors / functions / etc... ends up being too big.

the current implementation is quite slow.  doing it all in the API would be faster and nicer.  i could go either way, but at this point, i would favor making time for python work over another implementation of this; i'd be happy to open a follow up ticket to improve performance/efficiency around this. how does that sound?

@janelletavares Yes, fully agree with you and that sounds good to me!

opened this issue https://github.com/meroxa/turbine-project/issues/129

the current implementation is quite slow. doing it all in the API would be faster and nicer. i could go either way, but at this point, i would favor making time for python work over another implementation of this; i'd be happy to open a follow up ticket to improve performance/efficiency around this. how does that sound?

@janelletavares makes sense to me


types: Add assert_never for exhaustivenes checking with mypy

This PR addresses issue #835, and should help with exhaustiveness checking for types. Running mypy capa/rules.py showed no errors before I made these changes.
Output of mypy capa/rules.py after change:
capa/rules.py:1095: error: Argument 1 to "assert_never" has incompatible type "Statement"; expected "NoReturn"
capa/rules.py:1200: error: Argument 1 to "assert_never" has incompatible type "Scope"; expected "NoReturn"
Found 2 errors in 1 file (checked 1 source file)

Checklist

[x] No CHANGELOG update needed

[x] No new tests needed

[x] No documentation update needed

The code you added here is just what I had in mind for #835 - nice!
However, mypy doesn't seem to be recognizing the narrowed types. The error around line 1200 is most clear: although we've handled all cases (file, function, bb), mypy is worried about the type Scope (which is the enum container, not any of the values). Do you have any idea why this is or how we can fix it?

ahh, for the Scope errors (line 1200) there are two pre-existing mistakes:

cases should check against Scope.FOO rather than scope.FOO (which is a local variable), and
cases should use foo is enum.BAR rather than foo == enum.BAR

I found this by copying the example in the blog post and using reveal_type with changes until it worked. I was confused because the LSP/type checker in my vim editor resolved the types better than mypy was doing.

I don't have edit permissions for your repo, so @cl3o would you update this PR with the above changes?

looking next at the other mypy error...

Ahh, okay. I noticed those warnings from mypy too, and I wasn't sure if it was just on my end or not. Do you want me to just do a fixup for those errors real quick?

I can just give you edit permissions, if you'd like.

doesn't matter either way, I was just trying to save you a step before tagging you to request the edit.

Okay. I'll make the edit in a bit.
Thank you so much for all the feedback.

for the other case, the checking of Statement, i don't think we can convince mypy to do what we want.
what we want is to have mypy do exhaustiveness checking on all the subtypes of class Statement; however, i don't think this is something that mypy is capable of tracking (imagine: anyone can come along and define a new subtype of Statement so how would mypy know what is possible?). therefore, we should add a further explicit check to the if/elif/else branches like this:

here's the code as proposed above:
            elif isinstance(node, ceng.Statement):
                # unhandled type of statement.
                # this should only happen if a new subtype of `Statement`
                # has since been added to capa.
                #
                # ideally, we'd like to use mypy for exhaustiveness checking
                # for all the subtypes of `Statement`.
                # but, as far as i can tell, mypy does not support this type
                # of checking.
                #
                # in a way, this makes some intuitive sense:
                # the set of subtypes of type A is unbounded,
                # because any user might come along and create a new subtype B,
                # so mypy can't reason about this set of types.
                assert False, f'Unhandled value: {node} ({type(node).__name__})'

@cl3o if you agree, would you add this check? then, we'll be happy to merge!

About the first change - I get a warning in PyCharm:
Local variable 'easy_rules_by_feature' might be referenced before assignment
at easy_rule_names = easy_rules_by_feature.get(feature). It suggests creating a global statement. Should I just ignore this?

About the first change - I get a warning in PyCharm:

can you introduce a default value for the local variable, like easy_rules_by_feature = {} right at the start of method match()? PyCharm must not be able to see into the assert_never to understand that this case should be impossible.

I think that's everything. Thank you for being so patient with me. :)

no, thank you! this looks great and it was easy to work with you.
(no pressure) would you like to find or be recommended another capa issue?

I'd love to work on another issue. Do you have anything specific in mind?

here are a few issues that won't require a very deep knowledge of capa's internals.
#430
#103
#331
#377
#836
feel free to assign yourself any of these and open a PR. also, we're happy to discuss the requirements more if its unclear what is needed. we'd like to make it as easy as possible for contributors, so let us know what we can do to make your task easier!

once you're comfortable with how capa works, bigger features would be #376 and #322

I think I'll start with #331 and go from there. :)

Sorry. I wasn't sure where to ask this, so I'm just writing it here. What does it mean to be invited as a collaborator?

i had attempted to invite you so that i could "assign" the issue to you:

feel free to reject or ignore, its just project bookkeeping

Ahh, okay. That's fine then.


Question about downstream task

I find that you use the time series classification as the main downstream task, but I want to know if the pre-trained backbone is used for the time series forecast task, this method takes effect or not.

Thanks for your interest. We did not test the backbone on the forecasting task, you can have a try : )


containerd certificate config using incorrect header section for the EKS 1.24 GPU AMI

What happened:
The GPU EKS AMI's containerd config was recently updated to support custom certs (see #1154), however, the configuration block uses an incorrect header.
On launch, the new GPU AMI containerd config in /etc/containerd/config.toml (after cloud-init has ran) has a config block that looks like this:
[plugins."io.containerd.grpc.v1.cri".registry]
config_path = "/etc/containerd/certs.d:/etc/docker/certs.d"

While this is correct for the regular EKS AMI, the changes made for the GPU version require the header to be just plugins.cri.registry.
What you expected to happen:
The containerd config's certificate block should look like this:
[plugins.cri.registry]
config_path = "/etc/containerd/certs.d:/etc/docker/certs.d"

How to reproduce it (as minimally and precisely as possible):

Launch an EKS 1.24 GPU AMI
Check /etc/containerd/config.toml
See config block is [plugins."io.containerd.grpc.v1.cri".registry]
Try installing a cert into either directory and pulling from a private registry

Anything else we need to know?:
I also noted this on the original ticket: https://github.com/awslabs/amazon-eks-ami/issues/1154#issuecomment-1414711705
However, that ticket is closed now so I'm opening a new one for visibility.
Environment:

AWS Region: us-west-2
Instance Type(s): g4dn.xlarge
EKS Platform version (use aws eks describe-cluster --name <name> --query cluster.platformVersion): eks.3
Kubernetes version (use aws eks describe-cluster --name <name> --query cluster.version): 1.24
AMI Version: ami-0ebb35dfd192c3613
Kernel (e.g. uname -a): Linux ip-10-0-37-68.us-west-2.compute.internal 5.4.228-131.415.amzn2.x86_64 #1 SMP Tue Dec 20 12:51:02 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Release information (run cat /etc/eks/release on a node):

BASE_AMI_ID="ami-04e0068781ee1fe9e"
BUILD_TIME="Fri Jan 27 01:49:21 UTC 2023"
BUILD_KERNEL="5.4.228-131.415.amzn2.x86_64"
ARCH="x86_64"

Ah, sorry about that @Secretions; I'll get this fixed.

Thanks!

I've made this change, and it will ship in the next AMI release 👍

Is there a reason why version 2 isn't used in GPU ami's ?

Is there a reason why version 2 isn't used in GPU ami's ?

I have the same question


Conformance tests cannot run on v1.2.1

This is caused by https://github.com/kubernetes-sigs/gateway-api/pull/3211 which overrides the passed in Client as mentioned here: https://github.com/kubernetes-sigs/gateway-api/pull/3343#discussion_r1764102336. Due to this change Microsoft Azure's implementation of the conformance tests is broken because we had a custom Client that was passed in while setting up the conformance suite.
What would you like to be added:  Ensure that the Client is still configurable for implementors to override if needed
Why this is needed: Unable to upgrade to v1.2.1 because it breaks conformance tests.
cc @howardjohn @BobyMCbobs

Thanks for reporting this @snehachhabria! To clarify, is this a regression between v1.2.0 and v1.2.1, or is it a problem with all v1.2 releases?
/cc @mlavacca

Thanks for reporting this @snehachhabria! To clarify, is this a regression between v1.2.0 and v1.2.1, or is it a problem with all v1.2 releases?
/cc @mlavacca
it's a problem with v1.2

/kind bug

Thanks for reporting this issue, @snehachhabria! With #3343 we introduced the possibility to customize the client options to be able to pass scheme, mapper, etc. Isn't the ClientOptions field enough to fit your needs?

Thanks for reporting this issue, @snehachhabria! With #3343 we introduced the possibility to customize the client options to be able to pass scheme, mapper, etc. Isn't the ClientOptions field enough to fit your needs?

Unfortunately not, exposing the Client allows us to modify the writer interface for the Create/Update function to add some custom annotations while creating gateway objects

Are there any more details you can share about what you need to add? Maybe that might be useful for other folks as well, and we should build support directly into the tests?

Our implementation requires custom annotations on the gateway object, sample can be found here: https://learn.microsoft.com/en-us/azure/application-gateway/for-containers/how-to-traffic-splitting-gateway-api?tabs=alb-managed#deploy-the-required-gateway-api-resources . In order to add these annotations to the gateway objects created by the conformance suite we have modified the Create/Update function exposed via the client.
It would be great if support for annotations on Gateway objects can be supported directly via the test suit, similar to how namespace annotations are exposed: https://github.com/kubernetes-sigs/gateway-api/blob/99a3934c6bc1ce0874f3a4c5f20cafd8977ffcb4/conformance/utils/suite/suite.go#L137 . That way it could potentially be used by other implementors as well

To be honest, it's really intended that what's described in that doc is implemented by having a GatewayClass that sets all Gateways associated to it to use the configured ALB.
I really don't like the approach of using annotations on Gateway to do this - it's totally against one of the major design goals of Gateway API, which is to pull that kind of config out of annotations and into structured fields and more specific resources.

+1 to @youngnick's comment here. In my mind, one of the most important purposes of conformance tests is ensuring that users will get the same shared experience out of the box with our portable features. Obviously implementations should feel welcome to add features on top of the core API, but we really want the base API and examples to work without any changes (other than setting a GatewayClass name on a Gateway).
If I'm understanding this specific modification correctly, it seems like users would need to manually configure some annotations on each Gateway, which goes against the API experience we're trying to guarantee with conformance tests and status.

@youngnick and @robscott thanks a lot of sharing your thoughts. I completely understand the primary design goal of Gateway API is not to have any configurability via annotations. Given the limitations that existed at the time we were implementing Gateway API and our infrastructure/design needs we had to go down the route of using an annotation on the Gateway object.
I understand if providing support for annotations on the gateway object in the conformance is against the experience desired and shouldn't be exposed. But if we could go back to having the Client exposed, like it was prior to release v1.2, we would still be able to run the conformance tests and generate the reports. We are still conformant with all of Gateway API's requirements and would like to continue doing so, the conformance tests aid this and it would be great if we can run them as is without too many modifications from our end.


LogicApps Custom connector - Unable  to initialize operation details for swagger operation

Describe the Bug with repro steps
After the UX migration to the new designer, a workflow that uses a custom connector stopped working.
The custom connector action finishes as successful (green check) even though it shows the message "Unable to initialize operation details for swagger based operation - Error details - Incomplete information for operation ''" during the run history.    I'm also unable to edit the operation and the tabs "Parameters, Settings, Code View, Testing, About" do not appear.
This custom connector uses a "dynamic" connection.
"connection": {
"name": "@parameters('$connections')              [variables('dynamicConnName')]['connectionId']"
}
What type of Logic App Is this happening in?
Consumption (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Chrome
Additional context
No response

Having the same exact issue as above, any leads will be helpful thanks

Hi @fsarabia + @harshalCG,
I'm currently investigating this issue, could either/both of you send me your workflow.json file?
Possibly also your connections.json file just to be safe, feel free to remove anything values might think are sensitive if you'd like
My email is<EMAIL_ADDRESS>

We are unable to resolve the connections because it refers logic app variables in combination with workflow parameters. Currently this is an unsupported scenario because variable values are determined or changed during runtime. We do not resolve variables in the connection expression but we do for workflow parameters.
If this is an arm template variable then this should be sent as resolved before we load the designer, but looks like it is LA variables.

The flow is not failing, it executes as it should but it shows the
error/warning in the runtime log which is very confusing.  It’s
understandable that it cannot resolve a dynamic connection, but this
warning  is misleading and it didn’t work like that before.  Thanks!
On Mon, Apr 29, 2024 at 7:21 PM preetriti1 @.***> wrote:

We are unable to resolve the connections because it refers logic app
variables in combination with workflow parameters. Currently this is an
unsupported scenario because variable values are determined or changed
during runtime. We do not resolve variables in the connection expression
but we do for workflow parameters.
If this is an arm template variable then this should be sent as resolved
before we load the designer, but looks like it is LA variables.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/LogicAppsUX/issues/4675#issuecomment-2084205358,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGALEMLVDCF5TLT5GTCTPVTY73533AVCNFSM6AAAAABGT32VO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUGIYDKMZVHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@fsarabia PLease send a screenshot of which warning you are talking about.

See the screenshots, I also have included one from the previous UX for you
to compare. Thanks!
All images are from run history.
[image: Screenshot 2024-04-30 at 2.54.02 PM.png]
[image: Screenshot 2024-04-30 at 2.54.14 PM.png]
Previous UX (no warning/error displayed)
[image: Screenshot 2024-04-30 at 2.55.09 PM.png]
On Tue, Apr 30, 2024 at 1:14 PM preetriti1 @.***> wrote:

@fsarabia https://github.com/fsarabia PLease send a screenshot of which
warning you are talking about.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/LogicAppsUX/issues/4675#issuecomment-2087052017,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGALEMMVUEF3OVZ3GYAR5CDY773SVAVCNFSM6AAAAABGT32VO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBXGA2TEMBRG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@fsarabia  - I do not see any screenshots attached. Can you please reattach the screenshots?

I was able to get past this error, had to switch from the new designer view to the old designer view and that solved the issue

@fsarabia @harshalCG - PLease share the screenshots of the warning you saw earlier, the ones previously shared is not available in teh issue please check. Also old designer is retiring on September 1st


probs with interpolation in attributes

Thanks for putting this together--perfect timing for us :)
I'm trying to find the easiest way to conditionally include an attribute, and running into the following. E.g.,:
    - var target = thumbnail_url ? "target=\\"_blank\\"" : null
    %a( href="#{id}" #{target} )= name

This seems really awkward and so I am thinking of hacking the attribute parser to add some sort of conditional interpolation. Any thoughts on this?   But, unfortunately, even the above does not work as expected and instead produces:
   var _$output="";var target = thumbnail_url ? "target=\"_blank\"" : null; _$output = _$output  +
"" +
name +
"";

which clearly (note the lack of interpolation of #{target} and the dangling quote ") seems like a bug, no?
Thanks!
tv/

FWIW, I stumbled across this issue and reading it saved me a lot of time.


[Android] Incorrect bold font processing

Preconditions:
Platform: Android
"react-native": "0.63.3",
"react-native-parsed-text": "^0.0.22",

Issue:
Could someone explain this behavior? And how could we fix it?

code:
 <ParsedText style={{fontSize: 50, fontFamily: Nobblee.Bold}}>
    {'HELLO'}
 </ParsedText>

result (as expected)

code:
 <ParsedText style={{fontSize: 50, fontFamily: Nobblee.Bold}} parse={[]}>
    {'HELLO'}
 </ParsedText>

result (as NOT expected)

And this happens for any array of parse param. BUT SHOULD NOT!
I configured some banch of parse templates, but usual text is affected because of this.
Any clues?

I've put this font here as well
EENobblee-Bold.ttf.zip

@fbartho

@fbartho, anyone? any clues?

@aviemore no idea! -- this is super interesting. It might be a bug in how the top level text object is built. I would expect those two cases to be the same.
I would try to compare the Component tree in both cases (using the Inspector).
I suspect something different is happening in parse() here: https://github.com/taskrabbit/react-native-parsed-text/blob/fded31e2012959d1d4c3ade0e47e4d826e732fd0/src/ParsedText.js#L110

Same issue here, hates any font beyond a regular weight. Bold, semibold, all act the same on Android

@miamiappmachine Have you tried to use the inspector to understand what's happening to the Text / Font Styling?

Bizarrely I can't even select it on the element inspector in Android. No problem at all to select it on iOS (where it works perfectly)

That is indeed super strange. Maybe React-Native Android no longer supports Nested <Text> objects? This is the type of platform-specific difference that has cropped up in the past (Shadows are different on iOS vs Android, <Image> can be embedded in one of the <Text> implementations but not the other…)
Please do report back what you found. I would totally accept a PR if you find the root issue! -- My team's apps no longer use this library (this was previously used by our Chat code, but we now have a Vendor for that, and that vendor doesn't use this library).
So while I'm happy to help review code, and find a fix, I don't have an experimental test-bed actively set up.

Hey all -  problem solved. Patch file attached.
react-native-parsed-text+0.0.22.patch.zip

Another workaround is just to pass the text as an array in your code.
So e.g.
<ParsedText style={{fontSize: 50, fontFamily: Nobblee.Bold}} parse={[]}>
    {['HELLO']}
 </ParsedText>

or if you have your own component
<ParsedText style={{fontSize: 50, fontFamily: Nobblee.Bold}} parse={[]}>
    {[children]}
 </ParsedText>


Typewriter effect in the blog page

I suggest implementing a typewriter effect for the blog page's content to improve the visuals. Below is a video of the implementation,
https://user-images.githubusercontent.com/79045568/214353233-043d52ee-0c81-4441-b20f-5d2522ce37c1.mp4
The implementation makes use of javascript along with some logic to display

Sure, go ahead

Closing the issue


Active label

Hi,
How to use like that? https://github.com/timomeh/react-native-material-bottom-navigation/blob/master/.github/color-4-tab.gif

There is code for this exact example directly in the second chapter "But how? (Usage)" of the README. Also, there's a directory called /example with three examples for standalone usage or usage together with react-navigation. All examples will reproduce the exact gif you referenced. The react-navigation example has just three tabs, but adding a fourth tab shouldn't be that hard.
I'm going to close this issue since the README and the examples provide all the necessary informations to get you started. If you think there are some missing informations, please explain what is missing and/or should be improved.


Haplocheck

Description of feature
To detect in-sample contamination

https://github.com/genepi/haplocheck


Examples sometimes fail on start with error "Invalid get index 'global_position' (on base: 'Nil')"

Sometimes, the example scenes fail with:

Invalid get index 'global_position' (on base: 'Nil')

due to node being null in:
func move_to(delta:float, node:Node2D) -> int:
	if global_position.distance_to(node.global_position) > 10:

It seems easy to reproduce the error by opening just a scene like player.tscn or lumberjack.tscn.
However, when opening main.tscn, behavior is erratical: sometimes I have the error, sometimes I don't.

I already saw this error somewhere...
@hsandt on which addon version do you reproducde the issue ? Is that on 3.0.0 or in HEAD (latest sources) ?

v3.0.0 downloaded from Asset Library.
Will try v3.1.0 now.

With v3.1.0 + examples downloaded from repository main branch (should correspond to same version), I get a different error (on all examples):

Invalid call. Nonexistent function 'append' in base 'Nil'.

in
func declare_presence(blackboard:BTBlackboard) -> int:
	blackboard.get_data("players").append(player_name)  # here
	return BTTickResult.SUCCESS

Apparently, players data is missing.

@hsandt I reproduce your issue, but it's not a real one. It occurs when your directly play the player.tscn scene (or lumberjack.tscn scene, with a slitly different error).
For every example, the main.tscn scene should be run. Doing it, it should work as expected. Can you check this ?

I know it triggers at 100% when opening the isolated scenes yes. But for some reason after doing that, even if you open the main scenes, you can trigger the error in the main scene too.
No, wait, I got it. It's because of Godot 4 new Run Current Scene (F6) behavior: it will replay the last scene instead of the last opened scene until you Stop Running Project (F8).
I knew it was disturbing but it wasn't such an issue until now. I'll close this issue and see with the team if we can't get the old behavior as an option.


new resource SPWebApplicationExtension

new resource SPWebApplicationExtension

[x] Change details added to Unreleased section of changelog.md?
[x] Added/updated documentation and descriptions in .schema.mof files where appropriate?
[x] Examples updated for both the single server and small farm templates in the examples folder?
[x] New/changed code adheres to Style Guidelines?
[x] Unit and Integration tests created/updated where possible? [unit tests only]

This change is

working on the failing tests... they worked before, but now they are not :)

@MikeLacher448 How you going with those tests dude? Had a chance to look at them yet?

Review status: 0 of 7 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Can we include the AuthenticationProvider and Claims stuff in this resource as well to keep it consistent. See #513 for implementation details. SPWebApplication now has 100% unit test coverage, would guess you could shift almost all of them over.

@MikeLacher448 What do you think about pulling the claims stuff in from @mrpullen 's branch there? Reckon you can slide this in as well?

I'll take a look at the claims code from spwebapplication and fit them into here as well.

Codecov Report

Merging #510 into dev will decrease coverage by 1%.
The diff coverage is <1%.

@@         Coverage Diff          @@
##            dev   #510    +/-   ##
====================================
- Coverage    88%    87%    -2%
====================================
  Files        80     81     +1
  Lines      7589   7696   +107
  Branches      3      3
====================================
+ Hits       6716   6717     +1
- Misses      870    976   +106
  Partials      3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6aea22...93f15ab. Read the comment docs.

ok, I think I got this one all set now

Overall a pretty decent effort dude - got a few things that need cleaning up though. Details below.

Reviewed 6 of 6 files at r3.
Review status: all files reviewed at latest revision, 14 unresolved discussions.

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 75 at r3 (raw file):

        if ($null -eq $wa)
        {
            Write-Verbose "WebApplication $($params.WebAppUrl) does not exist"

Avoid positional parameters
Write-Verbose -Message "...

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 99 at r3 (raw file):

        }

        $PublicUrl = (Get-SPAlternateURL -WebApplication $params.WebAppUrl -Zone $params.zone).PublicUrl

lower case on the first letter of variables that aren't parameters

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 99 at r3 (raw file):

        }

        $PublicUrl = (Get-SPAlternateURL -WebApplication $params.WebAppUrl -Zone $params.zone).PublicUrl

Is there are scenario here where someone has set alternate URLs without an extension that might screw with this? I'm not 100% so wanted to ask the question

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 236 at r3 (raw file):

        $zone = [Microsoft.SharePoint.Administration.SPUrlZone]::$($params.Zone)

This line and the next couple are out of line in terms of indentation

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 252 at r3 (raw file):

                    if($params.AuthenticationMethod -eq "Claims")
                    {
                       try {

need to drop the brace here to a new line

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 254 at r3 (raw file):

                       try {
                            $ap = Get-SPTrustedIdentityTokenIssuer -Identity $params.AuthenticationProvider -ErrorAction Stop
                        } catch {

need to drop the catch and then the brace here to new lines each

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 292 at r3 (raw file):

            }
        else {
            write-verbose 'extension exists'

Need to use positional parameter for "Message" here, but can we also make the message a little more descriptive so it makes sense when seen in the logs

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 303 at r3 (raw file):

                if($params.AuthenticationMethod -eq "Claims")
                {
                    try {

Same note here about moving braces to new lines

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 413 at r3 (raw file):

    $CurrentValues = Get-TargetResource @PSBoundParameters

    Write-Verbose "Got the current Values"

We don't need this here I don't think

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 418 at r3 (raw file):

                                                     -DesiredValues $PSBoundParameters `
                                                     -ValuesToCheck @("Ensure","AuthenticationMethod","AllowAnonymous")
    Write-Verbose "Tested the current Values"

Definitely don't need this one here

Tests/Unit/SharePointDsc/SharePointDsc.SPWebApplicationExtension.Tests.ps1, line 45 at r3 (raw file):

        # Test contexts

Can we add a context that tests the set method were the authentication method is "claims" but there is no provider listed? Just to check that it throws the exceptions. Also we need one that will see Get-SPTrustedIdentityTokenIssuer throw an error so we can test that logic too.

Tests/Unit/SharePointDsc/SharePointDsc.SPWebApplicationExtension.Tests.ps1, line 46 at r3 (raw file):

        # Test contexts
        Context -Name "The parent web application does not exist" -Fixture {

Can we add tests to this context for the get and test methods as well (get returning "absent" on the ensure property, and test returning false)

Tests/Unit/SharePointDsc/SharePointDsc.SPWebApplicationExtension.Tests.ps1, line 59 at r3 (raw file):

            It "retrieving non-existent web application fails in the set method" {
                { Set-TargetResource @testParams } | Should Throw "Web Application with URL http://nosuchwebapplication.sharepoint.com does not exist"

Can we substitute the URL here with $($testParams.WebAppUrl) so if we ever change it then it doesn't need to be changed here as well?

Tests/Unit/SharePointDsc/SharePointDsc.SPWebApplicationExtension.Tests.ps1, line 176 at r3 (raw file):

        Context -Name "The web appliation extension does exist and should that uses NTLM without AllowAnonymous" -Fixture {

Can you repeat this context with the HTTPS and SecureBindings properties?

Comments from Reviewable

will clean up the code today and re-commit... some of my extra write-verbose statements were just for troubleshooting and I forgot to remove them.

give me another day or two to work on the extra test cases, will re-commit by Monday.

Review status: all files reviewed at latest revision, 14 unresolved discussions, some commit checks failed.

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 75 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
Avoid positional parameters
Write-Verbose -Message "...

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 99 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
Is there are scenario here where someone has set alternate URLs without an extension that might screw with this? I'm not 100% so wanted to ask the question

Hadn't really considered that, since product guidance is to not assign URLs to zones without a web app extension to back them up. I will try to create that situation in my lab and test to see what happens.
UPDATE: if an alternate URL is set without an extension,  than the IIS settings properties for the zone will be null, so the resource will treat it as absent, and create the extension if it should be present.

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 99 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
lower case on the first letter of variables that aren't parameters

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 236 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
This line and the next couple are out of line in terms of indentation

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 252 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
need to drop the brace here to a new line

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 254 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
need to drop the catch and then the brace here to new lines each

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 292 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
Need to use positional parameter for "Message" here, but can we also make the message a little more descriptive so it makes sense when seen in the logs

pulled this one out, was left over from testing

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 303 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
Same note here about moving braces to new lines

Done.

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 413 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
We don't need this here I don't think

deleted, left over from testing

Modules/SharePointDsc/DSCResources/MSFT_SPWebApplicationExtension/MSFT_SPWebApplicationExtension.psm1, line 418 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
Definitely don't need this one here

deleted, left over from testing

Tests/Unit/SharePointDsc/SharePointDsc.SPWebApplicationExtension.Tests.ps1, line 45 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
Can we add a context that tests the set method were the authentication method is "claims" but there is no provider listed? Just to check that it throws the exceptions. Also we need one that will see Get-SPTrustedIdentityTokenIssuer throw an error so we can test that logic too.

Done.

Tests/Unit/SharePointDsc/SharePointDsc.SPWebApplicationExtension.Tests.ps1, line 46 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
Can we add tests to this context for the get and test methods as well (get returning "absent" on the ensure property, and test returning false)

Done.

Tests/Unit/SharePointDsc/SharePointDsc.SPWebApplicationExtension.Tests.ps1, line 59 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
Can we substitute the URL here with $($testParams.WebAppUrl) so if we ever change it then it doesn't need to be changed here as well?

Done.

Tests/Unit/SharePointDsc/SharePointDsc.SPWebApplicationExtension.Tests.ps1, line 176 at r3 (raw file):
Previously, BrianFarnhill (Brian Farnhill) wrote…
Can you repeat this context with the HTTPS and SecureBindings properties?

Done.

Comments from Reviewable

Reviewed 3 of 3 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


source-map-explorer does not work

Describe the bug
running source-map-explorer produces  an error:
`npx source-map-explorer 'build/static/js/*.js'
npx: installed 78 in 4.925s
build/static/js/2.b41502e9.chunk.js
Unable to map 130/118776 bytes (0.11%)
build/static/js/main.28647029.chunk.js
Unable to map 123/1118 bytes (11.00%)
build/static/js/runtime~main.a8a9905a.js

Your source map only contains one source (../webpack/bootstrap).
This can happen if you use browserify+uglifyjs, for example, and don't set the --in-source-map flag to uglify.
See https://github.com/danvk/source-map-explorer/blob/master/README.md#generating-source-maps`

Did you try recovering your dependencies?
Yes this was a result of

npx create-react-app junk
cd junk
npm run build
npx source-map-explorer 'build/static/js/*.js'

I
Have you done all these steps and still see the issue?
Please paste the output of npm --version and/or yarn --version to confirm.
-->
(Write your answer here.)
npm version 6.10.1
Which terms did you search for in User Guide?
source-map-explorer
(Write your answer here if relevant.)
Environment

Environment Info:                                                                                │···················
│···················
System:                                                                                │···················
OS: Linux 4.15 Ubuntu 18.04.2 LTS (Bionic Beaver)                                                                                │···················
CPU: (2) x64 Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz                                                                                │···················
Binaries:                                                                                │···················
Node: 11.14.0 - ~/.nvm/versions/node/v11.14.0/bin/node                                                                                │···················
Yarn: Not Found                                                                                │···················
npm: 6.10.1 - ~/.nvm/versions/node/v11.14.0/bin/npm                                                                                │···················
Browsers:                                                                                │···················
Chrome: Not Found                                                                                │···················
Firefox: Not Found                                                                                │···················
npmPackages:                                                                                │···················
react: ^16.8.6 => 16.8.6                                                                                │···················
react-dom: ^16.8.6 => 16.8.6                                                                                │···················
react-scripts: 3.0.1 => 3.0.1                                                                                │···················
npmGlobalPackages:                                                                                │···················
create-react-app: Not Found
Steps to reproduce

(Write your steps here:)

npx create-react-app junk
cd junk
npm run build
npx source-map-explorer 'build/static/js/*.js'

Expected behavior
show analysis
Actual behavior

This message is expected.  Did your browser open with the results?

No it did not. Because it was a remote machine.
Suggestion: in the react documentation add a line after this:
"analyze": "source-map-explorer 'build/static/js/*.js'",
OR for a headless development environment
"analyze": "source-map-explorer 'build/static/js/*.js' --html sme_result.html",

PRs welcome


Replace dirlist with function filtering out images

Fix for https://github.com/FallingSnow/lightdm-webkit2-material2/issues/14

Haven't forgotten about this, just fyi. Just need to find some time to make sure there isn't a better way to handle this.

No hurry, I am using forked version. The best way to handle this is requesting Antergos to add function like dirfiles().


High channel selection value

The minimum RSSI value for detecting a video channel is hard coded to 150. Reports state that this is way to high.
On the other hand the noise floor of some receivers seems to be as high as 100.
This issue is directly associated with issue 6.

This turned out to be a red herring. The receiver module in question suffered from a bad solder joint.


proposal: io/fs: return ErrInvalid if the pattern argument of Glob is not a valid path

If pattern is a well-formed pattern but it does not satisfy fs.ValidPath(pattern), fs.Glob(fsys, pattern) does not return matchings and does not return errors.
For example, if fs.Glob(fsys, "a") returns []string{"a"} and nil, these other calls
fs.Glob(fsys, "/a")
fs.Glob(fsys, "a/")
fs.Glob(fsys, "./a")

return nil and nil:
I propose, before the 1.16 release, that the fs.Glob function returns the fs.ErrInvalid error if pattern is a well-formed pattern but does not satisfy fs.ValidPath instead of returning a nil matched and a nil error.
Note that the filepath.Glob function, as fs.Glob, can return only the path.ErrBadPattern error but filepath.Glob cleans the pattern before matching the files, fs.Glob doesn't.
Note also that //go:embed has the same pattern syntax of fs.Glob (except ".") but
//go:embed pattern
var files embed.FS

does not compile if pattern does not satisfy fs.ValidPath, instead of assigning to files an empty file system.

I think it would also be reasonable to instead return ErrBadPattern for these inputs: ErrBadPattern already indicates a pattern that cannot possibly match any files.

I am not at all sure we should make any change here.

fs.Glob(fsys, "/a")

The directory "/" does not exist in an FS; that's why "/*" doesn't have any matches.
It seems wrong to report that as path.ErrBadPattern, especially since path.Match accepts it.
It's also not invalid. It's a valid pattern, it just doesn't describe any files.
Instead we currently treat it like other non-existent paths, like "does-not-exist/*".
As another analogy, if we are running on a file system without support for Unicode,
we don't make filepath.Glob("☺*") return ErrBadPattern or ErrInvalid.
It just returns no match.

fs.Glob(fsys, "a/")

filepath.Glob returns no matches and no error for this too.
It seems especially wrong to make fs.Glob return an error that filepath.Glob does not.

fs.Glob(fsys, "./a")

I am more sympathetic to this example than /a, but not enough to make an exception.
Open("./a") fails too, of course, just like Open("/a").
These are valid patterns. They just don't describe openable files.
In the first two examples the behavior seems clearly correct (given the non-existence of / and the current behavior of filepath.Glob). That leaves only the third, but a special case would add more complexity about interpreting error results and deviate from the other two.

@rsc Thanks, I get your point and I'm fine to close this issue. Perhaps a note in the documentation could help to better understand this behavior, which after your exposition I believe correct.

No change in consensus, so declined.
— rsc for the proposal review group


Midi player not working

I am using the midi player in a personal project, it was working fine until yesterday, but today the play button is disabled:

When I see the console it shows me the following error: Uncaught (in promise) TypeError: h.ToneAudioBuffers is not a constructor:

My project is at https://www.komposair.com/ I am not sure if it is an error on my end or if this is the place to report it... but since it was working fine I thought it is something else. Any help would be appreciated...

Thanks for reporting this! It turns out @magenta/music got upgraded today to version 1.21.0 and now depends on a more recent major version of tone (14.7.58). Upgrading tone to this version seems to fix the problem. It may be a good idea to pin exact versions of  the libraries to ensure that upgrades like this don't break your project. I think I will do the same in my examples. E.g.:
<script src="https://cdn.jsdelivr.net/combine/npm/tone@14.7.58,npm/@magenta/music@1.21.0/es6/core.js,npm/focus-visible<EMAIL_ADDRESS>

Great! Thank you very much


Gra 1253 docker

Describe your changes
update docker for new join/register command
Provide Issue ticket number if applicable/not in title
Provide link to Netmaker PR if required
Provide testing steps
Checklist before requesting a review

[ ] My changes affect only 10 files or less.
[ ] I have performed a self-review of my code and tested it.
[ ] If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
[ ] If it is a bugfix, my code is <= 200 lines.
[ ] My functions are <= 80 lines.
[ ] I have had my code reviewed by a peer.
[ ] My unit tests pass locally.
[ ] Netclient & Netmaker are awesome.

created from wrong branch


multi-allele: store strain background from Canto

Make sure that the background strain is added to the JSON files and that we load it.
Original comment by: kimrutherford

The Canto JSON export now writes out the genotype background and the Chado loader code has been changed to store it.  Needs a full load to test.

I guess this should be done soon.
Is it part of the proposed display?

I guess this should be done soon.

Should be in V54 if the next load works OK.

Is it part of the proposed display?

Not at the moment I think.

The background is stored no.  It's a featureprop on the genotypes with the type "genotype_background".
I've just documented that on the pombase-chado wiki.


Feature Request - Restore ElastiCache

Currently cloudcustodian supports the actions: snapshot and delete but restore is not. My goal is to backup a cluster and delete it at night, then restore it in the morning to save aws costs on elasticache

That’s sounds pretty good. We would need off hours filter on elasticache and on hours filter on snapshot as well. Restore typically involves capturing some additional config/cache values as snapshot tags for automation


Upgrade gems across the board

Review app deployed to https://teaching-vacancies-review-pr-2926.london.cloudapps.digital


the paramaters in args.py

piecewise params
pw_boundaries = [60, 80]  # epoch based boundaries
pw_values = [learning_rate_init, 3e-5, 1e-4]
what is mean??  how to change it???

EVAL: Recall: 0.0037, Precison: 0.0001, mAP: 0.0000
EVAL: loss: total: 7655.04, xy: 1.30, wh: 21.19, conf: 7626.28, class: 6.28
at first ,the loss is very big???7655?


Add support for emphasized comments

I personally prefer comments to be more prominent than code, for a variety of reasons:

Well written comments are the reader's guide through the code;
Outdated comments are much more bothersome and thus less likely to be ignored;
Commented out code is far more annoying and is more likely to be deleted.

However, not everyone feels the same way, so I didn't make a wholesale change to the colorscheme, instead implementing a feature flag to make them more visible.
The flag is off by default, resulting in the colorscheme looking as it does now:

Enabling it via
let g:iceberg_emphasize_comments=1

turns the comments white:

Hopefully this seems like it could be helpful. I'm happy to maintain my own fork, but would obviously prefer the theme to support it out of the box, and I'd like to give back. Thanks for such a great colorscheme! 🇦🇶

Thank you for the kind pull request. Very interesting! I think writing good comments is important too.
Maybe adding options helps professional users, but...

it increases complexity
it increases a maintenance cost

Currently I want to focus a core value of the color scheme, so I think it's good to maintain the feature as your fork. Sorry :bow:

No problem, happy to do so.
Thanks again for the theme itself!


player.seekto() exception when playing encrypted video: Invalid NAL length

I use encrypt with “AES/CBC/PKCS5Padding”
I am playing a local encrypted video. after setting the video resource, sliding the progress bar to set the playback progress(player.seekTo) will cause an exception:
ExoPlayerImplInternal: Playback error
androidx.media3.exoplayer.ExoPlaybackException: Source error
at androidx.media3.exoplayer.ExoPlayerImplInternal.handleIoException(ExoPlayerImplInternal.java:736)
at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:706)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:219)
at android.os.HandlerThread.run(HandlerThread.java:67)
Caused by: androidx.media3.common.ParserException: Invalid NAL length{contentIsMalformed=true, dataType=1}
at androidx.media3.extractor.mp4.Mp4Extractor.readSample(Mp4Extractor.java:725)
at androidx.media3.extractor.mp4.Mp4Extractor.read(Mp4Extractor.java:332)
at androidx.media3.exoplayer.source.BundledExtractorsAdapter.read(BundledExtractorsAdapter.java:147)
at androidx.media3.exoplayer.source.ProgressiveMediaPeriod$ExtractingLoadable.load(ProgressiveMediaPeriod.java:1082)
at androidx.media3.exoplayer.upstream.Loader$LoadTask.run(Loader.java:421)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:929)
when the encrypted video is played to the last frame, the output error:
E/ExoPlayerImplInternal: Playback error
androidx.media3.exoplayer.ExoPlaybackException: Source error
at androidx.media3.exoplayer.ExoPlayerImplInternal.handleIoException(ExoPlayerImplInternal.java:736)
at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:712)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:219)
at android.os.HandlerThread.run(HandlerThread.java:67)
Caused by: java.io.EOFException
at androidx.media3.exoplayer.source.SampleDataQueue.sampleData(SampleDataQueue.java:186)
at androidx.media3.exoplayer.source.SampleQueue.sampleData(SampleQueue.java:602)
at androidx.media3.extractor.TrackOutput.sampleData(TrackOutput.java:161)
at androidx.media3.extractor.mp4.Mp4Extractor.readSample(Mp4Extractor.java:755)
at androidx.media3.extractor.mp4.Mp4Extractor.read(Mp4Extractor.java:332)
at androidx.media3.exoplayer.source.BundledExtractorsAdapter.read(BundledExtractorsAdapter.java:147)
at androidx.media3.exoplayer.source.ProgressiveMediaPeriod$ExtractingLoadable.load(ProgressiveMediaPeriod.java:1082)
at androidx.media3.exoplayer.upstream.Loader$LoadTask.run(Loader.java:421)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:929)
but after the video is decrypted and output as an mp4 file, it is normal to play it again, so my encrypted video file seems to be fine?
after several days of trying, I have not found a solution yet. please help me!

Add the SDK version：
implementation 'androidx.media3:media3-exoplayer:1.4.0'
implementation 'androidx.media3:media3-exoplayer-dash:1.4.0'
implementation 'androidx.media3:media3-ui:1.4.0'

The test has passed using DataSourceContractTest, please see the screenshot:

Below is all my code:
EncryptedDataSourceTest.java：
`@RunWith(AndroidJUnit4.class)
public class EncryptedDataSourceTest extends DataSourceContractTest {
private static final String TEST_FILE_PATH = "/storage/emulated/0/a/v/abc.mp4";
@Override
protected DataSource createDataSource() throws Exception {
    Cipher cipher = AesPassUtils.getCipher(Cipher.DECRYPT_MODE,AesPassUtils.AES_KEY,AesPassUtils.AES_IV);
    return new AESDecryptionDataSource(new AESDecryptionDataSourceFactory(cipher).createDataSource(),cipher);
}

@Override
protected ImmutableList<TestResource> getTestResources() throws Exception {
    return null;
}

@Override
protected Uri getNotFoundUri() {
    return null;
}

@Test
public void testEncryptedFileCanBeRead() throws Exception {
    DataSource dataSource = createDataSource();
    dataSource.open(new DataSpec(Uri.parse(TEST_FILE_PATH)));
    byte[] buffer = new byte[1024];
    int bytesRead = dataSource.read(buffer, 0, buffer.length);
    assertTrue("The encrypted file should be readable after decryption", bytesRead > 0);
    dataSource.close();
}

@Test
public void testPlayDecryptedVideo() throws Exception {
    Context context = ApplicationProvider.getApplicationContext();
    ExoPlayer[] player = new ExoPlayer[1];
    InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> {
        player[0] = new ExoPlayer.Builder(context).build();
    });

    DataSource.Factory dataSourceFactory = new DataSource.Factory() {
        @Override
        public DataSource createDataSource() {
            try {
                return EncryptedDataSourceTest.this.createDataSource();
            } catch (Exception e) {
                e.printStackTrace();
                return null;
            }
        }
    };

    MediaSource mediaSource = new ProgressiveMediaSource.Factory(dataSourceFactory)
            .createMediaSource(MediaItem.fromUri(Uri.parse(TEST_FILE_PATH)));

    // main thread
    InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> {
        player[0].setMediaSource(mediaSource);
        player[0].prepare();
        player[0].play();
    });

    Thread.sleep(5000);

    InstrumentationRegistry.getInstrumentation().runOnMainSync(() -> {
        System.out.println(String.format("ExoPlayer status：%d",player[0].getPlaybackState()));
        player[0].release();
    });
}

}`
AESDecryptionDataSource.java:
`public class AESDecryptionDataSource implements DataSource {
private final DataSource upstream;
private final Cipher cipher;
private InputStream inputStream;
private long bytesRemaining;

public AESDecryptionDataSource(DataSource upstream, Cipher cipher) {
    this.upstream = upstream;
    this.cipher = cipher;
}

@Override
public void addTransferListener(TransferListener transferListener) {
    upstream.addTransferListener(transferListener);
}

@Override
public long open(DataSpec dataSpec) throws IOException {
    long dataSpecLength = upstream.open(dataSpec);
    bytesRemaining = dataSpecLength == C.LENGTH_UNSET ? C.LENGTH_UNSET : dataSpecLength;

    inputStream = new CipherInputStream(new DataSourceInputStream(upstream, dataSpec), cipher);
    return dataSpecLength;
}

@Override
public int read(byte[] buffer, int offset, int readLength) throws IOException {
    if (bytesRemaining == 0) {
        return C.RESULT_END_OF_INPUT;
    }

    int bytesRead = inputStream.read(buffer, offset, readLength);
    if (bytesRead == -1) {
        return C.RESULT_END_OF_INPUT;
    }

    if (bytesRemaining != C.LENGTH_UNSET) {
        bytesRemaining -= bytesRead;
    }

    return bytesRead;
}

@Override
public Uri getUri() {
    return upstream.getUri();
}

@Override
public Map<String, List<String>> getResponseHeaders() {
    return DataSource.super.getResponseHeaders();
}

@Override
public void close() throws IOException {
    try {
        if (inputStream != null) {
            inputStream.close();
        }
    } finally {
        upstream.close();
    }
}

private static class DataSourceInputStream extends InputStream {
    private final DataSource dataSource;
    private final DataSpec dataSpec;
    private boolean opened = false;

    DataSourceInputStream(DataSource dataSource, DataSpec dataSpec) {
        this.dataSource = dataSource;
        this.dataSpec = dataSpec;
    }

    @Override
    public int read() throws IOException {
        byte[] singleByte = new byte[1];
        int result = read(singleByte);
        return result == -1 ? -1 : (singleByte[0] & 0xFF);
    }

    @Override
    public int read(byte[] buffer, int offset, int readLength) throws IOException {
        if (!opened) {
            dataSource.open(dataSpec);
            opened = true;
        }
        return dataSource.read(buffer, offset, readLength);
    }

    @Override
    public void close() throws IOException {
        dataSource.close();
    }
}

}`
AESDecryptionDataSourceFactory.java:
`public class AESDecryptionDataSourceFactory implements DataSource.Factory {
private final DataSource.Factory fileDataSourceFactory;
private final Cipher cipher;
public AESDecryptionDataSourceFactory(Cipher cipher) {
this.cipher = cipher;
this.fileDataSourceFactory = new FileDataSource.Factory();
}
@Override
public DataSource createDataSource() {
return new AESDecryptionDataSource(fileDataSourceFactory.createDataSource(), cipher);
}
}`
hopefully this information can help resolve the issue

Something isn't right in your screenshot. I would expect to see all the tests defined in DataSourceContractTest being run, like when I run FileDataSourceContractTest:

In your screenshot it seems that none of these inherited tests are being run.
I would also expect to most of these tests failing with a NullPointerException because you can't return null from getTestResources() or getNotFoundUri().

I would take a look at FileDataSourceContractTest and work on fixing your test set-up so that the contract tests are running.

You may also want to take a look at https://github.com/androidx/media/issues/856. It's not clear to me if you're using block-based encryption, but if you are then you likely need similar code to that in https://github.com/androidx/media/issues/856#issuecomment-2308585356 which adjusts the read position of the upstream encrypted datasource to ensure it always starts from the beginning of a block.

@ladeng Reading can't be that hard, right? I quote myself from https://github.com/androidx/media/issues/856

If you want the tests to work then you need to skip that part of the diff. The compile will fail for various reasons which you will all have to fix appropriately.

+1, same error here

I'm going to close this because I think the original questions have been answered, and additional high-touch support on the details of implementing a DataSource correctly are beyond the capacity we have on this issue tracker. If you have more questions, please file a new issue with details of a passing run of a DataSourceContractTest (see my comment above for what this should look like: https://github.com/androidx/media/issues/1643#issuecomment-2313069109).


when  I  run   roslaunch vrx_gazebo vrx.launch   get an error

Error: Non-unique names detected in type plugin in
<model name='short_navigation_course_0'>
  <frame name='red_bound_0::__model__' attached_to='red_bound_0::link'>
    <pose relative_to='__model__'>0 0 0 0 -0 0</pose>
  </frame>
  <link name='red_bound_0::link'>
...
<plugin name='BuoyancyPlugin' filename='libbuoyancy_gazebo_plugin.so'>
    <wave_model>ocean_waves</wave_model>
    <fluid_density>1000</fluid_density>
    <fluid_level>0.0</fluid_level>
    <linear_drag>25.0</linear_drag>
    <angular_drag>2.0</angular_drag>
    <buoyancy name='buoyancy_sphere'>
      <link_name>red_bound_0::link</link_name>
      <pose>0 0 -0.12 0 0 0</pose>
      <geometry>
        <sphere>
          <radius>0.325</radius>
        </sphere>
      </geometry>
    </buoyancy>
  </plugin>

but i can not find this plugin in folder.  could  someone help me,  thanks !!!

when i run this roslaunch vrx_gazebo vrx.launch  Gazebo can only show the ocean, not the coastline

We were unable to reproduce this issue. The buoyancy plugin can be found in vrx/usv_gazebo_plugins/src.
Can you make sure that you have followed all the installation instructions and have sourced vrx_ws/devel/setup.bash in the terminal that you're using?

Since we could not reproduce this issue, we are closing it for now. Feel free to reopen this if you face any additional difficulty.


🌱 Bump Golang to 1.22.9

What this PR does / why we need it: :seedling: Bump Golang to 1.22.9 release 1.8

/retitle 🌱 Bump Golang to 1.22.9

/test test
/test metal3-ubuntu-e2e-integration-test-release-1-8

/test test


Add testing action

A user that develops a tutorial should be able to run a testing action alongside it.

All set #7


Error in Scenario 1, Step 9

Under Access controls > Grant, select the following options:
Require approved client app
Require app protection policy (preview)
Require one of the selected controls
This will grant access when either an approved app is used, or the app has protection policy (either or), not when an approved app with protections policy is used to access the service (AND condition).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14348ba7-48f0-1862-ebec-0fc3640e587d
Version Independent ID: 8188cee4-3f28-6014-f3be-1ee9e9b183b6
Content: App protection policies with Conditional Access - Azure Active Directory
Content Source: articles/active-directory/conditional-access/app-protection-based-conditional-access.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@new-kirte Thank you for your feedback! We will review and update as appropriate.

I'm assigning this to the author as we had some earlier feedback on that point this week.

Thanks!


When 'upserting' using LiteRepository without specifying collection name, a NullReferenceException is thrown

The following code works as expected:
_db.GetCollection<MyType>().Upsert(new MyType());

But this code throws:
new LiteRepository(_db).Upsert(new MyType());

I tried to reproduce this but it works as expected on my end. Therefor I'll close the issue.
Feel free to re-open the bug if you found a way to consistently reproduce this. 🙂


Error when running rosace from dumpling workflow

Hi, sorry if this is trivial, but I'm running into some issues when running the dumpling workflow. It appears to be related to the run_rosace script. Here is the error I get:
CalledProcessError in file /project/chlandry/users/rodur28/dumpling/workflow/rules/rosace.smk, line 18:
Command 'set -euo pipefail;  Rscript --vanilla /project/chlandry/users/rodur28/dumpling/.snakemake/scripts/tmpaxrm35zq.run_rosace.R' returned non-zero exit status 1.
[Wed Dec 11 13:11:29 2024]
Error in rule run_rosace:
    jobid: 1
    input: results/benchmark_RD/processed_counts/CN_alp_r1_F1_T0.tsv, results/benchmark_RD/processed_counts/CN_alp_r2_F1_T0.tsv, results/benchmark_RD/processed_counts/CN_alp_r1_F1_T1.tsv, results/benchmark_RD/processed_counts/CN_alp_r2_F1_T1.tsv, results/benchmark_RD/processed_counts/CN_alp_r1_F1_T2.tsv, results/benchmark_RD/processed_counts/CN_alp_r2_F1_T2.tsv
    output: results/benchmark_RD/rosace/scores_cond_A.tsv
    log: logs/benchmark_RD/rosace/benchmark_RD.rosace.log (check log file(s) for error details)

Traceback (most recent call last):
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/bin/enrich_cmd", line 8, in <module>
    sys.exit(main_cmd())
             ~~~~~~~~^^
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/enrich2/main.py", line 232, in main_cmd
    obj.calculate()
    ~~~~~~~~~~~~~^^
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/enrich2/experiment.py", line 159, in calculate
    self.calc_counts(label)
    ~~~~~~~~~~~~~~~~^^^^^^^
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/enrich2/experiment.py", line 254, in calc_counts
    data[(cnd.name, sel.name, "c_{}".format(tp))] = sel_data[
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/pandas/core/frame.py", line 4311, in __setitem__
    self._set_item(key, value)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/pandas/core/frame.py", line 4524, in _set_item
    value, refs = self._sanitize_column(value)
                  ~~~~~~~~~~~~~~~~~~~~~^^^^^^^
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/pandas/core/frame.py", line 5263, in _sanitize_column
    return _reindex_for_setitem(value, self.index)
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/pandas/core/frame.py", line 12692, in _reindex_for_setitem
    raise err
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/pandas/core/frame.py", line 12687, in _reindex_for_setitem
    reindexed_value = value.reindex(index)._values
                      ~~~~~~~~~~~~~^^^^^^^
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/pandas/core/series.py", line 5153, in reindex
    return super().reindex(
           ~~~~~~~~~~~~~~~^
        index=index,
        ^^^^^^^^^^^^
    ...<5 lines>...
        tolerance=tolerance,
        ^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/pandas/core/generic.py", line 5610, in reindex
    return self._reindex_axes(
           ~~~~~~~~~~~~~~~~~~^
        axes, level, limit, tolerance, method, fill_value, copy
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ).__finalize__(self, method="reindex")
    ^
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/pandas/core/generic.py", line 5633, in _reindex_axes
    new_index, indexer = ax.reindex(
                         ~~~~~~~~~~^
        labels, level=level, limit=limit, tolerance=tolerance, method=method
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/pandas/core/indexes/base.py", line 4429, in reindex
    raise ValueError("cannot reindex on an axis with duplicate labels")
ValueError: cannot reindex on an axis with duplicate labels
/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/tables/file.py:114: UnclosedFileWarning: Closing remaining open file: results/benchmark_RD/enrich/cond_A_rep2_T1_lib.h5
  warnings.warn(UnclosedFileWarning(msg))
/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/tables/file.py:114: UnclosedFileWarning: Closing remaining open file: results/benchmark_RD/enrich/cond_A_rep1_T2_lib.h5
  warnings.warn(UnclosedFileWarning(msg))
/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/tables/file.py:114: UnclosedFileWarning: Closing remaining open file: results/benchmark_RD/enrich/cond_A_rep2_T2_lib.h5
  warnings.warn(UnclosedFileWarning(msg))
/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/tables/file.py:114: UnclosedFileWarning: Closing remaining open file: results/benchmark_RD/enrich/benchmark_RD_exp.h5
  warnings.warn(UnclosedFileWarning(msg))
/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/tables/file.py:114: UnclosedFileWarning: Closing remaining open file: results/benchmark_RD/enrich/cond_A_R1_sel.h5
  warnings.warn(UnclosedFileWarning(msg))
/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/tables/file.py:114: UnclosedFileWarning: Closing remaining open file: results/benchmark_RD/enrich/cond_A_R2_sel.h5
  warnings.warn(UnclosedFileWarning(msg))
/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/tables/file.py:114: UnclosedFileWarning: Closing remaining open file: results/benchmark_RD/enrich/cond_A_rep1_T0_lib.h5
  warnings.warn(UnclosedFileWarning(msg))
/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/tables/file.py:114: UnclosedFileWarning: Closing remaining open file: results/benchmark_RD/enrich/cond_A_rep2_T0_lib.h5
  warnings.warn(UnclosedFileWarning(msg))
/project/chlandry/users/rodur28/dumpling/.snakemake/conda/67d2d89bb9799e59a640f480438207d3_/lib/python3.13/site-packages/tables/file.py:114: UnclosedFileWarning: Closing remaining open file: results/benchmark_RD/enrich/cond_A_rep1_T1_lib.h5
  warnings.warn(UnclosedFileWarning(msg))

Most importantly, here is the log from rosace:
Attaching package: ‘dplyr’

The following objects are masked from ‘package:stats’:

    filter, lag

The following objects are masked from ‘package:base’:

    intersect, setdiff, setequal, union

This is cmdstanr version 0.8.0
- CmdStanR documentation and vignettes: mc-stan.org/cmdstanr
- CmdStan path: /home/rodur28/.cmdstan/cmdstan-2.35.0
- CmdStan version: 2.35.0

A newer version of CmdStan is available. See ?install_cmdstan() to install it.
To disable this check set option or environment variable cmdstanr_no_ver_check=TRUE.
Rows: 8 Columns: 6
── Column specification ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Delimiter: ","
chr (3): sample, condition, file
dbl (3): replicate, time, tile

ℹ Use `spec()` to retrieve the full column specification for this data.
ℹ Specify the column types or set `show_col_types = FALSE` to quiet this message.
Warning message:
In dir.create(rosace_assayset_dir, recursive = TRUE) :
  './results/benchmark_RD/rosace/assayset' already exists
Rows: 2271 Columns: 2
── Column specification ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Delimiter: "\t"
chr (1): hgvs
dbl (1): count

ℹ Use `spec()` to retrieve the full column specification for this data.
ℹ Specify the column types or set `show_col_types = FALSE` to quiet this message.
Joining with `by = join_by(hgvs)`
Rows: 2271 Columns: 2
── Column specification ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Delimiter: "\t"
chr (1): hgvs
dbl (1): count

ℹ Use `spec()` to retrieve the full column specification for this data.
ℹ Specify the column types or set `show_col_types = FALSE` to quiet this message.
Joining with `by = join_by(hgvs)`
Rows: 2271 Columns: 2
── Column specification ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Delimiter: "\t"
chr (1): hgvs
dbl (1): count

ℹ Use `spec()` to retrieve the full column specification for this data.
ℹ Specify the column types or set `show_col_types = FALSE` to quiet this message.
Joining with `by = join_by(hgvs)`
Error in CreateAssayObject(counts = as.matrix(counts[2:ncol(counts)]),  :
  Length of variant names is not equal to number of rows in input matrix
In addition: Warning messages:
1: In full_join(counts, count) :
  Detected an unexpected many-to-many relationship between `x` and `y`.
ℹ Row 3 of `x` matches multiple rows in `y`.
ℹ Row 3 of `y` matches multiple rows in `x`.
ℹ If a many-to-many relationship is expected, set `relationship = "many-to-many"` to silence this warning.
2: In full_join(counts, count) :
  Detected an unexpected many-to-many relationship between `x` and `y`.
ℹ Row 3 of `x` matches multiple rows in `y`.
ℹ Row 3 of `y` matches multiple rows in `x`.
ℹ If a many-to-many relationship is expected, set `relationship = "many-to-many"` to silence this warning.
Execution halted

I though this might be related to the specification of coordinates in the config file (which I'm guessing should corroborate the list of variants) but I double checked that and it should be OK. I don't really know what's going on :/.
thanks for the help, much appreciated!

Hm, the rosace environment has been finicky before, so I will definitely look at this. You are using a linux64 environment, right? Could you share your experiment config file (the csv)? You can give the samples dummy names to anonymize it if you want, that's fine.

Yes! The layout is attached. I just noticed that the chariot returns are encoded as CRLF, hopefully that hasn't caused any issue ^^"

Sorry for having to slog your way through this! I took the opportunity to make the r environment handling a little cleaner, as well as tidying a few issues. Could you give this branch a try and see if the issues remain?
https://github.com/odcambc/dumpling/tree/rosace_install

No problem! Could there be a typo in the defined input for the run_rosace rule? .csv files are expected, but the corresponding files (generated by rule process_counts) are .tsv

That's exactly right...there were some inconsistent files that I wasn't catching while testing for some reason. I just pushed another change that ought to fix that.


also allow TOML

There is not any benefit in using toml instead of yaml, so there are no plans to add the complexity to support another format. If you don't like yml you can use starlark or jsonnet.

Beside that, stop creating the same issue again just because it gets dropped.


Remove file system requirement for sessions & query results

Now that a variety of back end databases are supported and tested (#668, #715, #720, #724, #725, #726) I think it is worth reconsidering how the file system is used.
The file system is used for session management and storage of query results.
Sessions can be moved to the target database using a Sequelize adapter https://github.com/mweibel/connect-session-sequelize. I've previously explored this but found it was slightly slower.
For query result storage, these could also be moved into the database, but perhaps that is left as an option? While working on #632 I contemplated this and ultimately decided on file system.
For both session and query results, I could see the case made for putting this stuff in Redis or some other key value store as well, so maybe this is made optional -- users can select a session store and a query result store method.

This is implemented as of 5.4.0


Update examples

What does this PR do?

Update examples based on latest changes in Transformers' main branch.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


[Performance] What is the purpose of compiling a model？

System Info
CPU: x86_64
GPU: NVIDIA L40
CUDA: 12.2
OS: ubuntu 22.04
TensorRT-LLM: 0.15.0
Who can help?
@kaiyux
Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
convert model: python3 qwen/convert_checkpoint.py --model_dir ./Qwen2.5-32B-Instruct-GPTQ-Int4/ --dtype float16 --use_weight_only --weight_only_precision int4_gptq --output_dir ./trt_engines/Int4/
compile model: trtllm-build --checkpoint_dir ./trt_engines/Int4 --gemm-plugin auto --output_dir ./trt_engines/compiled-model/
run server-1: trtllm-serve ./trt_engines/Int4/ --host <IP_ADDRESS> --port 8000
run server-2: trtllm-serve ./trt_engines/compiled-model/ --host <IP_ADDRESS> --port 8000
when i use v1/chat/completions with 9k words prompt to test server-1 and server-2, they need about 12 seconds to return all the answers，so，What is the purpose of compiling a model？Or require certain configurations？
Expected behavior
compile model can improve performance or others
actual behavior
none
additional notes
none

hi @Flynn-Zh  please refer to the doc https://nvidia.github.io/TensorRT-LLM/architecture/overview.html#tensorrt-llm-architecture for details.


background rendering bug while change workspace

Hyprland Version
Hyprland, built from branch  at commit b08b72358ad549fd066e5be0fc3aa4c9df367607 dirty (). Tag: v0.27.2  flags: (if any)
Bug or Regression?
Bug
Description
If i have a windows running in fullscreen and change the workspace via workspace_swipe the background, set by swww or swaybg, isnt rendered until the new workspace is completely visible.
How to reproduce

set wallpaper with swww or swaybg
open any window
put window in fullscreen via hyprland. i did it with: bind = $mainMod, f, fullscreen
change workspace with touchpad gestures

Crash reports, logs, images, videos
No response

Similar to #2756 probably will be fixed in the next release (0.28.0), which will be very optimized and light on resources according to @vaxerski. Really looking forward to that awesome release.

nice, thanks! i'll close this


Docker compose installation is outdated?

Hello, I've recently moved from the other speedtest tracker to this one. The interface could be a bit faster but I love it either way. I installed it using docker compose with the latest image tag but the version reported in the dashboard is v0.11.0. Is it maybe a mistake on my part?
Thanks

I recreated the stack and it pulled the latest image, so I'm now at the correct version. I don't know what that was about.


Print Trades too Logbook

Print Trade Completion results too player logbook

example for travel mule in https://github.com/Misunderstood-Wookiee/Mules-and-Warehosues-Extended/commit/a587a705678ca3d9b8c04ec09b02b45ad0cd1b40

Noticed that one.. will have to get an output like this for station mule.
Unsure if we should default log tasks for distribution mule and supply mule I think I may just make those two a user-selectable choice if they want that mule to log or not, same with the travel one after I implement logging that works for the rest will tie the function into a selectable option to avoid un-necessary logging of mules you don't care about.

I think it might be nice to have the option for the supply and distrib mules to log to the player logbook, since you can easily filter and check on supply lines that way.

I think it might be nice to have the option for the supply and distrib mules to log to the player logbook, since you can easily filter and check on supply lines that way.

Did we get around to doing this?

This isn't finished yet, it's been locked by the more pressing issues. I want to make a pass through every mule and put standard messages in there for all of the trades.

If we could colour the messages that would be fancy.
Beyond scope tho.

In general, logging is much improved. In the interest of cleaning up our issues list, I'm going to close this. Any specific logging requests  from here on can get it's own issue.


Use RW-Lock for more efficient cache view access

This improves both performance and space efficiency
Pull Request Etiquette

[x] I have checked the PRs for upcoming features/bug fixes.
[x] I have read the contributing guidelines.

Changes

[x] Internal code
[x] Library interface (affecting end-user code)
[ ] Documentation
[ ] Other: _____

Closes Issue: NaN
Description
Changes internals for CacheView to synchronize with a read-write lock rather than using an implicit mutex.

Lets not do things like this: https://github.com/DV8FromTheWorld/JDA/pull/834/files#diff-3cd56d2bba5a9fa8c43fa87c7cb3b2caR281
It makes it harder to follow the source.
Start the stream on the first line, and bring the stream mutators to the next line
 return myStuff.stream()
     .filter(...)
     .map(...)
     .collect(...)

The latest commit also prevents things like
userCache.forEach(user -> userCache.remove(user.getIdLong()));

It looks like iterator() and forEach(...) have a different iteration order due to the changes I've made.
In SortedSnowflakeCacheView the iterator() is made to iterate the sorted array of values while forEach iterates the arbitrary order of the backing hash map. Now it is time to make a decision what we deem more important, efficiency or order.


LaTeX curly brackets do not convert correctly

I've noticed that LaTeX curly brackets do not convert correctly (according to standard LaTeX editing rules).
Fails: $\{STUFF\}$ [correct LaTeX syntax] -> \({STUFF}\) [appears wrong, as "STUFF"]
Works: $\\{STUFF\\}$ [wrong LaTeX syntax] -> \(\{STUFF\}\) [appears correct, as "{STUFF}"]
Ideally, the correct LaTeX syntax results in the correct display/conversion in Anki; right now adding an extra backslash works, but is not accurate LaTeX syntax.

I have tried to fix these errors these days, my pr is not be merged now, you can download new version here and help me to test it.
Besides \{\}, some other character errors have also been fixed(\#\$\&\_)


Look for fzf instead of fzf.vim

Since fzf is what is required and not necessarily fzf.vim it would be better to just check for this in the rtp.

In fact fzf.vim is needed to call the function fzf#run, so I think we should keep the rtp as it is.

@soywod I think it's actually defined in fzf, see here. I only have fzf installed and not fzf.vim and with this change things to work for me :)

Oh yes you right, I'm sorry! You totally right. I tried and seems to work also for me, so I merge.

Thank you :tada:

No problem :) Cool!


Update repository path and fix Outdated PIP version error

A new Dockerfile was included in https://github.com/Just-Some-Bots/MusicBot/commit/ee8be2ac6af305a79b55cc51f4ddf29f2a6232bf.


Add and modify Calc Functions

Pull request
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Please ensure you have read and noticed the checklist below.
Checklist
Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!
This is simply a reminder of what we are going to look for before merging your code.

[x] I have read and noticed the CODE OF CONDUCT document
[x] I have read and noticed the CONTRIBUTING document
[x] I have added necessary documentation or screenshots (if appropriate)
[x] I have tested my changes or additions for proper functionality.
[x] I have followed, as best as possible, the same function layout and coding style of other existing functions/code.

Types of changes
Please check x the type of change your PR introduces:

[ ] Bugfix (change which fixes an issue)
[x] Feature (change which adds functionality)
[ ] Code style update (formatting, renaming)
[x] Refactoring (functional, structural)
[x] Documentation content changes
[ ] Other (please describe)
**	|-->:

What is the current behavior?
Please describe the current behavior that you are modifying, or link to a relevant issue.
**	|-->:

Non-existent error returns in some headers.
Colour conversion could be simpler using BitShift
Gradient functions using $iBorder as parameter weren't clear what value it aligned with in L.O. UI.

What is the new behavior?
Please describe the behavior or changes that are being added by this PR.
**	|-->:

Removed unused error returns in headers.
Added Calc Comment functions.
Modified Colour conversion to use BitShift in some places.
Renamed Gradient functions $iBorder parameter to $iTransitionStart
Added Calc Outline functions.
Added more SheetLink functions and modified existing functions to integrate it.
Updated ChangeLog

Influences and relationship to other functionality
Describe how the changes will affect other functions, potential script breaking changes, etc.
**	|-->:
Additional context
Add any other context about the problem here.
**	|-->:
System under test
Please complete the following information.

OS: [e.g. Windows 10]
OS Arch.: [e.g. X64]
LibreOffice Component: [e.g. Main, Writer, Calc]
LibreOffice version: [e.g. <IP_ADDRESS>]

Added Fill Style Retrieval functions
Rename Internal Constant $LOCCONST_FILL_STYLE to $LOC_AREA_FILL_STYLE
This allows the user to determine what Background Fill Style is currently being used.

Here we have conflict after commiting changes

Fixed


not working on macos, dependency issue

macos silicon have different pip tensorflow, which is tensorflow-macos
is there a way to configure this library to use the macos tensorflow ?

I fixed this problem in this way.

use new conda env "pip install imagededup"
use this "https://drive.google.com/drive/folders/1oSipZLnoeQB0Awz8U68KYeCPsULy_dQ7" wheel reinstall tensorflow. more details see "https://stackoverflow.com/questions/65383338/zsh-illegal-hardware-instruction-python-when-installing-tensorflow-on-macbook"
reinsatll numpy=1.16, because imagededup need.

then I can use "cnn = CNN()"

The package doesn't have tensorflow as a dependency. So, closing the issue.


Custom format not working

Hello, when i'm trying to format date with dots. but it doesn't work.
I need 'dd.MM.yyyy' format.
Any suggestions?

@mtleppay You can solve the problem by changing next if statement in Calendar component:
if (str.length === 10 && (this.dateFormat === 'dd-MM-yyyy' || this.dateFormat === 'dd/MM/yyyy'))
change to this
if (str.length === 10 && (this.dateFormat === 'dd.MM.yyyy' || this.dateFormat === 'dd-MM-yyyy' || this.dateFormat === 'dd/MM/yyyy'))


gnomeExtensions: Update for GNOME 45

Description of changes
Closes #259035
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

btw it looks like extensions don't work on gnome 44 after this got merged, i guess many of them are now ported to ESM while #247766 is still wip

Oh I'm sorry, I hadn't thought of that, and it probably should not have been merged. Depending on how long #247766 still needs, we can fix this by reverting one line back to gnomeExtensions = lib.trivial.pipe (gnome42Extensions // gnome43Extensions // gnome44Extensions) [, or revert the entire thing (but which would also lose the updates which resolved e.g. #259035).

just wait until someone else notices and makes an issue 😎 personally i'll just wait for gnome 45 merge, but you'll definitely make some people mad once this lands in unstable

I think reverting just gnomeExtensions change makes most sense for now. We can then revert the revert in gnome branch.

Revert in #261196. I just noticed that after the update some extensions fail to build, which is a bit weird because I really thought we had CI to do some basic building of changed packages. So @jtojnar please don't re-add the commit to the gnome branch yet, as it requires more work. Also I'm currently writing a test suite to make sure this hopefully doesn't ever happen again.

Follow-up in #261831


Document Auth0 integration

I recently did some re-testing a wrote up a Gist with user-facing instructions about how to configure Auth0/Zed for authentication. Now that Zui v1.0.0 is out I should turn this into a proper doc for the Integrations section of the docs site.

This doc is now available at https://zed.brimdata.io/docs/next/integrations/zed-lake-auth.


Documentation is down

https://mikaeledebro.gitbooks.io/vue-airbnb-style-datepicker/ doesn't work:

5 months has passed and no documentation, lol

It's back now


How do we handle listeners in Workbox

we had a discussion in a sync regarding moving all event listeners over to default exports only
We agreed to add it to the styleguide
the reason is to ensure that the simplicity of workbox-sw is still encapsulated but doesn't block use cases of using the modules outside of event listeners
workbox-routing (the bug you link to) highlighted a change that resulted in a descrepency - i.e. routing had the magic method, precaching didn't
I'm happy to add helpers anywhere you would like

https://github.com/GoogleChrome/workbox/issues/721
What do people think is best?
cc @philipwalton @addyosmani @jeffposnick

I've been starting to migrate the template used by generateSW() over to v3, which has forced me to approach the API as more of a consumer.
It feels pretty good to have, e.g., workbox.router always set up the fetch event listener for me by virtue of that being in the default export, and then just being able to call the methods on that Router instance to add routes, etc. I think we can keep that model as long as it doesn't mess up anything for the developers who end up bundling their own instances of workbox-sw + supporting modules.
I'm open to re-adding optional helper methods to the Router class and whatever other classes are relevant to explicitly register the event listeners. This would benefit developers who are using those classes directly (i.e. not the default exports via workbox-sw) but aren't comfortable adding in their own event listeners. That's a pretty niche group, so we probably wouldn't steer folks towards that path, and I don't feel strongly about it.

There are a few issues going on here, so let me try to summarize how I see things to make sure we're all on the same page:
The concern of mine that originally brought up this discussion was not about event listeners, it was that a method was removed without any public issue tracking it. But @jeffposnick filed #914, so that's no longer a concern.
On the subject of how to handle adding event listeners, I think that's actually two separate (and orthogonal) issues.

Should workbox classes add event listeners in their constructors that call methods in response, or should we require users to explicitly add those listeners themselves (or call connivence methods, e.g. addFetchHandler())?

Should workbox modules add event listeners at import time?

Re: (1) I think we should handle it on a case-by-case basis since not all event listeners are conceptually the same and not all classes offer the same types of functionality. To generically say that classes should never add event listeners seems a bit heavy-handed to me.
In general though, I think we should err on the side of giving developers more control rather than giving them more magic.
Re: (2) I'm almost never in favor of modules having any side effect just from being imported, especially not the default export of the package (since you get that no matter what).
Having side-effects at import time has two big downsides form my perspective:

Users that only want one part of a package get the side-effects no matter what.
The fact that a module has side-effects, prevents it from being tree-shaken (as I described in #909).

For example, if a user only wants workbox only for workbox-google-analytics they'll get the default fetch event listener added from workbox.routing even though they're not using it. And if we add a default export to workbox.strategies, they'll get that too.


example website is down

countriesworldmap.simplewidgets.dev

Hi @EArminjon
The link has been replaced to the following: https://examples.simplewidgets.dev/#/countries_world_map
Thank you for pointing this out, I need to change the README.md to reflect the changes

INSANE JOB, wp <3

The README.md has been updates, thank you!
https://pub.dev/packages/countries_world_map


Add Cairofinance

@MRabenda  Please add  Cairofinance To Metamask,
Thank you!
Token Websites
Cairofinance Git
CairoFinance Main website
On Pancakeswap
Token Contract
https://bscscan.com/address/0x5662ac531A2737C3dB8901E982B43327a2fDe2ae
Token Socials
https://twitter.com/CairoFinance

@MRabenda  please review and add Cairo token.

This repo do not supports BSC contracts yet

Is there any other repo available for BSC?


MHGen n3ds NAND Dump Size - Different to Listed values

I made multiple NAND backups on my MHGen N3DS, and they're all 1.82 GB (1,954,545,664 bytes), people in the #3dshacks IRC say they've seen other people reporting the same.

[14:59:33]  Hi guys, I'm in the process of installing a9lh cfw for my brother's n3ds and succesfully downgraded to 9.2.0. When making a sysNAND backup, the size is always 1.82GB. The n3ds is part of the new Monster Hunter Generations bundle, could something be different with this model?
[15:00:50]  how are you checking?
[15:00:53]  check count in exact bytes
[15:02:19]  I did, it's smaller than it should be. I've also checked the backup of my own n3ds and that backup's size is exactly correct.
Logs from a few days ago of someone else reporting the same

Does anyone know the manufacturer of this device's NAND chip?

I've added the size to the guide, although knowing the manufacturer would be nice.


cdpam code missing?

Hi. Thank you for the DPAM model, excellent work and very nice paper!
I am curious to try your CDPAM model. I tried checking out the new cdpam model code.
However the directory seems to be empty in git? In https://github.com/pranaymanocha/PerceptualAudio/tree/master/cdpam
I only see requirements.txt, README.md and a sample/ directory?

Hi. Thanks for your comments. The work is under submission, and the idea is to release everything (dataset, trainable model etc.) after we hear back from the reviewers. However, we released the metric in a pip module so that people can try out the metric and see if that works for their task. The pip module supports evaluation the metric stand alone, and training the metric on some downstream task.

Ok, understood. Thank you for the quick response! Looking forward to the paper and the release.
If a preprint is available I would love to read it (my email is in github profile and on my website).

Any specifications on how to use this metric in Pytorch? (Can it be used as a metric during training and what sample rate is expected?)

Yes, it can be used as a metric during training. It expects sr=22050. For training, you need to pass tensors (it doesn't automatically change the sampling rate), but for eval you can pass numpy arrays (as shown by cdpam.load_audio() - which also converts automatically into sr=22050 in the backend). If you pass in tensors, then it passes gradients, but if you pass numpy arrays, it doesnt track gradients.

@pranaymanocha Hi. We are working on a paper where we want/need to reference CDPAM. Can you please advise on the best way of doing so? I guess we could reference the Github repo, but if you have an paper or pre-print that would be even nicer!

@pranaymanocha Hi. We are working on a paper where we want/need to reference CDPAM. Can you please advise on the best way of doing so? I guess we could reference the Github repo, but if you have an paper or pre-print that would be even nicer!

Hi, If you need a citation immediately, then please cite this github repo. However, if you can wait a few days then (I guess by next week), we expect to be able to provide a more suitable citation (possibly arXiv). Sorry for the confusion!!

Hi, If you need a citation immediately, then please cite this github repo. However, if you can wait a few days then (I guess by next week), we expect to be able to provide a more suitable citation (possibly arXiv). Sorry for the confusion!!

Thank you for the reply. Our deadline is still some weeks away, so we will wait for the proper citable artifact and cite that.

Thank you for the reply. Our deadline is still some weeks away, so we will wait for the proper citable artifact and cite that.

@jonnor Hi! I just updated the citation in the cdpam folder. Please have a look. I am also planning to put the paper up on arxiv in the coming 2-3 days, so I'll update you once that's done. Sorry for the trouble earlier.

Hi @jonnor @calclavia I just put the arxiv link of the paper in the repo. Please have a look guys. Thanks!