rive-react-native + Expo Go

Description
I am building an app with Expo Go and I am wondering if rive-react-native currently works in an Expo Go app. I've thoroughly read the documentation and I am still unsure. I see that installation steps include updating pods manually, which would not work in Expo Go. Additionally I see a line "The Rive React Native runtime does not have support for Expo at this time" indicating similarly that rive-react-native would not work in an Expo Go app.
If this is not yet supported, are there plans to have Rive supported in Expo Go apps? Is there a timeline for this?
TYIA
Provide a Repro
Not Available. Just that I am unable to pod install for an Expo Go app.
Expected behavior
Would love for rive-react-native to work in Expo Go!
Screenshots
Device & Versions (please complete the following information)

Device: iOS Simulator

Additional context

Hi @lisherwin, we're definitely considering adding better expo support, though no timeline for that as of now. The line in the docs about the RN runtime not having support in Expo was added at a time when it did not work, and Expo did not allow you to add Native modules easily.
There are community docs in this issue that mentions some considerations for adding Rive to an Expo app, that you may want to take a look at: https://github.com/rive-app/rive-react-native/issues/123
Expo allows you to add libraries with custom native code: https://docs.expo.dev/workflow/customizing/#generate-native-projects-with-prebuild
Here is an example Rive expo app: https://github.com/lklima/rive-animated-app

I don't think it's realistic to expect that Rive ever works with Expo Go since it depends on their native SDKs which wouldn't really make sense to have included in Expo Go.
It should be possible within the managed workflow (and currently is for iOS, I don't think it works on android though)

@iway1 It is possible
take example of notifee. It depends on native SDKs. So expo has a "config-plugin" for notifee to make it work in managed expo dev env
see https://github.com/expo/config-plugins.

I just create an issue, almost a doc on how to make Rive works on web and ios/Android.
https://github.com/rive-app/rive-react-native/issues/257
Also in that example, expo go still works, but the animation won't (Will display a placeholder image)
Still need to build the app for IOS/Android to see the animation. (At least you can still use expo go when develloping other things)


MFMailComposeViewController is not dismissed after user sent, saved, or canceled the mail.

After I shaken the phone to send the report, I find I'm trapped in the mail screen. I'd like to go back to the APP and continue what I was doing. But currently I have to kill the APP to quit the mail view.
I checked the code a little bit, it seems that CLUMailDelegate doesn't dismiss the mailComposeController in mailComposeController(_:didFinishWith:error:). I am not sure if it's by design or not. But by adding [controller dismissViewControllerAnimated:YES completion:nil]; after the switch solved my issue. Could you kindly fix this issue on your side? Or I can open a PR with my fix if you need. Thanks!

Hello, @ccmjz !
Thank you so much for your report and sorry for my late reply!
I'll take a look at this issue closer on the next week and write you my results back.
Thanks!
Ahmed.

Hi @Geek-1001 ! How is going these days? As you might noticed, I created a PR related to this issue. Let me know if you need me to change anything. Thanks!


http/1.1: fix multiple response crash when above high watermark

Fixes https://github.com/envoyproxy/envoy/issues/3589
Signed-off-by: Matt Klein<EMAIL_ADDRESS>Risk Level: Low
Testing: New UT
Docs Changes: N/A
Release Notes: N/A

@alyssawilk let me see about doing an integration test in a follow up. I would like to get this fix in since we are seeing crashes here.


Add Desktop-native Apps, emacs modes, and 2 paid

Desktop: Zim,Red Notebook,QOwnNotes,nvpy,CrossLine,AnyType,treesheets,leo,vim-wiki
emacs: org-mode,org-roam,deft,hyperbole/Koutliner,howm,org-brain
$$: TheBrain,Polar

Thanks for your work! I've merged your other PR. If there were any further contributions you're welcome :)


Use HumanAdd in Env

Closes #488
Depends on https://github.com/CosmWasm/rust-optimizer/pull/17 for building (merge and publish before merging this PR).

I rebased this on other PRs and rebuilt the contracts.
I don't think there are other comments left to address?


https://goreportcard.com/ is Down (7/25/2019)

Unable to reach https://goreportcard.com/.
Badges and reports are not being displayed on repositories.

@NathanielRose thanks, we're having some scaling issues. It should be back up now.


Updating Power Apps v2 trigger to invoker connection

https://msazure.visualstudio.com/One/_workitems/edit/13316505

@sbasi19 : Thanks for your contribution! The author(s) have been notified to review your proposed change. @hamenon

Docs Build status updates of commit b891285:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/approvals-known-issues.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2e24623:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/approvals-known-issues.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


value(true) and value(false) produce errors

I assumed that value(true) and value(false) would return their argument, but they produce key_not_found errors instead:
$ node eneyj/src/eneyj.js
eneyj v0.1.0
language is set to English
Enter .help for help
> value(true)
{
  "Z1K1": "Z15",
  "Z1K2": "Z443",
  "Z1K3": {
    "Z1K1": "Z12",
    "Z12K1": [
      {
        "Z1K1": "Z11",
        "Z11K1": "Z251",
        "Z11K2": "key_not_found"
      }
    ]
  }
}

> value(false)
{
  "Z1K1": "Z15",
  "Z1K2": "Z443",
  "Z1K3": {
    "Z1K1": "Z12",
    "Z12K1": [
      {
        "Z1K1": "Z11",
        "Z11K1": "Z251",
        "Z11K2": "key_not_found"
      }
    ]
  }
}

I noticed this when I was implementing “if” in GraalEneyj, figured that if(value(true), "then", "else") would be a nice test case of a non-constant reference condition, and was surprised to find that eneyj produced "else" rather than "then" as I expected:
> {"Z1K1": "Z7", "Z7K1": "Z31", "K1": {"Z1K1": "Z7", "Z7K1": "Z36", "K1": "Z54"}, "K2": "then", "K3": "else"}
else

Yes, can reproduce. I think it's a bug in the implementation of value. Will look at.

Thanks for reporting!


Fixed addGxtText typings

allow first arg of type number, too
https://github.com/altmp/altv-js-module/commit/5d0f45cc328ad2b690d0ed9d55ecd7ba0f5b8f61

Thanks


bug: textlint.d.ts mismatch name

https://github.com/textlint/textlint/commit/52edc5f#commitcomment-16721568

This issue doesn't effect anyone behavitor.

It is no problem


False-positive unit tests of observables

Hello, I found that most of your unit tests that tests observable are false-positive, meaning that these tests will pass even when they are supposed to fail.
Minimal reproduction of the bug with instructions:
just change behavior of effect or put one false-positive except (except(false).toBeTruthy())  into the subscribe method and test will still pass
Expected behavior:
Test will fail when they are supposed to
Other information:
example:
   effect.login.subscribe(() => {
     expect(localStorageService.setItem).toHaveBeenCalledWith(AUTH_KEY, {
        isAuthenticated: false
      });
      expect(false).toBeTruthy(); // should obviously fail but it won't
      expect(router.navigate).toHaveBeenCalledWith(['']);
    });
  });

this test has its 'except' in subscribe method, which is asynchronous and will be run after the test will complete without error
I would be willing to submit a PR to fix this issue:
Yes, I would like to start working on PR if you agree.
I would also remove these cold and hot helpers because most of the time here we are testing one value emitted from the observable and there are not necessary.

Hi @TarasCZ  !
Thank you very much for finding this, it would be amazing to make this right! I would go with standard @rxjs/testing with TestScheduler which enables simple marble testing without real time!
Docs
Thanks mate!

Hey Tomas :)
I think your solution is bit of an overkill for these simple purposes, since we don't need to test observable behavior over time, also I think is confusing when there is such unnecessary test because ngrx is immutable and shouldn't depend on when the action is fired.
I think the KISS rule could be applied here, I propose use BehaviorSubject and done function like this:

Let me know what do you think about this :)
Thanks, Jirka

@TarasCZ hi Jirka!
Yeah testing of actions is maybe too much ... still having even simple test using TestScheduler can be used as a starting point on how to use it for more complex cases.
Timing of action DOES matter for more complex effects with delays, debounces, race and other complex orchestration which are part of real world applications :)
What do you say ?


bump ocean.js

Bump ocean.js

It looks like it's still failing unfortunately

@alexcos20 I'm wondering why the Integration tests / test (pull_request) is failing even through Integration tests / test (push) is passing? When I run the integration tests locally they pass with Ocean 0.14.8

not sure about the test failure but over in the automatic update all is working #98


Packaging request: overleaf

Project description
Open-source and self-hostable online real-time collaborative LaTeX editor.
It would be great to have it packaged for NixOS as well as a NixOS module to quickly configure it.
Metadata

homepage URL: https://www.overleaf.com/
source URL: https://github.com/overleaf/overleaf
license: agpl3
platforms: linux

Bold adventure reserved for the mightiest :>

Bold adventure reserved for the mightiest :>

@RaitoBezarius don't be a doubter, be a believer.


Problem with grpc-echo-service

Hello, I am trying to complete the dapr-apim-integration demo, which depends on the grpc-echo-service docker image that you own.
When I run the demo as is, I get the error PostStartHookError: command '/daprd --wait' exited with 137
I have tried pulling the code for the image as you have defined in this repo (which appears more up-to-date than that in the quickstart docs) and building and deploying that I get the same error. Do you know why this may be?
Sorry if this isn't a real issue, just kinda puzzled and figured the original author might have more context than I do about the daprd process/error codes.

Also: in order to get your image to build I had to add a step in the dockerfile to run go mod vendor, based on the warning I got when building it:
go: inconsistent vendoring in /src:
<EMAIL_ADDRESS>is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
<EMAIL_ADDRESS>is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
<EMAIL_ADDRESS>is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt

run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory


ConvertTo-NTHashDictionary is not available in newest published module

There is this article https://www.dsinternals.com/en/auditing-active-directory-password-quality/ that uses ConvertTo-NtHashDictionary but it seems it's not in .psd1 anymore. Something has changed... is there replacement for it in newest version (also usage one - I tried ConvertTo-NtHash but it's for something else right?

You are right. I have to update the article, as there had been a major change in version 3.0.
The functionality is now integrated directly into Test-PasswordQuality. It has 3 optional weak password-related parameters:

WeakPasswords -Accepts one or more passwords directly from command line.
WeakPasswordsFile - Expects a path to a file containing bad passwords, one per line.
WeakPasswordHashesFile - Expects a path to a file containing password hashes, one per line (like the one from HaveIBeenPwned)


Error Trace

work on design patterns to get some global and single instance for calling common error handling.
Check for PHP trace function for getting an error stack.

Need to work on the ability to catch the error in one global file or class


Regarding examples['dpr']

Dear author,
Thank you for your code and data. We have read through the run_classifiers.py and run_seq2seq_classifiers.py files and noticed that the training data doesn't include the DPR component. We wonder if you can kindly share with us how the examples['dpr'] are generated. Can you point us to the source code involving this part of the generation?
Thanks for your help!

Hi!
We used the DPR code with the model used for KILT. After retrieving passages, we added the 'dpr' field to each example that contains a list of passages.
Thanks!


🎉 start project

What changed?

Unignore .python-version file. This change ensures consistent Python versions across different environments.

Update README.md to enhance project description and add a new line after the title.

Add pyproject.toml and poetry.lock for project management. These files specify dependencies and configurations using Poetry.

#4
#3
#2
#1  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mingi3314 and the rest of your teammates on  Graphite

Merge activity

Jun 23, 11:50 AM EDT: @mingi3314 started a stack merge that includes this pull request via Graphite.


Add cmd for printing object store config format for each provider

This is to make sure it is clear that it is easy to configure bucket for Thanos.

Maybe this could be solved with better documentation instead?

Good point, but I think both. In the same way you have both docs and flags in --help.
It's easier to print help and see corresponded yaml schema we support with the binary you just use, then tracking down what is the version of your thanos binary, where are the docs, changing to corresponded tag and checking the schema, isn't it? (:

Agreed.

@bwplotka I can take a look at this if you could give any more details on this.
What should the cmd look like? I have no idea how to name it for example ./thanos config object-storage ?
Also do you want to print all config examples by one command or allow to specify exact os?
Possibly add validation also same way as pomtool or amtool?

Thanks @FUSAKLA
So what we have right now is: https://github.com/improbable-eng/thanos/pull/645
We document the format and autogenerate it if needed.
The acceptance criteria for this one would be:

Allow validatation (nice idea @FUSAKLA ) by some thanos bucket config-validate command.
Print configuration thanos bucket config <objectstore> per tool.

I feel like we should not focus on this until it would be really confirmed it is needed, as we have autogenerated docs now. We have more important tickets to do (: Closing this for now.


Two magic keyboards listed under the same entry

First of all thank you for the great work on this awesome project! I've been using it for quite a while for minor modifications and it works like a charm.
Recently, I was experimenting with a quite experimental setup of two external keyboards to model a split keyboard setting. When I had two different keyboards types, Karabiner Elements worked as expected and let me modify each keyboard's keys accordingly. However, after my initial testing phase I got a second magic keyboard 2 and now both are listed under the same entry in Karabiner Elements, so any modification will affect both keyboards. The keyboard settings menu however has a way to distinguish them, so I suppose this should be possible somehow.
Karabiner Elements only recognizing one keyboard

both keyboards being detected in settings

Do you think it would be possible to let Karabiner Elements distinguish between the two as well?

I have the same problem with a different keyboard couple. A solution is discussed here: https://github.com/tekezo/Karabiner-Elements/issues/1542


bedtools fisher gives different results depending on the order of input files...

I have used bedtools version 2.28.0, where similar problem for bedtools jaccard (in version 2.26.0) is already solved, but not for fisher.
See example files below.
3CGvs1CGregion_chr1.bed (57860700 bp in  9773 intervals)
Int90617792_early_RT_chr1.bed (62087472 bp in  2528 intervals)
$ bedtools fisher -a 3CGvs1CGregion_chr1.bed -b Int90617792_early_RT_chr1.bed -g chr1.genome
Number of query intervals: 9773
Number of db intervals: 2528
Number of overlaps: 5724
Number of possible intervals (estimated): 9773
phyper(5724 - 1, 9773, 9773 - 9773, 2528, lower.tail=F)
Contingency Table Of Counts
#_________________________________________
|  in -b       | not in -b    |
in -a | 5724         | 4049         |
not in -a | 0            | 0            |
#_________________________________________
p-values for fisher's exact test
left	right	two-tail	ratio
1	1	1	-nan
$ bedtools fisher -a Int90617792_early_RT_chr1.bed -b 3CGvs1CGregion_chr1.bed -g chr1.genome
Number of query intervals: 2528
Number of db intervals: 9698
Number of overlaps: 5724
Number of possible intervals (estimated): 9698
phyper(5724 - 1, 2528, 9698 - 2528, 9698, lower.tail=F)
Contingency Table Of Counts
#_________________________________________
|  in -b       | not in -b    |
in -a | 5724         | 0            |
not in -a | 3974         | 0            |
#_________________________________________
p-values for fisher's exact test
left	right	two-tail	ratio
1	1	1	-nan
Moreover, the 0 values in the contingency table for “in -a and not in -b” are obviously not valid!!!
$ bedtools intersect -v -a Int90617792_early_RT_chr1.bed -b 3CGvs1CGregion_chr1.bed > only_in_earlyRT_chr1.bed
$ awk '{print NR}' only_in_earlyRT_chr1.bed | tail -n1
581
$ bedtools intersect -v -a 3CGvs1CGregion_chr1.bed -b Int90617792_early_RT_chr1.bed > only_in_3CG_chr1.bed
$ awk '{print NR}' only_in_3CG_chr1.bed | tail -n1
4832
Also, overlaps are obvious via IGV as well as in the bedtools jaccard:
$ bedtools jaccard -a 3CGvs1CGregion_chr1.bed -b Int90617792_early_RT_chr1.bed -g chr1.genome
intersection	union	jaccard	n_intersections
32124156	87824016	0.365779	5724
That means more than 50% of bases of each interval files are actually overlapping.
Int90617792_early_RT_chr1.bed.txt
3CGvs1CGregion_chr1.bed.txt

@brentp let's try to have a look at this together when you return.


Feature Request: Parallax support in ion-slides

Short description of the problem:
Swiper (the underlaying widget of ion-slides) supports parallax transitions. I'd like to use those in my Ionic app, so I activated them, but something in ion-slides' custom structure makes it impossible to use that feature (my bet is .slide-zoom).
Other information:
There could be a new element like ion-parallax with properties like offset and transition duration.
Which Ionic Version? 2.x

Hello! We are moving our feature requests to a new feature request doc. I have moved this feature request to the doc and because of this I will be closing this issue for now. Thanks for using Ionic!

Has Ionic team started working on this feature? which is, do I expect this feature in a near future ionic version?

Hello all! While this is an awesome feature request it is not something that we plan on doing anytime soon. Because of this I am going to move this to our internal feature tracking repo for now as it is just "collecting dust" here. Once we decide to implement this I will move it back. Thanks everyone for using Ionic!

This issue was moved to driftyco/ionic-feature-requests#41

Hello everyone! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!


Zooming to max zoom when detectRetina:true will make Leaflet zoom beyond max zoom.

When setting detectRetina:true on a tilelayer, zooming to max will cause Leaflet to zoom beyond the max allowed zoom.
I have this starting line:
var mymap = L.map('mapid', {maxZoom:17, minZoom:10,maxBounds:[[54.944734, 15.393258],[55.410491, 14.470423]],}).setView([55.071649, 14.920133], 13);
L.tileLayer('https://mydomain.com/mymap/x4/{z}/{x}/{y}.png', {detectRetina:true}, {attribution:'test', id: 'mapbox.streets' }).addTo(mymap);
My files are from zoom-level 9-17. If I change the maxZoom to 16, I don't have any issues. If maxZoom is set to 17 while detectRetina:true will cause Leaflet to zoom beyond 17. If detectRetina:false is set, everything works as intended.

Oops, the documentation actually say that this will happen..then not a bug, I guess.


Add copy method

If you want to use the same object to run over different groups of data, collecting objects, right now you need to re-initialize, or explicitly copy. A copy method would probably be useful.

Added.


Doesnt create output file

hi
if i run this command
ReportUnit.exe "D:\SourceXml\TestResult.xml" "D:\OutputHtml\report.html"
i am expecting the output file to be report.html but it is not, always calls it TestResult.html regardless.  Am i missing something ?

Version?

version <IP_ADDRESS>

Currently, it names the file as the same as the one being converted..  But its easily changed, will include this in next


 I tested the riscv_dret_test and other similar tests that you noticed some arbitrary errors in, and they all seem to pass successfully with these changes
A few notes about some parts of this PR:

ibex_mem_intf has two driver clocking blocks added, one for host side and one for device side. This is because our Ibex testbench currently provides both host and device agents for the Ibex I/D-side interfaces (of course we only use the reactive device agents in the main testbench). If you feel the host agents should be removed, I can do this in a later PR.
csr_if has only one clocking block - this is because the signals bound to this interface are only ever sampled, never driven (these are signals internal to the CSR 'register file').
dut_if has only one clocking block as well - this is because fetch_enable and debug_req are only ever driven, never sampled, and the remaining signals are only sampled, never driven (these are signals internal to the ibex_controller, so we can make do with a single clocking block here.
some utility tasks have been added to some interfaces to wait for a specified number of clock cycles - no other significant changes are present in this PR apart from this.

@rswarbrick thanks for the comments! A lot of the code in this testbench is relatively "old" (written around mid-2019), so it's definitely good to go through and update some old formatting styles.
I've also updated the commit message as per your request.


Bugfix: fix variable name and inference config.

Fix wrong variable name: enable_flashattn to enable_flash_attn.
Fix model dtype: From default to bf16.

Thank you for your PR. Your suggestion is valuable. However, we are now conducting a transformation of our model to huggingface's conversion. Thus, we will use another format and close your PR for now.

Thank you for your PR. Your suggestion is valuable. However, we are now conducting a transformation of our model to huggingface's conversion. Thus, we will use another format and close your PR for now.

Really looking forward to the transition to the Hugging Face format, it's indeed a great move.


Differences between aioredis and asyncio-redis

Asyncio-redis is a fairly complete and mature asynchronous redis implementation. I'm curious as to what sets aioredis apart from it?
https://github.com/jonathanslenders/asyncio-redis

Oh, well)

First of all I tried to make it simplier -- asyncio_redis implements asyncio.Protocol (lots of code) vs aioredis uses asyncio.StreamReader/StreamWriter (no protocol code; just read & send);
At the moment when I started aioredis asyncio-redis had no hiredis parser.
asyncio_redis API forces end-user to work with one type of data, ie only bytes or only unicode or etc. So you would receive an error trying to mix data types, say set('unicode_key', b'encoded_bytes_data').
asyncio-redis has no way to execute raw command
"automatic reconnections", well, in asyncio-redis if the server has gone away would reconnect, reconnect and reconnect. I mean reconnection is done as soon as connection is lost which is bad. For instance we had functional tests infrastructure where we were starting & shutting down standalone redis server instance so after all tests we had several hundreds of spamy errored 'reconnect' messages.
aioredis doesn't have pub/sub yet, but it is in progress and will be implemented soon.

How does aioredis handle disconnections ?
I'm having trouble with asyncio-redis not closing connections.
Redis says it has reached the max number of clients. But most of them are ghosts.
Do you think aioredis is better at handling those ?
Also, does aioredis support async with ?


Second screen

Timer & result & Cookies & Put the answer description including doc link

Create a simple version of it, because the user needs this feedback => Know the word & description


v4: The placeholderClassName prop does not work

<EMAIL_ADDRESS><EMAIL_ADDRESS>
The 4.0.13 release of NativeWind no longer supports placeHolderClassName:
import * as React from "react";
import { Text, TextInput, View } from "react-native";
import "./globals.css";

export default function App() {
  return (
    <View className="flex-1 bg-white items-center justify-center gap-8 p-6">
      <View className="gap-2 w-full">
        <Text>The placeholder below should be yellow-300</Text>
        <TextInput
          className="bg-slate-900 h-10 text-white px-2"
          placeholder="Placeholder text"
          placeholderClassName="text-yellow-300"
        />
      </View>
    </View>
  );
}

Unless I am missing something, placeholderClassName above should work.
Sample repo here: https://github.com/robcaldecott/natibewind-4-placeholder

WOAH this was hard to find. It would be really great if the docs could point to a list of all the clever additions you've made, even if it's just a typedef somewhere. Unless this is a TW thing I'm not familiar with, this was really non-discoverable for me.


ZAT will not install on Apple Silicon/M1 processor nor MacOS BigSur

Looks like errors in thin version 1.7.2 with XCode 12 prevent ZAT from installing.

Seems that updating the gemspec file to:
  s.add_runtime_dependency 'thin',        '~> 1.8.0'

Then changing .ruby-version file to 2.6.3
And running a bundle install to build our local copy of ZAT worked to get around!

Same problem on Big Sur. The latest version of thin installs just fine, so it probably just needs to be bumped in this gem's Gemfile. Here is the full stack trace:
$ gem install zendesk_apps_tools
Building native extensions. This could take a while...
ERROR:  Error installing zendesk_apps_tools:
	ERROR: Failed to build gem native extension.

    current directory: /Users/pelargir/.rvm/gems/ruby-2.7.2/gems/thin-1.7.2/ext/thin_parser
/Users/pelargir/.rvm/rubies/ruby-2.7.2/bin/ruby -I /Users/pelargir/.rvm/rubies/ruby-2.7.2/lib/ruby/2.7.0 -r ./siteconf20201228-56046-cj876b.rb extconf.rb
checking for main() in -lc... yes
creating Makefile

current directory: /Users/pelargir/.rvm/gems/ruby-2.7.2/gems/thin-1.7.2/ext/thin_parser
make "DESTDIR=" clean

current directory: /Users/pelargir/.rvm/gems/ruby-2.7.2/gems/thin-1.7.2/ext/thin_parser
make "DESTDIR="
compiling parser.c
parser.c:31:18: warning: unused variable 'http_parser_en_main' [-Wunused-const-variable]
static const int http_parser_en_main = 1;
                 ^
1 warning generated.
compiling thin.c
thin.c:242:3: error: implicit declaration of function 'thin_http_parser_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  thin_http_parser_init(hp);
  ^
thin.c:242:3: note: did you mean 'http_parser_init'?
./parser.h:41:5: note: 'http_parser_init' declared here
int http_parser_init(http_parser *parser);
    ^
thin.c:260:3: error: implicit declaration of function 'thin_http_parser_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  thin_http_parser_init(http);
  ^
thin.c:277:3: error: implicit declaration of function 'thin_http_parser_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  thin_http_parser_init(http);
  ^
thin.c:294:3: error: implicit declaration of function 'thin_http_parser_finish' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  thin_http_parser_finish(http);
  ^
thin.c:294:3: note: did you mean 'Thin_HttpParser_finish'?
thin.c:290:7: note: 'Thin_HttpParser_finish' declared here
VALUE Thin_HttpParser_finish(VALUE self)
      ^
thin.c:296:10: error: implicit declaration of function 'thin_http_parser_is_finished' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  return thin_http_parser_is_finished(http) ? Qtrue : Qfalse;
         ^
thin.c:334:5: error: implicit declaration of function 'thin_http_parser_execute' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    thin_http_parser_execute(http, dptr, dlen, from);
    ^
thin.c:334:5: note: did you mean 'Thin_HttpParser_execute'?
thin.c:317:7: note: 'Thin_HttpParser_execute' declared here
VALUE Thin_HttpParser_execute(VALUE self, VALUE req_hash, VALUE data, VALUE start)
      ^
thin.c:338:8: error: implicit declaration of function 'thin_http_parser_has_error' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    if(thin_http_parser_has_error(http)) {
       ^
thin.c:338:8: note: did you mean 'http_parser_has_error'?
./parser.h:44:5: note: 'http_parser_has_error' declared here
int http_parser_has_error(http_parser *parser);
    ^
thin.c:359:10: error: implicit declaration of function 'thin_http_parser_has_error' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  return thin_http_parser_has_error(http) ? Qtrue : Qfalse;
         ^
thin.c:374:10: error: implicit declaration of function 'thin_http_parser_is_finished' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  return thin_http_parser_is_finished(http) ? Qtrue : Qfalse;
         ^
9 errors generated.
make: *** [thin.o] Error 1

make failed, exit code 2

Gem files will remain installed in /Users/pelargir/.rvm/gems/ruby-2.7.2/gems/thin-1.7.2 for inspection.
Results logged to /Users/pelargir/.rvm/gems/ruby-2.7.2/extensions/x86_64-darwin-19/2.7.0/thin-1.7.2/gem_make.out

I have the same issue.

For anyone having the same issues on m1 Macs and if you have no idea how to modify the .gemspec file as suggested, you can install thin version by specifying the 1.7.2 explicitly using this command: gem install thin -v 1.7.2 -- --with-cflags="-Wno-error=implicit-function-declaration"

I also have this error, and I'm on an Intel Mac running MacOS Catalina 10.15.7.
@kyleleow your solution worked, but I think it might be worthwhile looking at this since it does not seem M1 Mac specific.

I solved the problem in the following way
 bundle config build.thin --with-cflags="-Wno-error=implicit-function-declaration"
 bundle install

Reference: https://stackoverflow.com/questions/63187613/fail-to-bundle-install-puma-4-3-5-or-gem-puma-with-ruby-2-6-6-on-macos-10-15-6/63201544#63201544

Hi!
I had the same problem on my Mac Big Sur 11.6 with M1 chip. None of the suggested solutions helps me (I tried to reinstall Xcode, updating/reinstalling command line tools, deal with the installation of thin separately, etc.). One thing that really helps me it's changing the ruby version to 2.6.9 with rbenv (https://gorails.com/setup/osx/11-big-sur - check Installing Ruby . Follow this instruction, but choose another ruby version). After change ruby version, make sure the correct version of ruby is currently selected with ruby -v and then try execute gem install zendesk_apps_tools again. I tried several versions of ruby before it worked for me, but in the end everything was fine on 2.6.9 version

Can confirm that v2.6.9 of Ruby and ZAT is now working fine on Monterey 12.3.1 with M1 Max. This is using Node v14.20.0.
Had proper headaches and went down numerous rabbit holes getting this up and running, before finding the answer in this issue; the documentation alludes to ZCLI (the node based tool) being a replacement for ZAT that works for M1 architectures. The problem is that functionality is half-baked and you can't preview themes locally with ZCLI.
Zendesk, please make this clear in the docs here https://developer.zendesk.com/documentation/apps/zendesk-app-tools-zat/installing-and-using-the-zendesk-apps-tools/#installing-zat and also https://developer.zendesk.com/documentation/apps/app-developer-guide/zcli/


Improvement for node cli

Great project, I'm studying also reactive programming for my projects with this usefull implementation of the maven confluence plugin. But in my opinion, it would be nice to have a package.json with the typescript cli ( I suppose that you transpile the files under ts folder in dist with the tsc command), a npm script to perform this, and finally a .npmignore in order to publish only the dist folder without ts files. All these things could be automated in ci with a .travis file for your cli branch (I guess that the cli-dev branch is the development branch while the cli branch contains your releases).
If you want, I can help you and open a pull request for the code review.
It is a suggestion :).
Thanks

Hi @amanganiello90
It would be great ... go ahead with PR

Thanks, Bartolo! I integrated the typescrypt cli in the package.json, but I have errors when I transpiles the files (maybe for tsconfig.js configuration or typescript version). Could you give me your typescrypt cli version and/or the commands that you performs to generate js file under dist?

I use only tsc --watch during development
> tsc --version
> Version 3.0.1

Don't you install typings? I have ts error during transpilation. For example:
ts/logo.ts:45:15 - error TS2345: Argument of type '<T>(array: ArrayLike<T>, scheduler?: IScheduler) => Observable<T>' is not assignable to parameter of type '_ValueOrSelector<string[], ArrayLike<{}>>'.
  Type '<T>(array: ArrayLike<T>, scheduler?: IScheduler) => Observable<T>' is not assignable to type '_Selector<string[], ArrayLike<{}>>'.
    Types of parameters 'scheduler' and 'index' are incompatible.
      Type 'number' is not assignable to type 'IScheduler'.

45     .flatMap( Rx.Observable.fromArray )

I resolved the errors...You have only to link your repo to travis and define the NPM_TOKEN (in travis buid plan) variable of travis.yml file to use the npm publish in the continuous integration. I Add the PR https://github.com/bsorrentino/maven-confluence-plugin/pull/174. If you are happy, please insert me as contributor :)


Setting a backup path will only set if it is a directory, but it is used as a file path in backupPhar()

When you try to setup a different backup path using the documented setBackupPath()  it goes to great lengths to ensure it is a directory.  However, if you try to update the phar it is assumed in getBackupPharFile() that the backup path is actually to a file.  When you then try and run the command it fails on line 364 of Updater.php because you cannot copy a file to a directory in that way.

This is true. I just wrapped up some Humbug work (new phar build). I'll be back on phar-updater to firm up the rollback and Github Releases support tomorrow. So this will get fixed then.
Thanks for trying it out though! Hopefully I can put out a stable first release shortly.

Thanks for writing such a handy tool - I look forward to the fix :o)


refactor(ui): add a new design

Description
This proposal introduces a new interface design using the chakra-ui, that provides some enhancements:

Better visual ui
Dark mode
A lot of components
Test outside the box
Flexible ui
And more

Other changes

Typescript
This was totally optioned, the project is recent and we can write the types gradually into the project, I think this help us do a better code along the time.

Folder structure
The folder core was removed, and the components were moved to the root.

Componentes naming
Some components were renamed to be more generic, this helps us understand the characteristics more easily, the idea is to move some components to the scope of the page, like the Demo renamed to Card.

API
The emoji on the title was moved into a new item, to keep the SEO more accurate and a better UI management.

Design
The Card was redesigned, to be cleaner, and enforce the user access to the content.
And was added `dark mode support.

NOTE
I did the redesign only on Homepage, if this PR is accepted, I will happy to continue working on this.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Tested on desktop, tablet, and mobile devices.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@mverissimo Thanks for putting it together. I haven't used chakra before but heard about it. Do you see it having any issues with TailwindCSS together? We will support themes and other customizations in the future. So I want to confirm, we have researched any impact of an incoming library with the existing ones.
Btw.. the UI improvements so far look fab!

Hello @atapas, I really like to use TailwindCSS too, but he works more efficiently with landing pages because we can code a customized layout fast. When starts talk about systems, I think he does not scale well, we need to implement events, accessibility, new components and think about the maintainability along the time, how any system. So I chose chakra because we have a lot of components tested, accessible, etc, and we can create custom themes with him.

I won't recommend using chakra ui from my personal experience. Chakra ui is definitely great but for large project. But in small project, it cost us performance. Using tailwind css gives us a great load time.

Hello @atapas, I really like to use TailwindCSS too, but he works more efficiently with landing pages because we can code a customized layout fast. When starts talk about systems, I think he does not scale well, we need to implement events, accessibility, new components and think about the maintainability along the time, how any system. So I chose chakra because we have a lot of components tested, accessible, etc, and we can create custom themes with him.

Let me tell you, I loved the UI transformation a lot. It look very silky and the theme switcher works well already for the landing page. The demo pages have more work to do but I understand it is work in progress.
I'm concerned of having both tailwindcss and chakra both for a small project like this. We should go for one of them I feel. What's your thought of continuing the UI look and feel change using tailwind? Would you be comfortable taking it up? I really liked your work and appreciate it so far.

My take on this is that I would highly recommend to continue with tailwind. No doubt chakra ui is great and appreciate your effort for that beautiful ui. But from my experience, I think tailwind css has great site loading time and performance with small project.

Hello @atapas, I really like to use TailwindCSS too, but he works more efficiently with landing pages because we can code a customized layout fast. When starts talk about systems, I think he does not scale well, we need to implement events, accessibility, new components and think about the maintainability along the time, how any system. So I chose chakra because we have a lot of components tested, accessible, etc, and we can create custom themes with him.

Let me tell you, I loved the UI transformation a lot. It look very silky and the theme switcher works well already for the landing page. The demo pages have more work to do but I understand it is work in progress.
I'm concerned of having both tailwindcss and chakra both for a small project like this. We should go for one of them I feel. What's your thought of continuing the UI look and feel change using tailwind? Would you be comfortable taking it up? I really liked your work and appreciate it so far.

I appreciate that you like the new design 😄 🚀 , maybe we can use both Tailwind on the landing page and Chakra on system general, what do you think? Personally prefer to keep using them because require less work, otherwise, we need to create a small set of components like, Button, Input, Typography, to reduce rewrite some styles with Tailwind, and this prevents that new contributors create new components unnecessary.
About the Demo page, I pretend to work on them soon, just waiting for the response on issue and our decision about the library that we use 😃

My take on this is that I would highly recommend to continue with tailwind. No doubt chakra ui is great and appreciate your effort for that beautiful ui. But from my experience, I think tailwind css has great site loading time and performance with small project.

I agree with you, this is a small project maybe we don't need the Chakra, but I think that this project will grow with time, many other guys will send some demo, and with this, more and more components, and about the performance I can't see a real impact, we can perform this with next(SSG, SSR), and the demos are simple in general.


Flaky avoid_redundant_argument_values lint

This is a little strange and doesn't reproduce consistently, but I'll try to provide as much details as I have. In IntelliJ I have a workspace that has a bunch of projects open (including the flutter repository). In this one, I also have a tiny playground project with two files:
foo.dart:
class Foo {
  Foo({required this.foo});

  Bar? foo;
}

class Bar {

}

main.dart:
// @dart = 2.9

import 'foo.dart';

void main() {
  Foo(foo: null); // 🔥 sometimes this line has an incorrect avoid_redundant_argument_values
}

Now, sometimes I see what appears to be an incorrect avoid_redundant_argument_values warning on the line with the 🔥. The warning doesn't show up consistently. Sometimes it doesn't show up at all, sometimes it shows up for 5s to 10s and then disappears. Sometimes it sticks around indefinitely until I edit the code again. It's a bit of a mystery.
Here are random changes I have made to the files to make the warning appear/disappear (I believe the warning is incorrect in all cases):

change the type of the foo field to int?
change it back to Bar?
remove the @dart directive from main.dart
put the @dart directive back in
add empty new lines at the end of the main.dart file

@srawlins

This whole investigation was triggered because in flutter we removed a bunch of // ignore: avoid_redundant_argument_values warnings that didn't appear to ignore anything and the PR was analyzer clean locally and on CI [1]. After the PR was submitted, Continued to stay green and then about 5 commits later, CI started to complain about the lines where we previously removed the //ignore avoid_redundant_argument_values. Interestingly, CI was still clean for the simple flutter analyze --flutter-repo case that just analyzes the entire repository.  We ended up putting these ignores back in, even though they shouldn't be needed [3].
[1] https://github.com/flutter/flutter/pull/108924
[2] https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8806782704607467489/+/u/run_analyzer_benchmark/test_stdout
[3] https://github.com/flutter/flutter/pull/108984

@scheglov I sat with @goderbauer as he reproduced the flakiness in the IDE. I think this is a really good repro (at least on his machine with a large workspace open in IntelliJ).
The diagnostic would remain in the Diagnostics panel for a while (~a minute; seemingly stable) while we kept foo.dart in focus. If we moved over to main.dart, and made a trivial whitespace change, then 5 seconds later the diagnostic would disappear.

Interesting. When I restart DAS, there is never any hint on Foo(foo: null). When I switch to Foo declaration, and switch back there is always the hint on Foo(foo: null). It seems that resolving the file with Foo changes the state of the element model for Foo.
What should happen here? The parameter is nullable, so passing null is not necessary. But the parameter is also required, so we have to provide something, e.g. null. So, we probably should not get the hint.

What should happen here? The parameter is nullable, so passing null is not necessary. But the parameter is also required, so we have to provide something, e.g. null. So, we probably should not get the hint.

I think there should be no hint here.

What should happen here? The parameter is nullable, so passing null is not necessary. But the parameter is also required, so we have to provide something, e.g. null. So, we probably should not get the hint.

I think there should be no hint here.

not getting the hint would be great

If I had a choice between getting the hint and correcting the flakiness, I would choose the latter 😛

Well,  now I got it to the state when we always report the hint :-D

The main issue is that when looking from a legacy library, we consider required this.foo as optional, as requested in https://github.com/dart-lang/sdk/issues/43397. So, the linter does not exit on !param.isOptional. The flakiness is because with element model we compute values only for constant.isOptional parameters. But this time, we are looking at the declaration of foo, which is required, so not optional. Apparently resolving the unit still compute its value somehow. We can "unflake" it by computing default values always.
So, I'm not sure how to make that it does not report the lint.

A solution could be to update the lint rule so that it checks that the declaration of the parameter it required.
      if (param.declaration.isRequired || param.hasRequired) {
        continue;
      }

@pq Not sure about the semantics here.

https://dart-review.googlesource.com/c/sdk/+/253705 will update the analyzer to evaluate default values, so unflake it.

A solution could be to update the lint rule so that it checks that the declaration of the parameter it required.

Is there a test case I can use to reproduce this in our reflective tests?  Maybe once a deflaked analyzer is published?

Here is what I used locally.
@reflectiveTest
class ZZZTest extends PubPackageResolutionTest {
  solo_test_XXX() async {
    writeTestPackageAnalysisOptionsFile(
      AnalysisOptionsFileConfig(
        lints: ['avoid_redundant_argument_values'],
      ),
    );

    final a = newFile('$testPackageLibPath/a.dart', r'''
class Foo {
  int? foo;
  Foo({required this.foo});
}
''');

    final b = newFile('$testPackageLibPath/b.dart', r'''
// @dart = 2.9
import 'a.dart';

void f() {
  Foo(foo: null);
}
''');

    // Uncomment to get the lint reported.
    // await resolveFile2(a.path);

    await resolveFile2(b.path);
    assertNoErrorsInResult(); // does not matter, just to see if there are or not diagnostics
  }
}

FYI, https://dart-review.googlesource.com/c/sdk/+/253705 landed, and breaks Flutter at least once.
Looks like exactly the issue with the lint that this issue is about.
Analyzing 3 items...

   info • Avoid redundant argument values • dev/integration_tests/android_semantics_testing/lib/src/tests/controls_page.dart:71:28 • avoid_redundant_argument_values

1 issue found. (ran in 170.3s)

It's complaining about this line here:
https://github.com/flutter/flutter/blob/49fbf19590fd206af1a78cde93ffba9eeb6bcc0f/dev/integration_tests/android_semantics_testing/lib/src/tests/controls_page.dart#L71
But onChanged is a required argument, removing it triggers the missing_required_param warning. So the lint there again is bogus and shouldn't really be there.

True, as I described above, my change it to make it not flake.
Which means that the lint rule now always reports the lint.
We still need a fix (again, outlined above) to the lint rule.
For now the best I can think out is to // ignore it.


[help] Fixed index

Hi, what i'm trying to do is to "fix" the index of the swiper.
i'm passing an  array with three position [0,1,2], and what i'm doing is change the information, when i swipe from right to left, i pass the information from [1] to position [0], [2] to position [1] and a i put new information in position [2] of the array.
In iOS i already did this, by changing  in the file react-native-swiper/src/index.js, but in android dosent work.
Anyone have an ideia ??
original file in line 193
if (state.total === initState.total) {
  // retain the index
  initState.index = state.index
} else {
  // reset the index
  initState.index = initState.total > 1 ? Math.min(props.index, initState.total - 1) : 0
}

changed
if (state.total === initState.total) {
  initState.index =1
} else {
  initState.index = 1
}

What happens in Android?
Also, you don't need the if conditional, if you're hardcoding initState.index = 1 in both cases.

Hi there, tanks for the reply.
I know that i don't need the if conditional, it was for a better understanding where i change the code. :)
In android if i swipe right to left  [1]->[2] the swiper index get stuck in index 2, it doesn't go back to position 1 when the information is updated.
If you prefer i can create a video/GIf showing what happens in android and in iOS

Update From what i understand the problem is here.
I may be wrong, but from what i'm understanding the component ViewPagerAndroid as is own index.
return _react2.default.createElement(
  _reactNative.ViewPagerAndroid,
  _extends({ ref: 'scrollView'
  }, this.props, {
    initialPage: this.props.loop ? this.state.index + 1 : this.state.index,
    onPageSelected: this.onScrollEnd,
    //onPageSelected: ()=>{},
    style: { flex: 1 } }),
  pages
);

Hi there, as i thought the ViewPagerAndroid  as its own index state, so when i hard coded the change of the index to 1 in swiper component, the index in ViewPagerAndroid didn't change, in swiper the index was 1, but in ViewPagerAndroid was 2 or 0.
Any way i forced using ViewPagerAndroid.setPageWithoutAnimation(1) to every time the data changes he goes to position 1.
Thanks for the reply @getnashty , and if anyone knows a better way of doing this please tell me :)


0.1 Review Comments/Questions: Clarification Requests for Chapter 5 "I/O MTT extension"

Page 28, third paragraph refers to "listed fields" and "unlisted fields". I assume it is referring to the list of fields provided for SET_ENTRY in first paragraph. But, I think the document should be explicit about which fields apply to each "OP" rather than leaving it implied.
Page 30, Table 10 has a SRC_IDM column numbered 0 to 3. The text above the Table says that SRC_IDM=NAPOT which is encoding 2. So, I assume the table shows examples of NAPOT encodings. So, what does the SRC_IDM column mean?
Also regarding Table 10 and the text above it - it says SRC_ID is set to DEVID. I assume that refers to encoding 1 - Filter by device ID - defined in Table 8, but the term "DEVID" is not defined. So, I have to infer that meaning rather than it being explicitly defined. Can the table be updated to define DEVID or the text changed to refer to "Filter by device ID"?
Page 30, Table 11 uses the term "TEE_LIM". I don't know what that is. Should it be defined here or point to a reference?
Page 31, 2nd paragraph, I infer that the value written into the PPN field requirements are the same as those define on page 13, 2nd paragraph for the mttp PNN field. Can that be made explicit?
More generally, I think that this chapter would benefit by providing a cohesive description of how S/W uses the SET_ENTRY "OP" to construct a table of "rules" which maps devices to SDID, IOMMU ID and MTT base address and how this table is used by SDCL.
Regarding mapping a devices to SDID/IOMMU/MTT base mapping - One may need to use multiple ruleids to map multiple devices to the same SDID/IOMMU/MTT base. A programming error could incorrectly specify the two devices with the same SDID but different MTT bases. or vice versa What does the spec say about that? Should H/W catch that and report an error in the control.STATUS? Or does that lead to UNSPECIFIED beahavior?

Reworded to clarify in #82. The section 5.5 and 5.6 call out which fields of the operands used by each operation.
These typos have been addressed in #67
Updated Table 10 caption in #82
TEE_LIM is a typo. Has been addressed in #67
Updated in #82
The specifications and examples are explanatory in this case.
When two devices are specified to use same SDID but different MTT then either of the MTT may be used for enforcing the access. This is clarified in #82

Regarding mapping a devices to SDID/IOMMU/MTT base mapping - One may need to use multiple ruleids to map multiple devices to the same SDID/IOMMU/MTT base. A programming error could incorrectly specify the two devices with the same SDID but different MTT bases. or vice versa What does the spec say about that? Should H/W catch that and report an error in the control.STATUS? Or does that lead to UNSPECIFIED beahavior?

Is the implication here that the I/O MTT can share cache entries across rules with the same SDID, so we can't know which MTT PPN was used to fill the cache? If so, this needs to be stated explicitly, and the description of MTTINVAL needs to be updated. Right now the spec says:

If the PPNV field is 0, the MTTINVAL operation affects all entries from the MTT associated with RULEID.

But it sounds like what you really want is:

If the PPNV field is 0, the MTTINVAL operation affects all entries with an SDID equal to the SDID in the rule given by RULEID.

(and we should probably clarify that the scoping to a particular rule or SDID applies even when PPNV == 1.)


Replace nodeSelector with nodeAffinity for singleuser notebook servers.

This will allow the user servers to run on core nodes from the core pool too and potentially make server spawn faster.
Should fix the timeout errors seen in the deployments tests that we run.
This PR tries to replicate the z2jh behavior of  scheduling.userPods.nodeAffinity.
Things that I'm unsure of:

I'm not sure if setting the node affinity in both KubeSpawner and jupyterhub.userAffinity was necessary, as setting it only in KubeSpawner seems to produce the desired behaviour:

Is there an issue that we have 2 node affinities set for the single user servers and they have the same weight?
If so, is there a way to remove the one coming from z2jh?

cc @yuvipanda and @consideRatio

Thank you @consideRatio :)
I tried testing this in the following scenario, but I'm a bit unsure if the right thing it's happening:

I started a user server when only one core node and no user node was available.

the user server got scheduled on the core node (:heavy_check_mark:  this is what should have happened, right?)

I started a user server when only one core node and one user node were available.

the user server got scheduled on the core node again (:x: It should have preferred the user node instead, right?)

I'm only seeing the z2jh default injected node affinity now :confused:

@consideRatio can we not just use https://zero-to-jupyterhub.readthedocs.io/en/latest/resources/reference.html#singleuser-extranodeaffinity instead? I thought that was the way to set node affinity for user pods.
I think the two scenarios you tested are right, @GeorgianaElena! The third one is that core node is full, new node needs to come up. It should spawn a user node, not a core node.

I'm only seeing the z2jh default injected node affinity now confused

@consideRatio can we not just use https://zero-to-jupyterhub.readthedocs.io/en/latest/resources/reference.html#singleuser-extranodeaffinity instead? I thought that was the way to set node affinity for user pods.

Ah, yes @yuvipanda! My suggestion was wrong @GeorgianaElena!
I got confused by the documentation. I thought scheduling.userPods.nodeAffinity was a configuration option, while in practice it was just a category of configuration wherein we had the option matchNodePurpose.

Thank you @yuvipanda and @consideRatio for reviewing this :tada:

The third one is that core node is full, new node needs to come up

I was thinking to test this by doing a manual deploy to all of the hubs while checking the number of nodes being created in the cluster. Alternatively we could merge this and let the CI do the deployment. @yuvipanda, what do you think?
Also, should we also increase the 5 min spawn timeout of the hub health check? I'm thinking that at some point (when the core node is full, a user node will need to be created) it will need more?

@GeorgianaElena manually doing a deploy to test this seems like a good idea.
We might have to increase the node timeout unfortunately. Can you get a measure of how long it takes to launch a new node + pod on it and we can set the timeout to that?

Can you get a measure of how long it takes to launch a new node + pod on it and we can set the timeout to that?

I tried this by creating a server on the dask-staging hub when no user node was available and with the user-pool selector still in place. This is what happened:

Server appeared ready in the hub logs:
[I 2021-03-02 10:19:15.348 JupyterHub users:664] Server<EMAIL_ADDRESS>is ready

So, it looks like it took the server 3m2s to start. This includes:

launch a new node and pod
image pull
notebook server start

That is actually quite fast! Although, just before that I actually logged in to https://swot-ocean-pangeo.pilot.2i2c.cloud and maybe that spawned a node? If it spawned a new node, there's usually an entry about 'triggered scale up' in the event history. Sorry :( I'll log off now...

This time I made sure there was only the core node available and the scale up event was present:

[I 2021-03-02 11:15:41.449 JupyterHub users:664] Server<EMAIL_ADDRESS>is ready

Everything still happened in about 3m...
I'll try the manual deploy to all the hubs once the user pool scales down to 0 again (is there a way to force this somehow?) and check the pod events if/when it gives a timeout.

woah, that's awesome! Yeah, please try a full deploy and see what happens

Everything passed :sweat_smile:
I'll however increase the timeout with 60s (around how much it takes the user node pool to scale up) because I saw some tests taking about 4min even though there was a user node available.

Hope this will make the tests fail less often at least :confused:

@yuvipanda, merge this and :crossed_fingers: the tests become more reliable?


Add Reject functionality to Dev phone

Voice Manager should handle the Reject event for incoming calls and reset state accordingly

HI @ayyrickay,
I've tested it myself, so I know what the issue is about, but I'm confused by the label tag: needs-design.
As I understand, the design as it is right now (layout of a button, colours of hangup, etc...) should be kept, just the functionality of the reject button should be working. Also if the incoming call is hanged by whoever side, it should restart to the full-width button call.
Thanks for the clarification.

@hatealgebra I think that's correct. I'm not totally sure of why I added needs-design, I think I assumed that there was more of a requirement there. I can give it a look, but if you think this is ready for work, feel free to pick it up!

@ayyrickay
Hi,
I'm back. I had a busy last week. I'm coming with an update.
I've managed to find out what is causing this issue.  In the voice manager file the disconnect fn is called on the activeCall instance:
https://github.com/twilio-labs/dev-phone/blob/2c89b34f7e059644f41dedccaebc0d86ce67f092/packages/dev-phone-ui/src/components/WebsocketManagers/VoiceManager.jsx#L49-L80
I've switched the activeCall.disconnect() for activeCall.reject() and the on subscriber for reject. Also, there is another event handler for the reject method.
            activeCall.on('reject', call => {
                call.removeAllListeners()
                updateCallInfo(null)
            })

This code enables the button to reject the call, it is successfully mirrored in the UI, and also it is shown on the device with the unbound call. I've an an idea how to proceed, but I I would be thankful for your insight. Maybe I'm missing something.

The disconnect and reject methods are reacting differently according to the state of the call. For the user the result is same, but application needs to handle it differently. If I'm correct, then the button would need conditions for onClick, where it checks the state and then decides which method it would call onClick?

.on event handler acts more like a clean up/reset state action. IMHO, the cleanup for hang up and disconnect could be same or are there some other things that also needs to be taken care of?

Thanks for you insight and message.

I believe this makes sense. Makes sense that reject seems to be its own method, and we just need to expose that in the UI instead of trying to disconnect.
This one seems safe to proceed!


Random question

I've looked at this code a bunch and always wondered, what's up with these two conditions. Do you happen to remember? Apologies for the sort of weird ask:
    pub(crate) fn insert(&mut self, key: &[u8], value: V) -> Option<V> {
        if self.label().get(0) > key.get(0) {

This condition also shows up a bunch:
} else if common_prefix_len == 0 && self.label().get(0) <= key.get(0) {

I don't understand why it would matter that the first byte is <=, or conversely on insertion why it would matter if the label being added starts with a larger byte. Any insight?
The condition on insert makes it such that if you have "abc" and insert "dabc" you get "dabc" - sibling -> "abc" instead of the other way around, but I'm not sure why that matters.

Thank you for your question.
Since I'm busy on weekdays, I'll respond weekend.

The condition on insert makes it such that if you have "abc" and insert "dabc" you get "dabc" - sibling -> "abc"

It's not true.
Since self.label() == "abc" and key == "dabc", the condition becomes 'a' > 'd'.
Thus it doesn't hold and we get "abc" - sibling -> "dabc" I think.

(BTW, looking back the code I think that I might be able to use < instead of <= in the condition self.label().get(0) <= key.get(0).)


nextPage, previousPage, animateToPage direction problem on the last page and on the first page

When nextPage runs on the last page, it should go forward to the first page, not go backwards.

Hi, thanks for opening the issue, I will check It out.

Hi @wfinf could you elaborate a little more on your use case that is triggering this issue?
I tested with the Example code and it seems to be working
https://user-images.githubusercontent.com/3476417/136302343-8277d924-65e8-456b-aeba-fa4c359857a5.mp4

Thanks, I will take a look at it.

Hi @wfinf, sorry for the delayed response.
What you described is actually the expected behavior!
The widgets inside LoopPageView are as in a 'closed loop'. You can manually move the loop to any direction you want, but when animating the move, LoopPageViewController will always move in the direction with 'less steps'.
When the travel distance is equal for both directions LoopPageViewController will always prefer to stay in the 'current loop' and will move to the left.
This is what happens when itemCount is 2 and you want to animate the move from page 1 to page 0.


just changing version to look at the project

nothing

Sorry to anyone who waste their time looking at this, I don't know GitHub well enough yet and apparantly I can't delete this pull request by myself


Radar chart collapses into labels on resize

Radar chart looks messed on page resize (it is so for small page sizes, but still not very nice). Ideally I want to see chart itself all the time, even if labels are gone on smaller screens. Right now I observe the opposite of what I would like to see.
I can reproduce in Chrome and Firefox but I did not test in other browsers. Chart version 2.5
Example.
https://jsfiddle.net/dgamhh0p/2/
Steps to reproduce:

Create radar chart with some data
Resize the window

Expected Behaviour
Chart resized or Labels will be hidden, but main data will remain visible
Current Behaviour
Main data collapses or inverted but labels are visible.
Normal size and chart

Resized area

Even more resized area

Note that on the last screenshot chart data is inverted compared to original.
Is there a way to solve this problem? Possible workaround?

One option here is to write a plugin that turns off the label display when the chart sizes very small. I think at one point @simonbrunel was working on a plugin that had a concept of generic 'rules' that would apply to the chart config and allow changing the options as the chart size changed.

Thanks for info. I will check docs on plugins. But this inversion worries me as well, do you think such plugin could care about this either?

The plugin that @simonbrunel was creating was very generic and was only to control changes to the config based on the size (almost like how CSS media queries apply new rules based on the window size).
It is a bit odd at first that a plugin controls the config, but it allows for a very extensible solution

Well, before starting and explaining my example code for solving this problem,  I want to mention some important facts about Chart.js and its labeling problems.
Today that we are at v.2.9.4, Chat.js made pointLabels fontSize so small that in normal cases of labels name we will not face any problem. But even in this situation if we make the label text too long, then we may face some problems. Depending on where our long label position is, we may face small or big problems!
In this case because our label with long text is at top so the chart.js just cut it but we do not have any major problem in radar chart performance:

But in this case, based on our long label position, the chart face a problem like this issue:

I want to say here that this problem is not just the problem of labeling. consider below examples:

As we can see, based on our font sizes in different parts of the chart we may face lots of visualization problems. So can we have a plugging to manage any chart problems?
Obviously no! Each chart based on its form, has lots of elements and styles that we can modify them and we will get lots of performance. Not only we can change their style, but also we can assign different contents and texts to them. Also their is not any rigid definition for good appearance of a chart and it depends on our definition.
So finally I believe that we should learn fundamentals so that we can modify the chart in our own way. I provided an example to make responsive radar chart and you can expand this example for differed charts and screen boundaries.
Responsive Radar Chart Example

v3-beta.11 enabled scriptable display option: https://jsfiddle.net/aovhrygc/1/

Great use of scriptable options @kurkle


accept LE Set Extended commands in the controller

Following commands are now accepted:

hci_le_set_extended_advertising_parameters_command
hci_le_set_advertising_set_random_address_command
hci_le_set_extended_advertising_data_command
hci_le_set_extended_scan_response_data_command
hci_le_set_extended_advertising_enable_command

This should fix connection in case a BT Host uses extended advertisement commands. Seee https://github.com/google/bumble/issues/215#issuecomment-1657247432

Did you try the extended advertising support in this branch? https://github.com/google/bumble/tree/gbg/controller-extended-advertising
it should have what you need.

thanks for the info, did not know about this.


_fe_analyzer_shared issue on version 3.4.0-24.0.dev

Hitting this issue with the SDK downloaded from archive, version 3.4.0-24.0.dev, on Linux:
Bad state: Expected an int but found a DataKind.oneByteString
#0      ByteDataDeserializer._expectInt (package:_fe_analyzer_shared/src/macros/executor/serialization.dart:521:9)
#1      ByteDataDeserializer.expectInt (package:_fe_analyzer_shared/src/macros/executor/serialization.dart:477:22)
#2      DeserializerExtensions.expectRemoteInstance (package:_fe_analyzer_shared/src/macros/executor/serialization_extensions.dart:9:14)
#3      DeserializerExtensions._expectIdentifierMetadataAnnotation (package:_fe_analyzer_shared/src/macros/executor/serialization_extensions.dart:293:21)
#4      DeserializerExtensions.expectRemoteInstance (package:_fe_analyzer_shared/src/macros/executor/serialization_extensions.dart:51:28)
#5      DeserializerExtensions._expectClassDeclaration (package:_fe_analyzer_shared/src/macros/executor/serialization_extensions.dart:265:21)
#6      DeserializerExtensions.expectRemoteInstance (package:_fe_analyzer_shared/src/macros/executor/serialization_extensions.dart:28:28)
#7      RemoteInstance.deserialize (package:_fe_analyzer_shared/src/macros/executor/remote_instance.dart:46:34)
#8      new ExecutePhaseRequest.deserialize (package:_fe_analyzer_shared/src/macros/executor/protocol.dart:293:33)
#9      new ExecuteDeclarationsPhaseRequest.deserialize (package:_fe_analyzer_shared/src/macros/executor/protocol.dart:332:15)
#10     MacroExpansionClient._handleMessage.<anonymous closure> (package:_fe_analyzer_shared/src/macros/executor/client.dart:133:19)

Hitting this issue with the SDK downloaded from archive, version 3.4.0-24.0.dev, on Linux:

Most likely, this is a version mismatch issue between your running analyzer version (via analysis server presumably?) and the local version solve you have in your package. Specifically, it would be the _fe_analyzer_shared version.

You can use git or path dependencies to depend on _fe_analyzer_shared from the SDK that you are using to work around this.

We also might want to consider at what point it makes sense to get the real dependencies published here, exporting directly some dart: APIs from the SDK, which won't have this problem.

I am going to close this for now at least, but lmk if you need help setting up the git or path deps.

Still hitting the issue, my pub.lock file reads:
# Generated by pub
# See https://dart.dev/tools/pub/glossary#lockfile
packages:
  _fe_analyzer_shared:
    dependency: "direct main"
    description:
      name: _fe_analyzer_shared
      sha256: "36a321c3d2cbe01cbcb3540a87b8843846e0206df3e691fa7b23e19e78de6d49"
      url: "https://pub.dev"
    source: hosted
    version: "65.0.0"
  meta:
    dependency: transitive
    description:
      name: meta
      sha256: d584fa6707a52763a52446f02cc621b077888fb63b93bbcb1143a7be5a0c0c04
      url: "https://pub.dev"
    source: hosted
    version: "1.11.0"
sdks:
  dart: ">=3.4.0-edge <4.0.0"

This is using a downloaded SDK, or using a locally built SDK.

I don't think those packages on Pub are new enough. I'm using a pubspec.yaml with overrides that just point back at my local SDK checkout:
# Override to the latest version of the in progress api.
dependency_overrides:
  _fe_analyzer_shared:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/_fe_analyzer_shared
  _js_interop_checks:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/_js_interop_checks
  analyzer:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/analyzer
  build_integration:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/build_integration
  compiler:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/compiler
  dart2js_info:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/dart2js_info
  dart2wasm:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/dart2wasm
  dev_compiler:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/dev_compiler
  front_end:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/front_end
  frontend_server:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/frontend_server
  js_ast:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/js_ast
  js_runtime:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/js_runtime
  js_shared:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/js_shared
  kernel:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/kernel
  mmap:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/mmap
  vm:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/vm
  wasm_builder:
    path: C:/Dev/Google/dart-sdk/sdk/pkg/wasm_builder

(I took this from the example here but changed to a local SDK so it wasn't cloning another copy during pub get!)

Thanks Danny, that did it.


Saved audio is not playing in IOS

I am recording audio and on next screen playing recorded audio. It works find on android but on IOS it didn't play I am getting the following in logs:
"iOS => call startHeadlessService, playerId cd52f66d-922e-4d38-986d-bb3e242812e8"
"calling start headless service (\n "-6035574777829228503"\n)"
"iOS => call play, playerId cd52f66d-922e-4d38-986d-bb3e242812e8"
But audio didn't play. I am using the path in audio_players to play audio.

Plz use propper issue template (version, reproducable code, etc.)

Closing as stale.


New givens syntax does no logger accepts valid given defintions

Based on OpenCB failure in jphmrst/scala-automata - build logs
Affects also:

rssh/cps-async-connect - build logs

The new givens syntax and its changes to the parser no longer accept valid old (pre 3.6.0) givens syntax, in cases when type of the type-class is moved to the next line. It's a common issue that might be introduced by automatic code formatters when dealing with long names or signatures of given.
Compiler version
Last good release: 3.6.0-RC1-bin-20241003-a672e05-NIGHTLY
First bad release: 3.6.0-RC1-bin-20241005-6fa81cf-NIGHTLY
Bisect points to: 14acdc06067a202f381fa9066a961cebb1314d6a
Minimized code
trait Typeclass[T]:
  def op(v: T): Unit

given namedGivenWithLongName[T]:
  Typeclass[T] with
    override def op(v: T): Unit = ???

given otherNamedGivenWithLongName[T]:
  Typeclass[T] = new Typeclass[T]:
    override def op(v: T): Unit = ???

Output
[error] ./test2.scala:5:16
[error] end of statement expected but 'with' found
[error]   Typeclass[T] with
[error]                ^^^^
[error] ./test2.scala:4:7
[error] Not found: type namedGivenWithLongName
[error] given namedGivenWithLongName[T]:
[error]       ^^^^^^^^^^^^^^^^^^^^^^
[error] ./test2.scala:4:30
[error] Not found: type T
[error] given namedGivenWithLongName[T]:
[error]                              ^
[error] ./test2.scala:5:13
[error] Not found: type T
[error]   Typeclass[T] with
[error]             ^
[error] ./test2.scala:5:3
[error] Not found: Typeclass
[error]   Typeclass[T] with
[error]   ^^^^^^^^^

Workaround
Compile with -source:3.5
Expectation
It should compile and be parsable until deprecating the old syntax.

cc @odersky


Add image components table to ImageCVE expanded table rows

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

Current dependencies on/for this PR:

master

PR #5383

PR #5367

PR #5386

PR #5420

PR #5451

PR #5458

PR #5478   👈
PR #5474

PR #5460

This comment was auto-generated by Graphite.


Picture loading top down

Lazysizes seems to be working great sometimes,but a few times the images will be shown before loaded properly. They Load the top down style. How can I fix this? I tried with opacity 0>1 using the lazyloaded class but not working as expected.

Don't understand what you mean. Please follow our template for reporting bugs:
https://github.com/aFarkas/lazysizes/blob/gh-pages/.github/ISSUE_TEMPLATE/bug_report.md

Are you sure you aren't using interlaced images?

We had one of our EWWW IO users mention something similar, it's related to progressive JPG encoding and has nothing to do with lazysizes. Further, it probably means the OP has some massive JPG images they need to scale down.


UI: The help icon on Bulk Add IP Address doesn't work

Environment

Python version: 3.9.6
Nautobot version: 1.2.9

Steps to Reproduce

Go to IPAM --> Add a New IP Address
Select the "Bulk Create" tab
Click the blue "help" question mark icon next to the page title

Expected Behavior
The modal with help text should pop up, just like it does on the initial tab for adding individual IP addresses.

Observed Behavior
Nothing happens.

Bug in the nautobot/core/templates/generic/object_edit.html template - the help contents are only included in the rendered template if obj and settings.DOCS_ROOT, but the (?) button is included if settings.DOCS_ROOT without regard for whether an obj is provided.

Fix in #1643, however fixed alternatively in #1601.


Netlify builds show warning about browserlist config option

All PR builds show the following issue in their netlify console. Sounds like an easy fix as described by the output.

/priority important-soon
/kind bug

/area web-development

/remove-lifecycle stale


Organizing Team Wheel

Organizing Team images with their positions
English and French Support
2 Rows

For inspiration: https://hackthenorth.com/

eta on this


Mock Store State is not being updated after an action has been dispatched

Hello,
For some reason the state within my mocked store is not being updated after an action has been dispatched. I've pasted my unit test below. Any suggestion on how to proceed would be greatly appreciated.
describe('Landing Page Action Creators', () => {
    let store = mockStore({app: {kbbToken: 'MTI2MDk2NjUy'}, ymmt: YMMT_INITIAL_STATE});

    beforeEach(() => {
        // Redux Mock store - clear actions before each test to assert the new actions being dispatched
        store.clearActions();
    });

    describe('Years', () => {
        // getYears()
        it('getYears() -> Should return an array of years dating back to 1992', (done) => {

            const expectedActions = [
                {type: 'GET_YEARS_PENDING'},
                {type: 'GET_YEARS_FULFILLED', payload: LandingMockedResponses.getYears}
            ];

            return store.dispatch(LandingActions.fetchYears())
                .then(() => { // return of async actions
                    done();
                    expect(store.getActions()).to.eql(expectedActions)
                })
        });
        // ***END getYears()

        // setYear(2016)
        it('setYear(year) -> Set selected year (ymmt)', (done) => {
            let expectedActions = [
                {type: 'SET_YEAR', payload: 2016},
                { type: 'GET_MAKES_PENDING' }
            ];
            store.dispatch(LandingActions.setYear(2016));
            done();

            expect(store.getActions()).to.eql(expectedActions);
        });
        // ***END setYear(2016)
    });

    describe('Makes', () => {
        // getMakes()
        it('getMakes() -> Should return an array of makes based on the year passed in', (done) => {
            store.clearActions();

            console.log(store.getState().ymmt);

            let expectedActions = [
                {type: 'GET_MAKES_PENDING'},
                {type: 'GET_MAKES_FULFILLED', payload: LandingMockedResponses.getMakes}
            ];

            return store.dispatch(LandingActions.fetchMakes(2016))
                .then(() => { // return of async actions
                    done();
                    expect(store.getActions()).to.eql(expectedActions)
                })
        });
        // ***END getMakes()
    });

});

the same thing happens to me, am I doing anything obviously wrong? Trying to follow the example for testing api requests described here under "Async Action Creators"
const middlewares = [ thunk ]
const mockStore = configureMockStore(middlewares)

describe('Todos actions', () => {
  afterEach(() => {
    nock.cleanAll();
  });

  it('creates LOAD_TODOS', () => {
    nock('http://localhost:8080')
      .get('/v1/todos')
      .reply(200, { body: { todos: ['read book'] }})

    const expectedActions = [{
      type: types.LOAD_TODOS,
      body: { todos: ['read book'] },
    }];
    const store = mockStore({ todos: [] })

    return store.dispatch(actions.loadTodos())
      .then(() => {
        console.log(store.getActions()); // { todos: [] }, does not update
        expect(store.getActions()[0]).toEqual(expectedActions)
      })
  });
});

And the action is like this:
export function loadTodos() {
  return (dispatch, getState) => {
    const url = '/v1/todos';

    fetch(url, {
      credentials: 'same-origin'
    })
    .then(checkStatus)
    .then(res => res.json())
    .then(todos =>
      dispatch({
        type: 'LOAD_TODOS',
        payload: todos
      })
    ).catch(err =>
      dispatch({
        type: 'LOAD_ERROR',
        error: `${err} : Request failed`
      })
    );
  }
}

Any help would be appreciated!

@michael-iglesias @Ericat Could you both provide a repo with the minimum working example or a JS fiddle? It would help me to debug the issue

@arnaudbenard yes and thanks for the quick reply, I will do it asap, probably in the next few days if that's ok with you.

@Ericat No problem! The source of your problem might be that your action loadTodos doesn't return anything. Have you tried this:

export function loadTodos() {
  return (dispatch, getState) => {
    const url = '/v1/todos';

    return fetch(url, {
      credentials: 'same-origin'
    })

...

I'm having this same issue. Maybe I'm not understanding this correctly, but does mock-store actually run the actions through the reducer anywhere? I'm not seeing how they're ever connected with a setup like this:
import configureStore from 'redux-mock-store'
const mockStore = configureStore([thunk])
const store = mockStore({ ...state })
console.log(store.getState()) // => { ...state }
store.dispatch(someAction())
console.log(store.getActions()) // => [ someAction() ] The action does show up here!
console.log(store.getState()) // => { ...state } But this is the same unchanged state as above

I don't get this: why I can't see the updated state here https://github.com/damianobarbati/react-redux-test/blob/master/test.js#L49 if I add let finalState = store.getState();?
Store is always an empty object.

@adamyonk you need to use your reducer like this
store.replaceReducer(rootReducer);

@adamyonk you need to use your reducer like this
store.replaceReducer(rootReducer);

Can you explain it better?

Was the issue solved? I am having the same issue. Tried 1.5.3 and 1.5.4 versions.
  const callback = (store) => (action) => {
    console.log(action)
    store.dispatch(action)
  }

fetchRelatedFamilies()(callback(store), () => currstate)

export const fetchRelatedFamilies = () => {
  return (dispatch, getState) => {
    if (isEmpty(getState().relatedFamiliesById)) {
      dispatch({ type: REQUEST_RELATED_FAMILIES_BY_ID })
      new HttpRequestHelper('/api/related_families',
        (responseJson) => {
          dispatch({ type: RECEIVE_RELATED_FAMILIES_BY_ID, updates: responseJson.relatedFamiliesById })
        },
        e => dispatch({ type: RECEIVE_RELATED_FAMILIES_BY_ID, error: e.message, updates: {} }),
      ).get()
    }
  }
}

OR:
store.dispatch(fetchRelatedFamilies())
expect(store.getActions()).toEqual(expectedActions)

Always see only the first action but not the second. In both cases 2nd action is dispatched which I see by simply printing it out with console.log().


Declaring dependencies

One use case that is not currently addressed is declaration of dependencies. I have seen this done using Eiffel in rather home grown ways... I feel as though I haven't quite thought this through, but I'm throwing it out there. The use case is essentially this:
Not only do I need to declare the composition of my artifact, but I also want to declare its dependencies so that I can check whether a higher level composition, containing the artifact, is actually legal (i.e. containing the dependencies declared by the artifact).
The main issue I see is how to deal with version ranges here - you don't want to point to a range of versions, sort of like Maven dependencies. Or you could go convention-heavy and essentially expect semantic versioning. Or point to a specific version (i.e. event id) and expect the reader (with an understanding of one's particular versioning scheme) to make sense of the version range that should be acceptable. And speaking of Maven, we're on stepping into territory where I'm afraid we'll end up re-inventing the wheel.

This will need to be resolved in no later than drop2, as it included CompositionDefined.

I'm currently seeking feedback from a number of sources and am planning a workshop regarding this. Current thinking is that this is not so much a CompositionDefined issue, but an ArtifactCreated issue: it's not the composition's business to tell its elements what they need. The composition should, however, be useful in determining legality based on what the constituent artifacts have declared.
In summary, this boils down to a likely addition to ArtifactCreated at a later date, possibly as part of drop3.


Feature requset: creating custom variables in snippets

I would like to be able to create variables for use in snippets to get rid of code duplication.
For example, I might want to transform a file name or current date in a certain way and reuse the output in multiple places.

This is a duplicate. Unfortunately, I don't recall the exact issue number nor its title :flushed: Anyways, searching for issues with the same labels will likely help you :point_right:
https://github.com/microsoft/vscode/issues?utf8=✓&q=is%3Aopen+label%3Afeature-request+label%3Asnippets


Improve parenthesis in circuit library equations

Summary
The pull request fixes issuehttps://github.com/Qiskit/qiskit-terra/issues/7800 (#7800). I have modified the docstrings of standard_gates module to fix the parenthesis size.
Details and comments
The docstrings of some files of qiskit/circuit/library/standard_gates module were written without appropriate latex tag (\left, \right) for parenthesis (they were using default parenthesis). So, the parenthesis size was not align with other text. We can refer to https://github.com/Qiskit/qiskit-terra/issues/7800#issuecomment-1078872749 to see how modifying latex tags fixes parenthesis size.
I have edited docstrings of 13 files in the standard_gates module. Basically I adjusted the parenthesis tags to fix their size.

Thanks for the PR @saktar-unr! This looks great, I just have some two small things we could also fix:

the parameter name in the CRX docs is wrong, could you adjust that to use \theta consistently?
the equations in the U1 docs don't have a parameter at all, could you adjust that it shows U1(\lambda) instead of U1?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.72%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
53993

Relevant Lines:
64492

💛  - Coveralls

@Cryoris, Thank you! I fixed CRX gate parameter as you said. Did you meant to fix CU1 gate (https://qiskit.org/documentation/stubs/qiskit.circuit.library.CU1Gate.html#qiskit.circuit.library.CU1Gate) by adding CU1(\lambda) instead of CU1.
I could not find any parameter issue in U1 gate documentation (https://qiskit.org/documentation/stubs/qiskit.circuit.library.U1Gate.html#qiskit.circuit.library.U1Gate).

@Cryoris, Thank you very much for all the guidelines. This was my first ever issue and pull request where I learned a lot. I hope to contribute more in the future!

Great to hear @saktar-unr, we can certainly find more projects you can tackle!


Convert PascalCase widget structure into folders

PascalCase had originally been a work around for Windows users.
@itexpert120 shipped a fix to bos-workspace, which has now been merged into this repository.
Let's refactor all existing widgets into utilizing a folder structure.

This is fixed in the dev branch


Compability mode

Hello,
I'm working on generating an invoice using 'caracal'. Everything seems fine, except when it gets generated and I open it the bottom borders of the tables are not showing. Well they are showing when the zoom level is above 100%, but when I try to print them out they are not showing again..
Perhaps it somehow related to being in "compatibility mode". Because when I convert it out of compatibility mode using Word, the issue is gone.
My first thought was that is was only me, but then I tried generating tables with different templates and tried opening them on another PC.. The result was that the bottom borders were still not showing on some of the tables, but as I have mentioned, when I convert them, then everything is fine.
Any thoughts on this?

I've never seen this particular behavior, but as I'm fond of writing in these conversations, welcome to the wonderful world of OOXML. :)  Each permutation of Windows/OSX and Word seems to have its own quirks.  Out of curiosity, which OS and which version of Word are you running?
I'd be curious to know if you can resolve your issue by removing the w:compat node from the output.  You could do this either by extracting your caracal output, editing the XML, and rezipping it as a docx file; or you could fork the library, remove the Nokogiri command that adds the node to the output, and then recreate your file.
If that worked, we could maybe add a new directive to the DSL to tell the document renderer to add/ignore the w:compat node.  Caracal would render in compat mode by default, but the DSL would let you override that, if desired.


Error using cosine loss

Hi,
thanks for making this code available! I'm having an issue trying to use a cosine loss with cifar100. Using ['ce', 'cosine'] as my losses I'm running into an error on the following line:
z = nn.functional.normalize(z, dim=1)
because z is of shape [128], so dim =1 is not valid. Should it be dim=0 instead for everything here?

Hello,
The cosine option in loss_factory.py is actually not supported; it's related to an experiment that didn't make the paper, and I should probably remove it to avoid confusion. Anyhow, I don't think it will produce the results you expect, even if you change the code to dim=0.
I might be able to help if you elaborate on what is it you're trying to achieve. Are you trying to replace the cross-entropy in ANCOR with a cosine variant a la BYOL?

Hi,
Thanks for the reply! I may have misunderstood the paper/code in that case. I'm trying to replicate the paper as a starting point - my understanding from the paper is that you have a cross-entropy loss for the course classes and an InfoNCE loss for the fine classes. Is that correct? The default arguments seemed to be doing cross-entropy for both the course and fine classes, so I changed to the cosine loss to try to re-create the CE, InfoNCE scenario in the paper.
Thanks!

You are correct: Regular Cross Entropy for coarse classes, InfoNCE on the angular-normalized features for the fine classes.
In practice, InfoNCE can be implemented using Cross Entropy (see for example here), which is why the default arguments have cross entropy for both coarse and fine classes.
Also, apologies for the delayed responses. I can't seem to get push-notifications from Github to work :)

Ah, I see - I didn't realise that detail. Thanks for the response, I'll close the issue


entry-script: Apply updates for balena base images

The following features will be removed: initsystem, hostname update for 1.x devices, devtmpfs mount
Signed-off-by: Trong Nghia Nguyen<EMAIL_ADDRESS>

Connects to https://github.com/resin-io/contracts/pull/48/files


Docker Hub Publish workflow for release

As part of the release tasks migration, the steps to build and publish docker images to DockerHub will be integrated in GitHub Actions.
The new workflow builds the images based on a provided Release Candidate Branch and have the option to retag the generated images as image:release_version and image:latest.
Merge is blocked until an access token and user are added to the repository as secrets.

R:@damccorm , Could you please review this new workflow? We also kindly ask for your help on the creation of the ASF infra ticket for the Token , unfortunately the previous one created by us was closed for the following reason : Infra cannot act on tickets submitted by people unaffiliated with the Foundation.

The Go team doesn't even support versions of Go that are two versions old,
we should be on at minimum Go1.18 or simply follow the latest version, go
1.19.
The absolute lowest we should be is 1.16 which includes the ability to self
install and download newer Go versions, which we take advantage of in our
go infra for Beam.
On Tue, Oct 25, 2022, 6:50 AM Danny McCormick @.***>
wrote:

@.**** commented on this pull request.
Could you please review this new workflow? We also kindly ask for your
help on the creation of the ASF infra ticket for the Token , unfortunately
the previous one created by us was closed for the following reason : Infra
cannot act on tickets submitted by people unaffiliated with the Foundation.
Could you please link to the ticket? I assume this is asking for the
docker hub repo/token to be created?
@lostluck https://github.com/lostluck could you help with a review here
as the most recent release manager? I'm not too familiar with our container
release flow/what makes sense here.
In .github/workflows/publish_dockerhub_images.yml
https://github.com/apache/beam/pull/23814#discussion_r1004509485:

steps:

 - name: Login to Docker Hub

   uses<EMAIL_ADDRESS>

   with:

     username: ${{secrets.DOCKER_HUB_REPO}}

     password: ${{secrets.DOCKER_HUB_TOKEN}}

 - name: Setting Release Branch

   run: echo "RC_TAG=v${{env.RELEASE_VERSION}}-RC${{github.event.inputs.RC_NUM}}" >> $GITHUB_ENV

 - name: Checkout

   uses<EMAIL_ADDRESS>

   with:

     ref: ${{env.RC_TAG}}

 - name: Setup Go

   uses<EMAIL_ADDRESS>

   with:

     go-version: '^1.13.1'

This seems odd - why are we (a) starting with such a low version (b)
pinning to the minor version, vs using the standard action
https://github.com/apache/beam/blob/master/.github/actions/setup-self-hosted-action/action.yml
for grabbing our current supported versions
In .github/workflows/publish_dockerhub_images.yml
https://github.com/apache/beam/pull/23814#discussion_r1004511634:

     java-version: |

       8

       17

       11

Do we actually need all 3 versions of Java? Is there a reason they're
ordered like this (not 8, 11, 17)?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/23814#pullrequestreview-1154843030,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKDOFK2QU436FB7XBNEIGTWE7QQRANCNFSM6AAAAAARNMC5DE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Could you please link to the ticket? I assume this is asking for the docker hub repo/token to be created?

@damccorm Sure, this is the ticket I've created: INFRA ASF

It looks like we could either have the action always use the latest version of Go for building the boot scripts. This is recommended. The performance implications are minimal as go doesn't release minor or patch versions that often, and we already have downloading go as part of our gradle builds. https://github.com/actions/setup-go#check-latest-version
Getting the version from the Go Mod file is handy too but, since the boot scripts don't change often, and are part of the release, it's better for them to have been built with the most secure version of the standard libraries. https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file
I think both of these are new to the v3 version of the action however, so if INFRA poses a blocker on using v3 (they shouldn't) the previous recommendation applies.

Many thanks for the recommendation @lostluck , I've tested with Go Version 1.19 and check-latest-version option set, the workflow is working correctly, we can go with latest version.

stop reviewer notifications

(stopping the bot since @lostluck is taking this review)

LGTM. Did those required secrets get added?

Hi @lostluck , the secrets are not available in the repo yet, but we’re maintaining a conversation with @damccorm  and @byronellis   about the secrets management approach. We hope to have a resolution soon.


Adding TPR storage to the integration tests

This PR is a refactor intended to begin addressing #407. I am PRing it to enable ongoing work to the etcd-based integration tests. The refactor moves all test logic under a function parameterized by the storage type. This function returns the test function, which is then run as a sub-test for each storage type.
This PR does not turn on integration tests for TPRs, however. My goal is to merge these refactors first, then tackle the logic needed to turn on the TPR tests (it's non-trivial) in a follow-up.
TODO in a follow-up PR:

Mock out the client interface and pass it to the TPR options in integration.go

Probably using github.com/kubernetes-incubator/service-catalog/pkg/client/clientset_generated/clientset/fake

Re-enable the TPR storage type in clientset_test.go

@pmorie addresses your suggestion in https://github.com/kubernetes-incubator/service-catalog/pull/409/commits/bf19cffc5976f4023672daa8d5e747a98f9cb97b


🐞 Paired Number is earsed on computer reboot.

What happened?
Whenever I restart my PC that runs go-whatsapp-web-multidevice, I have to re-pair my phone with this server using the QR code again. I reboot my PC once every 20 hours or so.
The server is launched through a shell script that gets executed automatically from the user's .bashrc file.
Reproduction Steps
1. Pair your phone with this server as usual
2. Reboot
3.
...

Relevant log output
No response
Screenshots or Additional Context
No response
Application Version
v4.17.0
Verification

[X] I have checked for existing closed issues and discussions.

what platform that you are runnion on? docker/windows/linux?

Which system are you using? Docker, Windows, or Linux?