Tf 12500/test plan with test refactor

Ticket(s)
Required unless this is just a change to documentation.

12500

Type of change
Please delete any options that are not relevant

[x] Documentation or testing

Description
We need to enhance our testing doc giving more advices of what do and what to avoid.
We need to have a testing plan to make sure that the initial tests and future tests have some guidance of how to be implemented.
We need to refactor current tests to fit our Test Plan
Overall PR Checklist:
Please delete any options that are not relevant

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (if applicable)
[x] My changes generate no new warnings in the console
[x] There are no new linting errors/problems in my code
[x] I have added tests that prove my fix is effective or that my feature works (if applicable)
[x] I have filled out the new 3rd party dependency checklist (if applicable)
[x] I have filled this PR out fully, and cleaned up any extraneous items so that it is clear and easy to understand

@LeoFuna I added a commit with some small spelling/grammar changes. Since English is not your first language it felt kind of silly/rude to mark up this amazing PR with those kind of comments, and it was easier to just make the changes quickly myself.

@LeoFuna I love this! And I appreciate you SO very much for creating this for us before you leave.
I see one thing that may make this testing a bit difficult, but never impossible -- the information coming from Sanity IS an external dependency in my opinion. I think that the path/slug and page title (which are the same) for our pages, are the only things that are guaranteed to stay static. The content isn't necessarily getting updated constantly, but the point of using Sanity for the content is that anyone, on any team any time is able to make those changes. Completely separately from anything going on in this repository. So what happens if someone makes a change to a word or phrase in the one of the strong:visible elements, this will break. Do we need to have an extra step that has people updating content to inform developers to make changes to tests? Or should we just test the paths using only the slug or title, and then also test the other components that should be on the screen? Those things are also theoretically likely to change via Sanity, but configs and things for those are less likely than the other content I think.

@e-papanicolas I really appreciate your review and changes! thx a lot :tada:
Good point! That is something that brings out the most important questo:  "What in each page is REALLY important?"
Because as you said, if someone change some text in Sanity, those page test will break.
If the only thing important would be to have a title with a subtitle with 2 buttons, we should not test using a text, but using another way, the only situation to test using text might be when the content of this text is REALLY important.
With that said, I raise this question: Do you know if the only important data on those pages are: have a title, have subtitle, have 2 buttons etc? Or Do we have pages that have really important texts that we need to ensure that they are wrote in a exactly way?
In short, we need to test only what we think is  important.

@LeoFuna I love this! And I appreciate you SO very much for creating this for us before you leave.
I see one thing that may make this testing a bit difficult, but never impossible -- the information coming from Sanity IS an external dependency in my opinion. I think that the path/slug and page title (which are the same) for our pages, are the only things that are guaranteed to stay static. The content isn't necessarily getting updated constantly, but the point of using Sanity for the content is that anyone, on any team any time is able to make those changes. Completely separately from anything going on in this repository. So what happens if someone makes a change to a word or phrase in the one of the strong:visible elements, this will break. Do we need to have an extra step that has people updating content to inform developers to make changes to tests? Or should we just test the paths using only the slug or title, and then also test the other components that should be on the screen? Those things are also theoretically likely to change via Sanity, but configs and things for those are less likely than the other content I think.

@e-papanicolas I really appreciate your review and changes! thx a lot 🎉
Good point! That is something that brings out the most important questo: "What in each page is REALLY important?" Because as you said, if someone change some text in Sanity, those page test will break.
If the only thing important would be to have a title with a subtitle with 2 buttons, we should not test using a text, but using another way, the only situation to test using text might be when the content of this text is REALLY important.
With that said, I raise this question: Do you know if the only important data on those pages are: have a title, have subtitle, have 2 buttons etc? Or Do we have pages that have really important texts that we need to ensure that they are wrote in a exactly way?
In short, we need to test only what we think is important.

Here are all of the components for the calculator and all of the ways in which we conditionally display different pieces on the actual page. If we also look at the Sanity screens, to see that pages that are marked isQuestion, will include choices, and also will include the I don't know button, and some pages might just have "content". Some pages might not be a question and just have a "continue" single button. So I do think that we need to remove the text from the tests since that is likely to change and so it's maybe not important to test. Do any of these examples help give insight into the important data?

@LeoFuna ok yes so then to be honest I am not 100% sure what the best way to decide what is important or what to test 🫣 I'm inclined to go with whatever way you suggest.

@LeoFuna ok yes so then to be honest I am not 100% sure what the best way to decide what is important or what to test 🫣 I'm inclined to go with whatever way you suggest.

@e-papanicolas  Ok, so lets follow cypress doc and try to use data-cy and if its not possible, we use contains('text').
And for now, lets just check if things are there, trying to not be too much coupled to Sanity.
I will refactor this PR trying to do this.


Reduce package install size

Currently unbuild's install size is around 90MB which is huge. https://packagephobia.com/result?p=unbuild
And I found typescript is on dependencies.
https://github.com/unjs/unbuild/blob/e710503cda58a2691a6ed04abe91c346dae66d21/package.json#L51
typescript alone is around 60MB. https://packagephobia.com/result?p=typescript
Can we make typescript as peer dependency?

Hi. Typescript is an (optional) peer dependency now https://github.com/unjs/unbuild/commit/f31c6a4cf13d08c04b45fbf9c5651c3d93317ec2


MWPW-154135: restricted gnav personalization

MWPW-154135

personalizes:

main nav first level items (links, text, primary CTA, secondary CTA, dropdown triggers)
main nav menu separated sections
main nav menu anchors
main nav menu link group blocks

adds region condition e.g. Announcements(partner-personalization, region-northamerica, region-es)
adds getMainNavItems utility function
supports removal in hideElement function

Example personalized restricted gnav document
Before: https://stage--dme-partners--adobecom.hlx.live/channelpartners/
After: https://mwpw-154135-restricted-gnav--dme-partners--adobecom.hlx.live/channelpartners/

@richardhand seems like we should add unit test for this, right?

@zagi25 - I added sales center support in https://github.com/adobecom/dme-partners/pull/57/commits/b3f0edced03af32a54e38bfc7c9f10ebcdca08d4, if you have a chance to take a look


Add RBAC support in CSV

This commit implements StrategyDeploymentPermissions. While scanning
manifests we save Roles and fillup StrategyDeploymentPermissions during
RoleBinding scan.
Fixes #12
Signed-off-by: Dinar Valeev<EMAIL_ADDRESS>
Description of your changes

Fixes #12
I have:

[ ] Read and followed Upbound's contribution process.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Support for ABAP 702

Hi Lars,
thanks for this awesome tool, which I would love to use on a ABAP 702/SP11 system. Unfortunately the report cannot be activated because class "cl_oo_class_section_source" constructor is expected to have the following parameters, which it does not have in our release:
source
suppress_constrctr_generation

The activation error thus happens in the method update_meta
I believe it should have been working on our release a little while ago, at least if I refer to #789 , which was an SP06 system.
Any chance to get it working or am I just out of luck?
Thanks for looking into this,
Arno

hi, just comment out the contents of the method update_meta, it is part of some in-progress code #904
can you paste the parameters for the constructor?

Hi,
wow, thanks for the fast answer. It does activate now and at a first glance seems to be working fine. Thank you!
These are the parameters for the constructor:
CLSKEY          TYPE SEOCLSKEY
EXPOSURE	TYPE SEOEXPOSE
STATE	        TYPE C

All are mandatory and "pass value".
Please let me know if you need any more info.
BR,
Arno

Oops, I just closed it. Please just reopen it if you need it to keep track of this....

@gfroggy try again, latest version

sorry for the late reply, didn't have access to that system for a couple of days. Unfortunately it is not compiling:
Error

Formal parameter "IM_ALSO_LOCAL_PACKAGES" does not exist.

in the following method call:
    cl_pak_package_queries=>get_all_subpackages(
      EXPORTING
        im_package             = iv_package
        im_also_local_packages = abap_true
      IMPORTING
        et_subpackages         = lt_packages ).

thanks, above code was added recently

@gfroggy try again, latest version

closing, feel free to open a new issue


Added PostalCodeValidator by @mattt

Project URL

https://github.com/FormatterKit/PostalCodeValidator
Category

Text
Description

A validator for postal codes with support for 200+ regions
Why it should be included to awesome-ios (mandatory)
It supports a lot of locales and I personally had problems with postal code validation
Checklist

[x] Has 50 GitHub stargazers or more
[x] Only one project/change is in this pull request
[x] Isn't an archived project
[ ] Has more than one contributor
[x] Has unit tests, integration tests or UI tests
[x] Addition in chronological order (bottom of category)
[ ] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 15 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

4
302
https://triplebyte.com/a/azelHFa/d redirects tohttps://triplebyte.com/

276
301
https://github.com/analytics-pros/Swift-GA-Tracker-for-Apple-tvOS redirects tohttps://github.com/adswerve/Swift-GA-Tracker-for-Apple-tvOS

474
404
https://github.com/czater/Colorify

767
301
https://github.com/igormatyushkin014/Sensitive redirects tohttps://github.com/hellowizman/Sensitive

935
301
https://github.com/onmyway133/Anchors redirects tohttps://github.com/onmyway133/EasyAnchor

1333
404
https://github.com/jorik041/PerfectAPIClient

1382
301
http://www.catapush.com/ redirects tohttps://www.catapush.com/

1452
301
https://github.com/adrianmateoaea24/magic-mapper-swift redirects tohttps://github.com/adrianmteo/magic-mapper-swift

1532
301
https://github.com/IvanVorobei/SPPermission redirects tohttps://github.com/ivanvorobei/SPPermissions

1615
301
https://github.com/facebook/facebook-swift-sdk redirects tohttps://github.com/facebookarchive/facebook-swift-sdk

2010
301
https://github.com/Babylonpartners/DrawerKit redirects tohttps://github.com/babylonhealth/DrawerKit

2097
301
https://github.com/soheil/RadialLayer redirects tohttps://github.com/soheil-zz/RadialLayer

2138
301
https://github.com/ML-Works/Overlap redirects tohttps://github.com/MLWOS/Overlap

2548
301
https://github.com/OpenFeyn/KafkaRefresh redirects tohttps://github.com/HsiaohuiHsiang/KafkaRefresh

3251
301
http://jamesonquave.com/blog/tutorials/ redirects tohttps://jamesonquave.com/blog/tutorials/

  Generated by :no_entry_sign: Danger


How to create two CacheManager?

How to create two CacheManager and support spring auto-config cache properties?

try this
https://github.com/idreamshen/spring-boot-with-multi-redis/pull/2


checkpoint_challenge_required

I have a problem when I want to enter accounts:
2019-07-31 20:17:48,901 Instabot Started 2019-07-31 20:17:51,204 Request returns 400 error! 2019-07-31 20:17:51,206 Instagram's error message: challenge_required 2019-07-31 20:17:51,206 Error type: checkpoint_challenge_required 2019-07-31 20:17:51,206 Username or password is incorrect.

same error
instabot.log
2019-07-31 20:17:48,901 Instabot Started 2019-07-31 20:17:51,204 Request returns 400 error! 2019-07-31 20:17:51,206 Instagram's error message: challenge_required 2019-07-31 20:17:51,206 Error type: checkpoint_challenge_required 2019-07-31 20:17:51,206 Username or password is incorrect.

fixed ?
There will be released cookie saving for instabot and instabotai in a few days.


Feature Request: Tab title max length/truncation

Because I use posh-git to append the current git branch name to my terminal prompt, the titles of the tabs in Windows terminal can become very long, appearing in the format <directory><git branch> ~ <terminal program name>. Could the tab names be restricted to a fixed number of characters and some kind of truncation behavior (i.e. ellipsis) be applied?
What I would prefer is if a title that would currently show as something like this:
~\workspace\myDirName [my-current-git-branch-name] ~ PowerShell 6.0.0 64-bit (21244)
Could be truncated to some fixed character length, e.g. 50 and an ellipsis appended:
~workspacemyDirName [my-current-git-branch-name] ~...

Thanks for the suggestion! We're actually already tracking a number of requests related to the sizing of tabs in #597, which also has a PR in progress over in #3876. I'd recommend taking a look at those for more discussion.
/dup #597


Fix GCC 11 warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]

I hit this on ubuntu-22.04 arm64 with GCC11.
This was reported in the past as well https://github.com/facebookincubator/velox/pull/9578

@Yuhta can you please help review this?


Add windows binary jobs

@mthrok @vincentqb

The wheels generated on Windows are noarch. I don't know whether it will break the search process for the wheel packages on Linux/MacOS.

noarch

@seemethere Could you advise?

@mthrok I tried to make the wheel package specific both on python version and platform. But I guess it is okay without this change. I quoted the related description from PEP-425.

Sometimes there will be more than one supported built distribution for a particular version of a package. For example, a packager could release a package tagged cp33-abi3-linux_x86_64 that contains an optional C extension and the same distribution tagged py3-none-any that does not. The index of the tag in the supported tags list breaks the tie, and the package with the C extension is installed in preference to the package without because that tag appears first in the list.

@mthrok I tried to make the wheel package specific both on python version and platform. But I guess it is okay without this change. I quoted the related description from PEP-425.

Thank you for the link.
So based on my understanding of PEP-425, and looking at the job logs, the binaries built by new jobs are the following. The Windows wheel binaries have win_amd64 as part of the name, so it should not interfere with Linux binaries or macOS binaries. Conda does not have ABI as part of the name but I guess they store such info as meta data somewhere in the files uploaded altogether.
I think it's safe to merge this PR. If this does interfere with binaries for Linux or macOS, then we can tell with the nightly smoke test job tomorrow morning.
Side note:
Is 94994ecd sufficient to add ABI for Windows? We plan to revisit and add C++ implementations like https://github.com/pytorch/audio/pull/580, https://github.com/pytorch/audio/pull/290 which might be able to build on Windows. In that case, we will need to add proper ABI. (though since torchaudio does not build extension on Windows so there are many steps ahead towards that.)

(from the last line of Uploading artifacts job log)

Wheel

torchaudio-0.6.0.dev20200516-cp38-none-win_amd64.whl

Python: CPython3.8
ABI: N/A
Platform: win_amd64

torchaudio-0.6.0.dev20200515-cp38-cp38-macosx_10_9_x86_64.whl

Python: CPython3.8
ABI: CPython3.8
Platform: macosx_10_9_x86_64

torchaudio-0.6.0.dev20200516-cp38-cp38-linux_x86_64.whl

Python: CPython3.8
ABI: CPython3.8
Platform: linux_x86_64

Conda

win-64\torchaudio-0.6.0.dev20200516-py38.tar.bz2

Python: Python 3.8
ABI: N/A
Platform: win-64

osx-64/torchaudio-0.6.0.dev20200515-py38.tar.bz2

Python: Python 3.8
ABI: cpython-38-darwin
Platform: osx-64

linux-64/torchaudio-0.6.0.dev20200516-py38.tar.bz2

Python: Python 3.8
ABI: cpython-38-x86_64-linux-gnu
Platform: linux-64


Duplicate logs are created for providers like fireworks using a mapping from openai error

Several providers are using functions like map_openai_to_*_error to map openai error types to the provider's error type but this generates a duplicate entry in the log with a message attributing the error to OpenAI first. In this example I provided an invalid api key to a fireworks provider and you can see in the first message that it is an error with a fireworks variant but the error type is OpenAI client
{"timestamp":"2024-12-15T19:37:27.152133Z","level":"WARN","message":"Error from OpenAI client: {\"error\":\"unauthorized\"}","spans":[{"function_name":"haiku","variant_name":"None","name":"inference"},{"function_name":"haiku","variant_name":"accounts/fireworks/models/llama-v3p2-3b-instruct","name":"infer"},{"model_name":"accounts/fireworks/models/llama-v3p2-3b-instruct","name":"infer_model_request"}]}
{"timestamp":"2024-12-15T19:37:27.152226Z","level":"WARN","message":"Error from Fireworks client: {\"error\":\"unauthorized\"}","spans":[{"function_name":"haiku","variant_name":"None","name":"inference"},{"function_name":"haiku","variant_name":"accounts/fireworks/models/llama-v3p2-3b-instruct","name":"infer"},{"model_name":"accounts/fireworks/models/llama-v3p2-3b-instruct","name":"infer_model_request"}]}

Good issue! This is caused by the pattern of logging on error construction we adopted a few weeks ago in order to make sure the spans were attached properly. I think the fix might be to just make the client and server errors for inference providers generic, remove all the error type mapping, and be sure to attach spans that include the model name and provider type so the information is present.
I could imagine this actually reducing the amount of code in T0 by a bit which is a nice side effect. @GabrielBianconi wdyt?

Yeah! I was gonna do it soon but you're welcome to it. Can review whenever you're ready.

Closed by #572


Can't import type PointerDownOutsideEvent

This type seems needed for onPointerDownOutside methods, but it is not exported in
@radix-ui/react-dismissable-layer/dist/index.d.ts
"@radix-ui/react-dismissable-layer": "1.0.4"
I solved it by creating my own type just as it was created in the file above...

You can type onPointerDownOutside like
type ContentProps = React.ComponentProps<typeof SomeContentPrimitive>
type Props = {
  onPointerDownOutside: ContentProps['onPointerDownOutside']
}

This worked for me:
type PointerDownOutsideEvent = CustomEvent<{   originalEvent: PointerEvent; }>;


Fix parameter-less resets

If you're a hipster and use $(tput sgr0) (instead of \033[0m) then you'll get the escape sequence \033[m, which according to Wikipedia is a valid way of doing a reset:

After CSI can be zero or more parameters separated with ;. With no parameters, CSI m is treated as CSI 0 m (reset / normal), which is typical of most of the ANSI escape sequences.

We should treat \033[m the same as \033[0m

@mipearson @keithpitt any idea how to fix the parser?

The answer is in here somewhere I think! https://github.com/buildkite/terminal/blob/b1c51da3204bb3ddce907ea91774607f43a54ec2/style.go#L88

Doh. #28

This is a dup of https://github.com/buildkite/terminal/issues/28 - lolol.

Except this one is a PR with a failing test case!

More info here: https://github.com/buildkite/terminal/issues/28

I shouldn't be opening/closing PR's before I've had coffee :coffee:

Good god man, how have you NOT had coffee yet?!

The grinder and aeropres is right next to me, but grinding is a lot of work, and clicking buttons is easier :P

You have reached the voicemail of @mipearson.
@mipearson is drinking margaritas on a tropical island and cannot take your call.
Please leave your message after the intense sense of FOMO.

fixed yo.

Voicemails can code!?


[Removal]:

Hotspot Name
Eager-Flint-Ferret
Hotspot b58 Address
11DxtznXNA7zMXQqkoDuJCx55k4myYm9SAgPRbzjrhKiWnzqfTz
Discord Handle
No response
Hotspot Manufacturer
panther
Removal Reason
刚买没多久就黑名单了，我们因热爱helium花了高价钱加入生态，还没收益就黑名单了？还有没有天理？区块链的世界不要被政治和种族主义者带领！希望项目方解除，我只想回本，谢谢。
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
No response

then prove it if you are not cheating.

Keep it on the denylist. These cheaters wants ROI. Perhaps should not cheat at the first place.

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Make ingresses optional

Is your feature request related to a problem? Please describe.
I do not want to create an ingress for querier, as there's a local grafana instance that will access it in-cluster.
Describe the solution you'd like to see
A bool variable in the CRD spec that disables ingress creation.
Describe alternatives you've considered
N/A
Additional context
N/A

Ah, looks like that leaving out
HTTPIngress: {}

from the spec works, but the Operator didn't remove the ingress on CRD change.

This should have clear documentation


System should show error message when posting to view account

System should show error when posting to view account

it is already like that: https://github.com/nfco/netforce/blob/master/netforce_account/netforce_account/models/account_move.py#L147


obsolete 'lobed nucleus'

I'm trying to update GO to use cl-base (see https://github.com/geneontology/go-ontology/issues/19984). Unsatisfiabilities are fixed by the new Uberon release, but now I am running into an inferred equivalence between two 'lobed nucleus' classes.
CL lobed nucleus and GO lobed nucleus have identical logical definitions. Could CL obsolete CP:0000025 in favor of the GO term? As a side note, CP is not a registered OBO prefix (there are some GO problems like this as well); it seems like that should be addressed.

Could CL obsolete CP:0000025 in favor of the GO term?

That's exactly what we should do.
There are only a handful of CP classes. Most belong in GO.  We should find some other way to retire or move what's left.

I agree with shifting the CP classes to GO where possible, though I thought their phenotypic nature did not support that:
'acidophilic cytoplasm' http://purl.obolibrary.org/obo/CP_0000027
'banded nucleus' http://purl.obolibrary.org/obo/CP_0000039
'basophilic cytoplasm' http://purl.obolibrary.org/obo/CP_0000028
'cartwheel heterochromatin' http://purl.obolibrary.org/obo/CP_0000043
'increased nucleus size' http://purl.obolibrary.org/obo/CP_0000037
'lobed nucleus' http://purl.obolibrary.org/obo/CP_0000025
'neutrophillic cytoplasm' http://purl.obolibrary.org/obo/CP_0000000
'polychromatophilic cytoplasm' http://purl.obolibrary.org/obo/CP_0000035
'reniform nucleus' http://purl.obolibrary.org/obo/CP_0000040

They are certainly types of cellular component.  I think we should just request their addition & see what GO editors say.
The only one that definitely doesn't belong is 'increased nucleus size'  The definition  suggests it should be a PATO term.  "A nucleus size quality which is relatively high compared to the amount of cytoplasm present in the same cell."
Something ilke:
high nuclear/cytoplasmic volume ratio:  A quality inhering in a cell by virtue of the cell having a high nucleus volume to cytoplasmic volume ratio.  [https://en.wikipedia.org/wiki/NC_ratio]
@addiehl would it be possible to add some guidance in a comment about what counts as high?

Looking some more - the x-phillic terms are likely problematic for GO.  They clearly correlate with physical differences between cells, but are also tied to assays.
Perhaps we could find a way to accommodate them as cellular qualities in GO;
cellular quality
.   -  cellular histological quality: A quality inhering in a cell by virtue of its capacity to be stained by specific histological dyes.
.   .    - cellular acidophilic* histological quality:  A cellular quality inhering in a cell by virtue of its capacity to be stained by acidic dyes.  Comment: in histopathology this is commonly indicated by pale-pink staining with Wright-Giemsa stain.
@addiehl  - does that sound OK to you?
* acidophilic should not be used on its own here, as it would be confused with the term used for acid loving microbes

[ ] Request alternative terms from PATO:

'acidophilic cytoplasm' http://purl.obolibrary.org/obo/CP_0000027

'basophilic cytoplasm' http://purl.obolibrary.org/obo/CP_0000028

'increased nucleus size' http://purl.obolibrary.org/obo/CP_0000037

'neutrophillic cytoplasm' http://purl.obolibrary.org/obo/CP_0000000

'polychromatophilic cytoplasm' http://purl.obolibrary.org/obo/CP_0000035

[ ] Request terms from GO:

'banded nucleus' http://purl.obolibrary.org/obo/CP_0000039
'cartwheel heterochromatin' http://purl.obolibrary.org/obo/CP_0000043
'lobed nucleus' http://purl.obolibrary.org/obo/CP_0000025
'reniform nucleus' http://purl.obolibrary.org/obo/CP_0000040

Based on http://lymerick.net/blood-cells.pdf, I would say an N:C ratio expressed as a percentage of the cytoplasm occupied by the nucleus of 50% or higher represents a 'high nuclear/cytoplasmic volume ratio', an "increased nucleus size."  It is difficult to find a great answer as to what constitutes a high ratio, but since lymphocytes have a 50-80% N:C ratio, and are considered to have a 'high nuclear/cytoplasmic volume ratio' per our CL definition ('increased nucleus size') we can take 50% as the low end to be considered to have a high N:C ratio.

I assume you mean cellular qualities in PATO, not GO.  I think your suggested subclasses for 'cellular quality' make sense. And   I agree with your division of these potential term requests from PATO and from GO.


 tags causing issue in more localized articles

As described in https://github.com/MicrosoftDocs/windows-itpro-docs/issues/9449 there are a number of windows/client-management files which contain  tags which are not valid .md syntax.  In addition to the files in that issue we found more which are causing the translated TOCs and page layout to look crazy.  Hopefully this will be the last of them.
windows-docs-pr/windows/client-management/mdm/activesync-csp.md
windows-docs-pr/windows/client-management/mdm/alljoynmanagement-csp.md
windows-docs-pr/windows/client-management/mdm/certificatestore-csp.md
windows-docs-pr/windows/client-management/mdm/clientcertificateinstall-csp.md
windows-docs-pr/windows/client-management/mdm/cmpolicy-csp.md
windows-docs-pr/windows/client-management/mdm/cmpolicyenterprise-csp.md
windows-docs-pr/windows/client-management/mdm/customdeviceui-csp.md
windows-docs-pr/windows/client-management/mdm/defender-csp.md
windows-docs-pr/windows/client-management/mdm/devicestatus-csp.md
windows-docs-pr/windows/client-management/mdm/device-update-management.md
windows-docs-pr/windows/client-management/mdm/dmacc-csp.md
windows-docs-pr/windows/client-management/mdm/dmclient-csp.md
windows-docs-pr/windows/client-management/mdm/enterpriseapn-csp.md
windows-docs-pr/windows/client-management/mdm/enterpriseappmanagement-csp.md
windows-docs-pr/windows/client-management/mdm/enterprisedesktopappmanagement-csp.md
windows-docs-pr/windows/client-management/mdm/enterprisemodernappmanagement-csp.md
windows-docs-pr/windows/client-management/mdm/maps-csp.md
windows-docs-pr/windows/client-management/mdm/nodecache-csp.md
windows-docs-pr/windows/client-management/mdm/unifiedwritefilter-csp.md
@illfated can you please help with this one also?

Thank you for providing this list of document pages where this issue is present. Sure, I am happy to help. I just need to start it tomorrow, since it is already long past my bedtime at this hour. I am fine with changing all of them in one PR or create separate PRs for all of them, so feel free to suggest which method you prefer that I should use.
Using local source on my computer and Git Extensions to push my changes, it does not make much difference to me, so feel free to choose which solution you prefer to manage here on GitHub.

@illfated this can definitely wait until tomorrow!  I think all in one PR is probably easier but I don't have a strong preference.  Really appreciate your help with these issues!

There you go. PR #9474 is ready for review, comments, and suggestions.

Hello what is this?
On 4/29/21, Daniel Klenda @.***> wrote:

What is exactly because I didn't Subscribe to this!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/MicrosoftDocs/windows-itpro-docs/issues/9467#issuecomment-829765368

The PR is completed so we can close this now. @ghost thanks for your help


Add support for other elink versions

thanks for sharing your code,
I have tried running this on an elink R8311 but receive the following errors:

2020-04-25T04:13:59.437Z:ERROR:Application: CommandStationError: Unsupported eLink version encountered, version=105
at ELinkCommandStation.
(/home/pi/Itokawa/Itokawa/dist/devices/commandStations/elink.js:347:23)

and also this error keeps scrolling through, is this a pi configuration issue?

2020-04-25T04:14:10.896Z:ERROR:Application: Command station error
2020-04-25T04:14:10.898Z:ERROR:Application: Error: Error Resource temporarily unavailable Cannot lock port

ok errors are gone after I edited Itokawa/dist/devices/commandStations/elink.js,
and made the following change:
const SUPPORTED_VERSIONS = new Set([
0x69 // 1.05
]);
checking in the webpage it also shows as:
Version: 0.2.0
Command Station: eLink 1.05
Git Revision: e9b48864

Thanks very much for trying this out, I'll get on this tomorrow.
I'm guessing you're eLink firmware is at version 1.05 which is something I'm unable to test which is why I have the version check. Just for my own curiosity, is there a reason why you haven't updated to firmware 1.07?

For the errors, my only guess is that the older version of the firmware behaves slightly differently so some more debugging may be required if you're willing to help me run some tests?

actually there was no errors once i edited the firmware check to be the same as my version, the webpage then appears to connect to elink and send commands ok (although I do not have it hooked up to a track or trains at present).
I did not realise the firmware could be updated, is there a site somewhere to get newer firmware? (hadn't used the elink since I bought it a couple of years ago, its just sat in a box until i found the time to set it up)
happy to help run further tests if you want further dumps etc. for this version... otherwise we can look at updating it?

The firmware updates ship with the latest versions of Rail Master which can be found here:
https://www.hornby.com/uk-en/forum/hornby-railmaster/?p=1
However, if 1.05 appears to be working for you, you might be ok sticking on the current version.

I've pushed out the latest changes to enable firmware 1.05, so I'd be interested to hear how you get on.
If you intend to update using the built in update feature, you will need to undo your local changes to enable your eLink otherwise the update will fail with a merge conflict.
Thanks very much for taking the time to report the issue and investigate the fix, it's very much appreciated by me.

many thanks, updated the binaries and it successfully launches for the 1.05 elink version
Will now investigate updating the firmware to a newer version
About screen is as follows:
Version: 0.2.3
Command Station: eLink 1.05
Git Revision: 3b1b7564

many thanks, updated the binaries and it successfully launches for the 1.05 elink version
Will now investigate updating the firmware to a newer version
About screen is as follows:
Version: 0.2.3
Command Station: eLink 1.05
Git Revision: 3b1b7564


🌱 Unify provider and baremetal operator imports in the codebase

What this PR does / why we need it:
This PR extends the list of imports with aliases for CAPM3 (both v1beta1 and v1alpha5 api) and BMO in importas linter configuration in order to unify them in the whole codebase. After this change all:

capm3 v1beta1 api imports are renamed to infrav1 which looks reasonable since it is clearer for newcomers to the codebase and aligns the patterns we have for other imports, i.e for capi (clusterv1). Also, other providers, CAPA has the same configuration for aws imports
bmo/bmh imports are unified and renamed to bmov1alpha1

/test golangci-lint

/check-cla

/test-v1b1-ubuntu-integration
/test-v1b1-centos-integration

/test-v1b1-ubuntu-integration
/test-v1b1-centos-integration

/test-v1b1-ubuntu-integration
/test-v1b1-centos-integration
/test-v1b1-ubuntu-e2e
/cc @namnx228 @smoshiur1237


AUI-2037

AUI-2038 https://github.com/thiago-rocha/alloy-ui/pull/40

Just started reviewing :) :octocat: Sent from GH.

Since this code was added here we need to add test cases for it on aui-form-validator.js.

Hey @blzaugg, I added some inline comments. Can you take a look at them?

@thiago-rocha, I need to address some other, time sensitive, customer tickets like this one. Would you have time to address the source formatting and tests? I'm not going to be able get back to this one until mid next week.

No problem, I will add the sf commit, but when you have time take a look at these inline comments that I added and also so read this contributing rules http://alloyui.com/contributing/

Just started reviewing :) :octocat: Sent from GH.

https://github.com/blzaugg/alloy-ui/pull/57


Release microsoft.api management 2023 03 01 preview

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@raych1 - Please help review Go breaking change.
@qiaozha - Please help review JS breaking change.

Removing ARMSignedOff for now since it looks like there are further changes coming in after signoff.

@solankisamir please only remove the ARMCHangesRequested label once this PR is ready for ARM review to avoid multiple review iterations

  "additionalProperties": true,

additionalProperties is not allowed and boolean is only supported in 3.0:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/avoid-additional-properties.md

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json:8857 in 63be757. [](commit_id = 63be75748a2709cb4f7cf787b468b8db76038b52, deletion_comment = False)

@ms-zhenhua I have resolved the issues you raised.
For additionalproperties we will consider this for future api-versions. Can you review again?

Hi @solankisamir ,
Would you please clarify why the following issue couldn't be fixed this time?

  "additionalProperties": true,

additionalProperties is not allowed and boolean is only supported in 3.0:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/avoid-additional-properties.md
Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json:8857 in 63be757. [](commit_id = 63be757, deletion_comment = False)

Hi @solankisamir ,
Would you please clarify why the following issue couldn't be fixed this time?

  "additionalProperties": true,

additionalProperties is not allowed and boolean is only supported in 3.0:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/avoid-additional-properties.md
Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json:8857 in 63be757. [](commit_id = 63be757, deletion_comment = False)

@Mielek can you please clarify this?

Hello @ms-henglu and @solankisamir
We want to leave an open ended contract for the values of tracing. We made a conscious decision about that.
Sort explanation. Traces are tight to policy documents used in APIM. Policy documents contain policies and expressions. Policy can produce part of the traces. Expressions (customer defined scripts) can produce expressions. Every document can have different set of policies and expressions. If we would define the structure of trace then:

Every modification, improvement or addition of traces would require an update in ARM spec. We want to avoid that.
The trace structure can be much different for every policy document. it is because customer will use different set of policies, policies in different order and customer can add trace elements with unknow for us structure through expression.
It is a debug functionality. Customer, when it faces some issues in policy documents, will produce a trace. The trace will be checked manually to find any issues. We do not believe that we or customers will be making tooling around that functionality.

I hope it helps you to understand why we want to have an open ended contract here. Let me know if you have more questions around it.

Hi @solankisamir ,
Would you please clarify why the following issue couldn't be fixed this time?

  "additionalProperties": true,

additionalProperties is not allowed and boolean is only supported in 3.0:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/avoid-additional-properties.md
Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2023-03-01-preview/definitions.json:8857 in 63be757. [](commit_id = 63be757, deletion_comment = False)

@Mielek can you please clarify this?

Hello @ms-henglu and @solankisamir
We want to leave an open ended contract for the values of tracing. We made a conscious decision about that.
Shortexplanation. Traces are tight to policy documents used in APIM. Policy documents contain policies and expressions. Policies can produce part of the traces. Expressions (customer defined scripts) can produce traces. Every document can have different set of policies and expressions. If we would define the structure of trace then:

Every modification, improvement or addition of traces would require an update in ARM spec. We treat trace as an event log. We do not want to block the addition of new log entries because of api-version. We as well do not see a point in filtering traces to remove the elements  which where not present in the api-version.
The trace structure can be much different for every policy document. It happens because customer will use different set of policies, policies in different order and customer can add trace elements with unknow for us structure through expression.
It is a debug functionality. Customer, when it faces some issues in policy documents, will produce a trace. The trace will be checked manually to find any issues. We do not believe that we or customers will be making tooling around that functionality.

I hope it helps you to understand why we want to have an open ended contract here. Let me know if you have more questions around it.

Hi @Mielek ,
Thanks for the clarification, I've signed off this PR.

@raych1 - Please help review Go breaking change. @qiaozha - Please help review JS breaking change.

@raych1  @qiaozha take a look on this


Rest API

Channel REST endpoint
Includes:
List
Get
Create
Accept
Reject
Delete

"Rest API" - This ticket is really vague. Specifically what is this ticket to track?
I think it would be better to specify which object: "Group Invitation REST API" so we know what this ticket is for, and others can grab other objects without worry of stepping on each others toes.

I agree.


helm: Enrich serviceMonitor properties

Required for custom relabeling actions or istio deployments.

@jkroepke, could you please add the ArtifactHub annotation here?
https://github.com/oauth2-proxy/manifests/blob/main/helm/oauth2-proxy/Chart.yaml#L35-L41
There are some missing default values here:
https://github.com/oauth2-proxy/manifests/blob/main/helm/oauth2-proxy/values.yaml#L362-L374
Specifically:
scheme
bearerTokenFile
tlsConfig

And an unused one, targetLabels.
So please fix your PR.

Documentation should also be updated with the changes.
https://github.com/oauth2-proxy/manifests/blob/main/helm/oauth2-proxy/README.md?plain=1#L204-L209
I apologize for the fragmented review.
To speed up, I'm making suggestions while busy with other tasks.
I hope I can be of help anyway.

I hope I hit all your points

After #171, serviceMonitor is valid now.
please review.


fix fix outfile test case failure

Proposed changes
Issue Number: close #xxx
Exception:
java.lang.IllegalStateException: /tmp already exists!

run buildall


BUG - CDS 7 default export

Related Feature
Feature request: issue number
Description
Starting with version 7.0.0 of @sap/cds functions are only available under default export. This introduce issues for UI5 Language Assistance (UI5 LA) as UI5 LA is dependent on "@sap-ux/project-access".
Steps to Reproduce
Steps to reproduce the behavior:

Install latest UI5 LA
Get project as explained here and make sure CDS 7 is maintained in package.json file
Perform step 1
code completion and diagnostic is not working for meta path or context path.

Expected results
Actual results
Screenshots
If applicable, add screenshots to help explain the problem.
Version/Components/Environment
Add any other context about the problem here
OS:

[ ] Mac OS
[ ] Windows
[ ] Other

Root Cause Analysis
Problem
{describe the problem}
Fix
{describe the fix}
Why was it missed
{Some explanation why this issue might have been missed during normal development/testing cycle}
How can we avoid this
{if we don’t want to see this type of issues anymore what we should do to prevent}

Using latest project access https://github.com/SAP/ui5-language-assistant/pull/636
Issue is solved therefore closing this issue. Thanks.


Website alpha features

We should have

A nice landing page
A link to github
A link to discord?

Anything else for now?

a "get started" page, with steps on how to install and have fex-emu running.


autogen: 5.18.5 -> 5.18.6

See http://lists.gnu.org/archive/html/info-gnu/2015-09/msg00006.html for
announcement

Looks like this triggers heavy rebuilds (and causes the CI to fail due to too long build time)

Staged.

BTW, you seem to commit with e-mail not connected to your github account.

Oh, thanks for noticing the e-mail issue.

:-)


Add ability to specify/save profile with configuration file

This pull request is to try and resolve #633
This patch treats the profile like the target and the toolchain currently are; it has methods in the Program class for getting and setting from a Cfg, and is automatically saved to the config file as a default if set at the command line. Additionally, mbed config profile works as expected.
Multiple profiles are handed by allowing the value to be a list of space-separated strings.
Tests for the mbed config profile functionality are in test/profile_test.py

@lfdebrux It looks like an unrelated failure. I'm going to restart the CI.

@lfdebrux The CI failure reproduced. It's probably related then. Could you take a look?

@theotherjimmy
I'm not sure how to fix this, but I don't think it's related to this PR.
I tried running the commands from the circle.yaml file in a clean docker image. I cloned my fork from  https://github.com/lfdebrux/mbed-cli and tried the build against master, 1.4.0, and save-profile, and got the same error with each. Looking at the circle logs, builds seem to have been failing from February 18th?
The error message suggests that there are some packages missing, as far as I can see the check_requirements method normally deals with that by using pip to install missing requirements. This leads me to believe that the issue might be that the hg-test repo is using a version of mbed-os that doesn't include requirements.txt files?
Not sure where to go from here.

@lfdebrux Thanks for looking into that, and reproducing on master. @cmonr Could you take a look at this circle issue?

@theotherjimmy Sure thing. I'll see what I can find.

@lfdebrux Fyi, I'll be away starting tomorrow, and won't be back until next week. I'll see what I can find today, but can't make any promises.

I'd like @sg- take on this, i.e. having the default mbed OS profile changed through config option in mbed CLI. Previously @sg- had concerns about reproducibility for when a different user doesn't have the mbed CLI specific config.

@lfdebrux @cmonr @theotherjimmy CI is now fixed.

@screamerbg thanks for fixing the CI.
I see your point about reproducibility, I guess it would depend on the use case. It does save having to remember specifying the profile every time you run mbed compile which is a plus, but it probably isn't a good fit for my use case, where I want to make sure the project is always built with a certain profile.

@lfdebrux You could check in the .mbed file. That file contains local settings.

Also may be mbed profile could be a local only config option?

I was under the impression that mbed profile was locally configurable. Sorry I read the code wrong.

@lfdebrux From technical standpoint, this is a really good PR. Thanks for walking the extra mile!

@screamerbg thanks.
@theotherjimmy @screamerbg in the PR as-is, profile can be configured locally or globally. So yeah actually I could just commit the project .mbed file. I'm not sure whether being able to configure the profile globally is a good thing, I put it in because I wanted the functionality to be similar to config target and config toolchain, but I could take it out if having that feature is a bad idea.

I think it would be best to have locally-configured profiles only. @screamerbg, It looks like you're of the same mind from the comment history.
@lfdebrux Could you remove the ability for a user to configure a build profile globally?

Sorry for the delay in sorting out the local-only profile, I was on holiday.
I fixed it in the simplest way I could think of, I've added tests to check the functionality but it seems to do the job.

@lfdebrux Thanks for this. Can I please ask you to:

fix the issues after the rebase, e.g. the Files Changed tab shows changes in 7 files, including version changes (from 1.4.0 to 1.5.0) etc.
remove the verb "mbed profile" for now and leave profile as a config option through mbed config. We'd like to revisit the current convention for mbed verbs (mbed <something>) between config options and actual functionality. There's an argument that if target, toolchain and profile are used, then we should introduce every config option as verb and as we don't have a position on this at the moment, I'd like to unblock this PR by providing the actual config functionality.

I hope that this makes sense and apologies for the delay for accepting this PR.

@lfdebrux if you're still interested in this feature, but no longer have time to contribute, we can pick this up for you. Would you like this feature?


[Refactoring] Regenerate Classes from rdf/shacl

There were some updates in the schema. They go beyond our request and recur to the spelling as it was in V3RC02. When generating the new classes, this will break our serializers (i.e. semanticId instead of semanticID). That's not necessarily a problem, it will however require to adapt and see if the public API will change.

[ ] Regenerate classes
[ ] Adjust serializers

Assigning myself for Regenerate classes.


Convert svg to dxf

Hi,
Anyone help how to convert svg to dxf
it's urgent

Hi Usama, can you tell me what types of SVG elements are in your document? Maker.js deals primarily with path data. See https://maker.js.org/docs/importing/#content for import techniques. You would need to traverse your SVG document and import each element accordingly.

Hi @danmarshall  thanks for your response i am use like this
maker.exporter.toDXF('./a.svg',{usePOLYLINE:true,units:'dxf'})

Hi Usama, do you need to do this for only one SVG document, or do you need a script that works for a multitude of documents?
If you only need one document, I would simply use Inkscape, which has a GUI that can export to DXF for you.
If you are looking at creating a script that will process many SVG documents, you will need more consideration of the system you need to build.
Maker.js is a low level library that only works with model objects. You can create model objects by importing SVG path data or points. Once you have a model, you can then export the model to DXF.
Maker.js will run in both Node.js and web browsers, each of these might have their own way of handling SVG files. So it would also help to know your environment.

Hi Usama, how many documents do you need to convert?

only one

For just one document, it will probably be easiest if you install Inkscape. It is not a library, it is a desktop app that you can install on Windows or Mac. No coding required, it's a GUI app. It should work for you, it is an extremely popular app! 😃👍

I have svg like this

and i want to convert this into dxf

Are you in Node.js or a browser environment?

Here is a basic minimum example:
<svg width="100" height="100">
    <circle cx="50" cy="50" r="40" stroke="green" stroke-width="4" fill="yellow" />
</svg>

From here you will have to make some choices, based on your requirements. There's a few things to consider:

DXF does not have "fill" - so the yellow data is lost.
stroke-width is not supported in Maker.js. Do you want a ring instead of a circle?

no need this svg just example
but svg look like this

Remember that Maker.js is primarily line drawing. So you will not be able to convert every type of SVG element, such as images. Also remember that text is also treated as outlines in Maker.js, and that you will need to download a font - see the documentation on fonts and text.
Pretty much the elements you'll need to add code for are circle, ellipse, rect, polygon, and path. See the documentation on importing, noting that the y-coordinates in SVG are opposite in Maker.js.
Finally, you'll need to consider if you want to support SVG's transform attribute, which introduces additional math on each type of shape.

Closing this issue for now, please reopen if there is anything else.


Checkbox

Current coverage is 45.74%

Merging #197 into master will not affect coverage as of 0b4956d

@@            master    #197   diff @@
======================================
  Files           21      21
  Stmts          341     341
  Branches         0       0
  Methods          0       0
======================================
  Hit            156     156
  Partial          0       0
  Missed         185     185

Review entire Coverage Diff as of 0b4956d

Powered by Codecov. Updated on successful CI builds.


Only black canvas

I tried the various downloads for this model , Three.js works fine but the React-three-fiber starter projects renders black without model and gives me an console error 'GLTFLoader.js:149 RangeError: Invalid typed array length: 4 at new Uint8Array () at GLTFLoader.parse (GLTFLoader.js:254) at Object.onLoad (GLTFLoader.js:169) at XMLHttpRequest. (three.module.js:34742)'
Status is 200 for the model but as I said it only renders a black window, how can this be resolved?

So it seems to be a fault in the 3d model. It does not go through validation from Krohnos , the project setup works fine when changing the model to a validated gltf..


Added quotes around the Package namespace

Tiny change to fix the namespace declaration so you can just copy and paste.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Can I use this image in my game for commercial use?

I am making a tiny game with my son.
I need person image.
Can I use this image in my game for commercial use?

Yes you could :)


Support string for destination property

The old CLI expects string on destination if the target is not raw, let's support that style as well.

Wouldn't it be better to fix the migration here? Save people some time by letting them know early that there's a problem.

Wouldn't it be better to fix the migration here? Save people some time by letting them know early that there's a problem.

I thought both styles are acceptable, don't you think?

So this is to let people use destination: "assets when they're not using RAW, right? Is it at least possible to still use the enum here, so the manifest fails if the string is wrong?

So this is to let people use destination: "assets when they're not using RAW, right? Is it at least possible to still use the enum here, so the manifest fails if the string is wrong?

this makes total sense, will change it!


Remove extern crate statements from the repo

TiKV is on Rust 2018 now. That means that for the most part extern crate isn't needed. Remove all that you can.
Resources:

Edition Guide - No more extern crate
Edition Guide - Macro changes

Note that the code in the fuzz directory is still on 2015, so don't change anything there.

Let me give this a try.
Tanks

It's all yours @wujunze !

OK  @brson

@wujunze Are you still working on this? If not, I will start.

I am doing   Thanks

This task looks very interesting and you are welcome to complete it together @ICEYSELF
https://github.com/tikv/tikv/pull/4297

Looks like this is fixed.


Review and Test all visible focus related tickets potentially fixed with GH-6052

We have over 20 tickets related to visible focus issues that might have been fixed when merging GH-6052.

Add specific browser screenshot to ticket.
Add theme-calydon label to all tickets needing calydon to be active.
Add fixed in GH-6052 reference
Add link to testing instructions if it's a Safari bug

33 tickets reviewed and tested.
This was a task control ticket, nothing to QA for this one specifically.


chore(deps): update dependency dagger/dagger-for-github to v7.0.2

This PR contains the following updates:

Package
Update
Change

dagger/dagger-for-github
patch
v7.0.1 -> v7.0.2

Release Notes

dagger/dagger-for-github (dagger/dagger-for-github)
v7.0.2
Compare Source
What's Changed

chore: bump default dagger version to v0.15.0 by @jedevc in https://github.com/dagger/dagger-for-github/pull/165

Full Changelog: https://github.com/dagger/dagger-for-github/compare/v7...v7.0.2

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


fix list index out of range bug when using byte_count with overlap = Y

fix support  for aes64ks1i using byte_count with variables=['rs1_val', 'imm_val']
Using byte_count with variables=['rs1_val','rs2_val','imm_val'] and overlap = "Y" will trigger "list index out of range" exception.

@liweiwei90 Thanks for this fix. I will need you to make an entry in the CHANGELOG.md file and bump the tool version as mentioned in the contributing guideline here. Also I would suggest you rebase on the current master to avoid conflicts in the CHANGELOG.md.
Thanks.

@neelgala Thanks for your review. Despite this problem I found in arch tests of aes64ks1. I also found a problem in the current arch tests for other instructions of K extension: when the x0 register is selected, the generated data by byte_count will be ignored (set to zero). This will affect the coverage of S-boxes. Do we have any way to avoid using x0 in byte_count related test cases while x0 can be used in other cases?

@neelgala Thanks for your review. Despite this problem I found in arch tests of aes64ks1. I also found a problem in the current arch tests for other instructions of K extension: when the x0 register is selected, the generated data by byte_count will be ignored (set to zero). This will affect the coverage of S-boxes. Do we have any way to avoid using x0 in byte_count related test cases while x0 can be used in other cases?

@liweiwei90 All the tests have been generated keeping this in mind and usually when x0 is used, another instance of the macro is written out where the register is not x0. Could you point us to the test where this problem exists?

@neelgala Thanks for your review. Despite this problem I found in arch tests of aes64ks1. I also found a problem in the current arch tests for other instructions of K extension: when the x0 register is selected, the generated data by byte_count will be ignored (set to zero). This will affect the coverage of S-boxes. Do we have any way to avoid using x0 in byte_count related test cases while x0 can be used in other cases?

@liweiwei90 All the tests have been generated keeping this in mind and usually when x0 is used, another instance of the macro is written out where the register is not x0. Could you point us to the test where this problem exists?

Sorry, I didn't check the whole test carefully. I do find another instance at the end of the test.


Invoking wp i18n make-pot fails when Xdebug is enabled

In VVV after having done xdebug_on and run:
wp i18n make-pot . languages/amp-js.pot --include="*.js"

I get an error:
PHP Fatal error:  Maximum function nesting level of '100' reached, aborting! in phar:///usr/local/bin/wp/vendor/mck89/peast/lib/Peast/Syntax/Scanner.php on line 972

If I do xdebug_off then it succeeds.
The plugin context here is AMP.

@westonruter This is a limitation to recursion that xdebug sets into place, regular PHP without an extension doesn't have such a limit.
This limit is normally set to 256. In your case it is 100, because you are using an older version of xdebug as well (< 2.3).
You can set this limit manually using the xdebug.max_nesting_level setting.
I don't see how we could get around this from within WP-CLI, but we might want to add this to our list of common issues.

I was working with Docker so I had to change two settings to be able to run the command within my container. But the command works fine if I run it directly from my machine.
memory_limit = 512M
xdebug.max_nesting_level = 512

I hope it helps someone.

Running this on CircleCI also throws the Maximum function nesting level error.
The following will disable xdebug in a CircleCI job:
- run:
    name: Disable xdebug PHP extension
    command: sudo rm /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini

I just stumbled over this thread and solved it in that way:
$ php -n -dextension=phar.so -dextension=json.so -dextension=mbstring.so $(which wp) i18n make-pot [...]

I use php bin to execute wp bin so I can pass additional parameters like -n which disables all extension (see this). With dextension I can enable all extensions needed for i18n make-pot.
This also brings a huge performance improvement, here a benchmark of my WSL Ubuntu machine:
With the previous mentioned solution of @schlessera and @brenoalvs it takes about 41.42s:
$ php -d xdebug.max_nesting_level=512 $(which wp) i18n make-pot [...]
Success: POT file successfully generated!
Done in 41.42s.

And with all extensions disabled expect required ones it takes 4.42s!!
$ php -n -dextension=phar.so -dextension=json.so -dextension=mbstring.so $(which wp) i18n make-pot [...]
Success: POT file successfully generated!
Done in 4.42s.


Ask : Tensorboard without fit function ?

Hello,
I was wondering if it is possible to use tensor board if we use forward/backward/update function instead of fit function? I did not find an example about it.

@Shiro-mx check this https://github.com/dmlc/tensorboard/tree/master/tests/python

@zihaolucky  thank for the help that's what I needed. I will try it.

@Shiro-mx :)

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.


try to remove or change long running read actions in some discovery utils

effects the following scenarios:
1- Intellij did indexing but the user won't be able to update the editor
2- While document change
There are still long running read actions in the following classes.
usually these run only on startup or when documents change or on bulk document change. they may hold read action for long time and may cause a freeze.
one possible way to fix is to take read access only when necessary.
or to run with write action priority and retry until success.
JavaSpanNavigationProvider
JavaEndpointNavigationProvider
DocumentsChangeListenerForJavaSpanNavigation
PythonSpanNavigationProvider
DocumentsChangeListenerForPythonSpanNavigation

see
https://github.com/digma-ai/digma-intellij-plugin/issues/1244

also fixes issue
https://github.com/digma-ai/digma-intellij-plugin/issues/1244


feat: Add GitHub Sponsor button

Closes #81
Description of the changes
Add GitHub sponsor links in footer and main page header, and create a specific section in team page.
Checklist

[x] I didn't over-scope my PR
[x] My PR title matches the commit convention
[x] I did not include breaking changes
[x] I made my own code-review before requesting one

I included unit tests that cover my changes

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

I added/updated the documentation about my changes

[ ] 📜 README.md
[ ] 📕 docs/*.md
[ ] 📓 docs.lenra.io
[x] 🙅 no documentation needed

Validated by Aliénor

:tada: This PR is included in version 1.1.0-beta.9 :tada:
The release is available on:

GitHub release
v1.1.0-beta.9

Your semantic-release bot :package::rocket:


Process to print the case

Please, could you explain the process to print the case? I uploaded  the files to sculpteo
yampad_v2-Eco2.User-screws.dxf
yampad_v2-Edge.Cuts.dxf

But I'm not sure how to proceed. I must print both files?
(I'm on linux so I don't have autocad to open the other 2 files)
Thank you.

Ok after tweaking with fussion (web), I can see there are 2 versions:
V2: Made of 4 pieces.
V3: Made of 2 pieces (wooden base and steel top plate)
Could you please upload the pieces invidivially in .dxf, so I can order them, or know a linux program I can use to do it myself? Thank you.

Ok got it,
Backplate: "yampad_v2-Edge.Cuts.dxf"
Top plate: "yampad_v2-Eco2.User-screws.dxf" -> But you must edit it on freecad before to send it for printing, to eliminate the arduino placeholder.

Hi,
the .dxf are the outlines of the PCB and are there to help with the process of designing a new case for the Yampad. They can't be printed as is.
If you want a case you can start from the .f3d files which can be edited in Fusion360. Keep in mind that those two projects were thought to be CNC'd and not 3d printed though.

Do you have any file dxf file with holes for stabilizers? I'm designing a case in steel, but I'm having a bad time with that. Cheers.

This is still WIP but I'm designing a new cover in metal. Might post a pull request in the future when I have it in my hands.
test.zip
Pretty excited, I just received my PCBs

Do you have any dxf file with holes for stabilizers? I'm designing a case in steel, but I'm having a bad time with that. Cheers.

@Zeioth You should be able to extract that file from the Kicad project file by selecting the correct layer. I'll try and extract it for you but I have very little free time lately.

Thanks! Don't worry I managed to do it, I'm already making sure everything is correct before to send it for printing.


[e2e] allocs-l1.json does not exist, skipping genesis generation on e2e test

The following log line appeared on my machine during e2e testing, which I believe is new:
file /home/colin/nm/polymerdao/monomer/.devnet/allocs-l1.json does not exist, skipping genesis generation

It is also happening on CI:
https://github.com/polymerdao/monomer/actions/runs/10822155982/job/30025536688#step:6:6
The error comes from optimism.op-e2e.config.init() - the init function of the config package, and it causes an early exit from this init. The init() seems to make an assumption about the running directory of whatever process invokes it, but this assumption is not true in our e2e test.
It's not clear to me if we ever use the op-e2e.config package, but something must, in order to invoke the init() function.

This started occurring on https://github.com/polymerdao/monomer/actions/runs/10798980035, associated with PR https://github.com/polymerdao/monomer/pull/196/files.
probably has to do with the introduction of the e2eutils package in op_stack.go, but this is a bit of a guess.
The error string itself is mildly annoying, but it's a little odd that something is

initiating the config package and relying on it somehow
doesn't seem to mind that the init exits early

Possible wontfix here, just wanted to flag.

One potential solution is just moving the e2e/optimism/.devnet directory to the monomer root, that may resolve the error message


Update README.md

Added section in for RAI and Security guidance.

Manually added change to readme page.

Closing because a new PR is submitted instead.


Create tree-like view of images

When building images with Dockerfiles one has a clear view of the parent image one is building it on (FROM foo). This image foo might be built from another image bar etc. One might not be the owner of all these images, some of them can be private and some official. Is there a way to get a clear view of this dependency? We are looking for a way to create a graph view like dockviz does (which doesn't work for me right now). It uses the Parent property of an image which seems to be empty with the changes from 1.10 or 1.11, not sure. Getting a view of the images is an important exercise to look for improvements in the way one builds docker images. It would be beneficial to have this information available, regardless of whether the image(s) are private or public.

Closing as a dup of #17366
Thanks!


(1.6.0) Array methods return undefined

Version: 1.6.0
SIMPLE Reproduction:

draft.items.find(({ id }) => id === extraId);

Expected behavior: return the item of the array if it exists
Actual behavior: return undefined

Given that the above doesn't give any insight in what extraId is, or doesn't exclude that the bug is somewhere else (typo, etc etc), please create a small, runnable, reproduction in codesandbox or as PR with unit test on this repo. (Tip: use gitpod).

I just ran into an issue with Arrays had to downgrade to 1.5.0 to get around it. Not sure if it's quite the same as this, but using a forEach with draft state (a proxy) in an NGXS app would cause a stack overflow error. Attempting to access an element of the draft state array would result in an undefined, so something is up with Arrays in 1.6.0.
I can hopefully put together a simple repro case this week.

@cwayfinder  As shown in above commit, the find method works as expected. So please provide a reproduction or close this issue.

I should have mentioned in my comment, and it may be related to the original comment in this issue, but this only came up when building my entire app for production (ng build --prod). It did not happen in Dev mode.

@lotz that sounds like a different issue. If the problem persists please create a new issue including reproducible reproduction.

Thanks @mweststrate. Just opened https://github.com/mweststrate/immer/issues/198 with repro steps and example code.

Closing for a lack of reproduction. #198 has been solved in the mean time, so upgrading to 1.7.2 might fix the issue, if the cause is related


Fix: Send reminder modal ui and options UI

Designs

Send Reminder Modal
Options on invoice details page

Description

Fixed send reminder modal UI for the labels.
Fixed the overlapping issue where when the options were opened it had text overlapping it.

Preview
Before -

After -

@mayankagnihotri7 Few fixes are required here

Remove the '{}' from the "Send Invoice" heading.
Email  & Message label is not similar to designs.
Email value background should have more margin from the bottom of the box
Subject label text is small

@mayankagnihotri7 Can we close the menu after the modal is opened?

@apoorv1316 Yes. We can close the modal using the esc key.

@mayankagnihotri7 We are able to type in the email field and add other emails. I don't think we are now allowing that. Please fix it

@apoorv1316 I've made the requested changes. Please review.

@mayankagnihotri7 We can still type emails on the mobile screens. Please fix it

@apoorv1316 I've made the requested changes. Please review.

@prasanthchaduvula Please review.


API Connector

Development in Progress
JP needs this ASAP
Documentation here - https://quality-assurance-dao.gitbook.io/training-and-automation/circle-automation/api-connector
[ ] Resolve issues with API connector

[ ] Andre drafted a Google script alternative.
[ ] JP is going to use dework for Catalyst Circle Action items


[BUG] Harvester didn't prevent user from creating VM with extra large volume size exceed overcommit-config setting

Describe the bug

Currently Harvester can't prevent user from creating VM with volume larger than the actual storage size with overcommit-config setting.
When user did not pay attention to the actual storage size and create volume larger than overcommit setting, the VM would not be able to operate correctly but the volume display with attached.

Storage size of node (115GB)

Default resource overcommit-config (Storage: 200%)

Create VM with volume size greatly larger than actual storage size (5000GB)

The extra large volume can still be created and attach to VM

But actually the VM can't be started with Failed to Attach Volume error

To Reproduce
Steps to reproduce the behavior:

Check the storage size on Host page
Check the overcommit-config of storage size in settings
Create a VM, set the volume greatly larger than the actual storage * overcommit-config size
Check the volume status
Check the VM status

Expected behavior

We should have a manner to prevent user from creating volume larger than the overcommit-config
Support bundle

supportbundle_280adef0-9fb7-4d52-9a79-cf8abb7ffdb6_2022-09-05T08-35-54Z.zip
Environment

Harvester ISO version: v1.0.3 master-caada0e6-head (09/05)
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): One node Harvester on local kvm machine

Related: https://github.com/harvester/harvester/issues/1931


Poster for mini hackathon in college

Can you remove the name of your institute for the poster and then appear for another pull request

Also, I am forwarding it for further review and merging,
Assigning the rest work to @PrinceX04


Unity Example

Greetings , am trying to move the cube from the example on unity but it keep telling me that unity cannot build a server on 8500 port .
I just wanna move the cube on unity would you please kindly help me .

@Doody02 . can you use other port number? seem, 8500 is used by other app or not closed from old one.

Already did , still same problem

@Doody02 .
you missed steps of running BCI app with OSC feature.
you can see steps in: https://www.youtube.com/watch?v=bWdHdnQbby4
and document: https://github.com/Emotiv/opensoundcontrol/tree/master/examples/Unity


Issue with query on RETS/1.7.2

I'm trying to do a simple query but I keep getting an error thrown.
client.search.query("Property", "ALL", "(County=|10000005773)", {limit:25, offset:1})
ERROR: issue encountered: RetsReplyError: RETS Server replied with an error code - ReplyCode 20203 (MISC_SEARCH_ERROR); ReplyText: Illegal RestrictedIndicator character, values are a..z, A..Z, 0..9
Just wondering if I am doing something wrong.

Oh and even if I remove the | in the query it still gives the same error.

Huh, well that's weird.  The arbitrary restrictions MLSs choose to impose never cease to surprise me.
Try adding the option: restrictedIndicator: 'RESTRICTED' and see if that does it.  The default we use in this library is ***, but apparently your MLS doesn't allow that.

That worked, thanks!


Fix: Validate headless and host options

Fixes #2575
Based on the discussion in #2610, validates the --headless and --host options.

If --headless is passed, then --host is required
If --host value doesn't include protocol, an error message is printed
Updated all tests that had --headless without --host
Added tests for the new error messages

These changes are only for the CLI. I'll make a separate PR for the webui.
If there's a better approach or anything to improve, I'm happy to.

If --headless is passed, then --host is required

--host should not be required, because it can also be set on the User class.

what if it is not an http test at all?

Then this is trickier. We could have a list of supported protocols (e.g. http, https, ftp, ssh, irc, etc.) but that might be too limiting? We could check that :// is in the host but I'm not sure all protocols specify a :// syntax. Maybe things are fine as is?

I updated the PR with one more approach. It uses urllib's urlparse to check that the parsed host has a scheme value. Just another option. If there are any issues with this, let me know :)

what if it is not an http test at all?

Then this is trickier. We could have a list of supported protocols (e.g. http, https, ftp, ssh, irc, etc.) but that might be too limiting? We could check that :// is in the host but I'm not sure all protocols specify a :// syntax. Maybe things are fine as is?

I wouldnt necessarily call it "fine", but the current design makes it really hard to fix :-/
I wonder... Perhaps HttpUser could validate its host attribute on initialization and stop the test if it is not a valid prefix? (probably we should allow None, but that is not the key issue) Or maybe throwing an exception is enough to stop the user from being spawned. I dont really have time to explore how feasible that would be, but that way different Users can use different schemes.


Allow stubs to not force to use App namespace as users can change this namespace

See https://github.com/acacha/adminlte-laravel/issues/109

Files:

https://github.com/InfyOmLabs/laravel-generator/blob/develop/templates/home_controller.stub

https://github.com/InfyOmLabs/laravel-generator/blob/0f9e75d65538a87cfad684938713e81f62bca739/src/Commands/Publish/LayoutPublishCommand.php

https://github.com/InfyOmLabs/laravel-generator/blob/0f9e75d65538a87cfad684938713e81f62bca739/src/Commands/Publish/LayoutPublishCommand.php


[Python] Support reading (compressed) CSV file from remote file / binary blob

From https://stackoverflow.com/questions/64588076/how-can-i-read-a-csv-gz-file-with-pyarrow-from-a-file-object
Currently pyarrow.csv.rad_csv happily takes a path to a compressed file and automatically decompresses it, but AFAIK this only works for local paths.
It would be nice to in general support reading CSV from remote files (with URI / specifying a filesystem), and in that case also support compression.
In addition we could also read a compressed file from a BytesIO / file-like object, but not sure we want that (as it would required a keyword to indicate the used compression).
Reporter: Joris Van den Bossche / @jorisvandenbossche
Note: This issue was originally created as ARROW-10425. Please see the migration documentation for further details.

Another example is when one has a large zip-file containing multiple .csv.gz archives. It would be nice to have a compression option in read_csv or in pyarrow.csv.ReadOptions, since pyarrow's gzip-decoding seems quite a bit faster than the one provided by python's standard library.
with ZipFile("huge_archive.zip", "r") as archive:
    with archive.open("table.csv.gz") as compressed_file:
        with gzip.open(compressed_file) as file:
            da = pa.csv.read_csv(file)

vs
with ZipFile("huge_archive.zip", "r") as archive:
    with archive.open("table.csv.gz") as compressed_file:
        read_options=pa.csv.ReadOptions(compression="gzip")
        da = pa.csv.read_csv(compressed_file, read_options=read_options)

or even
with ZipFile("huge_archive.zip", "r") as archive:
    with archive.open("table.csv.gz") as compressed_file:
        da = pa.csv.read_csv(compressed_file, compression="gzip")

Faster, more readable, less extra imports.


added a few Dart and Flutter online courses

What does this PR do?
Add resource(s)
For resources
Description
Add a few Dart and Flutter online courses from YouTube
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
It's a course.
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

it is recommended to avoid emoji for uniform reading

There wasn't mention of this anywhere in the contributing guidelines. So hope you'll include that in the docs so that others can know about this.

https://github.com/EbookFoundation/free-programming-books/blob/main/docs/CONTRIBUTING.md#in-a-nutshell
Here on the number 5

GitHub Actions will run tests to make sure your lists are alphabetized and formatting rules are followed. Be sure to check that your changes pass the tests.

It wasn't clear and that's why I made a mistake. Also, I saw others make the same mistake.
How It's alphabetized?
Is it only with the first letter of a word?
Or is it with each and every word?
So hope you'll include more specific guides on this.

I will edit the CONTRIBUTING file by adding these things.


Browser support

Hello,
Is it possible to use this library in a web browser?

Hello,
This library is designed to work on the server side, specifically Node.js (for example, in an API). To use the library directly from the client side, changes must be made.

I see, thanks for the answer!)

Oh, that's an awesome piece of news!) Thank you so much!)


Eliminate console.log messages during testing

Previously, when tests were run, you would see messages like:
"%c prev state color: #9E9E9E; font-weight: bold [object Object]"
This was caused by the redux.js logging tools. By default the
combination of cucumber, Capybara, Poltergeist and PhantomJS write
JavaScript console.log messages to standard out. This change configures
that logging to go to a file in the log directory.
Make sure you have checked off the following before you issue your Pull Request:

N/A Added unit tests for new functionality
[x] Passed all unit tests using rails test with 90%+ coverage
N/A Added cucumber tests for any new functionality
[x] Passed all cucumber tests using bundle exec cucumber
[x] Passed overcommit hooks, including running all code through Rubocop
N/A If any database changes were made, run rake generate_erd to update the README.md
N/A If any changes were made to config/routes.rb run rake jsroutes:generate

I'm seeing some weird behaviour on my end with this branch, and it may just be on my end since the cluster tests have passed.
When I run the full set of cucumber tests I am consistently seeing them crash on this scenario:
Failing Scenarios:
cucumber features/manage_forms.feature:20 # Scenario: Revise Form

40 scenarios (1 failed, 39 passed)
369 steps (1 failed, 6 skipped, 362 passed)
1m44.248s

with this error:
PhantomJS has crashed. Please read the bug reporting guide at
<http://phantomjs.org/bug-reporting.html> and file a bug report.
    And I click on the button to add the Question "What is your gender?"            # features/step_definitions/form_steps.rb:9
      PhantomJS client died while processing {"id":"0c2618f0-f693-48b3-815d-4e828ca408c2","name":"trigger","args":[2,1,"click"]} (Capybara::Poltergeist::DeadClient)
      ./features/step_definitions/form_steps.rb:11:in `/^I click on the button to add the Question "([^"]*)"$/'
      features/manage_forms.feature:28:in `And I click on the button to add the Question "What is your gender?"'

However if I just run bundle exec cucumber features/manage_forms.feature:20 it runs with no problem every time. Not sure if this is a machine problem or if there is some inconsistency that should be addressed but not merging until I figure out the cause.


Efficiency Measurement

Another small thing that could be useful is to show how much RF you get per mB.
The equation is really simple. It's just the RF-production divided with the Fuel Consumption.
RF/mB is the key factor when you go for maximum efficiency.
Another thing this could be used for is an automatic mode where it goes for maximum efficiency.
it would take some time before the computer finds the correct Rodlevel.
The optimal Core Temperatur for a passive cooled reactor is 900 C and it seems that the optimal Core Temperature for a active cooled reactor is 600 C.

That's a good idea. I'll look into it.

After fooling around with turbines, i think Efficiency meter should be used with reactor-only mode.
there are many factors of getting efficiency by using turbines.

I'm looking into it.

Since i'm still new to Lua, this seems like an easy thing to do.
So i will give this a go, in the next couple of days.

Updated! commit 1c8038503837f83a7e973415f33bf9697fd4e78b


Date Range Picker Validation event does not fire

Bug type
Component
Component name
MudDateRangePicker
What happened?
When using the MudDateRangePicker the method tied to the Validation attribute of the control never fires when the dates are selected manually or when the dates are entered manually.
Expected behavior
The Validation method is called any time the control value changes and validation message(s) are shown
Reproduction link
https://try.mudblazor.com/snippet/caQxkJvsKmAfALTv
Reproduction steps

Create a Date Picker Control with Editable="true" and Validation="fx"
Enter 05/01/2023 in the first date
Enter 04/01/2023 in the second date
Tab out of the control

Relevant log output
No response
Version (bug)
6.1.7, 6.2.5
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Chrome, Safari
On what operating system are you experiencing the issue?
Windows, Mac OSX
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Internally MudDateRangePicker inherits from MudBaseDatePicker which is a Picker whose type is DateTime?, so for validation to work it needs to be passed a function where T is DateTime? in this list:

You can sorta make this work by cheating a little (the internal Value of the DateRangePicker is set to the End date of the DateRange):
private string? ValidateDatePicker(DateTime? endDate)

Here's a working code snippet: https://try.mudblazor.com/snippet/cOcHEpGtRqeGpmlt
Fixing this in MudBlazor would require a solid refactor of both date picker components I believe.


How can I close a dynamoose instance?

Summary:
we are setting up some automated tests with dynalite and dynamoose and are hitting a show-stopper: after the test execution a process keeps running.
If we just start/stop the dynalite instance (without any interaction with dynamoose) there are no running processes left. Some process keeps running as soon as there is an interaction with dynamoose.
Code sample:
Schema
// Code here

see below
Model
// Code here

see below
General
// dynamooseHelper.js
const dynamoose = require('dynamoose');
const dynalite = require('dynalite');
dynamoose.AWS.config.update({
  accessKeyId: 'AKID',
  secretAccessKey: 'SECRET',
  region: 'us-east-1'
});

module.exports.getRunningDynaliteInstance = async () => {
  if (isRunning) {
    throw new Error(`dynalite is running`);
  }
  const portNumber = getPortNumber();
  dynaliteInstance = new dynalite();
  await dynaliteInstance.listen(portNumber);
  dynamoose.local(`http://localhost:${portNumber}`);
  isRunning = true;
  return portNumber;
}

module.exports.stopDynaliteInstance = async () => {
  if (!isRunning) {
    throw new Error(`dynalite is not running`);
  }
  await dynaliteInstance.close();
  isRunning = false;
}

function getCatModel() {
  return dynamoose.model('Cat', {id: Number, name: String})
}

module.exports.CreateCat = async (id, name) => {
  const Cat = getCatModel();
  const cat = new Cat({ id: id, name: name});
  await cat.save();
  return cat;
};

module.exports.GetCat = async (id) => {
  const Cat = getCatModel();
  const cat = await Cat.get(666);

  return cat;
};

// test/startStopTest.js
const assert = require('chai').assert;
const dynaliteHelper = require('../dynamooseHelper');

describe('start stop bad cat', async () => {
  before(async function () {
    await dynaliteHelper.getRunningDynaliteInstance();
  });

  after(async function () {
    await dynaliteHelper.stopDynaliteInstance();
  })
  it('dynalite start stop', () => {
    const garfield = dynaliteHelper.CreateCat(666, 'Garfield');  // comment out these lines here
    assert(garfield != null, 'garfield no lasagne');  // comment out these lines here
    const badCat = dynaliteHelper.GetCat(666);  // comment out these lines here
    assert(badCat != null, 'bad cat');   // change to assert(true)
  })
})

Current output and behavior:
After the test, a process keep running. If you comment the lines above and change the assertion, there is no process running after the test. While still acceptable for a developer PC, we cannot use this for CI and automated testing, if there is a process running after each test.
Expected output and behavior:
When closing the dynalite server, the dynamoose instance should also close.
OR a dynamoose.close() function or similar is needed.
Environment:
Operating System: Ubuntu
Operating System Version: 18.04
Node.js version (node -v): v9.11.2
NPM version: (npm -v): 6.9.0
Dynamoose version:  "dynamoose": "^1.8.0"
Dynamoose Plugins:
"dynalite": "^2.3.1" (is this to be considered a dynamoose plugin?)

Dynamoose Plugins:

[ ] Yes, I believe that one or multiple 3rd party Dynamoose plugins are effecting this issue
[ ] No, I believe this issue is independent of any 3rd party Dynamoose plugins I'm using
[X] Unknown, I'm unsure if Dynamoose plugins are effecting this issue
[?] I am not using any Dynamoose plugins

Other information (if applicable):
You can download a working test project here.
https://www.dropbox.com/s/s5bt9o78908vcwg/dynalite-startStopTest.zip?dl=0
Just run 'npm run test'  or press F5 in VS Code.
Type (select 1):

[?] Bug report
[ ] Feature suggestion
[x] Question
[ ] Other suggestion
[ ] Something not listed here

Other:

[x] I have read through the Dynamoose documentation before posting this issue
[X] I have searched through the GitHub issues (including closed issues) and pull requests to ensure this issue has not already been raised before
[X] I have searched the internet and Stack Overflow to ensure this issue hasn't been raised or answered before
[X] I have tested the code provided and am confident it doesn't work as intended
[X] I have ensured that all of my plugins that I'm using with Dynamoose are listed above
[X] I have filled out all fields above
[X] I am running the latest version of Dynamoose

@FrancoConci This normally indicates that Dynamoose is still trying to run some type of action. Enabling the debug logs should help you debug this further: export DEBUG=dynamoose*.
Overall tho, Dynamoose doesn't keep an open connection to anything. It just makes standard web requests, so unless it's not getting replies to it's request, there shouldn't be any long running tasks.

@fishcharlie
i think after calling dynamoose.model, some tasks remain.
these codes are from dynamoose.js
this code keep running after test.
describe('dynamoose Test', function () {
    it('dynamoose Test', async function () {
        const dynaliteServer = dynalite();
        await dynaliteServer.listen(8000);

        dynamoose.AWS.config.update({
            accessKeyId: 'AKID',
            secretAccessKey: 'SECRET',
            region: 'us-east-1'
        });
        dynamoose.local(); // This defaults to "http://localhost:8000"
        const Cat = dynamoose.model('Cat', { id: Number, name: String });
        console.log('Never trust a smiling cat. - ');
        dynaliteServer.close();
    });
});

this code exit after test.
describe('dynamoose Test', function () {
    it('dynamoose Test', async function () {
        const dynaliteServer = dynalite();
        await dynaliteServer.listen(8000);

        dynamoose.AWS.config.update({
            accessKeyId: 'AKID',
            secretAccessKey: 'SECRET',
            region: 'us-east-1'
        });
        dynamoose.local(); // This defaults to "http://localhost:8000"

        const Cat = dynamoose.model('Cat', { id: Number, name: String });
        const garfield = new Cat({ id: 666, name: 'Garfield' });
        await garfield.save();

        console.log('Never trust a smiling cat. - ');
        dynaliteServer.close();
    });
});

different part is only
        const garfield = new Cat({ id: 666, name: 'Garfield' });
        await garfield.save();

why this happen?

@bhw1994 Yes. After calling dynamoose.model by default Dynamoose will attempt to create/verify that the table exists in DynamoDB. You can disable this behavior in the options object. But otherwise this is the default (and expected) behavior.


What does the "Microsoft may display" warning actually mean?

In step 4 of "Create embed codes with Publish to web", there is the warning that "Microsoft may display the report on a public website or public gallery". Does this mean that Microsoft is claiming ownership of any reports that we choose to publish, and will use them without informing us? I can understand the warning of "if you put this on a website, anyone who uses the website can see it", but tying that into "Microsoft can use this report however we want" seems like a step too far.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc005634-24c6-15c4-4352-e1455d63f4f3
Version Independent ID: 577c460a-08cc-892e-c5f9-e6106958f856
Content: Publish to web from Power BI - Power BI
Content Source: powerbi-docs/collaborate-share/service-publish-to-web.md
Service: powerbi
Sub-service: pbi-collaborate-share
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi, @CaryCarr3Form -- I'm checking and will get back to you. Thanks!

Hi, @CaryCarr3Form -- here's the answer:
"We continue to reserve this right to put it in a gallery, though we've never actually created a gallery. This is indeed a requirement for using our free Publish to web capability. The customer can use the Power BI embedded offering to build a public report without that requirement, but this would be significant work and cost to them to build and maintain."
Hope that answers your question!


SF-1202: Prevent GitHub pages from ignoring files with leading underscores

The typedoc plugin nojekyll adds a  .nojekyll  folder to the docs output
directory. This file will tell GitHub pages that this is not a Jekyll
site and will not process the files with Jekyll, which will cause the
underscore files to be rendered.

Codecov Report

Merging #11 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master      #11     +/-   ##
=========================================
- Coverage   92.93%   92.83%   -0.1%
=========================================
  Files         196      198      +2
  Lines        5137     5055     -82
  Branches      617      611      -6
=========================================
- Hits         4774     4693     -81
  Misses        280      280
+ Partials       83       82      -1

Impacted Files
Coverage Δ

<EMAIL_ADDRESS>0% <0%> (-92.86%)
:arrow_down:

<EMAIL_ADDRESS>0% <0%> (-75%)
:arrow_down:

...storefront/breadcrumbs/src/original-query/index.ts
100% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>100% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>100% <0%> (ø)
:arrow_up:

...orefront/breadcrumbs/src/refinement-crumb/index.ts
100% <0%> (ø)
:arrow_up:

...storefront/navigation/src/refinement-pill/index.ts
100% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>100% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>100% <0%> (ø)
:arrow_up:

<EMAIL_ADDRESS>100% <0%> (ø)
:arrow_up:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620294a...11411e9. Read the comment docs.