Default responder should not console.error 4xx errors

Right now the default handler (last step) will console.error when it gets an err, otherwise 404. I think that it probably shouldn't console.error when the err it got was a 4xx error, mainly because a 4xx is supposed to be a client error, of which the server admin probably cannot do anything about. Adding a custom error handler could, of course, let the user log 4xx error all they wanted--this is just about the default behavior. It could probably wait until express 5, though.

Would something like this be considered a reasonable back-compatible solution?
diff --git a/lib/application.js b/lib/application.js
index 0ee4def..47e573a 100644
--- a/lib/application.js
+++ b/lib/application.js
@@ -76,6 +76,7 @@ app.defaultConfiguration = function defaultConfiguration() {
   this.set('query parser', 'extended');
   this.set('subdomain offset', 2);
   this.set('trust proxy', false);
+  this.set('log client errors', true);

   // trust proxy inherit back-compat
   Object.defineProperty(this.settings, trustProxyDefaultSymbol, {
@@ -625,6 +626,10 @@ app.listen = function listen() {
  */

 function logerror(err) {
+  if (!this.get('log client errors')) {
+    var status = err.status || err.statusCode || res.statusCode || 500;
+    if (status >= 400 && status <= 499) return;
+  }
   /* istanbul ignore next */
   if (this.get('env') !== 'test') console.error(err.stack || err.toString());
 }

@tunniclm, we should focus on getting the needed changed into Express 5.0 instead of adding more weird back-compat solutions. There are already two solutions for Express 4.x users can use for this, and so adding yet another solution is, i.m.o., not very valuable.
Currently the best solution in Express 4.x is to just handle your errors with an error middleware and not forward 4xx ones to the default handler.
As part of the "minimalist web framework" ideology of Express, we historically favor not adding a bunch of configuration switches, as by the time we're done, you may as well just use Hapi.js :)

@dougwilson That's fine by me. I assume the next step is to raise a pull request against pillarjs/router then?

Hi @tunniclm, I was hoping the labels would make it clear which mode these issues correspond to :) This is for the finalhandler module and it's already been implemented: https://github.com/pillarjs/finalhandler/commit/0a6847daeaa534df8aeaa7bb3e7d39568648a0a7

Sorry, wrong commit; I'll have to take a look later, but yea, this is against the finalhandler module.

@dougwilson Arg, so many issues relate to the router I think my brain went on autopilot.
Although, I thought this change might be in application.js  because I expected that the onerror handler should be called even for 4xx error codes, but just the onerror handler for the default handler shouldn't log them.
Is that incorrect, is the intention that the onerror not be called for 4xx status codes at all (even if it is a user provided function)?

Hi @tunniclm, there are really two parts here: a change to finalhandler and then a change in application.js, though that needs to be moved into a new module in pillarjs as well.
The built-in error logging that is implemented in the application.js-split module should use a 1.x version of finalhandler that provides the detected status to the logging function, otherwise all you're doing is duplicating the logic to get the status from the err object, which sucks for maintainability and the ability to reason about the program flow (for example, your patch will still log for err.stats = 201, which is confusing).
So once finalhandler is changed to provide the status code (and yes, it would always be invoked, even on 4xx errors, as it would be invoked whenever there was an err object), then the new module that is built to replace the application.js file would use it and this new logic. This issue is the over-all tracking towards these Express 5.0 features.
I hope that helps! From the previous discussions over a year ago, some of which is written down in the 5.0 pull request in this repo, there are no 5.0 changes that will be in this repository; 5.0 will consist of implementing new features in other modules & extracting all existing functionality into new modules. Implementing new 5.0 features in this repository is in general not working towards the 5.0 goal of extraction.

The reason I only suggested it wait for 5 is because there is a bunch of work around it. If it were to change, it should be made configurable. Of course if it's configurable, it could then easily land on 4 with the default config having it operate as it does now. Standard back-compat stuffs.

Just to check vs this earlier comment, are we saying this behaviour should not be configurable in 5?
Also, regarding refactoring parts of application.js out into a new module, it seems like it would be better to do that under an issue specifically for that purpose and refer to that from here.


Blueprint Option: Spellcheck

It would be great if the field also supported the "spellcheck: false" option. Just a feature request

It would be great if the field also supported the "spellcheck: false" option. Just a feature request

‚spellcheck‘ is configurable for ‚text’ and ‚textarea‘ fields. But for tables it is input fields. I don't know of a Kirby setting "spellcheck: false" for input fields...?

I would disable it by default. In a table case, I don't see making an impact. I could also make it configurable but I just don't see its point here.

@gbdesign2023 most off the fields have this option, see here in bottom of the table: https://getkirby.com/docs/reference/panel/fields/text
@bogdancondorachi that would also make sense of course! I personally disable it at nearly each field

@Werbschaft
Correct. For text and textarea. But the table plugin uses input fields, not text fields. So I can't find a Kirby function to disable spellcheck by option in the blueprint.
I also agree that spellcheck has no advantage in a table.

@gbdesign2023 yes, but of course, the text field is a simple input field right? But never mind, it would make sense to add spellcheck="false" to all input elements in the field

@Werbschaft That's right! But that would be more of a core function for Kirby to adapt this option to other fields.

As the new release would replace the text-input with writer-input, I would go for a config like this:
<k-writer-input
  v-model="row[columnIndex]"
  :inline="true"
  :nodes="false"
  :spellcheck="false"
  @input="update()"
/>

Would be amazing to see the writer field in the table

@Werbschaft This should be fixed in the latest release, you can also find the new writer-input.

Amazing work! You're an real artist with vue.js


Fixes for building on linux

Missing comma in LIBS array
Missing include when using non standard libevent

Looks good - thanks James.

Hi,
I am building the OMNM payload lib, I cant seem to find the enum entry for
it in your zmq branch of OpenMama and it caused the build to fail.
I have added it locally as follows.
--- a/mama/c_cpp/src/c/mama/msg.h
+++ b/mama/c_cpp/src/c/mama/msg.h
@@ -51,6 +51,7 @@ typedef enum mamaPayloadType_
MAMA_PAYLOAD_KWANTUM    = 'K',
MAMA_PAYLOAD_UMS        = 'L',
MAMA_PAYLOAD_INRUSH     = 'N',

MAMA_PAYLOAD_OMNM       = 'O',
MAMA_PAYLOAD_TICK42RMDS = 'P',
MAMA_PAYLOAD_QPID       = 'Q',
MAMA_PAYLOAD_TIBRV      = 'R',

Not sure if that's correct but it seems to build now.
Thanks
James
On Tue, Nov 10, 2015 at 4:32 PM, fquinner<EMAIL_ADDRESS>wrote:

Looks good - thanks James.
—
Reply to this email directly or view it on GitHub
https://github.com/fquinner/OpenMAMA-zmq/pull/7#issuecomment-155478075.

Hi James,
Interesting - i thought i had added that already to the feature-omzmq branch of my fork but it must not have gotten pushed. There's another change needed in msg.c as well - I'll put them into the feature-omzmq branch when i get to my dev laptop.
Cheers,
Frank

Hi Frank,
Just a quick note to say great job on the zmq bridge and omnm payload.
I have cobbled it into our market data framework and intial tests show a
huge performance increase over the qpid bridge/payload.
I am having a few issues with string fields when the size/data changes but
other than that its just works.
Do you have any plans to add this to the main line opemmama repo?
Thanks
James.
On Thu, Nov 26, 2015 at 8:53 AM, fquinner<EMAIL_ADDRESS>wrote:

Hi James,
Interesting - i thought i had added that already to the feature-omzmq
branch of my fork but it must not have gotten pushed. There's another
change needed in msg.c as well - I'll put them into the feature-omzmq
branch when i get to my dev laptop.
Cheers,
Frank
—
Reply to this email directly or view it on GitHub
https://github.com/fquinner/OpenMAMA-zmq/pull/7#issuecomment-159850638.

Thank you and I'm glad to see you are making use of the projects! That variable width field thing looks like a bug (actually had a TODO in the original code to fix that) - just fixed it over in https://github.com/fquinner/OpenMAMA-omnm/issues/1.
I don't have any plans to submit this to the main OpenMAMA repo at the moment because I quite like the idea of having an independent bridge out there and putting the onus on the OpenMAMA project to make this really easy (I'm also involved in the OpenMAMA side so I'm on the hook at that end too).
I've already submitted a few changes and new functionality back to core OpenMAMA to make it easier for projects like this to exist and I plan on submitting a few more once dynamic bridge loading is completed (another reason why I haven't submitted the enum to core OpenMAMA yet - once dynamic loading is working, the enum will be optional).

Hi,
Yes that all makes sense to me, allowing for dynamic loading sounds better
than bundling it all into the main repo.
I still had some trouble after pulling your fix, my system ran a little
longer but this time crashed at random points with heap corruption.
I think I have a fix. It works with my live system (real market data ~
20,000 msg/s) and I have added a unit test.
https://github.com/fquinner/OpenMAMA-omnm/pull/2
I messed up the initial commit (more used to perforce) and added loads of
extra files (which i removed in the second) but it should be correct now.
James
On Sun, Nov 29, 2015 at 4:10 PM, fquinner<EMAIL_ADDRESS>wrote:

Thank you and I'm glad to see you are making use of the projects! That
variable width field thing looks like a bug (actually had a TODO in the
original code to fix that) - just fixed it over in
fquinner/OpenMAMA-omnm#1
https://github.com/fquinner/OpenMAMA-omnm/issues/1.
I don't have any plans to submit this to the main OpenMAMA repo at the
moment because I quite like the idea of having an independent bridge out
there and putting the onus on the OpenMAMA project to make this really easy
(I'm also involved in the OpenMAMA side so I'm on the hook at that end too).
I've already submitted a few changes and new functionality back to core
OpenMAMA to make it easier for projects like this to exist and I plan on
submitting a few more once dynamic bridge loading is completed (another
reason why I haven't submitted the enum to core OpenMAMA yet - once dynamic
loading is working, the enum will be optional).
—
Reply to this email directly or view it on GitHub
https://github.com/fquinner/OpenMAMA-zmq/pull/7#issuecomment-160428117.


Cast callbacks to functions when set with default_args on task groups

Hello!
When used in the task group's default_args, callbacks are passed as strings to the tasks, which ends up generating failures.
The idea is to perform the same parse used in make_task (it is necessary to check whether the default_args attribute is defined, since it is optional and defaults to None) and perhaps in the future modularize this conversion functionality in order to cover the widespread use of default_args.
Co-authored-by: Luiz Felipe de Mesquita Baraldo<EMAIL_ADDRESS>Note: The actual work is done PR https://github.com/astronomer/dag-factory/pull/174

It appears to me that we have not enabled the setting to update branches/PR to latest main before merging the PR. Can we please enable that?

Thanks for addressing this, @pankajastro ! Should we merge #174 first and then immediately after this PR, to fix the static checks that are not passing? Please improve the description of the PR with what we're accomplishing in this PR.

This is a replication of #17 only. I attempted to address the checks in the original PR, but it became too complicated to implement changes there


non-projected hotspots (e.g. for a floor map)

Hej Matthew,
what a fantastic project! Thanks a lot for making it freely accessible to everyone!
I recently started trying Pannellum out and I am wondering - is there currectly a way (or do you plan to add such a thing in the future) to display non-projected (flat, with fixed positions) images that could act as hotspots? This would be useful to display a floor map, being overlaid on top of the panorama (like the compass or the navi buttons), consisting of a number of individual parts that together would act as a navigation help / floor plan. If so, it would be most helpful to be able to distinguish three states (i.e. provide three images) per hotspot: active (= last clicked), inactive (= another hotspot is active), mouse-over.
Kind regards, Ph.

I think this is something that's probably best left to the API. You can use the loadScene method to change the scene when a custom button is clicked. For an example of overlaying custom controls, see https://github.com/mpetroff/pannellum/issues/168#issuecomment-227605139.

Hej Matthew,
thanks for your reply and sorry that it took me so long to answer - I didn't realize you had answered before a minute ago.
Thanks for pointing me to that solution. I wasn't aware it could be done like this. I'll have to experiment a little with CSS/API calls, but it look very promising :-)


Bad regex for PUT method of /api/1.x/users endpoint

Specifically, that endpoint cannot be reached for any API version. One can PUT to /api/1.x/users/ or even /api/1.x/users/.json. The problem is that the regular expression being matched is users/{id}?(\.json)?$ but should be users(/{id})?(\.json)?$.

PUT /api/1.x/users was never designated to be an endpoint. There is still an issue with the regex. It seems I wanted to write a single regex for the MethodGet, so I made the {id} optional. It is better to have two regexs, one where the id is not required and another where it is. The optional {id} should not apply to the PUT, or the delete if it were to be implemented.
{1.4, http.MethodGet, `users/?(\.json)?$`},
{1.4, http.MethodGet, `users/{id}?(\.json)?$`},
{1.4, http.MethodPut, `users/{id}?(\.json)?$`},
{1.4, http.MethodPost, `users/?(\.json)?$`},

{1.4, http.MethodGet, `users/?(\.json)?$`},
{1.4, http.MethodGet, `users/{id}$`},
{1.4, http.MethodPut, `users/{id}$`},
{1.4, http.MethodPost, `users/?(\.json)?$`,

I'll fix and update the documentation.

I disagree in the strongest possible terms. There's no reason to require a different endpoint for the method.

First of all, I think the.json is just silly because does our API support anything other than json? but that's another story i guess.
But I'd say when in doubt just follow the examples already in routes.go so i guess:
		{1.4, http.MethodGet, `users/?(\.json)?$`
		{1.4, http.MethodGet, `users/{id}$`
		{1.4, http.MethodPut, `users/{id}$`
		{1.4, http.MethodPost, `users/?$`

Also, why is it 1.4? If these are simply rewrites of the Perl routes, it should be 1.1


Avoid passing both the short and the long proto paths to protoc

Currently for each .proto file Bazel passes to protoc the path relative to the workspace (the long path) via -I flag (alias for --proto_path).
Since 15a4362, Bazel also passes to protoc a short path via the --proto_path flag. The short path is only passed for proto_library targets that have set proto_source_root.
Passing to protoc both the short and the long path to a .proto file is error prone. A better mechanism must be implemented to deal with these situations.

A lot has changed since 2018 (e.g. the aforementioned proto_source_root has since been removed), so I'm not sure if this is still an issue.
There's also work going on to change how .proto files are compiled (e.g. bazelbuild/bazel#10939, bazelbuild/bazel#1005), which will definitely fix this (in case it isn't already fixed).

Fixed in  bazelbuild/bazel#10939

Fixed in  bazelbuild/bazel#10939


add postgis geometry as valid column type

This small pr simply also adds the PostGIS geometry type as a valid Type when creating a column.
table.AddColumn<Geometry>("geom");
Will now correctly create the type. Note that if the PostGIS extension is not enabled you will run into errors.

@staffanhedstrom Thanks for the PR. This would work but the solution to include PostGIS support is a bit involved and will require it to be done like an add-on plugin like what we do for NodaTime. I will liaise with @jeremydmiller on this and keep you posted.

Right, I had hoped that this was all that was necessary.
I am building an Event Sourcing project using Marten and using Weasel to build up projection tables. We are working with coordinates within a country so just being able to generate the geometry column is all I need and works very well for me.

I'm good with this as soon as the PR is green. I'm doing a weasel release for a bug fix and saw it.


Node JS documentation missing.

@ivorb, when is this getting done? It's been on the backlog for 3 months, considering that it is one of the most important parts of a product that is being widely used, it should be taken up on priority. Not to mention that MS has stable releases for only Node and C#, out of which a lot of documentation for Node is absent. Please help

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 409c8f0a-6388-574b-5443-a09c160962a7
Version Independent ID: efc9e777-18e8-bcf2-204e-b395ce2e9f90
Content: Implement custom storage for your bot - Bot Service
Content Source: articles/v4sdk/bot-builder-custom-storage.md
Service: bot-service
Sub-service: sdk
GitHub Login: @johnataylor
Microsoft Alias: johtaylo

@kaushalgautam , the dev team has not implemented the JavaScript version of the sample yet. You can open an issue in the BotBuilder-Samples repo to request that they expedite this.

@kaushalgautam
any update?


logger: cant set rate for topics

Hi,
If I put the file logger_topics.txt in etc/logging/ on an SD card with the following lines everything works as expected
sensor_gyro
sensor_accel

However, if I try to set the the interval like below, then the log file is always 0 bytes.
sensor_gyro, 500
sensor_accel, 500

I'm using a Pixhawk pro and latest master

@CarlOlsson try removing the space between the comma and the number. ;)

The spaces should be there according to the doc
However, also tried to remove them but then the logger is logging the default topics and not the ones that are defined in the file

OK, yes you're correct. The spaces are fine.
This issue seems to be a real issue. Let me have a look.

thanks!

Isn't it with a space like this?
vehicle_attitude 50
vehicle_attitude_setpoint 50

This is most likely a regression of a NuttX update - sscanf("%s %u") might not be matching any more.

I just tested on Pixracer, it works fine. The comma is optional.
There was a NuttX update regression, but I already fixed that several weeks ago.

Assuming @CarlOlsson is using a stale version, closing.

@bkueng strange that it works for you and not for me. I just tested it again.

Flashed master via QGC to a Pixhawk Pro,
Put this file logger_topics.txt in etc/logging on the SD card
Plug in the SD card in the Pixhawk Pro, plug in a usb cable to power it.
Check SD card -> Logfile is zero bytes.

But if you instead put the file without the interval time it works as expected
logger_topics.txt
I also tested the same thing on a Pixracer with the same results

Here is the logfile from the test that works, i.e. no setting of time interval
http://logs.px4.io/plot_app?log=752d73f0-37b9-4dc1-96c0-bb24db09a310

Really strange. Your topics file works for me & the log looks as expected.
What's the boot output? What does logger stop, logger start say?


Travis setup

This is an initial setup. At this moment, it only builds for OSX using clang.  Just getting my feet wet with it, but eventually we'll flesh it out to a more extensive build matrix.
I've still got lots of bells and whistles to add, and there's some debug scaffolding.
Just a first stab, but it's already becoming kind of useful.

If there are no objections, I'm going to merge this today, and then continue to refine as we move forward. Obvious next steps are to add Linux, clang vs gcc, C++03 vs C++11.
But even now with just one build platform, it's super cool to go to GH to look at a pull request and have it displayed right there that the PR has already been built cleanly and passes basic tests.


BLE Python test tools for examples don't support ESP32-C3 (IDFGH-6155)

I'm trying to run the BLE nimble examples and they flash onto the ESP32-C3 chip no worries and I can use other devices to connect so I believe they are working fine. It is just when I try to use the python scripts for testing such as blecent_test.py in the blecent example I get the error report below which I guess means that the script doesn't support the C3 chip. It would be great if these could be updated.

Hi @dazzalicious, "blecent_test.py" (and other "_test.py" scripts in the examples directory) are intended primarily for continuous integration (CI), not for using locally. See some background information in https://esp32.com/viewtopic.php?t=22552.

I'm not entirely familiar with the BLE examples but they don't seem to support any chip beside ESP32. Please notice the first line of the examples' READMEs. They state that the supported target is ESP32 (only).

I'm not entirely familiar with the BLE examples but they don't seem to support any chip beside ESP32. Please notice the first line of the examples' READMEs. They state that the supported target is ESP32 (only).

I've been able to get them to flash and function on the ESP32-C3 chip. I'm a noob with this though.


fix: Replace op_def and decorator_op code with simpler & safer version

fixes issue where we dropped class names in op method names
op method names are now ".<function_name>". Notice the change from "-" to "."
op function names are now just "<function_name>". Notice no more "op-" prefix
replaces the weave1 decorator_op.op decorator, and the OpDef class, with simpler versions in weave.trace.op.py
we now support all python calling conventions, and don't really on rely types during the call path, so there's less chance of crashing
smaller stack traces due to simpler op call path
fixes docstrings on weave.Object descendents (previously they were swallowed in VSCode because we were using a metaclass)

Merging TBR (To Be Reviewed)

Post merge approal


Return data and metadata in proc_() functions

See https://github.com/aolabNeuro/analyze/pull/227#pullrequestreview-854852350_
Similar return statements could be added to other preproc functions

I am taking some notes to make this issue easier to resolve.
for proc_exp:

add save_res as an optional argument
output bmi3d_data, bmi3d_metadata

for proc_mocap:

add save_res as an optional argument
output  optitrack_data and optitrack_metadata

for proc_lfp:

add save_res as an optional argument
output lfp_metadata, lfp_data

done for proc_exp()

need to think a bit more about whether this is actually useful. Currently the preprocessing functions always have to do work even if overwrite=False and the file already exists, since they need to return the data and metadata.


Pytorch Lightning stuck the computer and finally killed

Thanks for your great work. I'd like to reproduce the training process, but I encountered an error. That is when I use multi-GPU distributed training process, the logging information seems normal, but afterwards the remote server stuck and connection reset and finally the process is killed. My remote server is an independent machine with 4xRTX3090. Is there any issues with the pytorch lightning distributed training that may cause my failure?

It might be using more RAM. Check your RAM usage once you start running the code and reduce num_workers in config file. this might solve your issue.


address comments and update modal

Summary

This PR addresses the previous comments made to adding bulk registration to studio, and it also updates the response model to make it more readable
How did you test this change?

[ ] Test(s) added
[ ] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

would you mind updating the summary to link this pr to the previous pr if there is any?


missing ClassReflection#isArray(Class)

The equivalent of Class#isArray() would be nice to have in ClassReflection.

Thanks!


The Microsoft Edge browser does not show the Minluck or Catch Rate values.

I am using v0.42.1 on Windows 11

Update to v0.43.1.  I'm getting min lucks and catch rates using Edge now.

How do I update the extension? All I see is Delete.
On Wednesday, May 8, 2024 at 12:30:45 PM CDT, wachto79 @.***> wrote:
Update to v0.43.1. I'm getting min lucks and catch rates using Edge now.
image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Click

Right Click

Click

Click

My screens are completely different and no Update option but when I went back to mousehuntgame and refreshed it was at v0.43.1 and still no minluck or catch rates.

There was an issue with how updates refresh the data files - the newest released version v0.43.2 has fixed this.


Cap the maximum basic block padding in Cranelift

This commit is a fix for a fuzz failure that came in the other day where a module took more than 2GB of memory to compile, triggering the fuzzer to fail. Investigating locally it looks like the problem lies in the basic-block padding added recently. Turning on that option increases the memory usage of Cranelift from ~70M to ~2.5G. The setting in the test was to add 1<<14 bytes of padding between all basic blocks, and with a lot of basic blocks that can add up quite quickly.
The solution implemented here is to implement a per-function limit of the amount of padding that can be injected. I've set it to 1MB for now which is hopefully enough to continue to stress the various bits of the MachBuffer while not blowing limits accidentally while fuzzing.
After this commit the fuzz test case in question jumps from 70M to 470M with basic block padding enabled, which while still large is a bit more modest and sticks within the limits of the fuzzer.

Ah, yes, we actually do have 26-bit ranges that are relevant on AArch64: direct branches have a range of +/- 128MiB (2^26, times 4 because of PC alignment, signed). A function size up to 128MiB plus epsilon (144MiB, to pick a round number?) would I think give sufficient coverage.

(And x86-64 does have 2GiB ranges for all branches and RIP-relative labels, but we actually don't have façades to extend those; we just don't support a single function body that large!)

Sounds reasonable! I've bumped the per-function limit to 150M and reduced the maximum number of functions to 5 to keep the overhead under 1G here


web doesn't show all plugin

Describe the bug
The web ajax result contains all plugins ,but ui doesn't show all plugins
Like this picture: the rate_limiter doesn't show in ui

Environment

Soul version(s): [master]

Expected behavior
rete_limiter should show in ui

resolved by https://github.com/dromara/soul/pull/1029

resolved by https://github.com/dromara/soul/pull/1029


[FR] Set personal access token per repository

Hey 👋  it's great that #77 allows you to access private repositories. The documentation states that you can hand out a personal access token to your beta testers. However, you can only set one personal access token for all plugins. If my beta testers are also testing other private repositories, they have to change the token for each update. It would be great if one could specify a personal access token for each repo individually. This would also eliminate the need to check isPrivateRepo on each grabReleaseFileFromRepository call, if the user specifies per plugin, if it is private and provides a personal access token. One could also add a switch to use the global token on all repos if this is wanted.
If you'd like, I can open a PR that implements this, as soon as I find some time. 😄

This is a great idea. Something I have hoped to add, now that I see the functionality for accessing private repos is useful.
If you can submit a PR, that would be very nice, as it will be some time before I can get around to it. However its not such a small PR. It will require some UI modification as well, along with how the keys for private repos are stored, and taking into account any update process for existing users.


Add Pull Request Template

Pull Request
Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

#72
#71  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite


Sublime key bindings doesnt work

The default key binding ctrl+/ (toggle commet) doesnt work with the syntax

You mean in a Gulp Results tab? If that's the case you're right but what would be the desired result?

My gulpfile.js uses the syntax Gulpfile JS, when I want comment some part of the code I use ctrl+/. But nothing happens.
The gulpfile.js is a javascript file and the key bindings (toggle comments) should comment lines likes
// var myVar = 'test';

If I change the syntax of  gulpfile.js to JavaScript, works again.

Hm the thing is that this package does not define the Gulpfile JS syntax, it contains the Gulp Results syntax used on the panel/tab when running gulp.
The culprit could be another package or am I missing something?

I'm closing this for the sake of completeness, but if you have any feedback I'll be happy to re-open it!


Vendor the fixed get_server_dir, but compare its output to that of the upstream Pkg.PlatformEngines.get_server_dir, and print a warning if the two values differ

Suppose that Pkg and PkgAuthentication have different behaviors for determining the path of the token file (given the same exact server as input). So, then, for example, PkgAuthentication might create a token file at e.g. ~/.julia/servers/localhost_1234/auth.toml. But then when it comes time for Pkg to construct the authentication header, Pkg looks for a token file at ~/.julia/servers/localhost:1234/auth.toml. And now authentication fails because PkgAuthentication created a token in one location, and Pkg is looking for a token in a second location.
So I think we actually need PkgAuthentication and Pkg to always use the exact same get_server_dir function.

Codecov Report

Merging #16 (f62ac69) into master (a82dede) will decrease coverage by 2.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   72.81%   70.70%   -2.11%
==========================================
  Files           1        1
  Lines         206      198       -8
==========================================
- Hits          150      140      -10
- Misses         56       58       +2

Impacted Files
Coverage Δ

src/PkgAuthentication.jl
70.70% <100.00%> (-2.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82dede...f62ac69. Read the comment docs.

Agreed.
I suspect the original motivation for fixing this here is that we have a bunch of non-Pkg components that rely on this working regardless of whether Pkg itself works.

Hmmm. Okay, how about this: we vendor the fixed get_server_dir here. However, whenever we call get_pkg_server, we compare the output to that of Pkg.PlatformEngines.get_pkg_server. If the two values differ, we print a warning.

IIUC this will cause a regression on non-Windows OSs, right? The new _get_server_dir escapes : etc, but those are valid dir names.
In which case we should only use the escaping version when Pkg also escapes invalid chars.

Okay, I think we now avoid that regression.

Specifically, I restored the vendored copy of get_server_dir that exists currently on PkgAuthentication#master, which drops the colon and the port number. This is the behavior on PkgAuthentication#master, and it is also the behavior in the latest registered release of PkgAuthentication.

Anything else you'd like to do for this PR?

Nope, I think it's good to go!


Add a test for using -f w/git repo on build

https://github.com/docker/docker/pull/14546 actually fixed issue #14837
but I don't see a new test to ensure we don't regress. So this PR adds
a test and then we can close #14837.
Closes #14837
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

LGTM

LGTM


Add support for pre-release versions and build metadata

Description
It seems that python-semantic-release doesn't parse pre-release versions and build metadata as specified in SemVer 2.0.
Use cases
Releasing pre-release versions.
Possible implementation
Change the regex parsing to support it.

Would be nice if there were an option to release pre-releases as well. I have a very young project in which we would like to use semantic versioning from the start. But I wouldn't want anyone to think it was actually functional despite the high semantic version due to many breaking changes.

Prereleases are supported in the latest version v9 and previously v8.


about pretraied model: why mobilenetv2's model is slower than alexnet's?

Hi,
In pretrained Model-Zoo, I see that the mobilenetv2 based model is 87fps while alexnet based model is 180 fps, Why alex is faster than mobilenetV2? and I observed that no mobilenetV2 train config file exists?

Is there any reason that mobilenet should be faster than alexnet? And as for train config for mobilenet, we will update recently.


Communicate from Item to Adapter

Is there any mechanism (I couldn't find anything) to communicate from an AbstractItem to its FastAdapter? I have a few use cases where I'm using Glide to load some images. I'd like to create one instance of the Glide RequestManager and make it available to all the items in the adpater. Currently what I'm doing in a different situation is just passing the resource to my items when I instantiate them. new MyItem(SomeResource resource) which I can then use in those items. Is there a better way to do this?
Anyway to extend FastAdapter to include a reference to my RequestManager whose items then have access to it?

You could use an ModelAdapter and create your own IInterceptor. Inside the interceptor you get back each item you want to add to your adapter. The easiest solution would be to call an setter there to set the reference for the RequestManager.

Thanks for the feedback @FabianTerhorst. The places where I'm injecting a dependency like this are already ModelAdapters with generic items. So I'll just keep doing it that way.


Feat: Adding new Settings options in the settings section.

Describe the feature
The "Settings" section currently has only 4 basic settings. I'd add more setting options to the application, which includes the following:

Light mode/Dark mode switch: Through this, the app's light and dark mode background and primary colors can be adjusted.
Notifications: Through this, the users would be able to select weather they want to turn on the app's notifications or not.

Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'23 contributor
[X] I want to work on this issue

Go Ahead @jaivsh


equinox.static_field() not respected in subclass under python 3.9.0

It seems that when I have a subclass that extends a superclass with a static_field, the field is no longer marked as static. For example, when I run the code
import jax
import equinox as eqx

class A(eqx.Module):

  foo: int = eqx.static_field()

class B(A):

  def __init__(self, foo: int):
    super().__init__(foo=foo)

a = A(3)
b = B(3)
print(jax.tree_util.tree_flatten(a)[0])
print(jax.tree_util.tree_flatten(b)[0])

under python 3.9.0 I get the output
[]
[3]

I don't think this happens under all versions of python 3.9, and also doesn't happen under python 3.10+. Unfortunately I am limited to python 3.9.0 in my environment. Are there any workarounds or fixes?
I'm using jax 0.4.8, jaxlib 0.4.7, and equinox 0.10.3.

Thanks for the report! Looks like this was a bug that snuck in with v0.10.3. Should be fixed in #338.

Closing as fixed in v0.10.4.


I want the treeSelect component to have nzDropdownRender and nzOpen  similar to Select.

What problem does this feature solve?

nzDropdownRender: You can fix the operation button displayed at the bottom.
nzOpen  :  I can customize  to open and close the drop-down.

What does the proposed API look like?
<nz-tree-select  [(nzOpen)]="true" [nzDropdownRender]="render">
<ng-template #render>

@dansinian You can use cdk/overlay and nz-tree to customize.


Install YAML Extensions?

Issue Type

Feature Idea

Your Environment
Vagrant 1.8.6
VirtualBox
5.0.26r108824
ansible <IP_ADDRESS>
  config file =
  configured module search path = Default w/o overrides

Your OS

macOS (10.12.1)

Summary
Not sure if this is the best place for this, or maybe a pointer on how to install this so I can match my Acquia environment, but I have a discrepancy that cost a couple of hours yesterday.
I reported the issue here: One of the declarations in that routing file was double quoted, when it should be single quoted. I reported the issue here: https://www.drupal.org/node/2838151
It also seems that since I do not have the YAML extensions installed with the PHP config of my local VM (DrupalVM), this error did not occur. The Acquia environment does have the YAML extension installed. This is an important detail because I am told that Symfony parses YAML slightly differently in both cases - Symfony is more lax, where the YAML extension is more strict. This is why I could not reproduce locally.
How can I add that to the DrupalVM so it more closely matches my production environment?

References:

https://docs.acquia.com/release-note/acquia-cloud-196
https://www.drupal.org/node/1920902

Seems ondrej provides this for all PHP versions.
vagrant@drupalvm-project:~$ apt-cache show php-yaml
Package: php-yaml
Priority: optional
Section: php
Installed-Size: 278
Maintainer: Debian PHP PECL Maintainers<EMAIL_ADDRESS>Architecture: amd64
Version: 2.0.0+1.3.0-2+deb.sury.org~precise+1
Provides: php5.5-yaml, php5.6-yaml, php7.0-yaml, php7.1-yaml
Depends: php-common (>= 1:7.0+33~), phpapi-20160303 | phpapi-20151012 | phpapi-20131226 | phpapi-20121212, libc6 (>= 2.14), libyaml-0-2
Filename: pool/main/p/php-yaml/php-yaml_2.0.0+1.3.0-2+deb.sury.org~precise+1_amd64.deb
Size: 82202
MD5sum: 9884a653725f3292299bcba79c96bc25
SHA1: aecb27eb803c9eaeb4ec3cc21afbbf6674415acf
SHA256: f5ed833828c5cd20085a9f4fdcd35fa079f18700ff8d05678d3d61da6c3cd8a3
Description-en: YAML-1.1 parser and emitter for PHP
 PHP extension adding support for YAML 1.1 (YAML Ain't Markup
 Language) serialization using the LibYAML library.
Description-md5: 1bfaf65b64a715c72224ee22bc952860

You can install it by adding php{{ php_version }}-yaml to extra_packages (if you're using Ubuntu that is, not sure about Centos). This wouldn't work with the new version switching feature though.
To get version switching working you can override the php_packages which is previously defined in provisioning/vars/Debian.yml and add the yaml package at the end:
php_packages:
  - "php{{ php_version }}"
  - "php{{ php_version }}-apcu"
  - "php{{ php_version }}-cli"
  - "php{{ php_version }}-common"
  - "php{{ php_version }}-curl"
  - "php{{ php_version }}-dev"
  - "php{{ php_version }}-fpm"
  - "php{{ php_version }}-gd"
  - "php{{ php_version }}-imap"
  - "php{{ php_version }}-json"
  - "php{{ php_version }}-mbstring"
  - "php{{ php_version }}-mcrypt"
  - "php{{ php_version }}-opcache"
  - "php{{ php_version }}-sqlite3"
  - "php{{ php_version }}-xml"
  - "php{{ php_version }}-yaml"

@oxyc - If it is available in CentOS, then yes, that's fine by me. Apparently there was quite a fraças over Symfony's YAML parser vs. the PHP one recently, and having this installed by default might help people testing YAML they're deploying to servers where the PHP extension is installed...

And YAML is the new XML (but way more awesome-r), and we already include the xml... and json extensions.

This is now added in master.


Fixed Issues

Fixed: If you clone the code on a windows machine, there is an issue with the CRLF and LF EOL and the scripts are not able to run. Added the .gitattributes file to prevent this issue.
Fixed: "No Such file or directory" during the startup in the install.sh
Fixed: Crontab Error message. (The old comment still worked but were confusing for the user.)

@feydan Can you merge this please?


tomcat 6.0.44

Merged in https://github.com/Homebrew/homebrew-versions/commit/8447a5b0fe7f65833c38a8eb1beedb57485f7a28. Thanks for your contribution to Homebrew, we appreciate it! :smiley_cat:. One tiny nit: The ideal commit message should be tomcat6 6.0.44, just to ensure clarity in the logs. Thanks!

@DomT4 Nitpick noted for next time. Feedback is appreciated. Thanks.


GLIBCXX_3.4.20 not found

When I run the model I get "`GLIBCXX_3.4.20' not found" error! Do you have any ideas?

OSError: /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /home/myuser/anaconda3/envs/longformer/lib/python3.7/site-packages/tvm/libtvm_runtime.so)

I had the same issue and just resolved it. Please note that my solution could not be right answer for your situation.
TLDR: it seems the issue could be caused by incompatible compiler's version to the compiled library that Longformer uses. You could resolve it through (1) install new library (glibc) through condo and then (2) add conda's library path to your environment.
Part 1. Check your gcc version
In my case, I first checked my compiler (gcc) version:
gcc -v

With this, I got to know that my compiler's version is gcc version 4.8.5.
Through this table on the link, I found 4.8.5 uses/support GLIBCXX_3.4.19, not the one that Longformer needs. (Link: https://github.com/FoldingAtHome/fah-issues/issues/1147#issuecomment-134731211)
The link also says GLIBCXX_3.4.20 is indeed on gcc version 4.9.0.  So if your gcc version is below 4.9.0, it could be the same reason that I have.
Part 2. Install libgcc through conda
Based on my search on google, it seems basically you need to upgrade gcc but it requires sudo. For my case I don't have sudo. Another way to install the newer library is through conda's libgcc. Run following line:
conda install libgcc

Part 3. Add conda's library path to your LD_LIBRARY_PATH env variable.
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/path/to/your/anaconda3/lib

Then, the Longformer works as charm!

Closing. Please feel free to reopen or create a new one if you have more questions.


[feature request] ability to set env in Engine executeFeatureSync call

I am looking at the test in
   @Test
    public void testKarateEnvAccessFromScript() {
       //this sets envrionment for config.
        FeatureContext featureContext = FeatureContext.forEnv("baz");
        CallContext callContext = new CallContext(null, true);
        ScenarioContext ctx = new ScenarioContext(featureContext, callContext);
        Script.assign("foo", "function(){ return karate.env }", ctx);
        Script.assign("bar", "call foo", ctx);
        ScriptValue bar = ctx.vars.get("bar");
        assertEquals("baz", bar.getValue());
        // null
        featureContext = FeatureContext.forEnv();
        ctx = new ScenarioContext(featureContext, callContext);
        Script.assign("foo", "function(){ return karate.env }", ctx);
        Script.assign("bar", "call foo", ctx);
        bar = ctx.vars.get("bar");
        assertNull(bar.getValue());
    }

I am using following procedure to call dynamically loaded feature from jar.
I am not seeing any good way to dynamically to load environment so that
I can achieve following type thing
//so that it can load specified environment.
FeatureContext featureContext = FeatureContext.forEnv("prod")
       CallContext callContext = new CallContext(null, true);
        FeatureResult result = Engine.executeFeatureSync(feature, (String) null, callContext);
        String resultFile = feature.getResource().getPackageQualifiedName() + ".html";
        File resultLoc = Engine.saveResultHtml(this.outputDir, result, resultFile);

In side of executeFeatureSync seems to be only deal with tag and does not set environment..
public static FeatureResult executeFeatureSync(Feature feature, String tagSelector, CallContext callContext) {
        FeatureContext featureContext = new FeatureContext(feature, tagSelector);
        if (callContext == null) {
            callContext = new CallContext(null, true);
        }
        ExecutionContext exec = new ExecutionContext(System.currentTimeMillis(), featureContext, callContext, null, null, null, null);
        FeatureExecutionUnit unit = new FeatureExecutionUnit(exec);
        unit.run();
        return exec.result;
    }

Am I in the wrong track?

@jlee70 ok done, BTW it would have worked if you did System.setProperty('karate.env', 'foo')

@jlee70 ah you are right - and I kind of guessed you needed concurrent. let me know if it works !

@jlee70 great ! yes. I'm not very keen on a web-ui right now and you should consider open-sourcing.
BTW not sure if you knew this - but I had gone the web route before landing on the JavaFX UI, you should be able to find the code: https://twitter.com/ptrthomas/status/861249247282319360

yes, i tried and looked at that side. I was not sure about the future of javafx and for my purpose was the quick verification of the deployment, so minimizing complexity of the verification was one of the key parts. I can see the feature is composable and runnable without jar deployment. So maybe editable test and configuration might be next round to look at it.
Again, truly appreciate your effort and karate project. thank you.


CADL+DPG: caculate cadl project in unified pipeline

https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/pullrequest/430433


Fix Issue # conteinerView is changing to white during transition

exampleTransparent.zip

I just want to specify background color by my own, and not to set navigationBar superview to this etc.

Before and after going back from navigation bar using transparent background..

More you will find in example ...

Thanks, I understand what you mean, but I still have a question that how to change the background color of the container view if I merge the pr.

Same way as UIViewController - preferredStatusBarStyle is working, you are going to subclass from UINavigationController and implement - (UIColor *)km_containerViewBackgroundColor { return [UIColor clearColor];} in subclass

I got it, please delete the redundant blank lines, then I will merge the pr.

Done

Thanks, @m1entus!

Can you update pods ?

Done! The latest version is 0.0.4.


Nutrition Information

It'd be great to specify the nutrition of each ingredient and have that be tabulated to the total nutrition and per serving nutrition.

This would be great. If calculations from input macronutrient data (protein, lipid, carbs) are possible in the program then they could be converted to approximate caloric content using Atwater factors.

Yeah, definitely this was one of my biggest motivators to start Cooklang. It's paradoxical that while the nutrition balance is so important for the health, we have very little feedback on how we're doing.
Slowly we're getting there. But first we need to figure out different units and ingredient density.


I wish /docs/user-guide/downward-api/ had more thorough documentation about the structure of the dataset that fieldPath expressions are evaluated against.

I wish /docs/user-guide/downward-api/ had more thorough documentation about the structure of the dataset that fieldPath expressions are evaluated against.

/docs/user-guide/downward-api/ has been updated and relocated here:
https://kubernetes.io/docs/tasks/inject-data-application/downward-api-volume-expose-pod-information/
I think the link to the ref page for DownwardApiVolumeFile addresses the concern here.


change alpakka to pekko.connectors prefix for config names and package names

also removed replaced alpakka in package names because the text replace was easier this way
org.apache.pekko package name move (instead of akka) would be better done when we uptake the pekko core libs

@mdedetrich I'm not looking for an immediate review of this PR - just some advice. Would it be better if I expand this PR to include the pekko core jar uptake and org.apache.pekko package renames than to wait for this PR to be reviewed on its own?

I do think its preferable to include the updated packages in both pekko core and pekko http so that we only need a single PR to change the packages from akka.stream.alpakka.* to org.apache.pekko.stream.connectors.*

Note that its likely that you will have to wait for the various renames to land in pekko-http in order to use the updated pekko core because of the usage of package private, this is the same issue that I had to deal with in pekko-http.

I remember now why I didn't want to upgrade the jars and package names yet - not only does this repo depend on akka-http but also akka-grpc. By the time, pekko-grpc is ready, this PR is likely to be conflicted and hard to fix up.
I'll leave this PR for now and may end up abandoning it. It may be easier just to start again in a few weeks.

@mdedetrich @nvollmar would either of you have time to review this? I know the diff is large. There are a lot of doc references to Akka/Alpakka but I want to leave them to a dedicated doc PR. The test failures match those that are broken in main branch already (see #41).

Sure, waiting for this to continue switching pekko-persistence-cassandra :)


Remove heap allocations when flushing the nodes or cached leaves

Address issue https://github.com/utreexo/utreexod/issues/195

Learning about golang "escape analysis".  I tried a building with  -gcflags="-m", and shows that my changes from calling "make" to declaring a var, are not helping.  For example, func (m *NodesBackEnd) dbPut (line 74:80)

blockchain/utreexoio.go:74:7: leaking param content: m
blockchain/utreexoio.go:75:6: moved to heap: buf
blockchain/utreexoio.go:78:2: moved to heap: serialized

My other change, adding ClearMaps doesn't allocate to the heap:

blockchain/internal/utreexobackends/cachedleavesmap.go:126:7: leaking param content: ms
blockchain/internal/utreexobackends/cachedleavesmap.go:130:16: make([]map[utreexo.Hash]uint64, len(ms.maxEntries)) escapes to heap
blockchain/internal/utreexobackends/cachedleavesmap.go:132:20: make(map[utreexo.Hash]uint64, ms.maxEntries[i]) escapes to heap
blockchain/internal/utreexobackends/cachedleavesmap.go:139:7: leaking param content: ms
blockchain/internal/utreexobackends/cachedleavesmap.go:153:7: leaking param content: ms

Ran memory profiling on 853aa68d vs current master. Verified that the memory profiling does show that there's less overhead for 853aa68d.
Before:

After:


Add buildx support for build-docker.sh

What changes are proposed in this pull request?
Fix https://github.com/Alluxio/alluxio/issues/16821
Developers can execute cross compare with build-docker.sh
etc.
./build-docker.sh buildx linux/arm64
Why are the changes needed?
Nope.
Does this PR introduce any user facing changes?
Nope, just for developers.

@beinan Would you like to take a look~Thanks♪(･ω･)ﾉ

in case others are using the same script, can we preserve backwards compatibility by setting the most common default value for build_mode and platform, such that if the script was called as before (ex. dev/scripts/build-docker.sh path/to/tarball) it will still operate as before?

Makes sense, I'll modify it

in case others are using the same script, can we preserve backwards compatibility by setting the most common default value for build_mode and platform, such that if the script was called as before (ex. dev/scripts/build-docker.sh path/to/tarball) it will still operate as before?

in case others are using the same script, can we preserve backwards compatibility by setting the most common default value for build_mode and platform, such that if the script was called as before (ex. dev/scripts/build-docker.sh path/to/tarball) it will still operate as before?

Before this PR, build-docker.sh does not support setting parameters, so there is no backward compatibility issue on parameters. After the second commit is modified, it will be consistent with the previous image tag without specifying buildx.

alluxio-bot, merge this please


Support for mov video type

Mov format is uploaded as an image instead of a video.
As mentioned here https://github.com/PLhery/node-twitter-api-v2/issues/456
I added the type and checks

Thank you

Published in 1.14.3

Thanks a lot for your quick release 🚀
Just removed my tmp patch-package and posting .mov videos works fine now 🙌


Python Script V0: ##[error]The given path was not to a file: 'D:\a\1\s

Here's the YAML snippet for v0.147 of the task:
- task: PythonScript@0
  inputs:
    #scriptSource: 'filePath' # Options: filePath, inline
    #scriptPath: # Required when scriptSource == FilePath
    #script: # Required when scriptSource == Inline
    #arguments: # Optional
    #pythonInterpreter: # Optional
    #workingDirectory: # Optional
    #failOnStderr: false # Optional

In YAML, if you specify script but don't specify inline, you'll get a confusing error:
##[error]The given path was not to a file: 'D:\a\1\s'.
Currently, the correct way to use the task in YAML is to specify scriptSource: inline, but the error does not make this clear.
This is some YAML-unfriendliness left over from the task being made for classic editor.  If script is set, the task should infer inline.

This issue is stale because it has been open for a year with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days


pass sha from build step to push step

Summary
For some reason in a workflow, the 'github.sha' variable is changing from the sha of HEAD of the branch, to HEAD of main.  So now we pass the sha via an env variable.
Testing steps
merge and see if it pushes to the build repo

This failed CI, but should be unrelated.  going ahead and merging to try to get prod builds going


vm created by ISO cannot resize the root disk size

ISSUE TYPE

Bug Report

COMPONENT NAME

CLOUDSTACK VERSION

<IP_ADDRESS>

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

VM created by ISO cannot resize the root disk size.
Error:
Failed to resize Root volume. The service offering of this Volume has been configured with a root disk size; on such case a Root Volume can only be resized when changing to another Service Offering with a Root disk size. For more details please check out the Official Resizing Volumes documentation.
VM created by tempalte can resize root disk size.
https://github.com/apache/cloudstack/pull/4341
My serviceoffering not set rootdisksize item
STEPS TO REPRODUCE

1. Create serviceoffering, name=iso-1c-1g, (do not set rootdisksize.)
2. Deploy the VM using ISO, name=iso-vm01, and use serviceoffering=iso-1c-1g.
3.stop vm iso-vm01.
4.resize iso-vm01 root disk size to 100G(size=120&id=ebe7be07-5276-4e38-8563-64d47ae83972&command=resizeVolume&response=json)

EXPECTED RESULTS

vm root disk size changed to 120G

ACTUAL RESULTS

Task execution failed
The root disk size has not changed.

API throws an error:
Failed to resize Root volume. The service offering of this Volume has been configured with a root disk size; on such case a Root Volume can only be resized when changing to another Service Offering with a Root disk size. For more details please check out the Official Resizing Volumes documentation.

@Pearl1594 can you check if your PR/fix addresses the case of ISO?

@rhtyd I've added a fix to allow resizing of Root volume of a VM deployed from an ISO - https://github.com/apache/cloudstack/pull/4829/commits/1c3fc3c57621f003aaefbabae73d8f43fa0ee523.

I verified the commit https://github.com/apache/cloudstack/commit/1c3fc3c57621f003aaefbabae73d8f43fa0ee523
It solved the problem.
thank @Pearl1594  @rhtyd

@Pearl1594 is that commit part of your PR or already merged?

It's part of PR https://github.com/apache/cloudstack/pull/4829 - which hasn't yet been merged. Would you prefer me raising a separate PR to fix this? @rhtyd

Fixed in https://github.com/apache/cloudstack/pull/4829


Potential Error in Blog of Week 0

Hey Raviraj, great work. I am learning a lot.
In the week 0 blog post, you mentioned the following:
As an example, I will be implementing EarlyStopping callback. This helps the model not to overfit by mointoring on a certain parameter (val_loss in this case) The best model will be saved in the dirpath.
But in the code, you have used ModelCheckpoint callback and did not use EarlyStopping. I believe EarlyStopping and ModelCheckpoint callbacks are two completely different callbacks. Please correct if I am wrong. Thanks.

Hi @VirajBagal , thanks for pointing it out. You are correct it is ModelCheckpoint callback, not an EarlyStopping callback. Fixed it. Please check it out now.


Check if a number is palindrome or not in javascript problems

@vyasriday Can I work on this issue ?

Sure @aman-agrwl

I am interested in contributing, can we still contribute to this issue or is it already done ?

I want to contribute. Can you please confirm if this issue is solved or I can work on it?

@suyash2819 @Vaibhavgupta05 Pleaes check if there is relevant PR or the code exists. If not they you can raise a PR with your code. Multiple ways of doing so  are allowed

@vyasriday i have added a number palindrome code in palindrome file itself, i am converting number to string then showing iteration to show comparison of reverse and the numbered string which was not there in that file. Please let me know if this is relevant.

@suyash2819 Please don't use string conversion as such code already exists for strings.

@vyasriday but my function is for numbers and will accept number as a parameter, then i am converting number to string, wouldn't that be counted as a different approach just for numbers ? since we are not converting numbers to string anywhere in code.


Revert "feat: fist release version"

Reverts yurnov/ua-explosion-notification-bot#1

I'm not considering pylint in development branch even it's included into main, need to fix prior merge


Could not find method implementation

"react": "16.3.1",
"react-native": "0.55.4",
"react-native-fast-image": "^5.0.11",

How to solve?

If you upgrade your version of React Native (including your Gradle version) then implementation will work. implementation replaces compile in newer versions of Gradle. If this change is not made in this library then it eventually will stop working for new versions of React Native.


Avoid potential pitfalls of regex.exec() during variables evaluation.

This change may addresses item #3469
This changes how variables are being expanded (file: expand.ts)
The following changes are proposed:

Avoid using regexp.exec() which may lead to infinite loops, use string.matchAll() instead.
Add more logging for exceptional conditions that may lead to failures while expanding variables.

@lukka Don't forget about a changelog update, thanks!

@lukka Don't forget about a changelog update, thanks!

Done!


getting better at open source: make mathsteps easier to contribute to and maintain

I'd like to continue to make mathsteps better in the open source community: more people finding us and wanting to help, easier for people to get started, fun for people to keep contributing, easier for maintainers to maintain, etc.
A lot of these tasks can be done by anyone, so if you'd like to help out lemme know!
I found https://opensource.guide/ which looks amazing, and am taking notes on stuff I'd like to do:

[ ] Update README

make it clearer what mathsteps does and why it's helpful
acknowledgements to author/contributors/mathjs
link to the further documentation in the wiki
more resources: https://pages.18f.gov/open-source-guide/making-readmes-readable/ and https://gist.github.com/PurpleBooth/109311bb0361f32d87a2

[ ] document npm releases on github by using tags (e.g. https://github.com/PurpleBooth/git-lint-validators/releases)

[ ] update CONTRIBUTING

should we also put installation instructions here (it's already in the README) ?
link to the roadmap from the wiki
add some more stuff from https://github.com/nayafia/contributing-template/blob/master/CONTRIBUTING-template.md and http://mozillascience.github.io/working-open-workshop/contributing/

[ ] issue and pull request templates if we find certain a certain structure that makes sense and would help (I can't think of one right now)

Read more:

[x] https://opensource.guide/starting-a-project/
[ ] https://opensource.guide/finding-users/
[ ] https://opensource.guide/building-community/
[ ] https://opensource.guide/best-practices/
[ ] https://opensource.guide/leadership-and-governance/
[ ] maybe https://opensource.guide/getting-paid/
[ ] https://opensource.guide/metrics/
[ ] look into ways to support contributors and help them become long term contributors

I will look into this !

oh, and feel free to comment here anything else to add to the list!

I think I can make a github page or something for enhancing the wiki ! What do you think?

what do you mean by a "github page"? and I'd love to enhance the wiki :)

I mean setting up a gitbook like thing (see this) or setting up a static page (using Jekyll and Github).

If you want to keep wiki compact then I'd say we should go for GitHub Pages or for a more detail explanation GITBOOK is awesome......!!!

whoaaa gitbook looks great! let's move this conversation to #66

@evykassirer I've made some changes to the PR (mathsteps-demo) and I was thinking of adding the docs and contributing guide to website. Let me know what you think!

ah sorry Nitin! Let me look at your current PR - I've been a bit busy but I'll look either tonight or in the next day or two.
Did you want to add the current docs or write some new ones? If we're doing something new, let's talk about it first to make sure we're on the same page :)

If we're rewriting the core than it doesn't makes sense to render the old docs. I want to jump in where new changes are happening. Let me know where I can start! Also if there is some other stuff or some other issues to work on, let me know! I'll be happy to contribute more 😀!

sounds good!
I'm gonna explore what we need to do for the refactoring stuff within the week (hopefully!) and we can get started from there - I'm still not totally sure what the work will involve and what the issues that need tackling will be, and it'd be nice to have more concrete tasks before we start working on it - and it'd be nice to get a few people taking on tasks if possible so I think you can help with it!
In the meantime, you could check out the semantic math repo and start familiarizing yourself with it - especially math-parser and math-rules. We might need to add some stuff there too, and there's a bunch of open issues there as well.

I was thinking about replacing the current test suite with Jest!

Sorry for the delay - I'm happy to look into that once I'm done with the refactor (hopefully will finish in the next two weeks, I'm planning to sink a bunch of time into it!)
Thanks for suggesting it - I'll open an issue for now :)

Welcome back! 😜


Considering smaller format for control_data

I just saw that your control_data folder already has a size of > 130 MB, with 1.6 MB per file in the .npy format, which is huge!

In comparison, a png file rendered in low quality has only around 0.01 MB per file.
So what I want to say: On the long run, probably we should change to another format for the test of comparison data, otherwise the repo might grow quite large.
An svg file would have around 0.004 MB, so in case of manim should support SVG output one day, I'd say we can then switch to that format for the test control_data.
One more thing to note: there is software to clean up the git history and delete certain big files from it while not breaking other things, so we don't have to worry too much right now.

Good catch. cc @ManimCommunity/tests
We can't output SVG now, and something tells me that this will become an actual problem way before we output to SVG.
The problem with PNG is that we can't compare that to anything that we have in-memory.
All I can think of now is make the test animations smaller than usual, and maybe even remove the alpha channel. This way we could immediately reduce the size by half.

Thanks for pointing out this.
As @leotrs said, I don't see any better option. We could use hash instead, but it would make the tests very very hard to debug, which is bad.
About using svg, I'm not certain if it would be possible, as the essence of the tests is to compare the raw frame (before any post processing, compression, etc..).
If there is an optimisation to be done, maybe it's the alpha channel, as proposed.
it's kind of important to find a solution if we want to implement more reobust graphical unit tests that would test several frame of a movie instead of the last one (as it is now).
If you come up with new ideas, feel free!

I have an idea, we can use compressed NumPy arrays.
As we have lots of monochrome spaces and only a few colours that we use in our scenes, instead of np.save, we can use np.savez_compressed!
import numpy as np

ar=np.load("GrowFromCenterTest.npy")
np.savez_compressed('test', my_ar = ar)
loaded_ar = np.load('test.npz')["my_ar"]
print(np.array_equal(ar, loaded_ar))

The output of this script is "True".
And the size of the array went down from 1.6MB to 2,5 kB!
This could be also of use when testing the videos. np.savez_compressed works a little bit like a dict, were more then one array can be compressed simultaneously:
np.savez_compressed('/tmp/123', my_ar1=ar1, my_ar2=ar2, my_ar3 = ar3 )

Compressed arrays is a good idea!
Another idea is to store everything in grayscale. You can go from four channels (RGBA) to just one (grayscale). If you reduce the size of each test to half the number of pixels, that's a total of 8x reduction.

This seems good to me.
I think we'll use this feature of compressing sceveral arrays when out graphival tests will use several frames.

See #618 for further discussions.

I would really like to see us using compressed control data as soon as possible. Could we talk about implementing this as soon as possible? If it helps (and noone else wants to do it), I can PR this later today.
Rewriting git history is an extremely delicate process that requires a huge amount of coordination (basically, the fewer open PRs we have at that point the better; and everyone will have to adapt their local clones as well). Changing to compressed data sooner rather than later is a good idea to make sure we keep the repo size manageable until we actually rewrite the history.


Updating wishlist for future contributors.

Description
Please include a short summary of the change.
As per the discussion here, this PR updates the Wishlist with new projects under the contributing page of the documentation.
Type of change

[ ] New feature (backwards compatible)
[ ] New feature (breaking API changes)
[ ] Bug fix
[x] Other (Documentation, CI, ...)

Contribution checklist

[x] Add our license to new files.
[x] Check that your code adheres to our coding style.
[x] Write unittests.
[x] Run the unittests and check that they’re passing.
[x] Run the benchmarks to make sure your change doesn’t introduce a regression.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Transurgeon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I think we should have explicit instructions on how to contact us to discuss the bigger projects. Some of them have prototypes and others we at least have design ideas.
Something like "If you're interested in working on a bigger project, join the Discord and let us know! We'll be happy to provide guidance and advice."


⚠ Bofrost.de has degraded performance

In 55749f6, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1564 ms

Resolved: Bofrost.de performance has improved in 4f7eb26 after 1 hour, 24 minutes.


Corrected spelling mistakes.

My first pull request :)

Welcome! I've merged your changes. Feel free to add your user name to the Contributor list


Incompatible change in binary-compatibility-validator since 0.10.0

Hi,
Since 0.10.0 task ApiCompareCompareTask that you are relying on was renamed to KotlinApiCompareTask

Thanks for raising! I will fix it.


How to determine if setPosition will place windows in visible screen?

There does not seem to be a method for determining the available visible screen resolution, so if you wish to restore the window to the previously set size/position, you cannot be sure that you're not restoring it to some off-screen location (in cases where the user has a 2nd screen on a laptop, but is currently not connected).
What solution would you propose for either a) determining the screen resolutions have changed, or b) ensuring you are not restoring the window to an invisible location?

+1 Any way to determine available visible screen size?

window_manager using screen_retriever To retrieve the visible screen size and coordinates of the screen, I think this package should be able to solve your problem.


Unresolved reference: embedding

Flutter and android mixed development, android is opened with Android Studio alone,
but import io.flutter.embedding.android.FlutterActivity prompts Unresolved reference: embedding  (Cannot resolve symbol 'embedding').
doctor:
flutter.bat doctor --verbose
[√] Flutter (Channel stable, 2.8.1, on Microsoft Windows [Version 10.0.22563.1], locale zh-CN)
    • Flutter version 2.8.1 at D:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (3 months ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\10338\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[√] IntelliJ IDEA Ultimate Edition (version 2021.1)
    • IntelliJ at D:\idea\IntelliJ IDEA 2021.1.2
    • Flutter plugin version 63.2.2
    • Dart plugin version 211.7798

[√] VS Code (version 1.63.2)
    • VS Code at C:\Users\10338\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.21.0

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 96.0.4664.110
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 98.0.1108.62

• No issues found!
Process finished with exit code 0

@ddxl123
Check this solution and see if it helps.


NSURLCache deadlock Tests

This pull request should put the CI back to green.

@segiddins all green 🎉


Git pull help

hi ive seen a lot of comments relating to "git pull" can someone explain to me what it is?

http://lmgtfy.com/?q=git+pull


Add User story

Codecov Report

Merging #107 (4d40e99) into master (50a2477) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #107   +/-   ##
=========================================
  Coverage     55.28%   55.28%
  Complexity      557      557
=========================================
  Files            97       97
  Lines          2590     2590
  Branches        370      370
=========================================
  Hits           1432     1432
  Misses          924      924
  Partials        234      234

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


NamedModulesPlugin for HMR

Currently the HMR shows updated modules with numbers in the console. This provides little feedback and in this way you even get a suggestion to install the NamedModulesPlugin.
What I mean:
https://github.com/react-boilerplate/react-boilerplate/issues/719
I feel like this could be a useful enhancement.
I have already added it like so to my mix.webpackConfig object:
plugins: [
        new webpack.NamedModulesPlugin(),
        // prints more readable module names in the browser console on HMR updates
    ]

This is ok but to prevent the suggestion from popping up on the console and to provide prettier output(can probably strip off a bit of the path) I feel it would be justified incorporating this into this project.

Sure. If anyone wants to submit a PR, that'd be great.

Merged.


Detects no installations or mods

When running the executable, the resulting window looks like this (with the drop-down open):

This appears to be a known issue, per this reddit thread, but since I didn't see it listed here, I thought I'd add it for everyone's convenience.

It because of nuget version is not supporting v17 of mod file and it just cant read files, crashing and cant load mods list. Already 2 years as the issue about v17 was created and it must be implemented but for some reason it still cant read v17 headers and reporting about invalid mod files. I intentionally checked it by replacing dependency to my edited versions with v17 compatibility and all is working, the mods load order is loading and displaying. But I see there missing scrollbar and not all mods is displayed.


Mirage: You're instantiating a foo that has a barId of bar, but that record doesn't exist in the database.

I am getting an error from Mirage when I have a field which ends with *Id and there is a matching belongsTo relationship field on the model.
E.g.
// Parent model: foo.js
import DS from 'ember-data';
export default {
  barId: DS.attr('string'),
  bar: DS.belongsTo('bar')
};

//Child model: bar.js
import DS from 'ember-data';
export default {
  baz: DS.attr('string'),
};

And my factory for foo.js
import { Factory } from 'ember-cli-mirage';

export default Factory.extend({
  // Setting value of barId throws error.
  //barId: 'something'
});

I have found the culprit of this error in repository: https://github.com/samselikoff/ember-cli-mirage/blob/5a40018951c7d5db2245c27ae364972cdc88ce60/addon/orm/associations/belongs-to.js#L33
As it is trying to pull up relationship which does not exist in store and throws an exception Mirage: You're instantiating a foo that has a barId of bar, but that record doesn't exist in the database.

I'm experiencing the same issue. Is there a workaround other than renaming my model's properties?

Unfortunately I decided to rename property name to bypass this issue. Not
idea & long term fix but got me unblocked in this scenario.
On Wed, Feb 21, 2018 at 3:09 PM, Alex<EMAIL_ADDRESS>wrote:

I'm experiencing the same issue. Is there a workaround other than renaming
my model's properties?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/samselikoff/ember-cli-mirage/issues/1231#issuecomment-367509795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFY_KhySAy__51AWuQLa8sWuZqN98Q9uks5tXKI_gaJpZM4QxwyL
.

Sorry about the delayed response!
Assuming that barId is in fact bar.id, I would avoid storing a separate barId field in Mirage's database, and instead use the serializer layer to add the field at serialization time, derived from the actual bar relationship. That way the two will never be out of sync.
You'll also need to do some work on the receiving end if you're going to take data from a request payload and CRUD your Mirage models. I would use normalizedRequestAttrs() for this, and then strip the barId from the request.
Can I ask how you're using barId? Typically you'd access the id of a relationship in Ember via this.get('bar.id'), and I think you'll save yourself a lot of headache if you structure things like that.

Closing this issue for now but let me know if you have any more questions!


feat(ci): workflow for release

Is there an existing issue?

[X] I have searched the existing issues

Motivation
We need an action workflow to automate the release
Request
This workflow should handle:

automatically create a release on GitHub when a tag is pushed
update documentation

Solution
No response
Are you willing to help with this request?
Yes!

Reviving this issue to tell the following path that was decided internally:

Merge this PR to upgrade docker
Merge Adel fix on ChainConfigs
Merge a workflow to build a docker image on each releases
Release v0.7.0

done in #290


Add code for RAFT

Hi, I recently read a paper ( Run Away From your Teacher: a New Self-Supervised Approach Solving the Puzzle of BYOL ) expanding the work on self-supervised algorithms and providing new perspective on the BYOL methodology. By reading the paper, i thought it would have been quite easy to implement their proposal in a usable version, using this repository as a base.
If anyone seeing this PR have read the paper in question, or want to take a look at it, you can have a look at the alignment_loss and cross_model_loss function, as well as the forward method in the RAFT class, and verify that the implementation agrees with the description on the paper. Everything looks in order to me, but some confirmation never hurts.
The only slight concern i have about this PR is that it may be beyond the scope of this repository, which would resemble a collection of BYOL-related paper implementations. @lucidrains the decision is up to you, but since 99% of the code is shared between this RAFT implementation and the BYOL one, i decided to make a PR instead of just copy-pasting all your code to a brand new project.
Another notable implementation detail is that i changed the loss_fn's name to byol_loss in order to avoid confusion and maintain a consistent naming with raft_loss.
What follows is the commit message, GitHub pasted this here automatically so i might as well leave this here:
Add implementation for the algorithm described by the paper
"Run Away From your Teacher: Understanding BYOL by a Novel
Self-Supervised Approach" ( https://arxiv.org/abs/2011.10944 )
The RAFT class is essentially a copy-paste of the BYOL class,
with slight changes to the forward method, which computes a
different loss functionm making use of the new raft_loss
function. RAFT's loss is the difference of two losses: an
"alignment loss" between the projection of two different
augmented views of the same image, to be minimized, and the
"cross-model loss", to be maximized, which is the distance
between the online and target representation of the same input,
averaged over the two different views.
Tell me what you think :)

A weird thing i noticed is that since we're supposed to maximize the alignment loss, and minimize the cross-model loss, is that the loss is quite prone to being negative, since both losses are a positive quantity, and their difference is negative when one is greater than the other (the difference in question is thing_to_minimize - thing_to_maximize).
Does anyone more experienced than me have some trick to deal with this? Should i consider this a problem at all? Intuitively, i think it's a problem, because the optimizer tries to minimize the loss, and not move it towards zero as we'd like it to, so the loss would just approach negative infinity as the training goes forward.
Since the paper's authors define the RAFT loss as being actually a linear combination of the two losses, i just scaled the cross-model loss by 0.5 in my code and this suffices to get a positive loss, but i think hard-coding a magic number isn't going to be a universal solution.
Another trick could be to just take the absolute value, or a positive power of the loss, but i don't know if it is mathematically sound

@umbertov hello, I think there's no need to create separate methods for alignment and cross-model loss calculation. As far as I understand, the original loss_fn can be used for both.


add Data Natives Vienna meetup information

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add KUDO talk details for data natives Vienna meetup
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zmalik
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gerred
If they are not already assigned, you can assign the PR to them by writing /assign @gerred in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yankcrime, zmalik
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gerred
If they are not already assigned, you can assign the PR to them by writing /assign @gerred in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kensipe, yankcrime, zmalik
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kensipe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm


Packaging request: pyglossary

Project description
A tool for converting dictionary files aka glossaries with various formats for different dictionary applications.
Metadata

homepage URL: https://github.com/ilius/pyglossary
source URL: https://github.com/ilius/pyglossary/releases/tag/4.0.11
license: gpl3Plus
platforms: unix

have you looked into poetry2nix ? python ecosystem is huge and while I packaged a few python libraries for nix, I've started using poetry and it seems like a nice solution.

Still wanted.

Still wanted.

Still nice to have.


1.0 TransitionHook docs describe wrong param for routerWillLeave

routerWIllLeave's second param is actually a transition object, not a router object. At least in React Router 1.0-beta3.

api changed, but this prompted some clarity, thanks :) b567174e9a58060405234980dc7e0f281e5731ed


KBR - The message "Romania is not a city in Romania" is displayed on scrapers.peviitor.ro

ENVIRONMENT: production
URL: https://scrapers.peviitor.ro/
Browser: Chrome
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:
1.Open the URL in the browser
2.Run scraper for " KBR" Company
3.Check the location for all the 5 jobs
4. Run scraper on https://careers.kbr.com/us/en
5. Check the location for all the jobs
EXPECTED RESULTS:
Jobs must have a city as a location
ACTUAL RESULTS:
The message "Romania is not a city in Romania" is displayed on scrapers.peviitor.ro for the following jobs:
-LCV EUCOM Romania: Operations Coordinator

LCV EUCOM Romania: Logistics Warehouseman
LCV EUCOM Romania: Food Services, Lead
LCV EUCOM Romania: Logistics Warehouse Foreman
LCV EUCOM Romania: Sous Chef
On the company website, the location of the jobs hasn't a city specified. Mentioned only Romania
https://careers.kbr.com/us/en

fixed on pull request 434.
Re-test after pull request is merged.

assign me when the434 is merged


Remove superfluous help markup

This just removes an extra < in the help file.

Thanks for the patch!