How do you sort products by the criterias specified in the shopify docs using the client?

I have this query to fetch the products which is working fine:
const fetchProductsWithVariants = (
  client,
  productQty = 10,
  variantQty = 10,
  imagesQty = 10,
  collectionQty = 5
) =>
  client.query(root => {
    root.add("shop", shop => {
      shop.add("name");
      shop.addConnection(
        "products",
        { args: { first: productQty } },
        product => {
          product.add("id");
          product.add("title");
          product.add("description");
          product.addConnection(
            "variants",
            { args: { first: variantQty } },
            variant => {
              variant.add("id");
              variant.add("title");
              variant.add("price");
              variant.add("image", image => {
                image.add("src");
                image.add("id");
                image.add("altText");
              });
            }
          );
          product.addConnection(
            "images",
            { args: { first: imagesQty } },
            image => {
              image.add("src");
            }
          );
          shop.addConnection(
            "collections",
            { args: { first: collectionQty } },
            collection => {
              collection.add("id");
              collection.add("title");
              collection.add("image", image => image.add("src"));
            }
          );
        }
      );
    });
  });

My question is, how do I sort those products by price or any other criteria? I think it's necessary to complete the docs since it barely has information on how to achieve a lot of things that you can do with raw queries

@juanlet do you find way to sort ?

@juanlet Prices are not serialized on Product resources. Do sorting by price within Application

@magic-77 how to make query for sort?

Hi @PayalDinc i don't use Shopify GraphQL sorting, but this should do the job
collections(first: 10, sortKey:UPDATED_AT, reverse: true)

see here
https://help.shopify.com/en/api/custom-storefronts/storefront-api/reference/enum/productsortkeys

@magic-77  that the query of storefront API. But how to make query using graphql-js-client package?

Finally, I got the solution. Here it is
  queryForSortedProducts = (collection, limit, cursor,sortKey)=>{
        console.log('cursor = '+cursor)
        let collectionQuery = this.client.query((root) => {
            root.add('node', { args: { id: collection }, alias: 'collection' }, (node) => {
                node.addInlineFragmentOn('Collection', (collection) => {
                    collection.add('title');
                    collection.addConnection('products', {
                        args: {
                            first: limit, after: cursor, sortKey: this.client.enum('PRICE')
                    }} , (products) => {
                        products.add('id');
                        products.add('title');
                        products.addConnection('variants', { args: { first: 1 } }, (variants) => {
                            variants.add('price');
                            variants.add('compareAtPrice')
                        });
                        products.addConnection('images', { args: { first: 1 } }, (images) => {
                            images.add('src');
                        })
                    })
                })
            })
        });

        console.log("sorted collectionQuery = " + collectionQuery)
        return collectionQuery

    }

Have to pass sort key as this.client.enum('PRICE'),


Correctly include all modules during build

Motivation:
To ensure the release plugin works correctly we need to ensure all modules are included during build.
Modification:

Include all modules
Skip compilation and tests for native code when not supported but still include the module and build the jar

Result:
Build and release works again

Cherry-picked into 4.1 (9e62c79574)


The provided entity includes an unknown attribute - 'availableInNewTerritories' is not an attribute on the resource 'apps' - /data/attributes/availableInNewTerritories

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Running fastlane 2.217.0 and  2.219.0 fail uploading.
Upload used to work until today. No changes have been made to the script or store settings.
Command executed
Complete output when running fastlane, including the stack trace and command used
/usr/local/bin/fastlane ios upload build:/Users/agent00/BuildServer/production/_current-artifacts/FlowerGarden-2.74.0-ios-store-469747-build.ipa metadata:/Users/agent00/BuildServer/production/_current-artifacts/metadata review:false submit:false package:dk.tactile.lilysgarden org:tactile_games_aps --verbose

2024-01-18 13:10:25,106 [INFO]: INFO [2024-01-18 13:10:25.10]: Uploading app review information to App Store Connect
2024-01-18 13:10:26,893 [INFO]: INFO [2024-01-18 13:10:26.89]: Setting the app's age rating...
2024-01-18 13:10:28,241 [INFO]: INFO [2024-01-18 13:10:28.24]: App has no prices yet... Enabling all countries in App Store Connect
2024-01-18 13:10:31,269 [INFO]: WARN [2024-01-18 13:10:31.26]: Lane Context:
2024-01-18 13:10:31,272 [INFO]: INFO [2024-01-18 13:10:31.26]: {:PLATFORM_NAME=>:ios, :LANE_NAME=>"ios upload"}
2024-01-18 13:10:31,273 [INFO]: ERROR [2024-01-18 13:10:31.26]: The provided entity includes an unknown attribute - 'availableInNewTerritories' is not an attribute on the resource 'apps' - /data/attributes/availableInNewTerritories
2024-01-18 13:10:31,274 [INFO]: The provided entity includes an unknown relationship - 'prices' is not a relationship on the resource 'apps' - /data/relationships/prices
2024-01-18 13:10:31,274 [INFO]: The provided entity includes an unknown relationship - 'availableTerritories' is not a relationship on the resource 'apps' - /data/relationships/availableTerritories
2024-01-18 13:10:31,283 [INFO]:
2024-01-18 13:10:31,285 [INFO]: +------------------------------------------+
2024-01-18 13:10:31,285 [INFO]: |             fastlane summary             |
2024-01-18 13:10:31,286 [INFO]: +------+---------------------+-------------+
2024-01-18 13:10:31,286 [INFO]: | Step | Action              | Time (in s) |
2024-01-18 13:10:31,287 [INFO]: +------+---------------------+-------------+
2024-01-18 13:10:31,288 [INFO]: | 1    | update_fastlane     | 0           |
2024-01-18 13:10:31,288 [INFO]: | 💥   | upload_to_app_store | 27          |
2024-01-18 13:10:31,289 [INFO]: +------+---------------------+-------------+
2024-01-18 13:10:31,290 [INFO]:
2024-01-18 13:10:31,291 [INFO]: ERROR [2024-01-18 13:10:31.28]: fastlane finished with errors
2024-01-18 13:10:31,291 [INFO]:
2024-01-18 13:10:31,292 [INFO]: Looking for related GitHub issues on fastlane/fastlane...
2024-01-18 13:10:31,292 [INFO]: Search query: The provided entity includes an unknown attribute - 'availableInNewTerritories' is not an attribute on the resource 'apps' - /data/attributes/availableInNewTerritories
2024-01-18 13:10:31,292 [INFO]: The provided entity includes an unknown relationship - 'prices' is not a relationship on the resource 'apps' - /data/relationships/prices
2024-01-18 13:10:31,293 [INFO]: The provided entity includes an unknown relationship - 'availableTerritories' is not a relationship on the resource 'apps' - /data/relationships/availableTerritories
2024-01-18 13:10:31,293 [INFO]:
2024-01-18 13:10:31,293 [INFO]: URL: https://api.github.com/search/issues?q=The%20provided%20entity%20includes%20an%20unknown%20attribute%20-%20%27availableInNewTerritories%27%20is%20not%20an%20attribute%20on%20the%20resource%20%27apps%27%20-%20%2Fdata%2Fattributes%2FavailableInNewTerritories%0AThe%20provided%20entity%20includes%20an%20unknown%20relationship%20-%20%27prices%27%20is%20not%20a%20relationship%20on%20the%20resource%20%27apps%27%20-%20%2Fdata%2Frelationships%2Fprices%0AThe%20provided%20entity%20includes%20an%20unknown%20relationship%20-%20%27availableTerritories%27%20is%20not%20a%20relationship%20on%20the%20resource%20%27apps%27%20-%20%2Fdata%2Frelationships%2FavailableTerritories+repo:fastlane/fastlane
2024-01-18 13:10:31,488 [INFO]: ERROR [2024-01-18 13:10:31.48]: Error finding relevant GitHub issues: undefined method `map' for nil:NilClass
2024-01-18 13:10:31,491 [INFO]: /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/spaceship/lib/spaceship/connect_api/api_client.rb:223:in `handle_response': [!] The provided entity includes an unknown attribute - 'availableInNewTerritories' is not an attribute on the resource 'apps' - /data/attributes/availableInNewTerritories (Spaceship::UnexpectedResponse)
2024-01-18 13:10:31,493 [INFO]: The provided entity includes an unknown relationship - 'prices' is not a relationship on the resource 'apps' - /data/relationships/prices
2024-01-18 13:10:31,494 [INFO]: The provided entity includes an unknown relationship - 'availableTerritories' is not a relationship on the resource 'apps' - /data/relationships/availableTerritories
2024-01-18 13:10:31,496 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/spaceship/lib/spaceship/connect_api/api_client.rb:136:in `patch'
2024-01-18 13:10:31,497 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/spaceship/lib/spaceship/connect_api/tunes/tunes.rb:209:in `patch_app'
2024-01-18 13:10:31,498 [INFO]: 	from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/forwardable.rb:230:in `patch_app'
2024-01-18 13:10:31,499 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/spaceship/lib/spaceship/connect_api/models/app.rb:109:in `update'
2024-01-18 13:10:31,500 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/deliver/lib/deliver/upload_price_tier.rb:38:in `upload'
2024-01-18 13:10:31,501 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/deliver/lib/deliver/runner.rb:161:in `upload_metadata'
2024-01-18 13:10:31,502 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/deliver/lib/deliver/runner.rb:61:in `run'
2024-01-18 13:10:31,503 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/actions/upload_to_app_store.rb:22:in `run'
2024-01-18 13:10:31,503 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/runner.rb:263:in `block (2 levels) in execute_action'
2024-01-18 13:10:31,504 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/actions/actions_helper.rb:69:in `execute_action'
2024-01-18 13:10:31,505 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/runner.rb:255:in `block in execute_action'
2024-01-18 13:10:31,506 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/runner.rb:229:in `chdir'
2024-01-18 13:10:31,507 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/runner.rb:229:in `execute_action'
2024-01-18 13:10:31,507 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
2024-01-18 13:10:31,508 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
2024-01-18 13:10:31,509 [INFO]: 	from Fastfile:47:in `block (2 levels) in parsing_binding'
2024-01-18 13:10:31,509 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/lane.rb:41:in `call'
2024-01-18 13:10:31,510 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
2024-01-18 13:10:31,511 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
2024-01-18 13:10:31,511 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
2024-01-18 13:10:31,512 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/lane_manager.rb:46:in `cruise_lane'
2024-01-18 13:10:31,513 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/command_line_handler.rb:34:in `handle'
2024-01-18 13:10:31,514 [INFO]: 	from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.219.0/fastlane/lib/fastlane/commands_generator.rb:110:in `block (2 levels) in run'
2024-01-18 13:10:31,514 [INFO]: Error uploading to fastlane: 1

Environment

[✔] 🚀
[09:23:26]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[09:23:27]: Generating fastlane environment output, this might take a few seconds...
🚫 fastlane environment 🚫
Stack

Key
Value

OS
13.6.3

Ruby
2.6.10

Bundler?
false

Git
git version 2.39.2 (Apple Git-143)

Installation Source
/usr/local/bin/fastlane

Host
macOS 13.6.3 (22G436)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib

OpenSSL Version
LibreSSL 3.3.6

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode-14.3.1.app/Contents/Developer/

Xcode Version
14.3.1

Swift Version
5.8.1

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.219.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.3.0

artifactory
3.0.15

babosa
1.0.4

colored
1.2

highline
2.0.3

commander
4.6.0

faraday-cookie_jar
0.0.7

gh_inspector
1.1.3

google-cloud-env
1.6.0

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.5

naturally
2.2.1

optparse
0.1.1

rubyzip
2.3.2

security
0.1.3

terminal-notifier
2.0.0

terminal-table
3.0.2

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

public_suffix
5.0.3

addressable
2.8.5

aws-eventstream
1.2.0

aws-sigv4
1.6.1

aws-partitions
1.852.0

jmespath
1.6.2

aws-sdk-core
3.186.0

aws-sdk-kms
1.72.0

aws-sdk-s3
1.136.0

bundler
2.1.4

CFPropertyList
3.0.3

dotenv
2.8.1

emoji_regex
3.2.3

excon
0.104.0

ruby2_keywords
0.0.5

faraday-retry
1.0.3

faraday-rack
1.0.0

faraday-patron
1.0.0

faraday-net_http_persistent
1.2.0

faraday-net_http
1.0.1

multipart-post
2.3.0

faraday-multipart
1.0.4

faraday-httpclient
1.0.1

faraday-excon
1.1.0

faraday-em_synchrony
1.0.0

faraday-em_http
1.0.0

faraday
1.10.3

faraday_middleware
1.2.0

fastimage
2.2.7

webrick
1.7.0

rexml
3.2.6

httpclient
2.8.3

multi_json
1.15.0

jwt
2.7.1

signet
0.18.0

os
1.1.4

googleauth
1.8.1

mini_mime
1.1.5

retriable
3.1.2

trailblazer-option
0.1.2

declarative
0.0.20

uber
0.1.0

representable
3.2.0

google-apis-core
0.11.2

google-apis-androidpublisher_v3
0.52.0

google-apis-playcustomapp_v1
0.13.0

rake
13.0.6

digest-crc
0.6.5

google-apis-storage_v1
0.29.0

google-apis-iamcredentials_v1
0.17.0

google-cloud-errors
1.3.1

google-cloud-core
1.6.0

google-cloud-storage
1.45.0

unf_ext
<IP_ADDRESS>

json
2.5.1

mini_magick
4.12.0

plist
3.7.0

simctl
1.6.10

unicode-display_width
2.5.0

nanaimo
0.3.0

colored2
3.1.2

claide
1.1.0

atomos
0.1.3

xcodeproj
1.23.0

forwardable
1.2.0

logger
1.3.0

date
2.0.3

stringio
0.0.2

ipaddr
1.2.2

openssl
2.1.2

zlib
1.0.0

mutex_m
0.1.0

ostruct
0.1.0

strscan
1.0.0

io-console
0.4.7

fileutils
1.1.0

etc
1.0.1

libxml-ruby
3.2.1

psych
3.1.0

generated on: 2024-01-18

[09:23:32]: Take notice that this output may contain sensitive information, or simply information that you don't want to make public.
[09:23:32]: 🙄  Wow, that's a lot of markdown text... should fastlane put it into your clipboard, so you can easily paste it on GitHub? (y/n)
y
[09:23:43]: Successfully copied markdown into your clipboard 🎨
[09:23:43]: Open https://github.com/fastlane/fastlane/issues/new to submit a new issue ✅

same here

Getting the exact same issue; anyone has a workaround ?

Same as https://github.com/fastlane/fastlane/issues/21819

We eventually solved this by removing price_tier: 0 from our fastlane configuration, and running 2.219.0

Removing price_tier solved this for us as well, but maybe this issue should remain open since one might want to change the price_tier...

Can everyone still set prices after the update

i've tried using fastlane version 2.221.1, 2.219.0, 2.213.0, but still get this error.


Package update

[x] Updated packages to latest version
[x] Added lint rules with analysis_options.yaml
[x] Updated GitHub actions
[x] Removed containers and switched to GitHub actions for setting up Dart SDK

@vkammerer I have updated with latest PR here as requested

Hi @vkammerer any update on this PR?

@lig can you review this PR

This was finally published on pub.dev, under the version 5.0.0-releasecandidate.1


fix(mongoose): remove implicite discriminatorValue declaration on @Model decorator which is not an intended behavior

Closes: #2227

:tada: This PR is included in version 7.13.4 :tada:
The release is available on:

v7.13.4
GitHub release

Your semantic-release bot :package::rocket:


carc.in (play.crystal-lang.org) lies about recursive macro crash

http://carc.in/#/r/j0g

There was no output.

Yeah, right...
I know this is a wontfix, but play.crystal-lang.org should give a better description.

The compiler segfaults. Maybe this should be handled by carc.in and show an error message? Probably https://github.com/jhass/carc.in is a better place to add this issue. @jhass do you agree?

@waj I didn't realize it was a separate repo.

Well, at the end of the day it's a duplicate of #271

@jhass Not really. This is just so carc.in can show a message like "Segmentation fault" or something.

Still not an issue for this repo, so closing ;)


[vue.js] After adding submenus for some pages, src\router\index.ts and src/i18n/index.ts omitted some codes, causing errors.

Describe the bug
code is omitted and cannot work
Link to the Bolt URL that caused the error
https://bolt.new/~/github-ksayce3t
Validations

[X] Please make your project public or accessible by URL. This will allow anyone trying to help you to easily reproduce the issue and provide assistance.

Steps to reproduce
Ask the add new submenu
Expected behavior
Do not omitted the code
Screen Recording / Screenshot

Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 131
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 53101689,
  "usedJSHeapSize": 50810429,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = PaulWuGTK
Chat ID = f34aaf8d144c

Additional context
No response

Issue fixed after entering the following message and pressing the button when encountering an error.
Message:
1. You should not remove some code and replace it to "// ... existing xxxxx ... ", it will makes the code build error.
2. The Sidebar.vue do not have code for Management - NTP.
Can you fix it.
Other errors:
- Code error: Added missing export for getMockStatistics.


Register allocator improvements, including a spiller

Description
This PR includes a spiller for the register allocator and other changes to the algorithm itself.
Fixes #3429, #2657 #4631, #4511.

This is ready for review now. I'm going open new Issue(s) for further related improvements.

A few nitpicks, but LGTM

@vaivaswatha seems like one of the tests might be flaky ...
Failing tests:
    should_pass/unit_tests/regalloc_spill ... failed

I updated Forc.lock for that test and it works now.


MGMT-1355 adding host metrics and cluster installation duration

I added the missing host & installation finished metrics - I'm sending randon int for installation phase - will fix it after https://issues.redhat.com/browse/MGMT-1564 will be done
@ronniel1 @avishayt please review

@ronniel1 I'm willing to pay to merge my code before Ori's task :)


Remote branch v0.1.7 not found in upstream origin

warning: Could not find remote branch v0.1.7 to clone.
fatal: Remote branch v0.1.7 not found in upstream origin


BUG: spaceship_maven:14: bad set of key/value pairs for associative array

Discussed in https://github.com/spaceship-prompt/spaceship-prompt/discussions/1049

Originally posted by heefan July 15, 2021
spaceship: v3.13.2 macos oh-my-zsh
Hi guys, I am new to spaceship-prompt,  and I got the error as following,
spaceship_maven:14: bad set of key/value pairs for associative array

May I know what's the problem of it?   Thanks.

The file is located at $HOME/.oh-my-zsh/custom/themes/spaceship-prompt/sections/maven.zsh
Line 14
SPACESHIP_MAVEN_SYMBOL="${SPACESHIP_MAVEN_SYMBOL="𝑚 "}"

:tada: This issue has been resolved in version 3.13.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Midi Monitor on fluidpatcher_cli crashes when receiving sysex messages

Hi!
Thank you for making Fluidpatcher I really enjoy working with it! I did notice one issue recently.
I have a midi controller (nanoKey) that send System excusive messages when I switch scenes.
Example of such message - selecting first track:
"System exclusive F0 42 40 00 01 36 02 00 00 4F 00 F7"
xdotool catches this but MIDI monitor from Fluidpatcher doesn't show these messages at all. I tried using the CLI version and MIDI monitor there gives an exception:
Exception ignored on calling ctypes callback function: <function Synth.__init__.<locals>.<lambda> at 0x7f81df94e0> Traceback (most recent call last):   File "/home/bane/synthsynth/fluidpatcher/pfluidsynth.py", line 573, in <lambda>     self.custom_router_callback = fl_eventcallback(lambda _, e: self.custom_midi_router(e))                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/home/bane/synthsynth/fluidpatcher/pfluidsynth.py", line 648, in custom_midi_router     self.midi_callback(MidiSignal(mevent))   File "/home/bane/synthsynth/fluidpatcher/__init__.py", line 464, in _midisignal_handler     if self.midi_callback: self.midi_callback(sig)                            ^^^^^^^^^^^^^^^^^^^^^^^   File "/home/bane/synthsynth/fluidpatcher_cli.py", line 71, in sig_handler     t = MSG_TYPES.index(sig.type)         ^^^^^^^^^^^^^^^^^^^^^^^^^ ValueError: tuple.index(x): x not in tuple
Is it possible to catch these messages in midi monitor in CLI?

Thanks for the catch! The crashing is now fixed by #110
The MIDI monitors in the scripts are there to help you create router rules that match the events sent by your keyboard, not as general-purpose MIDI monitors. They only show "voice" messages note, noteoff, cc, pbend, kpress, cpress, prog because those are the types that can be used in router rules, and it would be more complicated to display other types (especially sysex, which can carry arbitrary amounts of data). Sysex messages are passed along to FluidSynth (which responds to a few) even though they're not displayed in the monitors, and will be shared with other MIDI devices on your system if you connect them to your controller (e.g. with aconnect).
Is there a need to display sysex messages in the built-in MIDI monitors I'm not thinking of?


add JetBrains ecosystem plugin (WIP) reference

This plugin is WIP, not-yet-released for various reasons:

LS Executables are not bundled into the plugin / downloaded at an appropriate time.
Currently requires JetBrains EAP builds (>=2023.2).
Not feature-complete.

To-do list:

[ ] Plugin should bundle or download appropriate executables
[ ] Plugin should automatically provide access to Roblox type definitions and docs (when appropriate)
[ ] Plugin should integrate with Rojo (notably sourcemap.json)
[x] Errors/warning highlighting (Supported via LSP)
[x] Syntax highlighting
[x] Autocompletion provider (Supported via LSP)
[x] Go to reference provider (Supported via LSP)
[ ] Refactor provider
[ ] Folding builder
[ ] Commenter
[x] Quick fixes (Supported via LSP)
[ ] Wait for 2023.2 to be released in earnest
[ ] Publish to JetBrains plugin marketplace

This is pretty neat, thank you!
Is the expectation that the Todo list is completed before this is available? Or is it usable in its current state

It's not yet usable, no - a bit more of the to-do list needs to be done (especially the points relating to the binaries).
I didn't realise quite how difficult implementing this plugin would be 😂 even just refactoring support is difficult.

I don't think luau lsp has any refactoring operations. What kind of stuff does that entail?

It involves some specific implementation (on my part) in the plugin. It's not trivial to explain, but

see here for a simple properties language example
see here for details

Essentially, whilst VSCode implements a 'naive' renaming system that looks for particular strings and replaces them, JetBrains plugins use a more complicated 'smart' renaming system that involves a language lexer and parser to generate tokens and use them to build a 'PSI tree' which can then be traversed to find usages of the text that will definitely be a reference, rather than just a coincidental instance of the text.


Add and remove elements to fieldArray (repeat) programmatically from the component

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[X] support request

Current behavior

I tried to use the repeating section example but I am stuck when I want to add new items to the fieldArray as the controls (buttons to add categories) are independent of the form, so I don't know how to use the FieldArrayType add and remove methods.
Expected behavior

Being able to add and remove elements in a FieldArrayType programmatically (call the add and remove methods by hand in my component).
Minimal reproduction of the problem with instructions

Stackblitz: https://angular-jhvhvn.stackblitz.io
Please tell us about your environment: Fedora, VS Code, NPM

Angular version: 7.2.0
Browser: all
Language: all
Node (for AoT issues): node --version = v10.15.1

Thank you in advance.

use one of the following ways:

update the model: https://stackblitz.com/edit/angular-jhvhvn-d6ozde
assign add/remove method to the field or formState: https://stackblitz.com/edit/angular-jhvhvn-4ykhtq

Hi @aitboudad, I was trying to call templateOptions.add() unfortunately it's not accessible. :(

@eugeniopaguntalan fill a new issue with a reproduction example.

Hello @aitboudad I'm using your stackblitzas an example to implement a fieldArray repeat. However I've run into a issue that seems to also be a problem in the stackblitz solution. In the stackblitz the fields have a className of 'col-sm-4', but they don't seem to enforce this. You can change the value around but the field will stay what seems to be col-12.
I have inspected the code with the chrome console and also changed the col-4-sm class in the console to col-2-sm, again nothing changes. Because of this whenever I use formArray the lay-out becomes huge because every field in the formArray takes up an entire line.
Is there a way to force the formly fields in a fieldArray to actually take the bootstrap class assigned to it?

@YhEtesian the bs grid require formly-field to be display:block, also the row class should be set using fieldGroupClassName:
// styles.scss
formly-field { display: block; }

// app.component.ts
fieldArray: {
+  fieldGroupClassName: 'row',
  ...
}

Worked like a charm, thank you!


change numpy / numba pins to lower bounds

conda will handle python and package alignment issues

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thank you @lgray! This is quite nice to have. :)


Configure data storage setup for aquired data

Notes
This task is closely related with:

#226

Domain
app backend
Description
This task starts with the evaluation of what is technically possible and and then implements the best solution for our use case.
Research and find a way to store the aquired data in a way that will allow:
a) embeddings generation and
b) the provision of the specific sources that were used by tha agent to produce the anwers to the user.
There might be no need to store raw data in a DB and just having plain JSONs in a directory in HPC or GCP is enough to fulfill these two requirements.
If this is not enough, a DB solution should be configured (MongoDB intance on GCP or Google Firestore).
User Story
As a developer in this team,
I need to have lots of aquired data saved at some centralised location
so that I can use them to generate embeddings and accurate source tracking for the results the agent will be providing to the end user.
Acceptance Criteria

[ ] Assesment of the feasibility of storing raw data as JSON files in HPC or GCP directories in comparison to using a document database like MongoDB on GCP or Google Firestore has been completed and has resulted in a concrete decision.
[ ] The chosen storage solution supports embedding generation.
[ ] The chosen storage solution allows for tracing sources of the generated answers (via meatadata or some other way).
[ ] Implementation of the chosen storage solution for acquired data can be demonstrated.
[ ] Doumentation of the setup and configuration process has been created in the respective section of the project wiki.

Definition of Done

[ ] The feature has been fully implemented.
[ ] The feature has been manually tested and works as expected without critical bugs.
[ ] The feature code is documented with clear explanations of its functionality and usage.
[ ] The feature code has been reviewed and approved by at least one team member.
[ ] The feature branches have been merged into the main branch and closed.
[ ] The feature utility, function and usage have been documented in the respective project wiki on github.

An instance of Mongo DB has been created on GCP, and some of the JSON files have been saved there.
Along with this a new method is found due to which the Mongo DB instance is not needed anymore. The embedding of the scraped data is directly stored on Astra DB.


use MONKEY-SEE-NO-EVAL;

EVAL doesn't work anymore unless this pragma is used:
use MONKEY-SEE-NO-EVAL;

this should solve issue #22

Hey, thanks for keeping an eye on it :)


nixos/lxd: add package options for LXC, LXD and ZFS

Currently, LXD always use pkgs.zfs, even if boot.zfs.enableUnstable is set. This
change provides the option to change the LXC, LXD and ZFS packages, and
determines the default ZFS package based on zfs.enableUnstable.
Motivation for this change
I had to change the LXD package (to use LXD from nixpkgs-unstable), and noticed it could not be changed in virtualisation/lxd.nix. I also noticed that zfs.enableUnstable was not taken into account for the ZFS dependency.
Things done
Added options for the LXC, LXD and ZFS packages in the LXD configuration.

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @

The force-push was to fix some forgotten whitespace.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/85

rebased and adapted to #71978
cc @Lassulus @wucke13

hmm, wouldn't it be better to use packageOverrides for something like this? maybe zfs.enableUnstable should override pkgs.zfs?

Should I remove the ZFS-part of this PR so that we can merge the LXC/LXD options and handle ZFS  in another PR ?


moving the X to the right side

Hi,
Is there an easy way to move the X to the right side?
Thanks

Apply the next CSS to tm-XButton class:
<style>
    .tm-XButton {
        backface-visibility: hidden;
        -webkit-backface-visibility: hidden;
        -moz-backface-visibility: hidden;
        transition: transform .8s;
        -webkit-transition: -webkit-transform .8s;
        -moz-transition: -moz-transform .8s;
        -ms-transition: -ms-transform .8s;
        -o-transition: -o-transform .8s;
        position: absolute;
        top: 10px;
        right: 15px;
        width: 28px;
        height: 28px;
        line-height: 28px;
        cursor: pointer;
    }
</style>

Thanks (sorry for the late reply)

actually, this CSS is exactly the same CSS as in tomloprodModal.css (so it doesn't work)

oh I see the difference

left not right

Thanks.


Drag resize handle

This adds a vertical bar to help resize
In this case, it actually squishes the tree width
It could alternatively cover up the names and leave the tree at the same width
My feeling is that seeing the names is often important though, so maybe this is the right behavior as implemented here

The grey vertical bar between the MSA and tree is a draggable handle

note that implementing a draggable handle is surprisingly tricky in flexbox in general, did a best effort using tricks learned from jbrowse 2 codebase on adding global mousemove/mouseup handlers after a per-element mousedown

could also make "two drag handles", with different behaviors (one for shrinking tree, one for shrinking space for names) depending on which is clicked...kind of a weird UI pattern but i feel like users would probably figure it out

I now have two resize handles colored green and red, the top one just "crops" the tree view while the bottom view stretches out the tree
I think natural curiosity can help the user figure out the system but open to considering some UI design


Disable and enable entities

What problem does this solve or what need does it fill?
For gameplay or performance reasons, it is common to want to temporarily disable entities.
While disabled, they should generally not be interacted with in any way.
What solution would you like?
Add a special Disabled marker component. Entities with this component do not appear in any queries, unless the query contains With<Disabled> (or otherwise explicitly requests that component).
I'm indifferent to either hard-coding a single type for this, or making this behavior an associated constant on the Component type. The former is simpler, but the latter is end-user extensible and arguably more elegant.
What alternative(s) have you considered?
Respawning
We could save, despawn and then respawn the entities. However it is both simpler and faster to keep the entities alive but filter them from (most) queries.
Additionally, reading the data of despawned and stored entities is much more challenging.
Custom marker component
Users could add a Disabled marker component of their own, and then add Without<Disabled> to all of their systems.
However:

This is a lot of boilerplate.
There is no standard across the ecosystem.
External systems will continue to operate on them.

Additional context
flecs has a Disabled component and a Prefab component that work in this fashion. It also has a Prefab component which works in the same way.

[9:27 PM]Joy: flecs also supports disabling individual components in a nice opt-in way
[9:27 PM]Joy: component IDs have a flag bit to differentiate between a T and a toggleable T
[9:28 PM]Joy: calling e.disable_component(), will move the entity to a new archetype/table whose column for T has a bitset saying which entries are disabled and marks e's as disabled
[9:28 PM]Joy: (no move if it's already there)
[9:28 PM]Joy: enabling it again will just flip the bit
[9:29 PM]Joy: so iteration is only affected when iterating entries in those archetypes/tables

#9797 unblocks the implementation of this for making use of bit-level IDs, a la flecs. It would need to be a follow-up PR that then modifies the ID format to include the extra disable bit in the flag portion (the high component will then be 2 bit flag, 30 bit value versus the current 1 bit flag, 31 bit value).

If we do the built-in disabled component we would need to give the choice of storage type

I would like that. I work on a crate where systems can be reversed. So far despawning an entity in reversible systems just add a marker component so it can be easily undone when reversing the command. I would have to ask the user to always filter on that marker. A built-in solution would be so much better.

I would prefer this be done via merging https://github.com/bevyengine/bevy/pull/9797 given that it's on the horizon and more flexible than a special Disabled component.

Can you explain how #9797 would be useful for this? I'm not immediately seeing the connection.

@alice-i-cecile Doing this via flag bits lets you disable components individually which avoids competing meanings for why something is "disabled" (these build up rather quickly). It also lets you implement an engine standard Disabled marker component on top of it rather than it being special case internal magic should that still be desired.

Gathering some of the important discussion from @maniwani on Discord into here:

[8:26 PM]Joy: the thing is, we want both fine-grained change detection and disabling to be something opted into at runtime
(we never added disabling because we didn't want to degrade iteration for all queries)
[8:26 PM]Joy: that's the complicated part
[8:28 PM]Joy: IMO the best way to achieve that is to exploit archetype fragmentation
[8:28 PM]Sander: I think that issue is for entity disabling which you can just do with a marker tag
[8:28 PM]Sander: Component disabling can be done with a bitset
[8:33 PM]Joy: if we reserve flag bits in ComponentId, we can use them to differentiate between "a plain T" and "a T you can toggle" (because their IDs are different, they'll be treated as distinct components)
[8:34 PM]Joy: then archetypes/tables that have "a plain T" and the ones that have "a T you can toggle" will be different, table columns for T in the first group won't have the bitset, but columns in the second group will
[8:35 PM]Joy: and then if we have an API like entity.disable_component::() and entity.enable_component::()
[8:38 PM]Joy: those would be exclusive operations (Commands::disable_component, EntityWorldMut::disable_component)
[8:38 PM]Joy:
if the entity has "a T you can toggle", just set the bit
if the entity has "a plain T", move it to the archetype that has "a T you can toggle" instead, then set the bit
[8:48 PM]Joy: so as far as "how hard is this to implement?" I think the main part is updating the Query, Table, and TableColumn logic to handle the conditionally-present bitset
[8:51 PM]Joy: the "reserve flag bits" might already be done (I think that was in the Identifier PR)
[9:00 PM]NiseVoid: This sounds kind of sketchy, that would mean there's 3 versions of T: A plain T, an enabled T and a disabled T ... But whats the difference between an enabled and plain T? 🤔
[9:01 PM]James 🦃: There's only 2 versions of T: normal T and toggle-able T
[9:01 PM]James 🦃: When matching normal T a query won't have to perform a check for whether it's enabled, where as for toggle-able it checks the bitset
[9:07 PM]Joy: exactly
[9:08 PM]Joy: queries iterate archetypes/tables
[9:08 PM]Joy: so if you query for T
[9:09 PM]Joy: when the iterator is on a table with a normal T (which we can tell from the ID), we can skip the check
[9:10 PM]Joy: when the iterator is on a table with a toggle-able T (again, we can tell from the ID), we do the check
[9:11 PM]Joy: it's sort of like a runtime version of specialization
[9:12 PM]NiseVoid: So I guess disabling a component would permanently move an entity over to an archetype where that component is togglable?
[9:12 PM]Joy: yes
[9:15 PM]Joy: I mean, could do stuff like entity.take::() and then add it back, or we could add an explicit API to say "I don't want to toggle anymore" but yeah, you got it

I want to note that those Discord discussions have been about a mechanism for disabling individual components, which is kind of orthogonal / complementary to this issue's proposed Disabled marker that disables entities.

Add a special Disabled marker component. Entities with this component do not appear in any queries, unless the query contains With<Disabled> (or otherwise explicitly requests that component).

Like, this solution is still what I would do for disabling entities.

I'm merging https://github.com/bevyengine/bevy/pull/13120 on Monday unless someone stops me.
Once that's in, I'd like to add a Disabled component in bevy_core, along with a EntityDisablingPlugin. That plugin sohuld be part of MinimalPlugins / DefaultPlugins / HeadlessPlugins.

I should note that I also have a Disabled marker component which does something quite different: it displays a button or widget in a grayed-out state. I named it Disabled because in HTML this grayed-out state is normally signified with the HTML attribute disabled, e.g. <button disabled on_click="etc...">A disabled button</button>.

Why not make sure that all requests have a filter: Without<Disable>?

Why not make sure that all requests have a filter: Without<Disable>?

Are you talking about the alternative solution described in ###Custom marker component, or default query filters?


Cut release 1.0.0 of logging package.

Should be OK after #3270? I made this branch on the GoogleCloudPlatform remote so that system tests are run in this PR.

Error on Windows: https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-python/build/1.0.1430.master/job/ru59q79vnb23wxiu
any_pb == any_pb

will fail if the type is unregistered. This seems like a big FAIL of google.protobuf.

Why on earth would that __eq__ not work only on Windows?

Looks like error-reporting==0.24.1 never got pushed. Will push a tag right now at 5878b78025eb039a95e5f42a61572c448aadc97c.
Only changes are this and #3299:
$ git log error-reporting-0.24.0..error-reporting-0.24.1 -- error_reporting/
commit 138f59fc1795e1e433822bdd62d927762fd8f2e2
Author: Bill Prin<EMAIL_ADDRESS>Date:   Mon Apr 17 10:16:11 2017 -0700

    Replace httpContext with httpRequest (#3299)

commit 7cf905115fbfa9d54850b6a3426f38ab7096009e
Author: Danny Hermes<EMAIL_ADDRESS>Date:   Thu Apr 6 18:43:55 2017 -0700

    Cut release 1.0.0 of logging package. (#3278)


[release-0.30] Add tests related to qemu processes

a) Ensure qemu processes run as cotainer_t, when
selinuxLauncherType is undefined. Also, ensure
that they are MCS constrained by checking for category_set.
b) Ensure qemu processes should be equal to the
value of selinuxLauncherType.
Signed-off-by: Kedar Bidarkar<EMAIL_ADDRESS>
What this PR does / why we need it: Add tests related to qemu processes
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer: Add tests related to qemu processes
Release note:

NONE

Backport of #3599

/retest

/assign @jean-edouard

This PR backports both https://github.com/kubevirt/kubevirt/pull/3750 and https://github.com/kubevirt/kubevirt/pull/3599 mashed into 1 commit.
Could you maybe either open 2 PRs, or split this one into 2 commits? Just to keep some coherence with master.

This PR backports both #3750 and #3599 mashed into 1 commit.
Could you maybe either open 2 PRs, or split this one into 2 commits? Just to keep some coherence with master.

It got mashed into 1 commit as I fixed it during re-base merge conflicts. Ok will cherry-pick both the commits into this PR.

So cherry-picked both the commits into this single PR.

Thanks @kbidarkar!
/approve


V1 of django-pgmigrate

django-pgmigrate helps you avoid costly downtime with Postgres migrations and provides the following features to alleviate problematic locking scenarios when running migrations:

Detect blocking queries and terminate them automatically.
Print blocking queries so that you can inspect and terminate them manually.
Set the lock timeout so that migrations are terminated if they block too long.

Type: api-break

Note that the PR will fail until django-pglock V1 is deployed


Update AS5600.cpp

Critical bug fix. The I2CADDR and I2CUPDT registers are single byte registers on AS5600L, without specifying this the default behaviour is to write two bytes. The address will then be mistakenly written as 0x00 which is a reserved I2C address. If this is followed by a burn settings, the wrong address may permanently be written and the sensor may be 'bricked'.

Thanks a lot for reporting this! I have merged it to the dev branch and it will be part of the next release.


Release 7.0.0

Let's release 7.0.0, particularly as some backports are only partially merged into 6.x. Doing this also frees up master to do more bold things.

[x] cut branch 7.x from master
[x] update master branch gradle.properties 8.0.0-SNAPSHOT
[x] create 7.x release job based on 6.x one
[x] kick off 7.x release job to release 7.0.0 from 7.x branch
[x] don't forget to close and release the oss sonatype staging repo!
[ ] update main example-github and example-wikipedia to use version 7.0.0
[ ] update denominator to use version 7.0.0

cc @qualidafial @davidmc24 @rspieldenner

How many of the release branches are getting active releases? I can kick off some pull requests to try out the new plugin.

How many of the release branches are getting active releases? I can kick off some pull requests to try out the new plugin.

None are getting regular releases, but I think we can make things regular
by saying "last 2" ex. now 7.x and 6.x

None are getting regular releases, but I think we can make things regular
by saying "last 2" ex. now 7.x and 6.x

@tbak You won't need to create a 7.x release job or close and release the oss sonatype staging repo (the plugin lets bintray do that).

And another question. I have the default for the new plugin setting sourceCompatibility to 1.7. Do you want that or do you want to keep it at 1.6?

1.6 since this is also for android. Thanks!

Build changes moved in. Created new Cloudbees jobs under the NetflixOSS/feign folder. And feign is now on jcenter which will push it to mavenCentral: https://bintray.com/netflixoss/maven/feign/view.

@adriancole Can you see and use the https://netflixoss.ci.cloudbees.com/job/NetflixOSS/job/feign/ jobs?

Login keeps wanting me to use a netflix one..


Release

Guys when you want release new version of the best react calendar ? :dagger:

when we have a free moment to do so


Inconsistent behavior with Test Tags from Settings and [Tags] from Test Case

Test Tags from *** Settings  *** and [Tags] from Test Case behave differently when removing tags: while it is possible to remove tags with Test Case's [Tag]  -something, Settings Test Tags  -something introduces a new tag -something.
Running tests with these robot files (also attached):

__init__.robot:*** Settings ***
Test Tags    something

-SomethingInSettings.robot:*** Settings ***
Test Tags         -something

*** Test Cases ***
-Something In Settings
    Should Be Empty    ${TEST TAGS}

-SomethingInTestCase.robot:*** Test Cases ***
-Something In Test Case
    [Tags]    -something
    Should Be Empty    ${TEST TAGS}

gives the following output:
> robot .
==============================================================================
TagsTest
==============================================================================
TagsTest.-SomethingInSettings
==============================================================================
-Something In Settings                                                | FAIL |
'['-something', 'something']' should be empty.
------------------------------------------------------------------------------
TagsTest.-SomethingInSettings                                         | FAIL |
1 test, 0 passed, 1 failed
==============================================================================
TagsTest.-SomethingInTestCase
==============================================================================
-Something In Test Case                                               | PASS |
------------------------------------------------------------------------------
TagsTest.-SomethingInTestCase                                         | PASS |
1 test, 1 passed, 0 failed
==============================================================================
TagsTest                                                              | FAIL |
2 tests, 1 passed, 1 failed
==============================================================================

(https://forum.robotframework.org/t/removing-tags-from-the-test-tags-setting/7513/6?u=romanliv confirms this as an issue to be fixed)

The current behavior is actually be default. When the -tag syntax was introduced in RF 7.0 (#4374), it was specifically designed to work only with [Tags]. The main motivation was making the change as little backwards incompatible as possible, by not changing how tags set using Test Tags work. I also believe it didn't occur to us that someone would like to remove tags set in initialization files using this syntax.
Now that I think about this again, I believe the use case to remove tags set in initialization files is pretty important. I also agree that the current behavior that -tag works with [Tags] but not with Test Tags is inconsistent. I think it makes sense to change this, but due to the aforementioned backwards compatibility concerns, the change needs to wait for a major release and we should also deprecate using -tag syntax as a literal tag name in Test Tags first. I thus propose the following:

We deprecate using -tag in Test Tags in RF 7.2. We similarly deprecated using -tag with [Tags] in RF 6.0 (#4380).
Actually implement this behavior in RF 8.0.

Let's use this issue for actually making the change. I'll update the title accordingly and assign this to RF 8.0 scope. I'll also submit a separate issue about deprecation and assign it to RF 7.2.


Fix some integv2 tests which were not behaving correctly.

Description of changes:
Fix some integv2 tests which were not behaving correctly.

Copy the trust store bundle so it can be accessed by integv2
Allow all ciphers in the the tls13 to tls12 negotiation test

Call-outs:
The CA bundle was just copied, not moved. This was to make the least changes possible and allow the existing integ tests to keep working. The duplication can be removed when #2114 is completed.
Testing:
Integration tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2115 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2115   +/-   ##
=======================================
  Coverage   80.92%   80.92%
=======================================
  Files         247      247
  Lines       18409    18409
=======================================
  Hits        14898    14898
  Misses       3511     3511


Implement stacked line charts

I noticed that Chartist allows stacked bar charts, but not line charts. So I added this feature for line charts, along with an example and test.
The implementation is a little blunt: during the render step, I modify the data object directly before all the other actions happen. I need to do this to get the axes do adapt to the data changes. I hope this is okay.
As always, feedback is appreciated!
:thumbsup:

In using this in my use case, I think the accumulation might not be working properly. I'm going to retract this and make sure it's right.

I realized that it's better if the developer implements line-stacking in their data, so this is moot. Wish I had realized that earlier, but oh well. Thanks!


Clarify timezone of "last updated" time

At the bottom it has "last updated" time. We should clarify that this is UTC

Maybe also worth having the date in a verbose format like 3rd June 2021 in case people get confused

Tweaked to add in UTC and a more universal date format.
![Screenshot from 2021-06-03 11-33-03](https://user-images.githubusercontent.com/1104745/120631166-780d3200-c45f-11eb-
8df4-0617bd1a00f7.png)


PermissionsEx 1.8 bukkit won't work

So I filled everything out I eve got chat manager and tryed multiple of them and countless times made new permission files and it still wont work
http://pastebin.com/bM9isisH
I try to see if it was just the prefixs not showing up but when my friend tryed a default command it still would say you can't do this command.

run /pex report and paste the link it gives you here.

I don't have access because I don't have enough permissions but I am the owner.

run it from console

I did it says I need a github account

well you have a github account, because you are commenting here, but that's not necessary -- just paste the link...

the problem is i'm not hosting the server cubed host is so I think thats why i'm trying to put the same plugins and permission file on a server on my computer.

on second thought its taking a long time to download.

or you could just paste the link it gives you...

wow sorry I just found out it gave me a link after sorry about that 01.07 21:21:41 [Server] INFO Fill in the information at http://git.io/vtA7C

Here is the link sorry https://gist.github.com/652255ed11d2d6026904)

Looks like you don't have any inheritance set up, and your default group has only modifyworld permissions. You'd have to add inheritance (look at the wiki for information how). Make sure you have a chat plugin that can get data from PEX -- essentialschat does this, probably others.

can't find essentialschat for bukkit

then look harder


[Serialization] support loading torch state dict from disk

Implement helpers to load a torch state dict from disk. For the implementation, it's mostly an importing from transformers and diffusers implementation with additional error handling and some refactoring. the loading can be done from a single file or from shards. It handles both safetensors and pickle files. Saving torch state dict has been previously added in #2314.

This PR:

adds load_torch_model() helper function that takes a nn.Module and  a checkpoint path (either a single file or a directory) as input and loads the weights into the model.

usage example:
from huggingface_hub import load_torch_model
model = ... # A PyTorch model

# load the weights into model
load_torch_model(model, "path/to/checkpoint")

adds two low-level helpers that can be used directly by transformers, diffusers and accelerate:

load_sharded_checkpoint(): loads sharded weights from disk.
load_state_dict_from_file(): loads a single checkpoint file.

tests have been added and documentation have also been updated.

Note: PRs will be opened in transformers, diffusers and accelerate to integrate these helpers once huggingface_hub v0.27.0 is released.
cc @sayakpaul for diffusers, @muellerzr and @SunMarc for accelerate and @ArthurZucker for transformers. Happy to get any feedback on this. The goal is the same as for the saving helpers: standardize things across our libraries and establish consistent conventions!

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin thanks for the review! I've addressed the comments and created a draft PR hanouticelina/transformers#1 to illustrate the integration (I've opened it on my personal fork for now while this PR is still WIP) –would love to have your feedback on that!

Sorry for the policing, but does a similar PR need to be opened in diffusers too? 👀

Sorry for the policing, but does a similar PR need to be opened in diffusers too? 👀

@sayakpaul, yes! we plan to open a PR in diffusers once these helpers are released. For now, I've created hanouticelina/transformers/pull/1 just as an example integration


Admin | Sync Template v2 (Model Driven Apps) Failing

I am executing this flow with my Power Platform Service Admin Account.
The environment which returned the result today, is throwing the error while running the flow again tomorrow.
I am seeing the performance is not consistent everyday.
Is there anything specific I have to see for this issue?
Cheers,
Dhawal Mehta

We did have a regression in this solution this week which impacted this flow. We shipped the fix yesterday. Can you upgrade and see if that fixes you? Be sure to choose overwrite customizations on upgrade.

I'm also having some trouble with this flow.  This is a brand new setup with Core 1.6.
I'm seeing 400s in the "List Model Driven Apps" step with "Invalid value provided for data set"

@JeneferM-MSFT    In the 1.6 version there's a problem in the "Get App Modules Table. Fail out if no permissions to environment" section.     In the List Model Driven apps step the Environment is set to admin_environmentcdsmetadataname   which looks like  orgXXXXXXXX.crm.dynamics.com.    This results in a 400 error when the step runs.
If I manually set the environment to one from the drop down and then go to peek code i can see the it is looking for only orgXXXXXXXX.crm.    I changed environment to the following:
replace(triggerBody()?['admin_environmentcdsmetadataname'],'.dynamics.com','')
This removes .dynamics.com from the environment name and the step runs successfully.
Same problem again in the "Get MDD App Creator" step.
Once those were both changed the flow runs successfully.

Hi Paul. I think you may have not chosen overwrite on upgrade as the issue you are seeing did ship but was fixed in 1.6
Thank you for getting yourself unblocked though! And thanks for using CoE!

Jenefer,
Ok,  I'm not sure that applies since this was our initial install and we started on 1.6?    Experienced the same problem with new install in test tenant.
It's working fine for me after the above work around, I just wanted to report the issue in case it comes up again.
Paul

Thanks Paul. The release may have missed the fix then, but our local version contains it and we are shipping soon.
Really appreciate your efforts to help make CoE great!


mismatch between gds and mag views

currently I am aware of:

mgmt_protect

I will update this list whenever I find more mismatches.

Why is there even a GDS view of this block, since it's not used?  The gds/ directory is full of GDS files that are not used and should be deleted.  The only GDS files that I can see that are actually being used are advSeal_5um_gen.gds and simple_por.gds.
Both of those should be rewritten with .gz at the end in the corresponding .mag files, and we should stop compressing/decompressing GDS files outside of the layout tools.

Reassigning to Kareem.  This requires only removing all of the unused GDS files (which is everything except those mentioned above) and confirm that this does not break the design and tapeout flow.  The scripts should be rewritten to force magic to always use gds compress 9 before writing GDS, and then to remove all compress/uncompress scripts from the repository (except possibly for generating the final tapeout database, depending on whether a foundry can or cannot read compressed GDS, or will be using only the Oasis database) (Global Foundries, for example, currently will take only uncompressed GDS).

Tapeout script specifies a single source of truth for each block and we will archive it as we tapeout with a tag. No need to work on this ticket as it represents an old status of the repo based on prior practices.


Feature request - Dekstop entry for linux

Problem
Without Desktop Entry user cannot pin application to dock (i.e. "Keep in dock" in Plank) and also the icon size is incorrectly scaled or there is not application at all.  The problem occurs on any electron based application on Linux with almost all dock software (plank, dash-to-dock for GNOME Shell etc.).
Solution
I would love to if KeeWeb would be bundled with a .desktop file (e.g.):
[Desktop Entry]
Name=KeeWeb
Comment=Kee Web
Exec=/<% path_to_keeweb &>/KeeWeb
Icon=/<% path_to_keeweb &>/resources/app/icon.png
Type=Application
Categories=GTK;GNOME;Utility;
Terminal=false

Which will be able to quickly copy into /usr/share/applications/ (sudo ln -s "$PATH_TO_KEEWEB/KeeWeb.desktop" /usr/share/applications if using Bash).

Hello!
Which distro are you using? Will this work in all Linux versions?
I need some help in this. Is creating a file with the content you posted enough? What would be the best location for this file? Inside an app folder?

Which distro are you using? Will this work in all Linux versions?

Yes, (almost) all Linux desktop environments are affected by .dekstop entry. I can confirm that problem occurs in Ubuntu and its derivatives. Please note that it is connected to DE not the distro itself. It means any distro with KDE/GNOME (or GNOME-based - i.e. Phanteon, XFCE) uses .desktop which works similar to good old desktop.ini on Windows.

What would be the best location for this file?
Inside an app folder?
Is anything else required, e.g. creating a script to copy this to desktop?

There are two locations which should be considered:

$HOME/.local/applications - user-specific
/usr/local/share/applications - global configuration

The KeeWeb.desktop can be bundled as a template by default and copied into applications directory (like Atom does it). As far as I know there are also a way to improve the [shortcuts in the launcher[(http://electron.atom.io/docs/v0.33.0/tutorial/desktop-environment-integration/)

Is creating a file with the content you posted enough?

It works for me if I set correct paths, but I am concern that we should modify it slightly to improve search experience (i.e. if you type password then KeeWeb will appear in resuts) and consistency to be more meaningful.
PS. I feel bad because I forgot to thank you in previous post for such awesome application as KeeWeb is! You are great! :+1:

Thanks for explanation, I'll add .desktop entry.

Now we have .desktop entry in deb package. So once #141 is resolved, I think we can close this. Am I right, or it's better to add .desktop entry to the app archive?

Yes, I think we can close this issue. After creating a installable .deb archive I claim it is done (since I prefer debian-based distros). I think that sample desktop entry should be put in the wiki of the instead of the repository.


Slow data reading

Hello!
Thank you for interesting paper and implementation.I would like to test it on my dataset, total 516218 lines. However, it more than 2 hours on "Reading data...+Stage 1/2..".  Seems also that it use only one thread to read the data. May be I am doing something wrong?

Hi - That might be indicative of a formatting error in the input files; I suggest carefully checking that.
Multithreading isn't applied to data reading, so it's normal that it uses one thread.

Thank you for the fast response! It is really was the problem: I made '1.0' quantity instead of int.


Set americanize false for tokenizer

@arunchaganty I am processing the following sentence:
Test sentence (this is a try).
As an output with print corenlp.to_text(sentence) I get.
'Test sentence -LRB-this is a try-RRB-.'
To get 'Test sentence (this is a try).' I would need to set -tokenizerOptions "americanize=false" as described under question 33 here: https://nlp.stanford.edu/software/parser-faq.html
Can you please let me know how to do that?
I have tried: with corenlp.CoreNLPClient(annotators="tokenize ssplit pos lemma".split(),properties={'timeout': '50000','americanize':'False'}) as client:
this did not work

You would want to use a command like this:
ann = client.annotate(u"Test sentence (this is a try).", output_format="text", properties={"tokenize.options":"ptb3Escaping=false"})

A related question: when setting 'tokenize.whitespace': 'true', even if I then do 'tokenize.options': 'ptb3Escaping=true', PTB-style conversions are not done.
E.g.:
with corenlp.CoreNLPClient() as client:
  print(client.annotate('I ( a student ) like apples .', properties={
        'annotators': 'depparse',
        'inputFormat': 'text',
        'outputFormat': 'text',
        'tokenize.whitespace': 'true',
        'tokenize.options': 'ptb3Escaping=true'
    }))

The parentheses in this example are not converted to -LRB- and -RRB-. Do you know how I can make it work? Thanks!

Looks like it might be ignored on the Java end, so I also opened an issue in the CoreNLP repo here.


Make a chatbot

Create a facebook page and make a chatbot for that page using services such as chatfuel or dialogflow or wit.ai
Make your bot do something. see bot stores to get ideas about chatbots.
Comment link on fb page at the bottom. Share your creation to the world on fb and tag opencode page. :smile: (that link also comment)
The bots which stands out will get extra credits. Depending on your implementation and creativity.
Atleast 5-6 type actions. If no text reply is also fine, given its fun.

Here is the link for the page:- https://www.facebook.com/Web-On-Roll-792008184501295/?modal=admin_todo_tour
link for chatbot using chatfuel :- https://dashboard.chatfuel.com/#/bot/5c619b910ecd9f2d171b7e7e/structure/5c619b910ecd9f2d171b7e92
Test this chatbot

I am attachig the screenshot for the same

I am attaching the screenshot between me and bot


About js_inject

When I try to make some templates, the Passwd value obtained after injecting JS code is encrypted. May I ask, can this value be unable to obtain the original text by injecting JS?

Hello Please do you have any idea on why after the user types in the username to proceed to the next page for password the phishing link i created will project the error below this message as shown in the picture. i have been on this issue for more than 3 days now.

You can use "--debug" to try to capture packet data to analyze the problem


Reduce camera field of view

It turns out that the field of view of the cameras in the kits is pretty low -- I think 55° was the reported best value, though less than that in most cases. This is a lot lower than the 82° which the simulator currently uses:
https://github.com/srobo/competition-simulator/blob/c2ba7070e62fc309ab5219e3caf3a47a4342d475/protos/Components/SRCamera.proto#L44
We should update the simulator to more closely match the kits.

This is in radians. 0.82 radians is 47 degrees.

:facepalm:


Syntax Highlighting with Gatsby

The react component works perfectly in my Create React App, but it will not work with Gatsby which I am using for HMR. Does Monaco not work with HMR related things?

Actually, it should work with HMR. May I ask you to share the reproducible code segment with the issue? Basically, it can be a codesandbox or Github repo.
Thank you!

@tomthornton I checked it. It works well with Gatsby as well as HMR. Maybe, your case is not related to Gatsby or HMR, or I couldn't reproduce it. In any case, I need more info.


Task system

Tasks are callables whom lifetimes are handled by the engine.
Tasks can be ran with 3 different modes

Synchronous (executed within the game loop thread)
Asynchronous (executed in a different, dedicated thread)
Pool (executed in a different thread, pooled with other tasks using collaborative multitasking)

Collaborative multitasking
Collaborative multitasking could be implemented using C++ coroutines.
A wait_for function could be available to either wait for a given time or a given event :
void mycallable(TaskContext ctx)
  wait_for(obe::Time::seconds(3);
  std::cout << "After 3 seconds" << std::end;
  wait_for(obe::Input::Events::KeyPressed::E);
  std::cout << "After E key was pressed" << std::endl;
end

Possible Lua API
local http = require "libhttp"; -- imaginary HTTP lib

local scores = {p1 = 0, p2 = 0, p3 = 0, p4 = 0};

function retrieve_player_score(ctx, player_id)
  local url = string.format("https://myscoreapi.com/api/scores/p%i", player_id);
  local response = http.get(url):json();
  scores[player_id] = response.score;
end

for i=1, 4 do
  Engine.Tasks:run {
    task=retrieve_player_score,
    params={i},
    every=seconds(1),
    pool="scores"
  };
end

Applications

CallbackScheduler could be reimplemented using Tasks
All API calls from game code could and should be made into tasks
Scenes could be preloaded using tasks

After some afterthought, Task should use Lua coroutines instead of C++ (at least for usage in Lua VM)
Since Lua VM is monothreaded it is not possible to implement coroutines from outside using C++ coroutines.
Task system will need to be reimplemented using language primitives for each language added to ÖbEngine.

Done and documented here https://github.com/ObEngine/ObEngine/wiki/Tasks


Functional tests for configuration and authentication

Depends on #756.
Adds my test-aci-auth-server library and the tests. The tests do sanity check if test-aci-auth-server actually produces some ACI then it checks basic auth, oauth, config overriding and file ignoring.

I have not looked at the test-aci-auth-server library yet but I wonder if it should share code with https://github.com/coreos/aci-discovery or they are 2 different things.

Quick glance at aci-discovery code tells me that it is basically slaps discovery protocol on top of images and keys on a filesystem. test-aci-auth-server doesn't implement discovery protocol and doesn't serve images from filesystem - it produces its own image with bogus application for every request. I wanted test-aci-auth-server to be completely standalone - no setup or other preparations are needed. So, 2 different things I'd say.

Updated PR.

The tests look good to me.
One open question is: where should test-aci-auth-server be located?

One open question is: where should test-aci-auth-server be located?

I believe this question is not directed to me. But for me it can stay where it is now. I'm not sure about moving it to appc - it is not generally useful nor appc should become a kitchen-sink of anything that related to ACI or App Container specification.

I think that is fine for now.

Actually @krnowak how would you feel about it being in the rkt repo itself?

Have a look, please - I placed the code in tests/test-auth-server.

Looks good, but needs a rebase and probably clashes with #794

Rebased.
@jonboulle: Yeah, it clashes. I'll fix the clash when either this or #794 gets merged.

Merging, I'll fix the clash in #794.


Task12

Worked on excel and workbook activities to read and write the data.

SourceCode/2024/May 2024/Supriya/Task12/project.json
Main.xaml
Log Message display names are duplicated. Please rename them to something more specific about their usage.
Names of activities should give a clear indication of how they are being used.
Score: 4/5
Note: The review score is based on the overall quality and clarity of the code review comments, with 5 being the highest possible score.

@Supriyar6040
Task – 12
Code verified.


CI: Bump Pico SDK to 2.0.0. 🎉

Unleash the bugs of war!

Note: There may be RP2350B (48 IO) bugs remaining!


Fix lodash remove predicate parameter.

Fixes #1003
Changes proposed:

[x] Fix

Things I've done:

[x] My pull request fixes an issue, I referenced the issue.

We didn't have any side effects till now but the implementation is wrong. Stumbled upon it when coding feature of #998.
By the way, somehow I managed to push the branch to the main repo. By bad.
@robertohuertasm appveyor/branch is missing Required. Please fix.


Prevent errors if the InkList property, in InkAnnotations, is missing and/or not an Array (issue 12392)

To prevent a future bug, the Vertices property in PolylineAnnotations are handled the same way.
Fixes #12392

/botio test

/botio-linux preview

Thank you!
/botio makeref


IScript's constructor run before Resource:OnStart

I'm use SimpleInjector and I except to register instance when OnStart run.
But unfortunately the IScript's constructor run before.

Thats by Design to Set the Script Event handlers before resource is started.


New version: VSCodium.VSCodium version <IP_ADDRESS>06

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:
user:

machine:

Hi @daiyam,
Like with the VSCodium PR yesterday, the x64 and Arm64 packages are being re-added as x86 packages, which fail validation. Could these be removed from the PR?


Test runner fails (documentation issue?)

Hi
README says that clj -X:test will run the tests. In fact, what I'm seeing is:
illuminator:clj-activitypub simon$ clj -X:test
No function found on command line or in :exec-fn

I suspect your environment has some context which allows it to select the appropriate test runner, but as I almost always work in a Leiningen environment this is unfamiliar to me and I'm not able to guess it.

Ah yep, the README is outdated. The project used to be a single lib but I split it into activitypub-core and activitypub-ring recently. There's no top-level test running anymore, so you'll need to cd into either of those directories and then run clj -X:test.
I'll update the README!

https://github.com/jahfer/clj-activitypub#running-tests


Matchup/standing navigation

Badger - Today at 5:20 PM
also at what point will it be possible to click through the website for a given weeks matchups?
currently you either have to go through the discord announcements or manually change the url

#48


SCons: use moc_files even when in cache_readonly

Describe the bug
the qt moc files didn't respect the cache_readonly argument to scons before, and would write to the /tmp/scons_cache directory. So I made a PR to move the mocfiles to a safe local directory if we set the cache_readonly param: https://github.com/commaai/openpilot/pull/29437
This works, but it appears the scons won't use the cache if it's copied from another folder (ex if we first build without cache_readonly, then try rebuilding with --cache_readonly, then it will still rebuild all of the moc_files, even though I copied them locally in the scons script).
Need a way to reuse the moc_files while still respecting cache_readonly

Should be fixed with #29528


VisibilityEnabler2D still toggles particles after being disabled by code

Tested on Godot 2.0.3 and 2.0.4, Windows 10 64 bits
How it happened:
In my game, pickups have particles on them. When the player picks them, I hide them and disable particle emission, because that way it won't "pop out" and I can make them respawn easily when the level restarts (which happens a lot).
To reduce CPU usage, I added VisibilityEnabler2D on pickups so their particles aren't simulated when out of view.
Problem: disabled pickup started to emit particles again when the player goes back the place where it was, because VisibilityEnabler2D activates them again.
Then, in addition to disable emission, I also turn off VisibilityEnabler2D with this code:
get_node("VisibilityEnabler2D").set_enabler(VisibilityEnabler2D.ENABLER_PAUSE_PARTICLES, false)

However it doesn't works at all, the enabler continues to enable or disable particles.
It works if I disable the enabler from the inspector, but in code I see no change.
Example project:
Here is a test project in which  I disable the enabler from code:
ParticlesEnabler.zip
Press right arrow to move the camera away from the particles. Notice it stops emitting, ignoring the ENABLER_PAUSE_PARTICLES setting.
(I also noticed a kind of margin, the camera has to be further away from the area)
You can also notice this when intentionally disabling particles: they will start to emit once in view.
What was expected:

VisibilityEnabler2D should work the same in code and inspector
Should pause particle simulation instead of changing emission

By looking at the code I can confirm that the collection of affected nodes is done when the VisibilityEnabler2D enters the tree, so no flags cannot be changed at runtime.
For the 2.1 branch, a new method called something like update_affected_nodes could be added.
For the 3.0 branch maybe the behavior of this node should be re-thought so it collects always every potentially affected node regardless which flags are set and then checks them on enter/exit to enable/disable what's relevant.

Regarding the detection margin, it's explained at https://github.com/godotengine/godot/issues/4803#issuecomment-225460236.

Any chance that someone will test this in 3.0?

I tested it in 3.1 and it seems like changing enablers after scene runs (i.e. via script or remote inspector too) doesn't take any effect.


CI : Publish nightly apim on azure registry & deploy on element-zero aks

Issue
gravitee-io/issues#6048
Description

Build apim from master and add plugins from nightly full apim zip
Update the Element Zero stack after each merge in the master branch.
Add workflows publish-to-bintray schedule with 0 2 * * * to replace legacy Jenkins job

Additional context

Indent change because prettier : https://github.com/gravitee-io/gravitee-api-management/blob/2cc80bb39e70b77b1fcc1addcc12be91c78ea310/.prettierrc#L2

Blocked by https://github.com/gravitee-io/gravitee-api-management/pull/103


Make the deduplication configurable per parser

As discussed a little bit in https://github.com/DefectDojo/django-DefectDojo/issues/1478, I believe it would be useful to have a configurable hash_code computation per parser, for the deduplication algorithm.
In the past month, the deduplication was changed several times, with a mix of changing the way of computing the hash_code and (more often) specific rules addded in the deduplication algorithm itlsef, often breaking the deduplication for some parsers.
I'm hoping we could put in place a basic deduplication algorithm, based on hash_code only:

If the hash_code is the same, the vulnerability is a duplicated
else, it's not

The complexity itself would reside in the hash_code computation. This would be done outside of the parser (as it is now).
In order to satisfy all use cases, it would be useful to make the set of fields used in the hash_code computation configurable, in settings.py for example.
I'm thinking of 2 levels of configuration:

a configuration per family of parsers (+ for each parser a configuration to state in which family they are, or hardcoded?)
an (optional) configuration for each parser, to allow specificities for each parser

The families of parsers that I know of at this point (please correct me / complete the list):

dynamic parsers (ex: ZAP)

hash_code should be computed based on title, endpoints, CWE

static parser (ex: sonar, checkmarx)

hash_code should be computed based on  title, cwe, file_path, line number (or not), cwe

dependency analysis (ex dependency check)

hash_code should be computed based on title, cwe, file_path (or CVE and Library, to be determined)

Another use case that this logic could handle is a tunable / better precision for static parsers.
Including the line number in the dedup fields for static parsers make tracking a unique vuln very weak: say we have a vuln at line 100, before the next scan we have added some code before line 100 so now our vuln is at line 101 -> it will not be detected as a duplicate but as a new vulnerability.
Some people may want a more "aggressive" dedup system in order to attach information to a finding and making sure it will persist across scan (they will want to remove the line_number in the computation), other people may want a more exact count of findings. Thus the necessity of a configurable solution
Also some SAST tools have already advanced techniques to track unique vulnerability even after code change, using data flow graphs. Checkmarx for example can do this. I believe one of the fields pathId or SimilarityId can be used to track unique vulnerabilities. We could update the parser to extract those fields and put them in the dedup key in order to have a unique vuln tracking as clever as checkmarx has (when analysing checkmarx reports)
To accomodate the various fields that will exist in parsers without making changes in the model everytime, we could add fields:

custom_1, custom_2, custom_3
and another table to associate each value to a label
(on this point i'll need to check how the current custom fields work, I can maybe use this functionality)

Edit 26/08: another (better) solution I think to avoid adding custom fields :

add a new field in dojo_finding that would hold the technical identifier from the source tool, for example unique_id_from_tool (for checkmarx filled with "pathId", for sonar filled with "key" ...)
add a configuration parameter that states for each parser if the dedup should be done based on hash_code or based on the unique_id_from_tool
That will allow keeping a hash_code filled with functional information in the database if at any point we want to go back to deduplication based on functional fields.

A difficulty to tackle is that, as @Maffooch pointed out, there is already a "kind of" deduplication made at (some) parser level when importing vulnerabilities, in order to not import duplicates from the same file. I think this specific deduplication might be removed altogether in order to have a unique deduplication system (if per the rule of the "global deduplication" two vulns in the same file are duplicates, one only is imported) but I'm not sure right now -> more info on that in a later post.
Edit 26/08: as discussed below (my post of august 18th), for SAST tools I think this problem should be alleviated by enforcing that 1 vulnerability in the source tool is imported into one and only one vulnerability in defectDojo (thus, no pseudo deduplication / aggregation done by the parser)
For debuging purposes, it will be useful to add also another field at finding level with the key values that generated the hash (value of the concatenated keys before applying the hash or whatever operation we apply before hashing). Otherwise it will be impossible to understand what's going on when the configuration changes and the hash value changes.
Edit 26/08: not too sure on this. keeping the whole value defeats the gain we have in having a hash_code (in term of space saving in the database).
However, I think we'll need a mass recalculation of hash_code: when changing the hash_code configuration, the user will run a specific command that re-computes all hash_codes
@DefectDojo/defectdojo-moderators what do you think?
I can work on it but don't expect to have this right away :)
Any feedback is welcome.

good news: sonarqube is also able to track same vulnerabilities across scans, at least with simple line number shift. The parameter we're gonna want to use for deduplication is key from the json extracted by /api/issues/search, which seems to identify uniquely a given vulnerability

Regarding checkmarx, this is the current situation: if you've imported some checkmarx reports, you must have noticed that the number of vulnerabilities in checkmarx is higher than in defectDojo (see for example unit test "multiple_findings.xml"). This is because 1 vuln in checkmarx, for each type of vulnerability is for a given:

source (start of attack vector)

filename
line number
object (variable)

sink (end of attack vector)

filename
line number
object (variable)

In DefectDojo, there is less information: we aggregate those multiple vulnerabilites from checkmarx into a single one, based on sink line number (into line number) and sink filename (into file_path) only.
So if you have a typical sql injection with a query constructed with 5 parameters, you'll have 5 vulns in checkmarx but a single in defectDojo.
It creates misunderstanding for defectDojo users and makes it almost impossible to verify that all vulnerabilities were imported correcly into defectDojo because the count always differs.
Also it would make it very complicated to track unique vulnerabilities using checkmarx pathId (or SimilarityId) because you'll have 5 distinct pathId in checkmarx but only one finding in defectDojo. Which pathId are you going to import? To have something robust, you would need to import all pathId, attach them to the finding, and when comparing 2 findings, they would be duplicate if at least one of their pathId is the same. Doesn't seem really optimised.
Conclusion: I think the pre-requisite to a proper deduplication system for SAST parsers is to make sure that each vulnerability from the source tool is imported into 1 distinct finding in defectDojo (and only one).
I'll see what I can do for checkmarx, with existing fields or adding new ones: for example we could concatenate all source and sink information to a "source" and a "sink" field in the finding (we need the details because having 5 findings in defectDojo that differ only by a technical id used for deduplication won't be helping).

dependency analysis (ex dependency check)
hash_code should be computed based on title, cwe, file_path

Please not! What happens if you adjust the title or correct the cwe (right now the same, always). I recommend to use duplication based on CVE and Library (e.g. sha1)

@wurstbrot noted :) i have thrown those very quickly, the point is they differ for each kind of parsers. i'll check this more thoroughly based on the currenty behavior and the ideal behavior!

I have added a couple of adjustments in my initial post. see paragraphs starting with "Edit 26/08"

@Maffooch re-computing the hashcode upon save wouldn't be enough: when changing the configuration, you'll want the deduplication to work right away. Most of the findings, that you have imported the past week, month, year won't ever be modified so they'll keep their wrong hash_code. You need to re-compute the whole database; maybe we could add a filter on product or/and dates or/and scanner in order to be a bit faster when the user knows that for other products/dates/scanners it doesn't matter.

FYI I'm working in priority on having a reliant tracking of unique vulns by SAST scanners:

removing the aggregation at checkmarx scanner level (i'm keeping a "checkmarx legacy scan" and adding a new scanner without the aggregation)
adding that unique_id_from_tool and other missing fields in dojo_finding (i'm thinking: SAST_SOURCE and SAST_SINK, both holding - for checkmarx- a concatenation of filename / line number / object for either source or sink)
checking the same for sonar parser
adding the configuration per parser that says if we want to deduplicate on hash_code or  unique_id_from_tool

i'll look at the hash_code configuration per parser a a later time

see also this slack discussion: https://owasp.slack.com/archives/C2P5BA8MN/p1566164911107100


[feature request] COMMUNITY_PACKAGE_JSON as a parameter

Currently it is only a static structure. It would be great if you could also set these as parameters for the individual rules.
As an example:

community-package-json-author-email-still-default
community-package-json-author-name-still-default

@ivov thanks :)
i tried to use this: 'n8n-nodes-base/community-package-json-author-name-still-default': ['error', {authorName: 'lublak'}],
But this doesn't work:
Configuration for rule "n8n-nodes-base/community-package-json-author-name-still-default" is invalid:
        Value [{"authorName":"lublak"}] should NOT have more than 0 items.

i use the latest version from eslint

my fault i used the old version


Making docs dropdown in alphabetical order.

Fixes #1091.

@jgeewax I think we should tried to have shared HTML / JS / CSS for our custom theme.
It seems the Node.js theme continues to improve while ours looks like an old snapshot of what they had.
Comparing our custom docs to RTD is not great (i.e. ours look not so great):
http://googlecloudplatform.github.io/gcloud-python/latest/gcloud-auth.html
http://gcloud-python.readthedocs.org/en/latest/gcloud-auth.html

LGTM


asp-for TagHelper doesn't work inside a ViewComponent (possibly others as well).

I have a ViewComponent that returns a View. In that view I have a form with a few input fields. On those fields I added the asp-for attribute. But for some reason they don't work when used in a ViewComponent.
When I place the content of the view directly in, lets say, my index.cshtml, then all the asp-for tags work perfectly. Just not in combination with a ViewComponent.
I've added a demo project to show the problem.
Is this a bug?
Demo - ViewComponent TagHelpers bug.zip

@chinookproject Your ViewComponent's view does not have an @addTagHelper. The reason why TagHelpers automatically light up in your other views is because you have a _ViewImports.cshtml sitting next to those views that have the @addTagHelper

Thanks! It works when I add the tag helper in the ViewCompents view file. I thought the ViewComponent would also pick up the imports from the _ViewImports.cshtml. But it makes sense now that it doesn't.

Tag helpers work fine for me in ASP.NET Core. I keep view components under Views/Shared/Components/Component1.. as described in documentation: View components in ASP.NET Core


html closing tag

Shouldn't this be like this?
Doesn't seem to make a difference anyway, still loads fine.

Ah, you are right...


fuse: Only reload list of snapshots once per minute

Codecov Report

Merging #1507 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1507      +/-   ##
==========================================
- Coverage   51.78%   51.64%   -0.15%
==========================================
  Files         138      138
  Lines       11100    11103       +3
==========================================
- Hits         5748     5734      -14
- Misses       4476     4499      +23
+ Partials      876      870       -6

Impacted Files
Coverage Δ

internal/fuse/root.go
0% <ø> (ø)
:arrow_up:

internal/fuse/snapshots_dir.go
0% <0%> (ø)
:arrow_up:

internal/checker/checker.go
67.55% <0%> (-3.78%)
:arrow_down:

internal/backend/s3/s3.go
65.76% <0%> (+1.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d84565...6d91d46. Read the comment docs.


Microsoft.TypeScript.MSBuild 2.0.3 - Painful when switching branches because it says the file is locked

TypeScript MSBuild Version:  2.0.3
Expected behavior:
The package files are not locked by VS or MSBuild so that when switching branches to another branch without this package or with a different version of this package we dont have to close VS to get a clean repository.
Actual behavior:
When we switch branches from a branch with this in place to one without it or with another version, the files are locked and we have to close Visual Studio down to release the locks.

I found an obscure way of solving this, using the environment variable MSBUILDDISABLENODEREUSE=1 to stop the MSBUILD.exe tasks being left open by VS.


THRIFT-3765 fix memory leak in python compact protocol extension

This fixes a significant memory leak in the new Python extension module for the compact protocol.

@cjmay thanks for catching this before the release.
C extension + UTF8 fix seems to be the true culprit here (so it's even much more worse in terms of the scope of this regression).

Thank you!  We were excited to see this extension get written.

Committed, thanks again for the fix.


[REQ] Clothing compatibility?

Something like a struct or class that holds the players clothing?
Clothes clothing = Game.Player.Character.Clothes;
clothing.face_id = 2; //etc.

Not sure if already requested sry

Propably useful:
http://gtaxscripting.blogspot.de/2016/04/gta-v-peds-component-and-props.html

I had a working clothes editor, but decided to scrap it as some permutations of clothes will cause the game to crash when applied to micheal/franklin/trevor/mp characters(M&F)

@zorg93 What do you mean by that? Did you verify that the component IDs/textures are valid? Do certain valid component IDs/textures result the game to crash? cause I haven't experienced that.
I have a working C# coded online-like character creator, letting you customize the components (clothes), overlays (makeup), ped props (accessories), hair styles and colors, eye colors, heritage and facial features (with a grid below the menu, in a similar fashion to Rockstar's online character creator, if you have screenshots of the facial feature settings you can clone the character to singleplayer, and vice versa).
Currently working on tattoos and finding which groups are compatible with eachother so they wouldn't overlap. After that I might add clothing restrictions in a similar fashion to Rockstar's, so you wouldn't have overlapping stuff, but that's a lot of work unless I figure out a better way to do it, so I'll probably only do that if I'm bored.
Also to add to the link from @JohnnyCrazy, watches and bangles are Prop IDs 6 and 7 respectively, at least on the multiplayer models, those aren't mentioned there.

@DorCoMaNdO I just found a specific example then. While playing as franklin, setting the torso drawable to 22(its like a coat), then setting to its max textureID caused the game to crash. As for verification, Im not sure how I could go about that. According to limits set by Number of texture variations it should be ok

For verification you'd use natives like IS_PED_COMPONENT_VARIATION_VALID and _IS_PED_PROP_VALID. I'm not sure if it'd keep you away from that scenario though. I've noticed a few odd things myself but not with my code, it was with Menyoo, which uses GET_NUMBER_OF_PED_DRAWABLE_VARIATIONS and GET_NUMBER_OF_PED_TEXTURE_VARIATIONS to check whether there are more drawables or textures to cycle through. I'm not sure whether these will let you avoid the crashes.
waits to test before sending
I just tested the torso drawable 22, with Menyoo it lets me to go up to texture 4, which was invisible, it didn't crash until I left it on it for a few seconds. My code, which uses the IS_PED_COMPONENT_VARIATION_VALID native, it goes up to texture 3, texture 4 and up return false (i.e. invalid).

Hmm I didnt know about the variation valid native, adding that check should hopefully fix issues

These are snippets from my code but here's how I do it, the API I made handles and verifies everything I've already implemented.
The code below is a snippet of my own menu code, it checks if the current drawable + 1 if pressed numpad right or - 1 if pressed numpad left is valid.
if (CharacterAPI.IsComponentVariationValid(Target, Component.Mask, drawable + (e.Type == ItemActivatedEventArgs.ActivationType.Left ? -1 : 1)))
                            {
                                drawable += e.Type == ItemActivatedEventArgs.ActivationType.Left ? -1 : 1;
                                texture = 0;
                            }
                        CharacterAPI.SetComponentVariation(Target, Component.Mask, drawable, texture);
The function that handles the native:
public static bool IsComponentVariationValid(this Ped ped, Component component, int drawable, int texture = 0)
        {
            return Function.Call<bool>(Hash.IS_PED_COMPONENT_VARIATION_VALID, ped, (int)component, drawable, texture);
        }
Component is an enum, I included lots of duplicates to cover what people might think the component is (since on freemode characters some stuff is different), it's understandable if you'd only like the actual names without the duplicates.
public enum Component : int
    {
        Head = 0,
        Mask = 1,
        Beard = 1,
       Hair = 2,
        Gloves = 3,
        Torso = 3,
        Pants = 4,
        Legs = 4,
        Parachute = 5,
        Hands = 5,
        Shoes = 6,
        Feet = 6,
        Accessories = 7,
        Scarf = 7,
        Necklace = 7,
        Bracelet = 7,
        Teeth = 7,
        Eyes = 7,
        Undershirt = 8,
        Accessory = 8,
        BodyArmor = 9,
        Task = 9,
        CrewEmblem = 10,
        Top = 11,
        Shirt = 11,
        Torso2 = 11
    }
The function setting a component:
public static bool SetComponentVariation(this Ped ped, Component component, int drawable, int texture = 0, int palette = 0)
        {
            if (IsComponentVariationValid(ped, component, drawable, texture)) return false;
            Function.Call(Hash.SET_PED_COMPONENT_VARIATION, ped, (int)component, drawable, texture, palette);
            return true;
        }
I only added the return values to the set function yesterday, but that lets you simplify the implementation I made in my menu further, instead of checking whether the variation is valid, you could just attempt to set it, if it was successful you could continue to do whatever (in my case it'd be storing the component in the outfit to a file).

I decided to make put Clothes and Ped Props in the same class. The classes for getting and setting Clothes and Props both inherit from the same class as well to make working with them much simpler


New and improved GPS Network online bill pay system

Benefit
The current GPS Network bill pay system is unreliable and often out of commission. Creating a new online bill pay system will make it possible for our customers to create a new account or renew an existing account seamlessly and it will be built following DTS security and website requirements.
Acceptance Criteria

The website will require all users to create a utah ID
Users will need instructions and be educated on how to create a Utah ID and understand why it is required.
Initial email announcement to customers.
Initial email announcement to partners and vendors.
Conference Presentation - Monsen/Trimble Users Group.
Conference Presentation - Utah Council of Land Surveyors.
Follow up email announcement to customers.
Follow up email announcements to partners and vendors.

Notes
No response
Risks
No response
Issue Reference
refs #

Can we add the product name to the dns?


Command line application

Yubico Authenticator before the version 4 used to have a non-GUI command line application yubioath.exe. Was it removed? If yes, would it be difficult to re-implement it, please?

The functionality has been moved to the YubiKey Manager CLI.


Feature: Team Build friendliness

By default, Team Build passes the OutDir property to projects during a build. BTDF currently uses only OutputPath and never defines OutDir for building an MSI. For more consistency with csproj/vbproj and a more seamless experience with Team Build, define OutDir the same way that csproj/vbproj does and use it as the path for the generated MSI. Rather than doing a . clean of the output path, delete only the two files that an MSI build can generate, since Team Build could have put other files in the same location.  Change the default target in new .btdfproj files to Installer instead of Deploy.  Add default TeamBuildOutDir property definitions in new .btdfproj files.
This work item was migrated from CodePlex
CodePlex work item ID: '8847'
Assigned to: 'tfabraham'
Vote count: '1'

[UnknownUser@11/7/2011]
Resolved with changeset 63418.

[UnknownUser@5/22/2012]

[UnknownUser@5/22/2012]
Resolved with changeset 67586.

[UnknownUser@2/21/2013]

[UnknownUser@5/16/2013]