Changes in /opt/harvest/conf/zapiperf/cdot/9.8.0/volume.yaml file was overwritten during harvest upgrade

Describe the bug
We have made few custom changes to /opt/harvest/conf/zapiperf/cdot/9.8.0/volume.yaml file. During harvest upgrade, this changes have been overwriiten.
Harvest version: harvest version 21.05.3-2 (commit b482aff) (build date 2021-06-28T21:08:05+0530) linux/amd64
Command line arguments used: harvest start clus01
OS: CentOS Linux release 7.9.2009 (Core)
Install method: YUM
ONTAP Version: 9.8P4
To Reproduce
Make some changes to volume.yaml file and run harvest update
Expected behavior
Config files should not be overwritten during the upgrade.
Actual behavior
Custom changes made to the volume.yaml file was overwritten
Possible solution, workaround, fix
Make a copy of the production file and diff it against the default one in the RPM. If there are any changes, copy the production file to another location and ask customer to check and copy back his file to required path

hi @madhusudhanarya we added sub-templates for customer edits. Does this line of documentation address your issue?

Hi @cgrinds: we need to implement below feature.
https://github.com/NetApp/harvest/issues/209
can you suggest how i can do this using sub-templates?

@madhusudhanarya - it's not completely possible until #124 is finished. You can get close with the following
cp conf/zapi/cdot/9.8.0/volume.yaml conf/zapi/cdot/9.8.0/tagvolume.yaml

Create a conf/zapi/custom.yaml and copy/paste the following into it to use the new template

collector:          Zapi

# Order here matters!
schedule:
  - instance: 600s
  - data: 180s

objects:
  Volume:           tagvolume.yaml

update conf/zapi/cdot/9.8.0/tagvolume.yaml with details in #209. This only needs to be done once
edit conf/zapi/default.yaml and comment out   #Volume:           volume.yaml - this will be overwritten until #124 is added

Bounce harvest and you will see the tagged volumes

Thank you @cgrinds. Was able to get custom labels working after following above instructions. We can close this issue.

awesome - glad you got it working!


Dashboard: hide admin notices

Context

Summary
Hide all notices on dashboard.
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6330

The editor doesn't have any .notice selector to specifically hide notices there, yet it works. So why is this needed here?
I'd want as much parity between the too stylesheets as possible.

The editor doesn't have any .notice selector to specifically hide notices there, yet it works. So why is this needed here?

Here is css for the editor
#screen-meta,
#screen-meta-links,
#screen-meta-links ~ :not(.web-stories-wp):not(.clear) {
  display: none;
}

The reason this work, is .notice is a sibling of #screen-meta-links.
However in the dashboard have a screen-meta-links div.

To make it work generic to work for both
#screen-meta,
#screen-meta-links,
#screen-meta ~ :not(.web-stories-wp):not(.clear)
#screen-meta-links ~ :not(.web-stories-wp):not(.clear) {
  display: none;
}

Or I just added notice to hidden. It can't be generic as the markup is different.

The editor doesn't have any .notice selector to specifically hide notices there, yet it works. So why is this needed here?

Here is css for the editor
#screen-meta,
#screen-meta-links,
#screen-meta-links ~ :not(.web-stories-wp):not(.clear) {
  display: none;
}

The reason this work, is .notice is a sibling of #screen-meta-links.
However in the dashboard have a screen-meta-links div.

To make it work generic to work for both
#screen-meta,
#screen-meta-links,
#screen-meta ~ :not(.web-stories-wp):not(.clear)
#screen-meta-links ~ :not(.web-stories-wp):not(.clear) {
  display: none;
}

Or I just added notice to hidden. It can't be generic as the markup is different.

Thanks for the insight!
Given that the current solution also hides the no-js notice, let's try
#screen-meta,
#screen-meta-links,
#screen-meta ~ :not(.web-stories-wp):not(.clear)
#screen-meta-links ~ :not(.web-stories-wp):not(.clear) {
  display: none;
}

as you suggested

Here is a cleaner solution I think. https://github.com/google/web-stories-wp/pull/6614/commits/4f0a5aebe257051a7ab3d80a746421647845b3bd


Ci repair

Remove gtest builds. They depend on Python 2 which is no longer available in GitHub actions.
Suppress ClangCL warning for "unsafe buffer usage" that flags all the raw string operations.

coverage: 99.323%. remained the same when pulling d8d9e191eee47b39ad875c930b44d26801d6ee32 on thetic:ci-repair into eccbc2190c672e598c1dd2bf5e4295f5ba27aad1 on cpputest:master.

Thanks for still paying attention after my lack of attention the last months. Is there no better solution than this?

Maybe, but I'd like to get CI passing in the meantime. I don't have much interest in trying to resurrect Python 2.

can someone merge it please? would love to see a new build in releases section!

Ok....


Minor addition

Add threshold and support_width to input

Was this closed intentionally?

Was this closed intentionally?

Sorry for any confusions. I closed it because I want to use a forced push to solve a conflict in the root branch. I made a new PR #336.


Better dns testing

Move dns test along with dashboard testing becasue we are running short on time on travis.
Fix dns testing

With this we actually test dns.


generate wifi access switch for wired devices

the component generates wifi access switch for wired devices.

This is really strange behavior :)
Thanks for the hint, I will fix this in the next version of the component.

Fixed in this pre-release version.


Feat: Add a loader

Describe the feature
I want to add a loader when you open the website first time
Add ScreenShots
I want to add a loader when you open the website first time, it can increase the user experience.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@souvikpramanikgit , you can proceed!

Hey, just checking in—are you still working on this issue?

Yeah, i will create a pull request in a hour

As i didn't notice properly that this repo is written only in js,ejs, so i can't do this, because i don't know ejs

Sure, No problem.


feat: iOS support

update to use the Polymer's IronFlex classes
add get/set methods for transform and transformOrigin browser support

Could resolve #31, #22

Thanks!


Remove unnecessary platforms minimum

This is not necessary and causes error in SQLiteKit:
The package product 'SQLiteNIO' requires minimum platform version 13.0 for the iOS platform, but this target supports 8.0

See reasoning here https://github.com/vapor/sqlite-nio/pull/18


merge main to live Tuesday 10 AM

Docs Build status updates of commit c073385:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2019-ps/configci/New-CIPolicyRule.md
:white_check_mark:Succeeded
View (WindowsServer2019-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add actions to user context menu #1674

This adds:

Whois
Conversation

And if the lounge user is also Op in the channel it adds:

Kick
Ban

Added ab80d640fc988a26d9f1f20cf4cc2309bb5251a3 this fixes everything in #1674 as it will now show the context menu when you click a user instead of doing a whois.  As far as UX goes this is more in line of other IRC clients and should make The Lounge somewhat easier to use.
On #thelounge there was some discussion about the ban action since it now, lacking better information,  defaults to banning based on nickname. I'll remove that in a future commit.

@MaxLeiter moved the function to utils.js
@xPaw changed the selectors to data-attributes as discussed on irc.

Did some searching and if accepted this would also fix #533 and partially #347.

@creesch can you squash commits? 👏

Sure can do.

Done :)

@astorije should be all of it. Just need to squash stuff....


Why when I press "D" and "down-arraw", It delete two lines?

I am a beginner in vim.
Any help?

Is it because  is defined to 2 in somewhere in the vimrc ?

This is the default behavior. You can use :help d  in vim for more detail.

thanks, but can i stop this feature？------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2019年8月1日(星期四) 晚上11:21
收件人<EMAIL_ADDRESS>抄送: "Statham"statham.stone<EMAIL_ADDRESS>主题: Re: [amix/vimrc] Why when I press "d" and "down-arraw", It delete twolines? (#529)
This is the default behavior. You can use :help d  in vim for more detail.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

what is the motivation to stop that? It is designed in such way that you can use command <motion> to quickly edit text. If you just mistakenly type d and then down, u can undo the command. If you mistakenly type d, esc helps cancel the command.

I'm closing this down...


Teukolsky source only works in Carter tetrad

I fixed this. But I've left the issue open until someone checks my formulas.

We checked this via email and agreed that the package now correctly gives the Teukolsky source in the Carter and Kinnersley tetrad.


docs:Merge hindi translation of the contribution guidelines.

Description

Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[ ] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[ ] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

@helloanoop Can you review this please.

Merged!
Thank you @jaideepghosh !


Test fix

Closes #30

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #31   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          30      30
  Lines         425     425
  Branches       18      18
======================================
  Misses        425     425

Impacted Files
Coverage Δ

src/rest_client/base.py
0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed15b2...523a68e. Read the comment docs.


Support processing None value in GIE

Is your feature request related to a problem? Please describe.
As titled.

Supported in #3972


Add documentation for Composite Sink

Screenshot 2023-08-07 at 13-52-15 Composite Sinks · Blue Brain Nexus

Creating #4190 for the CompositeSink name issue


Getting 2 hours less than I want

Hi. I'm trying to set a value for hours but when I send that info to my API I always store 2 hours less than I want.
This is the piece of code:
<ion-list>
                         Fecha de salida {{new.date_trip| date: 'd MMM y @ HH:mm' : 'UTC + 2'}}                         (click aquí para selecionar)
                 </ion-list>
In the Ionic App it sees ok, but the in the Database is not stored as I want.
Thanks in advance

Hi Juan, it seems that you are not correctly storing/reading the timezone from your time. Please check what is being sent to server and what is being stored in database to discover if the problem is in your ionic code or on server.

Thanks for your answer. I checked the server and it's ok. I mean that if I want to store a new datetime from the web app it is stored ok, but when I try it from the ionic app it fails...
This is the datetime what I send from ionic:
date_trip:Thu Apr 28 2016 15:40:00 GMT+0200 (CEST)
And this is what I get into the server when I insert it into the server
if (isset($data['date_trip'])) $trip->setDateTrip(new \DateTime($data['date_trip']));
[date_trip] => 2016-04-28T13:40:00.000Z
The server timezone is Europe/Madrid
Thanks again for your time :)

2016-04-28T13:40:00.000Z is the same datetime as Thu Apr 28 2016 15:40:00 GMT+0200 (CEST) so I see no problem. Could you please provide more info?

Well, I think my problem is about datetime conversion between Ionic and PHP Server... :/

This is definitely problem on your server, either in API for ionic app or in settings of your Web server. You can use the snippet from #15 to convert the time in ionic app to timezone-less. This fix should help you, but does not fix the bug you have on server side.


error while eosd, (error_info_injector<boost::program_options::multiple_occurrences)

Use the branch dawn-2.x.
Already changed the config.ini, but has error while launching eosd.
$ ./eosd
1801072ms            main.cpp:65                   main                 ] Throw location unknown (consider using BOOST_THROW_EXCEPTION)
Dynamic exception type: boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::program_options::multiple_occurrences> >
std::exception::what: option 'enable-stale-production' cannot be specified more than once

obviously you have two or more enable-stale-production in config.ini


txn: fix the wrong min_commit_ts returned by prewrite

What problem does this PR solve?
The min_commit_ts returned by prewrite was incorrect. This may make the client commit with a commit_ts smaller than expected.
It can happen when the min_commit_ts of a pessimistic lock is pushed forward and the new min_commit_ts is even larger max_read_ts.
What is changed and how it works?
Correct the min_commit_ts returned by prewrite.
This PR also ensures min_commit_ts does not regress in prewriting multiple keys.
Check List
Tests

Unit test

Release note

Part of async commit

PTAL @MyonKeminta @youjiali1995 @cfzjywxk

It can happen when the min_commit_ts of a pessimistic lock is pushed forward and the new min_commit_ts is even larger max_read_ts.

I think the solution is updating the max_read_ts when processing check_txn_status.

It can happen when the min_commit_ts of a pessimistic lock is pushed forward and the new min_commit_ts is even larger max_read_ts.

I think the solution is updating the max_read_ts when processing check_txn_status.

OK I can also update it in https://github.com/tikv/tikv/pull/8584.
Anyway I think this PR is also reasonable...

LGTM

/merge


Invalid type cast

In https://github.com/seleznevae/libfort/blob/ccb892f77dc30c2ebc42916a3f862a965e8c097f/lib/fort.c#L6870 contains a cast from pointer to integer of different size according to CLang warnings
This may attract side effects for x64 ¯_(ツ)_/¯

Hi! Thanks for reporting. I've merged fixes to the develop branch.
If it doesn't help in your environment please reopen the issue.


Project renaming effort

 Create registries, repositories, and code changes to satisfy a rename of the upstream projects around STF


install on server problem

Your Windows build number:  Microsoft Windows [Version 10.0.17134.1]

hi, i install wsl (ubunbu) on server with this guide: install-on-server
wsl good work, but when shutdown and turn on, wsl has error:
Windows Subsystem for Linux has no installed distributions.
Distributions can be installed by visiting the Microsoft Store:
https://aka.ms/wslstore
Press any key to continue...

and i have to install again wsl and install my dpkg ...
Is there a solution?
sry 4 my bad english

For your reference, I got this this morning when I turned my computer on. AFAIK there was no Windows update so I was a bit perplexed as to what had caused it.
On the advice of this comment https://www.reddit.com/r/bashonubuntuonwindows/comments/8j5igr/subsystem_using_lxss_folder_broke_today/dyx9ubu/ I just rebooted my computer (literally did nothing else) and that fixed it.
Still have no idea what caused it.
Win 10 Version	10.0.17134 Build 17134

Possible cause:

Lxss registry may be removed.
The rootfs folder may be deleted.
That folder permission may be changed temporarily.

This is a duplicate of #2576.


Error while trying to install through cocoapods?

Hi I'm getting this error
The platform of the target My_Project_Name (iOS 10.0) is not compatible with RichEditor (1.0.1), which does not support iOS.
and my podfile has
platform :ios, '10.0'
my minimum deployment version and IOS deployment target is at least 10.0 as well
TIA for your help!

Just saw the other ticket raised, i would love it if it could support IOS as it seems like a powerful tool to have on iphones cheers!


Time as dataset

Hi, I need to make a chart JS where my dataset is composed of times f.e: 0:0:6 or 146:53:1, however chart.js only checks the first number in this case 0 and 146, but that's not exact enough. How should I do it to make it look for minutes/seconds as well, because the chart shows just 0 for both: 0:59:59 and 0:0:2.

@adammo94 do you have a sample of what you're trying to do? Have you followed these samples? https://github.com/chartjs/Chart.js/tree/master/samples/scales/time

@adammo94 I'll be glad to help you but am unfamiliar with the time format in your comment. 146:53:1? Please explain...

Looks like your data is duration. You'll need to parse that yourself or using some external library. Durations are linear, so those can be plotted on a linear scale after converting to second for example.


Public the new interpolator

The web interface and the default on Oceanography image are both using the old version of the interpolator. We should change that to the new version.
There is also a couple other todo items:

[ ] Tom needs to create YouTube video and documentation
[ ] We need a button to select dataset and switch to ECCO
[ ] ECCO has a few less zoom levels.
[ ] Create viewer for other datasets on sciserver.

Also, I want to make a few edits to the UI. E.g., the default vorticity limits are wrong (10x too big). Where are the configuration files for the UI?

@ThomasHaine The limits are set in https://github.com/sciserver/poseidon-viewer/blob/master/src/store/index.js

@dmedv I'm working on some UI edits. How do I push/install the updated code to the live viewer instance in my SciServer container?


Trying to install via Kaggle

WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7d9321f42a70>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/attention-sinks/
Tried ! pip install attention-sinks and ! pip install attention_sinks, same error

Solved reseting Kaggle to Factory


Ctypes setup

But for linker issues mentioned on Discord, the setup is nearly completed (already works on mac) - a test app renders the C example.


whisparr: init at <IP_ADDRESS>9 + nixos/whisparr: initial commit

Description of changes
https://wiki.servarr.com/en/whisparr
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

The merge conflict needs to be resolved.


Custom JSON (de)serialisation not working on POST

Hi there!
I'm trying to send a post with a JSON that might contain a \n character in one of its fields. I tried what is explained here https://pydantic-docs.helpmanual.io/usage/exporting_models/ with no success. I can run the example there with no problems but when used in the app it crashes when it tries to parse the input json.
The sample code:
import json
from fastapi import FastAPI
from pydantic import BaseModel

def new_json_loads(*args, **kwargs):
    kwargs.update(dict(strict=False))
    return json.loads(*args, **kwargs)

class Request(BaseModel):
    name = "John Doe"
    class Config:
        json_loads = new_json_loads

r = Request.parse_raw('{\n  "name": "john \n doe"\n}')
# It runs!
print(r)

app = FastAPI()

# It does not run here when a request arrives
@app.post("/test")
def read_root(request: Request):
    return request

Description

Open the browser and call the endpoint http://<IP_ADDRESS>:8000/docs#/default/read_root_test_post.
Try it out with: { "name": "john  doe" }. Don't forget to enter a new line after the word John
The 422 error returns

{
  "detail": [
    {
      "loc": [
        "body",
        18
      ],
      "msg": "Invalid control character at: line 2 column 17 (char 18)",
      "type": "value_error.jsondecode",
      "ctx": {
        "msg": "Invalid control character at",
        "doc": "{\n  \"name\": \"john \ndoe\"\n}",
        "pos": 18,
        "lineno": 2,
        "colno": 17
      }
    }
  ]
}

Environment

OS: [e.g. Linux / Windows / macOS]: Linux 20.04
FastAPI Version [e.g. 0.3.0]: 0.61.1
Python version: 3.7.8

Thanks for your help!

Hi @charlielito!
As you can see here in sources, the custom json_loads won't be called at all.
But anyway, the issue is that you're sending a malformed JSON - line breaks inside keys and values are not allowed. By pressing Enter you're creating a payload like this:
b'{"name":"john\n doe"}'

And it's invalid from the JSON standpoint. If you need to store line breaks in the value, you should escape \ character, so the payload would be like this:
b'{ "name": "john\\n doe" }'

Just try to send { "name": "john\n doe" } in the same way you've described - but without visual line breaks. Then \n would be preserved.

Thanks for taking the time to answer.
I know that that way the JSON is malformed, that's why I want to add a custom json_loads, specifically with the parameter strict=False to be able to parse it. I want this because I am using the swagger ui to send a sql query in a JSON field, and such query includes break lines when pasting the query from another place.
The question is if it is even possible that the custom json_loads is used?

Hi 👋
This is an issue for me as well, when a user sends a load that contains an accidental \ I would like an easy way to remove that and process the request without just returning an error message. I see a very long dicussion about a similar  issue to this https://github.com/samuelcolvin/pydantic/issues/1098 on pydantic site.

I'm also looking for a way to use a custom json_loads
My use case, is my data model contains a field which is zipped with a custom encoder, and i'd like to be able to unzip it the other end.

Having same problem. I would like to throw an error when a duplicated key is present, and this is possible through pydantic, but FastAPI is not validating the JSON loader with pydantic, it is doing it with Starlette.


Winch Update Check

Basic version check using Octokit.net, has worked fine in my testing but does require that the 1.2MB dll be included with Winch.
Octokit.zip
Resolves #7

On hindsight, would probably be good to have this toggleable in the config to avoid devs spamming their api.

Hmm, not exactly a huge fan of the extra dll just for update checks...
And yes, if there's a rate limit it should definitely be configurable.

Yeah i’m not sure it’s worth it given the extra dll, and wasn’t particularly able to find other options that wouldn’t also have a dependency.

Why not just make a simple request to https://github.com/Hacktiz/Winch/releases/latest and then check the re-direct link whether it has the latest or not?
Additionally it would be simpler if releases don't have the winch version in the zip name because then you can always link to https://github.com/Hacktiz/Winch/releases/latest/Winch.zip and have it resolve appropriately


Flights with no positions display an error on plot.php.

When following the link for a flight displayed on flights.php to a flight for which no positions have been logged PHP errors are encountered. When a link to plot.php is clicked and not position data is available for said flight these errors need to be trapped and a message reporting no plot information is available needs to be displayed to the visitor.

A modal is now displayed alerting the visitor to the fact there are no positions to display for flight with no position data stored in the database. Also PHP errors are no longer encountered when accessing a page with no flight data available.
Commit 554feac1e9424663e425413ea0012069290a48b8.


Support xml as a column type for XMLFdw

If a create foreign table with type xml, is it possible to get the full child xml tree, not just the text from the tree?
create server xmlfdw foreign data wrapper multicorn options (wrapper 'multicorn.xmlfdw.XMLFdw');
create foreign table xml_test ("thing1" text, "thing2" xml) server xmlfdw
    options (filename '/tmp/test.xml', elem_tag 'child');

And if /tmp/text.xml is
<root>
  <child>
    <thing1>foo</thing1>
    <thing2><leaf1>leaf1</leaf1><leaf2>leaf2</leaf2></thing2>
  </child>
  <child>
    <thing1>bar</thing1>
    <thing2><leaf1>bar_leaf1</leaf1><leaf2>bar_leaf2</leaf2><leaf3>bar_leaf3</leaf3></thing2>
  </child>
</root>

Because thing2 is defined to be of type xml, I'd like it to return the xml fragment, rather than just a concatenation of all the textual contents as it does now.

i have been looking at something a bit similar and found XQuery. Using XQuery syntax you can create all the logic to search, parse and modify the XML to return just the contents as you want it and to restructure it on the fly to the formats you need on output.
I am considering to use it to build an XML FDW based on BaseX as the target engine to hold the XML.


Breaking change in GET /trustlist

The response to the GET /trustlist includes the extra field domain in the response. For some existing DCC implementations this is a breaking change.
In order to ensure full compatibility with EU-DCC this interface should not change in any way - this field needs to be removed in the response.
The API can be versioned - for example by making GET /v2/trustlist which does return this data.

This has been fixed :-)


Implement change chain name operation

Implement change chain name operation, including UI (dialog/notification), and undo/redo.

Initial implementation was completed. Error checking for the entered chain name should be required.

Simple check for the input chain name is implemented.


Add option to disable queueing

Hi!
When using Selenoid with GGR we observe that load on some node is much more than on others. In that case session queueing prevent GGR to skip overloaded node and redirect session to another Selenoid node. I think disabling queueing and rejecting overlimited session by Selenoid will force GGR to select another node and will provide more fair load-balancing.

@bashlakov instead of completely disabling queues - which will lead to hardware overload - just use Ggr -timeout flag allowing to specify max new session request timeout. Default timeout is 300 seconds but you may want to set shorter value - e.g. 10 seconds.
# docker run -d --name ggr -v /etc/grid-router/:/etc/grid-router:ro --net host aerokube/ggr:1.1.1 -timeout 10s

@bashlakov any updates? You can also ask questions online in our Telegram channel: https://telegram.me/aerokube

To summarise conversation in telegram: disable queueing should not be equal to limit=infinity, but rather return 503 error if number of serving sessions (active and pending) reach the limit value. This will force ggr to skip this node without waiting for timeout and will provide more fair and fast node selecting mechanism. Because this behaviour break capability with selenoid-hub, I think this feature should be enabled via appropriate command-line flag (e.g. --disable-queue).

Fixed in https://github.com/aerokube/selenoid/commit/4762ee186c912a64cf6d99ba2d061ca919eed213.


Fix. Call multi callbacks with correct Lua state

Close #78

Coverage increased (+0.9%) to 64.578% when pulling e7f83e7aa631e437db7d1d98f5182cb20fa22657 on moteus:master into 90c177740f386dc27551e9d3466c2118ba3181ed on Lua-cURL:master.

Coverage increased (+0.9%) to 64.578% when pulling e7f83e7aa631e437db7d1d98f5182cb20fa22657 on moteus:master into 90c177740f386dc27551e9d3466c2118ba3181ed on Lua-cURL:master.

Coverage increased (+0.9%) to 64.578% when pulling e7f83e7aa631e437db7d1d98f5182cb20fa22657 on moteus:master into 90c177740f386dc27551e9d3466c2118ba3181ed on Lua-cURL:master.

Coverage increased (+0.7%) to 64.43% when pulling a836734bfc02b695aa102b257b22c0f0f13e4a34 on moteus:master into 90c177740f386dc27551e9d3466c2118ba3181ed on Lua-cURL:master.

Coverage increased (+0.8%) to 64.46% when pulling 9a1270fde6a143fd100a306853ce26df5da7ac59 on moteus:master into 90c177740f386dc27551e9d3466c2118ba3181ed on Lua-cURL:master.

Coverage increased (+0.7%) to 64.43% when pulling b2e9474c6bf975a0f1813a387e2c0ec21d3064f3 on moteus:master into 90c177740f386dc27551e9d3466c2118ba3181ed on Lua-cURL:master.

It's OK, I have tested already

It will still crash in some case.
It creashed in lcurl_multi_timer_callback with p->L = NULL.

Did you can figureout from which curl function it called?

lua_gettop(lua_State * L) 行 118	C
lcurl_multi_timer_callback(void * multi, long ms, void * arg) 行 420	C
update_timer(Curl_multi * multi) 行 2806	C
curl_multi_remove_handle(Curl_multi * multi, Curl_easy * data) 行 780	C
lcurl_multi_info_read(lua_State * L) 行 216	C
...
lua_pcall(lua_State * L, int nargs, int nresults, int errfunc) 行 1052	C
luv_call_callback(lua_State * L, luv_handle_t * data, int id, int nargs) 行 96	C
luv_poll_cb(uv_poll_s * handle, int status, int events) 行 80	C
uv__fast_poll_process_poll_req(uv_loop_s * loop, uv_poll_s * handle, uv_req_s * req) 行 219	C
uv_process_poll_req(uv_loop_s * loop, uv_poll_s * handle, uv_req_s * req) 行 623	C
uv_process_reqs(uv_loop_s * loop) 行 206	C
uv_run(uv_loop_s * loop, uv_run_mode mode) 行 391	C
luv_run(lua_State * L) 行 33	C
...
lua_pcall(lua_State * L, int nargs, int nresults, int errfunc) 行 1052	C
docall(lua_State * L, int narg, int clear) 行 124	C
handle_script(lua_State * L, char * * argv, int n) 行 291	C
pmain(lua_State * L) 行 540	C
...
lua_cpcall(lua_State * L, int(*)(lua_State *) func, void * ud) 行 1074	C
main(int argc, char * * argv) 行 568	C

I use luajit.

Coverage increased (+0.6%) to 64.319% when pulling 367eb1482f651504a03b11ea4225e30f6115df29 on moteus:master into 90c177740f386dc27551e9d3466c2118ba3181ed on Lua-cURL:master.

Please test last commit

It's OK. I have tested already.

Coverage increased (+0.8%) to 64.486% when pulling 78a4a03e23329178d5b81d903d9279a8d1565b30 on moteus:master into 90c177740f386dc27551e9d3466c2118ba3181ed on Lua-cURL:master.

Coverage increased (+0.8%) to 64.532% when pulling c5e4734f63d20efb5c792b39818a28f5d002cd7c on moteus:master into 90c177740f386dc27551e9d3466c2118ba3181ed on Lua-cURL:master.


Fragment caching currently disregards block content when caching is turned off

see https://gist.github.com/1366727 for credit for the original fix. Seems like it was never pulled.  Right now if you run your site in development say with caching off, all fragment cache blocks are ignored.  It really should just execute them as if it is always a cache miss when caching is off.

Thanks man!

Thank you!


test on esp8266 and no works

Works perfectly in arduino but in esp8266 not. There is a difference in Data Types .Do you plan to make it compatible?.Nice library!

Thanks :-)
Currently, no. I am busy with other projects.
If you can provide some additional information on your esp8266 setup I might be able to guide you in the right direction.

Finallly i got it working with arduino uno  and esp8266 (arduino ide)  with this modifications.
cantt.h - line 96 -
void (*canCallback)(uint32_t, uint8_t *, unsigned int);
changed to
void (*canCallback)(uint32_t, uint8_t , uint16_t);
and
usage.ino line 29 -
uint8_t ret = CAN0.readMsgBuf(&msg.id, &msg.len, msg.data);
changed to
uint8_t ret = CAN0.readMsgBuf((long unsigned int)&msg.id, &msg.len, msg.data);
thank you for your attention.

@medusanet
What CAN driver did you use to make this work, I am having the same issue?

sorry, i was able to compile but got watch dog reset continiuosly.I couldn´t get it working.


2D deformation maps

It would be nice to have a 2D plotting routine that plots a deformation map as a function of stress and temperature, similar to those seen in many papers. As with other plotting routines, this should use GLMakie

solved with PR #51


Pick "enhance Obscure the secret key for show backup's repository stmt #34226"

Proposed changes
Issue Number: close #xxx
same as master #34226

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall


Option to only index git files

This seems like a great tool for my workflow, thank you for sharing it. I wonder if it would be possible to add a flag which will only include files from git ls-files?

BTW you might like aish which is a similar bash based tool for getting quick terminal one-liners.

Good idea @chr15m, I will look into it. It shouldn't be very hard.

@chr15m - could you test the version on feat/gitfeature?
I implemented including only files from git ls-files with -g option

@aerugo I tested your excellent prelude script, the script in main branch is buggy to ignore files/folders in .gitignore, and it's very slow with my simple repo(https://github.com/dongyuwei/temp_mail).
But, after switch to  feat/gitfeature, it works great! I hope you publish that version soon, thanks!

I also made a simple similar script with git ls-tree cmd, which serves the same purpose:
https://gist.github.com/dongyuwei/82e08826e59cd07065ba213a4adf037a
#!/bin/bash

COMMIT_HASH=$1

git ls-tree --full-tree -r --name-only $COMMIT_HASH | while read -r file; do
    echo "--- $file ---" >> all_files_contents.txt
    git show $COMMIT_HASH:$file >> all_files_contents.txt
    echo "" >> all_files_contents.txt
done

@dongyuwei - thanks for testing! I fixed a few other things and pushed a new release. You can install Prelude v0.3 now and use the -g flag to only include files tracked by git.

@aerugo sorry I was not able to check this before you merged, but I just tested and it works great!


Terminal output should have escape characters

Hi! First of all thanks a lot for this project, I hope it can get more users and more languages in the future! and I will be happy to contribute, however I noticed the following issue.
To print colors in the terminal we need an escape character: \e here is a reference.
So I was wondering if it would be an option to have this escape chars so:
This:
[0;0mlet[0;0m[38;5;65m a[0;0m[38;5;24m =[0;0m [38;5;65m-1[0;0m\n
Becomes this:
\e[0;0mlet\e[0;0m\e[38;5;65m a\e[0;0m\e[38;5;24m =\e[0;0m \e[38;5;65m-1\e[0;0m\n
Or I might not be using the library correctly, anyway I am thankful for this project! Hope there is a solution.

Hi! Thanks. What terminal are you using ? From what I have read, you should not need to escape the modifiers yourself in most terminals, since Lux already does it.
If you want to specify a color, you can use the Terminal Modifier(colorCode:) initialiser with a 0-255 color code (you can find the color codes list in the wiki). It will apply the escape and the color specification.
But if you don't plan to modify a color, you should not have to escape anything. Could you tell me more about your use case?

Thanks for the reply, I am using it as a library to output to iTerm 2, I am not using any colors that are different, I was testing it in playgrounds.
I don't know if the use as library has different behavior than the CLI tool

// Playgrounds
import Lux

var delegate = ZshDelegate()
let injector = ZshInjector(type: .terminal, delegate: delegate)

let text = "let a = -1"

let colorizedText = injector.inject(in: text)
print (colorizedText)

Here is the code since I am testing, I don't know if that helps.

Do you output in the terminal or inside the Xcode console when running the playground ? If it's in the Xcode console, it's not supported unfortunately, although some alternatives exist in open-source.

Oh I see thanks a lot, just checked seems to work correctly outside xcode console!

 Glad to help.


Sometimes, table of contents close button doesn't works.

Describe the bug

Sometimes, Table of contents close button doesn't works. Instead panel moves to right.
Screenshots

Expected behavior

when Close button clicked, eveytime closes the Table of contents box.
To Reproduce
Steps to reproduce the behavior:

Go to https://jekyll-theme-mrgreen-demo.mrgreensworkshop.com/posts/2022-03-03-mr-green-jekyll-theme
Click X button on the top right side of Table of contents.
Check if closes.

Desktop (please complete the following information):
none
Mobile devices (please complete the following information):
some tablets.
Additional context

Its not reproducible evey time. Sometimes it occurs.

I think I'm gonna close this.


AudioEffectPitchShift has audible effect when pitch = 1

Tested versions

Reproducible in 4.3.stable

System information
Godot v4.3.stable - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3070 (NVIDIA; <IP_ADDRESS>94) - 11th Gen Intel(R) Core(TM) i7-11700K @ 3.60GHz (16 Threads)
Issue description
The documentation for AudioEffectPitchShift claims that "1.0 is the default pitch and plays sounds unaffected", which matches expectations, however this is not the case. If you first set the pitch to something other than 1 then back to 1 via scripting, the sound will be noticeably distorted compared to how it initially was. When starting the effect at a pitch of 1 the audio is indeed unaffected, however changing it to something else then back to 1 continues to distort the sound.
In the video below, the pitch starts at a default 1.0, then I quickly press buttons to set the pitch to something else then back to 1.0, check the console to see the values. The sound is initially undistorted, but after changing its pitch to something else then back, there's an audible difference in the sound.
https://github.com/user-attachments/assets/a266e974-c495-442c-a940-2ba32eefca89
I was hoping to fade the pitch effect in and out as you open a menu, however this won't be possible without noticeable audio weirdness. I tried turning off the effect which works but has a noticeable snap to it as the effect instantly turns off.
Steps to reproduce

In the MRP below, you can press left / right arrows to set the pitch to 0.5 or 1.5. Pressing space returns the pitch to the default value of 1.0
Enter play mode, listen to the sound
Quickly press right arrow then space, the sound is noticeably not the same as how it started, despite the pitch being returned to the starting value of 1.0

Minimal reproduction project (MRP)
pitch-shift-bug.zip

try this
https://cdn.discordapp.com/attachments/1277836331501883449/1280291965879193731/fix.zip?ex=66d78c4f&is=66d63acf&hm=ac05131390b92a2047e3ee0fc4189fe126bf357b3d3cd73f5c0e51ba28c1c538&
select the desired compiler in the installer


Implement exporters config ui

Resolves #83

@baruchiro I went over the changes, looks fine on my end. If you approve my changes I will merge


Update Enable-CsOnlineSipDomain.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Enable-CsOnlineSipDomain.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Changes to settings aren't getting detected

I omitted the lines about images being skipped, but here's the log:

trigger_1       | 2020-07-16T12:49:48-05:00 [Main] ****************************************
trigger_1       | 2020-07-16T12:49:48-05:00 [Main] Starting up version 5.1.1
trigger_1       | 2020-07-16T12:49:48-05:00 [Main] Timezone offset is 300
trigger_1       | 2020-07-16T12:49:48-05:00 [Main] Current time is Thu Jul 16 2020 12:49:48 GMT-0500 (Central Daylight Time)
trigger_1       | 2020-07-16T12:49:48-05:00 [Settings] Loaded settings from /run/secrets/settings
trigger_1       | 2020-07-16T12:49:48-05:00 [MQTT] Connected to MQTT server mqtt://<IP_ADDRESS>:1883
trigger_1       | 2020-07-16T12:49:48-05:00 [Local storage] Creating local storage folders in /node-deepstackai-trigger.
trigger_1       | 2020-07-16T12:49:48-05:00 [Local storage] Enabling background purge every 60 minutes for files older than 30 minutes.
trigger_1       | 2020-07-16T12:49:48-05:00 [Local storage] Running purge
trigger_1       | 2020-07-16T12:49:48-05:00 [Main] Annotated image generation enabled.
trigger_1       | 2020-07-16T12:49:48-05:00 [Main] Web server enabled.
trigger_1       | 2020-07-16T12:49:48-05:00 [Triggers] Loaded configuration from /run/secrets/triggers
trigger_1       | 2020-07-16T12:49:48-05:00 [Triggers] Loaded configuration for Front Driveway not cars
trigger_1       | 2020-07-16T12:49:48-05:00 [Triggers] Loaded configuration for Front Driveway cars
trigger_1       | 2020-07-16T12:49:48-05:00 [Triggers] Loaded configuration for North Road
trigger_1       | 2020-07-16T12:49:48-05:00 [Trigger manager] There are 777 images waiting in /aiinput for Front Driveway not cars.
trigger_1       | 2020-07-16T12:49:48-05:00 [Trigger manager] There are 777 images waiting in /aiinput for Front Driveway cars.
trigger_1       | 2020-07-16T12:49:48-05:00 [Trigger manager] There are 777 images waiting in /aiinput for North Road.
trigger_1       | 2020-07-16T12:49:48-05:00 [Pushbullet] Pushbullet is disabled via settings.
trigger_1       | 2020-07-16T12:49:48-05:00 [Pushover] Pushover is disabled via settings.
trigger_1       | 2020-07-16T12:49:48-05:00 [Telegram] Telegram is disabled via settings.
trigger_1       | 2020-07-16T12:49:48-05:00 [Mqtt router] Subscribing to node-deepstackai-trigger/statistics/reset.
trigger_1       | 2020-07-16T12:49:48-05:00 [Web server] Listening at http://localhost:4242
trigger_1       | 2020-07-16T12:49:48-05:00 [Local storage] Purge complete
trigger_1       | 2020-07-16T12:49:48-05:00 [Mqtt router] Subscribing to node-deepstackai-trigger/statistics/trigger/reset.
trigger_1       | 2020-07-16T12:49:48-05:00 [Mqtt router] Subscribing to node-deepstackai-trigger/motion.
trigger_1       | 2020-07-16T12:49:48-05:00 [Trigger Front Driveway not cars] Listening for new images in /aiinput/drivewaysd*.jpg
trigger_1       | 2020-07-16T12:49:48-05:00 [Trigger Front Driveway cars] Listening for new images in /aiinput/drivewaysd*.jpg
trigger_1       | 2020-07-16T12:49:48-05:00 [Trigger North Road] Listening for new images in /aiinput/northroadSD*.jpg
trigger_1       | 2020-07-16T12:49:48-05:00 [Main] Watching for changes to /run/secrets/settings
trigger_1       | 2020-07-16T12:49:48-05:00 [Main] Watching for changes to /run/secrets/triggers
trigger_1       | 2020-07-16T12:49:48-05:00 [Main] ****************************************
trigger_1       | 2020-07-16T12:49:48-05:00 [Main] Up and running!
trigger_1       | 2020-07-16T12:49:49-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_065141376.jpg: Skipping as it was created before the service started.
deepstack-ai_1  | [GIN] 2020/07/16 - 17:50:01 | 200 |   1.17227931s |      <IP_ADDRESS> | POST     /v1/vision/detection
deepstack-ai_1  | [GIN] 2020/07/16 - 17:50:01 | 200 |  1.173287327s |      <IP_ADDRESS> | POST     /v1/vision/detection
deepstack-ai_1  | [GIN] 2020/07/16 - 17:50:01 | 200 |  115.324531ms |      <IP_ADDRESS> | POST     /v1/vision/detection
deepstack-ai_1  | [GIN] 2020/07/16 - 17:50:05 | 200 |  2.240648063s |      <IP_ADDRESS> | POST     /v1/vision/detection
deepstack-ai_1  | [GIN] 2020/07/16 - 17:50:07 | 200 |  4.497818932s |      <IP_ADDRESS> | POST     /v1/vision/detection
trigger_1       | 2020-07-16T12:49:56-05:00 [Trigger North Road] /aiinput/northroadSD.20200716_124956037.jpg: Analyzing
trigger_1       | 2020-07-16T12:50:00-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_125000010.jpg: Analyzing
trigger_1       | 2020-07-16T12:50:00-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125000010.jpg: Analyzing
trigger_1       | 2020-07-16T12:50:01-05:00 [Trigger North Road] /aiinput/northroadSD.20200716_125001063.jpg: Analyzing
trigger_1       | 2020-07-16T12:50:01-05:00 [Trigger North Road] /aiinput/northroadSD.20200716_124956037.jpg: Found at least one object in the photo. (4922 ms)
trigger_1       | 2020-07-16T12:50:01-05:00 [Trigger North Road] /aiinput/northroadSD.20200716_124956037.jpg: Matched triggering object car
trigger_1       | 2020-07-16T12:50:01-05:00 [Trigger North Road] /aiinput/northroadSD.20200716_124956037.jpg: Confidence 86.45112499999999 meets threshold 0 and 100
trigger_1       | 2020-07-16T12:50:01-05:00 [Trigger North Road] Prediction region (518, 175, 558, 204) blocked by trigger mask (491, 165, 640, 209).
trigger_1       | 2020-07-16T12:50:01-05:00 [Trigger North Road] /aiinput/northroadSD.20200716_124956037.jpg: Not triggered by car (86.45112499999999)
trigger_1       | 2020-07-16T12:50:01-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_125000010.jpg: Analysis failed
trigger_1       | 2020-07-16T12:50:01-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125000010.jpg: Analysis failed
trigger_1       | 2020-07-16T12:50:01-05:00 [Trigger North Road] /aiinput/northroadSD.20200716_125001063.jpg: Analysis failed
trigger_1       | 2020-07-16T12:50:03-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_125002539.jpg: Analyzing
trigger_1       | 2020-07-16T12:50:03-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Analyzing
trigger_1       | 2020-07-16T12:50:05-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_125002539.jpg: Found at least one object in the photo. (2253 ms)
trigger_1       | 2020-07-16T12:50:05-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_125002539.jpg: Detected object car is not in the watch objects list [person, cat, dog]
trigger_1       | 2020-07-16T12:50:05-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_125002539.jpg: Not triggered by car (78.36)
trigger_1       | 2020-07-16T12:50:05-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_125002539.jpg: Detected object car is not in the watch objects list [person, cat, dog]
trigger_1       | 2020-07-16T12:50:05-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_125002539.jpg: Not triggered by car (60.057559999999995)
trigger_1       | 2020-07-16T12:50:05-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_125002539.jpg: Detected object truck is not in the watch objects list [person, cat, dog]
trigger_1       | 2020-07-16T12:50:05-05:00 [Trigger Front Driveway not cars] /aiinput/drivewaysd.20200716_125002539.jpg: Not triggered by truck (40.02356)
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Found at least one object in the photo. (4511 ms)
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Matched triggering object car
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Confidence 78.36 meets threshold 0 and 100
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] Prediction region (136, 80, 526, 262) blocked by trigger mask (33, 85, 460, 251).
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Not triggered by car (78.36)
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Matched triggering object car
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Confidence 60.057559999999995 meets threshold 0 and 100
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] Prediction region (256, 0, 301, 11) blocked by trigger mask (257, 0, 314, 16).
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Not triggered by car (60.057559999999995)
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Matched triggering object truck
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Confidence 40.02356 meets threshold 0 and 100
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] Prediction region (175, 80, 532, 261) blocked by trigger mask (33, 85, 460, 251).
trigger_1       | 2020-07-16T12:50:07-05:00 [Trigger Front Driveway cars] /aiinput/drivewaysd.20200716_125002539.jpg: Not triggered by truck (40.02356)

Originally posted by @minideezel in https://github.com/danecreekphotography/node-deepstackai-trigger/issues/345#issuecomment-659573004

Can you tell me more information about your configuration?

Are you running Docker directly on Windows? Or using something like Portainer/UnRaid/etc?
Are you using secrets to mount the configuration files or mounting a folder with the config files in them? Post your docker-compose.yaml if you have one, thanks!

Environment is:
Ubuntu 18.04.4 server
Docker version 19.03.6, build 369ce74a3c

Docker-compose:
version: "3.8"
services:
  trigger:
    volumes:
      # Change d:/myfolder/myimages to point to the folder that will have the images
      # to analyze. Only change the local path that is before the :/aiinput portion.
      # Don't change the :/aiinput part.  For a list of valid timezone values
      # see https://en.wikipedia.org/wiki/List_of_tz_database_time_zones.
      # The value to use is in the "TZ database name" column.
      - TZ=America/Chicago

    ports:
      # This port is used by the local web server when annotated images are enabled.
      # If you change the port used by the local web server in the settings.json file
      # this also has to change to match.
      - 4242:4242

    # ------------------------------------------------------------------------
    # Don't change anything below this line unless you know what you are doing
    secrets:
      - triggers
      - settings
    image: danecreekphotography/node-deepstackai-trigger:latest
    restart: always
    depends_on:
      - deepstack-ai

  deepstack-ai:
    image: deepquestai/deepstack:noavx
    restart: always
    ports:
      - 5000:5000
    volumes:
      - localstorage:/datastore
    environment:
      - VISION-DETECTION=True

volumes:
  localstorage:

secrets:
  settings:
    # This should point to the location of the settings.json configuration file
    file: ./settings.json
  triggers:
    # This should point to the location of the triggers.json configuration file
    file: ./triggers.json

Interesting. I've never run this directly on Ubuntu (instead of on Windows Docker). It really shouldn't matter, since I use the same system to detect chanes to the settings files as I do for the new images arriving. I'm not sure what could be happening here. 🙁

I'm having the same issue on Windows Docker; from what I can tell the secrets files are not being mapped correctly to the docker container.
No matter what I put for a file location in the docker-compose file, if I CLI into the docker container there are the two default settings and triggers files under /run/secrets.

@crunchymetal please open a new support issue for your situation and include the docker-compose.yaml file and a complete output log. Thanks!

 Everything working as expected for me. Apologies for wasting your time.

Been there, done that! 😂

No response after two weeks, closing.

I know this issue is closed. How are people figuring out the coordinates to mask? Is there some software that is being used?

I know this issue is closed. How are people figuring out the coordinates to mask? Is there some software that is being used?

Paint.net will show cursor coordinates, you can get it here:  https://www.getpaint.net/

The built in Paint app in Windows 10 will also show you the x,y and width,height coordinates of a selection rectangle.

Awesome, I didn't want to ask a ridiculous question but I tried PS and it wasn't working out.  I appreciate you both!


logging cluster info

Description
improves logging for clusters and rule hits
Fixes CCXDEV-6002
Type of change
Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Testing steps
run the smart proxy and check the logs
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report

Merging #718 (f625450) into master (59392b1) will increase coverage by 0.26%.
The diff coverage is 86.95%.

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   53.61%   53.87%   +0.26%
==========================================
  Files          20       20
  Lines        2585     2604      +19
==========================================
+ Hits         1386     1403      +17
- Misses       1037     1039       +2
  Partials      162      162

Impacted Files
Coverage Δ

server/server.go
58.33% <86.95%> (+1.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59392b1...f625450. Read the comment docs.


Don't use static SR method for now (iOS issue)

@jtrieu please review and merge the fix for running on iOS

Don't need this anymore. Closing


SAMOA-68:  Saving true and predicted labels to file

This pull request refers to new code saving predicted and true values for classification and regression tasks. In addition, votes are saved for classification tasks. This can be easily extended at the level of individual evaluators.

The code is extended now to handle new switch "-h". This makes it possible to declare how frequently lines in labels file should be created. If set to e.g. 10 this option will make the label file contain true and predicted labels (+ votes for classification tasks) for every 10th instance in the stream. Please let us know if there is anything else to add.

Thank you @mgrzenda for the contribution! Very nice!
I tested it with bagging and VHT, covtypeNorm and random-tree-generator.
Quick feedback:

Can you please remove the copyright years etc., as per the other PRs?
Can you add some comments/help on what each of the new parameters mean?
I think the new parameter on the frequency is not included in the defined templates. Can you check and add it?
I think the printout of the last prediction is not printed in file. Not such a big deal but please check if there is something you can do to fix it (or if it's something bigger).
Interestingly, the higher the frequency of predicted labels printed (controlled by -h), the higher the overhead on the execution, and the longer it takes to finish the examples I tried. However, practically when outputing every say 10 instances, the impact is minimal. Any way we can make it impact less the execution time? Or is this due to I/O bottleneck to disk?

Seems all the issues have been solved.
Tested the code and seems to run fine.
+1

same here.
+1

I'm also fine on how the issues have been fixed.
+1

I'm also fine on how the issues have been solved.
+1


Postgres / SQLite: poly / hasMany relationships inside of blocks that are inside of localized blocks

Link to reproduction
No response
Environment Info
Payload: 190

Describe the Bug
From this config, field relation that is deeply nested to blocks + localized blocks is inproperly transformed from the database to the payload result.
import type { CollectionConfig } from 'payload'

export const NestedFields: CollectionConfig = {
  slug: 'nested-field-tables',
  fields: [
    {
      name: 'blocks',
      type: 'blocks',
      localized: true,
      blocks: [
        {
          slug: 'block',
          fields: [
            {
              name: 'nestedBlocks',
              type: 'blocks',
              blocks: [
                {
                  slug: 'content',
                  fields: [
                    {
                      name: 'relation',
                      type: 'relationship',
                      relationTo: ['localized-posts'],
                    },
                  ],
                },
              ],
            },
          ],
        },
      ],
    },
  ],
}

Reproduction Steps
Test here: https://github.com/payloadcms/payload/blob/86d6a4e1788a0f2a61b2c804a0a73f277495e042/test/localization/int.spec.ts#L1979
Adapters and Plugins
No response

Fixed in https://github.com/payloadcms/payload/pull/8456


Add attributes for corrected OCR files

Storing the path in database to corrected text and corrected OCR files.  So the _ALTO.txt and _ALTO.xml file.  These could be added to either the page_results or postproc_pages table.

Priority before #18


Support emptydir volumes for containers running as non-root

WIP for: #2630
@thockin @smarterclayton
E2E test doesn't work yet -- looks like local-up-cluster gives you a cluster that doesn't allow privileged containers; I am working through this now.

@vmarmol since we discussed on IRC

I get a clean e2e run from this locally.

I'd like #9442 to go in first.

@pmorie I assumed this was still a WIP. Change the title back when it's ready for a full review. Thanks!

@krousey @vmarmol This is ready for review now; we decided not to do #9442

@pmorie I didn't notice earlier that #2630 was a post v1 milestone. I'm going to mark this as such. Sorry for the confusion.

Thank you very much for the pull request - we sincerely appreciate the work that goes into sending us a change.
We are currently in a feature-freeze and general code slush as we work toward our 1.0 release.  Our initial triage indicates that this is a non-critical change at this time, so we'd like to leave it open and revisit it after 1.0.  We expect the freeze to wrap up in early to mid July.
If you feel that this triage is incorrect, please respond and let us know why.  We're currently accepting changes that meet any of the following criteria:

Changes directly related to v1.0 issues: https://github.com/GoogleCloudPlatform/kubernetes/issues?q=is%3Aopen+is%3Aissue+milestone%3Av1.0
Changes addressing P0 bugs: https://github.com/GoogleCloudPlatform/kubernetes/issues?q=is%3Aopen+is%3Aissue+label%3Apriority%2FP0
Changes to supported platforms to bring them up to par with the primary development platforms
Docs, user experience, and test related fixes

Thanks again for your contribution!  The community is really what has made this project so exciting.

@krousey I personally think this should be fixed for 1.0 -- without it, you cannot use the emptyDir volume from containers that do not run as uid 0.

@pmorie I will defer to @thockin on this one since he is the lead for this area. He is on PTO right now, so he may not be able to answer you until next week. For now I will leave this as is until he responds. Thanks again for the PR.

@krousey thanks, that is fine with me.

@k8s-bot test this please

@thockin The e2e tests aren't going to pass for this in GCE until someone pushes the new image.  I realized just now that I didn't test this in GCE yet (at least, that I can remember from the pre-OpenShift GA, pre-Summit bedlam run).  I'll push an image to my dockerhub account and use that to test in GCE.  I believe what I've done with @vmarmol in the past is that he's pushed the new image after changes that made dependencies on new images during E2E after they went into master and before they were batched in to your internal jenkins.  I think this is the first time we've done something like that (that I participated in) after the new E2E-gh integration.  I know this is marked for 1.0-post, just looking for what the process should be (and questing for 3 green-light status).

@thockin I have a clean run on GCE with this

@thockin @vmarmol Code is rebased and up to date.  One thing I'm considering is whether you should be able to request specific permissions for 'all' for emptyDir.

@thockin Will you have bandwidth to review this one soon?  We're carrying a patch for it in OpenShift and would like to get it into master.

LGTM overall.  I can't wait for a real fix (as discussed in https://github.com/GoogleCloudPlatform/kubernetes/issues/2630), but I am afraid that will have to come from RedHat which is the central store of selinux knowledge in the universe.

LGTM - the minor factoring is optional.  Mark this LGTM when you decide :)

@thockin I would prefer to leave as is for now, get this in, and do a follow-up for the refactoring that will be easier to rebase.  I have had to slice and dice quite a bit to get the origin patches in sync with the upstream PRs :-D
https://gist.github.com/pmorie/117594d649bb697d8651 if you're curious, read close to a trashcan.

@thockin Added the reference to #2630 -- I'm ready for this to be merged if you have nothing else you require in this commit, knowing that we'll be doing follow-ups to right wrongs.

As @thockin requested, I'm tagging this as LGTM.  Will need someone to build and push the new mounttest-user image once this goes in (or before!) to avoid breaking E2E.  Perhaps the on-call dev who deigns to merge this can ping me on IRC and we can coordinate.

@k8s-bot ok to test

@mikedanese Everything should be just-so about the images now.  You'll need to build both the mounttest and mounttest-user images.  Once those are pushed, the GCE E2Es should be solvent -- we can wait for all-greens.

@k8s-bot ok to test

Images are pushed. Ok to merge on green.

@mikedanese Thanks!


Web3-Onboard - style interface [13/n]

What does this PR do and why?
Adds support for styling of the web3-onboard screen
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #1739

PR #1740

PR #1741

PR #1742

PR #1743

PR #1744

PR #1745

PR #1746


[charts/gateway]: Update 10.1.00_CR2 tag to 11.0.00

Description of the change
Update Gateway image version from 10.1.00_CR2 to 11.0.00
Benefits
Enable usage of latest release of Layer 7 Gateway
Drawbacks
None. It's a straightforward version update. The image already exists on Docker Hub.
Applicable issues

fixes #

Additional information
Verified on GKE using local copy of fork:
PS C:\Users\jd683606.BRCMLTD\work\github\CAAPIM\apim-charts-jennarddy\charts> helm install jd683606-ssg-11 --set-file "license.value=LICENSE.xml" --set "license.accept=true" gateway
NAME: jd683606-ssg-11
LAST DEPLOYED: Mon Jan 30 18:04:36 2023
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
##################################################################################
####                                 Success!                                 ####
##################################################################################
####                 Your gateway deployment has been INSTALLED               ####
##################################################################################

To view the Gateway's services you can use the following command
$ kubectl get svc -n default | grep gateway

To learn more about the Gateway Helm Chart check out the following links

Gateway Helm Chart Readme
- https://github.com/CAAPIM/apim-charts/tree/stable/charts/gateway

Thinking in Kubernetes
- https://techdocs.broadcom.com/us/en/ca-enterprise-software/layer7-api-management/api-gateway/congw-10-1/learning-center/thinking-in-kubernetes.html#thinkingk8s

PS C:\Users\jd683606.BRCMLTD\work\github\CAAPIM\apim-charts-jennarddy\charts> kubectl get svc -n default
jd683606-ssg-11-gateway                   LoadBalancer   <IP_ADDRESS>   <IP_ADDRESS>   8443:32660/TCP                                  3m5s
jd683606-ssg-11-gateway-management        LoadBalancer   <IP_ADDRESS>    <IP_ADDRESS>   9443:31896/TCP                                  3m5s
jd683606-ssg-11-mysql                     ClusterIP      <IP_ADDRESS>   <none>           3306/TCP                                        3m5s
jd683606-ssg-11-mysql-headless            ClusterIP      None              <none>           3306/TCP                                        3m5s

Logged on to Policy Manager using <IP_ADDRESS>:9443

Checklist

[X] Chart version bumped in Chart.yaml according to semver.
[X] Variables are documented in the README.md
[X] Title of the PR starts with chart name (e.g. [charts/gateway])
[X] If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

Thanks, the updates look good -
Could you add a 3.0.5 updates section (above 3.0.2) and reference the release notes - specifically that the upgrade procedure requires careful planning given the embedded Hazelcast update requires Gateway deployments to be scaled to 0.
https://techdocs.broadcom.com/us/en/ca-enterprise-software/layer7-api-management/api-gateway/congw-11-0/release-notes_cgw.html

I've added 3.0.5 General Updates section. Please take a look. Thanks.


fix sqlalchemy2 compatibility

Describe your changes
Fixes sqlalchemy2 compatibility. Changes all places where .execute is called through sqlalchemy to new version.
Issue ticket number and link
Closes #234
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I have added thorough tests (when necessary).
[ ] I have added the right documentation in the docstring and changelog (when needed)

:books: Documentation preview :books:: https://jupysql--269.org.readthedocs.build/en/269/

another tool I use for debugging is from IPython import embed; embed() - place that right before the test fails so you can explore the values of existing variables interactively

I took a look at the code and fixed some errors but realized this PR still needs some work:

the CHANGELOG was reformatted (possibly some IDE misconfiguration)
fixed some tests, but others are failing now - i think the best way is to debug locally using pdb https://docs.pytest.org/en/7.1.x/how-to/failures.html

The main problem I encountered is that we have multiple types of db connections: sqlalchemy, native drivers and our sql.Connection, when passing SQL queries, we might be mixing them one another (e.g., passing sqlalchemy.text to a native driver connection breaks)

Probably I missed why now we have multiple types of DB connections? Since the duckdb connection here should be connected by SQLAlchemy at least (which should be?)

any updates here? @Palashio

Been doing some debugging but still working on that.

Been doing some debugging but still working on that.

I'll continue the work


Method snapshot.Set has side-effects on Image state

This is a change to what is described in #176.
Transfer of the Set function in the Snapshot.go file to the SetSnapshot() function in rbd.go

rbd: add SetSnapshot re-implementing rbd_snap_set on image type
rbd: add deprecation comment to snapshot.Set method

Checklist

[X] Added tests for features and functional changes
[X] Public functions and types are documented
[X] Standard formatting is applied to Go code

@phlogistonjohn Is there anything missing?

Hi! Thanks for the reminder ping. There are still a few issues I've previously mentioned that need to be resolved:

The test code still adds net new lines. I suggested, "It would probably better if we replaced the use of snapshot.Set at around line number 97." This is important because we want to ensure the new method is a functionally drop-in replacement for the old Set call.
I previously suggested we should replace the implementation of the old Set method with a call to SetSnapshot. I won't demand this one, but I'd like it if you could respond to this point and either defer it (and I'll create a new issue to track the work item) or make it part of this PR.
The commit messages and the commits need cleaning up.

As for the last point, I realize that not everyone is accustomed to rebasing/squashing/re-writing git history. If you don't know how to fix up your commits just let us know and I will either try to help you out with instructions or I will ask your permission to alter the git history myself - keeping your authorship of course!
Let me know if you have any question, comments, or concerns about these items. Thanks!

@phlogistonjohn I am new to changing commit using git
I would appreciate if you could give me the guide instructions.

@phlogistonjohn I am new to changing commit using git
I would appreciate if you could give me the guide instructions.

Sure! Because this is a reasonably small PR in terms of lines of code changed, I am going to recommend we squash everything into a single commit. He's how I would do it:

Ensure you're already on the branch containing your changes.
Run git rebase against the base branch for your changes, this may vary based on your set up but I think it should be something like: git rebase -i origin/master
This will bring up an editor window that looks something like:

pick 567fed0 Update snapshot.go
pick ce9fd36 #176
pick 0279dcd #176
pick 7db5c28 Update rbd/snapshot.go
pick 503db18 Update snapshot.go

On every line except the first, change pick to squash. Example:

pick 567fed0 Update snapshot.go
squash ce9fd36 #176
squash 0279dcd #176
squash 7db5c28 Update rbd/snapshot.go
squash 503db18 Update snapshot.go

git will now start a new editor window with the combined commit messages. Delete the existing messages and replace it with something like the one below. And since we're editing commits add a signed off by (DCO) line, similar to the example below but with your name and email:

rbd: add SetSnapshot (re)implementing rbd_snap_set

Signed-off-by: Your Preferred Name<EMAIL_ADDRESS>

Once you've saved and quit the editor git should create a single new commit from the previous commits.
Now, you must force push git push --force ... to update your fork+branch

That should be all. Once done we should see the new commit here. Let me know if you have any additional questions about this.

@phlogistonjohn I combined the commit msg. Is this okay?

@phlogistonjohn I combined the commit msg. Is this okay?

Commit structure and commit message text look good, thanks! However, the signed off by line should not contain the literal string "Your Preferred Name" but rather your name.
Here's a reference  that you can use as a starting point to read up on it more if you want to. You can also look at the recent git history of go-ceph to see other examples.
The change I mentioned about replacing Set rather than adding new lines still applies as well. I think it's the cause of the test failure in the CI.
In addition, because you now only have 1 commit you can use the (simpler, IMO) git commit --amend command to make changes to the commit that exists rather than adding new patches.

@phlogistonjohn The change I mentioned about replacing Set rather than adding new lines still applies as well. I think it's the cause of the test failure in the CI.

I changed the contents of Set API to rbd.Setsnapshot
changed the Error Case of snapshot_test.go to ErrImageNotOpen

@phlogistonjohn The change I mentioned about replacing Set rather than adding new lines still applies as well. I think it's the cause of the test failure in the CI.
* I changed the contents of `Set` API to `rbd.Setsnapshot`

Great! This means we only have 1 implementation of the binding now. Plus, every test that exercised Set is now also exercising  rbd.Setsnapshot!

* changed the Error Case of snapshot_test.go to `ErrImageNotOpen`

OK, thanks.

@phlogistonjohn  All checklists have been passed.
What should I do?

@mergifyio rebase

@nixpanic or @ansiwen - need a 2nd review on this, so PTAL when you have a moment. Thanks!


Fix: Add detail for to see DB/API error messages

Adds a subheading to the Query troubleshooting page that explains how to find the error messages that were returned by the user's datasource in response to their failed query.
Resolves appsmithorg/appsmith/#16043

Added wrong commits by mistake, closing


Add using example

Fixes dotnet/docs#14869.

@MetalDent This has gotten stale.
I like the sample that was added, but it is not referenced in the article. Do you want to update the article to include the new sample in a PR in dotnet/docs? Otherwise, I will close this.

@MetalDent This has gotten stale.
I like the sample that was added, but it is not referenced in the article. Do you want to update the article to include the new sample in a PR in dotnet/docs? Otherwise, I will close this.

Okay, I'll update the article

Closing due to lack of response.
@MetalDent If you have time to revisit this, I'll watch for any updates.


stroke-width / strokeWidth not being applied to the shape elements

The stoke width, among others, is not being applied to the <path> element for ChatAlt2. I have also seen instances where stroke-width={2} is hard coded. This should be something that is set from the strokeWidth prop, yes?

Something else I want to bring up here, is it possible to get outlined icons, and are there plans to integrate them into this library?

@cworsley4 good point (did notice that too). The problem is that many values are - accidentally - hardcoded so it's a bit difficult to maintain. I will look into a solution soon.
@coderinblack08 outlined icons are already available https://github.com/impulse/heroicons-react/tree/master/src/icons. They are suffixed with Outlined


AbortSignal does not fire when query errors out

Describe the bug
Consider this example from the TanStack Query docs. Imagine that when one of the todo details fetches fails, the entire query should error out. The AbortSignal supplied to the fetchFn by TanStack Query should fire the abort event in this case, to cancel pending requests, but it does not.
Your minimal, reproducible example
Codesandbox repro
Steps to reproduce

Run the example with the console open.

Observe that, when the request for /todo/2 rejects, the abort event is not fired on the AbortSignal supplied to the fetchFn by TanStack Query.
Expected behavior
The abort event should fire so that all of the abortables created inside fetchFn abort.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
All platforms.
Tanstack Query adapter
react-query
TanStack Query version
5.51.1
TypeScript version
4.4.4
Additional context
No response

You can manually call queryClient.cancelQueries({ queryKey: ['foo'], exact: true }) to trigger abort callbacks. However, the query will revert to its previous state, which may not be the expected result if you want to display the rejected information.
If you don't need to revert to the previous query state, would creating another AbortController within the queryFn to control the request flow be more appropriate?
const { data, error } = useQuery({
  retry: false,
  queryKey: ["foo"],
  async queryFn() {
    const controller = new AbortController();
    const signal = controller.signal;

    const [resultA, resultB] = await Promise.all([
      // REQUEST A
      // Always dies in 1000ms.
      new Promise<number>((_, reject) => {
        const timerId = setTimeout(() => {
          reject(new Error("Request A died!"));
          controller.abort();
        }, 1000);

        signal.addEventListener("abort", () => {
          console.log("request A was aborted");
        });
      }),
      // REQUEST B
      // Takes a lot longer than 1000ms; should always be aborted.
      new Promise<number>((resolve) => {
        // ...
        signal.addEventListener("abort", () => {
          console.log("request B was aborted");
        });
      }),
    ]);
    // Imagine it's something like price * units.
    return resultA * resultB;
  },
});

Thanks for your thoughts, @87xie. For the purpose of this issue, let's focus on the bug in TanStack Query rather than talk about workarounds.
For avoidance of doubt, I've changed the repro in the issue to be one that pulls straight from the TanStack Query docs themselves, so that we can all agree that if the use case in the docs is valid, then this bug is valid.

Thanks for your information. I'm not sure if it's a bug. The example from the TanStack Query docs shows sequential requests. The todoDetails request depends on todos, so I think it only triggers after resolved todos.
queryFn rejections are not always due to AbortError, so I think triggering an abort on each rejection is inappropriate. For a single request in the queryFn case, this seems unnecessary, or maybe it should be opt-in. If I missed something obvious, please let me know.

The example from the TanStack Query docs shows sequential requests

The example shows concurrent requests. See the Promise.all at the bottom.

Ahh, thanks for the explanation, todoDetails are indeed concurrent requests. It would be great if Promise.all(todoDetails) could have a better mechanism for canceling pending requests, but we also need to consider the scenario of Promise.allSettled(todoDetails)?

To your concern, if TanStack Query doesn't abort the signal, you can't implement responsible cancellation at all, however if TanStack Query does abort the signal, the developer still has control over how to proceed. The implementor of queryFn could decide to cancel all, some, or none of the in-flight requests, and to return complete or partial data.

I don't think this is really a bug, what you are proposing is a change in behaviour. What we are currently doing is we are aborting the signal only in two cases:

when queryClient.cancelQueries is triggered (imperatively by the user)
when the query becomes unused - that means, the last observer unsubscribes. This usually happens when the queryFn runs and the user navigates away to a different page, which leads to the observer unmounting.

If your queryFn makes multiple requests, it's not on us to decide that all requests should be aborted just because one of them fails. That might be your wanted behaviour for your use-case, but there's no guarantee that this is always correct.
The example you linked to shows that you can pass the signal to multiple requests, and if the component unmounts, all of those will be cancelled. Nothing in our docs indicates that rejecting one promise should abort other requests.
As described by others, there are lots of ways to achieve what you want. Additionally, I would probably go for useQueries in your example with combine and keep it to one request per queryFn.


Superficial: Remove incorrect version information from syntax

The omnisharp syntax file was copied from the standard vimfiles, but
it's had some heavy modifications despite "last change" being 2009.
Add OmniSharp as a Maintainer and strip out the version lines to help
others find their way back to this repo and make it clearer that the
file isn't stock.
I was confused when looking through my C# syntax files: I had what appeared to be three identical ones because I had also copied the vimfiles one. But all three had different contents. This change hopes to prevent similar confusion for others.

Thanks!


Migrate datasource to new Terrafrom SDK

This change migrates the Datasources which are set to be deprecated in the future to the new framework plugin. The reasoning for doing this is because the provider configuration would be severely limited due to backwards compatibility requirements.

I have some more validation to do, but my thought is to rebase the branch which makes changes to the provider configuration and get that done also. That way we are not blocking any release which may have to be made inbetween.


Triplet_sum

I want to write a code in C++ for finding whether the triplet of the sum exists in the array or not.

/assign


Wrong LASTTICK

Hi! me again :)
I found a very strange bug that I'm unable to reproduce by hand, so I've put the data needed to reproduce it in a gist: https://gist.github.com/bensmrs/c064434943d418f6533e08cfb1bba20f
Basically, LASTTICK doesn't return the actual last tick.
Can you check that?
My example should return this:
[TOP]<PHONE_NUMBER>000000
2<PHONE_NUMBER>000000

As a side effect, every MAP I try to apply to that GTS stops at the tick returned by LASTTICK, not the true one, so quite embarrassing…

Hi!
This is because your GTS was bucketized and then some values were added. LASTTICK returns the newest tick or the last bucket if the GTS is bucketized. Here is a simple example showing the same behavior.
NEWGTS
0 NaN NaN NaN 1 ADDVALUE
10 NaN NaN NaN 1 ADDVALUE
20 NaN NaN NaN 1 ADDVALUE

[ SWAP bucketizer.last 20 10 0 ] BUCKETIZE
0 GET
30 NaN NaN NaN 1 ADDVALUE

SORT DUP
TICKLIST DUP SIZE 1 - GET // Get the last tick using TICKLIST
SWAP LASTTICK // Get the last tick using LASTTICK

The solution is to use UNBUCKETIZE on your GTS.

Awesome! Is this behaviour documented anywhere?
But there is something that disturbs me a bit: I did not add any value to the GTS…
I used a FETCH to get several GTSes, bucketized them, and calculated the ratio between two sums: the sum of the GTSes matching a specific label and the total sum. The sums are calculated with reducer.sum using REDUCE and the ratio is calculated with op.div using APPLY. The metadata saying « I'm bucketized » is apparently kept, but the « last known bucketized tick » is the wrong one then.

The behavior of LASTTICK concerning bucketized GTSs is not documented. I updated it and it should be online in a few days.
You indeed spotted something weird, most probably a bug, thanks for that. Combining GTSs with different last buckets with REDUCE (and maybe APPLY) results in GTSs with what seems a wrong last bucket. We're investigating that.
For now, I would recommend setting the same last bucket on all your GTSs (don't use the magic 0 parameter). You can use the LASTTICK function on the list returned by FETCH to use that value.

Thanks for the catch, there was indeed an issue with the REDUCE, it is fixed in 250a102.


Re-add internationalization beta

Details
In https://github.com/Expensify/App/pull/4967 we removed the internationalization beta, but according to https://github.com/Expensify/App/pull/4967#issuecomment-918222573 we do not yet want to remove it. This PR re-adds the beta (files had changed so GH revert functionality didn't work).
Fixed Issues
Comment: https://github.com/Expensify/App/pull/4967#issuecomment-918222573
Tests

Update this line to remove the isDevelopment() check.
Sign out of the app, on the sign-in page confirm you don't see the option to change from English to Spanish.
Sign into an account that is on the beta, confirm you can see the English/Spanish dropdown

QA Steps

Sign out of the app, on the sign-in page confirm you don't see the option to change from English to Spanish
Sign into an account that is on the beta, then go to Preferences, confirm you can change from English to Spanish

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @roryabraham in version: 1.0.98-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add a button for a reaction roll to the monster tab

From #12
A morale roll already exists, but one for a reaction roll would be useful as well.

It should be clickable
It shouldn't show the result to the players

Wouldn't it be easier to add a button to the player's sheet? The modifier is just there and wouldn't have to be entered. Is it possible to create a button that sends a PM with the result to the GM?

I could add it to the player's sheet, but I think the player can see the results. I'll have to test that out.

I think the player can see the results. I'll have to test that out.

Yep, the player can see the results of the reaction roll. I'll put it on the monster page and have the GM roll it.


disappearing ranges on closer zoom -!found cause, need help to fix!

Hi
First things first great software.
Sadly though when zooming in to timeframes approximately less than 12 hours ranges start disappearing from the timeline!
This is for a timeline with less than 400 ranges set into 5 groups.
For some reason the order of the group seems to affect when ranges disappear but this is not universal...

so...on further testing groupMinHeight option is the culprit -turn this off and all events display -but then empty groups become unreadable as they are crunched down...
any help?

Can it be that this has to do with clustering instead? Maybe the disappeared items are clustered wrongly?


Feature Request - Accessible tabbing

Hey! Just started using this and I can't praise it enough. How hard would including accessible tabbing be? At the moment if I tab through internal links throughout the page the scroll doesn't move with me. I know this is common with smooth scroll libraries so i'm guessing it'd be quite hard to implement?
Thanks again for the awesome work on this so far :)

Hey Sam, thanks! I'm currently on vacation but as soon as I get back I'll check it out.
Initially I wouldn't imagine there'd be a problem - since we're technically bound to the window scroll - however if you're saying it's not working correctly I might be missing something.
I'll let you know next week 🙂

Hey @samuelgoddard, apologies for the delay. I've been able to take a look at this and believe I've got a solution:
useEffect(() => {
  const onTab = (e) => {
    if (e.key === 'Tab' || e.keyCode === 9) {
      const el = document.activeElement;
      const rect = el.getBoundingClientRect();

      const windowWidth =
        window.innerWidth || document.documentElement.clientWidth;
      const windowHeight =
        window.innerHeight || document.documentElement.clientHeight;

      const isInViewport =
        rect.top >= 0 &&
        rect.left >= 0 &&
        rect.bottom <= windowHeight &&
        rect.right <= windowWidth;

      if (!isInViewport) {
        window.scrollTo(0, el.offsetTop);
      }
    }
  };

  document.addEventListener('keyup', onTab);

  return () => document.removeEventListener('keyup', onTab);
}, []);

You'll find a working example here: https://stackblitz.com/edit/react-cfbmzv?file=src%2FuseScrollOnTab.js
Do let me know if any issues! 🙂


Add Zenburn theme

Zenburn theme home page: https://kippura.org/zenburnpage/
And Vim Zenburn theme repository, from which I took color codes: https://github.com/jnurmine/Zenburn

pygmentize -f html -O style=zenburn,full,linenos=True,hl_lines=9 test.py -o test.html

Thanks! There are only two more colors missing, for special line numbers. You can test that with lineospecial=2, the color names are line_number_special_color and line_number_special_background_color. Those are used to highlight every N-th line, so you probably want something a tad brighter for them.

Added _spcial_ colors for line numbers. But something does not work with HTML generator, because just by adding linenospecial=2 does not work. It only worked for me by also adding noclasses=True. It seems, that generated HTML and CSS styles does not line up.
pygmentize -f html -O style=zenburn,full,linenos=True,linenospecial=2,noclasses=True,hl_lines=9 test.py -o /tmp/test.html

Thanks @sirex! I was going in circles trying to figure out why the special formatting wasn't applying. Thanks for documenting your temporary solution.

The class issue is fixed in #1701, I think. Thanks for your contribution!


Add Avatar upload

On the profile page a user should be able to upload an avatar.
A preview would be nice and maybe an auto crop to square. This can be done fully in js.
We may need to discuss where to save the images and so on

Here some inspiration https://github.com/overtrue/vue-avatar-cropper/blob/master/src/AvatarCropper.vue


Update Spring Security, Spring Boot BOM, mysql-connector-j, and hibernate validaror versions

Update the version of spring related dependencies to the latest version used by the latest 2.7.x spring boot branches (version 2.7.8 at the moment of this MR/PR)
the 'mysql:mysql-connector-java' dependencies has been changed to 'com.mysql:mysql-connector-j' (the artifact was moved from mysql:mysql-connector-java to com.mysql:mysql-connector-j and the mysql:mysql-connector-java dependencies was not anymore in sping-boot-dependencies:2.7.8).
All unit tests passed and I was able to run the SPA and MPA examples (however I did not do exhaustive tests with them)

This pull-request helps me a lot! Thank you :)


Label has unused export properties.

Are we using Label component today?
I cannot find a single "import Label.svelte" in src files. Am I wrong?
Today this is still a problem with the warnings in CI env.


Localization update

This PR was auto-generated with the localization pipeline build.

Closed PR since there are still some not localized strings in output.


Secure consul

This patch does three things to secure consul:

enabled ssl pki certs via a puppet master
that are used to encrypt traffic for consul
rpc calls

sets an encryption key to encrypt gossip
traffic.

disables exec commands on all nodes except
the consul master node.

last test failed b/c it could not install our custom packages from rustedhalo. It happened on about half of the nodes, rerunning

please test this

please test this

please test this

please test this

please test this

please test this

please test this

please test this

please test this

please test this

please test this

please test this

please test this

please test this

running one more test b/c I had so many test failures before, the last test passed

please test this

@sorenh this passed tests 3 times in a row and is ready for review. Careful review would be great, I'm not sure about the introduction of Puppet to generate cluster specific certs...

please test this

@sorenh this should actually be the for realz version of this patch...

please test this

please test this

please test this

please test this

this test actually passed, I verified that everything works as expected. I just need some review, b/c I've made quite a few decisions here worth discussing (esp related to the generate of cluster specific ssl certs).

please test this

please test this

please test this

Other than this, the code seems fine to me. Last test failed because of a tempest test failure. Will rerun the test and will check the system .

please test this

please kill that run. I will make that fix and resubmit

please test this

please test this

please test this

@bodepd : just wondering, are we planning to take this up?

this patch has three parts:

encryption for gossip protocol (already merged)
fixes user escalation by setting up firewall rules to restrict port access(this is better implemented as an upgrade to 5.0 which supports unix sockets)
server auth through PKI (this is way too complicated for what we get out of it, I'm curious if there is a better solution for consul 5)

I think it's best to upgrade to 5 and reevaluate


Modified downing-provider-class to "org.apache.pekko.cluster.sbr.Spli…

Modified downing-provider-class to be "org.apache.pekko.cluster.sbr.SplitBrainResolverProvider" as per the documentation https://github.com/apache/incubator-pekko/blob/v1.0.1/cluster-typed/src/test/scala/docs/org/apache/pekko/cluster/typed/BasicClusterExampleSpec.scala#L42-L60

I created https://github.com/apache/incubator-pekko-samples/pull/54 because this issue appears in a few places. Thanks for reporting it. I'll close this if you don't mind.

Of course not :-)


Fix error when no options are provided

Just a tiny improvement to the otherwise very helpful extension (thanks a lot!).
I followed the README up to $('.gallery').bootstrapGallery();. That statement is however not working as intended:
When options is undefined, the error Uncaught TypeError: Cannot read property 'hasOwnProperty' of undefined would occur in line 20.
Hence I suggest this pull-request. Of course, this is an edge case since normally you would want to include some navigation icons (as you show later on), but just to make it more robust (and avoid others stumbling over it).
Thanks again for the plugin!

Thank you, good work :+1:


Regression: changing source/target providers while editing an existing plan no longer causes the rest of the wizard steps to be cleared

All of the options/selections on the filter/select VMs and mappings steps of the wizard are dependent on the selected source and target providers on the General step. If the user changes one of those provider selections, the wizard should clear all their selections in those dependent steps so they can start fresh. We implemented this with a useEffect here:
  // When providers change, reset all forms containing provider-specific options
  React.useEffect(() => {
    if (!isFirstRender.current && isDonePrefilling) {
      forms.filterVMs.reset();
      forms.selectVMs.reset();
      forms.networkMapping.reset();
      forms.storageMapping.reset();
    }
    isFirstRender.current = false;
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [forms.general.values.sourceProvider, forms.general.values.targetProvider]);

However, in https://github.com/konveyor/forklift-ui/pull/365 we indirectly changed the behavior of what that reset() function does by introducing the setInitialValue function in lib-ui's useFormState. When you reset a form, it sets all the fields to their initialValue, which in the case of a plan being edited is the values prefilled from the existing plan, not the initial values from an empty wizard (because we switched from using setValue to setInitialValue in the useEditingPlanPrefillEffect. So if the user is editing a plan, when they change providers it doesn't actually clear anything. This can cause weird side effects as form state and query results from a different provider are hanging around when the user moves through the wizard.
The bug is unfortunately present in 2.0.0, but it seems like everything is fine in that version because there is only one type of source provider and one type of target provider. So loading things like useMappingResourcesQuery will have the same results no matter which source provider you choose. However, with https://github.com/konveyor/forklift-ui/pull/597 we are introducing RHV source providers, and I have found that if you are editing a VMware plan and change to a RHV source provider, it totally breaks the storage mappings step of the wizard since it fails to prefill required sources from the new query (storage domains rather than datastores).
To fix this, we need to make it so those reset() calls will actually reset the form to actual blank initial values instead of what was in the planBeingEdited. We can't just go back to using setValue in the useEditingPlanPrefillEffect though, because that will reintroduce the bug fixed in #365. Instead we need a way to retain the initialValues when prefilling the plan, without setting isDirty when we prefill values.
I think a viable solution might be to add a setIsDirty parameter of the setValue function, which defaults to true. That way, we could use setValue for the prefilling, with that param set to false, and prevent the isDirty problem that was causing the save buttons to enable prematurely, but the initialValues in the form state would still be an empty wizard's values so the reset() calls would have the intended effect. This would require modifying lib-ui and upgrading to a new version here.

@seanforyou23 i need to introduce you to my custom useFormState hook in lib-ui :) despite wrinkles like this I'm still super glad we did it instead of using Formik or whatever. Note that the deployed docs URL is broken, so if you want to read about it you should clone https://github.com/konveyor/lib-ui and run its storybook locally.

Depends on https://github.com/konveyor/lib-ui/pull/65.