Add Wikidata tags to POIs with brand names

There are lots of amenity/shop POIs with records on Wikidata.  It would be nice to have the automatically tagged when inserted/edited, as is already done with other elements.
There's a list of the existing Wikidata entries for these elements.

The name-suggestion-index project came out of iD and is primarily used here 😂
When adding a new POI, you can search for a specific brand and it will add the Wikidata tag if available. See #6122 for recommending the tags to the user after they set the name manually.
Note that the version of iD on openstreetmap.org doesn't yet include the extensive updates made to the brand index in the past few weeks.


Wrapping redirect in ClerkProvider leads to spurious redirect

Preliminary Checks

[X] I have reviewed the documentation: https://clerk.com/docs
[X] I have searched for existing issues: https://github.com/clerk/javascript/issues
[X] I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)
[X] This issue is not a question, general help request, or anything other than a bug report directly related to Clerk. Please ask questions in our Discord community: https://clerk.com/discord.

Reproduction / Replay Link
https://github.com/xixixao/bug-clerk-next-redirect
Publishable key
pk_test_cHJvcGVyLXdoaXBwZXQtNzcuY2xlcmsuYWNjb3VudHMuZGV2JA
Description

npm run dev
Sign in or sign up
Wait a second, and observe that you are redirected to an invalid URL that doesn't live under the configured basePath

This was super hard to debug, but in the end what I had was weird, basically my layout was at the wrong level. Still wanted to share it in case someone else runs into this. Looks like nesting a redirect, or streaming server component, under ClerkProvider leads to weird behaviors.
Environment
System:
    OS: macOS 14.2.1
    CPU: Apple M1
  Binaries:
    Node: 18.17.0 - ~/Library/Caches/fnm_multishells/2125_1705529595263/bin/node
    npm: 9.6.7 - ~/Library/Caches/fnm_multishells/2125_1705529595263/bin/npm
    pnpm: 8.7.4 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 120.0.6099.234
    Safari: 17.2.1
  npmPackages:
    @clerk/nextjs: ^4.29.4 => 4.29.4
    @types/node: ^20 => 20.11.5
    @types/react: ^18 => 18.2.48
    @types/react-dom: ^18 => 18.2.18
    autoprefixer: ^10.0.1 => 10.4.17
    eslint: ^8 => 8.56.0
    eslint-config-next: 14.1.0 => 14.1.0
    next: 14.1.0 => 14.1.0
    postcss: ^8 => 8.4.33
    react: ^18 => 18.2.0
    react-dom: ^18 => 18.2.0
    tailwindcss: ^3.3.0 => 3.4.1
    typescript: ^5 => 5.3.3

Thanks for the issue and explaining how you figured it out :)


Mccalluc/reproduce session bug

Higlass came up! Though I didn't have any data to select from ... I might have been doing something else wrong. I also am logged in, but did not hit the same problem we saw on refinery, so might not be capturing all the details needed for a reproducer.

I'll merge for now, and fix it in the next. Thanks.


redux-resource-xhr: defaults

Specifying a custom query string serializer on every request can be tedious. There should be a way to configure defaults, similar to request.defaults.
Related: #178

For now, if you need a custom query string serializer, I recommend a pattern like this:
// default-xhr-options.js
import myQsLib from 'my-qs-lib';

// Set up your query string serializer in a single file, like so.
export default {
  qsStringify: myQsLib.stringify,
  qsStringifyOptions: {
    blah: true
  }
};

Then, import that config and spread it on all of your action creators:
// my-action-creators.js
import { readResources } from 'redux-resource-xhr';
import defaultXhrOptions from './path/to/default-xhr-options';

export default readBook(bookId) {
  return dispatch => readResources({
    resourceName: 'books',
    resources: [bookId],
    xhrOptions: {
      ...defaultXhrOptions,
      json: true
    },
    dispatch
  }
}

Going to close as revisit for now. The "workaround" above is actually a pretty reasonable pattern I think, so I think this is lower priority. Always open to PRs, of course! :v:


Provide container setup and a container image

Show, provide and test XLT in a container.

Building the XLT docker image can be done with packer. See https://github.com/Xceptance/XLT-Packer/issues/5 for more info.


Buildkite producing invalid terraform plan

This seems to be similar to the error seen in https://github.com/buildkite/terraform-provider-buildkite/issues/502
I've been trying to run a Terraform apply for our org and have been hitting multiple instances of this error:
╷
│ Error: Provider produced invalid plan
│
│ Provider "registry.terraform.io/buildkite/buildkite" planned an invalid value for buildkite_pipeline.website.steps: planned value cty.StringVal("steps:\n- label:
│ ':pipeline: Pipeline Upload'\n  command: buildkite-agent pipeline upload") does not match config value cty.UnknownVal(cty.String).
│
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
╵

We're on version 1.4.1 of the Buildkite terraform provider.

@pink thanks for raising this. I've asked @jradtilbrook to follow up with some information on how this was resolved in the mentioned issue.

Ahh yes. The case with #502 was more of a misconfiguration of terraform. Can you share with us a minimal reproduction where you see this issue?
Feel free to email us at<EMAIL_ADDRESS>if you want to send the exact info and keep it private.

Thanks for reporting this @pink. It should be resolved with #539


Routing to new components does not alert screen reader users of changes

Routing to new components does not alert screen reader users to changes in content. See https://marcus.io/blog/improved-accessible-routing-vuejs for a fairly thorough discussion of possible solutions in Vue.

After discussions of potential solutions, addressed focus issues when routing to a new route for this ticket. Route change announcement was addressed as part of a previous ticket.

PR: https://github.com/NationalSecurityAgency/skills-service/pull/1385

:+1:


Add some documentation

closes #30

sorry for the noise with the space changes, I've setup eslint ignore to hopefully not have this any more.
adds some info when creating a multisig
enhance the design a bit (with MUI Alerts)
created a "Help" page to document the current setup (it's dynamic, it shows some warning too eventually, e.g when threshold is the same as the amount of signatories)
creates a nice overview of the signatories, multisig(s) and pure proxy. Let's see if this helps someone. At least is looks kindda nice :)
fixes a bug in the indexer for "Staking" type of proxy
adds the proxy type in the UI for each multisig (we had the info pulled from the indexer but never used, now I use it in the diagram)

If you want to see this too, you need to

point your local node at Kusama (see the .env.example comments in ./squid)
connect the UI to it using ?network=local
add a hacky watch address such as "HqfNL8eE5Efvw5Wcj8d3tjeoCS3BPfshMHWG6rmtYUrgyrU" who's part of the ChaosDAO multisig (see the Readme of ./ui to know how to do this)

Merging this as I need to get going and fix #99 which will touch the same components.


Enabling KEDA fails as it's behind a preview flag

Describe the bug
Enabling KEDA fails as it's behind a preview flag
To Reproduce
Steps to reproduce the behavior:

Go to Addon Details
Enable "KEDA : Enable Kubernetes Event-driven Autoscaling (KEDA) on the AKS Cluster"

{     "status": "Failed",     "error": {         "code": "BadRequest",         "message": "Feature Microsoft.ContainerService/AKS-KedaPreview is not enabled. Please see https://aka.ms/aks/previews for how to enable features."     } }
Expected behavior
Setup the Preview flag OR warn the user that it needs to enable the preview flag for KEDA : https://docs.microsoft.com/en-us/azure/aks/keda-deploy-add-on-arm#register-the-aks-kedapreview-feature-flag
az feature register --name AKS-KedaPreview --namespace Microsoft.ContainerService
Screenshots

Hi @naioja
Thanks for the issue 👍
We do have a warning for all preview features, but as #384 mentions - it may be too subtle.

Yes, true but that is not necessarily valid for  enabling the Azure providers for KEDA and CSI.

Yep. I think we can probably add an extra link to the Helper (that you mentioned above) to give users a steer 👍

For example for KEDA if it's enabled as a deployment feature we can add a check if the provider is enabled
az feature list -o table --query "[?contains(name, 'Microsoft.ContainerService/AKS-KedaPreview')].{Name:name,State:properties.state}"
and if that's false then user can enable it:
az feature register --name AKS-KedaPreview --namespace Microsoft.ContainerService

I've created this issue to capture the better experience we want for this.
#421


Add integration tests to CI

Goal of this PR
It seems like integration tests were not run as part of CI, and some of them are actually not passing.

Do we want to always run the integration tests though? They might run fast now, but ideally we probably will want to run them only on a nightly build or something like that, soon enough (if we don't want a 15mn CI :p)

When it gets annoying, we can decide :)


Fix missing options argument in check call

[x] This is a bugfix
[ ] This is a new feature
[ ] This is a code refactor
[ ] This is a test update
[ ] This is a typo fix
[ ] This is a metadata update

For Bugs and Features; did you add new tests?
After looking at the existing tests, I think writing a case for this would take way more time than what this bug is worth (and than what I have to spare). Please, feel free to add one, if deemed necessary.
Motivation / Use-Case
The code throws without the fix.

Thanks for the PR 🍺
You get a pass for lib/client code on tests, since we presently have none. 😆
For the rest of the code, that's a hard requirement though. Same goes for most of webpack-contrib. If you find yourself short on time, an issue with the fix mentioned would be just as helpful (without having to explain you have no time for tests).
I'll get this released shortly.

an issue with the fix mentioned would be just as helpful

Okay, noted :slightly_smiling_face: Though can get cumbersome with larger diffs, I'd imagine.

I'll get this released shortly.

Thanks.

Though can get cumbersome with larger diffs, I'd imagine.

Absolutely, excellent point.


Dependency scanner for pub can't load Copyright Text

Describe the bug
I'm using dependency_scanner for my flutter project. I 'm generate oss license file like below

When i run fosslight_dependency_scanner, this software generate file without copyright text. I don't know why because my dart file have license text. Is there any other reason?

I found it . This code is written like below.
https://github.com/fosslight/fosslight_dependency_scanner/blob/0a4e9e2c8a94f8a426b09cee6a6b955ebf17cd65/src/fosslight_dependency/analyze_dependency.py#L797
Any plans to support this feature?

@namkyu1999
Thanks for the reporting it!
We will add it. 😃

How about using scancode-toolkit? Your team already used this package in 'fosslight_source_scanner'.

In fact, scancode-toolkit is a bit heavy for fosslight_dependency_scanner to use. But it would be nice if the tools could be unified and the copyright could also be detected. We will consider to replace it.


[MLIR] fix reshape dims having negative values

This happens in distillgpt2
Currently MLIR does not accept undefined/inferred as reshape dims.
For certain models, there are reshape with "dims" attribute with -1 in it but with a static shape as a result.
These fail in the MLIR backend.
E.g. :
mlir_main:pointwise4:x1.0 = @param:x1.0 -> half_type, {1, 2304}, {2304, 1}, target_id=0
mlir_main:pointwise4:@1 = multibroadcast[out_lens={384, 2304},out_dyn_dims={}](mlir_main:pointwise4:x1.0) -> half_type, {384, 2304}, {0, 1}, target_id=0
mlir_main:pointwise4:y1 = @param:y1 -> half_type, {768, 2304}, {2304, 1}, target_id=0
mlir_main:pointwise4:y0 = @param:y0 -> half_type, {1, 384, 768}, {294912, 768, 1}, target_id=0
mlir_main:pointwise4:@4 = reshape[dims={-1, 768}](mlir_main:pointwise4:y0) -> half_type, {384, 768}, {768, 1}, target_id=0
mlir_main:pointwise4:@5 = dot(mlir_main:pointwise4:@4,mlir_main:pointwise4:y1) -> half_type, {384, 2304}, {2304, 1}, target_id=0
mlir_main:pointwise4:@6 = add(mlir_main:pointwise4:@5,mlir_main:pointwise4:@1) -> half_type, {384, 2304}, {2304, 1}, target_id=0
mlir_main:pointwise4:@7 = @return(mlir_main:pointwise4:@6), target_id=0

terminate called after throwing an instance of 'migraphx::version_2_7_0::exception'
  what():  /var/mkarunar/work/AMDMIGraphX/src/targets/gpu/mlir.cpp:248: attribute: MLIR cant handle negative values since they are ambiguous

This ticket is to fix this where appropriate.
one option being inside fuse_mlir when checking view ops, just replace the dims with output shape as follows :
-                op_stream.push_back(input->get_operator());
+                if(input->name() == "reshape"){
+                    op_stream.push_back(make_op("reshape", {{"dims", input->get_shape().lens()}}));
+                }
+                else{
+                    op_stream.push_back(input->get_operator());
+                }

@pfultz2 Could you review if the attempted change by @manupak is desirable? If so we can file a pull request and get it fixed.


How to create custom index and  field ?

elastalert will create a index (Default elastalert_status)  , Can I create like logstash_log-*  ?
Can I custom which field in the index ? How to define the value to field ?

Mappings are defined here.
https://github.com/Yelp/elastalert/blob/master/elastalert/create_index.py#L106
You can add additional fields and re-create the index.

Qmando,
but when I try to create new index like logstash-log-* , get the error message "must not contain the following characters [\, /, *, ?, ", <, >, |,  , ,]'}) " , because I want to create index like logstash-log-2017.05.01 for every day, how to create the index like this ?
I can not find how to custom field for my new index from your link (https://github.com/Yelp/elastalert/blob/master/elastalert/create_index.py#L106)?
as i see, it's default field is @timestamp,_id,_index,_score,_type,data.rule,message,traceback , how can I add new field and delete field  ?

https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping.html


Panic on "\ \ \\ \\"

$ printf '\\ \\\\ \\\\\\ \\\\\\\\\n\n' | ./pulldown-cmark
thread 'main' panicked at 'unexpected item body Backslash', src/parse.rs:2740:14
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:39
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:70
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:58
             at src/libstd/panicking.rs:200
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:215
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:478
   5: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:385
   6: std::panicking::begin_panic_fmt
             at src/libstd/panicking.rs:340
   7: pulldown_cmark::parse::item_to_event
             at src/parse.rs:2740
   8: <pulldown_cmark::parse::Parser<'a> as core::iter::traits::iterator::Iterator>::next
             at src/parse.rs:2821
   9: <&mut I as core::iter::traits::iterator::Iterator>::next
             at /rustc/fc50f328b0353b285421b8ff5d4100966387a997/src/libcore/iter/traits/iterator.rs:2730
  10: <pulldown_cmark::html::HtmlWriter<'a, I, W>>::run
             at /mnt/d/src/pulldown-cmark/src/html.rs:144
  11: pulldown_cmark::html::write_html
             at /mnt/d/src/pulldown-cmark/src/html.rs:522
  12: pulldown_cmark::main
             at src/main.rs:260
  13: std::rt::lang_start::{{closure}}
             at /rustc/fc50f328b0353b285421b8ff5d4100966387a997/src/libstd/rt.rs:64
  14: std::panicking::try::do_call
             at src/libstd/rt.rs:49
             at src/libstd/panicking.rs:297
  15: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:87
  16: std::rt::lang_start_internal
             at src/libstd/panicking.rs:276
             at src/libstd/panic.rs:388
             at src/libstd/rt.rs:48
  17: std::rt::lang_start
             at /rustc/fc50f328b0353b285421b8ff5d4100966387a997/src/libstd/rt.rs:64
  18: main
  19: __libc_start_main
  20: _start

Can be shortened to:
$ printf '\\ \\\\\n\n' | ./pulldown-cmark

This might be the same as #304. Interestingly the fuzzer only found the panic with \r\r and not \n\n.

Yeah, definitely looks as a duplicate. Didn't check for duplicates after the shortening....


export via project with detections only

We currently only export a VIA project with the final tracks but a VIA project with the detections only (and their scores even those below the threshold) would be useful for debugging.

Now done since fdb11ff. Closing as fixed.


Utilize NO_NEW_PRIVS when available

The relatively-new prctl flag NO_NEW_PRIVS (available starting in kernel 3.10) prevents a process - and all its descendants - from acquiring any privileges (such as those granted by setuid / setgid executables).
Setting this would be an additional layer of security - primarily against really strange configurations.  Singularity already sets MS_NOSUID on the image mount, but not on the bind mounts.  So, this would protect against an administrator that adds bind /usr/sbin/sudo to the configuration file.
I don't currently see the lack of this flag as an exploit, but rather a measured improvement on top of the existing security mechanisms.

Excellent, thinking! This brings up 2 questions for me:

Should we enable MS_NOSUID on the bind mounts too? I am thinking yes, as you brought up a very good example... Or make it configurable? (however I can't imagine why anyone would want it enabled).

What about the introduction of PR_SET_SECCOMP with a SECCOMP_MODE_FILTER. Granted, this will take the security potential of a container up a lot, it will also break A LOT considering we will have to create an op-in for every syscall we feel is harmless (unless I am misreading BPF, which seems quite cryptic to me). But... the idea of Singularity is not necessarily to make a more secure environment then what the user already has, but there has been some discussions related to encrypted images and increased limitations when running within a container.

I'd definitely view PR_SET_SECCOMP as separate project (FWIW - Docker provides this and has some good examples to start with) - much for the same reasons you provide.  I assume the "typical" Singularity user already can execute arbitrary code as an unprivileged user outside the container, hence I'm more interested in fairly modest improvements (i.e., one prctl call).  Note the BPF can work by blacklisting certain syscalls - I think Docker does this - instead of whitelisting known safe ones.
I had the same idea about doing MS_NOSUID on bind mounts - that flag is supported by virtually all kernel versions.  I wasn't sure what the semantics of the combination of bind mounts and MS_NOSUID are, however.

I agree with making the PR_SET_SECCOMP a separate (and possibly future) milestone and I see you started working on it in #152. Excellent, thank you!

Fixed with #152.


Running

Walk_sheets.zip

Hmm, I think his legs are weird, I think they're too far away. But this is a skeleton 🤷♂ Nice work


[web]: icons are rendered with vertical offset on Firefox

The Icon widget seems to be rendered with a small vertical offset at the top when displayed on Firefox.
For example:
            child: Stack(
              children: [
                Container(width: 24, height: 24, color: Colors.lightGreen),
                Icon(Icons.send, size: 24),
              ],
            ),

is correctly rendered on Chrome:

but is misaligned on Firefox (tried on Mac OS X 10.15 and Android):

flutter doctor -v:
[✓] Flutter (Channel dev, v1.10.16, on Mac OS X 10.15.1 19B88, locale en-KR)
    • Flutter version 1.10.16 at /Users/thibaultdeckers/projects/flutter
    • Framework revision 798e4272a2 (6 days ago), 2019-11-06 21:04:17 -0500
    • Engine revision 34a40cfbfd
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/thibaultdeckers/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 28.0.3
    • Java binary at: /Users/thibaultdeckers/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/191.5977832/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.2, Build version 11B52
    • CocoaPods version 1.8.4

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /Users/thibaultdeckers/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/191.5977832/Android Studio.app/Contents
    • Flutter plugin version 41.1.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.40.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.6.0

[✓] Connected device (3 available)
    • iPhone 11  • 3373C512-23C6-42EC-8BA6-F79DC1ADE884 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-2 (simulator)
    • Chrome     • chrome                               • web-javascript • Google Chrome 78.0.3904.97
    • Web Server • web-server                           • web-javascript • Flutter Tools

• No issues found!

Material font has higher line height in firefox.  Please use:
Container(width: 24, height:24, color: Colors.lightGreen,
child: Icon(Icons.send, size: 24))

@ferhatb thank you for the explanation, but I don't think this issue should be closed.
The workaround you mention yields on Firefox exactly the same result as the image I included before. Actually, the convoluted Stack + Container was just an example to easily see the issue, but the offset is also a problem in core Widgets like IconButton.
Code:
            IconButton(
              icon: Icon(Icons.send),
              onPressed: () {},
            )

on Chrome (mouse hovering shows the highlight):

on Firefox (mouse hovering shows the highlight):

The icon is not in the center of its own highlight.

Thanks for reopening the issue, i assumed it was due to small container height since increasing it aligns it correctly. IconButton should definitely work correctly across browsers. We'll take a look at it again and see why Firefox is reporting 28.5 pixel height instead of 24px on all other browsers.

I cannot reopen the issue, as it wasn't closed by me.


get .srcElement from originalEvent in highcharts.js

Because of https://jquery.com/upgrade-guide/1.9/#removed-properties-of-the-event-object
Related to #1197

wontfix, not related to jquery after all


RFC 1123 issue using HelmChartProxy

What steps did you take and what happened:
I have problems creating a HelmChartProxy for helm charts containing a "/" in the "chartName". I get the error, that the creation of the HelmReleaseProxy failed due to problems with the schema:
      HelmReleaseProxy.addons.cluster.x-k8s.io "ingress-nginx/ingress-nginx-my-cluster-jxldh"
      is invalid: [metadata.generateName: Invalid value: "ingress-nginx/ingress-nginx-my-cluster-":
      a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters,
      ''-'' or ''.'', and must start and end with an alphanumeric character (e.g.
      ''example.com'', regex used for validation is ''[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*''),
      metadata.name: Invalid value: "ingress-nginx/ingress-nginx-my-cluster-jxldh":
      a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters,
      ''-'' or ''.'', and must start and end with an alphanumeric character (e.g.
      ''example.com'', regex used for validation is ''[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'')]'

I have tried to fix this by using the setting "releaseName" but without success. Is any one able to help me out here?
---
apiVersion: addons.cluster.x-k8s.io/v1alpha1
kind: HelmChartProxy
metadata:
  name: nginx-ingress
spec:
  clusterSelector:
    matchLabels:
      nginxIngressChart: enabled
  repoURL: https://kubernetes.github.io/ingress-nginx
  releaseName: nginx
  chartName: "ingress-nginx/ingress-nginx"
  version: "4.8.5"
  namespace: ingress-nginx
  options:
    waitForJobs: true
    wait: true
    timeout: 5m
    install:
      createNamespace: true
  valuesTemplate: |
    controller:
      name: "{{ .ControlPlane.metadata.name }}-nginx"
      kind: DaemonSet

What did you expect to happen:
Deployment of the helm chart in the cluster succeeds.
Anything else you would like to add:
%
Environment:

Cluster API version: clusterctl version: &version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.3", GitCommit:"b0284d8b9bf1220b744e8cfbfc812321c733e2dd", GitTreeState:"clean", BuildDate:"2024-06-11T10:14:56Z", GoVersion:"go1.21.11", Compiler:"gc", Platform:"linux/amd64"}
Cluster API Add-on Provider for Helm version: v0.2.4
minikube/kind version: kind v0.23.0
Kubernetes version: (use kubectl version): v1.30.0
OS (e.g. from /etc/os-release): Ubuntu 22.04

/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]

I believe the chart name is just ingress-nginx. The string "ingress-nginx/ingress-nginx" likely refers to the repo name, a slash, and the chart name. Let me know if it works for you now.

Hey, thank you very much for the hint. That worked for me :)


error: no match for ‘operator/=’ (operand types are ‘cv::Point3d {aka cv::Point3_}’ and ‘double’)

When I build code, I get this issue.
Anyone has overcame it, plz give me an instruction!!! Thankiu in advance

Hi, can you tell me the version of your OpenCV installation?

I installed OpenCV 2.4.11

Can you try it with OpenCV 3? Ideally, OpenCV 3.2.0

Closed due to inactivity


tabbing through size in image editor pops up accessibility menu

Describe the bug
the text boxes for the image size in the image editor are tabbable, but end up being the last thing in tab order on the page, so tabbing  through them immediately pops up the accessibility menu which is jarring / distracting.
maybe just making done tabbable would be sufficient so the focus goes to that instead would be sufficient; there always needs to be a way to access that menu, but this is a pretty common case to have it  pop up every time
To Reproduce
Steps to reproduce the behavior:

Go to image editor
click text box for size
tab past both text boxes
See error

Expected behavior
focus goes to some other element so you don't immediately get the jarring behavior from the only things you really want to tab with in the image editor
Screenshots

Tabbing seems to just be generally broken in the image/tilemap editor. We don't trap focus properly


Question: is it possible to override the version used?

Hello !
I would like to have a two part version number, like dependency-version_my-version like other libraries do.
How can I override the version number ?
Thanks.

Thank you for reporting! You can define version := any way you like. By default, the version number is provided by https://github.com/dwijnand/sbt-dynver There's nothing specific about sbt-ci-release, you can look at the source code yourself, it's only 170 lines https://github.com/olafurpg/sbt-ci-release/blob/master/plugin/src/main/scala/com/geirsson/CiReleasePlugin.scala

If you want to prepend a prefix to the version you can do
version ~= { oldVersion =>
  "new-suffix_" + oldVersion
}

FWIW, the idiomatic way to cross-build against multiple version of a single dependency is to include that name in moduleName instead of versions

I copied the way https://mvnrepository.com/artifact/com.holdenkarau/spark-testing-base is doing it. And it works now :) https://github.com/leobenkel/ZparkIO/blob/3c01b7e3ba20391e096588aca9cfe26f52eca7cb/build.sbt#L32-L33 , thank you !


AugmentedFacesExample camera failure; works in 1.25

Hey ARCore folks,
Friendly heads that there seems to be something wrong with the 1.26 AugmentedFacesExample. Frames never start landing, so it's just a stream of In renderer, currentFrame is nil. [Things work fine in 1.25.]
Thanks!
Chris
(ex-Daydreamer)

Sorry about this. We have identified the issue and a fix will be in 1.27 (expected late September).
For now I recommend just using 1.25.


PDF feature request: for drafts, provide additional metadata on top right corner like published/DIS document

For (docstage != 60) documents, we should provide additional metadata.
Published deliverables have "edition info" and "published date".

Taking hint from the ISO DIS PDF layout:

Let's add the following metadata:

Revdate

Secretariat

TC/WG info

ICS if it exists

Preferably, a special line of comment to be placed at the bottom. Do we have a Metanorma XML place for this sentence?

@ronaldtse ISO xslt supports DIS layout already.
https://github.com/metanorma/mn-samples-iso/blob/gh-pages/documents/international-standard/rice-en.dis.pdf

Revdate

do you mean 'Voting begins on:' and 'Voting terminates on:'?
adoc:
:vote-started-date: 2020-02-19
:vote-ended-date: 2020-05-13

Secretariat

I'll fix double Secretariat: Secretariat:.

TC/WG info

Currently, only ISO/TC 46 rendered, but I'll add SC.

ICS if it exists

It renders already, but:
:ics: 01.140.10

should be changed to:
:library-ics: 01.140.10

Preferably, a special line of comment to be placed at the bottom. Do we have a Metanorma XML place for this sentence?

No, this sentence is hard-coded in ISO xslt and display for DIS documents only.

@ronaldtse ISO updated. Here is rendered PDF example for data:
:docstage: 40
...
:workgroup-number: 3
...
:library-ics: 01.140.10
...
:vote-started-date: 2020-02-19
:vote-ended-date: 2020-05-13

Note: DRAFT rendered instead of DRAFT INTERNATIONAL STANDARD due the value in presentation xml:
<stage abbreviation="DIS" language="en">Draft</stage>

@Intelligent2013 for DIS layout, we have to show the document type "DRAFT INTERNATIONAL STANDARD" on top.
The point of this ticket is to allow showing metadata information for other draft stages (PWI, AWI, WD, CD) as well, like this:

And I also want to display an additional comment at the bottom (if exists), this will need to be a new attribute that Metanorma provides.

TC/WG info
Currently, only ISO/TC 46 rendered, but I'll add SC.

Does MN XML provide the full name of the drafting committee? We need to have the full identifier. In DIS and FDIS, only the TC/SC (if SC exists), no WG.

Does MN XML provide the full name of the drafting committee? We need to have the full identifier. In DIS and FDIS, only the TC/SC (if SC exists), no WG.

@ronaldtse MN XML provides textual name for each sub-component:
<editorialgroup>
	<technical-committee number="46">Information and documentation</technical-committee>
	<subcommittee number="2" type="SC">Conversion of written languages</subcommittee>
	<workgroup number="3" type=""/>
	<secretariat>AFNOR</secretariat>
</editorialgroup>

But there isn't predefined value ISO/TC 46/SC 2/WG 3. Xslt renders it on-fly.
I'll create a ticket.

ISO xslt updated for PWI, AWI, WD, CD cover page, added:

revision date
TC/WG information
secretariat
ICS code

And I also want to display an additional comment at the bottom (if exists), this will need to be a new attribute that Metanorma provides.

@ronaldtse I'm going to create ticket for metanorma-iso gem, so:

how would you like to set this additional comment - via parameter in document.adoc or hard-coded in gem?
what is condition to render this comment - DIS only or something else?

TC/WG information

The current rendering isn't most correct. Is that identifier provided by Metanorma XML (it should) or is it generated from XSLT?

how would you like to set this additional comment - via parameter in document.adoc or hard-coded in gem?

Parameter in document.adoc please.

what is condition to render this comment - DIS only or something else?

Whenever such comment exists.

@Intelligent2013 the TC/WG information shown is incorrect.
This is the data encoded:
:technical-committee-type: SG
:technical-committee-number: SMART
:technical-committee: SMART
:subcommittee-type: SG
:subcommittee-number: TS
:subcommittee: Technical solutions sub-group
:workgroup-type: AG
:workgroup-number: 1
:workgroup: Terminology

It should show as "ISO/SG SMART/SG TS/AG 1". Does the XML not provide you with the full identifier? It should be encoded in the Semantic XML.

Does the XML not provide you with the full identifier?

Not yet, https://github.com/metanorma/metanorma-iso/issues/638

@ronaldtse I've updated ISO xslt for rendering

only if adoc contains note:
...
:local-cache-only:
:toc-figures: true
:toc-tables: true

[NOTE,notag=true,coverpage=true]
====
This document is circulated as received from the committee secretariat.
====

include::sections-en/00-foreword.adoc[]
...

(https://github.com/metanorma/metanorma-iso/issues/642#issuecomment-1127408991)

@Intelligent2013 I'm only seeing the cover page note only appear for DIS layout. It should appear at all stages except for a published document. Can you update?

Thanks @Intelligent2013 !

Confirm fixed. Closing.
Moving the approval committee to a separate ticket.


Fix editing polygon/polyline/circle in leaflet.draw 0.4.3

Retrieve latitude/longitude from call to getLatLngs() rather than accessing the private property _latlngs directly, since L.Geodesic maintains it's own property called .latlngsinit instead when it extends classes.

Thanks!


Selecting "Change Settings" does not display Session dialog

What steps will reproduce the problem?
1.Start a session from the Sessions box
2.Right click on the session tab
3.Select "Change Settings"

What is the expected output? What do you see instead?
I should get a dialog showing the Session Dialog for the session tab so I can
turn on/off logging to my desktop.

Instead I never get the session dialog so I cannot make any changes to the
session. This works fine if I start the session through a single Putty Session
prior to using SuperPutty.

I upgraded my SuperPutty app to <IP_ADDRESS> beta and it did not help.

I asked others in my team and they were having the same problem.

I turned on the log viewer and it displays the following when I select "Change
Settings"

2012-08-22 16:04:25,988 INFO      Log4netLogViewer - Viewer Ready
2012-08-22 16:04:26,030 DEBUG           SuperPuTTY - STATUS: Showing Log Viewer
2012-08-22 16:04:31,830 DEBUG        ctlPuttyPanel - Sending Putty Command:
menu=Change Settings, tag=0x0050, command=80
2012-08-22 16:04:31,831 INFO      ApplicationPanel - [4065264] ReFocusPuTTY -
puttyTab=pmacU17-1 xxx.xxx.xxx.xxx, caller=MenuHandler
2012-08-22 16:04:40,579 DEBUG        frmSuperPutty - [38407120] Activated

What version of the product are you using? On what operating system?
I was using <IP_ADDRESS> and now am using <IP_ADDRESS> on Windows 7 Enterprise.

Please provide any additional information below.
I have not tried this on XP. Not sure if that will make a diff.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 22 Aug 2012 at 8:06

Closing this issue but all hope is not lost! We still want to help.
See: https://github.com/jimradford/superputty/wiki/Legacy-Imported-Issues on how to help us to help you!


actions - Update java support and update maven to 3.8.1

Coverage remained the same at 100.0% when pulling e11187ca3b3618e8cf1b2ecc64c596e91ba1ca94 on hazendaz:master into 76fdfc59ac85741641a72553bb47ee9dbe64f1a7 on mybatis:master.


Improve gopass audit UX

This PR improves output of the gopass audit command and improves handling on invalid entires.

Heads up: vendoring for new deps is missing.
As a sidenote: personally I had such a bad experience with pb in the past (it might have improved by now), I ended up writing my own (imo slightly saner solution) here: https://github.com/muesli/goprogressbar
You may or may not be interested in it, if pb does the job as you wanted it, I'd also be happy ;-)

Good ideas @muesli . Feel free to put those in another PR if you like. I just picked pb because I've used it in the past and it worked. But if you think your lib is considerably better, I'd be OK with replacing pb.
If you integrate the length check in crunchy we can drop the check here. I did some tests with some of my stores and stumbled upon audit being very slow with big/huge secrets

@dominikschulz I'll add that extra check in crunchy. The WagnerFischer algorithm it uses becomes very slow if the strings you compare start diverging in length too heavily. Once the entropy / length becomes great enough, a password is fairly secure by definition, anyway.
That being said, when it comes to an audit command, I will always prefer accuracy over speed.


Nested Navigator  - swipe back to popToTop()

Hi all, I'm not sure if this is possible or not but I'm trying to swipe back to popToTop() when I'm inside the nested navigator. Is this possible? I know I can set a button to close the nested navigator, but I'm stuck on the swipe back gesture.
Preferably if the index is at 0 in the route stack and you swipe back it will close the navigator.

I figured this out. :)
Set the nested scene config to act as a modal:
sceneConfig: Navigator.SceneConfigs.FloatFromBottom

That way I can dismiss simply by swiping down.


fix: don't break with multiple specs, add ARTIFACT_NAME option

In v2.11.0, actions/upload-artifact was updated to v4 which started to cause issues in the WebExtensions Community Group repository. In particular, v4 requires each invocation to have a unique artifact name (this was a breaking change) and that does not hold true when using spec-prod since there is no way to configure the name.
Configuration / Example failure
To resolve this, add a new input option to allow the name to be changed. After playing around for a bit this seemed like the simplest solution that would work for everyone :)

Preview | Diff

@oliverdunk Can you also verify it works fine by using it in a PR (perhaps for https://github.com/w3c/webextensions/issues/596) before I merge this PR?
You'd need to replace uses: w3c/spec-prod@v2 with uses: oliverdunk/spec-prod@artifact-matrix-fix

This is great @oliverdunk! Can you also add docs to docs/options.md, perhaps at the end of document?

Good call, done! I added it in the middle to be consistent with the ordering in the YML but feel free to move.

Can you also verify it works fine by using it in a PR (perhaps for w3c/webextensions#596) before I merge this PR?

I tested it here which is hopefully a good enough dry run: https://github.com/oliverdunk/webextensions/actions/runs/8706490856/job/23879164260
If you'd really like to see it run in the main repository, let me know and happy to do that.

Brilliant! That dry run is more than enough. Thanks for the PR @oliverdunk!


Having constants that follows the java naming conventions

@EsterDanielYtterbrink pointed out today that we did show code in our learning hour that had warnings from SonarQube noted in our IDE.
This is because we were using the code unchanged and the two variables could be constants and also the existing variable name does not match the java naming conventions.
Just copied the code as it already was done at https://github.com/emilybache/TirePressure-Kata/blob/88f76769ff9f42282154f20c8395a13d70404a23/java/src/main/java/org/example/Alarm.java#L5C1-L6C62

Thankyou!


Enable FUSE module

Hi,
It looks like with the latest release v18.09.0 the fuse kernel module is no longer compiled. Fuse was available in the previous release.
Do you plan on enabling it again?
Thanks

This got added back in https://github.com/boot2docker/boot2docker/pull/1350. :+1:

See https://github.com/boot2docker/boot2docker/releases/tag/v18.09.1-beta1 and https://github.com/boot2docker/boot2docker/releases/tag/v18.09.1-beta2 (which include this fix). :+1:


Subscription Management

[x] List of all streams
[x] Can Unsubscribe From a Stream
[x] Can Subscribe To a Stream

Is this resolved via https://github.com/zulip/zulip-mobile/pull/253?

Yep. Closing.


Feat compile with cmake

@henrique-jung-isi another note, please add CMake also to the example. So people can run it also using CMake! Thanks

@henrique-jung-isi another note, please add CMake also to the example. So people can run it also using CMake! Thanks

done


Explain Plan display issue with Mariadb

System information:

Linux 5.0.0-25-generic #26~18.04.1-Ubuntu  x86_64 x86_64 x86_64 GNU/Linux
DBeaver Version <IP_ADDRESS>908191349
No additional extensions

Connection specification:

Mariadb 10.3.16
MariaDB
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
Explain plan is not correctly displayed. Only 3 columns are displayed.
Steps to reproduce, if exist:
Do an explain plan
Include any warning/errors/backtraces from the logs

I can't reproduce this. Could you post a screenshot?

Yes of course :
Normal result with a previous version of MariaDB:

With a recent version:

is it still actual?
it isn't reproducible for me on 6.3.0

there is no update on ticket more than a month.
Ticket closed.
If issue still actual for you - feel free to reopen the ticket


refactor(types): use ? sign in object instead of union with undefined

Change object fields with | undefined to ? ones. Inspired by #106.

The use of | undefined is intentional. The value can be undefined but the key must be present to keep the objects monomorphic.


yield and release are not declared in modified soures

solution: use  -Wno-implicit-function-declaration for gcc

https://github.com/ftsrg/ConcurrentWitness2Test/commit/444f023543979be6b14377c09e300133623b7e89


fix(fastly) provide service version and other contextual information

Description
Provide additional contextual details in the context parameter passed to the main function for services running in Fastly Compute@Edge.
The following fields (which were previously null) are now set:

context.func.name: the service ID
context.func.fqn: A globally unique function identifier which includes the service ID and version
context.func.version: the fastly service version - typically a whole number that automatically increases with every deploy
context.invocation.requestId: An ID uniquely associated with the current request
context.invocation.transactionId: The x-transaction-id header from the request or otherwise a unique ID associated with the current request.
context.runtime.region: The region as 3-letter point-of-present code where the service is executed, see here for codes: https://developer.fastly.com/learning/concepts/pop

Usage example:
module.exports.main = async function main(req, context) {
  return new Response(`Executed in version: ${context?.func?.version}
      Region: ${context?.runtime?.region}
      Func Name: ${context?.func?.name}
      Func FQN: ${context?.func?.fqn}
      TxID: ${context?.invocation?.transactionId}
      ReqID: ${context?.invocation?.requestId}`);
}

Related Issue
Fixes: #598
Motivation and Context
It allows to determine with certainty what version of the function is being invoked (sometimes an update can take a while) and provides additional information which can be useful for tracing and debugging.
How Has This Been Tested?
A new unit test has been added: fastly-adapter.test.js.
Types of changes
As the fields for this information were there but not filled in I consider this a bug fix.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

The circleci build fails becaused my user ID is not authorized 😢

@bosschaert I've triggered the CI build for you, but it looks like there are related and unrelated errors https://app.circleci.com/pipelines/github/adobe/helix-deploy/2240/workflows/514221ab-11af-4d69-aec6-fac50490c6a5/jobs/2190


No error when index not found

By accident I tried to copy an index that didn't exist and exporter.js did say nothing:
[root@salttestvm70 Elasticsearch-Exporter]# node exporter.js -th localhost -si logstash-2015.10.11 -sh other-host
Elasticsearch Exporter - Version 2.0.0
Mapping on target database is now ready
Starting data export
Fetched Entries:	0 documents
Processed Entries:	0 documents
Source DB Size:		0 documents

To be fair, it did say that no documents were exported. Now it prints a message in red warning when no documents have been found (for whatever reason).


How to recover a Longhorn RWX volume with corrupted filesystem

Hello,
I currently have a Longhorn RWX volume with corrupted filesystem. From the logs of the share-manager-pvc-xxxx of this RWX volume, I can see errors like the following:
level=fatal msg="Error running start command: 'fsck' found errors on device /dev/longhorn/pvc-xxxx but could not correct them: fsck from util-linux 2.34\n/dev/longhorn/pvc-xxxx contains a file system with errors, check  forced.\n/dev/longhorn/pvc-xxxx: Resize inode not valid. \n\n/dev/longhorn/pvc-xxxx: UNEXPECTED  INCONSISTENCY; RUN fsck MANUALLY.\n\t(i.e., without -a or -p options)\n"
In the past I also ran into this same issue with other Longhorn RWO volumes but was able to resolve the issue by following this procedure: https://longhorn.io/kb/troubleshooting-volume-filesystem-corruption/#solution.
However, I have a difficulty today while attempting to manually attach a Longhorn RWX volume to a node in the cluster and run fsck to fix its filesystem. I'm currently using Longhorn version 1.2.2. When I tried to attach a RWX volume from the Longhorn web UI, I only see this option:
"RWX volumes can only be manually attached in maintenance mode."
If not quite sure what the maintenance mode really is. Before attempted to manually attach a RWX volume to a specific node, I did check and make sure nothing else was currently using this volume. When I tried to do so, it appears the web ui does allow me to attach the RWX volume to a specific host in the cluster. However, I notice there was NO such /dev/longhorn/pvc-xxxx device created on the host although the web UI indicates the RWX volume was currently being attached to such host.
In short, does anyone know how to manually attach a RWX volume to a specific node OR a procedure for recovering a Longhorn RWX volume  with corrupted filesystem?
Thank you in advance for your help and support!

@joshimoo , @PhanLe1010 , any ideas?

From @joshimoo, ref https://cloud-native.slack.com/archives/CNVPEL9U3/p1664931258378449?thread_ts=1664543756.230919&cid=CNVPEL9U3
In this case the easiest approach is to change the access mode on the longhorn volume from RWX to RWO temporarily, that way you can manually attach the volume.
This should be doable via the longhorn UI, there is no need to change the PVC/PV or anything else just the volume access mode.


Services managed by service-manager are not terminated by appscale down.

For datastore servers, it should be happening here: https://github.com/AppScale/appscale/blob/8128e620514d40624c7147812d9caea3a950227d/AppController/terminate.rb#L39-L51

Thank you. I missed it somehow. But I believe I could see persistent behavior and datastore was not terminated on down.
I'll do additional testing. And for sure I need to add such termination command for search service.


[SPARK-27237][SS] Introduce State schema validation among query restart

What changes were proposed in this pull request?
Please refer the description of SPARK-27237 to see rationalization of this patch.
This patch proposes to introduce state schema validation, via storing key schema and value schema to schema file (for the first time) and verify new key schema and value schema for state are compatible with existing one. To be clear for definition of "compatible", state schema is "compatible" when number of fields are same and data type for each field is same - Spark has been allowing rename of field.
This patch will prevent query run which has incompatible state schema, which would reduce the chance to get indeterministic behavior (actually renaming of field is also the smell of semantically incompatible, but end users could just modify its name so we can't say) as well as providing more informative error message.
How was this patch tested?
Added UTs.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #103793 has started for PR 24173 at commit d3ba4ef.

For now, the verification is done per partition. That sounds really weird, but if we want to do it only once for all partitions, we should modify code (maybe some interfaces too, and even maybe DSv2?) to let stateful operators report the states with its key/value schema.
So this approach is less optimized and less intuitive, but also pretty less intrusive, doesn't touch the current contract and will work well with custom state store providers.

Test build #103796 has started for PR 24173 at commit a638903.

cc. @tdas @zsxwing @jose-torres @arunmahadevan @gaborgsomogyi

Test build #103793 has finished for PR 24173 at commit d3ba4ef.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103793/
Test FAILed.

Test build #103796 has finished for PR 24173 at commit a638903.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103796/
Test PASSed.

I think it's good to add such check in general. Without too deep code line parsing I would ask:

Does this cover parameter optional/required changes?
Just wondering whether an opt-out param not needed?

but if we want to do it only once for all partitions, we should modify code (maybe some interfaces too, and even maybe DSv2?)

Do you have what exactly has to be modified? Storing things in a redundant way is rarely a good choice (not considering heavy constraints). Number of partitions may change over time.

Does this cover parameter optional/required changes?

The schemas are exactly same as how states are stored, so there's no optional thing. If you meant nullable the code includes it in comparison.

Just wondering whether an opt-out param not needed?

I'm not sure what you meant. If you meant toggling this option, I guess that's not necessary. Preventing query to be run would be always better than exposing possibility to get indeterministic behaviors.

Do you have what exactly has to be modified?

The schema of state is determined in stateful operator, or even in state implementation (please refer implementation of state in symmetric join) which we don't have any contract/interface for that. Moreover, if we want to deal with state schema at only one place, that should be done in driver side, whereas states are being initialized in executor side which would require additional work/trick to get the information from driver side.

Number of partitions may change over time.

For state, Spark disallows changing the number of partitions - that's why Spark retains spark.sql.shuffle.partitions when query is running for the first time, and ignore new values.

I'm not sure what you meant.

Yeah, some config which is on by default.

I'm not sure what you meant. If you meant toggling this option, I guess that's not necessary. Preventing query to be run would be always better than exposing possibility to get indeterministic behaviors.

Don't let the query start by default is good in such cases, but not having a plan B for cases what we've maybe missed is different.
After the deeper look I see the nullable stuff...

if we want to deal with state schema at only one place, that should be done in driver side, whereas states are being initialized in executor side which would require additional work/trick to get the information from driver side.

Now I see that part and it's really not easy. I don't have suggestion out of the box, let me think a bit...

not having a plan B for cases what we've maybe missed is different.

Got it. So the bug in checking schema compatibility would be a show-stopper and we want to have plan B. Makes sense. Will address.

Seems like there is an issue with jenkins, written a mail to dev list...

Test build #103825 has started for PR 24173 at commit fe71145.

Test build #103825 has finished for PR 24173 at commit fe71145.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103825/
Test FAILed.

Test build #103832 has started for PR 24173 at commit 36f2d9e.

Test build #103832 has finished for PR 24173 at commit 36f2d9e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103832/
Test PASSed.

Related driver side schema check don't have a solution which is clean enough to put it into the code. Maybe someone has a good idea.

Test build #103963 has started for PR 24173 at commit 8823005.

Looks good, except I would ping someone and ask for opinion in the per partition schema check topic.

Test build #103963 has finished for PR 24173 at commit 8823005.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103963/
Test PASSed.

Kindly asking for reviewing from committers.

Ping again, as Spark+AI Summit 2019 in SF is end.

Test build #107118 has started for PR 24173 at commit e98de6c.

Test build #107118 has finished for PR 24173 at commit e98de6c.

This patch fails R style tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
case class StateSchemaNotCompatible(message: String) extends Exception(message)

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107118/
Test FAILed.

I happen to revisit this, and succeed to change the approach to check schema only once per each stateful operator. The new approach is centralizing request to driver side, via RPC. Both executor and driver would cache the providerId with partition id erased, so requests would be minimized.
@gaborgsomogyi Could you review the last change? I guess you've also lost context so need time to rebuild. Thanks for the support!

Test build #107120 has started for PR 24173 at commit b0e9566.

Test build #107121 has started for PR 24173 at commit c783f04.

Test build #107120 has finished for PR 24173 at commit b0e9566.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class StateSchemaNotCompatible(message: String) extends Exception(message)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107120/
Test FAILed.

Test build #107121 has finished for PR 24173 at commit c783f04.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107121/
Test FAILed.

Test build #107142 has started for PR 24173 at commit 6497450.

Test build #107142 has finished for PR 24173 at commit 6497450.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107142/
Test PASSed.

@tdas @zsxwing @jose-torres @gaborgsomogyi Kindly reminder.

Ping.

Can one of the admins verify this patch?

ok to test

Test build #110687 has started for PR 24173 at commit 6497450.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15849/
Test PASSed.

Test build #110687 has finished for PR 24173 at commit 6497450.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110687/
Test FAILed.

Test build #110709 has started for PR 24173 at commit 7a5ff4d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15867/
Test PASSed.

Test build #110709 has finished for PR 24173 at commit 7a5ff4d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StateSchemaCompatibilityCheckerSuite extends SharedSparkSession

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110709/
Test PASSed.

@tdas @zsxwing @jose-torres @gaborgsomogyi Kindly reminder.

Test build #115795 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20588/
Test PASSed.

Test build #115795 has finished for PR 24173 at commit 1fcfff5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115795/
Test FAILed.

retest this, please

Test build #115801 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20594/
Test PASSed.

Test build #115801 has finished for PR 24173 at commit 1fcfff5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115801/
Test PASSed.

retest this, please

Test build #116590 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21372/
Test PASSed.

Test build #116590 has finished for PR 24173 at commit 1fcfff5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116590/
Test PASSed.

retest this, please

Test build #120257 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24970/
Test PASSed.

Test build #120257 has finished for PR 24173 at commit 1fcfff5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120257/
Test FAILed.

retest this, please

Test build #120612 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25316/
Test PASSed.

Test build #120612 has finished for PR 24173 at commit 1fcfff5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120612/
Test PASSed.

retest this, please

Test build #121236 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25923/
Test PASSed.

Test build #121236 has finished for PR 24173 at commit 1fcfff5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121236/
Test FAILed.

retest this, please

Test build #121246 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25933/
Test PASSed.

Test build #121246 has finished for PR 24173 at commit 1fcfff5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121246/
Test FAILed.

retest this, please

Test build #121306 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25990/
Test PASSed.

Test build #121306 has finished for PR 24173 at commit 1fcfff5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121306/
Test PASSed.

retest this, please

Test build #122136 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26808/
Test PASSed.

Test build #122136 has finished for PR 24173 at commit 1fcfff5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122136/
Test FAILed.

retest this, please

Test build #122152 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26823/
Test PASSed.

Test build #122152 has finished for PR 24173 at commit 1fcfff5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122152/
Test PASSed.

retest this, please

Test build #123146 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27778/
Test PASSed.

Test build #123146 has finished for PR 24173 at commit 1fcfff5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123146/
Test FAILed.

retest this, please

Test build #123164 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27793/
Test PASSed.

Test build #123164 has finished for PR 24173 at commit 1fcfff5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123164/
Test FAILed.

retest this, please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27803/
Test FAILed.

Test build #123175 has started for PR 24173 at commit 1fcfff5.

Test build #123175 has finished for PR 24173 at commit 1fcfff5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123175/
Test PASSed.

retest this, please

Test build #123993 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28615/
Test PASSed.

Test build #123993 has finished for PR 24173 at commit 1fcfff5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123993/
Test FAILed.

retest this, please

Test build #124004 has started for PR 24173 at commit 1fcfff5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28625/
Test PASSed.

Test build #124004 has finished for PR 24173 at commit 1fcfff5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124004/
Test PASSed.

Merged build finished. Test PASSed.

Test build #124479 has started for PR 24173 at commit 04c611b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29099/
Test PASSed.

Test build #124479 has finished for PR 24173 at commit 04c611b.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class StateSchemaNotCompatible(message: String) extends Exception(message)
class StateSchemaCompatibilityChecker(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124479/
Test FAILed.

Test build #124483 has started for PR 24173 at commit 3b968f7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29103/
Test PASSed.

Test build #124483 has finished for PR 24173 at commit 3b968f7.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class StateSchemaNotCompatible(message: String) extends Exception(message)
class StateSchemaCompatibilityChecker(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124483/
Test PASSed.

retest this, please

Test build #125733 has started for PR 24173 at commit 3b968f7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30344/
Test PASSed.

Test build #125733 has finished for PR 24173 at commit 3b968f7.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class StateSchemaNotCompatible(message: String) extends Exception(message)
class StateSchemaCompatibilityChecker(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125733/
Test PASSed.

Sorry for the late, I'll review this one in this week. I think it's the other necessary guard for state store format together with #28707.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31158/
Test PASSed.

Test build #126540 has started for PR 24173 at commit d5ab0cf.

Test build #126540 has finished for PR 24173 at commit d5ab0cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126540/
Test PASSed.

retest this, please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32160/
Test PASSed.

Test build #127539 has started for PR 24173 at commit d5ab0cf.

Test build #127539 has finished for PR 24173 at commit d5ab0cf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127539/
Test FAILed.

Merged build finished. Test FAILed.

retest this, please

Test build #127554 has started for PR 24173 at commit d5ab0cf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32177/
Test PASSed.

Test build #127554 has finished for PR 24173 at commit d5ab0cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127554/
Test PASSed.

retest this, please

Test build #128681 has started for PR 24173 at commit d5ab0cf.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33306/
Test PASSed.

Test build #128681 has finished for PR 24173 at commit d5ab0cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128681/
Test PASSed.

cc. @tdas @zsxwing @viirya @gaborgsomogyi @xuanyuanking

retest this, please

Test build #130223 has started for PR 24173 at commit d5ab0cf.

Test build #130225 has started for PR 24173 at commit d5ab0cf.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34824/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34824/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34824/
Test PASSed.

Test build #130223 has finished for PR 24173 at commit d5ab0cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130223/
Test PASSed.

Test build #130225 has finished for PR 24173 at commit d5ab0cf.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130225/
Test FAILed.

Test build #130273 has started for PR 24173 at commit fc9049e.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34873/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34873/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34873/
Test PASSed.

Test build #130273 has finished for PR 24173 at commit fc9049e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class StateSchemaNotCompatible(message: String) extends Exception(message)
class StateSchemaCompatibilityChecker(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130273/
Test PASSed.

+1 for me. The only small concern left is https://github.com/apache/spark/pull/24173#discussion_r460363409. Also cc @cloud-fan for taking a look.

+1 for me. The only small concern left is https://github.com/apache/spark/pull/24173#discussion_r460363409. Also cc @cloud-fan for taking a look.

Test build #130478 has started for PR 24173 at commit 4dd6fc3.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35082/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35082/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35082/
Test PASSed.

Test build #130478 has finished for PR 24173 at commit 4dd6fc3.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class StateSchemaNotCompatible(message: String) extends Exception(message)
class StateSchemaCompatibilityChecker(

Merged build finished. Test PASSed.


dict key type validation

Would it be possible to also add validation of key type in dict (={key:val}), please?
I am missing this functionality as almost all validators work along jsonschema principles. There (by definition) is every key string. But not so in YAML (https://yaml.org/spec/1.2/spec.html#id2764196)... The key itself could be almost everything (unique).
(If I am missing something obvious in yamale docs, excuse me in advance.)

Hi, thanks for your interest in Yamale!
Can you describe your use case? Perhaps there's a way to achieve what you need without using a non-scalar key.

I need to have URI as an key. I want to enforce some protocols (thus valiadate the key).
Consider e.g. cache.yaml (!Data in PyYAML stand for "map into object with key !Data"):
"file:///home/u/myfile.dat" : !Data {"size": 56, "original_url": "file:///home/u/myfile.dat"} "https://github.com/23andMe/Yamale/issues/53" : !Data {"size": 12345, "original_url": "https://github.com/23andMe/Yamale/issues/53"}
As you can notice I use that URI key as an "uniqness constraint" over the dict of objects (which contains the key as internal attribute).

Just to be sure I understand, you have a yaml with keys as strings and a custom data class as values. And you want the schema to validate that the original_url attribute in the data class matches the key of the data class in the yaml?
If that's the case, how much control do you have with this YAML? My suggestion would be to rewrite the file like this:
"file:///home/u/myfile.dat" : {"size": 56}
"https://github.com/123" : {"size": 12345}

If you can avoid custom constructors in your YAML, it'll be a lot more portable in the future.

Only I want from Yamale is to (1) allow dot (.) in string key + (2) check the correctness of URI in that string in regexp way (= it contains "://" somewhere, only allowed char from system charset, etc.).
I do not want Yamale to check the same value of inner attribute and object key at all.
Maybe your way of writing the data is a bit more efficient, but I need transparent and direct mapping from python in-memory objects to YAML with as little code as possible. In RAM this is the only efficient model.

Thanks for the additional explanation. Off the top of my head, this may be supported by adding a key constraint to the map validator to do something like this:
map(map(str(), int()), key=regex('.*://.*'))

We do accept pull requests. If you'd like to tackle this, we'll work with you to add this functionality. But, honestly, it'll take us a while to get to this feature request.

I assume the first challenge is escaping plague of "concatenate the keys with . to generate 'path' to the value". While it seems good idea alike XPath (exchange "." and "/"), it is generally not. At least in YAML world, where the mapping key can be string with dots inside or even number or whatever.
Maybe changing the concatenation of strings with "." to concatenation of anything into list would fix the most crucial part.
Maybe after th

That work is already being done here: #60


Re-work deleting of hooks

Since now a webhook is placed on both repos, we need to rethink how to delete webhooks.

Fixed by https://github.com/backstrokeapp/server/issues/66. No more new webhooks are made on github repos!


Enhancement: suggest set when testing membership of a list or tuple

Suggest a set when checking membership of a list/tuple of hashable values.
eg:
if fruit in {"orange", "apple"}:

rather than
if fruit in ("orange", "apple"):

or
if fruit in ["orange", "apple"]:

See also https://docs.sourcery.ai/Reference/Python/Default-Rules/collection-into-set/

Could also suggest calling set on an iterable before checking membership?
e.g.
for foo in iterable_of_foos:
    if foo in bar_iterable:
        do_something(foo)

->
bar_set = set(bar_iterable)
for foo in iterable_of_foos:
    if foo in bar_set:
        do_something(foo)

@tekumara that’s already an optional checker ini pylint: Set Membership checker.

Oh right I don't use pylint so wasn't aware it had this check. If possible, it would still be nice for perflint to include this so all the performance related checks are together?

Oh right thank you, I don't use pylint so wasn't aware it had this check. If possible, could perflint include this too so all the performance related checks are together?

@tekumara have you also looked at ruff’s performance lint implementation here?

oh yes! I'm using ruff rather than pylint or perflint directly 🙂
I thought to raise the issue here, as this is the upstream. Once implemented here, I'd hope ruff would implement it too.

Well, I think @tonybaloney can find inspiration in pylint’s set_membership.py module.
Although, looking at the inactivity of this repo over the past months I do worry that this package is getting stale… 🤔

Well, I think @tonybaloney can find inspiration in pylint’s set_membership.py module.
Although, looking at the inactivity of this repo over the past months I do worry that this package is getting stale… 🤔

Sorry. I'm on a long overdue break. This is on my list for next week

@tonybaloney oh that’s great to know 👍🏼  Enjoy your break!

perflint is a plugin to pylint so you can run both together. I don't want to duplicate rules that already exist in pylint

https://pylint.pycqa.org/en/latest/user_guide/messages/refactor/use-set-for-membership.html closing. thanks for the idea


Add highlights for floating windows

This is a simple change to style the border and background of a floating window. Without these highlight groups, Neovim falls back to using VertSplit (black) which makes it hard to see the floating window.

Thanks for the PR.


Adds DaskDataFrameResultBuilder

Adds a DaskDataFrameResultBuilder to help make it
clearer what's going on if someone wants to bring in dask to scale to larger datasets.
This also tidies up the dask hello world by introducing more run_* files. Since there are now effectively three ways you can use dask:

compute out non dask stuff via delayed
use dask datatypes
use both together

So I try to make it clear what is going on when you're using dask.delayed versus changing the inputs to be
dask dataframes/series.
Changes

h_dask -- augments the GraphAdapter, and adds DaskDataFrameResultBuilder.
dask hello world examples

How I tested this

locally

Notes

TODO: add tests.
TODO: update docs.

Checklist

[ ] PR has an informative and human-readable title (this will be pulled into the release notes)
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future TODOs are captured in comments
[ ] Project documentation has been updated if adding/changing functionality.

This information would be useful to debug

what are the datatypes of your dataframe?
do you know what is causing the memory to increase?
can you run the pandas version with the logging.basicConfig(stream=sys.stdout, level=logging.DEBUG) set? It should tell you at what function things die during computation: e.g. search for Computing XXXX.

What I think you should try:

Upgrade to pandas 2+
Turn on the pyarrow backend to read data

with pandas try https://pandas.pydata.org/docs/user_guide/pyarrow.html#i-o-reading

are you using strings? (assume pandas 2+)

with dask https://www.coiled.io/blog/pyarrow-strings-in-dask-dataframes

Install this branch and don't use delayed and use the dask dataframe result builder (see run.py)

pip install  git+https://github.com/dagworks-inc/hamilton.git@dask_additions
try what's shown in run.py -- add dask.config.set({"dataframe.convert-string": True})


Write instructions on how to update the bundles and use your own classifier.

The README should have a section describing how to add/remove/update bundles. It should also list the steps to manually set a classifier and prevent the demo from deleting it.

Should the app itself have an easy way to get this (like a link to click and show the classifier id?  or maybe an env var that prevents classifier deletion)?

make sense.


Multiple Search Selection, select undesired item

Hi,
I have noticed such strange and I assume invalid behaviour.
Using your example here http://semantic-ui.com/modules/dropdown.html under "Multiple Search Selection". If I select some item and then click "tab" or select any other control on the page, one more item is getting selected in the dropdown. If it is an expected behaviour, can you please let me know, how it can be avoided. Thanks!

I have it as well. You can see it in the docs for Multiple Search Selection.

Click on the input
Click on a menu item
Click somewhere else

An additional item is selected on 3.

It can be avoided if you do not click on the dropdown and select, but type, search and select by Enter. But anyway it seems to be a bug.

I thinks that the setting forceSelection should be false by default

I have the same problem and I have created a minimal jsfiddle for the developers to reproduce the problem: https://jsfiddle.net/tzj26adt/
The bug is somewhere between 2.2.2 and 2.2.3.

+1

+1

+1

http://semantic-ui.com/modules/dropdown.html#/settings
Set forceSelection:false and viola!

@jlukic, this can be closed too in my opinion.

Cheers

THANKS GUYS. I had the same issues but your comments helped resolved it. I am really in love with Semantic UI.
From Nigeria.

Hi @jlukic @vinayakkulkarni @Banandrew , just a heads-up .. this problem persists if the dropdown is multiple, forceSelection has no effect (2.2.10)
Thanks for a killer framework  #Loveit!

@shadoWalker89 Thanks a lot! I spent half an hour trying to figure out where my bug was and boom! Fixed!


Allow specifying environment variables in Exec Task

The Exec Task currently doesn't allow specifying environment variables which would be set for the to invoked process.
Example use case
The SDK currently defines a Run target which is used by VS to F5 an application. The properties used in the Run target are RunCommand, RunArguments and RunWorkingDirectory: https://github.com/dotnet/sdk/blob/3ed908ee77c592bae787ac78f466c3bc0581970a/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets#L757.
If the Exec Task would allow specifying environment variables we could add a RunEnvironmentVariables property which would remove the need for an extra launchSettings.json file: https://github.com/dotnet/runtime/blob/817ebcaeb617813f98650e78c14e76bbd8b733b0/eng/testing/launchSettings.json#L14-L16.
Other references

http://blog.jdhardy.ca/2011/12/setting-environment-variables-for.html
https://www.develop-bugs.com/article/21515881/Use+path+system+environment+variable+in+MSBuild+exec+task

cc @rainersigwald

Exec does support this.
Example from the Mac I'm on right now:
<Project>
  <Target Name="Exec">
    <Exec Command="env | grep FOO"
          EnvironmentVariables="FOO=bar" />
  </Target>
</Project>

$ echo $FOO

$ dotnet msbuild exec-env.proj
Microsoft (R) Build Engine version 16.5.0+d4cbfca49 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  FOO=bar

@ghogen, I suspect this is an example of the ToolTask-derived task docs not being sufficiently clear that they expose the ToolTask parameters. We have a link in each of them pointing to the base class, but is there a way to define a central snippet that could be included in each doc page?

OK I forgot to look into ToolTask... I would definitely add an outline to the docs page: https://docs.microsoft.com/en-us/visualstudio/msbuild/exec-task?view=vs-2019

@rainersigwald Yes we can write a separate code snippet and reference it from each article.
https://review.docs.microsoft.com/en-us/help/contribute/code-in-docs?branch=master#in-repo-snippet-references
We use an older outdated syntax in our docs though: see msbuild/build-loggers.md for examples
[!code-csharpmsbuild_SimpleConsoleLogger#2]
If you have the code, I can set this up.

@ghogen close, I think what we want is https://review.docs.microsoft.com/en-us/help/contribute/includes-best-practices?branch=master to include a table of the ToolTask arguments.
Let me throw a draft of that together.

https://github.com/MicrosoftDocs/visualstudio-docs/pull/5175

@ViktorHofer fyi: https://docs.microsoft.com/en-us/visualstudio/msbuild/exec-task?view=vs-2019#tooltaskextension-parameters is now there.

This is super helpful, thanks a lot Rainer 👍

This may be obvious to most, but in case it isn't and you find yourself here by googling this like I did.. if you need to specify multiple environment variables to an Exec command, separating them with a semicolon seems to do the trick.

@hairlesshobo would MicrosoftDocs/visualstudio-docs#5783 help?


How can i extend "field" types?

For example, i want to auto-mask phone numbers like +0<PHONE_NUMBER>. Or in my case i need show dates like dd.mm.YY but if it's closest dates i need to show (yesterday, today, tomorrow) and it's must work with sorting like:
(today + 3 days)
(today + 2 days)
Tomorrow
Tomorrow
Today
(today - 2 days)

@Hellek 'field' property takes a function which is supplied rowObject as a parameter so you can do something like
  {
    field: fieldFn
  }

  // in methods
  fieldFn(rowObj) {
    // do something with the row object
  }

you can use your custom method to do what you want. I'm going to close this for now, comment back if this doesn't solve your problem and i'll re-open it.


Change of integer type

It is a proposition of @FauconFan :
There is some language where char, short, int and long primitive variables are not defined to have respectively 8, 16, 32 and 64 bits (such as in C for int).
So we can introduce :

int8
int16
int32
int64

to replace this language restriction.
And add 'u' before them to have an unsigned value.

Refer #19
Otherwise, it's a godd idea for me


update Options in docs

this option is broken and was taken out into fixed

this feature is disabled because its broken


46+47+48

WIP for #46
Fixes #47 and #48

Thank you for the PR. Good to see you're still using it.

Let me look over the cfn-eco.json before merging. There's a lot of duplication between that and the main template and we may be able to get around that by using nested parameterized templates.

@kevinoriordan

There's a lot of duplication between
Yeah, it's WIP, I tried to put eco-mode into main template but it's a bit tricky so I leave it as reduced copy at the moment, also there should be added scripts in launch configuration to create record set for sundial service instance id which I not added yet.


Apps using the outdated android sdk com.segment.analytics.android:analytics 4.94 can no longer be uploaded after August 9, 2022

This outdated sdk is used by the expo bundled package https://www.npmjs.com/package/expo-analytics-segment which will be removed in expo 46.

@brandon-PG is this related to #1854


scalar Time changed behaviour.

Thank you for a nice piece of software. I started looking into custom scalars recently and noticed that the included custom graphql.Time type does not work as it did earlier. Has there been changes that I can't find documentation for?
Before f7d9ff4e09a02f4b09800eaf3604a36df90514e6 everything worked fine. I could send in both the Unix timestamp and the string-version. At this commit it started answering "wrong type" on requests. The test still works but I can't seem to use it in my application.
At 95a4ecd841312e27b542fb147295923832fdc7bc the error message changes. It returns Argument "from" has invalid value<PHONE_NUMBER>. Expected type "Time", found<PHONE_NUMBER>.
The tests also works fine here.
Do I need to implement the Time scalar myself nowadays? In what package would I place a custom type?

Check out the implementation of the Time scalar: https://github.com/neelance/graphql-go/blob/master/time.go
If that doesn't meet your needs, you can create one that does by following that example.

That is the one that I'm using. But I can only get it to work up to commit f7d9ff4. After that it breaks.

I now realize that I can return the custom scalar, but I am not able to use it as a filter or input:
{
  events {
    timestamp #works fine
  }
}

but this:
{
  events(from:123456789) {
    timestamp
  }
}

returns
"message": "Argument \"from\" has invalid value 123456789.\nExpected type \"Time\", found 123456789."

What does the events resolver look like?

Toy example that doesn't work:
package main

import (
	"io/ioutil"
	"log"
	"net/http"

	"time"

	graphql "github.com/neelance/graphql-go"
	"github.com/neelance/graphql-go/relay"
)

var schema *graphql.Schema

func init() {
	var err error
	b, err := ioutil.ReadFile("schema.graphql")
	if err != nil {
		panic(err)
	}
	schema = graphql.MustParseSchema(string(b), &resolver{})
}

func main() {
	http.Handle("/query", &relay.Handler{Schema: schema})

	log.Fatal(http.ListenAndServe(":4040", nil))
}

type resolver struct{}

func (r *resolver) Events(args *struct{ From *graphql.Time }) *eventResolver {
	return &eventResolver{}
}

type eventResolver struct{}

func (r *eventResolver) Timestamp() graphql.Time {
	return graphql.Time{Time: time.Now()}
}

and the schema:
# Presents a RFC3339. Accepts Unix timestamps & RFC3339
scalar Time

schema {
    query: RootQuery
}

type RootQuery {
    events(from: Time): Event
}

# Event based on an article
type Event {
    # The time of the article
    timestamp: Time!
}

I think I have hit a similar problem, the validator doesn't seem to make use of  ImplementsGraphQLType(name string) bool and UnmarshalGraphQL(input interface{}) error  to check if a scalar fits the schema.

Ran into same / similar issue. When you run a query with embedded time like this:
{
  events(from: "2017-05-06T13:22:33.000Z") {
    timestamp
  }
}

it fails the validation but if you use a variable;
{
  events(from: $from) {
    timestamp
  }
}

and supply
{
  "from": "2017-05-06T13:22:33.000Z"
}

it works just fine.

I can reproduce the issue as well, FWIW. Digging through the code to try and understand a fix.

I've been digging through the validation code and found there is a missing check to determine whether an argument literal is coercible to its corresponding argument definition type.
The specification defines this check as:

For each argument in the document

Let value be the Value of argument
If value is not a Variable

Let argumentName be the Name of argument.
Let argumentDefinition be the argument definition provided by the parent field or definition named argumentName.
Let type be the type expected by argumentDefinition.
The type of literalArgument must be coercible to type.

Given this specification, it seems like there should be a default case on this switch statement.
The default case then has the job of checking whether the argument literal can be coerced into the given type.
I think at the moment, the method does not have enough data to know whether a *lexer.Literal can be coerced into a common.Type. I'm not yet familiar enough with the project to know where such a lookup would exist (fingers crossed this gives @neelance an idea 😄 ).

@neelance Can you comment on @tonyghita's analysis, would love to help fix this but need some pointers


Add RBAC to fix orphaned SpaceRequests on staging

As requested on RHTAP Slack, there are a number of SpaceRequests that are orphaned in a couple of namespaces on RHTAP staging. This grants access to us to allow us to delete them.

/lgtm


[Question] How to construct a RNN training cluster with PaddlePaddle?

How to construct a RNN training cluster with PaddlePaddle? Any  build and install instruction?

please refer to http://www.paddlepaddle.org/doc/cluster/

@luotao1 Thanks a lot!


Add Benchmarking

Consider using [Amby[(https://hackage.haskell.org/package/amby) for visualization

Done!


Is there currently a way to use logit_bias with llama2 models?

In llama.cpp you can use logit bias to affect how likely specific tokens are, like this:
./main -m models/llama-2-7b.Q4_K_M.gguf -n 100 -p 'this is a prompt' --top-p 0.5 --top-k 3 --logit-bias 15043+1

Which would increase the likelihood of token 15043 by 1
It seems to have been mentioned a couple times in issues before and even seems like something was implemented, but I haven't been able to find any reference to "logit_bias" in the docs, and wasn't able to make much sense of bias.py
When I try to run this
llm = Llama(model_path="./models/llama-2-7b.Q2_K.gguf", logits_all=True)

biases = {"29991": -100, "1556": -100} # assume it's a dict

output = llm(my_prompt, max_tokens=100 ,temperature=0.8, logit_bias=my_biases)

It comes back with this error:
TypeError: Llama.__call__() got an unexpected keyword argument 'logit_bias'
Is this an available feature, and I'm just missing how to do it somehow?

@dschil138 it's actually supported in the server but not in the completion API yet, I'll add that!


Branch cleanup: cleaning up test-ceremony/** branches

Description
These branches are protected, so we don't have access to delete them yet. Investigate what to do about settings, particulary for test-* branches.

Allow deletions here? https://github.com/sigstore/community/blob/e319d18f5a773495c7e89c19a350e382814b241d/github-sync/github-data/repositories.yaml#LL1240C31-L1240C31

https://github.com/sigstore/community/pull/488


Make secure communication

make secure communication between Haaukins and Haaukins-store.

I think , it is done with this commit (https://github.com/aau-network-security/haaukins-store/commit/9bd01fe45a8315f22c0bdf6d168ff78e8c54ba5d) now there is a authentication between haaukins and haaukins-store.