HBASE-14067 bundle ruby files for hbase shell into a jar.

removes some cruft from the hbase-shell pom that appears to be from coping the hbase-server pom long ago
puts the ruby scripts into the hbase-shell jar following the guide from jruby for packaging
removes hard coding the location of the implementation scripts from our runtime
removes hard coding the load path for the implementation from the test code (leaves hard coding the test code location)
provides a work around for a name conflict between our shell and the ruby stdlib shell.

tested via unit tests:
mvn -Dit.test=NoItTest -Dtest=NoUnitTests install && mvn --no-snapshot-updates -PrunAllTests -pl hbase-shell package

and via making an assembly:
mvn --no-snapshot-updates -Dtest=NoUnitTests -Dit.test=NoItTests package assembly:single

then testing with a stand alone cluster and using the shell with it.

pushed an addendum after testing running the shell directly from a source build instead of a binary tarball. had a stale reference from when I was first testing running from source instead of build.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
checkstyle
1m 57s
master passed

+1 :green_heart:
spotbugs
8m 55s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

-0 :warning:
checkstyle
1m 55s
root: The patch generated 21 new + 0 unchanged - 0 fixed = 21 total (was 0)

-0 :warning:
rubocop
0m 59s
The patch generated 4 new + 1107 unchanged - 5 fixed = 1111 total (was 1112)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
17m  0s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
8m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 40s
The patch does not generate ASF License warnings.

57m 32s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
dupname asflicense shellcheck shelldocs rubocop xml hadoopcheck spotbugs hbaseanti checkstyle

uname
Linux 7246dc7e8d45 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bdcafa895c

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
137 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 11s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 46s
master passed

+1 :green_heart:
compile
3m 13s
master passed

+1 :green_heart:
shadedjars
7m 28s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 37s
the patch passed

+1 :green_heart:
compile
3m 11s
the patch passed

+1 :green_heart:
javac
3m 11s
the patch passed

+1 :green_heart:
shadedjars
7m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
234m 26s
root in the patch passed.

278m 12s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 008c8e023c27 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bdcafa895c

Default Java
2020-01-14

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/1/testReport/

Max. process+thread count
4489 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  2s
master passed

+1 :green_heart:
compile
2m 34s
master passed

+1 :green_heart:
shadedjars
7m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 47s
the patch passed

+1 :green_heart:
compile
2m 36s
the patch passed

+1 :green_heart:
javac
2m 36s
the patch passed

+1 :green_heart:
shadedjars
7m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
374m 53s
root in the patch passed.

411m 27s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3e8aeaa91358 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / bdcafa895c

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/1/testReport/

Max. process+thread count
3952 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 36s
master passed

+1 :green_heart:
checkstyle
1m 57s
master passed

+1 :green_heart:
spotbugs
8m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

-0 :warning:
checkstyle
1m 57s
root: The patch generated 21 new + 0 unchanged - 0 fixed = 21 total (was 0)

-0 :warning:
rubocop
1m  0s
The patch generated 4 new + 1107 unchanged - 5 fixed = 1111 total (was 1112)

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
17m  5s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
8m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 41s
The patch does not generate ASF License warnings.

56m 10s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
dupname asflicense shellcheck shelldocs rubocop xml hadoopcheck spotbugs hbaseanti checkstyle

uname
Linux c402ffef26e3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 78ae1f176d

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
137 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 20s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 33s
master passed

+1 :green_heart:
compile
3m 10s
master passed

+1 :green_heart:
shadedjars
7m 20s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 32s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 31s
the patch passed

+1 :green_heart:
compile
3m  6s
the patch passed

+1 :green_heart:
javac
3m  6s
the patch passed

+1 :green_heart:
shadedjars
7m 19s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 28s
the patch passed

_ Other Tests _

-1 :x:
unit
200m 51s
root in the patch failed.

241m 53s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0dca1f3bcab7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 78ae1f176d

Default Java
2020-01-14

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/testReport/

Max. process+thread count
3809 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 50s
master passed

+1 :green_heart:
compile
2m 34s
master passed

+1 :green_heart:
shadedjars
7m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 45s
the patch passed

+1 :green_heart:
compile
2m 36s
the patch passed

+1 :green_heart:
javac
2m 36s
the patch passed

+1 :green_heart:
shadedjars
7m  3s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 35s
the patch passed

_ Other Tests _

-1 :x:
unit
314m  9s
root in the patch failed.

350m  5s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0d0e9d7f3560 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 78ae1f176d

Default Java
1.8.0_232

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/testReport/

Max. process+thread count
2841 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

the failures for precommit are all in code that doesn't change, looks like env issues. lemme try again.

[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsFallback
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.026 s <<< FAILURE! - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsFallback
[ERROR] org.apache.hadoop.hbase.rsgroup.TestRSGroupsFallback  Time elapsed: 0.008 s  <<< ERROR!
java.io.IOException: Shutting down
at org.apache.hadoop.hbase.rsgroup.TestRSGroupsFallback.setUp(TestRSGroupsFallback.java:64)
Caused by: java.lang.RuntimeException: Master not initialized after 200000ms
at org.apache.hadoop.hbase.rsgroup.TestRSGroupsFallback.setUp(TestRSGroupsFallback.java:64)
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestMigrateRSGroupInfo
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.03 s <<< FAILURE! - in org.apache.hadoop.hbase.rsgroup.TestMigrateRSGroupInfo
[ERROR] org.apache.hadoop.hbase.rsgroup.TestMigrateRSGroupInfo  Time elapsed: 0.012 s  <<< ERROR!
java.io.IOException: Shutting down
at org.apache.hadoop.hbase.rsgroup.TestMigrateRSGroupInfo.setUp(TestMigrateRSGroupInfo.java:79)
Caused by: java.lang.RuntimeException: Master not initialized after 200000ms
at org.apache.hadoop.hbase.rsgroup.TestMigrateRSGroupInfo.setUp(TestMigrateRSGroupInfo.java:79)
[INFO] Running org.apache.hadoop.hbase.TestAcidGuaranteesWithEagerPolicy
[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsCPHookCalled
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.025 s <<< FAILURE! - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsCPHookCalled
[ERROR] org.apache.hadoop.hbase.rsgroup.TestRSGroupsCPHookCalled  Time elapsed: 0.009 s  <<< ERROR!
java.io.IOException: Shutting down
at org.apache.hadoop.hbase.rsgroup.TestRSGroupsCPHookCalled.setUp(TestRSGroupsCPHookCalled.java:45)
Caused by: java.lang.RuntimeException: Master not initialized after 200000ms
at org.apache.hadoop.hbase.rsgroup.TestRSGroupsCPHookCalled.setUp(TestRSGroupsCPHookCalled.java:45)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 15s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  0s
master passed

+1 :green_heart:
checkstyle
2m 17s
master passed

+1 :green_heart:
spotbugs
10m  5s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 45s
the patch passed

-0 :warning:
checkstyle
2m 14s
root: The patch generated 21 new + 0 unchanged - 0 fixed = 21 total (was 0)

-0 :warning:
rubocop
1m  3s
The patch generated 4 new + 1107 unchanged - 5 fixed = 1111 total (was 1112)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
18m 50s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
10m 10s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

63m 40s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
dupname asflicense shellcheck shelldocs rubocop xml hadoopcheck spotbugs hbaseanti checkstyle

uname
Linux e2168fa47711 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 665a8767a0

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
122 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 20s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 50s
master passed

+1 :green_heart:
compile
3m 10s
master passed

+1 :green_heart:
shadedjars
7m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 24s
the patch passed

+1 :green_heart:
compile
3m  3s
the patch passed

+1 :green_heart:
javac
3m  3s
the patch passed

+1 :green_heart:
shadedjars
7m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 29s
the patch passed

_ Other Tests _

-1 :x:
unit
201m 14s
root in the patch failed.

242m 25s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e5a394636bc2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 665a8767a0

Default Java
2020-01-14

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/3/testReport/

Max. process+thread count
3470 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

latest run failed in hbase-server again with

[INFO] Running org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.029 s <<< FAILURE! - in org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS
[ERROR] org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS  Time elapsed: 0.012 s  <<< ERROR!
java.io.IOException: Shutting down
at org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS.setUp(TestRSGroupsKillRS.java:72)
Caused by: java.lang.RuntimeException: Master not initialized after 200000ms
at org.apache.hadoop.hbase.rsgroup.TestRSGroupsKillRS.setUp(TestRSGroupsKillRS.java:72)

a shutting down exception during set up sounds like something is wrong with our test set up. definitely not related to this change though.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  0s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 59s
master passed

+1 :green_heart:
checkstyle
2m 15s
master passed

+1 :green_heart:
spotbugs
10m  3s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 45s
the patch passed

-0 :warning:
checkstyle
2m 13s
root: The patch generated 21 new + 0 unchanged - 0 fixed = 21 total (was 0)

-0 :warning:
rubocop
1m  3s
The patch generated 4 new + 1107 unchanged - 5 fixed = 1111 total (was 1112)

+1 :green_heart:
shellcheck
0m  2s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
18m 48s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
10m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

62m 25s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
dupname asflicense shellcheck shelldocs rubocop xml hadoopcheck spotbugs hbaseanti checkstyle

uname
Linux a2e89e6d157a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c367e91aff

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
122 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 36s
master passed

+1 :green_heart:
compile
3m  5s
master passed

+1 :green_heart:
shadedjars
7m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 32s
the patch passed

+1 :green_heart:
compile
3m  4s
the patch passed

+1 :green_heart:
javac
3m  4s
the patch passed

+1 :green_heart:
shadedjars
7m 17s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
238m 48s
root in the patch passed.

279m 53s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5c92999615e6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c367e91aff

Default Java
2020-01-14

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/testReport/

Max. process+thread count
4507 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  1s
master passed

+1 :green_heart:
compile
2m 35s
master passed

+1 :green_heart:
shadedjars
7m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 49s
the patch passed

+1 :green_heart:
compile
2m 38s
the patch passed

+1 :green_heart:
javac
2m 38s
the patch passed

+1 :green_heart:
shadedjars
7m 13s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
321m 49s
root in the patch failed.

358m 33s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 48f127b50df0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / c367e91aff

Default Java
1.8.0_232

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/testReport/

Max. process+thread count
2686 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ugh. a different failure in hbase-server every time. like the bad-old-days before the flakey lists.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  0s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 51s
master passed

+1 :green_heart:
checkstyle
2m 13s
master passed

+1 :green_heart:
spotbugs
9m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 45s
the patch passed

-0 :warning:
checkstyle
2m 16s
root: The patch generated 21 new + 0 unchanged - 0 fixed = 21 total (was 0)

-0 :warning:
rubocop
1m  2s
The patch generated 4 new + 1107 unchanged - 5 fixed = 1111 total (was 1112)

+1 :green_heart:
shellcheck
0m  1s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
18m 50s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
10m 10s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

62m 12s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
dupname asflicense shellcheck shelldocs rubocop xml hadoopcheck spotbugs hbaseanti checkstyle

uname
Linux b8ebb26c1606 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d1aaa6632

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt

rubocop
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
122 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 spotbugs=3.1.12 rubocop=0.80.0

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 41s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 30s
master passed

+1 :green_heart:
compile
3m 11s
master passed

+1 :green_heart:
shadedjars
7m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 36s
the patch passed

+1 :green_heart:
compile
3m  7s
the patch passed

+1 :green_heart:
javac
3m  7s
the patch passed

+1 :green_heart:
shadedjars
7m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 47s
the patch passed

_ Other Tests _

-1 :x:
unit
209m 15s
root in the patch failed.

252m 46s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2515

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7a888c54f3e0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3d1aaa6632

Default Java
2020-01-14

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/5/testReport/

Max. process+thread count
3556 (vs. ulimit of 30000)

modules
C: hbase-shell hbase-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2515/5/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey  doesn't seem related
[ERROR]   TestBucketCache.testRetrieveFromPMem:296->testRetrievalUtils:333

yeah they're all spotty failures all over the place. I think the flaky infra needs a bigger window so it can catch rarer issues in the hbase-server module.
I'll do another run locally for changed modules and those that depend on them before merging.


Select a datapoint

Ability to select a data point on the line cut and keep it selected to this row number, in the .dat file, when switching between data columns. For example, when doing a 4-terminal voltage bias IV-trace you get 3 columns with data: V_bias, I_measure, V_measure. I plot x=V_bias, data=I_measure, I select datapoint V_bias = 0.5 mV and then switch to x=V_measure. I want to see what value V_measure has for V_bias = 0.5 mV.

@dbouman1
I'm not totally sure what you mean here. Do you mean selecting a single datapoint, and then seeing somewhere the values of the other parameters in the same row?
You can plot the relation with (x=V_bias, y=, z=V_measure) but I guess that's not what you mean.

Indeed, that is what I want.
Plotting V_bias vs V_measure is not really usable for my purposes.


Provide Wasm (and Rust) function to get valid principal/action/resource for a policy

Category
User level API features/changes
Describe the feature you'd like to request
vscode-cedar's autocomplete functionality needs a function in Wasm which takes a policy and schema, and returns all of the valid principal types for that policy, all of the valid actions for that policy, and all of the valid resource types for that policy.
The Rust API doesn't currently have this functionality either, so while we're at it, we should add this to the public Rust API too.
Describe alternatives you've considered
As a hack/workaround, the current code creates special intentionally-invalid policies and parses the errors produced by those.
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

An example based on the vscode-cedar testdata:
@id("E1,E2 a,a2 R2")
permit (principal, action, resource is NS::R2);

the constraints (policy export to JSON) are All for principal and action
{
  "effect": "permit",
  "principal": {
    "op": "All"
  },
  "action": {
    "op": "All"
  },
  "resource": {
    "op": "is",
    "entity_type": "NS::R2"
  },
  "conditions": [],
  "annotations": {
    "id": "E1,E2 a,a2 R2"
  }
}

but looking at the namespace, they are:

principal: NS::E1, NS::E2
action: NS::Action::"a", NS::Action::"a2"
resource: NS::R2

namespace NS {
  entity E;
  entity R1 in [R] = {"p1": String};
  entity R;
  entity R2 in [R] = {"p1": Long};
  entity E1 in [E] = {"p1": String};
  entity E2 in [E] = {"p1": Long};
  action "as";
  action "a" in [Action::"as"] appliesTo {
    principal: [E1, E2],
    resource: [R1, R2],
    context: {"c1": Long}
  };
  action "a1" in [Action::"as"] appliesTo {
    principal: [E1],
    resource: [R1],
    context: {"c1": Long}
  };
  action "a2" in [Action::"as"] appliesTo {
    principal: [E2],
    resource: [R2],
    context: {"c1": Long}
  };
}

Could you clarify what validity mean for this feature? I was wondering what's needed is the set of cross-products that type check.

Yes, I think that's what's needed.  More specifically I think what @hakanson wants is "all principal types for which the policy could ever fire" and likewise for actions/resources.

Yes, I think that's what's needed. More specifically I think what @hakanson wants is "all principal types for which the policy could ever fire" and likewise for actions/resources.

Got it. Thanks.

example of the code I'd like to replace is determineEntityTypes in https://github.com/cedar-policy/vscode-cedar/blob/prerelease/src/validate.ts#L341-L377 with tests at https://github.com/cedar-policy/vscode-cedar/blob/prerelease/src/test/suite/validation.test.ts#L427-L481

Implemented via #1074


[topi] fix strategy for sparse dense cuda

@vinx13 @ceruleangu
I fixed the strategy so it is able to lower now. However, the schedule is not working with the current master. Could you fix it?
To verify it, please enable CUDA test at:
https://github.com/apache/incubator-tvm/blob/master/tests/python/relay/test_sparse_dense_convert.py#L50

@antinucleon please updater as per comment

Updated


Fix issue #5795

Fix the issue: nutz plugin throw NPE at afterMethod, cause traceid keep unchange for the thread

Fix

[ ] Add a unit test to verify that the fix works.

[x] Explain briefly about why the bug exists and how to fix it.

[x] Closes #5795.

[x] Update the CHANGES log.

Thanks for contributing, please fix codestyle(you can run ./mvnw checkstyle:check locally to verify), and update the CHANGES.md

Thanks for reply. Fixed codestyle and update the CHANGES.md.


Clarify CRS 3 maintenance plans

Hi there,
thanks for the great work on CRS.
It would be nice if the maintenance plans for CRS 3 would be documented. Like eg. no more releases planned, or only 3.3.x releases for another 12 months or similar. This would help users to decide on their migration plans from CRS 3 to 4.
Thanks and best regards!
Rainer

I, for one, would like to see a 'single source of truth' CRS release policy. Currently, we have this scattered across three different locations… And what we do have written down is not consistent with the new plans going forwards, so everything needs updating, too.

Hey @rainerjung, very good to see you. It's been a while.
I second what @RedXanadu has said.
We are now concentrating on 3.3.x and 4.x with the 4.x release line being supposed to get monthly updates, so 4.1.0 coming out in the next few days.
The idea is to declare one of the 4.x releases an LTS release.
I'd say the enterprise approach to the migration question would be to wait for an 4.x LTS release and then to start the migration to that release. My in official response on 3.3.x maintenance is, that we will probably treat it like an LTS and we are likely to keep at least 2 LTS releases under maintenance. So the clock starts to tick for 3.3.x the moment one of the 4.x releases becomes LTS.
But this is no yet official and we kind of need to grow into this new release policy.
What do you think about the LTS plans explained above. Does this make sense from your perspective?

We are in the process of writing an official document with our release policy.


replies get used up?

I noticed that sometimes the replies were blank, and I guess this is why:

Replies can be stacked up and will be chosen at RANDOM. Once a reply has been used, we discard it and won't use it again.

you mean permanently discarded? is there a way to stop this behavior, or to cycle through the replies in order? eg if I have an NPC in a shop, I want him to just keep repeating a set phrase like
"Come back later I told ya"

found the answer

Keep Flag
If you have a reply that needs to stick around after it has been said you need to mark it with the {keep} flag.

i say this

{keep} this is a reply

just to confirm if the empty situatino happens if there is only one reply?
if you have two or more will it bounce back and repeat even without :keep?

/*
	Keep Flag Test
	We use the keep flag to allow us to reuse the gambit over and over

*/
> topic:keep keeptopic
	+ i have one thing to say
	- topic test pass
< topic

You are on track.
If you want to keep a reply use the {keep} flag on the reply, or you can apply it globally to the whole topic as you shown above.
The will come back into play after 10 messages. And they are not erased globally (for all users) just the current user.


Autoreplay feature

Can you add autoReplay features or input number of replay as needed

you can use any macro software to config a simple combination in order to click on play button each 35 seconds
exemple :


Added test for readonly properties from parent scope variable

This PR adds a failing test for #58.
In the test, the closure inherits an object which uses readonly properties from the parent scope.
This causes an error when the closure gets deserialised as explained by @theofidry.

Thank you for this. Are you able to now, adjust the source code to solve the issue? You probably want to add a few more tests.

This probably a no-fix. It is not possible to by-pass readonly, even using reflection.

@Wedrix what are your thoughts on @GrahamCampbell's comment?

@Wedrix what are your thoughts on @GrahamCampbell's comment?

Found this somewhere in the PHP docs. It may be possible depending on the implementation. I am yet to study the code.

I am afraid this issue is unfixable, because it's literally impossible to set readonly properties using reflection. Feel free to make a pull request if you can come up with a solution.

Thanks for investigating this @Wedrix! I remember going a bit nuts on that issue not finding the cause, good to know why now.


Making arrayFormat: 'comma' symmetric with one-element arrays

arrayFormat: 'comma' currently doesn't work as expected with arrays of length 1.
I am using query-string to serialize objects and then read them from the query string, both with arrayFormat: 'comma'.
ids: [1, 2, 3] becomes ids=1,2,3, which is parsed as ids: [1, 2, 3] (expected).
ids: [1] becomes ids=1, which is then parsed as ids: 1 (unexpected).
Now, this can be solved easily by using another array format, but it seems that nothing stops arrayFormat: 'comma' from handling these cases properly.
For example, a solution I came up with is to stringify ids: [1] as ids=1,, which would then be read as ids: [1], as expected.

Trailing comma is already used to indicate a null element: https://github.com/sindresorhus/query-string/blob/a5ed7eaf496b47e0cd7f6071a56ac297c8e280e4/test/stringify.js#L136
You're better off either using 'bracket-separator' or even just JSON.stringifying the value (especially if you control both sides of the serialization).
The best solution would be to allow defining the types using some kind of schema: https://github.com/sindresorhus/query-string/issues/210

Well, I'm not sure my users would appreciate JSON in their address bar, haha. But yes, I did use bracket-separator in the end. The only difference is that it displays empty arrays, so I had to remove them manually with exclude. Calls for skipEmptyArrays, perhaps?
Other than that, my use case was covered. Thanks for making the package!

@finkrer
Could u please give me your solution for this ?

@phuhd-0935  Sure, something like that.
search = queryString.exclude(
      search,
      (_, value) => (Array.isArray(value) && value.length === 0),
      {
        arrayFormat: 'bracket-separator',
        arrayFormatSeparator: ',',
        parseBooleans: true,
        parseNumbers: true,
        skipEmptyString: true,
      }
    )


Expose 'originalInput' to access control functions for lists & fields

Let's say I've got a "publishing workflow" where a Post, once published, can't be edited except by admins, or if the author first marks it as draft.
I've got two options for setting access control, but neither seem ideal:
Option 1: access per field
keystone.createList('Post', {
  fields: {
    content: {
      type: Text,
      access: {
        read: true,
        create: true,
        update: ({ authentication: { item }, existingItem }) => {
          if (!item) {
            return false;
          }

          if (item.isAdmin) {
            return true;
          }

          // Allow updating when in draft
          // NOTE: This check is now required on _every_ field
          return existingItem.publishStatus !== 'published';
        },
      }
    },
    publishStatus: {
      type: Select,
      options: ['draft', 'published'],
      defaultValue: 'draft',
      access: {
        read: true,
        create: true,
        update: ({ authentication: { item }, existingItem }) => {
          if (!item) {
            return false;
          }

          // Admins or authors can adjust the published status
          if (item.isAdmin || existingItem.author === item.id) {
            return true;
          }
        },
      }
    },
  },
});

This isn't great because it would be easy to accidentally forget to add that access control on every field.
Option 2: List-level access
keystone.createList('Post', {
  fields: {
    content: { type: Text },
    author: { type: Relationship, ref: 'User' },
    publishStatus: {
      type: Select,
      options: ['draft', 'published'],
      defaultValue: 'draft',
    },
  },
  access: {
    create: true,
    read: true,
    update: ({ authentication: { item } }) => {
      if (!item) {
        return false;
      }

      if (item.isAdmin) {
        return true;
      }

      // How do I allow the author to set a 'published' post back to 'draft'?
      return {
        publishStatus_not: 'published'
        author: { id: item.id },
      }
    }
  },
});

This seems like the best bet, but I can't access the incoming changes so I can first check to see what the author is trying to change, and if it involves changing the publishedStatus to draft, then it's ok, otherwise, don't allow it.

So, this PR introduces the originalInput, which allows it to come out like this:
keystone.createList('Post', {
  fields: {
    content: { type: Text },
    author: { type: Relationship, ref: 'User' },
    publishStatus: {
      type: Select,
      options: ['draft', 'published'],
      defaultValue: 'draft',
    },
  },
  access: {
    create: true,
    read: true,
    update: ({ authentication: { item }, originalInput }) => {
      if (!item) {
        return false;
      }

      if (item.isAdmin) {
        return true;
      }

      // The only valid edit an author can make to publishStatus is to move it
      // from 'published' -> 'draft'.
      if (originalInput.publishStatus && originalInput.publishStatus !== 'draft') {
        return false;
      }

      // Otherwise, the author must be trying to edit a post that's already got
      // publishStatus in draft
      return {
        author: { id: item.id },
        publishStatus_not: 'published',
      };
    }
  },
});

100% agreed! I didn't want to clutter up this PR too much, but am happy to come back to it in the future 👍

In aggregate, the tests have all passed. Each run produces a different failure, all related to the known issues with our Cypress suite.


Add username's file

test github

created a branch, created a file and made a commit, and opened a pull
request


Prepare version 1.1.0

Changes to adopt to new version of EasyScience
Support for magnetism from refl1d
New way to fetch input data for tutorials

have to wait until easyscience v1.0.0 is ready


feat(sandbox): frontend example of payment-service

Description
adds example of payment-service(frontend)
Fixes #415
Type of change

[ ] New feature (non-breaking change which adds functionality)

Checklist:

[ ] Performed a self-review of my own code
[ ] Code conforms with the style guide

@sumiter92 fix sonar issues

@sumiter92 sonar issues?


On .NET Live: Co-hosting & Planning

Describe the issue or suggestion

I'll likely co-host several On .NET Live streams in the month of July.
I'll participate in On .NET Live planning meetings

https://learn.microsoft.com/en-us/shows/on-net/on-dotnet-live-building-a-game-with-dotnet-and-azure-open-ai
https://learn.microsoft.com/en-us/shows/on-net/on-dotnet-live-working-with-custom-controls-in-dotnet-maui
https://learn.microsoft.com/en-us/shows/on-net/on-dotnet-live-building-enterprise-apps-with-blazor


Setup /etc/default/cdap-web-app, if configured

This will cause the init script to source the file in /etc/default, allowing us to control the init script's behavior.

One example would be to set cdap['web_app']['enable_alpha_ui'] to true in CDAP 2.8 to test the Alpha UI.

:+1:


Use PackageLineup to manage PackageReference versions

Set PackageReference version from lineups.

Ugg. This forces you to use .NET Core 2.1.0. I can't sign off on this. Default user experience (latest stable release of VS) will give you these awful, misleading errors.

The current .NET SDK does not support targeting .NET Core 2.0.  Either target .NET Core 1.1 or lower, or use a version of the .NET SDK that supports .NET Core 2.0.

The current .NET SDK does not support targeting .NET Standard 2.0.  Either target .NET Standard 1.6 or lower, or use a version of the .NET SDK that supports .NET Standard 2.0.

The version of Microsoft.NET.Sdk used by this project is insufficient to support references to libraries targeting .NET Standard 1.5 or higher.  Please install version 2.0 or higher of the .NET Core SDK.

Do you have .NET Core 2.0.0 SDK installed and on your PATH? This is a requirement for .NET Core/Standard 2.0, regardless of this change.

Yep. Vanilla install of 15.3 + .NET Core SDK 2.0

I don't know how my change would lead to this then:

The current .NET SDK does not support targeting .NET Core 2.0. Either target .NET Core 1.1 or lower, or use a version of the .NET SDK that supports .NET Core 2.0.

I'm not changing TFMs.

I believe it's because of the copy of NuGet that ships inside VS. Installing (the EXE/MSI) the .NET Core SDK 2**.1** fixes the issue.

Basically, it can't find SDK 2.1.0 so it falls back to 1.1 (not 2.0).

@bricelam sounds like PATH issues. When you run build.cmd /t:noop, do you see warnings such as this?

Ok, I won't merge this yet, but I'm going to leave this PR open and move discussion to internal email thread so we can include the managers.

P.S. I'm OK doing this on 2.0.x patch branches. The workarounds are easy, just impossible to figure out.
build /t:Restore
DEL global.json

The workarounds are easy, just impossible to figure out.
build /t:Restore
DEL global.json

I hit the same when we upgraded to 2.1.0
There is very thin line between dogfood version of product and impossible to use product. And often we have ended up on the wrong side of the line.

I added some of these rough edges to the README and opened https://github.com/aspnet/BuildTools/issues/386 so we can follow up on other issues with setting up a local dev environment correctly.


fix: add missing "default_frontend_label" attribute property

Typos are hard, I haven't noticed them at all multiple times with this.


File error: Cannot open load file, no such file or directory, levenshtein

Perhaps you forgot to add it to your dependencies? Not sure.

Same problem here...


Access onMouse and onClick events

Is there a way to access onMouse events on the player? specially when the player is fullscreen?

What about this? https://github.com/cookpete/react-player/issues/1296


YarpLoggerDevice signal length different when saving

We noticed that some datasets we collected back in time are corrupted because the length of the joint position differs from the one of the joint velocity. This shouldn't happen since the pushing in the buffer manager and retrieving the data are done in the same thread of the logger.
Looking at the timestamps of the data we noticed that the data related to the joint position is longer than the one of the joint velocity.

Notice that for this specific dataset, the data were saved by the inner thread of the buffer manager and not closing the application. Since this behavior does  not happen in the case of the logger being closed (i.e., the buffer manager is destroyed) we were wondering if there is an issue in the saving of the data using the inner thread of robometry
cc @traversaro @S-Dafarra @LoreMoretti @isorrentino
Associated to: https://github.com/ami-iit/bipedal-locomotion-framework/issues/877

Does the same thing happen also for other data? I wonder if the condition in https://github.com/ami-iit/bipedal-locomotion-framework/blob/4e85d4d3c965b84f8a6ffa61a2678eceb9702f37/devices/YarpRobotLoggerDevice/src/YarpRobotLoggerDevice.cpp#L1483 was returning false maybe?

we were wondering if there is an issue in the saving of the data using the inner thread of robometry

The hunch might be correct. Checking the periodic save code in https://github.com/robotology/robometry/blob/bb2ea36c90141b9a6ac2be903619786734f95a52/src/librobometry/src/BufferManager.cpp#L230-L249, it seems that it locks the mutex m_mutex_cv, but this mutex is not locked when pushing back to the channel  https://github.com/robotology/robometry/blob/bb2ea36c90141b9a6ac2be903619786734f95a52/src/librobometry/include/robometry/BufferManager.h#L421-L453.
This might mean that while saving the buffer (done in https://github.com/robotology/robometry/blob/bb2ea36c90141b9a6ac2be903619786734f95a52/src/librobometry/src/BufferManager.cpp#L158-L202), it is still possible to push to the channels that have not been saved yet 🤔


Update kube-vip (non-ccm) to the latest version

A custom build of kube-vip is used within this project.
Update to the latest release version: https://github.com/plunder-app/kube-vip/tree/v0.3.2
(cc @thebsdbox)

@thebsdbox says the latest version should just work as a drop-in. (v0.3.5)

Updated to 0.3.8 in #76


Fix typos and wildcard error in EnvironmentSwitchHandler

Fixes a compile error in specification-compliant Java compilers, of which javac is not one.

Can one of the admins please verify this patch?

@GooeyHub: add to whitelist

Uh oh, something went wrong with the build. Need to check on that

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Approved and merged, thank you 👍


Error: unable to initialize llm library Radeon card detected

services:
  ollama:
    image: ollama/ollama:latest
    container_name: ollama
    devices:
      - /dev/dri
      - /dev/kfd
    volumes:
      - data:/root/.ollama
    restart: unless-stopped

volumes:
  data:

Having this docker compose config i get the following error:
Error: unable to initialize llm library Radeon card detected, but permissions not set up properly.  Either run ollama as root, or add you user account to the render group.
time=2024-02-21T12:25:30.862Z level=INFO source=images.go:706 msg="total blobs: 31"
time=2024-02-21T12:25:30.863Z level=INFO source=images.go:713 msg="total unused blobs removed: 0"
time=2024-02-21T12:25:30.864Z level=INFO source=routes.go:1014 msg="Listening on [::]:11434 (version 0.1.25)"
time=2024-02-21T12:25:30.864Z level=INFO source=payload_common.go:107 msg="Extracting dynamic libraries..."
Error: unable to initialize llm library Radeon card detected, but permissions not set up properly.  Either run ollama as root, or add you user account to the render group.
time=2024-02-21T12:25:43.219Z level=INFO source=images.go:706 msg="total blobs: 31"
time=2024-02-21T12:25:43.220Z level=INFO source=images.go:713 msg="total unused blobs removed: 0"
time=2024-02-21T12:25:43.221Z level=INFO source=routes.go:1014 msg="Listening on [::]:11434 (version 0.1.25)"
time=2024-02-21T12:25:43.222Z level=INFO source=payload_common.go:107 msg="Extracting dynamic libraries..."

I wonder how to fix the permission error. Can it be fixed in the docker compose code?

Never mind i had an error in LXC mount options


CDAP-6361 Create quicklinks to CDAP web services

This adds Quick Links to Ambari's CDAP page in the Ambari UI. To do this, we've created two new properties which aren't actually used by CDAP itself, but which will be used by Ambari.
This requires #79 for SSL detection.

LGTM


stopping simulation early bug

#383 allows a user to stop a running simulation early
but if the simulation is then continued from this point, there may be a jump in the resulting concentrations due to the interrupted partial step (which is not displayed in the plot, but as for the simulator it may be multiple completed sub-steps so it may have advanced the simulation beyond the state at the displayed time, which is then visible as a jump in the first timestep)

ideally this should be fixed, maybe by adding a partial step data point to the graph & concentration images
alternatively the GUI could be changed to a "stop" button which asks the simulator to stop at the end of a full step, but which turns into a "force stop" button after it is clicked which will then stop the simulator asap, with a warning about the consequences.
it is important to give the user the option to stop the simulator early in the case where completing a full step would take far too long

when a simulation stops early, we should set a flag, such that clicking on "simulate" re-initializes the simulator using the last SimulationData instead of just continuing with the current (potentially in-between steps) simulator state. Or maybe just do this after the simulation stops to avoid changing the "simulate" button logic?


Should whether the pleading is available be part of the logic for defense_rent_pleading_requirements?

if tenant_got_summons and petition_available:
if petition_alleges_nonrent or not petition_states_rent_amount or (not has_written_lease and not petition_states_terms_of_lease) or (has_written_lease and not lease_attached and not petition_states_terms_of_lease) or not petition_states_rent_periods or not petition_states_demand_made or (trial_court.circuit == 21 and not petition_separates_nonrent):
defense_rent_pleading_requirement = True
else:
defense_rent_pleading_requirement = False
else:
defense_rent_pleading_requirement = None

also required for 55.22 - no lease attached defense
also, it seems to assume that all the answers to the pleading requirements questions are no if you change from no pleading to pleading, when it should ask again.

@tobyfey Did you resolve this?


Crash on loading save. After removing mods + more.

Describe the Bug
I removed some mods that where broken + adding 3 other mods that i wanted instead
then on loading save this issue pops up.

To Reproduce
Note install a copple of mods not only the subjects.

Add modds u want to use and start a save. 1 of the mods can be -> (mod i used: Deep storage unit )
Save & quite game.  then  (Remove mod i used: Deep storage unit )
Restart game and load save u just made. Error shown on image shold we viseble to u.

Save file & Username
1.1.46 Bobs-Dark-Guns.zip
User Name
Sgamez
Log file
factorio-current.log
Privatley alternated mods
Customized.zip

Another note removing mod made me able to contiunue my save

I was unable to reproduce this issue, and I'm unsure of how it's even possible that it happened. If you ever come across it again, please let me know.

ok. i could add mod after no issue

Tho i have no more info to give it's all of it

tho i still have a save that breaks


Sanity v3 Internal server error: Failed to resolve import "sanity-plugin-tags" from "sanity.config.js". Does the file exist?

Hi! I am trying to add this plugin to a v3 project, but I get an import error:
Internal server error: Failed to resolve import "sanity-plugin-tags" from "sanity.config.js". Does the file exist?

In my sanity.config.js file I am importing import {tags} from 'sanity-plugin-tags'
I also tried justimport {tags} from 'tags' as that matches the name of the plugin in package.json but I get this error:
Internal server error: Failed to resolve entry for package "tags". The package may have incorrect main/module/exports specified in its package.json.

here is my package.json:
{
  "name": "gramafilm",
  "private": true,
  "version": "1.0.0",
  "main": "package.json",
  "license": "UNLICENSED",
  "scripts": {
    "dev": "sanity dev",
    "start": "sanity start",
    "build": "sanity build",
    "deploy": "sanity deploy",
    "deploy-graphql": "sanity graphql deploy"
  },
  "keywords": [
    "sanity"
  ],
  "dependencies": {
    "@sanity/color-input": "^3.0.2",
    "@sanity/vision": "^3.0.0",
    "get-youtube-id": "^1.0.1",
    "pluralize": "^8.0.0",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "react-icons": "^4.6.0",
    "react-is": "^18.2.0",
    "react-youtube": "^10.0.0",
    "sanity": "^3.0.0",
    "styled-components": "^5.2.0",
    "tags": "^2.0.10"
  },
  "devDependencies": {
    "@sanity/eslint-config-studio": "^2.0.1",
    "@types/react": "^18.0.25",
    "@types/styled-components": "^5.1.26",
    "eslint": "^8.6.0",
    "prettier": "^2.8.4",
    "typescript": "^4.0.0"
  },
  "prettier": {
    "semi": false,
    "printWidth": 100,
    "bracketSpacing": false,
    "singleQuote": true
  }
}

Also just got confused with this. Both the v2 message on the sanity docs but also on this repo itself it also says sanity install tags instead of install sanity-plugin-tags

Bump, also ran into this small problem. Editing the README would make it a smoother experience.

With the README update, this should be fixed now!


TSX colors still appear broken

Paste the code please, I can't type that out

This is the same issue as #118. I hope @p00f can fix this soon. Miss this plugin in my react development.

@Dosx001 The snippet pasted in #118 works, and nobody pasted the one here yet

@p00f I assumed the issue was unresolved since the it was still open.
Well here's a simple snippet I have laying around.
import type { GetServerSideProps } from "next";
import { useRouter } from "next/router";
import { useState } from "react";
import { prisma } from "../lib/prisma";

interface FormData {
  title: string;
  content: string;
  id: string;
}

interface Notes {
  notes: {
    id: string;
    title: string;
    content: string;
  }[];
}

const Home = ({ notes }: Notes) => {
  const [form, setForm] = useState<FormData>({
    title: "",
    content: "",
    id: "",
  });
  const router = useRouter();

  const refreshData = () => {
    router.replace(router.asPath);
  };

  async function create(data: FormData) {
    if (data.title && data.content) {
      try {
        fetch("http://localhost:3000/api/create", {
          body: JSON.stringify(data),
          headers: {
            "Content-Type": "application/json",
          },
          method: "POST",
        }).then(() => {
          setForm({ title: "", content: "", id: "" });
          refreshData();
        });
      } catch (e) {
        console.log(e);
      }
    }
  }
  async function deleteNote(id: string) {
    try {
      fetch(`http://localhost:3000/api/note/${id}`, {
        headers: {
          "Content-Type": "application/json",
        },
        method: "DELETE",
      }).then(() => {
        refreshData();
      });
    } catch (e) {
      console.log(e);
    }
  }

  const handleSubmit = async (data: FormData) => {
    try {
      create(data);
    } catch (e) {
      console.log(e);
    }
  };

  return (

Notes

      <form
        className="w-auto min-w-[25%] max-w-min mx-auto space-y-6 flex flex-col items-stretch"
        onSubmit={(e) => {
          e.preventDefault();
          handleSubmit(form);
        }}
      >
        <input
          className="border-2 rounded border-gray-600 p-1"
          type="text"
          placeholder="Title"
          value={form.title}
          onChange={(e) => setForm({ ...form, title: e.target.value })}
        />
        <textarea
          className="border-2 rounded border-gray-600 p-1"
          placeholder="Content"
          value={form.content}
          onChange={(e) => setForm({ ...form, content: e.target.value })}
        />
        <button type="submit" className="bg-blue-500 text-white rounded p-1">
          Add
        </button>
      </form>

          {notes.map((note) => (

{note.title}

{note.content}

                <button
                  onClick={() => deleteNote(note.id)}
                  className="bg-red-500 px-3 text-white rounded"
                >
                  X
                </button>

          ))}

  );
};

export default Home;

export const getServerSideProps: GetServerSideProps = async () => {
  const notes = await prisma.note.findMany({
    select: {
      title: true,
      id: true,
      content: true,
    },
  });
  return {
    props: {
      notes,
    },
  };
};

@Dosx001 can you try out the latest commit?

@p00f this is what I'm seeing with the new commit on
OS: Arch Linux x86_64
Kernel: 5.18.14-arch1-1
NVIM v0.7.2

It looks fine on 6c0b3b670f67c8eb4dca72e13fcba156f708cb86

I also encounter this problem in typescriptreact.
import type { Component } from "solid-js";

import logo from "./logo.svg";
import styles from "./App.module.css";

const App: Component = () => {
  return (

          Edit src/App.tsx and save to reload.

          Learn Solid

  );
};

export default App;

Notice that the self-closing img element (line 9) is colored correctly. All other elements' props have the same color as the element (line 7, 8, 14-17). Maybe that helps solve the problem.
I am on the latest commit (c5d2e6c45723daf2bfc1502d5d4b1331e6ebd6ab).

@Gelio that is intended behaviour, to turn that off disable extended mode

i'm sorry I wasn't able to test over the weekend, but i'm happy to say that it works for me in the latest commit!


New return type to modify entity components

new system return type which should allow setComponent and removeComponent to be called on the current entity invocation
TODO:

suggested API
how should it interact with multi-threading
how should iterating handle this (should probably "just work?" 🙏)

Problematic case: removing or adding component so that it will be move to an archetype yet to be looped over. How do we track that these should be skipped?

987dcb2 You can directly edit entities in systems through Storage.Subset now!


Cannot refresh resources and it's reachable paths

The resource api will not let us refresh a resource and all it's reachable paths from the server. A kind of loadPaths that gets the resources and it's reachable paths, while still honouring embedded resources.
context.refresh gets all resources in the context from the server, leading to unnecessary requests.

The implementation could be something like this: (not tested)
Resource.$load:
      $load: {value: function (ts) {
        if (this.$syncTime && this.$syncTime < ts) {
          return $q.when(this);
        } else {
          return this.$context.httpGet(this);
        }
      }},

Context.refresh:
      refresh: {value: function (ts) {
        var promises = [];
        angular.forEach(this.resources, function (resource) {
          if (resource.$isSynced) {
            promises.push(resource.$load(ts));
          }
        });
        return $q.all(promises);
      }},

@mvcatsifma Is this still an issue?

@jcassee Ja, en ik wil deze week de implementatie doen.

Fixed by #31.


Grid shows when you click on submit button

Related Issue

Info about the related issue

Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
Give a clear description what modifications you have made
Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Mention any unusual behaviour of your code (Write NA if not)
Any unusual behaviour of your code
Additional Info (optional)
Any additional information you want to give
Checklist:

[x] My code follows the guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly whereever it was hard to understand.
[x] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.

U just added one line comment . No change in the functionality

I make little bit attractive but it works when you click on submit button it shows grid.

I make little bit attractive but it works when you click on submit button it shows grid.

Its not showing on online servers . In local machine it works perfectly

sir I don't see much of the changes u made !  no functionality is added or improvised!


[SEO] Replace atomic - Updated Breadcrumb Filter

Completed on below PR:
https://github.com/hlxsites/danaher-ls-aem/pull/984

Completed on below PR:
https://github.com/hlxsites/danaher-ls-aem/pull/984

Completed on below PR:
https://github.com/hlxsites/danaher-ls-aem/pull/984


Return correct fromCache value when tokens are acquired from WAM

WAM exposes whether or not a token was returned from the cache via MATS telemetry. This PR parses MATS to return the correct value in the fromCache field of the response.

Codecov Report

Merging #4880 (0561574) into dev (fc942cc) will not change coverage.
The diff coverage is 95.23%.

Flag
Coverage Δ

*Carryforward flag

msal-angular
96.42% <ø> (ø)

msal-browser
87.13% <95.23%> (ø)

Carriedforward from fc942cc

msal-common
85.89% <ø> (ø)

Carriedforward from fc942cc

msal-core
82.67% <ø> (ø)

Carriedforward from fc942cc

msal-node
83.40% <ø> (ø)

Carriedforward from fc942cc

msal-node-extensions
76.03% <ø> (ø)

Carriedforward from fc942cc

msal-react
94.50% <ø> (ø)

node-token-validation
86.92% <ø> (ø)

Carriedforward from fc942cc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

.../src/interaction_client/NativeInteractionClient.ts
72.95% <94.11%> (ø)

lib/msal-browser/src/utils/BrowserConstants.ts
100.00% <100.00%> (ø)


User doesn't see the deleted products after toggling "Show Deleted"

Description:
User doesn't see the deleted products after toggling "Show Deleted"

@funtigr this should be a old bug before the UI changes.

Yes, not works as expected.


Group items in hierarchical layouts

Hello,
I find out that draw.io is very easy to use to generate automatic graphs from CSV and lately use those in other places such as Grafana.
However, even layouts have very powerful algorithmics, they do not fit in a classical network representation.
Let me explain...
In Networking, we usually have a hierarchical device connection, which commonly looks like a tree with connections between devices at the same level.

(^^ something like this ^^)
However, layouts do not handle correctly when 2 different nodes have to be on the same "level", and I did not find out any way to "configure" such thing and make things like that: (vertical tree/ vertical flow)

I don't know if there is a way to configure or notify the MXgraph to group those elements into the same hierarchical level. I've tried almost everything with no result.
#190 seems to have something in common with this issue, but when using left/top positioning, documentation says that layouts would overwrite them
Any help would be much appreciated.
Thanks

We don't have a layout that supports this. Both the tree and hierarchical don't allow significant edges between same level vertices. You'd have to know which edges to ignore and indicate to the layout to ignore them.

Thank you @davidjgraph,
The idea to filter edges sounds great. It shouldn't be difficult to identify such edges and put them in a array in an automated-way.
However... I'm reading the code ( https://github.com/jgraph/mxgraph/blob/master/javascript/src/js/layout/hierarchical/mxHierarchicalLayout.js ) and I can not find the property or something like that to ignore a set of edges.
How would be the way to do that? I'm still reading by the way other files, but my expertise in JS and the integration with draw.io is low. Any clue would be much appreciated.
Edit:
Reading https://github.com/jgraph/mxgraph/blob/master/javascript/src/js/layout/mxGraphLayout.js I have found the method "isEdgeIgnored()". I suppose i have to hide the "problematic" edges, apply the layout, and make them visible again. Am I correct? There are any other more explicit way?

Hello again.
I've tested the visible property.
However, it doesn't work as I would expect.
If I remove the links at the same level, I get with the horizontal/vertical flow almost what I would like to see:

However, if I mark those edges as 'visible="0"', I get the same result as if those edges are visible (but invisible actually):

(same shape with horizontal/vertical)
I attach the diagram with the visible attribute set to 0. I don't know if there is a bug with it or not.
testdiagram.zip
According to the code, this change should work but it doesn't. Any ideas? Any other way to ignore edges? Should I add (and test) a PR that handles an attribute called "ignore" that makes this for us?

Note:
Trees seems to work with invisible edges if there is a (fake) element that is set as root. However the shape/representation of this is not as good as the horizontal/vertical flow can be.

The json used to generate that tree was:
[   {     "layout": "mxCompactTreeLayout",     "config": {       "horizontal": false,       "invert": 0,       "resizeParent": true,       "maintainParentLocation": false,       "moveTree": true,       "sortEdges": true,       "alignRanks": true     }   } ]

I have created this related PR: https://github.com/jgraph/mxgraph2/pull/12

Thank you @davidjgraph for your guidance.
I have requested a couple of pull requests on MXGraph2.
I don't know if it is the correct repository to make those pull requests. ¿Should I open them on this repository instead?
Regards.


Package Requested

[X] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[ ] I have performed a search and couldn't find this package.
[ ] I have checked that the installer for this package is not a standalone or portable executable or a .zip file
[ ] I think there is a new version available and I have provided the URL.

Please provide the following information
Publisher: KDE e.V.
Publisher Url: http://kde.org
Package Name: KDE.KJumpingCube.Nightly
Description: http://apps.kde.org/kjumpingcube
Package Version: master-790
Installer URL: http://binary-factory.kde.org/view/Windows 64-bit/job/KJumpingCube_Nightly_win64/lastSuccessfulBuild/artifact/kjumpingcube-master-790-windows-msvc2019_64-cl.exe
Current Package Identifier (for new versions): master-790

Duplicate of #39190
Please post your KDE requests here


LICENSE

Thanks for the great work. Could you post a LICENSE statement?

Thank you for your interest in our work. It's done.


prune localizations for replication scheduling

Signed-off-by: Di Xu<EMAIL_ADDRESS>
What type of PR is this?
kind/bug
What this PR does / why we need it:
When updating scheduling strategy from Dividing to Replication, old Localizations are not pruned.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Codecov Report

Merging #401 (11d0371) into main (7557b87) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   13.54%   13.54%
=======================================
  Files          60       60
  Lines        6502     6502
=======================================
  Hits          881      881
  Misses       5554     5554
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7557b87...11d0371. Read the comment docs.

/lgtm


Fix links to poll method docs incorrectly going to Poll type

It looks like link names in Markdown are case-insensitive?

Interesting! I had no idea...


API deprecate solver.stopping_strategy in favor of solver.sampling_strategy

closes #577

Codecov Report

Merging #588 (a8a2db1) into main (8dd23c8) will decrease coverage by 0.12%.
The diff coverage is 33.33%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
- Coverage   54.67%   54.55%   -0.12%
==========================================
  Files          43       43
  Lines        2804     2810       +6
  Branches      510      511       +1
==========================================
  Hits         1533     1533
- Misses       1159     1164       +5
- Partials      112      113       +1

@tomMoral how to prevent the html to be opened in firefox when running the tests? It does not seem to happen on other tests.


Fixed 4-byte utf-8 encoding

Would using U+1F44D instead for the test work?

LGTM either way - I will be more responsive on the weekend.


Slow exit(:q) time in Neovim

Hey, thank you for your work.
I noticed there is a noticeable(2-3s) delay when exiting(:q) neovim from a markdown file with your lsp launched. However, if i switch to a different file, lua for example, there is no delay
Installed  through :Mason
Neovim version
❯ nvim --version
NVIM v0.10.0-dev-3087+gbb032d952b
Build type: RelWithDebInfo
LuaJIT 2.1.1713773202

Let me know if you need more details

Hey thanks for the contribution!
I don't have this issue as my neovim closes instantly.
Would you mind disabling markdown oxide :LspStop then quitting and seeing if there is still a delay?

After some debugging I realized it was a configuration bug on my part:
vim.api.nvim_create_autocmd("LspDetach", {
			group = vim.api.nvim_create_augroup("kickstart-lsp-detach", { clear = true }),
			callback = function(event)
				vim.lsp.buf.clear_references()
				vim.lsp.codelens.clear()
				vim.lsp.inlay_hint.enable(false)

				-- this line after doing :LspStop outputs an error
                               vim.api.nvim_clear_autocmds({ group = "kickstart-lsp-highlight", buffer = event.buf })

                               vim.api.nvim_clear_autocmds({ group = "custom-lsp-codelens", buffer = event.buf })
			end,
		})

Sorry for disturbance and thank you for a great LSP!

Thank you! Feel free to open issues for anything else!


[fix][build] Disable flaky test BrokerRegistryIntegrationTest

Motivation & Modifications
Disable flaky test BrokerRegistryIntegrationTest (#23365) until it's fixed.
It's currently blocking Pulsar CI.
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.49%. Comparing base (bbc6224) to head (738981e).
Report is 606 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23367      +/-   ##
============================================
+ Coverage     73.57%   74.49%   +0.92%
- Complexity    32624    33923    +1299
============================================
  Files          1877     1934      +57
  Lines        139502   145131    +5629
  Branches      15299    15870     +571
============================================
+ Hits         102638   108115    +5477
+ Misses        28908    28716     -192
- Partials       7956     8300     +344

Flag
Coverage Δ

inttests
27.51% <ø> (+2.92%)
:arrow_up:

systests
24.57% <ø> (+0.25%)
:arrow_up:

unittests
73.83% <ø> (+0.99%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 601 files with indirect coverage changes


I keep getting a invalid sender?

Is this a watch wallet or full wallet?
Can you check your key integrity by going settings -> change / add wallet -> 'Hamburger' options for the wallet you need to edit -> 'Key' in menu top right next to 'Manage Wallet'.
You can click on 'Run Key Diagnostics' which will test if it's possible to recover the 'public key' for the account in any way. If the public key doesn't appear then key has lost integrity, which is usually caused by a big change to the security of the phone; maybe the phone was fully unlocked (ie remove the fingerprint credentials, PIN/swipe).
 Note that the value shown is NOT sensitive, it is not the private key, it is the number used to create your ethereum address. You don't have to share that part with us though, please just say what the other text on the page says.
Make sure you are running the latest version of AlphaWallet too.

It's a full wallet and I got public key for it also
On Fri, Sep 23, 2022, 4:08 AM James Brown @.***> wrote:

Is this a watch wallet or full wallet?
Can you check your key integrity by going settings -> change / add wallet
-> 'Hamburger' options for the wallet you need to edit -> 'Key' in menu top
right next to 'Manage Wallet'.
You can click on 'Run Key Diagnostics' which will test if it's possible to
recover the 'public key' for the account in any way. If the public key
doesn't appear then key has lost integrity, which is usually caused by a
big change to the security of the phone; maybe the phone was fully unlocked
(ie remove the fingerprint credentials, PIN/swipe).
 Note
that the value shown is NOT sensitive, it is not the private key, it is the
number used to create your ethereum address. You don't have to share that
part with us though, please just say what the other text on the page says.
Make sure you are running the latest version of AlphaWallet too.
—
Reply to this email directly, view it on GitHub
https://github.com/AlphaWallet/alpha-wallet-android/issues/2839#issuecomment-1255914469,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVPJGOV3ZH45I2HRHNS5IYLV7VQRTANCNFSM6AAAAAAQTCRWNI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Decode keystore public key:0
On Fri, Sep 23, 2022, 4:19 PM Anthony hunt @.***> wrote:

It's a full wallet and I got public key for it also
On Fri, Sep 23, 2022, 4:08 AM James Brown @.***>
wrote:

Is this a watch wallet or full wallet?
Can you check your key integrity by going settings -> change / add wallet
-> 'Hamburger' options for the wallet you need to edit -> 'Key' in menu top
right next to 'Manage Wallet'.
You can click on 'Run Key Diagnostics' which will test if it's possible
to recover the 'public key' for the account in any way. If the public key
doesn't appear then key has lost integrity, which is usually caused by a
big change to the security of the phone; maybe the phone was fully unlocked
(ie remove the fingerprint credentials, PIN/swipe).
 Note
that the value shown is NOT sensitive, it is not the private key, it is the
number used to create your ethereum address. You don't have to share that
part with us though, please just say what the other text on the page says.
Make sure you are running the latest version of AlphaWallet too.
—
Reply to this email directly, view it on GitHub
https://github.com/AlphaWallet/alpha-wallet-android/issues/2839#issuecomment-1255914469,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVPJGOV3ZH45I2HRHNS5IYLV7VQRTANCNFSM6AAAAAAQTCRWNI
.
You are receiving this because you authored the thread.Message ID:
@.***>

0x3f17f1962b36e491b30a40b2405849e597ba5fb5
On Fri, Sep 23, 2022, 4:22 PM Anthony hunt @.***> wrote:

It show a green check mark when I run diagnostics
On Fri, Sep 23, 2022, 4:21 PM Anthony hunt @.***> wrote:

Decode keystore public key:0
On Fri, Sep 23, 2022, 4:19 PM Anthony hunt @.***>
wrote:

It's a full wallet and I got public key for it also
On Fri, Sep 23, 2022, 4:08 AM James Brown @.***>
wrote:

Is this a watch wallet or full wallet?
Can you check your key integrity by going settings -> change / add
wallet -> 'Hamburger' options for the wallet you need to edit -> 'Key' in
menu top right next to 'Manage Wallet'.
You can click on 'Run Key Diagnostics' which will test if it's possible
to recover the 'public key' for the account in any way. If the public key
doesn't appear then key has lost integrity, which is usually caused by a
big change to the security of the phone; maybe the phone was fully unlocked
(ie remove the fingerprint credentials, PIN/swipe).
 Note
that the value shown is NOT sensitive, it is not the private key, it is the
number used to create your ethereum address. You don't have to share that
part with us though, please just say what the other text on the page says.
Make sure you are running the latest version of AlphaWallet too.
—
Reply to this email directly, view it on GitHub
https://github.com/AlphaWallet/alpha-wallet-android/issues/2839#issuecomment-1255914469,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVPJGOV3ZH45I2HRHNS5IYLV7VQRTANCNFSM6AAAAAAQTCRWNI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Its still.  Not working
On Fri, Sep 23, 2022, 4:24 PM Anthony hunt @.***> wrote:

0x3f17f1962b36e491b30a40b2405849e597ba5fb5
On Fri, Sep 23, 2022, 4:22 PM Anthony hunt @.***> wrote:

It show a green check mark when I run diagnostics
On Fri, Sep 23, 2022, 4:21 PM Anthony hunt @.***>
wrote:

Decode keystore public key:0
On Fri, Sep 23, 2022, 4:19 PM Anthony hunt @.***>
wrote:

It's a full wallet and I got public key for it also
On Fri, Sep 23, 2022, 4:08 AM James Brown @.***>
wrote:

Is this a watch wallet or full wallet?
Can you check your key integrity by going settings -> change / add
wallet -> 'Hamburger' options for the wallet you need to edit -> 'Key' in
menu top right next to 'Manage Wallet'.
You can click on 'Run Key Diagnostics' which will test if it's
possible to recover the 'public key' for the account in any way. If the
public key doesn't appear then key has lost integrity, which is usually
caused by a big change to the security of the phone; maybe the phone was
fully unlocked (ie remove the fingerprint credentials, PIN/swipe).

Note that the value shown is NOT sensitive, it is not the private key, it
is the number used to create your ethereum address. You don't have to share
that part with us though, please just say what the other text on the page
says.
Make sure you are running the latest version of AlphaWallet too.
—
Reply to this email directly, view it on GitHub
https://github.com/AlphaWallet/alpha-wallet-android/issues/2839#issuecomment-1255914469,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVPJGOV3ZH45I2HRHNS5IYLV7VQRTANCNFSM6AAAAAAQTCRWNI
.
You are receiving this because you authored the thread.Message ID:
@.***>

What about the rest of the values on the page?
If it's not decoding the public key though, the key probably isn't there.
Has the security level of the phone changed? If you remove the screen lock on the phone and then restore the screen lock, the OS will erase all the contents of the secure enclave, which contains the data needed to reconstruct the key.

It show a green check mark when I run diagnostics
On Fri, Sep 23, 2022, 4:21 PM Anthony hunt @.***> wrote:

Decode keystore public key:0
On Fri, Sep 23, 2022, 4:19 PM Anthony hunt @.***> wrote:

It's a full wallet and I got public key for it also
On Fri, Sep 23, 2022, 4:08 AM James Brown @.***>
wrote:

Is this a watch wallet or full wallet?
Can you check your key integrity by going settings -> change / add
wallet -> 'Hamburger' options for the wallet you need to edit -> 'Key' in
menu top right next to 'Manage Wallet'.
You can click on 'Run Key Diagnostics' which will test if it's possible
to recover the 'public key' for the account in any way. If the public key
doesn't appear then key has lost integrity, which is usually caused by a
big change to the security of the phone; maybe the phone was fully unlocked
(ie remove the fingerprint credentials, PIN/swipe).
 Note
that the value shown is NOT sensitive, it is not the private key, it is the
number used to create your ethereum address. You don't have to share that
part with us though, please just say what the other text on the page says.
Make sure you are running the latest version of AlphaWallet too.
—
Reply to this email directly, view it on GitHub
https://github.com/AlphaWallet/alpha-wallet-android/issues/2839#issuecomment-1255914469,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVPJGOV3ZH45I2HRHNS5IYLV7VQRTANCNFSM6AAAAAAQTCRWNI
.
You are receiving this because you authored the thread.Message ID:
@.***>

If you are seeing the public key in the diagnostics (this data is not sensitive) then the key must be intact and functioning correctly.
Where are you getting 'invalid sender'? If it's in a dapp can you say which dapp you are seeing it in? If it's on a transaction can you say what type of transaction (pure transfer, ERC20/ERC721 transfer)?

i am getting same issue  its a transfer of bsctestnet token i am trying to transfer bsc testnet token from a wallet to another wallet

Ethereum and I'm trying to send to my Ethereum paypal act it doin it still sayin same bul

On full wallet


Add new key generator "LeafSegmentKeyGenerator"  and related functions.

Fixes #1775.
Changes proposed in this pull request:

Add new key generator "LeafSegmentKeyGenerator"  and related functions.

@terrymanu .
The test failed, due to LeafSegmentKeyGenrator test depends on zookeeper. Do u have any suggestion for me?
13:26:17.983 [pool-1-thread-1-SendThread(<IP_ADDRESS>:2181)] DEBUG org.apache.zookeeper.ClientCnxnSocketNIO - Ignoring exception during shutdown output
java.nio.channels.ClosedChannelException: null
at sun.nio.ch.SocketChannelImpl.shutdownOutput(SocketChannelImpl.java:797)
at sun.nio.ch.SocketAdaptor.shutdownOutput(SocketAdaptor.java:407)
at org.apache.zookeeper.ClientCnxnSocketNIO.cleanup(ClientCnxnSocketNIO.java:207)
at org.apache.zookeeper.ClientCnxn$SendThread.cleanup(ClientCnxn.java:1185)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1110)

You can try to use curator-test which can startup a zookeeper in memory, or use mock to do unit-test

@terrymanu .THX, I will try it later.

Pull Request Test Coverage Report for Build 8249

97 of 138 (70.29%)  changed or added relevant lines in 4 files are covered.
234 unchanged lines in 20 files lost coverage.
Overall coverage increased (+0.2%) to 60.843%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/keygen/LeafSegmentKeyGenerator.java
48
54
88.89%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/keygen/LeafExceptionHandler.java
0
10
0.0%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/keygen/LeafCuratorZookeeper.java
41
66
62.12%

Files with Coverage Reduction
New Missed Lines
%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/segment/dml/order/item/ExpressionOrderByItemSegment.java
1
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/segment/dml/order/item/ColumnOrderByItemSegment.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/common/dml/OrderByFiller.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/common/dml/GroupByFiller.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/segment/dml/order/item/OrderByItemSegment.java
4
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/statement/dml/SelectStatement.java
5
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/segment/dml/order/item/IndexOrderByItemSegment.java
5
0.0%

sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/parse/PostgreSQLComParseExecutor.java
6
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/segment/dml/column/ColumnSegment.java
7
0.0%

sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/rewriter/ShardingSQLRewriter.java
8
74.24%

Totals

Change from base Build 8228:
0.2%

Covered Lines:
8167

Relevant Lines:
13423

💛  - Coveralls

Nice work, thank you.
Let @tristaZero to review it.

@wgy8283335 Thanks, i think it is great after a quick look.
I will give you feedback as soon sa possiable.

@tristaZero. Thank you.

@wgy8283335
After reading your pr carefully and digging into the Leaf-segement and Leaf-Snowflake, i give my opinions about this pr, and also want to have
a discuss in detail with you, please let me know your feedback. Thanks.
1.The package of sharding-core-common should be basic package which is used by other packages, so it is better to move all the classes related to LeafSegmentKeyGenerator to sharding-orchestration-core
2.When LeafSegmentKeyGenerator is in sharding-orchestration-core, maybe we can consider to use CuratorZookeeperRegistryCenter instead of LeafCuratorZookeeper. The function of incrementCacheId in LeafCuratorZookeeper can considered to move to LeafSegmentKeyGenerator, and moving tryLock() to CuratorZookeeperRegistryCenter is ok?
3.The API of generateKey() now is to return null in LeafSegmentKeyGenerator, but it is not allowed to modify APIs. Therefore using generateKey(), not generateKey(tableName) is a better choice.

Actually, LeafSegmentKeyGenerator really needs tableName as a key in zk. So i suggest set tableName in properties of LeafSegmentKeyGenerator and getTableName() from properties to use it in zk.

5.The another important thing is multiple schemas. If user use same tableName in multiple schemas, the node value of same table name in zk will be overwrite. So please consider use schemaName and tableName as note key.


⚠ ClamAV has degraded performance

In 970b3c0, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 00e2474 after 5 minutes.


fix: make sliding window works without grace period (#kafka-13739)

backport of kafka-13739

Failure unrelated Build / JDK 8 and Scala 2.12 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testElectionResultOutput, Security=PLAINTEXT

Cherry-picked to 3.0


Camera will jump screens sometimes

Instead of panning, the camera will jump screens every other time after startup when walking to the right or left.

This code is no longer in this repository.


[PlaceholderAPI] Jobs is currently using a deprecated method to hook into PlaceholderAPI. This will be disabled after the next update. Please consult [phrstbrn] and urge them to updat

[PlaceholderAPI] Jobs is currently using a deprecated method to hook into PlaceholderAPI. This will be disabled after the next update. Please consult [phrstbrn] and urge them to updat

https://github.com/Zrips/Jobs/issues/413
Install the dev version.

@montlikadani , Which one PlaceHolder or Jobs plugin ? i need to download in dev version !

@montlikadani , Which one PlaceHolder or Jobs plugin ? i need to download in dev version !

https://github.com/Zrips/Jobs/releases/tag/4.11.2

Omg , thanks !