Sort Imports stopped working

Environment data

VS Code version: 1.47.3
Extension version (available under the Extensions sidebar): 2020.7.96456
OS and version: Ubuntu 18.04.5 LTS
Python version (& distribution if applicable, e.g. Anaconda): Python 2.7.17 (System), Python 3.8.5 (Conda)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Value of the python.languageServer setting: Jedi

Expected behaviour
When I click "Sort imports", the imports should be sorted.
Actual behaviour
Nothing happens. The Output Window reads:
> ~/.miniconda/envs/morphocut-graphviz/bin/python ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/sortImports.py - --diff
cwd: ~/Work/19-MorphoCut/morphocut-graphviz/src/morphocut
> ~/.miniconda/envs/morphocut-graphviz/bin/python ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/sortImports.py - --diff
cwd: ~/Work/19-MorphoCut/morphocut-graphviz/src/morphocut

Your issue maybe a dup of https://github.com/microsoft/vscode-python/issues/12949. Can you please check if any errors are logged in Developer tools?

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

XXXX

Yes, I get the same error:
mainThreadExtensionService.ts:65 [[object Object]]/home/moi/.miniconda/envs/morphocut-graphviz/lib/python3.8/site-packages/setuptools/distutils_patch.py:25: UserWarning: Distutils was imported before Setuptools. This usage is discouraged and may exhibit undesirable behaviors or errors.  This usage is discouraged and may exhibit undesirable behaviors or errors.  This will likely be resolved in the next release.

  File "/home/ubuntu/.vscode-server/extensions/ms-python.python-2020.10.332292344/pythonFiles/lib/python/isort/settings.py", line 31
    FILE_SKIP_COMMENTS: Tuple[str, ...] = (

gettint this error


Testing Component Did Catch

How can we test the ComponentDidCatch lifecycle method ?

Did you figure it out?

I did. Here is my comment from another thread:
You can test componentDidCatch using a spy method. I am using expect.spyOn there's also sinon. Here's is a working example of testing componentDidCatch:
import Login from './index';
import expect from 'expect';
import React from 'react';
import { mount } from 'utils/enzyme';

function ProblemChild() {
  throw new Error('Error thrown from problem child');
  return
Error
; // eslint-disable-line
}

describe('<Login />', () => {
  it('should catch errors with componentDidCatch', () => {
    const spy = expect.spyOn(Login.prototype, 'componentDidCatch');
    mount(<Login><ProblemChild /></Login>);
    expect(Login.prototype).toHaveBeenCalled();
  });
});


Added an animation for when leveling up.

The animation makes a copy of the $Sprites node in the player scene (along with it's children), then uses a tween to enlarge them as they fade away and finally deletes the copy.

Hopefully closes #49

I got an error when leveling up:

I guess it's just fixing the typo.

Oof, fixed.
Also, i know it's a bit basic rn, but it can always be improved later.
It is currently client-side but i imagine it's better that way (?)

It's working now.
I had a look at the effect and I am not really convinced about the result.
It kind of looks like the player is turning into a ghost or does a teleport.
I think a glow effect or even a big "LEVEL UP" text popping up would fit better.
Here is an example of how wow does it (I don't know what video is about but it had the levelup animation):
https://youtu.be/Tynw6D0j_Bw?si=k9MQAoloItaF9AVH&t=55

Yeah. The effect kind of blends in with the character itself and doesn't do much.
A "LEVEL UP" popup would be cool.
Do you think that this effect could be tweaked and combined with another or would you prefer if this was completely scrapped?
The expansion may add extra flair to other level up effects. But we can decide that when we get to it.

You may be able to re-purpose res://scenes/templates/JFloatingText/JFloatingText.tscn for a minimal effort "LEVEL UP!" pop-up fwiw.

I'd rather keep a simple thing like this contained to the script. It isn't any harder to reproduce than the existing animation, at least.

I'll keep this closed for the time being, will re-open when i do something with it.


Fix Docker for Mac reference

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Thanks, @vlad-ro :)


modify_vagrantfile

#53

Codecov Report

Merging #86 (880e624) into main (d70c8bb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   95.71%   95.71%
=======================================
  Files           5        5
  Lines         257      257
=======================================
  Hits          246      246
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70c8bb...880e624. Read the comment docs.

Thank you!!!


Cache downloaded layers

Currently we are using bazel over GCB and we have a performance issue with rules_docker where images are downloaded on every invocation
We would like to solve this issue by introducing a cache mechanism to containerregistery puller. Downloaded layers will be stored and fetched from this cache. The cache will be by layer so different images will be able to reuse layers that were already downloaded from different images

It sounds like Bazel distributed caching would be even more useful to you.  Have you looked into it at all?
cc @nlopezgi

Thanks @matmoor for your reply.
I think you’re incorrect. Bazel remote caching is for actions but unfortunately Bazel needs to have all of the external repositories on disk even if they exist in the remote CAS.
This is why Bazel has the repository_cache feature (currently only for files downloaded via the standard Bazel mechanism).
On Dev machines this is a net win.
On CI with ephemeral workers (like google’s GCB) you can use a GCP CDN and still get much faster results.
FTR we also use RBE (remote execution by google)


dbHash result caching. And some error output detalization

Description

Fixes # dbHash CPU high load

Hi @farmage
Really appreciate you coming up with a fix for db cache, as it was something needed in the future to do.
The only thing is can you add to this area, why you added a new parameter and what it does
https://github.com/X-CASH-official/xcash-dpops/blob/master/src/global_data/define_macros.h#L731
Also I think the last commit had all of the build folder in it, so if you can remove this as well
I have not had a chance to test this out yet, but will as soon as the network is stable again
Thanks!

The new parameter is just a small feature to have the ability to use a remote xcash-daemon. If the parameter is not specified, the local address<IP_ADDRESS> is assigned. I did it to simplify my local testing. Maybe it can be useful to someone else too, but you can skip it. I'll add a small description to the define_macros.h in the next PR
The really meaningful code to make the dbHash caching located within the databse_functions folder, so you can merge only related files. Other changes are just little prettifications of error messages output to understand debug log more clear.


check if we are properly opening and closing the files

I was recently going through a few python coding guidelines from their official documentation, here is what I found:
Read From a File
Use the with open syntax to read from files. This will automatically close files for you.

Bad:

f = open('file.txt')
a = f.read()
print a
f.close()
Good:

with open('file.txt') as f:
    for line in f:
        print line
The with statement is better because it will ensure you always close the file, even if an exception is raised inside the with block.

See to it if we are properly handling things in here or not.

Yes we are using the with statement everywhere we open a file.


chore: improve logging when fails to connect to a node

This is a bug report/feature or change request/support request
Problem
Sometimes when a user tries to establish connection to a default node
await createLightNode({ defaultBootstrap: true }) and it fails it prints vague log in the console:
examples.waku.org/:1 Uncaught (in promise) Error dialing peer 16Uiu2HAmVkKntsECaYfefR1V2yCR79CegLATuTPE6B9TxgxBiiiA : Error deleting undialable peer 16Uiu2HAmVkKntsECaYfefR1V2yCR79CegLATuTPE6B9TxgxBiiiA from peer store - TypeError: Cannot read properties of undefined (reading '0')

Proposed Solutions
Improve logging: show what operation on the side of js-waku failed and why.
Notes
Probably a follow up to https://github.com/waku-org/js-waku/pull/1380

May need clarification on how to reproduce.

Still seems to be happening. I can easily repro it by opening https://examples.waku.org/light-chat/ and waiting ~2 minutes.

unable to repro :(

Yes because a lot of improvements have been delivered on nwaku to avoid connectiong hogging AND ensure that websocket remains stable.
I would recommend to put an unreachable address on purpose to reproduce the error and then improve the logging.

Tried again - doesn't seem to be happening.


Design authentication code detail page - Hi-Fi and mobile screens

Refer to #29 for an overview of all design related tasks

@Abayolpeter @ti-oluwa . This has been done since
https://www.figma.com/file/UzdIIpsX43I1ZgMETPwLgQ/Authentication-Library?node-id=0%3A1

Was expecting you to submit a link before I close it

https://www.figma.com/file/UzdIIpsX43I1ZgMETPwLgQ/Authentication-Library?node-id=370%3A1985


How to get status code from WebSocketClosedError?

I'm trying to debug why all my websockets keep crashing at the same time. I'm subscribed to a feed.
I get the following error: Debug: WebSocketClosedError("while read(ws|client) Client side closed socket connection - Performed closing handshake.")
I believe this comes from https://github.com/JuliaWeb/WebSockets.jl/blob/0e81f48ab73dcb0d29df3d04539f922f2d4ae10e/src/WebSockets.jl#L480 which in turn is triggered by https://github.com/JuliaWeb/WebSockets.jl/blob/0e81f48ab73dcb0d29df3d04539f922f2d4ae10e/src/WebSockets.jl#L388-L394
It seems like the issue is on the Julia (client) side rather than on the webserver. Any tips for how I might debug? Thank you!

I can see how this is confusing. We have two subtypes of WebSockets. The 'read' function's argument is a WebSocket of the 'client' type. What that means is ambigious - which side of the connection is a client? Are we reading from our end or from the other end? Enabling more debug output will hopefully set that straight.
We know from the message that WebSockets.jl had WebSocketError 1002 or 1006 (the definition set is shown in the code). Either, the other side did something not according to protocol or the connection was lost. To play nice, our side initiated a separate task which will be trying to close the connection in the proper way during the following TIMEOUT_CLOSEHANDSHAKE seconds.
To get details from @debug statements, the simplest way is from the command line:
Users\f> julia -g 2
If you want full clarity, we have an additional log level, @wslog. See, ´examples/count_with_logger.jl´.
I  suppose you have been calling the 'readguarded' function? Use 'read' instead for full debugging sessions - most closing events are normal timeouts from a browser (i.e. from a client) or from a server, and some don't follow the protocol while closing.

@hustf thank you! That's super helpful. And yes indeed, I've been using readguarded and just switched to read.
It turns out there were two issues:

I was writing malformed messages. This led to Debug: ErrorException("WebSocket{MbedTLS.SSLContext} does not support byte I/O") error

I forgot my heardbeat message was commented out. As such, the connection was unceremoniously dropping, and I got a 1006 error.

issue solved, many thanks!!


Fix bug where split was applied on undefined strings

Description
split is causing an error to occur when the contest's automatically generated achievement is clicked on. Probably due to the contest not having a shortDescription.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

How to test

Checklist

[x] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.008%) to 30.816%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/commons/achievement/AchievementView.tsx
0
1
0.0%

src/commons/achievement/view/AchievementViewCompletion.tsx
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.008%

Covered Lines:
3424

Relevant Lines:
10352

💛  - Coveralls


Set up a code coverage tool

A code coverage tool can help us write better tests and have confidence that those tests are effective.
Karma 1 seems to have ability to generate coverage using Istanbul.

Integration with CodeClimate is desirable in this regard.


TemporaryJobs: handle DOCKER_HOST with unix sockets

TemporaryJobs.builder() attempts to set up default values for the
endpoints to connect to (representing the address of the Helios
cluster to talk to), prior to the user setting any endpoints or
HeliosClient of their own.
After checking a few environment variables for which Helios host to talk
to, TemporaryJobs.Builder then checks if DOCKER_HOST is set and uses
it as the host in a http:// URI.
This fails if DOCKER_HOST is a URI to a Unix socket (e.g.
unix:///var/run/docker.sock), such as when using Docker for Mac.
To fix this, change the Builder to ignore DOCKER_HOST values that
start with unix://, and rely on the user to set the endpoints or
HeliosClient to use themselves.

@spotify/helios-team

LGTM
Though ideally TemporaryJobs would forego all the magic Helios-client-discovery logic if someone explicitly passes a client to the Builder.

yeah, it is kind of silly to have all this default logic and construction of things in the constructor of Builder rather than in it's build() method.

:+1:


Special chars in username

Hello!
It's necessary to filter usernames for special chars - when "/" appears in username (for example in OWA logins) there is a problem to parse. I replaced "/" and "" to "-" in filenames.

Good point! Thanks, will add it to the list.


The old PHP version could handle URLs directly

The new Go version should do that too. It's useful for trivial cases.

I have a PR for this now :)

Awesome, thanks! I'll review it this evening :)

@iamthemovie I've issued a PR onto your master branch with a couple of changes I think I'd need before accepting, have a peek: iamthemovie/gron#1


Parity: NSCoding: DateIntervalFormatter

Implement NSCoding for DateIntervalFormatter through new hooks in CFDateIntervalFormatter. This requires fixing several bugs uncovered in the process:

Correctly initialize CFDateIntervalFormatter’s date and time style.

Fix __NSSwiftData to never try to encode itself, matching what the Darwin counterpart does.

NSCalendar needs to check if a coder contains values for a specific key before trying to fetch that key.

Add tests with fixtures. Since time zone data can come from different ICU versions, only compare time zone names.

Prevent fixtures with duplicate identifiers.

Fixes https://bugs.swift.org/browse/SR-10355

@swift-ci please test

@swift-ci please test

@swift-ci please test


fix: fixes crash on invalid arg error

Once this merges I'm going to ahead and put out 1.4.5 since this fixes a crash.
Relates to #277

@homu r+

:pushpin: Commit c78ce12 has been approved by Vinatorul

:hourglass: Testing commit c78ce12 with merge cf37cfb...

:sunny: Test successful - status


Xml improvements

Must be paired with assets update to compile: https://github.com/OutpostUniverse/ophd-assets/pull/1
It looks like the assets are a submodule of this repo, but I had trouble linking them on my machine for some reason.
Related to #830. Not quite a string dictionary but tried to consolidate some of the xml related code.
The last commit is pretty big. I had trouble teasing it into smaller chunks due to the serialization involved. I was experimenting with template functions and enum lookups. Hopefully it looks ok...
This PR will allow someone to change the planet attributes without recompiling the source code.

Looked over it. Generally no objections, looks pretty good. I made a few notes of areas where brace placement is inconsistent with the rest of the code. With that corrected this PR should be good to go.

The unnamed namespace work is a bit hairy due to the underlying structure. There are really 2 different sets of information being represented in Planet.h (the attributes of a planet and how to draw/manipulate in the UI a planet on screen). That logic is partially split between PlanetSelectState and Planet, making it even more complex. I think disentagling that is probably not a good idea in this thread though.
Made the easier style changes in addition to the anonymous namespace. I'll work the other points later.
Thanks for the thorough and quick feedback.

I wasn't thrilled with the results of adding the anonymous namespace. Having to prepend the :: qualifier to some of the functions may cause noise later.
I am complete with updates unless the additions I made need further refinement before merging.

Yeah, maybe I'll look into that as a post-merge thing.


Update README.md about docker usage

Hope this PR could save time for others.
Ran into multiple issues:

docker image on docker hub is no longer valid after recent upgrade to Tensorflow r1.0
nvidia-docker seems to be a must, it takes care to mount host CUDA and GPU driver files correctly into container. Otherwise, will run into strange exception complaining can't load libcuda.so.1, and google results would confuse you
for reason I haven't figure out, must make cython module within container. Otherwise, will get import error when other python script try to import the utility module.

thanks!


Draft: Fix: Use merge_environment_settings in RESTStream - [opened]

Merges requests-preparedrequest-mergeenvironmentsettings -> main
Migrated from GitLab: https://gitlab.com/meltano/sdk/-/merge_requests/256
GitHub Issue: https://github.com/meltano/sdk/issues/345

Hi guys.
I'd like to revisit this topic.
As I start using more SDK based RESTStream taps from the Meltano Hub, I now find myself having to:

clone the tap
update the dependency for singer-sdk to my fork with the merge_environment_settings method
build the tap
install my build of the tap

@edgarrmondragon You had some comments in the original Gitlab issue discussion about making merge_environment_settings configurable by the user.
Having a bit more meltano experience under my belt now after a few months, I understand the meltano approach a bit better.
Those changes that you suggested do make sense to me now.
I'll test out if the get_request_settings() logic that you proposed will work the way a meltano user expects them to work, which would be:

If either http_proxy or https_proxy env vars are present, the SDK based tap's Session.send() method will respect them (btw. I've had some anecdotal experience from a colleague that even without merge_environment_settings, Session.send() already seems to use http_proxy and https_proxy which seems to be by design .. see [1])
If neither http_proxy nor https_proxy are set, the SDK based tap's Session.send() method will not use any user-configured proxies. (transparent intercepting middleman proxies will obviously still intercept the HTTP requests)
If either REQUESTS_CA_BUNDLE or CURL_CA_BUNDLE env vars are present, the SDK based tap's Session.send() method will respect them and TLS inspection of any middleman proxies will function correctly.
It should never be possible to disable TLS verification through configuration options. This is not a feature that the requests library or libcurl provides. And Meltano SDK should not provide it either.

[1] https://github.com/psf/requests/issues/6108

I'll test out if the get_request_settings() logic that you proposed will work the way a meltano user expects them to work

Nice. Thanks for revisiting @cwegener!

This could also be better addressed by #1649


unify checking for @fields if nil or empty with active support blank,…

… in resource_serializer#requested_fields
This is a very minimal change. Please don't take it as an offense I don't want to change anything in other developers code (especially someone more experienced than me). I was just reading through the code and thought that checking  @fields.nil? || @fields.empty? is unnecessary when you already have ActiveSupport with his blank?.

@ristovskiv Thanks!


[WIP] Disable reconciliation in Replicated Mode

When you are having some trouble in your environment sometime is a good
choice just keep all quite during troubleshooting and debugging
time.
For this reason I was thinking about a flag to disable reconciliation in
a service in Replicated mode.
This feature allow people to figure out when something is wrong without
deal with the traffic generated by the reconciliation process.
Reconciliation is enable by default but you can choice to switch it off
with:
./swarmctl service update serviceName --no-reconcilable

Still to do

[ ] I am still having some problem with --no-reconcilable flag.

23:55 $ ./bin/swarmctl service update serviceName --no-reconcilable
Error: no changes detected

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "feature/disable-reconciliation" git@github.com:gianarb/swarmkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@gianarb Thanks for your proposal! I'd like to review the use cases first. Can you present your use case and how stopping reconciliation helps.

Hello @dongluochen thank you for your time. My use case is just to make simple troubleshooting a production environment. Your metrics can be confused if your environment in creating containers in the meantime.
I was working on this feature a log time ago but I left my branch on my laptop. I started to work on that when I was reading some story with k8s and SRE. It has this feature and IMHO can help to keep quite an environment during investigation.
I push my branch when I saw this PR:
https://github.com/docker/docker/issues/30981
And @aaronlehmann was speaking about this feature too.

I am afraid that here needs a rebase though. @gianarb

@allencloud Yes, it's there from a long time. I will do asap

Thanks @gianarb . I like the concept quite well.
And I have such situation that when using docker service update to finish a rolling update action. Then sometimes we will need to stop the rolling update action.
I think what I want is similar to this PR, right? If that, just mention that here 😄

Yes it's going to cover that case too. I am just changing house and job. It means that I am busy for the next couple of days. but I am going to do something about this feature next week :)

ping @gianarb :innocent:


Trying to patch long function without copying the old one

Hi, I am trying to find a way to add one line in the org-store-link function, but because of my unfamiliarity with elisp I am in the dark :)
I would be glad for any help or direction.
Here is my template attempt and defun attempt.
Patch is based on this answer
https://stackoverflow.com/questions/67604486/org-store-link-with-headline-as-description-using-custom-id-property
My attempt at template
(el-patch-define-template
  (defun (el-patch-swap org-store-link test-org-store-link))
  (el-patch-concat
...
    (el-patch-swap
      "(setq custom-id (org-entry-get nil \"CUSTOM_ID\"))"
      "((setq custom-id (org-entry-get nil \"CUSTOM_ID\"))
          (setq desc (org-link--normalize-string (org-get-heading t t t t)))
            (message \"patched funcion test message\")"

)
...
)
)

My attempt with function
(eval-after-load 'org
(el-patch-defun (el-patch-swap (old new) ()
(el-patch-concat
...
(el-patch-swap
         ((setq custom-id (org-entry-get nil "CUSTOM_ID"))
          (setq cpltxt
    (concat "file:"
      (abbreviate-file-name
       (buffer-file-name (buffer-base-buffer)))
      "::#" custom-id)
    link cpltxt))
         ((setq custom-id (org-entry-get nil "CUSTOM_ID"))
          (setq desc (org-link--normalize-string (org-get-heading t t t t)))
          (setq cpltxt
    (concat "file:"
      (abbreviate-file-name
       (buffer-file-name (buffer-base-buffer)))
      "::#" custom-id)
    link cpltxt))
) ;; end el-patch swap
...
) ;;end el patch concat
) ;;end el patch defun
) ;;end eval after load org

What error do you receive? Or what is the expected/actual behavior?

in el-patch-defun instead of (old new) should be (org-store-link new-org-store-link)
(eval-after-load 'org
(el-patch-defun (el-patch-swap (org-store-link new-org-store-link) ()
(el-patch-concat
...
(el-patch-swap
         ((setq custom-id (org-entry-get nil "CUSTOM_ID"))
          (setq cpltxt
    (concat "file:"
      (abbreviate-file-name
       (buffer-file-name (buffer-base-buffer)))
      "::#" custom-id)
    link cpltxt))
         ((setq custom-id (org-entry-get nil "CUSTOM_ID"))
          (setq desc (org-link--normalize-string (org-get-heading t t t t)))
          (setq cpltxt
    (concat "file:"
      (abbreviate-file-name
       (buffer-file-name (buffer-base-buffer)))
      "::#" custom-id)
    link cpltxt))
) ;; end el-patch swap
...
) ;;end el patch concat
) ;;end el patch defun
) ;;end eval after load org

I get this error
`Debugger entered--Lisp error: (error "Too many arguments (3) in for ‘el-patch-swap’")
  signal(error ("Too many arguments (3) in for ‘el-patch-swap’"))
  error("Too many arguments (%d) in for `el-patch-swap'" 3)

which look like the text I assume is used for search and replace (?) is being interpreted as 3 parameters instead of 2
el-patch template
I am trying to evaluate with
el-patch-eval-template

and i get
el-patch--resolve-template: At least one template did not match any form

from that I think that something is not matching any form
Thanx

For the non-template version, I've reindented your code:
(eval-after-load 'org
  (el-patch-defun (el-patch-swap (old new) ()
                                 (el-patch-concat
                                   ...
                                   (el-patch-swap
                                     ((setq custom-id (org-entry-get nil "CUSTOM_ID"))
                                      (setq cpltxt
                                            (concat "file:"
                                                    (abbreviate-file-name
                                                     (buffer-file-name (buffer-base-buffer)))
                                                    "::#" custom-id)
                                            link cpltxt))
                                     ((setq custom-id (org-entry-get nil "CUSTOM_ID"))
                                      (setq desc (org-link--normalize-string (org-get-heading t t t t)))
                                      (setq cpltxt
                                            (concat "file:"
                                                    (abbreviate-file-name
                                                     (buffer-file-name (buffer-base-buffer)))
                                                    "::#" custom-id)
                                            link cpltxt))
                                     ) ;; end el-patch swap
                                   ...
                                   ) ;;end el patch concat
                                 ) ;;end el patch defun
    ) ;;end eval after load org

Looking at it here, you can see that you've passed three arguments to el-patch-swap rather than two, as the error message describes. Generally speaking, the syntax you've used looks very different from what I would expect (e.g., using el-patch-concat on things that aren't strings, missing the function name, etc.). Perhaps I don't understand what behavior you're expecting from el-patch-defun?
For the templated version, here is the code I'm looking at:
(el-patch-define-template
 (defun (el-patch-swap org-store-link test-org-store-link))
 (el-patch-concat
   ...
   (el-patch-swap
     "(setq custom-id (org-entry-get nil \"CUSTOM_ID\"))"
     "((setq custom-id (org-entry-get nil \"CUSTOM_ID\"))
          (setq desc (org-link--normalize-string (org-get-heading t t t t)))
            (message \"patched funcion test message\")"

     )
   ...
   )
 )

It looks like you're trying to substitute s-expressions as if they were strings. That won't work; you need to use the other el-patch primitives for that.

I think this is the template you are after
(el-patch-define-and-eval-template
 (defun (el-patch-swap org-store-link test-org-store-link))
 ((setq custom-id (org-entry-get nil "CUSTOM_ID"))
  (el-patch-add
    (setq desc (org-link--normalize-string (org-get-heading t t t t)))
    (message "patched funcion test message"))
  ...))

since the "fix" is just adding forms

This thread is being closed automatically by Tidier because it is labeled with "waiting on response" and has not seen any activity for 90 days. But don't worry—if you have any information that might advance the discussion, leave a comment and I will be happy to reopen the thread :)


Add support for PSR17 factories

I decided to bump PHP version requirement because they are super dead and travis wouldn't run on them.. like "This PHP version is not supported".

Sure!
Thank you for the review


PiPPY won't work with crunchyroll [Vivaldi]

Using the Vivaldi browser, the videos on the Crunchyroll website aren't being detected as video feed by PiPPY, ecen though they are playing on the currently open tab, my bet would be that it's because of their custom player.
I don't know if this issue is also present in Chrome.

Hey,
Under the hood it' the standard html5 player so it should work fine but it clearly doesn't on this website, I'll need to take a look at this, thank you.


FIX for Issue #152

Fix for this issue: https://github.com/PowerShell/xActiveDirectory/issues/152
Functionality of xADGroup is only changed when setting Property 'MembershipAttribute' with a value of 'DistinguishedName'.
When 'DistinguishedName' is used, each Group Member DN String is evaluated to determine the AD Domain of the Group Member Object and the ObjectClass.  Then Get-ADComputer,Get-ADGroup or Get-ADUser is called, specifying the appropriate Domain to query.  Once the Object is retrieved then Add-ADGroupMember is able to successfully add the members, even if they exist in another domain.

This change is

@RobBiddle Sorry that it took so long to review you PR. Could you please add unit tests that tests this change?

Labeling as abandoned since it has gone 14 days until last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again.

Hi @johlju , how can I continue the PR? My customer has the same requirement.
I have taken all changes from @RobBiddle and added the necessary test cases here: https://github.com/nyanhp/xActiveDirectory/tree/multidomainmembers
I have of course branched off the current dev branch.

You can send in another PR. Reference this PR Close #174.
Please also read here https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md#how-to-continue-working-on-a-pull-request-pr-when-an-author-contributor-is-unable-to-complete-it


TypeError: decode() argument 2 must be str, not None

Hi!
I try to open some video file and I get an error:
>>> import av
>>> av.open('test_video_38.mp4')
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "av\container\core.pyx", line 249, in av.container.core.open
  File "av\container\input.pyx", line 50, in av.container.input.InputContainer.__cinit__
  File "av\stream.pyx", line 45, in av.stream.wrap_stream
  File "av\stream.pyx", line 64, in av.stream.Stream._init
  File "av\utils.pyx", line 137, in av.utils.avdict_to_dict
  File "av\utils.pyx", line 120, in av.utils._decode
TypeError: decode() argument 2 must be str, not None

The video file is available on link:
https://yadi.sk/i/bGzjHbvC3LtBf7
Also I get media info about the file by MediaInfo library:
https://paste.fedoraproject.org/paste/i5-mJObDMPGkn3bo~Kht2w
It seems that the file is OK.
Why PyAV cannot open the file?

I experience the same issue. I tryed applying the patch suggested by @mkfmnn (initializing ContainerProxy after metadata) but I still get the same error.

I am experiencing the same issue. I tried applying the patch suggested by @mkfmnn (initializing ContainerProxy after metadata in core.pyx) but it did not fix the problem for me. I am running the latest code from github.

I decided to do a little bit of debugging by checking out earlier commits, but the results are strange:
I went back through several commits to aeca78d (from 5/6/2017) which still failed
then I jumped back to 41ab2a94 which worked...
BUT then I went back to aeca78d and this time it WORKED ... and then I went back to the head and it ALSO WORKED.
My guess is that there is some race condition in the build system, perhaps in initialization of the c libraries, that gets triggered or not depending on your luck when building the libraries, but I would have to do more testing to validate this hunch. Hopefully this report helps though.

@jmoraleda, is it possible you're picking up build artifacts from a previous build, or perhaps from a different location on your filesystem? Can you retry my patch after re-running make clean-all? I'm pretty sure that this error (which is Python 3-specific) should be completely deterministic and not based on library initialization order.

@mkfmnn Thank you for your quick reply!
Yes it is possible that I was picking up old artifacts as I have been using the version from github for a while and I updated today after a few weeks, but I did not do a make clean.
Yes. I am using python3 (I replace all python calls  in Makefile with calls to python3. Is there a better way?)
After I run make clean-all and then make on the head of master the bug did not appear, so I did not get to try if the patch would make any difference.


Logical changes for determining whether or not the link is internal or external

Previously there were a few bugs with this relating to assumptions around the TLD.
You could do http://domain.com fine, but it would evaluate com.au instead of domain.com if you had http://domain.com.au for example.
This logical fix expands on possiblities however it still makes assumptions, but should be more forgiving than just a single TLD.
The order of determining if tracking a file has also been changed since there were assumptions being made that a file would always be hosted at the current domain.
This had consequences of chaining the external domain on to the internal domain like so : http://internal.com/something/http://external.com/file.txt

Hi Neumes,
Thanks for the PR.
I agree there is a flaw in these scripts regarding the domain matching. IMHO it would be better to match the document.domain to the href.replace(/^https?\:\/\//i, ''). That way we would have a general solution matching all URLs without hard coding any SLDs.
With the tracking of files on other domains you are correct, the concatenation is wrong. But I would rather do something like elEv.loc = (isThisDomain ? baseHref : '') + href; to avoid the concatenation. I'm not sure why the change of order solved it in your case.
What are you thoughts? Would you be able to update the PR?
Thank you very much.

The regex approach looks much better, although I think I explicitly avoided it due to personal reluctance to look into it (tp me, regex is that monster which I didn't particularly want to tame). I can play around with what you've given me locally and commit it when it's behaving.
In regards to the change in order, I only worked around changing the order due to the fact the js was making various assumptions based on the file being hosted locally (although I can see a possible issue if the file url given was absolute instead of relative (?)). By swapping them round, it would simply evaluate the link as being external before being a file as I didn't have too much time to fixing it "properly" per se. I can see how you may want to track a link being a file download if it's external, so I'll fix that up too.
I'll make these adjustments shortly and push up the changes.

Hi Neumes,
Any progress on this?
Cheers


NanBool introduced

Introduces a parameter NanBool, a boolean which if True, when calculating the  lower envelope during the construction of the consumption function, NA's are omitted. If cFunc is extending below mNrmMin, set NanBool to False to rectify. Default is True.
Solves #155 .
NanBool is a consumer parameter and is introduced to ConsIndShockModel. Therefore it also appears in the models which inherit ConsIndShockModel's characteristics.
It is also introduced into the ConsumerParameters module: it is imported as True if one uses the default parameter libraries.
(DemArk will need to be updated with a few lines setting NanBool to True whenever the the notebooks spell out the whole library instead of importing the defaults. PR to follow shortly).

An very short example showing that it works is herehttps://github.com/TimMunday/WorkARK/blob/master/ConsIndShock%20lower%20bound.ipynb

Good job, but you actually did too much in this case.

Main thing: NanBool should not be an input for AgentType subclasses, only for LowerEnvelope and UpperEnvelope (and their 2D and 3D analogues).  There is no situation in which a user would want to do

MyType = IndShockConsumerType(params,params,params,NanBool=True)
That says, "make an IndShockConsumerType, but make its cFuncs wrong below mNrmMin."  You're fixing a bug; there's no reason to give the user the option of reintroducing the bug.

In ConsIndShockModel.py, the only line you needed to change was 906, to be:

cFuncNow = LowerEnvelope(cFuncNowUnc, self.cFuncNowCnst, NanBool = False)
That's it.  None of the other model files need to change at all.

To fit with the style of other inputs in HARK.interpolation, please rename to nan_bool or ignore_nan or something like that.

ADDITIONAL COMMENTS:

Your code works, but it can be done with many fewer lines.  Rather than have an if-else at eval time, just put this in __init__:

if ignore_nan:
~~self.compare = np.nanmin
~~self.argcompare = np.nanargmin
else:
~~self.compare = np.min
~~self.argcompare = np.argmin
Then just have the eval method use self.compare rather than np.nanmin.  Each instance will take ~8 bytes more memory (I forget how big a function pointer is), but that's ok.

The _evalAndDer methods need to be fixed as well.  If you use the snippet I just posted, you can use self.argcompare.  Looking at the code, I now see that _evalAndDer for UpperEnvelope is bugged anyway.  As written, LowerEnvelope._evalAndDer ignores NaNs, but UpperEnvelope uses them... and turns them into infinities (which will be returned) as the output y.  Whoops.

This is really small, but I also just noticed that the _der methods should call the private/internal method _evalAndDer, not the public eval_with_derivative.  My bad.

Apologies! I got a bit carried away it seems...
I'll rework and come back to you.

No worries: you got a grand tour of HARK!

Great. I am away this weekend, but will look at this Sunday night (and
hopefully a backlog of other PRs).
On Fri, Sep 7, 2018, 1:20 PM TimMunday<EMAIL_ADDRESS>wrote:

This should be better now
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/pull/193#issuecomment-419508443, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANUQFRITIN1ABhmztKpNpDtyLNFz6xCyks5uYqrwgaJpZM4WZIgC
.

I will look at this later today, around 5pm eastern.

I forgot to merge this way back.  So much old work on HARK...


jax.numpy.linalg.eigh produces different results for full vs triangular matrices

Description
import numpy as np
import jax.numpy as jnp

A = jax.random.normal(jax.random.PRNGKey(0), (100, 100))
H = A + A.T

lam1, y1 = jnp.linalg.eigh(H)
lam2, y2 = jnp.linalg.eigh(jnp.tril(H))
print(jnp.linalg.norm(lam1 - lam2)) # 70.34676

lam1, y1 = jnp.linalg.eigh(H, UPLO="U")
lam2, y2 = jnp.linalg.eigh(jnp.triu(H), UPLO="U")
print(jnp.linalg.norm(lam1 - lam2)) # 70.34677

lam1, y1 = np.linalg.eigh(H)
lam2, y2 = np.linalg.eigh(np.tril(H))
print(np.linalg.norm(lam1 - lam2)) # 0.0

lam1, y1 = np.linalg.eigh(H, UPLO="U")
lam2, y2 = np.linalg.eigh(np.triu(H), UPLO="U")
print(np.linalg.norm(lam1 - lam2)) # 0.0

What jax/jaxlib version are you using?
jax v0.3.21, jaxlib 0.3.20+cuda11.cudnn805
Which accelerator(s) are you using?
CPU
Additional system info
Google colab
NVIDIA GPU info
No response

Never mind, I see the symmetrize_input=True parameter now...though it doesn't have a description in the docs and is easily overlooked. Why is the default to symmetrize when BLAS only uses the lower/upper part and it's common practice to only evaluate one of these halves?

Thanks for the report – the issue is also reported in #9473

We should make sure to document this behavior if we're not going to match numpy's

This comment about jax.numpy.linalg.cholesky pretty much explains it. I agree we should document it, though I think this may then be a duplicate of #12516. We might even want to consider changing the default, though a reason I like the current default is thatgrad(lambda x: f(jax.numpy.linalg.eigh(x)))(symmetric_x) is itself symmetric, while with symmetrize_input=False it would not be.

Closing as a duplicate of #9473


[type:feat] support properties

Codecov Report

Merging #102 (f4f7424) into main (bc63af1) will decrease coverage by 0.70%.
The diff coverage is 71.11%.

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   86.49%   85.78%   -0.71%
==========================================
  Files          27       28       +1
  Lines         933      978      +45
==========================================
+ Hits          807      839      +32
- Misses         96      104       +8
- Partials       30       35       +5

Impacted Files
Coverage Δ

core/idutil.go
100.00% <ø> (ø)

core/propsutil.go
71.11% <71.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc63af1...f4f7424. Read the comment docs.


On Planet Rework

As a player when I go into the planet I want it to be more realistic, since the whole game have a realistic feeling, for example different animals with different shapes and sizes, and a player model.

Moving issue to Palin


Fuse.Drawing.Surface: re-introduce IsEmptyPath-hack

In 6bed36f, we dropped the incorrect IsEmptyPath-hack because we
had a more directed fix. However, this doesn't seem to cover all
cases. So let's reintroduce a less broken version of this check
(e.g one that checks if both width and height is zero) just to
be safe.
We should probably try to get rid of this at the benefit of a more
targetted fix later, but let's not try to deal with that right now.
This fixes a crash on startup in ManualTestingApp on dotnet-targets.

Just to be clear, this triggered in the ImageFill-block inside DotNetSurface.StrokePath. The failure happens while trying to create the Bitmap that were to be inserted into _tiledImages. So to do this cleanly, we need a dedicated guard inside that code-path.
This approach here is just an attempt to be as conservative as we can, by going back to what we did before (modulo that single-dimension change, which would make us start failing the new tests).


add import iso script to release assets

What type of PR is this?
/kind feature
What this PR does / why we need it:
add import iso script to release assets
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
https://github.com/ErikJiang/kubean/actions/runs/5274371766/jobs/9538775444

/lgtm

/lgtm


Let user navigate to Front matter

As a checker, I want to be able to navigate to the Front matter of the TNs.

@birchamp Does this also apply to scripture verses?  What is the design here - do we change the bible reference RCL to add front to selectors?

Some Bible software (e.g., Paratext and others) uses verse 0 (zero) for introductory material. I see in the TNs, we have front:intro and 1:intro before 1:1. So that could be 0:0, 1:0, and 1:1 respectively? Not wonderful, but probably not huge to implement.

@birchamp what's the behavior when there is no front/intro data. Can the user navigate to the front if there's no data?
Use Front:Intro.

Just want to bump this up a little as it is needed for Psalm titles (A psalm of David, when he fled from the face of Absalom his son... etc)

@birchamp Also need an issue to add alignment of front matter.


Support AppVeyor for CI & enable CI testing

AppVeyor is free for open source project and runs on a Windows Server VM.  It has Visual Studio 2015 installed and allows for other software install as needed for building and testing.  It also supports automatic deployment to NuGet and creates a release for GitHub.
For this project I have installed the DocumentDB Emulator, and queue both unit and integration tests to run on CI.  If the tests fail then the build will fail.  If everything passes then it will create a tag and release on GitHub, and release to NuGet.
Some setup is still required!

Create AppVeyor project for AspNetCore.Identity.DocumentDB
Encrypt your NuGet api key and GitHub access key via https://ci.appveyor.com/tools/encrypt
Modify the appveyor.yml file and replace any instance of InsertEncryptedStringHere with the new string from AppVeyor.

If you need any help with maintaining the appveyor job feel free to add me as a collaborator.  My AppVeyor name is the same as my GitHub name.

Thanks once again!
AppVeyor's support for installing MSI's is a great feature I was looking for in some other CI tools but couldn't find.
The AppVeyor build is generally working now but the configuration seems to be somewhat faulty.
I added you as collaborator, maybe you can look into it.

Found the issue and fixed it in 0de0438eab7109a5b564d7ccc64166339535af25.
There is still some error with Git tag creation I'll look into now.

Good catch! I actually found that syntax a few months back and couldn't figure it out again recently.

Git tag creation is working now as well.
Artifacts are not properly stored though and ppVeyor is also only building for the .NETFramework and not .NETStandard target.

Hmm, does it build all of the frameworks when you do a dotnet build src\aspnetcore.identity.documentdb?

it looks like it's building both dlls:
dotnet build "src\AspNetCore.Identity.DocumentDB" -c ${env:CONFIGURATION} --version-suffix ${env:APPVEYOR_BUILD_NUMBER}
Project AspNetCore.Identity.DocumentDB (.NETFramework,Version=v4.5.1) will be compiled because expected outputs are missing
Compiling AspNetCore.Identity.DocumentDB for .NETFramework,Version=v4.5.1
Compilation succeeded.
    0 Warning(s)
    0 Error(s)
Time elapsed 00:00:03.3805208

Project AspNetCore.Identity.DocumentDB (.NETStandard,Version=v1.6) will be compiled because expected outputs are missing
Compiling AspNetCore.Identity.DocumentDB for .NETStandard,Version=v1.6
Compilation succeeded.
    0 Warning(s)
    0 Error(s)
Time elapsed 00:00:01.2621811

Ahh I know what it is....  I'll submit another PR.

I think I overlooked .NETStandard in the previous builds. Seems to be ok.


Warning in HTML2React should be fixed

child of https://github.com/wp-pwa/saturn-theme/issues/48

:tada: This issue has been resolved in version 0.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"Illegal character in path" when building from character encoded directories

🐞 Bug report
Command (mark with an x)

- [ ] new
- [X] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

 Yes, the previous version in which this bug was not present was: ....
7
Description
 A clear and concise description of the problem...
If I build from a directory called angular, my project builds fine. If the directory is called angular%2f, however, ng build fails.
🔬 Minimal Reproduction
This problem arose on Jenkins while using CI and the standard git flow naming conventions (eg. release/2019.6 becoming release%2f2019.6)
🔥 Exception or Error

ERROR in ./src/styles.scss (./node_modules/@angular-devkit/build-angular/src/angular-cli-files/plugins/raw-css-loader.js!./node_modules/postcss-loader/src??embedded!./node_modules/sass-loader/lib/load
er.js??ref--13-3!./src/styles.scss)
Module build failed (from ./node_modules/sass-loader/lib/loader.js):
Unsupported operation: Illegal character in path: angular/

Note how it's parsing the directory as angular/ instead of angular%2f.
🌍 Your Environment

Angular CLI: 8.0.2
Node: 10.16.0
OS: win32 x64
Angular: 8.0.0
... animations, cdk, common, compiler, compiler-cli, core, forms
... material, material-moment-adapter, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.800.2
@angular-devkit/build-angular     0.800.2
@angular-devkit/build-optimizer   0.800.2
@angular-devkit/build-webpack     0.800.2
@angular-devkit/core              8.0.2
@angular-devkit/schematics        8.0.2
@angular/cli                      8.0.2
@angular/flex-layout              8.0.0-beta.26
@ngtools/webpack                  8.0.2
@nguniversal/express-engine       7.1.1
@schematics/angular               8.0.2
@schematics/update                0.800.2
rxjs                              6.5.2
typescript                        3.4.5
webpack                           4.30.0

Anything else relevant?

I'm sorry, but this issue is not caused by Angular CLI. Please contact the author(s) of the dart sass  project or file an issue on their issue tracker.


Allow or deny sorting capability on specific models

This PR adds the ability to specify on a sortable model which other models the list should or shouldn't be sorted on via the use of the $sortable list keys only_sort_on or dont_sort_on
For example in a A HasMany B HasMany C
A contain a HasMany B as well as a HasManyThrough C
You don't want to sort C via the A relationship that the HasManyThrough provides.

Hi! Thanks for this PR. I tested it and found some errors. Had to rework some of it. Can you test out version 1.4.10 and confirm it still works for you?


Rails/RedundantPresenceValidationOnBelongsTo should be marked as unsafe for auto-correct

Is your feature request related to a problem? Please describe.
RedundantPresenceValidationOnBelongsTo is currently marked as safe for auto-correction. This is incorrect, as removing the validation changes the error message that is generated when the association is missing.
The default error message when using validates :foo, presence: true is "foo can't be blank".
The default error message for a required belongs_to :foo without the presence validation is "foo must exist".
This can break tests/behavior that rely on the error message.
Describe the solution you'd like
RedundantPresenceValidationOnBelongsTo should be marked as unsafe for auto-correct.
Describe alternatives you've considered
Additional context
Here's an example spec failure, using ThoughtBot's shoulda_matchers, after the auto-correction was applied:
     Failure/Error: it { is_expected.to validate_presence_of(:location) }

       Expected Category to validate that :location cannot be
       empty/falsy, but this could not be proved.
         After setting :location to ‹nil›, the matcher expected the
         Category to be invalid and to produce the validation error
         "can't be blank" on :location. The record was indeed invalid, but it
         produced these validation errors instead:

         * taxonomy: ["must exist"]

         You're getting this error because ActiveRecord is configured to add a
         presence validation to all `belongs_to` associations, and this
         includes yours. *This* presence validation doesn't use "can't be
         blank", the usual validation message, but "must exist" instead.

         With that said, did you know that the `belong_to` matcher can test
         this validation for you? Instead of using `validate_presence_of`, try
         the following instead:

             it { should belong_to(:location) }

I'm not convinced that validate_presence_of failure itself is indicative.
Just like validates ..., presence: true, it is redundant, as belong_to implies the required option.
As for the error message itself, "can't be blank" vs "must exist", I agree. It affects the error message shown to the end users, and changing it blindly may be problematic in some cases. E.g. when errors.messages.blank is properly translated to languages the project supports, while errors.messages.required only has the default English translation.
Would you like to send a PR to change the cop's SafeAutoCorrect setting to false?

@pirj will do so shortly


fix: fix BrowserFetcher._getFolderPath to support relative install paths

This patch fixes the BrowserFetcher._getFolderPath method so that it supports relative download paths using PUPPETEER_DOWNLOAD_PATH or npm config
Issues: #7592

@googlebot I signed it!

@nadhirhb Thanks for your contribution!


Create a diagram that shows the communication steps that implement a data ingest operation

Phil will put his talk and Nick's poster in HIVE-IEC-PSC Google Drive folder:
https://drive.google.com/drive/folders/15cP8zziUKF7kvQHPEnDZf1wHpV7ZsxNe

Collect all these diagrams in @pdblood 's space on google drive.

Should https://docs.google.com/drawings/d/1Cicn-JUVU9QmfsP0CHtGPJkqCe08DlENlKR02leOiLg/edit point to this, for people that want more details about what happens behind the scenes?

Complete


Add an RPC method returning % of weight of finality signatures attesting to a deploy/block

There needs to exist a simple way for clients to detect whether a particular deploy/block is safe to trust. There is a finalization phenomenon inside Consensus that occurs when enough validators have formed a quorum – had seen each other see a particular block. This has a particular disadvantage in that a client has to trust the node that told it about the finalization event since it [the client] itself can't observe the finality. There is a way for clients to detect finality in a trustless way – finality signatures.
Add an RPC endpoint get_finalization_status(block_hash|deploy_hash) returning:

a value between 0 and 100 which is a % (by weight) of validators from which we have received finality signatures for that particular block/deploy,
set of the finality signatures that sign over that block

WARNING: Just because node is returning finality signatures now it doesn't mean that any node can be trusted blindly. Clients should verify that signatures are correct and indeed created by active validators from the proper era. This can be done by cross-checking with another node(s) and cryptographically verifying the signatures correctness in the client.
NOTE: In the spirit of not adding non-essential, client-facing functionalities to the node itself, this particular feature could (and probably should) be implemented in a 2nd layer service that consumes the event stream.

@Fraser999  should we do this - if yes (need to add to epic)


Cannot set property '_modelCache' of undefined

After updating to the latest version I had to manually add the Criteria model file but now I'm getting the following error.
error: TypeError: Cannot set property '_modelCache' of undefined
    at Object.require.createModels.bind.then.then.roles (/candb/node_modules/sails-permissions/api/hooks/sails-permissions.js:64:52)
    at Object.tryCatcher (/candb/node_modules/bluebird/js/main/util.js:24:31)
    at Promise._settlePromiseFromHandler (/candb/node_modules/bluebird/js/main/promise.js:454:31)
    at Promise._settlePromiseAt (/candb/node_modules/bluebird/js/main/promise.js:530:18)
    at Async._drainQueue (/candb/node_modules/bluebird/js/main/async.js:182:12)
    at Async._drainQueues (/candb/node_modules/bluebird/js/main/async.js:187:10)
    at Async.drainQueues (/candb/node_modules/bluebird/js/main/async.js:15:14)
    at process._tickDomainCallback (node.js:492:13) [TypeError: Cannot set property '_modelCache' of undefined]

OK just tried on a clean app with no issues, so any suggestions as to what's causing this so I can fix it

OK looks like it need to be sails v11 to work properly

Ah, yes. Unfortunately npm decided to get pedantic about peerDependencies so I removed the sails requirement from package.json. The latest version of sails-permissions does require sails 0.11

I have sails version 11.2 and still have the error

Requires 0.11 or requires 0.11+  ?

@tjwebb I was under the impression that<EMAIL_ADDRESS>and<EMAIL_ADDRESS>both depend on<EMAIL_ADDRESS>since marlinspike is required.  What are the recommended versions for everything then if this isn't the case?

I still have this error after tryting to follow the tutorial from here
My package.json looks like this
"dependencies": {
    "bcryptjs": "^2.3.0",
    "ejs": "~0.8.4",
    "grunt": "0.4.2",
    "grunt-contrib-clean": "~0.5.0",
    "grunt-contrib-coffee": "~0.10.1",
    "grunt-contrib-concat": "~0.3.0",
    "grunt-contrib-copy": "~0.5.0",
    "grunt-contrib-cssmin": "~0.9.0",
    "grunt-contrib-jst": "~0.6.0",
    "grunt-contrib-less": "0.11.1",
    "grunt-contrib-uglify": "~0.4.0",
    "grunt-contrib-watch": "~0.5.3",
    "grunt-sails-linker": "~0.9.5",
    "grunt-sync": "~0.0.4",
    "include-all": "~0.1.3",
    "lodash": "^3.10.1",
    "passport": "^0.3.2",
    "passport-facebook": "^2.0.0",
    "passport-google-oauth": "^0.2.0",
    "passport-http-bearer": "^1.0.1",
    "passport-local": "^1.0.0",
    "rc": "~0.5.0",
    "sails": "~0.11.3",
    "sails-auth": "~2.1.1",
    "sails-disk": "~0.10.0",
    "sails-generate-auth": "^0.3.1",
    "sails-permissions": "~2.1.11",
    "suncalc": "^1.7.0",
    "validator": "^4.4.0"
  }

$ node -v
v4.2.3

Here's the complete log
Thanks

@andrasi I was able to get it working with<EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS> Also to fix this _modelCache issue I had to create a config/installedHooks.js file containing:

Ok, I'll give it a try. For the moment I've got it running by downgrading both sails-permissions and sails-auth.

@khchan  ur solution removed the error: TypeError: Cannot set property '_modelCache' of undefined
but now this error is coming: error: TypeError: Cannot set property 'protocols' of undefined

@khchan Your solution worked for me. Thanks


fix bug when failing to get user's posts

It seems a bug was introduced in a refactor causing the script to crash when failing to find an user on mastodon.

Thank you!


Add Plan.all support

Now that plans come through properly from the API here is support for Plan.all
I haven't added integration tests yet. As far as I can tell you're testing against your own sandbox? Either you could let me know what data you have in the sandbox for plans, or if you'd like to add some tests for this then that'd be welcome.
Hope this helps :)

@sorentwo Thanks I'll fix these things :)

@sorentwo You'll have to let me know if the tests I've added are close enough to what you're looking for. :)

Merged in @samueljseay, thanks again! Made use of the wonderful "Squash and Merge" feature too.


Support referencing another recipe / linking

For example, consider a simple recipe for baked salmon, and then a meal recipe that says to use that recipe, then do other things for sides. It would be nice to be able to do something like:
Prepare the salmon according to [this recipe](/Simple Salmon Bake.cook).

Bake the @potatoes{2} for ~{30%minutes}.

Let's move discussion about this to https://github.com/cooklang/spec/issues/10

Closing as duplicate


Make this instruction more clear

kubectl create secret generic my-secrets
--from-literal=hub0-cs=''
Once I figure out how to find the iot-hub-owner string I'll be able to create PR a fix. but I can't figure out how to find the string in the portal

Thanks for pointing out. I will add some links in the quickstart to get started with IoT Hub and IoT Edge.


How to make appx a "Silent" installer

I am currently in contact with windows desktop bridge consultant trying to get my app in the store. I am using electron-forge that is using electron-windows-store for appx and the consultant is telling me that the install needs to be silent and he is running into problems with his review tool because it's not
Any one have any idea what he means or how I could make it "silent"

Since Slack is in the store and uses this package, I'm afraid you'll have to work through this with your consultant...


how to create a wss ?

Hi folks, Aedes is amazing.
I have a question. how to create a wss connection?
I can create a standard ws, and tcp TLS, but I don´t know how to create a wss.

@xiclopex ,
its the same as ws, just require https module instead of http and specify your certificates in options.

https://nodejs.org/api/https.html#https_https_createserver_options_requestlistener

Closing, as it should be solved.


Accessing the json root of a vault kv2 secret

I'm having trouble managing to use the root of a vault secret. I.E. I want to access the entire vault secret as json, rather than accessing only a single key within a json secret. Either this is a bug in the plugin that this is unattainable, or else it's a documentation bug, because I can't find an example anywhere in the documentation on how to do this.
Looking up jsonPath I managed to determine that {@} would access the whole path, so that part is working fine. What I can't seem to do is get the entire json secret: I can only retrieve one key at a time.
So far, I've tried all the following formats to no avail:
<path:secrets/k8s/soa/kv/data/dev/test-pipeline#. | jsonPath {@}>
<path:secrets/k8s/soa/kv/data/dev/test-pipeline#@ | jsonPath {@}>
<path:secrets/k8s/soa/kv/data/dev/test-pipeline# | jsonPath {@}>
<path:secrets/k8s/soa/kv/data/dev/test-pipeline | jsonPath {@}>
All of these result in various errors, mostly:
"Replace: could not replace all placeholders in Template: replaceString: missing Vault value for placeholder"
For reference the following works just fine, so I know secrets are being pulled correctly from vault:
<path:secrets/k8s/soa/kv/data/dev/test-pipeline#testdata | jsonPath {@}>
In either case, I'd like to have the documentation updated to represent the current state. It would also be beneficial, I think, to break down in the documentation how to address a secret in hierarchichal paths within a kv2 keystore, which is used by many larger orgs, for e.g. breaking the path down into it's components for less confusion.
path:<path/to/secret/store></data if we're using kv2></path/to/secret>[#key within secret][#secret version]
I can't find in the existing documentation any examples of doing the specific thing that I'm talking about here, all documentation that I've read pulls a subkey of the json secret instead of the entire json secret.
What I'd like is a) to get the correct format of the secret that we need or b) know that this is not possible as currently implemented.... at which point I'll make a feature request or post a PR.
If this isn't currently implemented, I'd like to suggest that the format should be:
<path:secrets/k8s/soa/kv/data/dev/test-pipeline | jsonPath {@}>
As that keeps it consistent with the paths used by avp.kubernetes.io/path.
Thanks!

@liamhelmer getting all the key values from a vault secret is not supported at this time. I think in order to do what you want, we would have to add some logic to run a list call on the path instead of a get and then form the list data into the map that needs to be returned. Feel free to put up a PR and we can take a look.


Project won't build

I'm getting Secrets and ConnectionStatus issues that confound me - I'm not sure why either is occurring as secrets are populated and present and the namespacing matches up.

Sorry - secrets is both in "Pro" and in "HackKit" I was focused on HackKit - but this begs the questions of what are the distinctions - why do both need to exist. I'm pretty confused by this project now. And that seems counter-productive. (and still getting the ConnectionStatus errors)

Hi @houstonhaynes - there was a little complexity with the secrets file to try and prevent people from checking in their WiFi credentials in the code.
We've simplified the secrets file for the hack kit project - it should build now without any modifications.

Thanks. I did begin to grok what's happening and look forward to checking the latest beta this week.

fixed - closing


Add Map based view functions

Wrap documents returned from views into Maps

Part of release 0.4.3


Add Afonso Bordado as a recognized contributor

I am nominating or self-nominating a Recognized Contributor.
Name: Afonso Bordado
GitHub Username: @afonso360
Projects/SIGs:

Cranelift

Nomination
Extensive work on Cranelift, its interpreter, and fuzzing infrastructure over the last year: https://github.com/bytecodealliance/wasmtime/commits?author=afonso360
Optional: Endorsements

@fitzgen

[X] I have read and understood the qualifications for a Recognized Contributor

👍  Thanks!

I support Afonso's nomination: he has for a long time now helped improve Cranelift, finding issues through fuzzing, and improving the interpreter.
Note, however, that right now it's a bit unclear how nominations can be accepted, given that we don't currently have a TSC to process them. I brought this up with our Executive Director, @disquisitioner, to discuss with the board.

We discussed this nomination at the last TSC meeting, and agree that Afonso's contributions clearly warrant Recognized Contributor status.
@afonso360, to finalize the addition, please send an email to<EMAIL_ADDRESS>to let us know which address to use for communicating with you as a Recognized Contributor, and to confirm that you accept the nomination.
That address will be added to our RCs mailing list, which receives community and project updates every few weeks or so.
Once we've received that email, we'll add you to the mailing list and merge this PR.

Thank you for providing your email address—we've added you to the contributors mailing list. More importantly, thank you for contributing to Bytecode Alliance projects! ❤


UI branding not reflecting after adding the ssl certificate to keystore for tls-customizing in identity server

Describe the issue:
I have created the new keystore and added my ssl certificate and changed the value for peimary and tls keystore in deployment file. After adding the key the tls and certificate succefully refelecting but changing in UI branding doesn't. If I revert the process and keep the default keystore parameter it's getting all the UI branding changes. Even If I configuring the nginx reverse proxy it is routing the unsecured browser certificate doesn't reflects.
How to reproduce:
I followed the the keytool commands to create the new keystore and importing the sssl certificate generated by CA authority(zerossl).
Expected behavior:
Same , but in myaccount application all the changes gets effect excpet the /console page/portal of WSO2IS
Environment information :

Product Version: IS 7.0.0
OS: Linux (Ubuntu 22.04)

As per our documentation [1], the 'DefaultAndLocalhost' hostname verification option allows the hostnames localhost, localhost.localdomain, <IP_ADDRESS>, and ::1 to be treated as valid along the SAN values in the SSL certificate. Moreover, if the SAN contains wildcards *, it will also treat all subdomains levels valid  (i.e., '.foo.bar' accepts 'a.foo.bar' and 'a.b.foo.bar') – in contrast with 'Strict' which will only consider a single subdomain level per wildcard (i.e., '.foo.bar' accepts 'a.foo.bar' but not 'a.b.foo.bar').
We've followed the steps below to update the hostname and certificates:

Created a fresh pack of the Identity Server 7.0.0 and updated to the latest update level (63 as of the date of this issue).
Made the changes below to the deployment.toml file:

[server]
hostname = "sub1.sub2.testdomain.com"

[keystore.tls]
file_name = "newkeystore.jks"
type = "JKS"
password = "mypassword"
alias = "newcert"
key_password = "mypassword"

Mapped sub1.sub2.testdomain.com to <IP_ADDRESS> in the /etc/hosts file.
In the repository/resources/security directory, ran the below:

keytool -genkeypair -alias newcert -keyalg RSA -keysize 2048 -keystore newkeystore.jks -dname "CN=*.testdomain.com, OU=Test,O=Test,L=D1,S=State,C=US" -ext 'san=dns:*.testdomain.com,dns:testdomain.com' -ext 'keyUsage=digitalSignature,dataEncipherment' -storepass mypassword -keypass mypassword

keytool -exportcert -alias newcert -keystore newkeystore.jks -file newcert.cer -storepass mypassword

keytool -importcert -alias newcert -file newcert.cer -keystore wso2carbon.jks -storepass wso2carbon -noprompt

keytool -export -alias newcert -keystore newkeystore.jks -file pkn.pem

keytool -import -alias newcert -file pkn.pem -keystore client-truststore.jks -storepass wso2carbon

Made the changes below to the repository/deployment/server/webapps/authenticationendpoint/includes/branding-preferences.jsp file (around L641) to allow the exception to be thrown and appear in the carbon logs:

    } catch (BrandingPreferenceRetrievalClientException e) {
	throw e;
        // Exception is ignored and the variable will use the fallbacks.
        // TODO: Move the duplicated logic to a common place.
    } finally {

Started the server.
Tried accessing the console or myaccount applications but got a 500 status code.
Observed the exception in the wso2carbon.log file:

Caused by: org.wso2.carbon.identity.mgt.endpoint.util.client.BrandingPreferenceRetrievalClientException: Error while getting branding preference for tenant : carbon.super
	at org.wso2.carbon.identity.mgt.endpoint.util.client.BrandingPreferenceRetrievalClient.getPreference(BrandingPreferenceRetrievalClient.java:126)
	at org.apache.jsp.generic_002dexception_002dresponse_jsp._jspService(generic_002dexception_002dresponse_jsp.java:1086)
	... 42 more
Caused by: javax.net.ssl.SSLPeerUnverifiedException: Certificate for <localhost> doesn't match any of the subject alternative names: [*.testdomain.com, testdomain.com]
	at org.apache.http.conn.ssl.SSLConnectionSocketFactory.verifyHostname(SSLConnectionSocketFactory.java:507)
	at org.apache.http.conn.ssl.SSLConnectionSocketFactory.createLayeredSocket(SSLConnectionSocketFactory.java:437)
	at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:384)
	at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142)
	at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:376)
	at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:393)
	at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236)
	at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186)
	at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
	at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
	at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
	at org.wso2.carbon.identity.mgt.endpoint.util.client.BrandingPreferenceRetrievalClient.getPreference(BrandingPreferenceRetrievalClient.java:108)
	... 43 more

If you set the value of server.internal_hostname to the same as server.hostname (e.g., sub1.sub2.testdomain.com), you'd instead get the below error:
Caused by: org.wso2.carbon.identity.mgt.endpoint.util.client.BrandingPreferenceRetrievalClientException: Error while getting branding preference for tenant : carbon.super
	at org.wso2.carbon.identity.mgt.endpoint.util.client.BrandingPreferenceRetrievalClient.getPreference(BrandingPreferenceRetrievalClient.java:126)
	at org.apache.jsp.generic_002dexception_002dresponse_jsp._jspService(generic_002dexception_002dresponse_jsp.java:1086)
	... 42 more
Caused by: javax.net.ssl.SSLPeerUnverifiedException: Certificate for <sub1.sub2.testdomain.com> doesn't match any of the subject alternative names: [*.testdomain.com, testdomain.com]
	at org.apache.http.conn.ssl.SSLConnectionSocketFactory.verifyHostname(SSLConnectionSocketFactory.java:507)
	at org.apache.http.conn.ssl.SSLConnectionSocketFactory.createLayeredSocket(SSLConnectionSocketFactory.java:437)
	at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:384)
	at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142)
	at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:376)
	at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:393)
	at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236)
	at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186)
	at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
	at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
	at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
	at org.wso2.carbon.identity.mgt.endpoint.util.client.BrandingPreferenceRetrievalClient.getPreference(BrandingPreferenceRetrievalClient.java:108)
	... 43 more

I think we might need to address this through an update similar to [2].
[1] https://is.docs.wso2.com/en/latest/deploy/enable-hostname-verification/#:~:text=hostname verification options.-,DefaultAndLocalhost,-%3A This is
[2] https://github.com/wso2/carbon-identity-framework/pull/4262


compileFile just like lessphp?

Hi,
Are you going to implement this function similar to what you have in lessphp?

Cherry-picked into master


Sync package names in Bower

At the moment you have to bower install bootstrapaccessibilityplugin to install bootstrap-accessibility-plugin (I.e. the value of the name attribute in bower.json.) Noted in mquandalle/meteor-bower#66.
How should this be fixed? Should the package designation be changed to bootstrap-accessibility-plugin in the Bower registry? bootstrapaccessibilityplugin in the name: attribute? I can submit a PR if the latter.
Thanks.

Could you kindly submit a PR?
Thanks in advance.


Print all buffers in case of error

Hi,
While working on another issue, I hit the exact same than described in #232 : In the webapp, the grading fails with:
Erreur dans l'exercice lors du test de la solution utilisateur

And no other information.
So I decided to give it a try, and discovered that a buffer which contained some logs was not printed (and it was indeed the one where was the information I needed).
This PR fix this problem.

Note, this also fix in part #226 , since the report also print now if an exception was raised by the student code.

Fix #226
Fix #232


Devtools bug when actions triggered by window's scroll

I setup an container/component that dispatches actions on window resize/scroll, however, when I have the redux-devtools open, this event triggers when I scroll to the bottom and attempt to open the last state to inspect.
I was able to get to a state, where the event would fire endlessly as devtools continued to expand...  not sure about the display/render logic of the devtools container, but it's an issue for me.

NOTE: I'm using these events to control certain parts of rendering (namely hiding/showing components at different sizes), as well as wanting to do some scroll spying.  I'm using material-ui which uses inline styles.

Wrap the monitor into a filter monitor, and add these actions there to be filtered. Autoscrolling the monitor when a new action appears is an intended effect.

@zalmoxisus thanks, may need that...
In my case, I was able to resolve this, by inverting my position/size detection to only dispatch the event if the values actually changed...
https://github.com/tracker1/r3k-example/blob/master/client/containers/WindowEvents.jsx
https://github.com/tracker1/r3k-example/blob/master/client/actions/window/index.js
probably not the best way to handle this, but window/platform events should be very limited to begin with.


Mobile rotate and touch navigation

Hi! First thanks for really cool project.
Is there any plans to add support for mobile rotation (compass) and touch navigation (like Facebook 360 photos)?

There’s no feature for that planned in the moment being :/


Support ndarray methods in fused functions

It seems odd that the following is supported
@cupy.fuse
def test(x): return cupy.sum(127 < x)

but the following isn't
@cupy.fuse
def test(x): return (127 < x).sum()

It seems that to add this support the class _FusionVarArray could have a __getattr__ method that can map ndarray method names to the appropriate fusion functions (such as sum(...) getting mapped to fusion._call_reduction(_math.sum_auto_dtype, self, ...)).

Hello,
Can I work on this?

So massive changes are planned in #2734. So I don't recommend working on this before this PR is merged.

@niteya-shah FYI, #2734 has been merged so you are free to go ahead and add these features.


[Refactor] Ignore some UI elements and show up info header for user with Talkback on

Purpose
Ignore some UI elements for Talkback.
Modify the logic to always keep info header showing up when the Talkback is on
Does this introduce a breaking change?
[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test
Test the App with Talkback on, use gesture(swipe left or right) to navigate the UI elements on Setup screen to verify if some UI elements have been ignored. (Also same for the participants' number on the info header).
Try to join the call with or without Talkback on, to see if the info header show up as expected.

Tested.


Permissions popups bug (popup-refresh branch)

On popup-refresh branch.

Should be fixed now. Made a few selectors more generalised so hopefully this doesn't cause any regressions in lesser-used parts of the UI.

Seems OK.

Thanks for testing amigo.


Discrepancy between docs and implementation

README.md states:
done must be called only once, when your plugin is ready to go.
But the implementation silently suppresses this when it happens.
https://github.com/mcollina/avvio/blob/6d7554cfe4113985609b33e531f60ba72d36edf3/plugin.js#L40-L42
Should we throw an Error here and add a test to verify that a plugin calling done twice throws or should we change the docs and add a test verifying it does not cause any error?

I would keep the current behavior consistent. Fire a PR with the doc change and the test when you have the chance!


Add streaks

I know it doesn't look particularly pretty, so I'd like some ideas to make it better lol. I've never been good with design and UX stuff.
Adds rotating and character streams to the history page for a profile.

We already have the current streak on the 400 page -- I think the original request was to have the streak any one run was part of (e.g. run 3/7 in a streak)

I see. I guess I made an incorrect assumption based on the wording of the feature request


Improper sprite scaling

Hi, one thing that stuck out to me when playing the game was that the character portraits seem to be of varying aspect ratios and appear squashed in some cases. This is obviously from assets/units/Mugshots.png, but since these shots look properly ripped and proportioned, the distortion is possibly as a result of Godot loading the assets strangely.

Thanks for this, I didn’t even realize it.


Wrong button mapping in G700 profile

button set (using different software) to resolution cycle down gives output:
Button: 7 type resolution cycle up is mapped to 'resolution cycle up'
while setting button to resolution cycle up gives:
Button: 7 type resolution cycle up is mapped to 'UNKNOWN'
edit:
values in src/hidpp10.c are correct. Problem is probably just with formatting output

this bug is coming up to 2 years now - any chance this got fixed in the various other bits that we implemented since?

Looks like it's fixed.


[Enhance] Update HPA README

Sync the instructions from the latest HPA public doc: https://cloud.google.com/stackdriver/docs/managed-prometheus/hpa
cc.@courageJ

@pintohutch friendly ping?


Fix: Pnl percentage

This adjusts the unrealized pnl percentage denominator to include deposits to match the realized pnl percentage.

Discussed with Marko the new calculation:

Removed pnl percentage for realized profits
For unrealized, we base the percentage on initial margin + net transfers. This means the percentage will adjust when margin is deposited or withdrawn, but the percentage will always match your actual margin amount. Meaning, it would reach -100% when your margin is truly fully exhausted.


Ubuntu 16.04: systemd path issues

Trying to use this cookbook with Ubuntu 16.04, I found two issues:

With job_control set to systemd, the cookbook attempts to create<EMAIL_ADDRESS>but on Ubuntu 16.04 /usr/lib/systemd/system does not exist.
After installing the service file, /usr/bin/systemctl daemon-reload is called. On Ubuntu, this command should be /bin/systemctl daemon-reload.

Thanks!  I will try to patch this ASAP.

This is fixed in #302.

This also fixes the issue for me. Any chance of it making it into a release?

Yes sorry. I've been busy. Will try to prioritize some pull requests and cut a release next week.

Solved by https://github.com/brianbianco/redisio/pull/302


Calling subreddit.editSettings resets several settings

From what I can tell it's resetting the following:

allow this subreddit to be exposed to users who have shown intent or interest through discovery and onboarding
allow video uploads
allow free-form reports by users
mobile look and feel color

There may be others, but these are the ones I'm noticing.  Has anyone else encountered this issue or found a way around it?

Thanks for the report. This is probably happening because the API endpoint requires snoowrap to specify all of the new subreddit settings (even the ones that haven't changed). It accomplishes this by fetching the current settings from reddit and applying the provided changes, but it looks like it's currently just accepting a hardcoded list of keys. I think the settings that you listed were all added after this function was implemented, so they're not getting sent back to reddit correctly. It would probably be a good idea to pass additional keys found on the subreddit back to reddit as well, so that this doesn't break again in the future.

Thank you for the quick answer and snoowrap itself! I think you have the right idea to help future proof the issue.  I may play around with your source code later this evening and see if I can't make that change easily and if so I'll put in a pull-request.

Any update on this? From what I can see, it still resets mobile look and feel and therefore the .editSettings() function is not really useful....


Fix switching to the current channel

When you click on the already current channel, the program would show "No messages in this conversation yet!" and get stuck there until you change to a different channel. This fixes that.

Thanks!


Add stylistic plugin

Context
I want to ESLint add newlines between every object type properties:
type Foobar = {
	foo: string
	// newline here
	bar: string
	// newline here
	baz () {}
}

Rule @typescript-eslint/padding-line-between-statements can do this with proper options.
Since typescript-eslint deprecated all formatting rules and Prettier doesn't handle this, so ESLint Stylistic is needed.

Update: @typescript-eslint/padding-line-between-statements doesn't satisfies my need.
I'll write some ESLint rules by myself.


MapView onPress() is fired when I hit marker ! (iosMaps only)

Hello, I put onPress method both marker and map view. On android, marker onPress work fine, it dont fires mapView 's onPress(), but IOS do.. Logically, MapView's onPress should not be fired when I hit just marker(I am 100% sure that I am not hitting Map, I zoomed into marker 500% and only hit marker). How can I handle it ? Any idea? Is it an issue ?

Can you show the code that "fires" that onpress? Maybe the whole component?

Here is my code:
<View style={Style.container} onLayout={this.navigationParams.markers ? this.fitMarkers : null}>
               <MapView
                   ref={(map: any) => this.map = map}
                   style={Style.container}
                   onPress={() => { this.onMapPress() }}
                   onLongPress={() => this.onLongPress()}
                   rotateEnabled={false}
                   pitchEnabled={false}
                   toolbarEnabled={false}
                   initialRegion={this.navigationParams.markers ? null : turkeyRegion}
               >
                   {
                       // Eğer navigationdan gelen noktalar kümesi varsa onu çizdir
                       this.navigationParams.markers &&
                       map(this.navigationParams.markers, (marker: GeoMarker, index: number) => {
                           return (
                               <Marker key={index} coordinate={marker.coordinate}
                                   onPress={() => { this.onMarkerPress(index) }}>
                               </Marker>
                           )
                       })
                   }
               </MapView>
   .
   .

Does onMapPress() work properly in your case ?  I think GoogleMap can understand that are you pressed map or only marker, but ios Maps can not

Hi, got the same issue. It appears you could use MapView's onMarkerPress callback to handle marker taps correctly on iOS, not Marker's onPress.
Use identifier <Marker identifier={index.toString()}> to distinct markers within callback:
  onMarkerPress = (event: any) => {
    const index = parseInt(event.nativeEvent.id, 10);
    if (isNan(index)) {
      return;
    }
    ...

#114

@bzm97 I don't think that is what @emregurler wants. The problem is all MapView.onPress(), Marker.onPress() and also MapView.onMarkerPress() are triggered when pressing on a Marker. This is not logical as pressing on Marker shouldn't trigger MapView's press.

My workaround for this is to create a boolean class variable called userJustPressedMarker, initialized to false. In the marker's onPress function, if Platform.OS === 'ios' I set it to true. In the MapView's onPress function, I wrap all the code inside if (!this.userJustPressedMarker) { /* do stuff */ } and at the end I set it to false.

@danbockapps is that actually working? How are you ensuring your sequence of events? Like how are you sure your markerPress event handler is firing/setting state prior to the MapView's onPress?

@andrewtelkamp Yes, it's working. I'm using a class variable, not a state variable, so I don't have to worry about state getting set.
I guess react-native-maps doesn't promise to always call the marker's onPress function before the MapView's onPress function, but that does seem to be the order it always calls them in.

You can use event.nativeEvent.action === 'marker-press' to check whether a marker was pressed or not.

You can use event.nativeEvent.action === 'marker-press' in the onPress handler to check whether a marker was pressed or not.

Genius!

you can check by marker identifier
<Marker onPress={handleMarker} identifier="23af23" />
handleMarker = (e) => {
   let id = e.nativeEvent.id
}

handleMarker = (e) => {
// stop onPress event from propagating to mapView
e.stopPropagation();
// determine which marker pressed
let id = e.nativeEvent.id
}

handleMarker = (e) => {
   // stop onPress event from propagating to mapView
    e.stopPropagation();
    // determine which marker pressed
    let id = e.nativeEvent.id
}

This is called bubbling. It's common in touch applications and needs to be handled with propagation events.
Read this: https://javascript.info/bubbling-and-capturing

You can use event.nativeEvent.action === 'marker-press' in the onPress handler to check whether a marker was pressed or not.

That's it. Thank you!