krr_classification_ex link error

On Ubuntu 16.04, while trying to compile the examples as suggested on the site I am getting the following linker errors. under build in examples I have exported the cloned directory to my PATH.

The closest thing I found related to this was: https://github.com/cloudius-systems/osv/issues/474 but installing lib32stdc++-4.9-dev does not help. Any advice on how to proceed?

Those aren't dlib errors.  It looks like your compiler is just broken.  I would reinstall the compiler.

You were right, it would seem my gcc packages were broken or something. On a fresh install of Ubuntu 16.04.2 everything works fine. I got #348 but after a libx11-dev install everything compiled to completion and the examples run.


Not seeing all messages appear when using app.message(/.*/, ...)

Description
I have a simple application that listens in a channel for messages. I've noticed that if I send multiple messages in a row from slack, they don't always seem to land in the handler for app.message. Interestingly, this only happens when I send several messages in a row in a thread. It seems like if the other side of the conversation responds (an alternating conversation), then I will always successfully detect new messages. This seems so trivial that I wonder if I have overlooked something quite obvious. As you can see in the screenshot, I output a message ts for every message that arrives in the handler. You can see the second message from my user "Test" does not appear in the console with a thread ts. This project is fantastic and allowed me to build a robust chat application with very little effort, however the bug in my implementation is driving me crazy and I cannot see how it could occur from reading the documentation. Please let me know if I'm just missing a critical detail, or if there is something actually wrong. Thank you!
These seem slightly related:
https://github.com/slackapi/bolt-js/issues/1243
https://github.com/slackapi/java-slack-sdk/issues/803#issuecomment-895768180
App config:
this.app = new App({
      signingSecret: process.env.SLACK_SIGNING_SECRET,
      token: process.env.SLACK_BOT_TOKEN,
      socketMode: true,
      appToken: process.env.SLACK_APP_TOKEN,
      port: <any>process.env.SLACK_PORT || 3003,
    });

What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version:
node version:
OS version(s):
Steps to reproduce:

Expected result:
What you expected to happen
Actual result:
What actually happened
Attachments:
Logs, screenshots, screencast, sample project, funny gif, etc.
One other example for fun:

Answer:
https://github.com/slackapi/java-slack-sdk/issues/803#issuecomment-895768180

For anyone finding this because of the .message('/.*/' regex and trying to implement a catch-all clause (e.g. to display some help-menu or a 404 message), you can achieve that by omitting the pattern. Make sure it's defined as the last .message() handler
app.message(async ({ say }) => {
  await say("I didn't quite catch that. Maybe try `help`?")
})


script: Use pflag for command arguments

Embed the pflag FlagSet into the command creation so we can show decent help for the flags.
The CmdUsage now contains a Flags field of type func(*pflag.FlagSet) (similar to cell.Flagger!) that
allows registering the flags. These flags are then shown in the help summary, e.g.
[-q] [--quiet] for fs.BoolP("quiet", "q", ...) and also expanded in the verbose help.
For example help now looks like:
> help
...
sleep duration [&]
        sleep for a specified duration
stderr [-q] [--count=int] [--quiet] 'pattern'
        find lines in the stderr buffer that match a pattern
stdout [-q] [--count=int] [--quiet] 'pattern'
        find lines in the stdout buffer that match a pattern
stop [msg]
        stop execution of the script
...
> help stdout
stdout [-q] [--count=int] [--quiet] 'pattern'
        find lines in the stdout buffer that match a pattern

        The command succeeds if at least one match (or the exact
        count, if given) is found.
        The -q flag suppresses printing of matches.

        Flags:
              --count int   Exact count of matches
          -q, --quiet       Suppress printing of matches

Converted statedb to use this: https://github.com/cilium/statedb/pull/70.
That unfortunately won't be backwards compatible and will need to fix things up when StateDB will be bumped.


[BugFix] Capture query context when use its mem_tracker out of its lifetime

Why I'm doing
RuntimeFilterWorker may handle a delay runtime filter of  a pre-maturely terminating query, so a query context is destructed before the using its query-level mem_tacker in RuntimeFilterWorker. when this mem_tracker is undergoing
desctruction, its parent mem_tracker (e.g. resource_group-level mem_tracker) would be accessed, however, the resource-group-level mem trackers has already been destructed when the resource group is dropped or altered.
Using query-level mem-tracker beyond query context's life time may lead to BE's crash as follows:
*** Aborted at<PHONE_NUMBER> (unix time) try "date -d @1722298201" if you are using GNU date ***
PC: @          0x80cfb60 (unknown)
*** SIGSEGV (@0x0) received by PID 41980 (TID 0x7f0a2fbea700) from PID 0; stack trace: ***
    @          0x5c32442 google::(anonymous namespace)::FailureSignalHandler()
    @     0x7f0da11847f2 os::Linux::chained_handler()
    @     0x7f0da118b5c6 JVM_handle_linux_signal
    @     0x7f0da1181683 signalHandler()
    @     0x7f0da064c630 (unknown)
    @          0x80cfb60 (unknown)
    @          0x4a588d8 starrocks::MemTracker::~MemTracker()
    @          0x2cb1e8a std::_Sp_counted_base<>::_M_release()
    @          0x4ac1d87 starrocks::RuntimeFilterWorker::_receive_total_runtime_filter()
    @          0x4ac4266 starrocks::RuntimeFilterWorker::execute()
    @          0x8146cb0 execute_native_thread_routine
    @     0x7f0da0644ea5 start_thread
    @     0x7f0d9fc5f98d __clone
    @                0x0 (unknown)

What I'm doing:
We need capture query context to prevent it from being destructed, and when a dropping resource_group is used by outstanding query contexts, it would be delayed to be dropped until all its outstanding query contexts are destructed.
Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[x] 3.1
[x] 3.0
[x] 2.5

ignore backport check: 2.5.19

ignore backport check: 3.3.2


Update for KubeJS Iron's Spells 2.0.0

Added info for custom spellbooks, staves, and magic swords, as well as changing some information that has been changed by the update.
Also fixed an error with global.attributes.

I don't know why it's showing old commits, but it has no effect on the outcome of the PR.


[Migration] Unable to override default styles with tss-react

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
With v4 I was using <CssBaseline classes={classes}> to add bunch of classes which had higher specificity and was used to override a few of MUI's default styles.
The classes mentioned above was defined using makeStyles along with @global.
Post v5 migration I am using tss-react and I got to know that @global is no longer supported and changed to code as per the suggestion by tss-react
I replaced <CssBaseline classes={classes}> with something similar like <GlobalStyles styles={{ '.h-m': { fontSize: '40px' } }} />
With I can see the class .h-m is loaded however it has lower specificity i.e. it was loaded before the default styles of MUI.
And for that reason the override doesn't work anymore.
I tried exploring various articles found on the internet, however no luck fixing this behaviour.
Any suggestion here will be very helpful.
Expected behavior 🤔
Should be able to override MUI's default styles with global classes
Steps to reproduce 🕹
This is not applicable at this stage as its a migration issue.
However if any further information / code snippet is needed for investigation same can be provided.
Context 🔦
Trying to migrate from v4 to v5.
This issue has blocked the entire migration
Your environment 🌎

npx @mui/envinfo
  System:
    OS: macOS 12.2.1
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.19.0 - ~/.nvm/versions/node/v16.13.0/bin/yarn
    npm: 6.14.16 -
  Browsers:
    Chrome: 103.0.5060.114
    Edge: 103.0.1264.62
    Firefox: 102.0.1
    Safari: Not Found
  npmPackages:
    @emotion/react: ^11.9.3 => 11.9.3
    @emotion/styled: ^11.9.3 => 11.9.3
    @mui/icons-material: ^5.8.4 => 5.8.4
    @mui/lab: ^5.0.0-alpha.88 => 5.0.0-alpha.88
    @mui/material: ^5.8.6 => 5.8.6
    @mui/types:  7.1.4
    @mui/utils:  5.8.6
    @mui/x-date-pickers:  5.0.0-alpha.1

The intention of the GlobalStyles is to set defaults, this is why the styles are injected before the default one from emotion, it is intended. If you want to use GlobalStyles for overrides, you will need to bump the specificity of the classes, for example by adding all classes under the root element, something like: https://codesandbox.io/s/laughing-northcutt-776meg?file=/src/App.tsx
Note: so that there are no surprises in the portal components (as they are by default rendered outside of the root, you will need to do something similar to: https://mui.com/material-ui/guides/shadow-dom/#2-theme
I hope this helps and clarifies things.

Thanks for your comment @mnajdova
I just want to understand a few things:
Previously with v4 (with JSS), the order of loading styles was:

MUI styles
Styles created with makeStyles

At that time, since the app was using  <CssBaseline classes={classes}> where classes is created with makeStyles everything was fine.
With v5 I understand it is intended for GlobalStyles to be loaded first.
What I think the order should be:

Global styles
MUI styles
TSS styles

However the order that I can see is:

TSS styles
Global styles
MUI default styles

Styles created with makeStyles of tss-react are the first to load even before global styles, this is problematic.
Is there anything that can be done here like with TssCacheProvider, the prepend option there is of no use, because TSS styles are already at the top.

@shirshendubhowmick thanks for sharing your investigations. Yes, emotion is a singleton, which is why we have it as a peer dependency. It could have just been wrong caching when installing the modules. I wouldn't overload the migration guide until we see more people hitting this problem.


Update to .NET 6 and simplify fsproj

Update to .NET 6.0
Update NuGet packages
Use wildcards to simplify fsproj files
Remove the use of a reversed index expr.[^1] since it is a preview feature

LGTM, thanks for contribution.


Add transition validation check to signature

Closes #795

@vedhavyas @lucasvo @pstehlik holding on to this until we have done the tree changes.

closing in favor of: https://github.com/centrifuge/go-centrifuge/pull/1107


Tasks

Currently only an experiment. See #1362
docs

How does this look like: https://tasks.devenv.pages.dev/tasks/

are you planning to continue working on this? can I help?

Hey @sebastianwebber, will work on this as soon as I address #1364


Update two_fer_test.dart

@aly22 I believe you meant to use exercism submit to send the results you worked on to excersim.io

Was just trying to update your old a** code...

@aly22 Updating the code by trying to add a file doesn't change the existing code. It just adds a second test file.
There's no need to insult the code, it's just text.


Treesitter crashes on [[ ]] lua syntax in init.lua

It seems that whenever the [[ xxx ]] pattern is encountered in init.lua is encountered, TS crashes with the following back trace:
ERR 2022-12-17T09:36:32.033 nvim.63645.0 decor_provider_invoke:38: error in provider treesitter/highlighter:line: Error executing lua: ...im/0.8.0/share/nvim/runtime/lua/vim/treesitter/query.lua:219: query: invalid node type at position 2765 for language vim
stack traceback:
[C]: in function '_ts_parse_query'
...im/0.8.0/share/nvim/runtime/lua/vim/treesitter/query.lua:219: in function 'get_query'
....0/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:36: in function 'new'
....0/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:160: in function 'get_query'
....0/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:182: in function 'fn'
...0/share/nvim/runtime/lua/vim/treesitter/languagetree.lua:210: in function 'for_each_tree'
...0/share/nvim/runtime/lua/vim/treesitter/languagetree.lua:214: in function 'for_each_tree'
....0/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:168: in function 'on_line_impl'
....0/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:231: in function <....0/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:225>
Happend both on nvim 0.8.0 and 0.8.1 - I have not had this issue with my previous config which happily parsed any lua file.

I have this issue as well.  It's because you're in a .lua file but there's also .vim syntax present.  If I remember correctly, I would :TSUpdate vim and it would resolve it.

Thank you @MichaelVessia this solved it for me.

I noticed this too on a fresh install today, but :TSUpdate vim has fixed it for me

:TSUpdate vim seems to have resolved it for me as well, but keeping the issue open as it seems common enough that it should probably be worked around in the bootstrap code.

So just to make sure we're clear, after running :TSUpdate vim the problem was resolved?

Correct.

It did not fix it for me. But this predates my starting over with configuration using this repo.
here is the current output from checkhealth
`nvim-treesitter: require("nvim-treesitter.health").check()
Installation

WARNING: tree-sitter executable not found (parser generator, only needed for :TSInstallFromGrammar, not required for :TSInstall)
OK: node found v18.12.1 (only needed for :TSInstallFromGrammar)
OK: git executable found.
OK: cc executable found. Selected from { vim.NIL, "cc", "gcc", "clang", "cl", "zig" }
Version: cc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0
OK: Neovim was compiled with tree-sitter runtime ABI version 14 (required >=13). Parsers must be compatible with runtime ABI.

OS Info:
{
machine = "x86_64",
release = "6.0.6-76060006-generic",
sysname = "Linux",
version = "#202210290932~1669062050~22.04~d94609a SMP PREEMPT_DYNAMIC Mon N"
}
Parser/Features H L F I J

regex          ✓ . . . .
go             ✓ ✓ ✓ ✓ ✓
json           ✓ ✓ ✓ ✓ .
vim            x ✓ ✓ . ✓
comment        ✓ . . . .
lua            ✓ ✓ ✓ ✓ ✓
html           ✓ ✓ ✓ ✓ ✓
bash           ✓ ✓ ✓ . ✓
javascript     ✓ ✓ ✓ ✓ ✓
gitattributes  ✓ . . . ✓
git_rebase     ✓ . . . ✓
python         ✓ ✓ ✓ ✓ ✓
gitcommit      ✓ . . . ✓
typescript     ✓ ✓ ✓ ✓ ✓
help           ✓ . . . ✓
mermaid        ✓ . . . .
yaml           ✓ ✓ ✓ ✓ ✓
c_sharp        ✓ ✓ ✓ . ✓
markdown       ✓ . ✓ . ✓
c              ✓ ✓ ✓ ✓ ✓
rust           ✓ ✓ ✓ ✓ ✓
cpp            ✓ ✓ ✓ ✓ ✓

Legend: H[ighlight], L[ocals], F[olds], I[ndents], In[j]ections
+) multiple parsers found, only one will be used
x) errors found in the query, try to run :TSUpdate {lang}
The following errors have been detected:

ERROR: vim(highlights): /usr/local/share/nvim/runtime/lua/vim/treesitter/query.lua:171: query: invalid node type at position 4647 for language vim
vim(highlights) is concatenated from the following files:
|    [OK]:"/home/moose/.local/share/nvim/site/pack/packer/start/nvim-treesitter/queries/vim/highlights.scm"
| [ERROR]:"/usr/local/share/nvim/runtime/queries/vim/highlights.scm", failed to load: /usr/local/share/nvim/runtime/lua/vim/treesitter/query.lua:171: query: invalid node type at position 581 for language vim`

I was able to work around it using this syntax.
vim.cmd{ cmd='packadd packer.nvim'}

@agentHoover I have this in my notes, if it's helpful:
-- If seeing errors parsing, check that you do not have two parsers installed.  Why this happens I do not know.
-- :echo nvim_get_runtime_file('*/python.so', v:true)
-- rm -rf /usr/local/lib/nvim/parser

I'm still learning about treesitter so I don't know why this happens, but it seems like two highlights.scm files sometimes exist, as it seems to be in your case, and then it doesn't know which to use.

@MichaelVessia yep. That fixed it.  I tried to uninstall the vim parser with TSUninstall vim and it told me that vim was still installed and exactly which file to remove manually to uninstall it. Removed the file, reinstalled, and all is well.  The file I removed was located here:  /usr/local/lib/nvim/parser/vim.so for what its worth.
Thanks for your help.

I had the same issue and fixed adding 'vim' to ensure_installed.. Maybe we should add 'vim' to that array by default. Are there drawbacks to adding it?

:sweat: just that I thought I already had vim in the list haha
If someone wants a free PR, they can open. Otherwise I'll do probably tomorrow or soon

I have investigated these two situations...
Situation 1
After installing vim parser no more treesiter (2) errors.
init.lua:
vim.cmd [[packadd packer.nvim]]
vim.cmd [[colorscheme onedark]]
Situation 2
Example 01 (commands-GOOD.lua):
vim.cmd( [[

" ------------------------ COMMANDS --------------------------

" ----------------------------------------------------------
" Comm_ 01:
" Edit init.vim and cd to folder:
command! QeditVIMRC :e $MYVIMRC | tcd %:h

" ----------------------------------------------------------
" Comm_ 02:
" Toggle line relativenumber on or off.
command! QnumberRelativ set relativenumber!

" ----------------------------------------------------------

]] )

Example 02 (commands-BAD.lua):
vim.cmd [[

" ------------------------ COMMANDS --------------------------

" ----------------------------------------------------------
" Comm_ 01:
" Edit init.vim and cd to folder:
command! QeditVIMRC :e $MYVIMRC | tcd %:h

" ----------------------------------------------------------
" Comm_ 02:
" Toggle line relativenumber on or off.
command! QnumberRelativ set relativenumber!

" ----------------------------------------------------------

]]

Should have all the required grammars now, so I can't reproduce crash anymore. Thanks!


"permission"."active"}', but does not have signatures for it under a provided delay of 0 ms, provided permissions

Get this when i try to update the staking totals

Why its closed?


Simplify Clear Linux installation instructions

Thanks to https://github.com/madMAx43v3r/chia-plotter/pull/524 this can now be built with GCC 11.1.1 (Clear Linux 34740) so we can simplify the instructions. Tested OK.

great


Unable to download & save .dat file??

So I've been having no problems with the save manager up until now, where whenever I click "save changes" instead of downloading the new garden_plus.dat I get a pop-up that says "how do you want to open this file?" I'm not sure what happened to cause this, but clicking anything else gives me a pop-up that says "this file can't be opened on your computer." This issue worries me especially since I have other games on my computer that use .dat files to store save data and whatnot. Any help with this problem is greatly appreciated!!

Oh, well I found something - every time I press "save changes and the

Well then, apparently I HAVE been saving the game, and I now have over 30 copies of garden_plus in my downloads folder. At the very least I got a good laugh out of this 🤣


Can you build binaries for Linux OSes?

[ x ] I think my problem is NOT with youtube-dl
[ x ] I've verified and i assure that I'm running yt-dlg 1.X.Y
[ x ] I assure that i am using the latest version of youtube-dl
[ x ] Searched bugtracker
[ x ] I've read the FAQs file

What is the purpose of your issue?

[ ] Bug report
[ x ] Feature request (request for a new functionality)
[ x ] Question
[ ] Other

Question
Can you build binaries for Linux OSes? M.B. Snap/AppImage/Archived Package/DEB/RPM? Binary from this repository doesn't work on Ubuntu 22.04 with installed required python modules.

Check the Releases section the yt-dlg asset or the Downloads section in the yt-dlg site

Check the Releases section the yt-dlg asset or the Downloads section in the yt-dlg site

Do you think you will be possible to support flatpak. I think it will be better and easier if this app had a flatpak version since it could work on any distro. And unlike raw binaries they don't break as easily from Linux updates.

I don't have time to test and create
Relevant flatpak docs:

https://docs.flatpak.org/en/latest/first-build.html
https://docs.flatpak.org/en/latest/python.html

You probably need to build the requirements:
python3 flatpak-pip-generator --requirements-file=requirements.txt, it will output extra modules to python3-yt-dlg.json. I know you don't have a requirements.txt but I'm sure flatpak-pip-generator has something alternative.
Flatpak manifest that might work excluding the extra work that the dependencies might need (like wxpython...).
app-id: org.flatpak.yt-dlg
runtime: org.freedesktop.Platform
runtime-version: '22.08'
sdk: org.freedesktop.Sdk
command: yt-dlg
modules:
   - python3-yt-dlg.json
   name: yt-dlg
   buildsystem: simple
   build-commands:
     - pip3 install --prefix=/app --no-deps .
   sources:
     - type: archive
       url: https://github.com/oleksis/youtube-dl-gui/archive/refs/tags/v1.8.5.tar.gz
       sha256: 8b1f9815857228a002680e2f64fc421055098c6dcfed6f6be17274b0cf45ca4a


Test failure: TestSessionRestartedOnNodeDescriptionChange

Seen in https://circleci.com/gh/docker/swarmkit/6973:
--- FAIL: TestSessionRestartedOnNodeDescriptionChange (1.27s)
	Error Trace:	agent_test.go:248
	Error:		Received unexpected error session has not been restarted yet
			github.com/docker/swarmkit/testutils.PollFuncWithTimeout
				/home/ubuntu/.go_workspace/src/github.com/docker/swarmkit/testutils/poll.go:28: polling failed

cc @cyli

Thanks!  Will try to replicate.

Could the 1 second timeout here be too strict for the CI environment? Just a guess.

Could be - would it take that long for an agent to reconnect to a fake dispatcher?   I'll try a bunch of repeated runs, and if I can't replicate, I'll just bump the timeout up as a hail mary :)

Ok, 1096 iterations later without replication, so I'll just bump up the timeout and add a little more error info.


disable optional output formatter

Graphiz is an optional dependency and JUnit requires ext-dom

i like this PR but it's a BC, so i am not 100% sure.

We still have no 1.0 release and printing following disclaimer:
deptrac is alpha, not production ready.

Semver is allowing us having breaking changes in a zero-mayor-version. If there no others concerns when BC it should be merged. The documentation may have to be updated and changelog/upgrade guide could added.

from my point it's ok. feel free to merge :)

I added another/more reliable way to enable/disable formatters by default. Reviews are welcome :-)


Mentor signal localizable strings and current translations

Added mentor signal strings, and the current translations for those strings. This also removed the strings that are not longer part of the panel, such as the connection request and the second page of the panel.

Thank you! Merged!


Calling API using Botkit

Hi,
I am new to Botkit and I am trying to run a third-party API (e.g. weather API), so for example, if I am asking the BOT "What is the temperature in London right now", I expect to get an answer like "It's 6 Celsius"
I have to mention that it's running locally with no issues.
Can you help, please?

Not sure what help you need! You can call whatever API you want from within your Botkit handlers.

controller.hears('wheather', 'message_received', (bot, message)  => {
  axios(<API_REQ>)
    .then((respponse) => {
       bot.reply(message, `The wheather is ${response.body}`)
  })
})

This looks roughly correct.  What is your issue?

What is not clear for me, is how to access the API features from within the Botkit Studio?

@refai2016 A few things:

Botkit Studio will cease operation in February.  You should transition your bot ASAP to using botkit-cms

There is no way to directly use external APIs from within the Botkit dialog editor UI. What you CAN do is create variables that are referenced within your scripts, using tokens like {{vars.}}.

Docs for using variables in conversations are here:
https://botkit.ai/docs/core.html#using-variable-tokens-and-templates-in-conversation-threads
Docs for hooking into the execution of scripted dialogs (from studio or cms) are here:
https://botkit.ai/docs/readme-studio.html#controllerstudiobefore

@benbrown @adantoscano Thank you for your response.


Add variable resolver to entity key generator.

You can now do stuff like this:
entities:
  person:
    schema: Person
    keys:
      - variable.$foobar
    properties:
      $foobar:
        literal: "foo bar"

Tests would be nice one day


Possible install issue with an existing Anaconda environment

Hello, this is a partial bug message, I figured it was worth filing in case others have a similar issue. I have an existing Python 3.4 Anaconda environment called "scratch" (I use it for all side projects). It has numpy, pandas, IPython Notebook and lots more.
I already had a version of qgrid from at least 6 months back, installed back in the mists of time.
I just tried pip install -U git+https://github.com/quantopian/qgrid (adding -U to your install notes) and it had a crack at uninstalling my Anaconda-provided numpy+pandas+notebook. I killed it and thankfully it hadn't nuked my environment.
I cloned your repo locally and edited setup.py to remove the install_requires dependencies, then ran python setup.py install and I have the latest version. I'm not sure what happened but I figure it is worth noting (but feel free to close/delete if this isn't a helpful-enough bug report!).

Thanks @ianozsvald. I agree, setting install_requires with pegged versions is very aggressive towards the existing environment.

In addition (I just tried it again), due either to the Anaconda env or maybe because I have IPython 4.0.1 if I try to use the setup.py's original install_requires it (now) reports
pkg_resources.UnknownExtra: ipython 4.0.1 has no such extra feature 'notebook'
so I'll continue to experiment having commented out install_requires

We're not actually using requirements.txt for our setup.py: https://github.com/quantopian/qgrid/blob/master/setup.py.
Does Anaconda ignore setup.py and just look at the requirements?

@ssanderson Anaconda in this case didn't know anything about setup.py - I just ran python setup.py install at the command line inside my Anaconda environment. That environment wasn't super-up-to-date (maybe 6 months since I last updated the libraries) and all I remember is that IPython, numpy and more were uninstalled and then pip-installed (which breaks the conda package management, as these were installed through conda).
I think the lack of version pinning in your setup.py was the culprit (it saw that the latest versions were needed but older ones were installed, so it nuked my older ones). I'd suggest at least putting pinned version numbers against your install in setup.py.
There's a separate process to make a package installable inside the conda ecosystem (if that's what you're interested in):
http://conda.pydata.org/docs/build_tutorials/pkgs.html
http://conda.pydata.org/docs/build_tutorials/pkgs2.html

We've updated setup.py to read from requirements.txt, which has pinned version numbers now.  Sounds like the lack of pinned version numbers is our best theory as to why this happened so I'm going close this now.


feat(Popup): support an object from createRef() as context value

Changes similar to #3448.
So, Popup now accepts a refs created with React.createRef() into context prop, it's really great simplification 👍

Codecov Report

Merging #3459 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3459      +/-   ##
==========================================
+ Coverage   99.89%   99.89%   +<.01%
==========================================
  Files         172      172
  Lines        2813     2815       +2
==========================================
+ Hits         2810     2812       +2
  Misses          3        3

Impacted Files
Coverage Δ

src/modules/Popup/Popup.js
99.26% <100%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d29552...f95caf4. Read the comment docs.

Released in<EMAIL_ADDRESS>


readme: update read me to reflect the process made

Commit 9626b4b2d126a95402ea8c660e7c2fabe97d2545 is not signed-off.
Please fix these issues:

Sevki has not signed-off 9626b4b.

If you'd like more information on how to sign your commits please visit signed-off-by.me

rebase it.

rebase it.

Travis error due to problems derivated from the cleaning process in Feb. Redone in #802


[question] is it compatible with v45?

The ThunderStore says the last update date of mod was 3 weeks ago, is it compatible with the new version of game that came a few days ago?

Yes it should be compatible without any changes. Feel free to try it out.
That being said I am going to work on an update to integrate it into the new settings menu soon.


right_st validate on simple example errors on published rightscripts

I can't for the life of me figure out what is wrong with my template yml, it works if I make all scripts local.
$ right_st st validate tmp/PC_10_hello-app/PC_10_hello-app.yml                                                                                tmp/PC_10_hello-app/PC_10_hello-app.yml: yaml: unmarshal errors:
line 10: cannot unmarshal !!map into string
line 13: cannot unmarshal !!map into string
line 16: cannot unmarshal !!map into string
line 19: cannot unmarshal !!map into string
line 22: cannot unmarshal !!map into string
line 27: cannot unmarshal !!map into string
line 33: cannot unmarshal !!map into string
line 36: cannot unmarshal !!map into string
line 40: cannot unmarshal !!map into string
line 43: cannot unmarshal !!map into string
PC_10_hello-app.zip

fixed in latest version


nuxtServerInit calling twice

I know that this issue is well known. But in road map i dont see in which step resolving this problem.
Versions

nuxt: v2.14.0
node: v14.12.0

Steps to reproduce
Open chrome dev tools and refresh a page
What is Expected?
nuxtServerInit will be called twice

Hi，
Is the problem solved?

Could you provide a code reproduction?

@danielpost
Just create store/index.js and put any code to nuxtServerInit
export const actions = {
    async nuxtServerInit ({ dispatch }, { res }) {
        await this.$axios.get('test/any/request');
    },
}

@danielroe Maybe my bad, maybe bad explanation.
This issue happens while creating on local machine with vue devtools and opened chrome dev tools.
While dev mode npm run dev, in production mode everything works fine.


[WFCORE-3868] Notify the suspend listener when timeout is 0

If a ManagerExecutor is executing a task which is re-scheduling a new instance of itself just before exiting then the domain cannot be stopped when the timeout of stop operation is 0.
The problem is the listener is not notified when the user uses 0 as a timeout.
Since EE subsystem is not available in wildfly-core, I will add a test case in wildfly once this patch is merged and available from wildfly.
Jira issue: https://issues.jboss.org/browse/WFCORE-3868

Core - Full Integration Build 7479 outcome was FAILURE using a merge of 853be00a95920c0369c602bf519a26f9901d09de
Summary: Tests passed: 959, ignored: 73; exit code 1 (new) Build time: 00:08:11

This PR can merged as it is. I've opened https://issues.jboss.org/browse/WFCORE-3905 to track Brian's comment for improvement


Bug: Cursor jump to the end of the document when a collaborator deletes focusing paragraph

Lexical version: 0.14.5
Steps To Reproduce

Launch the Playground in collaboration mode
Open two windows (A and B)
In window A, select a line
In window B, delete the line that is selected in window A
The focus in window A moves to the end of the document

The current behavior
In the video, cursor in the right window jump to the end of the document when the paragraph is deleted from the left window.
This issue forces the cursor to the end of the editor during collaborative editing, which disrupts smooth editing experience.
https://github.com/facebook/lexical/assets/111737064/ad9ead44-d2ad-435c-aeb3-148dc1cc54cf
The expected behavior
The cursor should not move to the end of the document when the collaborator deletes focusing paragraph.

I already have solution

Nice find!


Add filter support to prometheus /api/v1/labels /api/v1/{label}/values

Not sure if my implementation is really ideal. Atm the querier.go of prometheus does not supprt filter support for metric and label searches. please review if what I do is really ok :)
This pull request implements the following changes:

Ensure that the matchers are matched against the Tags Array/Column.
For LabelNames() the matchers are performed against the Tags array column (by using index.TaggedTermWhereN)
For LabelValues() the same is done + LIKE name=% is added as a where condition for Tag1.

If no matchers are provided graphite-clickhouse should work exactly like before.
If a matcher is provided it is matched against the Tags column.
In our case we use the stack with multi tenant support. So a proxy before graphite-clickhouse performs authentication and injects a label into all requests. {x=y}.
This change ensures that LabelNames() and LabelValues() only returns results which match {x=y}
@bzed

https://github.com/go-graphite/graphite-clickhouse/pull/267/commits/a338baf6cd997d801cf5210f72b4be23b8b4ada3 adds a filter to LabelNames to prevent 'name' / the metric tag from being shown. From my understanding name is always the tag for metric names. So it does not need to be listed.
Problem here is that grafana etc. show this label in the label list and if people select it then grafana complains about invalid queries.

I assume the tag should not be shown?

closing this, creating a new one from a feature branch. master was a bad choice


tour: [local] No way to interrupt looped exercise from GUI

Context: /flowcontrol/8
Sorry if this was reported already but quick search didn't yield anything resembling this problem
Description:
I pressed "format" button during exercise execution and console part of UI returned to "idle" state but program continued to run independently in the background causing my machine to overheat. Interrupt button would be nice. I ran gotour on OS X Yosemite if this makes any difference.
Thanks for all the hard work creating this fun concise language! :+1:

@campoy there should be a 'kill' button on the tour interface in local mode. The playground infrastructure supports it.

Agreed, I added this to my todo list and will take care of it after gophercon.

Button Kill added with https://go-review.googlesource.com/#/c/12377/2

This is now live on tour.golang.org


Handle phantom mouseevents

I abandoned the other PR and created a new one.  I don't know why the html file is different than what you have in your master. But that's what the grunt docco task spat out.
Here is the comment from the other PR:

I was waiting and waiting for my idle event to occur but it never would. After turning on monitorEvents(window) in Chrome devtools I could see why. There were mousemove events occurring when the mouse wasn't actually moving! I have a wireless mouse, so I just turned it off with the switch. Still, phantom mousemove events kept pouring in at random intervals. I did some Googling and I'm not crazy. This does happen to other people. So I put in this bit of code to filter out mousemove events where there is no actual movement. It fixed my problem.

I'll implement your changes to new version. Thanks


ui: show tags only for supported resources

Description
Tags in info card of the UI are related to tags functionality(create/delete/listTags API)
UI was incorrectly showing storage tags as these tags in the UI.
Fixes #5727
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
Before:

After:

How Has This Been Tested?

Using UI

@blueorangutan ui

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5798 (SL-JID-923)

@blueorangutan ui

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5798 (SL-JID-924)

Thanks for fix @shwstppr. #5727 bug also reports about tags for host, Can you please consider fixing that as well, it says after adding tags, it is not displaying the tags. I've checked that and there is an issue.

@harikrishna-patnala made change to show tags only for supported resource types

@blueorangutan ui

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_multiplication_x:
(SL-JID-928)

@blueorangutan ui

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5798 (SL-JID-929)


Automatic hmrDelay activation with a warning, for big eleventy/typescript rebuilds

TypeScript has a bug, it will touch all files in --build mode. This leads to too many [ESM-HMR] reload. Please add a throttle on it thanks

Check out hmrDelay which should give you what you need here.
A good feature would be to detect that this was happening, and then  automatically increase hmrDelay

I believe something like a quick check of the number of files then increase the delay based on that @FredKSchott ? Is there a direct correlation to safely increase the hrmDelay

I believe something like a quick check of the number of files then increase the delay based on that @FredKSchott ? Is there a direct correlation to safely increase the hrmDelay

@FredKSchott Can I look into this issue?


Terran workers building metric does not align with building build time

Updated gatherGas function to only move mineral workers to gas.


Add stake module

Fixes #243

Codecov Report

Merging #253 (a572a2f) into master (06db6e2) will decrease coverage by 2.32%.
The diff coverage is 1.71%.

@@            Coverage Diff            @@
##           master    #253      +/-   ##
=========================================
- Coverage   10.53%   8.21%   -2.33%
=========================================
  Files          43      62      +19
  Lines        6058    8221    +2163
=========================================
+ Hits          638     675      +37
- Misses       5355    7481    +2126
  Partials       65      65

Impacted Files
Coverage Δ

x/stake/handler.go
0.00% <0.00%> (ø)

x/stake/keeper/encoding.go
0.00% <0.00%> (ø)

x/stake/keeper/genesis.go
0.00% <0.00%> (ø)

x/stake/keeper/grpc_query.go
0.00% <0.00%> (ø)

x/stake/keeper/keeper.go
0.00% <0.00%> (ø)

x/stake/keeper/msg_server.go
0.00% <0.00%> (ø)

x/stake/keeper/params.go
0.00% <0.00%> (ø)

x/stake/keeper/stake.go
0.00% <0.00%> (ø)

x/stake/module.go
0.00% <0.00%> (ø)

x/stake/types/codec.go
0.00% <0.00%> (ø)

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06db6e2...7dfad73. Read the comment docs.

:1st_place_medal:


Have different versions of solidity & at least 0.8 of solidity

It would be good if people could install this package for different versions of solidity, so we will need version 0.8 of solidity.

Now the Foundry-Chainlink toolkit supports Solidity compiler versions in the range [>=0.6.2 <0.9.0].


3dtransforms

Replaces https://github.com/cfpb/cfgov-refresh/pull/2761#issuecomment-298882841

hey, give it a go on Android 4.2 / IE9 on sauce. If it's good, then merge at will.

:+1: with the same caveat as @sebworks

Finally got around to testing this again. Lowest Sauce Android is 4.4 as far as I saw, and works there. Seems fine in IE9 too.


11 Related Safe Addresses

Related Safe Addresses
0x73821b41b8464007e0c53c8febda85d8936c3255
0xdf3ed665e9bac427c3c6f16529f5f70e82a7b945
0x8abd461178112feb783c2731eaec26a036e3d64d
0xd46fc741c6eceec160590b1bac259c2abb75126d
0x71e3e1e294eb5ebb1f41e134585e7906bfc9d78a
0xe8cf9acdfd521c55e81945b374597e50b8c50626
0x047248db3abaa80d2afdcd0f262abb7effabc1ff
0x7dabb3dc25dd46eb490242c2f37096154121fed3
0x9bc926bb9ed59a2a5718d079164c4c8587b4e8f9
0x668532fec67647e28fe1ce80ef377201b0b719e3
0x9af516f950386684223b5c7a341b188be640ad31
Reasoning
These safe accounts are all created by 0xbbc3ee24dd7e9511816ca2c6f1cb7e2fd909e321
We can see through this link：
https://etherscan.io/address/0xbbc3ee24dd7e9511816ca2c6f1cb7e2fd909e321
Methodology
##using the sql query：
with target as (
select *
from url('https://raw.githubusercontent.com/safe-global/safe-user-allocation-reports/main/safe_user_allocations_reworked.csv', CSVWithNames)
), transactions as (
select t1.*
from ethereum.transactions t1
join target t2
on t1.to_address = t2.safe_address
)
select distinct to_address
from transactions
where from_address = '0xbbc3ee24dd7e9511816ca2c6f1cb7e2fd909e321'
-->
Safe Address
0xD12f90cF187169C1C8b3E2b220E14061EB56109C

Reasoning
These safe accounts are all created by 0xbbc3ee24dd7e9511816ca2c6f1cb7e2fd909e321

Creating a number of Safes from the same account doesn't mean it's airdrop farming. It's quite common for projects/users to own multiple Safs.


added fullkeyandchain.pem support

#528 : this feature adds support for fullkeyandchain.pem. It will contain the merged key and fullchain.

Closed. See #528 for details.


Inconsistency in data type nomenclature

By reviewing #1157 , it appeared that there are different styles of nomenclature for the data types. We have:

data.ACCIDENTAL.GESTURAL (plusdata.ACCIDENTAL.GESTURAL.basic and data.ACCIDENTAL.GESTURAL.extended)
data.DURATION.gestural
data.PITCHNAME.GES

While there is nothing wrong with it in the sense that it works, we should consider consolidating those names some day.

@bwbohl Could you propose a scheme? Should everything be data.UPPER.UPPER.UPPER? Or just "official" customization/module names like CMN?

Hm. I moved this to the v5 milestone because I thought it would be addressed with #1181. Renaming all the data classes sounds like a post-v5 task, so I would suggest @bwbohl 's comment (and following discussion) be filed as a separate issue.

We can go that way and make tat a v6 issue

@pe-ro & @kepper has there been an "official" naming-scheme in the past?

The general pattern for datatypes is data.UPPERCASE.lowercase.  The 3rd part of the name functions as a qualifier, sometimes by repertoire, sometimes signifying membership in a higher order class, sometimes for distinction between two similarly named datatypes that couldn't be differentiated by name alone.
The exceptions to this that I could find with a quick visual scan are data.OCTAVE.DIS, which I would rename to data.OCTAVEDIS, and data.PERCENT.LIMITED and data.PERCENT.LIMITED.SIGNED, which can be renamed to data.PERCENT.limited and data.PERCENT.limited.signed (or data.PERCENT.limitedsigned), respectively.  It would be good to search for other exceptions with a regex.
In the case of note head modifier datatypes, data.NOTEHEADMODIFIER.list can be renamed as data.NOTEHEADMODIFIERLIST, and data.NOTHEADMODIFIER.pat can be renamed to data.NOTHEADMODIFIERPATTERN with no ill effects.

Closing this one as the specific issue has been solved. @bwbohl Please open a new one for post-v5.

The general pattern for datatypes is data.UPPERCASE.lowercase. The 3rd part of the name functions as a qualifier, sometimes by repertoire, sometimes signifying membership in a higher order class, sometimes for distinction between two similarly named datatypes that couldn't be differentiated by name alone.

@pe-ro :
So for absolute consistency, it shoud be:
data.ACCIDENTAL.mensural
data.ACCIDENTAL.mensural.basic
etc. right?
Nevertheless, we have a local consistency with #1181 now. Thx @rettinghaus !
As there is no sense in fixing the others in a rush, I added the new issue #1194 to the MEI 6  Milesonte

@bwbohl,

So for absolute consistency, it shoud be:
data.ACCIDENTAL.mensural
data.ACCIDENTAL.mensural.basic
etc. right?

that's correct.


Search input is multiline

The EditText for search is multiline (it just shows one line at a time). This can be fixed by adding: android:inputType="text" to the country_code_picker_search EditText

thanks will fix in the next release


Development branch

Do we make all changes to the master branch itself or will there be a development branch for that?

I think there will be a seperatte branch for each feature.

@kjain1810 Refer to the #general channel on Slack for an overview of how the development process will happen.


Update e2e-test-kind to pull image from quay.io

Issue link
Closes https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/661
What changes have been made
echo-server:1.0 pulled from quay.io instead of  dockerhub.io
Verification steps
Re-run e2e-test-kind
Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[x] Unit tests
[x] Manual tests
[ ] Testing is not required for this change

@asm582 could you give this a try on your M1 laptop.


ALB Ingress Controller Reconciliation Slowness

Hi,
We're noticing that new ingress resources can take up to 10-20 minutes sometimes to reconcile new ingress resources.  Most of these clusters have approximately ~25 existing ingresses that already exist.  Is it possible that increasing the worker threads of the controller would help to boost how fast reconciliation is occurring? I noticed there is an "undocumented" flag for this:  --max-concurrent-reconciles.  Not sure what ramifications if any, if we bump this past the default of 1?
https://github.com/kubernetes-sigs/aws-alb-ingress-controller/blob/v1.1.9/internal/ingress/controller/config/config.go#L85
Thanks.

Tagging @M00nF1sh

@niroowns
Hi, Is there any logs in the controller, like some API got throttled? (increase the worker thread won't solve it).
10-20 minutes most likely caused by some error prevented the controller to create the infrastructure, and it backoff retries from 10ms to 16 minute. there should be logs in the controller pod.

@niroowns
Hi, Is there any logs in the controller, like some API got throttled? (increase the worker thread won't solve it).
10-20 minutes most likely caused by some error prevented the controller to create the infrastructure, and it backoff retries from 10ms to 16 minute. there should be logs in the controller pod.

Hi - Just sent them over.  Hopefully they get sent your way.

We're noticing that new ingress resources can take up to 10-20 minutes sometimes to reconcile new ingress resources. Most of these clusters have approximately ~25 existing ingresses that already exist.

We're also noticing this issue with sometimes longer delays (for a similar number of ingresses). Curious to see if you've made any progress on this @niroowns?

We're noticing that new ingress resources can take up to 10-20 minutes sometimes to reconcile new ingress resources. Most of these clusters have approximately ~25 existing ingresses that already exist.

We're also noticing this issue with sometimes longer delays (for a similar number of ingresses). Curious to see if you've made any progress on this @niroowns (and have additional findings to share maybe)?

Hi @dabcoder - unfortunately not yet.  Will update back this thread once we make some progress.

@niroowns @dabcoder
Please try out our new v2.0.0 release, it dramatically improved the AWS API usage, which should solve this problem.
closing this, feel free to reopen if such issue exists in our v2.0.0 release.


Children blocks with custom transformers are not included in the output of blocksToMarkdown

This recent change broke all children with custom transformers when using blocksToMarkdown.
I understand the change was made to prevent some duplicate markdown from being created (#62), but I think a different solution is needed.
Consider the simple use case of a numbered list with sub items.

One

Sub one

If I call blocksToMarkdown on the first item, my numbered_list_item custom transformer used to be called for both items and both items would end up in the output.
Now, the child never makes it to the output at all.
This is true of any child with a custom transformer.
Was this an oversight?
Or did you intend that if a custom transformer was used that the transformer should be responsible for handling the type and all its children?
If the latter, could you provide an example of how this can most easily be accomplished?

Hi Andrew. I tried replicating the issue.
Considering bulleted_list_items

One
i sub one

and following a custom transformer.
n2m.setCustomTransformer("numbered_list_item", async (block) => {
  // deal with the block and it's children as per your need
  console.log(block);
});

Custom transformer deals with that specific block type and one has to deal with the children of that block.
When the custom transformer doesn't return anything (like in the above snippet), it should parse the numbered_list_items normally. However, on replicating the issue it doesn't work as intended.
Before proceeding I would like to confirm is this is the problem you are facing?

Clearly it is a huge tradeoff being made here as there is a higher need for child handling than synced block handling I believe.


The way the metric tests are set up is broken: slows down development of the project as a whole

Problem
We're currently adding all tests for all metrics inside the same test fixture in MetricsTest. This can unnecessarily create coupling between tests which then turns into impediments.
Example 1:
The job asking for implementation of NHD. The decision was made to use a certain value that happens to be incompatible with the current test fixture. A puzzle was left to add those test cases later. This puzzle shouldn't have been required in the first place if the tests would've been implemented separately.
Example 2:
Adding method-method interactions is introducing extra <op> which consequently breaks some existing tests, leading one to then have to create a puzzle to fix those later.
[EDIT]
Another symptom of this problem is that I keep having to constantly solve merge conflicts on my PRs long after I initially delivered them
Proposal
Let's separate tests for each metric. Each metric can have its own test class (eg. NhdTest) with its own @Test methods. Each metric should also have its own set of test resources in its own folder, separate from the rest (eg. org.jpeek.samples.nhd).
Any reusable test functionality could be refactored into its own "helper" class in the test packages.

@yegor256/z please, pay attention to this issue

@yegor256 WDYT?

Someone in another issue explained a few of the guiding principles of this project's management to me and I've now come to realize that most of the problems described in this issue is beyond the scope of my role in this project, so I'm closing this.

Job gh:yegor256/jpeek#164 is not assigned, can't get start time

Job #164 was not in scope

@llorllale you can submit bugs no matter what is your role. This ticket was a good one, but I would not accept it anyway, since I think our current configuration of tests is good enough. But, again, don't hesitate to submit bugs -- you have nothing to lose. If they are accepted, you earn. If they are not, you just move on.


Update zookeeper dependency to latest chart

Allows more configuration to persistence layer and nodeSelector

Thank you for contributing to kubernetes/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements
https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices

For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:

https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.

Please bump the chart version

@lachie83 forgot about that.  Done.

Regenerate the requirements.lock: helm dep up

/assign

@unguiculus done

/ok-to-test

/lgtm


Harvest should support StorageGRID Azure AD SSO auth

hello @cgrinds
Thanks a ton for your quick response. Apologies if my last question was confusing. So when the SSO was disabled we were able to make it work using local users but with the new security standard we need to use SSO on our Storagegrid System.
The link I provided helps us get a "token" which we can use for the api operations. So was hoping once you get the token rest of the harvest related operations should be same.
Do I need to raise it as an issue for the feature request ?
Originally posted by @santosh725 in https://github.com/NetApp/harvest/discussions/2048#discussioncomment-5819128

See latest comment.
Moving out of 23.08

With change #3408, Harvest's StorageGRID collector will use authTokens returned from credential scripts to authenticate with StorageGRID.
To write a credential script use StorageGRID's provided script.

Verified on 24.08.0 commit 0d2d7b4c
with unit test and made sure that authToken, returned from script, is set as the Bearer token in the request header for the StorageGRID client.


Saving file with Color Scale makes file corrupted

Creating XLSX file with "Color Scale" conditional formatting, parsing it using rubyXL and then saving (without modifying the file) makes file corrupted.
Steps to reproduce the problem:

Create spreadsheet file using LibreOffice or GoogleDocs.
Add numbers to several rows in one column
Add conditional formatting for that cells (Format > Conditional Formatting > Color Scale).
Save file to XLSX (LO) / Download as XLSX (Google Docs)
Use gem to parse and write file to disk like this:

irb
irb(main):001:0> require 'rubyXL'
=> true
irb(main):002:0> puts Gem.loaded_specs["rubyXL"].version
3.3.29
irb(main):003:0> workbook = RubyXL::Parser.parse("example_lo_calc.xlsx")
=> #<RubyXL::Workbook:0x000000015d04c0
(...)
irb(main):004:0> workbook.write('output_lo_calc.xlsx')
=> "output_lo_calc.xlsx"
irb(main):005:0>  workbook = RubyXL::Parser.parse("example_google_docs.xlsx")
(...)
irb(main):006:0> workbook.write('output_google_docs.xlsx')
=> "output_google_docs.xlsx"

When I open file in LibreOffice, Color Scale are changed
Before (example_lo_calc.xlsx):

After (output_lo_calc.xlsx):

Same thing happenes with files exported from Google Docs:
example_google_docs.xlsx -> output_google_docs.xlsx

Also, I have found that every time I try to upload any of output_*.xlsx file to Google Docs I see "Sorry, can't import this file right now. Try again later.".

The message does not appear for 'example_*.xlsx' or any other files.

@MartinKravec please pull the new version and give it a try.


[CLI]: run.history(keys=['key1', 'key2']) return empty array

Describe the bug

I am trying to fetch history, but it returns an empty pd.Dataframe when specifying more than 2 keys. With one key it returns the history of the specified key.

 run.scan_history(keys=['key1', 'key2']) # return nothing
 run.scan_history(keys=['key1']) # return history for 'key1'
 run.scan_history(keys=['key2']) # return history for 'key2'

I assumed that more keys could be specified. Is it a bug or a feature?
Additional Files
No response
Environment
WandB version: wandb-0.15.0
OS: MacOS 13.2.1
Python version: 3.10
Versions of relevant libraries:
Additional Context
No response

Hi @zdeneklapes, is an object returned by run.scan_history(keys=['key1', 'key2']) at all or is it just None? I wasn't able to reproduce this even if I use a key that isn't actually included in the history.

Hi @zdeneklapes, I wanted to follow up and see if this is still an issue?

Hi @nate-wandb, I am sorry for the delayed answer.
Please refer to this example:
import wandb

wandb_api = wandb.Api()
run = wandb_api.run("investai/portfolio-allocation/runs/8tml2ozg")
key1 = "test/reward/model"
key2 = "test/reward/maximum_sharpe_0_1"
print_samples = 10

# Issue: Print nothing
history1 = run.scan_history(keys=[key1, key2])
print([row[key1] for row in history1][:print_samples])

# Ok
history2 = run.scan_history(keys=[key1])
print([row[key1] for row in history2][:print_samples])

Thank you @zdeneklapes. I'm able to reproduce the issue in your project with the code you sent but if I call the same thing on one of my runs it works as expected. My initial thought was the deeply nested metric names but I tested that and it was not the case.
import wandb

api = wandb.Api()

run = api.run("nathank/test-scan-history/2yi2qtsk")

key_1 = "deeper/nested/metric_e"
key_2 = "deeper/nested/metric_f"

hist_1 = run.scan_history(keys=[key_1, key_2])
print([row[key_1] for row in hist_1][:10])

Outputs [-1000, -999, -998, -997, -996, -995, -994, -993, -992, -991] as expected.
How many rows are in your history? It may be related to a very large history table but it's a little unclear why this would return None

Hello @nate-wandb,
the table contains approximately 53k rows, but the specific key I am interested in only has values starting from the 50k step. So, it only contains values between rows 50k-53k and is null elsewhere.
Thanks!
Zdenek Lapes

Hi @zdeneklapes, I was able to replicate this finally. It turns out that filtering using the keys will only return steps where both keys have logged a value. So if steps 0-10 only record metric_1 and steps 11-20 only record metric_2 then nothing would get returned by  run.scan_history(keys=["metric_1", "metric_2"])
I think the preferred behavior here would be to return steps that contain EITHER metric correct? If so, I can make a request for this.

Hi @nate-wandb, well done!
I think the preferred behavior can be interpreted by each user differently. Perhaps it would be better to allow users to choose whether they want steps with all metrics available or at least one metric available.

@zdeneklapes Glad we got to the bottom of it! Ok, I'll mention that in the feedback to the team. I'll follow up once the engineering team has a chance to look into it.

Also ran into this problem just now. Took me more than an hour to figure this out. Please clarify this in the docs at least!

Thanks for raising this @ratheile. I've added to the feature request to clarify this behavior in the docs so other users don't run into the same thing.

Thank you! @nate-wandb


init setup

@amnona, let's start populating it!

If defaulting to sparse, then it seems like quite a bit of replication of biom.Table?
Note: in BIOM, we originally supported both dense and sparse, only to realize that the support for dense made the code much more complex and the subsequent benefit in practice was essentially non existent

While making the code more complex, i think there are a lot of use cases for analysis where we need a dense matrix, and converting each time before running can slow down the processing?

meh...? This is with a much denser matrix that we'd normally be operating on (50%)
In [9]: x = np.random.randint(0, 2, (10000, 1000))

In [10]: y = csr_matrix(x)

In [11]: %timeit y.toarray()
10 loops, best of 3: 62.1 ms per loop


Bugfix for Affiliate Marketing in Registration

1. Why is this change necessary?
Contrary to what is described in the documentation (https://docs.shopware.com/en/shopware-6-en/tutorials-and-faq/affiliateprogram), you have to specify both marketing codes in order for them to be saved during registration.
2. What does this change do, exactly?
It ensures that even one specified parameter is stored.
3. Describe each step to reproduce the issue or behaviour.
Add only affiliateCode or campaignCode parameter to teh URL and register an account.
You can't see the parameter at the customer.
5. Checklist

[ ] I have written tests and verified that they fail without my change
[X] I have squashed any insignificant commits
[X] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @Novusvetus, thank you for your contribution! :blue_heart: :tada:
To ensure that this bug does not pop up again, please add two test cases to the \Shopware\Storefront\Test\Controller\RegisterControllerTest, that check that the marketing codes are saved if only one is set.
The \Shopware\Storefront\Test\Controller\RegisterControllerTest::testGuestRegister TestCase can serve as a blue-print for your test cases.

Hey,
I am closing this as this PR is inactive. Feel free to create a new pull request when you fixed the missing things.


Updated newtype hint to account for unboxed types

The program
{-# LANGUAGE MagicHash #-}
import GHC.Prim

data X = X Int#

will give the suggestion that you should declare X as a newtype, which is incorrect. While the style of definition above is very rare in Haskell, it's quite common in Eta when declaring wrappers for Java objects so in bindings to Java libraries, you'll be flooded with the incorrect hint above.
This change assumes that all types ending in # are unboxed, which is a reasonable assumption make.

Thanks for the patch! I actually tried your example and it still warned for Int# - my guess is you were missing the case for TyCon directly not wrapped in TyApp. I refactored the code to use a few utilities I already have in HLint, moved the HSE utility to HSE.Util (that's where I keep all my HSE utils) and did a few other tweaks - but it's pretty much following your logic.

Thanks! I was not aware of HSE.Util - I'll keep that in mind for future PRs. The refactored code looks very clean and nice.


Correction for raw affiliation Information and Systems (MIS) Laboratory, University of Picardie Jules Verne, GRECO Institute, Amiens, Modeling, France

Correction needed for raw affiliation Information and Systems (MIS) Laboratory, University of Picardie Jules Verne, GRECO Institute, Amiens, Modeling, France
raw_affiliation_name: Information and Systems (MIS) Laboratory, University of Picardie Jules Verne, GRECO Institute, Amiens, Modeling, France
new_rors: 01gyxrk03
previous_rors: 00b4yme84;01gyxrk03
works_examples: W4388754831
contact: c0e5a81c0e448da825466db00a388cfc:91aaac499d774f4983622ee6cfced03b @ u-picardie.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


Preview Browser not shown

Latest insiders I get the following when clicking 'Preview in Editor' instead of the preview browser:

Version: 1.57.0-insider
Commit: 45aafeb326d0d3d56cbc9e2932f87e368dbf652d
Date: 2021-05-18T05:12:52.309Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0

@mjbvz the URI that get's passed to the simple browser opener still looks good to me.

@chrmarti Is this when connected to a remote?

@mjbvz Yes.

This has the same root cause as #123751

Should be fixed by 18ea5ac15e6c109184d70eb5d15eeee1a3ca096f
Let me know if you still see this in the next insiders build


On pull request, check run Safe-setting validator is created but never runs ("Not working on a PR, returning...")

Why are you seeing this issue?
This is a support escalation! You can find out more about expectations on communications and response times in the on-call docs. Thank you for doing your part to keep GitHub customers happy!
Severity
Note, for Sev1 issues always page the team first, using the PagerDuty information in the service catalog and the command .pager trigger <rotation> <reason>. Opening an issue for a Sev2 incident can come later (and can be done by the available Escalation Engineer).

[ ] sev1 - Engineering must respond, when paged, within their on-call SLO
[ ] sev2 - Engineering must respond to this issue within one business day
[x] sev3 - EPD squad for the team must respond to this issue within one week

Service
safe-settings
Issue
Customer reports the following:

We are observing a behavior with Github App Webhook callbacks for Check Runs which is affecting our deployment of the tool Github Safe Settings (https://github.com/github/safe-settings - Note that this is a first-party tool provided by Github).

The observation is that Github Safe Settings creates a check run on the head SHA of a pull request. It then expects to be called back by Github via the Webhook API from Github for the creation of the check run, with the pull request set in the payload (under check_suite.pull_requests).

In our deployment, I see that sometimes the webhook deliveries from Github have an empty check_suites.pull_requests list. This breaks safe-settings' handling of pull requests (safe settings just ignores the event, resulting in a check state that is stuck at "pending" indefinitely).

An example affected delivery from a just now:
Full payload: https://gist.github.com/andi-bigswitch/afa4f475b257529a3305c4e5d8e3c360
Relevant excerpt: (note: check_suite.pull_requests is empty).

    "check_suite": {
      "id":<PHONE_NUMBER>8,
      "node_id": "CS_kwDOKfMBec8AAAAEFP3d5g",
      "head_branch": null,
      "head_sha": "ca4d9be08ab0e6b6756ea4991f997fa04644b7b1",
      "status": "queued",
      "conclusion": null,
      "url": "https://api.github.com/repos/bigswitch/admin/check-suites/17532050918",
      "before": null,
      "after": null,
      "pull_requests": [

      ],

My question: Should the webhook payload for check_run.created contain a non-empty check_suites.pull_requests if the head SHA is associated with a PR (i.e., this needs to be fixed on the Github.com side) or is safe-settings making an invalid assumption (safe-settings needs to be fixed)?

Customer Impact
https://github.zendesk.com/agent/tickets/2393203
GitHub Product(s) Impacted (check appropriate boxes and provide GHES version if applicable)

[x] GitHub.com (including GHEC)
[ ] GitHub Enterprise Server.
If GHES, please list the version of GHES the customer is on here:
[ ] GHAE

Additional context
Customer opened the question here as well https://github.com/github/safe-settings/issues/540
cc:
@github/professional-services
@product_manager
Support Squad(s): @github/support-squad-ecosystem @loujr

Closing for duplicate issue https://github.com/github/safe-settings/issues/540


Railtie Hooks & Templates

Will we need a Railtie hooks so we can initialize better? Maybe templates for SAM YAML or bin scripts?

We actually got this during #19's development. Still a lot of places we can go, but so far I am fine with what we have.


Fresh install broken

So, just wanted to point out that a fresh install does not work. It's not this project's fault; it's a dependency that got broken somewhere along the way. I fixed it in my project, and anyone else can do the same.
I submitted a pull request to webpack-dev-middleware so if someone wants to copy that code, that will make the project work for them (hopefully :) ).

Of course, we could do something like a script in postinstall that patches the broken dependency, but I don't know if you want to mess with that. It would be pretty easy though.

Went ahead and submitted a pull request, just in case.

Nevermind, they just fixed the problem with webpack-dev-middleware


Add more ngx_lua builtin definitions.

OpenResty has extended the standard LuaJIT in their LuaJIT fork:
https://github.com/openresty/luajit2

@spacewander thank you!


Camera Preview Start Up Delay

Describe the bug
Camera preview takes 2x as long as regular camera package to show the preview.
How to reproduce
Call the CameraPicker.pickFromCamera function using any config.
Steps to reproduce the behavior:
Open the wechat camera picker and wait 2+ seconds of black to see actual camera preview
Expected behavior
The camera preview screen to show nearly instantaneously or under 1 second like the Camera package.
I noticed some apps grab 1 frame and sometimes blur it until the live preview fully kicks in. perhaps that's their workaround?
Screenshots (If contains)
Version information

iPhone 12
iOS 15.3
Package Version: wechat_camera_picker 3.2.0+1
Flutter Version: 2.10 and/or 3

Additional context
I don't doubt if there's an unavoidable delay before camera preview appears, but this package in particular takes extra long compared to other camera packages. it may be by design to fade in from black rather than an abruptly appearing video preview, but i think that should be an option.
Also, if there would be a way to keep the camera preview loaded for instant reveal, that would be useful. Or leave camera preview going for 1-2 seconds after it's use in case you want to flip back open the camera real quick.

This is intended. We have an existing issue targeting camera tracking this: https://github.com/flutter/flutter/issues/57831
TL;DR, we want to provide the best experience when recording without any black/blank frames. To do so, proper preparation must be called before recording:
https://github.com/fluttercandies/flutter_wechat_camera_picker/blob/2b29dfa0e6d0bb946beab00b263cb8809e39af90/lib/src/widgets/camera_picker.dart#L416-L418
It's a trade-off between missing frames and a longer initialization duration. No matter where you put the preparation, that would be unavoidable to wait. We've compared various experiences by putting the preparation into different callers, such as just before the recording started. The best would be at the initialization at present.
To avoid waiting when you don't want to record, you can disable the record and the preview should be the same compared to other camera packages. Otherwise, I would consider it as not doable.
Closing as it's a won't fix issue, but feel free to leave more thoughts.

Yeah I hear you. I prefer a slight jank over just a black screen. Black feels like something is lagging or broken.
How about an option to show a custom widget during initialization so we can add shimmer or color fading animation or circularprogressindicator or whatever. Similar to your overlay option but during the initialization period.
What I've done is immediately record a 300ms blip of video as soon as the camera initializes. There's a little hiccup/jank but then the recording is always smooth afterwards and no black frames. Assuming that's what you're doing behind the black?
I also like the idea/option/feature of showing the camera preview immediately, recording a 300ms and blitting it to the screen and possibly blurring it until the camera is fully ready. I like the fade in of the camera you have for sure, but plain black just feels like something is missing.
Also, wanted to note that this delay happens when switching cameras from front to back etc.

Yeah I hear you. I prefer a slight jank over just a black screen. Black feels like something is lagging or broken.

It's not only a jank produced, but another black screen because it starts another capture session.

How about an option to show a custom widget during initialization so we can add shimmer or color fading animation or circularprogressindicator or whatever. Similar to your overlay option but during the initialization period.

Could be a good option for the experience, I thought about a tip like "Waiting for the camera to be ready..." or some other things. We already have a foreground builder when the controller is initialized, maybe it's easier to implement this request by making the builder available when the controller is not ready.

What I've done is immediately record a 300ms blip of video as soon as the camera initializes. There's a little hiccup/jank but then the recording is always smooth afterwards and no black frames. Assuming that's what you're doing behind the black?

Do you mean using other camera packages? If so, then yes.

Also, wanted to note that this delay happens when switching cameras from front to back etc.

All controllers benefit from the same preparation so yes, they will have the same delay.

Got it. Perhaps you could clone the foregroundBuilder and just make an initilization builder so people can show whatever they want during that brief period.
Great job on the package, lot's of nice details!
Btw, is there any way to minimize the camera to a little floating window? Or is that out of the scope of the project?

Got it. Perhaps you could clone the foregroundBuilder and just make an initilization builder so people can show whatever they want during that brief period.

You can try with this https://github.com/fluttercandies/flutter_wechat_camera_picker/pull/97 to see if it's suitable for your case. The builder is valid when the cameraValue is null which indicates the controller is not yet initialized.

Btw, is there any way to minimize the camera to a little floating window? Or is that out of the scope of the project?

This is indeed out of scope. However, I think it's doable by combining the foregroundBuilder with a custom page route, though it might have other UI issues with the picker layout when the MediaQuery is narrowed.

Great job, working fine here. Thanks!
Is it up to the dev to program when to stop their CircularProgressIndicator/loading animation? Do you get any indicator once the camera is fully live and visible?

Do you get any indicator once the camera is fully live and visible?

The package can only tell whether the controller is initialized, without the information whether the camera preview is visible.

For the record, this is how long the preparation takes:

Got it thanks! Any way to fire off a notification when "Prepared for video recording" hits the log? That way we don't have to muck with timers or guess anything. Or perhaps have an initializingCameraBuilder that shows until "Prepared for video recording" has fired.

Any way to fire off a notification when "Prepared for video recording" hits the log? That way we don't have to muck with timers or guess anything. Or perhaps have an initializingCameraBuilder that shows until "Prepared for video recording" has fired.

Not sure what you need to guess here. The foreground builder is available for the initializations now. If you have more feature request, please file new issues.


Fixed .gitignore to ignore the util/_toolchain directory

Signed-off-by: John Zila<EMAIL_ADDRESS>

The commit message needs a subsystem prefix all: is fine, and the util/_toolchain/.gitignore file should be removed.

LGTM. Thanks!


Document guidelines to enable language features for embedded languages

In VSCode each file is associated with a language. Language supports such as code completion, hovers, are contributed to that language. This is ideally through a language server.
When a language allows to embedded snippets of an other language (e.g. CSS in HTML or HTML in PHP) there are various techniques that a language server can use:

The language server also implements support for the embedded language. It can do that by including libraries that provide that support. For example there are easy to use node modules for css, less, scss, html and json or more basic language supports for typescript
Forward requests to an other language server as done in intelephense

The first approach has the following advantages

Full control of the user experience. Completion proposals, hovers... can be tuned to apply to the situation.
No dependencies on other language servers, self contained server that is easy to embedded also in other editors or IDE.

In either case the embedded content needs to be escaped according to the owner language. E.g > needs to be &gt.

@aeschli Do you think that an extension can make the html part in php get the same behavior as the standalone html file? including let all the plugin for html work fine in that part?
Extension system is really important as we all know, but not all the features are suitable for plugins. What we actually need is parse one file to multiple language and treat them separately. This should be a built-in ability for a code editor.
And, all the PHP files are actually HTML, with a special HTML tag. Only the content in this tag should not be regarded as HTML. It is just a language embedded in HTML and can't work without it (except CLI). So the question is not about HTML in PHP, HTML is the main container. And also lots of language can be embedded in HTML, such as css javascript vbscript svg perl java, I don't think any extension can do this without official support.

@popcorner PHP files are actually not adhering to HTML syntax: <?php is not valid in pure HTML. Although it seems like PHP is embedded in HTML, the syntax is defined by PHP so it's actually 'HTML' inside PHP.
Same with templating languages like Smarty:

{escape}
This is some text I want <> escaped.
{/escape}

(snippet from here
Valid Smarty, not HTML. Try it the HTML validator)
Every templating language has their own way of escaping embedded content and why the HTML language server can't just be easily used. It lacks the knowledge of the embedding language.

The language server also implements support for the embedded language. It can do that by including libraries that provide that support. For example there are easy to use node modules for css, less, scss, html and json or more basic language supports for typescript

The problem is, how can I say I'm the master without maintaining a fork and rule them to only work in specific parts of a file? Why can't the language servers I want to control say what they are able to handle, so I do not need to worry about it and the end-user can install any extension they like, so I do not need to upload an extension douzens of megabytes big to support really any language?

You don't need to maintain a fork. You can forward the requests. But your Smarty server needs to transform the document to valid HTML and then ask the HTML server for the result on this document. That's approach number 2.
You can also tell the HTML language support to handle Smarty files. But it will struggle if the file is not valid HTML.

You can forward the requests.

I'm looking forward to an example code. ;)

Here's how intelephense does it: https://github.com/bmewburn/vscode-intelephense/blob/cdd5f66f09e8ee26a2d69a0799ba761c90bc8d43/src/embeddedContentDocuments.ts#L306
The requests to the PHP language server are injected and instead forwarded to VSCode using a command. That command gets a virtual 'html' document. Whoever registered on 'html' will provide proposals.

Here's how we implemented some time ago for css embedded in html. The server sends the request back the client the client asks other extensions based on a virtual documents that just contain the embedded language content.

I don't understand your last question. Can you rephrase?

You can use Smarty for everything, it's not dedicated to html, css, js, java, xml, json... So in the current version I need to detect which language it actually is, but that's the downside, because I want the language server that the user installed to give me examples of what they are able to handle, so I do not need to worry about, and it's completly modular.

User installs an extension, which provides language support(e.g. PHP).
User opens a smarty file, and the smarty-extension asks vscode for a list of language servers(content providers) and their samples(so what does a php code pattern look like?).
Once the user types in something that (for example) PHP can handle, I know I can delegate the request to the PHP language server and it can handle the request, so I simply wrap it.

That would be sooo easy and soo extensible.

@aeschli the html language server went with option 2 first for embedded languages then changed to option 1 later. Were there other advantages in addition to those listed above that prompted the change in direction?

In that situation one solution could be to provide a config setting so the user can declare what the embedded language is.

I want to make it as simply as possible, prompting the user for this to declare is very likely to include an error or missing an exception.

@bmewburn The main reason was really to be able to control the user experience. For example in the case of JavaScript embedded in HTML, we want to preconfigure the JavaScript language server with the dom definition files.

@jens1o

User opens a smarty file, and the smarty-extension asks vscode for a list of language servers(content providers) and their samples(so what does a php code pattern look like?).

Can you clarify "samples" with examples?
Currently if you want to get HTML completions in your extension, all you need to do in your extensions are three things:

Figure out if the completion position is in HTML or your-lang
If it's HTML, create a virtual HTML document with the embedded content
Call the command vscode.executeCompletionItemProvider.

If you are writing a language server that could handle embedded language X, things such as "getting range and content of embedded regions" (for 1 and 2) should be the language server parser's responsibility.

Can you clarify "samples" with examples?

I mostly mean regular expressions, so to keep it as universal as possible.
I'm not an exact regex expert, but for detecting PHP sections this could be used:
/(<\?(php)?)(.|(\r)?\n){1,}(\?>)?/gim

@jens1o There would be many problems with that approach, just off the top of my head:

PHP server wouldn't be able to control when the request is going to HTML and when it's going to PHP. Also passing data between LS could be very tricky, if it's not controlled by the LS.
LSP is chatty. You might have multiple requests going back/forth for each character entered. VS Code can't run complex regexes on the same file again and again on each document change.

So, I do not have a better solution, yet. Do you have some better ideas?

PHP server wouldn't be able to control when the request is going to HTML and when it's going to PHP. Also passing data between LS could be very tricky, if it's not controlled by the LS.

That's supposed to be like this, because it's the job of the master language server.

LSP is chatty. You might have multiple requests going back/forth for each character entered. VS Code can't run complex regexes on the same file again and again on each document change.

Perhaps we can include sub-languages while only checking whether a specific keystroke is in of the range.
 :: HTML LANGUAGE SERVER DETECTS START OF HTML LANGUAGE

Hello World!

<?php :: PHP LANGUAGE SERVER DETECTS START OF PHP LANGUAGE
| :: CURSOR IS WITHIN THE RANGE OF THE PHP LANGUAGE SERVER; SO ITS HANDLING THE REQUEST
?> :: PHP LANGUAGE SERVER DETECTS END OF PHP LANGUAGE; VSCODE SHIFTS DOWN AND LASTLY RECOGNIZED THE HTML LANGUAGE; THUS ASSUME HTML

 :: HTML LANGUAGE SERVER DETECTS END OF HTML LANGUAGE; ASSUMES FALLBACK LANGUAGE

Would that decrease the cost and pressure of vscode?

@octref @aeschli May I ask at what position this entry is?

@jens1o I've just reworked on the Language Server Guide. This is something I have in mind. I can't promise anything, but probably sometime later this year.

Okay, I'm working on implementing this. I've got one problem though. When I pass vscode the request, it apparently passes it back to me, then I pass it to vscode... Infinite Loop. How can I get around this and declare the specific code-part as another language, so (in my example) the Emmet provider rules it all?

That's the code currently: https://github.com/jens1o/vscode-smarty/blob/a558eb202f91c7657904e4c39a2844529e06fb39/src/completionProvider.ts#L28-L41

@jens1o Can you create a separate request? Thanks!

@aeschli Where? Here?

Just a new GitHub issue.

@octref I see that you closed this issue. Is there a link to the created guideline? I tried following some of the referenced issues, but was unable to find a related guide.

@axelson See https://code.visualstudio.com/api/language-extensions/embedded-languages


Mf2 moved repost context to render_content

All I wanted to do was move the repost rendering into render_content so that we'd get the same HTML rendering in mf2 and Atom conversions without having to add special cases to both.
It ended up being more refactoring than I bargained for, but I'm happy with the result.

@snarfed I know this isn't particularly your bailiwick; take a quick glance if you want to, but no pressure. I'll check over the changes and merge when I'm more awake :)

thanks for doing this! it all sounds good to me. i hear you on the tradeoff between maintenance in the asymmetric exclusions vs in the test data files themselves. i don't have a good feeling for which side will serve us better, but this change makes sense.
being able to exclude specific pairs in specific directions will probably continue to be useful, but that's still as easy now as before iiuc.
i say merge when ready!
btw i always enjoy seeing these changes first in my twitter-atom feed. :P speaking if which, i wonder when we convert twitter.py from favorite to like?! ducks


Bug, new ERRORs after 0.7.24

Observed behavior
After running last 0.7.24 FontBakery version I got some new errors
The report is included on Resources
Expected behavior
The Error to be solved
Resources and exact process needed to replicate
Fontbakery version: 0.7.24

[7] Gupter-Bold.ttf

💔 ERROR: Glyphs are similiar to Google Fonts version?

com.google.fonts/check/production_glyphs_similarity

💔 ERROR Failed with TypeError: new() missing 6 required positional arguments: 'xx', 'xy', 'yx', 'yy', 'dx', and 'dy'

At the same time, it would be great to have the meaning of checks included in the report.md file. Made a comment on this here

@vv-monsalve, I initially thought this ERROR would be in a PR to the google/fonts repo, but I could not find a Gupter PR there.
Then I cloned https://github.com/vv-monsalve/GUPTER.git and tried to run the latest fontbakery (form git master) on the bold ttf from the FONTS/TTF/ directory. FontBakery passes the check:

Please let me know where I can find files that cause the ERROR.

I ran the FB cheks in my local files that are up to date with my master branch of the upstream repo, I didn't change anything on them, so this is more strange to me now.
I did this on this project actually because I wanted to test the upgrade of Fontbakery on an already proved working job. Before it, I tried to upgrade it in another project, but even though I received the "successfully installed 0.7.24" after three attempts, it remained in 0.7.22. It only got updated after I delete the venv and reinstall the gftools.
It had not happened to me before when updating Fontbakery btw.
Link to a copy of my local Gupter folder. On FONTS/TTF, you can find the resulted folders of the two last QA processes performed and a .txt file with the terminal output, so you can check if I did something wrong.

@vv-monsalve, thanks for the feedback!

@vv-monsalve, I have the impression that you have python 2.7 in your virtual environment. Please delete your venv and create a new one using python 3:
virtualenv venv -ppython3
then install fontbakery and try to run the check agains Gupter again and let me know if that solves the issue.

@felipesanches The venv was built on python 3.6.
Nevertheless, I confirmed it and replicated the process and got the same three Errors. New report.md and terminal output here

oh, ok! So maybe you had an older venv folder with py2 in that ZIP file.
Anyway... I'll keep trying to replicate the bug. Thanks for sending more files. I'll look them up now.

Sure, no problem. I gave it a quick look and didn't see python 2.7, strange. I hope the new files are of any help!

It seems like this was caused by conflicts between python versions indeed. After checking this locally with @m4rc1e  I created a new venv with selected python 3.7 and everything worked ok with FB.
Closing this here :)


Allow mints that start after a future block height / time after the rune is etched

Closing in favor of #159.


Toggle hotkey

Hi, great idea to make headings visible in the file explorer, thanks.
I wouldn't mind a toggle hotkey with which you can show or hide the headings. In my use case, I would probably only display them temporarily to quickly search for parts of a document and not have them visible all the time.

Hey, I added an obsidian command to show/hide the headings to address #2 called "Toggle File Explorer Headings". You can set a hokey for that to turn on/off the feature quickly in your settings.

Does this resolve your issue, or is there something else we're looking for, like maybe a UI toggle?

That's already a great help, I was thinking though about a e.g. cmd-ctrl-h hotkey that I can press without having to run cmd-p and search for the toggle. Let me know what you think.

Hi @patrickchiang how silly, I searched for heading and it didn't find anything. So I presumed the feature was not build in yet. Thanks for the pointer!