(65, 71, 82): std.builtin.StructField field_type -> type rename

Working through the exercises with a recent build of Zig from master, I ran into issues in 065_builtins2 (and 71 & 82) because it seems like with this pull request in Zig, std.builtin.StructField's field_type member as been renamed to just type.
Thank you so much for this repository!

@michaelhelvey Thank you very much for your valuable advice. Unfortunately, I can't take your PR as is, since you've included the solutions for this excercise right away. :wink: Therefore, I close this PR and fix the error afterwards.


Error "nix is unable to build packages" when there's nothing to build

Go to https://app.kasmweb.com/#/cast/1481835260 , it's a demo for a web-based Ubuntu desktop environment.
Open a terminal and run:
wget --no-check-certificate https://github.com/DavHau/nix-portable/releases/download/v010/nix-portable
chmod a+x nix-portable
./nix-portable nix run nixpkgs#jq

There should be nothing to build here but it crashes with "nix is unable to build packages"
I ran it with NP_DEBUG=2, here's the log: errorlog.txt

I got that error when I had a nix.conf in my home directory pointing the store to a folder in my home directory that already existed.


Add optimizeDictionaryType config to automatically choose dictionary type

We see some mild improvements from using fixed length dictionaries when all values of a column in a segment are the same length. Since we programmatically manage our columns and use other optimizeDictionary functionality, we'd like to programmatically choose the dictionary type as well.
Previously the creation info is ignored during segment conversion. When the new config optimizeDictionaryType is true, then the creation info is used to determine the dictionary type (fixed width or var width). Tested in our internal cluster, inspected the log added and verified fixed length cols such as hash/uuid only cols use fixed dict, and variable length data uses var dict.
This PR also contains some minor fixes in TableConfigBuilder for missing configs.

Codecov Report
Attention: Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 55.38%. Comparing base (59551e4) to head (a29040a).
Report is 1324 commits behind head on master.

Files with missing lines
Patch %
Lines

...he/pinot/spi/utils/builder/TableConfigBuilder.java
33.33%
6 Missing :warning:

...ment/creator/impl/SegmentColumnarIndexCreator.java
0.00%
3 Missing and 1 partial :warning:

...ot/segment/spi/creator/SegmentGeneratorConfig.java
40.00%
3 Missing :warning:

...pinot/segment/spi/index/DictionaryIndexConfig.java
0.00%
2 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (a29040a). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (a29040a)

integration
7
0

integration2
3
0

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
1

skip-bytebuffers-false
7
0

unittests
5
1

unittests1
2
1

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14444      +/-   ##
============================================
- Coverage     61.75%   55.38%   -6.38%
- Complexity      207      697     +490
============================================
  Files          2436     2096     -340
  Lines        133233   110425   -22808
  Branches      20636    17513    -3123
============================================
- Hits          82274    61154   -21120
+ Misses        44911    44402     -509
+ Partials       6048     4869    -1179

Flag
Coverage Δ

custom-integration1
?

integration
?

integration1
?

integration2
?

java-11
?

java-21
55.38% <37.50%> (-6.25%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
55.38% <37.50%> (+27.65%)
:arrow_up:

temurin
55.38% <37.50%> (-6.38%)
:arrow_down:

unittests
55.38% <37.50%> (-6.37%)
:arrow_down:

unittests1
55.38% <37.50%> (+8.48%)
:arrow_up:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Enhencement] Profile/Preconfigured layout that use splits instead of floating windows like nvim-fzf or CtrlP?

Info
Not related

Description
Floating windows are great for displaying temporary buffers in that they do not ruin the previous split layout. But some people (including me) might find that splits are less intrusive and give more user control to the contents in the buffer displayed, for example, users can jump to the preview window and scroll/copy text directly from there, see the demo of nvim-fzf.
telescope.nvim provides a theme(aka 'profile' for fzf-lua) named 'ivy' to place the telescope window at the bottom of the screen to mimic the Emacs ivy fuzzy finder for a less intrusive experience BUT it's not quite there because it still uses floating windows instead of splits.
It would be great if fzf-lua could have a profile using splits to display fzf terminal window and the preview window (if any), like nvim-fzf/CtrlP/ivy. Since fzf-lua takes inspiration from nvim-fzf, it should not be too hard (idk)?

EDIT: typo

Split option already exists, take a look at the default options:

https://github.com/ibhagwan/fzf-lua#default-options

require'fzf-lua'.setup {
  winopts = {
    -- split         = "belowright new",-- open in a split instead?
                                        -- "belowright new"  : split below
                                        -- "aboveleft new"   : split above
                                        -- "belowright vnew" : split right
                                        -- "aboveleft vnew   : split left
  }
}

These are just recommendations, you can use any neovim command to create the split.

Hi, thanks for your reply.

Split option already exists, take a look at the default options:

How could I miss that? Please forgive my ignorance.
This is the test minimal conifg I am currently testing:
local tmp = '/tmp'
local data = tmp .. '/' .. (vim.env.NVIM_APPNAME or 'nvim')
local package_root = data .. '/site'
local clone_root = package_root .. '/pack/packages/start'
local clone_info = {
  {
    path = clone_root .. '/fzf-lua',
    url = 'https://github.com/ibhagwan/fzf-lua.git',
  },
}

vim.fn.mkdir(clone_root, 'p')
vim.opt.pp:prepend(package_root)
vim.opt.rtp:prepend(package_root)
vim.opt.mousemoveevent = true

for _, info in ipairs(clone_info) do
  if not vim.loop.fs_stat(info.path) then
    vim.notify('cloning ' .. info.url, vim.log.levels.INFO)
    vim.fn.system({ 'git', 'clone', info.url, info.path })
  end
end

require('fzf-lua').setup({
  winopts = {
    split = 'bo new',
    preview = {
      default = 'builtin',
      winopts = {
        split = 'vert new',
      },
    },
  },
})

vim.keymap.set('n', '<Space>.', '<Cmd>lua require("fzf-lua").files()<CR>')

With this minimal config, I can open fzf window as a split, but the preview  is still in a floating window, and once I leave the fzf terminal window it gets closed, making it impossible to put my cursor in the preview window:

I was imagining something similar to nvim-fzf, like this:
https://raw.githubusercontent.com/vijaymarupudi/nvim-fzf-commands/master/gifs/bufferpicker2.gif
where the preview window is also opened as a split side by side to the fzf terminal window.
Also it seems that the relative position is "fixed" using the split layout. Using the floating layout the preview window are automatically adjusted to be shown below or to the right of the fzf window according to the screen ratio, but it does not seem to be the case using split layout?
So for summary, I have these questions:

How to show the preview as a split beside fzf terminal window?
How to prevent fzf auto-closing when I leave the window?
Is it possible to automatically choose horizontal/vertical preview according to the screen ratio when I open fzf?

Thanks in advance!

How to show the preview as a split beside fzf terminal window?

This is not possible ATM, would require new code, given it has been over 2 years and this is the first request ever for this I’m probably not going to invest time in this (would require a major refactor).

How to prevent fzf auto-closing when I leave the window?

It’s possible to wrap an action with {} or add { fn = <action function>, noclose=true } but this is used mostly to open a new interface without a “refresh”, I’m not sure if it will get you what you want.

Is it possible to automatically choose horizontal/vertical preview according to the screen ratio when I open fzf?

Yes, that’s what layout=flex and flip_columns are for.

Emm 'flex' layout does not seem to work -- when the height is small and width is large the preview is still below the fzf window instead of being placed to the right of the fzf window:

Config:
require('fzf-lua').setup({
  winopts = {
    split = 'bo new',
    preview = {
      layout = 'flex',
      default = 'builtin',
      winopts = {
        split = 'vert new',
      },
    },
  },
})

Emm 'flex' layout does not seem to work -- when the height is small and width is large the preview is still below

Flex is dependent on the width of vim.o.columns, by default if it’s below 120 it will use a vertical preview, if the width is over 120 it will setup the preview as horizontal.
I think what you want is your own setup, instead of winopts define a winopts_fn that returns a table based on certain conditions, it will get called every time you open the interface (same as on_create) and you can decide when to use a split or what preview layout to use:
  winopts_fn = function()
    return {
     …
    }
  end

Thanks, winopts_fn works like a charm!

How to show the preview as a split beside fzf terminal window?

This is not possible ATM, would require new code, given it has been over 2 years and this is the first request ever for this I’m probably not going to invest time in this (would require a major refactor).

Would you accept a PR for it? I would like to investigate on this and see if I can help.

Would you accept a PR for it? I would like to investigate on this and see if I can help.

If done right absolutely, the issue is that the window creation codes isn’t structured optimally since I started with one window (one float, only fzf native previews), then a neovim buffer, then splits, then fzf-tmux, many conditions and edge cases (resizing, rotating previews, scrolling, etc) and although it’s a bit of a mess it currently works flawlessly. Doing this properly would require a lot of thought on the new window/preview class structure and code flow, that’s a major refactor.
If you do find the passion to do this and test this properly you have my blessing :)

rotating previews

I don't think it is possible to rotate a split window with respect to another given current split window implementation of nvim. Is it ok that we ignore this feature (I don't see it useful in a split layout) if user select to ues a split layout?

rotating previews

I don't think it is possible to rotate a split window with respect to another given current split window implementation of nvim. Is it ok that we ignore this feature (I don't see it useful in a split layout) if user select to ues a split layout?

It is possible to rotate the preview, it’s just a float window but you’d also need to send fzf a transform preview command since there is a hidden empty fzf window below the neovim preview buffer, without it the preview would cover the results.
The reason I didn’t do it is because when I implemented the preview rotation fzf didn’t have an option of transforming the layout (which I believe it now has).

I mean,  it is possible to rotate if the terminal and the nvim preview window are splits.

I mean, it is possible to rotate if the terminal and the nvim preview window are splits.

Understood, that’s why I said many edge cases which will require a new thoughtful code structure or it will be an absolute hacky mess.

I’m going to close this issue since it’s generally “solved”, if you do decide to submit the PR, we can discuss it there.

I am wondering is it possible to pin the fzf-lua window(e.g. to the right), nerver exit it. Then whenever a new one is called, we refresh the fzf-lua window.

I am wondering is it possible to pin the fzf-lua window(e.g. to the right), nerver exit it. Then whenever a new one is called, we refresh the fzf-lua window.

Not possible ATM, you can hide the window with alt-esc and return to it but there is no perm window possible ATM.


Fix nested ternary-if codegen

Fixes #55582
This fixes a GDScript code generation issue with nested ternary-ifs.

Thanks!


Improve base64 BIO correctness and error reporting

Also improve related documentation.

The BIO_FLAGS_BASE64_NO_NL flag did not behave as advertised, only leading and trailing, but not internal, whitespace was supported:
$ echo 'AA AA' | openssl base64 -A -d | wc -c
0

Switching from ignored leading input to valid base64 input misbehaved when the length of the skipped input was one more than the length of the second and subsequent valid base64 lines in the internal 1k buffer:
  $ printf '#foo\n#bar\nA\nAAA\nAAAA\n' | openssl base64 -d | wc -c
  0

When the underlying BIO is retriable, and a read returns less than 1k of data, some of the already buffered input lines that could have been decoded and returned were retained internally for a retry by the caller.  This is somewhat surprising, and the new code decodes as many of the buffered lines as possible.  Issue reported by Michał Trojnara.

After all valid data has been read, the next BIO_read(3) should return 0 when the input was all valid or -1 if an error was detected. This now occurs in more consistently, but further tests and code refactoring may be needed to ensure this always happens.

Checklist

[ x] documentation is added or updated
[x ] tests are added or updated

Fixes: #24728

I didn't know that ansi C limited string length to 509 bytes.  Do we need to skip or abbreviate these tests if building with -ansi?

I didn't know that ansi C limited string length to 509 bytes. Do we need to skip or abbreviate these tests if building with -ansi?

I did not know either, but no need for disabling tests as a workaround, now that I have roughly the right tests, I'll change the inputs to be machine-generated, rather than be string literals. That will also make it easier to expand the test matrix...

I didn't know that ansi C limited string length to 509 bytes. Do we need to skip or abbreviate these tests if building with -ansi?

I did not know either, but no need for disabling tests as a workaround, now that I have roughly the right tests, I'll change the inputs to be machine-generated, rather than be string literals. That will also make it easier to expand the test matrix...

For now, I'm looking for feedback on the code, docs and scope of changes. Ultimately, once we have sufficiently complete tests, I think the b64_read function should be completely replaced, it is rather poorly structured.

I didn't know that ansi C limited string length to 509 bytes. Do we need to skip or abbreviate these tests if building with -ansi?

Which is why char [] is used in quite a few places.

I would approve but I am hesitant because of the test is not using the proper TEST infrastructure macros.

approval holds, thank you for fixing up the test harness @vdukhovni

This pull request is ready to merge

Merged to the master branch. Thank you.


slow ping

Hi great work with this!
just a quick question, i tried ping with this API. But it's very slow around 15 ms. I've put the server close to the api server. Do you have similar performance or I messed up during installation?

Sorry for the late reply, I was crazy busy last few months, and this library is not used in any production environment so I'm not sure which part of this project is wrong to cause your issue, I will be looking at this issue for sure, thanks for reporting!


make sure the xunit output dir exists before trying to write to it

Can you take a look at the linting errors?

Can you move that logic to _mocha, since it's already responsible for dir creation with browser tests (grep mkdirp to see what I mean)

I encountered the problem with grunt-mocha-test. Won't putting the fix in _mocha only help with command line usage while still leaving it broken for programmatic usage?

Ah, you're right. Your current approach makes most sense anyway. Thanks!


Error in Windows Installation: Unable to import pyrealsense

Required Info

Camera Model
ZR300

Firmware Version

Operating System & Version
Windows 10

librealsense version
1.12.1

pyrealsense version
2.2

Hello!
I have successfully installed the pyrealsense on Windows 10. However, when I try to import pyrealsense in python, I encounted the problem above. I have set the environ varible PYRS_INCLUDES to the path C:\pyrealsense\librealsense-1.12.1\include\librealsense, which has rs.h, stdint.h,etc. And I also set PYRS_LIBS to the path C:\pyrealsense\librealsense-1.12.1\bin\x64 which has realsense.dll and realsense.lib.  Please help, I need to make it work in Windows system.

It is a file not found error. Please double check rs.h can be accessed from python space.

In constants.py there is the code that look for the header file.

I tried your suggestion, however, I still face the same problem.
Firstly, I'm sure that rs.h can be accessed from python space because if the program can't find the rs.h file, it will have another error(This is not my actuall error, I just move the rs.h file to a wrong place to test if the program can find it. Obviously, it's a path error):

Secondly, I print the variable rs_h_filename to resure the path:
There is nothing wrong.
Consequently, I'm still in a mess and I still can't find the real problem.

seems like an issue in pycparser ? maybe you can try to execute the line:
ast = pycparser.parse_file(rs_h_filename, use_cpp=True)
by itself and debug from there.
(Also, make sure you are in another directory than pyrealsense when importing the library.)


Is the centroid implemented correctly?

In the original version, the centroid is implemented as an average of the coefficients.
def centroid(self):
    centroid=np.zeros((2))
    for k in range(0, self.M):
         centroid+=self.coefs[k]
    return centroid

It is not clear to me if this is consistant with the following definition of the centroid:
$$c = \frac{\int_lxdx}{\int_ldx}$$
$$= \frac{\int_tf(t)f'(t)dt}{\int_tf'(t)dt}$$
Here $l$ is the line/curve and $f(t)$ is the spline describing the curve.
Should we instead average the knots or calculate the integrals of the definition?
I am also not sure what the use cases are for this function?
Is it just a helper function for the scale and rotate methods?

This is indeed misleading - this function is only meant to help geometric operations like scale, rotate, and translate. It does not return the centroid of the planar curve but the centroid of the control points. This is the sensible thing to do in an interactive setting where the elements that are accessible/visible/editable by the user are the knots or the control points: if, as a user, I select all control points to rotate them, I'd expect that the center of rotation is the centroid of the points I selected - not anything else.
I believe it is useful to keep this, but it should be renamed for clarity. There could also be another function (to be implemented) calculating the actual centroid of the curve - though I'm not sure how useful it would be since this can also be very quickly approximated by sampling the curve and averaging the sample points (most likely always much quicker than solving an integral).

I see! I'll rename it to coeff_centroid. Perhaps we can even make it a private method and expose the functionality by adding a keyword argument called  centered=True to the rotate method.

This is a good suggestion!

Implemented in 9befadb and b876c9e.


nodejs: 8.2.1 -> 8.3.0

Motivation for this change
Release Notes
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @goibhniu @havvy @gilligan @cko

darwin build timed out on travis but @lo1tuma tested that locally so LGTM!

🆗


setting the number of cpus as maximum_concurrent_rpcs by default

Codecov Report

Merging #20 into master will increase coverage by 0.04%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   49.68%   49.73%   +0.04%
==========================================
  Files          28       28
  Lines        2045     2047       +2
  Branches      199      199
==========================================
+ Hits         1016     1018       +2
  Misses       1025     1025
  Partials        4        4

Impacted Files
Coverage Δ

...n_python_toolbox/engine_base/engine_base_action.py
59.54% <0%> (ø)
:arrow_up:

marvin_python_toolbox/management/engine.py
27.07% <50%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2554e6...f22b489. Read the comment docs.


Enable TypeScript strict mode

This commit enables TypeScript's strict mode: no implicit any, strict null checks, etc.
As part of this work, I also removed all use of raw require() and switched to TypeScript's import = require() syntax, which preserves type information. Since many dependencies don't have type definitions, I manually annotated the subset of API we rely on in the typings.d.ts file.

+2,758 −1,045

to be honest I'm not sure how to review this in a reasonable way given that it is all in a single commit 🤔

@Turbo87 most of the changes (>2000) seem to be in the lockfile, so I'd just trust Yarn on that file 👼.
Need some more time for glimmer-app.ts, rest seems 👍


0101-Managing Identities in Azure AD

Module: 01
Lab/Demo: 01
Exercise: 01
Task: 01
Steps: 11-28
Description of issue
The Azure AD admin center has been replaced by the Microsoft Entra admin center. Also, the UI within the Entra admin center is different when creating accounts. As such, the steps required for creating Edmund and Miranda should be revised.
Similarly, the experience of managing roles and administrators in Exercise 2 and then licensing and branding in Exercise 3 requires a slight re-write of steps.
The Azure AD admin center is only functional until May 2023 per Microsoft.
As MD-102 is a new course, shouldn't we use the correct steps from the outset and not copy/paste from a broken course requiring MCTs to continue to provide workarounds? The sheer volume of PRs that were ignored and issues that were ignored for MD-101 should NOT continue into MD-102.

I agree WigF1. Microsoft did not care about the last course. Lets see if they care this time around. I have already found issues in this course and will be posting here

Thank you both for the feedback. We are currently working to resolve the ui changes within the labs and should have some changes rolling out soon.

Why is this not done before launch ?!
On Tue, 16 May 2023 at 18:49, MSFT-rstearman @.***>
wrote:

Thank you both for the feedback. We are currently working to resolve the
ui changes within the labs and should have some changes rolling out soon.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftLearning/MD-102T00-Microsoft-365-Endpoint-Administrator/issues/2#issuecomment-1550110939,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABH7DPCHHRFGH3PU7PJ6IADXGO4ZPANCNFSM6AAAAAAXKND4NA
.
You are receiving this because you commented.Message ID:
<MicrosoftLearning/MD-102T00-Microsoft-365-Endpoint-Administrator/issues/2/1550110939
@github.com>

--
Michael WhitehouseEmail: @.**
@.**>Tel: +447970012133
WWW.MICHAELWHITEHOUSE.COM http://www.michaelwhitehouse.com/
http://www.michaelwhitehouse.com/


Add vsf-capybara support as a dependency and extend CLI

Related Issues

Closes #4209
Short Description and Why It's Useful

This PR adds vsf-capybara theme as a selectable dependency for vue-storefront installation using CLI. CLI makes sure that vsf-capybara will be installed only with supported vue-storefront version - ^1.11.0.
Changes in CLI are ready for moving old default theme to separate repository - vsf-classic - in task https://github.com/DivanteLtd/vue-storefront/issues/4211. The only changes needed in CLI after vsf-classic repository will be created are removing 3 conditions answers.themeName !== 'classic', which currently prevents CLI from attempting to download default a.k.a. vsf-classic theme from GitHub, which does not exist yet.
Screenshots of Visual Changes before/after (if There Are Any)

Installing vue-storefront with vsf-capybara theme

Installing vue-storefront with old default a.k.a. vsf-classic theme
For this scenario default theme is not downloaded from GitHub yet, because currently vue-storefront has this theme built-in in path src/themes/default and vsf-classic repository is not created yet. CLI supports this scenario:

Which Environment This Relates To
Check your case. In case of any doubts please read about Release Cycle

[x] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

@kkdg we should update the docs + readme to have CLI as a default installation method starting from VSF1.12

I've just updated this PR to support recently created vsf-default repository, which contains the default theme extracted from vue-storefront. This default theme can be now also downloaded, just like vsf-capybara.


chore(Search, Typescript): Updates return type of index.get to IndexWithPermissions type.

https://github.com/globusonline/globus-search/pull/1528/files

Looks like I don't have authorization to merge, feel free to do so or add me to the authorized list. Thanks Joe


Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Database
Which platforms are affected?
Web
Description
Just Simple Update with button like this :
FilledButton(
  onPressed: () {
    FirebaseDatabase.instance.ref().child("Connection/Test").set(false);
  },
  child: const Text("Check"),
),

Will execute perfectly firstly but make after couple tries will return error like this. I try using async, change set to update but still give this error
Error: Exception: Unknown event type: DatabaseEventType.value
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 297:3                                       throw_
packages/firebase_database_platform_interface/src/platform_interface/platform_interface_database_event.dart 51:5  eventTypeToString
packages/firebase_database_web/src/database_event_web.dart 15:24                                                  new
packages/firebase_database_web/src/utils/snapshot_utils.dart 13:10                                                webEventToPlatformEvent
packages/firebase_database_web/src/query_web.dart 130:46                                                          <fn>
dart-sdk/lib/async/stream_pipe.dart 213:31                                                                        [_handleData]
dart-sdk/lib/async/stream_pipe.dart 153:5                                                                         [_handleData]
dart-sdk/lib/async/zone.dart 1594:9                                                                               runUnaryGuarded
dart-sdk/lib/async/stream_impl.dart 339:5                                                                         [_sendData]
dart-sdk/lib/async/stream_impl.dart 515:13                                                                        perform
dart-sdk/lib/async/stream_impl.dart 620:10                                                                        handleNext
dart-sdk/lib/async/stream_impl.dart 591:7                                                                         callback
dart-sdk/lib/async/schedule_microtask.dart 40:11                                                                  _microtaskLoop
dart-sdk/lib/async/schedule_microtask.dart 49:5                                                                   _startMicrotaskLoop
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 181:7

Reproducing the issue
FilledButton(
  onPressed: () {
    FirebaseDatabase.instance.ref().child("Connection/Test").set(false);
  },
  child: const Text("Check"),
),

Firebase Core version
^2.31.0
Flutter Version
3.19.5
Relevant Log Output
No response
Flutter dependencies

Expand Flutter dependencies snippet

dependencies:
  animated_check: ^1.0.5
  cloud_firestore: ^4.17.3
  cupertino_icons: ^1.0.2
  dartx: ^1.2.0
  dartz: ^0.10.1
  firebase_auth: ^4.19.5
  firebase_core: ^2.31.0
  firebase_database: ^10.5.5
  flutter:
    sdk: flutter
  flutter_speed_dial: ^7.0.0
  flutter_web_plugins:
    sdk: flutter
  flutter_widget_from_html_core: ^0.14.11
  freezed_annotation: ^2.4.1
  get: ^4.6.6
  google_fonts: ^6.1.0
  http: ^1.1.0
  internet_connection_checker_plus: ^2.3.0
  intl: ^0.19.0
  json_annotation: ^4.9.0
  qr_flutter: ^4.1.0

dev_dependencies:
  build_runner: ^2.4.9
  flutter_lints: ^3.0.2
  flutter_test:
    sdk: flutter
  freezed: ^2.5.2
  json_serializable: ^6.8.0

Additional context and comments
No response

Hello @fahrezahaydar, I've tested your code in my environment, and it didn't cause any issues:
Future<void> _set() async {
  await FirebaseDatabase.instance.ref().child('nested/check').set(false);
}

Please share a complete example where this error is occurring, so we can analyze and determine where it might be happening.

I tried run few time. Yeah its worked, but I notice that this error will occur again every i make mistake on other code that pause debug.  After solve other code and hot reload/restart, this error will occur in every set/update in my code.

Can you provide some steps along with the code that causes the issue?
Example for steps to provide:

Click on the "Set" button.
Cause a breakpoint to pause the application by clicking the "X" button.
Click on the "Set" button again.
The issue occurs.


consider adding a "us" geo_type to covidcast

atm the highest level is state but afaik there is no option to get signal values for the us as a whole. It would be nice to have them since it would provide a nice starting point for a visual drill down operation

Agree; FB asked for this back in July but we weren't in a position to provide it then.
Propose instead the following:

geo_type: nation
geo_value: usa

This will need to be handled in each indicator unless we want to get clever with aggregating aggregates. Moving to the indicators repo for further work.


Tool Development - October 2023

Next steps
Finish templates on UI
Make templates more readable on UI and connect to database
07.10.23 added more inputs and supabase function
https://github.com/SingularityNET-Archive/archive-oracle/commit/8a20596106b8418649766bb03478128c95e52542
09.10.23 connected database to form input and display
https://github.com/SingularityNET-Archive/archive-oracle/commit/d0656c53bd0a63946e69ec396a12a0a0a12c50a5
10.10.23 Fixed submit bug and added "other" tag
https://github.com/SingularityNET-Archive/archive-oracle/commit/bd44be76373372e0416580ba9e7d7f8d58f472b5
13.10.23 Added user constraint to database and date checking.
https://github.com/SingularityNET-Archive/archive-oracle/commit/7bdec0502680b8e88fadf325d40b716ff27c2ece
16.10.23 Started prepping Summary confirmation page and added SignIn requirement
https://github.com/SingularityNET-Archive/archive-oracle/commit/5d2d7bb33cd71bd2aeb0059d8906a697b421eb5a
https://github.com/SingularityNET-Archive/archive-oracle/commit/8a6e39e0942536b16128ab6a17469db5e1be03a8
17.10.23 Fixed date and admin bug
https://github.com/SingularityNET-Archive/archive-oracle/commit/80f7302de6708fd6e5ea5ee7ac55c3e273e051f6
https://github.com/SingularityNET-Archive/archive-oracle/commit/a7c499094f893951f291ad2b79710982007c4468
18.10.23 Added name selection component, Fixed submit bug and added assignee select
https://github.com/SingularityNET-Archive/archive-oracle/commit/a71cb4a3f778e0925ff11d43019fecf1664ce89e
https://github.com/SingularityNET-Archive/archive-oracle/commit/e0d5ef3567c194436728228af1cd4a067352baad

Potential to capture WG decisions - lends itself to transparency and accountability - Felix
When running can be used to train LLM - Vani
Compare and contrast different decision making in WGs - Vani
Build decision trees and context - Felix

Add status to Action items
TO DO / IN PROGRESS / DONE / BLOCKED / CANCELLED

We may have to data clean duplicate names in name select.


remove version template

Move away from Chart version template
Migrate from ats

Why no ats? I think we just need to change the executor type


feat: swipe to delete todo items

Add tap & swipe-to-delete functionality on mobile screens. Gesture handling based on the hammer.js library.

👍🏻


Glider events not firing up

I tried to register to events but none of them are being fired:
  <Glider
    slidesToScroll={5}
    slidesToShow={5}
    draggable={true}
    onRefresh={() => handleOnLoad}
    onLoad={() => handleOnLoad}
    onSlideVisible={() => handleOnLoad}
  >

function handleOnLoad(context: any, event: Event) {
}
from documentation:
/** Called after Glider.js is first initialized /
onLoad?(context: any, event: Event): void;
/* Called whenever a slide a shown. Passed an object containing the slide index /
onSlideVisible?(context: any, event: Event): void;
/* Called whenever Glider.js refreshes it's elements or settings */
onRefresh?(context: any, event: Event): void;

@yaronA If you make a PR with a fix I will merge and release quickly!


Feature/use labels in excel file

What

If a dimension label exists in the metadata use it in the excel file

How to review

Verify logic is correct
Run unit tests

Who can review
Anyone

closing as done as part of a different pr.


Support mounting a Dropbox directory

This would allow users to edit their ledgers using their own editor, as well as enabling scripts and so on.

https://github.com/dropbox/dropbox-sdk-js


NPE while connecting to sendbird

I'm using the recent version i.e v3.0.10
This happens sometimes, not all the time.
E/UncaughtException: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String com.sendbird.android.User.getUserId()' on a null object reference                                                                              at com.sendbird.android.SendBird$3$2.run(SendBird.java:306)                                                                              at android.os.Handler.handleCallback(Handler.java:815)                                                                              at android.os.Handler.dispatchMessage(Handler.java:104)                                                                              at android.os.Looper.loop(Looper.java:194)                                                                              at com.sendbird.android.SendBird$3$1.run(SendBird.java:291)

Can you check the version again?
Because, there no part to call getUserId() on SendBird.java:306
Maybe you can be using earlier version.

I am using the latest version i.e 3.0.10
This issue is happening in a Lenovo Tab with android 5, not in any mobile device. But that's alright cause my app is targeted towards mobile devices.
Thanks for replying.

The issue you are facing is the problem occurred in 3.0.7 and patched from the next version.
I will check and let you know again if v3.0.10 still has the same issue.


Interactive mode for disambiguation prompts

It would be a nice idea to have some extra interactivity in the CLI.
As an example see how the jira CLI deals with lists.
For the CLI there are several places where such an interactive experience might be helpful.
Scenario
There are a lot of places in the CLI where it is possible for the user to enter a name or a title or some such. The CLI will try to find the related object. Such as a team. However: if multiple objects with the same name exist, the CLI will request the user to select the proper object. This is done by printing the ids and titles to the terminal. It's called a disambiguating prompt. The user must copy paste the value he wants and execute the command again.
It would be cool to have some extra interactivity here:
When a command triggers the user to disambiguate, allow the user to select the correct option using the up, down and enter keys, after which the command is executed again on the proper item.
Remarks
We need to research this a bit more to see what the options are. I'm adding this here to keep it in mind.

It is a idea Martin. Good that you put it here.
We already had some discussion which was initiated by Waldek around this topic some while back here - #2880 . Please feel free to chime in your valuable thoughts over there.

Good point @arjunumenon, apparently I did not search there :-)

Here's what I propose:

add new boolean configuration setting interactive that will enable the disambiguation prompt. It will be disabled by default to avoid introducing breaking changes and preventing CLI from being used in scripts
when the interactive setting is set to true and there's an ambiguity error, CLI will show a choice prompt using inquirer showing the different options
if user selects an option from the list, CLI will assign the selected value to the corresponding option and proceed with execution
if a user cancels the prompt, CLI will stop execution

Any feedback?

Seems good to me!

Sure!

By the way @waldekmastykarz: why did we choose a new config key for this? We already had a prompt config key that encompasses the same type of interactivity... shouldn't we merge the two?


Use old syntax for defaut export object syntax

Fixes #205
The default export is an expression, so the { ... } is actually an object literal (not export names); as such, older runtimes may not support the shorthand object literal syntax. Duplicate the names to keep it working.

super old?

Uh, yeah

webpack 2.7.0
uglify-js 2.8.29

Object literal shorthand properties are in the same language spec as export default

TIL! I thought it came separately.

My bad, I forgot you had already opened this PR when I merged #216


[Test] Mark two unsupported for backdeploy.

They depend on new runtime changes.

@swift-ci please smoke test and merge


Add option for mounting a host directory as a data volume

:+1: to persist the data we need define volumes. i don't know where noe4j save the data otherwise i would create a pull request.

See pull request #11


Change to HTTPS origin

Per discussion http://community.rubymotion.com/t/redpotion-there-is-an-error-i-cant-help-ah/539/3

good catch. :+1:


Graph display error

In GitLab by @eferre1 on Mar 28, 2023, 14:00
Hi @ jberlin, I'm having one experiment not showing in the graph view of the GUI. The expid is a3wl.
I had this experiment from some time ago, running with the AS-3.14b version. I ran autosubmit create -np a3wl -v to regenerate the experiment after changing some jobs and dependencies that I wanted to check, and updated it to the AS-3.15b version. Then went to the graph view of the GUI and this error showed up:
Something has gone very wrong.

a bytes-like object is required, not 'str'

I didn't intend to run the experiment, since I wanted just to check some complex dependencies (using the SELECT_CHUNKS and SELECT_MEMBERS), but I could start its run if needed.
Seems related to the error in the issue https://earth.bsc.es/gitlab/es/autosubmitreact/-/issues/73.
FYI: @dbeltrankyl @mcastril

In GitLab by @eferre1 on Apr 24, 2023, 12:18
Yes, I had to run a new autosubmit create, but after that it now shows the graph without errors.

In GitLab by @ jberlin on Apr 24, 2023, 09:46
Hi @eferre1 , can you please confirm that now the issue has been resolved ? anycase if happens again we re-open this issue, thanks !

In GitLab by @ jberlin on Apr 20, 2023, 14:36
I think I fixed this issue with the changes I did for fixing issue #21 I will port the experiment to development environment and see how it goes

In GitLab by @ jberlin on Apr 20, 2023, 15:19
I copied the experiment to the development environment:
https://earth.bsc.es/autosubmitapp/experiment/a3wl
but the graph is displayed with some isolated nodes, is that correct @eferre1  ?

In GitLab by @ jberlin on Mar 28, 2023, 14:37
It seems that for migrated experiment, we have issues with the graph, I will try to reproduce the issue creating an experiment on 3.14 , check that the tree looks ok and then migrate to 3.15 version and see how it goes. the experiment is inactive state so I guess it is also related

In GitLab by @eferre1 on Apr 20, 2023, 15:42
It is possible, since I was trying to test the effects of some changes on the dependencies (and wanted to use the graph view for that reason).

In GitLab by @ jberlin on Apr 24, 2023, 12:21
great ! these fixes are in the development machine only, I will put this in testing

In GitLab by @manuel-g-castro on Jun 8, 2023, 10:40
It will be solved in autosubmit in issues
1007 (https://earth.bsc.es/gitlab/es/autosubmit/-/issues/1007)
1014 (https://earth.bsc.es/gitlab/es/autosubmit/-/issues/1014)


fix retry interceptor

The current retry interceptor has some problems.  Ellery was seeing weird behavior with it, and then in a somewhat unrelated incident the maintainers called out some weird behavior that it was causing in some trace logs that I sent them.  We need to update it to one of the ones recommended by the maintainers in this ticket:
https://github.com/grpc/grpc-node/issues/2285
Steps will look something like this:

[ ] set up a reproducer environment.  We can do this by using SST ; i had a branch in this ticket where I set one up https://github.com/momentohq/client-sdk-javascript/issues/113 .  Basically we create a lambda, make a request through it, wait until the connection is closed via the NLB idle timeout, then issue another request.
[ ] once we have a reproducer, we should just need to diff our current retry interceptor code with the code from the grpc ticket linked above, and apply the delta to our branch
[ ] then verify that the reproducer no longer shows the issue.

@virratanasangpunth also observed something that was probably related to this:
https://github.com/momentohq/client-sdk-javascript/issues/166
we should see if we can verify our fix with an environment like the one he described.  I can help set that up in a dev cell when the time comes.


Update sbt-scalajs, scalajs-compiler, ... to 1.7.0

Updates

org.scala-js:sbt-scalajs
org.scala-js:scalajs-compiler
org.scala-js:scalajs-library
org.scala-js:scalajs-library_2.13
org.scala-js:scalajs-test-bridge
org.scala-js:scalajs-test-bridge_2.13
org.scala-js:scalajs-test-interface

from 1.5.1 to 1.7.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-js" } ]

labels: library-update, semver-minor

superseded by #117


Marker Icons resizing on drag event and cursor change from pointer to arrow

Checklist

[X] I've looked at the documentation to make sure the behavior isn't documented and expected.
[X] I'm sure this is an issue with Leaflet, not with my app or other dependencies (Angular, Cordova, React, etc.).
[X] I've searched through the current issues to make sure this hasn't been reported yet.
[X] I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce
after creating a map and inserting a draggable marker in the markerlayer on the drag event of this marker the cursor on the screen changes from "arrow" to "pointer", and when I move the marker across the map it resizes the icon , shrinking it until it disappears
I'm using the latest version 1.9.4
Expected behavior
drag the marker without grabbing its image (and resize it with the movement of the cursor)
Current behavior

Minimal example reproducing the issue
No response
Environment

Leaflet version: 1.9.4
chrome (with version):  chrome (latest)
OS/Platform (with version): windows 11

I want to work on this issue please assign me

hey @nicolaturcoep can you please add a sandbox example for this?


[23] Add API Endpoint Documentation i.e. swagger

Added swagger api documentation

@maunga-et thank you for adding docs. Could you please create this PR against the develop branch instead of main?
You'll want to first get the latest changes from upstream develop and then create your branch based on that. Once you have the latest changes, we can add the docs.


Add GCC version check to cmake

Summary: Per https://github.com/pytorch/translate/issues/48
Differential Revision: D7995296
fbshipit-source-id: 2281b4d278985262ea046b237aa2d2d50431fe51

I just tested locally - since the cmake part checking compiler version can be tested on machines that don't meet the requirement.


indent lines don't show on opening folds

Whenever I open a block of folded code, the indent lines don't show up unless I move away from the buffer and be back.
Happens specifically for c/cpp files only.
Is this a known bug and is there a away to fix it?
I'm using v0.8.0.

this is a limitation of neovim, take a look at #449


Keyboard covers input fields that are at the bottom of a Column

Do you have a specific case you're working with?  The keyboard adds some padding to the window so that widgets can move out of the way.  For example, the Scaffold sizes its body (and positions the floating action button, etc) to avoid the keyboard.

I understand that this supposed to work, it just doesn't seem to be doing it consistently. I'll add a reduced test case.

https://gist.github.com/collinjackson/3495326873871035d3e4
import 'package:flutter/material.dart';

void main() {
  runApp(
    new MaterialApp(
      title: "Input Demo",
      routes: <String, RouteBuilder>{
        '/': (RouteArguments args) => new FlutterDemo()
      }
    )
  );
}

class FlutterDemo extends StatefulComponent {
  @override
  State createState() => new FlutterDemoState();
}

class FlutterDemoState extends State {

  GlobalKey _inputKey = new GlobalKey();

  Widget build(BuildContext context) {
    return new Scaffold(
      toolBar: new ToolBar(
        center: new Text("Input Demo")
      ),
      body: new Material(
        child: new Center(
          child: new Column(
            children: <Widget>[
              new Flexible(
                child: new Container(
                  decoration: const BoxDecoration(
                    backgroundColor: const Color(0xFF00FF00)
                  )
                )
              ),
              new Input(
                key: _inputKey
              )
            ]
          )
        )
      )
    );
  }
}

/cc @qchong
@abarth do you want to investigate this one?

Yeah, I can take a look.

Works on my phone.

clearzen:flutter abarth$ flutter --version
Flutter from git@github.com:flutter/flutter.git (on master)
flutter revision: 488285f11205337392cc337f1bd9bc502ce141f9 (2 hours ago)
Maybe it depends on the version of Android?  What Android version are you using?

I'm seeing it on both Android 5.1.1 and 6.0.1, tested on two Nexus 5s and a OnePlus.
flutter --version
Flutter from  (on )
flutter revision: 488285f11205337392cc337f1bd9bc502ce141f9 (2 hours ago)

@sethladd tried using a Nexus 6P with the latest Flutter revision and Android 6.0.1, same issue

That's pretty odd.  Hopefully I should be in the office tomorrow and we can look at it face-to-face.


Fnlint failing on windows

Hello there - thanks for maintaining this code!
I am running into an issue where fnlint works fine on Mac with the following config:
{
"basePath": "./src/",
"files": "**/*.{js,jsx}",
"format": "kebabcase",
"directories": true
}
Running it in from: package.json with this command:

"lint:fn": "fnlint -c ./fnlint.json",

However when running on windows Machines all the files fail.

kebabcase: 30 of 30 file(s) failed linting

Maybe the remove base path is failing here?
https://github.com/usabilla/fnlint/blob/9dde53fd53e7920b192789bff8986f942463ae72/lib/module.js#L40

Using a different solution. The issue is the backslash / forward slash between machine types. Will PR a fix proposal when I get a second.


how to use the script?

bro, how to use the script to get rtp url? is it use usb to usb from stb to pc?
oh ya, how about channel logo, can it extracted?
please add more channel bro, like animax hd (928), disney junior hd (931), cartoon network hd (933), and boomerang hd (934).
:D

bro, how to use the script to get rtp url? is it use usb to usb from stb to pc?

I'll write documentation about the script soon. Basically, a script that starts with frida_  is a Frida script and these Frida scripts are the ones that actually communicate with the STB, you can say that it's the main script that actually pulls the channel data. The rest of the scripts are to work with the raw data pulled by the Frida script.

oh ya, how about channel logo, can it extracted?

Yes, I've analyzed how to get the channel logo, I'll write the script soon... probably around Ramadhan since I'm currently not home and can't really work with this project.

please add more channel bro, like animax hd (928), disney junior hd (931), cartoon network hd (933), and boomerang hd (934).
:D

Yes, I notice that but I don't manually add channels, all of the channels are pulled directly from the STB. If I remember correctly, a channel like ANIMAX HD doesn't have an rtp URL information thus filtered by the script. I have yet to analyze this.

I'll write documentation about the script soon. Basically, a script that starts with frida_ is a Frida script and these Frida scripts are the ones that actually communicate with the STB, you can say that it's the main script that actually pulls the channel data. The rest of the scripts are to work with the raw data pulled by the Frida script.

Wow, can't wait for the documentation.
Yah, i try to run frida_, but its always show "device not found", how to communicate with stb? Must i install driver or something? Or must use hg860, because i try it on b860h v1.
About package name (com.fiberhome.iptv) in the script, should i change it?

Yes, I've analyzed how to get the channel logo, I'll write the script soon... probably around Ramadhan since I'm currently not home and can't really work with this project.

I'll wait for it then :D

bro, how to use the script to get rtp url? is it use usb to usb from stb to pc? oh ya, how about channel logo, can it extracted?
please add more channel bro, like animax hd (928), disney junior hd (931), cartoon network hd (933), and boomerang hd (934). :D

You can get some of TV logos in useetv website, just inspect the logo and copy the address Like this #EXTINF:0 tvg-logo="(Image adress)" group-title="(group title if you want to grouping some channels)", (at here you name the channel<EMAIL_ADDRESS>Example: #EXTINF:0 tvg-logo="http://images.useetv.com/logo_useesports_big1.png" group-title="Sport",85 USee Sports<EMAIL_ADDRESS>
Yes, i know that.
I just want to load logos direct from lan 4 like the channel, not from internet. :)


Second feature - create column of content in mobile size

[ ] Create one column of content for active tab section (mobile size)

[ ] include picture placeholder '360x195'
[ ] include <h> centered in column
[ ] include <p> with filler text centered in column
[ ] header(<strong>) and content are CF Blue
[ ] Enclose in a div container with the class name 'section-1', display: block

#26


ci: add helm package/push to Jenkinsfile

#373 added the helm chart. With this PR I add the ability to automatically package and push the helm chart.
Why is this necesarry?
Without this a user who wants to install stirling pdf using helm needs to checkout the repository and run helm install ./chart ... inside the repo. When the chart is published you can simply run helm install oci://registry-1.docker.io/frooodle ... without needing to checkout the repo first.
What is OCI
OCI is a new format that helm uses to package charts that can be stored in a docker image registry. So we can publish the chart alongside the docker images in the same registry, therefore the charts name can't be the same as the docker image and I renamed it to stirling-pdf-chart
** Disclaimer **
Since I don't have access to the Jenkins Server I cant test. I have manually published the chart to my accounts Github Package Registry using the following command, but since I only use ghcr.io instead of DockerHub I'm not 100% sure that the commands will work the same with docker. Please let me know if you need more help.
helm package chart/stirling-pdf
helm push stirling-pdf-chart-1.0.0.tgz oci://ghcr.io/danielr1996

License Agreement for Contributions
By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under MPL 2.0 (Mozilla Public License Version 2.0) license.
(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

The Jenkins file has actually been migrated to GitHub actions now
If you can try convert that to GitHub action I am happy to try it

@Frooodle I updated the PR with github actions


Request: option to no-op when source map uploads fail

When source map upload fails, we would like to log an error but continue with the webpack build and our CI release.
We use CircleCI as our CI pipeline. An engineer merged a branch to master and the deploy leg failed initially with this error: ERROR in Sentry Plugin: RequestError: Error: Client network socket disconnected before secure TLS connection was established.
Subsequently, when rerunning the failed deploy leg, we get this error: ERROR in Sentry Plugin: StatusCodeError: 409 - "{\"detail\": \"A file matching this name already exists for the given release\"}"
So, we cannot deploy this build anymore. We need to submit a new one with a dummy commit to get a deploy out. Instead, we'd prefer if we could rerun the initial build and have it succeed.
The fix here could take several forms:

log but do not fail on all upload source map errors
log but do not fail on failure to upload source maps specifically due to "file matching this name already exists"
add an overwrite option to overwrite existing files with the same name
etc.

Hi there! Options #1 and #2 are already possible. You can suppress all errors by setting the suppressErrors option to true, or you can suppress just the "file already exists" error by setting the suppressConflictError option to true.

awesome, ty!


Yoinker Immediately Crashing

log-4.txt
Just crashes immediately, here are the logs.
From OCE Comp queue, was working last night with the new ascendent ranks.

update to v2


Setup

I see a list of javascript files that look like they could be added as custom actions.
However, I don't see a package file that could be imported into vRO. Was that the intent? The README states that there is a package file to import.

@eshanks16 The package com.rubrik.library.rest.package should be under releases.  Let me know if you don't see it there

There it is. I didn't see it in code. Got it now. Thanks. Nice work, by the way.


caching: Validate stale cache entries and update cached headers

Commit Message: CacheFilter now validates cache stale entries and updates the cached headers.
Additional Description:
When a stale cache hit is found for a request, conditional headers are injected to the request for validation. If the a 304 response is received (not modified), a response is constructed from cache, and cached headers are updated. If a request already includes conditional headers it bypasses the CacheFilter, this is valid behavior and satisfies the minimum of #9855 for production -- however, it can lead to missed caching opportunities.
Signed-off-by: Yosry Ahmed<EMAIL_ADDRESS>Risk Level: Low
Testing: Integration tests
Docs Changes: N/A
Release Notes: N/A
Fixes #9976

This PR is a little bit lacking in tests, but right now I am working on a separate PR to improve tests and coverage for the whole cache tree. The CacheFilter is still WIP.

cc @toddmgreer (extension co-owner)

@toddmgreer I think this is ready for you to take a look. Josiah and Fred took passes so hopefully this shouldn't take too long.

@toddmgreer I managed to rewrite the state management in the filter in a simpler and cleaner way. Take a look whenever you can!

@jmarantz I think this is ready for you to take a look!

Yan this has approval from the extension owner, but can you do the Envoy pass with Josh out?

@yanavlasov let me know if you have any comments / suggestions!

Looks good modulo one nit and merging the main branch for resolving conflicting files.

@dio Done!

@lizan do you think the clang-tidy failures here https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/47052/logs/67 caused by recent changes?

Probably this one: https://github.com/envoyproxy/envoy/pull/12449?

@dio I merged master again, hopefully this will fix it

The clang tidy error still exists. All the checks passed before merging master and the nit commit (moving the include). I don't know what might be the problem.

/azp run

@yosrym93, sorry, seems like you need to have https://github.com/envoyproxy/envoy/pull/12449 as well.

Hello, sorry for the delay, I was pulled into working on customer case.
I've noticed that integration test only tests responses with 304 and 200 statuses. How are responses with other statuses (i.e. 404) tested?

Hello, sorry for the delay, I was pulled into working on customer case.
I've noticed that integration test only tests responses with 304 and 200 statuses. How are responses with other statuses (i.e. 404) tested?

According to: https://tools.ietf.org/html/rfc7234#section-4.3.3
304 responses (not modified) require special handling as they mean we should update and serve the cached response that is being validated.
Other responses (whether successful 2xx or errors 4xx) are forwarded to the client.

@dio I believe #12449 was already merged, but I merged master anyway just to make sure.

Still no luck with the clang-tidy problem, @dio thoughts?

@dio done!

Do I need to do anything about the cherry-picked fix now?

@lizan do you want to sign this as a senior maintainer? Thanks!

@lizan is there anything this PR still needs to be merged?


Inject Container within itself.

Container should be available for injections into members it contains (service locator anti pattern). Auto register container within itself when instantiating.

[ ] Write tests first, every member of a container should be able to inject container they're inside of. class B { constructor(@Inject(TContainer) private container: IContainer) {}  }

[ ] create container type  TContainer =  Symbol('IContainer')` next to IContainer in the same file.

[ ] when instantiating a new container, that container instance should register itself within itself via TContainer type ( this.register({ token: TContainer, useValue: this })

[ ] Create an example file for typescript and javascript.

Auto register container within itself.
Give default type for Container.
export const TContainer =  Symbol('IContainer')

Hey there again, I'm going to give this one a shot if that's OK. I think I understand the goal of this issue. I may reach out with some questions at some point.


Fix groups style

Fixes some styling for the new groups stuff.
Changes proposed in this pull request:

Adds more spacing around group neighbors and rounds image corners
Fix overflow in the group leaders list
Fix group name overflow in the "My Groups" widget (more noticeable on /groups)
Increases the height of the groups and tickets searchbar to match the sorting dropdown

/cc @hummingbird-me/staff

Looks great! Thanks as always!


User Story 1.1 - Issue 7: Spacing between Volunteer Position heading and Organization description - Resolved

Close this issue with video attached
https://user-images.githubusercontent.com/70918430/116583967-bb5a0b00-a8cb-11eb-9992-6b00a72957bb.mp4


Implementing RenderSections

Please consider implement RenderSections on Blazor! It's a nice feature to reutilize chunks of code

Duplicates #138


Create albanian

Added albanian stopwords.

Hi, and thanks for this. However, we don't support Albanian right now. While this file is useful, it won't be used unless we supported Albanian at the UI level. Actually I'm not even sure these static stop word files are being used - I'd have to do more code tracing to remind myself.
Relevant code references:
* we send in that language to NLTK in [`databasic.logic.wordhandler._count_words`](https://github.com/mitmedialab/DataBasic/blob/deb4dde5fbb7b02f2ed5b91aef36fce454a5e672/databasic/logic/wordhandler.py#L42)

* the lookup from language code to NLTK stop words language key is in [`databasic. NLTK_STOPWORDS_BY_LANGUAGE`](https://github.com/mitmedialab/DataBasic/blob/d37adc5735c42e72434f501d51180a64700f74d2/databasic/__init__.py#L18)

Thanks for the links.


Example Required: Unscented Kalman Filter

NAG currently has this document: https://www.nag.co.uk/industryarticles/unscentedkalman.pdf
Requirements:

[ ] - Simple Python example showing how to call the routines in the basic case
[ ] - A notebook based on the above document

Link 404s
Unlikely this will be picked up anytime soon


what is the use of loadMorePadding property ?

no proper sample available for the api. please explain the usecase??

From v3 docs:
Defines how many pixels need to be below the fold before the next page is loaded. The default value is 0 which means the result list needs to be scrolled all the way to the bottom for the next page of results to be loaded. This option can be used to trigger the load sooner, possibly resulting in a smoother user experience.

Looks like this has been resolved.


[Bug]: GetXHttpMethod returns no value in 9107 "SharePoint Http Content"

Describe the issue
The codeunit 9107 "SharePoint Http Content" contains a setter / getter functions for XHttpMethod.
However, the SetXHttpMethod does not properly set the value, resulting in GetXHttpMethod returning an empty value.
Expected behavior
procedure SetXHttpMethod(XHttpMethodValue: Text)
    begin
        XHttpMethodValue := XHttpMethodValue;
    end;

should be changed by
procedure SetXHttpMethod(XHttpMethodValue: Text)
    begin
        XHttpMethod:= XHttpMethodValue;
    end;

resulting in GetXHttpMethod returning the correct value
procedure GetXHttpMethod(): Text;
    begin
        exit(XHttpMethod);
    end;

Steps to reproduce

Call SharePointHttpContent.SetXHttpMethod('MERGE');
SharePointRequestHelper.Post(SharePointUriBuilder, SharePointHttpContent);

Below code does not add a X-HTTP-Method header ...
if SharePointHttpContent.GetXHttpMethod() <> '' then
            Headers.Add('X-HTTP-Method', SharePointHttpContent.GetXHttpMethod());

Additional context
I can provide a fix, but have no time to write any tests
I will provide a fix for a bug

[x] I will provide a fix for a bug

We'll take that fix - thanks 😊 Approved.


nodeName of null

Uncaught TypeError: Cannot read property 'nodeName' of null l.45

Hey @pierrefaure! Thanks for the PR. Can you write a test to prove the issue?


chore(Truncate)!: Remove Truncate

Overview

Removes deprecated Truncate component.

PR Checklist

[ ] Related to designs:
[x] Related to JIRA ticket: [WEB-1848]
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change
[x] This PR includes testing instructions tests for the code change
[x] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Visit the alert story and ensure the general (non inline) alert gets truncated with the option to expand. Confirm that clicking the arrow expands the alert and un-truncates the text. Confirm the general inline alert does not get truncated. Confirm that no other alerts show the expand button.
See monolith and portal PRs for testing instructions.
Don't make me tap the sign.
PR Links and Envs

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal Link
Portal Env

🚀 Styleguide deploy preview ready!https://62d9716f7de82700a16443c8--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.165-alpha.c14b20.0@codecademy/gamut-labs@33.0.1-alpha.c14b20.0@codecademy/gamut@48.3.1-alpha.c14b20.0@codecademy/monaco@0.6.60-alpha.c14b20.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://62d98d802a683f1483780bcf--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.169-alpha.e44bdf.0@codecademy/gamut-labs@33.0.5-alpha.e44bdf.0@codecademy/gamut@49.1.1-alpha.e44bdf.0@codecademy/monaco@0.6.64-alpha.e44bdf.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://62e7ec5d07f3246aef84a91a--gamut-preview.netlify.appDeploy Logs


makeBED12 error 137

Hello,
I tried to run the pipeline on a set of 10K paired reads using Ensembl verision 90 of human genome:
nextflow run nf-core/rnaseq -profile docker --aligner hisat2 -r 1.4.2 --pseudo_aligner salmon --reads 'data/*_{1,2}_10k.fastq' --reverseStranded --fasta Homo_sapiens.GRCh38.dna_sm.primary_assembly.fa.gz --gtf Homo_sapiens.GRCh38.90.gtf.gz --max_cpus 6 --max_memory 32

but got the following error:
N E X T F L O W  ~  version 20.01.0
Launching `nf-core/rnaseq` [serene_lalande] - revision: 3b6df9bd10 [1.4.2]
Extracting transcript fastas from genome fasta + gtf/gff
----------------------------------------------------
                                        ,--./,-.
        ___     __   __   __   ___     /,-._.--~'
  |\ | |__  __ /  ` /  \ |__) |__         }  {
  | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                        `._,._,'
  nf-core/rnaseq v1.4.2
----------------------------------------------------
Pipeline Release  : 1.4.2
Run Name          : serene_lalande
Reads             : data/*_{1,2}_10k.fastq
Data Type         : Paired-End
Strandedness      : Reverse
Trimming          : 5'R1: 0 / 5'R2: 0 / 3'R1: 0 / 3'R2: 0 / NextSeq Trim: 0
Aligner           : HISAT2
Fasta Ref         : Homo_sapiens.GRCh38.dna_sm.primary_assembly.fa.gz
Pseudo Aligner    : Salmon
GTF Annotation    : Homo_sapiens.GRCh38.90.gtf.gz
Remove Ribosomal RNA: false
Biotype GTF field : gene_biotype
Save prefs        : Ref Genome: No / Trimmed FastQ: No / Alignment intermediates: No
Max Resources     : 32 memory, 6 cpus, 10d time per job
Container         : docker - nfcore/rnaseq:1.4.2
Output dir        : ./results
Launch dir        : /Users/pgc92/projects/nextflow_nfcore_rnaseq/bkv
Working dir       : /Users/pgc92/projects/nextflow_nfcore_rnaseq/bkv/work
Script dir        : /Users/pgc92/.nextflow/assets/nf-core/rnaseq
User              : pgc92
Config Profile    : docker
----------------------------------------------------
executor >  local (10)
[de/6b0865] process > get_software_versions [100%] 1 of 1 ✔
[90/fe45a5] process > gunzip_genome_fasta   [100%] 1 of 1 ✔
[57/1fd372] process > gunzip_gtf            [100%] 1 of 1 ✔
[49/71a332] process > makeBED12             [100%] 2 of 2, failed: 2, retries: 1 ✘
[24/a7712b] process > makeHisatSplicesites  [100%] 1 of 1 ✔
[-        ] process > makeHISATindex        [  0%] 0 of 1
[-        ] process > transcriptsToFasta    -
[-        ] process > makeSalmonIndex       -
[fb/be49d8] process > fastqc                [100%] 1 of 1 ✔
[ad/21ce83] process > trim_galore           [100%] 1 of 1 ✔
[-        ] process > hisat2Align           -
[-        ] process > hisat2_sortOutput     -
[-        ] process > rseqc                 -
[-        ] process > preseq                -
[-        ] process > markDuplicates        -
[-        ] process > qualimap              -
[-        ] process > dupradar              -
[-        ] process > featureCounts         -
[-        ] process > merge_featureCounts   -
[-        ] process > stringtieFPKM         -
[-        ] process > sample_correlation    -
[-        ] process > salmon                -
[-        ] process > salmon_tx2gene        -
[-        ] process > salmon_tximport       -
[-        ] process > salmon_merge          -
[-        ] process > multiqc               -
[b5/02f5c4] process > output_documentation  [100%] 1 of 1 ✔
[HISAT2 index build] Available memory: 32 B
[HISAT2 index build] Less than 200 GB available, so NOT using splice sites and exons in HISAT2 index.
[HISAT2 index build] Use --hisat_build_memory [small number] to skip this check.
[0;35m[nf-core/rnaseq] Pipeline completed with errors
[e8/c58cce] NOTE: Process `makeBED12 (Homo_sapiens.GRCh38.90.gtf)` terminated with an error exit status (137) -- Execution is retried (1)
WARN: Killing pending tasks (1)
WARN: To render the execution DAG in the required format it is required to install Graphviz -- See http://www.graphviz.org for more info.
Error executing process > 'makeBED12 (Homo_sapiens.GRCh38.90.gtf)'

Caused by:
  Process `makeBED12 (Homo_sapiens.GRCh38.90.gtf)` terminated with an error exit status (137)

Command executed:

  gtf2bed Homo_sapiens.GRCh38.90.gtf > Homo_sapiens.GRCh38.90.bed

Command exit status:
  137

Command output:
  (empty)

Command error:
  .command.sh: line 2:    29 Killed                  gtf2bed Homo_sapiens.GRCh38.90.gtf > Homo_sapiens.GRCh38.90.bed

Work dir:
  /Users/pgc92/projects/nextflow_nfcore_rnaseq/bkv/work/49/71a3321c3829b20050bd40cb097992

Tip: you can try to figure out what's wrong by changing to the process work dir and showing the script file named `.command.sh`

I am unable to figure out what to do next.
Thank you

Similar error as in #411 - out of memory error, you need to specify proper amounts of memory :-)
https://success.docker.com/article/what-causes-a-container-to-exit-with-code-137

I fixed the makeBED12 error by increasing my Docker memory to 12GB and changing nextflow run command line to reflect the fact that my Docker has 12 GB memory and 3 cpus:
nextflow run nf-core/rnaseq -profile docker --aligner hisat2 -r 1.4.2 --pseudo_aligner salmon --reads 'data/*_{1,2}_10k.fastq' --reverseStranded --fasta refs/release90/Homo_sapiens.GRCh38.dna_sm.primary_assembly.fa.gz --gtf refs/release90/Homo_sapiens.GRCh38.90.gtf.gz --max_cpus 3 --max_memory 12
But now, I'm getting the following hisat2_sortOutput error:
Apr-20 09:04:11.745 [Task monitor] ERROR nextflow.processor.TaskProcessor - Error executing process > 'hisat2_sortOutput (SRR11074361_1_10k)'

Caused by:
  Process `hisat2_sortOutput (SRR11074361_1_10k)` terminated with an error exit status (1)

Command executed:
  samtools sort \
      SRR11074361_1_10k.bam \
      -@ 3 -m-1999999996 \
      -o SRR11074361_1_10k.sorted.bam
  samtools index SRR11074361_1_10k.sorted.bam

Command exit status:  1
Command output:  (empty)
Command error:  samtools sort: couldn't allocate memory for bam_mem

Seems like the pipeline correctly sets the number of cpus -@ 3 based on --max_cpus 3 command line option. However, notice how the pipeline is incorrectly setting the memory for samtools to 2GB even though I am specifying  --max_memory 12 on the command line.
Is there an option for explicitly setting the samtools memory?
Thank you

I figured out the problem. I am not using the correct format for --max_memory 12 but instead should be using --max_memory 12GB.   Closing issue now.


Align Quantity classes with SSN's Observable Property

Addressing this in https://github.com/BrickSchema/Brick/pull/76


Simple fix for test-send-receive test.

I don't know if this is acceptable, but it makes the test run (and apps depending on fingerprint being in offer/answer from createOffer/Answer continue to work).

Yup, that'll do for now. I guess we should use the relevant APIs as we have done in the bridge to generate the certs and such.

Where there any open issues regarding this one? If so, please close them. Thanks.

No, it was something that was caused by the landing of the createOffer commit yesterday.


Minimum supported Python version

For the Python bindings, we have to decide on how to integrate with the Python release cycle, i.e. what will be the lowest Python version that the bindings will support.
The Python Developer's Guide has a nice overview over the release cycle:

Currently, Python 3.8 is the oldest "supported" version (up until 2024-10) and the PyO3 template also sets requires-python = ">=3.8" in pyproject.toml by default.
Impact: The lowest supported Python version should be checked against in CI and newer Python language features cannot be used freely.

I don't have too much knowledge in this area but I feel that our priority should be to aim for low maintenance. Also, if there are features we want -- I somehow had structural pattern matching in mind which is usable from 3.10 -- we should give us this freedom. Not really an answer but hopefully a direction :-)

As the "features we want" would only be used in examples, I would argue that forcing users to upgrade to a newer Python version should generally be avoided, as other packages might not yet (or no longer) be available for that version.
That said, it does of course not make sense for us to jump through too many hoops to support all "bugfix" versions.

As it turned out, was building and testing all supported Python versions already part of the CI template provided by maturin which was adopted in #576.
For now, there is no strong reason for increasing the minimum supported Python over 3.8.


[GHSA-xfhp-jf8p-mh5w] HashiCorp go-getter Vulnerable to Code Execution On Git Update Via Git Config Manipulation

Updates

Affected products

Comments
Unblooks

Hi @Moradiii1987, this contribution is not being accepted because it makes no changes to the content of GHSA-xfhp-jf8p-mh5w. If you intended to make a change to the content of GHSA-xfhp-jf8p-mh5w, you may reopen this pull request or generate a new pull request. Thank you for your interest in GHSA-xfhp-jf8p-mh5w and have a good week.


Increase coverage for Edit Command

Codecov Report

Merging #241 (1cf142b) into master (10f8683) will increase coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
+ Coverage     67.95%   68.11%   +0.15%
  Complexity      743      743
============================================
  Files            94       94
  Lines          2581     2581
  Branches        346      346
============================================
+ Hits           1754     1758       +4
+ Misses          765      763       -2
+ Partials         62       60       -2

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/EditCommand.java
88.66% <0.00%> (+1.97%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f8683...1cf142b. Read the comment docs.


Fix RandomState.seed to only accept integer types

To align with NumPy, cupy.random.RandomState.seed should only accept integer types.
This fix supresses ComplexWarning in unit tests:
tests/cupy_tests/random_tests/test_generator.py::TestRandomState2::test_seed_not_none
  /work/cupy/cupy/random/generator.py:243: ComplexWarning: Casting complex values to real discards the imaginary part
    seed = numpy.uint64(seed)

LGTM!


Generated draft does not list changes

I have a PR merged, draft is indeed generated, but it does not list that PR. Actually it says "no changes".
May be related to #29, but it happens to me today.
Unfortunately my repository is private.
May be it's possible to check the logs.
On the image there might be useful info to search the logs for, like PR number, commit etc
Thanks in advance.

no I have more PRs merged but draft is not updated at all

Its broken for me too

happening with me as well for a private repo

the organization is vy-labs and the repo is labs-core-reloaded

mine is aliada-mx and the repo is tandem-api

I have release drafter enabled only for one repo in my organization. The latest draft is from 16 hours ago - Sep 27, 2018, 7:07 PM GMT+5:30.

The last release sucessfuly written by release drafter on  aliada-mx/tandem-api was at 2018-09-10T18:05:08Z for version v3.29.44 and commit hash efd7f70, if that helps you find it.
The previous release was done at 2018-09-07T22:35:27Z for the same repo.
After those, it stopped working.

@toolmantim I am having this same issue with my org's private repository. Uninstalling and reinstalling the app didn't seem to help. The org is @sproutsocial and the repository is seeds.

In fact, the app generated 2 drafts for me for 2 different PRs, instead of one draft for both PRs. Both drafts were empty.

Also seeing a similar issue on gorilla/sessions - there are 3 commits since the last release, but the draft release only shows 1.
Is the service missing webhooks/GitHub not delivering them?

Sorry there's been issues… it seems to be only affecting a small number of installs. I've just pushed some updates which might fix some of these issues. Can people give it another go, and let me know the org/repo again if it's still not working as expected?

@toolmantim Still not working for me. The org/repo is @sproutsocial/seeds.

still not working for me as well. repo is vy-labs/labs-core-reloaded

I know this is an open source project and free of charge, i would like with the debugging of this issue by setting up the app my self, are there any pointers where to start? any help to do this appreciated
I really want to fix this for my repo and i'm willing to put in the hours.
Thanks

willing to help in any way possible as well

Thanks for the offer @grillermo. I realised I had a logging bug (fixed in #79) which meant I was having trouble tracking this down, but if you could spin up your own local copy to debug it'd be much appreciated.
I've just updated the development instructions in 23e737c — since Probot v7.2.0 it's much easier to run an app locally, thanks to @wilhelmklopp, @bkeepers, and @hiimbex.

I managed to debug it and a copy of the app i made its working (on Heroku), it literally changed nothing of the code but i'm not sure the permissions are the same.
To the my copy of the github app i gave:
Subscription to Push events
Read and Write to Repository Contents
Read Only to Repository metadata
Read Only to Repository webhooks

I'm glad you got it working @grillermo — thanks for setting it up. It's disturbing that you changed literally nothing and it was working for you.
The only permissions difference I can see is that I don't have "Repository webhooks" read or write enabled at all. Any reason you enabled that?

I've just requested updated GitHub application permissions from everyone who has this installed. Let me know if that sorts things out for you.

Sadly it still doesn't work. I tried uninstalling and adding the app again but it is still generating empty drafts. I will try and setup a copy of the app to debug this over the weekend. Will let you know if I can diagnose what is causing this.

@trucalling you're not by any chance using rebase merging, right? :)

no, i am using squash and merge.

Hey @toolmantim! Sorry for letting you wait so long. I can confirm that it works in private repositories now. 😊 Thanks for the fix!


Support trace-level sampling

The libhoney-rust library has a sample_rate configuration option,
which provides random sampling of events sent to honeycomb.
Unfortunately, this sampling is done at the event level, rather than the
trace level. This means that spans or events belonging to a single trace
will have separate sampling decisions made for them. This in turn means
that when libhoney's sampling is enabled, traces will never have
complete span information within them. This severely limits the utility
of this sampling.
This proposed change introduces sampling based on the trace ID, meaning
that spans and events which are a part of the same trace will always
have the same sampling decision made for them. This will ensure that a
complete picture of the trace is sent up to honeycomb.
There are no breaking changes in behavior or API in this changeset, you
can still use the sampling logic built into libhoney if desired, but the
new function new_honeycomb_telemetry_layer_with_trace_sampling has
been introduced, which creates a telemetry layer that uses this new
sampling logic.
Alternatives:

Use the sample_rate from the libhoney config struct as the
trace-level sample rate, and reset the field to 1 before giving it to
libhoney. This is undesirable as it makes the current behavior
impossible to use, however it also makes it impossible to misuse this
new function by providing a sample_rate to this function, and libhoney
at the same time.
Perform this trace-level sampling within libhoney. This is
undesirable as it would require either parsing the traceID from the
string provided to libhoney, or using a hash of this string. It is
simpler to do the calculation in this library, where we have the raw
trace ID. This would also be a breaking change for libhoney, whereas
here it can be opt-in.

Example
I ran the following code with libhoney's sample rate set to 5, and the new trace-level sample rate set to 5.
fn main() {
    register_global_subscriber();

    for i in 0..10 {
        let s = info_span!("running process loop", i);
        let _g = s.enter();

        register_dist_tracing_root(TraceId::generate(), None).unwrap();

        foo();
    }

    std::thread::sleep(std::time::Duration::from_secs(5));
}

#[instrument]
fn foo() {
    sleep(Duration::from_millis(500));
    bar();
}

#[instrument]
fn bar() {
    sleep(Duration::from_millis(500));
    baz();
}

#[instrument]
fn baz() {
    sleep(Duration::from_millis(500));
}

This screenshot illustrates the change in behavior between the current libhoney sampling, and the new trace-level sampling.

I'll need this soon too. @inanna-malick are you able to take a look sometime soon?

Thanks for the review @inanna-malick! I pushed up a fixup commit which changes the implementation to use an Option instead of a sentinel value. I did also change the rate type from a usize to a u128 though, in order to avoid casting the TraceID to a usize every time - because I believe this operation may panic if the u128 doesn't fit into a usize.

This is great, thanks!


Requesting workflow suggestions and/or workaround

This isn't really a bug report but rather a list of issues workflow I have. Some of them are related to w64devkit while others are more of a windows issue - but maybe I can get some suggestions here anyways.
Ctrl+z
This was one of the biggest issues I ran into since my workflow consists of getting in and out of vim quickly via ctrl+z. But looking at https://github.com/skeeto/w64devkit/issues/30 it seems like this is unfixable. I've mostly managed to work around this by using 2 terminals and alt+tab.
Gdb locking up the executable
This is currently the biggest annoyance for me when using w64devkit. Because gdb locks up the exe, I cannot recompile the source again unless I go over to gdb and kill the exe with k. This is huge flow killer for me, especially since I'm not familiar with windows APIs and thus am often trying multiple different things out which requires lots of recompilations.
vim's termdebug plugin
Vim has a builtin plugin called termdebug which integrates gdb in vim. You can try it with :packadd termdebug and then :Termdebug. The problem is the gdb it spawns is unaware of w64devkit's environment. And so ! commands don't call into w64dk's shell and so forth.
I can cope with it by using a different terminal for gdb so it's more of a minor issue, though I'd prefer if termdebug worked properly instead since having editor and debugger integrated gives a better experience IMO since the line I'm stepping over in the debugger becomes synced with the editor window. And so if I notice something needs change, I can make that change more easily since the editor is at that line already.
PDB support
I've been thinking of switching over to Raddebugger (https://github.com/EpicGamesExt/raddebugger) on windows to avoid some of these gdb annoyances. But raddbg currently doesn't support DWARF files (it's in the roadmap though), only PDB. It might be nice to have some tool that can emit pdb in w64dk (afaik, clang can, but I doubt you'd want to add a giant tool like llvm/clang).
I have found this tool that claims to be able to do dwarf -> pdb conversion: https://github.com/rainers/cv2pdb but I haven't tried it out yet.

Also forgot to mention that git missing was also an annoyance. But I've just downloaded a portable version and adding it to PATH via .profile.

Ctrl+z

Yes, alt-tab is probably the best you can do. Have you considered gvim? I
personally prefer it over terminal vim, though I still use the latter in
certain contexts (git commits, composing this email). Resistance to gvim
is quite common, and it always surprises me.
I admit, I have quite a bit of Windows configuration, and I often forget
how poor stock Windows is out-of-the-box. (I have the same feelings about
Gnome, KDE, etc.) The Windows 11 alt-tab switcher is just awful. The old
behavior is still available through a registry entry. In fact, here's my
whole "Windows rc file" of sorts (which badly needs documentation):
https://github.com/skeeto/dotfiles/blob/master/init.bat
Starting with Aero, Windows gained some nice Window management keyboard
shortcuts that are worth learning. Snap is particularly nice if you turn
off the brain-damaged "snap assist" stuff Microsoft added later. I've even
adopted some Aero key bindings in my Openbox configuration.

Gdb locking up the executable

It's really Windows locking the executable because it's mapped into a
running process. There's really no way around that. In theory GDB could
make a copy to run. That would interfere with GetModuleFileName, and it
wouldn't work for DLLs you might also recompile — probably acceptable in
most cases. Maybe there's a way to rig this up.
Handmade Hero has a hot-reload system, with an architecture a bit like
Quake. The core application is a DLL, and the main EXE renames the DLL
before loading it (or was it the build system that does this?), leaving
the original unlocked. It then watches for recompiles and automatically
reloads when it happens. No locking problems.
Unless you're going to build something like that, you're stuck killing the
process before rebuilding. I've mostly grown accustomed to it myself, and
sometimes I catch myself doing it on Linux. At one point I explored having
vim or the build pkill before building, but that won't work if the target
is paused in GDB, which is the usual situation. (Maybe something termdebug
could address since it's integrated?)

And so ! commands don't call into w64dk's shell and so forth.

Yup, that's a general GDB problem, not just termdebug. Despite the GDB
documentation, it ignores $SHELL and uses cmd.exe. I haven't found a
solution. I use ! often myself, and I even have g aliased to "!git" so I
can seamlessly interact with Git in my GDB terminal. I've just had to
accept that it's a cmd.exe command, not sh. However, because I have .exe
command alias for the busybox-w32 built-ins, they're all accessible to
this shell (unless termdebug is messing this up?).

I have found this tool that claims to be able to do dwarf -> pdb
conversion

I found this a couple years ago and have a fork here:
https://github.com/skeeto/cv2pdb
The PDBs it produced didn't work reliably in RemedyBG, which is now fixed:
https://github.com/x13pixels/remedybg-issues/issues/247
I considered adding cv2pdb to w64devkit, but I quickly learned it requires
Visual Studio as a run-time dependency, which kind of defeats the purpose.
Though maybe it's worth it for your use case.

git missing was also an annoyance

True. I haven't yet given #77 the appropriate attention, in part because
I've gotten comfortable with portable Git. By the way, make sure you've
added its "cmd" directory to your path, not "bin".

Have you considered gvim?

Not yet, but I will give it a try. Thanks for the suggestion.

Resistance to gvim is quite common, and it always surprises me.

Personally, I prefer terminal version because I'm very comfortable in the terminal and ctrl+z makes switching between terminal and vim near seamless. But since I can't use ctrl+z in w64devkit anyways, I might as well try using gvim.

At one point I explored having vim or the build pkill before building, but that won't work if the target is paused in GDB, which is the usual situation.

I wonder if there's some other way IPC mechanism to tell gdb to kill the process from vim. But quick googling doesn't reveal anything.

(Maybe something termdebug could address since it's integrated?)

This might be possible, but I haven't looked into what protocol/api termdebug is using to communicate with gdb. This might be worth investigating, but looking at the plugin source, I can't say that I'm enthusiastic about doing that myself: https://github.com/vim/vim/blob/master/runtime/pack/dist/opt/termdebug/plugin/termdebug.vim
One more thing I forgot to mention (reminded by the comment in the plugin) is that on windows, termdebug will launch the debugee process in a new console - which is generally a distraction for me (similar to annoying popups).

(unless termdebug is messing this up?).

This seems to be the case, when I run !make from a gdb launched from w64devkit shell, it tells me it couldn't find any makefile which is expected.
When I run !make from gdb inside termdebug, nothing happens, there's no feedback at all.

but I quickly learned it requires Visual Studio as a run-time dependency, which kind of defeats the purpose.

That's a bummer.

make sure you've added its "cmd" directory to your path, not "bin".

Yup, I've got that setup properly by reading the portable README.

termdebug will launch the debugee process in a new console

Windows GDB has a "new-console" setting for this, which perhaps termdebug
enables by default. I'll enable it depending on what I'm debugging, but I
wouldn't want it enabled by default. (IMHO, it works far better than the
roughly-equivalent "tty" option on Linux!)

@skeeto gcc 14 apparently has -gcodeview which might work with remedybg. I think it's worth a try.

Interesting, I didn't know this was an upcoming feature! However, seems
like it won't quite be ready in GCC 14. I tried -gcodeview in the 20240405
snapshot, and neither RemedyBG nor Visual Studio 2022 could read the PDB
file. The latter reports "PDB format is not supported." I searched online,
and a few (old) results suggested disabling "managed compatibility mode"
in VS, but this option was removed in some earlier release.

@skeeto looks like only some patches for the option made it to gcc 14, the rest didn't.
But they got applied just now:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=36781ef8fd26eb9a0686957e7bac8f5ccc5ecc3f
In case you are interested to try again.

Thanks for the heads up, @Peter0x44. Took a little creativity to load an
arbitrary commit into the build container, but I got it built, and it's
definitely an improvement! RemedyBG loads the PDB and understands line
numbers, allowing me to step through GCC-built executables.
However, the good news ends there. RemedyBG does not see any symbols, so I
cannot inspect variables, see the call stack, nor break on symbols. That
unfortunately still falls short of practical. Visual Studio 2022 continues
to give the same "not supported" error, so no differences there, either.
The message says it's only the "initial support," suggesting it isn't
expected to work yet anyway, so hopefully it will continue to improve!

I have it working like this.

Install w64devkit to ~/code/w64devkit directory.
Install https://github.com/mstorsjo/llvm-mingw to ~/code/llvm-mingw directory.
Copy directories from llvm-mingw to w64devkit with replacement.
Compile like this:

clang -gcodeview -g hello.cpp -luser32 -Wl,--pdb= -o build/hello.exe

Inside ~/build we get:
~/code/hello $ ls build
hello.exe  hello.pdb

And there you have it (screenshot)

Obviously this is very hacky, but it's possible to replace gcc with clang in Dockerfile and it will become nicely packaged.


Bump up rk-entry version to v2.2.3

Codecov Report

Merging #26 (b1dc6af) into master (cc8cde9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   89.89%   89.89%
=======================================
  Files          18       18
  Lines         831      831
=======================================
  Hits          747      747
  Misses         65       65
  Partials       19       19

Help us with your feedback. Take ten seconds to tell us how you rate us.


Add get_auth_method utility function

Coverage increased (+0.7%) to 40.572% when pulling 11234b661bf895a528b51a47fe8b3e9108715ee6 on pickfire:get_auth_method into 1d439ede40dadc55e96fa2884c3e27cc9631f68a on newsboat:master.

Most of Travis builds failed, can you fix them please?

Looks good code-wise, but it doesn't build with Rust 1.25 because of libz-sys crate (macOS build, Linux build), and is not formatted properly. Will you deal with these, or should I take over? I usually just rustup toolchain override set 1.25 and pick the latest version of a crate that still builds.

Looks good code-wise, but it doesn't build with Rust 1.25 because of libz-sys crate (macOS build, Linux build), and is not formatted properly. Will you deal with these, or should I take over? I usually just rustup toolchain override set 1.25 and pick the latest version of a crate that still builds.

I have yet test with 1.25, but what I usually do is echo 1.25.0 > rust-toolchain, I only do rustup override set 1.25.0 sometimes. Maybe let me try again.

Maybe you can take this on, I tried on this but not sure how to specify the dependency of dependency.

Please don't rebase onto other PRs—that pollutes this PR's history with unrelated commits. Only rebase on master.

not sure how to specify the dependency of dependency

As far as I know, this can't be done directly, i.e. one can't say "curl-sys should be built with libz-sys version 1.2.3". However, one can take advantage of the fact that only one version of each crate gets built. By adding a libz-sys dependency directly to libnewsboat crate, I was able to "downgrade" it to a version that's buildable with Rust 1.25. I had to downgrade curl-sys a bit, too, since versions after 0.4.5 require libz-sys 1.0.18+.
I think it's time for me to figure out a real policy about compiler versions we support. Reading up on that now. Will probably open an issue about that later.
This PR looks good to me, I'll merge it when the CI passes.

Sorry, I rebased onto my own master, not the origin master.

[Many—but not all—builds failed]https://travis-ci.org/newsboat/newsboat/builds/531939383) because linker couldn't resolve openssl references. Interestingly, we didn't observe that with an earlier build that used the latest curl-sys crate.
I don't want to give up on Rust 1.25 just yet, so I'm trying another solution: link libnewsboat.a before libssl is linked. Let's just hope that curl-sys and our own config.sh pick the same SSL library.

Well, that didn't work out, and I've ran out of screen time for today. Will carry on tomorrow.

I saw that debian is using rust 1.24.1. Why not stick to edition 2015 without using all the new 2018 features instead of sticking to a rust version since you need an old compiler.

I aimed for 1.24.1 at first, but IIRC once_cell made me bump it to 1.24.1. I didn't fully comprehend Cargo.lock and Cargo's build planning back then, otherwise I'd try and force the 1.24.1 support by using an earlier once_cell version. Too late for that now.
We don't use any Rust 2018 features in Newsboat, primarily because they won't compile with 1.25. So we do stick to 2015 edition already. The problem is with dependencies that don't, and also dependencies that require newer compilers. The only way for us to fight that is to use older crate versions that have lower compiler requirements. But as we see here, it doesn't always work. I'm still looking into what can be done about that.

Looks like I fixed it! Apparently the debug build of curl-sys (or one of its dependencies, most probably openssl-sys) requires a symbol from OpenSSL's libssl library. We now link libssl after libnewsboat, which fixes the problem. OSX might be using different code, so it wasn't affected at all. This is all just speculation, of course—I didn't dig into the code to find the exact line that's using that symbol.
@pickfire, thank you for this PR! Wanna try rewriting another utils function? ;)

@Minoru Not at the moment, I am writing a parser for yaml. https://github.com/dtolnay/request-for-implementation/issues/9