Cannot access the topic of a received message

I've just started using robotframework-mqttlibrary, and I can set up a subscription as per the documentation, then successfully receive messages. If I subscribe to wildcards, e.g...
${message}=  Subscribe  topic=test/mqtt_test/+  qos=1  timeout=2
...I can successfully receive messages published to test/mqtt_test/apples, test/mqtt_test/oranges, test/mqtt_test/pears etc.
However, ${message} appears to only contain the content of the message payload, and I've been unable to work out if it's possible to determine the exact topic of the received message (e.g. was it test/mqtt_test/apples or test/mqtt_test/pears).
Is there any way to do this with robotframework-mqttlibrary?

Note: I've added a potential solution here: https://stackoverflow.com/questions/44681586/with-mqttlibrary-for-robot-framework-is-it-possible-to-determine-the-exact-topi
It would break existing Robot Framework scripts, as Subscribe would now return a list of lists, but it works for my application.

Yes, this is a breaking change, and honestly I'm not keen on adding this in near future. Hopefully the above solution works for you. If not, feel free to suggest a better solution and/or create a PR.


feat(showcase): add multi-player showcase

Description
Resolves #3 by introducing a new showcase that displays multiple players on the same page. A button has been added to allow the user to toggle the mute state for both players.

[!Note]
Only one player can have active tracking at a time, an issue has been created to provide documentation for this limitation, see: SRGSSR/pillarbox-web#208.

Changes made

Updated the titles of all pages in the application to follow a consistent pattern.
Updated the text example of the start-time showcase, the showcase itself was working but the text was still displaying the broken urn.

I also noticed a small bug when hovering over the player controls.

I also noticed a small bug when hovering over the player controls.

This has been fixed too.


Wrong YAML (de)serialization of nil and empty strings

Crystal's YAML builder/parser does not handle properly nil values and empty strings (specs):

Empty strings are serialized to nil
Most (all?) nil writings are deserialized to strings

Here is a small example:
$ cat test.cr
require "yaml"
p "".to_yaml
p [""].to_yaml
p({"a" => ""}.to_yaml)
p YAML.parse("---")
p YAML.parse("~")
p YAML.parse("null")
p YAML.parse("- ")
p YAML.parse("a: ")

the output:
$ crystal run test.cr
"--- \n...\n"
"---\n- \n"
"---\na: \n"
""
"~"
"null"
[""]
{"a" => ""}

$ crystal --version
Crystal 0.21.1 [3c6c75e] (2017-03-06) LLVM 3.5.0

to compare, the output of Ruby's implementation:
$ sed 's/parse/load/' test.cr | ruby
"--- ''\n"
"---\n- ''\n"
"---\na: ''\n"
nil
nil
nil
[nil]
{"a"=>nil}

$ ruby --version
ruby 2.1.5p273 (2014-11-13) [x86_64-linux-gnu]

I'm not sure it will be useful but here is the Ruby's Psych scalar scanner implementation.

This is more or less a duplicate of #4175 . The current YAML parser only knows about String, Array and Hash. We need to extend this to support the core YAML schema, possibly other schemas too.

@asterite Did you mean #2873 or #3101? Right now, your link is giving me a recursion error...

Oops, I tried to find a related issue but I missed both of them, thanks for the references.

This issue can't possibly be a duplicate of itself and I don't think it is a duplicate of #2873 or #3101 either. Please reopen.

No. It's a duplicate of #3101 per "unsupported types (e.g. null, numbers)".


issues when doing .transition(t)

Hi
I think there might be a bug in 3.0 when doing
const t = transition().duration(750);

selectAll("blah blah...")
   .transition(t)
   .attr('opacity', 1);

I keep seeing the error
Error: transition 1 not found
I'm using a factory for transitions, and it's been working in previous versions, but updating to 3.0 keeps giving me this error

Per the README, emphasis added:

If the name is a transition instance, the returned transition has the same id and name as the specified transition. If a transition with the same id already exists on a selected element, the existing transition is returned for that element. Otherwise, the timing of the returned transition is inherited from the existing transition of the same id on the nearest ancestor of each selected element. Thus, this method can be used to synchronize a transition across multiple selections, or to re-select a transition for specific elements and modify its configuration.

If you’re seeing this error, it’s either because (1) the transition has expired (not evident from your code snippet, but you didn’t share a complete working example so it’s impossible to say) or (2) the “blah blah” elements you are selecting are not descendant elements of the transition t.

(This happens in 3.0 because of #59; in earlier versions, it would silently ignore the t argument when the transition was not found.)

@mbostock I'm usually good w reading the d3 docs and figuring stuff out, however I still don't understand what could be happening.
Here's how I use transitions:
I've got a factory:
https://github.com/carbon-design-system/carbon-charts/blob/8c27e54319d8aabcccdfcee211acc0c669572cef/packages/core/src/services/essentials/transitions.ts#L20-L39
And I use it like so:
https://github.com/carbon-design-system/carbon-charts/blob/8c27e54319d8aabcccdfcee211acc0c669572cef/packages/core/src/components/axes/grid.ts#L100-L103
That's all working in 5.x, now trying to upgrade to 6.x or 7.x I keep seeing transition 1 not found
I might've misread your docs, but as a naive fix I tried adding an incrementing ID in my factory

and I still get the same error.
Could you pls clarify what needs to change?

I still feel like I'm not understanding how transitions are supposed to be working
Is this better?

bumping

In case anyone else is having these kinds of issues. I ended up using .call() to handle my transitions


gopls compatability

I am using the latest version of:

[x] Atom v1.13.1 x64
[x] ide-go v0.12.3
[x] atom-ide-ui
~-   [ ] go-langserver~

Operating System:
macOS 10.14.3
Expected Behavior
Expected it to JustWork™ when setting the server path to ~/go/bin/gopls, as it does for when using bingo. Since bingo is no longer going to be maintained in favour of gopls the ide-go package should work with the official language server.
Actual Behavior
A gopls process is spawned, but Atom does not communicate with it from what I can tell.
Steps to Reproduce
go get -u golang.org/x/tools/cmd/gopls
Set custom server path to $(which gopls)
Reload window, check for process with ps aux | grep gopls to see process.
See that atom-ide-ui displays nothing, format on save doesn't work, etc.

It seems to work using @saibing's version of gopls, however there are a lot of... interesting issues with it it seems. Go module support seems rather lacking at the moment.
I doubt there is anything to do here for this package, except maybe make gopls the first class supported citizen rather than go-languageserver.

I agree that it would be preferable for this plugin to switch to gopls since it is still in active development and supports go modules, as described here


Any ideas in using it on S31 ?

Well basically the S20 and S31 have the same ESP and the same pin assignments , but when I load it it just sticks on the WiFi selection and don't connect to my Network it stuck in the AP mode,  im really not interested on the current monitor in this point, so any ideas what is happening ?

Need more info

Well, I check the serial monitor and its curious. Let me explain in the steps.
I make the Sonoff basic all, after that I put in on my Sonoff and everything works perfect. After that I make the S20 and put in on my S31 and just stuck (checking the serial when I put my WiFi credentials, it just drops "No Wifi Configuration".
So I go back and flash another Sonoff Basic , and It just gets in the same error


wrong suggestions in bidirectional pattern synonyms

Issue.hs:
{-# LANGUAGE PatternSynonyms #-}
pattern A <- (True, True) where A = (not $ False && True, True)

hlint suggestions:
Issue.hs:2:38: Error: Evaluate
Found:
  not $ False
Why not:
  True

Issue.hs:2:38: Warning: Redundant $
Found:
  not $ False
Why not:
  not False

2 suggestions

Thanks! Looks like something (either me or Haskell-Src-exts) is forgetting to fixity inside the pattern. Would it be legitimate for hlint to suggest evaluating the && and replace that with False?

Yes, it would be legitimate to suggest evaluating (&&) here. Btw, this is not a real-life example, I simplified a more complex one and got this.

Thanks for the simplification. I think this is an error in the underlying HSE library, which I've raised upstream at https://github.com/haskell-suite/haskell-src-exts/issues/290.

Confirmed works with HEAD that doesn't use HSE for parsing, so fixed in the next release.


Put all resources under a flowstorm folder to avoid collisions

AFAIK, any files under resources will collide with similarly named files in users' projects. [1][2]
Ex. resources/styles.css (which currently exists in flowstorm), can be accidentally overridden if a user has resources/styles.css in their own project (and flowstorm pulled in).
This may result in potential issues with a user using flowstorm (flowstorm files accidentally overridden) or in their own projects (their files overridden by flowstorm ones).
(This typically isn't an issue with other libraries, because they don't have resources, just src files).
The simplest solution would be to "namespace" flowstorms resources, ie. move all files under resources/ to, say, resources/flow-storm/.

Ohh you are right, I'll namespace all resources


Uf

Describe the issue
A clear and concise what the issue
Feature area
What's incorrect? What's missing?
Existing doc link
If this is about something in an existing document, please provide link
Additional context
Add any other context about the problem here.

Todo bien


Is it possible to add sql's called in test reports?

Hi,
In our test report we want to see which sql's called. We investigated the source code, but seems like only you are logging to logger. Can we add called sql's to test report?
Thanks,

You would have to implement a custom TestReporter that gets access to the executed test actions (sql actions) as TestActionListener. Then you could create a custom report.


Chat React Component

Update: this will be two components:
Lower level component:

takes props for subscription criteria

High Level Component:

Enforces our recommended thread model. Specifically:

All new messages are added to the existing thread
Input prop


Concurrency limit per action

Description

After #2795 which only provides system-wider concurrency settings, this will allow per-action concurrency limit.
To use it:

specify whisk.concurrency-limit configs e.g.

whisk.concurrency-limit {
        min = 1
        max = 500
        std = 1
    }

enable concurrency in actions using: "limits":{"concurrency":125} in the action json

In a later PR, additional changes will be useful in cli, e.g. to enable a concurrency flag: wsk action create --concurrency 125
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[x] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[x] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #3687 into master will increase coverage by 0.1%.
The diff coverage is 79.27%.

@@            Coverage Diff            @@
##           master    #3687     +/-   ##
=========================================
+ Coverage    74.5%   74.61%   +0.1%
=========================================
  Files         126      127      +1
  Lines        5994     6054     +60
  Branches      392      402     +10
=========================================
+ Hits         4466     4517     +51
- Misses       1528     1537      +9

Impacted Files
Coverage Δ

...sk/core/containerpool/docker/DockerContainer.scala
75% <0%> (-2.03%)
:arrow_down:

...ain/scala/whisk/core/invoker/InvokerReactive.scala
0% <0%> (ø)
:arrow_up:

...la/whisk/core/containerpool/ContainerFactory.scala
100% <100%> (ø)
:arrow_up:

...cala/src/main/scala/whisk/core/entity/Limits.scala
85.71% <100%> (+1.09%)
:arrow_up:

...cala/whisk/core/containerpool/ContainerProxy.scala
92.67% <100%> (+0.85%)
:arrow_up:

...ain/scala/whisk/core/containerpool/HttpUtils.scala
93.02% <100%> (+0.52%)
:arrow_up:

...src/main/scala/whisk/core/entity/WhiskAction.scala
77.62% <100%> (ø)
:arrow_up:

.../scala/src/main/scala/whisk/core/WhiskConfig.scala
92.3% <100%> (+0.05%)
:arrow_up:

...src/main/scala/whisk/core/controller/Actions.scala
91.45% <100%> (+0.17%)
:arrow_up:

...ain/scala/whisk/core/containerpool/Container.scala
76.19% <66.66%> (ø)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc2227...2ba392a. Read the comment docs.

Closing this PR, and rolling these changes into #2795 (since these changes are required in any case, to make concurrency configs useful)


add block storage get docs

Coverage remained the same at 78.158% when pulling 8741f9d1c353c41b9d567f6040f9ab5dbd118c86 on mparke:add-block-storage-get-docs into ddbe8233ea0409da5b5aa820e290c7f4fce1f21c on linode:develop.

Coverage remained the same at 78.158% when pulling 8741f9d1c353c41b9d567f6040f9ab5dbd118c86 on mparke:add-block-storage-get-docs into ddbe8233ea0409da5b5aa820e290c7f4fce1f21c on linode:develop.


[Feature Request]: Break Client Routing Into Accessible Chunks

Feature description
As I noted in a comment here, I think we should look to break up our routing into three sections.

Authed but not "allowed" users -- this can be used to be landing pages and resources to help people see what we do but they can't do any create/manipulation/deletion of resources We have since disabled this feature -- you're either allowed or not.
Allowed users -- once they are authorized by OAuth, we allow them access to everything they have access to create Notebooks or projects or what have you -- we can also narrow as a secondary filter, by using useAccessReview (from OpenShift Console) to hide UI elements when the user does not possess the ability to do those actions (as the k8s call will fail anyways)
Admin users -- everything green under the sun, no restrictions

In our Routing, we can use component composition to just mount portions of the router in different spots -- globally disabling it at one level thus preventing any of those routes mounting -- any bookmark or direct navigation will end up in 404 (we can maybe look at auth checks & 403 wrapper pages if they have Dashboard access but do not have k8s access)
I think this will help us stay clean as more UI elements get added moving forward.
Describe alternatives you've considered
No response
Anything else?
No response

When we do this work, we should take the loading logic in https://github.com/opendatahub-io/odh-dashboard/pull/447 and move it into its own component (with the fetching logic for user).
App structure can be something like:
<App>
  <LoadUser> // << new, put the `detectUser` logic in here and handle the loading state and error state within
    <AppContext.Provider>
      <Page ...>
         ...
      </Page>
    </AppContext.Provider>
  </LoadUser>
</App>

We should also consider mounting our own custom <Route  -- where we implement an Error Boundary component (see React docs) along with permission checking. Make it nice to add new routes.

@andrewballantyne Please move to jira

Moved to Jira: https://issues.redhat.com/browse/RHOAIENG-944


Upload issue of beta table

Hi,
I hope this finds you well. I am writing to ask you a question about the online app.
I checked that I can upload your example beta table on the app, but I encounter an error when I tried to upload my beta table, which I tried my best to mimic the structure in your beta table. Attached is the screenshot of the error code, where I do not know where I can check the log:

Could you help me figure out what went wrong? Thanks so much.
Best regards,
Daisuke Adachi

Hi Daisuke,
Thanks for your email!
I think you did not know do anything wrong. However, you also need to
upload the remaining two CSVs (with the covariance and hypothesized
difference in trends) in order to get the results from the Shiny. There
appears to have been a bug with the error messaging on the Shiny app so
that this was very unclear. I have pushed an update that should hopefully
make it much clearer! Sorry about that. Let me know if it works or if you
have any other issues.
Best,
Jon
On Mon, Jul 4, 2022 at 4:31 AM Daisuke Adachi @.***>
wrote:

Hi,
I hope this finds you well. I am writing to ask you a question about the online
app https://jonathandroth.shinyapps.io/pretrendspowerapp/.
I checked that I can upload your example beta table
https://github.com/jonathandroth/PretrendsPower/blob/master/example_beta.csv
on the app, but I encounter an error when I tried to upload my beta table
https://github.com/jonathandroth/PretrendsPower/files/9039030/beta_l_emp.csv,
which I tried my best to mimic the structure in your beta table. Attached
is the screenshot of the error code, where I do not know where I can check
the log:
[image: Screenshot 2022-07-04 at 13 22 57]
https://user-images.githubusercontent.com/27741570/177145998-8f47a23c-a353-4cf7-8ce3-ac32000ab939.png
Could you help me figure out what went wrong? Thanks so much.
Best regards,
Daisuke Adachi
—
Reply to this email directly, view it on GitHub
https://github.com/jonathandroth/PretrendsPower/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE6EXFCG3VDHUF4C3LW2ICLVSLDRDANCNFSM52S4B3RA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi Jon,
This is great. I could perform the pre-test on the app now.
The app was great overall especially because I use mac and encounter the same problem as in another thread on your repo. But the app gave me the workaround, so thanks so much!
Best,
Daisuke

Awesome, glad to hear!
On Mon, Jul 4, 2022, 11:39 AM Daisuke Adachi @.***>
wrote:

Closed #2 https://github.com/jonathandroth/PretrendsPower/issues/2 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/jonathandroth/PretrendsPower/issues/2#event-6929705341,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE6EXFAHZGBBJTMVX5VG5SDVSMVVBANCNFSM52S4B3RA
.
You are receiving this because you commented.Message ID:
@.***>


mjml-social: base-url not applied to custom icons

With such a definition:
<mj-social
    display="custom-network"
    base-url="http://static.example.com/"
    custom-network-icon="icon.png" />

The icon is rendered as <img alt="custom-network" height="20" src="icon.png"> and not with src="http://static.example.com/icon.png" which was my expectation at first.
I'm not sure if this should be considered as an issue because if you naively used base-url for custom icons paths it would break the standard icons if you're not hosting facebook.png/twitter.png/google-plus.png/pinterest.png/linkedin.png/instagram.png at the same time.
At first I thought to apply base-url to custom icons at https://github.com/mjmlio/mjml/blob/master/packages/mjml-social/src/index.js#L230:
-      icon: mjAttribute(`${platform}-icon`)
+      icon: mjAttribute('base-url') + mjAttribute(`${platform}-icon`)

And update the doc to say you have to host facebook.png/etc. at the base-url otherwise it's broken.
But then you would not be able to provide a full path for a custom icon without having it prefixed by the default base-url (https://www.mailjet.com/images/theme/v1/icons/ico-social/) unless you set base-url="".
Sooo:

maybe just update the doc to say you have to provide full paths for custom icons and host the standard icons if you ever change base-url ?
or apply base-url to custom icons and say you must set base-url if you use custom icons (and host facebook.png/etc. once base-url is changed from the default) ?

Also custom network attributes trigger the validator:
Line 3 (mj-social) — Attributes custom-network-content, custom-network-href, custom-network-icon-color, custom-network-icon are illegal
But that's another issue.

Hi @blaze33 !
Yes, base-url is only for default icons. I think we'll have to update to reflect this behaviour.
For validation, we have plans on 3.1 to add some feature on validation that allow wildcards attributes and may be value restriction too ! But that's not for today 😄

Okay, thanks and good luck for the next release !
We use mjml at work at Smart Impulse and it really helped us a lot to have such a good framework available :)

Doc has been updated so I'm closing this !
Doc on website will be up to date soon.


Exception when failing to find binary path for Stark.run

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'launch path not accessible'

Need to add a check for this exception, else Stark crashes.

Added a check before launching the process to see if the binary exists at the specified path.


Add ZeroGPU to hub docs

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Releases/<IP_ADDRESS>

Overview
PR to be merged, using travis CLI, create encrypted file codesigning.asc.enc, encrypt env variable in travis.yaml
What
prototype for uploading code: snapshot or release to maven central repository,
Since commit have been made into bitcoinj by you Manfred, we can not push to the default groupID
org.bitcoinj
so i rename it to
io.bisq.bitcoinj
so we can push to maven central in our namespace own by us. Of course middle term we need to decide for a strategy:

go back to main branch of bitcoinj would mean submitting many PR and make them accepted by the bitcoinj project...could be difficult but is my preferred option
Bisq keep a fork, but require more effort in long run and is definitely more risky if some of our commits conflicts or introduce unforeseen security issues...

In order to push to Maven central code need to be signed, some files
cd/before-deploy.sh
cd/deploy.sh
cd/mvnsettings.xml

have been added to git, creating a gpg sub key of your key is recommended for safety reason, and need to be committed in cd/codesigning.asc.enc
Only you Manfred can prepare this, you can follow this
http://www.debonair.io/post/maven-cd/ starting at header Create signing sub-key
NOte that this branch name was chosen on purpose, there is my plugin <artifactId>git-branch-renamer-maven-plugin</artifactId> that will rename all pom to <IP_ADDRESS>-SNAPSHOT on mvn clean -Prename-pom-like-branch
We need of course to do the same for all 4 repositories: btcd-cli4j, libdohj, bitsquare
Target
Every repository bitcoinj, btcd-cli4j, libdohj, bitsquare build on its own, get pushed to maven central

Hi @cedricwalter, just quickly weighing in here. Thanks for doing this work, but for several reasons, I'd like to avoid publishing artifacts from our modified forks of bitcoinj and other libs to Maven Central.
Rather, I'd prefer to publish and consume them in a much lighter-weight fashion via the service at https://jitpack.io (I'm not sure whether you're familiar with it).
This is something I've been meaning to bring up with @ManfredKarrer and you, but I'm afraid more pressing concerns have been taking priority in the meantime.
So if you don't mind, let's please hold off on this PR until we can have a chat about JitPack. Let's discuss in Slack if that works for you.
In any case, thanks again for digging into this. Eliminating the need to build these dependent libraries is going to remove a painful barrier to entry for building and working on Bisq!

Closing as superseded by bitsquare/bitsquare#899.


Multiple diversity types

[x] Report on diversity type in output
[x] Update sub-packages and docs
[ ] Allow multiple diversities to be measured simultaneously
[ ] Output necessary parameters to disambiguate

Fixes #26.

Coverage decreased (-0.4%) to 93.979% when pulling bddfb9b1ccc5acb4ff786fe3d8bb648b563b805c on multiple into ef0a4d503e47b1915417ccce941f0c4120f03d7a on master.


Cannot install

Issue summary
The docs have pretty straightforward instructions on how to install:
$ composer require bakame-php/dice-roller

System informations
I'm not sure what to put here.  Please let me know if there's any additional information that might help.
Standalone code, or other way to reproduce the problem
I go to the command line and execute the following command:
$ composer require bakame-php/dice-roller

Expected result
The package is installed.
Actual result
The package is not installed and the following message is displayed:
Could not find a matching version of package bakame-php/dice-roller. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (dev).

I also noticed that the readme.md doc shows the following on the package's main github page:
release | no releases or repo not found

Also, I can't find the package on packagist.org....but perhaps I'm looking in the wrong place...?

@telkins yes currently the code is not yet on packagist 👍 the reason being that I'm not really ready to do it yet

@nyamsprod OK.  Thx for the info.  I guess I'd like to know, then, how you might suggest we install it.  :-)

@nyamsprod Any updates on this?

I'd say the easiest way for you would be to fork and release it's MIT so it's okay 😉

@nyamsprod Thx.  Sounds good.  Appreciate the response.  :-)

@nyamsprod Could you please detail the best way to install the dice-roller and its dependencies ? I've tried adding this github as a composer repository and succeeded make dice-roller a dependency but then my php script fails on the includes (Uncaught Error: Class 'Bakame\DiceRoller\ExpressionParser' not found).

OK, I've defined it in the my app composer.json this way :
{
  "require": {
    "php": "^7.2",
    "psr/log": "^1.1"
  },
  "autoload": {
    "psr-4": {
      "Bakame\\DiceRoller\\": "./dice-roller/src"
    }
  }
}

and git cloned this repo to get the files. Now it works properly.

Also had to add the line require_once __DIR__ . '/vendor/autoload.php'; to my app before the use declarations.

This package will stay unpublished for the forseeing future the best anyone can do if he/she wishes to use it is to fork it and make it his/her own.


Fix the clippy::explicit_iter_loop lint

Objective
Replace instances of
for x in collection.iter{_mut}() {

with
for x in &{mut} collection {

This also changes CI to no longer suppress this lint. Note that since this lint only shows up when using clippy in pedantic mode, it was probably unnecessary to suppress this lint in the first place.

Once you fix merge conflicts I'll merge :p

This also changes CI to no longer suppress this lint. Note that since this lint only shows up when using clippy in pedantic mode, it was probably unnecessary to suppress this lint in the first place.

I was very confused for a second, but we used to use -Wclippy::explicit_iter_loop in CI, and when I updated for rust 1.72 I just changed that to -A.
Do we want to add that back in now?

On second though, let's not add the warning yet. This suggestion is makes it worse.
373 |         for (access, _) in self.0.iter() {
    |                            ^^^^^^^^^^^^^ help: to write this more concisely, try: `&*self.0`

Seems like the suggestion will be fixed in the next clippy release (https://github.com/rust-lang/rust-clippy/issues/11074), so we can enable the warning then.


docs, tests, coveralls, minor tweaks

Changes Unknown when pulling 5d92545b1e3c53cf75d2f3a8d864a4c4307011df on dev into ** on master**.


Add oblique-strategies extension

Description
A quick way to get inspiration using oblique strategies. There is also a search command that provides a list, filterable by editions, as well as an AI command which I haven't been able to test without the pro subscription.

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Sorry for the waiting time, I'll clearing something internally 🙂


non-interactive SSH run

I've set vertx-shell to connect with SSH, and everything works very well.
The only problem is, how to do non-interactive things vis ssh command?
I've tried:
ssh user@${ip} -p ${port} ls

But I failed.

it is currently not implemented.

I use expect instead.
#!expect -f
spawn ssh -o StrictHostKeyChecking=no user@${ip} -p ${port}
expect "Password: "
send "PASSWORD\r"
expect "% "
send "ls\r"
expect "% "
send "exit\r"
expect eof

Hope it will be simplified by using ssh non-interactive.

yes it should be supported, I agree with you. thanks for the workaround.

I've made it an enhancement


Implement cluster-inventory

Description
The cluster inventory is managing all clusters handled by the reconciliation service. The inventory has an interface to KEB to receive information about new clusters or clusters which require an upgrade.
The inventory will store all cluster data in a database and support querying for cluster entities. Each entity has, beside it's name and some metadata (like its configuration, component list etc.) also a particular state. The cluster state will be several times updated during its lifetime (each reconciliation causes several cluster date updates).
The inventory will support efficient access to clusters which require any kind of reconciliation (e.g. used by schedule) and it allows to query efficiently for clusters which are in a failed/error or transition state (e.g. required by the metrics exporter).
ACs:

REST interface to KEB implemented
Support for CRUD operations for database cluster-entities to change cluster metadata (done only KEB) or cluster states (done only by scheduler)
Query possibilities to retrieve clusters in particular states (query performance has to be verified, respectively optimised as it will be used quite frequently).
The inventory is capable to retrieve kubeconfig files/strings for particular clusters from either Gardener or the underneath running KCP cluster.

Reasons
Centralised managing of cluster data.
Attachments

Interfaces required:

update status of cluster (will have to notify the metrics exporter) +   state changes have to be validated by model
Type: GO API
Input: cluster-id
Output: error (nil if update was successful)
Add new cluster (inclusive configuration) => initial state will be reconcile_pending
Type: REST API
Input: JSON as defined in contract
Output: http-status + URL (success) or failure description (error)
Upgrade cluster (inclusive configuration) => state will be set to reconcile_pending
Type: REST API
Input: JSON as defined in contract
Output: http-status + URL (success) or failure description (error)
Delete cluster
TBC: do we have to delete entries in DB or just set the state to deleted
Type: REST API
Input: JSON as defined in contract
Output: http-status
Get cluster state (used by KEB) => is specific to the status of a particular cluster configuration
Type: REST API
Input: Cluster-ID + Configuration-ID (via URL)
Output: http-status + cluster-status (of the particular configuration entity)
Get all clusters which required reconciliation => will return a list of particular cluster entries, considered are clusters in state reconcile_pending, reconcile_failed (if time-based reconciliation is enabled, each cluster which is in state ready longer than X seconds)
TBC: how to deal with "interim" configurations? Skip the more ensure each configuration was always reconciled at least once?
Type: GO API
Input: none
Output: List of cluster entities + the related configuration entity


Falco on GKE/COS -  Unable to download Kernel headers

Describe the bug
Using official Helm chart and enabling eBPF on a GKE cluster, the Kernel headers cant't be downloaded because they are not found in  https://dl.bintray.com/falcosecurity/driver
How to reproduce it
Install Falco using helm chart on a GKE cluster (1.16.13-gke.401) running COS instances and enable ebpf as defined in the documentation.
Expected behaviour
falco-driver-loader should download the kernel headers and falco services should start properly.
Current behaviour
The service failed to start because the kernel header can't be found on https://dl.bintray.com/falcosecurity/driver
* Setting up /usr/src links from host
* Running falco-driver-loader with: driver=module, compile=yes, download=yes
* Unloading falco module, if present
* Trying to dkms install falco module with GCC /usr/bin/gcc
DIRECTIVE: MAKE="'/tmp/falco-dkms-make'"
* Running dkms build failed, couldn't find /var/lib/dkms/falco/2aa88dcf6243982697811df4c1b484bcbe9488a2/build/make.log (with GCC /usr/bin/gcc)
* Trying to dkms install falco module with GCC /usr/bin/gcc-8
DIRECTIVE: MAKE="'/tmp/falco-dkms-make'"
* Running dkms build failed, couldn't find /var/lib/dkms/falco/2aa88dcf6243982697811df4c1b484bcbe9488a2/build/make.log (with GCC /usr/bin/gcc-8)
* Trying to dkms install falco module with GCC /usr/bin/gcc-6
DIRECTIVE: MAKE="'/tmp/falco-dkms-make'"
* Running dkms build failed, couldn't find /var/lib/dkms/falco/2aa88dcf6243982697811df4c1b484bcbe9488a2/build/make.log (with GCC /usr/bin/gcc-6)
* Trying to dkms install falco module with GCC /usr/bin/gcc-5
DIRECTIVE: MAKE="'/tmp/falco-dkms-make'"
* Running dkms build failed, couldn't find /var/lib/dkms/falco/2aa88dcf6243982697811df4c1b484bcbe9488a2/build/make.log (with GCC /usr/bin/gcc-5)
* Trying to load a system falco driver, if present
* Trying to find locally a prebuilt falco module for kernel 4.19.112+, if present
* Trying to download prebuilt module from https://dl.bintray.com/falcosecurity/driver/2aa88dcf6243982697811df4c1b484bcbe9488a2/falco_cos_4.19.112%2B_1.ko
curl: (22) The requested URL returned error: 404 Not Found
Download failed, consider compiling your own falco module and loading it or getting in touch with the Falco community
Tue Oct 27 15:50:32 2020: Falco version 0.26.1 (driver version 2aa88dcf6243982697811df4c1b484bcbe9488a2)
Tue Oct 27 15:50:32 2020: Falco initialized with configuration file /etc/falco/falco.yaml
Tue Oct 27 15:50:32 2020: Loading rules from file /etc/falco/falco_rules.yaml:
Tue Oct 27 15:50:33 2020: Loading rules from file /etc/falco/falco_rules.local.yaml:
Tue Oct 27 15:50:34 2020: Unable to load the driver.
Tue Oct 27 15:50:34 2020: Runtime error: error opening device /host/dev/falco0. Make sure you have root credentials and that the falco module is loaded.. Exiting

Environment

Falco version: 0.26.1
System info:
Cloud provider or hardware configuration: GKE
OS: COS
Kernel: 4.19.112+
Installation method: kubernetes

Additional context
The https://dl.bintray.com/falcosecurity/driver/2aa88dcf6243982697811df4c1b484bcbe9488a2 directory does not contain any kernel headers for COS.

Thanks @leodido
For some reasons running directly helm with the command you gave to me works:
* Setting up /usr/src links from host
* Running falco-driver-loader with: driver=bpf, compile=yes, download=yes
* Mounting debugfs
* Found kernel config at /proc/config.gz
* COS detected (build 12371.1079.0), using cos kernel headers
* Downloading https://storage.googleapis.com/cos-tools/12371.1079.0/kernel-headers.tgz
* Extracting kernel sources
* Configuring kernel
* Trying to compile the eBPF probe (falco_cos_4.19.112+_1.o)
* Skipping download, eBPF probe is already present in /root/.falco/falco_cos_4.19.112+_1.o
* eBPF probe located in /root/.falco/falco_cos_4.19.112+_1.o
* Success: eBPF probe symlinked to /root/.falco/falco-bpf.o
Wed Oct 28 14:00:17 2020: Falco version 0.26.1 (driver version 2aa88dcf6243982697811df4c1b484bcbe9488a2)
Wed Oct 28 14:00:17 2020: Falco initialized with configuration file /etc/falco/falco.yaml
Wed Oct 28 14:00:17 2020: Loading rules from file /etc/falco/falco_rules.yaml:
Wed Oct 28 14:00:18 2020: Loading rules from file /etc/falco/falco_rules.local.yaml:

I have to investigate why it fails when I edit the values.yaml ...
I let you know during the day if I found the issue if it's a mistake on my side or a real bug !
Thanks again

@leodido I found my mistake.
Actually I'm deploying Falco using the helm chart and ArgoCD.
Because previous version of ArgoCD was not creating a default namespace the common practice was to create a wrapper Helm chart. So a directory structure like that:

@nhuray Thanks for the explanation!
Happy to see you solved that.
/close

@leogr: Closing this issue.

In response to this:

@nhuray Thanks for the explanation!
Happy to see you solved that.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Error importing Slider in React app and https://jamesmfriedman.github.io/rmwc

Bugs
What RMWC Version are you using?

1.5.3

What browser(s) and React Version is this bug affecting?

Browser : Internet Explorer 11
React Version : 16.3.1
User Agent String : Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; Touch; rv:11.0) like Gecko

What build system are you using?

Webpack

What are the steps to reproduce the bug?

import something from rmwc (in my case, "import {Slider} from 'rmwc/Slider';")
run app in Internet Explorer

What is the expected behavior?

I should be able to import the slider without any error

What is the actual behavior?

When executing the steps, I have the following error : TypeError: Object doesn't support property or method 'getOwnPropertySymbols'

Any other information you believe would be useful?

I have the same error if I navigate to https://jamesmfriedman.github.io/rmwc/sliders in Internet Explorer

Hi Jessica,
I need to document browser support, but I haven't focused any attention on anything below evergreen browsers (read, IE).
WIth that said, this is an easy fix. MDN shows that this method isn't available in IE  so you just need to polyfill it. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertySymbols
My advice for any project trying to support legacy browsers would be to include the babel polyfill which should help you across the board with issues such as this. https://babeljs.io/docs/usage/polyfill/

I'm going to close this one out @umaknow-jessica in favor of #205. Hope that helped.


Concordance of SNPchip with WGS calls

SNPchip VCF has SNP calls from GRCh37 and contains 1,034 samples and 483,482 variants. Example sample names are:

1) 1_1
2) 2_2
...

155) 163_163
156) 164_165 # <- right value starts being +1
157) 165_166
...
1029) 1084_1085
1030) 1096_845_2 <- dups start (845_846 exists)
1031) 1100_914_2
1032) 1102_932_2
1033) 1103_926_2
1034) 1104_920_2

WGS GVCFs are per-sample and contain >24 million variants rows each. Example sample names are:

TOB1524, TOB1532, TOB1533, ...

[ ] Get sample name mapping between platforms
[ ] Use Crossmap to liftover SNPchip VCF from GRCh37 to GRCh38
[ ] Filter out non-variant sites from GVCFs
[ ] Explore Hail Concordance, Picard GenotypeConcordance, custom solution

Use Crossmap to liftover SNPchip VCF from GRCh37 to GRCh38

Would there be an advantage of reprocessing the raw data with GRCh38 instead of lifting over?

Thought of that too. I guess we'll get a small percentage of variants that can't be lifted over (will try in a bit).
For reprocessing, we would need to figure out how/where to run GenomeStudio - I think it only runs on Windows (maybe we could grab a GCP Windows machine??).

Sort and convert GRCh37 to hg19

INPUT_VCF="onek1k_pre_imputation_genotypes.vcf.bgz"
OUTPUT_VCF="sorted_test.vcf.gz"

cat \
  <(bcftools view -h $INPUT_VCF | sed 's/contig=<ID=/contig=<ID=chr/') \
  <(bcftools view -H $INPUT_VCF | sort -k1n,1 -k2n,2 | awk '{{ print "chr" $0 }}' ) \
  | bgzip > $OUTPUT_VCF

Liftover hg19 to hg38

$ CrossMap.py vcf hg19ToHg38.over.chain.gz sorted_test.vcf.gz Homo_sapiens_assembly38.fasta sorted_test_hg38.vcf.gz
@ 2021-04-12 19:17:50: Read the chain file:  hg19ToHg38.over.chain.gz
@ 2021-04-12 19:17:51: Filter out variants [reference_allele == alternative_allele] ...
@ 2021-04-12 19:17:51: Updating contig field ...
@ 2021-04-12 19:17:51: Lifting over ...
@ 2021-04-12 19:18:20: Total entries: 483482
@ 2021-04-12 19:18:20: Failed to map: 910

For filtering non-variant sites from single-sample GVCFs, we can use gvcftools (an oldie from Chris Saunders from Illumina, but still works at least via quay biocontainers):
$ bcftools view -H TOB1524.g.vcf.gz | wc -l
 25,072,270

$ docker container run -v $(pwd):/data/ -it quay.io/biocontainers/gvcftools:0.17.0--he941832_3
$$ gzip -dc TOB1524.g.vcf.gz | extract_variants | gzip -c > TOB1524_extract_variants.vcf.gz

$ bcftools view -H TOB1524_extract_variants.vcf.gz | wc -l
 5,078,667

Some concordance stats from three of the samples in the test bucket - I intentionally mixed up two samples to see what it looks like:

Note that I'm only looking at chr, pos, and genotype for matches. The mismatches are mostly due to e.g. 0/2 vs 0/1, 1/0 vs. 0/1 etc.


happy does not fail on deployment if TFE cannot apply changes

If a bad infra change is pushed to the repo, when running happy update (which is run by GHA in the Update step of a deployment), TFE will cause a silent failure, therefore the deployment will end up being green, even if no version is deployed. Instead, it should throw an error so that the oncall engineer can be notified and work on fixing the infra error.

this is where update is called https://github.com/chanzuckerberg/single-cell-data-portal/blob/ebe0662671935cbb787c4f89b6a36e975340a34a/.github/workflows/deploy-happy-stack.yml#L57

Here is the CLI handler https://github.com/chanzuckerberg/single-cell-data-portal/blob/ebe0662671935cbb787c4f89b6a36e975340a34a/scripts/happy#L964


UNO Wifi not supported

Hello,
the library is not working with the Arduino UNO Wifi Rev. 2.
It does not compile:
mcp2518fd_can_dfs.h:1466:14: error: expected ')' before 'volatile'
mcp2518fd_can_dfs.h:1467:14: error: expected unqualified-id before 'volatile'

Same issue on all STM32 Boards

Same issue on all STM32 Boards

were you able to interface this eventually?


Enable auto-merge from branch-23.06 to branch-23.08 [skip ci]

automerge from 23.06 to 23.08

build


⭐ 10 - Music Playlist Generator (Hacktoberfest Demo)

🤩 Thank you for participating in the CopilotKit Hacktoberfest event.
Please show your support and give a ⭐ to the CopilotKit repository.
Demo:
Music Playlist Generator
Description
Create an app that generates personalized music playlists based on mood, genre, or recent listening history

How to submit the application ?

Can I assign these to me?

Hi @aniirathod & @Saedbhati, we will officially kick Hacktoberfest off tomorrow.
I will post a link to the guidelines later today.

@NathanTarbert any updates?

@Saedbhati, please follow the link at the top to get started!

@NathanTarbert can you assign this project to me ?

@NathanTarbert please assign this to me

hey @Shubham66020 do you want to collab with me on this project ?


Add/update preview images

Description
This repository predates the updated template used in catppuccin/template so we should add preview images to the repository to be used in the README.
Acceptance Criteria

The following images are added to the assets folder:

latte.webp
frappe.webp
macchiato.webp
mocha.webp
preview.webp generated by catwalk.

The README.md is updated to showcase the preview images.

Will add this soon!


[SPARK-31476][SQL] Add an ExpressionInfo entry for EXTRACT

What changes were proposed in this pull request?

This PR intends to add an ExpressionInfo entry for EXTRACT for better documentations.
This PR comes from the comment in https://github.com/apache/spark/pull/21479#discussion_r409900080
Why are the changes needed?

To make SQL documentations complete.
Does this PR introduce any user-facing change?

Yes, this PR updates the Spark SQL, Built-in Functions page.
How was this patch tested?

Run the example tests.

Test build #121436 has started for PR 28251 at commit 933c89f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26120/
Test PASSed.

Test build #121436 has finished for PR 28251 at commit 933c89f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Extract(field: Expression, source: Expression, child: Expression)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121436/
Test FAILed.

Could you regenerate date.sql, too?
sbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException: postgreSQL/date.sql
Expected "struct<[date_part('EPOCH',] DATE '1970-01-01'):...", but got "struct<[extract('EPOCH' ```

Ah, yes. I'm updating now. Thanks for the check, anyway.

Test build #121444 has started for PR 28251 at commit 5579736.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26128/
Test PASSed.

Test build #121444 has finished for PR 28251 at commit 5579736.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121444/
Test FAILed.

retest this please

Test build #121446 has started for PR 28251 at commit 5579736.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26130/
Test PASSed.

Test build #121446 has finished for PR 28251 at commit 5579736.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121446/
Test PASSed.

cc @gatorsmile

Merged to master/3.0. Thank you, @maropu .

Thanks for the quick response, @dongjoon-hyun ! cc: @cloud-fan


Fix popover link to match the correct ID

The popover doesn't work unless the ID matches.

Thanks for reporting this. Switched to myPopover to make it more obvious that the ID is arbitrary.


Implement RedshiftDeleteClusterOperatorAsync

Acceptance Criteria:

[ ] Unit Tests coverage in the PR (90% Code Coverage -- We will need to add CodeCov separately to measure code cov) with all of them passing
[ ] Example DAG using the async Operator that can be used to run Integration tests that are parametrized via Environment variables. Example - https://github.com/apache/airflow/blob/8a03a505e1df0f9de276038c5509135ac569a667/airflow/providers/google/cloud/example_dags/example_bigquery_to_gcs.py#L33-L35
[ ] Add proper docstrings for each of the methods and functions including Example DAG on how it should be used (populate
[ ] Exception Handling in case of errors
[ ] Improve the OSS Docs to make sure it covers the following:

[ ] Has an example DAG for the sync version
[ ] How to add a connection via Environment Variable & explain each of the fields. Example - https://airflow.apache.org/docs/apache-airflow-providers-postgres/stable/connections/postgres.html
[ ] How to use Guide for the Operator - example: https://airflow.apache.org/docs/apache-airflow-providers-postgres/stable/operators/postgres_operator_howto_guide.html

OSS PR: https://github.com/apache/airflow/pull/23563

I have implemented the example DAG with required operator, trigger and hook changes but the DAG fails as the sync version of the operator has a missing assignment for aws_conn_id .

PR is ready with tests passing and code coverage is to an acceptable level. Addressing the review comments now.


Add support for annotations on loadbalancer service

Expected Behaviour

Unable to apply custom annotations to specifically the nginx loadBalancer service.
Current Behaviour

Because of how certain load balancers handle annotations, they must be present at resource creation time, otherwise they'll stay in a failed state.
Possible Solution

Expose annotations for the service in values.yml and apply if defined.  Suggested change to type: service definition in stack/templates/nginx.yaml (completely untested):
apiVersion: v1
kind: Service
metadata:
  labels:
    app: {{ .Values.stack.name }}
  name: {{ .Values.stack.name }}
  namespace: {{ .Release.Namespace | quote }}
  annotations:
+ {{- with .Values.stack.service.annotations }}
+ {{- toYaml . | nindent 4 }}
+ {{- end }}

(with supporting additions to chart values.yml as well)
Context

Some k8s load balancers (like metallb) allow sharing of IP addresses between services.  This is beneficial when you're trying to reduce the IP space requirements for a capability that may consist of multiple helm charts (with their own incumbent loadBalancer services.
Your Environment

K3s with KlipperLB disabled and MetalLB deployed.
Discussion welcome!

Hey @mddeff, this is resolved in #136. If there are any concerns or issues with that PR, please reopen this ticket. Thanks!

Awesome, thanks @jacobweinstock !


GraphQL implementation

Minimal implementation of the graphQL implementation currently used in our projects.

@awilderink the queries are not yet in the Relay format. At the moment of writing the fakeQL service seems to be down.
Maybe you can transform them to the relay versions (once the fakeQL service is back up) ?

Also it might be good to have a fragment as an example as well.

[ ] Add event fragment
[ ] Use event fragment in query and mutation

FakeQL service seems to up again :)
P.S if you want to try and see what kind of typescript can be automatically generated, just comment out the "documents" line in the codegen.yml. That output will just have types of a lot of things but not actual usuable queries (pre-build).
So I guess that's also a benefit we would have by adding them ourselves (fragments, queries and mutations).

Maybe we can also have a dummy graphql endpoint that we could use. The fakeql service has been on and off down over the last days and when it's down the build will fail because codegen can't connect.

As we don't want any external dependencies. We're opting for a local graphQL schema.
If you install the following module globally (get-graphql-schema), you'll be able to do the following:
get-graphql-schema https://fakeql.com/graphql/1e23b8089df1e104998c9ca3cd46d5b5 > schema.graphql
This will generate a local schema file which will then be used instead of the URL provided in the secrets.
I think this means we would also need to add the command to the build pipelines as well (as you don't want to commit your whole schema to git).
LMK what you guys think.

As we don't want any external dependencies. We're opting for a local graphQL schema.
If you install the following module globally (get-graphql-schema), you'll be able to do the following:
get-graphql-schema https://fakeql.com/graphql/1e23b8089df1e104998c9ca3cd46d5b5 > schema.graphql
This will generate a local schema file which will then be used instead of the URL provided in the secrets.
I think this means we would also need to add the command to the build pipelines as well (as you don't want to commit your whole schema to git).
LMK what you guys think.


Allow shutting down the server if the EULA is not accepted

Currently, the dedicated servers ends up looping forever in finalTick if the EULA was not accepted. While this has always been vanilla behavior, it's generally undesireable, since there's no point leaving the server running in a half-initialized state.
This PR adds a new config section and option to control whether the server automatically shuts down when the EULA is not accepted (which defaults to true). The only change that needs to be made in SpongeForge and SpongeVanilla is to enable the mixin config.
Note: Forge logs a message about an unexpected transition to the state SERVER_STOPPED when this change is enabled. This is correct - this change is functionally equivalent to manually stopping or killing server when the EULA is not accepted, which actually does prevent some initialization from running.

I don't think this needs to be it's own mixin module and have a config option IMO

@simon816: The main reason I did this is because it breaks Vanilla behavior. This has always been the behavior of Vanilla since the EULA requirement was added, and I'm loath to change it without an option to disable it

Actually, why not allow the user to accept the EULA without stopping and restarting the server? Something like Please read the EULA shown at https://account.mojang.com/documents/minecraft_eula. If you accept, type "I agree". Otherwise, type "stop".

@JBYoshi: It would be much nicer, but I'm extremely hesitant to include something like that in Sponge because of legal issues. I want to avoid us interfering in any way with the actual accepting of the EULA, as Mojang has defined it.

@Aaron1011 Sounds good.

I just ran into another situation when the server would hang - when it fails to bind the port. Perhaps this could be expanded for more general hanging cases?

@simon816: I considered that. I was thinking that those should probably be handled on a case-by-case basis.

We can close this now, can't we? https://github.com/SpongePowered/SpongeCommon/commit/2a3058de999a11605215167d97daf439fa762b14
We'll need to revert this again for 1.8.8 because that seems to be part of Vanilla behaviour now.

@Minecrell: Right - I just added this for now, since it was annoying me :P


[Bundle size] Increase in size due to react-toaster

Hi @AllenFang
Recently I've been observing the production bundle of my app using webpack-bundle-analyzer.
I imported the css which didn't use react-toastr still I'm seeing react-toastr occupying quite a size of the bundle. Is there a way to skip importing react-toastr?
Including screenshots for your reference:

zoomed-out view

zoomed-in view to react-toastr

Thanks! :+1:

@prajapati-parth nice question, this is known issue lol
Check https://github.com/AllenFang/react-bootstrap-table/pull/1216#issuecomment-296675731
Anyway, for now, it's impossible to remove those dependencies, in v3.x we use react-toastr, in v4.x we use react-s-alert. Like I mention above, I should avoid to use those library directly in this repo, if it really necessary, we should use it like a plugin or HOC or let developer to control the third-party library.
I'm planing the react-bootstrap-table2 for the refactoring the table structure and code base, but currently it is still in the plan and really need some time.
it's very sorry that we can fix this issue in near future.

I'm sure @AllenFang v4.x would be great! One more thing here.
I was using this library react-burger-menu that had external dependency on some svg thing that was occupying considerable size in my bundle and I just followed this to reduce the size by 83KB.
Basically if I would have done something like this
import { push as Menu } from 'react-burger-menu'

all the default dependencies would have pulled in.
So I followed the above mentioned comment and got size reduced quite much. Would something like that be possible in my imports of react-bootstrap-table?
Thanks!

@prajapati-parth thanks your sharing, I think we can't do it like that

@AllenFang All right.
Thanks for considering it as enhancement.

I will, but like I mention, I wont fix in react-bootstrap-table. In my plan, if react-bootstrap-table2 is available for me, I will do this enhancement in 2. Because reduce the bundle size in this package is  too hard sometime.  Thanks 👍


feat: added ability to define additional api permissions for service principals

Jira link (if applicable)
https://tools.hmcts.net/jira/browse/DTSPO-16190
Change description
Added Purview API permissions to SHAREDSERVICES-DEV SP.
Checklist

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)
[x] Does this PR introduce a breaking change

Plan Result (sandbox_enterprise)
No changes. Your infrastructure matches the configuration.

Please request approval for a new subscription by emailing DTS Platform Operations.
Reply to this comment with the approval from the 'Head of Platform Operations' (Linda Green).
Platform Operations, replace the label requires-approval-from-head-of-platform-operations with subscription-request-approved after approval received.

No new subscription is being created - so approval from Linda is not required.

Plan Result (prod_video_hearings)
No changes. Your infrastructure matches the configuration.

Plan Result (prod_enterprise)
No changes. Your infrastructure matches the configuration.


RDF data file reading functionality

file reading functionality partially implemented

Please resend your changes as a new PR. This PR cannot be merged.


Add known issue with Kuryr Neutron ports

Kuryr creates unnecessary Neutron Ports for hostNetworking pods and we
won't fix it before GA. This is adding info about the issue.

Thanks for the suggestions!

Thanks!


Jupyter Notebook cells don’t execute properly

OS/Web Information

Web Browser: Brave
Local OS: macOS
Remote OS: docker on macoS
Remote Architecture: amd64
code-server --version: 3.9.3

Steps to Reproduce

Click a .ipynb file

Expected
Jupyter Notebook should open, connect to a Kernel and cells should be ready to run
Actual
Even after a series of installations of plugins (that seem to work fine) the Notebook can connect to a kernel but no output is being received (all i see is "Loading...", then after some time I get the error shown in the screenshot "ChunkLoadError")
Screenshot

Notes
This issue can be reproduced in VS Code: No idea.

I tried again, still no dice.
This time I tried to installed (Mini-)conda environment into docker before getting and starting code server.
1.) I click the .ipynb file, Code Server asks me if I want to search the Marketplace for support for ipnb files, I agree and install Jupyter v2021.3.0
2.) I click the .ipynb file again and Code Server installs an ipython kernel
3.) I can select the kernel and get no error message when I connect to it
4.) I try to run a "print('Hello, world!')" cell and get the error message posted previously.

Is that the only error you see in the browser console logs?

This error is seen in the editor, i didn’t look at the browsers console log

Oops my bad. Please post the browser console logs! The code-server logs may also be helpful although in this case probably not.

I was trying to provide the console logs when the bug just went away. I don't know why but it's not an issue any more. I'm closing this, sorry for the fuzz.

Ok; i was able to reproduce this here's the log:
localhost/:1 [Deprecation] ::-webkit-details-marker pseudo element selector is deprecated. Please use ::marker instead. See https://chromestatus.com/feature/6730096436051968 for more details.
register.ts:14 [Service Worker] registered
webWorkerExtensionHost.ts:125 The web worker extension host is started without an iframe sandbox!
start @ webWorkerExtensionHost.ts:125
abstractExtensionService.ts:846 Extension 'ms-python.python' uses PROPOSED API which is subject to change and removal without notice.
updateEnableProposedApi @ abstractExtensionService.ts:846
abstractExtensionService.ts:846 Extension 'ms-toolsai.jupyter' uses PROPOSED API which is subject to change and removal without notice.
updateEnableProposedApi @ abstractExtensionService.ts:846
console.ts:137 [Extension Host] (node:465) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
m @ console.ts:137
2notificationsAlerts.ts:40 Failed to find a kernelspec to use for ipykernel launch
onDidChangeNotification @ notificationsAlerts.ts:40
console.ts:137 [Extension Host] rejected promise not handled within 1 second: Error: Failed to find a kernelspec to use for ipykernel launch
m @ console.ts:137
console.ts:137 [Extension Host] stack trace: Error: Failed to find a kernelspec to use for ipykernel launch	at w.createNotebookInstance (/root/.local/share/code-server/extensions/ms-toolsai.jupyter-2021.3.0/out/client/extension.js:49:823711)
m @ console.ts:137
mainThreadExtensionService.ts:59 [[object Object]]Failed to find a kernelspec to use for ipykernel launch
$onExtensionRuntimeError @ mainThreadExtensionService.ts:59
mainThreadExtensionService.ts:60 Error: Failed to find a kernelspec to use for ipykernel launch
at w.createNotebookInstance (:8080/root/.local/share/code-server/extensions/ms-toolsai.jupyter-2021.3.0/out/client/extension.js:49)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:60
console.ts:137 [Extension Host] rejected promise not handled within 1 second: Error: Failed to find a kernelspec to use for ipykernel launch
m @ console.ts:137
console.ts:137 [Extension Host] stack trace: Error: Failed to find a kernelspec to use for ipykernel launch	at w.createNotebookInstance (/root/.local/share/code-server/extensions/ms-toolsai.jupyter-2021.3.0/out/client/extension.js:49:823711)
m @ console.ts:137
mainThreadExtensionService.ts:59 [[object Object]]Failed to find a kernelspec to use for ipykernel launch
$onExtensionRuntimeError @ mainThreadExtensionService.ts:59
mainThreadExtensionService.ts:60 Error: Failed to find a kernelspec to use for ipykernel launch
at w.createNotebookInstance (:8080/root/.local/share/code-server/extensions/ms-toolsai.jupyter-2021.3.0/out/client/extension.js:49)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:60
DevTools failed to load SourceMap: Could not load content for http://localhost:8080/static/fe2dc2deb08e378069891b622bb62ad1d261d1b1/root/.local/lib/code-server-3.9.3/dist/pages/pages/vscode.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
DevTools failed to load SourceMap: Could not load content for http://localhost:8080/webview/vscode-resource/file/root/.local/share/code-server/extensions/ms-toolsai.jupyter-2021.3.0/out/datascience-ui/notebook/monaco.bundle.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
DevTools failed to load SourceMap: Could not load content for http://localhost:8080/webview/vscode-resource/file/root/.local/share/code-server/extensions/ms-toolsai.jupyter-2021.3.0/out/datascience-ui/notebook/commons.initial.bundle.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
DevTools failed to load SourceMap: Could not load content for http://localhost:8080/webview/vscode-resource/file/root/.local/share/code-server/extensions/ms-toolsai.jupyter-2021.3.0/out/datascience-ui/notebook/nativeEditor.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
console.ts:137 [Extension Host] Starting WebSocket: RAW/api/kernels/e06c821e-a79a-4868-a85f-c69a4adf19d6
console.ts:137 [Extension Host] Kernel: connected (e06c821e-a79a-4868-a85f-c69a4adf19d6)
commons.initial.bundle.js:2 Starting WebSocket: BOGUS_PVSC/api/kernels/e06c821e-a79a-4868-a85f-c69a4adf19d6
commons.initial.bundle.js:2 Kernel: connected (e06c821e-a79a-4868-a85f-c69a4adf19d6)
console.ts:137 [Extension Host] Starting WebSocket: RAW/api/kernels/566d6b79-95f1-4d30-9b8f-187695f0b08f
console.ts:137 [Extension Host] Kernel: connected (566d6b79-95f1-4d30-9b8f-187695f0b08f)
monaco.bundle.js:1 Could not create web worker(s). Falling back to loading web worker code in main thread, which might cause UI freezes.  Code Server asks me to install the Jupyter extension, then Python, then it installs ipython Kernel; unfortunately the ChunkLoadError comes up every time now again.

I tried to replicate but I ran into issues with the extension activating at all; I'm getting the error mentioned here: https://github.com/cdr/code-server/issues/2929
I'd be interested in seeing if downloading and installing the extension from OpenVSX works for you: https://open-vsx.org/extension/ms-python/python

With https://open-vsx.org/api/ms-python/python/2020.10.332292344/file/ms-python.python-2020.10.332292344.vsix installed (and de-selecting Extensions: Automatic Updates first) it was kinda worse - I wasn't even able to connect to the ipython Kernel. Even though at one point Code Server has installed ipython.

I gave it a try and I'm seeing the same thing (or something similar). It says Not connected. If I click it to connect it fails with:
Error: Jupyter cannot be started. Error attempting to locate jupyter: Data Science libraries jupyter and notebook are not installed in interpreter Python 2.7.17 64-bit

If I switch to Python 3 using the button in the status bar I get this instead:
Error: Jupyter cannot be started. Error attempting to locate jupyter:

Jupyter is in my path so I'm not sure why.
So then I opened the command pallete and switched the interpreter there instead and for some reason that worked. (Credit here: https://stackoverflow.com/questions/60330837/jupyter-server-not-started-no-kernel-in-vs-code)
I don't know if any of that applies to your situation but maybe it'll be helpful.

When I shift-reload code server i see "Connecting to Python 3", then the icon goes green and I'm connected (idle). But a cell containing "print('Hello, world!')" just yields "Loading...", then, later, the error I posted above (ChunkLoadError: Loading chunk vendors~dataresource~geojson~modeldebug~nteract_transf...). So for me connecting (supposedly) works, execution doesn't.
@code-asher Thank you very much for your help, though! I think it helped clarify this issue :-)

Ah that's unfortunate. This won't be helpful but running cells is working for me (similar code, just a simple print).
I don't think we've seen the browser logs yet with the OpenVSX version so posting those might lead to a clue.

I'll give the Dockerfile a run when I get a chance.

With OpenVSX I wasn't able to connect to the kernel - and I tried again now via Command Palette: The Command is available but no Kernels are being presented. It's very weird because console log says "Kernel: connected (099ad007-dbfd-48c6-ab30-003320fe07a9)" but the icons don't change, it keeps saying "Python3: Not Started". Note: I had two packages installed: Python (OpenVSX) and Jupyter (from Marketplace).

Oh maybe that's it! I actually forgot to mention I had a similar problem. I tried to uninstall the Python and Jupyter extensions and then install the OpenVSX Jupyter extension (it contains both Python and Jupyter from before they were split) but I ended up having to wipe the extensions in ~/.local/share/extensions and then install the OpenVSX one again.
VS Code doesn't actually remove extensions from disk when uninstalling so I think it causes weird issues when adding a different version of the extension manually.

I was using docker and actually deleted the images and containers frequently for a fresh start; the ~/.local/share/code-server/extensions/ are not in my /app dir so I think that can't be it...
Thank you very much for your help, it's very appreciated!

Oh, and I can't find a dedicated "Jupyter" Extension on OpenVSX!

Ah right that makes sense.
The Python extension on OpenVSX includes both Python and Jupyter.
It was split into two extensions but OpenVSX still has the version from before the split.

I gave your Dockerfile a run and everything worked! My exact steps:

Save Dockerfile as test.Dockerfile
docker build -t code-server . -f test.Dockerfile
docker run -e PASSWORD=test -p 8080:8080 code-server
Browse to localhost:8080 and log in
Open terminal
Run wget https://open-vsx.org/api/ms-python/python/2020.10.332292344/file/ms-python.python-2020.10.332292344.vsix
Extensions > Install from VSIX > Select downloaded VSIX
Refresh the page
Open command palette
Select  Create New Blank Jupyter Notebook
Add print("hello") to the cell
Click run

This is so weird, I was trying
docker build -t jupyter .
docker run -v $(pwd):/app -p 8080:8080 -it -d jupyter
docker exec -it <dontainer_id> cat /root/.config/code-server/config.yaml (to see the generated password)
Then follow 4, 5, 6, 7, 8, 9, 10, 11 and 12
And all I got is "Loading..." and then the ChunkLoadError. That was quite unexpected because we were using the same Dockerfile. My Docker host is macOS Big Sur 11.3; But my Broser is Brave - so i tried Safari and: The cell executed!

I turned off "Shields" for localhost:8080 but the cells are still not executing in Brave (still working fine in Safari). This whole thing is a browser issue!

After deleting all user data related to Brave and re-installing it cell execution works again like it should!

Thanks, @code-asher your help solved my issue!

Very interesting! I'm glad we got it sorted! :smile:

For completeness: after resetting Brave this issue is gone even when I use the Marketplace Extensions Jupyter v2021.3.0 and Python v2021.4.765268190 which are being installed as defaults (code server 3.9.3)!


[move-prover] Bug fix for field order

Motivation
Fixed bug so that fields are returned in the order in which they appear in bytecode.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Existing tests
Related PRs
None.

@bors-libra r=wrwg

:pushpin: Commit 831dffa has been approved by wrwg

:hourglass: Testing commit 831dffa5f125a0d62696aa6f2998342a525a42a5 with merge b93a9ef3ceea7e95e5970445f6a5d70116d7210e...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: wrwg
Pushing b93a9ef3ceea7e95e5970445f6a5d70116d7210e to master...


Page Transition on Android looks like modal transition.

Bug Report
Describe the Bug
The page transition on Android looks weird. Should be left to right and right to left for back and forth.
Steps to Reproduce
Steps to reproduce the behavior:

Go to https://beta.ionicframework.com/docs/api/nav/
Click on Material Design for the preview
Change pages and see it looks like a modal

Expected Behavior
IMO it should look more like the iOS Transition, the Android transition does not feel right at all. Should look like this https://material.io/design/navigation/navigation-transitions.html#peer-transitions.

They are hierarchical transitions:
https://material.io/design/navigation/navigation-transitions.html#hierarchical-transitions


Make formatters configurable

Only use subprocesses for formatting, and allow configuration of the formatter's command line for each supported data format.
This allows for better integration in existing pipelines with standard and I dare say, more common/popular formatters.

Only use subprocesses for formatting

I'd like to always avoid subprocessing if possible. It's slow, and requires dependencies that often can't be expressed in package metadata.
I'm not sure I want to add configurability to code formatter plugins I maintain. Should be fairly simple to create a fork if it's something you need.


[red-knot] Add a diagnostic for raise statements used with non-exceptions

Red-knot currently doesn't emit a diagnostic on this snippet:
raise 42

But we should, since 42 is not a valid object to be used in a raise statement:
>>> raise 42
Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    raise 42
TypeError: exceptions must derive from BaseException

The rule is that the object used in a raise statement must have a type that is assignable to the type BaseException | type[BaseException], since both of the following work:
>>> raise ValueError
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    raise ValueError
ValueError
>>> raise ValueError()
Traceback (most recent call last):
  File "<python-input-2>", line 1, in <module>
    raise ValueError()
ValueError

We need to add some extra logic to this branch here: https://github.com/astral-sh/ruff/blob/c9fdb1f5e3a4d0d60b4537741f2c9c19e2426038/crates/red_knot_python_semantic/src/types/infer.rs#L2193-L2201
I think this will probably need to be a new rule added to https://github.com/astral-sh/ruff/blob/main/crates/red_knot_python_semantic/src/types/diagnostic.rs ? I don't think it fits neatly into any other rule. The alternative might be to make the existing INVALID_EXCEPTION_CAUGHT rule broader (and rename it).

The alternative might be to make the existing INVALID_EXCEPTION_CAUGHT rule broader (and rename it).

That was also my first reaction. It's kind of the same problem.

The alternative might be to make the existing INVALID_EXCEPTION_CAUGHT rule broader (and rename it).

That was also my first reaction. It's kind of the same problem.

The same genre of problem, for sure. Though there's a subtle difference between the rules for raising exceptions and the rules for catching exceptions:

If you're raising an exception, the type must be assignable to BaseException | type[BaseException]
but if you're catching an exception the type must be assignable to type[BaseException] | tuple[type[BaseException], ...]

If we bundle them together into one rule, it'll be harder to explain the problem in the rule's documentation

I don't have a strong opinion, though. Any suggestions for what we might call the rule if we combined the two into one one rule?


Fixed typo in documentation form validation section

radii is correct, but a bit pretentious. I'd be ok with this PR


Problem with upgrading to v1.16.1(4)

I had a prolem with upgrading to 1.16.1(2) version:
{"level":"info","ts":"2023-11-02T13:30:39Z","msg":"credentials loaded","accessKeyLength":0,"accountLength":36}
{"level":"info","ts":"2023-11-02T13:30:39Z","msg":"keepLocal config is true, statuses and scan reports won't be sent to Armo cloud"}
{"level":"info","ts":"2023-11-02T13:30:39Z","msg":"starting server"}
{"level":"info","ts":"2023-11-02T13:30:40Z","msg":"updating grype DB","listingURL":"https://toolbox-data.anchore.io/grype/databases/listing.json"}
{"level":"error","ts":"2023-11-02T13:31:40Z","msg":"failed to update grype DB","error":"vulnerability database is invalid (run db update to correct): database metadata not found: /home/nonroot/.cache/grype/db/5"}
{"level":"info","ts":"2023-11-02T13:31:40Z","msg":"restarting to release previous grype DB"}

kubevuln can't start correctly. I tried to delete and install with zero, but it doesn't help me.

@batazor An issue occurred during the DB upgrade, and from what I recall, the update disrupted the existing database. I suggest uninstalling and then reinstalling the kubescape-operator.

@dwertent This problem is reproduced even when running on a new kubernetes cluster. Restarting kubevuln/storage pods does not solve the problem.
For context: I use ArgoCD for deployment and k8s v1.28.4

@batazor Are you running the latest chart version (1.16.5)?

@dwertent Yes, I am using the latest version. Could the problem be related to the fact that kubescape updates any configs that ArgoCD updates to the original version (as one theory)?

I disabled networkPolicy, and it fixed the problem with running kubescape
global:
  networkPolicy:
    enabled: false
    createEgressRules: false


how to persist user and have updated access_token until the user is using client app?

First, I have tried to implement silentSignin like described on many posts I get error refused to display ''x-frame-options" are set to "sameorigin"
However, I also saw somewhere in the posts @brockallen said it is not supported by many browsers
Secondly, I saw this https://damienbod.com/2017/06/02/implementing-a-silent-token-renew-in-angular-for-the-openid-connect-implicit-flow/
blog post but in this post it seems the author is not using the methods in oidc-client.js
So, I want to persist a user until s/he is using my app. Without asking s/he to put his/her credentials again.
Any help would be highly appreciable

Hi. You have implemented signing in action yet and need an only silent refresh mechanism?

First, I have tried to implement silentSignin like described on many posts I get error refused to display ''x-frame-options" are set to "sameorigin"

signin silent should never run into CSP issues because if it's successful then it will never be rendering html. It should also never be rendering a login page because prompt=none should be part of the silent request. If it does need to render html, then it's an error page, so I suspect you have some error somewhere (possibly config).

I am making an angular4 client using oidc-client.js
@timaxapa Yes I am able to successfully login, Now I just have to persist the session untill user is using my app
@brockallen
my config
const config: any = {   authority: 'http://localhost:5000',   client_id: '1',   redirect_uri: 'http://localhost:4200/callback',   silent_redirect_uri: 'http://localhost:4200/silent-callback',   automaticSilentRenew: true,   response_type: 'id_token token',   scope: 'openid profile mad-resource',   post_logout_redirect_uri: 'http://localhost:4200', };
http://localhost:4200/silent-callback
` export class SilentCallbackComponent implements OnInit {
constructor(private _oidc: OidcService, private router: Router) {
}
ngOnInit() {
this._oidc.mgr.signinSilentCallback();
}
}`
event at main page
    _oidc.mgr.events.addSilentRenewError((error) => {       alert(error);     });
Result when token is expiring

@leo9223
Your endpoints
http://localhost:4200/callback
http://localhost:4200/silent-callback

has to be added to SSO server config as an acceptable redirect urls. Do you have an access to SSO server configuration?

@timaxapa
Ah! you are right.
I was not setting the http://localhost:4200/silent-callback in my auth server. After setting the redirect uri its working awesomely fine. Thank you so much :)


Remove PHP8 deprecation notices

And also:

Bump minimum PHP to 7.2
Bump PHPUnit to 8.5
Remove unneeded Travis dependencies (although this should be probably moved to Github Actions)

fixes #124

PS: I assumed handlers with PHP8 Union Types should not be registered. Let me know if you think otherwise @rosstuck , thx!!

PS: I assumed handlers with PHP8 Union Types should not be registered. Let me know if you think otherwise @rosstuck , thx!!

Agreed on the union types, I feel like any handler that's receiving more than one command is probably doing something fishy, so let's not add to that.
Otherwise, thanks a ton for picking this up! I like the PR and it seems like you're transitioning everything nicely. The only thing I'd tweak is making this 1.3 since it drops earlier PHP version support.
Seems like just a few failing tests still and then I'm happy to merge and tag. Thanks once again! :heart:

Agreed on the union types, I feel like any handler that's receiving more than one command is probably doing something fishy, so let's not add to that.
Otherwise, thanks a ton for picking this up! I like the PR and it seems like you're transitioning everything nicely. The only thing I'd tweak is making this 1.3 since it drops earlier PHP version support.
Seems like just a few failing tests still and then I'm happy to merge and tag. Thanks once again! :heart:

Yes, dealing with multiple symfony and phpunit versions can be a bit of a PITA. Plus Travis seems to take hours these days. Everything should be ready now :D

Yes, dealing with multiple symfony and phpunit versions can be a bit of a PITA. Plus Travis seems to take hours these days. Everything should be ready now :D

This is just a genuinely lovely PR, thank you so much for picking this up and handling it so well. Much :heart:, I really appreciate it. :smile:

This is just a genuinely lovely PR, thank you so much for picking this up and handling it so well. Much :heart:, I really appreciate it. :smile:

Thanks @rosstuck, my pleasure!


Can't download encrypted files.

When I run it in development server with the runserver command, it works perfectly fine. But when I'm trying to run it in uwsgi it doesn't, and throws the following error
" Alert! C:\Users\username\AppData\Local\Temp\YorOkjRs.docx.part could not be saved, because the source file could not be read.
Try again later, or contact the server administrator."

What is throwing that error? Your browser, uwsgi, or the python app?
My suspicion is that uwsgi is configured to serve encrypted static or media files instead of passing it off the Django app. The request for any encrypted file has to hit the Django app in order to decrypt it first.

Hello eblocha, I am one of Asimina's colleagues, the error is thrown by the browser (can not read the file or can not parse response). We are using Django-rest-framework and we have an API endpoint that returns the file as a response, in that view other processes are being run that work (save the user that downloaded the file) so we know that the view is called and that uwsgi is not serving the media files. Is there another reason that this could happen, maybe something is not compatible with the default uwsgi configuration?
Thank you in advance, and thank you for this great module!

We managed to solve the issue by adding the bellow option in the uwsgi file, can you explain why this is needed, regular files work fine for us through uwsgi.
wsgi-disable-file-wrapper = true

Hi ABakirtzis, it looks like uWSGI uses the unix sendfile in its file_wrapper:
https://github.com/unbit/uwsgi/issues/1126#issuecomment-166687767
Sendfile is a kernel-level operation, so I believe the EncryptedFile class is completely skipped when reading the data, and it just sends the encrypted data from the file on disk.
So it appears that the only current solution is to disable the file_wrapper, unfortunately. There are some experimental kernel modules to use sendfile with AES encryption (https://github.com/kbeckmann/sendfile_aes), but they are not production-quality, or supported by uWSGI.
If you really need this optimization for regular files, you might look into hosting encrypted files on a separate application.

Hi ABakirtzis, it looks like uWSGI uses the unix sendfile in its file_wrapper:
https://github.com/unbit/uwsgi/issues/1126#issuecomment-166687767
Sendfile is a kernel-level operation, so I believe the EncryptedFile class is completely skipped when reading the data, and it just sends the encrypted data from the file on disk.
So it appears that the only current solution is to disable the file_wrapper, unfortunately. There are some experimental kernel modules to use sendfile with AES encryption (https://github.com/kbeckmann/sendfile_aes), but they are not production-quality, or supported by uWSGI.
If you really need this optimization for regular files, you might look into hosting encrypted files on a separate application.


Add Github Actions workflow with tests on Linux and Windows

This PR adds a Github Actions workflow that runs cargo test on Ubuntu and Windows.

Sweet. Thanks!


Recent list of news posts on single news page displaying old dates

Issue
Reported by: Rich OPG.
On the single news page, the recent news column is showing the wrong dates. Investigate news api.

This bug dealt with sort order affecting only the single news template and the order of news listed at the side of the page. Does not appear to be related to code changes but likely related to plugin or WP upgrades. It has been fixed now.


Cannot switch python interpreter when remote server

Does this issue occur when all extensions are disabled?: No.It's an extension bug.

Version: 1.62.3 (user setup)
Commit: ccbaa2d27e38e5afa3e5c21c1c7bef4657064247
Date: 2021-11-17T08:11:14.551Z
Electron: 13.5.2
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000 PC and Ubuntu20.04LTS server
Steps to Reproduce:
https://user-images.githubusercontent.com/38597848/143268935-395388cc-432b-4cce-b67d-66700d1c60d7.mp4

remote server and add two folder to workspace
I install python-extensions in the ubuntu server and then create a miniconda virtual-env.Then I want to change the python interpreter.When I add just one folder to the workspace,all runs well;but When I add two folders to the workspace,THE INTERPRETER CAN NOT be SWITCHed.


Will not move sub-components

I was able to get this working with html elements(div, li, etc) however if I tried to animate a sub-component  (  )it would not work. Is this a known limitation?

Hi, I was able to animate sub-components by adding a div inside the Magic Move tag, before the sub-component tag, instead of loading the sub-component directly. Hope it helps.


Add common psqlODBC tests file

Description
Add common psqlODBC tests file and sys.datetime & sys.bigint tests using common test functions in this file.
Issues Resolved
BABELFISH-584
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Already merged to upstream.


[BUG] Placing Rancher crashed the client

Description:
Placed an Industrial Revolutions Rancher into the world, and the client crashed.  The server kept running as if there was no problem.
Steps to Reproduce:
Place rancher MK1 in the world.
Technical Information:

Minecraft:   1.18.1
Fabric API:   Don't know.  Mod was not in the list.  Not present?
Industrial Revolution:   v1.13.4-BETA
Modpack:   All of Fabric 5

Logs:
https://pastebin.com/uNXPza4h
Details:
No screenshot to show.  I edited the world using Amulet, and deleted the rancher.  That allowed me back in, but the rancher was still in my character's hand.  I tried to place the rancher and the same thing happened again.  Client crashed,  Server still running.  Went back in with Amulet, and the block was not there.  But, I guess the server didn't save the placement, because I was able to get back in immediately, and the rancher was still in my character's hand.

Thanks for reporting, but this has already been fixed in later versions. Update the mod.


Revert Subset of Remove Deprecated Interfaces

Find and Position are meant to be kept indefinitely to guide them to the right thing.

Rustup nightly seems broken. It failed on update for me locally as well so I don't believe that this one is on me.

Thanks, I'm going to assume this PR is not at fault.


NEVISACCESSAPP-5853: Updated Android configuration to use Gradle 8.4.0 and above and AGP 8.3.0 and above

🔧 Can you please update the README as well?

Fixed.


Update the 'vendorUrl'

Just found the vendorUrl is changed.

Thanks for the fix. A CLA should not be needed for this small fix.


Quarantine Action Event List

https://docs.microsoft.com/en-us/microsoft-365/compliance/search-the-audit-log-in-security-and-compliance?view=o365-worldwide#quarantine-activities
This section does not include some Audited events like "QuarantineRequestReleaseMessage", which trigger when a request is sent. Could this section be updated with the most up-to-date events that quarantine actions trigger?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3494b782-92ad-e365-3398-bd2d760d10c6
Version Independent ID: fa4bca98-3975-23dd-dfac-f23049c71d01
Content: Search the audit log in the Microsoft Purview compliance portal - Microsoft Purview (compliance)
Content Source: microsoft-365/compliance/search-the-audit-log-in-security-and-compliance.md
Service: o365-seccomp
GitHub Login: @v-tophillips
Microsoft Alias: v-tophillips

@v-tophillips Please help us in resolving this issue. Thanks

This amount of work will have to be planned and scheduled. This is not something I can do immediately, but will add to my queue.


Bigtable: improve list tables spooler

Avoid blocking the event loop. Previously the first page would be fetched
asynchronously, but all of the other pages would be fetched synchronously
which would block the grpc event loop. The new implementation uses future
chaining.

@kevinsi4508, cna you take a look when you have a chance?

@pongad this should be ready for you


chunks: fix potential "index out of range" error

When binary.Uvarint() fails, the returned number of bytes is less than or equal to zero. I'm not sure how it can happen except with corrupted data but an "index out of range" panic has been reported in https://github.com/prometheus/prometheus/issues/4128.

well done, thanks Simon.
LGTM

Can you add a unittest for this?

@brian-brazil unit tests added.

:+1:

@gouthamve PTAL.