invalid byte sequence in US-ASCII (ArgumentError)

I'm running a lane that works fine on my development machine, but fails on our Jenkins machine. The Jenkins machine has the latest XCode (6.3.1) with ruby setup via rbenv. bundle install was run before running fastlane and fastlane was run using bundle exec fastlane dev.
The error I'm getting is:
[37mINFO [2015-04-24 10:19:41.60]: -----------------
INFO [2015-04-24 10:19:41.60]: --- Step: ipa ---
INFO [2015-04-24 10:19:41.60]: -----------------
DEBUG [2015-04-24 10:19:41.60]: set -o pipefail && ipa build -w "<snip>.xcworkspace" -s "<snip>" -d "./build" -m "/Users/ribot/.jenkins/jobs/<snip>-ios-nightly/workspace/build/profile.mobileprovision" --verbose | xcpretty
INFO [2015-04-24 10:19:41.60]: [SHELL COMMAND]: set -o pipefail && ipa build -w "<snip>.xcworkspace" -s "<snip>" -d "./build" -m "/Users/ribot/.jenkins/jobs/<snip>-ios-nightly/workspace/build/profile.mobileprovision" --verbose | xcpretty
/Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/actions/actions_helper.rb:68:in `strip': invalid byte sequence in US-ASCII (ArgumentError)
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/actions/actions_helper.rb:68:in `block (2 levels) in sh_no_action'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/actions/actions_helper.rb:67:in `each'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/actions/actions_helper.rb:67:in `block in sh_no_action'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/actions/actions_helper.rb:66:in `popen'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/actions/actions_helper.rb:66:in `sh_no_action'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/actions/actions_helper.rb:56:in `sh'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/actions/ipa.rb:64:in `run'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/fast_file.rb:112:in `block (2 levels) in method_missing'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/fast_file.rb:94:in `block in method_missing'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/fast_file.rb:93:in `chdir'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/fast_file.rb:93:in `method_missing'
    from (eval):20:in `block (3 levels) in parse'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/runner.rb:34:in `call'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/runner.rb:34:in `block in execute'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/runner.rb:24:in `chdir'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/runner.rb:24:in `execute'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/lib/fastlane/lane_manager.rb:33:in `cruise_lane'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/bin/fastlane:39:in `block (2 levels) in run'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/commander-4.3.3/lib/commander/command.rb:178:in `call'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/commander-4.3.3/lib/commander/command.rb:178:in `call'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/commander-4.3.3/lib/commander/command.rb:153:in `run'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/commander-4.3.3/lib/commander/runner.rb:428:in `run_active_command'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/commander-4.3.3/lib/commander/runner.rb:68:in `run!'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/commander-4.3.3/lib/commander/delegates.rb:15:in `run!'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/bin/fastlane:118:in `run'
    from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/fastlane-0.12.4/bin/fastlane:124:in `<top (required)>'
    from /Users/ribot/.rbenv/versions/2.1.2/bin/fastlane:23:in `load'
    from /Users/ribot/.rbenv/versions/2.1.2/bin/fastlane:23:in `<main>'
INFO [2015-04-24 10:19:46.82]: [SHELL OUTPUT]: 2015-04-24 10:19:46.824 xcodebuild[5102:18549] [MT] iPhoneSimulator: SimVerifier returned: Error Domain=NSPOSIXErrorDomain Code=53 "Simulator verification failed." UserInfo=0x7f980ad0dea0 {NSLocalizedFailureReason=A connection to the simulator verification service could not be established., NSLocalizedRecoverySuggestion=Ensure that Xcode.app is installed on a volume with ownership enabled., NSLocalizedDescription=Simulator verification failed.}
INFO [2015-04-24 10:19:48.99]: [SHELL OUTPUT]: /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/xcpretty-0.1.9/lib/xcpretty/parser.rb:350:in `===': invalid byte sequence in US-ASCII (ArgumentError)
INFO [2015-04-24 10:19:48.99]: [SHELL OUTPUT]: from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/xcpretty-0.1.9/lib/xcpretty/parser.rb:350:in `update_test_state'
INFO [2015-04-24 10:19:48.99]: [SHELL OUTPUT]: from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/xcpretty-0.1.9/lib/xcpretty/parser.rb:247:in `parse'
INFO [2015-04-24 10:19:48.99]: [SHELL OUTPUT]: from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/xcpretty-0.1.9/lib/xcpretty/formatters/formatter.rb:78:in `pretty_format'
INFO [2015-04-24 10:19:48.99]: [SHELL OUTPUT]: from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/xcpretty-0.1.9/lib/xcpretty/printer.rb:15:in `pretty_print'
INFO [2015-04-24 10:19:48.99]: [SHELL OUTPUT]: from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/xcpretty-0.1.9/bin/xcpretty:80:in `block in <top (required)>'
INFO [2015-04-24 10:19:48.99]: [SHELL OUTPUT]: from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/xcpretty-0.1.9/bin/xcpretty:79:in `each_line'
INFO [2015-04-24 10:19:48.99]: [SHELL OUTPUT]: from /Users/ribot/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/xcpretty-0.1.9/bin/xcpretty:79:in `<top (required)>'
INFO [2015-04-24 10:19:48.99]: [SHELL OUTPUT]: from /Users/ribot/.rbenv/versions/2.1.2/bin/xcpretty:23:in `load'
INFO [2015-04-24 10:19:48.99]: [SHELL OUTPUT]: from /Users/ribot/.rbenv/versions/2.1.2/bin/xcpretty:23:in `<main>'
INFO [2015-04-24 10:20:45.70]: Variable Dump:
INFO [2015-04-24 10:20:45.70]: {:DEFAULT_PLATFORM=>:ios, :ENVIRONMENT=>nil, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios dev", :GIT_NOTES_LOCATION=>"build/git_notes.txt", :CERT_FILE_PATH=>"/tmp/cert/<snip>.cer", :CERT_CERTIFICATE_ID=>"<snip>", :SIGH_PROFILE_PATH=>"/Users/ribot/.jenkins/jobs/<snip>-ios-nightly/workspace/build/profile.mobileprovision", :SIGH_UDID=>"45f742bf-9078-4112-a56b-f0cad54fb785"}

Any ideas what could be causing this?

Can you run locale on your CI server and post the results please? Sounds like your $LANG is configured incorrectly on that machine.

CI ➜  ~  locale
LANG="en_GB.UTF-8"
LC_COLLATE="en_GB.UTF-8"
LC_CTYPE="en_GB.UTF-8"
LC_MESSAGES="en_GB.UTF-8"
LC_MONETARY="en_GB.UTF-8"
LC_NUMERIC="en_GB.UTF-8"
LC_TIME="en_GB.UTF-8"
LC_ALL=

Try setting export LC_ALL="en_US.UTF-8"and see if that works for you. If you do a search on all fastlane repositories, this issue has happened quite a few times before with other fastlane tools, but we don't completely know what causes it (other than having a different locale than 'en_US.UTF-8').

Interesting... Adding export LC_CTYPE=en_US.UTF-8 as suggested in https://github.com/supermarin/xcpretty/issues/73 seems to fix the issue, but the values of locale are exactly the same on my development machine.

Ok, that fix seems to work so I'll close this. Thanks for the help!

Thanks @milch for resolving this issue. @milch do you think there is a way to do that automatically within fastlane? This issue has been reported around 10 times already. At least when you google for invalid byte sequence in US-ASCII (ArgumentError), the user can easily fix it, but still, it's an annoying thing. Would love to have this resolved.
I also noticed, the nomad tools are facing the exact same problem.

Since we don't know exactly what causes it I don't know if just straight up setting the locale ourselves would work reliably.
What if we do something similar to what home-brew does if it encounters an error? E.g. search github issues and present the user with some dialog like `fastlane noticed you encountered an error "<>", see if it has already been solved in the following Issues: <>".

+1 bit by this bug.  Don't know what changed but updating gave me this bug.  Fix above worked fine after I found it.

If this got introduced recently maybe it's a good time to use git biset to narrow down which commit introduced it?

If @robwithhair still knows which version he updated from, one of you might indeed be able to git bisect this. Any info on this, @robwithhair?

This has probably nothing to do with the fastlane version as this problem has been around since version 0.1.0 of deliver. It's very annoying... at least when you google for it, you find a solution immediately.

I added
# We want all files to be UTF8, just in case user has it wrongly configured
Encoding.default_external = Encoding::UTF_8
Encoding.default_internal = Encoding::UTF_8

into fastlane_core.rb. Since this problem occurs only when shelling out commands, this should be called in time before executing any external commands. What do you think @milch?

Fixed with https://github.com/KrauseFx/fastlane/commit/1147d8dc149d281a4a320c54c3c0fe56e0cbcd46 :+1:

I'm not sure about setting those, the documentation discourages it:
You should not set ::default_external in ruby code as strings created before changing the value may have a different encoding from strings created after the value was changed., ...

If we set them, they should bet set before any other strings can be created. Maybe calling force_encode on the strings would work as well?

@milch does that mean you see a problem on how it is solved with my commit? It is only executed right before something gets shelled out using the fastlane sh action.

I think the point the docs are trying to make is that you could be ending up with different encodings in your Strings, depending on wether they were created before or after you set default_external and default_internal (which probably would result in very hard to track down bugs). So according to that you would have to set both those properties at the start of fastlane, before any other String could be created.

Just ran into this issue when running fastlane from a Jenkins build. Setting LC_ALL=en_US.UTF-8 in the Jenkins configuration resolved the issue.

I had the same error message, my locale was not UTF-8, I tried this from https://stackoverflow.com/questions/7165108/in-osx-lion-lang-is-not-set-to-utf8-how-fix and solved the issue:

Modified/created a '.profile'
nano ~/.profile

added these two lines to .profile:
export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8

change en_US.UTF-8 to whatever country you are, just check first if available via 'locale -a'

close the session, reopen it

Brew doctor clears the error message

I have the exact same issue as @matto1990 - Works fine locally but doesn't when running from the same machine through my CI (i.e. I have my local machine set up as a CI runner). I'm using gitlab CI multirunner.
If I set the locales through my bash profile it is fixed, but we need keep environment variables within our builds and not globally.
So I'm using a fastlane/.env file but I end up back at the same issue - it's as if the fastlane/.env arrives too late?

@samskiter Can you create a new issue for this? That'd be wonderful! Hope you have a great day! 👍


API are getting deleted in higher enviornments

Release version
all version
Describe the bug
Generally speaking, how could we support a scenario in which in dev 2 apis (api-1, api-2) were updated but only 1 (api-1) needs to be promoted?
I thought by using the config extract.
So I put api-1 in the config extract and I saw I could "extract" one specific api, api-1, and create PR-A.
Now, my prod apim is already in place and tracked in the git repository. When I look to PR-A this is proposing to delete all the other Apis (which are missing in the branch created by the run - extract pipeline) and update api-1. If I understand this correctly, this will give me in the end a prod apim with api-1 updated and all the other ones deleted.
What I would have expected was to keep all the other apis and update api-1. I hope I made myself clear.
Expected behavior
Only selective api should be deployed to higher environments.
Actual behavior
API are getting deleted in higher enviornments
Reproduction Steps
Generally speaking, how could we support a scenario in which in dev 2 apis (api-1, api-2) were updated but only 1 (api-1) needs to be promoted?
I thought by using the config extract.
So I put api-1 in the config extract and I saw I could "extract" one specific api, api-1, and create PR-A.
Now, my prod apim is already in place and tracked in the git repository. When I look to PR-A this is proposing to delete all the other Apis (which are missing in the branch created by the run - extract pipeline) and update api-1. If I understand this correctly, this will give me in the end a prod apim with api-1 updated and all the other ones deleted.
What I would have expected was to keep all the other apis and update api-1. I hope I made myself clear.

I remember seeing the same question being brought up recently in another issue. Please check the other issues as your question has been answered there. Take a look at both the open and closed issues please.

I saw previous issues and read all the documentation. Is there a way to extract only a single API and migrate to higher environments with out deleting old APIs ? Why does the pipeline delete the existing API ? It does not make sense to me.

The publisher picks up the changes in your last commit. If you only modified a single Ali then that is the only change that will be published. Nothing should be deleted if you didn't delete explicitly. Something else most be going on.

Thank you for the reply. I have another question. Is It recomended to have branch for each APIM environments ? I mean, the namedvalues and many other values are specific to environments. How to store envirnment specific metadata in git repo ? What is the best way to store the API metdata ?(Single main branch or multiple branches followed by one main branch)

When we built APIops, we envisioned that you would have one set of artifacts, which usually represent the artifacts of the lowest APIm environment, and then, as you promote to higher environments, you would override using environment specific configuration files (configuration.EnV.yaml. If you follow that set up, then you would need a single git repository, which would store the artifacts of the lowest environment.
Remember that at the end of the day, you are at liberty to extract from any git environment to any git repository as you see fit.

Just to add, it's not recommended that you have multiple git repositories with artifacts, extracted from different environments as it would make it hard to keep them in sync. Instead, as I mentioned before, it is recommended to extract from the lowest environment and then start using the apiops to promote across higher environments while overriding using your environment specific configuration files.

When I extract an API or  a named value using extractor config, Why it is proposing to delete all other api and all named values ?

The publisher picks up the changes in your last commit. If you only modified a single API then that is the only change that will be published. Nothing should be deleted if you didn't delete explicitly. Something else most be going on.

My last commit was modifying the extractor.yaml to extract only one namedvalue. When I ran extractor tool, It is propsing to delete all extsting namedvalues .
configuration.extractor.yaml
namedValueNames:

test4

@guythetechie any thoughts on this?

To fix this, We are doing currently the below steps.

git checkout origin/artifacts-from-portal-build-668876  (We get the branch in local) . This brach is created by the extractor pipeline. Extractor pipeline only respects what is mentioned in the extractor.yaml file and delete everything which are not mentioned in the .yaml config. For me It is a code smell and It should not delete all other files.
We need to then switch to main branch. git checkout main
Now merge main branch with origin/artifacts-from-portal-build-668876 . git merge origin/artifacts-from-portal-build-668876
After merging , It is deleting all other files which are not mentioned in extractor.yaml config which is scary. If some will accidently push the changes, It will delete all api, namedvalues and other in the lower environment.
To prevent above, we need to write few commands.
git reset --soft HEAD~ (In main branch)
manually cheery pick the changes which are relevent and do git restore --staged (to prevent delete all the files).

Could you provide any best approach , so that extractor pipeline should include all old files and add new files which are mentioned in the extractor.yaml file.

In this case you may want to temporarily use gitignore to ignore api2 in this example. As for the extractor its behaving as expected as the moment you include select pais in the configuration.extractor.yaml file you are telling the tool that the only apis you are interested in are those on the list.


Bug: Not able to fetch commit when build type is tag creation

📜 Description
Not able to fetch commit when build type is tag creation
Criticality
P2 - Medium
Impact on Enterprise
Not able to build the image, so testing is stuck
👟 Steps to replicate the Issue
1- Create a build pipeline of type tag creation
2- Give a regex "^v"
3- Create a github release with tagGitHub
👍 Expected behavior
It should fetch the commits from the tag
👎 Actual Behavior
Not able to fetch commits from the tag
☸ Kubernetes version
1.26
Cloud provider

🌍 Browser
Chrome
🧱 Your Environment
No response
✅ Proposed Solution
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#8436

Root Cause:
The issue was produced as, we save the user given git material (git repo url) directly into database.
So if the user has given an additional trailing slash to the git material. It will work fine for CI Build (Branch fix and Regex); as we have the handling in code for them.
But where as in case PR based/ Tag based CI; we get the web-hook payload with the git repo url and we search the exact url in the database. For this case the unsanitized git material url (user given) will fail to match.
Proposed Solution:
Instead of saving user given git repo url, we should use the remote url present in git config after cloning.

Moving this ticket to be prioritised as this is not an blocking issue


windows ingester installer

Bug report indicating that the Ingester-UUID and Ingest-Secret are being put on the same line when installing.
Exact bug report:
It looks like there’s a slight bug with the windows installer.  When it creates the config file, it puts the Ingestser-UUID and Ingest-Secret on the same line.  I’m not sure if this prevents it from working or not, but wanted to let you know it was happening as I don’t think that’s desirable.

I'm unable to reproduce from dev - Building the MSI and pointing the installer to my local gravwell instance with IngestSecrets works fine on install, and the ingester immediately connects.


Markdown for spinning built-in icon not working

Version: 1.54.0-insider
Commit: 3f0d8a14759cddea93f0dbddc12a4ef1e5586e86
Date: 2021-02-17T07:37:22.767Z
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_1_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36
We are using the VS Code Markdown label to include a spinning icon in the status bar to show progress on one of our building processes.
To do this we set the status bar icon text to : $(loading~spin) ${text}
Seems that recently this spinning functionallity got broken since I don't see our status bar icon spinning anymore.
By looking at the developer tools it seems to be constructing correctly.
 $ oryx build
Steps to Reproduce:
This is noticeable in Codespaces.

Create a new codespace with a long running postCreateCommand
Once inside VS Code, look at the status bar showing the running process.

It looks like spin is only allowed for certain codicons, why is that? Need codicon-loading here too: https://github.com/microsoft/vscode/blob/0795762a8f02a7588cc51b1ae41520b50fe081ff/src/vs/base/browser/ui/codicons/codicon/codicon-modifiers.css#L16-L16

Looks like there was a typo and missed a comma when we updated the list a week ago. Fixed now.

/verified


Update ClaudeDev.ts to correct code/comment removing behavior

I noticed very often when proposing changes to the existing code, Claude Dev simply uses the line // ... [rest of the file content remains unchanged until the writeToFile method] to replace a large chunk of original code that is not supposed to be removed. This behavior is often seen in sonnet 3.5 api from my experience, but for Claude Dev's use case this has to be changed. Similarly sonnet 3.5 also tends to remove existing comments which I also find counter-productive. Hence I added two additional rules to counter these behaviors.

I have improved the system prompt in v1.4.17 to better guard against lazy coding. Please give that a try and let me know if it's any better.


Review module/function structure for table-related helper functions

As part of #613, we are actually moving towards complying with the table specs. This may come with a refactor of the core-library functions related to tables. Such refactor is not just a clean-up, but it is needed in view of a future coexistence of tools reading/writing V1 and V2 tables.
The general principle is that all functions which rely on V1 should be marked as such (e.g. in the module or function name), and we can offer general-use functions that do not make any assumption and then defer actual operations to versioned ones. An example is given below, for write_table.
write_table function
The first steps (already part of #613) concern the write_table function, which the closest to a nicely-scoped helper function:

I moved it from lib_write.py to lib_tables.py, since lib_write.py is currently the place for some low-level zarr/anndata operations, mostly extending the original functions with overwrite-related options.
I transformed write_table into a wrapper, which checks the table-specs version and defers the actual operation to _write_table_v1 (the only currently-supported one). In the future, this may conditionally call _write_table_v1 or _write_table_v2, provided they have a compatible I/O interface.
I implemented a (soft) check of compliance with V1 specs, upon writing, as part of _write_table_v1. This is nicely contained in a function marked as v1, so that it won't affect future versions.

Other functions
The API for many other table-related functions is not so precisely defined as for write_table, and the goal of the current issue (and of #613) is not to provide such a set of definitions. Still, we should aim at defining at least the correct modules.
An example of a wrongly-placed function is lib_regions_of_interest.load_region, with call signature
def load_region(
    data_zyx: da.Array,
    region: tuple[slice, slice, slice],
    compute: bool = True,
    return_as_3D: bool = False,
) -> Union[da.Array, np.ndarray]:
    """
    Load a region from a dask array.

    Can handle both 2D and 3D dask arrays as input and return them as is or
    always as a 3D array.
    ...
    """

This function clearly has nothing to do with V1 or V2 or our table specs, and it would rather belong to a module like lib_arrays.py or something like that.
A closer look at lib_regions_of_interest.py
The lib_regions_of_interest.py module is a container of several different functions, and I think we could improve its structure. Here is a first classification of its functions:
Functions that fully rely on table-specs V1

Functions that create a ROI table (either as an ad.AnnData or pd.DataFrame object)

prepare_FOV_ROI_table creates an AnnData ROI table
prepare_well_ROI_table creates an AnnData ROI table
get_single_image_ROI creates an AnnData ROI table
get_image_grid_ROIs creates an AnnData ROI table
empty_bounding_box_table creates a DataFrame
array_to_bounding_box_table creates a DataFrame

Functions that check something of a ROI table

is_ROI_table_valid actually checks if a table can be used for masked loading, and it is only used in cellpose task
are_ROI_table_columns_valid checks that the required V1 columns of a roi or masked_roi table are present and it is used in apply_registration_to_ROI_tables
check_valid_ROI_indices was introduced as part of v0.12 release, to provide meaningful errors when the zero-origin assumption does not hold

Functions that process a table, to produce a new table or a list of indices

convert_ROIs_from_3D_to_2D
convert_ROI_table_to_indices
reset_origin

Functions that are not specific to V1:

load_region, which has to do with extracting a region from an array but has nothing to do with tables
is_standard_roi_table which is only used in apply_registration_to_image to determine which tables must be copied
convert_indices_to_regions, which simply encodes our mapping between the XYZ start/end indices and the three XYZ regions

Note that the V1-related functions are not designed to have a version-agnostic I/O interface, and then I don't think it's useful to pursue the same route as for write_table - for the moment. But I would at least re-organize the modules, since the 15 functions defined in lib_regions_of_interest.py cover too broad a scope.
Specific proposals (which I'll implement in #613, while waiting for a broader discussion):

Move the three non-V1-specific functions out from lib_regions_of_interest.py (is_standard_roi_table should go to lib_tables.py, while I think load_region and convert_indices_to_regions should be part of a new module)
Keep the remaining 12 functions in lib_regions_of_interest.py, without adding a separation between table-creation and table-processing.
Move lib_regions_of_interest.py to lib_regions_of_interest/v1.py, and re-export all functions to lib_regions_of_interest/__init__.py, so that the imports in the tasks remain the same. Note that I also think we should remove lib_, but this is a different issue.

Note about table-specs-versions coexistence
The reason for point 3 has to do with the migration to V2, which will eventually take place. For instance we can say that starting from version 1.1 we default to writing V2 tables from all tasks. We then add a new lib_regions_of_interest/v2.py, and we modify lib_regions_of_interest/__init__.py so that it exports the v2.py functions. The v1.py functions are still importable, but this will require e.g. from lib_regions_of_interest.v1 import prepare_FOV_ROI_table.
This does not yet mean that tasks will work on both V1 and V2 tables, but it's the first step in this direction. The next step will be (as already done for write_table) to implement a conditional check that infers the version of a given table and proceed accordingly by calling the V1 or V2 functions.

Side comment: also lib_ROI_overlaps has a similar situation, since it is clearly related to specs V1. The difference here is that it can be clearly split into two parts:

Overlap-detection functions, which are fully unrelated to fractal
Wrappers which apply those functions to fractal ROI tables, and which do depend on V1

A possible structure would then be
$ tree  -L 1 lib_regions_of_interest/
lib_regions_of_interest/
├── __init__.py
├── _overlap_detection.py
├── v1_checks.py
├── v1_overlap_detection.py
└── v1.py

0 directories, 5 files

with the overlap-detection function now importable under the same namespace as the other ROI-related functions, as in
# CURRENT VERSION
from lib_regions_of_interest import prepare_FOV_ROI_table
from lib_ROI_overlaps import find_overlaps_in_ROI_indices

# FUTURE VERSION
from lib_regions_of_interest import prepare_FOV_ROI_table
from lib_regions_of_interest import find_overlaps_in_ROI_indices

Summary of of changed imports:
-from fractal_tasks_core.lib_write import write_table
+from fractal_tasks_core.lib_tables import write_table

-from fractal_tasks_core.lib_ROI_overlaps import find_overlaps_in_ROI_indices
+from fractal_tasks_core.lib_regions_of_interest import find_overlaps_in_ROI_indices
-from fractal_tasks_core.lib_ROI_overlaps import get_overlapping_pairs_3D
+from fractal_tasks_core.lib_regions_of_interest import get_overlapping_pairs_3D
-from fractal_tasks_core.lib_write import write_table
+from fractal_tasks_core.lib_tables import write_table


Euler-Angle Data Type (euler_t)

Description
Tracks the implementation of Euler Angles
Rationale
This tracks the implementation of the euler Data type (euler_t), which we'll use as an alternative form of orientation|rotation representation; this is likely to be used by the user (as it's easier to handle UI that sets euler angles than quaternions or a full blown rotation matrix :sweat_smile: ). Note that internally we'll avoid using these for orientation|rotation representation (thanks to Gimbal Lock :frowning_face:)

Finished implementation in 3c42332e9cf1185c88e094a88b95db7279bf5ac7


Visual Attention layers

Description
Created 2 layers Pixel Attention and Channel Attention for attentioned based CNN's to directly utilize:

Pixel Attention : Efficient Image Super-Resolution Using Pixel Attention(Hengyuan Zhao et al)
Channel Attention : CBAM: Convolutional Block Attention Module(Sanghyun Woo et al)

Fixes # (issue)
Type of change

[ ] Bug fix
[ ] New Tutorial
[ ] Updated or additional documentation
[ ] Additional Testing
[ ] New Activation and the changes conform to the activation contribution guidelines
[ ] New Callback and the changes conform to the callback contribution guidelines
[ ] New Image addition and the changes conform to the image op contribution guidelines
[x] New Layer and the changes conform to the layer contribution guidelines
[ ] New Loss and the changes conform to the loss contribution guidelines
[ ] New Metric and the changes conform to the metric contribution guidelines
[ ] New Optimizer and the changes conform to the optimizer contribution guidelines
[ ] New RNN Cell and the changes conform to the rnn contribution guidelines
[ ] New Seq2seq addition and the changes conform to the seq2seq contribution guidelines
[ ] New Text addition and the changes conform to the text op contribution guidelines

Checklist:

[x] I've properly formatted my code according to the guidelines

[x] By running Black + Flake8
[x] By running pre-commit hooks

[ ] This PR addresses an already submitted issue for TensorFlow Addons
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:

Model creation, summary and fit were tested in keras. Shapes and outputs were as expected

Thank you for this PR.
We are collecting this kind of things in Keras and Keras-cv repo now.


add dependency for gnu parallel

closed with #36; gnu parallel is now included in this repo, and mounted in the container for the bedpost-parallel rule that requires it


Refactor kernel-picker to remove atom-space-pen-views

This pr is heavily influenced by this example.
I haven't found any bugs yet, but this probably needs a little testing.

I've tested it with multiple kernels, multi-language files. And both, the functionality to start a kernel and the status bar switcher work for me.


ImagePicker example

Does anyone have an example of them using SwiftUIX's ImagePicker?

I would love to help with adding an example into the documentation or whatever, how do I get started? I am new to this repository

@jevonmao I believe if you reply to this feed and tag @vmanot , he may be able to add it to his documentation.

@jevonmao please just create a Markdown file anywhere and open a PR, I can copy and paste the contents to the wiki. GitHub Wikis don't support collaboration currently (which is crazy in 2020), hence the awkward process.
Apologies for the delayed reply to this issue - am strangled with work at the moment. @smaldd14, you'd use ImagePicker within a View.sheet or a View.popover - just like any other view. It takes a Binding<Data> and allows you to specify the encoding of the image you want. Image mutli-select support will be added soon, but feel free to open a PR for it if needed.


Run on startup

Add guide to run script when startup

Hey, thanks for your contribution but I've found out that this is not a good option. Sometimes the script  stop workings after a few days.
The best option would be to launch when Spotify opens and close it when closing the app.


JS file check breaks application

The introduced JS file check from #319 breaks the application. Non of the plugins will be inserted into the server plugins list and will not be mounted at all.

@CodeRedDev I will need server/bot logs, the QA pass that was ran passed inspection.

I went commit by commit updating my SquadJS to the latest and can confirm this change caused the FTP file trail of logs not to work crashing squadJS
    at FTPContext._onControlSocketData (D:\projects\ripsquadjs\node_modules\basic-ftp\dist\FtpContext.js:282:39)
    at Socket.<anonymous> (D:\projects\ripsquadjs\node_modules\basic-ftp\dist\FtpContext.js:123:44)
    at Socket.emit (node:events:513:28)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:293:11)
    at Readable.push (node:internal/streams/readable:234:10)
    at TCP.onStreamRead (node:internal/stream_base_commons:190:23)
Emitted 'error' event on FTPTail instance at:
    at FTPTail.fetchLoop (file:///D:/projects/ripsquadjs/node_modules/ftp-tail/index.js:117:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 550
}

Removing this change fixes the issue

@werewolfboy13 when commenting the JS files section the application will have objects in server.plugins and will mount them.
From my understanding of the code non of the plugin's plugin properties in the config.json end with .js. Maybe there is a typo?

If this is still breaking let me know, but if this is an FTP issue it shouldn't be causing this issue.

If this is still breaking let me know, but if this is an FTP issue it shouldn't be causing this issue.

I don't think rwsender's error has anything to do with this. It's a complete other component. Thanks for the quick fix :)

Nevermind just took another look at the changes.
https://github.com/Team-Silver-Sphere/SquadJS/blob/5be2d21183481e632d9ee2179a4d98f133b8523e/squad-server/factory.js#L85
This must be removed otherwise the error stated at the beginning of the issue won't be fixed.

IF this is occuring I want to see if the console logs I will not be approving a PR if you cant state/show why its not working.

If its fixed as such will it work?

If its fixed as such will it work?

No, the check shouldn't be in this place as I've mentioned in https://github.com/Team-Silver-Sphere/SquadJS/pull/341#issuecomment-1879875772

If its fixed as such will it work?

No, the check shouldn't be in this place as I've mentioned in #341 (comment)

I agree, the PR about checking the file's type is in wrong place. pluginConfig.plugin is the plugin property of the plugin's config which its name. Also what's been done already done in squad-server/plugins/index.js


chore(main): release 1.7.0

:robot: I have created a release beep boop
1.7.0 (2024-05-18)
Features

add support for grapple.nvim (638e37c)
extras: add support for kitty term (#48) (3b57712)

Bug Fixes

add theme variant field to config class (3b5e1df)
docs: small typo in readme (0511451)
improve contrast for line numbers (5827dc9)
low contrast counter in telelscope light theme (0511451)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/scottmckendry/cyberdream.nvim/releases/tag/v1.7.0 :sunflower:


Can a Subject unsubscribe itself from its source upon completion

Documentation Related To Component: Subject

Please check those that apply

[ ] typo
[ ] documentation doesn't exist
[x] documentation needs clarification
[ ] error(s) in example
[ ] needs example

Description Of The Issue
Consider the example below:
const source$: Observable<any>  = //;
const subject$ = new Subject();

const someSubscription = source$.subscribe(subject$); ---> talking about this subscription

subject$.complete();
// is someSubscription unsubscribed?

since the subscription is to source$, will the subject$ know that it should unsubscribe itself? should I still call .unsubscribe I don't believe the documentation goes into that detail.

No. The subject has no relationship with the subscription. Like any other observer, it will be automatically unsubscribed if the source errors or completes, but that's it. An explicit call to the subject's complete method will automatically unsubscribe any observers that have subscribed to the subject - not to the source.

Thank you for the clarification @cartant


In the browser shows that mathmenu is not loaded

@JackUrb
Bug Description
Gettting Error

File failed to load: /extensions/MathZoom.js

Reproduction Steps

Run python -m visdom.server on ec2
connect local machine port to local host of ec2 instance
Run https://localhost:8000/tree on local machine

It gives error

File failed to load: /extensions/MathZoom.js
and doesnt display anything

Getting same error if running on linux system even
Screenshots

Hi @Eyshika, the mathmenu issue is a known problem that doesn't actually have any impact on the running program, and thus I haven't gotten around to fixing it. If you're having logging problems, what are you trying to log and are you getting any errors in the visdom console?


Registry Update Frequency

Prerequisites
Please first check README. There are breaking changes from 0.x to 1.0

[x] Did you check the FAQ?
[x] Did you search open and closed issues to see if your issue has already been reported?

Description
https://api.typings.org/entries/dt/aws-sdk/
{"name":"aws-sdk","source":"dt","homepage":"https://github.com/aws/aws-sdk-js","description":null,"updated":"2016-08-05T03:09:05.000Z","versions":1}

How often are these updated?  The date listed has not been updated since https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10555 got merged in today.

Usually every 5 minutes or so, but the job stalled recently. I've since restarted it.


Allow MailHog to use privileged ports locally

MailHog allows to configure the port where it listens e.g. via
the environment variable MH_SMTP_BIND_ADDR. However privileged ports are
not allowed, since MailHog runs as normal user.
Using setcap the MailHog binary is allowed to bind on privileged ports
Closes #328

@kraxx @tyndyll @anthonyptetlow @rpkamp @teohhanhui
Can one of you please merge this pull request? Thanks you 🙏

I will look at it over the weekend. Want to understand the implications of using the capabilities before merging.

Would it be possible to extract the setcap portion as an additional stage in the Dockerfile build? I can then create and publish two images mailhog:latest and mailhog:latest-privileged-ports. This will give people the option of running it

Is this what you mean?
BTW: The default behavoir does not change, so IMHO people can use mailhog:latest-privileged-ports as a drop-in without noticing a difference. Only if they specify a priveleged port in the Environment, this now works :-)
Or do you have security concerns?
Thanks.

I have security concerns, but I'm 99% sure that they're not valid. I'm just doing some reading up to make sure I'm not missing something! Expect this to be merged in on Friday

Thanks. Take your time. Better to check than to be sorry.

@tyndyll  Thanks for looking into this. I agree with @martinkoehler that reading up on security should not be rushed. 👍🏻


[SMALLFIX] Removed explicit argument types in KeyValueMaster

Removed some explicit argument types in the KeyValueMaster class.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10042/
Test PASSed.

LGTM


bug: Unable to scroll vertically when i use ion-scroll

Type: bug
Platform: mobile webview
In a page i have some content, horizontally scrollable section and some content again. The issue is, if i tap and scroll on the content(not the horizontally scrollable section), then i am able to scroll vertically. But if i tap and scroll on the horizontal scrolling section, i am unable to scroll vertically. ion-scroll direction=x is blocking the vertical scroll. If the horizontal section takes almost full height of the screen, then the user is unable to scroll in vertical direction, which is blocking the scroll. If i remove ion-scroll and use custom css overflow-x : scroll, then i am able to scroll vertically by tapping on the horizontally scrollable section. But this is just working in system browser, but not in the mobile.
Please have a look at the code pen
http://codepen.io/rajeshwarpatlolla/pen/EjQyOJ
Steps to follow

Click/tap beside 'heading' and try to drag/move up and down.
Scroll down, and click/tap on the horizontally scrollable section and try to drag/move up and down. You wont be able to move vertically.
If the horizontally scrollable section occupiers whole screen of the mobile, then the user cannot see the above and below this horizontally scrollable section.

Similar to https://github.com/driftyco/ionic/issues/3789

Greetings @rajeshwarpatlolla!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Add auto tick repeaters and compariters.

I think It would be super useful, for example, the printer to be placing a repeater that needed to be at a four tick delay, to right click the repeater until it met that delay. I know it might be hard but lots of claints that use scamtica have it. The reson i don't use then is because it cost like 25usd. Thank you for your time in making this I hope you can add this in the future.

Also  you sould add esp.
Showes a traser to block that that are missplaced or not placed or in wrong state.


[BUG]

Describe the bug

In the body of resume whenever I am adding the data like when I am writing work experience and rest of the data it is just getting addd in the left part of resume only not in he whole page
Product Flavor

[x] Managed (https://rxresu.me)
[ ] Self Hosted

To Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Desktop (please complete the following information):

OS:
Browser
Version

Additional context

You would need to move your work experience section to another layout column (in the layout section on the right sidebar). This way, you can mix-match any layout design you like :)


Add numerical tests for optimizers

This PR adds new tests for SGD/RMSProp/Adam backed by TensorFlow code.
There already are convergence tests for them, but numerical tests are much better.
For other optimizers I tried adding similar tests but they didn't pass with small difference.
Related: #696

I missed the test for AdaDelta is also passing.
Added it.


Potentially illegal CPOOL references in JVM's SLEIGH definitions

https://github.com/NationalSecurityAgency/ghidra/blob/ba5fcdf4ede478ba1d394cc1efa7802099023510/Ghidra/Processors/JVM/data/languages/JVM.slaspec#L52
For both CPOOL_PUTFIELD and CPOOL_ARRAYLENGTH, these types are defined as "16:4" and "17:4". The expected format of this parameter isn't well documented, but I'm assuming it's supposed to be <value>:<bitwidth>. Obviously, the values 16 and 17 don't fit in 4 bits (0-15).
I haven't encountered any specific problems caused by this. Rather, I just stumbled across this while writing my own SLEIGH definitions for a new processor module and looking at examples from other processors.

Sizes in SLEIGH are in bytes, not bits.
Those particular definitions need to match the ones defined here: https://github.com/NationalSecurityAgency/ghidra/blob/0233f35d1fe487bf71cf0055a6cbfbe17c46bbdc/Ghidra/Processors/JVM/src/main/java/ghidra/app/util/pcodeInject/ConstantPoolJava.java#L37C1-L55C54


How to build chrome v8

http://blog.csdn.net/cutesource/article/details/8625497
https://github.com/joyent/node/wiki/Installation

With the help of https://github.com/xicilion/fibjs


ORT security tool parser: add license path in finding description

This will add feature #4222

[x] A new value is added to the model in order to allow the finding path to be found: license id number.
[x] A new function is added in order to find the path of a license id number in a given findings list.
[x] A condition was added in order to capture the cases where findings are present and the path value is applicable (i.e. can be found in the file).

@devsecopsale could you add a check in one unit tests that test the description with the new data?

@devsecopsale could you add a check in one unit tests that test the description with the new data?

Hi. sorry the late. I've been on leave. I'll try to take care of this next week.

@devsecopsale Are you still considering to add a check for the new functionality in the unit tests?

Are you still considering to add a check for the new functionality in the unit tests?

@devsecopsale

Are you still considering to add a check for the new functionality in the unit tests?

@devsecopsale

Hi, sorry, I'm not sure which kind of unit test I should add to it. Isn't the standard unit test for the parser enough to cover it?

Are you still considering to add a check for the new functionality in the unit tests?

@devsecopsale

Hi, sorry, I'm not sure which kind of unit test I should add to it. Isn't the standard unit test for the parser enough to cover it?

nothing is checked yet at https://github.com/valentijnscholten/django-DefectDojo/blob/e515c0e4030efec056e0ab5536ffe7b6fcf715db/dojo/unittests/tools/test_ort_parser.py#L19, so ideally we add some checks for file path and other fields.

@devsecopsale could you add a check in one unit tests that test the description with the new data?

@devsecopsale do you need help to complete this PR?
A simple thing could be to test if the license path is in the description. I can help on this one, you can contact me in Slack.


Typos in ob.txt

Another typo in obtheory (Q: shall I just put all typos into this issue?):
Lines 33,34:
* There are two selector functions, ob.a(z) and ob.b(z) that given
any ob and determine an ob as their result.
"given any ob determine an ob ...." -- the "and" does not belong there.
Originally posted by @band in https://github.com/orcmid/miser/issues/16#issuecomment-491023739

obtheory typo, lines 107-111:
Ob5. Totality
ob.is-individual(z) ∨ ob.is-enclosure(z) ∨ ob.is-pair(z)
    It is a consequence that each ob is exactly one of pair,

enclosure, and individual and there are no others.
Should this read "... one of pair, enclosure, or individual and ..."?

obtheory typo, line 139
In formats having greater typographical flexibility than plaintest, there
"plaintest" should be "plaintext"


Document format for Accord Project contracts

Discussion 🗣
The issue of a standard document format for Accord Project was raised by @jeromesimeon.
Details can be found here: Cicero Issue #562
TL;DR
The current CTA compressed archive format assumes the Accord contract is a template that is editable and represents a contract type but is not a contract in and of itself.
The assertion is that there needs to be a file format which contains a contract instance and encapsulates all data, logic and legal artefacts (e.g. signatures) that represents the final, executed agreement.
Context
This could be related to the issue Identity management and digital certs #13.
This could be a "Lab" candidate - under the Apache definition as there is no existing codebase.

From TSC Meeting, 2 June 2021:

@jeromesimeon has been excellent progress on issue and provided update.
Details can be seen via Create a contract Instance directly from an archive #677 and refactor(core) Clearer separation between contract template and contract instance #676

From TSC Meeting, 26-Aug-2021

Active work-in-progress following on GSoC project for Contract and Template signing.
More details to follow as work continues.


Follow search performance on basic queries

We could use a restricted set of queries used in tantivy benchmark.
Would be also interesting to know the perf with parallel queries.

Let's split this into subtasks:

[ ] Load test-data and run set of queries
[ ] Retrieve and store benchmarks in a DB (could be Quickwit :)
[ ] Have a dedicated machine running continuously

By the way, preparing a good benchmark set will help a lot with using PGO for Quickwit. Without some "generic" sample load it is much more time consuming to prepare PGO-optimized binary.

Regarding PGO (and Bolt) possibly these links could be helpful:

ScyllaDB results: https://github.com/scylladb/scylladb/pull/10808
Vector results: https://github.com/vectordotdev/vector/issues/15631
Rust experience with LTO + PGO + BOLT: https://kobzol.github.io/rust/rustc/2022/10/27/speeding-rustc-without-changing-its-code.html


chore: Use AWS public ECR's gitlab runner image as default #143

I added changes below:

Now 't3.micropublic.ecr.aws/gitlab/gitlab-runner:alpine' is the default runner image
Add createUserData() method to make writing tests easier

Fixes #143

@gotodeploy 't3.micropublic.ecr.aws/gitlab/gitlab-runner:alpine' is the default runner image??
Why not public.ecr.aws/gitlab/gitlab-runner:alpine

@guan840912 Thank you for pointing that out. I fixed the url.


Support richer links to pages on sidebar, allow use of icons [PlanID: 2023.3/16/1.7]

[ ] Allow integrators to upload an icon for the sidebar
[ ] Allow integrators to select one of the previously uploaded icons for the sidebar
[ ] Allow integrators to select icons from the library of the sidebar
[x] Allow integrators to explicitly select pages that expand

What's accomplished on the FE so far:

added a button that opens a modal. In the modal, there will be two sections. One for uploading an icon and another for listing the previously set page icons. The two sections will be split with an <hr>
added a checkbox for toggling whether to show subpages of a page or not

As we discussed, We will use existing /namespace/{namespaceID}/page/{pageID}/attachment endpoint to upload page icons and meta info witll be saved on page.config.navItem.icon stuct.
PageConfigIcon struct {
	// "attachment"
	// Reference (ID) to an existing attachment in local Corteza instance is expected
	// This type and reference must be validated by the backend.

	Type string `json:"type,omitempty"`
	Src  string `json:"src"`

	// Any custom styling that should be applied to the icon
	Style map[string]string `json:"style,omitempty"`
}

Define an icon gallery on some administration page where you can upload icons that can be used within Compose pages (you can use the Compose attachments for that)

On page configuration

Define a section to upload an SVG as an icon (store it directly in the page meta)
Define a search to select an icon from the galery
Define a search to select a FA icon.

We won't be adding a search to select a FA icon (discussed with Jože). The rest will be added

Added mx size and file type whitelist in admin's compose settings

Added functionality for setting link as page icon

Preview of the gallery items and their icon buttons. This demo is in FileBase because BE endpoint for retrieving a list of icons doesn't work as expected. The same view will be present on page edit.

Demo of view, select/unselect and download buttons

What's left to be done:

upload attachment and fetch list of icons endpoint need to be fixed
preview link as icon
expand list of pages in sidebar
show page icon next to page title

FOr today: if the remaining BE changes are added, continue working on this. Else, work on record list filter task

Page expand functionality added:

For today: research on how to display page icon in sidebar and implement the functionality

Show page icon in the sidebar (link set as icon):
![Image](https://user-images.githubusercontent.com/85161724/223503003-cfcc7ce0-6df0-4e30-a2f0-99a9223920b5.gif

New way/style of selecting an icon:

For today: sync with Vivek reg list page icon and upload attachment endpoints

For today: take a look at upload type being sent when uploading an attachment. Afterwards see and discuss what more needs to be done

Fetching of page icons and attachment upload are now working.
Todo:

make sure an attachment can be selected and set as an icon
either select an attachment as a page icon or upload a link
change the page icon a couple of times to confirm this works
refactor code

For today: complete the remaining things to be done and submit the task for code review

svg files will be supported in a future version

Todo:

fix broken icon link in sidebar for attachments
in admin set 10 as default max size
when uploading an attachment show the right message if an attachment file is whitelisted
mark selected page icon on icon list fetch
refactor code if needed

For today: complete todo list and if everything is ready submit code for review. If not, apply fixes and  submit code for review tomorrow at the latest

For today: focus on this task. Address any comments and make sure task moves forward to "Done"

For today: address the rest of the comment from PR and submit to QC

Found a small issue where when you add an icon and after saving the icon if you do any change on the page visibility toggle or the expand toggle the icon is getting erased after saving the changes. Providing also a video of this case:
bf336c10-400a-42ea-a48a-81d6ac07d268.webm

Retested and confirming that now everything works as expected.

CL:
What: Added support for page icon and  the option to expand subpages in the sidebar
Why: The page icon was added to allow the user to further customize a page. The expand sub-page option was added to improve access to subpages. When the option is enabled, the user can always see sub-pages without having to constantly expand the parent page.
Commit for 23.3: 72d44713f26cd4d6cfc10a0b4a35abf00ea9394e

Added CL. Moving the card to Done.


Doesn't recognise scan until app re-opened on Android (2.2.9)

In a Xamarin Forms app, ZXing is setup as follows:
protected override void OnCreate(Bundle bundle)
        {
            ...
            ZXing.Net.Mobile.Forms.Android.Platform.Init();
            ////ZXing.Mobile.MobileBarcodeScanner.Initialize(Application);

            Forms.Init(this, bundle);
            LoadApplication(new App(kernel));
        }

        public override void OnRequestPermissionsResult(int requestCode, string[] permissions, Permission[] grantResults)
        {
            ZXing.Net.Mobile.Android.PermissionsHandler.OnRequestPermissionsResult(requestCode, permissions, grantResults);
        }

When using 2.1.47 the app would crash after requesting permissions using:
ZXing.Net.Mobile.Forms.Android.PermissionsHandler.OnRequestPermissionsResult(requestCode, permissions, grantResults);
Since upgrading to 2.2.9 the app no longer crashes after requesting permissions but scanning doesn't work until the app is re-opened. The camera initialises but doesn't recognise a QR code. Scanning is done using <zxing:ZXingScannerView   IsScanning="True" IsAnalyzing="True"
Calling MobileBarcodeScanner.Initialize(Application);  doesn't seem to have any effect.
Please advise a work around (or fix) for either permissions crash on 2.1.47, or scanning not working on 2.2.9.
iOS works as expected.

I've also the same problem. After it ask the permission for the camera, the OnScanResult in never called after scanning QR Code.
If you reopen the ZXingScannerPage then it scan correctly.
Any workaround? I can't deliver an app where customers need to start a scan, then back or close, and scan again..

Well for now you can ask for the permissions a bit sooner manually in your app, but yes this needs to be fixed.

@Redth I am still seeing this error in 2.4.1. The app does not crash after requesting permissions, but scanning doesn't work until the app is re-opened (or scanning is restarted). Related to #717.


Parenthesis Cause see() to return false

I was testing this and was surprised to find this bug, but I don't know if it belongs here or upstream or not.
public function test_delete_customer()
{
	$this->test_add_customer();
	$customer = User::where('username', '=', $this->newuser['username'])->firstOrFail();
	$this->visit('/admin/customers/' . $customer->id  )
		->see('Customer Detail')
		->click('Delete')
		->onPage('/admin/customers')
		->see('Customer ' . $customer->first_name . ' ' . $customer->last_name . ' (' .     $customer->id . ') has been deleted.');

	}

Was returning failed, even though the output indicated it was there and correct.
Changing the see() call to:
->see('Customer ' . $customer->first_name . ' ' . $customer->last_name . ' \(' . $customer->id . '\) has been deleted.');

Corrected the issue.
I think this might be an issue with accepted syntax of the PCRE and what see() is passing.

That's because a regular expression is used for the see() method, and hence the parentheses are special characters.

I realize that. Hence my comment about the syntax and PCRE. There should either be some documentation stating that, or special PCRE characters be filtered from the see() method, was more to the point of this issue report.

I just encountered the same problem looking for a question on the page, because a ? has a special meaning in a regex.
To my way of thinking, see() should look for the actual string I pass it, not a regex interpretation of what I give it. Therefore I believe it should backslash escape any characters with special meanings - a simple preg_quote() does nicely - before doing the assertion.
If users have a need for such a thing, then I'd suggest a separate seeRegEx() function.
As it stands, I have to wrap my offending string in preg_quote() first.

I have been overriding the see() method in my TestCase.php to do this, so would love to see the referenced PR merged in.
public function see($text)
{
    return parent::see(preg_quote($text, '/'));
}


Feature/orders backend

This a draft PR. It's not ready to merge yet. I'll mark it ready when feature implementation is done.

Thank you guys for reviewing the PR!


Code Style Fix for Table Gen.

This PR fixed code style issues merged in #39. See the wiki for the code style guide.
Some highlights:

For new files, we need to run include-what-you-use script.
For return values, the reference symbol (&) or the pointer symbol (*) should be next to the return values, instead of the function name.
For non-static methods, the first letter of the method name should be in the lower case.
Always use std::size_t, defined in <cstddef>.
Items in QueryContext is sorted by alphabet order.

Thanks for the improvement! Other things look good, except that I think we don't need the additional copyright notice, as discussed in a previous email.

LTGM. Merging now.


Yatin: Watch nutritionwise.medium.com

Yatin requests the watch of the watch_keyword nutritionwise\.medium\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

nutritionwise\.medium\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


Implement an 'EmbedChooserPanel'

(Ref: https://github.com/torchbox/wagtail/issues/245#issuecomment-53628324)
In the same way that wagtailimages provides a dual-purpose chooser interface that can be invoked either from a rich text widget, or from an ImageChooserPanel to populate a standalone image field on the model - the wagtailembeds chooser interface could be extended so that it's not only used within the rich text widget, but can also populate a model field via a new 'EmbedChooserPanel'.
At a data model level this is not giving us anything that we can't already do with a bog-standard text box, because an embed is identified by its URL - effectively we'd just be prompting the user for a URL, and storing that same URL back to the model. However, going through the chooser means that we can validate that the URL is a recognised embed type, and allows us to render a preview within the page editor.

Are you guys still wanting to get this one done? I'm keen on taking over it :)

@jordij I don't think there's been any work done on it at our end - so yep, go for it!


feat: add patch bulk method

Can you solve the coverage problem or is it on some untestable paths?


Don't copy preload actions on form publish

Instead, a preload should be able to reference multiple questions. There should only be one preload set per form set.

Achieve this by adding a "PreloadQuestion" join table and removing question_id from preload_action table


Fishing rod knockback glitch into blocks

With the Old fishing rod check enabled, people are able to push themselves through blocks glitching themselves out of the map. Basically using the fishing rod knockback to block glitch.

What version of the plugin do you have?

1.4.0

But is the person glitching holding the rod too or do you need to players to do this?

I've only seen it done with two people, and the person being glitched is not holding the fishing rod but taking knockback from the fishing rod.

I don't' seem to be able to replicate this bug. Could you provide more information on the exact configuration of blocks that players are glitching through, or even a video?


Can this extension be used on chrome for iPhone?

Expected behavior

Current behavior

Possible solution

Steps to reproduce (for bugs)

Context

Steps for resolving the issue

[ ] Reauthenticate on Last.fm

[ ] Try to use unpacked extension from latest master

[ ] Check other issues for duplicates

Environment

Version used:
Browser name and version:

Nope.


Pass configured host string instead of always forcing an ip-address

Pass the configured host (https://www.home-assistant.io/components/homematic/#host) instead of always forcing an ip-address. This is required to get SSL certificate validation working.
Breaking Change:
Not that I'm aware of

Description:
The current implementation in the component at lines homeassistant/components/homematic/init.py#L265 and homeassistant/components/homematic/init.py#L281 always forces an ip-address passed to pyhomematic. This made it practically impossible to get SSL certificate validation working. With the proposed changes the configured value for host is passed to pyhomematic. If a user wants to pass an ip-address he is free to do.
Talking to @danielperna84 the maintainer of pyhomematic he wasn't even aware of this. I would have renamed the key 'id' to 'host' but @danielperna84 said it's not worth the effort as pyhomematic has to be adpted than as well.
This is my first pull request for Home Assistant so please bear with me if I have forgotten something.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly (example).
[ ] New dependencies have been added to requirements in the manifest (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

@pvizeli
Just commented on your comment. ^^
Yes, I'm fine with it. 👍

Could this PR be added to the 0.93 milestone?


[bug] useDisconnect not disconnecting from Metamask

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.4.12
Current Behavior
Whenever I connect one Metamask account and then disconnect it still shows connected on metamask.

Expected Behavior
It should be disconnected from the Metamask.
Steps To Reproduce

Login with Metamask,
useDisconnect method to log out,
Check Metamask it still shows connected, it should show Not. Connected

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

MetaMask doesn't support programmatic disconnect. wagmi simulates this with the shimDisconnect and UNSTABLE_shimOnConnectSelectAccount flags.


Remove expired deprecation warnings

Removes deprecated functionality that was deprecated at least one major release ago. Each deprecation is in a separate commit to ease review.

Merging.  Thanks @jcrist !


⚠ ClamAV has degraded performance

In b0e1434, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: ClamAV performance has improved in e09868b after 8 minutes.


add: unittest compatible with eth sig utl

name: Pull Request report
about: Create a PR report to apply for code merge or feature test.
title: ''
labels: ''
assignees: ''

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the Contributing doc
[ ] Lint and unit tests pass locally with my changes
[ ] I have added annotation in every module or function of my work
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation like README.md (if appropriate)
[ ] Any dependent changes should support downstream modules, if not, should add admin in this organization as reviewer to discuss

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

close first.


Screen Reader Support

Using the static method go on an onClick event handler, is it possible to display the links for screen readers?
For example let's take the following code:

Foo

        <mwc-list>
          <mwc-list-item
            @click=${() => Router.go('/foo/foo')}
            >Foo</mwc-list-item
          >
          <mwc-list-item
            @click=${() =>
              Router.go('/foo/foo')}
            >Foo</mwc-list-item
          >
        </mwc-list>

For screen reader supports I would like to have the links displayed in the bottom left corner of my browser, is it something possible?

Hi @aress31 to have better accessibility support, it's better to use the  element instead. I found an example of wrapping <mvc-list-item> into an .
<mwc-list>
  <mwc-list-item>google</mwc-list-item>
  <mwc-list-item>bing</mwc-list-item>
  <mwc-list-item>duck duck go</mwc-list-item>
</mwc-list>

Would this work for you?

Hi @haijian-vaadin, this indeed works, but I want to do client side routing with the Vaadin router, the point was to add screen reader when routing with Vaadin router in a similar fashion than the React router does.


Add Salesforce diagrams icons to library

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Is your feature request related to a problem?
No, I would like icons to be added
Describe the solution you'd like
Now Salesforce have a design guide to make diagrams using design Templates (as well as lucidchart).
Describe alternatives you've considered
Lucidchart have integration icons here.
Example

Additional context
About Salesforce Templates:

Videos: Youtube playlist
Docs: architect

Hello,
I'm interested in this issue as well, is there any news? Or workaround?
Thanks

This point is very interesting for the organization of processes

Please implement this, could be very interesting, thanks

If you wish to vote on the issue, thumbs up the original post. "Me too" post cause noise and add nothing useful.

Will be in next release

In 22.0.1


Show master data

This adds a comparison timeseries to the main BenchmarkTest timeseries. The motivation is to compare the metrics between the default branch and a PR.
I added a small "branch" icon to show where the PR starts. In the future I would like to replace/extend this by an area selection like shown in: https://dygraphs.com/gallery/#g/highlighted-region
Screenshot of a graph:

Btw, this is currently already deployed at: http://autumn.ocamllabs.io/#/pull/264

Closing this in favour of https://github.com/ocurrent/current-bench/pull/41/files


Wrong location listed for disallowMultipleLineBreaks

This code:
function foo() {
  var a = 2;

}

Reports that there shouldn't be at most two lines between the semicolon and the curly brace on the space after the semicolon. I would expect it to highlight the closing curly brace instead.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10097618-wrong-location-listed-for-disallowmultiplelinebreaks?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

https://github.com/jscs-dev/jscs-jsdoc/issues/89 lol. It shows jsdoc comment as the second token.

disallowMultipleLineBreaks: } and ; should have at most 2 line(s) between them at test.js :
     3 |
     4 |
     5 |}
---------^
     6 |

I don't know, does it looks better?

Hm, not sure why } placed as the first token.
@TheSavior Why you think the closing brace should be marked instead of opening one?
@markelog I'm missing a lot location range here.

@zxqfox now it looks like this -
disallowMultipleLineBreaks: ; and } should have at most 2 line(s) between them at test.js :
     1 |function foo() {
     2 |  var a = 2;
--------------------^
     3 |
     4 |

Check this ;-)
function foo() {
  var a = 2;

  /**
    * @something
    */
}

I think @TheSavior meant that it should looks like:
disallowMultipleLineBreaks: ; and } should have at most 2 line(s) between them at test.js :
     3 |
     4 |
     5 |}
--------^
     6 |

But I'm not sure why.

@markelog exactly.
@zxqfox exactly.
The reason I think it should look like your second example is because there is no error on the line with var a = 2; The error is that the semicolon has too many blank lines above it. You could also say that there are too many blank lines (and that those lines themselves are the error).
Either way though, there is nothing wrong on line 2 IMO. :P

Assertions need to be able to specify which of the tokens is in error. I'll work on this soon.

Will this be fixed when we integrate CST?

At this point only major and CST related bugs will be fixed.


tomcat9: 9.0.95 -> 9.0.97

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for tomcat9 is: Implementation of the Java Servlet and JavaServer Pages technologies
meta.homepage for tomcat9 is: https://tomcat.apache.org/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 9.0.89 with grep in /nix/store/z8y8id3r09r4a5z2b8xhnl8cbwv6n1yb-apache-tomcat-9.0.89
found 9.0.89 in filename of file in /nix/store/z8y8id3r09r4a5z2b8xhnl8cbwv6n1yb-apache-tomcat-9.0.89

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

tomcat9

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z8y8id3r09r4a5z2b8xhnl8cbwv6n1yb-apache-tomcat-9.0.89 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tomcat9 https://github.com/r-ryantm/nixpkgs/archive/87a769b312e4344f39dacccfa3eacbcea146aa88.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/87a769b312e4344f39dacccfa3eacbcea146aa88#tomcat9

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z8y8id3r09r4a5z2b8xhnl8cbwv6n1yb-apache-tomcat-9.0.89
ls -la /nix/store/z8y8id3r09r4a5z2b8xhnl8cbwv6n1yb-apache-tomcat-9.0.89/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

tomcat9
tomcat9.webapps

Maintainer pings
cc @anthonyroussel for testing.

Bug is present in pkgs/common-updater/generic-updater.nix (gitUpdater)
See https://github.com/NixOS/nixpkgs/blob/master/pkgs/common-updater/generic-updater.nix#L71
patchlevel_unstable argument parsing is broken, and is always true.
And in that case (when patchlevel_unstable is true/set), the patch version number cannot be greater or equal than 90.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for tomcat9 is: Implementation of the Java Servlet and JavaServer Pages technologies
meta.homepage for tomcat9 is: https://tomcat.apache.org/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 9.0.97 with grep in /nix/store/z06nvpl40b9520bfrbgs7q08lzd41zxi-apache-tomcat-9.0.97
found 9.0.97 in filename of file in /nix/store/z06nvpl40b9520bfrbgs7q08lzd41zxi-apache-tomcat-9.0.97

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

tomcat9

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/z06nvpl40b9520bfrbgs7q08lzd41zxi-apache-tomcat-9.0.97 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tomcat9 https://github.com/r-ryantm/nixpkgs/archive/1fd81111754942cefc7f47d4d6a08f3bf0294121.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1fd81111754942cefc7f47d4d6a08f3bf0294121#tomcat9

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/z06nvpl40b9520bfrbgs7q08lzd41zxi-apache-tomcat-9.0.97
ls -la /nix/store/z06nvpl40b9520bfrbgs7q08lzd41zxi-apache-tomcat-9.0.97/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

tomcat9
tomcat9.webapps

Maintainer pings
cc @anthonyroussel for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Pulling ASA lessons into MRLearningASA branch + new updates

Docs Build status updates of commit f45b176:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/mrlearning-asa-ch1.md
:warning:Warning
View
Details

mixed-reality-docs/mrlearning-asa-ch4.md
:warning:Warning
View
Details

mixed-reality-docs/images/Module2chapter3step7im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Module2chapter4step23im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Module2chapter4step7aim.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Module2chapter4step9im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter3step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter3step2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter3step3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter3step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter3step5im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter3step6im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter3step8im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter3step9im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4note2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4note3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4noteim.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step10im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step11im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step12im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step13im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step15im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step16im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step17im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step18im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step19im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step20im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step21im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step22im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step2aim.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step2bim.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step4aim.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step4bim.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step5im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step6im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step7bim.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/module2chapter4step8im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-asa-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-asa-ch3.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-asa-ch1.md

Line 13: [Warning] Invalid file link:(~/link).
Line 13: [Warning] Invalid file link:(~/link).

mixed-reality-docs/mrlearning-asa-ch4.md

Line 27: [Warning] Invalid file link:(~/dashboard.photonengine.com/en-US/Account/SignUp).
Line 172: [Warning] Invalid file link:(~/images/Module2chapter4step24im.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update managed API timeout

Update proxy timeout for managed APIs to accommodate Whisk invokers returning a 202 shortly after 60s.

Currently, the Whisk invokers timeout after 60s and return a 202 with the activation ID. However, the gateway has a default read timeout of 60s, meaning that it hangs up just before the invoker returns the 202. This change allows the gateway to receive the 202 response.
@mhamann @alexsong93 PTAL

@codymwalker I'm Cloud Support for https://github.ibm.com/BlueMix-Fabric/functions-support-tickets/issues/79.  Have you fixed the issue and rolled it out to the production env IBM Public EU-GB (LYP)?


chore(deps): bump davinci-github-actions to the latest version

FX-3708
Description
update to the latest version of davinci-github-actions to remove set-output deprecation
How to test

There are no deprecation warning https://github.com/toptal/picasso/actions/runs/4167190564

Screenshots
n/a
Development checks

n/a Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
n/a Annotate all props in component with documentation
n/a Create examples for component
n/a Ensure that deployed demo has expected results and good examples
n/a Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
n/a Covered with tests

Breaking change

n/a codemod is created and showcased in the changeset
n/a test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

I think, this PR might be closed: https://github.com/toptal/picasso/pull/3387


pod?

how to use it with pod?

@Rumyancev
Right now we are not supporting the cocoapods but we will add cocoapods support soon meanwhile you can use manual dragging classes files for now.
Thank You
Sent from my iPhone

On 10-Aug-2016, at 5:18 PM, Vitaly Rumyancev<EMAIL_ADDRESS>wrote:
how to use it with pod?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

thank you

@vitalrum Pods integrated , you can install through following command...
pod "ACFloatingTextfield"


Bundle source code for optimization

It would be cool to bundle the source code, so it can be optimized a bit. However, I stumbled upon a problem, which is that the Electron Forge Webpack plugin mandates the use of a renderer process, which I don't use.
Any help would be appreciated.
Refs https://github.com/electron-userland/electron-forge/issues/2628

PS: bundling source code didn't work because of some node_modules dependencies, but it's at least minified now.


SVG icon with a lot of blank space

I wanted to use the SVG icon for YakYak, but the document has a lot of whitspace around the image itself.
I've trimmed the document in inkscape, but maybe I removed an important tag (named filter) 009244b9dab60c63b87e1999457773b75b230d92
As it is in the commit it can be used as an icon in Ubuntu 16.04 (and probably any other distribution)
Cheers!

not anymore!! :)


resolves #296: pass 'leading' attribute from theme for table cells to prawn

with the help @fliiiix during a great hacking session at @froscon 12 (thanks a lot!), we found the right place to add the handling for this property and fix #296 .
It helps not only with the line spacing but also to handle appearently broken fonts that seems to report their height incorrectly, like shown in the screenshots:
Before:

After:

Also added some example files to demonstrate it.
Unfortunately, I cannot add the font with the wired behaviour as it's a licensed one :(

I implemented this in https://github.com/asciidoctor/asciidoctor-pdf/commit/1a0b00cadd9e2f674d514c99698e953f1d215782. It's a little more complicated than just setting the padding, as you can see.
I didn't add the table example since I'd rather use the chronicles example for that. I would like to have sample themes, but they either belong in the (future) test suite or a dedicated repository.


chore(protocol): remove etags

chore(protocol): remove etags (#29)
feat(protocol): implement packet sequence numbers (#30)
feat(protocol): add support for priorty updates (#50)

@pahimar,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Calc should support "@s" formatting for objects and lists

Line 1910 of CalcObjectVisitor should read:
if (formatTestChar != 'j' && formatTestChar != 'q' && formatTestChar != 's') {

And "@-s" could take out extraneous whitespace:
a=[1, 2, 3, 4]
a@s => "[ 1, 2, 3, 4 ]"
a@-s => "[1,2,3,4]"


Zoom Image Angular Issues

Describe the bug
I am trying to use your plugin in my Angular Application:
Angular: 17.3.9
Zoom Image Core: 0.36.2
Zoom Image Angular Adapter: 0.2.19
I looked at the example https://stackblitz.com/edit/willnguyen1312-zoom-image-x7vadc and tried to implement it like this.
First problem is when trying to run npm i:

This is caused by a peer dependency to angular 16 in the angular package of the library.
As soon as I have the service ZoomImageWheelService in my constructor, I get the following error:

Issue with Services seems to happen for all 4 Services.
Reproduction

Checkout Repo
run npm i
Notice first Problem
run npm i --force
run npm run start
Open Browser
Notice second problem in browser dev tools

Reproduction
https://github.com/janwidmer/zoom-image-angular-bug
Used Package Manager
npm
Validations

[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is available

Hi there, sorry for the late response as I'm on vacation now. Please try to use the latest version of Angular adapter 0.2.20. Hope it works :)

@willnguyen1312 thanks for the quick fix. That fixes the first part of this issue occurring during npm install.
The second problem with the no provider error still occurs though.. any idea on that?

I think we need to add missing providers in Angular like so. Hope it works on your end like mine too ;)

@willnguyen1312 aaah sorry my bad, I did not see the providers in the component. Now it works, thank you. :)


Add arch node selector for hybrid clusters

Currently, all of the lens prometheus components are multi-arch except for kube-state-metrics.  On a hybrid cluster this can get scheduled on arm, arm64 or other nodes and the pod will never come up.

kube-state-metrics image only supports amd64 - https://github.com/kubernetes/kube-state-metrics/issues/1037.  There is a PR for this but it hasn't been merged yet and seems to be held up.

Alternatively I could switch to use a different image: https://hub.docker.com/r/carlosedp/kube-state-metrics/tags but just limiting the state metrics to amd64 seems like the much easier/safer option.
And just a note:  I don't see it listed anywhere what minimum version of Kubernetes is required for Lens.  It might be nice to set that up?  Somewhere in the requirements section of the readme?  I.e. if it was clear that the minimum supported version was Kubernetes 1.14 I would have updated the labels from beta.kubernetes.io/* to kubernetes.io/*.  The old beta.kubernetes.io/[os | arch] labels were deprecated in 1.14 and scheduled for removal in 1.18.  They didn't remove them in 1.18 but may remove them in 1.19 or 1.20.

I just realized something based on your comment... if the terms are ored together, I don't think my change is correct.  We really want:
(kubernetes.io/os == 'linux' && kubernetes.io/arch == 'amd64')
|| (beta.kubernetes.io/os == 'linux' && beta.kubernetes.io/arch == 'amd64')

So I think the below is the way to get that?  Is there a command-line I could run to test my changes against my local cluster?
            nodeSelectorTerms:
              - matchExpressions:
                - key: kubernetes.io/os
                  operator: In
                  values:
                  - linux
                - key: kubernetes.io/arch
                  operator: In
                  values:
                  - amd64
              - matchExpressions:
                - key: beta.kubernetes.io/os
                  operator: In
                  values:
                  - linux
                - key: beta.kubernetes.io/arch
                  operator: In
                  values:
                  - amd64

@jonstelly you are absolute right, we want exactly this (logically, I wish it was that easy to specify with k8s :D ):
(kubernetes.io/os == 'linux' && kubernetes.io/arch == 'amd64')
|| (beta.kubernetes.io/os == 'linux' && beta.kubernetes.io/arch == 'amd64')

AFAIK I can grok it from kube docs, your nodeSelectorTerms  seems right. Unfortunately I don't have this sort of hybrid cluster at my hands right now so can't really test. I need to somehow "fake" such a cluster.

I made the changes mentioned and just tested them, building lens from source and installing and uninstalling the metrics 5 or 6 times, killing off the kube-state-metrics-... pod 2 or 3 times each install.
That pod always ended up on an amd64 node on my k3s cluster version: v1.18.3+k3s1.


Configure Azure Pipelines

Pull

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: abhishekp90 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


getOfferings() response empty?

First off, thanks for forking and creating this capacitor plugin! It came at the perfect time in our app development.
I can't seem to get the offerings call to return anything though, despite having offerings and entitlements set up in Revenue Cat. Not sure if this is a bug in this plugin, something I'm doing wrong, or something I need to contact RevenueCat support about?
Am I using this correctly?

import { CapacitorPurchases } from 'capacitor-purchases';

CapacitorPurchases.setDebugLogsEnabled({ enabled: true });
await CapacitorPurchases.setup({ apiKey: API_KEY });
let { offerings } = await CapacitorPurchases.getOfferings();
console.log(offerings) // => {}

in both android and ios ?
i use it my app and don't have this issue

@jkeen did you have special price in your offering ?
i got the same issue 2 days ago and fixed it, is was json conversion issue, can you check ?

Looks like that was it, offerings now loading correctly 👍🏻


Update implicit optional tests for coverage

Summary
Update implicit optional tests for coverage.
On main, the cases where there is only a single element in the subscript
list was giving false postivies such as for the following:
typing.Union[None]
typing.Literal[None]

Test Plan
cargo test

Current dependencies on/for this PR:

main

PR #5601

PR #5717   👈

This comment was auto-generated by Graphite.