Add "raw" flag equivalent for JQ

Hello! Thank you for the amazing work :)
I would like to suggest the possibility to output a string using JQ but with the equivalent of "-r" or "--raw" we can find on the official jq command: this allows to get a clean output for a single field for example, instead of having to sanitize it by doing some triming.
What do you think?
Thanks!

Nice suggestion, @LorisFriedel! Can you give a brief example of a program like this, showing how you'd like this behaviour to work?

For example, I would ideally do this to find a single element in a json object and use it directly:
nodeName, err := script.
		Exec("kubectl get pod myPod -o json").
		JQRaw(".spec.nodeName").
		String()

// output would be: xxx-ffkch-something-e32as-someregion-gsbn4

Today, that's what I need to do:
nodeName, err := script.
		Exec("kubectl get pod myPod -o json").
		JQRaw(".spec.nodeName").
		String()

// output is: "xxx-ffkch-something-e32as-someregion-gsbn4"\n

nodeName = strings.Trim(strings.TrimSpace(nodeName), "\"") // extra step to sanitze the output
// output is then: xxx-ffkch-something-e32as-someregion-gsbn4

Maybe this could be done with a more general-purpose trim method—something like Trim?
nodeName, err := script.
		Exec("kubectl get pod myPod -o json").
		JQ(".spec.nodeName").
		Trim().
		String()
// output would be: xxx-ffkch-something-e32as-someregion-gsbn4

This could be, but the trim would need to strip spaces AND quotes, and that would make it a weird "Trim" method I guess, WDYT?

Maybe there's a better name for this...

Maybe just a Trim(cutset string) and TrimSpace() functions could be perfectly suited here, easy to implement and easy to understand as they match their strings.Trim and strings.TrimSpace equivalent! WDYT?

I'd like to gather a bit more data on exactly how people are using JQ within script programs, so that we can come up with an API which fits well in that context. So if you're reading this issue and you have a program that uses jq queries, please post it in a comment!

Hi @bitfield,

I'd like to gather a bit more data on exactly how people are using JQ within script programs, so that we can come up with an API which fits well in that context. So if you're reading this issue and you have a program that uses jq queries, please post it in a comment!

I cannot speak for every jq user out there however, using jq with the -r command-line switch is definitely a thing, as otherwise, you often have to resort to some sed, grep or awk invocation to remove the unwanted quoting and/or newlines.

using jq with the -r command-line switch is definitely a thing

I believe you, but we need a realistic example to use as the input to the design process.

Hi @bitfield,

using jq with the -r command-line switch is definitely a thing

I believe you, but we need a realistic example to use as the input to the design process.

Thinking about it some more... I wouldn't do it.
Adding some convenience functions like Trim() or Strip(), and also Tr() might be a better alternative - new API could be easily reused somewhere else, other than removing bloat from jq's output.

Anything like Trim(), Strip() and such would save a lot a painful code handling those polluted outputs indeed!

Is there any example you can think of where a 'trim spaces and quotes' method would be used with anything other than JQ?

For the "trim quote" part, not really, but for the "trim space" part I guess everywhere where Fprintln() function is used in the library could be a good candidate, as when getting the output of something you generally don't want additional whitespace that serves no purposes!

An example use case (aside from using it for JQ): working with a result of a process spawned with Exec() to clean up output from the external process.

The problem I see is that a Trim method specialised for trimming jq output most likely wouldn't be much use for anything else.
Conversely, a Trim method that's configurable enough to trim both jq data and a variety of other cases would probably require an inconvenient amount of paperwork.
It's possible that we could get the best of both worlds, by providing a Trim method that performs general-purpose substitution, like tr, and also a "raw mode" for JQ that could use Trim under the hood.

Hi @bitfield,

An example use case (aside from using it for JQ): working with a result of a process spawned with Exec() to clean up output from the external process.

The problem I see is that a Trim method specialised for trimming jq output most likely wouldn't be much use for anything else.

Not if we make it generic. I can see it being useful as a handy function that can be used to rid something in the pipeline, so to speak, of whitespaces and such.

Conversely, a Trim method that's configurable enough to trim both jq data and a variety of other cases would probably require an inconvenient amount of paperwork.

What if we kept it simple? Like String#strip as an example from Ruby.

It's possible that we could get the best of both worlds by providing a Trim method that performs general-purpose substitution, like tr, and also a "raw mode" for JQ that could use Trim under the hood.

Or... Tr() and Strip(), simply.
Users of JQ can then use either depending on their needs. Unless you do want to have JQ() and JQRaw().
Thoughts?

Well, it's not just whitespace that needs to be removed from the JQ data; it's quotes, too. A Strip method that worked like Ruby's String#strip wouldn't do that, I suppose. So we couldn't write this:
script.Echo(data).JQ(query).Strip().Stdout()

On the other hand, suppose there were some method Translate (Tr means nothing unless you already know Unix), that worked like tr, we'd have to write:
script.Echo(data).JQ(query).Translate(" \"", "").Stdout()

...which is a lot to have to write after every call to JQ.
As I say, cleaning up JQ data is such a specific task that I can't see a no-argument method to do it being useful for anything else.

Hi @bitfield,

Well, it's not just whitespace that needs to be removed from the JQ data; it's quotes, too. A Strip method that worked like Ruby's String#strip wouldn't do that, I suppose. So we couldn't write this:
script.Echo(data).JQ(query).Strip().Stdout()

The idea to add Strip() was not strictly related to JQ(), but more as a generic function (a helper, if you wish) that could be used here and elsewhere to remove leading and trailing whitespaces.

On the other hand, suppose there were some method Translate (Tr means nothing unless you already know Unix), that worked like tr, we'd have to write:
script.Echo(data).JQ(query).Translate(" \"", "").Stdout()

...which is a lot to have to write after every call to JQ.

I see your point. OK. To keep it simple and retain the same ergonomics as other functions, introducing JQRaw() next to JQ() might be a good idea then.

As I say, cleaning up JQ data is such a specific task that I can't see a no-argument method to do it being useful for anything else.

The Strip() and Translate() were intended to be as generic as possible so that both could find use in different places too.

This could be, but the trim would need to strip spaces AND quotes, and that would make it a weird "Trim" method I guess, WDYT?

The GoLang string.Trim routine takes a cutlist which can trim multiple different characters. I don't think it would be weird at all.

Is there any example you can think of where a 'trim spaces and quotes' method would be used with anything other than JQ?

I would use the ability to time not only spaces and quotes, but a lot of other things, in an application like an HTML scraper. I frequently do this -- scrape 1,000 similar pages, strip out data from tables, for example.

Right, but if we had (for example) JQRaw, or equivalent, would we really need a general-purpose Trim method? What for?

I would use Trim to remove unwanted characters either from the start, the end, or both ends of a string.

Yes, understood, but why would you need to do that? In what real-world application would you need to trim specific characters from either end of a string? Don't take this as a challenge—I'm not saying there's no use case for this—but as an invitation to contribute suggestions for ways this feature might be used.
If a number of intelligent, experienced people cannot, in practice, think of any situation in which they would really use this feature, then I'm happy to leave the feature out. The best tools tend to be the ones that aren't bloated with unnecessary features.

Thanks @ John for your great work on script. I am also in the same kind of questions like you guys. On my side I am regularly using jq to quickly strip some json payload. In my case, I am using jq -r to use the raw possibility (no quotes around attributes).  For example :   echo '{ "ip": "<IP_ADDRESS>"}' | jq -r .ip will give <IP_ADDRESS>. There are a lot of args with the jq and almost the same with the gojq that use in JQ. I try to find a workaround to pass arguments to the JQ implementation (but I didn't succeed) or to define arguments thru environment variables. Did you you try this path ?

Yes but you will add a new function to your script list. I am not sure this is what you want ... Also as I mentioned there are many other parameters that I use like the S (slurp) or the -C for instance. But again, after reading the argument list in gojq,  this may be not a good idea to get access to some parameters. So yes why not JQr or JQraw ... Simple and easy. However I also like the idea to have a kinda generic "translator" in your set of functions. Thanks anyway.

It doesn't look like gojq has an easy way to get "raw" results, so now I'm leaning towards something like Trim for cleaning up the output.

You can do exactly this with FilterLine (for example):
script.File(path).JQ(".ip .host").FilterLine(func (s string) string {
  return strings.Trim(s, `"`)
}.String()


Improve Release Automation

Migrate GitHub release notes to a KeepAChangelog and automate releases somehow using:

https://github.com/crate-ci/cargo-release
https://github.com/taiki-e/create-gh-release-action

And while at it might as well add a CI step for clippy/rustfmt/testing stuffs.

the release two actions have been added, I'll leave the other ci stuffs for another issue


[eventgrid] Fix nightly Min/Max CI issues

Similar to #19862, we have recently started to see some issues in our
nightly min/max jobs that prevent us from saving the entire Response
object during the onResponse callback due to multiple imports of the
"same" type.
Similar to the resolution for #19862, I've decided to just not use
nominal types from core-client here and instead just stash away the
parts of the response I need inside the callback and observe the
values after.
Fixes #20014

/azp run eventgrid - js - tests

/azp run js - eventgrid - tests

/azp run js - eventgrid - tests


Small changes to Idea settings

use Java 8 in IntelliJ
fix a missing space before the URL in the copyright header defined in IntelliJ

Coverage remained the same at 80.159% when pulling 0a409c17b9550b6a26f75591a000d28ce08bab60 on sclassen:useJava8 into 795c2420840ab405a3307fa7f38341c1a868caba on aalmiray:master.


Geo stack image

Looks like the following got committed unintentionally  in my initial commit (8ba801a). I will revert.

[standard-cnpg/Dockerfile]
[tembo-pg-slim/Dockerfile]


US04: The user who sent the request is informed of the decision made by the other user.

Closed with commit b9a4c6e05f5f04c1afdf600a9fc24079b622d910


Handle special key combinations (like "shift+enter") that curses doesn't understand.

Currently we rely heavily on curses.key_name which isn't optimal. That function doesn't distinguish between input like enter and shift+enter. We should try to detect the special cases first and only then pass the code to curses.key_name if necessary.

I have a fix for this, but unfortunately it seems like some terminals don't send the "shift+enter" key code at all (the key code is 343). It might be that many special key bindings are only supported on some terminals. It's also worth noting that terminal emulators specify key bindings for their own functions (like switching tabs) that don't get sent to Suplemon at all. Therefore it might be hard to implement all key bindings reliably. :/

Done in release v0.1.56


Possible OOM with large servlet response

Hi,
I'm reading the source code and just wondering that why there is no size limit when writing to the branched OutputStream? What if there is a really large HTTP response? Then the whole thing will be stuck inside a ByteArrayOutputStream which will easily use up all your memory. Also there is a configuration property called "logbook.write.max-body-size". You would think that it should be able to put an upper limit to the memory footprint no matter the size of the actual HTTP response body, but looks like it did not.
https://github.com/zalando/logbook/blob/af6f818f4fcc17167f2508abe9eb8f81eb8148b8/logbook-servlet/src/main/java/org/zalando/logbook/servlet/LocalResponse.java#L285

You have a point here, as the response is copied in LocalResponse classes, the allocation of memory is doubled. We could use the max-body-size to enforce a limit, let's say, counting the worst case scenario, that 4 bytes are used per character.
I'm not sure how big of a risk this is. Who would enable response body logs for cases when it can be that big? Even truncation of the body doesn't make sense here.

Well, here is our story.
We use logbook in a legacy Spring 4.x system and we have a LogFilter for URL pattern "/*". We also have a max-body-size in place. Everything was fine for a couple of years, util a recent deployment. A file downloading functionality was added by one of our team members. And then with some users downloading files > 2GB, our server just exploded :(
I think the real risk is that the "max-body-size" configuration made everybody thought that it should be safe to Filter /*. But actually it's not.

Are you sure about the predicate already operating on a buffered request?
It used to be the case that predicates run before buffering and are
therefore cheap. There are defaults to exclude binary content types, iirc.
On Sun, Feb 18, 2024, 12:41 Karen Asmarian @.***> wrote:

After some internal discussions with the team, it doesn't look like we'll
be able to address this fully without changing how Logbook works entirely.
The problem is that Logbook buffers the requests and responses not only in
servlets implementation, but for all the HTTP clients and other server
types.
Another problem is that Logbook predicates evaluate the request/response
already after this buffering is made, as the request/response are converted
to the internal types at the same time. So you can't exclude the paths,
where you send the big payloads from the buffering path, really.
What you could potentially do for your case for now is writing your own
Filter implementation, where you exclude certain paths before calling
Logbook.
—
Reply to this email directly, view it on GitHub
https://github.com/zalando/logbook/issues/1754#issuecomment-1951212919,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADI7HOYZB5IZEDXJYFPSU3YUHSFDAVCNFSM6AAAAABCSTX462VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGIYTEOJRHE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Ah, @whiskeysierra is right, the buffering will be used only if the request is eligible for the logging.
Do you think it would help if we mention that logbook.write.max-body-size only affect the size of the output, but does not prevent the buffering of the body?
Another possible suggestion for @wintermute0 I can think of is to define a custom Strategy, if you still want to log response when customers download files, but to not log the body.
As per the defaults to exclude binary content types, as far as I can tell, FilteredHttpResponse still retrieves the body from the org.zalando.logbook.HttpResponse when getBodyAsString is called. So the buffering would still happen, even through the body will not be logged, if the ResponseFilter is configured to skip the body.

I think it would definitely help to mention the buffering behavior in the documentation for logbook.write.max-body-size. As for our particular use case we have already found a way to exclude the download request from logging. Thanks for your help :)

@wintermute0 Can you share the way that you excluded the download request? We have the same problem but get stuck in the property/configuration/bean swamp :-)


Token could not be auto-discovered for zhimi.airpurifier.v3

$ miio --discover
 INFO  Discovering devices. Press Ctrl+C to stop.

Device ID: 420693
Model info: zhimi.airpurifier.v3 (air-purifier)
Address: <IP_ADDRESS> (zhimi-airpurifier-v3_miio420693)
Token: ???
Support: At least basic

Sorry about that, i reset the device, the token was been generated.


Add fallback to support rc1 keys

https://github.com/aspnet/DataProtection/issues/153

/cc @blowdart

/cc @anurse @BrennanConroy

Looks alright

No more lost data. Woohoo. :shipit:

Curious: why not just providing a tool replacing the old namespace by the new one in the keys?

Because not everyone has command line access to the machines where the keys are. Like, oh, Azure Web Sites ...

Like, oh, Azure Web Sites ...

The same people whose RC1 app was badly broken when RC2 was released? :smile:
This PR will only help people migrating from RC1 to RTM. Is it really worth it?

Yes, it is.


Make a .git page available for viewing all projects

Requirements

Usage of the GitHub provided api to add an option to showcase hit projects and make it available as a partial tht can be added onto any page
optional: add interface or block that allows users to add specific repositories as components to pages

@anirudhsudhir suggest any changes?

lgtm, let's update as requirements change


Improve docfx_project/docs/index.md

PuppeteerSharp is a great service thank you.
After this latest updated however, I have noticed my existing code which takes an HTML page and converts it to PDF no longer works. It is failing on the browser fetcher. If the documentation could provide an example for how to change that and get the code working like before without a browser fetcher that would be sweet! Look forward for an update, thanks in advance!

Are you having a similar error to mine in #2785 ?

@AlexMata260 what error are you getting?


Task/43 - [BUG] Issue with displaying LaunchScreenActivity on diffrent screens

1. Created new 3 layouts for landscape, smaller screens and tablets screens for LaunchScreenActivity, Examples:

/\ small screen

/\ tablet

/\ Pixel 6 landscape

/\ Pixel 6 portrait
2. Created missing annotaion about LaunchScreenActivity in AndroidManifest.

Added changes: one xml file, added guidelines etc.
Small screen:

Tablet:

Phone (Pixel 6):


Add M1100 to auto-fire guns list

Fixes https://github.com/Kalaborative/survivio-plus/issues/150 and https://github.com/Kalaborative/survivio-plus/issues/151

Added the M1A1 gun as well. Cheers!


TypeError: Cannot read property 'push' of undefined

Noticed this in my selfhost web log:
ERR Cannot read property 'push' of undefined: TypeError: Cannot read property 'push' of undefined
    at g.addMatch (http://localhost:9777/static/out/vs/workbench/workbench.web.api.js:3912:755)
    at http://localhost:9777/static/out/vs/workbench/workbench.web.api.js:3913:946
    at Array.forEach (<anonymous>)
    at p.handleFindMatch (http://localhost:9777/static/out/vs/workbench/workbench.web.api.js:3913:856)
    at u.$handleFileMatch (http://localhost:9777/static/out/vs/workbench/workbench.web.api.js:3912:213)
    at g._doInvokeHandler (http://localhost:9777/static/out/vs/workbench/workbench.web.api.js:3572:464)
    at g._invokeHandler (http://localhost:9777/static/out/vs/workbench/workbench.web.api.js:3572:156)
    at g._receiveRequest (http://localhost:9777/static/out/vs/workbench/workbench.web.api.js:3570:817)
    at g._receiveOneMessage (http://localhost:9777/static/out/vs/workbench/workbench.web.api.js:3569:623)
    at http://localhost:9777/static/out/vs/workbench/workbench.web.api.js:3567:821

Looking at the number of "!" used, I am not surprised:
https://github.com/microsoft/vscode/blob/12215af89154f3b3eaeb92e7dc77fa7d024b47de/src/vs/workbench/api/browser/mainThreadSearch.ts#L86

Thanks. Have some types shared between file and text search where they really shouldn't be, especially after strict null checking


New Error ->error[E0599]: no method named as_mut_ptr found for struct AtomicU64 in the current scope

Some of the details are:
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.69.0-nightly (31f858d9a 2023-02-28)
info: checking for self-updates
Updating git repository https://github.com/Kindelia/HVM.git
Installing hvm v1.0.2 (https://github.com/Kindelia/HVM.git#573e9e2d)
Updating crates.io index
.
.
Compiling instant v0.1.12
Compiling hvm v1.0.2 (/home/verbus/.cargo/git/checkouts/hvm-a2339bb8b9261392/573e9e2)
error[E0599]: no method named as_mut_ptr found for struct AtomicU64 in the current scope
--> src/runtime/base/memory.rs:450:54
|
450 |         let val = heap.node.get_unchecked(*lvar.next.as_mut_ptr() as usize).load(Ordering::Relaxed);
|                                                      ^^^^^^^^^^ help: there is a method with a similar name: as_ptr
For more information about this error, try rustc --explain E0599.
error: could not compile hvm due to 14 previous errors
error: failed to compile hvm v1.0.2 (https://github.com/Kindelia/HVM.git#573e9e2d), intermediate artifacts can be found at /tmp/cargo-installsTN1UZ
This was the script the above was run from:
#!/usr/bin/env bash
rustup install nightly
cargo +nightly install --force --git https://github.com/Kindelia/HVM.git

This PR in Rust nightly changed the name of this function to just as_ptr. I'll send a fix in a moment

@verbus can you check that it works for you now?


feat: tag '&' query

Support draft <insert_nip> for querying tags with AND instead of OR operation.
This branch also greatly improves the query performace of tags by using JOIN on top level query, see query plan:
NEW

OLD

AND query plan:

I drafted nip for this a while back, but wasn't in the mood for nips so never published it. Someone please do this.

I drafted nip for this a while back, but wasn't in the mood for nips so never published it. Someone please do this.

Yep thats basically what i have here instead of # to prefix the tag key you use &
["REQ", "a", { "kinds": [2003], "&t": ["movie","4k"] }]

Which is to say that you would like kind: 2003 events having both movie and 4k tags

I'll publish the PR for the NIP this week, is this ready for review?

it supports only sqlite, and posgres is mocked out on the branch. Needs some more refactoring in the experimental postgres code to make postgres also work. Except from the postgres support, it's ready.

Is there a blocker for postgres support or was it just not started/completed?

It was only implemented in postgres, it also needs to be added to sqlite code, nothing blocking adding it for sqlite

It was only implemented in postgres, it also needs to be added to sqlite code, nothing blocking adding it for sqlite

Yes, @v0l made an implementation for postgres only. Then I wanted to use that, but I found it's easier to port that to sqlite than to adopt postgres code to the new master branch, so I went with sqlite.
If someone resolves the conflicts between the postgres code and master, it should be fine. I used the same datastructures in the common code what @v0l 's postgres commit used.


Set an object's default version to 1 when it is created,…

…rather than when it is stored, to allow undef versions (which can then be stored as NULLs in the database).

Coverage increased (+0.02%) to 81.852% when pulling 56f2d59f813ad791444dae160b3ff1dd5b239749 on james-monkeyshines:master into 985f2e3665ea4ffa98e6e70bfb272d31ec6a6065 on Ensembl:master.

that looks fine to me, thanks for the change


Sporadic crashes in the vmware_fs driver

The current vmware_fs implementation seems to be quite buggy, and fails under extensive usage:
Crash 1:
PANIC: Unexpected exception "General Protection Exception" occurred in kernel mode! Error code: 0x0

stack trace for thread 2553 "cp"
    kernel stack: 0xffffffff81bd5000 to 0xffffffff81bda000
      user stack: 0x00007f4cad8c1000 to 0x00007f4cae8c1000
frame                       caller             <image>:function + offset
…
11 ffffffff81bd95e0 (+ 240) ffffffff800ab0f7   <kernel_x86_64> panic + 0xb7
12 ffffffff81bd96d0 (+ 224) ffffffff801502b8   <kernel_x86_64> x86_unexpected_exception + 0x168
13 ffffffff81bd97b0 (+ 872) ffffffff8014692c   <kernel_x86_64> int_bottom + 0x80
kernel iframe at 0xffffffff81bd9b18 (end = 0xffffffff81bd9be0)
 rax 0xffffffff81bd3c90    rbx 0xffffffff9a09a520    rcx 0x0
 rdx 0x9                   rsi 0xffffffff9a09a520    rdi 0x64616f6c6e776f64
 rbp 0xffffffff81bd9c00     r8 0x0                    r9 0x6f8
 r10 0x0                   r11 0xffffffff8e19d000    r12 0xffffffff9a09a520
 r13 0xffffffff9a304000    r14 0xffffffff9a35f938    r15 0xffffffff9a304000
 rip 0xffffffff81bc2b0d    rsp 0xffffffff81bd9be0 rflags 0x10202
 vector: 0xd, error code: 0x0
14 ffffffff81bd9b18 (+ 232) ffffffff81bc2b0d   </boot/system/add-ons/kernel/file_systems/vmwfs> VMWNode::~VMWNode() + 0x57
15 ffffffff81bd9c00 (+  32) ffffffff81bc2b27   </boot/system/add-ons/kernel/file_systems/vmwfs> VMWNode::~VMWNode() + 0x11
16 ffffffff81bd9c20 (+  64) ffffffff81bc2e41   </boot/system/add-ons/kernel/file_systems/vmwfs> VMWNode::DeleteChildIfExists(char const*) + 0x55
17 ffffffff81bd9c60 (+  32) ffffffff81bc3e5d   </boot/system/add-ons/kernel/file_systems/vmwfs> vmwfs_remove_vnode(fs_volume*, fs_vnode*, bool) + 0x38
18 ffffffff81bd9c80 (+  64) ffffffff800fad65   <kernel_x86_64> free_vnode(vnode*, bool) + 0x185
19 ffffffff81bd9cc0 (+  80) ffffffff800fb47c   <kernel_x86_64> dec_vnode_ref_count(vnode*, bool, bool) + 0x2ac
20 ffffffff81bd9d10 (+ 144) ffffffff800fd696   <kernel_x86_64> vnode_path_to_vnode(vnode*, char*, bool, int, io_context*, vnode**, long*) + 0x156
21 ffffffff81bd9da0 (+  80) ffffffff800fdd9c   <kernel_x86_64> () + 0x3c
22 ffffffff81bd9df0 (+  48) ffffffff80104d51   <kernel_x86_64> common_path_read_stat(int, char*, bool, stat*, bool) + 0x21
23 ffffffff81bd9e20 (+ 256) ffffffff801094d5   <kernel_x86_64> _user_read_stat + 0x135
24 ffffffff81bd9f20 (+  16) ffffffff80146c38   <kernel_x86_64> x86_64_syscall_entry + 0xfe

Crash 2:
PANIC: vm_page_fault: unhandled page fault in kernel space at 0xffffffff0072616e, ip 0xffffffff81c40e1a

Welcome to Kernel Debugging Land...
Thread 2577 "python3" running on CPU 0
stack trace for thread 2577 "python3"
    kernel stack: 0xffffffff81c53000 to 0xffffffff81c58000
      user stack: 0x00007f86153f9000 to 0x00007f86163f9000
frame                       caller             <image>:function + offset
…
 4 ffffffff81c575d0 (+ 240) ffffffff800ab0f7   <kernel_x86_64> panic + 0xb7
 5 ffffffff81c576c0 (+ 240) ffffffff80132420   <kernel_x86_64> vm_page_fault + 0x260
 6 ffffffff81c577b0 (+  64) ffffffff8014feb0   <kernel_x86_64> x86_page_fault_exception + 0x160
 7 ffffffff81c577f0 (+ 888) ffffffff8014692c   <kernel_x86_64> int_bottom + 0x80
kernel iframe at 0xffffffff81c57b68 (end = 0xffffffff81c57c30)
 rax 0xffffffff99f262d0    rbx 0xffffffff99f262d0    rcx 0xe
 rdx 0x4                   rsi 0xffffffff99f262d0    rdi 0xffffffff9a103758
 rbp 0xffffffff81c57c60     r8 0x0                    r9 0x38
 r10 0x0                   r11 0xffffffff8e19d000    r12 0xffffffff99f262d0
 r13 0x0                   r14 0xffffffff9a103758    r15 0xffffffff00726166
 rip 0xffffffff81c40e1a    rsp 0xffffffff81c57c30 rflags 0x10282
 vector: 0xe, error code: 0x0
 8 ffffffff81c57b68 (+ 248) ffffffff81c40e1a   </boot/system/add-ons/kernel/file_systems/vmwfs> VMWNode::DeleteChildIfExists(char const*) + 0x2e
 9 ffffffff81c57c60 (+  32) ffffffff81c41e5d   </boot/system/add-ons/kernel/file_systems/vmwfs> vmwfs_remove_vnode(fs_volume*, fs_vnode*, bool) + 0x38
10 ffffffff81c57c80 (+  64) ffffffff800fad65   <kernel_x86_64> free_vnode(vnode*, bool) + 0x185
11 ffffffff81c57cc0 (+  80) ffffffff800fb47c   <kernel_x86_64> dec_vnode_ref_count(vnode*, bool, bool) + 0x2ac
12 ffffffff81c57d10 (+ 144) ffffffff800fd6f6   <kernel_x86_64> vnode_path_to_vnode(vnode*, char*, bool, int, io_context*, vnode**, long*) + 0x1b6
13 ffffffff81c57da0 (+  80) ffffffff800fdd9c   <kernel_x86_64> () + 0x3c
14 ffffffff81c57df0 (+  48) ffffffff80104d51   <kernel_x86_64> common_path_read_stat(int, char*, bool, stat*, bool) + 0x21
15 ffffffff81c57e20 (+ 256) ffffffff801094d5   <kernel_x86_64> _user_read_stat + 0x135
16 ffffffff81c57f20 (+  16) ffffffff80146c38   <kernel_x86_64> x86_64_syscall_entry + 0xfe

Crash 3:
vm_page_fault: vm_soft_fault returned error 'Bad address' on fault at 0x8, ip 0xffffffff81fe1ee3, write 0, user 0, thread 0x936
PANIC: vm_page_fault: unhandled page fault in kernel space at 0x8, ip 0xffffffff81fe1ee3

stack trace for thread 2358 "bash"
    kernel stack: 0xffffffff81fc2000 to 0xffffffff81fc7000
      user stack: 0x00007fa1ca357000 to 0x00007fa1cb357000
frame                       caller             <image>:function + offset
…
11 ffffffff81fc6790 (+ 240) ffffffff800ab0f7   <kernel_x86_64> panic + 0xb7
12 ffffffff81fc6880 (+ 240) ffffffff80132420   <kernel_x86_64> vm_page_fault + 0x260
13 ffffffff81fc6970 (+  64) ffffffff8014feb0   <kernel_x86_64> x86_page_fault_exception + 0x160
14 ffffffff81fc69b0 (+ 904) ffffffff8014692c   <kernel_x86_64> int_bottom + 0x80
kernel iframe at 0xffffffff81fc6d38 (end = 0xffffffff81fc6e00)
 rax 0xffffffff9a01e770    rbx 0xffffffff9a01e770    rcx 0x73
 rdx 0x0                   rsi 0xffffffff99ff401a    rdi 0xffffffff9a01e5f0
 rbp 0xffffffff81fc6e30     r8 0x3                    r9 0x38
 r10 0x0                   r11 0x1f4                 r12 0xffffffff99ff401a
 r13 0x0                   r14 0xffffffff9a0c5e18    r15 0xffffffff9a0c5e18
 rip 0xffffffff81fe1ee3    rsp 0xffffffff81fc6e00 rflags 0x10282
 vector: 0xe, error code: 0x0
15 ffffffff81fc6d38 (+ 248) ffffffff81fe1ee3   </boot/system/add-ons/kernel/file_systems/vmwfs> VMWNode::GetChild(char const*) + 0x73
16 ffffffff81fc6e30 (+  80) ffffffff81fe113a   </boot/system/add-ons/kernel/file_systems/vmwfs> vmwfs_read_dir(fs_volume*, fs_vnode*, void*, dirent*, unsigned long, unsigned int*) + 0x79
17 ffffffff81fc6e80 (+  64) ffffffff800fdbae   <kernel_x86_64> dir_read(io_context*, file_descriptor*, dirent*, unsigned long, unsigned int*) + 0x4e
18 ffffffff81fc6ec0 (+  96) ffffffff800ec0d6   <kernel_x86_64> _user_read_dir + 0xd6
19 ffffffff81fc6f20 (+  16) ffffffff80146c38   <kernel_x86_64> x86_64_syscall_entry + 0xfe

The problem seems to be in the VMWNode children management logic, it looks like some nodes are used after their memory has been freed.

Looking at the code, I would say it requires a major refactoring in a few places like VMWSharedFolders and VMWNode. It might be worth trying to port open-vm-tools instead (or at least their hgfs implementation).

What kind of refactoring is needed?

It might be worth trying to port open-vm-tools instead (or at least their hgfs implementation).

It's actually too much work as open-vm-tools has a lot of components to port.

What kind of refactoring is needed?

First of all, there's a user after free bug somewhere in the code, which I wasn't able to find.
To simplify debugging and fixing of issues like that it makes sense to rewrite the filesystem driver as UserlandFS/FUSE (FUSE implementation from open-vm-tools might provide some help there), also the VmWare filesystem version is quite old, and that would also need to be updated (again, using the headers from the open-vm-tools, they can be reused here without license violations).

There seems to be a working driver from open-vm-tools ported to Haiku here https://github.com/trungnt2910/open-vm-tools

The FUSE driver from that port is known to work. That said, there are some certain quirks (I can't remember what since it's been quite a while since I used that driver myself).
The port itself has a few stubs here and there, for example in scripts/haiku/network. There may be some other stubs I have forgotten that might or might not affect hgfs driver.

The filesystem driver doesn't appear to use any locking at all. That's probably the source of the crashes.

The FUSE driver from that port is known to work. That said, there are some certain quirks (I can't remember what since it's been quite a while since I used that driver myself).

Well done! Would you be up for upstreaming it? The open-vm-tool team welcomes porting the project to new operating systems.

Would @trungnt2910's port be recommended over these add-ons in general at this point?  Is a recipe available?


Adding a TransactionInterceptor

Adding a TransactionInterceptor. It will set the request attribute as transaction so that we dont need to get transaction separately in all the calls.
JIRA Ticket Number
Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Infrastructure change

Pull request checklist

[ ] I have added unit tests for new code that I have added
[ ] I have added/updated functional tests where appropriate
[ ] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: No security warnings found

CI: No security warnings found


Leetcode Question Number 1825

Leetcode Question Number 1825 solution needs to be added in the repo .
The link for the question is this.
Accepted Languages C++ / JAVA .
You Only need to add the  class Solution in the file.
Make Sure you have read the contributions guidelines before creating an PR.

assign


[BUG] minirocket doesn't support unequal-length

Describe the bug
although the documentation states "Input data, any number of channels, equal length series of shape ( n_cases, n_channels, n_timepoints) or list of numpy arrays (any number of channels, unequal length series) of shape [n_cases], 2D np.array (n_channels, n_timepoints_i), where n_timepoints_i is length of series i", the class wont fit data of type list length N, containing np arrays of size (2XM[i]).
Steps/Code to reproduce the bug
No response
Expected results
it should run..
Actual results
it doesnt run..
Versions
1.0.0

Hey, thanks for raising the issue, could you provide an example code to reproduce the issue or the code you used?


Included algorithm integration tests in core to allow easy reuse

To test a new platform, there is one test class for each algorithm that needs to be extended. For each algorithm there are two functions to run the platform-specific implementation on either directed or undirected example graphs.
First step towards completing #35. Will migrate Giraph, GraphX, Neo4j in separate PRs, and will implement #25 using this framework.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.tribler.org//job/Graphalytics_pull_request_tester/11/
Test PASSed.


run sqlc via go run without install

Is it possible to add the option to run sqlc via go run github.com/kyleconroy/sqlc generate?
Similar to the way gqlgen can be used (https://github.com/99designs/gqlgen#quick-start).
This has the advantage that everyone working on the project has uses the same version (added to the go.mod file) and no installation is needed.

You can use go:generate in your dependent go file and run go generate && go build
//go:generate sqlc generate

I know, that it is possible like this, but this way you still need to install sqlc manually.
The advantage the way gqlgen is using has, is that everybody working on the project uses the same version of sqlc and no installation is required.
I would also use it with go:generate like this:
//go:generate go run github.com/kyleconroy/sqlc generate
and add a "_ import" in my tools.go

You can do this today, but you need to use the correct import path.
go run github.com/kyleconroy/sqlc/cmd/sqlc@latest generate


Tag OAuthSwift with "1.2.2" and tag OAuthSwiftAlamofire with "0.2.0"

Description:
The latest release of OAuthSwift is 1.2.1 was made 4 Feb 2018.
When I do pod lib lint with my own cocoapod, then I'm seeing warnings related to OAuthSwift and OAuthSwiftAlamofire.
- WARN  | xcodebuild:  OAuthSwift/Sources/Int+OAuthSwift.swift:29:18: warning: 'deinitialize()' is deprecated: the default argument to deinitialize(count:) has been removed, please specify the count explicitly
- WARN  | xcodebuild:  OAuthSwift/Sources/Int+OAuthSwift.swift:30:18: warning: 'deallocate(capacity:)' is deprecated: Swift currently only supports freeing entire heap blocks, use deallocate() instead
- WARN  | xcodebuild:  OAuthSwift/Sources/String+OAuthSwift.swift:93:38: warning: 'IndexDistance' is deprecated: all index distances are now of type Int
- WARN  | xcodebuild:  OAuthSwift/Sources/String+OAuthSwift.swift:98:40: warning: 'IndexDistance' is deprecated: all index distances are now of type Int
- WARN  | xcodebuild:  OAuthSwift/Sources/SHA1.swift:142:104: warning: 'IndexDistance' is deprecated: all index distances are now of type Int
- WARN  | xcodebuild:  OAuthSwift/Sources/SHA1.swift:142:140: warning: 'IndexDistance' is deprecated: all index distances are now of type Int
- WARN  | xcodebuild:  OAuthSwift/Sources/SHA1.swift:144:22: warning: 'IndexDistance' is deprecated: all index distances are now of type Int
- WARN  | xcodebuild:  OAuthSwift/Sources/String+OAuthSwift.swift:49:22: warning: 'init' is deprecated: Please use String or Substring directly
- WARN  | xcodebuild:  OAuthSwift/Sources/String+OAuthSwift.swift:49:29: warning: 'characters' is deprecated: Please use String or Substring directly
- WARN  | xcodebuild:  OAuthSwift/Sources/Utils.swift:13:33: warning: 'characters' is deprecated: Please use String or Substring directly
- WARN  | xcodebuild:  OAuthSwift/Sources/Utils.swift:19:30: warning: 'characters' is deprecated: Please use String or Substring directly

In my-own-pod.podspec it looks like this:
s.dependency 'OAuthSwift', '~> 1.2.0'
s.dependency 'OAuthSwiftAlamofire'

I can't switch to OAuthSwift 1.2.1, because that breaks OAuthSwiftAlamofire.
I made another issue on OAuthSwiftAlamofire, where I'm more or less writing the same as in this issue.
OAuth Provider? (Twitter, Github, ..):
3rd party provider
OAuth Version:

[ ] Version 1
[x] Version 2

OS (Please fill the version) :

[x] iOS :
[ ] OSX :
[ ] TVOS :
[ ] WatchOS  :

Installation method:

[ ] Carthage
[x] CocoaPods
[ ] Manually

Library version:

[x] head
[x] v1.2.1
[ ] v1.2 (Swift 4.0)
[ ] v1.0.0
[ ] v0.6
[ ] other: (Please fill in the version you are using.)

Xcode version:

[x] 9.4 (Swift 4.1)

[ ] 9.3 (Swift 4.1)

[ ] 9.0 (Swift 4.0)

[ ] 9.0 (Swift 3.2)

[ ] 8.x (Swift 3.x)

[ ] 8.0 (Swift 2.3)

[ ] 7.3.1

[ ] other: (Please fill in the version you are using.)

[ ] objective c

Yes please, fix these deprecations/warnings 🙏🏻

you can use any commit hash or head in your Podfile
I cannot do it now (i am sick)

🎉  Congrats
🚀  OAuthSwift (1.2.2) successfully published
📅  June 26th, 11:55
🌎  https://cocoapods.org/pods/OAuthSwift
👍  Tell your friends!


What is the difference between or-tools and python-mip, e.g. performance, correctness?

or-tools claims the competition is consistently gold (https://developers.google.com/optimization) and python-mip claims to be the fastest open source linear programming solver (http://plato.asu.edu/ftp/lpsimp.html), so which one is faster?

Minizinc Challenge results: https://www.minizinc.org/challenge (CP-SAT Solver)

Please indicate when you cross post from stack overflow.


TRANSACTION_OVERSIZE

While Deploying My Contract I am getting this Error .
JAVA SDK Version 0.5.0

@patel512 could please try updating to the latest SDK, version 0.5.2, and let us know if this is still happening?

@patel512 That error code (if correctly returned and not a bug in the SDK) means that you need to break your contract byte code into chunks and submit in multiple FileAppend transactions.

@mehcode  I  breaked my code into parts and appended in multiple Transaction but now I am getting Error   INSUFFICIENT_GAS  even though  I have set my gas to<PHONE_NUMBER>0 and total no of line in my sc is  137

@mehcode any update on this facing the same issue INSUFFICIENT_GAS

Same here.

Can either @rahulasati or @publu run the example for this and see if you get the same error?

@abonander and I can't reproduce this so it's hard for us to help here. Our examples work and they seem to have a similar scenario to what you describe.
It would help and we could likely help you quikcly if you could PR an example that breaks with this issue.

@patel512 calling execute() alone does not get the final result of the transaction; if it returns successfully it just means the node has accepted it for processing. executeForReceipt() or execute()+queryReceipt() will get the final result of the transaction.

Please re-open if there is a specific issue with the SDK you're still experiencing.

Below is the code I use to handle chunking my 8.32 kB smart contract:
int MAX_FILE_SIZE = 4000
Hbar MAX_TX_FEE_CONTRACT = new Hbar(30)
// upload file (chunk if necessary):
        TransactionReceipt txReceipt_file = null;
        int nIters = (int) Math.ceil(evmBinary.getBytes().length/Helper.MAX_FILE_SIZE);
        System.out.println("File is " + String.format("%.2f", ((float)evmBinary.length()/1000)) + " kB long");
        System.out.println(nIters + " chunks will be uploaded");
        for(int i = 0; i <= nIters; i++) {
            int from = Helper.MAX_FILE_SIZE * i;
            int to = (i == nIters) ? from + evmBinary.getBytes().length % Helper.MAX_FILE_SIZE : Helper.MAX_FILE_SIZE * (i + 1);

            byte[] segment = Arrays.copyOfRange(evmBinary.getBytes(), from, to);

            if (i == 0) {
                // create a new file
                // save the file:
                var tx_file = new FileCreateTransaction();
                tx_file.setContents(segment);
                tx_file.addKey(operatorKey.publicKey);
                tx_file.setExpirationTime(Instant.now().plus(Duration.ofSeconds(7890000)));
                tx_file.setMaxTransactionFee(Helper.MAX_TX_FEE);

                TransactionId txId_file = tx_file.execute(client);
                txReceipt_file = txId_file.getReceipt(client);
                // print out the result:
                System.out.println("Result of file save:");
                System.out.println(txReceipt_file.status);
                System.out.println("File lives at: " + txReceipt_file.getFileId());
            } else {
                // append chunk to existing file
                System.out.println("Appending chunk: " + i + " (" + segment.length + " bytes)");
                new FileAppendTransaction().setFileId(txReceipt_file.getFileId())
                        .setMaxTransactionFee(Helper.MAX_TX_FEE)
                        .setContents(segment).execute(client);
            }
        }


Issue 1486: fixes disabled nested Nepo-block causes error

Description
This PR fixes the Issue that an error occurred when disabling a nested Nepo-block, which is not an instance of Expr, and trying generating the code.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
By running the integration tests and the following program
disabledBlocksTest.xml.txt

merged with 69b402ba83b09ad2b9e44f810c70ad9b8f4169cc


Data preprocess

Hello, I am very interested in your work and would like to process and reproduce your code from the raw data, so that I can do further research. I see that you mentioned in your paper that the data with a score of less than 3 in the Amazon-book and yelp datasets is filtered, and k-core is also filtered on Steam, can you provide the code about this part of preprocessing?

Hi 👋!
Thanks for your interests on RLMRec! Due to the complexity of the pre-processing code and its multi-file structure, it might be more helpful to provide a straightforward overview of the basic workflow for the pre-processing steps, as outlined below:

Score Filtering: Begin by filtering out low-score interactions (implemented using a for loop).
User Sampling (Discussion in Issue 9) Next, uniformly sample a ratio of users and remove items that have not been interacted with after filtering the users. This will help reduce the dataset size (implemented with boolean vectors).
K-Core Filtering: Finally, apply k-core filtering using the NetworkX library.

I hope the above answer is helpful to you :)
Best regards,
Xubin

Hi 👋!
Thanks for your interests on RLMRec! Due to the complexity of the pre-processing code and its multi-file structure, it might be more helpful to provide a straightforward overview of the basic workflow for the pre-processing steps, as outlined below:

Score Filtering: Begin by filtering out low-score interactions (implemented using a for loop).
User Sampling (Discussion in Issue 9) Next, uniformly sample a ratio of users and remove items that have not been interacted with after filtering the users. This will help reduce the dataset size (implemented with boolean vectors).
K-Core Filtering: Finally, apply k-core filtering using the NetworkX library.

I hope the above answer is helpful to you :)
Best regards, Xubin

Thank you for your reply!


Bug: theme matching by handle doesn't work, but uuid does

Describe the bug
Matching on a collection handle does not appear to work for a collection, but using a UUID does work (except for the duplicated elements #2346)
To Reproduce
Steps to reproduce the behavior:
themes:
  - name: etdr
    extends: krex
    handle: '2097/4'
    # uuid: '6d684812-6d29-4564-8b51-f5670957936b'

  # default theme, based on DSpace
  - name: krex

This works though
themes:
  - name: etdr
    extends: krex
    uuid: '6d684812-6d29-4564-8b51-f5670957936b'

  # default theme, based on DSpace
  - name: krex

Expected behavior
Theming should be applied to the collection items when using the handle, or the uuid.
Related work

I tried the same with this config, and it worked (I also had to uncomment the CustomEagerThemeModule in src/themes/eager-themes.module.ts):
themes:
  - name: custom
    extends: dspace
    handle: '123456789/2'
  - name: dspace

Could you maybe go over these steps and check that your theme is correctly set up

@alexandrevryghem I believe it's setup correctly? The copy of dspace to krex seems to work (https://github.com/kstatelibrariesit/dspace-angular/tree/etdr-theme/src/themes/krex) but not the subtheme etdr
I made the repo public incase it would be easier to see where I might have messed up

@misilot sorry for the late response I was on vacation. Can you try rebasing/merging your branch with the branch from the linked PR and check that both issues are now resolved?

@alexandrevryghem I was trying to apply this to the 7.6 branch I have, but it doesn't apply cleanly.
git am --show-current-patch=diff
---
 src/app/shared/theme-support/themed.component.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/app/shared/theme-support/themed.component.ts b/src/app/shared/theme-support/themed.component.ts
index 2ff0713f460..920fbba6e56 100644
--- a/src/app/shared/theme-support/themed.component.ts
+++ b/src/app/shared/theme-support/themed.component.ts
@@ -1,10 +1,10 @@
 import {
+  AfterViewInit,
   Component,
   ViewChild,
   ViewContainerRef,
   ComponentRef,
   SimpleChanges,
-  OnInit,
   OnDestroy,
   ComponentFactoryResolver,
   ChangeDetectorRef,
@@ -21,7 +21,7 @@ import { GenericConstructor } from '../../core/shared/generic-constructor';
   styleUrls: ['./themed.component.scss'],
   templateUrl: './themed.component.html',
 })
-export abstract class ThemedComponent<T> implements OnInit, OnDestroy, OnChanges {
+export abstract class ThemedComponent<T> implements AfterViewInit, OnDestroy, OnChanges {
   @ViewChild('vcr', { read: ViewContainerRef }) vcr: ViewContainerRef;
   protected compRef: ComponentRef<T>;

@@ -49,7 +49,7 @@ export abstract class ThemedComponent<T> implements OnInit, OnDestroy, OnChanges
     }
   }

-  ngOnInit(): void {
+  ngAfterViewInit(): void {
     this.destroyComponentInstance();
     this.themeSub = this.themeService.getThemeName$().subscribe(() => {
       this.renderComponentInstance();

is what git am isn't happy about

I just tried merging in themed-component-fixes-main into etdr-theme and it succeeded without any merge conflicts
 git merge themed-component-fixes-main
 Merge made by the 'ort' strategy.
 src/app/shared/theme-support/themed.component.ts | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Thanks @alexandrevryghem so
  - name: etdr
    extends: krex
    uuid: '6d684812-6d29-4564-8b51-f5670957936b'

appears to work, but not
  - name: etdr
    extends: krex
    handle: '2097/4'

However, the duplicating theme element issue did go away!

I couldn't reproduce at first because I tested it with the classic themed components until I realised you were talking about the @listableObjectComponent like UntypedComponent, they use a different mechanism to detect the theme. Normal themed components (the ones without decorators) can still be themed by handle. I will try to make PR for this bug as well.

@misilot I couldn't reproduce this error. I tried with both dynamically created components like UntypedComponent and standard themable components like HeaderNavbarWrapperComponent, and I still wasn't able to reproduced this error I also tried running it in both prod and dev mode without any luck. Can you provide more info about how you noticed that it didn't work like for which component doesn't it work on your branch and what change would you expect where.

@alexandrevryghem
So I'm trying to add these additional metadata specific components to specific communities (the etdr theme)
https://github.com/kstatelibrariesit/dspace-angular/blob/etdr-theme/src/themes/etdr/app/item-page/simple/item-types/untyped-item/untyped-item.component.html#L65-L75
If I use in my config.yml file
themes:
  # Specific Item
  # - name: etdr
  #   extends: krex
  #   handle: '2097/43295'

  - name: etdr
    extends: krex
    handle: '2097/4'

  # default theme, based on DSpace
  - name: krex
    headTags:
      # Insert <link rel="icon" href="assets/krex/images/favicons/favicon.ico" sizes="any"/> into the <head> of the page.
      - tagName: link
        attributes:
          rel: icon
          href: assets/krex/images/favicons/favicon.ico
          sizes: any

I get the following results (not working)

However if I use
themes:
  - name: etdr
    extends: krex
    uuid: '6d684812-6d29-4564-8b51-f5670957936b'

  # default theme, based on DSpace
  - name: krex
    headTags:
      # Insert <link rel="icon" href="assets/krex/images/favicons/favicon.ico" sizes="any"/> into the <head> of the page.
      - tagName: link
        attributes:
          rel: icon
          href: assets/krex/images/favicons/favicon.ico
          sizes: any

It does work as expected, except for the duplicative collections (I don't think I did this)

@misilot I used your branch again to test it and I'm still not able to reproduce the error, I asked a colleague (@nona-luypaert) to also test it on your branch to be sure I didn't miss anything and she also wasn't able to reproduce your error. Have you already tried running yarn clean & removing the .angular folder?
https://github.com/DSpace/dspace-angular/assets/43750381/ccdffd5a-ccb0-497c-95c0-6c77a87b22e0

@alexandrevryghem I ran docker system prune to purge all of the build components, and I am still seeing it when I target a collection by the handle. Not sure if there is anything else I can test?

I don't have yarn on the local system. Let me try applying the changes on
our test system and see what it does with built assets and pm2
On Tue, Aug 1, 2023 at 9:51 AM Alexandre Vryghem @.***>
wrote:

Have you also tried running it locally using yarn start:dev/yarn
start:prod, maybe it's docker related?
—
Reply to this email directly, view it on GitHub
https://github.com/DSpace/dspace-angular/issues/2348#issuecomment-1660487419,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALBHSGYG6MCVIUZWEQLDPTXTEJX3ANCNFSM6AAAAAAZ2AQQYU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@alexandrevryghem So I did the following

 yarn clean
rm -Rf .angular/
yarn install
yarn build:prod
rsync -avzh /klib/build/dspace-angular/dist/ /klib/app/dspace-ui-deploy/dist/ --delete
cd /klib/app/dspace-ui-deploy/
pm2 restart dspace-ui.json (with handle filter for the etdr theme configured)
Tested (did not work)
modifed config/config.yml to enable the uuid filter
Tested (did work)

@tdonohue I see that PR #2395 is linked to this. That PR addresses #2346

I confirm that matching by handle in DSpace 7.6 doesn't work for me either.

Hey @alanorth, are you able to reproduce it on the main branch or were you only able to reproduce it in your project? And if you were able to reproduce it on main, how do you run your dspace with yarn start:dev/yarn start:prod or with pm2? Because I wasn't able to reproduce it 😅

I'm using pm2 (I don't remember if I said that before)
On Thu, Sep 28, 2023 at 3:13 PM Alexandre Vryghem @.***>
wrote:

Hey @alanorth https://github.com/alanorth, are you able to reproduce it
on the main branch or were you only able to reproduce it in your project?
And if you were able to reproduce it on main, how do you run your dspace
with yarn start:dev/yarn start:prod or with pm2? Because I wasn't able to
reproduce it 😅
—
Reply to this email directly, view it on GitHub
https://github.com/DSpace/dspace-angular/issues/2348#issuecomment-1739944333,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALBHSHXCAA4DH5RDZ7S7OLX4XK6VANCNFSM6AAAAAAZ2AQQYU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi, I was testing via yarn start:dev, but I just tried via yarn start (production mode) and it definitely doesn't work for me on 7.6.

@alanorth could you maybe give me your config.yml that you used on the main branch

@alexandrevryghem I was working on DSpace 7.6, not main. But sure, this is my config.dev.yaml:
https://gist.github.com/alanorth/4d6e9a1db7a09567fd588d47ec34d8f9

Good news, I was able to reproduce the error locally. The error only happens for clients who change their handle.canonical.prefix, because this regex expects all handle urls to have handle in front of the handle, but this means that urls like http://hdl.handle.net/xxx/yyy currently aren't supported. I will provide a PR for this

@alexandrevryghem glad that might fix the issue, but not sure it is the case since we access the url's like https://fqdn/handle/2097/4
Our handle.canonical.prefix=https://hdl.handle.net/ is though 🤷

The handle that is used to find the correct theme isn't the one from the url, but the one in the metadata of the Community/Collection/Item. So in your case that regex will try to retrieve the handle from the url https://hdl.handle.net/2097/4. If you already want to test it on your local machine you can temporarily update the handle of your collection and replace https://hdl.handle.net/ with https://fqdn/handle/ and then you should be able to see the correct theme again.

Hey @misilot, I apologize for the delay in finishing the PR, but my last few weeks have been quite busy 😅, but I was able to finish it today could you maybe take a look and check if it fixes your issue?

Thank you for fixing this @alexandrevryghem!


Changed the default shared_schema options for the psql and atlas drivers

Updated the shared schema config to not default to the first schema. Verbose is better. Currently only updated the psql and atlas drivers. Related to the conversation in #187

@stephenafamo let me know if this makes sense. It'll definitely solve my be issue of an assumption that you can easily miss in the config

It'll definitely solve my be issue of an assumption that you can easily miss in the config

I'm hesitant to change this.
Most people would only be working with one schema, and may not appreciate the extra verbosity of including the schema name when they are only working with one schema.
And while I understand that they could manually set the shared schema to get the same behaviour back, I prefer to have the "default behaviour" be as seamless as possible.
If the issue is that is is unclear what shared schema is being used, wouldn't it be more beneficial to add a log statement to make the user aware of this?
What do you think?

Well I guess its a reasonable alternative. I'm personally a fan of explicit specifications rather than navigating default behavior, but I understand where you might be coming from. However, you should give it some thought, having explicit verbose configs are the easiest ways of learning how processes work.
For all the people who try to deploy the tool for anything beyond the basic usage, not having explicit complete configurations is a pain to deal with. For me, it changed what I could have done in 1 hour to stretch over a week as I was trying to figure out why things weren't working.


Updating columns in RAC/S2 TableView throws an error

Provide a general summary of the issue here
When updating the columns in an S2/RAC TableView (i.e. hiding/showing columns), TableView throws an error
🤔 Expected Behavior?
TableView should not throw an error when the columns are changed, and columns should be updated to reflect the latest value.
😯 Current Behavior
The following error is thrown:
runtime.js:4 TypeError: Cannot read properties of undefined (reading 'key')
    at $7713593715703b24$export$49571c903d73624c (useTableCell.mjs:18:1)
    at Table.mjs:820:1
    at Component (CollectionBuilder.mjs:150:1)
    at renderWithHooks (react-dom.development.js:15486:1)
    at mountIndeterminateComponent (react-dom.development.js:20103:1)
    at beginWork (react-dom.development.js:21626:1)
    at beginWork$1 (react-dom.development.js:27465:1)
    at performUnitOfWork (react-dom.development.js:26596:1)
    at workLoopSync (react-dom.development.js:26505:1)
    at renderRootSync (react-dom.development.js:26473:1)

💁 Possible Solution
No response
🔦 Context
Updating the columns prop to hide/show columns
🖥 Steps to Reproduce
use the following story and press the first action button:
export const ColumnTest = () => {
  const [cols, setCols] = useState(columns);
  return (
    <>
      <div className={style({display: 'flex', gap: 8})}>
        <ActionButton onPress={() => setCols(columns.slice(0, 2))}>Hide end columns</ActionButton>
        <ActionButton onPress={() => setCols(columns)}>Reset columns</ActionButton>
      </div>
      <TableView aria-label="Many items table">
        <TableHeader columns={cols}>
          {(column) => (
            <Column width={100} minWidth={100} isRowHeader={column.isRowHeader}>{column.name}</Column>
          )}
        </TableHeader>
        <TableBody items={items}>
          {item => (
            <Row id={item.id} columns={cols}>
              {(column) => {
                return <Cell>{item[column.id]}</Cell>;
              }}
            </Row>
          )}
        </TableBody>
      </TableView>
    </>
  );
};

Version
s2: 0.4.1, react-aria-components: 1.4.1
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
OSX Sonoma 14.1.1
🧢 Your Company/Team
Adobe/Quarry
🕷 Tracking Issue
No response

The root cause is that RAC Table expects the user to provided a list of dependencies to the TableBody in order to invalidate its items cache, so a case like this where the user wants to hide columns requires the user to provide the columns to the TableBody's dependency array. The provided example above works in RAC if col is provided to TableBody via dependencies={[cols]}.
S2 table doesn't allow the dependencies prop to be provided, and even when modified locally doesn't seem to have any effect on busting the cache despite using RAC Table under the hood, so this will need some investigate


Docker

Add the Dockerfile, also adds dummy serve_model for the microservice.
Doesn't work yet because
ERROR: failed to reproduce 'make_dataset': [Errno 2] No such file or directory: '/root/data/raw/test.tsv'

I've made some changes in the Dockerfile because it didn't work. Now I'm trying to run the Flask app on port 5000 as that is Flask's default port and I see that the Docker container does start the Flask app. However, the port forwarding doesn't seem to work for me... When I go to localhost:5000, it doesn't display a result

okay i forgot to push one small addition to the readme. now its all ready


question

how to connect the store and work on pm4 to this add-on?

because there is no coinjob coinshop yet


no feedback from Dendro when job submission fails

When I try to submit a job to Dendro using an old API key:

It doesn't work. I don't know if my API key has the necessary permissions.
There is no feedback on neurosift that it didn't work

https://github.com/user-attachments/assets/7dc8b267-f582-49ce-97cf-3dbc83f0cadd

Curious, did you try with a new dendro api key from https://dendro.vercel.app/?
I'll keep this issue open, will implement feedback on error.

I just generated a new key and it did not fix the problem

I changed some permissions, could you please try again (obviously we'll need feedback)

Looks like it's working now:


[Bug]Unlimited wool from shearing sheep

Forge version 36.1.0
Penguin-Lib 0.4.2
Husbandry 1.0.2
This was done in a new instance + new world. No other mods.
Steps to reproduce:

Get vanilla shears
keep shearing sheep
Unlimited wool

Hmm I think I can see how this might be. I - did test it and it worked originally but since then I'd also added a check for the shears tag but I think I forgot some brackets. Will see when I'm home.


Update rand_core dependency to version 0.6

Since version 0.6, rand_core::OsRng is behind a feature flag.
As OsRng is used in doc tests, the missing feature is added as a dev-dependency.

Hi @inorick! Thanks for the PR. The rand_core dependency was already updated to 0.6 in 9717eb8 which has been merged and released in version 2.0.0-pre.0.


Store settings.ini in appropriate folder rather than working directory

Writing to files in C:\Program\ is discouraged on Windows (and probably similarly on Unix). We need to store settings.ini in the appropriate folder depending on OS. (AppData on Windows.)

http://gamedev.stackexchange.com/questions/35700/in-which-directory-to-write-game-save-files-data/35703#35703

Same applies to log.txt

settings.ini and log.txt are now stored where they should.


logical router questions

may be i miss something, but how can looks type LogicalRouter struct ?
type LogicalRouter struct {
  UUID       string
  Name       string
  Enabled    bool
  ExternalID map[interface{}]interface{}
}

or i'm wrong?

Logical_Router TABLE
       Each row represents one L3 logical router.

   Summary:
       ports                         set of Logical_Router_Ports
       static_routes                 set of Logical_Router_Static_Routes
       enabled                       optional boolean
       nat                           set of NATs
       load_balancer                 set of Load_Balancers
       Naming:
         name                        string
         external_ids : neutron:router_name
                                     optional string
       Options:
         options : chassis           optional string
         options : dnat_force_snat_ip
                                     optional string
         options : lb_force_snat_ip  optional string
       Common Columns:
         external_ids                map of string-string pairs

this is the table define in the spec.  could we add more in the struct?
and how about to implement all thing about logical router,  such as logical port, or static router?
what's the suggestion?

I see that logical switch table contains more elements than defined in struct, so i dont understand why..

I think that options can be representet via map[string]string or map[interface{}]interface{}
When create new logical router simply iterate over map keys and check them, if it not in allowed list returns error like ErrorBadRequest, i'm prefer for typed errors because it can be easy compared.

struct already have all schema elements


A post about your good repository in the medium

@eric-mitchell
Thanks for your great repo. I have written the following brief post for introducing your great repo:
Fast Model Editing at Scale via Model Editor Networks with Gradient Decomposition (MEND)
Best

@ahkarami Thanks so much for the kind words!


Problem presenting swap chain to current buffer

Assertion fail occurs in triancle.cpp, when "Present the current buffer to the swap chain"

233 // This will display the image
234 err = swapChain.queuePresent(queue, currentBuffer);
235 assert(!err); // Fail here

err = VK_ERROR_INITIALIZATION_FAILED (-3)

I need more details. What hardware, driver and OS? Did you run the example with validation enabled (requires the SDK)? If not, can you please do so and check for validation errors?

MSI GX70 3BE Notebook : AMD A10 5750M CPU with Radeon HD 8650G iGPU, and Radeon HD 8970M GPU. Windows 10 installed.
I'm messing around with drivers : error change after installing/removing vulkan/WHQL drivers...

Hey where did you find SDK 1.0.2 ?

It comes with AMD Vulkan drivers.

AMD have just released updated drivers with support for SDK version <IP_ADDRESS>.
Can you try with these?

I've tried, and got the same error on your example. I make a note : I get different errors when I've installed the drivers differently. When I install vulkan drivers (upgrading from WHQL drivers), I get no vulkan adapter, and after uninstalling regularly and installing regular, I get vulkaninfo working, but your example stop working on the swapchain (vulkanswapchain.hpp).

That's odd. SwapChain works fine here on AMD (Windows 7), even with the initial beta driver. Though I'm on a more recent GPU, so it may be a problem tied to your GPU.
Does this happen with the samples from the LunarG SDK too?

Yep, the tri or cube samples tells me I do not have a "CLI"

I tried on my desktop build, and the samples actually works good but the pushconstant show only glitchs, I don't know why (I don't have a working VS on this machine).

Push constants are a rather new feature, and since drivers are still beta they may not work on every implementation. Does the shadowmapping example work fine? It uses push constants too, but not arrays.

On the Shadowmapping example, I get glitches too, but only on one wall, with sometimes seeing a circle on this wall.

Swap chain issue resolved with new drivers (feb27) and last version of examples.
All examples works fine exept pushconstant, and have one wall of the Shadowmappingomni example that is just covered with one shadow (like before).

Thx for the info. I'm testing on AMD with that driver too and hope to have the two examples fixed soon.

pushconstant example is now properly working :+1:


[bug] City Info / Production Screen not working/opening

When you click on a city to open the info and production screen, it highlights the city but no items or information shows up. The production screen will show up if there it nothing being produced and you click on the turn button gear icon.

Do you use other mods? Are you on Windows/Mac OS/Linux?

I've stumbled upon this bug as well, for my setup I'm running on Windows 10 (the direct x12 version of the game) and I'm running other mods as well, though I just went through and tripple checked that I don't have any other UI mods in there.
As for some of the mods:

R.E.D. (with all the civ/dlc addons)
MOAR units (with all the "Even MOAR units! packs)
all conceivable compatibility mods and "combo mods"
and some other game play altering mods, i.e. AI and unit/tile improvement mods

@U2328 It's likely a mod conflict. In the logs, you have an error in G:\Games\Steam\steamapps\workshop\content\289070\904443457\CityPanel.lua:1114 but CQUI have citypanel.lua in a panels so this error is not from CQUI and you also have a conflict because this other mod is changing the citypanel file.

I'll take a look, and see what I can find.

@Azurency So it does seem to be a different mod causing this, I'm now on the hunt which one it is. I'll right it in here when I'm done so you have this Info as well.

You are correct that it was a different mod. The mod in question for me was the "Happiness Level - Euphoric" mod and was easily fixed.

Great, so I'll close this issue then 👍


Resolved "Add public division to POND #126"

Added div functionality to Pond, PondTensor and various backing tensor types.
I more or less just copied the mul functionality and replaced the multiplication with division.

@mortendahl ok good to know. will look into it and fix it accordingly

I think the easiest is to only support public division with an int or floating point for now, ie you can do x / y when:

y is an integer
y is a float
y is np.ndarray

but otherwise not (ie leave out the case where y is PondPublicTensor or PondPrivateTensor).
That way there is no need to decode first, you can simply compute the reciprocal and use the existing methods for multiplication. Once working it's not too much trouble to add support for PondPublicTensor.
Very happy to see the interest! 👍 🎉

So heres my understanding.
In Int64Tensor & Int32Tensor I can use
    def div(self, other: Any) -> 'IntXTensor':
        x, y = _lift(self, other)
        return intXfactory.tensor(x.value / y.value)

as x.value and x.value are either int or tf.Tensor
for Int100Tensor which is the representation in a residue number system
you can multiply with the multiplicative inverse but only if Y and M are coprimes
otherwise you have to use some fancy algorithms thus I would use raise a NotImplementedError in that case
for PrimeTensor as the modular (following known as p) is a prime we can use y = pow(x, p-2, p) to get the multiplicative inverse for y and then just do  x * y % p
and then all the implementations of _div_public_public etc. should work as they delegate to the protocol which delegates down to the backing tensors correct?

The multiplicative ring inverse is not exactly what we're after here, it's rather the fixed point inverse!

@Nivek92 want to add a few tests?


Screen of my phone has black bars

I recently tried to connect my phone to the RAB.exe console but when it detected my screen resolution, my screen shrunk in size and now I have black bars on the top and bottom of my screen and it won't go away. I've had to contact OnePlus and they don't even know what went wrong.

I hope this is a common issue and can be sorted out easily because I have been searching the net with no luck.

Connect your phone to your computer, run RAB.exe again. Go to the tool tab (Last Tab) and click on "Reset Phone Resolution".
If you cannot see the option, ensure your computer resolution is 1920x1080 or more
Instructions has been clearly stated right at the start when you start up RAB,exe
"Remember to use CTRL+C when you want to quit RAB"
Please ensure you did that again to prevent your phone stuck in smaller resolution

It says device 'None' not found in the terminal

Make sure your phone is properly connected and screen is unlocked.

Thank you so much for the help.  Thank you again!
I was super worried for a second there.

More warning will be added in new version to prevent this from happening again. This issue will be closed.

This just happened with my phone. I connected it back and tried what you said, but it's not working. Is it stuck forever in this?


[V18: Volume Split] Refactor create gauge to only interface with pool ID

Part of: #6057
What is the purpose of the change
indepth overview of this change is in this hackmd (https://hackmd.io/rLt-8Ox4Qn2pIXRnsLyhMg)
but here's a tldr

[x] Remove distrTo while creating gauges (not needed for CL, and GAMM only uses 14d incentives so we can have 1:1 mapping with gauge and PoolId rn)
[x] After Pool Create Epoch, create gauge with longestLockableDuration (14d only) (this doesnot mean we remove 1d, 7d from lockableDurations on chain)
[x] Fix all broken test
[x] Add new test for CreateGauge

Testing and Verifying
-localosmosis tested
**** FOR CL *****
- osmosisd tx incentives create-gauge "" 100000uosmo 3 --from val --keyring-backend test --chain-id localosmosis  --epochs 12 --fees 100000uosmo -b block -y

- osmosisd q poolincentives external-incentivized-gauges
data:
- coins:
  - amount: "100000"
    denom: uosmo
  distribute_to:
    denom: no-lock/e/3
    duration: 0s
    lock_query_type: NoLock
    timestamp: "0001-01-01T00:00:00Z"
  distributed_coins:
  - amount: "8333"
    denom: uosmo
  filled_epochs: "1"
  id: "5"
  is_perpetual: false
  num_epochs_paid_over: "12"
  start_time: "1970-01-01T00:00:00Z"

***** FOR NON CL (GAMM) ****
-osmosisd tx incentives create-gauge gamm/pool/1 100000uosmo 1 --from val --keyring-backend test --chain-id localosmosis  --epochs 12 --fees 100000uosmo -b block -y

-osmosisd q poolincentives external-incentivized-gauges
data:
- coins:
  - amount: "100000"
    denom: uosmo
  distribute_to:
    denom: gamm/pool/1
    duration: 240s
    lock_query_type: ByDuration
    timestamp: "0001-01-01T00:00:00Z"
  distributed_coins: []
  filled_epochs: "0"
  id: "6"
  is_perpetual: false
  num_epochs_paid_over: "12"
  start_time: "1970-01-01T00:00:00Z"
- coins:
  - amount: "100000"
    denom: uosmo
  distribute_to:
    denom: no-lock/e/3
    duration: 0s
    lock_query_type: NoLock
    timestamp: "0001-01-01T00:00:00Z"
  distributed_coins:
  - amount: "16666"
    denom: uosmo
  filled_epochs: "2"
  id: "5"
  is_perpetual: false
  num_epochs_paid_over: "12"
  start_time: "1970-01-01T00:00:00Z"

Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

@devbot-wizard help

Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:

devbot fix: Fix basic errors in the PR. (e.g. imports, changelog conflicts, go mod conflicts)
devbot merge base: Merge the base branch into the PR branch.
devbot add changelog [misc/feat/bug/api/sec] [message]: Add a changelog entry to the PR. (e.g. devbot add changelog feat Added a new feature)

If message is blank, defaults to PR title.

devbot re-pr: Re-PR the PR, useful for external contributors where we have no edit perms.

devbot add changelog v18: Volume Split, Refactor create gauge to only interface with pool ID


Application; delete entry's

Bugreport:
Bug reported by Profxy
Is it a bugreport for the website or for the bot?: bot
What is the title of your bugreport?: Application; delete entry's
How can you reproduce the bug? (Explain in steps): try to delete a entry with the ID - doesn't work.
Which result would normally have to be?: the possibility to delete entrys with their ID - as with +editentry (there the ID works)
What happens if you do the action now?: same
ReportID: 74

➤ LenoxBot commented:
Approve:
reproducible
Fabiooo

➤ LenoxBot commented:
Approve:
could be reprodiced
Dadi

➤ LenoxBot commented:
Approve:
reproducible
Wandi


Unescape string in memory entirely.

Escape the path url.
Feature:

Operate completely in the memory pool without allocate memory
UTF-8 decode once only.

/cc @lodejard @Tratcher @halter73 @muratg

[x] Add a put function to MemoryPoolIterator2 for saving byte correctly
[x] Add UTF8 verification during the pass

Ping

Ping, updated.

Added iteration to fix a few bugs found in review. I'm adding test cases to cover them.

Ping @lodejard @Tratcher @halter73 @muratg @davidfowl

Ping

:shipit:

all right. I'll wait a bit for Travis.


Source select FM / Tuner not working on Marantz NR1603

Selecting any source other than FM/Tuner works without any problem. The custom name for the source is displayed as well.
In the source list the (analogue) radio is displayed as 'FM'. It seems this is also send to the receiver as the source name. This does not work. The expected source name is 'TUNER'.
A fix is to add a source mapping like this:
SOURCE_MAPPING = {"TV AUDIO": "TV", "iPod/USB": "USB/IPOD", "Bluetooth": "BT",
"Blu-ray": "BD", "CBL/SAT": "SAT/CBL", "NETWORK": "NET",
"Media Player": "MPLAY", "AUX": "AUX1", "Tuner": "TUNER", "FM": "TUNER" }

Fixed in version 0.7.10

Thanks for the fix and the great work on this HASS extension!

you are welcome :-)


Public folder support

It would be very useful if MHA worked on mail-enabling a public folder.
Currently compares "You cannot perform this action. This add-in scenario is not supported in this folder."
[maybe related to #17 Enhancement Request: support for Shared Mailboxes]

Yep - this is gonna be the same thing. I don't control where apps are enabled...


feat: add support for EC2 Instance Identity roles

What this PR does / why we need it:
This PR enables aws-iam-authenticator to support EC2 Instance Identity roles - https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-identity-roles.html , by parsing their UserID format. This enables use cases such as limited dynamic ad-hoc access to a kubernetes cluster based on AWS identity.
as of now, this prints an  error: "sts getCallerIdentity failed: malformed UserID "5553582100:aws:ec2-instance:i-1234567890"" method=POST path=/authenticate , this error is incorrect as the UserID is well formed (just not what was expected)
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
None

Thanks for this PR! Can you open a GH issue so we can discuss the use case? I want to better understand why this is needed as an alternative to the EC2 instance role

This enables use cases such as limited dynamic ad-hoc access to a kubernetes cluster based on AWS identity.

Under what scenarios would be this useful ?


ERROR    Fonts have different glyph names

Hello,
I keep getting the error message in check-ttfs, when I run multiple fonts together.
Run FB on this repo. https://github.com/m4rc1e/Maven-Pro
I have my own glyphsapp script to check if fonts contain different names and glyph counts
I get the following output:
Name: Regular, Glyphs: 722
Name: Medium, Glyphs: 722
Name: Black, Glyphs: 722
Name: Bold, Glyphs: 722
Regular - Regular set([])
Regular - Black set([])
Regular - Medium set([])
Regular - Bold set([])
Black - Regular set([])
Black - Black set([])
Black - Medium set([])
Black - Bold set([])
Medium - Regular set([])
Medium - Black set([])
Medium - Medium set([])
Medium - Bold set([])
Bold - Regular set([])
Bold - Black set([])
Bold - Medium set([])
Bold - Bold set([])
It seems the fonts share the same names and have the same glyph counts.
I'm terribly sorry I can't look deeper into this. I need to be on the autobahn releasing fonts.
Cheers,
Marc

@m4rc1e No worries. I'll take care of this. Thanks for reporting.

@m4rc1e Fontbakery only runs this check when a METADATA.pb file is found. There's no METADATA.pb in the fonts folder at your repo. Do you keep a copy of this file into the fonts dir only on your local working copy ?

There's a METADATA.pb file in this repo.
You have to create a temp folder which replicate the fonts/ofl structure for each family.

sure!
I think I fixed the problem. I'll commit it and then ask for your feedback in 5 minutes

ok. I merged this since it fixes the issue at my local working copy.


chore(get): refactor implementation

Description of Changes

Use internal APIs such as request, decompress, ffmpeg, node and nw functions.

This actually fixes cache behaviour but the commit message does not capture this info.
Refs: #1037


Adding deprecated schema v1 page

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "release/2.7" git@github.com:adrian-plata/distribution.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842359065760
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@thaJeztah, @andrewhsu, and @tonistiigi PTAL. Are there any additional things to add to this list?

vndr and static checking need to be fixed, can be done separately


Output debug logs until kernel has fully started, then store them somewhere

Instead of having a dedicated serial line for the debug logs, an idea could be to send them to the main (and likely only) serial line until the kernel has started. From there, we can avoid showing them because that would mess with the "UI" (e.g., kshell).
We could use a pseudo-file to show them if needed (e.g., we would use a ring buffer to store the logs exposed via the proc fs). It is going to work well until the system crashes, though because we'll lose everything probably. We could dump all the logs in PANIC() but, if it is a different crash, like unexpected, we'll be left without anything.
Another idea could be to use a feature flag for this?

Lately, I started to print INFO logs to the main output (e.g., screen or serial).
For DEBUG logs, especially on real hardware, we probably want them in a file as opposed to printed on the screen or serial, even if it is a second serial line.
For local dev, maybe there is a semihosting feature that we could leverage somehow?


Upload telemetry info in an independent process

Telemetry POSTs may block the current process until finished, which is an issue in very short-lived commands. Spawn a different process to do the upload so it does not block the user.

Closed via 25986c25334f578e62736dbb46d2e8e27b2dbb51


Allow starts to be defined as 'self' much like one can do in contains

I used this for a weird linking system. Colon separated values as { end: /:/, endsWithParent: true, starts: 'self', ... }
It's not a necessary thing, but it's consistent with the feature for contains.

I'm confused when you would use this exactly?

Since this was so long ago I hardly remember but going off of "colon separated values" I think I used it for like 1 : 1 : ... but where 1 is a complex type (like could be a number or a string or whatever)
It's in here, and while the grammar sorta works, it's slow in complex cases so I kind of have up.

Seems like a good way to get stuck in an infinite loop.  How does it break out if after end it always starts self?
And typically you'd do this with a parent and then inside your contains you'd just have you matcher... so it would run over and over and over again as many times as needed until you left the mode... no need for this start hack.

It breaks out when the parent ends, as the example says. :p

...
contains: [
  {
     begin: /\d\s:\s?/,
     endWithParent: true
  }
]

Doesn't that do exactly the same thing?

I don't know, I'm out of touch with the system. I'm pretty sure I only did it for reducing redundancy. I have no complaints if this is just closed.

Ok, closing.  It would have needed extra documentation and I had some issues with the code also... and generally this type of feature we shouldn't just add "abstractly"... if there was a grammar included with it that required the new functionality that would make a much better case for why it's necessary/useful, etc...


Use custom character instead of *

I'd like to use _ instead of * to use it with Stylus (it complains about * because it expects an operation)
Could you add an option to define a custom character instead of *?
postcssShortSpacing({
  spacer: '_',
});

Yes, this seems like a great feature.


Feature request: A very handy command that yanks the line(s) before commenting.

A very handy command that yanks the line(s) before commenting, so you can press p or P to insert the line (the way it was before) below or above.
Just like [count]cy |NERDCommenterYank|
[(https://github.com/preservim/nerdcommenter)]

A partial solution (as it works only linewise):
  ["gC"]          = { "yy<cmd>lua require('Comment.api').toggle.linewise.current()<cr>", "Yank and comment out" },
This is a map definition via WhichKey-Plugin.

I think a good keymap for this would be gcy, (not gC as above). And gby for block-wise


Fails to run "azd provision" in section "adding a custom domain name"

Describe the issue:
An error occurred while running azd provision according to the "adding a custom domain name" section of README.md. The error is shown as following:

Repro Steps:

Run npm i
Run npm run env:init
Run azd auth login
Add SERVICE_WEB_CUSTOM_DOMAIN_NAME=www.xshtest.com in .env.local file
Run azd provision

Expected behavior:
Run command azd provision successfully.
@CMeeg and @hemarina for notification.

Thanks for flagging this. I already had some DNS records setup where I had been testing the template that meant the domain verification step was passing.
I removed the DNS records and was able to reproduce the error that you raised.
I have now updated the readme (3fe3673) with some further instruction of how to verify your custom domain before you add it to the container app.


Juggling of Items after certain point of scroll

After a certain point of scroll, item started juggling. Some items which are already scrolled just coming up again.  It is on Ionic3 framework.
<virtual-scroll #scroll *ngIf="listItems.length > 0" [items]="listItems" >
<ion-col col-xl-6 col-lg-6 col-md-6 col-sm-12 col-12
     style="display:inline-block"
     *ngFor="let item of scroll.viewPortItems"  >
        <add-item style="height:150px; width:450px;"
        [itemInfo]="item" [documentType]="documentType" (itemAdded)="itemAdded($event)" (itemRemoved)="itemRemoved($event)"
          (qtyChanged)="qtyChanged($event)" (addTag)="addTag($event)" (removeTag)="removeTag($event)"></add-item>

    </ion-col>

+1 with Angular2.

Would you mind creating a git repo with a barebones ionic app that reproduces this issue? (or a StackBlitz ?) It'll help speed up troubleshooting. Thanks.

I'm facing a similar problem. In my case some of items from the array have a *ngIf condition to show an additional custom div. I suspect that when this div is recycled the scroll jumps. May be because of the height differences between them.
Looking for a solution.

I've seen this happen before with variable-sized child items (not sure if that's your usage scenario). However,the current version on npm addresses that (still not perfect, but it's much better).
Closing this since I haven't received a response from the original poster. Please re-open if you continue to experience this issue.


Issue No named parameter with the name 'connectTimeout'

Describe the bug
I am getting this error log when adding amplify_storage_s3: ^2.4.1
Launching lib\main.dart on sdk gphone x86 in debug mode...
../../../AppData/Local/Pub/Cache/hosted/pub.dev/drift_flutter-0.2.0/lib/src/native.dart:61:42: Error: No named parameter with the name 'connectTimeout'.
return await isolate.connect(connectTimeout: connectTimeout);
^^^^^^^^^^^^^^
../../../AppData/Local/Pub/Cache/hosted/pub.dev/drift_flutter-0.2.0/lib/src/native.dart:112:7: Error: No named parameter with the name 'port'.
port: connections,
^^^^
../../../AppData/Local/Pub/Cache/hosted/pub.dev/drift-2.18.0/lib/isolate.dart:178:11: Context: Found this candidate, but the arguments don't match.
factory DriftIsolate.inCurrent(DatabaseOpener opener,
^^^^^^^^^
Target kernel_snapshot_program failed: Exception
2
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.

Process 'command 'C:\flutter\bin\flutter.bat'' finished with non-zero exit value 1

I have created a sample project to replicate the problem I just added amplify_storage_s3: ^2.4.1 and the error above happened
if you could teach me a fix that would be great TIA.
https://github.com/markjoseultra/flutter_drift_test

Despite claiming to support older drift versions - drift_flutter actually requires a more recent version of the core drift package. This will be fixed in the next drift version, but that won't help you if you have another package depending on older drift versions (like Amplify).
Does adding this to your pubspec solve the issue?
dependency_overrides:
  drift: ^2.20.3

I will not be able to use the latest version of drift
Because no versions of location match >7.0.0 <8.0.0 and location 7.0.0 depends on location_web ^5.0.3, location ^7.0.0 requires location_web ^5.0.3.
And because no versions of location_web match >5.0.3 <6.0.0, location ^7.0.0 requires location_web 5.0.3.
And because location_web 5.0.3 depends on web ^0.5.1 and drift >=2.19.2 depends on web ^1.0.0, location ^7.0.0 is incompatible with drift >=2.19.2.
So, because flexiform depends on both drift ^2.20.3 and location ^7.0.0, version solving failed.

Judging by the few changes required in https://github.com/Lyokone/flutterlocation/pull/989, you might get away with also adding web: ^1.0.0 to the dependency overrides section.

If you can't use the latest drift, try downgrading drift_flutter by using drift_flutter: '>=0.1.0 <0.2.0'

I can't also use drift_flutter 0.1.0
Because amplify_db_common_dart 0.4.6 depends on sqlite3 >=2.0.0 <2.4.3 and no versions of amplify_db_common_dart match >0.4.6 <0.5.0, amplify_db_common_dart ^0.4.6 requires sqlite3 >=2.0.0 <2.4.3.
And because drift_flutter <0.2.0 depends on sqlite3 ^2.4.4, drift_flutter <0.2.0 is incompatible with amplify_db_common_dart ^0.4.6.
And because amplify_storage_s3_dart 0.4.5 depends on amplify_db_common_dart ^0.4.6 and no versions of amplify_storage_s3_dart match >0.4.5 <0.5.0, drift_flutter <0.2.0 is incompatible with amplify_storage_s3_dart ^0.4.5.
And because amplify_storage_s3 2.4.1 depends on amplify_storage_s3_dart ^0.4.5 and no versions of amplify_storage_s3 match >2.4.1 <3.0.0, drift_flutter <0.2.0 is incompatible with amplify_storage_s3 ^2.4.1.
So, because flexiform depends on both amplify_storage_s3 ^2.4.1 and drift_flutter ^0.1.0, version solving failed.

Closing as an amplify-related issue, there's not much we can do about this unfortunately :(


java.lang.AbstractMethodError: Method org/apache/kafka/connect/json/JsonSerializer.configure(Ljava/util/Map;Z)V is abstract

我看了下maven包中shade了很多其他包进去，但是没用relocation，其中kakfa这种flink中很常用的包，很容易和业务自己引入的kafka冲突。不清楚作者是否考虑调整下呢？

Closing this issue because it was created before version 2.3.0 (2022-11-10). Please try the latest version of Flink CDC to see if the issue has been resolved. If the issue is still valid, kindly report it on Apache Jira under project Flink with component tag Flink CDC. Thank you!


Change for Vietnamese developer

Do not translate all word into Vietnamese as it will not be meaningful

Thanks for the contribution. :+1:


Add distinct() operator

Sometimes it is useful to filter out consecutive duplicates from the stream of values. I don't see any immediate need for an implementation that filters out all values throughout the history though.
I can take on this improvement in a couple of days! Please assign this task to me if you decide that we do it :)

This would be great. I could use this if you implemented it.

@ivanmoskalev, that would be great. I guess it would work only with types conforming to Equatable?

Yes, exactly!

Closed, PR merged in


create "official" trino user names with more secure passwds

Recommend leaving the current names for now, the ones Humair created earlier, but we should start creating some more official names.  I am thinking like:
erik_erlandson
humair_kahn
vincent_caldeira
michael_tiemann
etc
Maybe also a couple of actual demo usernames, demo_user_a, demo_user_b, maybe just give these read/write access to demo1 catalog data, and read-only access to default and system catalog.
And giving these better (random) passwords. The first 10 characters of uuid or something.
We will need to create some usernames and passwords for people we on-board, ideally at least people attending training next friday.   cc @caldeirav @MichaelTiemannOSC

cc @HumairAK
initial users and user groups:

[ ] BNPP NLP: Jeremy Goh, Lea Deleris, Andra Anoaica
[ ] BNPP Entity Matching: Ludan Stoeckle, Rui Dias Morais, Patrycia Barros
[ ] Allianz (Many Workstreams, Leyla Javadova): David Winkel, Christian Meyndt, Ismail Demir, Tu Schmucker, Oleksandr Anufriyev
[ ] Ortec Finance: Bert Kramer, Joris Cramwinckel
[ ] EY: Mike Zehetmayr
[ ] OS-Climate: Michael Tiemann, Mike Platt

We should define trino user groups for the above,  by parent company/org:

[ ] bnpp
[ ] allianz
[ ] ortec
[ ] ey
[ ] osclimate

For now, all groups have read access to all current catalogs, schemas, tables. If and when there is a need for per-group access, we can work that out on a case by case basis.
All groups have write/create access to demo1

The Trino setup should be based on GitHub user groups and not by parent company, as per our data security architecture: https://docs.google.com/presentation/d/1eL2XKeBafPK8ZqhpKrqBiwygTcb--TsTouyz5Y7xjg8/edit#slide=id.gef587ef828_0_0
High level summary of requirements based on my thinking so far (to be validated with the dev team as we go along):

We should have one Trino catalog per repository doing ingestion or processing e.g. itr_data_pipeline catalog
Within the catalog, data sources would have their own schema in this catalog e.g. urgentem and lseg schema under itr_data_pipeline catalog. Also the streams will create their own schemas for processed data e.g. emissions based on urgentem + lseg + some corporate data
Default access to be given would be W at the catalog level for the entire GitHub team that has access to the repository i.e. os-climate-itr-tool-project-team has R access to itr_data_pipeline catalog
Access in RW mode at catalog level would be given to admin and developer sub-teams e.g. itr-data-pipeline-admin, itr-data-pipeline-developers in this case

When giving access to the outpuy of itr_data_pipeline, the idea would be to have a schema for this, and give schema level read access only to another team.

Hi, it's not clear to me which github orgs map to which users in the above list, can I get an explicit mapping in the form of:
<trino_group_name_1>:<user_1>,<user_2>
<trino_group_name_2>:<user_1>,<user_2>

...

@HumairAK  I have a proposal:  instead of using "firstname_lastname" let's define trino accounts that are the same as github account names.
This will have advantages:

it makes it easy to define mappings. github_team->user_group and github_user->trino_user.
the membership relationships are the same, and so can be derived directly from the github-org (and so also are easy to explain)
it is easy to remember your trino user name, it is just your github account
at whatever point we get true o-auth, the names remain the same

I will try to get specific names, but for now can you do users and groups corresponding to these github teams:

aicoe-osc-demo
os-climate-corporate-data-project-team
os-climate-itr-tool-project-team

If those are too long, can use corporate_data_project and itr_tool_project
for ref, see:
https://github.com/orgs/os-climate/teams

@erikerlandson can I get starter members for os-climate-corporate-data-project-team and os-climate-itr-tool-project-team

for xref:  https://github.com/operate-first/apps/pull/1010


Repository stars and watchers routes are allowed to access for all users even with no access to repository

Repository stars and watchers routes are allowed to access for all users even with no any unit rights to repository where all other repository URL's would return 404

There is no unit to include this two routes.

Yes, but at least it should be checked just like home handler on len repository units > 0

Should be fixed by #5314, close now and please feel free to reopen it.


Documentation & readme

The documentation site does not work for me.
Also in this comment you say:
https://github.com/almende/vis/issues/4259#issuecomment-466108361

It is maintained actively every week.

But coming here I read:

I intend to add features and fixes that are to my concern for my own projects. I will accept feature requests and merge requests, but will not prioritize them if not to my interest.

Which to me is kind of a mixed message. I got optimistic reading the comment, but was sort of disappointed reading the readme here. I can understand if its really the case though.

The documentation site does not work for me.

I know. I'm not available enough to really look in to why the examples are not working. Something got screwed on the way of fixing it. I do intend in fixing it when I'm available for it. It is on my top priority.

Which to me is kind of a mixed message. I got optimistic reading the comment, but was sort of disappointed reading the readme here. I can understand if its really the case though.

As I mentioned before, I do this project on my own time and for my own projects. I don't get paid for any of the work done here so I can't afford spending too much time here since I do have a full time job.
I intend on spending my free time working on this project. But only if I have the time and feel like doing the work.
The last few weeks have been busy and I can only spend minimal time dealing with issues. I hope to get to a less intense period of life soon and spend more time only this project. Until then, I will do my best to answer and accept PRs.

There is already a very good Example Repo, one could always refer to that until the doku-website gets fixed.


Extent L.mapbox.map

Hi I wanted to extend L.Map Like this
L.Map = L.Map.extend({
openPopup: function(popup) {
// this.closePopup(); // just comment this
this._popup = popup;
            return this.addLayer(popup).fire('popupopen', {
                popup: this._popup
            });
        }
    });

But i am using leaflet is there anyway to extent like so that i can prevent closing my marker popup
L.mapbox.accessToken = constant.accessToken;
var map = L.mapbox.map('map', 'mapbox.streets', {zoomControl: true});

Hi, great to hear that you find Leaflet useful!
However, this issue tracker is used for reporting bugs and discussing new features. For questions on using Leaflet, please use gis.stackexchange.com or stackoverflow.