Update Sapling protocol spec

Maybe fork the doc (including source) and make updates corresponding to the MASP?

Draft specifications used for Least Authority audit


Make get_collections mirror documentation

created with issue #159
Updates the get_collections/2 function and the get Still.Compile.Collections.find_files/2 functions to match documentation:
https://hexdocs.pm/still/templates.html#collections
The documentation appears to state that the get_collections/2 function will return the metadata for files based on strings under the tags key, in the slime file's headers.
This change updates relevant functions to make this change.

Hey @michaeldelago thank you for opening a fix! I think that for the metadata change, the documentation is wrong. We never really deal with "metadata" alone, we always use the SourceFile struct everywhere. What do you think?


term_font: add qterminal support

Description
self-explanatory
Issues
Works only after the user changed and saved some settings.

LGTM :+1:


Attempt to fix the Windows package

On Windows we only get static libraries!  Whoops. Better system in place now. Also don't provide manual pages in the package.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


fix: publish step was failing after switch to hybrid packages

Publish step was failing because the prepack script was executed by lerna in the package's folder.
This is failing for an unknown reason.
Running yarn workspace package_name build is working though.
To bypassa the issue the prepack lifecycles has been removed and the publish job has been moved to the Test_Lint job that has been renamed.
This way we can ensure that the packages are build before deploy.
This way we will always build all packages, whether before we were building only changed packages. This process is cheap and fast so we don't bother the trade off just yet.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Other information:

Closing in favor of https://github.com/microph1/microphi/pull/79

Closing in favor of 79


bond_core: 1.7.19-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository bond_core to 1.7.19-0:

upstream repository: https://github.com/ros/bond_core.git
release repository: https://github.com/ros-gbp/bond_core-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.5.25
previous version for package: 1.7.18-0

bond

No changes

bond_core

No changes

bondcpp
* fix unused var warning
* Contributors: Mikael Arguedas

bondpy

No changes

smclib

No changes

waiting for other packages...

Good to go, feel free to merge if no sync planned


adds the prefetch attribute on internal Link

Hello @JulianCataldo,
Thank you for your awesome astro components. I was looking for a Link component which will adds the rel=nofollow attribute on anchors targeting external pages but also rel=prefetch for internal pages, for prefetching with @astrojs/prefetch. Would you be interested in this change ?

Interesting idea! Thank you.
Indeed the solution I've put up is much more basic than the official integration
https://github.com/JulianCataldo/web-garden/tree/develop/app/HoverPrefetch
I think it didn't existed at that time, or they were released at roughly the same time, as it was a recurring demand from users (hence, why I did it :p).
Using the rel=prefetch makes the process fine-grained, I guess.
I admit I didn't chimed in much in that topic as I found myself not using prefetching much.
I work mainly with SSR now (where it's not a good fit), but I could get back to this topic in a indeterminate amount of time, though :p.
I certainly would welcome a PR with pleasure, with a little line in the docs explaining the feature / behavior ^^

I've tested it and implemented it, it works well with the Astro prefetch :) TY
BTW I may implements rel=prefetch detection in HoverPrefetch, too.


[zh] Localize 'stateless_apps'

[ ] Localize the content/en/stateless_apps.md to content/zh-cn/ in dev-zh.

I would like to contribute to this, Thanks


zip align broken

Hello Rich,
We had this chat a few months ago by mail. To recapitulate:
The zip align stuff is not working properly (you can use google's android tools to check it).
I might have still a working fix for this ready to merge (PR?) before branches diverge too much.
Would you like me to PR it ?
Keep up the good work

r-lyeh

ping @richgel999

ping @richgel999


Reset for testing

In one of my tests I was capturing all events, something like this:
global.bus.onAny( () => {
  console.log('Event')
})

That was fine for a while, but once I told my test suite to --watch my code I started getting the log repeated. The number of duplicated log lines increased every run.
Obviously the cause was that now under --watch the test suite never ended properly (the process never terminates). A new listener was attached every time the test ran.
I thought that a way to remove all listeners was just global.bus.removeAllListeners() but that did not work. I did try with a whole new instance global.bus = new EvetEmitter2() that did solve the original problem, but introduced lots of nasty side effects because some other parts of my code remembered the old bus instance.
Currently I am solving my test resets with global.bus._all = [] but that is just a dirty hack. Is there any more elegant solution?

Using global.bus.offAny() with no argument should clear the listener list. Seems like this is missing from the docs.
A PR with the documentation changes would be very welcome!

Did not work for me. But I managed to create a very clear example of my problem
https://gist.github.com/fgarcia/043c1afac5a5b6ef6edd4aed739a8cb0
The bus.offAny() raises an exception
I think the whole gist is a good note about how to use EventEmitter safely

Closing the issue for the time being because I am trying to understand myself this topic. Right now I can't tell apart clever ideas from tragic mistakes.


"Drăgănești", "Bărăitaru", "Belciug", "Cornu de Jos", "Hătcărău", "Meri" and "Tufani" villages are listed in the drop-down menu

The villages are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Type "Drăgănești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Drăgănești, PRAHOVA (Drăgănești)".

Step 2
Type "Bărăitaru" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Bărăitaru, PRAHOVA (Drăgănești)".

Step 3
Type "Belciug" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Belciug, PRAHOVA (Drăgănești)".

Step 4
Type "Cornu de Jos" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Cornu de Jos, PRAHOVA (Drăgănești)".

Step 5
Type "Hătcărău" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Hătcărău, PRAHOVA (Drăgănești)".

Step 6
Type "Meri" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Meri, PRAHOVA (Drăgănești)".

Step 7
Type "Tufani" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Tufani, PRAHOVA (Drăgănești)".


Start scheduler for persisting index segments before recovery

Currently, we recover all index segments before scheduling background thread for persisting them. During the scenario where a server is recovering lot of index segments, restarts (by nurse job, etc) results in recovery process to start from beginning since we didn't persist any of the index segments in background.
This PR starts background thread for persisting index segments before recovery process

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (770457e) 72.14% compared to head (d577ed6) 17.02%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2623       +/-   ##
=============================================
- Coverage     72.14%   17.02%   -55.12%
+ Complexity    11400     2882     -8518
=============================================
  Files           806      806
  Lines         65234    65234
  Branches       7951     7951
=============================================
- Hits          47060    11107    -35953
- Misses        15578    53311    +37733
+ Partials       2596      816     -1780

Files
Coverage Δ

...n/java/com/github/ambry/store/PersistentIndex.java
89.97% <100.00%> (-0.61%)
:arrow_down:

... and 632 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Import Issues. Can't find variable: Title

react-native, react and native-base version
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Expected behaviour
Importing Header and related components from 'native-base' should give me the Header component to use in my code.
Actual behaviour
Header and related components are not being imported, causing the app to produce the error message ReferenceError: Can't find variable: Title
This is what my IDE (Webstorm) shows me

Any other additional info which would help us debug the issue quicker.
This is my first time using native-base, maybe there are extra steps required to actually use the components? Not sure, but I did check that I had native-based included in my node modules.

@josephthweatt Delete node_modules, yarn.lock or package.json
Install node_modules, clean build, run

@SupriyaKalghatgi Sorry I didn't get back to your reply. The proposed solution did not work for me, but I was able to get my IDE to recognize the components and build the code by commenting out the import lines in native-base's index.

However, I do not know how I can create a permanent solution for this issue. In addition the component I was trying to display (the header) only shows as a slim rectangle in the top center. This maybe a separate question, but I was wondering if the examples being shown here are only a part of what is necessary to implement.

@josephthweatt which IDE?

@josephthweatt Check NativeBase-KitchenSink


Azure AI Studio

Hi,
Is this sample the best way to chat with your own data or should you use Azure AI Studio in the future? What is the difference between the two technologies?
Regards
Andreas

Good question @andreas-sommer-engenious.  To my mind, this is the "best" way to chat with your own data.
Others recommend Azure AI Studio for its ease (it is excellent) but when you want to change the front end, you need to clone the repo for the solutions locally, make changes and then deploy that repo, as you do here.
Doesn't appear as simple then, unless someone can advise I'm missing something?
In summary - AI Studio deployments for ease and this repo for a more complete solution.

We have a comparison with the "On Your Data" sample here:
https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/docs/other_samples.md
That's not Azure AI Studio though, exactly, that's Azure OpenAI Studio.
I personally prefer this approach for maximal code flexibility, but some audiences may prefer the AI Studio approach, especially if you're used to Azure ML workspaces.
We'll have sessions about both approaches at the upcoming RAGHack:
https://github.com/microsoft/RAG_Hack


[HOLD for payment 2023-08-08] [$1000] Dev: Web - App crashes when trying to unlink secondary contact method

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open a tab where account A is signed-in
Add secondary contact method B, and do not verify that contact method
Open a new window > Navigate to sign-in page
Enter secondary contact method B & click on the continue button
Click on 'unlink' button
Open email > copy 'validate link' > prefix the link localhost address > press enter

Expected Result:
App shouldn't crash & should unlink the secondary contact method
Actual Result:
App crashes
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.40-5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/98818a7a-638e-4f35-a9d3-45b16187726b
Expensify/Expensify Issue URL:
Issue reported by: @Natnael-guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689338260193289
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0125c02caca7cbee50
Upwork Job ID:<PHONE_NUMBER>782585856
        2023-07-21Automatic offers:

mollfpr | Reviewer | 25738337
StevenKKC | Contributor | 25738338
Natnael-guchima | Reporter | 25738340

Proposal
Please re-state the problem that we are trying to solve in this issue.
In the current Expensify app, attempting to unlink a secondary contact method leads to an application crash. This unexpected behaviour is triggered under the condition that the secondary contact method is unverified. This issue is particularly associated with the process of secondary contact validation and de-linking.
What is the root cause of that problem?
Investigation points to the translate function, which is used to handle language-specific translations of phrase keys in the application. It appears that when this function doesn't find a phrase key in the language dictionaries, it throws an error that leads to the application crash.
What changes do you think we should make in order to solve the problem?
A more robust alternative is to utilize the translateIfPhraseKey function which, unlike translate, returns the original message when a matching phrase is not found, rather than throwing an error. This graceful degradation prevents the application from crashing due to an error thrown.
Moreover, the translateIfPhraseKey function seems specifically designed for situations where the phrase keys might be dynamic or potentially non-existent in the language dictionaries, thus making it a more resilient choice.
Therefore, by replacing the translate function with translateIfPhraseKey in the specific code path related to unlinking secondary contact methods, we can avoid this issue and improve the overall robustness of the application.
Result:
https://github.com/Expensify/App/assets/65986357/24106626-7d92-484f-a096-4c970872238a

Proposal
Please re-state the problem that we are trying to solve in this issue.
App crashes when trying to unlink secondary contact method.
What is the root cause of that problem?
If unlink secondary contact method, unlinkLogin function will be called.
In this function, set account.message Onyx data to the translated message. (i.e. Secondary login successfully unlinked!)
https://github.com/Expensify/App/blob/ca8d279bec94f785e8247a7bdb8d3c62bcf5e126/src/libs/actions/Session/index.js#L763-L770
After unlink success, ONYXKEYS.ACCOUNT.MESSAGE will be displayed.
https://github.com/Expensify/App/blob/ca8d279bec94f785e8247a7bdb8d3c62bcf5e126/src/pages/signin/UnlinkLoginForm.js#L65-L72
Since props.account.message (i.e. account.message Onyx data) is already translated, and there is no Secondary login successfully unlinked! key in language dictionary, so the error is generated and app crashes.
What changes do you think we should make in order to solve the problem?
We should store message key to Onyx in order to display proper translated message.
    {
        onyxMethod: Onyx.METHOD.MERGE,
        key: ONYXKEYS.ACCOUNT,
        value: {
            isLoading: false,
-           message: Localize.translateLocal('unlinkLoginForm.succesfullyUnlinkedLogin'),
+           message: 'unlinkLoginForm.succesfullyUnlinkedLogin',
        },
    },

What alternative solutions did you explore? (Optional)
None.

Didn't get to triaging this bug, I'll take a look at it tomorrow!

The app isn't crashing for me but I'm not receiving the magic link after step 5 🐛

Thank you guys for the proposals!
I agree we should store localized messages in the Onyx with the phrase key instead the translated message. So the user will have the correct message shown based on their selected language. The proposal from @StevenKKC looks good to me.
🎀 👀 🎀 C+ reviewed!

Looks good 👍

Accepted the offer. Thanks👍

@mollfpr PR https://github.com/Expensify/App/pull/23561 is ready for review.

The C+ approval is on Jul 26, so this is still eligible for the bonus.

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/15811

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://github.com/Expensify/App/pull/15811/files#r1286197062

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

We have a checklist to ensure the copy/text is localized correctly in the reviewer checklist. So regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

(Web only)

Login App
Add a secondary contact method, and do not verify that contact method
Open a new window and navigate to the sign-in page
Enter the secondary contact method & click on the continue button
Click on the 'unlink' button
Open the email and copy the 'validate link'
Prefix the link localhost address and paste it to the address bar
Verify that the app does not crash

@Natnael-Guchima report $250 - paid ✔
@StevenKKC fix+bonus $1500 - paid ✔
@mollfpr review+bonus $1500 - paid ✔


Add quotes to cluster name in kurberos

In our environment clusters have number names. 10, 110 etc.
If i put it to kuberos configuration it will be converted to name: 10 , without quotes. Such yaml will conver to json with 10 as number, not a string.
When kuberos will try to load this configuration, json decoding will fail because it expects string there.
Signed-off-by: Alexander Shemshurenko<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md

@AlexShemeshWix please bump the chart version and sign the DCO

@AlexShemeshWix please bump the chart version and sign the DCO, thanks!

Bumped chart version

@AlexShemeshWix please sign the DCO


Do not set required = true in @JsonProperty for deserialization of properties

When deserializing a service response, we should not fail if a required property is not included in the response. This is a use case for OpenAI where the streaming response will not have some fields that are otherwise required for non-streaming responses.

Does it apply to "input-output" model, or "output-only" model?
We did a bit of this kind for x-ms-secret property (that even if required, won't return in response, and hence we don't add required=true to it).

There is another issue about ctor and Jackson. https://github.com/Azure/autorest.java/issues/2169
We may want to remove @JsonProperty from ctor.
These on ctor would cause failure if missing.
required = true on class variable won't cause failure.


added the slack button

@joemoe Couple of things… I think this might need a sync with master. Also, I can see the Slack and intercom button, is that what you want?

i'll do the sync with master. seeing both is intended.

OK, if that's what you want @joemoe then 'ack'


file:// URLs no longer work in chrome

Summary: file:// URLs used to work in chrome on linux, provided that the the user enabled "Allow access to file URLs" in chrome://extensions/. This stopped working fairly recently (March 2020?).
I've read #3 and the comment on the Chrome web store. #3 refers to firefox, so seems not directly relevant. The comment on the Chrome web store, which refers to #3, is undated. Because I know that file:// URLs have worked recently, that answer seems out-of-date.
I'm using Chrome 81.0.4044.92 on Ubuntu, with LivePage 2.7.0.
When I look at the background page, I see no messages at all (incl debug levels).
Thanks for this awesome extension. It's been extremely helpful for a couple of years and I'd love to recover this lost functionality.

Whoops. I put this in the wrong repo. Is there an egg-on-face emoji?


Migrate from tox to nox for test suite

Nox files are written in python rather than a custom syntax. Its api and cli output seem more intuitive.
https://nox.thea.codes/en/stable/

This has been done. I had to create a fork of nox that work with venv's rather than virtualenvs. Eventually nox will support this, but for now the fork lives at https://github.com/cs01/nox/tree/cs01/use-venv.


x/tour: moretypes: confusion between XOR and math.Pow

At the moretypes/14 page, x^y is used to mean exponentiation but the math package uses x**y. Also, the XOR version is prettier than the math.Pow version.

Dup of #11310

I believe this is fixed in https://go-review.googlesource.com/#/c/11134/3/content/moretypes.article by removing the reference math.Pow() (so the reader is no longer directed to documentation that uses the x**y syntax).


Add support for new ClimateEntityFeature.TURN_ON/OFF features

As per this blog post, we now need to flag ClimateEntityFeature.TURN_ON/OFF rather than these being implicitly activated.

Came here to note this - having just seen it in logs:
Logger: homeassistant.components.climate
Source: components/climate/__init__.py:371
integration: Climate ([documentation](https://www.home-assistant.io/integrations/climate), [issues](https://github.com/home-assistant/core/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+climate%22))
First occurred: 09:40:14 (12 occurrences)
Last logged: 09:40:14

Entity None (<class 'custom_components.fujitsu_airstage.climate.AirstageAC'>) does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method. Please create a bug report at https://github.com/danielkaldheim/ha_airstage/issues
Entity None (<class 'custom_components.fujitsu_airstage.climate.AirstageAC'>) does not set ClimateEntityFeature.TURN_ON but implements the turn_on method. Please create a bug report at https://github.com/danielkaldheim/ha_airstage/issues
Entity None (<class 'custom_components.fujitsu_airstage.climate.AirstageAC'>) implements HVACMode(s): off, cool, heat, fan_only, dry, auto and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/danielkaldheim/ha_airstage/issues

:tada: This issue has been resolved in version 1.1.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


doc: create a dedicated tab for 'silx view'

Is it what you expected? http://www.silx.org/doc/silx/latest/applications/view.html

yes perfect :star_struck:


English Version

Hi,
I just wanted to say thank you for creating this great material.
I wonder is there an English version for this repo?
Thanks

Hi buddy,
I appreciate that you like it.
I really prepared to create English version in the beginning, but I found I really don't have enough time to do it. So I just focus on Chinese version now.
If you or someone like to join us to create the English version together, I'll so happy.
Best

Sure, great I love to help as I currently learning c++ for game servers, I think this will be a good idea to translate at least the parts that I'm reading. Do you have any structure in mind? for example different repo? or a new folder structure?

I also attempted an English version in the early stages, but later on, I stopped. However, through practical experience, I tend to prefer separate repo. Please give me some time to prepare. Once the new repo is ready, I'll let you know.

Sure, great I love to help as I currently learning c++ for game servers, I think this will be a good idea to translate at least the parts that I'm reading. Do you have any structure in mind? for example a different repo? or a new folder structure?

Hello @AminSojoudi ,I created a new repo with name "GameDevMind-EN", the address is https://github.com/gonglei007/GameDevMind-EN, welcome to join it!

Hello Amin Sojoudi, thank you for your submission, I have merged your submission. You are now on the list of contributors.
What is your primary instant messaging tool? Do you use WeChat by any chance? (https://www.wechat.com/en/)
We have a game developer club here, with members from around the world, and we'd like to invite you to join.

Thank you.
Love to join your group but WeChat seems to be blocked in my country.

Or what other IM tool you are/can using, I can try it.  And how about leave an email to me. This is my personal email<EMAIL_ADDRESS>


Checkout Payment

I discussed this with @lauraluiz and we will do it like in the dmexco app, only prepaid is available and the others are hidden by css.


Test renaming file, huge diff PR

See #14360 comment
The issue here is:
Say you are renaming a file which is like ~1000LOC (used git mv old_name new_name). This is now committed and pushed to my test-renaming-file branch.
As expected when I make a PR to master from this test-renaming-file branch, I see zero lines of diff (which is nice since this is just a rename)
But now I make a new file which has the name old_name here filters.py. I write, say 2 LOC here. This new file with the old_name is now committed and pushed to the same test-renaming-file branch.
This is where the problem starts.
Now, GitHub thinks that I made a huge diff since it starts comparing this new file with the old_name to the actual old file in the master branch with the old_name. This leads to a huge diff.
Completely unacceptable. What should I do in such a case? Thanks!

Very sorry for the noise. This was meant for my fork.


Redshift connection using ODBC driver

we use azure plugin for Redshift connection using ODBC driver. How to configure new connection in sqltool for redshift using ODBC driver - system DSN.

AFAIK the PostgreSQL / Redshift driver from this repo doesn't support connecting with ODBC.


safely get global object

Description of your PR, including the what and why
Testing
Please, make sure to describe how you tested this change, include any gifs or screenshots you find necessary.

Oops, bundle size increase by more than 1kb 😢 can we check if we can possibly only either use this for the npm package or maybe find a lighter weight implementation? ( The CDN version doesn't need the pollyfill because webpack already pollyfills the global, it is only the npm package that needs it )


[move-prover] Specification of association.move, partial specs for li…

…bra.move
I created a new branch, since pushes to spec_libra_move were not working for reasons I do not understand.  I'm going to close that PR (#3955).  Wolfgang had a number of comments on it that I have addressed here.
This has a reasonably complete spec of association.move (so far as I know), and very partial spec of libra.move.  This is using doc gen a bit, but falls far short of what it should be.  This is not using the "first class types" that Wolfgang has in a pending PR.
The plan is to land this first, and Wolfgang can then make a pass over it to make it work with first-class types and improve the doc gen.
In association.move, there is a feature request that we should discuss later (let's land it first, though).
There is one property that doesn't hold (root is a member of the association). I need to discuss with Tim.  This also should not block landing.

Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r=wrwg

:pushpin: Commit d5d9421 has been approved by wrwg

:hourglass: Testing commit d5d942183cbac0155bf927ccab555f3fcb7fc89a with merge c310e66dfd3f1f77972be7f98c426095ffb3ef70...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: wrwg
Pushing c310e66dfd3f1f77972be7f98c426095ffb3ef70 to master...


Traffic to Service with no endpoints is dropped

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
We have a mixed setup of bare-metal servers and kubernetes cluster. We are using a LoadBalancer type Service which has some pods behind it. The same LoadBalancer IP is used in our bare-metal servers also.
When all the pods behind the LoadBalancer type Service is deleted, traffic originating from within the cluster to the LoadBalancer IP gets dropped (and that happens without any trace!). Only when the Service is deleted then the traffic gets routed to the bare-metal servers.
I would expect that when there are no pods traffic destined to Service IP should come out from the machine to the TOR based on the default route set on the worker nodes.
Cilium Version
cilium-cli: v0.16.3 compiled with go1.22.1 on linux/amd64
cilium image (default): v1.15.2
cilium image (stable): v1.15.3
cilium image (running): 1.15.2
Kernel Version
Linux 5.10.0-25-amd64 #1 SMP Debian 5.10.191-1 (2023-08-16) x86_64 GNU/Linux
Kubernetes Version
Client Version: v1.27.9
Kustomize Version: v5.0.1
Server Version: v1.27.9
Regression
No response
Sysdump
cilium-sysdump-20240405-063331.zip
Relevant log output
No response
Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

When all the pods behind the LoadBalancer type Service is deleted, traffic originating from within the cluster to the LoadBalancer IP gets dropped (and that happens without any trace!). Only when the Service is deleted then the traffic gets routed to the bare-metal servers.

You should be seeing a DROP_NO_SERVICE event in hubble. Or with https://github.com/cilium/cilium/pull/28157 active, an ICMP error response.

I would expect that when there are no pods traffic destined to Service IP should come out from the machine to the TOR based on the default route set on the worker nodes.

That's surprising - given that Cilium understands you're accessing a Service IP, why shouldn't it handle the access (and give you feedback as described above) ?

@julianwiedmann, I understand Loadbalancer type Service to be publicly routable based on the its description. Quoting from the official docs https://kubernetes.io/docs/concepts/services-networking/service/ which describes it as "Exposes the Service externally". It's not like ClusterIP which is specific to a cluster.
Hence I expected the traffic to go out from the Node if there are no pods behind it.


Show approvals on the PR listing page

As suggested in #8659, this PR displays the whitelisted approvals in Gitea's PR listing page if a given branch is protected and requires more than 0 approvals to be merged. I've chosen the eye Octicon but perhaps a person one would be better?

I've tested this works locally in the browser but as I'm on a Windows environment Docker doesn't work properly for the full test suite 😢 . This is also my first time using Go, so all suggestions (nitpicking) are most welcome!

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cb1048d). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master    #8762   +/-   ##
=========================================
  Coverage          ?   41.39%
=========================================
  Files             ?      539
  Lines             ?    69479
  Branches          ?        0
=========================================
  Hits              ?    28758
  Misses            ?    37025
  Partials          ?     3696

Impacted Files
Coverage Δ

models/branches.go
48.7% <ø> (ø)

routers/repo/issue.go
34.43% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb1048d...a25f336. Read the comment docs.

@jamesorlakin look at https://github.com/go-gitea/gitea/pull/8762#discussion_r341155966 ;)

I think you guys should consider the page load performance. Protected branches could be load once. Or I should send another PR to do that after this one.

Hi all,
Thanks for the comments. I've reworked it to now use a method similar to the last commit status - a map by PR ID for both required approvals and approved accepted ones.
6543 mentioned using GetUniqueApprovalsByPullRequestID. This would surely count all reviews on a PR, not just ones whitelisted needed for the PR to be merged? This raised a good point in my mind though - should the user see all approvals, or just ones relevant to the branch protection?
lunny, you're right, I didn't think about performance! 3 PRs rendered quick enough on my laptop... A to-do (assuming this approach looks okay) would be to cache protected branches during the loop - say a page had 25 PRs all for the same target branch, we would only need to load the ProtectedBranch once leaving just a call to GetGrantedApprovalsCount for each one.

The number of protected branches in a given repository should not be too large (3? 6? 10?). In my experience, it's more performant to load all of them at once rather than reaching for them one by one. Databases do that themselves: for example, for tables under a certain number of rows, indexes are never used for querying (only for updating); the database considers that reading one disk block is the "expensive" part; sorting/filtering is quickly done in memory. Context/process switching from Gitea to and from the database is costly as well.

For the number of approvals, I'd use a single database query, which is much faster than retrieving the information each time:

Collect all the issues/prs to show in the page using models.Issues() as normal, so pagination and other options are taken into account.
In a slice (array), collect all the ids for rows where .IsPull is true and .IsClosed is false.
If the number of ids collected is not zero, make one single query to the database counting approvals for those ids (using group by and count); load that into a map. For that, a method must be created in models/issue.go, where all database accesses should happen. That method should use sess.GroupBy("issue.id").Select("issue.id AS id, COUNT(*) AS count"); see CountIssuesByRepo() for an example.
Then that map can be used to display the info in the page.
Alternatively, the approval count can be moved into models.Issues() as well.

Hope this helps.

Thanks for the suggestions @guillep2k! Unfortunately I'm not sure I'm capable at dropping to such complex SQL (joining and comparing whitelisted approvers including teams, etc). That said, loading all protected branches at once initially could be better optimised than the individual looping - I'll try and do that.

ids for rows where .IsPull is true and .IsClosed is false.

I would be under the assumption closed PRs should show the same as open ones?
Moving forward, I'm also considering showing total approvals (not whitelisted) for PRs that aren't on a protected branch. This would just be a simple number next to the eye. If possible I'll want to grab all approvals for the PRs at once, and then do the whitelist filtering using a util function (similar to how GetGrantedApprovalsCount works, but without the query) - this may not go to plan...
I've since backported this to our production 1.9 instance and performance seems to be fine - though it's not a great representative measurement!

@guillep2k I can creat SQL statements but i dont know how to tell xorm to do the same :(
-> think @jamesorlakin need some help ...

@jamesorlakin do you still working on this?

@6543 yep I'm keen to finish it, but I likely won't have much time until the weekend. Feel free to tweak if you want to in the meantime 😃 .

@jamesorlakin what is the stats?

Hi all,
Apologies for the general radio silence - everything has been a tad busy of recent and it all generally got forgotten about 😥. In the meantime I've had a look around and #9274 seems to be a generally more polished implementation if you would like to go ahead with that.


DBeaver 24.2.4 Auto complete / Suggestion for table columns not showin

Description
Coming from community version 23.3.1, when I begin to type in my query, the table names will autocomplete/recommend, however the table column names are not suggesting like they use to.

DBeaver Version
Community Edition 24.2.4
Operating System
Windows 11
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Hi, @mmorehouse6 ! Thanks for creating the bug report. For now we're unable to reproduce the issue. Could you provide clear steps to reproduce your issue or record a short video showing how it happens for you?

Unfortunately, we have not been able to reproduce the reported behavior. Therefore, I am closing this issue. If the issue is still actual, please provide more information regarding it.


Idris: fix "addEnvHooks: command not found"  (#33820)

Motivation for this change
On the current head 'addEnvHooks' doesn't seem to be available in 'preHook'.
This patch tries to stay as close as the original by moving the code to
'setupHook' and changing the ln options.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ? ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"

Packages that depend on this are already broken, but that is something for a different issue.

[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Because I'm not working with Idris anymore and this PR is not a proper fix, therefore I've decided to close this pull request.


compile mow code compile error

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #44439
Problem Summary:
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[x] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[ ] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall


Fix brazilian ddds.

Filter Brazilian DDD's, blocking invalids DDD's.

Font: http://www.embratel.com.br/Embratel02/files/secao/06/13/365/codigos_ddd.doc

Thanks for this PR @jasperes! Sorry we missed it at the time.
This is working as intended.
We don't want more specific leading digits for the "(\d{2})(\d{4})(\d{4})" formatting pattern in Brazil, [1-9][1-9] is intentional. The leading digits are only used for formatting numbers, not to determine validity. The  pattern is more specific, and that's what's used for validity.
You can check the demo to verify: http://libphonenumber.appspot.com/phonenumberparser?number=23+0000+0000&country=BR
23 0000 0000 is invalid but possible. It gets formatted as (23) 0000-0000 in national format.


Peer Review - Karan/Sakariya

The seasonality effect of rental bikes can be explored more.
Computational time can be included in the model output as done by Karan's Team
Research question on readme.md

Plots done, you can find them here.

point 3 is done

computational time added

All the issues have been fixed! point 1 is optional


Can not use ROAPI/connector-X support to connect

Steps to reproduce the behavior (Required)
Use ROAPI to connect starrocks
Expected behavior (Required)
Real behavior (Required)
WARN connectorx::sources::mysql] mysql text prepared statement error: MySqlError { ERROR 1064 (HY000): Unsupported command(COM_STMT_PREPARE) }, switch to limit1 method
Error: Database error: MySqlError { ERROR 1064 (HY000): Unsupported command(COM_STMT_PREPARE) }
StarRocks version (Required)
2.5.1

@ulnit  Has the problem been solved？


Add rapids_cpm_cccl feature.

Description
This PR adds a new function rapids_cpm_cccl that adds CCCL from the new monorepo. This will eventually replace rapids_cpm_thrust and rapids_cpm_libcudacxx.
Checklist

[x] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The cmake-format.json is up to date with these changes.
[ ] I have added new files under rapids-cmake/

[ ] I have added include guards (include_guard(GLOBAL))
[ ] I have added the associated docs/ rst file and update the api.rst

/merge


[5.6] soft delete $joins issue fixed for PHP7.2

Fixes #22162

@Dylan-DPC See https://github.com/laravel/framework/issues/22162#issuecomment-346275696. 😉

Damn. Wouldn't this be a better way of fixing it rather than typecasting it to array everywhere else?

Closing since this has already been fixed

Damn. Wouldn't this be a better way of fixing it rather than typecasting it to array everywhere else?

Maybe this would be desirable, but it would require more changes - this single line change was breaking 5 tests. There are also other attributes in this class that would require the same refactoring. We've found here that there's at least a room for improvement in the docblocks of these attributes. 😄

but it would require more changes

How?

@Dylan-DPC This single change was changing the expected SQL code in a weird way: https://travis-ci.org/laravel/framework/jobs/305658674 Look that there's an extra space in the generated SQL code in every failed test.
Those files/lines were being affected:
https://github.com/laravel/framework/blob/5.5/src/Illuminate/Database/Query/Grammars/MySqlGrammar.php#L108
https://github.com/laravel/framework/blob/5.5/src/Illuminate/Database/Query/Grammars/SqlServerGrammar.php#L312
https://github.com/laravel/framework/blob/5.5/src/Illuminate/Database/Query/Grammars/Grammar.php#L723

Oh yes true. We could change the isset() to empty check or something similar. But still way better than remembering to typecast all counts right?

@Dylan-DPC Yep, there's a room for non-breaking improvements in all those attributes that are always handled as arrays. 👍  😉


Support Mongoose Discriminators

This package is lacking support for mongoose discriminators without dropping into the mongoose API directly. This could be implemented into the existing decorator pattern in a few ways.
One option is to accept an entity as an argument to the @Entity() decorator, this would enable the syntax to be @Entity(ParentEntity). This is by far the easiest solution to implement because we wont need to worry about whether or not the parent entity has been compiled or not yet.
Another more involved solution would be to enable using the native extends keywords to handle it. this would require navigating through the prototype chain, ensuring that each parent is compiled, preventing recompiling errors, and ensuring the discriminator api is used internally rather than following through the prototype chain. The root entity must still extend Model in order to receive the proper typescript types.
This options syntax would result in the following:
@Entity()
export class ChildEntity extends ParentEntity {}

Completed. Available in v0.5 using the extends syntax.


Retract v0.0.1 version

Description
Running go get github.com/kyma-project/kyma-environment-broker will resolve v0.0.1 to the latest version and override the real latest version without the 'v' prefix. Retracting v0.0.1 should fix this.
For more details see https://go.dev/ref/mod#go-mod-file-retract
Changes proposed in this pull request:

Retract v0.0.1 version

Related issue(s)

/kind enhancement


Asking about C3D and PCPA

Hi,
I am looking into your model and benchmark. Since you might be experienced in this topic, I'd like to ask about some details in C3D and PCPA model. From the aspect of coding, there are two operations: 1. directly using C3D model by calling C3D class; 2.keeping C3D model in PCPA class with removing other features: speed, box, pose as well as the attention modules. Will these two operations get same results? In my view, they both use only C3D model for prediction. Otherwise, do they have differences in detail?
I am interested in these models and want to do some exploration based on your repo. Could you answer it for me?
Thanks,
Haolin

Hi,
C3D without the top layer is used as one of the processing streams in PCPA, the C3D network was not modified. If you remove other streams (RNN encoder-decoders for speed, box, pose) and attention modules from PCPA, you'll get a C3D. The results from the stripped PCPA and C3D should be the same as long as the dense layers are the same.

Hi,
C3D without the top layer is used as one of the processing streams in PCPA, the C3D network was not modified. If you remove other streams (RNN encoder-decoders for speed, box, pose) and attention modules from PCPA, you'll get a C3D. The results from the stripped PCPA and C3D should be the same as long as the dense layers are the same.

Hi,
C3D without the top layer is used as one of the processing streams in PCPA, the C3D network was not modified. If you remove other streams (RNN encoder-decoders for speed, box, pose) and attention modules from PCPA, you'll get a C3D. The results from the stripped PCPA and C3D should be the same as long as the dense layers are the same.

Thanks for your reply!
I still have one question about Input date in PCPA model.
in 'action_predict.py' line 3128:
conv3d_model = self._3dconv()
network_inputs.append(conv3d_model.input)
I read the code carefully and know it feeds the 'local_box' into the C3D model.
Since I previously used Pytorch and is not familiar with Tensorflow, I have a question: how does model know .input is the image data.  Why not use like
network_inputs.append(Input(shape=data_sizes[i], name='input_' + data_types[i]))
conv3d_model = self._3dconv(input = network_inputs[0])
?
If I want to add a channel to feed local_context into a parallel C3D model in PAPC, can I use code as following?
conv3d_model = self._3dconv()
network_inputs.append(conv3d_model.input)
conv3d_model2 = self._3dconv()
network_inputs.append(conv3d_model2.input)
or how can I realize the following Model? now the feature is [local_box, local_context, speed, box, pose]
local_box -->C3D----------------------------------------fuse
local_context --> C3D (new channel)-------------------fuse (new parallel C3D model)
pose--->gru---------------------------------------------fuse
speed-->gru--------------------------------------------fuse
box-->gru---------------------------------------------   fuse
Could you help me with this?
Sincerely,
Haolin

Hi,
C3D without the top layer is used as one of the processing streams in PCPA, the C3D network was not modified. If you remove other streams (RNN encoder-decoders for speed, box, pose) and attention modules from PCPA, you'll get a C3D. The results from the stripped PCPA and C3D should be the same as long as the dense layers are the same.

Thanks for your reply!
I still have one question about Input date in PCPA model.
in 'action_predict.py' line 3128:
conv3d_model = self._3dconv()
network_inputs.append(conv3d_model.input)
I read the code carefully and know it feeds the 'local_box' into the C3D model.
Since I previously used Pytorch and is not familiar with Tensorflow, I have a question: how does model know .input is the image data.  Why not use like
network_inputs.append(Input(shape=data_sizes[i], name='input_' + data_types[i]))
conv3d_model = self._3dconv(input = network_inputs[0])
?
If I want to add a channel to feed local_context into a parallel C3D model in PAPC, can I use code as following?
conv3d_model = self._3dconv()
network_inputs.append(conv3d_model.input)
conv3d_model2 = self._3dconv()
network_inputs.append(conv3d_model2.input)
or how can I realize the following Model? now the feature is [local_box, local_context, speed, box, pose]
local_box -->C3D----------------------------------------fuse
local_context --> C3D (new channel)-------------------fuse (new parallel C3D model)
pose--->gru---------------------------------------------fuse
speed-->gru--------------------------------------------fuse
box-->gru---------------------------------------------   fuse
Could you help me with this?
Sincerely,
Haolin

Sorry, but only the existing codebase is currently supported, such as issues related to running the code or using the data, not creating new functionality.


compile bug

Describe your bug here.
i got this error
source/Achievements.hx:132: characters 30-54 : Warning : FlxCamera.defaultCameras is deprecated, use FlxG.cameras.setDefaultDrawTarget instead
source/MainMenuState.hx:69: characters 3-39 : Warning : FlxCamera.defaultCameras is deprecated, use FlxG.cameras.setDefaultDrawTarget instead
source/PlayState.hx:369: characters 3-39 : Warning : FlxCamera.defaultCameras is deprecated, use FlxG.cameras.setDefaultDrawTarget instead
source/editors/CharacterEditorState.hx:94: characters 3-41 : Warning : FlxCamera.defaultCameras is deprecated, use FlxG.cameras.setDefaultDrawTarget instead
source/editors/DialogueCharacterEditorState.hx:87: characters 3-40 : Warning : FlxCamera.defaultCameras is deprecated, use FlxG.cameras.setDefaultDrawTarget instead
source/options/NoteOffsetState.hx:57: characters 3-39 : Warning : FlxCamera.defaultCameras is deprecated, use FlxG.cameras.setDefaultDrawTarget instead
C:\Users\azizd\Downloads\vs-a&o-source-code\FNF-PsychEngine-0.6\export\release\windows\obj>setlocal enabledelayedexpansion
Warning: Could not find Visual Studio 2017 VsDevCmd
Missing HXCPP_VARS
Error: Could not automatically setup MSVC
how can i fix this?
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
no

You need to install MSVC v142 - VS 2019 C++ x64/x86 build tools and Windows SDK (10.0.17763.0) from VSC.


Error parsing config file

Windows user reported an error when parsing configuration file.

Looks like it's fixed, but not sure why:
https://www.reddit.com/r/WakaTime/comments/n5ujt9/wakatime_error_vscode/gyaexzk
We should keep an eye out for this in case it's still happening, but will close for now.

We needed to strings.Trim(param, `'"`) from --config because there were extra quotes wrapping that argument due to a space in the file path.


Create button with icon as standard body component

I often use buttons with icons into my emails. Here the outcome:

Right now, I am creating basic table to achieve it. An example of the code:
<mj-column width="270px" background-color="#78B927">
        <mj-table>

                  Contact

        </mj-table>
      </mj-column>

Do you think you can create a standard body component to make it smoother?

You can already embed an img inside mj-button as you can paste any HTML inside mj-button. ex : https://mjml.io/try-it-live/HJ98AlUMS
For a left/right icon inside the button I think you should do a custom component for that.

FYI won't work in many clients. icon has offset or text is missing. tested it with litmus.

Just tested and it works fine, the logo overflow in Outlook but this can be solved by adjusting the natural width of the image tho. You can still wrap the content in a table with 2 td one for the image one for the text it would work just fines

some proofs.
code:
<mj-button padding="0 10px 10px" css-class="region region-link" align="left" href="#" inner-padding="10px 0" background-color="#efefef" mj-class="webfont-sm" color="#af3393">   Button Link</mj-button>
outlook2019:

office 365 windows:

office 365 chrome:

Text could disappear because of non valid href for some clients try to remove href="#" or use a valid temporary like href="https://google.com"

veritcal-align:middle is already aligned. see code above will text the href attribute. thank you ryusa!

Text could disappear because of non valid href for some clients try to remove href="#" or use a valid temporary like href="https://google.com"
For the vertical align issue you can just try to apply veritcal-align:middle on img tag that should work

did not know that makes the difference. thank you!! label is there now. but vertical offset remains

You can use table inside your button. I tried it and it seems working on main clients like gmail / outlook/ apple.
https://mjml.io/try-it-live/tedYB7ZfKwh

If you should avoid putting a table inside mj-button as some client doesn't support  with
, making the link not clickable even it renders fine.

If you should avoid putting a table inside mj-button as some client doesn't support  with
, making the link not clickable even it renders fine.

Oh my bad, So do you recommend anything else in particular to solve this problem?

You can already embed an img inside mj-button as you can paste any HTML inside it. ex : https://mjml.io/try-it-live/HJ98AlUMS
For a left/right icon inside the button I think you should do a custom component for that.

This 😄

some proofs.
code:
<mj-button padding="0 10px 10px" css-class="region region-link" align="left" href="#" inner-padding="10px 0" background-color="#efefef" mj-class="webfont-sm" color="#af3393">   Button Link</mj-button>
outlook2019:

office 365 windows:

office 365 chrome:

Yes, I was talking about this issue

i can confirm that too. putting the img tag inside a button is not sufficient. where need a component here for sure :-D

There's not so much that can be done here as vertical-align on older outlook clients isn't supported without a wrapping table, and adding a table inside an anchor would degrade the clickability of the button.

i have better solution
https://mjml.io/try-it-live/u9caI30uD
Preview: - https://mcusercontent.com/58cc6fdf204aea6e7442682a9/images/1699d488-aca4-5862-7003-7da2ed012961.jpeg
<mj-section padding="24px 0px" background-color="#FFFFFF">         <mj-column>         <mj-social align="left" padding="0px 35px 35px 35px" mode="horizontal">           <mj-social-element font-size="14px" line-height="17px" icon-size="1px" icon-height="1px" color="#292D34"                    align="left" font-weight="700" padding="0px" href="www.example.com"                    src="https://mcusercontent.com/58cc6fdf204aea6e7442682a9/images/ff91363e-68a6-b542-160e-                    e2def8f82726.png"> Find out more              </mj-social-element>           <mj-social-element icon-size="16px" icon-height="17px" padding="0px"                    src="https://mcusercontent.com/58cc6fdf204aea6e7442682a9/images/a90930c2-5ec4-e8ba-d1a3-                    101687fa8914.png">          </mj-social-element>        </mj-social>         </mj-column>     </mj-section>

i have better solution
https://mjml.io/try-it-live/u9caI30uD

<mj-section padding="24px 0px" background-color="#FFFFFF"> <mj-column> <mj-social align="left" padding="0px 35px 35px 35px" mode="horizontal"> <mj-social-element font-size="14px" line-height="17px" icon-size="1px" icon-height="1px" color="#292D34" align="left" font-weight="700" padding="0px" href="www.example.com" src="https://mcusercontent.com/58cc6fdf204aea6e7442682a9/images/ff91363e-68a6-b542-160e- e2def8f82726.png"> Find out more   </mj-social-element> <mj-social-element icon-size="16px" icon-height="17px" padding="0px" src="https://mcusercontent.com/58cc6fdf204aea6e7442682a9/images/a90930c2-5ec4-e8ba-d1a3- 101687fa8914.png"> </mj-social-element> </mj-social> </mj-column> </mj-section>

very creative! does it look good across mail clients?

@nicmare yes, it looks good. I have tested on email on acid


GitHub Workflows

... and sonarlint

I think I've waited long enough for this PR to be reviewed. I'm wondering if you two are still interested in doing this.


Remove easy to misuse Buffer api that accidentally copies data

Which issue does this PR close?

Closes #6033.
Rationale for this change

What changes are included in this PR?
In addition to removing the From api, I also added From<&[u8]> and From<[u8; LEN]> etc api, trying to reduce the breakage.

Are there any user-facing changes?

Oh I accidentally closed it..

Oh I accidentally closed it..

I've kept the api unchanged, but updated the code to not using it. So it should not break any existing code.
Once we are ready to introduce api change, we should replace https://github.com/XiangpengHao/arrow-rs/blob/buffer-api/arrow-buffer/src/buffer/immutable.rs#L361-L370
with
impl From<&[u8]> for Buffer {
    fn from(p: &[u8]) -> Self {
        Self::from_slice_ref(p)
    }
}

impl<const N: usize> From<[u8; N]> for Buffer {
    fn from(p: [u8; N]) -> Self {
        Self::from_slice_ref(p)
    }
}

impl<const N: usize> From<&[u8; N]> for Buffer {
    fn from(p: &[u8; N]) -> Self {
        Self::from_slice_ref(p)
    }
}

I think we need to revert this as it is a breaking change?

This pr does not break api, it just avoid using that api

Thank you @XiangpengHao and @wjones127  and @tustvold  -- this is quite a nice change

https://github.com/apache/arrow-rs/pull/6043 is tee'd up for the next major release

The goal of above helper functions is to not break too many code and make it easier for user to migrate to the new api.
Basically, it asks user to explicitly call to_byte_slice() or explicitly pass an array that is obvious to user that it needs a copy.

I think this is done in https://github.com/apache/arrow-rs/pull/6043
Maybe you could add some doc comments to Buffer on https://github.com/apache/arrow-rs/pull/6043  with this context @XiangpengHao  (specifically, add the rationale of why the APIs are structured the way they are -- "to make it clearer when copying is occuring").
What code actually does can always be found by reading it, but why it was written that way is often not as easy to figure out. Thus I think comments focused on the why can be very helpful


Appending a zero to some integers

When I extract the data from the PDF som of the data has a zero appended to it.
 If you copy-paste the text of the table or run a pdftotext operation on the page, it reveals a big matrix of zeroes that seem to underlie the table.

Thank you for the feedback. So it just a crappy produced PDF. Love local government.


Adding more documentation to tracker events

Nice!
In addition to my two other comments, could you put property and event names in inline code notation?
It's my first time doing anything fancy with pull requests, like requesting modifications, but I believe it's possible to update pull requests?
Thanks for the contribution.

I've improved the formatting, please take a look when possible.

Thanks for the additions.


Some banking apps will detect Xposed hooks

Some banking apps (e.g. VCB Digibank, BIDV... and several banking apps in Vietnam) detect Xposed hooks when you enable the module. I don't think there is a solution for this, but it would be awesome if this is solvable.

Some banking apps (e.g. VCB Digibank, BIDV... and several banking apps in Vietnam) detect Xposed hooks when you enable the module. I don't think there is a solution for this, but it would be awesome if this is solvable.

Looking at this guy's profile I will assume he is also a Vietnamese like all of us (surname is a dead giveaway), and surprisingly he overlooked all of this. I really hoped it will work in the future to reduce steps for rooted users.
Currently you can configure Tasker app to automatically disable accessibility services when you open a banking app, works for both rooted and nonroot users.
Guide (vozforums): https://voz.vn/t/cac-app-ngan-hang-dang-bat-dau-cap-nhat-chan-cac-ung-dung-khac-truy-cap-ho-tro-tiep-can-accessibility.812505/post-27046403

Some banking apps (e.g. VCB Digibank, BIDV... and several banking apps in Vietnam) detect Xposed hooks when you enable the module. I don't think there is a solution for this, but it would be awesome if this is solvable.

Interesting!
A guy in XDA also mentiond BIDV app. I gave these apps a quick try. VCB Digibank allows me to continue with login screen (still theres nag saying im rooted) I dont have an account to continue unfortunately. BIDV stops me with "debug device" warning... perhaps thats another check. Im using neither of them so Im still fine I guess. Its understandable that apps may behave differently. When I have more time I will definitely give a little more of digging.
Feel free to come up with ideas. Im all ears!

Some banking apps (e.g. VCB Digibank, BIDV... and several banking apps in Vietnam) detect Xposed hooks when you enable the module. I don't think there is a solution for this, but it would be awesome if this is solvable.

Looking at this guy's profile I will assume he is also a Vietnamese like all of us (surname is a dead giveaway), and surprisingly he overlooked all of this. I really hoped it will work in the future to reduce steps for rooted users.
Currently you can configure Tasker app to automatically disable accessibility services when you open a banking app, works for both rooted and nonroot users. Guide (vozforums): https://voz.vn/t/cac-app-ngan-hang-dang-bat-dau-cap-nhat-chan-cac-ung-dung-khac-truy-cap-ho-tro-tiep-can-accessibility.812505/post-27046403

I dont know if nationality has anything to do with all this but thanks anyway. I see quite a few people using Tasker for that and it seems to work. Theres also another way of using Tasker: use variable to temporarily unset/reset the enabled_accessibility_services secure flag. Im not entirely sure if it works though.
I have an idea of making an app that can:

switch enabled_accessibility_services on/off using Quick Settings tile
with android.permission.READ_LOGS permission one-time granted by adb, the ability to switch on/off automatically when target apps open..

Lets see if I can make time for it..
Cheers!


fix: Arbitrary file access during archive extraction ("Zip Slip")

Refs: CU-8694945dk

Task linked: CU-8694945dk Zip Slip


fix(topology): moves base styles to plugin form component

Fixes: https://github.com/janus-idp/backstage-plugins/issues/251

verified the changes locally
LGTM!


Cons agg markov

Another attempt to merge my AggShockMarkov model into a dev branch on Edmund's fork.  Hopefully I chose the right branch this time.

Merging, hopefully this is safe.  But branches are cheap.


separated and cleaned up tutorial and test data directories

thanks @gregcaporaso ! I added the link. Note it will only work once this PR is merged.

Changes Unknown when pulling 17315e538dbb04f5155a91c742768a37464b88e0 on nbokulich:fix-test-data into ** on qiime2:master**.


[Bug]

Describe the bug
Newest update, 2.2.0, breaks the plugin and it no longer works
To Reproduce
Steps to reproduce the behavior:

Update to 2.2.0 or download 2.2.0
Tried to send an emoji
Doesn't work anymore

Expected behavior
The emojis are supposed to embed, but instead it just sends the text of the emoji
Screenshots

OS: [e.g. Windows 10]
Version [e.g. 2.1.1]

Additional context
none of the emojis are appearing when you type ":" except default ones

Still works for me, make sure you have the latest BD and restart discord.

Oh I didn't realize that discord wasn't updated, Sorry! That fixed it-


When will 2.0.0 be released to support sw8?

When will 2.0.0 be released to support SW8?
expect

If it's a blocker for you, please build the package yourself, we'll try to do a release as soon as possible


DOM not updated after initial page load?

With the masonry demo, after scrolling down a bit to get beyond initial load, I right-click an image to view the filename (https://i.imgur.com/Nxi4Psx.jpg) but when I 'view source' that doesn't appear.
I've been having trouble trying to change the 'src' of an img upon click, but it only works for items in the initial load, so I'm thinking its something with the DOM?

The problem was with my javascript for onClick event.
I wanted an ajax process to kick off when clicking a small heart [for each item], so the item would be marked as a favorite.
Using this, it worked for the 1st page but not for ensuing items via infinite scroll:
$(".item-favorite-link").click(function(event){
But this works for all items:
$("body").on("click", ".item-favorite-link", function(){
Anyway, might be helpful for someone else.


Toogle and switches

@liyokuna COLOUR CONTRAST: put for example black on white instead of white on orange background DEFAULT STATE OF CHECKBOXES : the default state is "checked" instead of " unchecked" See the components toogles and switches.

Also:

[ ] remove o-switch → Orange Switches
[ ] test and improve Bootstrap switches?

Orange Switches will be dropped in v5 and are marked as deprectaed in v4. See #283.
FWIW, colors are defined by Digital Brand Guidelines, and default state is not component-side: only implementation that can change for each use case.


macrocytosis - remove synonym megaolcytosis (typo)

Remove megaolcytosis (typo) as a synonym for macrocytosis MP:0000248

Done.


Fixed JWT expired token being logged as unhandled error

Closes #5601.

Properly handle valid errors such as JSONWebTokenExpired coming from invalid JWT payload;
Allow to toggle JWT verification whether DEBUG is enable or not (useful for testing each mode);
Added the default value of JWT_EXPIRATION_DELTA as it allows the users to customize it if needed or at least know how long a token stays valid.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[x] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[x] Changes are mentioned in the changelog

Why not add time expiration as an environment parameter ??

@JrmyDev what do you mean by optional?

@NyanKiyoshi : I mean we could set JWT_EXPIRATION_DELTA as an environment variable instead of editing settings.py

I don't really expect users to want to edit that value. Unless there is an actual use case?

Isn't this parameter the session duration ??

The time before the token must be refreshed.

Ok, sorry i misunderstood...
Is there a parameter for session duration?

No, as long the client refreshes the token, it's all good.


Headless export doesn't generate .godot/global_script_class_cache.cfg properly when global script classes are used

Godot version
4.x
System information
Fedora 37, ubuntu:latest
Issue description
When a repo with a Godot 4.x project is cloned and godot --headless --export-release <NAME> <PATH> is executed, it will fail to find GDScript classes (those not attached to any Scene or Resource but used as global resources).
Locally, it can be worked around by executing the Godot Editor once without using the --headless option, to let it create the .godot subdir. Therefore, the headless export depends on files in .godot which it cannot create by itself.
Precisely, if .godot/global_script_class_cache.cfg is added to SCM, the headless run with an otherwise empty .godot will succeed.
However, with Godot 4.x, a .gitignore file is added by default, which does ignore .godot/. In order to add global_script_class_cache.cfg, the .gitignore needs to be modified:
/.godot/**/*.*
!/.godot/global_script_class_cache.cfg

See https://github.com/itsas-taldea/moon/commit/d12a5ccd41f1ecc2308721cc12d83d603c1df4d2
I don't know what the solution would be:

Should Godot regenerate the config file transparently without errors?
Does that info need to be saved in the project file (which is checked in SCM) instead of in subdir .godot?

Steps to reproduce
git clone https://github.com/itsas-taldea/moon
cd moon
git checkout -b test-bug bada535a
cd godot
# This will produce errors such as: 'SCRIPT ERROR: Parse Error: Identifier "Utils" not declared in the current scope.'
godot --headless --export-release Linux ./moon.linux

rm -rf .godot
# Open the project in Godot "normally", then close it.
# Now, it will not produce SCRIPT ERRORs:
godot --headless --export-release Linux ./moon.linux

# Let's copy the problematic config file for later use
cp .godot/global_script_class_cache.cfg ../

rm -rf .godot
# It will produce errors again
godot --headless --export-release Linux ./moon.linux

rm -rf .godot
mkdir .godot
mv ../global_script_class_cache.cfg .godot/
# It will succeed now
godot --headless --export-release Linux ./moon.linux

Minimal reproduction project
See subdir in https://github.com/itsas-taldea/moon. Note that branch main includes .godot/global_script_class_cache.cfg. That needs to be removed in order to reproduce this issue.
See https://github.com/itsas-taldea/moon/actions/runs/4614444782/jobs/8157419040 and https://github.com/itsas-taldea/moon/actions/runs/4614591084/jobs/8157704125.

# This will produce errors such as: 'SCRIPT ERROR: Parse Error: Identifier "Utils" not declared in the current scope.'
godot --headless --export-release Linux ./moon.linux

This should work fine even without .godot folder.
Yes, it does print errors, but the generated export should work fine. Can you confirm?
Preventing the error spam is a worthy goal but it's just UX improvement, the functionality should be good already.

See subdir in [itsas-taldea/moon](https://github.com/itsas-taldea/moon). Note that branch main includes .godot/global_script_class_cache.cfg. That needs to be removed in order to reproduce this issue.

Tested with 4.0.2-stable and unlike what I wrote above (which is my experience on some other test projects), this one does export a broken PCK on the first run if .godot is missing.
Can be checked with:
mkdir build
cd godot
rm -rf .godot
Godot_v4.0.2-stable_linux.x86_64 --headless --export-pack Linux ../build/moon.zip

Then unzip the data package, and indeed .godot/global_script_class_cache.cfg exists but is empty.

@akien-mga I can confirm that the exported result is broken. Since the scripts are not found, the functions within are not executed and the UI is broken due to missing images (the UI is mostly based on VBoxes, HBoxes and Grids with TextureRect and TextureButton). Actually, that's how I found out there was a problem. I read the logs post-mortem.

I found this when trying to workaround #69511, this is my workaround.

Running into the same issue, running Godot twice is an odd solution though.
Is this expected? I'm seeing messages to ignore these errors, but they're not producing valid exports.
To reproduce:

rm -rf .godot
<path/to/godot/binary> --headless --export-release "Config"


Upgrade OkHttp from 2 to 3

Thanks! Can you sign our CLA: https://github.com/snowplow/snowplow/wiki/CLA

Signed!

Confirmed! Thanks so much. Assigning to @jbeemster to review...

@alexanderdean what is the status of this branch, when do you plan to release it?
We've migrated our app to okhttp3 and this is the only dependency that still requires okhttp2, so we're bundling both in our app.
Please let me know if I can help somehow.

Hey @jbeemster - we discussed the scheduling for this recently (goal was to time this to avoid forcing people to upgrade prematurely). I thought we had put a date on when we were going to merge this in but I can't see it?

Any updates on this?

Let's put this into the next version...

@alexanderdean any idea when the next version is being released?

It will be within the next 3 weeks...

Any updates on this release?

@alexanderdean it still isn't available yet. Any idea when the new release would be?

@alexanderdean looks like its still open. Can we get an estimate on this?

Hi @jvanderwee @MoizAli, sorry for the delay on this!  We are hoping to have this out early next week.

Any updates on this?

Hi @bogaert this is pending review by @alexanderdean before release.  An M1 has been pushed for those keen to get started:
compile 'com.snowplowanalytics:snowplow-android-tracker:0.6.0-M1@aar'


Kip500Broker transition to recovery state before rather than after

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Closed in favor of https://github.com/confluentinc/kafka/pull/465


ration tracking and water

id like an extra option to track and remove rations/ food and water or at least the option to auto remove food i.e rations and water and or just a prompt reminder for all players to do it manually also. could this be a part of the module?

This is already handled by https://foundryvtt.com/packages/rest-recovery


Not picking up User Name or Email from Git Repository

The plugin is not automatically picking up the user name and email address from the git repo even though it has been set using git config --global.  This means it won't connect to repo at all.

Turns out my colleague had an ancient version of git (2.6), updated him to 2.16 and it all works fine now!

Ok, sorry to hear that some older version of Git are not working any more


Images don't survive email

Steps to Reproduce

Post on Vanguard.
Check email.

Expected Result
Images.
Actual Result
No images.
Cf. https://vanguard.getsentry.net/p/clbcz8d6n11320ks6gz9dhfku vs. ...

Seems to be fixed now


Report classes renamed with 3.2 (breaking api change)

with moving the reports api into a module some reports seem to have been renamed.
Eg: SideReport_EmptyPages is now EmptyPagesReport
This is a breaking api change that is not reflected in the changelog.
So, we should either:

create class aliases to keep backwards compatible
or just update the changelog (and find+update all modules that rely on the old class names (eg mutlisites)

Also, I am a bit confused, there seem to have been 2 Reports for Broken Links: SideReport_BrokenLinks and BrokenLinksReport but now there is just one. What was the second one for, and why has it been removed?

We should probably revert these class-name changes in 3.2.1.

Fixed with https://github.com/silverstripe/silverstripe-cms/pull/1320


Updated validations.py python script

Updated validations.py python script.
Closed: #1
Fixed the behavior of validate_user function in validations.py.
Fixes #1

add function to test wheter the name start with a letter.

[x] Tests pass
[x] Appropriate changes to README are included in PR

update


Restrict number of core (cpu)

The command "ctx=mx.cpu()" is taking all available CPU. How to restrict to use a certain number only - say 6 out of 8 core

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


sideBySideFullscreen: false > Uncaught TypeError: Cannot read property 'className' of undefined

If i set sideBySideFullscreen: false and i click the side-by-side icon, i get a error message:
Uncaught TypeError: e is undefined
Steps to reproduce the behavior:
var mde = new EasyMDE({
			element: document.getElementById('md'),
			autoDownloadFontAwesome: false,
			spellChecker: false,
			autofocus: true,
			status: false,
			promptURLs: true,
			sideBySideFullscreen: false,

load the editor in a browser
Click the side-by-side button
in JS console Uncaught TypeError: e is undefined is displayed

Expected behavior
SideBySide view is opened not in fullscreen
Screenshots

** Version information **

Browser: Firefox 84.0.2
EasyMDE version: 2.13.0

The error message has now changed (at least in Chrome) to Uncaught TypeError: Cannot read property 'className' of undefined

I too have recently come across this. Seems to happen for me when I have more than one instance of EasyMDE on the page.

In EasyMDE version: 2.14.0 the issue is solved. Many thx.


Problems pronouncing times and dates

It looks like the English and German voices fail to pronounce dates and times like this (only ones I've tested):
English: 4/23/2021, 5:02:54 PM
German: 23.4.2021, 17:02:51
I know this is a widely discussed problem in the TTS field and not so easy to solve, but maybe there is some smart python library that does the work ;-). A small script using regular expressions could be a start, but to make this work for every language there has to be some ML based procedure I guess.
Maybe you are already working on something? ^^

This would be a great enhancement to add to gruut :slightly_smiling_face:
I'm not currently working on something for this, so I'd be interested to hear from anyone about approaches that have been tried. My first instinct would be to add date and time regular expressions to each language.yml file, and then use a combination datetime.strftime and num2words to produce the text.
It'll be important to understand how dates and times are commonly pronounced for each language. Beyond month/day ordering, it matters if it should be e.g., "23 April" or "April 23rd". Any resources on those kinds of things would be very helpful!

In German this topic is a little nightmare since all the pronunciations depend on what is happening around the date or time and if its singular or plural etc. :see_no_evil: .
All TTS developers arrive at this point sooner or later I guess and find some way to handle it. I'm not sure if the Mozilla people already thought about it? In Mary-TTS it was implemented somehow ... I think ... let me double-check.
I think the most sophisticated way would be to approach this like an NLU problem. Collect a large number of sentences, mark the date and time, define the correct replacement, create some magical ANN, cast magic, let the system learn the rules :stuck_out_tongue_closed_eyes: :sweat_smile:
The easy way to get started could be to collect a reasonable number of sentences and program a few hand-made rules ^^.
Espeak is not very good with dates and time etc. but at least you can understand the result. It simply replaces "24.04.2021" with "twenty-four dot four dot twothousand-twenty-one".

I just double-checked Mary-TTS behavior and its kind of funny ^^. I think they let Java reformat the date because if you use:
Today is the 04/23/2021 at 5:02 PM. it gives "Today is the April the 23rd twenty-twenty-one at five oh-two PM"
and if you flip the numbers like this:
Today is the 23/04/2021 at 5:02 PM. you get ... wait for it ... "Today is the November fourth twenty-twenty-two ..." :nerd_face:

I've made a first pass at this in a side branch of gruut. It's pretty simplistic, but I'm curious what you think.
For each language (currently just U.S. English), there is a set of datetime pattern triplets. Each triplet contains:

A regular expression for matching the date or time in raw text

Groups in the match are joined with a space, so (\d{1,2})/(\d{1,2}) on 4/10 would become 4 10

A strptime format string that parses the match from stage 1

Something like %m %d to parse <month> <day>

A strftime format string to turn the parsed datetime into words and numbers

Something like %B %d_ordinal to make April 10_ordinal

The _ordinal is special in gruut when "number converters" are enabled (--number-converters). Using the num2words package, gruut will transform 1_ordinal into "first", 2_ordinal into "second", etc. A _year converter is also available, which turns 2021 into "twenty twenty one".
I have some basic time examples working too (e.g., 5:30 and 5:30 PM). It should be pretty easy to extend this approach to German and other languages.
What do you think of this approach as a first pass?

First impression is good :+1: . I'm just a little bit concerned about the question of how to distinguish 4/10 = 10th of April from 4/10 = 4 over 10 and in German 4.10 = 4th of Octoberfrom4.10 = 4 point one zero`.
Is it possible to run tests in a very basic environment (without installing all the big libraries)? I could clone the lib and create some test sentences.

First impression is good +1 . I'm just a little bit concerned about the question of how to distinguish 4/10 = 10th of April from 4/10 = 4 over 10 and in German 4.10 = 4th of October from 4.10 = 4 point one zero.

Ah, I've thought of that! Kind of a cop-out, but 4/10 and 4.10 will be interpreted as numbers (though 4/10 isn't working just yet). However, 4/10_date and 4.10_date will be interpreted as dates.

Is it possible to run tests in a very basic environment (without installing all the big libraries)? I could clone the lib and create some test sentences.

Sure, give me some time and I can get a small script together.

I was just thinking of these German sentences again:

This seems a bit to me like the cardinal vs. ordinal difference for numbers ("one" vs. "first"). I get around this in gruut by having a default (cardinal in this case), and then having a _ordinal suffix otherwise.
Any idea what these different sense of a date are called?

Ah, I've thought of that! Kind of a cop-out, but 4/10 and 4.10 will be interpreted as numbers (though 4/10 isn't working just yet). However, 4/10_date and 4.10_date will be interpreted as dates.

I didn't quite get that, where is this suffix _date generated? Automatically by gruut (some sort of tokenizer)? Because I don't think we can expect the user to add it manually :-/

Any idea what these different sense of a date are called?

Its a result of the declension of words which is basically non-existent in English (except for singular<->plural) :see_no_evil:
4.10.2021 (10/4/2021) can be:
"the fourth of October" -> "der vierte Oktober" (Nominativ)
"morning of the fourth of October" -> "am Morgen des vierten Oktobers" (Genitiv)
"at the fourth of October" -> "am vierten Oktober" (Dativ)
"I'm thinking of the fourth of October" -> "Ich denke an den vierten Oktober" (Akkusativ)

As someone from a land where 4/10/2021 is "the fourth of October, Twenty-Twenty-One", locale-aware handling of dates is a plus... :)
Here's a couple of thoughts on the topic...
Input vs Output Locale
One aspect of this issue that I think hasn't yet been mentioned is that locale-aware can be split into:

locale of input text (e.g. I'm reading a web site with dates written with hard-coded MM/DD/YYYY-style format.)
locale of output speech (e.g. do I want the output pronounced as presented in the input text or as my locale convention?)

While my initial gut feeling is that I'd always want output based on my locale, on reflection it may depend on the content. e.g. if I'm reading a novel maybe its truer to the text for the American character to say "I'm looking forward to July Fourth Twenty Twenty-Two".
Limited Set of Valid/Ambiguous Dates
In terms of date parsing, the other aspect to keep in mind is that there's only a limited number of valid dates (or equally, a limited number of ambiguous dates). So, for example, if a possible date is "20/6/2021" then it can un-ambiguously only be "20 June 2021".
So perhaps a little more "intelligence" is also possible in terms of parsing--and maybe correct parsing is even possible in more circumstances: e.g. when a non-ambiguous date is encountered before an ambiguous date to select the correct format option for a specific document that contains some ambiguous dates.

Potentially useful date format-related resources:

"Falsehoods programmers believe about time"
https://github.com/kdeldycke/awesome-falsehood#dates-and-time
https://www.explainxkcd.com/wiki/index.php/1179:_ISO_8601 (Includes both "realistic" & "unrealistic" real world format examples.)
https://yourcalendricalfallacyis.com
https://unicode-org.github.io/icu/userguide/format_parse/datetime/

Other:

https://github.com/google/libphonenumber


vulkan: framework, backend_oculus: add support for building with clang

Cherry-picked from https://github.com/Samsung/GearVRf/pull/1319

some specific changes for vulkan

Still keeps crashing but that I will look into some other time. The important thing is the change from master is included.

GearVRf-DCO-1.0-Signed-off-by: Mihail Marinov<EMAIL_ADDRESS>

https://github.com/Samsung/GearVRf/pull/1319 has been merged. This can be considered for merging too.

I know. The property names are not consistent. Will get them all right one day.


Checking if object[prop] is not undefined does not eliminate undefined type from object[prop] (type guard)

Bug Report
🔎 Search Terms
type guard object property
🕗 Version & Regression Information
I'm using 4.2.4 in production, I don't know if this bug has occurred in prior versions.
I have tested in the playground that the bug also occurs in 4.3.x and 4.4 beta

This is the behavior in every version I tried, and I reviewed the FAQ for entries about it.

⏯ Playground Link
Playground link with relevant code
💻 Code

const kTableColumns = ['id', 'title', 'icon'];

type TableData = {
    id: string
    title: string
    icon: string
}

type Metadata = {
    url: string
}

type UpdateProps = Partial<Omit<TableData, 'id'>> & Partial<Metadata>;

function update(props: UpdateProps) {
    const tableUpdate: Array<{ column: string, value: string }> = [];

    kTableColumns.forEach((column) => {
        if (typeof props[column as keyof UpdateProps] !== 'undefined') {
            // Explicitly checked that props[columns] is not undefined, yet I have to
            // use non-null assertion operator to satisfy the compiler.
            // Error: string | undefined is not assignable to type string
            tableUpdate.push({ column, value: props[column as keyof UpdateProps]}) // Only ! can fix it.
            // Besdies this, the `as keyof UpdateProps` should be redundant after
            // checking that the value is not undefined.
        }
    });
}

🙁 Actual behavior
After validating that prop[columns] is not undefined, the compiler still treats prop[columns]as possiblyundefined`.
A non-null assertion operator at the end of the value is a workaround, but it feels like it should not be there.
🙂 Expected behavior
The type of prop[columns] inside the if clause should not be undefined.
Additionally, using column as keyof UpdateProps should not be required after validating that column is a valid key of the object (though I understand if there are valid reasons against it, I'm mostly concerned about the first issue).

Duplicate #44899 , others


jackett: 0.20.1473 -> 0.20.1768

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for jackett is: "API Support for your favorite torrent trackers"
meta.homepage for jackett is: "https://github.com/Jackett/Jackett/"
meta.changelog for jackett is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.20.1485 with grep in /nix/store/7ca0i4s6w2yrn744ag7l715p003wqb49-jackett-0.20.1485
found 0.20.1485 in filename of file in /nix/store/7ca0i4s6w2yrn744ag7l715p003wqb49-jackett-0.20.1485

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
jackett

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7ca0i4s6w2yrn744ag7l715p003wqb49-jackett-0.20.1485 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jackett https://github.com/r-ryantm/nixpkgs/archive/20e5975e11e8fab04e66de7e2084b5274fac4c70.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7ca0i4s6w2yrn744ag7l715p003wqb49-jackett-0.20.1485
ls -la /nix/store/7ca0i4s6w2yrn744ag7l715p003wqb49-jackett-0.20.1485/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

jackett

Maintainer pings
cc @edwtjo @nyanloutre @purcell for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for jackett is: "API Support for your favorite torrent trackers"
meta.homepage for jackett is: "https://github.com/Jackett/Jackett/"
meta.changelog for jackett is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.20.1687 with grep in /nix/store/hs5a1blgnlm18yxm4q4q0dral8apigfh-jackett-0.20.1687
found 0.20.1687 in filename of file in /nix/store/hs5a1blgnlm18yxm4q4q0dral8apigfh-jackett-0.20.1687

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
jackett

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hs5a1blgnlm18yxm4q4q0dral8apigfh-jackett-0.20.1687 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jackett https://github.com/r-ryantm/nixpkgs/archive/f5de056586b69fff8b9f84149c85b99d93f359a7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hs5a1blgnlm18yxm4q4q0dral8apigfh-jackett-0.20.1687
ls -la /nix/store/hs5a1blgnlm18yxm4q4q0dral8apigfh-jackett-0.20.1687/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

jackett

Maintainer pings
cc @edwtjo @nyanloutre @purcell for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for jackett is: "API Support for your favorite torrent trackers"
meta.homepage for jackett is: "https://github.com/Jackett/Jackett/"
meta.changelog for jackett is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.20.1743 with grep in /nix/store/55jwg8pc1xd87gxfhp55sp46qcvl16wi-jackett-0.20.1743
found 0.20.1743 in filename of file in /nix/store/55jwg8pc1xd87gxfhp55sp46qcvl16wi-jackett-0.20.1743

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
jackett

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/55jwg8pc1xd87gxfhp55sp46qcvl16wi-jackett-0.20.1743 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jackett https://github.com/r-ryantm/nixpkgs/archive/dfbf63f0ad22e2802862874eb7fcc166bf6564af.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/55jwg8pc1xd87gxfhp55sp46qcvl16wi-jackett-0.20.1743
ls -la /nix/store/55jwg8pc1xd87gxfhp55sp46qcvl16wi-jackett-0.20.1743/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

jackett

Maintainer pings
cc @edwtjo @nyanloutre @purcell for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for jackett is: "API Support for your favorite torrent trackers"
meta.homepage for jackett is: "https://github.com/Jackett/Jackett/"
meta.changelog for jackett is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.20.1768 with grep in /nix/store/047vg3mn8grif0j8ff401y65vlwnfw0b-jackett-0.20.1768
found 0.20.1768 in filename of file in /nix/store/047vg3mn8grif0j8ff401y65vlwnfw0b-jackett-0.20.1768

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
jackett

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/047vg3mn8grif0j8ff401y65vlwnfw0b-jackett-0.20.1768 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A jackett https://github.com/r-ryantm/nixpkgs/archive/aacdb9c6f1717c1be0f919e056a4ae4d8ac36a6c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/047vg3mn8grif0j8ff401y65vlwnfw0b-jackett-0.20.1768
ls -la /nix/store/047vg3mn8grif0j8ff401y65vlwnfw0b-jackett-0.20.1768/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

jackett

Maintainer pings
cc @edwtjo @nyanloutre @purcell for testing.

Result of nixpkgs-review pr 183905 run on x86_64-linux 1

1 package built:

jackett


Rounding with significant digits precision gives wrong results

Globalize.numberFormatter({
        compact: 'short',
        minimumSignificantDigits: 1,
        maximumSignificantDigits: 3,
    })(12849872883)

Actual => 12.9B
Expected => 12.8B
Root cause for this is in the method numberToPrecision which first changes the precision from actual precision to a +2. and then rounds the number based on the given precision. So the number in this case<PHONE_NUMBER>3 changes to 12.850 and when finally rounded becomes 12.9

Thanks for reporting and for the initial investigation. Fix would be welcome :). Thanks


Provide HTTP API endpoints for merging component catalog information and metrics

We've been working on view mode of topology, which provides overall look of topology structure as well as runtime information (mostly metrics).
To merge topology structure with metrics, we would want to provide unified API endpoint which provides merged result of separate API (topology catalog, metrics).
Due to the request of flexible time window in view mode, metrics should be queried as time-series manner, which can't be done with Storm REST API. So all the API endpoints will only work properly when time-series DB is properly set to the namespace.

#1032

#1032 was merged. Closing.