Make sure a GMS2 generated file is classified as such

I'm making sure the generated .yy file is being matches as a generated GMS2 file, instead of Yacc.
Fixes #4293
Checklist:

[x] I am fixing a misclassified language

[x] I have included a new sample for the misclassified language:

Sample source(s):

https://github.com/RobQuistNL/DSNet/blob/ad8bc9ffc37b920610f6524a86324f1b6503d3c0/options/main/inherited/options_main.inherited.yy

Sample license(s): MIT

[X] I have included a change to the heuristics to distinguish my language from others using the same extension.

Hmm, that explodes again..
TestFileBlob#test_language:
Encoding::CompatibilityError: incompatible encoding regexp match (UTF-8 regexp with ASCII-8BIT string)

@lildude Could you check this out, please? You're likely more familiar with this pipeline (and Ruby) than I am.

@Alhadis can you confirm that the tests run on your own machine? I can't since I don't have the project running :x

IMHO we could remove that one character - allthough it would be a pretty solid detection method :)

I've not had the chance to look into this in-depth but this smells very similar to https://github.com/github/linguist/issues/4028

Is there any chance of it being related to charlock_holmes? I keep seeing this warning emitted whenever I run bundle exec rake …:

/home/travis/build/github/linguist/vendor/bundle/ruby/2.5.0/gems/charlock_holmes-0.7.6/lib/charlock_holmes/encoding_detector.rb:66: warning: instance variable encoding_list not initialized

... and this doesn't look very good:
    # A mapping table of supported encoding names from EncodingDetector
    # which point to the corresponding supported encoding name in Ruby.
    # Like: {"UTF-8" => "UTF-8", "IBM420_rtl" => "ASCII-8BIT"}
    #
    # Note that encodings that can't be mapped between Charlock and Ruby will resolve
    # to "ASCII-8BIT".
    @encoding_table = {}

Since charlock_holmes appears to be consulting a lower-level system dependency (ICU) I'm willing to bet this is undefined behaviour subject to environmental factors. It would explain why OpenBSD gets flooded with errors (to an extend considered unacceptable by anybody), whereas nobody else seems to have reported this on other systems.

I really wish I could help, but I'm a real big newbie when it comes to Ruby - I will at least try to setup the project on my Xenial machine soon.

Seems like a decent compromise. 👍 Thanks for your patience!


rawQuery

I see that count, findOne and findMany can do rawQuery but I think findById does not process rawQuery. Can you please add rawQuery support to findById as well?

Sorry for late response. I lost your issue.
For what purpose you need rawQuery on findById? Can you share use case?
I try to keep findById as simple as possible.


rancher import alibaba k8s alert error

rancher: 2.2.2
I have import the alibaba k8s cluster, the agent install is OK! But the alert error:
the rancher logs:

The rancher server is local, the network is ok!
@loganhz  @aiwantaozi

rancher: 2.2.2
I have import the alibaba k8s cluster, the agent install is OK! But the alert error:
the rancher logs:

The rancher server is local, the network is ok!
@loganhz @aiwantaozi

I find the email is this error log， the wechat is normal！ I can received the wechat message

Cool.
Please let us know in a comment if you can still reproduce the issue, and we'll reopen it


add port to podman remote command

Signed-off-by: Brent Baude<EMAIL_ADDRESS>

LGTM

/lgtm

/hold


LESQ-830: Plan a lesson page

Description
Music year: {owa_music_year}
Pulls together the majority of the new plan a lesson page utilising the components built in the Oak Component library

Adds BlogAndWebinar list component
LessonPlanningBlog component
amends getAndMergeWebinarsAndBlogs function
Adds corresponding test files

Issue(s)
Fixes #LESQ-830
How to test

Go to https://deploy-preview-2420--oak-web-application.netlify.thenational.academy/lesson-planning-new

Screenshots
How it should now look:
https://github.com/oaknational/Oak-Web-Application/assets/91190841/7ef785bc-14be-4a21-b9ba-1b6ae31fc9ed
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

Looks good, one small style thing I noticed , on mobile the contents hero and blog section are not quite aligned.

Fixed on component lib PR ✅

:tada: This PR is included in version 1.439.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Changes for pretrained.py (tedlium3 pruned RNN-T)

Do some changes for pretrained.py and add modified beam search, fast beam search to the colab example.

I have check the modified beam_search.py in librispeech/pruned_transducer_stateless and tedlium3/pruned_transducer_stateless and they decode normally.


Component works in development mode but not in production mode?

Version
3.7.0
Reproduction link
http://vue-cli-test.surge.sh/
Environment info

  System:
    OS: macOS 10.14.5
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Binaries:
    Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
    Yarn: 1.16.0 - ~/.nvm/versions/node/v10.15.3/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v10.15.3/bin/npm
  Browsers:
    Chrome: 74.0.3729.169
    Firefox: 66.0.5
    Safari: 12.1.1
  npmPackages:
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.0.0
    @vue/babel-preset-app:  3.7.0
    @vue/babel-preset-jsx:  1.0.0
    @vue/babel-sugar-functional-vue:  1.0.0
    @vue/babel-sugar-inject-h:  1.0.0
    @vue/babel-sugar-v-model:  1.0.0
    @vue/babel-sugar-v-on:  1.0.0
    @vue/cli-overlay:  3.7.0
    @vue/cli-plugin-babel: ^3.7.0 => 3.7.0
    @vue/cli-plugin-typescript: ^3.7.0 => 3.7.0
    @vue/cli-plugin-unit-jest: ^3.7.0 => 3.7.0
    @vue/cli-service: ^3.7.0 => 3.7.0
    @vue/cli-shared-utils:  3.7.0
    @vue/component-compiler-utils:  2.6.0
    @vue/preload-webpack-plugin:  1.1.0
    @vue/test-utils: 1.0.0-beta.29 => 1.0.0-beta.29
    @vue/web-component-wrapper:  1.2.0
    jest-serializer-vue:  2.0.2
    typescript: ^3.4.3 => 3.4.5
    vue: ^2.6.10 => 2.6.10
    vue-class-component: ^7.0.2 => 7.1.0
    vue-hot-reload-api:  2.3.3
    vue-jest:  3.0.4
    vue-loader:  15.7.0
    vue-property-decorator: ^8.1.0 => 8.1.1
    vue-style-loader:  4.1.2
    vue-template-compiler: ^2.5.21 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
  npmGlobalPackages:
    @vue/cli: 3.7.0

Steps to reproduce

The dev version of the code is running at - https://codesandbox.io/s/vueclitest-8mccx.
Go to the above URL and you should see a Copy button that, upon clicking copies "Test Content" on clipboard. You can even try pasting somewhere after that.
Now, go to http://vue-cli-test.surge.sh/
You'll see a blank page.

The surge.sh link is just a prod build deployed there of the same thing that's there on codesandbox.
The github repo url is this - https://github.com/praveenpuglia/vue-cli-test
The component library code(which i author and having this issue with) - https://github.com/vue-lego/blocks
What is expected?
I should see the same copy  button in prod build too.
What is actually happening?
The component is not parsed / run as a vue component. Inspecting the DOM shows the markup that was used for the component's usage.

Because when you use BCopy.name you are actually referring to the BCopy class's name property, which will be minified after building. Should use BCopy.options.name here.

I tried changing that to BCopy.options.name but now I get type error saying options doesn't exist on type VueConstructor<Vue>.
Should I raise the typing issue to vue-class-component then?
I think BCopy should show up its type as VueConstructor<BCopy>. No?

BTW, changing it to BCopy.options.name actually did fix the issue.
Now, I need to get the typing thing fixed and everything should be good.


doc: vet check included in gc needs to be documented

vet check seems to be included in gc by default but not documented in go1.11 release note yet (sorry, I didn't search enough to find related issue/proposal/change to link yet).
This behavior change resulted in build-failures for codes that don't pass vet currently and could be misunderstood as a regression in go1.11. For example, with go1.11 (or tip), go test on
github.com/spf13/cobra will fail due to failure to pass vet check.

$ go version
go version devel +257d6c48e0 Thu Jun 28 03:12:01 2018 +0000 linux/amd64

$  go test github.com/spf13/cobra
# github.com/spf13/cobra
../github.com/spf13/cobra/command_test.go:1105:3: parentPersPreArgs declared but not used
../github.com/spf13/cobra/command_test.go:1109:3: parentPersPostArgs declared but not used
vet: typecheck failures
FAIL	github.com/spf13/cobra [build failed]

BTW, the vet error message is confusing because the parentPersPreArgs and parentPersPostArgs in the test are 'used' (literally). But for the purpose of vet check, the vars are 'not used' because they are never read.

That's not a vet error message. That file is failing the type-checking phase that precedes the vet checks.
The reason the file fails typecheking is that this:
var parentPersPreArgs string

PersistentPreRun: func(_ *Command, args []string) {
    parentPersPreArgs = strings.Join(args, " ")
},

doesn't count as using the parentPersPreArgs variable. The program should not compile, but it does because of #3059. But go/types, which is used by vet to type-check, correctly marks the variable as unused.

Root cause is the decision taken on #21287 (cmd/vet: decide how to handle type checking failure). I quote:

So the decision here is "go vet" will be fixed so that it can always typecheck, and then failure to typecheck will be a fatal error.

This happened in go1.10, but AFAIK it wasn't documented in the release notes. I don't see it here:
https://golang.org/doc/go1.10#vet
We could document this in the 1.11 release notes(?)

Is the error message misleading?

vet: typecheck failures

anyway, regardless of where the origin of this change is, the changed behavior should be documented clearly.

Ah, my bad. This is false:

vet typechecks since 1.10

it was put it, disabled to fix a go/types issue, and the re-enabled again during the 1.11 cycle, here:
https://go-review.googlesource.com/c/go/+/108555
So it should be documented.

Sorry, I'm experiencing this error and I'd like to know what I'm supposed to be doing instead of
var parentPersPreArgs string

PersistentPreRun: func(_ *Command, args []string) {
    parentPersPreArgs = strings.Join(args, " ")
},

Why is this considered a failure?

Sorry, I'm experiencing this error

Where? When?

I'd like to know what I'm supposed to be doing

Use the parentPersPreArgs variable in some way, or remove it from the code.

Why is this considered a failure?

Because unused variables are not allowed in Go (at least in gc and in go/types), and parentPersPreArgs is an unused variable.

@ALTree I'm experiencing it with the same closure usecase as you posted. By my reading, parentPersPreArgs is "used" when strings.Join assigns its result to it. I don't understand what makes it "unused."

A value that is only ever written to but never read from is effectively unused. go/types (which vet uses) is more strict about this than the compiler.


Remove verification on callback signup

Trello card
Trello-4640
Context
Verification step to book a callback is not necessary
Changes proposed in this pull request
Remove verification steps from the booking callback journey
Guidance to review

Looking good just one minor comment. I also got a 500 error when I tested it though, I think the email field isn't passing through for some reason?
https://dfe-teacher-services.sentry.io/issues/4293201121/?project=5276949&query=is%3Aunresolved&referrer=issue-stream&stream_index=0

Looks like I've managed to replicate it - if you completed the journey and then go back and create a callback again the store is empty at this point and the email doesn't exists there anymore. So no need to send the request to the API

Closing this PR - we have decided not to go ahead with this (see Trello card)


Naming a type "Subscription" creates invalid subscription related code

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
14.17.6
Amplify CLI Version
7.6.5
What operating system are you using?
Mac
Amplify Codegen Command
codegen
Describe the bug
Having a type as follows creates invalid subscription-related code:
type Subscription {
  myId: ID!
}

Creates the following in subscriptions.graphql:
# this is an auto generated file. This will be overwritten
subscription MyId {
  myId
}

And creates this in API.service.ts:
  MyIdListener: Observable<
    SubscriptionResponse<MyIdSubscription>
  > = API.graphql(
    graphqlOperation(
      `subscription MyId {
        myId
      }`
    )
  ) as Observable<SubscriptionResponse<MyIdSubscription>>;
}

Expected behavior
No subscription code should be created.
Reproduction steps
See above
GraphQL schema(s)
See above
Log output

# Put your logs below this line

Additional information
No response

Subscription is a reserved keyword, which is auto-generated by the gql transformer. The behavior is very similar to Query, Mutation. If you have these reserved type defined, it will be considered as your customized fields which are added to the generated fields as well. The code is expected because you add your own Subscription (the same as Query, Mutation.


Issue with Package / Namespace mismatch.

Microsoft Visual Studio Community 2019 Version 16.8.2
I'm hoping there is an easy solution, as I'm linking to dll's to bypass this.
I'm working on a very large solution containing multiple projects.
The project is open source, and has forked from the original, meaning the NuGet package names have had to be changed.
The issue seems to be one of the package being built with the namespaces instead of the package name.
Namespace info

Package Info

When jellyfin.Controller is imported into a plugin (via the NuGet manager) which I'm trying to develop, the following error is reported. (The NuGets are in a locally stored folder).
NU1101: Unable to find package MediaBrowser.Model. No packages exist with this id in source(s): Local, nuget.org

On further investigation - the following is showing under dependencies.

MediaBrowser.Common and MediaBrowser.Model don't exist with that name as packages, but like Jellyfin.Controller have different package names than their namespaces. The are, in fact, called Jellyfin.Common and Jellyfin.Model.
So the package is looking to import the namespace and can't find it, as it's in a package with a different name.
Am I missing something?

Cleaned and rebuilt nuget folder, and they linked ok. So it looks like there was corruption somewhere.


Help setting up Jellyscrub

Currently, after adding the jellyscrub plugin, and creating all .bif files, only the Jellyfin chapter previews appear.
See end of text for my question.
My installation and configuration
I used the following commands to set up Jellyfin on my Raspberry Pi:

curl https://repo.jellyfin.org/install-debuntu.sh | sudo bash
wget -O- https://repo.jellyfin.org/install-debuntu.sh | sudo bash

And added the plugin by adding this repo URL in the plugins tab on Jellyfin through the browser and installed it

https://raw.githubusercontent.com/nicknsy/jellyscrub/main/manifest.json

My configuration:
HW Acceleration: None
Generate trickplay files on demand when a client requests one: ON
Save trickplay files within media folders: OFF
Create trickplays when videos are discovered: ON
Scan Behavior: Non Blocking
Inject client script into jellyfin-web: ON
Image Interval: 1000
Width Resolutions: 320
Process Priority: Below Normal
FFmpeg Threads: -1

From the README, I believe this applies to me:

Install from distro repositories - the jellyfin-server will execute as jellyfin user while the web files will be owned by root, www-data, etc. This can likely be fixed by adding the jellyfin (or whichecher user your main jellyfin server runs at) to the same group the jellyfin-web folders are owned by. You should only do this if they are owned by a group other than root, and will have to lookup how to manage permissions on your specific distro.

Question
Could you please elaborate a bit more on how to change permissions?
I'm pretty sure jellyfin is the user that runs Jellyfin. I've checked using the htop command.
I don't know what jellyfin-web folders you are referring to.
The way I would check who the owner of the jellyfin-web folder is, would be by using ls -la.
What command should I then use to add the user Jellyfin to the group?

usermod -a -G jellyfin-web jellyfin

Could you please paste the parts of your jellyfin logs relating to jellyscrub and script injection status? It should also print the location of the web files in logs.

Here are the logs which I believe to be relevant. I added the lines which include the word “jellyscrub” and the lines in which I manually trigger the “Generate BIF Files” job and play a movie. Let me know If you need anything else, or the entire log.
[2023-08-03 21:26:00.470 +02:00] [INF] Loaded assembly "Nick.Plugin.Jellyscrub, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null" from "/var/lib/jellyfin/plugins/Jellyscrub_<IP_ADDRESS>/Nick.Plugin.Jellyscrub.dll"

[2023-08-03 21:26:49.133 +02:00] [ERR] Encountered exception while writing to "/usr/share/jellyfin/web/index.html": "System.UnauthorizedAccessException: Access to the path '/usr/share/jellyfin/web/index.html' is denied.
 ---> System.IO.IOException: Permission denied
   --- End of inner exception stack trace ---
   at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter)
   at Interop.CheckIo(Error error, String path, Boolean isDirectory, Func`2 errorRewriter)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at System.IO.Strategies.FileStreamHelpers.ChooseStrategy(FileStream fileStream, String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, Int64 preallocationSize)
   at System.IO.StreamWriter.ValidateArgsAndOpenPath(String path, Boolean append, Encoding encoding, Int32 bufferSize)
   at System.IO.File.WriteAllText(String path, String contents)
   at Nick.Plugin.Jellyscrub.JellyscrubPlugin..ctor(IApplicationPaths applicationPaths, IXmlSerializer xmlSerializer, ILogger`1 logger, IServerConfigurationManager configurationManager)"
[2023-08-03 21:26:49.215 +02:00] [INF] Loaded plugin: "Jellyscrub" "<IP_ADDRESS>"

[2023-08-03 23:33:50.616 +02:00] [INF] Executing "Generate BIF Files"
[2023-08-03 23:33:55.748 +02:00] [INF] "Generate BIF Files" Completed after 0 minute(s) and 5 seconds
[2023-08-03 23:33:55.751 +02:00] [INF] ExecuteQueuedTasks
[2023-08-03 23:34:25.651 +02:00] [INF] User policy for "mecs". EnablePlaybackRemuxing: True EnableVideoPlaybackTranscoding: True EnableAudioPlaybackTranscoding: True
[2023-08-03 23:34:25.653 +02:00] [INF] StreamBuilder.BuildVideoItem( Profile="Anonymous Profile", Path="/mnt/nas/Movies/Peliculas EN/Godzilla Vs. Kong 2021 1080p.mp4", AudioStreamIndex=null, SubtitleStreamIndex=null ) => ( PlayMethod=DirectPlay, TranscodeReason=0 ) "media:/videos/4c2f62fb-ccfa-0b7d-1b37-76eb2db04148/stream.mp4?MediaSourceId=4c2f62fbccfa0b7d1b3776eb2db04148&Static=true&VideoCodec=h264&AudioCodec=aac&AudioStreamIndex=1&api_key=<token>&Tag=19f16be4d89b8a3815011a6e14ecfbbe"
[2023-08-03 23:34:36.984 +02:00] [INF] Playback stopped reported by app "Jellyfin Web" "10.8.10" playing "Godzilla vs. Kong". Stopped at "7122" ms
[2023-08-03 23:34:39.081 +02:00] [INF] AuthenticationScheme: "CustomAuthentication" was forbidden.

Okay, so it looks like jellyfin process doesn't have write access to /usr/share/jellyfin/web/. If you do ls -la /usr/share/jellyfin/web/ what are the permissions?

All of them are:
-rw-r--r-- 1 root root
Exceptuating these folders:
drwxr-xr-x 5 root root    4096 Mar 18 16:10 assets
drwxr-xr-x 3 root root    4096 Apr 24 01:53 libraries
drwxr-xr-x 8 root root    4096 Mar 18 16:10 themes

Do chmod -R jellyfin:jellyfin /usr/share/jellyfin/web/ then restart jellyfin and see if the script injection succeeds using the logs.

pi@raspberrypi:~ $ sudo chmod -R --verbose jellyfin:jellyfin /usr/share/jellyfin/web/
chmod: invalid mode: ‘jellyfin:jellyfin’
Try 'chmod --help' for more information.

I get this. The user exists, which is weird.

Woops I meant chown not chmod.

Spectacular, thanks! That worked :)

chown jellyfin:jellyfin /usr/share/jellyfin/web/index.html and chmod 666 /usr/share/jellyfin/web/index.html with the docker console within unraid did the job for me.

@dandud100 I entered the two commands on the jellyfin docker terminal but it doesn't work. I use unraid

@dandud100 I entered the two commands on the jellyfin docker terminal but it doesn't work. I use unraid

Restart the docker container.

sorry for my English.
I did what you told me but it doesn't work.
should I remove these settings from jellyfin docker? look at photo

sorry for my English. I did what you told me but it doesn't work. should I remove these settings from jellyfin docker?

No, dont remove them.
Please input the following console output to the docker console of your jellyfin, scroll down to index.php and send a screenshot:
ls -la /usr/share/jellyfin/web/

I did as you told me but I see that the number in the central line is different

in the image below I have set jellyscrub like this

I solved it, I had jellyfin set as root.
Thanks so much for the support @dandud100

I solved it, I had jellyfin set as root. Thanks so much for the support @dandud100

Nice to hear! The next step would be making this change persistive, i wrote a guide for it, but it is in german. Maybe it can still help you in some way: https://forums.unraid.net/topic/149537-nutzt-hier-jemand-jellyscrub-für-jellyfin-wie-funktioniert-die-dauerhafte-berechtigungsänderung-der-indexhtml/?do=findComment&comment=1342117


Upgrade operator-sdk to 1.4.2

https://v1-5-x.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.4.0/
Pretty straightforward upgrade this time, thankfully. I did a bit of manual testing and changing the finalizer names doesn't seem to have broken them, and everything else appears to still be working.

Should I go ahead and start on 1.5.0 as well?
https://github.com/rh-jmc-team/container-jfr-operator/pull/176#issuecomment-801081815

Should I go ahead and start on 1.5.0 as well?
#176 (comment)

Sure, it seems like it will be useful for us.


Dataset preparation

Hello, have you any information regarding "Dataset preparation" – for example, I want to recognize old Egypt characters and I have a lot of hi-res hand-written scans of manuscripts, where is the better place to begin with?

Hi,
Most of the techniques I used are standard methods I came across on different blogs (like this one:
http://benanne.github.io/2015/03/17/plankton.html
 ). For my specific dataset, I inverted the colors (from white background to black background to reduce computational needs), manually added in a few random samples (to add noise and prevent overfitting), and augmented the dataset by applying small random rotations and translations to each image. Also note that I used supervised learning.
I hope this helps!
On Mon, Nov 14, 2016 at 4:29 AM DenisSergeevitch
<
mailto:DenisSergeevitch<EMAIL_ADDRESS>
wrote:

a, pre, code, a:link, body { word-wrap: break-word !important; }
Hello, have you any information regarding "Dataset preparation" – for example, I want to recognize old Egypt characters and I have a lot of hi-res hand-written scans of manuscripts, where is the better place to begin with?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dibyatanoy_Bengali-2DHandwritten-2DCharacter-2DRecognition-2DUsing-2DConvolutional-2DNeural-2DNetworks_issues_1&d=CwMFaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4aFUioRUIPBnRbMK-XnTsp3Yyl0B9mjd1bUMTcFpH8JGhVjU4szFekRe3XYzs9J_&m=twqq_y3dDfSqmZ0e3lJdIGACGfMLM6s8t8wP-lFG7H4&s=21QY_AIodcRfxsC2_YKIIb6ykitdR98kU46CfkRd3PI&e=
, or
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AOeRobaCOOJBjKlFjxqIai7lSlS28dBhks5q-2DCnmgaJpZM4KxG-2DE&d=CwMFaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=4aFUioRUIPBnRbMK-XnTsp3Yyl0B9mjd1bUMTcFpH8JGhVjU4szFekRe3XYzs9J_&m=twqq_y3dDfSqmZ0e3lJdIGACGfMLM6s8t8wP-lFG7H4&s=_m62bncUjeO0epO1WUvkG5MGiA_R1-wZKvjaYPMBU8I&e=
.

Hey,
I'm trying ocr for english characters, could you tell me the min no of examples for each class because for certain letters i only have near 2000 examples, dataset contains images of 28*28.


[Feature][Core] Supprot add thirdparty jar in env

close #3575

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

@Hisoka-X PTAL


Add WebSocket

Add WebSocket object and support native events for function arguments (needed to get data). Websockets are automatically closed when a VM instance is stopped.
Example using WebSocket for the FT transfer events. It handles reconnects.
if (state.ws === undefined) {
  const eventsFilter = {
    status: "SUCCESS",
    event: {
      event: "ft_transfer",
    },
  };

  function startWebSocket(processEvents) {
    let ws = State.get().ws;

    if (ws) {
      ws.close();
      return;
    }

    ws = new WebSocket("wss://events.near.stream/ws");

    ws.onopen = () => {
      console.log(`Connection to WS has been established`);
      ws.send(
        JSON.stringify({
          secret: "near-social-events",
          filter: eventsFilter,
          fetch_past_events: 10,
        })
      );
    };
    ws.onclose = () => {
      State.update({ ws: null });
      console.log(`WS Connection has been closed`);
      State.get().startWebSocket(processEvents);
    };
    ws.onmessage = (e) => {
      const data = JSON.parse(e.data);
      processEvents(data.events);
    };
    ws.onerror = (err) => {
      State.update({ ws: null });
      console.log("WebSocket error", err);
    };

    State.update({ ws });
  }

  function processEvent(event) {
    return {
      time: new Date(parseFloat(event.block_timestamp) / 1e6),
      event: event.event,
      accountId: event.account_id,
      predecessorId: event.predecessor_id,
    };
  }

  function processEvents(events) {
    events = events.flatMap(processEvent);
    events.reverse();

    State.update((state) => {
      const prevActions = state.actions || [];
      state.actions = [
        ...events.filter(
          (event) =>
            prevActions.length === 0 ||
            event.time.getTime() > prevActions[0].time.getTime()
        ),
        ...prevActions,
      ].slice(0, 10);
      return state;
    });
  }

  State.init({
    startWebSocket,
  });
  state.startWebSocket(processEvents);
}

return state.actions;

Note, this PR is based on top of a fix for the legacy function call creation. https://github.com/NearSocial/VM/tree/fix/legacy-function-call-creator

Fixes #35


SPI Master misses data on ESP32-S3 when max xfer size is more than 32KB (IDFGH-6125)

Environment

Development Kit:   ESP32-S3-DevKitC-1
Kit version (for WroverKit/PicoKit/DevKitC): v1?
Module or chip used:  ESP32-S3-WROOM-N8R8
IDF version: v5.0-dev-79-gbcbef9a8db
Build System:  CMake or idf.py
Compiler version: esp-2021r2
Operating System: Linux (Ubuntu 21.04)
(Windows only) environment type: zsh
Using an IDE?: Yes, CLion
Power Supply: USB

Problem Description
The SPI Master driver generates rubbish data on ESP32-S3 when the max transfer size is more than 32768 bytes.
We have a project that driving some display panels. The SPI Master's max_transfer_sz was set to 100KB and it was working fine on the classic ESP32. However it doesn't work when we move to ESP32-S3, even if CONFIG_SPIRAM_MALLOC_RESERVE_INTERNAL is set to 100KB (in case it causes some unexpected behaviour from the PSRAM).
Expected Behavior
Should just work as-is.
Actual Behavior
On every SPI transaction that SPI master driver has been set to max_transfer_sz > 32768 and transaction data length is > 32768, the driver seems only transfer the first 32KB data, and ignore the rest of them.
Steps to reproduce

Set the max_transfer_sz at spi_bus_config_t in the SPI driver initialisation function to something bigger than 32768
Transfer a big chunk of data
Take a look for the output with a logic analyser.

Code to reproduce this issue
Code is not allowed to be disclosed.
Debug Logs
N/A
Other items if possible
N/A

Here are more info:

SPI Master's DMA is definitely enabled
SPI Master's clock speed is at 8 to 11.4MHz (APB_CLK/7 to APB_CLK/10)
PSRAM (8MB Octal SPI PSRAM) is enabled, running at 40MHz Octal mode
Other settings are left as default

@Alvin1Zhang any updates? Do I need to provide more info?

@huming2207 Thanks for reporting, and sorry for slow turnaround, we will look into and provide feedback, thanks.

Hi @huming2207 , your conservation is correct. Due to registers bit width limitation, ESP32S3 SPI Master is able to transfer 32KB per transaction.
Besides, you may use keep_cs_active feature. See this. In this way, cs is kept active between 2 transactions, although it still costs some time on preparing the hardware (you should see clock signal keeping idle for some time between 2 transactions)

@Icarus113 Thanks. In our case, we are controlling CS pins by ourselves anyway. I guess I should queue a few transfers and wait for complete in the end instead.
By the way, may I ask which register bit width has that limitation? Is there a way to mitigate it by implementing a workaround in the SPI driver?

@huming2207  Hi, see this
We do have a hardware feature which is called Configure-Transfer(only under DMA mode), during configure, software can decide the length of the transaction, and need to prepare buffer in this length. Let's say SPI is configured to send 64KB, software should prepare this buffer, and use 2 DMA descriptors. Software only needs to trigger SPI once, and 3 transactions (1 configure transaction + 2 general transactions) will be started. During the configure transaction, you will only see clock signal keeping active level, and cs signal keeping inactive. Software doesn't support this feature yet.

@Icarus113 thanks. Then I will probably queue the SPI transfer and then wait for the result at the last one for now until Espressif implements that. Or maybe I will see if I can do it later on if I have time to do so, but it's not the highest priority for us for now.

Thanks for reporting, feel free to reopen.

@Alvin1Zhang I think this issue is not resolved yet. Please reopen it.
And indeed it is a bug, as the SPI master driver has different behaviour on transfer length between ESP32-S3 and the classic ESP32.

Hi @huming2207 , ESP23 also has this limitation, although the length is higher than it is on ESP32S3. This is the hardware design instead of a driver bug. Indeed we can have a wrapper to combine few transactions, but you'll still see the CS line changing between active and inactive between each transaction.
By using keep_cs_active feature, it's true the CS will be kept active, but hardware still needs time to prepare its state. Besides, if the configure-transfer feature is needed, you may open another issue for a dedicated feature request (about the configure-transfer feature)

@Icarus113 Yep okay, I will open another feature request for this configure-transfer mode. But nevertheless, I believe this indeed IS also a bug as the same API behaves differently on ESP32 and ESP32-S3 without any warning or panic.

I woke up early today and I started revising this issue, as it is indeed necessary for improving the performance for driving some displays.
So far I couldn't find any info of config-transfer mode like you said on ESP32-S3's TRM, because so far (as per 3 Dec 2021 7:00am AEDT) in the manual, SPI is not yet being documented. But I found something similar on ESP32-S2's TRM at Section 24.4.7 "DMA Controlled Segmented-Configure-Transfer". Then I referred to the header at components/soc/esp32s3/include/soc/spi_struct.h and there's a dma_seg_trans_done in dma_int_ena, and some other control registers there as well.
Apparently, ESP32-S2's SPI peripheral is quite different from ESP32-S3. But before Espressif releases their documentation for ESP32-S3, I guess I can probably have a try on ESP32-S3 later following the ideas from ESP32-S2's TRM.
@Icarus113 Do you think I'm on the right track? Any further suggestions?
Also, @Alvin1Zhang if there's no one currently working on this issue on your side, then I will consider starting my experiment this month and submit a PR if I manage to get it working.

For this table:

I guess the sequence for ESP32-S3 is different, so the 7th bit (offset 0x1c of SPI peripheral registers) is SPI_MS_DLEN_REG, which I need to set the ms_data_bitlen in the configuration buffer in the DMA linked list. Am I correct?

I also encounter the same problem when using SPI LCD. My solution is to split a frame of data and queue it, which can solve the problem that a frame is truncated. Then I found the drawback of this approach (the screen was split). For this, I used TE to synchronize every frame, which solved the problem and made the screen look like there was no problem. Of course, there is a premise that the frequency of SPI needs to be at least 60MHZ (the screen is only tested at 240: 240).
`
static esp_err_t panel_io_spi_tx_color(esp_lcd_panel_io_t *io, int lcd_cmd, const void *color, size_t color_size)
{
esp_err_t ret = ESP_OK;
spi_transaction_t *spi_trans = NULL;
lcd_spi_trans_descriptor_t *lcd_trans = NULL;
esp_lcd_panel_io_spi_t *spi_panel_io = __containerof(io, esp_lcd_panel_io_spi_t, base);
// before issue a polling transaction, need to wait queued transactions finished
for (size_t i = 0; i < spi_panel_io->num_trans_inflight; i++) {
    ret = spi_device_get_trans_result(spi_panel_io->spi_dev, &spi_trans, portMAX_DELAY);
    ESP_GOTO_ON_ERROR(ret, err, TAG, "recycle spi transactions failed");
}
spi_panel_io->num_trans_inflight = 0;
lcd_trans = &spi_panel_io->trans_pool[0];
memset(lcd_trans, 0, sizeof(lcd_spi_trans_descriptor_t));
spi_lcd_prepare_cmd_buffer(spi_panel_io, &lcd_cmd);
lcd_trans->base.user = spi_panel_io;
lcd_trans->flags.dc_gpio_level = !spi_panel_io->flags.dc_data_level; // set D/C line to command mode
lcd_trans->base.length = spi_panel_io->lcd_cmd_bits;
lcd_trans->base.tx_buffer = &lcd_cmd;
if (spi_panel_io->flags.dc_as_cmd_phase) { // encoding DC value to SPI command phase when necessary
    lcd_trans->base.cmd = !spi_panel_io->flags.dc_data_level;
}
if (spi_panel_io->flags.octal_mode) {
    // use 8 lines for transmitting command, address and data
    lcd_trans->base.flags |= (SPI_TRANS_MULTILINE_CMD | SPI_TRANS_MULTILINE_ADDR | SPI_TRANS_MODE_OCT);
}
// command is short, using polling mode
ret = spi_device_polling_transmit(spi_panel_io->spi_dev, &lcd_trans->base);
ESP_GOTO_ON_ERROR(ret, err, TAG, "spi transmit (polling) command failed");

// sending LCD color data

#ifdef CONFIG_IDF_TARGET_ESP32S3
uint32_t size = 0;
uint16_t index = 0;
do
{
lcd_trans = &spi_panel_io->trans_pool[index];
memset(lcd_trans, 0, sizeof(lcd_spi_trans_descriptor_t));
lcd_trans->base.user = spi_panel_io;
lcd_trans->flags.dc_gpio_level = spi_panel_io->flags.dc_data_level; // set D/C line to data mode
if (spi_panel_io->flags.dc_as_cmd_phase) { // encoding DC value to SPI command phase when necessary
lcd_trans->base.cmd = spi_panel_io->flags.dc_data_level;
}
lcd_trans->base.tx_buffer = &color[size];
if (size + 32768 < color_size)
{
size += 32768;
lcd_trans->base.length = 32768 * 8; // transaction length is in bits
}
else
{
lcd_trans->flags.trans_is_color = 1;
lcd_trans->base.length = (color_size - size) * 8; // transaction length is in bits
size = color_size;
}
// color data is usually large, using queue+blocking mode
ret = spi_device_queue_trans(spi_panel_io->spi_dev, &lcd_trans->base, portMAX_DELAY);
ESP_GOTO_ON_ERROR(ret, err, TAG, "spi transmit (queue) color failed");
spi_panel_io->num_trans_inflight++;
index++;
} while (size < color_size);
#else
lcd_trans->flags.trans_is_color = 1;
lcd_trans->flags.dc_gpio_level = spi_panel_io->flags.dc_data_level; // set D/C line to data mode
lcd_trans->base.length = color_size * 8; // transaction length is in bits
lcd_trans->base.tx_buffer = color;
if (spi_panel_io->flags.dc_as_cmd_phase) { // encoding DC value to SPI command phase when necessary
lcd_trans->base.cmd = spi_panel_io->flags.dc_data_level;
}
// color data is usually large, using queue+blocking mode
// ret = spi_device_polling_transmit(spi_panel_io->spi_dev, &lcd_trans->base);
ret = spi_device_queue_trans(spi_panel_io->spi_dev, &lcd_trans->base, portMAX_DELAY);
ESP_GOTO_ON_ERROR(ret, err, TAG, "spi transmit (queue) color failed");
spi_panel_io->num_trans_inflight++;
#endif
err:
return ret;
}
`

I encountered the same problem. I was trying to transfer 40960 bytes. spi_device_polling_transmit() returns success even though it does not transmit all data as described above. i would expect an error code. Can you explain the behaviour?
On another note: since this issue exists a while: is there a workaround on driver level to transfer bigger loads or do we still need to segment at user level?

Hi ALL:
I encountered the same problem as well. I also know about that the maximum buffer is 32768 bytes. All I want to do is to transfer 120,000 bytes by using Quad SPI.
How to setting the SPI buffer over 32768 bytes in once transmittion？


Bug with Yulife

Kill @Yulife and stuff him and put him on my mantle piece, then hug him. Crashes the game, Pls fix, my mc version is 1.6.4

I think it is fixable with CTM that has obj model loading and alternate support


For a deployment - can we get an estimate of the cost to deploy - similar to www.infracost.io?

Hi There,
As a future feature request it would be nice to be able to get an estimate of the deployed solution as per the infracost solution - https://www.infracost.io/blog/jul-2022-update/

Honestly, I have yet to experience good estimates for such solutions, simply because there are so many factors that weigh in.
Sure, lets say it's within 80% accuracy of costs, not factoring in reservations, discounts, variable costs such as network bandwidth, etc. how useful is this estimate?
It certainly can help some surprised high costs that many have probably experienced when starting out with Azure, where some SKU's have very high monthly base costs - and where it used to be many had upfront costs as well, such as ASE, SQL MI, etc.
Those are probably the prime examples where this feature would be great - but for accuracy in an estimate from a bicep template covering an entire subscription based on base-fees, I personally have doubts this would be that much useful other than a pretty and neat detail.
Although I would love to not have to maintain a markdown file which price estimates for our templates based on real-world examples, I doubt a programmatic solution based on the intel available in a bicep template would suffice.
Just my 2 cents - I fully respect others may have vastly different perspectives and hopes.

This would be incredibly useful but only if

Connected to an Azure Tenant
Connected to specific deployment subscription (due to price differences across subscription offers)
Could take into account any Reserved Instance pricing

without any of those (which I think wouldn't be all that easy to build for) you'd need to rely on public pricing which would only give an estimate, though would still be very useful and as such if development were to be done for this feature it should be done against the public listed costs of resources and not client specific costs as that would just be a nightmare to get right, at least initially.

I don't think it needs to be any more accurate than the Azure Pricing Calculator for it to be useful. I just want to get a heads up that the new resource I just added might cost more than I assumed. People new to Azure don't have the price model in their head and might accidentally deploy something that isn't priced the way they think. It would also be a neat way to highlight what resources have DevTest pricing. As a tool for teaching people new to Azure, it can be very valuable even if the estimates are rough and don't include data transfers and other costs.

Just for the visibility - I actually developed a tool similar to Infracost, which works with ARM Templates, Bicep and Terraform (soon), which can be used for automated calculations of infrastructure - https://github.com/TheCloudTheory/arm-estimator


Update plugin docs

Description
This PR revamps the plugin documentation to use the docs autogeneration work done in https://github.com/napari/npe2/pull/63 and  https://github.com/napari/npe2/pull/77 and to reorganize things  to make it easier to navigate, with less emphasis on "npe2".
The main difference is that everything related to the npe2 manifest schema is generated from the schema itself, using jinja templates.  This guarantees that the docs stay in sync with the schema (there are docs tests in npe2 to guarantee that as well), and also helps ensure that any python code is still relevant.
This still needs https://github.com/napari/npe2/pull/78 (and until then the makefile has a temporary workaround).
The easiest way to review this is probably to pull it and run make docs
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

I'm not sure why the _layer_events.md and _viewer_events.md are here - are we no longer autogenerating them? And if not, do they belong in this PR? This may have been a missed conversation on my part so my apologies if that's the case.

gitignore error.  fixed, thanks.

I don't know if this organization would be the best approach, again I don't feel strongly, but I do think we need to split it up somehow.

Totally agree (and agree with your proposed org).    I tried to organize it such that it would be reasonably easy to move once the theme is able to support it.

So where are we proposing storing these docs images?  A link to where?  We've got a dozen other small images in the docs folder, I assumed that would all be done together.  Do we have a proposed location for those all yet?

@tlambert03 the suggestion at the moment is that images are stored using github's new image/video hosting. Essentially you would edit the file via the github Web interface and drag the image into the file. This would upload it to github and embed it using a link (similarly to how you upload to issues or comments by drag & drop).
Fwiw I'm still not sure whether this is a stable long term solution for the repository, and I don't know whether the size trade-off is worth it for this PR. Of course if we do keep adding images then we'd have to remove them all eventually anyway, maybe also wiping them from history? Idk... I don't have a solution here

Ok.  I'm happy to do that here I guess.  But the half-in half-out nature is a little strange.  I definitely got it when we were avoiding a 300MB influx, but this one is 3 orders of magnitude smaller and in line with an existing practice.  Have we already started doing that for other images in the repo?

For me that image comes out to 60kB as a webp (ffmpeg -i test.png -c:v libwebp test.webp).
@DragaDoncila Just so I understand: the idea is to upload the image into e.g. a comment in this PR and then link to it? Is there an example showing where we've done this in the docs?
I'd rather not hold this PR up for this. It is a sort of incremental addition to an existing problem and I'm not sure we have a real solution for doc binary assets yet - I'd love to see some a recommendation for contributors here.

@nclack you could upload to a comment yes, but my feeling is it'd be preferable to edit the file in the PR directly via the web interface (navigate to the file in the github repository and click Edit in the top right). Then you drag the file in.
I completely agree that it shouldn't hold up this PR, because as I say, I'm not sure about it being a stable long term solution. Even if we do decide to go this way, we could update this file later. The process will be documented in the contributor's guide - the content is all ready to go, pending a decision about this exact issue.

ok, all good points. i'm fine to merge as is too as the file is so small. maybe @jni can take a quick look at this tonight and then he can feel free to merge if he agrees. if we don't hear from him then i'll try and merge before i go to bed

@tlambert03 the issue with even small pngs is that they add up in the history. Even if we remove or update them later that .png will be there forever. Re existing practices I would say that I just missed them — docs/images/screenshot-add-image.png at 1.32MB added in #2187 is excessive and should not be used as precedent! It will likely to require updates since we intend to start using scientific images as illustrations. Indeed any screenshots are always going to require updates, so my goal would be to keep all screenshots off the main repo.
So, my preferences are, in order:

host the image elsewhere (I don't really understand @DragaDoncila's suggestion (?), my own suggestion was inline with yours @tlambert03: upload to a comment then link to that file; but really anywhere other than the history works, e.g. imgur)
convert to webP
just merge

And yeah, I don't like the last option very much...

host the image elsewhere (I don't really understand @DragaDoncila's suggestion (?), my own suggestion was inline with yours @tlambert03: upload to a comment then link to that file; but really anywhere other than the history works, e.g. imgur)

It's the same suggestion lol, but rather than uploading it to a random comment, you can just upload it to the file itself, which makes more sense to me.
Go to edit the file:

Remove the current link to the image:

Drag your file into there instead:

And then commit. It works exactly the same as uploading to an issue or a comment.

Wow! I love it! My confusion was "to the file itself", I thought that was somehow the png, but it's to the file doing the linking! :heart:

Wow! I love it! My confusion was "to the file itself", I thought that was somehow the png, but it's to the file doing the linking! ❤

Yeah reading back my own comment I can see how that was confusing. In my defence, it was like 3am when I wrote it 😆

I'll upload the image somewhere since multiple people requested that.  but for the record, I'm not a big fan of this approach, and I don't think we've hit on any more permanent of a solution than simply adding a small png or two (a few a year perhaps?) to the docs until we hit on our "forever" solution, at which point we're going to need to figure out the git-filter-branch (or other) approach to remove these files from history anyway.  (I don't buy the argument that once in there's literally nothing we can ever do).
Github isn't an ideal image hoster since it doesn't support webp uploads (arguably the best format), and in any case, it doesn't feel right to have our recommended approach be "upload your file to some image host and then hotlink it here".  That's not a good archival approach, it's hard to run a "collect all images" script, and it just feels weird to go through these hoops.
but we've discussed it enough here!  I'll find a host for the webp and go with the flow

I'll upload the image somewhere since multiple people requested that. but for the record, I'm not a big fan of this approach,

Yup, points totally well taken @tlambert03. We'll make addressing this a priority over the next couple months - cc @neuromusic
I will merge this now :rocket

Thanks a lot for the docs improvements @tlambert03! I just quickly went through them and noticed that some links are broken. Most importantly in the getting started part (this paragraph: https://napari.org/plugins/stable/first_plugin.html#add-a-napari-yaml-manifest) the link to the commands description (https://napari.org/plugins/stable/contributions.html#contributions-commands) leads to a 404 page. I think it's just that the contributions section is missing (maybe missing from a toc somewhere.

Thanks, yeah we're aware.  The docs publishing pipeline is a mess at the moment.  Things work fine locally until you publish.  We're on it


Library not loaded: libvpx.5.dylib

Hi! Got this crash after install from testflight (but from Fabric it work fine)
Termination Description: DYLD, Library not loaded: libvpx.5.dylib | Referenced from: /var/containers/Bundle/Application/A84E5B94-7B0E-4114-8876-12EB9E260E31/MyApp.app/MyApp | Reason: unsafe use of relative rpath libvpx.5.dylib in /var/containers/Bundle/Application/A84E5B94-7B0E-4114-8876-12EB9E260E31/MyApp.app/MyApp with restricted binary
Triggered by Thread:  0
Use swift 4.2

Same here! can't publish an app with the library cause it use a relative path somewhere in the code


Definition as a global

Is it possible to set a flag global: true to have this fetch method exposed?
Reason being is that if we don't have something like this, then writing tests for this is a pain with mocha, and we have to define our own global.fetch = require('fetch');

Why not just var fetch = require('fetch') in all mocha files? That's the standard way of doing testing in Node.js I feel.
Also there's no technical way to set a flag to make this global. Most modules that do pollute the global scope use a separate require('fetch/global') for this purpose.

what does require('fetch/global') do???
On Nov 27, 2015 12:55 PM, "Timothy Gu"<EMAIL_ADDRESS>wrote:

Why not just var fetch = require('fetch') in all mocha files? That's the
standard way of doing testing in Node.js I feel.
Also there's no technical way to set a flag to make this global. Most
modules that do pollute the global scope use a separate
require('fetch/global') for this purpose.
—
Reply to this email directly or view it on GitHub
https://github.com/bitinn/node-fetch/issues/60#issuecomment-160182516.

It does nothing – I'm just pointing out that if you want to implement addition to global scope it must be done in something like this. Right now there's no fetch/global.js.

Reason being is that if we don't have something like this, then writing tests for this is a pain with mocha...

I am not sure what you mean, we use mocha for our test cases as well, check it out.

I was able to fix this with https://github.com/niftylettuce/frisbee/blob/master/src/frisbee.js#L11 and https://github.com/niftylettuce/frisbee/blob/master/test/unit/node.test.js#L2-L4


Remove id from UnifiedItem

What is this PR trying to achieve?
To be merged after #149
As the canonicalId has become part of the IdentifiedUnifiedItem - which wraps the UnifiedItem - the UnifiedItem should not have the "id" field any longer

🎉


Less jittery camera movement (+ more natural camera movement)

Less Jittery Camera Movement
(The camera is VERY jittery, so it would be nice to smooth it out a little, and more natural camera movement so the players head doesn't immediately snap to the object it's interacting with)
Discord Username: ThatJamGuy#3226
Developer Notes (leave this blank)
Difficulty: __
Estimated Time Required: __
Once development starts.

https://github.com/JustaSqu1d/RenderSmoothing/releases/tag/v0.1-1.19.2 for 1.19.2
and https://github.com/scorbett123/RenderSmoothing/releases/tag/v0.1 for 1.18.2

https://github.com/JustaSqu1d/RenderSmoothing/releases/tag/v0.1-1.19.2 for 1.19.2 and https://github.com/scorbett123/RenderSmoothing/releases/tag/v0.1 for 1.18.2

K thanks for this


[UN-647] Update styling for featured link

Ticket URL: https://national-archives.atlassian.net/jira/software/c/projects/UN/boards/75?modal=detail&selectedIssue=UN-647
About these changes
Updates the styling for 'featured link' component and rename template from promoted_item to featured_link to improve consistency between design & wagtail naming.
Note: this also updates some tracking data attributes - we no longer have a 'button' cta in the new design because the link is now the title of the component - so I have changed the data-link-type attribute to 'Link' and updated data-link to use the title instead of cta label.
Question: we still have a wagtail field for the CTA label - I assume this is now redundant so we can remove this?
How to check these changes
Check a page locally with a featured link (e.g. http://localhost:8000/stories/festival-of-britain/) and ensure the new styling matches the latest design (https://www.figma.com/file/uo8YY98lLws8E1HEfpdn5X/TNA-Etna---Design-system?type=design&node-id=2214-17182&t=852C6eTdqkCnmFgI-0)
Before assigning to reviewer, please make sure you have

[x] Checked things thoroughly before handing over to reviewer.
[x] Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
[x] Ensured that PR includes only commits relevant to the ticket.
[ ] Waited for all CI jobs to pass before requesting a review.
[ ] Added/updated tests and documentation where relevant.

Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md

Hi Jane, without images it looks good, but with an image it looks like this:

but looks (as far as I can tell) fine in mobile view :)

Thanks so much for your help with this James, I've updated the styling now for the image and also added a small change for the data-link-type as requested by Elise. This should be ready for another review now 👍


Fix for MSVC build.

Fix initialize a structure for MSVC build.

That's legal C99 (and C++). Why not simply ignore or disable the warning?

MSVC does not support full C99 for years and MS has no intention to fix.
Since MSVC is an important compiler, I will merge initializer fix.
But I have no idea about 99e409d. What is this? Is this kind of merge hiccups?

But it's supported by MSVC as an extension (just like other C99 features).

I didn't know that. How do we turned the extension on?

They're enabled by default (like GCC) and also it's a level 4 warning, but mruby uses level 3 (/W3). So if someone or mruby itself (in the future?) uses /W4, then this warning should just be disabled in my opinion.

@cremno Do  you mean replacing /W3 by /W4 works?

@matz: No. mruby uses '/W3 (by default), but this warning is enabled by /W4 (since VS2003!). /W4 enables much more warnings and some of them are as irrelevant as this one or in rare cases false positives.
@dyama: Did you use /W4 or why did the compiler emit a warning?


feat: Hide mgmt items from non-managers

Among the changes, hides the "Add team member" button. Not sure if we want to entirely hide the "Team" page or not. It's currently titled "Manage Team Members," but maybe editors should get a "View Team Members"?

maybe editors should get a "View Team Members"

lets work that out with Jean
I think that everyone should get to create labels though.

Added back "Manage labels" for everyone. We may want to consider whether we need to protect against someone accidentally renaming or removing a core label (though we don't yet support removing labels)


Add Basic Auth support

It would be better to add basic auth support in the project. I checked the code and noticed that we are using SimpleHTTPServer. Can we use Flask?
In config file, we could define as follows:
startWebServer = true
basicAuth = **true**
basicAuthUsername = **username**
basicAuthPassword = **base64 password** or **plain password**

I even found the code, will anybody help me to pick this task.
PS: I have worked on Ruby and JavaScript before, Just have basic knowledge on Python.
Code for Auth Handler
import SimpleHTTPServer
import SocketServer
from BaseHTTPServer import BaseHTTPRequestHandler, HTTPServer

class AuthHandler(BaseHTTPRequestHandler):
    ''' Main class to present webpages and authentication. '''
    def do_HEAD(self):
        self.send_response(200)
        self.send_header('Content-type', 'text/html')
        self.end_headers()

    def do_AUTHHEAD(self):
        self.send_response(401)
        self.send_header('WWW-Authenticate', 'Basic realm=\"PLB\"')
        self.send_header('Content-type', 'text/html')
        self.end_headers()

    def do_GET(self):
        ''' Present frontpage with user authentication. '''
        if self.headers.getheader('Authorization') == None:
            self.do_AUTHHEAD()
            self.wfile.write('no auth header received')
            pass
        elif self.headers.getheader('Authorization') == 'Basic vs4vijay':
            self.do_HEAD()
            self.wfile.write(self.headers.getheader('Authorization'))
            self.wfile.write('authenticated!')
            pass
        else:
            self.do_AUTHHEAD()
            self.wfile.write(self.headers.getheader('Authorization'))
            self.wfile.write('not authenticated')
            pass

@vs4vijay
You are welcome to make a Pull Request with changes, it will be reviewed.
Look into https://github.com/BitBotFactory/poloniexlendingbot/blob/master/modules/WebServer.py#L39
There is already a custom HTTP handler which you can extend to handle Basic Auth.
If you don't have a Pyton env I recommend PyCharm.
Don't forget the Docs. :)

Yea go for it @vs4vijay .
I've done a bit of Flask stuff before, so give me a shout on Slack or Gitter if you want a hand.

I'm sorta for this, but let's not bloat the bot down with extra libraries/dependencies. The idea here is to be a lean piece of software.

Yeah - you could just run Nginx in front of it (and you'll have everything you need for SSL etc without more code in this lib).
Personally, I access mine over VPN.

It can be done in pure python without extra libraries. BaseHTTPServer is part of the standard library.
Loading it will take an extra 2028 bytes (I just checked), so it's really not an issue.
Agreed, you could run behind apache / nginx, but not everyone can do that for themselves.

How about refactoring the entire WebServer feature into a Plugin? :)

Presumably this won't be happening now since we've moved to the new WebServer setup.


CLOUDSTACK-9589 vmName entries from host_details table for the VM's w…

CLOUDSTACK-9589 vmName entries from host_details table for the VM's whose state is Expunging should be deleted during upgrade from older versions
Having vmName entries for VMs in 'expunging' states would cause with deploying VMs with matching host tags fail. So removing them during upgrade

This change has been added to the schema-480to481.sql script.  Since 4.8.1 has already shipped, this script will not be applied for those users.  Therefore, this change needs to be placed in the schema-481to4820.sql script.
Also, the base branch for this PR is master.  However, the database change is targeted at 4.8.  Therefore, the base branch should be changed to 4.8.

ACS CI BVT Run
Sumarry:
Build Number 137
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=3
Skipped=6
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
Failed tests:

test_network.py

test_delete_account Failed

test_deploy_vm_iso.py

test_deploy_vm_from_iso Failing since 21 runs

test_vm_life_cycle.py

test_10_attachAndDetach_iso Failing since 22 runs

Skipped tests:
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_routers_network_ops.py
test_disk_offerings.py

@jburwell
Change is moved to schema-481to4820.sql and base branch is changed to 4.8

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-174

Move this to 4.9 or master branch.

@rhtyd rebased to 4.9 branch as suggested

@yvsubhash can you move the changes to 490to4910.sql ? Also rebase against latest 4.9, squash your changes.

@rhtyd can you suggest me the branch for rebasing this commit against?

LGTM

ACS CI BVT Run
Sumarry:
Build Number 463
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=1
Skipped=7
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
Failed tests:

test_routers_network_ops.py

test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 2 runs

Skipped tests:
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

tag:mergeready


Support Python 3.8 in GenAI-Perf

GenAI-Perf says it supports Python 3.8. This pull request fixes the breaking Python 3.8 code (i.e. removes features only available in 3.9+). To confirm it continues to support Python 3.8, it adds a job to build and run testing against 3.8 for each PR.
A few retrofits for Python 3.8:

Using the typing library rather than the built-in subscriptable types.
Using Union rather than "|"
Using a custom pairwise function rather than the itertools function
Using custom logic rather than the in-built removeprefix function

LGTM

Thanks, Harshini! Just a note to everyone that this PR still needs approval. :)

1 sec, before we merge. Is this an update we need? do we have a customer that is asking for 3.8 support?

1 sec, before we merge. Is this an update we need? do we have a customer that is asking for 3.8 support?

This is related to our offline conversation. It sounded like there was agreement (and approval from Ganesh) for adding it. GenAI-Perf currently says it supports Python 3.8.
PyTriton also supports 3.8+ and Triton CLI did as well before it was dropped until GenAI-Perf supports 3.8+ as well. We either need to drop 3.8-3.9 support in our documentation or support and test against it.
Please refer to the offline conversation as it has the back-and-forth decision making behind this pull request.

Got it. I forgot about that convo.
You are covering all the bases and this is good to go forward. Thanks for explaining it to me.


Single, non-ASCII characters permitted as bare keys.

The following line runs successfully:
toml.loads('@ = 1')  # {'@': 1}

Whereas the TOML online parser gives an error as I would have expected from the spec. Also, using the same character in a word gives the expected error:
toml.loads('a@ = 1')  # toml.decoder.TomlDecodeError: Found invalid character in key name: '@'. Try quoting the key name.

Is this behaviour expected? Did I miss something? Thank you.

@taehyounpark That's definitely a bug in your parser, because @ isn't a valid bare key in TOML v1.0.0. The same applies to<EMAIL_ADDRESS>You'll want to find the project for the parser that you're using and file bug reports with them about these.

@eksortso I believe that’s precisely what has been done here. :)

@eksortso I believe that’s precisely what has been done here. :)

Whoops, I was in the wrong project. My bad, sorry! :)


[BREAKING] Task API arguments rename

BREAKING CHANGE:
Task API namespace option got renamed to projectNamespace
JIRA: CPOUI5FOUNDATION-802
Relates to: https://github.com/SAP/ui5-tooling/issues/701

coverage: 94.63% (+0.02%) from 94.606%
when pulling 476e1296bfdb4fa8971cfaf4961f3fc5eed09af0 on breaking-v4-task-api
into 4af782c26ab74f80ded54eb70b841dd96636b929 on main.


Allow different degrees in witgen

Fixes #1494

use cbor for witness and constant files (moving polygon serialisation to the relevant backend)
add degree field on Symbol, inherited from the namespace degree
have each machine in witgen operate over its own degree
fail in the backend if we have many degrees

tests failing

I cannot really comment this in-line, so:
I would remove the degree parameter from Condenser::new and change Condenser::set_namespace to Condenser::set_namespace_and_degree, which takes the namespace and degree from the definition and stores it as the current namespace and degree in Condenser::degree.


Upgrade to React 18

Description

What was changed in this pull request?

Apply changes in https://github.com/higlass/higlass/pull/1104 based on the current develop branch. (Since recent changes on the base branch led to massive conflicts, I instead newly created this branch).

pkerpedjiev's original comment:

Update React to react 18
Change hglib.viewer() function to return a promise rather than an object. This is necessary because the React component render isn't necessarily synchronous and we may not have a reference to it immediately. We'll likely have to bump the major version number of the library.

Added documentation about upgrading React 18 under Troubleshooting. Feel free to suggest/make changes.

Changed all React tests (use await)

Why is it necessary?

Fixes #___
Checklist

[ ] Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
[x] Unit tests added or updated
[x] Documentation added or updated
[ ] Example(s) added or updated
[ ] Update schema.json if there are changes to the viewconf JSON structure format
[ ] Screenshot for visual changes (e.g. new tracks or UI changes)
[x] Updated CHANGELOG.md

I see we have @wojtekmaj/enzyme-adapter-react-17 on the package.json. Any idea about using enzyme with the latest React?

Hi @pkerpedjiev, I made this PR to apply your changes on top of the current develop branch. Could you take a look and let me know if we need to make other changes to be able to upgrade React 18?

I'm getting an error when trying to run on this branch. I'm probably doing something wrong but can't tell off the top of my head. Any ideas? cc @manzt
(base) toc3~/projects/higlass(sehilyi/react-18|✚1…) % npm run start

><EMAIL_ADDRESS>start /Users/pete/projects/higlass
> vite

/Users/pete/projects/higlass/node_modules/vite/bin/vite.js:2
import { performance } from 'node:perf_hooks'
       ^

SyntaxError: Unexpected token {
    at Module._compile (internal/modules/cjs/loader.js:723:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)

hmm what version of node are you on? this code is failing with a protocol import.


just asking

Why cats ?
why not any other thing or animals ?
Is this because CATS have ESP ?
or any other reason ?
&& why intel-coders love CATS so much ?
I can't figure it out..
PS I don't hate cats, I love wild-cats

because i wanted to


Update dev diplodocus and add new image with raster support

Solving #62 and #60

problems compiling...


[Package Renames] Add end-to-end test

Test that the package rename feature works as expected:

Upload a package
Rename it using the Gallery API
Check that search API lists its renames

This depends on:

NuGetGallery#7909 - Add Gallery API for end-to-end testing
NuGetGallery#7903 - Expose popularity transfers in search
NuGetGallery#7911 - Reduce popularity transfer propagation times

This is necessary as it takes up to 1.5 hours to propagate popularity transfers

Closing as per https://github.com/NuGet/NuGetGallery/issues/7896#issuecomment-653172862


Specification improvement and bug fix to sign_request

Per the OAuth Body Hash specifications (3.2), if there is no body entity, then the hash should be done over the empty string.
Also, when httplib2 handles a redirect, the follow is performed with None as the request body. This causes a TypeError to be thrown here when attempting to hash the body.
This commit prevents the TypeError, while improving the specification alignment.
"Win, win, win." -Michael Scott

Should fix issue #112
Should close pull #113
Many thanks to @holm!

Is this similar to the fix or different from #163?

It is similar to the fix in #163 but more correct. #163 skips the hash if the request does not have a body. My change properly hashes the empty string when there's no body, as specified in section 3.2.
I also noticed you asked for a regression test in #163, I'm happy to add that here.

@rickhanlonii You answered my other question in that PR as well. Please add a regression test. @jaitaiwan I'm :+1: after the test has been added. Can you take a peak?

Added a test. Before my change the test I added would fail with:
Error
Traceback (most recent call last):
  File "/Library/Python/2.7/site-packages/mock.py", line 1190, in patched
    return func(*args, **keywargs)
  File "/Users/euler/dev/python-oauth2/tests/test_oauth.py", line 1322, in test_url_with_query_string_body_none
    client.request(uri, 'GET', body=None)
  File "/Users/euler/dev/python-oauth2/oauth2/__init__.py", line 668, in request
    req.sign_request(self.method, self.consumer, self.token)
  File "/Users/euler/dev/python-oauth2/oauth2/__init__.py", line 499, in sign_request
    self['oauth_body_hash'] = base64.b64encode(sha(self.body).digest())
TypeError: must be string or buffer, not None

MMmmmm ... regression tests. :+1: cc @jaitaiwan

@jaitaiwan aaaaannnnnnnnnd Travis has arisen from the dead. PRs are building and tests are passing in 2.6 and 2.7.

Fantastic.

Sure will :ok_hand:


Unable to deploy Meteor 1.4.1 app

Hi - I am not a 100% sure where i should report this issue so i posted it here. Please move it to an appropriate place.
My app was working just fine on modulus before i updated it to Meteor version <IP_ADDRESS>
I get errors like this in modulus logs:
><EMAIL_ADDRESS>start /mnt/app/bundle/programs/server
> node ../../main

assert.js:93
  throw new assert.AssertionError({
        ^
AssertionError: "undefined" === "function"
    at wrapPathFunction (/mnt/app/bundle/programs/server/mini-files.js:77:10)
    at Object.<anonymous> (/mnt/app/bundle/programs/server/mini-files.js:108:24)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/mnt/app/bundle/programs/server/boot.js:9:13)
    at Module._compile (module.js:456:26)

npm ERR! Linux 3.13.0-92-generic
npm ERR! argv "node" "/mnt/app/.modulus/nvm/v0.10.41/bin/npm" "start"
npm ERR! node v0.10.41
npm ERR! npm  v3.10.6
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `node ../../main`
npm ERR! Exit status 8
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node ../../main'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the meteor-dev-bundle package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ../../main
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs meteor-dev-bundle
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls meteor-dev-bundle
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /mnt/app/bundle/programs/server/npm-debug.log
Now using node v0.10.41 (npm v3.10.6)
Found package.json: ./bundle/programs/server/package.json
Running command: npm start

><EMAIL_ADDRESS>start /mnt/app/bundle/programs/server
> node ../../main

assert.js:93
  throw new assert.AssertionError({
        ^
AssertionError: "undefined" === "function"
    at wrapPathFunction (/mnt/app/bundle/programs/server/mini-files.js:77:10)
    at Object.<anonymous> (/mnt/app/bundle/programs/server/mini-files.js:108:24)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/mnt/app/bundle/programs/server/boot.js:9:13)
    at Module._compile (module.js:456:26)

npm ERR! Linux 3.13.0-92-generic
npm ERR! argv "node" "/mnt/app/.modulus/nvm/v0.10.41/bin/npm" "start"
npm ERR! node v0.10.41
npm ERR! npm  v3.10.6
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `node ../../main`
npm ERR! Exit status 8
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node ../../main'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the meteor-dev-bundle package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ../../main
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs meteor-dev-bundle
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls meteor-dev-bundle
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /mnt/app/bundle/programs/server/npm-debug.log
Now using node v0.10.41 (npm v3.10.6)
Found package.json: ./bundle/programs/server/package.json
Running command: npm start

><EMAIL_ADDRESS>start /mnt/app/bundle/programs/server
> node ../../main

assert.js:93
  throw new assert.AssertionError({
        ^
AssertionError: "undefined" === "function"
    at wrapPathFunction (/mnt/app/bundle/programs/server/mini-files.js:77:10)
    at Object.<anonymous> (/mnt/app/bundle/programs/server/mini-files.js:108:24)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/mnt/app/bundle/programs/server/boot.js:9:13)
    at Module._compile (module.js:456:26)

npm ERR! Linux 3.13.0-92-generic
npm ERR! argv "node" "/mnt/app/.modulus/nvm/v0.10.41/bin/npm" "start"
npm ERR! node v0.10.41
npm ERR! npm  v3.10.6
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `node ../../main`
npm ERR! Exit status 8
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node ../../main'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the meteor-dev-bundle package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ../../main
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs meteor-dev-bundle
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls meteor-dev-bundle
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /mnt/app/bundle/programs/server/npm-debug.log
Now using node v0.10.41 (npm v3.10.6)
Found package.json: ./bundle/programs/server/package.json
Running command: npm start

><EMAIL_ADDRESS>start /mnt/app/bundle/programs/server
> node ../../main

assert.js:93
  throw new assert.AssertionError({
        ^
AssertionError: "undefined" === "function"
    at wrapPathFunction (/mnt/app/bundle/programs/server/mini-files.js:77:10)
    at Object.<anonymous> (/mnt/app/bundle/programs/server/mini-files.js:108:24)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/mnt/app/bundle/programs/server/boot.js:9:13)
    at Module._compile (module.js:456:26)

npm ERR! Linux 3.13.0-92-generic
npm ERR! argv "node" "/mnt/app/.modulus/nvm/v0.10.41/bin/npm" "start"
npm ERR! node v0.10.41
npm ERR! npm  v3.10.6
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `node ../../main`
npm ERR! Exit status 8
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node ../../main'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the meteor-dev-bundle package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ../../main
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs meteor-dev-bundle
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls meteor-dev-bundle
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /mnt/app/bundle/programs/server/npm-debug.log
Now using node v0.10.41 (npm v3.10.6)
Found package.json: ./bundle/programs/server/package.json
Running command: npm start

Now i have upgraded the app to meteor v1.4.1 and still the app is broken. Can anyone please tell me how to get it working on Modulus again? (Its been several weeks now and is getting rather frustrating :( )

Hey @hassanasad this is not an issue with demeteorizer. The process completes successfully. Meteor 1.4 requires node@v4. If you're deploying from the CLI, you can pass new arguments that support the node/npm version you want your project to use
$ modulus deploy -p <projectName> --node-version 4
That will fix that error. If you continue to experience problems you can follow the thread on the onmodulus/docker-build-meteor#25 repo.


Updating .newdev & removing .consolidate

See what you did with adding brackets around urls. I'll do that in the future. Added directions to the dev channels in .newdev. .consolidate is doing doubles in Ergopad, so removing. Does raise the question of integrating into sigmabot and using some prefix and qualifier for projects, such as .spf consolidate and .pad consolidate, and separate them into different cogs. Not sure if this is something that you, the projects or anyone else wants. So, leaving alone for now.

@cafebedouin i think we can leave alone for now and then rearchitect some things when/if more projects adopt sigmabot and want their own cogs. the option is also there for them to take this existing work and rewrite according to what they want too so lots of different ways to cut that pie.
in any case, approving PR and moving to prod. thanks for your contributions!


Bad practice?

I'm using ag-grid with angular1, as a directive.
That means, the API only loads after the first digest cycle, or in some cases a couple of cycles.
So if I want to show a grid, instantly loading data, on my data getting function, I'm calling this function:
function showLoading() {
    if (vm.grid.api === undefined)
        $timeout(showLoading);
    else
        vm.grid.api.showLoadingOverlay();
}

If it is the page full refresh, it calls this function 3 times.
If it is just a location change, usually 2 times.
If I just call the function after the grid's loading, like with free-text server-side text search, it calls only once.
On the one hand I feel dumb for doing so, but on the other I see no alternative.
Is this the correct way?

use the gridReady callback.
used in lots of my examples, such as the one on this page:
https://www.ag-grid.com/javascript-grid-value-getters/index.php


Doesn't work on files around 1mb and larger

this seems to fail when dealing with anything other than a minimal amount of data.

Hey @mattshepherd I've had this problem to it seems to be a matter on how jsonview parses the json data. You can try out another plugin I made which works better in this cases.
https://github.com/acrogenesis/JSONAce

Thanks, that doesn't seem to work either. Here is an example if you are wanting to give it a try:
http://results.skitosea.com/api/v1/2014/results

It does work on my mac, which version of OS X do you have and which version of Safari.

10.10.2 and 8.0.4
I have only tested on my main machine 2014 Core i7 11” Macbook Air with 8GB RAM.

On Apr 8, 2015, at 9:15 AM, Adrian Rangel<EMAIL_ADDRESS>wrote:
It does work on my mac, which version of OS X do you have and which version of Safari.
https://cloud.githubusercontent.com/assets/1312687/7049627/9536ba66-dde0-11e4-9658-93722435cbd8.png
—
Reply to this email directly or view it on GitHub https://github.com/acrogenesis/jsonview-safari/issues/2#issuecomment-90963420.

Could you update to 10.10.3 (comes with safari 8.0.5), and let me no if it still fails. (It was released today I was on the beta before)

Still no go.

On Apr 8, 2015, at 5:59 PM, Adrian Rangel<EMAIL_ADDRESS>wrote:
Could you update to 10.10.3 (comes with safari 8.0.5), and let me no if it still fails. (It was released today I was on the beta before)
—
Reply to this email directly or view it on GitHub https://github.com/acrogenesis/jsonview-safari/issues/2#issuecomment-91081279.

@mattshepherd I found the error, the download link for version 1.2 was wrong so you had 1.1 (this was a known problem on 1.1). Restart your safari and in a moment it should update. I tried it on a 2013 MacBookPro and it worked great

Working. Safari had already updated it. Just had to refresh.
Thanks.

On Apr 9, 2015, at 4:58 PM, Adrian Rangel<EMAIL_ADDRESS>wrote:
@mattshepherd https://github.com/mattshepherd I found the error, the download link for version 1.2 was wrong so you had 1.1 (this was a known problem on 1.1). Restart your safari and in a moment it should update. I tried it on a 2013 MacBookPro and it worked great
—
Reply to this email directly or view it on GitHub https://github.com/acrogenesis/jsonview-safari/issues/2#issuecomment-91383911.


Pester to do.oo3 -> text?

I'm wondering about helping a bit, but I can't even check the To Do list without using OmniOutliner. There is a 14-day trial, but a longer-term solution would be better.
So, would you consider converting the .oo3 file to some other, freely accessible, format? (I could do it myself and send a pull request, but what kind of format would you like?)

On Tue, Sep 29, 2015 at 12:41:59AM -0700, Horacio Mijail Antón Quiles wrote:

I'm wondering about helping a bit, but I can't even check the To Do
list without using OmniOutliner. There is a 14-day trial, but a
longer-term solution would be better.
So, would you consider converting the .oo3 file to some other,
freely accessible, format? (I could do it myself and send a pull
request, but what kind of format would you like?)

I converted it to HTML and checked it in, with the intention that this
will be read-only.  I will see about scripting this so it
automatically converts every time I change it.  For now, I'll keep it
up to date with any changes you make.  It's just a lot less overhead
than trying to deal with an issue tracker, and the vast majority of
what's in there is feature ideas I will probably never get to.
Also, let me know if anything in there doesn't make sense and I can
try to clarify.
Thanks for your interest!
--Nicholas

I've linked to a HTML rendering (through rawgit.com) from the README, and written the aforementioned script, which now also automates my update commits.  Should be enough for now, and probably something I should have done a while ago!
Here's the script, which will save, export and commit for me.


Using themes from Blogifier.Core is broken on Ubuntu

When I set the AdminTheme or BlogTheme to 'Standard' (which is defined in the Blogifier.Core project), I get the following error on ubuntu:
InvalidOperationException: Cannot find compilation library location for package 'Microsoft.Win32.Registry'
this may be related to the following issue:
https://github.com/dotnet/core-setup/issues/2117
I can use themes defined in the WebApp project just fine, I just can't use any of the Views that are in Blogifier.Core

I think i found a workaround for the problem.
Adding the following into the WebApp project file:
<MvcRazorCompileOnPublish>false</MvcRazorCompileOnPublish>
will create a 'refs' folder with all the required assemblies. If I FTP the 'refs' folder to my server, the pages work again. The downside is that the initial load after a dotnet restart will cause the loading to be very slow, although that only affects the initial page load. Subsequent page loads are pretty quick.
I only needed to copy the 'refs' folder, and not the 'Views' folder. After the 'refs' folder is copied, you can delete the code above from the webapp project and publish as before, so long as you leave the 'refs' folder on your server in your web directory.

Just a quick update on this. This might be related to the switch to Core 2.0 (I've been using the dev branch). I noticed other problems, such as the _ViewImports.cshtml file not really working. I've had to update all @model references in the /View/Account/ and /View/Manage/ folder to use fully qualified names, for example:
@model WebApp.Models.AccountViewModels.LoginViewModel
@inject Microsoft.AspNetCore.Identity.SignInManager<WebApp.Models.ApplicationUser> SignInManager

I made some more progress on this. The reason why the _ViewImports wasn't working seems to be because it was conflicting with the _ViewImports from the Blogifier.Core project. Its possible that, since they were both in an identical location, they were conflicting with each other. Removing the _ViewImports.cshtml from Blogifier.Core made my WebApp work correctly.
I'm starting to understand how you guys got the Views from Blogifier.Core to work in the WebApp (and the purpose of the "PrependFileProvider" setting). Unfortunately, this doesn't seem to work anymore for me in the latest core 2.0 build on Ubuntu. I'll try to figure out why....

In attempting to get the Views from Blogifier.Core working, I found another problem, which may again be related to the core 2.0 push.
In EmbeddedResources.cs, the following
if(ex.Message == "Write to non-body 304 response.")
needed to be changed to
 if(ex.Message == "Write to non-body 304 response." || ex.Message == "Writing to the response body is invalid for responses with status code 304.")
The error message appears to be different than what was expected.

I was finally able to get everything working again on Ubuntu. To summarize, I took the following steps:

I generated a "refs" folder containing all of the required assemblies by adding <MvcRazorCompileOnPublish>false</MvcRazorCompileOnPublish> to the WebApp project. I copied the refs folder to the root web folder on Linux. I then removed the MvcRazorCompileOnPublish tag from my WebApp project.

I removed the _ViewStart.cshtml file from Blogifier.Core/Views. I manually added@addTagHelper *, Microsoft.AspNetCore.Mvc.TagHelpers to all of the views to compensate.

I updated EmbeddedResources.cs as described by the post directly above.

I realize these aren't ideal changes, but that's was was necessary for me to get the core 2.0 package working on ubuntu. Hopefully you guys can find better workarounds.

Thanks for doing this, we soon will be ready for testing Linux/PostgreSql functionality and this might help to avoid some major headaches.

I also encountered this problem:
it is broken out after release to Linux,but it is Passed on windows,I think the reason is that Windows and Linux have different paths, do you think?
Exception:
[Error] The view '"/Views/Blogifier/Themes/Standard/Index.cshtml"' was not found. Searched locations: ["/Views/Blogifier/Themes/Standard/Index.cshtml"]

The current build is tested and working out of the box on Ubuntu, so closing this up.


feat: create a typescript plugin

Current dependencies on/for this PR:

main

PR #386

PR #402

PR #403   👈

This comment was auto-generated by Graphite.

creating new issue for this

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#403  👈
#402 : 2 other dependent PRs (#533 , #537 )
#504 : 1 other dependent PR (#499 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @boneskull and the rest of your teammates on  Graphite


Do not display in App if not allowed by UX

Description
Fixes https://ledgerhq.atlassian.net/browse/FWEO-924 to forbid Apps to redraw/refresh screen when disallowed by UX
Changes include

[*] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
[ ] Tests
[ ] Documentation
[ ] Other (for changes that might not fit in any category)
[ ]

Codecov Report
Patch and project coverage have no change.

Comparison is base (6ca66e1) 85.97% compared to head (2f2ad1a) 85.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   85.97%   85.97%
=======================================
  Files           8        8
  Lines         385      385
=======================================
  Hits          331      331
  Misses         54       54

Flag
Coverage Δ

unittests
85.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


libopensmtpd: init at 0.7; opensmtpd-filter-dkimsign: init at 0.6

Description of changes
Adds a filter for OpenSMTPD that attaches DKIM signatures to outgoing mail. libopensmtpd is a dependency of that filter.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

cc @obadz @Ekleog

Result of nixpkgs-review pr 173181 run on x86_64-linux 1

2 packages built:

libopensmtpd
opensmtpd-filter-dkimsign

thanks! :)


Fixed git checksum

Description
Fixed windows git checksum from https://github.com/git-for-windows/git/releases/tag/v2.35.1.windows.1
Obvious fix.
Issues Resolved
Check List

[ ] A summary of changes made is included in the CHANGELOG under ## Unreleased
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

Thanks for the PR!
If you could update the rspec tests so they pass and add a CHANGELOG entry then we can get this released 🚀

Hi @bmhughes I have made the change, let me know if there's anything else 😄

Hi @bmhughes I have made the change, let me know if there's anything else 😄

Looks great, thanks!

Released as: 11.1.1


Issue when installing

I tried installing it from Microsoft store and from GitHub (I pressed on the download button next to the preview button) it give me an error both times

@IbrahimAlIbrahimz thank you for your feedback, this doesn't appear to be an with Files, can you report this issue under MSIX or the MIcrosoft Store in the Feedback Hub?

try doing this from https://answers.microsoft.com/en-us/windows/forum/all/windows-10-does-not-install-updates-error/80fcf8c8-21d7-4e22-bceb-1dd88255658b
type services in the start menu and open it
Find the Windows Update service, right-click it, and then click Properties.
On the General tab, next to Startup type, make sure that Automatic is selected.
Next to Service status, check to see if the service is started. If it is not, click Start.

I tried doing so but it keeps saying access denied


BaseChunkSVForwardIndexWriter's default version can end up storing the overflowed chunkOffset in the header

BaseChunkSVForwardIndexWriter's default version is V2. V2 uses 4bytes to store chunkOffset. When there are a lot of rows for "noDictionaryColumn", it can actually store overflowed int value for chunkOffset in the header. From V3, we store long value so we won't face this issue.

The correct behavior should be throwing the exception when we generate the segment if we face the int overflow for chunk Offset.

V4 would also avoid this, has some other advantages discussed here but has a size limit of 4GiB.


[MINOR] test: fix tempdir leak in KerberizedHdfs tests

What changes were proposed in this pull request?
Use JUnit 5 managed @TempDir in KerberizedHdfs test.
Why are the changes needed?
The tempdir created by KerberizedHdfs is leaking.
It may cause test failures in some condition.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Before:
$ mvn test -Dtest=HadoopFilesystemProviderTest
...
$ find . -name 'serverKS.jks'
./common/target/tmp/kerberizedDfsBaseDir1821275617120252168/serverKS.jks

After:
$ mvn test -Dtest=HadoopFilesystemProviderTest
...
$ find . -name 'serverKS.jks'

Codecov Report

Merging #721 (8d3010b) into master (1e605c7) will increase coverage by 2.31%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #721      +/-   ##
============================================
+ Coverage     60.49%   62.81%   +2.31%
- Complexity     1846     1850       +4
============================================
  Files           228      215      -13
  Lines         12744    10785    -1959
  Branches       1067     1064       -3
============================================
- Hits           7710     6775     -935
+ Misses         4625     3660     -965
+ Partials        409      350      -59

see 30 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zuston please cherry-pick this to branch-0.7 after it's merged.

Merge to master & branch 0.7.

Thanks @jerqi for the review.

We run
mvn package

The test fail
ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.896 s <<< FAILURE! - in org.apache.uniffle.common.filesystem.HadoopFilesystemProviderTest
[ERROR] org.apache.uniffle.common.filesystem.HadoopFilesystemProviderTest  Time elapsed: 1.896 s  <<< ERROR!
java.lang.Exception: java.io.FileNotFoundException: /Users/roryqi/Downloads/apache-uniffle-0.7.0-incubating-src/common/target/tmp/junit1553702532156578735/serverKS.jks (No such file or directory)
I revert this pr. The tests passed.

@jerqi OK, please revert this. I'll look into it later.


align log with 'Before cleanup'

Also, There is something strange about this test failing regularly 'sometimes' :)


Implement rstuf artifact add command

Tests for the newly added command are still pending, but wanted to push the work so far for review.
We probably need to redesign the way we authenticate to the API and better define how we want to use the .rstuf.ini config file. TBD in another task.

Closes #343

Will rebase and complete the task after https://github.com/repository-service-tuf/repository-service-tuf-cli/pull/340/commits/185dc90be290d837f9f3432631c06660532b2e7a is merged.

@kairoaraujo PR is ready for another round of review. We still have the --token issue pending, which I believe was not merged with your previous PR.

@kairoaraujo PR is ready for another round of review. We still have the --token issue pending, which I believe was not merged with your previous PR.

I opened the -t/--token in a another PR

#369