Would love to be able to change the color of the icon in the menu bar

Visual feature request: most of the icons in the menu bar are white. Keycastr is icon is black. It would be nice to be able to change the color.

Happy to consider updates in the form of a pull request, especially now that we have a proposed contribution for an updated app icon in #213 .

If you want to hide it completely (ie. for creating a video tutorial or similar), I can recommend Hidden Bar app:
https://superbits.co/hidden/
It's free.


CoreHandler calls shutdown in NotConnected State, fixing ServiceClient

Fixes #278 .  Now service clients will properly stop trying to connect if disconnect is called during the connection process.  This was basically solved by having CoreHandlerinvoke the shutdown process while in the NotConnectedstate.  Previously it would only do it in the Connected state.

Current coverage is 83.76%

Merging #362 into master will increase coverage by +0.04% as of 35d1156

@@            master    #362   diff @@
======================================
  Files           69      69
  Stmts         3490    3492     +2
  Branches       507     507
  Methods
======================================
+ Hit           2922    2925     +3
  Partial          0       0
+ Missed         568     567     -1

Review entire Coverage Diff as of 35d1156

Powered by Codecov. Updated on successful CI builds.

👍


(wip) added dockerfile and cicd to publish the image

This PR adds a docker image for the package and CICD to publish it.
Discussed here:
https://github.com/MannLabs/alphatims/issues/256
LMK what you think. There are several ways to go around the CICD that I think should be design decisions with the team (whether to build the image and test the Dockerfile, whether to include the plotting dependencies, scope of the documentation ...)
Let me know which of those you feel would be what the project as a whole wants and we can work together in finishing those details!
Best,
Sebastian

@sander-willems-bruker lmk what you think

Hello @sander-willems-bruker.
I am sorry if my previous message were not clear.
The state of this PR was a draft that could build an image, but since there is not CICD testing set up in the branch for the build system on PR, it was not possible to test whether permissions are set up correctly to upload the image.
Oddly enough it seems to fiat he build (even though the build succeeds locally and using a docker image internally)
UPDATE:
Seems like adding wheel as a dependency works
pip install wheel twine
python setup.py bdist_wheel
twine check dist/*

Logs of the local build
$ python setup.py bdist_wheel &>> build_log.log
                                                                                feature/dockerfile
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/alphatims
copying alphatims/plotting.py -> build/lib/alphatims
copying alphatims/tempmmap.py -> build/lib/alphatims
copying alphatims/__init__.py -> build/lib/alphatims
copying alphatims/bruker.py -> build/lib/alphatims
copying alphatims/cli.py -> build/lib/alphatims
copying alphatims/utils.py -> build/lib/alphatims
copying alphatims/dia_data.py -> build/lib/alphatims
copying alphatims/gui.py -> build/lib/alphatims
copying alphatims/__main__.py -> build/lib/alphatims
copying alphatims/compiling.py -> build/lib/alphatims
running egg_info
writing alphatims.egg-info/PKG-INFO
writing dependency_links to alphatims.egg-info/dependency_links.txt
writing entry points to alphatims.egg-info/entry_points.txt
writing requirements to alphatims.egg-info/requires.txt
writing top-level names to alphatims.egg-info/top_level.txt
reading manifest file 'alphatims.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
adding license file 'LICENSE-THIRD-PARTY.txt'
adding license file 'LICENSE.txt'
writing manifest file 'alphatims.egg-info/SOURCES.txt'
creating build/lib/alphatims/__pycache__
copying alphatims/__pycache__/__init__.cpython-39.pyc -> build/lib/alphatims/__pycache__
creating build/lib/alphatims/docs
copying alphatims/docs/cli_manual.pdf -> build/lib/alphatims/docs
copying alphatims/docs/gui_manual.pdf -> build/lib/alphatims/docs
creating build/lib/alphatims/ext
copying alphatims/ext/timsdata.dll -> build/lib/alphatims/ext
copying alphatims/ext/timsdata.so -> build/lib/alphatims/ext
creating build/lib/alphatims/img
copying alphatims/img/github.png -> build/lib/alphatims/img
copying alphatims/img/max-planck-gesellschaft.jpg -> build/lib/alphatims/img
copying alphatims/img/mpi_logo.png -> build/lib/alphatims/img
creating build/lib/alphatims/lib
copying alphatims/lib/interface_parameters.json -> build/lib/alphatims/lib
installing to build/bdist.macosx-13-arm64/wheel
running install
running install_lib
creating build/bdist.macosx-13-arm64
creating build/bdist.macosx-13-arm64/wheel
creating build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/plotting.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/tempmmap.py -> build/bdist.macosx-13-arm64/wheel/alphatims
creating build/bdist.macosx-13-arm64/wheel/alphatims/ext
copying build/lib/alphatims/ext/timsdata.so -> build/bdist.macosx-13-arm64/wheel/alphatims/ext
copying build/lib/alphatims/ext/timsdata.dll -> build/bdist.macosx-13-arm64/wheel/alphatims/ext
copying build/lib/alphatims/__init__.py -> build/bdist.macosx-13-arm64/wheel/alphatims
creating build/bdist.macosx-13-arm64/wheel/alphatims/__pycache__
copying build/lib/alphatims/__pycache__/__init__.cpython-39.pyc -> build/bdist.macosx-13-arm64/wheel/alphatims/__pycache__
creating build/bdist.macosx-13-arm64/wheel/alphatims/docs
copying build/lib/alphatims/docs/cli_manual.pdf -> build/bdist.macosx-13-arm64/wheel/alphatims/docs
copying build/lib/alphatims/docs/gui_manual.pdf -> build/bdist.macosx-13-arm64/wheel/alphatims/docs
creating build/bdist.macosx-13-arm64/wheel/alphatims/img
copying build/lib/alphatims/img/github.png -> build/bdist.macosx-13-arm64/wheel/alphatims/img
copying build/lib/alphatims/img/mpi_logo.png -> build/bdist.macosx-13-arm64/wheel/alphatims/img
copying build/lib/alphatims/img/max-planck-gesellschaft.jpg -> build/bdist.macosx-13-arm64/wheel/alphatims/img
copying build/lib/alphatims/bruker.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/cli.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/utils.py -> build/bdist.macosx-13-arm64/wheel/alphatims
creating build/bdist.macosx-13-arm64/wheel/alphatims/lib
copying build/lib/alphatims/lib/interface_parameters.json -> build/bdist.macosx-13-arm64/wheel/alphatims/lib
copying build/lib/alphatims/dia_data.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/gui.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/__main__.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/compiling.py -> build/bdist.macosx-13-arm64/wheel/alphatims
running install_egg_info
Copying alphatims.egg-info to build/bdist.macosx-13-arm64/wheel/alphatims-1.0.7-py3.9.egg-info
running install_scripts
creating build/bdist.macosx-13-arm64/wheel/alphatims-1.0.7.dist-info/WHEEL
creating 'dist/alphatims-1.0.7-py3-none-any.whl' and adding 'build/bdist.macosx-13-arm64/wheel' to it
adding 'alphatims/__init__.py'
adding 'alphatims/__main__.py'
adding 'alphatims/bruker.py'
adding 'alphatims/cli.py'
adding 'alphatims/compiling.py'
adding 'alphatims/dia_data.py'
adding 'alphatims/gui.py'
adding 'alphatims/plotting.py'
adding 'alphatims/tempmmap.py'
adding 'alphatims/utils.py'
adding 'alphatims/__pycache__/__init__.cpython-39.pyc'
adding 'alphatims/docs/cli_manual.pdf'
adding 'alphatims/docs/gui_manual.pdf'
adding 'alphatims/ext/timsdata.dll'
adding 'alphatims/ext/timsdata.so'
adding 'alphatims/img/github.png'
adding 'alphatims/img/max-planck-gesellschaft.jpg'
adding 'alphatims/img/mpi_logo.png'
adding 'alphatims/lib/interface_parameters.json'
adding 'alphatims-1.0.7.dist-info/LICENSE-THIRD-PARTY.txt'
adding 'alphatims-1.0.7.dist-info/LICENSE.txt'
adding 'alphatims-1.0.7.dist-info/METADATA'
adding 'alphatims-1.0.7.dist-info/WHEEL'
adding 'alphatims-1.0.7.dist-info/entry_points.txt'
adding 'alphatims-1.0.7.dist-info/top_level.txt'
adding 'alphatims-1.0.7.dist-info/RECORD'
removing build/bdist.macosx-13-arm64/wheel
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/alphatims
copying alphatims/plotting.py -> build/lib/alphatims
copying alphatims/tempmmap.py -> build/lib/alphatims
copying alphatims/__init__.py -> build/lib/alphatims
copying alphatims/bruker.py -> build/lib/alphatims
copying alphatims/cli.py -> build/lib/alphatims
copying alphatims/utils.py -> build/lib/alphatims
copying alphatims/dia_data.py -> build/lib/alphatims
copying alphatims/gui.py -> build/lib/alphatims
copying alphatims/__main__.py -> build/lib/alphatims
copying alphatims/compiling.py -> build/lib/alphatims
running egg_info
writing alphatims.egg-info/PKG-INFO
writing dependency_links to alphatims.egg-info/dependency_links.txt
writing entry points to alphatims.egg-info/entry_points.txt
writing requirements to alphatims.egg-info/requires.txt
writing top-level names to alphatims.egg-info/top_level.txt
reading manifest file 'alphatims.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*' found under directory 'alphatims/logs'
adding license file 'LICENSE-THIRD-PARTY.txt'
adding license file 'LICENSE.txt'
writing manifest file 'alphatims.egg-info/SOURCES.txt'
/Users/sebastianpaez/git/alphatims/venv/lib/python3.9/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'alphatims.__pycache__' as data is deprecated, please list it in `packages`.
    !!

    ############################
    # Package would be ignored #
    ############################
    Python recognizes 'alphatims.__pycache__' as an importable package,
    but it is not listed in the `packages` configuration of setuptools.

    'alphatims.__pycache__' has been automatically added to the distribution only
    because it may contain data files, but this behavior is likely to change
    in future versions of setuptools (and therefore is considered deprecated).

    Please make sure that 'alphatims.__pycache__' is included as a package by using
    the `packages` configuration field or the proper discovery methods
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
    instead of `find_packages(...)`/`find:`).

    You can read more about "package discovery" and "data files" on setuptools
    documentation page.

!!

  check.warn(importable)
/Users/sebastianpaez/git/alphatims/venv/lib/python3.9/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'alphatims.docs' as data is deprecated, please list it in `packages`.
    !!

    ############################
    # Package would be ignored #
    ############################
    Python recognizes 'alphatims.docs' as an importable package,
    but it is not listed in the `packages` configuration of setuptools.

    'alphatims.docs' has been automatically added to the distribution only
    because it may contain data files, but this behavior is likely to change
    in future versions of setuptools (and therefore is considered deprecated).

    Please make sure that 'alphatims.docs' is included as a package by using
    the `packages` configuration field or the proper discovery methods
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
    instead of `find_packages(...)`/`find:`).

    You can read more about "package discovery" and "data files" on setuptools
    documentation page.

!!

  check.warn(importable)
/Users/sebastianpaez/git/alphatims/venv/lib/python3.9/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'alphatims.ext' as data is deprecated, please list it in `packages`.
    !!

    ############################
    # Package would be ignored #
    ############################
    Python recognizes 'alphatims.ext' as an importable package,
    but it is not listed in the `packages` configuration of setuptools.

    'alphatims.ext' has been automatically added to the distribution only
    because it may contain data files, but this behavior is likely to change
    in future versions of setuptools (and therefore is considered deprecated).

    Please make sure that 'alphatims.ext' is included as a package by using
    the `packages` configuration field or the proper discovery methods
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
    instead of `find_packages(...)`/`find:`).

    You can read more about "package discovery" and "data files" on setuptools
    documentation page.

!!

  check.warn(importable)
/Users/sebastianpaez/git/alphatims/venv/lib/python3.9/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'alphatims.img' as data is deprecated, please list it in `packages`.
    !!

    ############################
    # Package would be ignored #
    ############################
    Python recognizes 'alphatims.img' as an importable package,
    but it is not listed in the `packages` configuration of setuptools.

    'alphatims.img' has been automatically added to the distribution only
    because it may contain data files, but this behavior is likely to change
    in future versions of setuptools (and therefore is considered deprecated).

    Please make sure that 'alphatims.img' is included as a package by using
    the `packages` configuration field or the proper discovery methods
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
    instead of `find_packages(...)`/`find:`).

    You can read more about "package discovery" and "data files" on setuptools
    documentation page.

!!

  check.warn(importable)
/Users/sebastianpaez/git/alphatims/venv/lib/python3.9/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'alphatims.lib' as data is deprecated, please list it in `packages`.
    !!

    ############################
    # Package would be ignored #
    ############################
    Python recognizes 'alphatims.lib' as an importable package,
    but it is not listed in the `packages` configuration of setuptools.

    'alphatims.lib' has been automatically added to the distribution only
    because it may contain data files, but this behavior is likely to change
    in future versions of setuptools (and therefore is considered deprecated).

    Please make sure that 'alphatims.lib' is included as a package by using
    the `packages` configuration field or the proper discovery methods
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
    instead of `find_packages(...)`/`find:`).

    You can read more about "package discovery" and "data files" on setuptools
    documentation page.

!!

  check.warn(importable)
creating build/lib/alphatims/__pycache__
copying alphatims/__pycache__/__init__.cpython-39.pyc -> build/lib/alphatims/__pycache__
creating build/lib/alphatims/docs
copying alphatims/docs/cli_manual.pdf -> build/lib/alphatims/docs
copying alphatims/docs/gui_manual.pdf -> build/lib/alphatims/docs
creating build/lib/alphatims/ext
copying alphatims/ext/timsdata.dll -> build/lib/alphatims/ext
copying alphatims/ext/timsdata.so -> build/lib/alphatims/ext
creating build/lib/alphatims/img
copying alphatims/img/github.png -> build/lib/alphatims/img
copying alphatims/img/max-planck-gesellschaft.jpg -> build/lib/alphatims/img
copying alphatims/img/mpi_logo.png -> build/lib/alphatims/img
creating build/lib/alphatims/lib
copying alphatims/lib/interface_parameters.json -> build/lib/alphatims/lib
/Users/sebastianpaez/git/alphatims/venv/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
installing to build/bdist.macosx-13-arm64/wheel
running install
running install_lib
creating build/bdist.macosx-13-arm64
creating build/bdist.macosx-13-arm64/wheel
creating build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/plotting.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/tempmmap.py -> build/bdist.macosx-13-arm64/wheel/alphatims
creating build/bdist.macosx-13-arm64/wheel/alphatims/ext
copying build/lib/alphatims/ext/timsdata.so -> build/bdist.macosx-13-arm64/wheel/alphatims/ext
copying build/lib/alphatims/ext/timsdata.dll -> build/bdist.macosx-13-arm64/wheel/alphatims/ext
copying build/lib/alphatims/__init__.py -> build/bdist.macosx-13-arm64/wheel/alphatims
creating build/bdist.macosx-13-arm64/wheel/alphatims/__pycache__
copying build/lib/alphatims/__pycache__/__init__.cpython-39.pyc -> build/bdist.macosx-13-arm64/wheel/alphatims/__pycache__
creating build/bdist.macosx-13-arm64/wheel/alphatims/docs
copying build/lib/alphatims/docs/cli_manual.pdf -> build/bdist.macosx-13-arm64/wheel/alphatims/docs
copying build/lib/alphatims/docs/gui_manual.pdf -> build/bdist.macosx-13-arm64/wheel/alphatims/docs
creating build/bdist.macosx-13-arm64/wheel/alphatims/img
copying build/lib/alphatims/img/github.png -> build/bdist.macosx-13-arm64/wheel/alphatims/img
copying build/lib/alphatims/img/mpi_logo.png -> build/bdist.macosx-13-arm64/wheel/alphatims/img
copying build/lib/alphatims/img/max-planck-gesellschaft.jpg -> build/bdist.macosx-13-arm64/wheel/alphatims/img
copying build/lib/alphatims/bruker.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/cli.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/utils.py -> build/bdist.macosx-13-arm64/wheel/alphatims
creating build/bdist.macosx-13-arm64/wheel/alphatims/lib
copying build/lib/alphatims/lib/interface_parameters.json -> build/bdist.macosx-13-arm64/wheel/alphatims/lib
copying build/lib/alphatims/dia_data.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/gui.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/__main__.py -> build/bdist.macosx-13-arm64/wheel/alphatims
copying build/lib/alphatims/compiling.py -> build/bdist.macosx-13-arm64/wheel/alphatims
running install_egg_info
Copying alphatims.egg-info to build/bdist.macosx-13-arm64/wheel/alphatims-1.0.7-py3.9.egg-info
running install_scripts
creating build/bdist.macosx-13-arm64/wheel/alphatims-1.0.7.dist-info/WHEEL
creating 'dist/alphatims-1.0.7-py3-none-any.whl' and adding 'build/bdist.macosx-13-arm64/wheel' to it
adding 'alphatims/__init__.py'
adding 'alphatims/__main__.py'
adding 'alphatims/bruker.py'
adding 'alphatims/cli.py'
adding 'alphatims/compiling.py'
adding 'alphatims/dia_data.py'
adding 'alphatims/gui.py'
adding 'alphatims/plotting.py'
adding 'alphatims/tempmmap.py'
adding 'alphatims/utils.py'
adding 'alphatims/__pycache__/__init__.cpython-39.pyc'
adding 'alphatims/docs/cli_manual.pdf'
adding 'alphatims/docs/gui_manual.pdf'
adding 'alphatims/ext/timsdata.dll'
adding 'alphatims/ext/timsdata.so'
adding 'alphatims/img/github.png'
adding 'alphatims/img/max-planck-gesellschaft.jpg'
adding 'alphatims/img/mpi_logo.png'
adding 'alphatims/lib/interface_parameters.json'
adding 'alphatims-1.0.7.dist-info/LICENSE-THIRD-PARTY.txt'
adding 'alphatims-1.0.7.dist-info/LICENSE.txt'
adding 'alphatims-1.0.7.dist-info/METADATA'
adding 'alphatims-1.0.7.dist-info/WHEEL'
adding 'alphatims-1.0.7.dist-info/entry_points.txt'
adding 'alphatims-1.0.7.dist-info/top_level.txt'
adding 'alphatims-1.0.7.dist-info/RECORD'
removing build/bdist.macosx-13-arm64/wheel

$ ls dist
alphatims-1.0.7-py3-none-any.whl

Docker is outside of my comfort zone. Merged your fix with including wheel and the gh action now runs through. Not sure how to test it without a proper windows machine though;). Let me know if this works for you!

Hello again! Sorry for bother you so much on this regard ...
The only missing thing would be to make the package public (the built image that is stored in GitHub). Since it seems like everything is passing correctly but I do not have visibility on the image (attaching a couple of screenshots on the visibility RN for me).
Screenshot of what I currently see from the alphatims gh repo:

Reference screenshot of what I would expect to see on a repo with a public package:

link to the package itself: https://github.com/TalusBio/flimsay/pkgs/container/flimsay
https://docs.github.com/en/packages/learn-github-packages/configuring-a-packages-access-control-and-visibility


Improve LIKE error message

Situation
When using LIKE on any other column than SOURCE_REFERENCE,  users get the following error message:

F-VSD-5: The current version of virtual-schemas does not support LIKE and NOT LIKE as post-selection. Please change your query.

While technically true, that error message is confusing. What it should do instead is:

State that LIKE is only supported on the SOURCE_REFERENCE column.
Explain why (efficiency)
Explain what users can do to mitigate the situation (wrap in a super-select that does the LIKE)

Hmm... as the adapter should know it is creating SQL for Exasol... can it not simply wrap itself into a
select * from ( import ) where <LIKE>

?

No. That would require an SQL engine in the adapter.


Transport.queue spams log when queue is full

In a busy application, the agent-internal event queue may fill up frequently, which will lead to events being dropped. We currently log a warning every time this occurs, which may lead to spamming the logs.
Ideally, the agent would keep a record of the number of events dropped, and periodically report this as a metric to the server, and logging would no longer be needed. In the meantime, we should at least throttle this log message to prevent filling up the logs.

Related to this, if the queue fills up is there a way to drain/purge it?

Turns out this is solved by adding more threads to gunicorn.

@axw Implementing throttling would probably need quite a bit of work, how about changing the log level from WARNING to INFO or DEBUG for now?
But to be honest, I'm not even sure that's a good idea. In normal operation, this should almost never happen. I think it's OK to be somewhat noisy if things are failing so badly that the queue is spilling over constantly.
Regarding metrics: yes, it makes sense to track this as a metric, but it's not a replacement for logging the error, as the metrics themselves would use the same queue and also be lost in a situation like this.
@fxdgear I'm still a bit confused why adding threads helped in your situation. Threads in the same process use the same queue, so in my mind it should have made the problem worse, not better. Sometimes I hate computers...

@axw Implementing throttling would probably need quite a bit of work, how about changing the log level from WARNING to INFO or DEBUG for now?

I think making it DEBUG would be OK for now.

But to be honest, I'm not even sure that's a good idea. In normal operation, this should almost never happen. I think it's OK to be somewhat noisy if things are failing so badly that the queue is spilling over constantly.

The definition of "normal operation" will depend on the application. There will be applications where the load is always more than the agent can handle, so in that case it's normal for events to be dropped.
You could argue that the user should just decrease the sampling rate, but spamming logs can be pretty detrimental to performance, mostly due to I/O. For a busy application, that might be problematic.

Regarding metrics: yes, it makes sense to track this as a metric, but it's not a replacement for logging the error, as the metrics themselves would use the same queue and also be lost in a situation like this.

I would consider that a bug.

Truer words have never been spoken!

TBH I’m not sure why adding threads helped.
I also increased the mem limit on my container from 200 to 500mb
I also switched from sync workers to gevent async workers.
But, it’s been over 24hr and I can’t remember if those changes were all at once or one at a time.
I do remember that once I hit my mem limit on the container that’s when I started getting spammed with those queue full messages. So I chased a memory leak theory in gunicorn for a bit as well.


Star Flag

So i did my project with Javascript for the coming up
anniversary where Somalia declared independendce from Italy in the 1. of July 1960.

Thanks for the submission! I think this needs a bit more sophistication to earn a Blot but please resubmit when you are ready.


error: unknown argument: --vad-start-thold

branch: master
OS: Ubuntu Server 22.04
Compilers:  gcc 11.4.0 and g++ 11.4.0

I tried compiling your code. I was able to generate talk-llama, downloaded your script talk-llama.bat, but when I run it I get the following error continued by instructions on how to use talk-llama :
error: unknown argument: --vad-start-thold

usage: ./talk-llama [options]

options:
  -h,       --help           [default] show this help message and exit
  -t N,     --threads N      [4      ] number of threads to use during computation
  -vms N,   --voice-ms N     [10000  ] voice duration in milliseconds
  -c ID,    --capture ID     [-1     ] capture device ID
  -mt N,    --max-tokens N   [32     ] maximum number of tokens per audio chunk
  -ac N,    --audio-ctx N    [0      ] audio context size (0 - all)
  -ngl N,   --n-gpu-layers N [999    ] number of layers to store in VRAM
  -vth N,   --vad-thold N    [0.60   ] voice activity detection threshold
  -vlm N,   --vad-last-ms N  [500    ] vad min silence after speech, ms
  -fth N,   --freq-thold N   [100.00 ] high-pass frequency cutoff
  -su,      --speed-up       [false  ] speed up audio by x2 (reduced accuracy)
  -tr,      --translate      [false  ] translate from source language to english
  -ps,      --print-special  [false  ] print special tokens
  -pe,      --print-energy   [false  ] print sound energy (for debugging)
  -vp,      --verbose-prompt [false  ] print prompt at start
  -ng,      --no-gpu         [false  ] disable GPU
  -p NAME,  --person NAME    [Alex   ] person name (for prompt selection)
  -bn NAME, --bot-name NAME  [LLaMA  ] bot name (to display)
  -w TEXT,  --wake-command T [       ] wake-up command to listen for
  -ho TEXT, --heard-ok TEXT  [       ] said by TTS before generating reply
  -l LANG,  --language LANG  [en     ] spoken language
  -mw FILE, --model-whisper  [./ggml-medium.en-q5_0.bin] whisper model file
  -ml FILE, --model-llama    [./mistral-7b-instruct-v0.2.Q6_K.gguf] llama model file
  -s FILE,  --speak TEXT     [speak  ] command for TTS
  --prompt-file FNAME        [       ] file with custom prompt to start dialog
  --session FNAME                   file to cache model state in (may be large!) (default: none)
  -f FNAME, --file FNAME     [       ] text output file name
   --ctx_size N              [2048   ] Size of the prompt context
  -n N, --n_predict N        [64     ] Number of tokens to predict
  --temp N                   [0.90   ] Temperature
  --top_k N                  [40.00  ] top_k
  --top_p N                  [1.00   ] top_p
  --repeat_penalty N         [1.10   ] repeat_penalty
  --xtts-voice NAME          [emma_1 ] xtts voice without .wav
  --xtts-url TEXT            [http://localhost:8020/] xtts/silero server URL, with trailing slash
  --xtts-control-path FNAME  [./talk-llama-fast/xtts/xtts_play_allowed.txt] path to xtts_play_allowed.txt  --google-url TEXT          [http://localhost:8003/] langchain google-serper server URL, with /

Have you used a branch that you haven't pushed yet to build the demo version? If not, can you tell me what is it that I am missing?

oops, i forgot to upload recent code changes. Now fixed. Just git pull or manually download https://github.com/Mozer/talk-llama-fast/blob/master/examples/talk-llama/talk-llama.cpp

There is clearly --vad-start-thold now in https://github.com/Mozer/talk-llama-fast/blob/master/examples/talk-llama/talk-llama.cpp
Before that it wasn't there. Maybe some weird cache you have. Anyway you can just remove that param from bat file.


Alloww for chart dimension to be selectable

Only show top 10 categories (+Other) in chart
Description
Allows for the report dimension to be selected from any of the "standard" dimensions
Changes the chart to only show the top 10 values with all other data grouped into "Other" (like the UI does)
Issues Resolved
N/A
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

          2 Errors

:no_entry_sign:
Please add a changelog

:no_entry_sign:
Please add labels to this Pull Request

          1 Warning

:warning:
Should this include readme changes

  Generated by :no_entry_sign: Danger


⚠ Bofrost.be has degraded performance

In 5217709, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1040 ms

Resolved: Bofrost.be performance has improved in 82fb222.


Planify fonts invisible

Describe the bug
Unable to read any text in the Planify pkg GUI
Steps To Reproduce
Steps to reproduce the behavior:

install Planify using configuration.nix
open planify
...

Expected behavior
Be able to read text in app
Screenshots

Additional context
Add any other context about the problem here.
Notify maintainers
@dtzWill @davidak @bobby285271

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 6.1.77, NixOS, 23.11 (Tapir), 23.11.4248.01885a071465
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.1
channels(root): "nixos-23.11"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

---

Add a :+1: [reaction] to [issues you find important].

[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[issues you find important]: https://github.com/NixOS/nixpkgs/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc

A backport probably helps, please test the above PR.

Merged the above PR: https://nixpk.gs/pr-tracker.html?pr=288964


Rest API endpoints are not available after 4.1 update

http://hassio:40860/api/apikey/sensors
is not available anymore.
I use some put requests to configure the duration of my motion sensors. I guess the ingress support has something to do with this.

Duplicate of #931 and #926, extensively discussed in #926
Please make sure to check for existing issues before creating a new one, thanks! 👍


Add a dockerized kafka for running tests

It was not obvious how to run tests before this. This patch adds a
simple docker setup so you can run tests without manually setting up
kafka.
Currently some of the zookeeper tests fail, but putting the pull request forward to see if the maintainers would be amenable to this change.

That sounds good, I will look into it. thanks!

fig is now renamed to docker-compose. fig.yml should be renamed to docker-comopse.yml and the command fig should be changed to docker-compose.

+1

See my #387.


Add a "Copy to Clipboard" button to copy quotes

Add a button that allows users to copy the displayed quote to their clipboard. This will make it easier for users to share the quotes.

Can I work on this issue ?

Sure. How would you go about it?

One way I can do it is with a button next to the quote field.On click of the button I can handle the event by taking the data from the quote field and putting it in the clipboard.

Ok, fire on 🔥

@DanonymousCoder is there some work left in this issue ?


Execute k8s deployments from an rke2 server node

K8s roles using the kubernetes.core.k8s modules are now delegated to the primary rke2 server. The advantages are that the controller host doesn't have to download the kubeconfig file anymore and it doesn't need to have Ubuntu.

There is a "risky file permissions" warning by the linter. Can we get rid of that? Apart from that this looks ok.

That's from the other pull request, it's already fixed.


how to set image default

@zozeei  Can you please provide some more details about this?

@zozeei  Can you please provide some more details about this?

#25 Looks like same problem.


Duplicates in export json

Describe the bug
For an object detection task, if the Total annotations per task is more than 1 then the export json contains duplicates for all the tasks. The expected number of annotations if the Total annotations per task is n would be n but the json contains 2*n items and each of them will have all the annotations.
To Reproduce
Steps to reproduce the behavior:

Create a new project.
Update the labeling interface using the Object Detection template
Import new file/files
Open an image to annotate.
Draw one or more bounding boxes and click Submit
Click Create Copy
Optional: Update the annotations. (It's easier to see the duplicates if the values are different)
Click Submit again
Click Export and export as JSON.

The exported JSON file will have a list with 2 objects and both of them are exactly the same. The annotations also contain two objects which correspond to the two copies created above.
Expected behavior
The exported JSON should not contain any duplicates. Either the two main objects should be different with each corresponding to the copy of the image or there should be only one object with annotations containing the details about the copies.
Screenshots

Environment (please complete the following information):

OS: Ubuntu 20.04
Label Studio Version: 1.1.0

{
  "label-studio-os-package": {
    "version": "1.1.0",
    "short_version": "1.1",
    "latest_version_from_pypi": "1.1.0",
    "latest_version_upload_time": "2021-06-30T22:55:06",
    "current_version_is_outdated": false
  },

  "label-studio-os-backend": {
    "message": "1.1 doc updates (#1110)",
    "commit": "536f604d066958ebb00a4f36aed7aed395250dce",
    "date": "2021-06-30 15:44:26 -0700",
    "branch": "master",
    "version": "1.0.2+76.g536f604d"
  },

  "release": "1.1.0",
  "label-studio-frontend": {
    "message": "Improve Labels styles",
    "commit": "5a34b62e57653484bb5d9924cfd821a7b81de996",
    "branch": "master",
    "date": "2021-06-30T20:10:42Z"
  },

  "dm2": {
    "message": "Don't close QuickView by Enter",
    "commit": "d12a691d1e941768c3067ccb15abe5498f8a453b",
    "branch": "master",
    "date": "2021-06-30T16:06:22Z"
  },

  "label-studio-converter": {
    "version": "0.0.29"
  },

  "label-studio-ml": {
    "version": "1.0.0"
  }
}

Additional context
I found duplicates in JSON and COCO exports. Also, I tested only object detection but this might be a general issue with export.

@HarshSharma12 This has been fixed in version 1.1.1. Thanks!


Add Replicate demo and API

Hey @phizaz! 👋
This pull request makes it possible to run your model inside a Docker environment, which makes it easier for other people to run it.  We're using an open source tool called Cog to make this process easier.
This also means we can make a web page where other people can run your model! Vew it here: https://replicate.com/cjwbw/diffae
Replicate also have an API, so people can easily run your model from their code:
import replicate
model = replicate.models.get("cjwbw/diffae")
model.predict(image="...")

If you'd like to modify the Replicate page (e.g. Example Gallery), let me know and I can transfer ownership to your account.
In case you're wondering who I am, I'm from Replicate, where we're trying to make machine learning reproducible. We got frustrated that we couldn't run all the really interesting ML work being done. So, we're going round implementing models we like. 😊

This is so cool! Thank you 🤗


Could not create query for public abstract net.lecousin.reactive.data.relational.LcReactiveDataRelationalClient net.lecousin.reactive.data.relational.repository.LcR2dbcRepository.getLcClient()

I have got the error when build my application using lc-spring-data-r2dbc
Could not create query for public abstract net.lecousin.reactive.data.relational.LcReactiveDataRelationalClient net.lecousin.reactive.data.relational.repository.LcR2dbcRepository.getLcClient(); Reason: Failed to create query for method public abstract net.lecousin.reactive.data.relational.LcReactiveDataRelationalClient net.lecousin.reactive.data.relational.repository.LcR2dbcRepository.getLcClient(); No property 'getLcClient' found for type 'LcReactiveDataRelationalClient'
My repository is configured as follows
public interface DscUserRepository extends LcR2dbcRepository<DscUser, UUID> {

}

Could you please check the problem? Many thanks!

@lecousin could you help me check it?


Compilation errors with OpenUI5/SAPUI5 1.54+

Hi,
I tried https://github.com/cevou/openui5-sample-app. It works fine with UI5 1.52. However, I ran into several issues in UI5 1.54 and 1.56. I was able to get it running by twisting the UI5 source code a little. But it is of course not a solution. Please suggest a solution for this issue.
I will explain the issues I encountered as follows. jquery.sap.global has changed in 1.54 to use sap.ui.define. Several imports in openui5-sample-app are no longer required.
sap.ui.define([
	// new sap/base/* modules
	"sap/base/util/now",
	"sap/base/util/getObject", "sap/base/util/getter", "sap/base/Version",
	"sap/base/util/extend", "sap/base/assert", "sap/base/log",
	// new sap/ui/* modules
	"sap/ui/Configuration", "sap/ui/dom/appendHead", "sap/ui/dom/computedStylePolyfill", "sap/ui/dom/activeElementFix", "sap/ui/dom/includeScript",
	"sap/ui/dom/includeStylesheet", "sap/ui/initjQuerySupport", "sap/ui/initSupportHooks", "sap/ui/initjQueryBrowser",
	"sap/ui/security/FrameOptions", "sap/ui/performance/Measurement", "sap/ui/performance/Interaction", "sap/ui/performance/ResourceTimings",
	"sap/ui/bootstrap/StoredConfig", "sap/ui/SyncPoint", "sap/ui/XHRProxy",
	// former sap-ui-core.js dependencies
	"sap/ui/Device", "sap/ui/thirdparty/URI",
	"sap/ui/thirdparty/jquery",
	"sap/ui/thirdparty/jqueryui/jquery-ui-position",
	"ui5loader-autoconfig"
], function(now, getObject, getter, Version, extend, assert, log,
     Configuration, appendHead, computedStylePolyfill, activeElementFix, includeScript,
     includeStylesheet, initjQuerySupport, initSupportHooks, initjQueryBrowser,
     FrameOptions, Measurement, Interaction, ResourceTimings,
     StoredConfig, SyncPoint, XHRProxy,
     Device, URI,
     jQuery/*, jqueryUiPosition, ui5loaderAutoconfig*/) {
     .......
}

Based on the order of issues I ran into, the major changes that cause the problems are listed below:

A new dependency ui5loaderAutoconfig. I added two import statements to solve this problem.

import "ui5loader";
import "ui5loader-autoconfig";

In addition, ui5loaderAutoconfig validates baseURL by checking the global scope window['sap-ui-config'].
window["sap-ui-config"] = {
      theme: "sap_belize",
      bindingSyntax: "complex",
      compatVersion: "edge",
      resourceRoots: {
        '': 'resources/'
      }
    };

In the main function of jquery.sap.global, the following throws cannot access jquery of undefinied (i..e fn is undefined). I debugged into this line, the problem is jQuery is evaluated to empty object "{}". I haven't got time to investigate why jQuery is not evalued to "sap/ui/thirdparty/jquery", since Device, URI, and other dependencies are evaluated successfully.

var oJQVersion = Version(jQuery.fn.jquery);

To temporarily remove this runtime error, I import "jquery.sap.global-dbg" instead. In the -dbg version, I commented out the jQuery parameter and instead usingjQuery that has been instantiated in global scope through script-loader. See the changes I made below.
sap.ui.define([
	......
	// former sap-ui-core.js dependencies
	"sap/ui/Device", "sap/ui/thirdparty/URI",
	"sap/ui/thirdparty/jquery",
	"sap/ui/thirdparty/jqueryui/jquery-ui-position",
	"ui5loader-autoconfig"
], function(now, getObject, getter, Version, extend, assert, log,
     ......
     Device, URI/*,
     jQuery, jqueryUiPosition, ui5loaderAutoconfig*/) {
     .......
}

Similarly, I referred to "sap/ui/initjQuerySupport-dbg" instead of "sap/ui/initjQuerySupport" in jquery-sap-global, and removed the jQuery passed to the main function in sap.ui.define for initjQuerySupport.

Please kindly help on these issues.

Hi @shen-lin,
I just updated the sample project yesterday. It's true there were some changes to make. After the update, I also replaced the bower_components with the new UI5 libraries from NPM.
Can you check if it works for you?

Hi @cevou,
Thanks for your answering! I had a look at your changes in openui5-sample-app, but haven't got chance to test it yet.
The changes you made might not be backward compatible with older UI5 versions. You might want to create branches for each sample app for multiple UI5 versions.
Thanks,
Shen

I don't think that I will keep different versions of the sample app. My plan is to have the sample app always up to date with the latest UI5 version. I might add some tags to commits with certain UI5 versions.

Hi @cevou
Tag would be good enough. The latest sample app works fine with OpenUI5 1.56. I still have an error when adopting the sample app for SAPUI5 1.56. I will let you know if I can't fix it. I am closing this issue now.


Add Hijri calendar example

This PR closes #714

Moved both jalaali and hijri in single page.

No more comments. Waiting CI to pas. Sorry for requesting changes last time

No more comments. Waiting CI to pas. Sorry for requesting changes last time

No problem :) Thanks for your work!

Ohh. Just wired thing with headers and displaying https://share.icloud.com/photos/0ElVl0dcKx2ifbHWT0iht5Jhw

Ohh. Just wired thing with headers and displaying https://share.icloud.com/photos/0ElVl0dcKx2ifbHWT0iht5Jhw

I think headers look better now


Empty subscriptions should be an empty array

If an app doesn't have any subscriptions, it should return an empty array and not an empty response.

This is fixed