test storage::test_raft_storage::test_auto_gc panic

Bug Report
What version of TiKV are you using?
Commit: 995257ddb1c926cfce638663b66c92809064eedd
What operating system and CPU are you using?
MacOSX
What did you do?
make dev

What did you expect to see?
Test passed
What did you see instead?
thread 'storage::test_raft_storage::test_auto_gc' panicked at 'assertion failed: value.is_none()', tests/integrations/storage/test_raft_storage.rs:242:13
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /Users/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.29/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /Users/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.29/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:47
   3: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:36
   4: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:198
   5: std::panicking::default_hook
             at src/libstd/panicking.rs:212
   6: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:475
   7: <alloc::collections::CollectionAllocErr as core::convert::From<core::alloc::AllocErr>>::from
   8: integrations::storage::test_raft_storage::check_data
             at tests/integrations/storage/test_raft_storage.rs:242
   9: integrations::storage::test_raft_storage::test_auto_gc
             at tests/integrations/storage/test_raft_storage.rs:349
  10: integrations::storage::test_raft_storage::test_auto_gc::{{closure}}
             at tests/integrations/storage/test_raft_storage.rs:248
  11: core::ops::function::FnOnce::call_once
             at /rustc/0e4a56b4b04ea98bb16caada30cb2418dd06e250/src/libcore/ops/function.rs:231
  12: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once
             at /rustc/0e4a56b4b04ea98bb16caada30cb2418dd06e250/src/liballoc/boxed.rs:746
  13: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:82
  14: std::panicking::try
             at /rustc/0e4a56b4b04ea98bb16caada30cb2418dd06e250/src/libstd/panicking.rs:273
  15: std::panic::catch_unwind
             at /rustc/0e4a56b4b04ea98bb16caada30cb2418dd06e250/src/libstd/panic.rs:388
  16: test::run_test::run_test_inner::{{closure}}
             at src/libtest/lib.rs:1466
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Is there any log?

https://github.com/tikv/tikv/pull/5212 is trying to fix this.


[ fix ] Necessary changes for PR #2816

Note that I haven't checked that the output of the REPL commands in the Doc modules is still valid after this update.

I've checked everything with pack build elab-util && pack build elab-util-docs && pack test elab-util with compiler version at the upstream PR and all worked. I can merge it now as soon as the upstream PR would be merged today (as usual, to not to create a bad night build).

Happy to merge today

By the way, output of REPL in docs doesn't change because of implementation of Pretty (Maybe a) which uses pretty of Pretty a in the Just case O_O

Thanks for this. I'm in the process of using new pretty printers and ditching the dependency on contrib, so I'll have to recheck the REPL output anyway.


Nick: Watch Rajatogel(?!.vzy.io(?<=rajatogel.vzy.io))

Nick requests the watch of the watch_keyword Rajatogel(?!\.vzy\.io(?<=rajatogel\.vzy\.io)). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Rajatogel(?!\.vzy\.io(?<=rajatogel\.vzy\.io)) has been seen in 3 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Check for tuture.yml syntax

This procedure should be carried out before tuture up. In addition, a CLI command for this is also needed (maybe tuture check?).

Closed via #99.


Drop extra spaces

MP: wherehows-frontend
TO_COMMIT: 91bd2f50851c612d667c8265c1e788dc0edf8de4
FROM_COMMIT: 23999624d62fbeeff0fde1b66b92dceb52f1611c

Coverage remained the same at 22.946% when pulling 4878087a52f7eac68be7c36b42ff36d9e08ec89b on linkedin/malan/wherehows-frontend into 936f1147c528720b91f7906827e16bd113ebcabd on master.

travis build failed?

Codecov Report

Merging #1440 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1440   +/-   ##
=======================================
  Coverage   61.36%   61.36%
=======================================
  Files         187      187
  Lines        4066     4066
  Branches      949      949
=======================================
  Hits         2495     2495
  Misses       1571     1571

Impacted Files
Coverage Δ

wherehows-web/app/utils/api/datasets/schema.ts
83.33% <0%> (-16.67%)
:arrow_down:

wherehows-web/app/utils/api/datasets/compliance.ts
70.27% <0%> (-8.11%)
:arrow_down:

wherehows-web/app/components/purge-policy.ts
96.29% <0%> (+14.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 936f114...dcd7646. Read the comment docs.


Color Game using Tkinter

Aim
To make a tricky and interesting Color game using Tkinter with a GUI.
Details
In this game, the player has to enter the color of the word that appears on the screen. he game uses a variety of colors such as Red, Blue, Green, Pink, Black, Yellow, Orange, White, Purple, and Brown. These colors are interchangeably displayed to trick the player’s mind. The graphical user interface (GUI) will display the name of different colors in different colors.
@avinashkranjan I am a GSSoC'21 participant and I think this is an interesting python script of GUI domain. Kindly allow me to work on this issue and contribute to this project!

@PriyanshuChatterjee assigned to you


bors: update configuration

we require 2 reviewers
we do not want merge commits
clippy in a PR must always pass before we stage it

Not 100% sure yet if this is is final but I think it is.
!!!
Below here things are ignored CAS-1

bors r+

bors try


[FEATURE] Integrate a Chatbot for Instant User Support

Is your feature request related to a problem? Please describe.
Enhance the website's user experience by integrating a chatbot that provides instant answers to user inquiries. The chatbot should be easily accessible, provide relevant responses, and offer seamless assistance for common queries, improving user engagement and support.
Describe the solution you'd like
Add a chatbot icon or button that floats on the bottom-right corner of the site.
When clicked, the chatbot window should expand with a smooth animation, displaying an input field and previous chat history.
The chatbot should respond to frequently asked questions (related to the FAQ section) and common inquiries about products or services.
Implement a fallback response for questions outside the chatbot's scope (e.g., "Sorry, I don't have an answer for that. Please contact our support team.").
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
@Vishwajith-Shettigar please assign this to me under gssoc-ext and hacktoberfest

I would like  to work on this project . Can you assign it to  me.


[Swift 4.2] Updated Selection Sort

The code worked fine in Xcode 10. I removed code snippet at the top of playground file and fixed error in SelectionSort.swift

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description

PR related to #748

Thanks for the update 😄


nitdoc: does not apply header style to span elements anymore.

Fixes #1108
Signed-off-by: Alexandre Terrasa<EMAIL_ADDRESS>

+1 but does it still decorate bold and monospace text?

Yup,
Demo will be ready soon (http://gresil.org/jenkins/job/CI-nitdoc/).

+1


Add reference syntax highlighting grammar

Myst is designed to be CommonMark compliant, therefore standard Markdown syntax highlighters will work with Myst and handle the common syntaxes. However, it would be desired to have an 'extended' syntax highlighter, to cover the additional syntax introduced by Myst.
The de facto standard for syntax grammar is the TextMate grammar file, with support in Eclipse, Atom, VSCode, Sublime, etc (jupyterlab/jupyterlab#5504 also discusses their potential incorporation). Therefore, it would be good to have a reference implementation (tested somehow?) in this package.
Here are some helpful links:

https://www.apeth.com/nonblog/stories/textmatebundle.html
https://benparizek.com/notebook/notes-on-how-to-create-a-language-grammar-and-custom-theme-for-a-textmate-bundle
https://medium.com/@model_train/creating-universal-syntax-highlighters-with-iro-549501698fd2

It should also be considered whether the specific syntaxes discussed in ExecutableBookProject/sphinx-notebook#12 would be incorporated here. For example with:
```{execute} python
print('hi')
```

It would be desired that the block content was syntax highlighted as python code.
Perhaps there could be a script that auto-generated grammar files with additional highlighting of desired directives.

I think it sounds useful - how is this different from the LSP stuff?
Is the idea that the textmate grammar file would be the "official" reference implementation, then?

how is this different from the LSP stuff?

This is essentially a pre-cursor to a full LSP. LSP uses TextMate bundles for static syntax highlighting (there's actually no way yet to do it dynamically microsoft/language-server-protocol#18). The LSP then builds on this to add dynamic stuff like outlines, auto-completion, linting, etc.

Is the idea that the textmate grammar file would be the "official" reference implementation, then?

Yep, then it could be used by editor specific extension packages, like for VS Code or Jupyter Lab (hopefully).


Custom scrollbar

Here I suggest an improvemente on scrollbar.
Here I change some padding-top/margin-top values to avoid overlap
between the topbar and editor, and have full height of editor box.
And I install SimpleBar package to customize scrollbar.

Beautiful, thanks for adding this @phosph


Accounts for when the target has been destroyed

I hope this helps. By allowing find_target to return the path (or in this case, the name) of the node, we can continuously find the node in physics_process and work around what happens if the target is destroyed before the rocket terminates. In that case, the rocket will now look for the next-closest target. If none is found, it will just fly straight.

This makes sense! I initially was having issues understanding, but this visual allows me to connect the concepts with the code. Thank you so much!


Allow expanding dotenv with dotenv-expand

Allow expanding dotenv

Thanks. This will solve allot problems

I thank you for the idea 🙇 :)

Thanks for the the nice tool


Gracefully handle multiple ":status" headers

The server should never return multiple ":status" header values, but
if it does happen, we should abort the response rather than crash.
This seems better than arbitrariliy choosing the first value and
continuing on.

+2


Experiment Should Use Elapsed Time Reported by KLEE

This is for when generating experiment.csv for both coreutils/Makefile and scalability/Makefile. Currently they are using the output of time utility which may be less reliable. KLEE's elapsed time is reported in <program_name>.klee?/info or <program_name>.tracerx?/info.

Resolved via 2a670f6f453abc3bd5ac0f0691a2a5c80d12e555, where elapsed time from info file is added to a colum in the experimental table.


Update readme file

Release note:

NONE

@wattli: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/auth-presubmit.sh
394d204f8c2e19cbc16e46896fc7e63778d30262
link
/test auth-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I think our integration test fails. I'm trying to fix it.

/lgtm
/approve


Update 2.mdx, Fix errors in translation

Description
Hello, I am Mengke. When I was learning Astro, I found a mistake in the zh-cn documentation.

Corrected ../layouts to layouts
Corrected pubDate: to pubDate
Corrected .author to author

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

zh-cn
tutorial/4-layouts/2.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


transactions/trade: Add SignedTradeOffer Closes #98

Like mentioned in the original issue, the idea was to ultimately improve the type safety in the backend server. For the trading API, trade offers are saved into a mapping of TradeOffers. Then when a trade offer is executed, it it currently asserted that the offer has a sig. Please check if this can be improved, so that incoming trade offers are checked for non-nil sigs and then saved into a mapping of SignedTradeOffers.


Add “offline” spec validations in the validate command (optional flag)

When using the bump validate command it could make sense to add a --strict flag to enable OpenAPI/AsyncAPI spec verification.

For OpenAPI we could use

The Mermade developed/maintained oas-validator library
The AsyncAPI community maintained library @asyncapi/openapi-schema-parser

For AsyncAPI we could use the “official” community developed library @asyncapi/parser

We should probably use https://github.com/stoplightio/spectral to delegate validation to the formal specs directly

Remember there's more than just "linting YAML" or "linting OpenAPI", using some of these rulesets moves you into API Security testing and compliance.
https://github.com/stoplightio/spectral-rulesets
And you move into API Governance if custom rulesets are being used:
https://apisyouwonthate.com/blog/automated-style-guides-for-rest-graphql-grpc/


[core-lro] Prepare release

Release the addition of resolveOnUnsuccessful flag today.
API View

API change check
API changes are not detected in this pull request.


perf(hydration): supports tree shaking of code in dev environments.

supports tree shaking of code in dev environments.

This doesn't seem necessary - when __DEV__ is false most bundlers can already treeshake the function call after it.


UART demo with USB CH340N

https://www.amazon.com/JESSINIE-Serial-CH340N-Upgrade-Download/dp/B0CLD1THZ1

Says it can do 2M baud: https://aitendo3.sakura.ne.jp/aitendo_data/product_img/ic/inteface/CH340N/ch340n.pdf
Need to test / verify

Probably do https://github.com/vkottler/homestead/issues/2 first.


react/no-unknown-property: invalid property download found on tag

The react/no-unknown-property rule reports thedownload property of <a> tag as invalid.

This was fixed by #3394, and is a duplicate of #3399.


fix: fixing fallback to check local dir for asyncapi file before context e…

Description
A fix for #127 it now will check the file directory before finally checking the context again (and throwing errors).

This would be a big decision, as the overall functionality would change, I think we need to ask @derberg and @fmvilas for this. Because when we decided on the order of the fallback we agreed on this because the functionality was for the power users who would want to be using the current context if he has spent time setting it up.

ah OK.
if (filePathOrContextName) {
    const type = await nameType(filePathOrContextName);
    if (type === TYPE_CONTEXT_NAME) {
      return loadFromContext(filePathOrContextName);
    }
    await fileExists(filePathOrContextName);
    return new SpecificationFile(filePathOrContextName);
  }

Isn't this the part that would check the context? Happens before the fallback?
Or are you talking about the users that setup context, but don't pass in the filepath or context name?

That path figures out what that input is. Is the input a file path or a context name this does not run as we are not passing any input as the command is asyncapi start studio

Yeah, this same bug hit me during my QCon presentation. I typed asyncapi start studio and it complained there wasn't any context but I had a file in the current working directory. I think this should change.

Thanks, @derberg.

there is come console.log in code

😅👀 let's pretend you didn't see anything 😂

make sure PR title follows imperative mode. Anyway title also needs review to reflect implementation

Do you mean imperative mood? The first time I heard of this, can you give an example of what you would expect? I changed it, let me know what you think :).

context is still important, it is just that in case of no default context, there should not be an error like we get now, but the fallback mechanism should work further and in the end, the file from root should be picked

OK makes sense. I changed the flow so now will check context, if that fails it will then try and read the local dir for any files. Is this what you mean?

let's pretend you didn't see anything

see what?

Do you mean imperative mood

yes 😅 basically follow https://chris.beams.io/posts/git-commit/#imperative so we stay consistent and we don't get one commit like adding..... and right after add...... Best would be imho feat: set fallback to read local dir for asyncapi file if no context is present.  It is of any command and also rather improvement and not fix. What do you think?

OK makes sense. I changed the flow so now will check context, if that fails it will then try and read the local dir for any files. Is this what you mean?

yup, exactly

chris.beams.io/posts/git-commit/#imperative

Thanks, @derberg this is great and helps loads! I will amend the title 🙇

We still have the problem of course that if no local file is present then ContextError: No context is set as current, please set a current context. is shown.

If no file is present in the working directory and also there is no current context set, then ContextError: No context is set as current, please set a current context. will be thrown, also now it is picking the asyncAPI file from the working directory if there is any, thanks to @boyney123  so I think this problem is solved.

But I think there is a bigger problem with how we are passing errors, as so far I see https://github.com/asyncapi/cli/blob/master/src/errors/validation-error.ts#L19 will never get called even if I do asyncapi validate without context or local file

Yeah, this is not something that is supposed to happen. Ok so let me write about the issue in more details:
So when I run asyncapi validate and there is no file in the working directory and no current context is set, previously it threw no-spec-found error which had a message like this -
Unable to perform validation. Specify what AsyncAPI file should be validated.
These are your options to specify in the CLI what AsyncAPI file should be used:
  - You can provide a path to the AsyncAPI file: asyncapi validate path/to/file/asyncapi.yml
  - You can also pass a saved context that points to your AsyncAPI file: asyncapi validate mycontext
  - In case you did not specify a context that you want to use, the CLI checks if there is a default context and uses it. To set default context run: asyncapi context use mycontext
  - In case you did not provide any reference to AsyncAPI file and there is no default context, the CLI detects if in your current working directory you have files like asyncapi.json, asyncapi.yaml, asyncapi.yml. Just rename your file accordingly.

But now this message never gets printed, and instead of this we have a error message like this
ContextError: No context is set as current, please set a current context.

This error is getting thrown here:
https://github.com/asyncapi/cli/blob/b9cc9388d0aac81caa8d5bd9322b4c430127cb53/src/models/SpecificationFile.ts#L43
When we do not find any current context we are throwing SpecificationFileNotFound error.

@derberg I think we should open a new issue for this.

@Souvikns yeah, definitely a separate issue, created it here https://github.com/asyncapi/cli/issues/148
@boyney123 just update with latest master and we get that one merged 🥳

Cool thanks @derberg @Souvikns
All updated, good to go 👍


[TASK] Super events search query needs to filter sub events based on date

Describe the bug
Currently the super events search query (?superEventId=<super event ID>) when combined with date search query options are not filtering sub events based on those dates. Now that we have new date query filters, it needs to be used to filter out sub events. This is related to https://github.com/rokwire/illinois-app/issues/161.
To Reproduce
Steps to reproduce the behavior:

GET: https://api.rokwire.illinois.edu?superEventId=5f7dffe87a5461000759c848&startDate.lte=2020-11-12T07:32:43&endDate.gte=2020-11-06T07:32:43
See results:

[
  {
    "allDay": false,
    "category": "Other",
    "contacts": [
      {
        "email"<EMAIL_ADDRESS>        "organization": "University Housing",
        "phone": "+12173337111"
      }
    ],
    "cost": "",
    "createdBy"<EMAIL_ADDRESS>    "endDate": "Thu, 16 Apr 2020 14:59:00 GMT",
    "id": "5f80793c1b0b03000a25e91c",
    "imageURL": "https://api.rokwire.illinois.edu/events/5f7f45fd5c55e182abaafbbb/images/5f91d27cdf5b8c5b4eb8b253",
    "isSuperEvent": false,
    "isVirtual": true,
    "location": {
      "description": "University of Illinois",
      "latitude": 40.1019523,
      "longitude": -88.2271615
    },
    "longDescription": " Housing Sign-Up 2021-2022 is open to all Illini November 16-April 15. Are you an off-campus student who wishes to return to the ease of the residence halls? Sign up to choose any available space in the undergraduate or graduate residence halls. Click the link below to get started! ",
    "name": "",
    "sponsor": "University Housing ",
    "startDate": "Mon, 16 Nov 2020 19:00:00 GMT",
    "subEvents": [

    ],
    "subcategory": "",
    "tags": [

    ],
    "targetAudience": [

    ],
    "title": "University Housing Sign-Up All Illini Phase ",
    "titleURL": "https://housing.illinois.edu/signup",
    "rokwire_score": 1.4
  },
  {
    "allDay": false,
    "category": "Other",
    "contacts": [
      {
        "email"<EMAIL_ADDRESS>        "organization": "University Housing",
        "phone": "2173337111"
      }
    ],
    "cost": "",
    "createdBy"<EMAIL_ADDRESS>    "endDate": "Mon, 26 Oct 2020 04:59:00 GMT",
    "id": "5f7e0054d357a4000a754f99",
    "imageURL": "https://api.rokwire.illinois.edu/events/5f7dfc455c55e182abaafb48/images/5f8070c45c55e182abaafc05",
    "isSuperEvent": false,
    "isVirtual": true,
    "location": {
      "description": "University of Illinois",
      "latitude": 40.1019523,
      "longitude": -88.2271615
    },
    "longDescription": "Reserved for current residents, Same Room Phase of Housing Sign-Up 2021-2022 is October 19\u201325.\r\nIf you love where you live and want to stay there, sign up to keep your current room. Miss the October 3 deadline and your room will be up for grabs for someone else. Click the link below to get started. \r\n\r\n",
    "name": "",
    "sponsor": "University Housing ",
    "startDate": "Mon, 19 Oct 2020 18:00:00 GMT",
    "subEvents": [

    ],
    "subcategory": "",
    "tags": [

    ],
    "targetAudience": [

    ],
    "title": "University Housing Sign-Up Same Room Phase ",
    "titleURL": "https://housing.illinois.edu/apply-now/housing-sign-up",
    "rokwire_score": 1.4
  },
  {
    "allDay": false,
    "category": "Other",
    "contacts": [
      {
        "email"<EMAIL_ADDRESS>        "organization": "University Housing ",
        "phone": "2173337111"
      }
    ],
    "cost": "",
    "createdBy"<EMAIL_ADDRESS>    "endDate": "Fri, 16 Apr 2021 04:59:00 GMT",
    "id": "5f807363d357a4000bf40205",
    "imageURL": "https://api.rokwire.illinois.edu/events/5f8072c55c55e182abaafc2f/images/5f8074c35c55e182abaafc40",
    "isSuperEvent": false,
    "isVirtual": true,
    "location": {
      "description": "University of Illinois",
      "latitude": 40.1019523,
      "longitude": -88.2271615
    },
    "longDescription": "Reserved for current residents, Any Room/Any Hall Phase of Housing Sign-Up 2021-2022 is November 4-April 15. Ready to try a new floor or hall? Sign up to choose any available space in the undergraduate or graduate residence halls. Click the link below to get started!\r\n",
    "name": "",
    "sponsor": "University Housing ",
    "startDate": "Wed, 04 Nov 2020 19:00:00 GMT",
    "subEvents": [

    ],
    "subcategory": "",
    "tags": [

    ],
    "targetAudience": [

    ],
    "title": "University Housing Sign-Up Any Room/Any Hall Phase ",
    "titleURL": "https://housing.illinois.edu/apply-now/housing-sign-up",
    "rokwire_score": 1.4
  }
]

There are sub events are that does not fall in the query time period. In the above result, University Housing Sign-Up Same Room Phase event should not have been returned.

Expected behavior
When ?superEventId=<super event ID> is combined with date filter queries (e.g, &startDate.lte=<date>), the events in the response should be filtered based on those data query filters.

@sandeep-ps We do not apply the query parameters to the subevent search. This is the original design, thus if we have new need and requirement to apply the query parameters to subevent. I change to the Task label instead of Bug.


make distinction between range and uncertainty clearer and have subtypes

have separate types for value and range
make clear that range
how do you save the uncertainty

do we have something like
export interface QuantityWithUnit {
  value: number;
  unitText: string;
  unitCode: string|URL;
}

closes as duplicate of #22


chore: remove >1 year deprecations

This isn't everything with >1year deprecation ages: unfortunately lots is still actually in use!

It'd be nice to have a list of the old deprecated theorems in current use, so people can get to cleaning them up.

It'd be nice to have a list of the old deprecated theorems in current use, so people can get to cleaning them up.

The answer here is basically: "any lemma with nthLe in the name".

@Parcly-Taxel, thanks for taking a look here. It would actually make more sense if you made that commit into a separate PR:

I could then immediately merge it, instead of us needing to go find another reviewer
It will keep this PR simpler, as it is just deleting things, not making significant changes.

@Parcly-Taxel, thanks for taking a look here. It would actually make more sense if you made that commit into a separate PR:
1. I could then immediately merge it, instead of us needing to go find another reviewer

2. It will keep this PR simpler, as it is just deleting things, not making significant changes.

#15965

Thanks!
maintainer merge


[Suggestion] Support to auto navigate to the correct tag in Output Window

OS: All
Build Version: 20190606.16
Repro Steps:

Select "Start Streaming Logs" from the context menu -->Check the tag in Output window.
Select "Configure the Deployment Source..." from the context menu --> Check the tag in Output window.
Check whether it will auto navigate to the correct tag or not.

Actual:
It doesn't auto navigate to the correct tag "Azure App Service ".

Suggestion:
Support to auto navigate to the correct tag in Output window.

We used to open the output channel for the users but received feedback that it was annoying and intrusive.
If I'm understanding correctly, the suggestion is to automatically open the Azure App Service channel for the user, right?

Correct :).

@v-dantch
Thanks for your suggestion!  But as I mentioned, users said that opening the output channel for them was a little bit annoying so I'll close this unless we get user feedback.


Added docs for 'get releases' command

Please remember to

[x] Give the PR a meaningful title -- it will be shown in the release notes
[x] Add (or remove) user questions associated with any updated docs

Terrific! Could you please also add a link to this page form the "Related" section in https://docs.giantswarm.io/ui-api/gsctl/list-releases/ ?


Actor.set_location() is relative, but Actor.set_transform() is absolute for actors attached to another actor

This is kinda part 2 of #857
I would expect both setters and getters for transform, location, and rotation (btw. why does rotation not have a setter/getter?) to be relative when the actor was spawned attached to another.
with set_location, this works. But with set_transform it doesn't.
Alternatively, adding an argument (called "relative_to" or "parent"), which either takes a carla.Actor or None (default) would make this explicit and allow changing attachments at runtime.
Why do i need this? I can't change the rotation of a sensor relative to its Parent at runtime. Translation works

Correction: the setters are both relative, but the getters are absolute.
Still weird behavior.

currently, a workaround is to retain the relative transform while spawning, and update via setters based on that.

I use numpy to multiply matrix versions of the transformations in these cases. As such:

def get_relative_transform(t: carla.Transform, relative_to: carla.Transform) -> carla.Transform:
	rel_m = np.array(relative_to.get_inverse_matrix()).dot(transform_to_matrix(t))
	return matrix_to_transform(rel_m)

def matrix_to_transform(m: np.ndarray) -> carla.Transform:
	return carla.Transform(
		location=carla.Location(x=m[0, 3], y=m[1, 3], z=m[2, 3]),
		rotation=matrix_to_rotation(m[0:3, 0:3])
	)

Like that you can get relative transforms which you can use to set the transform of an attached actor.
I agree that the API could be improved as mentioned before:

set_rotation would be nice in company to set_location
set transform


Updated the native brotli library to the latest version.

The latest brotli encoding lib is now a C library rather than C++, so this has allowed removal
of the brotli_capi wrappers.
The main motivation for this PR is to enable brotli2-rs to be cross-compiled for musl easily.  Since musl doesn't provide a g++ wrapper, the inclusion of C++ files in the compression library is difficult to work around.
I ported the remaining small amount of C++ code in BrotliCompress(), BrotliMemIn and MyBrotliOut to Rust in compress_vec().

Whoa, nice! I always though it was kinda odd they were still using C++.
Looks like there's some test failures but they're a little obscure, I'll take a look

I've updated this now.  Points to note:

I haven't changed Compress::new(), but can do if you wish.
I've put a kind of dirty workaround in for the multiple definitions error we get in the systest.  You could maybe suggest a better approach?
I've unfortunately had to skip systests for two of the encoder structs (one being the main state holder) since their implementations aren't public.  Again, if there's a way I can avoid this, I'd be happy to make the changes.
I've simplified the compress_vec() function by using Compress::copy_input() and Compress::compress(), since this is actually making use of the lowest level API of brotli.  I can change this back and/or look at modifying the Compress interface to look more like BrotliEncoderCompressStream, but I'm not convinced that either of these things would be an improvement.

I've got one or two more cleanups in mind I'll do after merging, but this all looks great to me, thanks @Fraser999!

Ok, a few more commits pushed to master, could you give that a spin and see if it works for you? If so I'll make a new release.

I added a couple of comments to your other commits, but basically this is working fine for us thanks.

Cool, thanks @Fraser999! I've updated to 0.2.0 as well and published to crates.io

Nice one :)  Thanks.


V2 app can't work if the touristic contents are disabled or not synced on admin side

Actually the app always try to load touristic contents and events, which end un in 404 errors and routing issues if the admin doesn't have them synced or active.
We should add a setting to allow the app to ignore touristic contents and, ideally, to inform the user if the files are required but not present.

Oh OK. Indeed we actually dont have touristic content in database for GTE-mobile.
As it is controlled by Geotrek-admin synchronisation (https://github.com/makinacorpus/Geotrek/blob/master/docs/synchronization.rst#synchronization-filtered-by-touristic-content-categories), I thought that it was enough for Geotrek-mobile to know if there is some touristic content and which categories are synchronized with Geotrek-mobile.
I dont really understand the need for a setting.

A setting would prevent geotrek mobile from doing useless requests and it could allows us to handle real files issues independently.

OK I see.

An easier solution wouldnt it be to always include some empty touristic content geojson in the API ?
Maybe it dont make sense ?

I really think it's better to have at the same time an option in the mobile to prevent useless requests and another fix to allow the app to have a functional routing when there's a 404 on json resources.

https://github.com/makinacorpus/Geotrek-mobile/pull/148
Add one boolean setting TOURISTIC to ignore touristic content

:+1:


Adding text to an image

It would be great if there was a quick and easy way to add text to an image. I have a visualization of some WRF data over the US and I’d like to add some text (and maybe also a marker) at various locations to indicate key landmarks such as cities. There is a work-around (suggested on vapor discourse here) for now using image renderer but this seems cumbersome.

Note - this is an internal request from NCAR/MMM.


Allow for initializer to consider use case for argument labels

The initializer command should handle the following cases:
init(_ some: String)
init(some another: String)

I made a small edit to fix a typo. Glad we made this issue!


[Add] Added function calling support to GeminiClient

Why are these changes needed?
I have added function calling ability to GeminiClient so that we can use autogen tools with Gemini as well.
Related issue number

Completes "Function Calling" roadmap item in #2387
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

I am learning python just for the past few days. Kindly give me feedback on what I can improve in this.

Thanks for your great PR @arjun-g !! There are two tiny stuff missing: test cases and tutorial notebook.
Can you add test cases for the new features? I can help to update the Gemini notebook after the test cases are done.

@BeibinLi added a test case. Let me know if this is suffice

@arjun-g - A notebook example of using this would be great to have.

@BeibinLi added a notebook as well.

Thanks @arjun-g for updating. Take a look at @luxzoli PR #2805 , and we might need to slightly update this PR to be consistent with vertexai package. I will edit the notebook after luxzoli's PR is merged. Then, I will edit this PR and merge it.

@BeibinLi got it. I will wait for #2805 to be merged. The function call is a bit different in vertex ai. I will handle that and give the PR.

@BeibinLi updated the PR with function calling support for VertexAI as well.

Currently unable to use Gemini models in Autogen with Tool use (The LLM responds by itself instead of invoking the tool).

Keep calling from Google accounts these people have stolen money's from me
and are acting as me these are hackers hacking me please contact fbi
On Tue, Jun 11, 2024, 6:21 PM Drew Gillson @.***> wrote:

@.**** commented on this pull request.
In autogen/oai/gemini.py
https://github.com/microsoft/autogen/pull/2793#discussion_r1635580134:

             else:

               rst.append(Content(parts=curr_parts, role=prev_role))

               if "function_call" in parts[0] or "function_response" in parts[0]:

                   if len(curr_parts) > 1:

                       rst.append(Content(parts=self._concat_parts(curr_parts), role=prev_role))

                   elif len(curr_parts) == 1:

                       rst.append(Content(parts=curr_parts, role=None if curr_parts[0].function_response else role))

                   rst.append(Content(parts=parts, role="user" if parts[0].function_response else role))

                   rst.append(Content(parts=self._oai_content_to_gemini_content("continue"), role="model"))

Same here - don't add a message with role=model
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/autogen/pull/2793#pullrequestreview-2111606487,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BI3MSTA3ZCM34MGBFX3RDFDZG6A7XAVCNFSM6AAAAABIJCLX2SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJRGYYDMNBYG4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@drewgillson updated the PR as per your comment. Let me know if anything else needs to be done.

I wonder if it would be better to have separate implementations for GeminiAI and VertexAI as there are subtle differences in both.

Quoting the docs at https://cloud.google.com/vertex-ai/generative-ai/docs/multimodal/function-calling#python:-array-of-items

Vertex AI offers limited support of the OpenAPI schema. The following attributes are supported: type, nullable, required, format, description, properties, items, enum. The following attributes are not supported: default, optional, maximum, oneOf.

Does this mean that all functions to be used for Gemini should have only 1 type? In this case there should be two functions (a) with param str and another with (b) param list[str] ?

Hi @arjun-g - Thanks for the amazing work. When I try to use this with a function that has param signature as def some_func(values: str | list[str]) I get an error
/usr/local/lib/python3.10/dist-packages/autogen/oai/gemini.py in oai_function_parameters_to_gemini_function_parameters(function_definition)
    363     The type key is renamed to type_ and the value is capitalized.
    364     """
--> 365     function_definition["type_"] = function_definition["type"].upper()
    366     del function_definition["type"]
    367     if "properties" in function_definition:

KeyError: 'type'

You can find a notebook that demonstrates this error at https://colab.research.google.com/drive/1P56iRkrryHZHz0lA5gZBPur9t7ML_G0A?usp=sharing
Quoting the docs at https://cloud.google.com/vertex-ai/generative-ai/docs/multimodal/function-calling#python:-array-of-items

Vertex AI offers limited support of the OpenAPI schema. The following attributes are supported: type, nullable, required, format, description, properties, items, enum. The following attributes are not supported: default, optional, maximum, oneOf.

Does this mean that all functions to be used for Gemini should have only 1 type? In this case there should be two functions (a) with param str and another with (b) param list[str] ? If yes, then let's make this clear so devs can update their functions accordingly.
Also note how safety settings have been applied. It would be good to add this as an example in your notebook as well.

Thanks for pointing this out @r4881t . I have added an assertion error for union of data types and deleting the default value.

Hi @arjun-g , it works now. Thanks.
Another issue I noted is that when i started my app, it complained of importerror and told me to pip install google-generativeai. When I did that and ran again, it again threw the same error. So I added a print statement in the autogen/oai/client.py and found that vertexai module was missing. Then I installed it by pip install google-cloud-aiplatform and it ran successfully.

So a better error message would be helpful

Hi @arjun-g , it works now. Thanks.
Another issue I noted is that when i started my app, it complained of importerror and told me to pip install google-generativeai. When I did that and ran again, it again threw the same error. So I added a print statement in the autogen/oai/client.py and found that vertexai module was missing. Then I installed it by pip install google-cloud-aiplatform and it ran successfully.

So a better error message would be helpful

Hi, @r4881t This is unrelated to function calling. This is a problem with vertexai implementation itself. Will give a separate PR for this.

@BeibinLi @drewgillson

Okay, running through a set of test programs (which I've put on my repository), it looks good, however there was an issue with parallel tool calling (when the model suggests two or more tool-calls in one response). It's only handling one tool-call suggestion.
I'll add my code in to correct that.
My repo with test programs that you can use to test:
https://github.com/marklysze/AutoGenClientTesting
I ignored the streaming ones as streaming isn't supported yet in the code

Nice work @arjun-g :)... just need to run pre-commit run to tidy up the test file and notebook, and then commit that. That should rectify the "Code formatting / pre-commit-check" fail that's occurring.
Let us know if you need help with that.

Codecov Report
Attention: Patch coverage is 2.34375% with 125 lines in your changes missing coverage. Please review.

Project coverage is 18.77%. Comparing base (03259b2) to head (6563248).
Report is 1 commits behind head on main.

Files
Patch %
Lines

autogen/oai/gemini.py
2.34%
125 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (03259b2) and HEAD (6563248). Click for more details.
HEAD has 4 uploads more than BASE
| Flag | BASE (03259b2) | HEAD (6563248) |
|------|------|------|
|unittests|1|5|

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2793       +/-   ##
===========================================
- Coverage   32.45%   18.77%   -13.69%
===========================================
  Files          93       99        +6
  Lines       10109    10261      +152
  Branches     2172     2358      +186
===========================================
- Hits         3281     1926     -1355
- Misses       6544     8146     +1602
+ Partials      284      189       -95

Flag
Coverage Δ

unittests
18.73% <2.34%> (-13.73%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Is there anything else you need here @arjun-g? This is an important component for the gemini client I'd love to make use of in a more official capacity. I'm happy to help wrap up.

@robraux I am held up in a work. Will update the PR in couple of days,

It would be really nice to have this feature 🙂

Looking forward to having this feature 🙂

@arjun-g I have prepared a pull request to your repo that would resolve the merge conflicts, synchronize updates from the upstream autogen repo, and also add support for tool config with function calling.
Only changes to gemini.py , test_gemini.py , and openai_utils.py need to be reviewed, as the rest is changed due to synchronization with the official autogen repo except for agentchat_gemini.ipynb, where the difference is only automated formatting, which is not visible to the user anyway and thus irrelevant.
I hope this would save you some effort in case you still do not have time to finish this PR :)
You find a link to the PR here

@luxzoli  would you like to make a PR with your changes directly to this repo? Unless @arjun-g  you would like to continue with this?

@luxzoli would you like to make a PR with your changes directly to this repo? Unless @arjun-g you would like to continue with this?

Yes, sure. I can make a PR directly to the repo if @arjun-g will not finish this PR

@arjun-g please let us know soon. Thanks!

Closing this as work continue in #3726


Feat/vtp attributes

We should wait for VTU PR before merging this one

:tada: This PR is included in version 4.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Issue with Spacebuild

Some people on my server get this error:
"sbep_base_docking_clamp"
Entity Class Black listed, "sbep_base_door"
I on the other hand do not. I have advdupe2 local on my client but they do not. I looked through the code but found nothing really helpful so I figured I would file a bug report.

The entity needs to register itself as a duplicatable entity or else duplicator won't allow it.
Use http://wiki.garrysmod.com/page/duplicator/RegisterEntityClass or http://wiki.garrysmod.com/page/duplicator/Allow

pretty sure this isn't adv dupe 2's fault


Fixed not being able to delete lesson

Fixes #270

Policy part is already handled in https://github.com/openvitae-tech/blackboard-lms/pull/288.

@deepakkumarnd Please review


Disable "Enable new sign ups" does not work

Bug Report
Installation Method
Docker
Environment
0.3.21

Operating System: Linux (Synology)
**Browser (if applicable):Edge Chromium

Confirmation:

[ x] I have read and followed all the instructions provided in the README.md.
[x ] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.
[ ] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Expected Behavior:
New sign ups should be rejected
Actual Behavior:
Sign ups are allowed and totally unknown users show up as pending member into my list of users.
Description
Bug Summary:
See actual behavior
Reproduction Details
Steps to Reproduce:
Not relevant, users sign up though they should not be allowed to.

Working fine for me on the latest dev.

“I’m not sure I fully understand your point. I exclusively use OAuth for sign-ins, as it’s the most secure method, and passwords are vulnerable to brute-force attacks. Through OAuth, users can log in via Google, but they still appear in a ‘pending’ state. I’m using the latest version of Open-Webui, so the issue isn’t resolved for me. My goal is to prevent random users from signing up.

Have you set ENABLE_SIGNUP as an environment variable for your Open WebUI instance or disabled new sign ups within the UI?

Only within the GUI.

Have now done it in gui and in variable container but no change. Any user can still login then it shows this user status pending.

If you have the OAUTH_MERGE_ACCOUNTS_BY_EMAIL environment variable set to true, this bypasses the env var/toggle in the UI to disable new sign ups, which is intended behavior.

Have now done it in gui and in variable container but no change. Any user can still login then it shows this user status pending.
Also merge is not enabled.

Should be fixed with the latest dev, test wanted here!


[BugFix] fix show tablet return wrong result

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes:

Fixes #
Problem Summary(Required):

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:disappointed: fail : 2 / 3 (66.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
3
66.67%
[1879]

[FE PR Coverage Check]
:disappointed: fail : 2 / 3 (66.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
3
66.67%
[1879]

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


The aur package dosn't work correctly with paru

Hi! Trying to build this package with paru and it seems to be failing with the error
could not find Cargo.toml in /tmp/makepkg/cmus-rpc-rs/src or any parent directory
When building directly from GitHub and cargo though it seems to be fine.

from @Fazzi in https://aur.archlinux.org/packages/cmus-rpc-rs#comment-882055

Fixed 👍🏻


Popper.js v1.5.1 broken on IE10 (incorrect positions)

I believe this is an issue on Popper's end, and although IE10 doesn't really matter anymore (works fine on IE11), just checking:

Demo
https://codepen.io/anon/pen/QvbejQ
Steps to reproduce the problem
Scroll down on IE10
What is the expected behavior?
Tooltips should be positioned correctly, sticking to the element
What went wrong?
Tooltip instead scrolls with the scrollbar

I need a test case based on the template provided in the issues. Or even better, a PR that introduces a failing test for your problem.

I'll test the previous popper version with the new standalone tippy

I would suggest to add an automated test suite to Tippy if you want to avoid lot of problems in future. Automated tests are invaluable.

The old version works with tippy.standalone, so...

Ok then please provide the test case as required and I'll take a look

I'll definitely set up tests tomorrow for the library
What kind of test case do you need? I haven't written one in this type of scenario before

It's enough to edit the bug report template:
https://github.com/FezVrasta/popper.js/blob/master/.github/ISSUE_TEMPLATE.md

Any updates on this @atomiks ?

Sorry, not sure what you mean by edit the report template. Edit it with the test case? Can you give an example of what you need?

Take this:
https://codepen.io/FezVrasta/pen/wGqJEz
Update the code to make it reproduce the problem (particular markup, css, anything?)
I need a way to see the bug just opening the codepen without having to debug 3rd party code.

Ah okay, that makes it clear. I'll try to make a failing test

Okay here we go: https://codepen.io/anon/pen/QvbejQ
On IE10, it will scroll down with it rather than stick to the element.
Gif: https://i.gyazo.com/77cb6a3c82b7535f079d9fedd5895c94.mp4

How's that on Chrome I see the tooltip above the button? Is it expected? 😕

Updated

Ok, so... we have problems with margins applied to html, nice... The tests we have seems useless in this case 😓 And we have a scrollTop problem in IE10...
Thank you

This (#217) should fix the problems with the positioning on all browsers.
Tomorrow I'll take a look at the IE10 specific bug.

Any idea when this will be fixed?

I think within today, but I have other things scheduled that needs my attention.

It's trickier than I thought, I added a failing test but I can't find a way to fix the problem without breaking other stuff.

Tippy seems to work in IE10 properly now with 1.9.1, has it been fixed?

Closing this because the codepen and Tippy work in IE10 now, guess you fixed it somehow...


No Close method for AsyncConnection?

If I create a non-async Connection, there is a Close method I can access. However, there isn't a Close method for async connections. Should there be?

SQLiteConnectionPool is not public so it cannot be called!

You can use reflection to call it. In my attempts it worked perfectly for Android and Windows, it fires back after 3x or 4x such closed connections on iOS. Damn... I was almost tempted to go for this solution but on iOS (simulator) it does not seem to be a viable solution.
There must be a reason the creators did the Reset method internal so all in all this approach is probably not recommended but I need to close the connection time to time... :-(
    private static void CloseDatabaseConnectionViaReflection()
    {
        var assembly = typeof(SQLiteAsyncConnection).GetTypeInfo().Assembly;
        var sqLiteConnectionPoolType = assembly.GetTypes().First(t => t.Name == "SQLiteConnectionPool");
        var resetMethod = sqLiteConnectionPoolType.GetMethod("Reset");

        var sqLiteConnectionPoolSharedInstance =
            sqLiteConnectionPoolType
                .GetFields(BindingFlags.Static)
                .First(field => field.IsInitOnly && field.Name == "_shared")
                .GetValue(null);

        resetMethod.Invoke(sqLiteConnectionPoolSharedInstance, null);
    }

Pls has this issue been resolved? I also need the close() method on the async connection.

Up for the CloseAsync() method. Why is it missing?

Yeah, this is all my fault. I still use the synchronous version so the Async version gets neglected.
I've created Issue #480 to remind me to get these back in parity.
This issue will track the change to expose SQLiteConnectionPool.Shared.Reset

The solution is to call SQLiteConnectionPool.Shared.Reset(); This closes all of the open connections.
This issue will track the change to expose SQLiteConnectionPool.Shared.Reset
Isn't that dangerous? If you want to just close your current connection, exposing a CloseAsync method on the SQLiteAsyncConnection would be sufficient. You don't always know what other async or parallel process might have connections still being used before you just force shut them all down. I'm not sure that the pool reset needs to be exposed if CloseAsync is provided.

Working on a CloseAsync method now.

Thank you so much!

To cleare that pool call:
SQLiteAsyncConnection.ResetPool();
im using  sqlite-net-pcl 1.4.118
_connection.GetConnection().Close();                 _connection.GetConnection().Dispose();                 SQLiteAsyncConnection.ResetPool();


[IMPROVEMENT] Cleanup of left over resources after CLI command interruptions

Is your improvement request related to a feature? Please describe (👍 if you like this request)
Currently, users need to manually clean up leftover resources created by most CLI commands if the execution is interrupted.
Describe the solution you'd like
We can introduce a third-layer sub-command stop for each operation that automatically cleans up any residual resources. This approach is similar to the install preflight stop command.
Describe alternatives you've considered
None
Additional context
None

Besides, prevent running a cmd operation if there is ongoing or orphaned one unless it is finished or stopped.


Can't pass multiple arguments to hset(..., mappint={...})

Describe the bug
Passing multiple arguments to the mapping in Redis.hset(mapping={...}) raises ResponseError.
To Reproduce
Working example.
import asyncio
import aioredis

async def main() -> None:
    redis = aioredis.Redis(decode_responses=True)
    # Only 1 key -> value
    await redis.hset("users", mapping={"me": 'user1'})
    print(await redis.hgetall("users"))
    # Returns {'me': 'user1'}
    await redis.close()

loop = asyncio.get_event_loop()
loop.run_until_complete(main())

Example where the bug occurs
import asyncio
import aioredis

async def main() -> None:
    redis = aioredis.Redis(decode_responses=True)
    # Passing multiple key -> value to the mapping raises the error below.
    await redis.hset("users", mapping={"me": 'user1', "me2": "user2"})
    print(await redis.hgetall("users"))
    await redis.close()

loop = asyncio.get_event_loop()
loop.run_until_complete(main())

Expected behavior
The bugged example is supposed to return a mapping with the 2 inserted keys which's {"me": "user1", "me2": "user2"}
but raises ResponseError instead.
Logs/tracebacks
Traceback (most recent call last):
  File "auth_test\t.py", line 12, in <module>
    loop.run_until_complete(main())
  File "Python310\lib\asyncio\base_events.py", line 641, in run_until_complete
    return future.result()
  File "auth_test\t.py", line 7, in main
    await redis.hset("users", mapping={"me": 'user1', "me2": "user2"})
  File "auth_test\.venv\lib\site-packages\aioredis\client.py", line 1085, in execute_command
    return await self.parse_response(conn, command_name, **options)
  File "auth_test\.venv\lib\site-packages\aioredis\client.py", line 1101, in parse_response
    response = await connection.read_response()
  File "auth_test\.venv\lib\site-packages\aioredis\connection.py", line 919, in read_response
    raise response from None
aioredis.exceptions.ResponseError: wrong number of arguments for 'hset' command

Python Version
$ python --version
Python 3.10.1

aioredis Version
$ python -m pip show aioredis
Name: aioredis
Version: 2.0.1
Summary: asyncio (PEP 3156) Redis support
Home-page: https://github.com/aio-libs/aioredis-py
Author:
Author-email:
License: MIT
Location: \auth_test\.venv\lib\site-packages
Requires: typing-extensions, async-timeout
Required-by:

Additional context
No response
Code of Conduct

[X] I agree to follow the aio-libs Code of Conduct

Apologies. Is this resolved in #1156?

No not really. I just installed aioredis from that branch and it still raises the same error.
  File "D:\Projects\auth_test\t.py", line 6, in main
    await r.hset("users", mapping={"me": "user1", "me2": "user2"})
  File "D:\Projects\auth_test\.venv\lib\site-packages\aioredis\client.py", line 1173, in execute_command
    return await conn.retry.call_with_retry(
  File "D:\Projects\auth_test\.venv\lib\site-packages\aioredis\retry.py", line 52, in call_with_retry
    return await do()
  File "D:\Projects\auth_test\.venv\lib\site-packages\aioredis\client.py", line 1152, in _send_command_parse_response
    return await self.parse_response(conn, command_name, **options)
  File "D:\Projects\auth_test\.venv\lib\site-packages\aioredis\client.py", line 1188, in parse_response
    response = await connection.read_response()
  File "D:\Projects\auth_test\.venv\lib\site-packages\aioredis\connection.py", line 912, in read_response
    raise response from None
aioredis.exceptions.ResponseError: wrong number of arguments for 'hset' command

I'm not really sure what to say since I can't reproduce this. If you find a solution, please let me know:
In [8]: async def main():
   ...:     redis = aioredis.Redis(decode_responses=True)
   ...:     try:
   ...:         await redis.hset("users", mapping={"me": "user1", "me2": "user2"})
   ...:         print(1, await redis.hgetall("users"))
   ...:     except Exception as e:
   ...:         print(2, e)
   ...:     finally:
   ...:         await redis.close()
   ...:
In [9]: await main()
1 {'me': 'user1', 'me2': 'user2'}

I figured out that the the issue was in my end, I was using Redis on windows version v=3.2.100 which's pretty a outdated build.
re-tested it on linux distro and worked fine. Will close this for now. Thanks!


IFTTT integration?

I like your bookmarklet idea! One thing that might be useful would be to have the option of triggering IFTTT when a reservation is found, so that you can start the bookmarklet and walk away from your computer. IFTTT could trigger an SMS text, phone call, or email notification to let you know if anything was found.
I saw this simple example, so I believe it's possible:
https://gist.github.com/thegabrielstein/02b1fb5c8c6285e41f1826d3d06ed7c8

Usually too late to reserve by then.

Yeah, good idea, but from my experience I have to agree with @joeyman178.   I was able to score Space 220 and Olga's withing a few days!  Really helped me for my trip in Dec 2021, so just sharing if it could help others.  Please feel free to open issues if it is no longer compatible with the existing reservation site, as I have not tried it in some time.

Yeah, good idea, but from my experience I have to agree with @joeyman178.   I was able to score Space 220 and Olga's withing a few days!  Really helped me for my trip in Dec 2021, so just sharing if it could help others.  Please feel free to open issues if it is no longer compatible with the existing reservation site, as I have not tried it in some time.

Thanks Justin. I will be heading to Disney in late July, so will definitely look into using this for around that time. Any tips or recommendations for the process? Parks booked first or restaurants?
Thank you for your help!

Closing this due to it probably being too late to get a reservation once IFTTT triggers.
@joeyman178 if you still want to chat about your trip, send me an email and we can connect:
<EMAIL_ADDRESS>


CircleAvatar needs a fit property

CircleAvatar needs a fit property
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/material.dart';

// Examples can assume:
// String userAvatarUrl;

/// A circle that represents a user.
///
/// Typically used with a user's profile image, or, in the absence of
/// such an image, the user's initials. A given user's initials should
/// always be paired with the same background color, for consistency.
///
/// ## Sample code
///
/// If the avatar is to have an image, the image should be specified in the
/// [backgroundImage] property:
///
/// ```dart
/// new CircleAvatar(
///   backgroundImage: new NetworkImage(userAvatarUrl),
/// )
/// ```
///
/// The image will be cropped to have a circle shape.
///
/// If the avatar is to just have the user's initials, they are typically
/// provided using a [Text] widget as the [child] and a [backgroundColor]:
///
/// ```dart
/// new CircleAvatar(
///   backgroundColor: Colors.brown.shade800,
///   child: new Text('AH'),
/// )
/// ```
///
/// See also:
///
///  * [Chip], for representing users or concepts in long form.
///  * [ListTile], which can combine an icon (such as a [CircleAvatar]) with some
///    text for a fixed height list entry.
///  * <https://material.google.com/components/chips.html#chips-contact-chips>
class CircleAvatar2 extends StatelessWidget {
  /// Creates a circle that represents a user.
  const CircleAvatar2({
    Key key,
    this.child,
    this.backgroundColor,
    this.backgroundImage,
    this.foregroundColor,
    this.radius: 20.0,
    this.fit: BoxFit.cover,
  })
      : super(key: key);

  /// The widget below this widget in the tree.
  ///
  /// Typically a [Text] widget. If the [CircleAvatar] is to have an image, use
  /// [backgroundImage] instead.
  final Widget child;

  /// The color with which to fill the circle. Changing the background
  /// color will cause the avatar to animate to the new color.
  ///
  /// If a background color is not specified, the theme's primary color is used.
  final Color backgroundColor;

  /// The default text color for text in the circle.
  ///
  /// Falls back to white if a background color is specified, or the primary
  /// text theme color otherwise.
  final Color foregroundColor;

  /// The background image of the circle. Changing the background
  /// image will cause the avatar to animate to the new image.
  ///
  /// If the [CircleAvatar] is to have the user's initials, use [child] instead.
  final ImageProvider backgroundImage;

  /// The size of the avatar. Changing the radius will cause the
  /// avatar to animate to the new size.
  ///
  /// Defaults to 20 logical pixels.
  final double radius;

  /// Avatar Image BoxFit.
  ///
  /// Defaults to cover.
  final BoxFit fit;

  @override
  Widget build(BuildContext context) {
    assert(debugCheckHasMediaQuery(context));
    final ThemeData theme = Theme.of(context);
    TextStyle textStyle = theme.primaryTextTheme.title;
    if (foregroundColor != null) {
      textStyle = textStyle.copyWith(color: foregroundColor);
    } else if (backgroundColor != null) {
      switch (ThemeData.estimateBrightnessForColor(backgroundColor)) {
        case Brightness.dark:
          textStyle = textStyle.copyWith(color: Colors.white);
          break;
        case Brightness.light:
          textStyle = textStyle.copyWith(color: Colors.black);
          break;
      }
    }
    return new AnimatedContainer(
      width: radius * 2.0,
      height: radius * 2.0,
      duration: kThemeChangeDuration,
      decoration: new BoxDecoration(
        color: backgroundColor ?? theme.primaryColor,
        image: backgroundImage != null
            ? new DecorationImage(
                image: backgroundImage,
                fit: fit,
              )
            : null,
        shape: BoxShape.circle,
      ),
      child: child != null
          ? new Center(
              child: new MediaQuery(
              // Need to reset the textScaleFactor here so that the
              // text doesn't escape the avatar when the textScaleFactor is large.
              data: MediaQuery.of(context).copyWith(textScaleFactor: 1.0),
              child: new DefaultTextStyle(
                style: textStyle.copyWith(color: foregroundColor),
                child: child,
              ),
            ))
          : null,
    );
  }
}

also a shadow property for BoxShadow

Can you talk more about the use cases for these features?

@Hixie
square images fit correctly in the avatar, but rectangular images don't and a background is shown (blue one).
so if we set the fit to cover, those images fill the gaps.

@Hixie
and some times there's a need to glow the back drop of the avatar or maybe place a shadow.

Maybe it should just always set it to cover?

@Hixie
That's a better conclusion, avatar images always cover the container.

Any solution for this yet?

How can I fit this lake.jpg to the round circleavatar.
Code snippet
`
new CircleAvatar(
backgroundImage: new AssetImage('images/lake.jpg'),
radius: 100.0,
 )

`
After radius, for my sense there should be a 'fit: boxfit' but it won't work. Does anyone know how I can fit the image to the hole circle?

Any solution for this yet?

@silverhairs, yes, this was fixed in April 2018.

cover is fine if a photo is to be displayed.
But what about a company profile showing a logo in the Avatar? The company logo is not supposed to be cropped, so that contain would be more relevant for that use case...


Reorganize readme content and add ability to publish as GitHub pages.

.rst documents added as glue to support Sphinx output
conf.json, conf.py, requirements.txt, substitutions.txt are Sphinx support files.
Makefile - added html rule. make.bat is for Sphinx Windows support.
bad_refs.txt and fix_refs.py are needed as this is an atypical Sphinx deployment and some file dependencies need to be fixed after the build. (fix_refs.py called after sphinx build in Makefile).
.gitignore changed to exclude some local files I was using.
Multiple .md files added as part of reorganization.
publish.yml is github workflow - needs to be updated to work with intel/pmem-csi repo.

Forgot to mention processMDFiles.py, which I used for readme discovery. Could be removed without impact.

Before I look into details, some high-level questions and suggestions:

Is it possible to see or check the result of document changes before merging them? For individual .md files we could look at how GitHub rendered the modified file and while this was not always done and thus Markdown errors occasionally got past PR review, at least the option is there.
How can we handle different docs for the different supported branches? We probably want to make available docs for master and the latest stable release (starting with the upcoming 0.7.0 - we won't backport this to 0.6.x).
Can we reduce the top-level README.md to something that just provides a short explanation of the project and then links to the "docs" folder for details and the rendered documentation? Then people coming to the repo know where to continued without immediately being overwhelmed by the actual documentation. Worse, they might miss that there is a docs site...

@pohly

There are two recommended options for previewing locally.

Install reDocs GUI (Intel internal tool) and click "build" and "preview"
"pip install -r requirements.txt" to install dependencies and run "make html" - build output will be in _build/html directory.

How should it be organized when viewed? GitHub actions are pretty flexible. Were you thinking: intel.github.io/pmem-csi/latest, intel.github.io/pmem-csi/0.7.0, and intel.github.io/pmem-csi/0.8.0 as possible URLs?
Yep. Shall I propose something?

"pip install -r requirements.txt" to install dependencies and run "make html" - build output will be in _build/html directory.

Can we automate this so that "make html" will run inside a container which (ideally) already has the necessary tools installed? We assume that the developer has the rights to invoke "docker run" and has Go installed, but try to limit the set of additional dependencies. If there's no such container image, then a Python venv inside _build would also be okay. The latter approach then makes Python and venv an additional requirement.

How should it be organized when viewed? GitHub actions are pretty flexible. Were you thinking: intel.github.io/pmem-csi/latest, intel.github.io/pmem-csi/0.7.0, and intel.github.io/pmem-csi/0.8.0 as possible URLs?

We produce new patch releases automatically and frequently, usually without changing the content. "intel.github.io/pmem-csi/latest" and "intel.github.io/pmem-csi/0.7" (or in general, "intel.github.io/pmem-csi/x.y" for a "release-x.y" branch) sounds good to me.

Yep. Shall I propose something?

Please do :smile:

Can we automate this so that "make html" will run inside a container which (ideally) already has the necessary tools installed?

I built up a Dockerfile a while ago, which I can modify for this purpose. Do you have a preference for base image (Ubuntu, Alpine, etc.)? My assumption was that the user would build the docs with something like:
sudo docker  run --rm  -v `pwd`:/home/sphinx -w /home/sphinx -i -t  <image name> make html

Any tips for using docker on IT managed Windows? I kept having access to local file system broken.

We produce new patch releases automatically and frequently, usually without changing the content. "intel.github.io/pmem-csi/latest" and "intel.github.io/pmem-csi/0.7" (or in general, "intel.github.io/pmem-csi/x.y" for a "release-x.y" branch) sounds good to me.

So make the documentation HTML output one of the release artifacts, which gets deployed when the website is built.

Yep. Shall I propose something?

Please do 😄

Will do.

I ran some experiments in our Jenkins worker and on my local machine. We don't have "venv" installed at the moment under Jenkins, but apt-get install python3-venv completes reasonably fast. Doing it without venv is worse because apt-get install python3-pip also downloads binutils and gcc, something that we don't need. Then pip install completes in a few seconds.
This is faster than downloading a (large!) Docker image like ddidier/sphinx-doc and we get full control over the content via the requirements.txt. It might also work under Windows, although I am not sure because there will be some POSIX shell dependencies, like . _work/venv/bin/activate to enter the venv.
Let me see whether I can come up with a patch for make html which uses venv...

Would you consider Tox? I realize it has more dependencies than just venv, but the project is already configured to use it.

Would you consider Tox? I realize it has more dependencies than just venv, but the project is already configured to use it.

What is Tox, and which project?

Let me see whether I can come up with a patch for make html which uses venv...

That seems to be working, see https://github.com/intel/pmem-csi/blob/d03cf74be569b333e274c2aaee5f732c0b49d45d/test/e2e/deploy/deploy.go#L387

Would you consider Tox? I realize it has more dependencies than just venv, but the project is already configured to use it.

What is Tox, and which project?

Tox is a Python test framework that uses venv under the hood. It does all the heavy lifting for you. I built a GUI app that uses it to encapsulate all the dependencies for building Sphinx projects. All that is needed are the tox.ini and setup.py already checked into this branch.

Is it possible to see or check the result of document changes before merging them?

It is: https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/job/pmem-csi/view/change-requests/job/PR-571/Doc_20Site/
The job itself has a "Doc Site" item on the left: https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/job/pmem-csi/view/change-requests/job/PR-571/
That's with the additional commit here: https://github.com/intel/pmem-csi/pull/571/commits/b59c9f3720e6d91a9d93b20736eb65e3deec0861

Is it possible to see or check the result of document changes before merging them?

It is: https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/job/pmem-csi/view/change-requests/job/PR-571/Doc_20Site/
The job itself has a "Doc Site" item on the left: https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/job/pmem-csi/view/change-requests/job/PR-571/
That's with the additional commit here: b59c9f3

Nice. Couple of questions:

Is this infrastructure (azure) unique to K8 projects or can anyone use it?
How long do the artifacts of the PR build persist?

2. How long do the artifacts of the PR build persist?

there is no automatic cleanup configured, so in theory, for long time. But in practice, the system will run out of space, so I have made some manual deletions of older (multi-month) PR jobs.

Is this infrastructure (azure) unique to K8 projects or can anyone use it?

Azure is shared with other teams, but the Jenkins instance is specific to the Cloud Native projects.

Tox is a Python test framework that uses venv under the hood. It does all the heavy lifting for you. I built a GUI app that uses it to encapsulate all the dependencies for building Sphinx projects.

Running venv isn't hard. I'm not sure whether Tox really has practical advantages for us. I'd rather keep everything as simple as possible.

All that is needed are the tox.ini and setup.py already checked into this branch.

I haven't gotten to looking at individual files in this PR, so it's good that you mention those now - that way I don't need to ask :grin:
We can't take those into PMEM-CSI even if we wanted to because the source URL is not public and might even be considered confidential (reveals information about the Intranet).

@pohly sounds good. Give me a couple of days.

@pohly I've addressed quite a bit of your feedback. You can take a look at the latest deployed build here: https://intelkevinputnam.github.io/pmem-csi/.
Branch and tag relative links are fairly easy. If it is really necessary to use a specific commit, I think we can solve the linking issue for commits using GitHub workflows to feed the value into the build.

The structure looks good now. I noticed some dead links, for example in https://intelkevinputnam.github.io/pmem-csi/latest/install.html#hardware-required, "QEMU and Kubernetes” is broken.
Can you squash the commits?

The structure looks good now. I noticed some dead links, for example in https://intelkevinputnam.github.io/pmem-csi/latest/install.html#hardware-required, "QEMU and Kubernetes” is broken.

Fixed, plus a few others. One of the reasons I like reStructuredText with Sphinx is the hardy internal reference system and automatic checking during the build.

Can you squash the commits?
Yep. Only took 2 tries.

Fixed, plus a few others. One of the reasons I like reStructuredText with Sphinx is the hardy internal reference system and automatic checking during the build.

So why did the broken link get through that checking?

Can you squash the commits?

Yep. Only took 2 tries.

Almost there :grin: Please also update the commit message of that resulting commit. You can do that with git commit --amend.
A good subject (first line) is "docs: generate doc site with Sphinx" followed by a blank line and then a short summary of what the commit is about. Usually we also expect a "why this is useful" or "why this way" but that's obvious in this case, so don't bother.
But I have some other comments:

Can you move as many files as possible into the "docs" folder?
"make html" is currently broken for me (see below).
Can you add some instructions for developers to DEVELOPMENT.md? Consider what we need to know to continue maintaining this going forward in case that you are not around to help with it. For example, how do we deal with broken links? "bad-refs.txt  requirements.txt  substitutions.txt" all need to be documented.
There a plenty of warnings during "make vhtml". Can we get rid of those? Ideally, warnings should be errors or suppressed.

Okay, so now we have "make html" and "make vhtml". The later is what Jenkins and I want to use, but it fails for me:
$ make vhtml
rm -rf _work/venv
python3 -m venv _work/venv
. _work/venv/bin/activate && pip install -r requirements.txt
Collecting sphinx (from -r requirements.txt (line 1))
...
. _work/venv/bin/activate && \
	sphinx-build -M vhtml "." "_output"   && \
	python3 fix-refs.py
Running Sphinx v3.0.2

Sphinx error:
Builder name vhtml not registered or available through entry point
make: *** [Makefile:220: vhtml] Error 2

Here's a fix:
diff --git a/Makefile b/Makefile
index 1c5f2fdd..a3c09fbb 100644
--- a/Makefile
+++ b/Makefile
@@ -218,12 +218,12 @@ BUILDDIR      = _output
 # Generate doc site under _build/html with Sphinx.
 vhtml: _work/venv/.stamp
        . _work/venv/bin/activate && \
-               $(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) && \
+               $(SPHINXBUILD) -M html "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) && \
                python3 fix-refs.py
                cp index.html $(BUILDDIR)/html/index.html

-html:
-               $(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) && \
+html:
+               $(SPHINXBUILD) -M html "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O) && \
                python3 fix-refs.py
                cp index.html $(BUILDDIR)/html/index.html

But why did it work in Jenkins? Answer: because it's not invoked in Jenkins anymore. I'm not sure yet why. Looking at the pipeline for https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/job/pmem-csi/job/PR-562/16 I don't see the "docsite" stage. It's as if Jenkins ignored the modified Jenkinsfile. I wonder whether it does that intentionally because you are an untrusted contributor... those could cause all kinds of havoc if they were allowed to modify the pipeline. On the other hand, they can already do that by modifying other files, so this doesn't make a lot of sense.

It's as if Jenkins ignored the modified Jenkinsfile.

That seems to be it. The docsite was produced (with my fix) in https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi/detail/PR-571/3/pipeline.

@pohly Sphinx only checks cross referencing when they're written in reStructuredText and the syntax for those references are Sphinx specific, so they don't render well in GitHub. Markdown doesn't get the same royal treatment. I've added a couple of small extensions to improve markdown processing to fix references to files that need to be downloaded and references to other markdown files with anchors, but the checking is still a gap.

@pohly I've addressed most of your requests in another branch on my fork. Just working on the developer instructions for editing and improving the docs. You can take a look at the output here.
The build is down to one warning, and I was able to get rid of fix-refs.py and bad-refs.py. Those links are now fixed on the fly by changes I put in conf.py. You also now have the option to have linked files copied over into the html site or have the links converted to the github repo (by commit SHA when building with GitHub workflows). Links to directories are always turned into links to the repo. You can also choose to define a basebranch in the conf.py rather than use the commit SHA.
Once I'm done I'll squash and merge into this branch and amend the commit message.

@pohly Please, let me know if there is any more feedback.

I ran make vhtml and still got one warning:

WARNING: html_static_path entry '_static' does not exist

I indeed don't have _static directory. It looks like removing "html_static_path" from json.conf fixes this.
Commit b5e77867f35591588609a9236ac69a8e6c24c143 still has a rather long commit message:
docs: generate docs site with Sphinx

    Merge of squashed commits.
All of my changes for supporting docs and publishing with Sphinx.

    Signed-off-by: Kevin Putnam<EMAIL_ADDRESS>
    Removed local changes.

    Signed-off-by: Kevin Putnam<EMAIL_ADDRESS>
    Fixed typo in header.
...

As I want to try out this build with the modified Jenkinsfile, I'll create a separate PR myself where Jenkins will pick up that change and will remove that extra commit message comments there.

Merged via PR #571, thanks @intelkevinputnam.


version of pytorch

Could you tell me  the version of pytorch you use?  I use the pytorch0.4.1 and it tell me  module 'model_zoo' has no attribute 'BNInception'.

it was writtent in 0.3.x


This document does not print correctly with firefox

https://www.dropbox.com/s/d2j81j6fbblcx2u/Hausaufgaben_6.pdf?dl=0
The Document here won’t print properly with firefox... If I print this with preview for example it works well.
Not sure if this is a bug, but i wanted to let you know this.
Might be a problem with LaTeX and I had this more than once with pdfs containing LaTeX.

Could you provide a bit more details? It is a font problem, are there blank pages, is the print blurry? What is you OS name/version and browser name/version?

My OS is OS X 10.11.1 and I’m printing with the default driver for my Canon Pixma MP 610.
The pdfs look blurry, and are rendered incorrectly.
Preview.app prints them just fine, firefox (42) prints them incorrect.

If you could provide screenshots, then that would be very helpful. Anything you can provide to make the issue clear might speed up its resolution. Thanks.

Differences between prints expected and final results. Another example document
In both softwares it looks fine, but being printed out... just no!
https://www.dropbox.com/s/2gqlafq05mju8nn/Hausaufgaben_2-1.pdf?dl=0

Judging by the images, this might be related to #6498 where we lose the font when printing, causing this kind of rendering.

I don’t know 😅

Closing as fixed by #7694.


param and fps

Hello, could you please tell me how to obtain param and fps?

Hi @wp664, for FPS, you can follow this script provided in mmdet3d. While for param, you can refer to the parameter_count_table implemented in mmengine.

@Xiangxu-0103, Thanks.

I ran the following command and got around 18 fps on the 3090, which is quite different from the 29.1 mentioned in the paper. Do I need to do anything else? Thank you for your help.
python mmdetection3d/tools/analysis_tools/benchmark.py configs/frnet/frnet-semantickitti_seg.py frnet-semantickitti_seg.pth

Hi, the FPS is calculated under fp16 mode.


Assert in aws_mqtt_agent.c

We are noticing some of our devices are crashing on an assert in this function in aws_mqtt_agent.c
static void prvReturnConnection( UBaseType_t uxBrokerNumber )
{
    configASSERT( uxBrokerNumber < ( UBaseType_t ) mqttconfigMAX_BROKERS );

    /* Since this function is called from application tasks, many tasks can
     * be touching the xConnectionInUse simultaneously and therefore it has to
     * be in critical section. */
    taskENTER_CRITICAL();
    /* Mark the connection as "not in use". */
    xMQTTConnections[ uxBrokerNumber ].xConnectionInUse = pdFALSE;
    taskEXIT_CRITICAL();
}

Below is an example of panic backtrace that our devices are reporting back.
invoke_abort
amazon-freertos/lib/third_party/mcu_vendor/espressif/esp-idf/components/esp32/panic.c:216
abort
amazon-freertos/lib/third_party/mcu_vendor/espressif/esp-idf/components/esp32/panic.c:225
prvReturnConnection
amazon-freertos/lib/mqtt/aws_mqtt_agent.c:802
MQTT_AGENT_Delete
amazon-freertos/lib/mqtt/aws_mqtt_agent.c:1947
SHADOW_ClientDelete
amazon-freertos/lib/shadow/aws_shadow.c:1522

Would love some insight on why this could be happening so we can trace the issue down.

Apologies, it ended up being user error where we were trying to close a connection when it was not opened in the first place.


feat:footer_component

Closes #64
Fixes Issue
As suggested under issue #64 , added up a footer component with the same pattern as suggested by you and also added up the same content as you commented out in the issue .

Proposed Changes

Checklist (Check all applicable boxes)

[✅] My code adheres to the project's coding style.
[✅] My changes require updates to the project's documentation.
[✅] I have updated the documentation accordingly.
[✅] All new and existing tests have passed successfully.
[✅] This PR does not contain any plagiarized content.
[✅] The title of my pull request provides a brief description of the requested changes.

[✅] I am contributing independently.
[✅] I am contributing for Hacktoberfest 2023.

Potential Impact on Existing Code

Screenshots

Reviewer Notes
Pls do review up the changes and do suggest the features to be added into it.
@ManishaSwain8  Pls label it with Hactobefest-accepted  and Hacktoberfest.

@ManishaSwain8 pls do review up the changes as listed under #64  .

@abhay-raj19 you can add some more content to it , like about us,contact us ,with logo (sky colored icon that you can see in the tab)with title though footer is not req for this project ,still you can add some more content to it .

@ManishaSwain8 now pls do review it , if it is fine merge it into main codebase and pls do label it with hacktoberfest-accepted label

@abhay-raj19 you have removed some of the CSS that is affecting other elements too .

Button color of "Show map " is removed.
preloader has been moved to corner .

@ManishaSwain8 now pls do review it

@abhay-raj19  thankyou for your contribution !


Use first non-hidden partition from disk

When the virtual disk is created, a 16MB hidden partition is also created.  This partition gets selected, resulting in a failure to restore the database to the virtual disk.

Thank you for the changes @scottcramer!
Can you make some small changes though?
Can you change the following line
$partition = Get-Partition -Disk $disk | Where-Object { !$_.IsHidden } | Select-Object -First 1
to
$partition = Get-Partition -Disk $disk | Where-Object { -not $_.IsHidden } | Select-Object -First 1
I like to stay away from using abbreviations in PowerShell to keep it all the same.
I see you created a new command called Remove-PSDCUnusedImage, which I think is is great functionality. I do think it's better if that functionality was implemented in the Remove-PSDCImage function in the form of a switch parameter.
That way a user can call the same function to remove images but only has to apply something like this:
Remove-PSDCImage -Unused
The this could all be done in the begin block where all the filtering takes place.

Will do.  Thanks for the suggestions!


Update github workflow

add node v22 in testing matrix
remove deprecated node v16 version
update github action versions
remove duplicated test

for clarification: I would like to use this nice small lib to handle jsonl files with cypress.io. unfortunatelly cypress and its webpack has issues with the import of node:<modulename> and crashes. I tried to fix that somehow, but this is an issue with cypress, not in your library.
one other thing is, that the project is using vue3 and typescript, which isn't supported here yet. Because the lack of time, a bit lack of knowledge and the problem that cypress crashes when I try to use the lib within the testing code, I couldn't test my first attempt to add a type definition to the lib.
So I ended up to remove your lib again and handle the jsonl files with vanilla js. But the lib would make exactly what I need to manipulate test data within these jsonl files. 👍


Bug Fix: Preview Text Scaling

Fixed The Preview Component's Text Scaling
See Issue #4 for more Details

LGTM


wasi: ensure the context used for _start is consistent

This adds StoreConfig.Context to centralize assignment of the initial
context used implicitly by the WebAssembly 1.0 (MVP) start function and
also the WASI snapshot-01 "_start" exported function. This also
backfills tests and comments around propagation.

thanks for the ⚡


UI - Cluster Awareness

NIFI-1947 NIFI-2082:

Making it more obviously when a nodes cluster state changes.
Showing which node is the cluster coordinator.

@mcgilman looks great - i was able to verify the behavior and merged to master.


WSL2-Linux-Kernel Headers

I would like Headers installation option in WSL2-Linux-Kernel , I'm trying to install a module (v4l2loopback) and it requires headers installed at /lib/modules/<IP_ADDRESS>-Microsoft-standard-wsl2+ . I searched online and they say wsl2 msft linux kernel doesn't come with headers , will normal linux headers from apt work?

@raheel103 you need to match the headers with the current running kernel. The easy way is to get the WSL kernel source from https://github.com/microsoft/WSL2-Linux-Kernel/releases, run make headers_install and supply  the correct INSTALL_HDR_PATH. It defaults to INSTALL_HDR_PATH=/usr so the kernel headers will be dropped in /usr/include. See details at https://www.kernel.org/doc/html/latest/kbuild/headers_install.html


[libfido2] New port

This PR introduces libfido2 as a new port

What does your PR fix?
-/-

Which triplets are supported/not supported?
*-windows

Have you updated the CI baseline?
no

Does your PR follow the maintainer guide?
yes

Hi @xgcssch
Thanks for your PR.
I also noticed that there was a new released version 1.7.0. So would you like to update it to the latest release in this PR?

Could you please also address the review suggestions?

Hello Nancy!
Sorry for the checkin with only the 1.7 update.
I haven't recognized the suggestions you made.
I am currently working on them.
Thanks

Hi Nancy!
I applied the suggested changes.
I've no idea, why the osx check is failing.
Best regards
Sönke

Hi Nancy!
I applied the suggested changes.
I've no idea, why the osx check is failing.
Best regards
Sönke

The failures on osx pipeline are not related with this PR, it due to disk space ran out. I will rerun this PR once solved.

Done!
The failing Tests are from a different package. Interesting.

The failures cause by popsift  will be fixed by #17277.

/azp run

LGTM now, thanks for adding this port @xgcssch.

Done!

Thanks for your contribution!


Update SQLite.swift

Is your feature request related to a problem? Please describe.
Our project uses Apollo and Amplify Swift. Both have dependencies on SQLite.swift
In Apollo's latest version, the SQLite.swift dependency requirement is now defined as .upToNextMajor(from: "0.15.1")
However, Amplify Swift's dependency requirement is exact: "0.13.2".
Describe the solution you'd like
Update Amplify Swift to support newer versions of SQLite.swift
Describe alternatives you've considered
As a work around, we can avoid updating Apollo for now.
Is the feature request related to any of the existing Amplify categories?
No response
Additional context
No response

@maxchuquimia Thanks for submitting the feature request.  We will prioritize the request and provide updates here.

@phantumcode Thanks for adding as feature request I am also facing same issue here, so waiting for a quick release for it.

@phantumcode please note that this is now more important because we need SQLite's XCPrivacy manifest in order to comply with Apple's new rules starting tomorrow.

@phantumcode Thank you for addressing this issue. We are encountering the same problem on our end as well. We require the use of SQLite 0.14.1 or a newer version.


[Bug] Unicode character ≪ gives parse error

The unicode character ≪ (U+226A) in KaTeX input currently gives a parse error, but it should be interpreted as \ll, just like ≫ (U+226B) is interpreted as \gg.

Same problem with ⋘ (U+22D8)

@Danmou,  Thanks for the note. I've just submitted PR #1273, which will fix this issue.

Isn't this fixed? #1273 has been merged.

@literallyvoid It's fixed in KaTeX master branch. It is not yet part of a KaTeX release.

I need to do a release.

Fixed by #1273.


Avoid GetLastError result raised from others.

It could raise the error from other methods. To specify the error from the method, I recommend to reset the LastError on Windows.
In addition, PIL.Image.Image.save() makes Windows Error 183 but automatically overwrite the file when the file has already existed.  The error from this method isn't deleted after executed.

From https://msdn.microsoft.com/en-us/library/windows/desktop/ms680627(v=vs.85).aspx :
Most functions call SetLastError or SetLastErrorEx only when they fail. However, some system functions call SetLastError or SetLastErrorEx under conditions of success; those cases are noted in each function's documentation.
From checking out the docs for mouse_event, it seems that it doesn't set the "last error", so really this code shouldn't be calling GetLastError() at all. Since mouse_event is deprecated, this code should be calling SendInput(), which does modify the last error. This would make this commit's addition of SetLastError() unneeded.
What we should probably do is call SendInput() to correct the original problem. Thanks for pointing this out! I'll open an issue for it.
SendInput doc:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms646310(v=vs.85).aspx


Multiple API Logins and Tokens

I am using FusionAuth as my OICD provider.  I have 3 Angular Apps along with  3 separate APIs (call them Tools, Accounts, and CRM).
All 3 angular apps need to actually query all 3 APIs.  If I visit the Tools Angular app, use OICD against FusionAuth to get my JWT, the JWT that comes back is for Tools only.  It has the Tools app ID, it has the "roles" in relation to the Tools app.  When angular hits the Tools API, the API sees the proper Tools roles from the JWT, all good.  But when the Angular app hits the Accounts API the JWT that is passed in of course is the Tools JWT with the Tools roles.
There are ways to handle this on the backend (API code).  For example the Accounts API would recognize the Tools app just tried to hit it therefore go back to FusionAuth to get the roles related to the Accounts app NOT the Tools apps.  In other words ignore the roles found in the JWT and query FusionAuth for the right roles.  But there are other issues with this, like logging to 3rd party APIs that are out of my control.  Those 3rd party APIs would be passed a JWT with roles for the Tools app, not their app.
How do people handle this?  Accessing multiple APIs from a single Angular app seems very common.  What if angular-oauth2-oidc could handle this.  When the Tools angular app is first loaded couldn't it login to all 3 FusionAuth apps via OICD and store each access token separately in session storage.  Then Angular would simply inject the proper token stored in session storage based on the endpoint it was calling.  Now each of the 3 tokens in session storage are for the right endpoint with the right roles for that endpoint.
Am I way off here?  I must be missing something.

The questions isn't which one is best or how to implement myself if needed.  The question is more about if this angular-oauth2-oidc plugin is capable of option #3 out of the box.  Looking at the code it appears it is not.  I chose option #1 where my Angular app gets a single token from the IDP but that token has all the claims (role strings in this case) that work with multiple backends.  So one token that can access multiple APIs and contains enough claims to satisfy each of the backends.

Thx for getting back to us, that might help others with similar questions!
(I do recommend other forums or (Q&A) platforms for this type of question though.)


Issue with running solaris exporter

I've installed everything as described in readme. No issues found during packages installation. However when I try to run exporter, I get following error:
bash-3.2# /opt/csw/bin/python2.7 solaris_exporter.py
Traceback (most recent call last):
  File "solaris_exporter.py", line 1039, in <module>
    REGISTRY.register(c)
  File "/opt/csw/lib/python2.7/site-packages/prometheus_client/registry.py", line 26, in register
    names = self._get_names(collector)
  File "/opt/csw/lib/python2.7/site-packages/prometheus_client/registry.py", line 66, in _get_names
    for metric in desc_func():
  File "solaris_exporter.py", line 440, in collect
    swap = psutil.swap_memory()
  File "/opt/csw/lib/python2.7/site-packages/psutil/__init__.py", line 1982, in swap_memory
    return _psplatform.swap_memory()
  File "/opt/csw/lib/python2.7/site-packages/psutil/_pssunos.py", line 158, in swap_memory
    t, f = line[3:4]
ValueError: need more than 1 value to unpack

bash-3.2# cat /etc/release
                    Oracle Solaris 10 1/13 s10x_u11wos_24a X86
  Copyright (c) 1983, 2013, Oracle and/or its affiliates. All rights reserved.
                            Assembled 17 January 2013

bash-3.2# uname -a
SunOS myhost.com 5.10 Generic_147148-26 i86pc i386 i86pc

Hello,
I think that something changed in psutil library in the lastest version. A year ago it worked.
Try to install an older version https://pypi.org/project/psutil/#history
pip install psutil==5.7.0

Thanks a lot. That solved the issue :)
bash-3.2# /opt/csw/bin/pip2.7 install psutil==5.7.0
Collecting psutil==5.7.0
Downloading https://files.pythonhosted.org/packages/c4/b8/3512f0e93e0db23a71d82485ba256071ebef99b227351f0f5540f744af41/psutil-5.7.0.tar.gz (449kB)
100% |################################| 450kB 1.0MB/s
Installing collected packages: psutil
Found existing installation: psutil 5.8.0
Uninstalling psutil-5.8.0:
Successfully uninstalled psutil-5.8.0
Running setup.py install for psutil ... done
Successfully installed psutil-5.7.0
bash-3.2# /opt/csw/bin/python2.7 solaris_exporter.py


add retry, skip-error, keywords options

add retry times option to retry when book download failed
add skip-error option to continue downloading the next book if the current book download failed
add keywords option to only download the book that match the keywords

Thank for you contribution. I will review this PR ASAP.

I plan to add the code tweak on your works. This PR is gona be merged soon.

@passos Thanks for your contribution. This PR has been merged.


ticdc: Removed error type detection in CheckIsTiDB

Different downstreams will have different error messages for "select tidb_version()". We cannot provide a complete error whitelist in CheckIsTiDB.
Considering that we just want to know whether the downstream is tidb, the specific error cause is not very important. Therefore, we can directly output error information for all errors instead of returning errors.

/found customer