Fix - App crashes when click on Category while creating Money request

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/36622
PROPOSAL: https://github.com/Expensify/App/issues/36622#issuecomment-1947005762
Tests

Precondition :

User is an employee of Collect workspace on Old Dot
"People must categorize expenses" is enabled

create a category with the text & in OD and disable the category
In ND as the employee come and sign out and sign in
On the workspace chat FAB -> Request -> enter amount -> Select category
close the request modal
As admin now disable in OD "People must categorize expenses"
As Employee Now in ND refresh the page and On the workspace chat FAB -> Request -> enter amount -> Select category
Verify App will not crash

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/38649957/370e596e-c361-4184-99bb-458a8ff63056

Android: mWeb Chrome

https://github.com/Expensify/App/assets/38649957/9a2d48db-f74a-4053-88d8-6173354af284

iOS: Native

https://github.com/Expensify/App/assets/38649957/ff14173f-695e-4290-9614-5043851e3200

iOS: mWeb Safari

https://github.com/Expensify/App/assets/38649957/ae1e3bcc-94ee-4e4a-82f4-d9db5434cb64

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/38649957/5314d3c5-9951-4d4d-8f61-dad7229277c6

MacOS: Desktop

https://github.com/Expensify/App/assets/38649957/7500dffa-19bf-4e73-ae64-3ad4a394b58b

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/59907218/05f0fe9f-43e9-434d-8cae-2efce35bfc55

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/59907218/70a70cf9-b057-40f3-b9b5-9d54a1b0a37c

iOS: mWeb Safari
https://github.com/Expensify/App/assets/59907218/b87ed2be-cc2f-483a-b708-db567145ad54

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/59907218/01c9f9f2-8be8-476c-8b06-4fdf95456cf5

MacOS: Desktop
https://github.com/Expensify/App/assets/59907218/d45a0d60-83b0-4f74-aae6-67f8852112bf

Tests were passing!


Clickable Link to Media

Would be really great to be able to click on a poster and have it take you that item's landing page in a configurable plex library.

The goal of Posterr is to display content, not be a menu to media. I understand where you are coming from, but this will be very difficult once i start  adding other media server options.


Writing Deck reviews

When you write a deck review only cards from the same side are supported automatically with #Cardname so as a corp this only works for corp card and you can't link that easy to runner cards e.g. like DNA Tracker as the runner.
This works well in card reviews and I assume is not that hard to implement.

I'm not sure what you mean by a "deck review", but it's certainly possible to tag cards from both sides in a comment on a published deck using # if that's what you mean?

Or do you mean in the description of a deck when you publish it? I think all you can do there currently is insert links with markdown, the # prefix doesn't seem to do anything there right now.

It works in the comments, but when you write it in Notes, it don't.

Create what ever deck go to Notes (which is used when publishing) and try to reference a corp card in a runner deck.


Fix SyncStatusTest UT detected memory leaks.

Signed-off-by: hehechen<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #6025
Problem Summary:
Fix SyncStatusTest UT detected memory leaks.
What is changed and how it works?
Free memory in UT.
Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/merge


Contact Page - Contact filter drop down is not disabled in project view in contact page

Describe the bug

Contact filter drop down is not disabled in project view in contact page
from list page don't give option for remove contact from filter
https://www.berrycast.com/conversations/51db37a9-6aa2-51e6-b2e2-040e862988c4

https://www.berrycast.com/conversations/9e11329e-0356-5284-8c28-99b4443c88da


⚠ File access has degraded performance

In 6d31622, File access (https://fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 3827 ms

Resolved: File access performance has improved in db89547 after 10 minutes.


support 3.0.0-beta-2

3.0.0-beta-2 is available a few days ago.
http://repo1.maven.org/maven2/com/google/protobuf/protoc/3.0.0-beta-2/

Released protoc-jar-3.0.0-b2

Thank you for the quick response :smiley:


Assigning to a hashref marked as an array with a qw containing the list of keys generates bad code

Assigning to a hashref marked as an array with a qw containing the keys generates bad code.  For example:
my $narg = {%$data};
@{$narg}{qw(device inode cwd prefix depth)} =
              ( $cur_dev, $cur_inode, $updir, $canon, $data->{depth} + 1 );

Fixed in v0.968


'NoneType' object has no attribute 'windows' when using cx_freeze

From pyglet, I only use this in my program:
import pyglet.font as pyf
pyf.add_file("fonts/Dosis-Regular.otf")
It runs fine (Python 3.8/Windows 10). But after freezing it with cx_freeze in order to get a standalone application, when I run my .exe, I get this error:

Traceback (most recent call last):
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet_init_.py", line 334, in getattr
return getattr(self._module, name)
AttributeError: 'NoneType' object has no attribute 'windows'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet_init_.py", line 334, in getattr
return getattr(self._module, name)
AttributeError: 'NoneType' object has no attribute 'get_default'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Jules\AppData\Local\Programs\Python\Python38-32\lib\site-packages\cx_Freeze\initscripts_startup_.py", line 40, in run
module.run()
File "C:\Users\Jules\AppData\Local\Programs\Python\Python38-32\lib\site-packages\cx_Freeze\initscripts\Console.py", line 37, in run
exec(code, {'name': 'main'})
File "snake_main.py", line 12, in
File "", line 259, in load_module
File "C:\Users\Jules\Desktop\Python\2020\Snake\snake_menus.py", line 15, in
import pyglet.font as pyf
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet\font_init_.py", line 67, in
from pyglet.font.win32 import GDIPlusFont
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet\font\win32.py", line 42, in
from pyglet.font import base
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet\font\base.py", line 45, in
from pyglet.gl import *
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet\gl_init_.py", line 243, in
import pyglet.window
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet\window_init_.py", line 1897, in
gl.create_shadow_window()
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet\gl_init.py", line 220, in create_shadow_window
shadow_window = Window(width=1, height=1, visible=False)
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet\window\win32_init.py", line 132, in init
super(Win32Window, self).init(*args, **kwargs)
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet\window_init.py", line 647, in init
app.windows.add(self)
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet_init_.py", line 340, in getattr
import(import_name)
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet\app_init_.py", line 128, in
event_loop = EventLoop()
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet\app\base.py", line 147, in init
self.clock = clock.get_default()
File "C:\Users\Jules\AppData\Roaming\Python\Python38\site-packages\pyglet_init_.py", line 340, in getattr
import(import_name)
ModuleNotFoundError: No module named 'pyglet.clock'

(Using cx_Freeze on my program worked fine before I used Pyglet.) I don't know if the problem comes from Pyglet or cx_Freeze.

It looks like the problem is that cx_Freeze is not including the pyglet.font module. You may have to force include pyglet.font in the appropriate cx_Freeze option.

Thanks for you reply. But cx_Freeze includes the pyglet.font module:

I just found the error, and it has nothing to do with pyglet, sorry: pywin32 was missing, that's why I got this error.


Issue getting rbenv to work on MacOS

Hi
I have macOS 10.12.4 and having issues getting started with rbenv via homebrew...
ruby -v

ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin16]

Installed homebrew:
/usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
brew -v

Homebrew 1.2.3
Homebrew/homebrew-core (git revision c88f; last commit 2017-06-13)

brew install rbenv
rbenv init
rbenv -v

rbenv 1.1.0

rbenv install 1.9.3-p551
rbenv versions

system (set by /Users/chrisoshea/.rbenv/version)
1.9.3-p551

rbenv local 1.9.3-p551
rbenv versions

system

1.9.3-p551 (set by /Users/chrisoshea/Documents/jekyltest/.ruby-version)

So far so good, this is where the trouble starts...
gem install bundler

ERROR:  While executing gem ... (Gem::FilePermissionError)
You don't have write permissions for the /Library/Ruby/Gems/2.0.0 directory.

which gem

/usr/bin/gem

I tried rbenv rehash.
Something weird about my path?
echo $PATH

/Users/chrisoshea/Developer/android-sdk-macosx/platform-tools:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin

No mention of rbenv in there. What else should I be trying? Thanks!

also
rbenv init -

export PATH="/Users/chrisoshea/.rbenv/shims:${PATH}"
export RBENV_SHELL=bash
source '/usr/local/Cellar/rbenv/1.1.0/libexec/../completions/rbenv.bash'
command rbenv rehash 2>/dev/null
rbenv() {
local command
command="$1"
if [ "$#" -gt 0 ]; then
shift
fi
case "$command" in
rehash|shell)
eval "$(rbenv "sh-$command" "$@")";;
*)
command rbenv "$command" "$@";;
esac
}

You're almost there! rbenv init gives you instructions about what you should do to configure rbenv for your shell. It doesn't do anything if you just run it and ignore what it says. If you read its output and follow its instructions, you should be good.

In the install notes it says: "You'll only ever have to run rbenv init once." Is that once per session, or once ever?
It still isn't working.
rbenv init
cd /Users/chrisoshea/Documents/work/jekyltest
rbenv local 1.9.3-p551
gem install bundler

ERROR:  While executing gem ... (Gem::FilePermissionError)
You don't have write permissions for the /Library/Ruby/Gems/2.0.0 directory.

When I run rbenv init, output is:

Load rbenv automatically by appending
the following to ~/.bash_profile:
eval "$(rbenv init -)"

So even if I call init each time, or add to bashprofile i'm still going to get the above permission error.
Confused by the instructions, thanks.

Looks like they had the same issue, it isnt clear that you need to add this to your bash_profile, maybe update the readme?
https://github.com/rbenv/rbenv/issues/815
by adding that line to bash_profile, rbenv is now in my PATH and installing gem works.

I'm glad you got it solved. The output of rbenv init says:

Load rbenv automatically by appending the following to ~/.bash_profile

and the line to put in your .bash_profile is the following:
eval "$(rbenv init -)"

and by doing exactly that, and restarting the shell, your shell is now configured for rbenv.
What should be made clearer in this process?

I think my confusion (and that other post) is that the docs say: "You'll only ever have to run rbenv init once."
Does that mean each time on terminal, or only once during install? That was the confusion. Maybe it should say a requirement is to add it to your bash_profile or something.
Thanks

@chrisoshea, updated docs @ #1009

and the line to put in your .bash_profile is the following:

How do you do that?

I was quite stuck for a while until I realized that rbenv init simply prints instructions and will always print the same instructions. (Please correct me if that's not true.)
I mistakenly expected the output of rbenv init to change after I had correctly added eval "$(rbenv init -)" to the .bash_profile.
Instead of trying rbenv init again, I needed to move on to the next steps in the readme instructions to confirm that I had completed the rbenv init step correctly.
I'm adding this note in case someone else reads above and is still stuck for the same reason.

@edamamegreen thank you for taking the trouble to record the above, I was stuck until I read it.  To reiterate for future readers, rbenv init will always output the same thing even once it is fully functional and the problem above is solved. You can check that it has worked by running the following command in terminal:
curl -fsSL https://github.com/rbenv/rbenv-installer/raw/master/bin/rbenv-doctor | bash
Once you have added rbenv to your path, the above command will confirm with the following output:
Checking for rbenv' in PATH: /usr/local/bin/rbenv
Checking for rbenv shims in PATH: OK`

I'm adding this note in case someone else reads above and is still stuck for the same reason.

Thank you


pyprland: 2.2.17 -> 2.2.20

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for pyprland is: An hyperland plugin system
meta.homepage for pyprland is: https://github.com/hyprland-community/pyprland
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.2.20 with grep in /nix/store/9d1rpsd962vp8kjrpz5syzxhzmqq1ifk-pyprland-2.2.20
found 2.2.20 in filename of file in /nix/store/9d1rpsd962vp8kjrpz5syzxhzmqq1ifk-pyprland-2.2.20

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

pyprland

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9d1rpsd962vp8kjrpz5syzxhzmqq1ifk-pyprland-2.2.20 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pyprland https://github.com/r-ryantm/nixpkgs/archive/67d63b0646f34e3dab018edf82af00983de8f5ab.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/67d63b0646f34e3dab018edf82af00983de8f5ab#pyprland

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9d1rpsd962vp8kjrpz5syzxhzmqq1ifk-pyprland-2.2.20
ls -la /nix/store/9d1rpsd962vp8kjrpz5syzxhzmqq1ifk-pyprland-2.2.20/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages built:

pyprland
pyprland.dist

Maintainer pings
cc @iliayar @johnrtitor for testing.

@NixOS/nixpkgs-merge-bot merge


.circleci: enable -coverpkg=all

We want to count test for coverage even irregardless
of where it is located. Previously error "no non-test Go files"
was preventing us from doing so. This commit fixes it.

I think Makefile and .travis.yml should also be changed this way. I expect to see the same coverage results in coverage.html as in codecov.

I am investingating, why there is strange link error on circleci which doesn't pop up locally.

Merging #852 into master will increase coverage by 3.72%.

Impressive.

It seems like test failing was because of OOM killer for .circleci workers.
With CGO_ENABLED=0 and a separate job for coverage without -race it works good.


Document edit page should have an always visible sidebar

Similar to Wordpress

The default tab would have the page information, always visible, including the publication status
Bring the "Download as JSON" button to the default tab
The sidebar should be resizable

I want to work on this issue. Could you please give me the information I need? @joncarlson


In a typescript file, I get an error, Request textDocument/references failed: "Cannot read properties of undefined"

Specifically on this branch: https://github.com/NullVoxPopuli/ember-resources/pull/513
in ember-resources/src/core/resource.ts around line 180, I tried renaming cache.
And got this error:
2022-06-03T20:22:33 ERROR Error while finding references: Request textDocument/references failed with message: Cannot read propert
ies of undefined (reading 'includeDeclaration')
2022-06-03T20:22:38 WARN No results from textDocument/references
2022-06-03T20:22:38 ERROR Error while finding references: Request textDocument/references failed with message: Cannot read propert
ies of undefined (reading 'includeDeclaration')
2022-06-03T20:22:38 WARN No results from textDocument/references
2022-06-03T20:22:38 ERROR Error while finding references: Request textDocument/references failed with message: Cannot read propert
ies of undefined (reading 'includeDeclaration')
2022-06-03T20:22:38 WARN No results from textDocument/references
2022-06-03T20:22:38 ERROR Error while finding references: Request textDocument/references failed with message: Cannot read propert
ies of undefined (reading 'includeDeclaration')
2022-06-03T20:22:38 WARN No results from textDocument/references
2022-06-03T20:22:38 ERROR Error while finding references: Request textDocument/references failed with message: Cannot read propert
ies of undefined (reading 'includeDeclaration')
2022-06-03T20:22:39 WARN No results from textDocument/references
2022-06-03T20:22:39 ERROR Error while finding references: Request textDocument/references failed with message: Cannot read propert
ies of undefined (reading 'includeDeclaration')

(history from nvim-notify)
which I think is from:
https://github.com/smjonas/inc-rename.nvim/blob/main/lua/inc_rename/init.lua#L23
the code that triggered the error:
class ResourceManager {
  capabilities = helperCapabilities('3.23', {
    hasValue: true,
    hasDestroyable: true,
  });

  constructor(protected owner: unknown) {}

  createHelper(Class: typeof Resource, args: ArgsWrapper) {
    let owner = this.owner;

    let instance: Resource<ArgsWrapper>;

    // right here, I tried rename on `cache`
    let cache: Cache = createCache(() => {
      if (instance === undefined) {
        instance = new Class(owner);

        associateDestroyableChild(cache, instance);
      }

      if (instance.modify) {
        instance.modify(args.positional, args.named);
      }

      return instance;
    });

    return cache;
  }

in lua files, works as expected

fixed! thanks!


Updated design_request.md

Fixes #22  🔐
Are you a part of LGM SOC' 21 ❓

[x] Yes ✔
[ ] No ✖

Describe the changes you've made 🏆
Enhanced the design_request.md file.
Type of change 🖇
Please delete options that are not relevant.

[ ] Bug fixing (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist: 📋

[x] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

There's a small thing, Those who have created PRs, for the last time create a new branch with your name and then raise a Pull Request.


Sending test messages fails because sender is empty.

When sending test messages using the provided interface, it always fails. I traced the error to being located in Endroid\CmSms\Client inside createMessagesJson. In line 119 there is an is_null($message->getFrom()) check, but the from field is set to an empty string when i dump the contents just before the check.
Symfony Version: 4.0.4
PHP Version 7.2.2

You're right. The getFrom() message always returns a string, never not null given its method signature. So the check should indeed be different. Now I check if the returned value is an empty string so it uses the default when the value is empty.


Button Color

Hi, Changing the color on runtime does not work.
thx

Hi, @Bill-Niz
Thank you for reporting the bug! :dancers:
https://github.com/ykyouhei/KYShutterButton/releases/tag/1.0.1


IdentityServerDev

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: vishaldeshpande sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


 Added documentation to support servicenow click to dial

Description

Added documentation to setup service now click to dial

Checklist
Please ensure that you have completed the following tasks before submitting this pull request:

[x] I have updated the documentation or README if necessary.
[ ] My code follows the project's coding style guidelines.
[ ] My changes are self reviewed

Screenshots (if applicable)
If your changes include UI/UX modifications or additions, please include relevant screenshots here.
Additional Notes
None

Let's merge this PR as a first version and resolve comment via another PR later so that we can already start to share this to customer and refer to it.


cmd/vet: check for tautological comparisons

Report expressions such as:
if a.someLongField != a.someLongField { ... }

Wouldn't that depend on the type of a.someLongField? If it's a float, for example, that's not tautological (because of NaN).

Dup of #15586


Select name used for formal name

This issue is imported from pivotal
After linking an account, ask the user to use name from this link as his formal name.

Add the preference to the account-link in the database

Show the new information, after linking the account, before overwriting
design vs current version in the screenshots below.
Also : remove the scrollbars in the model-display
(Peter Havekes - Oct 13, 2023)

Display the  actual information (Okke Harsta - Oct 13, 2023)

https://github.com/OpenConext/OpenConext-myconext/commit/a308ce8c520a32cdeb04df0d6ec4ea51eb69c9a9 (Okke Harsta - Oct 14, 2023)

First account linked modal (Okke Harsta - Oct 14, 2023)

Second account linked modal (Okke Harsta - Oct 14, 2023)


DCOS_OSS-5243 Remove unused ssh library from installer

High-level description
What features does this change enable? What bugs does this change fix?
After doing the previous task and removing the deprecated code in the dcos_installer directory, we can now remove the SSH library in dcos/ssh.
Corresponding DC/OS tickets (required)

DCOS_OSS-5243 Remove the now-unused SSH library in DC/OS

Related tickets (optional)

DCOS-ID JIRA title / short description.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): no changelog because only internal changes
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot label Ready for Review

Thanks @mrnugget for laying the ground to getting this done!

Thanks @mrnugget for laying the ground to get this done!

You got it! (☞ﾟヮﾟ)☞


chore: updates deps and cuts 0.9.0 release

I realized when I went to go updates deps that we never cut the 0.9.0 release after all those major changes! This PR attempts to fix that :wink:

Since this is a minor change I'm going to merge ;)


On startup, omnisharp.cmd cannot be found if username includes spaces

Here is the corresponding output from the Omnisharp console in Atom
Errors & WarningsOmnisharp output
Starting OmniSharp server (pid:3760)
OmniSharp Location: C:\Users\Fname Lname.atom\packages\omnisharp-atom\node_modules\omnisharp-client\roslyn\omnisharp.cmd
Change the location that OmniSharp is loaded from by setting the OMNISHARP environment variable
OmniSharp Path: C:\Users\Fname LName\Documents\Github\test\WebAPIApplication
'C:\Users\Fname' is not recognized as an internal or external command,
operable program or batch file.

looks like a client issue... wonderful, I'll try and tackle this asap.
On Wed, Aug 12, 2015 at 7:32 PM, Kyle Brennan<EMAIL_ADDRESS>wrote:

Here is the corresponding output from the Omnisharp console in Atom
Errors & WarningsOmnisharp output
Starting OmniSharp server (pid:3760)
OmniSharp Location: C:\Users\Fname
Lname.atom\packages\omnisharp-atom\node_modules\omnisharp-client\roslyn\omnisharp.cmd
Change the location that OmniSharp is loaded from by setting the OMNISHARP
environment variable
OmniSharp Path: C:\Users\Fname
LName\Documents\Github\test\WebAPIApplication
'C:\Users\Fname' is not recognized as an internal or external command,
operable program or batch file.
—
Reply to this email directly or view it on GitHub
https://github.com/OmniSharp/omnisharp-atom/issues/466.

This was fixed on the server here https://github.com/OmniSharp/omnisharp-roslyn/releases/tag/v1.3.0 so should be coming to Atom soon

Thanks for the heads up, Jason!

I have the same issue as kylo101.
I'm working on Win8.1, Atom version:1.4.3, Omnisharp-atom package version:0.26.11.
I did what message says to me: "Change the location that OmniSharp is loaded from by setting the OMNISHARP environment variable"
So I made environment variable (OMNISHARP) with path in question marks - Win needs it to expand path with spaces, but I've got the belowed error:
events.js:141
throw er; // Unhandled 'error' event
^
Error: spawn "C:\Users\Fname Lname.atom\packages\omnisharp-atom\node_modules\omnisharp-client\clr\run.cmd" ENOENT
at exports._errnoException (util.js:837:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
at onErrorNT (internal/child_process.js:344:16)
at doNTCallback2 (node.js:441:9)
at process._tickCallback (node.js:355:17)
at Function.Module.runMain (module.js:477:11)
at startup (node.js:129:18)
at node.js:981:3

Yeah I need to figure out how to get node to behave, I'll see if I can look at this shortly.

I don't know if it helps, but when I changed run.cmd with stright foreward values
for example: DNX_PATH as
"C:\Users\Fname Lname.atom\packages\omnisharp-atom\node_modules\omnisharp-client\clr\runtimes\dnx-clr-win-x<IP_ADDRESS>-rc2-16444\bin\dnx.exe"
I have got this ugly exception when I run this script:

System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.AspNet.Server.Kestrel' or one of its dependencies. The system cannot find the file specified.
File name: 'Microsoft.AspNet.Server.Kestrel'
at System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
at System.Reflection.RuntimeAssembly.nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
at System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
at System.Reflection.Assembly.Load(AssemblyName assemblyRef)
at Microsoft.AspNetCore.Hosting.Server.ServerLoader.LoadServerFactory(String assemblyName)
at Microsoft.AspNetCore.Hosting.Internal.WebHost.EnsureServer()
at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
at Microsoft.AspNetCore.Hosting.WebHostBuilder.Build()
at OmniSharp.Program.Main(String[] args)
at Program.Main(String[] args)
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at Microsoft.Dnx.Runtime.Common.EntryPointExecutor.Execute(Assembly assembly, String[] args, IServiceProvider serviceProvider)
at Microsoft.Dnx.ApplicationHost.Program.<>c__DisplayClass3_0.b__0()
at System.Threading.Tasks.Task`1.InnerInvoke()
at System.Threading.Tasks.Task.Execute()
WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].


Issues compiling current master branch from source

Hi everyone,
I just tried compiling the current master branch source and I am getting the following compilation error:
pyscf/lib/gto/ft_ao.c:138:18: error: ‘CART_MAX’ undeclared (first use in this function); did you mean ‘RAND_MAX’?
int i_nx[CART_MAX], i_ny[CART_MAX], i_nz[CART_MAX];
^~~~~~~~
RAND_MAX
Looks like CART_MAX definition was removed in 392b827491e7c0b9b13b1283a3deb97ab79e482f (PR #930). Defining CART_MAX solves the problem. I used GCC 7.3.0 for the compilation.

You probably need to upgrade libcint. Remove libcint in lib/deps and the
downloaded source in build/deps and recompile should work.
Alexander Sokolov @.***>于2021年6月3日 周四上午9:25写道：

Hi everyone,
I just tried compiling the current master branch source and I am getting
the following compilation error:
pyscf/lib/gto/ft_ao.c:138:18: error: ‘CART_MAX’ undeclared (first use in
this function); did you mean ‘RAND_MAX’?
int i_nx[CART_MAX], i_ny[CART_MAX], i_nz[CART_MAX];
^~~~~~~~
RAND_MAX
Looks like CART_MAX definition was removed in 392b827
https://github.com/pyscf/pyscf/commit/392b827491e7c0b9b13b1283a3deb97ab79e482f
(PR #930 https://github.com/pyscf/pyscf/pull/930). Defining CART_MAX
solves the problem. I used GCC 7.3.0 for the compilation.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pyscf/pyscf/issues/969, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCZ6FTN67I6SUN7MHTWWSTTQ6UGBANCNFSM46BDWFRA
.

Recompiling libcint solves the problem. Thanks!


Add findsubdomains.com as a source

Add code to query findsubdomains.com.
Requires SPYSE_API_TOKEN environment variable set

Wrong API-endpoint being used :(


Error with angular 8 i am try to use ngx-treeview ver.10.0.2

I found this issue when trying to use ngx-treeview ver.10.0.2  with  angular 8 so please is it compatible together and if not what is the compatible ver. with  angular 8
ERROR in node_modules/ngx-treeview/lib/components/treeview/treeview.component.d.ts:24:9 - error TS1086: An accessor cannot be declared in an ambient context.
24     get hasFilterItems(): boolean;
~~~~~~~~~~~~~~
node_modules/ngx-treeview/lib/components/treeview/treeview.component.d.ts:25:9 - error TS1086: An accessor cannot be declared in an ambient context.
25     get maxHeight(): string;
~~~~~~~~~
node_modules/ngx-treeview/lib/directives/dropdown.directive.d.ts:6:9 - error TS1086: An accessor cannot be declared in an ambient context.

I have the same issue running Angular 8. Also installed is "tslib": "1.10.0"

Im getting same error. any news on this?

Any update for that above issue i'm getting same issue.

I am also running into this issue.

import { TreeviewModule, TreeviewEventParser, OrderDownlineTreeviewEventParser } from 'ngx-treeview';
import that is specific component module for ex.tree.component.ts and tree.module.ts import that package in tree.module.ts

this is the fix, you should close this one!

Hi, I had the same issue, I only did close my visual Code and then I would verify that library imported correctly. you can try this and tell me if you could resolve it

i resolved adding : "skipLibCheck": true  on tsconfig.json file for my project . I am using it correctly with angular 8

i am facing same
`- error TS2305: Module '"../../../../../../../../../../../Development/Sprint/Ng-Changes-9/RestaurantIntranet/RestaurantIntranet.WebUI/ClientApp/node_modules/ngx-treeview/ngx-treeview"' has no exported member 'TreeviewI18nDefault'.
1 import { TreeviewItem, TreeviewSelection, TreeviewI18nDefault } from 'ngx-treeview';`


Add dockerfile

This would make it trivial to deploy a doh-proxy container.

That container is a both huge (an entire Linux distribution just for one executable file?) and a little bit too minimal.
People familiar with Docker can easily build and customize such a container. But it's not really useful by itself, and doesn't install a running DoH service.
A container to run a working DoH service requires more pieces: a recursive DNS server, a web frontend, integration with Let's Encrypt or some other ways to install and rotate certificates, something that prints the configuration for using it, monitoring scripts, etc. Similar to the dnscrypt-server container.
In fact, support for DoH will eventually be added to that one. The tricky part being writing the eBPF/XDP code so that both DNSCrypt and DoH can share port 443. If you're familiar with this, your help would be more than welcome!
PS: Rust executables can be compiled and installed in one command with cargo install --path . --root ....

The container is 15.3MB, about 2/3s of that is the doh-proxy binary. The reason I can't use cargo install is because this is a multi stage build.
I'd argue that a container should only host a single service. acme should be done either by a second container, a tls termination proxy or by doh-proxy itself. A dns recursor should also run in its own container.

For our usecase, we'd like to run this in a kubernetes cluster, where the SSL termination is done by our load-balancer.


Lost the message of 'eligible FLOW to send' in the send tokens transaction

When a user tries to send FLOW tokens, they are only eligible to send their unlocked FLOW. We were showing a message previously that told them how much eligible FLOW that had to send. (you have # unlocked flow to send).
It looks like we have lost that message :(

Fixed. Closing.


Usage tracking

I want to go over this again but putting up for review now (it also needs more tests and better docs).
This adds a Usage model and utilities for tracking various kinds of usage. Usage is tracked against a source object e.g. experiment session, a service object e.g. an LlmProvider instance, and a type.
Currently I'm only tracking LLM token usage but in future we can track usage of other services e.g. TTS etc.
Initially I had the code to record usage at the point of use (or near) but that introduces a lot of boilerplate code that needs to be managed. Instead I decided to track the usage at the service level so that any usage of the service will result in usage being tracked:
session = ...
llm_provider = ...
service = llm_provider.get_llm_service()
chat_model = service.get_chat_model("gpt-4")

with service.record_usage(session):
    chat_model.invoke("hi")

Token counters
Prior to this PR we used langchains classes for token counting. This moves away from that to our own implementation (still does the same thing at the end of the day). The reason being that the langchain counters are cumulative where we needed finer grained control. Also, having the counters under our control gives us more flexibility e.g. using Anthropic values returned from the API instead of doing the counting manually.

I'm going to put this on hold for now. It needs some more design thought and is taking longer than I expected. I'm going to shift focus to getting some quick and dirty features for our current billing needs.


Will the new knives be available?

Title says all, oh and btw Panorama is now compulsory to use

You can still use scaleform, just put -scaleform in your launch settings

Just wait
Add them yourself
Use scaleform by putting -scaleform in your launch options

Ok thx

Why not add the new knives in yourself there is a thread on UC

Now.

Hahaha XD Thanks man!!!!


Problem with NewCInterface macro

Hello,
When I create project with NewProject macro and make project, I will get error:
error: ‘void operator delete [](void*, size_t)’ is a usual (non-placement) deallocation function in C++14 (or with -fsized-deallocation) [-Werror=c++14-compat]
I fix this by adding switch -fsized-deallocation, then I create new c interface with NewCInterface macro, I will get error
cc1: error: command line option ‘-fsized-deallocation’ is valid for C++/ObjC++ but not for C [-Werror]
How can I fix this?
With regards,
Esko

I found resolution, I have to add sized-deallocation switch with this:
CPPUTEST_CXX_WARNINGFLAGS=-fsized-deallocation


lxd/storage: Re-introduce cluster distributino of volume snapshots

Closes #8680
Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

Testsuite passed

@stgraber I think @monstermunchkin is already working on this here https://github.com/lxc/lxd/pull/8672
It was removed by another recent commit in 4.13, however we also noticed that as it is its also triggering a cluster heartbeat through the use of getting the node status which seemed inefficient if you didn't have any remote volumes so its being refactored to avoid it.

I'd appreciate your thoughts on the other PR, as the way I read this restoration of the original code, it seems like it could lead to some local volumes being skipped on their local node and being erroneously done on an invalid remote node.

I'll need to look into this closer but having things as broken as before would be a good step up compared to the current state of things where my cluster is snapshotting everything 3 time at the same time which on ceph means freezing filesystem access and causing massive load spikes across the cluster and taking down services.
This is the source of the recent issues with the image servers as it keeps freezing the volumes related to the image publishing.

@stgraber OK I'll merge this one now then. I'm pretty happy with the @monstermunchkin one too, there were just a couple of minor suggestions about  logging errors.


Given, When, Then descriptions

Hi,
I really love the Given, When, Then approach to splitting up your tests, but a huge part of why this is so useful in other frameworks is that it gives you the ability to describe the actions in a human readable way. It would be great if we could add an optional description string that then gets reported in the test results. For example
describe("assigning stuff to this", function() {
Given("I have the number 24", function() { this.number = 24; });
Given("I increment by one", function() { this.number++; });
When("I multiply by two", function() { this.number *= 2; });
Then("I should get 50", function() { return this.number === 50; });
});
Then it would be good to see in the test results something like this
assigning stuff to this - Passed
----- Given I have the number 24 - Passed
----- Given I increment by one  - Passed
----- When I multiply by two  - Passed
----- Then I should get 50  - Passed
Or ideally replace subsequent actions with And
assigning stuff to this - Passed
----- Given I have the number 24 - Passed
----- And I increment by one  - Passed
----- When I multiply by two  - Passed
----- Then I should get 50  - Passed

Sorry, @nitro52 but I'm :-1: on this. When @jimweirich designed rspec-given, a big part of his motivation was a rejection of the english-language-to-code translation made popular by Cucumber & RSpec. The reason is pretty straightforward, because in practice after you're comfortable writing a lot of tests you see these descriptors used in one of two ways:
First way:
it('should add 2 and 2 and get four', function(){
  expect(2 + 2).toEqual(4);
});

In the above, the text adds absolutely nothing, the code is readable, and if anything the text is a liability/carrying cost (just like a code comment is) in that it could become incorrect without anyone noticing in the future.
The other thing you see:
it('should send our accountants the TPS report for June', function(){
  expect(sillyNonsense("2138-GPL-4i2").functoCode).toEqual("sent");
});

In this case, the text description is a coping mechanism around a junky API that's unclear and not helpful. Rather than give ourselves the salve of a textual description to paper over our obtuse & confusing API, the goal of -given libraries is to make that un-obviousness stick out like a sore thumb.
That way, as a developer when I read a test that says:
Then ->  sillyNonsense("2138-GPL-4i2").functoCode == "sent"

I'm rightfully left scratching my head when I read the above, and hopefully driven to clean the API up tremendously to make it say what it's doing in a meaningful way.

@searls I'm kinda inbetween, and I think @nitro52 might actually be on to something...
I agree with Then { expect(2+2).toEqual 4 }  and that's what I do pretty much 100% of the time.  But that said, the current code does allow you provide labels to Then clauses if you really want to (https://github.com/searls/jasmine-given#it-style-test-labels).  I never bother with it, since I'd just as soon look at the ugly code as have to make up words.
Looking though at Givens and Whens, I have found that I do still have to type a bunch of words for contexts.  Standard pattern is
context "given foo is true", ->
  Given -> @foo = true

  context "when I click on a bug", ->
      When -> $.find(".bug").click()

Since words are still needed to describe what's happening with the Given's and When's, maybe something like @nitro52's proposal could make that cleaner?  This does actually seem cleaner:
context ->
    Given "foo is true" -> @foo = true

    context ->
      When "I click on a bug", -> $.find(".bug").click()

      Then -> expect(@happiness()).to beTrue

And once we've done that...  There are some times the Given or When code is clear and terse, and then you should be able to leave off the label and it'd be autogenerated same as for Then's.  E.g.
context ->
    Given -> @foo = true

    context ->
      When "I click on a bug", -> $.find(".bug").click()

      Then -> expect(@happiness()).to beTrue

would autogenerate
--- Given @foo = true
  --- When I click on a bug
    --- Then expect(@happiness()).to beTrue

And voila!  A step closer to the utopian ideal of English-free tests!
BTW another benefit to allowing labels everywhere is that it will make the library and methodology more accessible to newbies.  I suspect many people who first encounter Given/When/Then, either here or in @jimweirich's rspec gem can be put off by the lack of text labels.  In fact one of the first things I did was submit a PR to allow them, which @jimwerich rejected.   I think that's actually being overly principled.... it does little harm to allow people to use them (trivial code addition), and provides a gentle introduction to Given/When/Then.  And many people (like myself) would quickly enough discover that their English labels aren't necessary, and laziness (if nothing else) would take over and they'd stop bothering, and their tests would become better.  That's what happened to me, anyway.

I appreciate your perspective @ronen, particularly because you acknowledge the multiple a-ha moments that might come as someone grows comfortable with this testing style. My view on this (and partly b/c I've been thinking through https://github.com/testdouble/testdouble.js) is that one benefit of being a little, hyper-opinionated contender is that the message is clearer when it's sharper and pointier.
Put a different way, if rspec-given hadn't been so strict, it wouldn't have prompted me to ask Jim "hey, why can't I do this?" And in every case he'd already considered my thing, shot it down very kindly, and while my ego was bruised it was usually something I came around to.
In short:

I'd remove the Then/And description / label option if I could without breaking back-compat
If you really want to, you can provide a Given "whatever you want", ->  right now, and it'll just set this["whatever you want"] to whatever the function evaluates too. There's not a reporter for that, but I don't think the tool will blow up if you insist.
I actually like having the english language show up in those context calls like you have above because explaining the context of the test is exactly what's not communicated by the code, and usually the one place where it's helpful.

Thanks for chiming in. I appreciate your perspective and it made me pause for sure.


fix(website): not loading font awesome script

The build failed because of firebase something 😬

The build failed because of firebase something 😬

Yes, it will be fixed soon, don't worry


LocalDiskClaim  can be auto- created?

Hwameistor is installed, but  LocalDiskClaim is still installed by manual ,it can be optimized to be anto-installed

@qiupingdai thanks for your feedback.
You can see https://hwameistor.io/docs/quick_start/install/storage_pool.


Add (string) list and list operation to global command data

This means that for example quotes or previous runs can be added.
There should be a plugin to:

Get list size
Get list element
Remove list element
Add list element

Random list elements or clearing the list should be possible with the current elements

Implemented in version v1.0.27 (4ac036334da19c5be020f7217341a7f54f465959)


Request: A docker image with duet

Hi
While this program looks quite promising, we're encountering several problems trying to install the required software to make duet run.
Would it be possible to provide a docker image with duet and its runtime environment?
-Harald

Hi Harald,
Many thanks for using Duet. Duet has a unique feature to phase SVs so that it requires many additional dependencies to make it happen. Sometimes the environment may fail to solve, especially when there are many packages installed.
Could you please try create a separate clean env and install duet? It may also take a while to complete.
Let me know if you have other questions.
Thanks,
Yekai

I will agree that your package is unique and offers something that no other package on the market has-- phasing for long read callers besides pbsv. It is an excellent tool-- no lie. But, having made a package with 129 dependencies that was difficult for others to install a few years ago... I get where he is coming from. I think a docker package could really help adoption. deepvariant and nanocaller both use this to help their userbase. It would go a long way to making your program more used, and eliminate your need to update it. I think it will help all parties involved. I'll try to make one, but I have my own errors with clair3 I'm working through.

@jamesdalg @haraldgrove Thank you for your interests in Duet. I will try to make a docker image.
@jamesdalg You can post your issue of Clair3 at https://github.com/HKU-BAL/Clair3/issues if you are also using Clair3. Duet and Clair3 are ran by the same lab.
Yekai


Link to zf-component-installer 404

The link https://github.com/zfcampus/zf-apigility-doctrine#zf-component-installer in the Readme to the zf-component-installer is 404: https://github.com/zendframework/zf-component-installer
It appears it should be https://github.com/zendframework/zend-component-installer

Thanks @MECU! It is fixed now.


stop_words Invalid problem and infilling function

Hi，Dear：
When can latest release version be released to completely solve the problem that stop_words does not take effect ?
Another question is, does the current version support infilling ？
Looking forward to your reply！
thank you！

When can latest release version be released to completely solve the problem that stop_words does not take effect ?

Could you explain what problem do you encounter? It works well on our testing.

Another question is, does the current version support infilling ？

Can you explain more about infilling?

When can latest release version be released to completely solve the problem that stop_words does not take effect ?

Could you explain what problem do you encounter? It works well on our testing.
The problem with stop_words is that it only works on the main branch?

Another question is, does the current version support infilling ？

Can you explain more about infilling?
infilling: Fill in the code in the middle，such as input="import numpy\n<FILL_ME>\nc=a+b", output="import numpy\na=np.array([0,1]);b=np.array([2,3])\nc=a+b"

thank you!

I feel it is a capability of model but not inference framework.

I feel the infilling is a capability of model but not inference framework.
You're right, codellama already has this capability, but tensorrt or triton should have some pre-processing and post-processing capability for this type of scene, so that I can input "import numpy\n<FILL_ME>\nc=a+b" and output "import numpy\na=np.array([0,1]);b=np.array([2,3])\nc=a+b". Because this is a very general scenario, like vllm has implemented it

Shouldn't the input is "import numpy\n<FILL_ME>\nc=a+b", and the full output (+<generate_tokens>) is like
import numpy\n<FILL_ME>\nc=a+b import numpy\na=np.array([0,1]);b=np.array([2,3])\nc=a+b

Besides, please notify your format to prevent fuse the content you want to refer and your content for reply.

Shouldn't the input is "import numpy\n<FILL_ME>\nc=a+b", and the full output (input+generate_tokens) is like
import numpy\n<FILL_ME>\nc=a+b import numpy\na=np.array([0,1]);b=np.array([2,3])\nc=a+b

Besides, please notify your format to prevent fuse the content you want to refer and your content for reply.

Thank you for your reply, you can take a look at codellama's concept of infilling, format is： prefix-code  infilling code suffix-code. The model-codellama does realize this function, but it also needs inference framework for pre - and post-processing and output.

Then it does not supported in TensorRT-LLM now. But you could try modifying the pre/post processing because all of them are python codes.

Then it does not supported in TensorRT-LLM now. But you could try modifying the pre/post processing because all of them are python codes.

I got it, thank you!
Another thing is that I have updated tensorrt-llm to the latest version, stop_words has been solved when stop_words is plain string, but it is invalid when stop_words is ’\n‘, is there a solution?

related to https://github.com/triton-inference-server/tensorrtllm_backend/issues/128


refactor(multiple): switch to non-deprecated MDC list styles

Switches the components in mdc-autocomplete, mdc-core, mdc-menu and mdc-select to the non-deprecated MDC list styles.
Note for reviewer: merging this is currently blocked, because it depends on one change that isn't in the latest canary version. Once the change is released, I'll bump the version and unblock merging. The code can still be reviewed.

Caretaker note: in the process of migrating the styles for mdc-menu I noticed one places which didn't have the correct markup, causing the menu items to have bold text. I've corrected it here, but it may cause some screenshot diff failures. If it's problematic, I can split the markup fix into a separate PR.

@crisbeto is this available in canary now?

It's not available in canary yet. It's waiting for https://github.com/material-components/material-components-web/pull/7021.

Unblocking this since the necessary changes are in the canary branch now.

FYI, I had to lock us to a specific canary version, because having the caret in the version caused yarn to install an older canary version of MDC for some reason.


Rename Java Gradle Plugin Development Plugin

We refer to this plugin with a number of names:

the "Java Gradle plugin development Plugin" (in user guide)
the java-gradle-plugin (build scripts)
we also call it the "java plugin plugin" (when talking about it)

This is problematic because the name is long and confusing. For example the plugin should have nothing to do with "Java," as the plugin under development could be written in Groovy or Kotlin, too.
Proposal:

call the plugin the "Gradle plugin development plugin" in the user guide (without "Java")
rename the plugin ID to "plugin-dev"
call it the "plugin-dev plugin" when talking about it

I think the idea was to indicate that the plugin automatically applies the Java plugin. If we'd follow that logic then we'd also need to have another plugin for Kotlin- or Groovy-based plugins. Generally speaking, the plugin helps with developing JVM-based plugins. Given that all plugins are written in a JVM language there's no need to indicate it specifically. If users want to write a Groovy-based plugin then there's no harm in applying the Groovy plugin. I am not aware of any conflicts between the Java plugin and the Jetbrains Kotlin plugin.

To rename it, we should separate the assumption in the plugin that Java will be used as an implementation language. Currently, it is a plugin for implementing Gradle plugins in Java.

To rename it, we should separate the assumption in the plugin that Java will be used as an implementation language.

IIRC, the awkwardness in doing this at the time of this plugin's inception (or perhaps, lack of willingness to invest at that time) is the reason why it is the way it is.

Right. Part of that awkwardness was the state of the software model at the time, I think. This is much clearer now and the investment would be much smaller.
But it's still an investment. I would like to see what patterns and infrastructure come out of the native work before shuffling around the JVM plugins in this way.


Shoring up the exclusivity diagnostics.

Make sure that various SIL patterns can't create holes in the exclusivity model.

@devincoughlin can you take a quick look. Rather than parsing the diff, I think it's best just to read the code that handles noescape closures. It's all in one section of the file, about 250 lines, from
+// =============================================================================
 +// The data flow algorithm that drives diagnostics.

to
+// =============================================================================
 +// Verification

@swift-ci test.

@swift-ci test source compatibility.

@swift-ci test.

Build failed
Swift Test Linux Platform
Git Sha - aaf56629e93223620a61c4d202e6bfc3febe37be


Ddcyls 2109b

I attempted to update sbt and scala versions but I would then get the play fsm error. Because of this I decided to ignore those suggestions from PR bot


Incorrect 1-4 pair generation in Molecule._get14pairs() method for 5-atom rings

The function Molecule._get14pairs() generates 1-4 pairs of atoms based on molecule torsions. However, this approach can produce incorrect results in certain scenarios. For example, in a 5-atom ring ( ..(E)-A-B-C-D-E-(A)..), there is an A-B-C-D torsion. However, atoms A and D are connected through 2 bonds via atom E, making it a 1-3 interaction, not a 1-4.
This leads to incorrect [pairs] section in the GROMACS ITP file. Consequently, 1-3 interactions are mistakenly treated as 1-4 interactions, resulting in inaccurate simulations. I suspect this bug is also the root cause of the issues reported in Issue #20.
I checked this behavior using the LigParGen web server, and it correctly identifies 1-4 pairs without this bug.

Hey Vladimir,
You are absolutely right. I have fixed the issue, and the code should now work properly. Thank you for reporting it.


Users join referral program

As a user I want to join the program so I can invite new users and collect rewards.

Please review and comment here: https://www.figma.com/proto/SRRHyBuXcHKbh0WgzodOj6/Proton-Material-2-UI-PRO?page-id=60017%3A0&node-id=60017%3A1&viewport=499%2C1217%2C0.7748788595199585&scaling=scale-down


How to get the prediction output seperately?

Hi,
I want to know is there a function that I can output the prediction for each smiles,
for example:
smiles,class
O1CC[C@@H](NC(=O)[C@@H](Cc2cc3cc(ccc3nc2N)-c2ccccc2C)C)CC1(C)C,1
I want the prediction of this smiles (0 or 1)
Thank you.

Hello,
Thank you for your interest in our work. If you want to get the prediction for a specific SMILES, you can use the predict function.

with torch.no_grad():
    batch_preds = model(step, prompt, batch, features_batch)
batch_preds = batch_preds.data.cpu().numpy()

Here, batch refers to the batch of molecules you input, and batch_preds represents the prediction for each molecule in the batch. You can modify and print the input and output of this function according to your needs.
I hope this helps!


Crazy Rumble, count-down bugged.

BakkesMod Version: 172
Epic Version: BC2_Update39.1+401801
RocketPlugin Version: 0.7.2
Describe the bug
When i turn on rumble and crazy rumble to play crazy rumble when the timer hits 0 it goes back up to the starting number (1, 2 , 3 , 4 , 5 , etc)
To Reproduce
Steps to reproduce the behavior:
Turn on rumble in rocket plugin

go to gamemodes
Turn on crazy rumble
Start the game
In the bottom right it will go back up to the starting number

Expected behavior
It is supposed to let you use the item and not go back up to the starting number when it hits 0.
Screenshots
Rocket.League.64-bit.DX11.Cooked.2022-09-05.19-50-10.zip

I can't replicate the issue on my side, does this happen every time you start a match or just ones and does it also happen when you select 'rumble' in the 'game modes' drop-down above 'map' instead of enabeling rumble in the mutators settings?


Added docker quick-start example to README.

Please note that for legal reasons we require you to sign the
Contributor Agreement
before we can accept your pull requests.

Added to #10449


Extension UI should allow configuring the frontend

Recently the extension added a frontend link ("Manage Portfolio"). This is great. However, we should allow users to configure their default frontend along with their RPC settings.

In the connected sites settings page, there is a ⭐ that can be used to do that. But maybe this isn't super clear. Hmm...

Ahh, I see. I think that's probably reasonable.


[NFC] TypeLowering: Strengthen assertion.

Now that verification bails out on the top level in the face of types with type parameters, there's no need to bail out when visiting leaves.

@swift-ci please test


The paper of cross self-attention in Transformer?

❓ Questions and Help
Before asking:

search the issues.
search the docs.

What is your question?
I cannot find the paper of cross self-attention in Transformer.
Code
# args for "Cross+Self-Attention for Transformer Models" (Peitz et al., 2019)

What have you tried?
What's your environment?

fairseq Version (e.g., 1.0 or master):
PyTorch Version (e.g., 1.0)
OS (e.g., Linux):
How you installed fairseq (pip, source):
Build command you used (if compiling from source):
Python version:
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:

OK got it. https://github.com/pytorch/fairseq/files/3561282/paper.pdf


Update @babel/parser (to support TypeScript 4.7)

To support TypeScript 4.7, update @babel/parser and prettier.

@byara Could you please release this?


Use jest-axe for automated accessibility tests

Feature Description
We already use a similar package, @wordpress/jest-puppeteer-axe, for E2E tests and it can be quite useful there.
With jest-axe we enable automated accessibility scans for smaller units during tests.
Using it together with React Testing Library is documented as well:
https://github.com/nickcolley/jest-axe#testing-react-with-react-testing-library

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

PR as a base: #2810


Update dtls max version for dtls1.3

Another dtls 1.3 specific update. It is dependent on https://github.com/openssl/openssl/pull/22259

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 92 days ago

Test failures are relevant. We need to merge a couple of other PR's before this is working.

Test failures are relevant. We need to merge a couple of other PR's before this is working.

Will those failure go away with a rebase now?

Test failures are relevant. We need to merge a couple of other PR's before this is working.

Will those failure go away with a rebase now?

No. We need https://github.com/openssl/openssl/pull/22364 to be merged first. Which is dependent on https://github.com/openssl/openssl/pull/22366.
And then I expect there are some test cases that needs to be limited to DTLS 1.2 for it to work. I'll add that work to this PR to fix the pipeline.

@t8m @mattcaswell
A quick update on this.
Please prioritise reviewing the following:
https://github.com/openssl/openssl/pull/22936
https://github.com/openssl/openssl/pull/22401
https://github.com/openssl/openssl/pull/22380
https://github.com/openssl/openssl/pull/22360
When they are merged I'll do a rebase of this branch and make some adjustments to make the tests pass (some has to be forced to run on DTLS 1.2 for now). That will enable the dtls 1.3 feature branch to negotiate dtls 1.3. And then we can make the required adjustments to make it correct according to the RFC.

Please prioritise reviewing the following:

All of these are now merged

Yes thanks. I'll update this PR today or tomorrow.

Note that #24161 is going to cause problems for this one. My current plan is:
Rebase the feature/dtls-1.3 branch later today on master (there will be no conflicts from this)
Merge #24161 to master
Once #24226 is approved I can rebase the feature/dtls-1.3 branch again which will bring #24161 onto this feature branch
At that point you will need to update this PR again to fix any resulting issues.

@mattcaswell Please review again. I've marked a couple of tests for reenablement and some has been forced to DTLS 1.2. Please let me know what you think.

At least some of the CI failures look relevant.

 Sorry for the wait.

@mattcaswell @t8m
I think I found a fix for the memory leaks, but the patch in 6adbb30 seems to break compilation. TBH I don't understand why. Maybe you know what's causing it?

It is because the test file test/tls13secretstest.c mocks outs some internal functions and links in ssl/tls13_enc.c directly:
https://github.com/openssl/openssl/blob/deaa83af700113c99835a1db7d45d33baba05bd3/test/build.info#L1028-L1038
To fix it you will need to supply dummy implementations of dtls1_clear_received_buffer and dtls1_clear_sent_buffer in tls13secretstest.c:
void dtls1_clear_received_buffer(SSL_CONNECTION *s)
{
}

void dtls1_clear_sent_buffer(SSL_CONNECTION *s)
{
}

@mattcaswell @t8m
This is ready for review once again. I have added some handling of middlebox compatibility and fixed the memory leak. Please let me know what you think.

Pushed. Thanks.


Pickle python code strings

We can't pickle python code so can't save the model if model.convert_to_format="python". See #732 (comment) for workaround

Closing as duplicate of #1283 with less detail


genesis > megadrive

@Jamesinorbit Hey dude, are you sure you want to do this? The short name of the platform will still read GENESIS (at the tab at the bottom of the platforms page). Maybe you should add this image as a separate platform called megadrive, for people that want to create a custom platform with that name.

i think ive just done it...I closed the pull request


fix: do not strip dotted components from lean module names

This introduces FilePath.addExtension to take a path that we know has no prior extension, and append a new extension to it.
As this function is simpler than FilePath.withExtension, this change eagerly replaces uses of the latter with the former, except in a few cases where stripping the extension really is the right thing to do.
This should fix the bug described at https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Import.20file.20with.20multiple.20dots.20in.20file.20name/near/404508048, where import «A.B».«C.D.lean» is needed to import A.B/C.D.lean.
Summary
Link to RFC or bug issue: Closes #2999

@Kha I think the test failure on Nix may be due to the use of guillemets in a file name?

It looks to me like the full tests are still not actually running

@eric-wieser Could you try merging master?

@eric-wieser As to the error itself, I believe it has to do with MSYS2 path conversion. Adding the following to the top of the test file should hopefully fix it:
# make paths behave on MSYS2
[ "$OSTYPE" == "msys" ] && export MSYS2_ARG_CONV_EXCL=*

@eric-wieser I am happy with the Lake changes, but I think we need @Kha to sign off on the core changes before merging.

@Kha, is the new docstring ok?


SHINYPROXY_USERGROUPS empty with Kerberos

According to (the documentation)[https://www.shinyproxy.io/configuration/#environment-variables_1]:

When a user is authenticated, the following environment variables will be available in any Shiny application launched by the user:

SHINYPROXY_USERNAME: the name of the user, as used when logging in;
SHINYPROXY_USERGROUPS: the groups the authenticated user is a member of, as a comma-separated value.

It sounds very generic but is actually under Kerberos. However, in my case, SHINYPROXY_USERGROUPS is empty.
From what I know about Kerberos, it doesn't contain any group information so it needs to be looked up via LDAP. The corresponding properties user-dn-pattern, group-search-filter, and group-search-base are (according to the documentation) only for LDAP authentication.
How is it meant to work with Kerberos?

Hi Michel,,
I am not sure exactly how you use Keycloak (eg. if you connect it with some external identity provider), but if you add user to some previously created group under realm, SHINYPROXY_USERGROUPS will return you comma-separated list of all groups in which user is member.
I've just checked it.

Hi Dusan,
We don't use Keycloak, we use Kerberos with Active Directory.

Hi @micheljung
Have you managed to find the solution?

Hi @micheljung
Have you managed to find the solution?

Hi @filpro
Unfortunately not, for now we continue without Kerberos.
@Dusan-Dingarac could you respond to my initial question?

Hi @filpro
Unfortunately not, for now we continue without Kerberos.
@Dusan-Dingarac could you respond to my initial question?

Hi Michel,
my idea was to use Keycloak with Shinyproxy and to try to connect Kerberos as Identity provider for Keycloak... But, I think that you are right that group are part of LDAP not Kerberos itself....
But, you mentioned that you are using AD (which is in kind of Kerberos + LDAP combination). With one command you can start Keycloak docker container (you need some database also) and try to configure Keycloak Identity provider OIDC to your AD. I did not tried that but I saw in searches some blogs about that.
I hope that this can be solution for you and @filpro

Hi Michel,
my idea was to use Keycloak with Shinyproxy and to try to connect Kerberos as Identity provider for Keycloak... But, I think that you are right that group are part of LDAP not Kerberos itself....
But, you mentioned that you are using AD (which is in kind of Kerberos + LDAP combination). With one command you can start Keycloak docker container (you need some database also) and try to configure Keycloak Identity provider OIDC to your AD. I did not tried that but I saw in searches some blogs about that.
I hope that this can be solution for you and @filpro

Hi, we have removed support for Kerberos in ShinyProxy 3.0.0. The reason is that we lack the time and resources to fully support Kerberos in a high-quality way. We don't have any test servers or test documentation, and since Kerberos is such a complex system and also contains many proprietary implementations it's also hard to set up such test servers. Furthermore, we see that the adoption of Kerberos in ShinyProxy is very low. We have a few customers using Kerberos, but they always integrate Kerberos with their IDP and then integrate ShinyProxy with the IDP (e.g. using openid or saml). This is the same method as suggested by @Dusan-Dingarac .


fix: use same server_key within pipeline when issued watch

#212
This PR introduces two changes:

If host/port/db are provided as positional arguments (vs. kwargs) it will be transferred into kwargs. Previously, the positional arguments would be ignored in the connection_pool kwargs. This could lead to new connections to a new FakeServer instead of the current one, such as within a pipeline after issuing the .watch() command.
Generating a random host, if not provided, now happens before initializing the connection_pool, this way new connections from the pool will connect to the same FakeServer.

Hi Oleg, thank you.
This code be simplified:
        default_args = parameters.values()
        default_args_override_dict = dict(host=uuid.uuid4(), port=0, db=0)
        kwds = {p.name: default_args_override_dict.get(p.name, p.default)
                for p in default_args
                if p.default != inspect.Parameter.empty}

Hi @cunla! Thank you for the quick response. My only concern is that if someone initializes the FakeRedis with positional arguments the host, port, and db values won't be used in the FakeServer.
I added a few example tests that pass with the current implementation - https://github.com/cunla/fakeredis-py/pull/213/commits/8de2497ac8c4767034a2982af80764cf33acea7b
What do you think?

I get your point with the args but still think it can be addressed differently.
How about:
        default_args = list(parameters.values())[1:]
        default_args_override_dict = dict(host=uuid.uuid4(), port=0, db=0)
        kwds = {p.name: args[ind] if ind < len(args) else default_args_override_dict.get(p.name, p.default)
                for ind, p in enumerate(default_args)
                if p.default != inspect.Parameter.empty}

Also, minor things regarding the tests:

Can you move test_new_server_with_positional_args from test_general.py to test_init_args.py? it makes more sense there.
Can you remove the from fakeredis import FakeRedis in the tests? you can use fake_redis = fakeredis.FakeRedis() as it is already imported.
Can you mark the tests with @pytest.mark.fake so it will run only for fake?

Was about to push the changes you suggested. Great suggestions btw, thank you!
Should I add the fakeredis.FakeRedis to test_new_server_with_positional_args and markers for the tests?
One more note, I think we should keep the test for the pipeline where the FakeRedis was created without any parameters. Because the first test right now uses the fixture r which is created with (host=..., port=...) and the other test is created with positional arguments.

Was about to push the changes you suggested. Great suggestions btw, thank you! Should I add the fakeredis.FakeRedis to test_new_server_with_positional_args and markers for the tests?

I moved it to test_init_args.py and the marker exist in the class level.

One more note, I think we should keep the test for the pipeline where the FakeRedis was created without any parameters. Because the first test right now uses the fixture r which is created with (host=..., port=...) and the other test is created with positional arguments.

I agree, I will leave it for you to do this change and then merge. (the only test failure is something that is unrelated, it happens sometimes when cancelling GHA runs and restarting them).

Seems like I don't have the write access to merge PRs.
Only those with write access to this repository can merge pull requests


isEmpty for ConcurrentChannel ConsumerF

as was requested in this issue: https://github.com/monix/monix/pull/1012#issuecomment-531655051

@alexandru I have to admit I'm not quite familiar with ConcurrentChannel so I'm not sure how to test it properly, do you perhaps have any thoughts on this PR?


Pickles: add a test with fixed lookup tables and fixed and small table ID

The table ID is for RangeCheck, but the table is not used
Explain your changes:

Adding tests in Pickles for lookup tables. It is the first PR introducing tests related to lookup tables in Pickles.

Explain how you tested your changes:
*
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

Closes #0000

!ci-build-me

!ci-build-me


feat: add commands to assert success messages, error messages and page titles

This PR adds a few short helper functions:

shouldHavePageTitle
shouldHaveSuccessMessage
shouldHaveErrorMessage

All of them pretty much do what their title says.
Example usage for checking if a success message is present:
it('Can add a product to the cart from the product page', () => {
    cy.get(selectors.addToCartButton).click()
    cy.shouldHaveSuccessMessage(`You added ${product.simpleProductName} to your shopping cart.`)
})

Could you move the global commands to helper functions? See the first bullet point under Contributing; https://github.com/elgentos/magento2-cypress-testing-suite#contributing
Global commands are bad mmkay.

Should I remove the login command as well while I'm at it? Looks like it's not used anywhere.

Yes please!

Awesome, thanks!


regulates:transitive + regulates o part_of -> regulates => problems

This one's making my head spin a bit...
POTENTIAL REDUNDANT AXIOMS: GO:0098910 'regulation of atrial cardiac muscle cell action potential' part_of 'part of' GO:0086004 'regulation of cardiac muscle cell contraction' is also a simple SubClassOf.
POTENTIAL REDUNDANT AXIOMS: GO:0098911 'regulation of ventricular cardiac muscle cell action potential' part_of 'part of' GO:0086004 'regulation of cardiac muscle cell contraction' is also a simple SubClassOf.

Perhaps not a general issue after all.  Corrected this - given inconsistency with name and textual def:

Hi David,
Assigning to you - but let's bring it up for discussion at tomorrow's editors call. Could you please add it to the agenda? Cheers!
Paola

Solution (to this specific issue): change part_of to regulates in these cases.  Need to look at how this fits with related terms.
There is also a general issue that the regulates over part of property chain is problematic, e.g. individual steps in an ST pathway function by regulating each other without regulating pathway output for a given input. Needs to be a separate ticket with examples.

While this is fixed, there are still a number of issues to address.  At least some of these should be made into new tickets. Adding some notes for now.
Specific issues:

In terms of the biology, it may make more sense to have the AP (positively) regulating the contraction.  If so, this should be applied as a general pattern.  Although perhaps - causally upstream would be better still.

General Issues not resolved:

Why did these problems only show up when transitivity was added to regulates?
Are there legitimate double labelled edge combinations being flagged here?

Can P1 regulate some P2 when P1 part_of some P2 ?
Can P1 regulate some P2 when P1 SubClassOf some P2 ?

Do we have a general problem here, where legitimate combination of axioms lead to an illegitimate double labelled edge?
The regulates over part of property chain is problematic, e.g. individual steps in an ST pathway function by regulating each other without regulating pathway output for a given input. Needs to be a separate ticket with examples.

Closing as nothing further obviously actionable.  Have tagged as example of questionable regulation inference.


creational/builder

creational/builder - working example

I think my design is slightly wrong, I'll read some more on Product/Builder/Concrete/Director.


Missing attacks on data/pokemon.json for Hitmonlee and Staryu

Expected Behavior
I expected these line to be shown on the bot log.
Actual Behavior
The bot is outputting these lines:
2016-08-20 10:41:26,469 [   Pokemon] [ERROR] Unexpected moveset [Tackle, Bubble Beam] for #120 Staryu, please update info in pokemon.json and create issue/PR
2016-08-20 09:52:49,318 [   Pokemon] [ERROR] Unexpected moveset [Rock Smash, Brick Break] for #106 Hitmonlee, please update info in pokemon.json and create issue/PR

Your FULL config.json (remove your username, password, gmapkey and any other private info)
http://pastebin.com/FSLndJiY
Here is the pokemon.json witht he fixed attacks.
http://pastebin.com/4A2wNFJz

#4323 Use dev branch.

@mjmadsen you mean it is patched and merged in dev?

@Gurzeh Yeah, all movesets should now be in dev. If you find any missing moves please post them in #4324

thx @mjmadsen  O, it's running fine right now. Quite a number of change!


Fix for include/templates composers not firing

Fixed

Fixed include/templates view composers not firing

Closes #202

Test failure seems unrelated to my change

See https://github.com/laravel/framework/blob/dbb3eebf0818c584686ffb6a42a25db30cdf0440/src/Illuminate/View/Factory.php
/**
 * Normalize a view name.
 *
 * @param  string $name
 * @return string
 */
protected function normalizeName($name)
{
    $delimiter = ViewFinderInterface::HINT_PATH_DELIMITER;
    if (strpos($name, $delimiter) === false) {
        return str_replace('/', '.', $name);
    }
    list($namespace, $name) = explode($delimiter, $name);
    return $namespace.$delimiter.str_replace('/', '.', $name);
}

Should we do the same as Laravel?

I saw this but wasn't sure the namespace normalization wasn't already done somewhere withing TwigBridge. Will port the method over.

Yeah we're also doing something here: https://github.com/rcrowe/TwigBridge/blob/0e2693d99745eb8bbd01a80e841951c0738e1d15/src/Bridge.php#L71
So might make sure we do it only once and it the correct place.

Hm should I move the normalization here then?

I'm not sure. Probably.
Just need to make sure it's always called, also for the partials.

Like this?

Looks better. Can you squash?

Done

Thanks. Let me know if this fixes your problems with events etc!

Can i haz a 0.7.3 tag for this? :dancer:

Ehh, is this breaking or not?
If you have event listeners for the un-normalized names, they will stop working right?
So we'll need a 0.8 tag?

If you have event listeners for the un-normalized names, they will stop working right?

Hm in theory no? All the names are normalized underneath so to me it's more of a bugfix

Yeah the views that are called by view($name), but not the views that are inherited/child blocks, right?

No ok I just understood what you meant. Hm yes I guess it can be considered breaking in that way. I don't think a lot of people manually listen to composing: events but plugins extending on TwigBridge might so better tag it as 0.8 just to be sure indeed

Example:
test/hello.twig:
Hello {{ name }}

Hello {% include "test/child.twig" %}

test/child.twig
My Child!

Calling view('test/hello.twig')
Events before:

test.hello
test/child

Events after:

test.hello
test.child

So yeah, could be breaking. But it's better now :)
Gonna bump the alias just to be sure.

Tagged 0.8.0

Thanks!


Enable reconnect on failure for Transport.

If the server-server service restarts, the channel is closed in RabbitMQ causing a failure in sensu-api which calls stop. This will (if configured) allow sensu-api to attempt a reconnection and continue rather than simply fail and abort (which will in turn affect event handling and Uchiwa).


Improve Cluster udfs

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/11429/

@graetzer I believe we need backports of this as well or?

I don’t know, essentially UDFs do not work in the cluster since > 1 year, seems almost like an unused feature to me

It is at least used by the people who submitted the bug report.

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/11442/


fix(curriculum): luhn algorithm step 31 updated tests

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #53659

https://github.com/freeCodeCamp/freeCodeCamp/assets/87417638/10feecdc-15b2-4ad0-9b1f-5d143a9b2579

btw, you need to reload the page to be able to run the tests again after a successful attempt

https://github.com/freeCodeCamp/freeCodeCamp/assets/87417638/3f7a0066-b43a-49ab-b39d-6aad01584d2b


The app crashes when I push to non-default(non-IBM) cloud

I created a custom connection to my mqtt broker, the app keeps crash once I press the button "push to cloud". It works if I push to the default one(ibm IoT)

Hi, it seems not to be a problem of the application, it's a problem of the custom connection. You need to debug your own application to find the problem. I don't even have your code.

Thank you @lemariva ! I got it work on another android device.


Provide time zone

This PR adds the Time.currentTimeZone() method so that all the time-related downstream code can rely on it.
Also, we rename the default value of EntityOption.Visitiblity into DEFAULT so that it has more reach semantics than a plain "UNDEFINED".

@armiol, @alexander-yevsyukov, PTAL.

@armiol, PTAL again.

@armiol, PTAL.


Updated validations.py python script.

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Closes: #1

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Thanks for this course

Thanks for this course


feat: blob help for anomaly detection

/azp run

Codecov Report

Merging #1279 (382ca45) into master (175fbc5) will decrease coverage by 43.81%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175fbc5...382ca45.


Integrating the HTML5 History API

Mozilla says

The DOM window object provides access to the browser's history through the history object. It exposes useful methods and properties that let you move back and forth through the user's history, as well as -- starting with HTML5 -- manipulate the contents of the history stack.

Read more and also read this
It's an awesome feature for pagination and search functionalities specially for ajax DataTables. A lot of sites and plugins support it and I think DataTables should support it as well. You will see it clearly at Google Translate
https://translate.google.com/#en/es/awesome
That will make all urls look like this for example
https://example.com/datatables/#/page=6&search=uk

Thanks for the suggestion. Its perhaps not too dissimilar to this blog post. The same basic technique could be used.
It isn't something that I think should be built into DataTables core - I would consider that "back button hijacking" in most DataTables, but I can absolutely see that it could be useful in some cases, and it would be something that would be suitable for creation as a plug-in for DataTables.


User is not able to create an AWS node template

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Go to Node template --> Create a Node template
Enter AWS access key and secret key (create a cloud credential)
Click on Save/Next
Error is seen on the console.

component.js:498 Uncaught TypeError: AWS.KMS is not a constructor
    at component.js:498
    at rsvp.js:518
    at new e (rsvp.js:1040)
    at n.listKMSKeys (component.js:497)
    at n.<anonymous> (component.js:459)
    at w (polyfill.js:6292)
    at Generator._invoke (polyfill.js:6518)
    at Generator.e.<computed> [as next] (polyfill.js:6344)
    at s (component.js:9)
    at o (component.js:11)
component.js:479 Uncaught (in promise) TypeError: Cannot read property 'pushObject' of null
    at n.<anonymous> (component.js:479)
    at w (polyfill.js:6292)
    at Generator._invoke (polyfill.js:6518)
    at Generator.e.<computed> [as throw] (polyfill.js:6344)
    at s (component.js:9)
    at l (component.js:11)

Expected Result:
User should be able to create a node template
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.4-head commit id: 3e543f7c4
Installation option (single install/HA): single

Verified on 2.4-head latest - commit id: 6708cf9f1 ui tag: latest-2.4

Go to Node template --> Create a Node template
Enter AWS access key and secret key (create a cloud credential)
Click on Save/Next
Error in console: tracked in issue - https://github.com/rancher/rancher/issues/28141
User is able to go to the next page though and create a node template successfully