[Bug]:

Bug Description
I have a peculiar problem. As of llama index version 0.9.22 ollama is not able to produce text for me. I downgraded and tested almost all versions from 0.9.1 up to 0.9.21. 0.9.21 is the last version in which ollama is able to produce text with llama index.
I have it integrated as " llm = Ollama(model="Solar", temperature=0.2)" Adding request_timeout doesn't change a thing unfortunately
Version
0.9.33
Steps to Reproduce
Downgrading to below 0.9.22 eliminates the issue, above, ollama can't generate text.
Relevant Logs/Tracbacks
No response

Is there some error? Any other details?

Unfortunately not, it just does nothing. It retrieves nodes and the nodes are also printed if I use print(source.node.get_text()). At first I thought it may be a problem with my system and I completely reinstalled fedora, but nothing changed.

I'm fairly sure I've tested this recently and it worked fine... let me try again

So I did the following:
print("Constructing query engine...\n")
query_engine = index.as_chat_engine(chat_mode="context", similarity_top_k=40, node_postprocessors=[cohere_rerank], streaming=True, system_prompt=("My way too long prompt."))
response = query_engine.chat("What is 9 + 10?")

print(response)

And I get the following error:

Traceback (most recent call last):

File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_exceptions.py", line 10, in map_exceptions
yield
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_backends/sync.py", line 126, in read
return self._sock.recv(max_bytes)
TimeoutError: timed out
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpx/_transports/default.py", line 66, in map_httpcore_exceptions
yield
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpx/_transports/default.py", line 228, in handle_request
resp = self._pool.handle_request(req)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_sync/connection_pool.py", line 268, in handle_request
raise exc
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_sync/connection_pool.py", line 251, in handle_request
response = connection.handle_request(request)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_sync/connection.py", line 103, in handle_request
return self._connection.handle_request(request)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_sync/http11.py", line 133, in handle_request
raise exc
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_sync/http11.py", line 111, in handle_request
) = self._receive_response_headers(**kwargs)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_sync/http11.py", line 176, in _receive_response_headers
event = self._receive_event(timeout=timeout)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_sync/http11.py", line 212, in _receive_event
data = self._network_stream.read(
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_backends/sync.py", line 124, in read
with map_exceptions(exc_map):
File "/home/luis/.conda/envs/vllm/lib/python3.10/contextlib.py", line 153, in exit
self.gen.throw(typ, value, traceback)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpcore/_exceptions.py", line 14, in map_exceptions
raise to_exc(exc) from exc
httpcore.ReadTimeout: timed out
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 535, in _run_script
exec(code, module.dict)
File "/home/luis/Dokumente/ChatWithDoc English/Streamlit.py", line 130, in
query_engine = setup_ollama_and_weaviate()
File "/home/luis/Dokumente/ChatWithDoc English/Streamlit.py", line 124, in setup_ollama_and_weaviate
response = query_engine.chat("What is 9 + 10?")
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/llama_index/callbacks/utils.py", line 41, in wrapper
return func(self, *args, **kwargs)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/llama_index/chat_engine/context.py", line 163, in chat
chat_response = self._llm.chat(all_messages)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/llama_index/llms/base.py", line 97, in wrapped_llm_chat
f_return_val = f(_self, messages, **kwargs)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/llama_index/llms/ollama.py", line 102, in chat
response = client.post(
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpx/_client.py", line 1132, in post
return self.request(
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpx/_client.py", line 814, in request
return self.send(request, auth=auth, follow_redirects=follow_redirects)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpx/_client.py", line 901, in send
response = self._send_handling_auth(
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpx/_client.py", line 929, in _send_handling_auth
response = self._send_handling_redirects(
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpx/_client.py", line 966, in _send_handling_redirects
response = self._send_single_request(request)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpx/_client.py", line 1002, in _send_single_request
response = transport.handle_request(request)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpx/_transports/default.py", line 227, in handle_request
with map_httpcore_exceptions():
File "/home/luis/.conda/envs/vllm/lib/python3.10/contextlib.py", line 153, in exit
self.gen.throw(typ, value, traceback)
File "/home/luis/.conda/envs/vllm/lib/python3.10/site-packages/httpx/_transports/default.py", line 83, in map_httpcore_exceptions
raise mapped_exc(message) from exc
httpx.ReadTimeout: timed out

OK that makes more sense, a timeout error.
And you tried setting request_timeout to some absurdly large value?

You can see request_timeout is used consistently in the code
https://github.com/run-llama/llama_index/blob/e34c379f1a1c46b775580ae8678886a44cf775ca/llama_index/llms/ollama.py#L101

If I do that, it will generate a response. But somehow the overarching function is still broken. I use it inside a streamlit integration and with llama index 0.9.21 it is absolutely no problem

"It will generate a response. But somehow the overarching function is still broken." -- but what does that mean?

Trying something somewhat similar, it works fine for me (and this is running on CPU, so quite slow, as expected)
from llama_index.llms import Ollama
from llama_index import ServiceContext, SimpleDirectoryReader, VectorStoreIndex

llm = Ollama(model="starling-lm:latest", request_timeout=3000)
ctx = ServiceContext.from_defaults(llm=llm, embed_model="local")

documents = SimpleDirectoryReader("./docs/examples/data/paul_graham").load_data()
index = VectorStoreIndex.from_documents(documents, service_context=ctx)

chat_engine = index.as_chat_engine(chat_mode="context")
resp = chat_engine.chat("What did the author do growing up?")
print(str(resp))

def setup_ollama_and_weaviate():
    with open('/home/luis/Dokumente/ChatWithDoc English/config.yml', 'r', encoding='utf8') as ymlfile:
        cfg = box.Box(yaml.safe_load(ymlfile))

    print("Connecting to Weaviate")
    client = weaviate.Client(cfg.WEAVIATE_URL)

    print("Loading Ollama...")
    llm = Ollama(model="FusionNetTruthQ4", temperature=0.2)

    print("Loading embedding model...")
    embeddings = load_embedding_model(model_name='jinaai/jina-embeddings-v2-base-en')

    print("Building index...")
    index = build_index(cfg.CHUNK_SIZE, cfg.CHUNK_OVERLAP, llm, embeddings, client, cfg.INDEX_NAME)

    cohere_rerank = CohereRerank(api_key="bW8KGD0GqZdLvx4QcRg6OQfROvkMuhMAZd0CtIP3", top_n=6)

    print("Constructing query engine...\n")
    query_engine = index.as_chat_engine(chat_mode="condense_plus_context", similarity_top_k=40, node_postprocessors=[cohere_rerank], streaming=True, context_prompt=("My very long prompt."))

    return query_engine

    query_engine = setup_ollama_and_weaviate()

# Define an enum for roles
class Role(Enum):
    USER = "user"
    ASSISTANT = "assistant"

# Update the ChatMessage class
class ChatMessage:
    def __init__(self, role, content, additional_kwargs=None):
        if additional_kwargs is None:
            additional_kwargs = {}
        self.role = Role(role)
        self.content = content
        self.additional_kwargs = additional_kwargs

# Chat input processing

if prompt := st.chat_input("What is up?"):
    st.session_state.messages.append({"role": "user", "content": prompt})
    with st.chat_message("user", avatar="/home/luis/Dokumente/ChatWithDoc English/capri.jpg"):
        st.markdown(prompt)

    with st.chat_message("assistant", avatar="/home/luis/Dokumente/ChatWithDoc English/ollama.png"):
        message_placeholder = st.empty()
        full_response = ""

        # Convert st.session_state.messages to the expected format
        chat_history = [ChatMessage(m["role"], m["content"]) for m in st.session_state.messages]

        # Use the 'chat' method for generating responses
        streaming_response = query_engine.stream_chat(prompt, chat_history=chat_history)

        for source in streaming_response.source_nodes:
            # This prints the text of the node
            print(source.node.get_text())

            # Check if 'title' exists in the metadata of the node and print it
            if 'file_path' in source.node.metadata:
                print("\033[92m" + source.node.metadata['file_path'] + "\033[0m")  # This prints the title if it exists in metadata
                print("\n")

        for token in streaming_response.response_gen:
            full_response += token
            message_placeholder.markdown(full_response)

        st.session_state.messages.append({"role": "assistant", "content": full_response})

If I put the print command before the "return query_engine" it generates an output. If I put it afterwards, it won't and streamlit won't process my prompt. As a little fix I just copied the old ollama integration into the newer llama index and that seems to work fine.

def setup_ollama_and_weaviate():
    with open('/home/luis/Dokumente/ChatWithDoc English/config.yml', 'r', encoding='utf8') as ymlfile:
        cfg = box.Box(yaml.safe_load(ymlfile))

    print("Connecting to Weaviate")
    client = weaviate.Client(cfg.WEAVIATE_URL)

    print("Loading Ollama...")
    llm = Ollama(model="FusionNetTruthQ4", temperature=0.2)

    print("Loading embedding model...")
    embeddings = load_embedding_model(model_name='jinaai/jina-embeddings-v2-base-en')

    print("Building index...")
    index = build_index(cfg.CHUNK_SIZE, cfg.CHUNK_OVERLAP, llm, embeddings, client, cfg.INDEX_NAME)

    cohere_rerank = CohereRerank(api_key=api_key, top_n=6)

    print("Constructing query engine...\n")
    query_engine = index.as_chat_engine(chat_mode="condense_plus_context", similarity_top_k=40, node_postprocessors=[cohere_rerank], streaming=True, context_prompt=("My very long prompt."))

    return query_engine

query_engine = setup_ollama_and_weaviate()

# Define an enum for roles
class Role(Enum):
    USER = "user"
    ASSISTANT = "assistant"

# Update the ChatMessage class
class ChatMessage:
    def __init__(self, role, content, additional_kwargs=None):
        if additional_kwargs is None:
            additional_kwargs = {}
        self.role = Role(role)
        self.content = content
        self.additional_kwargs = additional_kwargs

# Chat input processing
# Chat input processing
if prompt := st.chat_input("What is up?"):
    st.session_state.messages.append({"role": "user", "content": prompt})
    with st.chat_message("user", avatar="/home/luis/Dokumente/ChatWithDoc English/capri.jpg"):
        st.markdown(prompt)

    with st.chat_message("assistant", avatar="/home/luis/Dokumente/ChatWithDoc English/ollama.png"):
        message_placeholder = st.empty()
        full_response = ""

        # Convert st.session_state.messages to the expected format
        chat_history = [ChatMessage(m["role"], m["content"]) for m in st.session_state.messages]

        # Use the 'chat' method for generating responses
        streaming_response = query_engine.stream_chat(prompt, chat_history=chat_history)

        for source in streaming_response.source_nodes:
            # This prints the text of the node
            print(source.node.get_text())

            # Check if 'title' exists in the metadata of the node and print it
            if 'file_path' in source.node.metadata:
                print("\033[92m" + source.node.metadata['file_path'] + "\033[0m")  # This prints the title if it exists in metadata
                print("\n")

        for token in streaming_response.response_gen:
            full_response += token
            message_placeholder.markdown(full_response)

        st.session_state.messages.append({"role": "assistant", "content": full_response})

If I put the print command before the "return query_engine" it generates an output. If I put it afterwards, it won't and streamlit won't process my prompt. As a little fix I just copied the old ollama integration into the newer llama index and that seems to work fine.

@Bearsaerker I've narrowed this down a bit.... seems to be related to streaming, as normal chat() works fine.
Not 100% sure how to further debug this, maybe it's related to httpx and how it handles streaming?

WOW this was a sneaky bug. Some non-serializable thing was only sometimes making its way into requests? And the error was only sometimes getting raised?
Very weird. Will have a PR in a sec, but I got your sample code to actually work


feat: adds support for percentage based height

Description

Support percentage based heights
Support min/max heights
Percentage based heights will be updated on container resize

Related Issue

Closes #216
Motivation and Context

Allows Charts to fill all or a percentage of the available vertical space
How Has This Been Tested?

Tested with new story in storybook
linked package to my team's implementation and verified it works with quarry/dashboard widgets

Screenshots (if appropriate):
https://github.com/adobe/react-spectrum-charts/assets/12468946/d65d38c5-7644-421e-a3e0-c4a9f650ba94
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Will re-open this PR, something seems to be off with the dedicated docker container for the runners


[MenuButton] Documentation for component

Documentation should be written for the API of this component. The markdown file should live in the root directory of this component and added to the story.
Docs should include a prop table , common uses, link to design pattern, etc.

Closed by #2279


fix(rolls): use "removed setaback dice" modifiers

This PR should include removed setback dice icons in all roll windows, and actually remove setback dice when rolling the dice.
I've seen your answer on issue #1719 and I'm wondering if it applies to my fix. Conditional "remove setback dice" bonus don't seem to be added as modifiers to the talent (at least when using oggdude's importer, e.g. Outdoorsman talent from Pathfinder spec), so any "remove setback dice" modifier present should apply to every roll of that skill.
Closes #1720

@obrenckle I think the automatic activation should be behind a setting. Would you mind adding it? If so, I'm happy to do it myself.

Good idea. I put the setting at the root of the "Star Wars FFG" settings for now, but there's a few "Roll - " settings that could be grouped with this one in a "Roll" sub-menu.

@obrenckle the setting registration looks good, but it isn't actually honored. The setting needs to be checked before removing the dice, kinda like here: https://github.com/StarWarsFoundryVTT/StarWarsFFG/blob/3f12b68bd4338c83c70d84cd561b3fc03f2d6d48/modules/helpers/dice-helpers.js#L77-L91 (except with an else)

Sorry to be a pain; I do appreciate your efforts and flexibility here.

@wrycu Not a pain at all, don't worry !
I think the setting is checked before being applied, look at theses changes :
https://github.com/StarWarsFoundryVTT/StarWarsFFG/blob/b7d66061b6efa395e84d9a28a64b220c3f97a134/modules/dice/pool.js#L218-L230
However the code changes in this PR are hard to navigate, I'll redo it without the purely visual changes added by prettier, sorry about that.

@wrycu It should be better now


Gantt Chart not getting model in sap.z2ui5.oResponse.OVIEWMODEL

Hi @oblomov-dev
i dont seem to get model in sap.z2ui5.oResponse.OVIEWMODEL running tree table in gantt chart,
seems to be empty.
am i doing something wrong or its just not possible to implement this chart..?
based on my latest pr  https://github.com/abap2UI5/abap2UI5/pull/413/commits/91317dc0087451a5b60c1065464a594ac7c957a0
this is the code snippet for the demo gantt.simple based on JSON Model.
https://sapui5.hana.ondemand.com/#/entity/sap.gantt.simple.GanttChartWithTable/sample/sap.gantt.sample.GanttChart2JSON
Z2UI5_CL_APP_DEMO_GANTT.txt

HI @choper725,
thank you for the example. I added the model binding which sends the data to the frontend. Adjusted the following:
 )->tree_table( rows = `{path: '` && client->_bind( val = mt_table path = abap_true ) && `', parameters: {arrayNames: ['CHILDREN'],numberOfExpandedLevels: 1}}`

You can check this example:
https://github.com/abap2UI5/abap2UI5-samples/blob/main/src/z2ui5_cl_app_demo_76.clas.abap

The model is now not empty anymore:

Best regards.

thanks! i saw that demo 07 (tree table) was adjusted also for the new syntax..
ill try get it to work now!

got it to display the tree but, the tasks need date object in order to work, hence the formatter there, but for some reason its not working, even if i put the method in the controller.. not getting called

can you update your example with your actual version?
Normally i would guess, you can do the following in the backend and just skip the formatter:

here it is
Z2UI5_CL_APP_DEMO_76.txt
you mean dealing with Date object in abap ??

yes instead of using the formatter at the frontend, try to do the changes directly in the backend and send the ready formatted values to the frontend.

yeah, i tried to send the date string instead of timestamp but its not wirking either…

did you try without these { }?
maybe something like this works:
{ path : '/starttime' , formatter...

set the path paramter = abap_true like:
             )->object_number(
                   state = '{STATE_PRICE}'
                   number = `{ parts: [ { path : 'PRICE' } , { path : 'WAERS' } ] } `
              ).

thanks ! adding parts did the trick, for the time
regarding the TASK and SUBTASK .. nothing worked there adding the templateSharing parameter..
any way, got it to work

now just need to handle the Date object being sent to the time & endtime properties, without the formatter..
any idea how to do so in abap ?
how its possible to create a js Date object in abap ?

yes i think it could work but the date field also made troubles here:
https://github.com/abap2UI5/abap2UI5/issues/401#issuecomment-1646958812
when you make it to send it to the frontend it hope it will work, otherwise you can update the example again that i can take a look to it.

created pr for new demo update
demo is not working as the formatter function not in the http_handler method, in order to get it to work, need to add this:
   `            ` && |\n|  &&
   `            fnTimeConverter: function (sTimestamp) {` && |\n|  &&
   `              return new sap.gantt.misc.Format.abapTimestampToDate(sTimestamp);` && |\n|  &&
   `            },` && |\n|  &&

tried changing it to string of Date function but im getting this..

i dont think this is possible without formatter function...

solved


Facade style API change proposal

For Facade style, instead of:
Pattern::pattern('[A-Z][a-z]+')->matches($subject)

You could try:
Pattern::of('[A-Z][a-z]+')->matches($subject)

Reads better for me :)

gracias, amigo :+1:  I didn't like pattern pattern either :)
(had no idea for a better name though)


[irods/irods#7220] Do not explicitly build against libc++

In service of irods/irods#7220
Merge irods/irods#7526 before merging this.

#'d

Do we need to keep the libcxx option around, or are we just moving ahead in the plugins?

I wasn't planning on supporting it in the plugins

I take it the 4-3-stable branch's build/test hooks will be updated to list the libcxx variants instead?

You've already approved the PR for it.


Rename content/github/getting-started-with-github/githubs-products.md…

… to Nội dung/github/bắt đầu với github/githubs-products.md/Password.is/Owner/chủ yếu/github: main/Chủ

Why:
Closes [issue link]

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (eg. a "before and after video")

H


Reward nan

Hi,
Thanks for sharing this great project!
when I run gail/ gaifo on Pendulum-v0, sometimes, return will become nan, I'm wondering why.
(venv) haoyux@haoyux-ThinkPad:~/tf2rl-master/examples$ python3 run_gaifo_ddpg.py --save-test-path --save-test-movie --expert-path-dir /home/haoyux/tf2rl-master/examples/results/20200725T223711.222453_SAC_ --test-interval 20000

01:32:03.873 [INFO] (irl_trainer.py:74) Total Epi:   157 Steps:   31400 Episode Steps:   200 Return:   nan FPS: 58.40
01:32:07.445 [INFO] (irl_trainer.py:74) Total Epi:   158 Steps:   31600 Episode Steps:   200 Return:   nan FPS: 56.01
01:32:11.351 [INFO] (irl_trainer.py:74) Total Epi:   159 Steps:   31800 Episode Steps:   200 Return:   nan FPS: 53.48
01:32:14.457 [INFO] (irl_trainer.py:74) Total Epi:   160 Steps:   32000 Episode Steps:   200 Return:   nan FPS: 64.44

(I tried a harder environment, robosuite will throw a nan reward always, and execution will be killed)

Hi @haoyu-x , thanks for reporting the error!
I'm afraid I won't work on this immediately because I've been busy for a paper deadline in a week, but I'll fix it after that.

sure, good luck to your CoRL :+1:

Hi @keiohta , I assumed that's because we need to normalize the reward of GAIL/GAIfO, but I'm not sure. Will have time these days to look into this issue? Thanks a lot!

so the weird "nan" bug goes like this: I'm using tf2rl GAIfO for robosuite. during training, the discriminator output becomes nan suddenly. however, the input of the discriminator is normal. so using the nan output(the reward) to update the policy leads to a nan action, which leads to a mujoco error. When I use tf2rl GAIL/GAIfO for gym pendulum, the nan error sometimes happens, sometimes not. But for robosuite, it happens always. it cost me too much time and I have no idea how to fix it. I'm wondering if you can offer me some help. Thanks!

Hi @haoyu-x , I'm going to look into this issue. In the mean time, can you try with enable_sn=True when creating the GAIL/GAIfO? One possible potential problem is that GAN like training is unstable, and Spectral Normalization certainly helps stabilize the training (see #14 that compares w/ w/o SN https://github.com/keiohta/tf2rl/issues/14#issuecomment-509034835).

Thanks for your reply. I tried enable-sn, but there's another issue:
Traceback (most recent call last):
File "run_gaifo_robosuite.py", line 126, in
gpu=args.gpu)
File "/home/haoyux/tf2rl-master/tf2rl/algos/gaifo.py", line 41, in init
units=units, enable_sn=enable_sn)
File "/home/haoyux/tf2rl-master/tf2rl/algos/gaifo.py", line 26, in init
self([dummy_state, dummy_next_state])
File "/home/haoyux/venv/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py",
line 968, in call
outputs = self.call(cast_inputs, *args, **kwargs)
File "/home/haoyux/tf2rl-master/tf2rl/algos/gail.py", line 29, in call
features = self.l1(features)
File "/home/haoyux/venv/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py",
line 968, in call
outputs = self.call(cast_inputs, *args, **kwargs)
File "/home/haoyux/tf2rl-master/tf2rl/networks/spectral_norm_dense.py",
line 52, in call
rank = common_shapes.rank(inputs)
AttributeError: module 'tensorflow.python.framework.common_shapes' has
no attribute 'rank'
and for the reward nan, I suppose it's because of the discriminator
architecture.
On Thu, Jul 30, 2020 at 4:52 AM Kei Ohta<EMAIL_ADDRESS>wrote:

Hi @haoyu-x https://github.com/haoyu-x , I'm going to look into this
issue. In the mean time, can you try with enable_sn=True when creating
the GAIL/GAIfO? One possible potential problem is that GAN like training is
unstable, and Spectral Normalization certainly helps stabilize the training
(see #14 https://github.com/keiohta/tf2rl/issues/14 that compares w/
w/o SN #14 (comment)
https://github.com/keiohta/tf2rl/issues/14#issuecomment-509034835).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keiohta/tf2rl/issues/92#issuecomment-665920753, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APACPZTBUSQPLAOYTER55YDR6CDZNANCNFSM4PHR4ACA
.

Thanks for trying to use SN. By the way, what’s your TensorFlow version? I tested on 2.0.0, and have not supported later version (but going to do soon).

I see. My version is 2.2.0
Could you first make sn support 2.2.0. So that I can try if the nan error
will disappear. Thanks.
Kei Ohta<EMAIL_ADDRESS>周四21:32写道：

Thanks for trying to use SN. By the way, what’s your TensorFlow version? I
tested on 2.0.0, and have not supported later version (but going to do
soon).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keiohta/tf2rl/issues/92#issuecomment-666366420, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APACPZTI2QDGL3G67XFAVNLR6FY5DANCNFSM4PHR4ACA
.

I'm also trying TensorFlow 2.0.0
Haoyu Xiong<EMAIL_ADDRESS>周四21:35写道：

I see. My version is 2.2.0
Could you first make sn support 2.2.0. So that I can try if the nan error
will disappear. Thanks.
Kei Ohta<EMAIL_ADDRESS>周四21:32写道：

Thanks for trying to use SN. By the way, what’s your TensorFlow version?
I tested on 2.0.0, and have not supported later version (but going to do
soon).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keiohta/tf2rl/issues/92#issuecomment-666366420, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APACPZTI2QDGL3G67XFAVNLR6FY5DANCNFSM4PHR4ACA
.

thanks for your advice, so for now I'm able to run enable-sn with tf 2.0.0. but not sure if the nan error will happen again, will update later.

Thanks @haoyu-x for trying tf2.0.0!! I'll do my best for supporting tf2.2.0, but might take time.
Anyway, please let me know if you have any kind of error. That definitely helps improve this library.

Thank you！
I change to tf2.0.0 and enable sn.
Now it goes well, the nan bug will not be thrown！
Kei Ohta<EMAIL_ADDRESS>周五13:17写道：

Thanks @haoyu-x https://github.com/haoyu-x for trying tf2.0.0!! I'll do
my best for supporting tf2.2.0, but might take time.
Anyway, please let me know if you have any kind of error. That definitely
helps improve this library.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/keiohta/tf2rl/issues/92#issuecomment-666927707, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APACPZS65CWEE5B7UPNX7KTR6JHV7ANCNFSM4PHR4ACA
.

Glad to hear that!
Please remain this issue open till you can successfully run this on tf2.2 (or later). I'll work on that.

Hi @haoyu-x , I think you can now run the original script on tf2.2 or later (PR #95 ).
Please confirm your script works without any problem, and close this issue.

I think this issue has been resolved by the PR in my previous comment.
Also, you should be able to run on tf2.3 on latest master.
Please reopen this issue if you encounter the same problem.


Support Video

Feature request
HF datasets are awesome in supporting text and images. Will be great to see such a support in videos :)
Motivation
Video generation :)
Your contribution
Will probably be limited to raising this feature request ;)

duplicate of #5225


[Migrated] zappa.io is down

Originally from: https://github.com/Miserlou/Zappa/issues/2114 by dekoza
I just want to let you know that the site zappa.io and all its subdomains are down. The domain name does not resolve.

yes, this domain is not controlled by the zappa community.
closing.


Colour coordination tweaks

Change the border colour to '#B6CEFC80' when in dark theme

assign to me pls

@mshokoya done


Qdrant (and other memory stores?) - support rigid filtering

I have structured and unstructured data that I need to search using both vector similarity and structured data filtering.
Qdrant supports payload filtering alongside vector similarity (as far as I know, Pinecone does as well), but the IMemoryStore interface does not currently support it.
What do you think would be the best way to address this issue?

Support rigid filtering through the IMemoryStore interface. I'm willing to work on this if it's decided that this is the approach to take.
Create my own class that inherits from QdrantVectorDbClient (or just copy it) and extends the base class with methods that support rigid filtering. I would then use this extended class explicitly in a skill.
Is there another recommended approach?

Thank you in advance.
P.S. This library is really cool! 👌

@piotrek-appstream , great idea!  @awharrison-28  and @tawalke  does this look like the right approach?

I agree that there is value in integrating semantic search capabilities with filtering functionalities for the structured segment of data. However, simply extending IMemoryStore may not be sufficient. Currently, it is not exposed either through SkContext or SemanticKernel, correct?
I was thinking about a solution that would allow us to use it seamlessly within the skill, just through context.Memory. What are your thoughts on the following options:

Extending ISemanticTextMemory with the following method:

public IAsyncEnumerable<MemoryQueryResult> SearchStructuredAsync(
       string collection,
       string query,
       int limit = 1,
       double minRelevanceScore = 0.7,
       bool withEmbeddings = false,
       IFilterExpression? filters = default, // some kind of expression to filter by payload fields
       CancellationToken cancellationToken = default)

This way, in the skill, we can simply use context.Memory.SearchStructuredAsync.

Introducing a new interface, ISemanticStructuredMemory, specifically designed for partially structured memories. It could be configured using .WithStructuredMemoryStorage(...) and utilized in the skill as context.StructuredMemory. I understand this option may require more effort, but it would allow us to tailor methods like SaveInformation or SaveReference in the new interface to better suit partially structured data.

@evchaki we have a PR ready for that, first with Qdrant, but designed in a way to be extendible for other memory stores without limiting their capabilities (source specific generic filter argument).
Would appreciate to get some feedback :)
Thanks!

All .Net issues prior to 1-Dec-2023 are being closed. Please re-open, if this issue is still relevant to the .Net Semantic Kernel 1.x release. In the future all issues that are inactive for more than 90 days will be labelled as 'stale' and closed 14 days later.


REP-33: transition to Review

I think we have not agreed on the grace period for a Node to transit into exited.
https://forum.rss3.io/t/rep-33-node-state-transition/173/2?u=henry

closed in favor of #46


Add dev profile to pom.xml

This allows a developer to run
./mvnw verify -P dev

and it will autoformat and skip long tests.

I'd rather not ignore all tests by default. We can discuss a better default though.


Use relaxed type (for unproven int subranges) in declarations for SMT solvers and stability parallelism

Stability's looking good :D


[MNT] Fix loop reassignment

What does this implement/fix? Explain your changes.
flake8 pre commit check: "B020 Found for loop that reassigns the iterable it is iterating with each iterable value"
PR checklist

For all contributions

[ ] I've added myself to the list of contributors.
[ ] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[X] I've added unit tests and made sure they pass locally.
[X] The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.

Thank you, good catch, Stanislav! 👍


testing PR

Make i mention myself

Missed @heywhy

Testing comment @heywhy

checking events

@heywhy mentioning myself

@heywhy shey you get notif

@heywhy testing notify again

are you thinking what I'm thinking @heywhy ?

Make I talk @heywhy ?

hello man how is the test going? @heywhy

hello majsjkas @heywhy @heywhy-test askkas


Larger data set

By chance, do you have a larger data set for the auto-correction functionality?

@drashna There's a larger list here that I'm working on integrating. The code has to be updated for apostrophe input:
https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

Too many entries in that to really apply.
eg, https://gist.github.com/drashna/46c64ea29a382f754b2cf957ebd8e924
I'm running the autocorrect code on a blackpill based controller, so that has a lot more system memory and program memory than the atmega32u4, and amuch higher clockspeed.
would it be possible to expand the number of possibly entries.

@drashna thanks for the awesome idea! A larger dictionary would be useful. And thank you @filterpaper for that helpful Wiki link, plus your other help already on email for improving the autocorrection feature.
I combed over the list and some other sources to make a larger 400-entry dictionary:
https://github.com/getreuer/qmk-keymap/blob/main/features/autocorrection_dict_extra.txt
It builds to a table of about 6000 bytes, so it's big but plausible depending on the board. I tested out that it works successfully on Moonlander.
Going beyond that, I tried building your ~3000 entry dict and see that it fails with AssertionError on assert 0 <= byte_offset <= 0x7fff. This assertion comes up because the implementation uses 15-bit offsets to link between trie nodes (using a uint16 where the high bit has a separate purpose). There is a description here if anyone is interested in the details. So the implementation currently supports a table up to 32 KB, or on the order of 2000 entries, which is not large enough for your dict.
There are many links in the trie, so I'd rather not simply increase the offsets' bit width if it can be avoided. I have a couple ideas, I'll think this over and report back when I have something.

Yeah, @filterpaper and I have both been messing with the code.
And yeah, ran into the assertion error, and figured that was the case.  But I'm not too sure what all is going on in this code, so fixing/improving it is over my head.

@drashna in commit 99a2b160963129f9efb6062ee6ab41b1115308e7, I worked out a revision to increase the max supported table size from 32 KB to 64 KB. I successfully built your ~3000 entry dict:
Processed 2982 autocorrection entries to table with 48293 bytes.

It flashed and worked successfully on my Moonlander. It's cool to be running autocorrect with that many entries.
Side note: There are "false trigger" warnings on that dict. Install the "english_words" Python package to enabled this checking (pip install english_words). Here is a sampling:
Warning:1483: Typo "hten" would falsely trigger on correctly spelled word "heighten".
Warning:1487: Typo "hting" would falsely trigger on correctly spelled word "nightingale".
Warning:1666: Typo "interm" would falsely trigger on correctly spelled word "intermediary".
Warning:1786: Typo "lsat" would falsely trigger on correctly spelled word "pulsate".
...

For practical use, I'd add word breaks (e.g. :hten:) before and/or after those entries to avoid these false triggers.

Yup, I saw. I was looing at the issue and noticed it was closed.
And thank you!   And yeah, it's nice having the option for a much larger data set on boards that can support it!
Also, filterpaper got it working with progmem.  That doesn't matter on boards like the moonlander, but for AVR boards... it can be important.

Tested the changes, and it doesn't work for me.  I suspect that there are some changes to the autocorrect.c file that didn't get pushed?

D'oh, you are exactly right. I just added the forgotten autocorrect.c update in commit da5aacdb05b35c77656062ca8f2c2add8f96047b.

Well, I can't say that I haven't done the same. 😆
And yeah, with those changes, everything is working again!

@getreuer Thank you for the updates!


Event listener tags

There are several cases where you might want to add some actors to the stage after a delay, when certain condition is met (for example: a button is clicked). For now, you can solve it by attaching a standard listener, which invokes a Java method that loads another template - for example, the one containing dialog data. However, it would be really useful if you could solve this issue entirely with LML code:
<button>
  <onClick>
    <dialog> ... </dialog>
  </onClick>
</button>

In the example above, a Dialog instance would be shown on the screen when the Button is clicked, rather than immediately added to the stage.
Such tags could be added in two ways:

macros: data between their tags would be stored as simple string and parsed as soon as the event occurs to show the requested actors. This would require to parse the template multiple times (unless cache mechanism is added) for each event. The templates would be in a separate context: any arguments from the original file would not be accessible.
tags: a special group tag would have to be added. Actors would be parsed immediately along with the rest of the template and added to the specialized group, only to be stored until the event occurs. This would allow to create actors within the same context and keep local "variables" ({arguments}). Actors would be created unnecessarily if the event never occurs though, so macro solution would still be preferred if the event is expected to occur rarely.

I think both ways would have their uses and both should be available. ClickListener and ChangeListener are obvious choices, not sure if any other listeners should be added.

I have a LmlView created with #createView.
If I want to display a dialog that would get called by my Java code (for example to display a warning).
For this I would have a custom <:macro alias="warning dialog"> or a simple template with the dialog (need your suggestion here).
And then, when my java code wants to display the dialog, it would call LmlParser#fillStage("dialogtemplate.lml", LmlView$getStage())?
In this case, it's better to have a dedicated template than a custom macro right?

@jpsgamboa, now the default way of handling such situation is using a listener tag or macro: onClick, onChange, :onClick or :onChange. gdx-lml-tests and gdx-lml-vis-tests projects are already updated with example uses of all 4 of these tags.

Thanks! May I ask you for an example of how would you implement a generic dialog with "yes" or "no" buttons that could be called from an event like this via LML or directly from Java code?
The example you provided above would serve as generic "warning" dialog, but what if I wanted a generic structure with 2 buttons? How could I handle the click event on those buttons for differently in different contexts?
Sorry if I'm repeating questions.

<:macro alias="showChoice" replace="content" title="@choice" onYes="close" onNo="close">
  <onChange>
    <dialog title="{title}">
      {content}
      <textButton onResult="{onYes}">@yes</textButton>
      <textButton onResult="{onNo}">@no</textButton>
    </dialog>
  </onChange>
</:macro>

<!-- Closes on no, invokes myAction on yes: -->
<:showChoice onYes="myAction">
  Do you really want to do it?
</:showChoice>

I have a doubt regarding the button attribute of the :clicklistener  macro. The java class says it attaches the clicklistener  the button ID I choose, but why is this an option if the <:clicklistener> will already be inside the <button> tag like this:
<textbutton>
    Click me.
    <:clicklistener>
        <:doSomething></:doSomething>
    <:clicklistener>
</textbutton>

Or the idea is to be able to do this?:
<:clicklistener button="button1">
    <:doSomething></:doSomething>
<:clicklistener>

<textbutton id="button1">
    Click me.
</textbutton>

Getting a NullPointerException in the following scenario:
Main View:
<table id="appRootTable" fillparent="true" align="top" debug="true">
    <:import path="templates/menubar.lml"/>
</table>

The imported menubal.lml (haven't gotten around to replace import with a macro as you suggested yet):
<menubar id="menuBar" growx="true" align="top" row="true">
    <menu<EMAIL_ADDRESS><EMAIL_ADDRESS>        <menuitem<EMAIL_ADDRESS>
<EMAIL_ADDRESS>            <submenu>
<EMAIL_ADDRESS>                    <:onclick cache="true">
                        <:showPosNegDialog title="my title">
                            Are you sure?
                        </:showPosNegDialog>
                    </:onclick>
                </menuitem>
            </submenu>
        </menuitem>

</menubar>

Finally, the global macro:
<:macro alias="showPosNegDialog" replace="content" title onPositive="close" onNegative="close" positiveText="Yes" negativeText="No">
<dialog title="{title}" defaultpad="4">
    {content}
    <textbutton onresult="{onPositive}">{positiveText}</textbutton>
    <textbutton onresult="{onNegative}">{negativeText}</textbutton>
</dialog>
</:macro>

The error is not much helpful, but it looks like when AbstractListenerLmlMacroTag.addActors calls actor.getStage() the stage is null, .
The error occurs when I click the button with the listener. The Actor is not null though, but his stage and parent are.
Full error:
java.lang.NullPointerException
	at com.github.czyzby.lml.util.LmlUtilities.appendActorsToStage(LmlUtilities.java:215)
	at com.github.czyzby.lml.parser.impl.tag.macro.AbstractListenerLmlMacroTag.addActors(AbstractListenerLmlMacroTag.java:84)
	at com.github.czyzby.lml.parser.impl.tag.macro.AbstractListenerLmlMacroTag.doOnEvent(AbstractListenerLmlMacroTag.java:77)
	at com.github.czyzby.lml.parser.impl.tag.macro.ClickListenerLmlMacroTag$1.clicked(ClickListenerLmlMacroTag.java:54)
	at com.badlogic.gdx.scenes.scene2d.utils.ClickListener.touchUp(ClickListener.java:89)
	at com.badlogic.gdx.scenes.scene2d.InputListener.handle(InputListener.java:58)
	at com.badlogic.gdx.scenes.scene2d.Stage.touchUp(Stage.java:353)
	at com.badlogic.gdx.InputEventQueue.drain(InputEventQueue.java:81)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Input.update(Lwjgl3Input.java:187)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Window.update(Lwjgl3Window.java:237)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.loop(Lwjgl3Application.java:122)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.<init>(Lwjgl3Application.java:95)

Or the idea is to be able to do this?:

<:clicklistener button="button1">
    <:doSomething></:doSomething>
<:clicklistener>

<textbutton id="button1">
    Click me.
</textbutton>

No. This the button ID from ClickListener API: see ClickListener#setButton.

I'm afraid this is not an LML issue. MenuItem reports null stage, as if it wasn't shown in the first place. Try the following code:
<menuBar>
  <menu text="menu">
    <menuItem>submenu
      <subMenu>
        <menuItem onClick="print">item
        </menuItem>
      </subMenu>
    </menuItem>
  </menu>
</menuBar>

    @LmlAction("print")
    void print(final MenuItem item) {
        System.out.println(item.getStage());
    }

You'll notice that null is printed to the console each time. That's why click listener cannot add the actors to the stage - there is no stage to begin with. Although this cannot happen if the actor is implemented correctly, I'll add a meaningful error to LmlUtilities. I'm afraid @kotcrab has to fix it in VisUI.
See https://github.com/kotcrab/vis-editor/issues/160.

Added LML workaround that extracts Stage from ancestors of the tag if no Stage is found on the actor with the listener attached. Your code should work now.

Or the idea is to be able to do this?:
<:clicklistener button="button1">
    <:doSomething></:doSomething>
<:clicklistener>

<textbutton id="button1">
    Click me.
</textbutton>

Now that I think about, it would be pretty useful if you wanted to reuse the same listener multiple times in one template - maybe not your usual use case, but might still be useful. Especially since you can add conditionals. Consider this:
<textButton id="someValue">
  <onClick if="$isError" attachTo="someValue;anotherValue">
     <dialog title="@error">@someError<button onResult="close"/></dialog>
  </onClick>
</textButton>
<textButton id="otherValue"/>
<textButton id="anotherValue"/>

@LmlAction("isError")
boolean isInvalid(TextButton button) {
  String id = LmlUtilities.getActorId(button);
  // proceed with validation
  return result;
}

This would allow you to reuse the click listener, while still allowing you to have some actor-specific treatment thanks to Java implementation. Again - not your usual use case, but we should allow that.

Listeners can be shared between multiple actors - or even views - thanks to the new ids and keep attributes. Snippet from the tests project:

<!-- Sometimes you might want to attach the same listener to
    multiple actors. You may even want to create some complex
    actors and share them across views. Thanks to "ids" and
    "keep" arguments, you can. The listener will be attached
    to all actors with the selected IDs. If "keep" is set to
    true, the listener will not be removed after template
    parsing and will be available in all views. Try adding
    'keep="true"' attribute, parse the template, then remove
    the whole listener and parse it again - you'll see that
    listener will still get attached:  -->

 <:onClick ids="clickA;clickB" cache="true">
    <dialog style="dialog" title="$random">
         Attached to multiple actors.
         <textButton onResult="close">Great.</textButton>
    </dialog>
 </:onClick>
 <textButton id="clickA">Same listener as next button.</textButton>
 <textButton id="clickB">Same listener as previous button.</textButton>

@jpsgamboa, I'd appreciate if you looked into the new input listener tags. Examples are already updated.

Sorry for the delay.
Can confirm the AbstractLmlTag#determineStage workaround is working! Nice one.
The new ids attribute is also working fine for me. I think this is a very nice addition. Feels intuitive and gives us a lot of freedom!
PS: It's funny how in just a few hours time frame that I don't read the updates here, your comment chain always goes from "maybe it would be nice to.." into "implemented it".

Yeah, I want to finish up LML to be honest. Since Scene2D API is pretty much covered and LML is more or less clean, I don't think there are going to be any major changes from now on. That's why I want to implement the missing features and do some refactoring before releasing the next version.


Fixes for psql window functions

Fixes #185

Thank you so much for the PR.
Can you add a test that uses a window function here?
https://github.com/stephenafamo/bob/blob/main/dialect/psql/select_test.go
Also run go generate after to add it to the examples in the documentation.

Added, let me know if anything else needs changing

All looking good 👍🏾
I also remembered by that argument was included, it was to support this form of window functions OVER window_name
Would it be possible to support that with your changes?

Also, if Valid() is now unnecessary, kindly delete it.

Updated. Looks like .From() was already there to specify a named window.

Thanks for this PR.
I will later make some additional changes to properly construct OVER window_name window functions.


Support custom names for reference and current

Description:
Add a new option that can be passed to any Evidently Report that would allow replacing “Current” and “Reference” display titles across the Report. For example, define it as current_title, and reference_title.
Context:
All Evidently Reports and Metrics refer to “Current” and “Reference” datasets. Reports can also be generated only for one (“Current”) dataset.
The names “Reference” and “Current” are visible side-by-side in Metric titles. Example:

They are also included in the render of the individual plots or as part of the visualization or legend. Examples for DataDriftTable:

Example for ColumnSummaryMetric

Sometimes users want to override the default titles and set different names for their dataset and models. For example, when generating a model comparison report for two models, you might want to call them “Model A” and “Model B”, or refer to your datasets as “training” and “testing” datasets, etc.
We want to add the functionality that allows changing the display title.
Note: the existing implementation of the reference and current names is not entirely consistent across Metrics. A thorough testing is required to ensure that changes propagate to all Metrics and renders.
Implementation:

Implement a new current_title and reference_title options that can be passed to all individual Reports. This is a Report-level render option. You can look at the implementation of “raw_data” or “color_schema” options for inspiration.
Document the option by adding a new section titled “Changing the names of “Reference and Current” to this docs page.
[OPTIONAL] add a how-to notebook showing the new functionality, similar to the other ones. The how-to notebook should include a very short example to show the usage of the parameter with a few different metrics and any of the metrics presets.

The option should work as the following:
report = Report(
   metrics=[
     RegressionQualityPreset(),
   ],
   options={"render": {“current_title”:”ModelA”}}
 )
report.run(reference_data=housing_ref, current_data=housing_cur)
report

I would be happy to contribute to this, if nobody else started working on it :)

I believe noone did @francesco086 !

Sry I got super busy lately. But I want to do this one. I believe I will be able to work on it Friday next week. I will come with an update

Hello, I wonder if this issue has been fixed and if there is any documentation related. Thanks!

Oh! Thanks for writing... I wanted to contribute on it but I had some private issues and then it slipped out of my mind. If it's not too late, I will invest some time on this one.

Update: I have been working on this yesterday and today, but it will take some time.
It's quite a pain tbh, hard-coded string "reference" and "current" are pretty much everywhere...

Hi, after a long pause when I could not find time anymore for this, I am back to this.
I would need some help.
I would like to explain my approach.
Since I don't know the code base and I believe in TDD, I am trying to write some simple tests that verify that the label "current" and "reference" are not output in the html.
This, in principle, should allow me to reverse-engineer where the label is coming from, and modify it there.
Unfortunately I underestimated in how many places these strings are hard-coded.
This is current PR (on my fork because I don't want to include the recent changes in the main): https://github.com/francesco086/evidently/pull/1
Notice that, to track where the string comes from, I started to add so
me identifiers, e.g. "current" -> "currentA".
Now we come to my help request.
Take this test: https://github.com/francesco086/evidently/pull/1/files#diff-309694ab0894d514be87278c134219f3f3432d934988647692f0e9c7be1af37fR85
The resulting html is here result.txt (it's in txt because github does not support html file upload).
Could someone tell me where the "current" and "reference" labels are set for these two plots. I cannot find it...

@francesco086 sorry for taking so long to respond!
I left a few comments in your pr

@DimaAmega thanks for your comments, I answered.
My impression is that perhaps are implicitly set starting from the column names in the dataframe. I would then rename the df column accordingly before the plot. But I would need to know where this happens...


Extension issue

Issue Type: Bug
Extension Name: LiveServer
Extension Version: 5.6.1
OS Version: Windows_NT x64 10.0.17763
VSCode version: 1.45.1

:warning: We have written the needed data into your clipboard. Please paste! :warning:

https://github.com/ritwickdey/vscode-live-server/issues/new/?body=- Issue Type: Bug

Extension Name: LiveServer
Extension Version: 5.6.1
OS Version: Windows_NT x64 10.0.18362
VSCode version: 1.45.1

:warning: We have written the needed data into your clipboard. Please paste! :warning:&title=Extension issue


Unpack automatically after download

Unpack automatically after download #37 - allows to disable auto-unpack.
Keeps the unpack command in case someone wants to make it separately.

@cholmes Ready for review

lol. It was 'lgtm' (looks good to me), auto-corrected on my phone...


Add CI!

This MR adds GitHub Actions for CI! Because the steps to build the container image and run tests were already done in the makefiles this is more or less equivalent to the existing GitLab CI config.
By using a self-hosted runner we solve two problems:

vrnetlab devices run as virtual machines and many require access to hardware virtualization extensions to even boot up. This means we cannot use GitHubs (free) runners except for the very basic containers. IME (n=1) even running a virtual machine with hardware assisted virtualization enabled (VMware) is not sufficient, it has to be bare metal.
Disk images are not committed to this repository, but are rather accessible directly on the runner.
I set up a self-hosted runner on one of the machines that satisfies the requirements. It runs one job at a time so the total time with the current set of tested images is about two hours.

There is still more work to be done:

[x] Put the container images (and containers) into a private namespace while they are being built. For example, we always produce the vrnetlab/vr-xcon:latest image. If the runners are completely isolated this is not a problem, but they are not ...
[ ] Add workflows to automatically push ci-builder, vr-bgp, vr-xcon, (maybe even some routers??) container images to:

[ ] Docker Hub
[ ] GitHub / GitLab Container Registry, depending on where CI runs

Closes #212

@mzagozen LGTM. I mentioned I prefer more stuff in Makefiles etc for local dev, testing. Not at all a dealbreaker though. Good job!
We can merge this as-is, right? Or do you feel you want to close the remaining items in same PR? Up to you. Feel free to merge.

Just a comment on pushing images to docker hub etc. My idea was that we, the upstream repo, decides to push to all those registries. At least for the ci-builder image. It means the consumer, which could be another CI job running in GitHub Actions or in Gitlab CI or perhaps you are just running something locally on your machine, would then grab it from the best source. For GitHub Actions the best source is GHCR since there are no quotas. Similar for GitLab CI it should use Gitlab registry. Anyone else probably does best in using docker hub? GHCR has severe quota, right? 1GB, so not suitable for public. Not sure about Gitlab? Docker Hub has rate limit, so users has to sign in, but it's still free, right? Just need an account.

We can merge this as-is, right? Or do you feel you want to close the remaining items in same PR? Up to you. Feel free to merge.

I resolved what I consider a blocker (name collisions on "shared" runner) by prefixing the images with the GHCR address. The containers get the pipeline id prefix too so it should be safe to run now.

Just a comment on pushing images to docker hub etc. My idea was that we, the upstream repo, decides to push to all those registries. [...]

I agree, but will do that later.

Wop wop! Good job @mzagozen


feat: separate status property on step component

Description
Remove status property and transform it into new individual properties:

Selected,
Checked, and
Error.

Expected Behavior
Have specific properties for each status
Current Behavior
Currently, all statuses are grouped into a single property. Because of this, we have already faced problems rendering changes in status change detection.
Additional Information
This improvement/adjustment is part of a package of improvements planned together. For full documentation, access the file here:
Novas Sugestões para Stepper do Ion.pdf.
Concluding

[ ] Exclude status global property
[ ] Add selected property
[ ] Add checked property
[ ] Add error property

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

eu


Thread Error when called TakePhoto

Hello!
I used your wrapper with Canon EOS 7D in WPF Application.
I successfully used LiveView functions, but i have a strange problem with TakePhoto function.
If i do as in your Example (call TakePhoto in button click handler) than all OK.
But in my App i used some functions after, like this:
CameraHandler.TakePhoto();
UpdateState();
etc...
In this case TakePhoto suspend in limitless loop somewhere in STAThread as far as I understand. How i should use this function?

TakePhoto when called does not finish immediately. The camera is busy creating a file then writing to the disk or memory buffer. So you can't make any calls until the camera is finished with those events.
here is the sequence:
TakePhoto
ObjectEventState
DirectoryItemCreated
Download
after download is complete then you can update the state.


syntax highlighting for jsp

What steps will reproduce the problem?
Would it be possible to add syntax highlighting for jsp? Jsp is really
similar to HTML.

Here is an example:
http://code.google.com/p/micrite/source/browse/tags/0.4/modules/micrite-security
/src/main/webapp/security/login.jsp

What is the expected output?  What do you see instead?
The source code is not highlighted. It would be nice to have syntax
highlighting.

Please provide any additional information below.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 3 May 2009 at 4:57

As far as I can tell, JSP and PHP or similar markups with embedded code inside <% ... %> or <? ... ?> sections are supported (see #3).
Here is a live example: https://jsfiddle.net/amroamroamro/zr9ywbhc/


aemulator - option to build and run Android project

if $1 present and is Android project, build it onto the emulator
./gradlew assembleDebug?
maybe list all possible flavours

impelmented as abuildproject


Squared does not seem to change the shape of the cutouts

I am on a conda evironment using imgaug v0.4.0 on Windows 10.
When using the code below and applying it to an image the cutouts do not change shape and are consistently square. I am sure this is not intended behaviour and have tried this with squared set to False as well with no change.
(Note: I am running other augmentations as well but this is the only one that does not produce intended results.)
aug = iaa.Cutout(nb_iterations=(1, 3), size=0.25, squared=0.5,
                   fill_mode="constant", cval=(0, 255),
                   fill_per_channel=0.5)

Any help or info would be great! Thanks

You just forgot to change size to a non-constant value, e.g. size=(0.05, 0.5). Otherwise every cutout region will have 25% size of the x- and y-axis. (I guess your images are square, leading to the cutout regions always being squared?)

Ahh that makes sense! thanks so much, yes you are right.


i18n(ar): Update astro-pages.mdx translation

Description (required)
I updated astro-pages.mdx. It has been corrected to conform to the latest English documentation.

Related issues & labels (optional)

Closes #
Suggested label:

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.


mouse example broken

the mouse example throws this error:
TypeError: function takes 2 positional arguments but 1 were given.

d'oh! the HID library changed. easy fix. see #14.

d'oh! the HID library changed. easy fix. see #14.


Fix dep verifier

This should fix the spurious issues from the dependency verifier. It turned out that GitHub's checkout action doesn't checkout the PR but a new ref that is the PR merged into master. This broke the assumptions of the verifier and caused much havoc.

/land

:broken_heart: Test Failed - commit-workflow

/help

Bors help and documentation

Bors is a Github App used to manage merging of PRs in order to ensure that CI is always green. It does so by maintaining a Merge Queue. Once a PR reaches the head of the Merge Queue it is rebased on top of the latest version of the PR's base-branch (generally master) and then triggers CI. If CI comes back green the PR is then merged into the base-branch. Regardless of the outcome, the next PR is the queue is then processed.
General

This project's Merge Queue can be found here.
This project requires PRs to be Reviewed and Approved before they can be queued for merging.
Before PR's can be merged they must be configured with "Allow edits from maintainers" enabled. This is needed for Bors to be able to update PR's in-place so that Github can properly recognize and mark them as "merged" once they've been merged into the upstream branch.

Commands
Bors actions can be triggered by posting a comment which includes a line of the form /<action>.

Command
Action
Description

Land
land, merge
attempt to land or merge a PR

Canary
canary, try
canary a PR by performing all checks without merging

Cancel
cancel, stop
stop an in-progress land

Cherry Pick
cherry-pick <target>
cherry-pick a PR into <target> branch

Priority
priority
set the priority level for a PR (high, normal, low)

Help
help, h
show this help message

Options
Options for Pull Requests are configured through the application of labels.

          Option
Description

Indicates that the PR is high-priority. When queued the PR will be placed at the head of the merge queue.

Indicates that the PR is low-priority. When queued the PR will be placed at the back of the merge queue.

Before merging the PR will be squashed down to a single commit, only retaining the commit message of the first commit in the PR.

/land


Update cc!addnote to work even if the user has left the server

Purpose
This will permit us to add notes to users if they've left the server (or have been banned).
Proposed Solution
Still need to do some research to figure out how to verify user ID without making use of any references to guild. This issue is similar to #163 and #164 and the same or a similar solution can be applied here.
Acceptance Criteria
Please list the requirements the implementation of this feature should meet.

[ ] cc!addnote should work on members who are no longer in the guild.

Do we also want cc!warn to be included in this issue?

Text commands have been phased out.


Getting Error : Selenium2Library' object has no attribute '_current_browser'

Hi,
i am trying to create custom python library which will help me for further operation using robot framework but currently i am facing below issue. Can someone please help me with the same.
Python file test.py
`import urllib
from robot.libraries.BuiltIn import BuiltIn

def get_webdriver_instance():
    se2lib = BuiltIn().get_library_instance('Selenium2Library')
    return se2lib._current_browser()
`

Robot file

` *** Settings ***
Library                                             Selenium2Library
Library                                             C:\\Users\\Username\\workspace\\webapplication.sample\\src\\test\\robotframework\\common\\lib\\test.py

*** Test Cases ***
RobotTest
    Open Browser                                    https://finance.google.co.uk/finance     gc
    ${webdriver}=     Get webdriver instance
    Log    ${webdriver}
    saveImage        ${webdriver}    //a[@id='aw0']/img    Myimage.png
    # saveImage1       //img[contains(@src, 'logo.png')]    myfile11sdasd1.pn
    Log    ${webdriver}
    # Wait Until Element Is Not Visible    xpath=//div[@id='splash']/div[3]/div
    Sleep     20
    Click Element    xpath=//div[@id='splash']/div[3]/div`

Error

Start / End / Elapsed:	20171020 19:53:14.261 / 20171020 19:53:14.290 / 00:00:00.029
19:53:14.279	FAIL	AttributeError: 'Selenium2Library' object has no attribute '_current_browser'

how did you resolve this issue?

@dipakbachhav  can you share the solution?


Highlight new comments in post view and show how many there are in list view

If we keep track of when users last checked a post's comments, we can

highlight comments that were posted after the last time they checked

in the list view, change the link to the comments to say something like '97 Comments (96 New)'

This could be done together with #225 and a view counter for posts. We'll have to start tracking visits (uid, date) to posts.


[CARBONDATA-2557] [CARBONDATA-2472] [CARBONDATA-2570] Improve Carbon Reader performance on S3 and fixed datamap clear issue in reader

[CARBONDATA-2557] [CARBONDATA-2472] Problem : CarbonReaderBuilder.build() is slower in s3. It takes around 8 seconds to finish build()
Solution: S3 is slow in listFiles, open, FileExist, getCarbonFile operations. So, List down all the calls of those API in the reader flow and remove the redundant checks.
[CARBONDATA-2570]  Problem : Carbon SDK Reader, second time reader instance have an issue in cluster test
Solution: Blocklet datamap's of first time reader is not cleared properly in the cluster. Need to change the API to clear the blocklet datamap.
so change
DataMapStoreManager.getInstance().getDefaultDataMap(queryModel.getTable()).clear();
to
DataMapStoreManager.getInstance().clearDataMaps(queryModel.getTable().getAbsoluteTableIdentifie());
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed? NA

[ ] Any backward compatibility impacted? NA

[ ] Document update required? NA

[ ] Testing done
Added UT

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.  NA

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5106/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6113/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4951/

It seems the method you added is dead code since no one calls it except from test.

@xuchuanyin : This is one of the exposed method in SDK reader now. External client can make use of it to get schema by passing index file path.
You can refer the other methods in this file. This is not a dead code

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6149/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4987/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5025/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6186/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5160/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6189/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5028/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5163/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6199/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5173/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6205/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5044/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6207/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5045/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5049/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5180/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6211/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6215/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5053/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5190/

@ravipesala : please review the PR.
With these change CarbonReaderBuilder.build() performance has improved by 50% on S3.

Have you add it in this PR?
so change
DataMapStoreManager.getInstance().getDefaultDataMap(queryModel.getTable()).clear();
to
DataMapStoreManager.getInstance().clearDataMaps(queryModel.getTable().getAbsoluteTableIdentifie());

@xubo245 : Yes, It is there in PR, refer the  CarbonRecordReader.java

ok, I will try It in my local machine

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6227/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5065/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5199/

retest this please

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6234/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5074/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6236/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6237/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5075/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5207/

@ravipesala : please review this PR. Build is success.

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5216/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6246/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5084/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5218/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5086/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6248/

LGTM


Remove wrapper scripts from musl causing a glibc dependency

Requiring bash here meant requiring glibc
No one wants glibc with their musl

How about moving them to a separate output, such as bin? Then they'll still be available if needed but will typically be excluded from dependers' closures.

I don't think musl-gcc and the like are spurious junk we can just get rid of.
If you want pure musl packages, use pkgsMusl instead.

Fixes #75476 for me

@symphorien can you show how you'd get a pure musl package without glibc given the sample project in #75476 without this change?

@r-burns possibly a decent solution, I'll see if I can't split it off. Ideally though the musl scripts would use a bash built against musl, but that seems impossible without moving the scripts to their own derivation? I'm still new-ish to writing nix but hard to see how it'd be possible otherwise.

@symphorien can you show how you'd get a pure musl package without glibc given the sample project in #75476 without this change?

let
  musl = (import <nixpkgs/lib>).systems.examples.musl64;
  musl-pkgs = (import <nixpkgs> {}).pkgsMusl;

  host-pkgs = import <nixpkgs> {};

  build = pkgs:
    let
      inherit (pkgs) stdenv;
    in
    stdenv.mkDerivation {
      name = "hello";
      src = ./.;

      buildPhase = ''
        $CXX hello.cc
      '';

      installPhase = ''
        mkdir -p $out/bin
        cp a.out $out/bin
      '';
    };
in
  {
    host = build host-pkgs;
    musl = build musl-pkgs;
  }

$  nix-build -A musl
these derivations will be built:
  /nix/store/3jkmx2gz2ps8q7hf2y1svxfy3jvn0ms9-hello.drv
building '/nix/store/3jkmx2gz2ps8q7hf2y1svxfy3jvn0ms9-hello.drv'...
unpacking sources
unpacking source archive /nix/store/6wqpdbiyk98q0s8ipgmdv286515d7v97-foo
source root is foo
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bnd7srs7x7h81574q5drnsvnmqrf5yxb-hello
shrinking /nix/store/bnd7srs7x7h81574q5drnsvnmqrf5yxb-hello/bin/a.out
strip is /nix/store/cdbsfljc8m900axs37fab7gnp2y1dksn-binutils-2.31.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bnd7srs7x7h81574q5drnsvnmqrf5yxb-hello/bin
patching script interpreter paths in /nix/store/bnd7srs7x7h81574q5drnsvnmqrf5yxb-hello
checking for references to /build/ in /nix/store/bnd7srs7x7h81574q5drnsvnmqrf5yxb-hello...
/nix/store/bnd7srs7x7h81574q5drnsvnmqrf5yxb-hello

$  nix-store -qR result
/nix/store/dl4gwchzfl6gxaf8xgvrva29k9m2zk77-musl-1.2.0
/nix/store/78iyhz8ci6vdqzybf1bl9kbs45w2bv94-gcc-9.3.0-lib
/nix/store/bnd7srs7x7h81574q5drnsvnmqrf5yxb-hello

As  I said, if you want a pure musl artifact, the most direct solution is to use a pure musl toolchain, that is pkgsMusl.
Anyway, I think removing musl-gcc is a regression and thus not an acceptable solution.

@symphorien fair enough, I didn't like it either to be quite honest, but was confused entirely by the musl -> bash -> glibc dep chain going on, which seems... wrong. Even if you do depend on the musl-dev shouldn't that avoid relying on glibc as it may inherently blow up closure size in some cases where the -dev related stuff is needed still?
My ultimate goal with this work is to be able to cross compile, with musl, to multiple target archs as well so I'm not sure if that changes the outcome here

If you insist on cross compiling and not having glibc in the build-platform compiler, then you should cross compile from a musl build platform. Untested, but pkgsMusl.pkgsCross might do that.

I do think -dev shouldn't depend on bash and glibc by default, but I agree with comments that removing the scripts isn't the right path. Closing


Use compileOnly configuration when checking dependency versions, faster.

Signed-off-by: dblock<EMAIL_ADDRESS>Description
Followup from https://github.com/opensearch-project/opensearch-build/pull/414#discussion_r706357455. Looks like compileOnly is inherited by all projects.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #495 (0ac3f93) into main (9a5843f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   68.97%   68.97%
=======================================
  Files          58       58
  Lines        1473     1473
=======================================
  Hits         1016     1016
  Misses        457      457

Impacted Files
Coverage Δ

...ow/src/ci_workflow/ci_check_gradle_dependencies.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5843f...0ac3f93. Read the comment docs.


Team/Org discussions: Initial commit

DO NOT MERGE
This merge request is work in progress published here as draft to coordinate the work with the rest of the team.

Pair-programming: https://go.codetogether.com/#/051cb379-92f2-40e8-8c83-86e7c00441d2/GHkQneZm1ahbShpHhI6Jpu
Fixes: https://github.com/go-gitea/gitea/issues/14562
Current status
Rework of the merge request
TODO

[ ] Rework the merge request based on new finding and brainstorms.
[x] Initial frontend implemented

[x] Page with button "Ping"

[x] Initial backend implemented

[x] Button "Ping" outputs "PING" in console
[ ] Button "Submit" outputs content of message field above it in console

[ ] Data management

[ ] TBD

[ ] Full Backend implementation

[ ] TBD

[ ] Full Frontend implemented

[ ] Convert the current issue form in a template usable for discussions
[ ] Propose mock-up to upstream
[ ] TBD

[ ] API implementation

[ ] TBD

[ ] Make discussions opt-in

[ ] Per Organization
[ ] Per Team

[ ] Resolve DNM (Do Not Merge) tags
[ ] Optimize CI/CD
[ ] Update documentation
[ ] Handle legality
[ ] Implement translations
[ ] Remove Docker Refactor used here only for testing (proposed in https://github.com/go-gitea/gitea/pull/14626)
[ ] Provide summary of a design and decisions in merge request's original post

Brainstorm: Data management
TBD
Signed-off-by: Jacob Hrbek<EMAIL_ADDRESS>
Merge process
Squash commits using GitHub UI with topic and message from original post of a merge request without 'Merge Process'

Transferred in https://github.com/Kreytea/kreytea/pull/1 will be submitted to upstream once finished.


[KOGITO-8281] - Adding redirects from version number to 'latest'

Signed-off-by: Ricardo Zanini<EMAIL_ADDRESS>
JIRA: https://issues.redhat.com/browse/KOGITO-8281

Description:
Documentation references:

https://docs.antora.org/antora/latest/playbook/urls-redirect-facility/
https://docs.antora.org/antora/latest/playbook/urls-latest-version-segment-strategy/

Please make sure that your PR meets the following requirements:

[x] You have read the contributions doc
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[x] The nav.adoc file has a link to this guide in the proper category
[x] The index.adoc file has a card to this guide in the proper category, with a meaningful description

How to setup automatic cherry-pick to another branch ?

The cherry-pick action allows to setup automatic cherry-pick from main to a specific branch.
To allow it, you will need to add the corresponding label with pattern: backport-{RELEASE_BRANCH}.
For example, if a backport to branch 1.26.x is needed, then the label should be backport-1.26.x.
Once the PR is merged, the action will retrieve the commit and cherry-pick it to the desired branch.
NOTE: You can still add label after the merge and it should still be cherry-picked.

Closing since we don't have a web server to create the redirect rules, and we want to keep the latest URL.


Please invite me to the GitHub Community Organization

Name
Emma Wain
Discord Username (if applicable)
ewainy # 0401
Additional Context
I met Eddie on Twitter, started following and talking to him because he was so positive and supportive and doing amazing things in the community! I want to join Eddie's community because it is inclusive and so that I can help in any way possible and give back to the community and help others along their way on their journey 😊

Welcome to the community ❤


Bump the SDK version to follow the controller refactor

Bump SDK version to 2.3.0 after the merge of the PR kuzzleio/kuzzle#569.
See kuzzleio/sdk-javascript#152 for more details.

should be 2.3.4 after the merge of  https://github.com/kuzzleio/sdk-javascript/pull/165

and need also to fix userAuthorization service with new contoller/action names


How to Automatic Row Binding

Issue Type (delete the irrelevant ones)

[x] Question
Specs
What version are you using?
v2.19.1
What browser?
Not tested yet

I have a question that I get a data array[{}] from database. Then how can I add rows to the component automatically.

Use a computed.

closing.


Kind e2e tests are failing continuously with source not becoming ready.

Describe the bug
While trying to update the dependencies to k8s 0.19.7 a kind e2e test failed here:
https://github.com/knative-sandbox/eventing-camel/pull/48/checks?check_run_id=1777588157
with:
    camel_source_test.go:94: Waiting for all resources ready
    tracker.go:153: Waiting for all KResources to become ready
    operation.go:95: Failed to get all KResources ready failed waiting for {TypeMeta:{Kind:CamelSource APIVersion:sources.knative.dev/v1alpha1} ObjectMeta:{Name:e2e-camelsource GenerateName: Namespace:test-camel-source-2n8j4 SelfLink: UID: ResourceVersion: Generation:0 CreationTimestamp:0001-01-01 00:00:00 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]}} to become ready: timed out waiting for the condition
    operation.go:116: Failed to get all test resources ready: failed waiting for {TypeMeta:{Kind:CamelSource APIVersion:sources.knative.dev/v1alpha1} ObjectMeta:{Name:e2e-camelsource GenerateName: Namespace:test-camel-source-2n8j4 SelfLink: UID: ResourceVersion: Generation:0 CreationTimestamp:0001-01-01 00:00:00 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]}} to become ready: timed out waiting for the condition
        knative.dev/eventing-camel/vendor/knative.dev/eventing/test/lib.(*Client).WaitForAllTestResourcesReadyOrFail
        	/home/runner/work/eventing-camel/eventing-camel/src/knative.dev/eventing-camel/vendor/knative.dev/eventing/test/lib/operation.go:116
        knative.dev/eventing-camel/test/e2e.TestCamelSource
        	/home/runner/work/eventing-camel/eventing-camel/src/knative.dev/eventing-camel/test/e2e/camel_source_test.go:96
        testing.tRunner
        	/opt/hostedtoolcache/go/1.14.13/x64/src/testing/testing.go:1050
        runtime.goexit
        	/opt/hostedtoolcache/go/1.14.13/x64/src/runtime/asm_amd64.s:1373

Then looking at earlier runs to see if this is something ongoing, sure looks like it:
https://github.com/knative-sandbox/eventing-camel/actions?query=workflow%3A"KinD+e2e+tests"
Just picking one from the list (from several days ago to make sure not related to this change):
    operation.go:95: Failed to get all KResources ready failed waiting for {TypeMeta:{Kind:CamelSource APIVersion:sources.knative.dev/v1alpha1} ObjectMeta:{Name:e2e-camelsource GenerateName: Namespace:test-camel-source-4nkrz SelfLink: UID: ResourceVersion: Generation:0 CreationTimestamp:0001-01-01 00:00:00 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]}} to become ready: timed out waiting for the condition
    operation.go:116: Failed to get all test resources ready: failed waiting for {TypeMeta:{Kind:CamelSource APIVersion:sources.knative.dev/v1alpha1} ObjectMeta:{Name:e2e-camelsource GenerateName: Namespace:test-camel-source-4nkrz SelfLink: UID: ResourceVersion: Generation:0 CreationTimestamp:0001-01-01 00:00:00 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]}} to become ready: timed out waiting for the condition
        knative.dev/eventing-camel/vendor/knative.dev/eventing/test/lib.(*Client).WaitForAllTestResourcesReadyOrFail
        	/home/runner/work/eventing-camel/eventing-camel/src/knative.dev/eventing-camel/vendor/knative.dev/eventing/test/lib/operation.go:116
        knative.dev/eventing-camel/test/e2e.TestCamelSource
        	/home/runner/work/eventing-camel/eventing-camel/src/knative.dev/eventing-camel/test/e2e/camel_source_test.go:96
        testing.tRunner
        	/opt/hostedtoolcache/go/1.14.13/x64/src/testing/testing.go:1050
        runtime.goexit
        	/opt/hostedtoolcache/go/1.14.13/x64/src/runtime/asm_amd64.s:1373
    k8s_events.go:66: EventListener stopped, 7 events seen
    test_runner.go:215: Event{

A clear and concise description of what the bug is.
Expected behavior
A clear and concise description of what you expected to happen.
To Reproduce
Steps to reproduce the behavior.
Knative release version
Additional context
Add any other context about the problem here such as proposed priority

Closing this as per https://github.com/knative-sandbox/eventing-camel/pull/97.


Collada import: bones are incorrectly positioned

Godot version
v4.0.dev.custom_build [1906b5967]
System information
Archlinux, Vulkan
Issue description
I know that DAE models are obsolete and being replaced by GLTF, but for project migrating from Godot 3.0, it might be useful nonetheless to support them.
Here is a simple model with 3 bones done in Blender 3.0:

When exported using the Better Collada Exporter and imported using Godot 4.0, the bones are messy:

For comparison, here is the same model, but exported using the default Blender Collada exporter:

For information: using GLTF, the bones are fines after import.

It was then partially fixed by commit [a54fe3ffa81e4dd19d24031dfcd73ab7a65311c9] collada: fix error in use of fix_transform.
Steps to reproduce
Open the project, and create a new scene inherited from the skeleton_better.dae. The Blender file is also included for testing.
Minimal reproduction project
DAE_skeleton_Test.zip

Looks like it is linked to the bone rest position: changing values in the DAE file make the bone position moving (especially the last 16 numbers):
<source id="id-controller-7-bind_poses">
	<float_array id="id-controller-7-bind_poses-array" count="48">  1.0 -0.0 0.0 -0.0 -0.0 0.0 1.0 12.073701858520508 0.0 -1.0 0.0 -0.0 -0.0 0.0 -0.0 1.0    1.0 -0.0 0.0 -0.0 -0.0 0.0 1.0 0.1018838882446289 0.0 -1.0 0.0 -0.0 -0.0 0.0 -0.0 1.0    1.0 -0.0 0.0 -0.0 -0.0 0.0 1.0 -12.129661560058594 0.0 -1.0 0.0 -0.0 -0.0 0.0 -0.0 1.0  </float_array>

Maybe related to https://github.com/godotengine/godot/pull/53765

We couldn't budget enough effort on collada and https://github.com/godotengine/godot-proposals/issues/2130 is in limbo. Not sure what to do.


Fix / tvod issues

TVOD Fixes
These are fixes to tvod, discovered during the last BeIN Sports sprint: OTT-627

Inlineplayer not supporting tvod: the lock would still appear, because it didn't implement the isEntitled prop
Subscription not reloaded after login for non-svod platforms: tvod can be implemented for any accessmodal OTT-567
For premier items, the subscription offers where still shown, which shouldn't be OTT-604
Did some refactoring of useOffer(). Wanted to push it further, but I prefer to do this separately, as we want to move more logic from the containers/hooks to the controllers/services.

Todo

Still need to check if drm works properly, but I don't know of a (demo) config that has this properly set up. I will do this separately, perhaps combining it with the drm-related work of @ChristiaanScheermeijer

I've rebased this branch


Add a CONTRIBUTING.md

This should reference anything we need to about contribution agreements (for AMWA/non-AMWA members) and the defined practice used for repository branches from the wiki

Made a start (have to catch train now) on peterbrightwell-contributing branch

Merged (see PR #5)


Indexing new providers contracts

📄 Context
An original PR on Sunodo has an implementation for indexing new provider contracts. However, we have a lot of commonalities, and the API could index such contracts.
✔ Solution
Add the implementation of said contracts for indexing (use original PR as a reference). Also, consider the entity diagram below for implementation.

Entity diagram

New contracts (ABI) and events of interest:

AuthorityFactory

AuthorityCreated (topic)

ValidatorNodeProvider

MachineLocation (topic)
FinancialRunway (topic)
Paused (topic)
Unpaused (topic)

Marketplace

ValidatorNodeProviderCreated (topic)

New Entities:

Authority
ValidatorNodeProvider
ValidatorNode
ReaderNodeProvider ??
ReaderNode ??

📈 Subtasks

[ ] Add new contract ABIs.
[ ] Add new Entities to graphQL schema.
[ ] Generate new migrations.
[ ] Add new handlers for topics of interest.
[ ] Add test cases.

🎯 Definition of Done

[ ] Can successfully index the AuthorityFactory, Marketplace and ValidatorNodeProvider contract events.

@tuler,
In the original PR, I saw the definition of the ReaderNodeProvider and ReaderNode entities. However, I could not see an ABI nor any reference to saving during the implementation in the main.ts when working with the block/log. Is that some initial idea forgotten to clean up, or is it missing?


PROD SUPPORT : Scrutiny | Witness Designation is not visible

Describe the bug
FSO is not able to see designation of the witness, so if there is any issue in witness designation, he will not be able to mark it. It will make issue in PDF also as Witness designation will be shown in PDF generated automatically

Its visible


arrow-cpp: 12.0.0 -> 12.0.1

Description of changes
Bump arrow to 12.0.1, resolving issues with rPackages.arrow.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Would this be better to merged into staging?

Would this be better to merged into staging?

Not necessary, we usually target master directly when updating Arrow.


Request index not exist handling

Flint Streaming Query Translog
Requirements

EMR-S job should stop if query_execution_request is unavailable.
SOP to recover job is query_execution_request is unavailable.

Solutions
Short-Term solution Fast Fail

In Flint.createIndex, create query_execution_request index if not exist
Check query_execution_request, before write to **query_execution_request **index, if index not exist, throw IllegalStateException, emit metrics QueryExecutionRequestIndexNotFound.
When write

In translog state update, **query_execution_request **index, service not available / write block, throw IllegalStateException. Emit metrics QueryExecutionRequestIndexWriteFail
heartbeat update, **query_execution_request **index, service not available / write block, catch exception, Emit metrics QueryExecutionRequestIndexWriteFail. After 5 times, Monitor system detect the job lastUpdateTime is stale. if index is green, Monitor system retry EMR-S job. if index is RED / write block. Monitor system should cut ticket.

When read

In translog state init***, query_execution_request*** index, read block, throw IllegalStateException, Emit metrics QueryExecutionRequestIndexReadFail.
heartbeat update, **query_execution_request **index, service not available / write block, catch exception, Emit metrics QueryExecutionRequestIndexReadFail. After 5 times, Monitor system detect the job lastUpdateTime is stale. if index is green, Monitor system retry EMR-S job. if index is read block, Monitor system should cut ticket.

SOP
query_execution_request index not found
Scenario, query_execution_request is deleted by user / by oncall during cluster recovery.

Precondition: Streaming job failure handling logic make sure EMR-S job quit.

Metrics: QueryExecutionRequestIndexNotFound
Alarm: In past 5 mins, datapoints > 1
Severity: HIGH
SOP - Fix Index Not Found
1. restore index from sanpshot.
  if restore index fail, move to 2,
  if restore index success, move to 3.

2. create query_execution_request index.
createIndexIfNotExist(query_execution_request)

SOP - Recovery streaming job

Limitation

if data index lost, we can not recover job. user need to resubmit streaming query.
if EMR-S application lost, we can not recover job. user need to delete data index and create index again.

3. call DP, cat/indices start with flint_, filter auto_refresh=true
List[(indexName, docId, jobId, appId)] = Stream.of(cat/indices)
  .where(index.startWith(flint_))
  .where(auto_refresh = true)

4. check all the docIds is in query_execution_request
for tp in List[(indexName, docId, jobId, appId)]
  jobInfo = EMR-S.getJobInfo(jobId)
  if (!tp.docId in **query_execution_request**) {
    createDoc(query_execution_request, state='ACTIVE', datasource=jobInfo.datasource)
  }
  call EMR-S API, submit(RECOVER INDEX JOB `flint_myglue_stream_lineitem_tiny_skipping_index`)

query_execution_request index write block / read block
Scenario, query_execution_request is write block / read block in case Cluster under pressure.

Precondition: Streaming job failure handling logic make sure EMR-S job quit.

Metrics: QueryExecutionRequestIndexWriteFail / QueryExecutionRequestIndexReadFail
Alarm: In past 5 mins, datapoints > 1
Severity: HIGH
SOP

fix write block / read block issue.
SOP - Recovery streaming job

query_execution_request index red
Scenario, query_execution_request is RED.

Precondition: Streaming job failure handling logic make sure EMR-S job quit.

Metrics: QueryExecutionRequestIndexWriteFailed / QueryExecutionRequestIndexReadFail
Alarm: In past 5 mins, datapoints > 1
Severity: HIGH
SOP

Fix red index issue.
SOP - Recovery streaming job

Related to https://github.com/opensearch-project/opensearch-spark/issues/167


Where is the SS-Former module in the implementation V2?

Hello. I cannot find the cross attention module named SS-Former in the implementation V2. The Generic_Unet returns anchor condition and segmentation only. Can you show me the corresponding position of the SS-Former part?

same question

same question

same question

same question

您好，您的邮件我已收到，我会尽快回复的，谢谢！

same question

I also can't find the implementation of the SS-Former.

same question

Hello. I cannot find the cross attention module named SS-Former in the implementation V2. The Generic_Unet returns anchor condition and segmentation only. Can you show me the corresponding position of the SS-Former part?

have u solved this problem?

same question

您好，您的邮件我已收到，我会尽快回复的，谢谢！


Add AggregatedOpInterface to iree_linalg_ext.custom_op

This allows decomposing the op, i.e. inlining the region of the
custom_op into the parent region, and removal of the op.
Also add a TD op for testing.
Signed-off-by: MaheshRavishankar<EMAIL_ADDRESS>

Depends on #18676 . Review only the last commit for now.

I am not sure we want to split op definitions this way.

I think the idea behind it is that we could have several interfaces and we want to prevent the *Ops.cpp being a large file. My rule is:

The internal interface implementation can go with *Ops.cpp or *Interfaces.cpp.
The external interface implementation can go with *InterfaceImpl.cpp.

Ill stick with the current split, but I am not convinced it should be this way.

I'm seeing the file is moved to IR/, but I do not see the implementation is moved to the file. Is it intended? In either way, it's better to centralize the style at least for a interface implementation. We can revisit how we split the op definitions, but it looks better if you move the decomposition logics to AggregatedOpInterfaceImpl.cpp.

I am not sure we want to split op definitions this way.

I think the idea behind it is that we could have several interfaces and we want to prevent the *Ops.cpp being a large file. My rule is:

The internal interface implementation can go with *Ops.cpp or *Interfaces.cpp.
The external interface implementation can go with *InterfaceImpl.cpp.

Ill stick with the current split, but I am not convinced it should be this way.

I'm seeing the file is moved to IR/, but I do not see the implementation is moved to the file. Is it intended? In either way, it's better to centralize the style at least for a interface implementation. We can revisit how we split the op definitions, but it looks better if you move the decomposition logics to AggregatedOpInterfaceImpl.cpp.

I forgot to move the decomposition method. Moved it now.