Webworker cannot reas baseUrl

Hi
Got the following error when deploying to gh-pages. The project is set up with the craco-resium package, but the error should not coming from there. On localhost everything is working fine. Only the deployment not working

Thanks for the help

Hi @dabuchera, would you be able to check the network tab of the debugger? My guess is Workers/createVerticesFromQuantizedTerrainMesh.js is 404ing, leading to the error.
I'm not sure about the details of craco-resium, but CesiumJS has some static asset files, including web workers, that need to be served alongside the library in order to work as intended. window.CESIUM_BASE_URL needs to be set so that cesium can request these files.

Nope. createVerticesFromQuantizedTerrainMesh is okay
I think the error is coming from the cesiumWorkerBootstrapper

It also looks like that some js scripts in the web worker are missing in comparison to the localhost version

Thanks. I think this is specific to the deployment process here, and not a bug, as I can't reproduce on sandcastle.cesium.com or other applications.
It will be difficult to track down exactly what's going on without more details. Perhaps try the community forum with a description of the steps of your build and deployment. There should be developers there who are more familiar with craco-resium.


Work around invalid SIMD bswap

I have not yet been able to reproduce the issue #166.
This adds a workaround as a quick fix.
I think it would be good to see how this changes the result of PkgEval first.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.32%. Comparing base (1eec9cf) to head (9255195).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   93.67%   93.32%   -0.36%
==========================================
  Files          13       13
  Lines        1122     1123       +1
==========================================
- Hits         1051     1048       -3
- Misses         71       75       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUGish] When Pay is disabled, add notice explaining the reason

Description
The current "Pay is disabled" notice is too ambiguous and may lead to confusion. Providing an explanation for why the button is disabled would help users feel more confident using the app.

fixed


Support custom model names

Currently, there are two distinct OpenAI options in the providers list: "gpt-3.5 turbo" and "gpt-4 turbo". It would be more efficient to consolidate these into a single item, with the capability to switch between different models. Naturally, the ability to assign custom model names is necessary.
The same improvements should also be made for Claude, LLama, and Mistral.

Hi there,
Yes, duplicating the handler instantiation like that is probably not the cleanest of solutions, I will see what can be done without compromising simplicity too much while refactoring.
If you had any initial thoughts feel free to share them here!

If you had any initial thoughts feel free to share them here!

I see several alternatives

Common models list, with possibility to add there any model by any provider.
Additionally there could be "Filter by provider" , drop-down control.
2 separate lists in dropdown controls: Provider / Model, with possibility to add any custom model.
It would be good, if we could add custom providers as well.
By "custom provider" I mean any OpenAI-, or Google Gemini-compatible service, which can be defined with its URL (#6)


Submit custom syscalls to golang

I'm wondering if we can submit the missing syscalls (that we generate with mksyscall & friend) to upstream golang developers to be added to the syscall package, so they could be removed from this library.
After some research here's what I've found:

syscall is a frozen package, is kept alive just for the go v1 compatibility promise, here the notice coming from https://golang.org/pkg/syscall/:
NOTE: This package is locked down. Code outside the standard Go repository should be migrated to use the corresponding package in the golang.org/x/sys repository. That is also where updates required by new systems or versions should be applied. See https://golang.org/s/go1.4-syscall for more information.

The new golang.org/x/sys package looks promising but we should first migrate the library to use golang.org/x/sys instead of syscall.

@albenik (or anyone esle) do you have any experience/opinion on that?

I did a little research while working on some new features for go-serial and found these issues:

https://github.com/golang/go/issues/12853
https://github.com/golang/go/issues/13104

and I think there is no way now to add a new syscalls to golang core packages. Moreover as I understood, syscall / golang.org/x/sys is a packages only for most common syscalls used in golang core and related packages. For any other cases the code generation is a right way.
And about migration to golang.org/x/sys I think it is not urgent but necessary improvement.

github.com/cwchiu/go-winapi
I did not look closely at the package yet. Jut drop it here for history.
Pros
No need to write/generate own wrappers to windows api calls at least
Cons
External dependency

Have to migrate unix codebase to golang.org/x/sys https://github.com/bugst/go-serial/pull/29

Some steps forward are being made with the x/sys/windows package, see #187.
I'm closing this one since it makes no more sense to keep it open.


AndroidX libraries and<EMAIL_ADDRESS>support

AndroidX libraries support added
Fixed Android release build issues with old File Provider libraries
<EMAIL_ADDRESS>support and auto linking support added
Updated ReadMe file with usage for<EMAIL_ADDRESS>

Awesome!
We're facing flow errors Check for errors in the example app using Flow. Could you take a look please?
I would also ask you to update example

example

Sure, working on it now, forgot to update example

Awesome!
We're facing flow errors Check for errors in the example app using Flow. Could you take a look please?
Flow Errors (click to expand)
I would also ask you to update example

@jgcmarins Fixed, please check

AWESOME! :tada:  :tada:
Thanks for helping us @oleksandr-dziuban. I gave a quick look, and It LGTM.

AWESOME! 🎉 🎉
Thanks for helping us @oleksandr-dziuban. I gave a quick look, and It LGTM.
Im going to give a quick test at this PR as soon as possible, so we can Merge this. 😄

Thanks, waiting publishing version 2.0.0 👍

@MateusAndrade Hello, I have checked it with fresh project and even with production live project in debug and release mode. No errors, Android/iOS is assembling correctly

Regarding this comment, we should add instructions about jetifier on README, as well.

Jetifier is always enabled if user migrated to<EMAIL_ADDRESS>It is added as enable.jetifier=true property in gradle settings.

@oleksandr-dziuban I said:
and then people that are stuck on RN0.59 should be advised to use jetifier -r as a package.json postinstall.

Your comment does not address that.
There are two jetifiers. There is the Java-level gradle tool you reference. You are correct it is always on for RN0.60, and the react-native-community/cli authors even worked with me to add the second tool - the javascript-level node_modules jetifier - to the CLI so it is on by default as well.
But what do you do when you are stuck on RN0.59 and you want to use the latest react-native-share after your breaking change?
Consider that.
That is what jetifier -r is for. It reverses the mapping then the transition is easy (by making modern library versions compatible with android support libraries) for people that can't move quite yet.
That's what I meant in my comment

@oleksandr-dziuban I said:
and then people that are stuck on RN0.59 should be advised to use jetifier -r as a package.json postinstall.

Your comment does not address that.
There are two jetifiers. There is the Java-level gradle tool you reference. You are correct it is always on for RN0.60, and the react-native-community/cli authors even worked with me to add the second tool - the javascript-level node_modules jetifier - to the CLI so it is on by default as well.
But what do you do when you are stuck on RN0.59 and you want to use the latest react-native-share after your breaking change?
Consider that.
That is what jetifier -r is for. It reverses the mapping then the transition is easy (by making modern library versions compatible with android support libraries) for people that can't move quite yet.
That's what I meant in my comment

Ok, I see, thanks.
So what are the next steps? You don't want to merge this PR?

I have been clear on my preference - the PR is the right direction, assuming it's good (I've not tested it), merging an AndroidX transition PR is the right idea.
The next step is just to update documentation for people still on react-native 0.59, tell them they will need jetifier -r in their postinstall after this. This will be a common recommendation across lots of libraries

I have been clear on my preference - the PR is the right direction, assuming it's good (I've not tested it), merging an AndroidX transition PR is the right idea.
The next step is just to update documentation for people still on react-native 0.59, tell them they will need jetifier -r in their postinstall after this. This will be a common recommendation across lots of libraries

I can handle this update and the test. :smile:
But how someone using rn 0.59 would need to updated their project? The will need to enable jetifier? This is not clear to me.

If you read this you'll understand, and you can link to it, https://github.com/mikehardy/jetifier/blob/master/README.md#to-reverse-jetify--convert-node_modules-dependencies-to-support-libraries

Just tested on a project using the following:
{
    "react-native": "0.59.2",
    "react-native-animatable": "^1.3.2",
    "react-native-camera": "^1.10.0",
    "react-native-confirmation-code-input": "^1.0.4",
    "react-native-firebase": "5.2.1",
    "react-native-gesture-handler": "^1.0.15",
    "react-native-keyboard-aware-scroll-view": "^0.8.0",
    "react-native-linear-gradient": "^2.5.3",
    "react-native-masked-text": "^1.10.1",
    "react-native-orientation-locker": "^1.1.2",
    "react-native-picker-select": "^6.0.0",
    "react-native-share": "git+https://github.com/oleksandr-dziuban/react-native-share",
    "react-native-splash-screen": "^3.2.0",
    "react-native-tab-view": "^1.3.1",
    "react-native-vector-icons": "^6.2.0",
    "react-native-view-shot": "^2.6.0",
    "react-navigation": "^3.0.9"
}

And it works for dev mode using react-native run-android and for release without any problem. i just needed to run a npx jetify -r after running a yarn and it build for both modes like a charm.  I also tested the share functions using both dev/release build and it works perfectly. :tada: :tada: :tada:
Btw, thanks @mikehardy for saving our lifes with jetifier. :smile:

Its looks ok for me now. Do you think we can merge this @mikehardy?

Thanks for helping with that @oleksandr-dziuban!
@mikehardy  what do you think about pin a issue wih the possible problems related to this update?

@MateusAndrade maybe? :-) - in react-native-firebase we pinned one because the issue volume was crazy. I would leave it to you, if you notice you're spending a lot of time on AndroidX chatter, pin one. Can't really hurt. Nothing else super-hot in this project I think so it's not as if the pin area is too full?


ES6/UMD module

Would you consider writing the module as an ES6 module (with export statements) and transform it into an UMD module (for example with rollup) to allow it to be used in all common environments?

Great idea and I'm totally supportive of it, but I need some education on which tools to use and how to set them up (e.g. - webpack vs. rollup vs. browserify vs. parcel vs. babel).
Shooting from the hip, I'd probably pick webpack on the browser side since it seems to have browser support; or pick babel on the node.js side (which would go away when import becomes more stable in node.js).
Thoughts?

Ok, your post above and doing a bit more reading on rollup convinced me.
Any suggestions for how to do distribution? e.g. - create a build directory, store the build results in GitHub, and distribute them through RawGit?
Let me know if you'd enjoy doing a PR for this. :) If not, it will probably be a couple weeks before I get to it since I'm currently playing around with Dockerizing the server.

I'll see if I can create a PR. One thing that would change is that when used with a plain script tag in the browser the individual exports will be put inside a single object (e.g window.WebAuthSimpleApp.Msg rather than window.Msg). Though that probably is a good thing.
I think rawgit would work fine with when the dist files are committed. It would require the build results to be committed (npm would not need that). Unpkg is also an option though I think it only supports UMD modules.


Broker API response now returns "service_brokers" instead of "brokers"

Broker API response now returns "service_brokers" instead of "brokers"

Requires adoption in proxy-core
Requires adoption in CLI

Specification PR: https://github.com/Peripli/specification/pull/40

Service Broker Proxy core PR: https://github.com/Peripli/service-broker-proxy/pull/37

Service Manager CLI PR: https://github.com/Peripli/service-manager-cli/pull/35


added a beta settings page and added a theme selector tab

The sunset and earth themes don't look like they'll pass contrast requirements. We might also have that problem with the secondary colour of the classic theme. Have they all been run through Wave to check?

Moved back to draft as this will not need to be merged in until V2 is complete.

Now that v2 has been released we can come back to this work, although it will make sense to start from scratch as there are too many changes since this PR was raised.
Leaving open for now to use as a base for when we revisit this work.


How to Make Online Photo Editing Effects like Blur Image, Sepia, Vintage

Proposed title of article
How to Make Online Photo Editing Effects like Blur Image, Sepia, Vintage
Proposed article introduction
Graphic elements will become expressive as a result of photo editing effects. You may express an idea with a simple photograph and the right effects.
Image blur, transparency, and shadowing are some of the visual effects that can be used to produce appealing visual effects. There are numerous visual effects to choose from. There are hundreds of them to choose from.
To apply the effects on a target image, online photo editing software use a variety of approaches. A CSS filter property or an SVG filter primitive, for example, can be used to generate an image blur effect.
Key takeaways

User interface for applying blur sepia effects to photos online
Using a jQuery slider to control image editing effects
Blur the image with CSS and SVG.
How to create a sepia tone in an image
Using a variety of tones and vintage effects
Image Blur Sepia and Vintage effects from the editing tool

Article quality
This article is not similar to many blogs. I will use the latest version of CSS and HTML to make it more attractive
References
N/A

Just pinging you on this topic form - as I'm making some room in the topic queue.
No rush if you're still working on this one - if you need more time we can always re-open at a later date


KeyError: '_results' | Unable to find _results in checkpoint

I am getting error when running the code
root@7f4a0fe182ea:/workspace/refign# python tools/run.py test --config configs/cityscapes_acdc/refign_hrda_star.yaml --ckpt_path pretrained_models/refign_hrda_star_acdc.ckpt --trainer.gpus 1
Global seed set to 0
/opt/conda/lib/python3.8/site-packages/torch/utils/cpp_extension.py:3: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
import imp
Rishav is printing  /workspace/refign/models/correlation_ops
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
Restoring states from the checkpoint path at pretrained_models/refign_hrda_star_acdc.ckpt
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15]
Missing logger folder: lightning_logs/refign_hrda_daformer_cs_acdc
Traceback (most recent call last):
File "tools/run.py", line 4, in
ConditioningLightningCLI(pl.LightningModule,
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/utilities/cli.py", line 528, in init
self._run_subcommand(self.subcommand)
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/utilities/cli.py", line 783, in _run_subcommand
fn(**fn_kwargs)
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 911, in test
return self._call_and_handle_interrupt(self._test_impl, model, dataloaders, ckpt_path, verbose, datamodule)
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 685, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 954, in _test_impl
results = self._run(model, ckpt_path=self.tested_ckpt_path)
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1194, in _run
self.checkpoint_connector.restore_training_state()
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py", line 191, in restore_training_state
self.restore_loops()
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py", line 224, in restore_loops
self.trainer.test_loop.load_state_dict(state_dict["test_loop"])
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 252, in load_state_dict
self._load_from_state_dict(state_dict.copy(), prefix, metrics)
File "/opt/conda/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 281, in _load_from_state_dict
state_dict[prefix + k], metrics=metric_attributes, sync_fn=self.trainer.training_type_plugin.reduce
KeyError: '_results'

Thank you for pointing this out. I repaired the HRDA checkpoints, so the loading should work now.


Branch 1.6

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Can one of the admins verify this patch?

@ideaJOO could you close this PR? Thanks!

Sorry.

NP


Git: Workspace with a few submodules shows all submodules in "SOURCE CONTROL PROVIDERS"

Version: 1.36.0
Commit: 0f3794b38477eea13fb47fbe15a42798e6129338
Date: 2019-07-03T13:20:56.241Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 4.15.0-54-generic
Issue
I have repository with many submodules. When I like to work on a small subset of those submodules, I open them in a new window. But the "SOURCE CONTROL PROVIDERS" shows me all submodules, unnecessary bloating the information, which is not interesting.

Does this issue occur when all extensions are disabled?: Yes/No

You can disable this behaviour with the setting git.detectSubmodules.

@joaomoreno What you proposed, completely hides the detection of submodules, which is not what I intended. For example if Repository Super has 40 Submodules (such as Super/A, Super/B, and so on), and if we open vscode by $ code Super then it should detect all the submodules.
But If I want to work on only a few Submodule such as Super/D and Super/E, and I open New window with $ code Super/D Super/E then I was hoping that in the SOURCE CONTROL PROVIDERS, it could only show me git status of Super/D and  Super/E, and not of other submodules.

I actually can't repro that. I have created a sample repo with two submodules. When I open one of them as a folder in code, neither the top level repo nor the other submodule get open in Code. Can you reproduce in a smaller sample?


RTCDataChannelInit structure pointers

https://github.com/pions/webrtc/blob/af2033741de289e3a1c36938da972fb16af2e1e2/rtcdatachannelinit.go#L5
Why do you have using pointers there? It's not very useful and makes things more complicated like from
	id := uint16(1)
	neg := true
	max := uint16(1)
	peerConnection.CreateDataChannel("test", &webrtc.RTCDataChannelInit{ID: &id, Negotiated: &neg, MaxRetransmits: &max})

it could be simple
	peerConnection.CreateDataChannel("test", &webrtc.RTCDataChannelInit{ID: 1, Negotiated: true, MaxRetransmits: 1})

Hi @Bogdan-D, The JavaScript API defines some defaults for the Init object. E.g.: the Ordered field should be 'true' by default. The fields are pointers so we can know if the user specified the value or if it wasn't set. E.g.: in your second example Ordered would default to 'false' since it was not specified and will be initiated with it's default value 'false'.
After much deliberation we decided to use pointers to solve this problem. We aim for it to be easy to follow examples written in JavaScript while working with pions/webrtc. We think this provides the behavior that most closely matches the JavaScript API.
We've also provided helpers to convert the values to pointer values in the null package. E.g.:
ordered := false
pc.CreateDataChannel("data", &webrtc.RTCDataChannelInit{
	Ordered: null.NewBool(ordered),
})

We should probably do a better job at documenting this.
Please let us know what you think of the approach. It has taken quite some discussion to get to this result but we may have to reconsider if real-world usage shows that the solution is not suitable.

Most common way I saw in golang community is to use constructor with setting default values for a struct.
Other way is to use maps.
Well, in any case I understand the reason now

@backkem @Bogdan-D
I am going to close this (but feel free to re-open) I don't know if we made the right decision, but it hasn't come up since September so I don't think it is a blocking pain point.
If either of you disagree feel free to re-open and we can make a plan around what needs to change and when!
thanks


display time in hours and minutes

Describe the bug
display all the time labels in hours and minutes
Checklist

[ ] I have recreated the issue in the vanilla starter kit (this is a template repo, some issues may be related to code or configuration that has been added outside the starter kit).
[ ] I am using a supported version of Node (at least 20.9) and npm (not Yarn).
[ ] I have installed the correct dependencies (run npm ci if you're unsure, this will clear node_modules/ and install based on the package-lock.json).

To reproduce
Steps to reproduce the behavior.
Expected behavior
A clear and concise description of what you expected to happen.
Actual behavior
What happened instead (e.g. errors, unexpected outputs).
Setup
Please complete the following information):

OS [e.g. macOS 10.15.3]:
Node [e.g. 20.16.0]:
Browser [if relevant, e.g. Firefox 72.0.2]:

Additional context
Add any other context about the problem.

Please think about how to do this.  It should not be a complex call at each point of use.  Think about how to centralise this


docs:JK-9965: Added new create service account and reset credentials …

…commands, as per https://issues.redhat.com/browse/MGDSTRM-9965.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation change
[ ] Other (please specify)

Hi @rkpattnaik780. This is my first time submitting a PR in this repo and the Validate/ Validate Conventional Commits (pull_request) keeps failing but I don't know why. Could you help me to make the necessary change to the commit so that all checks will be successful? Thanks.

Hi @rkpattnaik780. This is my first time submitting a PR in this repo and the Validate/ Validate Conventional Commits (pull_request) keeps failing but I don't know why. Could you help me to make the necessary change to the commit so that all checks will be successful? Thanks.

Thanks a lot for the PR @AedinC . Checking the commit log, I can see that the latest commit looks good, it just needs a space between : and the subject, i.e docs(update): added new service account create and reset credentials c…. The commit lint also checks the older commit messages along with the latest one. The most straightforward way I follow for this situation is:

Un-commit the last three commits (this will leave changes intact):

git reset HEAD~3

Stage the changed files

git add .

Commit the changes:

git commit -m "docs(update): added new service account create and reset credentials c…"

Force push the commit:

git push -f <remote> <branch>

Hopefully, this should make the checks pass.

Note: This might not be the best workaround. Also, we can set the commit while merging the PR using GitHub website, so we can ignore the commit lint checks failing, that serves more like a warning so we can give proper commit messages to main.

but it seems to have failed again.

Hey @AedinC . Our checks occasionally fail due to timeout while fetching a linter. It passed after a a re-run of the builds :). This looks good. I am approving and merging now. Thank you!

Great - thanks for all your help @rkpattnaik780!


Correcting typo in the pipelines function call

Updating the call to pipelines for automatic creation of the winlogbeat and syslog pipelines at install time.


roll & yaw seems swapped

no matter which way I hold the device it seems like it is rolling when I turn and turning when I roll.  toggling "roll off" does not stop it from rolling.

Is this a Samsung phone? Currently it expects the screen facing up and top of the screen pointing forward

And the browser in your AR glasses, not phone screen

ok, so I guess I never tried face up.  that seems to work as intended.


Add travis-based integration tests

@josschne Creating this PR to track work on enabling integration testing in travis

Ping @gsfr / @rentzso . I think we're ready to go with this. Please take a look.
Note that coverage through paster for the integration tests is a bit tricky. If we want to get those numbers we probably will need to refactor the integration tests to call the WSGI handler directly, see an example here: http://stackoverflow.com/questions/6222528/unittesting-the-webapp-requesthandler-in-gae-python

Thanks, @josschne.
Would using uWSGI help with the coverage issue?
Tentatively LGTM, pending clarifications or minor updates on various line comments.
@andynemzek: Would appreciate a quick review of the diff on the two .sh files.

Don't think using uWSGI would help with the coverage issue. In either case we need to enable coverage within the python environment, which can be done but is non-trivial. I'd like to focus on getting unit test coverage up and use the integration tests for their functional value, rather than any coverage.

@gsfr didn't see anything pop out at me, but run.sh has grown quite a bit since I last worked on it.

I'm going to stop reviewing here, as it started to become clear that much of the script's non-portability pre-dates this PR. I played with it a bit, but... for now I'll just accept that I can't run the tests this way, and maybe we worry about that (and CI on linux) after this lands.

@gsfr @josschne What are the remaining blockers on getting this merged? No activity in awhile... I see one unanswered question (the first thread from the top).

Thanks for the ping, @kofalt. Joe and I are on it. No action needed at the moment.

So... this got more complicated at the end than I was expecting.
We initially planned to use paster running locally, on an OSX box up on the Travis cloud. We evolved that idea to instead use our Docker container in order to improve maintainability. I subsequently discovered virtualbox (and thus docker-machine) cannot be run on the Travis OSX infra. So I went back to the Linux Trusty image where I'm able to run docker-compose without issue.
Would appreciate @rentzso and @gsfr's feedback on the following:

The integration tests now use py.test fixtures and have been heavily refactored.
I had to make a change to bootstrap.py to allow non-https api paths since that is the default in our Dockerfile
I found a bug in the download handler using the tests that I fixed. Hooray!

Would appreciate @ryansanford's check on the Dockerfile change I needed to make. uWSGI is configured to close each connection after sending the response by default. This causes an issue with the requests.Session connection pooling, which on localhost is fast enough to get the next request out after uWSGI closes the connection on its side, but before requests processes the closed connection. This results in a BadStatusLine exception popping out from the bowels of the Python standard library. Adding the various keepalive options to the Dockerfile uwsgi commandline fixes this issue.
And I'd like @kofalt's once-over just cause he's awesome (and he's going to look it over regardless).

@gsfr @josschne
Looks like we could extend docker-compose.yml to include nginx to support https out of the box for this runtests entrypoint. Thoughts?

And I'd like @kofalt's once-over just cause he's awesome

:sunglasses:
This looks pretty great. At the architecture level, I question if we really need to boot virtualbox... I would have assumed we could use Travis' docker infra and just ran our containers on it. I'm assuming you've either already been down that road or decided it wasn't worth it. Either way, this approach is A-OK since it gets us that delicious green checkmark on PRs.
The test layout is a tad hairy but makes sense; I like the fixtures. Great work!
My read on the uwsgi config is that it probably won't affect us since we're using UWSGI in fast-cgi mode in prod, so I presume keepalive settings don't apply. Could be wrong!

@ryansanford @kofalt: Thanks for the review!
We only need to boot virtualbox on OSX (via docker-machine). The Travis CI tests are now running on Linux and assume docker is ready (Travis CI's OSX infra actually can't run virtualbox - which is where I got stuck).
Not sure on the uwsgi comments. @ryansanford thoughts? What's the best way to get the keepalive options into the mix without breaking prod?
@ryansanford I don't think http nor nginx are necessary here. I'm not sure I understood the motivation behind your comment.

Thanks, @josschne. Nice work!
I would like to still understand @ryansanford's comments before merging.
Also, we may want to bring this in line with the conflicting #185 before merging.

Ping @ryansanford. Can you provide more detail on your nginx comment?
@gsfr - Looks like integration with #185 could be a large change to this PR. Would it make sense to separate that from this PR?

Thanks, @josschne. After team discussion, we decided to go ahead with merging #185, which just happened. @ryansanford has committed to update this PR to fall inline with #185 as well as his latest infra.

@gsfr - Alright. I'll consider my part on this PR complete.

:+1:  :smile:

Coverage remained the same at 8.008% when pulling<PHONE_NUMBER>a974594f6a20e4f8455d7e7296c43a on integration-testing into fe7737d7b34c73d4199528e9cc635f91eb5ecd93 on master.

Coverage remained the same at 8.008% when pulling 65e1553f3e5f80693d51ff1324b25338fe15422f on integration-testing into fe7737d7b34c73d4199528e9cc635f91eb5ecd93 on master.

@gsfr Conflicts should be resolved, and travis build completes without error. Any final words before merging?

Thanks, @ryansanford. Let's have @rentzso and @nagem take a final look.

LGTM

LGTM


Trouble compiling @stacks/common in typescript

Describe the bug
'NodeJSBuffer' not being recognised as a type when compiling the package in TS
Error: 'NodeJSBuffer' refers to a value, but is being used as a type here. Did you mean 'typeof NodeJSBuffer'
What version of Stacks.js are you using?
@stacks/common version 4.3.5
Is the bug present in the Stacks.js CLI, Gaia hub, Connect or Blockstack Browser?
Bug is in Stacks.js common package
To Reproduce
Steps to reproduce the behavior:

npm install @stacks/common
tsc --build
See error

Expected behavior
The build should complete.
Screenshots

Desktop (please complete the following information):

tsc -v = 4.8.3
node -v = v16.13.2
Version [e.g. 22]

Additional context
I believe this might be arising from a poly filling fix.

Thx for the report 🙏 The NodeJSBuffer is now removed.


How to constrain one heirachy of bodies to a seperate body?

Is it possible in MuJoCo to constrain one heirachy of bodies to a seperate body?
For example, a humaoid ragdoll attached to a separate static body?

Not clear what you are asking. Constrain how?
Are you just asking if MuJoCo has tendons? The answer to question is yes.

My understanding of MuJoco is that joints are created between two bodies, a parent and its child. Is it possible to create a joint between two bodies which do not share a parent/child relationship?
In the screenshot example this would be between the hand of the ragdoll and a separate body, one not part of the ragdoll heirachy.

MuJoCo has both spatial tendons and equality constraints. One or both of those might be what you are looking for. Please read the related documentation.


test: integration tests for account declaration

Added tests that check Beerus functions used for account declaration

Created new account_declare.rs file in tests folder
Restructured common module in tests
Added mock server in common module that acts like a starknet node with possibility to modify it's responses

Sorry for the delay, I need a bit more time to understand what is happening in the tests and what exact cases they protect us from.
At this point it seems like a complicated way to verify request-response JSON roundtrip :)

Inside the account_declare.rs is a starkli_declare_workflow_test. If a user would call starkli declare <contract.json> file, these functions would be called on a starknet node. Instead of a live starknet node, I have created a mock node where we can control what kind of response can come.
Additional test cases are for further verification.
For next step, I was thinking of same starkli_declare_workflow_test, but instead of on mock starknet node, we would be starting katana and would query same requests on development node in this test environment. This would be done in scope of this issue:
https://github.com/eigerco/beerus/issues/732


[no-issue] ParsingFailed, Notification

Pull Request Test Coverage Report for Build 334

29 of 68 (42.65%)  changed or added relevant lines in 11 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.1%) to 35.62%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

worker/src/main/scala/com/github/jaitl/crawler/worker/executor/resource/ResourceHelper.scala
1
2
50.0%

worker/src/main/scala/com/github/jaitl/crawler/worker/pipeline/PipelineBuilder.scala
3
4
75.0%

worker/src/main/scala/com/github/jaitl/crawler/worker/executor/SaveCrawlResultController.scala
5
7
71.43%

worker/src/main/scala/com/github/jaitl/crawler/worker/pipeline/ConfigurablePipelineBuilder.scala
6
9
66.67%

worker/src/main/scala/com/github/jaitl/crawler/worker/WarmUpManager.scala
0
4
0.0%

worker/src/main/scala/com/github/jaitl/crawler/worker/email/NotificationExecutor.scala
0
5
0.0%

worker/src/main/scala/com/github/jaitl/crawler/worker/executor/TasksBatchController.scala
3
11
27.27%

master/src/main/scala/com/github/jaitl/crawler/master/queue/QueueTaskResultController.scala
5
20
25.0%

Files with Coverage Reduction
New Missed Lines
%

master/src/main/scala/com/github/jaitl/crawler/master/queue/QueueTaskResultController.scala
1
52.54%

worker/src/main/scala/com/github/jaitl/crawler/worker/WarmUpManager.scala
1
0.0%

master/src/main/scala/com/github/jaitl/crawler/master/queue/QueueTaskBalancer.scala
2
66.67%

Totals

Change from base Build 332:
0.1%

Covered Lines:
296

Relevant Lines:
831

💛  - Coveralls


Gating tying modules w/ FSDP for torch 2.0

What does this PR do?
Gates which modules we check for tied weights, if the module is already FSDP wrapped we shouldn't be checking for it.
I've done manual testing, testing with launching a run right now
What issue(s) does this change relate to?
https://mosaicml.atlassian.net/browse/GRT-2356
Before submitting

[ ] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[ ] Did you update any related docs and document your change?
[ ] Did you update any related tests and add any new tests related to your change? (see testing)
[ ] Did you run the tests locally to make sure they pass?
[ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Trying to run a test right now w/ the .yaml it broke before with use_orig_params=True to verify this should work

No, that seems good to me.


Leaderboard UI signout breaks ANE

When you sign out from the leaderbord UI (top right > settings > sign out user) the application does not receive the sign out event and still assumes your signed in.

I have the same problem signing out through the Google Play Game Services achievements UI.


First commit

Project To Do List for review

Hello @joramot !
You have done an excellent job and have followed the DRY, KISS and YAGNI methodologies as well as HTML and CSS best practices.
However, I have a couple of suggestions and observations that could be used to take your code to the next level.

There seems to be some files or functions missing in the project, please make sure to include them so that the project can work properly.

Please make sure to modularize the javascript code for better readability and separation of responsibilities.

Thanks Sergio, I made a mistake when uploading the project, I will make the changes to correct the mistake. Thank you.


Chinese source (18漫畫)

Source name
18漫畫(18mh)
Source link
https://18mh.org
Source language
Chinese
Other details
godamh NSFW version
Acknowledgements

[X] I have checked that the extension does not already exist by searching the extension listing and verified it does not appear there.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[X] I will fill out all of the requested information in this form.

@stevenyomi This uses the same template as GoDa, so it should be fine to just copy and paste 👀


Add dynamic multivariate vcl templating

https://trello.com/c/gsUWTMyL/34-set-up-infrastructure-for-multi-variant-tests-multi-variant
Adds the ability to define multivariate test configurations with allocations based on percentages or arbitrary nominators, the denominator is the sum of nominators.
Requires that variants are specified in alphagov/fastly-configure.
The allocations are stored in Fastly dictionaries so they can be adjusted without a redeployment of the Fastly VCL configuration, this means we can still switch off tests by allocating 100% users to the first variant.
I ran a test of this branch on staging deploying the test dictionaries and CDN then took a 1000 request sample of header allocations:
for i in `seq 1 1000`;
do
  curl -Ik https://www.staging.publishing.service.gov.uk/ | grep Multivariate | awk '/=*.?;/ {print $2}' | cat >> mv.txt
  sleep 1
done

$ grep firstVariant mv.txt | wc -l
502
$ grep secondVariant mv.txt | wc -l
250
$ grep thirdVariant mv.txt | wc -l
248

cc @tijmenb @fofr @suzannehamilton

This is awesome. 💃
By moving the bucket config into this repo, does it mean that we'll have to do a full Fastly deploy to change the percentage of users in each bucket? It would be good to avoid this if possible - it's less risky to just deploy the dictionaries.
@tijmenb suggested keeping the bucket config in the dictionaries repo and just specifying the overall percentage of users who are in a test bucket. It would give you less flexibility because you would have to split the users evenly between B/C/D/etc., but it might be worth it to keep the deployment simple?

👍 Looking great.
To add to @suzannehamilton's comments, when Carlos first did the multivariate work they made it so that they could use descriptive names instead of "A" and "B", so the code in the app reads like variant?('ShowBlueBox') instead of variant?("C"). Could we support that?
https://github.com/alphagov/collections/blob/eed9aa5db0939eb30179d13d6b0a3199c8600b5d/app/models/blue_box_ab_test_request.rb#L24-L26
Also, would it be worth it to use rspec for consistency with other apps?

@suzannehamilton Thanks for reviewing, you're right it's a nasty limitation. It might be possible to achieve this using a dictionary per MV test. I'll give this a try.

@suzannehamilton @tijmenb I've added a WIP commit exploring the possibility of using a dictionary per MV test. The dictionaries would contain variant-name : nominator pairs (eg. someVariant : 50), which addresses naming variants rather than assigning a letter. We'd still need to deploy Fastly config to pick up new tests but at least the variant allocation lookups would be dynamic.
This method declares and sets the nominator/denominator vars per test and variant in the vcl code, there's still a reliance on the template-level config knowing how many variants there are so this would look more like:
- MyTest:
  - variant1
  - variant2

The other drawback to this approach is the lack of ability to test the logic now pushed into the vcl, is there a safe way of validating and running this output?
I've not attempted to do anything complex with maths in the vcl code as I don't have much confidence in how it will work, so splitting the test variants equally hasn't been addressed here, I can't think of a way to achieve that with the limited functions and options of vcl.

@suzannehamilton @brenetic  would you mind taking another look at this PR. I've deployed this branch a couple of times and run tests on staging the PR description above has updated info.


Using c3 with polymer ?

I want to display charts in a polymer (https://www.polymer-project.org/) framework.
I managed to display a line chart but there are pbs :

It looks like the fill property of svg objects is active because I have a black area enclosed by the line chart. Maybe I fail to load correctly the css file ?

More critically, any update of the chart (tooltip, etc.), generate some transient elements at root level (all elements generated by the chart should remain in the shadow root of the element containing the chart). These transient elements disturb the overall framework design by generating strange resizes of other elements.

Has anyone tried to combine c3 and polymer ?
Is there a good (and simple) way to do it ?
If not, is it planned as an enhancement of c3 ?

I'm using Polymer a boatload at the moment and never thought to try creating a c3-chart element. I might give it a go this afternoon and share my experiences.

Okay, so I've made aendrew/c3-chart for this purpose. Didn't have any problems, though I'm having a bit of an issue ensuring C3 and D3 have loaded before firing domReady.
Demo: http://aendrew.com/c3-chart/components/c3-chart/demo.html
I haven't noticed any elements in the root and it seems to work as intended. Issue you're having with axes above is due to the CSS not loading properly before.
Seems to work as intended, so closing. If you're still having problems after looking at my example code, do let me know and I'll reopen. Thanks! :smile:

Its all good if you are generating a line chart, but for different chart types (bar, pie) they always render as a line chart.. This is puzzling and I have no idea why using Polymer would break that functionality??

@aendrew Were you able to get different chart types working using your code above?  Here is the code I am using:
`Polymer({
is: 'chart-bar',
properties: {
chartId: String
},
ready: onReady
});
function onReady() {
drawChart.call(this);
}
function drawChart() {
var id = '#' + this.chartId;
var chart = c3.generate({
bindto: this.$$(id),
data: {
columns: [
['data1', 30, 200, 100, 400, 150, 250],
['data2', 50, 20, 10, 40, 15, 25]
],
type: 'bar'
},
size: {
width: 800,
height: 300
}
});
}`

Update:
Got this to work with different chart types, apparently Polymer does not like it when you use .call() in the ready function.  This code works for different chart types:
Polymer({
  is: 'chart-bar',
  properties: {
    chartId: String
  },
  ready: onReady,
  drawChart: drawChart
});

function onReady() {
  this.drawChart();
}

function drawChart() {
  var id = '#' + this.chartId;

  var chart = c3.generate({
    bindto: this.$$(id),
    data: {
      columns: [
        ['data1', 30, 200, 100, 400, 150, 250],
        ['data2', 50, 20, 10, 40, 15, 25]
      ],
      type: 'bar'
    },
    size: {
      width: 800,
      height: 300
    }
  });
}


Bug: Presence hold timeout not long enough

Describe the bug
The presence hold timeout feature is useful in case someone forgets to turn off Presence Hold once they no longer need it. However, the highest number that the configuration screen will let me enter is 9999 which is only 2.778 hrs. I was trying to enter 28800 which I believe is 8 hours, but the input turns red and prevents me from continuing after I enter a 5th digit.
To Reproduce
Steps to reproduce the behavior:

Configure an area with a presence hold switch
Try and enter a presence hold timeout larger than 9999 seconds

Expected behavior
It should allow for much larger numbers, or perhaps it should use minutes instead of seconds.
Additional context
It seems to me people might want to have a long Presence Hold period, but still use the timeout feature. My desire currently is for 8 hours, but I could easily see someone wanting a presence hold timeout of 24 hours, or maybe even longer.

In re-evaluating this request, perhaps it should be classified as an enhancement vs a bug, because I'm not sure what the original intention was as far as the upper bounds of the timeout.

This is probably something that would be fixed by changing the timeouts from seconds to minutes, which would make more sense in that directive.
The bad thing is that is not backwards compatible so people would have to update, which is not a dealbreaker but it makes it so it has to go in a major release.
I'm up for this and it's being tracked here https://github.com/jseidl/hass-magic_areas/discussions/254, make sure you upvote!

Oh totally, changing from seconds to minutes would be great! I upvoted that issue, looking forward to that hopefully making it in!
Could async_migrate_entry be used when updating to the newer version to migrate existing seconds values to minutes automatically?

Could async_migrate_entry be used when updating to the newer version to migrate existing seconds values to minutes automatically?

Possibly! Although I never messed with it, have to take a look at it

This is being tracked on https://github.com/jseidl/hass-magic_areas/discussions/254, please upvote. I am strongly inclined to doing this one but it's a breaking change so I'm waiting until I get the new naming convention out (still 1 or 2 releases out) so I make all the breaking changes at once.


Installing remote server via scp doesn't work anymore

VSCode Version: 1.62.0
Local OS Version: Windows 10 Enterprise 20H2
Remote OS Version: Kubuntu 20.04 / CentOS 7
Remote Extension/Connection Type: SSH
Logs:

[10:44:16.026] Log Level: 2
[10:44:16.027]<EMAIL_ADDRESS>[10:44:16.027] win32 x64
[10:44:16.038] SSH Resolver called for "ssh-remote+ubuntu-vm", attempt 1
[10:44:16.038] "remote.SSH.useLocalServer": false
[10:44:16.038] "remote.SSH.showLoginTerminal": false
[10:44:16.038] "remote.SSH.remotePlatform": {"XXX":"linux","XXX":"linux","XXX":"linux","ubuntu-vm":"linux","XXX":"linux","XXX":"linux","XXX":"linux"}
[10:44:16.038] "remote.SSH.path": C:\Users\XXX\bin\ssh.exe
[10:44:16.038] "remote.SSH.configFile": undefined
[10:44:16.039] "remote.SSH.useFlock": true
[10:44:16.039] "remote.SSH.lockfilesInTmp": false
[10:44:16.039] "remote.SSH.localServerDownload": always
[10:44:16.039] "remote.SSH.remoteServerListenOnSocket": false
[10:44:16.039] "remote.SSH.showLoginTerminal": false
[10:44:16.039] "remote.SSH.defaultExtensions": []
[10:44:16.039] "remote.SSH.loglevel": 2
[10:44:16.039] SSH Resolver called for host: ubuntu-vm
[10:44:16.040] Setting up SSH remote "ubuntu-vm"
[10:44:16.044] Using commit id "b3318bc0524af3d74034b8bb8a64df0ccf35549a" and quality "stable" for server
[10:44:16.047] Install and start server if needed
[10:44:16.050] Checking ssh with "C:\Users\XXX\bin\ssh.exe -V"
[10:44:16.123] > OpenSSH_for_Windows_8.1p1, LibreSSL 2.9.2

[10:44:16.129] Running script with connection command: "C:\Users\XXX\bin\ssh.exe" -T -D 56333 "ubuntu-vm" bash
[10:44:16.131] Terminal shell path: C:\WINDOWS\System32\cmd.exe
[10:44:17.517] > ]0;C:\WINDOWS\System32\cmd.exe
[10:44:17.517] Got some output, clearing connection timeout
[10:44:18.424] > agent key RSA SHA256:XXX returned incorr
> ect signature type
[10:44:18.788] > agent key RSA SHA256:XXX returned incorrect signature typ
> e
>
>
>
>
>
>
>
>
>
>
>
>
>
>
[10:44:19.556] > ca08f70aa8fa: running
[10:44:19.605] > Acquiring lock on /home/XXX/.vscode-server/bin/b3318bc0524af3d74034b8bb8a64df0ccf35549a/vscod
> e-remote-lock.XXX.b3318bc0524af3d74034b8bb8a64df0ccf35549a
[10:44:19.612] > Found old VS Code install 83bd43bc519d15e50c4272c6cf5c1479df196a4d, attempting to clean up
[10:44:19.621] > Deleting old install from /home/XXX/.vscode-server/bin/83bd43bc519d15e50c4272c6cf5c1479df196a
> 4d
[10:44:19.721] > Deleting old log file from /home/XXX/.vscode-server/.83bd43bc519d15e50c4272c6cf5c1479df196a4d
> .log
[10:44:19.727] > Installing to /home/XXX/.vscode-server/bin/b3318bc0524af3d74034b8bb8a64df0ccf35549a...
> Trigger local server download
> ca08f70aa8fa:trigger_server_download
> platform==linux==
> vscodeArch==x64==
> destFolder==/home/XXX/.vscode-server/bin/==
> destFolder2==b3318bc0524af3d74034b8bb8a64df0ccf35549a==
> ca08f70aa8fa:trigger_server_download_end
> Waiting for client to transfer server archive...
> Waiting for /home/XXX/.vscode-server/bin/b3318bc0524af3d74034b8bb8a64df0ccf35549a/vscode-scp-
> done.flag and vscode-server.tar.gz to exist
>
[10:44:19.727] Got request to download on client for {"platform":"linux","arch":"x64","destFolder":"/home/XXX/.vscode-server/bin/b3318bc0524af3d74034b8bb8a64df0ccf35549a"}
[10:44:19.727] Downloading VS Code server locally...
[10:44:21.735] Resolver error: Error: XHR failed
    at XMLHttpRequest.C.onerror (vscode-file://vscode-app/c:/Users/XXX/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:85:24735)
[10:44:21.738] ------

Steps to Reproduce:

Open SSH Connection to remote server (tested Ubuntu 20.04 and CentOS 7 - both worked before)

Does this issue occur when you try this locally?: Yes/No
Does this issue occur when you try this locally and all extensions are disabled?: Yes/No

@alexdima do you have an idea what could cause this error in the resolver?
Resolver error: Error: XHR failed
    at XMLHttpRequest.C.onerror (vscode-file://vscode-app/c:/Users/XXX/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:85:24735)

@tanhakabir It looks to me that the SSH resolver decides to download the vscode server locally and then fails to download it. I don't know why the download would fail, maybe the internet got briefly disconnected while downloading 🤷 . But this is not a core remote problem, it is the SSH resolver extension that downloads the vscode server. Maybe it should retry a few times before giving up?

@alexdima All of my servers do not have internet access. I did set "remote.SSH.localServerDownload": always to enforce scp download.

@ponchofiesta yes, the log shows this:
[10:44:19.727] Downloading VS Code server locally...
[10:44:21.735] Resolver error: Error: XHR failed
    at XMLHttpRequest.C.onerror (vscode-file://vscode-app/c:/Users/XXX/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:85:24735)
[10:44:21.738] ------

But 2 seconds later there is an XHR failed error, which I presume means that the download failed. I am sorry, but I don't know what might be causing the download to fail. cc @roblourens @tanhakabir perhaps to log more info or retry downloading in case of failure.


About HTC training

Does stuffthingmaps only have coco_stuff semantic map?  When I add semantic branch, there is an assertionError.
Traceback (most recent call last):
File "./tools/train.py", line 90, in
main()
File "./tools/train.py", line 86, in main
logger=logger)
File "/home/amax/mmdetection/mmdet/apis/train.py", line 58, in train_detector
_dist_train(model, dataset, cfg, validate=validate)
File "/home/amax/mmdetection/mmdet/apis/train.py", line 99, in _dist_train
runner.run(data_loaders, cfg.workflow, cfg.total_epochs)
File "/home/amax/anaconda3/envs/mmdetection/lib/python3.7/site-packages/mmcv/runner/runner.py", line 356, in run
epoch_runner(data_loaders[i], **kwargs)
File "/home/amax/anaconda3/envs/mmdetection/lib/python3.7/site-packages/mmcv/runner/runner.py", line 258, in train
for i, data_batch in enumerate(data_loader):
File "/home/amax/anaconda3/envs/mmdetection/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 637, in next
return self._process_next_batch(batch)
File "/home/amax/anaconda3/envs/mmdetection/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 658, in _process_next_batch
raise batch.exc_type(batch.exc_msg)
AssertionError: Traceback (most recent call last):
File "/home/amax/anaconda3/envs/mmdetection/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 138, in _worker_loop
samples = collate_fn([dataset[i] for i in batch_indices])
File "/home/amax/anaconda3/envs/mmdetection/lib/python3.7/site-packages/mmcv/parallel/collate.py", line 63, in collate
for key in batch[0]
File "/home/amax/anaconda3/envs/mmdetection/lib/python3.7/site-packages/mmcv/parallel/collate.py", line 63, in
for key in batch[0]
File "/home/amax/anaconda3/envs/mmdetection/lib/python3.7/site-packages/mmcv/parallel/collate.py", line 38, in collate
assert batch[i].dim() == 3
If there is a mistake in my root (data/coco/stuffthingsmaps/...)?

Yes it is COCO-stuff annotation maps. You may downloaded the wrong dataset?

I also meet this problem

I also meet this problem
I download the dataset from this url, and it's ok now.
https://github.com/nightrome/cocostuff/blob/master/README.md#downloads
@xlzhang1992

Thanks


Solved Issue#16

Description of Change
Added sponsor logos and hyperlinks
Evidence Of Change
Screen shots of the change working

Linked Issue
#16

Please change your issue labels to hacktoberfest.
Refer : https://github.com/digitalocean/hacktoberfest/pull/596

Please change your issue labels to hacktoberfest.
Refer : digitalocean/hacktoberfest#596

This refers to the repository topics and not the labels. This was updated a few days ago


Update List.split to List.splitAt

Many thanks! I'll merge this and make a new release.

Release 0.3.0 is published!


Curly quotes tool in v4 docs is overzealous

Stuff like this (http://v4-alpha.getbootstrap.com/components/modal/#modalshow ) should use plain apostrophes.
Ditto in tables of contents: http://v4-alpha.getbootstrap.com/components/tooltips/#contents
CC: @mdo

The only workaround I can think of is using plain html for the headers. I'm not aware of a kramdown  switch or something.

There's the smart_quotes option: http://kramdown.gettalong.org/options.html#option-smart-quotes

I haven't used it myself so I'm not sure if it'll have any impact in other part of the docs. But we can give it a go.

I had a quick look but I that config option seems to have a universal effect. Maybe I'm missing something, though.

If killing it everywhere is the only option, that's fine by me. Dunno how @mdo feels about it though.

Oh, OK, I thought that wasn't even an option :P

I'd rather we use <code> there to highlight those are commands. Otherwise, we should rewrite those headings to be regular text like the rest of the page.

Whatever you prefer. I could give it a go if we all agree on something.

Addressed by #17725.


Documents - delete sub collection items

When a top level collection document is deleted the subcollection documents should be deleted at the same time.  With the implementation we should use the available batch delete facilities provided by the database services to ensure this operation is efficient.

Completed


Migrate to per tenant DB fields cyphering

Current modifications:

Store the Cypher key from config.json in new collection default.keys in DB

Questions:

is the correct place to do this in MongoDBStorage.ts? If not where/when?
Is the type CryptoKey.ts needed? Currently I have not used it because I was unsure if to use it or use type CryptoConfigurations.ts so I made it with string.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

As I wrote via email, we'll store keys in settings and we have already a storage for that.
We must have a meeting to discuss this.

As I wrote via email, we'll store keys in settings and we have already a storage for that.
We must have a meeting to discuss this.

We already have started to discuss via teams, mail:

At first, where the key is stored is not important, the goal at the beginning is to have generic code to handle key change migration on senstivive information. And doing global key change and migration need a temporary permanent storage to store the current key and detect key change and make the decipherng with the old and ciphering with the new. A collection in the DB in the default tenant is the best place. To make Serge happy, Stefania put the keys in one tenant settings and test the migration only for a per tenant key usage.
I've asked Stephania, Kartal and Alfons weeks ago by mail to open draft PRs for their ongoing work to ease implementation to follow the coding standards in the project by doing incremental review until I think the PR is ready for your review and merge.

That's what I've been requested to do regarding their works: doing the technical framing. So please do not close PRs that will permit me to do it ;)

This has to be fully aligned with Settings like in Settings.ts as it'll be stored here in the end

This has to be fully aligned with Settings like in Settings.ts as it'll be stored here in the end

My comment on src/storage/mongodb/CryptoKeyStorage.ts file saying basically that file have disappeared???
@stefania-santimbrean Have you received it by mail at least?

This has to be fully aligned with Settings like in Settings.ts as it'll be stored here in the end

My comment on src/storage/mongodb/CryptoKeyStorage.ts file saying basically that file have disappeared???
@stefania-santimbrean Have you received it by mail at least?

Yes, received by email and I also see your comment in GitHub. I will adapt to your feedback. Thanks!

This has to be fully aligned with Settings like in Settings.ts as it'll be stored here in the end

My comment on src/storage/mongodb/CryptoKeyStorage.ts file saying basically that file have disappeared???
@stefania-santimbrean Have you received it by mail at least?

Yes, received by email and I also see your comment in GitHub. I will adapt to your feedback. Thanks!

Ok.
We will have a meeting to discuss that task, but:

the migration shall survive a server reboot/restart. That means that the state of the migration shall be tracked for each sensitive information or that you can test if each sensitive information fields have been migrated or not reliably.
You can generate randomly the key in the target test tenant settings to test the migration.

Questions:

is the correct place to do this in MongoDBStorage.ts? If not where/when?

No but you've already created a dedicated file to handle the collection for sensitive data migration. You've answered the question yourself ;)

Is the type CryptoKey.ts needed? Currently I have not used it because I was unsure if to use it or use type CryptoConfigurations.ts so I made it with string.

You've also found the solution by yourself ;)

Questions:

is the correct place to do this in MongoDBStorage.ts? If not where/when?

No but you've already created a dedicated file to handle the collection for sensitive data migration. You've answered the question yourself ;)

Is the type CryptoKey.ts needed? Currently I have not used it because I was unsure if to use it or use type CryptoConfigurations.ts so I made it with string.

You've also found the solution by yourself ;)

Some notes:

in config.json add under Scheduler->tasks the following:
{ "name": "MigrateSensitiveDataTask", "active": true, "periodicity": "* * * * *", "config": {} }
MigrateSensitiveDataTask -> detects when migation is not done and does it
SchneiderAssetIntegration, StripeBillingIntegration, AddSensitiveDataInSettingsTask were dependencies that needed to be changed because the crypto key is now in db -> don't know how to test this part
in start.ts and LockingStorage.ts - I've added the part that deletes all database locks related to migration of sensitive data at server start
In MongoDBStorage we call migrateCryptoKey that migrates the crypto key from config file to DB -> called once

Some notes:

in config.json add under Scheduler->tasks the following:
{ "name": "MigrateSensitiveDataTask", "active": true, "periodicity": "* * * * *", "config": {} }
MigrateSensitiveDataTask -> detects when migation is not done and does it
SchneiderAssetIntegration, StripeBillingIntegration, AddSensitiveDataInSettingsTask were dependencies that needed to be changed because the crypto key is now in db -> don't know how to test this part
in start.ts and LockingStorage.ts - I've added the part that deletes all database locks related to migration of sensitive data at server start
In MongoDBStorage we call migrateCryptoKey that migrates the crypto key from config file to DB -> called once

For the first migration of the Crypto Key from the config file to the database, the config file has to contain;
"Crypto": {   "key": "6pKSrPeSgE6ZNwQXvJPxpsH1E6JWCUyy",   "blockCypher": "AES",   "keySize": 256,   "operationMode": "CTR" }

For the first migration of the Crypto Key from the config file to the database, the config file has to contain;
"Crypto": {   "key": "6pKSrPeSgE6ZNwQXvJPxpsH1E6JWCUyy",   "blockCypher": "AES",   "keySize": 256,   "operationMode": "CTR" }

To test this PR:

Make sure you have in config.json the new Crypto and MigrateSensitiveDataTask information
First start the server so that the initial key is migrated to the database
To trigger a migration of sensitive data -> In Robo3T change the crypto Setting document to be like this:

{
    "_id" : ObjectId("5ff80f4e3b067644a031dace"),
    "content" : {
        "crypto" : {
            "key" : "{{new-crypto-key-256-bits-length}}",
            "keySetting" : {
                "blockCypher" : "AES",
                "keySize" : 256,
                "operationMode" : "GCM"
            },
            "formerKey" : "6pKSrPeSgE6ZNwQXvJPxpsH1E6JWCUyy",
            "formerKeySetting" : {
                "blockCypher" : "AES",
                "keySize" : 256,
                "operationMode" : "CTR"
            },
            "migrationDone" : false
        }
    },
    "createdBy" : null,
    "identifier" : "crypto",
    "lastChangedBy" : null,
    "lastChangedOn" : ISODate("2021-01-08T07:52:46.665Z"),
    "sensitiveData" : null
}

To test this PR:

Make sure you have in config.json the new Crypto and MigrateSensitiveDataTask information
First start the server so that the initial key is migrated to the database
To trigger a migration of sensitive data -> In Robo3T change the crypto Setting document to be like this:

{
    "_id" : ObjectId("5ff80f4e3b067644a031dace"),
    "content" : {
        "crypto" : {
            "key" : "{{new-crypto-key-256-bits-length}}",
            "keySetting" : {
                "blockCypher" : "AES",
                "keySize" : 256,
                "operationMode" : "GCM"
            },
            "formerKey" : "6pKSrPeSgE6ZNwQXvJPxpsH1E6JWCUyy",
            "formerKeySetting" : {
                "blockCypher" : "AES",
                "keySize" : 256,
                "operationMode" : "CTR"
            },
            "migrationDone" : false
        }
    },
    "createdBy" : null,
    "identifier" : "crypto",
    "lastChangedBy" : null,
    "lastChangedOn" : ISODate("2021-01-08T07:52:46.665Z"),
    "sensitiveData" : null
}

@stefania-santimbrean
Do not provide any security information in github!!!
I removed the key value from your comment!

@stefania-santimbrean
Do not provide any security information in github!!!
I removed the key value from your comment!

in start.ts and LockingStorage.ts - I've added the part that deletes all database locks related to migration of sensitive data at server start

We may have several several batch server instances and only the first one that starts up should remove the locks.
For the time being we have only one but we should find another solution here.

in start.ts and LockingStorage.ts - I've added the part that deletes all database locks related to migration of sensitive data at server start

We may have several several batch server instances and only the first one that starts up should remove the locks.
For the time being we have only one but we should find another solution here.

@stefania-santimbrean
Do not provide any security information in github!!!
I removed the key value from your comment!

Sorry, I did not realize :(

@stefania-santimbrean
Do not provide any security information in github!!!
I removed the key value from your comment!

Sorry, I did not realize :(

in start.ts and LockingStorage.ts - I've added the part that deletes all database locks related to migration of sensitive data at server start

We may have several several batch server instances and only the first one that starts up should remove the locks.
For the time being we have only one but we should find another solution here.

Should this handling now or?

in start.ts and LockingStorage.ts - I've added the part that deletes all database locks related to migration of sensitive data at server start

We may have several several batch server instances and only the first one that starts up should remove the locks.
For the time being we have only one but we should find another solution here.

Should this handling now or?

@LucasBrazi06 could you review the PR please?

@LucasBrazi06 could you review the PR please?

in start.ts and LockingStorage.ts - I've added the part that deletes all database locks related to migration of sensitive data at server start

We may have several several batch server instances and only the first one that starts up should remove the locks.
For the time being we have only one but we should find another solution here.

Should this handling now or?

Yes but only on SCP: you have to delete the lock that only have been the same hostname than the current one.
You also have to ensure the deletion is only run within the master processus.

in start.ts and LockingStorage.ts - I've added the part that deletes all database locks related to migration of sensitive data at server start

We may have several several batch server instances and only the first one that starts up should remove the locks.
For the time being we have only one but we should find another solution here.

Should this handling now or?

Yes but only on SCP: you have to delete the lock that only have been the same hostname than the current one.
You also have to ensure the deletion is only run within the master processus.

@LucasBrazi06 could you review the PR please?

All conversations should be closed and Jerome should acknowledge so I can start to avoid feeedback conflicts.
Could you check?

@LucasBrazi06 could you review the PR please?

All conversations should be closed and Jerome should acknowledge so I can start to avoid feeedback conflicts.
Could you check?

Error in sub-module SAP Convergeant Charging:

Maybe my sub-modules was not in sync.

Error in sub-module SAP Convergeant Charging:

Maybe my sub-modules was not in sync.

Just a quick note: Please keep this PR here as I'm looking at all the comments when doing the other PR for each step agreed in the meeting and sent on email.

Just a quick note: Please keep this PR here as I'm looking at all the comments when doing the other PR for each step agreed in the meeting and sent on email.


⚠ Spryr has degraded performance

In 3ae5069, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3157 ms

Resolved: Spryr performance has improved in b705b3c after 7 minutes.


: Could not initialize class com.amazonaws.serverless.proxy.spring.SpringBootLambdaContainerHandler

Hi Stefano, Thanks for the great presentation.  I followed the instructions as per Readme.txt(sample/springboot2/native-pet-store)  and I'm able to deploy as Lambda but when I invoke the URL I get Internal server error and could see following error in Cloud watch logs:  Exception in thread "main" java.lang.NoClassDefFoundError: Could not initialize class com.amazonaws.serverless.proxy.spring.SpringBootLambdaContainerHandler, Request you to kindly help me to fix this issue ASAP.

Looks like the class you need is not getting packaged in the deployment or something is not trying to load the right class. The native project should depend on the com.amazonaws.serverless.proxy.springboot2 package.

Looks like the class you need is not getting packaged in the deployment or something is not trying to load the right class. The native project should depend on the com.amazonaws.serverless.proxy.springboot2 package.

Thanks for the quick response I did not make any changes , just followed the steps mentioned in README under sample/springboot2/native-pet-store  :(. Please suggest. Should I make any changes in configuration or its ok to use as is?

I request you to kindly help us on this ASAP. Stuck with cold start spring boot cloud function even for a simple hello world and company has decided to go ahead with aws lambda for all rest calls :(

@anandv1770 are you still stuck? happy to help...

No further feedback, closing...


[4.16.0] NDI third party libraries missing when packaging for linux

Hi,
Just tried today to launch the packaged linux build and it comes out that the "Third Party" folder with the librairies is not packaged with it.
On windows the files are copied and the plugin works fine.
After copying the files by hand it works.
I tried to add the path to the files/folder into a /Config/FilterPlugin.ini file but changed nothing.
PS: i have also a crash issue at runtime, but i will first investigate to be sure it comes from the plugin before opening an other issue.

Thanks gundz, can you try the fix I just checked in?
Also, do you have a callstack for the crash? I can take a look at that as well. There is a known shutdown crash on Windows that I couldn't figure out yet. It only happens when the game or Editor is exited, and something inside NDI is dereferencing an invalid pointer. It's possible that the same thing happens on other platforms - I haven't tried.
I don't know of any runtime crashes in NdiMedia at this time, but that doesn't mean there aren't any :)

Your fix works perfectly !
For the other issue i'll check more in details tomorow and open another issue if its relevant (the crash happens in the NDIlib_find_get_current_sources function, the same (if i remember well the same line as the windows crash that happens sometimes)
Thanks for your quick answer !


redirect stderr to a file for debugging

Redirect stderr to a file for debugging

Wouldn't it be better if there is an option either to log in a text file or in a console window? Like .wslconfig has debugConsole xor debugConsoleLogFile.

Wouldn't it be better if there is an option either to log in a text file or in a console window? Like .wslconfig has debugConsole xor debugConsoleLogFile.

This module doesn't have any visibility to .wslconfig, so that's not possible. The immediate goal for us is to capture any error sent to stderr, during WSLg development. Once stable, it's possible we may switch back to kmsg, including child process (previously only this WSLGd process's stderr was redirected).


repair bug of when merged segments the bucketId was losted

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

repair bug of when merged segments the bucketId was losted


added: Notebooks

Notebooks is a versatile note-keeping app
with versions for Mac, Windows and iOS.

Thank you for the contribution. It was merged directly as 228cbebe360bb8eb9b27cadc5bcbf1e5ee613e66 to keep commit history cleaner. Your contribution is still credited to you.


Revert "Allow no hosts in the ServiceEntry validation"

Reverts istio/istio#12497

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4dc95ede5e11c8cc45e7e5a9634958e02b3e0d4f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu, ymesika
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu,ymesika]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4dc95ede5e11c8cc45e7e5a9634958e02b3e0d4f
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
4dc95ede5e11c8cc45e7e5a9634958e02b3e0d4f
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4dc95ede5e11c8cc45e7e5a9634958e02b3e0d4f
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
4dc95ede5e11c8cc45e7e5a9634958e02b3e0d4f
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
4dc95ede5e11c8cc45e7e5a9634958e02b3e0d4f
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4dc95ede5e11c8cc45e7e5a9634958e02b3e0d4f
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
4dc95ede5e11c8cc45e7e5a9634958e02b3e0d4f
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
4dc95ede5e11c8cc45e7e5a9634958e02b3e0d4f
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
4dc95ede5e11c8cc45e7e5a9634958e02b3e0d4f
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Enable SDK to be built with Java 21

Java 21 is the current LTS version, so it is what we should be building with. It is already configured for the CI builds, but some component updates are required in order to make the build pass.

Done as of 1.0.0.Beta7.


JAVA-1751: Include defaultTimestamp length in encodedSize for >= V3

QueryProtocolOptions.encodedSize previously incorrectly only accounted
for defaultTimestamp length if protocol version was equal to V3.  It
should be included for all protocol versions >= V3.

If there are other bugs in encodedSize, we want to fix them in order to allocate the optimal size and avoid resizing.
However blowing up if the size is wrong is probably too aggressive, at least for driver 3, since the error is recoverable. So I suggest adding a warning that will alert us if this happens elsewhere (it's the only warn log in this class, so easy to disable). I'm going to trigger our integration suite with it to check that it doesn't pop up.

👍 on adding the warning, thanks!

The warning identified at least one other issue, JAVA-1770 which I pushed a fix for in a89b30a.  Will run through suite again to see if any other issues are identified.

I don't see any more incidences of the added warning, so I think we got them all 🎉


user16217248: Blacklist Oleg.S

user16217248 requests the blacklist of the username Oleg\.S. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Rejected by Jeff Schaller in Charcoal HQ. Reason: 'while the post might have been spam (I cannot see it), there is at least one other Oleg.S user, making for immediate FP; a 'watch' would be much more appropriate, particularly if the user repeats spammy behavior'


Add support for RFC 8358

Add module and test for RFC 8358

Codecov Report

Merging #73 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   99.31%   99.31%   +<.01%
==========================================
  Files          69       70       +1
  Lines        5409     5421      +12
==========================================
+ Hits         5372     5384      +12
  Misses         37       37

Impacted Files
Coverage Δ

pyasn1_modules/rfc8358.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0a87d5...a57cadd. Read the comment docs.

Thank you!


Example never returns from stream.nex().await

The only modification I made to the example code provided in the docs is the SERVICE_NAME to a known service on my network.
Running the program, it never returned any output.
I then commented out the "while loop" and added a single manual entry for the next item and a print statement right before and right after it. This second print statement is never reached.
It looks like "stream.next().await" never returns.

I had the same issue and I think I figured out the problem, at least for me.
If you have multiple network interfaces on your machine, try disabling all, but the one connected to the network you want to send requests on.
With wireshark, I found the mDNS queries were being sent via my Hyper V virtual NIC, which was unexpected. Once I disabled my additional NICs, then it started working just fine.

Same issue. If the network devices are the issue, that is an unacceptable bug. Disabling network devices is either not possible or inappropriate for a given circumstance. This also shouldn't be necessary. Every other library, crate, or shell command I use is otherwise able to access the internet, why is this library different in this regard?

Not sure why the thumbs down when I was just trying to point out the problem to the maintainer, but okay then.

I'm having the same issue on Windows. Disabled all but my primary ethernet interface, and still no joy.


feat: advanced watcher usernames management

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This CL introduces a new plugin watcher that allows to add new
watcher usernames to a task, similar to how the tag plugin works.
A new field allowed_watcher_usernames has also been added to the
core model of a task template to allows pre-defined watchers usernames
at the template level. The pre-defined list of usernames of the template
is merged with the input list given during the creation of a task, ignoring
any duplicate values.

What is the current behavior? (You can also link to an open issue here)

n/a

What is the new behavior (if this is a feature change)?

See description.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No, new feature.

Other information:

n/a

CDS Report test#798.0 ✘

Stage 1

Test ✘

Will be adding some tests, but I would like to gather feedback about the implementation first.

CDS Report test#799.0 ✘

Stage 1

Test ✘


GEOMESA-1455 Scan authorizations in GeoMesaInputFormat cause errors w…

…ith Accumulo 1.7

Complete with minimum unit tests.

Signed-off-by: Jim Hughes<EMAIL_ADDRESS>

+1


Relay chain Mock verification

Verify that the Relay chain staking pallet mock implementation in the test was implemented correctly.
Relay chain mock https://github.com/mixbytes/lido-dot-ksm/blob/main/tests/helpers.py
Staking pallet code https://github.com/paritytech/substrate/blob/master/frame/staking/src/lib.rs
Result of verification - each line of code in Mock should be linked to code in staking pallet

Closing. Moved to Asana


perf: compilation.*Dependencies cache results and merge call

Related issue (if exists)

Summary

🤖 Generated by Copilot at 03d1e39
This pull request enhances the Compilation class and the fake dependency handling in ./packages/rspack/src/compilation.ts and ./packages/rspack/src/util/fake.ts, using a new MergeCaller class in ./packages/rspack/src/util/MergeCaller.ts. These changes aim to improve the readability, efficiency, and reliability of the code.

Walkthrough

🤖 Generated by Copilot at 03d1e39

Refactor getters for compilation dependencies to use properties (link)
Rename _rebuildModule to _rebuildModuleCaller and use push method instead of run (link, link)
Simplify generic type parameters of MergeCaller class from A and C to D (link)
Rename run method of MergeCaller class to push and accept variable number of arguments (link)
Modify createFakeCompilationDependencies function to accept getter function and create new MergeCaller instance (link)
Update has, add, and addAll methods of fake dependency object to use getter function and addDepsCaller property (link)
Add import statement for MergeCaller class in fake.ts file (link)

!eco-ci


Could not load font from file path: "/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf"

The file path to the font was hardcoded in plot.

The rust-fontconfig crate seems to be a nice implementation of cross-platform font searching. Sadly this means I now have two separate font dependencies, rust-fontconfig and rusttype.

Resolved with PR #8.


Issues with stepping into and over certain functions

The following function seems to experience the worst of these issues. When I try to step into transform_3f (which will first go through v3f), it steps into the function but doesn't redirect to the source file containing the function and doesn't allow me to step though it unless I do an "assembly step" at least once, in which case it resumes normal behavior. Strangely, I am able to step into r_push_vertex which is also in its own source file.
Another possibly related issue is that sometimes just stepping over this code (or really any code) causes the debugger to reset its state back to the breakpoint. This one is rare and difficult to reproduce.
void draw_sprite_x(Mat3x3F xform, Vec4F tint, TextureID tex, bool flash)
{
  R_Renderer *renderer = &global.renderer;
  r_use_texture(renderer, &global.resources.textures[TEXTURE_SPRITE]);
  r_use_shader(renderer, &global.resources.shaders[SHADER_SPRITE]);

  Vec3F p0 = transform_3f(v3f(-8.0f,  8.0f, 1.0f), xform);
  Vec3F p1 = transform_3f(v3f( 8.0f,  8.0f, 1.0f), xform);
  Vec3F p2 = transform_3f(v3f( 8.0f, -8.0f, 1.0f), xform);
  Vec3F p3 = transform_3f(v3f(-8.0f, -8.0f, 1.0f), xform);

  // ...

  r_push_vertex(renderer, p0, tint, color, top_left);
  r_push_vertex(renderer, p1, tint, color, top_right);
  r_push_vertex(renderer, p2, tint, color, bot_right);
  r_push_vertex(renderer, p3, tint, color, bot_left);
  r_push_quad_indices(renderer);
}

The step-into issue has been fixed in 6eef8c3e16219863c68d419aa5c3047c788e5cbf. The stepping failure issue has been fixed in 435877824a7fcc56ad1d860c700d85685a7e944a.


fixx: first spike of a git rebase/merge command

to remove the need for the v2 image/step

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstrachan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pr
d8db9677f8e66dd4ed7eed53f297976710eb0da1
link
/retest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Termination of VMware VM suspended because VM was not stopped before deleting

Version Info
17.9, VMware connector
Describe the bug
A provisioning of a VMware VM fails for some reasons. The VM is running but not ready. OK. The subscription remains in "pending". OK:
If the user terminates the subscription (in status pending) the VMware connector tries to delete the VM (which is running) from disk. This fails! The VM should be stopped before deleting!

Example log
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG filename: delete_vm.xml
[02/21 15:56:40] [EjbTimerPool - 2] INFO  Invoking action 'checkVMRunning' of state 'CHECK_VM_RUNNING' for instance '1550762639045'
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG vSphere connection is alive. Check took 20ms. URL: https://vcenter.fjdemo.local/sdk/vimService?wsdl, UserId<EMAIL_ADDRESS>[02/21 15:56:40] [EjbTimerPool - 2] DEBUG vcenter: vcenter.fjdemo.local
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG NIC adapter VM Network
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG GuestInfo IP [<IP_ADDRESS>] dhcp=false
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG GuestNicInfo.getNetwork = VM Network
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG Manual configured IP <IP_ADDRESS>
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG getState networkCardsConnected=true validHostname=false, validIp=false
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG instanceName: ESCM-test03 isLinux: false guestid: windows9_64Guest OS: Microsoft Windows 10 (64-bit)
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG NIC adapter VM Network
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG GuestInfo IP [<IP_ADDRESS>] dhcp=false
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG GuestNicInfo.getNetwork = VM Network
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG Guest system is not ready yet [hostname (false) =Win10-1.FJDEMO.local, ipReady=false, VM Network=[<IP_ADDRESS>],guestState=running, toolsState=TOOLS_OK, toolsRunning=guestToolsRunning, isConnected=true]
[02/21 15:56:40] [EjbTimerPool - 2] DEBUG Transition from current state 'CHECK_VM_RUNNING' with event 'not running' into state 'DELETE'
[02/21 15:56:55] [EjbTimerPool - 1] DEBUG InstanceID:<PHONE_NUMBER>045 | OrganizationID: 959c9bf7 | SubscriptionID: Win2016v2#d4658660-e023-4962-85a2-7be1c0ea16b4
[02/21 15:56:55] [EjbTimerPool - 1] DEBUG filename: delete_vm.xml
[02/21 15:56:55] [EjbTimerPool - 1] INFO  Invoking action 'deleteVM' of state 'DELETE' for instance '1550762639045'
[02/21 15:56:55] [EjbTimerPool - 1] DEBUG vSphere connection is alive. Check took 23ms. URL: https://vcenter.fjdemo.local/sdk/vimService?wsdl, UserId<EMAIL_ADDRESS>[02/21 15:56:55] [EjbTimerPool - 1] DEBUG vcenter: vcenter.fjdemo.local
[02/21 15:56:55] [EjbTimerPool - 1] DEBUG Call vSphere API: destroyTask() instanceName: ESCM-test03
[02/21 15:56:55] [EjbTimerPool - 1] DEBUG Save task info key: task-1089 name: Destroy_Task target: ESCM-test03 state: QUEUED progress: 0% description:  queue-time: Thu Feb 21 15:58:51 UTC 2019 start-time: Thu Feb 21 15:58:51 UTC 2019 complete-time:
[02/21 15:56:55] [EjbTimerPool - 1] DEBUG Transition from current state 'DELETE' with event 'deleting' into state 'DELETING'
[02/21 15:57:10] [EjbTimerPool - 2] DEBUG InstanceID:<PHONE_NUMBER>045 | OrganizationID: 959c9bf7 | SubscriptionID: Win2016v2#d4658660-e023-4962-85a2-7be1c0ea16b4
[02/21 15:57:10] [EjbTimerPool - 2] DEBUG filename: delete_vm.xml
[02/21 15:57:10] [EjbTimerPool - 2] INFO  Invoking action 'inspectTaskResult' of state 'DELETING' for instance '1550762639045'
[02/21 15:57:10] [EjbTimerPool - 2] DEBUG vSphere connection is alive. Check took 18ms. URL: https://vcenter.fjdemo.local/sdk/vimService?wsdl, UserId<EMAIL_ADDRESS>[02/21 15:57:10] [EjbTimerPool - 2] DEBUG vcenter: vcenter.fjdemo.local
[02/21 15:57:10] [EjbTimerPool - 2] DEBUG VM: ESCM-test03 taskId: task-1089
[02/21 15:57:10] [EjbTimerPool - 2] DEBUG task-1089 name: Destroy_Task target: ESCM-test03 state: ERROR progress: 0% description:  initiated: FJDEMO.LOCAL\Administrator queue-time: Thu Feb 21 15:58:51 UTC 2019 start-time: Thu Feb 21 15:58:51 UTC 2019 complete-time: Thu Feb 21 15:58:51 UTC 2019
[02/21 15:57:10] [EjbTimerPool - 2] ERROR The attempted operation cannot be performed in the current state (Powered on).
[02/21 15:57:10] [EjbTimerPool - 2] DEBUG Transition from current state 'DELETING' with event 'error' into state 'REPEAT_FAILED_STATE'

https://github.com/servicecatalog/oscm/pull/232


[thud] Add support for Foxy Fitzroy

Merged and tagged as thud/milestones/13 now when it's consistent with milestone 13 in other branches.


Documentation

Update the project documentation with the project structure (example), env variables to set, and main/most complicated logic to be aware of.

Hey I am new to open-source and would love to contribute. How can I help with this project?

Hi @ayushkanyal, We are not accepting external contributions for this project at the moment, but thank you for your interest

Not expecting Codium will add this, so closing. We can update the README/docs opportunistically.


run code error with "dynamically require"

Bug Report
I mostly worked on Rust and recently need to deploy some of our services written in Rust to AWS Lambda@Edge and this is a great example to start with, thanks
the test code running well both in local and AWS cloudfront. I use this as the framework and link our code as crates, and then I have the following error when run "make call" I don't really known how to solve it (I've searched the rollup document but still don't get how to solve this, since I don't use rollup before).
do you know what it might issue with this, thanks a lot!
Error: Could not dynamically require "./snippets/app_edge-d7b4f29aba445e31/inline0.js". Please configure the dynamicRequireTargets or/and ignoreDynamicRequires option of @rollup/plugin-commonjs appropriately for this require call to work.
    at _ (/opt/work/app_edge/request/build.function/index.js:1:241)
    at /opt/work/app_edge/request/build.function/index.js:1:5422
    at Object.<anonymous> (/opt/work/app_edge/request/build.function/index.js:1:16865)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/opt/work/app_edge/request/fixtures/viewer-request-call-test.js:1:23)
make: *** [Makefile:58: call] Error 1

Current Behavior

Code/Gist

Expected behavior/code

Environment
Rust: 1.59.0
OS: ubuntu:20.04
Possible Solution

Additional context/screenshots

Hi @kevi-sun,
I could not reproduce your issue.
In the meantime I also made a whole round of updates for all parts.
Furthermore I only test on node v14 and v16, in CI with ubuntu-22.04 (using latest stable Rust, but that does not matter here).
Could you retry again? Also specific versions for node/npm/rollup CLI would maybe be needed for further debugging, though I cannot help you that much with it, I only utilize JS to the degree it helps me to achieve my goals, I'm no expert in it.
In 2022 rollup might also not be the best choice I guess, I don't really follow the trend anymore. 🤷🏻
I nerdsniped myself and created this experiment with esbuild, which seems to be much lighter on the dependency part, but might create slightly less optimized/smaller packages: https://github.com/asaaki/rust-wasm-on-lambda-edge/pull/418

So I merged #418 and the node bundling part should be less painful hopefully.

Hi @asaaki,
I'm sorry for the late reply and thanks a lot for your keep improving this crate, your work really helped me.
The issue happen when there was the following inline js in rust that I'm not aware of. it is handy when a struct is exported from rust to js and then returned to rust (js is not really used it, just stores the value there). It is fine if move this inline function to js.
#[wasm_bindgen(inline_js = "export function toReceiverMessage(msg) { return msg; }")] extern "C" {     fn toReceiverMessage(msg: JsValue) -> InternalReceiverMessage; }


Feature/Integrate with Arch Linux and systemd

[x] Refactor aws-vpn-client.sh to connect.sh and support more flexible file paths.
[x] Add Arch Linux's PKGBUILD and systemd user service.
[x] Drop connect Docker Compose service as it's way outdated.
[x] Update README

LGTM 👍🚀