msglist: Let recipient header overlap date, just like a message

Fixes: #479
Also update some tests that probably should have been updated in #469.

Screenshots
Before:

After:

Thanks! I noticed the behavior of #479 too, when reviewing #469, but it didn't stand out to me as a problem. I see what you're saying about how the #479 behavior allows some information (like a message's topic) to get nudged off the screen.
This alternative approach seems mostly fine, except I think it now allows the appearance of incorrect information: if I'm looking at the first message on a new day, I can scroll up slowly until it looks like that same message is being labeled with a previous day (like "Yesterday"):
https://github.com/zulip/zulip-flutter/assets/22248748/701c6836-1f09-4d66-a216-0cbc94ddc85e
I don't yet see a nice way to fix that and #479 at the same time, so if you think this is OK, please merge at will.

Thanks for the review!

This alternative approach seems mostly fine, except I think it now allows the appearance of incorrect information: if I'm looking at the first message on a new day, I can scroll up slowly until it looks like that same message is being labeled with a previous day (like "Yesterday"):

Yeah. I'm pretty sure Zulip web had an equivalent bug for years; it's not great, but I think it's a lot less conspicuous than #479. The latter not only pushes some information off the screen, but looks like a significant visual glitch because (a) if you're moving quickly, there's a big flash of white where the sticky header should be, and (b) when the sticky header finishes getting pushed off the screen, "it" (really the new one with the new date) suddenly reappears all at once.
I should file an issue for that new problem, though, so we can track it. I think fixing it will probably involve adding a further wrinkle to the sticky_header library.


Sticky header row

It would be very interesting if you could specify in the global table settings that the header rows can be sticky. Especially with larger data sets or more data sets per page, you otherwise have to constantly scroll upwards if you have many columns in a table.

If you mean by "sticky header" just adding position: sticky to thead on demand, it looks like this could be done for the next milestone.
But maybe you try that out first. You can add the following to your stylesheet
angular2-smart-table thead {
  position: sticky;
}

and see if it has the desired effect.

Exactly, that's roughly how I've already implemented it. Nevertheless, I would find it quite helpful if this option could be configured directly in the settings.
Especially if you also want to make the first columns (in my case the edit column) sticky, you also have to configure the respective z-indexes. Personally, I would find it cool if you could configure the entire column headings on the one hand and individual columns on the left-hand side to be sticky on the other.

Making the action column sticky is a bit more tedious and needs more careful testing, because 1) there could be a multi-select column before the action column and 2) you can choose the action column to be right instead of left.
But for the next milestone I will add the sticky flag for the table head.

Sorry @juulian98 - I have to remove this from the next milestone for now.
Sticky table stuff is still a complete mess... It simply does not work as expected (see the following screenshot).

You could fix the background issue by giving the cells an explicit background. But how can I know which background this is? What's with theming? Custom styles etc.?
Also I do not have a clue why the borders are disappearing when the header becomes sticky.
Apart from that, for sticky headers to work in a scrollable container, the scrollable container must be the direct parent of the table. So I had to hack a height attribute into this thing, because it is not sufficient to wrap a div arround with some height and overflow: auto.
I uploaded the current draft. Any ideas on how to make this thing work are more than welcome :)


compute graph base on spatialdata regions and add mask graph based on polygon

IMPORTANT: Please search among the Pull requests before creating one.
Description
This PR introduces two features:

compute spatial graph based on regions (shapes, labels) from spatialdata.
mask the graph base on a shapes element (in spatialdata)

masking
The idea is, given a graph and a polygon, mask it base on the polygon (either every edge contained inside the polygon, or everything that is outside or partially outside to the polygon).
e.g. see
Original

Positive mask

Negative mask

How has this been tested?

[x] test for spatial graph building based on spatialdata
[x] test for mask graph

It would be nice to have feedback on argument names/apis and I should also be adding an example to show how to use it.

requires release of spatialdata

ok, this is ready to be merged!


[WIP]Add headings to each section of bootstrap process

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind cleanup

What does this PR do / why we need it:

The bootstrap process is divided into the following sections

Checking dependencies
Interactive prompt
Completion

Change the missing flag error message to be consistent with other commands
Add .git suffix to service repo URL after accepting the input. This was being done after the interactive prompt

Sample:

Have you updated the necessary documentation?
See https://github.com/rhd-gitops-example/docs
[ ] Updated
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:

Codecov Report

Merging #4 into master will increase coverage by 0.08%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   60.96%   61.04%   +0.08%
==========================================
  Files          51       51
  Lines        2454     2462       +8
==========================================
+ Hits         1496     1503       +7
- Misses        826      827       +1
  Partials      132      132

Flag
Coverage Δ

#unittests
61.04% <66.66%> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cmd/bootstrap.go
30.86% <62.50%> (+2.94%)
:arrow_up:

pkg/cmd/utility/utility.go
63.88% <100.00%> (ø)

pkg/pipelines/bootstrap.go
68.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3f6cc...d4c5804. Read the comment docs.


Add Login model

[x] make sure the migration is either auto generated when installing the engine or there's a rake task to generate it (not sure how that works)
[ ] the relation from the Login model to the User or whatever the host application uses must be configurable in an initializer

Made it so running rake db:migrate on the application will pick up the engine's migrations, as per http://pivotallabs.com/leave-your-migrations-in-your-rails-engines/ (option 3)

done


Migrate Bazel to Bazelisk version manager

Bazel has been historically painful to manage, Bazelisk is a more flexible official way to manage the version of the Bazel tool similar to nvm (Node Version Manager).
Fix #1153
Similar context #947

LGTM!


Update planning-hub-sites.md

Updated to clean up some terminology and add content about hub to hub associations

Not sure I did this correctly, but hoping these proposed changes make sense.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@scanum, @JohanFreelancer9, following up on the copy edit.

@SusanHanley, thank you for committing the suggestions, but you seem to have missed the last one.

Sorry - missed that last one - mostly because I really don't know what I'm doing!! :-) Think I got it now!

Thanks for the updates @SusanHanley!


The Floor is Lava (literally)

This is a pretty simple idea, and I've seen it done in plenty other games, so somebody may have already suggested it.
I think it might be interesting to build a boss around death traps, for example giant pits of lava with narrow walkways that the players have to navigate. This might make for a great tier 1 boss, since with a tier 1, you can justify insta-killing a player when they fall for a trap. And while we're at it, while not add extending spikes, moving platforms and more?

Instakilling won't happen, but high damage traps should be okay.

I'm thinking that for a tier 1 boss, assuming you're not being harassed by the enemies, health is basically the same as lives in other games. I understand the reason for giving players more than 1 chance to nail the boss, however insta-killing players might actually enforce teamwork (whether or not it's a good idea to do so through such drastic means is beyond me).
Since you as an individual player only has 1 chance of clearing the encounter, you can bring teammates, who can learn from your mistakes and finish the boss fight, benefiting the whole team. At the very least, it's food for thought.

Thank you for the contribution!
We have quite a few boss ideas based off of mazeing and reducing the available floorspace.


README - wsl2 instructions

Added WSL2 instructions that allow the plugin to work when using WSL2. Thanks for your plugin!
Resolves #9

Thanks for the pull request.

Thanks for the pull request.

Thanks for your work @nicollasricas , much appreciated!

Thanks for your work @nicollasricas , much appreciated!


Automated cherry pick of #2670: Fix init node transport interface bug (#2670)

Cherry pick of #2670 on release-1.3.
#2670: Fix init node transport interface bug (#2670)
For details on the cherry pick process, see the cherry pick requests page.

Codecov Report

Merging #2677 (fd486fb) into release-1.3 (55ec2ad) will decrease coverage by 19.66%.
The diff coverage is 25.00%.

@@               Coverage Diff                @@
##           release-1.3    #2677       +/-   ##
================================================
- Coverage        60.75%   41.09%   -19.67%
================================================
  Files              285      158      -127
  Lines            23003    19243     -3760
================================================
- Hits             13976     7907     -6069
- Misses            7535    10587     +3052
+ Partials          1492      749      -743

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.09% <25.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.


favicon

Console complains a favicon is missing. Should be a quick win. We can use a simple tool like http://realfavicongenerator.net/

@brylie Do you have an idea what is missing? Is favicon something we are using or something we have used before?

@philippeluickx will you please paste the console error? We can figure out whether the file is missing, or if it is something else we need to change.

Failed to load resource: the server responded with a status of 404 (Not Found) https://apinf.io/favicon.ico
Also couldn't find any file on the repo: https://github.com/apinf/api-umbrella-dashboard/search?utf8=✓&q=favicon

Cool, a simple fix would be to include the favicon.ico in /public/. We might also want to add favicon as an option on our branding page.

@jykae Any update on the progress? Can the issue be moved to In progress column?


[enh] clicking on an action now saves the form

pros:

no longer loss of manually added data
as anyhow email is sent to the author based on the current state of the form, nothing changed on email sending

solves https://github.com/OAButton/discussion/issues/785

If you trigger an adminsubmit, it will send a save request off to the backend. But if you then trigger the action, that will also send an action request to the backend WITHOUT waiting for the admin submission to complete. This would make it possible for the backend to be in the process of saving the request content when it then receives the request action, which itself can change request content and performs a save. I would be concerned that there is potential for one to overwrite the other here, or for the action to occur before the save completes, which means you will not be able to check to ensure that the content IS saved before the action executes.
If you really want to do this, I suggest you will have to alter the action function to actually call the adminsubmit function with an additional variable giving the name of the action to perform, and then the "success" function of adminsubmit should execute the action. Be careful not to cause an infinite loop doing this though.

Thanks @markmacgillivray & @jibe-b. cc @natalianorori so she's got a heads up and is ready to test when this makes it onto develop.

Another set of requests have been sent empty unfortunately.
Temporarily, as only moderators see this form, a way to inform the moderator is:

That's commit https://github.com/OAButton/website/commit/e38f69477a2d2d63c914a57cee324fb14c58aa08 on the develop branch, hence visible on the dev website

This seems quite old now, closing as I assume it is no longer necessary. Can reopen another PR to the develop branch if required again.


Add makedev for the BSDs

Also, make Linux's makedev function safe and const.

Some changes occurred in OpenBSD module
cc @semarie

r? @Amanieu
(rust-highfive has picked a reviewer for you, use r? to override)

cc @musikid

LGTM for openbsd.
just a question about the type used for the function definition: why using c_uint (and casting it to dev_t) instead of dev_t directly ?

LGTM for openbsd.
just a question about the type used for the function definition: why using c_uint (and casting it to dev_t) instead of dev_t directly ?

Just because that's what the existing Linux definition does.

:pushpin: Commit f776f0e4ef68a27f01509e4d045f69531ae425c8 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit f776f0e4ef68a27f01509e4d045f69531ae425c8 with merge 0d83fa00f5f1d5e24af1147865b8fa6a0ba9fb74...

:broken_heart: Test failed - checks-actions

👍, @bors r+

:pushpin: Commit 3de218ae43cd8a603d93765c8a4daff403000d04 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 3de218ae43cd8a603d93765c8a4daff403000d04 with merge c9fb3b6c5d9fa925019ac74db32a79740a160286...

:broken_heart: Test failed - checks-actions

@JohnTitor I think this should fix the bors error.  But I don't know how to run the tests on emscripten except by asking bors to merge.

We could do @bors try but I think it's okay to r+ in this case.
@bors r+

@bors r+

:pushpin: Commit 2f3fa3e9c6ec0f19ae27131676089c0f0902de3e has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 2f3fa3e9c6ec0f19ae27131676089c0f0902de3e with merge 567820c53d5321738db8ced674640ae9de27f2b2...

:broken_heart: Test failed - checks-actions

@bors try

@asomers: :key: Insufficient privileges: not in try users

@bors try=johntitor

@JohnTitor I think if you do " bors delegate=asomers" then that will give me permission to use "bors try".  It'll also give me permission to merge the PR, but I promise not to do that unless you say so ;) .

👍, @bors delegate+

:v: @asomers can now approve this pull request

@bors try

:hourglass: Trying commit 4f006afda53b023b354b74a921b6b68c3cbab3e0 with merge 6a390b5725de49b34440979eebea1f4821ff3d7b...

:broken_heart: Test failed - checks-actions

bors try

@bors try

:hourglass: Trying commit 8486fd7073dce762e1897df3d06be69e8b6dc5b2 with merge 9fb9ec101b203732701a2cb0d18cb4342c8f1399...

:broken_heart: Test failed - checks-actions

@bors try

:hourglass: Trying commit f26839a6e20c2d3d848f3bd9390d3c9affb7a431 with merge fe38ca19e35b59f079c89e10a1af9936b76313d7...

:broken_heart: Test failed - checks-actions

@bors try

:hourglass: Trying commit 3a615a0170b2da88d9c0057c4bba83f26eb48cc0 with merge b24118e1548647bf39969ef7459552d7fe03a3d1...

:sunny: Try build successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Build commit: b24118e1548647bf39969ef7459552d7fe03a3d1 (b24118e1548647bf39969ef7459552d7fe03a3d1)

@JohnTitor it finally passes CI, I've squashed my commits.

Thanks! @bors r+

:pushpin: Commit 5e6d9c4a92fd563f7e2e58a1e2889ccc4a87ff44 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 5e6d9c4a92fd563f7e2e58a1e2889ccc4a87ff44 with merge 6eee580b51455131b10b780087025379a591ceb6...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 6eee580b51455131b10b780087025379a591ceb6 to master...


function latestTag does not work under Windows shell

hi, if you execute the command inside function latestTag under Windows shell (not the Git shell) throws an error unknow option max-count=1 due to backtick.
I have made a quick test by making two calls instead of only one, using the output of a command to pass to the other one. With this change, it finds the tag.

fixed in 69cfb5c


I can't flash it into the board

I cannot flash to the board - exit status 1
Compilation error for ESP32 Wroom DevKit board.

All other firmwares are compiled normally

I suggest that you read the error message that you are getting!
I have no chance to help you if you do not provide me with any information what sketch you try to flash and about your environment.
The library has been tested with the old Arduino and the new Arduino IDE with ESP32 Versions 1.0.6 up to 2.0.5.

closed due to inactivity


Add missing dependency group

The Composer mlflow dependency group contains more than just mlflow, so we need to install the whole dep group.

@snarayan21 foundry needs the whole dep group


Add job board from sponsor submissions

FYI, I would have preferred to name the file "job board", instead of "jobs board". But that would have resulted in the sponsor info page link 404.
Currently in draft, waiting for more submissions. Once ready, @aramboi and @laisbsc can review.

That page is already 404 so we could just change it to link to /job-board to begin with. ☺

Awesome 🤩 LGTM :shipit:

Looks awesome! @aramboi sent a reminder to all sponsors for the Job Board and Virtual Swag page and no one really replied. So might be better to just merge this and add more as we get it. If we get it.
Also, something it always intrigued me was why the Job Board and Virtual Swag are not under the Sponsor menu on the website 🤔 I can never find it under Info & Support.

Also something it always intrigued me was why the Job Board and Virtual Swag are not under the Sponsor menu on the website 🤔 I can never find it under Info & Support.
Because attendees in the past said they can never find it under sponsorship 😅

Also something it always intrigued me was why the Job Board and Virtual Swag are not under the Sponsor menu on the website 🤔 I can never find it under Info & Support. Because attendees in the past said they can never find it under sponsorship 😅

I'm laughing out loud! 🤣  #howtomakeusershappy?

Maybe we should put the links in both submenus. I mean, I don't think it's unheard of, is it?
But for now, I'll merge like this and maybe add later. 😅


KeyError at /sso/saml/

Hello! I'm having an issue with the user mapping process, because the configuration of the saml where I work doesn't return the key if the user doesn't have the atribute. So when it reaches to the point of mapping, it's possible that saml_data doesn't have one or more keys that have been specified in the SAML_USERS_MAP.
Is it possible to consider this and maybe do this process less strict by controlling if the user_key is in saml_data before asigning it?
Thank you a lot!

Moving discussion to your PR

Addressed in #24, available on PyPi under version 0.0.7 and in the source under a git tag with the same version. Thank you for your contribution @santiagovassallo!

 And thank you for this awesome project!


Init a selinux project

This is an experimental crate. I'll implement a selinux crate step-by-step.
When it is mature, I'll move it under the 'crate/' and use it.
ref: #2718

@YJDoc2 @utam0k
As the initial PR, what function should I implement at least? Or is any small PR fine ?

I'm not familiar with this area. So, It would be nice if you could make the PR small enough so that one function could run on e2e.

Sure, thanks!

Hi @utam0k , @YJDoc2
Though this PR is small, I would like to complete this before becoming too complicated.
Could you review it?

Though this PR is small, I would like to complete this before becoming too complicated.
Could you review it?

This PR is the perfect size for me to review! Thanks. But sorry, I'll revisit it next weekend 🙏

Hi @utam0k, @YJDoc2,
Thanks to your comments, I've fixed this PR.
However, I think there are some parts which is not rust-friendly.
I would appreciate it if you could let me know.

@utam0k
Thanks! Since I don't have the write access, I can't merge this PR.
Could you merge this PR if it is ok?

Thanks, @Gekko0114 !


Slow transitions btwn pages

Maybe we should use ionic router for optimisation.
A loader could be displayed until the page content is rendered, since a part of the transition to a new page is that a gray background is shown

I finally found the issue: the App object was re-rendered at every Route change.
Two things were the cause:

BrowserRouter was declared as a parent component of App (thanks @HugoGresse for the hint)
Clicking on a page on the left menu drawer was changing the window.location.pathname => now using history.push from react-router-dom


[toimage]: bulk conversion working

As per #343  I have implemented the possibility to convert multiple dicoms to a folder of images.
For consistency, I have copied a lot of the logic from the dicom-storescu but I don't think it's worth extracting it yet.
Here are my questions/concerns about this commit and I need some guidance:
1. Not tested on multiframe dicom:
I am very unfamiliar with multiframe dicoms and I don't really know where to find or create proper ones. I was not able to test this commit with multiframe dicoms.
The basic functionality should be preserved but even though, I'm not certain that this is the expected behavior (convert the nth frame of every multiframe dicom in the input).
This is by far my biggest concern for this commit because there might be regressions and I don't know of an acceptable way to handle this since the use case (multiframe to image) is unclear to me.
2. Error enum with only Error::Other variant:
Initially I copied the Error enum from dicom-storescu required in the check_file function return type that I also imported. But since Error::Other is the only variant, maybe should it just be removed altogether ?
3. output flag was replaced by out-dir:
This has several consequences:

The possibility to rename the output file for a single conversion is not retained.
If several files have the same name in the set to be converted they will be overridden except for the last one being converted.

I just went to the simplest implementation that matched the specs in #343. If the mentioned consequences are not acceptable, I can try and find some ways to fix them.
4. The format flag currently takes a String:
It works as is but since the image crate is exposing an image::ImageFormat enum, this can be a good base for clap's checking and suggestions.
I refrained from doing it because I didn't know if every image format should be allowed or any other restriction I don't know about.
Overall this commit is far from perfect but I still opened this PR since I already find it more convenient than DCMTK's equivalent binary.

Thank you for working on this. As I suspect that we might need some time to review and I was about to bring forward a new release of DICOM-rs, I propose that this is worked on after 0.6.0 is out. This should not stop me from publishing this enhancement in a subsequent minor release anyway.

Oh yeah sure, I think you're right ! I'll check in back here when the 0.6.0 is out.

1. Not tested on multiframe dicom: I am very unfamiliar with multiframe dicoms and I don't really know where to find or create proper ones. I was not able to test this commit with multiframe dicoms. The basic functionality should be preserved but even though, I'm not certain that this is the expected behavior (convert the nth frame of every multiframe dicom in the input). This is by far my biggest concern for this commit because there might be regressions and I don't know of an acceptable way to handle this since the use case (multiframe to image) is unclear to me.

DICOM WG4 has a data set with some example files, and the pydicom test files also have some files which are multi-frame. Running cargo test on the project already downloads some of these via dicom-test-files (see for example pydicom/color3d_jpeg_baseline.dcm).
In practice, I can't be sure which behavior is more suitable, but we can either a) pick the first frame only, or b) print all frames into separate files with an extension to the file name, e.g. abc.dcm to  abc_0.png, abc_1.png, abc_2.png,...

2. Error enum with only Error::Other variant: Initially I copied the Error enum from dicom-storescu required in the check_file function return type that I also imported. But since Error::Other is the only variant, maybe should it just be removed altogether ?

Generally, we would go in the opposite direction from here: given this Error type, we can slowly add more specific error variants and replace context calls accordingly.

3. output flag was replaced by out-dir: This has several consequences:

The possibility to rename the output file for a single conversion is not retained.
If several files have the same name in the set to be converted they will be overridden except for the last one being converted.

I just went to the simplest implementation that matched the specs in #343. If the mentioned consequences are not acceptable, I can try and find some ways to fix them.

I admit that this was not made clear in the original issue, but I would prefer that the functionality to convert a single image is retained. It is OK if the code ends up with a bit of redundancy. --out-dir and -o should be marked as conflicting with each other, so it's either one or the other.

4. The format flag currently takes a String: It works as is but since the image crate is exposing an image::ImageFormat enum, this can be a good base for clap's checking and suggestions. I refrained from doing it because I didn't know if every image format should be allowed or any other restriction I don't know about.

That should be fine. At least adding support for extra image formats is as simple as updating image and its feature set.

Thanks for your guidance @Enet4 !
I made good progress on this PR, but I have an issue and I'm not sure what is the best way to handle it:
To select the image format, it's only necessary to set the extension of the PathBuf to the target extension.
So far, I took the original file name and set the extension but I realized there is an issue with filenames that don't include an extension and include a "." which is unfortunately pretty common.
In such cases, methods like file_stem or set_extension don't work correctly since they consider the last portion of the filename (after the last ".") to be an extension so it get lost.
For example given a file f with a filename of "1.2.276.0.123":

calling set_extension("png") on f would return "1.2.276.0.png" (losing the last part)
calling file_stem() on f would return "1.2.276.0" (also losing the last part)

Below is a code snippet to illustrate:
use std::{ffi::OsStr, path::PathBuf};

fn main() {
    let mut path = PathBuf::from("1.2.276.0.123");
    path.set_extension("png");
    assert_eq!(path, PathBuf::from("1.2.276.0.png"));

    let path = PathBuf::from("1.2.276.0.123");
    let stem = path.file_stem().unwrap();
    assert_eq!(stem, OsStr::new("1.2.276.0"));
}

As for the workaround, here are the propositions I though of:

We could force the user to pass a filename command giving some template of the filename based on some dicom tags.
example: --filename "{PatientName}-{SOPInstanceUID}"
This would allow to only have to append the target to this pattern and be done with it.
I implemented a similar logic on an other project and it works fine if the errors (element not found) are correctly handled.
The main downside of this is that it introduces complexity for the user.

We could just append the target extension regardless of the original filename. (I think that's how dcmtk behaves)
This would work but we could easily end up with filenames that end in "123.dcm.png" which is not so pretty.

We could force filenames to be something predictable like a timestamp.
The downside would be that matching original files with their images is harder.

If someone has an other suggestion as well or any opinion on the best one it would be great.
Thanks

I would detect .dcm and only replace the extension in this case, extending the file name in all other cases.

Hello,
This should be good.

Multiframe images:

The user can pass the -F flag to ask for every frame to be converted.
If -F is passed, every image will have a _n appended before the extension
By default, only the first frame will be converted

Error handling:

I add several other errors to make a better use of Snafu

Single file conversion:

The user can pass a single file (instead of a folder)
The user can use the -O option to rename the single file (excluding the extension that should be set with t
The -O option will be ignored with a warning if multiple files are passed for conversion

File names:

dicom-toimage correctly handles name collisions by appending (n) if a file already has the name in the output folder.

Please tell me if any other change should be made, I'll gladly oblige.

Hey,
Thanks for the testing and feedbacks!
I'm currently abroad but I'll make sure to make the modifications as soon as I'm back and have a little time. (likely during a weekend of September).

Hey hello, @Enet4
I am having trouble resolving conflicts in a clean manner. So I plan on starting from a new PR directly from master currents version of the toimage crate. So unless you have a better suggestion, I think we can close this PR.
I just have a quick question. I see that on master's version of main, you have extended the errors and also attributed some specific exit codes. Is there a specification on how exit codes should be attributed or should I just decrease as I add more errors (and group the one that share the same source as I think this is what you've done ?
Thanks !
Pierre

Hello @PierreBou91!

So unless you have a better suggestion, I think we can close this PR.

It is fine either way. It should also be possible to keep the pull request by hard-resetting the branch and doing a forced push.
As for the exit code, it was primarily to differentiate between different kinds of errors, but none of it is intended to follow a stable guideline, so feel free to rearrange them as needed.

I hard reset and force-pushed as advised and reimplemented the bulk conversion.
User can now pass a path to a file, multiple files or a folder (possibly recursively with -r flag). All the file paths will be collected in a Vec<InOuPair> and the output path of will be directly computed according to the --output to chose the name, --ext to chose the extension and, --dir to chose an output directory. The previous run() function is essentially unchanged, just moved in the convert_file function.
I have not reimplemented the frame selection for multiframe dicoms because I'm not sure yet how to do it when the --unwrap flag is selected. I'll try to research the fragments because I'm not familiar with it and the vast majority of the dicoms I have tested with did not successfully converted with --unwrap (only the multiframe dicom example worked fine).
Do you think we could see the multiframe part in a different PR ?
Please tell me if you see any improvements to be made. I also intent on doing an improved error handling for the inventory part.


Added saved recipe page

added a saved recipe page that is only visible to logged in users.

Great addition, I like this new page


CSIP114 conflicts with its examples

CSIP114 requires the presence of one or more mets/fileSec/fileGrp/@USE attributes with the value "Representations," i.e.:
USE="Representations"
However, the examples use more detailed values, e.g.:
USE="Representations/submission/data"
USE="Representations/preingest"
USE="Representations/submission"
USE="Representations/ingest"
Either the requirement text or the examples need to be changed.

Looks like there are text gone missing. The use starts with representations and the folder of what it is is given. But we cant put the rest of the value in the requirement just the start. Textual update will come in the next version.

@karinbredenberg All structMap representation LABEL related requirements have the same problem (CSIP101-CSIP104 and CSIP119).
So, the ideia is to assume that in both cases the logic is the same: the value starts with "Representations" and the whole value should be the path to the representation or representation data (like CSIP64 mentions)? Because if so, that logic colides with CSIPSTR13, which states that the folder name is "representation" (vs. "Representation").


Various linters with nbQA

"Run any standard Python code quality tool on a Jupyter Notebook"
https://github.com/nbQA-dev/nbQA

Started to experiment with bulk notebook linting reports using flake8, as well as injecting reports into notebook code output cells: https://github.com/innovationOUtside/nbqa-inject-flake8-report


NTR: pos reg of transc inv'd in G1 of cell cycle

Hi,
I see that we have these terms for regulation of transcription involved in G1 phase of mitotic cell cycle:
GO:0000114 regulation of transcription involved in G1 phase of mitotic cell cycle
-is_a GO:0060277 negative regulation of transcription involved in G1 phase of mitotic cell cycle
could we please have the positive regulation term also?
GO:NEW positive regulation of transcription involved in G1 phase of mitotic cell cycle
also with parentage under GO:0045944 positive regulation of transcription from RNA polymerase II promoter.
PMID: 20502685
thanks,
stacia
Reported by: srengel
Original Ticket: geneontology/ontology-requests/8878

The original parent terms in this request have been obsoleted. It also looks like the other terms were sorted out previously.  Therefore I am closing this request.


Mentions in new messages are not recognized

If a new message comes that mentions the user, this is not recognized and the message is not rendered differently.

(For more details, see https://github.com/zulip/zulip-mobile/pull/3029#issuecomment-428396766 where we discovered this.)


worldmap: add Mahogany Homes and Soul Wars minigame locations

Adds Mahogany Homes minigame locations (Falador, Varrock, Hosidius, and Ardougne) to the world map
EDIT 1/11/21: Adds Soul Wars minigame and teleport locations

Updated to include new Soul Wars world map locations

Updated to include new Soul Wars world map locations


8312.6 Add logs modal

Shippable/pm#8312
Add log modals to the logs buttons in the UI.  Clicking the logs button for a step should open the log modal and display the logs for the correct step.

complete. closing.


[OSB] Minor text issue for checking minion status during construction trip

When building Myth Cape Racks and checking your minion status, this is what you get. Doesn't seem to apply to any other build item.

Fixed


Unplayable MKV files

I'm having some trouble writing a valid MKV file when inside docker.
I have a sample script, and it works fine on ubuntu, but in a debian docker container the output video file isnt playable.
Mediainfo reports no streams, and says IsTruncated: Yes.
VLC wont play it, neither will gstreamer.
Sample script:
import av

input = av.open('rtsp://<IP_ADDRESS>/unicast', mode='r')
output = av.open('test_docker.mkv', mode='w')

video_stream = input.streams.video[0]
output_video_stream = output.add_stream(template=video_stream)
output_video_stream.options = {}
output.start_encoding()

for packet in input.demux(video=0):
    output.mux(packet)

Dockerfile (python:3.6-stretch based):
FROM python:3.6-stretch

ENV PYTHONUNBUFFERED 1

RUN apt-get -qq update
RUN apt-get install -q -y python-dev pkg-config
RUN apt-get install -q -y \
    libavformat-dev libavcodec-dev libavdevice-dev \
    libavutil-dev libswscale-dev libavresample-dev libavfilter-dev

# Requirements have to be pulled and installed here, otherwise caching won't work
RUN pip install pipenv
COPY ./Pipfile /Pipfile
COPY ./Pipfile.lock /Pipfile.lock

RUN pipenv install --deploy --system

RUN groupadd -r django && useradd -r --uid 1000 --create-home -g django django
ADD . /app

WORKDIR /app

mediainfo output:
General
Complete name                            : test_docker.mkv
Format                                   : Matroska
Format version                           : Version 4 / Version 2
File size                                : 1 018 KiB
IsTruncated                              : Yes

Versions:
Ubuntu 17.10
Docker version 18.03.0-ce, build 0520e24

Dependency
Ubuntu (working)
Docker (broken)

libavformat-dev
7:3.3.4-2
7:3.2.10-1~deb9u1

libavcodec-dev
7:3.3.4-2
7:3.2.10-1~deb9u1

libavdevice-dev
7:3.3.4-2
7:3.2.10-1~deb9u1

libavutil-dev
7:3.3.4-2
7:3.2.10-1~deb9u1

libswscale-dev
7:3.3.4-2
7:3.2.10-1~deb9u1

libavresample-dev
7:3.3.4-2
7:3.2.10-1~deb9u1

libavfilter-dev
7:3.3.4-2
7:3.2.10-1~deb9u1

python
3.6.3
3.6.5

pyav
0.4.0
0.4.0

Let me know what else you need (like a sample video file?).

Interesting, google seems to be able to preview video, even if VLC and gstreamer cant.
Here is an example video that wont play: https://drive.google.com/open?id=1UP8eiQif7CA0n6hUz2B3suM1VvAcdKjC
The google preview works, but if you download the file, I cant get it to play in VLC.

What does including an explicit output.close() do?

Damn, your right, adding a .close makes the file playable.


Finishing Touches:

Alright, we just need to do two last things:

Catch any bugs that appear
Create a good example usage of the program and add it to README

Everything fixed.


0.1.3 dev expose tools

Exposes the tool functions to generate WIF keys and addresses and also updates the example.

Really good, more utils the better -- I just do want to look at, in a simplification pass later, to not require the actual address of the chainparams pointer. That's a bit too "C native" for wide use, since the address of a pointer is going to at least have to be stored and recalled possibly in non-C languages, or via wrappers.
It's OK for this because I'd rather it go in. but I want to constrain exposing users to pointers and mem addresses. It's just a point of failure and difficulty we could probably simplify away.


Player crashed when switching between musics within playlist

I can't switch between musics within a playlist without crashing the player.
Your player is very beautiful and pretty mobile-friend. I really appreciate your work.
Thanks to fix the bug related to the playlist.
Thanks.

I have never encountered this situation, please tell me your OS and browser info, it would be better if you have a demo page or screenshot.

Here is a link to a screenshot: https://goo.gl/bNldLo
Thanks

+1, got below error, on your demo site.  Chrome Version 54.0.2840.59 (64-bit) with OS Linux Mint
Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause()

Repro:

go to demo site http://aplayer.js.org/
Play With playlist, click item1, then click item2

I can reproduce this situation now, thanks.
I will fix it later.

Thank you  for your friendly support.
May I know when I can expect this issue to be fixed.
I would like to use your player in a projet that I'm working on.
Thanks

I will fix it tonight (Chinese Standard time)

Awesome.
Thank you so much


Update dependencies

Update / harmonize various dependencies
Switch to formidable lint
Update travis

/cc @boygirl

approved pending potentially adding .eslintrc-demo

Released in<EMAIL_ADDRESS>


Precision loss warning from thumbnails

🐛 Bug
Converting image to uint8 for the thumbnails raises a precision loss warning:
/Users/kevin.yamauchi/Documents/MyNapari/napari/.venv/lib/python3.6/site-packages/skimage/util/dtype.py:135: UserWarning: Possible precision loss when converting from float64 to uint8
  .format(dtypeobj_in, dtypeobj_out))

To Reproduce
Steps to reproduce the behavior:

Run /examples/add_image.py
The following warning is printed to the terminal

/Users/kevin.yamauchi/Documents/MyNapari/napari/.venv/lib/python3.6/site-packages/skimage/util/dtype.py:135: UserWarning: Possible precision loss when converting from float64 to uint8
  .format(dtypeobj_in, dtypeobj_out))

Expected behavior
The warning should be suppressed
Environment

napari Version (latest commit): 244c818
OS (e.g., Linux): OS X
Python version: 3.6

It looks like this will be resolved by https://github.com/scikit-image/scikit-image/pull/3575. @jni, do you know if this will be merged soon?
Otherwise, we can just catch/ignore it with warnings.

@kevinyamauchi I'll make another push on it.

Awesome! Thanks, @jni!

 Unfortunately it'll probably be a couple of months before 0.16 is out though.

Amazing! Thanks for the quick turnaround, @jni!

This is fixed in #370, and I'm closing the issue, though once skimage 0.16 comes out we could remove our warnings catch


opam files: remove mentions to odoc

That's actually generated by dune so can't change this :sadpanda:


Update package.json settings in README

The syntax in the current README, specifying what to add to package.json, isn't valid json syntax and doesn't match the addition suggested in the blog post. This updates the documentation here to align with the blog post.

Looks like this should work with updated Jest


feat(gyp): update gyp to v0.9.4

Checklist

[ ] npm install && npm test passes
[ ] tests are included
[ ] documentation is changed or added
[ ] commit message follows commit guidelines

Description of change

couple of windows issues there but rubber stamp from me if you can figure those out
I suppose I should cut a release after this! we have a fair bit built up

@rvagg This id ready for review.


Support when running with frozen string literals

RUBYOPT=--enable=frozen-string-literal bundle exec rspec
Ruby is once again going in the direction of freezing strings by default. This is all that's needed here to make it compatible, at least according the the test suite and what I make use of from the gem myself.
I don't really expect this to be merged, the project looks pretty dead to me but maybe someone else will find this useful.

@Earlopain i know this is old, but more relevant with 3.4 now.  I was just about to submit a PR, then saw yours pending.  Same exact change, so can verify fix if anyone maintaining their own forks, or future 3.4 users that end up here.


[PIO-3] Update all the file headers with ASF License

Not sure whether the PR fixes all files, here is a list of fixed files:

All scala files

All java files

All py files

All bash files

SBT files with previous TappingStone license header

Configure files

FYI @HyukjinKwon, I also fixed the latter one you mentioned here https://github.com/apache/incubator-predictionio/pull/256#issuecomment-234698437

LGTM

Testing GitHub integration.


fix: tinytex issues

quarto install tinytex requests for confirmation. It is important to set the --no-prompt option.

I had to stop the runners manually and restart them. Can we get this merged (forcefully) and try the nightly runs?

Okay - closing PR


Documentation: User Guide

[x] Registering
[x] Navigating the site

[x] Help
[x] App
[x] Report
[x] Account

[x] Creating a new Project

[x] Selecting focus regions
[x] Filtering/configuring parameters
[x] Budgets: Fixed vs. Ranged
[x] Saving (maybe not required)

[x] Report

[x] Reading the Report (anatomy)
[x] Printing the Report
[x] Exporting Report Data
[x] Sharing the Report

[x] Loading previously saved Projects

Accidentally created #144 -- will close.

Workarounds to share.
Results

Response to request for PADID to pop up in map: Not in pop-up, but clicking pulls it up in table and search box.; hovering highlights it in table.

as of 4/26, needs @rhodges to address a few comments and maybe one last read-through from @jtutak


Email service does not work

Based on your coding, the service related to receiving the email settings in section (InfrastructureServiceRegistartion) will not be returned, please help.

Of course it's null, you have to use your own SendGrid Api Key :)


Enable back button to return to the first page

In our first two tests, both users assumed that they could use the browser's back button to return to the first page and enter different addresses.
Currently, clicking back will take you to the whatever you were viewing before you opened the tool. It's not critically important – both participants understood that they needed to click forward to get back to the tool, but it wasn't the expected interaction.

@awolfe76 This is fixed in build as I am not experiencing this issue in build.


mysql_database/client cookbook.

As the database cookbook is deprecated now, should sous-chefs do a mysql_client cookbook that will have the same functions specific to mysql database? If yes, what platforms/features do we start with.

I think this would be a great thing to write

I would say it should probably just go in the mysql cookbook itself, but it's the same functionality either way.

@coderanger interesting, I was thinking of abstracting the two so that a php server would use mysql_client, whereas a db server would use mysql_server, thoughts?

Someone in sous chef mentioned a few months ago about starting the mysql_client cookbook. I think it would be great to do.

Agree with a separate cookbook with client resources.

https://github.com/sous-chefs/mysql_database/milestone/1
well lets see how this goes


lastest version for 1.18.1 have problem with prevent_entity_render. And with applay shader to see change I need to change perspective F5

Minecraft Version 1.18.1
Origin Version 1.3.11
This power is applay shader but if i want see change i need change perspective
"vision1": {         "condition": {             "type": "origins:or",             "conditions": [                 {                     "type": "origins:power_active",                     "power": "torkit:transform_tf"                 },                 {                     "type": "origins:resource",                     "resource": "torkit:transform_r",                     "comparison": "==",                     "compare_to": 1                 }             ]         },         "type": "origins:shader",         "shader": "minecraft:shaders/post/blobs.json",         "toggleable": false     },

Minecraft Version 1.18.1
Origin Version 1.3.11
This power make invisivle entity fox when i am in first person

"f3hide": {
"condition": {
"type": "origins:resource",
"resource": "torkit:transform_f3",
"comparison": "==",
"compare_to": 0
},
"type": "origins:prevent_entity_render",
"entity_condition": {
"type": "origins:power",
"power": "torkit:foxnodie"
}
},
This power is before and add to entity fox power foxnodie

             {
                "type": "origins:execute_command",
                "command": "power grant @e[tag=foxform] torkit:foxnodie"
            },

I still can't figure out what the second power is supposed to do.
If you want to hide entities with tag foxform, use
{
    "type": "origins:in_tag",
    "tag": "foxform"
}

Also I would discourage you from using the minecraft namespace for tags.

In version I can't remember but I think
Origins <IP_ADDRESS> it's working and I don't change code

.12 has a change that might make your power work. Try it out. If it doesn't check your logs. Apoli reports errors in powers when a world is loaded.

ok i test origins .12  and it work now prevent entity render its working thanks :)
but shader is not applay(update) when i click primiary button
its applay when i change perspective after i click primiary button


Live

Docs Build status updates of commit b5023f7:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[BUG] Wrong percentage calculation

Current Behavior
When the torrent finished the download and reached to 100%, in Kodi, Elementum showed 33% (instead 100%), the status in the log changed from 'Downloading' to 'Queued'. It seems that all the percentage calculation during the download was wrong.
Expected Behavior
Follow the actual downloading state according to the torrent status.
Steps to Reproduce (for bugs)
Just check a one of the torrents in kodi and verify it with the torrent itself.
Your Environment

Version used: Elementu, 0.0.42 (File storage)
Environment name and version: Kodi 17.6
Operating System and version: Windows 10, 64 bit
Link to Kodi debug log: https://paste.ubuntu.com/p/2j9r9pN3jd

02:06:12.627 T:568  NOTICE: [plugin.video.elementum] DEBU  bittorrent   ▶ progressEvent    PR: 446499 (524288)/1782; "Downloading" = 33.33
02:06:13.625 T:568  NOTICE: [plugin.video.elementum] DEBU  bittorrent   ▶ progressEvent    PR: 453107 (376832)/1667; "Queued" = 33.33

Link to torrent log: https://paste.ubuntu.com/p/DY7N9WvzkV (You can see it reached to 100% file)
Screenshot: https://postimg.org/image/e3uxugbat/494ec939

Things changed in 0.0.43.

Thanks, I will check.

Still not working properly with the %, my download is now completed, but shows 50.44% .

I always have to wait the end of the download before watching. The streaming doesn't work (I can only see a few minutes then video stops, even when the download is almost finished...

Yep. Unstable download speed and the math is wrong for % download and total dl. I don't know if the download speed is correct either.  It's also trying to buffer up to 10-15 % of a large movie before it even starts playing. Quasar buffered 1-2%. It finally seems to totally lose track of where it's at and just stops.

It's also trying to buffer up to 10-15 % of a large movie before it even starts playing.

It's also trying to buffer up to 10-15 % of a large movie before it even starts playing.

The init buffer size can be set in the Settings, you can change it.

It's also trying to buffer up to 10-15 % of a large movie before it even starts playing.

The init buffer size can be set in the Settings, you can change it.
Regarding the unstable speed etc, there is another issue of mine.

@elgatito
The original bug still exist, look in the log what happens in 71.54%,
still keep downloading while the percentage is stuck on 71.54%, and continue to download until it finish but still the same percentage value, 71.54%
(Version 0.0.43)

@burekas7 for memory storage there is no perfect way to calculate progress percentage (because we operate data numbers, that changes as we delete non-needed pieces of torrent).
For file storage we take numbers from torrent engine.
If you have the described error with 0.0.44, please, provide a new log file.

@elgatito
But I didn't use Memory storage, I'm using the File storage option.
I will check it with 0.0.44 and update if this will happen again.

@elgatito
Update:
The problem is still exist in 0.0.44.
The progress stop twice, on 20.49% for a while and then it continued until 33.33% which is actually was the 100%.
https://s31.postimg.cc/9tk735wob/screenshot018.png
https://s31.postimg.cc/mkyd9oe63/screenshot019.png

By the way, I had a strange behavior that I paused the video for short period, and the dialog of the init buffer progress jumps again.
Screenshot: https://s31.postimg.cc/nzzxydke3/screenshot007.png

Kodi Log: https://paste.ubuntu.com/p/mVyYksFyq8

It did work on Quasar....
On Apr 22, 2018 1:08 PM, "burekas7"<EMAIL_ADDRESS>wrote:

@elgatito https://github.com/elgatito
Update:
The problem is still exist in 0.0.44.
The progress stop twice, on 20.49% for a while and then it continued until
33.33% which is actually was the 100%.
https://s31.postimg.cc/9tk735wob/screenshot018.png
https://s31.postimg.cc/mkyd9oe63/screenshot019.png

By the way, I had a strange behavior that I paused the video for
short period, and the dialog of the init buffer progress jumps again.
Screenshot: https://s31.postimg.cc/nzzxydke3/screenshot007.png

Kodi Log: https://paste.ubuntu.com/p/mVyYksFyq8
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/elgatito/plugin.video.elementum/issues/103#issuecomment-383408686,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiAAiDjM_Spn3OMuwDRu5Yjp9z_Tqm5Rks5trONFgaJpZM4SFlFP
.

We use numbers, that we get from torrent engine for torrent progress. It depends on many options how they calculate bytes count. But we don't influence it.


chore: restore old range strategy for dev-dependencies

…which is: relying on the lockfile maintenance.
When I updated the config to switch to the new configuration properties, I
failed to re-create the setting for dev-dependencies¹, which led to a
lot of PRs being opened by Renovate.
With this change the majority of dependency updates should be done
implicitly again via the lockfile maintenance. Only major updates will
lead to a dedicted PR which replaces the version string with the newer
one.

¹: https://github.com/xing/hops/blob/dad6ee42a1d80dcccb47c587c61ebeb02ea2a819/renovate.json#L40-L42

Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).

Syntax
Description

bors merge
Run the test suite and push to master if it passes. Short for "reviewed: looks good."

bors merge-
Cancel an r+, r=, merge, or merge=

bors try
Run the test suite without pushing to master.

bors try-
Cancel a try

bors delegate+
Allow the pull request author to merge their changes.

bors delegate=[list]
Allow the listed users to r+ this pull request's changes.

bors retry
Run the previous command a second time.

This is a short collection of opinionated commands. For a full list of the commands read the bors reference.

bors retry

react-intl needs to be updfated internally on master first.

bors retry


API | Shop Endpoints

I have created the Shop endpoints. They are the ones from the doc and some that came to mind that aid with the game.
Some many pop up during the day that I may add, such as Admin stuff (if it is needed). Else, I am making this PR to get feedback and so that the frontend can continue.

We have fix for B808 for fastapi, so do not ignore B808 on module level
https://github.com/FloncDev/exquisite-exoplanets/pull/29#issuecomment-2241332812

Where is the shop router

Where is the shop router

I may or may not have not added them...

No wonder why it it fail pre-commit 💀

Where is the shop router

I may or may not have not added them...

So when are you gonna add them lul
(Btw, you can still add commit while in a pr


The expected dylibs are missing from the app’s Framework location

Here's the message while uploading to App Store

The expected dylibs are missing from the app’s Framework location, such as /Payload/app/Frameworks

ALWAYS EMBEDED SWIFT LIBRARIES flag try to set to YES and NO, nothing help.

Same issue, @curselolz could you solved this?

Same issue, @curselolz could you solved this?

We use react-native-masked-text instead of this

I've encountered the same issue.

RN 0.59.4,
plugin version is 1.0.1
Error dyld: Library not loaded: @rpath/libswiftCore.dylib   Referenced from: /Users/olegtiulenev/Library/Developer/Xcode/DerivedData/twentyonevek-aakospyxjhkqufcqmfvtdxqbosih/Build/Products/Debug-iphonesimulator/InputMask.framework/InputMask   Reason: no suitable image found.  Did find: 	/usr/lib/swift/libswiftCore.dylib: mach-o, but not built for iOS simulator

I have the same issue as @trickyc0d3r , but only on 11.3 iOS, maybe its on all 11s versions, because 12.2 is working

I reproduced this issue, working on it, thank you

I have the same issue as @trickyc0d3r , but only on 11.3 iOS, maybe its on all 11s versions, because 12.2 is working

I believe its all osx versions prior to 12.2. We get the same error+crash on devices running 12.1.4, but it works for us on 12.2

@ivanzotov I faced the similar issue issue.
dyld: Library not loaded: @rpath/libswiftCore.dylib
Reason: image not found
Did you find the cause & resolution for this issue?
I tried solution provided by @RyanThomas73 but it didn't worked too.
Thanks in advance. Any help will be appreciated.

Try the steps described here:
https://github.com/react-native-community/react-native-text-input-mask/issues/117#issuecomment-513812574


Simplify TestHeadReadWriter_Truncate

The verifyFiles method was very confusing even though I wrote it myself. I have modified it to be like in TestHeadReadWriter_Truncate_NoUnsequentialFiles which was added recently which is much clear to read.
For reviewers: It is easier to read and understand the entire test from top to bottom instead of reading the diff in this PR.
PS: I fixed the test names to match with the updated names for the structs.

I'll review this ASAP. (Wanted to do it today, but on-call etc. blabla.0

Hello @codesome, are you still interested in this? thanks!

Yes

I have addressed the review and fixed the conflicts. Should be good for another review.
PS: "For reviewers: It is easier to read and understand the entire TestHeadReadWriter_Truncate test from top to bottom instead of reading the diff in this PR." still holds :)


Selectable ROM implementation (BRAM or DRAM) for the "9-scalable_test" design

I added support for explicitly instantiated DRAMs (RAM64X1D) to the 9-scalable_test design. The ROM implementation and its content is generated by a Python script. I had to limit size of the ROM data when using DRAM to 64 words in order not to use too many DRAMs and logic for muxes.
The CMake now generates targets top_bram_xxx and top_dram_xxx

LGTM!


Replace plotly cdn by static resource for server

Allow template to use a custom library path instead of hardcoded one. Needed for #25.

Done via https://github.com/mipt-npm/plotly.kt/commit/1531db288309289a870515d66a31dc5e79591195


Add support to CM SDK for setting time for scheduled publish

Motivation
Currently, setting time for scheduled publish is not supported in the Content Management SDK.

Released in 0.0.14


Update tests to use NUnit3

Update to NUnit3
Replace the ExpectedExceptionAttribute with Assert.Throws()

Updating to NUnit3 is needed in order to use the latest adapter
http://www.alteridem.net/2017/05/04/test-net-core-nunit-vs2017/
I would also like to add the new test adapter so that I can use dotnet test for running the tests and also the tests will show up in Visual Studio.
https://www.nuget.org/packages/NUnit3TestAdapter/3.8.0-alpha1
@jonorossi are you ok with using the new test adapter now?

If you can fix the indentation in a few places everything looks great. Apologies for the delay.

https://www.nuget.org/packages/NUnit3TestAdapter/3.8.0-alpha1
are you ok with using the new test adapter now?

Yep, happy for you to upgrade it.

Are we using .editorconfig? It could take care of these minor editor issues, for all PRs

The indentation issues appeared because the source code uses tabs and I edited them in Visual Studio which used spaces. It would be nice if editorconfig could help with that.

Switching to using the new adapter did not work well.
https://ci.appveyor.com/project/alinapopa/windsor/build/1.0.102
Adding the new adapter caused 20+ test failures, most of them with the error:

Could not load file or assembly Microsoft.VisualStudio.TestPlatform.ObjectModel, Version=<IP_ADDRESS>

. trx output is successfully uploaded, but looks like AppVeyor cannot read it. Nothing is displayed in Tests tab.
So I will not add the new test adapter to this PR.

Could not load file or assembly Microsoft.VisualStudio.TestPlatform.ObjectModel, Version=<IP_ADDRESS>

After adding the new NUnit test adapter, this error is caused by the new NUnit3.TestAdapter.dll that are now dropped to the output folder.  This dll has a dependency on Microsoft.VisualStudio.TestPlatform.ObjectModel.  The failing tests scan all assemblies in the test output folder and use Refelection to get types from them.
There are several options

Don't add the test adapter. We could use NUnitLite in the same way Castle.Core does. We will be missing the Visual Studio Test Explorer integration though.
Change GetAvailableTypes() to catch and ignore exceptions when assemblies fail to load. Current code already catches RefelectionTypeLoadException and returns types loaded so far. This method is in Castle.Core.Internal so not a breaking change to consumers.
Change those tests to filter NUnit3.TestAdapter.dll. This would make tests ugly...
Copy assemblies to be scanned to a new folder and test that folder. Extra code to workaround this issue.

I think option 2 is reasonable.  @jonorossi any more ideas?

Are we using .editorconfig? It could take care of these minor editor issues, for all PRs

Hmmm, actually no. I assumed we did, but we've only got one in Castle Core.

After adding the new NUnit test adapter, this error is caused by the new NUnit3.TestAdapter.dll that are now dropped to the output folder. This dll has a dependency on Microsoft.VisualStudio.TestPlatform.ObjectModel. The failing tests scan all assemblies in the test output folder and use Refelection to get types from them.

After a quick look it appears GetExportedTypes gets the public types of the assembly that contains the IWindsorInstaller, in this case in the unit test assembly which must cause NUnit3.TestAdapter to get loaded.
I assume the NUnit3TestAdapter package is designed for Visual Studio, does it then only break running in VS or does this ship with the command line build too?

@jonorossi It also breaks when running from command line, with dotnet test

#234


MCCGQ14LM (lumi.magnet.acn001) can't be paired in 3.0.0

I have two MCCGQ14LM (lumi.magnet.acn001) sensor and they were removed after upgrading 3.0.0
I re-pair them but fail, can help check it? Thanks.
Gateway firmware version : 1.5.0_0102
Integration version : 3.0.0
2023-01-23 21:40:28,251 x.x.x.x [LUMI] 54ef443***** (lumi.gateway.mgl03) recv {'discovered_mac': '54ef4410002*****'}
2023-01-23 21:40:28,253 x.x.x.x [LUMI] 54ef443***** (lumi.gateway.mgl03) recv
2023-01-23 21:40:28,824 x.x.x.x [LUMI] 54ef443***** (lumi.gateway.mgl03) recv {'pair_command': {'code': 0, 'install_code': '25be63b360cadb924de1243012fff1cc4ee7', 'mac': '54ef4410002*****'}}
2023-01-23 21:40:32,083 x.x.x.x [SLBS] 0x54ef4410002***** (0x69d4) new unknown device
2023-01-23 21:40:32,134 x.x.x.x [BASE] 0x54ef4410002***** (0x69d4) paired {'did': 'lumi.54ef4410002*****', 'mac': '54ef4410002*****', 'model': 'lumi.magnet.acn001', 'version': '4', 'zb_ver': '3.0', 'joined_type': 1}
2023-01-23 21:40:32,135 x.x.x.x [BASE] 0x54ef4410002***** (0x69d4) setup zigbee MCCGQ14LM (lumi.magnet.acn001): contact, battery, battery_low, zigbee
2023-01-23 21:40:32,135 x.x.x.x [LUMI] 54ef443***** (lumi.gateway.mgl03) recv {'added_device': {'did': 'lumi.54ef4410002*****', 'mac': '54ef4410002*****', 'model': 'lumi.magnet.acn001', 'version': '4', 'zb_ver': '3.0', 'joined_type': 1}}
2023-01-23 21:40:32,246 x.x.x.x [LUMI] 54ef443***** (lumi.gateway.mgl03) recv
2023-01-23 21:40:32,479 x.x.x.x [LUMI] 54ef443***** (lumi.gateway.mgl03) recv
2023-01-23 21:40:33,120 x.x.x.x [LUMI] 0x54ef4410002***** (0x69d4) recv
2023-01-23 21:40:33,272 x.x.x.x [LUMI] 54ef443***** (lumi.gateway.mgl03) recv {'pair': False}
2023-01-23 21:40:35,119 x.x.x.x [LUMI] 0x54ef4410002***** (0x69d4) recv
2023-01-23 21:40:35,645 x.x.x.x [LUMI] 54ef443***** (lumi.gateway.mgl03) recv {'remove_did': 'lumi.54ef4410002*****'}

Do you use China cloud for MiHome?

My MiHome is built in SG server, but I pair Zigbee devices by integration command instead of MiHome.
I also try to turn on firewall between Gateway and MiHome but still fail.
Any idea? Thanks.

Many E1 models works only with China cloud. This is described in readme

It's not an integration problem. The cloud does not allow the device to be added to the hub


Revert "fix(ci): RUN_E2E_TESTS is not false, but on, auto or true (#2…

…3362)"
This reverts commit 1b8fdf4.<!--

New contributors are highly encouraged to read our
CONTRIBUTING documentation.
Both Contributor and Reviewer Checklists are available at https://github.com/DataDog/datadog-agent/blob/main/docs/dev/contributing.md#pull-requests.
The pull request:

Should only fix one issue or add one feature at a time.
Must update the test suite for the relevant functionality.
Should pass all status checks before being reviewed or merged.

Commit titles should be prefixed with general area of pull request's change.
-->

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


FB Account Phishing URL

Came across a new one tonight; the first page that a user is directed to is cnnnewsonlinetogsdqq.wixsite.com/my-site-10 but clicking the fake video image redirects to this URL: dense1-madeindefense.ml/01jj/
URL root is fluff: dense1-madeindefense.ml
Not quite sure which host list to contact outside of StevenBlack hosts for the addition of dense1-madeindefense.ml as phishing.

Isn't better to block the root of the problem,aka cnnnewsonlinetogsdqq.wixsite.com ?
It's smells fishy just by reading it.

IMO both if user start new free wixsite or any other sended to Facebook posts/"sponsored" ads.


error CS7069: Reference to type 'DispatcherQueue' claims it is defined in 'Microsoft.WinUI', but it could not be found

Description
Compile error when using UITestMethodAttribute with MAUI preview 8 on VS 2022 preview 4.0
Steps to reproduce
Create a MAUI application from the VS template, modify App.xaml.cs and compile for Windows.
using Microsoft.Maui;
using Microsoft.UI.Xaml;
using Microsoft.VisualStudio.TestTools.UnitTesting.AppContainer;
using System;

namespace Test.DCF_UX.MSTest.Tests.WinUI
{
    public partial class App : MauiWinUIApplication
    {
        public App()
        {
            InitializeComponent();
        }

        protected override MauiApp CreateMauiApp() => MauiProgram.CreateMauiApp();

        protected override void OnLaunched(LaunchActivatedEventArgs args)
        {
            base.OnLaunched(args);
            Microsoft.Maui.Essentials.Platform.OnLaunched(args);

            Microsoft.VisualStudio.TestPlatform.TestExecutor.UnitTestClient.CreateDefaultUI();
            UITestMethodAttribute.DispatcherQueue = MainWindow.DispatcherQueue;
            Microsoft.VisualStudio.TestPlatform.TestExecutor.UnitTestClient.Run(Environment.CommandLine);
        }
    }
}

Expected behavior
Successful build. This compiled correctly in a prior preview of MAUI. It also ran the tests correctly from within VS (Run worked but Debug did not).
Actual behavior
2>C:\Users\Mike\source\repos\dcf_ux_832\src\Tests\Test.DCF_UX.MSTest.Tests\Platforms\Windows\App.xaml.cs(42,35,42,50):
error CS7069: Reference to type 'DispatcherQueue' claims it is defined in 'Microsoft.WinUI', but it could not be found
Environment
Windows 10.0.18362.0
VS 2022 preview 4.0
MSTest.TestAdapter version 2.2.7
MSTest.TestFramework version 2.2.7
Microsoft.TestPlatform.TestHost version 16.11.0
coverlet.collector version 3.1.0
Microsoft Maui preview 8

The problem also exists with testing WinUI 3. Please see the following link:
https://devblogs.microsoft.com/ifdef-windows/winui-desktop-unit-tests/

Hi,
DispatcherQueue is moved to Microsoft.UI.Dispatching namespace. You might want to check your references.


Allow Saving in UTF-* with BOM

Leaving aside all arguments about whether a Byte Order Marker is a good thing or a bad thing (I don't much care) there are situations in which software which will be reading the files produced by atom require it to be there. This should be an option in the encodings menu.
Further if a Byte Order Mark is present in a file, it should not be displayed (it currently is), and should be kept in its current state when saving a file (it can be deleted by an unknowing user who thinks it is an extra space, or mangled by auto-indent).

This is a duplicate of atom/encoding-selector#18. Please subscribe to that issue for updates.
Thanks for reporting!


add rustdocs to CI and publish to github pages

We should split files to avoid duplication and have small workflows requiring each other.
https://stackoverflow.com/questions/58139406/only-run-job-on-specific-branch-with-github-actions/69743847#69743847


Sdba add notebook xarray@master

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (minor / major / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?
A workaround for getting xarray to install from master without needing to introduce changes into several configurations files (tox.ini, .readthedocs.yml, potentially others). It's a workaround and depends on a subprocess call to system-installed pip. Seeing as the sdba utilities are available in<EMAIL_ADDRESS>this should be expunged from the code when it is made available.

Does this PR introduce a breaking change?
No.

Other information:

Pull Request Test Coverage Report for Build 2059

0 of 0   changed or added relevant lines in 0 files are covered.
490 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-14.0%) to 77.293%

Files with Coverage Reduction
New Missed Lines
%

xclim/sdba/init.py
6
45.45%

xclim/sdba/processing.py
46
0%

xclim/sdba/detrending.py
56
0%

xclim/sdba/base.py
102
0%

xclim/sdba/adjustment.py
134
0%

xclim/sdba/utils.py
146
0%

Totals

Change from base Build 2057:
-14.0%

Covered Lines:
2713

Relevant Lines:
3510

💛  - Coveralls

Cool hack, but finally with xarray 0.16 now released, we won't be needing it!

That's probably for the best!


Error configuring base job template

Configuring base job template with this command (source) is throwing errors in the latest version of prefect-worker:
helm install prefect-worker prefect/prefect-worker -f values.yaml --set-file worker.config.baseJobTemplate=base-job-template.json
Error: INSTALLATION FAILED: values don't meet the specifications of the schema(s) in the following chart(s): prefect-worker: - worker.config.baseJobTemplate: Invalid type. Expected: object, given: string
The command works for version 2024.4.4201250

hey @cchentola - thanks for raising this issue!
Apologies, there was an update to our values schema, where we nested the user-provided baseJobTemplate into an additional baseJobTemplate.configuration key after https://github.com/PrefectHQ/prefect-helm/pull/340, but did not update the docs accordingly
I've opened this PR to reflect this change here: https://github.com/PrefectHQ/prefect-helm/pull/368
to move past this, you can update your command line arg like so:
helm install prefect-worker prefect/prefect-worker -f values.yaml \
  --set-file worker.config.baseJobTemplate.configuration=base-job-template.json

Thanks for looking into this!


⚠ ClamAV has degraded performance

In 4482bd4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 73 ms

Resolved: ClamAV performance has improved in a5ba384.


Adding winston logger + cw transport support

:tada: This PR is included in version 1.68.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Question: How to use Slack threads?

How would I go about having the Slack bot respond in a Slack thread? I am familiar with the Slack API, but I'm not seeing a simple way to respond to a message in a thread.
Is that something that this simple-slack-bot framework is capable of doing?

I don't believe I ever worked with threads. What I would do is have your
bot listen in a channel for messages and send a thread message in that
channel.
Look at the payload that the Slack bot receives and feel free to share it
here.
I can see if we can make a few minor changes or improvements to handle
threads
On Thu, Apr 2, 2020, 4:04 PM Colten Krauter<EMAIL_ADDRESS>wrote:

How would I go about having the Slack bot respond in a Slack thread? I am
familiar with the Slack API, but I'm not seeing a simple way to respond to
a message in a thread.
Is that something that this simple-slack-bot framework is capable of doing?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GregHilston/Simple-Slack-Bot/issues/35, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAIFQCWVIDJLDXWUUOEIRTRKUDVFANCNFSM4L26Z7HA
.

Okay thanks, I'll take a look 👍

So, I may or may not get to this, but I am thinking that this codebase would become far more versatile if we could add support for threading and reactions (emojis).
My initial thoughts are that we could add thread support to the write function in this file. The end state, perhaps there is an optional function parameter for choosing to respond in the given thread. A boolean switch type of thing.
I am thinking that we could add a new function called react which would be very similar to the write function, but rather than posting messages in channels or threads, it would simply set (add or remove) Slack emojis to given messages.
I am looking into this further.
Basically, I want a library that supports this type of functionality which is very simple, such as the one you've written. I'm leaning towards contributing to your codebase rather than writing my own... because why recreate the wheel.
What are your thoughts @GregHilston?

@coltenkrauter let me start off by addressing your last part first:

I'm leaning towards contributing to your codebase rather than writing my own... because why recreate the wheel.

I am 100% down with you pull requesting any and all changes to this library if you want to avoid recreating the wheel. I can't promise you how much time I'll spend actively developing on this but I will look over every and all PR and provide help when I can.

My initial thoughts are that we could add thread support to the write function in this file. The end state, perhaps there is an optional function parameter for choosing to respond in the given thread. A boolean switch type of thing.

Sounds perfect to me.

I am thinking that we could add a new function called react which would be very similar to the write function, but rather than posting messages in channels or threads, it would simply set (add or remove) Slack emojis to given messages.

Also sounds perfect.
Let me see if I can get the project to run on my end and get back to you on these two topics above

@coltenkrauter I got the project running just fine on my end. I also merged all those pull requests AND remembered how to push the package up to pypi and did that.
The newest version is 1.3.2 and has been officially uploaded. Just so we don't forget, I put the commands in the Makefile.
So I think everything is a go to continue development!

BTW: Looked quickly into threads. it looks like a threaded message gets passed a thread_ts that links to the timestamp of the parent.
Parent:
received an event of type message and slack event {'client_msg_id': '6712d61e-4b18-4ad8-893e-3a481a5fb83a', 'suppress_notification': False, 'type': 'message', 'text': 'This is a test on a thread', 'user': 'U389
XUHT2', 'team': 'T38AP97Q9', 'blocks': [{'type': 'rich_text', 'block_id': 'UdV', 'elements': [{'type': 'rich_text_section', 'elements': [{'type': 'text', 'text': 'This is a test on a thread'}]}]}], 'thread_ts':
 '1585943493.003900', 'source_team': 'T38AP97Q9', 'user_team': 'T38AP97Q9', 'channel': 'C3FAX3UCV', 'event_ts': '1585943499.004000', 'ts': '1585943499.004000'}
received an event of type message and slack event {'type': 'message', 'subtype': 'message_replied', 'hidden': True, 'message': {'client_msg_id': '685721b0-affb-4b06-b480-85622cdd4ad9', 'type': 'message', 'text'
: 'This is a test of the base message', 'user': 'U389XUHT2', 'ts': '1585943493.003900', 'team': 'T38AP97Q9', 'blocks': [{'type': 'rich_text', 'block_id': '2/c', 'elements': [{'type': 'rich_text_section', 'eleme
nts': [{'type': 'text', 'text': 'This is a test of the base message'}]}]}], 'thread_ts': '1585943493.003900', 'reply_count': 2, 'reply_users_count': 1, 'latest_reply': '1585943501.004200', 'reply_users': ['U389
XUHT2']}, 'channel': 'C3FAX3UCV', 'event_ts': '1585943501.004300', 'ts': '1585943501.004300'}

thread message
received an event of type message and slack event {'client_msg_id': '4261a6b5-72c8-456d-a7c6-ebcef24b3efc', 'suppress_notification': False, 'type': 'message', 'text': 'ping', 'user': 'U389XUHT2', 'team': 'T38AP
97Q9', 'blocks': [{'type': 'rich_text', 'block_id': 'G=XwL', 'elements': [{'type': 'rich_text_section', 'elements': [{'type': 'text', 'text': 'ping'}]}]}], 'thread_ts': '1585943493.003900', 'source_team': 'T38A
P97Q9', 'user_team': 'T38AP97Q9', 'channel': 'C3FAX3UCV', 'event_ts': '1585943501.004200', 'ts': '1585943501.004200'}

Since simple slack bot uses slacker under the hood to interact with the Slack API, I quickly looked for how to reply to a thread and couldn't find a quick solution. I'll have to look later but please read above and let me know your thoughts

Great! I intend to contribute, but it may be a week or two before I submit a PR.

Take all the time you need! If you'd like to have more conversations feel free to reach out to me at
<EMAIL_ADDRESS>and we can keep some of the planning off of this Github issue. Your call.
Happy to be of any assistance

I'm open to that. Thanks! I'll touch base soon.

Update: I've been pretty busy... Not sure when I can get to this, but it is still my intention to contribute at some point.

Hey not a problem at all! Whenever you find time, feel free to reach out to me here and we can chat a bit about ways to approach.
No rush, just happy you're even still thinking about this project

@coltenkrauter Not poking you for any response on your part, but I'll be using this framework for a small side project in the near future. My plan is to discuss with you what I've learned and see what you think. I'll keep ya posted

@coltenkrauter
No worries at all mate! And it isn't for me but for the open source project :)
If I get some inspiration, I'll look into the request this weekend :) would love to have more people using it

@coltenkrauter Alright great news, was able to get this project to reply to channels this morning.
The current code is not pretty, so I'm going to spend a bit of time cleaning it up before I post a PR. I'd love if you reviewed the PR before we merge it.
I'm shelving reactions for now, just for time reasons, but can look at it in the future.
I'll bother you when a PR is posted

Sounds good, I'll review the PR 👍

Since most of this dialogue revolved around threads, I'm going to make a new one just for reactions to keep it easier for me to follow.


Update proc-macro-crate to 3.1.0

The old version caused a conflict with another crate that prevented me from compiling the code.
To prevent future conflicts, it would make sense to only define the major version (minor and patch should not break code version updates):
[dependencies]
-syn = { version = "2.0.48", features = ["extra-traits", "parsing"] }
+syn = { version = "2", features = ["extra-traits", "parsing"] }
quote = "1"
proc-macro2 = "1"
-proc-macro-crate = "3.1.0"
+proc-macro-crate = "3"

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Can Anyone run success this project?

I think the author has not double check the repo. Many error and missing file in this repo. If someone has  sucess run  it, please let me know

yeah, it will need to comment some parts for missing file and i changed some setting in opt file so it can run on my single 1070

Hi @John1231983
I also successfully run the code. Probably this note can be useful:
1. Remark all mobilenetv2 import (there are three files, find using "find in file" option on visual code)

2. Make sure all paths are correct, including "data_root" at init_dataloader.py, weights paths at resnet_caffe_*.py, and etc.

3. Remark this part on "trainer.py":
   """ self.visdom_log_file = os.path.join(self.opt.out_path, 'log_files', 'visdom.log')
   self.vis = Visdom(port = opt.visdom_port,
   log_to_filename=self.visdom_log_file,
   env=opt.exp_name + '_' + str(opt.fold))
   ```
    self.vis_loss_opts = {'xlabel': 'epoch',
                          'ylabel': 'loss',
                          'title':'losses',
                          'legend': ['train_loss', 'val_loss']}

    self.vis_tpr_opts = {'xlabel': 'epoch',
                          'ylabel': 'tpr',
                          'title':'val_tpr',
                          'legend': ['tpr@fpr10-2', 'tpr@fpr10-3', 'tpr@fpr10-4']}

    self.vis_epochloss_opts = {'xlabel': 'epoch',
                          'ylabel': 'loss',
                          'title':'epoch_losses',
                          'legend': ['train_loss', 'val_loss']} """
   ```

4. Don't forget to download the model*.pth from CASIA-SURF dataset, and put on the corresponding folder as shown on point 5 (pth path).

5. I run the val script as follows:

python inference.py --config /home/face-spoofing/ChaLearn_liveness_challenge/data/opts/exp1_2stage_seed1/exp1_2stage_seed1_fold1_stage1.opt --pth /home/face-spoofing/ChaLearn_liveness_challenge/data/opts/exp1_2stage_seed1/fold1/checkpoints/model_30.pth --input_list /home/face-spoofing/ChaLearn_liveness_challenge/data/lists/folds_by_fakes/fold1/val_list.txt --output_list /home/face-spoofing/ChaLearn_liveness_challenge/output.txt
Cheers!

Hi,
I found the links for exp1_2stage and exp3c on google drive to be broken. Can the author check and fix the broken links?

@AlexanderParkin
Hi,
I found the links for exp1_2stage and exp3c on google drive to be broken. Can the author check and fix the broken links?

Hello, download the model in the fourth article you wrote. Where did you download the model? could you tell me the specific path? @mrkstt

Hi, could you please kindly tell me where I can find "the model*.pth from CASIA-SURF dataset" as you mentioned? @mrkstt I cannot locate it anywhere within CASIA-SURF dataset, or I am missing something here...

I think the authors removed the .pth model file. If you're interested, please drop an email to me<EMAIL_ADDRESS>@cakuba @zhangxiaopang88
Thanks and sorry for the late reply.


Display current location on Map #3 Subtask 3

Call ViewerAPI.move() with calculated coordinates for a point in the direction user is currently facing.
For this calculation current location and currently facing direction from subtask 2 is used.

#3


Removing the Webspace mention from the documentation

Webspace mentioned in the documentation is confusing the customers as it is an internal implementation detail and causes a lot of issues as we do not surface it anywhere on our portal. Nowhere in our documentation, we should be mentioning the word WebSpace.

@Chibionos,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@Chibionos : Thanks for your contribution to the Azure documentation! The author, @btardif, has been notified to review your proposed change.

#please-close

Why close? @SyntaxC4 are you planning to make the change later?


Add 'tvOS' platform to jenkinsJobType

Add the 'tvOS' platform to jenkinsJobType to correctly display AppleTV tests

We already have appletv and androidtv platform icons available, maybe you could use appletv as platform? This way you'll have icon and tvos tests won't be confused with androidtv tests.

Shifted to appletv usage


http: added a new dual header mutation filter that could be used as downstream/upstream filter

Commit Message: http: added a new dual header mutation filter that could be used as downstream/upstream filter
Additional Description:
Check #24100 for more detailed context.
Risk Level: low. new L7 extension.
Testing: unit.
Docs Changes: added.
Release Notes: added.
Platform Specific Features: n/a.

cc @alyssawilk here is the pr for #24100. This PR is consist of three commits.
The first commit added a new HeaderEvaluator implementation to the common/http. The second PR refactor previous early_header_mutation to use the new implementation in the common/http. The final commit create a new L7 filter.

/assign-from @envoyproxy/api-shepherds

/coverage

LGTM modulo comment, thanks, this is really nice.


Add test works out of streamlit

Codecov Report

Merging #2 (197e191) into main (bc29607) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           39        39
=========================================
  Hits            39        39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc29607...197e191. Read the comment docs.


Convert Quest providers plugins to use pkgutil namespaces rather than stevedore

Convert what are currently Quest service plugins that are loaded with stevedore and registered in the setup.cfg, to be loaded in through the quest_providers name space (see https://packaging.python.org/guides/packaging-namespace-packages/).  This will allow plugins to be added without needed to modify the setup.cfg and reinstalling quest, and to install plugins as separate packages and still be loaded into quest at runtime.


linux ubuntu

i keep getting error 404 not found when i try to install this bot help pls ?
think your server link died

Did you start with
git clone https://github.com/Just-Some-Bots/MusicBot
??


cbqn: add replxx option

Description of changes

A new nifty feature was added to CBQN recently. So added it as a build option and enabled by default.

Both the online REPL and the REPLXX build of CBQN (make REPLXX=1) support backslash input with no configuration required.

BQN/editors at master · mlochbaum/BQN

catch up to the latest version.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@shnarazk please rebase and fix.

@AndersonTorres
sorry, I've just fixed.


Couple of fixes

These were useful to get this plugin working on my setup and to not have warnings on install. Hope this helps!

Thanks @panozzaj!

@panozzaj I've updated your changes and release 0.0.2!

:fireworks: for open source. :) Thanks!


It's not working after update to version 2

[x] Your Hyper.app version is 2.0.0. Please verify your using the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

Any relevant information from devtools? (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):

Is the issue reproducible in vanilla Hyper.app?

Issue

Hyper version: undefined "2.0.0"

OS ARCH VERSION: darwin x64 17.4.0

Electron: 1.8.4  LANG: undefined

SHELL: /usr/local/bin/zsh   TERM: undefined

 ~/.hyper.js contents

          {
  "updateChannel": "stable",
  "fontSize": 12,
  "fontFamily": "Menlo, \"DejaVu Sans Mono\", Consolas, \"Lucida Console\", monospace",
  "cursorColor": "#6BC6F9",
  "cursorShape": "UNDERLINE",
  "cursorBlink": false,
  "foregroundColor": "#fff",
  "backgroundColor": "#000",
  "borderColor": "#333",
  "css": "",
  "termCSS": "",
  "showHamburgerMenu": "",
  "showWindowControls": "",
  "padding": "12px 14px",
  "colors": {
    "black": "#000000",
    "red": "#ff0000",
    "green": "#33ff00",
    "yellow": "#ffff00",
    "blue": "#0066ff",
    "magenta": "#cc00ff",
    "cyan": "#00ffff",
    "white": "#d0d0d0",
    "lightBlack": "#808080",
    "lightRed": "#ff0000",
    "lightGreen": "#33ff00",
    "lightYellow": "#ffff00",
    "lightBlue": "#0066ff",
    "lightMagenta": "#cc00ff",
    "lightCyan": "#00ffff",
    "lightWhite": "#ffffff"
  },
  "shell": "",
  "shellArgs": [
    "--login"
  ],
  "env": {},
  "bell": "SOUND",
  "copyOnSelect": false
}
      {

"plugins": [
"hyper-snazzy",
"hyperborder",
"hyper-blink",
"gitrocket",
"hyper-confirm"
],
"localPlugins": []
}

@ppamorim  it was exactly this plugin, yes!

Yes, I hope so. Thanks for your answers. I close this issue.

@chabou, I'm trying to debug why Hyperborder no longer works. Is there a plugin migration guide? Judging by the info on http://hyper.is, the plugin should still work.
When debugging into the Hyperborder code, I see that decorateConfig(config) is now never called by Hyper. Is this an expected API change? That's where the crux of the Hyperborder logic lives.

I am pretty sure than decorateConfig is working. Most of the themes are using this to set their colors.
There are some good recipes here: https://github.com/zeit/hyper/blob/canary/PLUGINS.md
From what I saw, your css is broken.


Make compatible with gulp-sourcemaps?

What about making this compatible with gulp-sourcemaps so a sourcemap with original source files can be generated?

Nice question! I need this!


Old export format.

Please allow us to export using the old export format.
Some of us keep track of our permissions changes via github, and the old format made this absolutely beautiful when it comes to debugging recent changes, issues and problems.
The new JSON format unfortunately, as much as I understand it's the new system, simply is very difficult to use with our tracking systems.
Example: https://i.imgur.com/TGd8M68.png
Please allow a command syntax to export using the old format <3
This would be absolutely amazing!

I don't really think there would be any real need to add any more support for the old export format.
The new one is more compact and allows LP to handle all the actions for the import slightly faster (from what I know)
Right now does LP have support to import exported files from v4, but I don't think there will be anything more to that.

This suggestion is simply for exporting in the old format for maintenance reasons, nothing to do with importing from it / supporting it.
I'm a simple syntax could be added for those of us who wish to examine an old export style file.

You can track changes in the same way with the new json based format.
It's a .json.gz file, which you can extract using 7zip to get just .json - then changes should be easily readable / identifiable in that file.

Yeah no no I kno, it's just more readable and pretty in the old format :(

JSON is most definitely a readable format!
Sorry it's not really worth re-adding this just for this reason. The code to generate commands based on nodes wasn't very nice, which was one of the reasons for moving away from this system in the first place.

No worries, had to try lol <3


ParseableInterface: / is not part of the SDK on Windows

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - d894d3c31712c289727450ad1ae27e9c3e5b3775

Build failed
Swift Test OS X Platform
Git Sha - d894d3c31712c289727450ad1ae27e9c3e5b3775

@swift-ci please test

@swift-ci please test


Retry email jobs when we receive an EOFError

Every now and again the SES SMTP gives an EOFError for a variety of reasons. When this happens we should just retry the job.

Good idea.


Send proper Transform position to the player's entity

currently y = .88 is being sent (due to some transform offset), while it should be y = 0 (while standing on the floor)
we should check if we could use the following data for the player position
https://github.com/decentraland/unity-renderer/blob/dev/unity-renderer/Assets/Scripts/MainScripts/DCL/DataStore/DataStore_Player.cs#L10
more relevant info: kernel is already taking into account that offset
https://github.com/decentraland/unity-renderer/blob/dev/browser-interface/packages/shared/world/positionThings.ts#L54-L55
no idea where that .88 comes from 🤷♂

FYI > AvatarAttach component is affected by this behavior also


CAMEL-19058: wrap some internal properties in an EnumMap

This should make it simpler to abstract their complexity while maintaining reasonable performance (as they are used in many parts within the hot path)

This is the alternative implementation for #9982

Yeah JDK classes are good to prefer to use when they fit the purpose - map optimized internally with quick object array, and lookup by ordinal fixed number (like the old code)


Debate auto-scheduler

We need to put together some functions for automatically scheduling debates.
A spec for a first function we need has been added in the debate-scheduler branch. See here.
After this we'll need a hook to use it in the interface.

Thoughts:

There are a lot "costs" that we want to minimize — imbalance between debaters, judges judging the same story multiple times, etc.
We will need to trade off these costs with each other, so it makes sense to explicitly compute them and combine them together into a single function on entire outputs (i.e., sets of assignments).

In theory we want to produce outputs which minimize this cost function... BUT,

This is probably intractable to compute, and
We don't want the output to be perfectly predictable anyway, as people shouldn't be able to guess who they're debating / who's honest/dishonest based on previous history.

So instead of minimizing the cost function, we can use the cost function to define a distribution over outputs which favors lower-cost outputs, and sample from that distribution. Distributions defined in this way (monotonic with a cost function summed from several possibly-independent components) can be defined using factor graphs.
The simplest way to do this is probably via a softmax distribution based on the cost function (i.e., exponentiate and normalize), which corresponds to a conditional random field. If the nodes in the graph are independent, then sampling is easy because their values can be sampled in sequence. So you can cast the whole problem as one of sampling subparts from intermediate distributions based on cost functions.
For example:

First, sample a split of debaters/judges
Then, sample individual assignments in sequence

Or something like that.

Discussed with @julianmichael.
We're going to punt on factor graphs for now. The scale of the problem [1] implies that it's tractable to solve it directly by enumerating all possible assignments and picking the one with the lowest cost.
[1]: 10-15 debaters, scheduled in advance for 10-15 debates. (TBD what the # of stories is.)


Github actions migration

Travis CI has been disabled for the org, so we should switch to github actions in order to test PRs and auto-publish updates.

Hmm wait a moment, github actions is still enabled. https://travis-ci.org/github/RustAudio/rodio

Dupe of #358


Add config.yml to restrict creation of blank issues

Description
In scope of this pull request we add config.yml in ISSUE_TEMPLATE to restrict creation of blank issues.

config.yml: https://docs.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository#configuring-the-template-chooser

Related issue: https://github.com/actions/virtual-environments-internal/issues/1700
Check list

[x] Related issue / work item is attached
[x] Tests are written (if applicable)
[x] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

@dmitry-shibanov , May be we can also disable this step?
https://github.com/actions/virtual-environments/blob/main/.github/workflows/issue-triager.yml#L23


Displayed signature of function with *args has extra *

This is related to #91 and #102.
For functions that have *args, there is an extra * in the displayed signature. For example, https://shiny.rstudio.com/py/api/ui.nav.html

The actual signature is (https://github.com/rstudio/py-shiny/blob/95124eec149b691e2f4166086cb2f2ff3b8a51a7/shiny/ui/_navs.py#L90-L96):
def nav(
    title: TagChild,
    *args: TagChild,
    value: Optional[str] = None,
    icon: TagChild = None,
) -> Nav:

Ah, thanks! I'm going over the different signature cases again. Are there any you would add to this list?
def pos_only(x, /, a, b=2): ...

def kw_only(x, *, a, b=2): ...

def early_args(x, *args, a, b=2, **kwargs): ...

def late_args(x, a, b=2, *args, **kwargs): ...

Just a random note for posterity, sometimes people are weirded out that the star is not in the AST, but this is also how python represents it...
import ast

tree = ast.parse("""
def f(a, *, b): ...
"""
)

ast.dump(tree.body[0])

FunctionDef(
    name='f',

    # note how the arg representation is very similar to griffe ----
    args=arguments(posonlyargs=[], args=[arg(arg='a')], kwonlyargs=[arg(arg='b')], kw_defaults=[None], defaults=[]),

    body=[Expr(value=Constant(value=Ellipsis))],
    decorator_list=[]
)

With a signature like the following:
def nav(
    title: TagChild,
    *args: TagChild,
    value: Optional[str] = None,
    icon: TagChild = None,
) -> Nav:

...it makes sense that Python automatically considers value and icon to be keyword-only parameters, since positional ones will be eaten by *args, so you cannot ever pass value or icon with positional arguments, only keyword ones.