ERC20 Problem when used as an offer (Problem with latest seaport-js version)

const { executeAllActions } = await seaport.createOrder(
{
	offer: [
		// buyer's offer
		{
			token: '0xc1d6ef502ac5410b3f3706beb6a0808131337fb6',
			amount: offerPrice,
		}
	],
	consideration: [
		// buyer's ask
		{
			itemType: ItemType.ERC721,
			token: smartContractAddress,
			identifier: tokenID,
			recipient: address, // recipient for token is the buyer
		},
	],
},
address
)

I recently updated my @opensea/seaport-js to the latest version and now my code doesn't work.
Using this block of code to try and create an offer for some NFT. Thing is, when I put my token in the offer, a Metamask error pops up, indicating "Invalid token value; should be exactly 64 hex digits long (u256)".
If I change the offer to properties that represent an ERC721 token, it works totally fine.
Also, removing token property from the object in offer array, it pushes through.
I need to be able to indicate which ERC20 token address I want as an offer, but it isn't working.
Hope to get some help!

You can manually approve the ERC20 token to the seaport contract, and then execute the createOrder function.

This should be resolved now with v1.2.1


Remove lodash from tests

Extracted from https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1242
🚀 Description

[+] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[+] ✅ I've added tests where applicable to test my new functionality.
[+] 📖 I've made sure that my contracts are well-documented.
[+] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:fix).

Thanks for fast reviews!
Lodash is not declared in package.json explicitly. It is a dependency of babel, eslint, etc.
The Travis build has been terminated. That's weird a little bit, as "unit tests with coverage" in the same build are fine.

Looks like mocha didn't exist because of an unresolved promise. I'm going to restart to build and see if it was a fluke, but it might be helpful to run  https://github.com/mafintosh/why-is-node-running to figure out what promise isn't resolving


Add filtered dataset by Formal Camps only with links to general infrastructure PDFs

Awesome, this will be helpful


s3_auth_v4: update default region map

Update the default region mapping based on the latest changes in AWS Regions and Endpoints document
May be if one day AWS naming/mapping becomes 100% consistent we could just extract / calculate the right region from hostname.
The default region mapping can be overridden by using --v4-region-map parameter (more info in the s3 plugin docs).

This looks like a candidate for 7.1.x as well.


HMR doesnt reload globals

When I have globals like globals: { default: 'some' } and HMR enabled and then modify the code, the HMR charge the modules but the globals are still in the past version

HI! HMR works only on "default" project. Make sure to change the package when actually packaging. We could tweak it of course.

Closing it for now, re-open elsewise.


Export image from Skia View

Description
Can u create export image feature?
Ex: After change image SVG by color matrix, blur, ... I want to save that

Hey, there is already a makeImageSnapshot feature. It's documented here: https://shopify.github.io/react-native-skia/docs/canvas/overview#getting-a-canvas-snapshot


Pass capabilities to Firefox

Issue
#200

Description of the Change
I passed capabilities variable set in pylenium.json to Firefox webdriver, like done in IE and Edge.

Alternate Designs
I did not consider other alternates as this method was already used by IE and Edge.

Possible Drawbacks
For anybody calling Browser build_firefox method directly, he will have to add capabilities argument.

Verification Process
I checked the new functionnality with another project and the example of #200, the calendar file is downloaded directly.

Release Notes
Passed pylenium.json capabilities variable to Firefox

@ElSnoMan is it possible to release a new version with this feature ?


Event list generator: Make it consistent with the UI

Right now, the event list has the following format:

Directly from a Google Cloud source

Cloud Storage

google.cloud.storage.object.v1.archived

Using Cloud Audit Logs

Cloud Storage

storage.buckets.create

Using Pub/Sub
Using third-party sources

On the other hand, the Google Cloud console has the following format:

First-party

Cloud Storage

Direct

google.cloud.storage.object.v1.archived

via Cloud Audit Logs

storage.buckets.create

Custom
Third-party

I like the latter as it's always event source -> event medium -> event and there's a single place to look for each event source (eg. Cloud Storage). Should we consider changing our event list format to match the UI?

Yes, I'm fine with this and think it's a good idea to be in sync with the console. Note that we're not supposed to use "via" in the docs so unless the console can change, we'll work around that in any related pages or content.

Hi @camiekim, I looked into this and it's actually more involved than I thought. I'll park it for now but let me know if you think it's important to match the format of docs with the console and I'll spend more time on it.

Ok.

I'm closing this as Won't Fix


Should provide git hooks for good developer environment.

Especially, we should run 'lint' command whenever developer commits his/her patch locally.
But how can we provide them smoothly? The git hook files should be located in .git/hooks/ but it's an untracked path. So, we probably should provide them in our repo and then copy them into the git hook directory when developer runs 'absolute' command at first.

https://github.com/romandev/absolute/pull/92


PR for Modern C++ Course

Add self (frag-o-matic) to mentor's list
Add Curriculum for Modern C++

Thanks! Merged.
:beers:

great :+1:


The Canvas bounds.contains check has the canvas position as offset

Is there an existing issue for this?

[X] I have searched the existing issues.

Is this issue related to iced?

[X] My hardware is compatible and my graphics drivers are up-to-date.

What happened?
If the canvas top-left does not coincide with the window top-left then the check interprets the point as if it lived in the window frame of reference, not the canvas frame of reference.
SSCCE: See the Canvas Coordinate example in my iced playground.
What is the expected behavior?
The bounds.contains check should evaluate to true for all coordinates within the canvas.
Version
crates.io release
Operating System
Linux
Do you have any log output?
No response

Here's a screenshot:

The issue persists with the current master branch of iced.

Frame coordinates are relative. The bounds provided in draw are absolute.
The user needs to convert accordingly.


SceneVariableSet: Do not propagate variable value changes when a local variable has the same name

Part of row repeat fixes https://github.com/grafana/grafana/pull/87539
So we have this problem in row repeats that when the variable changes (that you repeat by). All the panel query runners inside all the repeated rows were notified that their variable dependency changed and started issuing a new queries (even when their local value did not change) .
So figured that this notification (via variableDependency) should not happen if there is a local SceneVariableSet with a local variable of the same name.
Created a test case for this scenario all is fine. This logic make sense, the variable has not changed for the local scope (as there is a local variable with the same name that has not changed).
The only really hard puzzle piece to solve is that his completely breaks the RowRepeatBehavior in core as it relies on this notification to process repeats.
So the problem here is that the first row (which we use as template / source of repeats) also get's a locally scoped value (the first variable value), so after the first repeat process this local value on the first row will block any updates the variable, which logically is correct the local value is not changing. ARHHHHfasFASDSDASFA S FQ"!° going to go for a walk.
Think the only solution is to the notification of variable changes from the behavior itself to the dashboard scene, this is now done in https://github.com/grafana/grafana/pull/87539

Think we need to wait with merging this and coordinate with https://github.com/grafana/grafana/pull/87539 ?

@dprokop yes, good point. Will wait merging this until that one is approved and ready to merge


Expose Slivka version

/version endpoint can be used to test connection and check the version.
Compatible version should also be added to distributed project instances and Slivka might refuse to start if it mismatches.
Client versioning can help to spot version mismatches beforehead as well.

Instead of checking Slivka version, the client should check API version. Server should be backwards compatible as long as major API version remains unchanged.


[Stable] Fix removed method from networkx

Summary
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0%) to 91.44%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4294

Relevant Lines:
4696

💛  - Coveralls


Include Email from Login in Feedback Form

When the user is logged in, do not prompt the user for an email in the feedback form. Use the email associated with the logged in account.

There are three cases to consider:

Per Allan not all User ID's are tied to an email address
Feedback submitted via the app can currently be anonymous. Would the user have to log out in order to submit the form anonymously?
The user may want to enter a different email address than that tied to their AD User ID, like a gmail account for example. Would we want to provide a way to the user override their AD email address?

@a6wu @woznaut sending this your way for review

This issue is being closed due to platform migration and may be revisited at a later date.


Investigate / Ensure sane logic for acks on data

This relates to the WAL and general acking of messages for sources that handle this.
We need to ensure we keep track of 2 things:

the last message sent
the last message acked

it opens a few concearns:
When getting a failure that is concerns a message that was already acked, what is the behaviour? Should that be an error? Is that possible? How can we prevent it?
When getting an ack for a message we consider not sent, what is the behaviour? Should we ignore it? should we consider it and all messages before it as acked? Should we error?
from #581
Wouldn't we need to fail the remaining messages at this point?
-- edit --
Or are messages in order and message.id is always < (message+1).id in which case we would always revert to the lowest here.
If so this opens a different problem that if we fail X and ack X+1 then x+1 would un-fail x (which might be a bug in the GD/wal code if we do I think?)
-- edit2 --
If they are in order we might not need to ack / fail any further messages since they'll be re-send anyway or am I missing something?
-- edit3 --
those changes are outside of the scope of this I'm just writing my mind down before I forget by tomorrow - one of those days ...

We have this defined now


SessionID

self.SessionId = str(uuid.uuid4()) in streamer.py
I am certainly no good at Python, so please take that in consideration:
Writing to the same bucket is possible (according to a recent webinar) if you use the same SessionId.
Looking at the code, it seems like specifying a SessionId will be pointless as the code just generates a new one...

@louisza I'm excited to let you know that version 0.0.25 was officially released and should fix your issue completely!
Now, all you have to do is specify the same bucket_key in the constructor of the Streamer like this:
streamer = Streamer(bucket_name="louisza's bucket", bucket_key="reference_key", access_key="[AccessKey]")

I'm going to close this enhancement as finished. But feel free to reach out if you have any more questions!
Thanks,
David


Add quick gralloc4 to gralloc1 handle conversion

Temp solution for gralloc4 to gralloc1 conversion. In future, we should use gralloc4 mapper to get the common metadata needed by client.

one of the dependent pr's program name is not compatable with other dependent prs, for more details please check tracked_on

one of the dependent pr's program name is not compatable with other dependent prs, for more details please check tracked_on


[libra framework] Update some transaction docs

Updates transaction docs to include missing error categories that were found during verification.

/land

:lock: Merge Conflict

/land

:boom: Tests timed-out

/land


You can now make selections on the modal

Issues to address:

I have forced it to stop overlap. perhaps this can be changed to create a merge
currently, it acknowledges events as time blocks, so if you delete it it deletes the entire thing, unlike with when2meet where you can delete sections. not sure if this is better or worse

Another issue to address is the close button overlaps with the calendar. we may need to give the calendar some margin


Run pulsar-functions as daemon process

Motivation
Now, I can't run pulsar-functions worker as daemon process.
Modifications
Support functions-worker command in pulsar-daemon script.

retest this please


Programatically Set the Location Picker

Love the plugin, I'm having an issue attempting to programmatically set the map location.
This questions has been asked a few times without an answer:
http://stackoverflow.com/questions/31631777/logicify-location-picker-using-dynamic-change-for-input
https://github.com/Logicify/jquery-locationpicker-plugin/issues/20
Essentially I would assume that I could programmatically set the values of latitude and/or longitude and the plugin would respond as if I had typed those values in (through the inputBinding latitude and longitude 'on('change' functions). However it doesn't.
I've tried various attempts at calling .locationpicker() after resetting the values or .trigger() on the values themselves. I'm not sure how to proceed if I can't get the inputBindings to fire.
Can anyone steer me in a direction to get the inputBinding functions to pick up on programmatically setting the lat and long?

Having the same question

@matthew-davis and @lem93 hi! You can set location with help of simulation events. Just write something like this
<button id="doIT">Do IT</button>
<script>
    $('#us3').locationpicker({
        inputBinding: {
            latitudeInput: $('#us3-lat'),
            longitudeInput: $('#us3-lon'),
        }
    });
    $('#doIT').on('click', function (e) {
        e.type = 'change';
        $('#us3-lat').val(-5.087353864895619).trigger(e);
        $('#us3-lon').val(112.17068155859374).trigger(e);
    })
</script>

I hope it help you.


Make ssh host optional again in vm-test

fixes https://github.com/nix-community/nixos-anywhere/issues/375

@mergify queue

@mergify queue


make simulated data from the absolute paper model

the task is to make up some purity/ploidy values and simulate data from it. we will use this data during the development of the tool.

Wrote some python code to simulate tumor phylogenies and CR/MAF profiles.


Can you upload a pre-trained model?

Thanks a lot for releasing the code of Meta-rPPG paper!
I understand that due to privacy issue, it is hard to get your training dataset. But can you provide a pre-trained model? This will help me a lot!

+1

Pre-trained model will be uploaded shortly. Thank you for your patience.

Hello, Can you please share custom dataset template file? You mentioned that it is uploaded but I did not find it.

Pre-trained model will be uploaded shortly. Thank you for your patience.

Hello~Have you uploaded the pre-trained model yet? It will help me a lot. Thanks!

Any news?

Any update？@eugenelet

Hi,
Thanks so much for the work.
Is there any updates on uploading the pre-trained model?

@eugenelet Any update about this? Would be really helpful to have access to your model.
Great work by the way!

@eugenelet  pretrained model

@eugenelet Great work, however can we get access to your pretrained model?


Correct way to initialise request context

I would like to use async hooks provided by Node.js to implement request context (having context without manually passing it everywhere). I saw some implementations using middleware to initialise request context:
const contextMiddleware = (req, res, next) => {
  // initialize request context
  const cxt = asyncContext.create({ parent: asyncHooks.executionAsyncId() });
  // take Request ID from request headers and store it into context
  cxt.set("request-id", req.get("X-Request-Id"))

  next();
};

This code says that async resource executing middleware code is parent of request context. So any code invoked by this async resource is going to share the same request context.
This approach works until you use something like morgan to log request which uses on-finished under the hood. Where code is executed outside of our request context so metadata such as Request ID aren't available within logs produced by morgan.
Is there any other better place to initialise request context other than within middleware to capture entire request lifecycle (including executing of on-finished)? Or would be using
const cxt = asyncContext.create({ parent: asyncHooks.triggerAsyncId() });

instead within middleware viable solution? Saying that root of request context is parent of resource executing middleware code (isn't parent resource reused among multiple requests? As it would cause leaking of request context among different requests)
I would be glad for any feedback. Thank you!

Use something like morgan to log request which uses on-finished under the hood. Then such logging is executed outside of our request context so metadata such as Request ID aren't available.

Hello! I'm not familiar with that the async context is, I'm sorry. At a high level it should be the same way in which you would do so for the native Node.js HTTP server (since that is what is under the hood here). But perhaps would it be possible to provide a full example code we can run to observe the issue? That would help us understand what is going on and perhaps what a solution is.

waiting on code sample, closing until it arrives.


move vendor scripts to helper

there are several places in the views where we are including vendor scripts, via:

create a helper with the checks in the app_config to render or not the partial
render the partial with the check in the view

all vendor partials should be rendered via helper, however there are still some in the views, also duplicate checks in the helper AND in the partial (analytics), so:

[ ] remove checks from partials
[ ] move vendor scripts to helper

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Installed Version does not work

I have checked out the latest version from the development branch (8b8162c1a943282bdcf9747ecfa6bff39af53e15) and did a "python3 setup.py install --user"
When I then try to load the module, I receive an error:
Python 3.4.3 (default, Jun 29 2015, 12:16:01)
[GCC 5.1.1 20150618 (Red Hat 5.1.1-4)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import escpos.printer as printer
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ch/mnt/raspberrypi/python-escpos/escpos/__init__.py", line 1, in <module>
    import constants
ImportError: No module named 'constants'
>>> import escpos
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ch/mnt/raspberrypi/python-escpos/escpos/__init__.py", line 1, in <module>
    import constants
ImportError: No module named 'constants'

I can fix it with the attached patch.
escpos_import.txt
I am unsure if that is the right way to do... The the import in the __init__.py even needed?

I think we do not need to import everything with the module. In #94 I have done it similar to your patch, but I am not sure if we even have to import printer. (I think it is simply for convenience)
Since printer is the only interface that is relevant to the user importing more makes no sense for me.
One small thing: I think you should cd somewhere else than your source directory. It seems to me that your python tries to importfrom there and not from the installed packages.

@patkan The error is always persistent, even cd to an other directory:
Python 3.4.2 (default, Oct 19 2014, 13:31:11)
[GCC 4.9.1] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import escpos
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ch/.local/lib/python3.4/site-packages/python_escpos-1.0.9_dev-py3.4.egg/escpos/__init__.py", line 1, in <module>
ImportError: No module named 'constants'
>>>

@braveheuel Yeah this was just a remark on the side. You are right, the way the init.py imports the rest of the package might have been ok in Python 2 but definitely isn't in Python 3. The question is, whether we should completely remove the imports from init.py and regarding this I am unsure.

As far as I understand the documentation (https://docs.python.org/3.4/tutorial/modules.html#packages) the __init__.py only acts as initialization. We for now don't initialize something. The __all__ magic word is needed for the "*" import.
So I think we are fine with removing all imports and keep the __all__.
Additionally: I should try out #97 as it supersedes this.

I just compared both behaviours:
with from . import printer
>>> import escpos
>>> p = escpos.printer.Serial("/dev/ttyUSB0")
Serial printer enabled

without  from . import printer
>>> import escpos
>>> p = escpos.printer.Serial("/dev/ttyUSB0")
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-2-0e0d19e40688> in <module>()
----> 1 p = escpos.printer.Serial("/dev/ttyUSB0")

AttributeError: 'module' object has no attribute 'printer'

So it depends on whether we want to give users the ability to use import escpos or whether they have to use import escpos.printer.
For me it would be ok to remove the import.

Ok, with the import line you don't have to explicitly import espos.printer, but you nevertheless need to use "escpos.printer.Serial" etc.
I am also ok with removing the line.

OK, I will commit a fix and then rebase the branch of my Pull request #94 onto this new commit.

As this is fixed in the PR #94 I will close this error.


Is there a way to restrict installing abandon libraries because of security issue?

We have a few packages in Drupal that are unsupported because of security issues(e.g. https://www.drupal.org/sa-contrib-2019-006). Is there a way to not allow to install (any version) them?

I think this might be outside the scope of this project.
Composer offers a way to mark projects as abandoned - it's up to Drupal to provide this information in their Composer repositories. Assuming they do this (they should, but I don't actually know if they do) then you should be seeing warnings in Composer's output similar to this:

That won't prevent installation though - you'll probably need to find or create a plugin to help automate that for you.

Thanks @colinodell I will check.

See also #319 for a bit of discussion on what to do when there's a known security issue with no fixed version.


OGGM slack guide

This PR includes an updated version of the welcome to the OGGM slack blog post. Feel free to edit it.

Thanks!


[WIP] Variant bitset

Bitset using union for block access

Coverage increased (+0.6%) to 84.025% when pulling 01969581e707a2c23344d5555b00be9ec7e55d2b on variant-bitset into eeda074d722fab53f3c7b26c329a199150d77edf on master.


Default to --squircle-smooth: 1

Only adding mask: paint(squircle) gives a quite interesting result, but perhaps not what folks expect for squircles:

Defaulting --squircle-smooth: 1 though, looks more like what I’d expect:

This seems to be documented as defaulting to 1, but I’m not seeing that? 🤔

@wooorm good idea. I'll check it

Sweet!
My guess is that:

this line evaluates undefined * 10 to NaN
resulting in this condition passing
resulting in NaN being returned here

Updated<EMAIL_ADDRESS>


Labor participation in events

We need to handle Labor participation in events. There is not a firm conclusion as to how. We could handle it at the event level, with a Labor/Non-Labor toggle, either exclusive or not (resulting in two separate events if labor students need to be recorded), or at the hours level, with each volunteer getting a Labor checkbox to indicate whether or not the hours ‘count’ towards service totals (or a Service checkbox that defaults to true on service events, showing whether the hours should be on service transcript). The latter option would be the most flexible but result in a number of changes to places where we show service hours. We could also have a separate place in the UI for labor students, as they are not really ‘volunteers’, and then handle the management of a service or labor flag on the backend. As an example of the problem, the Better Together and Empty Bowls events have both labor students working and student volunteers who are getting service hours, so we would either need two separate events for each (a labor and nonlabor), or one event but track labor and service hours separately. Another option could be having Labor as a program that is available only for labor students.

 Labor participation in events


[Bug] SSL install error on mac

Getting this error today while trying to install on my Mac. Anyone getting an ssl error?
$ python -m pip install --pre -U -f https://mlc.ai/wheels mlc-ai-nightly
Looking in links: https://mlc.ai/wheels
Requirement already satisfied: mlc-ai-nightly in /Users/mstack/.local/lib/python3.11/site-packages (0.15.dev404)
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1006)'))': /wheels

Might happen if you are using a proxy. Please check your proxy settings are correct


Remove NULs byte arrays passed to PostProcess

PostProcess is supposed to be parsing and handling HTML
fragments, but on fuzzing it appears that there is a weird
issue with NUL elements that could cause a memory address
error in downstream libraries.
The simplest solution is to strip out the weird NULs - they
should not be there in any case and would be stripped out
anyway.
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

No offense and I don't know Golang but is there not a stdlib function to do this?

Would bytes.ReplaceAll work for this?

Bytes.ReplaceAll will create a new []byte or change the original []byte array. As far as I understand we are not supposed to be changing the original []byte array passed in to postprocess

No offense and I don't know Golang but is there not a stdlib function to do this?

The point is to avoid multiple allocations of the (potentially large) byte array.
Yes bytes.ReplaceAll would replace the nil however at the expense of creating yet another copy of the []byte passed in.
This is the same code as bytes.ReplaceAll just replacing into the prefixed copy.

:rocket:


Office: "The file format differs from the format that the file name extension specifies"

Looks like Office 2007 and beyond have an extension check that is getting triggered when running even the examples, causing an error "The file format differs from the format that the file name extension specifies"
See: https://support.microsoft.com/en-us/kb/948615

It's worse than that - there's a new Microsoft patch out that means that Excel will refuse to open such files if they are untrusted : https://social.technet.microsoft.com/Forums/en-US/d2d84793-9920-45e3-baef-5027a4ac1ae0/kb3170008-for-office-2016-breaks-functionality-ms16088

Running into this now. These files are also broken in Office 360.

Is there any fix for this?

Next versions will support XLSX.
Will fix on #71


Convert inputs to tensor

Description
Convert inputs to tensor first; otherwise, .dtype will not be available for non-Tensor inputs.
Type of change

[x] Bug fix
[ ] New Tutorial
[ ] Updated or additional documentation
[ ] Additional Testing
[ ] New Activation and the changes conform to the activation contribution guidelines
[ ] New Callback and the changes conform to the callback contribution guidelines
[ ] New Image addition and the changes conform to the image op contribution guidelines
[ ] New Layer and the changes conform to the layer contribution guidelines
[ ] New Loss and the changes conform to the loss contribution guidelines
[ ] New Metric and the changes conform to the metric contribution guidelines
[ ] New Optimizer and the changes conform to the optimizer contribution guidelines
[ ] New RNN Cell and the changes conform to the rnn contribution guidelines
[ ] New Seq2seq addition and the changes conform to the seq2seq contribution guidelines
[ ] New Text addition and the changes conform to the text op contribution guidelines

Checklist:

[x] I've properly formatted my code according to the guidelines

[ ] By running Black + Flake8
[ ] By running pre-commit hooks

[ ] This PR addresses an already submitted issue for TensorFlow Addons
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@lc0
You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.


Feature Request: get scene contents

I'd love the ability to get the values for each entity that a scene has set. The reasoning for this is to be able to be able to apply these scenes in methods that I have automated elsewhere in pyscript.
My specific example is creating a service that sets the max/min value for a light. I'd love to be able to use the UI to create/edit scenes and then have my automation use this service. This way may spouse can also edit the values for scenes and the like.
Thanks!
EDIT:
The way I've hacked it so far is as follows. I don't really like it, but It works
@service
def list_scene(entity_id=None, **kwargs):
    attr = state.getattr(entity_id)
    scenes = pyscript.config["global"]["scenes"]

    for scene in scenes:
        if scene["id"] == attr["id"]:
            log.error(f"{scene}")

configuration.yaml
pyscript:
  global:
    scenes: !include scenes.yaml

Sadly, the internals of "scenes" aren't exposed through the entity system. So, if this is even possible (without changes to HASS) it would mean finding a way to access the actual internal HASS scene objects, and enumerating their internal variables. Generally a bad idea, since these things can change leaving pyscript broken.
In my opinion, scenes are one of the more underbaked HASS features. Your solution is pretty elegant, I think, by including 'scenes.yaml' into your pyscript config. This won't help with scenes created using scene.create, but, otherwise, it seems to work quite well.

Unfortunately the problem for my use case is that my whole goal is to allow my spouse to edit the scenes using the UI. Unfortunately though by importing the yaml I'd have to restart all of hass to get it to update the values.
At this point I see why you wouldn't/couldn't integrate it directly. Is there a way to either lazily load the yaml or somehow automate the reloading of it upon scene change?

I think there is a scene.reload service to cause Home Assistant to reload the scene definitions if you've altered them (manually or via some pyscript code).
If I were going to do this I would write my own "scene.create" and "scene.apply" services in pyscript. Each room in my home would have a preconfigured list of devices that will be saved for the scene. A input_select would present the room options, a input_text would provide the scene name, and a service call would start the pyscript.scene_create service. It would look at the room and name sent in the service call and save the state of those entities. when pyscript.scene_apply is called it looks up the room name and scene name and restores all the states if it exists. It's basically a complete rewrite of the Home Assistant "scene" stuff in pyscript. Though you could reuse the scene.apply service call from HASS to actually set the states of things if you so desired.

Is there a way to have pyscript reload the config vars? And if I do that does it follow the import?

If you make it an "app" and put the config in the "app config" it'll pyscript will reload whenever it changes:
pyscript:
  apps:
    my_scene_app:
      scenes: !include scene.yaml

Then in your app code pyscript.app_config['scenes'] will have the data.

Ah thanks! This is definitely workable for me.
On Mon, Feb 22, 2021 at 3:09 PM Daniel Lashua<EMAIL_ADDRESS>wrote:

If you make it an "app" and put the config in the "app config" it'll
pyscript will reload whenever it changes:
pyscript:
apps:
my_scene_app:
scenes: !include scene.yaml
Then in your app code pyscript.app_config['scenes'] will have the data.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/custom-components/pyscript/issues/166#issuecomment-783641841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAETWXOZ6WMZXCKXMEO67DTAK2XDANCNFSM4X7EA4BQ
.

If you put scene.yaml in or below the pyscript folder then any changes to that file will be auto-detected.  That will cause all the yaml config to be reloaded, and if your app's config settings change then the app will be reloaded.

Unfortunately then it wouldn't be editable by the front end UI right?

Then in your app code pyscript.app_config['scenes'] will have the data.

Probably a separate issue but i'm getting this:
        scenes = pyscript.app_config['scenes']
                 ^
NameError: name 'pyscript.app_config' is not defined

I haven't played with the frontend scene creator... but if it just, ultimately, stuffs YAML into scenes.yaml, it'll work just fine. If it stores it somewhere else, then, no, probably not.

seems like a scene_reloaded event gets triggered with changes in the UI. So I can hook onto that. Thanks so much w/o this thread I definitely wouldn't have been able to get this to work!


cross joins depending on table order in the from clause

Posting this per request from @bmyerz
I'm parsing this query from myria production since the data is there. You can't run these myrial queries though since the relations are only placed on a specific number of workers. I'm just using this as an example because it can be parsed. Let me know if you need a query that actually runs though.
I'm working with a star schema dataset and want to run a join across 3 relations (lineitem, supplier and customer).
Here is an example with a "bad order":
R1 = scan(public:adhoc10GB:supplier);
R2 = scan(public:adhoc10GB:customer);
R3 = scan(public:adhoc10GB:lineitem);

Q = [from R1, R2, R3
	 where R1.s_suppkey = R3.l_suppkey
     	   and R2.c_custkey = R3.l_custkey
     emit R3.l_linenumber];

store(Q, result);

This example produces this plan, where the supplier is broadcast and cross joined with the customer relation. This is likely because in my query, I am not directly joining between supplier and customer. This can be bad in cases where the supplier and customer are large.

If I rearrange the order of the join where lineitem is first, then I get a better plan without crossjoins:
R1 = scan(public:adhoc10GB:supplier);
R2 = scan(public:adhoc10GB:customer);
R3 = scan(public:adhoc10GB:lineitem);

Q = [from R3, R2, R1
	 where R1.s_suppkey = R3.l_suppkey
     	   and R2.c_custkey = R3.l_custkey
     emit R3.l_linenumber];

store(Q, result);

Let me know if there are any other questions/comments. Thanks!

#455 Another example of this


'NoneType' object is not subscriptable ?

macOS 10.14.
Python 3.7.2 (also tried with Python 2.7.10)
I get 'NoneType' object is not subscriptable ? from python3 setup.py py2app - can anyone help?
Thanks,
➜  radiobar git:(master) python3 setup.py py2app running py2app creating /Users/steveharman/radiobar/build creating /Users/steveharman/radiobar/build/bdist.macosx-10.14-x86_64 creating /Users/steveharman/radiobar/build/bdist.macosx-10.14-x86_64/python3.7-standalone creating /Users/steveharman/radiobar/build/bdist.macosx-10.14-x86_64/python3.7-standalone/app creating /Users/steveharman/radiobar/build/bdist.macosx-10.14-x86_64/python3.7-standalone/app/collect creating /Users/steveharman/radiobar/build/bdist.macosx-10.14-x86_64/python3.7-standalone/app/temp creating /Users/steveharman/radiobar/dist creating build/bdist.macosx-10.14-x86_64/python3.7-standalone/app/lib-dynload creating build/bdist.macosx-10.14-x86_64/python3.7-standalone/app/Frameworks Traceback (most recent call last):   File "setup.py", line 26, in <module>     setup_requires=['py2app'],   File "/usr/local/lib/python3.7/site-packages/setuptools/__init__.py", line 145, in setup     return distutils.core.setup(**attrs)   File "/usr/local/Cellar/python/3.7.2_2/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/core.py", line 148, in setup     dist.run_commands()   File "/usr/local/Cellar/python/3.7.2_2/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/dist.py", line 966, in run_commands     self.run_command(cmd)   File "/usr/local/Cellar/python/3.7.2_2/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/dist.py", line 985, in run_command     cmd_obj.run()   File "/Users/steveharman/radiobar/.eggs/py2app-0.18-py3.7.egg/py2app/build_app.py", line 838, in run     self._run()   File "/Users/steveharman/radiobar/.eggs/py2app-0.18-py3.7.egg/py2app/build_app.py", line 1053, in _run     self.run_normal()   File "/Users/steveharman/radiobar/.eggs/py2app-0.18-py3.7.egg/py2app/build_app.py", line 1146, in run_normal     mf = self.get_modulefinder()   File "/Users/steveharman/radiobar/.eggs/py2app-0.18-py3.7.egg/py2app/build_app.py", line 997, in get_modulefinder     debug=debug,   File "/Users/steveharman/radiobar/.eggs/modulegraph-0.17-py3.7.egg/modulegraph/find_modules.py", line 338, in find_modules     find_needed_modules(mf, scripts, includes, packages)   File "/Users/steveharman/radiobar/.eggs/modulegraph-0.17-py3.7.egg/modulegraph/find_modules.py", line 256, in find_needed_modules     path = m.packagepath[0] TypeError: 'NoneType' object is not subscriptable

This seems like an error with py2app. I'm not at my computer right now, but I'll investigate later. It could also help to report this error to the py2app developers.

Thanks @mdbraber - I just updated my ticket with a little more detail.

@steveharman are you possibly using PYTHONPATH to specific modules? If so you should use the --use-pythonpath option like described here: https://py2app.readthedocs.io/en/latest/options.html

@steveharman here's an approach to debug Python issues:
This is a general guide to debugging setup.py issues, or actually python issues in general (copied from: https://stackoverflow.com/questions/16131500/py2app-error-in-find-needed-modules-typeerror-nonetype-object-has-no-attribu)

Run it again in interactive mode, i.e. python3 -i setup.py py2app. Once setup.py exits you will find yourself in a python prompt.
Run from pdb import pm; pm(). You should now find yourself at a debug prompt.
Type up and hit enter - you are now a frame higher in the stack - you can type list to see where in the source code the current frame is positioned, and args to see the arguments passed to the current frame (usually a function or method). You can also run python commands to inspect the current state, and run pp var to pretty-print that variable.
Once you have repeated the above step a few times you will find where the error is encountered - in the case I encountered where it was a README file I found a variable called lineno which gave the line of my README file which caused the error. If your problem is a module import, it'll probably be something different, but my instinct is that you'll find yourself looping over the packages argument seen in your stack trace, and the current list item will be the key to your problem.

I'm really sorry @mdbraber I simply don't have time to go into resolving this right now.  I've never knowingly touched Python before, I just wanted a menubar radio app for my Mac.  ;-)

@steveharman unfortunately as I can't reproduce the issue it might be due to your local environment. I'll try to investigate a bit more and see if I can reproduce. One question: did you install python3 using brew?

perfectly understood @mdbraber
and yes to python3 via brew

Hi @mdbraber
I tried the steps you mentioned, here's my output:
running py2app
creating /Users/steveharman/radiobar/build/bdist.macosx-10.14-x86_64/python3.7-standalone/app
creating /Users/steveharman/radiobar/build/bdist.macosx-10.14-x86_64/python3.7-standalone/app/collect
creating /Users/steveharman/radiobar/build/bdist.macosx-10.14-x86_64/python3.7-standalone/app/temp
creating build/bdist.macosx-10.14-x86_64/python3.7-standalone/app/lib-dynload
creating build/bdist.macosx-10.14-x86_64/python3.7-standalone/app/Frameworks
Traceback (most recent call last):
  File "setup.py", line 26, in <module>
    setup_requires=['py2app'],
  File "/usr/local/lib/python3.7/site-packages/setuptools/__init__.py", line 145, in setup
    return distutils.core.setup(**attrs)
  File "/usr/local/Cellar/python/3.7.2_2/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/local/Cellar/python/3.7.2_2/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/usr/local/Cellar/python/3.7.2_2/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/usr/local/lib/python3.7/site-packages/py2app/build_app.py", line 838, in run
    self._run()
  File "/usr/local/lib/python3.7/site-packages/py2app/build_app.py", line 1053, in _run
    self.run_normal()
  File "/usr/local/lib/python3.7/site-packages/py2app/build_app.py", line 1146, in run_normal
    mf = self.get_modulefinder()
  File "/usr/local/lib/python3.7/site-packages/py2app/build_app.py", line 997, in get_modulefinder
    debug=debug,
  File "/usr/local/lib/python3.7/site-packages/modulegraph/find_modules.py", line 338, in find_modules
    find_needed_modules(mf, scripts, includes, packages)
  File "/usr/local/lib/python3.7/site-packages/modulegraph/find_modules.py", line 256, in find_needed_modules
    path = m.packagepath[0]
TypeError: 'NoneType' object is not subscriptable
>>> from pdb import pm; pm()
> /usr/local/lib/python3.7/site-packages/modulegraph/find_modules.py(256)find_needed_modules()
-> path = m.packagepath[0]
(Pdb) up
> /usr/local/lib/python3.7/site-packages/modulegraph/find_modules.py(338)find_modules()
-> find_needed_modules(mf, scripts, includes, packages)
(Pdb) list
333  	        path=path,
334  	        excludes=(excludes - includes),
335  	        implies=get_implies(),
336  	        debug=debug,
337  	    )
338  ->	    find_needed_modules(mf, scripts, includes, packages)
339  	    return mf
[EOF]
(Pdb)```

I have no knowledge of "PYTHONPATH".

Steve

The following steps resulted in a working app for me:

Make sure you install python via pyenv with the following flag (to get the dylib):
env PYTHON_CONFIGURE_OPTS="--enable-framework" pyenv install 3.7.4

Delete the setup.py and make a new one
py2applet --make-setup radiobar.py

Build the app using py2app
python -i setup.py py2app

Could you explain how I accomplish item 1 in your list of steps please @wasbeer ?
Thanks

I come bak to this from time to time, to see if the errors I have go away, but I think this is y final attempt.

Fresh install of macOS
Fresh install of python3
Fresh install of vlc
Fresh clone of the code [master]

And I get:
python setup.py py2app
running py2app
creating /Users/steveharman/radiobar/build/bdist.macosx-10.15-x86_64
creating /Users/steveharman/radiobar/build/bdist.macosx-10.15-x86_64/python2.7-standalone
creating /Users/steveharman/radiobar/build/bdist.macosx-10.15-x86_64/python2.7-standalone/app
creating /Users/steveharman/radiobar/build/bdist.macosx-10.15-x86_64/python2.7-standalone/app/collect
creating /Users/steveharman/radiobar/build/bdist.macosx-10.15-x86_64/python2.7-standalone/app/temp
creating build/bdist.macosx-10.15-x86_64/python2.7-standalone/app/lib-dynload
creating build/bdist.macosx-10.15-x86_64/python2.7-standalone/app/Frameworks
Traceback (most recent call last):
  File "setup.py", line 26, in <module>
    setup_requires=['py2app'],
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/setuptools/__init__.py", line 145, in setup
    return distutils.core.setup(**attrs)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/py2app/build_app.py", line 553, in run
    self._run()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/py2app/build_app.py", line 741, in _run
    self.run_normal()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/py2app/build_app.py", line 812, in run_normal
    mf = self.get_modulefinder()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/py2app/build_app.py", line 691, in get_modulefinder
    debug=debug,
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/modulegraph/find_modules.py", line 274, in find_modules
    find_needed_modules(mf, scripts, includes, packages)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/modulegraph/find_modules.py", line 199, in find_needed_modules
    path = m.packagepath[0]
TypeError: 'NoneType' object has no attribute '__getitem__'

@steveharman did you try pip3 install modulegraph?

I don't know what modulegraph is but I used pip3 to install py2app.    Is it relevant that I never get any success with the shortened version of py2app from terminal, only the full py2applet command
➜  radiobar git:(master) py2applet

usage: py2applet --make-setup [options...] script.py [data files...]
   or: py2applet [options...] script.py [data files...]
   or: py2applet --help

➜  radiobar git:(master) py2app
zsh: command not found: py2app
➜  radiobar git:(master)


codespace terminal does not respond after reload request

issue reloading after closing vscode desktop remote access
currently trying to access cs50 codespace with Github login at https://code.cs50.io/
terminal shows $ and white cursor but does not respond - memory issue?
Version: 1.77.1
Commit: b7886d7461186a5eac768481578c1d7ca80e2d21
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/111.0
Embedder: codespaces

Issue persists please advise. It could be that the codespace needs to be rebuilt entirely

disable terminal.integrated.gpuAccleration as it's not supported on certain versions of safari
/duplicate #165416


OTBN security countermeasure update

@prajwalaputtappa please note this adds some things to the OTBN V2S testplan, however I believe they're all covered by existing tests. The reason they'd be left off originally is they're 'functional' security features. They're documented as part of the OTBN architecture and implemented in the ISS. So I think the extra verification work is simply mapping them to existing tests.

Thanks for finding the typos @andreaskurth

Thanks for this cleanup - I aligned the spreadsheet accordingly.


Textfield widget needed (whereas the selection of an autosuggested option is optional)

Is it possible to make Select2 send the actual user input when no specific option has been selected?
Or is there another widget available; a simple text field with auto suggestions underneath?
I am trying to use dal to implement a searchbar for an image db. The user should be able to select one of the autosuggested titles, but this should be optional, not mandatory.

I decided to use the jQuery ui autocomplete widget. After a bit of tweaking it works quite well together with dal.
I'm closing this feature request, if there are no objections.


build(heroku): add Procfile

Pull Request Test Coverage Report for Build 1515

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.571%

Totals

Change from base Build 1514:
0.0%

Covered Lines:
89

Relevant Lines:
108

💛  - Coveralls


Change test cases and add validation before inserting a document

@noraesae Error fixed. Please review it.

LGTM


Possible fix for getting exit code from exec command

Hey, I took a look at the PR https://github.com/containers/youki/pull/1018 ,  and making this PR here to suggest possible changes. This is by no means a complete solution, but should hopefully provide some way to go forward.
Originally I had also though of using the pipe based way as this, but I have changed it. The reason behind this is - to make the pipe way work, some process has to wait for the init process (which runs the exec command) to exit, catch its code and write it to the pipe. The init cannot do it itself, as after exec-ing, the process image is replaced. One way to get the exit status is to do a wait or waitpid , but both only work on child processes or spanwed thread, and as the original youki process which spawned the init process has exited, the process sending exec message cannot use these to wait on the init process.
After seeing the poll on process fd, and reading https://stackoverflow.com/questions/18441760/linux-where-are-the-return-codes-stored-of-system-daemons-and-other-processes , I thought as we are waiting for the process to exit, we can read the exit code in the waiting process itself, thus not needing an intermediate pipe at all. Although this has issues, notably once in my several test runs, it gave IO error, directory in /proc does not exists ; indicating this is susceptible to race-conditions.
Hope this helps a bit :)

@utam0k let me know your thoughts whenever you will take a look at this! Thanks!

@YJDoc2 Verrry thanks. I'll check this tomorrow.

@YJDoc2 Great! I have a question:
Runc implements the same feature using a pipe. Why runc works find...? Do you know anything?

Hey, I had taken a look at it initially, but will need to take another look to confirm. I think it is because (maybe) some difference in the way the init process is called, but not sure. Will confirm and get back on this by today/tomorrow

I tried digging int the runc source, and I think, the status is obtained somewhere from this function https://github.com/opencontainers/runc/blob/c0d44ea9fc076840b9794de3826dbf4494a58c84/utils_linux.go#L276 . However, I don't know how it captures SIGCHLD, as the init process is not child of exec process. I had previously tried calling wait on the pid of launched process, but I might have called it on the wrong PID. I'll try calling it on the PID returned in this PR, and see if we can wait for the status that way.

@YJDoc2 Thanks for your investigation. Great input ❤

Closing in favor of #112


[docs] Fix production deploy of codesandboxes

The name is usally something like "ContinuousSlider demo — Material UI" which is not allowed:

The "name" field contains your package's name, and must be lowercase and one word, and may contain hyphens and underscores.

https://docs.npmjs.com/creating-a-package-json-file. In practice, it breaks the deployment of codesandboxes to production with yarn:

https://codesandbox.io/s/continuousslider-demo-material-ui-forked-69rumd?file=/package.json:518-553
It used to work in v4. What's the value? Sometimes a change in a PR only impacts the behavior in production. I needed this for https://github.com/mui/mui-x/issues/5557#issuecomment-1191764448.

Not sure if this is a regression

@siriwatknp True. Then, let's only say that it was working in v4 https://v4.mui.com/components/badges/ 😁


Problem installing full rom firmware

When i try to Install Full Rom Firmware
this comes after downloading

Firmware download checksum fail; download corrupted, cannot flash.

help me
Chromebook Acer C720

well, either the download failed for some reason, in which case you should try again, or you're running some forked version of my script that's pointing to old files that don't exist. Post pics of the main script menu and the error itself

It was a network issue. I changed the wifi and the problem is solved. Now, I am installing ChromeOS Flex.
Thank you for what you did 💖❤. Really appreciate your work


[Docs]: next-pwa preloading defaults may not be optimal for avg user

Provide environment information
next 13.5.3
@ducanh2912/next-pwa 9.7.1
Whose documentation is this feedback for?
Configuring
Describe the problem
First off, thanks @DuCanhGH for your work to keep the next-pwa concept alive.  You are a reminder and inspiration that one person can make a big community difference and that we all must help out how we can.  In that spirit, when I was testing out next-pwa I saw some things that I think you and others might not actually want happening and might need some discussion, consideration, documentation, or default changes.
source maps
I noticed my server was preloading .map files even though Next.js says they are opt in and I do not have them turned on but I do use sentry and I now notice that it turns them on.  I don't believe the pwa should ever preload these even if they exist.  I believe the default should exclude these:
buildExcludes: [ /\.map$/ ]  // Exclude all .map files

font files
next-pwa is configured with a maxEntries of 4.
Next.js font loading has all subsets in the build.  I have only used Inter but I assume most fonts have more than 4 subsets which means a most important subset (like latin for me personally) might be pushed out of cache depending on order.  One option would be to increase preloading beyond 4 but I think fonts are big and we don't want to download unused subsets.  next/font const inter = Inter({ subsets: ['latin'] })  seems to put a .p (prioritized?) on the files you call out in the subsets list.  I believe the default should be:
buildExcludes: [ /(?<!\.p)\.woff2$/ ]  // Exclude all .woff2 files that are not in the next/font subsets list.

page files
It looks like the default preloads every .js file in the build.  For sites that have alot of pages, this feels like an necessary burden on a user that could have limited mobile bandwidth.    I believe the default next.js prefetch of files in viewport is probably optimal for the average user.
buildExcludes: [ /^((?!~offline).)*\.js$/ ]  // Exclude all .js files that do not contain ~offline in the path

What to do
My opinion is that these are defaults out of the box if that is possible.  Documentation around a 'minimal' preload suggestion to protect users that use sentry, next/font or have large amount of pages could be good too:
    const withPWA = (await import('@ducanh2912/next-pwa')).default({
      dest: 'public',
      buildExcludes: [
        /\.map$/,                      // Exclude all .map files
        /^((?!~offline).)*\.js$/,  // Exclude all .js files that do not contain ~offline in the path
        /(?<!\.p)\.woff2$/,        // Exclude all .woff2 files that are not in the next/font subsets list
      ],
    });

Expected behavior
next-pwa:

doesn't preload map files
preloads only font files called out in next.js subsets list
only preloads offline page (other pages are downloaded during viewport visible link behavior)

Screenshots (if relevant)
No response
Additional information (if relevant)
No response

Thanks!
Let's break your point down a bit:

.map files: Yeah, these files really don't matter for the users, so perhaps they should be excluded.

Font files: your RegExp essentially means that we drop all font files except for .p.woff2 if I understand it correctly. I think we should use /\/_next\/static\/.*(?<!\.p)\.woff2/ instead - this will drop all non-.p.woff2 files that belong to next/font, which probably means it won't be a breaking change for those who don't use next/font. I'd like to confirm that .p means prioritized though.

.js files: the reason to consider excluding these files being the fact that they are preloaded by next/link on hover seems reasonable to me. However, considering the technical bits, excluding only JS files that include ~offline seems really specific. If we were to introduce something that the user won't ever visit through next/link (just like /~offline) once more, we would have to change the defaults again - this is something I'd like to avoid to be honest. And /~offline probably has scripts that don't have ~offline in its source link as well, so we'd break the page if we mistakenly exclude scripts that /~offline relies on. It is also worth nothing that the downloads seem to happen in the background (possibly in the service worker) so they probably won't block page load at all. All points considered, I think it would be best if we don't exclude JS files at all.

Makes sense.

.map files: Yeah, I think it would be great to protect consumers from ever getting these automatically downloaded if it is possible.  There are also security issues to exposing these.  I think many will evaluate next-pwa with maps off on in an MVP and when they turn maps on later in prod (possibly unintentionally like me when I loaded sentry) for improved debugging there is a real risk they wont realize they all get in the consumer preload.

Font files:  agreed /\/_next\/static\/.*(?<!\.p)\.woff2/ makes much more sense.  I can't find any official documentation on the ".p" but as I look through next.js code I see tests that indicate the .p is probably also short for "preload".

.js files: This is certainly the most opinionated one.  Small site may prefer everything preloaded.  It is really just a potentially unnecessary network resources issue on server and client as number of pages grows over time, especially over 64.  Fortunately this is easy to configure.  Part of me wonders if the docs should be a bit stronger worded on what is happening in the background, perhaps a tip for larger sites with page sizes beyond max cache side to consider a more specific whitelist but I don't think this is a huge deal.

@Enalmada yeah, perhaps we can update the docs a bit regarding precaching .js files. There are .next/app-build-manifest.json and .next/build-manifest.json, which are really detailed regarding JS files that pages would use, but I don't know how the user would read them in next.config.js, so it is somewhat a shame.


about c++ env in building deepspeed from source

      i try to use zero stage 3 to train a LLM, but encounter a lot of error, mainly because when i pip install deepspeed , cpu_adam and fused_adam not installed ,so i try to build from source, but encounter a lot of c++ compiling error ,can you share your c++ env, it includes gcc, g++ version and etc.
     my OS is centos 7, CUDA Version: 11.8, 8 NVIDIA T4

solved.i reinstalled gcc and gcc dev and building success.thanks for your reply.
original gcc env of my server is a mess and no Internet connection.


Save video params to Media

Media object now has:
video: {
  versions: [ url: String, width: Number, height: Number, type: Number ],
  has_audio: Boolean,
  duration: Number
}

But only if media_type is 2. The URL is a direct link to a MP4 file.

node and this lib is using camelcase so, also reason for parse method... I merge your changes manually...

more requests welcome, good job!


⚠ 한경주요지수-코스피200 has degraded performance

In ed0377e, 한경주요지수-코스피200 (https://markets.hankyung.com/indices/kospi200) experienced degraded performance:

HTTP code: 200
Response time: 6172 ms

Resolved: 신규상장 performance has improved in 2422d52.


fix 1px offset on homepage search button

Changes in this PR:
Fixes the weird 1px offset that the search button has relative to the text field on the homepage text box, and increases the gutter a little bit so the active button outline doesn't overlap the search field.
Trello card / Rollbar error (etc)
https://trello.com/c/AJ83U4jQ/363-da-fix-weird-spacing-on-search-box-on-homepage
Screenshots of UI changes:
Before

After

Codecov Report

Merging #542 (c3b06a8) into main (c406411) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   78.51%   78.51%
=======================================
  Files          16       16
  Lines         661      661
  Branches       43       43
=======================================
  Hits          519      519
  Misses        130      130
  Partials       12       12

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Learning a Probabilistic Latent Space of Object Shapes via 3D Generative-Adversarial Modeling

@meetshah1995 Are there any links between the input 2D images? 2D image to 3D image contact is what? Thank you

@meetshah1995  Did your results reproduce now? I use your code to get the result i do not know what? What is the specific format of your code input and output? Thank you

Hi ,I think the input may be A random normal distribution as you can see in the paper. it can be get be code z_sample = np.random.normal(0, 0.33, size=[batch_size, z_size]).astype(np.float32).


typings has problem

typings has problem

Care to share what that problem is?
On May 16, 2017 10:10 PM, "roc"<EMAIL_ADDRESS>wrote:

typings has problem
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mzabriskie/react-draggable/issues/251, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABJFP2OGuNLhmKs5zlrQoAfXJGrIHfUzks5r6mUKgaJpZM4NdUsu
.

I'm getting this error: Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in.
I don't see anything wrong with the typings file though.

typings has problem

when using TypeScript you should write:
import * as Draggable from 'react-draggable'

But this led me to another problem, TS compiler now throws an error:
JSX element type 'Draggable' does not have any construct or call signatures.

seems it has been solved recently #246

This problem has either been fixed, or there is simply too little information to debug.
"typings has problem" is not a workable ticket. Please have some respect for our time.


Getting error while running pipeline for IBM watson.ai models

I tried running the pipeline for Watson.ai models but I am getting unsupportedparamsError. I have attached the screenshot below

Also, I tried to drop these params by setting drop_params but that parameter value was not getting picked up. Could you please help me to run my pipeline?

Hi, thanks for posting an issue--we rely on tool calling to get all structured outputs for now, so unfortunately we don't support the Watson models yet because they don't support tool usage. We are working on alternatives (e.g., integrating with Outlines) and will keep you posted.


chore: Celebrate my 100th commit for RunKV

Actually nothing to celebrate, but life always needs something to celebrate, right?

Hope I will graduate, and RunKV will run as fast as it can.


Blue highlight doesn't always clear

I noticed that there are some things that cause the blue highlight to appear

hovering issues
hovering relation members (#939)
hovering on search results

And sometimes it goes away when you are done hovering, but sometimes it doesnt.
(Here I searched for the Space Needle - it stays blue after I've moved on to other things).

We can probably just clear this class on mode change?  Or be more diligent about removing the highlight?   Not sure.

I just opened Rapid in New Jersey and searched for "Space Needle", clicked "Search Worldwide", clicked first result (the tower building itself), and it remains blue even after interacting with other features.

This was pretty simple - there was just an extra else branch missing the code to clear the highlight.


WIP: 2.x Deprecate get_field() in favor of meta()

Ticket: #1827
Solution
MetaInterface
Added an interface MetaInterface as proposed by @pascalknecht. The goal is to have less inheritance and more «contracts». All classes that want to implement fetching meta values from the database should implement MetaInterface.
I made Post, Term, User, Comment and MenuItem implement this class. This means that any methods for handling meta values were removed from Core and CoreInterface.
Because every class now implements their own methods for meta() and the deprecated get_field() method, this has the additional benefit that in the generated reference documentation, all these methods will be properly documented 🎉.
Integrations
I added a new parameter for meta(), an arguments array. This arguments is passed to the filter, so that other plugins can hook into it and make their own arguments available through Timber. More about this in https://github.com/timber/timber/issues/1827#issuecomment-431487553.
I added the $args parameter to timber/{object}/pre_meta and timber/{object}/meta (where object can be post, term, user, comment). Here’s an example:
/**
 * Filters the value for a post meta field.
 *
 * This filter is used by the ACF Integration.
 *
 * @see   \Timber\Post::meta()
 * @since 2.0.0
 *
 * @param string       $value      The field value.
 * @param int          $post_id    The post ID.
 * @param string       $field_name The name of the meta field to get the value for.
 * @param \Timber\Post $post       The post object.
 * @param array        $args       An array of arguments.
 */
$value = apply_filters(
    'timber/post/meta',
    $value,
    $this->ID,
    $field_name,
	$this,
    $args
);

ACF Integration
I updated the ACF integration:

Changed ACF integration to use timber/post/pre_meta instead of timber/post/meta. This will prevent running get_post_meta() and maybe help with performance a little bit.
Changed ACF integration to use timber/term/pre_meta instead of timber/term/meta. This will prevent running get_term_meta() and maybe help with performance a little bit.

The new $args parameter now makes it possible to use the third argument for get_field() in the following way:
{{ post.meta('field_name', { format_value: true }) }}

Post
Removed unnecessary warning when no value was provided for meta():
if ( null === $field_name ) {
    Helper::warn('You have not set what meta field you want to retrieve this can cause strange behavior and is not recommended');
}

Removed unnecessary warning when meta field name was used
if ( 'meta' === $field_name ) {
    Helper::warn('You’re trying to retrieve a meta field named "meta". This can cause strange behavior and is not recommended.');
}

Term

Added new timber/term/pre_meta filter to make it behave like $post->meta().

Comment

Renamed timber/comment/get_meta to timber/comment/meta to make it follow the same pattern as in the other classes.
Removed shirt-circuit and applied behavior of $post->meta().

Usage Changes

meta() should always be used to access post meta values.
meta() also needs to be used instead of get_field(), to get ACF field values. The integration hooks into meta().

Considerations
Improve checks for unwanted behavior
We can’t use the defensive solution for __get() that’s listed in #1827 as a task for this pull request, because Twig accesses an object method directly, when it’s public and it exists. That warning would never be reached, so we can’t add it there.
Meta caching
In Term, there’s still a check at the beginning of meta():
if ( isset($this->$field_name) ) {
    return $this->$field_name;
}

This is a small caching mechanism. Do we need this? Depending on what we do in https://github.com/timber/timber/issues/1823, we don’t. Otherwise, we should probably add it to the other classes as well.
Documentation

Replaced remaining relevant instances of get_field() in the documentation.
Updated the documentation for Advanced Custom Fields.

Testing

Moved ACF-related tests to own file.
Added tests to test the new $args parameter for meta.
Added tests to test deprecation of get_field().

Todo

[ ] Take a decision whether to keep direct access meta values through dynamic properties: #478 and #1823. Make changes to this pull request accordingly.

@jarednova This pull request is based on #1830. As soon a it’s merged in, that pull request will be automerged as well.

I updated the description of this pull request. Before I can continue to work on this, we need to take decisions on #478 and as well as the related #1823.

@gchtr thanks for the bump. I just followed-up on #478 and #1823 — do you have what you need now?

@jarednova Yep, I have the answers I need 👍

I removed the logic in Timber\Term that assigned value of a field to a custom dynamic property.
I think this is now ready for merging (@jarednova). The remaining todos for meta values in 2.0 will be solved with a pull request for #1823.

Woohoo! This is a big one. Excited to tear into it!


Desired behavior

I want to generate a library
Mention any other details that might be useful (optional)

having a similar issue
ng generate library aa-header
Unexpected token ] in JSON at position 863

I had this trailing comma in my styles in my angular.json file.  it was causing the error.
            "styles": [
              "src/styles.css",
            ],

We have a fix for this. In the meantime this is a dupe of https://github.com/angular/angular-cli/issues/10757.


onLongPressStart and onLongPressEnd

go full screen,I need the relevant callback methods for onLongPressStart and onLongPressEnd, but I couldn't find.
Can we increase support?

On video player long press? What is it for? And on desktop or mobile?
Did you try to wrap the video player with a gesture detector and implement those functions by yourself? (Note: I think the hit behavior should be translucent)

On video player long press? What is it for? And on desktop or mobile?
Did you try to wrap the video player with a gesture detector and implement those functions by yourself? (Note: I think the hit behavior should be translucent)

on mobile，Users usually do this：
1.onLongPressStart：video will 2x speed play
2.onLongPressEnd：video returns to normal speed
I tried to use stack and add gesture to the topmost layer of flutter_meedu_videoplayer, but it didn't work.

On video player long press? What is it for? And on desktop or mobile?
Did you try to wrap the video player with a gesture detector and implement those functions by yourself? (Note: I think the hit behavior should be translucent)

on mobile，Users usually do this：
1.onLongPressStart：video will 2x speed play
2.onLongPressEnd：video returns to normal speed
I tried to use stack and add gesture to the topmost layer of flutter_meedu_videoplayer, but it didn't work.

No need for stack just a gesture detector and the video player is the child

On video player long press? What is it for? And on desktop or mobile?
Did you try to wrap the video player with a gesture detector and implement those functions by yourself? (Note: I think the hit behavior should be translucent)

on mobile，Users usually do this：
1.onLongPressStart：video will 2x speed play
2.onLongPressEnd：video returns to normal speed
I tried to use stack and add gesture to the topmost layer of flutter_meedu_videoplayer, but it didn't work.

No need for stack just a gesture detector and the video player is the child

AspectRatio(                         aspectRatio: 16 / 9,                         child: GestureDetector(                           behavior: HitTestBehavior.opaque,                           onLongPressStart: (details) {                           },                           onLongPressEnd: (details) {                           },                           child: MeeduVideoPlayer(                             controller: _controller,                           ),                         ),                       )
The code is not valid when going to full screen playback.

yes, okay i will add this to the main package and let you know how to enable it,
i think it should work on mobile, not desktop right?
most probably i will work on it tommorow

Yes, onLongPressStart and onLongPressEnd are very useful in mobile.
thanks！

published in 4.2.11-dev


crypto/x509: intermediates with unknown critical extensions not rejected [Go1.8]

Go 1.8 version of #22260.

CL 69294 OK for Go 1.8.5.

go1.8.5 has been packaged and includes:

CL 70842

The release is posted at golang.org/dl.
— golang.org/x/build/cmd/releasebot, Oct 26 21:07:50 UTC


[Snyk] Upgrade @opensea/seaport-js from 1.0.2 to 1.0.6

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @opensea/seaport-js from 1.0.2 to 1.0.6.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 4 versions ahead of your current version.
The recommended version was released 22 days ago, on 2022-09-13.

Release notes

Package name: @opensea/seaport-js

1.0.6 - 2022-09-13

1.0.5 - 2022-08-01

1.0.4 - 2022-07-10Patches an issue with 1.0.3 where we weren't setting the signer properly in the constructor.

1.0.3 - 2022-07-08Lets consumers provide a signer instead of a provider

1.0.2 - 2022-06-18Downgrade node version to v14

    from @opensea/seaport-js GitHub release notes

Commit messages

Package name: @opensea/seaport-js

fb1c40d 1.0.6
991b37a Add domain hash to random salt (#112)
74e1d8a Update README.md (#86)
861b12e 1.0.5
f543310 fix: it should wait for tx to be included when sending approve transa… (#84)
21aeed1 fix: set signer in Seaport constructor (#76)
386557f 1.0.3
1f18048 chore: fix README examples for creating orders (#75)
8db884b separate file for cancel tests (#72)
e7eb2af feat: add support for custom signer (#71)
5952c3c add npm badge to readme (#69)
e34dbbb add readme badges, codecov (#68)
16c7747 Add coverage and report via coveralls (#61)
159057b chore: Unpin dependencies (#60)
5564010 Add Opensea Conduit to known conduits (#56)
39bbc7f chore: make offerer and fulfiller more explicit addresses (#58)
6680976 README: quick line removal
4bbe6d3 Add some basic examples in readme (#57)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Why won't this be merged? It solves the polygon problem - no?


Add missing migration

The library is missing a migration for the validator change made a while ago.

Fixed by ffcaefb9985f0b89f1e8c248ed962ac3be1ca6c6


DONT MERGE: Fallback support

Checking conflicts

@googlebot I fixed it.

I'm facing some merge problems and this CLA error which I'm trying to debug, might not be able to push it out today

I think the merge conflicts were from me pulling from @alexander-fenster commit to master, but I think i got those. The CLA from checking the logs I'm not sure. These are they only two non-google commits I see.
commit 411178d419dff14a8c18ea3d9cf89fe45678458b
Author: Justin Beckwith<EMAIL_ADDRESS>Date:   Wed Jul 31 16:07:06 2019 -0700
docs: document apiEndpoint over servicePath (#561)

commit 3690ab17e174978ca3dffad35098e6dd2fb8524e
Author: ramya-ramalingam<EMAIL_ADDRESS>Date:   Wed Jul 31 15:51:29 2019 -0700
feat: making `google-gax` work in browser with `webpack` (#554)

This PR adds support for grpc-fallback calls over HTTP/1.1 to allow using google-gax in browser.

Co-authored-by: Liban Odowa<EMAIL_ADDRESS>Co-authored-by: Ramya Ramalingam<EMAIL_ADDRESS>

It got sent against the browser branch and the set of changes is really weird. Looks like something got fundamentally wrong :) Your branch just has too much stuff in it, and it does not make much sense to merge this long tail of commits.

Can you try doing that please?

Also, it will make CLA bot happy because now the bot is really confused about one of the commits in the list, and it's really easier to recreate the stuff than to try making that bot happy :)


Help,In an ionic2 ios App,how to open another ios app?

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ ] 3.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

Expected behavior:

Steps to reproduce:

Related code:
insert any relevant code here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
insert the output from ionic info here

Thank you for opening an issue with Ionic (fyi, I am not officially an Ionic team member... yet...)! However, this seems a support request, not a bug report or feature request. Please close this issue and either ask your question on the Ionic forums (https://forum.ionicframework.com/) or on the Ionic Worldwide Slack (http://ionicworldwide.herokuapp.com/).

thanks


flickering / button size

The audio bargraph (v2 / android 7.0) has been flickering for some time and the display is always 1x1, regardless of which button size has been selected.
With best regards
D1ck3s B

Hi, for the flickering it can be that the image has to high resolution (Width, Height), or the UpdateInterval is set to low. There is a Debug options that shows a counter (can be changed from false to true), and if this skips frames, or is displayed in the wrong order, then the plugin is sending more data than the app/network can handle.
For the 1x1, I would try to click the refresh button in the App (top right corner).
This can also be that the configuration file has an issue in it, and therefore the plugin ignores the changes. If nothing happens at all, then this is most likely the case. You can try using the JSON Schema Validator and copy in your own configuration (or share it here).
If this is something that worked better for you before, I am really interested in when it started to change. The Touch Portal team is testing out sliders and similar at this time, and this might have changed something in the App.
I will also try to test this out myself and see if I find something.

@D1ck3sb when I re-read your issue her, it might be that you have not changed the appsettings file? In that case my comment might not give any sense.
It works on my device, but the default is a squared image.
After you have changed the configuration file, you will need to refresh the page on Android, but this should only be the first time.
Configuration file can be found at: C:\Users\oddbj\AppData\Roaming\TouchPortal\plugins\TouchPortal.Plugin.AudioMonitor\appsettings.json just replace oddbj with your windows username.

Thank you for your answer and
apologize for not getting in touch first. was unfortunately too busy.
The error was, I had incorrectly interpreted the update interval
( total failure of logical thinking :-) )
and therefore set it incorrectly.
After I changed it, the button size could also be changed again.

Great. Good that it worked out in the end. :)
It might not be the most intuitive explanation from my side, so I might create a video guide or something for future reference.
Closing the issue as it is solved.


Regarding sort att_feats

Hi. Thanks for your code.
While going through the code, I realized something in the sort_pack_padded_sequence function. Apparently you would like to unsort the features after running them through the model by the inv_ix. However, when running this line: tmp = tmp[inv_ix], the arrangement is completely different. You can have a look at the example below:
a = torch.randn(5,2)
print(a)
lengths = torch.tensor([2,1,8,6,3])
sorted_lengths, indices = torch.sort(lengths, descending=True)
inv_ix = indices.clone()
inv_ix[indices] = torch.arange(0,len(indices)).type_as(inv_ix)
print(a[inv_ix])

They are not the same:
tensor([[ 0.0467,  1.1358],
        [ 0.9669, -1.4713],
        [-0.6780, -2.3222],
        [-0.7623, -0.9263],
        [ 0.3579, -1.2761]])

tensor([[ 0.9669, -1.4713],
        [-0.6780, -2.3222],
        [-0.7623, -0.9263],
        [ 0.3579, -1.2761],
        [ 0.0467,  1.1358]])

a = torch.randn(5,2)
print(a)
lengths = torch.tensor([2,1,8,6,3])
sorted_lengths, indices = torch.sort(lengths, descending=True)
a = a[indices] # you missed this.
inv_ix = indices.clone()
inv_ix[indices] = torch.arange(0,len(indices)).type_as(inv_ix)
print(a[inv_ix])


Move creation of clouds.yaml file to edpm_prepare

The clouds.yaml file was created by the tempest role because it is needed to execute tempest tests.
Later, those tasks from the tempest role were reused by the tobiko role, because the file is needed for running tobiko as well. This change moves the creation of clouds.yaml to an earlier step in the edpm_prepare role and it could be reused by any other stages executed later (e.g. new test frameworks).
Depends-On: https://github.com/openstack-k8s-operators/tcib/pull/123
OSPRH-1670
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running
[X] Appropriate documentation exists and/or is up-to-date:

[X] README in the role
[X] Content of the docs/source is reflecting the changes

@eduolivares heya! Is this still something you're working on? Do you need any help to finalize this change?

@eduolivares heya! Is this still something you're working on? Do you need any help to finalize this change?

@cjeanner I postponed this PR for too long and now I'd need to update it (for example, the tobiko role doesn't exist anymore) and this is not a good moment for me to resume working on it.
Perhaps I should close it and take it again when  I have more time.

@eduolivares care to close it, probably get some jira card to not forget about that task, and re-open a PR when you can handle it? That would help cleaning the backlog in here, really.
Thanks!


[#506] Authorization policy comments not working

Description
Please provide a summary of the pull request and the issue it resolves. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.
Update auth library and fix authorization policies to use new comment format.
Resolves #506
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[x] Within a week
[ ] When possible

Type of changes
Please select a relevant option:

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:
Please select all applicable options:

[x] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[x] I have updated the CHANGELOG.
[x] I have read the Contributor Guidelines.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[x] My changes generate no new warnings.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

Hi @petyos, please take a look at this when you get a chance. I have updated to the latest version of the auth library. This new auth library version is a large update with many breaking changes which you can see here: https://github.com/rokwire/core-auth-library-go/releases/tag/v2.0.1.
In the release notes above (also in the README in the auth library) are some notes about the new "comment" system. Essentially I just added a new column to the authorization model that is ignored when checking the policies. This means that every permission policy CSV must now have one more comma at the end even if no comment is provided.
Let me know if you have any questions or comments about these changes. Thanks!

Thanks for the feedback @roberlander2! I have fixed the issues you pointed out. Please take a look and let me know if you see anything else when you get a chance. Thanks again!


Improvement in VideoRipper

Declared 'bytesCompleted' on a separate line.
'canRip' was defined in the 'RipperInterface' interface and therefore was removed.
Redundant variable removed.
Closed fileWritter.

@Gaboso Why did you close the PR? Apologies for not following up on this.


DIR does not return working directory

Magic constants __DIR__
The directory of the file. If used inside an include, the directory of the included file is returned. This is equivalent to dirname(__FILE__). This directory name does not have a trailing slash unless it is the root directory.

https://github.com/deployphp/recipes/blob/master/configure.php#L50
__DIR__ should be replaced by getcwd() wich returns the working directory.

Done.

Please create tag with this fix https://github.com/deployphp/recipes/blob/master/configure.php#L50
Now this recipe works only in the master branch

Done.


Adding new rule for no-global-jquery and tests

@kratiahuja
Added new rule to help ensure devs are not using global $, but instead using Ember.$.

oooh. Can we lint no global selectors at all?
blog.isleofcode.com/the-real-reason-to-avoid-jquery/


Initial layout of the page

Set up the different sections of the page (introduction, bullet points, project)
Edit layout of each project's text box in the CSS file

Hey Holly. I found Google HTML/CSS style guide, as well as Google Javascript style guide.
https://google.github.io/styleguide/htmlcssguide.html
https://google.github.io/styleguide/jsguide.html
Can you skim through these guides, and see whether this pull request should be updated? The style guides are pretty long, so I understand if you can't remember every part of them. But it'd be nice to check them against this code change.


(BUG) orders: displaying identical list for all exhibitors

expected result
displaying a summary of orders specific to each exhibitor
actual result
displaying the same list of orders for all exhibitors
DK example from 4pm:

KM example from 11pm:

environment
chrome, chrome incognito
team members who tested
DK

@KarolinaTEH checking...(most probably cache issue)

@KarolinaTEH cache was to eager... fixed. sorry for problem.


Disable scroll and highlight code on hover

The feature that scrolls and highlights code as I hover over the sidebar is distracting.  I want to scroll and highlight code only if I click on the associated label in the sidebar.  I would like an option to disable this feature.

the op is right, this option would be very much appreciated!


PCF Dev not resolving api although running successfully

I feel pretty strongly that I haven't missed anything in the documentation as it is straight forward although I've made mistakes in the past....
I am on a Mac, I installed the plugin, I have Virtualbox > 5 with brew as my package manager.
$ cf dev start
Everything runs, PCF Dev banner pops, 57 services running....looks good.
Running:
cf login -a https://api.local.pcfdev.io --skip-ssl-validation

Gives me:
API endpoint: https://api.local.pcfdev.io
FAILED
Error performing request: Get https://api.local.pcfdev.io/v2/info: dial tcp: lookup api.local.pcfdev.io: no such host
TIP: If you are behind a firewall and require an HTTP proxy, verify the https_proxy environment variable is correctly set. Else, check your network connection.

I run:
cf dev status
It gives me
Running
CLI Login: cf login -a https://api.local.pcfdev.io --skip-ssl-validation
Apps Manager URL: https://local.pcfdev.io
Admin user => Email: admin / Password: admin
Regular user => Email: user / Password: pass

I can't get to the Apps Manager https://local.pcfdev.io either. It feels like I'm doing everything right, the instructions are quite simple, they seem hard to mess up (at this point at least).

When I worked through using PCF Dev offline setting up my own dns as instructed in the working offline section of the pivotal docs, everything appears to be working.
Would I be correct in saying this is the endpoint you have exposed that is not resolving correctly or is there something else going on here?
Second.  For the PCF Dev dash, the behavior is expected for the self-signed certs and having ourselves manually bring them in to not have to continually deal with Google's meltdown?

Do you happen to have custom router firmware (ex. dd-wrt, openwrt, tomato) that is configured to prevent DNS re-bind attacks? That would prevent you from resolving any public DNS records that specify private IP ranges.
To prevent the certificate warnings (and allow you to skip the --skip-ssl-validation flag), you can start PCF Dev with cf dev start -k. This adds the PCF Dev self-signed cert to the OS certificate store.

I have dd-wrt.  Didn't think to check that. I will check that and report
back. Likely resolves it, thanks!
I had seen the self-signed cert solution. Wasn't sure if it was final
solution.  Thanks for that.
On Jan 3, 2017 9:54 AM, "Stephen Levine"<EMAIL_ADDRESS>wrote:

Do you happen to have custom router firmware (ex. dd-wrt, openwrt, tomato)
that is configured to prevent DNS re-bind attacks? That would prevent you
from resolving any public DNS records that specify private IP ranges.
To prevent the certificate warnings (and allow you to skip the
--skip-ssl-validation flag), you can start PCF Dev with cf dev start -k.
This adds the PCF Dev self-signed cert to the OS certificate store.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pivotal-cf/pcfdev/issues/183#issuecomment-270146336,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG5JKmrsuy7Tqqd1kJCY4diXCayE9O0wks5rOm8agaJpZM4LUnDE
.

Closing as this seems to be addressed. Let us know if we should re-open.


Added a git mailmap file to consolidate authors

After seeing your name just now, it reminded me that I spotted a slight issue with this repo on SPI. You have a couple of different authors showing. We use git shortlog -sne to determine this information, and a .mailmap file can fix it up!

It may be a little cheeky for me to assume you want to do this, but just in case, here's a PR!

I've seen this issue on my SPI page before. Thanks for the fix!
By any chance, do you know why I actually have multiple authors? I don't recall committing from different machines or doing anything that could cause that. 🤔

I've seen this issue on my SPI page before. Thanks for the fix!
By any chance, do you know why I actually have multiple authors? I don't recall committing from different machines or doing anything that could cause that. 🤔

I don't. What's even stranger is that I can't see any character differences between the two lines if you run git shortlon -sne before this commit. It's odd!

I've seen this issue on my SPI page before. Thanks for the fix!
By any chance, do you know why I actually have multiple authors? I don't recall committing from different machines or doing anything that could cause that. 🤔

I don't. What's even stranger is that I can't see any character differences between the two lines if you run git shortlon -sne before this commit. It's odd!

Yeah... very odd :/


Nothing loading

Hi All.
I was using the nuget package in .NET Framework 4.7.2 and it was working fine. I then migrated the project to .NET 6 and then the gird no longer appeared. I'm not sure if it is because I am using .NET 6 or if I am doing something wrong, but any help would be much appreciated.
My current code:
XAML:
xmlns:control="http://filterdatagrid.control.com/2021"
...
<control:FilterDataGrid x:Name="filterGrid" Grid.Column="1" Grid.Row="2" Grid.ColumnSpan="2"></control:FilterDataGrid>

XAML.CS:
...
filterGrid.DataContext = viewModel;
filterGrid.ItemsSource = viewModel.Contracts;
filterGrid.AutoGeneratedColumns += (_, _) =>
{
     filterGrid.Columns.RemoveAt(0);
     filterGrid.Columns.Move(10, 0);
     filterGrid.Columns.Move(13, 0);
     filterGrid.Columns[0].Header = "Contract (JobID)";
     filterGrid.Columns.RemoveAt(7);
     filterGrid.Columns.RemoveAt(13);
     filterGrid.Columns.RemoveAt(13);
     filterGrid.Columns.RemoveAt(13);
     filterGrid.Columns.RemoveAt(13);
};

Contracts is a IEnumerable<Contract> which is loaded before this code.

I have the same problem. I use Net core 3.1, I use 1.2.5 is normal, when I upgrade to 1.2.6 is not displayed.

I have the same problem. Version 1.2.5 works normally, after updating to 1.2.6 the grid does not appear. The project is .NET 6, Nuget package.

So as long as I use version 1.2.5 everything should work as expected?

Several of you report this problem, do you all use the same method of loading data?

Several of you report this problem, do you use the same method of mbaksh01 to load the data?

I have tried several variants, for example this one works fine in 1.2.5 but not in 1.2.6.
On my XAML: <control:FilterDataGrid x:Name="someFilterDataGrid" ShowStatusBar="True"></control:FilterDataGrid> also tried with AutoGenerateColumns="True"
Code behind:
someFilterDataGrid.ItemSource = System.Windows.Data.CollectionViewSource.GetDefaultView(... filled e.g. with List....);
even .Refresh() didn't help

Hi All,
Specify :

Version of your project (.NET Framework or .NET)
NuGet package version
The FilterDataGrid version of the NuGet package
Visual Studio version
Also indicate your way of feeding FilterDataGrid data

best regards

Version of your project (.NET Framework or .NET) =>  .NET 6
NuGet package version => <IP_ADDRESS>8
The FilterDataGrid version of the NuGet package => 1.2.6
Visual Studio version => VS 2022 17.3.3
Also indicate your way of feeding FilterDataGrid data =>

Set ItemSource to a IEnumerable list.
Set IsReadOnly to true.
Add AutoGeneratedColumns event handler to arrange columns in custom order.
Pass the FilterDataGrid to the System.Windows.Controls.Frame Content property to be displayed.

Version of your project (.NET Framework or .NET) => .NET 6
NuGet package version => from nuget.org 1.2.6 published 6/15/2022
The FilterDataGrid version of the NuGet package => 1.2.6
Visual Studio version => 2022 17.3.3
Also indicate your way of feeding FilterDataGrid data => please see my comment from Aug 9

Hi all,
The problem with loading probably stems from where and when you feed the "items source" property of FilterDataGrid .
FilterDataGrid works the same way as a Datagrid.
If you don't implement INotifyPropertyChanged to notify that the "items source" property has been updated, use the "Loaded" event of FilterDataGrid to do further processing on the columns.
Here is an example :
// MainWindows.cs
List items = new List
{
new() { Name = "John Doe", Mail =<EMAIL_ADDRESS>Age = 42, Sex = SexType.Male },
new() { Name = "Jane Doe", Mail =<EMAIL_ADDRESS>Age = 39, Sex = SexType.Female },
new() { Name = "Sammy Doe",Mail =<EMAIL_ADDRESS> Age = 13, Sex = SexType.Male },
new() { Name = "Donna Doe",Mail =<EMAIL_ADDRESS> Age = 13, Sex = SexType.Female }
};
filterGrid.ItemsSource = items;
        filterGrid.Loaded += (_, _) =>
        {
            filterGrid.Columns.RemoveAt(3);
            filterGrid.Columns.Move(1, 0);
            filterGrid.Columns.Move(2, 1);
            filterGrid.Columns[0].Header = "Contract (JobID)";
        };

// test class
public enum SexType { Male, Female };
public class User
{
public string Name { get; set; }
public int Age { get; set; }

public string Mail { get; set; }

public SexType Sex { get; set; }

}
Please see the demo applications provided with the code of FilterDataGrid.
Best regards


Implement jQuery version checking

If the jQuery version is old then print the list of vulnerabilities that can be attacked.

I'm working on it


Validation is broken

Describe the Bug
Event.validate() is not functioning correct (tested in the express-ex example)
Steps to Reproduce

let e = HTTP.toEvent({headers: req.headers,body: { "a space": "not allowed", specversion: "1.0", source: "source1", id: "1", type: "test" }
e.validate() //no error

Expected Behavior
An error (just like when an ext.attribute with the name "Acapital"  is used).
Additional context
The problem seems to lie in spec.ts because of a broken reference tot the v1-schema. Looks as if it's there since release 5.4.0 when a separate schema-folder was created.

The problem seems to lie in spec.ts because of a broken reference tot the v1-schema. Looks as if it's there since release 5.4.0 when a separate schema-folder was created.

I know it seems that way, but the schema is actually precompiled at build time, so you don't see it in this source repository. You can see where this was changed here: https://github.com/cloudevents/sdk-javascript/pull/471 and where it actually happens during the build here: https://github.com/cloudevents/sdk-javascript/blob/847f6bfcc77934a53b07493a957ed11f724c6deb/package.json#L10
This seems like a genuine bug in the validation code. Extensions, unfortunately, do not have a formalized JSON spec that we can use to generate a validator (pretty sure about that). You can see in the CloudEvent spec that it does not mention extensions: https://github.com/cloudevents/spec/blob/main/cloudevents/formats/cloudevents.json. Thanks for reporting this.


Add simple launch screen

It is better than nothing but launch screens on iOS are not supposed to be splash screens.
See https://developer.apple.com/ios/human-interface-guidelines/graphics/launch-screen/