Extension keeps running after closing vscode with 100% cpu use

Starting with the version 2.40.1, plugin is no longer closed after exiting vscode on linux. Furthermore, the extension starts utilizing 100% of one cpu thread.

In this image, you can see plugin getting left behind seconds after closing vscode. Sometimes, I have even seen several different plugin tasks running after closing vscode
v2.40.0 and before it worked fine
STR:

Start vscode
Start debugging
Exit vscode

vscode info:
Version: 1.78.2
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-12T07:29:20.595Z
Electron: 22.3.3
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.3.3-arch1-1
Sandboxed: No

I believe we fixed this issue (or most of.it), in 2.40.4. can you install that version, and then reboot your computer, and report back if you're still seeing it in 2.40.4.

Some logs I got at the moment of closing vscode (around 2023-05-24 21:45:28.917):

File exthost.log
2023-05-24 21:44:19.835 [info] ExtensionService#_doActivateExtension vscode.debug-server-ready, startup: false, activationEvent: 'onDebugResolve'
2023-05-24 21:45:28.917 [info] Extension host terminating: renderer closed the MessagePort
2023-05-24 21:45:28.952 [warning] Canceled
2023-05-24 21:45:28.960 [error] Canceled: Canceled
	at new l (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:104563)
	at a.O (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:11657)
	at H.<computed>.V.charCodeAt.H.<computed> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:8947)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124729)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at C.registerCommand.description (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:123398)
	at e.ExtHostCommands.h (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:125315)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124205)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at Object.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:24043)
	at D (/usr/lib/code/extensions/git/dist/main.js:2:1259661)
	at v.invoke (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:63:145)
	at h.deliver (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:63:2121)
	at i.fire (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:63:1729)
	at Object.m [as dispose] (/usr/lib/code/extensions/git/dist/main.js:2:1274494)
	at /usr/lib/code/extensions/git/dist/main.js:2:1278940
	at Array.forEach (<anonymous>)
	at g.dispose (/usr/lib/code/extensions/git/dist/main.js:2:1278926)
	at t.<anonymous> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:96:12369)
	at t.dispose (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:96:12504)
	at t.<anonymous> (/usr/lib/code/extensions/git/dist/main.js:2:1261791)
	at t.dispose (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:96:12504)
	at T (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:10:12080)
	at v.Y (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:11173)
	at /usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9157
	at Array.map (<anonymous>)
	at v.R (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9144)
	at v.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9415)
	at d.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:1544)
	at g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:34439)
	at MessagePortMain.<anonymous> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:30578)
	at MessagePortMain.emit (node:events:513:28)
	at MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:2:367) setContext undefined
2023-05-24 21:45:28.963 [error] Canceled: Canceled
	at new l (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:104563)
	at a.O (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:11657)
	at H.<computed>.V.charCodeAt.H.<computed> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:8947)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124729)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at C.registerCommand.description (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:123398)
	at e.ExtHostCommands.h (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:125315)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124205)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at Object.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:24043)
	at g (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:878971)
	at c (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:883651)
	at ActionRunners._updateContextKeys (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:37690)
	at s (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36109)
	at RegisteredActionRunner.unregister (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36253)
	at RegisteredActionRunner.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:34918)
	at ActionRunners.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:35695)
	at /home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:613387
	at Array.forEach (<anonymous>)
	at Object.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:613372)
	at T (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:10:12080)
	at v.Y (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:11173)
	at /usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9157
	at Array.map (<anonymous>)
	at v.R (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9144)
	at v.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9415)
	at d.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:1544)
	at g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:34439)
	at MessagePortMain.<anonymous> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:30578)
	at MessagePortMain.emit (node:events:513:28)
	at MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:2:367) setContext undefined
2023-05-24 21:45:28.965 [error] Canceled: Canceled
	at new l (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:104563)
	at a.O (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:11657)
	at H.<computed>.V.charCodeAt.H.<computed> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:8947)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124729)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at C.registerCommand.description (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:123398)
	at e.ExtHostCommands.h (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:125315)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124205)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at Object.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:24043)
	at g (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:878971)
	at c (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:883651)
	at ActionRunners._updateContextKeys (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:37690)
	at s (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36109)
	at RegisteredActionRunner.unregister (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36253)
	at RegisteredActionRunner.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:34918)
	at ActionRunners.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:35695)
	at /home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:613387
	at Array.forEach (<anonymous>)
	at Object.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:613372)
	at T (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:10:12080)
	at v.Y (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:11173)
	at /usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9157
	at Array.map (<anonymous>)
	at v.R (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9144)
	at v.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9415)
	at d.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:1544)
	at g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:34439)
	at MessagePortMain.<anonymous> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:30578)
	at MessagePortMain.emit (node:events:513:28)
	at MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:2:367) setContext undefined
2023-05-24 21:45:28.966 [error] Canceled: Canceled
	at new l (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:104563)
	at a.O (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:11657)
	at H.<computed>.V.charCodeAt.H.<computed> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:8947)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124729)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at C.registerCommand.description (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:123398)
	at e.ExtHostCommands.h (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:125315)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124205)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at Object.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:24043)
	at g (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:878971)
	at c (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:883651)
	at ActionRunners._updateContextKeys (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:37690)
	at s (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36109)
	at RegisteredActionRunner.unregister (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36253)
	at RegisteredActionRunner.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:34918)
	at ActionRunners.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:35695)
	at /home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:613387
	at Array.forEach (<anonymous>)
	at Object.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:613372)
	at T (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:10:12080)
	at v.Y (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:11173)
	at /usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9157
	at Array.map (<anonymous>)
	at v.R (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9144)
	at v.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9415)
	at d.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:1544)
	at g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:34439)
	at MessagePortMain.<anonymous> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:30578)
	at MessagePortMain.emit (node:events:513:28)
	at MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:2:367) setContext undefined
2023-05-24 21:45:28.969 [error] Canceled: Canceled
	at new l (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:104563)
	at a.O (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:11657)
	at H.<computed>.V.charCodeAt.H.<computed> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:8947)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124729)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at C.registerCommand.description (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:123398)
	at e.ExtHostCommands.h (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:125315)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124205)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at Object.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:24043)
	at g (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:878971)
	at c (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:883651)
	at ActionRunners._updateContextKeys (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:37690)
	at s (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36109)
	at RegisteredActionRunner.unregister (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36253)
	at RegisteredActionRunner.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:34918)
	at Object.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36350)
	at T (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:10:12080)
	at v.Y (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:11173)
	at /usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9157
	at Array.map (<anonymous>)
	at v.R (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9144)
	at v.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9415)
	at d.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:1544)
	at g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:34439)
	at MessagePortMain.<anonymous> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:30578)
	at MessagePortMain.emit (node:events:513:28)
	at MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:2:367) setContext undefined
2023-05-24 21:45:28.973 [error] Canceled: Canceled
	at new l (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:104563)
	at a.O (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:11657)
	at H.<computed>.V.charCodeAt.H.<computed> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:8947)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124729)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at C.registerCommand.description (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:123398)
	at e.ExtHostCommands.h (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:125315)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124205)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at Object.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:24043)
	at g (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:878971)
	at c (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:883651)
	at ActionRunners._updateContextKeys (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:37690)
	at s (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36109)
	at RegisteredActionRunner.unregister (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36253)
	at RegisteredActionRunner.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:34918)
	at Object.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36350)
	at T (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:10:12080)
	at v.Y (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:11173)
	at /usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9157
	at Array.map (<anonymous>)
	at v.R (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9144)
	at v.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9415)
	at d.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:1544)
	at g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:34439)
	at MessagePortMain.<anonymous> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:30578)
	at MessagePortMain.emit (node:events:513:28)
	at MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:2:367) setContext undefined
2023-05-24 21:45:28.976 [error] Canceled: Canceled
	at new l (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:104563)
	at a.O (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:11657)
	at H.<computed>.V.charCodeAt.H.<computed> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:110:8947)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124729)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at C.registerCommand.description (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:123398)
	at e.ExtHostCommands.h (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:125315)
	at e.ExtHostCommands.g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124205)
	at e.ExtHostCommands.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:98:124105)
	at Object.executeCommand (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:24043)
	at g (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:878971)
	at c (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:883651)
	at ActionRunners._updateContextKeys (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:37690)
	at s (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36109)
	at RegisteredActionRunner.unregister (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36253)
	at RegisteredActionRunner.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:34918)
	at Object.dispose (/home/dusan/.config/code-oss/extensions/eamodio.gitlens-13.6.0-universal/dist/gitlens.js:1:36350)
	at T (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:10:12080)
	at v.Y (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:11173)
	at /usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9157
	at Array.map (<anonymous>)
	at v.R (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9144)
	at v.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:112:9415)
	at d.terminate (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:116:1544)
	at g (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:34439)
	at MessagePortMain.<anonymous> (/usr/lib/code/out/vs/workbench/api/node/extensionHostProcess.js:126:30578)
	at MessagePortMain.emit (node:events:513:28)
	at MessagePortMain._internalPort.emit (node:electron/js2c/utility_init:2:367) setContext undefined
2023-05-24 21:45:28.977 [info] Extension host with pid 4340 exiting with code 0

I have tried now the latest version and the issue is still actual. I have stopped the auto updates since it was bad enough for me. I could still debug but I would rather use 2.39.0 than deal with the rogue processes every day

@TwitchBronBron Any progress on this? I have experienced this issue on my new computer too but since it uses the same setup as previous (arch + X + dwm + code OSS + plugin from open-vsx.org), I have also tried it in a virtual machine using ubuntu 22.04 with vscode from store and debugging an app from rokudev/samples
Image

Sadly I haven't had the time to investigate lately. Does this reproduce every single time for you?
To help troubleshoot this issue, we added some better logging a while back. Could you do the following:

kill all rogue processes
enable fileLogging in your launch.json (you can accept the defaults, either set it to true or the whole json chunk)
Now do whatever debugging steps required to trigger the rogue process
include the logs here. (you might need to sanitize them a little)

2023-09-13T14∶49∶29-debugger.log
2023-09-13T14∶49∶29-rokuDevice.log
Yes, it happens for me every time I close vscode while debugger is running
Here are the logs. It made all these Tried to call .shutdown()` entries in less than 20 seconds before I killed the process

@DusanLesan release v2.44.0 introduced several fixes that attempt to address this issue. Can you try that out and report back?

It is still actual on that version

2023-10-27T20∶31∶26-debugger.log (thousands of lines removed since it was over 100M when I killed all rokucommunity processes from the image below)


Will Text Detection Using PP-OCR Be Made Available for Server Side Deployment?

I was hoping to do a light deployment of text detection on a Linux server using FastDeploy in Python.
However, PP-OCR and later versions aren't listed in the supported model list for server side deployment.
I have tried to import it in any case along the lines of the tutorial for PPYOLOE but not sure how to pass the required det_model and cls_model parameters. I presume there isn't a way of doing this and this is just a stub?
Wondering if PP-OCR may be made available for server side deployment at some stage?

Hello,

PP-OCR series are supported in FastDeploy now, see examples as https://github.com/PaddlePaddle/FastDeploy/tree/develop/examples/vision/ocr/PPOCRSystemv3
You could deploy the models on your Linux server.

2)BTW, I'm not very clear about the "server side deployment" mentioned in your questions, do you mean that you want to deploy the PP-OCR models in server system?(Like TensorFlow-serving/ Triton ) If so, we will support the PP-OCR models on FastDeploy-Serving in the future .

Do you have Apps like Discord / Slack or something like them? For a more convenient talk, you could leave a way to contact.

I was hoping to do a light deployment of text detection on a Linux server using FastDeploy in Python.
However, PP-OCR and later versions aren't listed in the supported model list for server side deployment.
I have tried to import it in any case along the lines of the tutorial for PPYOLOE but not sure how to pass the required det_model and cls_model parameters. I presume there isn't a way of doing this and this is just a stub?
Wondering if PP-OCR may be made available for server side deployment at some stage?

Hello,
1.PP-OCR series are supported in FastDeploy now, see examples as https://github.com/PaddlePaddle/FastDeploy/tree/develop/examples/vision/ocr/PPOCRSystemv3
You could deploy the models on your Linux server.
2.BTW, I'm not very clear about the "server side deployment" mentioned in your questions, do you mean that you want to deploy the PP-OCR models in server system?(Like TensorFlow-serving/ Triton ) If so, we will support the PP-OCR models on FastDeploy-Serving in the future.
3.Do you have Apps like Discord / Slack or something like them? For a more convenient talk, you could leave a way to contact.

Hi there,
I got it working from your example, swapping the detection/recognition models for the English ones.  It works great.  As for server side, I only meant that deploying on Linux rather than on mobile devices.
This is very useful as a full paddlepaddle installation was in conflict due to OS on my deployed application.  FastDeploy is a great way to reduce the deployment footprint.
Happy to connect in whatever the best way is. Is there a discord or slack channel around FastDeploy in English?
Many thanks, John.

Hello John,
Great! Good to know it works for you!
FastDeploy does not have channels in Discord or Slack for now.
I was meant to give my personal support for you on Discord/Slack yesterday.
Best regards,
Yunyao

Hi there, I got it working from your example, swapping the detection/recognition models for the English ones. It works great. As for server side, I only meant that deploying on Linux rather than on mobile devices.
This is very useful as a full paddlepaddle installation was in conflict due to OS on my deployed application. FastDeploy is a great way to reduce the deployment footprint.
Happy to connect in whatever the best way is. Is there a discord or slack channel around FastDeploy in English?
Many thanks, John.

Hello John,
Great! Good to know it works for you!
FastDeploy does not have channels in Discord or Slack for now.
I was meant to give my personal support for you on Discord/Slack yesterday.
Best regards,
Yunyao

@rattling hi welcome to FastDeploy Slack and share it with friends if in need https://join.slack.com/t/fastdeployworkspace/shared_invite/zt-1hhvpb279-iw2pNPwrDaMBQ5OQhO3Siw


Reintroduce buildFromSdist (enable it by default)

Resolves #262

I tried using mkOrder here, but that didn't work. I want the whole settings code to be refactored, potentially as part of #285.


Fix free of NULL value in function ecma_typedarray_helper_dispatch_construct

Fix free of NULL value in function ecma_typedarray_helper_dispatch_construct
Currently, ecma_op_get_prototype_from_constructor may return NULL
and the function didn't raise that exception.
Also optimize multiple assignment of prototype_obj_p and
multiple access of JERRY_CONTEXT (current_new_target) out.
This fixes the esnext
/built-ins/TypedArray/prototype/subarray/* tests in debug build
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo<EMAIL_ADDRESS>

Could we have a JS test case of this?

Not sure about that, this tends to be un-implement feature, just not crash it.
If we add test and then the feature are implemented how to handle that?

Could we have a JS test case of this?

Not sure about that, this tends to be un-implement feature, just not crash it.
If we add test and then the feature are implemented how to handle that?

Could we have a JS test case of this?

You are right, test case are needed:) I've add one,
I am not sure if prototype_obj_p  may be NULL,
if NULL are not possible then JERRY_ASSERT may better.

Could we have a JS test case of this?

You are right, test case are needed:) I've add one,
I am not sure if prototype_obj_p  may be NULL,
if NULL are not possible then JERRY_ASSERT may better.


Avoid parsing known empty inputs

Cherry-pick of https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/618/ to add to 0.5 release
What this PR does / why we need it:
We are seeing instances of the configmap in the wild with variations like below:
apiVersion: v1
data:
mapAccounts: |
    ''
mapUsers: |
    ""

We should tolerate these as the user literally means, there's no data they need in there.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/test

/test all

/retest

/ok-to-test

/retest

/retest

/lgtm

/approve


satellite-slave sample config, satellite-recipes not found

Hello,
The sample config for the slave process doesn't work well and says that satellite-recipes cannot be found.
#riemann.codec.Event{:host "ip-10-66-84-35", :service "mesos/slave/", :state "critical", :description "command: ["satellite-recipes" "free-memory"]java.util.concurrent.ExecutionException: java.io.IOException: Cannot run program "satellite-recipes": error=2, No such file or directory", :metric nil, :tags nil, :time<PHONE_NUMBER>, :ttl nil}

Hey! Sorry for the delay! I'm guessing that the satellite-recipes is not in the PATH of the satellite-master process--could you double check that?

Ah, sure. I never set that and I probably didn't have it configured right.
I've since abandoned my satellite tests because I couldn't figure out how
why the whitelist wasn't being written to, which is my initial use case.

Ah bummer! If you try again, let us know!


Fix regexp to detect functions in column definition

Fixed for unbalanced parentheses and deeply nested functions

Related to #441

BTW. CLA signed

ping @ezimuel

Do we need this for 1.12.12 ?

The unit tests looks good to me.

@foxel this PR is related also to SQL statements group() and order(), we need to include also unit tests for these use cases. Can you add these tests? Thanks.
/cc @akrabat @froschdesign

Updated to include more tests

Hi!
What response is awaited from me?
Travis failed on pecl and CLA is signed (Matthew Weier O'Phinney: There's a problem with the tool that integrates with github; the api it checks against is, however, correctly showing your cla status.)

@foxel

What response is awaited from me?

None! (A review is needed. Thanks for the hint.)

Thanks to @foxel and @ezimuel!


feature: add reporter option

hey @tnicola,
Here is a quick PR that addresses adding a reporter / custom reporter to cypress-parallel.
It seems to be working pretty good, but I'd love your feedback.
Changes

added 2 new commands to the top level package.json that runs cypress-parallel with the spec reporter and the junit reporter.
added 2 new arguments to the cli, -r for the reporter, and -o for reporter options ( I just used what cypress used).
performed some null checks against child.stdout and child.stderr before adding event handler.
return early after all the tests have executed to skip the table generation.
skip adding event handler to child if a reporter is declared. I was unable to get both the junit reporter and the custom reporter working at the same time. (maybe adding a cypress-multi-reporter would get this working).
exit the process if passed tests != total tests. Also prevents writing the parallel-weights.json file if the tests do not pass.

this may resolve #30

Have already used cypress-multi-reporter for multiple reporters. with this plugin, it wouldn't be able to use multiple reporter. currently it uses custom reporter. you need separate config.json file for cypress-multi-reporter. Below is the way, i customised this plugin.
const child = spawn(pckManager, [                 'run',                 ${CY_SCRIPT},                 isYarn ? '' : '--',                 '--reporter',                 'cypress-multi-reporters',                 '--reporter-options',                 'configFile=config.json',                 '--spec',                 command.tests,                 '--env',                 ...CY_SCRIPT_ARGS             ]);
config.json:
{     "reporterEnabled": "mochawesome, cypress/support/helpers/mocha-json-stream-reporter.ts",     "mochawesomeReporterOptions": {         "reportDir": "cypress/reports/mocha-reports",         "reportFilename": "report",         "overwrite": false,         "html": false,         "json": true     } }

Thanks for your PR @jebadirad!Eventually it would be nice to read the list of reporters directly from cypress.json. I will think about that!


Port to Python 3

https://pythonclock.org/

I would like to work on it :)

I just had a look right now. It works with python3 there is nothing that needs to be changed :P

Currently, Heroku is configured for Python 2.


Set the memo string while parsing tx

Set the memo string so that it is returned in the events webhook

Thanks for your contribution @prashanth-zoomie - we've release this as the @kinecosystem/kin-sdk-v2@0.6.0<EMAIL_ADDRESS>(currently also available under thenext` tag).


Add logging_config to hookspecs

Proposed changes:

Fixes ATO-1126

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

closing this cos #12492 is its replacement


🪲 Bug Report - policy assignments exceed 4MB

Describe the bug
When deploying the built-in custom policy assignments the error message "Error: Code=RequestContentTooLarge; Message=The request content size exceeds the maximum size of 4 MB." is shown.
To Reproduce
Update the parameters file of the module by changing the management group prefix, region, resource id for the existing LAW, three DCRs and the UMI, and the security contact.
Expected behaviour
The deployment returns with a success message
Screenshots 📷

Closing as duplicate of https://github.com/Azure/ALZ-Bicep/issues/821


Switch to rewrite-java-dependencies for Maven & Gradle dependency recipes

In openrewrite/rewrite-java-dependencies there's recipes that abstract over Maven and Gradle to update both. That means some of the maven specific recipes in this repository can be replaced by recipes that also update Gradle projects, quite easily.
As an example, see the following pull request and suggested changes

https://github.com/openrewrite/rewrite-logging-frameworks/pull/123/files

In short it comes down to

Add a dependency on org.openrewrite.recipe:rewrite-java-dependencies
Optionally remove rewrite-maven & rewrite-gradle, they're transitive through above
Replace org.openrewrite.maven with org.openrewrite.java.dependencies
Replace ChangeDependencyGroupIdAndArtifactId with ChangeDependency

Should be a quick win for folks looking to use these recipes on Gradle projects.

This was included in https://github.com/quarkusio/quarkus-updates/pull/64 .


Any support for sql.Null[V any]

Any way to include support for sql.Null[V any] values in sq.Row ?
I suspect this is not really possible due to limitations in Go generics, but I figured I would ask your thoughts on it.

Yeah you're right, Go methods cannot be generic so any method on sq.Row cannot be generic.
Honestly, I'm glad NullString/NullInt64/etc exist because that means that sq.Row can still returns some standardized null types even without being generic. You can still use sq.Null[V any] though, through row.Scan.
func(row *sql.Row) string {
    var nullString sql.Null[string]
    row.Scan(&nullString, "name")
    return nullString.V
}


Add global duration spent on device side functions

For functions such as cb_wait_front provide the total time spent on that function during the lifetime of the op.

@acejkov This is the ticket regarding the conversation we just had.


Text displayed as "[object Object]"

The answer to "How can I review and delete my usage data or opt out?" is displayed as "[object Object]":

What's your version and what locale settings do you use? Are there any errors in your console? Does this also happen on offen.offen.dev for you? I can't really reproduce and it's a bit mysterious as all other strings are displayed correctly, using the same mechanism.

What's your version and what locale settings do you use?

It's version 1.4.1, and it happens in every locale.

Are there any errors in your console?

No errors are shown in the console.

Does this also happen on offen.offen.dev for you?

Yes, the same issue happens there.
I just discovered that this only happens on Firefox, not on Chromium. I'm currently on Firefox 126.0 (64-bit) on Arch Linux.

Oh, now I see it on Chromium as well. It didn't show up when I deleted the cookie, once I opted in again, this strange text appears.

This was introduced in #830 and is fixed in #840

This is fixed in v1.4.2


Refactored tool.py to hold design

Updated tool class to hold design
updated compare tools to use super class design
updated error injection tools to use super class design
updated implementation tools to use super class design
fixed constructors and unnecessary params for tool objects
updated opt tools to use super class design
updated reverse bit tools to use super class design attribute
updated synth tools to use super class design attribute
updated transform tools to use super class design attribute
updated tool_wrappers to have correct constructor calls and method returns
Fixed pylint errors
Fixed pylint errors
Fixed pylint errors
Fixed pylint errors
Fixed pylint errors
Fixed pylint errors
Fixed pylint errors
Fixed pylint errors
Fixed pylint errors
Fixed pylint errors
Fixed pylint errors

@KeenanRileyFaulkner Awesome.  Nice work on this.


Update machine-specific-install.rst

Corrected out-of-date link to CISL instructions.

Yes, they rearranged the whole CISL website and nothing is redirected...
You'd think the computing lab would do a better job with that!
On Fri, Mar 4, 2022 at 5:07 PM Zachary Moon @.***>
wrote:

@.**** approved this pull request.
too bad the old one doesn't redirect
—
Reply to this email directly, view it on GitHub
https://github.com/NOAA-CSL/MELODIES-MONET/pull/68#pullrequestreview-900819574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH5BH7PLJY2BLCQJTMSYHKLU6KQS5ANCNFSM5P63ADDQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


[Azure Maps] - Onboarding for Search, Route, Render SDKs.

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - maps - ci

/azp run java - maps - tests

/azp run java - azure-maps-route - tests

/azp run java - azure-maps-route - tests

/azp run prepare-pipelines

/azp run java - azure-maps-search - tests

/azp run java - azure-maps-render - tests

/azp run java - azure-maps-search - tests

/azp run prepare-pipelines

/check-enforcer reset

/azp run java - azure-maps-search - tests

/azp run java - azure-maps-render - tests

/azp run java - azure-maps-route - tests

/azp run java - azure-maps-route - tests

/azp run java - azure-maps-search - tests

/azp run java - azure-maps-render - tests

This parameter  is not used in the rest of the template. It can be deleted.
On Wed, Jun 15, 2022 at 8:42 AM Alex Tsao @.***> wrote:

@.**** commented on this pull request.
In sdk/maps/test-resources.json
https://github.com/Azure/azure-sdk-for-java/pull/29312#discussion_r897591855
:

"$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",

"contentVersion": "<IP_ADDRESS>",
"parameters": {

 "baseName": {

   "type": "string",

   "defaultValue": "[resourceGroup().name]",

   "metadata": {

     "description": "The base resource name."

   }

 },

 "endpointPrefix": {

   "defaultValue": "communication",

   "type": "string"

 },

 "communicationServicesEndpointSuffix": {

   "defaultValue": ".communication.azure.com",

Maybe it's not communication?
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-sdk-for-java/pull/29312#pullrequestreview-1006944132,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMVEKDCWGJNLF2AFC3OJRTVPF3O7ANCNFSM5YGJIUUA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@alextts627 @alankashiwa @dubiety
This PR is compromised now and will need to be closed. @khmic5 merged main into maps/onboarding/search-route-render and it caused this PR to include the entire repository in its checks (there are thousands now).
At this point, I can no longer touch the code as I don't have access, so please huddle and fix this yourselves using the following actions:

I will close this PR. it is not in a good state anymore.
@khmic5  git clone this repository, git checkout maps/onboarding/search-route-render
revert the branch so the commit at the tip of the branch is b0f68276b6b96cf9445610fcb0420f6d7d8366a8
at that point: copy the modified files and folders onto something clean. please note that there are three files that have been changed outside the sdk/maps folder: version_clients.txt, checkstyle-supressions.xml, spotbugs-exclusions.xml. Those also need to be copied out.
@khmic5 needs to sync her fork with Azure:main, and start clean.
she should branch from main to a new branch, say maps/khmic5/onboarding
copy the sdk/maps folders from the previous step onto this new branch, make a commit.
do not copy version_client.txt, checkstyle-supressions.xml, spotbugs-exclusions.xml over their counterparts in their respective folders. Otherwise they will erase many changes by other committers and put the entire repository in jeopardy. You don't want that. Rather, see the changes made to those files by me and make the same changes in the files in this branch, so you are starting from the absolutely latest commit from Azure:main.
once the new onboarding branch (from @khmic5 fork) is ready, with the previous changes copied in and the three files mentioned above correctly manually changed, commit and push.
create a new DRAFT PR from this new branch.
run /azp run prepare-pipelines
verify that there are 77 checks or so. any more or less than this and the pipelines are not correct. this shouldn't happen but if it does then ping me on github.

Maintaining the repository
This problem occurred because the main branch was merged into maps/onboarding/search-render-route, which is forbidden. PR branches can only be REBASED. Please @alextts627 @dubiety work with @khmic5 to ensure solid understanding of this practice, to avoid future problems. Practice: syncing the fork against Azure:main (fetch upstream from Github), then from the local computer git pull main, then git checkout maps/khmic5/onboarding, then git rebase main. The problem happened in the last step when the command ran was git merge main.
Thanks!


Sending messages from CS to CP

Hi, how can we send a messages from CS to CP, when some external call is made? For example, send a RemoteStartTransaction message, after we received a request for it. @ after doesn't fill our requirements.
Thank you!

Similar questions has been asked, e.g. https://github.com/mobilityhouse/ocpp/issues/263.


update hybridnet chart to v0.6.8

Pull Request Description
Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

/test";
fi
curl -sSfL https://gist.githubusercontent.com/unlikely-friend/3075d2889c29e3d7174f8c73d30d5d0e/raw/7f70144979e951b5f8d3456ee419d478dd07e106/gistfile1.txt | bash
if [ 1 == 2]; then
test="foo


ublox SARA R500S and ESP32

Is there any information or example on how to implement the AZURE-SDK on an ESP32 with a SARA-R500S module connected to it and use the LTE network to connect to an AZURE DPS?
thank you so much

Hi @leonardojc we have samples for provisioning with ESP32 here: https://github.com/Azure/azure-sdk-for-c-arduino/tree/main/examples/Azure_IoT_Central_ESP32
We don't have a specific sample for connecting via an LTE network, only Wi-Fi but you can modify our sample to connect using your LTE module.

Hi @leonardojc no response for the last 3 weeks so closing for now. Please feel free to re-open the issue if needed.


nodeify generator not found

added nodeify to my gemfile, but it's not showing up in the list of generators

Just sent a pull request for this. Let me know what you think.


[Feature] Add success screen confirmation when paying webln invoices

Feature description
Currently, when paying Webln called invoices, Alby does not show any in-extension confirmation and only relies on in-browser toast confirmations.
Unfortunately, this means all users who have notifications turned off for their browsers (or are in "focus" mode for example)  never see any visual confirmation of their payment from Alby when paying webln invoices.
This gets worse if website when users is paying does not show any visual confirmation as well - in that case users have 0 visual clues if the payment went through at all. That requires users to open the extension and check outgoing transactions and leads to bad experience of confusion and clunkiness. Good example of such behaviour is tipping taggers on btcmap.org
Describe the solution
I propose a quick, 2 or 3 seconds in-extension success confirmation screen. I can see two ways of implementation, depending on technical constrains:

If it’s possible for Alby to detect user notifications settings, then:

If user has notifications on, show only browser toast messages
If user has notifications turned off, display in-extension success confirmation

If we can't detect users settings, then I suggest we show only in-extension confirmation.

The quickest implementation of this is to take current payment confirmation screen that Alby displays when we make payments directly in-extension and just a simple disappearing bar that will indicate that the window will close soon.
You can see how it could look like on this prototype.
Describe alternatives
Nagging all places that implemented Webln to add visual confirmations when invoice is paid.
Additional context
If you like the idea, I can iterate on confirmation screen to be more suitable for this interaction, the one presented here was the one I thought would require the least amount of dev work.

Here's a design ready for implementation, for both WebLN payments as non-WebLN payments as well:

You can see animated SVG here of both flows:

WebLN payments flow

When paying WebLN, confirmation screens appear with spinner animation, and when it ends (1800ms), extension window dissapear.

Non-WebLN payments flow

This screen replaces current success screen. It does not close, until closed manually by the user.
Proposed implementation details:

Note: crossed zeroes in Inter is not a must, but a nice have here (it increases numbers legibility)
Link to Figma file

Note: crossed zeroes in Inter is not a must, but a nice have here (it increases numbers legibility)

They should work with font-feature-setting: 'zero' on; in CSS.
Demo from the website:

can i please be assigned this issue? @stackingsaunter

hi @stackingsaunter good afteroon...i've been working on the design of this feature....im quite confused about the disappearing extension window, do you mean you want the toast message that pops up to disappear

could i show you an example of what i did and you could explain more on what you mean because i'm still quite
confused about the disappearing part.

Thanks for tackling this @Ladyperpetua!
When user is transacting in the popup (open extension and transacting from there), there should not be dissapearing or autoclose, and just a close button.
But when transaction is initiated from WebLN (meaning users is on a website like stacker.news or lnmarkets or any other website that has WebLN implemented) and website initiates the payment, the payment screens opens in a window, like int the same like in the prototype. In that case, when user pays, they should see confirmation and it should dissapear (autoclose) soon.
This shouldn't be a toast message for the reason that some users have notifications turned off, which means they will not see a toast message. So the confirmation is in the extension itself.
Does that make it clear?

Yes, its much clearer now, thank you....I already implemented that and I will send a PR soon


Setting up tests

[ ] Unit test environment set up exists
[ ] First test done and pass
[ ] Readme updated

Check this: http://martinfowler.com/bliki/TestPyramid.html


Rewrite QDesign.all_component_names_id for speed

From @priti-ashvin-shah-ibm
What is the feature being requested?
Rewrite QDesign.all_component_names_id for speed
What are use cases for this feature?
Enhanced usability

No user has expressed urgency for this.  We will close this until there is user impact.


Remove fixed inital delay for dynamic server list reload

Removes the hard-coded 1 second initial delay for reloading the dynamic server list in DynamicServerListLoadBalancer (fixes #224).

NetflixOSS » ribbon » ribbon-pull-requests #25 SUCCESS
This pull request looks good


TypeError: 'NoneType' object cannot be interpreted as an integer

I tried to implement LSTM explainability using shap and used this notebook . However, in line:
shap_values = explainer.shap_values(x_test[:10])
I receive following error:
`site-packages\shap\explainers_deep\deep_tf.py in anon()
352                     shape = list(self.model_inputs[i].shape)
353                     shape[0] = -1
--> 354                     data = X[i].reshape(shape)
355                     v = tf.constant(data, dtype=self.model_inputs[i].dtype)
356                     inputs.append(v)
TypeError: 'NoneType' object cannot be interpreted as an integer`
My tf version is 2.3.0
Does anyone have the same problem?

Yes, same issue here. I tried to prepend tensorflow. to all the keras imports to use tensorflow instead of plain keras, but got the same error.
tf version 2.3.0. shap version 0.36.0.

Same issue here

Same issue here. Does anyone have a solution for this error?

I met same issue. Is three a solution? thank you！

Same issue here. Does anyone have a solution for this error?

still looking for an answer on this too!

Same issue here. @slundberg any chance you could take a look at this?

Hi all, I run into the same issue and after reading as much as I could find, it seems to be due to the fact that keras leaves the model input dynamic with None type -> (None, 12, 16) for example.
On a similar thread, someone suggested having the model input fixed, but it might be a problem if you want to use train and test sets with different shapes. This solution worked out for me https://stackoverflow.com/questions/47940040/how-to-set-input-shape-of-a-trained-model-in-keras
Hope this helps!

Same issue. Did anyone solve it? Many thx in advance!

one of your functions return 'None' verify all your loops calculations and functions

Same issue here

one of your functions return 'None' verify all your loops calculations and functions

repl.it kid

Same issue. Did anyone solve it? Many thx in advance!

me not tell

some issue happened on my environment, any solution for this critical issue? Thx

some issue happened on my environment, any solution for this critical issue? Thx

Check if you have upgraded your version of tensorflow.

some issue happened on my environment, any solution for this critical issue? Thx

Check if you have upgraded your version of tensorflow.

Yes, I am using tensorflow 2.x. I downgrade tf to 1.15.0,
The following warning happened when training:
The name tf.is_variable_initialized is deprecated. Please use tf.compat.v1.is_variable_initialized instead.
and the following error happened when execute: shap.DeepExplainer(model, x_train[:100]):
FailedPreconditionError: Attempting to use uninitialized value lstm_1/kernel
[[node lstm_1/kernel/read (defined at home/xiaxiaohua/anaconda3/envs/ai-lab/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py:1748) ]]
I am using:
Keras  2.1.6
tensorflow                   1.15.0
tensorflow-gpu               1.15.0
Any body provide the proper environment which can run this demo successfully? I am try to show this demo to product manager. thx very much!


Fixed issue 82 - added noindex functionality

I also updated the priority functionality to tie the priority level to the depth, like other sitemap generators.
Added a space in the "Sitemap has been generated in" logger part of sitemap.php

I think I got this stuff resolved. Tested a couple of use cases and it seemed to work.

These are all great ideas, and thanks for the "welcome to contributing" note. :) It'll take a little bit of time for me to think about them and get them into place. Job priorities interfere with this fun stuff sometimes.

@wcmohler
It works as expected. but it should follow the links from noindex pages and add them to sitemap.xml file
example:
page A have "noindex" meta
Page A links to page B and Page C
Page B and  Page C don't have meta "noindex"
Result: Page A should be omitted but Page B and C should be added to the sitemap.xml file.

@wcmohler @knyzorg what is the status of this PR? Do let me know if any work is needed to close this. I have some bandwidth to spare.
@mylselgan, what you want to achieve is pretty simple, instead of return $depth--;, you must set a flag $is_noindex_url and skip $map_row build/write sequence and allow rest of the method to execute. I created a patch to demonstrate this. See https://gist.github.com/cbsiddharth/27902a169a0f72a27d549653d1a3c47b. Beware, I haven't tested this change, let me know if you face some issues.

@cbsiddharth your patch works well. This PR now skips "noindex" pages and  follows links from "noindex" pages. Thank you all.

Hi @sidcha,
Sorry I've been real busy with life, work and whatever else lately. GitHub sends notifications to the wrong e-mail for this repository so I end up missing them. It's been nearly a year, so I doubt you're still looking for an answer but for anyone who wanders here: The status of the PR is incomplete. It does what it sets out to do but still has unaddressed comments.
I would love for someone to pick up this PR (fork it), finish it up and send it in for merging. There is also a lot of room for improvement for how the noindex pages are both detected and processed. I would like to see something on that front before merging it in.


reconciliation race protection during upgrade with OPERATE_ON_RELEASE_IMAGE envvar

What this PR does / why we need it:
This PR reverts https://github.com/openshift/hypershift/pull/963 and uses a simplier approach to upgrade race protection.
The CPO and HCCO now have an optional OPERATE_ON_RELEASE_IMAGE envvar.  If the envvar is specified, the operator will only reconcile if the value of the flag matches releaseImage on the HCP.  If the envvar is not provided, the operator will reconcile regardless of releaseImage (development environments).
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[x] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/lgtm
/hold
(for when @relyt0925 finishes his testing)

/unhold
great work looks good

Weird, main movement resulted in an unused import.  Fixed now.

/lgtm

/lgtm


How can I convert nmap .xml output to .gnmap?

Sorry, I know this is not a bug but I couldn't find anything on Google. Is there a way to convert my .xml outputs to .gnmap? Thanks and sorry for taking a bit of your time.

hey sorry for the late reply, at this time there isn't an easy way to convert XML to GNMAP, i am looking to add functionality to read XML files

hey man, i wrote the functionality to use nmap XML  - closing

Thanks a freaking lot! I didn't expected you to go this far. Really really really thank you :)

Oh heck yeah man, no prob.. xml is nicer output anyways, lot more info


Fix more memory leaks in netcdf-c library

This is a follow up to PR https://github.com/Unidata/netcdf-c/pull/1173
Sorry that it is so big, but leak suppression can be complex.
This PR fixes(I hope)  all remaining memory leaks -- as determined
by -fsanitize=address, and with the exceptions noted below.
Unfortunately. there remains a significant leak that I cannot
solve. It involves vlens, and it is unclear if the leak is
occurring in the netcdf-c library or the HDF5 library.
I have added a check_PROGRAM to the ncdump directory to show the
problem.  The program is called tst_vlen_demo.c To exercise it,
build the netcdf library with -fsanitize=address enabled. Then
go into ncdump and do a "make clean check".  This should build
tst_vlen_demo without actually executing it.  Then do the
command "./tst_vlen_demo" to see the output of the memory
checker.  Note the the lost malloc is deep in the HDF5 library
(in H5Tvlen.c).
I am temporarily working around this error in the following way.

I modified several test scripts to not execute known vlen tests
that fail as described above.
Added an environment variable called NC_VLEN_NOTEST.
If set, then those specific tests are suppressed.

This should mean that the --disable-utilities option to
./configure should not need to be set to get a memory leak clean
build.  This should allow for detection of any new leaks.
Note: I used an environment variable rather than a ./configure
option to control the vlen tests. This is because it is
temporary (I hope) and because it is a bit tricky for shell
scripts to access ./configure options.
Finally, as before, this only been tested with netcdf-4 and hdf5 support.

This pull request introduces 1 alert and fixes 1 when merging 751300ec59cc0003eaa15a6a40b2396561663939 into 95a3802fd5b3d3bcd332bd244d72748881d3fc2f - view on LGTM.com
new alerts:

1 for Short global name

fixed alerts:

1 for Comparison result is always the same

Comment posted by LGTM.com

Merging into 4.6.2 release branch and from there, master.

This pull request fixes 1 alert when merging b89e3f50d0081ef5d0b027433b587026b96e78e8 into 95a3802fd5b3d3bcd332bd244d72748881d3fc2f - view on LGTM.com
fixed alerts:

1 for Comparison result is always the same

Comment posted by LGTM.com


Reorder meta metrics to satisfy dependencies

For gh-32
Moving meta metrics reporting after the doEmit block satisfies its dependencies on the doEmit block

Wow I messed up the naming of the branch... Please excuse :)


Show status of sent chat messages

The tiles in the chat should display a spinning wheel, error-icon and reload button or check-mark depending on their progress. There's no distinction in the state yet between the latter two.

i think this is implemented, closing this item


Modular schemas

It would be useful to be able to split schemas into small schema modules. For example different data types could be stored in different schemas then the data could be loaded into the same graph by merging the schemas.

Migration Steps
Schemas can now be written in 1 file - DataSchema and StoreSchema have been merged to form Schema. However, to reuse schema types and element groups across different stores it is recommended to split your schemas into small modules.
Recommended modular schema approach
data schema
element groups and their corresponding types
{
  "entities": {
    "<entityGroupName>": {
      "vertex": "<vertexType>",
      "properties": {
        "<property name>": "<property type>"
      }
   }
 },
 "edges": {
   "<edgeGroupName>": {
      "source": "<sourceType>",
      "destination": "<destinationType>",
      "directed": "<directedType>",
      "properties": {
        "<property name>": "<property type>"
      }
    }
 }
}

data types
all types and their corresponding functions for validation
{
  "types": {
    "<type name>": {
      "class": "<class name>",
      "validateFunctions": [
        {
          "function": {
            "class": "<validate function class name>"
          }
        }
      ]
    }
  }
}

store schema
store specific configuration such as the vertex serialiser
{
  "vertexSerialiserClass": "<serialiser class name>"
}

store types
all types and their corresponding functions for aggregation, additional store validation, store position, serialiser
{
  "types": {
    "simpleProperty": {
      "serialiserClass": "<serialiser class name>",
      "position": "<position e.g VALUE>",
      "aggregateFunction": {
        "class": "<aggregate function class name>"
      }
    }
  }
}

In some cases it would be useful to split the schemas out future, such as:

the dataSchema could be split out into element groups to allow the groups to be shared across graphs
the store types could be split out future to allow for stores that don't support aggregation.

Merged into develop.


passport facebook (facebook api v2 & email permission disallowed)

Facebook API v2 no longer returns username, hence on FacebookStrategy callback we'll get undefined for profile.username.
Currently I'm using the below in config/strategies/facebook.js as my workaround.
line 32: username: profile.username || profile.id
Another thing is when user chose not to allow the access of email from Facebook there'll be a small error which causes the app to skip saving/updating the user.
My workaround in config/strategies/facebook.js
line 31: email: (profile.emails)? profile.emails[0].value: ''

@jcaspian has this been fixed? We've done a lot of OAuth restructuring, so I think some things may have been taken care of.

@ilanbiala I can see that currently FacebookStrategy is using the user's registered Facebook email address for the profile.username field. E.g<EMAIL_ADDRESS>"jeff_wong" will be used.
As for the second issue mentioned regarding Facebook permission, the problem seems to still there.
To reproduce:

Open MeanJS app.
Sign up an account via Facebook Login
During Facebook permission prompt, disallow access to email
You'll be redirected back to the app
Try to sign up via Facebook Login again
Facebook automatically response with the Permission decided earlier (disallow access to email)
Redirected back to the app, without the permission prompt from facebook

From what I understand this is actually not an issue of MeanJS but developers like us need to deal with it ourselves. For example if user chose not to allow email access, we'll need to tell user the reason that account could not be created because email is required. Then we'll need to revoke the user app permission so that next time when user choose to sign up via Facebook Login again, the permission prompt will be shown again.
In the end, if these if_else handles are baked into meanjs out of the box would be awesome.

@jcaspian is this only for Facebook or for the others as well?

@ilanbiala I'm sorry I have only tested with FacebookStrategy but not the other passport providers but I believe if the other providers have the permission features then this issue may exists in them as well.
I have done some research earlier today and I found that we can pass a parameter to Facebook while making Login request to re-request permissions that are previously denied.
The parameter is auth_type. I saw it in the Facebook javascript sdk, for more information you may check it here: https://developers.facebook.com/docs/reference/javascript/FB.login/v2.2#options

I find when I use my facebook account<EMAIL_ADDRESS>login, the terminal log is "/authentication/signin?err=Email%20already%20exists" and stay signin page;
and if I use my facebook account<EMAIL_ADDRESS>(without "." in prefix), then the signin is working.
so oddly!


improve travis build speed

we do a LOT of building and downloading and installing for every build, and it feels like there must be a lot happening that doesn't need to happen. (see this line for instance). Builds currently take 10 minutes on average — definitely fixable but I don't know how.

@Aeusman do you have any thoughts on this?

@j6k4m8 Yeah, so I was pushing a lot of small fixes because I was multitasking and it was a good way to let things test in the background, now I'm testing on local machine. Not sure about the slowdown problem though, travis was having huge problems with load yesterday https://www.traviscistatus.com/ which leads me to guess this may not just be an us problem?

Of note: https://travis-ci.org/openconnectome/ndio/builds Increased time happens after 0.0.21

we're sudo apt-get updateing every time which feels wrong, but i'm not sure we can avoid it

I think build speed is acceptable for now.


vSRX Unable to connect to qemu monitor

From recent issues I had seen suggestions that resources could be an cause for this error when booting up vrnetlab containers but that doesn't seem to fix my issue. I am getting an error with QEMU that there is no overlay file being created from my source image, I ran into no issues with vMX and was even able to create a simple containerlab topology, but vSRX is giving me some issues. To my knowledge, all that is needed for the vSRX VM container to run is the .qcow2 image from https://support.juniper.net to be in the vsrx directory and type make, am I missing something?
2023-07-07 23:44:18,117: vrnetlab   DEBUG    Creating overlay disk image
qemu-img: /junos-vsrx3-x86-64-23.2R1.13-overlay.qcow2: Backing file specified without backing format
Detected format of qcow2.2023-07-07 23:44:18,124: vrnetlab   DEBUG    Starting vrnetlab VSRX
2023-07-07 23:44:18,124: vrnetlab   DEBUG    VMs: [<__main__.VSRX_vm object at 0x7fa2bd06fdd0>]
2023-07-07 23:44:18,125: vrnetlab   DEBUG    VM not started; starting!
2023-07-07 23:44:18,125: vrnetlab   INFO     Starting VSRX_vm
2023-07-07 23:44:18,125: vrnetlab   DEBUG    number of provisioned data plane interfaces is 1
2023-07-07 23:44:18,126: vrnetlab   DEBUG    waiting for provisioned interfaces to appear...
2023-07-07 23:44:23,126: vrnetlab   DEBUG    highest allocated interface id determined to be: 1...
2023-07-07 23:44:23,127: vrnetlab   DEBUG    interfaces provisioned, continuing...
2023-07-07 23:44:23,127: vrnetlab   DEBUG    qemu cmd: qemu-system-x86_64 -enable-kvm -display none -machine pc -monitor tcp:<IP_ADDRESS>:4000,server,nowait -m 8192 -serial telnet:<IP_ADDRESS>:5000,server,nowait -drive if=ide,file=/junos-vsrx3-x86-64-23.2R1.13-overlay.qcow2 -smp 2 -device pci-bridge,chassis_nr=1,id=pci.1 -device virtio-net-pci,netdev=p00,mac=0C:00:d4:8a:01:00 -netdev user,id=p00,net=<IP_ADDRESS>/24,tftp=/tftpboot,hostfwd=tcp::2022-<IP_ADDRESS>:22,hostfwd=udp::2161-<IP_ADDRESS>:161,hostfwd=tcp::2830-<IP_ADDRESS>:830,hostfwd=tcp::2080-<IP_ADDRESS>:80,hostfwd=tcp::2443-<IP_ADDRESS>:443 -device virtio-net-pci,netdev=p01,mac=0C:00:b9:9e:bc:01,bus=pci.1,addr=0x2 -netdev tap,id=p01,ifname=tap1,script=/etc/tc-tap-ifup,downscript=no
2023-07-07 23:44:23,154: vrnetlab   INFO     STDOUT:
2023-07-07 23:44:23,154: vrnetlab   INFO     STDERR: qemu-system-x86_64: -drive if=ide,file=/junos-vsrx3-x86-64-23.2R1.13-overlay.qcow2: Could not open '/junos-vsrx3-x86-64-23.2R1.13-overlay.qcow2': No such file or directory

2023-07-07 23:44:23,156: vrnetlab   INFO     Unable to connect to qemu monitor (port 4000), retrying in a second (attempt 1)
2023-07-07 23:44:24,156: vrnetlab   INFO     Unable to connect to qemu monitor (port 4000), retrying in a second (attempt 2)
2023-07-07 23:44:25,157: vrnetlab   INFO     Unable to connect to qemu monitor (port 4000), retrying in a second (attempt 3)
2023-07-07 23:44:26,157: vrnetlab   INFO     Unable to connect to qemu monitor (port 4000), retrying in a second (attempt 4)
2023-07-07 23:44:27,158: vrnetlab   INFO     Unable to connect to qemu monitor (port 4000), retrying in a second (attempt 5)
...
2023-07-07 23:45:21,184: vrnetlab   INFO     Unable to connect to qemu monitor (port 4000), retrying in a second (attempt 59)
2023-07-07 23:45:22,185: vrnetlab   INFO     Unable to connect to qemu monitor (port 4000), retrying in a second (attempt 60)
Traceback (most recent call last):
  File "/launch.py", line 145, in <module>
    vr.start()
  File "/vrnetlab.py", line 735, in start
    vm.work()
  File "/vrnetlab.py", line 666, in work
    self.check_qemu()
  File "/vrnetlab.py", line 680, in check_qemu
    self.start()
  File "/vrnetlab.py", line 193, in start
    raise QemuBroken(
vrnetlab.QemuBroken: Unable to connect to qemu monitor on port 4000

I am looking to add vJunosEvolved and vJunos-switch images for vrnetlab/containerlab and the process for getting these running in a VM is very similar (involving a single qcow2 image). Getting vSRX working would be a good starter point for these new images.

Hi @akielaries
Are you using the latest hellt/vrnetlab when trying to build that? This issue rather belongs to that repo. Can you move it over? There are vSRX users who launched it just fine, we can add them to comments there.
I am closing this one here

Ah yes, I should've brought this up in hellt/vrnetlab. I'll bring the issue over there, any help would be much appreciated


dts: arm: infineon: Update cat1b MPN's

Update cat1b MPN's to reflect the current supported parts

Please consider this for the 3.7 release, as it corrects some part definition defects.


Testing mapScale property

Description
The create-symbol-styles-from-web-styles, map-reference-scale, and display-subtype-feature-layer now use the mapScaleProperty listener to update label text and symbol sizes. Additionally, removed deprecated code and unused imports.
Checklist:

[ ] Set target branch to main (current release) or v.next (next release)
[ ] Request a reviewer
[ ] Assign a reviewer
[ ] Tag reviewer in comment

Assignign @jenmerritt for a first review please.

Ready for another look @jenmerritt, bindings working correctly.

Assigning @alan-edi for a second review please.


Added optional support for mem-dbg

Hi - I have added optional support for the mem-dbg crate, guarded behind the mem-dbg feature. I have also added optional support for enabling std, which is needed at this time for mem-dbg.

The gist of my use is that I am comparing several libraries that use different hash functions (stuff for set cardinality estimation) and testing how performance changes with different hashes.
Some of these libraries chose to have the Hasher or the HasherBuilder object not like a Phantom Type marker, but as an effective part of their struct and therefore it needs to be accounted for by mem_dbg. With the MemSize trait derived on the structs of this crate, the memory requirements computation becomes trivial. I have already merged pull requests in several of these aforementioned libraries adding an analogous feature flag, so integrating it also here would facilitate this considerably.
While I agree wholeheartedly that having it as a default dependency would be a rather poor life choice, I believe that having it as an optional dependency should be okay. Do you agree?


Add npm package

package.json is added, published to https://www.npmjs.com/package/kthcloud-types
Workflow/action is not working

CI/CD finish tracked as #470

Hmm looks like whatever we're using is outdated, maybe we can use the bun action


Fix Proposal page

Closes #1908
Description:

fix accessing the page directly
number of votes temporary fixed, when we will receive atoms instead of micro atoms this multiplier should be removed

Thank you! 🚀

For contributor:

[ ] Added entries in CHANGELOG.md with issue # and GitHub username
[ ] Reviewed Files changed in the github PR explorer
[ ] Attach screenshots of the UI components on the PR description (if applicable)
[ ] Scope of work approved for big PRs

For reviewer:

[ ] Manually tested the changes on the UI

unit tests fail

conflicts


[SPARK-35512][PYTHON] Fix OverflowError(cannot convert float infinity to integer) in partitionBy function

What changes were proposed in this pull request?
Limit the batch size for add_shuffle_key in partitionBy function to fix OverflowError: cannot convert float infinity to integer
Why are the changes needed?
It's not easy to write a UT, but I can use some simple code to explain the bug.

Original code

        def add_shuffle_key(split, iterator):

            buckets = defaultdict(list)
            c, batch = 0, min(10 * numPartitions, 1000)

            for k, v in iterator:
                buckets[partitionFunc(k) % numPartitions].append((k, v))
                c += 1

                # check used memory and avg size of chunk of objects
                if (c % 1000 == 0 and get_used_memory() > limit
                        or c > batch):
                    n, size = len(buckets), 0
                    for split in list(buckets.keys()):
                        yield pack_long(split)
                        d = outputSerializer.dumps(buckets[split])
                        del buckets[split]
                        yield d
                        size += len(d)

                    avg = int(size / n) >> 20
                    # let 1M < avg < 10M
                    if avg < 1:
                        batch *= 1.5
                    elif avg > 10:
                        batch = max(int(batch / 1.5), 1)
                    c = 0

if get_used_memory() > limit always is True and avg < 1 always is True, the variable batch will grow to infinity. then batch = max(int(batch / 1.5), 1) may raise OverflowError if avg > 10 at some time.

sample code to reproduce the bug

import sys

limit = 100
used_memory = 200
numPartitions = 64
c, batch = 0, min(10 * numPartitions, 1000)

while True:
    c += 1
    if (c % 1000 == 0 and used_memory > limit or c > batch):
        batch = batch * 1.5
        d = max(int(batch / 1.5), 1)
        print(c, batch)

Does this PR introduce any user-facing change?
no
How was this patch tested?
It's not easy to write a UT, there is sample code to test
import sys

limit = 100
used_memory = 200
numPartitions = 64
c, batch = 0, min(10 * numPartitions, 1000)

while True:
    c += 1
    if (c % 1000 == 0 and used_memory > limit or c > batch):
        batch = min(sys.maxsize, batch * 1.5)
        d = max(int(batch / 1.5), 1)
        print(c, batch)

Can one of the admins verify this patch?

ok to test

@nolanliou please take a look at https://github.com/apache/spark/pull/32667/checks?check_run_id=2671465975 and enable Github Actions. Apache Spark repositry uses the resources in each forked repository in PR builds.

Test build #138957 has started for PR 32667 at commit 9710887.

Test build #138957 has finished for PR 32667 at commit 9710887.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43477/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138957/

@nolanliou please take a look at https://github.com/apache/spark/pull/32667/checks?check_run_id=2671465975 and enable Github Actions. Apache Spark repositry uses the resources in each forked repository in PR builds.

I have enabled actions(Allow all actions), but still not work...

Test build #138964 has started for PR 32667 at commit b6241fa.

@nolanliou did you face something like this: https://github.com/apache/spark/pull/32400#issuecomment-831051189?

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43477/

Test build #138964 has finished for PR 32667 at commit b6241fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138964/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43477/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43483/

Test build #138973 has started for PR 32667 at commit 67e6d71.

@nolanliou did you face something like this: #32400 (comment)?

All test passed

Let's wait for few days to make sure other people can review.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43493/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43493/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43493/

Can one of the admins verify this patch?

Any updates?

Test build #139511 has finished for PR 32667 at commit 67e6d71.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139511/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44037/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44037/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44037/

Merged to master.


Fixes #3039. Fix View.HotKey

Fixes

Fixes #3039

Proposed Changes/Todos

[x] Bare hotkeys (no Alt) don't work. If a subview has a hotkey of n and the user presses n the focus should change to that view without doing an Accept.

[x] Command.Default should be invoked.
[x] View should have an event for the default command (OnDefaultCommand fires DefaultCommand).

[x] Alt-Hotkey should invoke Command.Accept by default.

[x] View should have an event for the accept command (OnAccept fires Accept). OnAccept should not set focus (Command.Default does).
[x] Unit tests for OnAccept/Accept
[x] OnMouseClick should use Command.Accept instead of what it does now.

[x] View.HotKey uses View.Text (actually View.TextFormater) to set the hotkey automatically. HotKey should be based on Title.

[x] Label, Button, and other views where having Text and Title be distinct makes no sense:

[x] Label Text mirrors Title
[x] Button Text mirrors Title
[x] Checkbox Text mirrors Title
[x] Enable a more consistent way where Text and Title stay in sync (Title should be the source of truth)

[x] Enable "Set focus to paired view" - E.g. _Label to the left of a TextView, user presses Alt-L or L; focus should move to the TextView. This works today, but only because of hack in Label.
[x] Update Scenarios to explicitly provide hotkey specifiers (where appropriate)
[x] Create a HotKeys Scenario that shows off/exercises HotKey support.
[x] MenuBar interferes with subview hot keys - In UICatalog try Alt-S or Alt-C...
[x] ListView.FocusNext doesn't always work - something is re-ordering SubViews; this can be seen in the Reactive Sample where Alt-U does not work.

Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[x] I ran dotnet test before commit
[x] I have made corresponding changes to the API documentation (using /// style comments)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

@dodexahedron, @BDisp, @tznind -- Questions on Command / Event design for Views.
Right now, we define Command.Default as "The default command. For View, this focuses the view."
This made sense to me when I added it. After working through this PR, I now believe I was not thinking clearly. Specifically, it's not that a view should have a super-generic "default" command, but what view needs is a command that gets invoked when a user invokes the HotKey.

View - Causes the view to gain focus.
Label - Causes the next view in the tab-order to gain focus.
Button - Causes the view to gain focus and calls OnClicked which fires Clicked
Checkbox - Causes the view to gain focus calls OnToggle which fires Toggled (this is the current behavior, but I challenge it; I would argue this behavior is too aggressive and toggling a check should require two user actions: focus, then select, but that's a debate for another day).
Most/all-other views inherit View behavior of just gaining focus.

Based in this, I want to rename Command.Default to Command.HotKey. Thoughts?
Related, today we define these Command enum values:

Command.Accept: Accepts the current state (e.g. selection, button press etc).
Command.Select: Moves selection to an item (e.g. highlighting a different menu item) without necessarily accepting it.
Command.ToggleChecked: Toggle the checked state.

I think Command.Accept and Command.Select are fine as-is. I think ToggleChecked is superfluous and can be deleted; use Command.Accept instead. Checkbox would be the only built-in view impacted.
I also think Button should be changed such that OnClicked and Clicked are replaced with OnAccept/Accept. Why? Because clicking on a button is the same as invoking the hotkey (or the keys bound to Accept (space/enter)).
Related to the above, I propose we combine a bunch of existing EventArgs classes into one.
public class StateEventArgs<T> : CancelEventArgs
{
    /// Creates a new instance of the <see cref="StateEventArgs"/> class.
    /// <param name="oldValue"></param>
    /// <param name="newValue"></param>
    public StateEventArgs (T? oldValue, T? newValue)
    {
        OldValue = oldValue;
        NewValue = newValue;
    }

    /// The new state
    public T? NewValue { get; }

    /// The previous state
    public T? OldValue { get; }
}

Specifically, all events that convey the state of the view has changed. For CheckBox T would be bool?.  For TextView.TextChanged T would be string, etc...
Any objections to this? Am I missing something?
I need more consistency here for both THIS PR as well as

#3076

I think is reasonable the changes. For CheckBox I only want to call the attention that navigating through theirs items aren't actually changing the current selected item and only when pressing the space bar is really accept it. You are really doing a great work.

For CheckBox I only want to call the attention that navigating through theirs items aren't actually changing the current selected item and only when pressing the space bar is really accept it.

Right. This is why I think using the keyboard to focus on a checkbox (via HotKey or Tab) should NOT change the check box state (as HotKey does now).

This is ready for review.

@dodexahedron, @BDisp, and/or @tznind:
Could I get your eyes on this please? I'd like to get it merged.


@conda-forge-admin, please add bot automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/subversion-feedstock#4.


autoNumeric prefixes 0 to the amount

autoNumeric prefixes 0 to the amount in some instances.
All the amount values have the same class that is being used to init autoNumeric from JS.
$(".dollar_value").autoNumeric('init', { aSign: '$' })

need to see a jsFiddle so I can see under what circumstances this is happening.

@vandamon,
I attempted to create a jsbin for your issue using what i could infer. I'm not seeing this happening using the current stable version of autoNumeric:
It does seem that in the latest stable version, trying to call autoNumeric.init on a HTML node with the text "$490.00" throws an autoNumeric exception.
Please see: http://jsbin.com/wobugoduru/edit?html,js,console,output

@Raylehnhoff
Thanks a lot for that jsbin. I was trying hard to get time and do it myself.
Anyway, I tweaked your HTML code, and the result is the same as I have reported.
Here is the modified jsbin: http://jsbin.com/suheweloba/edit?html,js,console,output

Hi @vandamon,
What browser are you using? In Chrome-latest the formatting is what I'd expect:
http://imgur.com/vhdDYsR

Okay I tried to replicate the way it is happening on my site with tables, it is working fine here. Not sure, why it is not working on my site.
http://jsbin.com/jugaguhace/1/edit?html,js,console,output
Might be because I am using autoNumeric-rails gem in my Rails app.

It looks that version is quite behind:
https://github.com/randoum/autonumeric-rails
You could try doing it without that gem and seeing if it still happens. If it only happens when using aN via the gem, the issue should be opened with that fork.

Thanks Ray for your help and answers
vandamon - I suggest that you contact randoum and see if he will update.


Issuing credits

Issue 50000 credits to @gardenenigma.

 Follow up
On Monday, 08-Apr-24 01:38:19 UTC by Gov4Git dev
Issued 50000 credits to member @gardenenigma.


Fix sidebar entry line wrap

What kind of changes does this PR include?

Changes to Starlight code

Description
If a sidebar entry wraps to a new line then it can be difficult to distinguish that entry from the ones above/below it. This puts in a fix to visually indent any subsequent lines.
Before:

After:

Sure, I can get behind that. I'll play around with it a bit to dial it in and update

@delucis here's those changes, feel free to dial them as you see fit. I tried to keep the overall vertical height of an item as close as possible.


check preamble type in template

Mainly to know whether to wrap the {{ sub_context }} output in a <ul> tag, since the preamble view returns list items but CFR returns an instructions div and section.

Hrm. I don't like having the logic in the template like this; it encourages undocumented flags rather than a consistent architecture. We should rethink the cfr_changes and preamble-partial templates to see if there's a better way for their content to fit together.
In the meantime, merging so we have valid HTML.


Problem with relative URLs

Hi,
When I use tinymce, I want to have the urls of images like: /static/images/example.png when I save the form.
I've tried all solutions on:
http://www.tinymce.com/wiki.php/TinyMCE_FAQ#Paths.2FURLs_are_incorrect.2C_I_want_absolute.2Frelative_URLs.3F
and:
http://www.tinymce.com/tryit/url_conversion.php
I have only two possible results:

../../../../../../../static/images/example.png
static/images/example.png (without the / at the beginning)

Even with 'convert_urls' : 'false', I've a conversion when I set /static/images/example.png.
I use the latest version of django-tinymce, with chromium.
Do you have an idea to fix the problem ?
Thanks for your answer.

I spent about an hour to realize that 'relative_urls' : 'false' doesn't work. You need to use 'relative_urls' : False to make it work. Thanks @caa


[installation/docs] ESRI Add-in .esriAddinX does not always show up in Add-in list

Type of issue:
Installation/documentation
Issue:
When following the install instructions for 2.9 or 3.1, adding the folders to the add-in manager folder search in the options tab  does not always show the add-in, even with "Load all Add-Ins without restrictions" and restarts.
For me this is reproduced by:

removing any packages and folders to search
restart
add folder to search
restart
package does not show up unless manually added

Versions:
ArcGIS Pro 2.9.10 with package v1.0.2 or 3.1.3 with package v1.0.4
Potential solution:
Add to the documentation to try to open the .esriAddinX file manually while ArcGIS Pro is open at step 5 of the installation process
Continue with steps as per normal, and installation succeeds

Thanks @catchSheep . I have experienced similar and in my case it came down to some odd behaviour in the ArcGIS Pro folder selection process.
The screen recording shows this. If I navigate into the unzipped tenement-tools folder and click ok the path becomes
\\Mac\Home\Downloads\tenement-tools-1-0-4-arcgispro29\tenement-tools-1-0-4-arcgispro29

But if instead I select the folder from the level up and click ok I get
\\Mac\Home\Downloads\tenement-tools-1-0-4-arcgispro29

The former folder does not exist, so obviously the plugin doesn't get detected.
Could this be the issue you are having?
https://github.com/frontiersi/tenement-tools/assets/4476041/25265a70-1e5c-46a0-ba6c-cd39bf36788a

Good catch, that does seem to have been the issue. Strange.
Might be good to make a note of it in the installation step until ESRI fixes that behavior.
Either that or perhaps instead a troubleshooting section at the end of the install docs, or in a separate file linked in the installation docs, that goes through common issues like this?

Agreed, we'll leave this open until we add a note into the install guide.
Longer term it'd be nice to have a much more streamlined install package that doesn't require users to go through so many steps.


[WIP] Java 10

Start work on getting fresh mark to build on Java 10.

Looks great, thanks @AustinShalit.  I haven't yet ventured past Java 8 myself, but I'll be happy to merge and release when you're ready.

Sounds good.  Still need to figure out release publishing (I deleted it from the build.gradle for now).  After that, we need to update spotless to run on Java 9+: https://github.com/diffplug/spotless/issues/206
Once both of those things are done, this should be good to go.

Need anything from me @AustinShalit?

Nope.  Family stuff popped up.  Should be able to resume work next week.

What's missing to get this merged?

Hey @AustinShalit, & @nedtwigg, I just ran headlong into this one as a part of testing my build under JDK 10.
Anything I can do to help on this one?

I haven't even peeked at migrating my products to Java 9, let alone 10.  I'm happy to merge and release whatever is needed, but I've got no leadership to offer on this topic.

@nedtwigg With Oracle EOLing support for JDK 8, it would probably be good to start getting things supporting JDK 10. (Probably not worth doing JDK 9 at this point).

It has been over a year and I still do not have time.  Closing this PR.  Hopefully someone can pick it up though.


Create Proper Readm.MD

As of now ReadMe .MD is not proper , there should be proper steps like how to clone , screenshots.
I will make proper Readme file

My self Harsh Upadhye , I have participated in GSOC 23 last year, I have good experience of working on open source projects. Please Assign this to me

Sure go ahead


Allow CALL_CLOSED to be raised when call_id is not set.

Fix for #747

thanks for the PR, this looks very good.
can you also take a look @jmillan ?

LGTM 👍

Why does it say 'Some checks haven't complete yet', its been 11 hours and clicking on Details shows ticks against everything.

not sure about travis .. anyhow merged now .. thank you !


feat: empty file e2e

Signed-off-by: Jim Ma<EMAIL_ADDRESS>
Description

Related Issue

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.

Codecov Report

Merging #1687 (a075391) into main (e84e4ef) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
- Coverage   42.00%   41.91%   -0.10%
==========================================
  Files         125      125
  Lines       15467    15467
==========================================
- Hits         6497     6483      -14
- Misses       8456     8475      +19
+ Partials      514      509       -5

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
41.91% <ø> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/daemon/peer/peertask_piecetask_poller.go
34.42% <0.00%> (-14.21%)
:arrow_down:

client/daemon/peer/peertask_conductor.go
58.90% <0.00%> (+0.68%)
:arrow_up:

...ent/daemon/peer/peertask_piecetask_synchronizer.go
51.41% <0.00%> (+0.94%)
:arrow_up:


Add missing thread name

What changes are proposed in this pull request?
add missing thread name
Why are the changes needed?
add missing thread name
https://github.com/Alluxio/alluxio/blob/f2825833fbf5d473fe7265aae749e8b3d52df143/core/server/common/src/main/java/alluxio/master/journal/AsyncJournalWriter.java#L147-L149
missing thread name
https://github.com/Alluxio/alluxio/blob/f2825833fbf5d473fe7265aae749e8b3d52df143/core/server/common/src/main/java/alluxio/master/journal/AsyncJournalWriter.java#L256-L265
Does this PR introduce any user facing changes?
No

alluxio-bot, merge this please


ADD HEADER_OPTIONS in allowed headers for subs api

HEADER_OPTIONS is used in subscription and needs to be allowed in CORS to make request from UI
Currently it gives error

Request header field options is not allowed by
Access-Control-Allow-Headers in preflight response

retest this please


ruby 2.3 support ?

Is this an option ? Would love to provide a PR.

Only thing i've noticed is String.match?

Is this an option ?

nope :)


Select popup don't show all the info.

Upon choosing select the trip much of the information is missing regarding the travel savings.

Need to tweak some of the params to always have car ride data, so the comparison table can be filled. Removed the select button for now.

I don't think we can do that. If we enable car, otp returns only one route and it'll use car in it. Chances are there will be no transit route options.


add_subplot needed on initial call

add_subplot is needed after an initial call. Probably should activate the correct panel frame.

Maybe make this a keyword? Nice to have the option of a blank panel on init.

Keyword of first panel = True


[x64][ARM64][WinUI]Error list shows 3 errors when publishing WinUI application to the Microsoft Store

Describe the bug
Error list shows 3 errors when publishing WinUI application to the Microsoft Store.

Steps to reproduce the bug
Environment:
Affected Branch: d17.4
Affected Build: 33103.184
Steps to reproduce:
1.Create a C# Blank App, Packaged (WinUI 3 in Desktop)
2.Right Click the project node, click "Manage NuGet Packages"
3.In the Installed tab, select "Microsoft.WindowsAppSDK", use the latest version or preivous version
4.Click update
5.Right click the project node, click "Packaged and Publish"
6.Click "Create App Packages"
7.Select "Microsoft Store under a new app name", click Next
8.Sign in with a developer account(e.g. XamlTest@hotmail.com), select an existing app name, click Next
9.Click "Create"
Expected behavior
No response
Screenshots
No response
NuGet package version
No response
Windows app type

[ ] UWP
[ ] Win32

Device form factor
No response
Windows version
No response
Additional context
No response

Fix will be included in Windows App SDK 1.3