Unable to create trust policy for central account - Prohibited field "Principal"

Describe the bug
When creating a trust policy for my central account role based on these instructions, I'm unable to create a trust policy for my role. When I attempt to add the policy to my newly created role, Amazon reports the following error:

This policy contains the following error: Has prohibited field Principal For more information about the IAM policy grammar, see AWS IAM Policies.

To Reproduce
Steps to reproduce the behavior:

Create a AWS IAM role without a policy.
Once the AWS IAM role is created, attach a new policy to it with the following JSON:

{
  "Statement": [
    {
      "Action": "sts:AssumeRole",
      "Effect": "Allow",
      "Principal": {
        "Service": "ec2.amazonaws.com"
      }
    },
    {
      "Action": "sts:AssumeRole",
      "Effect": "Allow",
      "Principal": {
        "AWS": "INSERT_THE_ROLE_ARN_YOU_JUST_CREATED_HERE"
      }
    }
  ],
  "Version": "2012-10-17"
}

When saving the trust policy you will see the Amazon error.

Expected behavior
I should see the policy created.
Screenshots
Here is a screenshot of the error:

Desktop (please complete the following information):
N/A
Smartphone (please complete the following information):
N/A
Additional context
There are two possibilities here: either I don't understand fully AWS IAM roles and policies, or the sample trust policy in your instructions is not correct. I am leaning towards this issue being the former case but I'm going to go ahead and post this issue anyways just in case it's not.

Hi @mrthankyou,
When you are creating the policy, make sure you are editing under the Trust Relationships tab, and not the Permissions tab.
When adding the policy under Permissions I got the same error: this is because the policy is a Trust relationship, it defines what principals can assume the role, and under which conditions. The Permissions tab has the Permission Policies, which define the permissions that a principal assuming the role is able (or restricted) to perform, and on which resources.
So, you will need to go under the Trust Relationships tab within the role and edit that to the given policy.

Attached above is the screenshot of the tab; you should be able to click Edit trust relationship and edit the JSON to update the policy accordingly.
Hope this helps!

@jaydhulia Thanks for the quick response. That did it for me. I'll continue work on this and hopefully not run into anymore issues. I'm happy to close this if you are.

@mrthankyou Awesome, glad to hear that! Yup, feel free to close the issue and create a new issue if you run into any more issues!


Fix di server resolution

:tada: This PR is included in version 6.75.12 :tada:
The release is available on:

v6.75.12
GitHub release

Your semantic-release bot :package::rocket:


Remove non-essential files from npm package

Fixes #22

Sorry for the delay on this.  I intend to incorporate this after #10 is integrated (since that's a pretty big change).

Done under #36.


package.json support

is there any plan for  package.json integration support?
as described on jsdoc3: http://usejsdoc.org/about-including-package.html

I'll add the option, but it should work (using the beta version, that will become stable soon) just by adding the package.json file to your source list.

The package option is supported.

I've added a test case and this option works.


fix(transformer): add deepUnmock to hoist method list

Add deepUnmock to hoist method list
Improve hoist codes
Improve unit tests and e2e tests

Closes #1088, #1098
Thanks @tonyhallett for the solution

Pull Request Test Coverage Report for Build 3955

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 90.468%

Totals

Change from base Build 3953:
0.01%

Covered Lines:
1067

Relevant Lines:
1123

💛  - Coveralls


Refactor/libvirt resource

This PR contains the refactor of the LibvirtComputingResource. The motivation behind this effort is to increase maintainability and testability of the code.
The LibvirtComputingResource went from 5.5k to 3.3k lines of code. The unit tests went from 300 to 5050 lines of code, covering 23.3% of the whole KVM plugin (instead of the previous 4%).
All the code extracted from the LibvirtComputingResource has 64.8% coverage.
This has already been rebased and built. I'm creating the PR now but will test it against a KVM hypervisor before it gets pushed towards the Master branch.
Cheers,
Wilder

Please, do not merge it before I test it with a KVM hypervisor.
Cheers,
Wilder

Yeah, I think this is a big enough change that we should give all KVM "stakeholders" an opportunity to review and test before merge. At least the committers, but anyone who wants to participate, of course.  Mike T, Wido, myself, Lucian, Andrija, just to try to get an array of use cases and storage types represented. Hopefully at least someone who uses OVS and vxlan.

Thanks, guys.
Would be really nice to test it ASAP so we avoid another rebase.
Most of the changes are purely structural, I tried my best to keep the behaviour as it is. If you look at the wrappers, they have the same content that the methods had when inside the LibvirtComputingResource. Are there changes in the behaviour? Yes, a few. For example, in few methods we had try/catch blocks with e.printStackTrace() and after that still returning true (as a successful operation). There were also methods returning always true and that return was being ignored. Those kind of things I changed.
Right now I'm busy getting my KVM environment test up and running. I will test the changes with OVS and VLAN and send a report to the list. My plan is to do it today/tomorrow
After the code reaches master, I will change the flyweight implementation in order to use the Annotations (suggested by @mlsorensen) and also increase UT coverage.
If you would have time to test it this week it would be very appreciated.
Cheers,
Wilder

looks nice :+1:

Looks good, I guess Travis is sort of green (with on failing test due to timeout). I will help test it tonight or tomorrow.

Thanks, @bhaisaab and @K0zka :)
Yep, "linbvirt" is a typo. :( When I apply the annotations (after the merge) I will rename it. :)
Cheers,
Wilder

Hi @mlsorensen @bhaisaab
Did you guys have time to test this PR?
My KVM environment is up and running and I just started testing. I will send a report soon.
Cheers,
Wilder

Okay.... but thanks a lot for start looking into it, @mlsorensen.
My env was a bit bumpy today and I did no manage to do all I had planned for, but I'm moving on with the tests just to identify performance improvements for our current test environment. It's taking about 10min to start a VM... so, running a test list test_accounts.py takes a very long time.
I will keep you up to date.
Cheers,
Wilder

Yeah, I got past tomcat and other systemd switchover issues on > 4.5 code, but then ran into other issues. The mgmt server configs got all messed up by the new RPMs. I got the server xml worked out but it couldn't connect to the db, 'access denied for cloud@localhost'. It doesn't seem to even be reading my db.properties. Mainly master teething issues around upgrade, I presume, but I've spent too much time on it today. I'll try a fresh install later.
One thing in particular I'd like to see tested is live migration. If I don't manage to test this please do at least this one.

@mlsorensen
"I got the server xml worked out but it couldn't connect to the db, 'access denied for cloud@localhost'"
I've seen this before as well when testing 4.5 upgrades. I'd check permissions on files cloudstack touches, for me it was permission related and it was not reading db.properties file like you mentioned.

@wilderrodrigues any update on this PR, if it's well tested, let's merge it?

@bhaisaab
I'm testing since yesterday. My KVM environment is a bit slow, but all the tests are going okay.
Please check the partial report below (last just wait a couple of hours then merge it):
Hi all,
I took some time to run integration/smoke tests on the LibVirt refactor I finished last week. All the test went well, as detailed in the report below.
More information about my environment and what was covered.
Environment:
Centos7 + KVM + Qemu
MySQL/MariaDB 5.5.41
Management Server running CentOS 7
Component/Smoke tests: https://github.com/apache/cloudstack (test/integration/component and smoke)
Storage type: NFS shared
Isolation method: VLAN
Test Create Account and user for that account ... === TestName: test_01_create_account | Status : SUCCESS ===
ok
Test Sub domain allowed to launch VM  when a Domain ... === TestName: test_01_add_vm_to_subdomain | Status : SUCCESS ===
ok
Test delete domain without force option ... === TestName: test_DeleteDomain | Status : SUCCESS ===
ok
Test delete domain with force option ... === TestName: test_forceDeleteDomain | Status : SUCCESS ===
ok
Test to verify Non Root admin previleges ... === TestName: test_01_non_root_admin_Privileges | Status : SUCCESS ===
ok
Test Remove one user from the account ... === TestName: test_01_user_remove_VM_running | Status : SUCCESS ===
ok
Test to verify service offerings at same level in hierarchy ... === TestName: test_01_service_offering_hierarchy | Status : SUCCESS ===
ok
Test to verify service offerings at same level in hierarchy ... === TestName: test_01_service_offering_siblings | Status : SUCCESS ===
ok
Test to verify template at same level in hierarchy ... === TestName: test_01_template_hierarchy | Status : SUCCESS ===
ok
Test update admin details ... === TestName: test_updateAdminDetails | Status : SUCCESS ===
ok
Test update domain admin details ... === TestName: test_updateDomainAdminDetails | Status : SUCCESS ===
ok
Test user update API ... === TestName: test_updateUserDetails | Status : SUCCESS ===
ok
Test login API with domain ... === TestName: test_LoginApiDomain | Status : SUCCESS ===
ok
Test if Login API does not return UUID's ... === TestName: test_LoginApiUuidResponse | Status : SUCCESS ===
ok

Ran 14 tests in 7517.316s
OK
/tmp//MarvinLogs/test_accounts_RWB0RK/results.txt
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
ok

Ran 10 tests in 2936.289s
OK (SKIP=1)
/tmp//MarvinLogs/test_vm_life_cycle_F2MIF6/results.txt
====Trying SSH Connection: Host:<IP_ADDRESS> User:root                                   Port:22 RetryCnt:60===
===SSH to Host <IP_ADDRESS> port : 22 SUCCESSFUL===
{Cmd: ssh -i ~/.ssh/id_rsa.cloud -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 <IP_ADDRESS> service dnsmasq status via Host: <IP_ADDRESS>} {returns: [u'Checking DNS forwarder and DHCP server: dnsmasq(running).']}
====Trying SSH Connection: Host:<IP_ADDRESS> User:root                                   Port:22 RetryCnt:60===
====Trying SSH Connection: Host:<IP_ADDRESS> User:root                                   Port:22 RetryCnt:60===
===SSH to Host <IP_ADDRESS> port : 22 SUCCESSFUL===
===SSH to Host <IP_ADDRESS> port : 22 SUCCESSFUL===
{Cmd: ssh -i ~/.ssh/id_rsa.cloud -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 <IP_ADDRESS> service haproxy status via Host: <IP_ADDRESS>} {returns: [u'haproxy is running.']}
{Cmd: ssh -i ~/.ssh/id_rsa.cloud -ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 <IP_ADDRESS> service haproxy status via Host: <IP_ADDRESS>} {returns: [u'haproxy is running.']}
Test router internal advanced zone ... === TestName: test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS ===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS ===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS ===
ok

Ran 7 tests in 1995.909s
OK
/tmp//MarvinLogs/test_routers_QV22YU/results.txt

@bhaisaab @mlsorensen
I just sent the test report to your emails.
I'm fully confident with the changes and would like to suggest a merge of the PR.
Thanks in advance.
Cheers,
Wilder

Hi @bhaisaab ,
Is that okay if I merge the PR? It's been here for 7 days and has been tested.
Cheers,
Wilder

@wilderrodrigues thanks for sharing the test reports, while I've not personally tested. Looks good, please go ahead.

@wilderrodrigues build-master-jdk18 is failing in jenkins. http://jenkins.buildacloud.org/job/build-master-jdk18/38/
It fails on the below test
com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest.testGetHostStatsCommand

Test set: com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
Tests run: 143, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.744 sec <<< FAILURE! - in com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
testGetHostStatsCommand(com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest)  Time elapsed: 0.185 sec  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<java.lang.NumberFormatException> but was<java.lang.NullPointerException>
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtGetHostStatsCommandWrapper.execute(LibvirtGetHostStatsCommandWrapper.java:77)
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtGetHostStatsCommandWrapper.execute(LibvirtGetHostStatsCommandWrapper.java:34)
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:182)
at com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest.testGetHostStatsCommand(LibvirtComputingResourceTest.java:930)

@wilderrodrigues Sorry, I could not test the PR earlier. I see the following issues while trying to bring up my KVM setup:

LibvirtUtilitiesHelper NPE. This could be due to spring configuration.  LibvirtUtilitiesHelper  ws not injected.

2015-05-14 00:00:05,362 DEBUG [kvm.resource.LibvirtComputingResource] (agentRequest-Handler-2:null) Execption while executing command com.cloud.agent.api.StartCommand
java.lang.NullPointerException
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:72)
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:45)
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:182)
at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1251)
at com.cloud.agent.Agent.processRequest(Agent.java:503)
at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:808)
at com.cloud.utils.nio.Task.run(Task.java:84)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)

executeRequest in LibvirtComputingResource is not logging any exception. It return Unsupported command answer. This makes it difficult to debug exceptions thrown during command execution,

Hi @kishankavala,
I will have a look at that, although that's pretty weird since I have tested on a KVM environment as well. Don't see why the bean would have been injected for me and not for you.
Have you done a full clean/install of the latest source?
Cheers,
Wilder

Hi @karuturi,
I had a look and it has more to do with the hard coded paths in the code (which were already present) and the setup of the machine where the Java8 builds run.
Good it failed, because that code has never been tested before.
I will make the test better and push a fix asap.
Thanks for the heads up.
Cheers,
Wilder


Use CSS modules for Project Card component

Please refer to the guide to use CSS modules.

Interested!

Interested!


Malformed numpy

From @andrie:
> use_condaenv("cntk-py35", conda = "/home/adevries/anaconda3/envs/cntk-py35/bin/conda", required = TRUE)
> py_config()

Error in py_run_string_impl(paste0("import sys; sys.path.append('", system.file("python",  :
  ImportError:
Importing the multiarray numpy extension module failed.  Most
likely you are trying to import a failed build of numpy.
If you're working with a numpy git repo, try `git clean -xdf` (removes all
files not under version control).  Otherwise reinstall numpy.

Detailed traceback:
  File "/home/adevries/anaconda3/lib/python3.6/site-packages/numpy/__init__.py", line 146, in <module>
    from . import add_newdocs
  File "/home/adevries/anaconda3/lib/python3.6/site-packages/numpy/add_newdocs.py", line 13, in <module>
    from numpy.lib import add_newdoc
  File "/home/adevries/anaconda3/lib/python3.6/site-packages/numpy/lib/__init__.py", line 8, in <module>
    from .type_check import *
  File "/home/adevries/anaconda3/lib/python3.6/site-packages/numpy/lib/type_check.py", line 11, in <module>
    import numpy.core.numeric as _nx
  File "/home/adevries/anaconda3/lib/python3.6/site-packages/numpy/core/__init__.py", line 24, in <module>
    raise ImportError(msg)

Update numpy from 1.12 -> 1.13 seems to fix, but this issue doesn't effect the python API, just the R API.

Hi @andrie, is it OK to close this issue?


ASTERIX: Show that 65 does not imply 1491

See the blueprint chapter at https://teorth.github.io/equational_theories/blueprint/asterix-chapter.html and the discussion at https://leanprover.zulipchat.com/#narrow/stream/458659-Equational/topic/Equation.2065.20-.3E.20left.20cancellability .  Note that the blueprint requires some correction and modification a discussed at the latter link.
This can go in a new Lean file.  When done, update the blueprint with appropriate \lean and \leanok tags.

claim

propose PR #513


Default to creating a regular TOML table for the metadata MSRV fallback value

Previously we would create an inline table instead, but the inline table makes it harder to add more values (as keys and values need to be on one line).
closes #364

bors r+

bors r+


Content in the welcome page not properly aligned

Some of the text and AP logo is not well adjusted in the taskpane. I would like to work on this issue

@DianaLease Rendering of this component for fraction of seconds in the add-in at the start does not make much sense. What are your views about it?

What welcome page are you referring to? I only see a loading screen before the add-in renders.

@DianaLease This page loads in the local host and it also loads in the add-in for some initial seconds in the start when add-in is initialized.

Ah, yeah, I think we could probably remove that.

Should I start working on this issue?

Sure, thanks!

Should we render this Page in localhost as well or remove it from there also?

If it's possible to only show in the browser and not when already side-loaded, let's do that

Working on that ...

@DianaLease I am still working on this issue.


compile failed use<EMAIL_ADDRESS>

I use scripts\npm install
get
<EMAIL_ADDRESS>node_modules\typescript.
and then run gulp watch
get
*** Error: D:/workSpace/vscode/vscode/src/vs/editor/browser/standalone/standalon
eCodeEditor.ts(199,3): 'super' must be called before accessing 'this' in the con
structor of a derived class.
*** Error: D:/workSpace/vscode/vscode/src/vs/editor/browser/standalone/simpleSer
vices.ts(219,3): 'super' must be called before accessing 'this' in the construct
or of a derived class.
*** Error: D:/workSpace/vscode/vscode/src/vs/editor/browser/standalone/simpleSer
vices.ts(220,3): 'super' must be called before accessing 'this' in the construct
or of a derived class.
*** Error: D:/workSpace/vscode/vscode/src/vs/editor/browser/config/configuration
.ts(275,3): 'super' must be called before accessing 'this' in the constructor of
a derived class.
*** Finished with 57 errors.

I try to roll back typescript to 1.8.0.
gulp watch will be successfully executed

So... wait for the next vscode to upgrade to 1.8? @joaomoreno
Thanks --

@chadbr This issue was about the development of VS Code itself. It couldn't be compiled against 1.8.2.
The next VS Code will indeed come with the 1.8.2 language service, but that's another matter.

I have the same problem in VS2015, TS 1.8.9, Gulp executes.


CMS_SignerInfo_verify verification failure

CMS Verification failure
8022A29B9C7F0000:error:02000068:rsa routines:ossl_rsa_verify:bad signature:crypto/rsa/rsa_sign.c:430:
8022A29B9C7F0000:error:1C880004:Provider routines:rsa_verify:RSA lib:providers/implementations/signature/rsa_sig.c:775:
8022A29B9C7F0000:error:1700009E:CMS routines:CMS_SignerInfo_verify:verification failure:crypto/cms/cms_sd.c:925:
For PKCS#1, the SHA256 header should be:
30 31 30 0d 06 09 60 86 48 01 65 03 04 02 01 05 00 04 20 ...
However, there might also be this alternate header:
30 2f 30 0b 06 09 60 86 48 01 65 03 04 02 01 04 20 ...
Some implementation use the alternate. According to PKCS#1, the first one is used when producing signature, but both should be accepted when verifying signatures
Thanks

I found similar https://github.com/openssl/openssl/issues/16683
Close this, excuse me


[Event Parameter Request] Codeunit 80 Sales-Post - procedure PostItemLine - event OnPostItemLineOnBeforePostItemJnlLineForInvoiceDoc

We would like the IncludeSender added to the following event.
Codeunit 80 Sales-Post - procedure PostItemLine - event OnPostItemLineOnBeforePostItemJnlLineForInvoiceDoc
Original:
Codeunit 80 Sales-Post - procedure PostItemLine - event OnPostItemLineOnBeforePostItemJnlLineForInvoiceDoc

OnPostItemLineOnBeforePostItemJnlLineForInvoiceDoc(SalesHeader, SalesLineToShip, Ship, ItemLedgShptEntryNo, GenJnlLineDocNo, GenJnlLineExtDocNo, SalesShptHeader, TempHandlingSpecification, TempTrackingSpecificationInv, TempTrackingSpecification, IsHandled, QtyToInvoice, TempPostedATOLink);

[IntegrationEvent(false, false)]
local procedure OnPostItemLineOnBeforePostItemJnlLineForInvoiceDoc(SalesHeader: Record "Sales Header"; var SalesLineToShip: Record "Sales Line"; Ship: Boolean; var ItemLedgShptEntryNo: Integer; var GenJnlLineDocNo: Code[20]; var GenJnlLineExtDocNo: Code[35]; SalesShptHeader: Record "Sales Shipment Header"; var TempHandlingSpecification: Record "Tracking Specification" temporary; var TempTrackingSpecificationInv: Record "Tracking Specification" temporary; var TempTrackingSpecification: Record "Tracking Specification" temporary; var IsHandled: Boolean; QtyToInvoice: Decimal; TempAssembletoOrderLink: Record "Posted Assemble-to-Order Link" temporary)
begin
end;

Change:
we need IncludeSender to be set true in this event

[IntegrationEvent(true, false)] // <-- IncludeSender true
local procedure OnPostItemLineOnBeforePostItemJnlLineForInvoiceDoc(SalesHeader: Record "Sales Header"; var SalesLineToShip: Record "Sales Line"; Ship: Boolean; var ItemLedgShptEntryNo: Integer; var GenJnlLineDocNo: Code[20]; var GenJnlLineExtDocNo: Code[35]; SalesShptHeader: Record "Sales Shipment Header"; var TempHandlingSpecification: Record "Tracking Specification" temporary; var TempTrackingSpecificationInv: Record "Tracking Specification" temporary; var TempTrackingSpecification: Record "Tracking Specification" temporary; var IsHandled: Boolean; QtyToInvoice: Decimal; TempAssembletoOrderLink: Record "Posted Assemble-to-Order Link" temporary)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10050.


Payment.Currency must be of type string not Currency

SuccessfulPayment has a field "currency" of type string. But in Payment struct Currency field is declared as Currency type not string.
This causes Error when a SuccessfulPayment Message is received:

json: cannot unmarshal string into Go struct field Payment.Result.message.successful_payment.currency of type telebot.Currency

#300


On the other hand, d0, d1 will still evaluate to 1, not, say, 1, 1 or error. I am going to call this a feature, not a bug. Oh comma operator, how I love thy ridiculous nature!


Update kind-projector to 0.13.2

Updates org.typelevel:kind-projector from 0.13.0 to 0.13.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "kind-projector" } ]

labels: library-update, semver-patch

Codecov Report

Merging #247 (ba64b9a) into master (5d58a3d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   66.29%   66.29%
=======================================
  Files          18       18
  Lines         534      534
  Branches       21       22    +1
=======================================
  Hits          354      354
  Misses        180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f417f...ba64b9a. Read the comment docs.


Passing arguments via the display function?

Thank you all for developing this.
Would there be a way to pass arguments to the display function, like:
TNSPSPDFKit.display('~/images/file.pdf', {scrollDirection: 'vertical'}); ?
I can successfully do it via my XML element
<TNSPSPDFView scrollDirection="vertical" scrubberBar="verticalRight" thumbnailBar="scrubber" spreadFitting="fit"></TNSPSPDFView>
But then the fancy tools (search, bookmarks, etc) are not displayed in my ActionBar.
Thanks for any help you can provide

It is possible but not wired up , if anyone wants to know where to start check out the following
Android
https://github.com/TeamMaestro/nativescript-pspdfkit/blob/master/src/android/pspdfkit.ts#L80
https://pspdfkit.com/api/android/reference/com/pspdfkit/configuration/activity/PdfActivityConfiguration.Builder.html#build()
IOS
https://github.com/TeamMaestro/nativescript-pspdfkit/blob/master/src/ios/pspdfkit.ts#L97
https://pspdfkit.com/api/ios/Classes/PSPDFViewController.html#/c:objc(cs)PSPDFViewController(py)configuration


More Musical Cargo

About the PR

Adds a whole bunch of Instruments to the Cargo manifest, via bundles organized (roughly) by Type
Media

Options within the Cargo UI
Contents of each box (Variety, Brass, String, Woodwind, Keyed/Percussion, Specialty

[X] I have added screenshots/videos to this PR showcasing its changes ingame

Changelog

:cl: EnDecc

add: Added String, Woodwind, Keyed and Percussion, and Specialty Music crates to Cargo's Manifest
tweak: Renamed 'Big Band' crate to Variety Instrument collection, tweaked ID of Brass crate to easily identify with other Instrument Crate IDs, and its contents.

lgtm


/sbin/pipework: 274: kill: Illegal number:

Not sure what is happening here...
First time pipework is called it returns an exit code 2. After waiting 5 seconds, the same pipework cmd is retry, and then it works.
https://gist.github.com/dreamcat4/34975af1714b6f916c3d
+ ip netns exec 29121 dhclient -pf /var/run/dhclient.29121.pid eth0
mv: cannot move '/etc/resolv.conf.dhclient-new.29301' to '/etc/resolv.conf': Device or resource busy
+ cat /var/run/dhclient.29121.pid
cat: /var/run/dhclient.29121.pid: No such file or directory
+ kill
/sbin/pipework: 274: kill: Illegal number:
++ '[' 2 '!=' 0 ']'

In shell, the commands were:
id@emachines-e520:~/docker-images$ docker start pipework ; sleep 15 ; docker start tvh
pipework
tvh

Hmm. And then my wrapper script hangs / stops responding to further events.
My issue seems to have gone away either by moving from ubuntu 14.04 to 15.04, or from netcat --> curl.
Perhaps there is nothing actionable here.

This happens some times, but not other times. I also may get on the 2nd try:
+ ip netns exec 20832 dhclient -pf /var/run/dhclient.20832.pid eth0
RTNETLINK answers: Device or resource busy

Waiting 15 seconds until the retry has no effect.

Do you think you could try with a different DHCP client?
I wonder if this might be caused by the fact that dhclient tries to clobber /etc/resolv.conf, which is actually a bind-mount (and has to be re-written instead of re-created).

@jpetazzo Yeah sure! Although it was a long time ago I tried the others once. To my memory only 1 clients actually worked for me. Can't remember which one(s).
I'll try to re test it and then get back to you some better clues. Maybe I should also edit your script to strace the relevant command to see what it's doing on those runs vs the 'working times' (when the same cmd is run but there is not error).
This is good !

@jpetazzo. Have now had the chance to get back to try this. Updated to latest pipework today with your new default busybox udhcpc client. From my limited testing (during 1 hour), it seems fantastic. Very happy. My docker image is updated to v1.10 tag.
It seems to solve this issue entirely. I can't fault your analysis of the problem (trying to move the resolv.conf. Since there were other worse issues / hang with dhclient, there was little point going back to confirm it. As we can't do anything about it anyway.

Thanks! Sorry that I couldn't check earlier. I have slated some time next week to go over open pipework issues, I hope I can crunch through the backlog :-)

I wonder if this might be caused by the fact that dhclient tries to clobber /etc/resolv.conf, which is actually a bind-mount (and has to be re-written instead of re-created).

It seems there will be some change in behaviour for docker v1.9.1
https://github.com/docker/docker/pull/14965
^^ Not sure if that helps dhclient does it? But at least dhclient would then be able to see the file is readonly... and maybe not be trying to move it / / update it / replace it.


use react router to create links to pages with information on each launch

https://reactrouter.com/
This issue is to be addressed after #5 is resolved.

Interested ,please assign this to me

This issue is still available for now :)

Assign this to me

Hey @gagandeepp, although I appreciate your interest in many of our issues, we want to make space for a variety of contributors. We've assigned you #7

Hi @Cerchie, I hope you are doing well!
Is this issue still up for grabs?

@rek990 it's yours!

@rek990 I thought it was, but looks like it was addressed here https://github.com/stepzen-dev/stepzen-spacex-graphql/pull/22-- please feel free to grab another, or create an issue to start work in one of the examples in our monorepo here if you like https://github.com/stepzen-dev/examples

@Cerchie no problem: I'll definitely take a look at some of the other repos!


Add DatagramPacketEncoder and DatagramPacketDecoder

Motivation:
UDP-oriented codec reusing the existing encoders and decoders would be helpful. See #1350
Modifications:
Add DatagramPacketEncoder and DatagramPacketDecoder to reuse the existing encoders and decoders.
Result:
People can use DatagramPacketEncoder and DatagramPacketDecoder to wrap existing encoders and decoders to create UDP-oriented codec.

If we add a new copy operation to AddressEnvelope that allows us to specify the new content while preserving other properties such as remote address, we can get it work for all AddressedEnvelope messages rather than only DatagramPacket.

@trustin I think we cannot add new method to an interface in 4.0/4.1. So I still used DatagramPacket in this PR.

I think we cannot add new method to an interface in 4.0/4.1. So I still used DatagramPacket in this PR.

I thought we can in 4.1?

We can in 4.1

Am 07.03.2016 um 08:27 schrieb Trustin Lee<EMAIL_ADDRESS>I think we cannot add new method to an interface in 4.0/4.1. So I still used DatagramPacket in this PR.
I thought we can in 4.1?
—
Reply to this email directly or view it on GitHub.

https://github.com/NUBIC/ncs_navigator_core/commit/65fc2e0bc68c46ccfb4f1e47b5d4945d1719cf2d

@W12S12E12 Wrong thread

Tried to add a copy(AddressedEnvelope<M, A>) to AddressedEnvelope. However, not all AddressedEnvelope subclasses accept a ByteBuf content (e.g., DatagramDnsQuery and DatagramDnsResponse). It looks pretty weird to implement this method for them.

Updated to delegate other methods.

LGTM... @trustin any more comments ?

LGTM :-)

Squashed and cherry-picked into 4.1 (4fb585965cf7613dc1011b23f09114135a254399)

@windie thanks!


Support to call multiple kafka schema registry VIPs

Codecov Report

Merging #1891 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
+ Coverage   70.12%   70.12%   +<.01%
==========================================
  Files         814      814
  Lines       38950    38955       +5
  Branches     5146     5147       +1
==========================================
+ Hits        27314    27318       +4
- Misses       9833     9836       +3
+ Partials     1803     1801       -2

Impacted Files
Coverage Δ

...e/realtime/impl/kafka/KafkaAvroMessageDecoder.java
0% <0%> (ø)
:arrow_up:

...ore/query/scheduler/resources/ResourceManager.java
81.81% <0%> (-13.64%)
:arrow_down:

.../pinot/core/query/scheduler/PriorityScheduler.java
77.46% <0%> (-5.64%)
:arrow_down:

...pinot/core/operator/docidsets/OrBlockDocIdSet.java
84.9% <0%> (-3.78%)
:arrow_down:

...e/operator/dociditerators/BitmapDocIdIterator.java
60.71% <0%> (-3.58%)
:arrow_down:

.../impl/dictionary/BaseOffHeapMutableDictionary.java
75.8% <0%> (-2.69%)
:arrow_down:

...not/broker/requesthandler/RangeMergeOptimizer.java
88.7% <0%> (-1.62%)
:arrow_down:

...rEqualitiesToInClauseFilterQueryTreeOptimizer.java
90.9% <0%> (-1.3%)
:arrow_down:

...impl/dictionary/DoubleOnHeapMutableDictionary.java
75.55% <0%> (ø)
:arrow_up:

...ot/core/query/pruner/ColumnValueSegmentPruner.java
87.93% <0%> (ø)
:arrow_up:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c7bf5...a023050. Read the comment docs.


Add unit/regression tests for language simplifier

The simplifier is a significant piece of arcane magic and should be kept a close eye on.

This is complete as of 02c715e.


Update VM Probe configuration

This adds PeriodSeconds to probe configuration, which indicates how often to perform the probe.
It also adds VirtualMachineReady condition type in virtualmachine status.

Please run make generate and include the zz_generated.deepcopy.go in the PR please

Please run make generate and include the zz_generated.deepcopy.go in the PR please

I would not expect the generated Probe DeepCopy() to change from this change. The new field is just an int32 and copied for free because of the struct assignment.


Question:  Cannot eat anybody

I just downloaded and installed it on Ubuntu 15.10, but no matter how large we grow, we cannot eat each other. Is there a setting I need to change?

 If so, it's a bug in my code and
I'll try fixing it...

Yes, that worked!  We can now eat blobs!! Thanks for the last good commit #.

Still not working for me.

Try commit ef5bdf5f8e61d5806e23db9ef83f8ef7719e0596. I'll fix it soon and
I've already said that.

Tried it, still doesn't seem to work.

Are you 5 mass bigger than the other player and is the other players mass
more than 10?

Yes

That's weird, can you try the es6-refactor branch?

How would I clone that branch?

With git clone -b es6-refactor https://github.com/huytd/agar.io-clone.git

Won't install dependencies/start.
`npm install
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/jscs/node_modules/vow-fs/node_modules/glob requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/jscs/node_modules/minimatch,
npm WARN unmet dependency which is version 3.0.0
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/babel-eslint/node_modules/babel-core/node_modules/source-map-support requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/babel-eslint/node_modules/babel-core/node_modules/source-map,
npm WARN unmet dependency which is version 0.5.6
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/eslint/node_modules/file-entry-cache/node_modules/flat-cache/node_modules/del/node_modules/globby requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/eslint/node_modules/glob,
npm WARN unmet dependency which is version 5.0.15
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/node-sass/node_modules/node-gyp requires glob@'3 || 4' but will load
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/node-sass/node_modules/glob,
npm WARN unmet dependency which is version 7.0.3
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/node-sass/node_modules/gaze/node_modules/globule/node_modules/glob requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/node-sass/node_modules/gaze/node_modules/globule/node_modules/minimatch,
npm WARN unmet dependency which is version 0.2.14
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/node-sass/node_modules/request/node_modules/http-signature/node_modules/sshpk requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency /home/ubuntu/workspace/agar.io-clone/node_modules/node-sass/node_modules/request/node_modules/http-signature/node_modules/assert-plus,
npm WARN unmet dependency which is version 0.2.0
zanderl:~/workspace/agar.io-clone (es6-refactor) $ npm start

<EMAIL_ADDRESS>start /home/ubuntu/workspace/agar.io-clone
babel-node server/index

sh: 1: babel-node: not found
npm ERR! Linux 4.2.0-c9
npm ERR! argv "/home/ubuntu/.nvm/versions/node/v4.4.3/bin/node" "/home/ubuntu/.nvm/versions/node/v4.4.3/bin/npm" "start"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>start: babel-node server/index
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'babel-node server/index'.
npm ERR! This is most likely a problem with the agar-clone package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     babel-node server/index
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs agar-clone
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls agar-clone
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/ubuntu/workspace/agar.io-clone/npm-debug.log`

Eating won't work for me as well

Making a heavily modified version i stumbled into that bug too.
The bug I had was related to the the quadtree used for collision detection.
There is a temporary fix until a solution is found :
In server.js remove this :
 tree.clear();
        users.forEach(tree.put);
        var playerCollisions = [];

        var otherUsers =  tree.get(currentPlayer, check);

        playerCollisions.forEach(collisionCheck);

and put this instead :
        var playerCollisions = [];
         users.forEach(check);
        playerCollisions.forEach(collisionCheck);

It basically forces the detection in the whole map
Its dirty, I know.

I've found a fix but it includes removing the split
go to config.json and change this  "limitSplit": 1,

The problem I have is that smaller player is eaten only if it is in the center of bigger player, no matter what the size different. Can someone show what to change to make it that smaller player is eaten as soon it is completely under bigger player?

I made a sort of fix by finding the code in server.js (line 538) and removed the multipliers. As far as I know it is working much better.


Enable NCTL regression test for querying auction-info

We have written an nctl regression  test that ensures we can query for historical auction data in a Protocol version before 1.4.0, however that test needs to be wired up to be run. We have confirmed that the test does indeed work and it needs to be wired up with a change to the shell file that works with the global-state-update-gen tool.
The PR introducing the test: https://github.com/casper-network/casper-node-private/pull/58

PR: https://github.com/casper-network/casper-node-private/pull/68

merged


Add DockerCon21 banner on the homepage

Signed-off-by: Usha Mandya<EMAIL_ADDRESS>
Updated the banner for DockerCon21
Updated the registration URL
Added a new image
Deleted the DockerCon20 image

@thaJeztah @StefanScherer PTAL


typealias Chebyshev{1} Ultraspherical{0}?

I'm not even sure this is possible, but it would in principle allow for
typealias Chebyshev{2} Ultraspherical{1}

and then the third and fourth kind polynomials could be Chebyshev{3} and Chebyshev{4}.

I think it might be better to do
function Chebyshev(k::Integer,d)
	if k==1
		Chebyshev(d)
	elseif k==2
		Ultraspherical{1}(d)
	elseif k==3
		Jacobi(-0.5,0.5,d) 	# may not have correct normalization
	...
end

On 8 Jul 2015, at 5:50 am, Richard Mikael Slevinsky<EMAIL_ADDRESS>wrote:
I'm not even sure this is possible, but it would in principle allow for
typealias Chebyshev{2} Ultraspherical{1}
and then the third and fourth kind polynomials could be Chebyshev{3} and Chebyshev{4}.
—
Reply to this email directly or view it on GitHub https://github.com/ApproxFun/ApproxFun.jl/issues/211.

Ok. Is it true then that each kind of Chebyshev polynomial has a fast transform (some form of DCT or DST) at each kind of point, i.e. 16 fast transforms in total?

I think it’s true but not sure how to do it for 3/4 kind

On 8 Jul 2015, at 5:52 pm, Richard Mikael Slevinsky<EMAIL_ADDRESS>wrote:
Ok. Is it true then that each kind of Chebyshev polynomial has a fast transform (some form of DCT or DST) at each kind of point, i.e. 16 fast transforms in total?
—
Reply to this email directly or view it on GitHub https://github.com/ApproxFun/ApproxFun.jl/issues/211#issuecomment-119475832.

Yes, sure. This is true.   There are 4 types of Chebyshev polynomials and 4 sets of Chebyshev points.  This gives 16 transforms.  Each one is a diagonally weighted discrete cosine or sine transform.l computed via FFTs.  In Chebfun in the commands chebfun.dct(), chebfun.idct(), chebfun.dst(), and chebfun.idst() I coded up all 16 DCT and DST transforms and their inverses just for this purpose.

Great! This is actually what I wanted from this issue.

I guess the chebfun case callse fft/ifft?  Probably all 16 can be made more efficient by calling FFTW….

On 8 Jul 2015, at 6:18 pm, Alex Townsend<EMAIL_ADDRESS>wrote:
Yes, sure. This is true. There are 4 types of Chebyshev polynomials and 4 sets of Chebyshev points. This gives 16 transforms. Each one is a diagonally weighted discrete cosine or sine transform.l computed via FFTs. In Chebfun in the commands chebfun.dct(), chebfun.idct(), chebfun.dst(), and chebfun.idst() I coded up all 16 DCT and DST transforms and their inverses just for this purpose.
—
Reply to this email directly or view it on GitHub https://github.com/ApproxFun/ApproxFun.jl/issues/211#issuecomment-119488770.

Yes, they use fft() and ifft(). I think FFTW only has type 1 DCT and DST transforms though...

Oh OK, but these transforms are probably less important than type 1 and 2, so the extra factor of 2 is tolerable

On 8 Jul 2015, at 6:36 pm, Alex Townsend<EMAIL_ADDRESS>wrote:
Yes, they use fft() and ifft(). I think FFTW only has type 1 DCT and DST transforms though...
—
Reply to this email directly or view it on GitHub https://github.com/ApproxFun/ApproxFun.jl/issues/211#issuecomment-119496603.

And there are things like DCT of type  3 is really a IDCT of type 2.  I forget all the interconnections.   Yeah, 8 of the transforms are truly exotic!


Add Cookie consent banner

the cookie consent banner only adds the Google Analytics script to the page when the user accepts the cookie.

@Martinsos here are some answers to your Qs:

So what are we doing here: we are adding the banner where they agree to cookies. Ok. How is that connected to our analytics? So if the agree, we will activate the analytics, is that it? Otherwise, analytics are not collected.

Exactly!

What about any cookies that we might use for other stuff? I don't think we use any though hm.

Nope. But currently, by putting analytics scripts in the head section of the config file causes them to load or be reloaded on every page load/refresh. Therefore, when using a consent banner, we can't add our analytics scripts in the expected Wasp manner.

What about having some docs for this? Shouldn't those also be part of this PR?

Definitely. Docs are on a separate branch though. I would add them after this PR gets merged.

What about e2e test for this, would that be interesting?

Yeah, possibly. I guess checking to see if the Google Analytics cookie (e.g. ga_...) is present or not is enough.

It feels a bit confusing to me that they have the place to put analytics in head, but then we also have cookies, and they have to delete one or the other hm. Would be awesome if they could choose what they want, but I guess that would be too much right now. But if we had docs we could call it out there, make it very clear it is a choice and what they have to do.

Perhaps we could add the code in the docs only, and if they want to opt-in to a using a cookie banner, they can add the component + config, and not add the script to head. How does that sound?

Oh man, this brings on some PTSD :smile:
Anyway, it's not as simple as it seems.
To answer some of the questions.
@Martinsos wanted to know what falls under GDPR and cookie consent.
In short, there's no such thing as a "Cookie law."
It's a very confusing unofficial term that trips people up all the time.
GDPR is a "Data regulation law". It never mentions or cares about cookies, local storage, session storage, or any kind of technology sites may use to achieve data storage and collection.
In short, all you need to know is:

Under the GDPR you can only store personal data that is necessary to provide the service you are providing. For everything else, you need opt-in consent.

It doesn't matter at all how you store this data (cookies, local storage, Google Analytics, etc.). It only matters whether you store it or not.
To complicate things, even though it's enough to offer only "reject all unnecessary" and "accept all," most companies prefer to divide the non-necessary data into subcategories (analytics, marketing, etc.).
This is because some users might be okay with sharing their data for analytics but not for marketing. Companies want to get as much data as possible, so offering subcategories might help them collect just a little more.
I haven't seen the banner Vinny implemented. However, if it does offer subcategories, we must make sure they are honored (e.g., we can have them accept "analytics only" and then go on to collect data used for marketing).
As far as I can see, the current setup we use for GA can also be used for GTM (Google uses GTM's setup for setting up GA), and GTM can do all kinds of stuff our banner might not expect it to. Therefore, I recommend we stick with the "accept or reject everything banner" and don't offer subcategories. (that might be exactly what it does, I haven't run it).
Also, we should make sure not to show the banner if they're not collecting any extra data (i.e., using analytics).

@sodic thanks for the nice explanation!
Ok, I agree with the logic of by default having "reject" or "accept all", that makes sense. Further than that is up to developers, they can customize it further how they like. What we are giving them is an easy way to get going with cookies.
@vincanger

e2e tests -> if it is too complicated we can skip them, but having them ensures it all keeps working, so up to you, I think you will best be able to decide what makes sense.
adding code to the docs only -> yeah hm, that is an "issue" we have recently, with features that are not super core, how to best have them -> added to the code, or as part of the docs. If they are part of code, we can do e2e tests on them. But some stuff is just too much.
We could do though a separate open-saas app we are e2e-testing that is not the same thing as template, and there we can put everything, but I guess that would be too much at the moment. It would be cool if we had a mechanism for choosing what you want: I want cookies, I don't want them. I want analytics, I don't want them. I am not sure what is best at the moment I have to admit. Either we put them in and it is quite a bit of stuff then to remove, or we don't and we don't have a good way to test it. I will leave it to your intuition of what is best for open-saas's users. But we should start thinking about ways to offer people programmatic choice when creating an app, that would up our game quite a bit. Should we open an issue for that?
docs on separate branch -> ah yes, I remember something like that! Why is that so? Because on main is template, and on release is what is actually published as docs + demo app, so it is not the same thing? Could you shortly explain the reasoning behind the split, how it works, here, even if slightly off topic?

@Martinsos

added e2e tests for accepting and rejecting cookies
I decided to leave the code in template. Because it is a separate component, it's easy enough to remove. And if they're serious about building a SaaS, it's nice to have that whole thing figured out for you already.
The "docs on a separate branch" issue we're discussing in the other issue, so I'll leave that for there.

Approved! I did left some comments though so please check those out, but I think the main idea is fine. Once you take care of those, feel free to merge.
So next are docs?

Next would be docs and updating landing-page to let people know we have e2e-tests


Update dev to match mains ci-cd workflow

Describe your changes
Updates the ci-cd workflow in this branch to better tag each release accordingly. These updates were also forcefully pushed up into each release branch, which was the easiest way to auto tag each of our releases. Checking docker hub now we have tags from 0.1 to 0.13, latest (main), and experimental (dev). The experimental tag will update once this PR gets merged into dev: https://hub.docker.com/repository/docker/codexrems/pims/tags?page=1&ordering=last_updated
Issue ticket number and Jira link
REMS-491
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

[ ] Review the code changes and make sure they all make sense and are necessary.
[ ] Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

note: do not click the update branch button below as that will merge changes from dev into main that we do not want yet - unless we want to make an iterative 0.13.1 release or something similar in which case merging can be performed for that release


API mocking

As part of merging https://github.com/babbel/rollbar-go/ (per #1) into our own Rollbar API client, we need better API mocking.
The existing tests for https://github.com/babbel/rollbar-go/ do manual API mocking.  It would be better to use an open source mocking tool.
The internal Rollbar API client in the jmcvetta provider uses Resty as a REST client.  Resty supports supports httpmock for mocking.  Therefore that's probably a good choice.

API mocking with httpmock is now working:  https://github.com/rollbar/terraform-provider-rollbar/blob/919f3ca70c2a74123a37883ad2cfad027b8e41ab/client/project_test.go#L13-L16


Fix ineffassign variable

Change unused variable named to underbar
Handling ignored error
Signed-off-by: Daehyeok Mun<EMAIL_ADDRESS>

@daehyeok there were a couple of recently merged ineffassign PRs incorporating these fixes, so I'm going to close this pr. Feel free to open a new one if there are more ineffassign errors to address.


Update CORENLP version

Right now IEPY is using corenlp 3.4.1
I understand that the main reason was to not require java8 (which is not provided by default on several linux distros), but stanford guys already release 3.5.0 and now 3.5.1 and I'm tempted to do the switch.
Maybe can be an option for the user (not sure, will make more confusing the installation from scratch)

Done on release 0.9.4


Creaturenex/issue2865

Corrected the spec. I did a search for non diaper and only changed the zero-values specs, I missed the test-values spec. Changes made and tested file locally with rspec and this spec passed.
Checklist:

I have performed a self-review of my own code,
I have commented my code, particularly in hard-to-understand areas,
I have made corresponding changes to the documentation,
I have added tests that prove my fix is effective or that my feature works,
New and existing unit tests pass locally with my changes ("bundle exec rake"),

Resolves #2865
Description
see above
Type of change

Documentation update

How Has This Been Tested?
tested spec in question locally.
Screenshots
n/a

Can you confirm that that last failure is not relevant to the code I wrote? logs show it might be
rspec ./spec/requests/distributions_requests_spec.rb:334 that might be causing the issue
Distributions While not signed in GET #calendar with a correct hash id should render the calendar
There are other failures as well but have the note
Pending: (Failures listed here are expected and do not affect your suite's status)

application_helper line 61
purchase_system_spec line 251

Hello Edwin I use local history for vscode which saves a copy of the file
everytime I save a file. Helps me see the difference in the file between
saves as opposed to pushed git commits.
https://marketplace.visualstudio.com/items?itemName=xyz.local-history
On Sun, May 29, 2022 at 9:09 AM Edwin Mak @.***> wrote:

@.**** commented on this pull request.
In .gitignore
https://github.com/rubyforgood/human-essentials/pull/2954#discussion_r884268613
:

+# plugin history
+.history/
Curious, what generated this folder that caused it to have to be ignored.
—
Reply to this email directly, view it on GitHub
https://github.com/rubyforgood/human-essentials/pull/2954#pullrequestreview-988620470,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADS27EQ35QYGCYLGKUJ4EE3VMNT7BANCNFSM5XCLIZNQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

lgtm

Thanks for the PR :)


Permission issue not honored in glob

Installed fsspec from the master branch, Python 3.6.8.
For at least in HDFS filesystem, the permission issue that raises the IOError exception would get excepted and fail silently.
The exception raised from user code:
OSError: HDFS path exists, but opening file failed: /tmp/testfile

The problematic snippet from fsspec:
https://github.com/intake/filesystem_spec/blob/801021bab0139657b716c98efbd9734ed3cebce4/fsspec/spec.py#L385-L388
Proof of the problem:
In [37]: try:
    ...:     raise OSError()
    ...:     print(1)
    ...: except IOError:
    ...:     print(2)
    ...:
2

Some questions:

Why IOError catches OSError?
Should IOError be replaced with something specific?

I will continue looking and update the thread or raise a PR.

This is actually the expected behavior, as per os.walk, no-permission dirs will give an empty generator as well.
bash-4.4$ ls -l /var/log/audit/
ls: cannot open directory '/var/log/audit/': Permission denied
bash-4.4$ python
Python 3.6.8 (default, Aug 18 2020, 08:33:21)
[GCC 8.3.1 20191121 (Red Hat 8.3.1-5)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> list(os.walk("/var/log/audit/"))
[]
>>>

closing since this is not a bug.


[SYSTEM]: Delta Green

Discord Username
killbotvii#1996
System
https://github.com/TheLastScrub/delta-green-foundry-vtt-system-unofficial
Notes on the Support
It’s meant for a modern setting BUT has a lot of fantasy elements anyway due to the nature of it being Lovecraftian horror.
That said, even just flickering flashlights and the like would add a whole lot.

Hi! I will add support for this system on the next release!


Suggestions and typo corrections for MANUAL.md and input yaml

I figured this was the best way to make my recommendations stand out.

Thanks for the Critique, Once you rebase and adress comments, I can merge this

continued in #47

resolved in #48


[2.0] Remove # coding: utf-8

Removes # -*- coding: utf-8 -*- and friends.
Requires https://github.com/getsentry/sentry-python/pull/2640

General Notes
Thank you for contributing to sentry-python!
Please add tests to validate your changes, and lint your code using tox -e linters.
Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

Yes, I skipped that one because of this: https://github.com/getsentry/sentry-python/blob/715c5a63839a04f38fbf90ab23ac072f1dd194db/tests/integrations/grpc/grpc_test_service_pb2.py#L2C1-L2C59

Fair enough, approving now!


chore(trezor): Update to Trezor Connect v9

Hello from Trezor!
We are preparing a GA release of Trezor Connect v9.
Wanted to see if you tests pass with the new version, though I'm uncertain if the tests actually test anything Trezor Connect releated.

@Hannsek and @sime thanks! we will go ahead and test it out

we will include this in a future release!

added in #149

Hi @kvhnuke
Looks like you did a minor upgrade to Trezor Connect and are still using v8.
V9 is actually a new package: @trezor/connect.


Middle layer STL file chirality.

I am trying to print the ergodox tentable middle layers and it looks like the STL files are meant to be mirrored before printing to get both sides--is this correct?
Thanks.

To answer my own question, it seems like the middle layer for the is reversible. I've printed two of the same and they both fit fine, although it means the two sides aren't symmetrical.
I've attached a mirrored copy of the model though, in case anyone wants it.
iris middle layer ergotox tent kit left right.zip


⚠ ClamAV has degraded performance

In 9b611da, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 82 ms

Resolved: ClamAV performance has improved in 13c45e3 after 5 minutes.


Installation: improve FreeBSD instructions for Manual Build

Some meta notes:

I don't like CMake, so don't expect me to fix Hyprland (unlike other hyprwm projects)
Clang/libc++ 16 in FreeBSD base (unlike ports) is currently WIP and may take ~1 year to propagate into any -RELEASE.

huh why is cmake linux only?

huh why is cmake linux only?

See https://github.com/hyprwm/Hyprland/pull/2209

@jbeich has anything changed since 4 months ago?

Not much:

Both CMake and Meson instructions still work
FreeBSD 13.3/14.0 haven't been released yet, so building with GCC is still easier

105b55239eba added meson subprojects update but it isn't very useful compared to explicit git clone --recursive (or git submodule update --init --recursive):
$ meson subprojects update --reset
Updating udis86...
  -> Cannot update subproject with no wrap file
Updating tracy...
  -> Cannot update subproject with no wrap file
Updating hyprland-protocols...
  -> Cannot update subproject with no wrap file
Initialized empty Git repository in /tmp/Hyprland/subprojects/wlroots/.git/
remote: Enumerating objects: 480, done.
remote: Counting objects: 100% (480/480), done.
remote: Compressing objects: 100% (466/466), done.
remote: Total 480 (delta 27), reused 160 (delta 5), pack-reused 0
Receiving objects: 100% (480/480), 773.01 KiB | 300.00 KiB/s, done.
Resolving deltas: 100% (27/27), done.
From https://gitlab.freedesktop.org/wlroots/wlroots
 * branch            c74f89d4f84bfed0284d3908aee5d207698c70c5 -> FETCH_HEAD
HEAD is now at c74f89d Avoid using memcpy() to copy structs
Applying diff file "wlroots-meson-build.patch"
Updating wlroots...
  -> c74f89d (grafted, HEAD) Avoid using memcpy() to copy structs [Simon Ser]

$ meson setup build
$ meson compile -C build
[...]
../subprojects/wlroots/include/wlr/render/egl.h:19:10: fatal error: 'wlr/config.h' file not found
#include <wlr/config.h>
         ^~~~~~~~~~~~~~

$ find . -name config.h
./build/subprojects/wlroots/include/wlroots/config.h
./build/subprojects/wlroots/include/config.h

$ cat subprojects/packagefiles/wlroots-meson-build.patch
[...]
-install_subdir('wlr',
+install_subdir('wlroots',
[...]

Both CMake and Meson instructions still work

From this PR, otherwise Meson fails.

but it's broken outside of Nix

Can I fix it somehow or is it better to just not use meson subprojects?

Better remove wlroots.wrap. It's not consistent with other subprojects (e.g., hyprland-protocols, udis86) or CMake support.
Downstream I use git submodule instead of meson subprojects and system wlroots (a la Nix), so don't need synthetic soversion bump.

Alright, I'll remove it soon (unless I forget).

Rebased and adjusted dependencies to the current Hyprland and FreeBSD versions.

Is there anything left to do in this PR or is it ready? @jbeich

Tested both Meson and CMake instructions - still good.

Wait, --skip-subprojects may be wrong for the plugin API.

Is there anything that can be done on the meson side, so we don't have to include all the commands here? The wlroots.wrap file used to patch the subproject so it properly installed headers, but now I don't know of a better approach.

I've dropped Meson workaround and rebased after aquamarine switch.


React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components).

So we have a bug here :( this is hard.. I'll get it tho..

It's super hard, I need to get this solved fast.. My milestone is overdue, I'll give it 2 more days.

Apparently in Countdown it was:
export class Countdown extends React.Component {
instead of
export default class Countdown extends React.Component {
which caused it to not export the class properly.. It's fixed now and the app is nearly complete..


A divider between evemail messages

Small feature request.
When the evemail fires off, if more than one message is sent too close, it jumbles them together, making it hard to see there were two messages end and begin.

Anyway to add a spacer or a divider line to help the visual of message dividers?

File: /src/plugins/onTick/evemails.php
Line: 162
Adding in a line before the Mail By section will allow it act as a divider.
Looks like shibdib already got it sorted though.


Code Refactorings

  Please Check The Preview

General code refactorings, please
ask if you have any questions.

I checked it works. Thank you!!

Of course still more can be done~


build(deps): update spring dependencies

Tested with Messaging-Services Test-Connector and Dataspace Connector main-Branch with tests enabled.


Failed to resolve dependency 'react-native-pure-chart@*' (Network request failed)

Do you understand that any Expo CLI issues opened in the core Expo repository will be closed?
Yes

duplicate of #115


chore: queue up all fs actions in memory storage

Closes #1847
Closes #1853
(hopefully once and for all 😓)

Apologies if this is not the place to ask or if there's an easy way to find out, but I can't seem to tell whether this fix has been released yet. It was merged into master before v3.3.1 was released, but wasn't in the release notes. I'm running into the same issue as #1847 on v3.3.1, and am not sure if I should make a new bug. Thanks in advance for any clarification.

Yes, this is released as part of 3.3.1 - I'd suggest using refined github extension, you will get those nice things like a note about a PR being part of some release :]

but wasn't in the release notes

chore commits are not part of release notes, only feat/fix/perf + breaking changes

I'm running into the same issue

We are aware of this and working on a proper fix. Right now it seems to be some race condition, possibly in some of the lower levels, not really in our code.


Some small documentation discrepancies

Collection.insert()

Documentation and example is talking about the document(obj) function, which seems to have been renamed to insert(obj). At first I didn't realise that and I was wondering why I couldn't call the  document function so I looked at the source and the comment here is rather confusing, especially the last line :-)

Loki.loadDatabase()

Documentation is missing the inflate option (btw "inflate" is a rather confusing word in this context, "loader" like in the source seems clearer imho)

These are fixed, thank you.


cannot pass delta="fossil" argument in client new_subscription method

in example.py file say when you create new subscription (client.new_subscription):
--- # you can pass delta="fossil" too
but new_subscription function does not  have "delta" argument.
so when you try pass delta argument to new_subscription (client.new_subscription(..., delta="fossil") throw an error:
--- Client.new_subscription() got an unexpected keyword argument 'delta'
how can pass delta="fossil"to new_subscription and how can i enable fossil algorithm for receive data in python?

Hello @patterniha
Fossil delta compression support has been merged to master just a couple of days ago - it will become available in the next release, I think today or tomorrow.

Mm, btw - need to fix the example before the release, because it was eventually changed to ENUM - https://github.com/centrifugal/centrifuge-python/blob/4795ccfae07d3c02735fffc8b3550499ce2000d8/centrifuge/client.py#L211
client.new_subscription("channel", delta=DeltaType.FOSSIL)

Released in https://github.com/centrifugal/centrifuge-python/releases/tag/0.3.1


Add output_file parameter for type -onboarding

Adding an accepted parameter for type -onboarding to define the output file. By defining a unique output file we may find more use cases where a generic wizard/walkthrough would be helpful. This was brought up in #230

Failure was due to the fact OnboardingData is now expected to have outputFile and was not present in the test useCase's.  It is guaranteed to be set when onboarding payload is created outside OnboardingData in NotificationObject:init()
(148) self.payload?.outputFile = dict["output_file"] as? String ?? Constants.storeFileName
onboarding tests updated and passing


[Microsoft.StorageSync] Add new cloud tiering status for 2019-10-01 protocol

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[x] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

@pilor Thanks for approving the changes.

/azp run automation - sdk

Looks like Subscription's readme.go.md is out of date and did not get updated. Could you please review the logs and see if you can get automation SDK GO to pass?

/azp run automation - sdk

Looks like Subscription's readme.go.md is out of date and did not get updated. Could you please review the logs and see if you can get automation SDK GO to pass?

@allenjzhang Sorry for the confusion, I didn't intend to change the subscriptions readme.md file. I reverted that change.

/azp run automation - sdk

@allenjzhang Thanks for your help with this pull request. It looks like it's ready to be merged.


Adding Open Interpreter to Devika

Integrating Open Interpreter with Devika in scientific research . Researchers could ask questions in natural language and receive insights from complex datasets, like identifying trends or generating hypotheses. This would improve data exploration and scientific discovery.
Open interpreter has internet acces

True, This option will boost the case and explore the power of Devika.


Duffel Bag - Given Rumiabox's Challenge Book, fix relic so it works with a double of itself (or don't allow that...)

Ok, best way to solve this is to fix Duffel Bag to work with a copy of itself. Now, how I'm going to do it...

Ok, best way to solve this is to fix Duffel Bag to work with a copy of itself. Now, how I'm going to do it...


Added Ada 2022 Reference Card

I'd put it in the Reference section.

Sorry, @bracke, I don't follow you. Do you mean the Docs link in the GitHub footer?
I mean that you have placed the link to the reference card in the Education > Online Books section of the list. I think the card should be listed in the Education > Reference section, instead.

@mgrojo  Ah, sorry I misunderstood.
I agree the location you mention makes sense.
Can You change it?

Moved to Reference and merge. Thanks!


Allow to change font using format tags

This would be very useful and will ameliorate the need to split each format in many labels that can be separately configured. Nevertheless if you're moving to pango I believe most of current format tags will be redundant after the inclusion of pango markup.

There is already a %{T} tag where you can specifiy the font that is used after it. See the Wiki for an example.
When/If we move to pango, we will not deprecate the lemonbar format tags because they are very widely used.

Cool! Do you want me to add some doc to https://github.com/jaagr/polybar/wiki/Formatting? After reading that I got the impression that the tag list was exhaustive and T is missing there.

Done https://github.com/jaagr/polybar/wiki/Formatting#font-t


[UMC] Permissions List shows us some of permissions

Hi team,
The docs do not mention about 'Microsoft.Maintenance/configurationAssignments/delete' and 'Microsoft.Maintenance/maintenanceConfigurations/delete'.
'Microsoft.Maintenance/configurationAssignments/delete' seems to need to remove VMs from Maintenance Configuration.
'Microsoft.Maintenance/maintenanceConfigurations/delete' seems to need to delete Maintenance Configurations.
Could you update the docs to show us all of Permissions for Microsoft.Maintenance?
In addition, I am glad that you also include Microsoft.Maintenance actions in the list.
https://learn.microsoft.com/en-us/azure/role-based-access-control/resource-provider-operations
Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d9d8d677-81cf-7bfb-73a9-198ed21d37f8
Version Independent ID: 7d5f53cb-c796-f93e-93a8-c2b044475313
Content: Update management center (preview) overview
Content Source: articles/update-center/overview.md
Service: update-management-center
GitHub Login: @SnehaSudhirG
Microsoft Alias: sudhirsneha

@m-yuka746 Thanks for your comment. We will review the issue and get back to you shortly.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


[stable/traefik] : running on minikube

Is this a request for help?:
help
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Version of Helm and Kubernetes:
helm :
Client: &version.Version{SemVer:"v2.6.0", GitCommit:"5bc7c619f85d74702e810a8325e0a24f729aa11a", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.6.0", GitCommit:"5bc7c619f85d74702e810a8325e0a24f729aa11a", GitTreeState:"clean"}
kubernetes : v1.6.4 running in minikube v0.20.0
Which chart:
stable/traefik
What happened:
I tried to install traefik on minikube. I changed the service type to NodePort in values.yaml. Also I used traefik.local as the domain for dasboard ingress. Opening traefik.local/ in browser gives ERR_CONNECTION_REFUSED on chrome
What you expected to happen:
Using traefik.local in browser should open traefik dashboard
How to reproduce it (as minimally and precisely as possible):
install minikube
add traefik.local <IP_ADDRESS> to /etc/hosts
run helm init to install tiller
helm install stable/traefik --values=values.yaml
Use this values config file
Anything else we need to know:

I think there's an error in your expectations. Requesting traefik.local in your browser is implicitly requesting http://traefik.local:80 (port 80). The port that the service is mapped to on the minikube VM is almost certainly not port 80.

ok I get it. the node port should be in the range 30000-32767 for minikube. But, the same logic goes for that port range. Currently the configuration does not allow for a nodePort mapping for a service of type NodePort. If I change the service type to NodePort then a random nodePort is assigned.

But, the same logic goes for that port range. Currently the configuration does not allow for a nodePort mapping for a service of type NodePort. If I change the service type to NodePort then a random nodePort is assigned.

Yes. That is a problem.
The common solution I have seen to this is the addition of the following to values.yaml:
## Further configuration for services of type NodePort
nodePort:
      ## Available port in allowable range (e.g. 30000 - 32767 on minikube)
      ## The endpoint will be exposed here
      port: 30080

And then a change like this in the Service definition:
{{- if eq .Values.serviceType "NodePort" }}
  nodePort: {{ .Values.nodePort.port }}
{{- end }}

I'd definitely LGTM (I'm a reviewer for this particular chart) if you would like to PR that change.

surely would do that!

Being able to set up a specific port for NodePort would be really useful. How about supporting a custom port for the https endpoint too? It's unlikely to be used in minikube, but can be handy in small production envs.
I have a single-VM k8s cluster built with kubeadm, where I map traefik's ports 80 and 443 directly to the host's port. In order to do that, I configure the port range to 80-10000 when creating the cluster and then manually change the assigned ports once traefik is up.  The benefit of this is that you no longer need a load balancer, which makes it easier and cheaper to host a few tiny personal projects. Right now my workflow is the following:
echo "
serviceType: NodePort
# ... other stuff
" > /tmp/values.yaml

## install
helm install --name=traefik stable/traefik --values /tmp/values.yaml

## manually change service's nodePort to 80 and 443;
## (only needed on a mini kubeadm cluster, not a kops one behind the LB)
kubectl edit service traefik-traefik

With fixed port definitions for http and https endpoints, the last step can be omitted.

Being able to set up a specific port for NodePort would be really useful. How about supporting a custom port for the https endpoint too? It's unlikely to be used in minikube, but can be handy in small production envs.

With that in mind, I'd amend my suggestion to this:
## Further configuration for services of type NodePort
nodePort:
  ## Available port in allowable range (e.g. 30000 - 32767 on minikube)
  ## The endpoint will be exposed here
  port: 30080
  securePort: 30443

How about
nodePort: 30000 # (undefined by default)
tls.nodePort: 30443 # (undefined by default)

Two reasons:

LoadBalancer's options are flat (i.e. loadBalancerIP, loadBalancerSourceRanges insteaed of loadBalancer.*)
nodePort may be used in LoadBalancer service type too
tls.nodePort makes sense since all other tls options are in this group too

Both options should be undefined by default because otherwise this may cause port collisions. Only those who know what they are doing will benefit from the pre-defined port numbers.

If the naming you suggest is in line with other charts, I support your option too. I haven't got a lot of experience with many charts and so justify the design in some sort of isolation.
What do you think of starting a meta issue with a list of debt being around? So that it was easy to find what to do once it's a good time for chart version 2.0.

@kachkaev yes... start a meta-issue.
Re: convention used by other charts, let's research it.

I referred some other chart configs. They all seem to support nesting nodePort under the parent entity. Posting a few for reference. The last link for nginx is directly relevant to us.
https://github.com/kubernetes/charts/blob/2e62901584bcfc883db7849c1fe0e2a457933317/stable/grafana/templates/svc.yaml
https://github.com/kubernetes/charts/blob/f6b1817962b45deda6b9d4f05c3774bad94281c1/stable/risk-advisor/templates/service.yaml
https://github.com/kubernetes/charts/blob/d39f1140849f2ad7244e143264b327d1d2d2b658/stable/jenkins/templates/jenkins-master-svc.yaml
https://github.com/kubernetes/charts/blob/cc6916ff6d1799e1e9208c5d5a0513d06d2c8179/stable/centrifugo/templates/service.yaml
https://github.com/kubernetes/charts/blob/54f070577bdb0a8b11687da91e9e08d84aab2020/stable/nginx-ingress/templates/controller-service.yaml

How about this-
service:
  # can switch the service type to NodePort if required
  type: LoadBalancer
  loadBalancerIP:
  # loadBalancerSourceRanges: []
  ## Useful to configure for service of type NodePort to get a specific nodePort
  ## Available port in allowable range (eg. 30000 - 32767 on minikube)
  # nodePorts:
  #   http: 31000
  #   https: 32000

I have sent a PR for the same #2106

@krancour What is the process to submit a new chart to this repo? I wanted to make a chart for apache ignite and share with the community.

@arunkjn no special process, afaik. (I've been deputized to do code reviews for this particular chart since I'm its original author, but I'm not a maintainer for this repo.) Just go ahead an PR it.
If you're new to writing charts from scratch, this command can help you get going:
$ helm create <new chart name>

This will create a directory for you containing a skeleton for a new chart.
Here's the guidance from Helm's own docs on how to write good charts:
https://docs.helm.sh/developing_charts/

@arunkjn I ran into the same problem. #2106 fix this? Since this PR is not merged, what should I do to access traefik ui from a browser?

yes @Catorpilor #2106 is supposed to address this. For now you can manually amend those changes in your chart locally.

For now you can manually amend those changes in your chart locally.

Don't overcomplicate things. Why not just pull the branch that #2106 was opened from?


Feature request: ability to set the current context to "none".

Hello!
First, I love the fact that you ported kubectx to PowerShell. This is really cool!
I would love to have a feature to set the context to "none" or empty. Is that possible? This would help to potentially avoid running commands by accident using the history and messing up a customer's production environment cluster for example.
Regards,
Stéphane

Hi @stremblay
I think this is a great feature idea.  I'll work on something this weekend.
Thanks

I'll be modifying this code
https://github.com/thomasliddledba/kubectxwin/blob/d0f6e22b9de44cf391d9fb7268acc5e47e7819dc/kubectxwin.ps1#L50-52
to the following
function switch_context($context) {
    if ($context -eq 'n/a') {
        kubectl config set-context no-context
        kubectl config use-context no-context
    }
    else {
        kubectl config use-context $context
    }
}

I'm using the n/a because namespaces can't use special characters referenced in RFC 1123 for creating namespaces.
kubectl create ns n/a
The Namespace "n/a" is invalid: metadata.name: Invalid value: "n/a": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')

Hi @stremblay
I made the changes requested.  Let me know if you have any questions or issues.
Thanks.

Amazing! Thank you! I will update immediately and let you know. :)

In case you want to make your tool as similar to the Linux kubectx, I think they use a flag such as -u --unset which I just found out was added last year.
kubectx -u, --unset       : unset the current context
This could be an alternative as well.

I like the unset option also.  I'll add that.  Give me a few days.


Update to version 1.2.0

Pull Request Test Coverage Report for Build 174

7 of 7 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 96.334%

Totals

Change from base Build 154:
0.2%

Covered Lines:
277

Relevant Lines:
280

💛  - Coveralls


User defined aggregations

Dask.dataframe has efficient grouped aggregations for known reductions like sum, max, min.
To do this is uses the apply-concat-apply pattern.  We could expose this pattern out to users to help support their own custom aggregations.  This likely just means renaming the currently private _aca_agg method, adding a docstring, and adding some documentation.

The signature of the function is:

def _aca_agg(self, token, func, aggfunc=None, **kwargs)

Can we derive the token from the name of the given func? None of the rest of public dask.dataframe API methods expose the token attribute. We can use dask.base.tokenize for this.
So my proposal is to create a new public aca_agg function that in turn calls _aca_agg.

I believe this is wrong https://github.com/dask/dask/blob/master/dask/dataframe/core.py#L2073 (edited):
def apply_concat_apply(args, chunk=None, aggregate=None,
                       columns=no_default, token=None, chunk_kwargs=None,
                       aggregate_kwargs=None, **kwargs):
    """ Apply a function to blocks, the concat, then apply again"""
    if chunk_kwargs is None:
        chunk_kwargs = dict()
    if aggregate_kwargs is None:
        aggregate_kwargs = dict()
    chunk_kwargs.update(kwargs)
    aggregate_kwargs.update(kwargs)

    if not isinstance(args, (tuple, list)):
        args = [args]

    ...

    a = '{0}--first-{1}'.format(token, token_key)
    if len(args) == 1 and isinstance(args[0], _Frame) and not chunk_kwargs:
        dsk = dict(((a, i), (chunk, key))
                   for i, key in enumerate(args[0]._keys()))
    else:
        dsk = dict(((a, i), (apply, chunk, [(x._name, i)
                                            if isinstance(x, _Frame)
                                            else x for x in args],
                                    kwargs))

Last kwargs should be chunk_kwargs. Otherwise the argument chunk_kwargs is ignored and only the extra kwargs are used.

So my proposal is to create a new public aca_agg function that in turn calls _aca_agg

This generally sounds good to me.  I recommend rethinking the name aca_agg if we intend to expose this to users.
I recommend looking at using both dask.utils.funcname and dask.base.tokenize when determining the name.

Your analysis of chunk_kwargs seems accurate to me.


GetAllExtensionDeploymentStatusEntries

The procedure GetAllExtensionDeploymentStatusEntries is publicly available but the first and only argument is Record "NAV App Tenant Operation" and this table cannot be used for Cloud development.
The procedure should be marked with Scope(OnPrem)
or
The table NAV App Tenant Operation should be accessible in Cloud development
or
Another signature should be available to make it usable in Cloud development.

That's a good suggestion. I am fixing it right now and the fix will be available starting with version 17.0. Is this timeline good enough, @nicolassaleron ?

Thank you for the update !
Depending on the decision made the timeline is fine (if solution 2 or 3 is chosen), or do not matter (if solution 1 is chosen :) )

It is option 3 that I have implemented for Wave 2. We will use a different table that the PTE developers have access to.
Thank you for the feedback !


Relax dependencies version requirements

Allow puppetlabs-stdlib 9.x

implemented in https://github.com/voxpupuli/puppet-unattended_upgrades/pull/231


Handle hadolint check failure with proper risk assessment

PR description
Suppressing/Ignoring hadolint warning about the last USER in Dockerfile being the root user - with reasoning that the root user has very specific job to do and then besu runs as besu user .
Follow up to https://github.com/hyperledger/besu/pull/7575
Fixed Issue(s)
Follow up fix to #4292

Still something not working https://github.com/hyperledger/besu/actions/runs/10927512262/job/30333865457 seems related to testDocker task

Looking into it, that gradle task runs fine locally on my Mac

Running it on Linux we get this report
<testcase name="File /var/lib/besu owner" time="0.000">
<system-err>File: /var/lib/besu: owner: Expected "root" to equal "besu"</system-err>
<failure>File: /var/lib/besu: owner: Expected "root" to equal "besu"</failure>
</testcase>

the expected user does not match

Fix for the CI issue https://github.com/hyperledger/besu/pull/7655

@fab-10 Thanks for taking care of it. I wasn't able to repro with act runs and was planning on uploading the reports to see what was failing. This is a better approach to wait for besu that waiting a few seconds .


Improve how we demonstrate the relationship between more data and reduced uncertainty

One potential point of confusion that came up in the May Pilot is that our pairing of the All Classes and All Students histograms muddles the relationship between an increase in the number of data points and a decrease in uncertainty.
We want students to see that the All Students histogram has a wider range of age values than the All Classes histogram because each class measurement is made with ~20x more galaxies than each student measurement.
However, the number of galaxies that goes into a particular age measurement is invisible to the user who is only looking at the histograms. Also, the All Students histogram displays a far larger number of data points than the All Classes histogram.
I think we can reduce this confusion by offering a button on the All Students histogram to randomly select N values to display (where N is the same number of age values being shown in the All Classes histogram).
I'm not sure if there is a way to make the number of galaxies involved in each age measurement more tangible to students looking at the histograms, but I think the random matched N displayed in the histograms might be a good start.
@johnarban and @heywooddogwood, does that seem like that would be helpful, or would it just add more confusion?

Well, randomly subsetting to have the same N will make it 🍎 : 🍎 , but I think it would be confusing.
I think we just need to carry the explanation of where the class age comes from through. basically reinforcing by repetition.
perhaps in age_dis1c we remind students

Here is a histogram of the class by class age measurements. Each measurement represented here is the best fit to an entire class's set of galaxy measurements. It's a large number of student measurements (and thus galaxies) aggregated into a single value

Like, what we want them to see is that each class count is an average over many students,  I think. That is what we would want them to put in the lac_bia3 box.

so you_age1c sort of moves on without making an point about this exercise. It was obvious why I fit a line to my data (to get an age). This kinda moves by without relating back to the histogram.

Perhaps the previous guideline (really tre_lin2c) can say something like

"Now that you've drawn what conclusions you can from looking at individual students' age measurements , let's turn back to your whole class's dataset. We can treat the entire class's set of galaxy measurements, graphed here, the same way we treated your measurements and derive a single age using you and your classmates measurements
Click....."

I feel like maybe it could more directly compare the two methods.


Not able to register modules or compile DAG on VS Code version 1.78.2 for mac

Hi,
I am not able to see any button to register or de-register modules after I updated VS code to version 1.78.2. Also from command as well when I try to register a module and compile the dag, nothing happens.

Hi @akundaliya!
I take note of your issue.
The extension is in a very early state. This week, I should be releasing an update that includes an extension walkthrough within VSCode itself and a logging channel to improve issue tracking.


Line Series shows unnecessary lines in UWP

Due incompatibility with WPF structure, UWP needs 2 paths to display correctly the fill of any LineSeries otherwise we get this ugly lines...
Version 0.8 introduces UWP 🎉 and will not include this fix for now

@beto-rodriguez You said that "UWP needs 2 paths to display correctly the fill of any LineSeries".  Are you implying that there is a workaround for this issue?  Can you elaborate please?

I already fixed it in my local 'designcleanup' branch, in general in this branch I am cleaning the design issues I faced to extend the library to UWP, this  fix should be soon uploaded in this repo.
In WPF I was able to create a Path object, at the beginning and end of the Path I added a LineSegment, in WPF the LineSegment  object has the IsStroked  property, it is set to false, sadly in UWP   we don't have this property, so the best workaround I could think of, is to add 2 different paths, the First one will draw only the stroked line, and the second one will draw the fill of the LineSeries

@beto-rodriguez I too have experienced the pains of missing items from UWP.  I am anxiously awaiting that fix 😄.  Your library is awesome, and I appreciate all the work that you continue to put into it! 💣


Flush messages from mock gossip in IPAM test

Refactored mock router, and added a flush() function which we then call every time gossip messages are generated in TestTransfer(), thus avoiding the problem that they may be dropped if the previous message has not been removed from the channel, or may not have arrived by the time we check what has happened.
flush() is not called in the other two tests that use the mock router; one of them hardly does anything, and the other benefits from the message-dropping behaviour, in that it makes it also a test of recovery from network issues.
Fixes #982.
Also replaced a Sleep with the flush, so the unit tests run faster.

flush() is not called in the other two tests that use the mock router; one of them hardly does anything, and the other benefits from the message-dropping behaviour, in that it makes it also a test of recovery from network issues.

But message loss is part of the mock router, so surely it gets tested anyway?
I'd rather see flush() everywhere.

The loss parameter is not actually set in the current codebase.  But I could do that.

I don't think it makes sense to call flush() in TestAllocatorFuzz(); all interactions with the mock router are indirect, via Allocator, and we don't know which ones will generate gossip, nor do we care when it is delivered. All we care is that the process of allocating and freeing makes progress at some reasonable rate. (I should note that isn't tested either, but is perhaps a separate issue)

I don't think it makes sense to call flush() in TestAllocatorFuzz()

ok.

anything left to do here?

I don't think there is anything left for the original issue.  I ran the ipam unit tests repeatedly in a loop for an hour with no failures.

ok. pls assign back to me then.

argh. Branched incorrectly. This was meant to be off 1.0.

Replaced by #1024


Prematurely removed python@2?

Python 2.7, while technically deprecated as of Jan 2020, is still a required dependency by many programs in the github community. I've read the some of the issues that have been closed were the  executive decision to pull python@2 from the homebrew formulae was made. The version that macOS ships with has yet to be updated. I feel that for the homebrew users that require homebrew as a depedency manager are at an obvious loss.  I request python@2 it be reinstitued into the core formula until a more appropriate fix is available.  Or..  provide some reasonable direction to bridge the gap. Thank you.

@mcstrassell09 For a few suggestions how to bridge the gap, see https://github.com/Homebrew/homebrew-core/pull/49796. Another solution would be to look for the deleted formula in the Changes tab of the PR, then copy it to a personal tap.
If you have any questions, read: How to create and maintain a tap.

Please always fill out the issue template, as requested.


Rename TextLabel to ElidedTextLabel

The new name gives a better explanation of what the class does.

You sure the documentation/header is not enough? besides it also adds click handling along with eliding. I think of it as a super QLabel, with added functionality that should be in QLabel anyway (long story here, even have a Qt issue/e-mail for it), I have it in every project I did for years, so for me it's a de facto.
I could do without the extra 6 chars appended, which will increase code width, with minimal gain in clarity.

I considered calling it ElidedClickableTextLabel, but thought you'd object to that name.
Yes, the doxygen comments help, but I still think that TextLabel gives the wrong impression.  I also asked a friend of mine (one of the leading programmers at a Vancouver game company), and he said "there's no way that should be called TextLabel.  Maybe @cperciva will chime in?

So, I don't know what this code does, but "TextLabel" seems like a rather vague name.  C++ is pretty verbose anyway, so I'd lean towards having a more informative name; whether "ElidedTextLabel" is the right one, I don't know.

ElidedClickableTextLabel definitely not. This is not Java code. How about ElidedLabel, this is after all based on QLabel with added elide support, there isn't anything special nor confusing about it.

I'm not as fond of ElidedLabel, but ok, I've updated the PR to use that.


DevTest Labs link actually linking to Lab

On page https://docs.microsoft.com/en-gb/azure/?product=developer-tools
The Azure DevTest Labs link is taking users to the Azure Lab Services documentation.
It should be pointing at this: https://docs.microsoft.com/en-us/azure/devtest-labs/
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Edge - Version 85.0.564.41 (Official build) (64-bit)

@martingbrown Please move this issue to https://github.com/MicrosoftDocs/azure-docs/issues

@rootsmusic I can't see any way to do that. Are you suggesting I just create a new issue there and close this one or am I just not seeing the move button?

Yes @martingbrown.


Recursive closing of html tag when you paste a closing tab inside an opening tab

If you (accidentally) paste a closing tag inside an opening tag, or before typing the closing >, Volar seems to recursively add the closing tag. It adds them repeatedly until you type something else.
The built in HTML extension does not seem have the same problem, and so I think it's Volar related.
See video below, I type <div then ctrl+v to paste the </div>.
https://user-images.githubusercontent.com/31130/209205292-02b91e91-1432-4e38-b68a-d56d2b3a670b.mov

Duplicate of #2238


Optimize README images

Issue

close #261

Overview (Required)

This PR references README images optimized by Squoosh.

An animated GIF file is not optimized because I could not find a reliable optimization tool for GIF files.

Links

Screenshot

Before
After

Thank you for your contribution!


v10 API upgrade

Summary
Update edpy to Discord's v10 API

Checklist

[x] If code changes were made then they have been tested.

[x] I have updated the documentation to reflect the changes.

[ ] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[x] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Remember to change the gateway connection URL

Can you remove the following and instead use the reason kwarg in .request please.
https://github.com/iDevision/enhanced-discord.py/blob/10badc134ac4a6eb24c37107cb1c35abd071fe35/discord/http.py#L713-L715
This was discovered in the Py-Cord server MESSAGE URL by @AlexFlipnote, @krittick and me. Alexflipnote has an open issue on their repo: https://github.com/Pycord-Development/pycord/issues/1109 (still marked as unconfirmed huh)