with_filtered_backtrace called on Test::Result::Unknown with strange feature file

To reproduce, create a trivial feature file:
➜  tmp mkdir features
➜  tmp touch features/accidental.feature

edit the file to become:
➜  tmp cat features/accidental.feature
Feature: A

  Scenario: S
  Scenario: S
    Given I begin

and run dry-run: cucumber -d
so you get:
undefined method `with_filtered_backtrace' for #<Cucumber::Core::Test::Result::Unknown:0x007fa2d1e32b98> (NoMethodError)
/Users/krukow/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/cucumber-2.3.3/lib/cucumber/formatter/legacy_api/adapter.rb:44:in `after_test_case'
/Users/krukow/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/cucumber-2.3.3/lib/cucumber/formatter/fanout.rb:16:in `block in method_missing'
/Users/krukow/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/cucumber-2.3.3/lib/cucumber/formatter/fanout.rb:15:in `each'

I was able to repro this issue on my machine and determined it was introduced in version 2.0.1. When I remove the first Scenario: S (the empty scenario), the error goes away. I'll look into fixing this - at the least, it seems like it should fail gracefully.

I created a PR against the cucumber-ruby-core repo correcting this error by adding a #with_filtered_backtrace method to the Cucumber::Core::Test::Result::Unknown class. https://github.com/cucumber/cucumber-ruby-core/pull/107

In Gherkin v4.0 the compiler does not create a pickle/test case if there are no steps in a scenario (see for instance feature file and pickles reference). Cucumber-Ruby does not use the Gherkin compiler, but maybe also the compiler of Cucumber-Ruby(-Core) should also be changed to not create test cases for scenarios without steps.

That would probably be a more ideal solution.

IMO the most reasonable behaviour for an empty scenario like this is an undefined result, since the scenario has yet to be defined with any steps.
in the pickles model, this empty scenario would disappear from the results, but I don't think that's what a business user who has recorded the name of the scenario would expect to happen.
I wonder if we should get rid of the Result::Unknown status altogether and default to Undefined

Maybe, although I've written scenarios like this just with the intention of not letting myself forget which ones I meant to write. I didn't notice or care whether they were included in the results.

Then again, I guess I am not really a business user, per se.

Anyway that's an academic discussion we can have later. This looks like a good fix for @krukow's immediate problem.

I'm looking at the core code to figure out how I can make the result undefined since I agree that would be better. Shouldn't be too hard. (Famous last words!)

I'm looking at the core code to figure out how I can make the result undefined since I agree that would be better. Shouldn't be too hard. (Famous last words!)

How about we merge the current solution first and then do that as a second iteration?

Works for me.

thanks 👍

I'm looking at the core code to figure out how I can make the result undefined since I agree that would be better. Shouldn't be too hard. (Famous last words!)

How about we merge the current solution first and then do that as a second iteration?

Could this hide problem that should be fixed. If the Result::Unknown status should not end up somewhere but it does, isn't failing immediately better than continue?

@brasmusson I don't think so, I just think we should open a second issue to make sure the better fix stays on our radar.

IMO the most reasonable behaviour for an empty scenario like this is an undefined result, since the scenario has yet to be defined with any steps.

The current behaviour when running and empty scenario is that its result is passed, so is it really reasonable that when using --dry-run its result becomes undefined?

The root cause of this issue is that when executing and empty scenario there will still be hooks executed (for instance the hooks applied by the PrepareWorld filter), which will change the status/result of the test case from Unknown to Passed, before any scenario step is executed. But when using --dry-run only the steps of the scenario will be "executed" by the runner and the status/result of the test case will changed from Unknownto either Skipped or Undefined. However if the scenario is empty nothing is changing the status/result of the test case from Unknown.
One option for fixing this root cause (to mimic the difference when using --dry-run or not for scenarios will steps), would be to when using --dry-run apply a SkippingBeforeHook (with the same behaviour as SkippingStepMatch) to change the status/result of the test case from Unknown to Skipped even when the scenario is empty.

Truthfully, I think it's more reasonable that the result be undefined even when there is no --dry-run flag.

Truthfully, I think it's more reasonable that the result be undefined even when there is no --dry-run flag.

👍
Having thought about it, I don't think we can simply eliminate the concept of an Unknown result - after all that is the true status of a test step that has been activated but is yet to be executed. I hadn't thought about those filters though Bjorn. Perhaps we need to adjust them to no-op on scenarios with no steps.
We could also possibly add a new filter (on the end of that chain) that implements this new rule about empty scenarios being undefined, by just adding a test step that fails with an undefined result.

I see a couple of arguments why undefined is not the right result of an empty scenario. Today undefined for a scenario mean, "there is at least one step the does not have a matching step definition". Using undefined for empty scenarios changes its meaning to something more vague like "you are not finished yet". But then also a scenario with only a Given step should be undefined, because until you have written a Then step you are not finished, right? not-executed seems to be a more accurate status for an empty scenario, since there were no step - nothing was executed.
Thinking ahead to parallel execution (discussed for instance in #924), the runner could in many cases be in a another process or on a another machine then the parser/compiler/UI. It that case there is a need for a specified interface between them. I think a lot of the success with the Gherkin re-write ("Gherkin 3"), parser/compiler implemented in 8 languages and counting, is due to the acceptance test data which are used to test all the implementations. I think that acceptance test data already has defined the interface from the parser/compiler/UI component to the runner component: the pickles. That is one reason why empty scenarios should no reach the runner, the other is, why send data to another machine for execution (a fairly expensive operation) when you know what is going to happen - nothing. I empty scenarios will not be sent to the runner in that case, why do it just because the parser/compiler/UI and the runner executes in the same Ruby interpreter?
I also like to point out that with the event based formatter like https://github.com/cucumber/cucumber-pretty-formatter, the formatter get the content of the feature file passed separate from the data from the runner, so such a formatter are able to determine whether any scenarios in the feature file was not executed. It may not easy/possible for the formatter to determine why, did not match tag expression, fail fast options used and failure occurred, empty scenario, etc, but as least it can determine what was not executed.

--dry-run shouldn't differ ... expected behavior is "run as regular test run" except the execution of steps ...
adding emtpy steps is "hacky" (just my 2cents)

I've manually tested Karl's bug and this should now be fixed in the next release. We can discuss this other issue (about how to handle scenarios without steps) elsewhere.


Create wireframes for trainee's user journey

We have already defined the first user stories for trainees. It is a good starting point for creating wireframes for their user journey.
 Wireframes should represent the user journey and not visual design. Think how a user moves from one screen to another and where they can find the desired information and actions.
Acceptance criteria

Wireframes must cover all defined user stories
Place a link or images in a comment when completed


metatags are not being populated when I use custom _document

I created a very simple _document element just to add the lang='en' to the html tag
import Document, { Main, NextScript } from 'next/document';
import React from 'react';
import flush from 'styled-jsx/server';

export default class MyDocument extends Document {

  static getInitialProps ({ renderPage }) {
    const {html, head, errorHtml, chunks} = renderPage()
    const styles = flush()
    return { html, head, errorHtml, chunks, styles }
  }

  render () {
    return (
     <html lang="en">
        <Main />
        <NextScript />
     </html>
    )
  }
}

The problem that I am facing is that the <Head /> is not rendered on the server (if I disable the javascript I see an empty head tag), but it is correctly populated dynamically on the client. Am I missing something or this is a bug?

https://github.com/zeit/next.js#custom-document
You're missing this bit:
import Document, { Head, Main, NextScript } from 'next/document'
<Head />

@timneutkens I was using the <Head /> in my ` component (same as the layout example in the repo) so I wasn't missing it. The head was populated on the client, but not on the server. If I had't include it at all I wouldn't see any head I guess (?)

You literally need to add <Head /> above <Main /> then it'll work, this is the sole reason it's not showing up on the server 😄 this head component is something different than next/head.

@timneutkens I see, thx a lot.


Issue with DTO and Deserializing JSON

Hello,
I'm facing an issue while trying to integrate this repository into my project, due to the deprecation of the previous implementation I was using  aelariane/mangadex-sharp.
As part of my project's architecture (trying to) adhering to clean architecture principles, I am unable to directly reference the repository in the front end.
To work around this, I've attempted to create a DTO.
Here's the sequence of events:
I copied the contents of the "models" folder from the repository into my project.
I addressed compilation errors as they arose during this process.
However, I'm encountering two major issues:
The JSON deserialization using System.Text.Json results in an empty object.
Additionally, I'm experiencing an error when using to Newtonsoft.Json.
I'm seeking assistance and guidance to resolve these issues. Any help or suggestions on how to properly integrate the repository, create the required DTO, and successfully deserialize JSON data would be greatly appreciated. Thank you!
Please let me know if you need further information or code samples to better understand the problem.
Newtonsoft.Json.JsonSerializationException: Could not create an instance of type MangaHunter.Contracts.Mangadex.Models.Relationships.IRelationship. Type is an interface or abstract class and cannot be instantiated. Path 'MangadexDto.Data.Relationships[0].Id', line 1, position 219.
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateNewObject(JsonReader reader, JsonObjectContract objectContract, JsonProperty containerMember, JsonProperty containerProperty, String id, Boolean& createdFromNonDefaultCreator)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateList(IList list, JsonReader reader, JsonArrayContract contract, JsonProperty containerProperty, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, Object existingValue, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType)
   at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
   at MangaHunter.BlazorServer.Common.Services.HttpClients.ApiClient.SendHandleResponse[T](HttpRequestMessage httpRequestMessage)

chat.openai.com/d8319a3e

Just to make something clear, there is no relationship between aelariane/mangadex-sharp and this repo.
I didn't realize someone had already used the name "mangadex-sharp" (that's my bad).
That being the case, there will be no overlap in how they are written and used:
I can already tell one major issue you're going to run into is that the other library uses Newtonsoft.Json where as my library uses newer System.Text.Json which are not compatible with each other. You can read more about the migration here.
There were a few things I had to tweak about the serialization system to get it to work correctly with the MangaDex models. You can find the code for these tweaks in this folder (look for any class that ends with "parser"). The relationships objects are handled via this class and have somewhat complex logic to ensure it works correctly.
Also, as far as I can tell, the other repo does not have a nuget package that you can take advantage of, where as mine does. You should strive to use the nuget package where-ever possible in order to get any updates or bug fixes that I release. You shouldn't need to copy any of the code from my repo if you use the nuget package, but it also won't be a drop in replacement for the older repo either.
Let me know if this helped, if not, you can reach out to me via my discord server or message me directly and I can see if I can assist you better there.

Closing as this isn't necessarily an issue with MD#.


Add a kaka-console-producer application

Nice as an example, and could be nice for shell scripting without the need of installing the JVM to use the one that ships with Kafka. E.g. this could be nice to ship a Kafka event on a deploy of an application.
@Shopify/kafka /cc @graemej

We could use Github's releases option to make pre-built binaries available as well, so people don't have to install the go toolchain either.

I am split between "tools" and "examples", I feel like that distinction is pretty fine... does it make sense to just put this in examples?

For me the distinction is that a tool is actually useful.  I actually want to install them on our infrastructure. Because of the versatility, the code is a bit harder to grasp. I would like to do binary releases of the tools so they are easy to install with chef.
An example on the other hand, is not really a useful application, but purely meant for studying to source code. The code is kept as simple as possible so it is easier to follow.
Does this difference warrant different directories?

Does this difference warrant different directories?

I guess, it just seems odd to have two separate subdirectories for programs that make use of the library.

Updated.

LGTM


Generated client include compilation error with unknown type

The below compilation error message includes when the generated client is built.

Affected connector:  ballerinax/launchdarkly
compilation issue

Compiling source
	ballerinax/launchdarkly:1.2.1
ERROR [client.bal:(747:163,747:231)] unknown type 'deleteFeatureFlagApprovalRequestFeatureflagapprovalrequestconfigbody'
error: compilation contains errors

This issue happened due to the given yaml as a reference for the requestBody section with an inline record content type.
That time logic picks the RequestBody name as the generated record name.

As discussed @NipunaRanasinghe, @aneeshafedo, There are two options we can solve above mentioned issue

Generate the inline record as-is for the request body.
Append the postfix _requestBody to the RequestBody name to ensure the uniqueness of the record name.
While this option does carry the possibility of sharing a name with a schema, it provides a user-friendly approach for those who prefer named records when invoking the API. This is particularly beneficial for records that contain more than 10 fields.

example:
...
paths:
  /projects:
    post:
      operationId: operation01
      requestBody:
        $ref: '#/components/requestBodies/deleteFeatureFlag'
      responses:
        '200':
          description: Feature flag approval request response
          application/json:
          schema:
            $ref: '#/components/schemas/Item'
components:
  requestBodies:
    deleteFeatureFlag:
      content:
        application/json:
          schema:
            type: object
            properties:
              comment:
                type: string
              date:
                type: string

Expected Ballerina record
// Generated record
public type DeleteFeatureFlag_requestBody record {
     string comment;
     string date;
}
...
remote isolated function operation01(DeleteFeatureFlag_requestBody payload) returns Item|error {}

Therefore we decided to apply the second option for the fix.

Issue : microsoft.dynamics365businesscentral connector was assigning generate json value when it has the requestBody scenario similar to the above issue.
Reason: Given connector's inline object defined without the schema type object.


Lack of any logging or debugging flags to assist in troubleshooting

This plugin goes through a number of steps to try to find credentials. But there's no logging or any way to debug which of the methods was tried, which were unsuccessful, and whether any credentials were returned.  I'm trying to work out if my env var is even being seen by this plugin, but there's no way to tell.

@lindsayismith what is your env var name and the nature of your credentials?
export GOOGLE_APPLICATION_CREDENTIALS='<path to your service account credentials json>' should do the trick. See https://cloud.google.com/docs/authentication/getting-started#setting_the_environment_variable for more on this set up.

Hi Dan,
My issue is specifically around the level of logging in this library, not a specific situation. My case is that I'm working on a Maven wagon that handles auth against my teams GCP service (https://github.com/GoogleCloudPlatform/artifact-registry-maven-tools), and our library depends on this one to get application default credentials.
I've been testing the scenario where a maven project is built and deployed from Jenkins using our Wagon. I've been trying to work out how our plugin behaves in different situations and what the right way to set ADC should be as we write guides to our customers.  Because the build is running within Jenkins, it's tricky to introspect how that build is run, and what the env variables are, what the system path is, etc, etc.
Because this library has a number of different paths it might take to find ADC, I think it would be very useful, not just for me, but for any customer trying to debug their credential exchange, if there was logging in this library that can explain which steps it has tried and which it settled on. In particular the DefaultCredentialsProvider.java class implements the search strategy, but doesn't give any logging about what steps it is trying or which succeeds.

Ah, OK. Let me investigate some more internally.


Set default elemental-operator USER

Picked a non-conflicting uid/gid, tested on v1.24.9-k3s2 with the recommended hardening options.
Fixes #317
Signed-off-by: Fredrik Lönnegren<EMAIL_ADDRESS>

@davidcassany ah, will change the obs dockerfile as well, good catch!
As for copying the passwd file I only think that works if the user exists on the host. I only got it working with the PSP using a numeric identifier.

The PR looks great, it shows how to fix the issue.
Anyway, wondering: as the user will be mapped to an host user, isn't there a policy for that in rancher clusters? The pod is an operator for rancher, so it is not a normal workload 🤔


picture in picture

I have two feeds. I'm trying to run one full screen, with a second one overlapping that feed on the bottom right corner of the screen. Is there anyway to get this to work and stop flickering / glitching.

This is not about displaycameras, but this can be done with showontop=true in Rpisurv https://gist.github.com/SvenVD/7b973cde2ce5dce6c8284606434e3a14

This is not about displaycameras, but this can be done with showontop=true in Rpisurv https://gist.github.com/SvenVD/7b973cde2ce5dce6c8284606434e3a14

Thank you, I will check this out and report back

No. That would require a custom build with layer support added. I started
to get into that a bit in the layers branch but never completed the work.
If you look at the code, it should be pretty easy to hack together.
Andy
On Sun, Aug 1, 2021, 4:43 AM ericmersino @.***> wrote:

I have two feeds. I'm trying to run one full screen, with a second one
overlapping that feed on the bottom right corner of the screen. Is there
anyway to get this to work and stop flickering / glitching.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Anonymousdog/displaycameras/issues/100, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHIYIKL3XQHY4DZLBAU2QHLT2UCJ7ANCNFSM5BK465AQ
.


Missing support for anything more than primitive patch matching

I got simple problem, got some "static" data in /data/ and favicons.
But if I add new path in ADD_METHOD_TO that i want to match every url (to then search in "db" and print what is needed) can't use negative regexp like "/(?!data){1}" - because drogon do some stupid "replace", also can't use any custom regexp, and crapy {1} match only to a first /, so need to add .* to match rest. Can't even use things like /([^d]|d[^a]|da[^t]|dat[^a]).* because drogon segfault when access any other url...

@PiotrZSL  As you said, this ADD_METHOD_TO only does primitive matching, in order to solve this issue, I added a new macro ADD_METHOD_VIA_REGEX in the PR #329.
You could use ADD_METHOD_VIA_REGEX(...,"/(?!data)(.*)",...) to implement your function, and the parameters mapping is also valid for subexpressions. Here is a example:
https://github.com/an-tao/drogon/blob/e8dc6dcba633ba8a0a0e79c98fc9726b2a384127/examples/simple_example/api_v1_ApiTest.h#L37
Sorry for confusing you, please check it out, thanks.

Thanks, should do a job...


[Task]: Setup the maven package for external plugin implementation

SubTasks
This task is only for setting up a new maven package and adding the basic methods with no logic. It will help in displaying these external plugins in the UI.

Completed with PR https://github.com/appsmithorg/appsmith-ee/pull/5748


please tell me finally how you are setting the image to a ImageView.

eg - how should i use the format Picasso picasso
like :
iv_image.setImageDrawable(ContextCompat.getDrawable(iv_image.getContext(), R.drawable.location_placeholder));
       or

Picasso.get()
.load(MediaURL)
.placeholder(R.drawable.location_placeholder)
.error(R.drawable.location_placeholder)
.memoryPolicy(MemoryPolicy.NO_CACHE, MemoryPolicy.NO_STORE)
.networkPolicy(NetworkPolicy.NO_CACHE, NetworkPolicy.NO_STORE)
.into(iv_image);

This doesn't seem related to the OkHttp 3 downloader at all.


[Android] Full screen loader whille course is upgarding

While implementing IAP on the legacy apps, it was seen that after processing the payments it takes some time for the course to upgrade. Considering design heuristics and for a more interactive approach, we have implemented a full-screen loader to show while the learners wait for their course to be upgraded.
Acceptance criteria:

The loader shows up after the payment is processed and the backend is unlocking the course content
The loader is not shown when upgrading is completed
The loader illustration should either be generic or should go with the theme of the app

Current implementation:
Video Demo

@farhan-arshad-dev @k1rill we need to update the rocket illustration to the following rocket icon in order to match the schema design system.
https://fonts.google.com/icons?selected=Material+Symbols+Outlined:rocket_launch:FILL@0;wght@400;GRAD<EMAIL_ADDRESS>

@farhan-arshad-dev  please have a look at the above loading screen and let me know if there are any questions.


Fix New Relic integration tests.

@vastin This PR supersedes https://github.com/aws-observability/aws-otel-test-framework/pull/240
Can you try testing with this?

@a-feld OK. I will run test with this PR.

@a-feld I tested this PR with https://github.com/aws-observability/aws-otel-collector/pull/392 and it passed mock test.

I have concern that /* is too wild that could mistake the other requests as valid data push request and have the invalid tests passed. Can we add /metric/v1/ and /trace/v1 in mock server as validation path?

Done! 😄

Thanks!


feat(to-observable-signal): refactor toObservableSignal to handle Obs…

…ervables and Subscribables
The refactor allows toObservableSignal to handle Observables and Subscribables, expanding its flexibility and usage. It introduces the ability to convert an Observable or Subscribable to a Signal & Observable, enhancing its adaptability. This change aims to improve the overall functionality of toObservableSignal by broadening its capabilities.

@all-contributors please add @nguyenphutrong for code


[meta]: Adding license

@liuheng92, thank you for your work! To enable others use your code for other projects, could you please add a license to your repo, explaining the conditions for fair use? Since the PyTorch implementation is licensed with Apache 2.0, this would look great from the legal side as well. I appreciate your time!

already added, thank you for your remind.

@liuheng92, thank you for your work! To enable others use your code for other projects, could you please add a license to your repo, explaining the conditions for fair use? Since the PyTorch implementation is licensed with Apache 2.0, this would look great from the legal side as well. I appreciate your time!

already added, thank you for your advice.


MWPW-155941: MAS aem.js:saveFragment

aem.js with saveFragment feature to support MAS Studio development.
Also changes the way mas.js is distributed.
mas.js full-fledged commerce with merch-card included.
mas.min.js commerce with prices and checkout links.
Resolves: MWPW-155941
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/ilyas/merch-card?martech=off
After: https://mwpw-155941-final--milo--yesil.hlx.page/drafts/ilyas/merch-card?martech=off

Test URL for QA:
https://mwpw-155941-final--milo--adobecom.hlx.page/drafts/ilyas/merch-card?martech=off

@Dli3 could you please take a look into the marketo tests failures? It seems that the latest condition changes in the tests are case sensitive.

Thanks @afmicka, I've fixed the tests and reran the job. Looks to be good now.
cc @yesil

I'll open a new PR with more changes.


Link in lifecycle should link to build log

Should have a log store that returns an HTML location, so we can put it wherever. Gist is a strategy

Fixed


go build fails macOS

Build Error: go build -o /Users/y/src/services/svc1/cmd/svc1/__debug_bin2562250829 -gcflags all=-N -l .
error obtaining VCS status: signal: segmentation fault
    Use -buildvcs=false to disable VCS stamping. (exit status 1)

mirrord.json
{
  "feature": {
    "network": {
      "incoming": "mirror",
      "outgoing": true
    },
    "fs": "read",
    "env": true
  },
  "target": "deployment/svc1"
}

command line
mirrord exec -f mirrord.json -- go build ..

source:
https://discord.com/channels/933706914808889356/1290590096185102348

I believe this will be fixed by #2846


[SPARK-26427][BUILD] Upgrade Apache ORC to 1.5.4

What changes were proposed in this pull request?
This PR aims to update Apache ORC dependency to the latest version 1.5.4 released at Dec. 20. (Release Notes)
[ORC-237] OrcFile.mergeFiles Specified block size is less than configured minimum value
[ORC-409] Changes for extending MemoryManagerImpl
[ORC-410] Fix a locale-dependent test in TestCsvReader
[ORC-416] Avoid opening data reader when there is no stripe
[ORC-417] Use dynamic Apache Maven mirror link
[ORC-419] Ensure to call `close` at RecordReaderImpl constructor exception
[ORC-432] openjdk 8 has a bug that prevents surefire from working
[ORC-435] Ability to read stripes that are greater than 2GB
[ORC-437] Make acid schema checks case insensitive
[ORC-411] Update build to work with Java 10.
[ORC-418] Fix broken docker build script

How was this patch tested?
Build and pass Jenkins.

Test build #100365 has started for PR 23364 at commit 363d28c.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6328/
Test PASSed.

LGTM.

Thank you for review, @dbtsai .

Test build #100365 has finished for PR 23364 at commit 363d28c.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100365/
Test FAILed.

Retest this please.

Test build #100375 has started for PR 23364 at commit 363d28c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6341/
Test PASSed.

Test build #100377 has started for PR 23364 at commit 0b71045.

Any ORC JIRA mentioned in the release impacts us?

Nice! https://issues.apache.org/jira/browse/SPARK-23458

Thank you for reviews, @gatorsmile ! Only our resource leakage patches impact us. The other stuffs are related OpenJDK and related stuff.

Test build #100375 has finished for PR 23364 at commit 363d28c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100375/
Test FAILed.

Retest this please.

Test build #100380 has started for PR 23364 at commit 0b71045.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6344/
Test PASSed.

Test build #100377 has finished for PR 23364 at commit 0b71045.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100377/
Test FAILed.

So far, one python failure, HiveClientSuite failure, and the last one is irrelevant TimSort OOM failure.
sbt.ForkMain$ForkError: sbt.ForkMain$ForkError: java.lang.OutOfMemoryError: Java heap space
	at org.apache.spark.util.collection.TestTimSort.createArray(TestTimSort.java:56)
	at org.apache.spark.util.collection.TestTimSort.getTimSortBugTestSet(TestTimSort.java:43)

Test build #100380 has finished for PR 23364 at commit 0b71045.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100380/
Test PASSed.

Merged to master.

LGTM as well


Add option to display raw characters/markdown in queries

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.
[X] I am only requesting a single feature. Multiple changes should be split into individual requests, with links between them.
[X] I believe my requested feature will be generally applicable to other users, not just me: it is not uniquely tied to my personal workflow.

🔖 Feature description
Allow task query results to show the characters in a task without any formatting (e.g., ==x== won't appear highlighted, and the exclamation points are still visible).
✔ Solution
Add an option to task queries to display the tasks with markdown formatting or without it.
❓ Alternatives
No response
📝 Additional Context
Tried doing this to see if any tasks were being neglected by my Tasks queries due to some unforeseen formatting mistake (e.g., putting a non-bulleted, non-empty line below the task). Compared the results of Regex queries with a Tasks query on all files in my vault, but found that many of the lines couldn't be compared directly when copy-pasting from the Tasks query since they contained equations/links/etc. that didn't retain their Markdown elements (e.g., highlighting characters) when being pasted.

Hi, I’m not at all clear what this is trying to achieve, and what the options are to address it.
There are no exclamation points in your example. And Obsidian source mode shows the raw task lines already.
Please supply as text (not screenshots):

Several example problem task lines
An example Tasks query
Specific information about what changes you want in Tasks behaviour, for the example you gave.

Sorry for the confusion. I meant to say "equal sign", not "exclamation mark".
As for source mode, that doesn't do what I'm aiming for. While it does show the raw task lines when viewing them in their original locations, it doesn't do so in a query block; instead, the query code itself appears.
Here's what I want: an option within Tasks queries to display the task text how it would appear within Source View. This would help preserve formatting when copying and pasting tasks from queries. This option could be a line added to a task query (e.g., "use source view").
Here are examples of how you'd use it:
Assume file "test.md" contains the following tasks (shown below in code block format for clarity):
- [ ] t\a\s\k 1
- [ ] **another** t\a\s\k
- [ ] __another__ t\a\s\k

Query A (without added option):
path includes test.md

Currently, copying and pasting its results would return the items in the code block below:
task 1
another task
another task

Query B (with added option):
path includes test.md
use source view

copying and pasting its results should return the items in the code block below:
- [ ] t\a\s\k 1
- [ ] **another** t\a\s\k
- [ ] __another__ t\a\s\k

Or, if including the task statuses is too difficult, it should return the items in the code block below:
t\a\s\k 1
**another** t\a\s\k
__another__ t\a\s\k

Is this an XY Problem?
Is the request really to have the ability to be able to copy text from Tasks search results, and be able to paste them elsewhere with any formatting in the task descriptions retained?

Also, why might a task be formatted \t\a\s\k? Is there something else underpinning this request?

Tried doing this to see if any tasks were being neglected by my Tasks queries due to some unforeseen formatting mistake

If on the other hand the goal of this is to make description searches more forgiving of the presence of formatting, it's not clear to me how this request solves that problem - as the would already have to be correct enough to find the tasks in order to show them in Tasks query results.
So again, I feel I must be missing something fundamental about the request...

Is this an XY Problem?
Is the request really to have the ability to be able to copy text from Tasks search results, and be able to paste them elsewhere with any formatting in the task descriptions retained?

That's my request.

Also, why might a task be formatted \t\a\s\k? Is there something else underpinning this request?

This was just for demonstration purposes, to show how the results pasted from a Tasks query would differ from the actual content of those tasks. I picked backslashes since they would normally be invisible, making this easy to demonstrate with text alone.

Is this an XY Problem?
Is the request really to have the ability to be able to copy text from Tasks search results, and be able to paste them elsewhere with any formatting in the task descriptions retained?

That's my request.

OK, and why then are you copying the search results, please? In to what software? For what reason?

Is this an XY Problem?

Is the request really to have the ability to be able to copy text from Tasks search results, and be able to paste them elsewhere with any formatting in the task descriptions retained?

That's my request.

OK, and why then are you copying the search results, please? In to what software? For what reason?

I was copying them into VScode to compare which tasks appeared when querying my whole vault vs. searching for all checkboxes via grep. This was to see if my to-do list - a Tasks query - was neglecting anything I intended to be a task. I would see which lines appeared in the grep results but not in the Tasks query, and fix whatever caused them to be excluded from the query (e.g., too many indents). However, the grep versions had all the formatting characters (brackets for links, equal signs for highlights, etc.) while the Tasks query versions didn't, leading to a lot of lines that appeared to be excluded from the query but actually weren't.
While writing this, I realized I can just copy-paste from Tasks queries into Outlook then back into Obsidian to preserve the markdown formatting characters, fixing my problem without adding a new feature. I guess it wouldn't hurt to have this feature, but it's no longer something I need.

Thanks, I understand a bit better now.
I don’t think this passes the “I believe my requested feature will be generally applicable to other users, not just me: it is not uniquely tied to my personal workflow.” test.


database

hello, where is the imgen database?

It's rethinkdb

yes, but I need the imgen db struct, as config says

You'll need to create two tables in rethinkdb called "keys" and "applications"

solved, thanks


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v4.4.292",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=156ce5bb6cc43a80a743810199defb1dc3f55b7f"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "156ce5bb6cc43a80a743810199defb1dc3f55b7f",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "isofs: Fix out of bound access for corrupted isofs image\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.4.292 by commit 156ce5bb6cc43a80a743810199defb1dc3f55b7f. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001927


[10.x] Test Improvements

Add tests to verify using auth()->logoutOtherDevices() will rehash the password.
Made a mistake targeting 11.x branch yesterday.

Thanks!


[database] Clean up labeling structure in database

At the moment the label modifications are a bit scattered within properties:
labelRotate, labelScale, labelX, labelY
Would be cleaner to make as a dictionary within properties, such as:
"labelAdjust": {
"rotate":75,
"xoffset":5,
"yoffset":-10,
"scale":1.5},
At the same time, it is probably more flexible to be able to override the default label itself, currently "entity2name", so can add (eg): "text": "NH"

Moving this to post-phase-I, but will experiment with better ways to represent this in the database.

Actually, I looked into it, and it saves no space and just makes things less compact and no more readable. Labeling wontfix


Troubling ASSERT for file size

''''XMLTest("Read dream.xml", true, uint32_t(size) >= uint32_t(bytesRead));''''
Why the >=? May be a line conversion issue; need to make sure it works or nothing more sinister.

Here's a comment https://github.com/leethomason/tinyxml2/commit/e4dc7218a5d0a34e2347269ab4426e4be30f561a#commitcomment-23118510 which contains extra details for this issue.


Refactor Sholl analysis code, fix #663

Neuron attributes soma center and soma radius were being computed for each neurite. Now they are computed only once.

Codecov Report

Merging #905 (879312c) into master (401fa5c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #905   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           37        37
  Lines         2121      2116    -5
=========================================
- Hits          2121      2116    -5

@GianlucaFicarelli the PR has been reviewed by Alexis. I will need your approval to merge.

can't you give me and adrien some more access so we can approve witout merge?

Thank you!

@arnaudon > can't you give me and adrien some more access so we can approve witout merge?
Yes, that isn't right.

Ah hold on! @mariarv  is just telling me that we need step_size, not bins as argument, otherwise we loose the information of the distance of each sholl sphere, I didn't realise this before, sorry... We can still provide a list of bins, but it is easier to have step_size. I'll make another PR on that, and check the tests.


Tex: Ignore files generated by pdfcomment package

The pdfcomment package generates *.upa and *.upb files when compiling LaTeX files. These should be ignored as well.

Thanks!


npm install error / no permissions installing grunt-zaproxy

I'm having problems installing the Shop under Debian 8.
Runnning npm install throws the following error message in a loop:
gyp WARN EACCES user "root" does not have permission to access the dev dir "/root/juice-shop/node_modules/grunt-zaproxy/node_modules/node_xslt/.node-gyp/4.4.7"
gyp WARN EACCES attempting to reinstall using temporary dev dir "/root/juice-shop/node_modules/grunt-zaproxy/node_modules/node_xslt/.node-gyp"
Any ideas?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/35835549-npm-install-error-no-permissions-installing-grunt-zaproxy?utm_campaign=plugin&utm_content=tracker%2F6283055&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F6283055&utm_medium=issues&utm_source=github).

Ups, as normale user it works without problems.


Correct typo

Sorry - I forgot to merge the pull request. The documentation was updated immediately after my comment, which is why I'm closingit now. See Improve and Retire.


Error "No suitable driver found for" even after adding JDBC driver

But I've already added here:

My Protege: 5.6.3, Ontop plugin 5.2.0, JDK 11.

Have you input the correct parameters in the "Connection Parameters" tab and then checked they are complete before starting the reasoner? The message seems to indicate all 3 fields are empty. For example (NOTE: modify the connection URL, username and password as needed):

I just ran a test with the same JDK and MySQL jdbc driver version in Linux, and for Ontop v. 5.2.0 the bootstrapper command in Protege worked correctly.

No wonder. The doc has no description for this step. Thank you very much!@apano-on


Question: Do you regularly merge kafka-connect-hdfs updates to your fork?

I see there is lots of development that happens with kafka-connect-hdfs.  I have been building a solution with your S3 connector as we are on S3 and not HDFS anymore.  As I continue development before deploying to production (I am working on my own custom partitioner), I would love to have the latest updates from kafka-connect-hdfs as well as the latest updates to your own S3 connector.  What are your own reasons for not merging the latest kafka-connect-hdfs changes to your fork?

Hi @phillipamann We want to update it regularly. We have a plan to pull in new changes from kafka-connect-hdfs after every confluent minor release. Does that sound good to you ?

Sure (I think...).  Do you have an explicit plan linked somewhere?  I noticed that in your POM, you have older (non minor release) versions of CP and Kafka.  This is why I asked.

Ya till now, I have done manual merges whenever I find time or something needs to get pulled in. I will have been thinking on this for sometime. Will send out a plan.

Is there a way I can contribute?

@phillipamann it will be great if you could help in merge or adding some tests to StreamX. Both are very important. One thing I want to make sure before the merge is, that its backward compatible with older versions of Kafka/Confluent,

Hi, didn't want to open a separate issue for this but I would love the rotate.schedule.interval.ms option to be merged from the hdfs connector (implemented in 3.1.x) into streamx.

@levin81 Sure, I will look into upgrading soon.

@phillipamann I have done the upgrade and doing some testing. I can push it as a separate branch if you would like to test it out first.

@phillipamann I have done the upgrade. Can you try it out.

I am closing this issue. If you find any issues with upgrade, please file an issue. Thanks

Are you the only one that maintains this @PraveenSeluka ?


ComboBox selection breaks when Items is updated (two bugs? check comments)

The following xaml:
<ComboBox Items="{Binding MyItems}" SelectedItem="{Binding MySelection}"/>

The following code:
public IEnumerable<object> MyItems { get; }
private object _mySelection;
public object MySelection
{
	get => _mySelection;
	set
	{
		if (_mySelection != value)
		{
			_mySelection = value;
			UpdateMyItems(); // MyItems gets set
			OnPropertyChanged(nameof(MySelection)); // Fire MySelection first with INotifyPropertyChanged
			OnCollectionChanged(nameof(MyItems)); // Fire MyItems second with INotifyCollectionChanged
		}
	}
}

You get the following ComboBox:

If you swap the order, it works as intended.
Due to the order my code runs in, I cannot simply swap the order without breaking my programs, so I have been forced to make hacky workarounds in them. It should work both ways since SelectedItem is still the correct value. Even if SelectedItem does not change, but Items does change, it still breaks until a propertychanged event is fired even though the SelectedItem is in the new collection. A fix for this would greatly reduce the amount of redundant extra code being run on my side.

Just to be clear, I'm using INotifyCollectionChanged, but I think if you use INotifyPropertyChanged to change the MyItems object for another object, it still will not adapt to the SelectedItem

We just noticed something similar, not sure if that's related tho https://github.com/AvaloniaCommunity/Avalonia.FuncUI/issues/126

I know this isn't helpful but this is probably the most annoying bug in Avalonia and it's annoyed me for years now. I'm begging you to fix this before 0.10
Right now I'm making a model that has a ComboBox of string objects. If I update the items of the ComboBox, then the selection is hidden no matter what order I fire events and no matter if the old index is available in range of the new items. I have to manually click the empty ComboBox and select my item in the UI because it's not working in code-behind at all (I have no idea why, this is the first time). It's driving me crazy that something so simple does not work. I really don't know what to do about it other than come here and complain.
<ComboBox Items="{Binding SelectableItems}" SelectedIndex="{Binding Index}" />

private int _index = 0; // Default to first item works
public int Index
{
  get => _index;
  private set
  {
    if (value == -1)
    {
      _index = 0; // No -1 please I beg you, why would I ever want -1
      OnPropertyChanged(nameof(Index));
    }
    else if (value != _index)
    {
      _index = value;
      OnPropertyChanged(nameof(Index));
    }
  }
}
private IEnumerable<string> _selectableItems = new[] { "Default" };
public IEnumerable<string> SelectableItems
{
  get => _selectableItems;
  private set
  {
    _selectableItems = value;
    OnPropertyChanged(nameof(SelectableItems));
  }
}

private void UpdateItems(object[] items)
{
  // Setting selectable items sets the selected index to -1 for no reason
  if (object.Length == 0)
  {
    SelectableItems = new[] { "Default" };
  }
  else
  {
    SelectableItems = items.Select(o => o.ToString());
  }
  Index = 0; // No selection even though I'm telling it to select 0 here and in the setter
  /* Same nonsense if you fire in reverse order
  Index = 0;
  SelectableItems = items;
  */
}

Honestly what can I do?

The (different) bug in the above comment does not occur if you let the ComboBox successfully set your index to -1 and you change the index from -1 afterwards to what you want. Really, this is unnecessary (and will not work if you are using unsigned types to retrieve your value like I am in my real code), but I have my workaround for now (which is to have a conditional in my getter to return -1 instead of my unsigned value when this bug would occur).

I think we might be able to get this to work.
The ItemsControl could use SelectedIndex = IndexOf(SelectedItem) when Items changes. That way one can add items and the selection isn't changing if the currently selected item is present in the Items collection.

Something to that effect would definitely fix both of these issues, as long as it works that way for both CollectionChanged and PropertyChanged

Something with Items is really wrong. This may be related to what's causing #4461

@Kermalis taking a look at this now. Got a few questions:

Which version of Avalonia?
What does OnCollectionChanged(nameof(MyItems));  do? Is MyItems a custom collection class that implements INotifyCollectionChanged and OnCollectionChanged is raising the CollectionChanged event on that? If so, with what Action?
https://github.com/AvaloniaUI/Avalonia/issues/4048#issuecomment-661513205 is a different problem, correct? It would be better to open a separate issue for that

I really don't know what to do about it other than come here and complain.

Opening an issue here is definitely the correct thing to do! You're not complaining ;) We can't fix issues if we don't know about them
One this that would really help me would be to create a repository which demonstrates the problem with the last code possible. I'll try to work out the exact problem from the information you've provided here in the meantime.

Maybe @Gillibald has understood the problem better than me. Is the issue just that:

You assign Items and SelectedItem
You change Items to a new collection which also contains SelectedItem
SelectedItem isn't preserved?

Maybe @Gillibald has understood the problem better than me. Is the issue just that:

You assign Items and SelectedItem
You change Items to a new collection which also contains SelectedItem
SelectedItem isn't preserved?

I think so :)

Y that is how I understood it

Yes, that's the issue. SelectedIndex is set to -1 when the collection changes. Also my other comment you linked to is indeed another issue, I'll create it now.


[FIX] Fixing some bugs

[Bug Fixes]

1: Compilation error because of add_executable and qt_add_executable when compiling with QT6.
2: 'sysconf was not declared in this scope'.
3: Hex view with problem when running with a white theme variant for QT6.
4: Wrong data predication inside the Header segment of the ELF file format.

[Bug Details]

1: When compiling with QT toolkit version 6, both executable commands are activated by a wrong evaluation.

2: Problem find inside of the class 'Data' at proclib.hpp.

3: []

After the fix:

4: The ['Type','Os ABI'] has incorrect.

After the fix:

thanks for the pull requests, i will evaluate and bring a feedback, the new version of maProc, will have a dark theme, improving the visual and fixing the hex ; )

thanks for the pull requests, i will evaluate and bring a feedback, the new version of maProc, will have a dark theme, improving the visual and fixing the hex ; )

Thanks🤝! I should like to improve the quality of code of no only this project, but by for a variety of softwares from the community! I will keep my work on! 😉


Missing video in Programming with Text section(1.4)

"1.4: Getting Text from User: Loading a Text File - Programming with Text" video is missing in the site

I will be working on it


Fix example tabs on mobile viewport

This PR fixes #145

You can preview this change here:
Built with commit 1f804820dab1d882478943ad19fb5e9e0b6c5ab2
https://deploy-preview-410--govuk-design-system-preview.netlify.com

@dashouse I'll wait for a dev to have an eye on it too :)


How to add example for non-struct types?

With the example tag I can create examples for structs:
type A struct {
   B string `example:"TEST"`
}

But how to do examples when the returned value is a primitive like a string? For example:
// @Success 200 {string} ExampleOfResult

There is an example here: https://github.com/swaggo/swag/blob/master/example/basic/api/api.go
// @Success 200 {string} string	"ok"

There is an example here: https://github.com/swaggo/swag/blob/master/example/basic/api/api.go
// @Success 200 {string} string	"ok"


openldap::server::dbindex doesn't work properly

It seems the type doesn't work properly: while trying to add multiple indices on a running openldap, puppet crashes:
Error message: Execution of '/usr/bin/ldapmodify -Y EXTERNAL -H ldapi:/// -f /tmp/openldap_dbindex20151110-28704-5ufp39' returned 20: SASL/EXTERNAL authentication started
SASL username: gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth
SASL SSF: 0
ldap_modify: Type or value exists (20)
        additional info: modify/add: olcDbIndex: value #0 already exists
modifying entry "olcDatabase={1}mdb,cn=config"
Error: /Stage[main]/Foo::Ldap/Openldap::Server::Dbindex[uidNumber]/Openldap_dbindex[uidNumber]/ensure: change from absent to present failed: LDIF content:
dn: olcDatabase={1}mdb,cn=config
add: olcDbIndex
olcDbIndex: uidNumber eq

Error message: Execution of '/usr/bin/ldapmodify -Y EXTERNAL -H ldapi:/// -f /tmp/openldap_dbindex20151110-28704-5ufp39' returned 20: SASL/EXTERNAL authentication started
SASL username: gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth
SASL SSF: 0
ldap_modify: Type or value exists (20)
        additional info: modify/add: olcDbIndex: value #0 already exists
modifying entry "olcDatabase={1}mdb,cn=config"
Error: LDIF content:
dn: olcDatabase={1}mdb,cn=config
add: olcDbIndex
olcDbIndex: cn pres,sub,eq

Error message: Execution of '/usr/bin/ldapmodify -Y EXTERNAL -H ldapi:/// -f /tmp/openldap_dbindex20151110-28704-157phwt' returned 20: SASL/EXTERNAL authentication started
SASL username: gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth
SASL SSF: 0
ldap_modify: Type or value exists (20)
        additional info: modify/add: olcDbIndex: value #0 already exists
modifying entry "olcDatabase={1}mdb,cn=config"
Error: /Stage[main]/Foo::Ldap/Openldap::Server::Dbindex[cn]/Openldap_dbindex[cn]/ensure: change from absent to present failed: LDIF content:
dn: olcDatabase={1}mdb,cn=config
add: olcDbIndex
olcDbIndex: cn pres,sub,eq

Error message: Execution of '/usr/bin/ldapmodify -Y EXTERNAL -H ldapi:/// -f /tmp/openldap_dbindex20151110-28704-157phwt' returned 20: SASL/EXTERNAL authentication started
SASL username: gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth
SASL SSF: 0
ldap_modify: Type or value exists (20)
        additional info: modify/add: olcDbIndex: value #0 already exists
modifying entry "olcDatabase={1}mdb,cn=config"
Error: LDIF content:
dn: olcDatabase={1}mdb,cn=config
add: olcDbIndex
olcDbIndex: uid pres,sub,eq

Error message: Execution of '/usr/bin/ldapmodify -Y EXTERNAL -H ldapi:/// -f /tmp/openldap_dbindex20151110-28704-1yo0yvs' returned 20: SASL/EXTERNAL authentication started
SASL username: gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth
SASL SSF: 0
ldap_modify: Type or value exists (20)
        additional info: modify/add: olcDbIndex: value #0 already exists
modifying entry "olcDatabase={1}mdb,cn=config"
Error: /Stage[main]/Foo::Ldap/Openldap::Server::Dbindex[uid]/Openldap_dbindex[uid]/ensure: change from absent to present failed: LDIF content:
dn: olcDatabase={1}mdb,cn=config
add: olcDbIndex
olcDbIndex: uid pres,sub,eq

Error message: Execution of '/usr/bin/ldapmodify -Y EXTERNAL -H ldapi:/// -f /tmp/openldap_dbindex20151110-28704-1yo0yvs' returned 20: SASL/EXTERNAL authentication started
SASL username: gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth
SASL SSF: 0
ldap_modify: Type or value exists (20)
        additional info: modify/add: olcDbIndex: value #0 already exists
modifying entry "olcDatabase={1}mdb,cn=config"

It seems the first index was added (this is a fourth run after many tests), but the following weren't.
After poking around in the doc and examples we can find, it seems the next indices creation ldif should embed the following directive:
changetype: modify

This will prevent openldap to believe it has to create another index thing, and just update the existing one in order to add the new index itself.
The generated ldif should hence be something like:
dn: olcDatabase={1}hdb,cn=config
changetype: modify
add: olcDbIndex
olcDbIndex: cn pres,sub,eq

Would be marvelous to get this working :smile_cat:

The acceptance test shows the issue: the provider doesn't detect properly the existing index.

Seems the self.instances is correct:
[
#<Puppet::Type::Openldap_dbindex::ProviderOlc:0x00000003583ad8 @property_hash={
:name=>"objectClass on dc=foo,dc=example,dc=com",
:ensure=>:present,
:attribute=>"objectClass",
:suffix=>"dc=foo,dc=example,dc=com",
:indices=>"eq"
}>,
#<Puppet::Type::Openldap_dbindex::ProviderOlc:0
x00000003583588 @property_hash={
:name=>"cn on dc=foo,dc=example,dc=com",
:ensure=>:present,
:attribute=>"cn",
:suffix=>"dc=foo,dc=example,dc=com",
:indices=>"pres,sub,eq"
}>,
#<Puppet::Type::Openldap_dbindex::ProviderOlc:0x000000035831f0 @property_hash={
:name=>"uid on dc=foo,dc=example,dc=com",
:ensure=>:present,
:attribute=>"uid",
:suffix=>"dc=foo,dc=example,dc=com",
:indices=>"pres,sub,eq"
}>
]

OK, seems I have found the issue:
it seems the provider wants a specific string, like "foo on bar".
But when we create the index resource, we're more likely to put just "foo" or any other string.
Main issue is here — $title shouldn't be used in there. We should create a string like the following:
$_title = "${attribute} on ${suffix}"

But even this won't work properly in the case we have multiple attribute in the form foo,bar,baz, as the type itself split those attribute in separated instances.
@mcanevet would be good to discuss this matter when you have some time to spare :).

@cjeanneret there is something weird with the composite namevar, it looks like it does not recognize the existence of the resource and thus tries to create it again.

So is this fixed now?

@cjeanneret should be fixed, feel free to reopen if it is not the case.

I am having this issue still
o matching Packages to list
Error: LDIF content:
dn: olcDatabase=hdb,cn=config
changetype: add
objectClass: olcDatabaseConfig
objectClass: olcHdbConfig
olcDatabase: hdb
olcDbDirectory: /var/lib/ldap
olcSuffix: dc=pexadir,dc=pexa,dc=com
olcDbIndex: objectClass eq
olcAccess: to * by dn.exact=gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth manage by * break
olcAccess: to attrs=userPassword
by self write
by anonymous auth
by dn="cn=admin,dc=pexadir,dc=pexa,dc=com" write
by * none
olcAccess: to dn.base="" by * read
olcAccess: to *
by self write
by dn="cn=admin,dc=pexadir,dc=pexa,dc=com" write
by * read
Error message: Execution of '/bin/ldapmodify -Y EXTERNAL -H ldapi:/// -f /tmp/openldap_database20151124-31049-eutbk' returned 80: SASL/EXTERNAL authentication started
SASL username: gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth
SASL SSF: 0
ldap_add: Other (e.g., implementation specific) error (80)
additional info:  namingContext "dc=pexadir,dc=pexa,dc=com" already served by a preceding hdb database
adding new entry "olcDatabase=hdb,cn=config"
Error: /Stage[main]/Main/Node[ath10]/Openldap::Server::Database[dc=pexadir,dc=pexa,dc=com]/Openldap_database[dc=pexadir,dc=pexa,dc=com]/ensure: change from absent to present failed: LDIF content:
dn: olcDatabase=hdb,cn=config
changetype: add
objectClass: olcDatabaseConfig
objectClass: olcHdbConfig
olcDatabase: hdb
olcDbDirectory: /var/lib/ldap
olcSuffix: dc=pexadir,dc=pexa,dc=com
olcDbIndex: objectClass eq
olcAccess: to * by dn.exact=gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth manage by * break
olcAccess: to attrs=userPassword
by self write
by anonymous auth
by dn="cn=admin,dc=pexadir,dc=pexa,dc=com" write
by * none
olcAccess: to dn.base="" by * read
olcAccess: to *
by self write
by dn="cn=admin,dc=pexadir,dc=pexa,dc=com" write
by * read
Error message: Execution of '/bin/ldapmodify -Y EXTERNAL -H ldapi:/// -f /tmp/openldap_database20151124-31049-eutbk' returned 80: SASL/EXTERNAL authentication started
SASL username: gidNumber=0+uidNumber=0,cn=peercred,cn=external,cn=auth
SASL SSF: 0
ldap_add: Other (e.g., implementation specific) error (80)
additional info:  namingContext "dc=pexadir,dc=pexa,dc=com" already served by a preceding hdb database
adding new entry "olcDatabase=hdb,cn=config"

@coffeecoco could you please provide the puppet code that provided this error?


file watcher is removed by the agent once the sidecar resource containing TLS certificate configuration is removed

Bug Description
For one of our services, we enabled TLS termination on the sidecar proxy  with the following sidecar resource.
...
ingress:
  - defaultEndpoint: <IP_ADDRESS>:8080
    port:
      name: https-8080
      number: 8080
      protocol: HTTPS
    tls:
      mode: SIMPLE
      privateKey: /etc/certs/key.pem
      serverCertificate: /etc/certs/cert-chain.pem
...

Just a little background, all our certificates (mTLS) are volume mounted on the proxy and rotated every few hours. This is our usual setup.
The configuration worked well and everything worked as expected.
But for some unrelated reason, we decided to roll back the TLS enablement by removing the sidecar and the PeerAuthN resource.
After a few minutes, we realized that removing the sidecar resource somehow caused the agent to remove the watcher on the certificate file /etc/certs/cert-chain.pem. Even though the certificates were being rotated regularly, but since the watcher was removed, the new certificates were not being pushed to the proxy.
This is an issue because the same certificates are used for mTLS for calls made to or made from services within the mesh.
Steps to reproduce

Create a service with TLS in the sidecar enabled using the steps described here
Test and make sure the sidecar is terminating TLS.
Delete the Sidecar and PeerAuthN resources applied in step 1.
Tail the proxy logs and after a few minutes you'll see the agent has stopped watching on the default (/etc/certs/cert-chain.pem) certificate.

Proxy logs that we observed while debugging
Logs when TLS was enabled
2023-03-15T20:46:03.299973Z	info	ads	SDS: PUSH for node:blackhole-gw-6dbdbffc68-shxpt.services-blackholea430-use2-dev resources:1 size:1.1kB resource:default
2023-03-15T20:47:04.903149Z	info	cache	event for file certificate /etc/certs/root-cert.pem : REMOVE, pushing to proxy
2023-03-15T20:47:04.903203Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:3 Version:
2023-03-15T20:47:04.903379Z	info	cache	event for file certificate /etc/certs/cert-chain.pem : REMOVE, pushing to proxy
2023-03-15T20:47:04.903402Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:3 Version:
2023-03-15T20:47:04.903418Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:3 Version:
2023-03-15T20:47:04.903657Z	info	cache	adding watcher for file certificate /etc/certs/root-cert.pem
2023-03-15T20:47:04.903690Z	info	cache	read certificate from file	resource=ROOTCA
2023-03-15T20:47:04.903782Z	info	ads	SDS: PUSH for node:blackhole-gw-6dbdbffc68-shxpt.services-blackholea430-use2-dev resources:1 size:2.0kB resource:ROOTCA
2023-03-15T20:47:05.004630Z	info	cache	read certificate from file	resource=file-cert:/etc/certs/cert-chain.pem~/etc/certs/key.pem
2023-03-15T20:47:05.004706Z	info	ads	SDS: PUSH for node:blackhole-gw-6dbdbffc68-shxpt.services-blackholea430-use2-dev resources:1 size:1.1kB resource:file-cert:/etc/certs/cert-chain.pem~/etc/certs/key.pem
2023-03-15T20:47:05.004709Z	info	cache	adding watcher for file certificate /etc/certs/cert-chain.pem
2023-03-15T20:47:05.004734Z	info	cache	read certificate from file	resource=default

Logs when Sidecar and PeerAuthN resource was removed
2023-03-15T20:54:18.100311Z	info	ads	SDS: PUSH for node:blackhole-gw-6dbdbffc68-shxpt.services-blackholea430-use2-dev resources:1 size:1.1kB resource:default
2023-03-15T20:55:19.998374Z	info	cache	event for file certificate /etc/certs/root-cert.pem : REMOVE, pushing to proxy
2023-03-15T20:55:19.998416Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:2 Version:
2023-03-15T20:55:19.998462Z	info	cache	event for file certificate /etc/certs/cert-chain.pem : REMOVE, pushing to proxy
2023-03-15T20:55:19.998485Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:2 Version:
2023-03-15T20:55:19.998496Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:2 Version:
2023-03-15T20:55:19.998614Z	info	cache	adding watcher for file certificate /etc/certs/root-cert.pem
2023-03-15T20:55:19.998645Z	info	cache	read certificate from file	resource=ROOTCA
2023-03-15T20:55:19.998734Z	info	ads	SDS: PUSH for node:blackhole-gw-6dbdbffc68-shxpt.services-blackholea430-use2-dev resources:1 size:2.0kB resource:ROOTCA
2023-03-15T20:55:20.099493Z	info	cache	adding watcher for file certificate /etc/certs/cert-chain.pem
2023-03-15T20:55:20.099532Z	info	cache	read certificate from file	resource=default

Logs 15-30 minutes after the TLS was disabled.
2023-03-15T20:56:21.602143Z	info	ads	SDS: PUSH for node:blackhole-gw-6dbdbffc68-shxpt.services-blackholea430-use2-dev resources:1 size:1.1kB resource:default
2023-03-15T20:57:12.953133Z	info	xdsproxy	connected to upstream XDS server: istiod.istio-system.svc:15012
2023-03-15T20:57:12.961376Z	info	envoy upstream	cds: add 52 cluster(s), remove 5 cluster(s)
2023-03-15T20:57:12.965043Z	info	envoy upstream	cds: added/updated 0 cluster(s), skipped 52 unmodified cluster(s)
2023-03-15T20:57:23.599681Z	info	cache	event for file certificate /etc/certs/root-cert.pem : REMOVE, pushing to proxy
2023-03-15T20:57:23.599719Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:2 Version:
2023-03-15T20:57:23.599796Z	info	cache	event for file certificate /etc/certs/cert-chain.pem : REMOVE, pushing to proxy
2023-03-15T20:57:23.599827Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:2 Version:
2023-03-15T20:57:23.599837Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:2 Version:
2023-03-15T20:57:23.599931Z	info	cache	adding watcher for file certificate /etc/certs/root-cert.pem
2023-03-15T20:57:23.599968Z	info	cache	read certificate from file	resource=ROOTCA
2023-03-15T20:57:23.600043Z	info	ads	SDS: PUSH for node:blackhole-gw-6dbdbffc68-shxpt.services-blackholea430-use2-dev resources:1 size:2.0kB resource:ROOTCA
2023-03-15T20:57:23.700816Z	info	cache	read certificate from file	resource=default
2023-03-15T20:57:23.700905Z	info	ads	SDS: PUSH for node:blackhole-gw-6dbdbffc68-shxpt.services-blackholea430-use2-dev resources:1 size:1.1kB resource:default
2023-03-15T20:58:25.400907Z	info	cache	event for file certificate /etc/certs/root-cert.pem : REMOVE, pushing to proxy
2023-03-15T20:58:25.401005Z	info	ads	XDS: Incremental Pushing:0 ConnectedEndpoints:2 Version:
2023-03-15T20:58:25.401207Z	info	cache	adding watcher for file certificate /etc/certs/root-cert.pem
2023-03-15T20:58:25.401226Z	info	cache	read certificate from file	resource=ROOTCA

In the last set of logs, you would notice that there is no adding watcher for file certificate /etc/certs/cert-chain.pem.
Right now the only way to resolve this issue is by doing a rolling restart of the deployment.
Version
$ istioctl version
client version: unknown
control plane version: 1.13.5
data plane version: 1.13.5 (393 proxies)

$ kubectl version --short
Client Version: v1.21.2
Server Version: v1.22.16

Additional Information
No response

Why do you expect the certificate to be used if the Sidecar is removed?

Why do you expect the certificate to be used if the Sidecar is removed?

@howardjohn sorry I missed mentioning that we use the same certificate for mTLS when calls are made to or made from services within the mesh. I'll update the description

I donot think we have ever stopped the watcher even when sidecar is deleted

I think this is because it is using fsnotify directly to watch. But k8s volume mount is path link, so when an update happens, the old watcher does not work.
There is another issue here maybe leaking inode.

Should replace with istio filewatcher

@ramaraochavali Is this fixed by you?

I can't remember exactly

Found the fix https://github.com/istio/istio/pull/44890


Unnecessary scrollbar in navbar

There is an unnecessary scrollbar in the navbar which ruins the experience of the site, allow me to fix it

assigned


Namespace reset on narrative elements

Doing a query like http://spark.furore.com/fhir/Encounter?patient=spark2653 to sparks returns elements in the narrative with the namespace removed, like xmlns="". This isn't correct as all elements need to be in the xhtml namespace.
<Bundle xmlns="http://hl7.org/fhir">
    <id value="urn:uuid:359250d0-a37b-4736-b123-a6181bddef9a" />
    <type value="searchset" />
    <total value="1" />
    <link>
        <relation value="self" />
        <url value="http://spark.furore.com/fhir/Encounter?patient=spark2653" />
    </link>
    <link>
        <relation value="first" />
        <url value="http://spark.furore.com/fhir/_snapshot?id=dd294dec-8750-4dc5-965c-69d28ea03b20&start=0" />
    </link>
    <link>
        <relation value="last" />
        <url value="http://spark.furore.com/fhir/_snapshot?id=dd294dec-8750-4dc5-965c-69d28ea03b20&start=0" />
    </link>
    <entry>
        <fullUrl value="http://spark.furore.com/fhir/Encounter/spark181/_history/spark1920" />
        <resource>
            <Encounter>
                <id value="spark181" />
                <meta>
                    <versionId value="spark1920" />
                    <lastUpdated value="2016-04-21T05:01:45.585+00:00" />
                </meta>
                <text>
                    <status value="generated" />

                            Generated Narrative with Details

                            id: nehta-f001

                            identifier: v1451 (OFFICIAL)

                            status: finished

                            class: outpatient

                            type: Patient-initiated encounter
                            (Details : {SNOMED CT code '270427003' = 'Patient-initiated encounter (procedure)', given as 'Patient-initiated encounter'})

                            priority: Non-urgent cardiological admission
                            (Details : {SNOMED CT code '310361003' = 'Non-urgent cardiological admission (procedure)', given as 'Non-urgent cardiological admission'})

                            patient:
                            P. van de Heuvel

Participants

                                -

                                    Individual

                                *

                                    P. Voigt

                            length: 140 min
                             (Details: http://unitsofmeasure.org code min = 'min')

                            reason: Heart valve replacement
                            (Details : {SNOMED CT code '34068001' = 'Heart valve replacement (procedure)', given as 'Heart valve replacement'})

Hospitalizations

                                -

                                    PreAdmissionIdentifier

                                    AdmitSource

                                    DischargeDisposition

                                *
                                93042 (OFFICIAL)
                                Referral by physician
                                    (Details : {SNOMED CT code '305956004' = 'Referral by physician (procedure)', given as 'Referral by physician'})

                                Discharge to home
                                    (Details : {SNOMED CT code '306689006' = 'Discharge to home (procedure)', given as 'Discharge to home'})

                            serviceProvider:
                            Burgers University Medical Center

                </text>
                <identifier>
                    <use value="official" />
                    <system value="http://www.amc.nl/zorgportal/identifiers/visits" />
                    <value value="v1451" />
                </identifier>
                <status value="finished" />
                <class value="outpatient" />
                <type>
                    <coding>
                        <system value="http://snomed.info/sct" />

                        <display value="Patient-initiated encounter" />
                    </coding>
                </type>
                <priority>
                    <coding>
                        <system value="http://snomed.info/sct" />

                        <display value="Non-urgent cardiological admission" />
                    </coding>
                </priority>
                <patient>
                    <reference value="http://spark.furore.com/fhir/Patient/spark2653" />
                    <display value="P. van de Heuvel" />
                </patient>
                <participant>
                    <individual>
                        <reference value="http://spark.furore.com/fhir/Practitioner/nehta-f002" />
                        <display value="P. Voigt" />
                    </individual>
                </participant>
                <length>
                    <value value="140.0" />
                    <unit value="min" />
                    <system value="http://unitsofmeasure.org/" />

                </length>
                <reason>
                    <coding>
                        <system value="http://snomed.info/sct" />

                        <display value="Heart valve replacement" />
                    </coding>
                </reason>
                <hospitalization>
                    <preAdmissionIdentifier>
                        <use value="official" />
                        <system value="http://www.amc.nl/zorgportal/identifiers/pre-admissions" />
                        <value value="93042" />
                    </preAdmissionIdentifier>
                    <admitSource>
                        <fhir_comments value="        <preAdmissionTest>
            <coding>
                <system value="http://snomed.info/sct"/>
                <code value="164847006"/>
                <display value="Standard ECG"/>
            </coding>
            <coding>
                <system value="http://snomed.info/sct"/>
                <code value="396550006"/>
                <display value="Blood test"/>
            </coding>
        </preAdmissionTest>   " />
                        <coding>
                            <system value="http://snomed.info/sct" />

                            <display value="Referral by physician" />
                        </coding>
                    </admitSource>
                    <dischargeDisposition>
                        <coding>
                            <system value="http://snomed.info/sct" />

                            <display value="Discharge to home" />
                        </coding>
                    </dischargeDisposition>
                </hospitalization>
                <serviceProvider>
                    <reference value="http://spark.furore.com/fhir/Organization/nehta-f001" />
                    <display value="Burgers University Medical Center" />
                </serviceProvider>
            </Encounter>
        </resource>
    </entry>
</Bundle>

Did you upload the Encounter yourself and see that Spark removed the namespaces, or is this just an example of a resource you found where the namespaces are empty?
IMHO the namespace should just be on the  element, so the top level of the  contents.
I've tried uploading a new Encounter where I filled in the namespaces for some of the  and other tags within the . Spark didn't remove them upon creating the Encounter and Spark shows them when I retrieve the Encounter again. So I don't see what you think Spark is doing incorrectly?

When I upload this to spark:
{
  "resourceType": "Encounter",
  "id": "nehta-f001",
  "text": {
    "status": "generated",
    "div": "

Generated Narrative with Details

id: nehta-f001

identifier: v1451 (OFFICIAL)

status: finished

class: outpatient

type: Patient-initiated encounter (Details : {SNOMED CT code '270427003' = 'Patient-initiated encounter (procedure)', given as 'Patient-initiated encounter'})

priority: Non-urgent cardiological admission (Details : {SNOMED CT code '310361003' = 'Non-urgent cardiological admission (procedure)', given as 'Non-urgent cardiological admission'})

patient: P. van de Heuvel

Participants

-	Individual

*	P. Voigt

length: 140 min (Details: http://unitsofmeasure.org code min = 'min')

reason: Heart valve replacement (Details : {SNOMED CT code '34068001' = 'Heart valve replacement (procedure)', given as 'Heart valve replacement'})

Hospitalizations

-	PreAdmissionIdentifier	AdmitSource	DischargeDisposition

*	93042 (OFFICIAL)	Referral by physician (Details : {SNOMED CT code '305956004' = 'Referral by physician (procedure)', given as 'Referral by physician'})	Discharge to home (Details : {SNOMED CT code '306689006' = 'Discharge to home (procedure)', given as 'Discharge to home'})

serviceProvider: Burgers University Medical Center

"
  },
  "identifier": [
    {
      "use": "official",
      "system": "http://www.amc.nl/zorgportal/identifiers/visits",
      "value": "v1451"
    }
  ],
  "status": "finished",
  "class": "outpatient",
  "type": [
    {
      "coding": [
        {
          "system": "http://snomed.info/sct",
          "code": "270427003",
          "display": "Patient-initiated encounter"
        }
      ]
    }
  ],
  "priority": {
    "coding": [
      {
        "system": "http://snomed.info/sct",
        "code": "310361003",
        "display": "Non-urgent cardiological admission"
      }
    ]
  },
  "patient": {
    "reference": "Patient/nehta-f001",
    "display": "P. van de Heuvel"
  },
  "participant": [
    {
      "individual": {
        "reference": "Practitioner/nehta-f002",
        "display": "P. Voigt"
      }
    }
  ],
  "length": {
    "value": 140,
    "unit": "min",
    "system": "http://unitsofmeasure.org",
    "code": "min"
  },
  "reason": [
    {
      "coding": [
        {
          "system": "http://snomed.info/sct",
          "code": "34068001",
          "display": "Heart valve replacement"
        }
      ]
    }
  ],
  "hospitalization": {
    "preAdmissionIdentifier": {
      "use": "official",
      "system": "http://www.amc.nl/zorgportal/identifiers/pre-admissions",
      "value": "93042"
    },
    "admitSource": {
      "fhir_comments": [
        "        <preAdmissionTest>\n            <coding>\n                <system value=\"http://snomed.info/sct\"/>\n                \n                <display value=\"Standard ECG\"/>\n            </coding>\n            <coding>\n                <system value=\"http://snomed.info/sct\"/>\n                \n                <display value=\"Blood test\"/>\n            </coding>\n        </preAdmissionTest>   "
      ],
      "coding": [
        {
          "system": "http://snomed.info/sct",
          "code": "305956004",
          "display": "Referral by physician"
        }
      ]
    },
    "dischargeDisposition": {
      "coding": [
        {
          "system": "http://snomed.info/sct",
          "code": "306689006",
          "display": "Discharge to home"
        }
      ]
    }
  },
  "serviceProvider": {
    "reference": "Organization/nehta-f001",
    "display": "Burgers University Medical Center"
  }
}

and ask for XML back, some elements in the narrative obtain xmlns="", which is effectively removing the xhtml namespace on them - so it is by actually adding the namespace tag that it is removing the namespace.

So it seems to be in the json-xml roundtripping, which is the responsibility of the parser and serializer in the [Hl7.Fhir API] (https://github.com/ewoutkramer/fhir-net-api). I will close this issue here, but have created [issue #193 on the API] (https://github.com/ewoutkramer/fhir-net-api/issues/193).

OK! Thanks :)

In this example, the div doesn't have the xhtml namespace defined in the json example, so are you expecting the server to replace it?


Add nested ordered list option

This PR fulfills the feature requested in #41

Hi
Thanks a lot for this contribution, looks like a great new option 🙏
We might need to add new unit tests; let me know if you want to do it yourself in this PR; otherwise I can also merge it and add a few myself before releasing a new version of the plugin.
Thanks!

I actually have less than 30 minutes of experience with coding in js, so I might not be the right person to write new unit tests 🤣
This was just an experiment to see if I could do it myself by looking at how you had done the rest and taking advantage of AI auto-complete in VS Code 😉
But if you can specify what tests need to be added, I'm willing to give it a go myself. But, if you think it has to be done soon™, then maybe it's better that you do it yourself 😄

Thanks! Merged and updated a bit as I just discovered you can always put 1. in the lists (instead of the real number) to generate ordered lists, which makes the code simpler
Test looks like this: https://github.com/johansatge/obsidian-automatic-table-of-contents/pull/45/files


Reloading calendar?

Hello, is there a way to re-trigger func supplementaryView(shouldDisplayOnDayView dayView: DayView) -> Bool after the calendar view is loaded?  Thanks

already fixed in master ... should be closed
calendarView.contentController.refreshPresentedMonth()

Ok Thank you!

@stefreak for now I manually copied and pasted the code in to my codebase.  Will I have to wait until the podspec is updated for it to be officially available?

For it to be officially available yes, but you can also just do this until a new version is released: https://guides.cocoapods.org/using/the-podfile.html#from-a-podspec-in-the-root-of-a-library-repo

Great thanks
On Thu, Dec 10, 2015 at 11:42 AM, Steffen Neubauer<EMAIL_ADDRESS>
wrote:

For it to be officially available yes, but you can also just do this until
a new version is released:
https://guides.cocoapods.org/using/the-podfile.html#from-a-podspec-in-the-root-of-a-library-repo
—
Reply to this email directly or view it on GitHub
https://github.com/Mozharovsky/CVCalendar/issues/175#issuecomment-163574743
.


chore: Merge dev branch into staging.

This Pull Request is intended to update the staging branch with fixes from dev branch which includes fix for super admin profile, data-privacy, region, organisation creation on sign up.

Description
This Pull Request is intended to update the staging branch with fixes from dev branch which includes fix for super admin profile, data-privacy, region, organisation creation on sign up.  These are all a requirement for every single user, regardless of super admin privileges.

Related Issue (Link to issue ticket)
This Pull Request is intended to update the staging branch with fixes from dev branch which includes fix for super admin profile, data-privacy, region, organisation creation on sign up.

Motivation and Context

How Has This Been Tested?
This has been tested with postman and pytest.

Screenshots (if appropriate - Postman, etc):
pytest

SUPER ADMIN REGISTRATION ORGANISATION CREATED

SUPER ADMIN REGISTRATION PROFILE CREATED

SUPER ADMIN REGISTRATION REGION CREATED

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@trevorjob
Kindly review.


Added go modules support

Please request README.md update if needed. Now build procedure should be simplified

Thanks


Team Page

Describe the solution you'd like
Make the Login screen as same as the mockup
Contents

Use Proper fonts
Use already existing icons on the page.
For the UI elements refer to the website www.flaticon.com.

Please mention the work you are doing before we assign u this task.
Follow the UI Strictly

I was already working on this previously so can I go forward with it ?

Please assign me this issue !!

Could you please work on the Sign Up page issue I assigned you now

@Anushka-shukla For the next 5 days assigned to you.

@bharat-1809 Could you please work on the Sign-Up page issue I assigned you now

Yeah Sure

@Anushka-shukla Update on this Page

Solving the errors..

Any screenshot of screen?

Can I work on this issue?

Can I work on this issue?

go ahead.

Can I work on this issue?

go ahead.

What specifically needs to be done?

Can I work on this issue?

go ahead.

What specifically needs to be done?

Check the mock-up and make the team page exactly as seen. We will provide u the assets when u need it. Also check the description of this issue.


Add option for ES bundling, as alternative/mode for ES index output

Take inspiration from some very clever re-naming logic in rollup that handles collisions well:
main.js:
import { hello as h1 } from "./a.js";

import { hello as h2, foo } from "./b.js";

h1();
h2();
console.log(f2);
export { foo };

a.js:
var foo = 2;
export function hello() { console.log(foo); }

b.js:
var foo = 3;
export function hello() { console.log(foo); }
export { foo }

Produces...
output.js:
var foo = 2;
function hello() { console.log(foo); }

var foo$1 = 3;
function hello$1() { console.log(foo$1); }

hello();
hello$1();
console.log(f2);

export { foo$1 as foo };

Also interesting issues to address differently from how Rollup behaves:

How to handle name conflicts when re-naming won't work? Rollup issues a warning and just drops the duplicate stuff (via tree shaking, I guess?)?
rollup example
main.js:
export * from "./a.js";
export * from "./b.js";

a.js:
var foo = 2;
export function hello() { console.log(foo); }

b.js:
var foo = 3;
export function hello() { console.log(foo * 2); }

Rollup does issue a warning that there's a collision between the two hello identifiers both being exported. Unfortuantely, the warning isn't fatal, and then Rollup just drops the entire contents of b.js (tree shaking, I assume?):
var foo = 2;
function hello() { console.log(foo); }

export { hello };

How to just stitch two peer modules together without some main entry-point module that "re-exports" them?
rollup example
main.js:
var foo = 2;
export function hello() { console.log(foo); }

a.js:
var foo = 3;
export function hello2() { console.log(foo * 2); }

Unfortunately, Rollup expects a main entry-point module, so (via tree shaking?) produces just this:
var foo = 2;
function hello() { console.log(foo); }

export { hello };

This emphasizes that Moduloze provides better for this use-case than Rollup, in that Moduloze (not relying on tree-shaking) doesn't require a single entry-point file to key off of, it just bundles a tree of peer files together.

I am interested in this feature. Is there anything I can help with to get this done?


Add shrinking of rootfs and image to optimize_image functionality

Followup to #4.
Add shrinking of rootfs and image on cleanup, when optimize_image is set.

Can be seen in action here: https://github.com/f-laurens/pynab/actions/runs/976622811.
If/when this PR is merged and released, arm-runner-action users like Pynab can doip using PiShrink altogether, and just compress the resulting image.

It's an additional 40 seconds, maybe we should make this optional?
I also believe we should call pishrink, even with a hard-coded sha, instead of duplicating the functionality.

It's an additional 40 seconds, maybe we should make this optional?

40 seconds is somewhat negligible, compared to most (for example Pynab) build times, and also to compression (xz) times for images.
By optional, do you mean adding another option (shrink_image?) in addition to optimize_image? I think it would be better to just have optimize_image defaut to no, as I originally proposed.

I also believe we should call pishrink, even with a hard-coded sha, instead of duplicating the functionality.

Well, as you wrote: " I'm all in favor of implementing selected features of PiShrink".
We don't duplicate the functionality here: we do a better use of resize2fs, and avoid duplicating the "dangerous" -p option, and the obsolete/dangerous (if not specified) -s option of PiShrink.
But if you want (for Pynab) to go on using PiShrink, then it would be certainly better to just close this PR, without merging it.
I'll keep the code alive in my forks anyway.


Firefox save doesn't work

.-""-.
Example console output:
/[] _ \
|o_LII|
/ | ==== |
|| ==== ||
||LI  o ||
||'----'||    artoo.js
/|    |\   v0.3.2 artoo-latest.min.js:2:19592
[artoo]: - jQuery already exists in this page (v2.1.1). No need to load it again. artoo-latest.min.js:2:19291
[artoo]: - artoo is now good to go! artoo-latest.min.js:2:19291
artoo.savePrettyJson({k:'v'})
undefined
using firefox 41.0.2. same behaviour with all other save method

Hello @addadi. Will test this asap to check where things went bad.

thanks a lot :) I found a workaround with the console.save snippet from here: http://bgrins.github.io/devtools-snippets/ so it's not that urgent. perhaps the code there can help you finding a solution for cross browser savings. Anyway thanks for the great library!

The thing which is strange is that I basically use the same method as the one displayed in your snippet. Do you have an error shown in the console when trying to use the lib's save methods?

nope

Does not work for me neither

I'm having the same issue on Firefox 42.0, OS X Yosemite 10.10.5.
After a quick research + testing, seems like Firefox doesn't simulate the click if the element is not attached to the DOM.
A quick & dirty solution would be to attach the element, trigger the click, and remove the element afterwards.
If you are ok with this I can provide a pull request :).
cc @Yomguithereal

@roperzh, this seems like a sensible solution. However I don't get why the snippet shown by @addadi works then since the element is not attached to the DOM either.


[Bug] Rule missing-space-after-comment complaining of too much #s

What happened?
The rule 0702 complains that a # char that is in a comment but is not the first char of the comment (i.e. it does not turn the rest of the line into a comment) is not followed by a space.

This is either a bug or at least an inconsistency: Robocop should complain of the rest of #s as well. (But I will rather see this as a bug. 😄)
Operating System
No response
Robocop version
2.0.2

Bug:

it should check for blank space after # only at the beginning of the comment
For multiple ###.. it maybe should just skip it anyway

The bug happened because you actually have two comments here - if there is more than two spaces in a line with comment, Robot Framework parses it as: COMMENT, SEPARATOR, COMMENT. We should add extra handling there and 'merge' it as single comment before checking for comment validity.


CUDA_CUDA_LIBRARY Error Cmake

Host system has NVIDIA Container Toolkit 15.2, CUDA 11.4 on Ubuntu 20.04 (if it matters)
I'm building with atk dev -ba -s chrono --optionals gpus vnc to build a fresh Chrono image (the dockerhub one is out of date for the current Chrono feature/ros branch) I'm also building for humble
I'm running into the following error at step 13

Would appreciate some guidance!

As an update, error is reproduced with CUDA 12.2 and NVIDIA CUDA toolkit 12.2

This was fixed by appending -DCMAKE_LIBRARY_PATH=/usr/local/cuda/lib64/stubs to the CMake build command. The demo_ART_cone.py needed some small fixes to accomodate a (new?) PyChrono API. I'd be happy to make it a PR/fork if needed

@bretwitt Ah sorry, I must have notifcations disabled! Thanks for the update. Odd that it worked okay before and not anymore. Looks like we can just set -DCMAKE_LIBRARY_PATH=${LIBRARY_PATH} since nvidia includes the cuda library path in the LIBRARY_PATH env variable (I wonder if there was a change in chrono which caused this to break, probably okay to do this for now tho). I will make a PR with this change, as well as updating the chrono branch to main since feature/ros has been merged in the latest release.
As for the PyChrono demo fixes, feel free to make a PR with those! I meant to update those, but didn't get to it. Thanks for debugging that!!


minor changes in text: adapting visual rendering

Hi!
Just changed the ":::", I think that this is what it was supposed to show (italics or subtitles), but I am not sure, just noticed that it looked weired.
BTW, as a side-note: great project, love it, I'm browsing your site right now, it is just great! Thank you @libellux !

Any chance someone checked it out? :)

Hello @fintzd sorry for the slow reply been busy with work. Hm the ":::" in vuepress creates collapse. Which browser do you use and could you please provide a screenshot? :)

Hey @libellux !
No worries and thank you for the reply in any case! I use Firefox, and attached the screen here! :)
Hope it helps, I'm not sure what the replacement option for that would be good.
Cheers!

Hey @libellux !
No worries and thank you for the reply in any case! I use Firefox, and attached the screen here! :)
Hope it helps, I'm not sure what the replacement option for that would be good.
Cheers!

Hello @fintzd ! I see you're only viewing the documentation from GitHub - then it might look weird :) if you visit the actual website which is fetched directly from this git you'll see what above markdown does. See attached screenshot.