FileOpenPicker PickMultipleFilesAsync Break in WinUI3 Desktop

Describe the bug
The FileOpenPicker in WinUI3 Preview4 Desktop sample solution breaks and closes the application when trying to open multiple items. Exception details below in the last section.
Steps to reproduce the bug

Clone the WinUI3 Preview4 Problems FilePicker repository.
Go to the FilePickerWinUIPreview4 folder.
Open the FilePickerWinUIPreview4 solution in Visual Studio 2019 Preview.
Build and run with Debug x64.
Click the second / bottom button "FileOpenPicker: Multiple Files". (The first button should work as expected.)
Select one or more files.
Click "Open". Crash should occur.

Expected behavior
We expect the application to display the path of the selected file(s) or folder.
We expect the FileOpenPicker to allow the user to select multiple files as it does in UWP.
Screenshots

Screenshot#1a and 1b - Current Behavior (Single File working and Crash Error Message)

Screenshot#2 - Expected Behavior (File paths of selected files)
Version Info
NuGet package version:
[Microsoft.WinUI 3.0.0-preview4.210210.4]
Targeting:
Target: Universal Windows
Target version: Windows 10, version 1809 (10.0; Build 17763)
Min version: Windows 10, version 1803 (10.0; Build 17134)
Windows app type:

UWP
Win32

Yes

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)
Yes

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context
Exception Details
System.Reflection.TargetInvocationException
HResult=0x80131604
Message=Exception has been thrown by the target of an invocation.
Source=System.Private.CoreLib
StackTrace:
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
at WinRT.SingleInterfaceOptimizedObject..ctor(Type type, IObjectReference objRef)
at Windows.Storage.Pickers.FilePickerSelectedFilesArray.<.ctor>b__8_1()
at System.Lazy1.ViaFactory(LazyThreadSafetyMode mode)    at System.Lazy1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
at System.Lazy1.CreateValue()    at System.Lazy1.get_Value()
at Windows.Storage.Pickers.FilePickerSelectedFilesArray.AsInternal(InterfaceTag`1 _)
at Windows.Storage.Pickers.FilePickerSelectedFilesArray.GetEnumerator()
at FileOpenPickerWinUIPreview4.MainWindow.<fileOpenPickerMultipleButton_Click>d__2.MoveNext() in \FileOpenPickerWinUIPreview4\FileOpenPickerWinUIPreview4\MainWindow.xaml.cs:line 60
This exception was originally thrown at this call stack:
[External Code]
Inner Exception 1:
COMException: The application called an interface that was marshalled for a different thread. (0x8001010E (RPC_E_WRONG_THREAD))

I get a similar error with FolderPicker's PickSingleFolderAsync.
Any workarounds for now?

Hi @AmSmart, for PickSingleFolderAsync, are you using IInitializeWithWindow? In desktop apps, you need to use IInitializeWithWindow to associate your HWND with the API before calling PickSingleFolderAsync, see this example: https://github.com/microsoft/ProjectReunion/issues/466#issuecomment-779628934

Yeah, I used the IInitializeWithWindow interface. The issue was that I didn't specify a file type filter. Looking through the docs, I discovered that not specifying it generates an exception. It's all resolved now. Thanks for the swift response!

I got the same issue on PickMultipleFilesAsync, which crashes WinUI/Reunion WPF desktop app. But PickSingleFolderAsync works well. Do we have workaround or fix now? Thanks in advance.

FileSavePicker also crashed even use InitializeWithWindow

PickMultipleFilesAsync is unfortunately not supported right now. You can instead use the Win32 API GetOpenFileName, we're working on posting a workaround sample for that.
@Aloento make sure when you're calling this.As<IWindowNative>(), the this object is a Window object. If you're still seeing problems, you can open a new issue, and please provide a full example of the code you're calling, what specifically is failing, etc. Thanks!

PickMultipleFilesAsync is unfortunately not supported right now. You can instead use the Win32 API GetOpenFileName, we're working on posting a workaround sample for that.
@Aloento make sure when you're calling this.As<IWindowNative>(), the this object is a Window object. If you're still seeing problems, you can open a new issue, and please provide a full example of the code you're calling, what specifically is failing, etc. Thanks!

https://github.com/microsoft/ProjectReunion/issues/909

I'd like to share the workaround of using Interop GetOpenFileName API call.
By researching several links and verifying some experiments:
https://docs.microsoft.com/en-us/windows/win32/dlgbox/open-and-save-as-dialog-boxes
https://stackoverflow.com/questions/9088227/using-getopenfilename-instead-of-openfiledialog
https://social.msdn.microsoft.com/forums/vstudio/en-US/2f4dd95e-5c7b-4f48-adfc-44956b350f38/getopenfilename-for-multiple-files
I can  workaround this issue as below:
Notes:  This works in Project Reunion 0.8 Preview. If you are using WinUI3 Preview or Project Reunion 0.5, may hit this bug:
https://github.com/microsoft/microsoft-ui-xaml/issues/4952
And need to upgrade the project to 0.8 by going through:
https://docs.microsoft.com/en-us/windows/apps/project-reunion/update-existing-projects-to-the-latest-release
The helper class is as attached:
Libwrap.txt
The calling sample code snippet:
`
string[] files = LibWrap.ShowOpenFileDialog("Select Files","c:\users\freistli\documents", "All files\0 .\0", true, true);
        if (files != null)
        {
            FPS.Text = "";
            foreach (var file in files)
            {
                Debug.WriteLine("Selected file with full path: {0}", file);
                FPS.Text += file + "\r\n";
            }
        }

`
Hope this helps.

Just confirming this is not an issue on cppwinrt after
picker.as<IInitializeWithWindow>()->Initialize(hwnd);

The wrong thread exception in the repro app looks to be fixed with the CsWinRT update in .NET SDK 5.0.302.  Specifically, the CsWinRT fix for calling non agile objects (https://github.com/microsoft/CsWinRT/issues/844) resolves it.

Awesome @manodasanW, so can you confirm that PickMultipleFilesAsync is now functional for C# apps if you use .NET SDK 5.0.302 and the IInitializeWithWindow?

I just confirmed that PickMultipleFilesAsync is now functional thanks to @manodasanW's fix available in the latest .NET SDK 5.0.302!
Update VS using the Visual Studio Installer to get the latest .NET, and then the following code should work! I tested this in a WinUI 3 Desktop app using Microsoft.ProjectReunion 0.8. You can replace the following code in a File->New project to see the picker working!
private async void myButton_Click(object sender, RoutedEventArgs e)
{
    myButton.Content = "Picking files...";

    var picker = new Windows.Storage.Pickers.FileOpenPicker
    {
        // Make sure you specify FileTypeFilter, it's required
        FileTypeFilter =
        {
            "*"
        }
    };

    // Make sure to get the HWND from a Window object... if calling from a helper method,
    // you'll have to pass a Window reference to GetWindowHandle
    var hwnd = WinRT.Interop.WindowNative.GetWindowHandle(this);
    WinRT.Interop.InitializeWithWindow.Initialize(picker, hwnd);

    var files = await picker.PickMultipleFilesAsync();

    myButton.Content = string.Join(", ", files.Select(i => i.Name));
}

 var hwnd = WinRT.Interop.WindowNative.GetWindowHandle(this);, in the example given this is a Windows.
@andrewleader How do we get the Window object in a Page object?

@harvinders you'll have to statically store the current Window somewhere you can access it globally. If your app only has one single window, the easiest thing to do is, in your App.xaml.cs, refactor...
private Window m_window;

to...
public static readonly Window MainWindow;

And then when you need to reference it, you can do...
var hwnd = WinRT.Interop.WindowNative.GetWindowHandle(App.MainWindow);

[Is there any way to pick multiple files and folders with the same OpenPicker in WinUi 3?]

[Is there any way to pick multiple files and folders with the same OpenPicker in WinUi 3?]

For both files and folders, a way is with IFileDialogCustomize
(I had posted a test sample at WinUI3_IFileDialog)

@castorix Getting error.

@castorix Getting error.

It is another error that some people met from Google
Did you build as Unpackaged ?
Do you have windows10.0.19041.0 SDK installed ?

@castorix No, I am trying with windows 11

@castorix No, I am trying with windows 11

Maybe try from a new WinUI 3 blank project, then set it Unpackaged, then add code by copy/paste...

@castorix Still can't select multiple folder.
What is use of this button ?

2nd option ( choose directory ) can't select multiple folders

@castorix Can we select multiple folders and multiple files at the same time?

@castorix Can we select multiple folders and multiple files at the same time?

Yes, with the custom Button added in the Dialog Box (that I named "Return selected items") :

@castorix Can we remot this button from picker?

@castorix Can we change the position to return the selected item button?

I copied-pasted CFileDialog.cs with quick changes to hide Open button and resize the custom button, to be improved : https://pastebin.com/NqLCLytq

Yes, I made a last change that I did not test...
For quick fix (but not great because the button text is hardcoded atm) :
Remove static  at
static ObservableCollection
Uncomment/Comment at :
IntPtr hWndButton = FindWindowEx(m_hWndDialog, IntPtr.Zero, null, " Return selected items ");
//IntPtr hWndButton = FindWindowEx(m_hWndDialog, IntPtr.Zero, null, m_Buttons[0].Label);

Is it the custom button that you renamed ?
If yes, change the text " Return selected items " by your button text ("Select" or other) (in WindowSubClass)
or FindWindowEx won't find it to change its position with SetWindowPos

Like that,

Yes, if the text is exactly "Select" (without paces)
And  for a cleaner code, a test should be added to check if hWndButton != IntPtr.Zero

Did it still not change select folder location,

You have set 0, 0 for location in SetWindowPos, instead of
pt.x + (rcOpen.right - rcOpen.left) + 12, pt.y

Still not change position of that select button,

Can you share your code snippet if it's changing at your side ?

In the main code :
cfd.AddPushButton(ID_PUSHBUTTON, "Select");
The class :
https://pastebin.com/a2Ntn335
Result :

@castorix All going perfectly but the files/folder picker is open in full screen. Can we change the size?

@castorix All going perfectly but the files/folder picker is open in full screen. Can we change the size?

On my OS, Windows 10 22H2, it saves the position/dimensions and it is opened at the latest ones.
For example, if I double-click on caption to set it Fullscreen, it will be re-opened Fullscreen next time; if I set it at 50, 50 with 100*100, it will be re-opened exactly at same location/size next time, and so on...

Are you sure it is the same code ? (I don't see the test on bOpen for example)
I get S_OK as result when I click on Select button (Unpackaged, Windows 10 22H2)) :

@castorix Yes, it is the same code, as I don't need the bOpen, so I removed that variable.

Does the code go in WM_APP_FILEDIALOG where I fill the file names and return S_OK ? :

@castorix No, it does not go.

Is m_hWndOwner correct at :
(the window handle passed as 1st parameter of ShowDialog)
        public void OnButtonClicked([In][MarshalAs(UnmanagedType.Interface)] IFileDialogCustomize pfdc, [In] int dwIDCtl)
        {
            IntPtr pClassPtr = Marshal.GetIUnknownForObject(this);
            SendMessage(parentCFD.m_hWndOwner, WM_APP_FILEDIALOG, (IntPtr)dwIDCtl, (IntPtr)pClassPtr);
            return;
        }

Hello @castorix  Brother, We have been getting unknown expectations for 7-10 days. I can't share the whole project with you due to the large dependency on a backend server and complexity. So, can we connect on a remote session for 15 min ( Link )? It will save a lot time of and it will be very helpful to us. I hope you can understand our situation. Thanks a lot in advance.


ZK Ethernet Inspector: support a case where ports are dynamically assigned

In JUnit, ports are dynamically assigned

Work in progress: https://github.com/twitter/zktraffic/pull/52

#55 closes this


[OFFER] Willing to help with non-Pro device.

Since we're in the same country, I was thinking of letting you tinker with my Discover Media non-Pro.
I have a 2016 VW Caddy. Need any info on the unit, let me know.
If you're willing, we could arrange something. I would do anything to help the community!
If my device bricks, it's easy for me to replace as I'm in the car audio business.

Thanks for the offer! I recently got a Technisat unit to play with. But....lacking the time to work on it. So currently no progress there.


fix: replace NumCPU with NumCores

Reason for Change:

replace NumCPU with NumCores, so that it can be correctly decode in dnc side.
Issue Fixed:

wrong request field name, should use NumCores instead of NumCPU
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests

Notes:

@zhangming870 what's the context? has this just always been wrong and silently ignored, or has something changed in DNC?

@zhangming870 what's the context? has this just always been wrong and silently ignored, or has something changed in DNC?

@rbtr We believe it always been wrong, because no one uses it yet. This is for dnc in managed mode.

good to merge

@zhangming870 can you rebase? there was a fix to the CI which should improve your check results 🙂

@rbtr sure. rebased.

@zhangming870 not sure what you did, but it messed up the commit history: https://github.com/Azure/azure-container-networking/pull/1358/commits
can you try and again and make sure you are rebasing, not merging master/other branches in to your branch? happy to help if you need some guidance on that.

@rbtr rebased again and did a sync branch, I guess it pushed history to remote. thanks for letting me know how to do that. And please let me know if anything still wrong.

/azp run


Reth beta not supporting deneb endpoints

Describe the bug
Mar 08 20:34:41.001 WARN Not ready for Deneb                     info: Execution endpoint does not support Deneb methods: Required Methods Unsupported: engine_getPayloadV3 engine_forkchoiceUpdatedV3 engine_newPayloadV3, hint: try updating the execution endpoint, service: slot_notifier
Mar 08 20:34:44.455 WARN Execution engine call failed            error: ServerMessage { code: -32601, message: "Method not found" }, service: exec
Mar 08 20:34:44.455 WARN Error whilst processing payload status  error: Api { error: ServerMessage { code: -32601, message: "Method not found" } }, service: exec
Mar 08 20:34:46.703 WARN Execution engine call failed            error: ServerMessage { code: -32601, message: "Method not found" }, service: exec
Mar 08 20:34:46.703 WARN Error whilst processing payload status  error: Api { error: ServerMessage { code: -32601, message: "Method not found" } }, service: exec
Mar 08 20:34:48.608 WARN Execution engine call failed            error: ServerMessage { code: -32601, message: "Method not found" }, service: exec
Mar 08 20:34:48.609 WARN Error whilst processing payload status  error: Api { error: ServerMessage { code: -32601, message: "Method not found" } }, service: exec
Mar 08 20:34:49.698 WARN Execution endpoint is not synced        last_seen_block_unix_timestamp: 0, endpoint: http://localhost:8545/, auth=true, service: deposit_contract_rpc

Steps to reproduce
Run the reth beta tag with lighthouse consensus
Node logs
No response
Platform(s)
Linux (ARM)
What version/commit are you on?
reth Version: 0.2.0-beta.1
Commit SHA: aec59b730
What database version are you on?
2
What type of node are you running?
Archive (default)
What prune config do you use, if any?
No response
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

Can you post the very start of the reth logs if you have them?

did you point lighthouse to the correct endpoint?

That was it, thx, this was an ad hoc deployment to test for #7022 and I made a typo :)


Decode json body

I don't know what's going wrong with StyleCI, sorry, but one time it shows that new line at the and of class doc block is required, but when I add that then it shows that added line is invalid... :/

Thank you @cve! Don't worry about the style-ci analysis. For next times you face issues with it, here is how you can easily fix them from your CLI:
wget https://styleci.io/analyses/[ANALYSIS_ID]/diff
git apply diff
rm -f diff

Replacing [ANALYSIS_ID] by the id of the corresponding analysis (here 8jDvxB)

Ok, thanks


Support for Function App

Feature request:
-Support for Function App in Event Grid Topics, at this point you cannot see nor create subscriptions manually created between Topics  and Function Apps with Azure CLI.  I would like to create these subscriptions from my command line instead of manually creating them and having to redo this for every Event Grid Trigger.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 63e73e1b-aad9-0ce8-be1f-a9b9d02ca6d4
Version Independent ID: 73525c5f-94f3-1c07-e3b6-3a022aab2a10
Content: az eventgrid event-subscription
Content Source: src/azure-cli/azure/cli/command_modules/eventgrid/_help.py
Service: event-grid
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

eventgrid

Hi @sebastiaanvandesteeg, we're looking to understand usage scenarios and pain points when customers are using Event Grid. Would you be interested in giving us some feedback on your experience with the library?

@lilyjma I am happy to give feedback based on my experience, so far I really like Event Grid and the flexibility of it.  The pain point though is the fact I have to configure so much from the Azure Portal, I would like to setup my Event Grid with a Function App using Event Grid Trigger binding.
Right now it's easy to set it up using the Azure Portal, but I would like to connect my Function App through configuration(just like any other connection, CosmosDB for example) in the Function App or creating a subscription with the Azure-CLI. But manually configuring this is just not good, I can't automate releases with this for example (atleast new functionality).
Within my company we use 3 resource-groups for the different environments, test -> acceptation -> production. With the current way of configuring I can do 95% through Github Actions and the Azure-CLI but it's hard to release new triggers on the Event Grid because you have to configure the subscription through the Azure Portal.
Since we are a forwarding company we use the Event Grid for internal events and notifcations. So we want it to be flexible, which the Event Grid itself is. But configuring is not...

Hello @sebastiaanvandesteeg .. Thanks for reporting this issue and requesting this feature.
Can you please add this request through the Azure feedback (user voice). Link is here: https://feedback.azure.com/forums/909934-azure-event-grid .. This will allow it to be voted on and makes it to our planning list.
Said that, it seems the ask here is to automatically create when function is created? is this correct?
Currently, Azure Event Grid support creating event subscription in our SDK with Azure Function as a destination (as well as a webhook). This requires The Azure function to be set up separately and to be fully functioning and you have full access privileges to it.
If this is not what you are looking, can you please provide us with additional information to understand the request better.
Adding @jfggdl for awareness.

@ahamad-MS Thanks for your reply. You are right, it's about creating a subscription automatically. I will submit a ticket in the Azure feedback.

Thanks @sebastiaanvandesteeg .. Can you please use user voice to open the feedback request and close this issue whenever you have a chance. thanks.


Taiko cannot interact with Electron App

Sample Repo to replicate the problem: https://github.com/saikrishna321/taiko-electron-boilerplate
Run jest command to trigger the code.
I enabled chrome proxy to debug the ws calls made to the electron application. I don't see any commands send to dev tools api.
https://gist.github.com/saikrishna321/21aa8ba47d5e6798768dba2b9ac9015b

https://github.com/saikrishna321/taiko-electron-boilerplate works with Taiko 1.0.0

Fixed as part of https://github.com/getgauge/taiko/issues/939.
@saikrishna321 Please verify.

Fixed 🎉


Response 500, when trying to join meeting on the guest sample app.

08-28 18:40:20.385 17298-17517/com.microsoft.office.sfb.sfbdemo I/[Http] HttpConnection: Got Response: 500 for: Post https://xxx.infra.lync.com/WebTicket/WebTicketService.svc/mex

We have a new version of the SDK. Please download and retry.
Please let me know if this works


Bad code generated

The command given in the current example:
 func new --name HttpExample --template "HTTP trigger" --authlevel anonymous
Generates bad code with the current func version 4.0.5611.  The generated function_app.py must be edited before running func start:

Replace:
auth_level=func.AuthLevel.Anonymous

With:
auth_level=func.AuthLevel.ANONYMOUS

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0e045946-4569-2d82-c495-3d1c15b39159
Version Independent ID: 9bea0106-46d2-2d70-9860-f51cc09171a1
Content: Create Azure Functions in a local Linux container
Content Source: articles/azure-functions/functions-create-container-registry.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Hey @kjeipta, I didn't run into that issue. I would double check the version or run --verbose

@RyabHill-MSFT  The version I noted that I have,  4.0.5611, is more recent than the version you posted:  4.0.5455

@kjeipta apologies for the late reply. Yes, I do see the issue. Appears the tools in the later versions uses camel case while the Azure Python SDK still uses all caps. For now, continue to use auth_level=func.AuthLevel.ANONYMOUS until the tooling can be corrected. I'll be sure the team is aware of this.
#please-close

I can confirm this issue with 4.0.5801:
$ func start
Found Python version 3.8.10 (python3).

Azure Functions Core Tools
Core Tools Version:       4.0.5801 Commit hash: N/A +5ac2f09758b98257e728dd1b5576ce5ea9ef68ff (64-bit)
Function Runtime Version: <IP_ADDRESS>69

[2024-06-06T05:31:25.294Z] Worker failed to index functions
[2024-06-06T05:31:25.294Z] Result: Failure
[2024-06-06T05:31:25.294Z] Exception: AttributeError: Anonymous
[2024-06-06T05:31:25.294Z] Stack:   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.8/LINUX/X64/azure_functions_worker/dispatcher.py", line 413, in _handle__functions_metadata_request
[2024-06-06T05:31:25.294Z]     self.load_function_metadata(
[2024-06-06T05:31:25.294Z]   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.8/LINUX/X64/azure_functions_worker/dispatcher.py", line 393, in load_function_metadata
[2024-06-06T05:31:25.294Z]     self.index_functions(function_path, function_app_directory)) \
[2024-06-06T05:31:25.294Z]   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.8/LINUX/X64/azure_functions_worker/dispatcher.py", line 765, in index_functions
[2024-06-06T05:31:25.294Z]     indexed_functions = loader.index_function_app(function_path)
[2024-06-06T05:31:25.294Z]   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.8/LINUX/X64/azure_functions_worker/utils/wrappers.py", line 44, in call
[2024-06-06T05:31:25.294Z]     return func(*args, **kwargs)
[2024-06-06T05:31:25.294Z]   File "/usr/lib/azure-functions-core-tools-4/workers/python/3.8/LINUX/X64/azure_functions_worker/loader.py", line 238, in index_function_app
[2024-06-06T05:31:25.294Z]     imported_module = importlib.import_module(module_name)
[2024-06-06T05:31:25.294Z]   File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
[2024-06-06T05:31:25.294Z]     return _bootstrap._gcd_import(name[level:], package, level)
[2024-06-06T05:31:25.294Z]   File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
[2024-06-06T05:31:25.294Z]   File "<frozen importlib._bootstrap>", line 991, in _find_and_load
[2024-06-06T05:31:25.294Z]   File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
[2024-06-06T05:31:25.294Z]   File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
[2024-06-06T05:31:25.294Z]   File "<frozen importlib._bootstrap_external>", line 848, in exec_module
[2024-06-06T05:31:25.294Z]   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
[2024-06-06T05:31:25.294Z]   File "/home/brian/Code/azurefunc/function_app.py", line 8, in <module>
[2024-06-06T05:31:25.294Z]     @app.route(route="HttpExample", auth_level=func.AuthLevel.Anonymous)
[2024-06-06T05:31:25.294Z]   File "/usr/lib/python3.8/enum.py", line 384, in __getattr__
[2024-06-06T05:31:25.294Z]     raise AttributeError(name) from None
[2024-06-06T05:31:25.294Z] .

and in function_app.py:
import azure.functions as func
import datetime
import json
import logging

app = func.FunctionApp()

@app.route(route="HttpExample", auth_level=func.AuthLevel.Anonymous)
def HttpExample(req: func.HttpRequest) -> func.HttpResponse:
    ...

Changing it to func.AuthLevel.ANONYMOUS lets the API run as expected.


Document title not translatable

The document titles "Receipt", "Invoice", "Statement" are inherited from the class name, which makes them non-translatable.
Even if you start empty, there is not an option to set a custom title. Am I missing anything?
It may be better to remove this dependency and just use the class name as fallback when no title option present.

it is already a fallback to the title attribute but not documented so this works
Receipts::Receipt.new(
   title: "Package slip",
    )

Wanna make a PR to add that to the docs?


Explore custom thumbnail detectors for specific websites

It seems likely that there are dedicated APIs for getting thumbnails for things like Amazon listings, YouTube videos, etc.

It feels like there's a lot of work that can be done to improve the generic thumbnail detection, so I'm going to put this one into future for the time being.


mssql: Error 40532: Cannot open server "xxx.com" requested by the login. The login failed.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

SQLTools Version [e.g. v0.17.x]
VS Code Version: [e.g 1.x.y]
OS: [e.g. Windows, Linux, Mac]
Driver:

[ ] PostgreSQL/Redshift
[ ] MySQL/MariaDB
[ ] MSSQL/Azure
[ ] SQLite
[ ] Other? Which...

Database version: [e.g. MySQL v5.6, PostgreSQL vX...]

Additional context
Add any other context about the problem here.

@nice1517 please edit this issue so it contains the information requested by the template.


Implemented postProcessor option, a tweaked version of predicate

I wanted to have a control on output, basing on prevState, nextState and action altogether.
Main goal was to greyout (or not to show at all) log messages of actions which did not cause store state mutation.

Your example with group color is narrowly focused, I don't think it can be popular feature. If you want full control of log based on prevState, action and nextState altogether, you need fork redux-logger and implement your version on top.


How can I get the aligned infrared image?

Required Info

Camera Model
D400

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
Win 10

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC

SDK Version
2.54.1

Language
C++

Segment
others

Issue Description
How can I get the aligned infrared image but not the infrared image overlaid with the  depth image(as following image)?
My code is:
rs2::frameset frames1 = pipeline.wait_for_frames();
rs2::align align_to_depth(RS2_STREAM_DEPTH);
rs2::frameset frames = align_to_depth.process(frames1);
rs2::frame infrared_frame = frames.get_infrared_frame();
cv::Mat infrared_img(cv::Size(frame_width, frame_height), CV_8UC1, (void*)infrared_frame.get_data(), cv::Mat::AUTO_STEP);

Hi @hosea7456 There is no need to perform alignment between infrared and depth if you do not want a combined image. This is because the left infrared image is already perfectly time-syncronized and pixel-perfect aligned with the depth image by default, This is because the left infrared sensor is also the origin point of the depth image.

Thank you for your prompt response! I got it, I've been using "rs2::frame infrared_frame = frames.get_infrared_frame(2)" by default.

You are very welcome.  Index '2' is the right-side infrared stream, whilst '1' is the left stream that is aligned with depth.  You do not need to use an index number if only using one infrared stream though as the left stream is used by default.

Hi @hosea7456  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.

Just wondering, is it possible to align the infrared frame to the color frame? The image I got from this process seems to be off with the color frame.
            frames = self.pipeline.wait_for_frames()
            # Align the depth frame to color frame
            align = rs.align(rs.stream.color)
            aligned_frames = align.process(frames)

            # Get aligned frames
            aligned_depth_frame = aligned_frames.get_depth_frame()
            color_frame = aligned_frames.get_color_frame()
            ir_frame = aligned_frames.get_infrared_frame(1)

Hi @jwwang0-0  When using align_to, one of the two streams that is being aligned has to be depth.  However, because the infrared stream is already aligned with the depth stream it is possible to produce a combined depth, color and infrared image.  An example of doing so in Python is at https://github.com/IntelRealSense/librealsense/issues/5093

Thanks! Your answer is quick, great and useful 😆.  Sorry if I may ask one more question, is the focal point located at (0,0,0) of the depth frame?

When depth is unaligned, its 0,0,0 origin is the center-line of the left infrared sensor.  But when depth is aligned to color, the depth origin becomes the center-line of the RGB color sensor.

Cool! Thank you for your explanation.

The last question: I am doing some accuracy tests of the D455. The official document said that its accuracy is less than 2% within 4m. From my test result, an object moved 20mm in real; based on realsense, it moved 18mm. I think it is quite good in this case. Do you have more data about the accuracy of it? 1m with 2% is 2cm which is quite poor.

Error starts at around zero at the front glass of the camera and increases linearly as distance of an observed object / surface from the camera increases.  This is called RMS Error.
The D455 camera model has 2x the accuracy over distance of the D435 models.  For example, at 6 meters distance from the camera the D455 has the same accuracy as a D435 has at only 3 meters.


Using Cropped Faces

Hello! Thank you for posting the code for this nice work. I have one question: Why do people use cropped faces as input instead of original images as input and turn detection task to a off-shelf detection model? I assume they want to make the model focus more on classification and don't let the model ruin the detection results. Is it correct? Thank you!

Thank you for your interest in our work. The active speaker detection task is a specific instance of audio-visual separation. If you want to detect the speaker from the original video, you can focus on the related work of speaker diarization [1].

[1] Xu, Eric Zhongcong, et al. "Ava-avd: Audio-visual speaker diarization in the wild." Proceedings of the 30th ACM International Conference on Multimedia. 2022.


snippet tags added.

Added snippet tags for the samples.

@tdunn Can you please review?  Thank you!


I can׳t understand how should i load data inside the list?

Thank you for your amazing plugin, but how can i load data?

Hey @roysG,
This sort of question is better asked on Stack Overflow or on Gitter. Move it over to one of those channels and I'll be happy to help answer. 😄

@bvaughn, thanks for you quick response, i searched in stackoverflow and still i didn׳t find.
It will be better if this will be explained in documentation.

Ok, thanks i find it.

I'm the only maintainer for this project and so I encourage people to ask questions on Stack Overflow or Gitter so that other people can help answer them. Bugs belong in Github but questions belong on those other sites. That's all I meant. ;)
Glad you figured it out!


Git Guide: expand on creating a Github account

Feedback that I received on the forking section:
Step 0 for forking the repository is "login to Github and/or create a Github account".  We might want to mention that they may want to separate their personal, open-source contributions from their profession, employer-sponsored accounts.
Might also want to clarify the difference between github.com and Github enterprise since more and more people have Github enterprise accounts but not github.com accounts.

I will work on this


Document lifetime of services in middleware

See https://github.com/aspnet/Mvc/issues/3860

Add to middleware topic.


CoreTextServicesManager.InputLanguage returns wrong language

I have found that Windows.UI.Text.Core.CoreTextServicesManager.InputLanguage.LanguageTag may return wrong input language that is not the same as returned from Windows.Globalization.Language.CurrentInputMethodLanguageTag. It is wrong in case of some transient input languages (that doesn't have LCID). It seems there is same issue as I have already reported with LCIDToLocaleName API.
It could be easily reproduced like this:
 Windows::UI::Text::Core::CoreTextServicesManager::GetForCurrentView()->InputLanguageChanged +=
        ref new TypedEventHandler<Windows::UI::Text::Core::CoreTextServicesManager ^, Platform::Object ^>(this, &SDL_WinRTApp::OnLanguageChanged);

....

void SDL_WinRTApp::OnLanguageChanged(Windows::UI::Text::Core::CoreTextServicesManager ^ sender, Platform::Object ^ args)
{
    Windows::Globalization::Language ^ language = sender->InputLanguage;
    Windows::Globalization::Language ^ language2 = ref new Windows::Globalization::Language(Windows::Globalization::Language::CurrentInputMethodLanguageTag);
}

What Get-WinUserLanguageList PowerShell cmdlet returns:

Also reported here: https://github.com/dotnet/runtime/issues/82367

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9f24da47-f47b-8a3e-c62d-0d7c691a42ef
Version Independent ID: 5d24c8fa-3529-2647-b35b-27a809a9fa15
Content: CoreTextServicesManager.InputLanguage Property (Windows.UI.Text.Core) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.UI.Text.Core/CoreTextServicesManager.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @Karl-Bridge-Microsoft
Microsoft Alias: kbridge

@Karl-Bridge-Microsoft can you please take a look?

Hey @Karl-Bridge-Microsoft! Do you have any updates on this topic?

@Karl-Bridge-Microsoft any news?


Removal of Plex-Remote-Transcoder

Since I installed this its worked pretty awesome however upon install my Plex server lost its ability to offline sync and I also cannot Stream to IOS devices. I was wondering how could i remove this without causing damage to my Plex install. I have already shutdown my Plex Slave host. Are there any particular directories or config files i should remove? I want to restore service to my offline sync and Streaming please let me know if you get an available moment.
Thanks
Joe

I've been out of the loop for a while so I need to review the background info but this is a known issue with a known fix. Basically the sync uses a custom area for the encoding and the quick fix is to make the /var/lib/plexmediaserver nfs export read/write (or rw) instead of read only (or ro) as stated in the installation guide and that will fix that issue. There has been discussions about how to try and fix this without opening up that whole file structure as read/write and I need to find out where that got to but that will fix your issue as I had it myself.
In /etc/exports change the ro to rw for the file system
/var/lib/plexmediaserver
Re-export
sudo exportfs -r
And on the slave(s) either unmount and mount that share or to be sure it's all clean just restart the client system and on next boot it should be able to process those other types of jobs.
As for removing if you are determined to do so then you can either just remove the .prt.conf file in the plex user home directory and it will only use the master which has access already and then you can look at fixing it another way or you can either remove this file -
rm "/usr/lib/plexmediaserver/Resources/Plex New Transcoder"
Then move the old one back -
mv /usr/lib/plexmediaserver/Resources/plex_transcoder /usr/lib/plexmediaserver/Resources/Plex New Transcoder
Or reinstall the plex -
sudo dpkg-reconfigure plexmediaserver && sudo apt-get -f install
But as I mentioned changing the export to read/write will fix it.
Cheers,
Liviy

While it's never a good thing to have people want to uninstall your hard work we should probably add a delete and/or a disable option before PRT gets labeled malware due to the lack of it ;)

Yeah, agreed.
On Sat, May 7, 2016 at 6:28 PM Liviy<EMAIL_ADDRESS>wrote:

While it's never a good thing to have people want to uninstall your hard
work we should probably add a delete and/or a disable option before PRT
gets labeled malware due to the lack of it ;)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/wnielson/Plex-Remote-Transcoder/issues/23#issuecomment-217681992

Generally installation tutorials will include a section at the end about complete and efficient uninstallation. Since PRT already has a nice Ubuntu tutorial, having a section at the end of that about how to return to a normally-functioning PMS and fully remove everything installed by PRT seems ideal to me.

I added a section to the tutorial about uninstalling.


Support for mssql named instance

Hi,
How to add support for named instance on mssql?
Regards.

@ngcammayo what do you mean named instance? Having multiple mysql db's in the project?

Ah, I guess not. I don't have the slightest clue about mssql. Can you fill me in a little bit more so I can hopefully support this in the new version if necessary ?

Hi, i was referring on the database instance i.e. localhost\sqlexpress2014. The connection string seems to be invalid when using named instance. For now as a quick solution, I already re-installed the database server and use the default instance.

See comment in #42 - v3 api should solve this


[4.2] Correctly fill the $request->request parameter bag on creation

Can you describe the bug?

Also a test would be nice. Thanks :)

The bug is described in the description. I'll add a test later today.

Updated.

Updated.

Can you describe how this actually effects applications? What could you not do before that this fixes?

In our case: we pass on the SymfonyRequest object to the OAuth2 server from the php league with this method. It then uses the $request object to get the request body, which should been parsed (with a parsing method defined by the Content-Type header or application/x-www-form-urlencoded) by default. The $request->request parameter bag is used here and here. It only works for application/x-www-form-urlencoded unless we manually create the $request->request parameter bag when we set the request with setRequest() method from the AbstractServer class.
There are several people and issues with the request to support application/json like thephpleague/oauth2-server#292.


Make proposal for tackling technical debt

Background
As discussed in the 8.24.21 meeting, there are several areas of 'technical debt' that should be remediated before we embark on ambitious expansions and feature development. These areas include:

Updating software to latest versions.
Making procedures for ensuring that software remains up-to-date and security issues are addressed promptly.
Creating proper development / staging / production environments and associated workflows.
Developing explicit procedures for updating, testing, and deploying code.
Properly documenting our code and site.
Addressing problems that appear in logs but don't necessarily manifest in obvious issues for users.
Cleaning up and documenting server filesystems and settings.
Creating tools for support and users to address common needs that currently require ad hoc developer intervention.

To Do

[ ] Develop an initial proposal for addressing technical debt over the next few months (Mike).
[ ] Refine and discuss proposal (Bonnie & Mike).
[ ] Consult with Grant about proposal, strategies for remediating technical debt (Bonnie & Mike).
[ ] Present proposal to HC Team (Bonnie & Mike).

Draft document: https://docs.google.com/document/d/1z626zhiAWeukYu_RZS2e7NpVaCGtYswOs6w0wYkvlyA/edit#

Steps before Tuesday's meeting:

[ ] Mike edit document to remove time estimates, create section explaining that we're taking the next month to plan out in more detail what is involved, which will allow us to have a better idea of how long things might take.
[ ] Mike brainstorm issues to be tackled over the next month
[ ] Bonnie brainstorm issues to be tackled over the next month
[ ] Mike and Bonnie meet at 10 on Tuesday to create roadmap for next month, get proposal ready for meeting.


Google Recommend app architecture

Does google architect its apps with MVP or MVVM ?
Google sample apps show no specific architecture at all,
Is it ok if we don't architect at all?

Or use this community
https://plus.google.com/communities/105153134372062985968

thank you !
btw I'm now using MVVM with data binding. this way both fragment and activity could be used as view and multiple ViewModel for each fragment can be used .
i don't know if my approach is right, but it works for me.


Fix pre-commit copyright check

This PR is a small fix for an error I ran into locally on the copyright check.

Thanks Bradley! 🙏
Should we add copyright lines to other files like these as well?
https://github.com/rapidsai/pynvjitlink/blob/571a69e68cf763b03ad407ca12589713793c2639/.ycm_extra_conf.py#L1
https://github.com/rapidsai/pynvjitlink/blob/571a69e68cf763b03ad407ca12589713793c2639/test_binary_generation/Makefile#L1
https://github.com/rapidsai/pynvjitlink/blob/571a69e68cf763b03ad407ca12589713793c2639/test_binary_generation/test_device_functions.cu#L1
https://github.com/rapidsai/pynvjitlink/blob/571a69e68cf763b03ad407ca12589713793c2639/test_binary_generation/undefined_extern.cu#L1

@jakirkham The copyright checker will enforce that in the future, next time those files are modified. If you would like to add them in this PR, feel free to push.

I'm going to merge this as-is. We can gradually fix the files in this repo as they are edited, which is the same strategy we've been using across RAPIDS.

/merge


refactor(example): use headlineMedium instead of headline4 in example app

⬇ Generated builds by Codemagic for commit 5fb9b6c467d83b11b2f905cc7572fa504044df6c ⬇
This is a custom message.

iOS
Android
macOS

  Download link
  Download link
  Download link

Isn't available the used Flutter version.


Make GrowthBookSDK gb property optional

This was a late property before which was causing issues because the
UI would load before gb was initialized. This caused the screen to
flash red with a LateInitializationError. Once gb was initialized the
red screen would be replaced with the example app main screen.
Check gb != null before loading UI.

I don’t understand this change. Is there a test that proves that it’s fixed? Where are you seeing a red flash?

This SO has some good discussion around using late variables:
https://stackoverflow.com/questions/67197902/how-to-check-late-variable-is-initialized-in-dart

I don’t understand this change. Is there a test that proves that it’s fixed? Where are you seeing a red flash?
Could use some help thinking about how to test this. Reproducing requires a DEV_KEY and HOST_URL, but we could fake the response/result in the test.

Here is a screen recording showing the red flash:
https://user-images.githubusercontent.com/13595016/231904763-20927bdd-d3f4-4dd0-9677-195505a18fa1.mp4


Add back button for Auth

Is your feature request related to a problem? Please describe.
We used functional tests and saw that if a user types his phone number wrong, he should be able to go back a step at auth and retype it.
Describe the solution you'd like
Add a button to go back a step after entering phone number

Done and merged into feature/gh-123


merge matches_archetype and matches_table

Objective
the code in these fns are always identical so stop having two functions
Solution
make them the same function

Changelog
change matches_archetype and matches_table to fn matches_component_set(&self, &SparseArray<ComponentId, usize>) -> bool then do extremely boring updating of all FetchState impls
Migration Guide

move logic of matches_archetype and matches_table into matches_component_set in any manual FetchState impls

PR description could provide a bit more context on what exactly these types are, but I'm happy with the changes themselves.

@BoxyUwU @alice-i-cecile
Came across this change while reviewing #4626: im not sold on this for a number of reasons:

This forces each caller of matches_component_set` to decide what it means for an archetype or table to match a component id. This should not be externalized, it is a core part of what it means for a query to match an archetype / table.
It assumes that archetype matching will always hinge on ComponentIds. I think there is a reasonable chance that we will add things like "value based" archetype identity (ex: for things like indexing), which would split out our definitions of "matches table" vs "matches archetype".
We've removed a "duplicate" method from each impl, but it comes at the cost of additional implementation complexity because it adds the abstraction of "calling an arbitrary input function". It is much harder to tell whats going on (and the purpose of the function).

Ah I see: I'd missed some of the broader context.

I think this is an important consideration: I agree with your concerns here.
I agree that we'll likely have some form of value based matching. I'm reluctant to call this an "archetype", because of how much that further muddies the waters around what an archetype is. By itself I don't think this is a good reason to block this change; those changes are a long way in the future.
That's a fair criticism.

@BoxyUwU, you mentioned you had rebuttals to these concerns but never remembered to actually write them down :)


Sell tab tracking in iOS

My first cohesion PR 🔥
What
cc @pepopowitz

Tracking for the new Sell tab in iOS
Design here ("Sell tab landing - current build" section)
events tracked here

Questions on the PR

I am not extra sure of my new context_module names - would love some feedback here.
tappedConsign event:

This is just a tap of a button, but I created this new event to single out consign taps (as on Force). Welcoming any thoughts here whether I should create a broader event.
I added a subject property. I added this property in the event file and not in a separate property file such as context_module. Is it OK?

Questions on Cohesion

What is the difference between the general tap event and all the "sub-events" in it? (tappedArtistGroup, etc.). My underlying question is when should I branch out of a generic event?

Next Steps

Let me know if this PR works or if I am totally wrong. In the latter case I could pair with @abhitip ?
@pepopowitz I think you might have to create a new event for tappedConsign in the /Events folder?

Closing Remarks
This PR has been very very smooth to write big props @abhitip and @eessex !!!
Todo

[x] Refine context modules for tapped consign
- [ ] Subject properties for tappedArtworkGroup and tappedArtistGroup

@louislecluse  the tappedConsign event is sourced from a button within the sell tab, correct? versus the tapping of the 'sell' icon within the bottom nav? Just checking, since I think the bottom nav taps could comprise their own tap event/module.

Additionally @pepopowitz I think the context modules for tappedArtworkGroup and tappedArtistGroup are too detailed (spreadsheet)
What is the name of the context modules for the artist grid and the recently sold works grid in the sell tab? We may want to use these as context modules.
I can then add a subject property that describes the exact text for each grid (eg: "Artists collectors are looking to buy" for the artist grid).

Given the detailed names in https://github.com/artsy/cohesion/blob/master/src/Schema/ContextModule.ts, I actually think the names you provided for context modules are great. They clearly identify the rail/grid in question. We don't have any context modules attached to the code yet - we won't until we implement the tracking.

Had one minor comment but otherwise this looks great to me! New context_modules and adding the subject field makes a lot of sense to me :)

Oh also, action should not be a special property that is passed to segment. It's just what engineers use to indicate the event_name. I noticed action in your spreadsheet and just wanted to make sure that you were aware of that!

LGTM!

:rocket: PR was released in v1.0.4 :rocket:

I'll follow up to add a helper 🎉


streamline localization process

easier for admins to create new language
better user documentation?
#388 - ability to contact language admins
are translations going into source control?
how to deploy translations
how to update/refine translations as they are improved after deployment
@jisqyv

@jsheldonmit This isn't really an issue for the sources. We need to redesign how we are handling translations. We should have a meeting to just deal with this issue. I should be in on Monday, and I can do a hangout on Friday (and maybe Thursday afternoon depending on how things go that morning).

Gotcha.
On the topic of meetings, maybe Thursday or Friday, and if not, then later next week, as I’m traveling to CSTA on Monday/Tuesday 7/13&7/14.
If this doesn’t go in sources issues, do you have a suggestion for where we track this kind of issue? Start another github project that exists mostly for issue tracking?
Thanks
josh
Josh Sheldon
Director of Strategic Programs – MIT App Inventor
Project Manager - MIT Scheller Teacher Education Program
MIT Center for Mobile Learning
20 Ames St., Bldg E15-309
Cambridge, MA 02139
cell:<PHONE_NUMBER>
work:<PHONE_NUMBER>
http://appinventor.mit.edu - @MITAppInventorhttp://twitter.com/MITAppInventor
http://education.mit.edu - @mitSTEPlabhttp://twitter.com/mitSTEPlab
From: Jeffrey Schiller <notifications<EMAIL_ADDRESS>Reply-To: mit-cml/appinventor-sources <reply<EMAIL_ADDRESS>Date: Wednesday, July 8, 2015 at 11:11 AM
To: mit-cml/appinventor-sources <appinventor-sources<EMAIL_ADDRESS>Cc: Josh Sheldon <jsheldon<EMAIL_ADDRESS>Subject: Re: [appinventor-sources] streamline localization process (#457)
@jsheldonmithttps://github.com/jsheldonmit This isn't really an issue for the sources. We need to redesign how we are handling translations. We should have a meeting to just deal with this issue. I should be in on Monday, and I can do a hangout on Friday (and maybe Thursday afternoon depending on how things go that morning).
—
Reply to this email directly or view it on GitHubhttps://github.com/mit-cml/appinventor-sources/issues/457#issuecomment-119619256.


Added support for API 19 (Android 4.4) through API 30 (Android 11)

Hello Laurent, as discussed I've updated your library to support API 19 - 30. I noticed a bug when targeting API 30 that I could not grant access to the OEMIdentifiers, but the issue disappears when targeting API 29. I'll need to follow up with this separately but works for now.
Could you double check the gradle files in particular please? I haven't seen this method of pushing to jcenter before so I may have overlooked something!

Thanks James for the update.


[populations] Fetch course data only when it is needed

Currently students --> courses table will not render correctly if the tab is opened before the data is loaded. This needs to be sorted out if we want to fetch the data only when the user uses the data

The data needs to be loaded when user lands on population page


Bot automerge failing

The most recent two releases are failing (#13).
+ pip check
xarray-spatial 0.2.0 requires spatialpandas, which is not installed.
Tests failed for xarray-spatial-0.2.0-pyhd8ed1ab_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING:conda_build.build:Tests failed for xarray-spatial-0.2.0-pyhd8ed1ab_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING conda_build.build:tests_failed(2955): Tests failed for xarray-spatial-0.2.0-pyhd8ed1ab_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: xarray-spatial-0.2.0-pyhd8ed1ab_0.tar.bz2

Seems like spatialpandas might be required now, but hasn't been added to the meta.yaml.

Fixed in https://github.com/conda-forge/xarray-spatial-feedstock/pull/13/commits/a1a84ae7ab29cf3bd15b42ddbe38b9c55969d127


Serverless p2p example?

I'm looking to give Swarm a spin in a p2p app, but the example in the readme appears to be for client-server sync.
Is p2p sync in a working state at the moment? What would we have to do differently in a p2p sync scenario compared to the client-server example?
Thank you for your work on this amazing library by the way! =)

1.0 syncs by a tree of replicas. That allows for some great optimizations.
In other words, it is impossible to sync to a random node.
For random topology gossip, state based CvRDTs are much better. Swarm is an op based CmRDT system.

Thanks for the clarification.
Does this mean the p2p sync capability mentioned in http://swarmjs.github.io/articles/1of5/ is no longer feasible, or is it still on the roadmap for a future release?

Given that some server exists somewhere and is available periodically, it is possible to do "shortcut syncing" between any two replicas. That feature is on the roadmap.
Fully p2p sync was available in .3, but that feature is too expensive.

@gritzko Will it scale ?
From your docs:

There is a bunch of political, engineering and usability arguments in favor of P2P architectures. Unfortunately, building P2P systems is order of magnitude harder.

Impressive project! Could a few million smartphones sync a single "Swarm"?
[Delft greetings]

It will.


Create Mk2Essentials-6.ckan

This new version has been out for months. I believe it works fine in 1.0.5; the previous version already seemed to.

Merging with my thanks


Ubuntu 22.04

What new feature would you like to see?
Can you add support for ubuntu 22.04?
Which of these categories fit your request?
Other
Just checking...

[x] I have confirmed that my feature has not already been requested.
[X] I have confirmed that my feature has not already been implemented in the review branch.

Have you tried installing?

No.

I could try later

Can confirm it works on Ubuntu 22.04 just fine


Using fsacruntime with netcore setting causes errors in UI when using non .Net standard type providers

I have a project with a non .Net core type provider which uses the fsproj file change supplied by Don to enable it to work in .Net core projects. This was developed with the fsacruntime set to net. With the runtime set to net there are no problems with Ionide.
I then opened another project and Ionide encouraged me to switch over to fsacruntime=netcore which I did.
I reopened the original .Net core project with a non .Net core type provider. This build fine on the command line but in Ionide I get errors on any types provided by the type provider. I've attached a screenshot below which shows the type provider issues.

Duplicate of #1026


Planned features and required tasks for v0.1 Developer Preview 1.

Source for some items: https://twitter.com/DrewTNaylor/status/1415110624561045505

[x] Sort the All Apps list according to their "Name" key
[x] Make pinning and unpinning tiles work

[x] Pinning tiles
[x] Unpinning tiles
Unpinning tiles is fine, but pinning tiles can have some issues as described in #85.

[x] I never did fully implement tile resizing with a context menu and went directly to the corner buttons once I verified the buttons in the context menus could get stuff into Python. Until tile resizing can be done from an arrow on the corner of the tiles, I should add two extra "pin to start" items to the list, in addition to the medium one:
- pin to start (medium)
- pin to start (small)
- pin to start (wide)
- They're in that order because medium was the default on WP, and changing tile sizes with the arrow button on WP would go from starting at medium: small, wide, medium.
- Resizing from the tile itself may require Avalonia Behaviors.

In addition to the items above, I also need to do these:

[x] Modify the appbar in RetiledSearch so it looks correct.
[-] Add the scrollbar to the All Apps list Delayed until v0.1-DP2.
[x] Get the All Apps list entry item context menu looking close enough to what it should be.
[x] Filter out everything in the Exec key that's unnecessary so that opening programs works generally as expected.
[-] Pass the .desktop file assigned to each All Apps list entry and tile to dex for now as described in #52. A future version, likely the version right after, will include a port of libdotdesktop_standard to Python which I'll use. That port will only contain the code for removing extra stuff like %F, as I want to keep it as light as possible and I don't really need the heavier features that are supposed to be available in the original version but aren't implemented yet there, either. We're just using the Python port of libdotdesktop_standard (libdotdesktop_py) by default. Not sure about support for dex.
[x] Guess I can just add an item for cleaning exec keys with libdotdesktop_py.
[-] (Moved to DP2) Allow the user to set their accent color in a config file and figure out a way to bind background color values for the All Apps list items and the textbox and button in the Search app. This value will be used as a fallback in case tiles don't have their accent color specified in the layout file (likely startlayout.yaml), but if the accent color is also not specified, it'll fallback to Cobalt. To make things easier, I'll probably use a separate file to store values for accent colors and the theme, probably themeconfig.yaml. Actually, the light theme vs dark theme switching may be a little difficult to do right away, though this code should help when I get around to add light theme support: https://github.com/nullvoid-creations/Jaya/blob/dev/src/Jaya.Shared/ThemeManager.cs Eventually I'll also add support for third-party themes.

This'll be closed when I transfer the changes required for DP2 to a separate issue for easy tracking.

I've moved the unfinished things to a new issue. This issue is now closed.


Sample app

Why don't you include a small app for using the tool? or at least a few coding in the introduction?

PDF is not working with Unicode? it's showing wrong order for Arabic letter as example

@omarmallat, I plan on creating an example app, but I do not have time to do it at this moment. Maybe somebody from the community would help with that.
If something is wrong with the PDF formatting then create a separate issue. I am using this library to create reports in Russian and do not think that problem is with Unicode. SimpleWPFReporting relies on third party library to generate PDF, so I am not sure if anybody could help you with that unless you are willing to help yourself.


Hotfix/googledrive log path

Purpose
Fix https://trello.com/c/VJ8Yzweq/76-consistency-of-linked-repo-folder-addon-logs. Refactor googledrive folder name in log part back to folder_path. The space display as %20 problem is actually not addressed in my pr but in https://github.com/CenterForOpenScience/osf.io/pull/2231.

@sloria rdy for review


Uncomment useless import

There are two major changes:

uncomment the useless model import in the files in models
replacing yaml.load with yaml.full_load in options/opts.py

@GolferChen Hello, thanks for your kind help. I will merge it soon. 🙌


replace Testlagoon images with uselagoon+tag, smoother local dev

so the goals here:

Set the charts to use the named release of Lagoon (2.0.0-alpha.1) from the uselagoon repo as a default
Allow the makefile (or command line) to provide a different repository (testlagoon) or tag (main etc) for the images
Be able to locally build the individual namespaces (core, remote, tests) without having to rebuild everything - again using the common repository/image settings
Fix up the variable naming in the build-deploy-dind variable overwrite (not working yet)

Thinking about this some more, I think part of the problem with getting this green is that it is too big. Maybe we should split this PR into (at least) three parts:

Update the image registry defaults.
Add the new test suites.
Changes to the Makefile structure.

What do you think?

yup - I'm going to have to split it up further I think!
As for the envsubst templating - I agree it's not ideal - but I don't know if the multiple --set commands are better.  Ideally there should be a solution that's as easy to follow as possible!
I'll have another think.  I'll post another commit that fixes it all up, and then split it from there.

so it turns out the if the ct install doesn't install because of missing unpullable images, it just silently fails :facepalm:

Updated this to the alpha-3 tag, passed all tests (finally!)


When adding an invalid user in Osekai Rankings, the server returns a 500 error

So you will not get a message such as "Could not add because of invalid user name".

It looks working as intended now: it returns "This user could not be added: User does not exist" message in case you put an invalid username. Probably been solved in #89.

yeah, seems fixed


[WIP] AI custom cards

Added interface for custom card renderer
Added MessageRenderer implementation for messages with HTML-based metadata
Added logic for handling messages with metadata as regular operator message in case when metadata can't be handled

@EgorovEI please check if the SDK is building well before the merge.


offers.loadMyInventory() doesnt return an array of items.

I understand that it will only return an array of items on success, I dont know the error though.

steam.on('tradeOffers', function(number) {
offers.loadMyInventory({
appId: 730,
contextId: 2
}, function(err, items) {
// Getting number of keys
// items doesnt return any array.
for (var i = 0; i < items.length; i++) {.......

I also setup the trade offers before(?), not sure if this is being run before.

steam.on('webSessionID', function(id) {
steam.webLogOn(function(newCookie) {
offers.setup({
sessionID: id,
webCookie: newCookie
});
});
});

are you trying to get tf2 inventory? In this case your problem is the appid, which is 440 for tf2.

@Ax6 Nope, its for csgo, thats 730 afaik.

Then I'm not sure where the problem is, have you already tried console logging the raw item list returned by loadMyInventory?

Most importantly, you should be checking the err value in the loadMyInventory callback.

@Ax6 @scholtzm Interesting! Seems like steam went down or something, now its all working again, items returns an array of all items. Kinda odd, but ill get a fix out so my bot doesnt crash everytime steam goes down.


Changed API?

I have this in my in my gruntFile.js and it worked fine before updating Node, but now it, not only uses hash instead of date but also skips making assets_versioning.js. Something I'm doing wrong? My apologies in advance if this is not the right place for this.
Here's the part for assets_versioning
assets_versioning: {
options: {
use: 'date',
dateFormat: 'MMDDHHmm',
tasks: ['uglify:min'],
skipExisting: false
},
target: {
expand: true,
options: {
output: 'versioning/assets_versioning.json'
},
},
}
the minified and versioned file is hashed, not dated and the assets_versioning.js doesn't get created.
Thank you,
Aron (a.k.a. chakkimatti)

Yes, the API changed with version v0.6.0. Please read the readme file for more details. If you don't want to upgrade, you can update your package.json file so that it points out to the specific version you want to stick with.

Thank you. I will.


chore: add issue and PR templates

:tada: This PR is included in version 4.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Feature request: disable default content styles

Right now I need to overwrite default editor styles in order to apply my global styles. Would be nice if the editor could optionally inherit these styles for its content alone. Menu-bar is fine, I wouldn't want to change that.

I haven't considered this yet. Maybe I will extract the rich text css file, if need, user can introduce style file.

now element-tiptap content styles are below el-tiptap-editor__content class, you can use custom class for your content.


DRY, KISS, and YAGNI rules - Do I follow JavaScript best practices?

Nothing to say for now.

Done with this Issue. Thanks


Feature: Integration with Databricks API

Databricks (Spark-as-a-service) recently added native support to Airflow for their Jobs API (https://docs.databricks.com/api/latest/jobs.html, https://databricks.com/blog/2017/07/19/integrating-apache-airflow-with-databricks.html).
I'd like to work on adding a similar functionality to Luigi as a new contrib submodule. Still thinking through what targets/outputs would be, will add thoughts here as I start working through it.
Any thoughts or comments?

I think a DatabricksSparkSubmitTask using Databricks' Jobs API and another module that could kick-off a cluster using Databricks' Cluster API would be very useful.

@a1xt06 I hadn't thought about kicking off a cluster! Might take a pass at that too. Was also wondering if having a set of DBFS targets would be helpful.

DBFS targets might be useful, but as a first pass, using Luigi's S3Target for targets would probably be enough, especially considering most DBFS endpoints will be associated with mounted s3 buckets. I'm guessing doing DBFS endpoints would require using Databricks' DBFS API, and I haven't looked into that API.
At the same time, it might be nice to have DBFS endpoints as a part of a roadmap, considering Databricks' is trying to add Azure support (maybe?) later this year, so the S3Target might not be enough for Luigi on Microsoft's cloud.

@a1xt06 I just added a pull request (took me long enough, eh); if you have the ability to do some light review or testing would appreciate your input.
And since now Databricks does have Azure support (with DBFS pointing to Azure Blob Storage) it may be more helpful to have DBFS targets defined. I might be able to get started on this over the holiday break.

See https://github.com/spotify/luigi/pull/2312 for an Azure Data Lake file storage option. I may write a module to support Azure Blob Storage as well.

Are there still any plans to add this functionallity? I see a stale PR here that started to get it to work...


WebApp SSL binding bug

#2935 - No update since June but this is still an issue in the latest release v1.2.
I've tested in a new web app with certificate installed. The certificate binding is not added.
           _webApp.Update()
                .WithClientCertEnabled(true)
                .DefineHostnameBinding()
                .WithThirdPartyDomain(domain)
                .WithSubDomain(subDomain)
                .WithDnsRecordType(CustomHostNameDnsRecordType.CName)
                .Attach()
                .Apply();

The API doesn't allow specifying IP or SNI and I have no idea why WithClientCertEnabled(true) is stuck there.
A better way might be:
            _webApp.Update()
                .DefineSslBinding()
                .ForHostname(domain)
                .WithExistingCertificate(thumbprint)
                .WithSniBasedSsl()
                .Attach()
                .Apply();

Thanks
Andrew

This issue was moved to Azure/azure-libraries-for-net#45


Discussion: DSL syntax

I'd like to start a bit of a discussion around the DSL syntax.
Multiple paths to one goal:
router.clear()
router.push(Route())

router {
    clear() push Route()
}

router {
    clear()
    push(Route())
}

There are several ways to perform similar actions. The first way isn't correct, as it won't bundle up the actions as a single item, but my understanding is the last two ways are essentially the same. ̛I think it would be a better idea to have a single syntax, even if it means that a single "push" needs to be performed as:
router { push() }

Builder syntax:
router {
    clear() push RouteA() push RouteB() push RouteC()
}

The builder continuation syntax that allows a user to push a series of routes like this is inconsistent with the use of infix functions, as a user is unable to split these onto different lines. The following code will not compile:
router {
    clear() push RouteA()
        push RouteB()
        push RouteC()
}

I have two questions:

Is the builder/continuation syntax actually useful? Could commands just be split onto different lines?
If the builder/continuation syntax is useful, should the use of infix be removed, so a user can split the continuation over multple lines?

Personally I think that if router { already receives a Router.() -> Unit, then the infix is not needed.

@Zhuinden I agree

I think you raised a few very interesting points here!

Multiple paths to one goal:

router.clear()
router.push(Route())

Exactly, this will work but won't bundle those instructions to a single which might break animations.

router {
    clear() push Route()
}

This will lead to the wanted behavior of bundling those two instructions to a single ✅

router {
    clear()
    push(Route())
}

This one will ignore the result of the clear() call. The Router.invoke  function expects a function of type RoutingStack<T>.() -> RoutingStack<T> and clear returns a new RoutingStack that will be ignored by the push because the push function is received by this and not the result of the clear. So we can see that the syntax leads to confusion here and is not optimal!
Let me address your questions by clarifying the underlying architecture of the router a little more:
A Router contains a  RoutingStack. This RoutingStack is nothing more than a list of routes (bundled with a unique key). Any instruction is nothing more than a function from a RoutingStack to a new RoutingStack :  RoutingStack<T>.() -> RoutingStack<T>. So you have all the freedom in routing possible. You can do anything here. All the operators like pop, push, clear, ... are just defined on an interface called PlainStackInstructionSyntax which the RoutingStack implements.
The Router  itself also implements the PlainStackInstructionSyntax, but in a way that you cannot chain instructions.
So that being said: When opening the router { } context, then chaining the commands is necessary!
Regarding the infix function: Theoretically one could use them just as normal functions, but I guess people tend not doing it then? But as from now, I think they are one of the major sources of confusion and we should rather remove them? Also we might want to make sure, that results are check inside a router instruction. Mabye @CheckResult could help us here?

router {
clear()
push(Route())
}
This one will ignore the result of the clear() call

:thinking:
That's totally not expected.

Ah yes, number 3 tricked me too!
The clarification on the architecture was useful, I was obviously misunderstanding things a little bit.
What would you think if we made route { } execute as a single stack instruction, and use it as an "instruction chain builder" as Zhuinden suggests?

What would you think if we made route { } execute as a single stack instruction, and use it as an "instruction chain builder" as Zhuinden suggests?

You mean like
router { clear().push(route1).push(route2) }

? 🤔

Or would you propose that the following syntax:
router {
    clear()
    push(route1)
    push(route2)
}

Haha I get it 👍
I even had a draft supporting this kind of syntax at the beginning. The problem with it is, that it kind of doesn't fit into the (List<Route>) -> List<Route> signature which I really think is key for having an extremely solid router foundation. This signature is flexible in a way that it can cover 100% of possible routing scenarios and it is extensible in a way that it is easy to write custom operators on it 🤔
@Zhuinden @isaac-udy What are your thoughts on this one? At least, I am sure there would be no way of building this syntax while keeping the whole thing immutable.
Maybe the underlying concept would then more look like a
MutableList<Route> -> Unit inside this router { } lambda. Which might be fine. But personally, I prefer the immutable version List<Route> -> List<Route more. Maybe there is a way of building the syntax on top of it?

You make a good point with the (List<Route>) -> List<Route> idea - this is very flexible, and very functional. I do like this as a concept. Currently the syntax used is more like List<Route>.() -> List<Route>, and I think the implicit receiver is what has caused Zhuinden and I some confusion.
I would suggest the following:
class Router {
    ...
    @CheckResult(...)
    fun pushTransaction(val transaction: (List<Route>) -> List<Route) { ... }

    operator fun invoke(val transaction: MutableList<Route>.() -> Unit) {
        pushTransaction { it ->
            return@pushTransaction mutableListOf(it).transaction().toList()
        }
    }
}

I think this is the best of both worlds - it gives the "easier" interface as the default router { ... }, but is performed through the functional interface, which is exposed if it is required. The toList call ensures that we use a MutableList in the router.invoke but doesn't expose it to modification after the call returns.

Exactly! That was also what I had in mind, but I am not quite sure about it. Maybe one of my colleagues can contribute its thoughts on this tomorrow.
I honestly think the List<Route>.() -> List<Route>/functional style has more advantages and the most confusing thing might just be the infix function. Maybe removing the infix is enough?
The problem with the CheckResult:
The Router is part of the common Kotlin API, while  CheckResult is just an Android annotation :/
Right now, I do not know something similar for Kotlin only.

Maybe removing the infix is enough?

I think this is a good idea, but I think that we should also consider changing the signature of the invoke function - currently it's RoutingStack<T>.() -> RoutingStack<T>, but I think (RoutingStack<T>) -> RoutingStack<T> would be better, as it forces the user to write it.clear().push() ...  rather than using the implicit receiver. What do you think?

That at that point there is no reason to have it passed as a lambda.

Another idea:
What about having something like:
router.clear().push(route1).commit()
Whoever wants to do custom routing with the List<Route>.() -> List<Route> can still open the lambda like  router { clear().push(route1) }?
What are your thoughts on that?

I think the simple function chaining is the easiest to understand and fulfills the basic needs when using this lib. I also see how the lambda gives you more flexibility. So why not keep both?
Having 2 ways to do the same thing can be a cause of confusion and this should be clearly stated in the docs.

I will now build two branches:

One with the infix removed
One with the syntax as

router {
    clear()
    push(route1)
    push(route2)
}

Let's decide afterwards based on both working branches!


order of request/response pairs

Is there a reason why WARCWriter will output the response before the request when using write_request_response_pair? Wouldn't it be more natural to put the request first?
Very minor nitpick.

Heretrix outputs the response before the request. I wonder how many warc tools break with the reverse ordering?

Writing them that way has been a convention for a long time. I think the reason is that the response record is considered the principal, and the request record sort of represents some extra information about it.
I don't think that wayback (openwayback, pywb, etc) care about the ordering of the records. They ignore the request records anyway afaik. Not sure about other tools.

Ah. I'd only generated warc records with wget before, which orders them as request then response. Interesting to hear that that's unusual!

That's good to know about wget, that means that the Wayback Machine already has a fair amount of warc data in that form, thanks to Archive Team.

Yeah, pywb can support either request-response or response-request order. FWIW, CommonCrawl also generates data in request-response-metadata form. The request record is not always ignored however, as it can be used to resolve POST/PUT data into an index (pywb has an option to do this).
I'm planning to add a way to better reference concurrent records for improved indexing, though likely in a separate tool for indexing

As there are no docs available on this, can someone explain how to use this request_response_pair feature?


Lock analysis rule

Given a Field/Property x and a lock object y.
If at least once lock (y) is called to access x, then the other places are missing the locks.

Could someone provide a an example in code, I'm realy visual, and I can't quite see it in my head :(

class A
{
    // Worst case, non-atomic on any kind of operation.
    long x;
    object obj = new object();

    void Inc()
    {
        lock (obj)
            x++;
    }

    void Dec()
    {
        lock (obj)
            x--;
    }

    void Add(int y)
    {
        // Signal that lock isn't being used here, since every other instance of the object had a lock on access (r/w).
        x += y;
    }
}

Perfect thanks, I'll get a new branch on my fork this week and get started with this. Except if I'm wrong, this shouldn't take long to implement ! @mkrueger  @Therzok

Rules like this are getting implemented in dotnet/roslyn-analyzers.


Encode 3x node/way/relation in vector tile feature id

Encode whether a vector tile feature comes from an OSM node, way, or relation in the feature ID according to the formula {vector tile feature id} = {osm id} * 3 + {0 for node, 1 for way, 2 for relation}. See https://github.com/onthegomap/planetiler/discussions/824 and compare to #826 which resulted in slightly larger tile sizes

closing in favor of #826


Unexpected token 'export'

Describe the bug
In next.js (Client Component) it is throwing error on Build time.
Error Message:
export { default as a11yDark } from './a11y-dark';
SyntaxError: Unexpected token 'export'
Screenshots

Desktop (please complete the following information):

OS: windows 11
Browser : Brave
Version : latest

Same thing here!

I think this package is not compatible with nextjs or react 18+ version.

@yeasin-2002 check this solution https://github.com/react-syntax-highlighter/react-syntax-highlighter/issues/230#issuecomment-568377353
Basically you need change the import style from
react-syntax-highlighter/dist/esm/...
to
react-syntax-highlighter/dist/cjs/...

@LeandroJavierLaino Thanks!  It can work!


WIP: Add's support for png decoding on linux

Hi @cpuhrsch
As discussed here, This PR add's c++ operators to decode png.
Thanks

It's still a WIP, I have some weird issues with the search paths.

Hi @cpuhrsch,
There first PR is done. The failures are due to pipelines timing out. I don't know how to fix that (already tried with and without ninja ). What could we do ?
Thanks

Hello @r-zenine,
Thanks for splitting this out!
Master is currently timing out as well, I imagine it's because our builds are starting to take too long. Could you try increasing the timeout? Especially with submodule libraries that are being built from source we're increasing the build times yet again. You could also build in parallel via the -j or --parallel flags of cmake. While Ninja causes an OOM, cmake might not.
On another note, let's make zlib a submodule as well. This way we're not increasing the number of dependencies. I thinks this is the main repository. Another comment on submodules: Since you can choose the commit it might make sense to pin it to a recent release for now, if you haven't done that already. That way we should run into less risk of a dependency bug.

Christian

Codecov Report

Merging #1881 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1881      +/-   ##
=========================================
- Coverage    0.43%   0.43%   -0.01%
=========================================
  Files          92      93       +1
  Lines        7396    7414      +18
  Branches     1113    1117       +4
=========================================
  Hits           32      32
- Misses       7356    7374      +18
  Partials        8       8

Impacted Files
Coverage Δ

torchvision/io/image.py
0% <0%> (ø)

torchvision/models/mobilenet.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2573a7...dd6aac7. Read the comment docs.

Hi, @cpuhrsch,
Hope you are doing well!
I have added zlib as a vendored dependency and pinned the versions for both libpng and zlib.
I increased the timeout for both circleci (30 minutes) and travis (1h).
There is one last pipeline that is failing. The unit test for ops in failing on windows. I tried to rebase from master in the hope of getting a fix for that with no success.
Have a good day!
Let me know if there is anything else left to do!

That Windows build is a mystery to me. Paging Dr. Windows @peterjc123 to take a look if he has some time.

Well, the test failures are not related to this PR.

Ok, let's wait for the next nightly and try again.

Hi @cpuhrsch ,
Do you have the credentials to re-run the pipeline ?

Hi @cpuhrsch,
Please do not merge this PR. While working on the jpeg one. I figured out that even tough this approach works for now, it is not stricly what we wanted.
Here is what is happening:
We are building the extension code code against vendored versions of libpng and zlib. However, the code is running against the system wide dynamic libraries. It works because libpng and zlib and ubiquitous in linux systems.
As in torch, we would need to ship the .so in package using data_files or package_data arguments in the setup function. My struggle now is that when I do this, the code fails because the dynamic library is not found.
There is an option runtime_library_dir the might help. But there is little documentation about it.
Do you happen to know how it's done in pytorch ?
Thanks

Hi @cpuhrsch ,
I have pushed a version with libpng and zlib linked dynamically and shipped with the package.
The windows pipeline is failing without any useful error message. I will try to investigate further.
What do you think of the approach ? Do we still try to link everything statically?
have a good day !

Hello @r-zenine,
Yes, ideally we link everything statically. Shipping dynamic libraries can be a nightmare and in particular building against a library that has dynamic dependencies can lead to lots of conflicts. If we can build something statically it's always preferred and if it seems possible we should try until it works.
Thanks,
Christian

hi @cpuhrsch ,
It works ! We are linking everything statically !
Thanks for pushing hard for this !
The only thing that remains is the windows error that has nothing to do with the PR !
Have a good day

Hi @cpuhrsch ,
What are the next steps ? Anything else i have to do ?
Have a good day !

Great! Thanks again for your work! I'll take a closer look at the Windows build and also a few other things related to this PR setup. This might take a few days / week.

Hi @cpuhrsch ,
Let me work on MacOs support on the same PR. I'll try to push that on thursday. I will let you handle the windows pipeline and will get back to work on the png support.
Thanks a lot for the help !

Hi @cpuhrsch ,
I just added macos support in the build. Tests for image are passing everywhere but other pipelines are failing because of other tests. It's probably due to something that happened with pytorch nightly.
Have a good day !!

Hi @cpuhrsch ,
I think the conda pipelines are failing because of a linking issue. There is a weird warning in the build :
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: /lib64/libm.so.6
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: /lib64/libc.so.6
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: $RPATH/libtorch_python.so
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: /lib64/ld-linux-x86-64.so.2
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: /lib64/libpthread.so.0
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): Needed DSO lib/libgcc_s.so.1 found in [u'libgcc-ng']
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): .. but [u'libgcc-ng'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: $RPATH/libpng16.so.16
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: $RPATH/libtorch_cpu.so
   INFO (torchvision,lib/python3.5/site-packages/torchvision/_C.so): Needed DSO lib/libcudart.so.10.0 found in defaults::cudatoolkit-10.0.130-0
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: $RPATH/libc10_cuda.so
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): Needed DSO lib/libstdc++.so.6 found in [u'libstdcxx-ng']
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): .. but [u'libstdcxx-ng'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: $RPATH/libtorch.so
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: $RPATH/libtorch_cuda.so
WARNING (torchvision,lib/python3.5/site-packages/torchvision/_C.so): did not find - or even know where to look for: $RPATH/libc10.so
WARNING (torchvision): dso library package defaults::python-3.5.6-hc3d631a_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)

Do you have any idea where it is coming from ? Do we have that on master, or is it specific to this PR ?
Thanks

Hello @r-zenine,
We'll need to wait on @fmassa for some insight here. He's currently working on a hi-pri deadline so this will take a bit longer than expected.
Is this working locally for you? You could also try installing this within a docker container (if your environment allows you to set that up) to get local feedback on the linking behavior etc.
In particular, if you take a look at the CI jobs you can see that they pull in the "pytorch/conda-cuda" container. This could be worthwhile looking into so you can get a faster turnaround time on experiments.
Thanks,
Christian

Hi @fmassa , @cpuhrsch
Here is a status of what's going on, I tried to statically link the libraries (it works with wheel not conda and I could not figure out a fix with conda despite dedicating many hours to it). I also tried dynamically linking against libpng and shipping the library with the package ( like what pytorch does for it's dependencies). It's seems to be working on most pipeline. There is a bug with the linking in macos conda that I still need to figure out.
If we go that way, it might make updating the windows pipelines easier.
Thoughts ?

@r-zenine, thanks for your contribution, we've migrated your commits to https://github.com/pytorch/vision/pull/2301, so we will close this one


Tutorial 3: prevalence curve

Dear Alex,
In tutorial 3, the log file just shows prevalence at the time of the last observation. Is it possible to show prevalence curve over time like birthRate?
Many thanks in advance!
Cheers,
Ruopeng

Hi Ruopeng,
The current method does not have a way to estimate the prevalence through time. There are a couple of approaches that could work, but they all require non-trivial changes to the package.
If you are in a rush for any estimate, you could generate a rough estimate of the prevalence at time T by only using the data from before then, and then do this for a couple of different times.
I hope the tutorials have been helpful, please let me know if you have any feedback/suggestions.
Cheers,
Alex

Thanks Alex!

Hey @xieruopeng
Just wanted to let you know that historical prevalence estimation is now implemented on the dev branch so will hopefully appear in v.0.3.0. It appears to work on a simple example (included in examples/ex4.xml) but BEAUti support is pretty rubbish and there isn't any proper documentation on it yet, so it might be a while.
Cheers,
Alex

There is now a pre-release with this implemented so I'll close the issue :)


use workspace:* and update pnpm

Actually, perhaps we will need this... Because it's now broken with pnpm 9


Recording clips

This allows support for loading a new clip that can then be recorded to.
In addition, this also fixes a bug with the way the commands are sent to the device that was incorrect. Long names would fail to load, which results in Companion losing the device connection since the device stop responding after receiving a bad formed command.

This is tested?

Yes, I wrote it last year and then retested it last week and works with the Ki Pros we have.


Coverage GUI: Illegal Bins reduce total coverage percentage of the coverpoints and instances

I created an illegal bin, to throw an exception when reaching an illegal state in a state machine. In the simulation this works fine and i will get 100% coverage, but when I look at the coverage report in the HTML GUI, it will not add up to 100% because the illegal bin has no hit count. This seems not to be a correct behavior.

Hello karrenb,
You are correct, the behavior for illegal_bins was backwards in the GUI. Now illegal_bins with 0 hits will be displayed in light green and won't drop the percentage anymore. The ones with hits will be red and lower your percentage.
Fixed in the latest commit.
Thanks for reporting this!


add tags=["manual"] to image_tag rules

without this change image_stamp_tag is built by default, even when stamping is not enabled and it cannot find the stable-status.txt file

@wwieclaw I was testing this and I've also added the manual tag to the image transition. Otherwise you get a surprise x86_64/aarch64 build when using //...

@wwieclaw we should probably have also considered just passing through **kwargs so that users can decide whether to add the manual tag...


setting @mobileGutter to any other value than 1 rem issue in Chrome mobile

Hi all, whenever I change @mobileGutter in container.variables to any other value than its default value 1rem  to, like for example (0.5rem or 10px), I find that the width of the window becomes slightly larger than its fit in google chrome in my phone in all my app pages (i.e. you can drag the window to the right/left slightly); this issue does not happen in firefox mobile or even whenever I try to resize the browser in my PC, (tried on latest versions of chrome & firefox).

Hi, please provide a test case as per our contributing guidelines; you can fork this JSFiddle. Also, what Chrome for Android version is that?

This actually seems like enough to go on seeing as this involves less.


Type request module

Summary of Changes
Replace this text with a high-level summary of the changes included in this PR.
Related Issues
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
Pull Request Checklist
This is just a reminder about the most common mistakes.  Please make sure that you tick all appropriate boxes.  But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

[ ] Applied changes to both WSGI and ASGI code paths and interfaces (where applicable).
[ ] Added tests for changed code.
[ ] Prefixed code comments with GitHub nick and an appropriate prefix.
[ ] Coding style is consistent with the rest of the framework.
[ ] Updated documentation for changed code.

[ ] Added docstrings for any new classes, functions, or modules.
[ ] Updated docstrings for any modifications to existing code.
[ ] Updated both WSGI and ASGI docs (where applicable).
[ ] Added references to new classes, functions, or modules to the relevant RST file under docs/.
[ ] Updated all relevant supporting documentation files under docs/.
[ ] A copyright notice is included at the top of any new modules (using your own name or the name of your organization).
[ ] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.

[ ] Changes (and possible deprecations) have towncrier news fragments under docs/_newsfragments/, with the file name format {issue_number}.{fragment_type}.rst. (Run towncrier --draft to ensure it renders correctly.)

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template inspired by the attrs project.

Uh, i've been also working on this and was about to publish a PR...
Thanks for the effort, I'll try meeting the two efforts

Uh, i've been also working on this and was about to publish a PR...
Thanks for the effort, I'll try meeting the two efforts

Uh, oh. I didn't know. What modules can i go next, so that we don't have conflicts?

I've incorporated your commit into #2271


Websocket support

Many textractor based tools have moved from clipboard polling to using a websocket. This method is more reliable and doesn't change your current text when you copy something else.
It may also be faster though I have not tested.
Server examples:

https://github.com/sadolit/textractor-websocket
https://github.com/KamWithK/TextractorSender

Client examples:

https://github.com/KamWithK/exSTATic
https://github.com/Renji-XD/texthooker-ui

Would it be possible to consume text from a websocket server?

Implemented in https://github.com/rampaa/JL/commit/1493fce8a49c12078bb471573b92cc5ae1937bf9, will be included in the next release.

:ikneel:


Model uniqueness isn't honored in custom Form

Need to revamp the validation to make sure the unique_together constraint of our OrderItem Model is met on a page that doesn't have access to that information.

We probably should do something in the formset clean hook to manually check.


[Fix #4910] added example to space inside block braces

Added an example documentation to space_inside_block_braces.rb cop.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests(rake spec) are passing.
[x] The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@yieldjessyield: Just a few reminders of good commit messages:
Use the imperative mood in the subject line, and also Capitalize the subject message.

It seems someone already wrote the missing documentation for this cop. We ran into a classic race condition :-(
@yieldjessyield Thanks for your contribution and I'm sorry we can't merge it. Excellent work! (P.S. There are plenty more undocumented cops)