Feedback incorporated

All screenshots should be updated, along with several feedback items provided by reviewers. outstanding items in progress denoted by "todo" notes

Docs Build status updates of commit db63220:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/mrlearning-base-ch2.md
:warning:Warning
View
Details

mixed-reality-docs/mrlearning-base-ch3.md
:warning:Warning
View
Details

mixed-reality-docs/mrlearning-base-ch4.md
:warning:Warning
View
Details

mixed-reality-docs/mrlearning-base-ch5.md
:warning:Warning
View
Details

mixed-reality-docs/images/Lesson1Chapter2Step3b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson1Chapter3Step1.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1a.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step5.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_Chapter1_step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_chapter4_step1-2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-1step3bim.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7ima.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imbb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step3imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch1.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch6.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch2.md

Line 196: [Warning] Invalid file link:(~/melearning-base-ch3).

mixed-reality-docs/mrlearning-base-ch3.md

Line 75: [Warning] Invalid file link:(~/mrlearning-base-ch4).

mixed-reality-docs/mrlearning-base-ch4.md

Line 218: [Warning] Invalid file link:(~/mrlearning-base-ch5).

mixed-reality-docs/mrlearning-base-ch5.md

Line 199: [Warning] Invalid file link:(~/mrlearning-base-ch6).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 1507853:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/images/Lesson1Chapter2Step3b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson1Chapter3Step1.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1a.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step5.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_Chapter1_step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_chapter4_step1-2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-1step3bim.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7ima.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imbb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step3imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch1.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch3.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch5.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch6.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 346dce5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/images/Lesson1Chapter2Step3b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson1Chapter3Step1.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1a.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step5.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_Chapter1_step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_chapter4_step1-2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-1step3bim.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7ima.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imbb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step3imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch1.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch3.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch5.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch6.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 909e287:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/images/Lesson1Chapter2Step3.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson1Chapter2Step3b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson1Chapter3Step1.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1a.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step5.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_Chapter1_step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_chapter4_step1-2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-1step3bim.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7ima.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imbb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step3imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch1.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch3.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch5.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch6.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit a814955:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/images/Lesson1Chapter2Step3.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson1Chapter2Step3b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson1Chapter3Step1.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1a.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step5.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_Chapter1_step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_chapter4_step1-2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-1step3bim.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-1step3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7ima.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imbb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step3imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch1.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch3.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch5.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch6.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit b67dbfc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/images/Lesson1Chapter2Step3.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson1Chapter2Step3b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson1Chapter3Step1.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1a.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step1b.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson2_Chapter4_Step5.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_Chapter1_step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson4_chapter4_step1-2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson5_chapter1_step6im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson5_chapter1_step7im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson5_chapter1_step8.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/Lesson5_chapter2_step8im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-1step3bim.JPG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-1step3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step3im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7ima.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-2step7imbb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step1im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step2im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step3imb.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/images/mrlearning-base-ch2-3step4im.PNG
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch1.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch3.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch4.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch5.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-base-ch6.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


chore: Remove EOL issue version and add prepare one

due to we release the last version of 2.0.x and 3.0.x, we do not accept bug report for them now.
Add new version 3.2.0-prepare for testing the incoming verison 3.2.0-prepare

Codecov Report

Merging #14270 (1d055d8) into dev (b8748e2) will increase coverage by 0.02%.
The diff coverage is 55.97%.

:exclamation: Current head 1d055d8 differs from pull request most recent head 50a7874. Consider uploading reports for the commit 50a7874 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14270      +/-   ##
============================================
+ Coverage     38.39%   38.42%   +0.02%
- Complexity     4478     4496      +18
============================================
  Files          1229     1235       +6
  Lines         42936    42914      -22
  Branches       4763     4745      -18
============================================
+ Hits          16485    16489       +4
+ Misses        24625    24598      -27
- Partials       1826     1827       +1

Impacted Files
Coverage Δ

...che/dolphinscheduler/api/python/PythonGateway.java
16.94% <0.00%> (ø)

...er/api/service/impl/MetricsCleanUpServiceImpl.java
12.50% <0.00%> (-1.79%)
:arrow_down:

...api/service/impl/ProcessDefinitionServiceImpl.java
35.31% <0.00%> (-0.04%)
:arrow_down:

...cheduler/common/constants/DataSourceConstants.java
0.00% <ø> (ø)

...in/datasource/vertica/VerticaDataSourceClient.java
0.00% <0.00%> (ø)

.../server/master/runner/StateWheelExecuteThread.java
0.51% <ø> (+0.10%)
:arrow_up:

.../server/master/runner/WorkflowExecuteRunnable.java
10.39% <ø> (+0.07%)
:arrow_up:

.../org/apache/dolphinscheduler/spi/enums/DbType.java
0.00% <0.00%> (ø)

...ler/server/worker/metrics/WorkerServerMetrics.java
0.00% <0.00%> (ø)

...eduler/server/worker/runner/WorkerExecService.java
0.00% <0.00%> (ø)

... and 13 more

... and 58 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


add field syntax to common field in sealed trait

Related to #735
Use case:
sealed trait Order

case class Draft(orderId: String, basket: List[Item]) extends Order
case class Submitted(orderId: String, basket: NonEmptyList[Item], submittedAt: Instant)  extends Order
case class Delivered(orderId: String, basket: NonEmptyList[Item], submittedAt: Instant, deliveredAt: Instant) extends Order

val root: Iso[Order, Order] = Iso.id

root.field(_.orderId) : Lens[Order, OrderId] // all constructors of Order have it
root.field(_.submittedAt): Optional[Order, Instant] // some constructors of Order have it
root.field(_.basket) // probably does not compile because it has different types

@cb372 do you think it is feasible in scala2 / dotty?


igluctl: add static gccp command

To push to Google Cloud Storage.

Not sure if/when we need this, we are leaping straight to Scala schema registry for GCP...
/cc @jbeemster

Makes sense.

Migrated to https://github.com/snowplow-incubator/igluctl/issues/16


Some spelling and grammar changes

Thanks for the correction.

hey, no worries! You have done a great job. Made our life simpler.


RabbitMQ no longer releases Mac binaries since Sep. 2019

From https://www.rabbitmq.com/install-standalone-mac.html:

Standalone MacOS Build
Overview
RabbitMQ releases used to include a special binary package for macOS that bundled a supported version of Erlang/OTP. As of September 2019, this package has been discontinued. It will no longer be produced for new RabbitMQ releases.
macOS users should use the Homebrew formula or the generic binary build (requires a supported version of Erlang to be installed separately) to provision RabbitMQ.

This means Embedded-RabbitMQ library needs to account for this change in behavior when trying to download mac-specific binaries that will never be published.
The solution is to re-use the generic linux binary build only for releases starting Sep. 2019

Fixed and released with v1.3.1


Zapret doesn't work on the laptop

Thank you for your great work!
On 5 of my devices (2 computers and 3 laptops) all works without problems, now I bought a new laptop (a little outdated laptop bought it for work) and on it Zapret does not work at all, no solution methods do not help I do not know what to do and I write here with a call for help, maybe someone can help me
~
MSI GT73VR Titan PRO - laptop model
I7 - 7820HK
32Gb RAM
GTX 1080
~
all of the bat files work, but I can't connect to blocked sites/programs (discord, YT and others)
Windows 10 22H2 actual windows version for me
maybe someone can tell me what I need to do with my laptop to get the program to work, thanks in advance
With respect for your work, Zenith!

I don't know what this is related to, but none of the versions works with my laptop, it feels like the problem is in the laptop, maybe you need to change the registry or something else.


Fixed EC2 module (added http_endpoint = enabled)

EC2 module was broken because http_endpoint is set to '' by default instead of a valid setting, despite being an optional argument. Should now work as I've tested locally.

Related:

https://github.com/hashicorp/terraform-provider-aws/issues/12564
https://github.com/hashicorp/terraform-provider-aws/pull/30520

LGTM 🚀


Refresh UI

This is an enhancement request, not a bug. I hope this is the right place for my suggestion.
Currently, in the Mac client, the refresh button is at the top left, but the progress bar is at the bottom left. I sometimes hit the refresh button and don't notice the progress bar. If no new articles are displayed, I'm not sure if I just missed the refresh button.
Maybe make the refresh button animate while content is refreshing to make it visually apparent that it activated.
Thanks for your consideration.

The refresh button is disabled when refresh is happening and provides visual confirmation.


Update Sync Interface

This is a WIP but opening it up for some input and reviews.
Goals of this PR:

to simplify the SyncManager interface and make it easier to test
add support for testing multiple remote DWNs

This PR prepares the pull/push queues before calling sync, this will allow to test out different strategies for enqueuing syncs, and currently allows pull/push to be called async after enqueuing.
I have some ideas of changes to make to the DWN SDK/DWN Server to make sync more efficient, but will work through those in a separate PR.
Additionally, I am creating some chaos-monkey type scripts that will live in a separate repo. This will allow us to also compare syncing performance with different scenarios.
**** NOTES
I think we should enforce a minimum sync, however for certain tests this minimum should be low. I've added logic for the testing environments, but locally you currently have to pass a specific ENV variable for tests to pass. This is just temporary.
Looking for input on how best to handle this, or just remove the minimum interval from the code completely.

Talked to @LiranCohen about this PR yesterday and he's going to review and determine whether it should be closed or taken out of Draft state for review.

@LiranCohen said he'll re-open later once ready for review


ImportError: cannot import name 'VariableSampler' from 'models.base.base_sampler'

When I run "sh egs/tts/VITS/run.sh --stage 2 --name ljs_base"
I had an issue with the following:
"""
Traceback (most recent call last):
File "/home/zhangy33/data1/lz/tts/Amphion/bins/tts/train.py", line 13, in
from models.tts.naturalspeech2.ns2_trainer import NS2Trainer
File "/home/zhangy33/data1/lz/tts/Amphion/models/tts/naturalspeech2/ns2_trainer.py", line 16, in
from models.base.base_sampler import VariableSampler
ImportError: cannot import name 'VariableSampler' from 'models.base.base_sampler'
"""
I didn't find the "VariableSampler" when I checked the "models.base.base_sampler.py".
Can you help me with this problem?

@HeCheng0625  Please follow up on this issue, in which VariableSampler  used in ns2_trainer.py is not imported correctly.

Hi @Abel1802, we have already fixed the bug and merged the code, if you have any further question about it, feel free to reopen this issue.


DBZ-2480 Initial commit of outbox event router SMT doc updated for 1.2

This is for DBZ-2480.
I revised the doc for the outbox event router SMT. The downstream Technology Preview note is conditionalized to show downstream.  Comments contain annotations that allow the downstream fetch script to split this file into the modular files required downstream.
Let me know what needs to change.
When this is merged, please backport this to 1.2.
Thanks!

@Naros Just want to note that referring to outbox.EventRouter is consistent with referring to ByLogicalTableRouter and ExtractNewRecordState. I included the outbox part because EventRouter seemed to general.
I'm happy to do whatever you all want. But I hope we can use a consistent convent to refer to the SMTs by name.

@TovaCohen I discussed this with @gunnarmorling and we both agree that it makes more sense from a docs perspective that unless we're referring to a place where you configure the actual outbox event router class name in the configuration, it would be better to have references of outbox.EventRouter changed simply to outbox event router.  I understand the desire for consistency with the other router docs, but I now wonder if we shouldn't have the others conform to this style instead?

Why do you think outbox event router is better than outbox.EventRouter?  And just to be clear and make sure we are talking about the same thing - both those instances are in fixed-width, monospace, font.  Where is outbox event router a literal that should be in fixed-width?
I'm not trying to be difficult, but I can do a better job with the doc in the first place when I understand why things should be a certain way.

Where is outbox event router a literal that should be in fixed-width?

What I meant was rather than using the fixed-width, monospace font it should read "outbox event router" in normal font of the paragraph for which its contained.

Oh, got it.  Normal font. I'll make those changes now.

@gunnarmorling @Naros  Here is a link to the downstream user guide, outbox router section:
https://access.redhat.com/documentation/en-us/red_hat_integration/2020-q3/html-single/debezium_user_guide/index?lb_target=stage#outbox-event-router
You must be logged in to the customer portal for the link to work.

Applied to master & branch 1.2.  Thanks @TovaCohen!


Mining Software

Since we're losers and like to use Python, how we're doing this whole thing won't use Allium like C does so it will more than likely not be compatible with current miners which means we'll have to write our own. Hopefully the community will help out with this after launch.
Will support:
CUDA probably 8.0+
OpenCL probably 1.1
CPU better have a ton of xeons homie

We are using Allium, its simply not implemented right now in a way that is compatible with current miners. I will look into trying to implement it so that we can use the current miners, but we might have to write our own. Hopefully it doesn't come to that.

"Hopefully it doesn't come to that." 👍 with that one. Might want to bring in community help on this one

Settled on using a different hashing algorithm (likely blake2s)


Reject requests that updates immutable fields

Is there a related GitHub Issue?

#1086
What is this change about?

See issue
Does this PR introduce a breaking change?

No
Acceptance Steps

See issue
Tag your pair, your PM, and/or team

@Birdrock
Things to remember

Made some updates to the error messaging. It now takes a constant template and formats it with a field name.


[Bug Report] Wrong week translations for hr locale

Element UI version
2.15.2
OS/Browsers version
Mac OS / Chrome
Vue version
2.6.12
Reproduction Link
https://github.com/ElemeFE/element/blob/2842399eb7190c2dc9400ad940c9225d81ef82d5/src/locale/lang/hr.js#L38-L44
Steps to reproduce
With language set to hr(croatian) open a datepicker. The weekdays are offset by one day. The typo in the translations is clearly visible: https://github.com/ElemeFE/element/blob/2842399eb7190c2dc9400ad940c9225d81ef82d5/src/locale/lang/hr.js#L38-L44
What is Expected?
The weekdays should be in this order(firstDayOfWeek set to 1):
Pon Uto Sri Čet Pet Sub Ned
What is actually happening?
They are like this:
Uto Sri Čet Pet Sub Ned Pon

firstDayOfWeek set to 7 (of course,you don't need set ,7 is default ) will make Sunday at first .In China ,1 mean Monday :-)

firstDayOfWeek set to 7 (of course,you don't need set ,7 is default ) will make Sunday at first .In China ,1 mean Monday :-)

The issue has nothing to do with the firstDayOfWeek setting. The translations are in wrong order: https://github.com/ElemeFE/element/blob/2842399eb7190c2dc9400ad940c9225d81ef82d5/src/locale/lang/hr.js#L38-L44
"Mon" in croatian(hr) should be "Pon", "Tue" -> "Uto",... and so on...
Every one that speaks any slavic language can confirm this.


2.0 release notes don't indicate breaking changes

Modifier.draggableHandle and Modifier.longPressDraggableHandle are moved from ReorderableItemScope to ReorderableCollectionItemScope.

Thank you! I have edited the release notes


fix: add 'With' methods to HttpServerConfiguration

Issue
https://gravitee.atlassian.net/browse/APIM-1381
Description
HttpServerConfiguration builder implementation was only relying on Environment so set default values.
Add lombok's @With to be able to set fields after builds with an immutable object.

Gravitee.io Automatic Deployment
🚀 A prerelease version of this package has been published on Gravitee's private artifactory, you can:

use it directly by updating your project with version: 1.25.4-apim-1381-debugmode-secured-3-19-SNAPSHOT
download it from Artifactory here

:tada: This PR is included in version 1.25.4 :tada:
The release is available on:

1.25.4
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.27.8 :tada:
The release is available on:

1.27.8
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.7 :tada:
The release is available on:

2.0.7
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.6 :tada:
The release is available on:

3.0.6
GitHub release

Your semantic-release bot :package::rocket:


Unable to run the SlideShow sample: Unhandled exception

Unable to cast object of type 'Windows.UI.Composition.ContainerVisual' to type 'Windows.UI.Composition.IVisual'.

Sorry about the delay in answering your issue, we had a few problems getting pings back from our GitHub when issues were posted.
This error can occur when a project is not targeting the latest build and SDK in VS2015. Make sure you're on build 10586 and under Project>Properties you're targeting SDK for 10856. We have also noticed that sometimes VS and the SDK get in a bad state and VS and the SDK both need to be reinstalled.
Once again sorry about the delay.


Update authenticate_with_magic_auth to use the email instead of user_id parameter

Description
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b83b201) 97.13% compared to head (da352d8) 97.13%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   97.13%   97.13%
=======================================
  Files          52       52
  Lines        1220     1220
=======================================
  Hits         1185     1185
  Misses         35       35

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add qlc-wiki project for rpc

Description of the issue
the documentation of rpc
Issue-Type

[ ] bug report
[ ] feature request
[x] Documentation improvement

close via c2a093a2bfbcc809bcf069f21609a358f12eed69


Docs should pin GKE configs to a particular release

The GKE getting started guide have several links to scripts/config files to be used
https://github.com/kubeflow/website/blob/master/content/docs/started/getting-started-gke.md
This links currently point at HEAD. But as part of a release we should update the links to point to the revision corresponding to the release.

I think this is fixed by a number of changes.

#88 automatically links scripts to the branch matching the docs branch
In 0.3.0 with kfctl.sh we run the scripts directly from the directory containing the source code so everything should be at the same version.


Hide Aspire internal/automatic env vars

Aspire sets a lot of env vars on a .NET project resource when it starts up. These include, ASP.NET Core env vars for the URL, environment and launch profile. Logging env vars for printing to the console. Service discovery env vars with connection strings and HTTP client addresses. And OTEL env vars to configure .NET OTEL SDK:

Because these env vars are set on the resource by Aspire, they're always visible. I think the vast majority of the time people don't care about these env vars. They create noise and make it harder to find important data in resource details. The exception is probably service discovery env vars.
We should consider hiding internally set env vars so they're only visible when show all is selected.

cc @davidfowl @DamianEdwards

I don't think we should hide anything. These are what a resource sets, and it's one of the only ways to look at the env at runtime. Developers use these to debug what is being injected into the application.

Another problem is sections below the env vars are hidden at the bottom. Health checks for example.
If env vars aren’t changed then they should be last.

I don't have a problem with sorting sections but we shouldn't hide any information.

I don't have a problem with sorting sections but we shouldn't hide any information.

It's not hidden forever. The user can click on show all to see all env vars set on a resource.
Look at it from a users point of view: they didn't set PATH env var on the resource, so it doesn't show up. Makes sense. But they also didn't set OTEL_EXPORTER_OTLP_ENDPOINT either, Aspire did that so telemetry is sent to the dashboard, yet OTEL_EXPORTER_OTLP_ENDPOINT is visible in the list of env vars for some reason.
I think we should only show env vars that a user action - such as adding a reference which that populates service discovery env var. The ASP.NET Core env vars for setting app endpoint URLs probably falls into this category.
"System" env vars like OTEL, console logging would be removed from the default view. They could still be viewed by clicking "Show all" icon.

I think there's very little value in hiding information from the user. We already hide the system environment variables because it's too much noise, we shouldn't hide environment variables because the user didn't explicit add them and they came from the resource definition. IMO the value of this issue is low.

The problem is env vars are still almost all noise. Look at what you see for myfrontend:

50%+ of the data in resource details is env vars that no one cares about.
Compare that with a container that doesn't automatically have a bunch of "system" env vars set on it:

There is no need to spot the important env vars amoungst the OTEL and console log noise, because they're not visible. .NET project resources would be much nicer to view if they showed actually important information like a container does.
0% of people care about what OTEL_BLRP_SCHEDULE_DELAY is. I think I can say that as the person who cares about those env vars most with OTEL + dashboard dev work. Like all these "system" vars, they're always the same value.
This seems like a low effort change to drastically simplify and reduce .NET project resource details view to information people care about.

50%+ of the data in resource details is env vars that no one cares about.

That's a judgement, one I don't agree with. I don't know why you are calling it noise. It's literally what the resource implementation sets. Let's say I am trying to figure out why something isn't working. I go looking at env and I see nothing because we decided that information isn't important.
When you look at the env in docker inspect (in the UI) it's not being filtered.

When you look at the env in docker inspect (in the UI) it's not being filtered.

Aren't all those coming from the docker file? Docker itself isn't setting env vars and then showing them here.

Probably? I ran the rabbitmq image, which has a docker file that I don't own (much like resources set env variables that the user didn't explicitly set).

We're already hiding env vars. Someone could already be confused that the env var set on their machine isn't showing up here.

I know and I think hiding system env variables is a good thing (that's actual noise). I don't like the idea of hiding anything else nor trying to determine what is a "user" set env vs a "library set env" based on some fuzzy logic that we start setting on our env variables.

I'm not proposing doing this for all env vars for libraries. It would just be done for the env vars that are automatically added to a .NET project resource.  If they're present we simply don't show them by default.

Oh so you just want to special case a few env vars for .NET projects specifically?

I agree that system variables should be hidden as they are there before aspire, and will be there if I dotnet run my app.  However if Aspire adds any environment variables that could cause my app to behave differently when run through aspire vs dotnet run, I want aspire to tell me.
If your app already has jaeger & prometheus exporters set up, the OLTP_* variables will change how your app behaves (hopefully for the better in local dev).  But it's still a change so I want aspire to tell tell me what it's doing differently.

From developer perspective it would be great If I could see only variables that I have to provide when deploying application. I'm not there yet but I believe that some of OLTP_* I have to provide to make OpenTelemetry working (eg endpoint).


Adding myself to contributor's page

Thanks for the PR, home.html is missing. Could you take a look?

Done. Sorry I forgot to add it earlier.


bat: 0.6.0 -> 0.6.1

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: bat
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r5scqmf4iflsnidb6sdvd6zsbi4px0mq-bat-0.6.1
shrinking /nix/store/r5scqmf4iflsnidb6sdvd6zsbi4px0mq-bat-0.6.1/bin/bat
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r5scqmf4iflsnidb6sdvd6zsbi4px0mq-bat-0.6.1/bin
patching script interpreter paths in /nix/store/r5scqmf4iflsnidb6sdvd6zsbi4px0mq-bat-0.6.1
checking for references to /build in /nix/store/r5scqmf4iflsnidb6sdvd6zsbi4px0mq-bat-0.6.1...
/nix/store/r5scqmf4iflsnidb6sdvd6zsbi4px0mq-bat-0.6.1

Success on x86_64-linux (full log)
Attempted: bat
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xl26qxlnsncckqjsdcybdwr9sl85fa73-bat-0.6.1
shrinking /nix/store/xl26qxlnsncckqjsdcybdwr9sl85fa73-bat-0.6.1/bin/bat
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xl26qxlnsncckqjsdcybdwr9sl85fa73-bat-0.6.1/bin
patching script interpreter paths in /nix/store/xl26qxlnsncckqjsdcybdwr9sl85fa73-bat-0.6.1
checking for references to /build in /nix/store/xl26qxlnsncckqjsdcybdwr9sl85fa73-bat-0.6.1...
/nix/store/xl26qxlnsncckqjsdcybdwr9sl85fa73-bat-0.6.1


Core cleanup

AtomicWaker and ContextExt are now in futures_util::task and ContextExt is now actually reexported in futures
Macros are now in futures_util::macros
ReadyFuture is now called Ready an in futures_util::future
FutureOption is now called OptionFuture an in futures_util::future with a code example
futures_util top-level exports are now also hidden in the docs

Works for me!


[WIP] Allow user to add a todo item

todo (for a todo app 😄 ):

[x] write tests
[x] have a okayish UI
[ ] add CI?

closed in favor of https://github.com/nilenso/do.it/pull/5 which starts the project from scratch instead of copying of bunch of boiler plate code.


A single task can launch many times if running multiple times while window is loading

I had a particularly slow start up just now and I hit ctrl+shift+b a bunch of times, once everything settled it launched 3x for each task:

Version: 1.55.0-insider (user setup)
Commit: 04770364fdc1bebeca9d1a257df2cacce06b35d6
Date: 2021-03-05T15:40:03.281Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

This is going to require a lot of refactoring to solve. Will try to tackle next debt week.

Found a simple way to solve it.

If I try to repro now the default build task no longer works, ctrl+shift+b only shows this now:

I had reverted the fix since it broke something else. Will try another fix.

Re-applied the fix and fixed the test that it revealed a bug in.

@alexr00 the issue I hit is still happening in:
Version: 1.56.0-insider (user setup)
Commit: 633562da380f9161ea2fd783e561eed508cfbbea
Date: 2021-04-26T05:14:38.204Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042
Repro:

Reload vscode repo
ctrl+shift+b quickly

/duplicate #159640


test mappings TL calibration hierarchy reversals

can't figure out why it's failing
I have written a test, I want the test to pass. This is the only test that is failing:
test_mappings_calibration_hierarchy_reversal_SemioBrainBeta within the Class TestDummyDataHierarchyReversal

there was a typo and a mistake in calling MEGA_ANALYSIS


feat: #2339 - added language and country to query product list keys

What

added language and country to query product list keys
that means that if I run a query for "pizza", not only the results will be different depending on the language and country (that was already the case), but the results will be cached accordingly - if I change language or country, I will see the cached results for those new language/country, not the results of the same query but with different language/country
we needed that improvement in order to display correctly the "world" results; that was the first step
also moved all the "query" classes to a specific folder
fun fact: there are more "pizza"s in France than in Italy

Impacted files:

abstract_onboarding_data.dart: minor refactoring
barcode_product_query.dart: moved; minor refactoring
category_product_query.dart: moved; added language and country to product list key
continuous_scan_model.dart: minor refactoring
country_selector.dart: minor refactoring
database_product_list_supplier.dart: minor refactoring
keywords_product_query.dart: moved; added language and country to product list key
main.dart: minor refactoring
new_product_page.dart: minor refactoring
nutrition_page_loaded.dart: minor refactoring
ocr_helper.dart: minor refactoring
onboarding_data_product.dart: minor refactoring
ordered_nutrients_cache.dart: minor refactoring
paged_product_query.dart: moved; added language and country to product list key; refactored around getProducts
paged_search_product_query.dart: moved; refactored
paged_to_be_completed_product_query.dart: moved; added language and country to product list key; refactored
paged_user_product_query.dart: moved; added language to product list key; refactored
picture_capture_helper.dart: minor refactoring
product_dialog_helper.dart: minor refactoring
product_list.dart: added optional language and country to constructor parameters
product_list_import_export.dart: minor refactoring
product_list_page.dart: minor refactoring
product_list_supplier.dart: minor refactoring
product_query.dart: moved; not an interface anymore
product_query_model.dart: minor refactoring
product_query_page_helper.dart: minor refactoring
product_refresher.dart: minor refactoring
query_product_list_supplier.dart: minor refactoring
robotoff_insight_helper.dart: minor refactoring
robotoff_questions_query.dart: moved; minor refactoring
search_page.dart: minor refactoring
simple_input_page_helpers.dart: minor refactoring
summary_card.dart: minor refactoring
user_preferences_account.dart: minor refactoring
user_preferences_dev_mode.dart: minor refactoring

Part of

https://github.com/openfoodfacts/smooth-app/issues/2339

Codecov Report

Merging #2465 (029b3e0) into develop (2ea0da3) will decrease coverage by 1.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2465      +/-   ##
==========================================
- Coverage     8.86%   7.49%   -1.38%
==========================================
  Files          161     205      +44
  Lines         6623    9825    +3202
==========================================
+ Hits           587     736     +149
- Misses        6036    9089    +3053

Impacted Files
Coverage Δ

...kages/smooth_app/lib/widgets/attribute_button.dart
0.00% <0.00%> (-92.00%)
:arrow_down:

...s/smooth_app/lib/data_models/user_preferences.dart
8.73% <0.00%> (-23.57%)
:arrow_down:

packages/smooth_app/lib/themes/smooth_theme.dart
60.00% <0.00%> (-22.98%)
:arrow_down:

...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart
15.29% <0.00%> (-18.92%)
:arrow_down:

...mooth_app/lib/data_models/product_preferences.dart
24.65% <0.00%> (-6.78%)
:arrow_down:

packages/smooth_app/lib/main.dart
14.40% <0.00%> (-3.49%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/welcome_page.dart
0.00% <0.00%> (-3.13%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/scan_example.dart
0.00% <0.00%> (-2.28%)
:arrow_down:

...p/lib/pages/onboarding/consent_analytics_page.dart
0.00% <0.00%> (-1.57%)
:arrow_down:

...smooth_app/lib/pages/product/new_product_page.dart
0.00% <0.00%> (-0.88%)
:arrow_down:

... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28ad14...029b3e0. Read the comment docs.

Thank you @M123-dev for your review!
As you're mentioning @AshAman999 it makes me think about the offline database, and I've just noticed that the primary key of a Product is the barcode but without the language. Therefore, we can't have a product in different languages: just one Product for one barcode, the latest downloaded versions wins. Should we have a version for each language? I don't know.

@Ashaman999 is the right one to ask but as the ultimate goal is to be able to allow multiple different datasets for countries that's probably a good idea + a a own field for language to be able to explicitly get data for a single data set.
"German"
"500.000 Products"
"300mb:
Similar to Google Maps but don't take my word for granted let's wait for @ashaman999 s answer

Though I am not an expert here dealing with db's, but i am thinking of making multiple tables according to the desired country and language.
So the current table name is String TABLE_PRODUCT = 'product';
What i am thinking here is to do something like this for a table name String TABLE_PRODUCT = 'product_$language_$country';
In this process i could seperate the products for different coutries and language according to the need here.
Thoughts @monsieurtanuki @M123-dev ,
Would be great to hear yours answer on this  as well

It's not a good idea. The correct way to do that is by adding a language and a country column. Another way would be to create "partitions", but I don't think SQLite supports them.
I don't think you can even do that with dynamic languages and countries in sqflite, given that each table change means a new database version. If you knew from the start that we need tables product_en_us, product_fr_fr and product_it_it, that would be thinkable. But that's not the case.
Maintenance would be hard because you would have to do all your table changes to all product tables.
I don't believe we need that for the moment.
Given that SQL is not something you're very comfortable with, I would suggest to go step by step and first develop something that works. And then make it evolve with the needs. If you try to make everything at the same time you add confusion in your code - not good for you, not good for the reviewers.
That was definitely a good idea to ask ;)

De : Aman Raj @.>
Envoyé : lundi 4 juillet 2022 08:08
À : openfoodfacts/smooth-app @.>
Cc : monsieurtanuki @.>; Mention @.>
Objet : Re: [openfoodfacts/smooth-app] feat: #2339 - added language and country to query product list keys (PR #2465)
Though I am not an expert here dealing with db's, but i am thinking of making multiple tables according to the desired country and language.
So the current table name is String TABLE_PRODUCT = 'product';
What i am thinking here is to do something like this for a table name String TABLE_PRODUCT = 'product_$language_$country';
In this process i could seperate the products for different coutries and language according to the need here.
Thoughts @monsieurtanukihttps://github.com/monsieurtanuki @M123-devhttps://github.com/M123-dev ,
Would be great to hear yours answer on this as well
—
Reply to this email directly, view it on GitHubhttps://github.com/openfoodfacts/smooth-app/pull/2465#issuecomment-1173389256, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACYKI34TXFXHMVGQNYKMA7TVSJ5V5ANCNFSM52MSB7XQ.
You are receiving this because you were mentioned.Message ID: @.***>


Increase output length by one frame

This fixes a particularly nasty bug which shows itself only with the right value of ratio and after processing a signal that is long enough.
Output array length was too small, because the value of self.ratio() * input.len() is trimmed when casted to usize. As the output array was a single frame too short, SRC_STATE stored the additional frame in it's internal buffer. The buffer is finite and when it overflows there is no error, the converter simply drops all samples in the buffer.

I am sorry for taking so long.

Please change it back. Calling the channels isn't expensive

Done.

Thanks for your support and your patience.


braintree.api.Client should be its own module.

I am disappointed in the implementation of this lib. The size, number of dom bindings and only offering a minimized/uglified version is IMO insulting.  There should be a way to extract the client module?
Braintree is for developers?
Help me keep my applications lean.

Thank you for the feedback, @arenoir.
Could you tell us a little more about your integration and usage of Braintree's APIs? Are you using our v.zero integrations?
Are you including braintree via a <script> tag, AMD, or CommonJS?
We currently do not provide unminified files through npm or bower, but you can link against our hosted assets that are unminified. See https://github.com/braintree/braintree-web/issues/1#issuecomment-75969617 for specifics.
Also, are you primarily developing for desktop or mobile web?

@mrak thanks for the response.  I am using the v.zero script in a ember.js application.
Currently I am lazily loading the v.zero script when transitioning to a route using the following method.
I don't like loading external scripts.  I am planning on transpiling the v.zero modules I am using tokenizeCard into my application.
I have a version of my application for desktop and mobile web.  Credit cards are only entered on the desktop.

Since you are loading braintree on-demand in a single-page applications, take care not to call braintree.setup() more than once (it sounds like you are not calling it at all).
braintree.api.Client at this time needs some of the other machinery offered by other parts of braintree.js, so you may see some issues if you manage to extract it out and transpile it into your code.
The use of a lower-level, leaner library for integrating braintree is often requested, so we'll keep this issue open to track it.

As of right now there are no plans to release the braintree-api library as a separate module. Given the recent changes with regards to PCI, in order for a merchant to be eligible for SAQ-A compliance, sensitive cardholder data cannot be collected from the merchant's page.
From our Hosted Fields documentation:

For a merchant to be eligible for the easiest level of PCI compliance—SAQ A—payment fields cannot be hosted on your checkout page. All payment fields (credit card number, CVV, and expiration date) must be hosted on an external payment gateway's domain and presented to the user in a frame or with a redirect.

For this reason, we encourage the use of Hosted Fields or Drop-in when using a braintree.js integration.
You are still welcome to use a braintree.api.Client to tokenize cards, but that functionality will remain bundled with braintree.js.


Normalize network in docker-compose.yaml

Most demonstrations will use an existing docker-network.   To allow individual docker-compose.yaml files to work together,  the common format is:
networks:
  senzing:
    external: true
    name: ${SENZING_DOCKER_NETWORK:-senzing-network}

References:

https://docs.docker.com/compose/compose-file/#external
https://docs.docker.com/compose/compose-file/#name

Pull requests:

https://github.com/Senzing/docker-python-demo/pull/86


TypeError: entry_points() missing 1 required positional argument: 'name'

A clear and concise description of what the bug is.
Expected results
able to run superset db upgrade
what you expected to happen.
Actual results
cpchung:incubator-superset$ superset db upgrade
Traceback (most recent call last):
  File "/home/cpchung/anaconda3/bin/superset", line 18, in <module>
    from superset.cli import superset
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/superset/__init__.py", line 21, in <module>
    from superset.app import create_app
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/superset/app.py", line 29, in <module>
    from superset.extensions import (
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/superset/extensions.py", line 118, in <module>
    celery_app = celery.Celery()
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/celery/local.py", line 509, in __getattr__
    module = __import__(self._object_origins[name], None, None, [name])
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/celery/app/__init__.py", line 5, in <module>
    from celery import _state
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/celery/_state.py", line 17, in <module>
    from celery.utils.threads import LocalStack
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/celery/utils/__init__.py", line 19, in <module>
    from .nodenames import nodename, nodesplit, worker_direct
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/celery/utils/nodenames.py", line 9, in <module>
    from kombu.entity import Exchange, Queue
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/kombu/entity.py", line 9, in <module>
    from .serialization import prepare_accept_content
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/kombu/serialization.py", line 456, in <module>
    for ep, args in entrypoints('kombu.serializers'):  # pragma: no cover
  File "/home/cpchung/anaconda3/lib/python3.6/site-packages/kombu/utils/compat.py", line 93, in entrypoints
    for ep in importlib_metadata.entry_points().get(namespace, [])
TypeError: entry_points() missing 1 required positional argument: 'name'

what actually happens.
Environment
cpchung:incubator-superset$ uname -a
Linux cpchung 5.4.0-29-generic #33-Ubuntu SMP Wed Apr 29 14:32:27 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

(please complete the following information):
cpchung:incubator-superset$ npm -v
6.14.5
cpchung:incubator-superset$ python --version
Python 3.6.8 :: Anaconda, Inc.
cpchung:incubator-superset$ node -v
v10.16.0

superset version: superset version
python version: python --version
node.js version: node -v
npm version: npm -v

similar.

Looks like dependencies might have gotten out of sync after you upgraded.
Try pip install -r requirements/base.txt


Multi domain operator delegation

This is likely an enhancement. When I have multiple domains , I would like to delegate the operator setup to different person for each domain.
is it in the roadmap?

I'm not entirely sure I understand your proposal in its entirety yet. Would you like to offer some self-service way of creating Offen instances for random users, or what exactly is your use case? Why would you need to run instance setup multiple times?

Let us say I am hosting 3 Domains, on behalf of 3 customers
DomainA,
DomainB,
DomainC
I would like to use 1 instance of the Often, but give access to different operator for each domain, such that they don't see each others data.
With my email in Often.env to help with password resets etc..
Basically, multi tenant!

Creating users with a limited number of accounts visible to them is already supported. The only caveat being you as the admin of an instance would still have access to these accounts. As a workaround such a user could however create another account which would not be visible to you anymore.
If this is unwanted in your scenario, I'd probably recommend deploying a single instance per tenant. I've had a similar setup for a while and it worked quite well.

If I understand correctly,often."somedomain".com/setup - create pr

Yes, this is how it could work.


How to pass request throw the nginx?

I have such config:

http {
  server {
      listen 80;

      location / {
          access_log off;
          proxy_pass http://localhost:8080;
          proxy_set_header X-Real-IP $remote_addr;
          proxy_set_header Host $host;
          proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;

          proxy_read_timeout 86400s;
          proxy_send_timeout 86400s;

          proxy_http_version 1.1;
          proxy_set_header Upgrade $http_upgrade;
          proxy_set_header Connection "upgrade";
      }
  }
}

I use docker with server port 8180. I use main example from this repo for creating websocket server.

<?php
use Ratchet\MessageComponentInterface;
use Ratchet\ConnectionInterface;

// Make sure composer dependencies have been installed
require __DIR__ . './../../vendor/autoload.php';

/**
 * chat.php
 * Send any incoming messages to all connected clients (except sender)
 */
class MyChat implements MessageComponentInterface {
    protected $clients;

    public function __construct() {
        $this->clients = new \SplObjectStorage;
    }

    public function onOpen(ConnectionInterface $conn) {
        $this->clients->attach($conn);
    }

    public function onMessage(ConnectionInterface $from, $msg) {
        foreach ($this->clients as $client) {
            if ($from != $client) {
                $client->send($msg);
            }
        }
    }

    public function onClose(ConnectionInterface $conn) {
        $this->clients->detach($conn);
    }

    public function onError(ConnectionInterface $conn, \Exception $e) {
        $conn->close();
    }
}

// Run the server application through the WebSocket protocol on port 8080
$app = new Ratchet\App('localhost', 8080);
$app->route('/chat', new MyChat, array('*'));
$app->route('/', new MyChat, array('*'));
$app->route('/echo', new Ratchet\Server\EchoServer, array('*'));
$app->run();

And it works into container on port 8080
But if I  call websocket outside of the container I get issue:
error: Unexpected server response: 502

I use this;
location /chat/ {
  proxy_set_header Upgrade $http_upgrade;
  proxy_set_header Connection "upgrade";
proxy_pass http://<IP_ADDRESS>:8093;
proxy_http_version 1.1;

}
Just modify it to make it meet your needs.


Set "imagePullPolicy: Never" for sandbox env

When running flyte locally in sandbox environment, it is useful to be able to iterate on docker images quickly, build and run them in the workflows. Currently the yaml spec sets the pod's image policy to imagePullPolicy: IfNotPresent which would try to pull image from the actual docker registry and fail. In some orgs like ours the credentials to publish docker images to the private registry are not even available meaning the only way to test and iterate locally is to go via CI/CD pipeline with the publish step. This is extremely inefficient way to test workflows in local environment.
What i would like to be able to do is to set the imagePullPolicy: Never to force the local k8s instance to fall back to local images.

@apryiomka doesnt, IfNotPresent imply that if you have an image locally it will not try to pull it from remote? Are you suggesting to use Never as a failure mechanism, so that if the image is not built locally, it fails instantaneously?
Moreover, do you think this is a platform level override or a per task registration parameter?
Example: In an override, we could just enforce that for a deployment of flyte it will always use imagepullpolicy: <set by platform override>, if no override is provided then it uses the default
Thank you for opening this issue, it is wonderful to have more users try it out and help us isolate issues

On thinking more closely, imagepullpolicy never will imply that no new images will be downloaded. I do not think that is the right solution. IfNotPresent should accomplish what you really want - use local images if present. Now important caveat, that the image should be tagged correctly.
I am going to close the issue, please open it with some additional information, if you think this is till the right approach.


Installation dont work

Got the following after executing the script
Hit:1 http://raspbian.raspberrypi.org/raspbian stretch InRelease
Hit:2 http://ppa.launchpad.net/webupd8team/java/ubuntu trusty InRelease
0% [Connecting to archive.raspberrypi.org (2a00:1098:0:82:1000:13:0:6)]
Does not continue after this. Trying to install on a rasperry pi

What package is it trying to download? Try to confirm that your raspberry pi can access this package. It might be that your internet provider, home network, or your Pi is somehow blocking that request.

This is not a problem with the script, looks like a connectivity problem with the repository.
Solutions:

Switch to a different mirror
Is your IPv6 connectivity working correctly? If not, disable it.


Add DB migration

What is this PR for?
We will plan to change DB schema.
For this, we need to add a DB migration functionality.
This PR includes

Add requirements of Flask-Migrate
Add migration runner (manage.py)

What type of PR is it?
Feature
What is the issue?
N/A
How should this be tested?
$ sh ./app/start.sh

I changed that upgrade will be executed if we set upgrade argument.


Hello, when can I publicly disclose the complete code?

Hello,
I’m happy to let you know that the implementation of LCAT is now available. We will be adding more results in the following weeks.
Thanks for your patience and support!


Updating Learn TV Code of Conduct for Learn rebrand

Docs Build status updates of commit 727f479:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 0a78ecf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

DocsLegal/GDPR.md
:white_check_mark:Succeeded
View

DocsLegal/index.md
:white_check_mark:Succeeded
View

DocsLegal/learnevents/codeofconduct.md
:white_check_mark:Succeeded
View

DocsLegal/termsofuse.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


wip: bump docker images versioning

@douglaz we can close this, this was back when I was debugging the gateway not connecting to thunderhub / voltage . Will open a new one when we cut the 0.2 release.

Ping we got a 0.2.0 release :tada:


LLVM Error

Getting this error
'''
A Recurrent Neural Network (LSTM) implementation example using TensorFlow library.
This example is using the MNIST database of handwritten digits (http://yann.lecun.com/exdb/mnist/)
Long Short Term Memory paper: http://deeplearning.cs.cmu.edu/pdfs/Hochreiter97_lstm.pdf
Author: Aymeric Damien
Project: https://github.com/aymericdamien/TensorFlow-Examples/
'''

from __future__ import print_function

import tensorflow as tf
from tensorflow.python.ops import rnn, rnn_cell

# Import MNIST data
from tensorflow.examples.tutorials.mnist import input_data
mnist = input_data.read_data_sets("/tmp/data/", one_hot=True)

'''
To classify images using a recurrent neural network, we consider every image
row as a sequence of pixels. Because MNIST image shape is 28*28px, we will then
handle 28 sequences of 28 steps for every sample.
'''

# Parameters
learning_rate = 0.001
training_iters = 100000
batch_size = 128
display_step = 10

# Network Parameters
n_input = 28 # MNIST data input (img shape: 28*28)
n_steps = 28 # timesteps
n_hidden = 128 # hidden layer num of features
n_classes = 10 # MNIST total classes (0-9 digits)

with tf.device('/gpu:0'):
    # tf Graph input
    x = tf.placeholder("float", [None, n_steps, n_input])
    y = tf.placeholder("float", [None, n_classes])

    # Define weights
    weights = {
        'out': tf.Variable(tf.random_normal([n_hidden, n_classes]))
    }
    biases = {
        'out': tf.Variable(tf.random_normal([n_classes]))
    }

    def RNN(x, weights, biases):

        # Prepare data shape to match `rnn` function requirements
        # Current data input shape: (batch_size, n_steps, n_input)
        # Required shape: 'n_steps' tensors list of shape (batch_size, n_input)

        # Permuting batch_size and n_steps
        x = tf.transpose(x, [1, 0, 2])
        # Reshaping to (n_steps*batch_size, n_input)
        x = tf.reshape(x, [-1, n_input])
        # Split to get a list of 'n_steps' tensors of shape (batch_size, n_input)
        x = tf.split(0, n_steps, x)

        # Define a lstm cell with tensorflow
        lstm_cell = rnn_cell.BasicLSTMCell(n_hidden, forget_bias=1.0)

        # Get lstm cell output
        outputs, states = rnn.rnn(lstm_cell, x, dtype=tf.float32)

        # Linear activation, using rnn inner loop last output
        return tf.matmul(outputs[-1], weights['out']) + biases['out']

    pred = RNN(x, weights, biases)

    # Define loss and optimizer
    cost = tf.reduce_mean(tf.nn.softmax_cross_entropy_with_logits(pred, y))
    optimizer = tf.train.AdamOptimizer(learning_rate=learning_rate).minimize(cost)

    # Evaluate model
    correct_pred = tf.equal(tf.argmax(pred,1), tf.argmax(y,1))
    accuracy = tf.reduce_mean(tf.cast(correct_pred, tf.float32))

    # Initializing the variables
    init = tf.initialize_all_variables()

    # Launch the graph
    with tf.Session() as sess:
        sess.run(init)
        step = 1
        # Keep training until reach max iterations
        while step * batch_size < training_iters:
            batch_x, batch_y = mnist.train.next_batch(batch_size)
            # Reshape data to get 28 seq of 28 elements
            batch_x = batch_x.reshape((batch_size, n_steps, n_input))
            # Run optimization op (backprop)
            sess.run(optimizer, feed_dict={x: batch_x, y: batch_y})
            if step % display_step == 0:
                # Calculate batch accuracy
                acc = sess.run(accuracy, feed_dict={x: batch_x, y: batch_y})
                # Calculate batch loss
                loss = sess.run(cost, feed_dict={x: batch_x, y: batch_y})
                print("Iter " + str(step*batch_size) + ", Minibatch Loss= " + \
                      "{:.6f}".format(loss) + ", Training Accuracy= " + \
                      "{:.5f}".format(acc))
            step += 1
        print("Optimization Finished!")

        # Calculate accuracy for 128 mnist test images
        test_len = 128
        test_data = mnist.test.images[:test_len].reshape((-1, n_steps, n_input))
        test_label = mnist.test.labels[:test_len]
        print("Testing Accuracy:", \
            sess.run(accuracy, feed_dict={x: test_data, y: test_label}))

: CommandLine Error: Option 'help-list' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options

I'm getting the same problem.
It happens when I try to stance a tensorflow's Session.

import tensorflow as tf
sess = tf.Session()

Then I get the same error.


Test the merge step

Tickets #162 and #164 do a pretty good job of testing reports, translate steps, and partially testing send step.
This ticket is to write something that tests merge

Create 3 small fake data files in the simple report schema.  Find and save the primary keys from each file.
Call merging (I'm assuming there's a programmatic way to do this directly in Kotlin.  If not, will need to write it.
Merge and assert that all the primary keys in the original 3 data files are in the merged file.

I think there's no need to write out the merged file (?)

Note:  as part of this, I added a --merge option to the CLI.  Its getting a bit messy.
@Mr0grog , rick tells me you might do some cleanup in main.kt?      My tweaks are in jim/fixes2 branch at the moment, not merged in yet.

Note:  as part of this, I added a --merge option to the CLI.  Its getting a bit messy.
@Mr0grog , rick tells me you might do some cleanup in main.kt?      My tweaks are in jim/fixes2 branch at the moment, not merged in yet.

Its getting a bit messy.

👍 I had a similar thought! I’m taking a look at splitting it up into separate commands (process data, list schemas, generate docs) to clarify that these are mutually exclusive operations and make it a little easier to see what options apply where. Maybe I can add a little more explanation to the help text while doing so. Hoping this might help me grok the structure of things a little more, too.

Its getting a bit messy.

👍 I had a similar thought! I’m taking a look at splitting it up into separate commands (process data, list schemas, generate docs) to clarify that these are mutually exclusive operations and make it a little easier to see what options apply where. Maybe I can add a little more explanation to the help text while doing so. Hoping this might help me grok the structure of things a little more, too.

Its getting a bit messy.

👍 I had a similar thought! I’m taking a look at splitting it up into separate commands (process data, list schemas, generate docs) to clarify that these are mutually exclusive operations and make it a little easier to see what options apply where. Maybe I can add a little more explanation to the help text while doing so. Hoping this might help me grok the structure of things a little more, too.

That would be awesome!   prime is ready to grow up to become a real cli.  ;)
Note that Mo (@mauricereeves ) also has some incoming additions to the cli, adding an ability to do fancy comparisons of two csv files.  They are in a PR at the moment.

Its getting a bit messy.

👍 I had a similar thought! I’m taking a look at splitting it up into separate commands (process data, list schemas, generate docs) to clarify that these are mutually exclusive operations and make it a little easier to see what options apply where. Maybe I can add a little more explanation to the help text while doing so. Hoping this might help me grok the structure of things a little more, too.

That would be awesome!   prime is ready to grow up to become a real cli.  ;)
Note that Mo (@mauricereeves ) also has some incoming additions to the cli, adding an ability to do fancy comparisons of two csv files.  They are in a PR at the moment.

I think this would be a good first issue. Putting back into the backlog.

I think this would be a good first issue. Putting back into the backlog.


Update slack community links in README and docs/index.md files

Closing this PR since the slack links are in the latest format.


Remove previous implementation of LRU cache in favour of MemoryCache

Replace LRUCache with new MemoryCache
Remove external dependency to com.nytimes.android:cache
Clean up NormalizedCache from inheritance hell

How much of a burden would it be to keep the guava cache as a separate artifact? That could be useful if we want to do benchmarks at some point.

Sure I was thinking if we want to keep it, I guess the only reason is to keep it for benchmarking.
I will revert removing old LRUCache so we can benchmark it later, but keep MemoryCache as default one.


Schematics generate service outside of state folder

I'm submitting a...

[ x ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
When generating a new feature with the akita schematics like this:
ng g @datorama/akita:feature test
it generates the following files:
CREATE src/app/state/test.store.ts (375 bytes)
CREATE src/app/state/test.query.ts (307 bytes)
CREATE src/app/test.service.ts (133 bytes)
CREATE src/app/state/test.model.ts (203 bytes)
Expected behavior
I expected the store, query and service to all be generated inside the state folder.
Minimal reproduction of the problem with instructions
Run ng g @datorama/akita:feature test.
What is the motivation / use case for changing the behavior?
The documentation recommends structuring projects like this:

todos

state

todos.query.ts
todos.store.ts
todos.service.ts

todos.module.ts
todos-page.component.ts
todo

todo.component.ts
todo.component.html
todo.component.scss
todo.component.spec.ts

Environment

Angular version: 8.2.8

For Tooling issues:
- Node version: 10.13.0
- Platform:  Windows

This is a regression, thanks.

I have edited the report to be a regression.

I used Default.


cups-browsed option to rename DNSSD printers before adding them

CUPS shares DNSSD printers with the following format:
PrinterName @ HostName
I need to add those printers without the @ HostName like if I where using the deprecated CUPS sharing mechanism.
I reported the reverse of this here https://github.com/apple/cups/issues/5543.
I think it would be good to have that flexibility in both to adapt better to any user needs.
Thanks!!!

cups-browsed can be configured to do so.
Edit /etc/cups/cups-browsed.conf to have the lines
LocalQueueNamingRemoteCUPS RemoteName
AutoClustering Yes

and restart cups-browsed. Then your remote CUPS queues should be handled as they were before, with CUPS browsing.

CUPS protocol is deprecated isn't it?
So, what is needed is a way to accomplish the same thing but with DNS-SD.
I think this issue has been closed by mistake...
Thanks!!!

The configuration settings apply also to DNS-SD-advertised print queues, not only to the deprecated CUPS protocol.

Oh! Now I see! It works indeed without using the CUPS protocol! Nice!
I don't know how, but the comments and manpage should be changed a bit to make this more clear.
Thanks a lot!!!


Login to registry1 before trying to build packages that have IB conta…

…iners

/test all

/test all


tooltip destroy does not work

Destroy does not work. Disable does.
You can look at this fiddle: http://jsfiddle.net/ecw3rk1s/3/

Since you're using delegation (i.e. the selector option), I believe there's only one actual tooltip instance (on the body). Thus, trying to destroy nonexistent tooltip instances on the trigger elements themselves has no effect.
Compare the non-delegated version: http://jsfiddle.net/zsb9h3g5/1/

Hi @cvrebert!
You appear to have posted a live example (http://fiddle.jshell.net/zsb9h3g5/1/show/light/), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 45, column 104: Element link is missing required attribute property.
line 46, column 6: An body start tag seen but an element of the same type was already open.
line 54, column 7: Saw an end tag after body had been closed.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Thank you for your answer. I learned something new!

To document this, the documents currently say, "Hides and destroys an element's tooltip." followed by the code example $('#element').tooltip('destroy'). Do you believe it would be clear to instead have:
.tooltip('destroy')
Hides and destroys an element's tooltip. Destroy should not be used when delegating to a target element using the selector option. When calling destroy, it will attempt to remove the nonexistent tooltip instance from the trigger element.
$('#element').tooltip('destroy')

Thoughts?

How about:

Hides and destroys an element's tooltip. Tooltips that use delegation (which are created using the selector option) cannot be individually destroyed on descendant trigger elements.

?

I think that works well.

Fixed by #15742.


Scrollers out of container

How can I set position of scrollbars out of the container.
I know there is problem do it, bc. scroller container need to be with position relative.
But pls help me with this situation, bc. i dont want overlaped content by srollers.
Thx.

Duplicated with #507


[GIE POM] Unify GIE version by the global flag 'revision'

Build a GIE target with a unified version by running mvn clean package -Drevision=<XXX>, default  is https://github.com/shirly121/GraphScope/blob/ir_unify_version/interactive_engine/pom.xml#L71
What do these changes do?

Related issue number

Fixes #2164

Codecov Report

Merging #2243 (d019001) into main (1c4c1cd) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2243      +/-   ##
==========================================
+ Coverage   40.17%   40.19%   +0.02%
==========================================
  Files          87       87
  Lines        9847     9847
==========================================
+ Hits         3956     3958       +2
+ Misses       5891     5889       -2

Impacted Files
Coverage Δ

python/graphscope/deploy/kubernetes/utils.py
70.47% <0.00%> (+0.95%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4c1cd...d019001. Read the comment docs.


testadd upgrade and downgrade compatibility test case

Proposed changes
testadd upgrade and downgrade compatibility test case

run buildall

run buildall

new pr: https://github.com/apache/doris/pull/46162


avoid calling load from service manager during bean creation

If the load() method is called in afterPropertiesSet() of the service manager, it may fire events that end up modifying a service and saving it with a call to servicesManager.save() (e.g. OidcProfileScopeToAttributesFilter) and that will fail b/c the servicesManager bean is in the process of being created. The services should be loaded by the serviceRegistryInitializer bean which also calls serviceManager.load().

This is what error looks like on startup if load() is called and OidcProfileScopeToAttributesFilter ends up calling servicesManager.save.
2019-05-03 18:17:17,674 WARN [org.apereo.cas.web.CasWebApplicationContext] - <Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'scopedTarget.servicesManager' defined in class path resource [org/apereo/cas/config/CasCoreServicesConfiguration.class]: Invocation of init method failed; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'scopedTarget.servicesManager': Requested bean is currently in creation: Is there an unresolvable circular reference?>
2019-05-03 18:17:17,887 ERROR [org.springframework.boot.diagnostics.LoggingFailureAnalysisReporter] - <

***************************
APPLICATION FAILED TO START
***************************

Description:

The dependencies of some of the beans in the application context form a cycle:

???????
|  scopedTarget.servicesManager defined in class path resource [org/apereo/cas/config/CasCoreServicesConfiguration.class]
???????

>

This problem was hard to track down because there was no stack trace logged pointing to where the error occurred. The way I found the class where the exception occurred was by doing a git bisect and finding the commit where the error started (somewhere between RC3-SNAPSHOT I had working and RC3). I set a breakpoint in the main classes modified by that commit and step through line by line to see where the error occurred. In retrospect I should have turned on "debug" logging for the org.springframework.boot.diagnostics.LoggingFailureAnalysisReporter logger and it would have logged the stack trace. I think that should be on by default in log4j2.xml.


Feature request: Auto-populate specific FAQ at end of tutorials

I have an FAQ on using the single cell instance (and, tbh, tutorial mode) I'd like to appear at the beginning of ALL single cell tutorials
Ditto an FAQ on joining the single cell user community to appear at the end of ALL single cell tutorials
Can I put this somewhere rather than copy and paste this FAQ into every individual tutorial?

We currently only really have the ability to insert content at the end of the tutorial, and the true beginning of the tutorial (just under metadata box), not e.g. after the introduction paragraph(s) where it might be a tad more relevant. If that's what you want, we could implement that.

Yeah I can be down with that, that would still be super helpful
It's also cool how you can embed the FAQ with different formatting, so like I might do this with the 'more details' clickable sometimes, so this feature would be great

Did i misread this? did you silently edit it somehow without triggering the 'edit' notification?  I could've sworn it said at the beginning :sweat_smile:
yeah end is too easy

OK coming back to this - at the beginning would be ideal. I now have 3 tips I put on everything, and it would be ideal to put that FIRST instead, after the metadata header. Yes please!

Yeah sorry -
End of all single-cell tutorials

Single cell user community (https://training.galaxyproject.org/training-material/topics/single-cell/tutorials/scrna-case_basic-pipeline/tutorial.html#tip-how-can-i-talk-with-other-users)

Answer key histories (It would be nice to automate some sort of box that uses the Answer Key history metadata a la:

`Want to check your answers? Or did you get stuck, and need to figure out where it went wrong?
Import our {% icon galaxy-history-answer %}  history'
Prior to getting data but after the Introduction
Example here: https://training.galaxyproject.org/training-material/topics/single-cell/tutorials/scrna-case_alevin/tutorial.html#important-tips-for-easier-analysis
Important tips for easier analysis

Using tutorial mode FAQ
Using Single cell subdomain FAQ
Troubleshooting FAQ

Following up!
Yes, automating just under the header for all single-cell tutorials the following FAQs:

https://training.galaxyproject.org/training-material/faqs/galaxy/tutorial_mode.html
https://training.galaxyproject.org/training-material/topics/single-cell/faqs/single_cell_omics.html
https://training.galaxyproject.org/training-material/faqs/galaxy/analysis_troubleshooting.html
The FAQ I just submitted about using answer key histories, although ideally only if the answer key metadata is filled out (i.e. there is one)

And at the end

https://training.galaxyproject.org/training-material/topics/single-cell/tutorials/scrna-case_basic-pipeline/tutorial.html#tip-how-can-i-talk-with-other-users

95% of issues with users relate to the top two Tips I've put there, so that's why I think it's worth the real estate


links to vizor chat slack link without http:// come out silly

e.g. type in vizor.io in slack and vizor.io|vizor.io comes out on the other side, see screenshot below

Seems like we disabled the chat a while back, so closing this ticket.


Connecting to a Read-Only PostgreSQL databases causes prepared statement missing error

I need to connect to a read-only PostgreSQL replication. when running queries this error occurs:
ConnectorError(ConnectorError {
   user_facing_error: None, kind: QueryError(Error {
   kind: Db, cause: Some(DbError {
    severity: "ERROR",
     parsed_severity: Some(Error),
     code: SqlState(E26000),
     message: "prepared statement \"s15\" does not exist",
     detail: None,
     hint: None,
     position: None,
     where_: None,
     schema: None,
     table: None,
     column: None,
     datatype: None,
     constraint: None,
     file: Some("prepare.c"),
     line: Some(506),
     routine: Some("FetchPreparedStatement")
   })
  })
})

Is it related to creating prepared statements?
How can I disable this behavior?

It was the pgBouncer problem. Adding pgbouncer=true to the connection string solved it.
https://www.prisma.io/docs/guides/performance-and-optimization/connection-management/configure-pg-bouncer


Improve documentation of Value-Only

Is your feature request related to a problem? Please describe.
The existing rules are hard to understand. Many readers requested a more easy to understand documentation of the Value-Only serialialiation.
Additionally, Examples shall be updated to not come from Submodel but provide Value-only for every element since the API (IDTA-01002) allows $value calls not only for submodels.
see also
https://github.com/admin-shell-io/aas-specs-api/issues/270
https://github.com/admin-shell-io/aas-specs-api/issues/269
https://github.com/admin-shell-io/aas-specs-api/issues/268

@mjacoby listed the remaining remaining problems in
https://github.com/admin-shell-io/aas-specs/pull/403#pullrequestreview-1996355586

[x] (1) 2^53-1 is again missing the 5

[x] (2) JSON schema again contains validation for Operations which are defined not to have a valueOnly serialization

[ ] (3) Range is again limited to number

[ ] (4) There are no rules defined how to serialize elements other than Submodel, i.e. serialization of all other types is only given by a single example. This means serialization is seriously underdefined and unclear.

[ ] (5) The section about limitation of numbers in JSON to 2^53-1 is still lacking any substantial reasoning. There is no such limitation in JSON itself, only in the implementations in different programming languages - and they might even be different to each other. So why this limitation?

[ ] (6) Handling of non-existent values is not addressed at all, i.e. what is the valueOnly Serialization of a property that has no value? What about SubmodelElementCollection without elements or Submodel without any elements?

[ ] (7) Missing serialization rules for auxiliary classes (i.e. classes that are not subclass of SubmodelElement but still part of the serialization) like Reference

[ ] (8) Rules for serialization in section Rules for Value-Only Serialization are inconsistent/overlapping, e.g.,
The definition of SubmodelElementCollection says

SubmodelElementCollection is serialized as named JSON object with ${SubmodelElementCollection/idShort} as the name of the containing JSON property. The elements contained within the struct are serialized according to their respective type with ${SubmodelElement/idShort} as the name of the containing JSON property.

while the definition of Property says

Property is serialized as ${Property/idShort}: ${Property/value} where ${Property/value} is the JSON serialization of the respective property’s value in accordance with the data type to value mapping (see table after this section).

If you apply these rules recursively like required by another rule, you end up with something containing the idShort of the property twice.

For (3) I create a new issue: https://github.com/admin-shell-io/aas-specs/issues/407 since I am not convinced to allow "all types" makes any sense for Range.

https://github.com/admin-shell-io/aas-specs/pull/403 covers (1) and (2) + adding examples and a table similar to metadata fields table
https://github.com/admin-shell-io/aas-specs/pull/408 covers (4), (8) and (9)


Change the way command parameters work

At the moment every command that has fixed parameters just has hardcoded string compare.
This should be changes as to allow for aliases for parameters.
Implementing such methods requieres commands to create and delete those aliases

closed because duplicate of #246


"binds" relationship not shown for protein binding IPI

on cyr1
| IPI                   with                                  gpa2
-- | --

(paper has not been through canto yet, maybe that is the issue?)

(paper has not been through canto yet, maybe that is the issue?)

If it's not in an approved session it won't show up yet.

I think Antonia means that it is  data in Artemis. This should show?
@Antonialock  can you confirm?
Actually did we ever implement the "binds" display yet? I can't remember but I thought we had.

yeah binds display is implemented.
The annotation is showing (the binds extension is showing for other genes),
this paper has not been through canto so I guess it is a legacy one from artemis.

but "binds" should still display for data in Artemis?

which is why I opened a ticket :-)

Could you explain this to me in smaller words?  I'm not following.
What data is in the contig files and where is it not displaying?

cyr1 gene page only shows "protein binding" no extension in collapsed view

full view:

in contrast gpa2 gene page shows the binding extension in summary view

Thanks!  Sorry for being slow.  Got it now.  I forgot we change IPI+with to binds() extensions.
The code was relying on the order that annotation properties were stored in Chado.  Sometimes it was failing to get the evidence code before checking for "with".
It's fixed now.


Import of visualisations not working nor itself nor with dashboard

Create any visualisation
Export it to zip file
Remove previously created visualisation
Try to import visualization from zip file - it will write that all work well, but visualization not occured in visualization list!
Same with dashbord export import - dashbords and datasets are restored, but visualizations - not!

Same issue

Same issue here!

Environment

Google Chrome 95.0.4638.69
master branch at  commit e60083b45b8953220e54c67544ce2381d7c96f2e
docker-compose -f docker-compose-non-dev.yml up -d
the only change in docker-compose file - switch postgres:10 to postgres:14 while it is in volume already after dev start
all other staff (python, node) comes from containers defined in docker-compose

Not reproduced, think it was fixed some commits before

@jacobcroope We are still experiencing the issue.
browser type and version: 103.0.5060.114
superset version: 2.0.0 (using docker image apache/superset:2.0.0)
any feature flags active: VERSIONE_EXPORT=True (by default in 2.0.0)
If we export a dashboard, and then delete the dashboard, charts, and dataset. If we then import the dashboard, the import completes successfully but all the charts are broken with the following error:

Notes: Dashboard filters, titles, and texts are correct.

@stefanocascavilla Weird, I can't reproduce this on either of my installs or browsers. We regularly develop new charts and dashboards on our development system before exporting them to production which is what caught my interest in this error. I am guessing it has something to do with your particular configuration and I don't have a better idea than to maybe look at the logs on import to see what is erroring out.
I do know that 1.3,1.5,2.0 all seem to be working for me on this behavior so maybe its time for a clean install?

We were able to find the issue.
If we delete the broken charts, the correct ones appear (they were hidden on the right side of the dashboard pane).

We were able to find the issue. If we delete the broken charts, the correct ones appear (they were hidden on the right side of the dashboard pane).

To add a bit of context, this happens only with dashboards that were created with a Superset version < 2.0, in our case it was Superset 1.5.0

Facing same issue for
browser type and version: Google Chorme Version 105.0.5195.125 (Official Build) (64-bit)
superset version: 2.0.0
python version: Python 3.9.0
node.js version: v16.14.2
any feature flags active: No

I face the same issue trying to import charts from 1.4 to 2.0 or from 1.4 to 1.4


Backbone Resnet101 - Training time error

I have changed the backbone to Resnet101 and started the training,
got the following error
"RuntimeError: Given groups=1, weight of size 128 64 1 1, expected input[8, 256, 160, 160] to have 64 channels, but got 256 channels instead"
Could you tell me the reason for this error?

Can you provide more error info, e.g., which line in which files does it crash...etc?

Thank you for the quick response.
Error is showed on the line "**return self.relu(self.bn(self.conv(x)))**" on the file "/root/source/pan-pytorch/models/fpem.py"
Please find the complete error trace below

Replace this neck_channel = (256, 512, 1024, 2048) in your train.py. This setting is for both ResNet50 and ResNet101.


Snippet can not auto trigger in markdown file

Snippet can not auto trigger in markdown file

/needsMoreInfo

when i code a java file ,snippet for java will show in suggestions automatically, it will not when i write a markdown file, i have to use shortcuts to trigger it.

I think this is as designed. The built-in Markdown Language Features extension doesn't register a CompletionItemProvider, so there are no trigger characters when editing a file that is using the 'markdown' language mode. Markdown snippets come from the built-in Markdown Language Basics extension. To access them you need to use the generic trigger, which on Windows is Ctrl+Space

You could also enable tab completion with "editor.tabCompletion": "on"

Read this in another issue.  For markdown to get snippets showing in suggestions you have to do this in your settings.json:
  "[markdown]": {
    "editor.quickSuggestions": {
      "other": true,                          // <= this is the important one
      // "comments": false,
      // "strings": true
    }
 }

@ArturoDent Thanks for your help.


Add sample perf results image.

MS Learn docs only support tables of maximum 4 columns. So added a table image instead.

@pmaytak for accessibility and scalability (mobile/small screen devices), we should not be replacing text tables with images.

@pmaytak for accessibility and scalability (mobile/small screen devices), we should not be replacing text tables with images. Let me see how to fix this.

Yea, if there's a workaround, that'd be great. Otherwise, I figured including an image would be better than not including anything at all. However, I could just link to a PR that has test results, that would work also.

Fixed by #253.

Fixed by #253.

@localden Thanks. Hmm, so the fix is just having column alignment on all columns?...

@pmaytak yep, and it needed a whitespace. The warning is just that - a warning. They recommend keeping it under 4, but it generally is possible to have more, just to not overuse them.


Comparison against TensorRT, was it in FP32 or FP16?

In the Hidet paper, comparison against TensorRT

was this in FP32 or FP16?

Hi @kshitizgupta21, all numbers in Hidet paper are for float32 data type.
We did a lot of work since the paper submission, and now, hidet supports float16 and tensor core.


Error using call in client

Map<String, Object> signInValues = new HashMap<String, Object>();
signInValues.put("email", email);
signInValues.put("password", password);
mMeteor.call("/users_booklook/find", signInValues);
why I cant call method with 2 parameter like above in my android .

You need to pass the parameters inside Object [] {...}.
mMeteor.call("method_on_the_server", new Object[]{params} );

params can be a single object or a hashmap object like you've used.

Thanks for your question, @isdzulqor, and thanks for helping out, @FranciscoVictor :)
Actually, both is possible. You can pass any number of parameters to the call(...) method. But it's true that the parameters always have to be wrapped in new Object[] { ... }.
Regarding the single parameters, it's not important what type they are of. They may be a string, a number or a Map. Remember that a single Map with several entries is still just one parameter.
So in your example, signInValues is just one parameter, although there are two values in it.
Fixing your example (wrapping in the array) would look like this:
 mMeteor.call("/users_booklook/find", new Object[] { signInValues });

Maybe you really want two parameters, but this would look like the following:
 mMeteor.call("/users_booklook/find", new Object[] { email, password });

You probably don't want that, however.
Anyway, your example probably doesn't work because /users_booklook/find is not a method that you can call. You can't call the find method on Meteor collections directly.
What you could do is define a method like findSomeThing in your Meteor server code that expects two parameters or a map and then returns something.