MSID: 90674 Version: 1 DOI: 2<IP_ADDRESS>7448

"msas": "Evolutionary Biology", "Neuroscience"
"msid": "90674"
"preprintDoi": "10.1101/2<IP_ADDRESS>7448"
"Reviewed Preprint posted": "2023-09-27"
"Sent for peer review": "2023-07-20"
"Posted to bioRxiv": "2023-07-03" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>7448v1/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=90674)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/90674/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>7448)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/90674/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/90674)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/90674

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/90674

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/90674/v1/90674-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/90674)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

Last author's corresponding email address is incorrect:

Nice work - thanks Naushin

@naushinthomson, should be fixed now - could you check and confirm?


blocks and closures in method chains are visually indented

Which can cause orphans lower in the chain. E.g.,
    aaaaaaaaaaaaaaaa.map(|x| {
                            x += 1;
                            x
                        })
        .filter

The tricky thing here is that we do want to visually indent arguments to methods outside chains

Something very similar happens with multi-line macro invocations, although I'm not sure if this is the same issue so I'll paste it here and can move it to a new issue if not:
    TokenStream::from_str(quote!{
        #deserialized
    }
            .as_str())
        .unwrap()

Playground

Closed via #1604.


NFL Boxscore not separating boxscore.away_players from boxscore.home_players

Describe the bug
NFL Boxscore not separating boxscore.away_players from boxscore.home_players
To Reproduce
Sample code which causes an issue.
from sportsreference.nfl.boxscore import Boxscores
from sportsreference.nfl.schedule import Boxscore
for schedweek in range(1,5):
    games_today = Boxscores(schedweek,2020)
    for week in games_today.games:
        for game in games_today.games[week]:
            bscore = Boxscore(game['boxscore'])
            if len(bscore.away_players) == 0 or len(bscore.home_players) == 0:
                print(f'{game["boxscore"]} Away {len(bscore.away_players)} Home {len(bscore.home_players)}')

Expected behavior
The players on the home team should show up in boxscore.home_players
Screenshots
Here are the games that there is a problem through week 4
202009130rav Away 69 Home 0
202009130ram Away 59 Home 0
202009200clt Away 64 Home 0
202009200oti Away 63 Home 0
202009200crd Away 61 Home 0
202009200sdg Away 59 Home 0
202009200htx Away 63 Home 0
202009210rai Away 62 Home 0
202009270sdg Away 54 Home 0
202009270clt Away 65 Home 0
202009270crd Away 61 Home 0
202009280rav Away 63 Home 0
202010040htx Away 64 Home 0
202010040ram Away 65 Home 0
202010040rai Away 65 Home 0
Desktop (please complete the following information):

OS: Windows 10
Sportsreference Version 0.5.2

Using 202009200clt as an example.  home_abbreviation gets the abbrev from https://www.pro-football-reference.com/teams/clt/2020.htm which is CLT.  Then the team on the individual stats are listed as IND.
The Away/Home decision is if the home abbrev matches the players abbrev then it is home, else away.

For a quick, unofficial fix, one can insert the following code into the boxscore.py file between lines 584 and 585. Keep in mind that this is probably only a quick fix for one to keep working. It checks the name found and replaces it, if needed, before the conditional if statement that checks if home abbreviation matches the team abbreviation found on the player.
abbreviation_fix = {
            'BAL':'RAV', 'LAR':'RAM', 'IND':'CLT',
            'TEN':'OTI', 'ARI':'CRD', 'LAC':'SDG',
            'HOU':'HTX', 'LVR':'RAI'}
        try:
            name = abbreviation_fix[name]
        except:
            pass

I imagine that if the Washington Football Team (note: not addressed above) announces their new team name and abbreviation tomorrow, the above would need to be adjusted.

That works for the current year 2020!  It won't work for other years when the Raiders were referenced with OAK.https://www.pro-football-reference.com/boxscores/201909090rai.htm
I'm wondering if the fact that first team listed is always the away team.

Thank you both for the feedback! You are both spot-on about the abbreviations being the cause of the issue here, and I agree that it will continue to be an issue as various teams change their names and/or move. I found a fairly quick fix to this and will push an update soon once all of the tests pass. Essentially, I do a secondary pull of the abbreviations shown on the actual page (as opposed to just the URIs) and compare those abbreviations with the ones listed in the tables. In my testing, this works both for the code that @mdekarske provided above, as well as previous seasons that I tested and the correct number of players are returned for both home and away.
Thanks again! I will get an update to resolve this out shortly.


Return scorecard results in API result format

I think we should return the score results in the format returned by the scorecard API:
https://api.securityscorecards.dev/#/results/getResult
This will probably make it easier to integrate the result of tally with other tooling that is built to integrate with scorecards.

Done. The results include the full document returned from the API/scorecard client.


Flutter 3.3

推荐收录
链接
Flutter 3.3

还有 Dart 2.18

Flutter 3.3 中文链接

https://medium.com/flutter/whats-new-in-flutter-3-3-893c7b9af1ff


NPM 7 is required

NPM version: 6.14.15
npm install<EMAIL_ADDRESS>--loglevel error --prefix "/opt/iobroker" (System call)
npm ERR! code ENOTSUP
npm ERR! notsup Unsupported engine for<EMAIL_ADDRESS>wanted: {"npm":">=7"} (current: {"node":"14.18.2","npm":"6.14.15"})
npm ERR! notsup Not compatible with your version of node/npm<EMAIL_ADDRESS>npm ERR! notsup Not compatible with your version of node/npm<EMAIL_ADDRESS>npm ERR! notsup Required: {"npm":">=7"}npm ERR! notsup Actual: {"npm":"6.14.15","node":"14.18.2"}
npm ERR!  I tried installing this adapter but npm 7 is required. The problem is that ioBroker does not currently support npm 7.

This is an interesting challenge tho. We officially do not propose users to use npm7. We will change that with js-controller 4.0 soon, because else the github install for some adapters might be broken becauseof an NPM change

As I now upload the complete compiled version to gtihub, I could remove all the dependencies and only add them dev-dependencies... I will fix that

fixed


readarr: <IP_ADDRESS>6 -> <IP_ADDRESS>5

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for readarr is: A Usenet/BitTorrent ebook downloader
meta.homepage for readarr is: https://readarr.com
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found <IP_ADDRESS>0 with grep in /nix/store/clkj9473bkf8pnyjapw9rkf0cml8m392-readarr-<IP_ADDRESS>0
found <IP_ADDRESS>0 in filename of file in /nix/store/clkj9473bkf8pnyjapw9rkf0cml8m392-readarr-<IP_ADDRESS>0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

readarr

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/clkj9473bkf8pnyjapw9rkf0cml8m392-readarr-<IP_ADDRESS>0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A readarr https://github.com/r-ryantm/nixpkgs/archive/7b7def0fedee5f16c4538e520a1592ceab75fc47.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7b7def0fedee5f16c4538e520a1592ceab75fc47#readarr

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/clkj9473bkf8pnyjapw9rkf0cml8m392-readarr-<IP_ADDRESS>0
ls -la /nix/store/clkj9473bkf8pnyjapw9rkf0cml8m392-readarr-<IP_ADDRESS>0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

readarr

Maintainer pings
cc @jocelynthode for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for readarr is: A Usenet/BitTorrent ebook downloader
meta.homepage for readarr is: https://readarr.com
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found <IP_ADDRESS>5 with grep in /nix/store/yqpyqfycqwcxn02q3jw4dx6qpn5v7v31-readarr-<IP_ADDRESS>5
found <IP_ADDRESS>5 in filename of file in /nix/store/yqpyqfycqwcxn02q3jw4dx6qpn5v7v31-readarr-<IP_ADDRESS>5

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

readarr

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/yqpyqfycqwcxn02q3jw4dx6qpn5v7v31-readarr-<IP_ADDRESS>5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A readarr https://github.com/r-ryantm/nixpkgs/archive/5afa84a64d9dfa21192efe126f15fe091397ca1e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/5afa84a64d9dfa21192efe126f15fe091397ca1e#readarr

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/yqpyqfycqwcxn02q3jw4dx6qpn5v7v31-readarr-<IP_ADDRESS>5
ls -la /nix/store/yqpyqfycqwcxn02q3jw4dx6qpn5v7v31-readarr-<IP_ADDRESS>5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

readarr

Maintainer pings
cc @jocelynthode for testing.

Result of nixpkgs-review pr 306242 run on aarch64-darwin 1

Result of nixpkgs-review pr 306242 run on x86_64-darwin 1

1 package built:

readarr


[minor] fix: update default template cleanup in Get Default Value VI

[x] This contribution adheres to CONTRIBUTING.md. (Required)
[ ]  Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

Updated the Cleanup Default Value Template.vi to perform the template cleanup process, even if error occurs during the client creation.

Why should this Pull Request be merged?

To update the Cleanup Default Value Template.vi, as the improper cleanup affects the Client generator.

What testing has been done?
Manually tested the template cleanup by generating error during the client creation process for a set of running measurements.

Cleanup Default Value Template.vi
Diff image
Before:

After:

Get Default Value.vi
Diff image
Before:

After:


Update deletion strings to refer to instances instead of resources

Fixes https://github.com/microsoft/azuredatastudio/issues/11853

Pull Request Test Coverage Report for Build 256691904

5 of 11 (45.45%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.048%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/arc/src/ui/dashboards/miaa/miaaDashboardOverviewPage.ts
1
4
25.0%

extensions/arc/src/ui/dashboards/postgres/postgresOverviewPage.ts
1
4
25.0%

Totals

Change from base Build 256666044:
0.0%

Covered Lines:
19172

Relevant Lines:
44915

💛  - Coveralls


Task 105-112: ProPara, cmrc2018, samsum Datasets

I have uploaded 8 tasks for 3 datasets. Please review.

@Mihir3009, wondering if you can help review this PR?

Task 105:
Let's make the definition more comprehensive (Change it to this):
In this task, you are given a paragraph, and your job is to generate comma-separated entities present in the given paragraph. Generate entities from a given passage in such a way that (i) they are present in the paragraph, (ii) they are non-duplicate, (iii) they underwent a state change during the process. Avoid creating entities that (i) aren't present in the process paragraph and (ii) aren't significant.
Task 106:
Few changes in the definition:
In this task, you are given a paragraph, and your task is to construct a question from the given passage. Construct question in such a way that (i) it is well explained in the paragraph, (ii) the words may/may not be present in the paragraph, (iii) it should start with what/how/describe. Avoid creating a question that (i) is just relevant to one or two sentences, and (ii) not relevant to passage.
Task 107:

Change the definition:

In this task, you are given a paragraph, event and an entity. The event is part of the given paragraph and it changes the state of the entity. Your task is to classify the state of the entity into three classes: 1) not exist, 2) unknown location and 3) known location.  [Moreover, explain what each label means here].

Follow the same format of input for 'Positive Examples', 'Negative Examples' and 'Instances'.

Task 108:

Change definition like this:

In this task, you are given a paragraph, and your task is to construct a question from the given passage. Construct a question in such a way that (i) it is unambiguous, (ii) it is answerable from the passage, (iii) its answer is unique, and (iv) the answer is a continuous text span from the paragraph. Avoid creating questions that (i) can be answered correctly without actually understanding the paragraph and (ii) uses the same words or phrases given in the passage.

Please use the language indicators as suggested in #113

Task 109:

Definition:

In this task, you are given a paragraph and question, and your task is to generate the right answer for the given question from the passage. Construct an answer in such a way that (i) it is unambiguous, (ii) it is answerable from the passage, (iii) it is relevant to the question asked, and (iv) its answer is a continuous text span from the paragraph.

Please use the language indicators as suggested in #113

Task 110:

Change category to "Answer Generation" only
Definition:

In this task, you are given a paragraph and question. The answer to the given question is a span from the given passage. Your task is to generate the starting index of answer span for the given question from the passage.
3. Please use the language indicators as suggested in #113
4. In the Instances, your outputs are wrong, check -
{
"input": " ... ",
"output": [
"dataset[i]['answers']['answer_start'][0]"    [This should be the number]
]
},
Task 111:

Change category to "Summarization" from "Summarisation"
Definition:

In this task, you are given a conversation, and your task is to generate a summary from the information present in the given conversation. Generate a summary in such a way that the context should be present in the conversation. It should cover the complete context of the conversation.

Remove '\r' from the input text. Keep them comma-separated

Task 112:

Change category to "Classification"
Definition:

In this task, you are given two sentences taken from a conversation, and your job is to classify whether these given sentences are sequential or not. We will mark the given sentence pair as 'True' if it's sequential, otherwise 'False'. The two sentences are spoken by two different people.

Remove '\r' from input. Keep them comma-separated.

Let's Change Readme also:
Task 105: Generate entities from given text
Task 106: Generate question from the given passage
Task 107: Based on the passage, event, and entity, classify locations
Task 108: Generate question from the given passage
Task 109: Generate the right answer to a given question from the context passage
Task 110: Generate starting index of the answer span to a given question from the context passage
Task 111: Generate a summary of given conversations
Task 112: Classify whether given two dialogue sentences are sequential or not
(Change categories and JSON file names accordingly)

@Amrit-Bhaskar-abhask10, can you address reviewer comments so that I can evaluate your HW?

@Mihir3009 By adding language indicators in 108, 109, and 110, do you mean, adding as part of the template? like
input :
input_language :
output :
output_language:

@Amrit-Bhaskar-abhask10 No. You don't have to add for all of the input output pairs.
Just before the definition, include three more keys in JSON:
For example, you have Bulgarian for input and English for output and you wrote definition in english then:
{
"Contributors": [],
"Source":[],
"Input_language": ['bg']
"Output_language": ['en']
"instruction_language": ['en']
"Definition":
.
.
.
.
}

@swarooprm @Mihir3009 , Thanks for the review. I have updated the files w.r.t your comments.

Don't remove swaroop's .json files and also don't remove that from Readme. Please update it.

@Mihir3009 Added the files and updated the Readme.

@swarooprm I am happy with @Amrit-Bhaskar-abhask10's work. I approve of this PR. Looks good to me.

Your HW2 is complete now.
Would you like to submit the same tasks to our big project repo https://github.com/allenai/natural-instructions-expansion/pulls? You just need to fork that repo, rename tasks starting from the latest number in the repo and create PR there. This way, you can be part of our research on "learning from instructions instead of learning from examples (conventional machine learning)". This is purely optional and your HW2 grade does not depend on this @Amrit-Bhaskar-abhask10

@Amrit-Bhaskar-abhask10 Just a reminder that, if you plan to submit these tasks to the main Github repo and join our research project, Monday (27th Sept) is the deadline. Again, this is optional and independent of your HW2 grade.


[AIRFLOW-2770] Read dags_in_image config value as a boolean

This PR is a minor fix for #3683
The dags_in_image config value is read as a string. However, the existing code expects this to be a boolean.
For example, in worker_configuration.py there is the statement: if not self.kube_config.dags_in_image:
Since the value is a non-empty string ('False') and not a boolean, this evaluates to true (since non-empty strings are truthy)
and skips the logic to add the dags_volume_claim volume mount.
This results in the CI tests failing because the dag volume is missing in the k8s pod definition.
This PR reads the dags_in_image using the conf.getboolean to fix this error.

PTAL @dimberman

@dimberman , this one looks ok to me. But it seems it breaks this pr(https://github.com/apache/incubator-airflow/pull/3770)...


popovers: Rename and move popover-related templates to follow naming convention.

Following our current naming convention, rename and move all popover-related templates to web/templates/popovers/*_popover.hbs.
Fixes: https://github.com/zulip/zulip/pull/29785#issuecomment-2079809519

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@timabbott Here is the follow-up PR for (https://github.com/zulip/zulip/pull/29785#issuecomment-2079809519).

Nice, merged, thanks @sayamsamal!


How to control the interactive markers positions in RVIZ?

Hi,
Actually, i created an interactive marker in RVIZ and i want to control its position. I mean when the interactive marker reaches a specified position it should be blocked in that position and will not have the right to move forward. Hence you will have just the right to move it back, right or left.
Do you have any suggestions for that?
Thanks.

Is this question related to crouton in some way? It looks like it's specifically an RVIZ issue.


EXT-80: customize horizon container for bsn plugin enablement [cherry-pick]

Reviewer: @sarath-kumar

cherry-pick

Refer to this link for build results (access rights to CI server needed):
https://jenkins.bigswitch.com/job/openstack_horizon_bsn_pull_req/145/

Refer to this link for build results (access rights to CI server needed):
https://jenkins.bigswitch.com/job/openstack_horizon_bsn_pull_req/147/

i presume this is okay to merge. let me know if there are any other comments. i'll open another PR.
getting a tarball ready for now :)


Remove requestify requirement for ArcGIS use

I could not get requestify working with ArcGIS. Using https as the httpAdapter should be sufficient. The Changelog specifies that the requestify httpAdapter was removed at 2.0, but it is required to use the ArcGIS provider

v2.13.1 should resolve the bug you can now use https adapter
an example
var geocoder = require('node-geocoder').getGeocoder('agol', 'https', {
    client_id: 'CLIENT ID',
    client_secret: 'SECRET'
});

thanks @nchaulet!


Error while sending log messages to elasticsearch: message="Method may only be called on a Type for which Type.IsGenericParameter is true."

There is error while trying to send logevent with exception to elastic. It is "known" issue in ElasticSearch.Net SimpleJson Bug (Method may only be called on a Type for which Type.IsGenericParameter is true.) there is workaround with JSON.NET.
if (logEvent.Exception != null)
    document.Add("exception", JsonConvert.DeserializeObject<ExpandoObject>(JsonConvert.SerializeObject(logEvent.Exception)));

Maybe add this workaround to code until main issue will be fixed. @markmcdowell @ejsmith @AlexeyRokhin ?

I was trying to avoid the extra dependency and keeping just elastic search and nlog, hence the use of the elastic search low level client.
The serialiser can actually be swapped out at the moment but requires use of the target via code rather than config.

Fixed by #22


CNF-11189: Add AZTP binary in a separate image

Monitor ManagedCluster resource for AZTP label
If labelled, extract child policies for the cluster and wrap the resources in the AZTP configmap.
If labelled for full acceleration, add manifests
for AZTP post-reboot service.
This commit also includes AZTP post reboot service source code under pkg/aztp. It is built and copied into a separate image for post-reboot execution on spokes
This PR is an alternative to #748 - either of them can be considered for merging
/cc @jc-rh

/hold


[FLINK-12336][monitoring] Add HTTPS support to InfluxDB reporter

What is the purpose of the change
Add HTTPS support to InfluxDB reporter
Brief change log
Added the option to configure scheme for the InfluxDbReporter
Verifying this change
This change added tests and can be verified as follows:
Use an InfluxDB database with HTTPS interface
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

Updates #8466 to latest master changes
Please have a look if the changes are good @tillrohrmann

I'm happy that the change is going to be included!
Thanks for being welcoming and encouraging @tillrohrmann

CI passed. Merging this PR now.


[NewPlugin]  xclusivor binaryninja-xbe 1.0

Please add my plugin to the repository.
Yes, I've read the instructions, especially the part about creating an actual release and creating the tag.
I either used the UI, or the hub command to create a real release.
Author: Me
Repo name: binaryninja-xbe
Release: 1.0

Thanks! Sorry for not closing the issue already. :-)


Add Redox to cross compile CI

This will require https://github.com/rust-lang/libc/pull/2728 before it is functional

Here is the error:
error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /home/vsts/.cargo/registry/src/github.com-1ecc6299db9ec823/libc-0.2.120/src/lib.rs:29:5
   |
29 |     feature(static_nobundle, native_link_modifiers, native_link_modifiers_bundle)
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0554`.
error: could not compile `libc` due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed
##[error]Bash exited with code '101'.

I will mark this PR as ready for review when I can update libc to fix this error

Now that libc 0.2.121 is released, this should probably work, I have marked it as ready for review.

Thanks @jackpot51


[CI] Update Versions DB: Hit S3 directly (instead of going through the julialang.org intermediary

@davidanthoff Any idea why CI is failing here?

That seems unrelated, I'll look into the test failures in a moment. Thanks for the PR!


Fix variable collision causing errors

Codecov Report

Merging #34 (0755d4a) into master (efa3a4d) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   44.35%   44.44%   +0.09%
==========================================
  Files          38       38
  Lines        4437     4437
==========================================
+ Hits         1968     1972       +4
+ Misses       2469     2465       -4

Impacted Files
Coverage Δ

assemblyline_core/dispatching/dispatch_hash.py
97.63% <100.00%> (+3.93%)
:arrow_up:

assemblyline_core/dispatching/run_submissions.py
67.69% <0.00%> (-9.24%)
:arrow_down:

assemblyline_core/dispatching/client.py
72.47% <0.00%> (-0.46%)
:arrow_down:

assemblyline_core/dispatching/dispatcher.py
90.85% <0.00%> (+1.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa3a4d...0755d4a. Read the comment docs.


security templates for archetype engine

security templates for archetype engine
See #4276
Signed-off-by: aserkes<EMAIL_ADDRESS>

/oca-checked


feat: added global env for license scan to publish report as pr comment

Add before, after step along with this.


java.lang.IllegalStateException: Observer com.yanzhenjie.recyclerview.swipe.SwipeMenuRecyclerView$2@50752ff was not registered.

我在PageAdapter.destroyItem的时候
java.lang.IllegalStateException: Observer com.yanzhenjie.recyclerview.swipe.SwipeMenuRecyclerView$2@50752ff was not registered.
at android.database.Observable.unregisterObserver(Observable.java:69)
at android.support.v7.widget.RecyclerView$Adapter.unregisterAdapterDataObserver(RecyclerView.java:6627)
at com.yanzhenjie.recyclerview.swipe.SwipeMenuRecyclerView.onDetachedFromWindow(SwipeMenuRecyclerView.java:331)
at android.view.View.dispatchDetachedFromWindow(View.java:14599)
at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3110)
at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3102)
at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3102)
at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3102)
at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3102)
at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3102)
at android.view.ViewGroup.removeViewInternal(ViewGroup.java:4642)
at android.view.ViewGroup.removeViewInternal(ViewGroup.java:4615)
at android.view.ViewGroup.removeView(ViewGroup.java:4546)
at android.support.v4.view.ViewPager.removeView(ViewPager.java:1498)

我也遇到了同样的问题，是在list所在view调用了removeAllViews的方法的时候报出的异常，你解决了么？

recyclerView嵌套SwipeMenuRecyclerView滑动出现   java.lang.IllegalStateException: Observer com.yanzhenjie.recyclerview.swipe.SwipeMenuRecyclerView$2@4aa7b9a0 was not registered.

Hey thanks for quick response. I’m using 2.1.0 apparently. Should I switch to 1.2.0 instead or will that only break more stuff?

8 dec. 2018 kl. 13:25 skrev Zhenjie Yan<EMAIL_ADDRESS>@Addibro Are you using the new version 1.1.3 or 1.2.0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@Addibro Sorry, I am a bit confused, are you using SwipeMenuRecyclerView? The current version of SwipeMenuRecyclerView is 1.2.0, the previous version was 1.1.4, and the 2.x version has not been released yet.

Sorry, I mixed up names with you and someone else. You can ignore this from now on.

On 9 Dec 2018, at 03:45, Zhenjie Yan<EMAIL_ADDRESS>wrote:
@Addibro https://github.com/Addibro Sorry, I am a bit confused, are you using SwipeMenuRecyclerView? The current version of SwipeMenuRecyclerView is 1.2.0, the previous version was 1.1.4, and the 2.x version has not been released yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/yanzhenjie/SwipeRecyclerView/issues/141#issuecomment-445506154, or mute the thread https://github.com/notifications/unsubscribe-auth/AOXjVUlE1TaYu9mCYdo7UhRCjAcpTtu6ks5u3HlngaJpZM4Q0gAR.


Dealing with active record validation exceptions

A failed active record validation (ex: validates :names, presence: true) produces a 422 (Unprocessable Entity) error response which will be handled by Gaffe.
Is there a way to circumvent this so as to deal with failed validations in the original controller without having to resort to a rescue clause in every create/update method?
Thanks for this handy gem by the way!

As far as I know, .create, .update and #save don’t raise exceptions — .create!, .update! and #save! do. So if you want to handle errors in the original controller:
class FooController < ApplicationController
  def create
    foo = Foo.create(foo_params)

    if foo.save
      redirect_to foo_path(foo)
    else
      render json: { errors: foo.errors }, status: :unprocessable_entity
    end
  end
end

Gaffe won’t handle any 422 error in the above code.

 My bad, I was using a bang update method. Thanks a bunch :)

Alright, I’ll close the issue. :smile:


Showcase Submission for 125-fourier-series

Thank you iain maitland for your contribution! A member of the Coding Train team will review it shortly.

Fourier Fun Times
iain maitland

Love this!


[Docs]: Clarify runtime and development targets for Win32 App Isolation

Links
No response
Description
It should be made clear which versions and SKUs of Windows support Win32 App Isolation (e.g., retail 22621, beta X, dev Y, canary Z) and which capabilities are supported where. Also consider which targets are needed for development (the tooling in this repository) if it doesn't match the first list.

Hey @riverar we have the versions covered in the windows-release-notes.md file, but we'll clarify the supported SKUs too. We'll look into the supported OS versions for the tools as well.

Is that checked into this repository somewhere?

I saw https://github.com/microsoft/win32-app-isolation/blob/main/relnotes/windows-release-notes.md but it doesn't seem accurate or complete. Win32 App Isolation is documented as shipping in 22621 right? But the documentation only indicates it's available via Canary builds of Windows.

The Public Preview called out in the blog is only available through Windows Insiders via the Canary channel. The release notes are accurate about the supported builds.

Got it, thanks!

Close as clarified.


Create flag to enable background executor and add to VR panel apps

Summary: We'd like to run experiments on removing background executor in RN Fabric. This will move layout computing from the background thread (fabric_bg) to the JS thread. It will simplify the RN threading model and unblock new performance tracking features like Visual Completion Tracker and MutationObserver.
Differential Revision: D47452561

Which VR panel apps? Do you have in-app measurements that illustrate the difference?


Examples for CASTEP interface added.

Dear Dr. Togo,
I've added examples for dynamic matrix calculations using CASTEP interface. Please consider this pull request to add the changes into development branch.
Very friendly,
Eugene

Merged. Thanks!


.hidden-XX-down how to show/hide elemetns in same time?

With new rules .hidden-XX-down ONLY I cant show and hide in same time elemts.
I have:
<button class="navbar-toggler pull-xs-right hidden-sm-up" type="button" data-toggle="collapse" data-target="#exCollapsingNavbar">☰</button>

and

        Link 1

        Link 2

        Link 3

Here how it works
stadia 1

stadia 2

stadia 3

So there is a white space during  responsive resizing. White blame when any nav doesn't appear in 230 px.

@jek-fdrv Please make your example into a JS Bin or JS Fiddle.

Ok. 1 min plz.

Here https://jsbin.com/ravoninino/edit?html

Hi @jek-fdrv!
You appear to have posted a live example (https://jsbin.com/ravoninino/edit), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 36, column 1 thru column 7: End tag for  body seen, but there were unclosed elements.
line 12, column 3 thru column 23: Unclosed element div.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Nice system!  Sry. Here the new version.
https://jsbin.com/jihotoxise/edit?html,output

Hi @jek-fdrv!
You appear to have posted a live example (https://jsbin.com/jihotoxise/edit), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

W002:  is missing X-UA-Compatible <meta> tag that disables old IE compatibility modes
W003:  is missing viewport <meta> tag that enables responsiveness

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Honestly on bootstrap original documentation page same thing
One

Two

Paa-aadaa

Also why error system with html validation ask about is missing X-UA-Compatible <meta> if bootstrap  doesn't support 8 IE any more?
https://jsbin.com/zabaxozefe/edit?html,output

Hi @jek-fdrv!
You appear to have posted a live example (https://jsbin.com/zabaxozefe/edit), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 40, column 3 thru column 44: No space between attributes.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

https://jsbin.com/zabaxozefe/edit?html,output

Also why error system with html validation ask about is missing X-UA-Compatible <meta> if bootstrap doesn't support IE8 any more?

The problem which that tag addresses is not specific to IE8.

The SM breakpoint covers the following range of viewport widths: 544px ≤ viewport_width < 768px
.hidden-sm-up hides elements when the viewport width is SM or wider, which is to say viewport_width ≥ 544px.
.hidden-sm-down hides elements when the viewport width is SM or narrower, which is to say viewport_width < 768px
Thus, if the viewport is within the SM breakpoint and two elements have .hidden-sm-up and .hidden-sm-down, neither of them will be visible.
So, the classes are working as intended.
You should use a different combination of responsive visibility classes such that both elements are never simultaneously invisible. I invite you to consult the chart on http://v4-alpha.getbootstrap.com/layout/responsive-utilities/ to better understand the effects of the classes.

You should use a different combination of responsive visibility classes such that both elements are never simultaneously invisible.

For example, .hidden-sm-down and .hidden-md-up

Filed #18557 regarding the issue with the navbar on v4-alpha.getbootstrap.com


NO-JIRA: Update rebaseLabel name in renovate config

We need write access to add labels to PR, hence updating the rebaseLabel in renovate.json to use the needs-rebase added by the prow/tide.

/hold

/unhold


(HELP! still got an issue) after a few intensive days, i finally got it working with mailwhizz

Hi Postal Users,
If someone with more experience could point me in the right direction.....
i'm surprised i actually made it this far :) bit of a noob

my mails will only send with my ip address, how do i change it to my hostname ?
how do i change the sender address, at present its something like<EMAIL_ADDRESS>i would like it to be<EMAIL_ADDRESS>and remove the sub domain part,
i am presuming i should be editing something else rather than the postal.ybl file

thanks for viewing & thanks in advance and all stay safe......
Wayne

Please share how you fixed this so that others could benefit.

Please share how you fixed this so that others could benefit.

i honestly dont know tbh , but it defo has something to do with my domain name as i cant login to postal only from the ip i will fully update people when i figure it out , but it is working from mailwhizz .

You will need to have pointed a DNS record at your servers IP address at some point so you should be able to use that?

if you can't add bbbb.com to Postal in the UI then you could have a look at the Send As Any setting which might help but could complicate your integration with your other software.

1. You will need to have pointed a DNS record at your servers IP address at some point so you should be able to use that?

2. if you can't add `bbbb.com` to Postal in the UI then you could have a look at the Send As Any setting which might help but could complicate your integration with your other software.

hi, i sorted out this issue out, thanks anyway..... can someone point me to an example postal.yml file completed and filled out, i have everything working from mailwhizz just having an issue getting a 10/10 score dmarc dkim spf errors even though postal saying we all good and my mind is bamboozled on what postal.yml needs to be properly configured

Postal merges in the defaults so you probably have what you need covered. What errors do you have?

I have 1 fully working vultr server running postal sending fine.
QUESTION: has the files for postal changed in the last fews days or something?
as i have just added a second server for testing and i have just done the normal install, and now getting softmail when i send, scratching my head is an understatement right now with 1 working and 1 not working and i have tried 6 times,am i missing something as i have done nothing different but everytime i try now, i am getting softfail done nothing different at all......


Create automated river tests

I want a test suite that will run against all rivers and validate that:

They have the correct files in place
The config contains the right info
The parser can be sent the response from the URL(s) in the config and returns the properly formatted data to the callbacks.

This will allow people to create new rivers without having to run Redis locally.

Does your third bullet point mean that the fields and metadata will have to directly map (in name) to the responses from the URLs or does this suggest additional info in the config defining what the response should look like from each of the URLs?

I think all we can do is check that the data sent to the first callback for temporal data has the same length as the fields in the config. Some of the items in the list might be null, that is okay, but the length must be the same.
For the metadata callback, I think we just need to ensure it's not null. Otherwise the data could have any structure, as long as it is able to be JSON.stringify-ed.


Configurable timeout?

Some of my queries sometimes take longer than 10 seconds to execute.
I tried to fork and make a patch to pass in a custom timeout, but your function returns function way of structuring things makes it very hard to get down to the core components.
Any way you could add a configurable timeout?
Thanks,
~Jordan
btw, this library rocks. Thanks.

For what it's worth, I'm also really curious why you structured this library in such a strange way. Is it just a style, or is it helpful in a way I don't quite understand? Thx for explaining

Do you mean the continuous style: return function(cb)? Or the separation between FacebookClient+FacobookSession?

The Return function (cb) pattern
~J
(via phone)
On Jan 11, 2012 12:58 AM, "DracoBlue" <
<EMAIL_ADDRESS>wrote:

Do you mean the continuous style: return function(cb)? Or the separation
between FacebookClient+FacobookSession?

Reply to this email directly or view it on GitHub:
https://github.com/DracoBlue/node-facebook-client/issues/20#issuecomment-3443634

The advantage is, that one can add optional parameters (even functions), without breaking the signature of the method:
#graphCall(method, params)(function() {
});

becomes to:
#graphCall(method, params, options)(function() {
     console.log('timeout is', options.timeout);
});

But I keep this pattern in this library just for consistence. It's pretty difficult to maintain and doesn't help autocompletion in IDE and such things :).

Neato.
So the best way to add this timeout parameter would be to just add it as an argument of the top-level method, and pass it all the way down to onRequest?

Fixed with 593c6f9c5c7149ad9a488f577f2893b743fdd3c0


Resolve parser conformance tests (initial PR)

Issue #, if available: #108
Resolves 10 case failures.
Description of changes:
Before (full report)
cargo test --package partiql-conformance-tests --features "conformance_test"
...

test result: FAILED. 76 passed; 87 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

After:
cargo test --package partiql-conformance-tests --features "conformance_test"
...

test result: FAILED. 86 passed; 77 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for providing the before and after for the test results. May be helpful to include a brief description for the fixed tests since there can be some subsequent PRs fixing more conformance tests.
The output of cargo test shows the number of passing/failing tests but as part of the conformance report generation #79, we may need to ensure that tests that were previously passing are not now failing. E.g. if 5 more tests pass due to a change, need to ensure that 5 additional tests are passing and not something like 6 tests now pass but 1 more fails.

That's a fair point, will do.

Please disregard this PR as it has been polluted by commits from main. I'll create a new one and reference this PR for comment history.

Closing this PR in favor of the following:
https://github.com/partiql/partiql-lang-rust/pull/116


create Makefile, Taskfile or justfile to provide common operations like lint, format, docgen

There are a bunch of tools to support these kinds of operations, we should pick one of them and make it easier to run common operations like lint, format, docgen, etc.

https://github.com/casey/just
https://taskfile.dev/#/

cc: @imjasonh @mattmoor
feel free to assign it to me, we(w/@dentrax) are willing to work on this

I'm not opposed to someone contributing this, but for my part, I probably wouldn't use it day-to-day. We've been just running scripts directly ourselves and checking things in CI, and that's been fine.
So I won't reject a Makefile/whatever being contributed, but I probably won't be surprised if it breaks in subtle ways in the future, unless someone is actively and regularly exercising it. This might lead to an even worse new contributor experience, since we could end up suggesting broken workflows. 😞
wdyt?


littleproxy.org does not respond

The README has links which point to http://littleproxy.org. However, the links cannot be reached and time out. Maybe they should be changed to point to http://www.littleshoot.org/littleproxy/ instead.

I've removed it from the README, since I think this link is permanently dead (#219).

Since this change has been merged, I'll close this issue.


fix minor problem in list_attributes_to_params()

Signed-off-by: Doron Chen<EMAIL_ADDRESS>

@cdoron  - thank you for reporting this issue and the patch to address the same. I filed ATLAS-4590 and merged your fix in master and branch-2.0.


Is it possible to extract the socket message from the raw packet?

I'm trying to drop the headers and fluff so that only the original socket message remains.
So, if I have another NodeJS running and I send socket.write(Buffer.from([0xAB])), how would I get 0xAB from the raw_packet using node_pcap?
This is what I have so far.
pcap_session.on("packet", function (raw_packet) {
    console.log("raw packet", raw_packet);
    const packet = pcap.decode.packet(raw_packet);
    console.log(
        packet,
        raw_packet.buf.slice(packet.pcap_header.len, raw_packet.buf.length)
    );
});

It seems that payload.data should do this.


feat: added refs to link components

Adds ref support to the nextjs/react  component.
Description / Motivation
Currently if you are using this library with another library that tries to pass a ref to the Link component, you get warnings as it doesn't support Link's being passed through.
We have been using this with the MUI framework, and they require refs when passing the component to it's components:
https://mui.com/material-ui/guides/composition/
@pzi has opened an issue: https://github.com/Sitecore/jss/issues/1053
Testing Details
Added to the Image.test.tsx files a simple check that the ref's id is the same as the anchor's id.
Just ran the standard yarn run test in both react/nextjs packages and then yarn run coverage-packages. Linting passes, however can't build. But then dev wouldn't build for me neither.
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

could be seen as a bug, or an enhancement.

I've just updated this as there was a conflict due to a recent merged change. However I noticed you have bumped to react 18. Is it possible if this gets merged we can back port this to the v20 release as this is an issue for us. Not sure how quick it will be for us to move to v18 of react (or if this will be compatible with v17 of react).

@ambrauer @illiakovalenko could we get a review/some feedback please?

Is there anyone who can have a look into this? The actual change is reasonably small, just the formatting has made it look large. Keen to get this into our project as we have recently upgrade using MUI which is causing lots of warnings for the Link component.

Hey @jedimonkey @pzi - I've added this to our backlog so we can prioritize getting you some feedback and merging this in. Expect something in the next couple weeks. We are actively planning a minor release of v20 and hoping to include this one.

awesome, thanks for getting back to us @ambrauer 👍🏼

@pzi @jedimonkey I pulled your commits into another branch (#1080) in order to make quick changes:

Removed package.lock
Removed children proptype - there is a mismatch which I couldn't handle when you provide different values
We will release it in the next major release as it's recommended in React docs, don't release a minor version if you add Ref's


restore model slow

hi,thanks for your great work ,it works well .But when i restore model ,it usually use more than 10mins ,it is  normal? or something wrong with code?

My configuration is RTX 2080 Ti  ,cuda 8.0


New tr069 server in the making

The new tr069 will be based on Scala, Akka HTTP and Slick. It will handle sessions differently than the existing tr069 server by leveraging actors in akka. Each authenticated client gets it's own actor. The actor keeps the conversation state. The protocol and next steps logic will reside in the session actor.
There are many reasons to rewrite tr069. One of the reasons is that it's very difficult to extend tr069 as it is now. Another reason is typesafety. Yet another reason is performance from akka by being fully asynchronous.

Currently i have something working now. And it will be alot easier to add AddObject into the mix compared to current code. The new service will make a FSM (finite state machine) actor for each conversation. This guarantees that messages can only come in the correct order and the FSM will fail and kill it self otherwise.
It's very interesting. If any experienced Java developers out there that want to learn Scala or know Scala, please speak up :)

Discovery mode will be removed as it's a security hole. And there will be no test mode or test servlet like in the current tr069 server.
I will also remove "none" as a security method because we are now in 2018 and every important server like this should be protected behind ssl and authentication.
I have currently implemented the server as completely stateless. Which is different from existing tr069 server. Existing server establishes a session server side and then send a Cookie back to client. The latter will save load on db but will make it Impossible scale horisontally without pointing units to different servers. With my new solution you have three servers load balanced with a round robin.

I will also run the eventually horisontally scaled servers in an akka cluster which will enable me to cache data in actors because the state will be shared across the cluster. This replaces the currently resource heavy db message system via a message table

The Digest authentication will also be much, much more secure. It will make sure to check that nc increments for each request. And conversation will break if the number sequence in nc is restarted or retried. That is the plan at, at least ;)

nc aka for ex 00000001 must now always be incremented for each request. And if a hacker tries to dump thousands or millions of requests and fails, the server will curcuit break, meaning it will say its busy

I will also verify server nonce

both nonce verification and nonce count verification is now implemented. This is only for Digest auth, and might introduce a slight overhead. But its better to implement the digest protocol correctly than to just support it on paper

Decided to publish the work in progress.
https://github.com/freeacs/freeacs-tr069.
All the things needed to implement and craft out a full blown tr069 server has been implemented.

Closing. Not relevant as issue.


Lock optimization

目前锁粒度太大，需要通过bucket、数据结构维度减少锁粒度，提高并发性能。或者分片的方式。
The current lock granularity is too large and needs to be reduced by bucket, data structure dimension to improve concurrency performance. Or a sharding approach

We can consider implementing this paper: Epoch Protection Framework

And also MVCC is one of solutions, but we need more research.


Add support for pausebreak

Hi there,
It would be great if we had support for the pause-break button. Probably under pausebreak. It's a very easy addition.

This is now possible to do yourself as of version 1.6.0
You can use Mousetrap.addKeycodes.


fixing permissions on bluetooth does not help, this does

Hi, about the issue described in README, this helped me on Ubuntu 15.10
https://code.google.com/p/pybluez/issues/detail?id=62

Awesome thanks! I will add it once I get a chance

Updated the Readme thank you!


"Accommodation" industry is misspelled

Fix this in utils/industry.py

Corrected for version 0.1.4


Upgrade httpoison dependency version to ~> 1.0

Please upgrade. Currently it doesn't seem possible to use etherscan with the latest version of https://github.com/izelnakri/eth since the latter depends on httpoison ~> 1.0.

httpoison has been updated to 1.0 in version 0.1.5 (just released)


Line 25 type, additional character '2'

Line 25
Currently is:
Add-AzureADGroupMember -ObjectId $GroupObjectID2.ObjectID -RefObjectId $y2.ObjectId -InformationAction SilentlyContinue
the 2 needs to be removed.
Add-AzureADGroupMember -ObjectId $GroupObjectID.ObjectID -RefObjectId $y2.ObjectId -InformationAction SilentlyContinue

Great catch! Updated. Thanks


Installer should honor current settings during update

Description of the new feature/enhancement
When updating the installer defaults to enable run at system startup but I have this turned off. I have to deselect this every time I update. If I would have chosen not to add the start menu item I would also need to deselect this option every time I update.
Proposed technical implementation details (optional)
Read current configuration during update.

Solved in PR #57 release v.1.1.1


Design calculator UI with JSX or Style.css

This is the second milestone of my first React-based project. I am happy that I have successfully completed the mentioned tasks in this particular milestone:

[x] Design UI using JSX and Styles.css
[x] Follow JS, React, and CSS best practices
[x] No linters Error

@emhamza, if the project is not yet deployed you should remove the Live Demo section altogether from the README. it is not required to deploy the app at this stage

@Ismailco  Certainly, I will do that, but I think It would be more appropriate to leave the Live Demo section with some text I have already posted there that "The live demo link will be available soon...".  This means I will update my readme file with the live link when I will deploy my website. 🥇 However, if you insist, I will remove the section, but please do assist me first if you found my argument irrelevant and inappropriate. 💯


Enhancement of Home Page

Is your feature request related to a problem? Please describe.
The home page of any website is the major attracting force of the organisation as well as the website. I have some ideas for enhancing the same and making it more responsive and updated with today's trend.

Having a responsive navigation bar.
The sections look very distraught currently.
Footer needs to be positioned and re- designed.

Describe the solution you'd like

Navigation bar of various types can be used - sticky navbar, side navbar, drop down menu etc.
Sections can be divided into cards segments and trendy scrolling effects can be implemented.

Enough padding between the sections
Spreading content instead of compressing it would improve visibility of text (highly recommended).
Using icons/ images/ better styling (highly recommended).
Adding testimonials section, any other highlights to home page

Align footer content and use appealing color scheme.

@shivangi00 welcome to our repo, good to have you here.
Yeah, the designs could be made better. We wanted to update the designs, but I was unable to come up with some good ideas, If we gonna do it, I think we should start with making mockups and all. If you would like to manage this issue I can give you outside collaborators rights that way you can merge and manage issues on your own.
And for the design what vision do you have, should we go with the current theme and create new components and add new content or change the theme completely.

@Souvikns Thank you! Yes I would definitely like to manage this issue. I agree we can start with building a mockup first that would make things clearer.
For the design too I think mockup will be a decent start to know which of the options we can go with.

This is one of the design themes I came up with. Since the logo reminded me of pacman game. Let me know how you find this or whatever suggestions you have in mind. Also we can connect on figma to make design sharing easier.
My figma profile link - https://www.figma.com/@shivangi00

This is kinda cool, so should we have this as a banner, for the website, like the first thing that loads when the user visits our page.
Also, what are your thought on the theme, as it is dark should we convert the whole website dark?

@shivangi00 , Thank you for this. Make sure, you are in the discord channel. I am happy to see you up :)
Due to ongoing exams, we are bit running slow. But never mind, wont let you down. :)

This is kinda cool, so should we have this as a banner, for the website, like the first thing that loads when the user visits our page.
Also, what are your thought on the theme, as it is dark should we convert the whole website dark?

Yes this is just the banner design, the rest of the content will follow. We can use dark theme, it looks great, just as in Netflix's website and many others. A lot many animations and designs can be incorporated with this theme. Let me know what you think.

@shivangi00 , Thank you for this. Make sure, you are in the discord channel. I am happy to see you up :)
Due to ongoing exams, we are bit running slow. But never mind, wont let you down. :)

Yes I am in the discord channel. I too have my exams, can totally understand. But I'm excited! :)

I would love to work for the implementation of the same.

can i work on this issue

@Souvikns  would love to work on this issue please assign this to me

@Souvikns  would love to work on this issue please assign this to me


[jest-plugin-set] Set variables should be created before beforeEach is called

Description
Nested set calls must ALL come before beforeEach in order to be set properly. Otherwise, it'll use the values from outer set calls which is incorrect
Screenshot
Test Plan

@negativetwelve I wonder what this is about. When you mix in own beforeEach blocks and use values previously defined with set in them? Because this seems to work just fine:
import set from 'jest-plugin-set';

set('foo', () => 'outer');
set('bar', () => `bar with foo: ${foo}`);
set('baz', () => `baz with bam: ${bam}`);

describe('outer', () => {
  set('foo', () => 'inner');
  set('bam', () => 'yey');
  it('uses the inner foo for calculating bar', () => {
    expect(bar).toEqual('bar with foo: inner');
  });
  it('uses the inner bam for calculating baz', () => {
    expect(baz).toEqual('baz with bam: yey');
  });
});

Hi @bxt, thanks for your comment. If I remember correctly, the issue comes from something like:
import set from 'jest-plugin-set';

set('a', () => 1);
set('b', () => 2);

describe('outer', () => {
  beforeEach(() => {
    console.log(a, b);
  });

  describe('inner', () => {
    set('a', () => 5);
    beforeEach(() => {
      console.log(a, b);
    });

    it('returns the correct value', () => {
      expect(a + b).toEqual(7);
    });
  });
});

The test should pass but the console.logs will be wrong meaning that using the set values in the beforeEach does not work properly.
(I wrote the code without testing, please excuse if there are small errors)

Hey @negativetwelve, wow thank you for your fast answer! It also fails for me but slightly different. It outputs
1 1
5 1

And:
    Expected value to equal:
      10
    Received:
      6

So only the indirect calculation of b has the problem. Interestingly the beforeEach also messes with the assertion, because the bad value will be cached then.
(node v10.7.0<EMAIL_ADDRESS><EMAIL_ADDRESS>I think one can get rid of all beforeEach uses with set though 😅

oops you're right (I kept editing my responses haha). It's definitely a caching issue because of the order that the beforeEach are run in.
I stumbled upon this issue when using set to construct something like a user object and changing one value within a nested set of describe blocks. It wasn't too hard to work around but was definitely unexpected.
I mainly use set for variable assignment and beforeEach for actions and things like requests.
beforeEach(() => {
  fetch(url, params);
});

something like this ^

I ran into this also today. Here's another repro.
describe('', () => {
  set('a', () => x)
  beforeEach(() => {
    console.log(a);
  })
  describe('', () => {
    set('x', () => 1)
    test('', () => {
      expect(a).toEqual(1)
    })
  })
})

Fails with ReferenceError: x is not defined on the second line.
Pulling variables from inner contexts to use in beforeEach is definitely a useful pattern which can eliminate a lot of duplicate code. Something I always do in rspec.


ChatGPT does not respond

Describe the bug
问题描述
The chatgpt does not respond to me. For example if I select some text from the context menu, the floating window will display something like: Reply in Chinese (Traditional).Analyze the following content and express your opinion,or give your answer: "....", without any response from chatgpt.
To Reproduce
如何复现
Steps to reproduce the behavior:

select some text
right click on the selected text
click "?" of the context menu
See error

Expected behavior
期望行为
I found the chatgpt does not work this week, but bing is still working.
Screenshots
截图说明

Please complete the following information):
请补全以下内容

OS: Windows 11
Browser: chrome
Extension Version: v2.4.2

同样的问题，我是设置成自动触发的，当在浏览器搜索一个问题后，侧边栏的回复没有反应，有时间辛苦看一下吧

Recently, ChatGPT has updated the verification of regular mode.
最近ChatGPT更新了普通模式的验证.

Hey,
same problem are here.

There has been no connection for a few days.
Yesterday it was sporadic. Not again today.
No matter what you set, no function is possible. Despite tokens etc.
One day it works, another day it doesn't work again.

插件貌似出了一点问题，无法正常响应了，感觉好像是gpt那边的问题，作者看到修一下吧

I will fix it recently.

ChatGPT Box  no longer responding..

Same problem here. Thanks !

Also same problem here. Hope this gets fixed soon! Google Bard seems to be working fine, so I think this is just a chatGPT problem.

Same problem, thanks

same here

Fixed in https://github.com/josStorer/chatGPTBox/commit/4859e9a905e8a405d2a5c40d526bec1b2ea112ed
Thank you for providing these references. In the end, I adopted a method that I believe may be more reliable to obtain the arkose_token. This method does not depend on the specific api.js from the official repository and script injection, making it usable on any page.

@josStorer It works now, thank you!


Add activity feed API

#6  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @newtoallofthis123 and the rest of your teammates on  Graphite


"Tap to view upload" versus Samsung

We tap the above notification, but nothing happens. Samsung Galaxy Android 12
4.0.5~f03b7dd8d

Sure we can switch to the app manually, but it takes some of the fun out of it.

I can reproduce the issue on current master.
Anyone taking this, you find find this helpful: #4656

Hello @nicolas-raoul!, I am interested in working on this issue and would love to be assigned to it. Please let me know if there are any additional details or information I should be aware of before starting. Thank you.

Hello @nicolas-raoul!, I am interested in working on this issue and would love to be assigned to it. Please let me know if there are any additional details or information I should be aware of before starting. Thank you.

I have same issue on Android 10 (MIUI 12).

clicking on successful upload does nothing
clicking on failed upload opens the app (but does not position on failed picture, nor give any more information about the error, as one would expect)
clicking on notification that description was changed does open the browser linking to commons metadata page, which is correct at least.

Video:
https://github.com/commons-app/apps-android-commons/assets/156656/df391468-862d-416b-b38e-ad655a2bfb2e

Also can confirm that "clicking on successful upload does nothing"  in latest f-droid release (4.1.0~1649d1e2c)

Can confirm that "clicking on successful upload does nothing"  bug is still present in latest f-droid release (4.2.1~14b6c455b) on Android 10 (EMUI 12), Huawei P30 Pro.

@wldeh  Any progress to share? :-)

I face this issue on the current master as well, and this happens with almost all upload notifications, such as "Upload Failed", "Upload Paused", etc.

I still face this problem on the current master, and it seems to be there for almost all upload notifications, such as "Uploading Paused", "Failed to upload", etc.

Can confirm that "clicking on successful upload does nothing" bug is still present in latest f-droid release (5.0.1~af028cbdd) on Android 14 (OneUI 6.1), Samsung Galaxy S23+

@wldeh are you still interested on working on this Commons issue? Or would you rather be unassigned?

I tap on the Commons app message in the push notifications. No matter how I press, nothing happens. The strange thing is that it does work in very rare cases. But I have no idea under what circumstances it works and when it doesn't.
See also #5779

@wldeh  I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)

If the smartphone is unlocked, it does not work for me. If the smartphone is locked (lock screen), it works for me

If the smartphone is unlocked, it does not work for me. If the smartphone is locked (lock screen), it works for me

I just tried, and cannot reproduce this on my Samsung Galaxy A40 (Android 11, v4.2.1)

Hi, all. Are people still having this issue in the latest release?
Thanks,
Chris.

@chrisdebian : I tried it earlier (Version 5.1.0~707997bd1). It worked both in lock screen and unlocked state. Thank you very much!


Make block size configurable for SPT

Make block size configurable for SPT. This is desirable when the FS does IO in blocks larger than the current 512 Bytes. Having this issue in rumprun; IncludeOS is not an issue at the moment as only fat is supported (which uses 512B blocks as default). Other FSes default to different block sizes, like ISOFS to 2048, ext2 to 1024, and LFS to 4096.
Ideally, would like to pass the block size as an argument (like --disk=abc --bsize=1024), but I'm guessing that's not a very good idea for security reasons. Instead, this suggested change sets block size at compilation time. The idea would be to build solo5 like this: SPT_EXTRA_CFLAGS=-DSPT_BLOCK_SIZE=2048 make.
Alternatively, could also relax the block size checks (in the bindings and tenders) to only multiples of block size. This would be by far the easiest option, but not sure if it's the safest.

Moving the discussion to #325


Update xml with enum and array for struct item

####Problem
In order to add support for complicated type for issue 8895, we need explicitly to mark struct item as enum=true or array=true for enum and array processing inside struct, the zap has already added the support for enum and array query and check.
We need to update xml with enum and array for struct item
####Change overview
update xml with enum and array for struct item
Also cleanup test cluster.xml
Sync with latest zap
####Testing
How was this tested? (at least one bullet point required)
Compilation and presubmit validation.

Also, are the other changes required by the ZAP update? If not, we should have one PR that does the ZAP update and minimal other changes, and a second PR for whatever changes are not related to the update.
sure, would create two PR


minecraft crash log: DuplicateModsFoundException

Minecraft version: 1.12.2
mod version: VanillaFix-1.0.3-22.jar
crash log:
https://pastebin.com/iuzVHVF9
but i have only one mod installed (no 2 VanillaFix-1.0.3-22.jar in the mods only one)

Duplicate of #1. Either use the latest CurseForge release, or recommended forge 2655. The fix for bug #1 breaks the mod from loading in dev, so we're only making it work with forge 2655+ in releases.


Two taps required on mobile unless playButtonShowing: false

Describe the bug
Mobile (specificlaly iOS) requires two taps to get the video started playing. Desktop only requires one click
To Reproduce
Steps to reproduce the behavior:

Go to any video where playButtonShowing is not set to false
Click on big play button
Second tap required to start video

Expected behavior
Single tap required to start video (considering play button is on screen)
Screenshots or Links
While on mobile navigate to https://www.fluidplayer.com/ - player at bottom of page, check "Show play button"
Desktop (please complete the following information if relevant):

OS: Windows 10
Browser: Chrome
Version: latest

Smartphone (please complete the following information if relevant):

Device: iPhone XS Max
OS: iOS 13
Browser: Safari

Affected version
v2 (current), v3 (current)
Additional context
None

I think this is a duplicate of my issue: https://github.com/fluid-player/fluid-player/issues/511

Can confirm this is a duplicate of #511


Revision needed - Embedded GUI Using Linux Frame Buffer Device with LVGL

The tutorial is not compatible with 8.0.  Noobs might have difficulty.  I made several modifications to get it working.
https://blog.lvgl.io/2018-01-03/linux_fb

@Uup115 Can you share what you changed to make it working?
I am in the same boat now. Using RPI OS Lite

Any help appreciated @kisvegabor @Uup115
Device/OS : Raspberry Pi with Desktop
SDL version working fine - Display & Touch
Device/OS : Raspberry Pi Lite
Display : Working
Touch : Not working yet
Getting the following compiler error with touch is enabled using evdev
/usr/bin/ld: ./main.o: in function `main':
main.c:(.text.startup+0x74): undefined reference to `evdev_init'
/usr/bin/ld: main.c:(.text.startup+0x80): undefined reference to `evdev_read'
/usr/bin/ld: main.c:(.text.startup+0x90): undefined reference to `evdev_read'
collect2: error: ld returned 1 exit status
make: *** [Makefile:38: default] Error 1

Full Project is here for review
https://github.com/sukesh-ak/LINUX-LVGL-FRAME-BUFFER
Code for touch here

@Uup115 Can you share what you changed to make it working? I am in the same boat now. Using RPI OS Lite

The simplest route:

Start with the Linux port: https://github.com/lvgl/lv_port_linux_frame_buffer
Replace the two attached modified files:  main.c and lv_conf.h ( modification(s) are below commented line(s))
Edit the file:  /boot/config.txt and comment the line:  vc4-fkms-v3d

You can edit the appropriate make files to shorten build time.
Embedded GUI Using Linux Frame Buffer Device with LVGL.tar.gz

@Uup115 Can you share what you changed to make it working? I am in the same boat now. Using RPI OS Lite

@sukesh-ak   I think it's best to clone lvgl from the Linux port:
https://github.com/lvgl/lv_port_linux_frame_buffer
Kisvegabor already setup everything for Linux.  You can edit the make files as needed.

@Uup115
My sample project is a clone of that project itself with few changes.

Local lv_drv_conf.h is still old which does not have the latest SDL and other updates from drivers folder. So the latest is copied from drivers repo.

I removed the demos since that repo is deprecated and have a label+2 buttons inside main.c for testing. Display works already.

I will check the attached files and revert soon.

@Uup115 Looks like the file you attached only has display and not touch. Like I mentioned above display is already working.
I need help to get touch working.

I've have updated both the blog post and this rrepo.
It uses lvgl v8.2 (last release) but you can update to latest master without any issues.

Thank you @kisvegabor
Will test and revert soon.

@kisvegabor Thanks for the updates.
@sukesh-ak  Run evtest to find where your touchscreen is mapped.
In my case: /dev/input/event1.  This needs to be set in file:  "lv_drv_conf.h" @ line #397.
Be sure to #define USE_EVDEV   1 @ line #389.
In addition, I needed to #define EVDEV_CALIBRATE   1 @ line #400.
See attached "lv_drv_conf.h".
lv_drv_conf.h.gz
"

Any idea why this could be happening with colors?

@kisvegabor Thanks for the updates.
@sukesh-ak Run evtest to find where your touchscreen is mapped. In my case: /dev/input/event1. This needs to be set in file: "lv_drv_conf.h" @ line #397. Be sure to #define USE_EVDEV 1 @ line #389. In addition, I needed to #define EVDEV_CALIBRATE 1 @ line #400.
See attached "lv_drv_conf.h". lv_drv_conf.h.gz

Thank you @Uup115
Do you know why touch screen changes between event0 and event1 after reboot? How do I fix it?

Current status
evtest output
Available devices:
/dev/input/event0:      Goodix Capacitive TouchScreen

Display: working
Touch:
unable to open evdev interface:: No such file or directory
If I run like below, this error doesn't show up but touch doesn't work
DISPLAY=:0 ./demo
If I run evtest, it detects touch so hardware is fine.

Any idea why this could be happening with colors?
This happens if I use the instructions for Bullseye branch. Surprisingly, someone updated the Wiki page yesterday.
https://www.waveshare.com/wiki/2.8inch_DPI_LCD

As explained here:
Edit the file: /boot/config.txt and comment the line which has:  vc4-fkms-v3d

Have now reverted to Raspberry Pi OS Buster branch now, so that display works as expected.
How do I rotate the touch?
Tried enabling this but does not work.
#  define EVDEV_SWAP_AXES         1               /*Swap the x and y axes of the touchscreen*/

Have now reverted to Raspberry Pi OS Buster branch now, so that display works as expected.
How do I rotate the touch? Tried enabling this but does not work.
# define EVDEV_SWAP_AXES 1 /*Swap the x and y axes of the touchscreen*/

Maybe this (see comments):
#  define EVDEV_CALIBRATE         1   /*Scale and offset the touchscreen coordinates by using maximum and minimum values for each axis*/

#  if EVDEV_CALIBRATE
#    define EVDEV_HOR_MIN         0   /*to invert axis swap EVDEV_XXX_MIN by EVDEV_XXX_MAX*/
#    define EVDEV_HOR_MAX      4096   /*"evtest" Linux tool can help to get the correct calibraion values>*/
#    define EVDEV_VER_MIN         0
#    define EVDEV_VER_MAX      4096
#  endif  /*EVDEV_CALIBRATE*/

@Uup115
Yes I have already tried changing it. Its still won't swap.
I also tried
#  define EVDEV_SWAP_AXES         1               /*Swap the x and y axes of the touchscreen*/
Reviewing this now
https://github.com/lvgl/lv_drivers/blob/af07f57390ec50fb8cd2a52590141c2ab3ce6bee/indev/evdev.c#L112
Output of evtest. What should be the values of EVDEV_HOR_MIN etc?
  Event type 3 (EV_ABS)
    Event code 0 (ABS_X)
      Value      0
      Min        0
      Max      639
    Event code 1 (ABS_Y)
      Value      0
      Min        0
      Max      479
    Event code 47 (ABS_MT_SLOT)
      Value      0
      Min        0
      Max        4
    Event code 48 (ABS_MT_TOUCH_MAJOR)
      Value      0
      Min        0
      Max      255
    Event code 50 (ABS_MT_WIDTH_MAJOR)
      Value      0
      Min        0
      Max      255
    Event code 53 (ABS_MT_POSITION_X)
      Value      0
      Min        0
      Max      639
    Event code 54 (ABS_MT_POSITION_Y)
      Value      0
      Min        0
      Max      479
    Event code 57 (ABS_MT_TRACKING_ID)
      Value      0
      Min        0
      Max    65535

@sukesh-ak  Not sure.  This is the output when I touch my screen:
Event: time<PHONE_NUMBER>.433049, -------------- SYN_REPORT ------------
Event: time<PHONE_NUMBER>.441088, type 3 (EV_ABS), code 53 (ABS_MT_POSITION_X), value 1836
Event: time<PHONE_NUMBER>.441088, type 3 (EV_ABS), code 54 (ABS_MT_POSITION_Y), value 444
Event: time<PHONE_NUMBER>.441088, type 3 (EV_ABS), code 60 (ABS_MT_TOOL_X), value 1836
Event: time<PHONE_NUMBER>.441088, type 3 (EV_ABS), code 61 (ABS_MT_TOOL_Y), value 444
Event: time<PHONE_NUMBER>.441088, type 3 (EV_ABS), code 0 (ABS_X), value 1836
Event: time<PHONE_NUMBER>.441088, type 3 (EV_ABS), code 1 (ABS_Y), value 444
Event: time<PHONE_NUMBER>.441088, type 4 (EV_MSC), code 5 (MSC_TIMESTAMP), value 1336100

@Uup115 Thanks for the details.
I think there is an issue with hardware/driver itself.
Not sure how this gets fixed in the RPI Desktop UI.
Scenario:

OS: Raspberry Pi 64 Lite
Default : Portrait with top on the side of USB/Ethernet
No rotation applied in config
No touch configured

When display is in portrait (default), X max should be 480 and Y max should be 640. Isn’t it?
But as per output of evtest command, its switched. See below output
Output of evtest
Available devices:
/dev/input/event0:      Goodix Capacitive TouchScreen
Select the device event number [0-0]: 0
Input driver version is 1.0.1
Input device ID: bus 0x18 vendor 0x416 product 0x38f version 0x1060
Input device name: "Goodix Capacitive TouchScreen"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 59 (KEY_F1)
Event code 60 (KEY_F2)
Event code 61 (KEY_F3)
Event code 62 (KEY_F4)
Event code 63 (KEY_F5)
Event code 64 (KEY_F6)
Event code 125 (KEY_LEFTMETA)
Event code 330 (BTN_TOUCH)
Event type 3 (EV_ABS)
Event code 0 (ABS_X)
Value      0
Min        0
Max      639
Event code 1 (ABS_Y)
Value      0
Min        0
Max      479
I am working with Waveshare support to figure this out first.

This is how the touch cordinates from evtest looks like right now.
@kisvegabor
Is this supposed to fix it? Because I tried and it does not work. A bug?
#  define EVDEV_SWAP_AXES         1               /*Swap the x and y axes of the touchscreen*/

@sukesh-ak  Touch resolution isn't necessarily equal to the resolution of the display.  My display resolution is configured to 800x600.  Per evtest, the touch resolution is higher.  In my case, I use the following settings:
#  define EVDEV_CALIBRATE         1   /*Scale and offset the touchscreen coordinates by using maximum and minimum values for each axis*/

#  if EVDEV_CALIBRATE
#    define EVDEV_HOR_MIN         0   /*to invert axis swap EVDEV_XXX_MIN by EVDEV_XXX_MAX*/
#    define EVDEV_HOR_MAX      4096   /*"evtest" Linux tool can help to get the correct calibraion values>*/
#    define EVDEV_VER_MIN         0
#    define EVDEV_VER_MAX      4096
#  endif  /*EVDEV_CALIBRATE*/

I think we can close this since the original issue has been resolved.


[infra] Android SDK+NDK CIPD packages should follow the standard directory structure.

TL;DR: The CI bots have the Android sdk and ndk folders as siblings, and set ANDROID_SDK_ROOT and ANDROID_NDK_PATH. An env-var for the NDK is non-standard, and the standard location of the ndk directory is nested inside the sdk directory. We should update our DEPS and scripts to do the same.
Long version:
The Android SDK & NDK are installed through a CIPD package: https://chrome-infra-packages.appspot.com/p/flutter/android/sdk/all
The directory structure inside the package (for every OS) is the ndk and sdk directories as siblings.
Our infra sets the ANDROID_NDK_PATH env var https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/flutter_deps/api.py;l=341, and presumably we use this env var somewhere in our build (but I have not been able to find uses in flutter repos including the recipes).
When the Android SDK & NDK are installed on a users' machine through Android Studio or the SDK manager, the sdk directory contains the ndk directory. (Older SDK versions had an ndk-bundle directory.)
The official Android documentation makes no mention of using an environment variable for the NDK location: https://developer.android.com/studio/command-line/variables.html#envar
An online search reveals that project use conflicting env vars for the NDK: ANDROID_NDK_PATH, ANDROID_NDK_HOME, and ANDROID_NDK_ROOT. The latter seems the most common. But none of them is mentioned in the official Android documentation on recommendations.
https://github.com/flutter/flutter/pull/135148 adds logic for NDK discovery on top of the SDK discovery. Since there is no well defined env variable and the ndk is always nested as ndk/ inside sdk/ (old versions of the Android SDK can contain ndk-bundle instead of ndk), and we'd like to use an NDK belonging to the SDK we're using, we look for a nested ndk directory inside sdk.
This fails on our CI bots currently, because that ndk/ directory is not there. Our script for making the CIPD package explicitly moves the ndk directory out of the sdk directory:
  # Special treatment for NDK to move to expected directory.
  mv $upload_dir/sdk/ndk $upload_dir/ndk-bundle
  ndk_sub_paths=`find $upload_dir/ndk-bundle -maxdepth 1 -type d`
  ndk_sub_paths_arr=($ndk_sub_paths)
  mv ${ndk_sub_paths_arr[1]} $upload_dir/ndk
  rm -rf $upload_dir/ndk-bundle

https://github.com/flutter/engine/blob/c24f30343cf6506bda6a56b833e77461f299fd0c/tools/android_sdk/create_cipd_packages.sh#L118-L123
Changing the CIPD package to not modify the directory structure makes the tests on the above mentioned PR pass (log). (log of failing tests)
Changing the directory structure will likely require multiple changes:

The recipes to set up ANDROID_NDK_PATH correctly again (link).
The script to make the CIPD package (link).
Stuff that pops up when we making this change.

Many thanks to @godofredoc for helping me triage this! 🙇
@reidbaker Do you agree we should depend the ndk directory being inside the sdk directory in the discovery in lib/src/android/android_sdk.dart in https://github.com/flutter/flutter/pull/135148?
@GaryQian You have modified the mentioned lines in create_cipd_packages.sh. Would you happen to know why we have a non-standard directory structure? And any concerns about the above proposal?

Gary no longer works on flutter. @gmackall however might be who you intended to tag.

@zanderso do you know what would be the complexity of updating the engine build rules to use ndk from a nested folder in sdk?

The script that creates the package would need to be updated here: https://github.com/flutter/engine/blob/main/tools/android_sdk/create_cipd_packages.sh
After that, it's probably just a matter of updating paths like here https://github.com/flutter/buildroot/blob/master/build/config/android/config.gni#L81
and here
https://github.com/flutter/engine/blob/main/build/secondary/third_party/android_tools/BUILD.gn

@godofredoc Any progress? Or should I take a stab at this myself?

Update, sdk/ndk/ doesn't cover it correctly, it should be sdk/ndk/<version-number>/.

The script that creates the package would need to be updated here: https://github.com/flutter/engine/blob/main/tools/android_sdk/create_cipd_packages.sh

I'll take a stab at updating the script tomorrow.

The script that creates the package would need to be updated here: https://github.com/flutter/engine/blob/main/tools/android_sdk/create_cipd_packages.sh

https://github.com/flutter/engine/pull/47454

After that, it's probably just a matter of updating paths like here https://github.com/flutter/buildroot/blob/master/build/config/android/config.gni#L81
and here
https://github.com/flutter/engine/blob/main/build/secondary/third_party/android_tools/BUILD.gn

We'll need some conditional logic in there to find the version folder inside the sdk/ndk/xx.xxx/ (to avoid hardcoding the version number there and having to update the DEPS in tandem with that version number).
(@godofredoc pointed to a file in the recipes repo earlier, but that logic should have all been merged into the GN files.)

An investigation of our build files and helper scripts shows that we have quite many places where we have the paths hardcoded:

https://github.com/flutter/engine/blob/a47c721db226c4b57082ca5c389c73843f996f70/build/secondary/third_party/android_tools/BUILD.gn#L8-L14
https://github.com/flutter/engine/blob/a47c721db226c4b57082ca5c389c73843f996f70/ci/binary_size_treemap.sh#L25
https://github.com/flutter/engine/blob/a47c721db226c4b57082ca5c389c73843f996f70/sky/tools/flutter_gdb#L89
https://github.com/flutter/engine/blob/a47c721db226c4b57082ca5c389c73843f996f70/testing/scenario_app/run_android_tests.sh#L49
https://github.com/flutter/engine/blob/a47c721db226c4b57082ca5c389c73843f996f70/testing/analyze_core_dump.sh#L18

Moreover, the Flutter GN files import the Dart GN files:

https://github.com/flutter/engine/blob/a47c721db226c4b57082ca5c389c73843f996f70/build/secondary/third_party/android_tools/BUILD.gn#L5
https://github.com/dart-lang/sdk/blob/75c975fe6d964f08cf03fe13c63a5238f4a28865/build/config/android/rules.gni#L8
https://github.com/dart-lang/sdk/blob/75c975fe6d964f08cf03fe13c63a5238f4a28865/build/config/android/config.gni#L57

Which also hardcodes the ndk folder.
Flutter and Dart don't agree on the NDK version to build and test with. o, we can't change the path from ndk to sdk/ndk/22.x.xxxxxxx/. In Dart we are already on NDK 27.x.xxxxxxx, because we're testing Windows arm64 and RISC-V.
This makes me think the CIPD package was shuffling the directory structure for a good reason: To avoid the hassle in all places dealing with a dynamic directory that changes every version change and allow for running the build with different versions (e.g. the flutter build reuses Dart GN rules but uses a different NDK version).
So, maybe we should go back and reconsider flutter_tools checking if ANDROID_NDK_ROOT, ANDROID_NDK_PATH, or ANDROID_NDK_HOME  is provided, and only if these are not provided, try to find an NDK inside $sdkPath/ndk/xx.x.xxxxxxx.

Moreover, the Flutter GN files import the Dart GN files:

For the engine GN files that refer to the NDK and set up the Android build, I don't think they share any logic or import files from the Dart build. The build roots are separate. Did you actually run into any issues related to this?
Also, @reidbaker and will soon be conspiring to update the Engine's NDK version.

For the engine GN files that refer to the NDK and set up the Android build, I don't think they share any logic or import files from the Dart build. The build roots are separate. Did you actually run into any issues related to this?

Maybe I was misreading the GN files https://github.com/flutter/engine/blob/a47c721db226c4b57082ca5c389c73843f996f70/build/secondary/third_party/android_tools/BUILD.gn#L5:
import("//build/config/android/rules.gni")

This file doesn't exist in the flutter engine repo. I now see it exists both in the dart and buildroot repo. I hadn't noticed the latter earlier.
Okay, so we could modify the GN files between the Dart and Flutter repo independently.
That still leaves the question open if we would want to modify the the GN files on roles.

Also, @reidbaker and will soon be conspiring to update the Engine's NDK version.

That has already happened, it's at 34v3 instead of 33v6 now.

Also, @reidbaker and will soon be conspiring to update the Engine's NDK version.

That has already happened, it's at 34v3 instead of 33v6 now.

I think we might be referring to different things. Any more recent version of the NDK than the one we have now has some large changes to layout, and removes support for building with gcc, so I'm pretty sure that hasn't happened yet.

From my POV, https://github.com/flutter/flutter/pull/135148 is unblocked by relying on an env var that points to the NDK instead.
If it would gain us benefit to un-shuffle the NDK directory for other reasons, we can keep this issue open to track that work. If no-one wants to un-shuffle the directory structure, we can close this issue as wont fix.

I'm going to re-open this as it is a valid request independently of its relation to native asset support.
In particular, after https://github.com/flutter/flutter/pull/159756 lands, there will be a couple of cases where CI will need to download the NDK due to this abnormal structure. Fixing the structure would prevent these downloads.


fixed formatting for pep8

Thanks again for your work.
This PR fixes the formatting to comply to pep8 standard.

added unit-tests and some suggestions, hope this is helpful !
TODO:

unit-tests to check for wrong inputs with seqs_train


[LS] Allow import of Test contract

Issue To Be Solved
It is currently not possible to import the Test contract:

Context
https://github.com/orgs/onflow/discussions/1330

@m-Peter Would this maybe be part of the developer grant?

Duplicate https://github.com/onflow/cadence-tools/issues/98


Form submits even though input is marked Required

Challenge Waypoint: Use HTML5 to Require a Field has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/601.2.7 (KHTML, like Gecko) Version/9.0.1 Safari/601.2.7.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
<link href="http://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Click here for cat photos.

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

<form action="/submit-cat-photo">
  <input type="text" required placeholder="cat photo URL">
  <button type="submit">Submit</button>
</form>

Please describe what the problem is, and what you have tried

I tried putting required in various positions within the  tag, but it still submitted. This was only a problem when I tested it on the screen simulation on the right-hand side of the screen. When I clicked Cmd+Enter to run the tests, it was listed as correct.

If you are saying that it worked no matter where you put the 'required' it worked, that's fine, it's an attribute, so you can put it anywhere. But if you are saying something else, I still don't understand...

You're using Safari, which does not enforce the required attribute on submit. Safari is the new IE

Closing as @jbmartinez is correct that this is a Safari problem.

I'm sure that's it. Thanks!


Stable Giant Swarm Management Cluster for CAPVCD (guppy)

Story

As a Giant Swarm engineer, I want to have a stable Giant Swarm CAPVCD management cluster with alerts enabled in order to identify problems early and to always have a stable environment for demos.

Background
All the current CAPVCD management clusters are test environments. Alerts and etcd backups are disabled for them.
Resources
https://github.com/giantswarm/giantswarm/issues/24225.

installation on ikoula, with proxy

@vxav @glitchcrab do you know how can we block all internet access for a cluster?

One option would be to deploy the cluster on network-test-2 as the SNAT rule doesn't touch it and it is served by the squid proxy.
Do we need the installation to be behind the proxy if it is bound to be a permanent testing installation though?

Do we need the installation to be behind the proxy if it is bound to be a permanent testing installation though?

My understanding is yes. At the end of the day, our one prod cluster will be behind a proxy without internet access.

guppy is up&running. It will be seen by other teams after these PRs.

https://github.com/giantswarm/installations/pull/2090

Other teams can use the cluster after running opsctl login guppy.
After merging the PR in management-clusters-fleet, I will close this issue.

Guppy is working as a stable test cluster. Closing this issue.