Not working on Apple Silicon

Trying to send a notification on an M1 MacBook produces an error:
Error: spawn Unknown system error -86
    at ChildProcess.spawn (node:internal/child_process:416:11)
    at spawn (node:child_process:619:9)
    at Object.execFile (node:child_process:262:17)
    at Object.module.exports.fileCommandJson (/blah/blah/node_modules/node-notifier/lib/utils.js:83:13)

I suppose it comes down to the terminal notifier not having a native M1 build? I am not using Rosetta.

Confirmed

This is something that needs to be solved by dependency terminal-notifier I'm afraid.

https://github.com/julienXX/terminal-notifier did not receive any update in three years, it's unlikely they'll solve any issue. On the other hand this issue will likely gain thrust as Apple plan to migrate all of their computer to the M1 chip eventually.

isn't it only a matter of re-compiling it to support AS? terminal-notifier is listed as supporting AS in Homebrew, I am not sure if it's through Rosetta2 or native. I don't have Rosetta2 so I will install and see if it works.

My M1 does not have Rosetta2 installed and it's failing too.

any idea on how to fix this?

It might be enough to recompile terminal-notifier. I'm unable to test/fix as I don't have access to M1 at the moment. If anyone could investigate and submit PR that would be much appreciated.

The easiest way is certainly to recompile. But you could probably also execute the macOS notifier tool with Rosetta like this arch -x86_64 vendor/mac.noindex/terminal-notifier.app/Contents/MacOS/terminal-notifier

If you don't want to recompile yourself, and keep avoiding Rosetta you can also install terminal-notifier via brew and change the path in node_modules/node-notifier/notifiers/notificationcenter.js

https://github.com/julienXX/terminal-notifier seems to be dead, https://github.com/vjeantet/alerter seems to be a reasonably active fork

Hey guys,
any news on this issue? It's still not working on a M1 out of the box and @joeflateau is right, terminal-notifier looks not active at all.
The brew solution from @08-15at to avoid Rosetta works, is really good and easy, but modifying a file in node_modules/, for every project is not a real solution.

Running softwareupdate --install-rosetta fixes it for me.
(I ran that as part of installing Docker as per https://docs.docker.com/desktop/mac/apple-silicon/; since that appears to be a compatibility layer for older Mac binaries, I wondered if it might also fix this problem, and it seems to!)

Hi, would it be possible to update the terminal-notifier binary from the currently utilized version 1.7.2 to version 2.0.0? Besides being from 2017 and might not supporting every possible options on newer macOSs, this latest version at least runs on a M1 Mac without having to install Rosetta first.

Hey, original author of terminal-notifier here :wave: I feel your pain, as I was wanting to use this project in a build of ours, so I'm looking into picking up maintenance myself again and publish new code-signed releases. Will report back when I have an update.

@alloy I just cloned https://github.com/julienXX/terminal-notifier and simply built it with absolutely no changes and it seems to compile fine for arm64.
Any chance of just releasing an update with no code changes just to resolve this issue?
Thanks!
$ lipo -archs ./DerivedData/Terminal\ Notifier/Build/Products/Release/terminal-notifier.app/Contents/MacOS/terminal-notifier
x86_64 arm64

Any news on this? 😅

I was facing the same issue and running what @candu suggested with softwareupdate --install-rosetta seems to have solved the issue for me

Hi @alloy, Any Update on terminal-notifier. Is it possible to create a universal build for it

Just want to chime in here, brand new M3 Pro, ran into this setting up an active project on the new machine. This fixed it immediately 👇 Thanks @candu !

Running softwareupdate --install-rosetta fixes it for me.
(I ran that as part of installing Docker as per https://docs.docker.com/desktop/mac/apple-silicon/; since that appears to be a compatibility layer for older Mac binaries, I wondered if it might also fix this problem, and it seems to!)

Running softwareupdate --install-rosetta fixes it for me.
(I ran that as part of installing Docker as per https://docs.docker.com/desktop/mac/apple-silicon/; since that appears to be a compatibility layer for older Mac binaries, I wondered if it might also fix this problem, and it seems to!)

This is fixed for me. Thanks!

Looking for a simple fix that is not rosetta - as that creates as many issues as it solves

For now I'm using patch-package. From your project's root directory:
brew install terminal-notifier
npm i -D patch-package

Open node_modules/node-notifier/notifiers/notificationcenter.js and make the following changes and save:
-const notifier = path.join(
-  __dirname,
-  '../vendor/mac.noindex/terminal-notifier.app/Contents/MacOS/terminal-notifier'
-);
+const notifier = '/opt/homebrew/bin/terminal-notifier';

Your path may differ, and if so simply run which terminal-notifier to find your own path to the binary file.
Then again from your project's root directory:
npx patch-package node-notifier

Then update your package.json:
 "scripts": {
+  "postinstall": "patch-package"
 }

Commit everything including the new patch file and you'll be all set for future npm install thanks to the postinstall.
Instructions above will be slightly altered if you're using yarn, just check the patch-package docs as they're pretty easy for those adjustments.
You may also choose to not add the postinstall script and instead rename it so that it must be manually run by only those who are affected by this change. We're only using it during local development and our team are all in devices with Apple Silicon, so it works for us for now, but YMMV. This is a band-aid, but at least a convenient one.

I have access to an Intel Mac and an M2 Mac without Rosetta installed and running the examples with the commands node example/macInput.js, node example/advanced.js, and node example/message.js work as expected and all tests pass on both machines with the changes in pull request #441. That pull request fixes the issues for people with Apple Silicon Macs that don't have Rosetta installed.

Thanks for your comment @TrevorSayre this worked for me.


Update kicad for OSX to r5572 nightly binary.

Kicad for OSX now has nightly build binaries uploaded to kicad-pcb.org. This cask installs the latest binary as well as the necesssary Application Support folder.

Closes #904.


[vulkan] Assertion in tir/transforms/lower_thread_allreduce.cc", line 157   TVMError: Check failed: v:

Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discussion, roadmaps, and bug tracking.  You are always welcomed to post on the forum first :)
Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed.
For bug reports, to help the developer act on the issues, please include a description of your environment, preferably a minimum script to reproduce the problem.
For feature proposals, list clear, small actionable items so we can track the progress of the change.
Hit assertion in vulkan target.  Other targets might have the same issue as well.
File "/home/mye/main/incubator-tvm/src/tir/transforms/lower_thread_allreduce.cc", line 157
TVMError: Check failed: v:
repro.zip

I have encounted the same problem.
It's triggered by 7b74a8672e1e40e7541c0007d8628586c62277e8, as vulkan use some cuda codes in topi.  Forcing the sched_warp_softmax  (in topi/python/topi/cuda/softmax.py) to return false could bypass the problem.
The root cause of the problem seems that MakeAllreduce mistakenly assume the fourth arg should be a var node, as the var node might be replaced by a constant node in the simplify optimization.

Thanks @majiang31312  please let me know if you would like to attempt a fix. cc @kazum @wpan11nv @yongfeng-nv @roastduck

I'm new to TVM, but I will have a try :)
Thanks! @tqchen

This sounds similar to me to the symptoms discussed in the recent posts in #5600.
So quite likely, making the cuda softmax schedule specific to cuda would fix this. Of course, implementing shuffle reductions where they exist is the alternative...
I'm not entirely sure how to improve the error message (because the root cause is that warp shuffle reductions are not supported on the target).

The fix seems quite simple, but I'm not sure whether it's complete.
Please take a look at the Discussion section. Thanks! @tqchen @wpan11nv
Problem:
when num_thread = 1 (that's the case for vulkan as CreateTarget in target.cc set thread_warp_size to 1),
'
ko, ki = s[B].split(B.op.reduce_axis[0], factor=num_thread)
s[B].bind(ki, te.thread_axis("threadIdx.x"))
'
will triger "TVMError: Check failed: v:" in MakeAllreduce.
when factor=1, simplify optimization replace the IterVar with a constant node, but MakeAllreduce want a var node.
Reproduce:
import tvm
from tvm import te

n, m = 32,32
num_thread = 1
A = te.placeholder((n, m), name='A' ,dtype = 'int8')
k = te.reduce_axis((0, m), "k")
B = te.compute((n, ), lambda i: te.sum(A[i, k], axis=[k]), name="B")

s = te.create_schedule(B.op)
ko, ki = s[B].split(B.op.reduce_axis[0], factor=num_thread)
s[B].bind(ki, te.thread_axis("threadIdx.z"))

#target = tvm.target.create("vulkan")
target = tvm.target.create("cuda")
s = tvm.lower(s, [A, B])
s = tvm.tir.transform.Apply(lambda f: f.with_attr("target", target))(s)
s = tvm.tir.transform.Simplify()(s)
print(s)
s = tvm.tir.transform.LowerThreadAllreduce()(s)

Fix:
--- a/src/tir/transforms/lower_thread_allreduce.cc
+++ b/src/tir/transforms/lower_thread_allreduce.cc
@@ -154,9 +154,17 @@ class ThreadAllreduceBuilder final : public StmtExprMutator {
std::unordered_set<const VarNode*> reduce_set;
for (size_t i = 2 + 2 * size; i < call->args.size(); ++i) {
const VarNode* v = call->args[i].as();

 CHECK(v);

 reduce_set.insert(v);

 // The simply optimization replace a iteration variable with a constant

 // when extent of the iteration is 1. As threaded IterVar always started from 0,

 // we can just ignore this variable in this case.

 if (v) {

   reduce_set.insert(v);

 } else {

   CHECK(call->args[i].as<IntImmNode>() && call->args[i].as<IntImmNode>()->value == 0)

     << "arg" << i << "should be a VarNode or IntImmNode";

 }

}
size_t nmatch = 0;
std::vector vred, vpar;
for (const AttrStmtNode* attr : thread_extents_) {
@@ -170,6 +178,11 @@ class ThreadAllreduceBuilder final : public StmtExprMutator {
const auto* ptr = attr->value.as();
CHECK(ptr) << "Need constant extent for reduce set " << iv;
e.extent = static_cast(ptr->value);

   // ignore variables equal to 0

   if (e.extent == 1) {

     continue;

   }

   if (reduce_set.count(iv->var.get())) {
     vred.push_back(e);
     ++nmatch;

Discussion:
At this moment threaded IterVar always started from 0, so we can safely ignore the const var node.
Maybe we could keep a record somewhere after we replace a VarNode with a IntImmNode? I thinks that would help to deal with such kind of cases more clearly.
By the way, the 'analyzer_.Simplify' in BufIndex can not work as expected. It looks like that the analyzer have not been initilized properly. I can provide test cases if someone want to take a look.

@t-vi Thanks for the advice.
In my opinion this is not a backend problem, we can triger it in the cuda backend (my test case above is using cuda).

@mei-ye Cool! Yes. I ran into trouble when the target info erroneously specified 1 thread per warp for ROCm, which would look similar but not for the same reason. I'm glad you found the complementing fix.

https://github.com/apache/incubator-tvm/pull/5726

I do think there is a bug still to be fixed even if it is not currently triggered by the schedules, i.e.
@majiang31312 's analysis looks very plausible and I can reproduce the assertion with the demo.

@majiang31312 can you please followup with another pr :)?

@majiang31312 can you please followup with another pr :)?
Hi @tqchen, do you mean #5726?
I'm strongly agree with @t-vi  that this problem(5686) should be fixed separately. This problem is not related to any specific backend. In my opinion, it's just a misunderstanding in MakeAllreduce that impose a overstrict assert.

@majiang31312 that sounds good, can you send a PR with your proposed fix?

@majiang31312 that sounds good, can you send a PR with your proposed fix?

Thanks, I have create a PR for the fix.


[ConstraintSystem] Downgrade some invalid specialization uses to a warning until Swift 6 language mode

Some invalid specializations were previously allowed by the compiler
and we found some existing code that used that (albeit invalid) syntax,
so we need to stage that error as a warning until Swift 6 language mode
to avoid source compatibility break.
Resolves: rdar://134740240

@swift-ci please test


Taking Sanskrit 101-107 doesn't satisfy a BSE Foregin Language distribution.

Describe the bug
After adding SAN 101 to Fall 1, SAN 102 to Spring 1, SAN 105 to Fall 2, and SAN 107 to Spring 2, the Foreign Language distribution still has a 0, even though SAN 107 should fulfill it.
To Reproduce
Steps to reproduce the behavior:

Go to TigerPath.
Choose a BSE major in Settings.
Add SAN 101, SAN 102, SAN 105, SAN 107 to the schedule as described previously.
You should see that Foreign Language is still yellow and has a 0.

Expected behavior
Foreign Language should have a 1 and turn green.
Screenshots

Desktop (please complete the following information):

OS: Windows 10 Version 1909 Build 18363.959
Browser Firefox 78.0.2
Major COS (BSE)

Additional context
None.

Thanks for pointing this out, @pranavavva!
You're right, that must have been an oversight.
Let me try to push a fix for it.

Hi @pranavavva. I've now opened pull request #358 which should hopefully fix this once it's merged in.

Alright, it should hopefully be fixed now. Try refreshing the page, and maybe removing and then re-adding the courses, and see if it now appears under the language requirement.
If not, then let me know!
Thanks again @pranavavva for pointing this out!

Awesome! The foreign language requirement is coming up as green as expected. But now upper-level SAN courses (SAN 300/303) is showing up twice. I can choose to settle them under the LA or foreign language distributions, but when I settle them under LA, it is coming up double in the Seven Total Courses.
I think the logic here is probably similar to how departmentals (at least for COS BSE) can be settled under either a specific category (for example Systems) or General. I believe the bug is coming from how total courses are counted.
See screenshot:

@bnehoran sorry for the ping, not sure if you saw this

@pranavavva Thanks for the update!
As for courses counting twice under the "Seven Total Courses", I think I know why this is happening. It's a separate problem with how that requirement is currently evaluated.
What it's doing at the moment is adding up the courses that could satisfy each of the "Humanities and Social Sciences" categories, and then summing up those subtotal, which fails when a course like this falls into multiple categories.
I expanded this out into a new issue at https://github.com/TigerPathApp/tigerpath/issues/359 so that it's easier to keep track, and since it's a different problem than the one from this issue.
Let me see if I can find a good way to fix it.
I see that you have programming experience, by the way, so if you would like to help out with this, just let me know and I can try to familiarize you with the relevant parts of the code!

I would love to help! I am learning React/Node, but I'm not too familiar with Python and Django, but I'm totally willing to learn!

Awesome! I would be happy to help you out!
The changes to fix this issue (with some courses counting twice for the "Seven Total Courses") will probably involve mainly editing python and json/yaml code, as it's mostly dealing with how the BSE requirements are encoded into a file as well as how they are interpreted.
If you are interested, you might want to take a look at the documentation here, which explains how the requirements files are structured, and what the different parts mean.
The BSE requirements, specifically, are located in this file.
The interpretation of requirement files (that is, the actual evaluation of the logic encoded in them, as well as the decisions of what gets displayed in the requirements tree panel on the right of the app) occurs in verifier.py, but the logic here is a bit complex so I wouldn't get too buried in it.
We should probably continue the discussion about this on the page I opened for the issue, https://github.com/TigerPathApp/tigerpath/issues/359, just to keep things organized. But yeah, I would be happy to help you out!
If you'd like to do something specifically with React or Node, you might consider taking a look at some of the other open issues we have, especially some further down the list which deal with UI and user data related features and updates. If you want me to help point you to some that would be relatively easier for a first-time contribution, let me know!


Customers without policies

Steps to reproduce
The customers without device compliance policies and configuration profiles is including customers that have one or both.
Expected behavior
The tables only contain the customers that do not have either.
Actual behavior
All customers are being included; this is being caused by the filter applied to the relationship should filter both directions.
Diagnostic logs
N/A
Environment

Windows 10
Power BI Desktop
SecMgmtInsights version 1.2

The work to address this issue has been completed. It will be available with the release of version 2.0


Decrease bundle size

I've been running some bundle analyzers in the code to see what we can change to decrease the bundle size:

There is a lot of room for improvements, I'll use this issue to list my findings and track my progress

[x]  remove lodash.uniqBy
[x]  remove lodash.isequal
[x]  remove lodash.merge
[x]  remove lodash.once
[x]  remove lodash.isplainobject
[x]  remove lodash.result
[x]  figure out where this buffer module is coming from
[ ]  remove the process polyfill
[ ]  use babel-preset-env to improve our babel pipeline and avoid unnecessary polyfills
[ ]  test CommonsChunkPlugin for multiple bundles and async load of big dependencies
[ ]  try to remove clappr-zepto 🔥
[ ] use module field in package.json to es6 version of the code
[ ] only export plugins in the main and dont require all in the Loader
[ ] remove white spaces from template/css code

current bundle size is 521kb

The "main" property in package.json of clappr-zepto module is pointing to zepto.min.js. Maybe it worth a try to change the value to zepto.js and try to rebuild Clappr to see if it reduce size of bundle minified by uglifyjs.

@thiagopnts
Another idea is to add a release job to make a "light" version of Clappr which excludes FlashLS, as probably the majority of developers using Clappr don't even need Flash support at this point in 2017. (At least I hope so)
I have a fork of Clappr on my GitHub profile where I stripped out FlashLS entirely. See commit: https://github.com/michaelcunningham19/clappr/commit/a00b12ea0c27dbd5011f1b134a6bc2d2ea196f2e
The change resulted in a decent decrease in file size, which I will add here when I can! :)
If this sounds like a good idea I will gladly look into opening a PR to support a "light" build
Worth noting that hls.js also has a "light" build that they recently added: https://github.com/video-dev/hls.js#dependencies

@michaelcunningham19 I'm working on this here https://github.com/clappr/clappr/tree/skinny-clappr
it has a ~175kb light version


Allow time to equal zero

On machines with low-res clocks, cells that run really quickly may have a runtime of zero which causes AssertionError to raise incorrectly. Protect only against negative times instead.

Doh. I see #2 now which fixes this.


Add : Tag duration in AnyTag

Hi @RodolpheThienard, fyi I forked the project (to martpie/rust-audiotags2) and incorporated your changes. I emailed the maintainer, and if I don't receive any news in the next days, I'll publish the updated crate.

These changes - I believe - were merged back today from audiotags2 :partying_face:
https://github.com/TianyiShi2001/audiotags/pull/18
I will publish crate as 0.4.0 soon -
Can you do a favor and run tests off git main if you have some manual tests you would like to try ?
Too bad I can't add the status as Merged when round trip from audiotags2 re-merge


Add method Elements.before(Node node)

Hello,
We can made Element.before(Node node), Element.before(String html) and Elements.before(String html) .
Is it possible to add Elements.before(Node node) ?
Actually, I need to do myElements.before(myElement.outerHtml()) which isn't really pretty...
Regards,
Anael

Hi -- can you describe your use case or show an example? Just want to make sure I understand the request completely.

Hello,
I found an element an the webpage. (eg "Warning : remote link")
I want to insert it before all div[class=specific]  elements.
I need to output my element to HTML to add it before each selected div.
IMHO, it could be great to insert it as an element (and don't needing to put it on html)
Regards,
Anael

I am trying to do likeElements to solve it

Should do this for before, after, prepend, append, to match the Elements string methods.


making single node install, upgrade/rollback, backup/restore clearer

https://github.com/rancher/docs/issues/664


Added missing 'python' directory under examples/vanilla/sdk for prope…

…r Python code generation of tdldk using monolithe.

Wow, I completely missed the notification about this PR. Sorry about that.
I think I fixed the issue today, but thanks anyway :)

Hi Antoine,
No worries, I just wanted to make an early contribution to the Monolithe project J
I am planning to submit the first version of the java plug-in (code generator) for Monolithe next Thursday (March 10). I have also written a java version of the sample program (originally in Python, the one located under monolithe\examples).
Do you have a suggestion as to where I could put the (Java) source code of the sample program along with the Maven script to build it?
Thanks,
Martin.
From: Antoine Mercadal<EMAIL_ADDRESS>Sent: March 3, 2016 3:10 AM
To: nuagenetworks/monolithe
Cc: martin-leclerc
Subject: Re: [monolithe] Added missing 'python' directory under examples/vanilla/sdk for prope… (#6)
Wow, I completely missed the notification about this PR. Sorry about that.
I think I fixed the issue today, but thanks anyway :)
—
Reply to this email directly or view it on GitHub https://github.com/nuagenetworks/monolithe/pull/6#issuecomment-191644601 .  https://github.com/notifications/beacon/APGZ0l29XR1NzCytYXxywyUdTiDlYrlVks5pppc-gaJpZM4HjvD4.gif

Do you plan to create an external plugin or to embed it in the monolithe's internal lang package (like Go, Python and HTML)?

The code for the java code generation is currently embedded in the Monolithe codebase, the main reason being that I started working on it week ago (i.e. prior to the introduction of the plug-in framework).
Would you rather suggest packaging it up as a separate plug-in?
Martin.
From: Antoine Mercadal<EMAIL_ADDRESS>Sent: March 3, 2016 5:45 PM
To: nuagenetworks/monolithe
Cc: martin-leclerc
Subject: Re: [monolithe] Added missing 'python' directory under examples/vanilla/sdk for prope… (#6)
Do you plan to create an external plugin or to embed it in the monolithe's internal lang package (like Go, Python and HTML)?
—
Reply to this email directly or view it on GitHub https://github.com/nuagenetworks/monolithe/pull/6#issuecomment-192002049 .  https://github.com/notifications/beacon/APGZ0hoFMd6_SCaVelY0wWDc4F3xtJNtks5pp2RSgaJpZM4HjvD4.gif


cgroups v2 silently breaks kubevirt

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What happened:
VMIs get stuck on "Scheduled", and the pods backing the VMI keep restarting, with no error message.
The virt-handler errors out with "Could not detect slice of whitelisted controller: [devices]"
What you expected to happen:
VMs just work.
How to reproduce it (as minimally and precisely as possible):
Run kubevirt using cri-o on systemd with unified cgroup hierarchy enabled (as is default in multiple distros), and try to run any VM.
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version): v0.37.0
Kubernetes version (use kubectl version): v1.19.7
VM or VMI specifications: Any.
Cloud provider or hardware configuration: almost-plain qemu on AMD.
OS (e.g. from /etc/os-release): NixOS 21.03pre-git.
Kernel (e.g. uname -a): 5.4.86
Install tools: kubeadm, and manual kubectl apply
Others:

@puckipedia thanks.

@puckipedia thanks.

@vasiliy-ul would that be something you would be interested to look into?

@vasiliy-ul would that be something you would be interested to look into?

@rmohr , frankly speaking I've already briefly looked at the issue :) Fixing the slice detection error is rather simple. Though with cgroups v2 a new files hierarchy is introduced and AFAIK there are several places in Kubevirt that potentially may not work with v2. IMHO its probably worth decoupling cgroups handling into a separate utils package. Additionally I guess it will require adjustments in CI to test with both versions. But supporting v2 in Kubevirt is definitely needed. Sooner or later v1 may be droped.
Anyway, sure, I can look into the issue. I can assign it to myself then...
/assign @vasiliy-ul

@rmohr , frankly speaking I've already briefly looked at the issue :) Fixing the slice detection error is rather simple. Though with cgroups v2 a new files hierarchy is introduced and AFAIK there are several places in Kubevirt that potentially may not work with v2. IMHO its probably worth decoupling cgroups handling into a separate utils package. Additionally I guess it will require adjustments in CI to test with both versions. But supporting v2 in Kubevirt is definitely needed. Sooner or later v1 may be droped.
Anyway, sure, I can look into the issue. I can assign it to myself then...
/assign @vasiliy-ul


Do not build for Windows

Windows is unsupported, we use wsl instead now

I agree with this, it's better to focus in WSL on windows for now


K8SSAND-1530 ⁃ Add DSE/OSS Cassandra validation for CDC configs

What is missing?
The first iteration of the CDC reconciliation logic doesn't take account of the fact that DSE deployments won't support CDC until the CDC agent is built into a DSE image.
We should provide validation through either/both of:

The validating webhook.
The reconciliation logic itself.

When CDC is requested for a DSE deployment this is an error.
Why do we need it?
DSE deployments currently use the official DataStax DSE images. As of now these do not include the CDC agent and attempts to enable CDC in these images will cause DSE to fail to start.
┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1530
┆priority: Medium

This is no longer valid.


Performance improvements and bug fixes

Improved performance by parallelizing the receiver side.
Fixed a crash and some odd behavior when receiving improperly formatted messages from other stations.

Coverage decreased (-0.3%) to 41.491% when pulling e9ab9b7c042f9249b7d53b3b59e049cc50e084c1 on Zeverin:master into ea3142b88437fa2d7b055f2ed76a49a8beea254d on alexvoronov:master.


Listener called multiple times

Platform

[ ] Web
[x ] iOS
[ x] Android

Describe the bug
I integrated Stripe Capacitor library in my Ionic Angular App. I registered listeners in order to call my server when payment completed.
I register listeners when the user enters the checkout page.
If the user goes to the checkout page but then thinks better of it and goes back to another page in the app, I would like to destroy the listeners.
If the user returns to the checkout page, I create new listeners.
When the user finalizes the payment, there are N listeners listening.
how can I solve it? I would like to use the ngOnDestroy method but how do I destroy the listeners?

The listener can remove by using remove(). ex: https://github.com/capacitor-community/stripe/blob/main/demo/angular/src/app/sheet/sheet.page.ts#L165
This is not plugin issue. please check capacitor docs.


Code Appears next to the Headers in the Print Version of the Page

Example collapsible panel appears "nel (#02-content-containers-03-collapsible-panel)" next to the title, in the print version when Ctrl+P is pressed.

Link
https://swiss.github.io/styleguide/en/content-containers.html#02-content-containers-03-collapsible-panel
Chrome

It's a feature, not a bug.
In print mode a CSS rule is applied to all links (not only headers) to display the target of the link.


Class 'Sentinel' has no instance getter 'pauseEvent'

Running the service tests via kernel (via command python tools/test.py -mrelease -cdartk --use-standalone-dartk --no-tree-shake service) yields lots of "Class 'Sentinel' has no instance getter 'pauseEvent'" errors (among more kernel-specific errors).
This happens semi-randomly, and only (at least for me) when running all the tests (via command above), i.e. not when running a single test.
What seems to happen is this:

The vm isn't quite done loading
The test framework asks about the vm (getVM)
getVM responds with, among other things, an isolate id
the test tries to fetch the isolate via the id, but in sdk/lib/vmservice/running_isolates.dart, class RunningIsolates, it goes into the if (isolate == null) case (and returns Sentinel) because RegisterRunningIsolatesVisitor::VisitIsolate (vmservice.cc) hasn't yet been run, i.e. the isolate hasn't yet been registered via _registerIsolate (passing to isolateStartup in running_isolates.dart).

Normally, the isolate is registered before getVM is called and stuff is fine, but sometimes it goes as above.
This seems to have started with f679b3c3e53bac92df6136eceb56a5febe576819, though it seems to me it's a timing issue and the mentioned commit only changed the timing slightly (and thus isn't really to blame).
(btw the ugly hack of inserting something like "await new Future.delayed(const Duration(seconds: 1));" in observatories service/object.cc, _fetchDirect, after "await listenEventStream(_kGraphStream, _dispatchEventToIsolate);" seems to be enough to "reskew" the timing back in our favor, but is hardly a solution...

Problem goes away with 65e5de9a4291dc496dae1b7ff279f1891997d84d.


Instantiating scenes is not always thread-safe

Godot version
3.5.stable
System information
not relevant
Issue description
the godot docs says that instantiating scenes is thread-safe:
https://docs.godotengine.org/en/3.5/tutorials/performance/threads/thread_safe_apis.html#scene-tree
this is true for the most part, but there's specific exceptions, 2 that i know of
the 1st exception is if one of the nodes in the scene has an attached script with an _init function that does something that isn't thread-safe (like adding to the scene tree for example)
this should already be obvious to the user of course, because that's their own doing, so i think there's no issue there
however, what's not obvious is the 2nd exception, which is that godot has a few nodes that are unsafe to create in a thread:
AudioStreamPlayer
AudioStreamPlayer2D
AudioStreamPlayer3D
in the constructors of these nodes, they connect a signal, which is not thread-safe:
https://github.com/godotengine/godot/blob/338114d47154298cc96bb3098653bb3db3943457/scene/audio/audio_stream_player.cpp#L423
https://github.com/godotengine/godot/blob/338114d47154298cc96bb3098653bb3db3943457/scene/2d/audio_stream_player_2d.cpp#L530
https://github.com/godotengine/godot/blob/338114d47154298cc96bb3098653bb3db3943457/scene/3d/audio_stream_player_3d.cpp#L1032
it doesn't seem to be documented anywhere that it's not thread-safe to create these nodes or to instantiate a scene that contains these nodes
also, these nodes seem to be the only thing that prevents the instantiating of scenes from being completely thread-safe, so i wonder if it's really necessary that those connections are made in their constructors (which afaik is unusual)
could they instead be connected when they enter a tree? or deferred to the main thread?
but if it's actually necessary to be connected in the constructor, then shouldn't the docs say that it's not thread-safe to create those nodes?
it's completely unclear to me if this is an oversight of the nodes or an oversight of the documentation

also yes i know there's the related issues #34752 and #77518
but #34752 is about how connecting signals is not thread-safe
and #77518 is about a consequence of this issue
this issue is about if 3 certain nodes should or should not be thread-safe to create in the first place
i am NOT asking for a solution/workaround for safely instantiating a scene that contains these nodes
(it's not relevant and i already know how to do that)
Steps to reproduce
there's nothing to reproduce
Minimal reproduction project
N/A

As I mentioned on https://github.com/godotengine/godot/issues/34752#issuecomment-1564596292 this applies in 4.x as well, and this is arguably a duplicate of that issue

As I mentioned on #34752 (comment) this applies in 4.x as well, and this is arguably a duplicate of that issue

i don't see this as a duplicate issue since it doesn't appear to be necessary that creating these nodes is not thread-safe
it's definitely related, and if that issue is fixed somehow, then this issue would also be fixed, but this issue seems like it can be resolved independently from that
though again, i'm not 100% sure what the side-effects would be since it's not clear to me if it's actually necessary or not that the bus_layout_changed signal is connected in the constructor

not sure if this is still a thing in godot 4 (definitely still is in godot 3)

nvm im blind, should still be an issue in the current version
https://github.com/godotengine/godot/blob/691d8bee2bdc316da32c7137783864a25c1ad674/scene/audio/audio_stream_player_internal.cpp#L351-L360
should it just be mentioned in the documentation that it's not thread-safe to instantiate any scene that contains an audiostreamplayer/2d/3d node?


Feat: Make PluginConfig namespace configurable

As noted down in the internal repository by @IvoGoman:
With the current implementation all Plugins will be installed into the Greenhouse managed namespace within the remote clusters.
In order to have a more granular setup and to avoid a "mono-namespace" it should be possible to provide a namespace with the PluginConfig. To ensure that no helm releases are left-behind this namespace should be immutable and defaulted to the Greenhouse managed namespace.

Summing up the discussion:

Introduce an immutable $PluginConfig.spec.namespace field forcing potential backend components to be installed in the specified namespace in the remote cluster.
Stick with Helm behavior to only create the namespace in the remote cluster in case it doesn't exist
Only fully manage the  namespace in the remote cluster
Document the  namespace and behaviour

Would a minimal implementation be feasible short-term @IvoGoman?
We're currently onboarding the cluster with plugins that are hard to migrate without downtime (ingress controller).


Azure Container Apps docs deep link to using Azure.Identity with a user-assigned identity is broken

https://learn.microsoft.com/en-us/azure/container-apps/managed-identity?tabs=portal%2Cdotnet#tabpanel_3_dotnet has a Access Azure service with a user-assigned identity broken link that should instead point to https://learn.microsoft.com/dotnet/api/overview/azure/identity-readme?view=azure-dotnet#specify-a-user-assigned-managed-identity-with-defaultazurecredential
It might also be good for the Containers Apps docs to call out that users need to set the Entra Client ID for a user-assigned managed identity.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1bae7356-5237-f004-16e8-3f89b1dfeac6
Version Independent ID: 841a9a04-8bc8-8bfd-a57d-f57945829a66
Content: Managed identities in Azure Container Apps
Content Source: articles/container-apps/managed-identity.md
Service: container-apps
GitHub Login: @v-jaswel
Microsoft Alias: v-wellsjason

@tg-msft
Thanks for your feedback! We will investigate and update as appropriate.

I apologize for the delay. I've merged a PR to resolve the broken link:
https://github.com/MicrosoftDocs/azure-docs-pr/pull/260844
Regarding: "It might also be good for the Containers Apps docs to call out that users need to set the Entra Client ID for a user-assigned managed identity."
The doc does say:
https://learn.microsoft.com/en-us/azure/container-apps/managed-identity?tabs=portal%2Cdotnet#add-a-user-assigned-identity
"Configuring a container app with a user-assigned identity requires that you first create the identity then add its resource identifier to your container app's configuration."
After that, the Azure Portal/Azure CLI/ARM Template/YAML tabs show how to do that.
I'm not familiar with Entra ID yet, so if I've misunderstood the issue, please don't hesitate to ping me.

Thanks for your feedback and your contribution to Azure docs.
Feedback for this repository is moving away from GitHub to a system specific to the Microsoft Learn platform. Issues for this repository will soon be disabled, and additional comments from GitHub will no longer be possible. However, we are now tracking and triaging this issue in the new feedback system.
To learn more about our feedback systems, please see Provide feedback for Microsoft Learn content.
#please-close


Add @Feature annotation with categories

Eventually yes, but I'd like to keep that as a separate activity.  After
this PR, I want to have some generated NAMED_CONSTANTS for the categories
to prevent string typos, etc...  Similar to the error categories! All just
staging steps to the eventual goal...
On Thu, Jan 26, 2023 at 1:35 PM John R @.***> wrote:

@.**** commented on this pull request.
In
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java
https://github.com/faucetsdn/udmi/pull/566#discussion_r1088363203:

@@ -198,7 +198,7 @@ public void endpoint_connection_success_alternate() {

@Test
@Description("Restart and connect to same endpoint and expect it returns.")

@FeatureStage(PREVIEW)

@Feature(stage = PREVIEW)

I meant should we fill in category values that Nour is generating. But we
can revisit this when we settle the enums, too.
—
Reply to this email directly, view it on GitHub
https://github.com/faucetsdn/udmi/pull/566#discussion_r1088363203, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEPD5T65JYGOLVYTJQBWTWULU3RANCNFSM6AAAAAAUGKQZQQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Using UnitOfWork with UnitOfWorkAwareProxyFactory when creating json on the resource does not work anymore

Hello,
In version 1.3.12 of Dropwizard we used a class that is created with UnitOfWorkAwareProxyFactory.
The return of one of our resources had a variable that is an instance of this class and that during the creation of the response in JSON saved some data in the database via hibernate.
We are migrating to Dropwizard 2.0.2 and we had a problem with that, UnitOfWork tries to use the same transaction as the resource due to the new code implemented
and therefore throws the error due to the code
if (unitOfWork.transactional ()! = (txn! = null && txn.isActive ())) {
    throw new IllegalStateException (String.format (
        "Existing session transaction state (% s) does not match requested (% b)",
        txn == null? "NULL": Boolean.valueOf (txn.isActive ()),
        unitOfWork.transactional ()
    ));
}

Because the resource transaction is no longer active and we have the response "Unable to create json".
This worked perfectly in version 1.3.12
I saw that this new code was created at https://github.com/dropwizard/dropwizard/pull/2913
How should I act in such a case?
Is it a bug in the new version?
We are doing something wrong?

@irineuruiz I'm willing to look at your code - could you provide a minimal, runnable, selfcontained sample, that reproduces your problem?

unitOfWork.zip
In this zip I have a simple case, of course this case can be done without the Supplier, but we have a very more complex case in our system...
CREATE TABLE public.tb_person
(
id integer NOT NULL,
firstname text,
CONSTRAINT pk00_tb_person PRIMARY KEY (id)
)
WITH (
OIDS=FALSE
);

Correction: These are not interleaved, but serial transactions. This looks like a dangerous setup - my take on this:
@UnitOfWork starts a session and optionally a transaction. The transaction is committed/rolled back on the return from the @UnitOfWork method, the session is kept open. The code reads (UnitOfWorkAspect#afterEnd):

// We should not close the session to let the lazy loading work during serializing a response to the client.
// If the response successfully serialized, then the session will be closed by the onFinish method

That means, that lazy loaded data is initialized in a different/outside a transaction. It also contradicts the documentation (https://www.dropwizard.io/en/latest/manual/hibernate.html):

The Hibernate session is closed before your resource method’s return value (e.g., the Person from the database), which means your resource method (or DAO) is responsible for initializing all lazily-loaded collections, etc., before returning. Otherwise, you’ll get a LazyInitializationException thrown in your template (or null values produced by Jackson).

@joschi @artem the comment above referenced above was introduced with 7590203f13fb5d728ae6de1946643e4f06361c9a
I agree with the documentation - it is dangerous and badly specified what gets returned if a lazy collection is returned from a different transaction and here we see the fallout.
I have an idea for a fix: Currently the implemented behavior of @UnitOfWork is: If conflicting transactional values are found in the @UnitOfWork annotations an Exception is raised. Hypothetical call sequence:
(1) UW1-Enter (transactional=true)
(2) UW2-Enter (transactional=false)
(3) UW2-Leave (transactional=false)
(4) UW1-Leave (transactional=true)

Currently an exception is raised at point (2).  The problem described here results from this sequence:
(1) UW1-Enter (transactional=true)
(2) UW1-Leave (transactional=true)
(3) UW2-Enter (transactional=true)
(4) UW2-Leave (transactional=true)

At point (3) an exception is raised - the reason is, that a session is created at point (1) and a transaction is started, at point (2) the transaction is committed. Now the interceptor at point (3) finds the session created at point (1) (which we can't close yet because we want to enable lazy loading), detectects, that is not in an transaction and raises the exception, because  a transaction is required.
If transactional=false is interpreted as "can be run without transaction, but can join one" (compareable to "Supports" container managed persistency), we would get:
(1) UW1-Enter (transactional=true)     // Transaction T1 created
(2) UW2-Enter (transactional=false)    // T1 still active
(3) UW2-Leave (transactional=false)   // T1 still active
(4) UW1-Leave (transactional=true)    // T1 is commited

and for the error case:
(1) UW1-Enter (transactional=true)    // Transaction T1 created
(2) UW1-Leave (transactional=true)   // T1 committed
(3) UW2-Enter (transactional=true)    // Transaction T2 created
(4) UW2-Leave (transactional=true)   //  T2 committed

So @UnitOfWork(transactional=true) would be compareable to @TransactionAttribute(REQUIRED) and @UnitOfWork(transactional=false) would be compareable to @TransactionAttribute(SUPPORTS)
To complete this - the last relevant sequence would be:
(1) UW1-Enter (transactional=false)
(2) UW2-Enter (transactional=true)    // Transaction T1 created
(3) UW2-Leave (transactional=true)   // T1 is commited
(4) UW1-Leave (transactional=false)

Does that sound sane?

This is the implementation of the suggested handling: https://github.com/matthiasblaesing/dropwizard/commit/082ec3ba5a93aecf330c63f57182314ebc03b995. All existing unittests still succeed, the new unittests failed before this change and with the change succeed.

@irineuruiz can you comment on the outlined solution and check the proposed patch?

I'm sorry, I was on vacation and I just came back today, I'll check it out

Hi @matthiasblaesing
I tested your suggestion and it worked as expected

Commenting to keep this open. Fix is proposed in #3201 and is pending review.

The issue is not stale, review is still pending.


Add README status badges #188

@marcuswestin you need to create a TravisCI account and enable this repo. Once that is in place, a build will be tested with npm test and update the badge accordingly

Nice!
I'll create an issue for continuous automated testing. In the meantime I'm going to comment out the build badge.
Thanks for making this happen!

Nevermind - Travis automatically decided to run make test, so it looks like we're g2g! :)
I'll update #209 to specifically enable full cross-browser saucelabs testing.


[KARAF-5190] Enhance realpath() function to better manage awk on Solaris

This PR aims to update and normalize the realpath() function included in Karaf shell scripts (karaf, shell, start, stop, status, instance, client) , making them compatible with Solaris platforms.
For exemple, until now, launching the start script on Solaris resulted in a loop caused by bad behavior of default Solaris awk command, which is not able to properly manage the -F"-> " delimiter.
It also cleans the checkJvmVersion() function to make the awk command configuration inside it identical to the one in newly updated realpath().

retest this please

I would like to run Jenkins build in addition of my review/build before merging.

retest this please


fix: First source import modal opening before ingestion is completed

closes #4976
The code checking for source ingestion was not looking for a successful creation of table. Updated the code to be specific to source and it now checks for either a table is created or an error is encountered.

/review


go/doc: Examples includes example functions with returns

As documented at https://golang.org/pkg/testing#hdr-Examples, an example function is expected to have no parameters and no returns. doc.Examples considers functions with parameters as invalid examples and skips them.
Unlike the vet pass, doc.Examples does not check if there are results.
That means both of these are recognized as examples by doc.Examples:
func ExampleHello() {
	fmt.Println("hello")
	// Output: hello
}

func ExampleHi() int {
	fmt.Println("hi")
	return 42
	// Output: hi
}

It means x/tools/cmd/godoc and other tools that display documentation may show such invalid examples:
godoc screenshot

go vet catches this problem:
# example.org/p
./style_test.go:131:1: ExampleHi should return nothing

Perhaps doc.Examples should be changed to treat functions with returns as invalid examples, like it does for functions with parameters, and not include them in its output.
/cc @griesemer @jayconrod @matloob @bcmills
(This is somewhat related to issue #36184 and CL 211598.)

Part of the reasoning in CL 211598 was that go/doc.Examples should return the set of example functions that go test will call. If go test filtered anything out, then go/doc.Examples would be returning something inaccurate.
Are examples with return values ignored or rejected by go test? I suspect they're called. Since testing says they should not have return values and go vet rejects them, this seems like a bug.

go test fails to build the test package when an example returns something:
$ go test
# example.com/p
/tmp/go-build839897815/b001/_testmain.go:44:21: cannot use present.ExampleHi (type func() int) as type func() in field value
FAIL	example.com/p [build failed]

Proposal #21111 (which is on hold for error handling) is related.

I think we should remove them, and let the vet check flag them.

I think we should go ahead with proposal #21111 and allow Examples to return an error.


micro <...> --api_handler=rpc api it doesn't work

@doubleycn thanks for your reply.
My service type is service(grpc), not api.
so can you test micro api by using --handler=rpc instead of --handler=api?
Please follow the steps below to test.

create one rpc service:
micro new --namespace=xxx --type=service greeter
run service:
cd greeter && make build && ./greeter-service
run micro gateway in RPC handler type mode (rpc rpc rpc :) ):
micro --auth_namespace='xxx' --api_namespace='xxx' --api_handler='rpc' api
send http request:
curl --location --request POST 'localhost:8080/service/greeter/greeter/call' --header 'Content-Type: application/json' --data-raw '{"name":"jack"}'

And you will get this result:
{"id":"go.micro.api","code":500,"detail":"service not found","status":"Internal Server Error"}
go-micro version: v2.8.0
micro version: v2.9.1
I'm sure it cannot work, even if use both --auth_namespace and ---api_namespace options.
btw, it works well in 1.x.x versions.
Originally posted by @t5w0rd in https://github.com/micro/go-micro/issues/1709#issuecomment-650971081

please test the --api_handler=rpc, thanks!

Whats the namespace?

namespace + path = service

curl localhost:8080/greeter/call

file this issue with micro repo and look at examples repo

@asim OK, i see.
After reading the examples/api/rpc, I found the difference between the new and old versions. service name must contain .api..


refactor: dashboard create form fields and actions

Description
The change is a refactor + added documentation of the create dashboard form fields and action. No functional changes were made. In a follow-up PR (unscheduled), the form will be brought to 100% unit test coverage (currently covered by a comprehensive Playwright test suite).
Legal
This project is available under the Apache 2.0 License.

Conflicts resolved.


Not Working

Malicious File: Dark Comet Trojan
nothing happens when running loader.js
should i use a meterpreter shell or something?

It looks like it's flagging on the embedded file. Just by Googling Dark Comet is highly IoCed so it might be that. I would try something more evasive.

Closing due to lack of response.


Fix building failure due to floaxie test dependency on C++14 standard

As @vitaut pointed in #13, building the floaxie test proposed by me some time ago fails when pre-C++14 standard is used by the compiler. This little fix just let floaxie be skipped from the test suite in this case.
Sorry for the error made, and I hope this fix would help the problem.

Thank you very much for merging!


Unclear documentation for MaxCmds

MaxCmds says "This parameter does not affect connections with SMB 2.0 servers."  what about other versions?   This sounds like an old comment from before 2.1 and 3.x.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81b40e8b-6840-30f3-ff6a-e178160f6ef5
Version Independent ID: 8a9f683d-cc6a-0182-713f-c0a789335f65
Content: Performance Tuning for SMB File Servers
Content Source: WindowsServerDocs/administration/performance-tuning/role/file-server/smb-file-server.md
Product: windows-server-threshold
Technology: performance-tuning-guide
GitHub Login: @phstee
Microsoft Alias: NedPyle; Danlo; DKruse

This was meant for https://docs.microsoft.com/en-us/windows-server/administration/performance-tuning/role/file-server/
Sorry, wrong tab.


fix(api): unsubscribe all subscribed emails

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Related #40773 (Only to be closed, once new api is deployed)

Before
After

Unsubscribing accounts with the same email but different unsubscribeIds would result in emails still being sent
Unsubscribing accounts with the same email but different unsubscribeIds unsubscribes all accounts

All accounts with same unsubscribeId get unsubscribed
All accounts with same unsubscribeId get unsubscribed

These changes could be backported to the old/current api. However, I find it unscrupulous.

nice work🙌


API design for choosing between multiple backends

Let's say in the future, we have astrowidgets API implemented with different visualization tools (backends); e.g., Ginga, glue-jupyter, PyWWT, etc. How do we enable switching backends?

Do we do this at import time and then have it fixed for a session? Example: from astrowidgets.ginga import ImageWidget
Do we allow user to switch inside an active session? Example: import astrowidgets; astrowidgets.set_backend('ginga'); from astrowidgets import ImageWidgets
Something else I haven't thought of?

Also see: #93

With #162  , backend implementation would be completely separate and eventually they won't even be in this repo.


Add appVersion and home key in nginx-lego/Chart

To solve the ci testing failure problem, the appVersion and home key are needed in the yaml file.
appVersion: 0.8.3
home: https://github.com/jetstack/kube-lego

/ok-to-test
/lgtm

/assign @viglesiasce

Thanks @unguiculus
Got it. how to know whether a chart is deprecated?


Need to update Specialty Genes Data Landing Page with new data sources

For Antibiotic Resistance description, remove ARDB and add PATRIC AMR curation and NDARO (https://www.ncbi.nlm.nih.gov/pathogens/antimicrobial-resistance/).
Need 2 new categories with descriptions:

Transporters (uses TCDB http://www.tcdb.org/)
Essential genes (uses PATRIC model reconstruction?  need link)

@rkenyon or @mshukla1 would you provide one line description about the data type?

how does this sound like?
Transporters refers to proteins that serves the function of moving other materials within an organism. We have integrated and mapped proteins from Transporter Classification Database.

updated


Kindy Tan's Lab 4 submission, class to draw a bear face

Finished both simple and advanced drawings. Added classes to draw a Bear and BearFace.

Pull Request Closed by request from Kindy


⚠ Bofrost.at has degraded performance

In 2776b44, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1390 ms

Resolved: Bofrost.at performance has improved in b3006ee.


-[__NSDictionaryI setObject:forKeyedSubscript:]: unrecognized selector sent to instance

Describe the bug
We're seeing a crash on the launch of our app. When Bugsnag is uninstalled, the app works fine.
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSDictionaryI setObject:forKeyedSubscript:]: unrecognized selector sent to instance 0x283290fc0'
When I add a breakpoint, it takes me to line 284 in BSGOutofMemoryWatchdog.m:
contents[BSGKeyApp][APP_KEY_IS_MONITORING_OOM] = [self.kvStore NSBooleanForKey:KV_KEY_IS_MONITORING_OOM defaultValue:false];
Steps to reproduce
Launching the app and starting Bugsnag on launch.
Environment
Bugsnag version: 6.1.5
CocoaPods version: 1.9.3
Carthage version (if any): N/A
iOS/tvOS/macOS version(s): iOS 13 or 14 so far
Simulator or physical device: Physical device.
Xcode version: Xcode 12 (12A7209)
Swift version (if applicable): Swift 5

Hey @jonahollman, thanks for reporting this. Are you seeing the same issue with any previous versions of bugsnag-cocoa? If you point your Podfile to v6.1.4, do you see the same issue? There have been some changes in this area in v6.1.5. I am looking into reproducing this error now, but this sanity check would be very helpful to help expedite the check.

@xander-jones I'm not seeing the issue when I revert to v6.1.4. I'll use that as a workaround for the time-being. Thanks!

I'm also seeing this exception, I just upgraded to 6.1.5 from 6.1.2 where There was no issue.

6.1.4 is also not reproducing the crash for me.

Hey @randarnold, thank you for your feedback also. Could you please let us know which version of Xcode you seeing this on? And which iOS version are you targeting?

Xcode 12, running on iOS 14 on an iPhone 11 Pro (targetting iOS 12 and later).

Thanks! I'm not seeing this crash just yet using Xcode 12.0, and running on iOS 14.0; I wonder if there's a commonality in your configurations that I don't have set at the moment. @randarnold @jonahollman, would you please drop us a message at<EMAIL_ADDRESS>just detailing your configuration of Bugsnag? Additionally, do you see this issue when running in a simulator too?
For future travellers, if you see this issue, reverting to bugsnag-cocoa v6.1.4 is the best solution at present. You can do this by adjusting your Podfile to read:
  pod 'Bugsnag', '6.1.4'

It doesn't happen for me in the simulator, will send my config.

Hey @jonahollman, @randarnold –– Thanks for highlighting this to us, a release will be coming very shortly!

This has been released in https://github.com/bugsnag/bugsnag-cocoa/releases/tag/v6.1.6

Looks good! 👍 Thank you.


Puma and rack-timeout results in a null pointer after running for some time

We recently tried introducing request timeouts for our Rails application using this gem. While this setup works for some time, we run into a null pointer exception at some point:
NoMethodError: undefined method `state=' for nil:NilClass
  _set_state! at /usr/local/bundle/gems/rack-timeout-0.6.3/lib/rack/timeout/core.rb:193
  call at /usr/local/bundle/gems/rack-timeout-0.6.3/lib/rack/timeout/core.rb:123
  call at /usr/local/bundle/gems/rack-timeout-0.6.3/lib/rack/timeout/core.rb:125
  run! at /usr/local/bundle/gems/rack-timeout-0.6.3/lib/rack/timeout/support/scheduler.rb:39
  run! at /usr/local/bundle/gems/rack-timeout-0.6.3/lib/rack/timeout/support/scheduler.rb:52
  run_loop! at /usr/local/bundle/gems/rack-timeout-0.6.3/lib/rack/timeout/support/scheduler.rb:100
  each at org/jruby/RubyArray.java:1865
  run_loop! at /usr/local/bundle/gems/rack-timeout-0.6.3/lib/rack/timeout/support/scheduler.rb:100
  loop at org/jruby/RubyKernel.java:1507
  run_loop! at /usr/local/bundle/gems/rack-timeout-0.6.3/lib/rack/timeout/support/scheduler.rb:81
  runner at /usr/local/bundle/gems/rack-timeout-0.6.3/lib/rack/timeout/support/scheduler.rb:73

So it appears that the env either no longer holds the state or never held it in the first place.
Our setup is as follows:

JRuby <IP_ADDRESS>
Rails <IP_ADDRESS>
Puma 6.2.1

Any help would be very much appreciated

Hmm, this looks like some kind of threading-related bug, possibly one that isn't seen in CRuby due to the GIL. Would have to review the logic and design more carefully to get to the bottom of this one.


Load repository settings from the github repo

Fixes #73
Allow repository settings and templates to be loaded from files stores in the github repo. These settings will override the environment variables and default config files.
Configuration file naming and structure that it will look for:
.concierge/
  templates/
    signature.hbs
    ...
  config.json

@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.
I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.
I am a bot who helps you make Cesium awesome! Thanks again.

Awesome, didn't realize you were working on this.  I'll try and review it later today or tomorrow.  One thing I would suggest is using .concierge instead of .bot since it's more specific and unlikely to collide with anything (or other bots).

@mramato I refactored RepositorySettings and update it at the beginning of each action. The nconf stuff still need to be there for setting the repository names and github token (which I assume you'd never want to specify in the repo itself).

Is there a Cesium PR to go along with this?  Once we merge and deploy I want to make sure cesium behavior is ready to go.

Same for this repository actually.

There's some low hanging coverage missing here, for example fetchSettings is never called in the test.  Please run coverage and do a pass on anything easy to add.

Is there a Cesium PR to go along with this? Once we merge and deploy I want to make sure cesium behavior is ready to go.

It will fall back on the defaults (what's currently used in cesium), and I added a configured template in this repo for testing.

@mramato Updated, added some more specs for coverage.

It will fall back on the defaults (what's currently used in cesium), and I added a configured template in this repo for testing.

OK, we should probably add a PR to Cesium anyway, just so that becomes the defacto place to manage Cesium's concierge configuration.
We don't really have a good testing set up for this, do we?  I didn't actually run any of this.

We don't really have a good testing set up for this, do we? I didn't actually run any of this.

Should I just run the app locally to test this out? The config files would need to be in master to see an effect.

Yeah, that's one of the problems we really haven't solved yet.  The issue is that You would need to simulate a GitHub webhook (and that only goes so far).
If you are ready to deploy and verify everything, I'll merge this and we can test it out.

If you are ready to deploy and verify everything, I'll merge this and we can test it out.

OK sounds good.


Tutorial: Identifying a transiting planet signal in Kepler or TESS light curves

This notebook introduces the Lightkurve BoxLeastSquaresPeriodogram and walks users through the basics of a fundamental reason for using Kepler or TESS data—finding transiting planets.
While many users will be familiar with the BLS method, I think it's useful to have a quick refresher with some figures that clearly show the approach taken by BLS.
Then, the notebook will provide simple steps to use the BoxLeastSquaresPeriodogram object to identify a transiting exoplanet signal in both Kepler and TESS. It will show users how to extract a transit model and transit mask, which can be used to remove the identified signal and search the remainder of the light curve for additional transiting planets.
(optional, but I think it would be cool →) Finally, it will show a concise gif of how the interactive BLS periodogram works, with references to the lightkurve docs for more information. This gif could be reused for an "Interactively analyzing Kepler/K2 and TESS data with Lightkurve" notebook, which I think would be fun to write!
By the end of this tutorial, you will:

Understand the "Box-Least Squares" (BLS) method for identifying transit signals
Know how to use the Lightkurve BoxLeastSquaresPeriodogram to identify a transiting planet
Estimate the period, epoch, and duration of the transit
Plot the phase-folded transit light curve
Be familiar with the interactive Box Least Squares periodogram in Lightkurve

:+1:

@barentsen This tutorial is ready for review.

Note: title changed to "Identifying transiting planet signals in a Kepler light curves" to better reflect the content of the tutorial

Hmmm both colab and my local install seem stuck on the line that says lc_collection.stitch().flatten(901).  Did you experience any problems with that?

@barentsen It was working fine for me yesterday. This appears to be an issue introduced by lightkurve #844, which is causing lightkurve to download simultaneous short and long cadence Kepler data. I added cadence='long' to the search function and it's now behaving as expected again.

@nksaunders Ah! That makes sense. Thank you!
This is in intentional change by #844, because TESShas many targets for which only short and no long-cadence products exist.

Thanks @nksaunders!  This is a really excellent tutorial.  I love it!
Nitpicking: in two or three places I turned unnamed arguments into named keyword argument, e.g. it is good practice to use
lc.fold(period=planet_b_period, epoch_time=planet_b_t0)

instead of
lc.fold(planet_b_period, planet_b_t0)

because it makes the code more resilient against any future API changes.
Otherwise this is a really fun, informative, and important tutorial.  It is ready for copy editing! :+1:

The filename is Identifying a transiting planet signal in Kepler or TESS light curves.ipynb.

@nksaunders and @barentsen I finished copy editing this tutorial. I loved reading this one -- finding transiting exoplanets is so fascinating!!
I made minor copy edits throughout, and I also named "planet b" earlier in section 3, as I was little confused when it was named in section 4 and had to go back and look at the code more carefully. Hopefully that change is alright! Otherwise, this one is all set on my end and ready to go!

Awesome :+1:

Perfect, thanks @lglattly!!

This notebook has successfully been merged into spacetelescope/notebooks.  Thanks everyone!  Closing the issue...


Problem Getting Azure B2C OAuth Connection Working

Hello,
My company currently uses Azure B2C to authenticate users and provide access to a .NET Core API via a JavaScript.  This is all working fine and currently in productive use.
We decided that it would be great to have a chatbot in .NET core that could call API requests for a different user interface.  However, we still need to authenticate users and get a token to call the API and this is where I am having issues.
I have created a new web app bot in Azure,  registered the bot in B2C (app entry) and then in the chatbot gone to Settings > 'OAuth Connection Settings' and added a new connection.
Originally I would have expected Azure B2C to be listed, however it is not so I decided to opt for the generic oAuth 2 and I have added all the details here.  When I click test connection, it opens the correct login page, I use one of our test accounts, however I get a redirected to the 'https://token.botframework.com/.auth/web/redirect' with a response of 'bad request' (no other error message)..
My assumption is that my Auth URL, Token URL or Refresh URL are incorrect somehow, even though these are similar to the ones I have used in the javascript app to get access to the API's.  Please see them below:
Authorization URL:
https://login.microsoftonline.com/tfp/<Tenant ID>/<b2c_Policy>/oauth2/v2.0/authorize
Token URL:
https://login.microsoftonline.com/tfp/<Tenant ID>/<b2c_Policy>/oauth2/v2.0/token
Refresh URL:
https://login.microsoftonline.com/tfp/<Tenant ID>/<b2c_Policy>/oauth2/v2.0/token
Just to note, I am using the client ID and secret from my registered chatbot  in Azure B2C in teh connection.  I have also tried setting these up using https://.b2clogin.com instead of login.microsoft.com, but I dont even get through to the login page... this must be a configuration with our B2C and cannot really go poking around in there at the minute.
Regarding getting tokens form B2C, I have been using this as a guide:
https://docs.microsoft.com/en-us/azure/active-directory-b2c/active-directory-b2c-access-tokens
Any help you could give would be great as currently we cannot use a chatbot until I get this working.

Additionally, when I try this in the emulator using the auth bot sample, I get the sign in button, I click it then a popup opens... but hangs at loading.  Please see attached:

When you set up an OAuth Connection, I believe you want to give it its own Microsoft app registration rather than reusing the client ID and secret from your bot. In that app registration's settings you can configure who is allowed to be authenticated through that app (personal accounts, one specific organization, etc.). This document provides a tutorial for adding authentication to a bot using Azure Active Directory.
It seems like Azure B2C is also called Azure Active Directory B2C, so it might be worthwhile to even try selecting Azure Active Directory v2 rather than Generic Oauth 2. And if you already have an app registration associated with your Azure B2C then you might be able to use that.

It looks like there's some documentation about Generic Oauth 2 connections here: https://docs.microsoft.com/en-us/connectors/custom-connectors/connection-parameters#oauth-20

@silver-stack - I've just learned that B2C isn't a distinct service from AAD v2, so go ahead and follow the AAD docs

Hello @v-kydela,  firstly thank you for your quick response, it is much appreciated.
Back to my original post, when I created the new chatbot it was registered in the Azure tenant AADv2 automatically and so a new client ID and secret are created at that point that allow the chatbot channels to authenticate etc.  However, so that my B2C customers can authenticate inside the chatbot against my Azure B2C I have registered a new app in the B2C for the chatbot, similar to how the API is registered for which I need to provide access to.  Having two sets of client IDs and secrets in this scenario does make it a little difficult to explain, sorry.
I have also just tried setting up a new connection with AADv2 using my Azure B2C details, however the issue here (I think) is that I cannot supply a B2C policy (these are now called User Flows) with the fields that are supplied (see below).  Either way I have tried and I get the standard MS AAD login prompt, not my Azure B2C one, so I am not sure that this is the correct path (though I would be more than happy to be corrected).
Bot Connection Details

My Azure B2C App Details

Login in screen that I get when logging in via the chatbot emulator:

Login that I would expect to see:

@silver-stack - I've created a B2C tenant and I can reproduce your issue. To clarify, do you want to be able to configure your bot's OAuth 2.0 connection to use your B2C user flow with that specific UI? Or are you only commenting on the UI discrepancy because you're worried you haven't actually configured the connection to use your B2C app?

@v-kydela - thank you again for looking into this.  I tried a couple more test earlier today and appeared to get a little further.
So in my previous comment, what I was saying is that if I used the standard AADv2 connection, but used my Azure B2C tenant details I would get redirected to the standard MS login page.  I would then try and login with a test B2C user, however I would then get a message informing that the test user does not exist in that tenant.   So I dont think this is the right avenue for B2C (see below)

Also, this account works fine via our JS based app that uses MSAL to sign-in to our Azure B2C.  So I am certain the account is OK.  So in answer to your question - I don't think this is configured to connect to use my B2C app.
However, after signing out of everything and clearing my cache I have tested the Generic OAuth 2.0 connection via the OAuth Connection Settings in the chatbot settings (the button 'Test Connection') and the new tab displays my Azure B2C login screen. The URL that it has constructed is the following:
https://login.microsoftonline.com/tfp/<tenant ID>/<B2C Policy>/oauth2/v2.0/authorize?client_id=<client ID>&response_type=code&redirect_uri=https%3a%2f%2ftoken.botframework.com%2f.auth%2fweb%2fredirect&scope=<scope>&state=a7c04c340bc64e9a8a67cbb23f9f7ce3
Which looks correct... however I supply the correct credentials and click login and instead of seeing the successful token page I get the following still:

Maybe its something to do with the generic OAuth 2 token settings? - Though the generic OAuth will be based on a standard and I have followed the documentation, so cant see why this is not working unless its just not supported in this scenario?

I actually wasn't able to reproduce that error, but following your guide I was able to get the Generic Oauth 2 connection working in my bot. Let's see what we're doing differently.
OAuth Connection
Client id
This is taken from the Application ID field in your B2C app's properties. It's the equivalent of a Microsoft app ID taken from any other AAD app registration.

Client secret
This is generated using the steps in this tutorial.

Select Keys and then click Generate key.
Select Save to view the key. Make note of the App key value. You use the value as the application secret in your application's code.

Authorization/Token/Refresh URL
I followed your lead on this one with https://login.microsoftonline.com/tfp/<Tenant ID>/<b2c_Policy>/oauth2/v2.0/authorize for the Authorization URL and https://login.microsoftonline.com/tfp/<Tenant ID>/<b2c_Policy>/oauth2/v2.0/token for the Token and Refresh URL's.
For <Tenant ID> I used the URL format (kyleorg.onmicrosoft.com) rather than the GUID format, but using the GUID also seems to work.
<b2c_Policy> is the name of a user flow. I created one with this tutorial.
Scopes
I suspect we are differing here. Using the scopes openid offline_access I am able to sign in successfully, but to my astonishment the token returned is empty.

Then I found this document which suggests using the client ID itself as a scope.
When I reuse the value from the Client id field in my Scopes field, a token is returned successfully and my bot is able to use the connection.

You can combine this with other scopes as needed, but for the sake of experimentation I highly recommend getting the simplest implementation to work first.

Let me know if these instructions work, and if they don't then we'll see if the difference lies in how we've set up our B2C apps.
As a bonus, I should mention that after you get a token you can paste it into https://jwt.ms/ to decode it and see if it recognized your B2C user correctly. Always refresh the page when pasting a new token to make sure it doesn't keep showing you the information from the last token.

@v-kydela Firstly, let me say thank you very very much for your assistance on this.  With your help I have managed to get this working, however it was partially with your instruction and partially by accident.  After a little more investigation I have found out what the issue was... but there is very little documentation on it.
So as stated earlier, my original auth and token endpoints where the following:
https://login.microsoftonline.com/tfp/<Tenant ID>/<b2c_Policy>/oauth2/v2.0/authorize
https://login.microsoftonline.com/tfp/<Tenant ID>/<b2c_Policy>/oauth2/v2.0/token
I then followed looked at some of the openId connect post requests that you had posted and changed a couple of things as we cannot add parameters (as far as I am aware) in the generic OAuth 2 connection options.
So I decided to copy one of their URL's and paste in my details.  My endpoints are now:
https://<tenant-name>.b2clogin.com/<tenant-name>.onmicrosoft.com/<b2c_Policy>/oauth2/v2.0/authorize
https://<tenant-name>.b2clogin.com/<tenant-name>.onmicrosoft.com/<b2c_Policy>/oauth2/v2.0/token
I tested them and they worked... but I couldn't understand why at first.  Then I noticed that I had accidentally omitted the tfp from the URL, which from all my previous links to tutorials and howtos showed that this was a required field if you were using policies.  I believe that TFP stands for Trust Framework Policy, however these policies are now known as user flows as far as I can tell.
After some further digging, I found the following setting in my policy under properties:

As you can see, I actually have the top one selected, which I think is default.  If I change this to the bottom one my log in no loner works.  Also to note, I added in my client ID into the scopes as you suggested, and this also has an effect.  If I omit it, I get bad request, if I leave it in I get signed in.
This is absolutely great news and I cant wait to get started on our new chatbot.
Once again, thank you, your assistance and details explanations have been much appreciated.

That's great news, @silver-stack
I'm glad we could get this resolved


Added section for Choice fields in documentation for types

Added Enums example for Integer choices
Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ x] Documentation

Issues Fixed or Closed by This PR

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

This has not have any activity for a while now so I'm closing this to clean up the backlog a little.
In case op or anyone wants to get back to this, feel free to reopen, or ask me to reopen in case you don't have permission to :)


Export from a query

Is it possible to export a subset of a table's data based on a sql query?

Hi,
Unfortunately it's not possible at the moment. This plugin is based on https://github.com/androidmads/SQLite2XL and i only port the available function in that library.

I may try to create a temporary table in sql and export from there, because I really need ordering, where and join clauses for selecting data to export

Let me know if you are able to get it working as your expectation.
And I will try to see if there is a way to do that, but i can't promise on the timing.


It's hard to use the Accessible Autocomplete in the Prototype Kit

(from support)
The Accessible Autocomplete is not built into GOV.UK Frontend or the Prototype Kit, and has no macro, so it can't be used out of the box the way other components can.
The installation instructions are quite complicated for Prototype Kit users, and don't cover all the steps needed. In support, I have recommended the 'plain javascript module' approach:
https://github.com/alphagov/accessible-autocomplete#as-a-plain-javascript-module

@alextea has written a guide here:
https://gist.github.com/alextea/2ec78934472fdb3b1433b342c2ef18d3

would make a good plugin

GOV.UK Prototype Components includes the accessible autocomplete, designed in way that it can be configured declaratively via component params.
GOV.UK Prototype Components is itself a plugin, which includes 6 other Nunjucks components, and 2 JavaScript helpers.
So it is possible, today, to install a plugin and get an easier to use autocomplete. However, I suspect this functionality should probably live within the autocomplete package itself. Maybe time to submit a PR…

Need to review the XGOV.UK plugin before working on this as they may have found a good solution already


Dart SDK change breaks background notifications

On upgrading to Flutter from current main, and running in release mode, the app no longer shows notifications on Android when it was in the background. This burst of error messages appears in logcat:
DartVM   E  ERROR: To access 'package:zulip/notifications/receive.dart::NotificationService' from native code, it must be annotated.
            ERROR: See https://github.com/dart-lang/sdk/blob/master/runtime/docs/compiler/aot/entry_point_pragma.md
flutter  E  [ERROR:flutter/lib/ui/dart_runtime_hooks.cc(38)] Dart Error: ERROR: To access 'package:zulip/notifications/receive.dart::NotificationService' from native code, it must be annotated.
            ERROR: See https://github.com/dart-lang/sdk/blob/master/runtime/docs/compiler/aot/entry_point_pragma.md
flutter  E  [ERROR:flutter/shell/common/shell.cc(115)] Dart Error: ERROR: To access 'package:zulip/notifications/receive.dart::NotificationService' from native code, it must be annotated.
            ERROR: See https://github.com/dart-lang/sdk/blob/master/runtime/docs/compiler/aot/entry_point_pragma.md
flutter  E  [ERROR:flutter/shell/common/shell.cc(115)] Dart Error: ERROR: To access 'package:zulip/notifications/receive.dart::NotificationService' from native code, it must be annotated.
                                                                                ERROR: See https://github.com/dart-lang/sdk/blob/master/runtime/docs/compiler/aot/entry_point_pragma.md

It looks like the relevant upstream commit is probably this one:
https://github.com/dart-lang/sdk/commit/9b06e26620a081c89931e5618336ff23dc6083be
which is also the latest commit to touch that linked docs page.
AFAICT those docs don't actually say that we should need to annotate the class. We already do annotate the static method that we ask native code to call:
  @pragma('vm:entry-point')
  static Future<void> _onBackgroundMessage(FirebaseRemoteMessage message) async {

Well, at least the error message is nice and clear, though. We'll annotate the class too.

This makes a good example of why it'd be valuable for us to have end-to-end testing for notifications:

#758


Trained nets

Hi, any chance we can get the trained networks / weights? Seems a bit pointless having everyone retrain it, especially since I saw an issue about the database no longer being available.
Thanks, Povilas

Hi Marcin,
Pre-trained checkpoints can be found at the link that is here: https://github.com/joelmoniz/DepthNets/tree/master/depthnet-pytorch#experiments
Unless you mean wanting a pretrained network that maps images of faces directly to keypoints. We had one that we used internally, but it was trained a very long time ago under the Theano framework (@SinaHonari would have more details about this). There should be some off-the-shelf image-to-keypoint regression networks lying around on the internet that you can use. While some may generate 68 keypoints instead of 66, you could roughly figure out a heuristic to 'convert' to 66 keypoints through the use of this reference image. (We actually had to do this at one point for the opposite direction: converting from 68 to 66 keypoints, as computed in this method: https://github.com/joelmoniz/DepthNets/blob/master/depthnet-pytorch/util.py#L137-L148)
Let me know if there are any other concerns.
Thanks,
Chris

In the coming days I will look to see what can be done about the fact that 3DFAW is no longer available.


Library name change request

Library repository URL
https://github.com/SeeedJP/wio_cellular

Hi @matsujirushi. I am confirming your request.
Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will close this issue when it is done. You will get a notification from GitHub at that time.
After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

Hi,
Should I just wait?
The library name does not appear to have been changed yet.
https://downloads.arduino.cc/libraries/logs/github.com/SeeedJP/wio_cellular/
2024/07/24 23:36:34 Checking out tag: 0.1.3
2024/07/24 23:36:34 Release WioCellular:0.1.3 has wrong library name, should be Wio Cellular

@matsujirushi yes, you must wait.
As I already explained, a manual process must be performed on the index in order to accommodate your request. The change in this repository is only one part of the task. As I said, the issue will be closed once the request is accommodated and GitHub will send you a notification at that time.
We will get to it as soon as we have the time to do so. Until then, please be patient.

Solved in https://github.com/arduino/library-registry/pull/4812#issuecomment-2255911835


Parsing error with heredoc that contains keywords such as change, append, insert, etc.

Steps to reproduce
$ vim -u NONE
:source foo.vim

foo.vim:
function RunLua() abort
lua<<EOF
local foo = {
    change = {},
    insert = {},
    append = {},
}
EOF
endfunction

What happens:
(neovim nightly, vim 8.2.0000)
E126: Missing :endfunction

(or in recent versions, in my env: vim 8.2.3550)
E1145: Missing heredoc end marker: .

Expected behaviour
The heredoc block should run without any errors -- even if the heredoc script contains a word like change, append, insert, etc. Those words are some kind of special directives (see :lua-heredoc) but they impact on parsing function ... endfunction blocks.
Operating system
macOS
Version of Vim
Vim 8.2 and Nightly (8.2.3550)
Logs and stack traces
See https://github.com/neovim/neovim/issues/16136 for the downstream issue on Neovim. I believe this is a vim bug.
Implementation of parsing heredoc: https://github.com/vim/vim/blob/master/src/userfunc.c#L940

Hi,
I am not able to reproduce this problem with the latest version of Vim
(with one minor modification
described below). Can you try to reproduce this problem with the latest
version of Vim?
On Sun, Oct 31, 2021 at 3:33 PM Jongwook Choi @.***>
wrote:

Steps to reproduce
$ vim -u NONE
:source foo.vim
foo.vim:
function RunLua() abort
lua<<EOF

You should add a space around "<<".

Yegappan

local foo = {
change = {},
insert = {},
append = {},
}
EOF
endfunction
What happens:
E126: Missing :endfunction
Expected behaviour
The heredoc block should run without any errors -- even if the heredoc
script contains a word like change, append, insert, etc. Those words are
some kind of special directives (see :lua-heredoc) but they impact on
parsing function ... endfunction blocks.
Operating system
macOS
Version of Vim
Vim 8.2 and Nightly
Logs and stack traces
See https://github.com/neovim/neovim/issues/16136 for the downstream issue on Neovim. I believe this is a vim bug.
Implementation of parsing heredoc: https://github.com/vim/vim/blob/master/src/userfunc.c#L940

Indeed, when lua<<EOF is changed to lua <<EOF the error can no longer be reproduced in either Vim or Nvim.

And this is also what the documentation says:
:[range]lua << [endmarker]
{script}
{endmarker}

closing then.


Update texture layering doc

The texture layering doc needs a paragraph talking about materials, and their properties. In particular, the required texture is villager_v2_masked.

Also talk about geometry

Texture layering doc is now moved to the render controller doc

Closed


Issue importing bfo-core.ttl

I'm having a problem with the owl:imports directives in the current version of master (commit a9e8c72e), I'm using Protege 5.5. When it loads ExtendedRelationOntology.ttl, it processes the imports directive but does not consider BFO to be imported by ExtendedRelationOntology. My company blocks image uploads, so I can't attach a screenshot, but the effect is that:

If I set Protege's View menu to "Show the imports closure of the active ontology" none of the BFO entities appear.
If I set Protege's View menu to "Show all loaded ontologies", the BFO entities appear.

Also, if I change the IRI of the ontology in bfo-core.ttl from http://purl.obolibrary.org/obo/bfo.owl to http://purl.obolibrary.org/obo/bfo, Protege resolves the imports as expected.
A couple of questions:

I don't have Protege 5.6 installed. Is this problem specific to Protege 5.5 (or perhaps to the version of OWL API 5.5 uses)?
In bfo-core.ttl, why is the ontology's IRI bfo.owl rather than bfo? The latter is used in imports directives.

The ontology IRI is always  http://purl.obolibrary.org/obo/bfo.owl
The version IRI is  http://purl.obolibrary.org/obo/bfo/2020/bfo-core.ttl - that's the one to import. or http://purl.obolibrary.org/obo/bfo/2020/bfo-core.owl -both have the same content but are different formats.
The ontology is accessible from either the ontology IRI or the version IRI, but you import the version IRI if you want the specific version.
The extended relations ontology is importing the wrong IRI:   owl:imports obo:bfo ; which translates to http://purl.obolibrary.org/obo/bfo
It needs to import one of the above version IRIs.
The entry in catalog-v001.xml is also wrong. Currently
    <uri id="User Entered Import Resolution" name="http://purl.obolibrary.org/obo/bfo" uri="imports/bfo-core.ttl"/>

Should be
    <uri id="User Entered Import Resolution" name="http://purl.obolibrary.org/obo/bfo/2020/bfo-core.ttl" uri="imports/bfo-core.ttl"/>

Once the catalog is fixed and the correct IRI is imported all will be good.
The reason that changing the IRI to http://purl.obolibrary.org/obo/bfo works is due to a cascade of errors. Extended relations imports http://purl.obolibrary.org/obo/bfo. That's looked up in the catalog. The catalog has that IRI, so it thinks it's going to find the ontology with the IRI (version or main) that is http://purl.obolibrary.org/obo/bfo. When it doesn't apparently it's deciding something is wrong and not loading, because, well, something is wrong.
The ontology it looks up must have the same value of ontology or version IRI that was imported. It doesn't.

Technically, any file that uses a BFO term should be importing BFO. Which I'm guessing is all of them. But all have to import the same IRI.

The IRI http://purl.obolibrary.org/obo/bfo resolves to the GitHub web page for the BFO project, not a file containing an ontology, so @alanruttenberg's statement that the imports directive in ExtendedRelationOntology.ttl is wrong makes sense to me.
I'm less certain about the claim that the catalog entry is wrong. At least, I don't think there's a single entry that's right. I tried various combinations of owl:imports directives and catalog entries. (Keep in mind I'm using Protege 5.5, and @neilotte's experience suggests 5.6 behaves differently.) There's no single catalog entry that works for any of the three IRIs.  The 's name attribute has to match the object of an imports directive, so http://purl.obolibrary.org/obo/bfo/2020/bfo-core.ttl in the catalog only works if the imports directive is:
owl:imports <http://purl.obolibrary.org/obo/bfo/2020/bfo-core.ttl>

Someone needs to decide which IRI to use in the imports directive, and the catalog should be changed in response to that decision.

@swartik Thanks for the catch. I can confirm this behavior does not occur in 5.6, but does in 5.5.
@alanruttenberg Your suggested changes to import stmt. in ERO and the catalog.xml fixed the problem. Thanks!
How is BFO being versioned? I expect a v-IRI to have a date or some numeric to distinguish unique versions.
http://purl.obolibrary.org/obo/bfo/2020/bfo-core.ttl seems static to me. What will change about that IRI when the next version is released?

@swartik Check out this branch and let me know if it works for you.
https://github.com/CommonCoreOntology/CommonCoreOntologies/tree/ero-import-fix
@neilotte @johnbeve Any reasons not to merge these changes into master?

@mark-jensen It's working now. Thanks for the quick response.

When a new release happens we'll change the version IRI of this one to have a date and have the new version have this IRI. best we can do because the ontology IRI is fixed

The BFO's version IRI has changed accordingly as of February 21


DO NOT MERGE: Near blockchain

WIP nix packages for the Near blockchain
Currently attempting to resolve an issue where cargo can't find a package, even though it exist.

Encountered an issue (caused by me) which rendered my nix store db in a corrupt state, meaning I need to delete my nix store, and re-init the db.

Due to issues with buildRustPackage, attempting to use alternate solutions, including but not limited to import-crate and crate2nix.

crate2nix was outdated, and had issues which made it difficult to use with our current setup. I'm giving cargo2nix a try.

cargo2nix is unable to read the Cargo.toml of nearcore/chain/chain, going to give crane a try after lunch.

I think crane might be what I need to get things working. However i'm having some difficulty getting it to work, given that it's a flake, and i want to use it in a derivation.
I'll keep trying for a bit, and if i still can't get I'll ask Petar for help.

Curreently (and for the past few hours as well), attempting to get neard to build, by patching the different Cargo.lock and Cargo.toml files.

cargo2nix is unable to read the Cargo.toml of nearcore/chain/chain, going to give crane a try after lunch.

When you abandon a specific approach, it's may be valuable to push the progress to git anyway (in a side-branch). This would effectively document a very precise way what didn't work and would allow further experimentation with the abandoned approach (in case this becomes necessary).

I'll make sure to do so in the future.
In the meantime i'm trying to workaround the re-emergence of an old bug, cargo once again can't find a crate, i'm going to try making a nix package for it, and hope that whatever black magic nix is using can work with that.

Attempting to resolve compilation issues in wee_alloc


fix(UI): Fix resolution selection on src=

With this change, when we are in src= mode we only leave the automatic mode in the resolution selector, since we will not be able to change the resolution.
Fixes https://github.com/shaka-project/shaka-player/issues/5330

@theodab I'll wait to merge it to pass all tests. Thanks!


Bokeh 1.1 problem with overlay layers in maps

With Bokeh 1.1, overlaying two layers with geopandas results in only the last layer shown (@heuvel). Example:
import pandas as pd
import geopandas as gpd
import pandas_bokeh

from bokeh.plotting import figure
from bokeh.io import output_notebook

from shapely.geometry import Point

output_notebook()

point_a_df = pd.DataFrame([['a', Point(4.96548,52.49110)]], columns=['id','geometry'])
point_a_gdf = gpd.GeoDataFrame(point_a_df, geometry='geometry')
point_a_gdf.crs = {'init':'epsg:4326'}

point_b_df = pd.DataFrame([['b', Point(4.63045,52.38150)]], columns=['id','geometry'])
point_b_gdf = gpd.GeoDataFrame(point_b_df, geometry='geometry')
point_b_gdf.crs = {'init':'epsg:4326'}

p = figure()
point_a_gdf.plot_bokeh(figure=p, show_figure=False)
point_b_gdf.plot_bokeh(figure=p, show_figure=True)

Fixed with PR https://github.com/PatrikHlobil/Pandas-Bokeh/pull/23


Failed crafting, progress offset by 5

Required Information
Class: GSM
Level: 62
Craftsmanship: 531
Control: 496
CP: 379
Recipe Name: Grade 4 Skybuilders' Embroidery Frame
Recipe Level: 60
Solver Seed: 154505
Expected Behaviour
Item is crafted at 582/580
Actual Behaviour
Item fails at 577/580
Steps To Reproduce
Using Chili Crab HQ to get those stats (they're included in the stats above already).
Note that with my base stats, adding a Chili Crab HQ doesn't end up having the same ingame stats as I have, so I had to manually adjust them so that the attributes on the solver screen are correct.

The computed macro that fails ends up being:
/ac "Muscle Memory" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Standard Touch" <wait.3>
/ac "Waste Not" <wait.2>
/ac "Careful Synthesis" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Standard Touch" <wait.3>
/ac "Master's Mend" <wait.3>
/ac "Innovation" <wait.2>
/ac "Standard Touch" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Standard Touch" <wait.3>
/ac "Byregot's Blessing" <wait.3>
/ac "Careful Synthesis" <wait.3>
/echo Macro #1 complete <se.14>

I am having the exact same issue on the same class and recipe. Looking at it the site calculates synthesis action by 2 or 3 more than what the game shows.
Info
Class: GSM
Level: 62
Craftsmanship: 531
Control: 481
CP: 383
Recipe Name: Grade 4 Skybuilders' Embroidery Frame
Recipe Level: 60
Solver Seed: 1337
Expectation
Progress 582/580
Actual Behaviour
Progress 577/580

The Failing Macro
/ac "Muscle Memory" <wait.3>
/ac "Careful Synthesis" <wait.3>
/ac "Waste Not II" <wait.2>
/ac "Basic Touch" <wait.3>
/ac "Standard Touch" <wait.3>
/ac "Basic Touch" <wait.3>
/ac "Standard Touch" <wait.3>
/ac "Innovation" <wait.2>
/ac "Basic Touch" <wait.3>
/ac "Standard Touch" <wait.3>
/ac "Byregot's Blessing" <wait.3>
/ac "Careful Synthesis" <wait.3>
/echo Macro #1 complete <se.14>

I have the same issue while crafting [75]Amaro Barding Materials for the crystarium delivery.
Progress is off by 4 when using 2 Groundwork after Veneration.
Info
Class: Weaver
Level: 77
Craftsmanship: 1149
Control: 1089
CP: 395
Recipe Name: Amaro Barding Materials
Recipe Level: 75
Solver Seed: 1337
Expectation
Progress 1002/1001
Actual Behaviour
Progress 998/1001


feat: add sort-attributes rule

Close #417.
The source code for the rule was partially ported from the ESLint Plugin Perfectionist. This is done as part of this task:
https://github.com/azat-io/eslint-plugin-perfectionist/issues/175

@ota-meshi Hello! Could you review this PR?


What does "dimension_numbers" parameter represent in Convolutional layer constructor GeneralConv in jax.experimental.stax.py?

As titled. There are several use cases in the repo (https://github.com/google/jax/search?q=generalconv&unscoped_q=generalconv), but I am still not clear what they are. Thanks.

jax.lax.conv_general_dilated has some documentation on this:
https://jax.readthedocs.io/en/latest/_autosummary/jax.lax.conv_general_dilated.html

I see. Thanks for bringing up the link, @shoyer !


[SCHEDULE] Improve bound inference, support reduce codegen.

Moved schedule_ops into schedule folder
Rename rdom in sum to axis
Rewrite IntSet based on interval and StridedSet
Add support to reduction code generation.
Change behaviour in loop generation,  now most of the loop code avoid add additional LetStmt, and always encourage direct substitution of index value expression for ease of simplification

hello


Presentation: Fix nodes getting duplicated when using hierarchy level limiting with same label instance grouping under hidden nodes

Fixes https://github.com/iTwin/imodel-native/issues/620.
In addition, there was a problem that same-label grouping nodes were returned in wrong order when requesting in pages.

@mergifyio backport release/4.x


Make datapoints editable (remove/add) on the fly

This makes addition and removal for mocked datapoints during runtime available. It is used by the Web UI and tkinter GUI.

Bit off topic from the ticket feature but since this introduced some hiccups when starting the mock service on a Mac at first... we maned to solve those issues. So the basic interactions are working also on a Mac with this branch. However I had to:

delete the mock_service.egg-info file
then call pip3 install .

So that part looks good for me.