Does not create thumbnail from a specific jpeg (while from others does)

I got a few pictures which I upload from django admin using solr.thumbnail.ImageField and it works perfectly - image is uploaded to media folder, thumbnails are created in cache subdir and proper entries in thumbnail_kvstore are created.
I got some images though, which do not work though - they are uploaded to media folder, but no cache entries and no thumbnails are created. No errors or anything raised.
Django==1.8
Pillow==3.0.0
sorl-thumbnail==12.3
This picture I obtained from bigger one and resizing down, but same behaviour applies to original picture also.
What should I look into to make those pictures work?

This is a backend specific issue,
will you able to find a solution?

There is a problem with exif tags:
{315: u'J.F.', 296: 2, 34665: 264, 306: u'2015:08:06 22:06:45', 271: u'Canon', 272: u'Canon EOS 5D Mark III', 305: u'Adobe Photoshop CS6 (Macintosh)', 274: 1, 33432: u'Jakub Frackowiak', 282: 300.0, 283: 300.0}

and how they are being processed by PIL/TiffImagePlugin.__get__item method, which is used by PIL/JpegImagePlugin._get_exif()
    def __getitem__(self, tag):
        if tag not in self._tags_v2:  # unpack on the fly
            data = self._tagdata[tag]
            typ = self.tagtype[tag]
            size, handler = self._load_dispatch[typ]
            self[tag] = handler(self, data, self.legacy_api)  # check type
        val = self._tags_v2[tag]
        if self.legacy_api and not isinstance(val, (tuple, bytes)):
            val = val,
        return val

_tags_v2 = {36864: ('0230',), 37377: (6.965784,), 40962: (1440,), 36867: (u'2015:08:05 15:23:36',), 36868: (u'2015:08:05 15:23:36',), 37381: (3.0,), 41990: (0,), 37383: (5,), 37385: (16,), 37386: (118.0,), 37378: (5.655638,), 41486: (1600.0,), 41487: (1600.0,), 37520: (u'00',), 37521: (u'00',), 37522: (u'00',), 40963: (960,), 37380: (0.0,), 33434: (0.008,), 33437: (7.1,), 34850: (1,), 40961: (65535,), 34855: (100,), 41987: (1,)}

There is a tag: 42034 which is not in _tags_v2 and because of this "load_rational" handler is called and trying to divide by zero as there are some zeros in vals after upacking data related to this tag.
@_register_loader(5, 8)
    def load_rational(self, data, legacy_api=True):
        vals = self._unpack("{0}L".format(len(data) // 4), data)
        combine = lambda a, b: (a, b) if legacy_api else a / b
        return tuple(combine(num, denom)
                     for num, denom in zip(vals[::2], vals[1::2]))

with:
vals = (70, 1, 200, 1, 0, 0, 0, 0)
legacy_api = False

problem is:
  File "/home/mstrecker/envs/papu/local/lib/python2.7/site-packages/PIL/TiffImagePlugin.py", line 482, in <lambda>
    combine = lambda a, b: (a, b) if legacy_api else a / b
ZeroDivisionError: division by zero

Try to use Pillow=2.9.3 or wait for 3.1.

many thanks @lampslave - works like a charm on Pillow==3.1.0. If you provide answer to http://stackoverflow.com/questions/34716513/solr-thumbnail-some-jpegs-are-not-processed, I will accept it :)
I think the issue can be closed.

Pillow 3.1.0 was released on 4th January, please upgrade like:
pip install -U pillow

Thank you @hugovk


Unable to set volumeClaim labels using variables

Summary
It's not possible at present to set volumeClaim labels using variables. This is possible with pod labels for each of the steps. This breaks our current cost reporting, which expects to have a common set of labels for each kubernetes resource.
For example...
If you take the example workflow examples/ci.yaml and modify it as below:
  volumeClaimTemplates:
  - metadata:
      name: workdir
      labels:
        foo: "{{workflow.parameters.revision}}"
    spec:
      accessModes: [ "ReadWriteOnce" ]
      resources:
        requests:
          storage: 1Gi

... you will see the following message when you submit it.
Name:                ci-example-rp2zw
Namespace:           main
ServiceAccount:      default
Status:              Error
Message:             pvc create error: PersistentVolumeClaim "ci-example-rp2zw-workdir" is invalid: metadata.labels: Invalid value: "{{workflow.parameters.revision}}": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

Diagnostics
👀 Yes! We need all of your diagnostics, please make sure you add it all, otherwise we'll go around in circles asking you for it:
What Kubernetes provider are you using? GKE v1.20
What version of Argo Workflows are you running? v3.1.2
What executor are you running? Kubelet
Did this work in a previous version? I.e. is it a regression? No

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

The place the code needs to change is here:
https://github.com/argoproj/argo-workflows/blob/master/workflow/controller/operator.go#L1432
Would you like to submit PR to fix?

I was going to to submit a PR but I wasn't able to reproduce it with Argo v3.1.2. For me it looks like this have been fixed with this PR: #5565. And v3.1.2 has this changes.


FYI: Download links about Android APKs for piper models

Now you can try piper models on your Android phones.
The following languages are supported:

English
French
Spanish
German

Community help is appreciated to convert more models from piper to sherpa-onnx.
Please see
https://k2-fsa.github.io/sherpa/onnx/tts/apk.html

@csukuangfj Sorry for my noob question. When I convert a fine-tuned coqui tts vits-ljs model to onnx using the code here, i only got the onnx export. The android code expects  tokens.txt and lexicon. How can i get those too? and will this work with coqui tts models?

@anita-smith1
Can you find the code about how to convert a word to phonemes for vits models from coqui?
If you can provide that, I can provide scripts to generate lexicon.txt and tokens.txt and also model.onnx from coqui.

@anita-smith1
I just managed to convert vits models from coqui to sherpa-onnx.
Will post a colab notebook to show you how to do that.
You can use the converted model in sherpa-onnx, e.g., build an Android App with sherpa-onnx.

@csukuangfj I am also facing same issue with coqui vits model for android tts . Sharing your code on how to export onxx,lexicon and tokens will be very valuable to the community. As you can see from coqui #407 discussion

@anita-smith1
@nanaghartey
I just created a colab notebook to show how to export the VITS models from
https://github.com/coqui-ai/TTS
to onnx
and how to generate tokens.txt and lexicon.txt so that you can use the exported
model with sherpa-onnx.
Please see
https://colab.research.google.com/drive/1cI9VzlimS51uAw4uCR-OBeSXRPBc4KoK?usp=sharing

@csukuangfj Thanks for sharing how to export. I run your colab notebook without using my model. Everything is generated but when i use it in the sherpa-onnx tts android demo app, it crashes. The app loads the model, lexicon and tokens all right but when you tap "Generate" the app crashes with:
2023-11-10 17:39:10.825 18430-18430 sherpa-onnx             com.k2fsa.sherpa.onnx                W  string is: how are you doing
2023-11-10 17:39:10.825 18430-18430 sherpa-onnx             com.k2fsa.sherpa.onnx                W  Raw text: how are you doing
2023-11-10 17:39:10.826 18430-18430 libc                    com.k2fsa.sherpa.onnx                A  Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x38333501 in tid 18430 (fsa.sherpa.onnx), pid 18430 (fsa.sherpa.onnx)
2023-11-10 17:39:11.148 18526-18526 DEBUG                   pid-18526                            A  Cmdline: com.k2fsa.sherpa.onnx
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A  pid: 18430, tid: 18430, name: fsa.sherpa.onnx  >>> com.k2fsa.sherpa.onnx <<<
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #00 pc<PHONE_NUMBER>3d65f8  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libonnxruntime.so (BuildId: 5bc662f139575789b099c8c4823a8ed1565a0d4c)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #01 pc<PHONE_NUMBER>3a9404  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libonnxruntime.so (BuildId: 5bc662f139575789b099c8c4823a8ed1565a0d4c)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #02 pc<PHONE_NUMBER>09f914  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libsherpa-onnx-core.so (Ort::detail::SessionImpl<OrtSession>::Run(Ort::RunOptions const&, char const* const*, Ort::Value const*, unsigned long, char const* const*, unsigned long)+204) (BuildId: c9b089160ce1cb938a4794e9c94d3a1636656712)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #03 pc<PHONE_NUMBER>124ba4  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libsherpa-onnx-core.so (sherpa_onnx::OfflineTtsVitsModel::Impl::RunVits(Ort::Value, long, float)+1128) (BuildId: c9b089160ce1cb938a4794e9c94d3a1636656712)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #04 pc<PHONE_NUMBER>123f9c  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libsherpa-onnx-core.so (sherpa_onnx::OfflineTtsVitsModel::Impl::Run(Ort::Value, long, float)+96) (BuildId: c9b089160ce1cb938a4794e9c94d3a1636656712)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #05 pc<PHONE_NUMBER>123ec0  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libsherpa-onnx-core.so (sherpa_onnx::OfflineTtsVitsModel::Run(Ort::Value, long, float)+48) (BuildId: c9b089160ce1cb938a4794e9c94d3a1636656712)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #06 pc<PHONE_NUMBER>1220a4  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libsherpa-onnx-core.so (sherpa_onnx::OfflineTtsVitsImpl::Generate(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&, long, float) const+1128) (BuildId: c9b089160ce1cb938a4794e9c94d3a1636656712)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #07 pc<PHONE_NUMBER>00a1a8  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libsherpa-onnx-jni.so (Java_com_k2fsa_sherpa_onnx_OfflineTts_generateImpl+316) (BuildId: 7c35f6abaaa0600b2d69ed7bf0aa62b69c017daa)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #14 pc<PHONE_NUMBER>002278  [anon:dalvik-classes3.dex extracted in memory from /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/base.apk!classes3.dex] (com.k2fsa.sherpa.onnx.OfflineTts.generate+0)
2023-11-10 17:39:11.150 18526-18526 DEBUG                   pid-18526                            A        #19 pc<PHONE_NUMBER>0012a0  [anon:dalvik-classes3.dex extracted in memory from /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/base.apk!classes3.dex] (com.k2fsa.sherpa.onnx.MainActivity.onClickGenerate+0)
2023-11-10 17:39:11.150 18526-18526 DEBUG                   pid-18526                            A        #24 pc<PHONE_NUMBER>001544  [anon:dalvik-classes3.dex extracted in memory from /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/base.apk!classes3.dex] (com.k2fsa.sherpa.onnx.MainActivity.onCreate$lambda$0+0)
2023-11-10 17:39:11.150 18526-18526 DEBUG                   pid-18526                            A        #29 pc<PHONE_NUMBER>001200  [anon:dalvik-classes3.dex extracted in memory from /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/base.apk!classes3.dex] (com.k2fsa.sherpa.onnx.MainActivity.$r8$lambda$OIkLpaHjEAmudVQGZZp-NNJ9rrA+0)
2023-11-10 17:39:11.150 18526-18526 DEBUG                   pid-18526                            A        #34 pc<PHONE_NUMBER>0011ac  [anon:dalvik-classes3.dex extracted in memory from /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/base.apk!classes3.dex] (com.k2fsa.sherpa.onnx.MainActivity$$ExternalSyntheticLambda0.onClick+0)
2023-11-10 17:39:11.150 18526-18526 DEBUG                   pid-18526                            A        #49 pc<PHONE_NUMBER>3074bc  [anon:dalvik-classes.dex extracted in memory from /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/base.apk] (com.google.android.material.button.MaterialButton.performClick+0)
---------------------------- PROCESS ENDED (18430) for package com.k2fsa.sherpa.onnx ----------------------------
2023-11-10 17:39:11.408  1190-1226  WindowManager           pid-1190                             E  win=Window{a478533 u0 com.k2fsa.sherpa.onnx/com.k2fsa.sherpa.onnx.MainActivity EXITING} destroySurfaces: appStopped=false cleanupOnResume=false win.mWindowRemovalAllowed=true win.mRemoveOnExit=true win.mViewVisibility=0 caller=com.android.server.wm.ActivityRecord.destroySurfaces:6536 com.android.server.wm.ActivityRecord.destroySurfaces:6517 com.android.server.wm.WindowState.onExitAnimationDone:5966 com.android.server.wm.ActivityRecord$$ExternalSyntheticLambda10.accept:2 java.util.ArrayList.forEach:1528 com.android.server.wm.ActivityRecord.onAnimationFinished:8605 com.android.server.wm.ActivityRecord.postApplyAnimation:6250

This is the model.onnx, lexicon.txt and token.txt generated from your notebook - https://drive.google.com/file/d/1ndZ5MSyS8482Eht6IP1jqxsMwIvB9Ln6/view?usp=sharing
This happens when i export and use  my fine-tuned coqui tts model too.
When running your notebook, this was the only error i encountered but i'm not sure that matters:
%%shell
pip install -q TTS:
 Preparing metadata (setup.py) ... done
......
  Building wheel for encodec (setup.py) ... done
  Building wheel for umap-learn (setup.py) ... done
  Building wheel for bnnumerizer (setup.py) ... done
  Building wheel for bnunicodenormalizer (setup.py) ... done
  Building wheel for docopt (setup.py) ... done
  Building wheel for gruut-ipa (setup.py) ... done
  Building wheel for gruut_lang_de (setup.py) ... done
  Building wheel for gruut_lang_en (setup.py) ... done
  Building wheel for gruut_lang_es (setup.py) ... done
  Building wheel for gruut_lang_fr (setup.py) ... done
  Building wheel for pynndescent (setup.py) ... done
  Building wheel for gruut (setup.py) ... done
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
lida 0.0.10 requires fastapi, which is not installed.
lida 0.0.10 requires kaleido, which is not installed.
lida 0.0.10 requires python-multipart, which is not installed.
lida 0.0.10 requires uvicorn, which is not installed.
plotnine 0.12.4 requires numpy>=1.23.0, but you have numpy 1.22.0 which is incompatible.
tensorflow 2.14.0 requires numpy>=1.23.5, but you have numpy 1.22.0 which is incompatible.

@csukuangfj Superr!
For converting piper models to sherpa-onnx using the provided colab notebook, i can confirm that it works on SherpaOnnxTTS
but for converting coqui tts vits model to sherpa onnx, using same android code, the android app crashes on all test devices

The app loads the model, lexicon and tokens all right but when you tap "Generate" the app crashes with:

@anita-smith1
Could you show more logs, something like below:
13:48.972 19945-19945 sherpa-onnx             com.k2fsa.sherpa.onnx                I  Start to initialize TTS
2023-11-11 11:13:49.063 19945-19945 sherpa-onnx             com.k2fsa.sherpa.onnx                W  config:
                                                                                OfflineTtsConfig(model=OfflineTtsModelConfig(vits=OfflineTtsVitsModelConfig(model="vits-coqui-en-vctk/model.onnx", lexicon="vits-coqui-en-vctk/lexicon.txt", tokens="vits-coqui-en-vctk/tokens.txt", noise_scale=0.667, noise_scale_w=0.8, length_scale=1), num_threads=2, debug=True, provider="cpu"), rule_fsts="")
2023-11-11 11:14:07.089 19945-19945 sherpa-onnx             com.k2fsa.sherpa.onnx                W  ---vits model---
                                                                                punctuation=; : , . ! ? ¡ ¿ — … " « » “ ”
                                                                                add_blank=1
                                                                                sample_rate=22050
                                                                                language=English
                                                                                n_speakers=109
                                                                                comment=coqui
                                                                                model_type=vits

I need to see the model meta data output.

@csukuangfj Superr!
For converting piper models to sherpa-onnx using the provided colab notebook, i can confirm that it works on SherpaOnnxTTS
but for converting coqui tts vits model to sherpa onnx, using same android code, the android app crashes on all test devices

@nanaghartey
Could you post some logcat output for the crash?

@anita-smith1
From you error log,

2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #01 pc<PHONE_NUMBER>3a9404  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libonnxruntime.so (BuildId: 5bc662f139575789b099c8c4823a8ed1565a0d4c)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #02 pc<PHONE_NUMBER>09f914  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libsherpa-onnx-core.so (Ort::detail::SessionImpl<OrtSession>::Run(Ort::RunOptions const&, char const* const*, Ort::Value const*, unsigned long, char const* const*, unsigned long)+204) (BuildId: c9b089160ce1cb938a4794e9c94d3a1636656712)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #03 pc<PHONE_NUMBER>124ba4  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libsherpa-onnx-core.so (sherpa_onnx::OfflineTtsVitsModel::Impl::RunVits(Ort::Value, long, float)+1128) (BuildId: c9b089160ce1cb938a4794e9c94d3a1636656712)
2023-11-10 17:39:11.149 18526-18526 DEBUG                   pid-18526                            A        #04 pc<PHONE_NUMBER>123f9c  /data/app/~~VjPnUWg1_JmIAZyAeNh2fA==/com.k2fsa.sherpa.onnx-kZTE0P4iaYzmG76-wTSUZQ==/lib/arm64/libsherpa-onnx-core.so (sherpa_onnx::OfflineTtsVitsModel::Impl::Run(Ort::Value, long, float)+96) (BuildId:

It crashes in the function
sherpa_onnx::OfflineTtsVitsModel::Impl::RunVits

which does not look right. I think there is something wrong in the comment field of your model meta data.
It should be coqui or piper for models from coqui and piper.

@csukuangfj

The app loads the model, lexicon and tokens all right but when you tap "Generate" the app crashes with:

@anita-smith1
Could you show more logs, something like below:
13:48.972 19945-19945 sherpa-onnx             com.k2fsa.sherpa.onnx                I  Start to initialize TTS
2023-11-11 11:13:49.063 19945-19945 sherpa-onnx             com.k2fsa.sherpa.onnx                W  config:
                                                                                OfflineTtsConfig(model=OfflineTtsModelConfig(vits=OfflineTtsVitsModelConfig(model="vits-coqui-en-vctk/model.onnx", lexicon="vits-coqui-en-vctk/lexicon.txt", tokens="vits-coqui-en-vctk/tokens.txt", noise_scale=0.667, noise_scale_w=0.8, length_scale=1), num_threads=2, debug=True, provider="cpu"), rule_fsts="")
2023-11-11 11:14:07.089 19945-19945 sherpa-onnx             com.k2fsa.sherpa.onnx                W  ---vits model---
                                                                                punctuation=; : , . ! ? ¡ ¿ — … " « » “ ”
                                                                                add_blank=1
                                                                                sample_rate=22050
                                                                                language=English
                                                                                n_speakers=109
                                                                                comment=coqui
                                                                                model_type=vits

I need to see the model meta data output.

This is my log. Comment field says coqui but when I compare to yours I can see the numofspeakers is 0 for mine:
2023-11-11 04:17:49.611 14902-14902 sherpa-onnx             com.k2fsa.sherpa.onnx                I  Start to initialize TTS
2023-11-11 04:17:49.701 14902-14902 sherpa-onnx             com.k2fsa.sherpa.onnx                W  config:
                                                                                OfflineTtsConfig(model=OfflineTtsModelConfig(vits=OfflineTtsVitsModelConfig(model="original_colab_model/model.onnx", lexicon="original_colab_model/lexicon.txt", tokens="original_colab_model/tokens.txt", noise_scale=0.667, noise_scale_w=0.8, length_scale=1), num_threads=2, debug=True, provider="cpu"), rule_fsts="")
2023-11-11 04:17:51.634 14902-14902 libc                    com.k2fsa.sherpa.onnx                W  Access denied finding property "ro.mediatek.platform"
2023-11-11 04:18:00.766 14902-14902 sherpa-onnx             com.k2fsa.sherpa.onnx                W  ---vits model---
                                                                                punctuation=; : , . ! ? ¡ ¿ — … " « » “ ”
                                                                                add_blank=1
                                                                                sample_rate=22050
                                                                                language=English
                                                                                n_speakers=0
                                                                                comment=coqui
                                                                                model_type=vits
2023-11-11 04:18:06.575 14902-14902 sherpa-onnx             com.k2fsa.sherpa.onnx                I  Finish initializing TTS
2023-11-11 04:18:06.657 14902-14902 MSHandlerLifeCycle      com.k2fsa.sherpa.onnx                I  check: return. pkg=com.k2fsa.sherpa.onnx parent=null callers=com.android.internal.policy.DecorView.setVisibility:4411 android.app.ActivityThread.handleResumeActivity:5476 android.app.servertransaction.ResumeActivityItem.execute:54 android.app.servertransaction.ActivityTransactionItem.execute:45 android.app.servertransaction.TransactionExecutor.executeLifecycleState:176
2023-11-11 04:18:06.657 14902-14902 MSHandlerLifeCycle      com.k2fsa.sherpa.onnx                I  removeMultiSplitHandler: no exist. decor=DecorView@c4a4467[]
2023-11-11 04:18:06.684 14902-14945 NativeCust...ncyManager com.k2fsa.sherpa.onnx                D  [NativeCFMS] BpCustomFrequencyManager::BpCustomFrequencyManager()
2023-11-11 04:18:06.716 14902-14902 InsetsController        com.k2fsa.sherpa.onnx                D  onStateChanged: InsetsState: {mDisplayFrame=Rect(0, 0 - 1920, 1200),

@anita-smith1
Are you using the latest master of sherpa-onnx or the version >= v1.8.9?

@anita-smith1
Are you using the latest master of sherpa-onnx or the version >= v1.8.9?

I am using version 1.8.7. Same version used in the apks you originally shared

@anita-smith1
Are you using the latest master of sherpa-onnx or the version >= v1.8.9?

I just tried v1.8.9 and it worked :)

@anita-smith1
Are you using the latest master of sherpa-onnx or the version >= v1.8.9?

I just tried v1.8.9 and it worked :)

Glad to hear that it works for you.
By the way, we have pre-built Android APKs for the VITS English models from Coqui.

https://k2-fsa.github.io/sherpa/onnx/tts/apk.html

@anita-smith1
Are you using the latest master of sherpa-onnx or the version >= v1.8.9?

I just tried v1.8.9 and it worked :)

Glad to hear that it works for you.
By the way, we have pre-built Android APKs for the VITS English models from Coqui.

https://k2-fsa.github.io/sherpa/onnx/tts/apk.html

Thank you very much for your amazing support. It's incredible!
Now android demo works with my fine-tuned coqui models too. By the way, in case I want to use Java instead of kotlin for android, would I need to build from source? There seems to be only kotlin support for android at the moment.
Also are there plans to release same on-device tts for iOS too?

By the way, in case I want to use Java instead of kotlin for android, would I need to build from source?

Sorry that we only have Kotlin for Android demo. But the jni interface can also be used in Java.
You can reuse the .so files for java.
You can build sherpa-onnx from source for Android
by following https://k2-fsa.github.io/sherpa/onnx/android/index.html
if you want to use the latest master of sherpa-onnx.

Also are there plans to release same on-device tts for iOS too?

Yes, it is in the plan. We have already supported speech-to-text on iOS. Adding text-to-speech to iOS is very easy
with our current code in sherpa-onnx. We will do that in the coming week.

@csukuangfj That's great to hear!
I have another noob question:
I have a fine tuned coqui tts vits model that contains non-English words. I use a custom CMU.in.IPA.txt and custom all-english-words.txt file for the non-English words (with few English words). When I synthesise using the cell that contains this code:
   ......
def main():
 model = OnnxModel("./model.onnx")
 text = "xse wo atua de a fa"
 x = vits.tokenizer.text_to_ids(text, vits.tokenizer)
 x = torch.tensor(x, dtype=torch.int64)
 y = model(x)
 print(y.shape)
 soundfile.write("test.wav", y.numpy(), model.sample_rate)

main()

Everything works. The pronunciation is good. However when I use:
sherpa-onnx-offline-tts \
  --vits-model=./model.onnx \
  --vits-lexicon=./lexicon.txt \
  --vits-tokens=./tokens.txt \
  --output-filename=./test.wav \
  "xse wo atua de a fa"

I get unexpected results - the pronunciations are wrong. Even for the few English words.
This is a sample of my ipa.txt file which contains both non-english and few English words:
a,              ʌ
atua,           ejtujʌ
call,           kɔˈl
de,             ðʌ
din,            diˈn
edin,           ejdiˈn
fa,             fʌ
frq,            fɹɛ
line,           lajˈn
mma,            mɑˈ
mobile,         mowˈbʌl
na,             nɑˈ
naa,            nɑˈɑˈ
ndrope,         ɪŋdɹɑˌpi
ne,             nɪ
no,             nu
nreflecte,      ɪŋɹʌflɛˈktɪ
nxma,           nɔmbɚ

all-english-words.txt contains all the words. I followed the same format used in the original English list and I used a phoneme to IPA converter.
What do I need to do to make this work? Thank you

I used a phoneme to IPA converter.

Please add your words to all-english-words.txt and let the code generate the pronunciations for you.
The pronunciations in CMU.in.IPA.txt  are discarded and are never used. Only the first column, i.e., the words,
is used in CMU.in.IPA.txt.
Please don't use an IPA converter to generate pronunciations for your new words.
The code uses get_phones in one cell from the colab to generate pronunciations for a given word.

@csukuangfj you are right! It's better now, though there is still some difference ( a slight loss in pronunciation  compared to the original coqui model).
Is the order of the words I add important? I added them at the bottom of all-english-words.txt file. Also, is anything else I can do to improve the pronunciations on sherpa-onnx?

Hi @csukuangfj,
Why not make an Android port of piper_phonemize and use it in next gen TTS instead of a lexicon? These voices could be used in a screen reader in the future, and there will be many words will try to read that may not be in that lexicon.

Why not make an Android port of piper_phonemize and use it in next gen TTS instead of a lexicon?

We try to support as many models as possible, including models not from piper, which may not use piper_phonemize.

there will be many words will try to read that may not be in that lexicon

We can add OOV words to the lexicon.txt manually. By the way, the lexicon.txt already covers lots of words.

Is the order of the words I add important?

The order does not matter as long as you don't add duplicate words.
If you add duplicate words, then the first one has a higher priority and later ones are ignored.

is anything else I can do to improve the pronunciations on sherpa-onnx?

I realized that a word that appears in a sentence with other words can have a different pronunciation from when it appears standalone.  I am afraid it is hard, if not impossible, to improve the pronunciations with the current approach.

I am not sure you can cover everything.
It might be better to make a condition and use piper_phonemize for piper models.
Yes, this will result in adding espeak-ng, but it will be much better
than adding words manually
On 11/14/23, Fangjun Kuang @.***> wrote:

Why not make an Android port of piper_phonemize and use it in next gen TTS
instead of a lexicon?

We try to support as many models as possible, including models not from
piper, which may not use piper_phonemize.

there will be many words will try to read that may not be in that lexicon

We can add OOV words to the lexicon.txt manually. By the way, the
lexicon.txt already covers lots of words.
--
Reply to this email directly or view it on GitHub:
https://github.com/rhasspy/piper/issues/257#issuecomment-1809946186
You are receiving this because you commented.
Message ID: @.***>

--
with best regards Beqa Gozalishvili
Tell: +995593454005
Email: @.***
Web: https://gozaltech.org
Skype: beqabeqa473
Telegram: https://t.me/gozaltech
facebook: https://facebook.com/gozaltech
twitter: https://twitter.com/beqabeqa473
Instagram: https://instagram.com/beqa.gozalishvili

Maybe a better approach is to change the modeling unit from phones to other units that can be entirely derived from words.

@csukuangfj true, when single words have poor pronunciations. However, I like the fact that this tts solution works offline. By the way has the iOS version been released?

And importantly, has the iOS version been released

I am writing the code now. Please wait a day or two.

@csukuangfj wow can't wait :)  your work is amazing

@anita-smith1
The iOS demo is ready now.
You can run text-to-speech with Next-gen Kaldi on iOS using
https://github.com/k2-fsa/sherpa-onnx/pull/443
I have recorded a video showing how to use it. Please see
https://www.youtube.com/watch?v=MvePdkuMNJk

single words seem to have poor pronunciations compared to same words in phrases

Don't worry. I will try to fix it.

@csukuangfj incredible. that was quick! The video demo is fantastic. Great Job!  but for me seems I'd have to wait since my project does not use swiftUI. It only uses uikit. I can see you have this to help us build the android from source. Can you add documentation for iOS too? so we can build our iOS too from source

Please see
https://k2-fsa.github.io/sherpa/onnx/ios/build-sherpa-onnx-swift.html#build-sherpa-onnx-in-commandline-c-part
for doc.

Please see
https://k2-fsa.github.io/sherpa/onnx/ios/build-sherpa-onnx-swift.html#build-sherpa-onnx-in-commandline-c-part
for doc.
okay thank you

Please see
https://k2-fsa.github.io/sherpa/onnx/ios/build-sherpa-onnx-swift.html#build-sherpa-onnx-in-commandline-c-part
for doc.

Thank you

Is it possible to add my custom model? Here is the link:

If you want to check it out, it can be unpacked with:
tar --lzma --extract --file ivona_hq.tar.lzma

Ive been wanting to use this voice but the original application is 32bit and nearly 15 years old at this point. Its being held together by threads.

is it a vits model? could you show the extracted files?

Is it possible to add my custom model? Here is the link: /ivona_hq.tar.lzma
If you want to check it out, it can be unpacked with:
tar --lzma --extract --file ivona_hq.tar.lzma

Ive been wanting to use this voice but the original application is 32bit and nearly 15 years old at this point. Its being held together by threads.

@sweetbbak
I just looked at the model and found that it is piper-based, so it is definitely supported by sherpa-onnx.
I have converted the model. You can find it at
https://github.com/k2-fsa/sherpa-onnx/releases/tag/tts-models

I have also added it to
https://huggingface.co/spaces/k2-fsa/text-to-speech

For the following text:
“Today as always, men fall into two
groups: slaves and free men. Whoever does not
have two-thirds of his day for himself, is a slave, whatever he
may be: a statesman, a businessman, an official, or a scholar.”

It generates the following audio:
https://github.com/rhasspy/piper/assets/5284924/9a2d2869-5272-4eb0-8f28-c705fbee4c05

By the way, you can also find the exported model at
https://huggingface.co/csukuangfj/vits-piper-en_US-sweetbbak-amy/tree/main
The above repo also contains the script for exporting.

@sweetbbak
The audio sounds like British English, but the JSON config file says the voice is en-us. Is there something wrong?

Thank you so much! Thats my mistake, more than likely. I believe I used en_US-amy as a base to fine-tune off of because it sounded better. So I was unsure if it should be marked as en_US or en_GB. Its definitely a British voice.

Thank you so much! Thats my mistake, more than likely. I believe I used en_US-amy as a base to fine-tune off of because it sounded better. So I was unsure if it should be marked as en_US or en_GB. Its definitely a British voice.

I am changing it to en_GB.

I appreciate it.

@beqabeqa473

@csukuangfj thanks for your work.
To evaluate models it would be great to implement android tts engine api.

Im very new to working with android let alone with tts apis. Would it be possible to lead me in the right direction to trying to develope a android tts engine api? I have found some examples of offline-tts though im trying to figure how convert this into a engine api.  I was thinking some of these would be useful ((TTS service wrapper)[https://github.com/BentiGorlich/android-mimic3-tts-engine-wrapper], (TTS-engine)[https://github.com/aiyu-ayaan/tts-engine]), I think i just need some guidance as I am lost in a sea of knowledge. Let me know what you think.

TTS-engine

Please wait for a moment. I have managed to create a tts engine service that you can use to replace the system tts engine.
I will create a PR soon.

I will create a PR soon.
@csukuangfj
Woah that is legendary. I'd love to explore what you did to do this, I'm interested in learning. I'll hold tight. Thanks

I am also working on that.
I have already a working prototype of piper tts engine for android
with downloading and installing voices.
I will make repo public soon
On 12/31/23, ekul_ @.***> wrote:

I will create a PR soon.
@csukuangfj
Woah that is legendary. I'd love to explore what you did to do this, I'm
interested in learning. I'll hold tight. Thanks

--
Reply to this email directly or view it on GitHub:
https://github.com/rhasspy/piper/issues/257#issuecomment-1872655597
You are receiving this because you were mentioned.
Message ID: @.***>

--
with best regards Beqa Gozalishvili
Tell: +995593454005
Email: @.***
Web: https://gozaltech.org
Skype: beqabeqa473
Telegram: https://t.me/gozaltech
facebook: https://facebook.com/gozaltech
twitter: https://twitter.com/beqabeqa473
Instagram: https://instagram.com/beqa.gozalishvili

I will create a PR soon.
@csukuangfj
Woah that is legendary. I'd love to explore what you did to do this, I'm interested in learning. I'll hold tight. Thanks
Sorry for my naivety, What does PR stand for?

@LuekWasHere
PR is short for pull request.

I just created one at https://github.com/k2-fsa/sherpa-onnx/pull/508
You can find a YouTube video at
https://www.youtube.com/watch?v=33QYuVzDORA

By the way, you can download pre-built text-to-speech engine APKs at
https://k2-fsa.github.io/sherpa/onnx/tts/apk-engine.html

@csukuangfj  Awesome repo Fangjun Kuang ! do you know if anybody is working on a dart package for next gen Kaldi to be used on android and iOS ?

@Web3Kev
Yes, please see
https://github.com/k2-fsa/sherpa-onnx/issues/379

thanks !

@csukuangfj Awesome repo Fangjun Kuang ! do you know if anybody is working on a dart package for next gen Kaldi to be used on android and iOS ?

@Web3Kev  Yes, we have now. Please see
https://pub.dev/packages/sherpa_onnx

We have flutter TTS demo for Piper. Please see
https://github.com/k2-fsa/sherpa-onnx/tree/master/flutter-examples/tts

@csukuangfj @beqabeqa473 or Anyone (Help Please) I am not advanced enough to get into the coding of this model etc...
I am just trying to get it to work on Android for use in my Accessibility TTS readers. I see there were created apks https://k2-fsa.github.io/sherpa/onnx/tts/apk-engine.html .
When I install on my Google Pixel it only allows one to be used at a time (no input or way to change to a different voice's apk under the app)? It installs the new voice over the same APK from the download.
Is there a easier way to do this with Fdroid app where you can just select the voice you want off the onnx voices?
Thanks,
DD.


Can't install extension properly

Type: Bug

Click update button in extention page

2024-12-19 10:43:50.754 [info] Getting Manifest... llvm-vs-code-extensions.vscode-clangd
2024-12-19 10:43:51.633 [info] Installing extension: llvm-vs-code-extensions.vscode-clangd {"pinned":true,"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/Administrator/.vscode/extensions/extensions.json","path":"/c:/Users/Administrator/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 10:44:22.523 [error] [network] #5: https://llvm-vs-code-extensions.gallerycdn.vsassets.io/extensions/llvm-vs-code-extensions/vscode-clangd/0.1.33/1732259347312/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&update=true - error GET net::ERR_TIMED_OUT
2024-12-19 10:44:52.633 [error] [network] #6: https://llvm-vs-code-extensions.gallerycdn.vsassets.io/extensions/llvm-vs-code-extensions/vscode-clangd/0.1.33/1732259347312/Microsoft.VisualStudio.Services.VSIXPackage?update=true - error GET net::ERR_TIMED_OUT
2024-12-19 10:44:52.634 [warning] Failed downloading vsix. net::ERR_TIMED_OUT.  无法写入文件"c:\Users\Administrator\AppData\Roaming\Code\CachedExtensionVSIXs\.06ca40a7-ce43-493f-a1d4-3a3cf884e5c7"(Error: net::ERR_HTTP2_PING_FAILED). Retry again... llvm-vs-code-extensions.vscode-clangd
2024-12-19 10:47:11.339 [error] [network] #14: https://llvm-vs-code-extensions.gallerycdn.vsassets.io/extensions/llvm-vs-code-extensions/vscode-clangd/0.1.33/1732259347312/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&update=true - error GET net::ERR_TIMED_OUT
2024-12-19 10:47:21.354 [warning] Failed downloading vsix. 无法写入文件"c:\Users\Administrator\AppData\Roaming\Code\CachedExtensionVSIXs\.ef1c2f0e-052a-470b-aede-ef4f6fdeca7d"(Error: net::ERR_HTTP2_PING_FAILED).  Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2024-12-19 10:43:30.915 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'ms-python.python' wants API proposal 'contribIssueReporter' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2024-12-19 10:43:30.915 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'ms-python.debugpy' wants API proposal 'contribIssueReporter' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2024-12-19 10:43:31.540 [info] Started local extension host with pid 17092.
2024-12-19 10:43:32.070 [error] Extension 'ms-python.debugpy' wants API proposal 'contribIssueReporter' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2024-12-19 10:43:32.070 [error] Extension 'ms-python.python' wants API proposal 'contribIssueReporter' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2024-12-19 10:43:32.167 [warning] [REditorSupport.r]: 无法注册“r.rpath.windows”。此属性已注册。
2024-12-19 10:43:32.168 [warning] [REditorSupport.r]: 无法注册“r.rpath.mac”。此属性已注册。
2024-12-19 10:43:32.168 [warning] [REditorSupport.r]: 无法注册“r.rpath.linux”。此属性已注册。
 Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `Code --trace-deprecation ...` to show where the warning was created)
2024-12-19 10:43:55.118 [error] 无法解析不存在的文件 'vscode-userdata:/c:/Users/Administrator/AppData/Roaming/Code/User/globalStorage/llvm-vs-code-extensions.vscode-clangd': Error: 无法解析不存在的文件 'vscode-userdata:/c:/Users/Administrator/AppData/Roaming/Code/User/globalStorage/llvm-vs-code-extensions.vscode-clangd'
    at _ot.resolve (vscode-file://vscode-app/d:/soft/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3108:60549)
    at async BTt (vscode-file://vscode-app/d:/soft/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:480:44682)
2024-12-19 10:50:01.495 [error] [uncaught exception in main]: Titlebar overlay is not enabled: Error: Titlebar overlay is not enabled
    at vu.updateWindowControls (file:///D:/soft/Microsoft%20VS%20Code/resources/app/out/main.js:71:49452)
    at vu.n (file:///D:/soft/Microsoft%20VS%20Code/resources/app/out/main.js:71:47265)
    at vu.Q (file:///D:/soft/Microsoft%20VS%20Code/resources/app/out/main.js:80:8705)
    at vu.tryClaimWindow (file:///D:/soft/Microsoft%20VS%20Code/resources/app/out/main.js:80:8475)
    at App.<anonymous> (file:///D:/soft/Microsoft%20VS%20Code/resources/app/out/main.js:80:9718)
    at App.emit (node:events:518:28)
    at n._init (node:electron/js2c/browser_init:2:12818)
    at openGuestWindow (node:electron/js2c/browser_init:2:101599)
    at WebContents.<anonymous> (node:electron/js2c/browser_init:2:89067)
    at WebContents.emit (node:events:518:28)
2024-12-19 10:51:59.136 [error] Error: net::ERR_CONNECTION_RESET
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/utility_init:2:10511)
    at SimpleURLLoaderWrapper.emit (node:events:518:28)
2024-12-19 10:51:59.151 [error] net::ERR_CONNECTION_RESET: Error: net::ERR_CONNECTION_RESET
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/utility_init:2:10511)
    at SimpleURLLoaderWrapper.emit (node:events:518:28)

When I install extension on WSL, it also crashed.

I uninstall vscode and delete user-data in User/AppData/Roaming/Code and User/.vscode, then I download latest vscode and install again. But the error still exists.

Good news. I installed VSCode(1.95.3) and I can install extension properly.

same issue

I'm also unable to install or upgrade any extensions.
Then I downloaded the files in .vsix format from the extension marketplace to install them manually, but that failed as well.

Same here.

@dwpeng May I know if you are still seeing this issue? If so, please share the shared log again?

@dwpeng May I know if you are still seeing this issue? If so, please share the shared log again?

2024-12-19 23:32:43.254 [info] Getting Manifest... baiducomate.comate
2024-12-19 23:32:43.254 [info] Getting Manifest... marscode.marscode-extension
2024-12-19 23:32:43.255 [info] Getting Manifest... ms-python.python
2024-12-19 23:32:43.256 [info] Getting Manifest... pkief.material-icon-theme
2024-12-19 23:32:43.256 [info] Getting Manifest... redhat.java
2024-12-19 23:32:43.756 [info] Installing extension: ms-python.python {"installPreReleaseVersion":true,"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"pinned":false,"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/shaoping/.vscode/extensions/extensions.json","path":"/c:/Users/shaoping/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 23:32:43.824 [info] Installing extension: redhat.java {"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"pinned":false,"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/shaoping/.vscode/extensions/extensions.json","path":"/c:/Users/shaoping/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 23:32:43.891 [info] Installing extension: baiducomate.comate {"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"pinned":false,"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/shaoping/.vscode/extensions/extensions.json","path":"/c:/Users/shaoping/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 23:32:43.891 [info] Installing extension: marscode.marscode-extension {"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"pinned":false,"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/shaoping/.vscode/extensions/extensions.json","path":"/c:/Users/shaoping/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 23:32:44.110 [info] Installing extension: pkief.material-icon-theme {"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"pinned":false,"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/shaoping/.vscode/extensions/extensions.json","path":"/c:/Users/shaoping/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 23:33:14.277 [error] [network] #11: https://redhat.gallerycdn.vsassets.io/extensions/redhat/java/1.38.0/1734613995676/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&targetPlatform=win32-x64&update=true - error GET net::ERR_TIMED_OUT
2024-12-19 23:33:24.289 [warning] Error while deleting the file file:///c%3A/Users/shaoping/AppData/Roaming/Code/CachedExtensionVSIXs/.ec12d5cd-03f8-4b3e-9eda-afe51934489b Unable to delete nonexistent file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs.ec12d5cd-03f8-4b3e-9eda-afe51934489b'
2024-12-19 23:33:24.290 [warning] Failed downloading vsix. Unable to write file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs.ec12d5cd-03f8-4b3e-9eda-afe51934489b' (Error: net::ERR_HTTP2_PING_FAILED). Retry again... pkief.material-icon-theme
2024-12-19 23:33:34.303 [warning] Error while deleting the file file:///c%3A/Users/shaoping/AppData/Roaming/Code/CachedExtensionVSIXs/.20059cc3-f64f-4a65-983d-bb56d97ebb1d Unable to delete nonexistent file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs.20059cc3-f64f-4a65-983d-bb56d97ebb1d'
2024-12-19 23:33:34.304 [warning] Failed downloading vsix. Unable to write file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs.20059cc3-f64f-4a65-983d-bb56d97ebb1d' (Error: net::ERR_HTTP2_PING_FAILED). Retry again... ms-python.python
2024-12-19 23:33:44.305 [error] [network] #26: https://redhat.gallerycdn.vsassets.io/extensions/redhat/java/1.38.0/1734613995676/Microsoft.VisualStudio.Services.VSIXPackage?targetPlatform=win32-x64&update=true - error GET net::ERR_HTTP2_PING_FAILED
2024-12-19 23:33:44.307 [warning] Failed downloading vsix. net::ERR_HTTP2_PING_FAILED. Retry again... redhat.java
2024-12-19 23:33:44.311 [warning] Error while deleting the file file:///c%3A/Users/shaoping/AppData/Roaming/Code/CachedExtensionVSIXs/.d78cb01d-3319-431e-b5b2-70e6a3503945 Unable to delete nonexistent file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs.d78cb01d-3319-431e-b5b2-70e6a3503945'
2024-12-19 23:33:44.311 [warning] Failed downloading vsix. Unable to write file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs.d78cb01d-3319-431e-b5b2-70e6a3503945' (Error: net::ERR_HTTP2_PING_FAILED). Retry again... baiducomate.comate
2024-12-19 23:33:54.320 [error] [network] #29: https://pkief.gallerycdn.vsassets.io/extensions/pkief/material-icon-theme/5.16.0/1734449103902/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&update=true - error GET net::ERR_HTTP2_PING_FAILED
2024-12-19 23:33:54.323 [warning] Error while deleting the file file:///c%3A/Users/shaoping/AppData/Roaming/Code/CachedExtensionVSIXs/.7b9c00aa-b2b6-40c5-ad48-b8054cbba9b0 Unable to delete nonexistent file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs.7b9c00aa-b2b6-40c5-ad48-b8054cbba9b0'
2024-12-19 23:33:54.323 [warning] Failed downloading vsix. Unable to write file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs.7b9c00aa-b2b6-40c5-ad48-b8054cbba9b0' (Error: net::ERR_HTTP2_PING_FAILED). Retry again... marscode.marscode-extension

test

@dwpeng May I know if you are still seeing this issue? If so, please share the shared log again?

2024-12-19 23:32:43.254 [info] Getting Manifest... baiducomate.comate
2024-12-19 23:32:43.254 [info] Getting Manifest... marscode.marscode-extension
2024-12-19 23:32:43.255 [info] Getting Manifest... ms-python.python
2024-12-19 23:32:43.256 [info] Getting Manifest... pkief.material-icon-theme
2024-12-19 23:32:43.256 [info] Getting Manifest... redhat.java
2024-12-19 23:32:43.756 [info] Installing extension: ms-python.python {"installPreReleaseVersion":true,"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"pinned":false,"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/shaoping/.vscode/extensions/extensions.json","path":"/c:/Users/shaoping/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 23:32:43.824 [info] Installing extension: redhat.java {"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"pinned":false,"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/shaoping/.vscode/extensions/extensions.json","path":"/c:/Users/shaoping/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 23:32:43.891 [info] Installing extension: baiducomate.comate {"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"pinned":false,"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/shaoping/.vscode/extensions/extensions.json","path":"/c:/Users/shaoping/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 23:32:43.891 [info] Installing extension: marscode.marscode-extension {"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"pinned":false,"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/shaoping/.vscode/extensions/extensions.json","path":"/c:/Users/shaoping/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 23:32:44.110 [info] Installing extension: pkief.material-icon-theme {"productVersion":{"version":"1.96.1","date":"2024-12-17T17:50:05.206Z"},"pinned":false,"operation":3,"isApplicationScoped":false,"profileLocation":{"$mid":1,"external":"vscode-userdata:/c%3A/Users/shaoping/.vscode/extensions/extensions.json","path":"/c:/Users/shaoping/.vscode/extensions/extensions.json","scheme":"vscode-userdata"},"installOnlyNewlyAddedFromExtensionPack":true}
2024-12-19 23:33:14.277 [error] [network] #11: https://redhat.gallerycdn.vsassets.io/extensions/redhat/java/1.38.0/1734613995676/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&targetPlatform=win32-x64&update=true - error GET net::ERR_TIMED_OUT
2024-12-19 23:33:24.289 [warning] Error while deleting the file file:///c%3A/Users/shaoping/AppData/Roaming/Code/CachedExtensionVSIXs/.ec12d5cd-03f8-4b3e-9eda-afe51934489b Unable to delete nonexistent file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs\.ec12d5cd-03f8-4b3e-9eda-afe51934489b'
2024-12-19 23:33:24.290 [warning] Failed downloading vsix. Unable to write file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs\.ec12d5cd-03f8-4b3e-9eda-afe51934489b' (Error: net::ERR_HTTP2_PING_FAILED). Retry again... pkief.material-icon-theme
2024-12-19 23:33:34.303 [warning] Error while deleting the file file:///c%3A/Users/shaoping/AppData/Roaming/Code/CachedExtensionVSIXs/.20059cc3-f64f-4a65-983d-bb56d97ebb1d Unable to delete nonexistent file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs\.20059cc3-f64f-4a65-983d-bb56d97ebb1d'
2024-12-19 23:33:34.304 [warning] Failed downloading vsix. Unable to write file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs\.20059cc3-f64f-4a65-983d-bb56d97ebb1d' (Error: net::ERR_HTTP2_PING_FAILED). Retry again... ms-python.python
2024-12-19 23:33:44.305 [error] [network] #26: https://redhat.gallerycdn.vsassets.io/extensions/redhat/java/1.38.0/1734613995676/Microsoft.VisualStudio.Services.VSIXPackage?targetPlatform=win32-x64&update=true - error GET net::ERR_HTTP2_PING_FAILED
2024-12-19 23:33:44.307 [warning] Failed downloading vsix. net::ERR_HTTP2_PING_FAILED. Retry again... redhat.java
2024-12-19 23:33:44.311 [warning] Error while deleting the file file:///c%3A/Users/shaoping/AppData/Roaming/Code/CachedExtensionVSIXs/.d78cb01d-3319-431e-b5b2-70e6a3503945 Unable to delete nonexistent file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs\.d78cb01d-3319-431e-b5b2-70e6a3503945'
2024-12-19 23:33:44.311 [warning] Failed downloading vsix. Unable to write file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs\.d78cb01d-3319-431e-b5b2-70e6a3503945' (Error: net::ERR_HTTP2_PING_FAILED). Retry again... baiducomate.comate
2024-12-19 23:33:54.320 [error] [network] #29: https://pkief.gallerycdn.vsassets.io/extensions/pkief/material-icon-theme/5.16.0/1734449103902/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&update=true - error GET net::ERR_HTTP2_PING_FAILED
2024-12-19 23:33:54.323 [warning] Error while deleting the file file:///c%3A/Users/shaoping/AppData/Roaming/Code/CachedExtensionVSIXs/.7b9c00aa-b2b6-40c5-ad48-b8054cbba9b0 Unable to delete nonexistent file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs\.7b9c00aa-b2b6-40c5-ad48-b8054cbba9b0'
2024-12-19 23:33:54.323 [warning] Failed downloading vsix. Unable to write file 'c:\Users\shaoping\AppData\Roaming\Code\CachedExtensionVSIXs\.7b9c00aa-b2b6-40c5-ad48-b8054cbba9b0' (Error: net::ERR_HTTP2_PING_FAILED). Retry again... marscode.marscode-extension

Following request https://redhat.gallerycdn.vsassets.io/extensions/redhat/java/1.38.0/1734613995676/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&targetPlatform=win32-x64 has timed out  - GET net::ERR_TIMED_OUT . Can you please try downloading it manually and let me know if it works?

Following request https://redhat.gallerycdn.vsassets.io/extensions/redhat/java/1.38.0/1734613995676/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&targetPlatform=win32-x64 has timed out - GET net::ERR_TIMED_OUT . Can you please try downloading it manually and let me know if it works?

Yes, extensions can works normally after manual download and installation.

Now, my vscode upgrade to 1.96.2 now can install/upgrade extension. But I found another two error logs.

Click Details tab in extension home page.

install/uninstall a extension.

I'm using 1.96.2, but still can't install some extensions and their updates.

Same issue: #236224.

Same issue: #236224.

Also can not install extension until now.

Same issue: #236224.

Also can not install extension until now.

You can have a try to disable setting extensions.gallery.useUnpkgResourceApi, maybe it works.

extensions.gallery.useUnpkgResourceApi

Is using unpkg to download updates for the extension the root cause of this problem? Perhaps this configuration extensions.gallery.useUnpkgResourceApi is not using the local proxy correctly.

@dwpeng
Nice. I did try that disabling extensions.gallery.useUnpkgResourceApi makes the extension install updates work fine again.

@dwpeng Nice. I did try that disabling extensions.gallery.useUnpkgResourceApi makes the extension install updates work fine again.

Good news!
I found v1.96's ChangeLog optimized-extension-updates-with-vscodeunpkg-service said that vscode enable vscode-unpkg as default. There may be a bug while using vscode-unpkg.


Change to use @interactors/html in sample app

Motivation
I ran interactors-sample and cypress tests failed. Then I realized that Jest and BigTest are not using @interactors/html.
Approach
Change to use @interactors/html
TODO
How do I test this?

I added @interactors/html to all templates because cypress, bigtest, jest will all need them.
This means it's optional for the bigtest tests at the moment because bigtest ships with interactors but may not be the case in the future.
I also removed bigtest from jest because we only needed it for interactors.


SSR compilation issue on iView and bootstrap-vue

I've tried to install iView and bootstrap-vue components with vue-started one by one according to instructions on their websites.
Everything works fine until the first time SSR happens. Looks like the issue is related to vue-starter because few Vue libraries fails the same way.
This is the error:
[1] error: error during rendering: /shop; error: {"stack":"/Users/alex/Workspace/kmb-ts/vue-starter-master/node_modules/iview/dist/styles/iview.css:1\n(function (exports, require, module, __filename, __dirname) { .ivu-load-loop{-webkit-animation:ani-load-loop 1s linear infinite;animation:ani-load-loop 1s linear infinite}@-webkit-keyframes ani-load-loop{from{-webkit-transform:rotate(0);transform:rotate(0)}50%{-webkit-transform:rotate(180deg);transform:rotate(180deg)}to{-webkit-transform:rotate(360deg);transform:rotate(360deg)}}@keyframes ani-load-loop{from{-webkit-transform:rotate(0);transform:rotate(0)}50%{-webkit-transform:rotate(180deg);transform:rotate(180deg)}to{-webkit-transform:rotate(360deg);transform:rotate(360deg)}}.input-group-error-append,.input-group-error-prepend{background-color:#fff;border:1px solid #ed4014}.input-group-error-append .ivu-select-selection,.input-group-error-prepend .ivu-select-selection{background-color:inherit;border:1px solid transparent}.input-group-error-prepend{border-right:0}.input-group-error-append{border-left:0}.ivu-breadcr\n\nSyntaxError: Unexpected token .\n    at new Script (vm.js:74:7)\n    at createScript (vm.js:246:10)\n    at Object.runInThisContext (vm.js:298:10)\n    at Module._compile (internal/modules/cjs/loader.js:657:28)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)\n    at Module.load (internal/modules/cjs/loader.js:599:32)\n    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)\n    at Function.Module._load (internal/modules/cjs/loader.js:530:3)\n    at Module.require (internal/modules/cjs/loader.js:637:17)\n    at require (internal/modules/cjs/helpers.js:20:18)\n    at r (/Users/alex/Workspace/kmb-ts/vue-starter-master/node_modules/vue-server-renderer/build.js:8335:16)\n    at eval (webpack-internal:///iview/dist/styles/iview.css:1:18)\n    at Object.iview/dist/styles/iview.css (isomorphic.js:626:1)\n    at __webpack_require__ (isomorphic.js:27:30)\n    at eval (webpack-internal:///./src/app/app.ts:16:85)\n    at Module../src/app/app.ts (isomorphic.js:224:1)","message":"Unexpected token ."}
Basically whenever .css file is added from within the node_packages folder the error happens.
Any ideas where to look in order to solve it?
Could be an integration issue related to webpack 4, it's plugins, TypeScript or isomorphic.ts

Hey @zelid thanks for reporting this.
I will try to reproduce it later this week and come back to you. My first guess is that you have to add a webpack-loader for CSS files in the webpack base config. because the vue-starter is just set up for SCSS/SASS.
You can try it by adding one in the meantime and see if it works.

@zelid see the new documentation section: https://vue-starter.herokuapp.com/docs/guide/third-party.html
this should help you even if it's a guide for vuetify.


[Navigation Reboot] Swap the DrawerNavigator for the ResponsiveNavigator (WIP)

Details
Work in progress. Putting it here to make it easier to cooperate
Fixed Issues

$ https://github.com/Expensify/App/issues/15848
$ https://github.com/Expensify/App/issues/15851
$ https://github.com/Expensify/App/issues/15852
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I think this is kinda ready for testing but in limited scope.
@adamgrzybowski would you be bale to describe what should bre ready to be tested here or give some guidance for the team once ready? Thanks!

Hi! I think it's a good time to start some testing and look for what is missing. As you may notice, this may be a bit unusual because work is still in progress and we are assuming that there are bugs here.
That's why I need your help! Those are quite big changes. It would be hard for me to check every place where something could break after this refactor and continue development in the meantime.
The parts that you should focus on are related to the navigation, especially actions around the report screen and the report list. But it would be great to do some general testing.
The part that you shouldn't really focus on now is navigating between screens in the right modal e.g. /settings -> /settings/profile. This part is yet to be done in other PR.
There are a few issues that I am aware but I am still working on them:

Lag after opening a report from the report list (there should be a loader here)
Using /concierge page to navigate to the report.
When using the back button it's possible that highlighting the current report on the sidebar won't update.

Have in mind that the pattern of navigation has changed a little and now there is a possibility to push multiple report screens on the stack
I see a request about the details in the PR but I guess it would be best to fill it in when removing the draft status
Thanks for your help! Let me know if you need some more information.
cc: @parasharrajat @mountiny

Thanks! C+ could yu try to test push notifications too?

BUG: WEB: Firefox: Using the Back arrow does not update the selected report on Sidebar.
Steps:

Open the App on the web.
Change a few reports by clicking them on the LHN.
use the Back arrow on the browser.

This should be fixed now

Thanks for all your feedback! 🙇  It will make our work so much easier! I will try to resolve all comments / bugs asap.
I see that I can't reproduce at least one of these bugs. Could you please post a commit that was tested by you?
Also:

BUG: Web: No animation while opening a report from LHN or navigating back to LHN.

If I understand correctly we are not going to implement animations for this. At least for now.
Similarly for the:

Bug4 (Inconsistency): left swipe to go back works only on iOS. Android and mWeb should support as well?

Hey! This bug should be fixed in the newest commits

Done:
- Bug: Android: Animate type is wrong on native Android for chat opening.

Bug4 (Inconsistency): left edge swipe to go back works only on iOS. Android and mWeb should support as well?

You can set on the system level if you want to have the back button or swipe back gesture. I think this is about it and not about something supported in the app.

https://support.google.com/android/answer/9079644?hl=en#zippy=%2Cgo-back%2Cgo-to-home-screen

@aimane-chnaif are you able to reproduce this one? https://github.com/Expensify/App/pull/16581#issuecomment-1496689709

Bug2: [mChrome or resized web] wrong route on LHN after refresh on Report detail page and navigate back. And this causes "LHN switches to Report detail after refresh" bug. On mSafari, the behavior is different but still bug - loading forever

Can you please confirm that you have reinstalled node_modules? I am not able to reproduce the problem with "LHN switches to Report detail after refresh"

@aimane-chnaif The target branch navigation-refactor has newer navigation versions than the main. It was done in separate PR so it's not visible here. There was a bug related to linking. Please try it with reinstalled node_modules

https://github.com/Expensify/App/pull/15928/files

The bug with the report screen scrolling down should be fixed

The linting errors are related to the part that we are still working on. We still may need these unused values. I wanted to deal with it after fixing bugs.
But you are right, linting error notifications are annoying 😄 I will fix that tomorrow.
I will also sync with my colleague to create a list of bugs with the current status.

Hey! I think most of the bugs mentioned above should be resolved so let me do a quick recap
Done:

Web: Firefox: Using the Back arrow does not update the selected report on Sidebar.
Web: Opening the Chat url directly on a resized window does not load it. Back arrow to LHN does not work as well.
Web: No animation while opening a report from LHN or navigating back to LHN.
Web: Opening the same chat should not refresh the central Pane.
Mobile Web Chrome: Can't run the app on mWeb Chrome.
Android: Animate type is wrong on native Android for chat opening.
Android: Quickly opening the FAB after clicking the report in LHN breaks its state. This is also possible when clicking on the report first and then quickly on FAB
Android: Chat is scrolled to the latest message when the user pops back to it
^This is actually a much more complex issue. It turns out that on Android freezing components calls onLayout where the dimensions of the components are equal to zero. I am assuming that this is what causes the offset to also be 0.
I resolved this bug by creating FlatList component (only for Android) that remembers the offset and uses this value to recreate the scroll position.
However, it would be great to check with someone familiar with the native part of react-native if we can fix this problem at the root.

Can't reproduce
There is a bug that we are not sure how to reproduce. There were some changes that might have fixed that. It would be great if you could try to reproduce it again with the newest changes. Make sure that versions of navigation packages installed are as the one mentioned here https://github.com/Expensify/App/pull/16581#issuecomment-1497515518
To reconsider
There are two things to reconsider if we want to do something about it or "just do nothing". In both cases, I would take care of it later and prioritize other more important bugfixes/changes

Bug (Inconsistency): left swipe to go back works only on iOS. Android and mWeb should support as well?

There was a discussion about this. I thought that "swipe left" for Android is about the setting on the system level. In the current Android version, the user can decide if wants the buttons to tap or gestures to save some space on the bottom of the screen. Not sure about gestures on the mWeb but I am guessing that's also something handled on a different level than the app.

Bug: there should be no loading indicator on Report detail. Show skeleton instead. Please check production website for reference.

This one is related to changes in the structure of the navigation. In the previous version, the sidebar and report screens were packed into one screen in the root navigator. Now that's two different screens in the root navigator.
That causes the sidebar to still be visible when the app is loading the initial report id with the function findLastAccessedReport.
The circle loader with the visible sidebar is analogous to the full-screen circle loader before.
That means the skeleton loader still exists in the cases as before. Nothing should be changed here
We could probably hide the sidebar when the report screen looks for the initial report ID to exactly match the previous look and feel. But it can be a bit ugly in code logic because of navigation tree differences.  The question is if this makes any sense with the new architecture.
I would argue that we could either leave it as it is or take care of that later because this doesn't change functionality at all.

Animation while opening a report from LHN is sometimes not smooth.

It's actually something to do, not to reconsider 😄  At least as much as we can improve it. The web version of the app doesn't need the hack with the first render ref. I mentioned it here https://github.com/Expensify/App/pull/16581#discussion_r1158801520
I am still not used to avoiding the Platform.OS. Maybe you have some idea of how to implement this with file extensions?
Summary
Thank you guys for your help with finding all these problems and for all code related suggestions 🙇  It's very valuable to us!
Also thank you for your patience 🙇  I know this PR can be much more annoying to test and code review than the usual ones.
I hope that we managed to fix the ones listed above. Now we are waiting for the new portion of bugs to solve (I am assuming that there may be more hiding.)
P.S. My colleague is working to adjust the tests to match the new architecture so it should be done soon.

Use the links below to test this build in android and iOS. Happy testing!

@parasharrajat

Do you agree to move the RHN to a new PR? I am happy to get assigned to that PR as well because I am C+ for a lot of navigational issues that are being tracked.

We can do that for sure, whatever works best for the Adam and Mariusz

@mountiny @0xmiroslav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Done but also there might be some updates coming. @adamgrzybowski or @staszekscp can you also add some tests/notes to the PR body to explain what is being done here. Ideally with more context as that will help anyone looking at this PR in future.
I think @staszekscp is working on updating the tests to work without drawer.

We are getting closer @aimane-chnaif @0xmiroslav @parasharrajat Any issues you have found in this PR?
Once we fix the jest job, I think we can merge.

Synced the navigation refactor branch with main so there are some conflicts here now,

Kicked off the internal build https://github.com/Expensify/App/actions/runs/4745281568

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/16581/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/16581/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/16581/NewExpensify.dmg
https://16581.pr-testing.expensify.com

Thanks Rajat, feel free to post more issues if you find them
I think we should merge this though and more on the other PRs, seems like there is mitigating returns from testing more now. @staszekscp @adamgrzybowski could you skip the test which is failing once you get a chance

BUG: Desktop: Backward and forward shortcuts does not always take you to the same chat when RHN is part of history.

Oh, that's a great catch! I haven't seen this one. I think this problem should be fixed with changes that I made to the react-navigation.
Soon I will create a PR for the second part of this work (right modal stack and UP functionality) so we can test it there. It will include react-navigation changes.

I feel like this one might be a polish later https://github.com/Expensify/App/pull/16581#issuecomment-1516486205 its just not stopping the animation I guess.
Should we treat these bugs as something to look at in other PRs to keep make sure we can merge this one?

@parasharrajat we can test that later, I think we wont merge this today as there are some questions address to @staszekscp and @WoLewicki first

Ok I think I will go ahead and merge this so we can address the next issues with smaller PRs.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Looks like you modified DeprecatedCustomActions.js! To be clear, you should not be adding any code to this file.
This file contains deprecated workarounds for limitations of react-navigation and a more long term solution will need to be investigated.
Drop a note in #expensify-open-source to discuss with the team how to proceed.

@parasharrajat yes, thanks!

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.25-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@mountiny @adamgrzybowski Hello! Any QA needed for this PR?

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.25-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Request Options

How do you pass the Request Options, either in the TS file or the Html, is there a method or properties I can assign the Request Options?  I need to pass a token to authenticate for the remote option to work, any help would be greatly appreciated.  Thank you.

RemoteData has a requestOptions method which you can use to set the request options.
private dataRemote: RemoteData;

...
this.dataRemote = completerService.remote(
            "https://raw.githubusercontent.com/oferh/ng2-completer/master/demo/res/data/countries.json?",
            "name",
            "name");
this.dataRemote.requestOptions(options);

Hi, this didn't work for me.
My HTML code is as followed:
<ng2-completer [inputClass]="{'form-control': true, 'has-error': !Name.valid && Name.touched}"
                               [(ngModel)]="searchStr"
                               [datasource]="dataService"
                               formControlName="Name"
                               [minSearchLength]="3"
                               autoMatch="true"
                               clearUnselected="true"></ng2-completer>

my component is as follows:
protected searchStr: string;
headers: any;
protected dataService: RemoteData;

  constructor(private completerService: CompleterService, private url: UrlService) {
    this.headers = new Headers();
    const options = new RequestOptions({ headers: this.headers });
    options.headers.set('Content-Type', 'application/json');
    options.headers.set('Authorization', 'xxx');
    this.dataService = completerService.remote(url.data_url, 'name', 'name');
    this.dataRemote.requestOptions(options);

  }

This one is not sending my auth token. Please any one can help me? Thanks

Can I send HttpPost from RemoteData ?

Can I send post call from remote?


can't find vl_nnbilinearsampler

hi @anilbas,
Thanks for sharing the code!
I followed your readme to run the demo.m, but i can't find vl_nnbilinearsampler function. Could you please release that part of code?
sampler = vl_nnbilinearsampler(Images,grid);
demo (line 131)
Thanks in advance!

Hi @2013211543, vl_nnbilinearsampler is part of MatConvNet: http://www.vlfeat.org/matconvnet/mfiles/vl_nnbilinearsampler/.
So I suspect that you didn't install MatConvNet correctly, maybe didn't run vl_setupnn or something like that.

Thank you, @patrikhuber, I have fixed my problem with your advice.


$stateChangeStart fired twice when interacting with confirm

So I have some events setup around $stateChangeStart and $stateChangeSuccess to determine whether a page is loading or not. On certain sections of my application I have a confirm that appears to allow users to confirm they want to move on. These events work fine if the user hits ok. If they hit cancel another $stateChangeStart event is fired and my loading screen comes up again.
from my controller(s):

$scope.$on('$stateChangeStart', function (event, next, state) {
    if( !_.include(next.name, 'new-report') && !_.include(next.name, 'complete')) {
      if (!confirm("Are you sure? Unsubmitted data will be lost.")) {
        event.preventDefault();
      }
    }
  });

  $scope.$on('$stateChangeSuccess', function (event, next, current) {
    vm.loading = false;
  });

    $scope.$on('$stateChangeStart', function () {
      vm.loading = true;
    });

Please post a Plunkr that demonstrates the issue.

I'm not involved with the company the project was for anymore and no longer have access to the source code. Sorry!


Can't upload via drag and drop and other...

I can't upload new files via drag and drop. Only the upload Button works. But after uploading I get this (see picture). Then I have to restart VPin Studio.
And it is not possible to click on the menues in the right pane (f.e. Playlists) - nothing happens.

A similar issues has been reported on Discord. I'm on it.

Fixed with 3.0.7


RoR group project: set up your Kanban board #17

To see the project link, click here
Members:

@MenendezON
@malikhaiderkhan
@Wils-FOURR-speed

Hi @MenendezON, @malikhaiderkhan and @Wils-FOURR-speed,
Highlights
✔ Assigned tasks
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻

[ ] Kindly add the tasks for these two.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @MenendezON, @malikhaiderkhan and @Wils-FOURR-speed,
APPROVED 🟢
Highlights
✔ Descriptive tasks
Great implementation of all the requirements in this milestone. 👏
You have done an amazing job 👍
Your project is complete!  There is nothing else to say other than... it's time to merge it. :shipit:
Congratulations! 🎉
CHEERS AND HAPPY CODING!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


fix ceil

I found calling math.Ceil on a converted integer is pointless (SA4015), so reviewed this expression and it seems to be wrong.

PTAL @tonybase @kagaya85


Small fixes in ROC AUC docs

The list of use cases did not render on GitHub with the prepended spacing.
Additionally, some typo's we're fixed.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Tensorflow setup

Please go to Stack Overflow for help and support:
https://stackoverflow.com/questions/tagged/tensorflow
If you open a GitHub issue, here is our policy:

It must be a bug, a feature request, or a significant problem with documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
It shouldn't be a TensorBoard issue. Those go here.

Here's why we have that policy: TensorFlow developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

I want to install tensflow and amazon server and os for that is oracle linux 5.11. which setup in can use. Will the ubuntu setup will work same for the oracle linux.

this is not the stackoverflow

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!


Review social card image

[x] Change name from "Ferdi" to "Ferdi Messenger"
[x] "All your services in one place" to "All your messaging services in one place"
[x] Include icons of supported services that are famous enough to catch the eye

@vantezzen Can you share the PSD if you have any?

Got it via https://github.com/getferdi/ferdi/commit/473a84824d86a7e9f1178bbcbc45b230eeae2921, thanks @vantezzen.

@kytwb I would like to work on this, if this is still unassigned

@g-ravity feel free to!

@kytwb @vantezzen I looked at the PSD file, but I can't get the font used in the PSD, since the font layer has been rasterized. I browsed through the project and saw that Open Sans has been used in the project. Can you tell the font used in the social preview PSD or should I use Open Sans instead?

@g-ravity I have checked the PSD file and tried to type "Ferdi" with Open Sans to compare, but it doesn't seem to be that font; I'll let @vantezzen answer on this.

I just checked:
I used the "Circular Std" font in the social preview, you can however use another font if it fits better or if you don't have that font.

I'm not being able to make the design better as per your checklist. Anybody else wanna try, then go ahead

No problems @g-ravity, taking over!

@vantezzen WDYT? Does that work for now?

Twitter Card Validator:

Facebook Sharing Debugger:

LinkedIn Post Inspector:

I pushed the updated PSD, we can iterate if needed. FYI, I've shared the links to the Twitter/Facebook/LinkedIn developer tools for links previews. You can refresh the social networks previews caches after updating the social preview on GitHub by just resubmitting the repository URL for Twitter/LinkedIn, or by pressing the "Scrape Again" button for Facebook.

The font: circular_std_font_family_by_ybtoffical_dd40z3q.zip


tsc 2.9.1 : doesn't understand /** @typedef { import('./types').Foo } Foo */

TypeScript Version:  2.9.1

Search Terms: typedef import, js import
I really wish there was better documentation around this. Took a lot of random googling and reading to even figure out the weird syntax. How is someone even supposed to import multiple types from same .d.ts file?
I was so hopeful that this would work but after a lot of head bashing I still can't get tsc, js files and .d.ts files to play well together 😢 . Its almost 1am, but something so simple shouldn't be complex, should it?
Code
types.d.ts
export interface Foo {
  str: string;
}

main.js
  /** @typedef { import('./types').Foo } Foo */

  /**
   * @param {Foo} foo
   */
  function hello(foo) {}

tsconfig.json
{
  "compilerOptions": {
    "allowJs": true,
    "allowSyntheticDefaultImports": true,
    "alwaysStrict": false,
    "esModuleInterop": true,
    "lib": ["es2017", "dom"],
    "noFallthroughCasesInSwitch": true,
    "noImplicitAny": true,
    "noImplicitReturns": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "pretty": true,
    "sourceMap": true,
    "types" : ["node"],
    "target": "es6"
  }
}

Expected behavior:
It correctly understands type Foo
Actual behavior:
[ts] cannot find name 'Foo'
in the typedef it shows a red squiggly and complains about
[ts] '}' expected.
near import(

Works for me:

Are you sure your VSCode is using the correct version of the TS compiler?

So after waking up I seem to have found some new avenues.

re-installed typescript on my lib so package.json points to "typescript": "^2.9.1",
re-installed typescript globally on my machine, realized nvm installed it to /Users/me/.nvm/versions/node/v8.9.2/lib/node_modules/typescript rather than /usr/local/lib/node_modules/typescript
removed  /usr/local/lib/node_modules entirely, to stop any command resolution confusion
Changed vscode settings to use a custom typescript lib "typescript.tsdk": "/Users/me/.nvm/versions/node/v8.9.2/lib/node_modules/typescript/lib",
Restart vscode (this was important)

That seems to make everything work nicely 😃. Some failures in importing default lib.d.ts  but that's another issue.
Closing this.


fix Rewrite Packed Structs pass for opaque pointers

For opaque pointers, do not look for packed structure in kernel arguments.
Instead look for gep on packed structure or on structure with an implicit cast.
Lowering structure (even unpacked) in implicit cast gep is needed to avoid complicated issue (that I don't have a answer for) in replacepointerbitcastpass.
Lower all those GEPs using 2 new functions to rework GEP indices from a source type to a target type.
Also use those functions in Simplifypointerbitcastpass
SimplifyPointerBitcastPass needs to be updated with a new Map containing ImplicitCasts (between 2 GEPs) that can be lower in this pass. This is needed to avoid regression in the CTS.
Other minor fixes:

ReplacePointerBitcastPass::ComputeLoad: CreateGEP might not create a GEP, use getIndexedType to get the Load Type.
BitcastUtils::getEleTypesBitWidths: fix typo in struct size supported.

Fixes #1005
Fixes #1050
No regression on full cts with Swiftshader and Nvidia

RewritePackedStruct pass would be more StructLoweringPass with this PR.
I could rename everything, but I am not sure about it.