Remove @typescript-eslint/strict-boolean-expressions

This setting is rather aggressive, preventing simple checks such as if (!process.env.FOO_VARIABLE). It is not included in @typescript-eslint/recommended.
In the studio repo, we have helpers to make checking for empty or undefined values easier. However, other repos don't have these available.
I therefore propose we remove it from our default shared config, and enable it on the studio repo only.

@amacneil Do we have lint rules to catch these issues?
const foo = 0;

// non-obvious boolean use of foo - did the writer realize foo is a number and that 0 = false? I don't think numbers should be treated like booleans - it may feel quick to do so but is not clear
if (foo) ...

const foo: string | undefined = "";

// non-obvious boolean use of foo - did the writer realize empty string is false rather than desiring having the empty string value?
if (foo) ...

For the integer case: I haven't found a strong need for or against it. I don't think it's "non-obvious" that 0 is falsey, that is fairly standard behavior in every programming language I've used. But I'm happy to reintroduce that if desired.
For the string case: I have only ever wanted to treat empty string and null/undefined as false. It comes up constantly for me in the website repo, and I find explicitly checking both empty string and undefined overly verbose and error prone (for example in process.env.FOO). In fact, we just had a bug that I fixed where this lint rule caused someone to change a perfectly valid if (!foo) string comparison into if (foo == undefined) and broke the code in question. It seems like for the rare case where you want to explicitly check for only undefined, you should do that, but in all other cases allow treating empty string as falsey.

I don't think it's "non-obvious" that 0 is falsey…

Discussed this a bit more on #14, but my concern with this is that when reading if (x) you can't always tell whether x is a number or number | undefined or SomethingElse | undefined. When that information's not obvious, the check looks like it means "x is present" but if x happens to be a number then it actually means "x is present and non-zero".


Support updating (while retaining ids) on cast_polymorphic_embed for polymorphic_embeds_many.

Thank you for the work, few questions:
@naserca Why did you remove support for MFA :with? If I'm not wrong this is supported by the Ecto embeds_ functions so therefore polymorphic embed supports this as well.
@Miradorn Why did you remove the dependencies on phoenix html/phoenix ecto/phoenix live view in the mix file?
Anyway the changes have been added in the lib. Thank you

@naserca Okay found the deprecation notice of using MFA in Ecto

Hi @mathieuprog , thanks for following up and taking some time to work on this!
IIRC I removed the phoenix_html related code due to a problem when we updated phoenix_html (or some of the other phoenix libraries). The new version had breaking api changes which broke compilation of the related modules here.
Since we weren't using the html part of this library anyway internally I decided it was easier (for us :D) to remove the dependency completely instead of trying to make it work either with both versions or break support of the old one.
I think it might be worthwhile to extract the phoenix_html specific code into its own package (polymophic_embed_html_helpers? :D) to avoid this happening again in the future, ignoring the overhead of that approach 🤐 , since it might be a common use-case to use the "core" functionality without the html helpers.
In the end it's obviously your call! Thanks again for the great library and the work ❤

Thank you for the clarifications. Taking note of the suggestion to isolate the helpers, feel free to contribute it or I'll address this later.
In the meanwhile all of the changes from your branch have been added.
I also noticed your comment here https://github.com/mathieuprog/polymorphic_embed/issues/74#issuecomment-1439622961 but we would need a failing test. Again welcome to add it, or I'll address this later as well. If the comment is related to this issue, this would allow us to understand the limitation we have with custom Ecto Type and either see if anything can be done on Ecto's side, or at the minimum document this limitation.

I would love to spent some time, but I'm going on parental leave next week for 4 months, so I'm currently pretty swamped finishing up work and preparing handover. Once I'm getting back and something needs work/help I'll be glad to jump onto it!

Congrats to you then:) Enjoy your parental leave


Call to server.getIntegrations fails with 400 Error

This statement is spitting out errors to the console not sure why
server.getIntegrations { integrations, error in
                if let firstIntegration = integrations?.first {
                    print(firstIntegration.buildResultSummary!.testsCount)
                } else {
                    print("Error: \(error?.description)")
                }
            }

I get this in the console:
Error: Optional("Error Domain=com.honzadvorsky.Buildasaur Code=0 \"Wrong body Optional({\n    message = \"unable to parse the query string\";\n    status = 400;\n})\" UserInfo={NSLocalizedDescription=Wrong body Optional({\n    message = \"unable to parse the query string\";\n    status = 400;\n})}")

Oh hey @kdawgwilk, sorry for completely not responding here. This looks like we're sending a wrong URL parameter to XCS. Are you still seeing this?

I wonder if that has anything to do with https://github.com/fastlane/fastlane/pull/1067/files

Hey @kdawgwilk, are you still seeing the issue?

Closing as there hasn't been any activity for a long time. Please reopen if you see this issue again. 👍


Fix installing dependencies in Docker

Another follow-up with Docker changes - changed pipenv installation to use pip and added missing Pipfile.
Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] GraphQL schema and type definitions are up to date.

Let's see what happens 😄


error when entering the correct password in the addon

Netflix add-on version
1.23.0
Operative systems used
Android
Kodi version used
Kodi 20 (Nexus)
Description of the bug
I try to log in to the addon and my password is correct, but when I try to log in it says that the password is incorrect, I can't use authenticationkey because I don't have a computer
Steps to reproduce the behavior

open the addon
enter the password
the error appears

Debug log - mandatory
https://paste.kodi.tv/zasosiwori.kodi
Possible fix
No response
Additional context
No response
Screenshots

explained on wiki
https://github.com/CastagnaIT/plugin.video.netflix/wiki/How-install-the-addon#the-login-could-cause-incorrect-password-error

Could you tell me how to do this without a PC?


Refactor service tests in sc-network

Create a separate directory for the tests and move common network instantion related code to mod.rs from where it can be used by both service and chainsync tests.
Use the builder pattern when creating the TestNetwork object to reduce code duplication between the test files.
These changes are introduced in a separate PR in order to prevent cluttering future PRs with too many testing-related changes.

ping @bkchr

ping @bkchr

Sorry for the delay!

bot rebase

bot merge


GUI Features and Requirements

This is a holder for all the requirements and features for msc-GUI. Later we will create tasks and maybe even use the milestone feature in GitHub to track this.
I'll start this list and then we can start categorizing them by importance. As we figure out what is more important we can limit this list to only what is absolutely needed for a 1.0 and assign features for later versions.

Communicate with mscs over REST using token auth
World list
Control servers

start/stop/restart
enable/disable
create/destroy

Login or other authentication

users and groups with access control

Backups

list/create/delete
Not sure if delete works since backups are incremental
Create tar.gz from any backup?

Server stats

CPU, memory, MC version, plugins, players online, whitelist, blacklist, ops

Settings view/set/update

global and per-world

I've been doing some research on RESTful APIs, and I am beginning to come up to speed.  If we want to stick with Perl, Mojolicious would probably be a whole lot better than trying to write something DIY like this.  Mojolicious has theming support, has its own webserver so we don't necessarily need Apache, and it looks like it supports authentication as well.
If you guys would rather work with some other language like PHP or Python, that is fine with me.

The backend language doesn't matter all that much, the HTML/JS/CSS can and should be pretty separate from that. I also think setting up our own web service without having to rely on Apache or Nginx could be a good thing (less dependencies) and maybe some might not want a web server running on their Minecraft server.
All that said, I think mscs would be nice if it had a REST service within itself. Then we could do neat things like remote server control. That or we need the REST service as an additional layer so we have [mscs <-> msc-REST <-> msc-GUI], or for remote management [mscs <-> msc-REST <-> msc-REST <-> mscs]. Then again, maybe I'm getting ahead of myself.

Maybe this is more of a pain than it is worth, but I would like it better if our user facing solution would still function without JS.  I use NoScript  for safer web browsing, and nothing annoys me more than a web site that just feeds me a nonfunctional white screen or a garbled mess until I add the site to my whitelist.
To this end, it seems like we need to have all formatting logic server side.  JS would only be used to make the page interactive without a page reload.  A good example of what I am talking about would be the world menu.  I could see JS grabbing the list of worlds and updating the menu, but I would prefer that the html presented by the server already have all of the world's listed.  This means we need a theming engine.
My question is: do we need two different webservers running (rest and gui), or would it be better if they were controlled by the same program?  I think I see what you are talking about RE the remote management solution, but what does that provide that ssh or the gui wouldn't provide?

Let's see if we can come up with a list of nouns and verbs that we would need.  Here is a RFC start:

http://server.com/msc/worlds

GET: return a JSON array of worlds.

http://server.com/msc/worlds/alpha

GET: return JSON hash containing the statistics for world alpha
POST: create world alpha (also need port and ip variables somehow)
DELETE: delete world alpha

http://server.com/msc/maps

GET: return a JSON array of worlds that have been mapped

http://server.com/msc/maps/alpha

GET: the Overviewer generated content for world alpha
POST: run Overviewer on world alpha
DELETE: delete the Overviewer generated content for world alpha

Maybe this is more of a pain than it is worth, but I would like it better if our user facing solution would still function without JS. I use NoScript for safer web browsing, and nothing annoys me more than a web site that just feeds me a nonfunctional white screen or a garbled mess until I add the site to my whitelist.

I don't mind JS myself but I do understand the desire to run NoScript. AJAX is nice for updating parts of content without reloads but we can make the site function without it.

To this end, it seems like we need to have all formatting logic server side. JS would only be used to make the page interactive without a page reload. A good example of what I am talking about would be the world menu. I could see JS grabbing the list of worlds and updating the menu, but I would prefer that the html presented by the server already have all of the worlds listed. This means we need a theming engine.

Exactly, first render has all the content already, JS just makes it interactive.

My question is: do we need two different webservers running (rest and gui), or would it be better if they were controlled by the same program? I think I see what you are talking about RE the remote management solution, but what does that provide that ssh or the gui wouldn't provide?

I don't think so. REST and the GUI could run on the same webserver. Having REST separate would just provide a different method for controlling mscs and we could have multi-mscs server control in the GUI and allow not having the GUI portion on the servers that don't need it.

Edit: another thing to note is that not everyone will want to use the gui, so adding more bloat to mscs might be seen as a bad thing to some, meaning that [mscs <--> rest <--> gui] makes more sense to me than adding rest to mscs.

Agreed, that is why I suggested msc-REST be separate. Keeps mscs more simple.

Anyone making any progress on this?

I haven't been able to touch it since I started a new job recently. Once I get into the grove there hopefully I can start contributing.

Hi guys :)
Likewise, I've been very busy recently finishing up school. I will definitely start contributing soon as the summer arrives

Although it's been more than a year since we've started discussing this, I definitely still want to do this. One of the things I've been looking into is flask, a popular, full-stack python web microframework that is well-documented and includes support for authentication and restful API's. It also seems to be more beginner friendly (for someone like me). If it's good with you guys, I'll start developing this using that framework.
Did we ever figure out if we wanted to include a database in MSCS for the rest API to communicate with? Or what's the alternative? (I suppose we could include a database inside of MSC-gui and have it query MSCS for updates, but that seems very complicated)

This project has been in the back of my head as well, I just wish I had time to devote to it. I'm not sure this would require a DB, except for maybe user profiles access control.

I played around with a new script today that uses a RESTful API and the Perl module Mojolicious. It is more performant than my CGI::Ajax-based script but is mostly functionally equivalent.
use strict;
use warnings;
use utf8;
use feature ':5.10';

use Mojolicious::Lite;

get '/' => sub {
  my $self = shift;
  $self->stash (enabled_worlds => &getEnabledWorlds);
  $self->stash (disabled_worlds => &getDisabledWorlds);
  $self->render (template => 'dashboard');
};

get '/worlds' => sub {
  my $self = shift;
  $self->stash (enabled_worlds => &getEnabledWorlds);
  $self->stash (disabled_worlds => &getDisabledWorlds);
  $self->render (template => 'worlds');
};

get '/worlds/:world' => sub {
  my $self = shift;
  my $world = $self->stash ('world');
  my $enabled = &getEnabledWorlds;
  my $disabled = &getDisabledWorlds;
  $self->stash (title => "MSC-GUI: $world");
  $self->stash (enabled_worlds => $enabled);
  $self->stash (disabled_worlds => $disabled);
  if ($world ~~ @{$enabled}) {
    my $backups = mscs ("list-backups", $world);
    my @query = split /\t/, mscs ("query", $world);
    $self->stash (backup_list      => $backups);
    $self->stash (query_motd       => $query[6]);
    $self->stash (query_gametype   => $query[8]);
    $self->stash (query_gameid     => $query[10]);
    $self->stash (query_version    => $query[12]);
    $self->stash (query_plugins    => $query[14]);
    $self->stash (query_map        => $query[16]);
    $self->stash (query_numplayers => $query[18]);
    $self->stash (query_maxplayers => $query[20]);
    $self->stash (query_hostport   => $query[22]);
    $self->stash (query_hostip     => $query[24]);
    $self->stash (query_players    => $query[29]);
    $self->render (template => 'enabled-world');
  }
  else {
    $self->render (template => 'disabled-world');
  }
};

app->start ('daemon', '-l', 'http://*:3000?reuse=1');

sub getEnabledWorlds {
  my $self = shift;
  my @worlds;
  foreach my $line (mscs ("ls enabled")) {
    if ($line =~ /^\s*(\w+):/) {
      push @worlds, $1;
    }
  }
  return \@worlds;
}

sub getDisabledWorlds {
  my $self = shift;
  my @worlds;
  foreach my $line (mscs ("ls disabled")) {
    if ($line =~ /^\s*(\w+):/) {
      push @worlds, $1;
    }
  }
  return \@worlds;
}

sub mscs {
  return `mscs @_`;
}

__DATA__

@@ dashboard.html.ep
% layout 'default';

Dashboard

Enabled Worlds:

% foreach my $world (@{stash('enabled_worlds')}) {

<a href="/worlds/<%= $world %>"><%= $world %>

% }

Disabled Worlds:

% foreach my $world (@{stash('disabled_worlds')}) {

<a href="/worlds/<%= $world %>"><%= $world %>

% }

@@ worlds.html.ep
% layout 'default';

Enabled Worlds:

% foreach my $world (@{stash('enabled_worlds')}) {

<%= $world %>

% }

Disabled Worlds:

% foreach my $world (@{stash('disabled_worlds')}) {

<%= $world %>

% }

@@ enabled-world.html.ep
% layout 'default';

<%= $world %>

List of backups:

<%= $backup_list %>

Query:

MOTD: <%= $query_motd %>
Game type: <%= $query_gametype %>
Game ID: <%= $query_gameid %>
Server Version: <%= $query_version %>
Server Plugins: <%= $query_plugins %>
Server Map: <%= $query_map %>
Number of players online: <%= $query_numplayers %>
Maximum players: <%= $query_maxplayers %>
Host port: <%= $query_hostport %>
Host IP: <%= $query_hostip %>
Player list: <%= $query_players %>

<a href="http://localhost/maps/<%= $world %>/index.html"><img id="map" src="http://localhost/maps/<%= $world %>/normalrender/base.png" alt="Map of <%= $world %>"/>

@@ disabled-world.html.ep
% layout 'default';

Disabled world: <%= $world %>

@@ layouts/default.html.ep
<!DOCTYPE html>

<title><%= title %></title>
<link rel='icon' type='image/x-icon' href='/favicon.ico'/>
<link rel='stylesheet' type='text/css' href='/stylesheet.css'/>

Minecraft Server Control

Dashboard
% foreach my $world (@{stash('enabled_worlds')}) {
<a id='msc_menu_<%= $world %>' class='menu_item_active' href='/worlds/<%= $world %>'><%= $world %>
% }
% foreach my $world (@{stash('disabled_worlds')}) {
<a id='msc_menu_<%= $world %>' class='menu_item_inactive' href='/worlds/<%= $world %>'><%= $world %>
% }

<%= content %>

I posted a new version of the above script as Pull Request #7.


Backup ~/.ssh dir in hosted 3bot

Backup ~/.ssh dir in hosted 3bot

done on branch
development_3botdeployer_status

branch: development_3botdeployer
commit: 76e220ed6d43b496e7614fd7f98778ab631a65d4


support ensembles of class1 allele specific predictors

In our tests ensembles of as many as 64 predictors (perhaps more, haven't tried) show improved accuracy

Realized we can kill two birds with one stone here to get ensembles and an estimate of generalization error with sacrificing training data. In the production training run we should train predictors on random subsets of the data (either with or without replacement, perhaps need to experiment to see which works best) and then estimate generalization error by testing on the out-of-bag samples

I guess to keep information leaking from the model selection to the estimate of generalization error we'll actually have to do something like this:
For N predictors:

pick a random subsample of training data (say 50% of the data? maybe more?)
do cross validation model selection within this subset to pick a model
save the best model

Our production predictor would then take the average over the N predictors selected above.
To estimate generalization error: for each data point in the training data, take the average of the K < N predictors on it that did not have it in their subsample (i.e. were not trained on it), and calculate the accuracies of those predictions.
On one hand this is nice since we'll be averaging over multiple model architectures. On the other hand, this will be quite expensive. Will definitely need the cloud setup working well.

Simpler/cheaper alternative #1:
For each model architecture, perform k-fold cross validation to estimate that model architecture's performance. A final ensemble is just the k models trained for CV.
Maybe this is the same as your original idea? We'll get inflated estimates of accuracy (since we're choosing the max over all model architectures) but will have to train way fewer models.
Another downside is that our ensemble size and number of cross-validation iters become tied.

For reference, here's the cross-validation + ensemble strategy described in the NetMHCpan 3.0 paper:

Networks were trained in five-fold cross-validation using gradient descent back-propagation with early stopping. Ensembles were generated by training five networks for each data partition and network architecture each starting from a distinct random initial configuration, leading to an ensemble of 10 networks for each data partition, and a total of 50 networks across all partitions. The ensemble trained on all alleles and all peptide lengths will be referred to as the “allmer” method.

Closed by #86


How to generate a file that can be recompiled?

How to generate a file that can be recompiled?

Hi. As written in #45, producing recompilable C source code is not our main goal, so there is no special parameter that would magically make the output C code recompilable. Nevertheless, in some cases, the C source code that RetDec produces is recompilable, which we sometimes utilize in our tests (e.g. this one, which checks that a program doing FPU computations is correctly decompiled, then recompiled, and produces correct output when run).
For more details, please see the discussion in #45.


Cannot use more than one query in on_connect.sql with MySQL

Introduction
Using on_connect.sql as described in the documentation does not seem to work if more that one query is used.
To Reproduce
:heavy_check_mark: Working
select 1;

:x: Not working
select 1;
select 2;

Actual behavior
App logs:
[INFO  sqlpage::webserver::database::connect] Connecting to database: mysql://user:password@myhost/mydb
[INFO  sqlpage::webserver::database::connect] Creating a custom SQL database connection handler from "/var/www/sqlpage/on_connect.sql"
[ERROR sqlx_core_oldapi::pool::inner] error returned from after_connect: Database(MySqlDatabaseError { code: Some("42000"), number: 1064, message: "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'select 2' at line 33" })

Expected behavior
One should be able to use any number of properly terminated queries in the on_connect.sql bootstrap file.
Version information

Database: MySQL 8
SQLPage Version: 0.15.2

Indeed, the on_connect file contents are passed as is to the database, without SQLPage parsing and splitting it.
This allows you to use the raw database syntax, but limits you to what your database accepts, and MySQL accepts a single statement by query by default.
You can work around that by using a user-defined function.

Unfortunately that's a no-go for what I intended to do where I cannot write a single persistent piece of data on the remote server.
I was trying to build a dev tool to inspect rapidly a running production database where I can only create temporary tables and execute SELECT statements.
Here I was using on_connect.sql to "persist" common data into a temporary table that I could then reuse on every page.
I managed to partially work around this by turning my CREATE TEMP TABLE + INSERT INTO to a single CREATE TABLE ... SELECT ... but it stills means I can only use it once, and for a single record.

Oh, I get it, the limitation is indeed annoying. I'll look into whether there is a way to bypass MySql single statement limitation.
Why would CREATE ... SELECT be limited to a single record?
Out of curiosity, what is it you are building with SQLPage ?

Why would CREATE ... SELECT be limited to a single record?

Well, that's not entirely true, but having to chain UNION does not really help readability when those data are hardcoded and not the results of a SELECT against the database.

Out of curiosity, what is it you are building with SQLPage ?

As written above, a dev tool to inspect rapidly a running production database. I hope it could help me gather interesting data quickly, and be able to look at them whenever I need through a cute webGUI.
Currently I use dBeaver with a pile of SQL queries I often reuse but it lacks the user-friendliness of a dedicated tool.

MySQL's documentation gives the following example:
CREATE TABLE tvx
    SELECT (x,z) FROM (VALUES ROW(1,3,5), ROW(2,4,6)) AS v(x,y,z);

https://dev.mysql.com/doc/refman/8.0/en/create-table-select.html

Right! I didn't know this syntax. Thanks for the tip.
Anyway, eventually I'll probably need several tables to meet my needs, so this does not completely solve the problem.

By querying the database differently, we should be able to support multiple statements in on_connect even in MySQL :tada:
I pushed a fixed, it should be automatically published as sqlpage:main on docker hub soon. Can you give it a try, @nanawel ?


Translations for Fly-Pie 5

Dear translators! Fly-Pie 5 is soon to be released and it would be great if you could update the translations!
I originally planned to include the achievements in this release, but there are so many changes already since the last version, that we shouldn't wait any longer. All the achievement & statistics related code is still in there but disabled for now. So please be not confused as there may be some string which you won't find in the user interface!
You can read the preliminary change log here: https://github.com/Schneegans/Fly-Pie/blob/release/v5/docs/changelog.md

[ ] German: @daPhipz
[ ] Italian: @albanobattistella

You can follow the translation guide and should base your work on the release/v5 branch.
Thank you so much!

Thanks for the notification!
I'm done with German, but before filing a PR, I would like to clarify some questions that came to my mind during the translation. I put them as comments in the code block below.
Here you go:
# Do you mean "Bronze"?
#: assets/settings.ui:273
msgid "🥉 Copper Sponsors"
msgstr "🥉 Kupfer-Unterstützer"

# Are there other support plans (higher amounts)?

# I assume you mean the Presets, that's why I'll go with "sie".
# Might be worth clarifying, though ;)
#: src/prefs/SettingsPage.js:327
msgid ""
"Here it will be deleted whenever Fly-Pie is updated. It has been saved "
"anyways, but please consider to store it in a safer place!"
msgstr ""
"Bei einem Update von Fly-Pie wird sie hier gelöscht. Sie wurde zwar "
"gespeichert, aber bitte ziehen Sie einen sicheren Ort in Betracht!"

I decided to post this here instead of including it in the file, in order to keep it clean.
What is your take on this? Thanks! :+1:

Thank you for this extremely quick response! If you have the time, you can also play around with the current state and check for any bugs!

Do you mean "Bronze"?

Yap :smiley:

Are there other support plans (higher amounts)?

Yes, there are 1$, 5$, and 10$ available. I reformulated that string to suggest that there are more options.

Should we convert the currency?

I don't think so. GitHub just supports sponsoring in dollars, and the conversion changes daily...

What is "it"?

You got it right, I added a comment accordingly!
Thank you very much!

@albanobattistella : Do you have all the required information to start working on this? I could also provide a step-by-step guide to make things easier if there are any difficulties!

Hi Simon,
thanks,I'm working on...
Regards,
Albano

Da: Simon Schneegans @.>
Inviato: giovedì 1 aprile 2021 08:12
A: Schneegans/Fly-Pie @.>
Cc: albanobattistella @.>; Mention @.>
Oggetto: Re: [Schneegans/Fly-Pie] Translations for Fly-Pie 5 (#96)
@albanobattistellahttps://github.com/albanobattistella : Do you have all the required information to start working on this? I could also provide a step-by-step guide to make things easier if there are any difficulties!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Schneegans/Fly-Pie/issues/96#issuecomment-811670885, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIJS6FGWPBNL5C3LC2S22FLTGQFETANCNFSM4Z4AOQOA.


Usages Detail is not clear

I run this code. I can not login to the app. How to get the name and passcode and in the sample. which credentials I have to change to use this sample in my app. Please help me on this

Hi @abhi8702 ,
Thanks for reaching out! The name can be whatever you want it to be as it is just an identifier used when joining a video room. The passcode comes from the Twilio CLI, which is generated after following these steps. Were you able to successfully follow these steps to generate a passcode to use in the app?

Closing for now @abhi8702. Please free to reach out again if you are having any more issues with the Twilio CLI setup.

I am trying out with the sample. As soon as I ran the the quickstart sample app, it goes into the camera view, with "Connect to a Room" button and other control buttons. There is no log in or place to input passcode. Where should I put the passcode and webapp link in the android app? In local.properties?

Hi @cjf12harry. For instructions on how to get up and running with this app, please refer to the Getting Started Section in the readme. It has instructions on how to generate a passcode that can be used in this app.
If you run the community product flavor, you should see the login screen asking for your name and passcode.


Is it possible to extract the audio from a video directly to stdout

I am looking for something that downloads the video to memory (or a temporary place) and streams the extracted audio directly to standard output as it is converted.
So something like:
youtube-dl -x -o - http://url

however it gives me error:
youtube-dl: error: Cannot download a video and extract audio into the same file! Use "-.%(ext)s" instead of "-" as the output template

If there are any workarounds to this, I'd appreciate. My use case is, I'm trying to extract audio of a video to stdout in a single command (say, docker container entrypoint) .

Not possible. Duplicate of #8269.

One day perhaps ..


Multiplayer:

Decide on protocol, maybe write project with connection abstractions.
Adapt readme to mention that only Win11 is supported (because of Quic)
Classes for ClientPlayer and LocalPlayer. But without the prefixes.
Player names using billboards.

Wrongfully created


[slack] Web middlewares to /api/messages get ignored

Custom webserver middlewares for the /api/messages endpoint get ignored
Are you sure this is an issue with the Botkit core module?
Yes. As stated in the documentation, the webserver is based off an expressjs app, meaning middlewares can be added to it through .use(...) (get, post, delete or update as well)
What are you trying to achieve or the steps to reproduce?

Create a middleware for the /api/messages endpoint

controller.webserver.use('/api/messages', (req, res, next) => {
   // My custom middleware code
   next();
})

Trigger a post call to the endpoint (using slack or postman)
The bot receives the event on the endpoint, but the custom middleware never gets called

What was the result you received?
The middleware created for the endpoint never gets called.
This is most likely to happen since the botkit adapter contains an internal middleware that never calls next() to pass control over to other custom created middlewares.
What did you expect?
That the custom middleware created for /api/messages gets called
Possible solution
Include a next() call in the definition of Botkit's /api/messages endpoint middleware. This would allow other custom middlewares to be called while remaining consistent with expressjs middleware functionality.
Context:

Botkit version: 4.8.1
Messaging Platform: Slack
Node version: v14.0.0
Os: macOS Mojave 10.14.6

There is a configuration option for the Botkit constructor that allows you to bind additional middlewares to the webserver.
const controller = new Botkit({webserver_middlewares: [(req, res, next) => {}], ...});

Thanks @benbrown I just gave it a try and this works, but not quite as expected.
The way you are recommending this seems to be for a more global approach (all endpoints on the web server) compared to a more specific option (a middleware for a specific endpoint /api/messages in this case).
Is there a recommended way of adding an endpoint specific middleware? The class reference doesn't mention much about the webserver_middlewares property being capable of that, and the Middleware documentation using expressjs specific methods do not work for /api/messages as described on this issue.
Thats why I created #2008 to allow the api/messages middleware set by the core, to allow passing control to other endpoint-specific middlewares. Could you please consider re-opening and reviewing this again?
Thanks!


inlay hints are a visual distractor

i use catppuccin mocha theme in zed and when i tried to enabled inlay hinds i noticed that they are just a regular white color indistinguishable from variables, which makes it hard to read the code because i can't what what is type annotated manually and what is not
code without inlay hints

code with inlay hinds

in the intelliji they look like a badge or a faded comment, i prefer the grayish comment style inlay hints.

oh interesting, thanks for submitting this issue. I see it on my end as well: I normally don't enable this feature.
will investigate how I could fix this. the built in Zed Syntax debug tree doesn't give a hint as to what colors this 😅

One Dark and Dracula theme seem to have this colored correctly. this should be an easy fix

sick! thank you @tecandrew !!!


close #677 - remove SSR redirection from the landing page

AWS won. I won't bother investigating how to setup containerized sequelize considering that we're moving to prisma soon. I also found a workaround for flickering problem, I simple won't render landing page component until I'm sure that it's unauthorized user. This way I also can keep index page static and benefit from static site optimization.
This PR:

removes server side redirect
adds back isLoggedIn localStorage value
changes C0D3 logo from NavLink to simple div to prevent page reloads when authorized user clicks it. This change caused all these snapshot updates.

Go to vercel. Throttle your connection and refresh index page, you will get navigation bar and white background then landing component loads. Login and try to open index page again. You will see navigation bar and white background then it's curriculum page. Click on C0D3 button, nothing happens (no rerenders, as it should be).

changes C0D3 logo from NavLink to simple div to prevent page reloads when authorized user clicks it. This change caused all these snapshot updates.

I don't understand this, what is reloading exactly? Only thing that I noticed when looking at the network requests is that the discord widget updates.
This change also prevents returning to the main page when you are inside a lesson for example, because the link does nothing. Another thing is acessibility is worse by having a div with onClick instead of anchor tag.

I don't understand this, what is reloading exactly?

You're right I was confused by difference between dev and prod build again. In dev clicking on c0d3 results in reloading lessons which is fairly noticeable while in prod build it works fine (only discord users reshuffle). I reverted it back to NavLink.


search for assets in xdg data directories on non-windows platforms

ref: https://github.com/v2rayA/v2rayA/pull/393
search paths before the change:

/usr/local/share/v2ray
/usr/share/v2ray
/opt/share/v2ray
$V2RAY_LOCATION_ASSET or executable dir

search paths after the change:

$XDG_DATA_HOME/v2ray or ~/.local/share/v2ray
for dir in $XDG_DATA_DIRS; $dir/v2ray or /usr/local/share/v2ray and /usr/share/v2ray
$V2RAY_LOCATION_ASSET or executable dir

the only breaking change is that /opt/share/v2ray is no longer searched

Codecov Report

Merging #1578 (17e0772) into master (1df4322) will decrease coverage by 0.23%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1578      +/-   ##
==========================================
- Coverage   39.29%   39.05%   -0.24%
==========================================
  Files         602      597       -5
  Lines       35480    35491      +11
==========================================
- Hits        13941    13862      -79
- Misses      20003    20076      +73
- Partials     1536     1553      +17

Impacted Files
Coverage Δ

common/platform/others.go
90.90% <80.00%> (+18.18%)
:arrow_up:

app/proxyman/outbound/errors.generated.go
0.00% <0.00%> (-100.00%)
:arrow_down:

transport/internet/http/errors.generated.go
0.00% <0.00%> (-100.00%)
:arrow_down:

common/task/task.go
88.88% <0.00%> (-7.41%)
:arrow_down:

testing/servers/tcp/tcp.go
81.81% <0.00%> (-5.46%)
:arrow_down:

testing/scenarios/common.go
73.07% <0.00%> (-4.62%)
:arrow_down:

app/proxyman/outbound/handler.go
36.61% <0.00%> (-4.23%)
:arrow_down:

transport/internet/udp/hub.go
73.61% <0.00%> (-4.17%)
:arrow_down:

transport/internet/kcp/dialer.go
80.39% <0.00%> (-3.93%)
:arrow_down:

transport/internet/system_listener.go
48.07% <0.00%> (-3.85%)
:arrow_down:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df4322...17e0772. Read the comment docs.

ref https://github.com/v2fly/v2ray-core/pull/715


[Mention The Feature]:  Header details misbaheving

Is your feature request related to a problem? Please describe.
H2 size code is visible it is not added perfectly or due to code incompleteness
Describe the solution you'd like.
Code need to correct
Describe alternatives you've considered.
No response
Additional context.
No response
Show us the magic with screenshots

Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

Can you please assign me this issue?

can you assign me this issue please


[Bug]:   The "--stats-overview" option does not exist.

What happened?
Command provided on ReadMe file does not work.
How to reproduce the bug
Install the repo as per readme.
Copy very next command from Readme:
php artisan make:filament-advanced-widget AdvancedStatsOverviewWidget --stats-overview
Observe the error in console.
Package Version
"eightynine/filament-advanced-widgets": "^3.0",
PHP Version
8.2
Laravel Version
11
Which operating systems does with happen with?
macOS
Notes

hey @nezaboravi
the option is --advanced-stats-overview
the command should be
php artisan make:filament-advanced-widget AdvancedStatsOverviewWidget --advanced-stats-overview

Thanks for pointing this out, @nezaboravi @alphaolomi . I have updated the documentation!


Introduce new diff flag --ignore-status-field

Introduce new diff flag --ignore-status-field which can be used to ignore the top-level .status field when comparing diffs.
In some cases when performing a diff on resources the only shown change is the .status field. Seeing as this field is only updated on the live object, it doesn't make much sense to show a diff of it.

would --diff-strategy last-applied work for you?

Yes, --diff-strategy last-applied works. We were previously using subset.


Multiline descriptions not recognised

I've tried adding multiline comments in the following formats:
class PersonType < BaseObject
  description "A Person has four limbs.
  People can ride buses and bikes."

and
class PersonType < BaseObject
  description "A Person has four limbs."\
  "People can ride buses and bikes."

Both are not picked up by the cop as compliant. I've seen it on Objects and Arguments thus far. Can this be supported with some documentation on which way might be preferable? Thanks! CC @bessey

Hi @PussInDasBoot! Looks like a bug in the cop

Fixed in #31 and 0.6.2


Clean up more [b]Example:[/b] lines from the class reference

Continuation of https://github.com/godotengine/godot/pull/95749, see prior PR for similar reasoning.
This PR continues the effort to standardise the [b]Example:[/b] somewhat, instead of bolding the entire line describing the example below.
It also replaces some lines similar to For example: with [b]Example:[/b]. This is not exhaustive at all, as oftentimes doing this change makes readability worse, but whenever possible... sure, why not?
The descriptions affected by this have received tweaks to justify a localization update. Notably:

Control._gui_input() has been changed drastically
SyntaxHighlighter.get_line_syntax_highlighting() has been changed drastically
A note in HTTPRequest was made into an actual note
A note in PopupMenu was shifted to the bottom
A note in Window was shifted to the bottom

Thanks!


Tolerations, nodeSelectors and affinity not being properly set

As I commented on #244, the tolerations, nodeSelectors and affinity are now being properly set in the workflow with the current code:
    workflow = Workflow(
        name="my-wf",
        tolerations=generate_workflow_tolerations(),
        node_selectors=generate_workflow_node_selectors(),
        affinity=generate_workflow_affinity(),
    )

results in:
spec:
  templates:
  - templates:
    ...
    nodeSelector:
      some_key: value
    tolerations:
    - effect: NoSchedule
      key: some_key
      operator: Exists
    affinity:
      ...

These entries in the yaml will be ignored by Argo/k8s and won't have any effect on the workflow, since they are children of templates.
The solution is to have the entries defined as siblings of templates:
spec:
  nodeSelector:
    some_key: value
  tolerations:
  - effect: NoSchedule
    key: some_key
    operator: Exists
  affinity:
    ...
  templates:
  - templates:
    ...

This matches the API seen in IoArgoprojWorkflowV1alpha1WorkflowSpec.

Apologies for not spotting this sooner :/

@flaviuvadan good point, I'll fix those two as well.
Re: being redundant adding it to the inner templates, I agree with you that it looks/feels redundant, but I'm not 100% certain that removing it won't break something else given that Argo's own API models accept these attributes, which, to me, means they are being used somewhere (their docs mention that it's possible for some of the attributes set in the workflow to be overridden).
Furthermore, there's a non 0% chance that someone out there is relying on these being set.
With that in mind, I decided to keep them to be on the safe side. Happy to defer to your judgement and decision though!

Furthermore, there's a non 0% chance that someone out there is relying on these being set

This is a great point, actually, so let's merge it this way :)

(for the lack of a better discussion forum)
@flaviuvadan is there anything else you need help with on hera? Perhaps a roadmap you're trying to fulfil? Would like to continue contributing.


Added Python 3.6

Dropped Python 2.6, as I discovered that flake8 wasn't passing in travis for it. This is not unsurprising, given that Travis was using flake8 3.4.1, and flake8 dropped support for Python 2.6 in 3.0.0.

Thanks!


Add optional USPS special services

I'm not seeing a way to include USPS special services. More specifically I need to add Registered Mail Restricted Delivery. Any plans to make this available?
https://www.usps.com/business/web-tools-apis/rate-calculator-api.pdf - page 8
Special Service Name  |  ServiceID
Insurance  |  100
Insurance –Priority Mail Express  |  101
Return Receipt  |  102
Collect on Delivery  |  103
Certificate of Mailing (Form 3665)  |  104
Certified Mail  |  105
USPS Tracking  |  106
Signature Confirmation  |  108
Registered Mail  |  109
Return Receipt Electronic  |  110
Registered mail COD collection Charge  |  112
Return Receipt –Priority Mail Express  |  118
Adult Signature Required  |  119
Adult Signature Restricted Delivery  |  120
Insurance –Priority Mail  |  125
USPS Tracking Electronic  |  155
Signature Confirmation Electronic  |  156
Certificate of Mailing (Form 3817)  |  160
Certified Mail Restricted Delivery  |  170
Certified Mail Adult Signature Required  |  171
Certified Mail Adult Signature Restricted Delivery  |  172
Signature Confirm. Restrict. Delivery  |  173
Signature Confirmation Electronic Restricted Delivery  |  174
Collect on Delivery Restricted Delivery  |  175
Registered Mail Restricted Delivery  |  176
Insurance Restricted Delivery  |  177
Insurance Restrict.  Delivery –Priority Mail  |  179
Insurance Restrict. Delivery –Priority Mail Express  |  178
Insurance Restrict. Delivery (Bulk Only)  |  180
Scan Retention  |  181
Scan + Signature Retention  |  182
Special Handling -Fragile  |  190

USPS Special Services are available now since version 1.1.4. Here are the docs: https://github.com/alexeybusygin/ShippingRates/wiki/USPS-Special-Services


Is it possible to record search terms?

Hi! I am wondering if there is any way to change this theme so that it is possible to record the terms that users search for?
We have a documentation site and it would be nice to have a list of what people are searching for, since that will have many clues about which documentation material needs to be written next.
Is it possible with the current search architecture? How?
EDIT: One way to do this would be to have some javascript call out an HTTP request that could be pointed at the statistics engine (like Piwik or Google Analytics).
Thanks!

You could add some Javascript for sending the searched data to another server like Google Analytics does for visited pages. Nothing is impossible but you will have to implement it yourself.
Did you try https://matomo.org/ (ex Piwik), it may help you !

Hi, thanks for your fast reply. We already run Piwik, my question is just how to connect it with the current search architecture.
I confess I don't know the Search currently works in Learn Theme. If you can just point me to the place in the code where you think the call should be added, I'll try and take it from there.
I have an intuition that one thing will be difficult: since search is find-as-you-type, when people search for Cats, you would get a query for C, another for Ca, another for Cat and finally one for Cats. And avoiding this might not be simple... you never know when the person is still going to type more characters.

Search is based on searching in a json file containing page content (with Lunr). This file is exposed by Hugo thanks to the file index.json. Then search is done by https://github.com/matcornic/hugo-theme-learn/blob/master/static/js/search.js
You can see a rendered example file at https://learn.netlify.com/en/index.json
To avoid the problem of searching for each letter, the usual solution is throttle/debounce function (ex: http://benalman.com/projects/jquery-throttle-debounce-plugin/). Then add needed Javascript in your custom custom-footer
I don't know much about Piwik and whether you can send this kind of data though.

Thanks a lot for the detailed information. I won't be able to work on this right away but I will definitely save this precious guidance for when get a chance.


Update to Kafka <IP_ADDRESS>

Version <IP_ADDRESS> of Kafka is now available: https://archive.apache.org/dist/kafka/<IP_ADDRESS>/RELEASE_NOTES.html

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

CLA signed!

Your commit was merged in #38 , closing.


background-image

Hi,
Sorry for the basic question, how can I change the height of the background-image? I would like to decrease it but I can't seem to find any height percentage or pixels in the CSSs. Thanks!

I figured it out.
I guessed it is getting a default value from bootstrap, I overwrite the default by adding height: XYZpx; in the header.masthead class which is located in the file _masthead.scss.


Fix title of sliders added to Report

When adding custom figures with mne.Report.add_slider_to_section, the section parameter is erroneously used in the sidebar to refer to the image. This should be the title parameter.

I will have to see how this effects the reports I've been creating. I think I noticed it had this peculiarity and set my section and title values to something that made it look reasonable. It's possible fixing/changing this behavior could break existing report aesthetics. But maybe it's always for the better...
Perhaps things on the left should actually be nested with indents like:
Section 1
    Title 1
    Title 2
    ...
Section 2
   ...
...

That seems more backward compatible because it at least keeps the section names on the left, too.

ping @jasmainak

seems like a reasonable fix to me @wmvanvliet
@larsoner I let you check your report scripts before merging. The idea of nesting is a good one! But probably not crucial for this fix ...

Almost nothing changes in my reports, probably because whatever workaround I was using put the same value in two places. Thanks @wmvanvliet


argument to setProperty must be const reference

argument to setProperty must be const reference. Current implementation modifies the argument which is bad design.

:octocat: cibot: Thank you for posting issue #1098. The person in charge will reply soon.

Now every setProperty has const reference :)


networkx>=2.5 support

Describe the feature
Add networkx>=2.5 support to mmdetection3d
Motivation
mmdetection3d only supports networkx<2.3 (see https://github.com/open-mmlab/mmdetection3d/blob/master/requirements/runtime.txt).
Would be nice to have networkx>=2.5 support. Otherwise, mmdetection3d can't be used with other modules that expect a newer networkx version.

I tested with networkx >= 2.5 and it works fine (at least for the models I tried). Perhaps you can just upgrade the version of networkx? We will test on this and update the requirements if appliable

Thank you.


Warn when trying to ref.listen a scoped provider

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

erm, @rrousselGit? you didn't fill out your own issue template...

@TekExplorer because I know what I need to do :P

@TekExplorer because I know what I need to do :P

i mean yes, cleary, but it would be nice to know what and why this is :p

Well I'm working on this as we speak, so you'll see soon~


Update c-lightning-REST to v0.9.0

Previous versions of c-lightning-REST will not list multiple channels per peer. This causes all REST consumers such as RTL and Zeus to display the incorrect number of channels.
See: https://github.com/Ride-The-Lightning/RTL/issues/988#issuecomment-1227595503
The current version is v0.7.2. cl.rest.sh

Thx. Will take a look for next release.

OK updated to 0.9.0 - will be part of next release. Closing issue.


Add version catalog problem location

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

I just noticed that this isn't going into master, apologies if my comments are too early.

@octylFractal don't worry, feedback is already welcome :).
It's based on the other PR, therefore I set the target to that one. It should be easier to review what actually matters here.

@bot-gradle test APT

I've triggered the following builds for you. Click here to see all build failures.

AllPerformanceTestsReadyForRelease build

@bot-gradle help

@bot-gradle test RFM

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Moved to https://github.com/grale/gradle/pull/26885


create logo

LogCabin needs a logo, preferably before 1.0. Here's an image that might be useful, if we can get it to look more like a drawing. This is sitting on my desk for now, so I can take more images as needed if that'd help.

I'm probably not the right person to do this. Anyone more artistically talented able to help?

Couple more pix and some dimensions ?

@bch I don't see how dimensions are important but here ya go:

@bch, are you trying this? It sounds like 14BlackPoppies on twitter might be willing also: https://twitter.com/14BlackPoppies/status/584075100590211072

Hi -- ya - I was going to try a 3d cad model and see what happens --
don't let my interest stop anybody else though...
-bch
On 4/3/15, Diego Ongaro<EMAIL_ADDRESS>wrote:

@bch, are you trying this? It sounds like 14BlackPoppies on twitter might be
willing also: https://twitter.com/14BlackPoppies/status/584075100590211072

Reply to this email directly or view it on GitHub:
https://github.com/logcabin/logcabin/issues/123#issuecomment-89398769

Hope y'all like what I came up with :)

Of course, I'd be happy to switch to something better if someone with more artistic ability wants to work on this (probably best to open a new issue at that point).


Fix big liquibase/jpa repository configuration issue

getting rid of is restarting field close #232
Fix H2/Mysql start error
Renamed and move WakeupApplication
Refactoring repositories

Coverage decreased (-1.2%) to 88.889% when pulling 0b0f79eaeda61a986b382bd154370198f2ebbe33 on fix/repositor-refacto into 650ca1ec7272892c649324f2100718e598e6ad47 on develop.


Add community newsletters page

With the rise of Hack Club's new community newsletters, I figured it would be a pretty cool idea if we had a page that showcased all the issues, similar to the VIP newsletters!

The authors of each issue are rendered based on the contributors to the issue in the Github repository!

📝 Changed routes:

/newsletters/[slug]
/newsletters

(view full size)
(view full size)

Commit c52f6fc987548bde0627a91f3f1247fc565a0b32 (https://workshops-jf4zr8jbb.hackclub.dev).


Sound fall behind(delay)

(50% of all download video) sound fall behind(delay) video
how to fix? in stream VOD all is ok, but twitch leecher 1.5.8 make this

Please browse closed issues befor posting... there is enough info there


Getting a pod by label fails when serving an archive

When an archive created by crust-gather is served using eg. kubectl-crust_gather serve -a $directory, getting a pod or its logs by label fails:
For instance:
$ kubectl get pods -n cattle-fleet-system -l app=fleet-agent
No resources found in cattle-fleet-system namespace.

# This generates the following crust-gather output:
2024-11-19T08:56:47.008957Z ERROR table{table="namespaces/cattle-fleet-system/v1/pod/*.yaml"}:try_from{selector="app=fleet-agent"}: kubectl_crust_gather::gather::selector: error=failed to parse value as expression: '-' at 9..10
2024-11-19T08:56:47.014260Z ERROR table{table="namespaces/cattle-fleet-system/v1/pod/*.yaml"}:try_from{selector="app=fleet-agent"}: kubectl_crust_gather::gather::selector: error=failed to parse value as expression: '-' at 9..10
2024-11-19T08:56:47.017589Z ERROR table{table="namespaces/cattle-fleet-system/v1/pod/*.yaml"}:try_from{selector="app=fleet-agent"}: kubectl_crust_gather::gather::selector: error=failed to parse value as expression: '-' at 9..10
2024-11-19T08:56:47.020614Z ERROR table{table="namespaces/cattle-fleet-system/v1/pod/*.yaml"}:try_from{selector="app=fleet-agent"}: kubectl_crust_gather::gather::selector: error=failed to parse value as expression: '-' at 9..10
2024-11-19T08:56:47.024984Z ERROR table{table="namespaces/cattle-fleet-system/v1/pod/*.yaml"}:try_from{selector="app=fleet-agent"}: kubectl_crust_gather::gather::selector: error=failed to parse value as expression: '-' at 9..10
2024-11-19T08:56:47.027600Z ERROR table{table="namespaces/cattle-fleet-system/v1/pod/*.yaml"}:try_from{selector="app=fleet-agent"}: kubectl_crust_gather::gather::selector: error=failed to parse value as expression: '-' at 9..10
2024-11-19T08:56:47.031166Z ERROR table{table="namespaces/cattle-fleet-system/v1/pod/*.yaml"}:try_from{selector="app=fleet-agent"}: kubectl_crust_gather::gather::selector: error=failed to parse value as expression: '-' at 9..10
2024-11-19T08:56:47.033542Z ERROR table{table="namespaces/cattle-fleet-system/v1/pod/*.yaml"}:try_from{selector="app=fleet-agent"}: kubectl_crust_gather::gather::selector: error=failed to parse value as expression: '-' at 9..10
2024-11-19T08:56:47.036526Z ERROR table{table="namespaces/cattle-fleet-system/v1/pod/*.yaml"}:try_from{selector="app=fleet-agent"}: kubectl_crust_gather::gather::selector: error=failed to parse value as expression: '-' at 9..10

However, getting the same pod by its name succeeds:
$ kubectl get pod -n cattle-fleet-system fleet-agent-0 -o=jsonpath="{range .items[*]}{.metadata.name}{'\t'}{.metadata.labels}{'\n'}"
fleet-agent-0   {"app":"fleet-agent","apps.kubernetes.io/pod-index":"0","controller-revision-hash":"fleet-agent-5dd5d5dd8c","statefulset.kubernetes.io/pod-name":"fleet-agent-0"}

Seems that the problem is within the regex, which should include “-“: https://github.com/crust-gather/crust-gather/blob/e4b942437160e61bf298e2ecf5c0ddeed01096aa/src/gather/selector.rs#L59
May be enough to replace/extend each \w with the set from https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/

Fixed by #181


OnOff Cluster - OFFONLY feature example

Added Cooktop device type on endpoint 3
OnOff cluster is enabled with feature OFFONLY
Only OFF command is supported, other commands will result in unsupported_command

This is an old PR in draft form that has merge conflicts. Assuming stale and closing.


display Text instead of URL on sidebar

Display text instead of raw URL on sidebar; I believe it is the desired behavior. like this:

i didn't realize the first problem, but for my use case it is ok.
adding hover display and setting customization certainly has some work to do. i'm very new to Obsidian plugin, hopefully i can find some time to investigate.

Cool! We can collaborate on it!


Change Name to OpenBCI_Radio

The name should be changed to singular to match naming convention and library implementation. @biomurph this should be approved by you :)

Another option could be to change the name of the library files to OpenBCI_Radios


Http.connector.redirect

Added parsing of MAXIMUM_REDIRECTS in ResourceAddress whether
Added MAXIMUM_REDIRECTS to xsd
Added test to WsnConnectorRule to follow redirects
Fixed bug where resetParent needs to be called on all http redirect sessions (as proved in above test)
Feedback from Code review


Please test if the new version of utility.py works for Mac

Hello, I tried to fix the bug with the utility function. Could you please verify for me if the new version works on your Mac? Thanks.

@ZhouLong0 @liuya2360

yes, it does ty!


How to build the docker images ?

⚠ Please verify that this question has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
hi @louislam , first of all a big thanks for making this project as an open source. I am inspired with your journey and want contribute in the existing open issues...I have picked up coupled of issues and started fixing.
Now, before pushing the code, I want to test it on my local machine by building the docker images and running in my local.
So, I can test as well which ensures that everything will work fine if you merge my PR with the master branch.
So, it would be great that if you tell me the steps for creating the image locally, so I can test in local with the temporary docker image.
Thanks & Regards,
Sohit
📝 Error Message(s) or Log
No response
🐻 Uptime-Kuma Version
1.23.13
💻 Operating System and Arch
Ubuntu, Mac
🌐 Browser
Google Chrome
🖥 Deployment Environment

Runtime: Docker 24
Database: Sqlite
Filesystem used to store the database on:
number of monitors: 15

off-topic: Making every 3rd world bold is quite distracting, please don't.

I want to test it on my local machine

Please refer to our contributuin guide. You can run in development mode via
npm run dev

[!TIP]
For testing PRs, we have documented this workflow: https://github.com/louislam/uptime-kuma/wiki/Test-Pull-Requests

steps for creating the image locally

You don't need this, but here is the command we use to build the production docker images:
npm run build-docker


remove redundent return statements

Minor - There is a fair amount of redundant return statements. Removing to clean it up a bit

Thank you


Add support for blobs with spaces (and other special URL characters) in the name

I've updated every test that operates on a blob to check for the existence of a space, and other special URL characters. I've excluded the + (plus) character from this, as it appears to need additional special handling (as it stands in for 'space' in some parts of the URL component, but not others).  The others work as expected.

Hi @bcc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@bcc thanks for the pull request. This looks good in general except I am a bit against having special char blobs spread over all test cases. Please do not forget to sign the CLA (see the comment above).

@bcc pinging to see if you are still interested in carrying this. I have left a couple of comments and we need CLA to be signed to merge this.

@ahmetalpbalkan Yep, had some fun and games getting workplace to sign off on the CLA. Will hopefully have this resolved early next week. Comments are fine, I've not had time to make the changes yet, but seems reasonable.

@bcc, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

@ahmetalpbalkan Support for + in blob names also now supported. I've made the changes you suggested, but I've left the special chars in TestBlobSASURICorrectness as I think that sense for that particular test.

@bcc thanks for addressing these issues. I guess I should write a separate test to validate the special characters. randNameWithSpecialChars might not return special characters all the time, so that will introduce some non-determinism in validating that code path you added.
Would you like to just add a test for uploading a constant blob name with a special characters in it? That might help address the original issue (blob upload with special chars) better. If not, I can just go ahead and merge and take the fix myself.

@ahmetalpbalkan randNameWithSpecialChars will always return the same set of special characters, only the prefix and postfix alphabet characters are random. I had the same concerns regarding the repeatability of that test.

@bcc ah okay then! I missed that point.

Thanks for the contribution @bcc!


Print Factorial of a number using stack

Description
Print Factorial of a number using stack
Additional context
Add any other context, links references or screenshots about the feature request here.
Important Checklist

[x] I have read the contribution guidelines before making this issue.
[x] I have verified this issue program is not already implemented
[x] I have not pushed this code anywhere else (even my repo)

Languages and Assignees:

[ ] Python: @
[x] Java: @13snehitha
[x] C: @gh4abhi
[x] C++: @NandiniMundra-8

Please assign this to me.

@kaustubhgupta
Can you allot this to me in java

hey @kaustubhgupta , I would love to perform this task in c++,so can you assign this to me?

Hey can you assign this issue to me?
I will solve it in C


Updates to permissions class

Sorry for the last second bonus fixes, but there were some soft errors to clean up.

I'd say there is nothing left but prepare the packages!


Feature/Return Source Documens to retriever tool

Addressed - https://github.com/FlowiseAI/Flowise/issues/1267


Change repo and maintainer info in page footer.

Currently still points to BitBucket, replace with link to this repo here. New maintainer info should be "Team Townteki" or something like that.

fixed by #10


Simple SELECT makes Influx 1.0 OOM

Running in AWS on an m4.large, Influx v1.0.0 running on Debian Jessie
I have one particular measurement that seems like maybe it is corrupted somehow. When I run a simple SELECT statement on it, e.g.
select * from replay_outcome_stats limit 10
Influx hangs and the heap shoots straight up until the whole box becomes unresponsive. I have to restart the instance to recover. See the attached grafana graph of "Heap Alloc" and "Heap Idle"

shards
http://pastebin.com/VEtq1JXAhttp://pastebin.com/VEtq1JXA
stats
http://pastebin.com/sTQKbAFY
diagnostics
http://pastebin.com/2qbgwcjK

Also, the WAL directory has one sub-folder with a bunch of files still in it. This is the output from running tree on the filesystem:
http://pastebin.com/YEfLPTyk

Your query has no time filters and it looks like you may have sparse data based on the number of shards you have.  That will cause memory to spike currently if you a querying across a lot of shards.  Can you attach the output of "show shards"?

Will probably be fixed by #7303.

My "show shards" output is attached.
shards.txt
However, I'm concerned that there are all these un-compacted files in the WAL. The pastebin contains the output of the filesystem.
http://pastebin.com/YEfLPTyk
I migrated the data from one machine to another via the backup and restore mechanism more than a month ago, and I think I remember seeing those files in the WAL then. Is it possible that somehow the compaction for that data fell through the cracks as a side effect of doing a backup on one machine and a restore into another?

All of those wal segments are snapshotted already.  They are 0 size.
You need to change the shard group duration of your shards or specify a time filter.  Querying across that many shards at once triggers high memory usage currently. The majority of those shards look like they are expired and will get removed once the retention policy runs.
Going to close this as #7303 would fix this issue.

It's section 123 specifically, I'm referring to:
├── [4.0K]  123
│   ├── [ 10M]  _00172.wal
│   ├── [ 10M]  _00173.wal
│   ├── [ 10M]  _00174.wal
│   ├── [ 10M]  _00175.wal
│   ├── [ 10M]  _00176.wal
│   ├── [ 10M]  _00177.wal
│   ├── [6.3M]  _00178.wal
│   └── [5.8M]  _00179.wal

Shard 123 is the current shard for this week.  If it's taking writes, you'll have some wal segments until they are snapshotted or goes cold.
123	hsreplaynet	default			123		2016-09-19T00:00:00Z	2016-09-26T00:00:00Z	2016-09-26T00:00:00Z


qtox on master missing 99% of in-application icons

kde4.qtox, as seen in master, as of July 3, is missing 99% of in-application icons -- I have seen just one.

cantata also started to miss most of its icons, I don't know if it's related…

That could be some qt5 change. So far I've only solved some gtk in-app icons by wrap-extending $XDG_DATA_DIRS by $XDG_ICON_DIRS (defined by some icon-providing packages that need to be in build inputs for this to work).

/cc @ttuegel (seems to know most about our qt5).

I'm not sure what this has to do with Qt 5? If it's under kde4, it should be a Qt 4 application.
General comments: Qt doesn't have an "icon theme" concept like GTK does. Icons are loaded by application-specific means. Setting those variables would help if qtox respects them. Note that KDE does provide the "icon theme" abstraction. You'll probably have to poke at the source code to see how qtox gets its icons.

This is what I see, for example for the friendlist widget code -- which is all iconless:
    avatar->setPixmap(QPixmap(":img/contact.svg"), Qt::transparent);
    statusPic.setPixmap(QPixmap(":img/status/dot_offline.svg"));

..which is in qTox:///src/widget/friendwidget.cpp

That looks very much like they are trying to use embedded resources, but the syntax is wrong.

@ttuegel: that's a mistake, I believe: I see no kde4.qtox, just plain qtox attribute which depends on qt5 (and not qt4).

I can't tell from this issue; did the icons it qTox ever work correctly in NixOS? (I will presume so until told otherwise.) The resources should be compiled in, so it's not an issue of being unable to find files at runtime. Does the build show any errors related to rcc?

I have seen an older NixOS build of qtox with icons, yes. February or so..

Same problem with qgis, interestingly enough it happen on a computer but not on an other and they both share the same system packages configuration.

Icons are typically picked up from XDG dirs which typically means that also some ~/.foo locations are searched, for example. Wrapping the executables with correct icon path is the nix solution (meaning some work per package).

(triage) Is that still a problem?

@Profpatsch I can not reproduce it for qgis, I'm unsure about the OP issue though.

@Profpatsch, I confirm that this is no longer an issue as of master ee8fbaf4110f29d5473c659168cf9bed3f72c86f.


shift i and a offset are back

It was a closed issue but ...
shift i doesn't go to the beginning of the line and 'a' jumps forward a few characters. I deleted the vscode cache extension in (user/.vscode/extensions) and installed again but still no go.
Latest dev Neovim.
Love the plugin.

Can't reproduce


feat(frontend): enhance dapp data

Motivation
The Design-Team added more social links and new images for the dapp-explorer. This MR updates adds the new data.
Changes

Add images for decideID and OpenChat
New image for KongSwap
Add callToAction as optional string
Add OpenChat and Telegram as social

Could you confirm if the new PNG files are optimized for the best resolution and compression? For example, woould similar files in Webp significantly smaller?

Converting to webp and compressing once more saved a few KB :)


Why you only use half of the feature for FFT?

Hi there,
Thanks for sharing the work, which is excellent! I  am curious, in FFC, why you only use half of the feature for FFT. Did you ever try using different scales of features to divide Local and Global? For example 3/4 for LOCAL, and 1/4 for GLOBAL? Also, in both of the 'Local' and the 'Global', you actually use convolution operation  3 times and FFT only once, then do the feature fusion. Did you ever try dealing with Global feature all in frequency domain. In other words, have you tried making frequency domain operations a larger proportion of your FFC? And what inspired you to do this decision?
Thanks for your attention!
Best
Chris

To the best of my knowledge we did not do a lot of experiments on that! please let us know if you try!


Inject values of attributes, allow custom urls for each content type

Read the updated README to get an overview of what's new ;)
This uses the pluginOptions for a model's settings introduced in Strapi v.3.6.x. See the README for examples. It is implemented in a way that still allows activating the preview and clone buttons using the "normal" options (See services/preview.ts line 42):
"options": {
  "previewable": true
},

I made that switch because the i18n plugin (and others) by Strapi use it and it seems to be the new way for plugins to add their options. Theoretically you could also add fields to the content type builder to configure these options like the i18n plugin, but the api is undocumented and might change, so I didn't do that.
Closes #11

Hey @danestves, would you mind having a look? Sorry for this pushy bump ;)

Oh I didn't si this before! Let me take a look and merge ASAP ✨

Seems really a good improvement @pr0gr8mm3r! Just fix some of the code there and i'll merge it, document in changelog and update new version to NPM 🙌

Also as i see this feature is also good for https://github.com/danestves/strapi-plugin-preview-content/issues/7?

Not quite, as I undestand it #7 calls for the settings to be configurable through the settings. Now the a model's custom preview url is the same between environments, but you'd still have to set the base Url in the settings (if you don't want to hardcode the Url in the custom preview url and therefore loose the ability to easily switch your hostname).

Just fix some of the code there and i'll merge it, document in changelog and update new version to NPM

What code should I fix? Should I bump the version or will you do that?

@pr0gr8mm3r i request a review up there, see some of the changes that i request:

Huh, the review didn't show up for me. Anyways, I fixed what's in the screenshot.

Let me make some changes for changelog and so on and i'll publish, in 20 minutes you will see the new version

Thank you for the help @pr0gr8mm3r i put the new version now in npm!

Thanks!


[Feature][Deploy]  Optimized k8s script format

What is the purpose of the change
Optimized k8s script format.
Related issues/PRs
Related issues: #115
Related pr:#136
Brief change log
Optimized k8s script format
Checklist

[x] I have read the Contributing Guidelines on pull requests.
[ ] I have explained the need for this PR and the problem it solves
[ ] I have explained the changes or the new features added to this PR
[ ] I have added tests corresponding to this change
[ ] I have updated the documentation to reflect this change
[ ] I have verified that this change is backward compatible
[ ] If this is a code change: I have written unit tests to fully verify the new behavior.

need to add the ingress exit configuration

LGTM


completion/validation on kind

I thought completion wasn't working on metadata's name/labels/annotations etc

turns out I'd made a typo in the kind but the LSP didn't warn me or offer completion

DOH - spot the obvious mistake on the kind :) I guess completion on kind would be good too

Hi! I've looked into this and this actually has more to do with the default VS code settings then it does the extension. For some reason by default in the user settings under editor, editor.quickSuggestions is false for strings and thats whats needed in order for autocompletion to work. When editor.quickSuggestions string is set to true this is what you should see:

I will update the readme so anyone else who tests this knows!!

Also there's no completion for the values of kind which should autocomplete all the known kinds like Deployment, Secret etc etc

I've added this this in the newest release!


Change the endpoints so they are easier to reverse proxy

Old:
GUI: http://localhost:1717/secrets
REST: http://localhost:1717/api/secrets

New:
GUI: http://localhost:1717/secrets
REST: http://localhost:1717/secrets/api

This way you can have an NGINX configuration that proxies "/secrets" to "/secrets". With the old config, either you needed two location definitions, or an extra prefix in the path requested by the client.

This PR is best viewed with the "Hide whitespace changes" option. The indentation was inconsistent with the EditorConfig settings.


Add ocaml-cow & update needed ocaml-packages (especially async_ssl related stuff)

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Fits CONTRIBUTING.md.

State of this PR
I expect to break a few packages with this PR, but I wanted to open this for discussion as soon as possible.
Known breakages are currently:

  ocamlPackages_4_02.trv

I am eager to hear your opinions! Especially if you know a good method for testing for breakages inside   ocamlPackages  .

I’ve merged the ezjsonm update in 44820907afab52221ac7db20bf6e115ee42a927a and the init of logs in 4f0feb4f5f2f4662a075f015d9675b25865b3ae9, as they are independent of this issue.

@vbgl seems resonable, will rebase those commits out of this branch!

I took care of the uri update in d2a4a84f00019596006cf218df9f8b143c7d624d, and cherry-picked the init of cow in a452714799b36fae4c34e7167122d2b26ff07747 (after fixing the propagated inputs).
How did you end up touching ipaddr and async_ssl?
All this _p4 stuff is an ugly mess; we need to find a proper way to deal with several incompatible versions of the set of core libraries…

I have a pr coming for the core stuff.

@vbgl because   cow   depends on the most current version of   uri  , that update then caused all the other changes.

I don't think these changes are not too important at the moment, maybe, we better wait with the updates of   cohttp   and   async_ssl   since the   core  -stuff has been resolved by @FlorentBecker?

Sorry, I misunderstood what the problem with core was, I haven't fixed it. I think we should drop packages which only compile with caml 4.01 (here, it seems trv is the one causing trouble).

This seems like a reasonable idea in the long term, many of the current dependencies to   _p4   packages can be resolved by updating the packages.

I think this kind of reasoning is flowed. In the long term, every single package that is currently in nixpkgs will be removed or completely rewritten. Each package is a temporary hack to accommodate for the current state of the world. We cannot just wait that everything eventually gets fixed.
trv in nixpkgs is available on 4.02 only. It builds and seems to work. It has been recently added with — I guess — some user need in mind. And I don’t see how removing it will help solving actual issues (like, say, having ocamlPackages_latest.sexplib build).

My mistake, I thought trv was old and unmaintained, it isn't.

@ericbmerritt : is trv supposed to be in nixpkgs? Its homepage says it isn't.

Cherry-picked the ipaddr update in 8352e0b38c65a736219619d8821ad50f787e58d1


SQLite support

@go-jet , issues #43 and #76 mention SQLite support coming soon. Are there any plans on making this happen in the foreseeable future?

I believe it should be included in the next release.

Is there a date planned ?

No, the date has not been set yet. Depending on the complexity, the next release may be in the next 1 to 3 months.


Question: node_redis & ioredis merge status

What's the status of the merging of node_redis and ioredis?

Thanks for asking. In general: I must work again on node_redis and I hope to find time soon for it again. There must be another major version with more features in here before that can progress much further.
So currently there is no specific timeframe.

I was hoping that cluster support was being added to node_redis.  I've started to use redis clusters with ioredis and have run into a number of disturbing issues.  @luin has not been responding to any recent issues logged, so I am rather concerned about the continued viability of that library.

I am soon going to work on cluster support here. So stay tuned :-) it will not happen in the next two weeks though.

@BridgeAR I have time soon (also I work at Redis Labs now, so if we have any questions I have a direct line to experts ;) )

Any update?


set cursor pointer for network node label

This will address https://github.com/VEuPathDB/web-monorepo/issues/1165.
@asizemore Simply put, it was a typo, though it took some time to find the reason as it was hard to notice 😓

@asizemore yes indeed. Hard to find it: I missed it several times too😄


Match Secondary Email in WRF

Hi Piotr,
We recently added the option to include a secondary email in AMY's person record. I'm creating this issue to verify or update our person matching for instructor training applications and/or all workshop request forms to the secondary email address if used.

Once matched, person's secondary email gets updated with what's in Training Request secondary email field.
However, secondary email from Training Request was not used to search for matching person. This will be changed.
Workshop requests (and workshop inquiries, and self-organised submissions) aren't meant for creating persons, so they don't offer "match with this person" capability.


YouTube mobile version blank

We already had the same error once back :)
I updated my page with your proxy and realized that It stoped working (YouTube): http://i.imgur.com/AOP3zBM.jpg

decrypting all that javascript inside m.youtube.com is impossible right now. Why use mobile in the first place? You're better off using an actual server here instead: http://www.proxynova.com/proxy.pac

We at highschool,work with iPads, everything from IP proxys to VPNs are blocked, were not able to install apps.
VPNs don't connect ports are blocked
IP proxys (I did test yours just are stuck loading)
I can wait, and others too


Add Connection animation to Block Clock connecting state

Based on https://github.com/bitcoin-core/gui-qml/pull/252

light
dark

Thank you for implementing this, I just tested it and have a few thoughts.
Since we have the blinking dots to communicate that a network connection is being established, I don't think we need to show this massive loader right away. Maybe it can only appear after 5 seconds of a blink dot, in case the user gets impatient ("now the app is trying really hard").
Fading the loader in and out somewhat slowly, maybe 600ms, would be nice to avoid this abrupt effect we have right now where it pops in/out instantly.
It looks like the gradient currently goes from yellow to red to the background color. Is it possible to add transparency to this? There's a very slightly funky effect happening right now where the dots on the dial behind the loader get covered up by the last part of the gradient that uses the background color. This could be done later, not sure if anyone really notices this.
Overall, is there any other type of loading the app does that might also need a loader?
On a sidenote, I tested this by disabling wi-fi altogether. Would be awesome if there's a way to detect whether the phone has any type of internet connection and show an appropriate message.
@jarolrod really appreciate how much work you're putting into this app. Hats off to you.

Based on #252

It has been merged.

Updated from e2ecfaf to 6d97c0a, compare
Changes: rebased over main

Updated from 6d97c0a to 3d4a760, compare
Changes: made last color in gradient transparent instead of Theme.color.background

master
pr

Closing in favor of https://github.com/bitcoin-core/gui-qml/pull/272


Allow custom scoring functions in the query

Virtual field allows running an expression. It might be usable in some form for this.

Done with #36 .


New version release

Hello, could you please release new version with release notes support?

PR with version 1.0.1 should be available now.


dashes (-) in filenames on iso9660 images

Hi,
I'm not sure why, but a regexp in filesystem/iso9660/finalize.go and filesystem/iso9660/directoryentry.go sanitizes the filenames and replaces dashes (-) with underscores (_).
Afaik is a dash in a filename valid.
I changed this, added a '-' to regexp, and it looks good and works.
Should I create a PR or is there any risk in my solution?
Thanks,
Kurt

I assume you are referring to this?
In ISO9660, a filename must be composed of d-characters, see section 7.5.1 of the ECMA-119 reference here. Those are [A-Z0-9_] and do not include - (essentially, the same as MS-DOS). You can use other characters when doing things like Rock Ridge and other extensions. But not in the basic iso9660.

Ah, ok thanks, didn't know about that.
My problem is, cloud-init (in NoCloud mode) depends on on an iso with files including dashes in their name (user-data, meta-data, ...).
Is there a plan to implement the Rock Ridge extension to go-diskfs?
thanks, Kurt

It’s already there. Look at the options for finalizing an iso here https://godoc.org/github.com/diskfs/go-diskfs/filesystem/iso9660#FinalizeOptions

Yes, thanks.
Now it works as expected.
Many thanks for your help.


IGAPP-986

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.
@sarahsporck

So there are multiple possible fixes for the failing native tests. The most obvious one being to add lib: ["dom"] to the native tsconfig.json. When looking at https://github.com/tsconfig/bases this could actually make sense, although I think it seems a little bit overkill, as we'd just need the dom types for this specific case right now.
Another solution would be to create a testing tsconfig whith the lib setting adjusted which extends the general native tsconfig. This also seems a little bit unnecessary imo. And if you wonder it is not possible right now to set specific ts options for ts-jest. Read more about this here https://github.com/kulshekhar/ts-jest/issues/2869.
And last but not least you can just add
// @ts-expect-error
const isAndroid = /Android/i.test(navigator.userAgent)

which will disable all typechecking for this line. Also not optimal, but currently probably the simplest solution.


[typo][doc]Modify some words typos.

Proposed changes
Modify some words typos.  An incorrect word was corrected in from_unixtime.md and a superfluous word was removed in BROKER_LOAD.md.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Provide a native way to generate the ID from the sequence

For now, there is no in-built way of generating the id from the sequence. The as mentioned here by @schauder, there is a way to achieve this via callbacks (one of the examples I believe can be found here)
That is a bit tedious, especially if we have multiple different entities in our persistence context (which is insanely often the case). We need to provide the utilities for ID generation from sequence on the framework side.
Related #842

Hey @schauder!
Based on the discussion in this PR: #1922, can we rewrite the implementation in there via callbacks?

That is basically the expectation.


HADOOP-17544. Mark KeyProvider as Stable.

JIRA: https://issues.apache.org/jira/browse/HADOOP-17544

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 51s

trunk passed

+1 :green_heart:
compile
22m 12s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
18m 47s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
2m 19s

trunk passed

+1 :green_heart:
shadedclient
18m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
21m 31s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 31s

the patch passed

+1 :green_heart:
compile
18m 49s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
18m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 25s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
2m 27s

the patch passed

+1 :green_heart:
shadedclient
17m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 17s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

186m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2776/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2776

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 89ea906f45c5 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 74335f5a36debf2170cc5c764bfe75101d803fe1

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2776/1/testReport/

Max. process+thread count
3143 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2776/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@jojochuang Ranger relies on the API, so I think it can be public. What do you think?

@aajisaka I think it would be good to state the API as used by downstream projects. While it would be nice if we can have new Interface having essential methods, it looks difficult to do it without breaking existing codes.
git log of the KeyProvider.java shows that some recent changes are related to external dependencies. Removing those dependencies would make the KeyProvider more stable if possible.
import org.bouncycastle.jce.provider.BouncyCastleProvider;
import com.google.gson.stream.JsonReader;
import com.google.gson.stream.JsonWriter;
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.HashCodeBuilder;

Makes sense to make it public stable to allow downstream key provider implementations to use.

Thank you @iwasakims and @jojochuang for your comments.

Removing those dependencies would make the KeyProvider more stable if possible.

Sounds good. EqualsBuilder and HashCodeBuilder can be removed easily, so I'll try this in this PR. However, the others doesn't look easy.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 18s

trunk passed

+1 :green_heart:
compile
27m 41s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
23m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 58s

trunk passed

+1 :green_heart:
mvnsite
1m 34s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 45s

trunk passed

+1 :green_heart:
shadedclient
19m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  5s

the patch passed

+1 :green_heart:
compile
23m 54s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
23m 54s

the patch passed

+1 :green_heart:
compile
27m 57s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
27m 57s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 56s

the patch passed

+1 :green_heart:
mvnsite
1m 33s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 10s

the patch passed

+1 :green_heart:
shadedclient
23m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 54s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

223m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2776/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2776

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 42ae460fd4ca 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 50028ea8620b3db2c80b0d50209e30157159293d

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2776/2/testReport/

Max. process+thread count
3093 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2776/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Merged. Thank you @iwasakims


Parsing Values (New CE, Comprehensive), some values parsed twice

Describe the bug
Sometimes when values are parsed in New CE and/or comprehensive, they are parsed into two fields, e.g. both date and georeference
To Reproduce
Steps to reproduce the behavior:

When I  enter numerical data
Then I parse it using "Parse Fields" or "Clone from Specimen"
See data parsed twice.

Example:

Expected behavior
Data should only ever parse once.
Environment (please identify where you experience this bug:
*** One of ***

Production
Chrome

Both dates and coordinates are processed independantly, I cannot say if the pattern is recognized from the same or different parts of the label. In some conditions the search may fail. There are also cases when the date or coordinates are parsed incomplete. That is more interesting and may indicate a pattern which was not currently recognized.

On the same label you can also suggest an alternative pattern.  "1 Jan. 28" or "1 Jan." + "28,45". The label is too short to properly catch possible pattern. I can probably add a restriction: do not search for coordinates on the labels shorter than 45 characters? I think it is reasonable. Older labels are short and usually do not have coordinates.

It is not a matter of pattern recognition. It is that data should not be parsed more than once.

Advanced handling like this will require breaking out the parsing library into it's own entity/Gem, which is understood, but unfortunately not likely to happen any time soon.  It's a great rule to add when we get to that point.


Switch TabBarView to PageView

Tabs are now fully driven by slivers.

@Hixie @HansMuller

LGTM

Looks like this one also did some regressioning. complex_layout_scroll_perf_ios__timeline: average_frame_build_time_millis, for example, doubled.

Great!  Such a huge regression should be easy to find.

Looks like it also slightly regressed microbenchmarks:stock_build_iteration, from ~845ms to ~880ms.