Propose "Pull Model" interface for operators

I was lazy and wrote all the operators and pipeline such that they take and return whole populations at a time.  We need to change this so that one individual at a time can be passed down the pipeline.
Acceptance Criteria

Prototype and propose a "pull"-style interface that tries to make it as easy as possible to work with both generational and one-at-a-time operators
Solicit feedback from the team

Essentially, I'll be either re-writing or bringing over smallLEAP code to effect this.  I'll be working on the issue-5 feature branch for this.

I changed context to **kwargs to Operator since that's a common pythonic idiom.  I also added *args.  However, @AureumChaos warns that he wasn't able to get that to work, so I may be entering rocky shoals.  I'll have a crack at it, and if I can't get it to work, I'll just back out.

Welp, when trying to install it to run the test examples:
  File "build/bdist.macosx-10.7-x86_64/egg/leap/operate.py", line 251
    return population, *args, **kwargs

Trivial fix.
I blame it being 4:52pm on a Friday.  ☹

Did make test-fast, and just making a note of these warnings here:
/Users/may/anaconda/envs/leap/lib/python3.6/site-packages/nbconvert/exporters/exporter_locator.py:28
  /Users/may/anaconda/envs/leap/lib/python3.6/site-packages/nbconvert/exporters/exporter_locator.py:28: DeprecationWarning: `nbconvert.exporters.exporter_locator` is deprecated in favor of `nbconvert.exporters.base` since nbconvert 5.0.
    DeprecationWarning)

/Users/may/anaconda/envs/leap/lib/python3.6/site-packages/nbconvert/preprocessors/regexremove.py:41
  /Users/may/anaconda/envs/leap/lib/python3.6/site-packages/nbconvert/preprocessors/regexremove.py:41: DeprecationWarning: Traits should be given as instances, not types (for example, `Int()`, not `Int`). Passing types is deprecated in traitlets 4.1.
    patterns = List(Unicode, default_value=[r'\Z']).tag(config=True)

/Users/may/anaconda/envs/leap/lib/python3.6/site-packages/traitlets/traitlets.py:2367
/Users/may/anaconda/envs/leap/lib/python3.6/site-packages/traitlets/traitlets.py:2367
/Users/may/anaconda/envs/leap/lib/python3.6/site-packages/traitlets/traitlets.py:2367
/Users/may/anaconda/envs/leap/lib/python3.6/site-packages/traitlets/traitlets.py:2367
  /Users/may/anaconda/envs/leap/lib/python3.6/site-packages/traitlets/traitlets.py:2367: DeprecationWarning: Traits should be given as instances, not types (for example, `Int()`, not `Int`). Passing types is deprecated in traitlets 4.1.
    super(Set, self).__init__(trait, default_value, minlen, maxlen, **kwargs)

/Users/may/anaconda/envs/leap/lib/python3.6/site-packages/tornado/web.py:1747
  /Users/may/anaconda/envs/leap/lib/python3.6/site-packages/tornado/web.py:1747: DeprecationWarning: @asynchronous is deprecated, use coroutines instead
    DeprecationWarning)

-- Docs: https://docs.pytest.org/en/latest/warnings.html

---------- coverage: platform darwin, python 3.6.7-final-0 -----------
Coverage HTML written to dir htmlcov

I suggest not scrutinizing them now until the rest of the foundation of the code settles, but at least I'm bookmarking them here now.

The other tests appear to get hung up on the Jupyter notebook having a dependency on a virtual env.  May need to have a discussion with the rest of the team regarding this dependency.
(I don't mind having it, but if it's critical for the tests to run, that needs to be documented.)

Ok, I've done:

renamed operate.py to ops.py since that was more intuitive. (operator.py is already taken, alas)
added ops.evaluate() and ops.clone() along with their respective doctests and unit tests.

I'll proceed on to the rest of ops.py tomorrow, if I'm not interrupted too much.

I got  proof-of-concept working by combining the args and kwargs passed in to the explicit function call with those passed down the pipe.  We can discuss this Friday, and if amenable, I can move forward to rope in the remaining operators.

Since the proof-of-concept has been accepted, I'm marking this issue done, and moving on to #6 for completing the actual implementation.


Move all abstract functionality from QuantumOpticsBase to QuantumInterface

fixes piracy issues
makes the distinctions between QuantumOpticsBase and QuantumInterface clearer

QuantumInterface is for abstract types and concrete bases (so it can be used by QuantumSymbolics, QuantumClifford, and QuantumSavory)
QuantumOpticsBase is for concrete datastructures for Schroedinger-style simulations
QuantumOptics is for dynamics over types defined in QuantumOpticsBase

Surprisingly, this was very easy. There is only one difficult piracy issue to be fixed, a testament of how well abstracted the two layers of QuantumOpticsBase have been from before the split into QuantumInterface.
No new functionality is added. No functionality is removed. Almost all piracy issues are fixed. Significant new tests are added.
This is a breaking version -- 0.2.0. It will not be used by any other library until their compat field is updated.
I will wait a weak or so for review, but as there are no functionality changes, only moving code around, I will not block the merge waiting on review. Let me know if you prefer I take it slower. We can have slower more thorough merge window on the QuantumOpticsBase side of things.
fixes https://github.com/qojulia/QuantumInterface.jl/issues/4

I tried to make each commit easy to review on its own, if that is your preference. I would suggest merging without squashing. The "Breakage CI" is expected to fail as this is indeed a breaking release.

JET and lazy strings issues to be fixed shortly

it should be ready for review now


[Utility] Stake Weighted Supplier Rewards

Objective
Achieve feature parity with the Stake Weighted Servicer (now known as Supplier) Rewards.
Origin Document

pocket-core implementation can be found here: https://github.com/pokt-network/pocket-core/pull/1449

👆 should be used as the reference for how to implement this

Goals

Achieve stake-weighted reward parity with Morse
Clean implementation to enable other types of reward staking tiers post mainnet
Clear documentation of how this works

Deliverables

[ ] Parity implementation of stake weighted rewards from Morse
[ ] Docausrus document describing how this functionality works

Non-goals / Non-deliverables

Redesigning the stake weighted reward mechanism

Creator: @Olshansk
Co-Owners: @bryanchriswhite

Closed by closing #825


Add Feature to Copy Images from Various Image Hosting Services

Hello, thanks for the nice plugin
It would be great if the project could support copying images directly from various image hosting services or Object Storage Services (OSS).
Suggested Functionality

Ability to copy images directly from URLs provided by different image hosting services.

Best regards

@edwards19900128. Thank you for informing me. May I confirm that directly copying images from various image hosting services implies copying images in Markdown format such as ![flow.png](https://s2.loli.net/2024/09/23/b5gadTAhojsQUnu.png) in your Obsidian note?


Unpinning one item initiates a full refresh of the pin-list

Describe the bug
When one item of the list of pins is unpinned, the UI initiates a full refresh of the pin-page, which takes a lot of time.
Expected behavior
The UI understands that unpinning one item from the "root" of pins will just remove the item from the list, and hide it, and work with the delta data until the next refresh is initiated.
Desktop (please complete the following information):

OS: Linux
Browser chrome
Version 79

Additional context
Probably related to https://github.com/ipfs-shipyard/ipfs-webui/issues/1403

The list of low level pins will be removed from GUI as part of https://github.com/ipfs/ipfs-gui/issues/91


[Refactor] Package YAMLs alongside pip installations of lm-eval

Currently, if not installing the python package via pip install -e ..., the YAML files (and any non-python files) will not be copied to the environment's lm_eval installation. The solution to this is to tell setuptools.setup to track these files and include them as package data.
Reference:
https://stackoverflow.com/a/1857436
In future, we may also consider switching to pyproject.toml with MANIFEST.in, potentially. https://stackoverflow.com/questions/69647590/specifying-package-data-in-pyproject-toml

Nice catch!


[bug] Update Readme

I believe what's there has been deprecated.

@smyja thanks for filing an issue with us.  Is there a specific portion of the README that you believe contains a deprecated reference?  From what I can see, all of the code samples are still valid.
There are a handful of non-deprecation warnings that I'll address here though.
Some are regarding prompt variable format, one of which may not be accurate and I'll track that in another issue and cross reference here.
It also appears that the length validator does not support objects. I'll have to check with the team to see if this is intended to be supported or if this is an example of a descriptive format for the llm like shown here with the 1-indexed format.

Oh, I felt the rails spec format had been deprecated since it now uses pydantic as specified in the docs and a pr that contained an example for llamaindex. I'll close this.

We should probably add the pydantic equivalent as well.  We still support both formats, there's just more flexibility when using the code-first implementations (i.e. from_pydantic and from_string).

Yeah,since the pydantic one is easier to understand.
On Fri, 13 Oct 2023, 14:42 Caleb Courier, @.***> wrote:

We should probably add the pydantic equivalent as well. We still support
both formats, there's just more flexibility when using the code-first
implementations (i.e. from_pydantic and from_string).
—
Reply to this email directly, view it on GitHub
https://github.com/guardrails-ai/guardrails/issues/387#issuecomment-1761542371,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEZEC4TXHDE56SZOQHCAGE3X7FAMXAVCNFSM6AAAAAA56X3SDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRRGU2DEMZXGE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

I went ahead and made an issue for this: https://github.com/guardrails-ai/guardrails/issues/390
Thanks again for bringing this up!

I also want to point out that in addition to our README, we also have docs hosted over here: https://docs.guardrailsai.com/
Most of our examples in the docs should show both the XML and the Pydantic implementations.

Awesome, thanks for the info!
On Fri, 13 Oct 2023, 18:21 Caleb Courier, @.***> wrote:

I also want to point out that in addition to our README, we also have docs
hosted over here: https://docs.guardrailsai.com/
Most of our examples in the docs should show both the XML and the Pydantic
implementations.
—
Reply to this email directly, view it on GitHub
https://github.com/guardrails-ai/guardrails/issues/387#issuecomment-1761884751,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEZEC4XRVUY64RSYJZ4AV73X7F2AFAVCNFSM6AAAAAA56X3SDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRRHA4DINZVGE
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Update Berlin,DE data

The provided source for Berlin, DE is outdated and not available anymore.
There is a new source available:

WEBSITE: https://daten.berlin.de/tags/amtlichen-hauskoordinaten
WFS: https://fbinter.stadt-berlin.de/fb/wfs/data/senstadt/s_wfs_adressenberlin?service=WFS&version=2.0.0&request=GetFeature&TYPENAMES=fis:s_wfs_adressenberlin&srsname=EPSG:25833
LICENSE: DL-DE->BY-2.0

The WFS endpoint only returns XML, not sure if this can be processed automatically or needs to be converted to CSV with static upload first. If this is the case, I could do it, but I don't have permissions to upload files.

Awesome, thanks.
Quick question @arch0345: How can I apply to get permissions to be able to upload data? I'm working a lot with address data in Europe and would ❤ to update available sources or add new ones.

@StephanGeorg normally we require that the data is fetched directly from official sources and don't accept uploads of data. What sort of data are you looking to upload?

The only reason to upload data was that I was not able to configure XML data coming from

WFS: https://fbinter.stadt-berlin.de/fb/wfs/data/senstadt/s_wfs_adressenberlin?service=WFS&version=2.0.0&request=GetFeature&TYPENAMES=fis:s_wfs_adressenberlin&srsname=EPSG:25833

and then I saw https://github.com/openaddresses/openaddresses/pull/7040#issue-2097598936.
If there's any example or documentation how to use XML from WFS I would prefer to use the original source of course. Same goes for #7049.

@iandees any thoughts on 👆


Javascript error in AjaxFileUpload.js

Hello,
I'm successfully using the AjaxFileUpload control in VS 2013 but, as I want to check file sizes BEFORE uploading, I'm trying out some javascript code that uses AjaxFileUpload.js. I get the following error every time the page loads. I've seen that MikhailTymchukDX has been making some changes regarding the AjaxFileUpload control  and I'm wondering if the changes will help with this issue - if so, is there a set of updated files I could download?
Unhandled exception at line 1, column 1 in http://localhost:54093/js/AjaxFileUpload.js
0x800a1391 - JavaScript runtime error: 'Type' is undefined

This feature is implemented in PR #73
You can download the entire repository or the latest version of the AjaxFileUpload.js file.
As for the error you provided, would you please describe it in more detail:

What application do you run?
If possible, make a screenshot of the browser console with this error.
I am looking forward to your response.

Hello Mikhail,
Thanks for your support. I’ve recently been employed by a company that has a web application called ‘SafeWells’. It’s a pretty big project, but it is quite old and in need of some modernization – so I’m currently trying to improve its file uploading feature.
The problem happens when I load a page with  which is called by some javascript on the page:

There is a scriptmanager…
<asp:ScriptManager ID="ScriptManager1" runat="server"></asp:ScriptManager>
And the ajax upload control is:
<ajax:AjaxFileUpload ID="AjaxFileUpload1" runat="server" Padding-Bottom="4"
Padding-Left="2" Padding-Right="1" Padding-Top="4" ThrobberID="myThrobber" maxFileSize=""
OnClientUploadComplete="onClientUploadComplete"
OnUploadComplete="AjaxFileUpload1_OnUploadComplete"
OnClientUploadCompleteAll="onClientUploadCompleteAll"
OnUploadCompleteAll="AjaxFileUpload1_UploadCompleteAll"
OnUploadStart="AjaxFileUpload1_UploadStart"
OnClientUploadStart="onClientUploadStart"
OnClientUploadError="onClientUploadError"
onchange="checkfilesize(); return false;" />
The error occurs during the page load and the VS debugger opens AjaxFileUpload.js, highlights Type.registerNamespace("Sys.Extended.UI.AjaxFileUpload");, and shows:
<EMAIL_ADDRESS>Here is the browser console you referred to…
<EMAIL_ADDRESS>Thanks again for your help.
Regards,
Richard
From: MikhailTymchukDX<EMAIL_ADDRESS>Sent: 04 May 2016 13:36
To: DevExpress/AjaxControlToolkit
Cc: Richard McNaught; Author
Subject: Re: [DevExpress/AjaxControlToolkit] Javascript error in AjaxFileUpload.js (#88)
This feature is implemented in PR #73https://github.com/DevExpress/AjaxControlToolkit/pull/73
You can download the entire repository or the latest version of the AjaxFileUpload.jshttps://github.com/DevExpress/AjaxControlToolkit/blob/master/AjaxControlToolkit/Scripts/AjaxFileUpload.js file.
As for the error you provided, would you please describe it in more detail:

What application do you run?
If possible, make a screenshot of the browser console with this error.
I am looking forward to your response.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com/DevExpress/AjaxControlToolkit/issues/88#issuecomment-216848288
Important Notice: The information in this email is confidential and may be legally privileged. If you have reason to believe you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it is prohibited and may be unlawful and you are requested to contact the sender urgently and dispose of this e-mail. We make every effort to keep our network free from viruses. You should, however, check this e-mail, and any attachments to it, for viruses, as we will not be liable for direct, special, indirect or consequential damages as a result of any virus being passed on, or arising from alteration of the contents of this message by a third party. Company registration details, including registered office information, for Expro's principal UK companies can be found via the following link: www.exprogroup.com/about-us/locations/#Europe_CIS

@R-McN  I cannot see the screenshots you attached.
Would you please re-attach them using the GitHub browser UI?

Is js/AjaxFileUpload.js a custom script file or a file from the AJAX Control Toolkit scripts?

It is one of the AjaxControlToolkit files that I got from the sample site (that was installed with the toolkit) and it is in a folder called ‘js’ off the root of my web site.
From: MikhailTymchukDX<EMAIL_ADDRESS>Sent: 05 May 2016 09:23
To: DevExpress/AjaxControlToolkit
Cc: Richard McNaught; Mention
Subject: Re: [DevExpress/AjaxControlToolkit] Javascript error in AjaxFileUpload.js (#88)
Is js/AjaxFileUpload.js a custom script file or a file from the AJAX Control Toolkit scripts?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/DevExpress/AjaxControlToolkit/issues/88#issuecomment-217101825
Important Notice: The information in this email is confidential and may be legally privileged. If you have reason to believe you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it is prohibited and may be unlawful and you are requested to contact the sender urgently and dispose of this e-mail. We make every effort to keep our network free from viruses. You should, however, check this e-mail, and any attachments to it, for viruses, as we will not be liable for direct, special, indirect or consequential damages as a result of any virus being passed on, or arising from alteration of the contents of this message by a third party. Company registration details, including registered office information, for Expro's principal UK companies can be found via the following link: www.exprogroup.com/about-us/locations/#Europe_CIS

Why do you place it there?
AjaxFileUpload will work without it by default, but if you need physical files to be downloaded, you have to install the AjaxControlToolkit.StaticResources NuGet package and disable bundling.

I added it because I thought that it was required for being able to validate files before they are uploaded to the server and then to remove them from the queue if they are invalid. Am I mistaken?
From: MikhailTymchukDX<EMAIL_ADDRESS>Sent: 05 May 2016 09:45
To: DevExpress/AjaxControlToolkit
Cc: Richard McNaught; Mention
Subject: Re: [DevExpress/AjaxControlToolkit] Javascript error in AjaxFileUpload.js (#88)
Why do you place it there?
AjaxFileUpload will work without it by default, but if you need physical files to be downloaded, you have to install the AjaxControlToolkit.StaticResourceshttps://www.nuget.org/packages/AjaxControlToolkit.StaticResources/ NuGet package and disable bundlinghttps://github.com/DevExpress/AjaxControlToolkit/wiki/How-to-use-bundling-and-CDN#to-disable-bundling.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/DevExpress/AjaxControlToolkit/issues/88#issuecomment-217104710
Important Notice: The information in this email is confidential and may be legally privileged. If you have reason to believe you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it is prohibited and may be unlawful and you are requested to contact the sender urgently and dispose of this e-mail. We make every effort to keep our network free from viruses. You should, however, check this e-mail, and any attachments to it, for viruses, as we will not be liable for direct, special, indirect or consequential damages as a result of any virus being passed on, or arising from alteration of the contents of this message by a third party. Company registration details, including registered office information, for Expro's principal UK companies can be found via the following link: www.exprogroup.com/about-us/locations/#Europe_CIS

AjaxFileUpload has no capability to validate files before uploading except for the file extension (as for the v16.1 release).
The code that performs that validation is the code you provided earlier and it has no relevance to the AJAX Control Toolkit code.
AjaxFileUpload.js file and all dependencies are loaded automatically in correct order by the toolkit, so you need no extra actions.
Trying to load it explicitly can cause errors, because it uses types defined in files that are not loaded yet.
You can inspect Network tab in a browser's developer tools to get familiar with scripts' load sequence.

OK, I’ll remove the js file. Thanks for your help Mikhail.
Best regards,
Richard
From: MikhailTymchukDX<EMAIL_ADDRESS>Sent: 05 May 2016 10:15
To: DevExpress/AjaxControlToolkit
Cc: Richard McNaught; Mention
Subject: Re: [DevExpress/AjaxControlToolkit] Javascript error in AjaxFileUpload.js (#88)
AjaxFileUpload has no capability to validate files before uploading except for the file extension (as for the v16.1 release).
The code that performs that validation is the code you provided earlier and it has no relevance to the AJAX Control Toolkit code.
AjaxFileUpload.js file and all dependencies are loaded automatically in correct order by the toolkit, so you need no extra actions.
Trying to load it explicitly can cause errors, because it uses types defined in files that are not loaded yet.
You can inspect Network tab in a browser's developer tools to get familiar with scripts' load sequence.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/DevExpress/AjaxControlToolkit/issues/88#issuecomment-217109366
Important Notice: The information in this email is confidential and may be legally privileged. If you have reason to believe you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it is prohibited and may be unlawful and you are requested to contact the sender urgently and dispose of this e-mail. We make every effort to keep our network free from viruses. You should, however, check this e-mail, and any attachments to it, for viruses, as we will not be liable for direct, special, indirect or consequential damages as a result of any virus being passed on, or arising from alteration of the contents of this message by a third party. Company registration details, including registered office information, for Expro's principal UK companies can be found via the following link: www.exprogroup.com/about-us/locations/#Europe_CIS


No line breaks on long underlined links

When using the command \underlinedLink, \uline does not cause a line break when the text is very large.
Before:

Moving the \uline inside the second parameter of \href solves the issue.
After the fix:

The fix has been merged in this pull request.


Please add me to Hyperledger Labs github org

Hi I joined IOHK (Atala-Prism) a couple of weeks ago as a QA Engineer.

GitHub ID to add: todorkoleviohk
Lab to be added to: Open Enterprise Agent
Role: Write

invite sent!

@antonbaliasnikov once @todorkoleviohk accepts the invite you have the power to add him to the correct teams


version: add separate UserAgent variable for default User-Agent

version: add separate UserAgent variable for default User-Agent
The default User-Agent as used by containerd to perform requests to
registries is using a hard-coded containerd/ prefix; this can be
problematic in situations where containerd is used as a module.
In cases where the consuming code does not explicitly set a User-Agent header
(therefore falling back to the default), it may either identify itself as
containerd or, when overriding the Version variable at linking time, as
containerd/<unrelated version>.
This patch introduces a separate UserAgent variable to allow setting the
user-agent separate from other variables that can be set at linking time.
It currently defaults to the existing default (using containerd as prefix
(product name)), but this could be changed to distinguish containerd builds
from products using containerd as a module.
The variable is added to the version package, as this is where other
compile / linking-time variables reside, but given it's a default value,
could be considered for inclusion in teh defaults package instead.
Makefile: add CONTAINERD_USER_AGENT var for overriding default user-agent
With this patch, the default user-agent can be overridden when compiling;
# setting the make variable
make CONTAINERD_USER_AGENT="my-product/1.2.3 os/linux arch/arm64" binaries

# through an environment variable
CONTAINERD_USER_AGENT="my-product/1.2.3 os/linux arch/arm64" make binaries

The CONTAINERD_ prefix is used to reduce risk of collisions when setting
through an environment-variable.

I should add some context to this PR; this PR came following an internal discussion with the Docker Hub team (and others);
The Docker Hub team is investigating some improvements to be made, as well as sunsetting some backward-compatibility code (e.g. the "v1 conversion code"). As part of that work, they were looking at active uses of old versions of Docker, containerd, and other tools, and while looking at access logs, found various instances of user-agents having a non-existing containerd versions.
While this PR may not (yet) fix that problem, I opened this PR for the first steps toward that, and want to discuss;

changing the default to prevent tools using containerd as a module identifying as containerd (e.g. default to containerd-client or something else (TBD - open for input)).
expanding the default user-agent to include OS, Architecture and Variant

For the latter one; the team wants to have a more informed perspective on native architectures in use (which may include "variants" now becoming more widely used in x86 situations); while we have insight in what architectures are pulled, some of that information can be skewed due to things like QEMU userland emulation. Adding the native OS and Architecture can help here; for example, to provide images optimized for newer variants/sub-architectures.
I'll open a follow-up PR for those changes for further discussion.
cc @chris-crone @tianon @dmcgowan (FYI)
I think @samuelkarp also showed interest in more insight in the past, but maybe that was before changing companies, so let me add @estesp and @austinvazquez here as well 😄


Lock Fn

Description of the new feature / enhancement
Create a parameter that would give us the possibility to lock the Fn key.
Scenario when this would be used?
Sorry I'm french but I'm going to try :
This will make it possible to have the keys from F1 to F12 and the shortcuts accessible by simultaneously pressing Fn and the corresponding key. and in the other case the shortcuts accessible directly from the f1 - f12 keys. Also the ability to customize actions would be great!
Supporting information
No response

we directly call out Fn as a key we cannot remap.  with the APIs we use, the Fn key is not visible.


Signing is only enforced in Firefox above version 41 (bug 1193256)

Fixes bug 1193256

I'd go with "Firefox 41 and higher"


bower.json not well formed

Line 19 of the bower.json file has a trailing comma, which I believe is causing problems when trying to retrieve the framework using bower.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/34206622-bower-json-not-well-formed?utm_campaign=plugin&utm_content=tracker%2F18331363&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F18331363&utm_medium=issues&utm_source=github).

Thanks @tm8747a, it has been fixed.


Implement CI with Travis/SauceLabs - linting + unit/e2e

Implemented testing in CI
Added small Express server for tests, instead of BrowserSync, to prevent popping (and not closing) extra browser window
Removed "pretest" and "preprotractor", to prevent rebuilding native node addons in deps every test run
Added "webdriver-update" to npm "post-install" hook
Fixed unit test task to correctly signal it's async
Return merged streams in view task, so gulp knows to wait until both are completed

Here is this PR passing in CI

Configuring for this repository
SauceLabs

[Signup for an "Open Sauce" account with SauceLabs[(https://saucelabs.com/opensauce/)
Login to your new account, and navigate to the "My Account" section
Click "Show" under the "Access Key" header, and hold on to the value

Travis

Login to Travis with your GitHub account
Enable this repository
Click "Settings > Settings"
Under "Environment Variables", add two, with the appropriate values

SAUCE_USERNAME
SAUCE_ACCESS_KEY

If you checkout this branch now and push it to this projects github remote, Travis should pick it up and build it.

Have some merge conflicts in here - will get them updated in the next day

I've created the SauceLabs and Travis accounts, as well as added the keys. Should be ready to go once the merge conflicts are resolved!

+1

Pinging for attention :smile:

Done in #132 since this branch wasn't getting updated


got a problem when I ran the preprocess.sh

got a problem when i ran the preprocess.sh
here is what's causing my program to go wrong in the preprocess.sh
--------python scripts/save_embed.py --fseqdir $fseq
--modeldir /home/lsy/code/sixt/fairseq/models/xlmr_base --src $src --tgt $tgt
--outfile $fseq/xlmr_${tgt}_emb.pt
and this is the problem
now start to extract target embeddings ...
Traceback (most recent call last):
File "scripts/save_embed.py", line 59, in
main()
File "scripts/save_embed.py", line 44, in main
XLMR = XLMRModel.from_pretrained(args.modeldir, checkpoint_file='model.pt')
File "/home/lsy/code/sixtp/fairseq/models/roberta/model_xlmr.py", line 43, in from_pretrained
return RobertaHubInterface(x["args"], x["task"], x["models"][0])
File "/home/lsy/code/sixtp/fairseq/models/roberta/hub_interface.py", line 29, in init
self.bpe = encoders.build_bpe(bpe_set)
File "/home/lsy/code/sixtp/fairseq/registry.py", line 61, in build_x
return builder(cfg, *extra_args, **extra_kwargs)
File "/home/lsy/code/sixtp/fairseq/data/encoders/sentencepiece_bpe.py", line 23, in init
sentencepiece_model = file_utils.cached_path(cfg.sentencepiece_model)
File "/home/lsy/code/sixtp/fairseq/file_utils.py", line 166, in cached_path
raise EnvironmentError("file {} not found".format(url_or_filename))
OSError: file /path/to/your/work/location/models/xlmrL_base/sentencepiece.bpe.model not found
idk why i've changed the content of workloc, but it did't work.

You can use pdb package to see what's going on. Maybe there are other paths to be configured in the code.


set user-defined kubelet dir to  handler with operator

What this PR does / why we need it:
The purpose of the PR is on operator working with user-defined kubelet data dir - to set correct kubelet data dir for virt components and vms if kubelet-pods-dir or kubelet-root is user-defined.
The path under proc/1/root should be the actual path of kubelet on device.If the kubelet data dir is user-defined,the path under proc/1/root which be used should also be set.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8998
Release note:
The parameters kubelet-pods-dir and kubelet-root have different priorities. If both are set, kubelet-pods-dir has a higher priority.

/test all

/remove-lifecycle rotten
@qiutingjun Did you want to rebase this PR and see if we can try to get it reviewed?


Modifying Gentoo pkgconfig package. @SvenWe.

+1

@allenh1, thank you for writing this, but I guess there has been a minor confusion: The virtual package is called "virtual/pkgconfig", not "virtual/pkgconf".


[Feat]: Google Authorization using Firebase

Feature Description
Google Sign In using Firebase
Provide a detailed description of the feature
I would like to request the addition of Google Authorization using Firebase in our project. This feature would allow users to authenticate using their Google accounts, streamlining the sign-in process and enhancing user experience. Firebase provides a robust authentication solution that can simplify the integration of Google Sign-In, making it easier for users to access the application without having to create a new account or remember another password.
Put here any screenshots or videos (optional)

By submitting this issue, you agree to

[X] I agree to follow this project's Code of Conduct
[X] I’ve read all the issues in the issue section, and this feature has not been proposed yet.

Other Information

[X] I'm a GSSoC '24 Extended contributor
[X] I'm a Hacktoberfest '24 contributor
[X] I am willing to work on this feature (optional)

@maniyaom Could you please assign this issue to me under gssoc-ext and hacktoberfest

@samriddhitiwary Google authentication for sign-up has already been implemented. You can focus on adding the sign-in with Google functionality.

@samriddhitiwary also avoid making any changes to pages that haven't been assigned to you.

@maniyaom Sure, can please attach the level also

@samriddhitiwary I'll be adding the level based on your code.

@maniyaom  Ok


Use zig for building acton? and bundle zig with actonc? :S

I've been following zig for a while. It's a new language that attempts to be a better C. Some say C++, D, Rust also attempt to be better C, but that's not really true. C is small. C++ is massive with all sorts of bells and whistles. Rust is probably a better C++, or attempts to be, rather than a better C. Zig is a better C. It is compatible with C in so many interesting ways, it's compiler even compiles C without any form of wrapping or anything and does so better in many ways than gcc or clang. For example, it's up-to-date check is amazing with checksumming and automatically checking included files and building a dependency tree so we don't need make targets that declare those. cross-compilation is a top priority, so we could likely use this to test aarch64 calling conventions in a very simple way.
We could use it to compile acton itself, but there's also the possibility of bundling zig with acton, so that when you install acton, it has no dependencies at all and we would get completely known results since we know what version of zig we'd bundle. Today things can start failing all of a sudden because a user has a different version of cc than we have tested with.
Something to ponder...

I'm splitting this issue in two:

using zig to build acton itself, this issue
bundling zig with acton to be used as cc from actonc #972

Turns out it was easier to bundle the two tasks in the end... so yeah, this is done with #986. Closing.


Update to AS 2.2.1 & Gradle 3.1. Got rid of apt

update to Gradle Android Tools 2.2.1
update to gradle 3.1 (better performance yeah)
get rid of apt (2.2.0 can do this now)

Also needed to update the dexcount plugin since the version used is not compatible with Gradle 3.x the newer ones are though.

I think travis timed out. Can you restart it?

Current coverage is 77.73% (diff: 100%)

No coverage report found for master at 1af1cbf.

Powered by Codecov. Last update 1af1cbf...c6624c0

Oh nice you already did thanks :)

Thanks!

btw you don't need custom lombok with gradle 2.2: https://twitter.com/jakewharton/status/777954097148358656

@thevery My lint still fails without custom lombok using Android Gradle Plugin 2.2.0.

Same here


default of auth().id to createdBy in createManyAndReturn API doesn't work

I'm trying to use createManyAndReturn API on polymorphic model, the base of the model (not the polymorphic part) has createdBy field, but when I'm trying to use it, I get the following error:
'Argument createdBy is missing.'
createdById Int @default(auth().id)
createdBy User @relation('ShelfCreatedBy', fields: [createdById], references: [id])

zenstack: 2.4.1
prisma: 5.18.0

Fixed in 2.6.0


You are unable to broadcast unless you update to the latest version of Instagram.

POST /api/v1/live/create/ - 400 Bad Request; You are unable to broadcast unless you update to the latest version of Instagram.
Hey @Nerixyz (dilame or whosoever it may concern), I don't know why you deleted my previous bug report, its fine if you don't want to help out people using this library anymore for whatever reason but at least, please do not delete it. Maybe someone else from the community can help us. Because this is the first place to look out for any problems we are facing while using this instagram api.
I hope you understand our concern and this time you will not delete it.
AND last but not least thanks a lot for this awesome repo. This work of yours is a life savior for many of us.

any news?

any update about this bug? I am facing the same issue.

Just update api version to 261 or something newer , it will for you:
{
    AppApiVersionCode = "418951243",
    AppVersion = "2<IP_ADDRESS>.111",
    Capabilities = "3brTv10=",
    SignatureKey = "SIGNATURE",
    BloksVersionId = "a399f367a2e4aa3e40cdb4aab6535045b23db15f3dea789880aa0970463de062"
}

P.S: update other parts as well, note that in v272 they use bloks api for login/logout endpoint.

Just update api version to 261 or something newer , it will for you:
{
    AppApiVersionCode = "418951243",
    AppVersion = "2<IP_ADDRESS>.111",
    Capabilities = "3brTv10=",
    SignatureKey = "SIGNATURE",
    BloksVersionId = "a399f367a2e4aa3e40cdb4aab6535045b23db15f3dea789880aa0970463de062"
}

P.S: update other parts as well, note that in v272 they use bloks api for login/logout endpoint.

I tested it. this change works. Thank you ramtinak.

Just update api version to 261 or something newer , it will for you:
{
    AppApiVersionCode = "418951243",
    AppVersion = "2<IP_ADDRESS>.111",
    Capabilities = "3brTv10=",
    SignatureKey = "SIGNATURE",
    BloksVersionId = "a399f367a2e4aa3e40cdb4aab6535045b23db15f3dea789880aa0970463de062"
}

P.S: update other parts as well, note that in v272 they use bloks api for login/logout endpoint.

I tested it. this change works. Thank you ramtinak.

Hi, Can you explain how to extract these informations? Im using ItsAGramLive in pyhon and abose codes dont work here.

Hi @amir4833
Please help me, I used instagram python private api to generate rtmp stream key but now I am facing same issue, I used above app version but I am not able to fix my issue, Could you please give me the device information as well for instagram updated app version.
DEVICE_SETS =   {
"app_version": "2<IP_ADDRESS>.111",
"android_version": "28",
"android_release": "9.0",
"dpi": "640dpi",
"resolution": "1440x2560",
"manufacturer": "samsung",
"device": "SM-G965F",
"model": "star2qltecs",
"cpu": "samsungexynos9810",
"version_code": "418951243",
}
API_URL = 'https://i.instagram.com/api/v1/'

USER_AGENT = 'Instagram {app_version} Android ({android_version}/{android_release}; {dpi}; {resolution}; ' \
             '{manufacturer}; {model}; armani; {cpu}; en_US)'.format(**DEVICE_SETS)
IG_SIG_KEY = '807e40a665202db7b3af81fa188cb0f43c7016c876c5919a9367ab5a173300d7'
SIG_KEY_VERSION = '4'

Hello friends, any news?

Just update api version to 261 or something newer , it will for you:
{
    AppApiVersionCode = "418951243",
    AppVersion = "2<IP_ADDRESS>.111",
    Capabilities = "3brTv10=",
    SignatureKey = "SIGNATURE",
    BloksVersionId = "a399f367a2e4aa3e40cdb4aab6535045b23db15f3dea789880aa0970463de062"
}

P.S: update other parts as well, note that in v272 they use bloks api for login/logout endpoint.

How i can get the SignatureKey ?

Just update api version to 261 or something newer , it will for you:
{
    AppApiVersionCode = "418951243",
    AppVersion = "2<IP_ADDRESS>.111",
    Capabilities = "3brTv10=",
    SignatureKey = "SIGNATURE",
    BloksVersionId = "a399f367a2e4aa3e40cdb4aab6535045b23db15f3dea789880aa0970463de062"
}

P.S: update other parts as well, note that in v272 they use bloks api for login/logout endpoint.

How can i can get the SignatureKey ??

Hello, anyone with the difficulty? can you help me ?

@wwwwelton @krishnPratapSingh can you help me ? I still face problems


Rebuild for additional architectures

MNT: Re-rendered with conda-build 3.21.8, conda-smithy 3.19.0, and conda-forge-pinning 2<IP_ADDRESS>.41.03

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


iox-#415 Replace IPC-channel-based findService() with pub/sub-based one

Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-#123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit messages are signed (git commit -s)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] Assign PR to reviewer

Notes for Reviewer

Remove all IPC-chanel-based findService() and changeRegistryCounter methods
Send a copy of serviceRegistry via a new pub/sub pair
Make ServiceDiscovery attachable to WaitSet
Add notification-based unit test cases for ServiceDiscovery

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior

[ ] Each unit test case has a unique UUID

[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes #415 (partly)

Please try to squash/pack one liner commits together before opening a PR. But not in this PR anymore (otherwise we screw up the already reviewed file list for the reviewers).


Integrations - header token - API Key

Add support for HTTP header token on outgoing HTTP requests.
The configuration for this authentication mechanism should be:
{
  "request": {
    "uri": "https://jsonplaceholder.typicode.com/posts/$.body.id",
    "method": "get",
    "authentication" : {
      "mechanism" : "token",
      "type" : "header",
      "config" : {
        "token" : "$.secret.name",
        "header" : "x-api-key"
      }
    }
  }
}

The token field within the configuration should support the use of secrets.
When this authentication mechanism is present the requestService within the integration application should add a header to the outgoing request with a value of the token provided within the config:
x-api-key: <token>

Done and pushed into latest.


[azeventhubs] Update to latest azblob SDK

azblobs is approaching GA and we can now remove our vendored copy of azblobs and use the proper package. Our code footprint will get smaller and it'll also solve #19842, where we weren't exporting all the possible authentication for blobs.
Fixes #19842 #19883

/azp run go - azeventhubs

NOTE: this uses the pre-release commit for azblobs so we can get close to what we need. We'll want to wait to merge this and release until after the GA release for azblobs goes out.

/azp run go - azeventhubs

/azp run go - azeventhubs

Interesting test failure - it's in an area completely untouched by my change. Going to retry.

/azp run go - azeventhubs

/azp run go - azeventhubs


Regarding prompt selection frequency

Hi @jamessealesmith , thanks for your amazing work!
I was wondering if you checked the prompt selection frequency in CODA prompt and L2P?
Any idea if your reproduction of L2P has the issue reported here and here about the same set of prompts being selected everytime?

Update - I realised CODA prompt doesn't use prompt selection and there is an attention weighting over the prompt components, hence this question would be invalid for CODA prompt.


[release-1.3] fix: update janus-idp/cli in wrappers to 1.13.3

Description
Update janus-idp/cli in wrappers to the 1.13.3 that include fix for  https://issues.redhat.com/browse/RHIDP-3574
Which issue(s) does this PR fix

Fixes https://issues.redhat.com/browse/RHIDP-3574

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

/retest

/retest

/retest

/retest

/retest

/retest


⚠ ClamAV has degraded performance

In 61cd8e2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 211 ms

Resolved: ClamAV performance has improved in 9cbb424.


support unions

Onions have a natural representation as enums, with one field per variant. This makes the translation a little more complicated (rustc represents them like structs) and of course we also need to have non-optional checks on field access.
I changed the Verus is_variant builtin to support onions, and made get_union_field to be an analogue of get_variant_field.
Not supported in this PR:

Onion patterns, assignment to onion fields, or &mut references to onion fields
#[is_variant] attribute (synstructure library does not support onions, so we basically have to re-do the is_variant implementation entirely)
Using onions with external_type_specification


Remove all declarations that start with underscore

There are many private ugly APIs that only clutter the debugger and global object. We should remove them from the metadata.
The JSC C API hides them too.

For now, we are not going to remove the APIs, starting with underscore. Aftrer introducing Module Proxies (https://github.com/NativeScript/ios-runtime/issues/95) the global object will not be polluted with "ugly" APIs. The issue is open-ended and if there are problems with these APIs in the future we can reconsider it.


Fix for issue #23884 (Documentation clarification)

Fixed issue  #23884, Simple documentation clarification already outlined in the github issue
Signed-off-by: Justyn Temme<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:justyntemme/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@thaJeztah I have researched and couldn't find anything related to a wrapper for service. My thoughts on the issue -
This is a guide and not hard coded, anyone reading this who is still on a sysvinit machine probably knows they are on a sysvinit machine. While we could just write both commands in, systemd has replaced sysvinit in modern debian, and we should update the guides to echo the current way to do things.
If there are other opinions would love to hear,

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:justyntemme/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~8
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Reverted and ready to go. Service.. is now being used. p80.... has been reverted as well. The commit still has one suggestion from the issue ticket.

LGTM, thanks! :+1:

awesome, thanks!
LGTM


some code format optimize

Make sure set the target branch to develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #4364 (c382a75) into develop (316d32a) will decrease coverage by 0.02%.
The diff coverage is 21.42%.

@@              Coverage Diff              @@
##             develop    #4364      +/-   ##
=============================================
- Coverage      48.18%   48.15%   -0.03%
+ Complexity      5087     5082       -5
=============================================
  Files            642      642
  Lines          42782    42779       -3
  Branches        5598     5597       -1
=============================================
- Hits           20613    20601      -12
- Misses         19660    19670      +10
+ Partials        2509     2508       -1

Impacted Files
Coverage Δ

...ava/org/apache/rocketmq/store/ConsumeQueueExt.java
65.48% <0.00%> (ø)

...rg/apache/rocketmq/store/DefaultMessageFilter.java
0.00% <ø> (ø)

...org/apache/rocketmq/store/DefaultMessageStore.java
55.56% <ø> (ø)

...ava/org/apache/rocketmq/store/MappedFileQueue.java
62.85% <0.00%> (ø)

...ava/org/apache/rocketmq/store/StoreCheckpoint.java
90.19% <0.00%> (ø)

...ava/org/apache/rocketmq/store/ha/HAConnection.java
66.97% <0.00%> (ø)

...n/java/org/apache/rocketmq/store/ha/HAService.java
71.76% <ø> (+0.99%)
:arrow_up:

...main/java/org/apache/rocketmq/store/CommitLog.java
75.05% <100.00%> (-0.03%)
:arrow_down:

...n/java/org/apache/rocketmq/store/ConsumeQueue.java
64.55% <100.00%> (ø)

...a/org/apache/rocketmq/store/ReferenceResource.java
79.31% <100.00%> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316d32a...c382a75. Read the comment docs.

Coverage decreased (-0.06%) to 52.273% when pulling c382a756340a0ce373768c095347afef54fa23da on mroccyen:some-optimize into de5e6d9e06732e88df03b4df5759aa87ea017ac3 on apache:develop.


Are multiple untappd users/sensors possible?

Just wondering if anyone has had any luck creating two untappd user sensors
I wanted to display the checkin/badge data of both me and my other half on a single page.
I only get the sensors created for the first user:
Untappd API Sensors

platform: untappd
name: untappd_user1
username: !secret untappd_username1
id: !secret untappd_id
secret: !secret untappd_secret

platform: untappd
name: untappd_user2
username: untappd_username2
id: !secret untappd_id
secret: !secret untappd_secret

The sensor name is not dynamic

Love your work - thank you very much! 🍻


Adding my repository 1

Information

Issue: https://github.com/bacloud14/Classified-ads-48/issues/8

Repository: https://github.com/bacloud14/Classified-ads-48

Tech stack: JavaScript, NodeJs, MongoDB, Leaflet.

[x] is it a beginner-friendly issue?

Note: I would like to add the whole repository.

Looks good to me.
Can you create a PR with your issue?

I did


Hide the AWS user secret input

This is essentially a password and should not unexpectedly show on the user's screen.

Thanks!


Makefile: allow restricting test packages

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 9 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 6.427%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/makefile/makefile.go
0
9
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
34

Relevant Lines:
529

💛  - Coveralls

What is the purpose of this? If we put test files in a package, I don't see why we would not want to run the tests. go test already auto-skips packages without test files.

We might want to skip a package that has test files for various reasons; our immediate use case is that we don't want to test packages under acceptance directory in gophercloud-sapcc because these packages require OpenStack as their more of a e2e tests rather than unit tests. The tests in other packages are unit tests.
The problem occurs when we run this in CI, e.g. in our GitHub workflow's test job, we get a non-zero exit code since the acceptance/... tests failed.


AttributeError: partially initialized module 'torch' has no attribute 'Tensor' (most likely due to a circular import)

I tried running the test command and got this error. I wouldn't be surprised if I screwed something up. I uninstalled and reinstalled torch and tensor to no avail.
  Jesus Christ dude, what fixed it

Ill have to double check. Part of my problem was having conda and python installed and my prompt was confused which was which. I then made sure the installs for tensor and torch were complete

And to be fair i never got it to fully work. I dont have enough vram to run this apparently


feat(cdk/drag-drop): add support for nested containers with cdkDropListGroup (#16671)

Allow for cdkDropListGroup to work on nested drop lists

There are some tests that are failing because im no longer clearing down the provider for cdkDropListGroup, but I don't see the use-case for that

i could also make another directive that group nested lists so that way it's not a breaking change


Fix task threads closed on step up

When running a custom load test shape, there would a be drop in the RPS whenever there was a change in the number of users.
Locust version: 2.0.0b3
Locust4j version: master
Steps to reproduce

Run a test with a custom load shape. E.g.

class StepLoadShape(LoadTestShape):
    step_time = 30
    step_load = 10
    spawn_rate = 2

    def tick(self):
        run_time = self.get_run_time()
        current_step = math.floor(run_time / self.step_time) + 1

        if current_step > 7:
            return None

        if current_step > 3:
            current_step = 8 - current_step

        return (current_step * self.step_load, self.spawn_rate)

Expected:

Actual:

I noticed that all threads were being terminated and recreated on each spawn message, and that the stast were being reset. This PR:

Stores a reference to the futures returned by ThreadPoolExecutor.submit()
On spawn messages, instead of stopping the treads, adds or removes individual threads by first adjusting the pool size and then cancelling/creating tasks.
Removes the call to reset stats.

The expected image above was taken with this patch applied.

@stephen-harris It's a great idea! I will merge this ASAP after reviewing. Can you add some unittests for this?

@myzhan I've added a couple of tests. The scale-out verifies that only new tasks are submitted (i.e. the existing ones are kept). The scale-in checks the appropriate tasks are removed, and no new tasks are created.
I had to expose setTaskExecutor as a protected method to inject the spy, but that seems reasonable.
I also added LocustTestHelper class so I could set the runner of the Locust singleton. This is necessary as otherwise the TestTask exceptions, and has to be re-submitted. It's a bit of hack - the other option was make Locust.setRunner public. That seemed worse as Locust.setRunner  exists only for tests.
I didn't do any assertions on the futures map because that's more of an implementation detail, and would have involved exposing more of Runner's internals.

FYI, I have comfirmed that locust removes the call to reset stats, we should remove it as well.

So when I first encountered the issue I had assumed that it was the stopping and recreating the threads that was causing it. Fixing that did improve it, but it wasn't until I removed the call to reset stats that the issue went away completely.
I've since tested this with just removing this line - i.e. the threads are all stopped and restarted on spawn message, and that appears to be sufficient to fix the issue.
So unless there is any particular reason to try and keep threads, the smaller and simpler fix here might be just to remove the call to reset stats.  What do you think?

I think we should keep threads, avoid lots of creation. If we are ok with this PR, I will merge it.

I've just tested with two tasks and a 1:3 weights and it correctly scaled up each task.

User (per worker)
Task (3) threads
Task (1) threads

5
4
1

10
8
3

15
11
4

20
15
5

Obviously due to rounding the ratio of users doesn't work out exactly 1:3, but that's unrelated to this issue. So I'm happy for this PR to be merged.

Thanks again! I have merged into master branch and a minor version will be published soon.

FYI, 2.0.1 has been released.


How to get the same width for kerning font as like GDI+ via SkiaSharp?

We have requirement to measure a string with required font by using SkiaSharp.
Here, when we try to measure the Kerning applied text "Test document for DOCX to PDF conversion" with "Calibri Light" font.
Attached the measuring code example (UsingGDI.zip) of using the System.Drawing.Graphics.MeasureString(), it return the exact width of the text as "482.918" point as expected.
But, we are willing to use SkiaSharp library since it supported in multiple platforms. When we measure the same text using SkiaSharp (UsingSkiaSharp.zip) return the "488.5918" point.
Could you please suggest us a solution to get the same width as in Graphics.MeasureString() via SkiaSharp.

Having the same problem. GDI+ is still performing better than Skia in most cases for us.


OCI Distribution Conformance Testing

The OCI Distribution spec has a conformance test that you can run to see if a registry meets the OCI spec.
I ran this for archeio and we are doing great with blobs but not so well with the manifests.
https://github.com/opencontainers/distribution-spec/tree/main/conformance
Set the following variables:
export OCI_NAMESPACE=kubernetes/pause
export OCI_TAG_NAME=3.7
export OCI_TEST_PULL=1
export OCI_ROOT_URL=https://registry.k8s.io
export OCI_TEST_PUSH=0
export OCI_MANIFEST_DIGEST=sha256:f81611a21cf91214c1ea751c5b525931a0e2ebabe62b3937b6158039ff6f922d
export OCI_BLOB_DIGEST=sha256:221177c6082a88ea4f6240ab2450d540955ac6f4d5454f0e15751b653ebda165

We need to change a few things to make it comply with the spec.
Report link: https://htmlpreview.github.io/?https://github.com/upodroid/oci-proxy/blob/compliance-fixes/oci-compliance.html
/sig k8s-infra
/priority important-soon
/kind feature

We don't support push and have no intention to, the others I don't have too much concern about, the failed responses are from AR not registry.k8s.io.

It is worth noting that the README currently states OCI compliance, which may be misleading and also unnecessary.
Per:
https://github.com/opencontainers/distribution-spec/tree/main/conformance#testing-registry-workflows
We would need to fix the pull tests, but only the pull tests.
But again, most of these responses appear to be from AR, not archeio so ....
Unlike Kubernetes conformance, I don't think there's a program to vet implementations and list vendors. It's unclear that these test results should be a priority vs working pull and tag list (which work fine).

I did some digging around since I opened the issue:

the conformance test runs with the v1 api which is deprecated.(There isn't a flag for v2 only tests)
AR doesn't support the v1 API.
AR is returning incorrect values. Blaming Google.

https://cloud.google.com/artifact-registry/docs/supported-formats
TL;DR, we meet the spec and everything is mostly good. Can't really do anything about the cloud vendor's implementation.
I don't mind putting this in a small markdown in the repo and closing out the issue.

the conformance test runs with the v1 api which is deprecated.(There isn't a flag for v2 only tests)
AR doesn't support the v1 API.

Ah, yeah that will do it. We also dropped v1 from archeio for similar reasons, I don't think any clients are still on v1.
We should say that we are OCI v2 compliant, which is also noteworthy if a v3 is released and we're not prepared yet...
For error codes, I think it's split between archeio and AR, but responses with different 4XX codes don't seem like a big deal, lots of registries are doing things like forwarding blobs to blob storage backends with their own error codes.

Our current failures for pull-only testing (not push, delete, discovery) are the same as the AR backing registry.
They also seem like flaws in the tests, such as expecting 200 OK for some API calls even when pretty much all major registries return 3XX ...
I think we're doing a solid job implementing the intention of the API spec and we should continue to test with real API clients instead for now.


Ban emoji in public channel creates ban-request

Having a reaction that when adding it to a message, it will automatically create a ban request in #ban-request-queue on behalf of the Moderator.

Problems:
-the ban request will be limited to only that specific message. There is no context and this would only make sense for bans such as racial slur bypassing
-The moderator will skip the process of going through their message history, will not search for the users previous infraction and will dive right into the ban.


Fix dashboard with no primary body

Fixes HELP-959 and probably a few others

@LeonVreling dashboard didn't work for those without primary body, I've fixed it :D

:tada: This PR is included in version 0.36.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Invalid Memory Address with AD LDAP via TLS

I've configured LDAP for TLS connecting to an AD server, but I get the following error whenever a user attempts to login.
runtime error: invalid memory address or nil pointer dereference
goroutine 12 [running]:
net/http.(*conn).serve.func1(0xc82017fce0, 0x7f2f7223a268, 0xc82008c840)
/usr/local/go/src/net/http/server.go:1287 +0xb5
github.com/go-ldap/ldap.(*Conn).StartTLS(0xc82027c900, 0xc8201c1680, 0x0, 0x0)
/home/rojer/go/src/github.com/go-ldap/ldap/conn.go:180 +0x125c
github.com/cesanta/docker_auth/auth_server/authn.(*LDAPAuth).ldapConnection(0xc8200240b0, 0xc8201fe540, 0x0, 0x0)
/home/rojer/go/src/github.com/cesanta/docker_auth/auth_server/authn/ldap_auth.go:133 +0x33d
github.com/cesanta/docker_auth/auth_server/authn.(*LDAPAuth).Authenticate(0xc8200240b0, 0xc8202748d2, 0xd, 0xc82027e32e, 0x9, 0x0, 0x0, 0x0)
/home/rojer/go/src/github.com/cesanta/docker_auth/auth_server/authn/ldap_auth.go:56 +0x8c
github.com/cesanta/docker_auth/auth_server/server.(*AuthServer).Authenticate(0xc820126680, 0xc82025ed80, 0x11, 0x0, 0x0)
/home/rojer/go/src/github.com/cesanta/docker_auth/auth_server/server/server.go:109 +0x11e
github.com/cesanta/docker_auth/auth_server/server.(*AuthServer).doAuth(0xc820126680, 0x7f2f7223e8e8, 0xc8202820b0, 0xc820233960)
/home/rojer/go/src/github.com/cesanta/docker_auth/auth_server/server/server.go:229 +0x3d1
github.com/cesanta/docker_auth/auth_server/server.(*AuthServer).ServeHTTP(0xc820126680, 0x7f2f7223e8e8, 0xc8202820b0, 0xc820233960)
/home/rojer/go/src/github.com/cesanta/docker_auth/auth_server/server/server.go:201 +0x1ef
net/http.serverHandler.ServeHTTP(0xc8201a05a0, 0x7f2f7223e8e8, 0xc8202820b0, 0xc820233960)
/usr/local/go/src/net/http/server.go:1862 +0x19e
net/http.(*conn).serve(0xc82017fce0)
/usr/local/go/src/net/http/server.go:1361 +0xbee
created by net/http.(*Server).Serve
/usr/local/go/src/net/http/server.go:1910 +0x3f6

i have no way to test it, unfortunately, we don't use LDAP, let alone with AD.
let's ask @summerQLin who wrote the LDAP plugin. any ideas?

@kidhasmoxy could you please paste your ldap_auth.yml configuration here?

I can paste a redacted version, to start. Although, now that I look at this closer, I realize that we should be searching for sAMAccountName for AD. I'll try that to see if it helps.
ldap_auth:
addr: "my.public.domain:636"
tls: true
In case bind DN and password is required for querying user information,
specify them here. Plain text password is read from the file.
bind_dn: "CN=svc_ldap,OU=Service Accounts,OU=Managed Objects,DC=example,DC=DC=com"
bind_password_file: "/config/ldap_pw"
User query settings. ${account} is expanded from auth request
base: "DC=example,DC=com"
filter: "(&(uid=${account})(objectClass=person))"

Still no go, as the error is happening at the StartTLS phase. I validated the connection information to LDAP with OpenLDAP client, so the content is correct. Is there an option of using DialTLS for testing? I haven't been able to put together an environment to recompile, or I would try it myself.
I1027 22:16:53.307686       1 ldap_auth.go:126] Dial: starting...redacted.example.com:636
dockerauth_1 | I1027 22:16:53.511054       1 ldap_auth.go:132] StartTLS...
dockerauth_1 | I1027 22:17:03.603112       1 server.go:1934] http: panic serving redacted_ip:65026: runtime error: invalid memory address or nil pointer dereference
dockerauth_1 | goroutine 14 [running]:
dockerauth_1 | net/http.(*conn).serve.func1(0xc8203adc30, 0x7f9ba2166018, 0xc820095600)
dockerauth_1 | 	/usr/local/go/src/net/http/server.go:1287 +0xb5
dockerauth_1 | github.com/go-ldap/ldap.(*Conn).StartTLS(0xc82045b100, 0xc820470780, 0x0, 0x0)
dockerauth_1 | 	/home/rojer/go/src/github.com/go-ldap/ldap/conn.go:180 +0x125c
dockerauth_1 | github.com/cesanta/docker_auth/auth_server/authn.(*LDAPAuth).ldapConnection(0xc8200240b0, 0x9, 0x0, 0x0)
dockerauth_1 | 	/home/rojer/go/src/github.com/cesanta/docker_auth/auth_server/authn/ldap_auth.go:133 +0x33d
dockerauth_1 | github.com/cesanta/docker_auth/auth_server/authn.(*LDAPAuth).Authenticate(0xc8200240b0, 0xc82046cc12, 0xd, 0xc82046bd8e, 0x9, 0x0, 0x0, 0x0)
dockerauth_1 | 	/home/rojer/go/src/github.com/cesanta/docker_auth/auth_server/authn/ldap_auth.go:56 +0x8c
dockerauth_1 | github.com/cesanta/docker_auth/auth_server/server.(*AuthServer).Authenticate(0xc820126740, 0xc8204567e0, 0x11, 0x0, 0x0)
dockerauth_1 | 	/home/rojer/go/src/github.com/cesanta/docker_auth/auth_server/server/server.go:109 +0x11e
dockerauth_1 | github.com/cesanta/docker_auth/auth_server/server.(*AuthServer).doAuth(0xc820126740, 0x7f9ba216a880, 0xc820444dc0, 0xc820428a80)
dockerauth_1 | 	/home/rojer/go/src/github.com/cesanta/docker_auth/auth_server/server/server.go:229 +0x3d1
dockerauth_1 | github.com/cesanta/docker_auth/auth_server/server.(*AuthServer).ServeHTTP(0xc820126740, 0x7f9ba216a880, 0xc820444dc0, 0xc820428a80)
dockerauth_1 | 	/home/rojer/go/src/github.com/cesanta/docker_auth/auth_server/server/server.go:201 +0x1ef
dockerauth_1 | net/http.serverHandler.ServeHTTP(0xc8201a05a0, 0x7f9ba216a880, 0xc820444dc0, 0xc820428a80)
dockerauth_1 | 	/usr/local/go/src/net/http/server.go:1862 +0x19e
dockerauth_1 | net/http.(*conn).serve(0xc8203adc30)
dockerauth_1 | 	/usr/local/go/src/net/http/server.go:1361 +0xbee
dockerauth_1 | created by net/http.(*Server).Serve
dockerauth_1 | 	/usr/local/go/src/net/http/server.go:1910 +0x3f6

I did some testing with the ruby net:ldap library and ran into a similar "connection reset by peer" issue when I used StartTLS. The connection was successful when I switched to using the "Simple_TLS" option.
The setup we employ means that there's no LDAP connection available for our AD (I believe it's via Win Server 2008), and we only accept connections over LDAP/S.
@summerQLin Would reverting to the DialTLS approach resolve the issue?

@kidhasmoxy, port 389 is not available for your AD, right? StartTLS should go with port 389, ldap:// not ldaps://. I will have TLS enabled.

Exactly, 389 is filtered publicly by firewall, but instead require TLS from the start.

Yeah, I ran into this as well when trying to use LDAPS before looking in the code and realizing it's not yet supported (only TLS is at the moment).

I finished @summerQLin 's PR and pushed. :latest has the new code but I have not tested it - as i hsaid, i have no access to a LDAP server. if someone could report here, that'd help.

Using tls = always works for me (ldaps), but this will result in the following error:
authn #2 returned error: LDAP Result Code 200 "": tls: either ServerName or InsecureSkipVerify
Specifying insecure_tls_skip_verify=true will work, but i would rather like to be able to specify the ServerName :)

@julakali could you please try to add your ServerName here https://github.com/cesanta/docker_auth/blob/master/auth_server/authn/ldap_auth.go#L144
to have a test?
Change this line to be
l, err = ldap.DialTLS("tcp", fmt.Sprintf("%s", la.config.Addr), &tls.Config{InsecureSkipVerify: la.config.InsecureTLSSkipVerify, ServerName: "your ldap server name"})

Please let me know your test result.

FWIW, I can confirm adding ServerName as suggested above did work for me.

@dpetzel can you send a PR? i'll merge it


error value equal to zero when taking  a ratio

Hi,
I get an error equal to zero when I do the ratio x/x,  but if x is assigned a value and y the same value the ratio of x/y is the correct answer. See screenshot:

This isn't a bug but a feature.  x is exactly the same thing as x and there is no doubt that x/x is equal to 1, so the uncertainty must be 0.  y instead is an independent measure which accidentally happens to have yielded the same value and uncertainty as x, but it's fundamentally something different.
If the fact that x is the same thing as x wasn't taken into account, this wouldn't be possible
julia> x = 1 ± 0.5
1.0 ± 0.5

julia> y = 1 ± 0.5
1.0 ± 0.5

julia> x + x
2.0 ± 1.0

julia> 2 * x
2.0 ± 1.0

julia> x + y
2.0 ± 0.71

x + x would return the same as x + y, which is different from 2 * x, which is totally flawed.
This is also extensively documented in the manual, see for example:

https://juliaphysics.github.io/Measurements.jl/v2.3/usage/#Correlation-Between-Variables-1
https://juliaphysics.github.io/Measurements.jl/v2.3/examples/#Correlation-Between-Variables-1

Thanks for an excellent explanation. Great package and I find it very
useful.
On Fri, Sep 18, 2020 at 6:16 PM Mosè Giordano<EMAIL_ADDRESS>wrote:

Closed #77 https://github.com/JuliaPhysics/Measurements.jl/issues/77.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JuliaPhysics/Measurements.jl/issues/77#event-3783093251,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMA2ULSTRPWP5XJRUWPDLSGN2UBANCNFSM4RSDAACQ
.


Gracefully handle backgrounded processes

Kinda similar to some of the other issues on here. rubocop --start-server always runs daemonized, which kills the other processes. In this case, there's no signal to trap, since it's just spawning another process.
Hopefully the issue will be remedied soon on their side soon, as they have a pull request open: https://github.com/rubocop/rubocop/pull/11319
But I think a lot of folks would benefit from some type of solution for this -- whether it's before/after hooks, process order, process dependencies, or something else.
My workaround:
OVERMIND_CAN_DIE=rubocop rubocop --start-server
This isn't a great workaround, because the server continues running even after Overmind has shutdown.

But you can see the rubocop server running:

Here, you can see all processes running:
(I guess it's a separate issue, but there are two of each of them)

After overmind stop:

Unfortunately, I don't see any way to fix this on the Overmind's level. When daemonizing, the process launches another process within another process group. Thus Overmind can't get the new process's PID and can't monitor its status.
As a dirty bypass:
rubocop: trap 'rubocop --stop-server' EXIT > /dev/null; rubocop --start-server && ping localhost > /dev/null

trap 'rubocop --stop-server' EXIT > /dev/null sets the trap on exit so rubocop --stop-server will be executed when the script exits.
ping localhost > /dev/null makes script keeping running after rubocop --stop-server exits.

agh! That ping trick worked! But that is definitely a dirty, dirty bypass :)
Thank you.


Is this library named incorrectly?

Just as a discussion topic, I wonder if this library name is misleading, specifically in regards to the clean method. The clean method is a wrapper around the common del library, which can not be used within a gulp.pipe method since it does not return a Stream (it returns a Promise or an array).
So for the sake of discussion, does it make sense to rebrand this module as something more descriptive to what Handyman provides, utility methods for Node scripts?
Note: handyman.clean (as well as del) can be used within Gulp tasks, just not as part of the pipeline.

not sure we can really change the name, we would have to make a whole new repo.
That said, are you proposing a name change over one method?  What is misleading about the name handyman?  What would an alternative name be?  Handyman seems to fit within the context of an ecosystem made up of Gulp pipelines.  It was for this reason the name was picked.

@thescientist13
It wasn't so much "handyman" that I felt was misleading, rather it was "pipeline". Since this library doesn't support streams, and can't really be used within a pipe() method.  I figured it was worth a discussion.

Ah, I see what you mean.
I guess at the time pipeline-* was the convention for our Gulp pipelines in the Keystone ecosystem, and also acted like a namespace if you will, so we went ahead and rolled with it for handyman too.
What would you propose as an alternative?

@paul-barry-kenzan that's a valid point, it isn't actually a pipeline itself but a pipeline utility.  So in that regard it shouldn't start with the pipeline prefix. I originally called it gulp-task-helper, i'm open to other suggestions.

@thescientist13 @mgnsharon
Not the best "namer of things". What about: keystone-handyman, or handyman-toolbelt, or task-handyman or something else framework/library agnostic, since it can be used with any JS script.

I would vote for keystone-handyman


Efficient ways to handle column additions / deletions for incremental models

My company has some very large tables (billions of rows). Engineers add or delete columns from these tables several times per month. We use incremental dbt models to process data in these redshift tables (named as source tables), and output results to another set of redshift tables (named as target tables), and need full-refresh a table every time a column is added / deleted. Because full-refresh involves billions of rows, I want to know if there is a way to avoid it.
First case is for adding an empty column to a source table. The incremental data model simply reads data from source table and writes to a target table. Instead of doing a full-refresh, can I just add the new column in the target table and refer to the new column in the incremental model ?
Second case is for dropping a column from a source table. The incremental data model simply reads data from source table and writes to a target table. Instead of doing a full refresh, can I just drop the column from the target table, and remove the column reference from the incremental model ?
Thanks.

Thanks for the writeup @chuangliuconvoy! There's a somewhat related issue over here: https://github.com/fishtown-analytics/dbt/issues/320
I think the big question is "how should an incremental model behave when its schema changes?"
I think there are generally three options:

Do nothing, and ignore any new columns produced by the model (current behavior)
Automatically run a full-refresh (see linked issue above)
Create a new column in the target table, with historical data nulled out.

The current approach, item 1, is passable. The user is encouraged to run a --full-refresh at their discretion to fill in data for the new field(s), but no data will appear in the target table until the --full-refresh is run.
The second approach is pretty untenable for dbt at the moment. dbt is stateless, so there's no good way to identify when a model's SQL has changed between runs.
The third approach is definitely more feasible than the second approach, but has a similar kind of idea. Instead of full-refreshing the model, dbt could add or remove columns to make the target schema match the schema produced by the model SQL. There is some existing code here that's responsible for "expanding" column types to make model SQL and the target table share a compatible schema. In the future, this function could also add new columns and delete extraneous columns as required to make the target schema and the model SQL identical.
The caveat of approach 3 is of course that the columns will exist, but they will not be backfilled with data as with a --full-refresh.
I'm unsure if this proposed implementation is more or less confusing than the current implementation, but I know that folks have a lot of questions about what happens when incremental logic changes, and I wonder if a change like this wouldn't help to mitigate the confusion, with the added benefit of being more performant in the case of issues like @chuangliuconvoy's.
...
@chuangliuconvoy we discussed your question in Slack, but I'll repeat it here for the sake of anyone reading this issue in the future:
I'd avoid mutating the tables that dbt produces manually, as these manual migrations are both error-prone and unversioned. Ideally, dbt would be able to run this sort of "migration" for you as described above, such that the behavior of incremental models will be consistent across dev and prod environments.

@drewbanin  I went through dbt documentation, and found an interesting function "get_missing_columns" in adapter https://docs.getdbt.com/v0.10/reference#adapter
For the use case of adding a new column to a simple incremental model that just copy data from one table to another, instead of doing a full-refresh, can I do something like following before each incremental model run?
{% for col in adapter.get_missing_columns(my_src_schema, this.name, this.schema, this.name) %}
alter table {{this}} add column "{{col.name}}" {{col.data_type}};
{% endfor %}


Modularize pbkdf2-compat

ACK

ACK

3.9.12  61056c06a520494d2c1781d6f9eb089bc1e38dc9 also sending @ForbesLindesay an invite to the org he's hooked

@calvinmetcalf Thanks.  Is there any process written down for how pull requests are reviewed?  I'm guessing from what I've seen that tit takes two "ACK"s and then the third person merges?

I usually wait for an ack, unless its a repo that one person has some ownership on (like @dcousens for this one) then I wait for that person.


wg-bento Status Update 2020-03-16

What was accomplished

React-based amp-social-share in review
Working on React-based design for amp-accordion
Working on React-based design for video players
JSX syntax is enabled
React linting is enabled

What's next

Continue work on React components
Fix prop access in React components to drop quotes
Discovery: use storybook for React component testing
Discovery: inter-element context propagation

What was accomplished

Reviewed Bento components PRs
Fixed DCE of PreactBaseElement static properties
React Hooks linter

Lessons learned

Latest closure started DCEing the static assignments to the constructor, meaning our Component code was eliminated.

Workaround is to use quoted props. Looking for better solutions.

What's next


Actually closing #4

N.B. Still working on schedule

It's worth just noting that we're not requiring attendees to be students

Also we should add an under-18s FAQ since we're not allowing them to the event (papwerwork headache)

Should I change:

question:      "Do I need to be a student to attend?"
answer:        >
Yes. Only students who are currently enrolled at a college/university or
have graduated within the past 12 months are eligible to attend.
for:
question:      "Do I need to be over 18yrs attend?"
answer:        >
Yes. Currently we cannot accommodate attendees under the age of 18.

Or something like that^

The one thing left to do with this is to add in a button at the top that links to the map, but I'll stick that in an issue


nixos/glance: init at liberty version

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @spinus @Mic92

@nlewo would be nice to add similar test to one you added for keystone, start some vm, run services, make sure they are working. Maybe even integration test for keystone would be good as well.

@edolstra sorry for indentation problems. I fixed them.
@spinus I made it but I forgot to git add the file :( I added it in a new commit.

@nlewo in general looks ok (for testing)

Thanks!

Thanks!


Github should now know about license and added lots of badges.

Linked Issue:

Checklist:

[ ] Is the linter reporting 0 errors?
[ ] Did you comply with our styleguide?
[ ] Is there adequate test coverage for your new code?
[ ] Does the CI pipeline pass?
[x] Did you update the documentation?
[ ] Did you update the sample app?
[ ] Do we need to increment the minor/major version?
[ ] Did you change the public API?
[ ] Have you done everything you can to make sure that errors that can occur are compile-time errors, and if they have to be runtime do you have adequate tests and documentation around those runtime errors? For more details.

If Applicable:

[ ] Did you test when the first item is skipped?
[ ] Did you test when the last item is skipped?
[ ] Did you test when middle items are skipped?
[ ] Did you test when incorrect data is passed forward?
[ ] Did you test proceeding backwards?

If Public API Has Changed:

[ ] Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
[ ] Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
[ ] If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

Codecov Report

Merging #59 (0089c5c) into main (7f19d72) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 0089c5c differs from pull request most recent head 967e445. Consider uploading reports for the commit 967e445 to get more accurate results

@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   97.25%   97.25%
=======================================
  Files          35       35
  Lines         985      985
=======================================
  Hits          958      958
  Misses         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4fc4f...967e445. Read the comment docs.


removeAt() method on ObjectList should guard against invalid index

We recently ran into an error on https://github.com/rdkcentral/Lightning/blob/master/src/tree/ObjectList.mjs#L144 due to us passing an invalid index somehow. I think it would make sense for the method to bail out early if the index is invalid and item is undefined.

Fixed by #309


Fix/private database chartjs

ref: OM-265

@jleveugle QA reports that this fix doesn't work.

Hello @jleveugle,
Your pull request is now closed due to inactivity.
Feel free to re-open it if you have any update.
Anna Bot for OVH UX <3


Fixed bug when writing file on windows

Does not exist on Windows. Added check to check and see if we are on Windows and if we are skipping it.

Good catch, merged.


Fixing the number of per class ground truths calculation in compute_macro_f_score()

Hi,
The number of ground truths per each class seem to be done in a degenerate way in the following line in case of zero tp_ratios  leading to nan values of num_gt
        num_gts = per_class_tp / tp_ratios

https://github.com/DCASE-REPO/psds_eval/blob/41cb9639633271fd676a6a7f26dbff36fbc0c9ba/src/psds_eval/psds.py#L755C41-L755C41
Since there is already a relevant method implemented to obtain gts in the class, the above line seems unnecessary and can be replaced by :
        num_gts = self._get_dataset_counts().values[:-1].astype(float)

the [:-1] slicing is to remove the dummy class injected at the end of the counts tensor, confusion matrix, etc. by the original developers referred to as "injected_psds_world_label". similar slicing for example is perfomed in the line above of the above mentioned line to obtain the tp counts:
per_class_tp = np.diag(counts)[:-1]

Event label "injected_psds_world_label" is not added always as a last element, and it seems that self._get_dataset_counts() returns ordered data by event label alphabetically.
This may address the issue temporarily.
num_gts = self._get_dataset_counts().drop(WORLD).values.astype(float)


Bug fix: Accessing BackgroundRefreshStatus should be done from UI thread.

Description of Change
  at UIKit.UIApplication.EnsureUIThread () [0x0001a] in /Users/builder/azdo/_work/1/s/xamarin-macios/src/UIKit/UIApplication.cs:96
  at UIKit.UIApplication.get_BackgroundRefreshStatus () [0x00000] in /Users/builder/azdo/_work/1/s/xamarin-macios/src/build/ios/native/UIKit/UIApplication.g.cs:777
  at Shiny.Jobs.JobManager.RequestAccess () [0x000e9] in <693141b490624ec4902e2a1cc684bf42>:0
  at Shiny.Jobs.Infrastructure.JobsStartup.Start () [0x0012a] in <693141b490624ec4902e2a1cc684bf42>:0
  at System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__7_0 (System.Object state) [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/src/Xamarin.iOS/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/AsyncMethodBuilder.cs:1021
  at Foundation.NSAsyncSynchronizationContextDispatcher.Apply () [0x00000] in /Users/builder/azdo/_work/1/s/xamarin-macios/src/Foundation/NSAction.cs:178
--- End of stack trace from previous location where exception was thrown ---

  at (wrapper managed-to-native) UIKit.UIApplication.UIApplicationMain(int,string[],intptr,intptr)
  at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x00013] in /Users/builder/azdo/_work/1/s/xamarin-macios/src/UIKit/UIApplication.cs:69

Related to PR #835
Issues Resolved

fixes #

API Changes

None
Platforms Affected

iOS

Behavioral Changes

None
Testing Procedure

PR Checklist

[X] Rebased on top of the target branch at time of PR
[X] Changes adhere to coding standard
[X] Sent to DEV branch

Thanks Allan! Saw the fix in the latest commit. Tested it and it's working now.

I bumped into this myself doing some testing on simulator.  Glad to hear it's working great for you.  The break seems to be changed in Xamarin iOS 15


typechecker: Remove redundant errors that come from bad lookups

Removes errors of the kind "no methods available on type", "assignment between
incompatible types", "attempt to access member on a non-struct type" etc. that propagate when some lookup yields "unknown" as the type of the expression.
Failed lookups on functions now return a dummy expression that has "unknown" as the return type instead of "void". Failed lookups on method calls because of an unknown expression type id run the arguments through the typechecker but otherwise accept the call name and make it have "unknown" as a result.
Since the test proves that those redundant errors don't exist by requiring only one error to exist (the one lookup error that would've chained the redundant ones), I've modified Jakttest so it can check for this condition as well, under a exact-error flag accept the Expect: .

I'm in the process of preventing error propagation on a for loop as well, if this is merged I'll submit another PR.

OK, now it's ready.

Hello!
One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.


Class Table and Half Class Table Produce the Same Background Table Image

The background graphic for < div class='classTable' > and < div class='classTable wide' > remains the same size no matter how much I manipulate it. the text looks fine but that graphic is really bugging me. Is there a quick fix? Or just a bug that will be resolved in due time?
Additional Details
Share Link :
or
Brew code to reproduce : Click to expand
PASTE BREW CODE HERE

can you show a picture of what you're talking about?

Closing for now because of no further response from the user, and the issue does not have enough information to fix.
Feel free to reopen this issue if this is still a problem for you and you can provide more information. @AceWindu


edits to client.prefs aren't taken into account.

say you started FAF for the first time. you logged in then you closed it.
you then edited the .faforever/client.prefs to the appropriate values for your game's location.
when you start FAF back up the fields are still empty/haven't changed.
where else are these values supposed to be changed.
may be a linux-specific issue.

The values are not supposed to be changed at all in the client.prefs. You are suppossed to set them in settings or else where. But when you do it should actually have an effect. Tell me exactly what u changed and what u expect it to do...

well I'd like for editing FAF settings to be scriptable as a part of my install script.

Sorry but from the description u provide i can not see what u are doing nor what the issue is

ok so I'd like for a non-human entity, a bot, a machine, a script, that is not even starting FAF, to simply via modification of files, edit FAF's setting's.
and then when the actual human starts FAF, FAF will have said settings in it's settings page currently being applied.
I've edited the file $HOME/.faforever/client.prefs while FAF was closed then opened up FAF to find the settings not applied in the settings window of FAF.
I grasp from this that editing $HOME/.faforever/client.prefs is the wrong way to script the editing of FAF's settings.
my question is what is the right way to edit FAF's settings?
the context is this : https://github.com/tatsujb/installFAFscript

I think it is the right way to do it ;) maybe on linux it is the wrong location up that is more a question for @Geosearchef

yeah I think it actually applies but what's shown in the GUI isn't ncessarilly loaded from that file, just set to it. it probably loads from .com.faforever.client.FafClientApplication I'll test and see if edited values actually apply even if they don't show when I have the time. if that's the case then we can close this as for the purposes of my install script it would be sufficient.

Ok so values are written as soon as you close the settings window. You should definetly only write to that file if the client is closed otherwise it might be over written or not loaded

I'm having to run FAF to gen the file loop a wait until prefs has a "username" value, then kill faf, edit the values and immediately re-run to obtain the desired effect. a bit hacky
is it reasonable to be asking of you guys/Downlord the ability to pipe run args to faf, args including most of the important values in this prefs file?
would seem neat to me. kinda like how I can script logging in to steam and downloading and running this and that.
...I wager this is a tall ask.
In any event you were right I can sorta get the behavior I want from altering that file.


Slow with large wallet

From Sunil https://github.com/AlphaWallet/alpha-wallet-ios/issues/2293#issue-746194844:

Know it is a test build, but was slow especially for wallets with a large number of tokens and transactions. Crashed often, you can use to test this 0x26aaD4D82f6c9FA6E34D8c1067429C986A055872

@hboon i found that place where stuck appears, locate in function
private func filterTransactionsToNotOverrideERC20Transactions(_ transactions: [Transaction], realm: Realm) -> [Transaction]
it seems like we a trying to filter 10k array, matching with 7k other values that is why execution stucks.


Evaluate watchPath + secrets

Description of feature
Evaluate watchPath channel factory to monitor sequencer upload dir for new runs
https://www.nextflow.io/docs/latest/channel.html?highlight=watch#watchpath
This will be in conjunction with ngs-utils, Smaple and nf secrets

discussion @ https://nfcore.slack.com/archives/CE56GDKN0/p1656654336913999

watchPath only viable from nf version 22.06 onward with (DirWatcher v2 )[https://github.com/nextflow-io/nextflow/releases/tag/v22.06.0-edge]

To make this work we need:

[ ] Create an "monitor" run mode, which triggers the workflow for each new run
[ ] Support for exome tagged runs
[ ] Support for genome tagged runs
[ ] Support for coPGT tagged runs
[ ] Support for CNVSeq tagged runs
[ ] Support for Research tagged runs
[ ] Pull trimming/mapping/... args from params and set according to tag

Not useful for now - closing


Extra space being added to js expressions inside jsx

Hello Royriojas,
Thanks for this awesome plugin!
I'm not sure why an extra space is being added here where there is a return:
Before:
export class Test extends React.Component {
render() {  //****4 spaces
    return (  //****8 spaces

  //****12 spaces
            {this.props.testApps.map((app) => {  //****16 spaces
                return (  //****20 spaces
                    <AppLauncher appData={app} key={app.name}/>  //****24 spaces
                );
            })}

    );
}

}
After:
export class Test extends React.Component {
render() {
    return (

            {this.props.testApps.map((app) => {
                 return (  //****21 spaces (should be 20)
                     <AppLauncher appData={app} key={app.name} />
                     );
             })}  //****17 spaces (should be 16)

        );
}

}
As you can see the after, I have 21 and 17, but the rest have formatterd correctly. Below is my config for this plugin:
"jsx":{
"formatJSX":true,
"attrsOnSameLineAsTag":true,
"maxAttrsOnTag":3,
"firstAttributeOnSameLine":true,
"spaceInJSXExpressionContainers":"",
"alignWithFirstAttribute":false,
"htmlOptions":{
"brace_style":"collapse",
"indent_char":" ",
"indent_size":4,
"max_preserve_newlines":2,
"preserve_newlines":true
}
}

Not sure I understand your issue completely but I did notice now that there is an extra space when the code is formatted. This is definitively a bug.

Hi Royriojas, thanks so much, and yes, its a bug, I'll stay posted for the updates. I would love to contribute, not sure where to get started with a beautifier library.

Hey @royriojas is there any chance to fix this bug or this is fundamental one?

not really, it is just a wrong calculation. but this will have to be a major change because some of the tests were mistakenly asserting the wrong thing.

I am still having this problem using the latest version.

                <AutoSizer>
                    {({height, width}) => {
                         return <ScrollSync>
                                    {({onScroll, scrollTop}) => {
                                         return
Blah
;
                                     }}
                                </ScrollSync>
                     }}
                </AutoSizer>


Add explanation for installation, explain update

@cHolzberger the name of the package is going to be sqltojson.
see package.json: "name": "sqltojson"
can you change that please?