Confusing type error message

I received this error on my types:
[ICS02.tla:7:5-7:21]: Need annotation. Found 2 matching operator signatures (((a749 -> a750), a749) => a750) or ((Seq(a749), Int) => a749) for arguments a747 and a748 E@17:10:12.873
I can kind of guess what is going on here but obviously it is not that clear. I assume it's a pretty big task to make this any better than it is, but I thought I'd make an issue.

Thanks for the report!
This is maybe a duplicate of #943, but that has an even broader scope, so we can keep this open as sub issue for now. It may be closed as a duplicate during triage.

Closing this, we'll keep #943 for tracking error message UX.


Use fast uppercase function also for reads

Gives ~0.5% faster mapping (or less)

"många bäckar små"


[BUG] v2.8.0 - rke-tools v0.1.95 not included in rancher-images - blocks RKE1 provisioning with private registries.

Rancher Server Setup

Rancher version: v2.8.0-rc1
Installation option (Docker install/Helm Chart): chart rke2 HA

Information about the Cluster

Kubernetes version: v1.25.14+rke2r1
Cluster Type (Local/Downstream): local Rancher

User Information

What is the role of the user logged in? Admin

Describe the bug
-rancher/rke-tools:v0.1.95 image is not getting pulled from a private registry as it is missing in rancher-images.txt
Image rancher/rke-tools:v0.1.94 is in the image list.
RKE provisioning Kubernetes version: v1.25.14-rancher1-1
To Reproduce

Create a Docker registry
Push all images in rancher-images.txt
Create local cluster for Rancher install and install Rancher with the private registry configuration
Provision an rke2 or k3s cluster

Result
[Failed to pull image [/rancher/rke-tools:v0.1.95] on host [<IP_ADDRESS>]: Error response from daemon: manifest for /rancher/rke-tools:v0.1.95 not found: manifest unknown: manifest unknown]
RKE2 and K3s unaffected
RKE1 provisioning impacted
Expected Result
rancher/rke-tools:v0.1.95  listed in rancher-images.txt
Registry used for Rancher should contain the image and Rancher should be pulling it successfully
Notes
rke-tools:v0.1.95 is in the KDM
This version isn't in the rke-tools Rancher repo releases.

Available to test with v2.8.0-rc2

Validated on Rancher v2.8.0-rc2


Get upcoming events from TheSpaceDevs API

Swagger information on the API: https://thespacedevs.com/2.0.0/swagger
Provides information on upcoming launches via https://ll.thespacedevs.com/2.0.0/event/upcoming/
A 'space_events' command provides short information on the upcoming 10 space events (1 line per launch) showing following info:

index 1-10
program name International Space Station
name Progress MS-16 Docking
windows_start

A 'space_event' command with parameter 1-10 providing more details on a specific launch (1 line per item below)

Windows open - Windows close
Name + description
Location

It seems this is implemented by you @leovdd ?


December/January 2019 Endgame

Schedule Template

End game master: @dbaeumer / Zurich
End game body: @roblourens  / Redmond
01/28 Code freeze for the endgame
02/01 Endgame done
02/06 Expected release date (this may change)

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame.

Monday

[x] Run OSS tool @dbaeumer

The LCA review of the ThirdPartyNotices.txt files is not needed anymore

[x] Code freeze at 5pm PT
[x] Ensure we have a green build on all platforms at 5pm PT
[x] All test items contain sufficiently comprehensive test descriptions by 6pm PT
[x] Update your availability for testing here - https://vscode-tools.azurewebsites.net/

Tuesday

[x] Test plan items assigned (using https://vscode-tools.azurewebsites.net/)

Run the tool multiple times to balance load if test items come in later and assignments are already made

[x] All closed feature-requests either have a verification-needed or on-testplan tag
[x] Test build starts at 7am CET
[x] Test plan ready by 8am CET
[x] Testing
[x] Verification needed

Wednesday

[x] Testing
[x] Remind team members to assign issues that they intend to fix to the current milestone
[x] Fixing (self-assigned, milestone assigned)
[x] Verification

Thursday

[x] Fixing (scrutiny sets in - major bugs only - to be discussed in stand-up meeting, labeled as candidate)
[x] Verification
[x] Check new OSS usage is entered into the OSS registry owner

Friday

[x] Pause scheduled insider builds @dbaeumer
Satellite modules/npm packages ready, version updated, smoke tested

[x] vscode @bpasero
[x] yo generator @aeschli
[x] vsce @joaomoreno
[x] node debug @weinand
[x] node debug2 @roblourens
[x] node debugadapter node @weinand

[x] All issues verified
[x] Fixing (only critical bugs - no string changes)
Smoketest

[x] Windows - @dbaeumer
[x] OS X - @isidorn
[x] Linux - @chrmarti

[x] All release notes updated

release notes are collected in a file named Month_Year.md in this repo directory
[x] @aeschli
[x] @alexandrudima
[x] @alexr00
[x] @bpasero
[x] @chrmarti
[x] @dbaeumer
[x] @egamma
[x] @isidorn
[x] @joaomoreno
[x] @jrieken
[x] @kieferrm
[x] @mjbvz
[x] @octref
[x] @rebornix
[x] @rmacfarlane
[x] @roblourens
[x] @sandy081
[x] @sbatten
[x] @tyriar
[x] @weinand

[ ] Acknowledge pull requests in release notes. We acknowledge PRs from outside the team. Use the thankyou tool to generate the initial contents of the section. owner

[x] vscode endgame master
[x] debug-adapter-protocol @weinand
[x] vscode-node-debug @weinand
[x] vscode-node-debug2 @roblourens
[x] vscode-debugadapter-node @weinand
[x] vscode-languageserver-node @dbaeumer
[x] language-server-protocol @dbaeumer
[x] vscode-textmate @alexandrudima
[x] vscode-loader @alexandrudima
[x] vscode-generator-code @aeschli
[x] vscode-vsce @joaomoreno
[x] vscode-docs @gregvanl
[x] vscode-css-languageservice @aeschli
[x] vscode-json-languageservice @aeschli
[x] vscode-html-languageservice @aeschli
[x] jsonc-parser @aeschli
[ ] vscode-jscs @chrisdias
[x] vscode-tslint @egamma
[x] vscode-eslint @dbaeumer
[x] vscode-jshint @rmacfarlane
[x] vscode-recipes @auchenberg
[x] localization @shawndon
[x] vscode-github-issues-prs @chrmarti
[x] inno-updater @joaomoreno

[x] Review pull requests acknowledgements with NOT MERGED - PLS REVIEW. endgame master
[x] Add notable fixes to the release notes all
When done fixing/verifying and there are changes since last build at the end of day PT

[x] Trigger new insider build and publish it manually endgame master

Friday/Monday

[x] Branch code to `release/1.31 endgame master
[x] Bump up the version in package.json - endgame master
[x] Announce master is open for business endgame master
[x] Polish release notes redmond

Monday - Wednesday

[x] Polish release notes redmond
[x] Cherry-pick hand-picked and reviewed changes to release/<x.y> endgame master
[x] Build Insider from release/<x.y> endgame master
[x] Manually release Insider endgame master
[x] Build stable for all platforms as new candidate issues come in endgame master
[ ] Documentation updated

[x] @aeschli
[x] @alexandrudima
[x] @alexr00
[x] @bpasero
[x] @chrmarti
[x] @dbaeumer
[x] @egamma
[x] @isidorn
[x] @joaomoreno
[x] @jrieken
[ ] @kieferrm
[ ] @mjbvz
[x] @octref
[ ] @rebornix
[x] @rmacfarlane
[x] @roblourens
[x] @sandy081
[x] @sbatten
[x] @tyriar
[x] @weinand

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame.

Wednesday/Thursday

[x] Build stable for all platforms endgame master
[x] Make rpm signing request @Tyriar
[x] Sanity check of installable bits

[x] Windows

[x] signed installer 32-bit @dbaeumer
[x] signed installer 64-bit @dbaeumer
[x] signed user installer 32-bit @dbaeumer
[x] signed user installer 64-bit @dbaeumer
[x] zip 32-bit @alexr00
[x] zip 64-bit @alexr00

[x] OS X - @weinand
[x] Linux

[x] deb package 32-bit @joaomoreno
[x] deb package 64-bit @joaomoreno
[x] rpm package 64-bit @joaomoreno
[x] rpm package 32-bit @joaomoreno
[x] archives @joaomoreno

[x] Publish website @gregvanl
[x] Publish Localization language pack @shawndon
[x] Publish to stable endgame master
[x] Add a git tag to HEAD of release/1.31 in format 1.31.0 (for vscode.d.ts download)  endgame master
[x] Publish rpm to repository manually @Tyriar
[x] Enable scheduled insider builds endgame master
[x] Twitter announcement @auchenberg

Recovery Build
We release a recovery build with a handful of critical fixes and translation updates a few days after a release. The candidate fixes are reviewed by the development team and are assigned to the recovery milestone. We want to be restrictive about the included candidates. The mindset is "we will lose users if we do not include the fix". Here are some examples:

data loss
a regression that users complain loudly about in issues or twitter
a significant performance regressions
an issue that impacts many users as indicated by telemetry data
an embarrassing UI glitch
critical security fixes
an issue that impacts extensions or is an API regression

Check list

[x] Create a milestone <Month> Recovery <year> owner
[x] Bump the version number owner
[x] Assign candidate issues to the recovery milestone team
[x] Review the candidate issues, and if they pass the review assign them to the recovery milestone team
[x] All candidate fixes are peer reviewed and pushed to master and then cherry-picked into the release branch team
[x] Initiate insiders build from master
[x] Issues are tested in the insiders team
[x] Build stable for all platforms from release branch owner
[x] Make rpm signing request @Tyriar
[x] Issues are verified on stable build and the verified label is added owner
[x] Check https://github.com/Microsoft/vscode/compare/release/<x.y> to ensure no other commits have been made in the release branch owner
[x] Update the release notes and include a link to a query for the fixed issues @gregvanl
Smoketest stable bits

[x] Windows - @Tyriar
[x] OS X - @rebornix
[x] Linux - @roblourens

[x] Sanity check installable stable bits that have not been smoke tested

[x] Windows

[x] signed installer 32-bit owner
[x] signed installer 64-bit @Tyriar
[x] zip 32-bit owner
[x] zip 64-bit owner

[x] OS X - owner
[x] Linux

[x] deb package 32-bit owner
[x] deb package 64-bit owner
[x] rpm package 64-bit owner
[x] rpm package 32-bit owner
[x] archives owner

[x] Publish website @gregvanl
[x] Publish stable build owner
[x] Publish rpm to repository manually @Tyriar
[x] Add a git tag to HEAD of release/1.31 in format 1.31.x

Signing off on localization for February 2019 release (v1.31 Loc)

rpm published

Hi. "Find in selection" button looks still broken: https://github.com/Microsoft/vscode/issues/68190


As a dev, I'd like to test whether the methods to follow other users works correctly to ensure correct and proper functionality.

References to methods made in #167
Legend
- Ghost: A logged-in user with no cheeps posted.
- Ghostslayer: A logged-in user with posted cheeps.

Acceptance Criteria

[x] Assess that Ghost now exists in the database
[x] Assess that a Ghost's chosen Ghostslayer exists in Ghost's following-list
[ ] Assess that Ghost exists in their chosen Ghostslayer's followers-list

The last checkbox should probs be that the follow isnt in the ghostslayers list just to show that follows are one way

@Slug-Boi Has been changed to fit your recommendation.


Store configuration file path as relative to the project root

Right now, as of v1.17.1, the Detekt configuration path is stored as an absolute path. Given that the Detekt IJ plugin settings are per-project, and thus saved in .idea/detekt.xml, this prevents folks from sharing the Detekt plugin configuration with other devs by committing the .idea/detekt.xml file as that contains absolute paths which will only work for one user.
This would easily be solved by using relative paths instead, referred to the project root directory.

used both 1.17.x and 1.18.0 (PR) - saved normally in the .idea/detekt.xml file:
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
  <component name="DetektProjectConfiguration">
    <enableDetekt>true</enableDetekt>
    <buildUponDefaultConfig>true</buildUponDefaultConfig>
    <configPaths>$PROJECT_DIR$/detekt.yml</configPaths>
  </component>
</project>

There is only a problem with the file selector settings - it displays the full path to the file, not a relative

It saves them as absolute paths on my computer, but maybe it's because I used the file picker

I also use the file selection dialog

Hm it's the same I've done, but I'm on Windows. Maybe that's the difference

I can confirm that the issue is that the IDE expects paths to be stored in POSIX format and will automatically relativize them only if they are in that format. I'm taking care of this as part of the work I am doing for #231 and the larger UI overhaul.


Investigate NA forecasts

pyrenew-test-output/influenza_r_2024-11-12_f_2024-08-29_t_2024-11-11/AK/baseline_ts_count_ed_visits_forecast.parquet
forecast column appears to be entirely NA

It does not support missing values. You can complete missing values in the data with imputed values (e.g. with tidyr::fill(), or by fitting a different model type and then calling fabletools::interpolate()) before fitting the model.

https://fable.tidyverts.org/reference/ETS.html
This is probably the issue here

@SamuelBrand1 The problem is logging the forecast targets. Sometimes counts are 0, and the forecast functions do not like log(0) = -Inf values
https://github.com/CDCgov/pyrenew-hew/blob/dbcfb6b862530feb454613934e359c1915678a8a/pipelines/timeseries_forecasts.R#L80-L81

@SamuelBrand1 Can you implement a fix?

@SamuelBrand1 The problem is logging the forecast targets. Sometimes counts are 0, and the forecast functions do not like log(0) = -Inf values
https://github.com/CDCgov/pyrenew-hew/blob/dbcfb6b862530feb454613934e359c1915678a8a/pipelines/timeseries_forecasts.R#L80-L81

Nice spot. We have an offset for the scoring, so I think it is most consistent to use that here.


[azservicebus] Adding authorization and subscription rule support

Adding in support for:

Getting/updating AuthorizationRules for topics and queues
CRUD for working with Subscription rules.

NOTE to reviewers - this doesn't yet incorporate the latest change to the naming of the List* functions. Separate PR since the changes were getting rather large here.
Fixes #16045

/azp run go - azservicebus

/azp run go - azservicebus

Does this include the fix for https://github.com/Azure/azure-service-bus-go/issues/204?

Does this include the fix for Azure/azure-service-bus-go#204? I think the answer is yes but looking for an ack.


add -s and -w flags to the go_binary linkopts

What this PR does / why we need it:
Based on https://blog.filippo.io/shrink-your-go-binaries-with-this-one-weird-trick/, adding -s and -w flags as go_binary linkops arguments reduces the binary size.
From the article:

Interestingly, what gets stripped is only the DWARF tables needed for debuggers, not the annotations needed for stack traces, so our panics are still readable!

The cert-manager kubectl plugin's size shrinks from 68M to 43M.
Kubernetes also applies these flags when compiling their binaries; https://github.com/kubernetes/kubernetes/blob/1861e4756df1818a2d4ca60c869780bf742fff6b/hack/lib/golang.sh#L798-L804.
Release note:

reduce binary sizes by adding "-s -w" as ldflags

/kind feature

/ok-to-test

ref: https://github.com/jetstack/cert-manager/pull/4138

We have an internal project where we create an alternative build of cert-manager linked against some C libraries. One of the checks that verify that build tests that it has been linked against the correct libraries etc (using goversion  and go tool nm).
This PR has removed the debugging information, so the checks no longer work:
go tool nm com_github_jetstack_cert_manager/cmd/acmesolver/acmesolver_/acmesolver
reading com_github_jetstack_cert_manager/cmd/acmesolver/acmesolver_/acmesolver: no symbol section
reading com_github_jetstack_cert_manager/cmd/acmesolver/acmesolver_/acmesolver: no symbols

We don't really have a feasible alternative way to do those tests now.
Would it be possible to either only remove the debugging info for the kubectl plugin, or alternatively parameterize building with these flags @inteon ?


How to get focussed client

Hey there!
First of all, thank you for all the work that went into writing this library! I'm really glad it exists :)
I've been playing around with it a little bit but there's something I'm not super sure about – maybe because the i3 IPC interface is generally new to me.
I want to find out what client is actually focused. Now, there is the focused field but it includes several id's and when I try to query those from the nodes field I just get back generic eDP-1 or _i3 or whatever.
I guess I'm misunderstanding the API here? Any help would be appreciated! :)

Hello! If you recursively visit the first element of focus down the tree you will eventually get to the node with focused set to true. Example:
extern crate i3ipc;

use i3ipc::I3Connection;
use i3ipc::reply::Node;

fn find_focused(node: &Node) -> Option<&Node> {
    if node.focused {
        Some(node)
    } else {
        if let Some(&want) = node.focus.get(0) {
            let child = node.nodes.iter().find(|n| want == n.id).unwrap();
            find_focused(child)
        } else {
            None
        }
    }
}

fn main() {
    let mut connection = I3Connection::connect().unwrap();
    println!("{:?}", find_focused(&connection.get_tree().unwrap()).unwrap());
}

Btw eDP-1 is the name of your display which is near the top of the tree.

Closing this out, feel free to reopen if you have any questions


ListTile drawing correctly under windows

I am having trouble getting ListView to render correctly under windows. The problem is that by default ListTile has a bunch of properties such as hoverTileColor, selectedTileColor that should change the color of the ListTile it is being rendered with.
Now I noticed that under windows neither of these properties actually seem to do anything. If i change hoverTileColor to blue, and go over my ListTile, the background seems of the tile seems the same. What is actually quite weird, about it, is that the moment the ListTile is being displayed on a surface that doesn't have any color it does seem to give it an focus and selectable colors.
For example, this would be enough to make the list tiles not change colors (focus, selecting)
Scaffold(body: Container( color: Color.white, ListView(children: [ListTile(title: Text('hello world')), ListTile(title: Text('hello world'))]))

while this did show visuals of selecting and focussing, it's not customizable:
Scaffold(body: Container( ListView(children: [ListTile(title: Text('hello world')), ListTile(title: Text('hello world'))]))

I suspect that it has something to do with a repaint boundary or state set that isn't picked up/propagated because the tile was being rendered on a colored surface.
Edit:
if I do, I can see the hover color, but if I change opacity back to 1.0 the hover color disappears. It's somehow like the hover is geometry is repainted under the actual background of the container.
Scaffold(body: Container( color: Colors.blue.withOpacity(0.0), ListView(children: [ListTile(title: Text('hello world'), hoverColor: Colors.red,), ListTile(title: Text('hello world'), hoverColor: Colors.red,)]))
``

Hi @phr34k
Thanks for filing the issue, I can reproduce the same hover issue with opacity on the web on Windows, macOS too.

code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Material App Bar'),
        ),
        body: Center(
          child: Container(
            color: Colors.blue.withOpacity(1.0),
            child: ListView(children: [
              ListTile(
                title: Text('hello world'),
                hoverColor: Colors.red,
                focusColor: Colors.blue,
                onLongPress: () {},
                onTap: () {},
              ),
              ListTile(title: Text('hello world'))
            ]),
          ),
        ),
      ),
    );
  }
}

I suspect this is an issue when running on the desktop, no matter web or app, was this working for you earlier? Can you please provide your flutter doctor -v
Thank youi

@TahaTesser nope, so far to my knowledge it was broken very first start I started to use desktop. I was basically, developing a larger desktop-based proof-of-concept application intended for desktop/tablets, so I didn't actually check against android/ios builds but with my brief exposure to flutter on android I believed it worked over there just fine.
Here is my flutter doctor -v output:
[√] Flutter (Channel dev, 1.27.0-1.0.pre, on Microsoft Windows [Version 10.0.18362.1256], locale en-US)
    • Flutter version 1.27.0-1.0.pre at D:\SDK\flutter
    • Framework revision 68c96f100e (2 weeks ago), 2021-02-08 16:14:15 -0800
    • Engine revision b04955656c
    • Dart version 2.13.0 (build 2.13.0-0.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at D:\SDK\android-sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = D:\SDK\android-sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.5.3)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.5.30002.166
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.53.2)
    • VS Code at C:\Users\phpfr\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.19.0

[√] Connected device (2 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.18362.1256]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 88.0.4324.182

• No issues found!

@TahaTesser just to clarify it seems to happen whenever there's an opaque background color under the listview/listile, if there's a parent container that has the color, it seems to either not repaint or maybe in a wrong order overlayed. Either way, I think considering you can reproduce it, you'll have no problem seeing what i mean.

CC @gspencergoog - thought you might have looked at ListTile rendering recently

This is not a result of the recent list tile changes (which were reverted), but is actually as designed.
The highlights are drawn by the InkWell that the ListTile uses, and it draws it on the nearest Material ancestor widget.  Since you are drawing over that Material widget (introduced by the Scaffold), the highlights are drawing, but they are drawing behind the opaque Container that you blocked them with.
If you want to have the highlights, but also specify a color, swap out the Container widget for a Material widget, for example:
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Material App Bar'),
        ),
        body: Center(
          child: Material(
            color: Colors.blue.withOpacity(1.0),
            child: ListView(children: [
              Focus(
                child: ListTile(
                  title: const Text('hello world'),
                  hoverColor: Colors.red,
                  focusColor: Colors.green,
                  onLongPress: () {},
                  onTap: () {},
                ),
              ),
              const ListTile(title: Text('hello world'))
            ]),
          ),
        ),
      ),
    );
  }
}

(Closing because this is as designed)


[Input] Fix doubly applied disabled opacity

Fixes #5283
See the issue for details.

@jlukic Could you add a milestone here?  We're blocked at https://github.com/Semantic-Org/Semantic-UI-React/pull/1591 over this issue.

Added in next manually with credit. Sorry about wait, appreciate your patience @levithomason.

Thanks much.


made keyword arguments explicit

This passes through the keyword arguments explicitly so that typo's don't lead to hard to debug behavior but rather to syntax errors.
In one instance a create keyword argument was passed, which I assume was meant to be either create_client or create_classpath, but i'm not sure which, so I picked one, and added a comment. Please let me know either way, and I'll remove the comment and/or fix the usage.

I like the idea of passing explicit parameters but if the number of them starts to increase we may be better of going back to this solution. Please, remove that change I pointed out and rebase on top of the last PR. Then it'll get merged :+1:

Are you ready for merge @thisfred ?

yep, this one's ready too, but needs #158 to go in first

Oops, actually you'll need to rebase this on top of the other PR so that it can get merged.

I redid the branch with just the one commit cherry picked.

Thanks @thisfred!


Elm 0.19

Closes  #36
Update template with

[x] README
[x] Elm 0.19
[x] New elm-spa-example architecture
[x] Update examples/
[x] Update index.js and index.html with new way to initialize an elm app
[x] Webpack compatibility

[x] Elm Webpack Loader
[ ] Webpack Hot Loader
[x] Best UglifyJS configuration to minimize the code here

The HMR is not added because to https://github.com/romariolopezc/elm-webpack-4-starter/issues/40

Uglify info for this template: https://github.com/romariolopezc/elm-webpack-4-starter/pull/38


add journal snapshots to storage model

The journal currently is read a ZNG file at a time generating inefficient I/O with the storage layer.  Snapshots should be stored alongside journal entries so that only the latest snapshot need be read and the fast-forwarded to HEAD.  For time travel, the last snapshot before the "at" pointer can be read then fast-forwarded.

#3296 added storage and retrieval of serialized lake/commit.Snapshot objects to lake/commit.Store.


Create IG route: /balances

Description
The balances resource is used by an AISP to retrieve in bulk or single account balance information for a specific AccountId for that the PSU has authorised to access.
Issues related

https://github.com/SecureBankingAccessToolkit/SecureBankingAccessToolkit/issues/114

Route Specifications

read/write API: Account and Transaction
Specification link: GET /balances v3.1.8
Endpoint: /balances
Method: GET
API version spec: Balances v3.1.8
API uri: /rs/open-banking/v3.1.*/aisp/balances

Acceptance criteria

[x] Functional tests passed in nightly environment
[x] Functional tests passed in dev environment
[x] Proper response expected by the spec
[x] Errors expected match with the OBIE specs
[x] Route documented

[x] Route source commented
[x] Add the route documentation to the wiki route section

Functionality implemented in: /securebanking-openbanking-demo/blob/master/config/7.0/obdemo-bank/ig/routes/routes-service/12-ob-account-access-multiple-routes.json


Fix NCHW bugs

Fix NCHW bugs including:

MatrixInstruction not work
incorrect output tensor shape formula for dilation and stride
batch stride calculation is incorrect
ZeroPad not work if PSD0 is enabled
ZeroPad not work with hipcc
Coord calculation is incorrect of ZeroPad Source kernel
refer to wrong prePad sgpr in ZeroPad cases

Enable CI tests for:
-Convolution ZeroPad
-MatrixInstructions assembly kernel

Once the CI issues are fixed, can @imcarsonliao get this PR peer-reviewed first?  Thanks so much.

@zaliu We have finished the review process at our end. could you check and assign someone who familiar with tensile convolution to review this PR.  Thanks.


crash - PusherChannels.find(name:)

Steps to reproduce
I'm using version 7.0.0
Unfortunately uncertain of the steps to reproduce, but i have a large number of the following crashes
Actual behavior

I think I've been able to replicate this issue.
I was able to replicate it by rapidly subscribing and unsubscribing from channels on a thread that isn't the main thread. The stack trace for the exception in your screenshot shows a message being processed from the websocket, which runs on the main thread and involves reading the message's channel from a Dictionary in PusherChannels.find. If you call a method that modifies that Dictionary (e.g. subscribe or unsubscribe) concurrently on a different thread then you can get the above exception.
I've started working on a fix for this. I'll let you know when I merge it.

@TomKemp i just wanted to follow up on this issue.


Fix errors returned by GCS to align with expectations in the HCS

Remove unused error types
Return HR ERROR_NOT_FOUND after process exit
Return ERROR_VMCOMPUTE_SYSTEM_NOT_FOUND on runc kill error  …

When a container is not found the HCS expects a GCS to return an HRESULT
error ERROR_VMCOMPUTE_SYSTEM_NOT_FOUND to indicate this condition.

Return ERROR_VMCOMPUTE_SYSTEM_ALREADY_EXISTS on CreateContainer with existing ID

Minor nit but LGTM

@jhowardmsft - Made the change. Submitting.


Feature: Gitlab MR support

Description of the problem / feature request:
Gitlab support for create_gitops_prs
Feature requests: what underlying problem are you trying to solve with this feature?
Create MR in gitlab.com or self-hosted gitlab
Have you found anything relevant by searching the web?

Replace these lines with your answer.
Places to look:

Work in Progress: https://github.com/cotocisternas/rules_gitops/tree/gitlab-support

Merged in #71


Add command lint:icons

As it stands right now, the icons will be linted when the application cache is warmed up

It allows CI automations,
And more important "real-time" checks:

designer give me 20 icons
i paste them in the folder
run lint command to ensure everything is safe

But it's not an absolute need for V1 obviously.


Misconfigured bosh link in bbr-credhubdb

When using bosh links, the backup fails because the json file generated doesn't contain the IP address of the postgres server.
Running bbr backup returns this output:
1 error occurred:
error 1:
Error attempting to run backup for job bbr-credhubdb on web/8c1276b4-e408-48cf-95a4-044783fd5921: + JOB_PATH=/var/vcap/jobs/bbr-credhubdb
+ SDK_PATH=/var/vcap/jobs/database-backup-restorer
+ BBR_ARTIFACT_FILE_PATH=/var/vcap/store/bbr-backup/bbr-credhubdb//credhubdb_dump
+ CONFIG_PATH=/var/vcap/jobs/bbr-credhubdb/config/bbr.json
+ /var/vcap/jobs/database-backup-restorer/bin/backup --config /var/vcap/jobs/bbr-credhubdb/config/bbr.json --artifact-file /var/vcap/store/bbr-backup/bbr-credhubdb//credhubdb_dump
psql: could not connect to server: No such file or directory
	Is the server running locally and accepting
	connections on Unix domain socket "/tmp/.s.PGSQL.5432"?
2018/08/07 10:40:37 Unable to check version of Postgres: exit status 2

psql: could not connect to server: No such file or directory
	Is the server running locally and accepting
	connections on Unix domain socket "/tmp/.s.PGSQL.5432"? - exit code 1

The bbr.json file generated doesn't contain the IP of the postgres server (in my case in another instance group):
{
  "username": "credhub",
  "password": "mypassword",
  "port": 5432,
  "database": "credhub",
  "adapter": "postgres",
  "tls": {
    "cert": {
      "ca": "-----BEGIN CERTIFICATE-----\nMYCERTIFICATE\n-----END CERTIFICATE-----\n"
    }
  }
}

Sorry error on my manifest...


ExportDialog: Validate path before allowing export

Otherwise one could quite easily end up with the exported game
being hidden files named ".x86_64" and ".pck" for example.
Also improved the default filename logic a bit to also include
extension, and never fallback to an empty string.
Also fixed being able to click "Export project" without selecting
a preset.

I've been annoyed by this UX issue several times, and I'm fairly confident there must be one or more issues about it in the tracker, but couldn't find them...

Now that Godot 3.1 has been released, we don't plan to cherry-pick new features and enhancements to the 3.0 branch, unless there is very strong support in favor of it. Removing cherrypick label for 3.0.


Reimplement readv to deal with short reads

Summary
The original implementation seems to have an assumption that the file is a regular file.
This commit re-implements it so that it can deal with tty, sockets, etc.
Impact
Testing

@yamt nice! Is there some example that showing the failure? Should it be added to apps/testing/ ?
Another question: did you run ostest and LTS locally to confirm there is not known side effects?

@yamt nice! Is there some example that showing the failure? Should it be added to apps/testing/ ?

micropython repl (with https://github.com/micropython/micropython/pull/13676) on toywasm and wamr.

Another question: did you run ostest and LTS locally to confirm there is not known side effects?

no.

The original implementation seems to have an assumption that the file is a regular file.

well, the original implementation was actually broken for regular files as well wrt read/write atomicity.

can we make a decision?

can we make a decision?

ping

can we make a decision?

I would prefer to just read the first memory block, which conform the spec and don't need malloc.

can we make a decision?

I would prefer to just read the first memory block, which conform the spec and don't need malloc.

it doesn't conform the spec.

can we make a decision?

I would prefer to just read the first memory block, which conform the spec and don't need malloc.

it doesn't conform the spec.

Why?

can we make a decision?

I would prefer to just read the first memory block, which conform the spec and don't need malloc.

it doesn't conform the spec.

Why?

consider:

file types which are usually not interruptible. eg. regular files
file types which are supposed to preserve data boundaries. eg. udp sockets
file types which are supposed to preserve read/write atomicity. eg. regular files

can we make a decision?

I would prefer to just read the first memory block, which conform the spec and don't need malloc.

it doesn't conform the spec.

Why?

consider:

file types which are usually not interruptible. eg. regular files

if spec enforce the implementation must read all available data, please point out the statement.

file types which are supposed to preserve data boundaries. eg. udp sockets

since udp already support sendmsg, the right fix is mapping writev to sendmsg by checking the fd type is socket.

file types which are supposed to preserve read/write atomicity. eg. regular files

it's caller responsibility to ensure the atomicity if readv/writev just can finish the partial job.

BTW, it's better to do the different action base on the fd type:

forward to sendmsg/recvmsg for socket type
read/write as much as possible for regular file
read/write the first block for all other type

of course, it may need to move readv/writev from libc to fs/vfs to do this type of dispatch.

can we make a decision?

I would prefer to just read the first memory block, which conform the spec and don't need malloc.

it doesn't conform the spec.

Why?

consider:

file types which are usually not interruptible. eg. regular files

if spec enforce the implementation must read all available data, please point out the statement.

i don't know where/if it's explicitly specified in the spec.
it's the traditional common behavior which many applications rely on.

file types which are supposed to preserve data boundaries. eg. udp sockets

since udp already support sendmsg, the right fix is mapping writev to sendmsg by checking the fd type is socket.

udp is just an example.
eg. there can be such character devices.

file types which are supposed to preserve read/write atomicity. eg. regular files

it's caller responsibility to ensure the atomicity if readv/writev just can finish the partial job.

no.
search "atomic" in https://pubs.opengroup.org/onlinepubs/009604599/functions/read.html.

It's better to do the different action base on the fd type before we add readv/writev to file_operation:
1. forward to sendmsg/recvmsg for socket type

2. read/write as much as possible for regular file

3. read/write the first block for all other type

of course, it may need to move readv/writev from libc to fs/vfs to do this type of dispatch. BTW, to simplify readv/writev dispatch, we can add readv/writev callback to file_operation and provide the default readv/writev implementation if the driver or file system doesn't provide one.

see https://github.com/apache/nuttx/pull/12674#discussion_r1678639259

i don't think it's a good idea to block an obvious fix like this for months just saying "there can be a better solution" w/o actually providing any better solutions.
if this PR was merged two months ago, i might even have implemented the ideal iov-based solution at least partly in the two months.

can we make a decision?

I would prefer to just read the first memory block, which conform the spec and don't need malloc.

it doesn't conform the spec.

Why?

consider:

file types which are usually not interruptible. eg. regular files

if spec enforce the implementation must read all available data, please point out the statement.

i don't know where/if it's explicitly specified in the spec. it's the traditional common behavior which many applications rely on.

But the spec explicitly allows return the short length. Caller always need handle the short return correctly.

i don't think it's a good idea to block an obvious fix like this for months just saying "there can be a better solution" w/o actually providing any better solutions.
if this PR was merged two months ago, i might even have implemented the ideal iov-based solution at least partly in the two months.

Since this solution isn't perfect, especially the allocation happens in the read/write path, I hesitate to merge this change, but other maintainers could merge it if they think it's OK.

since the better approach is merged(https://github.com/apache/nuttx/pull/13498), let's close this pr.


Community package requirements: sanity tests

Community package requirements: sanity tests
(Note: This issue was filed in a semi-automated fashion. Let me know if you see errors in this issue.)
As per the Ansible community package inclusion requirements, collections must pass ansible-test sanity tests. Version 2.0.3 of cisco.intersight, corresponding to the 2.0.3 tag in this repo, fails one or more of the required sanity tests.
Please see the errors below and address them. If these issues aren't addressed within a reasonable time period, the collection may be subject to removal from Ansible.
Thank you for your efforts and for being part of the Ansible package! We appreciate it.

Sanity tests
The following tests were run using ansible-test version 2.16.1:

ansible-doc
compile
validate-modules
yamllint

Note that this is only a subset of the required sanity tests. Please make sure you run them in all in your CI.
Results
The test ansible-test sanity --test validate-modules [explain] failed with 15512 errors:
Issue Truncated. Click to read more..

Version 2.0.6 of the collection is passing sanity tests and has been certified in the Ansible Automation Hub. Logs of the ansible-test sanity and other required tests for certification are at https://console.redhat.com/ansible/automation-hub/repo/published/cisco/intersight/import-log/

The sanity tests do fail. When doing a clone of this repository and running ansible-test sanity --docker in it (ansible-core devel or ansible-core 2.17), there is a very long list of failures (all for the validate-modules test).
(Also what Automation Hub says on sanity tests does not count for the Ansible community package inclusion requirements.)
Similar to https://github.com/CiscoDevNet/ansible-ucs/issues/40#issuecomment-2303996579, there doesn't seem to be any CI in this repository, which is also a problem.

We'll work to setup CI for the repo - sorry that's not in place.
Can you share the errors you're seeing with ansible-test sanity?  When run on the whole collection the output doesn't look right:
Running sanity test "validate-modules"
ERROR: Found 15582 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/intersight_boot_order_policy.py:0:0: doc-choices-do-not-match-spec: Argument 'acs_control_gpu1state' in argument_spec defines choices as (['platform-default', 'enabled', 'disabled']) but documentation defines choices as ([])
...
The plugins/modules/intersight_boot_order_policy.py doesn't contain that code at all and ansible-test appears to actually be referring to code in plugins/modules/intersight_bios_policy.py.  The arg spec and docs in plugins/modules/intersight_bios_policy.py is correct however and that file passes sanity tests:
ansible-test sanity plugins/modules/intersight_boot_order_policy.py
Running sanity test "action-plugin-docs"
...
Running sanity test "validate-modules"
Running sanity test "yamllint"

Hmm, that seems to be a bug in ansible-test then. The problem is that validate-modules imports all modules one by one and runs them, while mocking AnsibleModule.__init__. Since every single one of your modules uses the global intersight_argument_spec from module_utils and modifies it, you get these errors from the second module in the list on.
Applying the following patch gets rid of all these issues:
diff --git a/plugins/modules/intersight_bios_policy.py b/plugins/modules/intersight_bios_policy.py
index d2ec103..cfd1b93 100644
--- a/plugins/modules/intersight_bios_policy.py
+++ b/plugins/modules/intersight_bios_policy.py
@@ -4313,7 +4313,7 @@ def check_and_add_prop(prop, propKey, params, api_body):

 def main():
-    argument_spec = intersight_argument_spec
+    argument_spec = intersight_argument_spec.copy()
     argument_spec.update(
         state={"type": "str", "choices": ['present', 'absent'], "default": "present"},
         organization={"type": "str", "default": "default"},
diff --git a/plugins/modules/intersight_boot_order_policy.py b/plugins/modules/intersight_boot_order_policy.py
index d66c015..c5d8177 100644
--- a/plugins/modules/intersight_boot_order_policy.py
+++ b/plugins/modules/intersight_boot_order_policy.py
@@ -319,7 +319,7 @@ def main():
             default='None',
         ),
     )
-    argument_spec = intersight_argument_spec
+    argument_spec = intersight_argument_spec.copy()
     argument_spec.update(
         state=dict(type='str', choices=['present', 'absent'], default='present'),
         organization=dict(type='str', default='default'),
diff --git a/plugins/modules/intersight_imc_access_policy.py b/plugins/modules/intersight_imc_access_policy.py
index 27ebe80..5ca03a3 100644
--- a/plugins/modules/intersight_imc_access_policy.py
+++ b/plugins/modules/intersight_imc_access_policy.py
@@ -124,7 +124,7 @@ from ansible_collections.cisco.intersight.plugins.module_utils.intersight import

 def main():
-    argument_spec = intersight_argument_spec
+    argument_spec = intersight_argument_spec.copy()
     argument_spec.update(
         state=dict(type='str', choices=['present', 'absent'], default='present'),
         organization=dict(type='str', default='default'),
diff --git a/plugins/modules/intersight_info.py b/plugins/modules/intersight_info.py
index b57aab8..6fab364 100644
--- a/plugins/modules/intersight_info.py
+++ b/plugins/modules/intersight_info.py
@@ -94,7 +94,7 @@ def get_servers(module, intersight):

 def main():
-    argument_spec = intersight_argument_spec
+    argument_spec = intersight_argument_spec.copy()
     argument_spec.update(
         server_names=dict(type='list', elements='str'),
     )
diff --git a/plugins/modules/intersight_local_user_policy.py b/plugins/modules/intersight_local_user_policy.py
index 88b69b3..1459b79 100644
--- a/plugins/modules/intersight_local_user_policy.py
+++ b/plugins/modules/intersight_local_user_policy.py
@@ -176,7 +176,7 @@ def main():
         role=dict(type='str', choices=['admin', 'readonly', 'user'], required=True),
         password=dict(type='str', required=True, no_log=True),
     )
-    argument_spec = intersight_argument_spec
+    argument_spec = intersight_argument_spec.copy()
     argument_spec.update(
         state=dict(type='str', choices=['present', 'absent'], default='present'),
         organization=dict(type='str', default='default'),
diff --git a/plugins/modules/intersight_ntp_policy.py b/plugins/modules/intersight_ntp_policy.py
index 01e7322..775d8e7 100644
--- a/plugins/modules/intersight_ntp_policy.py
+++ b/plugins/modules/intersight_ntp_policy.py
@@ -116,7 +116,7 @@ from ansible_collections.cisco.intersight.plugins.module_utils.intersight import

 def main():
-    argument_spec = intersight_argument_spec
+    argument_spec = intersight_argument_spec.copy()
     argument_spec.update(
         state=dict(type='str', choices=['present', 'absent'], default='present'),
         organization=dict(type='str', default='default'),
diff --git a/plugins/modules/intersight_rest_api.py b/plugins/modules/intersight_rest_api.py
index 866c458..1b9e943 100644
--- a/plugins/modules/intersight_rest_api.py
+++ b/plugins/modules/intersight_rest_api.py
@@ -141,7 +141,7 @@ from ansible.module_utils.basic import AnsibleModule

 def main():
-    argument_spec = intersight_argument_spec
+    argument_spec = intersight_argument_spec.copy()
     argument_spec.update(
         resource_path=dict(type='str', required=True),
         query_params=dict(type='dict'),
diff --git a/plugins/modules/intersight_server_profile.py b/plugins/modules/intersight_server_profile.py
index 8746bdc..b55ba1e 100644
--- a/plugins/modules/intersight_server_profile.py
+++ b/plugins/modules/intersight_server_profile.py
@@ -253,7 +253,7 @@ def post_profile_to_policy(intersight, moid, resource_path, policy_name):

 def main():
-    argument_spec = intersight_argument_spec
+    argument_spec = intersight_argument_spec.copy()
     argument_spec.update(
         state=dict(type='str', choices=['present', 'absent'], default='present'),
         organization=dict(type='str', default='default'),
diff --git a/plugins/modules/intersight_target_claim.py b/plugins/modules/intersight_target_claim.py
index 97dcdc0..1d51fc7 100644
--- a/plugins/modules/intersight_target_claim.py
+++ b/plugins/modules/intersight_target_claim.py
@@ -106,7 +106,7 @@ from ansible.module_utils.basic import AnsibleModule

 def main():
-    argument_spec = intersight_argument_spec
+    argument_spec = intersight_argument_spec.copy()
     argument_spec.update(
         claim_code=dict(type='str'),
         device_id=dict(type='str', required=True),
diff --git a/plugins/modules/intersight_virtual_media_policy.py b/plugins/modules/intersight_virtual_media_policy.py
index ba5b35d..abee9c5 100644
--- a/plugins/modules/intersight_virtual_media_policy.py
+++ b/plugins/modules/intersight_virtual_media_policy.py
@@ -268,7 +268,7 @@ def main():
         password=dict(type='str', no_log=True),
         authentication_protocol=dict(type='str', default='none'),
     )
-    argument_spec = intersight_argument_spec
+    argument_spec = intersight_argument_spec.copy()
     argument_spec.update(
         state=dict(type='str', choices=['present', 'absent'], default='present'),
         organization=dict(type='str', default='default'),

I filed a bug in ansible/ansible: https://github.com/ansible/ansible/issues/83842
It still makes sense to apply the above patch, otherwise you won't be able to get CI pass until the ansible-test issue is fixed.

Thank you.  I'll apply the patch and add CI to the repo.

The recommendation by the core team is also to copy the dictionary (https://github.com/ansible/ansible/issues/83842#issuecomment-2304785795). I wouldn't be surprised if that problem won't get fixed, since a) a fix would be pretty complicated and/or expensive, and b) it's better for the modules to copy instead of modifying it anyway since that makes it easier to unit test complete modules. (If you would have unit tests for the modules where the whole module is started with some parameters, and the network APIs are mocked, you'd run into the same problem with unit tests, since they can also run in the same process and thus tests for different modules could cause problems with each other.)


filters for bot network under iammrneeson1.bsky.social

etc

Added contingent filters just in case pattern recurs


Fixed example app link in README.md

Is there any explanation for this change?

It was somehow redirecting me to github.com/example/lib for some reason. But I am unable to recreate it.


Rules noob question

Hi, first of all I'd like to say thanks for such an awesome window manager.
I want to create a set of rules for Chrome windows, so I'll have to leverage the title property, although I'm struggling with the REGEX.
I tried a few regex expressions that would work in other scenarios but I'm always get errors from yabai.
I basically want to look for the application titles, like: "Mail - Joe", "Mail - Mary", "Mail - Chad", and I would like each title variation to have its own rule.
But I can't get it working... Can you guys provide some example on how to tackle this type of scenario?
Thanks

Try to get as close as possible with your match.
You used - in your example title, but maybe it's – or —? Getting the exact string is really important here.
You can query all open Google Chrome windows by running this command, which will include the exact title as read by yabai (requires jq).
# get everything about Google Chrome windows
yabai -m query --windows | jq 'map(select(.app == "Google Chrome"))'

# get just the title of all Google Chrome windows
yabai -m query --windows | jq 'map(select(.app == "Google Chrome").title)'

The regex syntax used is the POSIX syntax. It's good practice to try and match start and end of line with ^ and $ respectively to avoid surprise matches.
An example rule might look something like this:
yabai -m rule --add app="^Google Chrome$" title="^Mail - Joe$" native-fullscreen=on

If you want to run code when a window title changes, consider looking into the event=window_title_changed signal, which will trigger whenever a macOS reports that a window title changed. The signal carries the window id of the window whose title has changed, allowing you to do further queries.
Also... there really are no "noob" questions. Feel free to ask, we all like to help. :octocat:

@dominiklohmann thank you, really clarified everything.
I'm also glad you mentioned how to run queries... it makes everything way way easier.
Curiosity: What the properties role and subrole (from the query result) means?
Once again, thanks.

Curiosity: What the properties role and subrole (from the query result) means?

Run Accessibility Inspector.app on your Mac and you'll see.
The gist of it is that everything in macOS windows is comprised of "elements" that are in a specific hierarchy, similar to the view hierarchy for views in iOS. There is an accessibility API that allows you to query these elements, and to identify what an element is they have roles (e.g. AXWindow for windows or AXButton for buttons), and they can optionally have a second role ("subrole") for subtypes of that role (e.g. AXStandardWindow for most windows, or AXFullscreenButton for the green fullscreen button on your windows).
When you see yabai prompt for permissions to control your computer, it is asking for access to this API specifically.
The reason that role and subrole are included in the queries is that some applications—most notably Emacs—report wrong roles for their elements. A recent change that is on current master, but not yet released, is that yabai no longer acts on windows whose role is AXPopover or whose subrole is AXUnknown.

@dominiklohmann (While I knew the gist of what roles and subroles are, for inexperienced people) What about adding your wonderful explanation about roles in the wiki? I think that the roles and subroles should be explained to people who aren’t familiar with cocoa.
Sent with GitHawk


crossbeam-skiplist bug

[dependencies]
crossbeam-skiplist = "0.1.1"
fn main() {
    let map: Arc<SkipMap<u32, u32>> = Arc::new(SkipMap::new());
    map.insert(1, 2);
    let map1 = map.clone();
    std::thread::spawn(move||{
        let key = 1;
        for _ in 0..10_0000 {
            let len = map1.len();
            if let Some(entry) = map1.get(&key) {

            }else{
                panic!("len={},key={}",len,key);
            }
            std::thread::sleep(Duration::from_millis(1));
        }
    });
    for _ in 0..10_0000 {
        map.insert(1, 2);
        std::thread::sleep(Duration::from_millis(100));
    }
}

output:
thread '<unnamed>' panicked at 'len=1,key=1', src\main.rs:21:17
stack backtrace:

Thanks for the report!
IIUC, insert reduces the refcount of the old value and then sets the new value, so if insert makes the refcount zero, a get that occurs between the time the refcount is reduced and the new value is set will return None because it sees a deleted value with a refcount of zero.

I consider it a bug that needs to be fixed, but I'm not sure if I will be able to work on a fix anytime soon.
It would be great if you or someone else could work on a fix.

I consider it a bug that needs to be fixed, but I'm not sure if I will be able to work on a fix anytime soon. It would be great if you or someone else could work on a fix.

I am trying to fix it. https://github.com/crossbeam-rs/crossbeam/pull/1101


adding oauth cards to cards-reference

fixes #801

Docs Build status updates of commit aecea04:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/Cards/cards-reference.md
:warning:Warning

Details

msteams-platform/concepts/Cards/cards-reference.md

Line 217: [Warning] Illegal link: `<a href="concepts/Cards/cards-actions.md#adaptive-card-actions">Adaptive card actions in Teams</a>` -- missing bookmark. The file concepts/Cards/cards-actions.md doesn't contain a bookmark named adaptive-card-actions.
Line 34: [Suggestion] Illegal link: `<a href="#oath-card">OAuth Card</a>` -- missing bookmark. The file concepts/Cards/cards-reference.md doesn't contain a bookmark named oath-card. NOTE: This Suggestion will be elevated to a Warning on 8/26/2019. Please fix invalid bookmarks as soon as possible.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit b086133:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/Cards/cards-reference.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


"No suitable image found" When I import framework in the iOS project and make it "Embed & Sign"

Xcode 11.3.1
iOS 13.3.1
dyld: Library not loaded: @rpath/SomeFrameworkName.framework/SomeFrameworkName   Referenced from: /private/var/containers/Bundle/Application/***   Reason: no suitable image found.  Did find: 	/private/var/containers/Bundle/Application/***.app/Frameworks/SomeFrameworkName.framework/SomeFrameworkName: code signature invalid for '/private/var/containers/Bundle/Application/***.app/Frameworks/SomeFrameworkName.framework/SomeFrameworkName' 	/private/var/containers/Bundle/Application/***.app/Frameworks/SomeFrameworkName.framework/SomeFrameworkName: stat() failed with errno=25
Can I add signing on the FatFramework stage?

Sry I can't help you here.
I don't know what the error is or what it said.
I guess signing is not possible.
See also the task:
https://github.com/JetBrains/kotlin/blob/master/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/targets/native/tasks/FatFrameworkTask.kt


counterblockd -V shows unexpected version

rippler@cpd01:/home/xcp/.config/counterblockd-testnet$ counterblockd -V
counterblockd v1.5.0

This is with the current 9.49.3.
I didn't update counterpartyd_build, I just ran setup_federated_node.py + U from 9.49.2.
After that I removed setup*.py files and ran another update, but I'm still getting this version.
According to https://github.com/CounterpartyXCP/counterblockd/releases there's only v1.0.0.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

Also in counterblockd log.
{"counterpartyd": "OK", "counterblockd_ver": "1.5.0", "counterpartyd_ver": "9.49.3", ....


Does support scheduler in timeline or vertical view ?

Version
1.7.0
Development Environment
Chrome
Current Behavior
In example I didn't seen any solution to make like timeline.
Expected Behavior
example:
timeline: https://fullcalendar.io/releases/fullcalendar-scheduler/1.9.4/demos/scale.html
vertical: https://fullcalendar.io/releases/fullcalendar-scheduler/1.9.4/demos/vertical-resource-view.html

Similar to #120


[CursorInfo] Add ObjC location to generated symbol graph

Add the file for an imported ObjC-symbol to the generated symbol graph
when ObjC documentation is requested.
Skips line/column information for now since it's not needed. If we add
those we should extract location retrieval to a common method for both
cursor info and symbol graph gen.
Resolves rdar://91658873.

@swift-ci please test

@QuietMisdreavus is there any way to pass those symbol graph options down from symbolgraph-extract? I was thinking it'd probably be better to move these tests into SymbolGraph and then have cursor info just test the very basics. Can do that in a later PR though.

@bnbarham If you want to set an option directly in swift-symbolgraph-extract, you'll need to add a CLI flag for it. There's a section of symbol-graph-specific options in Options.td, so you should be able to add one there and load it just in swift_symbolgraph_extract_main.cpp.

@bnbarham If you want to set an option directly in swift-symbolgraph-extract, you'll need to add a CLI flag for it. There's a section of symbol-graph-specific options in Options.td, so you should be able to add one there and load it just in swift_symbolgraph_extract_main.cpp.

Ah nice, thanks! I'll refactor those tests in a separate PR later.

@swift-ci please test macOS platform

@swift-ci please test macOS platform


Integrate fastpages in an existing repository

Is your feature request related to a problem? Please describe.
I want to use fastpages in an existing repository. So far, I only see the option of creating a new one.
Describe the solution you'd like
I would like to be able to use fastpages in an existing repository without having to create another one. Is this possible? I don't see the option in the documentation.
Additional context
Regarding to this topic I have seen a closed issue: https://github.com/fastai/fastpages/issues/357 which seems to show that is it not possible.
If not possible, is it planned to be added?

You have to create a new repository.  It is possible to use on an existing repository but it would require significant work on your end to configure everything.

@hamelsmu Do you have any documentation or could you indicate me how to do it?

Look at the README under customizing fastpages


kv provider lazy init

Description:
Allow kv-provider to service requests before connection to kv has been established. Once the connection has been established any kv failures were already being returned while kv-provider stayed up.
Issues affected:

Resolves #NONE :(

This change is

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable


Update Main.php

Where's the .phar?

https://github.com/Jelly9912/LightningJoin/releases/tag/v.03


sqlpackage publish fails to create views in correct order (view on view)

My database has 'view1', then another 'view2' that selects from view1. sqlpackage publish fails with an error like:
Error SQL72914: Core Microsoft  SqlClient Data Provider: Msg 208, Level 16, State 1, Procedure View2, Line 24 Invalid object name 'MyDatabase.dbo.View1'.
It is attempting to create View2 before View1 exists.
Is this a known issue? In model.xml it looks like the 'sqlpackage export' has written the correct dependencies.
Is it expected that sqlpackage publish should be smart enough to figure out dependencies?

Yes, it is expected - please share a .dacpac or a sample schema.

Hi I'm just getting back to this after 3 months. If I provide a .dacpac is someone still around to take a look?

If it helps anybody else in the future I figure out my problem. The view in my database was defined like this:
CREATE VIEW dbo.MyView2 AS SELECT * FROM dbo.MyTable
GO
CREATE VIEW dbo.MyView1 AS SELECT * FROM MyDatabase.dbo.MyView2
GO
Notice MyView1 is selecting on an explicit database causing sqlpackage to skip dependency checking I assume. Even if I published back to a database with the same name 'MyDatabase' it will still try to restore MyView1 before MyView2.
Understandable behaviour and an easy fix. Still it would be great if sqlpackage could be smart enough to realise that 'MyDatabase' is the one being restored and handle the dependency.


FileContentMatch with WorkflowFiles collection

Hi @aelassas
Is it possible to add a workflow file collection to the FileContentMatch.cs ?
return new TaskStatus(Status.Success, success);
I can see it's only returns one TaskStatus to the ExecutionGraph, but a have a scenario where to search in multible files in a folder for af Keyword in the files, and the have a IF-ELSE graph for each file.
Is that possible ?
/Jan

@janborup Ok, I will update the task in the v5.4 to search for multiple files or files in a folder.

@janborup I added support for multiple files and folders in FileContentMatch. I will publish it in the v5.4.

Thanks for the enhancement.
I think I got a little lost in translations of my task, because the mission it not quite done yet.
As I wrote above, i need postman to watch a folder, and then move-files to different folders  depending on the content in the files.
Example Task:
Watch in c:\WexflowTesting\Watchfolder3
-- Get a File from folder
-- If-FileContenctMatch = "abca" move file to c:\WexflowTesting\Watchfolder3\abca
-- If-FileContenctMatch = "abcb" move file to c:\WexflowTesting\Watchfolder3\abcb
-- Else move file to c:\WexflowTesting\Watchfolder3\other
Repeat next file
The FileContentMatch only returns ONE status for this task "Succes" or "NotFound", so the inspected files cannot we validated for the single file, and a what to do with it.
I have tied different approach, but cannot solve the in a workflow (even with the FileContentMatch enhancement)
Any suggestions ?

@janborup I updated the task to solve your issue. Now FilesContentMatch loads the file if the regex matches the content of the file.
Here is a sample workflow with your use case:
<Workflow xmlns="urn:wexflow-schema" id="999" name="Workflow_FileContentMatch3" description="Workflow_FileContentMatch3">
 <Settings>
  <Setting name="launchType" value="trigger" />
  <Setting name="enabled" value="true" />
  <Setting name="approval" value="false" />
  <Setting name="enableParallelJobs" value="true" />
 </Settings>
 <LocalVariables />
 <Tasks>
  <Task id="200" name="FileContentMatch" description="Checking file..." enabled="true">
   <Setting name="folder" value="C:\WexflowTesting\Watchfolder3" />
   <Setting name="pattern" value="(abca)" />
  </Task>
  <Task id="1" name="FilesMover" description="Moving files to abca folder" enabled="true">
   <Setting name="selectFiles" value="200" />
   <Setting name="destFolder" value="C:\WexflowTesting\Watchfolder3\abca" />
   <Setting name="overwrite" value="true" />
  </Task>
  <Task id="201" name="FileContentMatch" description="Checking file..." enabled="true">
   <Setting name="folder" value="C:\WexflowTesting\Watchfolder3" />
   <Setting name="pattern" value="(abcb)" />
  </Task>
  <Task id="2" name="FilesMover" description="Moving files to abca folder" enabled="true">
   <Setting name="selectFiles" value="201" />
   <Setting name="destFolder" value="C:\WexflowTesting\Watchfolder3\abcb" />
   <Setting name="overwrite" value="true" />
  </Task>
 </Tasks>
 <ExecutionGraph>
  <If id="100" parent="-1" if="200">
   <Do>
    <Task id="1">
     <Parent id="-1" />
    </Task>
   </Do>
  </If>
  <If id="101" parent="-1" if="201">
   <Do>
    <Task id="2">
     <Parent id="-1" />
    </Task>
   </Do>
  </If>
 </ExecutionGraph>
</Workflow>

Great Thanks.
Have just testet the last code, with this change, but got an 'null Refrence Exception' error.
Now listening on: http://[::]:8000
Application started. Press Ctrl+C to shut down.
2020-04-06 21:47:59,492  INFO [14] - [Workflow_FileContentMatch3 / 1] Workflow started.
2020-04-06 21:47:59,495  INFO [14] - [Workflow_FileContentMatch3 / 1] [FileContentMatch] Checking file...
2020-04-06 21:47:59,496  INFO [14] - [Workflow_FileContentMatch3 / 1] [FileContentMatch] No content matching the pattern (abcb) was found in the file C:\WexflowTesting\Watchfolder3\file1.txt.
2020-04-06 21:47:59,499  INFO [14] - [Workflow_FileContentMatch3 / 1] [FileContentMatch] No content matching the pattern (abcb) was found in the file C:\WexflowTesting\Watchfolder3\file2.txt.
2020-04-06 21:47:59,500  INFO [14] - [Workflow_FileContentMatch3 / 1] [FileContentMatch] A content matching the pattern (abcb) was found in the file C:\WexflowTesting\Watchfolder3\file3.txt.
2020-04-06 21:47:59,500  INFO [14] - [Workflow_FileContentMatch3 / 1] [FileContentMatch] Task finished
2020-04-06 21:47:59,501 ERROR [14] - An error occured while running the workflow. Error: {id: 202, name: Workflow_FileContentMatch3, enabled: True, launchType: Trigger}
System.NullReferenceException: Object reference not set to an instance of an object.
   at Wexflow.Core.Workflow.RunIf(Task[] tasks, Node[] nodes, If if, Boolean force, Boolean& success, Boolean& warning, Boolean& atLeastOneSucceed)
   at Wexflow.Core.Workflow.RunTasks(Node[] nodes, Task[] tasks, Boolean force)
   at Wexflow.Core.Workflow.<>c__DisplayClass183_0.<Start>b__0()

I'm a missing something ?

Yep... the parent 100 fixed "not invoked" FileMover for the second TaskId:2, FileContentMatch 'abca', but the taskId:1 is still not invoked for the first FileContentMatch for the 'abcb' in file3.txt
2020-04-06 23:57:48.753 INFO - [Workflow_FileContentMatch3 / 1] Workflow started.
2020-04-06 23:57:48.755 INFO - [Workflow_FileContentMatch3 / 1] [FileContentMatch] Checking file...
2020-04-06 23:57:48.756 INFO - [Workflow_FileContentMatch3 / 1] [FileContentMatch] No content matching the pattern (abcb) was found in the file C:\WexflowTesting\Watchfolder3\file1.txt.
2020-04-06 23:57:48.758 INFO - [Workflow_FileContentMatch3 / 1] [FileContentMatch] No content matching the pattern (abcb) was found in the file C:\WexflowTesting\Watchfolder3\file2.txt.
2020-04-06 23:57:48.760 INFO - [Workflow_FileContentMatch3 / 1] [FileContentMatch] A content matching the pattern (abcb) was found in the file C:\WexflowTesting\Watchfolder3\file3.txt.
2020-04-06 23:57:48.762 INFO - [Workflow_FileContentMatch3 / 1] [FileContentMatch] Task finished
2020-04-06 23:57:48.763 INFO - [Workflow_FileContentMatch3 / 1] [FileContentMatch] Checking file...
2020-04-06 23:57:48.764 INFO - [Workflow_FileContentMatch3 / 1] [FileContentMatch] A content matching the pattern (abca) was found in the file C:\WexflowTesting\Watchfolder3\file1.txt.
2020-04-06 23:57:48.765 INFO - [Workflow_FileContentMatch3 / 1] [FileContentMatch] A content matching the pattern (abca) was found in the file C:\WexflowTesting\Watchfolder3\file2.txt.
2020-04-06 23:57:48.766 INFO - [Workflow_FileContentMatch3 / 1] [FileContentMatch] A content matching the pattern (abca) was found in the file C:\WexflowTesting\Watchfolder3\file3.txt.
2020-04-06 23:57:48.766 INFO - [Workflow_FileContentMatch3 / 1] [FileContentMatch] Task finished
2020-04-06 23:57:48.767 INFO - [Workflow_FileContentMatch3 / 1] [FilesMover] Moving files...
2020-04-06 23:57:48.767 INFO - [Workflow_FileContentMatch3 / 1] [FilesMover] Creating directory: C:\WexflowTesting\Watchfolder3\abca
2020-04-06 23:57:48.768 INFO - [Workflow_FileContentMatch3 / 1] [FilesMover] File moved: C:\WexflowTesting\Watchfolder3\file3.txt -> C:\WexflowTesting\Watchfolder3\abca\file3.txt
2020-04-06 23:57:48.769 INFO - [Workflow_FileContentMatch3 / 1] [FilesMover] File moved: C:\WexflowTesting\Watchfolder3\file2.txt -> C:\WexflowTesting\Watchfolder3\abca\file2.txt
2020-04-06 23:57:48.770 INFO - [Workflow_FileContentMatch3 / 1] [FilesMover] File moved: C:\WexflowTesting\Watchfolder3\file1.txt -> C:\WexflowTesting\Watchfolder3\abca\file1.txt
2020-04-06 23:57:48.771 INFO - [Workflow_FileContentMatch3 / 1] [FilesMover] Task finished.
2020-04-06 23:57:48.771 INFO - [Workflow_FileContentMatch3 / 1] Workflow finished.

What i'm i missing.

Have just found out that ALL files in a folder checked with FileContentMatch has to have a match before the Success is invoked, and thats why taskId 2 is fired, because all files contains 'abca'.
If I create at file4.txt with the content "You find nothing here", none of the Success (Task 1 or 2) is fired.

@janborup Thanks for the pull request. Did you get it working for your use case?

Yes - thanks @aelassas
The success fix solve the case, and it works fine.


fix(module:badge): fix parent component use onpush nzCount not show

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

https://github.com/NG-ZORRO/ng-zorro-antd/issues/5216
i think onstable means change detection has done, markForCheck does not trigger change detection, it's only change view check state


Clearing the search bar still yields script template results

Type a search string, then delete what you typed. There will still be results in the results box, specifically Script templates:

This seems to be a problem with the Script templates Searcher, @ctrueden; it also happens in Fiji. Where is that Searcher located? It'd be best to move this issue there.

I agree that we should fix it in the script template searcher. But it would also be good to have explicit handling here in napari-imagej to clear the results explicitly whenever the text field gets blanked out.
@gselzer wrote:

Where is that Searcher located?

#@ PluginService ps
from org.scijava.search import Searcher
for searcher in ps.getPluginsOfType(Searcher):
	print(searcher)

class='org.scijava.search.snippet.SnippetSearcher', priority=1000000.0, enabled=true, pluginType=Searcher
class='org.scijava.search.module.ModuleSearcher', priority=10000.0, enabled=true, pluginType=Searcher
class='net.imagej.ops.search.OpSearcher', priority=9999.0, enabled=true, pluginType=Searcher
class='org.scijava.search.template.TemplateSearcher', priority=9990.0, enabled=true, pluginType=Searcher
class='org.scijava.search.web.ImageJWikiSearcher', priority=100.0, enabled=false, pluginType=Searcher
class='org.scijava.search.classes.ClassesSearcher', priority=0.0, enabled=true, pluginType=Searcher
class='org.scijava.search.web.ImageScSearcher', priority=0.0, enabled=false, pluginType=Searcher

But it would also be good to have explicit handling here in napari-imagej to clear the results explicitly whenever the text field gets blanked out.

I don't think it's that simple @ctrueden. Getting from search text to results is all done through event handlers, and we leave any search ordering up to the SearchOperation. Thus if we were to try to process different search texts diffrently (i.e. by handling an empty string search ourselves), we might break the search ordering and see weird behavior.
For example, suppose you start from a fresh terminal, and type f and then immediately clear the search bar. If we finish handling the empty string from clearing the bar before the searchOperation returns the results from searching f, we'll have search results with no search string.
As much as I'd like to handle clearing the search bar ourselves, it would take a lot of yucky refactoring to do so


How to focus a touchable opacity component in a FlatList in tvOS

I'm focusing on a FlatList button that selects the video's caption, but when I open the modal again and navigate between the buttons, the focus goes to the top of the list instead of the button that is focused.
https://www.loom.com/share/e572acde4ee94319ad3106c394b8e238

When I select a subtitle by pressing the button, the modal closes and when it is opened again the selected subtitle button appears focused, but when pressing the up arrow the focus goes to the top of the list or the focus goes down to the end of the list. instead of starting from the button that is focused.

I used scrollview instead of FlatList, but the same thing happened before.

Hey. Not really sure what causes this issue, but I've noticed interesting choice here with button ref:

Idk if it has anything to do with your issue but maybe it would be better to have an array of buttonRefs and control these modal buttons that way, instead of providing the single buttonRef to different button every time focus changes 🤔

Tried with an array, but it didn't work either.
Instead of FlatList I just used ScrollView and used react-native's native modal instead of this lib.
The first button is now focused, previously none of the buttons were focused when displaying modal unless you navigated between buttons.
But I couldn't focus on a specific button and navigate from it, the first one is always focused and I navigate from it.

Did you try hasTVPreferredFocus prop?

Tried with an array, but it didn't work either.
Instead of FlatList I just used ScrollView and used react-native's native modal instead of this lib.
The first button is now focused, previously none of the buttons were focused when displaying modal unless you navigated between buttons.
But I couldn't focus on a specific button and navigate from it, the first one is always focused and I navigate from it.

Did you try hasTVPreferredFocus prop?

Tried with an array, but it didn't work either.
Instead of FlatList I just used ScrollView and used react-native's native modal instead of this lib.
The first button is now focused, previously none of the buttons were focused when displaying modal unless you navigated between buttons.
But I couldn't focus on a specific button and navigate from it, the first one is always focused and I navigate from it.

Did you try hasTVPreferredFocus prop?

I tried that too but it keeps focusing on the first button and navigation also starts from the first button.
And in this case with hasTvPreferredFocus the bug of showing as if there were two buttons selected happened again.
So, as a workaround, I let autofocus on the first button happen and reordered the list by moving the selected button to the first one in the list.


Input Stream Alias Clash with Output

Unexpected output is produced if the name of field in the input stream & outstream is same.
Input Stream Definition

Query is
SELECT id,t,sum (v) as v FROM tagStream  GROUP BY SlidingWindow(ss, 30)

Input Payload
Current Output Payload
Expected Output Payload

{"eid":"eid1","id":"tag1","t":1,"v":5}
{"id":"tag1","t":1,"v":5}
{"id":"tag1","t":1,"v":5}

{"eid":"eid1","id":"tag1","t":2,"v":5}
{"id":"tag1","t":1,"v":10}
{"id":"tag1","t":2,"v":10}

{"eid":"eid1","id":"tag1","t":3,"v":5}
{"id":"tag1","t":1,"v":20}
{"id":"tag1","t":3,"v":15}

Notice that the v should be 15 instead of 20 in last row. Changing the alias of sum(v) to e.g. v_new produces correct sum.
However the value of field 't' remains fixed as 1 & only changes after the duration of window has passed. This last problem might be related to issue-838

Thanks for opening this issue with the detail.
I think it is not allowed to alias to the name of another field. All field names + field alias names are supposed to be unique. Maybe we can add some validation during the SQL parsing.

@ngjaying So if the payload format for input & output needs to be same then we should use templates?
What about second issue :
"However the value of field 't' remains fixed as 1 & only changes after the duration of window has passed. This last problem might be related to issue-838"

@zeeshanshabbir93 yes, data template should be fine.

After refactoring, it is now allowed to have an alias name to be the same as a field name. The support is planned to be released at 1.3.0


[cxx-interop] calls to __swift_interopStaticCast in synthesized base class member accessors should not copy C++ type by value

Right now, when Swift compiler synthesizes a call to __swift_interopStaticCast when creating a thunk for imported C++ type that calls a const base class  method (non-mutating), it ends up passing the C++ record by value, thus copying the given value. This should be avoided, we should pass them by const ref or pointer, like we do when invoking mutating methods.

Let's punt this out of 5.9

for swift-5.10

https://github.com/apple/swift/pull/68846


Package request: Teradici PCoIP Client

Project description
From their site: "PCoIP Software Clients are applications that establish PCoIP sessions with remote Windows or Linux desktops."
Metadata

homepage URL: https://www.teradici.com/
source URL: https://docs.teradici.com/find/product/software-and-mobile-clients/2023.04
license: proprietary
platforms: linux, darwin

there seem to have been an attempt at it in this PR, but it was closed, and since then a lot has changed

+1 I'd love to have this

I'm willing to have a bounty to see this packaged in Nix

I would add some capitol to a bounty as well.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nix-bounties-rewarding-people-who-package-maintain-with/26711/16

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/distrobox-pcoip-client/37125/2

I tried packaging from the deb to an appimage but ran into QT problems. Had an idea to run the windows exe with wine.... and it works! Performance isn't bad, seems to be about the same as the linux client. So steps are to download the windows pcoip - [windows pcoip client download]](https://dl.teradici.com/DeAdBCiUYInHcSTy/pcoip-client/raw/names/pcoip-client-exe/versions/23.12.2/pcoip-client_23.12.2.exe), run the installer with wine.
A native package would be great but this is will get me onto Nixos for my daily driver.

This actually works as well as distrobox does but still has the issue of inhibiting shortcuts on wayland :/


Improve Discord message reply name handling

Previously replies would be prefixed as ${Server Nickname} replying to ${Discord Username}:, meaning if you were nicked in the server and replied to your own message it would look weird as shown here:
This replaces the username with the server nick in order to keep the same.
If webhook message mode is enabled replying to the webhook will be displayed as ${Server Nickname} replying to ${Minecraft IGN} instead of as if there was no reply.

Looks good, thanks!
Something that might be noteworthy is that the bot will still use the user's Discord username instead of their nickname if the message you're replying to was sent before the instance of the bot was started, since the bot uses Discord.js-Light, and in order to save memory it doesn't fetch the member instance along with the message, that could be circumvented by fetching the member instance directly after the message but shouldn't really be an issue the majority of the time since the bot is a long-running instance, and is only restarted occasionally.
Thanks again for working on this. 👍


Simplify expectations

Refactor expectations code. The recursive nature of the code makes it very difficult to understand, debug and cause maintaining issues.
Issues with the code to address:

Flipping types in expectation's signature. It brings lots of surprises during debugging when you don't know which call is going to be next.
Recursive. Same debugging and reading code problem.
Blank (unused) parameters of the expectation don't help in reading, understanding the code as well.

Contact: @awav, @vdutor

Over the GPflow slack, I have been discussing this issue with others. To summarize the current state of the expectations module and discuss some of the desirable features to keep or add, I wrote down a Google Docs document about it.
In summary, the proposals in the document are:

Adopt a Strategy-like design pattern to simplify the adoption of alternative ways to solve expectations. E.g. AnalyticOnly, GaussHermiteQuadrature, MonteCarlo, UnscentedTransform, BayesianIntegration;

Prioritize analytical expressions over approximations. The current implementation based on pattern matching is excellent at only resorting to approximations if nothing else can be done and I believe the pattern matching though multi dispatch is one of the most significant assets of the current implementation, and it must be preserved;

Break the expectation function into smaller parts;

Add a mechanism to pass state into the expectation function. Currently, the expectation module exports a stateless free-standing function. However, to enable proper usage of Monte Carlo integration as an alternative, the Psi-statistics computation must share the sample points between expectations.


composite operation create a gray outline with the latest 0.30.2

Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?

[x] Running npm install sharp completes without error.
[x] Running node -e "require('sharp')" completes without error.

Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?

  System:
    OS: macOS 12.2.1
    CPU: (8) arm64 Apple M1
    Memory: 131.50 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.7.0 - ~/.nvm/versions/node/v16.7.0/bin/node
    Yarn: 1.22.15 - ~/.yarn/bin/yarn
    npm: 7.20.3 - ~/.nvm/versions/node/v16.7.0/bin/npm
  npmPackages:
    sharp: 0.30.2 => 0.30.2

What are the steps to reproduce?
take a transparent png,
apply a composite with tiles to the background,
output to jpeg or webp,
a gray outline is visble (obvious on white images like attached)
inputFile

inputTile

example code 1:
let image = sharp(inputFile);
image.composite([{ input: inputTile, tile: true, blend: 'dest-over', gravity: 'northwest' }]);
image.resize({ width: 400, fit: 'outside' });
image.jpeg({ quality: 100 });
OR
image.webp({ quality: 100 });

example code 2:
let image = sharp(inputFile);
image.resize({ width: 400, fit: 'outside' });
image = sharp(await image.png().toBuffer());
image.composite([{ input: inputTile, tile: true, blend: 'dest-over', gravity: 'northwest' }]);
image.jpeg({ quality: 100 });
OR
image.webp({ quality: 100 });

output with 0.30.2

output with 0.30.1

These kind of fringe effects around edges usually relate to premultiplication.
Commit https://github.com/lovell/sharp/commit/c62002554b5938c43c14fefafad7353ae4d720cf in v0.30.2 switched from libvips' composite2 to composite as well as passing responsibility for premultiplication to libvips.
Does this only occur for dest-over? Perhaps the problem fixed by https://github.com/libvips/libvips/issues/1301 needs to include that blend also?

using image.composite([{ input: inputTile, tile: true, blend: 'dest-in', gravity: 'northwest' }]);

doesn't seems to produce that gray line, I can test other options if that's helpful

do you think I should transfer this issue to https://github.com/libvips/libvips and reference the change in https://github.com/libvips/libvips/issues/1301 ?

Thanks for confirming, if you're able to reproduce using vips composite2 in1.png in2.png out.png dest-over at the command line then yes please.

thank you, here is my results using vips-8.12.2-Tue Jan 25 09:34:32 UTC 2022 installed with brew install libvips
output of --vips-config
enable debug: no
enable deprecated library components: yes
enable modules: no
use fftw3 for FFT: yes
accelerate loops with orc: yes
ICC profile support with lcms: yes (lcms2)
zlib: yes
text rendering with pangocairo: yes
font file support with fontconfig: yes
RAD load/save: yes
Analyze7 load/save: yes
PPM load/save: yes
GIF load:  yes
GIF save with cgif: yes
EXIF metadata support with libexif: yes
JPEG load/save with libjpeg: yes (pkg-config)
JXL load/save with libjxl: yes (dynamic module: no)
JPEG2000 load/save with libopenjp2: yes
PNG load with libspng: yes
PNG load/save with libpng: yes (pkg-config libpng >= 1.2.9)
quantisation to 8 bit: yes
TIFF load/save with libtiff: yes (pkg-config libtiff-4)
image pyramid save: yes
HEIC/AVIF load/save with libheif: yes (dynamic module: no)
WebP load/save with libwebp: yes
PDF load with PDFium:  no
PDF load with poppler-glib: yes (dynamic module: no)
SVG load with librsvg-2.0: yes
EXR load with OpenEXR: yes
OpenSlide load: yes (dynamic module: no)
Matlab load with matio: yes
NIfTI load/save with niftiio: no
FITS load/save with cfitsio: yes
Magick package: MagickCore (dynamic module: no)
Magick API version: magick7
load with libMagickCore: yes
save with libMagickCore: yes

I don't reproduce the issue using vips composite2 inputFile.png inputTile.jpg output.png dest-over
inputFile.png

inputTile.png

output.png

when using vips composite2 inputFile.png inputTile.jpg output.png dest-over --premultiplied
the output give me an white outline border
output with --premultiplied

fwiw I got the same results when sharp use the globally available libvip instead of the prebuilt binaries
here is the complete test
const { readFileSync, writeFileSync, unlinkSync } = require('fs');
const path = require('path');
const sharp = require('sharp');
let assert = require('assert');

const { handleImageResize } = require('../image-handler');

describe('composite', () => {
  it(`create a tiled png composite output from sharp pipeline`, async () => {
    try {
      unlinkSync(path.resolve(`${__dirname}/output/test2.jpg`));
    } catch (error) {}
    let image = sharp(readFileSync(path.resolve(`${__dirname}/inputFile.png`)));
    image.composite([{ input: readFileSync(path.resolve(`${__dirname}/inputTile.jpg`)), tile: true, blend: 'dest-over', gravity: 'northwest' }]);
    image.resize({ width: 400, fit: 'outside' });
    image.jpeg({ quality: 100 });

    writeFileSync(path.resolve(`${__dirname}/output/test2.jpg`), await image.toBuffer());
  });
});

Thanks for the all the extra examples, I can reproduce this locally with sharp, but I've yet to try to reproduce with vips at the command line.
If sharp premultiplies both images before compositing and sets premultiplied to true (as it used to prior to this change) then the problem goes away.
I think we're seeing this due to libvips only premultiplying one of the images when compositing, which is usually the "lower" image, but with the dest-* blends I think it might be the "upper" image that needs this instead/as well.
https://github.com/libvips/libvips/blob/330ebf3cd7114afd6bc634b450bea20d73fd864f/libvips/conversion/composite.cpp#L508-L512
Possibly the calculation for the dest-over resulting colour should somehow involve the resulting alpha?
https://github.com/libvips/libvips/blob/330ebf3cd7114afd6bc634b450bea20d73fd864f/libvips/conversion/composite.cpp#L566
@jcupitt When you get a mo, please can you check the current VIPS_BLEND_MODE_DEST_OVER logic to see if we're missing anything obvious, thank you.

Hi @lovell, this is an odd one. I tried a small test program
#!/usr/bin/python3

import sys
import pyvips

image = pyvips.Image.new_from_file(sys.argv[1])
tile = pyvips.Image.new_from_file(sys.argv[2])

background = tile \
    .replicate(1 + image.width / tile.width,
               1 + image.height / tile.height) \
    .crop(0, 0, image.width, image.height)

over = background.composite(image, "over")
dest_over = image.composite(background, "dest-over")

diff = (over - dest_over).abs().max()

print(f"maximum difference = {diff}")

With git master libvips and with 8.12 I see:
$ ./composite-tile.py ~/pics/heart.png ~/pics/tile.jpg
maximum difference = 0.0

So over and dest-over seem to work. I saved the images and checked by hand as well, they look OK.
I think I would patch sharp to save the argument images to composite just before calling it, probably as .v format to make sure the saver doesn't change anything. You can then check the argument images to verify that sharp hasn't done any premultiplication (vipsdisp is handy for this, right-click, turn on the info bar and you can see the exact pixel values in the file). Then run composite at the command-line and check the result.
If the input images are wrong I suppose sharp might have a stray premultiply still. If they are OK and the output is wrong, we have a reproducer for a libvips bug.

Thanks John, I think I've found the problem, there was a extra unpremultiply taking place in sharp after composite that affects some of the dest-* blend modes.
Rather annoyingly the unit tests did pick this up at the time but I incorrectly assumed the "new" behaviour was more accurate. https://github.com/lovell/sharp/commit/c62002554b5938c43c14fefafad7353ae4d720cf#diff-7a6322e019754e2e5f843a65aa8cfb3635d77a757b88ef4c6a9450a022e5678f

I've reverted the test fixtures to their v0.30.1 state, as well as removing the unpremultiply operation when compositing, in commit https://github.com/lovell/sharp/commit/23033e2050d9ef099ecb02dde0f56f9f23e8d30d
This will be in v0.30.3, thanks for reporting.

v0.30.3 now available.

Hi,
I've tried with sharp 0.30.3
> npm view sharp dist-tags.latest
0.30.3

>npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp

  System:
    OS: macOS 12.2.1
    CPU: (8) arm64 Apple M1
    Memory: 78.98 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.7.0 - ~/.nvm/versions/node/v16.7.0/bin/node
    Yarn: 1.22.15 - ~/.yarn/bin/yarn
    npm: 7.20.3 - ~/.nvm/versions/node/v16.7.0/bin/npm
  npmPackages:
    sharp: 0.30.3 => 0.30.3

for the following code, with the same input files
describe('bg mosaic', () => {
  it(`create a tiled png output from sharp pipeline`, async () => {
    try {
      unlinkSync(path.resolve(`${__dirname}/output/test2.jpg`));
    } catch (error) {}
    let image = sharp(readFileSync(path.resolve(`${__dirname}/inputFile.png`)));
    image.composite([{ input: readFileSync(path.resolve(`${__dirname}/inputTile.jpg`)), tile: true, blend: 'dest-over', gravity: 'northwest' }]);
    image.resize({ width: 400, fit: 'outside' });
    image.jpeg({ quality: 100 });

    writeFileSync(path.resolve(`${__dirname}/output/test2.jpg`), await image.toBuffer());
  });
});

I still have the same output

v0.30.3 works on my machine:
node -p "require('sharp')('heart.png').composite([{ input: 'checks.jpg', blend: 'dest-over' }]).toFile('out.png')"

yes I messed up my test files... and was testing with a wrong input, it works fine, thank you again


Widget.js CHECK_COIN_STATUS_ENDPOINT_ Error in Console

There seems to be a bug in the Widget.js script. Whenever I include it in my app it does a get request for /___CHECK_COIN_STATUS_ENDPOINT____/rb/checkStatus. Since there's no domain at the beginning of the url it's interpreted as a request to my local server, which has no route for this endpoint, so it throws an error.
I'm not sure that this is actually causing an issues with how the script functions. So far it seems to be more of a nuisance than anything. I was asked to look into it so I thought it would be a good idea to open an issue here just in case.
This is the script I'm including. It throws the error even if I never do anything to setup the widget.
<script type="text/javascript" src="https://static-na.payments-amazon.com/OffAmazonPayments/us/sandbox/js/Widgets.js" async></script>

@adamwgriffin, we are aware and working on this issue. Just an FYI, this is only happening in sandbox and not in production.
I will update here, once we have resolved this error in sandbox.

Great! Thanks @tarishah

Closing as no longer an issue. Please reach back if there are any further concerns.
Thanks!


[DROOLS-7600] Impact Analysis : export as JSON

JIRA:
https://issues.redhat.com/browse/DROOLS-7600

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request checks
Please add comment: Jenkins retest this

for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests

for a full downstream build

for jenkins job: please add comment: Jenkins run fdb
for github actions job: add the label run_fdb

a compile downstream build please  add comment: Jenkins run cdb

an upstream build please add comment: Jenkins run upstream

for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch

for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main

for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts

for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

for native checks
Run native checks
Please add comment: Jenkins run native

for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native

for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts

for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

If this PR is merged, ansible-rulebook rules can be visualized with the following demo apps:
https://github.com/tkobayas/rule-visualization-demo

backend is drools-ansible-rulebook-integration-visualization exposing a quarkus rest endpoint that receives a RuleSet definition JSON and returns a topology graph JSON.
frontend is a React app with patternfly/topology. Sends an example RuleSet definition JSON to the backend service and receives the topology graph JSON. Then renders the topology graph.

@mariofusco Please merge this PR, thanks!