Twistlock to Amazon Inspector

User Story - Business Need
Twistlock is currently responsible for scanning our container images for vulnerabilities. Its drawbacks are that another team manages it, it is currently implemented on an EC2 instance that requires hand-holding, its user interface is not intuitive. AWS Inspector has been identified as a solid replacement. The VAEC has no requirements that we use one or the the specifically, so we are free to replace Twistlock.

[ ] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)
As a VA Notify
I want to implement Amazon Inspector for vulnerability scanning and replace our current system, Twistlock
So that we can increase efficiency and cost-effectiveness while filling existing security gaps in our setup
Additional Info and Resources
The goal of this ticket is to replace Twistlock with AWS Inspector.  This includes to begin scanning our Lambdas.  Currently, whenever we deploy, we get notified in Actions whether Twistlock passes or failed.  We need another method of getting notified if one of our images or lambdas have vulnerabilities when we deploy.
Thus, the goal of this ticket is to:

Implement AWS Inspector via terraform.
Set up a way to automatically notify the team when deploying a new image to dev (preferably in Github Actions).

A fair bit of knowledge has already been gathered in this document, but actual implementation was outside the scope of that research.
Inspector provides real-time vulnerability detection in both OS and programming language packages, and it rescans automatically when there are changes to the workloads.
Switching to Twistlock eliminated three points of failure (Actions, Twistlock, and the EC2 AMI)
Notably, there are some implementation considerations:

AWS Inspector should be integrated via terraform to adhere to our IaC standard.
Appropriate IAM policies should be in place to permit Amazon Inspector access to the repository and choose the desired scanning settings.
The implementation includes both image scanner and lambda functions.
Remove Twistlock from our actions and infrastructure.

Overview Document
Terraform docs on AWS Inspector
Medium Blog on Terraform Implementation
Implementation via GUI
Engineering Checklist

[ ] Implement the enhanced inspector via terraform
[ ] Create appropriate IAM policies to enable AWS Inspector (with Terraform)
[ ] Configure Amazon Inspector for image scanning and lambda scanning.  If setting up lambda scanning proves additionally complex, make a new ticket.
[ ] Create documentation in team repo
[ ] Remove Twistlock from our Github Workflows and our infrastructure

Acceptance Criteria

Amazon Inspector is successfully implemented and replaces Twistlock.
All images and lambda functions are being scanned by Amazon Inspector.
All changes are appropriately documented in the team repo.

QA Considerations

[ ] review the implementation to inform us how to manage what it reports

Closing.


Add Ability To Provide Custom HTTP Headers For Storybook Endpoint

For storybook deployments that are behind authentication, such as Basic Auth, while playwright supports defining httpCredentials or custom headers, the initial check done by this test runner fails since it only runs a very simple check against the URL.
This PR adds the ability to define custom headers for the test runner so that it can properly verify URL in these cases, and the test runs will use playwright's config afterwards.

Thank you so much for your contribution @anshap1719! I made a PR in #245 that provides this functionality but with a slightly different approach. I hope it's alright with you. This PR served as an inspiration! Thank you once again!

@yannbf Totally. Thanks for letting me know. This is great to finally have :)


Move from miscreant to aes-siv

This is an alternative to #411 (and is in fact based on that PR).
This copies miscreant's internals, using aes-siv's lower-lever interface. That way, we keep backwards compatibility with previously generated IDs.
Half the work here was done by @kornelski, the other half was copied from miscreant's src/aead.rs @ 53b3ae9fabe049ce2a6341d10aa359546b03c734.
Fixes #410.
Checklist:

[ ] cargo +nightly fmt --all — broken by someone else, so I only applied the changes on the lines that I modified
[x] Modify CHANGELOG.md if applicable — this change shouldn't be visible to users, so I left the changelog untouched

@Minoru Thanks a lot for help! Much appreciated.

@kornelski I'm a bit confused with the change you just landed. We do still land this, right? I did a quick local verification and this seems to work.


Identifying nodes with no children

Sometimes in my XML file the nodes might end up like this:
<W20170116>¬DELETED¬</W20170116>
Normally there are other nodes inside there. I thought this code would work:
if (!pWeek->NoChildren())
{

I assume that the ¬DELETED¬ is considered a text value or something and thus a child, so my code is failing. In my case what I really want to know is if there are no children nodes.  As far as I am concerned the above example does not have any "children" and should have returned false.
Please assist.

Text is considered a node - XMLText is a child of XMLNode, specifically. You could check for FirstChildElement() returning null, perhaps?

Thanks. :)


V3: Extensions: Theming support and shared module

Make sure you run:
npm run build-tools

this will build the tool that customizes the webpack config.

Superseded by V4 build PR


Feature Request: bump-my-version show-bump --type <major/minor/patch> [VERSION]

bump-my-version version:
Python version:
Operating System:

Description
None
What I Did
Here's the current CLI options for show-bump in bump-my-version.
 Usage: bump-my-version show-bump [OPTIONS] [VERSION]

 Show the possible versions resulting from the bump subcommand.

╭─ Options ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ --config-file      FILE           Config file to read most of the variables from.                                                      │
│ --ascii                           Use ASCII characters only.                                                                           │
│ --verbose      -v  INTEGER RANGE  Print verbose logging to stderr. Can specify several times for more verbosity.                       │
│ --help         -h                 Show this message and exit.                                                                          │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

Is it possible to add a new option for specifying the exact bump type? For example:
bump-my-version show-bump --type patch v1.0.0 # it should gives v1.0.1 to stdout

It would be helpful for using it in CI as I don't want to have a actual file like __init__.py to track the version (no new commit in main branch after bumping version is created/needed).
So the following is what I hope to achieve:
python --version
python -m venv .venv && source .venv/bin/activate && pip install --upgrade pip --quiet
pip install -U bump-my-version --quiet

git config user.email "${CI_BOT_EMAIL}"
git config user.name "${CI_BOT_USERNAME}"

git remote set-url --push origin<EMAIL_ADDRESS>git push origin tag v$(bump-my-version show-bump --type ${RELEASE_TYPE})     // by default, bump-my-version already can read latest version from git tag

Or even better, allow bump-my-version to create new tag without writing to a file. Then this can be achieved:
python --version
python -m venv .venv && source .venv/bin/activate && pip install --upgrade pip --quiet
pip install -U bump-my-version --quiet

git config user.email "${CI_BOT_EMAIL}"
git config user.name "${CI_BOT_USERNAME}"

bump-my-version bump $RELEASE_TYPE    // this will create a new git tag without explicit write to any file
git remote set-url --push origin<EMAIL_ADDRESS>git push origin tag v$(bump-my-version show current_version)

Two things::

The current, most straightforward way to get the version of a potential bump as you want it is with the show command. bump-my-version show --increment minor new_version. The show command is a legacy command that displays configuration information and allows one to show specific keys.
Your question about this demonstrates the overlap of the two commands. I may not be able to get to this for a week or two.

Hey @coordt, appreciate the prompt reply!
I can achieve what I'm trying to do with the provided command. Would you deprecate the legacy command in a very near future? If this ever get deprecated, this is my current workaround:
bump-my-version show-bump --ascii | grep $RELEASE_TYPE | awk '{print $NF}'     # $RELEASE_TYPE is either 'major', 'minor', or 'patch'

For 2, I'm willing to contribute if you need another helping hand on this. Anyway, this is not a very rushed requirement on my project too.

@hongjiaherng FYI my PR last year provided that exact functionality (show the next number for specific type):
https://github.com/callowayproject/bump-my-version/pull/88

Hi @coordt
I and my team are struggling  this same issue mentioned in https://github.com/callowayproject/bump-my-version/pull/88#issuecomment-1817534528
This unique feature in not available in any of the other package on pypi.
Adding this feature will significantly improve our CI pipeline.
Request you to please consider this feature.

@hdhakernk The feature in #88 was about a Docker file. This is now a part of the repository, along with a GitHub action to provide automation.
To preview a new version, you can use the command bump-my-version show --increment <type> new_version to see it.
I'm not sure exactly what you are requesting. Can you provide a bit more clarification?

@coordt
i was interested in a CI command where i can provide current version along with required parameter.
in response I'm expecting new version
Syntax: bump-my-version show --increment <type> new_version --current_version "x.x.x"
eg 1:  bump-my-version show --increment minor new_version --current_version 1.0.0
output: 1.1.0
eg 2:  bump-my-version show new_version --increment patch  --current_version 1.0.0
output: 1.1.0
we can keep rest of all the config parameter in .config.toml as it is.
only current version can be overwrite by a new parameter.
it will reduce effort to update current version in  config file in order to get new

To summarize, would it work for you if I added a --current_version option to the bump-my-version show command?
That should be an easy addition.

@coordt
same i am expecting.

Version 0.29.0 should have that capability.


tooting from toot! - can't make toots

see error

Fascinating. We'll have to debug this with it connected against a live test server, unfortunately, which means I need to go dig out an ipad at some point.

this is fixed


Calculate luminosity of stars using realistic spectra

FRESCO calculates luminosities based on a blackbody spectrum. Using a spectral lines library would make for more realistic images, and would allow the use of narrow-band filters in the future.

UVBLUE and BLUERED libraries (http://www.inaoep.mx/~modelos/bluered/documentation.html) could be used for this.


BUG: pressing back on a page using the webcam causes a crash

BUG: pressing back on a page using the webcam causes a crash
DESCRIPTION
Steps to reproduce:

Go to the page where you scan your item or take a snackchat
Press back
Wait about a second and the app crashes

Expected behaviour:

Should go to the previous page

Observed behaviour:

App crashes (due to methods being called on objects that no longer exist)

See comment in #263 about buying an 'UNKNOWN'

This is technically complete


Test request URL being build correction

Test case for caseyamcl/phpoaipmh#20

And would be please create a new release, so that I can require a stable version :)

Hi @scheb.  Looks good.  I'll pull and tag a release later today.

Hi @scheb -- Just tagged Version 2.3

Thanks! :)


chore: upgrade snakeyaml version

What is the current behavior? (You can also link to an open issue here)
Old version of Snakeyaml
What is the new behavior?
Latest 1.26 version
One more change to https://github.com/Talend/components/pull/1617 PR - updating
services/components-api-service-rest/pom.xml.
Since in https://github.com/Talend/components/pull/1617 build https://ci-common.datapwn.com/job/components_pull-request_master/490/consoleFull 1.17 version can also be found.
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[x] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[x] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:

Pull request test result: success :star:


Refactor

I plan to make some updates to the cryptography library and some additional wrappers similar to the compression library but I will not be redesigning the library using the OOP model.


Bias sidebar documentation to autogenerated

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Description
Currently, the sidebar docs is first describing the sidebars.js API, and then going on to demonstrate how autogenerated configuration maps to the "old-style API". This is technically correct since autogenerated is just sugar over sidebars.js. However to most users this means they have to look up docs in two places—for example, for category index, they have to first find out the concept and accepted fields in https://docusaurus.io/docs/sidebar/items#category-link, and then how it's implemented in https://docusaurus.io/docs/sidebar/autogenerated#category-item-metadata. This is easily confusing.
I suggest we bias the docs towards autogenerated. I don't have solid plans on how that would work, but maybe we can first introduce how the file system maps to docs and categories, and then for each API, offer a tab set between sidebars.js and autogenerated.
Self-service

[X] I'd be willing to address this documentation request myself.

Yes agree to make this move
We didn't do that initially because users were more used to manually creating sidebars.
But now autogenerated sidebars are widely adopted and part of the initial template, I guess it makes sense to bias toward them.

根据接口返回生成侧边栏如何实现 求指导

@wqinglin Please, we are an international community and be inclusive by using English. Also, this issue is about autogenerating sidebar from files, not from external APIs.


Broken link on polymer pub page

Originally opened as dart-lang/sdk#20419
This issue was originally filed by<EMAIL_ADDRESS>
URL (if available): https://pub.dartlang.org/packages/polymer
Issue/feedback:
    The link to the TodoMVC example on the polymer pub page is broken:
    http://addyosmani.github.com/todomvc/

 Comment by sigmundch

Yes - i think so. Fix on it's way: https://codereview.chromium.org/457743003/

 Comment by kwalrath

Should the link be to http://todomvc.com/?

cc @sigmundch.
Removed Area-Site, Type-Defect labels.
Added Pkg-Polymer, Type-Documentation, Area-Pkg, Priority-Medium labels.

 Comment by jakemac53

looks like this was fixed in dart-lang/sdk@bcb99865b9d3d65a64254e676cc984c59a85faa5

Added Fixed label.


Make KEY_ID_ENCODES_OWNER compatible with USE_PSA_CRYPTO

Fix library references, tests and programs.
Testing is performed in the already present all.sh test.
Fixes #5259.

It seems that there is some problem with CI. pr-merge is green, but seems still running.

Yes, it happens occasionally. What's interesting is that each component of pr-merge (which is just the parent launching the actual jobs) reported success, but pr-merge itself didn't. I assume it's a glitch in reporting somewhere. Doesn't prevent merging of this PR anyway, but deserves to be noted for the record, as you did.

One line follow-up doc fix: https://github.com/ARMmbed/mbedtls/pull/5457


[request] Dimlet Storage System

Hey there.
While attempting to store lots and lots of dimlets it occurred to me that it would be pretty handy to have a catalogue system dedicated to their storage and retrial. I'm not sure if something like this is already in your plans but it would definitely help reduce the clutter.
At the moment the optimum method seems to be to stash them in a filing cabinet from extra utilities. Maybe you can come up with something better?

I also think that would be a great addition.
I dont know why but I was thinking of something that could be placed next to the enscriber and could be accessed from the describer menu. Similar as TiC workbenches can access nearby chests.
"Dimlet Archiver" storing all dimlets and neatly sorting them - with rf cost increasing by amount of dimlets stored.

Yes, this is still on my todo and I also considered the 'placing next to enscriber' idea. Currently busy with something else but I'll probably start on this after that has finished.


Fix Navigation bar items overlap

Description
Items in the navigation bar overlap when the window is sized down, narrowing it further sets it to a new row. Chrome does not have the overlapping issue, the solution is tested on both browser types and works as expected.
Issue
GitHub Issue #4872
JIRA: DOCK-2149
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that your code compiles by running npm run build
[x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[x] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[x] Do not use cookies, although this may change in the future
[x] Run npm audit and ensure you are not introducing new vulnerabilities
[x] Do due diligence on new 3rd party libraries, checking for CVEs
[x] Don't allow user-uploaded images to be served from the Dockstore domain

Same window size, before change:

After change:


local support

Does this support local models the way open interpreter does?

sadly this project does not include that feature still. feel  free to contribute if you want this feature, or if you can't be free to help us to add this and other more features contributing with a coffee.

I'm just evaluating tools at the moment and Python is definitely not my first language.  :) Thanks and good luck!

@chrisbraddock in latest commit was added local support through llmstudio and Ollama, take into consideration that can be used in cloud if you open your server maybe using ngrok to use directly in our demo in cloud if you like

I try ollama,but it couldn't work,can't connect localhost:11434,but webui is working fine.


Tan11389/scene grid app update

Description
Updates and renames the "Display Grid" sample to "Show Grid" and adds 3D functionality.
Type of change

[x] New sample implementation

Platforms tested on:

[x] Windows
[x] macOS

similar to what Lucas mentioned, I would request you possibly go back and git mv. Looks like everything is new rather than just an update. I'll do a review anyhow but just wanted to make the request.

A git mv would have been good, yeah -- back when I re did this sample in 200.5 however this was still using the old template style with the void DisplayGrid::componentComplete() way of doing things, so this really is a full delete of the old sample and addition of a new one with a different template but I can make some git changes.

@jared-2016 and @ldanzinger thank you a ton for your reviews so far. I believe I've been able to address most of your feedback but there were a few things I was a little unsure of. I've pushed up my changes and used "git mv" to track changes with the renamed files. If you want to see that specifically, you can view this specific commit: https://github.com/Esri/arcgis-maps-sdk-samples-qt/pull/1754/commits/08382f85af38483677c606da7ce2c3596e32e493
Thank you!

@tanneryould looks like this change requires updates to the sample viewer imports and initialization


Sonoff S60 "energy_day entities" missing attribute Device_class: energy

Hi!
First off all, thank you for integration.
I have four S60 Sonoff devices to use. They are recognized well within integration. There is only problem when adding them to the Energy dashboard. Adding gives me following error:
**Unexpected device class
The following entities do not have the expected device class:

sensor.sonoff_1002231aba_energy_day**

Device states in developer tools are:

What seems to be the issue? How do I add Device_class: energy to those entities?
Thank you in advance.
Best regards,
Tomaž

#1377


Cleanup

This PR:

uses file-scoped namespaces
adds readonly to readonly fields
seals classes that implement and interface
uses var when the other side is the type name
changes Interger to a struct

Excluding Integer -> struct change and sealing (preventing the user from subclassing to improve the ability for the JIT to devirtualize calls), all changes are focused on code readability.

@Genbox Ready for feedback / review.


FTUE: Remove Feature Flag

Feature Description
After feature has been through QA and UAT and stakeholders feel the feature is ready for users we need to remove the feature flag and the conditional code around it so that the flag is on by default.
This should be done in 2 parts.

PR that sets default: true on the existing feature flag. This is so that it can be easily reversed if something goes wrong.
After release, removing the actual feature flag and the conditional code.

Additional Context

Screencast: https://drive.google.com/file/d/1rAHJzuv9FNzTlVoVP5vHDoJm9zmQmkZv/view?usp=sharing

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
This ticket turns on the help center first time user experience that shows on the bottom left (ltr) or right (rtl) of the canvas section of the editor. All functionality from tickets included in MVP of epic should be testable by default at this point.

There should be a button that says "help", clicking or hitting enter/space on this button should expand the help center.
The help center should have 7 "tips" as a main menu
You can click any tip from the main menu and cycle through the available content.
Each tip should have an accompanying graphic
As you view tips, the 'unread' count on the badge displayed on the 'help' button should decrease.
When you have no more unread tips you should no longer see the badge icon but a chevron instead.
When you go to the last tip you should see a done screen.
You should only see the done screen after you have read all the tips no matter what order you began in.
If you exit the help center and come back you should always begin on the main menu that has all 7 tips with arrows displayed.
Your read count should be maintained on all sessions.

If you need to clear out your read tips type this and hit 'enter' in your console:
await wp.apiFetch({ path: '/web-stories/v1/users/me', method: 'POST', data: { meta: { web_stories_onboarding: {} }}})

@csossi this is needed for the release that's scheduled for feb 16, if there's anyway you can prioritize it!

Verified in QA


Helper to get link to page

Function that takes a string or a component as input and returns a string containing the URL to the page

Included in version:
https://github.com/byr0n3/react-even-better-router-dom/releases/tag/0.0.2


Start adding localization

Excuse me, but would you test to see if what I have localized so far works.

If it does work, I will finish the localizations.

Thanks for the contribution Aaron! Unfortunately, I have very limited time because I'm finishing my master thesis this month. Could you try to setup your own bot on own server and test it? I've added a quick guide how to do it in the readme.
Overall, your proposed solution has a lot defects, namely unused variables, wrong formatting etc. but more importantly I doubt it is able to handle multi-language load. The bot may listen on multiple servers that have to be independent - from the language perspective.
Side note: The Discord.NET library that I depend on released its 2nd version a few months ago. I still did not upgrade thought. I would do some research how does other bots handle localisation, maybe they did add some native support or somebody created an extension for it.

I managed to get it to work on my server properly. I fixed things up. I decided against a localization service because it was unnecessary. That functionality was built into C# projects by default. Updating to the newest version of Discord.NET is going to be a pain, if trying to update the clean module and then reverting back to a prior version were an indicator. There's more places where the summary needs to be changed to a key name however.

I really appreciate your effort but can you revert cosmetic changes, please? It is really painful to do a code review that literally changes all files. For instance adding/removing private access modifier, change from explicit type to var vice versa, adding/removing brackets, adding/removing white spaces, newline at the end of file, converting standard methods to arrow functions etc.

I will do my best to try to undo my cosmetic changes.


Perform first release

Please close this issue when the first release is performed. Instructions are available here: https://github.com/quarkiverse/quarkiverse/wiki/Release
Feel free to reach us out if you have any questions.
Thank you!

Release 0.1.0
https://search.maven.org/search?q=g:io.quarkiverse.hibernatetypes AND a:quarkus-hibernate-types-parent

Release 0.1.0
https://search.maven.org/search?q=g:io.quarkiverse.hibernatetypes AND a:quarkus-hibernate-types-parent


fixed pillow and numpy version

Fixed deprecated PIL.Image.ANTIALIAS method. Also set numpy<2 as there is not a numpy 2 compatible build for opencv at the moment. See https://github.com/opencv/opencv-python/issues/943.

Moin @jonas-amme,
do you need a new pip package?

Hi @ChristianMarzahl,
I just needed a quick update on the dependencies to get it running again. A new pip package would still be useful for future integrations with Exact tho ;)


docs(protocol): fix some typos

fix some typos
SchmaWithId  -> SchemaWithId
only inserte if addresss doesnt exist -> only insert if address doesn't exist
priorioty -> priority

@momodaka thanks for your contribution, but unfortunately we won't accept small typo PRs from now, as they are too numerous.
Instead, I have opened this more comprehensive GitHub issue here, if you are interested in it, I can assign it to you: https://github.com/taikoxyz/taiko-mono/issues/16488

Thank you for your response and for opening issue #16488. I appreciate the opportunity and am eager to contribute.

Thank you for your response and for opening issue #16488. I appreciate the opportunity and am eager to contribute.

can you comment on that issue #16488 ? I need you to comment on it so that I can assign it to you :)


Fixes #171

This fixes the bug that you can't download e-mails if you are using "maildir" as storage type.

is there a PR for this to go into Mailhog-server first?

No and I don't think I would create one at the current state of the project.

@Grotax
He means you should create PR to repo https://github.com/mailhog/MailHog-Server instead

I got that but as said... maybe another time, if the pr is not wanted here we can close it.

it's a valuable addition, but it needs to go into the right repo, please leave this open as a reminder


Added australia and tungsten cube

Added shroom wtih tungsten cube as commerical, and also the australian pamphlet, both written by ChatGPT

sahroom

blurboory


Allow nested packages for @Modulith(sharedModules)

Current Behavior
The sharedModules parameter of the @Modulith annotation does not allow nested packages, even when the nested packages are explicitly listed.
package structure -  com.app.core.exception
@Modulith(sharedModules={"com.app.core"}, useFullyQualifiedModuleNames = true) and @Modulith(sharedModules={"com.app.core", "com.app.core.exception"}, useFullyQualifiedModuleNames = true) result in java.lang.IllegalArgumentException: Module com.app.core.exception does not exist!
@Modulith(sharedModules={"com.app.core"}, additionalPackages = { "com.app.core.exception"}, useFullyQualifiedModuleNames = true) results in
Module 'com.app.user' depends on non-exposed type com.app.core.exception.EntityNotFoundException within module 'com.app.core'!
Desired Behavior
Allow for wildcard(1) or explicitly listed(2) sub-packages to be referenced within all modules.
1 @Modulith(sharedModules={"com.app.core.*"}, useFullyQualifiedModuleNames = true)
2 @Modulith(sharedModules={"com.app.core", "com.app.core.exception"}, useFullyQualifiedModuleNames = true)
Workaround
change package structure to com.app.core and com.app.exception with @Modulith(sharedModules={"com.app.core", "com.app.exception"}, useFullyQualifiedModuleNames = true)

There simply is no such thing as nested modules, yet. In other words, if a module named com.app.core exists, no module com.app.core.exception can exist at all. Note, that the attribute is sharedModules, not sharedPackages. That the module names look like packages is a side effect of the setting to enable qualified module names.
Can you take a step back and elaborate why you think you'd need to list that nested package in the first place?

Thanks for getting back to me so quickly!  I am VERY new to modulith concepts so appreciate your input and guidance.
I have a set of common classes in 3 packages that will be used across all modules, e.g. exceptions., response. and util.*.  The only way I could get the .verify() to work was to add a sharedModules annotation for each fully qualified package.  Ideally, from my perspective, I would be able to have these packages in the same hierarchy (com.app.core) and just use it in the sharedModules annotation.
Is there another way to indicate that a class is shared across modules?

From: Oliver Drotbohm @.>
Sent: Friday, March 8, 2024 8:17 AM
To: spring-projects/spring-modulith @.>
Cc: Timothy Vogel @.>; Author @.>
Subject: Re: [spring-projects/spring-modulith] Allow nested packages for @Modulith(sharedModules) (Issue #524)
There simply is no such thing as nested modules, yet. In other words, if a module named com.app.core exists, no module com.app.core.exception can exist at all. Note, that the attribute is sharedModules, not sharedPackages. That the module names look like packages is a side effect of the setting to enable qualified module names.
Can you take a step back and elaborate why you think you'd need to list that nested package in the first place?
—
Reply to this email directly, view it on GitHubhttps://github.com/spring-projects/spring-modulith/issues/524#issuecomment-1985680852, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACBEBVWIBDWGL7EICZKX5ZLYXG277AVCNFSM6AAAAABELN2L4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBVGY4DAOBVGI.
You are receiving this because you authored the thread.

No worries. I am a bit surprised you state that you could get this to work, as the shared modules definition is not even considered during the verification. The Javadoc of the attribute clearly states that it's used to define modules that are supposed to be included in integration test executions (using @ApplicationModuleTest) but it will not change anything about the outcome of a AppplicationModules.of(…).verify().
As documented here, nested packages of application module base packages are considered internal and other modules are not allowed to refer to code within those by default. I.e., it is not surprising that references to those would break the verification. To expose such types to other packages, the package they reside in needs to be declared a named interface.
We generally discourage the use of packages to group types by their stereotype (exceptions, controllers, services etc. getting their own package) as that fundamentally subverts the encapsulation effects of packages. That said, Spring Modulith 1.2 will ship with the notion of an “open module”, which would also expose its externals (in other words: all nested packages) to other modules.
If you find the time, it would be helpful to look at a reproducer as that allows us to find out what we're really talking about here.

As you indicated, sharedModules did in fact NOT enable me to use nested packages.  The test was green b/c I made them top level packages therefore modules (duh on my part).
2.
After a bit of time to RTFM, what I need is @NamedInterface to make my original package layout work.
3.
WRT grouping types by stereotype, I have top-level packages, i.e. modules, named with Domain model names.  Within those top-level packages, I was grouping by stereotype.  Is that also discouraged?  If so what sub-package approach do you recommend?

From: Oliver Drotbohm @.>
Sent: Saturday, March 9, 2024 9:25 AM
To: spring-projects/spring-modulith @.>
Cc: Timothy Vogel @.>; Author @.>
Subject: Re: [spring-projects/spring-modulith] Allow nested packages for @Modulith(sharedModules) (Issue #524)
No worries. I am a bit surprised you state that you could get this to work, as the shared modules definition is not even considered during the verification. The Javadoc of the attribute clearly states that it's used to define modules that are supposed to be included in integration test executions (using @ApplicationModuleTest) but it will not change anything about the outcome of a AppplicationModules.of(…).verify().
As documented herehttps://docs.spring.io/spring-modulith/reference/fundamentals.html#modules.advanced, nested packages of application module base packages are considered internal and other modules are not allowed to refer to code within those by default. I.e., it is not surprising that references to those would break the verification. To expose such types to other packages, the package they reside in needs to be declared a named interfacehttps://docs.spring.io/spring-modulith/reference/fundamentals.html#modules.named-interfaces.
We generally discourage the use of packages to group types by their stereotype (exceptions, controllers, services etc. getting their own package) as that fundamentally subverts the encapsulation effects of packages. That said, Spring Modulith 1.2 will ship with the notion of an “open module”, which would also expose its externals (in other words: all nested packages) to other modules.
If you find the time, it would be helpful to look at a reproducer as that allows us to find out what we're really talking about here.
—
Reply to this email directly, view it on GitHubhttps://github.com/spring-projects/spring-modulith/issues/524#issuecomment-1986870800, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACBEBVUJKABGNIQLUJOM5D3YXMLVRAVCNFSM6AAAAABELN2L4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWHA3TAOBQGA.
You are receiving this because you authored the thread.

Hello @odrotbohm ,
Firs thanks for your work on Spring, it's always a great pleasure to work with it.
We started using Modulith on a project and it allows us to detect invalid dependencies. But the nested item is not clear for me.
Regarding your comment "To expose such types to other packages, the package they reside in needs to be declared a named interface."
You reference this:

The effect of that declaration is twofold: first, code in other application modules is allowed to refer to SomeSpiInterface. Application modules are able to refer to the named interface in explicit dependency declarations. Assume the inventory module was making use of that, it could refer to the above declared named interface like this:
..

I have 2 questions:

If you have nested packages, is this expected to work foo::nestedlevel1::nestedlevel2 ? I understand it's not recommended. Maybe the last point should be added or highlighted to documentation, I may have missed it.
Regarding "For modules without explicitly described dependencies, both the application module root package and the SPI one are accessible.", it's not clear, do it mean that if another module (not nested) does not declare any AllowedDependencies it would be the foo and all NamedInterface in it ?


Submit Desert Heater Base loot procs as convertible

With the influx of Discord screenshots showcasing Desert Heater Base's ability to generate jackpot loots such as FW trap/portal parts, Launch Boxes, H/I essences, Aromatic Oils and more, I thought it'd be useful to piggyback off of the existing active horn response handling to parse DHB's bonus journal entry and submit it as a standard convertible.
Sample HAR file for testing

Should work OK. I opened #77 to update this branch to be more explicit / guarded against blindly splitting and indexing the result, in case the format changes. Currently, neither this PR or #77 will handle more than a single kind of item being dropped -- not sure if that's gonna be a thing.
@DevJackSmith what sorts of journal entries are you not interested in tracking? There are a number of bonus loot journals across different setup combinations, but not all are equally interesting (such as ones where the outcome is guaranteed, like a +1 mist).

Oops, didn't notice that you opened your PR from this branch. Will merge this in now and take the conversation about additional bonus journal entries to https://github.com/mh-community-tools/mh-helper-extension/issues/78.
Re: handling more than a single item from DHB - we haven't seen an instance of this so far, and I highly doubt we will. I can't think of another piece of equipment that generates multiple items either. Without an example to test on I don't think it's necessary/possible to properly handle that.


adding retries to critical api requests

Codecov Report

Merging #231 into master will decrease coverage by 0.42%.
The diff coverage is 47.36%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   62.62%   62.19%   -0.43%
==========================================
  Files          40       40
  Lines        3058     3074      +16
  Branches      364      366       +2
==========================================
- Hits         1915     1912       -3
- Misses       1049     1069      +20
+ Partials       94       93       -1

Impacted Files
Coverage Δ

core/clients/docker_client.py
46.31% <100%> (ø)
:arrow_up:

core/utils/__init__.py
49.62% <37.5%> (-1.66%)
:arrow_down:

vmpool/endpoint.py
80% <0%> (-10%)
:arrow_down:

vmmaster/webdriver/helpers.py
65.16% <0%> (-2.59%)
:arrow_down:

vmpool/clone.py
57.47% <0%> (-0.67%)
:arrow_down:

core/auth/custom_auth.py
67.39% <0%> (+2.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcbd9f...7f9638b. Read the comment docs.


Memory warning when loading files via CommonsExtension

Often, when starting a new project via the CommonsExtension, OpenRefine will warn about memory issues in big red angry words.
The project is usually not that large, though.

This issue is not specific to the Commons Extension but happens in OpenRefine generically. I'll leave this open for now though.


Pass additional metadata from alert to event

Depends on #14295 [merged]

@miq-bot add_label enhancement, providers/containers, wip

@miq-bot remove_label wip
(dependency merged)

@gmcculloug can you please review?

@simon3z @gmcculloug could you please review?

@gmcculloug could you take another look please

Code-wise LGTM :+1:
Anyway this is more about the implications on the core infrastructure. I'll leave to @gmcculloug to evaluate that (e.g. is this playing nicely with all providers, etc.)
@miq-bot assign gmcculloug

@gmcculloug please take another look

@moolitayer Please label fine/yes or fine/no

@miq-bot add_label fine/no


[Feature Request]:  Add copyright details section

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Hey, @HimanshuNarware I would like to add the copyright details section in the footer section.
Use Case
I would like to ass the copyright details which is important as it helps to protect the value of an author/academic/researchers work, by giving the originator of the work the ability to protect it from unlicensed or uncredited usage.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@HimanshuNarware please assign this task, I want to work on this

Can you assign me this issue @HimanshuNarware

Ok @Saimanjari777

Hii @PSS2134 i have requested first to assign this issue ?


rofi-file-browser: 1.2.0 -> 1.3.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/rofi-file-browser-extended/versions.
meta.description for rofi-file-browser is: "Use rofi to quickly open files"
meta.homepage for rofi-file-browser is: "https://github.com/marvinkreis/rofi-file-browser-extended"
meta.changelog for rofi-file-browser is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.3.0 in filename of file in /nix/store/84h4gx1lm7dyx97lgaph8nicmncn2hma-rofi-file-browser-extended-1.3.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
rofi-file-browser

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/84h4gx1lm7dyx97lgaph8nicmncn2hma-rofi-file-browser-extended-1.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A rofi-file-browser https://github.com/r-ryantm/nixpkgs/archive/47c36939d57fe12c3d6a68d010fa4e2eb540dbfd.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/84h4gx1lm7dyx97lgaph8nicmncn2hma-rofi-file-browser-extended-1.3.0
ls -la /nix/store/84h4gx1lm7dyx97lgaph8nicmncn2hma-rofi-file-browser-extended-1.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

rofi-file-browser

Maintainer pings
cc @jluttine for testing.

@ofborg eval


ci: change to Xenial-based VM

Curious whether we’ll see any meaningful performance difference.
Ref.: https://docs.travis-ci.com/user/reference/overview/
wchargin-branch: travis-xenial

Closing per https://github.com/tensorflow/tensorboard/pull/2293#issuecomment-497389240.


Remove -e , --config and --observe options

Purpose
ballerina run has above additional optional which is not consistent with java jar command. Hence removed.
Config passing, enabling observability and pass config can be done as below.
java -jar main-exectable.jar --b7a.config=/home/waruna/ballerina.conf
--b7a.observability.enabled=true

Same way with ballerina run
ballerina run main-exectable.jar --b7a.config=/home/waruna/ballerina.conf
--b7a.observability.enabled=true

Fixes #18547 and #18555
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Will send sepearte PRs  examples and cli doc changes.

Codecov Report

Merging #18633 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #18633   +/-   ##
=======================================
  Coverage   15.15%   15.15%
=======================================
  Files          48       48
  Lines        1254     1254
  Branches      197      197
=======================================
  Hits          190      190
  Misses       1050     1050
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c4cee...22b2abb. Read the comment docs.


https://docs.asp.net/en/latest/data/index.html need pointer to http://docs.efproject.net/en/latest/index.html

customer found this page confusing, so did I.
https://github.com/aspnet/Docs/issues/72#issuecomment-163796450
Need link to EF7 http://docs.efproject.net/en/latest/index.html

Two of the links on https://docs.asp.net/en/latest/data/index.html already point to the EF7 docs. I've submitted a PR to clean up this page to make that clearer.


Refactored componentWillUpdate into getDerivedStateFromProps

Fix for issue: #61

Thanks for review/merge. Is there an npm update planned in near future?

Soon. Turns out that CI is dead. It's now fixed, but still have some testing issues.

5.2.0 has released.


Chart type dropdowns don't repopulate as "bar" if that is selected.

Via UAT group:

log into CMS
click Add New Post
click on Add Media
add a chart
click to edit the chart by clicking on the icon in left hand corner
change chart from Line to Bar in Data Options
click Copy to CMS
close edit by clicking on the X
re-open edit
view the Data Options drop downs

Something fixed this and I have no idea what it is. WOOOOOO GO MEEEEEE! :tada:


LD Blocks are not filtered correctly.

This is probably due to a type mismatch when looking at the chromosomes. I should make a habit to enforce types when reading data into dataframes.

false alarm


feat: refactor ApisixPluginConfig and add e2e cases

Type of change:

[ ] Bugfix
[x] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

Pre-submission checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Codecov Report

Merging #815 (18f0978) into master (819b003) will decrease coverage by 0.41%.
The diff coverage is 24.47%.

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
- Coverage   32.55%   32.13%   -0.42%
==========================================
  Files          68       70       +2
  Lines        7284     7726     +442
==========================================
+ Hits         2371     2483     +112
- Misses       4643     4968     +325
- Partials      270      275       +5

Impacted Files
Coverage Δ

pkg/apisix/apisix.go
61.36% <ø> (ø)

pkg/apisix/cluster.go
32.57% <0.00%> (-1.07%)
:arrow_down:

pkg/ingress/apisix_pluginconfig.go
0.00% <0.00%> (ø)

pkg/ingress/apisix_route.go
0.00% <0.00%> (ø)

pkg/ingress/compare.go
0.00% <0.00%> (ø)

pkg/ingress/controller.go
0.94% <0.00%> (-0.03%)
:arrow_down:

pkg/ingress/ingress.go
6.81% <0.00%> (-0.08%)
:arrow_down:

pkg/ingress/status.go
0.00% <0.00%> (ø)

pkg/kube/translation/translator.go
46.07% <ø> (ø)

pkg/kube/translation/apisix_route.go
21.82% <35.71%> (+0.79%)
:arrow_up:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819b003...18f0978. Read the comment docs.


Add url metadata to SimpleWebPageReader

Description
I have ported the base file reader metadata functionality to the SimpleWebReader.
Type of Change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?

[x] Added new unit/integration tests
[x] I stared at the code and made sure it makes sense

Suggested Checklist: (In progress)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Cool! Can you make a similar PR to llama-hub as well?
https://github.com/emptycrown/llama-hub/blob/main/llama_hub/web/simple_web/base.py


Update architecture documentation

Current version of architecture documentation doesn't even mention the aadarchi-maven-plugin

Fixed in 612124c201ba60021f08fbd7db1857b27283bc0c


FID of FFHQ model does not match reported value

I am attempting to use the FFHQ model provided to generate images that will give the same FID result as reported in the paper (3.39), but I instead get FID=4.36.
I am also generating images and calculating the ffhq 256 x256 FIDs of various other generative models (Stylegan-XL, StyleNAT, etc..) and found that my local version is consistent with what was reported, so I do not believe the error is on my end. Please let me know if it is.
Is the model that matches the reported FIDs available? Or is there a set of publicly available set of 100k generated ffhq256 images?
command and result below:
python calc_metrics.py --metrics=fid50k_full --network=https://s3.eu-central-1.amazonaws.com/avg-projects/projected_gan/models/ffhq.pkl --data=data/ffhq256/
Loading network from "https://s3.eu-central-1.amazonaws.com/avg-projects/projected_gan/models/ffhq.pkl"...

{"results": {"fid50k_full": 4.366911864743968}, "metric": "fid50k_full", "total_time": 1171.9112825393677, "total_time_str": "19m 32s", "num_gpus": 1, "snapshot_pkl": "https://s3.eu-central-1.amazonaws.com/avg-projects/projected_gan/models/ffhq.pkl", "timestamp":<PHONE_NUMBER>.6151838}

Having the same result as you:
{"results": {"fid50k_full": 4.300614431220116}, "metric": "fid50k_full", "total_time":<PHONE_NUMBER>840759, "total_time_str": "9m 18s", "num_gpus": 1, "snapshot_pkl": "https://s3.eu-central-1.amazonaws.com/avg-projects/projected_gan/models/ffhq.pkl", "timestamp":<PHONE_NUMBER>.8560216}


flutter/games The endless_runner has an overflow on the win screen

Steps to reproduce

Clone the flutter/games repository
Run the templates/endless_runner template game using the macos desktop runner
Beat the first level
Get the "Well done!" congrats screen... with an overflow

Expected results
I'd love the well done screen to not have an issue.
Actual results

Code sample
Code is from endless_runner template, running unchanged
Screenshots or Video
No response
Logs
Logs

The relevant error-causing widget was:
    Column Column:file:///Users/brettmorgan/Documents/GitHub/games/templates/endless_runner/lib/flame_game/game_win_dialog.dart:34:16

: To inspect this widget in Flutter DevTools, visit: http://<IP_ADDRESS>:9109/#/inspector?uri=http%3A%2F%2F<IP_ADDRESS>%3A60662%2FDjdoToQBV8E%3D%2F&inspectorRef=inspector-0

The overflowing RenderFlex has an orientation of Axis.vertical.
The edge of the RenderFlex that is overflowing has been marked in the rendering with a yellow and black striped pattern. This is usually caused by the contents being too big for the RenderFlex.
Consider applying a flex factor (e.g. using an Expanded widget) to force the children of the RenderFlex to fit within the available space instead of being sized to their natural size.
This is considered an error condition because it indicates that there is content that cannot be seen. If the content is legitimately bigger than the available space, consider clipping it with a ClipRect widget before putting it in the flex, or using a scrollable container rather than a Flex, like a ListView.
The specific RenderFlex in question is: RenderFlex#07bea OVERFLOWING
    parentData: offset=Offset(32.0, 32.0) (can use size)
    constraints: BoxConstraints(w=356.0, h=216.0)
    size: Size(356.0, 216.0)
    direction: vertical
    mainAxisAlignment: center
    mainAxisSize: max
    crossAxisAlignment: center
    verticalDirection: down
    child 1: RenderParagraph#68477 relayoutBoundary=up1
        parentData: offset=Offset(38.0, 0.0); flex=null; fit=null (can use size)
        constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
        size: Size(280.0, 36.0)
        textAlign: center
        textDirection: ltr
        softWrap: wrapping at box width
        overflow: clip
        locale: en_US
        maxLines: unlimited
        text: TextSpan
            debugLabel: (englishLike headlineMedium 2021).merge(((((blackRedwoodCity headlineMedium).apply).copyWith).copyWith).apply)
            inherit: false
            color: Color(0xee352b42)
            family: PressStart2P_regular
            familyFallback: PressStart2P
            size: 28.0
            weight: 400
            letterSpacing: 0.0
            baseline: alphabetic
            height: 1.3x
            leadingDistribution: even
            decoration: Color(0xff1c1b1f) TextDecoration.none
            "Well done!"
    child 2: RenderConstrainedBox#75e8f relayoutBoundary=up1
        parentData: offset=Offset(178.0, 36.0); flex=null; fit=null (can use size)
        constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
        size: Size(0.0, 16.0)
        additionalConstraints: BoxConstraints(0.0<=w<=Infinity, h=16.0)
    child 3: RenderParagraph#41e55 relayoutBoundary=up1
        parentData: offset=Offset(0.0, 52.0); flex=null; fit=null (can use size)
        constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
        size: Size(356.0, 40.0)
        textAlign: center
        textDirection: ltr
        softWrap: wrapping at box width
        overflow: clip
        locale: en_US
        maxLines: unlimited
        text: TextSpan
            debugLabel: (englishLike bodyMedium 2021).merge(((((blackRedwoodCity bodyMedium).apply).copyWith).copyWith).apply)
            inherit: false
            color: Color(0xee352b42)
            family: PressStart2P_regular
            familyFallback: PressStart2P
            size: 14.0
            weight: 400
            letterSpacing: 0.3
            baseline: alphabetic
            height: 1.4x
            leadingDistribution: even
            decoration: Color(0xff1c1b1f) TextDecoration.none
            "You completed level 1 in 27 seconds."
    child 4: RenderConstrainedBox#bd0b9 relayoutBoundary=up1
        parentData: offset=Offset(178.0, 92.0); flex=null; fit=null (can use size)
        constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
        size: Size(0.0, 16.0)
        additionalConstraints: BoxConstraints(0.0<=w<=Infinity, h=16.0)
    child 5: RenderMouseRegion#07ddb relayoutBoundary=up1
        parentData: offset=Offset(99.5, 108.0); flex=null; fit=null (can use size)
        constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
        size: Size(157.0, 48.0)
        behavior: opaque
        listeners: enter, exit
        child: RenderSemanticsGestureHandler#3df9e relayoutBoundary=up2
            parentData: <none> (can use size)
            constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
            size: Size(157.0, 48.0)
            behavior: deferToChild
            gestures: tap
            child: RenderPointerListener#b2b9e relayoutBoundary=up3
                parentData: <none> (can use size)
                constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
                size: Size(157.0, 48.0)
                behavior: deferToChild
                listeners: down, panZoomStart
                child: RenderCustomPaint#767ff relayoutBoundary=up4
                    parentData: <none> (can use size)
                    constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
                    size: Size(157.0, 48.0)
                    painter: _ButtonPainer#142cb()
    child 6: RenderConstrainedBox#9e960 relayoutBoundary=up1
        parentData: offset=Offset(178.0, 156.0); flex=null; fit=null (can use size)
        constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
        size: Size(0.0, 16.0)
        additionalConstraints: BoxConstraints(0.0<=w<=Infinity, h=16.0)
    child 7: RenderMouseRegion#37df8 relayoutBoundary=up1
        parentData: offset=Offset(68.3, 172.0); flex=null; fit=null (can use size)
        constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
        size: Size(219.5, 48.0)
        behavior: opaque
        listeners: enter, exit
        child: RenderSemanticsGestureHandler#a6e1f relayoutBoundary=up2
            parentData: <none> (can use size)
            constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
            size: Size(219.5, 48.0)
            behavior: deferToChild
            gestures: tap
            child: RenderPointerListener#69539 relayoutBoundary=up3
                parentData: <none> (can use size)
                constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
                size: Size(219.5, 48.0)
                behavior: deferToChild
                listeners: down, panZoomStart
                child: RenderCustomPaint#4c05b relayoutBoundary=up4
                    parentData: <none> (can use size)
                    constraints: BoxConstraints(0.0<=w<=356.0, 0.0<=h<=Infinity)
                    size: Size(219.5, 48.0)
                    painter: _ButtonPainer#2d055()
════════════════════════════════════════════════════════════════════════════════

Flutter Doctor output
Doctor output
[✓] Flutter (Channel beta, 3.19.0-0.3.pre, on macOS 14.3 23D56 darwin-arm64, locale en)
    • Flutter version 3.19.0-0.3.pre on channel beta at /Users/brettmorgan/flutter
    • Upstream repository https://github.com/flutter/flutter
    • Framework revision 1b197762c5 (12 days ago), 2024-01-25 22:23:26 -0800
    • Engine revision 968e2945c7
    • Dart version 3.3.0 (build 3.3.0-279.2.beta)
    • DevTools version 2.31.0

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/brettmorgan/Library/Android/sdk
    • Platform android-34-ext8, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.15.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Community Edition (version 2023.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 77.0.1
    • Dart plugin version 233.13135.65

[✓] VS Code (version 1.86.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.82.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 14.3 23D56 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 121.0.6167.139

[✓] Network resources
    • All expected network resources are available.

• No issues found!

PTAL @spydon

Thanks for the ping @domesticmouse, apparently there had been some update to nes_ui that made the elements take a bit more space.


[hi] Localize application-architect.md

Signed-off-by: Bishal Das<EMAIL_ADDRESS>Localizes content/en/docs/reference/glossary/application-architect.md to Hindi content/hi/docs/reference/glossary/application-architect.md
Fixes :- #35944

@divya-mohan0209 @anubha-v-ardhan
Could you please leave some suggestion for this PR
It would be really helpful
__
  Summary: :hammer_and_wrench: This code needs a fix

/assign @mittalyashu
__
  Summary: :hammer_and_wrench: This code needs a fix

@bishal7679 : PTAL at this PR whenever free.

@bishal7679 I'd recommend अमल since it seems simpler.
Also, you'll need to sync your fork and pull the latest branch changes for ALL your PRs

@Babapool @verma-kunal @Garima-Negi @anubha-v-ardhan : PTAL


Enhancement: Update md output mode to exclude nested properties in md output mode.

Related to #4150 where we determined that the csv output mode should show all properties, except nested objects. Nested objects should only be visible when expressly selected using the --query option.
This issue is solved when the same is applied to md:

exclude nested options by default.
include nested options only when --query is used.

Let's clarify the spec: nested properties should be available for querying, but in the end will still be removed, because we can't render them in a meaningful way in md.

That's the same for csv though. I'd say: keep it the same, if people want to show them they can. Who knows what they'll do with the output. Maybe they'll do some further processing.

Correct. I only mentioned md here, because this issue refers specifically to md format, but indeed, md and csv would be the same.

I'd say: keep it the same, if people want to show them they can

I don't think there's anything you could achieve with such output, so I'd say let's take it out. If we find a better way to go about it, we can always add it.

I would like to give this a go

Nice to hear @nicodecleyre, it's all yours!


the gradient of sinkhorn layer

Sorry, I don't find backward of sinkhorn layer. So how do you use the gradient of this layer. I really need your help.

Hi,
The Sinkhorn layer (https://github.com/pemami4911/sinkhorn-policy-gradient.pytorch/blob/e029640397b77571b33df887f524b6ba2009e2c1/spg/layers.py#L10) is differentiable, and PyTorch will compute its gradient automatically whenever .backward() is called on the SPG loss (e.g., https://github.com/pemami4911/sinkhorn-policy-gradient.pytorch/blob/e029640397b77571b33df887f524b6ba2009e2c1/train_spg.py#L395)
Hope this helps!


Viewmat gradient backward to optimize camera position

Hi @vye16  and @kerrj
In order to re activate camera pose opt in nerfstudio, I cherry pick the gradient backward proposed in branch : https://github.com/nerfstudio-project/gsplat/tree/vickie/camera-grads
My tests were not really good.
Did you get any plan to continue with this feature ? Anyway I could help on it ? Any idea how we could test properly.
thanks

Hi few more experiments on my side:
I used camera poses directly got from pandaset:
we got this reconstruction:

I added gaussian noise on trainset camera poses:

translations : sigma .2m (in real world coordinate, before rescale in -1 1 cube)
rotation : sigma 1degree

of course the reconstruction is very bad like that:

When I activate camera pose optimization I get this one:

It difficult to compare metric because even if I didn't add noise to eval set, the "world" seems to be not reconstructed exactly at the same position. So eval metrics are badly similar for noisy and optimized poses. But we could have a look at train psnr (noisy_notInEval2, is the optimize one):

By carefully manually review images between no noise and optimized poses version, optimized is a little less quality. But in another hand I now that in my in case, even with no noise, when I render on shift trajectory the quality decrease.


Reduce RBAC grants for CCM

Even though CCM is rather highly privileged process on the cluster, for the sake of lease privilege principle and to better describe what CCM actually touches, current RBAC rules could be reduced. For example:

Currently ClusterRole is used for endpoints objects. This could be moved to Role in deployment namespace.
Currently ClusterRole is used for  coordination.k8s.io objects. This could be moved to Role in deployment namespace.
Currently ClusterRole is used for configmaps objects to manage MetalLB ConfigMap. This could possibly be reduced to only metallb-system namespace. Do note, that this will also require binding extension-apiserver-authentication-reader system role to be able to read extension-apiserver-authentication ConfigMap.

This could possibly be reduced to only metallb-system namespace.

It cannot. We give the user the option to use the configmap in any namespace. Sure, most use it in metallb-system, but it is not restricted there.
For the rest, open a PR for it?

It cannot. We give the user the option to use the configmap in any namespace. Sure, most use it in metallb-system, but it is not restricted there.

Make sense :+1:

For the rest, open a PR for it?

I can't promise that I'll find time to do that.

/reopen

/remove-lifecycle rotten

/triage accepted


Add CRI installation instructions page

What this PR does / why we need it:
Added cri-installation page with CRI installation instructions
Referenced it from kubeadm-init and install-kubeadm pages.
Which issue this PR fixes
Fixes: kubernetes/kubeadm#1086, kubernetes/website#9692
Release note:
NONE

/assign @Bradamant3 @timothysc
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews

@bart0sh @neolit123 the original PR is now closed. This looks good now.

@neolit123

this should be against the release-1.12 branch

Thanks for pointing this out. Will rebase this or create new PR.
Note, this is work in progress. Things I'm considering to do:

Add CRI-O instructions
Remove Docker instructions from https://kubernetes.io/docs/setup/independent/install-kubeadm/#installing-docker to avoid duplication

@bart0sh Docs PRs must be merged by 9/18. Please rebase and finish up any WIP items by then. Thanks!

Tested docker installation on Ubuntu 16.04 and Centos 7.5
The only part left is CRI-O instructions. Will do it right away.

Added CRI-O installation instructions.

@timothysc @Bradamant3

Docs PRs must be merged by 9/18. Please rebase and finish up any WIP items by then. Thanks!

I think I'm done with this. Please review and approve.

thanks @bart0sh
IMO this looks good for 1.12,
if we have errors or if something has to be changed, we can quickly amend shortly after the release.
/lgtm

@neolit123 Thank you! BTW, should I send this to master as well?

@bart0sh

Thank you! BTW, should I send this to master as well?

no, there is no need.

As this PR is not merged yet I did a bit markup changes to make the page looking a bit better.
Now it's ready to be merged.

@bart0sh
thanks, had a look at the page myself again.
/lgtm

@kubernetes/sig-docs-pr-reviews  - We are good to go, merge request, please.

/approve


⚠ Fortnite has degraded performance

In 91e30fd, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1555 ms

Resolved: Fortnite performance has improved in 058c13a.


Typo in course Quantum Business Foundations

URL to the relevant documentation
https://learning.quantum.ibm.com/course/quantum-business-foundations/quantum-computing-fundamentals
In the section How quantum computing is different from classical, at the end of the first paragraph, the documentation states At any point in the computation, a classical computer’s state is entirely determined by the states of all its bits, so that a computer with n bits can exist in one of 2n possible states
Select all that apply

[x] typo
[ ] code bug
[ ] out-of-date content
[ ] broken link
[ ] other

Describe the fix.
It should say At any point in the computation, a classical computer’s state is entirely determined by the states of all its bits, so that a computer with n bits can exist in one of 2^n possible states

Hello! I will pass this along to the IBM Quantum Learning team. Thanks for reporting!

Hi All. This is fixed. But it turns out it wasn't a typo. Directus is failing to parse html tags like  and <\sub> and actually undoes corrections to the syntax! I fixed it by using latex notation. But this likely indicates a TON of other such instances. Doing a review now. Thanks for calling my attention to this.

I don't have permission to close the issue.


Fixes to preserve custom collections

Update mutators to preserve collection type
Allow creating from a collection
Allow copying the wrapped collection via a collection() accessor

Fixes #62

ping?

Ping @Im0rtality ?


Create SDK repository

Create SDK repository
Summary
At each new release of SciCat BE, we want to auto generate all the supported SDKs in a separate repositories.
The objective is to always have the SDK (bindings, libraries) up to date to the most recent and stable version of SciCat
Expected Behaviour
Create a new repository in SciCat project named SDK, also known as bindings or libraries.

Related to https://github.com/SciCatProject/pyscicat/issues/59

I think that pyscicat is the natural place for the python version.

We will need to store source code for compiled languages some where. Having source code for these is very much appreciated by the developers.
Also for these having independent repo would be more preferred, as every language has its own eco system which is easier to maintain independently

Not needed for now.
SDK are generated and stored as artifacts at every merge to Master. They are also published to NPM.js and PYPI at every release.


[Event Request] Codeunit 5750 Whse.-Create Source Document - OnFromTransLine2ShptLineOnBeforeSetQtysOnShptLine

Hi Team,
In codeunit 5750 we need possibility to replace and avoid using standard code. Having event with handling in procedure FromTransLine2ShptLine, would be a perfect solution :

[IntegrationEvent(false, false)]
local procedure OnFromTransLine2ShptLineOnBeforeSetQtysOnShptLine(var WhseShptLine: Record "Warehouse Shipment Line"; var TransLine: Record "Transfer Line"; var IsHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


select for association adds an extra empty value

Hello,
there is a select box for the HABTM association in the view
.medium-6.columns
      legend Lieft Team
      = f.simple_fields_for :teams, Team.new  do |tf|
        =tf.association :players, include_blank: false, collection: Player.all
.medium-6.columns
      legend Right Team
      = f.simple_fields_for :teams, Team.new  do |tf|
        =tf.association :players, include_blank: false, collection: Player.all

and no matter how many items  are selected there is an extra empty id  in the params:
Parameters: {"utf8"=>"✓", "authenticity_token"=>"hg6+cwJHlIxFHap7ZZf0VDJ/vH2FJfErAc3WvHCjo67j2bziYr6n3nWh3HOlRk+fhkEWHVgFC3hQPF8QMKGRdA==", "match"=>{"teams_attributes"=>{"0"=>{"player_ids"=>[""]}, "1"=>{"player_ids"=>["", "3"]}}}, "commit"=>"Create Match"}

+1

This is on purpose. If there was no hidden empty value and you selected none of the options, your association would not be updated. This is because the player_ids keys would be missing. The empty value is there to ensure the player_ids will be sent to the server on form submission. The use case it covers is when you edit a record and want to remove all associated records.

Now we have an issue template that helps you provide more information about the issue. Please open a new issue and make sure to fill in all the information requested by the template shown inside the text box. Thank you!


fix(docs): prevent some symbols from being copied in docs

SUMMARY

This PR fixes some problem in docs and prevent some symbols from being copied.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Good catch!


[Gardening] Remove DoubleWidth related dead code

Remove auxiliary benchmark and tests for DoubleWidth which was removed from stdlib and stashed into prototype in #15470. These scattered remains were just a dead code. I'm leaving a comment breadcrumb in test/Prototypes/DoubleWidth.swift.gyb pointing here, to assist in easy resurrection (revert these commits).

@swift-ci please benchmark

@swift-ci please test

This kind of stuff is important. White space is important.

@eeckstein I'd like to remove the DoubleWidthDivision benchmark that always returns zero because the tested type was removed from stdlib. Please review 🙏

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Improvement

UTF8Decode_InitDecoding
228
200
-12.3%
1.14x (?)

UTF8Decode_InitFromBytes_ascii
311
289
-7.1%
1.08x (?)

Removed

DoubleWidthDivision
0
0
0
—

Performance: -Osize

TEST
MIN
MAX
MEAN
MAX_RSS

Removed

DoubleWidthDivision
0
0
0
—

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

String.data.Empty
91
98
+7.7%
0.93x (?)

Improvement

UTF8Decode_InitDecoding_ascii
428
393
-8.2%
1.09x (?)

Removed

DoubleWidthDivision
0
0
0
—

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB


Support For Sitecore 8.0 Update 3?

I have installed the module in Sitecore 8.0, Update 3.0 and published the Templates and the Samples.
I then attempt to go to https://<IP_ADDRESS>/external1   but instead of getting redirected to http://www.sitecore.net like the example is configured for, i get "the requested" document is not found?

Disregard.   After doing a full site publish this works correctly.   Documentation should exist to say what paths need to be published after installing the module.


Epic v2: Critical CSS

This PR takes some of the core ideas from previous incarnations of Critical CSS I've implemented and modernizes it to 2018 -- combining that with some of the awesome ideas from Google's Critters project, yet making it work with all of our systems we're using (regardless on if we're using Webpack or not, or if the site(s) being optimized are using the HTML Webpack Plugin or not).
More work to be done to get this into production on the Drupal end however we should still see a  tremendous performance boost on the Bolt-side of things while we get there!

Closing out — the even newer version of Critical CSS implemented in https://github.com/bolt-design-system/bolt/pull/1324 supersedes this


[#407] [2fa extension]: Add generation options, tokens sortiong

Description
Add options to the token generator, optional sorting for tokens
#407
Type of change

Bug fix / improvement for somebody else's extension. Extension author: @cjdenio

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing

FYI:  @bennetfabian

Thanks for actually looking into it. Appreciate it!

I've been thinking about adding otpauth parsing, but not sure if it is a good idea.

Especially sites like GitHub or other developer tools focused on tech-savvy people often use the standardized URI scheme so it would seem like a good idea to me. URI parsing should be relatively easy to robustly implement either by writing custom RegExp or using a URI parsing library.

Can anyone merge?

One quick comment: should alphabetical sorting be an option? It seems reasonable enough to be the default.

One quick comment: should alphabetical sorting be an option? It seems reasonable enough to be the default.

To be honest, I thought that, too. Just didn't say anything because I didn't want to make you think I don't appreciate your work. @guga4ka
Let's think about it from another perspective: could you imagine there may be people who prefer random sorting as a default? At least from my perspective, I couldn't relate to people who prefer random sorting. 😅
@cjdenio @guga4ka

@cjdenio quick question is the "remove" shortcut working for you? I have ISO keyboard (large return and short left shift) and I guess the right button should be "return" not an "enter".
Is it ok, to create one more pr to remove the sorting option and make sorting by default? Also, should I add a view to hast otpauth URL to create token?

Hmm, the ctrl+shift shortcut isn't working for me either (looks like a Raycast bug perhaps)
otpauth parsing sounds awesome; I think that it could be added in the same PR as removing the sorting option (if you're up to it)
Thanks!


Refactoring

Currently the code is not very modular, it would be nice to refactor it to be cleaner.

Done as of https://github.com/neulab/compare-mt/commit/9330aa3597bb9a213f7e207b713d5b04fc53cde0


add upsert behavior

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3131856). Click here to learn what that means.
The diff coverage is 0%.

@@          Coverage Diff          @@
##             master   #1   +/-   ##
=====================================
  Coverage          ?   0%
  Complexity        ?    3
=====================================
  Files             ?    1
  Lines             ?   28
  Branches          ?    0
=====================================
  Hits              ?    0
  Misses            ?   28
  Partials          ?    0

Impacted Files
Coverage Δ
Complexity Δ

src/Model/Behavior/UpsertBehavior.php
0% <0%> (ø)
3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3131856...2b31682. Read the comment docs.


The pay with bitpay

For some reason the pay with bitpay button is redirecting to a non recognized URL. which is. bitcoin:1vnfpsXm7ypVfUQp7SAUfrS4NABVGvyxf?amount=4.968399&r=https%3A%2F%2Fbitpay.com%2Fi%2FJLssvnZxN6x1s6WvbpiRn4

The 'Pay with Bitcoin' button you're probably referencing is found on the BitPay invoice, and that URL attempts to open a Bitcoin wallet on the computer or device.  If you don't have a Bitcoin wallet program or app set to handle the bitcoin: protocol, it will be seen as a non recognized URL.  It would be like opening a mail: protocol URL without an email application installed.  Some web wallets allow you to register their website as a handler, and wallet apps for phones, of desktop wallets almost always do.
This is a user error and related to the BitPay invoice, not the BitPay for WooCommerce plugin, so I'm going to close this issue.  Please contact<EMAIL_ADDRESS>if you have any further questions.


Support for elmish with commands

Currently, I am seeing elmish is based on a simple elmish loop without commands. It would be nice if full elmish with commands are supported.

Yeah currently it's not elmish as much as the traditional React reducer pattern. I originally had full elmish support, but it's not quite compatible with Recoil and can lead to race condition issues. This is especially the case when React concurrent mode is released, which Recoil will be compatible.
They're currently working on a way to support effects within the context of Recoil that I'm hoping will solve this problem.

AtomEffects are released now, but I'll need to give it some thought as to how (if) this can be done. In the mean time this might help.


Token renew token after expiration

According to https://docs.aws.amazon.com/cognito/latest/developerguide/amazon-cognito-user-pools-using-tokens-with-identity-providers.html#amazon-cognito-user-pools-using-the-refresh-token
The Mobile SDK for iOS and the Mobile SDK for Android automatically refresh your ID and access tokens if there is a valid (non-expired) refresh token present, and the ID and access tokens have a minimum remaining validity of 5 minutes. If the refresh token is expired, your app user must reauthenticate by signing in again to your user pool.
Could u please provide example in swift how to renew the token ? Just to be sure that we r on right way?

For SDK related questions please open a github issue in the iOS SDK repo. We will track this as a SDK Issue. Closing this sample issue.


⚠ ClamAV has degraded performance

In 440ef37, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 54 ms

Resolved: ClamAV performance has improved in 6cbed9a after 542 days, 11 hours, 41 minutes.


Fix caps for PackageUrl and PublisherUrl in manifest docs

Camel case "PackageUrl" is required but spelling case "PackageURL" is present.

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@stephengillie, could you make sure for the future to create a pull request from a branch in a fork please, as everyone who has winget-pkgs cloned will also get stephengillie-patch-1.


Close file handles in gedcom2html. Fixes #110

When exporting a large tree (1600 people) it will error with too many files open.

This change is

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   91.72%   91.72%
=======================================
  Files          28       28
  Lines        1172     1172
=======================================
  Hits         1075     1075
  Misses         86       86
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb17885...52bff81. Read the comment docs.


how to write directly to png file?

hi, I try to write directly to png file like this:
`buffer := bytes.NewBuffer([]byte{})
err := graph.Render(chart.PNG, buffer)
if err!=nil {
	fmt.Println(err)
}

ioutil.WriteFile("chart.png", buffer.Bytes(), 644)`

but the resulting file cannot be opened (I'm not sure whether it is corrupt or else)
how to properly write the resulting chart to png file? thank you

nevermind, I should have put 644 in octal format 0644


Allow for non-async usage for 'prepared'

Resolves WPT-1650:
yarn run v1.9.4
$ flow check
Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/components/profile/profile-page.js:43:5

Cannot call prepared with function bound to sideEffect because undefined [1] is incompatible with Promise [2] in the
return value.

     src/components/profile/profile-page.js
     39│   }),
     40│   withUser,
     41│   withUserCity,
     42│   prepared(props => {
 [1] 43│     return; //non-async
     44│   })
     45│ );
     46│
     47│ export type {Props};

     node_modules/fusion-react/src/async/index.js
 [2] 24│   sideEffect: (props: Object, context: Object) => Promise<any>,

Found 1 error
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Sure!  I'll make sure a test case runs synchronously and does not return a Promise.

!merge


Feature Request: Reduce bundle size, currently arround 120kB

Is there an existing issue for this?

[X] I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply
mux-video-react
Description
There is no easy way to lazy load the player and even so they bundle size is way to big.
It added 120kB to my first load JS
Instead I'm now lazy loading react-player with a reduced bundle size of 120kB
Expected Behavior
A reduced bundle size and the ability to defer / lazy load

@JoeMatkin thanks for opening. Lazy loading will depend on your framework and build setup, what are you using?
We do have a guide here about Lazy Loading Mux Player
The biggest dependency we have is Hls.js, which is beefy and required in order to make Hls playback work in all non-Safari browsers.

@JoeMatkin thanks for opening. Lazy loading will depend on your framework and build setup, what are you using?
We do have a guide here about Lazy Loading Mux Player
The biggest dependency we have is Hls.js, which is beefy and required in order to make Hls playback work in all non-Safari browsers.

HLS leads to 383kb being loaded client side in our case.
Not including the other 83kb by mux-embed and another 135kb by @mux.
That's quite a bit.

Is that expected?
Our only dependency in package.json is "@mux/mux-player-react": "^1.14.2",.


fix(Upload): if no file found in the folder provided to upload the file, provide a console message, and not traceback

Earlier, while uploading the files to a dataset, if the user has provided a blank folder in the path, they get a traceback, making an appearance like something had failed. Also, an import id was being generated by the API. Now no import ID is being generated either, and user is being provided an explicit message that there were no DICOM files in the provided folder.

@AvanishCodes Please resolve the failing tests

type: ignore is not the solution. Please refrain from using it, unless you are 100% sure

Got it.
Made changes to address that.


Update the theory section in the documentation

The current theory section in the documentation is outdated and a part of it is wrong. Should update it ASAP.

Closing this issue now since some action items have become outdated, and the valid ones have been incorporated/restated in issue #41.


NO-ISSUE: Don't assign auto-closed tickets to a human

/cc @adriengentil
/cc @omertuc

Leacing

Leaving behind commented out code is unnecessary, we can always just revert this commit if we ever want it back

Sorry closed due to misclick

Totally agree, just fixed and completely removed that

/lgtm


Padding on v2 alert

I just ran into this issue where there's extra padding at the bottom of the modal while I was trying to use the v2 Modal with kind="alert" set.

It seems to be coming from this rule:
https://github.com/helpscout/hsds-react/blob/master/src/components/Modal/Modal.css.js#L119
I'm not sure why we're not seeing this problem in other alert modals, or maybe we're just overriding that padding-bottom every time as I'm about to do right now?

Closing this b/c as per Jared the alert modal shouldn't have a footer anyway and there is a ticket for updates to this modal that will remove the footer.


Error building with latest graphcache and cra

Hi I get the following error when building cra app with the latest graphcache
<EMAIL_ADDRESS>Attempted import error: 'visitWithTypeInfo' is not exported from 'graphql/utilities/TypeInfo'.

Thanks

hello, I still get this error :
[ error ]<EMAIL_ADDRESS>Attempted import error: 'visitWithTypeInfo' is not exported from 'graphql/utilities/TypeInfo'.

While I have this in my package.json, full re-install :
"next-urql": "0.3.7",
"urql": "1.9.7",
"@urql/devtools": "1.0.2",
"@urql/exchange-graphcache"

I tried to lower versions and all, still having the same problem :/
thank you for your help !

Do you by any chance have an ejected webpack config?

I just have a simple next.config.js from Next.js :
module.exports = withPlugins(
  [
    withTM({
      experimental: {
        scss: true,
      },
    }),
    withBundleAnalyzer,
    withImages,
  ],
  {
    target: 'serverless',
    env: envVars,
    webpack: (config, { isServer }) => {
      if (isDev) {
        config.plugins = [
          ...config.plugins,
          new Dotenv({
            path: path.join(__dirname, '.env.build'),
            systemvars: true,
          }),
        ];
      }
      if (!isServer) {
        config.node = {
          fs: 'empty',
          net: 'empty',
          tls: 'empty',
          dns: 'empty',
        };
      }

      config.plugins.push(new LodashModuleReplacementPlugin({}));

      config.module.rules.push({
        use: {
          loader: 'next-babel-loader',
          options: {
            isServer,
            cwd: process.cwd(),
            plugins: [['lodash', { id: ['lodash-es'] }]],
          },
        },
        test: /\.js$/,
        exclude: /node_modules/,
        include: [process.cwd()],
      });

      const originalEntry = config.entry;
      config.entry = async () => {
        const entries = await originalEntry();
        if (
          entries['main.js'] &&
          !entries['main.js'].includes('./lib/polyfills.ts')
        ) {
          entries['main.js'].unshift('./lib/polyfills.ts');
        }
        return entries;
      };

      return config;
    },
  },
);

Which didn't really change neither ^^

This is about CRA though, the issue you talk about could be caused by a multitude of factors. The thing that comes to mind is the breaking change graphql made in their transition from 14 --> 15

I tried to lower versions and all, still having the same problem :/

@coding-days: Have you upgraded your packages though, specifically the populate exchange? This was an issue that simply affected some specific versions, so it’s frankly impossible to occur once you’re off those versions 😅

I forced the "graphql": "14.6.0" but still having the issue.
@kitten: I never installed the populate exchange, I'll give it a try !

So I have :
"graphql": "14.6.0",
"next-urql": "0.3.7",
"urql": "1.9.7",
"@urql/devtools": "1.0.2",
"@urql/exchange-graphcache": "2.4.0",
"@urql/exchange-populate": "^0.1.6",

When I check in the node_modules graphql/utilities/TypeInfo, I don't see any visitWithTypeInfo exported indeed. Must I use the graphql@15 ?

@coding-days the populate exchange itself is currently a deprecated dependency if Graphcache.
So if you run yarn upgrade @urql/exchange-populate it should fix this issue

Oh okay, I'll kinda relieved because yarn upgrade @urql/exchange-populate didn't work either, did a full re-install again with yarn.lock deleted and I was starting to feel really confused :p

@coding-days This should be fixed with<EMAIL_ADDRESS>


Feature Request: SSLM

I'ts possible to insert SSLM in notify?
Is a good feature!

If you can do it in the Alexa app we can potentially mimic it. If you can't, we probably won't be able to.  Can you?

mmm in my  alexa app i can't even do tts...

I've just tested this and found that it already works for notifications using the "announce" method, but not the "tts" method. For example, using the dev-service page to call the relevant service (e.g. notify.alexa_media_bedroom) with the following (using an SSML example from the Amazon documentation will make the device whisper the announcement:
{       "message": "<amazon:effect name='whispered'>I am not a real human.</amazon:effect>",       "data": {           "type":"announce",           "method":"speak"       } }
Here is the same as a script:
alexa_ssml_test:
  alias: Alexa SSML Test
  sequence:
    - service: notify.alexa_media_bedroom
      data:
        message: <amazon:effect name="whispered">I am not a real human.</amazon:effect>
        data:
          type: announce
          method: speak

@gadgetchnnel Thanks! Do you mind editing the wiki to include that example?

Wow work!
It would be nice to work also on tts, or if you could remove the "bling blong" from the announce

You'll need to ask Amazon to provide those. We're just hooking into Amazon's APIs.

Hey
any progress with sound src? I get output on the log but no sound.
#https://developer.amazon.com/docs/custom-skills/ask-soundlibrary.html
  alexa_sound_door_bell:
    sequence:
      - service: notify.alexa_media
        data_template:
          target:
            - '{{ states.sensor.last_alexa.state }}'
          data:
            type: announce
            # method: speak
          message: >
            "<audio src='soundbank://soundlibrary/home/amzn_sfx_doorbell_chime_02'</audio src>"

No, we don't control audio src. That's amazon unfortunately. I'll go ahead and close this since @gadgetchnnel already updated the wiki.


Fix 'no encryption' error in staging.

Fixes 'no encryption' error by turning off RDS parameter that forces connections to use SSL encryption (rds.force_ssl).

🗣 Description
Adds an RDS parameter group to database.tf and turns off forced ssl encryption.

💭 Motivation and context
This fixes an issue where connections to the staging API are blocked.
The break is caused by a recent update from postgres 11 to postgres 15. RDS assigns differing default settings for each of these postgres versions, stored in their own respective parameter group. One setting that differs between these groups is rds.force_ssl documented here.
RDS does not allow changes to a default parameter group. This PR creates a new parameter group using terraform and specifies that rds.force_ssl is set to false, as it was before the update to postgres 15.

🧪 Testing

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

Looks good


Lock mutex when changing color

Ref linkerd/linkerd2#2264
We're using Color() to restart the spinner, and when running with -race, sometimes we get a data race that starts something like this:
WARNING: DATA RACE
Write at 0x00c0001aa4e0 by main goroutine:
  github.com/linkerd/linkerd2/vendor/github.com/briandowns/spinner.(*Spinner).Color()
      /home/alpeb/go/src/github.com/linkerd/linkerd2/vendor/github.com/briandowns/spinner/spinner.go:323 +0x3ef
...

Thank you very much for this update.


why I can return tuple as json?

Description
I am wonder why below code can be compiled
#include "json.hpp"
#include <iostream>
using json = nlohmann::json;

std::tuple<bool, json> test() {
    json j;
    j["name"]="a";
    return std::make_tuple(true, j);
}

int main() {
    json j;
    j = test();
    std::cout << j.contains("name") << std::endl;
}

Reproduction steps
code supplied description.
Expected vs. actual results
I am expecting a compile time failure, while the above code can actually compiled and run
Minimal code example
No response
Error messages
No response
Compiler and operating system
ubuntu 20
Library version
gcc 9
Validation

[ ] The bug also occurs if the latest version from the develop branch is used.
[X] I can successfully compile and run the unit tests.

See https://json.nlohmann.me/api/macros/json_use_implicit_conversions/
Can you try to compile with
#define JSON_USE_IMPLICIT_CONVERSIONS 0


Scale mons

The ability to add nodes with the monitor role to an existing cluster whose name differs from the default name is fixed.

You shouldn't send a PR against stable branch for this kind of issue. Instead you need to create a PR agains master and we will backport the change if necessary.
Also I think you messed up with your PR because you shouldn't have 217 commits.

The change has been added in https://github.com/ceph/ceph-ansible/pull/4196


LayerDetailsModal: NPE check

This fixes an error while parsing the BBOX.
Please review @terrestris/devs.

:tada: This PR is included in version 6.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


GsaAPI.Node with no ConnectedMembers throw exception

gsaNode.Node.ConnectedMembers = 'gsaNode.Node.ConnectedMembers' threw an exception of type 'System.NullReferenceException'
https://github.com/arup-group/GSA-Grasshopper/blob/fb97913d01893e761f68fa1a901a9ec60a9e9936/GhSA/Components/2_Geometry/EditNode.cs#L177

the error is handled with the exception shown above. Can leave it like this


Loading plot/vega starts chrome browser

Just loading the system via ASDF causes the chrome browser to be displayed.  It appears to be caused by the executable-present-p function? I assume this behaviour is not intentional?

@Symbolics Which platform? The only thing I can think of is that chrome on Windows might not treat the version command line argument the same as Linux does.

It's on Windows.

@Symbolics Please can you confirm if the pull request fixes it on your side.

Fixed, thanks.


Use prismic pageId instead of vanity url for url match

☝
Noticed that 'get-involved' and 'schools' wouldn't be picked up by Hotjar as they were.

Where does the value of url come from on L79?

In this case we pass in a prop url={{ pathname: /pages/${page.id} }}, so PageLayout doesn't know about the vanity url

Ah, so this might clash with #7973 and it'd be worth working out how we want to tackle this.

Good point. Looks to me if #7973 is merged, then this PR is unnecessary(/wrong).