Implementation of SectionList with numColumns and header does not work correctly

Current behavior
Header on the same line as an item, that is really bad
[](https://user-images.githubusercontent.com/36490069/191108692-852ac39e-4ae6-4836-8578-88340388ffc1.mov)

Code from an example in official documentation, and added some props to make two columns
const stickyHeaderIndices = sections
    .map((item, index) => {
      if (typeof item === 'string') {
        return index;
      }

      return null;
    })
    .filter(item => item !== null) as number[];

    interface Contact {
      firstName: string;
      lastName: string;
    }

    const contacts: (string | Contact)[] = [
      "A",
      { firstName: "John", lastName: "Aaron" },
      { firstName: "John", lastName: "Are" },
      { firstName: "John", lastName: "Avik" },
      { firstName: "John", lastName: "Amok" },
      { firstName: "John", lastName: "Aluz" },
      { firstName: "John", lastName: "Amio" },
      "D",
      { firstName: "John", lastName: "Doe" },
      { firstName: "Mary", lastName: "Dianne" },
      { firstName: "Mary", lastName: "Dmol" },
      { firstName: "Mary", lastName: "Deko" },
      { firstName: "Mary", lastName: "Duke" },
    ];

    return (
      <View style={styles.container}>
        <View style={{height: 50}} />
        <FlashList
        numColumns={2}
          data={contacts}
          renderItem={({item}) => {
            if (typeof item === 'string') {
              // Rendering header
              return (
                <View style={{backgroundColor: 'dodgerblue', height: 50, width: width, alignSelf: 'center',}}>
                  <Text
                    style={{
                      fontSize: 15,
                    }}>
                    {item}
                  </Text>
                </View>
              );
            } else {
              // Render item
              return (
                <View
                  style={{
                    width: width * 0.4,
                    height: normalize(85),
                    backgroundColor: 'green',
                    alignItems: 'center',
                    justifyContent: 'center',
                    marginTop: 20,
                  }}>
                  <Text>{item.lastName}</Text>
                </View>
              );
            }
          }}
          stickyHeaderIndices={stickyHeaderIndices}
          getItemType={item => {
            // To achieve better performance, specify the type based on the item
            return typeof item === 'string' ? 'sectionHeader' : 'row';
          }}
          estimatedItemSize={normalize(85)}
          contentContainerStyle={{backgroundColor: 'red'}}
        />
      </View>
    );

Expected behavior

Header is not located on the same line like an item. UI structure must be something like this:
Header
Item item
Item Item
... ....
Item item
Header
Item item
Item item
.... ....
Item item
To Reproduce
Run code

Platform:

[✅] iOS
[✅] Android

Environment
"react-native": "0.67.4",

"@shopify/flash-list": "1.2.2",

You can use overrideItemLayout prop to increase span of your header to 2.

You can use overrideItemLayout prop to increase span of your header to 2.

Thanks. that workes👍

@Slapbox numColumns={2} needs to be set on FlashList.

This function has been there since v1. Are you using this with masonry? That doesn't support custom column spans.
If not, help me with an expo sample and I can fix it for you.

Any chance we can support this, even haphazardly, in Masonry mode?

Any chance we can support this, even haphazardly, in Masonry mode?


Prebuilds failing on Windows

https://ci.appveyor.com/project/resin-io/drivelist/build/1.0.830/job/k570q7x53q2v79x7
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  code.cc
  log.cc
  drivelist.cc
  com.cc
C:\Users\appveyor\.node-gyp\iojs-1.8.0\deps\v8\include\v8.h(4028): error C2610: 'v8::WasmCompiledModule::TransferrableModule::TransferrableModule(v8::WasmCompiledModule::TransferrableModule &&)' : is not a special member function which can be defaulted (..\src\drivelist.cc) [C:\projects\drivelist\build\drivelist.vcxproj]
C:\Users\appveyor\.node-gyp\iojs-1.8.0\deps\v8\include\v8.h(4031): error C2610: 'v8::WasmCompiledModule::TransferrableModule &v8::WasmCompiledModule::TransferrableModule::operator =(v8::WasmCompiledModule::TransferrableModule &&)' : is not a special member function which can be defaulted (..\src\drivelist.cc) [C:\projects\drivelist\build\drivelist.vcxproj]
C:\Users\appveyor\.node-gyp\iojs-1.8.0\deps\v8\include\v8.h(4104): error C2610: 'v8::WasmModuleObjectBuilder::WasmModuleObjectBuilder(v8::WasmModuleObjectBuilder &&)' : is not a special member function which can be defaulted (..\src\drivelist.cc) [C:\projects\drivelist\build\drivelist.vcxproj]
C:\Users\appveyor\.node-gyp\iojs-1.8.0\deps\v8\include\v8.h(4106): error C2610: 'v8::WasmModuleObjectBuilder &v8::WasmModuleObjectBuilder::operator =(v8::WasmModuleObjectBuilder &&)' : is not a special member function which can be defaulted (..\src\drivelist.cc) [C:\projects\drivelist\build\drivelist.vcxproj]
  scanner.cc
  volume.cc
  disk.cc
  wmi.cc
  win_delay_load_hook.cc
prebuild ERR! build error
prebuild ERR! stack Error: `msbuild` failed with exit code: 1
prebuild ERR! stack     at ChildProcess.onExit (C:\projects\drivelist\node_modules\node-gyp\lib\build.js:258:23)
prebuild ERR! stack     at emitTwo (events.js:125:13)
prebuild ERR! stack     at ChildProcess.emit (events.js:213:7)
prebuild ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
prebuild ERR! not ok
prebuild ERR! build Error: `msbuild` failed with exit code: 1
prebuild ERR! build     at ChildProcess.onExit (C:\projects\drivelist\node_modules\node-gyp\lib\build.js:258:23)
prebuild ERR! build     at emitTwo (events.js:125:13)
prebuild ERR! build     at ChildProcess.emit (events.js:213:7)
prebuild ERR! build     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>prebuild: `prebuild --all --strip "-u" "*****"`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prebuild script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\appveyor\AppData\Roaming\npm-cache\_logs\2017-09-28T14_38_40_790Z-debug.log
Command exited with code 2

Turns out the issue here is that  VS2013 does not support defaulting move constructor and move assignment operators (see https://github.com/nodejs/node-v8/issues/4).
I have now set the build worker image on AppVeyor to use the VS2015 image (which it should've defaulted to according to the docs) instead of the VS2013 image.


Make Family, Section, and Genus pages appear in global search results

At the moment, our global search feature only lists Sources and either Host or Gall "species" results, because these are the only entries in the db that have corresponding pages to link to. For instance, if you search "Quercus" you'll get the species page for every host in that genus, but no page for the genus itself. Since we can already handle searching for every gall on a genus using the ID tool (replacing the genus-level gall table on Bladmineerders, which I use all the time), it's not clear how much utility having a genus (or section, or family) page would necessarily add.
But it is something I expected to be able to do, and which I think other users will expect to be able to do. Is it worth the effort to add this? If so, what should be displayed on these pages?

@jeffdc I'm slightly confused by what you told me last time we talked about this, because families do literally have pages already. Is there a reason we can't just link to this page eg if I search "Fagaceae" ? I just find it weird somehow that we can have hundreds of plants added in a family but the search tool acts as if it doesn't exist. I've been using the search tool to check the presence of different taxa and aliases etc to see what needs to be added and if these higher taxa don't show in search then that isn't possible.

You are correct that we have family pages, I forgot about those. We could also create Section pages. There is no reason we can not add this stuff to global search.

@megachile here is what I came up with:
Search results:

New Genus Page:

Gall Page:

Host Page:

Looks good to me. I have definitely found myself wishing for a link to all the galls in a genus on gall page too, so that will be good to have.


We should be proactively testing all features on upcoming OS versions

This came up as part of #38375.
Right now we're not methodically testing all of our features on upcoming OS versions. This can lead to features unexpectedly regressing like in the linked issue. In the above example Android 10 had a public beta that spanned several months but this issue was only really root caused after the public release.
I'm thinking of two main approaches to try and prevent this going forward, there may be more that I'm not thinking of.

Deliberately run our automated test suite against beta OS versions. Manual one-offs with an attached device in the simplest case. I think this is the most feasible and "should" guarantee our features work. The main catch I can think of here is that, at least for Android, our most brittle OS-dependent code doesn't have automated tests. In those cases it tends to be so tightly coupled with the underlying operating system that we don't have the ability to write meaningful Flutter driver tests for it. Automated tests wouldn't have caught the linked issue, for example. We are attempting to improve the automated tests to cover cases like it though.
Come up with a manual test plan and verify. This would probably be full time work for a QA team. But it would catch tricky OS-dependent edge cases that are out of scope from our automated tests, and just general behavior that the tests don't cover.

/cc @Hixie @dnfield @collinjackson

From an offline discussion, part of the problem here is that keeping track of upcoming operating system releases is non-trivial given how many OSes Flutter runs on and the cadence of how often updates tend to roll out. It adds up really quickly.
Maybe it's possible to shard the burden across multiple people for the different OSes? I as an individual can keep an eye out for upcoming Android releases and manually run the test suite when they're in beta.

@reidbaker - I believe there's some other issue tracking this now?
We are, in any case, in a better state now - we test against more recent OS versions, and Reid has or is working on a process to make sure that gets kept up to date as new versions become available for testing.
I think we can close this. Feel free to re-open if it's not better tracked elsewhere.

Yes if someone comes across this bug in 2023 we are working on or have a test that will ensure flutter can target preview releases as a ci test. Additionally we have manual testing triggered for preview builds.


Please support ASP.NET Core 2.0.

We are looking to build our new project in Core 2.0. Any time frames on when IdentityServer will support it?

Issue already open: Support ASP.NET Core 2.0 - #1055

Ah apologies


Update MD file on new branch 2017-11-10_00-24-45

:warning: Validation status: warnings

File
Status
Preview URL
Details

split/ref1.yml
:warning:Warning

Details

split/updateTestRef1.md
:white_check_mark:Succeeded

split/ref1.yml

[Warning] Uid(Microsoft.SqlServer.Server) has already been defined in test_link_to_con.yml.
Line 1: [Warning] Invalid file link:(~/content1.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


add Tls12 support on websocket

I am trying to implement a new crypto brokerage which needs WebSocket to support SslProtocols Tls12.
Expected Behavior
Tls12 support on the WebSocket client wrapped into WebSocketWrapper
Actual Behavior
no Tls12 support
Potential Solution
I tried to globally set the SecurityProtocol but it didn't help
ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls12
The solution was to set the value on the WebSocket in the WebSocketWrapper.Initialize(string) method :
_wrapped.SslConfiguration.EnabledSslProtocols |= System.Security.Authentication.SslProtocols.Tls12;
System Information
irrelevant
Checklist

[X] I have completely filled out this template
[X] I have confirmed that this issue exists on the current master branch
[X] I have confirmed that this is not a duplicate issue by searching issues

your welcome, thanks for this great project :)


Apptainer is missing the /var/lib/apptainer/mnt/session directory

Describe the bug
The apptainer derivation is missing the /var/lib/apptainer/mnt/session directory to work properly.
Steps To Reproduce
Steps to reproduce the behavior:
❯ nix-shell -p apptainer --run 'apptainer run docker://alpine echo Hi'
INFO:    Using cached SIF image
FATAL:   container creation failed: failed to resolve session directory /var/lib/apptainer/mnt/session: lstat /var/lib/apptainer: no such file or directory

Expected behavior
A clear and concise description of what you expected to happen.
Hi is output without error.
Screenshots
Additional context
This can be fixed by creating the /var/lib/apptainer/mnt/session directory manually (sudo mkdir -p /var/lib/apptainer/mnt/session). I guess this could be added to the derivation. 🤷
Notify maintainers

@jbedo @ShamrockLee
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.41, NixOS, 23.05 (Stoat), 23.05.2403.d57e8c535d4`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

The NixOS module programs.singularity provides those top-level directories.

I discussed with one of the main Apptainer developer in https://github.com/apptainer/apptainer/issues/1283 . He think it should be easy to specify a directory that will always exist at build time.
Regalding this, I'm considering the possibility to put those dilectories under the derivation store path. Not sure if there would be potential problem using a store path as a mount point, but it seems to work without problem.

@nobodyinperson Could you help me take a look at #250949?

@nobodyinperson If you have time, please help me test the PR #250949. It should fundamentally solve this issue. If applied, you no longer need the NixOS module or sudo mkdir -p /var/lib/{apptainer,singularity}/mnt/session just to run images.
It specifies the LOCALSTATEDIR as $out/var/lib/{apptainer,singularity}/mnt/session, making both Apptainer and Sylabs SingularityCE works without /var/lib/{apptainer,singularity}/mnt/session.
(The image running still depends on /etc/resolv.conf and /etc/hosts to run images, which might be the final obstacle to build images as a package without invoking a virtual machine. Other than that, it should not be an issue for most users, as /etc/{resolv.conf,hosts} are available on most of the UNIX/UNIX-like systems.)

I removed /var/lib/apptainer/mnt/session (the temporary fix for this issue) and ran the following and it seems to work fine:
yann in yann-desktop-nixos in ~
🐟 ❯ nix-shell -p apptainer -I nixpkgs=https://github.com/ShamrockLee/nixpkgs/archive/refs/heads/apptainer-localstatedir.zip --run 'apptainer run docker://alpine echo Hi'
INFO:    Converting OCI blobs to SIF format
WARNING: 'nodev' mount option set on /run/user/1000, it could be a source of failure during build process
INFO:    Starting build...
Getting image source signatures
Copying blob 96526aa774ef done
Copying config e175fa54c5 done
Writing manifest to image destination
Storing signatures
2023/11/14 13:05:32  info unpack layer: sha256:96526aa774ef0126ad0fe9e9a95764c5fc37f409ab9e97021e7b4775d82bf6fa
2023/11/14 13:05:32  warn xattr{etc/shadow} ignoring ENOTSUP on setxattr "user.rootlesscontainers"
2023/11/14 13:05:32  warn xattr{/run/user/1000/build-temp-1961815878/rootfs/etc/shadow} destination filesystem does not support xattrs, further warnings will be suppressed
INFO:    Creating SIF file...
Hi

Thank you for this fix!

Glad to hear that!
Would you mind approving #250949 ? I've heard that committers tend to merge PRs getting two approvals.

✅ Done!


:white_check_mark: test: Add unit tests for webpack plugin

Description
Add testing suite for webpack plugin
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #397

PR #398

PR #399

PR #400

PR #401

PR #402

PR #403

PR #404   👈

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

main

PR #397

PR #398

PR #399

PR #400

PR #401

PR #402

PR #403

PR #404   👈

This comment was auto-generated by Graphite.


Not compatible with doctrine/lexer v3

In v3, doctrine/lexer's Token class, the value has to be either string or int. So it throws a type error when you pass it a float.
A workaround is to downgrade doctrine/lexer to 2.1.0
Is this project still maintained?

If you're not aware, @longitude-one has forked creof's wkt-parser and doctrine-spatial.
I have opened a PR to add support for doctrine/lexer 3 to wkt-parser.  I would like to see doctrine-spatial updated as well but it depends on creof/geo-parser.  Ideally longitude-one would fork creof/geo-parser as well (including your changes).  Then wkt-parser, doctrine-spatial and geo-parser would be in one place.
https://github.com/longitude-one/wkt-parser/pull/5

I just forked the geo-parser. This week, I will attempt to update the code (namespaces, GitHub action, code climate, etc.). Once I've made the changes, could you please push your PR to the new repository's dev branch? I'll take a look at it. Feel free to provide me with some information about the differences between these versions of doctrine/lexer

Thanks Alexandre.  The differences between doctrine/lexer 2 and 3:

In doctrine/lexer 2, Token implements ArrayAccess and properties can be accessed like this $token['value'].  In version 3 this has been dropped so they must be accessed as properties: $token->value.
Token::$value is now typed as string|int, so float cannot be passed.

https://github.com/doctrine/lexer/blob/3.0.x/UPGRADE.md

Thank you. I now understand your PR. I will release three versions (v1, v2, v3) of the geo-parser, with each version corresponding to a specific doctrine/lexer version, to prevent any confusion with doctrine-spatial.


Wsmprovhost process user name is missing with PS 7

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce

Create an endpoint with JEA using PowerShell 7 on a server (Windows Server 2019)
Open a remote session from another computer
On the server that runs the endpoint, open a PowerShell 7 console, and run the command Get-Process wsmprovhost -includeUsername. You will see the Username property is empty

If you run the same command using Windows PowerShell, the username is there :
eg.: WinRM Virtual Users\WinRM VA_1_POWERSHELL_TestJea
Expected behavior
# On the server side where the remote endpoint is
Get-Process wsmprovhost -includeUsername | Select-Object -ExpandProperty Username

# Should Output
WinRM Virtual Users\WinRM VA_1_POWERSHELL_TestJea

Actual behavior
# On the server side where the remote endpoint is
Get-Process wsmprovhost -includeUsername | Select-Object -ExpandProperty Username

# There's no output

Error details
No error

Environment data
Name                           Value
----                           -----
PSVersion                      7.4.0
PSEdition                      Core
GitCommitId                    7.4.0
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No visuals

I want to add that it is okay when you use Powershell below Version 7. This is also true when you use Enter-PSSession.
Get-Process -IncludeUserName seems not to use the Method GetOwner from Win32_Process correctly.
The same result is happening in PowerShell >=7, when you try to use the method GetOwner directly:
Invoke-CimMethod -InputObject $process -MethodName GetOwner | select -ExpandProperty user


Not working to get language preferences from FireFox

I set my firefox language preferences to have spanish first :

But the plugin seems not detecting it. QueryStrings are working fine.

could you please paste your init options...thank you

Yeah, almost no init options:
i18next.use(LngDetector).init({    keySeparator: false,    resources: ....    });
That is all.

Probably is something wrong with firefox :S , after use the query string with es , yes it worked, but when I remove it, it does not want to come back to en, even I configured language preferences again to put en on the top, but I am still having spanish now. I restarted multiple times >.<

https://github.com/i18next/i18next-browser-languageDetector#detector-options there is the caches  array. Means after a detection (or manual change via i18next.changeLanguage) the new lng value is stored on localStorage or cookie (whatever is set). On every subsequent load it will use that value (if higher in the detection order. Hope that is understandable...
So if nothing else detected it will take lng from navigator - once persisted it will take the persisted value (clear that from localStorage or cookie for new detection from navigator)

Ho man, yeah I think that was it. In my beginning tests I used lng: 'en' So I guess it was cached, then when I wanted to use your plugging, it got that from cache (cookies or localStorage) and no matter what I tried in the navigator.
I used the options you suggested to put the browser as first option, and all started to work as expected.
Thanks man! appreciated.
Postdata, probably would be better to change the default order, cookies and localstorage imho are used explicitly and require extra work and is a bit hard to realize third libs are using it,  also for demo proposals browser priority would be nice.

ah...if you init with lng set in options it not even will do detection...will always use that value.

yep I just init once or twice with that, then removed it, but I guess that was enough to make i18next to cache it.

Thank you!  I think will be my next step (:.


Need Advice Sidekiq jobs eat memory !

I'd like to optimize my notification system, so here is how it works now:
Every time some change occurred on application, we're calling background job (Sidekiq) in order to compute some values and then to notify users via email.
This approach worked very well for a while, but suddenly we got memory leak as there were a lot of actions very frequently and we had about 30-50 workers per second so I need to refactor this.
What I would like to do is, instead of running worker immediately, to use sidekiq-cron scheduler but I'm afraid that also will cause a problem, but just "delayed" problem.
@ondrejbartas I'd like to hear from you if sidekiq-cron is good way for this or there is some other possible way to solve this issue?
Thanks in advice !

Hi @zauzaj,
if you are having memory leak problem than most probably it is not caused by sidekiq or sidekiq-cron.
I run both of them for long time without any issues.
Ruby has problems with memory consumption, which basically do one thing, when it allocates some memory it will not flush it to system back when it does not need it anymore.
I am running 2 sidekiq workers side by side, first worker is processing small actions with huge amount of workers and second worker process has only 1-2 workers and it is managing those huge imports or processes big data, by this I will ensure that I am not processing in one time more of these expensive workers.
Does that makes sense for you?

Hi @ondrejbartas
thanks a lot on your advice. That sounds very interesting, I will definitely try to implement something like that as it totally has sense :)
Thanks again.


Get node name when cluster is on-premise

Hey guys,
I would like to know if there is an easy way to get the node name when I have the cluster on-premise, since my machine could have a different name than the node, let's say the machine name is machine1 but the node name is vm1
This is related with #170 I need to get the node name outside of SF application. So I noticed that the manifest contains this section when the cluster is on-premise, but I would like to know if is there another way to get it:
<Infrastructure>
    <WindowsServer>
      <NodeList>
        <Node NodeName="vm0" IPAddressOrFQDN="<IP_ADDRESS>" IsSeedNode="true" NodeTypeRef="NodeType0" FaultDomain="fd:/dc1/r0" UpgradeDomain="UD0" />
        <Node NodeName="vm1" IPAddressOrFQDN="<IP_ADDRESS>" IsSeedNode="true" NodeTypeRef="NodeType0" FaultDomain="fd:/dc2/r0" UpgradeDomain="UD1" />
        <Node NodeName="vm2" IPAddressOrFQDN="<IP_ADDRESS>" IsSeedNode="true" NodeTypeRef="NodeType0" FaultDomain="fd:/dc3/r0" UpgradeDomain="UD2" />
      </NodeList>
    </WindowsServer>
  </Infrastructure>

Have you tried using the NodeContext class? You should be able to get the NodeName from there.

The point is that I need to get the name out of the SF app, let's say from a console app, is it possible tho?

@vany0114 Yes, the Service Fabric API has a method for that:
C#
CLI
PowerShell
HTTP

Closing the issue based on the answers above.


SysConfig/VolumeMapping events are not delivered

When using TraceEvent, the FileName property of file-related events is sometimes delivered with an incorrectly formatted kernel path. For example, it contains C:\Device\HarddiskVolume25\foo.bar instead of D:\foo.bar. It happens only if the drive in question is mounted after the ETW session is started (say, a USB key is inserted).
It turns out that this heuristic kicks in and adds the system drive prefix (C:) because the appropriate kernel-to-user drive mapping cannot be found (\Device\HarddiskVolume25 to D: in the example above). In turn, the mapping is missing because the event callback for SysConfig/VolumeMapping, which should insert it, is never called. And indeed, no matter how I configure the tracing session, VolumeMapping (and other SysConfig events) are nowhere to be found, even if I manually look for them by instrumenting the RawDispatch callback. I tried both on Win10 and Win7.
When I collect kernel events with PerfView, SysConfig events do appear (without a timestamp, though):

I can also read them from the generated file using TraceEvent. However, the events seem to originate during ETL merging, not during trace collection. I can't find them in the "raw" ETL files right after collection, only in the final, merged ETL. Another hint that merging does something is the following: If a drive is disconnected while the trace is being collected, and I plug it in only during merging, the VolumeMapping event for that drive appears. In the opposite case (connected at collection time, disconnected at merge time), the event is missing.
Are SysConfig events special in any way? How can I get them to appear with TraceEvent in real-time sessions?

In a world where drives come and go, there is no way to be 'right' without help from outside (basically something has to tell you when the mappings change).   Thus I am not thrilled with the idea of heuristically calling PopulateFromLocalMachine() at various points.
I would not be averse, however to adding a 'hook' to get 'help' from the outside.   Thus if a KernelTraceEventParser had a delegate  'string MapKernelFilePathToUserFilePath(string)' that you could set to take over this mapping.   By default it would just do what it does today, but if that is not good (as in your case, you can set this (you can simply set it to the identity function if you wish to simply have the kernel path), and gives you control.    Should be pretty simple to implement if you want to do create a PR to do that.

Closed. The "hook" for path mapping is here: https://github.com/Microsoft/perfview/commit/a7f8dffcd7a09ec3483f98b4c19e617b353c3750


Unable to send binary data to a process' stdin

I've been trying to send binary data to a process' stdin with delegator but it blows up with a TypeError as follows:
In [1]: import delegator

In [2]: cmd = delegator.run("pngquant -", block=False, binary=True)

In [3]: cmd.send(b"")
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-3-e2d15877a492> in <module>()
----> 1 cmd.send(b"")

~/.virtualenvs/paddy-test-gGhWdBGA/lib/python3.6/site-packages/delegator.py in send(self, s, end, signal)
    184                 return self.subprocess.communicate(s + end)
    185             else:
--> 186                 return self.subprocess.send(s + end)
    187         else:
    188             self.subprocess.send_signal(s)

TypeError: can't concat str to bytes

For now I've been able to work around the problem with:
    cmd.subprocess.send(image_bytes + b"\n")

Closing due to inactivity :+1:


fix(table-config): Set arrows as disabled when no column is selected

Mandatory

[x] What does this PR do?
Sets arrows in attribute settings as disabled when no attribute is selected in table-config component.
[x] What issue/task does this PR references?
This PR addresses the following settings issue
https://github.com/openshiftio/openshift.io/issues/3856
[x] Are the tests Included?
Yes, testcases have been included.

Please note: This PR will work properly after the tooltip is in place ( https://github.com/fabric8-ui/fabric8-planner/pull/2818 ).

@abhinandan13jan Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 and visit http://localhost:5000 to access it.

@abhinandan13jan Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 and visit http://localhost:5000 to access it.

@sahil143 This PR is dependant on the other PR on tooltip ( https://github.com/fabric8-ui/fabric8-planner/pull/2818 ), which must be merged first. I see that the other PR is now merged. Can you check it again. The arrows are of type 'span' and 'span' doesn't have a disabled property so I've changed on the tooltip message part saying "Please select an attribute". Should I grey-out the spans as well using CSS?

Yes, You can disable using the css

@sahil143 Added CSS

@abhinandan13jan Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 and visit http://localhost:5000 to access it.

@abhinandan13jan the behaviour works only for the first time. If I move the attributes back and forth, the arrows do not grey out.

@joshuawilson ok


Failed to create template.

This happens in Rider right after starting a new project with SpaceWarp template
The entire stack trace is here:
Failed to create template. Details:
Error while processing file /swinfo_id/swinfo.json System.UnauthorizedAccessException: Access to the path 'C:\swinfo.json' is denied.
at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
at System.IO.File.Create(String path)
at Microsoft.TemplateEngine.Utils.PhysicalFileSystem.CreateFile(String path)
at Microsoft.TemplateEngine.Core.Util.Orchestrator.ProcessFile(IFile sourceFile, String sourceRel, String targetDir, IGlobalRunSpec spec, IProcessor fallback, IEnumerable`1 fileGlobProcessors)

The solutions seems OK tho (it opens with Rider)

I think this may be caused by not filling in all the parameters - everything apart from description and source URL are required (there's no validation as Rider can't validate .net template parameters as far as I know, but the solution will be broken if you don't fill them in)

That is quite correct. I tried filling dummy values and it works now. Thank you for the prompt response!

(there's no validation as Rider can't validate .net template parameters as far as I know

So this means there is no fix? Too bad ://

A fix isn't possible as far as I know, but it is documented in the readme that the parameters must be filled in.


[SPARK-36165][INFRA] Fix SQL doc generation in GitHub Action

What changes were proposed in this pull request?
This PR aims to fix SQL doc generation in GitHub Action by specifying the mkdocs-installed python version explicitly.
Why are the changes needed?
Currently, the SQL doc generation is using spark-submit and picked up another Python 3 binaries.
Generating SQL configuration table HTML file.
Traceback (most recent call last):
  File "/__w/spark/spark/sql/gen-sql-config-docs.py", line 25, in <module>
    from mkdocs.structure.pages import markdown
ModuleNotFoundError: No module named 'mkdocs'

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the GitHub Action linter job.

Test build #141086 has started for PR 33372 at commit 4e50da1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45600/

Hi, @viirya . Could you review this please?
This will recover GitHub Action doc generation test in master branch.

https://github.com/dongjoon-hyun/spark/runs/3079233581?check_suite_focus=true

Thanks for fixing this.

Thank you so much. The linter job passed.
Merged to master to recover GitHub Action.

GA doc generation was passed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45600/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45600/

Test build #141086 has finished for PR 33372 at commit 4e50da1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141086/


abnormal library behavior on threads

@Fdhvdu
i just installed and execute your sample for thread pooling. after execution stage 1 (same result on other usage in all 3 remaining stages) i see the result below that it is not correct :

stage 1
add_and_detach - thread 4 wait 0 sec
add_and_detach - thread 4 wait 0 sec
add_and_detach - thread 4 wait 1 sec
add_and_detach - thread 4 wait 3 sec

as you see the all thread shows number 4, as their thread no,  that it is not correct! you send the i as a variable to the function add_and_detach_func but it seems it is not working correctly
        for(size_t i{0};i!=tp.size();++i)
                tp.add_and_detach(add_and_detach_func,i);

        std::size_t add_and_detach_func(const std::size_t i)
        {
                using namespace std;
                const auto sec{get()};
                this_thread::sleep_for(chrono::seconds{sec});
                lock_guard<mutex> lock{mut};
                cout<<"add_and_detach - thread "<<i<<" wait "<<sec<<" sec"<<endl;
                return i;
        }

more info :
Compiler : g++ (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
OS:  Ubuntu 18.04.1 LTS (GNU/Linux 4.15.0-54-generic x86_64)

Actually this is a correct behavior. The behavior is as same as I wrote in Warnings.
(But the example do a misleading demonstration.)
I push a commit here to make it correct.


ENH: Upgrade viz rendering to use q2templates

This also fixes an issue where the entire page was wiped on Taxonomic Level changes.
Dependent on qiime2/q2templates/pull/3

Thanks @thermokarst, should be good to go after tests pass 👍 !


[tekton-pipelines] add oc to path Containerfile.base

Adding oc and kubectl to path.
Using pattern from art-bot

/cc @MartinPl0

/lgtm

/approve


Missing git tags for latest versions

For some reason FDroid is still on 1.0, not necessarily because of this, but still.

Not sure what exactly you mean. All our releases are tagged, see https://github.com/dmfs/tasks/tags
However, I just noticed that I didn't push the latest tags yet. I'll do that next week. Also, we've published the binaries of every public release under https://github.com/dmfs/tasks/tree/master/releases

Sorry for the confusion, I did mean that you forgot to use tags for the latest few releases. I think F-Droid goes by tags when watching for new versions, which is why this is important to me.

@dmfs any updates on this?
Since 1.1.1 there are no new tags although from the commit log it seems you're already on 1.1.6.

sorry, all tags are pushed to github now.


Option title-card-clickable false is not working

Checklist:

[x] I updated to the latest version available
[x] I cleared the cache of my browser

If you use a title card with  title-card-clickable: false, the title card is always clickable and not only the arrow

Fixed in 1.2.9


[#115709073] Move public facing TLS terminations to ELBs - Move router TLS termination to ELB

What
We want to move TLS termination to the ELB for the router. As part of this, we have refactored the way SSL certificates are generated in the pipeline, as this was duplicated and not consistent.
How this PR should be reviewed
Checkout this branch and deploy the changes. Run the tests and check they apply.
Check the ssl certificate contains the correct SAN for the router
openssl s_client -connect api.$ENV.dev.cloudpipeline.digital:443 </dev/null | openssl x509 -noout -text | grep 'DNS:'
Who should review this PR

Anyone except me or @jonty

TF behaves weirdly. In one case it reports 0 instances destroyed, whereas it is destroying old certs:
aws_iam_server_certificate.logsearch: Destroying...
aws_elb.metrics_elb: Modifications complete
aws_iam_server_certificate.metrics: Destroying...

Apply complete! Resources: 3 added, 6 changed, 0 destroyed.

In other instance it fails (& forgets about that resource):
aws_iam_server_certificate.concourse: Destroying...
Error applying plan:

1 error(s) occurred:

* aws_iam_server_certificate.concourse: DeleteConflict: Certificate: ASCAIL7OJZQWQCOHRWL3K is currently in use by arn:aws:elasticloadbalancing:eu-west-1:595665891067:loadbalancer/mt2-test-elb. Please remove it first before deleting it from IAM.
	status code: 409, request id: 137c1831-f67e-11e5-be43-4d43ee79d79c

The 2nd case looks like a possible race condition in creating & applying new cert and then quickly trying to destroy old cert which is in process of being removed from ELB. Even though I would have thought cert swap operation on ELB is atomic.

May help to read the summary here: https://www.pivotaltracker.com/projects/1275640/stories/115709073

works as described...


Optimize performance

The current program takes about 1 day to run on a Dell laptop with 16GB ram and an Intel i7 2.8GHz processor.
To add detection of loops (see issue #1) may increase the run time of the app to several days.
Since I am an inexperienced Python programmer, I expect there are ways to optimize the program that are obvious to a more experienced Python programmer.

Perform any optimizations after you've implemented issue #1, because detecting loops may dramatically reduce the number enumerated boards, which will speed the programs

Optimized the calculation of whether a coordinate is on or off the board, isOnBoard(). The program now runs in about 18 hours.

Profiling output (see FullRunProfilingResult.txt)  suggests that optimizing isPieceDirectionLegal() would be worthwhile.


Updated Japanese version for 2023.1

Updated the Japanese version of Versal Embedded Design Tutorial (UG1305) 2023.1 for IO site.

Updated the Japanese version of Versal Embedded Design Tutorial (UG1305) 2023.1 for IO site.


Nested slick sliders ignore touchmove:false on mobile devices

short description of the bug / issue, provide more detail below.

====================================================================
You can see in action here:
http://rocket55staging.com/cpc/products/mk-vii/
For the sliders in the Media Gallery and the Accessories Gallery
I was disabling the touchmove to begin with because touchmoving the inner (nested) slider causes the outer slider to page instead of the inner slider.  So I guess I would appreciate recommendations for either of these issues.
====================================================================
Steps to reproduce the problem
====================================================================
What is the expected behaviour?
set touchmove to false, and you cant swipe to page the slick slider
====================================================================
What is observed behaviour?
touchmove false is set but you can still swipe to page the slider.  On top of that it pages the outer slider not the inner (nested) slider.
====================================================================
More Details
Tested in safari on iphone, and chrome on android and same behavior happens on both.

Doh, my bad.  I didnt realize that there were properties for both touchmove and swipe.  I saw touch and assumed that was what I was looking for.


gh provider, map users via scim username

Our usecase:

we use AAD OIDC for user auth in OCP (using upn as userid)
we do not auth with GH as OIDC provider, as we want users to have singular identities, and the user-audience of OCP is wider than GH.
we have various teams in GH, which would map nicely over to groups in OCP and hence roles

However, syncing GH teams as groups with the current impl. would use the gh login id, while we'd like to list team-members, find their linked SCIM-identity, and then use the Username attribute, which would match upn.
Would you accept such an implementation? Could fit into the same package, and be toggled via a flag?

We'd need https://github.com/google/go-github/issues/2030 in place 1st.

Blocked on https://github.com/palantir/go-githubapp/issues/104 and https://github.com/shurcooL/graphql/issues/46


modify the service query and query by group and layer and modify the elasticsearch scroll queryMaxSize

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

And what is the reason of ElasticSearch change?
A pull request must include the explanation. One pull request is about one thing.
Please be clear about the change, otherwise, we don't know what do you mean, and how could we follow?

And what is the reason of ElasticSearch change? A pull request must include the explanation. One pull request is about one thing. Please be clear about the change, otherwise, we don't know what do you mean, and how could we follow?

Sorry,I will explain it.

And what is the reason of ElasticSearch change? A pull request must include the explanation. One pull request is about one thing. Please be clear about the change, otherwise, we don't know what do you mean, and how could we follow?

Sorry,I will explain it.

And what is the reason of ElasticSearch change? A pull request must include the explanation. One pull request is about one thing. Please be clear about the change, otherwise, we don't know what do you mean, and how could we follow?

Sorry,I will explain it.

The metadataSize will effect queryMaxSize and will effect other query and the sroll query.But when user not change the elasticsearch max result limit size.The sroll query will not cause an exception，but the other query will fail for the exception.
So I split the two size.

I can't follow you are randomly replying on different threads. If you want to discuss it, do it in a more formal way.

I can't follow you are randomly replying on different threads. If you want to discuss it, do it in a more formal w

I can't follow you are randomly replying on different threads. If you want to discuss it, do it in a more formal way.

I will change the pull request and submit it soon.Sorry for this.


[SPARK-19459] Support for nested char/varchar fields in ORC

What changes were proposed in this pull request?
This PR is a small follow-up on https://github.com/apache/spark/pull/16804. This PR also adds support for nested char/varchar fields in orc.
How was this patch tested?
I have added a regression test to the OrcSourceSuite.

cc @cloud-fan

Test build #73301 has started for PR 17030 at commit e832ce6.

Test build #73301 has finished for PR 17030 at commit e832ce6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
sealed abstract class HiveStringType extends AtomicType
case class CharType(length: Int) extends HiveStringType
case class VarcharType(length: Int) extends HiveStringType

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73301/
Test FAILed.

Test build #73346 has started for PR 17030 at commit fa2e0cc.

Test build #73346 has finished for PR 17030 at commit fa2e0cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73346/
Test PASSed.

thanks, merging to master!
it conflicts with branch 2.1, can you submit a new PR?


Allow timeseries to be sliced by specific days

Description of PR
Allows the Spread Trends timeseries to be shown as the last 7 days, last 30 days, and since forever.
Type of PR

[ ] Bugfix
[x] New feature

Relevant Issues
Fixes #629
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots

@umanghome I think you need to adjust the number of ticks on the x-axis. Right now, the ticks overlap when the 1-month tab is selected. It should be an easy fix in d3. Apart from that, looks good!

@shuklaayush - I made some changes in this commit, but I'm not sure if that's the correct way.

@umanghome thank you for the PR :)

@jeremyphilemon When would this be merged to master?

@umanghome I'm handling this. It will be merged after #733. I'll fix the merge conflicts that arise.

@shuklaayush Alright


Add AMWA ID  and add to NMOS index

@bgilmer77 can we have an INFO- number?  @peterbrightwell please add to index on https://specs.amwa.tv/nmos

INFO-004 is reserved for this  guide.


HBASE-25955 Setting NAMESPACES when adding a replication peer still requires scope definition at CF level

As mentioned on the jira description, setting either NAMESPACES or TABLECFs when calling add_peer still doesn't suffice to allow entries for the related namespaces/tables to be replicated, if those don't have replication scope set to '1' in the CF descriptor.
The above happens because ChainWalEntryFilter, currently, applies conjunction (AND) to all its chained filters. Following suggestions from @anoopsjohn on an previous PR, rather than changing this behaviour completely, this PR introduces an option to define between conjunction (AND) or disjunction (OR) logic for ChainWalEntryFilter, keeping current logic (AND) the default one, if not specified.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  8s
master passed

+1 :green_heart:
compile
2m 42s
master passed

+1 :green_heart:
shadedjars
8m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 33s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 50s
the patch passed

+1 :green_heart:
compile
2m 40s
the patch passed

+1 :green_heart:
javac
2m 40s
the patch passed

+1 :green_heart:
shadedjars
8m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 46s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 20s
hbase-client in the patch passed.

+1 :green_heart:
unit
147m 32s
hbase-server in the patch passed.

+1 :green_heart:
unit
7m 24s
hbase-shell in the patch passed.

194m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4052

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e87ae0bc4181 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1d2b8a033d

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/testReport/

Max. process+thread count
4967 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  1s
master passed

+1 :green_heart:
compile
3m 28s
master passed

+1 :green_heart:
shadedjars
8m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 50s
the patch passed

+1 :green_heart:
compile
3m 23s
the patch passed

+1 :green_heart:
javac
3m 23s
the patch passed

+1 :green_heart:
shadedjars
8m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  7s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m 32s
hbase-client in the patch passed.

-1 :x:
unit
148m 55s
hbase-server in the patch failed.

+1 :green_heart:
unit
7m 34s
hbase-shell in the patch passed.

201m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4052

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 4f4dd5837a0b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1d2b8a033d

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/testReport/

Max. process+thread count
4098 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

TestFromClientSide5 pass locally for me. Flakey?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  9s
master passed

+1 :green_heart:
compile
5m 30s
master passed

+1 :green_heart:
checkstyle
1m 25s
master passed

+1 :green_heart:
spotbugs
7m  4s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 56s
the patch passed

+1 :green_heart:
compile
5m  2s
the patch passed

+1 :green_heart:
cc
5m  2s
the patch passed

+1 :green_heart:
javac
5m  2s
the patch passed

+1 :green_heart:
checkstyle
1m 26s
the patch passed

-0 :warning:
rubocop
0m 12s
The patch generated 19 new + 481 unchanged - 5 fixed = 500 total (was 486)

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 39s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
hbaseprotoc
1m 39s
the patch passed

+1 :green_heart:
spotbugs
6m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

57m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4052

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux ffe0c23e1c73 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f78f232b28

Default Java
AdoptOpenJDK-1.8.0_282-b08

rubocop
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 19s
master passed

+1 :green_heart:
compile
1m 24s
master passed

+1 :green_heart:
shadedjars
3m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

+1 :green_heart:
shadedjars
3m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 24s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
1m  9s
hbase-client in the patch passed.

-1 :x:
unit
170m 25s
hbase-server in the patch failed.

-1 :x:
unit
7m 31s
hbase-shell in the patch failed.

198m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4052

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f4a5b98635de 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f78f232b28

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/testReport/

Max. process+thread count
2782 (vs. ulimit of 30000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4052/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Decode unknown object constellations with known types

As you mind guess my over all goal is to process every tx on a blockchain.
This also means that I don't know the constellation of what messages are in a tx and in which order they are in.
Here is an example to show case the problem:
const {
    Codec,
    FieldOtions,
    TypeFactory,
    Utils,
    Types,
    WireTypes,
} = require('js-amino');

let StdTx = TypeFactory.create('StdTx', [{
    name: 'msg',
    type: Types.ArrayInterface,
},
    {
        name: 'fee',
        type: Types.Struct,
    },
    {
        name: 'signatures',
        type: Types.ArrayStruct,
    },
    {
        name: 'memo',
        type: Types.String,
    },
]);

let MsgSend = TypeFactory.create('MsgSend', [{
    name: "to_address",
    type: Types.String,
},
    {
        name: "from_address",
        type: Types.String,
    },

    {
        name: "amount",
        type: Types.ArrayStruct
    }
]);
let MsgMultiSend = TypeFactory.create('MsgMultiSend', [{
    name: "inputs",
    type: Types.ArrayStruct
},
    {
        name: "outputs",
        type: Types.ArrayStruct
    }
]);
let Coin = TypeFactory.create('coin', [{
    name: 'denom',
    type: Types.String,
},
    {
        name: 'amount',
        type: Types.String,
    }
]);

let Input = TypeFactory.create('input', [{
    name: 'address',
    type: Types.String,
},
    {
        name: 'coins',
        type: Types.ArrayStruct,
    }
]);

let Output = TypeFactory.create('output', [{
    name: 'address',
    type: Types.String,
},
    {
        name: 'coins',
        type: Types.ArrayStruct,
    }
]);

let Fee = TypeFactory.create('fee', [{
    name: 'amount',
    type: Types.ArrayStruct,
},
    {
        name: 'gas',
        type: Types.Int64,
    }
]);

let Amount = TypeFactory.create('amount', [{
    name: 'denom',
    type: Types.String,
},
    {
        name: 'amount',
        type: Types.String,
    }
]);

let PubKeySecp256k1 = TypeFactory.create('PubKeySecp256k1', [{
    name: 's',
    type: Types.ByteSlice,
}], Types.ByteSlice)

let Signature = TypeFactory.create('signature', [{
    name: 'pub_key',
    type: Types.Interface,
},
    {
        name: 'signature',
        type: Types.ByteSlice,
    }
])

let codec = new Codec();

codec.registerConcrete(new StdTx(), 'auth/StdTx', {});
codec.registerConcrete(new MsgSend(), 'cosmos-sdk/MsgSend', {});
//codec.registerConcrete(new MsgMultiSend(), 'cosmos-sdk/MsgMultiSend', {});
codec.registerConcrete(new PubKeySecp256k1(), 'tendermint/PubKeySecp256k1', {});

let amount = new Amount('stake', "301");

let addressFrom = [ 59,58,243,13,132,163,164,202,233,7,236,93,136,166,181,175,236,69,48,186 ]
let addressTo = [ 94,222,114,42,196,107,51,203,139,142,219,243,137,60,54,250,139,153,46,168 ]

let sendMsg = new MsgSend(addressTo, addressFrom, [amount]);

let fee = new Fee([new Amount('stake', '300')], 40000);

let pubKey = new PubKeySecp256k1([2,27,24,0,255,96,147,21,64,29,132,192,108,219,59,134,206,201,126,224,63,160,24,236,170,124,164,95,43,180,6,246,250]);
let signature = [165,76,109,61,53,129,190,147,52,224,34,106,235,208,224,36,190,25,204,36,226,129,97,109,35,130,217,228,144,106,10,134,14,183,95,252,219,235,22,92,37,53,3,89,111,173,12,158,146,71,82,113,236,241,170,121,217,20,236,23,131,35,80,29];

let sig = new Signature(pubKey, signature);
let stdTx = new StdTx([sendMsg, sendMsg], fee, [sig], '');

//let jsonTx = codec.marshalJson(stdTx);
let decodedDataTx = new StdTx();

// a tx from on chain
const base64OnChain = 'hALwYl3uCj6oo2GaChRe3nIqxGszy4uO2/OJPDb6i5kuqBIUOzrzDYSjpMrpB+xdiKa1r+xFMLoaDAoFc3Rha2USAzMwMQo+qKNhmgoUXt5yKsRrM8uLjtvziTw2+ouZLqgSFDs68w2Eo6TK6QfsXYimta/sRTC6GgwKBXN0YWtlEgMzMDESEgoMCgVzdGFrZRIDMzAwEMC4AhpqCibrWumHIQIbGAD/YJMVQB2EwGzbO4bOyX7gP6AY7Kp8pF8rtAb2+hJApUxtPTWBvpM04CJq69DgJL4ZzCTigWFtI4LZ5JBqCoYOt1/82+sWXCU1A1lvrQyekkdScezxqnnZFOwXgyNQHQ==';
const hexOnChainTx = Buffer.from(base64OnChain, 'base64').toString('hex');
console.log("hex:\n", hexOnChainTx);

codec.unMarshalBinary(Utils.fromHex(hexOnChainTx), decodedDataTx);
console.log("Decoded data:\n", JSON.stringify(decodedDataTx.JsObject()));

In this example I am able do decode the following message so all good:
{
	"msg": [{
		"to_address": "^�r*�k3ˋ���<6���.�",
		"from_address": ";:�\r�����\u0007�]�����E0�",
		"amount": [{
			"denom": "stake",
			"amount": "301"
		}]
	}, {
		"to_address": "^�r*�k3ˋ���<6���.�",
		"from_address": ";:�\r�����\u0007�]�����E0�",
		"amount": [{
			"denom": "stake",
			"amount": "301"
		}]
	}],
	"fee": {
		"amount": [{
			"denom": "stake",
			"amount": "300"
		}],
		"gas": 40000
	},
	"signatures": [{
		"pub_key": [2, 27, 24, 0, 255, 96, 147, 21, 64, 29, 132, 192, 108, 219, 59, 134, 206, 201, 126, 224, 63, 160, 24, 236, 170, 124, 164, 95, 43, 180, 6, 246, 250],
		"signature": [165, 76, 109, 61, 53, 129, 190, 147, 52, 224, 34, 106, 235, 208, 224, 36, 190, 25, 204, 36, 226, 129, 97, 109, 35, 130, 217, 228, 144, 106, 10, 134, 14, 183, 95, 252, 219, 235, 22, 92, 37, 53, 3, 89, 111, 173, 12, 158, 146, 71, 82, 113, 236, 241, 170, 121, 217, 20, 236, 23, 131, 35, 80, 29]
	}],
	"memo": []
}

But the problem is that I have to init the StdTx with the following line:
let stdTx = new StdTx([sendMsg, sendMsg], fee, [sig], ''); otherwise the decoding will fail with:
js-amino-example/node_modules/js-amino/src/binaryDecoder.js:178
    for (let i = 0; i < instance.length; ++i) {
                                 ^

TypeError: Cannot read property 'length' of undefined
    at decodeBinaryArray (js-amino-example/node_modules/js-amino/src/binaryDecoder.js:178:34)
    at decodeBinaryField (js-amino-example/node_modules/js-amino/src/binaryDecoder.js:97:23)
    at Reflection.ownKeys.forEach (js-amino-example/node_modules/js-amino/src/binaryDecoder.js:151:13)
    at Array.forEach (<anonymous>)
    at decodeBinaryStruct (js-amino-example/node_modules/js-amino/src/binaryDecoder.js:145:34)
    at Object.decodeBinary (js-amino-example/node_modules/js-amino/src/binaryDecoder.js:40:31)
    at Codec.unMarshalBinary (js-amino-example/node_modules/js-amino/src/codec.js:136:23)
    at Object.<anonymous> (js-amino-example/index.js:149:7)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)

As you can see I have to put in the same sendMsg twice to get it to work.
Ideally it would be very nice to not need the line at all since you cant really predict all the array constellations because its in Interface.
It should be able to identify witch object to use since there are prefixes on the encoded bytes.
This will also be a problem with tx that have other types of messages like the MsgMultiSend type.
Aditional it would be also great if the encoder would add the type of the message to the decoded object like this.:
{
      "type": "cosmos-sdk/MsgSend",
      "value": {
        "from_address": "cosmos1tm08y2kydveuhzuwm0ecj0pkl29ejt4gghxw35",
        "to_address": "cosmos18va0xrvy5wjv46g8a3wc3f444lky2v96luase3",
        "amount": [
          {
            "denom": "stake",
            "amount": "301"
          }
        ]
      }
    }

Thanks for your reporting, I will answer all your questions soon

This library is encountering one problem with JS language.
For exp: If you define a structure like this :
let A = TypeFactory.create('A', [{     name: 'b',     type: Types.Struct, } ]);
b  is Types.Struct and it can be any type of Object struct, if you init :
 let aObj = new A(newB())  the codec will know the default value of b inside  A, this initiation is something like caching the default value for obj. In Go, it's very easy because you can declare the true type for the first time. But anyway, do you have any suggestion for improving this ? Any idea is welcome

It should be able to identify witch object to use since there are prefixes on the encoded bytes.
Nice idea, I think I can recursively to parse the prefix bytes for predicting the type to decode. It should be a new developbranch

Here is a way cosmos/tendermit is doing it currently:
https://github.com/tendermint/go-amino#prefix-bytes-to-identify-the-concrete-type
If thats to much just giving in a list would also be great like here:
https://github.com/binance-chain/javascript-sdk/blob/cd52817f8eae7eb81d32639fc0a9a68ea01dc2c5/src/tx/index.js#L23
Just putting it in as an additional param in the registerConcrete function would be a easy solution or?

Yes, that's actually the Js-Amino is doing. I parse whole byte array to read the prefixes and know which type to decode. But As I told you before, you know a "123" prefix number is belong to which registered type but you can not know exactly the Types.Struct inside it(if you don't init it for the first time). With Go, the compiler takes care for you, but with JS, it's very tricky

I think I am lacking the JS knowledge here, naively could a very ugly way be try and error?
So just building up each possible object and then trying if it fits?

Yes, when you Init one object, the "codec" will know the "concrete type" to decode it later. I'm very sorry if it's a work-around until now

anyway, the plan for this improvement will be started soon


Cloud functions module

Thanks Lorenzo! I completely forgot to add the ingress / egress settings even though I planned on adding them, good catch! I will do a second PR soon.


consumers query bug in konga 0.14.1

Hi ,I found a bug while using konga. Konga cannot query all the consumers completely when
the number of consumers is more than 1000. By anylizing the konga 's  api. I found that konga  call url '/consumers?size=4294967295' which attempt to query all the consumers in database . But kong only  return 1000 consumers at once. this really trouble me a lot when I want to add a user to kong but it  hints me this consumer has alreadly created  and show nothing while querying this consumer 。 I want to know is there anyway to resolve the problem.

@skyniu , thanks for the feedback. I'll check it out and keep you posted.

@skyniu , that was the way Konga used to work. Now, it fetches all consumers from db in chunks of 1000's.
https://github.com/pantsel/konga/blob/b2bb772f50488473b3908e87feab2ecf0b53978d/api/services/KongService.js#L150
That particular change is in place in Konga 0.14.1.
I've tested it on my environment and all the consumers are loaded correctly even if they are more than 1000.
I'm using Kong 1.0.0.
What Kong version are you using?

My kong version is 0.14.1  。.

I think the problem is that konga does not  query all the data . kong doesn't support return all the datas at a time and return a field 'offset' every time, which can call it to get data in next page . I think konga may not use the 'offset ' field.

local function validate_size_value(size)
if floor(size) ~= size or
size < 1 or
size > 1000 then
return nil, "size must be an integer between 1 and 1000"
end
return true
end
//this is kong 's source code .They put a limit on the maximum size。 I think this made konga only query 1000  consumers at a time.  I hope you can make some attention to it 。

Hi I found I gave you the wrong konga version,I am sorry about it,.In my produce environment ,my konga version is 0.13.0 and kong version is  0.14.1.In konga:0.14.1 ,the problem was fixed as you say. But in konga:0.13.0 ,this problem may already exists . As konga:0.14.1  was not compatible with kong 0.14.1 , My produce environment may increase some  risk if upgrade kong to 1.X. So can you fix the problem in konga:0.13.0 .


Make interop client compatible with non-HTTP/0.9 endpoints

Running the interop client against some endpoints gets most of items failing because they don't support HTTP/0.9 anymore.
Update interop/src/main.rs to fix that and make fix H3 if it doesn't match the needs for it.

There might also be other impls that don't support H3, so taking a flag for which to use could be prudent.

This also ha been fixed in #551


Suggestion to parse solution when projects have similar names

Created a fix to detect collision caused by a unique project name's normalization, reported on issue #3019

What's wrong with this:
https://github.com/Forgind/msbuild/commit/13ae999eeacb3893fc99599978959a2f8f6697e0
?

What's wrong with this:
Forgind@13ae999
?

As far as I know, the unique name is based on the project name, not the file name.

Thanks for your work here!


An invalid LanguageConfiguration.wordPattern can cause vscode to crash

This is an odd set of circumstances, but it causes v10.10 to crash (on Windows), and it didn't in 10.8, so I'll report it anyway. I was experiencing a lot of crashes while developing autocomplete in an extension, and found that it boiled down to this:
If an extension provides a LanguageConfiguration with a wordPattern that can match an empty string (eg /\w*/), and it then registers a CompletionItemProvider that provides no completion items (an empty array): the intellisense will show "Loading..." for about 10 seconds, then vscode will crash.
Here's example code (full sample attached). This extension creates a new language "abc" with extension ".abc".
import * as vscode from 'vscode';
import { TextDocument, Position, CancellationToken, CompletionItem, languages } from 'vscode';

const languageConfiguration: vscode.LanguageConfiguration = {
	wordPattern: /\w*/
}

export function activate(context: vscode.ExtensionContext)
{
	context.subscriptions.push(
		languages.setLanguageConfiguration('abc', languageConfiguration));

	context.subscriptions.push(
		languages.registerCompletionItemProvider('abc', new CompletionItemProvider()));
}

class CompletionItemProvider implements vscode.CompletionItemProvider {
	provideCompletionItems(
		document: TextDocument, position: Position, token: CancellationToken)
		: CompletionItem[]
	{
		return [];
	}
}

Both conditions must be true: if the completion provider provides at least one result then it's shown without a problem. If the wordPattern is a valid one then the intellisense shows "No suggestions." for an empty array without problem.
I think it can also cause crashes with a hover provider too but I haven't pinned that one down.

@stkb It does crash :scream: Will drill into this asap. Thanks for reporting such awesome steps.

@alexandrudima This is happening with the textualSuggest and us never returning from MirrorModel._wordenize

@stkb wondering if you have shipped your extension with such a word definition. Now we will throw an exception from setLanguageConfiguration which might be to harsh

@jrieken Thanks, it's in the vscode-elm extension, and was of course a bug, so throwing an error seems fine. It just didn't get noticed until v10.10 where I experienced the crashes. Have submitted a fix there.
Some other people have also reported crashes with that extension (sbrink/vscode-elm#41), but hopefully that was the reason.

great


Add first version of Hazelcast Jet based Java Runner

This is a first working version of a Java Runner based on Hazelcast Jet (https://github.com/hazelcast/hazelcast-jet). With it we have aimed for the batching (bounded data) scenario for now, but adding the missing pieces for unbounded data is something we fully intend to do.
The functionality is relatively complete, see the validatesRunner task in the :beam-runners-jet module. I've excluded the Splittable DoFn tests completely, because we have not implemented that functionality yet and also the single test case for Impulse, because we have a problem with that related to parallelism. Beyond these though the results are: 235 tests completed, 10 failed, 2 skipped. The 10 failed ones are also caused by missing features, like timer support, multi-graph support and such. Again, to be solved soon.
The Nexmark testsuite also runs, I'm using the following params: -Pnexmark.runner=:beam-runners-jet -Pnexmark.args="--runner=JetRunner --suite=SMOKE --streaming=false --manageResources=false --monitorJobs=true --jetGroupName=jet"
The last two Nexmark queries aren't being run successfully, but the cause of that seems to be external to our specific runner, a NullPointerException at NexmarkQueryName.fromNumber(NexmarkQueryName.java:78).
This is it. What we have done so far is mostly about pure functionality. We have not yet worked on performance (for example we don't do any pipeline surgery or fusing), which is far away from what standalone Jet is capable of, but I hope that this is still a worth-vile start.
Lots and lots of things remain to be added and improved but I'm really curious what you think about it so far and would really appreciate your feedback.
R: @kennknowles
R: @mxm

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Nice!!
This is large enough I want to be clear: Have you filed an ICLA with the ASF? Is there applicable CCLA? Anyone else contributing to this code?

Great to see this coming and already integrated with ValidatesRunner and Nexmark. I will definitely have a closer look the next days.
Usually it is enough for you to file the ICLA, unless your company has to grant rights (CCLA).

FYI: we are working on the needed agreements, a CCLA will be required. I'll let you know once it's ready.

I've submitted the CCLA.

Hi guys. I've just added some more changes (a metrics related bug fix and generic handling for triggers). Wanted to ask if you had any time to look into this PR? I realise how much code this is, is there something I could do to facilitate your review? Walk you through the Jet part or anything else?

Apologies @jbartok, I'll take a look later today. Since you have integrated with ValidatesRunner and Nexmark, I don't think we need to review the Jet integration code in detail. Generally, we would expect members of the Jet community to maintain the Runner, or put differently, we want to welcome the Jet community inside the Beam community :) I just wanted to point that out, since it is also a possibility to maintain the Runner externally but still be listed as a Runner on the Beam website.

Hi Maximilian. First of all thank you very much for taking the time to review this.
I've just pushed some changes, hopefully I've correctly addressed most of your concerns.
Some of them I didn't, but I'm planning to do so in a follow-up Pull Request. We have been planning one anyways, because we want to make the Jet Runner more usable (and do some usability tests too, because it was only about having the necessary code until now) . For example add easy to use Gradle tasks for starting/stopping external Jet clusters, submitting Beam Pipelines to such clusters and so on.
Btw. a question: once we have the usability part in place and we are confident that this runner is ok for Beam users to use, will it be ok to also submit an edit request for the Capability Matrix page, put ourselves "on the map", so to speak?
Best regards and thanks again for your help & time.

Thanks for the update. Of course, all Runners deserve an entrance in the capability matrix. Feel free to submit a follow-up PR for that.
I think this looks good to merge but I'd wait to see if @kennknowles wants to do a review as well.

I've made the requested naming change.

As far as I can tell the "Python_PVR_Flink" check failure is not caused by my changes...

Run Python_PVR_Flink PreCommit

Hi Guys. Could you pls. merge this in, if everything is in order? I would like to open a new PR in which we would add a couple of missing pieces of code and start making the runner actually usable for running the Beam examples with.
Sorry for pestering, I just want to not miss your next release. From what I understand from your build setup, once we are present in a released version it will be much simpler to use our runner for running the examples.

I've looked at this conflict that popped up, but it's a bit tricky... The change on master that causes it is such that if I adapt to it, then exactly the part that I've used to name the runner "experimental" is what goes away... Should I instead rename "jet" into "experimental-jet"?
And even if I ignore this aspect and try to adapt, there will still be work left on merge. Should I even attempt to change what's on the branch or will it be resolved during merge?

I agree, we should merge this. Everything is ok from my side and it looks like @kennknowles requested changes have been resolved. As for the release, we will have to cherry-pick this to the release branch because it has already been cut. Shouldn't be a problem though.
@jbartok Could you rebase the PR to master and get rid of any merge commits?

@jbartok I see that there are unrelated changes in some of the commits. Could you please remove those or simply squash all commits into a single commit? Will then merge.

Done.

Thanks @jbartok! Could you assign this JIRA issue to yourself? https://jira.apache.org/jira/browse/BEAM-7305 If you do not have permissions, please ping me and provide your JIRA username.
You mentioned that you wanted to include the Runner in the release. Please open a PR against the release-2.13.0 branch for that.


Update onboarding UI

Needs work on:

[ ] Background images for the onboarding steps
[x] Transitioning out of the animations

Fixes #8
Fixes #19

Animations work, but the complete event doesn't fire for some reason and doesn't let us unmount the animation and show the next question. This part is relevant.

This is functional now. We just need to wire up the right background images.

Animations:
https://github.com/ooni/probe-ios/tree/master/ooniprobe/Resources/anim
https://github.com/ooni/probe-android/tree/master/app/src/main/assets/anim

@hellais

Can you check if you are able to drag with the topbar on onboarding screen?
With the new animations, do you get the same sense of lag? I didn't find any difference by adding a speed={2} prop to <Lottie> in here.

Can you check if you are able to drag with the topbar on onboarding screen?

Yes the dragging now works great!

With the new animations, do you get the same sense of lag? I didn't find any difference by adding a speed={2} prop to  in here.

It may have been an issue with the other animations you were using. I don't see anymore lag now.

I made the quiz modal (and animations) in the wider aspect ratio before.


TileLayer/GridLayer requesting tiles outside of specified bounds

How to reproduce

Leaflet version I'm using: 1.0.2

Browser (with version) I'm using: Chrome 54.0.2840.98

OS/Platform (with version) I'm using: macOS Sierra 10.12

Add a tile layer with bounds to the map.

What behaviour I'm expecting and which behaviour I'm seeing
I would expect that only tiles inside the bounding box are requested and displayed.
Instead there are tiles requested and displayed that are outside the boundingbox. More specific tiles that are located near "The International Date Line".

Minimal example reproducing the issue
In the example there are tiles requested and displayed that are located inside the red box and are not part of the bounds.
There has already been some conversation with @IvanSanchez in the leaflet Gitter channel about this topic on November 24, 14:05.
Most likely its some kind of issue that has to do with coordinates being wrapped around the date line and not correct boundingboxes being returned from a private GridLayer function. Here the concluding quote from Ivan:

The L.GridLayer._tileCoordsToBounds private method is not returning good bboxes for tiles with a x-coordinate of -1

https://playground-leaflet.rhcloud.com/lulic/1/edit?html,output

Note: That playground shows the expected bounds of the {x: -1, y: 1, z: 2} tile in red, and the actual in blue.

I think the other way around. Actual bounds in red, expected in blue.

@mrMetalWood Ahem.
    // Actual tile bounds of a tile with a x-coordinate of -1 (red)
    // i.e. {x: -1, y: 1, z: 2}
    var tileRect = L.rectangle(
      position._tileCoordsToBounds(L.point({x: -1, y: 1, z: 2})),
      {color: 'blue', weight: 5}
    ).addTo(map);

    // Expected tile bounds of a tile with a x-coordinate of -1 (blue)
    // i.e. {x: -1, y: 1, z: 2}
    var tileRect = L.rectangle(
      [[0,-180],[66.51326044311188,-270]],
      {color: 'red', weight: 1}
    ).addTo(map);

I made a mistake in the comments, so actual = blue, expected = red.

I have been looking into this and, as @mrMetalWood said, there is a wrapper that converts the coordinates to fit a specific range  (file /core/Util.js, line 102):
wrapNum: function (x, range, includeMax) {
	var max = range[1],
	    min = range[0],
	    d = max - min;
	return x === max && includeMax ? x : ((x - min) % d + d) % d + min;
}

This function is called here with the default range [-180, 180] (file /geo/crs/CRS.js, line 100):
wrapLatLng: function (latlng) {
	var lng = this.wrapLng ? L.Util.wrapNum(latlng.lng, this.wrapLng, true) : latlng.lng,
	    lat = this.wrapLat ? L.Util.wrapNum(latlng.lat, this.wrapLat, true) : latlng.lat,
	    alt = latlng.alt;

	return L.latLng(lat, lng, alt);
}

@IvanSanchez Correct me if I'm wrong, but I think this would force the GridLayer to be within the International Date Line range.
A possible, albeit probably undesired, solution would be to stop enforcing this wrapper for this particular scenario. I'm going to experiment with it tomorrow and will follow up if I get any interesting results.


Performance Improvements

I found this excellent repo to use with some work I'm doing with very large images.
I see some places where loops could be replaced with list comprehensions or with some built-in methods in Python. I expect this would help improve performance by quite a bit. Would you be open to a PR with such performance-related changes?

sure!
I tried to balance the performance and the readability of the code. If you see improvements feel free to submit a PR.

So far I'm seeing an improvement of ~18% in the runtime of the update function, which I think is the most important and time-consuming function here. I'll have the PR ready in a day or two. I am currently trying to properly organized the commits.
I was wondering, is there a way to insert a batch of values and then call trim/trim_in_place only once per batch? I realize that this would widen the error bounds from the paper but it might be a lot faster for a large distribution.

Nice. Yes update is the bottleneck because in most use-cases it is called orders of magnitudes more than the other ones.
I did not look at feeding data with batches or micro-batches because the intent is to use this library with streaming data. In this way of working [micro]batching data is complex. So for now I would prefer to stick with a pure streaming way of working.

merged in #5


services.guix does not exist

https://github.com/NixOS/nixpkgs/blob/576ecd43d3b864966b4423a853412d6177775e8b/nixos/modules/services/misc/guix/default.nix#L53
I am trying to add services.guix.enable = true; to my nixos config, but it doesn't find the option (23.11). I believe the line above should be cfg = with lib; ...  as later on the module checks lib.mkIf cfg.enable but defines the enable option on options.services.guix instead of config.services.guix.
Will report back if if I get around to testing this fix.

CC @foo-dogsquared

Woops my bad its been a while since I wrote a module...
Regardless, I realized that services/misc/guix did not exist in my nixpkgs outPath. I did some digging on the github and "solved" this issue by setting my system flake as follows:
    nixpkgs.url = "github:nixos/nixpkgs/nixos-23.11";

instead of github:nixos/nixpkgs/23.11 (ie the 23.11 tag). Don't know if this is user error on my part or something bigger.
Marking as closed.

23.11 is the release tag (frozen in time at Nov 2023)
nixos-23.11 is the current stable branch (until the 24.05 release)
As you guessed, nixos-23.11 is what is meant to be used.

Thanks for clarifying, learning something new about this project everyday.
Soham Gumaste
@.***
On Wed, May 1, 2024 at 3:45 PM éclairevoyant @.***>
wrote:

23.11 is the release tag (frozen in time at Nov 2023)
nixos-23.11 is the current stable branch (until the 24.05 release)
As you guessed, nixos-23.11 is what is meant to be used.
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/issues/308327#issuecomment-2089113500,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABWJLT5JTQSYTGWKB5OM2LTZAFH77AVCNFSM6AAAAABHCJGUHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBZGEYTGNJQGA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


List widget not enforcing required fields or default values

- Do you want to request a feature or report a bug?
Bug
- What is the current behavior?
For a collection that includes a list widget, when I add a new item to the list, but don't provide values in any of the fields, I am able to save changes without complaint from the UI. The resultant object within that list within that collection item is missing any keys for which I omitted values. This is true for list fields with required: true as well as for fields where required key is unspecified (assumed required by default).
For example, I can save this (see screenshot) even when list items One / Two / Three are required (implicitly or explicitly). Also note missing default value for Three.
I have not tested regex validation for list fields, but also wonder about that.

- If the current behavior is a bug, please provide the steps to reproduce.
Push below config.yml to GitHub, open the CMS UI after everything builds on Netlify, add new collection item, add a value to one of the required collection fields (e.g., title), add new list item, omit all fields for new list item, click save.
- What is the expected behavior?
I was expecting to see the same behavior as when omitting values for required fields not contained within lists, i.e., I wasn't expecting the UI to permit saving. Also was expecting to see default values pre-filled by the UI.

- Please mention your versions where applicable.

Netlify CMS version: 1.7.0
Browser version: Chrome 66.0.3359.139

Node.JS version:
Operating System:
- Please link or paste your config.yml below if applicable.
backend:
  name: git-gateway
  branch: develop-netlify
publish_mode: editorial_workflow
media_folder: "assets/netlify"
collections:
- name: "example"
  label: "Example"
  folder: "_example"
  create: true
  fields:
  - {name: "title", label: "Title", widget: "string"}
  - {name: "default", label: "Default", widget: "string", default: "foo"}
  - name: "test"
    label: "Test"
    widget: "list"
    fields:
    - {name: "one", label: "One", widget: "string"} # implicitly required by default?
    - {name: "two", label: "Two", widget: "string", required: true} # explicitly required
    - {name: "three", label: "Three", widget: "string", default: "foo"} # specifying default

This is a duplicate of #467. Can you add any additional info there?

Got it, sorry about that!


Nicer, more hackable search URL

Before: home/DocumentationSearchForm?Search=bbcode&action_results=Search After: /?q=bbcode
Should be possible by adding a check in index(), and overwriting the form action :) Not sure how to get rid of the button, perhaps we can do a redirect in index() as well (which would slow down search, so not ideal)

Closing due to inactivity, feel free to reopen if this is still a problem

Note: upcoming epic of work to look at search holistically across all SilverStripe sites


GIOU计算问题

计算GIOU时，是不是写错了？giou = iou - (area_c - area_i) / area_c.clamp(1e-16)，应该减并集面积吧。。。是故意减的交面积吗？

 But GIoU is not used in our current experiments. So the results reported in our paper and this repo should be fine. We will fix it soon!


Add support for docker 26.0.2

The following docker versions are to be added:
v26.0.2
The same approach as https://github.com/rancher/rancher/issues/45291 is to be followed for implementation and testing.

Validated on rancher v2.9-head(7ee02ac)
Validated docker 26.0.2 install script by provisioning node driver as well as custom clusters using below OSes:

Rocky 9.3, 8.9
RHEL 9.3, 8.9
OL 9.3, 8.9
Ubuntu 24.04, 22.04
CentOS 7.9

Released

https://releases.rancher.com/install-docker/26.0.2.sh

https://releases.rancher.com/install-docker/26.0.sh points to 26.0.2

Closing the issue, since testing and release have been completed.


Feature request: Option for automatic off only

I have quite a few lights in the house where I currently have timers that turn the lights off if there is no one in the room. I have no interest in automatically turning them on when someone enters the room, but I would like to be able to turn them off after a period of time if someone "forgets" to.
I'm not sure if the best way to do this would be to have separate control_lights and control_lights_off features, or if there should be main_lights and main_lights_off config options. I like the latter gives more flexibility, but it would also require that there be an option for "None" in main_lights instead of the current default of "all".
Having the ability to just turn lights off when the presence detector goes off would let me retire quite a bit of manual code I have running in my ISY.

After re-reading synapselabs.io posts bring homeassistant areas to life with magic areas and doing some testing here, I believe the existing integration will work for your needs...

Magic Areas will automatically turn off all light, climate and media_player entities in that area when presence is changed to off. This ensures you’ll never let anything running when the room is not being used.

On disable state, Magic Areas won’t turn any lights on, but will still turn them off if the area presence state goes to off.

The area will turn off area lights whenever presence is cleared regardless whether night: is true or false.
As long as night: is never true, it will not turn on the lights when presence is detected.
So just specify a valid entity ID to disable automatic light control [night_entity] and set its Entity state to disable automatic light control to a value that will never be true.  I.e. rather than on|off enter something like never.
Or use a new entity that you may never set to on and specify its state for true as on.
As long as the state of the night_entity never matches the specified state string, automatic lighting will never turn the lights on but will turn them off when presence is cleared.

I haven't had any time lately to dig into this, work has been a nightmare... I'm hoping to spend some time on it this weekend.

I need to run a couple more tests, but I think this is going to work. I have it reliably turning lights off in my home office, I just need to make sure that isn't turning them on after dark tonight.

Let me know so I can close this

This does work, I have disabled my old programs that turn off the lights after a period of time and am now using Magic Areas to do that. Nice work on this module! The only drawback to this method is that I can't use "sleep" lights, as they never trigger since the area never has "night" set to true.


create with symmetric encryption should automatically ask for passphrase

If passphrase hasn't been defined by any mean (keyring, env and so on) then the create  command should by default ask for the passphrase:
Examples
given no passphrase in the env, nor in the keyring the following behavior is expected:
trousseau create --encryption-type symmetric
Passphrase:

given passphrase already provided through environment or keyring:
trousseau create --encryption-type symmetric
echo $status
0

Whatever is the environment, if --ask-passphrase is provided, the ask passphrase should be prompted
export TROUSSEAU_KEYRING_SERVICE=mykeyringentry
trousseau --ask-passphrase create --encryption-type symmetric
Passphrase:

Fixed, thanks to @jd1123  \o/


Support Multiple Block and Cell Size for GPU::HOG

Hello,
Would be really helpful if HOG could support multiple block and cell sizes, trying to do OCR using HOG and SVM and not being able to select cell size is very limiting.
Please state the information for your system

OpenCV 3.x
Host OS: Linux (Ubuntu 14.04)  / Mac OS X 10.11.3 / Windows 10

In which part of the OpenCV library you got the issue?

objdetect
HOG

I am sorry but this is not true I think. Take a look at the gpu hog.cpp sample, right here. At line 290 you can clearly see that the cell size and block size can be selected as you wish for the HOGDescriptor...


Add new release v1.41.0 to interop matrix

waiting for python images:
https://github.com/grpc/grpc/pull/27703
https://github.com/grpc/grpc/pull/27620
Will re-run adhoc after these submissions

running adhoc again at:
https://fusion2.corp.google.com/invocations/be0c13a9-0cd7-46f0-93ed-0319518dc230/targets


performance (# of recompiles): do not constant fold when it provides no benefit

🚀 Feature
If there's no advantage to a constant fold, we should not perform it. Consider the following difference between two graphs:
$ diff -u graph-14.log.txt graph-30.log.txt
--- graph-14.log.txt    2024-07-31 19:06:59.118184530 +0000
+++ graph-30.log.txt    2024-07-31 19:07:05.450221326 +0000
@@ -1,4 +1,4 @@
-graph 14:
+graph 30:
 # Constructed by Delete Last Used (took 0 milliseconds)
 import torch
 from torch import Tensor
@@ -37,15 +37,15 @@
     # value_layer = ltorch.reshape(t4, [80, 384, 128])  # value_layer: "cuda:0 f16[80, 384, 128]"
       # value_layer = prims.reshape(t4, (80, 384, 128))  # value_layer: "cuda:0 f16[80, 384, 128]"
   del t4
-  matmul_result = torch.baddbmm(matmul_input_buffer, query_layer, key_layer, beta=0.0, alpha=0.08838834764831843, out=None)  # matmul_result: "cuda:0 f32[80, 384, 384]"
-    # matmul_result = ltorch.baddbmm(matmul_input_buffer, query_layer, key_layer, beta=0.0, alpha=0.08838834764831843, out=None)  # matmul_result: "cuda:0 f32[80, 384, 384]"
+  matmul_result = torch.baddbmm(matmul_input_buffer, query_layer, key_layer, beta=0.0, alpha=0.044194173824159216, out=None)  # matmul_result: "cuda:0 f32[80, 384, 384]"
+    # matmul_result = ltorch.baddbmm(matmul_input_buffer, query_layer, key_layer, beta=0.0, alpha=0.044194173824159216, out=None)  # matmul_result: "cuda:0 f32[80, 384, 384]"
       # t28 = prims.convert_element_type(query_layer, dtypes.float16)  # t28: "cuda:0 f16[80, 384, 128]"
       # t29 = prims.convert_element_type(key_layer, dtypes.float16)  # t29: "cuda:0 f16[80, 128, 384]"
       # t30 = ltorch.matmul(t28, t29)  # t30: "cuda:0 f16[80, 384, 384]"
         # t30 = prims.matmul(t28, t29)  # t30: "cuda:0 f16[80, 384, 384]"
-      # t33 = ltorch.mul(0.08838834764831843, t30)  # t33: "cuda:0 f16[80, 384, 384]"
+      # t33 = ltorch.mul(0.044194173824159216, t30)  # t33: "cuda:0 f16[80, 384, 384]"
         # t31 = prims.convert_element_type(t30, dtypes.float32)  # t31: "cuda:0 f32[80, 384, 384]"
-        # t32 = prims.mul(0.08838834764831843, t31)  # t32: "cuda:0 f32[80, 384, 384]"
+        # t32 = prims.mul(0.044194173824159216, t31)  # t32: "cuda:0 f32[80, 384, 384]"
         # t33 = prims.convert_element_type(t32, dtypes.float16)  # t33: "cuda:0 f16[80, 384, 384]"
       # t34 = ltorch.mul(0.0, matmul_input_buffer)  # t34: "cuda:0 f32[80, 384, 384]"
         # t34 = prims.mul(0.0, matmul_input_buffer)  # t34: "cuda:0 f32[80, 384, 384]"

graph-14.log.txt
graph-30.log.txt
Here it seems we folded in the alpha value, but passing the single element value instead of a constant is not going to change performance in any meaningful way, and it would mean that we could reuse the previous graph instead of generating another one.
Motivation
NeMo's NeVA includes 83 candidate graphs (when dynamic=False). These are graphs 14 and 30.
Pitch
Ideally alpha would become an argument to def computation and just get passed in.
Alternatives
The existing approach is just to recompile, which works but induces more recompilation than necessary.
Additional context
cc @tfogal

closing for now; this is a minor thing and actually isn't possible with thunder.jit alone; I'll want to create a wider design idea for dealing with duplicate graphs and circulate that, instead of one-offing each possible item that comes up.