AzureDisk backed PersistentVolumes causing moved Pods to take very long to start up

I used the instructions here to allow for the Pods in Kubernetes App to have Persistent Volumes backed by Azure Disks that I provisioned separately. All worked exceptionally well -- until I enable the Cluster Autoscaler. Now, when I remove enough Pods from my AKS cluster that the Cluster Autoscaler decides to remove a Node from the VM Scale Set, Pods on that node that need to be rescheduled have to wait for the node to shut down before it releases their volumes! I see this error: "Multi-Attach error for volume "<volume name>" Volume is already exclusively attached to one node and can't be attached to another" for the pod -- until the Node shuts down, at which point it can finally remount the volume. Please mention this in the docs and if possible, provide a link to a workaround. Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 74be7378-92bc-0e59-0b70-c6b10e80d9b6
Version Independent ID: f7f1eeb3-efe7-86e2-1fd7-04341b2c77cc
Content: Create a static volume for pods in Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/azure-disk-volume.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@emacdona Thanks for the question! We are investigating and will update you shortly.

@emacdona, could you share the version of AKS cluster you are seeing the error on.

Did you mean Kubernetes version? If so:
kubectl version Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.4", GitCommit:"8d8aa39598534325ad77120c120a22b3a990b5ea", GitTreeState:"clean", BuildDate:"2020-03-12T23:41:24Z", GoVersion:"go1.14", Compiler:"gc", Platform:"darwin/amd64"} Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.10", GitCommit:"059c666b8d0cce7219d2958e6ecc3198072de9bc", GitTreeState:"clean", BuildDate:"2020-04-03T15:17:29Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}
If not, how do I find the version of AKS that I'm using?

that's good enough. v1.15.10 is your Kubernetes version you selected when you installed AKS.
how many disks are getting detached when the node scales down ?
https://docs.microsoft.com/en-us/azure/aks/troubleshooting#large-number-of-azure-disks-causes-slow-attachdetach
HEre's a List of known issues with version fix and also existing issues.
https://github.com/andyzhangx/demo/blob/master/issues/azuredisk-issues.md#25-multi-attach-error
Note that when 1.15.10, there are still a few issues that were fixed after this release.
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.15.md#other-bug-cleanup-or-flake
Fix: add remediation in azure disk attach/detach (#88444, @andyzhangx) [SIG Cloud Provider]
Fix: get azure disk lun timeout issue (#88158, @andyzhangx) [SIG Cloud Provider and Storage]
Add delays between goroutines for vm instance update (#88094, @aramase) [SIG Cloud Provider]
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.15.md#bug-or-regression
For volumes that allow attaches across multiple nodes, attach and detach operations across different nodes are now executed in parallel. (#89241, @verult) [SIG Apps, Node and Storage]

how many disks are getting detached when the node scales down ?
https://docs.microsoft.com/en-us/azure/aks/troubleshooting#large-number-of-azure-disks-causes-slow-attachdetach

So, I'm running 25 StatefulSets, each with one Replica -- with a PVC connecting to a PV backed by an AzureDisk. The NodePool starts with 2 nodes and the Cluster Autoscaler is configured with a min of 2 nodes and max of 5. Just giving some context for the next statement...
When I deploy the app, it scales up to 4 nodes, so I'm guessing it puts either 6 or 7 Pods per Node. So, under the 10 volume threshold in the bug mentioned above.
What's REALLY interesting about this is that it appears the Autoscaler is trying to work around the issue... because my first attempt at fixing the problem was switching to Azure File Shares. When I did that, the Autoscaler took a VERY long time to decide to go from 2 nodes to 3 nodes. In the meantime, the app was unusable because the Pods kept failing to come up and were continuously restarting. But that's another issue for another time. Only mentioning it because the Autoscaler seems to behave differently for AzureDisks vs AzureFiles.

HEre's a List of known issues with version fix and also existing issues.
https://github.com/andyzhangx/demo/blob/master/issues/azuredisk-issues.md#25-multi-attach-error

This looks promising, but the workaround seems only for Rolling Updates. I'm experiencing the problem during an Autoscaler Scale Down event. I'll research further and see if it still applies, though.
Thanks!

Actually, the more I look at that workaround, the more it looks like it will prevent the actual error message from happening -- but do nothing to shorten the amount of time required to move a pod from one node to another.
Sorry, I'm in a state where I can't test that theory at the moment. When I do get a chance to test it, I'll report back :-) (Probably tomorrow morning).

Unfortunately current slowness is on Azure Compute(CRP) level, here are the main issues:

Disk attach/detach latency is high
Cluster scale up is slow

Parallelization of disk attach/detach in VMSS/VMAS is now only 3

CRP team are working on this, current target date is around Oct this year.
Also, there is a new vhd disk feature based on azure file which could attach/detach disk < 1s, consider that as an option if cx really has concern about disk attach/detach time cost: https://github.com/kubernetes-sigs/azurefile-csi-driver/tree/master/deploy/example/disk

Thanks for the info! I'll check out the vhd disk feature.

Thanks @andyzhangx
@emacdona  Thanks for bringing this to our attention. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


add support for slowlog command

@wziww this looks pretty good - sorry for the delay. I have 2 small questions if you are still around. Anyway I will merge this tomorrow.

@wziww thanks, merged this in https://github.com/go-redis/redis/pull/1472


Revisit condor shadow hooks with plugin staging

Making this an actual issue so that I can aim to do it. For v7.6.0 I want to revisit condor's shadow job hooks with our Pelican plugin staging to see if we change a file on an origin that we can detect that and change the file. Cole's changes to condor file transfers are making progress but not fully implemented however, we should start working on this again so that we can see if this works how we want it to and just make changes when needed.

Making a note here:
We can make a test for this using our federation in a box however, how it is currently written it cannot work. It most likely will work with this PR being merged: #798, because of the changes to how we handle metadata and it would work with an osdf:// url and prefix. It will work because it will load the metadata from config since it should be set already and not completely rely on topology. Therefore, we can set our fed in a box to config and utilize that to run this as a test locally.

Note: Got a successful test run on HTCondor AP submit4! All that is needed now to complete this PR is a test but currently waiting on #798 to be merged first

This needs revisiting


Cannot Export nor Backup

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce
For any task, click 'Actions' -> 'Export tasks dataset'.
Pick any Format
The file does not download.
Furthermore, 'Actions' -> 'Backup task' also does not work.
Expected Behavior
For any task, click 'Actions' -> 'Export tasks dataset'.
Pick any Format
A file in the respective format starts to download.
Furthermore, 'Actions' -> 'Backup task' downloads the backup of the task
Possible Solution
No response
Context
No response
Environment
CVAT.ai

I got the same issue.

Even I am getting the same issue, not able to export annotations.

Are u still experience the issue? There was a long queue of requests, but now it is resolved.

The issue seems to be resolved.
Thanks


10/31/2018 01:56 : Create Pull Request for branch master -> prTesting1_2018103101

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


chore: make clippy happy

Codecov Report

Merging #2267 (cf48adf) into main (ec097fa) will decrease coverage by 54.68%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #2267       +/-   ##
===========================================
- Coverage   70.75%   16.07%   -54.68%
===========================================
  Files         472      472
  Lines       56721    56738       +17
===========================================
- Hits        40132     9121    -31011
- Misses      16589    47617    +31028

Flag
Coverage Δ

integration-tests
16.07% <0.00%> (-0.07%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/trie/src/cursor/storage_cursor.rs
0.00% <0.00%> (-93.75%)
:arrow_down:

crates/trie/src/hash_builder/mod.rs
0.00% <0.00%> (-92.71%)
:arrow_down:

crates/trie/src/trie.rs
0.00% <0.00%> (-99.02%)
:arrow_down:

... and 328 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Flaky test: RunsWithIterationEnvVariable

This test fails occasionally with the following error:
System.TimeoutException : The operation at /_/test/dotnet-watch.FunctionalTests/AwaitableProcess.cs:83 timed out after reaching the limit of 30000ms.
   at Microsoft.AspNetCore.Testing.TaskExtensions.TimeoutAfter[T](Task`1 task, TimeSpan timeout, String filePath, Int32 lineNumber)
   at Microsoft.DotNet.Watcher.Tools.FunctionalTests.AwaitableProcess.GetOutputLineAsync(String message, TimeSpan timeout) in /_/test/dotnet-watch.FunctionalTests/AwaitableProcess.cs:line 83
   at Microsoft.DotNet.Watcher.Tools.FunctionalTests.DotNetWatcherTests.RunsWithIterationEnvVariable() in /_/test/dotnet-watch.FunctionalTests/DotNetWatcherTests.cs:line 42
--- End of stack trace from previous location where exception was thrown ---
------- Stdout: -------
The temporary test folder is /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde
Copying project /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/TestProjects/KitchenSink to /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink
Restoring msbuild project in KitchenSink
Project directory: '/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink'
Started process 44313: /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/.dotnet/dotnet restore
  Restoring packages for /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink/KitchenSink.csproj...
  Generating MSBuild file /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink/.net/obj/KitchenSink.csproj.nuget.g.props.
  Generating MSBuild file /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink/.net/obj/KitchenSink.csproj.nuget.g.targets.
  Restore completed in 446.21 ms for /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink/KitchenSink.csproj.
Process exited 44313
Process exited 44313 with code 0
Building KitchenSink
Project directory: '/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink'
Started process 44343: /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/.dotnet/dotnet build
Microsoft (R) Build Engine version <IP_ADDRESS>72 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.
  Restore completed in 76.01 ms for /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink/KitchenSink.csproj.
  KitchenSink -> /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink/.net/bin/Release/netcoreapp2.2/KitchenSink.dll
Build succeeded.
    0 Warning(s)
    0 Error(s)
Time Elapsed 00:00:03.35
Process exited 44343
Process exited 44343 with code 0
7/30/2018 3:57:52 PM: process start: '/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/.dotnet/dotnet /Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tool/dotnet-watch.dll run --'
Waiting for output line [msg == 'Started']. Will wait for 120 sec.
7/30/2018 3:57:52 PM: post: 'watch : Running MSBuild target 'GenerateWatchList' on '/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink/KitchenSink.csproj''
7/30/2018 3:57:52 PM: recv: 'watch : Running MSBuild target 'GenerateWatchList' on '/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink/KitchenSink.csproj''
7/30/2018 3:57:52 PM: post: 'watch : Started '/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/.dotnet/dotnet' with process id 44377'
7/30/2018 3:57:52 PM: recv: 'watch : Started '/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/.dotnet/dotnet' with process id 44377'
7/30/2018 3:57:54 PM: post: 'watch : Process id 44377 ran for 1760ms'
7/30/2018 3:57:54 PM: recv: 'watch : Process id 44377 ran for 1760ms'
7/30/2018 3:57:54 PM: post: 'watch : Watching 2 file(s) for changes'
7/30/2018 3:57:54 PM: recv: 'watch : Watching 2 file(s) for changes'
7/30/2018 3:57:54 PM: post: 'watch : Started '/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/.dotnet/dotnet' with process id 44398'
7/30/2018 3:57:54 PM: recv: 'watch : Started '/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/.dotnet/dotnet' with process id 44398'
7/30/2018 3:57:54 PM: post: 'watch : Running dotnet with the following arguments: run --'
7/30/2018 3:57:54 PM: recv: 'watch : Running dotnet with the following arguments: run --'
7/30/2018 3:57:54 PM: post: 'watch : Started'
7/30/2018 3:57:54 PM: recv: 'watch : Started'
7/30/2018 3:57:54 PM: post: 'Telemetry is: Disabled'
7/30/2018 3:57:54 PM: recv: 'Telemetry is: Disabled'
7/30/2018 3:57:58 PM: post: 'Running dotnet exec "/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink/.net/bin/Release/netcoreapp2.2/KitchenSink.dll"'
7/30/2018 3:57:58 PM: recv: 'Running dotnet exec "/Users/asplab/TeamCity/work/33bdfc1cae7b2a38/modules/DotNetTools/bin/dotnet-watch.FunctionalTests/Release/netcoreapp2.2/tmp/ie5ss3zj.qde/KitchenSink/.net/bin/Release/netcoreapp2.2/KitchenSink.dll"'
7/30/2018 3:57:58 PM: post: 'Process ID: 44434'
7/30/2018 3:57:58 PM: recv: 'Process
...

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.
CC @Eilon,@muratg,@mkArtakMSFT
This issue was made automatically. If there is a problem contact @ryanbrandenburg.

Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

Is this actually a flaky test?

No, this is a regular test failure, fix the test/product (TODO: Link to commit/PR)
Yes, proceed below...

Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)

[ ] File a bug against the product (TODO: Link to other bug)
Is it possible to change the test to avoid the flakiness?

Yes? Go to the "Change the test!" section.
No?

[ ] Disable the test (TODO: Link to PR/commit)
[ ] Wait for other bug to be resolved
[ ] Wait for us to get build that has the fix
[ ] Re-enable our test (TODO: Link to PR/commit)
[ ] Close this bug

Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)

Is there is a way to change our test to avoid this flakiness?

Yes? Change the test!

[ ] Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
[ ] Run the test 100 times locally as a sanity check.
[ ] Close this bug

No?

[ ] Delete the test because flaky tests are not useful (TODO: Link to PR/commit)

This comment was made automatically. If there is a problem contact @ryanbrandenburg.

RunsWithIterationEnvVariable failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.

RunsWithIterationEnvVariable failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.

Duplicate of #467
This should have been resolved already in https://github.com/aspnet/DotNetTools/pull/469. Those changes have not yet made it into a Universe build.


Revert "Next gensim release"

Reverts conda-forge/gensim-feedstock#15

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

Whenever possible python packages should use pip. See https://conda-forge.org/docs/meta.html#use-pip


Options When You Own All Sites

We're using Identity Server to authenticate web apps and api across a few domains, but we own all of them, and they all have access to a common datastore.
The nice thing about Identity Server is, for .NET web apps, we can plug in the middleware and it just works. I'm finding it's not quite as easy to secure a Node/Express web api with OAuth2. That's a little disappointing.
But, JWTs have some features that we just don't need: PKI and statelessness.
So my questions is, would it make sense to modify Identity Server to do the following:

Validate JWTs (or an alternative token format) with a shared, non-public signing cert
Make JWTs lighter by removing the header, issuer and audience values
Do active token validation agains the DB, thereby greatly simplifying the logout story, and gaining token invalidation.

I'm not asking these questions lightly, like "Hey, can I author invalid JWTs and then complain that JWT parsing libs can't read them." Rather, I'd like to know if the Identity Server project/code has enough value for my scenario, or it's better to look elsewhere.

Have you looked into reference tokens?

Thanks. I found some blog posts and issues on Reference Tokens. The docs are empty. Am I correct that access token validation works out of the box with the Thinktecture Middleware, app.UseIdentityServerAuthentication, by contacting an HTTPS token validation endpoint? If so, that seems to conflict with the idea of a common data store. There is a way to add a custom token validator when using app.UseIdentityServerAuthentication right?

Kerberos is designed to do this. Why don’t you just use Kerberos?
thx ..tom
From: Josh<EMAIL_ADDRESS>Sent: Thursday, March 16, 2017 3:50 AM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS>Subject: [IdentityServer/IdentityServer4] Options When You Own All Sites (#930)
We're using Identity Server to authenticate web apps and api across a few domains, but we own all of them, and they all have access to a common datastore.
The nice thing about Identity Server is, for .NET web apps, we can plug in the middleware and it just works. I'm finding it's not quite as easy to secure a Node/Express web api with OAuth2. That's a little disappointing.
But, JWTs have some features that we just don't need: PKI and statelessness.
So my questions is, would it make sense to modify Identity Server to do the following:

Validate JWTs (or an alternative token format) with a shared, non-public signing cert
Make JWTs lighter by removing the header, issuer and audience values
Do active token validation agains the DB, thereby greatly simplifying the logout story, and gaining token invalidation.

I'm not asking these questions lightly, like "Hey, can I author invalid JWTs and then complain that JWT parsing libs can't read them." Rather, I'd like to know if the Identity Server project/code has enough value for my scenario, or it's better to look elsewhere.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/IdentityServer/IdentityServer4/issues/930, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKxq1vnxD_gBSxYYr81hxMcXYo8plI0Jks5rmRPjgaJpZM4MfH_a.


Add 1990-2000 to the set of EIA 861 years

Changes:

Pick the "reformatted" version of the EIA file when available (1990-2011) Edit: Pick the "original" version for all years.
Fix some small typos in the README
Update the eia861.html test data page

Notes:

Please don't merge yet, until I can change the EIA 861 file mapping in pudl.
I selected the "reformatted" files for the whole 1990-2011 period. If you think it'd be better to use the original files for the whole period, or to use the original files for 2001-2011 (the period that's already included) and the reformatted files for 1990-2000, let me know! Edit: Pick the "original" version for all years.

cc @aesharpe
Addresses part of https://github.com/catalyst-cooperative/pudl/issues/923

FYI, tests are passing here, but the check fails because of SLACK_WEBHOOK_URL.

FYI, tests are passing here, but the check fails because of SLACK_WEBHOOK_URL.

Again.

@karldw Is this still a draft? Or shall we merge it and try creating a new archive?  I guess we'll need to update things in the pudl-zenodo-storage repo as well.

Feel free to merge!


Marketing resource url incorrect for BulkCreateAdsByListingId

https://github.com/davidtsadler/ebay-sdk-php/blob/42714ad203f0d37be53aa11fbe78b3eb6b18d34b/src/Marketing/Services/MarketingService.php#L34
The resource url must be  ad_campaign/{campaign_id}/bulk_create_ads_by_listing_id

the project is nearly two years old, the project owner didn´t say or do anything since a year, do yourself a favor and take a look into this: https://github.com/OpenAPITools/openapi-generator


RGBA colors for FancyZones

Description of the new feature / enhancement
I wish to chose alfa channel on colors for FancyZones, like to remove borders or make it semitransparent.
Scenario when this would be used?
Customization
Supporting information
No response

For the snap zone?


Specify message format of saved IoT Hub messages in storage container

Please extend the documentation to specify the file format used by the files stored in the storage container.
After some research I found that it's the Apache Avro format (https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-devguide-endpoints).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b0bc375-145f-3e45-e1e9-1869e183a4a3
Version Independent ID: 8dc4d773-0a92-31de-6ce4-4a118d552f6a
Content
Content Source
Service: iot-hub

@mguntli Great feedback! I have assigned the issue to the author who will work on an update.


[v1.x][BUGFIX][ONEDNN] Remove next_impl calls from deconvolution

Description
next_impl is broken for deconvolution since oneDNN 2.3. This change removes calls to this function because it never worked anyway - it always returned false, never finding another implementation (to achieve this, a new primitive descriptior had to be created)
Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e.


Restore-DbaDbCertificate - add parameter, fix some formatting

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[X] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Added the -EncryptionPassword parameter, previously certificates were being restored to the server and then encrypted with the Decryption password. Now If you specify an encryption password it will use that, however if you don't it will be encrypted using the master key which I believe would be preferable behaviour (at least it is in my shop).
Approach

Adds -EncryptionPassword parameter
Commands to test

#encrypts using master key
Restore-DbaDbCertificate -SqlInstance $server -Path $path -Password $password

#encrypts using password
Restore-DbaDbCertificate -SqlInstance $server -Path $path -Password $password -EncryptionPassword $password

Excellent,t hank you!

@potatoqualitee just a heads up, I don't think the tests are working so I'm going to look at those today.


Error on click with leaflet v1.0.0-rc.1 release

Leaflet hotline works fine but there is this error en each click:
leaflet-src.js:8755: Uncaught TypeError: Cannot read property 'contains' of undefined
L.Polyline.prototype._containsPoint = function (p, closed) {
	var i, j, k, len, len2, part,
	    w = this._clickTolerance();

	if (!this._pxBounds.contains(p)) { return false; } // Error here this._pxBounds is undefined

	[...]

This is because between the version v1.0.0-rc.1 release and v1.0.0-beta.2 the _project function changed.
_project: function () {
	var pxBounds = new L.Bounds();
	this._rings = [];
	this._projectLatlngs(this._latlngs, this._rings, pxBounds);
	var w = this._clickTolerance(),
	    p = new L.Point(w, w);
	if (this._bounds.isValid() && pxBounds.isValid()) { // pxBounds.isValid() is false
		pxBounds.min._subtract(p);
		pxBounds.max._add(p);
		this._pxBounds = pxBounds;
	}
},

So this.pxBounds is not defined!

Thanks for the detailed report.
I'll go over the plugin to update it to the latest Leaflet RC soonish.

I'm encountering this as well. A fix would be much appreciated! :D
@YuanxiangFranck any hack to get around this for now?

It's fixed in version 0.3.0.

👍 If you are ever in Columbia, MO I will buy you a 🍺 .


Adding a new resource to introductions section in  README.md

I used Ramda extensively in Functional Programming in JavaScript, published this year. I think it's also a good reference for developers wanting to learn more about it.
Thanks!

cool! so when can we expect our free copies? :stuck_out_tongue_winking_eye:
congrats on publishing your book.

I see many occurrences of _ in chapter 3. :stuck_out_tongue_winking_eye:
I don't think this book belongs in the list. The current items are Ramda-centric and/or curry-centric rather than general FP resources for JavaScript programmers.

Yeah there's a bit of Lodash in CH03 lol :-)  after teaching currying it's Ramda from then on for the most part.
I understand. Thanks.

I agree that it probably doesn't belong on this list, but I would suggest that you make a PR to
https://github.com/stoeffel/awesome-fp-js

And I wonder if Ramda should offer a link to that list as well.
I did read the book, BTW.  It was several months ago, and I keep saying that I'm going to get around to writing reviews of the various FP in JS books available, but it never bubbles to the top of my list.  FWIW, this one ended up below Fogus and far above Mantyla.  But so far no one has come close to Lonsdorf and Braithwaite.

Thanks for the feedback. Yes, absolutely, I read them all as well and I'm a huge fan of Lonsdorf and Braithwaite. The stuff they write about is so incredibly well articulated. Sorry, didn't intend for this to be a book review lol, certainly that's not ramda-centric.
Thanks again.


Update docs to reflect latest master

@guidow, PTAL

Coverage remained the same at 65.47% when pulling a5595916360b2c9f2fc629f5c908b3b6a1c33b80 on doc_update into 7e80cb13dc71afa680891ba3ddb036aa82687a62 on master.

Coverage remained the same at 65.47% when pulling a5595916360b2c9f2fc629f5c908b3b6a1c33b80 on doc_update into 7e80cb13dc71afa680891ba3ddb036aa82687a62 on master.

Coverage remained the same at 65.47% when pulling a5595916360b2c9f2fc629f5c908b3b6a1c33b80 on doc_update into 7e80cb13dc71afa680891ba3ddb036aa82687a62 on master.

Looks okay, I guess.


Update tests for latest mini_mime update

Description
I noticed merging #5287 today resulted in two unrelated test failures that didn't occur before yesterday:
  1) Failure:
TestBlob#test_mime_type [/home/runner/work/linguist/linguist/test/test_blob.rb:17]:
Expected: "application/postscript"
  Actual: "application/pdf"

  2) Failure:
TestFileBlob#test_mime_type [/home/runner/work/linguist/linguist/test/test_file_blob.rb:31]:
Expected: "application/postscript"
  Actual: "application/pdf"

MiniMime released a new version yesterday which has pulled in the latest updates from https://github.com/mime-types/mime-types-data which has in turn pulled in @Alhadis's fix to correctly classify .ai files as PDFs in https://github.com/mime-types/mime-types-data/issues/22
This PR updates our tests to reflect these changes.
[ Checklist removed as it doesn't apply ]

I was wondering about this quite recently…


Implement In-app Update feature

Reference link for In-App update : https://developer.android.com/guide/playcore/in-app-updates/kotlin-java

Hey @aritra-tech , I would like to work on this feature.
Can you please assign this issue to me?

Hey @devedroy any update?

Sorry @devedroy, I'm unassigning this issue it's almost 1 week but there has been no update till now.
Thank you.


python311Packages.google-cloud-datacatalog: 3.18.2 -> 3.18.3

Changelog: https://github.com/googleapis/google-cloud-python/blob/google-cloud-datacatalog-v3.18.3/packages/google-cloud-datacatalog/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 293855 run on x86_64-linux 1

4 packages marked as broken and skipped:

python312Packages.google-cloud-bigquery
python312Packages.google-cloud-bigquery.dist
python312Packages.google-cloud-datacatalog
python312Packages.google-cloud-datacatalog.dist

6 packages built:

python311Packages.dbt-bigquery
python311Packages.dbt-bigquery.dist
python311Packages.google-cloud-bigquery
python311Packages.google-cloud-bigquery.dist
python311Packages.google-cloud-datacatalog
python311Packages.google-cloud-datacatalog.dist

Result of nixpkgs-review pr 293855 run on x86_64-linux 1

4 packages marked as broken and skipped:

python312Packages.google-cloud-bigquery
python312Packages.google-cloud-bigquery.dist
python312Packages.google-cloud-datacatalog
python312Packages.google-cloud-datacatalog.dist

6 packages built:

python311Packages.dbt-bigquery
python311Packages.dbt-bigquery.dist
python311Packages.google-cloud-bigquery
python311Packages.google-cloud-bigquery.dist
python311Packages.google-cloud-datacatalog
python311Packages.google-cloud-datacatalog.dist


[ISSUE #4445] Update  doc

Make sure set the target branch to develop
What is the purpose of the change
Close #4445
ps: I do not find  this issue  in en  doc
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #4548 (7914996) into develop (493e52b) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4548      +/-   ##
=============================================
- Coverage      48.17%   48.02%   -0.16%
+ Complexity      5129     5116      -13
=============================================
  Files            649      649
  Lines          43045    43045
  Branches        5630     5630
=============================================
- Hits           20737    20671      -66
- Misses         19801    19864      +63
- Partials        2507     2510       +3

Impacted Files
Coverage Δ

...va/org/apache/rocketmq/logging/inner/Appender.java
29.21% <0.00%> (-7.87%)
:arrow_down:

...tmq/namesrv/processor/DefaultRequestProcessor.java
66.04% <0.00%> (-7.48%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
46.26% <0.00%> (-5.98%)
:arrow_down:

...in/java/org/apache/rocketmq/test/util/MQAdmin.java
38.88% <0.00%> (-5.56%)
:arrow_down:

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
66.07% <0.00%> (-5.36%)
:arrow_down:

...ache/rocketmq/broker/topic/TopicConfigManager.java
54.61% <0.00%> (-4.62%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
39.13% <0.00%> (-4.35%)
:arrow_down:

...ava/org/apache/rocketmq/test/util/VerifyUtils.java
46.26% <0.00%> (-2.99%)
:arrow_down:

...ava/org/apache/rocketmq/filter/util/BitsArray.java
59.82% <0.00%> (-2.57%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
60.43% <0.00%> (-2.20%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493e52b...7914996. Read the comment docs.

Coverage decreased (-0.1%) to 52.083% when pulling 7914996d82c1ef4b5798fb82eaa23bdbb4bb60f2 on Oliverwqcwrw:develop-remove-useless-17 into 493e52b945c7fdbdddb759847816d4952c966cff on apache:develop.

Coverage decreased (-0.1%) to 52.083% when pulling 7914996d82c1ef4b5798fb82eaa23bdbb4bb60f2 on Oliverwqcwrw:develop-remove-useless-17 into 493e52b945c7fdbdddb759847816d4952c966cff on apache:develop.

Hi @Oliverwqcwrw ,
Nice catch. We're now planning to restructure and rewrite our documents (as you could see there are many errors in docs and the content is a bit messy), where you can find the work in https://github.com/apache/rocketmq-site/tree/new-official-website/docs. Would you mind joining us and giving us a hand?

I'd love to join. How should I contribute ?


Add node e2e test timeout.

Add timeout for node e2e test.
The build is red now, it seems that cri-containerd or containerd gets unresponsive during test running. However,

I could not reproduce it in my local machine;
because of travis 50m test timeout, it doesn't even get a chance to upload test log, so that there is no way to debug it.

This PR added 40m timeout to node e2e test. Usually it only takes 30-31 minutes. If it timeout, test will abort, and we still get the chance to collect test logs.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

LGTM

@abhi Thanks!


fix Fix some p0 case

What problem does this PR solve?
fix test_partial_update_2pc_schema_change and test_f_2pc_schema_change case due to changes in https://github.com/apache/doris/pull/45211
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[x] No need to test or manual test. Explain why:

[x] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run p0


Decide on error boundaries.

Now that we are on React 16, we should probably decide where to create "error boundaries" (https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html). Right now, thrown errors will now dismount the entire app if not caught. Should they be per-widget? per-page? per-component?

Agreed, thanks for raising this.
A prescriptive approach is probably best. Error boundaries can actually be dangerous otherwise - allowing parts of the app to run while other parts are inactive can lead to cases we simply don't expect and aren't set up for.
The first applied error boundary, and a generic, reusable boundary component, are in #779.

What about creating an error boundary around the entire app, so we don't just get a blank white screen on crash?

With the generic component and the app now wrapped in it, I think we can close this.


multialloc fix

This PR mirrors Jordan's multialloc fix in svmbir.
Tested with demo_3D_shepp_logan.py on the cluster. Results are visually the same as before.

Ideally we'd test this on an M1 before approving.  But I think only Jordan and Natalie have an M1 at this point.

Check all calls to multialloc.  For the array dimensions you need to have the argument type match what va_arg is expecting in multialloc (currently 'int').  It looks like many of the calls to multialloc use 'long int'.  See the comment in https://github.com/HPImaging/sv-mbirct/issues/16
After the fixes, test on an M1 if you can. That's the only place I've seen the type mismatch cause a problem, and it's fatal.

Thanks Jordan. I'll check and fix all multialloc calls.
My personal laptop is M1, but I might need some time to set up everything (since I've never run mbircone or svmbir on that before).
I'll drop a message when I'm finished with the fix.
Regards,
Diyu

From: Sherman J Kisner @.>
Sent: Monday, August 22, 2022 11:39 AM
To: cabouman/mbircone @.>
Cc: Diyu Yang @.>; Author @.>
Subject: Re: [cabouman/mbircone] multialloc fix (PR #90)
---- External Email: Use caution with attachments, links, or sharing data ----
Check all calls to multialloc. For the array dimensions you need to have the argument type match what va_arg is expecting in multialloc (currently 'int'). It looks like many of the calls to multialloc use 'long int'. See the comment in HPImaging/sv-mbirct#16https://github.com/HPImaging/sv-mbirct/issues/16
After the fixes, test on an M1 if you can. That's the only place I've seen the type mismatch cause a problem, and it's fatal.
—
Reply to this email directly, view it on GitHubhttps://github.com/cabouman/mbircone/pull/90#issuecomment-1222532694, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB2Q7OA3MZ3SYK25PJANGVDV2ONJNANCNFSM57H2TKWA.
You are receiving this because you authored the thread.Message ID: @.***>

Looks good. I can test on an M1. What demo would you suggest running?

Thanks a lot Jordan!
demo_3D_shepp_logan.py should be a good test.
If you want to test memory usage, then you may change num_det_rows and num_det_channels from 128 to some large values.
Regards,
Diyu

From: Sherman J Kisner @.>
Sent: Monday, August 22, 2022 12:02 PM
To: cabouman/mbircone @.>
Cc: Diyu Yang @.>; Author @.>
Subject: Re: [cabouman/mbircone] multialloc fix (PR #90)
---- External Email: Use caution with attachments, links, or sharing data ----
Looks good. I can test on an M1. What demo would you suggest running?
—
Reply to this email directly, view it on GitHubhttps://github.com/cabouman/mbircone/pull/90#issuecomment-1222563450, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB2Q7OCOABWXGKODM2GOK4TV2OQBJANCNFSM57H2TKWA.
You are receiving this because you authored the thread.Message ID: @.***>

I ran demo_3D_shepp_logan.py on mac/M1, and the output looks consistent with a run on linux.
BUT, I did have a separate issue in that "pip install -r requirements_demo.txt" would fail on my mac because it appears tensorflow isn't building wheels for macOS/arm64.  demo_3D_shepp_logan.py doesn't require tensorflow so I just deleted the line. I'll open a separate issue for this.


Refactored Attachment handling

Added a calculate layout method that takes a already built attributed string.
Moved LayoutBehaviour to the types' OverflowPolicy but kept backwards compatibility.
Attachments are no longer included in the span, and are handled as a special kind of character.
Attachments are not cached by vector x anymore, they only request images with a target size, and it's up to the loadImage callback implementer to render accordingly.
Attachments are rendered with the size of the current font instead of the size referenced from the son file.

I fixed the conflicts here. Seems to be working on our side. Would be nice to get this merged, but I understand there are still some philosophical debates to be worked out around this change...

I'll start working on this now.

I still don't see a point in this change "Attachments are no longer included in the span, and are handled as a special kind of character." You need it to edit internal string representation which I never intended to be editable. I don't see why you don't want to change templates in styled strings and then render them normally.

what do you mean with change templates?

[f=arial22]%number_of_coins%{coint}[/f] -> [f=arial22]1 000 000${coint}[/f]

The thing is that the attachments are visible and are kind of a character. So when I want to edit a section of the text, I don't want to care about the formatting by code, but I care about the attachments. I want to be able to swap for example %number_of_coins% with "no coins" or "10 {coin} !!!". Right now it's extremely easy to do this, but if the attachments spawn a new section, than we have no choice but to parse the original raw string and not use the already built AttributedString object to edit sections.
Also, an attachment is not formatting, so it's very weird that it is parsed as such, even if it makes the code easier to write, it doesn't make it easier to understand at all.

Hi all,
I tried to merge this but it doesn't work as there are changes in at least buildunitylayout library which are not provided as a PR.
If I understood our collaboration concept well - we will need all changes in SGF libraries to be visible for us.
@catdawg please let me know your thoughts.

Hi @dejan-gd , since duellbuildunitylayout is not a public repo we cannot actually PR. But we can provide you with the patches.

You can pull request on private repos.

we have no choice but to parse the original raw string and not use the already built AttributedString object to edit sections

Honestly, I don't see why it's bad. Cost of constructing AttributedString from template is insignificant compared to layouting + rasterization work that is needed in any case

Hi @catdawg, @jcxavier,
can't build it with the source from the ZIP. I'm getting this ouput:
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:25: characters 21-35 : game_engine.components.text.VectorTextComponent has no field text
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:27: characters 15-44 : game_engine.components.text.VectorTextComponent has no field horizontalAlignment
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:40: characters 15-42 : game_engine.components.text.VectorTextComponent has no field verticalAlignment
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:53: characters 15-40 : game_engine.components.text.VectorTextComponent has no field layoutBehaviour
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:70: characters 8-26 : game_engine.components.text.VectorTextComponent has no field text
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:75: characters 16-49 : game_engine.components.text.VectorTextComponent has no field horizontalAlignment
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:78: characters 16-49 : game_engine.components.text.VectorTextComponent has no field horizontalAlignment
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:81: characters 16-49 : game_engine.components.text.VectorTextComponent has no field horizontalAlignment
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:87: characters 16-47 : game_engine.components.text.VectorTextComponent has no field verticalAlignment
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:90: characters 16-47 : game_engine.components.text.VectorTextComponent has no field verticalAlignment
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:93: characters 16-47 : game_engine.components.text.VectorTextComponent has no field verticalAlignment
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:99: characters 16-45 : game_engine.components.text.VectorTextComponent has no field layoutBehaviour
.duell/lib/game_engine/game_engine/serialization/serializers/VectorTextComponentSerializer.hx:102: characters 16-45 : game_engine.components.text.VectorTextComponent has no field layoutBehaviour

Please, could you provide complete patch for the changes in libraries game_engine and duellbuildunitylayout?

As suggested by @catdawg - we will close this PR.


[JENKINS-54375] Use JFR released version in demo

JENKINS-54375
Once JFR has been released, we can use it on the demo. Some code changes were necessary for that.
@oleg-nenashev @raul-arabaolaza @fcojfernandez

It would be great to get this released once approved & merged, since the demo depends on that new version still to be released.

@oleg-nenashev I'm not sure I understand. I've tested it locally and it works fine, so no need to use the ci.jenkins.io-runner.
Why splitting in two? I think together it's straightforward to see that the new feature allows to use the version parameter in the yaml configuration file.

Why splitting in two? I think together it's straightforward to see that the new feature allows to use the version parameter in the yaml configuration file.

Because it would not be a clean merge after that, and I prefer to avoid it. I also want to verify the new mode on a more complex setup

https://github.com/oleg-nenashev/ci.jenkins.io-runner/pull/20 reproduces the issue I was concerned about:

There are multiple versions of binaries being packaged into Docker image
JARs from App Assembler have a priority
It is possible to stop including libs in appassembler and using the exposed WAR, but it will be a pretty big fix to make

===== TEST CLASSLOADING ===
  16.616 [id=26]	SEVERE	jenkins.InitReactorRunner$1#onTaskFailed: Failed GroovyInitScript.init
java.lang.ClassNotFoundException: org.kohsuke.stapler.EvaluationTrace.ApplicationTracer
	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at groovy.lang.GroovyClassLoader.loadClass(GroovyClassLoader.java:677)
	at groovy.lang.GroovyClassLoader$InnerLoader.loadClass(GroovyClassLoader.java:425)
	at groovy.lang.GroovyClassLoader.loadClass(GroovyClassLoader.java:787)
	at groovy.lang.GroovyClassLoader.loadClass(GroovyClassLoader.java:775)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:264)
	at System.run(System.groovy:14)
	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:585)
	at jenkins.util.groovy.GroovyHookScript.execute(GroovyHookScript.java:136)
	at jenkins.util.groovy.GroovyHookScript.execute(GroovyHookScript.java:119)
	at jenkins.util.groovy.GroovyHookScript.run(GroovyHookScript.java:89)
	at hudson.init.impl.GroovyInitScript.init(GroovyInitScript.java:41)
Caused: java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:104)
Caused: java.lang.Error
	at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:110)

@oleg-nenashev thanks for the explanation and the production example. I am closing this until I am able to push the necessary fixes.


ci: fix: Running workflows on pr's from forks

Now we have dublicate runs on PR's not coming from forks but there are worse things then that

Codecov Report

Merging #2847 (7c6c6a9) into develop (474b3d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #2847   +/-   ##
=======================================
  Coverage     7.05%   7.05%
=======================================
  Files          219     219
  Lines        10864   10864
=======================================
  Hits           766     766
  Misses       10098   10098

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


network connectivity check

need to check the type of network access before trying to connect to the database. if there is no connection or local only, no internet then it should not even try to query the database. right now it does the query no matter what, then checks if the value returned is null and informs the user from there but that uses unnecessary time and resources.

This is now fixed. It checks for wifi first, if not available then it checks mobile connection, and if not available it skips the attempt to connect to the db. eventually you will be able to choose in settings if you want to use mobile connection or wifi only.


logout method not working

hi, thanks in advance for your library, i having problems with the logout method , i call but but ai reopen the app and ask AuthManager.getInstance().isLoggedIn() always is returning true after call AuthManager.getInstance().logout()

I can not reproduce the bug. Please create a sample project which can be used to reproduce it.

I can not reproduce the bug. Please create a sample project which can be used to reproduce it.

was my fault, the logout method is working fine , closing ..


[BUG] Piston Example misses LineSeries

Describe the bug
After cloning plotters to a ne wdirectory in /tmp and building it with 'cargo build',
I changed into the example directory for piston and running it, it complains of being unable to find "LineSeries".
To Reproduce
cd /tmp
git clone https://github.com/38/plotters.git
cd plotters
cargo build
cd examples/piston-demo
cargo run --release
Version Information
For now I'm pulling plotters from master;
I'll try to build the example from the lates release on crates.io as next, but doubt it'll chnage the outcome to the better.

Might be related to #30, which does not mention LineSeries, but is still open.

I just tried, creating a new crate, pasting the piston example, and using plotters by it's latest version insted of by a given path results in the same error about "draw_piston_window()",  which @bermeon found earlier.

Hello, thanks for reporting this.
I believe this is unrelated to issue #30, and the cause should be the example is out-of-dated after we add the feature that allows different components opt in and out.
Just add line series to its Cargo.tmol should work.  Believe it's fixed on master now.
Thanks for the help,
Cheers

I just verified it using the master branch; adding the line in the toml resolves the issue.
Thanks for the effort, this helps me a lot to gain a foothold in rust and gui design.
However, I wish you happy Christmas holidays!


add .AlServiceC to index

Problem Description
We include this library from others by using direct links to filenames:
const m_servicec = require('al-collector-js/al_servicec');

This is bad practice as it increase lib interface dependency.
Solution Description
Use index file with specific names
PRs to other libs are to follow.

closing, as it's implemented here: https://github.com/alertlogic/al-collector-js/pull/10


cmd/gc: optimize memset idiom

There should be a fast way to zero memory.

When implementing object pools (reusing []byte or []int), for safety the application's
pool allocator needs to zero memory before giving it back out to callers.  Currently Go
can't do it very quickly.

I consider this fixed. Optimizing non-zero cases isn't very interesting.
We can open another bug if people feel strongly about doing more.


⚠ Bofrost.de has degraded performance

In 3275a6e, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 983 ms

Resolved: Bofrost.de performance has improved in c93f7d7.


Wrong RSA buffer size in encrypt mode

The enclosed emulator fork creates a one-byte-shorter array when the RSA engine is used in encryption mode. The corresponding original issue in the upstream version of jCardSim:  https://github.com/licel/jcardsim/issues/106.
It's quite interesting, that even though the issue was never fixed in the upstream GitHub repository, the 'com.licel:jcardsim:3.0.5' maven package creates buffer arrays of a correct length.
Corresponding pull request: https://github.com/ph4r05/jcardsim/pull/1

I have tested the latest master as ph4r05/jcardsim#1 is already merged for some time and the issue is indeed fixed. Thanks!


Fix non-determinism in test - AlignByDeviceOrderByLimitOffsetTest#orderByExpressionTest1

Description
The test org.apache.iotdb.db.queryengine.plan.planner.distribution.AlignByDeviceOrderByLimitOffsetTest#orderByExpressionTest1 fails under NonDex tool which detects non-deterministic nature of tests with when non-deterministic data structures are used. The failure behavior is defined by incorrect ordering of relatedDataRegions. relatedDataRegions is a hashset and hence doesn't have deterministic order as per the java documentation, but is iterated over in the method constructDeviceViewNodeListWithCrossRegion.
How to Reproduce
mvn -pl iotdb-core/datanode edu.illinois:nondex-maven-plugin:2.1.7:nondex
-Dtest=org.apache.iotdb.db.queryengine.plan.planner.distribution.AlignByDeviceOrderByLimitOffsetTest#orderByExpressionTest1
-DnondexRuns=10

Error
[INFO] Running org.apache.iotdb.db.queryengine.plan.planner.distribution.AlignByDeviceOrderByLimitOffsetTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.430 s <<< FAILURE! -- in org.apache.iotdb.db.queryengine.plan.planner.distribution.AlignByDeviceOrderByLimitOffsetTest
[ERROR] org.apache.iotdb.db.queryengine.plan.planner.distribution.AlignByDeviceOrderByLimitOffsetTest.orderByExpressionTest1 -- Time elapsed: 1.411 s <<< FAILURE!
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.apache.iotdb.db.queryengine.plan.planner.distribution.AlignByDeviceOrderByLimitOffsetTest.orderByExpressionTest1(AlignByDeviceOrderByLimitOffsetTest.java:820)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ...

Proposed Solution
Use LinkedHashSet instead of HashSet to keep the ordering deterministic

This PR has:

[ ] been self-reviewed.

[ ] concurrent read
[ ] concurrent write
[ ] concurrent read and write

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods.
[ ] added or updated version, license, or notice information
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
[ ] added integration tests.
[ ] been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Hi @SteveYurongSu, any idea on how I can see more logs of the GitHub Actions that are failing? Just the GitHub Actions logs are not giving clear idea of the failed actions

Hi @SteveYurongSu, any idea on how I can see more logs of the GitHub Actions that are failing? Just the GitHub Actions logs are not giving clear idea of the failed actions


I don't seem to be able to run the code correctly

Hello, I have the following problem when running the code and I need your help very much!

After I clone the code and install the dependencies according to the tutorial (i.e. complete the following steps), I open jupyternotebook and then how to execute the code?

I tried to run  directly in vscode python . /datagen/gen_data.py, but the following error is reported

After encountering the above error, I tried to create an hdf5 file using the command: touch /xxx/test/deep-route/data/layout_data.hdf5, after executing python . /datagen/gen_data.py still reported the same error, and I created the hdf5 file disappeared.

I've tried many things and still can't solve the problem, hope to get your help!

There was an issue with the genData function. An issue related with the directory
The rectified function code is as below:
###########################################
def genData(N=10, H=32, W=32, pin_range=(2, 6)):
"""
Generates decoded training image dataset of size (N, C, H, W)
Inputs:
   - N: number of images to generate
   - H, W: image height, width (in px)
   - pin_range: tuple (low, high) for allowed range of number of pins; "half-open" interval [low, high)
                  (e.g. (2, 6) pins means 2 or 3 or 4 or 5 pins)

Outputs:
   - Saves X: training data (N, 1, H, W)
   - Saves Y: training labels (N, C, H, W)
         where C = 8 (each corresponds to a layout layer, viz.
              [pin, m3, via3, m4, via4, m5, via5, m6])

     X[:, 0, :, :]  pin (m2)

     Y[:, 0, :, :]  pin (m2) - same as X[:, 0, :, :]
     Y[:, 1, :, :]  m3 (vert)
     Y[:, 2, :, :]  via3
     Y[:, 3, :, :]  m4 (horz)
     Y[:, 4, :, :]  via4
     Y[:, 5, :, :]  m5 (vert)
     Y[:, 6, :, :]  via5
     Y[:, 7, :, :]  m6 (horz)
"""

# 8 layout layers for now
C = 8

data_dir = os.getcwd() + "/data/"
# Ensure the directory exists
if not os.path.exists(data_dir):
    os.makedirs(data_dir)

if os.path.exists(data_dir):
    for file in os.listdir(data_dir):
        if file.endswith(".hdf5"):
            os.remove(data_dir+file)
else:
    os.makedirs(data_dir)

data = h5py.File(data_dir + "layout_data.hdf5", 'w')

# numpy arrays no longer needed; use HDF5 instead
#X = np.zeros([N, 1, H, W], dtype = np.int8)
#Y = np.zeros([N, C, H, W], dtype = np.int8)

X = data.create_dataset("X", shape=(N, 1, H, W), dtype='uint8', compression='lzf', chunks=(1, 1, H, W))
Y = data.create_dataset("Y", shape=(N, C, H, W), dtype='uint8', compression='lzf', chunks=(1, 1, H, W))

# Set physical size represented by HxW pixels
microns = 11.0    # To have balanced dataset covering from m3 to m6 (based on resistance plots from resistance_vs_distance.ipynb)
microns_per_xpixel = microns/W
microns_per_ypixel = microns/H

# Layer map
l_map = {
    # Pins
    'pin' : 0,

    # Vias
    'via3' : 2,
    'via4' : 4,
    'via5' : 6,

    # Vertical tracks
    'm3' : 1,
    'm5' : 5,

    # Horizontal tracks
    'm4' : 3,
    'm6' : 7
}

#m3_m4 = m5_m4 = m5_m6 = 0

n = 0
print_every = 5000

while n < N:
    # Randomly select number of pins from given range
    # Uniform distribution over pin range
    nPins = np.random.randint(*pin_range)
    # Non-uniform distribution (skewed exponentially towards smaller number of pins)
    #p_range = np.array(range(*pin_range))
    #p = np.exp(-p_range) / np.sum(np.exp(-p_range))
    #nPins = np.random.choice(p_range, p=p)

    # Randomly pick x and y co-ords for nPins from [0, W) and [0, H) pixels
    x_pins = np.random.randint(W, size=nPins)
    y_pins = np.random.randint(H, size=nPins)

    max_xlen = (max(x_pins) - min(x_pins)) * microns_per_xpixel   # length in um
    max_ylen = (max(y_pins) - min(y_pins)) * microns_per_ypixel   # length in um

    # Corner case when pins overlap each other (invalid case)
    # Bug fix for https://github.com/sjain-stanford/RouteAI/issues/4
    if (max_xlen == 0) and (max_ylen == 0):
        continue

    # Draw pins on layer 'pin (m2)' of both X (data) and Y (labels)
    X[n] = drawPins(X[n], x_pins, y_pins, l_map)
    Y[n] = drawPins(Y[n], x_pins, y_pins, l_map)

    # Add routes to Y (labels)
    x_wire, y_wire = selectWireClass(max_xlen, max_ylen)
    Y[n] = drawRoutes(Y[n], x_pins, y_pins, max_xlen, max_ylen, x_wire, y_wire, l_map)

    n += 1

    if (n % print_every == 0):
        print("Finished generating %d samples." %(n))

    #if x_wire == 'm4' and y_wire == 'm3':
    #    m3_m4 += 1
    #elif x_wire == 'm4' and y_wire == 'm5':
    #    m5_m4 += 1
    #elif x_wire == 'm6' and y_wire == 'm5':
    #    m5_m6 += 1
    #else:
    #    print(x_wire, y_wire)

#print(m3_m4, m5_m4, m5_m6)

# Storing as .npy using np.save -> Issue: RAM out of memory, disk memory limitation
#data_dir = os.getcwd() + '/data/'
#if os.path.exists(data_dir):
#    for file in os.listdir(data_dir):
#        if file.endswith(".npy"):
#            os.remove(data_dir+file)
#else:
#    os.makedirs(data_dir)
#X_save = data_dir + 'X_save.npy'
#Y_save = data_dir + 'Y_save.npy'
#np.save(X_save, X, allow_pickle=False)
#np.save(Y_save, Y, allow_pickle=False)

print("Dataset generated as follows:")
for ds in data:
    print(ds, data[ds])

#############################################


Reducing boost file set

Somewhere (and I can't remember where) I mentioned that the uncompressed size of this file set could be more that halved if we got rid of files that aren't actually used by BioCro.  This isn't so urgent now that we've reduced the size of the BioCro R package by other means, but it is something to consider going forward.
In any case, I thought it worthwhile making a record of the method I used to find and dispense with unused Boost files.  I was working on a Mac using the Z shell, but I'm sure this would work without modification in the Bash shell and on any Linux machine, and probably also on any Windows machine that has Cygwin or MinGW installed.
The first step was to add the -H flag to line at the top of the Makevars (or Makevars.win) file that appends to the PKG_CPPFLAGS variable so that the line became
PKG_CPPFLAGS+=-I../src/inc -DR_NO_REMAP -H

Then, starting in the src directory, I executed the following sequence of commands.  There are probably a few extraneous things left in here, which I'm not bothering to weed out at this point:
# This line could be omitted if you start with a clean working directory or if you use the `--preclean` option in the `R CMD INSTALL` command immediately following.
for file in `grep --exclude-dir boost --exclude-dir .deps "<boost/" --include "*.h" --include "*.cpp" -rl .`; do touch $file; done

cd ..
R CMD INSTALL . 2>&1 | tee install_log
grep -E "^\.+ \.\./src/inc" install_log > boost_includes
sed 's|^.*\.\./src/inc/||' boost_includes | sort -u > boost_unique_includes
cd src/inc
mv ../../boost_unique_includes .
find boost -type f | sort > all_boost_files
for file in `find boost -type f`; do
    if ! grep $file -q boost_unique_includes; then rm $file; fi
done
cd -
R CMD INSTALL --preclean . 2>&1 | tee install_log_2
cd tests
Rscript testthat.R

This would be nice. Boost takes a lot of space, and I assumed that the export tool was bringing only the minimum requirement. The Boost installation instructions seems like the most sensible place for this. https://github.com/biocro/inc/blob/04c4598924930ee2ff7e84df669640cf35180d44/adding_the_boost_libraries.md

This would be nice. Boost takes a lot of space, and I assumed that the export tool was bringing only the minimum requirement. The Boost installation instructions seems like the most sensible place for this. https://github.com/biocro/inc/blob/04c4598924930ee2ff7e84df669640cf35180d44/adding_the_boost_libraries.md

I looked briefly at those instructions, and one line gave me pause:

Note that we do not actually use boost/units, but it is included whenever boost/numeric/odeint.hpp is included, and BioCro will not compile on some operating systems without it.

That made me wonder if there were issues I'm not considering and whether what works on my OS might not work elsewhere.  (That said, the units-related files, or at least some of them, remain, even after I've eliminated the files unused on my system.)
If you all thought it worthwhile, I could make a branch with the files trimmed down for testing, and then maybe a branch of BioCro that uses that branch to do such testing.

We're right at 5 MB and we've already removed things I felt were valuable. Making any additions is going to be very difficult now, so if we can remove things that are actually unnecessary that would be great.

If things do work fine, possibly it worth reporting your findings to the Boost authors. I feel like their tool isn't working properly if unnecessary stuff is exported.

Or maybe we need to double check that we're choosing the right things to export.

If things do work fine, possibly it worth reporting your findings to the Boost authors. I feel like their tool isn't working properly if unnecessary stuff is exported.

My guess is that their tool is designed to export whole Boost libraries as a unit (plus any dependencies of the chosen libraries).  What files from any particular library actually get used by a code base is likely to change during the course of development.  We, on the other hand, have a fairly stable code base (I think), so it is less consequential to throw out the stuff we don't actually use.  And we are packaging the stuff we do use along with our own code, which is probably not the usual use case.

My guess is that their tool is designed to export whole Boost libraries as a unit (plus any dependencies of the chosen libraries)

I wondered if their documentation gave details. It does have a section about how it can give "fat dependencies" if a term matches a library name. It says you can avoid that by giving specific headers, which we do, so I'm not sure that what we're doing is a problem. However, there's a "--scan" argument, that will read files for dependencies. That would be more robust than what we're doing now, which requires updating the docs whenever we change dependencies. The page also implies that it gives a smaller set of dependencies, " If you want a more minimal list, then try using the names of the headers you are actually including, or use the --scan option to scan your source code.", but "more minimal" isn't reassuring wording.
https://www.boost.org/doc/libs/1_78_0/tools/bcp/doc/html/index.html

And we are packaging the stuff we do use along with our own code, which is probably not the usual use case.

This is one of the specific use cases they give, "... and for Boost users who want to distribute a subset of Boost with their application", which is what makes me think if it's not giving a minimal set then something is not as expected.

I don't see newton_raphson_boost.h anywhere, but it's in the docs as including several Boost files. Maybe this is where the extra files are from? @eloch216 is this one of the files that only you were using that you moved out?

However, there's a "--scan" argument, that will read files for dependencies. That would be more robust than what we're doing now, which requires updating the docs whenever we change dependencies.

This is very true.  newton_raphson_boost.h no longer exists.  Conversely, parameters.h uses boost/algorithm/string.hpp, which isn't mentioned in the Developer's Manual documentation.

The page also implies that it gives a smaller set of dependencies, " If you want a more minimal list, then try using the names of the headers you are actually including, or use the --scan option to scan your source code.", but "more minimal" isn't reassuring wording.

Yes, unfortunately.  Although the --scan option is considerably simpler than going through the steps I outline, it also results in a considerably larger set of files.  Still, even if we do want to use the steps I outline, using the --scan option to produce an initial file set is probably a good option.  Moreover, I could probably come up with a script to do most of the work automatically.

I don't see newton_raphson_boost.h anywhere, but it's in the docs as including several Boost files. Maybe this is where the extra files are from? @eloch216 is this one of the files that only you were using that you moved out?

Yes, I think I was the only one (potentially) using it. (I see to remember that the boost Newton-Raphson solver was only able to handle one dimension, and I ended up writing my own, though.) It could probably be removed if it's contributing to a space issue, since I could always add it back in if I need it.


Move setup.sh to end of .env so that you can use envars in setup.sh

I think it’s good - can you check that the append-to-setup works ok still?

Just noticed "Setup completed" is emitted before that, so I'll fix that up.

Ok looks good now, tested with gitport


git-codereview: git change should barf if there is no newline between subject and description

Gerrit makes a complete hash of the CL if there is no blank line between the 1st and subsequent lines on the change description. Maybe git-codereview should detect this and barf accordingly.

When I did this I got a warning about the subject being too long. The next
change has a fixed subject line.
git mail -r rsc<EMAIL_ADDRESS>remote: Resolving deltas: 100% (8/8)
remote: Processing changes: new: 1, done
remote: (W) aa88053: commit subject >65 characters; use shorter first
paragraph
remote: (W) aa88053: too many commit message lines longer than 70
characters; manually wrap lines
remote:
remote: New Changes:
remote:   https://go-review.googlesource.com/2349 Runtime: Increase GC
concurrency. Run GC in its own
background goroutine ...
remote:
On Tue, Jan 6, 2015 at 3:42 PM, Dave Cheney<EMAIL_ADDRESS>wrote:

Gerrit makes a complete hash of the CL if there is no blank line between
the 1st and subsequent lines on the change description. Maybe
git-codereview should detect this and barf accordingly.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/9522.

I think that warning comes from the gerrit end which doesn't like any lines

70 chars.

I think the git-codereview tool could do more before involving gerrit.
On 7 Jan 2015 09:07, "Richard L. Hudson"<EMAIL_ADDRESS>wrote:

When I did this I got a warning about the subject being too long. The next
change has a fixed subject line.
git mail -r rsc<EMAIL_ADDRESS>remote: Resolving deltas: 100% (8/8)
remote: Processing changes: new: 1, done
remote: (W) aa88053: commit subject >65 characters; use shorter first
paragraph
remote: (W) aa88053: too many commit message lines longer than 70
characters; manually wrap lines
remote:
remote: New Changes:
remote: https://go-review.googlesource.com/2349 Runtime: Increase GC
concurrency. Run GC in its own
background goroutine ...
remote:
On Tue, Jan 6, 2015 at 3:42 PM, Dave Cheney<EMAIL_ADDRESS>wrote:

Gerrit makes a complete hash of the CL if there is no blank line between
the 1st and subsequent lines on the change description. Maybe
git-codereview should detect this and barf accordingly.
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/9522.

—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/9522#issuecomment-68943046.

That's just a warning, I think we have lot of commits with longer lines.

Mailed https://go-review.googlesource.com/#/c/4130/


Installing on ubuntu 16.04

Has any one ever got this to install on ubuntu 16.04? The install does not work from source or from pip.

Hi @wmantly,
For now we don't support Ubuntu 16.04, but we have this issue in our road-map.
The pip installation is not supported anymore, only packages via ppa (https://launchpad.net/~presslabs/+archive/ubuntu/gitfs).

I was able to get it to install using this repo by installing python3.4 and changing the version of pygit2 to 24. After running, it gave me permission issue about writing to /var/lib/gitfs/*, after changing the permission of that folder to 777 it runs with out error, but does nothing. Nothing appears in the specified mount dir or in the /var/lib/gitfs/* folder and there are zero error messages.
I was using this command
gitfs<EMAIL_ADDRESS>~/gitfs

Running on ubuntu 14.04 worked somewhat better. I had the same issue with /var/lib/gitfs/* but the files would mount but my changes would were not pushed to github.
I look forward to support for ubuntu 16.04!

Sadly, we dropped support for ubuntu 16.04, but you can install it via pip, you'll just need libgit2 == 0.28.X, since pygit2 requires it.
Sadly, there are no offical builds for it, so you'll need to build it yourself.
Besides that, it should be all good.
Sorry for the delay.


Update Keptn extension to V0.8.2

Updating the Keptn marketplace extension to the newest version (v0.8.2) as discussed with @jetzlstorfer.

[X] Notified the Maintainer of the application in this pull request so that they are aware of your proposal.
[X] Outlined the changes you are proposing, and the reasons these are required (e.g. stability, compatibility with new versions of Kubernetes implementations, etc).
[ ] Tested that the application works with the proposed updates applied (including a screenshot)

Just tried with the new instructions but installation fails.
Events:
  Type     Reason              Age                  From                     Message
  ----     ------              ----                 ----                     -------
  Warning  FailedScheduling    3m23s                default-scheduler        0/1 nodes are available: 1 pod has unbound immediate PersistentVolumeClaims.
  Warning  FailedScheduling    3m23s                default-scheduler        0/1 nodes are available: 1 pod has unbound immediate PersistentVolumeClaims.
  Normal   Scheduled           2m38s                default-scheduler        Successfully assigned keptn/configuration-service-54c4d66bbb-ppjgv to k3s-civo-marketplace-638b6938-node-pool-a4a9
  Warning  FailedAttachVolume  79s (x2 over 112s)   attachdetach-controller  AttachVolume.Attach failed for volume "pvc-3d8c3b7d-a521-40d1-9312-8a394cd95fea" : rpc error: code = Unknown desc = UnknownError
  Warning  FailedMount         36s                  kubelet                  Unable to attach or mount volumes: unmounted volumes=[configuration-volume], unattached volumes=[configuration-volume keptn-configuration-service-token-wpxhs]: timed out waiting for the condition
  Warning  FailedAttachVolume  15s (x7 over 2m24s)  attachdetach-controller  AttachVolume.Attach failed for volume "pvc-3d8c3b7d-a521-40d1-9312-8a394cd95fea" : rpc error: code = DeadlineExceeded desc = context deadline exceeded

@saiyam1814 are PVCs supported by Civo? Seems we are having issues with it if I read the error message correctly.

Just tried with the new instructions but installation fails.
Events:
  Type     Reason              Age                  From                     Message
  ----     ------              ----                 ----                     -------
  Warning  FailedScheduling    3m23s                default-scheduler        0/1 nodes are available: 1 pod has unbound immediate PersistentVolumeClaims.
  Warning  FailedScheduling    3m23s                default-scheduler        0/1 nodes are available: 1 pod has unbound immediate PersistentVolumeClaims.
  Normal   Scheduled           2m38s                default-scheduler        Successfully assigned keptn/configuration-service-54c4d66bbb-ppjgv to k3s-civo-marketplace-638b6938-node-pool-a4a9
  Warning  FailedAttachVolume  79s (x2 over 112s)   attachdetach-controller  AttachVolume.Attach failed for volume "pvc-3d8c3b7d-a521-40d1-9312-8a394cd95fea" : rpc error: code = Unknown desc = UnknownError
  Warning  FailedMount         36s                  kubelet                  Unable to attach or mount volumes: unmounted volumes=[configuration-volume], unattached volumes=[configuration-volume keptn-configuration-service-token-wpxhs]: timed out waiting for the condition
  Warning  FailedAttachVolume  15s (x7 over 2m24s)  attachdetach-controller  AttachVolume.Attach failed for volume "pvc-3d8c3b7d-a521-40d1-9312-8a394cd95fea" : rpc error: code = DeadlineExceeded desc = context deadline exceeded

@saiyam1814 are PVCs supported by Civo? Seems we are having issues with it if I read the error message correctly.

civo Volume issue is resolved now, can you test one more time and see if it works ? @jetzlstorfer

IT took 5 minutes to get this running but as soon as it all went running I saw error
Error: timed out waiting for the condition -> can we increase the timeout ?
NAME                                     READY   STATUS    RESTARTS   AGE
svclb-api-gateway-nginx-vcb7q            1/1     Running   0          5m26s
svclb-api-gateway-nginx-xscrg            1/1     Running   0          5m26s
svclb-api-gateway-nginx-6r629            1/1     Running   0          5m26s
api-gateway-nginx-79b6bb7767-lhd7d       1/1     Running   0          5m25s
api-service-dc8f9d9dd-k4wmg              2/2     Running   0          5m24s
secret-service-7ffdf597d7-sf674          1/1     Running   0          5m24s
keptn-nats-cluster-0                     3/3     Running   0          5m24s
bridge-597967d475-pftvr                  1/1     Running   0          5m24s
mongodb-datastore-84c975559-v95pp        2/2     Running   2          5m25s
statistics-service-7bd9968dbd-qbjdk      2/2     Running   2          5m24s
remediation-service-5b9ffb54f9-8cr6g     2/2     Running   2          5m24s
shipyard-controller-6844695949-x2m2s     2/2     Running   2          5m25s
lighthouse-service-857df5646b-66gst      2/2     Running   2          5m25s
approval-service-dcb7979c8-d8chr         2/2     Running   2          5m24s
configuration-service-54c4d66bbb-xt4kr   1/1     Running   0          5m25s
mongodb-6b455c56fb-8tw6m                 1/1     Running   0          5m24s

Thanks @saiyam1814 for the update!
I've increased waiting time to 10m and will update this in the PR.
I tried again and it is now running. Important details Traefik has to be disabled and should not be installed as it takes the free ports that are also needed to expose keptn via the LB.
Running installation:
NAME                                     READY   STATUS    RESTARTS   AGE
svclb-api-gateway-nginx-qtl4c            1/1     Running   0          18m
api-gateway-nginx-f454c64c4-dq9tv        1/1     Running   0          18m
bridge-597967d475-vc428                  1/1     Running   0          18m
secret-service-7ffdf597d7-2rmkt          1/1     Running   0          18m
api-service-dc8f9d9dd-54g7k              2/2     Running   0          18m
keptn-nats-cluster-0                     3/3     Running   0          18m
mongodb-datastore-84c975559-6hpcb        2/2     Running   2          18m
remediation-service-5b9ffb54f9-mbdrd     2/2     Running   2          18m
approval-service-dcb7979c8-6sf74         2/2     Running   2          18m
shipyard-controller-6844695949-f4shv     2/2     Running   2          18m
lighthouse-service-857df5646b-nqvl5      2/2     Running   2          18m
statistics-service-7bd9968dbd-grtx8      2/2     Running   2          18m
configuration-service-54c4d66bbb-4j8m4   1/1     Running   0          18m
mongodb-6b455c56fb-gqjcg                 1/1     Running   0          18m

Yeah There are some apps that do not work with Traefik, it's ok in future we will try to come up with a mechanism to detect an ingress controller running and say warning to uninstall the previous one or something like that. Apart from this is PR complete now ?

I'll leave it to the original author of the PR to update some minor issues.
@TannerGabriel please have a look
Once this is addressed we can move it out of "Draft" and ask for the PR to be merged

@saiyam1814 it is ready for review


Update spam.md

Description of the change: Added "additional resources" section
Reason for the change:
Link to original source:

Closes #

Hello @iamnishantmishra,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Adding vertical/horizontal classes to data-responsive-menu

I really like how I can switch between a drilldown and a dropdown with http://foundation.zurb.com/sites/docs/responsive-navigation.html, but is there a way to make the li elements toggle between horizontal and vertical with this? Or should I stick with visibility classes?
thank you,

This repository is about the Foundation gem, not the actual framework.
You should post your issue here: https://github.com/zurb/foundation-sites

thank you will do.


Exploratory Data Analysis

We need to have Data Source Views that give a nice EDA (Exploratory Data Analysis), with charts and stats.
References:
https://www.analyticsvidhya.com/blog/2021/04/rapid-fire-eda-process-using-python-for-ml-implementation/
https://rpubs.com/davidmh/Abalone_Age

Let's make sure we include

Distinct
NaNs
Still have string unique values


Cannot use $this as parameter

I'm getting the fatal error below when trying to run this repo on php 7.0.18 https://github.com/sitedyno/phergie-sitedyno
PHP Fatal error:  Cannot use $this as parameter in /home/durkon/phergie/vendor/react/http-client/src/Request.php on line 94
PHP Stack trace:
PHP   1. {main}() /home/durkon/phergie/vendor/phergie/phergie-irc-bot-react/bin/phergie:0
PHP   2. Phergie\Irc\Bot\React\Bot->run() /home/durkon/phergie/vendor/phergie/phergie-irc-bot-react/bin/phergie:28
PHP   3. Phergie\Irc\Client\React\Client->run() /home/durkon/phergie/vendor/phergie/phergie-irc-bot-react/src/Bot.php:237
PHP   4. React\EventLoop\StreamSelectLoop->run() /home/durkon/phergie/vendor/phergie/phergie-irc-client-react/src/Client.php:731
PHP   5. React\EventLoop\Tick\FutureTickQueue->tick() /home/durkon/phergie/vendor/react/event-loop/StreamSelectLoop.php:175
PHP   6. call_user_func:{/home/durkon/phergie/vendor/react/event-loop/Tick/FutureTickQueue.php:45}() /home/durkon/phergie/vendor/react/event-loop/Tick/FutureTickQueue.php:45
PHP   7. WyriHaximus\React\Guzzle\HttpClient\Request->WyriHaximus\React\Guzzle\HttpClient\{closure}() /home/durkon/phergie/vendor/react/event-loop/Tick/FutureTickQueue.php:45
PHP   8. WyriHaximus\React\Guzzle\HttpClient\Request->setupRequest() /home/durkon/phergie/vendor/wyrihaximus/react-guzzle-http-client/src/Request.php:181
PHP   9. React\HttpClient\Client->request() /home/durkon/phergie/vendor/wyrihaximus/react-guzzle-http-client/src/Request.php:203
PHP  10. spl_autoload_call() /home/durkon/phergie/vendor/react/http-client/src/Client.php:23
PHP  11. Composer\Autoload\ClassLoader->loadClass() /home/durkon/phergie/vendor/react/http-client/src/Client.php:23
PHP  12. Composer\Autoload\includeFile() /home/durkon/phergie/vendor/composer/ClassLoader.php:301

It should be pretty simple to clone the repo and try it (be sure to use the sitedyno version of the config files). You don't need any API keys, just use !bofh
If that's too much trouble let me know and I will try to arrange something simpler.
I THINK that getting a version bump for wyrihaximus/react-guzzle-ring will fix this issue.
Thanks.

Hey @sitedyno, the issue is actually a lot simpler, while looking through your composer.lock I found that you're locked to react/http-client v0.4.8, there has been a fix in react/http-client v0.4.9 that solves this issue for you. A simple composer update react/http-client should fix it for you.

Works for me. Thanks for taking a look :)

No problem, and thank you for committing your composer.lock, that made things very simple


Bin/Item Duplication Bug

Filling multiple bins in a crafting grid (tested with 2x2 inventory crafting grid) and shift clicking to fill one creates however many bins you have in the stack, with the number of items you were trying to put in 1 bin.
64 bins with 64 diamond ore blocks shift click crafted = 64 bins full of 64 diamond ore blocks (4096 diamond ore blocks)
Shift clicking to unpack these bins additionally duplicates the bins, but I'm not sure how that works.
Mekanism: <IP_ADDRESS>
InventoryTweaks: 1.59-dev-152
(38 additional mods)

Thanks for discovering this, I've decided to temporarily ban them on my server

I don't see how this is an issue, bins can't be stacked except by spawning them in through NEI.

I have no trouble stacking them without being in creative mode

Thanks, Bins can no longer stack.

Actually found a better way of doing this.  Bins can still stack while empty but no longer can stack when they have items inside, and the crafting table interaction only works with individual Bins.

Must have mixed up an outdated version or something, my bad.


obelisk master branch: config/common/route didn't take affect

i want to customize the port from obelisk server by configure the  config/common/route.
but it didn't work from master brach commit (de99fc6178fe64f6ea3176746e9c273c92fb8e45)
the master branch have two version:
ca6edae87909d0d3c31f6c4a89a2f70bcb209924[old]:
_backend_run :: ((R backendRoute -> Snap ()) -> IO ()) -> IO ()

de99fc6178fe64f6ea3176746e9c273c92fb8e45[new]
_backend_run :: ((R backendRoute -> BackendConfigsT Snap ()) -> BackendConfigsT IO ()) -> BackendConfigsT IO ()

and the develop branch switch to the old interface without BackendConfigsT.
so i wonder whether the current master interface is unstable, and is it better to use develop version?
and what's the prefer strategy to process configure for each version?

Yeah, that's an unfortunate bug in master -- it's looking for that config file in the wrong location in a Map of configs due to some other changes which went through and missed that bit.
I have a branch which will fix that (and does a whole bunch of other stuff, including removing BackendConfigsT again, since it was only ever a nuisance when trying to set up your backend and needing to use things that were written in CPS).
I just need to get it all merged, the PR is a bit of a mess atm. https://github.com/obsidiansystems/obelisk/tree/cg-fullroute

@clojurians-org Are you still having this issue?
I wasn't able to reproduce this on current master. I.e., changing the port in config/common/route worked correctly. I'm guessing @cgibbard's fix got merged at some point, probably in #452.


Always receiving a BLE count of zero

Environment :

Windows 10 (also reproduced on Linux)
Arduino IDE 1.8.19
ESP32 espressif arduino boards packages 1.0.6
T-Beam v1.0 dev board (reproduced on many different other boards)

Steps to reproduce :

clone libpax branch master
edit lib/libpax/libpax_api.h to uncomment build-time options LIBPAX_WIFI and LIBPAX_BLE
copy lib/libpax in arduino libraries folder
copy the sample program src/main.cpp as src/main.ino and open it in arduino ide
modify it like this (removing non-arduino version for clarity, and defining LIBPAX_ARDUINO as instructed in README.md) :

#define LIBPAX_ARDUINO
#include <libpax_api.h>
#include <stdio.h>

struct count_payload_t count_from_libpax;

void process_count(void) {
  printf("pax: %d; %d; %d;\n", count_from_libpax.pax, count_from_libpax.wifi_count, count_from_libpax.ble_count);
}

void init() {
  struct libpax_config_t configuration;
  libpax_default_config(&configuration);
  configuration.blecounter = 1;
  configuration.blescantime = 0; // infinit
  configuration.wificounter = 1;
  configuration.wifi_channel_map = WIFI_CHANNEL_ALL;
  configuration.wifi_channel_switch_interval = 50;
  configuration.wifi_rssi_threshold = -80;
  configuration.ble_rssi_threshold = -80;
  libpax_update_config(&configuration);

  // internal processing initialization
  libpax_counter_init(process_count, &count_from_libpax, 10, 1);
  libpax_counter_start();
}

void setup() {
  init();
}

void loop() {}

build and upload, open the serial monitor.

Expected output:
Receiving values for both wifi and ble counts.
Actual output:
16:25:09.268 -> pax: 3; 3; 0;
... 10 minutes later
16:25:19.262 -> pax: 7; 7; 0;
BLE count is always zero.
Note that running the BLE_scan sample sketch included with ESP32 arduino package finds around 15 BLE devices at the same location, same time on the same board.

All tests are also successful with pio test -e espidf.

Tests show BLE sniffing results (see third column) as expected, thus BLE sniffing works.
Looks like in integration / API problem with your app. Did you set the build time options in your app?
#define LIBPAX_WIFI // enables WiFi sniffing features in build
#define LIBPAX_BLE  // enables BLE sniffing features in build

At the moment I am not using any code of my own, I'm testing with only the libpax provided sample "src/main.cpp"
As described in my initial post I have uncommented the build time options directly in the libpax file libpax_api.h so they are always enabled.

In the example there is an RSSI threshold set:
configuration.wifi_rssi_threshold = -80;
configuration.ble_rssi_threshold = -80;

Perhaps your BLE signal do not hit the threshold. Please set to zero and try again.

I installed Arduino IDE 1.8.19, compiled and uploaded on a ESP32 T-Beam Board, an can reproduce this issue:

That's similar to my own results. Thanks for your time testing that.

I finally succeeded in building the main.cpp sample with esp-idf v4.4, and the BLE counting works there.

@zapoig thanks for the note.
We should leave this open, until it's clear why it does not work with Arduino IDE.

I'm also experimenting with libpax and ran into the same issue:
Building with platform.io and this configuration
[env:nodemcu-32s]
platform = espressif32
board = nodemcu-32s
framework = arduino

gives me 0 BLE devices.

I'm also experimenting with libpax and ran into the same issue: Building with platform.io and this configuration
[env:nodemcu-32s]
platform = espressif32
board = nodemcu-32s
framework = arduino

gives me 0 BLE devices.

Did you try to run the tests ?
pio test -e arduino

@lifezoned4 Yes I had tried setting rssi_thresholds (for both wifi and ble) to zero before.
Here is the results I have today :
When unit tests yield counts :
libpax should be running
pax: 18; 1; 17;
pax: 21; 1; 20;
pax: 21; 1; 20;
pax: 21; 1; 20;
pax: 23; 1; 22;
pax: 23; 1; 22;
E (41212) event: Event loop not initialized via esp_event_loop_init, but esp_event_send called
after stop: Current free heap: 208120
libpax should be stopped

The sample, built with arduino IDE, only finds wifis with default RSSIs = -80 :
pax: 1; 1; 0;
pax: 1; 1; 0;
pax: 2; 2; 0;
pax: 2; 2; 0;
pax: 3; 3; 0;
pax: 3; 3; 0;

And - still building using arduino IDE - switching the RSSIs to 0 doesn't change the BLE zero count (although it appears to find more wifis) :
pax: 4; 4; 0;
pax: 7; 7; 0;
pax: 8; 8; 0;
pax: 11; 11; 0;
pax: 14; 14; 0;
pax: 15; 15; 0;

Now if I build the original sample (rssi at -80) with platformio, it is finding both ble and wifi nodes :
pax: 6; 1; 5;
pax: 6; 1; 5;
pax: 6; 1; 5;
pax: 6; 1; 5;
pax: 6; 1; 5;
pax: 8; 1; 7;

And switching the rssi to 0 improves both counts - with platformio build again :
pax: 16; 2; 14;
pax: 17; 2; 15;
pax: 17; 2; 15;
pax: 17; 2; 15;
pax: 20; 2; 18;
pax: 21; 2; 19;

In the end I am happy having switched to platformio for my own project, but if the arduino IDE support is broken it should probably get mentioned in the README.

@zapoig thanks for the report. It's strange, i have no idea what's the root cause here.


Launch is not created 405

I have checked out the code and provided

Report portal deafult cloud configurations to update the report - Failing
Personal portals configurations - Failing

Issue 2 no launch is created
module.exports = defineConfig({   headless: true,   reporter: '@reportportal/agent-js-cypress',   reporterOptions: {       endpoint: 'http://152.554.218.73:8082jj',       token:       launch: 'default_TEST_EXAMPLE',       project: ,       description: 'default_TEST_EXAMPLE',   },   e2e: {     setupNodeEvents(on, config) {       return registerReportPortalPlugin(on, config)     },   }, });
Could someone help I am I missing some thing?

Closed as a duplicate of https://github.com/reportportal/agent-js-cypress/issues/138


win32: Use call in vimtutor.bat

This is originally reported at k-takata/vim-win32-installer#3.

Please add to *.bat file
for example vim80\vimtutor.bat
change
vim -u NONE -c "so $VIMRUNTIME/tutor/tutor.vim"
to
call vim -u NONE -c "so $VIMRUNTIME/tutor/tutor.vim"
because now second string (vim -u NONE -c "set nocp" %TUTORCOPY%) newer run

If Vim is installed with "Create .bat files for command line use", the
"vim" command executes "vim.bat" and it causes the reported problem.
Using "call" fixes it.

Codecov Report

Merging #2105 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
- Coverage   73.97%   73.97%   -0.01%
==========================================
  Files          90       90
  Lines      131716   131717       +1
  Branches    28941    28941
==========================================
- Hits        97436    97434       -2
+ Misses      34276    34264      -12
- Partials        4       19      +15

Impacted Files
Coverage Δ

src/libvterm/src/screen.c
71.94% <0%> (-0.4%)
:arrow_down:

src/ex_cmds.c
77.71% <0%> (-0.09%)
:arrow_down:

src/channel.c
82.54% <0%> (-0.05%)
:arrow_down:

src/gui_gtk_x11.c
47.71% <0%> (+0.05%)
:arrow_up:

src/if_py_both.h
76.23% <0%> (+0.14%)
:arrow_up:

src/os_unix.c
53.36% <0%> (+0.18%)
:arrow_up:

src/gui.c
46.95% <0%> (+0.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4033c55...e1c2466. Read the comment docs.


README's link to documentation is dead

Title. I clicked "documentation", I got 404'd.

Hi,
Sorry about that, will remove with the next update, here is the link to existing docs https://github.com/PaulleDemon/tkTimePicker/blob/master/Documentation.md


Filterfile #16

Description
This pull request includes a fix for the file filtering functionality within the FileFilter class. The tests for valid and invalid file extensions, as well as files with multiple extensions, have been added and successfully passed. This update enhances the file filtering process by ensuring that it properly handles various file extensions and conditions.

Fixes #(16)

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] I have maintained a clean commit history by using the necessary Git commands
[x] I have checked that my code does not cause any merge conflicts

Screenshots (if applicable)

@smartfellow1234
Great work
But i think , when you got three issues aassigned , each issue should have been fixed in a separate branch
So please make separate branch for separate issues and the make PR for each of them
other than this everything LGTM!

@smartfellow1234
can you just reference the three PR's which you made for three different issues?

@smartfellow1234
I have left reviews
make changes as neccessary


📚 Add documentation on Converting a Fork

Related to:

https://github.com/scientist-softserv/adventist-dl/issues/552

Is this eventually going into Hyku?

These are eventually going into Hyku Knapsack.


Not working on type number

Not working on type number

i'm reanalyze, this not working on type number


Added Swagger file

This shows the expected API for both @rakunkel-ucd site-farm API, as well as @UcDust relationship put command.

You'll also want to add swagger : 'expert.yaml' in the index.js file of this model.

You'll also want to add swagger : 'expert.yaml' in the index.js file of this model.

@UcDust, yes I had that in before, but then I wondered is this basically a filename, that gets read later?
I will do that.

I imported this into the visibility fixes, since that's the function that was in there.