Clean up some NA stuff an update the news.

Codecov Report

Merging #243 (3095083) into main (d262ed0) will increase coverage by 0.02%.
The diff coverage is 96.29%.

:exclamation: Current head 3095083 differs from pull request most recent head dab6941. Consider uploading reports for the commit dab6941 to get more accurate results

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   94.46%   94.48%   +0.02%
==========================================
  Files          21       21
  Lines        2404     2413       +9
==========================================
+ Hits         2271     2280       +9
  Misses        133      133

Impacted Files
Coverage Δ

R/get_geometry.R
100.00% <ø> (ø)

R/get_path_lengths.R
91.46% <ø> (ø)

R/prep_nhdplus.R
94.39% <95.23%> (+0.51%)
:arrow_up:

R/calc_network.R
100.00% <100.00%> (ø)

R/get_codes.R
99.08% <100.00%> (ø)

R/get_paths.R
95.73% <100.00%> (ø)

R/index_nhdplus.R
97.56% <100.00%> (ø)

R/run_plus_attributes.R
98.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d262ed0...dab6941. Read the comment docs.


Adds make j.dirs consistent  local prefab dir_paths

related to https://github.com/Jumpscale/prefab9/issues/11
Signed-off-by: Ashraf Fouda<EMAIL_ADDRESS>What this PR resolves:
https://github.com/Jumpscale/prefab9/issues/11
Changes proposed in this PR:

j.dirs gets its values from jumpscal9.toml and prefab dirpaths gets its dirs from env. So I add the dirs we get from jumpscale9.toml to the env

Version:
Fixes: #

I'd like to give it more thinking (prefab [local/remote] can has it's own standardized dir structure away from jumpscale)


Avoid duplicate Cc: lines

It was reported in https://github.com/gitgitgadget/gitgitgadget/issues/16 that GitGitGadget produces mails with duplicate Cc: lines, which could be interpreted by anti-malware software to indicate non-benign emails.
So let's fix this.
/cc @ sunshineco

I don't understand the implementation, but I understand the tests that achieve what we want.


Make committee page nicer

Not as important because it is behind the scenes (fewer users see it) but good for Senators to have a good experience with the app as well.

Can complete this post launch ASAP. But we want to launch as early as possible so this can come after.


Updates review reportback logic to support multiple files

Rewrote a good chunk of the setFlaggedPromoted function, as a result this PR should fix the following issues, #4908 #4880
Currently testing it, progress is being logged in a Google Sheet here: https://docs.google.com/a/dosomething.org/spreadsheets/d/1YA5QSNf5Jhs9myY-CUcY3Ca3arkDWgr4MUR7AiphniQ/edit?usp=sharing
Logic is much more clear and documented now, accounts for each reportback item before determining what the values should be. Clearly labels & separates the business logic. After this is merged I can another round of thorough testing with @namimody
@angaither

@angaither ready for another look

other than that :+1:


Use DynamoSingleVersionStore from scala-storage

Current error in CI:
BagReplicatorFeatureTest:
[info] - replicates a bag successfully and updates both topics *** FAILED ***
[info]   The code passed to eventually never returned normally. Attempted 85 times over 15.132448625999999 seconds. Last failure message: List("Replicating started", "Replicating succeeded", "Replicating retrying") did not contain the same elements as List("Replicating started", "Replicating succeeded"). (BagReplicatorFeatureTest.scala:48)


failure while creating Trainer

Hi,
I am trying to port my Python program for time series forecasting (where it works). It is a regression style setup with both input and output being vectors. There are many time series, with varying lengths, but every point on a series is preprocessed to an input vector (of INPUT_SIZE), and at each point we also have the vector forecast (of OUTPUT_SIZE).
I am using stacked LSTMs, but to simplify matters, only single one here, created with this function:
createLSTMnet<-function(input_var , hidden_layer_dim1, output_dim) {
r=Recurrence(LSTM(hidden_layer_dim1,
use_peepholes=LSTM_USE_PEEPHOLES,
enable_self_stabilization=LSTM_USE_STABILIZATION, name="firstCell"))(input_var)
r=Dense(output_dim, bias=TRUE, name="lastLayer")(r)
}
I also use custom loss function:
sMAPELoss<-function (z, t){
t1=op_element_select(op_less(t,-0.9), z, t, name="t1")
a=op_abs(op_minus(t1,z))
b=op_plus(op_abs(t1),op_abs(z))
op_reduce_sum(op_element_divide(a,b))
}
The most important few more lines of code:
input_var <- seq_input_variable(INPUT_SIZE, name = "input")
output_var <- seq_input_variable(OUTPUT_SIZE, name = "label")
z = createLSTMnet(input_var, LSTM_STATE_SIZE, OUTPUT_SIZE)
loss = sMAPELoss(z,output_var)
eval_error = loss
learner = learner_momentum_sgd(z$parameters, lr_schedule, mm_schedule,
		l2_regularization_weight = 0.0005, gaussian_noise_injection_std_dev = 0.0005)
trainer <- Trainer(z, c(loss, eval_error), learner)

And the last line fails with:
Error in py_call_impl(callable, dots$args, dots$keywords) :
TypeError: argument label's type Sequence[Tensor[2]] is incompatible with the type Sequence[np.float32] of the passed Variable
Could some kind soul help me please?
BTW, there is only the SGD learner available, right? No Adam, Adagrad, etc.
Any plans for brining the R functionality closer to the Python's one?
Regards,
Slawek

Not sure this is your issue, but first thing I noticed is that there's actually a special reduce sum operation for sequences, seq_reduce_sum, which is reflected from the Python API. Try switching that in your loss function.
As for your question on the learners, the R API should be able do anything Python can. For whatever reason this didn't show up in the documentation (could you look into that, @akzaidi?), but all the same learners like the ones you mentioned are available. Until we get those showing up in the docs you can reference learners.R.

Hi,
Thank you for your prompt answer.
I changed the sMAPE function to use seq_reduce_sum but unfortunately I am gettin the same error:
Error in py_call_impl(callable, dots$args, dots$keywords) :
TypeError: argument label's type Sequence[Tensor[2]] is incompatible with the type Tensor[2] of the passed Variable
Detailed traceback:
File "C:\local\ANACON~1.1-W\envs\CNTK-P~3\lib\site-packages\cntk\ops\functions.py", line 406, in call
Function._replace_args_type_check(arg_map)
File "C:\local\ANACON~1.1-W\envs\CNTK-P~3\lib\site-packages\cntk\ops\functions.py", line 320, in _replace_args_type_check
raise TypeError(param_name() + "'s type " + str(param_type) + " is incompatible with the type " + str(arg_type) + " of the passed Variable")

Could you post the corresponding Python you're porting from? That may helpful to spot what's going wrong since these R operations are just ported to the Python interface.

Sure. I attach a simple Python program that I am trying to reproduce in R.
nnbf100demo.zip

I wanted to add one thing: each element of trainInputs_l is an array of size (<length_of_a_particular_time_series>, INPUT_SIZE) and each element of trainOutputs_l is an array (<length_of_a_this_particular_time_series>, OUTPUT_SIZE). This first dimension changes with every series.
So the minibatch is MB_SIZE (10) of sequences of vectors.


Same property ID tracked twice

Hi there
In one of our projects I replaced the traditional google-analytics tracking-snippet with the rack-racker gem:
Like in the ReadMe, I added this:
config.middleware.use(Rack::Tracker) do
    handler :google_analytics, tracker: ENV['GOOGLE_ANALYTICS_ID'], anonymize_ip: true, advertising: true
end

to my production.rb
To get it working with Turbolinks, I also had to add the position: :body option.
Now, when I check the page with the Google Tag Assistant Add-On for Chrome, it complains about the property being tracked twice:

(The more pages you visit, the more duplicated properties are shown in the addon)
Is it really an issue or something, which can be ignored?
Thanks in advance

Thanks for reporting the issue and sorry for the late reply.
rack tracker actually supports turbolinks so that should not be an issue and the page view should only be tracked once.
I can not reproduce this issue right now. Can you please check again if you still have this issue and if so open this issue again?
thanks.


Possible race condition

When we count open files for write, we had a case were all the time, on file was still count as writing, even if it was already closed.

Possible duplicate of #223.


size prop from FormGroup not passed down via app.config?

Description
Hello together,
when setting formGroup.default.size in app.config.ts to true, it seems that this prop is not passed down to the elements.
Here is a small repo: https://stackblitz.com/edit/nuxt-ui-q8qq7g
Is this behavior expected? (Same with buttonGroup.default.size)
Thanks in advance!

Hello! We were using the default value for the input / button instead of relying on the group's default value. I submitted a PR to fix it :)
Thanks!

Merci Romain! 👍

@eduardo-faith we had to revert the changes to the FormGroup component since it clashes with the input size configuration: https://github.com/nuxt/ui/pull/2011. After these change are released, the size prop for the FormGroup component will only impact the label and other FormGroup fields and you'll need to configure the size for all inputs explicitly.


How many match entries odota stores?

Tried to get a thousand or so for my little project, but seems that I can get only 100 with  https://api.opendota.com/api/publicMatches
and when I add
?less_than_match_id=[oldestIDIGot]
it returns nothing
and if I request with ?less_than_match_id=[mostRecentIDIGot]
it returns less than 100 results.
How do I get more than this? If it's not a problem, please store more entries.

Are you sure you passed the oldest ID (smallest number?).  Can you provide a sample link?

https://api.opendota.com/api/publicMatches returns a list where
responce[0]['match_id'] =<PHONE_NUMBER>
responce[99]['match_id'] =<PHONE_NUMBER>
https://api.opendota.com/api/publicMatches?less_than_match_id=3283084804
returns this '[]'
I've already kind of solved my issue, I request latest 100 matches every 100 seconds and it gives me different matches all the time. In case of matchId repeating I check if I've already saved that match.
This method is relatively slow, but I've already managed to download 10 000 matches.

I added an order by that should fix the issue (matches should be sorted in descending match ID order).

See https://github.com/odota/core/issues/1490 for continuation


store job info in Sample

could store some additional info about the job in the Sample, e.g.

runner email/name
hostname where runner was running
timestamp when job was claimed
timestamp when result was uploaded

might be useful for debugging failed jobs

Or maybe better would be to have a separate table in the database with the jobs, rather than tying this to the sample - especially for jobs that time out and get restarted.
Ideally the logs from the runner would also be stored and available to download.

certainly would be useful to know how long the jobs were taking, then we'd know roughly what our likely compute costs are and how to optimise them in future


Quick way to compute number of mismatches

I am using the StripedSmithWaterman class for DNA alignment and would like to derive the number of mismatched bases. What is the most straight forward way to accomplish this?

I would use the aligned_query_sequence and aligned_target_sequence properties on the result with skbio.sequence.distance.hamming.


Catch errors

Currently we get lots of (404) errors in console for missing files on github; we should catch these so the console is not cluttered for developers

I don't think this is a problem. How many developers are going to have this issue?

Yeah, it's just ugly.  Agree it's low priority.

I'm not even sure this is possible. https://stackoverflow.com/questions/7035466/check-if-file-exists-but-prevent-404-error-in-console-from-showing-up

Fair enough, closing.


GPT2 tests mysteriously killed

Description
GPT2 tests in tests/test_models.py is mysteriously killed. The was found in the recent nightly tests(cu102-2.0.0b20210502 and cu102-2.0.0b20210504).
But, after I tried other MXNet nightly build prior to cu102-2.0.0b20210502, the error was still there. So, I suspect that some changes in other upstream packages resulted in this issues. Need more investigation.
Error Message
root@ce877b5a6d9d:/workspace/gluon-nlp# python3 -m pytest --durations=50 --device='cpu' --verbose --runslow tests/test_models.py
Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=1945812666 to reproduce.
==================================================================== test session starts =====================================================================
platform linux -- Python 3.6.9, pytest-6.2.3, py-1.10.0, pluggy-0.13.1 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /workspace/gluon-nlp, configfile: pytest.ini
plugins: cov-2.11.1, mock-3.6.0, flaky-3.7.0, env-0.6.2
collected 55 items

tests/test_models.py::test_list_backbone_names PASSED                                                                                [  1%]
tests/test_models.py::test_get_backbone[ctx0-google_albert_base_v2] PASSED                                                                             [  3%]
tests/test_models.py::test_get_backbone[ctx0-google_albert_large_v2] PASSED                                                                            [  5%]
tests/test_models.py::test_get_backbone[ctx0-google_albert_xlarge_v2] PASSED                                                                           [  7%]
tests/test_models.py::test_get_backbone[ctx0-google_albert_xxlarge_v2] PASSED                                                                          [  9%]
tests/test_models.py::test_get_backbone[ctx0-gluon_en_cased_bert_base_v1] PASSED                                                                       [ 10%]
tests/test_models.py::test_get_backbone[ctx0-google_en_cased_bert_base] PASSED                                                                         [ 12%]
tests/test_models.py::test_get_backbone[ctx0-google_en_cased_bert_large] PASSED                                                                        [ 14%]
tests/test_models.py::test_get_backbone[ctx0-google_en_cased_bert_wwm_large] PASSED                                                                    [ 16%]
tests/test_models.py::test_get_backbone[ctx0-google_en_uncased_bert_base] PASSED                                                                       [ 18%]
tests/test_models.py::test_get_backbone[ctx0-google_en_uncased_bert_large] PASSED                                                                      [ 20%]
tests/test_models.py::test_get_backbone[ctx0-google_en_uncased_bert_wwm_large] PASSED                                                                  [ 21%]
tests/test_models.py::test_get_backbone[ctx0-google_multi_cased_bert_base] PASSED                                                                      [ 23%]
tests/test_models.py::test_get_backbone[ctx0-google_zh_bert_base] PASSED                                                                               [ 25%]
tests/test_models.py::test_get_backbone[ctx0-gluon_electra_small_owt] PASSED                                                                           [ 27%]
tests/test_models.py::test_get_backbone[ctx0-google_electra_base] PASSED                                                                               [ 29%]
tests/test_models.py::test_get_backbone[ctx0-google_electra_large] PASSED                                                                              [ 30%]
tests/test_models.py::test_get_backbone[ctx0-google_electra_small] PASSED                                                                              [ 32%]
tests/test_models.py::test_get_backbone[ctx0-gpt2_124M] SKIPPED (Skipping GPT-2 test)                                                                  [ 34%]
tests/test_models.py::test_get_backbone[ctx0-gpt2_1558M] SKIPPED (Skipping GPT-2 test)                                                                 [ 36%]
tests/test_models.py::test_get_backbone[ctx0-gpt2_355M] Killed

To Reproduce
(If you developed your own code, please provide a short script that reproduces the error. For existing examples, please provide link.)
Steps to reproduce
(Paste the commands you ran that produced the error.)

What have you tried to solve it?

Environment
We recommend using our script for collecting the diagnositc information. Run the following command and paste the outputs below:
curl --retry 10 -s https://raw.githubusercontent.com/dmlc/gluon-nlp/master/tools/diagnose.py | python

# paste outputs here

Would you try the alpha version?

Would you try the alpha version?

Looks like alpha version works well. The issue may be still in upstream(mxnet) changes, I will try to fix it.

This might be difficult to fix. You may try to see if running GPT-2 alone will still cause the error.


Can't respond to bot call

I trying to respond to a call in Teams but actually I'm not getting a respond from the bot.
First I get access_token from Graph API.
Then I have a route that intercept bot calls.
(app.post("/api/call", function(req, res) {
  if (j === 1) {
    j = j + 1;
    res.status(204).send();
  } else {
    var answerbody = {
      callbackUri: "https://8a73b7ad.ngrok.io/api/call",
      acceptedModalities: ["audio"],
      mediaConfig: {
<EMAIL_ADDRESS>"#microsoft.graph.serviceHostedMediaConfig",
        preFetchMedia: [
          {
            uri: "https://cdn.contoso.com/beep.wav",
            resourceId: "1D6DE2D4-CD51-4309-8DAA-70768651088E"
          },
          {
            uri: "https://cdn.contoso.com/cool.wav",
            resourceId: "1D6DE2D4-CD51-4309-8DAA-70768651088F"
          }
        ]
      }
    };
    POST(
      "https://graph.microsoft.com/beta/" + req.body.resource + "/answer",
      answerbody
    )
      .then(
        data => console.log(data) // I get undefined
      )
      .catch(function(err) {
        console.log("err   " + err);
        res.status(200).send();
      });
  }
});)

Here's POST function
function POST(url, BB) {
  return new Promise(function(resolve, reject) {
    var options = {
      url: url,
      method: "POST",
      headers: {
        Accept: "application/json",
        Authorization: "Bearer " + token
      },
      body: BB,
      json: true
    };
    request(options)
      .then(function(body) {
        resolve(body);
      })
      .catch(function(err) {
        reject(err);
      });
  });
}

As mentionned in documentation , Server sould first reply 204 in order to get response in Graph API protocol.
Actually I don't get a response. Bot still ringing until It gets voice message : " You can't talk to the bot just yet , we are working on it".
As mentioned in Teams API documentation, I should get callback with the ressource id and other information to be able to answer to the call.
So I use my POST function to answer. but here I don't get any 202 Accepted response as indicated in docs, instead I get more than one callback with different ressource ids, then after some seconds I get the voice message.

@Githamza, we are removing the requirement of the initial 204 No Content response for Graph API. Your bot already uses that. Please remove the corresponding logic and retry.
The documentation will shortly be updated to reflect this. For future issues of the graph API, please take a look here.


Any test results for cornell and jacquard dataset?

Since I saw this repo supports Cornell and Jacquard dataset, I wonder if there already exists test performance on cornell and jacquard dataset somewhere.

Hello,
We discuss the results on the datasets in this paper https://journals.sagepub.com/doi/full/10.1177/0278364919859066, however one of the main findings is that performance on the datasets doesn't necessarily equate to performance on a real robot.


add .table-borderless style.

There's no styled tables without border. Yes You can disable borders with CSS, but, it would be nice to have it out of the box.
What do You think?

It's a nice feature to have out of the box.
Would those 4 lines make that much of a difference?

I believe the philosophy behind Bootstrap isn't to be a one-stop-shop for everyone.

You can as well get rid of the .table-bordered then with that logic.


[HUDI-5519] Fix LogFileComparator with suffix for CDC

Change Logs
LogFileComparator does not compare cdc suffix, for example, for the following logs, they will be considered equal:
.file1_2.log.1_1-1-1
.file1_2.log.1_1-1-1.cdc

One problem it will bring is: because new TreeSet<>(HoodieLogFile.getReverseLogFileComparator()) is used when constructing FG, when the two logs are exactly the same except for suffix, only one of them will exist in logFiles.
Impact
Fix LogFileComparator
Risk level (write none, low medium or high below)
low
Documentation Update
None
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Looks good.


ThirdParty.json

Adds ThirdParty.json as a convince for tracking third party dependencies. It's generated as part of the build step based on info we manually enter in ThirdParty.extra.json and then by pulling data from each module's package.json where available. ThirdParty.extra.json contains a list of packages which are shipped with the cesiumJS release, which more or less matches the Third-Party Code section of LICENSE.md.

Notably, I chose not to include libraries included in LICENSE.md which the implementations were only referenced in comments. Let me know if leaving those out was an incorrect assumption.
Where a library is not sourced from an npm module, I chose the license and version available at the time when the library was last updated in our codebase.
I updated LICENSE.md, removing out-of-date entries and adding one which I believe was missed.

Thanks for the pull request @ggetz!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

Thanks @shehzan10. Updated the documentation to include steps for updating package.extra.json.
@sanjeetsuhag Could you do a final review and merge when ready?

Additionally, is it intentional that we are not shipping this file with the release ZIP?

@shehzan10 Is ThirdParty.json something we want to ship? I doesn't seem like something that would be useful to users beyond LICENSE.md

I just ran npm i; npm run build; on two different machines. For the @zip.js/zip.js dependency, a different version was installed, causing a change in the ThirdParty.json. This is unfortunate because simply running npm run build is now causing a change in the repo that needs to be handled.

The point is for the script to increment versions numbers to match the shipped version. Since this seems to generate too much noise, I'll break this into its own node script.

@shehzan10 Is ThirdParty.json something we want to ship? I doesn't seem like something that would be useful to users beyond LICENSE.md

@ggetz Right, since we're shipping License.md, no need to ship ThirdParty.json too.

Thanks @shehzan10.
@sanjeetsuhag This is updated.


Minor performance optimization to Gradle build in Dockerfile

This should make the Dockerfile build just a tiny bit faster.

I am not very sure about this one, maybe @ptuomola you can review this?

@vidakovic perhaps you would like to review & merge this one?


Fix for  php 5.6 on Centos 7.1.1503 #131

have added the yum repo so this works ok on centos7 - not sure if i should leave the original reference in so have left it.

I am unable to see what failed 8(  Will fix it if i can see it. the module works fine for me locally tho so i assume maybe a test needs to be changed somewhere?

Thanks!


chore: bump 2.7.0-rc.3 to 2.7.0

Update all starknet dependencies and scarb versions to 2.7.0
https://github.com/starkware-libs/cairo/releases/tag/v2.7.0
as soon as scarb releases 2.7
https://github.com/software-mansion/scarb/releases
-> simply find and replace all

Hi can I be assigned to this?


PolySharp.SourceGenerators.PolyfillGenerator is not generating files

In our solution of about 200 projects, all targeting .NET 4.7.2 and using SDK Style format, one project does not have any polyfills generated, see the screenshot. I have no idea why it's not working for this one specific project.

It should generate polyfills in all projects.
Is there a way how can I debug this package or polyfill? Is there any logging that I can read or exception that is thrown?
System info
Polysharp 1.13.2, VS 2022 17.6.2, project targeting .NET 4.7.2 in SDK style.
(Have you tested Polysharp in .NET 4.7.2 SDK style projects?)
Additional context (optional)
Note in each of our projects I can see this error/warning in the Analyzers section: POLYSP0003 Unsupported C# version, even though it works in all but one project. Possibly false positive?

Forgot to mention we have defined LangVersion 11.0 in our Directory.Build.props file.

I have repro!
Repro.zip
Tl;dr if a dependency project has PolySharp installed and uses InternalsVisibleTo("App"), then polyfills are not generated in App even when PolySharp is also included, but in this case C#11 features work becuase internals from dependency project are used.
The problem is if there are two dependencies with PolySharp and both with InternalsVisibleTo("App"). In this case it's not possible to use records/init properties and other features in App because there are two attributes available in the same namespace - ambiguation for the compiler.
How to solve it? Ideally generate polyfills even if there are polyfills available through InternalsVisibleTo from other asembly.
Also if possible fix the issue with POLYSP0003 warning.

Looks like a duplicate of https://github.com/Sergio0694/PolySharp/issues/50


Adds missing check for runtime ctl:ruleRemoveByTag (Issue #2099)

This PR fixed the remained bug from issue #2099:
Added some test cases to prevent the similar problems.

General comments:

Try to give significative names to pull requests, so it can be searchable by other users.

A good title could be: Adds missing check for runtime SecRuleRemoveByTag (Issue #2099)

Whenever you make a reference to an issue, use the hash marking otherwise Github won't notice the reference.

Instead of 2099 use #2099

General comments:
* Try to give significative names to pull requests, so it can be searchable by other users.

A good title could be: Adds missing check for runtime SecRuleRemoveByTag (Issue #2099)

* Whenever you make a reference to an issue, use the hash marking otherwise Github won't notice the reference.

Instead of 2099 use #2099

Sorry, and thanks for the tips - I'll try to keep it mind :)

Hi @airween,
I have started a review in the code.
Question: Why you have sent this patch against that branch? As already explained to you we are working on 3.1. It seems like your patch is compatible only with the master branch.

Where should I sent the patch?
I just read about the 3.1 from blogposts... not remember that we've discussed about the flow of sending of patches for "old" version :)
Edit: and one more note: the original issue affects 3.0 - I think it's better to apply to this first.

Sure @airween. I think that reiterates the need to talk over GitHub issues instead of Hangouts/Skype and Slack. So that we don't lose track of what is going on with the project. With that, we are keeping the info not only ourselves but for others who may want to be up to date and participating in the discussions.
No worries I will modify your patch to fit 3.1.

Hi @airween,
I have started a review in the code.
Question: Why you have sent this patch against that branch? As already explained to you we are working on 3.1. It seems like your patch is compatible only with the master branch.

Where should I sent the patch?
I just read about the 3.1 from blogposts... not remember that we've discussed about the flow of sending of patches for "old" version :)
Edit: and one more note: the original issue affects 3.0 - I think it's better to apply to this first.

Sure @airween. I think that reiterates the need to talk over GitHub issues instead of Hangouts/Skype and Slack. So that we don't lose track of what is going on with the project. With that, we are keeping the info not only ourselves but for others who may want to be up to date and participating in the discussions.
No worries I will modify your patch to fit 3.1.

Hi @zimmerle - thanks for details.
I've double checked on Slack (a long time ago we didn't used Skype and Hangouts :)), and mailing list. On the list, I've found a mention for 3.1 in a mail, nothing more.
Of course, it's important to keep the control over the project.
I've never checked out the 3.1 - sounds interesting. Would you like me to see that too?

Hi @airween,
Thank you for your patch. I have made some modifications in your patch in order to:
(a) merging all the commits that you were offering fixies within the very same branch;
(b) baptise the commits with more meaningful description;
(c) Adding the test case to the test case list.
The result is here:

2c136a2d9cda6bac4123fee22905a16fbe55b622
7a93bea8f753f45bb3c5246b464977998ea5b462
db298696fa9f6f8eb7a14c31ff914474b6e2f6c8
b5823d4e0c53375d56f7e5089d6c6bec948ac339

Since you are a long-term contributor, it is important to highlight (c).  If the test case is not on the make file list, it is not executed by the buildbots. Therefore not automagically tested. List is still manual, little trickier to get it done right.
Here is the list:
https://github.com/SpiderLabs/ModSecurity/blob/b5823d4e0c53375d56f7e5089d6c6bec948ac339/Makefile.am#L152
This patch is now merged!

Hi @zimmerle, thanks for the tips - I'll try to keep them in mind :).
Note, that I've added many test cases (may be for all relevant modifications), but never met whit this issue. Thanks for the notification. :)


Simd sum null

Same spirit as #42 . This requires SIMD masks, which we use uX to do.
Before:
add nulls f32           time:   [324.46 us 325.94 us 327.32 us]

after:
add nulls f32           time:   [49.267 us 49.499 us 49.718 us]

Arrow SIMD:
sum nulls 512           time:   [10.863 us 10.914 us 10.966 us]

Arrow has an out of bound read on chunks, so this comparison is not 100% fair. Still, I was unable to reach the same perf. as the current Arrow implementation by a factor of 5x (yet).

Impressive! I found the crate with the same idea of using auto vectorization mentioned in the other PR:
https://docs.rs/slipstream/0.2.0/slipstream/
Maybe there is also some cool inspiration to find there.

Impressive! I found the crate with the same idea of using auto vectorization mentioned in the other PR:
https://docs.rs/slipstream/0.2.0/slipstream/
Maybe there is also some cool inspiration to find there.

Really good finding, @Dandandan ; I agree. I will ping the owner :)


chore(IdsMultipartSender): use default object mapper for data reference serialization

What this PR changes/adds
Resets the used ObjectMapper for serializing the MultipartEndpointDataReferenceRequestSender payload to the default one, since EndpointDataReference is not an IDS object and EndpointDataReferenceHandler uses the same for reading this value.
Details the edc exception message in IdsMultipartSender::checkResponseType.
Why it does that
The IDS object mapper should only be used for de/serializing ids objects, not edc objects.
Further notes
--
Linked Issue(s)
Relates #1781
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[x] assigned appropriate label? (exclude from changelog with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Why couldn't be the EndpointDataReferenceHandler use the same mapper (the ids specific) as the sender? I know that's not an ids specific message, but using the same mapper thorugh all the senders/handlers would make a lot of sense

My first thought was that only IDS objects should be serialized to JSON-LD because that is currently the "protocol specification". If you want to use (and deserialize) the payload of the IDS message elsewhere (other extension), it would not be clean to have to use an IDS ObjectMapper there. Same goes for, when the IDS protocol changes and methods expect the reference still as JSON-LD just as leftover, but not for a particular reason. But I also understand your point. Don't know.

Also, the JSON-LD generated by the IDS object mapper would contain a reference to the idsa context, right? This context wouldn't contain the EDR entity, which also doesn't seem right then.

Right, this info was missing :D so for me it makes no sense to de/serialize an edc object to ids. @ndr-brt Fine for you?


After clicking on send button, keyboard should not be hided (Similar to WhatsApp)

New issue checklist

[ ] I have read all of the README, documentation, and FAQ.
[ ] I have reviewed the contributing guidelines. Confirmation: ____
[ ] I have searched existing issues and this is not a duplicate.

General information

Library version(s):
iOS version(s):
Devices/Simulators affected:
Reproducible in the demo project? (Yes/No):
Related issues:

Bug report
Expected behavior
Actual behavior
Steps to reproduce
Crash log? Screenshots? Videos? Sample project?
How should I prevent keyboard being hided after sending the message?

Thanks @gmansata6290 ! :smile:
I don't understand what you mean.
Please provide all the information in the issue template so we can help!
And don't forget to read our contribution guidelines. :blush:

@jessesquires After typing my message when I click on send button on JSQMessageViewController the keyboard automatically gets hided so I just want to prevent this behaviour. I don't want to hide keyboard after sending a message. How can I prevent or what is the better approach to do that?
Library version(s): 7.3.4
iOS version(s): 8.0 or above
Devices/Simulators affected: yes both
Reproducible in the demo project? (Yes/No): yes
Related issues: Keyboard

@gmansata6290 -- there must be something wrong in your implementation. pressing the send button in the demo does not dismiss the keyboard...

Thanks @jessesquires I got the it.


[release-4.6] IBM Cloud services for DNS and LB

This is an automated cherry-pick of #275
/assign yussufsh

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ltccci
To complete the pull request process, please assign bpradipt after the PR has been reviewed.
You can assign the PR to them by writing /assign @bpradipt in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ltccci, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ltccci, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @bpradipt @Prajyot-Parab

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ltccci, Prajyot-Parab, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, ltccci, Prajyot-Parab, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Fix error format of time in instance list query.

Please answer these questions before submitting pull request

Why submit this pull request?

[x] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

Bug description.
org.apache.skywalking.oap.server.storage.plugin.elasticsearch.query.MetadataQueryEsDAO#getServiceInstances,
this interface return incorrect data.

How to fix?
Fix error format of time in org.apache.skywalking.oap.server.storage.plugin.elasticsearch.query.MetadataQueryEsDAO#getServiceInstances

New feature or improvement

Describe the details and related test reports.

@kezhenxu94 This PR should fix a bug of instance list but seems to cause the e2e broken. Could you take a look about this? Is there an existing e2e check bug too?
In the current version, the instance list will always be all until the TTL deadline, but that is caused by a wrong query condition.

The startTime when verifying in the tests should be updated accordingly
https://github.com/apache/skywalking/blob/dcd66ee6e940bdc9a7ecf90415929bfd48a3a284/test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/base/SkyWalkingTestAdapter.java#L32
    protected final LocalDateTime startTime = LocalDateTime.now(ZoneOffset.UTC).minusMinutes(30);

I rechecked data from traffic instance data,

last_ping is time bucket format. Please recheck.

sorry, my fault. only this code,"org.apache.skywalking.oap.server.core.metric.promethues.PrometheusMetricConverter#generateTraffic",  use timestamp to update serviceTraffic. i will resend pr.


New Infinite Scroll Spec

Our current implementation of infinite scroll has problems, see #445 - and is also very slow.
For comparison, try out the scroll perf on https://blog.algolia.com - it's like an absolute rocket.
It turns out Algolia load JSON, whereas we instead make full page requests, parse the body, and then insert it into the existing page.
It would be really, really cool if Casper could behave the same way as Algolia's implementation.
(I haven't looked at it that closely, but I assume it's just using Jetpack's infinite scroll - for reference)
Changing to use Ghost API rather than full page request would require that the public API is enabled (so, we should probably detect that, and have a super simple fallback?)
It would be great not to have to duplicate all of https://github.com/TryGhost/Casper/blob/master/partials/post-card.hbs when parsing the response, but I'm not sure how else to do it

Closed via https://github.com/TryGhost/Casper/commit/41bcbb71570db0f829a2f0f1b5549f380d38d36a
Poor perf performance for our scroll was mostly down to parsing HTML into jQuery DOM objects and unnecessary fade animations, using HTML rather than JSON should be marginally faster because we don't need to use templates to build DOM on the fly and the HTML pages are more likely to be cached and gzipped than API responses.


Access Token is confusing and over complicated !

Hi,
We have been struggling with Access Token and its complexity. Our design is simple as everything is going through our back-end server, and the back-end server (which controls everything) will connect to the LiveKit server on users' behalf. The client only connects socket/peer/SFU as it requires. Almost all actions like creating a room, deleting a room, listing users, kicking users, managing subscribers/publishers tracks, and such are managed through the back-end (except simulcast) and the back-end server will talk to LiveKit.
The Access Token was just not designed for ease of use in such a case where the back-end server has to create a new Access Token for itself (the Administrator) all the time for each room to be administered which is way too complicated as we have so many rooms and such.
Is there any way to make LiveKit easier for such (popular) scenarios?
We also found that even if we reserve some action for end-user to request directly to LiveKit, it is also very complicated and a new set of token have to be generated all the time, unnecessarily.
Maybe we have not read / understood LiveKit access token thoroughly ? Please help.
Thanks,
Steve

After walking through real-life coding example, we found it pretty good actually. We implement in Python, it works.
Thanks,
Steve

@thusinh1969 have a reference implementation? I'm also about to use python


Fix typo in CRUD tutorial for Entity Framework

s/preferrred/preferred

Hi @jimbeaudoin, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@tdykstra  please review

@danroth27  see OPS build error, fixed by my PR #2023


Thoughts on cfront's potential improvements

Currently cfront is using scanless parser with IR emitter binds into it, and it contains ~3000 LOC. But based on my contributions experience to industrial grade programming languages (V Lang in this case), shecc's frontend parser is lack of ease to either debug or for others to contribute (Even though shecc is meant to be educational).
Here's a list of my thoughts on improving the frontend of shecc:

Discard scanerless parser, rewrite it into both lexer and parser.
Introducing Abstract Syntax Tree for better IR emission and backend generation.
Separation on the compilation phases into multiple files would be a better idea for potential contributors to learn shecc's architecture.

And by accepting the suggestion described above, the possible major changes would be:

Having more than 3 phases compilation in shecc.
The code generation logic must rewrite based on the introduced AST.

Currently cfront is using scanless parser with IR emitter binds into it, and it contains ~3000 LOC. But based on my contributions experience to industrial grade programming languages (V Lang in this case), shecc's frontend parser is lack of ease to either debug or for others to contribute (Even though shecc is meant to be educational).

I have undertaken the task of reworking my earlier compiler project, AMaCC, with a primary focus on its educational value and potential extensibility. I wholeheartedly acknowledge the limitations of the current C front-end implementation, including the absence of a robust AST and proper modularization.
At the same time, @vacantron is dedicated to enhancing the SSA based IR following his initial efforts in register allocation. I want to make sure that we avoid any significant conflicts of interest when it comes to the reworking of the C front-end. Could you please consider proposing a plan for submitting pull requests that involve minimal changes?

Currently cfront is using scanless parser with IR emitter binds into it, and it contains ~3000 LOC. But based on my contributions experience to industrial grade programming languages (V Lang in this case), shecc's frontend parser is lack of ease to either debug or for others to contribute (Even though shecc is meant to be educational).

I have undertaken the task of reworking my earlier compiler project, AMaCC, with a primary focus on its educational value and potential extensibility. I wholeheartedly acknowledge the limitations of the current C front-end implementation, including the absence of a robust AST and proper modularization.
At the same time, @vacantron is dedicated to enhancing the SSA based IR following his initial efforts in register allocation. I want to make sure that we avoid any significant conflicts of interest when it comes to the reworking of the C front-end. Could you please consider proposing a plan for submitting pull requests that involve minimal changes?

No problem, for the minimal changes, I would like to try separate current parser into lexer and parser, so we can keep all lexical analyzing and grammar parsing separate and also keeps all IR related functions stays in the same place in cfront. This will only extract lexical analyzing functionality from cfront and it passes token stream to parser.

Should we also rework the preprocessor? I think the current cfront with the compiler directives and macro expansion might cause some problems in your working.

No problem, for the minimal changes, I would like to try separate current parser into lexer and parser, so we can keep all lexical analyzing and grammar parsing separate and also keeps all IR related functions stays in the same place in cfront. This will only extract lexical analyzing functionality from cfront and it passes token stream to parser.

That sounds promising. You can track the ongoing migration to an SSA-based IR in pull request #85.

Should we also rework the preprocessor? I think the current cfront with the compiler directives and macro expansion might cause some problems in your working.

Yes, I'm currently investigating on it, current implementation is highly unreasonable and may produces some unexpected side effect, I'll try to handle preprocessor directives in parser in a more consistent way. (token based parsing instead of manual string parsing)

For the rework implementation progress, I'll keep update here.

After successfully finishing task #85, @vacantron will focus on improving the SSA IR and its related compilation process. Next, he plans to devote attention to task #88, which involves an optimization phase based on SSA. In the meantime, it presents an ideal opportunity to revise and rework cfront.

Discard scanerless parser, rewrite it into both lexer and parser.

#92 is the starting point for this task.

I recently discovered a small-scale project laroc designed to create a C99 compiler for RISC-V. This project is intended to serve as a reference for improving the frontend and code generation aspects of C compilers.

Edit 2: After discussion with Jserv, shecc will not have a separated preprocessor, instead, I'll focus on making it consistence in token-based parsing form.

I would like to know the reason not to have a separated pre-processor. Current pre-processing logic is mixed in both lexer and parse as special cases. If pre-processing is separated, the implementation may benefit from fewer states in lexer and less additional conditions in parser. Also new features (if planned), such as string concatenation in macro (##), might be easier to add with separated pre-processing. Or other parsing algorithms (like a more error-resilient one) could be easily tried out since dealing with pre-processing is not in need.

I would like to know the reason not to have a separated pre-processor. Current pre-processing logic is mixed in both lexer and parse as special cases. If pre-processing is separated, the implementation may benefit from fewer states in lexer and less additional conditions in parser. Also new features (if planned), such as string concatenation in macro (##), might be easier to add with separated pre-processing. Or other parsing algorithms (like a more error-resilient one) could be easily tried out since dealing with pre-processing is not in need.

This project draws inspiration from AMaCC, which in turn was influenced by the remarkable c4. All three projects share a common theme of minimalism, emphasizing self-bootstrapping without the need for external tools. This is precisely why our project eschews the use of separate assemblers and linkers, despite being a cross-compiler. Unlike mature compilers like GCC and LLVM, where the C preprocessor (cpp) is a distinct program, in our project, cpp is integrated into the lex/parser. This approach aligns with our minimalist design philosophy. While this integration adds complexity to the existing C front-end, we believe that the benefits of a more unified design principle justify this complexity.

As of the merge of #111, the work on cfront's job is considered temporarily completed, but still, I will leave this issue open for the following reasons:

The viability of seperation of parser and lexer is doubtful since memory usage will increase, if the source file's tokenization phase is completely done before syntactic analysis phase and the token information is stored in struct form.
As mentioned above, the tokenization strategy may have to be heavily changed due to the different parsing strategy used in cpp (C preprocessor for short) and the C language itself. More precisely, the newline (\n or \r) or the backslash (\) character may needs to be consider as an valid token in order to successfully parsed. Additionally, the token aliasing strategy will requires previous changes to be done (see #107).
The preprocessor syntax validation, specifically, unused-token-after-expression validation, is unimplemented due to reason 2.

Generally, these issues requires addition investigation to be done in order to be resolved.


HSERACH-1947 Bridge for classes in java.time

https://hibernate.atlassian.net/browse/HSEARCH-1947
The bridges are now going to convert the objects to string padded with zero to allow the sorting.
The provider will check for the types on the classpath instead of checking for the jdk version
By the way, do I need to use the ClassLoader  service to check for the presence of a class or can I use the Class.forName(,..)? I'm asking because in NumericFieldUtils I don't have access to the ClassLoaderService at the moment.
Previous pull request: https://github.com/hibernate/hibernate-search/pull/887

By the way, do I need to use the ClassLoader service to check for the presence of a class or can I use the Class.forName(,..)

I guess the intention is to always use the service. In this case you are looking for Java classes so Class.forName should be fine as well, I guess. Preferably ClassLoaderService though imo.

The idea behind using the Class.forName was to be able to add the classes for other version of JDK.
While I was testing that everything is working fine with a separate project, I discovered that the backports have a different package name. @Sanne: should I create a BridgeProvider (and relative bridges) for the backport as well? I can probably resuse most of the code, so tit should not take too much time
This is the link to the backport page: http://www.threeten.org/
The backport sources: https://github.com/ThreeTen/threetenbp

I just checked this build using the demo as suggested at https://hibernate.atlassian.net/browse/HSEARCH-1969?focusedCommentId=69872&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-69872
and found that this is introducing a hard dependency on the Time types, we should fix that first.

I made a change yesterday evening, could you make sure that you have the latest branch and using the latest building. The problem was that I was catching the wrong exception.
I'm asking because I've tried the demo and it seems to work.

I made a change yesterday evening,

Yeah sorry my snapshot build was from early yesterday. I'll try again now.

I've pushed an update, now the following type are converted to numeric fields:

Instant: truncated to the milliseconds from Epoch
Duration: in nanoseconds, throw exception if it cannot be represented as long
Year as integer

I'm updating the documentation ...

rebasing this


google hangouts - telefon calls not working

Since the update to the latest version, google hangouts does not work properly. I cannot make phone calls anymore. (Franz tries to load all my conacts - but this doesn't happen). Videocalls are fine.

OS: manjaro kde linux

Same issue on Windows 10 November 2019 build. Just get an error saying "Cell phones feature is not available"
Feature still works fine on gmail in Chrome.


avoid multiple initialization of rand

Issue #, if available:
It looks that math/rand is initialized two times.

https://github.com/aws/aws-xray-sdk-go/blob/dc1201085c0b1e64259ef8f7cb48954691212db9/utils/rand.go#L17
https://github.com/aws/aws-xray-sdk-go/blob/dc1201085c0b1e64259ef8f7cb48954691212db9/utils/timer.go#L17

math/rand.Seed changes global state of users' program, so any SDK should not call this.
Description of changes:
I implemented a random value generator only used by the X-Ray SDK.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @shogo82148 ,
would you mind resolving the conflict and adding few tests around the function ?

resolving the conflict is done!


Question:  will ChatterBot support Form type conversation

After Its come to custom adapter, chat should hold the state and continue until the form data filled.
Example, If I have 5 fields in a form : have to do validate and should get input from user. Like iDialog Form in Microsoft Bot Framework

In the future, this is a feature that might possibly be added. I have notes about a possible design in the project wiki. Right now my focus is on improving the performance and accuracy of the chat bot's responses so this feature likely won't be added any time in the near future.

Wiki link https://github.com/gunthercox/ChatterBot/wiki/Chat-Forms

This would be really useful. Being able to keep context and track what's required in a "form" would be great.

@gunthercox Master, I would like work on this feature, could you please guide how to do and where to do

@vkosuri I'll put together a ticket for it with more details.

@VanRH Nope, I will be sure to design it so that it can work independently from the environment where the chat bot is being hosted. It is the bot that will be filling in the fields for the form anyway.


Disabled WARP has messed up my Oh-My-Posh theme.

Windows Terminal version
1.21.3231.0
Windows build number
10.0.26100.0
Other Software
PowerShell 7.4.6
oh-my-posh 24.10.1
Font: Jetbrains Mono Nerd Font
oh-my-posh theme:
{
  "$schema": "https://raw.githubusercontent.com/JanDeDobbeleer/oh-my-posh/main/themes/schema.json",
  "secondary_prompt": {
    "template": " \ueb70 ",
    "background": "transparent"
  },
  "transient_prompt": {
    "template": " \uf054 ",
    "background": "transparent",
    "type": "path"
  },
  "console_title_template": "{{if .Root}}Admin: {{end}} {{.Folder}}",
  "blocks": [
    {
      "type": "prompt",
      "alignment": "left",
      "segments": [
        {
          "properties": {
            "cache_duration": "none"
          },
          "template": "\ue0c5",
          "foreground": "#0a565d",
          "type": "text",
          "style": "plain"
        },
        {
          "properties": {
            "cache_duration": "none"
          },
          "template": " {{ if .WSL }}WSL at {{ end }}{{.Icon}} ",
          "foreground": "#efe6be",
          "powerline_symbol": "\ue0c4",
          "background": "#0a565d",
          "type": "os",
          "style": "powerline"
        },
        {
          "properties": {
            "cache_duration": "none",
            "home_icon": "\uf015  Giresharu",
            "style": "agnoster"
          },
          "template": "{{ .Path }} ",
          "foreground": "#efe6be",
          "powerline_symbol": "\ue0c4",
          "background": "#0a565d",
          "type": "path",
          "style": "powerline"
        },
        {
          "properties": {
            "branch_ahead_icon": "\uf403 ",
            "branch_behind_icon": "\uf407 ",
            "branch_gone_icon": "\udb80\udd64 ",
            "branch_icon": "\ue0a0 ",
            "branch_identical_icon": "\udb80\udd60 ",
            "branch_max_length": 10,
            "cache_duration": "none",
            "fetch_stash_count": false,
            "fetch_status": true,
            "fetch_upstream_icon": false,
            "tag_icon": "\uf412 ",
            "truncate_symbol": "..."
          },
          "template": "{{if gt .Ahead 0}}{{end}} {{ .HEAD }} {{if .BranchStatus }}{{ .BranchStatus }} {{ end }}",
          "foreground": "#efe6be",
          "powerline_symbol": "<#0a565d>\ue0c6",
          "background": "#085b46",
          "type": "git",
          "style": "powerline",
          "foreground_templates": [
            "{{  if or (and .Working.Changed (or (or (gt .Working.Modified 0) (gt .Working.Deleted 0)) (gt .Working.Unmerged 0))) (.Staging.Changed) }}#000000{{ end }}",
            "{{ if and (gt .Ahead 0) (gt .Behind 0) }}#efe6be{{ end }}",
            "{{ if gt .Ahead 0 }}#000000{{ end }}"
          ],
          "background_templates": [
            "{{ if or (and .Working.Changed (or (or (gt .Working.Modified 0) (gt .Working.Deleted 0)) (gt .Working.Unmerged 0))) (.Staging.Changed) }}#eaca20{{ end }}",
            "{{ if and (gt .Ahead 0) (gt .Behind 0) }}#cc3e2b{{ end }}",
            "{{ if gt .Ahead 0 }}#1298df{{ end }}",
            "{{ if gt .Behind 0 }}#8266c5{{ end }}"
          ]
        },
        {
          "properties": {
            "cache_duration": "none",
            "fetch_stash_count": false,
            "fetch_status": true,
            "fetch_upstream_icon": false
          },
          "template": "\ue0c4",
          "foreground": "#085b46",
          "type": "git",
          "style": "powerline",
          "foreground_templates": [
            "{{ if or (and .Working.Changed (or (or (gt .Working.Modified 0) (gt .Working.Deleted 0)) (gt .Working.Unmerged 0))) (.Staging.Changed) }}#eaca20{{ end }}",
            "{{ if and (gt .Ahead 0) (gt .Behind 0) }}#cc3e2b{{ end }}",
            "{{ if gt .Ahead 0 }}#1298df{{ end }}",
            "{{ if gt .Behind 0 }}#8266c5{{ end }}"
          ]
        }
      ]
    },
    {
      "type": "prompt",
      "alignment": "right",
      "segments": [
        {
          "properties": {
            "always_enabled": true,
            "cache_duration": "none"
          },
          "template": " {{ if gt .Code 0 }}{{ .Meaning }} \uf00d{{ else }}\uf00c{{ end }} ",
          "foreground": "#0e3310",
          "powerline_symbol": "\ue0c5\ue0c7",
          "background": "#d4d4d4",
          "type": "exit",
          "style": "powerline",
          "foreground_templates": [
            "{{ if gt .Code 0 }}#d3d7cf{{ end }}"
          ],
          "background_templates": [
            "{{ if gt .Code 0 }}#cc2222{{ end }}"
          ],
          "invert_powerline": true
        },
        {
          "properties": {
            "always_enabled": true,
            "cache_duration": "none"
          },
          "template": "\ue0c4",
          "foreground": "#d4d4d4",
          "powerline_symbol": "\ue0c5",
          "background": "#2d8967",
          "type": "exit",
          "style": "powerline",
          "foreground_templates": [
            "{{ if gt .Code 0 }}#cc2222{{ end }}"
          ],
          "invert_powerline": true
        },
        {
          "properties": {
            "always_enabled": true,
            "cache_duration": "none"
          },
          "template": "\udb81\udcc5 {{ .FormattedMs }} ",
          "foreground": "#efe6be",
          "powerline_symbol": " \ue0c7",
          "background": "#2d8967",
          "type": "executiontime",
          "style": "powerline",
          "invert_powerline": true
        },
        {
          "properties": {
            "cache_duration": "none",
            "time_format": "15:04:05"
          },
          "template": " \uf017 {{ .CurrentDate | date .Format }}",
          "foreground": "#efe6be",
          "powerline_symbol": "\ue0c5\ue0c4",
          "background": "#0a565d",
          "type": "time",
          "style": "powerline",
          "invert_powerline": true
        },
        {
          "properties": {
            "cache_duration": "none"
          },
          "foreground": "#ffd700",
          "powerline_symbol": "\ue0c4",
          "background": "#0a565d",
          "type": "text",
          "style": "accordion"
        }
      ]
    },
    {
      "type": "prompt",
      "alignment": "left",
      "segments": [
        {
          "properties": {
            "cache_duration": "none"
          },
          "template": " {{if .Commit.Subject}} [\ueafc {{.Commit.Subject}} \uf007 {{.Commit.Author.Name}} \udb80\uddee {{.Commit.Author.Email}}]{{end}}",
          "foreground": "#3a7c50",
          "background": "transparent",
          "type": "git",
          "style": "diamond"
        },
        {
          "properties": {
            "cache_duration": "none"
          },
          "foreground": "#5aAcAc",
          "background": "transparent",
          "type": "git",
          "style": "diamond",
          "templates": [
            "{{if or .WorktreeCount (gt (.Env.BRANCH_COUNT | int) 0)}}[{{end}}",
            "{{if gt (.Env.BRANCH_COUNT | int) 0}}\uf126 {{add .Env.BRANCH_COUNT 1}}{{end}}",
            "{{if and .WorktreeCount (gt (.Env.BRANCH_COUNT | int) 0)}} {{end}}{{if .WorktreeCount}}\udb83\ude94 {{add .WorktreeCount 1}}{{end}}",
            "{{if or .WorktreeCount (gt (.Env.BRANCH_COUNT | int) 0)}}]{{end}}"
          ]
        },
        {
          "properties": {
            "cache_duration": "none",
            "fetch_stash_count": true,
            "fetch_status": true,
            "fetch_upstream_icon": false
          },
          "trailing_diamond": "\ue0b0",
          "foreground": "#506463",
          "background": "transparent",
          "type": "git",
          "style": "diamond",
          "foreground_templates": [
            "{{if or .Staging.Added .Staging.Modified}}#eeb573{{end}}"
          ],
          "templates": [
            "{{if or .Staging.Changed (gt .StashCount 0)}}[{{end}}",
            "{{if .Staging.Added}}\udb81\udf52 {{.Staging.Added}}{{end}}",
            "{{if and .Staging.Added .Staging.Modified}} {{end}}{{if .Staging.Modified}}\udb83\uddc8 {{.Staging.Modified}}{{end}}",
            "{{if and (or .Staging.Added .Staging.Modified) .Staging.Deleted}} {{end}}{{if .Staging.Deleted}}\udb86\ude9f {{.Staging.Deleted}}{{end}}",
            "{{if and (or (or .Staging.Added .Staging.Modified) .Staging.Deleted) .StashCount}} {{end}}{{if .StashCount}}\uf187 {{.StashCount}}{{end}}",
            "{{if or .Staging.Changed (gt .StashCount 0)}}]{{end}}"
          ]
        },
        {
          "properties": {
            "cache_duration": "none",
            "fetch_stash_count": false,
            "fetch_status": true,
            "fetch_upstream_icon": false
          },
          "foreground": "#eee673",
          "background": "transparent",
          "type": "git",
          "style": "powerline",
          "foreground_templates": [
            "{{if .Working.Unmerged}}#E74555{{end}}",
            "{{ if and (eq .Working.Modified 0) (eq .Working.Deleted 0) }}#6b5c80{{ end }}"
          ],
          "templates": [
            "{{if .Working.Changed}}[{{end}}",
            "{{if or .Working.Untracked .Working.Added}}\uf059 {{add .Working.Untracked .Working.Added}}{{end}}",
            "{{if and (or .Working.Untracked .Working.Added) .Working.Modified}} {{end}}{{if .Working.Modified}}\udb83\uddc8 {{.Working.Modified}}{{end}}",
            "{{if and (or .Working.Untracked .Working.Modified) .Working.Deleted}} {{end}}{{if .Working.Deleted}}\udb86\ude9f {{.Working.Deleted}}{{end}}",
            "{{if and (or (or .Working.Untracked .Working.Modified) .Working.Deleted) .Working.Unmerged}} {{end}}{{if .Working.Unmerged}}\ue728 {{.Working.Unmerged}}{{end}}",
            "{{if .Working.Changed}}]{{end}}"
          ]
        }
      ]
    },
    {
      "type": "prompt",
      "alignment": "left",
      "segments": [
        {
          "properties": {
            "cache_duration": "none"
          },
          "template": "\ueb70\uf054",
          "type": "text",
          "style": "powerline"
        }
      ],
      "newline": true
    }
  ],
  "version": 3,
  "final_space": true
}

Steps to reproduce

Follow the instructions on the oh-my-posh official website to install oh-my-posh. (I used winget to install it.)
Save the theme I provided above as a local JSON file, and use code $profile or another editor to open the Microsoft.PowerShell_profile.ps1 file, and add the following line:

oh-my-posh init pwsh --config "PathToTheme.json" | Invoke-Expression

Download the JetBrains Mono Nerd Font from NerdFont (the font I am actually using is a full patch version manually created with the patch provided by NerdFont; I am unsure if providing the file here would cause copyright issues. If there are no copyright issues, I will provide the attachment later).
Change the font of Windows Terminal to the one downloaded in step 3, and disable the WARP feature.
Restart Windows Terminal, and open pwsh7 in it.

Expected Behavior
The correct theme is the same as when WARP is enabled; the text color does not mess up the background, causing the theme to become muddled. As shown in the figure:

However, enabling it will cause another issue, which is that the cursor is not displayed. Therefore, I cannot work with WARP enabled.
Actual Behavior
Messed up theme, as shown in the figure. Each yellow Nerd Font character has incorrectly affected the color of the background block, resulting in a confused theme:

However, enabling it will cause another issue, which is that the cursor is not displayed. Therefore, I cannot work with WARP enabled.

This is a separate bug worth investigating.

Thanks for filing! Some questions from the team:

Can you share the current ttf file you're using for this font as a ZIP?
If you use the latest version of the font, does this repro?

The latest Windows Terminal Preview version supports a new text selection mode, which reveals why this issue occurs:
https://github.com/user-attachments/assets/1fc61248-ee5f-44ac-90d8-df1da0018cd1
Your powerline characters are visually 2 columns wide, but Unicode says that they're supposed to be 1 column wide characters. This is why you need to use "\ue0c5 " with a space at the end as padding.
That aside, I noticed that your oh-my-posh configuration has a lot of issues and smaller mistakes. If you search for your example powerline character in the repository, you'll find a lot of reference code that you can use: https://github.com/search?q=repo%3AJanDeDobbeleer%2Foh-my-posh ue0c5&type=code
Among others, you can merge your first and second segment together by simply using the "leading_diamond" attribute.
Let me know if you have any questions!

I should add that the only reason you don't see this when WARP is enabled is because we use a fallback text renderer in that case that is less accurate. You should also never ever use WARP if you can avoid it. It's basically a small CPU torture test every time you print lots of text. 😟

The latest Windows Terminal Preview version supports a new text selection mode, which reveals why this issue occurs:
QKKiuJdjMHnn7acE.mp4
Your powerline characters are visually 2 columns wide, but Unicode says that they're supposed to be 1 column wide characters. This is why you need to use "\ue0c5 " with a space at the end as padding.
That aside, I noticed that your oh-my-posh configuration has a lot of issues and smaller mistakes. If you search for your example powerline character in the repository, you'll find a lot of reference code that you can use: https://github.com/search?q=repo%3AJanDeDobbeleer%2Foh-my-posh ue0c5&type=code Among others, you can merge your first and second segment together by simply using the "leading_diamond" attribute.
Let me know if you have any questions!

That makes sense, I must find a way to improve my theme file.

The latest Windows Terminal Preview version supports a new text selection mode, which reveals why this issue occurs:
QKKiuJdjMHnn7acE.mp4
Your powerline characters are visually 2 columns wide, but Unicode says that they're supposed to be 1 column wide characters. This is why you need to use "\ue0c5 " with a space at the end as padding.
That aside, I noticed that your oh-my-posh configuration has a lot of issues and smaller mistakes. If you search for your example powerline character in the repository, you'll find a lot of reference code that you can use: https://github.com/search?q=repo%3AJanDeDobbeleer%2Foh-my-posh ue0c5&type=code Among others, you can merge your first and second segment together by simply using the "leading_diamond" attribute.
Let me know if you have any questions!

I took another look at the themes provided by oh_my_posh that use the same characters, and they seem to have the same issue. Other terminals do not have similar problems. Can this really not be considered a problem with Windows Terminal? If the theme configuration needs to be modified due to character length reasons, wouldn't that configuration no longer be universal?
Windows Terminal:

Tabby:

Hmm... I don't mind treating this as a bug in Windows Terminal, but I'm honestly not convinced yet that it is one. Your example images from Tabby perhaps shows it best. This is how it's supposed to look like, coming straight from the oh-my-posh website:

In the "cert" theme, Tabby is drawing the powerline symbols on top of the colored background, while in the reference image it blends in perfectly. In the "free-ukraine" theme, the color of the icons is wrong (it's white but should be yellow).
I think it's fair to say that the more advanced oh-my-posh themes make certain assumptions about the text rendering behavior of the terminal that may not be universally true.


Since v1.2.0, the drawer button is not well aligned on large screens

Tested on Chrome and Firefox, from v1.2.0, the drawer icon is not well aligned on large screens; it's too low.
You can see the difference in the 2 following codepen when the view is bigger than 1024px:
v1.1.3
v1.2.0

Working on this in PR #4675


OHRI-1964 COVID-19 Cases" title missing in the COVID Programme

Requirements

[ ] This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
[ ] My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@kajambiya ,@jaime,@Pius,kindly review this PR


Clearing a cache tag, clears ALL cache!

Describe the bug
Consider the following code:
// Tag-less key
cache()->put('key1', 'value1');
// Tagged key
cache()->tags('tag1')->put('key2', 'value2');

Now delete keys under "tag1"
cache()->tags('tag1')->clear();

In the above example not only the "key2" will be deleted, but also "key1"! The whole cache in fact will be cleared!
This library handles multi-tenancy caching by adding all the tenant's cache keys under a tenant tag (e.g. tenant_xyz). And the  CacheManager passes all calls through ->tags([ tenant tag ]) first, to assure that get/put/delete/... only works on the current tenant.
That means that if try to clear keys under a certain other tag, the library will add the tenant's tag to the tags array (previously hold only the user's tag), and Laravel's beheiver is to clear all keys under EITHER tags (here)! And in this case, ALL the tenant's cache will be deleted, since it's all under the tenant's tag.
Steps to reproduce
Simply use the code above and try to dd the value of key1
Expected behavior
Only the tag's keys should be deleted
Your setup

Laravel version: [e.g. 7.5.0]
stancl/tenancy version: [e.g. 3.1.0]

Hey, thanks for the report. Seems like the tags approach isn't ideal, even if it seemed nice due to how easy deleting individual tenants' cache is by specifying the tags.
I'll change this in v4 probably by making the cache use prefixes instead of tags, and I'll add a custom command for clearing tenant cache.

Great. I think prefixed keys is the way to go too> A quick fix also could be to exclude the "clear" method from that rule in the CacheManager, thus allowing clearing only the passed tags, not the tenant's primary tag.
Also If you manage to find time for one more extra thing in this area I believe it should be something to handle cache in the centeral app scope. Because currently everything is linked to the tenants, but what if one wanted to cache something shared between all tenants?
Thanks for the time and effort.

but what if one wanted to cache something shared between all tenants

You can use the CentralCache facade or the central_cache() helper iirc. It's possible that I didn't document them, but I think they should be mentioned somewhere.

Sorry, global cache, not central.

Even in a bare laravel app with Redis cache
cache()->tags('tag1')->clear();

will clear all the cache not just the tags
it should in fact be flush() to just clear the keys under the tags
cache()->tags('tag1')->flush();

however
https://laravel.com/docs/8.x/cache#removing-tagged-cache-items
with a tenant say foo this cache()->tags('tag1')->flush(); is basically the same as cache()->tags(['tenantfoo', 'tag1'])->flush();
and so both tags are cleared, its treated more as an or than an and
if you had put something under 'tag1' in central\global even that would be cleared

Hello everyone, I have used multi db and everything, but how to implement the cache ?
Because normal cache is not working
and I couldn't get what you mean by this :-
cache
The CacheManager instance that's resolved when you use the Cache or the cache() helper will be replaced by Stancl\Tenancy\CacheManager. This class automatically uses tags. The tag will look like config('tenancy.cache.tag_base') . $uuid.
https://tenancyforlaravel.com/docs/v1/configuration/


Change MFA setup instruction to Okta [KETI-1687]

Signed-off-by: Bharath Sekar<EMAIL_ADDRESS>

Verified


switch to stable release

Switching to use stable release and fixing clippy issues along the way. Also removed atomic-exec/examples/fungible-token for now as it is causing conflicting wasm build and we are deprecating it. Deleting it for now as a quick solution.

@cryptoAtwill, as discussed sync, I suggest using directly the new refactored implementation merged to dev: https://github.com/consensus-shipyard/ipc-agent/pull/300 Actors will be deprecated, and we will move all actor-related types from the sdk to the ipc-agent repo from now on. Closing this one accordingly (feel free to reopen if needed)


Return hash output (useful for command-line testing at least)

@kaspth First of all, let me thank you for your refactoring work, it's very impressive and I'm learning a lot!
It seems the pure Ruby Hash output was removed, but I used it a lot to debug code in command line, it's much more readable than yaml or json strings. Here I return it back as Jbuilder::Schema.hash.

Ah, the previous code didn't run normalize when just returning the schema hash i.e. load, so I preserved that here. What if we just run normalize in load?

I should clarify, the intent was to use Jbuilder::Schema.load to return the schema hash, like the old API would.

Yes, I see that now. Hm, that is weird I didn't use normalization in straight hash output before.
Well, I believe all 3 outputs should return same data.

If we're swapping back to string keys, then the normalization only does something for Regexps and I think we should just cut it then.

It sets Regexps to the right format for JSON-Schema


grpc: Don't close the terminal on CloseStdin() call

CloseStdin() is supposed to close only the standard input, which
helps the process to terminate in some cases. But for the case where
we are using a terminal, it should be closed by the agent once the
WaitProcess() will complete. Otherwise, closing it before the end of
the process could prevent some output from the terminal to reach the
shim.
Fixes #283
Signed-off-by: Sebastien Boeuf<EMAIL_ADDRESS>

@jodh-intel @amshinde @bergwolf @grahamwhaley PTAL

lgtm

@sboeuf I think we should deny WriteStdin as well in such case.

@bergwolf what do you mean ? Do you mean that we should ignore any WriteStdin() after CloseStdin() got invoked ?

@sboeuf yes

@bergwolf yes I can definitely add a flag to ignore WriteStdin() if stdin has been closed previously !

@bergwolf PR updated, PTAL !

lgtm

@bergwolf PR updated!


JCenter support

At the moment the library requires volley that is available only in jCenter which will be closed 1 of May

At the moment Volley team is working on releasing the version 1.2.0 either on maven central or on maven google:
https://github.com/google/volley/issues/394

Hey @adamszewe, Google released Volley 1.2.0 recently, do you have any plans to update processout-sdk?

Do you have any updates on this migration? We don't support jcenter() in our app and we had to manually authorize it in our codebase because of the outdated Volley dependency...
This issue was created 1 year ago, and many libraries used by this SDK are still outdated... Is this SDK still maintained? 👇

We upgraded the libraries the sdk uses in the latest release. https://github.com/processout/processout-android/releases/tag/2.18.4


Use of separate entities for charging state at card config level

Using a secondary entity for charging state is already possible at the individual entity level. However, this feature is not yet applicable at a card config level.
I suppose having something similar to the filter function but for charging state could be a possible approach.

I would imagine something like this:
charging_filter:
  include: # filters for auto-adding charging states
    - name: entity_id # entities which id ends with "_is_charging"
      value: "*_is_charging"

Exactly what I'm looking for. Please have a look at https://community.home-assistant.io/t/lovelace-battery-state-card/191535/157 for potential additional/helpful information.

Closing as a dupe of #365


bug: TypeScript import names are the same color as the import keyword

Describe the bug
import * as X from 'y.js'

Note (see screenshot) that the colour of the actual import is the same as the other keywords, and means it is hard to differentiate. Ideally it would be marked in a different color.

Screenshots
No response
Operating System + version
13.4.1 Mac OSX
Neovim version
NVIM v0.10.0-dev-433+g4b60267f8
Reproduce steps

Load up a TypeScript project with LSP configured
Find a file that has an ES Module import in

Expected Behavior
No response
Additional context
No response

require("dark_flat").setup({
  themes = function(colors)
    return {
<EMAIL_ADDRESS>= { fg = colors.white:darken(0.8) },
    }
  end,
})

Makes this look much nicer. I would be happy to contribute this back if you are happy with this?

I have solved. Pls try to sync again 🤔

Thanks!


Filename too long

 /Users/postit/Documents/projects/ucdpolicies/output/docs/ucd/ucddelegation/DA 2629, Vice Chancellor--Human Health Sciences to Director--Facilities Planning and Development Approval of Appointment of Executive Design Professionals and Execution of Executive Design Professional Agreements.pdf.
Should update code to truncate really long filenames

no filenames in v2


Use Atomastic Components instead of Flextype Components

We should use
atomastic/session
atomastic/arrays
atomastic/filesystem
atomastic/registry
atomastic/strings

should be removed
flextype-components/arrays
flextype-components/filesystem

implemented for all components, except of one I18N - it is should be replaced in ferthere releases


Spell1 generated parser

As you mentioned on IRC that you were planning to use spell1, I gave it a shot.
It compiles and the resulting binary can still evaluate (+ 1 1) but that is about the extent of my testing done as I don't really know how a release is tested.
This was generated with a fresh (from today) checkout of spell1.

You were a little fast there. :-) Locally I had added #. to the syntax and cleaned up the code a little but not committed and pushed. I have done that now. If you could re-include the new files and rebuild lfe_parse.erl I will pull it.

Cool.  I updated the .spell grammar file from the spell1 repo's examples/erl/ dir and also fixed the Makefile target to actually work.
The new stuff has now been pushed.


production build doesn't work

chrome-extension://sdfsdff/newtab/newtab/index.js Failed to load resource: net::ERR_FILE_NOT_FOUND

Do you have public repo with that? Problem is obvious, but why it happened is another story :)

gulp -p and install it, I've tried to figure it out, :-( no luck.

See my pull request (#10), should address the issue. The relative path to index.js is currently incorrect in production builds.

Thanks to @MattSPalmer, we find the source of issue. Fixed with commit https://github.com/schovi/webpack-chrome-extension/commit/9ffe78cf13028b5d88e8442e3e8e1995856c6f62


Need support for latest Node (0.12.x) and iojs (3.x.x)

As far as I know support for iojs might be difficult or takes time due to some (sub)dependencies that need to use and update the codebase for nan 2.x.x
Support for node 0.12.x should be a must have in my opinion.

It depends on whether more that one project uses Jeff.

Well, I use Jeff on my project and use iojs 3 on it. Can make the effort for node 0.12.x though.

The chances for these supports to happen are higher if someone contributed.

This should no longer be relevant.


Updating namespace for attribute-based rules.

Description
The given example for building and looping over attributes to build rules works well, but it also (if unchanged) pulls in the default attributes for iptables, which generate invalid rules.
Issues Resolved
https://github.com/chef-cookbooks/iptables/issues/81
Check List

[X] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[X] New functionality includes testing.
[X] New functionality has been documented in the README if applicable
[X] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Signed-off-by: Jerry Qassar<EMAIL_ADDRESS>

Thanks for the fix


🐛 BUG: wrangler dev throws if finding a non-iterable middleware export

Which Cloudflare product(s) does this pertain to?
Wrangler core
What version(s) of the tool(s) are you using?
3.39.0 [Wrangler]
What version of Node are you using?
20.10.0
What operating system and version are you using?
Mac Ventura 13
Describe the Bug
Observed Behavior
wrangler dev throws if it finds an export named "middleware", but cannot iterate it.
Expected Behavior
If requesting a hidden exported property (middleware) and iterating over it, there should at least be checks to verify if the item is iterable before attempting to iterate.
TLDR; It should not throw.
Error Reproduction
Create a simple file with the following content, then launch it using wrangler dev:
export default {
  middleware: () => {}, // wrangler dev attempts to iterate this, throwing
}

The same script runs fine in production/deployed but cannot be run locally.
Why this matters
itty-router routers have a Proxy trap on the prototype chain.  If we export our router directly, a request from the runtime to "middleware" returns a function (via that trap).  This throws when wrangler tries to iterate it without checking to see if it's iterable/an array.
import { Router } from 'itty-router'

export default Router() // this doesn't work locally

export default { ...Router() } // but this does, as the prototype chain is stripped

Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs

Fun Fact
We used a Proxy to identify that the property "middleware" was being requested from the export (the logs showed nothing).

@kwhitley Just to check, does itty-router have a middleware property?

We can definitely add that check (as the linked PR does), but is there any reason itty-router returns a function for the middleware property? Ideally it should only return a function for the fetch property, and pass through to the underlying object otherwise

Itty allows (unknown) properties to be read off the underlying object as methods/route handlers, in order to maintain its tiny footprint and support virtually any current/future HTTP type.
For instance, accessing router.post responds with a route handler (function) that will ultimately register on the POST http method. Likewise for any other attributes not defined on the underlying object itself, so router.middleware is simply interpreted as the user trying to create a route handler matching the MIDDLEWARE http method :)

This is why our current wrangler dev workaround of export default { ...router } works, even though it looks pointless. It strips off the proxy prototype from the object, returning only the current tangible values, and none of the intercept behavior. A bit of random trivia there!

The " export default { ...router }" seems to still have major problems. It was initially working untill this morning and I spent more than an hour trying to figure out whats wrong with my local inspector in vs code in cloudflare worker.
the only fix to get it to work is to just remove itty-router all together
https://www.loom.com/share/d8ca80a8e700474fb1ef8711f1fd94fd

The " export default { ...router }" seems to still have major problems. It was initially working untill this morning and I spent more than an hour trying to figure out whats wrong with my local inspector in vs code in cloudflare worker.
the only fix to get it to work is to just remove itty-router all together
https://www.loom.com/share/d8ca80a8e700474fb1ef8711f1fd94fd

I feel like you'd be better off asking itty-router specifically for help with this, maybe there is something else in your setup that's causing issues with it.

I didnt see a way of reachung out to them directly, whays the best way to do that?Sent from my iPhoneOn Jun 29, 2024, at 4:10 PM, MajorTanya @.***> wrote:
The " export default { ...router }" seems to still have major problems. It was initially working untill this morning and I spent more than an hour trying to figure out whats wrong with my local inspector in vs code in cloudflare worker.
the only fix to get it to work is to just remove itty-router all together
https://www.loom.com/share/d8ca80a8e700474fb1ef8711f1fd94fd
I feel like you'd be better off asking itty-router specifically for help with this, maybe there is something else in your setup that's causing issues with it.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

I'd recommend the itty discord - where folks like Major Tanya here are amazing at sorting out issues people encounter! :)
https://discord.gg/7YRS9jMzHD

In fact, the 500 error you’re seeing says (to me) that itty is working fine, and that wrangler isn't the issue... otherwise you'd see a terminal error, rather than a properly thrown 500 Response. So something else must be up!

Hey Kevin,
If the only solution to fixing the issue is removing itty router all
together, and if the first time the issue started to occur was within a day
of adding itty-router, then how can you possibly conclude that the issue is
not with jitty router?!
On Sun, Jun 30, 2024 at 12:41 AM Kevin R. Whitley @.***>
wrote:

In fact, the 500 error you’re seeing says (to me) that itty is working
fine, and that wrangler isn't the issue... otherwise you'd see a terminal
error, rather than a properly thrown 500 Response. So something else must
be up!
—
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/workers-sdk/issues/5420#issuecomment-2198467976,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5JG2ESKFLLXB7BSPYV3373ZJ6ZD5AVCNFSM6AAAAABFLWM2I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGQ3DOOJXGY
.
You are receiving this because you commented.Message ID:
@.***>

as soon as I remove itty router, everything works fine. Havent seen the
issue before and haven't seen it since.
On Sun, Jun 30, 2024 at 8:42 AM Adeola Morren @.***> wrote:

Hey Kevin,
If the only solution to fixing the issue is removing itty router all
together, and if the first time the issue started to occur was within a day
of adding itty-router, then how can you possibly conclude that the issue is
not with jitty router?!
On Sun, Jun 30, 2024 at 12:41 AM Kevin R. Whitley <
@.***> wrote:

In fact, the 500 error you’re seeing says (to me) that itty is working
fine, and that wrangler isn't the issue... otherwise you'd see a terminal
error, rather than a properly thrown 500 Response. So something else must
be up!
—
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/workers-sdk/issues/5420#issuecomment-2198467976,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5JG2ESKFLLXB7BSPYV3373ZJ6ZD5AVCNFSM6AAAAABFLWM2I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGQ3DOOJXGY
.
You are receiving this because you commented.Message ID:
@.***>

I highly doubt the only solution is to remove itty. A thrown 500 suggests a possible error in your handlers. That said, I don't believe this thread is the place to discuss, as it is likely unrelated. Mind opening an issue on itty-router's board, or discussing in Discord? If we can peak at your code, we can likely sort you out :)


Add Picture View on Create Page

Value description/ definition
As a user
I want to see wich image i want to upload
so that I know that it is the correct image I want to upload to my sheet
Description
implement that the uploaded image is shown in the create form
Acceptance criteria

[ ] the image must shown on the create page

Tasks

[ ] Create a branch
[ ] Make first Commit for Upstream
[ ] implement a view-space for the image

Complexity
low

Hey 👋 good idea!
The only thing I would add: what happens when the user added the wrong image? He should be able to delete it? Then you also need the functionality for that.


#177: setup of administration frontend

create react app
added graphql support
added blueprintjs
created navigation skeleton

@maxammann Imo web-frontend rather sounds like a web-frontend for the app (facing "otto-normal" users). Administration is fine for me; maybe also content-management or just management would suit as well...

@maxammann Imo web-frontend rather sounds like a web-frontend for the app (facing "otto-normal" users). Administration is fine for me; maybe also content-management or just management would suit as well...


Content item count tab

Change Audit Content tab to My content (x), where x is the number of unaudited content items that are assigned to the current user, due to the positive feedback that was received on the prototype feature during user research sessions.
Add my_content_spec.rb to test that the My content tab reflects the correct number of content items as the user assigns, unassigns and audits content items.
Add audit_assignment_page object model, and assign new elements in other page object models, to allow testing using the page object model pattern currently employed in similar feature tests in the application.

 (3) 'My content item count' (in the tabbed area)

 (3) 'My content item count' (in the tabbed area)


IOError: [Errno 2] No such file or directory: '/opt/ros/melodic/lib/turtlebot3_autorace_core/traffic_light_red/model.sdf'

Hello,
I want to practice the link but I get an error
http://emanual.robotis.com/docs/en/platform/turtlebot3/autonomous_gazebo/
"roslaunch turtlebot3_gazebo turtlebot3_autorace.launch " command is working, not error but ,
"roslaunch turtlebot3_gazebo turtlebot3_autorace_mission.launch" command is not working, get error.
I would be happy if you help ,thanks
started roslaunch server http://ali:36213/
SUMMARY
PARAMETERS

/rosdistro: melodic
/rosversion: 1.14.5

NODES
/
core_node_mission (turtlebot3_autorace_core/core_node_mission)
ROS_MASTER_URI=http://localhost:11311
process[core_node_mission-1]: started with pid [9603]
Traceback (most recent call last):
File "/opt/ros/melodic/lib/turtlebot3_autorace_core/core_node_mission", line 163, in
main()
File "/opt/ros/melodic/lib/turtlebot3_autorace_core/core_node_mission", line 158, in main
controlmission = ControlMission()
File "/opt/ros/melodic/lib/turtlebot3_autorace_core/core_node_mission", line 38, in init
self.loadMissionModel()
File "/opt/ros/melodic/lib/turtlebot3_autorace_core/core_node_mission", line 65, in loadMissionModel
red_light_model = open(red_light_path,'r')
IOError: [Errno 2] No such file or directory: '/opt/ros/melodic/lib/turtlebot3_autorace_core/traffic_light_red/model.sdf'
[core_node_mission-1] process has died [pid 9603, exit code 1, cmd /opt/ros/melodic/lib/turtlebot3_autorace_core/core_node_mission __name:=core_node_mission __log:=/home/ali/.ros/log/0979ac9a-834e-11ea-a2d0-28c2dd84afd9/core_node_mission-1.log].
log file: /home/ali/.ros/log/0979ac9a-834e-11ea-a2d0-28c2dd84afd9/core_node_mission-1*.log
all processes on machine have died, roslaunch will exit
shutting down processing monitor...
... shutting down processing monitor complete
done

@aliozcan01
First of all, the simulation is written based on ROS 1 Kinetic so there could be some differences in Melodic.
It seems like you haven't properly installed the package.
Make sure that you have all the necessary packages under the ~/catkin_ws/src folder.
As of now, binary installation using apt install ros-kinetic.... does not provide the latest source.
Please use git clone method to download the source code and build locally.
Thank you.

Thank you for your answer.
I do not have a missing package inside ~/catkin_ws/src .
But I think there is a problem with ros melodic files.
There are various  Turtlebot3 files in their directory:
/opt/ros/melodic/lib
/opt/ros/melodic/share
sudo apt-get install ros-melodic-turtlebot3-*
I installed it with this command
How can I install differently as you mentioned ?
Thanks.
Note:
My only problem is Autorace in Turtlebot3 Simulations. Other simulation sections work smoothly, with minor exceptions.

@aliozcan01
Hi, we are currently preparing for the binary source code update.
In order to download the most up to date source code, please use the instruction with git clone command written in the eManual.
Please also note that there are 2 different Autorace version (2020 and 2019).
http://emanual.robotis.com/docs/en/platform/turtlebot3/autonomous_driving/#ros-1-autonomous-driving
Thank you.

problem solved, thanks a lot

Hello aliozcan01,
i get same error.
how did you solve that error?

Hello aliozcan01,
i get same error.
how did you solve that error?

Hello Mayur,
I solved the problem by following the steps below. I hope that will be useful.
sudo apt-get install ros-melodic-turtlebot3-*
cd ~/catkin_ws/src/
git clone https://github.com/ROBOTIS-GIT/turtlebot3_msgs.git
git clone https://github.com/ROBOTIS-GIT/turtlebot3.git
git clone https://github.com/ROBOTIS-GIT/turtlebot3_simulations
git clone https://github.com/ROBOTIS-GIT/turtlebot3_autorace
cd ~/catkin_ws && catkin_make

Hello Mayur,
I solved the problem by following the steps below. I hope that will be useful.
sudo apt-get install ros-melodic-turtlebot3-*
cd ~/catkin_ws/src/
git clone https://github.com/ROBOTIS-GIT/turtlebot3_msgs.git
git clone https://github.com/ROBOTIS-GIT/turtlebot3.git
git clone https://github.com/ROBOTIS-GIT/turtlebot3_simulations
git clone https://github.com/ROBOTIS-GIT/turtlebot3_autorace
cd ~/catkin_ws && catkin_make

thanks for your reply.
But it does not work.

I can run , do not use
sudo apt-get install ros-melodic-turtlebot3-*
after git clone and catkin_make:
cd catkin_ws source devel/setup.bash
then roslaunch those launch files

I can run , do not use
sudo apt-get install ros-melodic-turtlebot3-*
after git clone and catkin_make:
cd catkin_ws source devel/setup.bash
then roslaunch those launch files

@MayurRabadiya  Which ROS distribution are you using? The current Autorace packages support ROS 1 Kinetic and Melodic.

i am use melodic
On Wed, Jan 6, 2021 at 5:12 AM Will Son<EMAIL_ADDRESS>wrote:

@MayurRabadiya https://github.com/MayurRabadiya Which ROS distribution
are you using? The current Autorace packages support ROS 1 Kinetic and
Melodic.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ROBOTIS-GIT/turtlebot3_autorace/issues/48#issuecomment-754967944,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKIZMOPB2JD66BUVCPY2CC3SYOPV3ANCNFSM4MMZL35Q
.

i am use melodic
On Wed, Jan 6, 2021 at 5:12 AM Will Son<EMAIL_ADDRESS>wrote:

@MayurRabadiya https://github.com/MayurRabadiya Which ROS distribution
are you using? The current Autorace packages support ROS 1 Kinetic and
Melodic.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ROBOTIS-GIT/turtlebot3_autorace/issues/48#issuecomment-754967944,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKIZMOPB2JD66BUVCPY2CC3SYOPV3ANCNFSM4MMZL35Q
.