[BACKLOG-18772] - Only set the parameter is the scheme of the variable matches the one being used by the file options

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/vfs/KettleVFS.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.vfs.KettleVFS

Branch Change: -1.97%:small_red_triangle_down:
Complexity Change: -1.03%:small_red_triangle_down:
Instruction Change: -.58%:small_red_triangle_down:
Line Change: -.35%:small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -.38%:small_red_triangle_down:
Complexity Change: -.51%:small_red_triangle_down:
Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change:  + .52%
Complexity Change:  + .56%
Instruction Change:  + .07%

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.28%:small_red_triangle_down:
Line Change: -3.87%:small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -.66%:small_red_triangle_down:
Complexity Change: -.93%:small_red_triangle_down:
Instruction Change: -.13%:small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -.68%:small_red_triangle_down:
Complexity Change: -.58%:small_red_triangle_down:
Instruction Change: -.19%:small_red_triangle_down:
Line Change: -.26%:small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change:  + 8.70%
Complexity Change:  + 3.03%
Instruction Change:  + .75%
Line Change:  + .89%

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -.11%:small_red_triangle_down:

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -3.12%:small_red_triangle_down:
Complexity Change: -3.16%:small_red_triangle_down:
Instruction Change: -.14%:small_red_triangle_down:
Line Change: -.37%:small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change:  + 2.00%
Complexity Change:  + 1.89%
Instruction Change:  + .17%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -.06%:small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -.14%:small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change:  + .91%
Complexity Change:  + .82%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -.18%:small_red_triangle_down:

org.pentaho.di.trans.steps.googleanalytics.GaInputStepMeta

Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -.15%:small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change:  + .17%

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/vfs/KettleVFS.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.vfs.KettleVFS

Branch Change: -1.97%:small_red_triangle_down:
Complexity Change: -1.03%:small_red_triangle_down:
Instruction Change: -.58%:small_red_triangle_down:
Line Change: -.35%:small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.28%:small_red_triangle_down:
Line Change: -3.87%:small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change: -8.70%:small_red_triangle_down:
Complexity Change: -3.03%:small_red_triangle_down:
Instruction Change: -.75%:small_red_triangle_down:
Line Change: -.89%:small_red_triangle_down:

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -.11%:small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.22%:small_red_triangle_down:
Complexity Change: -.76%:small_red_triangle_down:
Instruction Change: -.29%:small_red_triangle_down:
Method Change:  + 1.01%

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2.08%:small_red_triangle_down:
Complexity Change: -2.11%:small_red_triangle_down:
Instruction Change: -.14%:small_red_triangle_down:
Line Change: -.37%:small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Branch Change: -1.22%:small_red_triangle_down:
Complexity Change: -.85%:small_red_triangle_down:
Instruction Change: -.06%:small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.12%
Complexity Change:  + 1.30%
Instruction Change:  + .17%
Line Change:  + .46%

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change:  + .91%
Complexity Change:  + .82%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.googleanalytics.GaInputStepMeta

Instruction Change:  + .07%

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change:  + .93%
Complexity Change:  + .80%
Instruction Change:  + .17%

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -.14%:small_red_triangle_down:


Issue/jdt issue with nested class in module 1000678

Updated ScalaStructureBuilder, as it is responsible of correctly exposing module's inner classes to JDT. The issue was that module's inner classes were exposed as member of the $ module class, which is wrong, since the scala compiler expose them as inner classes of the module's companion class.
I moved the code that was responsible of traversing the Scala AST Tree into a new class 'TreeTraverser', that takes a new field 'module2innerClassDefs' used to keep track of inner classes that are defined in a module. This solution has the advantage of avoiding possible memory leaks that could result from not correctly cleaning the 'module2innerClassDefs' map.
Fixed ticket Re #1000678.

Ok, I merged manually.


search bar result not showing properly

Describe the bug
When I use the search bar the results are half-hidden to the left of the browser
Expected behaviour
I should be able to see all of the search results.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: Linux Mint
Browser Firefox
Version 69.0

Additional context
Add any other context about the problem here.

This but has already been resolved on the master branch and is just awaiting deployment to production.
I am closing this issue for now.


Add basic DML support

This adds basic DML support (but not performant). It currently requires a private local build to run, but for the sake of timelines and keeping PRs small, I'm making the PR right now.

Closing. Just noticed that the CUDA graph has been merged and will need to make it work with it (and fix merge conflicts)


Compiler attributes for improved security

A number of compiler attributes (e.g. alloc_size, malloc, access, nonnull) provide additional information to the compiler to allow it to (1) detect potentially undefined behaviour and (2) optimize code. These often end up in the win-win category where the compiler is able to improve performance as well as security.  I had documented a couple of them in an article in the past in a narrow scope, but there's scope for a more comprehensive document.  There are some caveats to their usage though, so it's likely not a matter of simply listing them.
Would a new document describing these attributes and how OSS developers could use them with best effect be a useful addition to this project?

The Linux kernel has set up a set of conventions to prevent buffer overwrites in many circumstances, that might be a useful source.
We currently have a project for compiler options, but that's a different thing.
The issue would be that some people would need to dedicate real time for this. If that can be done, I imagine it could be really helpful.

I don't want to promise (because this is largely going to be free time work for me and it's summer!) but I can take a stab at it at some point. I just wanted to put this issue out here to (1) get a sense for whether this would be interesting for this WG and (2) remind myself of it later whenever I have some free time to tackle it.

Fully supporting this! A new document seems to be a sensible approach in my opinion, although there's potentially some overlap with the existing guide too, e.g. this recent RFC for Clang proposes a combination of option flag + annotations.

@siddhesh - could you take a quick stab at a starting document? I think there's general agreement that this is useful, but probably needs to be a separate document. The big difference, as I understand it, is that this involves changes to the source code itself. Feel free to focus on just C (or just C++); I suspect that it may need to be more specific about the language.
I encourage looking at:

Some of the approaches and discussion of the Linux kernel (current and proposed)
GCC C extensions: https://gcc.gnu.org/onlinedocs/gcc/C-Extensions.html

I can't attend tomorrow's call due to a conflict, but I wanted to share that I've started working on this, here's a preview: https://github.com/siddhesh/wg-best-practices-os-developers/commit/fc1dce2742d0ff049a3e5b73817b96c3ab740acd
I'll send a PR once I do the due diligence, i.e. figure out minimum compiler versions, etc. and write some detail for each of those attributes with notes on their usage.  There may be more attributes to add in there, but that could be done incrementally.

Has this been addressed by the C/C++ Compiler Hardening options guide?    @gkunz @thomasnyman @david-a-wheeler


configmap injection seems to be generating a large number of events

investigate why configmap injection controller seems to be receiving an unlimited number of events.
when adding logs to the event filter:
	isAnnotatedConfigMap := predicate.Funcs{
		UpdateFunc: func(e event.UpdateEvent) bool {
			oldSecret, _ := e.MetaOld.GetAnnotations()[certAnnotationSecret]
			newSecret, _ := e.MetaNew.GetAnnotations()[certAnnotationSecret]
			log.V(1).Info("update func", "config map", e.MetaNew.GetName(), "annotation old", oldSecret, "annotation new", newSecret)
			return oldSecret != newSecret
		},
		CreateFunc: func(e event.CreateEvent) bool {
			_, ok1 := e.Meta.GetAnnotations()[certAnnotationSecret]
			log.V(1).Info("create func", "config map", e.Meta.GetName(), "has annotation", ok1)
			return ok1
		},
	}

the operator seems to be entering an infinite loop in which all it does is printing those statements and discard the event.

@raffaelespazzoli do you have any steps to replicate the issue?  I was unable to witness that behavior.
Steps to try to reproduce

create secret

kind: Secret
apiVersion: v1
metadata:
  name: test-inject-ca
  namespace: cert-utils-testing
data:
  ca.crt: >-
    entry here
  tls.crt: >-
    entry here
  tls.key: >-
    entry here
type: kubernetes.io/tls

create configmap with annotation to reference secret

kind: ConfigMap
apiVersion: v1
metadata:
  name: test-inject-ca-cm
  namespace: cert-utils-testing
  annotations:
    cert-utils-operator.redhat-cop.io/injectca-from-secret: cert-utils-testing/test-inject-ca

@mathianasj I didn't even have to create the secret. Did you add those debug statement? Do you see them in the logs? After opening this issue, I thought that perhaps there are some configmap in OCP 4.x that are constantly getting renewed and that could have explained the behavior I was seeing.

I am able to see the log message when running locally I did have to change one thing on my 4.3.13 cluster to get it to start.  The only time I get the log entry is when I change a configmap
I had to change https://github.com/redhat-cop/cert-utils-operator/blob/a68715b246f0a7eb26f98384fbbc02b16c66158d/cmd/manager/main.go#L24
crd "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
to
crd "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"

Let me try one more check

@raffaelespazzoli I see what you mean now, that looks like normal behavior because the ones that are flowing ar things like the configmap locks for operators.  Not sure if we can exclude certain configmaps from the watch?

@mathianasj can you upgrade the CRD to v1?
@mathianasj we can't exclude configmaps by namespace. not sure if there is pattern to see the configmaps used as leader election locks by operators. Any idea?

Since this is normal behavior due to increased logging I think we can close this.  Even if we add an exclude in the updatefunc to look for the annotation that defines the configmap as a lock it will still fire.


Angular 6 Update

From @mbeckenbach on June 22, 2018 12:57
Hi,
do you have plans to upgrade to angular 6 anytime soon?
The project file and some dependencies have changed there.
Best regards
Copied from original issue: dotnet/templating#1592

Support for Angular 6 has been added as part of https://github.com/aspnet/Templating/issues/541.
Closing this issue as a dupe.


[build.zig] emscripten build broken?

[x] I tested it on latest raylib version from master branch
[x] I checked there is no similar issue already reported
[ ] I checked the documentation on the wiki
[x] My code has no errors or misuse of raylib

Issue description
I think #3983  broke the Zig 0.12.0 build. If I pass --sysroot with an absolute path I now get
thread 637865 panic: sub_path is expected to be relative to the build root, but was this absolute path: '/home/lilith/Developer/emsdk/upstream/emscripten/cache/sysroot/include'. It is best avoid absolute paths, but if you must, it is supported by LazyPath.cwd_relative

If I pass --sysroot with relative paths
thread 637149 panic: reached unreachable code
/home/lilith/.zigup/cache/0.12.0/files/lib/std/debug.zig:403:14: 0x10b5bfd in assert (build)
    if (!ok) unreachable; // assertion failure
             ^
/home/lilith/.zigup/cache/0.12.0/files/lib/std/fs.zig:280:11: 0x10f0b3a in openDirAbsolute (build)
    assert(path.isAbsolute(absolute_path));
          ^

due to the std.fs.openAbsoluteDir verifying that a path is absolute or not. I think the changes in #3983 are well intended but are maybe too soon. Upgrading to Zig 0.13.0 when it is released will likely require more work than just changing one line...
I have a commit in a fork I am happy to PR that just reverts the change in #3983. I have tested it and it seems to work fine.
Environment
Cloned master branch and built with Zig version 0.12.0 with
zig build -Dtarget=wasm32-emscripten --sysroot "/home/lilith/Developer/emsdk/upstream/emscripten"

@fjebaker Thanks for reporting! Probably @CosmicBagel should comment on this issue.

I'm also seeing this issue in my project and agree with @fjebaker assessment of what's happening. The problem arises due to changes in the Zig master branch where the path to the emsdk headers must be a relative path, as mentioned here. Previously, in versions >= 0.12, this path was absolute.
This code in the src/build.zig is checking that the path is absolute:
var dir = std.fs.openDirAbsolute(cache_include, std.fs.Dir.OpenDirOptions{ .access_sub_paths = true, .no_follow = true }) catch @panic("No emscripten cache. Generate it!");
dir.close();

However, we need to pass a relative path to b.path(cache_include) to avoid the error sub_path is expected to be relative to the build root, but was this absolute path:
raylib.addIncludePath(b.path(cache_include));

Ideally, I'd like to be able to use raylib's master branch with Zig's master branch. To resolve this in a way that doesn't break existing code but enables new development also I propose something like this:
if (comptime builtin.zig_version.minor > 12) {
    var dir = std.fs.cwd().openDir(cache_include, std.fs.Dir.OpenDirOptions{ .access_sub_paths = true, .no_follow = true }) catch @panic("No emscripten cache. Generate it!");
    dir.close();
    raylib.addIncludePath(b.path(cache_include));
} else {
    var dir = std.fs.openDirAbsolute(cache_include, std.fs.Dir.OpenDirOptions{ .access_sub_paths = true, .no_follow = true }) catch @panic("No emscripten cache. Generate it!");
    dir.close();
    raylib.addIncludePath(.{ .path = cache_include });
}

I've made those changes in a fork here, happy to submit a pull request if others agree this change makes sense.

My apologies for breaking this for you, I should have tested this code path properly with 0.12.0 before submitting the PR, that's on me.
Indeed, zig is making a push to eliminate all absolute paths in the build system it seems https://github.com/ziglang/zig/issues/18450
Context: andrewrk is the BDFL for zig, so if he's pushing to have it happen, it will most likely happen.
I like the approach dylan proposed here, the only thing I would like to add is maybe a warning that gets printed when using zig 0.12.0 so that people will be aware of future breakage when upgrading to zig 0.13.0. I'm assuming people have little scripts and shell aliases, shell variables, ect, that point to this.

Ah dang, I was too slow

Thanks @dylanlangston  and @CosmicBagel, the changes merged work for me. Thanks for addressing this so quickly!

Context: andrewrk is the BDFL for zig, so if he's pushing to have it happen, it will most likely happen.

I absolutely love the direction Andrew is taking Zig in! Until the language has arrived at its stable API, these are just the little hacks we'll have to put up with (~;


Fix broken link to DeviceDescriptors.ts

Just fix a broken link in the documentation

@googlebot I signed it!


[DOC] classifiers missing bibtex reference

Describe the issue linked to the documentation

The following classifier miss the bibtex reference to the paper for the algorithm:

ColumnEnsembleClassifier in classification/compose/_column_ensemble.py

TimeSeriesForestClassifier in classification/compose/_ensemble.py

TemporalDictionaryEnsemble in classification/dictionary_based/_tde.py

ProximityTree in classification/distance_based/_proximity_forest.py

ShapeDTW in classification/distance_based/_shape_dtw.py

KNeighborsTimeSeriesClassifier in classification/distance_based/_time_series_neighbors.py

Suggest a potential alternative/fix
add back the bibtex reference

Do we want to add them in the BibTeX format or simply some other standard format?
Either way, we should add them under the References heading in the numpy docstring format.

hi,
ColumnEnsembleClassifier in classification/compose/_column_ensemble.py
KNeighborsTimeSeriesClassifier in classification/distance_based/_time_series_neighbors.py
thanks for this, please add bibtext for now, and maybe link under references?
TimeSeriesForestClassifier in classification/compose/_ensemble.py
https://www.sciencedirect.com/science/article/pii/S0020025513001473
TemporalDictionaryEnsemble in classification/dictionary_based/_tde.py
@inproceedings{middlehurst20temporal,
title={The Temporal Dictionary Ensemble {(TDE)} Classifier for Time Series Classification},
author={Middlehurst, Matthew and Large, James and Cawley, Gavin and Bagnall, Anthony},
booktitle={The European Conference on Machine Learning and Principles and Practice of Knowledge Discovery in Databases},
year={2020}
}
ProximityTree in classification/distance_based/_proximity_forest.py
same as proximity forest, just copy from there
ShapeDTW in classification/distance_based/_shape_dtw.py
https://www.sciencedirect.com/science/article/abs/pii/S0031320317303710?via%3Dihub

hi,
ColumnEnsembleClassifier in classification/compose/_column_ensemble.py
KNeighborsTimeSeriesClassifier in classification/distance_based/_time_series_neighbors.py
thanks for this, please add bibtext for now, and maybe link under references?
TimeSeriesForestClassifier in classification/compose/_ensemble.py
https://www.sciencedirect.com/science/article/pii/S0020025513001473
TemporalDictionaryEnsemble in classification/dictionary_based/_tde.py
@inproceedings{middlehurst20temporal,
title={The Temporal Dictionary Ensemble {(TDE)} Classifier for Time Series Classification},
author={Middlehurst, Matthew and Large, James and Cawley, Gavin and Bagnall, Anthony},
booktitle={The European Conference on Machine Learning and Principles and Practice of Knowledge Discovery in Databases},
year={2020}
}
ProximityTree in classification/distance_based/_proximity_forest.py
same as proximity forest, just copy from there
ShapeDTW in classification/distance_based/_shape_dtw.py
https://www.sciencedirect.com/science/article/abs/pii/S0031320317303710?via%3Dihub

so wt about ColumnEnsembleClassifier and KNeighborsTimeSeriesClassifier?

hi jason,  ColumnEnsembleClassifier and KNeighborsTimeSeriesClassifier are generic classifiers, they do not need a reference


apiMethods.update() should use HTTP method PUT instead of POST

Using POST results in getting an error message when trying to update a method.

merged - now close


Support server side rendering

Prevents use of window when it is not defined to allow server side rendering

What's the purpose of this? Why would you want to use a library for keyboard shortcuts on the server?

Not meant to use on the server, but if included on the server it shouldn't throw an error. When working with techs like react where your components also usually need to be rendered on the server side including keymaster dependency shouldn't throw an error. (of course I don't call it unless it's on the client side) at least this is my use case

Please merge this.
If it's still unclear why, I'll try to explain.
React supports applications that can run both on the server and the client with the same codebase. For example the first load might be server-rendered to improve the load time but then the client takes over for real-time updates and similar.
It isn't the keyboard events themselves that must work on the server (which they of course can't) but it must not crash so that the rest of the application can be rendered on the server.

Would really really love to see this merged!

is there a chance that this PR will be merged?

Same needing here – using with next.js.

Alternative library on modern js supports SSR https://github.com/elv1n/keybuddy

I've merged this here
As I use this library and it hasn't been touched in two years, and has many prs and issues, I'll be maintaining it in my fork.

I've merged this here
As I use this library and it hasn't been touched in two years, and has many prs and issues, I'll be maintaining it in my fork.


CircleCI: Rerun failing tests

If an indivdual test fails, rerun it up to 2 times. If it passes on a
subsequent run, it will get reported as "flaky" but won't fail the build.

:+1:


Custom Persistence with Sideposting?

I've read over the examples for both custom persistence and sideposting. It seems like to add a service call in the mix, you would define a create(attributes) method in the resource. If you're sideposting, I suppose you'd define multiple create(attributes) on the various resources.
Assuming that's all correct, what if your service object coordinates multiple models being posted together, none of which can be saved until the service object touches all of them?
A more concrete example, let's say you have an Order and an Address and need to geocode to find the timezone, then apply that timezone to a time on the order:
# app/services/some_service.rb
class SomeService
  def initialize(order, address)
    # assigning variables, etc...
  end

  def create
    address.geocode
    order.some_time = time_in_new_timezone(order.some_time_without_zone, address.timezone)
    address.save && order.save
  end

  private

  def time_in_new_timezone(time, zone)
    # some logic
  end
end

# app/resources/order_resource.rb
class OrderResource < ApplicationResource
  type :orders
  model Order

  def create(attributes)
    order = Order.new(attributes)
    # address = ??? (no access to the params for address here)
    SomeService.new(order, address).create
    order
  end
end

I know there are other ways to approach this particular example, but it's just a simple example representing a much more complex service.

Hi Derek - great question. I think I have an answer for you, the documentation just hasn't caught up yet. In your example, you could do something like this:
class AddressResource < JsonapiCompliable::Resource
  # ... code ...
  def create(attributes, parent) # note the optional second arg here
    address = Address.new(attributes)
    if parent.is_a?(Order)
      address.geocode
        .time_in_new_timezone(parent.some_time, address.timezone)
    end
    address.save
    address
  end
end

Note the check on parent here - since multiple objects could (in theory) sidepost an address, we should verify it's an Order doing the sideposting.
Another option would be the after_save hooks within the parent. I haven't written a how-to yet, but you can see examples in the tests. One way:
# OrderResource
belongs_to :address,
  foreign_key: :order_id,
  scope: -> { Address.all },
  resource: AddressResource do
    after_save only: [:create, update] do |order, addresses|
      # addresses is always an array regardless of has-many/belongs-to
      address = addresses.first
      address.geocode(order.some_time, address.timezone)
      address.save
    end

For both of these examples, you'll already be within a transaction. Make sure to define #transaction in your adapter if not using activerecord.
Does either of those work for you?

And by the way, as you noted earlier - another option is to simply post a CompoundOrder object, rather than sideposting the address. In this case you'd have a CompoundOrder resource and the attributes could be whatever structure you want, and you could do whatever you want within the relevant resource methods. I think this is less than ideal, but it's what a lot of RESTful folks did/do before jsonapi introduced sideposting, so no worse than the status quo as a last resort.

Thanks for the quick reply!  Having access to the parent is definitely helpful. I want to avoid callbacks as much as possible; it's gotten us into a lot of trouble in our past API.
I am thinking at this point the compound object would be best. Ideally, I'd like to define a central place where things are happening to an order, so it's easy to see what effects are taking place.
Another option, for future consideration, might be the ability to specify which resource handles the create/update for a relationship. Something like:
# app/resources/order_resource.rb
class OrderResource < ApplicationResource
  type :orders
  model Order

  has_one :address,
          resource: AddressResource,
          persisted_by: :self, # something to specify OrderResource is handling address params
          scope: -> { Address.all },
          foreign_key: :address_id
end

This way, AddressResource can operate as normal in any situation and not know about the custom requirements for OrderResource, while OrderResource is smart enough to handle address params in a certain way. What do you think?

I'm definitely open to more options/injectables around persistence. That said, I'm not sure I agree with that abstraction - I like the premise of an OrderResource persists an Order, an AddressResource persists an Address, and a CompoundOrderResource is persisted by a CompoundOrderService that coordinates multiple resources. Cross-pollinating these sounds like we'd end up with some confusing "who does what where" issues, and some "unexpected side-effect" issues similar to what you've seen before with callbacks.
I do think there is probably something to the idea of a JsonapiCompliable::CompoundResource concept, but I'd like to hear more about these scenarios and problems with the existing paradigm before digging too deep. Maybe you could start down the CompoundOrderResource route and let me know any problems you run into?


support async await

Is there any work being done on upgrading lapin-futures to use std::future?

Yep: don't use lapin-futures, it's futures-0.1 only.
Lapin now has a futures feature for futures-0.3 and async await, see https://github.com/sozu-proxy/lapin/blob/master/examples/pubsub_futures.rs

Ah, I see. Awesome, thanks!

I see it requires futures feature. Suppose we can document it in README?

Sure !
On Tue 19 Nov 2019 at 19:01, jerry73204<EMAIL_ADDRESS>wrote:

I see it requires futures feature. Suppose we can document it in README?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sozu-proxy/lapin/issues/217?email_source=notifications&email_token=AABWNXTL4ZW3QZBUSKRZYSLQUQSYJA5CNFSM4JL2QAG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEPEJXI#issuecomment-555631837,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABWNXXCCWAWITCC2EHCX6DQUQSYJANCNFSM4JL2QAGQ
.

I'll gladly accept a pull request documenting that :)

@Keruspe Since async await is stable now, any thoughts on setting the futures feature on by default?

Will do in 0.29


Fixed changelist filter taking up too much space with long strings

Let me know if this needs a ticket.
If you have a long string that can be filtered without breaking characters it really messes up the page (not shown: horizontal scrollbar until you get to the end of the string):

With this fix:

Could also set overflow-x: hidden but didn't want to hide part of the string.

@knyghty Thanks :+1: Can you reproduce this issue on the main branch? This should be already fixed by 361bb8f786f112ee275be136795c0b1ecefff928 :thinking:

Oops, I missed that, change wasn't where I expected, ignore me 😄


add waiting button to team add

@keybase/react-hackers This screen needs a waiting button badly.

It just goes off the screen when the RPC completes, just needs to spin until it unmounts.

Guess not! Merging over that circle failure.


Slices: Faster SequenceEqual implemented in IL

It is similar to IndexOf impl. The same benefits - shorter code, tighter loop.
Assembly for the long and char instantiations.
; Assembly listing for method System.SpanExtensions:SequenceEqual(struct,struct):bool
; Lcl frame size = 0
       8B4110               mov      eax, dword ptr [rcx+16]
       3B4210               cmp      eax, dword ptr [rdx+16]
       7539                 jne      SHORT G_M39316_IG06
       8B4110               mov      eax, dword ptr [rcx+16]
       4863C0               movsxd   eax, eax
       4885C0               test     rax, rax
       7428                 je       SHORT G_M39316_IG04
       4C8B01               mov      r8, gword ptr [rcx]
       488B4908             mov      rcx, qword ptr [rcx+8]
       4C03C1               add      r8, rcx
       488B0A               mov      rcx, gword ptr [rdx]
       488B5208             mov      rdx, qword ptr [rdx+8]
       4803CA               add      rcx, rdx
       33D2                 xor      rdx, rdx
G_M39316_IG03:
       4C8B0CD1             mov      r9, qword ptr [rcx+8*rdx]
       4D390CD0             cmp      qword ptr [r8+8*rdx], r9
       750E                 jne      SHORT G_M39316_IG06
       48FFC2               inc      rdx
       483BD0               cmp      rdx, rax
       7CEE                 jl       SHORT G_M39316_IG03
G_M39316_IG04:
       B801000000           mov      eax, 1
       C3                   ret
G_M39316_IG06:
       33C0                 xor      eax, eax
       C3                   ret

; Total bytes of code 68, prolog size 0 for method System.SpanExtensions:SequenceEqual(struct,struct):bool
; ============================================================

; Assembly listing for method System.SpanExtensions:SequenceEqual(struct,struct):bool
; Lcl frame size = 0
       8B4110               mov      eax, dword ptr [rcx+16]
       3B4210               cmp      eax, dword ptr [rdx+16]
       753E                 jne      SHORT G_M17275_IG06
       8B4110               mov      eax, dword ptr [rcx+16]
       4863C0               movsxd   eax, eax
       4885C0               test     rax, rax
       742D                 je       SHORT G_M17275_IG04
       4C8B01               mov      r8, gword ptr [rcx]
       488B4908             mov      rcx, qword ptr [rcx+8]
       4C03C1               add      r8, rcx
       488B0A               mov      rcx, gword ptr [rdx]
       488B5208             mov      rdx, qword ptr [rdx+8]
       4803CA               add      rcx, rdx
       33D2                 xor      rdx, rdx
G_M17275_IG03:
       440FB70C51           movzx    r9, word  ptr [rcx+2*rdx]
       450FB71450           movzx    r10, word  ptr [r8+2*rdx]
       453BD1               cmp      r10d, r9d
       750E                 jne      SHORT G_M17275_IG06
       48FFC2               inc      rdx
       483BD0               cmp      rdx, rax
       7CE9                 jl       SHORT G_M17275_IG03
G_M17275_IG04:
       B801000000           mov      eax, 1
       C3                   ret
G_M17275_IG06:
       33C0                 xor      eax, eax
       C3                   ret

; Total bytes of code 73, prolog size 0 for method System.SpanExtensions:SequenceEqual(struct,struct):bool

The results of the benchmark for lengths of 1, 2, 4, 8, 16, 32, 64, 128, 512, 1024 and types byte, char and int. For comparison I added string.Equals and looping through two char arrays.
Meaning of the labels for chars:
char - calls to SequenceEquals specialized for Span[char]
char array - loop through char arrays
char gen - current generic SequenceEquals[T]
char gen 2 - current SequenceEquals[T] but with Span params copied to local vars (JIT enregisters them)
char gen new - the new SequenceEquals[T] implemented in IL
I ran the benchmark on my ultrabook  - Windows 10 and NET 4.6 (BenchmarkDotNet doesn't yet support .NET Core).
BenchmarkDotNet-Dev=v<IP_ADDRESS>+
OS=Microsoft Windows NT 6.2.9200.0
Processor=Intel(R) Core(TM) i7-3537U CPU @ 2.00GHz, ProcessorCount=4
HostCLR=MS.NET 4.0.30319.42000, Arch=64-bit  [RyuJIT]
Type=BenchmarkSeqEqual  Mode=Throughput  Jit=HostJit  .NET=HostFramework  toolchain=Classic  Runtime=Clr  Warmup=2  Target=3

Hi @omariom, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@omariom, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

@mikedn @VSadov  do you see anything suspicious?

string.Equals beats them all, but that's because it unrolls the loop and reads in longs.

Code looks fine but I wonder where the whole IL thing goes. Initially IL was only when strictly needed but now it looks like half of this library may end up being rewritten in IL. It's perhaps unfortunate given that this is just an workaround for C# language and JIT compiler limitations.

@mikedn
I am concerned too. But for while, until proper JIT support, IL is Ok.
People will be comparing Slices' perf with arrays and strings and a bad name can stay longer than it  will deserve to.
And I think better shape increases its chance to get into CoreFx even without favors from JIT.

I wonder where the whole IL thing goes

To make things worse I'm thinking about implementing a non-pinning version of MemoryUtils.MemCmp unrolling the loop into 4 non-aligned long reads :)
Yeah, baby Slice, we will beat the shit out of string.Equals and teach it to respect small things that can't yet enjoy language and JIT support :rage3:
If it is too much of IL.. well, it will have been a good exercise for me )

I will try to replace a loop in the  specialized overloads (byte, char, int etc.) of   SequenceEqual with a call to  the new generic one and see if it will make them faster.

Is the benefit mostly from omitting the range check?
I wonder it it makes sense to implement overloads for primitives like  byte,char,int etc by just deferring to optimized byte-wise compare (do we have such thing already? like BlockCompare?) .
For general T, it may be a diminishing return thing to create and maintain custom IL implementation. Those scenarios may be not as common and are likely be dominated by things other than a range check.

Is the benefit mostly from omitting the range check?
No,  all the overloads already use  GetItemWithoutBoundariesCheck. I think it is number of instructions.

I wonder it it makes sense to implement overloads for primitives like byte,char,int etc by just deferring to optimized byte-wise compare (do we have such thing already? like BlockCompare?) .

Those overloads already do that if the length >= 512 (256 for int and long). It is pinning and on shorter distances slower than the loop.
Some improvements can be gained by copying span parameters to locals vars, using the version of the indexer  fixed in another PR  and passing params  to MemCmp by ref.
I will try to squeeze everything from IL and non IL approaches and benchmark both.
Speaking of the burden of maintaining IL, I started thinking that Slices is a fairly low level thing,  and as there are parts of CLR  for perf sake written and maintained in Assembly, it might be ok for Slices to be implemented in  IL for the same reasons.

No, all the overloads already use GetItemWithoutBoundariesCheck. I think it is the number of instructions.

For reference here's the loop assembly code generated for the current implementation (slightly adjusted for clarity):
00007FFCF02F0E79  mov         rax,qword ptr [rcx]
00007FFCF02F0E7C  mov         r9,qword ptr [rcx+8]
00007FFCF02F0E80  add         rax,r9
00007FFCF02F0E83  mov         r9d,r8d
00007FFCF02F0E86  mov         rax,qword ptr [rax+r9*8]
00007FFCF02F0E8A  mov         r9,qword ptr [rdx]
00007FFCF02F0E8D  mov         r10,qword ptr [rdx+8]
00007FFCF02F0E91  add         r9,r10
00007FFCF02F0E94  mov         r10d,r8d
00007FFCF02F0E97  cmp         qword ptr [r9+r10*8],rax
00007FFCF02F0E9B  jne          00007FFCF02F0EA0
00007FFCF02F0EA0  inc         r8d
00007FFCF02F0EA3  cmp         r8d,dword ptr [rcx+10h]
00007FFCF02F0EA7  jl          00007FFCF02F0E79

There are portions that are loop invariant but the JIT isn't that smart to hoist them so the resulting code is quite large.

The following generates slightly better assembly code:
var fobj = first._object;
var fofs = first._offset;
var sobj = second._object;
var sofs = second._offset;
for (int i = 0; i < first.Length; i++) {
    if (PtrUtils.Get<long>(fobj, fofs, i) != PtrUtils.Get<long>(sobj, sofs, i)) {
        return false;
    }
}

The introduced local variables are enregistered so a lot of memory loads are saved. But the object + offset addition from PtrUtils.Get is still not hoisted. I think that's actually expected since a managed pointer is involved and that requires GC tracking.

@mikedn
The generated code is the same if we just copy the params to locals and use them instead.
I don't get why JIT can't enregister struct params which are passed by value.

Are you saying that my version and a version that copies params to locals generate the same code? Could be, I haven't checked. But I suppose that the object + offset problem is still present, right?

Are you saying that my version and a version that copies params to locals generate the same code?

Yes, JIT it handles it  well.

But I suppose that the object + offset problem is still present, right?

Yes, it is still there. And the size of the method is about 140,  the frame same is about 40. The IL version is about 70 and zero frame.
Anyway, I will battle test both. Thought I think the difference will be bigger on weaker CPUs  like Atoms.

Yes, JIT it handles it well.

Makes sense. Value types are actually passed by ref and that prevents various optimizations. But when value types stored in local variables the JIT can sometimes replace them with individual scalar variables and then optimization start working.

Value types are actually passed by ref and that prevents various optimizations.

At the CLR level it is guaranteed that the caller passes refs to copies which are invisible to anyone except the callee, isn't  it? Then why JIT can't enregister them? Or I miss something?

At the CLR level it is guaranteed that the caller passes refs to copies which are invisible to anyone except the callee, isn't it?

Well, yes, in the current implementation a ref to a temporary copy is passed. That's required to preserve the by value semantics of the code.

Then why JIT can't enregister them?

Eh, the usual JIT limitations, warts and all. It has a history of problems with value types. Funny thing that if span was a reference type then this would have likely worked.

@mikedn
I will create an issue for that.
Interesting that readonly locals and params will let the caller to avoid making copies which are currently created  even when the calls are inlined.

There are better ways to avoid making copies that do not require language support. It's really up to the JIT to make this scenario better, it's not the job of the language to work around JIT limitations.

Can we use SIMD registers for this? With something like casting a pointer to a Vector<long> (type doesn't matter), you could then compare 16 / 32 bytes at a time. For the remaining amount of buffer you can fall back to the current test.

@mburbea

Can we use SIMD registers for this?

I know little about Vector and how to use it :confused:

@dotnet-bot test this please

@dotnet-bot test this please

@dotnet-bot test this please

@KrzysztofCwalina
This PR is not done yet. I am going to route non generic SequenceEquals' to IL version so that they benefit from the change too.

This is the microbenchmarking results  for slices of bytes.

Now it is ready.

@dotnet-bot test this please


Error: spawn npm ENOENT

Getting an error when trying to run npm-install-changed.
Output from command:
Running npm install...
events.js:141
      throw er; // Unhandled 'error' event
      ^

Error: spawn npm ENOENT
    at exports._errnoException (util.js:870:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
    at onErrorNT (internal/child_process.js:344:16)
    at nextTickCallbackWith2Args (node.js:442:9)
    at process._tickCallback (node.js:356:17)

npm install on its own works properly.
Some stats: Windows 10, node version 4.4.3.
Any ideas?

I never tested this on Windows but I could issue a fix if you help me. Probably because npm binary has the .exe extension?

Sure thing, I'll give it a shot. I'll try to take a look at it tomorrow and let you know.

Hey I issued a PR for the fix. It looks like you were right, it was having trouble spawning a process because of the OS being Windows. I added the cross-spawn module and let that take care of spawning if that's cool with you. PR here: https://github.com/oNaiPs/npm-install-changed/pull/2

Thanks @MrDoctorJ. I merged the issue. Will submit the update to npm now.


Provide ES translation

This is the ES translation for Welcome to the Moon Solo Helper.

thanks for the contribution! - released as v1.0.5


hardware timer wont restart with no auto_reload (IDFGH-6435)

Hi,
i am having problems with restarting hardware timer which is init with auto_reload=false. No matter what i am trying to do in ISR callback, and/or when i am trying to call timer_start(); again, the timer wont fire anymore.
My tests are performed https://github.com/espressif/esp-idf/tree/master/examples/peripherals/timer_group on master branch and esp32 and S3 boards.
With auto_reload = true example code works fine.
Its not entirely, true. The timer will reload and fire one more time with auto_reload=false, when i set (only 1 timer is running in this example):
    if (!info->auto_reload) {
        timer_counter_value += 130; // about 130 ticks or less
        timer_group_set_alarm_value_in_isr(info->timer_group, info->timer_idx, timer_counter_value);

        timer_group_clr_intr_status_in_isr(info->timer_group, info->timer_idx);
        timer_group_enable_alarm_in_isr(info->timer_group, info->timer_idx);
        ets_printf("%lld\n", timer_counter_value);
    }

logs:
15000145
15000304
Timer Group without auto reload
Group[0], timer[0] alarm event
------- EVENT TIME --------
Counter: 0x0000000000e4e1cf
Time   : 3.00000300 s
-------- TASK TIME --------
Counter: 0x0000000000e557e5
Time   : 3.00604900 s
Timer Group without auto reload
Group[0], timer[0] alarm event
------- EVENT TIME --------
Counter: 0x0000000000e4e26e
Time   : 3.00003480 s
-------- TASK TIME --------
Counter: 0x0000000000e6df2e
Time   : 3.02608280 s

with 100 ticks it finally works:
15000115
15000274
15000415
15000556
15000696
15000837
15000978
...
eventually crash due to ets_printf() in ISR

Thanks

Even this code borrowed from unity test is not letting to fire timer more then 1 time:
static bool test_timer_group_isr_cb(void *arg)
{
    bool is_awoken = false;
    timer_info_t _info = {
        .timer_group = TIMER_GROUP_0,
        .timer_idx = TIMER_0
    };
    timer_info_t *info = &_info;
    const timer_group_t timer_group = info->timer_group;
    const timer_idx_t timer_idx = info->timer_idx;
    uint64_t timer_val;
    double time;
    uint64_t alarm_value;

    if (timer_group_get_auto_reload_in_isr(timer_group, timer_idx)) { // For autoreload mode, the counter value has been cleared
        timer_group_clr_intr_status_in_isr(timer_group, timer_idx);
        esp_rom_printf("1. This is TG%d timer[%d] reload-timer alarm!\n", timer_group, timer_idx);
        timer_get_counter_value(timer_group, timer_idx, &timer_val);
        timer_get_counter_time_sec(timer_group, timer_idx, &time);
    } else {
        timer_group_clr_intr_status_in_isr(timer_group, timer_idx);
        esp_rom_printf("2. This is TG%d timer[%d] count-up-timer alarm!\n", timer_group, timer_idx);
        timer_get_counter_value(timer_group, timer_idx, &timer_val);
        timer_get_counter_time_sec(timer_group, timer_idx, &time);
        timer_get_alarm_value(timer_group, timer_idx, &alarm_value);
        timer_set_counter_value(timer_group, timer_idx, 0);
    }

    return is_awoken;
}

2. This is TG0 timer[0] count-up-timer alarm!

Yes, it's broken by a wrong fix of https://github.com/espressif/esp-idf/issues/7001
So the alarm is disabled by accident in https://github.com/espressif/esp-idf/commit/9a14cf083f2d7b4dc9841ad7d7bcb11eec1a8594
Will have another fix for that.

It is fixed, thanks
I have one more question:
i found that accurate time is when i set alarm with this value:
timer_group_set_alarm_value_in_isr(group, timer_id, seconds * TIMER_BASE_CLK / TIMER_DIVIDER  - 276 / config.divider);

Any thoughts?

v4.3 also needs this fix.

v4.3 also needs this fix.

@suda-morris This is still broken in v4.3.


Js Engine Android Build

What needs to be documented?
I was about to download Js Engine Android Build again but I should keep it instead of uninstalling it again until I noticed that the Android, Linux, Mac, and Windows downloads had expired, I creating my Dave and Bambi chart and I need the Android Build so I can test it again if I can tell if it's good. The Lastest Psych Engine is a Android Build 0.7.1 and it lags with botplay so I need no botplay lag from your engine.

Wait 4 days.


wrong week  day

hello
moment("2020/03/21", 'YYYY/MM/DD')
.format('dddd');
return  friday    جمعه
saturday  شنبه  correct
Just the same day
thanks

Hello,
This is related to summer time. When you don't include time in your input string, it is assumed to be zero, midnight. On March 21, Iran moved to summer time, and as a result, that hour doesn't exists, and it is assumed to be on the previous day:
moment("2020/03/21 00:00:00+0330", 'YYYY/MM/DD hh:mm:ssZ').format('dddd') // Saturday

moment("2020/03/21 00:00:00+0430", 'YYYY/MM/DD hh:mm:ssZ').format('dddd') // Friday

You want the first result, but you get the second. To fix the problem on every day, including the border days where timezone changes occur, add a few hours to your input string and parse format:
moment("2020/03/21 12:00:00+0430", 'YYYY/MM/DD hh:mm:ssZ').format('dddd') // Saturday

On Farvardin 3, 1399 AP, 9:41 AM +0430, jafarpishdadi<EMAIL_ADDRESS>wrote:

hello
moment("2020/03/21", 'YYYY/MM/DD')
.format('dddd');
return friday جمعه
Just the same day
thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Building with docs without Git results in build failure

Checklist

[x] I have followed every step on the compiling wiki page and
installed all necessary dependencies.
[x] My problem is not described on the known issues page
[x] I have searched for other open and closed issues that
may have already reported this problem.
[x] I was able to reproduce this build issue in a clean build

Build Process
How did you build polybar?

[x] From a release archive (Which version?)
[ ] By cloning this repository (What is the output of git describe --tags?)
[ ] Some other way (How?)

Version 3.5.2.

Built through Gentoo's package manager, but in general this issue should be reproduced with -DBUILD_DOC=yes.
Build Log

build.log
Environment:

Distro (with Version): Gentoo

Additional context

No Git installed, unecessary dependency aside from this issue.

Fixed in #2311. I will release 3.5.3 in a week or so.


Update fixtures script to load data agreement and revisions to database

[ ] GovStack Gherkin test failed since data agreement with id 1 is not present in database.

So what is the solution we intend to provide?

So what is the solution we intend to provide?

Script to load the database.


DeltaLm：does deltalm has Target language token like m2m100 to indicate the target language？

does deltalm has Target language token like m2m100 to indicate the target language？I didn't find such token in dictionary of deltalm-base

There is no language token for pre-training. We add the language tokens to the dictionary before fine-tuning.


refactor: Remove direct copy of nlohmann/json

In this way we can make the porject smaller and easier to update

This seems to break the build. Any idea why that is? How do you pull the submodule?

We talked about that and it this seems like we'd rather keep a copy of the repo rather than use git to pull it. This way a clone of our repo is always self contained and can be directly built, even in private networks without access to internet, as some of our CI is.

got it thanks!!


iFrame drag and drop

Was just curious if somebody tried it on a cross-frame and their implementation? Just like how divshot/webflow functions.

I do not think anybody using this lib with iframes, closing this as it is a generic one.


How to cross compile to riscv64

Hi Everyone.
I want to build iwasm for riscv64 on x86_64 ubuntu(docker)
But it doesn't works.
I referred to the following link.  https://github.com/bytecodealliance/wasm-micro-runtime/issues/1830
I installed RISC-V GNU Compiler Toolchain  and  export PATH=/opt/riscv/bin:$PATH, and then added lines to CMakeLists.txt
+SET(CMAKE_C_COMPILER riscv64-unknown-linux-gnu-gcc)
+SET(CMAKE_AR riscv64-unknown-linux-gnu-ar)
+SET(CMAKE_RANLIB riscv64-unknown-linux-gnu-ranlib)
+SET(WAMR_BUILD_TARGET "RISCV64")

and i tried
cmake ..
make

But it doesn't build..
/root/wasm-micro-runtime-main/core/iwasm/common/arch/invokeNative_riscv.S:144:9: error: invalid instruction mnemonic 'mv'
        mv sp, fp
        ^~
/root/wasm-micro-runtime-main/core/iwasm/common/arch/invokeNative_riscv.S:145:22: error: expected register here
        ld fp, 0 * 8(sp)
                     ^
/root/wasm-micro-runtime-main/core/iwasm/common/arch/invokeNative_riscv.S:146:22: error: expected register here
        ld ra, 1 * 8(sp)
                     ^
/root/wasm-micro-runtime-main/core/iwasm/common/arch/invokeNative_riscv.S:147:9: error: invalid instruction mnemonic 'addi'
        addi sp, sp, 2 * 8
        ^~~~
/root/wasm-micro-runtime-main/core/iwasm/common/arch/invokeNative_riscv.S:148:9: error: invalid instruction mnemonic 'jr'
        jr ra
        ^~
make[2]: *** [CMakeFiles/vmlib.dir/build.make:621: CMakeFiles/vmlib.dir/root/wasm-micro-runtime-main/core/iwasm/common/arch/invokeNative_riscv.S.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:87: CMakeFiles/vmlib.dir/all] Error 2
make: *** [Makefile:136: all] Error 2`

Plesea anyone helpme!

Hello
If you applied the version, the path, and all that
Delete CmakeCache.txt in the cmake path and proceed with the cmake again
thank you

OMG
I installed riscv64-glibc-ubuntu-20.04-nightly-2022.12.17-nightly.tar.gz](https://github.com/riscv-collab/riscv-gnu-toolchain/releases/download/2022.12.17/riscv64-glibc-ubuntu-20.04-nightly-2022.12.17-nightly.tar.gz
and Delete CmakeCahec.tx and then
cmake ..
make

it work's!
Thank you!!!


Framework support for checkerboardOffscreenLayers

See https://github.com/flutter/flutter/issues/9473

@chinmaygarde

Is this testable?


Add nri-plugins operator

Move the operator code from:

https://github.com/containers/nri-plugins-operator
https://github.com/containers/nri-plugins-operator/pull/3
https://github.com/containers/nri-plugins-operator/pull/4

Also, refactor the nri-plugins so that we can reuse the already existing CRD yamls instead of duplicating them.
There is one thing left to be added, which is image build refactoring. I will add it soon, but the rest is ready for review.

A general comment about the PR... Although this is definitely not a showstopper/biggie, but since we're lifting existing code over from another repository, I wonder if the current PR commit history makes sense for each commit, or if it could be squashed to fewer ones. For instance, cannot we create the operator directly in the final location instead of first adding it in one location then moving it to another ? Also, it looks to me like the first two commits could as well be squashed together.
If I try to take a milky-way perspective at the full set of additions in this PR, it seems to me that a more logical set of commits would be:

add operator (commits 1, 2, 5, 6 squashed)
add operator bundle (commits 4, 7 squashed)
add operator scorecard testing  (commit 3)
add/link in documentation for the operator (commit 8)

First commit message has an outdated reference to PluginConfig which I think should be NriPluginDeployment instead.

@fmuyassarov Here is a rewritten history which is not squashed to a single commit and is more along the lines what I've been thinking of: https://github.com/klihub/nri-plugins/tree/devel/plugins-operator

@klihub @marquiz @askervin @kad PTAL. It is ready now.

@askervin @marquiz @kad PTAL.

I don't have any concerns about this PR, except deletion of files under docs/deployment/. Is that expected?

We are not deleting docs but rather re-structuring them to accommodate the operator document. You can also see from the changes lines at the top of the PR.


using "gather_for_metrics"

System Info
- `Accelerate` version: 0.15.0.dev0
- Platform: Linux-3.10.0-1160.71.1.el7.x86_64-x86_64-with-glibc2.10
- Python version: 3.8.5
- Numpy version: 1.23.4
- PyTorch version (GPU?): 1.13.0 (True)
- `Accelerate` default config:
        - compute_environment: LOCAL_MACHINE
        - distributed_type: MULTI_GPU
        - mixed_precision: fp16
        - use_cpu: False
        - dynamo_backend: NO
        - num_processes: 2
        - machine_rank: 0
        - num_machines: 1
        - gpu_ids: 0,1
        - main_process_ip: None
        - main_process_port: None
        - rdzv_backend: static
        - same_network: True
        - main_training_function: main
        - deepspeed_config: {}
        - fsdp_config: {}
        - megatron_lm_config: {}
        - downcast_bf16: no
        - tpu_name: None
        - tpu_zone: None
        - command_file: None
        - commands: None

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
Hello,
I am trying to employ the gather_for_metrics function to do evaluation on all the devset.
I am following the example in this link:
https://github.com/huggingface/accelerate/blob/main/examples/by_feature/automatic_gradient_accumulation.py#L196-L204
The only difference is the fact that I do not use metric as I am using my own metric.
In stead, I opt for aggregating all the scores and then calculating the final score.
This is a snippet of my code with the relevant part:
        generated_outputs, precision_scores, recall_scores, final_rewards = [], [], [], []
        for i, (input_ids, attention_mask, global_attention_mask, jsonl_ids) in enumerate(tqdm(self.val_dataloader)):
            with torch.no_grad():
                input_ids, attention_mask, global_attention_mask = self.add_control_code(input_ids, attention_mask, global_attention_mask)
                rollouts = self.policy.sample(input_ids=input_ids, attention_mask=attention_mask, top_p=self.params.top_p, global_attention_mask=global_attention_mask)

                forward_inputs = {'input_texts_input_ids': rollouts['input_doc/input_ids'][:, 1:],
                                  'input_texts_attention_mask': rollouts['input_doc/mask'][:, 1:],
                                  'input_texts_global_attention_mask': rollouts['input_doc/global_mask'][:, 1:],
                                  'generated_reductions_input_ids': rollouts['output_reduction/input_ids'],
                                  'generated_reductions_attention_mask': rollouts['output_reduction/mask']}
                ref_logprobs = self.ref_policy.forward_pass(**forward_inputs)['generated_reduction/log_prob']

                input_doc = [self.policy.tokenizer.decode(p, clean_up_tokenization_spaces=True) for p in rollouts['input_doc/input_ids'][:, 1:]]

                output_reduction = rollouts['output_reduction/text']
                score = self.score_model.get_reward(input_docs=input_doc, jsonl_ids=jsonl_ids, output_reductions=output_reduction, epoch=f'step{step}_eval{i}', jsonl_path=self.params.dataset_val)
                precision_score, recall_score, final_reward = score["precision_score"], score["recall_score"], score["final_reward"]

                output_reduction, precision_score, recall_score, final_reward  = self.accelerator.gather_for_metrics((output_reduction, precision_score, recall_score, final_reward))

                generated_outputs.extend(rollouts['output_reduction/text'])
                precision_scores.extend(precision_score)
                recall_scores.extend(recall_score)
                final_rewards.extend(final_reward)

The problem is that in the end, generated_outputs, precision_scores, recall_scores, final_rewards are all empty lists.
What am I doing wrong?
And a followup question - how do I reset the aggregation after calculating the final score for the current epoch? (As in the example, calling metric.compute() resets the aggregation, but in my case I do not use metric).
Thanks!
Expected behavior
having all the scores and generated outputs in `generated_outputs`, `precision_scores`, `recall_scores`, `final_rewards`

cc @muellerzr

@lovodkin93 a few questions on this:

Are score["precision_score"], score["recall_score"], score["final_reward"] all torch.tensor's?
Does the code work on a single GPU?
Is any part of your previous code as it goes through and back expected to have all of the actual predictions rather than the ones from a single worker/node?

Thanks!

@lovodkin93 From the documentation, it seems that gather_for_metrics() only works on tensors and not on other types.
Let me know if you have found a way to do this for variables with other types which may be part of the batch.
https://huggingface.co/docs/accelerate/v0.19.0/en/package_reference/accelerator#accelerate.Accelerator.gather_for_metrics


Firefox directory under default/prefs ?

what did you mean by going into your firefox directory? i tried going into $HOME/.mozilla/firefox/###.default-default but i don't see any default or prefs directory there.
can you please help me find what should i do to replicate Newtab as startpage as you did?

I'm assuming that you are running Linux, you can find where firefox is installed via whereis firefox in terminal. Usually, if you installed it directly from Mozilla the defaults folder should be in usr/lib/firefox

I'm assuming that you are running Linux, you can find where firefox is installed via whereis firefox in terminal. Usually, if you installed it directly from Mozilla the defaults folder should be in usr/lib/firefox

oh now i figured out. thank you!  i fixed


fix some syntax error in monitor.bt

here we can see some syntax error when run bpftrace monitor.bt

and i find some usage about this:
https://github.com/iovisor/bpftrace/blob/289f0c7e028b2317aeddbb0228d542f6250fe08c/docs/reference_guide.md?plain=1#L781-L793
maybe else if is not supported.

This works on alinux3 5.10.134 & bpftrace-0.16.0 , what version are you using ?

linux version:  Linux version 5.10.134-14.an8.x86_64
bpftrace version:  bpftrace v0.9.2
i guessed that too, probably due to a low version of bpftrace.  the syntax of if is also supported in lower versions of bpftrace, is it ok for us to implement this part of the logic with if? The meaning is the same, so that no one will encounter the same problem later.


Unusual _ for 'from' parameter

Hello, you use 'from_' in your documentation for some functions, but I believe it should be 'from':
resp = client.get_prices_eod('AAL.LSE', period='d', order='a', from_='2017-01-05')
Not only this one, there are more of them. Thank you.

Hi @deios0, thank you for you submitting your feedback. I have chosen the from_ syntaxis rather than the from because Python doesn't permit using the former as a valid argument or parameter for a method (At least Anaconda doesn't let you). So to address that issue, I have created a special class that transforms the from_ into from for a valid API request. You can find the details of that transformation inside the request_handler_class.
In short: The underscore is intentional, so you don't have to worry. Just stick to the documentation.


Alerts UI - frequency field is reset to default when user changes "what to evaluate" field

Alerts UI - frequency field is reset to default when user changes "what to evaluate" field.
When editing or creating a new Alert and changing "what to evaluate" field, the frequency field is always reset to the default 10 minutes - not clear why they are so tightly coupled, but it causes the user to pay attention and change that back every time, because otherwise the alert setting changes to something the user didn't want to.

@miq-bot add_label ui

was this fixed?

@abonas Not sure, but let's move this over to the correct repo to be evaluated.
@miq-bot move_issue manageiq-ui-classic


Bug: In-App Messages loading indicator

Improve loading on the Notifications via a clear loading indicator and accompanying message to the user
User-facing loading messages:
if (isLoading) {
	myMessagesStatusText = 'Loading your notifications, please wait.'
} else if (this.props.myMessagesError) {
	myMessagesStatusText = 'There was a problem fetching your messages.\n\n' +
						   'Please try again soon.'
} else if (messages && messages.length === 0) {
	myMessagesStatusText = 'You have no notifications.\nYou may be opted out of all topics.\n\n' +
						   'Notifications to specific topics can be turned on in User Profile.'
}

merged into experimental-v2: 45bd03e9c0c1e3a55d660c032fafd37ba03aa24c

Verified. Merged into experimental


Access to other uptime servers

Hello,
I discovered your module and I asked if I can transpose it in my homelab.
I have an uptime kuma server that seems to be the same base than your uptimerobot service.
I can have an API key too : https://github.com/louislam/uptime-kuma/wiki/API-Keys
I forked your project to try to adapt it, but I'm not sure to modify the good parameters.
I identified the urlApi and option.url in the node_helpers.js file as a link to the website.
Do you know if I have to modify anything else in the code ?

Hi,
Thank you for your time.

@NeoSlugman, I have a fork of this project that's been adapted to Uptime-Kuma instead of Uptime Robot.


Add Location, Reason & ContactInfo attributes

Hello, I would like to add options to include Reason, Location, and ContactInfo during signing.

Thank you for the PR!
May I ask what's your use case for these fields is? Do you have some specific legal or client requirement on setting these?
Standard reference: PDF 32000-1:2008 12.8.1 (table 252)

Actually, I haven't come across any requirements that necessitate the inclusion of those fields. However, it may be beneficial for the reader to have information about the reasons, location, and signatory details, which is something I also require.

Image Source: StackOverflow


Dealers are missing the links that they entered

Original comments

Android intent to open Telegram with a given channel/handle.
https://stackoverflow.com/questions/21627167/how-to-send-a-intent-with-telegram

Don't forget to test on the latest Android version and beta. The PackageManager has changed and may return 0 results without a correct  section.


HydroShare GIS Add Local File not working for Shapefiles

I created a HydroShare GIS Map Project saved in https://www.hydroshare.org/resource/c5ea17e850c64b34a93fb778e03a0222/
I loaded a shapefile using the Add Local File Button.  I selected all parts of the shapefile to add.
The current layers list then showed each file individually and did not recognize this as a single shapefile entity to display.
I then tried loading the parts of the shapefile as a zip file, but the zip file was not opened and displayed on the map.  It appears in the Current Layers as a zipfile.

This issue was moved to CUAHSI-APPS/tethysapp-hydroshare_gis#24


Support SPIR-V 1.3 and Vulkan 1.1

This requires the latest SPIRV-Headers that supports SPIR-V 1.3.

The bots did pass on this PR.
The "x" failure shown above is due to cancellation of the bots when this CL landed on master;  I had immediately added yet another commit on top of it, so the "master" jobs for this CL were cancelled in favour of jobs for the very latest master.


"Mircea cel Bătrân", "Rovine" are listed in the drop-down menu

Description:
When user writes ” Mircea cel Bătrân” and "Rovine" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Mircea cel Bătrân"

Expected results
The location appears in the drop-down menu as "Sat Mircea cel Bătrân, IALOMIȚA (Reviga)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Rovine"

Expected results
The location appears in the drop-down menu as "Sat Rovine, IALOMIȚA (Reviga)".


elixir-android <--> Android comms

Dear all -- good-looking project!
This is not really an issue, more of a query:
Would an Android application built with this be able to

receive push notifications;
call Android OS functions?

Or would that require work on the bridge?

Thanks!  I'll take it out for a test drive just now.  Do you think there is much potential for qualitatively speeding up the startup time (eg to under a second)?

There definitely is room for that. Startup time is something that erlang+elixir have generally improved on recently and the example skeleton is still using a relatively old version.

Thanks :)


Hover effect on the Helpdesk

Is your feature request related to a problem? Please describe.
There is no hover effect on the Helpdesk in the footer.I would like to add one.
Please assign me this issue.

Okk.
Also, align the help desk button properly.


Create View "Enter Financial Product Data"

User story

As a consultant
I want to enter financial product data
So that I can store and evaluate products

Acceptance criteria

Implement list which contains each criteria (generic)
For each criterion add:
- Field for saving numerical values
- Option to assess evaluation (High, medium, low)
- Comment area
- Possibility to add documents (UI only, no document database yet)
- Criterion can have subcriterions with same fields
Add possibility to submit overall rating
Add button to economic evaluation (= Save & Forward to #62 )
Add button to save and go back to product overview (#48)
Add cancel and go back to product overview (#48)

Definition of done

Added only after week 5
The same for all features


Website content translation to Turkish

Website content translation to Turkish

https://docs.google.com/document/d/1rnh0Sm8RlejwiVkTUI4oXc-P6Lq9lfdZ2sZ8dFxdx-Q/edit?usp=sharing


Is it possible to have properties like $first, $last, etc. as in AngularJS in v-for loops?

Hello,
I found out in the VueJS documentation about lists, only $index exists as a special property in template lists. AngularJS has 6: $index, $first, $middle, $last, $even and $odd which I found really convenient.
For example, instead of writing this code:

  <li v-for="item in items" :class="{'last': $index === items.length - 1}"

We would write:

  <li v-for="item in items" :class="{'last': $last}"

Avoiding the well-known-and-always-the-same logic to know if we are talking about the last element or not, or the first element, or an odd element, etc...
Is it possible to get this part of VueJS 1.x.x?
Thanks!
Jerome

(No comment on Vue 1)
In Vue 2 I don't see this being very feasible due to the v-for="(item, index) in items" syntax.
Maybe you could just write helper methods instead and add them in each component that needs them?

$index is deprecated in 2.0 in favor of explicit syntax (item, index), because it has been concluded long ago that magically injected variables like $index will be a mess if you are in nested v-for(ng-repeat).
So please use the solution you're using, it's only a few characters longer but everything is more explicit and won't give you any surprises, and you have full control of what's going on.


error in property name for lineAlignment

The last json block of the second last code section has...
displayName: "Line Alignment",
uid: "dataCard_dataDesign_lineAlignment_slice",
control: {
type: powerbi.visuals.FormattingComponent.AlignmentGroup,
properties: {
descriptor:
{
objectName: "dataCard",
propertyName: "fontColor"
},
mode: powerbi.visuals.AlignmentGroupMode.Horizonal,
value: "right"
}
}
fontColor should be lineAlignment

Document details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 777292ae-fa02-7f8f-395d-2d9b850883ba
Version Independent ID: 777292ae-fa02-7f8f-395d-2d9b850883ba
Content: Customize the format pane in Power BI custom visuals - Power BI
Content Source: powerbi-docs/developer/visuals/format-pane.md
Service: powerbi
Sub-service: powerbi-custom-visuals
GitHub Login: @mberdugo
Microsoft Alias: monaberdugo

Thanks for your comment, @o221. This issue has been assigned to the doc author for review.

Thanks for pointing this out, @o221. I'll make the change and it should be live in a day or so.


Log routes

Current coverage is 92.80% (diff: 91.50%)

Merging #3 into master will decrease coverage by 0.21%

@@             master         #3   diff @@
==========================================
  Files            22         24     +2
  Lines           645        751   +106
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            600        697    +97
- Misses           45         54     +9
  Partials          0          0

Powered by Codecov. Last update b5b8dbd...f3149ca

How would you print this from Vapor? Something like this?
print(drop.router)

@tanadeau you'd print like print(drop.router.routes())

Lol wrong "tan"


add a prop for callbacks on DOM event

For example on the Checkbox element.
I want to do the following :
import { Checkbox } from 're-bulma'

const CustomComponent = ({ option, onToggle }) => (
  <Checkbox
    key={ option.name }
    onCheck={ () => onToggle()}
  >{option.name}</Checkbox>
)

and have my callback be fired everytime I check or uncheck this checkbox.
but at the moment . . . nothing is happening, and I'm too lazy to implement this myself :)

@Thebigbignooby Thanks for your report. I'll need to add callback props.
But, does react support the onCheck callback? Is it onClick?


Keyboard Manager - Direct keystroke to out of focus window using WinTitle

Enable KeyManager to specifies an out of focus target for a remapped keystroke.

I imagine this feature as adding some optional elements to the configuration UI for KeyManager that specifies a Win Title the remapped keystroke is to be directed to, even if the application is out of focus. Partial substring match or regular expressions used to specify the WinTitle.

Hi @taxetTia, need a little clarity. Are you hoping to invoke a shortcut that only ever applies to an app thats not in focus?


Convert avro to protobuf

Works towards closing #43

Thanks @david4096, this is great! +1 for merging this and going forward from there. We'll need to polish a few things (update pom.xml etc.).

This is a good start, but we should have the proto version cover everything we currently have in Avro before we merge it. I've copied this to the develop-proto branch, where we can continue developing. Closing the PR, we'll submit a new one from the develop-proto branch when we feel like we're done.


Consistent column widths for chapter 9.

i can't see any difference in the output from this PR
am i missing something?
what should be the result of this change please?

Currently table 9.4 is full width. With the change it should only occupy 25% of the width, thus the cells end up the same width as in earlier 4-column tables.
This gives consistency across the various tables, and also makes it look much more like the original DocBook version.

that makes sense, thank you


Fix exception in ToolTip.

Make sure old ToolTip is disposed before showing a new one.
Fixes #1029.

cc: @Sergey-Terekhin


Please give us a builded ffmpeg.exe for download?

Thanks for developers, please give us a builded ffmpeg.exe for download, i don't know how to build, thx

It is beyond the scope of this project to explain how to compile ffmpeg for Windows.
However I keep getting asked to provide a static exe incorporating xfade-easing.
Despite several attempts I have not managed to cross-compile but I shall keep trying other methods.


winetricks mt4 hangs

The following command:
curl https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks | bash -x /dev/stdin mt4

hangs on Linux.
E.g.
$ DISPLAY=:0.0 ./winetricks mt4
Using winetricks 20160425 - sha1sum: 0d572083442ec7b1375999e81f9f042f5f427a3c with wine-1.6.2
Executing w_do_call mt4
Executing load_mt4
------------------------------------------------------
Working around wine bug 7156 -- Meta Trader 4 needs wingdings.ttf, installing opensymbol
------------------------------------------------------
Executing w_do_call opensymbol
opensymbol already installed, skipping
Executing wine y:\ahk\AutoHotkey.exe C:\windows\Temp\_mt4\tmp.ahk
wine: cannot find L"C:\\windows\\system32\\winebrowser.exe"

^C

Fixed in Winetricks/winetricks/issues/645


Integrate a refactored drone 1.0.x pipeline

For now I have commented out the codacy step until I have debugged the current issue. All components are built multi-machine now, the deployment for try only happens after all build steps, building the binaries should only happen if the test suite succeeds. Next step could be integrating jsonnet, adding multi architecture and adding a Docker manifest.

Whoops, sorry. This needs a rebase now (which you can do with the rest tomorrow) as Dart 2 was merged in #20.
The conflicts should only affect the dart and UI steps. :blush:


Expose a constant that defines the genesis Fork

When running testnets it is desirable to set a wacky Fork version to avoid signature collisions when we go to mainnet.
Presently there's no way to express this in the configs, which is a little awkward for testnet interop.
If we could expose it as a "constant" then it would fit nicely into a config.

I'm in favor of adding GENESIS_FORK_VERSION instead of relying on default SSZ 0x0. This is certainly something we want to tune in testnets and other use cases


Nested Objects in Environment

Hi i try using nested Objects in env for debugging like this
{"TANGA": {
    "DEBUG": {
      "WEBSOCKET": true,
      "COLLECTION": true,
      "STORE": true
    }
  }
}

Problem is jshint failed on Build.

Hi,
you're right. It never occurred to me but this is an obvious use case. I fixed this. If you want to fix it in your gulp task. Replace the following line: https://github.com/mwaylabs/generator-m/blob/63a2b2a9be9dd35a93247ab0a48cfc04a91c31a1/app/templates/gulp_tasks/injecting.js#L92
json = json.replace(/  /g, '');

with this:
json = json.replace(/^  /g, '');

Nice thanks


Improve diagnostic if where clause is missing a requirement

Fixes apple/swift-syntax#759
rdar://99730909

@swift-ci Please test

Oh, sorry, accidentally merged without waiting for a review, @bnbarham. I’ll address review feedback in a follow-up PR.


Connecting to device results in error 133

Changing one line ConnectionManager.kt:225
device.connectGatt(context, false, callback)
to
device.connectGatt(context, false, callback, BluetoothDevice.TRANSPORT_LE)
solves the problem (although requires to target SDK at least 23)

@sgserg Sorry for the delayed response. Thanks for reporting this issue! We'll keep this issue open for when we move the library to target a minSdkVersion of 23. For now, we're sticking to 21 and so some OEM devices may not work well. Would you mind also posting your device that failed to connect using connectGatt? Device manufacturer, Android version, etc.

@cheeyi Sure, tested on Maize M6s, Android version 7.0, Flyme <IP_ADDRESS>G

We have a list of possible reasons that could trigger a 133 error in https://punchthrough.com/android-ble-guide/#Connecting-To-A-BLE-Device. Closing due to inability for our team to reproduce this issue reliably.


How to handle merge entity records into NormalizedRecord?

NormalizedRecord cannot be merged with previous entities, records are replaced and not merged together as one would expect. Using mergeDeep (which would handle list concatenation) throws an error as entities is a Record and not a List.
import { Schema, arrayOf, normalize, NormalizedRecord } from 'normalizr-immutable';
import { Record } from 'immutable';

const record = Record({ id: null, name: null });
const schema = new Schema('articles', { record });

const results = normalize([
    { id: 1, name: 'One' },
    { id: 2, name: 'Two' },
    { id: 3, name: 'Three' }
], arrayOf(schema));

const more = normalize([
    { id: 4, name: 'Foo' },
    { id: 5, name: 'Bar' },
    { id: 6, name: 'Baz' }
], arrayOf(schema));

let state = NormalizedRecord();
console.log(state.entities === null);

state = state.merge(results);
console.log(state.entities.articles.size); // 3

// Uncaught Error: Cannot set unknown key "4" on Record
// state = state.mergeDeep(more);

state = state.merge(more);
console.log(state.entities.articles.size); // 3 <-- Expected a size of 6

Thanks. I'll take your remarks and add them to the test (feel free to do that, if you like).

Thinking about this a bit more, this is likely caused by the fact that the entities structure is a record and I basically abuse the Record api by creating the Record definition with the entities result. This seemed like a good idea at the time to be able to keep the ability for dot-property access in place.
This is an unwanted side effect. The most obvious workaround instead of merging is to create a new Record with the content of the original record and the new result. I suppose I could create a helper for that.
Another option would be to drop this Record approach entirely and use a map, which is the proper way of doing this, but at the expense of dot-property access.

I just had an idea. What if the result key would contain proxies instead of ids? In that case, you would never have to access entities directly and the entities structure could be just be based on a regular map.
Alternatively, even if we don't do that, the relation could be like so, and you could merge on the Record schema keys.
entities:{//Record with articles as a schema key
  article:{//Map with id-object relations
      3:{},
      5:{}
  }
}

If you use the proxy, this would be minimally impactful on your code. The proxy would abstract the map access away mostly. I imagine it might also be more performant.
 renderRow (rowData) {

    const { articleReducer, actions } = this.props;
    const articleObject = articleReducer.entities.articles[rowData];

    return (
        <Article
            post = {articleObject}
            {...actions} />
    );
}

render () {

    return (
        <ListView
            dataSource={ this.state.dataSource.cloneWithRows(this.props.articleReducer.result.toArray())}
            renderRow={ this.renderRow.bind(this) }
        />
    );
}

//would become
renderRow (rowData) {

    const { articleReducer, actions } = this.props;
    const articleObject = articleReducer.entities.articles.get(rowData);

    return (
        <Article
            post = {articleObject}
            {...actions} />
    );
}

render () {

    return (
        <ListView
            dataSource={ this.state.dataSource.cloneWithRows(this.props.articleReducer.result.toArray())}
            renderRow={ this.renderRow.bind(this) }
        />
    );
}

I think I will make this an option, so people can choose between the approaches. WDYT?

Ok, added to 0.0.3-rc branch

Though I am not currently using getState/reducerKey, that seems like a viable solution.


WIP: Convert zone pivots config to YAML

Replaced with https://github.com/dotnet/AspNetCore.Docs/pull/19175.


⚠ Bofrost.de has degraded performance

In fe2c483, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1078 ms

Resolved: Bofrost.de performance has improved in 2e3be94 after 6 minutes.


Connection problem

Hi everyone. I tried to configure ARI as this link ( https://wiki.asterisk.org/wiki/display/AST/Asterisk+Configuration+for+ARI ).

And when running, it doesn't show anything.  I went wrong in the installation step, help me

There's no way for us to troubleshoot that error.  "DEADLINE EXCEEDED" is a message from the Google API.  You should consult their documentation for more info.


Why do u choose Solr

Hi, i am reading your project, why do you choose Solr instead of other search engines such as Elastic search... Can u tell your purpose, the pros and cons of Solr if you know, thank u so much

Here you go: https://sematext.com/blog/solr-vs-elasticsearch-differences/


[Visual Studio] Colorize ${} as a keyword in ES6 template strings

Visual Studio Code correctly colorizes ${} as a keyword in template strings, but Visual Studio does not:

This issue was moved to Microsoft/TypeScript-TmLanguage#253


Scan for past removals of finalizers and add logict that removes the finalizer if it exists. This is so that long running systems do not start leaking objects, because we removed the finalizer

This chore is too broad. Let's close it and reopen it with more specific details (the finalizer of which object has to be removed) if it occurs agiain


Mentioning Page Extensions

Could information be added about whether all or which of all these are available on Table Extensions?
As per VS Code compiler, I can e.g. use both OnDelete, OnBeforeDelete, OnAfterDelete and I do not find any information about them, nor in which order table extension triggers are executed against the standard table triggers.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb8a0a4d-a5ee-0e97-fb86-838f5aea4394
Version Independent ID: cbefe940-1d8e-5340-f733-4c701db41f68
Content: Table and Field Triggers - Business Central
Content Source: dev-itpro/developer/triggers/devenv-table-and-field-triggers.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Hi, thanks for your feedback. Documentation for the table extension triggers has been added and it will be available soon.


Add TracedRunnable and TracedCallable

Similarly to TraceRunnable in Sleuth, I think we could make the lives of those users who wants to switch threads simpler in some scenarios by providing TracedRunnable and TracedCallable components that will propagate the context and create a new Span for tasks running on different threads. Additionally, maybe we can create components that are not starting new Spans but just propagating the context (open Scope). The use-case is something like this: https://micrometer.io/docs/tracing#_micrometer_tracing_examples
See: https://github.com/micrometer-metrics/micrometer/issues/3881

I am working on adding ObservedRunnable and ObservedCallable. During that process I came across this. I believe adding TraceRunnable and exposing an executor similar to LazyTraceExecutor will be a good design. If not should can we expose this in ContextExecutorService. Please let me know your thoughts and correct me if I am wrong.

Also can I please work on this also along with ObservedRunnable.

I think that could be step two on top of TraceRunnable. But I'm curious about @marcingrzejszczak's opinion.
I assigned this issue to you.

So let's discern two things here

Context Propagation
Span creation

We already have the 1) done via https://github.com/micrometer-metrics/context-propagation and its methods. I understand that we would like to have some helper methods to create new observations around Runnable, Callable and Executors and ExecutorServices ?
I think those are so specific that we can't really create anything out of the box for them (I think doing that for Sleuth wasn't the best idea). How would we call the observations? What would be the low and high cardinality tags?

I have this code:
    public static ExecutorService newFixedThreadPool(final int corePoolSize) {         final ExecutorService service = Executors.newFixedThreadPool(corePoolSize);         return ContextExecutorService.wrap(service, ContextSnapshot::captureAll);     }
I need to submit multiple tasks to it. Now I need to propogate some key-value pairs to each task.
Those key values will be different for each task.
Once that task gets those key values, it will be set in ThreadLocal/Use Them for some purpose.
How can I do it?
I tried to implement ThreadLocalAccessor but that is propagating wrong key values for each task.
@marcingrzejszczak

Do you want to create an observation around those scheduled tasks or propagate baggage?

Do you want to create an observation around those scheduled tasks or propagate baggage?

We need to propagate some key values to each thread.
So let's say there's a for loop in which we are submitting the task to the executor service and before submission that key value might get changed. So that updated value needs to be propagated. Tried this with ThreadLocalAccessor but that propagates the wrong key value.

So just write custom wrapper around the executor that will take the current observation and modify its key value.

Ping?


Cardinality of where element in ViewDefinition

Think this should have a cardinality of 0..*?
Also, is it an array of path strings or an array of objects with a path element?

Updated in logical model


Handle crashes and OOMs in Redis worker

Now that we're running the prediction in a separate subprocess, we can monitor the state of that from outside. When we detect that the prediction process has exited (due to OOM or random crashes) we should send a terminal failed status to the output queue/webhook and terminate the main process. On Replicate, that will then spin up a new fresh pod.

This is done as of https://github.com/replicate/cog/pull/795


Unable to build Dicom2Mesh on windows

Hello,
First of all, it really looks like great work and I highly appreciate it making it open source.
Unfortunately I'm not able to build DicomToMesh on windows. I Installed VTK 7.1.1 and one of the examples is working, so i'm assuming that part is okay.  Underneath you'll see how I'm using cmake(first time using cmake.). No errors or anything.  But when building "ALL BUILD" I get the error in the second image. I saw in another issue someone having the same issue, but that should be fixed in a newer version. The version I have if from today. I'm also not sure if any other library will be missing after vtkmeshroutines.h since that is the first one.
Edit:
The other 2 libraries imported are also not reachable. See last picture.
Edit 2: Okay, It seems that when using git clone, this errors occur. Just downloading it as zip doesnt make any error pop up and cmake is showing options like the GUI, which didn't show on git clone files. But building the solution doesn't make a folder in program files (86x). The command "dicom2mesh" and "dicomtomesh" also don't work while visual studio is telling that the build succeeded without any errors.
Hope anyone can help me out:) Thanks in advance!

Hi,
If those three header files cannot be found, the cmake configuration went wrong. This has nothing to do with git. I think I see what is the problem - you point to the wrong cmake file. Could you please try the following:

In CMake, set the source code directory to C:/Users/....../DicomToMesh instead of  C:/Users/....../DicomToMesh/dicom2mesh

Basically, the "source code directory" is the location where the top CMakeLists.txt file is located.
Hope it works, Adrian

Hello,
It works for the cmake part and building without errors. But i'm still not seeing the folder created at  CMAKE_INSTALL_PREFIX location or any other. Starting visual studio as admin is not helping.
For now using the pre-build files from another user I found in other issues seem to work correctly:). Maybe adding an prebuild windows version somewhere in the readme would help other windows users, since installing vtk can also be cumbersome. Thanks for the help!

The cmake_install_prefix is only relevant if you call "make install". In your case when building worked, the binaries should be located under the build directory - something like C:/Users/....../Dicom2Mesh/build/dicom2mesh/Release/
and
C:/Users/....../Dicom2Mesh/build/lib/Release/
Easiest is to search the build directory for the files dicom2meshlib.dll and dicom2mesh.exe. To run the exe, the dll needs to be located in the same directory (or somewhere the PATH points to).

@eidelen  Thanks! I got it working:)


Rename test function

Should be named test_fit ? And in folder tests.
https://github.com/Ouranosinc/xclim/blob/8078cb5ac5d331361f6ff5255e1f88f6750bbb41/xclim/stats.py#L46

Yep, but it's still very much experimental (it works, but needs polishing).

I know, it's just so that we don't forget. Was browsing the code!

Added a note to address this in the future with b3d2debabff51ad5d4844295e28228b85d57e330


Is it possible to build the bom from just gerbers and position files?

Is it possible to build the interactive view from just gerbers and component position files allowing one to search for components?

No, gerber files have no information about components, only about pcb layers.

The placement file has information about components.
On Mon, May 27, 2019 at 12:20 PM qu1ck<EMAIL_ADDRESS>wrote:

No, gerber files have no information about components, only about pcb
layers.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openscopeproject/InteractiveHtmlBom/issues/101?email_source=notifications&email_token=ABCGVCLIXREOYFVLWJWT6CDPXOYXJA5CNFSM4HP2OP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJNTEY#issuecomment-496163219,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCGVCKY6ASFKZE2N64H3A3PXOYXJANCNFSM4HP2OP6A
.

It should be possible to at least reconstruct the placement of references.
On Mon, May 27, 2019 at 12:20 PM qu1ck<EMAIL_ADDRESS>wrote:

No, gerber files have no information about components, only about pcb layers.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I started looking at it and what I have done so far is export gerbers from
gerbview to kicad pcb format and for now without the placement data. The
interactive bom script says it failed to parse the file. Possibly because
there is no module data in the file. I have no time to look further into it
but I'm thinking I could use kicad-library-utils and parse the placement
data and then create dummy modules in the kicad pcb file and try exporting
again. Would be very helpful because I have old gerbers with placement
files that I want to browse this way.
On Mon, May 27, 2019 at 12:20 PM qu1ck<EMAIL_ADDRESS>wrote:

No, gerber files have no information about components, only about pcb
layers.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openscopeproject/InteractiveHtmlBom/issues/101?email_source=notifications&email_token=ABCGVCLIXREOYFVLWJWT6CDPXOYXJA5CNFSM4HP2OP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJNTEY#issuecomment-496163219,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCGVCKY6ASFKZE2N64H3A3PXOYXJANCNFSM4HP2OP6A
.

If you provide examples of files I can look into it more but I highly doubt placement files have anything other than positions of component centers and some part id (not board component reference) which is not enough. At the minimum bom needs board reference, value and footprint.

The interactive bom script says it failed to parse the file.

How are you running it and what is the exact error message?

I will close this for inactivity unless I hear from you in a few days.


feat: state consumer

Thanks for the PR! I tested it, and I am getting results, but I noticed some issues:

When tests are running, I do not get intermediate status while tests are running - the status updates to "passed"/"failed" only when all tests finish. But for example, in test summary statuses are being updated in real-time.
When I open the file and immediately run tests, sometimes I do not get running test results.
In some files with many files when all tests finish I still see one running test (even when in the test summary there are no running tests).

Here is my status function:
      function()
        local status_ok, neotest = pcall(require, "neotest")
        if not status_ok then
          return ""
        end
        local adapters = neotest.state.adapter_ids()
        if #adapters > 0 then
          local status = neotest.state.status_counts(adapters[1], {
            buffer = vim.api.nvim_buf_get_name(0),
          })
          local sections = {
            {
              sign = "",
              count = status.failed,
              base = "NeotestFailed",
              tag = "test_fail",
            },
            {
              sign = "",
              count = status.running,
              base = "NeotestRunning",
              tag = "test_running",
            },
            {
              sign = "",
              count = status.passed,
              base = "NeotestPassed",
              tag = "test_pass",
            },
          }

          local result = {}
          for _, section in ipairs(sections) do
            if section.count > 0 then
              table.insert(
                result,
                "%#"
                  .. section.base
                  .. "#"
                  .. section.sign
                  .. " "
                  .. section.count
              )
            end
          end

          return table.concat(result, " ")
        end
        return ""
      end,

Thanks for testing @sidlatau!

When tests are running, I do not get intermediate status while tests are running - the status updates to "passed"/"failed" only when all tests finish. But for example, in test summary statuses are being updated in real-time.

I've addressed this so you should see updates the same as the summary.

In some files with many files when all tests finish I still see one running test (even when in the test summary there are no running tests).

This may also be fixed by the previous change, please let me know!

When I open the file and immediately run tests, sometimes I do not get running test results.

Do you mean that the the statuses go from 0 running/failed/passed to 0 running and x failed/passed? How long do the tests take to run?

FYI @weilbith I've added a positions function to get the tree of positions in a buffer

@rcarriga I just checked the latest changes, and I am unable to reproduce any of the previous problems, thanks for the update! LGTM for the merge! 🚀

Thank you very much for your work on this! 🙏🏾
Despite the simple status, I have already 3 different "plugins" planned using this data. 😊

Great to hear! Would love to see it in use when ready :smile: