live <= master

Docs Build status updates of commit a0d8135:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/laurent-bugnion.yml
:white_check_mark:Succeeded
View

advocates/media/profiles/laurent-bugnion.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e0f0a48:
:warning: Validation status: warnings

File
Status
Preview URL
Details

advocates/index.html.yml
:warning:Warning
View
Details

advocates/cassie-breviu.yml
:white_check_mark:Succeeded

advocates/laurent-bugnion.yml
:white_check_mark:Succeeded
View

advocates/map.yml
:white_check_mark:Succeeded
View

advocates/media/profiles/cassie-breviu.png
:white_check_mark:Succeeded

advocates/media/profiles/laurent-bugnion.png
:white_check_mark:Succeeded
View

advocates/toc.yml
:white_check_mark:Succeeded
View

advocates/index.html.yml

Line 10, Column 8: [Warning-file-not-found] Invalid file link: './map'.
Line 12, Column 8: [Warning-file-not-found] Invalid file link: './tweets'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Bug: Git3 checkout and merge: Not working for branches with '/' in name

When creating a branch with slashes (/) in the name, git3 checkout and git3 merge are not able to work with this branch.
git3 checkout it not able to switch to the branch
git3 merge is not able to merge the branches

So, git3 checkout actually works, but adding content to a file, adding and commiting it, the changes are lost after switching to a different branch and coming back.
main -> git3 checkout -b feature/branch -> change file -> git3 add -> git3 commit -> git3 checkout main -> git3 checkout feature/branch
Changes are lost.


Added custom function object calling with details.

Added the ability to use the req object in custom validators with README and test updates.
Addresses #188

I'm quite afraid of this PR... it feels like is a breaking change.
Any custom validators accepting a rest argument will likely break/won't be possible because of this.

Version 4.0.0 arrived and custom validators will now have access to the req object 😉
Check the README for complete docs and the upgrade guide for version 3 users.


AppCode support

It would be great to get an AppCode plugin that runs clang-format on save!

It would be, but you would need to talk to the Jetbrains guys about that. Their plugins are written in Java, and this is a plugin specifically for Xcode. I believe AppCode already has some form of code auto formatting built in, doesn't it?


do a light.pool

light got a max number
light needs to be init before objects
do a light.pool
intensity == 0 => invisible
a bit slower but not much

provide nb light per type


Add defaultText to extraBin.namd

fixes #335

Please squash merge

Done already if not mistaking

Do you want me to change the commit message?


chore: Separate alloydb config and superuser

Refactor codebase so that individual Cloud Run jobs referencing AlloyDB don't require alloydbsuper db roles.

move subnets and vpc-access connector are part of common infra.
defining names of service accounts, and creating alloydb users, must also be done in common-infra/ and passed to later modules.
new Cloud Run job in common-infra will create schema, db users, and grant permissions to those db users. It will not set tables, that logic should be left to each individual job in its own module.

TODO: still need to get this triggered as part of the overall terraform apply command

Discussed with Eyal to move the AlloyDB config steps to a new module like components/post-setup-config, and revert the changes to specialized parser user to remain under the specialized-parser/ module


chore(EMS-848): Change yes/no string fields to booleans

This PR changes various fields defined by the KeystoneJS schema to be a boolean/"checkbox" field instead of a text field with "yes/no" values.
Changes

Create a custom KeystoneJS field, nullableCheckbox. This allows us to create checkbox keystone/graphQL/DB fields that are null by default.

This is not possible with Keystone's default checkbox field - it has to have a true or false value by default, which is not appropriate for our use case.

Update all type definitions, conditions, tests and mock data for the following fields:

hasTradingAddress
hasTradingName
hasAntiBriberyCodeOfConduct
exporterHasTradedWithBuyer
isUsingBroker
canContactBuyer
exporterIsConnectedWithBuyer
exporterHasTradedWithBuyer
Section review: eligibility, policyAndExport, business, buyer

Remove now unnecessary logic for "yes/no" strings in the yes-no-radio-buttons nunjucks component.
Update and rename getYesAndTrueAnswerProperties to getTrueAndFalseAnswers,
Update "required declarations fields" to handle a particular declaration answer being null, undefined, true or false.
Update "your broker" and "your buyer" summary list mappings so that "yes/no" values will appear instead of booleans.
Bump KeystoneJS version.

Is there anything in submittedValues, where if the value is null, it does not default to false which selects the no radio?

The radio's will only be selected it the value is either true or false due to updated nunjucks conditions for checked i.e:
checked: submittedAnswer === true
checked: submittedAnswer === false


replace label 'releaser-v2' with 'executor-v2'

Currently there no agents labeled with releaser-v2.
What does this PR do?
replaces agent labeled with releaser-v2 to executor-v2
What ticket does this PR close?
N/A
Checklists
Change log

[ ] The CHANGELOG has been updated, or
[x] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[ ] This PR includes new unit and integration tests to go with the code changes, or
[x] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[x] This PR does not require updating any documentation

Approved because without pipeline adjustments there's no way to test this outside of master. Happy to discuss further if need be.


Typo fix restrction -> restriction

Fix typo in description in Overview document: restrction -> restriction

Oh, I guess I should have checked PRs first. There is also one with "flexibility" I fixed in #52.

Also needs rebase


[Enhancement]: Add custom saved prompts

Scope
Web (gpt-turbo-web)
Type
New feature
Description
I'm not sure this is in the scope of this application but would be very nice to be able to save custom prompts and start conversations with them. I have some prompts that I use a lot and ended up storing them in a markdown file and copy-pasting them when needed.
The main points would be:

Users should be able to view a list with custom prompts (maybe in a modal?)
Users should be able to add/delete/edit custom prompts that they created
Users should be able to select a custom prompt from a select input when starting a new conversation
Users should not be able to see other users prompts or have any kind of cloud like functionality
User prompts should be stored in the user browser (maybe localstorage or something like that) and would be lost when clearing cache (just to avoid all the work of syncing it)

It is a somewhat complex feature so I would definitely understand if you think it shouldn't be added.
Benefit
Users would have easy access to prompts they use a lot when creating a new conversation, making it easy to do repetitive tasks in different conversations (like generating code or translating text)
Participation
Yes

Hey! Thanks for opening an issue.
Yes, that would be a good idea, especially for context (system) prompts. I would suggest some button inside the context input (when creating a new conversation) and the same button inside the prompt input of the conversation. When either of these buttons is pressed, a popup or dropdown shows the saved prompts (maybe with a name instead of the entire prompt? or maybe with an ellipsis "..."?). I'm open to different display methods, I've never had the same use case as you so you might have better insight into it!
I'd be happy to work on it soon, or I can leave it to you if you'd like.

@guilhermelimak did you plan on implementing this? Just so I know before I work on something you're already working on 😅

hey, sorry about the silence. I will not be able to work on this for at least a couple of days, I'll post here to let you know if I start working on this so we don't do the same work twice

I'll start working on it and hopefully get it out pretty soon! 😁

Hey, just a heads up that the feature has been implemented. However, upon deployment, I've noticed the app totally crashes because of an invalid persistence state in local storage. Because this will affect most returning users, I've rolled back to the previous deployment until a fix is out for this bug. Will let you know when it's deployed!

Fixed by #18. It's now live on the web app!

This works wonderfully! Thansk a lot for taking the time to add this feature. Your app is great, I've been using it daily.


Define plane for MV opening

Allow the user to select the plane for the MV opening.

Can be done using basic Slicer controls. Reopen if decision is made to add more explicit control.


Missing  your self-collected LiDAR scan dataset

Hi,
Your demo is very engaging. This is a very good work.
I noticed that the outdoor_AVIA folder is empty in the data file. Is this data missing, or is it temporarily not publicly available? I'd like to test how well this works in an outdoor environment.

Thank you for following our work.
Due to company copyright reasons, the self-collected data "outdoor_AVIA" is not available now.
However, you can make your own outdoor dataset for experiments using the format provided.
Sorry for causing trouble, we'll try our best to make it public as soon as posible.


Feature request: support Observables

Would be nice if we would have observables that track the remote value and are automatically updated when the value on the remote is changed. Let me know if that sounds like something this repo can accommodate.

A version of this could be made to work and would be very cool.
What would the API be? How about having y = @remote x "just work" when x happens to be an observable on the remote side?
Here's how that can work.

We add a listener to x on the remote side to send the updates down the RemoteREPL socket
We create a new Observable y on the local side, and register it with the code which manages the RemoteREPL socket so that updates translate to y[] = new_x_val

The big under-the-hood change needed would be to update the RemoteREPL protocol to give each message an ID and allow out-of-order delivery of messages between client and server. That way we can safely interleave delivery of Observable updates with normal RemoteREPL "REPL traffic", and deliver each message to the correct consumer on the client side.
This is a good change in general because having message IDs and out of order delivery would also greatly help with delivering log messages back to the client in real time. And would probably allow more graceful recovery from disconnected sockets as well.

How about having y = @remote x "just work" when x happens to be an observable on the remote side?

I guess that could work with some multiple dispatch that expects an Observable and it's also very close to the current design. But there is a corner case. What if the user really just wants to take the Observable x from the remote and not create a new y that tracks it ? How would they do it ?
Also,  do you want Observables.jl to be a direct dependency or have as an extension. I think I would prefer not using extensions since Observables.jl has almost no dependencies itself.

update the RemoteREPL protocol to give each message an ID and allow out-of-order delivery of messages between client and server.

How do you imagine that? Like a counter to tell apart which messages are old and which are new? Also why do we need a message ID? We already have a session ID. What would we win to give each message an ID? And if we really need one, maybe we can actually use some sort of a hash of the message content ?

What if the user really just wants to take the Observable x from the remote and not create a new y that tracks it ?

I guess they can't.
But I'm not sure this really works "as expected" anyway? What happens to the listeners on the remote side when the observable is serialized? Are the listeners serialized too? What does it mean to call setindex! on the local copy of that observable? Clearly the listeners on the remote side won't receive any update.

Also, do you want Observables.jl to be a direct dependency

If Observables.jl is low-dependency that seems fine.

How do you imagine that? Like a counter to tell apart which messages are old and which are new? Also why do we need a message ID?

Something like the client generates a sequential ID for a request, and the server sends that ID back to the client in the reply?  So not really a message ID I guess, but some kind of transaction ID to mark the request-response cycle.
Why would we need a transaction ID?  The point is if you have an Observable on the remote side a setindex! update could be triggered at any time and the server will send that to the client whenever it feels like it. But this can happen concurrently with the user typing something in the REPL.
So the client may be expecting the next message from the server to contain the reply to the REPL command, but the client may get an observable update message instead. The transaction ID allows the client to determine which reply is which.


brew cask upgrade failed

Hello,

I try today this command:
$> brew cask upgrade
and got this error:
Error: Cask 'betterzipql' definition is invalid: Token '{:v1=>"betterzipql"}' in header line does not match the file name.

$> brew upgrade
is still OK.
Any idea to fix that?
Thanks for the reply.
Rgds,

Welcome @MrMic,
When you open an issue, please:

Follow the template (as it warns you to).
Do not open issues for formulae or casks in this repo (as the template warns you to).

The consequences are clear, and right at the top:

Please note that we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

When you ignore the template, you waste maintainer time and everybody loses. So please read and follow the instructions.
Your problem is that you have a very old setup. Open an issue in the correct repo and follow the template, as it has commands that are likely to fix this without you even having to open the issue.


Fix scope access bug in IfError function

Currently an expression such as With({x:1}, IfError(x,x,x)) - which should return 1 - fails to execute. The problem is with the scope access within the IfError function, caused by a bug in the IR translator. This change fixes it, and adds many tests for the IfError function.

✅ No public API change.

✅ No public API change.


Invalid attempt to destructure non-iterable sequence

Hey, just trying to test out the example from the readme. I get this error with just:
class Example extends Component {
  render() {

    let data = [{
      value: 'Banana',
    }, {
      value: 'Mango',
    }, {
      value: 'Pear',
    }];

    return <Dropdown label="Favorite fruit" data={data}/>
}

I'm on "react": "16.2.0", "react-native": "https://github.com/expo/react-native/archive/sdk-25.0.0.tar.gz", and "expo": "^25.0.0". Could this be Expo's fault?

Thanks for question. Probably this issue is related to babel configuration. Please, try running example project without expo in clean environment.


Add Sadaf Tahir to Contributors list

This was my first contribution on Github, the experience of putting my name on to the contributors list was very easy. The instructions were clear and concise and very easy to follow for a first timer!

@sadaftahir, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

The first thing I did was to follow the instructions given at the end of the page of the project. For a first timer they were incredibly easy to follow. I was able to add my name to the contributors file by using terminal in my own laptop. The branch was created and I committed the changes. There were codes given in the instructions, few changes such as my own name was added and then committed. I will go and share my contributions on the link you've provided.

@sadaftahir, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


hls_fragment & hls_playlist_length cannot changed

Hello Everyone,
I have nginx-1.12 with nginx-rtmp-module - latest version.
having a problem with setting hls_fragment and hls_playlist_length which cannot be changed even i have tried to make each fragment with 1s but it's still getting 10 fragments with 4.8 seconds.
Config sample:
           hls_fragment 2s;             hls_playlist_length 10s;
Please is there any solution for this ?
Even tried to put these parameters in application and rtmp section and i have the same default results.

Hello
Did u solve the problem? I have the same problem.
my fragments are 11 seconds.
this is my conf:
`
worker_processes  1;
error_log  logs/error.log info;
events {
worker_connections  1024;
}
rtmp {
server {
listen 1935;
    application live {
        live on;
    }

    application hls {
        live on;
        hls on;
        hls_path test/hls;
		hls_fragment 2s;
		hls_playlist_length 6s;
    }
}

}
http {
server {
listen      8080;
    location / {
        root html;
    }

    location /stat {
        rtmp_stat all;
        rtmp_stat_stylesheet stat.xsl;
    }

    location /stat.xsl {
        root html;
    }

    location /hls {
        #server hls fragments
        types{
            application/vnd.apple.mpegurl m3u8;
            video/mp2t ts;
        }
		add_header Cache-Control no-cache;
		# To avoid issues with cross-domain HTTP requests (e.g. during development)
		add_header Access-Control-Allow-Origin *;
        alias test/hls;
        expires -1;
    }
}

}
`

how are you pushing to your server?
can you check your error log? it might be that your video source cannot be segmented into such small chunks. See here.

how are you pushing to your server?
can you check your error log? it might be that your video source cannot be segmented into such small chunks. See here.

my error log is no problem. my video source is 25 fps/s. how to confirm whether it be segmented into such small chunks? when i use ffmpeg, it can produce .ts file that is 5s.
ffempg command line：
ffmpeg -i "rtsp://admin:awifi123@<IP_ADDRESS>:554" -fflags flush_packets -max_delay 2 -flags -global_header -hls_time 5 -hls_list_size 3 -vcodec copy -acodec aac -y D:\Develop\nginx-rtmp-win32-dev\test\hls\video.m3u8

how are you pushing to your server?
can you check your error log? it might be that your video source cannot be segmented into such small chunks. See here.
thanks for your suggestion,i have already solved this.
when i use ffmpeg to rtmp, i set gop params.
let hls_fragment honoured.

That's why you should always check logs :)
Streaming software sometimes doesn't send full frames regularly - it's
trying to save bandwidth. ffmpeg sets everything to achieve correct .ts
fragments length. nginx receiving stream without those full frames won't do
it on its own - nginx acts only as splitter and broadcaster and if there is
no metadata to split on - it will wait for the closest place after the
split point where stream can be split successfully.
czw., 11.04.2019, 11:04 użytkownik limaob<EMAIL_ADDRESS>napisał:

how are you pushing to your server?
can you check your error log? it might be that your video source cannot be
segmented into such small chunks. See here
https://stackoverflow.com/questions/38216051/hls-fragment-length-and-playlist-length-with-nginx-rtmp-module
.
thanks for your suggestion,i have already solved this.
when i use ffmpeg to rtmp, i set gop params.
let hls_fragment honoured.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/arut/nginx-rtmp-module/issues/1232#issuecomment-482032152,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbp9lew-LUCQGqHz-L14Ynpx0hDkGfhks5vfvqRgaJpZM4Ss09Y
.


Not consistent file names between languages

When I did Spanish translation I looked up from Portuguese translation and resource file name was like  xxxresource.langcode.resx and I followed that convention.
But now with the new Arabic and Vietnamese languages the resource names are xxxresource.resx (without the langcode)
Recently I installed the ResxExtractor and It generates the files like xxxresource.resx. (without the langcode either) I made a modification to the code, to add the langcode, if you want I do the PR.
Install the language pack to the framework requires xxxresource.langcode.resx I think this is the way to follow, what do you think?

You are right, seems I miss to push some changes accidently


Update MiniWord.Implment.cs

Fix when a Split Tag Text element Inner Text start with " {" instead of "{"

@hieplenet 👍👍👍 Merged, and could we invite you to our team?


Openssl genrsa numbits issue

Hy,
My issue is that there is a special function of openssl, named genrsa..it is special in the way how it manages one of its options, namely numbits. Quote from OpenSSL docuemntation:
"numbits
the size of the private key to generate in bits. This must be the last option specified. The default is 512."
Seeing how this does not work with the following syntax: openssl genrsa -numbits 2048 or openssl genrsa -2048, only accepting the syntax openssl [options] 2048, I think the library should be updated to support this particular case. An optional workaround is to use openssl genpkey, but I think the former should also be supported!
Thank you!

openssl('genrsa', {des3: true, passout: pass:${password}, '2048': false})

mgcrea, this does not work.
Javascript does not ensure key-value order in objects. But 'numbits' argument for 'genrsa' must be the last. If it is not, '-out' option doesn't work and key generated into stdout instead of file.


Item Display UI: 360 images

360 items may persist alone or paired with still images in the DAMS interface. When paired with still images, 360 should be first thing shown in the item navigation thumbnails and marked by an icon. The 360 view of the item should begin with spin enabled by default to signal to the user that the image moves/is interactive.
For product/object imagery, there should be three buttons: a spin/pause button and a forward/backward button. The user may also click and drag to move the item.

When 360 spin in enabled, the pause button shows. When pause in enabled, the 360 spin button shows.
(I'm not sure what our 360 space/room view solution is, plugin or internally built, but if internally built the interface may also function in the same way -- its really the same experience from a user interaction perspective -- one is a spherically wrapped image and the other is a set of images, but the controls and method of interacting don't really change. Clicking the spin button for a room should reset the view for the viewer as well.)
For any type of 360 image -- space or object -- a 360 interface should be marked in the item list by the 360 icon.

The icon's black and white combo make it easily visible no matter the background color -- same for the control buttons on the 360 image. Example on black with the image paused in order to show the 360 icon in the controls:

Other examples of list item demarcated instances can be seen in Issue UCDavisLibrary/fin-server#138; more information on icons in UCDavisLibrary/fin-ucd-lib-server#3.

This is deferred due to priority setting - will re-hydrate at an appropriate time in the future.

This is deferred due to priority setting - will re-hydrate at an appropriate time in the future.


Pipe V2: don't create a salesforce pipe by default anymore

Since we now support multiple pipes, we shouldn't assume the user wants to create a SalesForce pipe

resolved


Installation improvements

Here are two ideas, explained in details in the commit descriptions, to improve a bit the installation process.
Let me know what you think :ok_hand:

@rdubigny updated my commit to remove the postinstall stuff, only added a script to easily build all assets and mentioned it in the docs

Obsolete now that the assets handling is changing with #489


nanoc show-data doesn’t show dependencies from @items

Steps to reproduce

Create a layout that pulls in some other items with @items[item_identifier_string] or @items.find_all(some_item_glob).
Use that layout in two or more items.
Run nanoc show-data

Expected behavior
show-data should list all the dependencies for all of the items.
Actual behavior
show-data lists the dependencies for one of the items using that template. The other items are listed as depending on (nothing).
Details
Unsure if this is related or not, but the values given to @items originates from an @item property.  E.g. @items.find_all("{#{@item[:array_of_item_identifiers].join(',')}}") or @items[@item[:thumbnail_item_identifier]].
Despite not showing in show-data, the dependency tracking works most of the time. Sometimes need to run compile a second time for an item using such a layout will recompile.
Update 1: The recompilation issue seems to only affect item properties from items with meta files.
Update 2: Recompilation issue separated into separate issue #1454.

More minified way to reproduce:

Follow all the steps 1–6 in #1405
Run nanoc show-data

Should: index.html should depend on test.png. Actual: it doesn’t.

For your minified steps to reproduce, the <%= … %> ends up being copied as-is into output/index.html, because there is no filter :erb, and then show-data shows:
item /index.html depends on:
  [ layout ] (r___) /default.html

item /stylesheet.css depends on:
  (nothing)

item /test.png depends on:
  (nothing)

If I add filter :erb to Rules (matching index.html), and re-run show-data, I get
item /index.html depends on:
  [  items ] (r___) matching any of /test.png
  [   item ] (_a__) /test.png
  [ layout ] (r___) /default.html

item /stylesheet.css depends on:
  (nothing)

item /test.png depends on:
  (nothing)

which shows that /item.html does depend on /test.png.

I’m not able to reproduce it in a different way. Can you double-check the steps to reproduce?

I just ran nanoc show-data on a larger project and the same thing happen again. Changed nothing and ran it again and it didn’t happen. I just don’t know what causes it to happen and when.

It could be that #1493 is a fix for this — it’s definitely a related issue, but I’ve not been able to reproduce yours specifically.
Can you see whether Nanoc master works for you?

This is extremely elusive. I just saw this in a build with #1493. I can’t reproduce it on demand but it keeps happening from time to time.


Missing h11 dep?

Installing an editable package with pip wants to install h11 in the quetz environment - maybe it needs to also be specified in the environment.yml file?
Collecting h11>=0.8
  Downloading h11-0.12.0-py3-none-any.whl (54 kB)

Hmm, not sure if we should add it or wether it's a dependency of ours that needs to add it to their meta.yaml?

That's odd - it doesn't seem to be used directly here 🤔
If it were a dep of anything in the environment.yml it would have been installed so I'm not sure what's pulling it in...

Looks like a dep of httpcore which is a dep of httpx. Not sure why mamba env create -f environment.yml wouldn't install a version pip was happy with though.
In any case, nothing to do here...


nixos/sway: Improve the wrapper

Port a change by @primeos from sway-beta module to sway module.
https://github.com/NixOS/nixpkgs/pull/51316
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@primeos Thanks!


Google maps is a bad example of use. Allow alternative such as OSM

Due to the commercialization of using google api cards, please make an alternative to google maps, for example OSM (OpenStreetMap).
$ 7 for every 1000 map downloads makes it difficult to use their technology on a less visited site.
Charges for the use of maps are simply huge ...

Hi there,
Very good question! I already investigated for alternative maps, in order to offer different map providers in the software.
However, right now there is no plan for implementing an alternative map because of lack of time.
If there is an awesome developer here 💪, feel free to implement an alternative map to pH7CMS, and open a PR. I will be pleased to review it 😊
Note: From v14.8, I added the possibility to disable the "maps" features (admin panel -> Mods -> Enable/disable modules -> uncheck "Google Maps"). So you won’t have broken maps if you didn’t setup a billing account at your Google API account. This might be a solution for you...
Hope this helps! 🤞 And welcome to the community! 🎉
P.S. I think, your subject "Google is a bad example of use" looks wrong to me...
Before, Google Maps was number one for maps. It was by far the best (and it is still the best map service available on the market!). It didn’t even required an api key before June 2016.
That’s why "Google Maps was the first choice.
Now, I can agree with you that it might not be the best choice for people who just start and are not willing to pay if they exceed 25,000 free requests per day (but 25,000 requests is still a lot, before you sill have to pay per request).

Hi there! @pH-7 where can I find the Google Maps code? Maybe I can have a look at it later this week.

@yuri25 Here https://github.com/pH7Software/pH7-Social-Dating-CMS/tree/master/_protected/framework/Geo/Map
You will have to create a new dedicated class for it.
Then, the maps are displayed in two different places:

https://github.com/pH7Software/pH7-Social-Dating-CMS/blob/0207b9f21dcc638db5eff1289ce4e1144d3035e4/_protected/app/system/modules/map/controllers/CountryController.php#L118-L126
https://github.com/pH7Software/pH7-Social-Dating-CMS/blob/32ddb2d38c1e7482b6759cfc27187f3ad7d5162f/_protected/app/includes/classes/ProfileBaseController.php#L134-L142

Awesome if you could do it 💪

Hi there,
Very good question! ( ... )
Thank you for your suggestion anyway 😀 Highly appreciated!

Hi, I#m trying to configure the Google API, I know that there is free request, but still giving that message, “For development purposes only” ... I could find some topics about it, but it looks like Google ask a Billing Address or a Credit Card to allow a minimum free usage, is that correct, or have any possibility to allow the minimum free usage without a billing address or billing account...???


Need to use code to determine game room and position

This is will make the game more manageable

Multiple room is supported now. position is something players can work out offline


[drivers] * remove unused files about lslidar driver

remove tmp debug files

@mickeyouyou Could you do a git pull --rebase upstream master before commit for later PR?

OK get it . thank you so much for reminding @Capri2014


JSON Schema is not OpenAPI

Behavior is inconsistent and broken when attempting to validate against OpenAPI specific syntax.

@larrydewey Could you provide example?

There are a number of things which are not the same. You can read about a number of them in a blog by the developer of openapi.
The tl;dr is OpenAPI v3.0:

type's cannot be an array.
type's cannot contain null as an option in openapi
nullable is not supported in JSON schema, but is required for openapi
You may only provide one example. JSON Schema allows an array of examples.
There are more formats which may not be compatible.

While there are more edge cases, they are found by trying to use the two together.

All those cases are covered now hence closing.


Add Nexus APIs to the Temporal Go SDK

Part of the ongoing effort to integrate Nexus RPC into Temporal.
Rendered

Short update: We're going to add a "service" concept that's a grouping of operations and rename the current "service" concept to "endpoint".
This change has to start from the Nexus API spec and Go SDK and then come into this proposal.
I'm putting this one on hold until we have the prerequisites in place.


Buffer Overflow

The function ShiftLeft() in charconv_bigint.h writes outside the bounds of words_ on line 113, which could corrupt data, cause the program to crash, or lead to the execution of malicious code.The program writes outside the bounds of allocated memory, which could corrupt data, crash the program, or lead to the execution of malicious code.

Line 113 doesn't write anything at all:
https://github.com/abseil/abseil-cpp/blob/1e3d25b2657228bd691ee938cfd37d487f48054b/absl/strings/internal/charconv_bigint.h#L113
I took a look at the function and couldn't figure out where the out-of-bounds write you are talking about is. Can you please share a test case that causes an out-of-bounds write?
@vslashg

I'm assuming this might be the copy_backwards on line 112.  I'm digging into it and seeing if I can spot the problem.
If you have any reproduction steps, that would be appreciated.

I added some more unit tests for ShiftLeft(), hoping to reproduce the out-of-bounds access, but the test is still passing under ASAN for me.
I don't doubt that you may have found something, as all of this code is rather young, but I don't have any ideas how to proceed.  Any details as to what you've found would be greatly appreciated.

372081

__

غ


delete obsolete classes: BamToBfq, ConvertSequencingArtifactToOxoG

these classes are no longer needed, as confirmed by @nh13 .

closing. the list is being revised now.


ProgressRing progress inconsistency

As shown in the xaml controls gallery, the ProgressRing does not fill consistently (with 'IsIndeterminate=False').
When the progress is set to 100 or 99, it shows like this:

Changing the value to 98 or 97 makes a huge difference:

Changing the value to 96 and below is consistent:

I would expect to have half a bar left at 50, but instead it's well over:

If this is expected behavior, then I would like to propose a 'IsAbsolute=true' property. I'm using the ProgressRing for a countdown timer and it looks very weird.

Unfortunately, this is a known bug with ProgressRing that is being tracked by #3787.

closed as duplicate.


Resizing a panel sometimes gets stuck dragging forever

Describe the bug
When you start resizing a panel, the mouse sometimes changes to drag and drop cursor instead of staying on the resize cursor. If this happens, releasing the mouse no longer stops the drag operation, and the divider will continue following the mouse until you click again. Seems like a native drag and drop event is not being cancelled or something. This happens maybe 1 in 5 attempts to resize, although sometimes it doesn't happen at all and other times it happens on almost every attempt.
I mostly see this in Chrome although it does happen less frequently in Firefox. Seen on both Windows and Ubuntu as well.
To Reproduce

Mouse down on any resizable panel border
Move mouse
Get unlucky

Expected behavior
Resize operation should stop when the mouse is released. Resize mouse cursor should be displayed the whole time.
Environment:

Chrome 112.0.5615.138, Firefox 112.0.2
Windows 10, Ubuntu 18.04

Screen Capture
This screenshot shows the drag-and-drop cursor that appears when this bug happens.
The video shows the drag operation getting stuck. Enable audio to hear when the clicks start and stop:

Recording showing the broken drag occurring twice.

Good news! I think I found a workaround. I noticed when getting stuck in drag mode, I could see the title of one of the panels very faintly, moving around with the mouse:

This made me think the entire panel element was being dragged. I added the following CSS rule and have been unable to recreate the bug since. Note that both selectors seem to be required, otherwise it occasionally reproduces, so I guess both of these elements are sometimes getting selected.
.split-view-container .view-container .view, .groupview {
  user-select: none;
}

Realized that the previous CSS rule was breaking all text selection inside the panel, which is obviously not ideal. Worse, re-enabling user-select: auto on any child element seemed to break the whole thing and the bug came back. Finally I figured out that it just needs to be applied to the drag handles themselves:
.split-view-container .sash-container .sash {
  user-select: none;
  -webkit-user-select: none; /* Safari */
  -moz-user-select: none; /* Firefox */
  -ms-user-select: none; /* IE 10 and IE 11 */
}

This appears to fix the bug as well as preserve normal selection of panel content.

Thanks for the detailed description and the attempt to fix it too!
I just checked this out by adding a global drag listener to check what was actually being dragged here, something like:
document.addEventListener('dragStart', (e) => {
    console.log('drag', e)
});

and yes it seems that the sash element is unintentionally entering a drag state occasionally as below. I think your analysis and fix is correct, great spot.

I will double-check a few things and aim to merge your PR and publish a fix version for this in the next day or two.
Thanks for finding the bug and the fix :)

This is now merged and published as v1.7.2

Awesome, thanks for the quick turnaround! Was really excited about using this library caus it's great. Glad the solution didn't end up being too complicated.


sst start single stack

Requested by Ryan in Slack
ie. sst start <stack>

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


redux-immutable support

Is seems that there is a problem with replacing reducer when using redux-immutable. Consider example:
import createLoguxCreator from 'logux-redux/create-logux-creator';
import { combineReducers } from 'redux-immutable';
const reducer = combineReducers({});

const createStore = createLoguxCreator({
  subprotocol: '1.0.0',
  server: 'ws://<IP_ADDRESS>:1337',
  userId: 10
});

const store = createStore(reducer);

This fails with error that ...previous state received by the reducer is of unexpected type. Expected argument to be an instance of Immutable.Collection or Immutable.Record... pointing to https://github.com/logux/logux-redux/blob/master/create-logux-creator.js#L155

Thanks for report. I will investigate it in the end of the week (sorry, really hard well because if moving to NY).

I started 0.3 where I plan to fix the problem by design

I think we version should support it


backup uptime.com checks

It shounldn't have any cred now

Did not find any auth related information anymore. But did you simply leave out the ones that had? How is the back up solved for those then?

@rstens I give all n8n test a seperate tag  called PUT where I will backup all of them in seperate pr. This backup is filtered by tag shared-services.


Cannot build applications with dts having (unused) external flash partition and disabling those drivers

Describe the bug
Seeing an issue with building mcuboot in zephyr whereby there is an external flash on QSPI which has a partition, lfs_partition, this partition is not used by mcuboot but the application fails to link unless the QSPI driver is enabled with an undefined reference to '__device_dts_ord_133' error, which is in default_flash_map. This leads to a complete waste of flash space by requiring completely unused flash drivers be enabled in builds.
If the lfs_parition part of the dts is commented out, the application builds without failing to link.
To Reproduce
Build mcuboot (or any application with a flash driver) which has an unused flash partition in an external device and build it with the flash driver for that partition disabled.
Expected behavior
Application to build without needing unused flash partition drivers
Impact
Annoyance, waste of resources
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK 0.14.2
Commit SHA or Version used: 0baf45f00af7296caa089e02e75193ae4c2ae08c

@thedjnK, it is possible to remove the driver while building for mcuboot by supplying a dts overlay file that deletes the lfs-partition node.

@thedjnK, it is possible to remove the driver while building for mcuboot by supplying a dts overlay file that deletes the lfs-partition node.

I did try this for a while and was not able to get it working, just tried it again and it is working so must have made a mistake previously.

@de-nordic  can you please take another look?

@de-nordic can you please take another look?

@nashif  The issue is there. It appeared when we have switched to device macros.
The Flash Map creates entry for every partition that is visible in DTS and attaches device to it, so it requires device driver to be compiled in. At this point Zephyr does not provide a method to match driver enabling Kconfig to DT node, which means that we have no way to just not include references to devices that will not be there, because their drivers will not be linked.
I am currently working, again, at dropping the Flash Map in current form, but the work requires significant modification on the side of MCUboot and Zephyr and takes time.


The text works perfectly on iOS, but on Android, the  code makes all the components disappear.

Hi, I'm trying to use Text Ticker for my Android and iOS apps using Expo. TextTicker works fine on the iOS simulator (XCode), but when I try to run my code on my Android tablet, all icons, names, and TextTicker are disappearing. Here is my code along with screenshots from the iOS XCode Simulator and the Android tablet.
Has anyone else encountered the same problem and found a solution for it?

`<TextTicker
// style={{ fontSize: 50 }}
duration={9000}
loop={true}
// shouldAnimateTreshold={100}
animationType={'bounce'}
// bounce
repeatSpacer={10}
marqueeDelay={1000}

Super long piece of text is long. The quick brown fox jumps over the lazy dog.
`

Did you find a solution to this ?


SVG pictograms downloaded from the Carbon website are missing stroke/fill.

SVG pictograms downloaded from the Carbon website are not rendering correctly.
Seems related to https://github.com/carbon-design-system/carbon/issues/6107 and https://github.com/carbon-design-system/carbon/pull/6109, but we’re seeing this issue again today.
Detailed description
Downloaded pictograms from the pictogram library are missing color values. Upon brief investigation, it appears that stroke that was included in previous downloaded SVGs are not included in the current downloads. Adding the stroke color back seems to address the issue for our team members.
Our analysts reported that pictograms they downloaded last week were working as expected, but today they were “blank.”

Previously behavior
Current behavior

What browser are you working in?
Analyst and I were using Firefox and Chrome respectively and were both able to reproduce the issue.

Chrome 83.0.4103.61.
Steps to reproduce the issue

Access Carbon design system pictograms
Download the pictogram (Video was one of the pictograms in question but issue seems to affect all pictograms we’ve tried) using Download SVG button.
Open SVG in browser, Powerpoint, or Sketch.
SVG appears without a set/default stroke color.

Additional information
Seems like this should have been addressed https://github.com/carbon-design-system/carbon/issues/6107 and https://github.com/carbon-design-system/carbon/pull/6109, but we’re seeing this issue again today.

This should be resolved.


Add driver's available drive times to rider confirmed match information in self-service portal, email and SMS notifications

This is useful information for the rider as a starting point for a conversation with the driver.

This may be possible for the self-service page prior to mid-terms, otherwise it's after that. Or, less relevant due to the role of operators

Done for self-service portal


tests(issue-28): Introduce code coverage

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Add chi version

As discussed outside Github with @meshenka : this version does a lot more than the two others, while the goal is to have parallel demos, as closed to each other as possible.


subtitle

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

i tried downloading several videos with the subtitles in this manner :
for link in \
    https://www.youtube.com/watch?v=J3fcHxHw-gw \
    https://www.youtube.com/watch?v=aQkip0MbR9k \
    https://www.youtube.com/watch?v=kMq5mF7dry0 \
    https://www.youtube.com/watch?v=5Sa20gEeaNo \
    https://www.youtube.com/watch?v=C7OQHIpDlvA;
do
    youtube-dl --restrict-filenames \
        --write-auto-sub \
        $link
done

but their subtitles are in one big lump, not having the segment time stamps.
How to get them in their proper time stamps format ?
for example for the first link (https://www.youtube.com/watch?v=J3fcHxHw-gw)
Expected a proper segmentation with sentences in bigger chunks of time
WEBVTT
Kind: captions
Language: en

00:00:00.000 --> 00:00:05.430 align:start position:0%

um so i'm 40 this year

00:00:05.440 --> 00:00:09.180 align:start position:0%

yes  i did think of  being a businessman

00:00:09.180 --> 00:00:09.190 align:start position:0%

since i was a little  kid

...

But i got a lump of all the transcripts (700 words) and random timestamps after that
WEBVTT
Kind: captions
Language: en

00:00:00.000 --> 00:00:05.430 align:start position:0%

[Music]  do  [Music]  um so i'm 40 this year and  it's a yes and no answer  yes  i did think of  being a businessman since i was a little  kid and in fact until i was five i  couldn't speak
<super long transcription with 700 words>
thanks so much  i don't have a favorite korean drama i  don't watch korean dramas  but my wife does  [Music]  you

00:00:05.430 --> 00:00:05.440 align:start position:0%

00:00:05.440 --> 00:00:09.180 align:start position:0%

00:00:09.180 --> 00:00:09.190 align:start position:0%

...

fixed in https://github.com/ytdl-org/youtube-dl/issues/30710 ?


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit 6fc5ad7:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2019-11-21-02-31-21 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2019-11-21-02-31-21

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Feature/directory updates

This PR implements the following tickets:
192960 - View Role details (UI only pending back-end)
192961 - Add role as favourite (UI only pending back-end)
194709 - View service details (UI only pending back-end)
194715 - Add service as favourite (UI only pending back-end)
199736 - View media in gallery (UI only pending back-end)
207522 - Dialler functionality (UI only pending back-end)
NOTE: This PR contains UI implementations and connectivity to a 'faux' back-end.  For example, the Media Gallery function is coded to connect to a room and display the media in that room (as per the final implementation) but as there is no per-user media room as yet this function is hard-coded to a test room we have configured. The tickets above will be returned to Dev to complete the final implementation once the respective back-end functions become available.
The branch is based upon act-master.
This branch will build on Xcode 12 / iOS 14.
Pull Request Checklist

[x] I read the contributing guide
[x] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
-Noting there is no change currently in the display behaviour between those two settings as per requirement.
[x] Pull request is based upon act-master from the Pegacorn repo.
[x] All new and existing unit tests pass successfully in this branch.

All comments updated in latest commit 23e772bc.
I also snuck in the change that points this build to the new Lingo test server, so that we can push out a TestFlight build sooner rather than later with the new server.


fix(scale): return error message in proper format

Summary of Changes
Handle the case of validation error instead of value error as it value error re-thrown as validation error in the validate function.
Issue(s) that this PR Closes
fixes #831
Associated End To End Test PR(s)
Associated Documentation PR(s)
Associated Design Document(s)
Testing Instructions
Please provide a detailed list for how to test the changes in this PR.

Create a Deis Cluster
Register an app
Try to call the scale endpoint as mentioned in the #831 and you should get a proper json error response.

Pull Request Hygiene TODOs
Please make sure the below checklist is complete.

[x] Your pull request is concise and to the point (make another PR for refactoring nearby code)
[x] Your commits are squashed into logical units of work
[x] Your commits follow the commit style guidelines

:cherry_blossom: Thank you! :cherry_blossom:

can we add some unit tests here to validate this?

We could embed the "invalid scaling format" as part of the actual error message so that we don't have a string + list and instead just get a list. Thoughts?

ah wait that might be hard since we are transforming ValidationError into a DeisException...

[Current coverage][cc-pull] is 86.81%

Merging [#844][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.07%

@@             master       #844   diff @@
==========================================
  Files            30         30
  Lines          2723       2723
  Methods           0          0
  Messages          0          0
  Branches        448        448
==========================================
- Hits           2366       2364     -2
- Misses          236        237     +1
- Partials        121        122     +1

Powered by Codecov. Last updated by [c65c508...dc2a946][cc-compare]
[cc-base-branch]: https://codecov.io/gh/deis/controller/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/deis/controller/compare/c65c5083104780c3d7c5993a23dc7fdb9b2bf4b9...dc2a9466a763efa45872f23ca9ee26cabebf61c3
[cc-pull]: https://codecov.io/gh/deis/controller/pull/844?src=pr


monorepo docs on eval details and prefetch user

🚀 Deployed on https://6627179d2a8f7570963e4860--cozy-fox-0defec.netlify.app


thredds browser error and MODE JOURNAL

Reported by ansley b manke on 23 Aug 2011 20:13 UTC
If MODE JOURNAL is turned off, then USE/BROWSE hits an error
yes? cancel mode journal
yes? use/browse
At line 123 of file split_list.F
Fortran runtime error: Bad unit number in OPEN statement

Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1878

Comment by ansley.b.manke on 2 Sep 2011 18:06 UTC
This is fixed in gnl/get_dataset_name.F
check for mode journal before writing to that unit number.


Search - Room mention in the message is not highlighted or linked when opened from Search

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to a room.
Send a message containing #room mention.
Go to Search.
Go to Chat.
Click on the message sent in Step 3.

Expected Result:
The room mention in the message will be highlighted and linked when opened from Search.
Actual Result:
The room mention in the message is not highlighted or linked when opened from Search.
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/3ecc3011-db2d-4952-8058-9b7671a84c39

View all open jobs on GitHub

We think that this bug might be related to  #wave-control

@slafortune  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
The room mention in the message is not highlighted or linked when opened from Search.
What is the root cause of that problem?
Currently, here the values of currentReportIDContext and currentReportID?.currentReportID are both -1 because we are not adding enough Provider and passing the correct reportID in the Search Page, which is why the value of isGroupPolicyReport is false, and we will not show the highlight for that message.
https://github.com/Expensify/App/blob/b0ce2068ee57c252ec47aa1f09319eee8b4f673c/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx#L63
What changes do you think we should make in order to solve the problem?

We should add MentionReportContext.Provider for items and pass in the value mentionReportContextValue like we did here with
    const mentionReportContextValue = useMemo(() => ({currentReportID: report.reportID}), [report.reportID]);

We can add this provider to ChatListItem here to highlight text in list all chats

https://github.com/Expensify/App/blob/b0ce2068ee57c252ec47aa1f09319eee8b4f673c/src/components/SelectionList/ChatListItem.tsx#L82

Also add this provider to ReportActionItem here

https://github.com/Expensify/App/blob/b0ce2068ee57c252ec47aa1f09319eee8b4f673c/src/pages/home/report/ReportActionItem.tsx#L905
What alternative solutions did you explore? (Optional)
NA
https://github.com/user-attachments/assets/0c9006bb-6de2-4e27-bdbe-5bc642e6bcfa

@nkdengineer's proposal looks good to me.
🎀👀🎀 C+ reviewed

@nkdengineer's proposal looks good, green light to go forward with the PR

@mjasikowski please assign me to this issue so i can open the PR

@situchan Can you please complete this checklist?

This was not a regression but missing case while implementing Search v2.2 - chat type in search.
I think we'll add comprehensive regression tests after search project is done so no action required here.

@situchan Role - C+ - Paid $250 Via Upworks
@nkdengineer Role - Contributor - Paid $250 Via Upworks


About how the hmdb51 and ucf101 dataset is divided into training part and test part

Thanks for your great work !
In the experiment, you have done the experiment of hmdb51 and ucf101 dataset and presented the results in the paper, but in mmaction2/tools/data/skeleton/README, unlike other datasets will be divided into train and val parts. When I studied the provided hundb.pkl and ucf101.pkl I found that although there are points 'spilt' and 'annotations', in 'spilt', there are only characters train1, train2, train3, test1, test2, test3. So I don't know how the two datasets are divided into training part and test part.

Hi, HaleYan, for UCF101 and HMDB51, we use the official split released with the original dataset. Please refer to the original paper of these datasets to get the split information.


Make submit URLs /projects/NUMBER not /projects/NUMBERedit

The submit form accidentally had the word "edit" after the
project number because of how the form helper was used.
It doesn't matter because the extra text is ignored,
but it looks odd, and we want to keep everything clean.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

Great! I'd noticed this in the past but didn't know how to fix.
LGTM.


Could the global dictionary be put under $XDG_DATA_HOME as well?

Right now the global dictionary is in $XDG_CONFIG_HOME/harper-ls - but it's not really a configuration file. The per-file dictionaries are (correctly, IMO) in $XDG_DATA_HOME/harper-ls/file_dictionaries. Could the global dictionary be moved under $XDG_DATA_HOME as well?
Thank you for an amazing utility.

I see that the global dictionary can be viewed as internal data generated by harper, and belongs in  $XDG_DATA_HOME. I think the global dictionary can also be viewed as user configuration: it is a list of words that I use intentionally, and while harper manages this list for me I could just as easily see setting it as an array in a configuration file. My mental model (which is definitely personal opinion) is that configuration is something I want to add to my dotfiles and take with me to a new system, and the global dictionary falls into this category for me.
I don't mind much either way because both are easy to work with, but wanted to give a different perspective.
And I fully agree with @sbromberger, thank you for the great tool!

Sorry to get back to you so late, things in the project have been pretty chaotic.

Could the global dictionary be moved under $XDG_DATA_HOME as well?

I see two possible interpretations of this question.

You want to move your global dictionary to $XDG_DATA_HOME.
You think the default should be $XDG_DATA_HOME

I'll consider 2, but I don't think it makes a lot of sense. @drewgingerich has described precisely the intention behind it. The global list can be viewed as configuration and many Harper users (including myself) check it into their dotfile repositories.
If you just want to do 1, there's a configuration option (although it doesn't resolve environment variables on its own).
Just change userDictPath to whatever file you want.
Here's an (untested) Lua snippet that might do what you want:
lspconfig.harper_ls.setup {
  settings = {
    ["harper-ls"] = {
      userDictPath = os.getenv("XDG_DATA_HOME") .. "/dict.txt",
      fileDictPath = "~/.harper/",
    }
  },
}

If that doesn't answer your question, please confirm what editor you're using. If does, go ahead and close this ticket and have a happy new year!


e2e: refactor grandpa test ibc transfer to use suite.transfer

Description

closes: #4963
Commit Message / Changelog Entry
type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

this test currently fails because the sent tokens do not end up arriving in the parachain user's account. on hold until the relayer/parachain images stabilise.

Is it possible now to complete this PR?

Is it possible now to complete this PR?

bump (doing some PR housekeeping)! @charleenfei

closing pr as stale as it targets the wasm feature branch


Cross compilation

My platform is: windwos10 X64 mingw64
SET CGO_ENABLED=0
SET GOOS=linux
SET GOARCH=amd64
go build main.go

# github.com/go-vgo/robotgo
C:\Users\pxlol\go\src\github.com\go-vgo\robotgo\robotgo_mac_win.go:13:2: undefined: internalActive

Closing is due to duplicate ( #143 ), Will reply in #143.

Because the code has cgo, SET CGO_ENABLED=0 is invalid.


Bug when serializing optimizer with tf.keras.utils.serialize_keras_object but works fine with tf.keras.optimizers.serialize

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.2.0-rc4-8-g2b96f3662b 2.2.0
Python version: 3.8
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version: NA
GPU model and memory: NA

Describe the current behavior
I have provided two code snippets for serializing and deserializing Keras optimizer. One of them works and other doesn't.
Describe the expected behavior
Both the code snippets should work.
Standalone code to reproduce the issue

For your quick reference, I provide here the two code snippets
Snippet 1 - does not work
import tensorflow.keras as tk
opt = tk.optimizers.Adam()
opt_ser = tk.utils.serialize_keras_object(opt)
opt_deser = tk.utils.deserialize_keras_object(opt_ser)
print(opt_deser)

Snippet 2 - works
import tensorflow.keras as tk
opt = tk.optimizers.Adam()
opt_ser = tk.optimizers.serialize(opt)
opt_deser = tk.optimizers.deserialize(opt_ser)
print(opt_deser)

I have tried in colab with TF version 2.2, nightly and was able to reproduce the issue.Please, find the gist here.Thanks!

@SpikingNeuron  Was able to replicate the issue using TF 2.5 but error message has been given clearly how it should be passed.
Could you please check the gist and confirm if we can go ahead and close the issue. Thanks!

The error says ValueError: Unknown object: Adam.
But the Adam object is inbuilt.
If you think that should not be an issue and users can understand that they still need to use the custom_objects argument for builtins then please close the issue.


Fix various state state inconsistencies of DecoupleableInterpolatingFramedClock

Resolves #1633
Fixes #1634
Blocked awaiting osu!-side testing.

Looks fine on osu!'s end, even after removing the PauseContainer schedule.

gah. This is what I was trying to fix with part of #1590 but I never got a response if the old functionality was intentional

I saw that, and that's what led me to this path. I needed to have the adequate testing in place because there was a reason we didn't do this in the past - start/stop used to be non-blocking.

Oh ok, and isRunning would change immediately and not on completion?
In this implementation, the DecouplableClock doesn't seek to the same time if the source isn't running and the source seeks to some new position (and they're coupled). Not sure if that's something you want or not, or if that would cause bugs

Yeah I discussed this with @peppy, and we reached the conclusion that since Decoupled.Start() will seek the clock to the source time (which is something we definitely want), seeking the source clock should be an unsafe operation.
Ideally we'd disallow the possibility of seeking the source clock but I can't think of a neat way to prevent that.

Seems to work no worse than before 👍


yamup and meteor 2.5

Hi there
I'm trying to run awesome yamup on current meteor 2.5.3 but it fails. I have used it all the time with all meteor version and it worked with 2.1 just fine. I'm using meteor's node version 14.18.2 in yamup setup. Maybe the problem is somewhere else? I thought node-fibers is no longer in use for meteor? I even created a new, blank meteor project but deploy also fails.
yamup deploy returns this:
Invoking deployment process: FAILED

        -----------------------------------STDERR-----------------------------------
        f you
        would like to compile fibers on this machine please make sure you have setup your
        build environment--
        Windows + OS X instructions here: https://github.com/nodejs/node-gyp
        Ubuntu users please run: `sudo apt-get install g++ build-essential`
        RHEL users please run: `yum install gcc-c++` and `yum groupinstall 'Development Tools'`
        Alpine users please run: `sudo apk add python make g++`
        sh: 1: nodejs: not found
        npm ERR! code ELIFECYCLE
        npm ERR! syscall spawn
        npm ERR! file sh
        npm ERR! errno ENOENT
        npm ERR! fibers@https://github.com/meteor/node-fibers/archive/refs/tags/5.0.0-1.tar.gz install: `node build.js || nodejs build.js`
        npm ERR! spawn ENOENT
        npm ERR!
        npm ERR! Failed at the fibers@https://github.com/meteor/node-fibers/archive/refs/tags/5.0.0-1.tar.gz install script.
        npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

        npm ERR! A complete log of this run can be found in:
        npm ERR!     /root/.npm/_logs/2022-01-25T12_55_49_558Z-debug.log
        -----------------------------------STDOUT-----------------------------------

        > fibers@https://github.com/meteor/node-fibers/archive/refs/tags/5.0.0-1.tar.gz install /opt/meteor/tmp/bundle/programs/server/node_modules/fibers
        > node build.js || nodejs build.js

Any help appreciated!

Can it be related to #13?

Probably, yes. Error message suggests that something is messed up. I will try again with clean installs.

Yes everything works fine now with Meteor 2.5 :-) The only important thing one has to do is to enter the correct nodeVersion in yamup.json - output from meteor node --version. In my case 14.18.3.
Thanks

@quape I had some issues with meteor 2.5.6 so I made some changes: 8d114fbf
Please update yamup to 0.8.3

Thanks!


Particles Keep Growing

Are you using tsParticles latest version?

[X] Yes
[ ] No

Which library are you using?

[X] Vanilla JS (tsparticles)
[ ] React (react-tsparticles)
[ ] Vue.js 2.x (particles.vue)
[ ] Vue.js 3.x (particles.vue3)
[ ] Angular (ng-particles)
[ ] Svelte (svelte-particles)
[ ] Preact (preact-particles)
[ ] Inferno (inferno-particles)
[ ] jQuery (jquery-particles)

Issue:
When I leave the particles idle in the background for a few minutes (~10minutes) the particles (originally ~5px) are HUGE (around 100px).
It looks like they keep always growing larger infinitely.
I'm using Nuxt.js
I wonder if it's something about these parameters:
              "resize": true,
              "onhover": {
                "enable": true,
                "mode": "bubble",
                "parallax":{
                  "enable":true,
                  "force":100,
                  "smooth":6
                }
            }

Here is the website with this issue and below the full Javascript code:
<script>
import { tsParticles } from 'tsparticles'
/* eslint-disable */
export default {
  data () {
    return {
      id: 'particles-instance-' + Math.floor(Math.random() * 5000)
    }
  },
  mounted () {
    const tsParticles = require("tsparticles")
    this.$nextTick(() => {
      this.initParticleJS()
    })
  },
  methods: {
    initParticleJS () {
    tsParticles.load(this.id, {
          "particles": {
            "number": {
              "value": 60,
              "density": {
                "enable": true,
                "value_area": 800
              }
            },
            "color": {
              "value": "#ffffff"
            },
            "shape": {
              "type": "star",
              "stroke": {
                "width": 0,
                "color": "#000000"
              },
            },
            "opacity": {
              "value": 0.8,
              "random": true,
              "anim": {
                "enable": true,
                "speed": 12.0,
                "opacity_min": 0.6,
                "sync": false
              }
            },
            "size": {
              "value": 2,
              "random": true,
              "anim": {
                "enable": true,
                "speed": 0.3,
                "size_min": 1.,
                "sync": false
              }
            },
            "line_linked": {
              "enable": true,
              "distance": 60,
              "color": "#ffffff",
              "opacity": 0.7,
              "width": 1.5
            },
            "move": {
              "enable": true,
              "speed": 0.5,
              "direction": "none",
              "random": true,
              "straight": false,
              "out_mode": "out",
              "bounce": false,
              "attract": {
                "enable": false,
                "rotateX": 0,
                "rotateY": 0
              }
            }
          },
          "interactivity": {
            "detect_on": "canvas",
            "events": {
             "onDiv": [
              {
                "enable": true,
                "selectors": ".titlespace",
                "mode": "bounce",
                "type": "rectangle"
              },],
              "resize": true,
              "onhover": {
                "enable": true,
                "mode": "bubble",
                "parallax":{
                  "enable":true,
                  "force":100,
                  "smooth":6
                }
              },
              "onclick": {
                "enable": true,
                "mode": "push"
              },
              "resize": true
            },
            "modes": {
              "grab": {
                "distance": 400,
                "line_linked": {
                  "opacity": 1
                }
              },
              "bubble": {
                "distance": 250,
                "size": 6,
                "duration": 2,
                "opacity": 0.9,
                "speed": 3
              },
              "repulse": {
                "distance": 400,
                "duration": 0.4
              },
              "push": {
                "particles_nb": 1
              },
              "remove": {
                "particles_nb": 2
              }
            }
          },
          "retina_detect": true,
          "pauseOnOutsideViewport":true
        }).then((container) => {
    console.log("callback - tsparticles config loaded");
  })
  .catch((error) => {
    console.error(error);
  });
    }
  }
}
</script>

Thanks for reporting the issue, I'll inspect that as soon as possible.
I can't follow your website link because it asks me to register on Vercel. But I'll set a sample on CodePen to checkout.
By saying idle in the background, you have the website with particles not visible right?

I can't follow your website link because it asks me to register on Vercel. But I'll set a sample on CodePen to checkout.

Sorry, I've posted the wrong link. My mistake!
Here it is: https://readmystar-79ak9k97y.vercel.app/

By saying idle in the background, you have the website with particles not visible right?

My website has visible particles.

How to reproduce the issue:

Open the browser (Firefox)
Go to website
Let the tab opened for a few minutes (you can even navigate in other tabs in the meanwhile)

Unexpected Behavior

The particles grows to a large size (10x bigger).

Have you tried with the version 1.18.11? It should contain the fix


docs: displaying environment variable as code snippet

Added the markdown syntax to the singular environment variable in the README.md not displayed as a code snippet to be displayed as one, increasing readability.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Same change as https://github.com/aws/aws-lambda-runtime-interface-emulator/pull/57 with a more specific commit message, that PR can be closed after this is merged.

Closing in favour of https://github.com/aws/aws-lambda-runtime-interface-emulator/pull/57

Merged in #57


Use cibuildwheel and update grpcio

What was changed
Use cibuildwheel in CI now and update grpcio package.
Why?

Need cibuildwheel at least for its Linux docker capabilities
grpcio made a new release to fix its bad wheel naming for macOS arm builds

Checklist

Closes #10

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


When user is not logged in she gets an error instead of login button

This is admittedly a corner case, somewhat.
A user has a bookmark to https://superset.mydomain.org/chart/list/
When she tries to access this page BUT is not logged in (maye she logged out, or changed browser or whatever),
she gets an awful error.
A probably better solution would be to redirect to https://superset.mydomain.org/superset/welcome
Note that "Login" works, it's just confusing users
How to reproduce the bug

Login
Go to https://superset.mydomain.org/chart/list/
Bookmark
Logout
Open bookmark
See error

Expected results
redirection to the welcome page
Actual results
Error message
Screenshots

Environment

browser type and version: Chrome  97 or Firefox 95
superset version: superset version 1.4.0
python version: python --version 3.8.12
node.js version: node -v - not included in Docker image
any feature flags active:

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

Hey @squalou definitely not an ideal experience! But I will say this isn't strictly a "bug" because it's working as intended. If it's okay with you, I've added the "nice to have" label to this issue.

You're completely right, an annoyance, not a bug. Nice to have is fine.
Thank you!

cant reproduce on master, it correctly shows access denied and redirects to login page while keeping intended url in next parameter.

good news :)
I'll see what happens at next update.

Does anybody know in which version this was implemented?

facing same issue. was there a solution for the same?


Files not added to navigation

In the most recent version, adding a new .mdx file does not result in it being added to the site navigation sidebar when the file is added to a subfolder.

Hi @pearcircuitmike, do you still have this problem?

closing due inactivity

I have the same issue. Locally the navigation is fine, on vercel, it does not work


bundled_api macro fails on Windows machine, still works on linux, remote building on vercel works on both

I received this error when I try to build locally on my Windows machine with the new api bundling macro:
error: custom attribute panicked
  --> api/main.rs:16:1
   |
16 | #[bundled_api]
   | ^^^^^^^^^^^^^^
   |
   = help: message: `"api\\cron\\characters_db"` is not a valid identifier

error[E0425]: cannot find value `handler` in this scope
 --> api/main.rs:9:9
  |
9 |     run(handler).await
  |         ^^^^^^^ not found in this scope

Even though this error didn't show up in my linux machine with the same code, I've also tried cargo clean but no luck.
If I commit to git and let vercel builds for me, then it still builds without any issue

this is my vercel.json
{
	"outputDirectory": "public",
	"functions": {
		"api/main.rs": {
			"runtime"<EMAIL_ADDRESS>		}
	},
	"crons": [
		{
			"path": "/api/cron/write_characters_db",
			"schedule": "0 1 * * *"
		}
	]
}

Do you happen to have a reproduction repo and toolchain configuration? I'm not super familiar with Windows and I'm unable to build the crates at all due to singal-hook issues.


ERROR (Yajl::ParseError): lexical error: invalid bytes in UTF8 string

ERROR (Yajl::ParseError): lexical error: invalid bytes in UTF8 string.
          t_courses.json:\fstartedl+\b�\f�da\u0001:\u0011machine_name\
                     (right here) ------^

Same here

Okay, did not read the README, my bad.
"If you have binary or serialized data in your Redis database, the YAJL parser may not load your dump file because it sees some of the binary data as 'invalid bytes in UTF8 string'. If you are certain that your data is binary and not malformed UTF8, you can use the -n flag to redis-load to tell YAJL to not check the input for UTF8 validity. Use with caution!"


Best practice recommendations for saving trained networks

Hi Stefan,
do you have any recommendations for how to best store the trained networks when using the parameter estimation workflow notebook?
Best regards
Zijian

Hi Zijian,
you can just use the argument checkpoint_path when creating a Trainer instance.
Cheers,
Stefan

Thanks a lot!
Best regards
Zijian


fix: transform null arrays

See #137

Ok, I just saw this introduces some errors, I think you guys would know how to approach this in a better way. Closing.


Is version 0.13 published on NPM?

I can't see it on NPM. I'm getting warnings during the installation of packages:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

Duplicate of https://github.com/angular/in-memory-web-api/issues/10


subject upload limit

I have only 2828 subject uploaded but I get the upload limit notification when trying to upload more - this is likely cause due to me having previously uploaded and then deleted subject sets - so I may have 10000 uploads in total rather than 10000 active subjects.
Following that, if I deleted all my current subjects then I wouldn't be able to add any more and my project would have none. This leads me to think that it isn't the intention to have the limit be on the total number of subjects uploaded but rather on the number of currently active subjects.

Linked to https://github.com/zooniverse/Panoptes/issues/1037.
This is a know issue that we understand will cause problems. What was the reasoning as to why you were just uploading and removing subjects instead of reusing them? Just trying to figure out user behaviour, not an accusation.
@aliburchard can you PM @AdrianEvans to figure out a new custom limit.

I didn't realise the limit - I see it is in the policy document but adding a comment on the subject upload page would be good.
The reason was that I'd left 6000 uploading over night and then my computer went to sleep and as the site doesn't check for duplicates, and it isn't a very simple process to manually do that check I decided to change my upload strategy and start again. This time being very aware of what was and wasn't uploaded.

@AdrianEvans - thanks for the feedback. I agree that providing guidance and maybe hard limits on the uploader tool would help here.
Some liks, please comment on the open ticket, as your the person we want to hear from about this.
https://github.com/zooniverse/Panoptes-Front-End/issues/461
https://github.com/zooniverse/Panoptes-Front-End/issues/861
https://github.com/zooniverse/Panoptes-Front-End/issues/316
You can use the subject csv exporter (on your builder project page down the bottom) to get a list of subjects that exist.
Also see the discussion started here (again thoughts appreciated), #1120
I'm going to close this ticket as we've got this discussion already started in a few places, reopen if needed.


Generate op specs and package as resource

Extracts the op export part of #244 so that it can make its way into the snapshots.
Adds ~1.5MB to the 70MB native jars, so I don't think the size is an issue.
@karllessard can you add the CI build tag?

The CI's having issues w/ framework's javadocs again.

Thanks @rnett , interesting approach, let's give it a try with a full build

The build's failing b/c linux-mkl-gpu is running out of disk space.

I'm going to move the proto sources in this PR instead of #244, since we already have native builds going.


Is There A Way To Get Stream Mode on DesktopCamera

My Friend On Discord Wants Stream Mode but idk stream mode has disappeared or replaced camera
Did you Know How That Happen
Did it just Replace PC Camera as Quest Camera
or Forgotten Stream Mode With UI Mask I Think Users can See Quick Menu and they know how to turn it off within UI Mask
Thank You For Understanding
From:
aortiz294_bf99

Hey, sorry for the late response!
That change was made by Nirvash, in a PR, which I later on merged in.
And since they updated it, I gave them permissions to update this mod by themselves, and so you might also ask them if you want :3
Nirvash#0001

Ok thank you


Correct updating next matches

updateNextMatch() shoud handle Loser Brackets
Update.match() shouldn't have a updateNext argument anymore.
Add locked to match status. Must be default when to be determined and updated with scores.

Add locked to match status. Must be default when to be determined and updated with scores.

This is still to do.

Actually, when locked, a match could be pending or completed. Therefore, it shouldn't a be a possible status but another boolean property of a match.

This would be used to simplify checking if a match is locked, and for the viewer to be able to show the locked status without doing calculations.

The solution was to add more states to a match with its status. There are 6 states now:
/** The two matches leading to this one are not completed yet. No update possible. */
Locked = 0,
/** One participant is ready and waiting for the other one. No update possible. */
Waiting = 1,
/** Both participants are ready to start. Update possible. */
Ready = 2,
/** The match is running. Update possible. */
Running = 3,
/** The match is completed. Update possible. */
Completed = 4,
/** At least one participant completed his following match. No update possible. */
Archived = 5


Is there a Python API (like pylive)?

Cool. I am making some experiments with this, and I have also a few ideas for projects based on this.
Btw do you plan to release this under some opensource license?

Just added a LICENSE.md that puts this under the terms of the MIT license, so free for commercial and non-commercial use.

Just added a LICENSE.md that puts this under the terms of the MIT license, so free for commercial and non-commercial use.


with 1.0-beta-19, sometimes SEVERE error occurred.

Version report
Jenkins and plugins versions report:

1.0-beta-19

What Operating System are you using (both controller, and any agents involved in the problem)?

Linux

Reproduction steps

I deployed jenkinsfile-runner in kubernetes as pod.
Usually it worked very well.
Sometimes, SEVERE error occurred and pod was not worked.
2021-06-15 07:18:50.117+0000 [id=1]     WARNING j.branch.WorkspaceLocatorImpl#getWorkspaceRoot: JENKINS-2111 path sanitization ineffective when using legacy Workspace Root Directory ‘/build’; switch to ‘${JENKINS_HOME}/workspace/${ITEM_FULL_NAME}’ as in JENKINS-8446 / JENKINS-21942
2021-06-15 07:18:50.152+0000 [id=1]     INFO    o.c.j.p.k.KubernetesClientProvider$SaveableListenerImpl#onChange: Invalidating Kubernetes client: kubernetes null
2021-06-15 07:18:50.166+0000 [id=1]     INFO    j.m.JenkinsLocationConfiguration#preventRootUrlBeingInvalid: Invalid URL received: http://localhost:-1/jenkins/, considered as null
2021-06-15 07:18:54.610+0000 [id=1]     SEVERE  h.i.i.InstallUncaughtExceptionHandler$DefaultUncaughtExceptionHandler#uncaughtException: A thread (main/1) died unexpectedly due to an uncaught exception, this may leave your Jenkins in a bad way and is usually indicative of a bug in the code.
java.io.FileNotFoundException: /tmp/jenkinsfileRunner.tmp/jfr7762827885266829059.run/jobs/job/builds/1/log (No such file or directory)
        at java.io.RandomAccessFile.open0(Native Method)
        at java.io.RandomAccessFile.open(RandomAccessFile.java:316)
        at java.io.RandomAccessFile.<init>(RandomAccessFile.java:243)
        at org.kohsuke.stapler.framework.io.LargeText$FileSession.<init>(LargeText.java:399)
        at org.kohsuke.stapler.framework.io.LargeText$2.open(LargeText.java:121)
        at org.kohsuke.stapler.framework.io.LargeText.writeLogTo(LargeText.java:212)
        at hudson.console.AnnotatedLargeText.writeLogTo(AnnotatedLargeText.java:165)
        at hudson.model.Run.writeWholeLogTo(Run.java:1556)
        at io.jenkins.jenkinsfile.runner.Runner.writeLogTo(Runner.java:134)
        at io.jenkins.jenkinsfile.runner.Runner.run(Runner.java:94)
Caused: java.lang.reflect.InvocationTargetException
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at io.jenkins.jenkinsfile.runner.JenkinsfileRunnerLauncher.doLaunch(JenkinsfileRunnerLauncher.java:32)
        at io.jenkins.jenkinsfile.runner.JenkinsLauncher.launch(JenkinsLauncher.java:83)
        at io.jenkins.jenkinsfile.runner.App.run(App.java:13)
        at io.jenkins.jenkinsfile.runner.bootstrap.Bootstrap.run(Bootstrap.java:312)
        at io.jenkins.jenkinsfile.runner.bootstrap.Bootstrap.main(Bootstrap.java:135)

Results
Expected result:

No SEVERE error.
Actual result:

That's odd but looks like a real bug caused by a race condition somewhere.
P.S: Ideally Jenkinsfile Runner should support not writing the build log to the filesystem, it is a performance overhead


update brush completed event with expected data fields

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Align the brush completed event data with the other tools

What is the current behavior? (You can also link to an open issue here)

toolType instead of toolName
The brush toolState is sent for all segmentation.

What is the new behavior (if this is a feature change)?

Used toolName to follow the new v3 naming convention
selected the brush data for the current segmentation.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Maybe

Other information:

:tada: This PR is included in version 3.14.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to use TimeDistributed if I have multiple inputs

TimeDistributed works fine if there is only one input as is in this exampe at the bottom of the page.  But when there are multiple inputs, TimeDistributed seems not working.
Say, if my model has 3 inputs,
seq_inputs= [Input(shape=(TIME_STEPS, FEATURE_LENGTH)) for i in range(3)]                                                                 outputs=TimeDistributed(model)(seq_inputs)
the reported error is:   TypeError: can only concatenate tuple (not "list") to tuple
So I changed the last to outputs=TimeDistributed(model)(*seq_inputs), but there is still an error saying that   TypeError: call() takes at most 3 arguments (4 given)
#################  below is my code
from keras.models import Sequential, Model, Graph
from keras.layers import Input, Convolution2D, MaxPooling2D, LSTM, Dense, BatchNormalization, ZeroPadding2D, Flatten, merge, Masking, Dropout, TimeDistributed, Reshape, Lambda, Embedding
from keras import backend
NUM_INPUTS=3
TIME_STEPS=20
model = Sequential()
model.add(Dense(32, input_dim=784))
inputs = [Input(shape=(32,)) for i in range(NUM_INPUTS)]
temps=[model(x) for x in inputs]
merged=merge(temps, mode='concat')
merged_model=Model(input=inputs, output=merged)
merged_model(inputs)
pdb.set_trace()
seq_inputs = (Input(shape=(TIME_STEPS, 32)) for i in range(NUM_INPUTS))
outputs=TimeDistributed(merged_model)(*seq_inputs)

Have you found a solution yet?

num_inputs = 3
input_dim = 784
input_length = 20
output_dim = 32

model = Sequential()
model.add(Dense(output_dim, input_dim=input_dim))

merged_input = Input((num_inputs, input_dim))
temps = [model(merged_input[x, :]) for x in range(num_inputs)]
merged = merge(temps, 'concat')
merged_model = Model(input=merged_input, output=merged)

seq_inputs = [Input(input_length, input_dim) for x in range(num_inputs)]
seq = map(Reshape((input_length, 1, input_dim)), seq_inputs)
seq = merge(seq, 'concat', concat_axis=2)
outputs = TimeDistributed(merge_model)(seq)

@farizrahman4u
thanks, my solution looks similar.
I merge the inputs and then use Lambda functions (for slicing) to retrieve all parts.

If you guys need it, I could enable multi input support to the TimeDistributed wrapper.

I think it is not necessary, as everything for this exist. Also this thread easily pops up when search in the Internet.

#3432

@farizrahman4u I believe the trick of merging multiple input tensors would not work if the shape of the input tensor differ from each other. It would be nice if there is native and robust support of using multiple input tensors with TimeDistributed.

They should have the same number of timesteps either way.

@farizrahman4u I think that would be useful and for the sake of consistency.
Or at least it should be mentioned in the TimeDistributed documentation/error message that it doesn't support multiple inputs. This thread is easy to find once you figure out what the cause of the problem is, but it's not obvious right away that there should be this problem. It is easy to assume that you can pass multiple inputs here as anywhere else.

Is multi input support planned to be implemented?

@farizrahman4u
Thank you for your solution. I tried it but it fails

With theano backend, I had
TypeError: ('Not a Keras tensor:', Subtensor{::, int64, ::}.0)

because of line 13
...
temps = [model(merged_input[:, x, :]) for x in range(num_inputs)]
...

With tensorflow backend, I had
AttributeError: 'NoneType' object has no attribute 'inbound_nodes'

because of line 15
...
merged_model = Model(input=merged_input, output=merged)
...

I am new to keras and use
keras: 2.0.2
theano 0.10.0dev1.dev-RELEASE
tensorflow 1.1.0
ubuntu 16.04

Any update on multi-input support for TimeDistributed?
I would like to implement a hierarchical model to classify each sentence based on the context information provided by the whole document. Thus, I designed a model where the first recurrent layer works at sentence level and the second one at document level. I want to include further sentence-level information (e.g. sentence type or category), concatenate it to the output of the first layer and use the resulting augmented tensor to feed the second recurrent layer. Here is my code:
# input sentence
in_sentence = Input(shape=(MAX_LENGTH,), dtype='int32')
# additional sentence-level information (fixed length array - already "embedded")
in_info = Input(shape=(INFO_LENGTH,), dtype='float32')
# first layer (sentence-level)
# word embedding
embedded_sentence = Embedding(len(vocab) + 1,
                            EMBEDDING_DIM,
                            weights=[embedding_matrix],
                     trainable = False)(in_sentence)

recurrent_sentence = GRU(hidden_dim_1)(embedded_sentence)
recurrent_sentence_and_info = concatenate([recurrent_sentence, in_info])
encoded_model = Model([in_sentence, in_info], recurrent_sentence_and_info)

#second layer (document-level)
sequence_input = Input(shape=(MAX_SENTENCES, MAX_LENGTH), dtype='int32')
info_seq_input = Input(shape=(MAX_SENTENCES, INFO_LENGTH), dtype='float32')
seq_encoded = TimeDistributed(encoded_model)([sequence_input, info_seq_input])

# Encode entire sentence
seq_encoded = GRU(hidden_dim_2,return_sequences=True)(seq_encoded)

# Prediction
prediction = Dense(NUM_CLASSES, activation='softmax')(seq_encoded)
model = Model([sequence_input,info_seq_input], prediction)

For the sake of completeness, MAX_LENGTH is different from INFO_LENGTH, in general.
When I run
seq_encoded = TimeDistributed(encoded_model)([sequence_input, info_seq_input])
I get the following assertion error: assert len(input_shape) >= 3
Without additional sentence-level information, TimeDistributed has a single input and everything seems to work fine. Is there any work around to include multiple input?

I am using Bucketing to group together batches of different length. This is time series data where I have multiple time series of the same length (but variable length across batches) as input to the different layers at the beginning of the model. Thus the input shape for my input layer is (None, 1) because I only have one column of data per input. How can I apply @farizrahman4u original solution without an input length?
I've tried submitting None as a dimension and get the following error:
ValueError: Tried to convert 'shape' to a tensor and failed. Error: None values not supported.

If the multi-input of TimeDistributed has different shape, such as there has three input A, B, C, only A is a 5D tensor, the B and C are not, but I have to input them together to a custom_conv function through Lambda layer which will be wrapped by the TimeDistributed, so how can do? Thanks!

@karenyun Can you elaborate? How you pass a 5D tensor and 2 non-5D tensors exactly?

@iretiayo Have you found any solution to your problem? I'm currently looking at the exact same architectural problem. As you, I'm having a 2D vector and an image as input, which is then fed to a LSTM. If you have any solution using a different approach, it would also be great if you could share it! My only idea of how to solve that is by using T input networks with shared weight, which then are used as a sequence to feed to the lstm layer.

@raharth  Have you found any solution?
Here is the part of my code that throws out the error:

@raharth Have you found any solution?
Here is the part of my code that throws out the error:

Unfortunately I don't see your code. As far as I remember I actually used shared weights to solve it, but it was a whole mess and really hacky. I actually decided to build the same architecture using pytorch, which is way more flexible and cleaner for an architecture like that. Since it doesn't compile the graph it doesn't care about what you did with the tensor before feeding it to a specific layer, so you just need to take care that the shape actually matches what it expects.

@farizrahman4u  Thanks a lot for the proposed solution. I tried Lambda layer, but it seems the nested model can't be trained when it is embedded in Lambda layer. Do you have any suggestion regarding this issue?
Here, you can find the snippet of my code that I am stuck. Any help is highly appreciated.

#3432

This solution is not working

RepeatVector can help, e.g.
TimeDistributed( Dense(tensorflow.shape(word_embeddings)[2] ) )(Concatenate()([
    word_embeddings,
    RepeatVector( tensorflow.shape(word_embeddings)[1] )(sentence_embedding)
]))

I was able to solve this problem using the RepeatVector layer.
from keras.models import Model
from keras.layers import Input, Dense, BatchNormalization, LSTM, TimeDistributed #, Conv1D, LeakyReLU, MaxPool1D,
from keras.layers import Concatenate, RepeatVector
...
core_input_1 = Input(shape=(self.core_timesteps, self.core_input_1_dim), name='core_input_1')
core_branch_1 = BatchNormalization(momentum=0.0, name='core_1_bn')(core_input_1)
core_branch_1 = LSTM(self.core_nodes[0], activation='relu', name='core_1_lstm_1', return_sequences=True)(core_branch_1)
core_branch_1 = LSTM(self.core_nodes[1], activation='relu', name='core_1_lstm_2')(core_branch_1)

core_input_2 = Input(shape=(self.core_timesteps, self.core_input_2_dim), name='core_input_2')
core_branch_2 = BatchNormalization(momentum=0.0, name='core_2_bn')(core_input_2)
core_branch_2 = LSTM(self.core_nodes[0], activation='relu', name='core_2_lstm_1', return_sequences=True)(core_branch_2)
core_branch_2 = LSTM(self.core_nodes[1], activation='relu', name='core_2_lstm_2')(core_branch_2)

merged = Concatenate()([core_branch_1, core_branch_2])

full_branch = RepeatVector(self.output_timesteps)(merged)
full_branch = LSTM(self.core_nodes[1], activation='relu', name='final_lstm', return_sequences=True)(full_branch)

full_branch = TimeDistributed(Dense(self.output_dim, name='td_dense', activation='relu'))(full_branch)
full_branch = TimeDistributed(Dense(self.output_dim, name='td_dense'))(full_branch)

Note that return sequences before the concat is False and that the RepeatVector layer repeats the concat vector the same number of timesteps as I want output by the TimeDistributed layer at the end. This is a multi-variate mutli-step forecasting model.