Add Codespaces to the repository

As discussed with @kianenigma, @PierreBesson and others, this pull request brings the ability to spin up a Codespace instance inside this repository. The PR has two components:

devContainer.json: The setup instructions to initialize the instance with
postCreateCommand.sh: A custom shell script to install the necessary dependencies for Substrate and the contracts node template on the Codespace instance that is invoked immediately after the instance is created

Once this is merged, we can then include links for folks to create their own Codespace with the contracts node template using their own GitHub account similar to the way Rustlings does do.

CI fails because we need to sync against the latest substrate release I think.

Yep. Please merge or rebase master for your branch

Thanks both. I'll go ahead and do that early this coming week.

@athei and @SkymanOne This is now ready for a review again. 🙏🏻


fav-btn-fix

The favorites button was not working due to an assumed bug in next-auth getSession() function - fixed by migrating to using getServerSession().

Find out if getSession() returning null when adding body to axios request is a bug from next-auth or just a new feature - as this doesn't happen with their old versions


[WIP] JDC edits

So far, this is just some edits to the introduction. I'll continue with edits to the statistical analysis section.

@jchodera how is the WIP coming along here?

Working on it again today!

@jchodera, I will close this, as I would like to move things along.

I incorporated your changes into the manuscript, but the pull request is now too old.


Custom editor: extension should create CustomDocument and get it passed into resolveCustomEditor

Refs https://github.com/microsoft/vscode/issues/91325
When implementing a custom editor that is not text based, I have to implement 2 methods:

resolveCustomEditor
resolveCustomDocument

The editor is actually the one that is driving everything, e.g. edits emit from there. However, the capabilities are in some other place, associated to the document?
It is not clear to me how I get access to my capabilities from the document. Should I use the user data for that purpose?

I will end up having to keep a Map<CustomDocument, CustomEditorCapabilities> in some global to get around this.

I think what I actually want is that I am returning a CustomDocument from resolveCustomDocument which is then getting passed into the resolveCustomEditor method. I would then operate on methods from my own custom document in the same way I can do operations on TextDocument.

This is especially confusing because the method is called resolveCustomDocument while it only returns CustomEditorCapabilities

Yes, the userdata field was intended for this purpose. However I find myself setting userData to the capabilities object.
Some possible api directions:

Have capabilities be a property on CustomDocument that extensions can get or set (possibly replacing userData)

Move all the capabilities back onto the CustomEditorProvider and update all the capability methods to take a CustomDocument as their first argument

The more I think about it, the more I like approach two. This is basically the delegate based approach we already tried. This would move CustomEditorEditingCapability to a property on CustomEditorProvider and update each of the CustomEditorEditingCapability methods to take CustomDocument as its first argument.
I believe this would also play more nicely with any future methods we may add to custom documents, such as handlers for rename.

We've changed to what should be a more familiar model:

CustomDocument is now a class
renamed resolveCustomDocument to openCustomDocument
openCustomDocument now returns a CustomDocument


Upgrade to Ubuntu 24.04

I upgraded my box to Ubuntu 24.04 and now I can't run the local docker compose - a GCC compiler error when I compile on Ubuntu 24.04 and run on 22.04.

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.06%. Comparing base (7d250e3) to head (56c649f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   57.06%   57.06%
=======================================
  Files         277      277
  Lines       14168    14168
  Branches     1902     1902
=======================================
  Hits         8085     8085
  Misses       5495     5495
  Partials      588      588

Flag
Coverage Δ

57.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUG] Typescript Import Attributes

What happened?
Using Typescript's import attributes leads to build errors in Plasmo.
With Typescript 5.3, import attributes have been introduced: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html
🟣 Plasmo v0.86.3
🔴 The Browser Extension Framework
🔵 INFO   | Starting the extension development server...
🔵 INFO   | Loaded environment variables from: [ '.env.chrome', '.env' ]
🔴 ERROR  | Build failed. To debug, run plasmo dev --verbose.
🔴 ERROR  | Expected ';', got 'with'

or with plasmo dev --verbose
🔵 INFO   | Loaded environment variables from: [ '.env.chrome', '.env' ]
🟡 0      | @plasmohq/parcel-transformer-manifest
🟡 1      | Adding tab onboarding.tsx
🟡 2      | Adding icons
🟡 3      | Adding default_icon
🟡 4      | Adding default_popup
🟡 5      | Handling MV3 background service worker
🟡 6      | + Finished transforming manifest
🔴 ERROR  | Expected ';', got 'with'
🟡 30     | ...\src\lib\handlers\mappinghandler.ts:1:45

with the corresponding line mappinghandler.ts:1:45:
import buffIds from<EMAIL_ADDRESS>with { type: "json" };
My package.json uses "typescript": "5.4.5".
Version
Latest
What OS are you seeing the problem on?
Windows
What browsers are you seeing the problem on?
No response
Relevant log output
No response
(OPTIONAL) Contribution

[ ] I would like to fix this BUG via a PR

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

I think the packaged Parcel's TS path resolver doesn't support TS import attributes atm xd...
If you can help with #813 that'd be great.


nightly specify date

Closes #169
Follow up to #167
Allows you to install a specific date of nightly. Specifying the TargetTriple is still disallowed (automatically sourced from the running system's OS).
Commands that should work:

[x]  fuelup toolchain install nightly-2022-08-31
[x]  fuelup default nightly-2022-08-31
[x] fuelup toolchain uninstall nightly-2022-08-31

In addition to the above,
fuelup check should not check updates for date-specific versions
You should still not be able to add/remove components from date specific nightlies
This is not ready for review just yet - would like to look through the code again tomorrow and add more tests.

This should be good to go as well but note that this merges into #167.

Hey looks like this might have slipped by, or didn't quite make it to "Ready for review"? Happy to review once rebased or merged with master and out of draft mode :)

Yep, this was sort of left behind because of the previous PRs to fix things related to the semver changes and is very outdated - will come back to this soon


Module Does not show in the admin

Hi,
I have installed this module on magento 2.3.3 and this module does not work and gives issues related to the swatches css & js. Even it does not show in the admin.

@razarehman56 there is no anything added to the admin part. The extension is mostly for developers to show them how this solution can be used for creating this add to cart popup. It seems like it has some conflicts with your custom theme and that is why you're getting the issues. Also I've not tested it with new Magento versions, so I cannot guaranty it will be working with newest versions.


Graded games list should show the grades you gave

The graded games list should include your grades per item.
Preferably the list should be sortable not only on order that you graded games but also the grades given.

Could also show the final ranking and grade of the game once the results are out.

#1518 has the grades showing. It'd be better opening new issue if we should show comparison to global average and rank after voting. It's also a matter of not getting too much text and info into the list.


Fix: json formatting for strftime

This should be output as a string when json formatting is selected.
Checklist

[ ] Language changes are updated in man/adoc/bpftrace.adoc
[ ] User-visible and non-trivial changes updated in CHANGELOG.md
[x] The new behaviour is covered by tests

Not sure if this is worth a changelog entry


send_upload_contract_confirmation should not set to_msme=False

Original error in ba14fda70731431b54bab8494c45703eae271b6b

Ah correct, but before https://github.com/open-contracting/credere-backend/commit/bb364e3e0f88ca2e04150503a27eb26ec00ce733 this was sending emails to lender emails anyway (so no harm has been done e.g. sending emails to borrowers in dev/local testing)

to_name is True by default so better to just delete the keyword argument, like in other functions.


impl Stream for future::Either

For code that returns one of multiple Streams it'd be nice to have future::Either also impl Stream.
fn foo() -> impl Stream {
    let v = match some_result {
        Ok(v) => v,
        Err(err) => return Either::A(stream::once(Err(err))),
    };

    return Either::B(some_stream(v));
}

Sounds like a good idea to me!

Added in https://github.com/rust-lang-nursery/futures-rs/pull/756

@tekjar I've cherry picked it and made #1682

Thanks @Kixunil


Feat/Add README.md and test.properties filled with the instructions

close #2433

@smlambert ,Done .

@OsamahGharad could you sign the Eclipse Contributor Agreement (ECA) details: https://www.eclipse.org/legal/ECA.php? Thanks

@OsamahGharad could you sign the Eclipse Contributor Agreement (ECA) details: https://www.eclipse.org/legal/ECA.php? Thanks

@llxia. Done , I signed it .

hi @OsamahGharad - the ECA check still fails (with this advice: Could not validate the users ECA sign-off status. Please ensure that the e-mail address of all contributing accounts match a valid Eclipse Foundation account with a valid ECA.)
Can you please verify the email address you used to sign the ECA matches the one of your Eclipse account?

Hey @smlambert . Can you please check the  ECA status again . I have just logged in to my account with the same e-mail and ECA status was actually marked as done .Please let me know .


[10.x] Add Model::isValidColumn method

Hello!
This PR introduces a new Model::isValidColumn method that checks if the given column is a valid database column.
Why
I need to check if a column is a valid column in the database---there's currently not an easy, efficient way to do this.
You can use the Schema facade:
Schema::hasColumn($model->getTable(), $column);

however, this performs a query for every single check---not good for loops.
The next best solution is to statically cache all the table columns:
protected static array $tableColumns;
//...
if (! isset(static::$tableColumns)) {
    static::$tableColumns = Schema::getColumnListing($model->getTable());
}
//...
if (in_array($column, static::$tableColumns)) {
    //...
}

Which works, but then I discovered that the Model is already doing this via GuardsAttributes::isGuardableColumn---it's just a protected method that I don't have direct access to:
https://github.com/laravel/framework/blob/ff96905683e7035d6d7c9700ef8f722344c27c2f/src/Illuminate/Database/Eloquent/Concerns/GuardsAttributes.php#L215-L229
To keep the logic on the Model and avoid duplication/BCs I moved the logic from GuardsAttributes::isGuardableColumn to Model::isValidColumn (and update the old location to point to the new logic).
Alternatives

Can change the visibility of GuardsAttributes::isGuardableColumn from protected to public, however, 1) I wasn't sure if this would be considered a BC, and 2) it's not the most descriptive in the context that I want to use the method---checking if it's a valid database column not just a guardable column.

Thanks!

Can you define a trait in your own project with this method name and simply call the protected method from there?

@taylorotwell, sure I could do that...but would need to create an AbstractModel that all models extend. But is this not something that could benefit the community at large? I can't be the only one that needs to ensure that an attribute is a valid database column.

Could you describe a situation where this would be needed? Because checking table schema is not really an efficient solution because you still need to establish a connection where none could be needed.
From my experience if you're creating the application you should know if the column exists or not, the situation where you would check columns individually from database is very rare and I doubt many in that case would resolve to checking the database schema for it, mostly would go around using feature flags or such.

@donnysim,
We have dedicated query builder classes, and we've added additional logic to more easily apply request parameters to scopes. One of the conveniences I've added is for simple where(<column>, <value>)  or orderBy(<column>) clauses, a method does not have to be explicitly defined on the Builder class---instead I check if the attribute is a valid database column and if so then I apply the where/orderBy. I need to check that it's a valid column to prevent SQL exceptions if an invalid column were to be passed in

But if that's the case wouldn't you also want to validate the data being passed from request parameters which would require specifying the column validation rules anyway so that it doesn't end up like user_id = "1,2,3" and you get a incorrect value, truncating warning and so on?

Take this example:
I allow sorting to be dynamically specified with a sort_by attribute in the form of '-completed_at,id' (conforms to JSON:API specs). I then loop over all the columns and determine if they should be sorted asc/desc. However, now I need to validate that those are actual DB columns or the orderBy will throw an exception.
There's no reason for the class to throw a SQL exception that alerts all devs when I can just skip it.

Valid use case, however I think I would be more explicit and define a $sortable property with the column names that can be sorted (even if I have to put all column names in there). Yes, it is less generic and it wouldn't just work when adding a new column to the database – you would have to add the column name to the property – but you get rid of that extra database query to check which columns actually exist.
We built an app for a client once where they needed a form builder and every form should be a table in a specific database. So tables where added and altered automatically (when a new field was added for example). Upon saving the form after editing it we had to sync the table (check if a newly added "first_name" field already exists in the table and so on).
But I don't know if this is really required as a method in the model core as @donnysim said:

the situation where you would check columns individually from database is very rare

@dennisprudlo

but you get rid of that extra database query to check which columns actually exist.

The thing is, all models are already performing this query and caching the result

where did you get that? Laravel models do nothing to know about guarded fields by database. Every attribute that is not in $fillable is by default guarded no matter if it exists or not in database. Or are you referencing your project? I personally always disable the guarded property because it's better to be explicit what you're filling and I've seen many cases where developers add an x_id to fillable (and I did in my early days too) just because it didn't set, instead of understanding the problem.

@donnysim,

Laravel models do nothing to know about guarded fields by database.

You are incorrect, see GuardsAttributes::isGuardableColumn() which is called by GuardsAttributes::isGuarded() which in turn is called by GuardsAttributes::isFillable().

Oh, never knew that 😆to be honest I'm even more glad I disable them now.

@CalebDW This is very interesting. Do you know why the database columns are being read? I mean as you said the GuardsAttributes::isGuardableColumn is basically a GuardsAttributes::isValidColumn and only used in GuardsAttributes::isGuarded:
public function isGuarded($key)
{
    if (empty($this->getGuarded())) {
        return false;
    }

    return $this->getGuarded() == ['*'] ||
           ! empty(preg_grep('/^'.preg_quote($key, '/').'$/i', $this->getGuarded())) ||
           ! $this->isGuardableColumn($key);
}

Say we have given a column for a mass update with the name "foo". Now the code says this column is guarded, when

The $guarded property is ['*'], meaning all columns should be guarded
The value "foo" is somewhere in the $guarded array, meaning it was explicitly defined as guarded
The value "foo" is not a valid column.

But why the last one? Why not simply let the database crash with a "column not found" when you give it a nonexisten column. I mean ultimately it is the developers fault and laravel doesn't do that in other cases. Like you get exceptions when you didn't hook up a relationship the correct way instead of null or when using MyModel::get() but the defined table does not exist – instead of an empty array.
This would obviously cost database queries to find out in the first place but why is it acceptable in the guarded case? Anyone knows why we do that here?


ClusterAttributes gone from models.jobs

In 0.1.2 we have a models.jobs generated out of jobs.yaml, but before it was generated out of jobs-2.1-aws.yaml. Current main doesn't have file named as jobs.yaml, but has the former one: jobs-2.1-aws.yaml.
Issue
Our code base was relying on ClusterAttributes which is still in the schema ClusterAttributes link.
Was this change of schema for generation intended and how to find a new schema file?
I observed that DockerImage is also gone from models.jobs.
Background
We use specific setting out of it: docker_image. If this change was intended how to pass it now?

Minor update:
This is not a blocker, since I'm able to workaround that with following snippet, but it still would be nice to bring back DockerImage and NewCluster property for that, so we can do more object orient things.
cluster_kwargs["docker_image"] = {"url": docker_image}


How do I implement this?

Sorry nobody has gotten back to you, but please don't make lots of separate issues for the same thing. I've moved the discussion to https://github.com/go-gl/gltext/issues/21.


Generic return type for abstract method giving an error in child class

TypeScript Version:
<EMAIL_ADDRESS>Search Terms:
generic abstract class method
Code
abstract class Parent<T> {
  abstract getX<U = T & { ax: number }>(x: U): U
}

class Child extends Parent<{ nx: number }> {
  getX(x: { nx: number, ax: number }): { nx: number, ax: number } {
    return x;
  }
}

Expected behavior:
No Errors
Actual behavior:
Property 'getX' in type 'Child' is not assignable to the same property in base type 'Parent<{ nx: number; }>'.
Type '(x: { nx: number; ax: number; }) => { nx: number; ax: number; }' is not assignable to type '<U = { nx: number; } & { ax: number; }>(x: U) => U'.
Types of parameters 'x' and 'x' are incompatible.
Type 'U' is not assignable to type '{ nx: number; ax: number; }'
Playground Link:
https://www.typescriptlang.org/play/index.html#src=abstract class Parent<T> {
  abstract getX<U %3D T %26 { ax%3A number }>(x%3A U)%3A U
}

class Child extends Parent<{ nx%3A number }> {
  getX(x%3A { nx%3A number%2C ax%3A number })%3A { nx%3A number%2C ax%3A number } {
    return x%3B
  }
}

Related Issues:

This is a correct error. Parent's contract claims that this call is legal
const p: Parent<{ nx: number }> = new Child();
p.getX<{}>({});

Child's signature for getX does not support that call, e.g. this code reads two undefineds:
class Child extends Parent<{ nx: number }> {
  getX(x: { nx: number, ax: number }): { nx: number, ax: number } {
    return { nx: x.nx + x.ax, ax: 0 };
  }
}

Sorry, I'm not sure what you mean by "this code reads two undefined's"?

The call p.getX<{}>({}); passes in an empty object, so in the body of the method the two property accesses:
x.nx + x.ax

will both return undefined because x is empty.

I feel like you're trying to use U = T & { ax: number } as a shortcut to define the U generic.
That construct is actually used to define a default value for the generic U when is not otherwise specified, that means that I could call p.getX<number>(4) (accepted by the Parent's contract).
The problem occurs because Child define that I cannot make that call anymore.
This code should show the error a bit better:
// let's change Child slightly keeping the same contract
// assume that this doesn't give any error
class Child extends Parent<{ nx: number }> {
  getX(x: { nx: number, ax: number }): { nx: number, ax: number } {
    return { nx: 12, ax: 10 };
  }
}
const p: Person<{ nx: number }> = new Child();
console.log(p.getX<number>(4));
// this would not give any error, **the expected logged value is a number**
// but since p is actually an instance of Child is going to log me an object!!!

Remember that when you extends/implements you can only make your generics less specific (allows more values), this is why it fails when you use your code where the generic U becomes more specific (allow less values, in your case it allows only the value { nx: number }).
I will show two example to show what I just said:
abstract class Parent {
  abstract getX<A extends number>(x: A): A;
}

class Child extends Parent {
  // ERROR! 5 is more specific than number
  // Type 'number' is not assignable to type '5'.
  getX<A extends 5>(x: A): A {
    return x;
  }
}

abstract class Parent {
  abstract getX<A extends 5>(x: A): A;
}

class Child extends Parent {
  // IT WORKS! number is less specific than 5
  getX<A extends number>(x: A): A {
    return x;
  }
}

In any case I think you meant to do this:
abstract class Parent<T> {
  abstract getX(x: T & { ax: number }): T & { ax: number }
}

class Child extends Parent<{ nx: number }> {
  getX(x: { nx: number, ax: number }): { nx: number, ax: number } {
    return x;
  }
}

This all makes a lot of sense. Thanks a lot, closing the issue.


Use ImmutableMap.of() in DefaultEventMetadata

Description
From looking at the code, I see that most Events do not have metadata attributes. Each of these calls was creating a new ImmutableMap. This PR calls ImmutableMap.of() which will use a shared empty map. This should help reduce the object churn for Events.
Issues Resolved
N/A
Check List

[x] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2239 (1914947) into main (9b7767d) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #2239      +/-   ##
============================================
- Coverage     93.99%   93.93%   -0.06%
  Complexity     1767     1767
============================================
  Files           218      218
  Lines          5130     5130
  Branches        412      412
============================================
- Hits           4822     4819       -3
- Misses          213      215       +2
- Partials         95       96       +1

Impacted Files
Coverage Δ

.../dataprepper/model/event/DefaultEventMetadata.java
100.00% <100.00%> (ø)

...pensearch/dataprepper/model/sink/AbstractSink.java
95.45% <0.00%> (-4.55%)
:arrow_down:

...rwarder/discovery/AwsCloudMapPeerListProvider.java
92.68% <0.00%> (-2.44%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Lint OPA config file

A pretty common mistake in OPA is to mistype some attribute in the config, which OPA will happily swallow most of the times. It would be awesome if Regal would be able to lint OPA config files at some later point in time :)

Let's fix this in OPA instead, or come back to this later.


Use of DEBUG Symbol

DEBUG define symbol is always active in the Unity Editor which is leading to Assertions being active... slowing performance and cluttering the Burst Inspector with many branches. I'm not sure what the best remedy for this is. Maybe using ENABLE_UNITY_COLLECTIONS_CHECKS instead so at least Burst can get rid of them.

ENABLE_UNITY_COLLECTIONS_CHECKS would add an unnecessary dependency on the Unity.Collections package.
There is a functionality for disabling all/some assertions in the editor via Window/C# Dev Tools/Manage Safety Checks... for performance tests or editor scripts.
This is technically closed but I'll leave it open for others to read.


Release 1.0.0

This release targets Swift 2.0 / Xcode 7.0.
Breaking changes

#31 Introduce error handling model. The signatures of decode functions / methods and operators for Extractor are changed to use throws with DecodeError and return non-optional value, as something like:

Decodable: static func decode(e: Extractor) throws -> DecodedType
func decode<T>(object: AnyObject) throws -> T
func <| <T>(e: Extractor, keyPath: KeyPath) throws -> T

Enhancements

#24 Add watchOS target.
KeyPath now conforms to Equatable.

Finally :ship:


Update to match new player UI

This uses couple internal js objects I found via console. I'm not sure if thats acceptable.
fixes  https://github.com/tiliado/nuvolaruntime/issues/656

Sorry, I missed this. Thanks for your help.


Add more details to documentation about changing color theme

Just trying to make it clear that the .tmtheme file is the one to change, and than other plugins might get in the way of the process of trying to reload the color scheme, as neither of these things were obvious to me and it caused it to take much longer than it should have to tweak a colour.

Cleaned up whitespace, removed the merge commit, and merged. Thanks for the contribution!


[User Story] Validate Email Addresses on Signup

Bug Title
Email does not validate

T-shirt size default is S(mall)
S

Story Points - Fibonacci (1,2,3,5)
2

Description
User email has no validation whatsoever.

Business Need (the why):
A valid email address is fundamental to verifying the identity of the user in the system

Applications or Systems impacted
Data integrity in the database, usability of the application

@kthblmfld What sort of email validation can we really do here?

Are we going to block usage of the app until the new user receives an email from neXt and verifies that he has access to it -- then let the registration complete?
Are we simply going to verify the correct format of an email address<EMAIL_ADDRESS>?
would it be desirable to restrict the domain that can be used (like only<EMAIL_ADDRESS>can be used.  More secure this way?  App-wide config setting maybe?

migrated to new tmobile/sawtooth-next-directory repo


RUM-1930 Add regression test for Gson toString method

What does this PR do?
As a followup on the previous action taken on iOS: https://datadoghq.atlassian.net/browse/RUM-1929, I investigated all the potential issues on our end regarding this topic and came to the following conclusions:

we are using indeed . attributes on our end but most of them are correctly handled in our serializers.
it will be quite hard and very intrusive to try to remove all these attributes in the sdk and for no reason momentarily because the serializers are handling this. There is only one problem that could appear if by any chance we adopt a new Gson version which changes the implementation in adding the properties into the toString method. Right now they are using a LinkedList which suites us very well.

In this PR I added a regression test for our Gson dependency to make sure it will always add the properties in the order they were added in the Json object when using the toString method.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1742 (3324639) into develop (1b499cf) will decrease coverage by 0.26%.
Report is 12 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1742      +/-   ##
===========================================
- Coverage    83.58%   83.32%   -0.26%
===========================================
  Files          465      465
  Lines        16182    16179       -3
  Branches      2412     2411       -1
===========================================
- Hits         13525    13481      -44
- Misses        2016     2040      +24
- Partials       641      658      +17

see 25 files with indirect coverage changes


MissingPluginException(No implementation found for method wifi on channel plugins.ly.com/settings)

I'm using settings plugin to jump to device settings on a button click. But the application is throwing Missing Plugin Exception.

Please report in https://github.com/once10301/settings


chore: add asset description for crvCVXETH

Looks great @krissnawat! Just have a few requests: can you please add links to the shapeshift asset pages for the underlying assets?
ie. CVX
Also, can you link ShapeShift to the earn page?
ie. ShapeShift
(see https://github.com/shapeshift/lib/pull/424/files as an example)
Last thing: next time you submit one of these, can you post a link to the PR in the #product-design-public channel in discord.gg/shapeshift (add the product role in #role-selector if you can't access it)?
Thanks for picking up this bounty; hope you take on more!

done

hey @krissnawat please see my comment on the other PR as it relates to this one too
#436 (review)

all my pr done

@krissnawat looks good but please rebase off of main


Possible fix the webhook API creation

Maybe fix #13907

Sorry to report, still seeig the error:
curl -X POST "http://localhost:3000/api/v1/repos/test/test/hooks?access_token=da0c14c710e2e000fcd80d7d7b4a0b4eba9c485d" -H  "accept: application/json" -H  "Content-Type: application/json" -d "{  \"active\": true,  \"branch_filter\": \"master\",  \"config\": {      \"url\":\"http://test.local\",     \"content_type\":\"json\"  },  \"events\": [    \"push\"  ],  \"type\": \"gitea\"}"

{"message":"Invalid hook type: gitea","url":"http://localhost:3000/api/swagger"}

Is it because "Gitea" is not in the webhooks array:
https://github.com/go-gitea/gitea/blob/master/services/webhook/webhook.go#L28-L59
Previously there was a default case:
https://github.com/go-gitea/gitea/blob/v1.13.0/modules/webhook/webhook.go#L99-L138

@bobemoe done.

@lunny, seems to be working at fist test using curl :)  I will see if Drone is working next...

Codecov Report

Merging #13960 (7dc3927) into master (1837e64) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #13960      +/-   ##
==========================================
- Coverage   42.25%   42.21%   -0.04%
==========================================
  Files         710      710
  Lines       77226    77228       +2
==========================================
- Hits        32628    32598      -30
- Misses      39235    39253      +18
- Partials     5363     5377      +14

Impacted Files
Coverage Δ

routers/api/v1/utils/hook.go
0.00% <0.00%> (ø)

services/webhook/webhook.go
52.42% <0.00%> (-1.04%)
:arrow_down:

services/pull/check.go
48.90% <0.00%> (-2.92%)
:arrow_down:

modules/notification/ui/ui.go
93.05% <0.00%> (-2.78%)
:arrow_down:

modules/process/manager.go
72.50% <0.00%> (-2.50%)
:arrow_down:

modules/charset/charset.go
68.53% <0.00%> (-2.25%)
:arrow_down:

services/gitdiff/gitdiff.go
69.05% <0.00%> (-1.94%)
:arrow_down:

models/notification.go
66.25% <0.00%> (-0.99%)
:arrow_down:

models/error.go
38.49% <0.00%> (-0.82%)
:arrow_down:

services/pull/pull.go
40.68% <0.00%> (-0.50%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1837e64...7dc3927. Read the comment docs.

I can confirm that Drone is now able to use the API to add a webhook to a Gitea repo.
And that from Gitea I am able to successfully test delivery of the Drone webhook :)


Shapes gallery suggestion

Hi Alex,
may I say that your tool is great and very helpful.
May I suggest a gallery of animated vector to be provided in the live version for those of the users who want to share their animations?
With good search and tags and with converter to animated png for preview?
This would have great impact and would be of help to a lot of users.
Please consider it.

Good idea! I think this has already been filed here. I'm definitely considering it! https://github.com/alexjlockwood/ShapeShifter/issues/229


cli/wallet: Add Ledger support for consensus transactions

This is basically lifted from oasis-core-ledger with some minor rework.
The reason is:

I didn't want to require users to use the plugin signer that Oasis Core uses as it is cumbersome.
The current oasis-core-ledger does not export the useful parts as a library to allow reuse.

It would probably make sense to refactor oasis-core-ledger to make it usable in different contexts, but I didn't want this to block adding Ledger support to the new CLI. Once that is refactored the CLI can be updated to use the new lib.

ok, can we leave a code comment in the module so that readers know where to find the canonical version?

ok, can we leave a code comment in the module so that readers know where to find the canonical version?

Done.

Note that this only supports ADR 0008 currently. Should we allow people to use the old derivation scheme as well? We probably should and it would be simple to add.

I think we should. I'd go as far to say that if we don't, we should add something user-facing to communicate that this is something different from basically all oasis ledger software currently in use

I added support for the legacy derivation scheme (it can be set when creating a new wallet using --ledger.derivation legacy). Can someone verify that it generates the right addresses?

I added support for the legacy derivation scheme (it can be set when creating a new wallet using --ledger.derivation legacy). Can someone verify that it generates the right addresses?

Tested the first five derived accounts and the addresses match the ones from the oasis web wallet. Good job!

Task linked: CU-2gf4pgf Add support to new Oasis CLI


KAFKA-10903:Optimize producerBatch order performance

please. see https://issues.apache.org/jira/browse/KAFKA-10903,
as we konw,if we need sort  the producerBatch by sequence,now we use the new batch compare with the first batch in deque, and if the first batch in deque is less than the new batch,we will loop the deque and let the new batch insert to the right position.and if the new batch is more than the last producerBatch in the deque,we just need add the new batchProducer to the last position in the deque,most of time the deque not exists the mixed producerBatch(has sequence and not has the sequence),so i think this optimize make sense,thank you review
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks for the PR. Did you see a performance issue as a result of this? Do you have some numbers to share?

Thanks for the PR. Did you see a performance issue as a result of this? Do you have some numbers to share?

Thanks for the PR. Did you see a performance issue as a result of this? Do you have some numbers to share?

thank you reply, sorry,i don't have the data support, but we can make very simple reasoning,we don't always need loop the deque,Just need to add a judgment,and May do less recursion，it is Obvious

Thanks for the PR. Did you see a performance issue as a result of this? Do you have some numbers to share?

thank you reply, sorry,i don't have the data support, but we can make very simple reasoning,we don't always need loop the deque,Just need to add a judgment,and May do less recursion，it is Obvious

@huangyiminghappy it seems that your assumption is, for most cases, there will just be one inflight request, and hence the batch to be enqueued would most likely need to be add to the last of the queue since very likely none of the batches in deque would have a sequence number, is that right?
Logically I think I agree with your reasoning here, and this optimization makes sense. But I'm wondering how much it is actually optimizing in practice -- looping over the deque should usually be very quick since the deque should be relatively short, like having single-digit number of batches.
Do you observe in your production environment, that the number of batches in deque could be very large and hence looping over it to the end could be very costly?

@huangyiminghappy it seems that your assumption is, for most cases, there will just be one inflight request, and hence the batch to be enqueued would most likely need to be add to the last of the queue since very likely none of the batches in deque would have a sequence number, is that right?
Logically I think I agree with your reasoning here, and this optimization makes sense. But I'm wondering how much it is actually optimizing in practice -- looping over the deque should usually be very quick since the deque should be relatively short, like having single-digit number of batches.
Do you observe in your production environment, that the number of batches in deque could be very large and hence looping over it to the end could be very costly?


firefox - import prompts don't work

This issue is a little more tricky... In contrast to other Browsers, Firefox immediately closes add-on popups once the focus leaves the popup. I'll see if I can find a workaround once I have a moment to spare.

If you want you can also attempt to fix it and make a pull request. I'd be happy to review it.


IJava kernel failing to connect

I have installed the Ijava kernel but when I try to switch the kernel in my notebook from python3 to Java it fails to connect every time. I am using jupyter Notebook with anaconda3, Here is the error I get when I try to connect to the java kernel:
"Error: could not open<EMAIL_ADDRESS>[I 11:01:25.029 NotebookApp] Kernel started: 30d3292d-826a-4ab4-8313-058aadc18507, name: java [I 11:01:28.030 NotebookApp] KernelRestarter: restarting kernel (1/5), new random ports Error: could not open<EMAIL_ADDRESS>[I 11:01:31.036 NotebookApp] KernelRestarter: restarting kernel (2/5), new random ports
Error: could not open<EMAIL_ADDRESS>[I 11:01:34.033 NotebookApp] KernelRestarter: restarting kernel (3/5), new random ports Error: could not open<EMAIL_ADDRESS>[I 11:01:37.044 NotebookApp] KernelRestarter: restarting kernel (4/5), new random ports
Error: could not open<EMAIL_ADDRESS>[W 11:01:51.947 NotebookApp] KernelRestarter: restart failed
[W 11:01:51.947 NotebookApp] Kernel 30d3292d-826a-4ab4-8313-058aadc18507 died, removing from map."
Any help is much appreciated

I double checked that the Ijava-1.3.0.jar file is in the directory, the .json file is there too

I also got an installation failure with the same error in windows 10

Did any of you solve this? I might have a similar issue with Google Colab


not enough values to unpack (expected 14, got 0)

Traceback (most recent call last):
File "C:/Users/user/Downloads/15647NeonBand.RarZipExtractorPro_g3b9h1p9bdemw!App/CPI_prediction-master/CPI_prediction-master/code/newtest1.py", line 153., in
setting) = sys.argv[1:]
ValueError: not enough values to unpack (expected 14, got 0)
################
I am getting this type of error. How can I solve it? Can you provide me the original code to me please....
My email id<EMAIL_ADDRESS>

In my environment (Mac or Linux), such error does not occur.
Could you clone this repository (git clone https://github.com/masashitsubaki/CPI_prediction.git) again and run the following two commands: preprocess_data.sh and run_training.sh in the code directory?

can you please send me the exact code with all the file location .....
my email id is<EMAIL_ADDRESS>On Mon 4 Mar, 2019, 10:29 PM Masashi Tsubaki<EMAIL_ADDRESS>wrote:

Closed #1 https://github.com/masashitsubaki/CPI_prediction/issues/1.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/masashitsubaki/CPI_prediction/issues/1#event-2178506887,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Asg4bEYQ4URhcXLxrdqIAo4uPvm6aX_Nks5vTVECgaJpZM4ba1FO
.

Perhaps, did you run "python run_training.py"  not "bash run_training.sh" ?

I am now trying on Linux....
when I run 'bash preprocess_data.sh' , I found some error' no module named rdkit'.
At first....
actually I installed anaconda python and make an environment of 'my-rdkit-env'.
there i found 'not enough values to unpack (expected 14, got 0)'
How can I install rdkit without conda?
kindly send me the full code or send me the .py file .... please...
<EMAIL_ADDRESS>

I do not know the details about RDkit.
I just installed RDkit with 'conda install -c rdkit rdkit'
https://anaconda.org/rdkit/rdkit
2019年3月8日(金) 14:30 shouvik-paul<EMAIL_ADDRESS>
I am now trying on Linux....
when I run 'bash preprocess_data.sh' , I found some error' no module named
rdkit'.
At first....
actually I installed anaconda python and make an environment of
'my-rdkit-env'.
there i found 'not enough values to unpack (expected 14, got 0)'
How can I install rdkit without conda?
kindly send me the full code or send me the .py file .... please...
<EMAIL_ADDRESS>—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/masashitsubaki/CPI_prediction/issues/1#issuecomment-470810283,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AmmcBvrBb1Fo52Nffy_UFkCA41Mue8_tks5vUfVkgaJpZM4ba1FO
.

please send me the original  .py file to my email<EMAIL_ADDRESS>

did you run it on python 3( anaconda 3) or python 2 ?

I installed anaconda python 3.7  and run in the terminal " bash run_training.sh ".
but I am facing this type of problem.
(base) acer@acer-Aspire-A515-51G:~/Downloads/test/CPI_prediction-master/code$ bash run_training.sh
Traceback (most recent call last):
File "run_training.py", line 7, in
import torch
File "/home/acer/anaconda3/lib/python3.7/site-packages/torch/init.py", line 102, in
from torch._C import *
ImportError: /home/acer/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so.1: undefined symbol: nvrtcGetProgramLogSize
(base) acer@acer-Aspire-A515-51G:~/Downloads/test/CPI_prediction-master/code$

Sorry for disturbing you....
Your code is 100% right.
I successfully run it today after installing and uninstalling many dependencies.
It takes much time to set my environment.
Thank you very much for your help.....
actually I want to implement attention based CNN for predicting Protein-Protein Interaction....(Protein-Protein Interaction using attention mechanism, pytorch).
If you give me some suggestions, I will be very grateful. Thank you once again.

@shouvik-paul
Hello, I'm sorry to bother you.
I'm new to programming, and I'm running this code now.
Now I have the same problem as you had.
How did you solve it at that time?
I am looking forward to receiving your reply!

Hello, did you successfully use the trained model?

@shouvik-paul Hello, I'm sorry to bother you. I'm new to programming, and I'm running this code now. Now I have the same problem as you had. How did you solve it at that time? I am looking forward to receiving your reply!

Hi @kiki-win
I have used the Linux environment at the end. I have faced a lot of problems with Windows Environment because of the versions of dependencies. But in Linux environment, I have changed some syntax based on the avaiable versions of that time and succeed. Let me know if it is not solved by you after minor changes in Linux Environment.

您好，我使用的是linux环境，麻烦问下您使用的版本是什么嘛，遇到了和您之前一样的问题


Extend ceph sc tests

We'll extend the Ceph storage class test to actually create a PVC and ensure that pods can read/write data from these volumes.
While at it, we're making some slight changes to the ceph bundle. At the moment, it deploys a single unit with two OSDs and node based replication (default). For this reason, the PGs are inactive and the rbd commands hang (and implicitly the Ceph provisioner). We'll fix this by using three units, each containing one OSD.
We're also updating the pytest command to include timestamps.
Applicable spec:
Overview

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

[ ] The charm style guide was applied
[ ] The contributing guide was applied
[ ] The changes are compliant with ISD054 - Managing Charm Complexity
[ ] The documentation is generated using src-docs
[ ] The documentation for charmhub is updated
[ ] The PR is tagged with appropriate label (urgent, trivial, complex)

I see that the scp command fails but unfortunately we don't have the stderr output. Fwiw it passed locally.
juju.errors.JujuError: command failed after 10 attempts: ['scp', '-i', '/home/ubuntu/.local/share/juju/ssh/juju_id_rsa', '-o', 'StrictHostKeyChecking=no', '-q', '-B', '/home/ubuntu/actions-runner/_work/k8s-operator/k8s-operator/tests/integration/data/test_ceph/ceph-xfs-pvc.yaml', 'ubuntu@<IP_ADDRESS>:/tmp/ceph-xfs-pvc.yaml']


Working on latest buildbot?

I'm using buildbot:latest from docker and i'm unable to make it work, it looks that the endpoints aren't working and as described in the buildbot page:

The API described here is version 2. The ad-hoc API from Buildbot-0.8.x, version 1, is no longer supported.

Is that the case?

hello @oprietop might be, I didn't test this project for a while, I will during the weekend, run it against the new version and adapt what needs to be adapted to make it run. thank you for raising the issue 👍

Thanks @ghophp, just got into buildbot and your dashboard looks really neat!


*(::Woodbury, ::Diagonal) is wrong

This can be seen by:
julia> using PDMatsExtras, LinearAlgebra

julia> W = WoodburyPDMat(2 .* ones(4,2), Diagonal(5 * ones(2,)), Diagonal(3 * ones(4,)));

julia> D = Diagonal(rand(4,));

julia> M1 = D * W
4×4 WoodburyPDMat{Float64, Matrix{Float64}, Diagonal{Float64, Vector{Float64}}, Diagonal{Float64, Vector{Float64}}}:
 30.9114  33.6469  33.466   25.5906
 33.6469  42.3242  39.1597  29.9444
 33.466   39.1597  41.8703  29.7834
 25.5906  29.9444  29.7834  24.4827

julia> M2 = D * Matrix(W)
4×4 Matrix{Float64}:
 30.9114  28.7548  28.7548  28.7548
 39.3714  42.3242  39.3714  39.3714
 38.9491  38.9491  41.8703  38.9491
 22.7746  22.7746  22.7746  24.4827

Similar for
julia> M1 = W * D
4×4 WoodburyPDMat{Float64, Matrix{Float64}, Diagonal{Float64, Vector{Float64}}, Diagonal{Float64, Vector{Float64}}}:
 30.9114  33.6469  33.466   25.5906
 33.6469  42.3242  39.1597  29.9444
 33.466   39.1597  41.8703  29.7834
 25.5906  29.9444  29.7834  24.4827

julia> M2 = Matrix(W) * D
4×4 Matrix{Float64}:
 30.9114  39.3714  38.9491  22.7746
 28.7548  42.3242  38.9491  22.7746
 28.7548  39.3714  41.8703  22.7746
 28.7548  39.3714  38.9491  24.4827

The reasons the tests pass is because they are scale of the Identity matrix so they are commutative. e.g. here. Changing Diagonal to a random will cause these tests to fail.
My fault. I added these in originally
WIP PR: https://github.com/invenia/PDMatsExtras.jl/tree/ar/remove_diagonal

Oh, interesting, I only saw this now, sorry (not subscribed to all activity in PDMatsExtras). As far as I can tell the PR #21 both fixes this and adds ChainRules. Is it possible to disentangle the two? It would make the review better

OK i'll look at that now. I already have an MR for it.

https://github.com/invenia/PDMatsExtras.jl/pull/19
Just need to work out why codecov is complaining

codecov is weird sometimes, so no need to spend more than 5 mins


Put lineups display different effects from existing data in json file

The process to test:

Run Main.java
add L/ n/Starting 5
put P/Alex Yeoh L/Starting 5
view L/ -> displays all players with lineups
view P/ -> displays all players only, but Alex Yeoh will still have lineup Starting 5 shown

Resolved


Design changes that would be necessary for minimal design and mobile i.e. scroll bar adjustments

Feature Request
Just my first impressions of styling the bot per the documentation... The controls should be true to the intended css functionality meaning, changing by a single whole number is not always ideal as a user may want to use 10, 0, 0, 10 for example.
Also, the scroll bar needs the ability to be adjusted, especially on mobile.  Having a thinner scroll bar may be ideal for may various applications.  On a mobile device a scroll bar is not necessary as touch panning up and down is very efficient.  Mobile does not mean only phone.
As well, opacity adjustments or blur for text boxes may be desirable. I have not fully vetted out the rgba so I am not entirely sure how that works.
Other than that it isn't too bad for making design adjustments but I would have to do more testing.

You're going to have to be more specific regarding your first request. what whole numbers are you interested in changing that you are unable to change right now?
Your other requests should be adjustable via idiosyncratic styling. If you try this sample out and still have trouble, feel free to let us know.

@corinagum the whole numbers in css are the border radious in a complete square/rectangle format i.e. 10, 10, 10, 10 is written shorthand as 10.  but if I want the right and bottom left only it would be something like 10, 0, 0, 10.
I will try the idiosyncratic styling to see if i can create what you're referring to.

@corinagum
So I have added the idiosyncratic styling and it's a little confusing on the context of the object and what each part is doing per se.  I will include my code below.  It works
One question I have is when you use the idiosyncratic styling you cannot use the styloptions(preferred) override method as it seems to not work in coordination with the styleset(non-preferred) method.  Is this the case?
Also, what is the different from the const variable setup to the specific file override... meaning, if I edit the const in styleset is that the exact same thing as editing the styleoptions method? i.e. the defaultstyleoptions.js method way of doing things
Lastly, if I edit the specific files beyond changing the names of those files i.e. root to base for example, would that cause a breaking change even if I create a css class inside of the specific file of per se root.js?
I think so I just want to confirm.
If it is not advisable and code could break should I do a pull request to have edits in place for the scroll bar styling through webkit?
here is the code below
        const styleSet = window.WebChat.createStyleSet({
          rootHeight: '100%',
          botAvatarInitials: 'BF',
          userAvatarInitials: 'CH',
          backgroundColor: '#131313',
          bubbleBackground: '#353535',
          bubbleBorderWidth: 0,
          bubbleBorderStyle: 'none',
          bubbleFromUserBorderWidth: 5,
          bubbleBorderColor: 'green',
          bubbleBorderRadius: 0,
          bubbleFromUserBorderColor: 'black',
          bubbleFromUserTextColor: 'white',
          bubbleTextColor: 'white',
          sendBoxTextColor: 'white',
          bubbleFromUserBackground: '#353535',
          sendBoxBackground: '#131313',
          sendBoxBorderTop: 'solid 0px #E6E6E6',
         });

        const styleOptions = {
          rootHeight: '100%',
          botAvatarInitials: 'BF',
          userAvatarInitials: 'CH',
          backgroundColor: '#131313',
          bubbleBackground: '#353535',
          bubbleBorderWidth: 0,
          bubbleBorderStyle: 'none',
          bubbleFromUserBorderWidth: 5,
          bubbleBorderColor: 'green',
          bubbleBorderRadius: 0,
          bubbleFromUserBorderColor: 'black',
          bubbleFromUserTextColor: 'white',
          bubbleTextColor: 'white',
          sendBoxTextColor: 'white',
          bubbleFromUserBackground: '#353535',
          sendBoxBackground: '#131313',
          sendBoxBorderTop: 'solid 0px #E6E6E6',

        }

        styleSet.textContent = Object.assign(
          {},
          styleSet.textContent,
          {
            // fontFamily: '\'Comic Sans MS\', \'Arial\', sans-serif',
            // fontWeight: 'bold',
            // cursor: 'crosshair',
          }
        );

        styleSet.root = Object.assign(
          {},
          styleSet.root,
          {
            // background: 'red',
            // cursor: 'crosshair',

            /* width */
            ' ::-webkit-scrollbar': {
              width: '3px'
            },

            /* Track */
            ' ::-webkit-scrollbar-track': {
              background: '#353535'
            },

            /* Handle */
            ' ::-webkit-scrollbar-thumb': {
              background: '#131313'
            },

            /* Handle on hover */
            ' ::-webkit-scrollbar-thumb:hover': {
              background: 'red'
            }

          }
        );

here is a screenshot of the final product

Changing the border radius worked fine for me:

This is my styleOptions change: bubbleBorderRadius: '10px 25px',
Idiosyncratic styling by nature should override your styleoptions changes if they are conflicting. @compulim, do you have input on this?
I'm inclined to say that scrollbar styling is not something we will be adding to Web Chat, but perhaps team members have a different opinion.
It sounds like you are deving off a fork of v4, which unfortunately we don't support. However, v4 of Web Chat is intended to be customizable without forking, which is supported. :) editing styleoptions is one of the ways we provide users with the ability to customize without having to make changes to the Web Chat code itself.
Glad to see you got the changes you were looking for. Closing this issue :)
I believe what you are saying about changing the files and component names is correct and this would be considered breaking changes.
Questions for the team -

Do we want to enable scrollbar adjustments to the app? Since scrollbar css is very browser specific my understanding is that this would be unnecessary.

@corinagum thanks for the tips. From what I see the styleset does override styleoptions... but at the core they are the same and use the same properties to change things. What's different is when you choose to edit a component right?  I'll give a code sample below.
So am I correct in saying until you choose to edit a component everything is the same? i.e. root or i am groot.  Meaning there would be no conflict.
Lastly, let me make this argument for the adjusting of the toolbar.  because of the bots smaller incorporation into a website or especially a mobile site the scroll bar on the side is very unsightly. Now, for example, Visual studio code does the scroll bar awesome.  It has opacity and it goes and gets larger upon hovering over the area.  That is a very ideal case because it covers every scenario of usage and looks very nice all around.
Also, chromium is pretty much the core browsing experience for about what 80 90% of the web?  I production, because of Angular and React we have had force our business into using chrome.  So, just web percentage alone I think it is a fair argument to include webkit changes for additional styling.


Update to Cadence v1.0.0

Description
Automatically update to:

onflow/cadence v1.0.0
onflow/flow-go-sdk v1.0.0
onflow/flow-go v0.38.0-preview.0.0.20241002124048-21cfe5aea5a8
onflow/flow-emulator v1.0.1

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.82%. Comparing base (d685b24) to head (3d840e1).

Files with missing lines
Patch %
Lines

tests/resources.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   43.82%   43.82%
=======================================
  Files          40       40
  Lines        3366     3366
=======================================
  Hits         1475     1475
  Misses       1631     1631
  Partials      260      260

Flag
Coverage Δ

unittests
43.82% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


issue when quickly goNext()

Hello,
I have a pdf (1.6Mo with images) that I converted with libreOffice from a ppt.
When I goNext() quickly (with a  button) the content of the pdf get sometimes completely crazy (head upside and mix between pages).
Any idea where this come from ?

Hi @soubok, thanks.
Can you create an example on jsbin?
I can't reproduce.

Issue fixed with version 1.2.4 and 1.2.5, but now I get the following error when the route is reloaded (with $route.reload()):
TypeError: pdfLoaderTask.destroy is not a function

testcase:
<!doctype html>

Hi @soubok, thanks for the report:

your example don't match Requirements, missing the worker
please, can you open an example on jsbin? it's very hard help you on a copy&paste
next time, open a new issue for new problem

Cheers

Hi @soubok, are you using a recent version of pdf.js? But anyway, perhaps it is a good idea to add something like if 183: if (pdfLoaderTask && (typeof pdfLoaderTask.destroy === 'function')) {
What do you think? If we agree that this is a way to go, I would offer to make the change later.

Hello, ( and sorry for points 2. and 3.).
I use PDF.js 1.1.469 (and my browser is the latest google chrome).
Note that the issue is not only related to reloading a route. When I leave then I come back to a view that contains angularjs-pdf, the same error appears.

@soubok, can you then update your pdf.js? The version currently used (https://github.com/sayanee/angularjs-pdf/blob/master/example/js/lib/pdf.js) is 1.2.131. Does that already help? In line 2009 there is a destroy function defined for PDFDocumentLoadingTask ;) Keep us posted!

Thnaks, the pdfLoaderTask.destroy error does no occurs any more with v1.2.131

I noticed the following warning in the console with v1.2.131:
Warning: Deprecated API usage: getDocument is called with pdfDataRangeTransport, passwordCallback or progressCallback argument

Good to hear. I would then say, we can close this issue.

@soubok, the warning you mentioned is definitely something, that has to be fixed in the future. But "the old way" is currently still fully supported. So at least for now, you can safely ignore this warning.


Many error like "Module 'Alamofire' has no member named ...."

I don't know how to solve it.
The file I removed and reload several times.

I solved this issue by changing the Build Active Architectures Only settings.

@Ethanator Thank you, "I solved this issue by changing the Build Active Architectures Only settings." worked for me !!

@Ethanator - That's not a "solution", doing that you are just postponing the error until the moment you want to Archive the app for the App Store. I'm struggling with this problem at the moment.

I've also run into this issue when installing with CocoaPods (3.1.4) and manually including the target. Changing the Build Active Architectures Only settings did not work for me. Are there any other potential solutions?

+1

I just started running into this with Xcode 12 (GM) on macOS Big Sur. It's not just Alamofire though. With another project it happens with a different framework. Reinstalled command line tools, checked xcode-select, etc. No love.


Machine learning

Hello @wilcockhue, can I know what specific issue you are facing.

Hello @wilcockhue, can I know what specific issue you are facing.

Sorry about that. I think I misclicked. Thanks!


test: Android theme containing a period

This is a reproducer for #1038.
The consumer generates AttrRef(type = "style", id = "AppTheme.Foo").
The producer generates AttrRef(type = "attr", id = "AppTheme_Foo").
https://github.com/autonomousapps/dependency-analysis-gradle-plugin/actions/runs/8265204574/job/22610349535?pr=1146#step:8:393
ResSpec > detects theme set in manifest (#gradleVersion AGP #agpVersion) > detects theme set in manifest (Gradle 8.6 AGP 8.4.0-alpha01) FAILED
    org.spockframework.runtime.ConditionFailedWithExceptionError at ResSpec.groovy:131
        Caused by: com.google.common.truth.AssertionErrorWithFacts at ResSpec.groovy:131

Thank you for this! It was a big help in narrowing down to the root cause. I'm replacing it with my own PR, so will close.


[update] license year

Thanks for the PR. Could you also update it here as well:

https://github.com/dask/dask/blob/master/docs/source/conf.py#L47
https://github.com/dask/dask/blob/master/docs/source/conf.py#L261

Updated PR to include changes in conf.py


Fire webhooks when repo is created from a template

Gitea version (or commit ref): 0b8b81e
Git version:
Operating system: arch
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
As requested from #9126
Currently webhooks aren't being fired when a repository is created from a template.
The same webhooks which are fired when a repository is created not via a template should be fired.

Looking at this, when I create repo from a template I get a 'repo created' webhook same as if I use the Web site. I'm not sure how to reproduce this or whats expected/not working.
I guess to be clear we only support repo created webhooks for organization owned repos and not individual users as far as I can tell:
https://github.com/go-gitea/gitea/blob/777015c2c2d2d74d98d15e145f9f8af04f1d9c8f/modules/notification/webhook/webhook.go#L100-L112
Is there a more detailed description of whats expected vs whats happening?

so not an issue?

sorry fired this off in a rush, the ‘push’ event is the one I’m thinking of:
I have a system webhook, it gets triggered with a ‘push’ event if you create a new repo but not if you create a new repo from a template.

When commits are created via repo creation (template or not), this function is used to set the environment, which would stop hooks from firing.
https://github.com/go-gitea/gitea/blob/0b8b81e02902a5c11829cce7f439f84731a8eaeb/models/helper_environment.go#L26-L34
https://github.com/go-gitea/gitea/blob/0b8b81e02902a5c11829cce7f439f84731a8eaeb/cmd/hook.go#L136-L139
https://github.com/go-gitea/gitea/blob/0b8b81e02902a5c11829cce7f439f84731a8eaeb/cmd/hook.go#L271-L274
I believe you could get a push event to fire if using the push-create feature, however.

Push event will trigger when use push to create and files are added, which seems right in the sense that somebody actually ran 'git push' in that situation. The create repo hook is still not a push event, but Gitea will consider the file commits (if there are any) as separate push events in that scenario -- they were manually pushed so that seems somewhat correct.
So if something should be triggered specifically by repo creation it should look for repository event which is what the 'repo creation' hook is considered and the only hook guaranteed to run when a new repo is created no matter how.

@mrsdizzie ahh ok, but the repo creation webhook is only supported in an organisation context - so using a system webhook, creating a repo as a user (not in an org), then expecting to see any webhook fired is expected behaviour right now? (until the work is done to support that on the user level)
If so looks like this is a feature request rather than a bug report - apologies for the confusion & back-and-forth everyone!

I'm going to move this to 1.13 as it's currently intended behavior.  🙂


Support sort Desc

Find a way to map descending sort fields

Maybe just support order fields by includeing enums with __DESC at the end, and then parse this out in the extract phase

I tried out an alternative design for my own project -- I created a new input object that just combines the field enum with a direction enum:
Schema example:

enum SortDirection {
  DESC
  ASC
}

enum ExampleObjectSort {
  ID
}

input ExampleObjectSortSpec {
  field: ExampleObjectSort!
  direction: SortDirection
}

exampleObjects(sort: [ExampleObjectSortSpec!]): [ExampleObject!]!

This design seemed slightly better to me than specifying ASC/DESC sorting for each field in the enum. I would be happy to submit a PR for supporting this kind of sorting input if this is an API you like.


remove lkm

Description
Very simple changes, just removing any code involves loadable kernel modules.
Type of change

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
passed the make test

I agree with Nick that a more comprehensive explanation as to why these changes were necessary would be helpful. However, the changes themselves look good to me.


Settings parameters are reset after firmware upgrade

Describe the bug
After a firmware upgrade, the settings parameters "UseTLS" and "SDCardSupport" seem to be reset to their default values.
To reproduce

Install the Docker ACAP
Set the parameters to non-default values using the web GUI
Reinstall the firmware (not using factory default)
Check the values of the parameters

Environment

Axis device model: Q1615 Mk III
Axis device firmware version: 11.0
Version: Docker ACAP 1.2.3 (latest beta at the time of writing)

This was a general problem with parameters, where the default parameters were active after a firmware upgrade. This was the case until parameters were reloaded for some reason, such as after a restart of the device. This will be fixed in an upcoming AXIS OS firmware release (11.1).


Fancyzones editor doesn't open but instead displays a message about not being able to load an assembly.

Environment
Windows build number: [Version 10.0.19042.330]
PowerToys version: 0.19
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Steps to reproduce
Open the fancyzones editor with the shortcut [win + `]
Expected behavior
The Fancyzones editor opens.
Actual behavior
The message below is displayed.

Other things I've done
I tried opening the fancy zones editor by going to C:\Program Files\PowerToys\modules\FancyZones and running fancyzoneseditor.exe, it opens after displaying a path cannot be null error.

@Dakael
try do uninstall and reinstall PowerToys.
Running C:\Program Files\PowerToys\modules\FancyZones\fancyzoneseditor.exe directly is not supported, so the error you are getting is expected.

I've done that, running it from the path was something that was suggested in a different issue to see if the .net framework is broken.

@Dakael
reinstalling PowerToys didn't fix the problem?
Try downloading the installer again https://github.com/microsoft/PowerToys/releases/tag/v0.19.1

Just tried it again, issue still persists. Now on powertoys 19.1

@Dakael
can you try quitting PowerToys and moving this folder
"C:\Users\%USERNAME%\AppData\Local\Microsoft\PowerToys"

to the desktop and then restart PowerToys.

Issue still occurs after doing this, and updating to 0.19.2

I have the same issue since upgrading from 0.18.2 to 0.19.0.
I've been through 0.19.1 and now 0.19.2 and still have the same issue
Microsoft Windows [Version 10.0.17763.1282] (its a work managed laptop so I can't upgrade)

That key does not exist for me.

Can you go to C:\Program Files\PowerToys\modules\FancyZones and open the System.Numerics.Vectors.dll properties?

Looks like mine matches the one you posted.

I'm running out of ideas of what the problem could be.
Can you give it a try to manually install .Net Framework 4.7.2?
https://dotnet.microsoft.com/download/dotnet-framework/net472

Says I already have this or a later version, isn't it because it is built into the OS now?

Is expected, but I wanted to make sure.

I have the same answers as Dakael. The reg key doesn't exist, System.Numerics.Vectors.dll properties looks the same as yours and i have .Net framework installed already.
I'm still on PowerToys 0.18.2 and FancyZones is working correctly. The issue only pops up when I move to a newer version

@millers
thanks for the information.

just tried v0.20.1 (v0.20 wouldn't install) and still have the same issue. rolled back to v0.18.2 again and the editor is still working there

@millers
thanks for the update. We still haven't found the root of this problem.

@Lotzof  from https://github.com/microsoft/PowerToys/issues/6147
was it a first installation or was it working previously?

For me it was an existing install working correctly and the upgrade broke it. Rolling back fixed the issue

@Lotzof from #6147
was it a first installation or was it working previously?

It was a first install.

Alright an update, as of Powertoys v0.27.0, the error still appears (twice now), but the zone editor now launches. The app is actually usable now.

Closing this issue in favor of https://github.com/microsoft/PowerToys/issues/7937
If someone is still affected by this bug, I've uploaded an unsigned private build that might solve the issue, please see https://github.com/microsoft/PowerToys/issues/7937#issuecomment-737263507
Thanks.


Queries with date variable brokes UI

Is the issue already present in https://github.com/cloudera/hue/issues or discussed in the forum https://discourse.gethue.com?
No
Describe the bug:
After reloading page with date query or load that query from query history all variable editboxes are shown and query history became hidden
Steps to reproduce it?

create table with date type -  create table t2.dtest (i int,tdate DATE)
add some values in the table - INSERT into t2.dtest values (3, '1990-01-02'), (4, '2025-01-01')
run query with date variable - select * from t2.dtest where tdate = "${datestr}"
refresh page by clicking Refresh button in browser or pressing F5

Hue version or source?
CDH 6.3.4

@akaAPal thanks for reporting :-) I can't reproduce this in our nightly builds. Which version of Hue are you using and which browser?

@bjornalm  This issue was there on only CDH-6.3.4 hue ( hue-3.9) this has been fixed already now.

Hue™ 4.4.0 - cdh6.3.4
In which version that was fixed?

@Akhilsnaik ^


Add support nested groups on the Repositories page

Fix for #725.
This includes #1224 from @ybosy, because a lot of the code of it was reusable.
Also covers  #527

(Panel contains a lot of copy-paste code from RepositoriesPanel :( But this way I was able to keep the original RepositoriesPanel without changing it a lot. ...this could be done a lot easier after a wicket upgrade in my opinion ;))

Just got a task to realize similar functionality. Nice to see it done!

What would you think about listing repositories first?

Leaving out the "guard rails" would look cleaner, but with many folders it might get difficult to see what group a repository belongs to. On the other hand, this is the opposite sorting to what one is used from a file explorer.

I like your approach a lot. looks much better in my opinion :+1:

Closed by a squash merge to master in commit 0bace7e


[stable/prometheus-operator] manifest_sorter.go:192: info: skipping unknown hook: "crd-install"

Describe the bug
Deployment of Prometheus-operator become successful but still getting warning/error of manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
Version of Helm and Kubernetes:
Helm Version
version.BuildInfo{Version:"v3.3.0", GitCommit:"***", GitTreeState:"dirty", GoVersion:"go1.14.7"}
Kubectl Version
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.0", GitCommit:"***", GitTreeState:"clean", BuildDate:"2020-08-26T14:30:33Z", GoVersion:"go1.15", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8+k3s1", GitCommit:"***", GitTreeState:"clean", BuildDate:"2020-08-14T20:42:29Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}

k3s Version
k3s version v1.18.8+k3s1 (6b595318)
Which chart:
Stable release of prometheus-operator version 9.3.1
What happened:
Getting Warning/error of manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
manifest_sorter.go:192: info: skipping unknown hook: "crd-install"
NAME: prometheus-operator
LAST DEPLOYED: Thu Sep 10 18:49:12 2020
NAMESPACE: default
STATUS: deployed
REVISION: 1
NOTES:
The Prometheus Operator has been installed. Check its status by running:
  kubectl --namespace default get pods -l "release=prometheus-operator"

Visit https://github.com/coreos/prometheus-operator for instructions on how
to create & configure Alertmanager and Prometheus instances using the Operator.

i know it's successfully installed but cant figure out which crd is not installing
NAME                                    CREATED AT
addons.k3s.cattle.io                    2020-08-30T14:00:47Z
helmcharts.helm.cattle.io               2020-08-30T14:00:47Z
aplogconfs.appprotect.f5.com            2020-09-02T11:25:37Z
appolicies.appprotect.f5.com            2020-09-02T11:25:37Z
globalconfigurations.k8s.nginx.org      2020-09-02T11:25:37Z
policies.k8s.nginx.org                  2020-09-02T11:25:37Z
transportservers.k8s.nginx.org          2020-09-02T11:25:37Z
virtualservers.k8s.nginx.org            2020-09-02T11:25:37Z
virtualserverroutes.k8s.nginx.org       2020-09-02T11:25:37Z
alertmanagers.monitoring.coreos.com     2020-09-09T12:49:09Z
thanosrulers.monitoring.coreos.com      2020-09-09T12:49:10Z
prometheuses.monitoring.coreos.com      2020-09-09T12:49:09Z
servicemonitors.monitoring.coreos.com   2020-09-09T12:49:09Z
podmonitors.monitoring.coreos.com       2020-09-09T12:49:09Z
prometheusrules.monitoring.coreos.com   2020-09-09T12:49:09Z

What you expected to happen:
install chart without any warnings/errors. and can't figure out which crd is not installing?
How to reproduce it (as minimally and precisely as possible):
I am using k3s on my Majaro 20.0.3-gnome-200606 Arch Linux on i5-6200U with 8GB RAM. and export KUBECONFIG=/etc/rancher/k3s/k3s.yaml cause using k3s and kubectl so its same after KUBECONFIG env.
Anything else we need to know:
i don't think of anything else

🚧 This chart is now deprecated in the stable repo.
Further development has moved to prometheus-community/helm-charts. The chart has been renamed kube-prometheus-stack to more clearly reflect that it installs the kube-prometheus project stack, within which Prometheus Operator is only one component.
If applicable, please re-open this issue there. Thanks!


Address lgtm.com alerts based on CodeQL analysis

Fixes #1384
See report at https://lgtm.com/projects/g/vmware-tanzu/antrea/alerts/?mode=list
After merging this, I will enable the lgtm.com status check for automated PR review

Codecov Report

Merging #1724 (9627933) into master (9d3d10b) will decrease coverage by 10.96%.
The diff coverage is 51.62%.

@@             Coverage Diff             @@
##           master    #1724       +/-   ##
===========================================
- Coverage   63.31%   52.35%   -10.97%
===========================================
  Files         170      184       +14
  Lines       14250    15786     +1536
===========================================
- Hits         9023     8265      -758
- Misses       4292     6605     +2313
+ Partials      935      916       -19

Flag
Coverage Δ

kind-e2e-tests
37.12% <35.78%> (-18.27%)
:arrow_down:

unit-tests
40.38% <37.66%> (-0.90%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/antrea-agent/agent.go
0.00% <0.00%> (ø)

.../agent/apiserver/handlers/networkpolicy/handler.go
58.33% <ø> (ø)

...gent/controller/noderoute/node_route_controller.go
45.83% <0.00%> (-0.64%)
:arrow_down:

pkg/agent/proxy/proxier_linux.go
0.00% <0.00%> (-25.00%)
:arrow_down:

pkg/agent/proxy/types/groupcounter.go
0.00% <0.00%> (-95.00%)
:arrow_down:

pkg/agent/proxy/types/types.go
0.00% <0.00%> (-84.62%)
:arrow_down:

pkg/agent/route/route_linux.go
43.44% <ø> (-0.65%)
:arrow_down:

pkg/agent/stats/collector.go
97.72% <ø> (ø)

pkg/agent/types/networkpolicy.go
37.50% <ø> (-45.84%)
:arrow_down:

pkg/antctl/antctl.go
100.00% <ø> (ø)

... and 142 more

Codecov Report

Merging #1724 (9627933) into master (9d3d10b) will decrease coverage by 10.96%.
The diff coverage is 51.62%.

@@             Coverage Diff             @@
##           master    #1724       +/-   ##
===========================================
- Coverage   63.31%   52.35%   -10.97%
===========================================
  Files         170      184       +14
  Lines       14250    15786     +1536
===========================================
- Hits         9023     8265      -758
- Misses       4292     6605     +2313
+ Partials      935      916       -19

Flag
Coverage Δ

kind-e2e-tests
37.12% <35.78%> (-18.27%)
:arrow_down:

unit-tests
40.38% <37.66%> (-0.90%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/antrea-agent/agent.go
0.00% <0.00%> (ø)

.../agent/apiserver/handlers/networkpolicy/handler.go
58.33% <ø> (ø)

...gent/controller/noderoute/node_route_controller.go
45.83% <0.00%> (-0.64%)
:arrow_down:

pkg/agent/proxy/proxier_linux.go
0.00% <0.00%> (-25.00%)
:arrow_down:

pkg/agent/proxy/types/groupcounter.go
0.00% <0.00%> (-95.00%)
:arrow_down:

pkg/agent/proxy/types/types.go
0.00% <0.00%> (-84.62%)
:arrow_down:

pkg/agent/route/route_linux.go
43.44% <ø> (-0.65%)
:arrow_down:

pkg/agent/stats/collector.go
97.72% <ø> (ø)

pkg/agent/types/networkpolicy.go
37.50% <ø> (-45.84%)
:arrow_down:

pkg/antctl/antctl.go
100.00% <ø> (ø)

... and 142 more

One alert remains after this patch: https://lgtm.com/projects/g/vmware-tanzu/antrea/snapshot/3845143e4321166cfa66c2df94e6b9861dacb2ac/files/pkg/ovs/ovsctl/ovsctl_others.go?sort=name&dir=ASC&mode=heatmap#xee2d4bf6ffb82c1a:1
I have added some validation code for the user-provided input. Either it is not enough or the CodeQL analysis cannot detect that this is no longer an issue. Unfortunately there is no support for suppressing warning for a single code path (yet?), and I do not want to suppress all warnings for that sink unconditionally as additional codepaths may have issues in the future.

One alert remains after this patch: https://lgtm.com/projects/g/vmware-tanzu/antrea/snapshot/3845143e4321166cfa66c2df94e6b9861dacb2ac/files/pkg/ovs/ovsctl/ovsctl_others.go?sort=name&dir=ASC&mode=heatmap#xee2d4bf6ffb82c1a:1
I have added some validation code for the user-provided input. Either it is not enough or the CodeQL analysis cannot detect that this is no longer an issue. Unfortunately there is no support for suppressing warning for a single code path (yet?), and I do not want to suppress all warnings for that sink unconditionally as additional codepaths may have issues in the future.

/test-all

/test-all

/test-e2e
/test-networkpolicy

/test-e2e
/test-networkpolicy

/test-e2e

/test-e2e


[Feature] skip offline players when sleeping

Is your feature request related to a problem? Please describe.
I have a problem not being able to sleep when there are players who are afk
Describe the solution you'd like
so i suggest to add a feature to ignore afk players when other players want to sleep
Additional context
Add any other context or screenshots about the feature request here.
Versions

Minecraft: 1.21.1

Will look into this, nice feature idea :)

Feature is now available in 1.1.1, thank you for the suggestion 🙏


pip version is outdated

Hi! pip version should be updated before running poetry!
WARNING: You are using pip version 19.2.3, however version 20.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Base image has been updated https://github.com/docker-library/python/commit/44ded7c92b0c20abbeaa88785751eb0822d05ced


Gersi gridworld

Add a grid-world environment with tests to the MDPs package for users.

The doc test fails because it is missing an #output
"┌ Error: invalid doctest block in src/recipes.md:65-74
│ Requires julia>  or # output
│
│ ```jldoctest"


Create ponzu-cms#ponzu.toml

include @ponzu-cms / ponzu in awesome-cms repository

[x] verified that the CMS I'm adding is still maintained.
[x] read CONTRIBUTING.md.
[x] did not generate README.md.

Whoa, our first Go CMS. Thanks, @nilslice!

@mutewinter - thanks for putting together a great list! Glad to see Ponzu on it :)


Git: Make the logic to create a missing local tag more robust

As parsing human-readable output is generally fragile, instead check
whether the revision is a remote tag in order to conditionally create a
matching local tag.
Also, as right now (before the scan-by-repository topic is implemented)
there could be race conditions with multiple paths from a single Git
repository being downloaded in parallel, force to create the local tag
in case it already exists.
Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

@heliocastro can you please check whether this makes your bogus fatal: tag '1.1.1' already exists output go away?

The rationale was wrong, and I had to tweak the implementation slightly.


SCGM example in tutorial

Hi,
I think there might be some flaw in the example uploaded, please correct me if I'm wrong.
According to SCGM challenge, we had to segment the GREY MATTER. Here is a snapshot of what training data and the labels look like (this is in ITKSnap a viewer for medical images, I have loaded the site1-sc01-image.nii.gz from the training set with the corresponding mask site1-sc01-mask-r1.nii.gz)

My understanding is that the grey matter is the red label stuff in the above image, so my trained model should take a slice (or group of slice) as input and output a mask which only highlights red rigion like stuff, however after few epochs (25 epochs) of running the code given in the example we get something like

My doubt being why is the ground truth label a white blob-like stuff, should it not be very narrow and tiny like the red structure in the above ITKSnap image (and hence the prediction should also be something very fine not a blob-like structure)
What is being considered as ground truth in the code?
Please clarify.
Thank you so much for this amazing effort!!

Hi @udion, thanks for the feedback, I pre-processed the dataset before to remove the WM mask from the labels and I completely forgot to mention. I'll add soon a filter to do that in medicaltorch to avoid the pre-processing work, but meanwhile you can just remove the WM mask and leave the GM mask only on the label files.

@perone
I see that all the scans consist of 3 SLICES (am I right?)
and if that is the case then does slice_axis=2 mean that it will only train and test using axis=2?
and if that is the case does that mean that the example given in documentation ignores the other 2 slices and hence we may have to train other models with different slice axis (or a different model which processes 3 slices together)?

Hi @udion, slice_axis=2 means that it will slice the volume on the 2 dimension, in this case on the axial dimension. It doesn't mean it ignores the other axis, just that it is using one axis to train. There are many approaches to train, including the use of 3D kernels, however the model I made available is a 2d slice-wise model.

@perone
Few questions about the example code..

Original nifti scans and labels have the shape 512 X 512 X 12 you are using mt_transforms.CenterCrop2D((200, 200)) this means the tensor will consider only 200 X 200 region in the frame, right? if so then this assumes that in all the frames the required region will be inside a central region of 200 X 200 right?

Since there are 4 labels available for every scan, I am assuming you are using the mean label to train the network?

@perone
I wanted to customize this for my own problem (segmentation of medical RGB image dataset, it's not MRI/CT) I was able to change the dataloader and model appropriately and my model is training, the task is still the same that the model should output a binary mast, so I am using the same dice loss setup which you have in the example, but my training and validation dice losses are negative
Any clues/pointers what might be wrong?

Hi @udion, regarding the questions related to the cropping and 4 labels per rater, take a look on the article from Nature Scientific Reports called "Spinal cord gray matter segmentation using deep dilated convolutions" where we describe our steps and details about it.
Regarding your validation dice being negative, it is supposed to be like that, take a look at this line here, we minimize the negative Dice. Always plot some samples of the predictions to check it as well, it's easier to see what is going on on the network.


History of task declaration is not kept

Hello,
After reading at http://www.ukiws.demon.co.uk/GFAC/documents/tech_spec_gnss.pdf p26 about C RECORD - TASK (Pre-flight Declaration), it seems to me that an IGC file can have several tasks declared and "a declaration continues to be valid until it is replaced by a new one".
So there's at a given instant only one active task but several tasks can exist in a whole IGC file.
Reading at
https://github.com/Turbo87/aerofiles/blob/4dc41ca08d39ff9eb3be7eb57218e2d21e1e2745/aerofiles/igc/reader.py#L70
it seems that history of tasks in not kept in your implementation and maybe it should be considered.
An implementation could be to have
https://github.com/Turbo87/aerofiles/blob/4dc41ca08d39ff9eb3be7eb57218e2d21e1e2745/aerofiles/igc/reader.py#L31
replaced by
task = [[], []]

and have
https://github.com/Turbo87/aerofiles/blob/4dc41ca08d39ff9eb3be7eb57218e2d21e1e2745/aerofiles/igc/reader.py#L68-L73
replaced by
 if task_item['subtype'] == 'task_info':
     del task_item['subtype']
     task_item["waypoints"] = []
     task[1].append(task_item)
 elif task_item['subtype'] == 'waypoint_info':
     del task_item['subtype']
     task[1]['waypoints'].append(task_item)

I haven't tested it as I'm currently working on my Julia implementation but would be very pleased to have your opinion about my interpretation of this.
Kind regards

hmm, I guess that could be interpreted like that. but since it has to appear before the first B record I'm wondering if that actually makes sense. I would assume it means: if you switch off the flight recorder, switch it on again on another day the same task declaration should still be active.
in all of the IGC files I've seen so far I've never encountered one with multiple task declarations.

my guess was that some IGC loggers accept changing task during flight but in such a case declaration of a second task could only occur after some B records (covered by first task declaration).

some IGC loggers accept changing task during flight

nope, that is strictly forbidden. the task must be set prior to takeoff and can not be changed anymore afterwards.

Well! so this part of IGC spec is quite unclear because "The lines for Takeoff and Landing are for information and are not part of the official IGC Declaration".
I have never seen IGC file with multiple task declarations but it seems to be possible by replacing a task declaration by a new one.
Maybe we should ask for clarification to the GFAC = The IGC GNSS Flight Recorder Approval Committee especially to its chairman at the time of publication of spec (Ian Strachan).
Your opinion?

so this part of IGC spec is quite unclear because "The lines for Takeoff and Landing are for information and are not part of the official IGC Declaration".

while that is true, most FRs these days have an automatic takeoff/landing detection and will only start the IGC file recording once takeoff is detected. others even require you to restart the device after a task declaration (e.g. Flarm).

An other part of spec seems to prove what your are saying...
p4 of pdf (page named iii)
Appendix A – The IGC Data File Standard
A3 Single Instance Data Records (A, H, I, J, C, D, G Records)
A4 Multiple Instance Data Records (B, E, F, K, L Records)

C records are single instance data records.

This issue is quite old and I dont see a clear bug/recommendation/feature request.
Could you please provide an IGC file that shows what you are requesting. If it is pure theoretical, then I want to close it, until we find a IGC file which shows the problem. Please reopen then.


Issue with mj-html-attributes and templating language tags <% %>

Describe the bug
When we use mj-html-attributes and a templating language like EJS inside a compontent, a tag <%= my_variable %> is not preserved as is, but it is rendered as <%= my_variable="" %="" />.
To Reproduce
Steps to reproduce the behavior:

Copy and paste the following code in the try-it-live tool:

<mjml>
  <mj-head>
    <mj-html-attributes>
      <mj-selector path=".custom div">
        <mj-html-attribute name="data-id">42</mj-html-attribute>
      </mj-selector>
    </mj-html-attributes>
  </mj-head>
  <mj-body>
    <mj-section>
      <mj-column>
        <mj-text css-class="custom">
          Hello <%= world %>
        </mj-text>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

See error

Expected behavior
We expect the tag <% ... %> to be rendered as is.
MJML environment

MJML Version 4.9.3
MJML try-it-live tool

Yup, I think this should be mentioned in the doc as it's not something we can fix. When Cheerio parse the document, any "look alike" xml/html will be treated as a xml tag so it will alter the output HTML


[Feature Request] Sync Attachment on demand and clear them periodically to save up disk on edge device

Scenario: It's nice to sync all .md files across all devices, but it's not quite a good idea to sync all attachments across all devices, especially on mobile side. For example, I just wanna view some of the pdfs occasionally, not all the pdfs should be synced to mobile side. I would like to sync/download the attachments when it's needed.
Possible Feature:

When opening a pdf/some other attachments(some event occurs), livesync client check if the attachment exist on remote couch db(either make a communication/save some meta info about the file on client side to indicate), if so, sync the file from couch db.
When editing the attachments, livesync sync as usual.
After the attachments are not required for a period of time/disk usage is not enough, it gets deleted(maybe leaving out some meta info data there to indicate that remote couch db has this file)

Maybe this feature could be named as a cache feature.

Thank you for the request! I think this might be a useful feature.
However, we have a few things to solve.

Possibly, we should have a stub file to handle the existence. Otherwise, we cannot fetch that again if the file is not referenced from anywhere.
Self-hosted LiveSync always handles the file events, but cannot intercept them. So, we should hook the file opening or create events. This possibly causes some unexpected behaviour (i.e., clicking [[a.png]] without real a.png makes a.png.md).
From the point of view of other plugins, it may be a bit difficult to interpret.
We cannot rebuild the database as in the past.

However, indeed it might be a useful feature (especially at the initial setup).
I hope to think about it more deeply in the time that I can focus on it.

For now, I use pdf++ plguins's dummy pdf feature. Maybe it could be used as a reference.


python3Packages.skein: init at 0.8.0

Motivation for this change
This PR adds the skein package to python3Modules. The build process is a bit hairy as it depends on an integrated Maven build from within the setup.py. I pulled it out and build the JAR separately and made the fetching of the Java dependencies into a fixed output derivation.
The Maven build downloads some native executables for dealing with ProtocolBuffer generation and thus needs some patchelf magic which further complicates the build.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @FRidh

Thank you for your suggestions @jonringer! All of them applied!

Gentle ping for another round of reviews @jonringer @FRidh


question: create a tfsec check to validate that there is a backend configuration

We want to ensure this is defined in the terraform code.
terraform {
  backend "azurerm" {}
}

Can this be enabled with a tfsec check?

I'm unclear what's the ask here. Our efforts have moved to Trivy. If you still see a need for this, please open a discussion in the Trivy repo.


add missing material lib to presentation-widget

Not sure which changes caused this but recently my Android Studio always got this error:
ERROR: AAPT: tachiyomi.presentation.widget.test.presentation-widget-mergeDebugAndroidTestResources-70:/values-v31/values-v31.xml:3: error: resource color/m3_sys_color_dynamic_light_surface (aka tachiyomi.presentation.widget.test:color/m3_sys_color_dynamic_light_surface) not found.
Although CI build still works fine on Github Action.

I got that every time I tried to clean and rebuild.
Finally a fix.

But it only happens from yesterday, not sure why.

Probably related to the glance version bump we did a week ago


refactor: JavaScript

Trying to tidy up all of the JavaScript so that it's easier to understand and maintain.

Codecov Report

Merging #805 (761e49e) into master (c16d696) will increase coverage by 81.51%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #805       +/-   ##
===========================================
+ Coverage        0   81.51%   +81.51%
===========================================
  Files           0      117      +117
  Lines           0     4475     +4475
  Branches        0      625      +625
===========================================
+ Hits            0     3648     +3648
- Misses          0      712      +712
- Partials        0      115      +115

Impacted Files
Coverage Δ

src/CreeDictionary/tests/API_tests/test_views.py
100.00% <0.00%> (ø)

...tionary/CreeDictionary/templatetags/relabelling.py
100.00% <0.00%> (ø)

src/CreeDictionary/API/search/ranking_test.py
100.00% <0.00%> (ø)

...002_change_example_site_to_cree_dictionary_site.py
76.92% <0.00%> (ø)

...abaseManager_tests/test_xml_consistency_checker.py
100.00% <0.00%> (ø)

...Dictionary/API/migrations/0003_wordform_indexes.py
100.00% <0.00%> (ø)

...c/CreeDictionary/CreeDictionary/paradigm/filler.py
88.61% <0.00%> (ø)

src/CreeDictionary/CreeDictionary/wsgi.py
100.00% <0.00%> (ø)

src/CreeDictionary/API/search/query_test.py
100.00% <0.00%> (ø)

...aseManager_tests/test_cree_inflection_generator.py
100.00% <0.00%> (ø)

... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c16d696...761e49e. Read the comment docs.


Hello_world

Rust Version:
Runtime version (e.g. Tokio):
OS Version:

Steps to Reproduce:

Hello

Hi!
Please use this issue tracker for issues and feature requests only 😉 If you need help getting started with contributing, please feel free to reach out.


between fails on zero inputs

@rultor release, tag is 0.0.31

@rultor release, tag is 0.0.31

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.31

@yegor256 Done! FYI, the full log is here (took me 8min)


Can we update to llhttp-ffi 0.5.0

Can we update to llhttp-ffi 0.5.0

thank you!   For some reason I can't spot #744 in github issues - either open or closed - but I can definitely get to it via the link.
sorry for the redundant request