Configuration wizard stuck

System Health details
x
Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue
Hi.  I have downloaded the code as per your instructions and restarted HA. I can now find the integration and it starts to loads the configuration wizard but the circle just spins and it won't move past this point. I am running HA in a NAS within docker if that makes a difference. Any tips appreciated as I would love to make this work. Thanks
Reproduction steps

Created directory and downloaded files
Restarted HA
Ran the integration and the wizard started
...

Debug logs
x

Diagnostics dump
No response

Restarted a second time and now it asks for login credentials

Hi @morgsman no worries. I've occasionally seen this sort of thing when the Emerald API is having some sort of issue. It may be that there was one when you first tried and it had resolved itself by the time you restarted again.
If it does happen again, are you able to post any relevant logs? There should be something in there listing the issue, and it might be something I can bubble up to the UI rather than just hanging (which I agree is not great)

Thanks Ross.I think you are right as it’s all working perfectly now. Thanks so much for developing this. Regards - ChrisOn 8 Nov 2024, at 10:52 AM, ross-w @.***> wrote:
Hi @morgsman no worries. I've occasionally seen this sort of thing when the Emerald API is having some sort of issue. It may be that there was one when you first tried and it had resolved itself by the time you restarted again.
If it does happen again, are you able to post any relevant logs? There should be something in there listing the issue, and it might be something I can bubble up to the UI rather than just hanging (which I agree is not great)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


Typo on personal library project in quality assuarance

There is an extra quote in the string below

You can send a DELETE request to /api/books to delete all books in the database. The returned response will be the string 'complete delete successful if successful.

it can be removed as it isn't required

You can send a DELETE request to /api/books to delete all books in the database. The returned response will be the string complete delete successful if successful.

Here is the file: https://github.com/freeCodeCamp/freeCodeCamp/blob/15c19a44a7763755ccaaad228c1a325cac9914b6/curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md#L174?plain=1

If you would like to fix this issue, please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this.

Can I work on this issue?

Yea, feel free to open PR, after you have read our contribution guideline

@Sboonny I have created the pull request, please review it.

Can i also contribute to this issue?

Yes, there is no pull request that follows the contribution guideline. If you open PR that follows it, that pr will be merged and closes the issue with it

Thank you @Sboonny


tests: add function_used_twice example

Codecov Report

Merging #83 (7e73bbd) into master (817b6ca) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          390       390
  Branches        46        46
=========================================
  Hits           390       390

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update ABlog CSS now that it has better-labeled HTML

I noticed that ABlog made a release that added the extra HTML structure to make it much easier to style.
For example: their landing page now has sidebar items that look like:

  Recent Posts

      25 July - ABlog v0.11 released

  ... etc etc

We should update our ABlog CSS to utilize these new HTML classes for more predictable behavior.

This one is actually not quite done - as the new release of ABlog will change their CSS classes and we'll need to update again.

ah sorry I just merged your PR I thought it was good to go

No worries! That was just the bulk of the fix but not everything 🙂

Note that ablog has made this release so we're now getting warnings in our docs - we should update and attach this to the next release. I can try to do it this weekend since my blog uses this :-)


Preset for tofu shops

Very common in Japan. 豆腐屋
shop=deli
product=tofu

See https://wiki.openstreetmap.org/wiki/JA:How_to_map_a
Alt names: tofu seller; tofu maker

closing because of the (currently still) too low usage. If this gains traction, we can reconsider it in the future, of course :relaxed:
see also #27


gnutls: fix guile bindings

Motivation for this change
The gnutls derivation fails to build if the guileBindings argument is set to true: It attempts to install some of the guile bits in what it presumes to be the system-wide guile path, i.e. inside the guile output path.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I confirmed that it builds, and that the gnutls module is then available in the guile repl.

I had exactly this patch sitting on my machine for a couple of months...

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/guile-module-packaging-guidelines/5909/1

Hi, might this be merged?

This seems to be a strict improvement over the status quo, as it only touches the broken part of gnutls. Merging for now since the author seems to be unavailable for now and the only outstanding request for changes is not terribly important. It would be nice to adopt @JohnAZoidberg's suggestion in a follow-up though if somebody wants do to that.

Thanks for fixing this @Thra11!


fix(hadolint): add --no-cache-dir to pip install

hadolint has what I expect is a new rule that Dockerfiles should use --no-cache-dir on pip install. This helps promotes slimmer container images.
This change is currently blocking #65 non urgently (because there are other blockers too). Will raise priority if this becomes the last blocker.

LGTM, but if we're trying to make slimmer packages, will the identity samples work with python:3.8-slim?

It probably should use -slim, I'll send another PR to that effect later. For now I'm unblocking the hadolint test.


Fix doc typos and simplify link-to-pdf markups

Please note that the corresponding PDFs are not updated/regenerated.


Develop

Hello @EdinsonRequena! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file 04_introduccion-al-computo-con-python/modulo_IV/clase06-list-comprehesion.py:

Line 11:28: E261 at least two spaces before inline comment
Line 11:80: E501 line too long (94 > 79 characters)


Fixes export statement in .d.ts to reflect new syntax 1.8..

So we can use them in Visual Studio and get intellisense and no namespace errors.

Not even sure why we need d.ts's without comments?
During transpiling we can configure it to remove the comments :) it would be easier to maintain.

I have been shifted to dom based projects for a good long time and have fallen out of touch somewhat with this side of the net.
The definition files were manually created and at the time, the rate of change of pace was pretty rapid. Sometimes it would take hours a week to maintain the commit history.  Had comments been involved, then it would have been impossible to compare 2 files easily without scrolling through 10 times as many lines.
A cool dude came along and merged docs into the phaser.d.ts file to give us the comments. I only ever maintained the original phaser.d.ts and as far as I am aware, the phaser-comments.d.ts is just the original merged.

The comments defs file is generated automatically by the grunt script, which parses the comments out of the JS files and merges them with the hand-moderated defs file. So no, the comments file isn't maintained by hand.

Sorry but I'm closing this PR off. It's been too long and has become so stale, that merging now would be a nightmare. Also the inclusion of the comments files broke the merge ability as well, so if you do ever want to re-open the PR, please just include the defs files, not the auto-generated comments ones.


Automated cherry pick of #3779: redis create bugfix & redis acl create bugfix

Cherry pick of #3779 on release/2.12.
#3779: redis create bugfix & redis acl create bugfix

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@9506c4a). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #3780   +/-   ##
==============================================
  Coverage                ?   6.93%
==============================================
  Files                   ?     500
  Lines                   ?   84323
  Branches                ?       0
==============================================
  Hits                    ?    5844
  Misses                  ?   77984
  Partials                ?     495

Flag
Coverage Δ

#aFlag
6.93% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/elasticcache_instances.go
1.26% <0%> (ø)

pkg/compute/models/elasticcache_accounts.go
4% <0%> (ø)

pkg/compute/models/elasticcache_backups.go
4.91% <0%> (ø)

pkg/compute/models/elasticcache_acls.go
5.45% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9506c4a...6ea039d. Read the comment docs.

/approve
/lgtm


Fixes HeLx webapp redirect for /accounts/login/ route

The /accounts/login/ route stuck around, but is now supposed to redirect to the new login route, /helx/workspaces/login. This redirect was not working, so this fixes that.

I believe this was fixed in the decoupling PR, so closing


Add failed logic for trx logger when TreatNoTestAsError is set to true

We have TreatNoTestAsError parameter. When it is set to true and no tests discovered/executed, vstest.console.exe returns 1.
We do not see that in the TRX logger, only message about "no tests found".
We can potentially change TestRun/ResultSummary@Outcome to specify it or do the same as usual failed cases.
Current Behavior
<ResultSummary outcome="Completed">
   <Counters total="0" executed="0" passed="0" failed="0" error="0" timeout="0" aborted="0" inconclusive="0" passedButRunAborted="0" notRunnable="0" notExecuted="0" disconnected="0" warning="0" completed="0" inProgress="0" pending="0" />
   <RunInfos>
      <RunInfo computerName="" outcome="Warning" timestamp="2021-01-20T21:07:50.5110319+01:00">
         <Text>No test is available in D:\tmp\notests\bin\Debug\net5.0\.\notests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.</Text>
      </RunInfo>
   </RunInfos>
</ResultSummary>

Proposed Behavior
<ResultSummary outcome="Completed">
   <Counters total="0" executed="0" passed="0" failed="0" error="0" timeout="0" aborted="0" inconclusive="0" passedButRunAborted="0" notRunnable="0" notExecuted="0" disconnected="0" warning="0" completed="0" inProgress="0" pending="0" />
   <RunInfos>
      <RunInfo computerName="" outcome="Failed" timestamp="2021-01-20T21:07:50.5110319+01:00">
         <Text>No test is available in D:\tmp\notests\bin\Debug\net5.0\.\notests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.</Text>
      </RunInfo>
   </RunInfos>
</ResultSummary>

(Note that the value of //ResultSummary/RunInfos/RunInfo/@outcome attribute is changed.)

IIRC this being just a warning was one of the motivations to introduce the new option. That way the build actually fails if there are no tests. Maybe the TRX should reflect that and it should be an error instead of warning?

IIRC this being just a warning was one of the motivations to introduce the new option. That way the build actually fails if there are no tests. Maybe the TRX should reflect that and it should be an error instead of warning?

I thought the example above is an example of the final message, and the example above says warning. But if there will be error then great. 🙂

I thought the example above is an example of the final message, and the example above says warning. But if there will be error then great. 🙂

Should we keep the //ResultSummary/@outcome attribute as Completed in this case? Since the test run actually never happened. Shouldn't we set that as Failed as well?

Should we keep the //ResultSummary/@outcome attribute as Completed in this case? Since the test run actually never happened. Shouldn't we set that as Failed as well?

We can provide new outcome like Not started. It is not Failed, cause there were not errors during discovery or execution.

We can provide new outcome like Not started. It is not Failed, cause there were not errors during discovery or execution.

But how will that show in AzDO? IF that is a new status, AzDO won't know about not started and because TRX is versionless we won't be able to tell them that this is supported. Also they would have to do development to support this.

But how will that show in AzDO? IF that is a new status, AzDO won't know about not started and because TRX is versionless we won't be able to tell them that this is supported. Also they would have to do development to support this.

Yes, you are right. IMHO, in this case Completed could be more reasonable, cause we finished test run even if test execution did not start, while Failed means that something wrong happened during discovery/ execution.

Yes, you are right. IMHO, in this case Completed could be more reasonable, cause we finished test run even if test execution did not start, while Failed means that something wrong happened during discovery/ execution.

Currently, even one test fails, we report //ResultSummary/@outcome as Failed. Considering we report a failure from vstest.console.exe, I think we should report a failure in this case as well. Otherwise, it implies a successful run. If we have the TreatNoTestAsError switch set, we should treat this as a failure.

Currently, even one test fails, we report //ResultSummary/@outcome as Failed. Considering we report a failure from vstest.console.exe, I think we should report a failure in this case as well. Otherwise, it implies a successful run. If we have the TreatNoTestAsError switch set, we should treat this as a failure.

Thanks, I will take into consideration these opinions, while working on this change.

Thanks, I will take into consideration these opinions, while working on this change.


Add commands to get current selected tests/profiles

Expose API commands to get the currently selected tests and profiles

vscode.commands.executeCommand('testing.getSelectedProfiles') -> { controllerId: string, kind: TestrunProfileKind, label: string }[]
vscode.commands.executeCommand('testing.getExplorerSelection') -> { include: TestItem[], exclude: TestItem[] } (like a TestRunRequest)

@connor4312 Hello!
I found unexpected behavior for new command testing.getExplorerSelection. If I run tests using the "Run tests" button from menu header, I get this object from command:
exclude: (0) []
include: (1) [{…}]
  0: {items: {…}, label: <accessor>, refreshHandler: <accessor>, id: <accessor>, createRunProfile: ƒ, …}
      createRunProfile: (Ee,he,fe,x,B,Z)=>{let pe=(0,D.hash)(Ee);for(;_.has(pe);)pe++;return new M(this.f,_,z,pe,Ee,he,fe,x,B,Z)}
      createTestItem: ƒ createTestItem(Ee,he,fe){return new v.TestItemImpl(z,Ee,he,fe)}
      createTestRun: (Ee,he,fe=!0)=>this.g.createTestRun(z,Y,Ee,he,fe)
      dispose: ()=>{$.dispose()}
      id: ƒ id(){return z}
      items: {size: <accessor>, forEach: ƒ, replace: ƒ, add: ƒ, delete: ƒ, …}
      label: ƒ label(){return G}
      refreshHandler: ƒ refreshHandler(){return F}
      resolveHandler: ƒ resolveHandler(){return Y.resolveHandler}

That is, in the include, I always get an array from one TestController object. This is fine?

The second point, which completely prevents the use of this task as a workaround for this bug


Change Title

Can you change the title to "GitWorkshop_UserRegistration"?

Let me show it's content first.


Add docs for Ema interface

Simple docs for the Ema interface

thank you for your contribution! do you mind fixing the jsdoc linting errors before merging?

Pushed a fix


Repository issue

Hello,
First of all I should appreciate your great library.
There is an abnormal issue I am facing with your repository. I cannot sync my project when using
repositories {
    maven { url 'https://dl.bintray.com/musichin/maven' }
}

dependencies {
    implementation 'com.github.musichin.reactivelivedata:reactivelivedata:0.23.0'
    //or
    implementation 'com.github.musichin.reactivelivedata:reactivelivedata:0.24.0'
}

My error is simply Read Time Out
but using the Jitpack everything is ok and I use this one
implementation 'com.github.musichin:ReactiveLiveData:0.23.0'
In fact, this is not an issue, I just want to people know that they can use Jitpack instead

Thanks for opening an issue.
Maybe it was an temporally issue?! Everything is working at the moment for me.

resolved.


[Discussion] Does Chakra expose parser information?

Does Chakra exposes parser information?
For example, assuming I have script like this:
function foo(x, y) {
    return x + y;
}

I want to be able to get argument names ("x" and "y").
Alternatively, assuming I have script like bellow and already ran it and got "f1" as a value. Can I get argument names of f1 from runtime?
var f1 =function foo(x, y) {
    return x + y;
}

We don’t have a back door for extracting this kind of information, no, but there’s a very good front door in the form of “foo.toString”. Converting a function object to a string will give you back the original source, and from there you can scan past the “function” keyword and optional name to pull out all the names of the formal parameters.
--Paul
From: zoryn<EMAIL_ADDRESS>Sent: Friday, January 15, 2016 1:31 PM
To: Microsoft/ChakraCore<EMAIL_ADDRESS>Subject: [ChakraCore] [Discussion] Does Chakra expose parser information? (#125)
Does Chakra exposes parser information?
For example, assuming I have script like this:
function foo(x, y) {
return x + y;

}
I want to be able to get argument names ("x" and "y")
Alternatively, assuming I have script like bellow and already ran it and got "f1" as a value Can I get argument names of f1 from runtime?
var f1 =function foo(x, y) {
return x + y;

}
—
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/ChakraCore/issues/125.

Thanks for your response! This is what I was thinking as well, just wanted to check if there is a better way not involving regex or manual string parsing.


WidgetHandlers for custom widgets

Is there any reason, why EditorWidgets#registerHandler is private?
Would be much easier (less magic), if this would be public or at least package private

No, there is no specific reason for that. So if I understand right, it would be desired, that it is possible to extend EditorWidgets and use the extended version instead. I think it is well justified idea. Is there something else needed for that? I need to investigate it a bit more. Also if there are some framework stock fields, that needs to be added there, open issues about those.

I don't think that it is necessary to extend EditorWidgets itself.. It would be enough, if I can call that method with a non-native call (from java).
I don't know the inheritance strategies in gwt/js, but perhaps it is possible to implement a kind of "bestCandidate" for abstract classes.
e.g. you could use ValueBoxBase instead of VTextField
On the first call you could look for a candidate that is assignable from the concrete class and save this candidate for the next call !?

I uploaded version 2.1.8 which has EditorWidgets#registerHandler public and improved JavaDocs. Tell me if it works for you.


Generate sitemap.xml

A sitemap.xml file is required for the google search console so that ranking pages can be indexed on google. It should contain all contest ranking pages with the last updated date. Also, It should be automatically updated whenever new contest rankings are added.

Do you want to implement it using cron jobs?

Background jobs are already running using Bull. We can create a new queue for updating the sitemap.xml file. Ref: https://github.com/SysSn13/leetcode-rating-predictor/tree/main/services/job-queues
Whenever a rating prediction job is completed, this new job should run once.


updates text in changes file and pr template

Pull Request check-list
Please make sure to review and check all of these items:

[X] Do tests and lints pass with this change?
[X] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
[X] Is the new or changed code fully tested?
[X] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
[ ] Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Resolves #31 by removing the changes update request in the PR template and adding a comment to the top of the CHANGES file.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@01db8ba). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage        ?   61.34%
=======================================
  Files           ?      132
  Lines           ?    34350
  Branches        ?        0
=======================================
  Hits            ?    21072
  Misses          ?    13278
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi Jay! Can you rebase this PR so that it only contains your commit? Thanks


added InMemoryDatabase trait

That would allow the tests to run in a ':memory:' sqlite database automatically by using this trait. example:
<?php

use Illuminate\Foundation\Testing\InMemoryDatabase;

class UserTest extends TestCase
{
    use InMemoryDatabase;

    // tests here
}

I would rather people set this in their configuration files, but decent idea :)


Example do not work

Hello i try the example but dont work . Can provide me working sample ? Thanks in advances
i found this endpoint url : https://immersal.gitbook.io/sdk/api-documentation/rest-api

@micfio thank you for your inquiry. I cannot provide working sample as I cannot share info from my developer's page in Immersal. You need to follow the following instructions provided:

Create a free account on Immersal's developer page.
Create a map using Immersal Mapper App (available on AppStore and PlayStore; it is free).
Inside of Immersal's developer page take individual token and map id.
Then use this component.

pheraps you can help me with this? the point cloud ar not visualized.
https://zenn.dev/tkada/articles/1b144d1a427148

Just to be sure: did you add your token and mapID?

yes
Inviato da Posta per Windows
Da: Akbar S.
Inviato: venerdì 16 agosto 2024 19:50
A: akbartus/A-Frame-Component-Web-VPS
Cc: micfio; Mention
Oggetto: Re: [akbartus/A-Frame-Component-Web-VPS] Example do not work (Issue#1)
Just to be sure: did you add your token and mapID?
a-entity webvps="pointCloudSize: 0.05; modelURL: example.glb; token: yourtoken; mapID: 99999; mapType: 0" visible="false"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

yes, not are visualizad tap to place help and seems that tap not work . i have not found addevent lister click in the file.

One more question: does your device support ARCore(Android)? Because without support it will not work. (see compatible devices: https://developers.google.com/ar/devices )

Yes

A forward step : setting token inside script and not passed now the pointcloud map are visualized but remain the tap not work and also the localize.

changed :
`// Virtual Positioning System for A-Frame
AFRAME.registerComponent("webvps", {
schema: {
modelURL: { type: "string" },
scale: { type: "vec3", default: { x: 0.5, y: 0.5, z: 0.5 } },
position: { type: "vec3", default: { x: 0, y: 0, z: 0 } },
rotation: { type: "vec3", default: { x: 0, y: 0, z: 0 } },
token: { type: "string" },
mapID: { type: "string" },
mapType: { type: "int", default: 0, oneOf: [0, 1] },
pointCloudSize: { type: "number" } // Changed from int to number
},
init: function () {
var data = this.data;
var el = this.el;
let token = data.token;
let myMapID = data.mapID;
let myMapType = data.mapType;
let myPointCloudSize = data.pointCloudSize;
console.log('Component data:', data); // Debugging line

new THREE.GLTFLoader().load(
  data.modelURL,
  function (gltf) {
    var mesh = gltf.scene;
    mesh.scale.set(data.scale.x, data.scale.y, data.scale.z);
    mesh.position.set(data.position.x, data.position.y, data.position.z);
    mesh.rotation.set(
      THREE.MathUtils.degToRad(data.rotation.x),
      THREE.MathUtils.degToRad(data.rotation.y),
      THREE.MathUtils.degToRad(data.rotation.z)
    );
    el.setObject3D("mesh", mesh);
  },
  undefined,
  function (error) {
    console.error('An error occurred while loading the model:', error);
  }
);

init(token, myMapID, myMapType, myPointCloudSize);
animate();

},
});
// END `
according to:
<a-entity webvps="**pointCloudSize: 0.05**; modelURL: tree.glb; token: abcdefjhi; mapID: 99999; mapType: 0" visible="false"></a-entity>
now the parameters are passed and i noth define the token in script. But always the tap and localize not work.

Working Code :
Uploading aframe-web-vps.zip…

aframe-web-vps.zip


Django >= 1.7 compatibility for requires_system_checks

Hi @dcramer,
Devserver will fail to start up on Django 1.7 with the error:
django.core.exceptions.ImproperlyConfigured: Command Command defines both "requires_model_validation" and "requires_system_checks", which is illegal. Use only "requires_system_checks".

The django-devserver runserver management command inherits from the django core runserver management command which set requires_system_checks = False. The django-devserver runserver management command then sets requires_model_validation = False.
This pull request ensures only the appropriate attribute is set to False, so is backwards compatible with Django < 1.7.
The implementation is only suggested. If you have another way you'd prefer to do it that's fine, this was just a convenient way to illustrate the issue.

Same here. @dcramer any chance we can get this merged?

+1. Gotta use personal fork for this, please merge this :)

+1 waiting for merge

+1 please merge

Thanks @dcramer :fireworks:

:+1:

Thanks @dcramer. When you get a chance could you make a 0.8.1 release to PyPI please, so we can get it from there in a pip install?

Merged fix forces validation for Django 1.6 and below, is that on purpose?
https://github.com/dcramer/django-devserver/pull/99#commitcomment-8306414

+1 for

Thanks @dcramer. When you get a chance could you make a 0.8.1 release to PyPI please, so we can get it from there in a pip install?

Shouldn't this be changing requires_system_checks and requires_model_validation on self, instead of creating locally scoped variables inside __init__? Or am I understanding this wrong?


"Tag had invalid wire type." error when running on

Getting a "google.protobuf.message.DecodeError: Tag had invalid wire type." error on Python 3.6.2. Thanks!

I was able to restore from an earlier backup, guessing one was just corrupted, so going to close it out. thanks.


Question about the dataset download link.

Hello! The download link you provided doesn't seem to work for me.
Could you please provide another link including base_data_128.txt and test.txt?
Thank you.

Did anyone manage to get the data? I would really appreciate it if they could host it on a more accessible platform!

I managed to get the data! If someone urgently needs it, kindly email me, and I will gladly share a link to download it.


RFC: represent units in ascii

This is a draft request for comments.
In a former discussion on the google doc, we had considered representing all units in ascii notation.
The ASCII representation is taken from
here, where additional units
may be found. The primary reason for choosing an ASCII representation, is that
certain characters can have multiple unicode representations that look very
similar. (e.g., https://graphemica.com/search?q=mu)

I have no objection against including the ascii representation of units, but I would not have them as a replacement to the unicode units (this would also be a backwards compatibility breaking change I suppose).
I suggest having both representations side by side, so that each user can choose which to use.
We should introduce a test in the bids-validator that checks for the correctness of units, i.e., compares the unit to the set of prefixes, names, and suffixes we accept

I for one am content with any of the following:

ASCII following the CMIXF12
Unicode with explicit code points specified, copy-pasteable from any generated spec documents, and the validator checking these
Both

Probably would prefer (1), just because I don't want to write unicode that doesn't appear on my keyboard. On the other hand, we have been specifying Unicode characters, so we may end up invalidating compliant datasets. Which would lead us to (3).

I agree with the backward compatibility issue raised by @sappelhoff.

@chrisfilo - in general, how are we dealing with backwards compatibility? aren't many changes in upcoming 2.0 not backwards compatible? since bids adopts a validation driven approach, perhaps the validator can indicate that a dataset is compatible with bids version x -- y, z and a linter could suggest what to change to expand/change compatibility.
i'm not a big fan of 3 (supporting both), since that piece of logic now has to go into every software. it's always possible for software to detect version of bids dataset and do something or not do something. but having lived through six and future, and many if sys.version < (3, ) and all the fun unicode things, i'm strongly in favor of dropping unicode characters in units.
in this particular case i would say the friction this causes (adopting 1) is probably worth the headaches it reduces later, and the simplicity we gain.

@chrisfilo - in general, how are we dealing with backwards compatibility?

Current master is 1.x and strives to maintain backward compatibility. Ideas/suggestions/proposals that would break backward compatibility are collected in the BIDS 2.0 document.

aren't many changes in upcoming 2.0 not backwards compatible?

Yes - by definition.

since bids adopts a validation driven approach, perhaps the validator can indicate that a dataset is compatible with bids version x -- y, z and a linter could suggest what to change to expand/change compatibility.

Indeed that would be technically possible, but I expect that developing and maintaining such solution would incure a substantial effort. This is probably not the best place to discuss such approach though (since this PR will eventually be merged and forgotten). If you are interested in this topic perhaps you can open a new issue?

in this particular case i would say the friction this causes (adopting 1) is probably worth the headaches it reduces later, and the simplicity we gain.

Such arguments have been successful in the past (for example with hotfixes to MEG spec). It is really the question of which datasets and tools this change would impact.

Some progress on this matter, I opened an issue on validating units, see: https://github.com/bids-standard/bids-validator/issues/777
Specifically, we would want the bids-validator to enforce the units we are deciding on.
I also cross-post @ftadel's opinion here from a discussion in https://github.com/bids-standard/bids-examples/pull/155#discussion_r281095667

It's probably better to accept less options for units formatting. If we accept too many variations, the programs processing automatically BIDS datasets might miss the interpretation of some of the extra options. This is "useless" freedom (who cares if the file has to use microV instead of uV?) might make development/maintenance/debugging more complicated.
But the validator should enforce this properly then.

@satra after reading @effigies comment: https://github.com/bids-standard/bids-examples/pull/175#issuecomment-580323160 and further discussing with him in person I am now of the impression that we should go ahead with your PR (that you proposed almost a year ago :wink:  )

obviously we stay with SI units for BIDS
however, we now clarify how we want them to be formatted
namely:

either exactly like in out Appendix currently (i.e., permit unicode characters U+00B5 (µ) and U+00B0 (°) and U+2126 (Ω)... and ONLY those)
or according to this document: http://people.csail.mit.edu/jaffer/MIXF/CMIXF-12

For this PR that would mean concretely that the intro pragraph would have to be rephrased to account for the three unicode characters we permit ... and to change their table entries back to unicode.
This change in the spec would involve changes with the validator, which actually refreshed this whole discussion through bringing up https://github.com/bids-standard/bids-examples/pull/175 cc @rwblair

okay, seems like merging https://github.com/bids-standard/bids-specification/pull/408 blew up this PR ... :-/
At this point it seems like picking the changes from https://github.com/bids-standard/bids-specification/pull/151/commits/bdb3cd5eed7ba19a724a782195462f0841cb2ebc and https://github.com/bids-standard/bids-specification/pull/151/commits/9f22dc9f65c76f7f4d93467264775580d6828b78  and opening a new PR would be cleanest.
I'll just go ahead and do that.

please see https://github.com/bids-standard/bids-specification/pull/411 and continue discussion there.


Issue #27 General Implementation

General Implementation

We follow the convention of putting tests near the python file, by creating a tests folder and adding required tests_[filename].py into there.
Hub/test/test_dataset.py <- putting here does not follow the convention.
In this case, since the feature was developed in hub/collections/dataset/__init__.py ideally would add tests below
Hub/hub/collections/tests/test_dataset.py
However, there are a bunch of tests Hub/hub/collections/tests/test_dataset.py that do not follow convention either (@edogrigqv2 )

#22 and #24

p


kalendar: 0.4.0 -> 1.0.0

Motivation for this change
Version bump
~Currently, it builds and runs on master however, it doesnt build on nixos-unstable. So, I'm unable to run it along with the rest of my system. I believe it should work, however im not too sure. (I would like to wait till nixos-unstable advances so that it hopefully builds on unstable)~ It works (I was using an older version of unstable)
Also, as with the previous update (https://github.com/NixOS/nixpkgs/pull/153084), clearing ~/.cache/KDE/kalendar is necessary if you ran a previous version.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/729

Result of nixpkgs-review pr 159862 run on x86_64-linux 1

1 package built:

kalendar


Node Exporter Full 0.16 problem when node_exporter is on different ports

hi Ricardo, first of all - thank you for this excellent dashboard.
On my servers, some of the node_exporters are on port 9100 and some are on port 80.
I discovered that when I use the Host dropdown to select a host where the metrics are on port 80
that the dashboards are all empty (no data). I enabled the port dropdown with the following change:
19505c19505
<         "hide": 2,
---
>         "hide": 0,

When I do that, and select port 80 from the dropdown, then the dashboard charts get populated.
Is this an issue with the regex on line 19513 of the json file?
We basically need the port to track the host appropriately.
here is the relevant section of my prometheus.yml - you can scrape my URLs to test
  # node_exporter metrics from various servers
  - job_name: node
    scrape_interval: 60s
    static_configs:
      - targets:
        - localhost:9100

      - targets:
        - devops.fywss.com:80
        - thrash.fywss.com:80
        - home.fywss.com:80

Cheers
Steve

hi Ricardo, I tried the most recent file from the repository and I now see 3 drop-down menus at the top.
The only panel that displays any data is the "system load" as this version of the dashboard doesn't seem to support the new metric names in node_exporter version 0.16-rc0

the newest dashboard is working great, with one change. On line 995, I changed node_time to node_time_seconds. Otherwise, the uptime chart wasn't working. I'm using version 0.16.0-rc.2 of node_exporter on linux-arm7 and darwin-386. Thanks a lot Ricardo!

Great, I just upload the fix on the line 995 and an other similar in 9620.
Thanks for the feedback.


Thumbnails error after updating Meteor

After updating to the newst Meteor version, the thumbnails doesnt work anymore, getting this error.
Any Ideas :x?

Hello @AdrianAbba ,
Sorry for delay. Yes, storagePath now always is function, see here
I wish it's already fixed on your end.

Adde note to v1.7.6 release, assuming this one as solved


Ability to export API from dash into an importable file for postman

Add the ability to export the openapi spec as a json file.

Completed by #464


Revert "Disabling the MD4 algorithm. (#272)"

This reverts commit 85330c701ff534f268100106d10c26ee7114008d.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[X] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[X] Any updated packages successfully build (or no packages were changed)
[X] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[X] Ready to merge

Summary

The change from the title has to be reverted, as we still have some dependencies on OpenSSL's MD4 from cURL, which comes up when you try to run it against the updated version of the crypto library.
Change Log

Reverted removal of MD4.

Does this affect the toolchain?

No.
Test Methodology

N/A, reverting to previous, good state.

Ignoring linter complaints, since I'd like to keep the revert clean (only change what was touched by the original PR). Will address linter's issues with a next change to this file.


fix: declaration for provider name

The implementation is not fulfilling the abstraction definition:
https://github.com/open-feature/php-sdk/blob/4e25be68937dc4ec405366cb6ba726f66fc0e5c8/src/implementation/provider/AbstractProvider.php#L19
protected static string $NAME = 'AbstractProvider';

The implementation is pointing not to a property but to a constant.
protected const NAME = 'SplitProvider';

This is leading to getMetadata method in the implementation to return all the time "AbstractProvider" value
Reproducing the issues:
<?php
abstract class AbstractProvider {
  protected static string $NAME = 'AbstractProvider';

  public function getMetadata()
  {
      return static::$NAME;
  }
}

class SplitProvider extends AbstractProvider
{
    protected const NAME = 'SplitProvider';
}

class FlagdProvider extends AbstractProvider
{
    protected const NAME = 'FlagdProvider';
}

$splitProvider = new SplitProvider();
var_dump($splitProvider->getMetadata());

$flagDProvider = new FlagdProvider();
var_dump($flagDProvider->getMetadata());
?>

This looks good to me, the lazy static binding was merged in the php-sdk but these weren't updated with it.
Thank you @apodgorbunschih!
If the tests for the providers don't cover this already, it will be a good follow-up to ensure it doesn't break again

@tcarrio Thanks a lot. Let me add the test in this MR, so we will be sure that is returning the correct value 👍


fix: alias uses type of lemma

#check @Function.Surjective.range_eq now gives
@Surjective.range_eq : ∀ {α : Type u_2} {ι : Sort u_1} {f : ι → α}, Surjective f → range f = univ

as expected.

Can you add a test test/Alias.lean to cover this case?

added test. On master both forward and backward are 1 + 1 = 2 → 1 + 1 = 2

bors merge


pick and display date only

is it possible for pick and display date only?

      <input class="form-control" size="16" type="text" placeholder="Release Date" id="release-date" value="{{ unit.release_dt|date:'Y-m-d' }}" style="cursor: default; background-color: #ffffff;">

using the code above I can just limit the user to select date only but the time is displayed as "00:00". could it just be "yyyy-mm-dd"(tried data-format and data-date-format, not working)

This appears to be working correctly on my demo page.  Try changing the demo page in the distribution to see if it works on your browser / OS combination, and if so this issue can be closed, perhaps?

so using data-format should be working properly?
honestly I am not sure about the version I am using--well, no version info available to me in the code base. maybe it could be an older version?

Yeah, version info is hard to find .. no worries, if you download it you'll get latest.
I've actually moved away from using this plugin .. I prefer it visually but it isn't reliable / stable enough at this time for what I'm doing.  However, when I was using it, I used data-date-format.  Did you get that wrong?  I see you said "data-format" but it's "data-date-format"

Nice plugin but how to use without time selection I can not find


Initial video stuttering in CameraCaptureActivity

Hello,
I have copied the CameraCaptureActivity (and it's many dependencies) into my project and encountered the following issue:
Previewing works ok and smooth, but the recorded video does not match the said preview.
When I checked the video that was recorded, I noticed that the first second or so it stutters. As if the frames that were fed to the encoder weren't updated. Weirdly enough, even the square moves slowly. I'm tinking it could be an issue with feeding the encoder?
I've installed the Grafika app, just in case I broke something when copying but the same issue occurs.
Can also confirm that this issue occurs on the following devices: LG Nexus 5X, LG Nexus 5, Samsung Galaxy S4.
Here is a small video that illustrates the issue:
https://drive.google.com/file/d/0ByilB1pyzZdDNGFQdjd5RnpjeHM/view?usp=sharing
I have used the following settings for the preview and encoding:
Resolution: 1280 x 720
Bitrate: 4000000
Keep in mind that this also happens in the Grafika App with the default settings.
Any feedback would be greatly appreciated.

FWIW, the video quality seems consistent across the 2-second sample you linked to.  Is that what you're seeing?  Is it possible you're seeing an issue with playback rather than recording?

Thank you @fadden for the super quick response!
The quality is good both in the video and in the preview. As I mentioned, the issue is with the recorded video's frame rate.
Note while you watch the sample that the pan speed should be constant, however in the first second it appears jittery, while in the second half it is more consistent.
Any idea what could be causing this?

Watching the rectangle in the bottom-left, the playback frame rate seems pretty consistent.

I cannot upload another video right now, although i assure you that there is stuttering. I will post a longer video tomorrow that better shows what i mean.
Any suggestion of content would be appreciated. I'll try with a stopwatch or i'll record a fluid motion on the screen to see how it measures up.

@fadden as promised, i've found a suitable example, in the form of the ufo test here
Here is a recording of the screen:
https://drive.google.com/file/d/0ByilB1pyzZdDRWFWT0U5X1NrYzA/view?usp=sharing.
I did some measurements on this video and here's what i have found:
In the beginning, it takes the 15fps UFO approximately 41 frames to display 15 different frames (including the first one). After that, if we start counting from say the 60th frame, it takes only 2 frames for the 15fps UFO to completely move to the new position (as expected for the 15fps version).
I would say that besides the visually observable initial slowdown of the video, we now have conclusive measurable proof of this issue.
PS: I removed the purple square just in case it was the issue but apparently not.

I can see it in the new video -- watching the 60fps UFO, it clearly speeds up after the first second or so.
The thing to look at would be the PTS timestamps being passed to the video encoder (or, if you have the appropriate tools, the timestamps stored in the .mp4 file).  Those determine the rate at which the frames are presented by the player.  They come from the camera, which should yield a video where the output frame presentation matches the camera capture timing.  The only way things should get weird is if the timing is mis-matched, e.g. the PTS values were being generated at a fixed frame rate rather than reported by the camera code.

@fadden I have added a check in the handleFrameAvailable method of the TextureMovieEncoder (line 325), checking time stamps for consistency (if new values are bigger, smaller than or equal to the last) and indeed they all were for a 30 frame video sample. I haven't checked if the times are indeed consistent with 30 fps video.
How would this solve my issue exactly though? If the time stamps are off, is there any way to correct them?
And even so, why am i seeing duplicate frames?

If Grafika is encoding 30 frames per second, with timestamps spaced 1/30th of a second apart, then the output video should be correct.  If it's not, then you need to identify how it's failing.  The PTS timestamps determine when the player displays frames -- it's variable-frame-rate video -- so that's where I usually look first when the playback rate is off.  Things should play back correctly whether you have 2x as many frames or 1/2 as many frames, because the PTS times are being generated by the camera when the image is captured.
If a player forces playback to a specific rate (e.g. 29.997 fps), things will look weird if frames are inserted or dropped.
The GLSurfaceView-based approach has some opportunities for failure.  It's calling requestRender() from onFrameAvailable() to feed the encoder, so if the GLES render thread drags behind it might miss a frame.  If some weird thing in the system caused onDraw() to spuriously fire, you'd encode the same frame twice (but you'd see that as a duplicated timestamp).
FWIW, the code in ContinuousCapture is generally better.

Sorry for the late reply @fadden .
I tried, as you suggested to check the timestamps more closely. I've compared the spacing between each of the sequential timestamps with the expected value of 33.333.333 nanoseconds. This is the value one would expect to see between timestamps in a perfect world, correct?
Needless to say, that neither interval was exactly this, the largest deviation being 101333 nanoseconds at it's worst in a 30 frame capture session. There were no duplicate timestamps however, or at least, no timestamps that were closer to each other than the value i've specified.
I would like to continue using the CameraCaptureActivity however, as with little modification it will fulfil my needs perfectly.
If I may ask though, is custom video recording in Android such an unexplored issue? Grafika seems to be the only place to go to for this type of task.

If the code is outputting 30fps video, then I'm at something of a loss to understand why it doesn't seem to be playing back at 30fps.
The "show + capture camera" Activity does have a serious problem (see bug #36), so be careful with that.  Depending on what you're doing, the Camera2 APIs may offer better (more efficient, less convoluted) approaches.
The current docs look like this.  When I first encountered them, they looked like this.  Things have come a long way, but it's been something of an adventure.

Hi Fadden,
First of all, thank you for this great app - very helpful for many folks!
I am testing on Samsung S7 and I see that the timestamps are not at a regular 33.33ms difference when streaming at 30fps. The timestamps from the SurfaceTexture in onFrameAvailable() callback itself are not uniform. What could be the issue & how can we resolve this? See the graph below Y axis in time and X axis is frames.

Thank you,
Ajay


Attachments don't work on iphone/ipad

I'm working on a site and I need to send attachments to iphone/ipad users because safari doesn't support the file type for download. The issue I have, is that the attachments show up inline at the end of the message. I don't know if it's something I'm doing wrong, or a bug of some kind. On my desktop I use Outlook with Exchange, I've tested in windows phone 7, andriod, windows live, and Gmail. All receive the attachement correctly. Anyone else run into this, or have any suggestions?

It's definitely something to do with formatting the attachment I think. If I send the attachment to my desktop email, then manually download it, compose a new message in outlook, attach the file, and then send it to my ipad, I receive the attachement as expected.

What type of file are you attaching?
If you send an email using the .NET SmtpClient and MailMessage classes (which Postal uses itself) do you get a correct email? I need to know if this is a .NET issue or something specific that Postal is doing wrong.

Ah I didn't think to try that, I'll give it a shot. The attachment is a VCF file.

OK, so it does work using SmtpClient if I attach the file without specifying the content type, such as:             message.Attachments.Add(new Attachment("C:\file.vcf")); that gives it a Content-Type: application/octet-stream.
I looked on the email I'm generating with postal and I'm ending up with a Content-Type of text/x-vcard, which is technically correct, but obviously a problem for apple email lol. I'm not sure where that's getting set, is that being set by Postal? I'm attaching in postal using a memory stream, and only passing in the name: Attachments.Add(vcfName, memoryStream.ToArray());

I wanted to make sure it wasn't something with my vcf library, so I've tried using the same code to generate the attachment with smtpclient, and the content-type remains application/octet-stream if I don't explicitly set it. So at this point, it's got to be something with postal. Is there any option for explicitly setting the content-type of an attachment in Postal? I'm looking through the source, but not seeing anything... Thanks for the help, btw :)

Cassette doesn't really do any processing of attachments. It simply adds them to the generated MailMessage class. So I don't understand why you're getting different content types.
Can you try specifying the content type when creating the attachment:
email.Attach(new Attachment(stream, fileName, "application/octet-stream"));

Does this force the right content type?

No worries :) I'm glad you've solved it!
My guess about the differing environments is that either the Windows registry or IIS has a mapping of file extensions to content types. So your production server must have an entry for vcf files.

You haven't by chance tried working with this in .net 4.5 or MVC 4 yet have you? I've been playing with the developer preview and I'm really excited for the mobile view support. The only reason I'm asking, is I loaded postal and I'm getting an unimplemented exception when I try to send. I can't tell if it's something just not yet complete in .net 4.5 or something no longer availible.

I've not tried .NET 4.5 yet. Can you paste in the stack trace into a new GitHub issue please? I'm guessing it's one of the System.Web.Http*Base classes, which Postal overrides, missing something used by 4.5.
Thanks.


ScriptYouTubePlayer: Weird specific bug related to layouts, transitions and useFetch

🐛 The bug
Hi, I found this specific bug that occurs using layouts and having pageTransition and layoutTransition enabled in nuxt config.  The script loads, but the video doesn't play.

Steps to reproduce: (It is recommended to open the preview in a new tab)

Start the reproduction
You must be on the index page /
Click Go to Layout
Try to play the video
The script loads, but the video doesn't play
Inspect the console and you must see the error

🛠 To reproduce
https://stackblitz.com/edit/nuxt-starter-aqvq3n
🌈 Expected behavior
The video in /video should be played after clicking it
ℹ Additional context
nuxt: 3.13.2
@nuxt/scripts: 0.9.4
Btw: this error doesn't occur if you enclose the script with <ClientOnly>

Hello again @harlan-zw ,
I discovered this error is caused because onMounted is being executed twice. You will notice it by logging something to the console
I also noticed that it is not related to useFetch at all, it is related to awaiting for async functions in general.
It seems that this happens because of a bug with Vue.
Here are some nuxt issues that are facing similar problems
https://github.com/nuxt/nuxt/issues/27442
https://github.com/nuxt/nuxt/issues/27364
I tested a workaround by enclosing the layout </slot> with <Suspense> and I got it working normally.
<!-- Layout -->
<template>
  <div>
    <Suspense>
      <slot />
    </Suspense>
  </div>
</template>

So, that said, it's probably not a problem with @nuxt/scripts


Error when deleting shipping/payment image

In Umbraco 7 you get an error after you pick an image for a Shipping Method and the click delete to remove the image. Might also be an issue for Payment methods.

I see that, but I think its a bug with Umbraco as we use the ContentPicker of Umbraco. The href is ../shared/# and so is the "choose" link. But the choose link works

Fixed in 2e2b70a. Technically this is a core issue, but I've added some code to intercept the buttons on the content picker and have them preventDefault on the event.


Investigate if we can safely remove the use of Uint8clampedArray when it's useless

For example here:
https://github.com/mozilla/pdf.js/blob/694cb311c045a3499b5ed5865a2fe28469b42691/src/core/decode_stream.js#L101
we use the ctor with a typedArray argument:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8ClampedArray/Uint8ClampedArray#typedarray
and ergo data are copied.
And as far as I understand, Uint8ClampedArray is especially useful when some data are written in the array but in general (afaik) there are no difference with an Uint8Array.
Those Uint8ClampedArray have been added in https://github.com/mozilla/pdf.js/pull/9802.
and it clearly makes sense for color stuff, for image.js::undoPreblend and maybe few other cases I overlooked but in general my feeling is that they're useless and their use induces a performance penalty.
@Snuffleupagus, any opinion about that ?

Those Uint8ClampedArray have been added in #9802.
and it clearly makes sense for color stuff, for image.js::undoPreblend and maybe few other cases I overlooked but in general my feeling is that they're useless and their use induces a performance penalty.

I suppose that it's possible that we currently use the forceClamp-parameter unnecessarily is some cases, however that should be limited to data where e.g. the ColorSpace-code will subsequently be used, but it's not really clear to me more exactly which those actually are.
Do you perhaps have a list of potential ones that you think could/should be removed? Given that all code-paths that need to use Uint8clampedArray should have asserts, have you tried running all tests locally with your proposed changes?

For example it seems to be useless here:
https://github.com/mozilla/pdf.js/blob/694cb311c045a3499b5ed5865a2fe28469b42691/src/core/image.js#L358
and even here (which is almost the previous version of the code above):
https://github.com/mozilla/pdf.js/blob/694cb311c045a3499b5ed5865a2fe28469b42691/src/core/image.js#L303
or here:
https://github.com/mozilla/pdf.js/blob/694cb311c045a3499b5ed5865a2fe28469b42691/src/core/image.js#L714-L738
or:
https://github.com/mozilla/pdf.js/blob/694cb311c045a3499b5ed5865a2fe28469b42691/src/core/image.js#L742-L757
Maybe we could remove the forceClamped parameter and return a wrapper around a typedArray.
And add a method to get a clamped version of the underlying buffer or a clone if we mustn't change the underlying data, something similar to what we have here:
https://github.com/mozilla/pdf.js/blob/694cb311c045a3499b5ed5865a2fe28469b42691/src/core/image.js#L715-L726
Just a sort of Copy-on-Write wrapper... something like that.
And the clamped version is only useful when some data are potentially out of the 0-255 range, but in case we do stuff like buffer[i] ^= 0xFF it isn't required.
The problem I see with the forceClamped = true parameter is that we use it because maybe at some point we'll do some color stuff. With the CoW approach, we're more lazy and just do the clone only when we absolutely need it.

I'd suggest that we simply remove the forceClamped-parameter where it's actually deemed unnecessary, based on code-inspection and testing, and refrain from bigger changes here.

Maybe we could remove the forceClamped parameter and return a wrapper around a typedArray.

What you're suggesting is, assuming I'm understanding you correctly, is changing the return type of BaseStream.getBytes and related methods. Doing that would affect basically the entire worker-thread code, in one way or another, since in most cases we're actually fine with whatever kind of TypedArray.
Having those methods return a wrapper, rather than an actual TypedArray, would thus mean re-writing so much code and I'd also wonder if the wrapper itself wouldn't also incur additional memory/run-time overhead?

I was thinking changing the return value of getImageBytes and for stuff like:

Oh, that's the missing piece of context required to understand what you meant here :-)
Basically you want to limit the previous forceClamped handling to only the PDFImage-code, which means that it can removed from the various Stream-implementations; in that case that should probably be fine!
(Hopefully our existing asserts, combined with the ref-tests, should ensure that we don't accidentally regression something.)

@Snuffleupagus, if you agree that it'd make things better, would mind to fix this bug ?

if you agree that it'd make things better, would mind to fix this bug ?

Maybe, but I'm not sure exactly what you have in mind for the getImageBytes-method. Do you want it to look something e.g. something like the following?
diff --git a/src/core/image.js b/src/core/image.js
index af0bf6f4a..6985024c1 100644
--- a/src/core/image.js
+++ b/src/core/image.js
@@ -872,7 +872,16 @@ class PDFImage {
     this.image.drawWidth = drawWidth || this.width;
     this.image.drawHeight = drawHeight || this.height;
     this.image.forceRGB = !!forceRGB;
-    return this.image.getBytes(length, /* forceClamped = */ true);
+
+    const imageBytes = this.image.getBytes(length);
+    return {
+      raw: imageBytes,
+      clamped: () => {
+        return imageBytes instanceof Uint8ClampedArray
+          ? imageBytes
+          : new Uint8ClampedArray(imageBytes);
+      },
+    };
   }
 }

Yep and if possible the return object could handle the if (this.image instanceof DecodeStream) ... thing.
And if it safe to write into the original buffer then use new Uint8ClampedArray(imageBytes.buffer) instead to avoid an extra copy.
The idea is really to try to have something smart enough to avoid useless copies and to make the code more simple.
I can do it for sure, but you're certainly the best to avoid to miss something important somewhere and handle some corner cases you've in mind if any.

After taking a brief look, and running all tests with a quickly thrown together patch, I'm not actually sure that we need any of the forceClamped handling in the PDFImage-code at all.
I might be overlooking something, or maybe our test-coverage is lacking, because it's really starting to look like this is basically useless code...
In the following cases we're returning the data without any ColorSpace-parsing, and the exact TypedArray used shouldn't matter:

https://github.com/mozilla/pdf.js/blob/b72a4483276d65bef32cff269eb40923c1363f2d/src/core/image.js#L714
https://github.com/mozilla/pdf.js/blob/b72a4483276d65bef32cff269eb40923c1363f2d/src/core/image.js#L751

In the following cases the image-data is only used internally, and again the exact TypedArray used shouldn't matter:

https://github.com/mozilla/pdf.js/blob/b72a4483276d65bef32cff269eb40923c1363f2d/src/core/image.js#L762 however the actual image-data is being defined below in https://github.com/mozilla/pdf.js/blob/b72a4483276d65bef32cff269eb40923c1363f2d/src/core/image.js#L772-L779
https://github.com/mozilla/pdf.js/blob/b72a4483276d65bef32cff269eb40923c1363f2d/src/core/image.js#L837


Make description nicer

At the moment, the description field is clustered.

There are 2 ways in fixing this:
1st way:
The following code breaks up the information by each new line and insert a line break.
function description(internshipDescription) {
  try {
    return (
        internshipDescription.split('\n').map((item, key) => {item}
)
    );
  } catch (e) {
    console.log('No description field.');
    return '';
  }
}

While this way works, the format is not as neat:

2nd way:
When scraping the description, replace innerText --> innerHTML in the fetchInfo() function so it keeps the HTML tags like:

We are looking for a Full Stack Developer (Intern) to join our team to launch our flagship product! The role will involve reporting directly to the CTO and helping to build the basis for Athly's infrastructure. This role has a high chance of transitioning into a full position with equity.

Responsibilites:

Developing responsive web applications

Working with the project lead to build reliable cloud infrastructure

Help build the foundation of Athly's codebase

Writing quality code documentation

Creating unit tests to ensure continued functionality of site

Requirements:

Previous knowledge in creating React web applications using Django for backend.

Firm knowledge of using JavaScript, HTML and CSS.

Expirience deploying applications in cloud environments

Python and Django or equivalent framework expirience

Previous projects (Code on GitHub is a bonus)

In our modal description, we use:

However, the caveat is that, as the HTML attribute suggests, it is dangerous because it’s easy to inadvertently expose your users to a cross-site scripting (XSS) attack. More information can be read from here:
https://reactjs.org/docs/dom-elements.html#dangerouslysetinnerhtml

Use the 2nd way but we can check to see if the description as a


Error Node was not found

I got this error
When loading the graph, the following node types were not found:
ADE_AnimateDiffLoaderWithContext
Nodes that have failed to load will show as red on the graph.
But AnimateDiff_evolved is installed. I've reinstalled it several time, doesn’t help

It must mean you have an error when ComfyUI is booting up and its trying to load AnimateDiff-Evolved. Look in your console, and send me waht it says

@Kosinkadink
ImportError: cannot import name 'attention_basic' from 'comfy.ldm.modules.attention' (D:\comfui\ComfyUI_windows_portable\ComfyUI\comfy\ldm\modules\attention.py)
Cannot import D:\comfui\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved module for custom nodes: cannot import name 'attention_basic' from 'comfy.ldm.modules.attention' (D:\comfui\ComfyUI_windows_portable\ComfyUI\comfy\ldm\modules\attention.py)

Looks like your ComfyUI is outdated, update ComfyUI and you'll be good to go.

same.
Cannot import L:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved module for custom nodes: Missing parentheses in call to 'print'. Did you mean print(...)? (ldm.py, line 20).
It looks like it's the LDM version that's the problem,my ldm version is 0.1.3,Where to find a LDM for py3?

Looks like your ComfyUI is outdated, update ComfyUI and you'll be good to go.

thanks you. updating comfyui solved this issue.

updating helped, thanks a lot

thank you very much

coming from a clean install - I get same error

i create clean conda env - with latest cuda12.1 - do a git pull
installl manager - install evolved - load in image - same error as above.
I git pull - it's up to date


Add tests for math ufuncs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f597ee7) 100.00% compared to head (5a5e931) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #574   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           25        25
  Lines         2145      2149    +4
  Branches       276       278    +2
=========================================
+ Hits          2145      2149    +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feature/vue frontend

Merge the frontend implemented in Vue.
Todo:

Clean up UI and the code.

I just need to handle empty room codes now

There needs to be a way to enter the username.

Not ready yet, I need to finish up the web socket JS :)

Front end looks really nice. Can we have the collaborators section show the username as in "Luke - You" as other people might have the same username.
Perhaps connect the websocket in a different PR. This looks good to get the frontend setup visually. Adding logic would be in a different scope

Perhaps connect the websocket in a different PR. This looks good to get the frontend setup visually. Adding logic would be in a different scope

Yeah, I agree. I think let's merge this PR after I make these couple fixes instead of waiting for client JS to be finished.

Do we need to satisfy deepsource before merging?

Do we need to satisfy deepsource before merging?

Ideally, yes. It gives some really useful tips for better code quality

@Evorage0 do you mind taking up the issues on deepsource? because most of it is from your part I think and I don't want to meddle with it because it may have unwanted consequences.


Update discovering-the-ray-app.md

Added a link to the Ray app :-)

Perfect, thank you very much!

Perfect, thank you very much!


solve #60 and added check

Solve #60 , maybe also should changed commands for goimports.go and goto_def.go but I'm not sure.
And added check on equal to 0 when using goto line.

The solution is a little bit more complicated than this.  If you have a project open, then the project has a GOPATH that we need to set up in the environment.  We also need to include $GOPATH/bin in PATH.  The old code was setting those variables explicitly because they should be the only environment variables that gocode needs.
Obviously, I'm missing some important information about the Windows environment.  I'll dig through some docs and see what I can find.  If you could post the output of os.Environ() (e.g. add log.Printf("Environ is %v", os.Environ()) to the gocode command), it would help me a lot.  I'm sure there's just a Windows environment variable that I know nothing about, and it's hard for me to look it up since I don't have a working Windows system to test on.

Yes, you're right. I must was more know about other OS.  Updated now for windows only.


Background problem issue buggy screen

Steps to Reproduce

Run flutter create bug.
Update the files as follows: ...
...

Expected results:
Actual results:

Logs

Hi @ljbdelacruz
can you please provide your flutter doctor -v and flutter run --verbose?
Also, to better address the issue, would be helpful if you could post a minimal code sample to reproduce the problem
Thank you

Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.1 19B2106, locale en-PH)
• Flutter version 1.12.13+hotfix.8 at /Users/fortunefaith/Desktop/projects/flutter/tools/flutter
• Framework revision 0b8abb4724 (4 weeks ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/fortunefaith/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.0)
• Xcode at /Applications/Xcode11.app/Contents/Developer
• Xcode 11.0, Build version 11A420a
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 43.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] VS Code (version 1.42.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.8.1

this is how i displayed the BG image
return SafeArea(
child:Container(
decoration: BoxDecoration(
image: DecorationImage(
image: AssetImage("assets/images/bgimage.png"),
fit: BoxFit.cover,
),
),
child: Scaffold(
backgroundColor: Colors.transparent,
body: Center( child: Viewer1Lottie(anim),)
,),
)
);

Hi @ljbdelacruz
It's probably your asset image not a Flutter issue
Since i didn't have access to your asset image, here i replaced with network image
Code Sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: SafeArea(
          child: Container(
        decoration: BoxDecoration(
          image: DecorationImage(
            image: NetworkImage("https://i.imgur.com/nWHQd22.jpg"),
            fit: BoxFit.cover,
          ),
        ),
        child: Scaffold(
          backgroundColor: Colors.transparent,
          body: Center(
              // child: Viewer1Lottie(anim),
              ),
        ),
      )),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you


The "Equipment" Trait or Pool gives me duplicate random items

I have found if I create a QItem with the  all other traits (Firearms, common, etc) trait or pool with randomized items, I will not get duplicate items.
However the "Equipment" trait/pool trait I have observed is giving out duplicate items.
I have starting QItems that generate from the "Common" trait/pool. The other items that generate random items from the other categories (firearms, tomes, etc) do not give me duplicate items. However the QItem that gives a random item from the "Equipment" trait/pool will frequently give out items that were given out as starting items.
I had first assumed that all randomised items were rolled up at the start of an event and could not be duplicates, but the Equipment doesn't seem to work this way.

I'll look into it.  Perhaps it is the same specific item(s) that are duplicated somewhere?  What packs do you have enabled when you see this problem?

MoMET1, MoMEM1(?), SM, BoT

FYI better not to use SM here, just use the FA/CotW elements you need.  If the user has SM enabled it will still work.

I'm having trouble reproducing this, it would be great if you could attach an example that can produce the problem if you still have one.

I can't reproduce this either anymore. I will re-open the case if I run into the issue again.


Memory increasing with string type values

I coded some C++ tests based on the sum-store example but modified them a bit to handle string values.
It works great, however the memory consumption gets growing till it eats all my RAM. Using Valgrind and Massif it happens that most of my RmwContexts live forever. Also the async. callbacks (deep copies) used for the contexts are never called.
Best regards & many thanks

RmwContexts are likely not being deleted because the callbacks aren't being called. This means that no I/Os are being completed.
If you are using thread pool I/O (currently supported on Windows, but not Linux) then the question is why the thread pool is not completing the I/Os. (Is Windows just not completing the file reads?) If you are using queue I/O, then you need to explicitly call TryComplete() on the I/O handler.
We may have wrapped TryComplete() inside Refresh(); but that's the most likely explanation. If the sum_store example is insufficient to diagnose, you could try looking at the benchmark driver, as well.

Thanks Badrish.
Tried store.disk.TryComplete() and store.disk.handler().TryComplete() and
still no luck.
I compiled the code for Windows and still see the same issues.
Best regards
On Sat, Oct 20, 2018 at 8:18 PM Badrish Chandramouli <
<EMAIL_ADDRESS>wrote:

RmwContexts are likely not being deleted because the callbacks aren't
being called. This means that no I/Os are being completed.
If you are using thread pool I/O (currently supported on Windows, but not
Linux) then the question is why the thread pool is not completing the I/Os.
(Is Windows just not completing the file reads?) If you are using queue
I/O, then you need to explicitly call TryComplete() on the I/O handler.
We may have wrapped TryComplete() inside Refresh(); but that's the most
likely explanation. If the sum_store example is insufficient to diagnose,
you could try looking at the benchmark driver, as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/FASTER/issues/54#issuecomment-431606079,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMA7d3yW8z1pkdMilbDypt1ciVA3Vnkvks5um2jygaJpZM4XyBIo
.

Closing as we have not seen this issue in our test cases. Related, @matthewbrookes has a recent PR at https://github.com/microsoft/FASTER/pull/128 that shows how variable length keys may be used with FASTER.


[Relay][Pass] Avoid stack overflow when using PostOrderRewrite

Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
Avoid stack overflow when there are many let nodes.

Thanks @hgt312 @mbrookhart @comaniac . This is now merged.


implement slab allocation quarantine

Combining a randomized array (per OpenBSD malloc) with a ring buffer (per my OpenBSD malloc extension).

This is implemented by https://github.com/AndroidHardening/hardened_malloc/commit/3a488c9a271eb14caf208ba123de4e5d47b72a59.


AnalyzeSequences bug due to Genome object

This line of code in AnalyzeSequences raises the following error:
AttributeError: type object 'Genome' has no attribute '_initialized'
The error appears to be because the default value, Genome, is not initialized when the init function is called for AnalyzeSequences and appeared in version 0.5.0. The issue doesn't occur in version 0.4.8.
I'm not sure how to handle the error because constructing a Genome object requires passing in the path to a file, but a file may not always be necessary, e.g. when calling the function AnalyzeSequences.get_predictions_for_fasta_file.

Thanks for finding this bug! I think we should remove these two lines.
        if not self.reference_sequence._initialized:
            self.reference_sequence._unpicklable_init()

Here because it only uses the Genome class and its class methods, not an Genome object, it does not have attribute _initialized and does not need to run  _unpicklable_init().

That makes sense! I can fix it and open a PR.

LGTM, thanks Ryan!


Quick fix for broken elastic search and my workflows

#3310
Attempts were being made to assign null to the Java primitive boolean
isLegacyVersion field in WorkflowVersion. This would happen when
fetching workflows, which would at least cause ES reindex
and My Workflows to fail.
Don't allow nulls in the table.
Quick fix because I don't know how it got into the state where the value
is null. But it makes sense to not allow nulls in any case. Nor did I
add a test. But I would like to get dev.dockstore.net working again.

Egads, check migrations is failing. Closing

Egads, check migrations is failing. Closing

Check migrations should just mean a failure to define a JPA model that corresponds to the migration. In this case, there's probably a not null annotation or a setting in the @Column annotation or similar.


Add touch support for mobile devices

Thanks @luke-john
https://github.com/facebook/fixed-data-table/blob/master/site/examples/TouchExampleWrapper.js

scroll also seems 'funky' on lenovo y50 touchpad


Integration Test - Release - 2022/01/27 09:06:48

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign PRMergerTest2

#reassign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#please-close

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#unassign PRMergerTest1

#unassign NonAllowedUser


Automated Package Upgrade

:tada: This PR is included in version 2.0.50 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore(docs): use plain JS objects for storing the context

Use a JS object to store the GraphQL resolver context instead of a function that returns the object.

Thanks @shreyas44!

Having a function to create the context is a very common pattern, I don't think I ever saw a production server with a static context.

@Sytten If you have a dynamic context which is derived or calculated from say the content of the http request, a function is definitely the right way to go. But, if it's static (which in the case of the tutorial it is) I don't think it makes a difference if you use an object or a function. I thought passing a plain object might make more sense in this case as there's no dynamic context at all.

The tutorial is about starting from nothing and building up out of necessity to learn. This change is more inspirit with that. The way I would address your point would be to have a the chapter about auth show why a function for context is needed.


Hot-spot: Kore.Step.EquationalStep.applyRulesSequence

This function is a hot-spot because it is the top of the inner loop of function evaluation. The generated code is more complex than it needs to be because this is not yet specialized to function evaluation; it still refers to Kore.Step.Step.

This will be obsolete when #1602 is fixed.


Fixing the article after internal discussions

Sid Sharma<EMAIL_ADDRESS>Jasmine Betthauser<EMAIL_ADDRESS>Casey Zhang<EMAIL_ADDRESS>

@githubarpyka : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@japere could you please have a look at the preview?

@githubarpyka , this looks great! I will sign off on the change.

#sign-off

@japere: I'm sorry - only the author of this article, @msmimart, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Palette newchunks Issue

When flying around  it generates chunk that become old when you try to load them. Tho with liquid stuff it shows them as new

can't fix
servers can generate more chunks than it is sending you.
this is vanilla behavior, there is a built-in chunk send rate limiter in 1.20.4+. Also can be worsened by you having a lower render distance than the server view distance


Add links to Italian 7b and 13b LoRA

Hi there,
I've added the links to two models trained on GPT-4 generated instruction-following data in Italian.

Thanks!


catch unreachable url

Hello~ how can i catch error once unreachable url I inserted?

@theo92hoo can you provide more information and the code needed to reproduce the what you're trying to do?

$connection =  new Connection(
    [
       "realm"   => 'test',
       "url"     => 'ws://<IP_ADDRESS>:9091'
    ]
 );

$connection->open();

for example, the actual port set on my server side was 9090 and i try to mis-inserted the port as 9091 in client side, therefore i hope it will return handshake error to me, but it didn't. Is it anyways for me to get the error? thx

@mbonneau should $connection->open() throw an exception when this happens?

This issue should be moved to the thruway/client. First, we should decide if we are going to keep the Connection object moving forward.
The open method returns nothing and most errors would be async. The only place to notify about an error would be to listen to the error emits (which I have not even checked to see if this is a problem if you do listen to that).


New command: spo group set

Usage
m365 spo group set
Description
Updates a group in the specified site
Options

Option
Description

-u, --webUrl <webUrl>
URL of the site where the group is located.

-i, --id [id]
Id of the group to update. Specify either id or name but not both.

-n, --name [name]
Title of the group. Specify either id or name but not both.

--newTitle, [newTitle]
New title for the group.

--description [description]
The description for the group.

--allowMembersEditMembership [allowMembersEditMembership]
Who can edit the membership of the group? When true members can edit membership, otherwise only owners can do this.

--onlyAllowMembersViewMembership [onlyAllowMembersViewMembership]
Who can view the membership of the group? When true only group members can view the membership, otherwise everyone can.

--allowRequestToJoinLeave [allowRequestToJoinLeave]
Specify whether to allow users to request membership in this group and allow users to request to leave the group.

--autoAcceptRequestToJoinLeave [autoAcceptRequestToJoinLeave]
If auto-accept is enabled, users will automatically be added or removed when they make a request.

--requestToJoinLeaveEmailSetting [requestToJoinLeaveEmailSetting]
All membership requests will be sent to the e-mail address specified.

--ownerEmail [ownerEmail]
Set user with this email as owner of the group. Specify either ownerEmail or ownerLoginName but not both.

--ownerLoginName [ownerLoginName]
Set user with this login name as owner of the group. Specify either ownerEmail or ownerLoginName but not both.

Examples
Update group title and description
m365 spo group set --webUrl https://contoso.sharepoint.com/sites/project-x --id 18 --newTitle "Project contributors" --description "This group contains all project contributors"

Update group with membership requests
m365 spo group set --webUrl https://contoso.sharepoint.com/sites/project-x --title "Project leaders" --allowRequestToJoinLeave true --requestToJoinLeaveEmailSetting<EMAIL_ADDRESS>
Sets a specified user as group owner by group ID
m365 spo group set --webUrl https://contoso.sharepoint.com/sites/project-x --id 18 --ownerEmail<EMAIL_ADDRESS>
Additional Info
Update group:
PATCH https://contoso.sharepoint.com/sites/project-x/_api/web/sitegroups(<id>)
Accept: application/json
Content-Type: application/json

{
    "Title": "New Site Group",
    "Description": "New Site Group description",
    "AllowMembersEditMembership": false,
    "OnlyAllowMembersViewMembership": false,
    "AllowRequestToJoinLeave": false,
    "AutoAcceptRequestToJoinLeave": false,
    "RequestToJoinLeaveEmailSetting"<EMAIL_ADDRESS>}

Set owner:
POST https://contoso.sharepoint.com/sites/project-x/_api/web/sitegroups(<group id>)/SetUserAsOwner(<user id>)
Accept: application/json
Content-Type: application/json

Hi @milanholemans,
Two points here:
-I'd like to use name instead of title here as well. Let's open another issue to discuss name vs title
-could we use 1 property for owner, instead of two? The user should be able to use Loginname or e-mail. As these types of data are more or less the same, it's okay to combine them me thinks.

-I'd like to use name instead of title here as well. Let's open another issue to discuss name vs title

All right :)

-could we use 1 property for owner, instead of two? The user should be able to use Loginname or e-mail. As these types of data are more or less the same, it's okay to combine them me thinks.

Was thinking the same, until I saw that spo group user add uses these 2 options. Same for spo user get. What should we do? Keep it or combine it?

Hmmm... in this case I prefer that we first check if there is a good reason for this.
If not, I'd say combine the two for owner and create an issue to combine them for the other commands as well.

Just checked. It uses the aad user get command, in which one of both properties are expected to be specified.
That's unfortunate... I dislike having 2 options for roughly the same func. 😎
But okay, let's just align it with the other commands and keep 2.

But maybe we should align the option names:
ownerUserName and ownerEmail

That's great @milanholemans! Do change the newTitle to newName though. Good luck!

That's great @milanholemans! Do change the newTitle to newName though. Good luck!

Well spotted 😃


Update Information for NineAnimator

The requested changes have been forwarded to our editors, but we don't accept direct modifications due to our backend-editor getting out of sync with the file-state.

The requested changes have been forwarded to our editors, but we don't accept direct modifications due to our backend-editor getting out of sync with the file-state.


Semantic token support

Since https://github.com/neovim/neovim/pull/21100 has been merged in nightly.

Thanks, I'll look into it

This is now on main and unfortunately the thing that keeps me from using oxocarbon vs tokyonight or others that already support it

Yep, this would be great!

I think for this one would "only" need to define all of the @lsp.* colors, that can be viewed using :highlight.
See here for reference:
https://github.com/folke/tokyonight.nvim/blob/161114bd39b990995e08dbf941f6821afbdcd666/lua/tokyonight/theme.lua#L266

Should have some initial support but I will refine it further


do not perform the login and the cors error

Hey @MatheusMoreira0101, Can you help me with more details?

Operating system
Commands you ran to start the app

Cross-origin request blocked: The same origin policy (Same Origin Policy) prevents the remote resource from being read at https://i.instagram.com/api/v1/qe/sync/. (Reason: the ‘user-agent’ header is not allowed according to the ‘Access-Control-Allow-Headers’ header of the CORS verification response)


Docking action succeeds but not centered on dock

The bug
Docking action succeeds but Create3 model is not in valid "Charging Position" on dock

To Reproduce

(Unbuntu 22.04, ROS 2 Humble or Galactic, update/upgrade, clone create3_sim main, rosdep, build, source setups, run classic gazebo)

ros2 launch irobot_create_gazebo_bringup create3_gazebo.launch.py

Undock, Move, Dock:

pub undock

ros2 action send_goal /undock irobot_create_msgs/action/Undock "{}"

pub move to -1,0 w: 1

ros2 action send_goal /navigate_to_position irobot_create_msgs/action/NavigateToPosition "{achieve_goal_heading:true,goal_pose:{pose:{position:{x: -1,y: 0,z: 0.0}, orientation:{x: 0.0,y: 0.0, z: 0.0, w: 1.0}}}}"

pub dock goal:

ros2 action send_goal /dock irobot_create_msgs/action/Dock "{}"

(Or /DockServo for Galactic - same issue Galactic or Humble)

Echo dock_status, odom

Expected behavior:   Return to dock in "Charging Position"
Additional context
$ uname -a
Linux FU22 6.2.0-37-generic #38~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Nov  2 18:01:13 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

$ more /etc/os-release
PRETTY_NAME="Ubuntu 22.04.3 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.3 LTS (Jammy Jellyfish)"

(20.04 used for Galactic test)

$ dpkg -l | grep gazebo11
ii  libgazebo11:amd64                                  11.10.2+dfsg-1                          amd64        Open Source Robotics Simulator - shared library

$ more package.xml
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematype
ns="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
  <name>irobot_create_gazebo_sim</name>
  <version>2.0.0</version>

Update: I see that this was first reported two years ago, not closed as working as designed and not fixed.  Is this actually working as designed?  Does the simulation odometry error approximate what is seen with the physical Create3?

Suggest adding a reset of odometry when dock status docked changes from false to true.  This will allow the “drift” but correct the odometry based on known “localization”.


build: update version to v3.2.1

After releasing, the version will be changed back to v3.2-canary again.

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

/retest ci/centos/containerized-tests

/retest ci/centos/containerized-tests

/retest ci/centos/mini-e2e/k8s-1.19

/retest ci/centos/mini-e2e/k8s-1.19

/retest ci/centos/mini-e2e/k8s-1.19

Failed due to #1795 :
ProvisioningFailed: failed to provision volume with StorageClass "csi-rbd-sc": rpc error: code = InvalidArgument desc = invalid encryption kms configuration: missing encryption passphrase in secrets

/retest ci/centos/mini-e2e/k8s-1.19

Failed due to #1795 :
ProvisioningFailed: failed to provision volume with StorageClass "csi-rbd-sc": rpc error: code = InvalidArgument desc = invalid encryption kms configuration: missing encryption passphrase in secrets


Network Watcher Platform Dependency Validation Failure

| 18:13:35 - Error: Code=InvalidTemplateDeployment; Message=The
 | template deployment 'networkWatchers-20211107T1811062763Z' is
 | not valid according to the validation procedure. The tracking
 | id is 'd3aa4911-f0ff-4223-a8e0-7aa680e318ab'. See inner errors
 | for details.

This occurs when running the platform dependencies pipeline. (US Gov Tenant)

@cacarroll can you please provide the detailed log for this correlation id?

Closing as there was no progress in 3 months