Gifsicle not working on AWS Lambda

How to get gifsicle working, I have compiled the binary but it still fails gives cannot fine gifsicle in the path error.
Even normal gif images are failing

ok found something but dont know how i can get it working with this package
https://www.dadoune.com/blog/best-thumbnailing-solution-set-up-thumbor-on-aws/
They have created an optimizer which needs to be added to thumbor/optimizer dont know how to do that

We are testing a new update to support this request. Would anyone mind testing the following template and provide feedback if this is what you are looking for?
https://s3.amazonaws.com/solutions-test-reference/serverless-image-handler/latest/serverless-image-handler.template

We included gifsicle in v2.2. Would you verify if this resolves this issue?
https://s3.amazonaws.com/solutions-reference/serverless-image-handler/latest/serverless-image-handler.template

@stevemorad Thank you for the update, I made my own changes and have been using the same, Will check you solution and get back to you as soon as possible

I had forked the project and used the same you can check what I have done, I got ffmpeg working for gif to solve my issue
https://github.com/bananabandy/serverless-image-handler

You can look in the Lambda log files for the custom resource to see why it's failing. This is often related to an S3 bucket permission issue (e.g. mistyping the bucket name or using a bucket that the test environment does not have access to).

@stevemorad sure I shall check and get back to you soon

@stevemorad I tried it again got the function to compile but to test it out I started getting the following error
[WARNING]	2018-05-09T11:24:01.247Z	7749ad3d-537b-11e8-be70-09644b79a80f	Malformed URL: /images/1.jpg
Tried solutions i found online non of them worked

Does the demo website work?

@stevemorad
I have fixed it had to make changes as the build script kept breaking, pip updated was breaking stuff I have forked this project and made changes, you can have a look here
https://github.com/bananabandy/serverless-image-handler
There are few issues which i am working on
Here is ui link
https://s3.ap-south-1.amazonaws.com/indiefolio-test/serverless-image-handler-ui/index.html
GIF image to test
https://s3.ap-south-1.amazonaws.com/indiefolio-test/serverless-image-handler-ui/img/cef35faa46aa232a4848a4ea4a30b557.gif
Seems like Gifsicle is working but there are few other issues which will be out of scope here I guess but just mentioning here
The quality of the images degrade like crazy
Image uploaded on Behance and their optimizer does this
Original image
https://mir-s3-cdn-cf.behance.net/projects/original/4443b354394403.Y3JvcCwxMjk3LDEwMTUsNTQsMA.jpg
Optimized image
https://mir-s3-cdn-cf.behance.net/projects/404/4443b354394403.Y3JvcCwxMjk3LDEwMTUsNTQsMA.jpg
Original Image
https://s3.ap-south-1.amazonaws.com/indiefolio-test/serverless-image-handler-ui/img/1.jpg
Thumbor Optimized Image
https://d3gwrgc1s4dyfr.cloudfront.net/fit-in/404x0/serverless-image-handler-ui/img/1.jpg
The quality is really something bad, in my thumbor config i have kept everything on 100 and still get this back
Any suggestion would be really helpful
Also @stevemorad thank you for all your help with Gifsicle

@deadmantfa - glad you've had some success. I don't have a really good graphical eye, but I think you are trying to compare this:
https://mir-s3-cdn-cf.behance.net/projects/404/4443b354394403.Y3JvcCwxMjk3LDEwMTUsNTQsMA.jpg
with
https://d3gwrgc1s4dyfr.cloudfront.net/404x316/serverless-image-handler-ui/img/1.jpg
It looks like the second version is a little washed out, that might be fixable with changing default brightness/contrast filters (assuming all your images render this way).
Additionally, since these are JPG files, we included alternative JPEG engines as well (mozjpeg, jpegtran, imgmin) that you might want to try.

@stevemorad I have tried them with all and all seem washed out, the sharpness just disappears.
Will try and find a solution and update you when I do
Cheers and thanks for all you help.

@Enalmada I have actually set it to 100 so maybe that might be an issue for the increase in size. I will test it out and get back to you

Yes, perhaps 100 is the problem.  I tried the jpg above with this online converter at 100 and it created a webp of 223kb.  I thought webp would be a tiny bit smaller than a source jpeg at high quality levels and just wasn't expecting it to be 2x as big.

Quality=100 on webp means lossless compression. It would be fair to compare it with other lossless format, like png.

Ah that makes sense.  Ok, well it seems gif works now this issue can probably be closed and perhaps other tickets can be opened about sharpness/quality.

@deadmantfa  How about doing a pull-request back to awslabs for you gif changes?
Also, please do better commit messages, 40 commits with "Pixel Size increase" aren't helpful at all for those trying to understand what changed! :)

@danielmotaleite Yes I am aware about it, it was supposed to just a private repo for me never meant to be public as there are quite a lot of shortcuts I have taken in that repo also I am not very proficient in python im just a beginner. So not very confident about the changes I made, but I will clean up the code when I get a chance and set a proper commit message and send a pull request, hopefully this weekend

@deadmantfa please close the thread if the gifsicle issue is resolved, and create another thread with sharpness/blur issue

Is gifsicle really working? It gives me this error when trying to thumbnail a gif animation:
[ERROR]	2018-11-13T08:16:53.778Z	lambda_handler trace: Traceback (most recent call last):
File "/var/task/image_handler/lambda_function.py", line 338, in lambda_handler
result = call_thumbor(event)
File "/var/task/image_handler/lambda_function.py", line 317, in call_thumbor
return process_thumbor_responde(thumbor_response, vary)
File "/var/task/image_handler/lambda_function.py", line 287, in process_thumbor_responde
vary = thumbor_response.headers['vary']
File "/var/task/requests/structures.py", line 52, in __getitem__
return self._store[key.lower()][1]
KeyError: 'vary'

Lambda function version is 3.1.0.
Changed configuration option: USE_GIFSICLE_ENGINE = True.


Any way to toggle off certain enchantments in the game like XP Boost etc?

Issue Description:
Other than soulbound, I do not see options in config to toggle off some of the custom enchantments, is there a way to do it ? (such as toggle off XP Boost, auto smelt etc).

Affected Versions (Do not use "latest"):

EnderIO: <IP_ADDRESS>_alpha
EnderCore: <IP_ADDRESS>
Minecraft: 1.9.4
Forge: 1960

Your most recent log file where the issue was present:
[pastebin/gist/etc link here]

The enchantments are added by Ender Core and can be turned off in its config file.


Non-grouped panels show up as grouped when nested inside a grouped panel

non-grouped panels that are inside of a panel that is itself part of a panel group are getting the margin-bottom:0px style applied. This makes them appear as though they are grouped even when they are not, and messes up spacing with anything that comes below them.
See this plunker for an example with a work-around: http://plnkr.co/edit/9i94bBFeWCIusPiuVhf6?p=preview

Hi @timscaffidi!
You appear to have posted a live example (http://run.plnkr.co/plunks/9i94bBFeWCIusPiuVhf6/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

W001: <head> is missing UTF-8 charset <meta> tag
W002: <head> is missing X-UA-Compatible <meta> tag that disables old IE compatibility modes
W003: <head> is missing viewport <meta> tag that enables responsiveness
line 5, column 5: W013: Bootstrap version might be outdated. Latest version is at least 3.3.5 ; saw what appears to be usage of Bootstrap 3.3.1

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

fixed bootlint errors. Updated plunker: http://plnkr.co/edit/9i94bBFeWCIusPiuVhf6?p=preview

Hi @timscaffidi!
You appear to have posted a live example (http://run.plnkr.co/plunks/9i94bBFeWCIusPiuVhf6/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

W001: <head> is missing UTF-8 charset <meta> tag

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

fixed bootlint errors. Updated plunker: http://plnkr.co/edit/9i94bBFeWCIusPiuVhf6?p=preview

I noticed this issue when using UI Bootstrap accordion component with panels nested inside the accordion panes.

Bootstrap 3 is no longer being officially developed or supported.
All work has moved onto our next major release, v4. As such, this issue or pull request is being closed as a "won't fix." For additional help and support, we recommend utilizing our community resources. Thanks for your understanding, and see you on the other side of v4!
<3,
@mdo and team


Issue 176: remove biznes.gov.pl section for no outsanding tax debt certificate

As per request https://t.me/c/2428959115/68

Thank you for the contribution!


Blue artifacts when displaying images

Hi,
Sory for my poor english, as I'm french :)
I tried T-RGB Display (2.8) with project from Nishad2m8 (https://github.com/nishad2m8/T-RGB-YT/tree/master/02-Moon-Phase-Clock-T-RGB)
All works great, except for the image rendering.
All images (mainly with greyish or blueish tints) presents blue artifacts. Maybe a roundig color problem ?
The problem appears whatever image source is used. From C array, bin image from lvgl converter and direct load from SD card, in jpg or png format.
I loaded the same image with the same version of LVGL (but LovyanGFX instead of TFT_eSpi) on another dev board (WT32SC01 plus with ST7796UI display controller, parallel rgb565) and there is no artifact.
I saw somewhere on a STM32 forum, a user had the same problem with the ST7701s display driver, and apparently solved this and said, I quote : "This was due to the pixel polarity - it was inverted". But no further explanations.
As I have not enough knolewdge on low-level lcd display driving, I hope someone could help
Thanks

This problem is caused by the fact that T-RGB uses the RGB666 pixel format screen (cannot be configured as RGB565), and esp32s3 only supports RGB565 and RGB888 pixel formats, so some pixels are missing.
https://docs.espressif.com/projects/esp-iot-solution/en/latest/display/lcd/rgb_lcd.html

OK I understand, but is there a solution to avoid this problem ?

There is currently no solution to this problem


[1.20.1] [Forge] Visual Overhaul crashes when rendering a juke box

https://bytebin.lucko.me/NZI2K85rpI

I can't access the crash log anymore, please just upload it to GitHub


Messaging: Personless email announcement

Messaging
Context
We have a launch for personless events coming up. There's an RFC for it here: https://github.com/PostHog/product-internal/pull/583/files so I won't reiterate
This comm needs to go to all users. It needs to go after the TOS update we're doing - https://github.com/PostHog/meta/issues/195 -  Personless is also a blocker to other pricing changes which we'll communicate, so we need to get this out in short order. But deadline is TBD.
I have an art request out with @lottiecoxon - https://github.com/PostHog/posthog.com/issues/8248 - which is in production and will feature here.
Requested input
Feedback from @raquelmsmith and @simfish85
Previews
First, rough draft. Details subject to change. Non-final art.

Note: Need to add in the TOS update here too.

New version also include TOS news. CC @fraserhopper and @charlescook-ph
Still not final art or links.

Now featuring the world's fattest pig

I don't "added a new event type" is correct. Afaik, direction of travel is events are just events, and we're giving people more control over what data is collected. Something like "We're giving you more control of data collection and, good news, it makes PostHog up to 12x cheaper..."

I think your original final para was better. This one makes it seems like the blog is about our terms.

Looks good! Just one small suggestion

it makes PostHog up to 12x cheaper, depending on your volume
I think you can get rid of "depending on your volume". "up to" already covers that and could read a little overly caveated.

nit: I don't think we normally capitalize posthog-js.

I don't think we should call it a "new event type." It should be more around:

We've split our costs up so you can fine-tune your bill. Now getting advanced person data like person properties and UTMs for never-identified traffic is optional and separate from our event costs.

Yep, this terminology was all rough until we had a name. Will respin it
tomorrow now we know it's person profiles (since we at least want to use
that name specifically).
On Mon, 15 Apr 2024, 21:13 Raquel Smith, @.***> wrote:

I don't think we should call it a "new event type." It should be more
around:
We've split our costs up so you can fine-tune your bill. Now getting
advanced person data like person properties and UTMs for never-identified
traffic is optional and separate from our event costs.
—
Reply to this email directly, view it on GitHub
https://github.com/PostHog/meta/issues/196#issuecomment-2057722817, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AUA6UKPOZOSR23OPHGVUDSTY5QYGPAVCNFSM6AAAAABGG6MFB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJXG4ZDEOBRG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

IMO both this announcement and the blog post explain the how but not the why. To me we're missing the story that connects the two.
I went ahead and wrote up a blurb to try to explain why we're doing this. Feel free to use here, in the blog post, or ignore entirely.

TL;DR: We're making it 12x cheaper to track anonymous users on your website or product by restructuring how we track events.
Most companies track user events in one of two ways (or use both):

Anonymous tracking (like what Google Analytics collects) - you get basic info like the user's browser, OS, and UTM source
Identified events (like what PostHog has always offered) - send custom properties (like email, plan, etc) and get a deeper level of insights as a result

Since PostHog began in product analytics, we've only ever offered identified events. This works great for building deep insights, but this per-event pricing doesn't scale with large volumes of traffic (like on a marketing site) where you don't know their email (yet, don't have any custom properties that are worth tracking, and don't get the full value of identifying those visitors.
So today we're introducing an updated event pricing that makes it cheaper to track anonymous visitors. (In fact, if you don't need to identify users, event tracking becomes ~12x cheaper!)
We're also changing how we refer to events:

All events are now anonymous, and come with basic properties (browser, OS, geo IP, limited UTM properties)
Enable Person profiles (a new add-on) to get the full power of PostHog events as you've always known them today

As an existing customer, we'll enroll you in this automatically, but you can change it at anytime

Tracking an event + enabling person profiles = the same cost of traditional PostHog events as you've always known them - you won't pay more.

Things you should know:

You can choose when you want to enable a person profile. A common example of this is when a user signs up (and enters their email), it's a good time to enable their person profile.
Once a person profile is enabled for a user, you'll be billed for both the (cheaper) event price and for the person profile add-on per-event.

Things I tried to hit in the above:

Why you'd use one vs the other
"Up to 12x less" is a little disingenuous without directly caveating that it's for anonymous users only, and to use the same product you're used to today, there might not be much difference
Nomenclature change

Thanks all -- appreciate the feedback. Just to clarify: The final version will adhere more closely to James' blog, reference Persons Profiles specifically, explain a bit more of the why, link to finished docs, etc. These are all things we've been blocked on until now and I've been sharing these rough drafts to get feedback from the specific people I've tagged as we continue working on this. Apologies if this wasn't clear before!

OK, consider this a first final draft.
After chatting with a few people I think we can drop the caveat around not being able to use data you don't have, and I've tried to bring the why out a bit more.
Nomenclature around the config still seems to be changing, but I'll revisit as there'll be at least one more version.

Where does that link to?
It doesn't flow as well but you could say "you may want to use identified_only on your marketing site..." as that's the mode I would expect people to use there.

Where does that link to?

If we wanted to include the min posthog-js version it would be 1.125.0

Do we want to include this? I want to make sure we're giving the correct info in your opinion.

Now that we're coming up on a louder launch, here's some new suggested copy for the email. CC @raquelmsmith for the approval here.

If you're like us you probably only need profiles for logged in users, for example. For others you can skip prifiles, track them anonymously in the web analytics beta, and save money in the process. Simple.

Replace with (edits in bold):
If you're like us you probably only need profiles for logged-in users, for example. For others you can skip using profiles entirely and track people anonymously in the web analytics beta. For both cases, you'll end up saving money in the process. Simple.

...but if you're curious why we're helping you spend less then CEO James Hawkins

Replace with (edits in bold):
...but if you're curious why we're helping you spend less, CEO James Hawkins
(the less then read very weird in my head, I thought it was a typo at first)

Great, finalized version. I'll look at the blog post next and we can send when that's locked in.

Missing 'the' before "web analytics beta.

I have rethought this from scratch and introduced some much needed sass.

Slight tweak

Honestly, it's like we're allergic to cash.

Feels forced, but take it or leave it.

Anonymous events work by skipping the properties we collect on other, identified events

This phrasing feels awkward and doesn't really tell me what "properties" are, or mean to me.
I might be biased, but check out the copy on the pricing page → explain event types modal. I put a lot of effort into trying to distill it into something digestible. Maybe we can match some language?

*Default for unidentified users only, so you save money without much data loss

This even confuses me and I wrote the explanation on this stuff

Good notes. Let's try this:

The first line should say "session replay" - remove the plural S from replays.
I don't want to say we're launching a new event option called anonymous events. We've always had tracking for anonymous users, and I feel like that's inconsistent. But we have is new pricing for anonymous events.
We should also avoid using the term personally identifiable information as that's a legal term, PII, and we should avoid that when we can.
What we do is we skip creating a person in posthog for these anonymous events, and that means there are no properties stored for the person.
"Personal data" -> person profiles

The first line should say "session replay" - remove the plural S from replays.

✅

We should also avoid using the term personally identifiable information as that's a legal term, PII, and we should avoid that when we can.

Switching for 'individually identifiable', which matches the pricing page. Feels a bit clunkier, but legal reason is a good point.

What we do is we skip creating a person in posthog for these anonymous events, and that means there are no properties stored for the person.

"Personal data" -> person profiles

I've changed this to 'that data' because I don't think it's useful in the announcement to introduce the concept of person profiles specifically and, if person profiles ultimately are a way of storing this data then referring to the data itself is sufficient. I'd quite strongly like to keep this focused on the use-case and price cut as much as possible, referring to the docs for technicals.
I basically want to avoid letting this become: "There are anonymous events and identified events. Identified events have person profiles, which are a way of storing person properties, which are individually identifiable data that includes email or other custom properties. Anonymous events skip the person profiles, so don't have person properties, though they do keep some non-customizable data which isn't individually identifiable, such as device and location. Also, anonymous events are cheaper." 🤣

I don't want to say we're launching a new event option called anonymous events. We've always had tracking for anonymous users, and I feel like that's inconsistent. But we have is new pricing for anonymous events.

Tried to clear this up. I personally feel it's a little less clear now, but happy to defer

Looks good - not a huge fan of the Oh Crap but maybe it's on brand?

Looks good. As an aside - this isn't an automatic drop for people, because previously-made person profiles will still have events be "identified" even if the person was never "identified." So it'll be more like a slow slide as previously-seen users are replaced with new users. I don't think we need to call that out but I'm calling it out just in case you want to call that out.

Slight tweak to the language, and also an FYI that we'll send this only to users who match our 'recently engaged' segment (i.e have signed in during the last 4 months) in order to protect our deliverability. I think this classes as a service update, so it'll go to all users regardless of subscription preference.
Everyone seems happy and the copy changes aren't major, so I'm scheduling this in to send on Wednesday, 11th Dec 11AM London time.


Feature/html5 doctype

Description

Motivation and Context

How Has This Been Tested?

Type of Changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that changes existing functionality)

Documentation and Compatibility

What documentation changes are needed for this feature?
(Provide links to existing documentation topics that will require updates)
Will this change affect backwards compatibility or other users' overrides?

Checklist

My code follows the code style of this project.

https://github.com/dita-ot/dita-ot/wiki/Java-Coding-Conventions
https://github.com/dita-ot/dita-ot/wiki/XSLT-Coding-Conventions
https://github.com/dita-ot/docs/wiki/coding-guidelines

I have updated the unit tests to reflect the changes in my code.

Description

From xsl output element, removed encoding and doctype attributes. Added text to root rule.

Motivation and Context

W3 Validator errors as in https://github.com/dita-ot/dita-ot/issues/3715.

How Has This Been Tested?

This has produced correct output on my local machine when validated on W3.

Type of Changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Not functional, but fixes the validation.

Documentation and Compatibility

What documentation changes are needed for this feature?
None.
Will this change affect backwards compatibility or other users' overrides?
I don't think so.

Checklist

My code follows the code style of this project.

https://github.com/dita-ot/dita-ot/wiki/Java-Coding-Conventions
https://github.com/dita-ot/dita-ot/wiki/XSLT-Coding-Conventions
https://github.com/dita-ot/docs/wiki/coding-guidelines

I have updated the unit tests to reflect the changes in my code.
Not sure. I committed rather hastily after I saw issue #3715 posted this morning.


Calendly Meeting

When user submits feedback about DLP, notify them of option to discuss their feedback via a 15 to 20 minute meeting that can be scheduled over calendly.
good place to start: automated email notification via AWS SES endpoint with calendly meeting link once feedback is submitted through the form on our website.
please comment if you have concerns or suggestions relating to this issue
starting point: https://help.calendly.com/hc/en-us/articles/4409838727703-Embedding-Calendly-on-your-site#how-to-add-your-event-type-to-your-website-0-1

added


Swipe Left??

Hi,this is concerning the List View Swipe code your library allows to Implement.
There is a right to left swipe view that shows the delete Item menu,but how do we create a layout that will allow us to Implement a swipe from left to right to show something on the other side too?

This is a really old question, but you can use this:
swipeLayout.addDrag(SwipeLayout.DragEdge.Left, findViewById(R.id.left);
swipeLayout.addDrag(SwipeLayout.DragEdge.Right, findViewById(R.id.right);

This way, when you swipe left you will show the left view, and when you swipe right you will show the right view.

If I add only right view, it shows me only on right swipe. But if I add only left view, it shows me in both left and right swipe. Any ideas?
Code:
        swipeLayout = (SwipeLayout) itemView;
        swipeLayout.setShowMode(SwipeLayout.ShowMode.PullOut);
        swipeLayout.addDrag(SwipeLayout.DragEdge.Left, swipeLeftView);

@frodberserk , I think this will work for you when you want only left swipe:
swipeLayout.setLeftSwipeEnabled(true);
swipeLayout.setRightSwipeEnabled(false);

when I try this
((MyViewHolder) holder).swipeLayout.addDrag(SwipeLayout.DragEdge.Left, ((MyViewHolder) holder).ll_SwipeDown);
it gives me this error
Error:(149, 48) error: cannot find symbol method addDrag(DragEdge,LinearLayout)
why this error is comming please sove thanks in advance


[BUG] Third-person distance

The third-person viewdistance doesn't work for me at least. When I move the slider nothing happens.

try re-check thirdperson checkbox.

I’ll test when I get home from work. Does it work for you though, @NexSqaud?

Yes.


Add localized menu title support.

I didn't implement this changes to those constructors which are receiving (NS)AttributedString objects, considering that Attributed Strings are not directly localizable like plain strings.
Note: The previous constructor has been changed from .init(_ title: String) to .init(verbatim title: String).
This might be a ground-breaking change to those projects who are already using this package.

Also a memo to input method developers:
If using this package to build the main menu of your input method, there are two things to mention:

.onSelect {} doesn't work. Use .action(#selector(self.LOREMIPSUM(_:))) instead.
Submenus responsive to neither shortcut keys nor .action().

@j-f1 Sorry for interrupting, but may I confirm whether this repository is actually accepting external pull requests?

Oh sorry, this PR must have slipped through the cracks. I will merge it soon!

Actually, now that I think about this a little more, I’m not sure this is a good idea. NSLocalizedString only allows auto-generating strings files if you pass a string literal directly into it, so people who use this API won’t get that functionality. On the other hand, if they do MenuItem(NSLocalizedString("whatever")) the translated string will be run through the localization logic again which might have unexpected results. I think I’ll rename those initializers to init(localized:) to make sure people are aware this is happening, and then add LocalizedStringResource support when building for iOS 16.

Published v3.0.0!


Waiting for the training script

Thanks for providing the implementation of such wonderful work!
Can't wait to see the full training scripts as other Forkers do!

Hi Wei,
Does the current version support the use of the trained model in a new protein's docking process, instead of the WDR domain of LRRK2 protein? I saw the coordinates of the pocket center are needed in the high_throughput_virtual_screening_LRRK2_WDR.ipynb, but didn't find the function of generating such coordinates of the pockets in of new protein.
Cheers.

You can construct the "info" pandas DataFrame yourself. The pocket center column could be manually changed.
Hope this help.

@luwei0917  Do you have any updates for the training script?

In early commit
(https://github.com/luwei0917/TankBind/commit/18314e9664621f44fd1f83a7c3660d547c74afad),
you could find an exmaple "examples/prediction_example_using_PDB_6hd6.ipynb" to construct
the dataset, and the main.py script to train. "python main.py -d 0 -m 0
--batch_size 5 --label baseline --addNoise 5
--use_equivalent_native_y_mask" is the script I used to train the model.

Great! Thank you so much.

Thanks for your interest.
In early commit (18314e9), you could find an exmaple "examples/prediction_example_using_PDB_6hd6.ipynb" to construct the dataset, and the main.py script to train. "python main.py -d 0 -m 0 --batch_size 5 --label baseline --addNoise 5 --use_equivalent_native_y_mask" is the script I used to train the model.

That's great! Thank you so much.

@luwei0917  Do you have any plan to publish the fully training dataset?

It has been uploaded.

Hi Wei,
I ran the main.py as your script and got  the following error:
File "TankBind-main\tankbind\data.py", line 164, in get_data
new_dataset.data = new_dataset.data.query("c_length < 100 and native_num_contact > 5").reset_index(drop=True)
AttributeError: 'NoneType' object has no attribute 'query'
Maybe the training data under "./apr22_pdbbind_gvp_pocket_radius20" is absent?

Thanks for your interest.
In early commit (18314e9), you could find an example "examples/prediction_example_using_PDB_6hd6.ipynb" to construct the dataset, and the main.py script to train. "python main.py -d 0 -m 0 --batch_size 5 --label baseline --addNoise 5 --use_equivalent_native_y_mask" is the script I used to train the model.

Hi Wei,
I ran the main.py as your script and got the following error:
File "TankBind-main\tankbind\data.py", line 164, in get_data new_dataset.data = new_dataset.data.query("c_length < 100 and native_num_contact > 5").reset_index(drop=True) AttributeError: 'NoneType' object has no attribute 'query'
Maybe the training data under "./apr22_pdbbind_gvp_pocket_radius20" is absent?

hello,
I have the same mistake as you. Have you solved this problem? If so, can you help me

Hi Wei,
I ran the main.py as your script and got the following error:
File "TankBind-main\tankbind\data.py", line 164, in get_data new_dataset.data = new_dataset.data.query("c_length < 100 and native_num_contact > 5").reset_index(drop=True) AttributeError: 'NoneType' object has no attribute 'query'
Maybe the training data under "./apr22_pdbbind_gvp_pocket_radius20" is absent?

Thanks for your interest.
In early commit (18314e9), you could find an example "examples/prediction_example_using_PDB_6hd6.ipynb" to construct the dataset, and the main.py script to train. "python main.py -d 0 -m 0 --batch_size 5 --label baseline --addNoise 5 --use_equivalent_native_y_mask" is the script I used to train the model.

hello,
I also have the same mistake... Have you solved it now?

Hi Wei,
I ran the main.py as your script and got the following error:
File "TankBind-main\tankbind\data.py", line 164, in get_data new_dataset.data = new_dataset.data.query("c_length < 100 and native_num_contact > 5").reset_index(drop=True) AttributeError: 'NoneType' object has no attribute 'query'
Maybe the training data under "./apr22_pdbbind_gvp_pocket_radius20" is absent?

Thanks for your interest.
In early commit (18314e9), you could find an example "examples/prediction_example_using_PDB_6hd6.ipynb" to construct the dataset, and the main.py script to train. "python main.py -d 0 -m 0 --batch_size 5 --label baseline --addNoise 5 --use_equivalent_native_y_mask" is the script I used to train the model.

hello!!
I also have this mistake, Have you solved it now?

Hi Wei,
我将 main.py 作为您的脚本运行，并收到以下错误：
文件“TankBind-main\tankbind\data.py”，第 164 行，get_data new_dataset.data = new_dataset.data.query（“c_length < 100 和 native_num_contact > 5”）.reset_index（drop=True） AttributeError：“NoneType”对象没有属性“query”
也许“./apr22_pdbbind_gvp_pocket_radius20”下的训练数据不存在？

Thanks for your interest.
在早期提交 （18314e9） 中，您可以找到一个示例“examples/prediction_example_using_PDB_6hd6.ipynb”来构建数据集，以及要训练 main.py 脚本。“python main.py -d 0 -m 0 --batch_size 5 --label baseline --addNoise 5 --use_equivalent_native_y_mask”是我用来训练模型的脚本。

hello!!
I also have this mistake, Have you solved it now?


/fix new term "raw" used in<EMAIL_ADDRESS>instead of "frozen"

$state.frozen was replaced by $state.raw in Svelte 5.00-next.218.

Fixed in another pr


Sails apps cannot use hooks published to npm as namespaced modules

I was trying to load a custom hook from my own npm namespace by installing it from npm from @lennym/sails-hook-sockets, but because this installs into ./node_modules/@lennym/sails-hook-sockets it is ignored by Sails.
I'd propose swapping some of this code (https://github.com/balderdashy/sails/blob/master/lib/hooks/moduleloader/index.js#L399-L407) for something that instead reads the app's package.json for dependencies, and then uses require.resolve('<module>/package.json') to read their pacakge.json files.

Note: workaround is obviously to put the following in ./api/hooks/sockets.js:
module.exports = require('@lennym/sails-hook-sockets');

It's just a little bit of a hack, and it's be nicer if it "just worked".

Thanks for the heads up @lennym- and for posting the workaround.  I was just looking at a similar issue re: adapters in the orm hook.  We'll look at it for hooks asap.  If anyone has time to submit a PR for this, that'd be awesome.

I'd propose swapping some of this code (https://github.com/balderdashy/sails/blob/master/lib/hooks/moduleloader/index.js#L399-L407) for something that instead reads the app's package.json for dependencies, and then uses require.resolve('/package.json') to read their pacakge.json files.

:+1:

Thanks. I'll see if I can put together a PR today if I get some time.

@mikermcneil  @lennym  - I believe it's just the regex here that needs changing to:
/^(sails-hook-)|(@.+\/sails-hook-)/

Here's a regex101 of it: https://regex101.com/r/lC8sM4/1

@Salakar That does not match my understanding from reading the code, which is that the code point you linked to will not be reached at all, because the module in question will never be recursed over, since it does not sit directly in a child directory of ./node_modules with a package.json file at ./node_modules/<modulename>/package.json. I will admit to not having debugged the code fully yet to establish this though.
However, I think my approach would be a better one in the long term anyway, since it does not place any dependency on the install location of modules, and so will better support both npm3 environments, or cases where sails apps are loaded as dependencies of other projects (this is actually our current use case, and part of my motivation for this work) and modules may have had their install locations de-deduped up the tree. My feeling generally is that Sails should avoid anywhere traversing/inspecting the ./node_modules directory, and should always consider package.json and require[.resolve] as the canonical source for installed modules and their installed locations.

@Salakar I've tested this at both<EMAIL_ADDRESS>and<EMAIL_ADDRESS>and neither return user-scoped modules with the results from the node_modules directory traversal here

@Salakar @lennym thanks y'all.
@lennym re flattenNamespacedModules -- correct- that's a workaround for when NPM released private packages. We'll get a fix for this working on master first, then bring it back for a 0.11.x patch (@sgress454 do you think you can take point on that?)

@lennym re:

I'd propose swapping some of this code (https://github.com/balderdashy/sails/blob/master/lib/hooks/moduleloader/index.js#L399-L407) for something that instead reads the app's package.json for dependencies, and then uses require.resolve('/package.json') to read their pacakge.json files.

The reason why the hooks loader wasn't implemented this way is that it requires you to always do npm i --save (or manually add packages to your package.json after installing).  If you're just installing a hook just to try it out in your project, you don't want it listed in your package.json where you are likely to forget about it.  Plus, every hook would have to have its installation instructions say npm install <hook name> --save, which is a bit odd.
It sounds to me like @Salakar hit on the real issue here--at least since the flattenNamespaceModules method appeared, there should be no problem with your hook loading, just with the internal name it's being given.  The regex fix sounds correct.  There's also a configuration setting you can put in your package.json (apparently undocumented, but I'll go and fix that): sails.hookName.  If you set a value for the hookName property in the sails dictionary of your hook's package.json (alongside isHook: true), then the loader will use that name internally for the hook.  For instance, if you had:
"sails": {
   "isHook": true,
   "hookName": "sockets"
}

in your package.json, the hook would be loaded into sails.hooks.sockets (replacing the default).

@sgress454 thanks for adding hookName to the docs.  We redeployed sailsjs.org and it just cleared cloudflare here.
@lennym @Salakar We could make the hook identity a required property in the hook spec.  But still, in the mean time, since Sails core is currently handling the inference of hook identity from package names, we should support the latest and greatest from NPM there.

Merged in #3514, and added some more tests including tests for the hookName config and for saving hooks in namespaced folders.  Thanks @lennym and @Salakar for the help!

We've been using private npm modules and hookName with no issues.

@luislobo :+1: thanks for the update!


Callback transformer

Thanks for sharing PHP ETL. I enjoyed the approach to data handling and it helped me migrate between two databases provided by different systems.
The number of transformers is limited and it seems unreasonable to expect the library to provide something that covers every need.
Would you be interested in a transformer which lets the user provide a callback with an anonymous function á la:

<?php

use Marquine\Etl\Row;
use Marquine\Etl\Transformers\Transformer;

class CallbackTransformer extends Transformer
{

  /** @var callable */
  protected $callback;

  protected $availableOptions = [
    'callback'
  ];

  /**
   * Transform the given row.
   *
   * @param \Marquine\Etl\Row $row
   *
   * @return void
   */
  public function transform(Row $row)
  {
    call_user_func($this->callback, $row);
  }
}

I agree ! But I think you can create your own Transformers just by binding it to the container
use Marquine\Etl\Container;
use MyTransformer;

$container = Container::getInstance();
$container->bind('my_transformer', MyTransformer::class);

You can. Based on my brief experience with PHP-ETL most of my transformations are  LOC. I find it a bit excessive to create a class for each.

I've also found this need, and created a Callback Transformer as well (nearly identical code!).  My functions were placed in a single library file for each project, as each was very bespoke to the particular data.

Hi @kasperg if you want, we forked the library here and we fixed some issues and added some features. The changelog is available here. Our objective is to keep this great library alive. If you find any bug or want to contribute to keep the package alive, do not hesitate!

@ecourtial :+1: My current use case for php-etl has passed but you are welcome to lift my suggestion to your fork.


Set CA2008 to "Error" and resolved compiler errors

closes #1431
Set CA2008 to "Error" and resolved compiler errors.
When prompted for a TaskScheduler, set the value to the Default TaskScheduler.

Thank you!


Fix off-by-one at worker round robin init.

Signed-off-by: Jérôme Benoit<EMAIL_ADDRESS>
PR Checklist

[ ] Please add a description of your changes.
[ ] We need your changes to come with unit tests in order to keep this project in quality and easy to maintain.
[ ] Please add a link to the open issue or task that this pull request will resolve.
[ ] Add a note to the changelog to indicate the change.

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If yes please indicate it and migration info into the CHANGELOG.md file.

Have fixed it directly


Expose has_rng as method on Modules.

has_rng has been requested a few times, since it exists on scope objects we should just expose it.

Codecov Report

Merging #1974 (f701be3) into main (5934571) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
+ Coverage   70.90%   70.92%   +0.02%
==========================================
  Files          59       59
  Lines        4983     4987       +4
==========================================
+ Hits         3533     3537       +4
  Misses       1450     1450

Impacted Files
Coverage Δ

flax/linen/module.py
93.43% <100.00%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5934571...f701be3. Read the comment docs.


Move and group SVG.

We would like to be able to group, move, and rotate objects together through an event like a mouse drag and removing single items in that group with a shift+click. Is this possible?

Hi @alextate4, thank you for the comment.
Of course you can do that.
https://anseki.github.io/plain-draggable/#options-left_top

Maybe this will make sense if I am more specific.

When the mouse is clicked and dragged, we would like to create a visual box that represents the area of elements being selected, seen in programs such as Adobe Illustrator, Photoshop, etc. When this visual box touches each element, the will be added to a group that can then be manipulated all together. Do you know how this can be done?

Generally speaking, changing status (flag) of each object is used.
When an object is clicked, change the selected object. When an object is clicked with pressing Ctrl key, add the selected objects.

No reply came, then this abandoned issue is closed.


Parameter to generate report for Test-WindowsBestPractices

Record current state and any changes that were made. This would be useful for change management.

Is this still something that is needed? We now create a log file with the cmdlet output.
If anyone feels ambitious, feel free to create it.

The updated cmdlet has logging so we can close this one.


system metadata and search

It would be nice if there was a way to display information about systems as well as search by at least system name (if not also description)

I was playing around with this today.  The idea is to have some kind of DB  with search terms and metadata (eg. link to upstream project) uploaded as an OCI artifact.  So ocicl would always download and install this somewhere.
The interesting part would be to populate the DB with search terms generated by an LLM that would process the README or whatever else is relevant. I've tried generating search terms for some projects, and it seems to work pretty well.   Need to think about this more, but interested in feedback.


Add QN version of eigen

This adds a QN version of eigen for both Hermitian and non-Hermitian ITensors. It also removes the eigenHermitian(A) function in favor of eigen(A; ishermitian=true), so it is breaking. DMRG using an eigendecomposition instead of an SVD for the orthogonalization is working.
I still need to add a QN Diag sparse tensor type (i.e. using a DiagBlockSparse storage type). Right now the eigenvalues are just returned as a Dense storage with zero off-diagonal values.

Codecov Report

Merging #213 into master will decrease coverage by 0.5%.
The diff coverage is 92.2%.

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   87.76%   87.26%   -0.51%
==========================================
  Files          44       45       +1
  Lines        4169     4294     +125
==========================================
+ Hits         3659     3747      +88
- Misses        510      547      +37

Impacted Files
Coverage Δ

src/Tensors/diag.jl
65.82% <ø> (-1.9%)
:arrow_down:

src/Tensors/Tensors.jl
100% <ø> (ø)
:arrow_up:

src/Tensors/linearalgebra.jl
82.52% <100%> (-7.59%)
:arrow_down:

src/mps/mpo.jl
99.38% <100%> (ø)
:arrow_up:

src/Tensors/dense.jl
77.69% <100%> (-5.4%)
:arrow_down:

src/Tensors/symmetric.jl
100% <100%> (ø)

src/decomp.jl
96.02% <100%> (+2.27%)
:arrow_up:

src/Tensors/blocksparse/blocksparsetensor.jl
88.64% <30.76%> (-1.36%)
:arrow_down:

src/Tensors/tensor.jl
56.6% <50%> (-1.09%)
:arrow_down:

src/Tensors/blocksparse/blocksparse.jl
72.88% <50%> (-1.26%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 654a7f7...e9f197d. Read the comment docs.


Async example?

Can you please share a link to example of async dns query loop of 500 domains for example.
Of course, simply changing Dns\resolve($domain) in /examples/benchmark.php to:
        $host = Amp\Future\awaitFirst([
            Amp\async(fn() => Dns\resolve($domain, Dns\DnsRecord::A)),
        ]);

doesn't make any difference.

Apologies for the (very) late reply, this issue slipped under my radar.
To perform multiple queries simultaneously (or multiple of any operation which will await I/O), use Amp\async() in conjunction with Amp\Future\await() to await the set of futures created from async().
$listOfDomains = [...]; // List of domain names to query.

$futures = [];
foreach ($listOfDomains as $domain) {
    $futures[$domain] = Amp\async(Dns\resolve(...), $domain);
}

$resolvedRecords = Amp\Future\await($futures);

Note it may not be a good idea to initiate 500 DNS requests simultaneously. As with many simultaneous async operations, it may be a good idea to throttle the number of simultaneous requests in-flight. See amphp/sync and amphp/pipeline for tools to do just this.


Support building fonts with Makefiles

Eg https://github.com/santhoshtr/AutonymFont
https://github.com/georgd/EB-Garamond/ is a great test repo for ingesting SFD(ir) font masters and using make in the build process to allow for custom binary building.

Building is now out of scope, so closing.


Fixed race condition in libsodium's build schemes.

I think that same protection should be added to url_sha1_libsodium_autogen_autotools.cmake.in too

Indeed, give me a second.

Testing only Ninja: https://ci.appveyor.com/project/ingenue/hunter/build/1.0.571

Test passed

Test passed

Cool. Let's do full testing now:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.572
https://travis-ci.org/ingenue/hunter/builds/138757343

All tests passed, we're good to go.

Uploading binaries:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.573 (almost all uploaded in fact, run ninja upload)
https://travis-ci.org/ingenue/hunter/builds/138765077 (all uploaded in fact, just check)

Uploading binaries

Done. Released: https://github.com/ruslo/hunter/releases/tag/v0.14.27


TCK: Integrate Husky package

Problem
Occasionally, contributors may unintentionally skip signing their commits, which can lead to significant challenges down the road, especially when managing complex pull requests with contributions from multiple people. If several commits are missing the required sign-off, it can create unnecessary complications during the merge process, ultimately increasing the time and effort needed to resolve the issue.
Solution
A potential solution to this problem is to leverage the Husky npm package. Husky can be configured to enforce signing off on commits and ensure that necessary pre-commit tasks, such as running linters or other validation scripts, are executed before the commit is finalized. This tool helps maintain code quality by automatically running tasks like linting or throwing an error if you try to commit without signing it.

After implementing the Husky package and configuring it in a PR, we consulted with our DevOps team to enable a setting to complete the desired functionality. During this process, we discussed the use of Husky, and the team expressed strong reservations about its use. Based on their feedback, we’ve decided not to merge the PR with Husky. They recommended using the pre-commit tool as a more suitable alternative, which can achieve our goals. We’ve noted this and plan to implement it when we have the opportunity.


Do not pre-select artifact on local GAE run/debug config UI.

Helps on #945

FYI this fix reenables the message on the UI for how to fix the config.

Github is saying I don't have write access to merge this PR

Try now.q
On Wed, Oct 5, 2016 at 12:43 PM, João Martins<EMAIL_ADDRESS>wrote:

Github is saying I don't have write access to merge this PR
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/948#issuecomment-251730137,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHf5HQ1n4AYJpnDEwH1GAVX8Q1ucKjoNks5qw9OugaJpZM4KO4dF
.


feat: Add support for RenderModeAttribute

The current implementation just creates the instance without any side-effects of those new attributes.
I don't see any reason why someone should unit test that anyway.

Closes #1117

Seems like preview.5 has a small hiccup:

/usr/share/dotnet/sdk/8.0.100-preview.5.23303.2/Roslyn/Microsoft.CSharp.Core.targets(80,5): error MSB6006: "csc.dll" exited with code 139. [/home/runner/work/bUnit/bUnit/tests/bunit.testassets/bunit.testassets.csproj]

Looks good to me. And yeah, that compile is also present in the older pr. think it's safe to me anyway.

I would wait until your PR (#1111) is done (because otherwise your build is failing) - merge the latest v2 and ping you again so you can merge the PR. Unfortunately, due to the failing ubuntu test, I can not merge the PR to v2 as one check is not successful.

I rebased v2 - feel free to merge as ubunut-latest will fail.

I rebased v2 - feel free to merge as ubunut-latest will fail.

Not sure I follow. Do you want me to merge the PR?

In short yes, because I can’t due to the failing test.


No way to call this from background

Hi, is there any plans to make this library callable from background with only application context? providing an Activity is not always available when it comes to GPS features.

I think that this is unlikely. Because the activity context is required to request permissions. how to request from the background?

And how about using a location-based widget? How to manage that?


Account details full screen mode

Account detail full screen mode

Summary by CodeRabbit

New Features

Introduced NewAddress, AssetIcon, DisplayLogo, and FullScreenIcon components for enhanced UI experience.
New account details full-screen view with comprehensive information including balances, assets, and staking options.
Added ChangeAssets, AccountInformation, AccountSetting, ExternalLinks, LockedBalanceDisplay, TotalChart, Confirmation, Review, and various modal components to improve user interaction and account management.
Implemented DeriveAccountModal, SelectParent, ExportAccountModal, ForgetAccountModal, HistoryDetailModal, HistoryItemModal, HistoryModal, ReceiveModal, and RenameModal for account operations.
Added functionality to retrieve asset balances on various blockchain networks.

Enhancements

Upgraded UI components like Select2, CommonTasks, and DisplayBalance for better usability.
Simplified FullScreenChainSwitch logic for improved performance.
Updated HeaderBrand for better navigation and branding consistency.
Enhanced governance components to include new page type and improved selection logic.
Expanded icon library with new asset icons.

Bug Fixes

Addressed dropdown selection delay with setTimeout in AddressDropdown components.
Fixed navigation issues by replacing useHistory with useContext and useIsExtensionPopup.

Refactor

Modified Popup component routing to incorporate new features and improve navigation flow.

Chores

Updated copyright year in multiple files.

changes as the fullscreen branch


upstream connect error or disconnect/reset before headers. reset reason: connection termination

Hi , i am new to istio , i have ran into this bug
"upstream connect error or disconnect/reset before headers. reset reason: connection termination"
let' say my website is running on mydomain.com
in my website i have routed traffic on static ip  let's say <IP_ADDRESS>
port 80 is being forward to 32285
and port 40 is being forward to 31970
when i visit my website http://www.mydomain.com it displays proper web page
but when i visit my website https://www.mydomain.com it displays above mentioned error.
if i m logged into ssh using root and run following command
curl -v -HHost:mydomain.com http://<IP_ADDRESS>:32285/
it outputs

Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 32285 (#0)

GET / HTTP/1.1
Host:mydomain.com
User-Agent: curl/7.47.0
Accept: /

< HTTP/1.1 200 OK
< server: istio-envoy
< content-type: text/html; charset=UTF-8
< x-powered-by: PHP/7.3.14
< cache-control: no-cache, private
< and so o
and displays rest of the web page which is good so far
and when i run following command
curl -HHost:mydomain.com --resolvemydomain.com:31970:<IP_ADDRESS> -k https://mydomain.com:31970/
it also displays the web page which makes me assumes that my certificates are properly installed
problem only occurs when i m using domain name in browser.
here is my gateway and virtual service for ingress gateway
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
name: nginx-gateway
namespace: myapp
spec:
selector:
istio: ingressgateway # use istio default controller
servers:

port:
number: 443
name: https-web
protocol: HTTPS
tls:
mode: SIMPLE
serverCertificate: /etc/istio/ingressgateway-certs/tls.crt
privateKey: /etc/istio/ingressgateway-certs/tls.key
hosts:

"mydomain.com"

port:
number: 80
name: http-web
protocol: HTTP
hosts:

"mydomain.com"

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
name: nginx
namespace: myapp
spec:
hosts:

"mydomain.com"
gateways:
nginx-gateway
http:
route:

destination:
host: nginx
port:
number: 80

any help would be appreciated.
thanks

@shahid-mushtaq I do not understand the when the failure actually occurs, can you be more explicit about what succeeds and what fails, and capture access logs (https://github.com/istio/istio/wiki/Troubleshooting-Istio)? I am confused by your Gateway being on 443 but requesting on a different port

Without more info we are unable to troubleshoot this further. If you still experience this issue, please reopen with the requested information. Thanks again!


Change default simulation method to parsimonious fba

I think you just have to change also the tests.

Thanks, I'm not sure I agree the test should hardcode these expected values, but it's updated now anyway.


Fix a few unrelated frontend issues

Fixes #1061
Clicking play on iPad reveals this anchor shape.

On the branch, this section is rewritten so the anchor can be styled as a block, and inherit the shape of its contents:

Fixes #1059
On iOS, maybe due to some specific font nuance, this caret was jumping down to the next line. I rewrote the double space before the caret more explicitly with   to fix it.

Fixes #1058
This was brought up by childhoodsend, but also very noticeable using AT on portrait iPad, 768px wide, as well as an iPhone with a 320px wide view.

The current solution on the branch was to add an alternate text for those 2 width ranges, Narrow 2 column view, and small mobile phone. But maybe there's a better fix?

This brings up perhaps that the Percy mobile view should be smaller, as this text change made it through Percy?
Fixes #1053
This is illustrated in the Issues, with alter ego as the example. The branch code moves where that css margin style is, so a track view without comments doesn't collapse:

The other change is to slightly update the Toggle drag sliders on Edit playlist, so they aren't transparent and very broken on dark theme. Also, the original design from Figma seemed to have been lost somewhere along the way, with an extra element. Some other UI elements, X and +I don't think have dark theme designs in Sigma, so right now, I kept the toggles universal, same for white and dark.
Current:

Branch:

Does anything special need to happen for deployment?
No.
"Ready For Review" checklist
These checklists are to help ensure the code review basics are covered. Consider removing to reduce noise.

[ ] PR title accurately summarizes changes
[ ] New tests were added for isolated methods or new endpoints
[ ] I opened an issue for any logical followups
[ ] If this fixes a bug, "Fixes #XXX" is either the very first or very last line of the description.

Before code review and after additional commits during review.

[ ] Update title and description to account for additional changes
[ ] All tests green
[ ] Migrations were tested locally and do the right thing
[ ] Booted up the branch locally, exercised any new code
[ ] Percy changes are purposeful or explained
[ ] Css changes are happy on mobile (via Percy is ok)

Thanks for the visual description of changes — quite useful!!


[EventRequest] codeunit 134 "Import Attachment - Inc. Doc." - OnFindUsingDocNoFilterOnBeforeFind

Please add new integration event and call as follows:
    local procedure FindUsingDocNoFilter(var IncomingDocumentAttachment: Record "Incoming Document Attachment"; var IncomingDocument: Record "Incoming Document"; var PostingDate: Date; var DocNo: Code[20]): Boolean
    var
        FilterGroupID: Integer;
    begin
        for FilterGroupID := 0 to 2 do begin
            IncomingDocumentAttachment.FilterGroup(FilterGroupID * 2);
            if (IncomingDocumentAttachment.GetFilter("Document No.") <> '') and
               (IncomingDocumentAttachment.GetFilter("Posting Date") <> '')
            then begin
                DocNo := IncomingDocumentAttachment.GetRangeMin("Document No.");
                PostingDate := IncomingDocumentAttachment.GetRangeMin("Posting Date");
                if DocNo <> '' then
                    break;
            end;
        end;
        IncomingDocumentAttachment.FilterGroup(0);

        if (DocNo = '') or (PostingDate = 0D) then
            exit(false);

        IncomingDocument.SetRange("Document No.", DocNo);
        IncomingDocument.SetRange("Posting Date", PostingDate);

        // ---- New code start ----
        OnFindUsingDocNoFilterOnBeforeFind(IncomingDocumentAttachment, IncomingDocument, PostingDate, DocNo);
        // ---- New code end ----

        exit(IncomingDocument.FindFirst);
    end;

    // ---- New code start ----
    [IntegrationEvent(false, false)]
    local procedure OnFindUsingDocNoFilterOnBeforeFind(var IncomingDocumentAttachment: Record "Incoming Document Attachment"; var IncomingDocument: Record "Incoming Document"; PostingDate: Date; DocNo: Code[20])
    begin
    end;
    // ---- New code end ----

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10748.


Issue with npm run dev

Being a beginner in web pack, I'm confused with this error. Please let me know if this is an issue with the required version or something else. Thanks!
<EMAIL_ADDRESS>dev /Users/abenezerayana/Downloads/Netflix-Clone-master-2

webpack-dev-server --mode development --config webpack.config.js --open

internal/modules/cjs/loader.js:968
throw err;
^
Error: Cannot find module 'webpack/bin/config-yargs'

You can try to run the app with latest updates, which includes the latest Webpack (5) features


fix toc

Review URL
fixes #34167

Internal previews

📄 File
🔗 Preview link

aspnetcore/toc.yml
aspnetcore/toc

Well, it's in the wrong place in the toc.yml file but it's rendered in the right place and I don't know why

Not only that, it's not taking the name I specified
          - name: Configure OpenID Connect
            uid: security/authentication/configure-oidc-web-authentication

It's using Configure OIDC web authentication
that string is nowhere to be found in the doc or the toc.yml

It almost has to be a cache issue, but I've tried many hard refreshes, and nothing changes.

It almost has to be a cache issue, but I've tried many hard refreshes, and nothing changes.

Cached on the server not the client. I've tried different browsers. Look at the https://github.com/dotnet/AspNetCore.Docs/pull/34171/files and compare to the TOC
I'm going to clean up the toc.yml, merge, and see what happens.

The file and the rendered page are now in sync -- but both are in the wrong place. 😄


Add diagram of the CCX in the readme

Hello,
I have started working on the Muntjac SoC and to help me better understand the code architecture I have made a diagram of the core complex.
I think that it could be useful for others newcomers. If needed, I can amend the diagram.
Best

It should be okay now !

Thank you!


Initial ProjectGraph interfaces/stubs

Add initial interfaces/stubs to code against for ProjectGraph.
From the design, something similar to:
	namespace Microsoft.Build.Graph
	{
	    public class ProjectGraph
	    {
	        // Creates a graph starting at the given project file.
	        public ProjectGraph(string projectFile) { }

	        // Creates a graph starting at the given project files, for example all projects in a solution.
	        public ProjectGraph(IEnumerable<string> projectFiles) { }

	        // All project nodes in the graph.
	        IReadOnlyCollection<ProjectGraphNode> ProjectNodes { get; }
	    }

	    public class ProjectGraphNode
	    {
	        // No public creation.
	        internal ProjectGraphNode() { }

	        // Projects which this project references.
	        IReadOnlyCollection<ProjectGraphNode> ReferencedProjects { get; }

	        // Projects which reference this project.
	        IReadOnlyCollection<ProjectGraphNode> ReferencingProjects { get; }

	        // The evaluated project
	        Project Project { get; }
	    }
}

curious: What's the goal (/ scenarios) of the project graph effort?

@dasMulli Apologies, I've just post the motivation and design here: #3696


How does this differ from jekyll-commonmark?

(Similar question posted at https://github.com/jekyll/jekyll-commonmark/issues/39)
I notice that while the readme for jekyll-commonmark talks about using libcmark, it actually appears to achieve this via the commonmarker gem.
Looking at commonmarker, it talks about being a ruby wrapper for libcmark-gfm, which apparently includes all of the GFM extensions already:

Ruby wrapper for libcmark-gfm, GitHub's fork of the reference parser for CommonMark. It passes all of the C tests, and is therefore spec-complete. It also includes extensions to the CommonMark spec as documented in the GitHub Flavored Markdown spec, such as support for tables, strikethroughs, and autolinking.

This would make me think that jekyll-commonmark by itself already supports GFM, and so i'm wondering what  jekyll-commonmark-ghpages provides above/beyond that, particularly as this project also uses the same commonmarker gem.
--
Adding jekyll-commonmark to my Gemfile resulted in the following in my Gemfile.lock:
jekyll-commonmark (1.3.1)
      commonmarker (~> 0.14)
      jekyll (>= 3.7, < 5.0)

commonmarker (0.21.0)
      ruby-enum (~> 0.5)

Resetting, then adding jekyll-commonmark-ghpages to my Gemfile resulted in the following in my Gemfile.lock:
jekyll-commonmark-ghpages (0.1.6)
      commonmarker (~> 0.17.6)
      jekyll-commonmark (~> 1.2)
      rouge (>= 2.0, < 4.0)

jekyll-commonmark (1.3.1)
      commonmarker (~> 0.14)
      jekyll (>= 3.7, < 5.0)

commonmarker (0.17.13)
      ruby-enum (~> 0.5)

So jekyll-commonmark-ghpages gives us an additional version dependency on rouge, but we already get that via jekyll anyway:
jekyll (4.1.1)
      ..snip..
      rouge (~> 3.0)

By the looks of this, by using jekyll-commonmark instead of jekyll-commonmark-ghpages I would actually be getting a more up to date version of commonmarker (and thus the underlying c implementation), that supports GFM. Which to me, at face value, is definitely not what I would have expected.
I can see that there is a semi-related issue / PR (https://github.com/github/jekyll-commonmark-ghpages/issues/13 , https://github.com/github/jekyll-commonmark-ghpages/pull/15) talking about loosening the version lock on the commonmarker dependency, which would allow it to get the same newer version as jekyll-commonmark currently is able to. I also noticed https://github.com/github/jekyll-commonmark-ghpages/issues/11 that talks about documenting the fact that commonmarker is used under the hood, rather than a direct dependency on libcmark-gfm as this project's readme implies.

I also noticed https://github.com/github/pages-gem/issues/699 which states that the pages-gem (which claims to version gem dependencies used by ghpages; updated in 2020, so seems active) appears to be using the default Kramdown parser, instead of this project, which casts further doubt in my mind as to what the 'correct' choice is.

For anyone else wondering, @pathawks provided an answer at https://github.com/jekyll/jekyll-commonmark/issues/39#issuecomment-662161067, quoted here:

It is my understanding that the commonmarker Gem that we require is merely an FFI wrapper around libcmark. If that is no longer the case, we can certainly update this project or at least update the Readme.
To answer your broader question: if I remember correctly, we both started at around the same time. My intent when starting this project was (primarily) to utilize the fastest Markdown processor available in Ruby and (secondarily) conform to the then emerging CommonMark spec. I imagine the GitHub Pages team is more focused on building a processor that behaves similar to the GitHub Flavored Markdown processor used on the site. The fact that we are both using the same tech under the hood is kind of an implementation detail. 🤷🏼♂


Create links also for documented behaviors.

Connects to vaadin/components-team-tasks#34

LGTM, we should wait until we merge vaadin-grid#behaviors though


add regression-v1x10.sh

We are going into direction of a single script https://github.com/Dasharo/open-source-firmware-validation/pull/208#discussion_r1512203665


No custom_sqlite3 bundle?

Looks like there are only bundles for green, e_sqlite3, and sqlcipher in gen_build.cs. Can one be added for the custom_sqlite3 provider?

Maaaaaybe.
But what would this bundle DO?
I mean, it could bring in the custom_sqlite3 provider for every platform.  And it could provide the Batteries.Init() function to do initialization.
But the other bundles bring in the native SQLite library.  In fact, this is most of the value of these bundles.
bundle_custom_sqlite3 couldn't do that.  So it would only work when somebody also provides the proper custom_sqlite3 build.  On each platform.  And properly configured to end up in the output directory in such a way that the custom_sqlite3 provider can find it.  On each platform.
That native lib stuff is most of the effort of a bundle, so bundle_custom_sqlite3 hasn't saved anybody much time.
(I should write up some docs on how to use the custom_sqlite3 provider.)
A package named bundle_custom_sqlite3 would overpromise and underdeliver, disappointing almost everyone.  So that's why I haven't created it.
Does this make sense?
Feel free to tell me more about what your situation and you had in mind when you asked the question.  Making this bundle might still be a good idea.

I am considering forking https://github.com/praeclarum/sqlite-net which references the green bundle. If my fork can reference this proposed "custom" bundle I figured I just had to provide the custom library in the final output directory or include it somewhere along the line of packages.
If my fork can just as easily reference core and then call
SQLitePCL.raw.SetProvider(new SQLitePCL.SQLite3Provider_custom_sqlite3());

Rather than
SQLitePCL.Batteries.Init();

Great! But since the readme was a bit scarce on custom usage I felt that the bundle approach would be safer.

Yeah, the raw.SetProvider() call is the preferred approach for your situation.
And, just because I'm curious:
What platform(s) are you going to be targeting?
How will your custom SQLite3 build be different?

Alrighty will do.
Windows and iOS. Version of sqlite has some proprietary extensions under the hood.
Thanks for the quick help!

Actually, I have another question. Will this provider work on iOS and other PCL targets?
I see it lists .net 3.5 but I thought all it needed was the pinvoke names set to custom_sqlite3 which should work on a PCL, right? I am not quite familiar enough with PCL to know if it will work with a 3.5 dependency.

For your purposes, no, a portable version won't work.
iOS is a very special case, because Xamarin is different, and because iOS does not support dynamic linking.  Or rather, it didn't until iOS 8.  And I'm not sure the Xamarin toolchain supports it.
Anyway, for iOS you need to use SQLitePCLRaw.provider.internal.ios_unified, and your custom SQLite3 build needs to be a static library in an embedded resource compiled by Xamarin into an assembly with a LinkWith attribute and also some kind of pointless function you can call just to prevent the Xamarin linker from discarding the assembly.  (Sometimes I love a good run-on sentence.)
The best way to see how this works is to:

csc gen_build.cs
./gen_build.exe
cd bld
cd SQLitePCLRaw.lib.e_sqlite3.ios_unified.static

and look at the csproj to see how all this is done.

Xamarin does support dylibs. Shouldn't it work as long as I can keep the architecture in sync with the native lib that is deployed?

(Oh cool.  Dylibs.  I'll need to explore that...)
Er, no.  For iOS, even with dynamic loading, [I assume] the pinvokes still need special attributes to marshal the callbacks.
Actually, I suppose for a limited set of SQLite API calls with no callbacks used, what you're describing would work.  But the breadth of stuff supported by SQLitePCL.raw means that iOS providers generally need to be compiled specially for iOS.
So, if you wanted to use dylibs with iOS, I would need to build provider.custom_sqlite3.ios_unified.  This line of gen_build.cs is currently commented out because it would only make sense with dylibs.  But obviously I haven't done any testing with this approach.
Bottom line:  I'm still pretty sure the pinvokes cannot be portable, at least not when iOS is in play.

Okay thanks for your help. From my understanding any callbacks need to be marked with MonoPInvokeCallbackAttribute and have to be static due to the ahead of time compilation for iOS.
I don't currently have to get iOS working because windows is the higher priority so when that time comes I may have to revisit this issue. You may get a pull request from me if you haven't already addressed it.

"Haven't already addressed it"
What does "it" refer to?
If you mean those iOS pinvoke callback attributes, I do already have all that stuff in place. I was just explaining why the pinvokes cannot be portable.


[Bug] Chat messages are not sent to chat channel after installing Factions Mod

I was doing a server restart a few days ago, and after restarting, the MCDC has stopped sending in-game chat messages to Discord. However, it still sends messages like "Server Started" and " joined the game/left the game". The logs channel, however, properly receives chat messages. This is shown in the below two images:

The mods I have installed are:
anti-xray 1.1.0, blast 1.8.1, Dynmap 3.3.2, entity-view-distance 1.0.0, factions (my fork, at this link: https://github.com/LFC6times/factions), FatExperienceOrbs 1.0.1, FerriteCore 3.1.0, Hydrogen 0.3, LazyDFU 0.1.2, Lithium 0.7.5, MCDC 1.12.1, recipecache 0.2.1, Starlight 1.0.0, and SimpleVoiceChat 2.2.24
Fabric Loader is 0.13.3, and Fabric API is 0.45.0
I have tested without Hydrogen, and without the factions mod. This mod has worked with my factions fork and I believe the factions mod is the only mod with mixins into the chat. My config file is the default except ./msg is an excluded command, and a changed MSPT limit.

You upgrade your MCDC version when you restarted the server this time?

I did not change the MCDC version

I tested in my test server and found no problem. Below is my server environment:

Minecraft 1.17.1 with Fabric Loader 0.13.3
Installed mods:

fabric 0.46.1+1.17
carpet 1.4.57
lithium 0.7.5
mcdiscordchat 1.17-1.12.1
phosphor 0.8.0

Also, to simulate your configuration, I added /msg to excludedCommands, but still no problem.
Did you find any errors or exceptions in the console?
My mcdiscordchat.json:
{
  "generic": {
    "switchLanguageFromChinToEng": false,
    "botToken": "hidden",
    "botListeningStatus": "",
    "webhookURL": "hidden",
    "channelId": "hidden",
    "consoleLogChannelId": "hidden",
    "worldName": "world",
    "avatarAPI": "https://visage.surgeplay.com/bust/%player%.png",
    "modifyChatMessages": true,
    "broadcastCommandExecution": true,
    "multiServer": true,
    "useUUIDInsteadNickname": true,
    "membersIntents": true,
    "announcePlayers": true,
    "announceAdvancements": true,
    "announceDeaths": true,
    "announceHighMSPT": true,
    "msptLimit": 50,
    "removeVanillaFormattingFromDiscord": false,
    "removeLineBreakFromDiscord": false,
    "botCommandPrefix": "!",
    "excludedCommands": [
      "/tell",
      "/msg"
    ],
    "superAdminsIds": [],
    "adminsIds": [
      "hidden",
      "hidden"
    ],
    "bannedDiscord": [],
    "bannedMinecraft": []
  },
  "multiServer": {
    "serverDisplayName": "TEST",
    "botName": "MCDC Bot"
  },
  "textsZH": {
    "serverStarted": "**[TEST] 已启动！**",
    "serverStopped": "**[TEST] 已关闭！**",
    "joinServer": "**%playername% 加入了 [TEST]**",
    "leftServer": "**%playername% 离开了 [TEST]**",
    "deathMessage": "**%deathmessage%**",
    "advancementTask": "**%playername% 达成了进度 [%advancement%]**",
    "advancementChallenge": "**%playername% 完成了挑战 [%advancement%]**",
    "advancementGoal": "**%playername% 达成了目标 [%advancement%]**",
    "highMSPT": "**%mentionAllAdmins% 服务器 MSPT (%mspt%) 高于 %msptLimit%！**",
    "consoleLogMessage": "**[%timestamp%] [INFO]:** %message%",
    "blueColoredText": "[%servername%] ",
    "roleColoredText": "<%name%>",
    "colorlessText": " %message%"
  },
  "textsEN": {
    "serverStarted": "**Server started!**",
    "serverStopped": "**Server stopped!**",
    "joinServer": "**%playername% joined the game**",
    "leftServer": "**%playername% left the game**",
    "deathMessage": "**%deathmessage%**",
    "advancementTask": "**%playername% has made the advancement [%advancement%]**",
    "advancementChallenge": "**%playername% has completed the challenge [%advancement%]**",
    "advancementGoal": "**%playername% has reached the goal [%advancement%]**",
    "highMSPT": "**%mentionAllAdmins% Server MSPT (%mspt%) is above %msptLimit%!**",
    "consoleLogMessage": "**[%timestamp%] [INFO]:** %message%",
    "blueColoredText": "[%servername%] ",
    "roleColoredText": "<%name%>",
    "colorlessText": " %message%"
  }
}

There are no errors or warns in the console.

Also, messages sent on discord appear in the in-game chat. Do I need to allow another port through the firewall?

Also, messages sent on discord appear in the in-game chat. Do I need to allow another port through the firewall?

I think this just means JDA (Java Discord API) is working.
Please try to use my config (remember to backup your own) and leave only fabric 0.46.1+1.17 and mcdiscordchat 1.17-1.12.1 and see if the same problem still occurs.

Please provide more information. If you have resolved the problem on your own, please let me know too. Thx.

Please provide more information. If you have resolved the problem on your own, please let me know too. Thx.
If there is still no new activity after 7 days, the issue will be marked invalid and closed.

I believe the factions mod is the only mod with mixins into the chat.

The factions mod @Redirect the method handleMessage in ServerPlayNetworkHandler to another place:
@Redirect(method = "handleMessage", at = @At(value = "INVOKE", target = "..."))
private void replaceChatMessage(PlayerManager playerManager, Text serverMessage, Function<ServerPlayerEntity, Text> playerMessageFactory, MessageType playerMessageType, UUID sender, TextStream.Message message) {
     ChatEvents.handleMessage(player, message.getRaw());
}

The method of MCDC to obtain chat messages sent by players in the server is to @Inject the same method, so MCDC no longer works.

You'll need to modify the Faction Mod yourself to fix this.

Hello, sorry for the very delayed responses.  I've also tried re-inviting the bot to the server, but to no avail. I still receive the same "Server started!" and "Server stopped!" messages, and the logs channel still works.

I'm on JAVA 17.0.1, and I've run system updates, neither of which have resolved the issues

It's ok. 👌👍
Since you are running the server on a Linux machine, I think you issue might be related to two previous MCDC issues that were resolved by updating Java to 17.0.2. Maybe try updating to Java 17.0.2 first?

That worked perfectly, thank you so much!

Ok! 👌


Deploy to prod

Description
Deploy charterafrica to Prod
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Screenshots
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Need to bump apps/charterafrica/contrib/dokku/Dockerfile as well @koechkevin (same exact version).

Also it's better to include version bump in the commit comment as well @koechkevin (Use git log | grep Bump to see previous bumps).


Readme instructions for using without composer still requires composer

I downloaded this:  https://sendgrid-open-source.s3.amazonaws.com/sendgrid-php/versions/sendgrid-php-39c3745.zip
sendgrid-php.php requires vendor/autoload.php which requires composer.

@nquinlan  thanks for providing the correct link, I was able to download the the php helper library from there, however, when implementing, I get the error: Fatal error: require_once(): Failed opening required '.../sendgrid-php/vendor/composer/autoload_real.php'; which in fact, there is no composer directory under the vendor folder.
Is there zip that provides this vendor? The v2 library I currently have DOES come with composer, but I really would like to upgrade to v3.
Thank you,
Paola G.

Please how do I use send grid without composer, the package I downloaded still requires autoload

@KingsleyOgu @paoga87 Hope this helps.
Unzip the SDK download file in the same directory as your PHP code. And then in your code require the loader file bundled with the SDK:
// Require the bundled autoload file - the path may need to change
// based on where you downloaded and unzipped the SDK
require __DIR__ . '/sendgrid-php/lib/loader.php';

The solutions above no longer seem to work as the latest version (7.9.1) doesn't contain a /vendor directory or /lib/loader.php. Following README with require("./sendgrid-php.php"); also produces composer error.


chore: simplyfy formatting for byte slice representing eth types

Checklist

[x] I have read the coding guide
[x] My change requires a documentation update and I have done it
[x] I have added tests to cover my changes.
[x] I have filled out the description and linked the related issues

Description
Hash and Address types already implement Stringer interface so manual bytes slice formatting is not needed.
Part of https://github.com/ethersphere/bee/issues/3157

This change is

Thanks for the PR. Can you make all the changes related to the #3157 in one PR (maybe move this changes to #3216), so if we decide to revert all changes, it will be in one go.

Usually it's better to have smaller PRs because they are easier to review and maintain. Even for reverting code this way can give you finer granularity.

Usually it's better to have smaller PRs because they are easier to review and maintain. Even for reverting code this way can give you finer granularity.

For the purpose of review, we usually do separate commits instead of doing it in separate PRs, that way the commits can also be reviewed separately.

Anyway, closing this PR in favor or #3216


cannot load active support error

Bug
What I did
I generated a new bridgetown site, committed it, then ran:
bridgetown apply "https://github.com/ParamagicDev/bridgetown-automation-tailwindcss"

Expectation
I would expect this command to run, without error, and add the files needed for using Tailwind in a Bridgetown site.
What actually happened
➜ bridgetown apply "https://github.com/ParamagicDev/bridgetown-automation-tailwindcss"
Traceback (most recent call last):
        10: from /Users/andrew.mason/.rbenv/versions/2.7.1/bin/bridgetown:23:in `<main>'
         9: from /Users/andrew.mason/.rbenv/versions/2.7.1/bin/bridgetown:23:in `load'
         8: from /Users/andrew.mason/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bridgetown-core-0.16.0/bin/bridgetown:21:in `<top (required)>'
         7: from /Users/andrew.mason/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bridgetown-core-0.16.0/bin/bridgetown:21:in `require'
         6: from /Users/andrew.mason/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bridgetown-core-0.16.0/lib/bridgetown-core/commands/base.rb:3:in `<top (required)>'
         5: from /Users/andrew.mason/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bridgetown-core-0.16.0/lib/bridgetown-core.rb:12:in `require_all'
         4: from /Users/andrew.mason/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bridgetown-core-0.16.0/lib/bridgetown-core.rb:12:in `each'
         3: from /Users/andrew.mason/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bridgetown-core-0.16.0/lib/bridgetown-core.rb:13:in `block in require_all'
         2: from /Users/andrew.mason/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bridgetown-core-0.16.0/lib/bridgetown-core.rb:13:in `require'
         1: from /Users/andrew.mason/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bridgetown-core-0.16.0/lib/bridgetown-core/commands/concerns/actions.rb:4:in `<top (required)>'
/Users/andrew.mason/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bridgetown-core-0.16.0/lib/bridgetown-core/commands/concerns/actions.rb:4:in `require': cannot load such file -- active_support/core_ext/array/extract_options (LoadError)

Workaround
I don't really think its an issue with this repo, though I could be wrong. I was able to get it to run by prepending the command with bundle exec. I made sure my gem was updated and even uninstalled the gem completely but got the same error after reinstalling it.
Proposed solution
Maybe it's worth a quick look but I believe this is an issue with Bridgetown, however, I haven't gotten the error before and I am using the bridgetown CLI. I think a good solution for now is modifying the readme to recommend prepending the command with bundle exec.
What do you think? Thanks!

This is a known issue with Bridgetown / ActiveSupport. ActiveSupport is loaded by the Bridgetown CLI...I may do some more digging to see if there's a way to fix the require calls to ActiveSupport.
ActiveSupport also breaks a lot of naming conventions and requires Bundler to make it work properly.
IE: the gem itself is gem install activesupport but when you require it becomes require "active_support"

I think this can be closed then.
If it's that big of an issue, it may be worth assessing how many methods from AS have leaked into the code and then assess the cost of removal. If it's everywhere then it's probably too much work. But, I typically find when AS is added to a codebase, it starts with one specific class or method. Usually dates.
AS is just ruby, if it's only a few select methods just patch them into the Bridgetown. If it's bigger but centered on something like just dates, there's plenty of other date gems for ruby and this is true regardless of what it is.
This comment is also for me if I get a chance to look.

@andrewmcodes if I remember front last time I looked, it's not even used.
https://github.com/bridgetownrb/bridgetown/blob/main/bridgetown-core/lib/bridgetown-core/commands/concerns/actions.rb


chore(GH-24): make binary builds really static

fixes https://github.com/ivanilves/travelgrunt/issues/24


Fix execution summary for optional parameters

Description
If an optional parameter has its own next_in_enumeration method, generating a summary ends in an error if the same task has been run both with a value of None and with a proper value for the parameter.
Motivation and Context
import luigi

class A(luigi.ExternalTask):
    def output(self):
        return luigi.LocalTarget("a.txt")

class RecB(luigi.Task):
    step = luigi.OptionalIntParameter(default=None)

    def requires(self):
        step = 3 if self.step is None else self.step
        if step == 0:
            yield self.clone(A)
        else:
            yield self.clone(step=step-1)

    def run(self):
        with self.output().open("w") as f:
            f.write("1")

    def output(self):
        return luigi.LocalTarget(f"b_{self.step}.txt")

luigi.build([RecB()])

Traceback (most recent call last):
  File "/home/astachlewski/tmp/luigi_bug_recursive_graph/bug.py", line 28, in <module>
    luigi.build([RecB()])
  File "/home/astachlewski/tmp/luigi_bug_recursive_graph/venv/lib/python3.10/site-packages/luigi/interface.py", line 243, in build
    luigi_run_result = _schedule_and_run(tasks, worker_scheduler_factory, override_defaults=env_params)
  File "/home/astachlewski/tmp/luigi_bug_recursive_graph/venv/lib/python3.10/site-packages/luigi/interface.py", line 178, in _schedule_and_run
    luigi_run_result = LuigiRunResult(worker, success)
  File "/home/astachlewski/tmp/luigi_bug_recursive_graph/venv/lib/python3.10/site-packages/luigi/execution_summary.py", line 79, in __init__
    self.summary_text = _summary_wrap(_summary_format(summary_dict, worker))
  File "/home/astachlewski/tmp/luigi_bug_recursive_graph/venv/lib/python3.10/site-packages/luigi/execution_summary.py", line 414, in _summary_format
    str_output += '{0}\n'.format(_get_str(group_tasks[status], status in _PENDING_SUB_STATUSES))
  File "/home/astachlewski/tmp/luigi_bug_recursive_graph/venv/lib/python3.10/site-packages/luigi/execution_summary.py", line 196, in _get_str
    first, last = _ranging_attributes(attributes, param_class)
  File "/home/astachlewski/tmp/luigi_bug_recursive_graph/venv/lib/python3.10/site-packages/luigi/execution_summary.py", line 261, in _ranging_attributes
    next_attributes = {param_class.next_in_enumeration(attribute) for attribute in attributes}
  File "/home/astachlewski/tmp/luigi_bug_recursive_graph/venv/lib/python3.10/site-packages/luigi/execution_summary.py", line 261, in <setcomp>
    next_attributes = {param_class.next_in_enumeration(attribute) for attribute in attributes}
  File "/home/astachlewski/tmp/luigi_bug_recursive_graph/venv/lib/python3.10/site-packages/luigi/parameter.py", line 686, in next_in_enumeration
    return value + 1
TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'

Have you tested this? If so, how?
Automated tests as well as running the above code.

I've also fixed some broken test for jsonschema (as order of validation is changed in newest version).


ARIA needed for components supporting multi selection.

Issue Description
The Button Group (and MultiSelectList and Table.MultiSelectableRows) supports multi selection.
These components should have an ARIA (e.g. aria-multiselectable) to indicate whether it is single or multi select.
Issue Type

[ ] New Feature
[ ] Enhancement
[ ] Bug
[X] Other

Maybe we could document this so consumers are aware if they are making the button group multi-selectable, they'll need to add this attribute.


Side Menu Toggle

Add a toggle option for the side menu bar.

Waiting to taste this change

I had to put a little button to do that in my project (www.practico.org)
So if you wan to show/hide the sidebar only need to press that button and then Div sizes are changed.
You can see that in this file:  https://github.com/unix4you2/practico/blob/master/core/marco_arriba.php near to the line 126
Regards

+1...
waiting anxious for this improvement

+1 looking forward to this enhancement

+1 I'd love to see this enhancement. Infact I created a github account just to post this. sb-admin2 is awesome. Many thanks!

+1 very interested in this
thanks

+1

+1 Looking forward to it!

+1

Can we use this until the enhancement completed?
https://github.com/kongbab04/sb-admin2-sidebar-toggle-collapse

I tried that link above but unfortunately I couldn't get it to work. I'd be interested to know if anyone manages to get
It working

I'm also looking forward to the toggle option for the sidebar, how would i know when it's ready?
Congrats....

Here it is! Please find the demo application for the SB Admin 2 sidebar toggle. Enjoy!
https://github.com/pramod-rathod-avalara/startbootstrap-sb-admin-2-sidebar-toggle

Hi Iron!
Thanks for you quick response!
I'm having problems, i've just downloaded these files and replaced the
files into the root template folder, but it's not working... How should i
do?
Thanks buddy, and congrats!!
2015-06-26 9:46 GMT-03:00 pramod.rathod<EMAIL_ADDRESS>
Here it is! Please find the demo application for the SB Admin 2 sidebar
toggle. Enjoy!
https://github.com/pramod-rathod-avalara/startbootstrap-sb-admin-2-sidebar-toggle
—
Reply to this email directly or view it on GitHub
https://github.com/IronSummitMedia/startbootstrap-sb-admin-2/issues/3#issuecomment-115667845
.

Hi Juniornativa ,
If you are replacing the files into the 'StartBootstrap SB Admin 2' template folder. Things will not work as is. You will need to correct the paths to CSS and JS files into the index.html. The index.html in the downloaded project by default points to './assets/bower/' and './assets/css' folder.
Instead just include the ./assets/css/sbadmin2-sidebar-toggle.css  into your template project and update the index.html to as per. The things to look for are inside index.html are contents inside  and .
I hope this helps!

Oh okay my friend, i'll try that way!!
Thanks for your big help, i appreciate your job!!
Take care of yourself!! Bye
2015-06-26 15:28 GMT-03:00 pramod.rathod<EMAIL_ADDRESS>
Hi Juniornativa ,
If you are replacing the files into the 'StartBootstrap SB Admin 2'
template folder. Things will not work as is. You will need to correct the
paths to CSS and JS files into the index.html. The index.html in the
downloaded project by default points to './assets/bower/' and
'./assets/css' folder.
Instead just include the ./assets/css/sbadmin2-sidebar-toggle.css into
your template project and update the index.html to as per. The things to
look for are inside index.html are contents inside
and .
I hope this helps!
—
Reply to this email directly or view it on GitHub
https://github.com/IronSummitMedia/startbootstrap-sb-admin-2/issues/3#issuecomment-115825079
.

Hi,
Thank you very much on this. Its working great.
I had a question/suggestion. When the menu is expanded its not so important to close the menu as it doesn't overlap with the rest of the page content.
However when the menu is collapsed clicking on the sub-menus 'pops out' the menu over the rest of the context. Once we have clicked on the menu item which renders content it would be good to be able to hide that menu automatically if the menu is in collapsed mode.
Any idea how to achieve this?
Many thanks.

You can do it inside menu-toggle click handler. Just add the below line. This simply collapses any open menu.
$('#wrapper.toggled').find("#sidebar-wrapper").find(".collapse").collapse('hide');

Complete example is below.
$(document).ready(function() {
            $("#menu-toggle").click(function(e) {
                e.preventDefault();
                $("#wrapper").toggleClass("toggled");
                $('#wrapper.toggled').find("#sidebar-wrapper").find(".collapse").collapse('hide');
            });
        });

Thanks Pramod,
That fix didn't work for me however ( not sure why ).  Also I think I didn't explain what I was trying to achieve well.  What I was suggesting was when someone clicks on menu a menu item that is in a 'toggled' state, i.e minimised, you want the sub menus etc to be closed rather then displaying over the rest of your screen. The code below is put on the on click event for your menu item.
if ( $("#wrapper").hasClass("toggled") ) {
$(this).parents("li").removeClass("active");
$(this).parents("ul").removeClass("in");
}
What you provided I think would collapse all of the menu's when toggling between the full and minimised menu. Although for some reason it didn't work for me.

There is an issue with this a metis-menu. When wrapping the menu item in the span class 'masked'. The font for the arrow or plus/minus no longer changes when expanded/collapsed. I guess this has something to do with metis.

Hello pramod-rathod-avalara! I downloaded your projetct to try a menu sidebar, but it didnt work, I just downloaded and corrected the path of the css. Should I do more thing?
Thanks! :)

You will need to update your html to apply the css classes to make the toggle work. Please check the index.html from the example project.
Hope this helps!

HI, thanks for reply me. SO, I did update the index.html, but it didn't work yet :/

It worked, I missed the bower install :)

I have tried pramod-rathod-avalara's solution and it's working fine. Thanks ☺ Before using this, I had installed the bootstrap hover dropdown plugin in order to make the sb admin 2 upper menu show options on mouse hover.
After installing pramod-rathod-avalara's plugin, I have noticed a problem. When the left side menu is collapsed or toggled. The upper menu is changed: when I hover over the menu, the size of the menu is smaller and in different position. For example, the user menu appears so far on the right that the user can no longer see the options, for example, the logout.
Anybody knows how to fix this?

Okay there's a lot of +1's here so I am definitely adding this to the to-do list for the Bootstrap 4 version that I'll be developing.

any chance of this feature being added to a future revision of SB Admin 2? I would rather not install further packages to get such simple functionality out of the sidebar nav. Thanks!

It will certainly be added, but SB Admin 2 is going to get quite a few changes as well. Design wise and all.

Well I certainly cant push any design changes onto my clients, so Ill write my own JS module for collapsing the sidebar then, Thanks!

I already wrote something for that...
As you can see in the first screenshot (red circle) I put a floating button
so Users can expand or collapse the side bar:

And in the second screenshot you can see another hidden bar that users can
expando too (black sidebar).

You can see all the JS functions and styles to do that in this project:
https://github.com/unix4you2/practico  as a framework to build applications
without programming.
Regards.
Mg. John F. Arroyave Gutiérrez
Construya aplicaciones web en minutos con
Práctico Framework - www.practico.org http://www.practico.org/
On Sun, Aug 27, 2017 at 11:49 AM, Todd<EMAIL_ADDRESS>wrote:

Well I certainly cant push any design changes onto my clients, so Ill
write my own JS module for collapsing the sidebar then, Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/BlackrockDigital/startbootstrap-sb-admin-2/issues/3#issuecomment-325210096,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACVQZCtayFZ_YqNQZFF9e5m00QRwMjBGks5scZ4DgaJpZM4C1_LW
.

i notice if you open sb admin 2 then click the sidebar toggle while watching inspect, there are class on elements that change
if anyone still have problem with sidebar toggle accordion that didn't work, here is solution that work for me


Getting 'A helper named 'select-2' could not be found'

After trying to install and use select-2 I'm seeing this error in my console.
After I installed it using the default syntax ember install ember-select-2
I also had this error after NPM finished it's job
The 'ember generate' command requires an entity name to be specified. For more details, use 'ember help'.

Fixed by running ember generate ember-select-2
Which really should be added into the setup instructions just in case

I think
ember install ember-select-2

is automatically running this, but there seems to be an error that prevents it to do so.
The `ember generate` command requires an entity name to be specified. For more details, use `ember help`.

So I my eyes this is an installation issue and not a documentation issue.


Feature Request: Minumum Size requirements

I would like to have a minimum size (width, height) requirement as well as a maximum size

What maxWidth/maxHeight does is resize the image such that the image returned is within those constraints. To implement minimum size, we would be scaling the image up from it's original (possibly resulting in a stretched, blurred image). Why would you ever need this?

No response.


Suggested improvements to get-id-from-url.js

Scope & Features:
I wrote this code for the modify app when it was not available and i realised there are some improvements that are worth pushing to 3d-io-js

this makes get-id-from-url responsive to storageDomain from config, so it also works for testing environments
throws an error instead of returning the input url, if the url is not a valid url. If this was intentional by design, I can adjust it.

How to use:

test it like this:
io3d.storage.getStorageIdFromUrl("https://storage.3d.io/535e624259ee6b0200000484/bake/2017-07-25_14-03-12_lXOHrN/lighting.gz.data3d.buffer")
should return the same result as master
Now returns an error insted of returning the url:
io3d.storage.getStorageIdFromUrl("bullshiturl/bake/lighting.gz.data3d.buffer")

thx. yes, it's cleaner and more consistent - definitely an improvement.

cool thanks