 in v3

It would be super-nice if <sourcecode> were generated when appropriate, so that linters, etc., could rely on its presence, and to reduce diffs from the RFC Editor (since xml2rfc --v2v3 doesn't automatically convert them).
I'm thinking that kramdown-rfc2629 could assume that something is <sourcecode>, not <artwork>, when @type matches an entry in https://www.rfc-editor.org/materials/sourcecode-types.txt.

Because new source languages are coined every minute, maybe it is better to make a list of types that stay ?  Section 2.5.7 of RFC 7991 suggests
   o  ascii-art
   o  binary-art
   o  call-flow
   o  hex-dump
   o  svg

https://tools.ietf.org/id/draft-levkowetz-xml2rfc-v3-implementation-notes-10.html#section-3.1.3 contains more musings about the sorry state that this part of RFCXMLv3 is in, clarifying the type attribute for artwork to be a format specifier and leaving hex-dump and call-flow on the cutting-room floor.

RFC 8688 is the only one I can find that has type=hex-dump, but uses it for base64.
        <artwork align="left" alt="" name="" type="hex-dump" pn="section-4.1-14">
eyJhbGciOiJFUzI1NiIsInR5cCI6InZjYXJkK2pzb24iLCJ4NXUiOiJodHRwczov
L2NlcnRzLmV4YW1wbGUubmV0L3JlamVjdF9rZXkuY2VyIn0=
</artwork>

This is also the only one I can find that uses type=call-flow, for a pretty standard ASCII-art representation of a message sequence chart.
OBTW, what is "binary-art"?

That seems like a reasonable approach...

OBTW, what is "binary-art"?

I have no idea, but I'd like it to be this. ;-)

I'd love to be able to use xml2rfc in draft-dkg-lamps-samples to generate sourcecode elements of PEM-encoded X.509 certificates, secret key material, and PKCS #12 objects which would be easily extractable from the resultant RFC.   Including a filename for these elements would also be a nice bonus.

I'm also interested in using kramdown-rfc2629 to refer to sourcecode snippets of C API that could be used to document an extension to the stateless OpenPGP interface.

I'd love to be able to use kramdown-rfc2629 in draft-dkg-lamps-samples to generate sourcecode elements of PEM-encoded X.509 certificates, secret key material, and PKCS #12 objects which would be easily extractable from the resultant RFC.

You are not using {::include fn}, but built your own -- reason?

Including a filename for these elements would also be a nice bonus. That draft source is on gitlab.

Yes, that would be the "name" attribute, which you can put into an IAL.
As this needs to be put on the actual artwork element, you end up needing this:
~~~ mylang
{::include foo.mlng}
~~~
{: artwork-name="foo"}

This is not exactly well documented, so documentation needs to be part of the solution for this issue

You are not using {::include fn}, but built your own -- reason?

ignorance? 😛
however, in my latest revisions, i have some inclusions that need to happen within backticks, which would look like this:
This secret key was generated using provable prime generation found in {{FIPS186-4}} using the seed `{::include ca.seed}`.

But that appears to just embed the literal string {:include ca.seed} instead of the contents of the ca.seed file.  I'll convert all my full-line objects to use {::include though, thanks for the suggestion.

{: artwork-name="foo"}

thanks for this hint.  it looks like it's coming through as expected now, though the version of xml2rfc that i'm using isn't doing anything particularly clever with that tag when i convert it to html locally. I'll submit a new revision of the draft shortly and see what i can do with it.
I still think that these PEM objects would be better labeled as sourcecode than artwork -- if there's a way to do that with kramdown-rfc2629, let me know! But in fact they're something different than both -- they're ASCII-encoded sample protocol data units (PDUs), but i don't see anything in RFC 7991 that is more appropriate. ☹
PS any suggestion of what type attribute i should use for PEM-encoded objects like this?  discussion over on ACME suggests application/x-pem-file is the appropriate MIME type, but for whatever reason the type attribute isn't aligned with MIME.

Working on the code for sourcecode (had a sufficiently boring meeting to write it already, now testing).
(I think sourcecode is fine for any machine-readable input, even PEM stuff.)
{::include fn} is currently only recognized at column 0; your usage is a new idea that hadn't surfaced so far.
Recognizing that construction anywhere is a bit more dangerous; can you think about another restricting condition we could apply to it?  (Maybe we need to live dangerous.)
I don't think anything speaks against using media-type-names for type attributes; I actually think this is a great idea.  We could adopt the convention that anything with a / in it is a media-type-name.  (Or actually a content-type; parameters would need to be notated without spaces as spaces are not allowed in codeblock language identifiers.)

RFC 733 contains the string Standard Distribution::Include: -- not quite a match, but a close hit.
draft-fossati-svg-test-03 does contain it literally in a kramdown-rfc example.  Hmm.
(And it's good humor to see the occasional {::include leak through unintendedly... draft-ietf-rats-eat-05...
Probably need to make its own issue about that.

Probably need to make its own issue about that.

#104 covers this issue.  thanks for thinking about it!

in the commit message in https://github.com/cabo/kramdown-rfc2629/commit/18786196cc4d77c48373ce4f71d9eefdd7fad215 it has this example:
An example with an inline attribute list (IAL):

~~~ c
main() { return 1; }
~~~
{: #my-little-c-program artwork-name="myli.c" title="My little C program"}

It's not clear to me whether artwork-name works for both sourcecode and artwork (and maybe sourcecode-name would also work for both?), or whether the example is mistaken, and it should be sourcecode-name.

Either works.  (Making artwork-name= not work with this change would break existing documents that now generate <sourcecode>, so we had to accept both.)

hm, i've tried updating to 1.3.34, and this doesn't seem like it's working as expected for me.
the source code looks like this:
~~~ application/x-x509-ca-cert
{::include ca.crt}
~~~
{: artwork-name="ca.crt"}

and the generated xmlv2 looks like this:
<figure><artwork type="application/x-x509-ca-cert" name="ca.crt"><![CDATA[
-----BEGIN CERTIFICATE-----
MIIDLDCCAhSgAwIBAgITD5FARp09T2LXr/FPQiI+8ZsGAjANBgkqhkiG9w0BAQ0F
ADAtMSswKQYDVQQDEyJTYW1wbGUgTEFNUFMgQ2VydGlmaWNhdGUgQXV0aG9yaXR5

I would have expected sourcecode instead of artwork.
I'm invoking it as kramdown-rfc2629 < lamps-samples.md > lamps-samples.xml, fwiw.  Should I be doing something differently?

You are not setting --v3, and <sourcecode> is not valid in v2.
Best call kramdown-rfc2629 using the driver kdrfc, as in
kdrfc -3chi lamps-samples
(This gives you a .txt, a converted v3 XML, a HTML, and an idnits check, all in one call :-)

after supplying the --v3 flag to my invocation of kramdown-rfc2629, the transformation works as expected.  thanks!


Issue an error if NODE_ENV=production and you would reach the setup app

Feature Request
Is your feature request related to a problem? Please describe.
When trying to deploy a Probot app to a production environment, I had an issue with my env vars that prevented it from actually reaching my routes (specifically, I had a typo in PRIVATE_KEY_PATH). As such, I spent several hours blindly guessing what the problem was since all of the logs indicated that it was starting up fine
Describe the solution you'd like
If NODE_ENV=production, the startup process should fail loudly and clearly - with errors written to stdout - if it reaches a condition that would run the setup process. Currently, those conditions are a missing APP_ID and/or a missing or invalid PRIVATE_KEY or PRIVATE_KEY_PATH.
Describe alternatives you've considered
Maybe a command to test that the env/config is production-ready?
Teachability, Documentation, Adoption, Migration Strategy
n/a

The latest version should warn in the console when the PEM file contents are bad. If the file path does not exist, Node will exit and throw a standard Error: ENOENT: no such file or directory, open './bad/path.pem'.

It might be a good to warn users when app id is set but their certificate is not, or vice-versa. https://github.com/probot/probot/blob/c5f7a32e12e3c42575b09e06d5a7b474a3f8cd1d/src/index.ts#L72-L75
  if (!options.id || !options.cert) {
+   if (typeof options.id !== typeof options.cert) {
+ 	  throw Error('bad config...')
+   }
    probot.load(setupApp)

@Firehed I agree, do you want to start a pull request?
@MaximDevoir I think your suggestion would be worth discussing separately? We could also do it altogether, but I wouldn't want one change get blocked by the other

If the suggestion is a solution to @Firehed's issue, then I'll leave it for him.

@MaximDevoir's suggestion may have indeed caught the issue I encountered, but I don't think it's an optimal solution to indicate a production misconfiguration. It does look like a check also worth adding.
@gr2m Sure, I can look into putting something together.


cmd/asm: can't store float32 in odd-numbered registers s1,s3,s5,... on GOARCH=arm

We lack the ability to store float32 into odd-numbered single-precision floating point sX registers on GOARCH=arm.
The only way to access the floating-point registers is via the F0, F1, ... register names, and these correspond to the double-precision float64 registers d0, d1, ....  If you write a 32-bit value to these registers, the assembler will emit an opcode that writes to the single-precision floating point register sX that aliases the corresponding dX register, where dX == s(2*X).
The only way to access the odd-numbered sX registers is to write BYTE $0x.... statements and lay out the opcodes directly.  But this has the unfortunate consequence of not being able to use virtual registers like FP, and thus extra instructions are required to work around this limitation.
What version of Go are you using (go version)?

$ go version
go version go1.12.4 darwin/amd64

Does this issue reproduce with the latest release?
Yes; including tip as of July 25, 2019.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jpap/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/jpap/Development/go"
GOPROXY=""
GORACE=""
GOROOT="/Users/jpap/Development/go/src/github.com/jpap/go"
GOTMPDIR=""
GOTOOLDIR="/Users/jpap/Development/go/src/github.com/jpap/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/wc/jkc42h512cv0n1tdp51yjp7w0000gq/T/go-build781111158=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
[main.go]
package main

func storeFloat(a, b, c, d, e, f float32)

func main() {
	storeFloat(1, 2, 3, 4, 5, 6)
}

[storeFloat.s]
// +build arm

// storeFloat(a, b, c, d, e, f float32)
TEXT ·storeFloat(SB), $0-24
  MOVF  a+0(FP), F0   // ed9d0a01        vldr    s0, [sp, #4]
  MOVF  b+4(FP), F1   // ed9d1a02        vldr    s2, [sp, #8]
  MOVF  c+8(FP), F2   // ed9d2a03        vldr    s4, [sp, #12]
  MOVF d+12(FP), F3   // ed9d3a04        vldr    s6, [sp, #16]
  MOVF e+16(FP), F4   // ed9d4a05        vldr    s8, [sp, #20]
  MOVF f+20(FP), F5   // ed9d5a06        vldr    s10, [sp, #24]
  RET

Build the above project, for example to target the Raspberry Pi having vfp support:
env GOOS=linux GOARCH=arm GOARM=6 go build -o demo .

Disassemble the binary:
objdump -d demo

Observe the opcodes of the MOVF instructions in storeFloat: they all reference even-numbered registers s0, s2, s4, s6, s8, s10.  I have appended the disassembly to the code above as line-comments.
I did try to specify single-precision floating point registers using S0, S1, S2, S3, ..., however the assembler fails with errors:
./storeFloat.s:5: illegal or missing addressing mode for symbol S0
./storeFloat.s:6: illegal or missing addressing mode for symbol S1
./storeFloat.s:7: illegal or missing addressing mode for symbol S2
./storeFloat.s:8: illegal or missing addressing mode for symbol S3
./storeFloat.s:9: illegal or missing addressing mode for symbol S4
./storeFloat.s:10: illegal or missing addressing mode for symbol S5
asm: assembly of ./storeFloat.s failed

A quick look at the Go source code shows that only REG_Rx and REG_Fx register types have been defined in src/cmd/internal/obj/arm.

Concretely, it would be great if we could:

Expand the legal floating point registers that the assembler accepts to F0, ..., F31 so that we can target all 32 single-precision registers.
Specify the floating-point precision in a MOV instruction so that the assembler can map FN to dN or sN as appropriate.  This is how the arm64 architecture is treated: there is FMOVS for a single-precision load, and FMOVD for the double-precision variant.

Expand the legal floating point registers that the assembler accepts to F0, ..., F31 so that we can target all 32 single-precision registers.

We could consider adding more register support. I would think adding Sx registers, either odd-numbered only, or all 32 with S0 aliases F0, S2 aliases F1, etc., instead of changing the existing semantics of Fx registers.
What is your use case for these registers? Accessing them in assembly (only)? If you want the Go compiler to use all 32 single-precision registers, it would need more than that.

Specify the floating-point precision in a MOV instruction so that the assembler can map FN to dN or sN as appropriate.  This is how the arm64 architecture is treated: there is FMOVS for a single-precision load, and FMOVD for the double-precision variant.

We already have: MOVF and MOVD.

What is your use case for these registers? Accessing them in assembly (only)?

I only access these registers from assembly, currently via the BYTE workaround.  I construct the opcodes in a code generator using a hard-coded FP virtual register to R13 (SP) mapping based on the TEXT stack size.

We could consider adding more register support. I would think adding Sx registers, either odd-numbered only, or all 32 with S0 aliases F0, S2 aliases F1, etc., instead of changing the existing semantics of Fx registers.

It would be nice to have some consistency with arm64, where the Fx virtual register names map to the single- and double-precision aarch64 register sx and dx depending on the mnemonic.


ARM Image?

I have an Odroid HC2, ran the command grep -E 'avx2?' /proc/cpuinfo and don't see AVX. Any plans to support ARM architechture?

Doesn't it work with the official Immich images? --> https://github.com/tensorflow/tfjs/issues/5937
Or is it a 32-bit system?

Yes, it's armv7, so 32-bit.

So, immich itself provides a armv7 image. Did you try it?

Yes, it's running right now. But without the machine learning. I'm just asking about having a machine learning image with no avx requirements for armv7.

But the machine-learning image is also available for armv7: https://hub.docker.com/r/altran1502/immich-machine-learning/tags
Why wouldn't it work?

I can't install that one as per the instructions: https://immich.app/docs/install/requirements
I do not have avx or avx2 instruction sets.

Ohhhh. That makes sense. Thanks for clarifying! I just didn't even both running the container because of the docs. In any case, I will revisit this at a later time, hopefully if the dev adds the ability to import, and library files staying separate from the media folder(s). Then I'm sold on Immich. :)


cannot unmarshal number 1715.0 into Go struct field StatsData.data.daily_average of type int64

Still have the same issue as #37 on commit 4542143b42f704f75a6b9f5285920886de980547.
Full log is shown as below:
panic: wakabox.GetStats: Error getting Current Stats: unmarshal error  :json: cannot unmarshal number 1715.0 into Go struct field StatsData.data.daily_average of type int64

goroutine 1 [running]:
main.main()
	/home/runner/work/ZexinLi0w0/ZexinLi0w0/waka-box-go/cmd/box/main.go:48 +0x7d6
Error: Process completed with exit code 2.

update  	github.com/YouEclipse/wakatime-go v0.1.2-0.20221018190731-e3134bb99788


Explicit limitation of master log backups

The product does not allow the master log to be backed up, though you can change to full mode. This change explicitly states no log backup allowed

Steve, once again we appreciate your contribution, and once again it looks like you've uncovered an article that needs a refresh as well. We'll pull this into an internal PR and you'll get the appropriate credit.

FWIW, I think these could also use the explicit limitation:

https://learn.microsoft.com/en-us/sql/t-sql/statements/backup-transact-sql?view=sql-server-ver16
https://learn.microsoft.com/en-us/sql/relational-databases/backup-restore/back-up-a-transaction-log-sql-server?view=sql-server-ver16


Update to 4.5.0

jemalloc came a long way since 4.0.3. Let's try to update. Once this is merged I'll follow-up with the rust-lang/rust PR.

Thanks! I've pushed this as https://github.com/rust-lang/jemalloc/tree/rust-2017-05-09


Problem with search and BaseDn.

Hi I have one trouble with searching by login. It looks like via console:
ldapsearch -LLL -h example.com -b 'dc=example,dc=com' -D "username" -W "sAMAccountName={LOGIN}"

It works perfectly via ldapsearch. But there is a problem with client.search Here is an example:
var ldap = ldapjs.createClient({
    url: options.url
});

ldap.bind(options.username, options.password, function(err) {
    if (err) {
        throw err;
    }

    var login = "sAMAccountName=LOGIN";
    ldap.search(login, function(err, res) {
        if (err) {
            throw err;
        }

        res.on('searchEntry', function(entry) {
            console.log('entry: ' + JSON.stringify(entry.object));
        });

        res.on('searchReference', function(referral) {
            console.log('referral: ' + referral.uris.join());
        });

        res.on('error', function(err) {
            console.log(err.message);
        });

        res.on('end', function(result) {
            console.log('status: ' + result.status);
            ldap.unbind()
        })
    })
});

There is an error: 000020D6: SvcErr: DSID-031007DB, problem 5012 (DIR_ERROR), data 0
If I put all DN path to login variable it works perfect too. But the system doesn't know the full path of user. I think there should be an option BaseDN in search. Is it correctly?

You should use '(sAMAccountName=LOGIN)' as your filter, not the baseDN.
BaseDN is the LDAP tree entity from which a search is initiated. (The search depth determined by scope.)

Hello,
but what shall I write instead of the 'sAMAccountName' in the search function, in my ldap system 'c' is not defined.
Yours sincerely,
Patrick Langkau

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


prisma db push Error - Database error: Error querying the database: db error: ERROR: type "citext" does not exist but citext extension enabled

Bug description
https://github.com/prisma/prisma/issues/5772 - Similar issue to what is described here.
We are trying to run the prisma commands on Vercel and we keep getting this error.
Our initial migration creates the extensions as suggested above.
CREATE EXTENSION IF NOT EXISTS citext;
CREATE EXTENSION IF NOT EXISTS "uuid-ossp";

Weirdly, it works absolutely fine locally right now which makes it even harder to debug. The sequence of commands we are running is:
npx prisma migrate reset --force
npx prisma db push --preview-feature
To clarify, the first migration applies fine and then the second command errors. It might be worth noting that we are running against a custom postgres schema so maybe something going on in the shadow db there?
How to reproduce
Steps to reproduce the behavior:

Reset your db with an initial migration to create the required extensions
Run db push to apply the rest of the schema
See error

Expected behavior
db push after the initial migration has been applied should already know about citext has it has been applied before.
Prisma information
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model Member {
  id                 String               @id @default(dbgenerated("uuid_generate_v4()")) @db.Uuid
  createTime         DateTime             @default(dbgenerated("now()"))
  externalId         String?              @unique @db.VarChar(255)
  firstName          String               @db.VarChar(255)
  lastName           String               @db.VarChar(255)
  email              String               @unique @db.Citext
  hashedPassword     String?              @db.VarChar(255)
  workTypes          String[]             @db.VarChar(64)
  useTypes           String[]             @db.VarChar(64)
}

Environment & setup
Currently happening on Vercel

Database: PostgreSQL
Node.js version: 14
Prisma version: 2.21.2

Just to further this, when inspecting in PG_Admin, the main difference between the working case and the failing one is the absence of the relevant Functions within that schema. I wonder if the IF NOT EXISTS part of the command just looks at a single schema, establishes it exists there and does not add it anywhere else?
I also tried generating the full initial migration (i.e. create extensions + tables) and just applying that without db push and I get the same behavior; also only failing on CI

I think you're right. We execute the extensions only to the shadow database, not at all to the actual one.
Plan:

Use the describer to describe all extensions: SELECT * FROM pg_extension
In the differ, find missing extensions from the actual database. Create them.

I'm still not sure would it be a problem for us when we don't have the extensions in the PSL.

have there been any progress on this?

Hey, @kiily, we have a preview feature that provides support for PostreSQL Extensions now that might help with this! You can read more in our docs.

Yeah, I'm having the same issue as @GeeWee. Works fine in the public schema, but we're creating 1 schema per integration test and then it fails with Error: db error: ERROR: type "citext" does not exist.
I tried create the extension before every test, but it still doesn't work:
await db.$executeRawUnsafe(`CREATE EXTENSION IF NOT EXISTS "citext" WITH SCHEMA "${getSchemaFromPGSQLUrl()}";`);
execSync(`npx prisma db push`, {
  env: process.env,
});

I found a way to make it work based on this SO answer, but it goes against what's recommended for production PGSQL dbs:
extensions = [citext(schema: "pg_catalog")]

It basically adds to the pg_catalog schema, which is magically shared between all schemas.

How are you creating the schemas and then migrating the schema onto these @luisrudge?

@janpio I'm not proud of it, but it works 😅
//__mock__/db.ts
import { PrismaClient } from '@prisma/client';
export type { Prisma } from '@prisma/client';
import { URL } from 'url';
import { v4 } from 'uuid';
import { execSync } from 'child_process';
import { afterAll, beforeAll } from 'vitest';

function getPGSQLUrl() {
  if (!process.env.PGSQL_URL) {
    throw new Error('please provide a database url');
  }
  const url = new URL(process.env.PGSQL_URL);
  url.searchParams.delete('schema');
  url.searchParams.append('schema', `test-${v4()}`);
  return url.toString();
}
function getSchemaFromPGSQLUrl() {
  if (!process.env.PGSQL_URL) {
    throw new Error('please provide a database url');
  }
  const url = new URL(process.env.PGSQL_URL);
  return url.searchParams.get('schema');
}

process.env.PGSQL_URL = getPGSQLUrl();

//override the db export so it uses the dynamic PGSQL_URL
export const db = new PrismaClient();

beforeAll(() => {
  execSync(`npx prisma db push`, {
    env: process.env,
  });
});

afterAll(async () => {
  await db.$executeRawUnsafe(`DROP SCHEMA IF EXISTS "${getSchemaFromPGSQLUrl()}" CASCADE;`);
  await db.$disconnect();
});

beforeEach(async () => {
  await truncateDB();
});

async function truncateDB() {
  const tablenames = await db.$queryRaw<
    Array<{ tablename: string }>
  >`SELECT tablename FROM pg_tables WHERE schemaname=${getSchemaFromPGSQLUrl()}`;

  for (const { tablename } of tablenames) {
    if (tablename !== '_prisma_migrations') {
      try {
        await db.$executeRawUnsafe(
          `TRUNCATE TABLE "${getSchemaFromPGSQLUrl()}"."${tablename}" CASCADE;`
        );
      } catch (error) {
        console.log({ error });
      }
    }
  }
}

Interesting, that would mean that db push does not activate the extension as expected. Can you open a new issue with your code and also your schema you are using? Maybe we can figure this out.

@janpio I think db push activates the extension correctly. The problem is that you can have only a single schema for the extension and that makes it impossible to run tests in parallel. I think it's more related to this issue: https://github.com/prisma/prisma/issues/14662

To anyone who's still facing this issue. It seems the CITEXT extension doesn't work well if you have multiple schemas on your DB, it only works well for the first schema that you activate it for which caused this issue for me.

Got around this issue by using a multiple databases on local docker instance.
https://github.com/boskomijin/postgres-multiple-databases-creation


Support picolib

This uses the new precompiled newlib system to create a compiled picolib for libtock-c.
Hopefully this sweetens the deal for #353.

Needs a formatting pass? Having a hard time parsing the CI output. It's very exciting to see picolibc support, though it'll be interesting if this build also alleviates the malloc concerns of https://github.com/tock/libtock-c/pull/305#issuecomment-1604414789.

The problem with this is that picolibc seems to want core functions without underscores:
int fstat(int fd, struct stat *st) { return _fstat(fd, st); }
int isatty(int fd) { return _isatty(fd); }
int read(int fd, void *buf, uint32_t count) { return _read(fd, buf, count); }
int write(int fd, const void *buf, uint32_t count) { return _write(fd, buf, count); }
int lseek(int fd, uint32_t offset, int whence) { return _lseek(fd, offset, whence); }
int close(int fd) { return _close(fd); }
caddr_t sbrk(int incr) { return _sbrk(incr); }

whereas newlib wants the versions with the underscore. My attempt to include both causes some apps to fail to compile. In any case, we probably don't want both.
I have no idea why picolib deviates here, or if there is a way to request the _ versions.
It's worth considering the picolibc flags I am using:
# Picolibc Configure Flags
#
# picolib=false             # Do not use picolib sbrk. We need to use the memop syscalls.
# picocrt=false             # Do not build crt0, we have our own.
# picocrt-lib=false         # Do not package crt0.
# tinystdio=false           # Do not use AVR tinystdio, which uses a different underlying interface (aka stdout object).
# newlib-stdio64=false      # Do not include 64 bit APIs.
# newlib-reent-small=true   # ?
# newlib-global-atexit=true # ?
$PICOLIB_SRC_DIR/scripts/do-configure arm-none-eabi -Dprefix=`realpath $PICOLIB_INSTALL_DIR` \
  -Dpicolib=false \
  -Dpicocrt=false \
  -Dpicocrt-lib=false \
  -Dtinystdio=false \
  -Dnewlib-stdio64=false \
  -Dnewlib-reent-small=true \
  -Dnewlib-global-atexit=true \
  -Dmultilib-list=thumb/v6-m/nofp,thumb/v7-m/nofp,thumb/v7e-m/nofp \
  -Dc_args="-g -Os -ffunction-sections -fdata-sections -fPIC -msingle-pic-base -mno-pic-data-is-text-relative"

I don't know what tinystdio is, but when I didn't set that to false compilation failed because we didn't have some sort of file-descriptor-like thing.
In any case, I've looked over the picolibc build options a couple times and I can't figure out what would have an impact on _ system names versus not.

AFAICT, the presence/absence of the leading underscore is some unimportant fight among various library/tool vendors: https://stackoverflow.com/questions/36438732/close-vs-close-read-vs-read-write-vs-write-what-is-difference — neither is correct. Best (sigh) solution here is probably to #ifdef on whether we're using picolib or newlib for a given build.

AFAICT, the presence/absence of the leading underscore is some unimportant fight among various library/tool vendors: https://stackoverflow.com/questions/36438732/close-vs-close-read-vs-read-write-vs-write-what-is-difference

oh gross

solution here is probably to #ifdef on whether we're using picolib or newlib for a given build.

I think we can add this in a reasonable way

Hurrah this passes CI!

Rebase and updated.

Doesn't work on a fresh checkout currently. Had enough time to debug quickly but not push fix sorry. Need to add ifdef PICOLIB guards in the Precompiled.mk file as well, because the newlib pattern and the picolib pattern are the same (so you end up with two rules to make the same targets). Other option is to go back to the lib/newlib/... and lib/picolib/... which will also fix the problem. (Got away without the subdirectory for newlib vs libc++ because the archive names are different; here's it's libc.a in both cases)
TOCK_NEWLIB_TARGETS += $$(TOCK_USERLAND_BASE_DIR)/lib/%/$(1)/$(2)/lib/$(3)/libc.a
TOCK_NEWLIB_TARGETS += $$(TOCK_USERLAND_BASE_DIR)/lib/%/$(1)/$(2)/lib/$(3)/libm.a

TOCK_PICOLIB_TARGETS += $$(TOCK_USERLAND_BASE_DIR)/lib/%/$(1)/$(2)/lib/$(3)/libc.a
TOCK_PICOLIB_TARGETS += $$(TOCK_USERLAND_BASE_DIR)/lib/%/$(1)/$(2)/lib/$(3)/libm.a

Does something like https://github.com/tock/libtock-c/pull/357/commits/d4cb0c3c8608a8d4227d2dc164666b44b57225b0 work?

Beyond the CI error, I don't think the rules are right either. Without debugging deeply, on a fresh checkout it will try to fetch picolib twice:
[-bash] Fri 14 Jun 12:36 [[make-precompiled-picolib] /tmp/libtock-c/examples/blink]
$ make PICOLIB=1 -j4
cd ../../lib; ./fetch-picolib.sh 1.8.5
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C ../../picolib-tock -f Makefile all
cd ../lib; ./fetch-picolib.sh 1.8.5
 DIR        ../picolib-tock/build/cortex-m0/picolib-tock
...
replace libtock-picolib-1.8.5/build-riscv.log? [y]es, [n]o, [A]ll, [N]one, [r]ename:

which ultimately causes the build to hang because of this question.

full output
[-bash] Fri 14 Jun 12:36 [[make-precompiled-picolib] /tmp/libtock-c/examples/blink]
$ make PICOLIB=1 -j4
cd ../../lib; ./fetch-picolib.sh 1.8.5
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C ../../picolib-tock -f Makefile all
cd ../lib; ./fetch-picolib.sh 1.8.5
DIR        ../picolib-tock/build/cortex-m0/picolib-tock
DIR        ../picolib-tock/build/cortex-m3/picolib-tock
Fetching picolib from https://www.cs.virginia.edu/~bjc8c/archive/tock...
DIR        ../picolib-tock/build/cortex-m7/picolib-tock
Fetching https://www.cs.virginia.edu/~bjc8c/archive/tock/libtock-picolib-1.8.5.zip...
DIR        ../picolib-tock/build/cortex-m4/picolib-tock
Fetching picolib from https://www.cs.virginia.edu/~bjc8c/archive/tock...
Fetching https://www.cs.virginia.edu/~bjc8c/archive/tock/libtock-picolib-1.8.5.zip...
 Short answer, no.
That's actually what I tried the first time for newlib/libc++, and how I eventually ended up with the extra directory. % isn't quite like a generic wildcard matching text, it is aware of file and directory structure, and it matches a directory, not a string [things learned a few weeks back when I fought this same battle].
The easy answer is to just embrace the subdirectory like I originally had. It's what make wants 🤷🏼 .


Include Digest and ImageID in /services response

/images is returning Digest and ImageId which comes from the image repository, but we don't have the Digest/ImageId of the pods running in the cluster.

It would be great to get CreatedAt too but I'm not sure if that piece of information resides in the same place?

I looked into this. It's not straight-forward to get this info from kubernetes -- controllers don't keep track of the digest (unless you specify one in the manifest), since they are just a template for the pods.
Individual pods seem to have an image ID of some kind:
$ kubectl get pod -n kube-system =l name=flux -o yaml
apiVersion: v1
items:
- apiVersion: v1
  kind: Pod
  metadata:
# ...
  status:
    conditions:
    - lastProbeTime: null
      lastTransitionTime: 2018-02-07T13:31:34Z
      status: "True"
      type: Initialized
    - lastProbeTime: null
      lastTransitionTime: 2018-02-08T18:24:54Z
      status: "True"
      type: Ready
    - lastProbeTime: null
      lastTransitionTime: 2018-02-07T13:31:34Z
      status: "True"
      type: PodScheduled
    containerStatuses:
    - containerID: docker://7733a0c9ab1f4048e6d1b43c41207a2ea3a6b13211afc91f4311fc661920c960
      image: quay.io/weaveworks/flux:feature-repo-sync-99acb551
      imageID: docker://sha256:a6a480bea993c2d9fa7f6d138a69f1a1525ae252498c03ebbba0818ab3b5be13

.. but there will usually be more than one pod that's attributable to a controller, and they may well have different images running (either because a rollout is in progress, or because for some reason the images at each host differ).

Gotcha.
If the new /images summary tells the UI what flux thinks the current image is that would be fine too.
This issue should be described as the problem really: The UI would like to know. currentImage.ID and currentImage.CreatedAt to show that information in https://github.com/weaveworks/service-ui/pull/1907. The solution proposed in https://github.com/weaveworks/flux/issues/913 will probably solve that so we could close this.


fix(curriculum): give useful hint for step 50 of statistics calculator if you are missing the starting value of the reduce.

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #56938

Please stop closing and opening PRs, you can make changes to the existing PR to address any issues, withotu closing it. Thank you

Please stop closing and opening PRs, you can make changes to the existing PR to address any issues, withotu closing it. Thank you

sorry i didn’t know how to do it 🙏

You can ask for help, opening a topic on the forum or writing on discord

You can ask for help, opening a topic on the forum or writing on discord

should i continue this pr or what?

Yes please keep this PR! You said you didn't know how to do something, when you don't know how to do something you can ask for help

Yes please keep this PR! You said you didn't know how to do something, when you don't know how to do something you can ask for help

okay thank you


Appender: should be scope since it copies its arguments

This does not convince me. The element itself is copied, but if it has mutable indirection it's contents are not.
You do not want to put a pointer to a local into a global array.

This function is now an alias to put, therefore this change is no longer necessary.


Make the /groups API use a generic renderAsJson, like the /status API

Main blocker being supporting the rendering of a generic Option (containing a string or an object).

Open question on whether the types can be made more generic to support an Option of any other value, rather than an Option of two specific subtypes. A round of renaming can be helpful first given the prefix Status is used in the generic renderer.

ownedBy should also use the generic renderAsJson. The only new case to support in its ViewModel is Date which works natively (and perhaps RawUserInput).


Add a way to know the current 'open' state of tooltips

It would be nice to know the open state of tooltips. I can also try to create a PR, if this is something more people think is missing.
Is your feature request related to a problem? Please describe.
We are using tooltips on our page, with a click to open them. We would like to close them with a click on the same button, but that is not possible (as I see it) at the moment, as there is no way to know the state of the tooltip.
Describe the solution you'd like
Either add a flag to TooltipService to indicate if any tooltip is currently open, or invoke the OnClose event when the tooltip is closed (also when closed by clicking some other element).
Describe alternatives you've considered
I tried to make it work with the current implementation, but it's not possible as I see it.
Example:

Add event handler to OnClose that sets a TooltipIsOpen flag to false.
Click button to open tooltip (sets flag to true).
Click outside the button (tooltip closes), event handler not called, TooltipIsOpen is still true.
Click on button again, as the flag indicates it's still open, it will not open before a second click.

Additional context
Nothing to add.

I believe that you can use a simple variable in your button click for such state.

@enchev That would not work, if you read the example. The wrong state will be set if the tooltip is closed by clicking something else than the button.

Maybe similar option can work for tooltip as well:
https://github.com/radzenhq/radzen-blazor/blob/master/Radzen.Blazor/DialogService.cs#L373

Thank you! It works great :)


If two people walk side by side or one after the other, which parameter should I adjust?

Hi @Hardold,
Are they recording as one person or two?
Best

They are recording as one person.I'm confused .Which parameters should I adjust?
Best

Blobsize is to be adjusted

If you have two people walking in side by side, footfall for the time being cant segment them. So i would adjust the maxblobsize to 3/4 the size of the camerawidth. Adjust the midblobsize variable to 1.5x size of minblobsize.

Hi,
@DHaylock
What parameters to adjust maxblobsize, midblobsize and minblobsize? Thinks a lot !
"minsizeone": 10, "minsizetwo":30, "minsizethree": 150?

Tracking config: minblobsize and maxblobsize for the contour finder. min,mid,max size for the event reporting is if the blob can be considered to be bigger than one person.

minblobsize is "minarea"?
maxblobsize is"maxarea"?
What is the relationship between( "minsizeone", "minsizetwo", "minsizethree" )and( "minarea" and "maxarea") ?  My picture size is 640*480. How to set them?

Hi @Hardold,
Yes.
The Configuration.md should explain all the parameters.
Best


docker: Update dockerfile with driver version 682.38

Update GPU driver and FW version to 682.38 release: https://dgpu-docs.intel.com/releases/production_682.38_20230929.html.
Remove extra build argument KERNEL_VERSION.
Use ubi-minimal 9.2 image for packaging GPU driver container.
Remove firmware for Max series GPU since we only support Flex series GPU now.
Signed-off-by: Hersh Pathak<EMAIL_ADDRESS>

Looks good to me. Thanks!


AL2 instances report auth fail occasionally

When bootstrapping an AL2 instance sometimes it reports "Auth fail" even with correct SSH keys and this prevents the instance from being bootstrapped.

Possible fix 1, allow more than one "Auth fail" before failing completely.


Authentication failes

Hi, I have installed docker-mail server with the following settings:

DMS_DEBUG=0
ENABLE_SASLAUTHD=1
ONE_DIR=1
OVERRIDE_HOSTNAME=mydomain.com
PERMIT_DOCKER=connected-networks
SSL_TYPE=
SMTP_ONLY=1

My goal is to use it to send email from my docker applications platform.
I have added a user by the provided setup script.
When I try to send any email to any address I get 535 5.7.8 Error: authentication failed: generic failure.
The log reports:

Mar 25 17:58:06 smtp postfix/smtpd[1002]: warning: SASL authentication failure: cannot connect to saslauthd server: No such file or directory
Mar 25 17:58:06 smtp postfix/smtpd[1002]: warning: SASL authentication failure: Password verification failed
Mar 25 17:58:06 smtp postfix/smtpd[1002]: warning: 172-1-0-1.lightspeed.hstntx.sbcglobal.net[<IP_ADDRESS>]: SASL PLAIN authentication failed: generic failure

Could somebody help me?
Thank you so much in advance!
Antonio

I don't know, if that is the root cause of your problem, however PERMIT_DOCKER should be empty, host or network, but not connected networks.
https://github.com/tomav/docker-mailserver/blob/b435c3866cd2cd55437901ecbb7544301c1de91f/env-mailserver.dist#L22-L29

I think you need to read up on ENABLE_SASLAUTHD and the related options in the readme. You have it on, but with SASLAUTHD_MECHANISMS empty which means authentication is with pam. Your added user will not be used; presumably only operating system users can send mail. If you want to use the added user you probably want ENABLE_SASLAUTHD=0 which will use Dovecot for authentication. In that case you cannot use SMTP_ONLY=1 as that prevents Dovecot from starting.
Please read through the docs carefully and plan your installation. This is a bit complex and when you stray off the beaten path to do something a little bit different you need to know how to set things up. Good luck!

No update for 15 days, does that mean this can be closed?

Closing due to inaction.


Colon-delimitation of commands in BROWSER is not respected

Projects with Storybook set up (which it seems uses better-opn) fail to start for me, unless I override BROWSER for the command. For a dozen years or more mine has been set to x-www-browser:www-browser.
I forget what prompted me to set it that way originally, and it's a bit hard to find documentation of exactly what BROWSER is supposed to be. After a bit of digging I found this Stackoverflow question which asks where the docs are, and one of the answers says

The BROWSER variable is not in the same league as EDITOR or PAGER - it is not mentioned by the standards. However, some programs may use them, like man:
man 1 man (Debian):
BROWSER
      If $BROWSER is set, its value is a colon-delimited list of  com-
      mands,  each  of  which  in  turn  is used to try to start a web
      browser for man --html.  In each command, %s is  replaced  by  a
      filename  containing  the HTML output from groff, %% is replaced
      by a single percent sign (%), and %c is replaced by a colon (:).

Right now when it's set with a colon-separated list, better-opn fails:
node:events:368
      throw er; // Unhandled 'error' event
      ^

Error: spawn x-www-browser:www-browser ENOENT
    at Process.ChildProcess._handle.onexit (node:internal/child_process:282:19)
    at onErrorNT (node:internal/child_process:477:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
Emitted 'error' event on ChildProcess instance at:
    at Process.ChildProcess._handle.onexit (node:internal/child_process:288:12)
    at onErrorNT (node:internal/child_process:477:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn x-www-browser:www-browser',
  path: 'x-www-browser:www-browser',
  spawnargs: [ 'http://localhost:6006/' ]
}

because I don't have anything called x-www-browser:www-browser.
To follow the way man uses the variable better-opn would try each of the commands in turn. If that's overkill, just splitting by colon then running the first one would be an improvement.

Hey @tremby, sorry for the late reply.
This definitely sounds reasonable to me given it appears to be a common convention in unix tooling.
Would you be open to contributing?


DownloadGitRepoResources function implementation should also handle variations of other devfile.yaml in its if-block

Which area this feature is related to?
/kind bug

Which area this bug is related to?

/area library
What versions of software are you using?
Go project
Operating System and version:
Go Pkg Version:
Node.js project

Operating System and version:
Node.js version:
Yarn version:
Project.json:
Web browser

Operating System and version:
Browser name and version:
Bug Summary
Describe the bug:

The DownloadGitRepoResources function implementation checks for devfile.yaml,
if !gitUrl.IsFile || gitUrl.Revision == "" || !strings.Contains(gitUrl.Path, OutputDevfileYamlPath) {
	return fmt.Errorf("error getting devfile from url: failed to retrieve %s", url)
}

The function should also handle various other possibilities of devfile.yaml like devfile.yml, .devfile.yaml, .devfile.yml...
To Reproduce:

Expected behavior

Function should be able to handle various devfile naming conventions.
Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

Additional context

devfile.yaml has a few naming conventions that is accepted like .devfile.yaml and devfile.yml. They should be considered along side devfile.yaml
Any workaround?

Suggestion on how to fix the bug

Need to add acceptance criteria for determining if the function affected should be auto-detecting or if the user is passing a devfile url and we are trying to parse it.

Need to add acceptance criteria for determining if the function affected should be auto-detecting or if the user is passing a devfile url and we are trying to parse it.

Looks like in the usage documentation at step 1 the entry point is devfilePkg.ParseDevfileAndValidate(parserArgs), this trickles down to the DownloadGitRepoResources function. I believe as a result this is going to take a user input for the devfile in an attempt to parse it.


missing var keyword for defaultProperties

fixes #826
One first step to tackle global pollution! ;)
I hope this PR doesn't come over as an insult :)

Thanks! By the way, in the future please make PRs to the devel branch :)


🐛 [firebase_app_check] Doesn't work on ios App Attest / Device Check

Bug report
Describe the bug
AppleProvider.deviceCheck and AppleProvider.appAttestWithDeviceCheckFallback doesn't not work on IOS 17.2. I tried both methods and both aren't working, all request are being blocked. On android App Check works without a problem.
Current package version of app check is 0.2.1+8.
I uploaded my app to Test Flight and from there I downloaded it to test the app.
Does someone has an idea what the issue could be?

@Epikur86
Is it only occuring while in release mode or occurs in debug mode as well ?
Can you provide the exact log you get while trying to call AppleProvider.deviceCheck and AppleProvider.appAttestWithDeviceCheckFallback ?

In debug mode it is working when providing a debug app check token. The app is currently in review for the app store and I disabled app check for this period to not interrupt the review process. But I get the a permission-denied error from firebase, is there another way to get a more detailed log?

I get the a permission-denied error from firebase

Can you provide the entire error log you get ? Along with permission-denied, it should also show a one liner description something like The caller does not have permission to execute the specified operation.

Hello,
I tried it on now with AppleProvider.debug on simulator and physical device with providing a debug token but both doesn't work on ios.
PlatformException (PlatformException(permission-denied, The caller does not have permission to execute the specified operation., {message: The caller does not have permission to execute the specified operation., code: permission-denied}, null)).
On Android it works perfectly fine in debug mode.
firebase_app_check:'^0.2.1+8'
`[✓] Flutter (Channel stable, 3.16.3, on macOS 14.2 23C64
darwin-arm64, locale de-DE)
• Flutter version 3.16.3 on channel stable at
/Users/artjomgyulnazarov/development/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision b0366e0a3f (4 weeks ago), 2023-12-05
19:46:39 -0800
• Engine revision 54a7145303
• Dart version 3.2.3
• DevTools version 2.28.4
[✓] Android toolchain - develop for Android devices (Android SDK
version 34.0.0)
• Android SDK at
/Users/artjomgyulnazarov/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: /Applications/Android
Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
17.0.7+0-17.0.7b1000.6-10550314)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15C65
• CocoaPods version 1.14.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google
Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2023.1)
• Android Studio at /Applications/Android
Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build
17.0.7+0-17.0.7b1000.6-10550314)
[✓] VS Code (version 1.85.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.80.0
[✓] Connected device (5 available)
• sdk gphone64 arm64 (mobile) • emulator-5554
• android-arm64  • Android 12 (API 32) (emulator)
• iPhone von Artjom (mobile)  • 00008120-000A1D042EB8201E
• ios            • iOS 17.2.1 21C66
• iPhone 15 Pro Max (mobile)  •
8D678EEF-1DB6-4C22-AA67-381BA71B5AEE • ios            •
com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)
• macOS (desktop)             • macos
• darwin-arm64   • macOS 14.2 23C64 darwin-arm64
• Chrome (web)                • chrome
• web-javascript • Google Chrome 120.0.6099.129
[✓] Network resources
• All expected network resources are available.`

I found the solution:
In the file GoogleService-Info.plist, a wrong GOOGLE_APP_ID was defined.


Fix for TEIIDTOOLS-172

Added text to the spinners that required explanation to help the user realize what was going on

Looks good - merging.


Error: JPEG error: marker was not found. Scanned from Samsung MFP.

Link to PDF file (or attach file here): scan.pdf
Configuration:

Web browser and its version: Chrome 56.0.2924.87 (64-bit) and Firefox 52.0.1 (64-bit)
Operating system and its version: Windows 10 64 bit and Ubuntu 16.10
PDF.js version: Stable 1.6.210 and Beta 1.7.225
Is an extension: No

Steps to reproduce the problem:

Upload the pdf to the Online demo site https://mozilla.github.io/pdf.js/web/viewer.html
All pages are blank

What is the expected behavior? PDF will be rendered properly

What went wrong? There are pages but no content.  In the developer console of the browser this is the logs:
PDF a650df87b150696f9e4415aeeaece60c [1.4 CLX-8380 Series / 300] (PDF.js: 1.7.378) pdf.worker.js:345 Error: JPEG error: marker was not found /pdf.js/build/pdf.worker.js:345 Error: JPEG error: marker was not found pdf.worker.js:346     at error (https://mozilla.github.io/pdf.js/build/pdf.worker.js:346:15)     at decodeScan (https://mozilla.github.io/pdf.js/build/pdf.worker.js:44260:5)     at JpegImage.parse (https://mozilla.github.io/pdf.js/build/pdf.worker.js:44637:22)     at JpegStream_ensureBuffer [as ensureBuffer] (https://mozilla.github.io/pdf.js/build/pdf.worker.js:3087:13)     at JpegStream_getBytes [as getBytes] (https://mozilla.github.io/pdf.js/build/pdf.worker.js:3094:8)     at PDFImage_getImageBytes [as getImageBytes] (https://mozilla.github.io/pdf.js/build/pdf.worker.js:42687:22)     at PDFImage_createImageData [as createImageData] (https://mozilla.github.io/pdf.js/build/pdf.worker.js:42619:26)     at https://mozilla.github.io/pdf.js/build/pdf.worker.js:25799:28 /pdf.js/build/pdf.worker.js:346     at error (https://mozilla.github.io/pdf.js/build/pdf.worker.js:346:15)     at decodeScan (https://mozilla.github.io/pdf.js/build/pdf.worker.js:44260:5)     at JpegImage.parse (https://mozilla.github.io/pdf.js/build/pdf.worker.js:44637:22)     at JpegStream_ensureBuffer [as ensureBuffer] (https://mozilla.github.io/pdf.js/build/pdf.worker.js:3087:13)     at JpegStream_getBytes [as getBytes] (https://mozilla.github.io/pdf.js/build/pdf.worker.js:3094:8)     at PDFImage_getImageBytes [as getImageBytes] (https://mozilla.github.io/pdf.js/build/pdf.worker.js:42687:22)     at PDFImage_createImageData [as createImageData] (https://mozilla.github.io/pdf.js/build/pdf.worker.js:42619:26)     at https://mozilla.github.io/pdf.js/build/pdf.worker.js:25799:28

I think this is also related with #8090 and #8104
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension): Tested using mozilla.github.io/pdf.js

Similar bug on version 52.0.2 not solved yet:
Warning: Unable to decode image: Error: JPEG error: marker was not found pdf.worker.js:2965:6
Warning: Dependent image isn't ready yet pdf.js:265:6
Error: JPEG error: marker was not found pdf.worker.js:2973:6
decodeScan@resource://pdf.js/build/pdf.worker.js:13800:8
parse@resource://pdf.js/build/pdf.worker.js:14162:25
JpegStream_ensureBuffer@resource://pdf.js/build/pdf.worker.js:23708:6

@joopeed can you confirm that the scan.pdf attached in OP produces the error you mentioned above?

Yes, I'm using version 52.0.2 of firefox, and the scan.pdf produces the error:
Error: JPEG error: marker was not found  pdf.worker.js:3841:11
decodeScan@resource://pdf.js/build/pdf.worker.js:14246:15
parse@resource://pdf.js/build/pdf.worker.js:14668:33
JpegStream_ensureBuffer@resource://pdf.js/build/pdf.worker.js:24613:11
JpegStream_getBytes@resource://pdf.js/build/pdf.worker.js:24620:11
PDFImage_getImageBytes@resource://pdf.js/build/pdf.worker.js:44455:20
PDFImage_createImageData@resource://pdf.js/build/pdf.worker.js:44378:32
PartialEvaluator_buildPaintImageXObject/<@resource://pdf.js/build/pdf.worker.js:47300:29
pdf.worker.js:3842:11
Warning: Unable to decode image: Error: JPEG error: marker was not found  pdf.worker.js:3830:11
Warning: Dependent image isn't ready yet  pdf.js:273:11
Error: JPEG error: marker was not found  pdf.worker.js:3841:11
decodeScan@resource://pdf.js/build/pdf.worker.js:14246:15
parse@resource://pdf.js/build/pdf.worker.js:14668:33
JpegStream_ensureBuffer@resource://pdf.js/build/pdf.worker.js:24613:11
JpegStream_getBytes@resource://pdf.js/build/pdf.worker.js:24620:11
PDFImage_getImageBytes@resource://pdf.js/build/pdf.worker.js:44455:20
PDFImage_createImageData@resource://pdf.js/build/pdf.worker.js:44378:32
PartialEvaluator_buildPaintImageXObject/<@resource://pdf.js/build/pdf.worker.js:47300:29
pdf.worker.js:3842:11
Warning: Unable to decode image: Error: JPEG error: marker was not found

This issue is fixed in ff55 -- see https://bugzilla.mozilla.org/show_bug.cgi?id=1352276


sherlock wrapper update

The sherlock wrapper needs updating for the new syntax of the alerts. Specifically, this code should be replaced with:
    for alert in alerts:
        diaObject = alert.get('diaObject')
        name = diaObject.get('diaObjectId')
        if not name in annotations:
            if not name in names:
                names.append(name)
                ra.append(diaObject['ra'])
                dec.append(diaObject['decl'])

Note that in the LSST schema, it is the diaObject that has RA and Dec that goes into Sherlock, whereas with ZTF there was no object and we just used the latest candidate ( i.e. diaSource)
I would make this change myself, but I can't find it is on lasair-lsst-dev-sherlock

Hi Gareth
Thank you for setting up the new branch [1] so that the sherlock wrapper can handle LSST alerts, in response to issue 39 [2]. I have a couple of questions:
(1) How does this code get executed? I know it goes into a docker container, but where does that happen? I can't see any clone of the repo on lasair-lsst-sherlock? What is the command to make the container from the code, and how does that new container get into the pipeline?
(2) Have you tried running it yet? I am not seeing the "ztf_sherlock" that would be the result of processing the "ztf_ingest" topic. Can we do that ASAP as the milestone is due at the end of this week?
(3) I note that you assume the incoming alert contains either a diaObject or a ssObject, is there a reference for this? My reading of the document [3] is that ssObjects arrive in a separate stream the next day. I would suggest we remove this assumption and just panic if we get an alert woth no diaObject. Besides, we are not paid for solar system object processing and have had no communication from those who are.
I have copied this message into the github issue
Roy
[1] https://github.com/lsst-uk/lasair-lsst/blob/feature/sherlock_wrapper_update/pipeline/sherlock/wrapper.py#L157-L172
[2] https://github.com/lsst-uk/lasair-lsst/issues/39
[3] https://docushare.lsst.org/docushare/dsweb/Get/LDM-612 section 2.2.2

The Dockerfile is in pipeline/sherlock/Dockerfile. The image needs to be rebuilt and the version in the playbook updated.
My reading of LDM-612 section 2.2, in combination with the [DPD] (https://lse-163.lsst.io/), is that alerts could be either a new diaObject, an existing diaObject or an existing ssObject. The bit that happens later is the detection of new ssObjects and they don't go into the main alert stream.

OK, we can leave in the dichotomy of diaObject / ssObject.
Yes I see the dockerfile in the github.


Pricing Alignment on Sheet log

Point 13
Test URLs:

Before: https://main--express--adobecom.hlx.page/de/express/pricing?lighthouse=on
After: https://pricing-align--express--adobecom.hlx.page/de/express/pricing?lighthouse=on

Also make sure you PR has lighthouse=on 😉

Codecov Report

Merging #198 (ed530b0) into main (1cd2c9f) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   35.68%   35.49%   -0.20%
==========================================
  Files          27       27
  Lines        9465     9465
==========================================
- Hits         3378     3360      -18
- Misses       6087     6105      +18

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@redvelvet511 could you please take a look at the linting error again?


Strategy: Upload bmp image and dataURL

ref: https://github.com/gyazo/gyazo-chrome-extension/issues/89
ref: https://github.com/gyazo/gyazo-chrome-extension/issues/86

If src is dataURL

dataURL is match image/jpg or image/png or image/gif
upload it to gyazo directly

if src is image but not jpg, png or gif format

convert it to png via canvas
upload

:+1:

I think we don't have to support bmp. they are too rare.

i want to upload webm :movie_camera:


Feature request: add shortcuts for tools of the image editor

I was thinking to make things more efficient with the image editor, maybe we could add shortcuts for the eraser and the pen, as well as the color picker?
B = brush
E = eraser
I = color picker (or whichever key you think fits best to it)
I was thinking this because it would make things more efficient.
hope you add this!

Good idea -- added hotkeys for all the tools.
Note color picker tool doesn't exist yet, and the brush's color selector is a placeholder (need a proper interface, browser default color picker sucks)


[package_info_plus] appName is always empty string on macOS and iOS

System info
Issue occurs on: iOS and macOS
Plugin name: package_info_plus
Plugin version: 1.0.6
Flutter doctor output:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.0.1 20B50 darwin-x64, locale ja-JP)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.1)
[✓] VS Code (version 1.59.1)
[✓] Connected device (4 available)

• No issues found!

Steps to Reproduce
demo app: https://github.com/tomoyuki28jp/package_info_plus_bug_sample

Analyzing foo...
No issues found! (ran in 2.5s)

[✓] Flutter (Channel stable, 2.2.3, on macOS 11.0.1 20B50 darwin-x64, locale ja-JP)
    • Flutter version 2.2.3 at /usr/local/lib/flutter
    • Framework revision f4abaa0735 (8 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/tomo/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.59.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.25.0

[✓] Connected device (4 available)
    • sdk gphone x86 arm (mobile) • emulator-5554                        • android-x86    • Android 11 (API 30) (emulator)
    • iPhone 8 (mobile)           • 9845607F-FC30-4645-9BDB-BAB9E0B00E59 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)             • macos                                • darwin-x64     • macOS 11.0.1 20B50 darwin-x64
    • Chrome (web)                • chrome                               • web-javascript • Google Chrome 92.0.4515.159

• No issues found!

It looks like the code for iOS is pulling from CFBundleDisplayName but I see my app doesn't use that plist property. It only has CFBundleName. I imagine iOS uses CFBundleDisplayName if present, otherwise CFBundleName. Haven't had a chance to test this yet though.

@tomoyuki28jp As the package currently uses CFBundleDisplayName to get the app name, you probably need to add that in both your iOS and macOS Info.plist files, like the following example.
	<key>CFBundleDisplayName</key>
	<string>Put Your App Name Here</string>

@cjwhitsitt I tried to create a new flutter project, and I found out that CFBundleDisplayName is not added when the project is created. So you would probably have to look into the Info.plist file and add it if necessary. In the meantime, will try to investigate and change CFBundleDisplayName to CFBundleName.
Hope that helps 👍

@mhadaily seems like it is fixed with last merged PR or not yet?


random string in custom intent

Hi,
I have a question, why can't a random string be used as part of an intent as was the case with the text ingredient option in IFTTT ? Let me clarify with an example.
I would like to create a custom intent that will add some stuff to a shopping list via a service call in home assistant.
However now I need to define a fixed list of items that can appear in the sentence.
In my opinion it should be possible to setup a custom sentence like this: "add <text> to my shopping list". the text part will then be passed along to the intent_script which then can use this as, for example, a variable when calling a script.
I can imagine that there would be more false positive/negatives this way but that should be something people should be aware of when using this functionality.

This is something that will require changes to the algorithm, but it is planned to be added (specifically for shopping lists).

Damn, i just made a really cool node-red flow & wanted to trigger it using intents.. T_T
Can't wait for this feature!

Can't wait for this feature

In the meantime I am using a temporary workable solution.
I copied the conversation files to "/config/custom_components/conversation", and then changed line 184 in "default_agent.py" to be "warning" rather than "debug".
Then I put the following in "configuration.yaml" so that warnings and errors would generate an event.
system_log:
  max_entries: 200
  fire_event: true

After a restart, Node Red can listen "system_log_event" using an events: all node. If you say something like "buy white bread", which HA doesn't understand, it will now fire an event including "No intent was matched for ' Bye! White bread!'". So you can extract the part in single quotes and deal with "buy" vs "bye" vs "by" (and even sometimes "five" and "byebye").
Obviously HA is still going to say "I don't understand", but I'm using an old-style telephone and I hang up before that happens.
You also need to deal with the fact that "default_agent.py" is likely to change and you have to update manually. I'm tempted to automate tracking changes for this file, if it goes on for long enough.

hi I've created a agent that can parse regex sentences to trigger custom intents. when no matches found the default agent will be triggered. Have a look here: https://github.com/siemon-geeroms/yarvis. you can add it as a custom integration via the hacs store. just need to add my repo as a custom repo. please be aware the is my first attempt to write a custom component and in early stages of development

Wildcards are being added here: https://github.com/home-assistant/hassil/pull/56


Enable DNS tests when windows nodes are present

What this PR does / why we need it:
Starts to improve the windows e2e tests for kubernetes from issue #3632.
This PR does the following:

Include a linux agent node in the windows end to end tests. This will enable testing of other scenarios down the line such as testing dns works accross linux and windows pods.
Enable DNS checks that are disabled during windows only tests.
added stability to a windows File mount tests when it is run continuously (during dev work)

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@PatrickLang could you do a review?

/lgtm
Thanks, especially for reenabling those other tests. That was on the backburner and I forgot about it.

@jsturtevant can you rebase to fix the merge conflict?

@PatrickLang fixed the merge conflict.  ready for review again

/lgtm

/assign @CecileRobertMichon

/lgtm


Add finduser methods and template

Dear friends, I wrote a beautiful method that takes a name for search and finds 5 best accounts relevant to that query then it prints last tweets of that 5 accounts. It seems to be working well on my local. Please review it and accept the appropriate parts.
You can review it's screenshot from here.

Can you rename simple_page.html to something specific to your API endpoint?

can you refer to #48 then make your request again?

@cerob  I think it's ready now. Can you check once more before approving my pull request? Thanks, in advance.

There is a small problem. you've edited your template file, but why copied base.html into it? You don't need to do that. That's why we use template inheritance.


Get the following error in lodash/index.js when running on a tessel device

This is probably not a fault in your  library.
[string "colony-node.lua"]:1: /app/node_modules/amqp10/node_modules/lodash/index.js:627: function at line 627 has more than 200 local variables
/dag

@buzzfrog that seems weird, are you running it through some kind of linter? Where does the error originate from?

Basically the Tessel (similar to the Pi) runs the Javascript through a Lua interpreter, and that Lua interpreter has some limitations.  Not being able to support Lodash is a big bummer, though, as so many modules use it :(

@noodlefrenzy hmm https://github.com/tessel/runtime/issues/682
Looks like they are focusing more on Tessel 2? This is truly unfortunate..


question about nuxt start  -> window.NUXT

after I start it through nuxt start, <script>window.__NUXT__=(function(a,b,c,d,e,f){b[0]= always appears on the html page,
after trying to remove, the data will not be rendered,
how to solve this problem?

It is necessary to transfer the state from the server to the client. You cannot remove it, otherwise your app won't work.


Bot says "can't comment because of Filters"

Hey there,
I have allowed the bot to comment. (So I removed the # in the original config)
I also filled the file with the comments for photos, carousel and videos.
Now it is displayed during the run:
WARNING | Can't comment this MediaType.PHOTO because filters are: can_comment_photos = False, can_comment_videos = False, can_comment_carousels = False, can_comment_blogger = False. Check your filters.yml.
In the filter file, however, all entries are set to "true":
comment_photos: true
comment_videos: true
comment_carousels: true
comment_blogger: true
What am I missing?

try : copy file : filter.yml, config.ym , etc >> to folder /accounts/yourusername/

Hey there,
I will show the issue in a better way:
Die Arbeitsdateien liegen in einem Ordner mit meinem Nutzernamen.
Also starte ich den Bot wie folgt: python run.py --config C:\Users\Benutzer\Desktop\bot-master\username\config.yml
meine config Datei sieht folgendes vor:
username: username # you have to put your IG name here!
device: <IP_ADDRESS>:11111 # 'adb devices' in the console to know it.  It's needed only if you have more than 1 device connected
app-id: com.instagram.android
use-cloned-app: false
allow-untested-ig-version: false # Using an untested version of IG would cause unexpected behavior because some elements in the user interface may have been changed
screen-sleep: true
screen-record: false
speed-multiplier: 4
debug: false
close-apps: false
disable-block-detection: false
disable-filters: false
dont-type: false
scrape-to-file: scraped.txt
total-crashes-limit: 5
count-app-crashes: false
shuffle-jobs: true
truncate-sources: 2-5
##############################################################################
Actions
##############################################################################
Interaction (active jobs)
blogger-followers: [ username1, username2 ]
blogger-following: [ username1, username2 ]
blogger-post-likers: [ username1, username2 ]
blogger: [ username1, username2 ]
hashtag-likers-top: [Hashtag1, Hashtag2]
hashtag-likers-recent: [ Hashtag1, Hashtag2 ]
hashtag-posts-top: [ Hashtag1, Hashtag2 ]
hashtag-posts-recent: [ Hashtag1, Hashtag2 ]
place-posts-top: [ Ort1, Ort2 ]
place-posts-recent: [ Ort1, Ort2 ]
place-likers-top: [ Ort1, Ort2 ]
place-likers-recent: [ Ort1, Ort2 ]
interact-from-file: [usernames1.txt 10-15, usernames2.txt 3]
posts-from-file: posts.txt
feed: 2-5 # is the number of likes you will give in feed
Special modifier for jobs and sources
watch-video-time: 5-15
watch-photo-time: 3-4
can-reinteract-after: 48 # the amount of hours that have to pass from the last interaction
delete-interacted-users: true
Unfollow (unfollow jobs)
unfollow: 20
unfollow-any: 20
unfollow-non-followers: 10-20
unfollow-any-non-followers: 10-20
unfollow-any-followers: 0
Special modifier for unfollow jobs
sort-followers-newest-to-oldest: false
unfollow-delay: 15
Special actions
pre-script: pre_script_path_here
post-script: post_script_path_here
##############################################################################
Source Limits
##############################################################################
interactions-count: 30-40
likes-count: 1-2
likes-percentage: 100
stories-count: 1-2
stories-percentage: 30-40
carousel-count: 2-3
carousel-percentage: 60-70
max-comments-pro-user: 1-2
comment-percentage: 40-60
pm-percentage: 30-40
interact-percentage: 30-40
follow-percentage: 30-40
follow-limit: 50
skipped-list-limit: 10-15
skipped-posts-limit: 5
fling-when-skipped: 0
min-following: 100
##############################################################################
Total Limits Per Session
##############################################################################
total-likes-limit: 120-150
total-follows-limit: 40-50
total-unfollows-limit: 40-50
total-watches-limit: 120-150
total-successful-interactions-limit: 120-150
total-interactions-limit: 280-300
total-comments-limit: 3-5
total-pm-limit: 3-5
total-scraped-limit: 100-150
##############################################################################
Ending Session Conditions
##############################################################################
end-if-likes-limit-reached: true
end-if-follows-limit-reached: false
end-if-watches-limit-reached: false
end-if-comments-limit-reached: false
end-if-pm-limit-reached: false
If I start the Bot everysthing is working. Only commenting doesn´t work.
The bot shows:
WARNING | Can't comment this MediaType.PHOTO because filters are: can_comment_photos = False, can_comment_videos = False, can_comment_carousels = False, can_comment_blogger = False. Check your filters.yml
Okay, let´s check the filters.yml =
Filters on profile type
skip_if_private: false
skip_if_public: false
skip_business: true
skip_non_business: false
skip_following: false
skip_follower: false
skip_if_link_in_bio: false
follow_private_or_empty: false
Filters on profile stats
min_followers: 50
max_followers: 25000
min_followings: 50
max_followings: 25000
min_potency_ratio: 0.5
max_potency_ratio: 5
min_posts: 3
mutual_friends: -1 # -1 for ignore that filter
Filters on biography and name
blacklist_words: [sex, link,]
mandatory_words: [cat, dogs,]
specific_alphabet: [LATIN, GREEK]
biography_language: [it, en]
biography_banned_language: [es]
Filters for enabling comments
Action specific
comment_hashtag_likers_top: true
comment_hashtag_likers_recent: true
comment_hashtag_posts_top: true
comment_hashtag_posts_recent: true
comment_place_likers_top: true
comment_place_likers_recent: true
comment_place_posts_top: true
comment_place_posts_recent: true
comment_blogger_followers: true
comment_blogger_following: true
comment_blogger_post_likers: true
comment_blogger: true
comment_interact_usernames: true
comment_interact_from_file: true
comment_feed: true
Content specific
comment_photos: true
comment_videos: true
comment_carousels: true
Filters for sending PM
pm_to_private_or_empty: true
Filters on number of post likers
min_likers: 1
max_likers: 1000
This file is also in "username"-Folder.
My sources:
device = MEmu / Android Version 9
IG Version = 2<IP_ADDRESS>.104


Multiple sequential modals only work when replaced

Dismissing a TurboNavPresentationContext.MODAL visit by performing a DEFAULT context visit breaks the app when there's more than 1 MODAL context visit in the backstack.
Suppose we have this configuration.json:
{
  {
    "patterns": [ ".*" ],
      "properties": {
        "context": "default",
        "uri": "turbo://fragment/web"
      }
  },
  {
    "patterns": [ "/tasks/wizard/" ],
    "properties": { "context": "modal" }
  }
}

This sequence of visits works as expected:
/
/tasks
/tasks/wizard/step-1
/tasks

However, if we have this sequence of visits...
/
/tasks
/tasks/wizard/step-1
/tasks/wizard/step-2
/tasks

The app doesn't properly replace the underlying /tasks fragment. What seems to happen instead is that it tries to go back to /tasks/wizard/step-1 and breaks.
Here's a video for demonstration:
https://user-images.githubusercontent.com/25386350/156970441-ed353ecf-9d9c-4126-a847-aeadb48d31dc.mov
That can be 'fixed' it by adding this rule:
{
  "patterns": [ "/tasks/wizard/step-2$" ],
  "properties": { "presentation": "replace" }
}

Unfortunately, this means that if you're in a multi-step form, and you remember something you needed to change in the previous form, you'll then have to close the entire form and start again.

Looking into the navigation code, I noticed that the behaviour achieved with subsequent wizard steps performing a replace is totally independent of presentation context, as per TurboNavRule:64


Value Error (not enough values to unpack) in pool.py

https://github.com/uber/fiber/blob/b9d519ebfd572e49af7f1c6a235d19d4396207cb/fiber/pool.py#L908
I am getting the following error: ValueError: not enough values to unpack (expected 3, got 2) on line 908 in pool.py.
The error is being raised when I am calling fiber using docker as the backend.
This the command I am using to call the script: FIBER_BACKEND=docker FIBER_IMAGE=docker-test:latest python test_fiber_docker.py

Can you provide a minimized test case (don't need to provide all of test_fiber_docker.py, just enough to reproduce this error)? Also, what OS are you running and what python version are you using?

Can you provide a minimized test case (don't need to provide all of test_fiber_docker.py, just enough to reproduce this error)? Also, what OS are you running and what python version are you using?

Here is a minimized test case for reproducing the error:
import ludwig
import yaml
from ludwig.hyperopt.run import hyperopt

filename="config_docker.yaml"
file_path="goemotions.csv"

with open(filename) as f:
    file_contents = yaml.load(f, Loader=yaml.SafeLoader)

model_config = file_contents
hyperopt_results = hyperopt(
                model_config,
                dataset=file_path,
                model_name="goemotions_bert",
                output_directory="."
            )

Here is the contents of config_docker.yaml:
input_features:
- encoder: bert
  level: word
  name: text
  preprocessing:
    pretrained_model_name_or_path: bert-base-uncased
    word_tokenizer: hf_tokenizer
  type: text
output_features:
- name: emotion_ids
  type: set
hyperopt:
  sampler:
    type: random
    num_samples: 50
  executor:
    type: fiber
    num_workers: 10
    fiber_backend: docker
    num_cpus_per_worker: 2

My OS is: Darwin 18.7.0 Darwin Kernel Version 18.7.0
Python version: Python 3.7.7
Let me know if you need any more info!

Here is a minimized test case for reproducing the error:
import ludwig
import yaml
from ludwig.hyperopt.run import hyperopt

filename="config_docker.yaml"
file_path="goemotions.csv"

with open(filename) as f:
    file_contents = yaml.load(f, Loader=yaml.SafeLoader)

model_config = file_contents
hyperopt_results = hyperopt(
                model_config,
                dataset=file_path,
                model_name="goemotions_bert",
                output_directory="."
            )

Here is the contents of config_docker.yaml:
input_features:
- encoder: bert
  level: word
  name: text
  preprocessing:
    pretrained_model_name_or_path: bert-base-uncased
    word_tokenizer: hf_tokenizer
  type: text
output_features:
- name: emotion_ids
  type: set
hyperopt:
  sampler:
    type: random
    num_samples: 50
  executor:
    type: fiber
    num_workers: 10
    fiber_backend: docker
    num_cpus_per_worker: 2

My OS is: Darwin 18.7.0 Darwin Kernel Version 18.7.0
Python version: Python 3.7.7
Let me know if you need any more info!

I think the problem is at docker_backend.py:195
        if sys.platform == "darwin":
            # use the same hostname for both master and non master process
            # because docker.for.mac.localhost resolves to different inside
            # and outside docker container. "docker.for.mac.localhost" is
            # the name that doesn't change in and outside the container.
            return "docker.for.mac.localhost", 0

it returns two elements.
But after I modify it, I still can not run through all the test on the MAC OS.

Hi @Basasuya , Fiber current doesn't work on Mac OS with Docker, see doc. But yeah, the return value is a bug that needs to be fixed.


Bring Mersenne Twister code into morphologica

This is the rng.h in AttractorScaffolding, BUT, it needs to be modified so that it can generate 64 bit random numbers; at present it is a 32 bit implementation.

Consider also incorporating siderand to obtain entropy from the CPU.

See "Stronger Cryptography For Every Device, Everywhere" by J V Roig.

Maybe use "SIMD-Oriented Fast Mersenne Twister: a 128-bit Pseudorandom Number Generator" by  Mutsuo Saito & Makoto Matsumoto

...which is https://doi.org/10.1007/978-3-540-74496-2_36

...code here: http://www.math.sci.hiroshima-u.ac.jp/~m-mat/MT/SFMT/index.html#SFMT

Update: C++-11 has nice random number generators, so this should be "Wrap C++-11 in some convenience functions"

Fixed, with addition of Random.h.


Improving Preloader

Description
The current Loading has no preloader. The screen becomes blank when the website loads. Enhancing the preloader, and improving the styling of the preloader design would greatly improve the user experience and website presentation
Tasks:
Redesign the preloader for better visual appeal.
Improving the preloader.
@vivekvardhan2810  can you assign this issue to me with labels "gssoc-ext" with levels ,"hacktoberfest-accepted";

we don't need this for now, so i am closing this issue.


[feature request] Add hcl support for PackerBuild@1

Note
same request as #14966 which has been closed without action
For a list:
HCL2 is the preferred way to write Packer templates with latest Packer version. Please add support for HCL2 templates.
Required Information
Type: Feature
task name:  PackerBuild@1 (or could be v2 if add this feature)
Environment
any, feature is not exist yet
Issue Description
not support hcl template

any upates?

we're still waiting for any response from the support team

Is there a reason why we still don't have HCL2 support a year after this request was placed?

we're still waiting for any response from the support team

This feature should absolutely be added. Seems quite simple to implement. Why is there no news about this issue?

Any update on this one?

Any updates on this one for 2024? As mentioned on Packer docs the hcl would be preferred format going forward so wouldn't like to convert our Packer files to deprecated JSON format.

As of version 1.7.0, HCL2 is the preferred way to write Packer templates.

At least a configuration parameter which skips the "packer fix" command could be integrated


Remove inconsistent xml-model processing instructions

This pull request derives from #350. So needs to be handled after that.

Some files have xml-model processing instruction. But they are inconsistent:

Some files have it. The others do not have it.
src/schematron/schut-to-xspec.xsl specifies a wrong type of schema.
Some files (test/schematron-014.xspec for instance) specify an incorrect path.

This pull request removes all xml-model, because

The existing instances of xml-model have errors as listed above.
Decent XML editors such as oXygen should be able to associate schema without xml-model.
If xml-model is really necessary, it should be added to all the files in a consistent manner.

@cirulls
Merged this bug fix.


Question about the how to set parameters for removing ground plane points?

Hi, thanks for your nice work.
I read your paper and found that you remove uninformative ground plane points with z coordinate below −0.9 m for the MulRan dataset and −1.6 m for the Apollo dataset. May I know how to set the parameters for removing ground plane points when I use other 3D point cloud data?
Thanks in advance.

Hi,
z_threshold depends on the LiDAR position with respect to the ground plane (the road).
For some datasets, you can get this value from extrinsic parameters included in the dataset. For others, you can find it by trial and error.
For Mulran and Apollo_SouthBay, we took a trial and error approach. We just tried different values of z_threshold - and for each z_threshold, we made a visualization of a few exemplary point clouds with all points with z-coordinates below z_threshold removed. When z_threshold was too low, a lot of ground plane points were visible. When it was too high, too many points from buildings were removed.


Add version check to Python package

This adds a best effort version check to the Python package. On import it will try to check pypi.org for the latest version and compare it to the metadata for the currently installed version. It uses a 3 second timeout for the check and will catch and ignore any failures so that it doesn't interfere with using the package. The message to users is displayed on stderr to avoid having it show up along with normal script output while still showing on first import in a jupyter environment.

I don't think we should include this, but if we have to, we should write some kind of file to disk to remember the last update check and only do the check once a day. Many users will hit the 3-second timeout every single time they run a script, I guarantee it.

I think that's a fair concern. I think it's worth tabling this for now, but I would like to pull out just the __version__ property part and have that merged. Does that seem reasonable? Having that property set would be nice for those who expect it.

Seems reasonable, __version__ appears to be standard. I think you may need to export it explicitly through __all__ for qsharp.__version__ to work, not sure.

@swernli nevermind - the PEP I was looking at says "rejected" on top. https://peps.python.org/pep-0396/#pep-rejection . This stackoverflow answer has some commentary. https://stackoverflow.com/questions/72167802/adding-version-attribute-to-python-module . So maybe it's not a great idea?

@swernli nevermind - the PEP I was looking at says "rejected" on top. https://peps.python.org/pep-0396/#pep-rejection . This stackoverflow answer has some commentary. https://stackoverflow.com/questions/72167802/adding-version-attribute-to-python-module . So maybe it's not a great idea?

Yeah, I was reading some of the same links. From what I gather, it's an informal convention many libraries follow but is not part of any formal specification, so it's totally optional. Given that a user can just themselves call importlib.metadata.version('qsharp') and get the same info, it's definitely not critical. That said, the property is something a lot of other packages do, so I could be convinced either way.

I'm just going to drop this for now. If this ends up being a customer pain point (out of date pip packages) we can circle back to exploring how to address it.

I don't think we should include this, but if we have to, we should write some kind of file to disk to remember the last update check and only do the check once a day. Many users will hit the 3-second timeout every single time they run a script, I guarantee it.

Did we look at what 'pip' itself does? Being that it also gives a similar message, and is far more used than we will be, I'm guessing they've dealt with any major feedback on impact.

Did we look at what 'pip' itself does? Being that it also gives a similar message, and is far more used than we will be, I'm guessing they've dealt with any major feedback on impact.

The difference in my mind is that pip is a command-line tool, but qsharp is a library (more comparable to something like numpy IMO) . pip interacts with pypi by definition. I don't think it's a great comparison.
I also mentioned to @swernli about this: We did talk about evolving our Python package into a more full-featured CLI tool. I think an update check would be perfectly appropriate for such a tool. But I don't think qsharp is it, in its current form. It's a small, fast, library.


License agreement of pretrained models

What are the licensing terms for pretrained models specified in Model Zoo, I am specifically interested in TableBank. As per their website(https://github.com/doc-analysis/TableBank/blob/master/MODEL_ZOO.md) model and data can not be commercially used. However layout-parser is distributed under Apache 2.0, does it mean the TableBank listed here https://layout-parser.readthedocs.io/en/latest/notes/modelzoo.html#model-catalog falls under Apache 2.0 license.

Thanks! That's great point! We need to add the appropriate notes for the license for the models. And in the future I believe we can release a version of table detection models with the compatible license.

It's great to know that the DocBank/TableBank authors have updated their license to Apache 2.0. And I've checked all other models and they all support for the Apache 2.0 license. I'll keep an eye on the license issue in the future. Thanks!


C# Tutorial: Asynchronous Server Programming

#This issue tracks the creation of this topic: https://github.com/dotnet/docs/blob/master/docs/csharp/tutorials/asynchronous-server-programming.md
This tutorial should explain techniques for starting asynchronous tasks, monitoring those tasks, and reporting progress.
This tutorial should also explore why offloading CPU bound work using Task.Run() in a server context is often an anti-pattern. More importantly, other recommended techniques should be explained.
Consider ValueTask, and caching completed Task results. Make sure to cover why async void is bad, and how to avoid using it in server based scenarios.

This issue has been closed as part of the issue backlog grooming process outlined in #22351.
That automated process may have closed some issues that should be addressed. If you think this is one of them, reopen it with a comment explaining why.

This issue has been closed as part of the issue backlog grooming process outlined in #22351.
That automated process may have closed some issues that should be addressed. If you think this is one of them, reopen it with a comment explaining why.


DEVINF-124: Allow overriding the audit field value formatter (take 2)

(this is the second version of https://github.com/kenshoo/persistence-layer/pull/57)
In Skai we enabled the auditing for a certain entity, and we saw that the default formatting of audited field values is not sufficient since it is not backwards-compatible.
The default uses the PL string value converter of the entity, but we have a different logic that existed before.
To handle this, I am extending the mechanism by allowing the PL client to override the default formatting.
This can be accomplished by setting a new optional parameter valueFormatter  in the @Audited annotation.
If specified, the value formatter will override the default logic above. It can be placed at either the field level or entity-level. If both have it, the field-level overrides the entity-level.
In more detail:

Added a new interface AuditFieldValueFormatter, plus a parameter valueFormatter of this type to @Audited

Added a default implementation DefaultAuditFieldValueFormatter which has the same logic as we had until now: It formats according to  the String ValueConverter of the entity (if exists), and if not - falls back to the string representation.

Added a custom implementation DBAuditFieldValueFormatter which formats according to the DB value. This value can be different than the entity value, if the field has a custom ValueConverter.
NOTE that a field can have two converters: The one we are talking about here is responsible for converting to/from the DB value, and is not the same as the String ValueConverter mentioned above. Refer to the AbstractEntityType.field(...) methods for details.
This custom impl is the one needed by Skai.

Refactored the code which generates the audited field data, so that it also resolves and stores the value formatter (before running the flow)

For external fields (see ExternalAuditedField), the value formatter has been also added as an optional member. If not specified, it will default to the formatter of the underlying field (in the external entity). If the underlying field is not itself audited (in its own entity) - it will simply default to the string representation.

Still TBD - a few unit tests and all of the integration tests
Usage examples:

Setting a custom formatter at the entity level:

@Audited(valueFormatter = MyValueFormatter.class)
public class MyEntity extends AbstractType<MyEntity> {
      // ....
}

Setting a custom formatter at the field level:

@Audited
public class MyEntity extends AbstractType<MyEntity> {
      // ...

      @Audited(valueFormatter = MyValueFormatter.class)
      public static final EntityField<MyEntity, String> NAME = INSTANCE.field(MyTable.INSTANCE.name);
}

Setting a custom value formatter for an external field:

public class MyAuditExtensions implements AuditExtensions {

    @Override
    public Stream<? extends ExternalAuditedField<?, ?>> externalMandatoryFields() {
        return new ExternalAuditedField.Builder(MyParentEntity.NAME)
                                       .withValueFormatter(new MyValueFormatter())
                                       .build();
    }
}

@Audited(extensions = MyAuditExtensions.class)
public class MyEntity extends AbstractType<MyEntity> {
      // ...
}

@effiban
Looks very good


Can't sensibly cite more than one unpublished manuscript by same author

Hello,
Suppose that I have two citation keys, @dobbsmsa and @dobbsmsb.  They are two unpublished manuscripts by the same author, with different titles.  Now suppose I want to cite both:
In recent essays Dobbs [-@dobbsmsa, p. 1; -@dobbsmsb, pp. 2--3] ...

This will produce "In recent essays Dobbs (n.d., 1, 2--3)" which suggests I'm referring to two pages from the same work.  What I want is something like this: "Dobbs (n.d. a, 1, n.d. b, 2--3)".
I'm not sure if this issue is actually in pandoc-citeproc or somewhere else in the toolchain, so please excuse me if I'm filing in the wrong place.

You might try a few different styles to see if this is a
style-dependent issue or a pandoc-citeproc one.

Hello,
On Fri, Mar 09 2018, John MacFarlane wrote:

You might try a few different styles to see if this is a
style-dependent issue or a pandoc-citeproc one.

From the upstream styles repo, british-journal-of-political-science.csl
and chicago-author-date.csl show the bug, while university-of-york-chicago.csl
does not.
I don't think this really reveals whether or not it is a pandoc-citeproc
bug, because it is possible that the bug is triggered by certain styles,
or that it is present in both british-journal-of-political-science.csl
and in chicago-author-date.csl.
--
Sean Whitton

I wasn't able to reproduce this in chicago-author-date.csl (pandoc-citeproc's built-in default).
Can you post a minimal example that suffices to reproduce it?

Okay, I was able to reproduce.
% pandoc 325.md -F pandoc-citeproc -t plain
(Wright, n.d.; Wright, n.d.)

Wright, Sewall. n.d. “Title.”

———. n.d. “Title2.”

where 325.md is
---
references:
- id: my2
  type: manuscript
  author:
  - family: Wright
    given: Sewall
  title: Title
  page: 1-2

- id: my1
  type: manuscript
  author:
  - family: Wright
    given: Sewall
  title: Title2
  page: 395-420
...

[@my1; @my2]

Hello,
On Sun 14 Oct 2018 at 03:16PM -0700, John MacFarlane wrote:

Closed #325 via e3bfecd95bf34cb95226270e1bc995e7fd884824.

Thank you!
--
Sean Whitton


Add light platform for Yeelight Sunflower lights

Description:
Add new platform for the light component for Yeelight Sunflower bulbs (https://www.yeelight.com/en_US/product/yeelight-sunflower).
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#2006
Example entry for configuration.yaml (if applicable):
light:
  - platform: yeelightsunflower
    host: <IP_ADDRESS>

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

Could write tests for this platform?
You can mock out the yeelightsunflower lib.

@andrey-git - I'm happy to write tests, but I haven't done that before and similar platforms (e.g. yeelight) don't have tests, do they? I added my platform to .coveragerc along with many others that don't have tests. If it's expected, please point me to a best practice example similar enough to mine, thank you!

Sorry, but I don't understand what's happening with rebase. I followed https://home-assistant.io/developers/development_catching_up/ (git rebase upstream/dev) and did a rebase, not merge. Now my PR has many commits and files that are not mine.
Should I do a new PR and then never rebase after during future PR processes?

I'm no git expert, but I always do
git pull upstream dev
If there are conflict a resolve them and commit.

New PR for this platform: https://github.com/home-assistant/home-assistant/pull/6060
(I won't try and rebase my fork until this is merged)


Store impersonated_user in RequestStore instead of Thread

Also includes plugin name fix from https://github.com/markedagain/redmine_impersonate/commit/33be8a33f4dcb58a5251a20bcfe079ef4c6199b6

Thanks !


Relax tree-sitter version bounds to include 0.20.x

Hi there! I've been happily using the rust crate provided by this repo for the last month or so. I've noticed that the version of tree-sitter pinned here (0.19.5) is a bit behind the latest release (0.20.1). This PR relaxes the version bounds to include the old 0.19.5 and 0.20.x both.
Based on my own testing with version 0.20.1 this doesn't result in any problems.

Any reason to not just update completely? I'm not sure if the cargo file get's generated at build time, has been some time since I last did it.

Do you mean update the Cargo.lock file? Curiously it already contains 0.20.1, and running cargo update did not result in any changes there!

Sorry, I don't completely understand your question. Can you expand on what you mean by 'update completely'? Do you mean pinning the tree-sitter dependency to 0.2.1 exactly?

I've done the update here https://github.com/elm-tooling/tree-sitter-elm/pull/108 but turns out, there is a regression in an error case.

Oh, I see now. Will close this PR either way, since yours is much more comprehensive!

Thank you for pushing me to get this updated ;)

I didn't do much! Thank you for doing the work!