Production build fails with message "Cannot read property 'input' of null"

OS?
node:6.9.4 docker container
Versions.
<EMAIL_ADDRESS><EMAIL_ADDRESS>Repro steps.
After an upgrade to 1.0.0-beta.26 from 1.0.0-beta.24 the app fails to build.
Build always starts with a clean docker container in which the following steps are run:
FROM node:6.9.4
WORKDIR /root/
RUN npm install<EMAIL_ADDRESS>-g
COPY package.json ./package.json
RUN npm install
COPY src ./src/
COPY e2e ./e2e/
COPY angular-cli.json ./angular-cli.json
COPY protractor.conf.js ./protractor.conf.js
COPY karma.conf.js ./karma.conf.js
COPY tslint.json ./tslint.json
RUN ng build --prod
Prod build works when running on the development machine with Windows 7
The log given by the failure.
Cannot read property 'input' of null
TypeError: Cannot read property 'input' of null
at ObjectSchemaTreeNode._set (/root/node_modules/@ngtools/json-schema/src/sc
hema-tree.js:347:132)
at new ObjectSchemaTreeNode (/root/node_modules/@ngtools/json-schema/src/sch
ema-tree.js:331:14)
at OneOfSchemaTreeNode.NonLeafSchemaTreeNode._createChildProperty (/root/nod
e_modules/@ngtools/json-schema/src/schema-tree.js:244:24)
at /root/node_modules/@ngtools/json-schema/src/schema-tree.js:260:26
at Array.map (native)
at new OneOfSchemaTreeNode (/root/node_modules/@ngtools/json-schema/src/sche
ma-tree.js:259:48)
at ArraySchemaTreeNode.NonLeafSchemaTreeNode._createChildProperty (/root/nod
e_modules/@ngtools/json-schema/src/schema-tree.js:244:24)
at ArraySchemaTreeNode._set (/root/node_modules/@ngtools/json-schema/src/sch
ema-tree.js:434:39)
at new ArraySchemaTreeNode (/root/node_modules/@ngtools/json-schema/src/sche
ma-tree.js:414:14)
at ObjectSchemaTreeNode.NonLeafSchemaTreeNode._createChildProperty (/root/no
de_modules/@ngtools/json-schema/src/schema-tree.js:244:24)
at ObjectSchemaTreeNode._set (/root/node_modules/@ngtools/json-schema/src/sc
hema-tree.js:347:47)
at new ObjectSchemaTreeNode (/root/node_modules/@ngtools/json-schema/src/sch
ema-tree.js:331:14)
at ArraySchemaTreeNode.NonLeafSchemaTreeNode._createChildProperty (/root/nod
e_modules/@ngtools/json-schema/src/schema-tree.js:244:24)
at ArraySchemaTreeNode._set (/root/node_modules/@ngtools/json-schema/src/sch
ema-tree.js:434:39)
at new ArraySchemaTreeNode (/root/node_modules/@ngtools/json-schema/src/sche
ma-tree.js:414:14)
at RootSchemaTreeNode.NonLeafSchemaTreeNode._createChildProperty (/root/node
_modules/@ngtools/json-schema/src/schema-tree.js:244:24)
at RootSchemaTreeNode.ObjectSchemaTreeNode._set (/root/node_modules/@ngtools
/json-schema/src/schema-tree.js:347:47)
at RootSchemaTreeNode.ObjectSchemaTreeNode [as constructor] (/root/node_modu
les/@ngtools/json-schema/src/schema-tree.js:331:14)
at new RootSchemaTreeNode (/root/node_modules/@ngtools/json-schema/src/schem
a-tree.js:478:16)
at GeneratedSchemaClass.SchemaClassBase (/root/node_modules/@ngtools/json-sc
hema/src/schema-class-factory.js:66:29)
at new GeneratedSchemaClass (/root/node_modules/@ngtools/json-schema/src/sch
ema-class-factory.js:165:20)
at new CliConfig (/root/node_modules/angular-cli/models/config/config.js:24:
24)
at Function.CliConfig.fromConfigPath (/root/node_modules/angular-cli/models/
config/config.js:99:16)
at Function.CliConfig.fromProject (/root/node_modules/angular-cli/models/con
fig.js:63:44)
at Class.run (/root/node_modules/angular-cli/tasks/build-webpack.js:14:73)
at Class.buildRun (/root/node_modules/angular-cli/commands/build.run.js:39:2
2)
at Class.run (/root/node_modules/angular-cli/commands/build.js:38:47)
at Class. (/root/node_modules/angular-cli/ember-cli/lib/models/co
mmand.js:147:17)
at process._tickCallback (internal/process/next_tick.js:103:7)
The command '/bin/sh -c ng build --prod' returned a non-zero code: 1
Mention any other details that might be useful.
angular-cli.json
{
"project": {
"version": "1.0.0-alpha.2",
"name": "core-ui"
},
"apps": [
{
"root": "src",
"outDir": "dist",
"genDir": "gen",
"assets": ["assets"],
"index": "index.html",
"main": "main.ts",
"test": "test.ts",
"tsconfig": "tsconfig.json",
"prefix": "app",
"mobile": false,
"styles": [
"scss/style.scss"
],
"scripts": [
"../node_modules/pace-js/pace.min.js",
"../node_modules/chart.js/dist/Chart.bundle.min.js",
"../node_modules/chart.js/dist/Chart.min.js"
],
"environments": {
"source": "environments/environment.ts",
"dev": "environments/environment.ts",
"prod": "environments/environment.prod.ts"
}
}
],
"e2e": {
"protractor": {
"config": "./protractor.conf.js"
}
},
"test": {
"karma": {
"config": "./karma.conf.js"
}
},
"defaults": {
"styleExt": "scss",
"prefixInterfaces": false
}
}

I don't know the cause of the issue as i did not invest enough time to understand the parsing of the configuration but if I change Line 347 in @ngtools/json-schema/src/schema-tree.js from
this._children[name_1] = this._createChildProperty(name_1, value ? value[name_1] : null, forward ? forward.children[name_1] : null, propertySchema);
to this:
this._children[name_1] = this._createChildProperty(name_1, value ? value[name_1] : null, forward  && forward.children ? forward.children[name_1] : null, propertySchema);
it works again

Can you show me your angular-cli.json? Maybe you have a property there that's not supported anymore or something.

I actually provided it in the issue description under "Mention any other details that might be useful.".

I'm having the same exact problem.

I guess this is the root cause (related to Docker, not sure about other cases).
When I have angular app under $HOME path, I got the same exact problem.
When I move the angular app out of $HOME path, it works as expected, no error.

@hoatle Thanks for taking the time to share this, can't say how happy I am to have this working finally! :)

Today I've updated angular-cli and now I get this same error.

@giertych97 That's unrelated to this particular issue.  See here for a fix: https://github.com/angular/angular-cli/issues/4326#issuecomment-276819350

@filipesilva I have had the same issue in my production builds to Heroku since Beta 25 (Beta 24 & earlier worked great, however I just updated to Beta 28 & can confirm the issue still exists).
2017-02-02T13:23:29.383781+00:00 app[web.1]: TypeError: Cannot read property 'input' of null
2017-02-02T13:23:29.383783+00:00 app[web.1]:     at new ObjectSchemaTreeNode (/app/node_modules/@ngtools/json-schema/src/schema-tree.js:331:14)

I believe it may have something to do with the JSON Schema feature added in Beta 25:
@ngtools/json-schema: Introduce a separate package for JSON schema. (#3927) (74f7cdd)

This does not happen when I ick off a build in my local environment npm start - all things are working as expected on localhost:4300. It is only when I deploy & Heroku kicks off the npm start that it will fail on the 'ng build' (it breaks before it is able to create a /dist folder)
This type of error message is similar to the ones seen when an npm package is missing a Types declaration file - unfortunately, one does not exist for the JSON Schema package. Maybe this is related to that?
I made a comment on this in another thread a while back but didn't follow up until just now - here's a link for additional context
Hopefully this provides some additional insight to the bug

Maybe this will help. I accidentally called ng init in Нome directory, after the launch of the ng in any other directory caused the error (even when call ng --version). After deleting ng files from the home directory. ng runs without errors

@dustintheweb did you find any solution?

@dlimkin Thank you, it solved my problem! It seems like I had some old Angular files in the root of my home directory causing all Angular projects in there with later Angular-cli versions to fail. So by deleting all files and folders that doesn't belong to the home directory, it solves the problems and the errors disappears.

@dlimkin solution works. Thanks.

For me, this issue is weirdly specific to a new build, only in my live production environment (Heroku / Ubuntu). Everything gets built fresh from the package.json (no old files), so no possibilities of similar ng gremlins for me in that regard.
Can anyone with a similar production env also confirm that this is an issue?

@dustintheweb I'm getting it too and only when building in Docker

anyone using Docker, I recommend using this Docker image to get started https://hub.docker.com/r/teracy/angular-cli/tags/
or you can use this seed project https://github.com/teracyhq/angular-boilerplate that I'm working on
I do not have any issues so far with these 2 projects.

@hoatle Thanks for the tip!  Unfortunately my project's openshift s2i environment doesn't allow me to use docker images (even though OC itself supports it), we're currently using: https://hub.docker.com/r/ryanj/centos7-s2i-nodejs/ which is itself pretty out of date, sigh. :(

OSX 10.12.3
NPM 4.2.0
[ISSUE]
Encounter the same issue when I updated angular-cli and ran $ng new appname. App wouldn't build.
[RESOLVED]

ran npm uninstall angular-cli -g
ran  npm uninstall angular-cli --save
Confirmed angular-cli was not in angular-cli /usr/local/lib/node_modules
Confirmed angular-cli was not in /Users/username/node_modules
Confirmed there was no package.json or angular package files in /Users/username/
Reinstall angular cli npm install angular-cli -g
Ran  ng -v output angular-cli: 1.0.0-beta.28.3 node: 7.3.0 os: darwin x64
Successfully created new project with ng new project

I think my main issue was having a package.json in my /Users/username/

To add to what others have mentioned, on Ubuntu if you have an angular-cli.json file in your home directory, it seems to get read (and maybe merged) whenever running ng commands in any folder. If you have a project in your home directory the json file seems to get read twice, which screws up parsing if you specify styles property.
Simplest way to see this behavior is to create an empty angular-cli.json in your home directoy, and then run the angular-cli tests, many of which will fail:
touch ~/angular-cli.json

git clone https://github.com/angular/angular-cli.git
cd angular-cli
npm install && npm test

@filipesilva is this expected behaviour?

Thanks for all the work investigating this issue. @mikejpeters I can confirm this isn't intended and is in fact a bug.

@mikejpeters Which version of CLI are you using? Fallback mechanism has already been changed and fixed<EMAIL_ADDRESS>I tried to replicate issue and seems to be working fine.

I haven't tested with the latest version, but from reading the source code I don't see any reason the issue would be fixed.
The issue is that the global config is merged with the project config even if they are the exact same path (i.e. project folder = home folder).

i just run today to this issue with latest cli and angular-cli.json file in the home. It looks like issue is still there.

 There's a couple more reports that seem to indicate some problem with the config merging logic:

heroku seems to need explicit redeclare of the HOME var: https://github.com/angular/angular-cli/issues/5808#issuecomment-298309209
seems to be happening outside of heroku as well: https://github.com/angular/angular-cli/issues/6227

Hi, I am changing the schema.js file manually and it works fine. But
I want to implement : this._children[name_1] = this._createChildProperty(name_1, value ? value[name_1] : null, forward && forward.children ? forward.children[name_1] : null, propertySchema);
in my node modules automatically using ng build through gradle. I am download node v6.9.2 and running npm install and build using gradle task. I get the same error.
Please suggest. Is it a version issue or something else?

Still running into this (on dokku) with the latest version of the cli.

The issue still exists on latest @angular/cli 3.10.10..
Works on my windows machine but throws this error:

TypeError: Cannot read property 'glob' of null

on centos in aws.
All was good until today morning when the error just popped up while running:
ng build && node server.js
on CentOS.
Is there a fix?

Thank you SO much @dlimkin
Such a stp issue!

The same issue for me with dokku today.
Updated @angular/cli to 1.6.1 with no help.
Could we expect a fix?
The non-working repo, if needed, is https://github.com/ysilvestrov/ontap-tv

@ysilvestrov redefine HOME to any other directory before building, for example i have this in my package.json
    "heroku-postbuild": "HOME=/tmp/build ng build --target=production -e ${NODE_ENV:-production} --aot --no-progress"

The bug appears when $HOME contains a .angular-cli.json and since dokku puts the project in $HOME then the bug triggers

Closing as version 1.0.0-beta.26 is a prerelease version and no longer supported.  If the problem persists within the latest stable version (currently 6.2.3), please open a new issue detailing the problem.


Migrating app to Androidx fails due to unability to transform bottomsheet-1.3.1 dependency

Hi there.
As of today many faced an issue with building RN apps due to major release by google.
Details are here: RN issue
The main way to fix this is to upgrade your app to Androidx.
Android studio has a way to update dependencies sort of automatically, but bottomsheet is one that can not be updated.
Here is Gradle sync error after one adds
android.useAndroidX=true android.enableJetifier=true
to gradle.properties according to manual.
Unable to resolve dependency for ':react-native-bottomsheet@debug/compileClasspath': Failed to transform file 'bottomsheet-1.3.1.aar' to match attributes {artifactType=processed-aar} using transform JetifyTransform
This prevents me from migrating project to Androidx and thus from ability to further build.
I see this references native bottomsheet library and not your wrapper directly.
Hopefully you might know the reason Jettifier can not transform this exact aar or have other thoughts on this.

Curious if npm i --save-dev jetifier && npx jetify manages it for you? Also, worth noting that the primary way of solving this is not to upgrade to AndroidX, it's to run a gradle dependencies report and pin the versions on the libraries that are leaking in the AndroidX Play dependencies to the pre-AndroidX version so you are working immediately, then migrate to AndroidX in a measured way. This library may be doing something special in gradle though preventing jetification, which is why I'm curious, as we're working on it as a general strategy for react-native https://github.com/react-native-community/discussions-and-proposals/issues/129

Read the above discussion in the topic. What you are doing is very important for the entire react-native community. But unfortunately now there is no possibility to try the solution, in my large enough project I had to return to android.supoort and now I am solving another problem with duplication of dependencies.

@mikehardy I read your comments on how to find dependencies causing androidx to be installed.
The issue with that approach is that once I identify firebase.x.x is the case, i downgrade it and some other modules, which results in constant errors like this
The library com.google.android.gms:play-services-basement is being requested by various other libraries at [[15.0.1,15.0.1]], but resolves to 17.0.0.
Bumping com.google.android.gms:play-services-basement version results in similar errors for other modules in cycle.
Having spent a day with this I just gave up.
Can you please explain what jetifier complains about when it's unable to transform file? It complains about compiled aar, what it does try to do with it? It would be good to understand possible reasons jettifier can not handle file.

Sorry, I have no idea why jetifier wouldn't transform an aar - that basically it's only job, and I'm not sure why it would fail, I've never seen it which is why I took the time to collaborate here. If jetifier can fail it is important to know how.
I fully understand the pain of dependency hell and I'm sorry you're going through it. This will be a difficult few months while everything settles out. RN0.60 will also change to "pods first" for iOS at the same time it goes AndroidX, so it's going to be a bumpy ride, but also both are clearly the right decisions. It's just not easy taking in all the breaking changes of 3 ecosystems at once (iOS, Android, RN)

@mikehardy thanx for being responsive first of all.
I will additionally try 'npx jetify' right now and report the results.
IF ti fails can I provide anything to help investigate it?

If npx jetify fails for any reason, please open an issue in the jetifier repo and I'll see what I can see. The console log of execution and then subsequent build results and your android/build.gradle and android/app/build.gradle would be important I guess. The repository is young so I have no template and have not seen problems yet. Thanks for giving it a spin, hope it helps though I will admit it sounds like you have a problem that is more thorny

Yes I'm aware of this AndroidX problems recently. Will make necessary changes to it. However, because 0.60 is not out yet, I think I'm not going to support it right away.

@Doko-Demo-Doa do you mean you can handle it with RN wrapper?
Jettifier complains about native android bottomsheet which is  this repo dependency

@Doko-Demo-Doa that is a sensible position, I also maintain react-native-device-info and help on react-native-share and react-native-firebase and it does not make sense at the library level to move yet. Soon, but not yet. So we are trying to provide bridges like jetifier etc. The weird thing is that the bottomsheet aar won't jetify so users can't move to AndroidX and just transform things while you stay on support libraries. It's a failure that has no explanation yet, and doesn't require AndroidX support on your part, but is odd.
I will mention it will soon be possible to integrate the "bob" package, move your module to AndroidX, and use a bob build target to generate a "reverse jetified" aar at the build time then distribute it. Then you will have an AndroidX library (your main AAR) but also a support library (separate AAR) for apps to consume at their option
Good luck during this transition - not easy times for library maintainers :fist_raised:

(quick update: that PR on bob is merged, you can generate reverse-jetified AARs for support library consumers with trivial package.json directives now, I think...in case it's interesting)

I found the problem. It is specific to this library, or even more precisely it is a bug in the packaging of the underlying library. https://github.com/soarcn/BottomSheet/issues/142
The branch on that fork mentioned in that library is fully converted to AndroidX so may not be a viable solution here.
The library is effectively unmaintained. So I proposed a PR that fixes it and includes it directly #23
It works https://github.com/mikehardy/rn-androidx-demo/blob/master/make-demo.sh#L34

In addition to all of the above. During the study, I realized that the problems associated with the new release of Google. https://developers.google.com/android/guides/releases
Maybe this will lead to other difficulties for someone else, so I attach a link that would be where to start searching for a solution!

@JerakRus please read issue link in my initial comment.

@quarryman Thanks, I think I missed it. This will help me a lot! Then I will delete the previous comment.

It should be solved now. Please use package v2.0.1
Let me know if there are still crashing, compiling errors,...

I altered the dep to the standard npm install for bottomsheet in the AndroidX demonstrator I'm using to test/prove jetifier and it works great: https://github.com/mikehardy/rn-androidx-demo/commit/0c9f4b24d595897e806507c9b3c384b0547f6bae#diff-c8e33fe90e78d567b713e8dab48e5d87R34
Thanks @Doko-Demo-Doa


Example's editor doesn't render line numbers correctly

Line numbers are not rendering properly in the editor.
They appear to be squished and not aligned with the code.
Browser: Arc (chromium)

I'm interested in solving this issue, could you specify where this issue is and if you have tested in other browsers.


Add a metadata.rb file

When trying to use a fork or a branch of this repo - berkshelf throws an error about The resource at '/var/folders/wp/5vk87yqj74s6db15lbjn16qr0000gn/T/d20160515-60205-qblbms' does not appear to be a valid cookbook. Does it have a metadata.rb?"
I also tried adding extension 'halite' to the top of the Berksfile file and using the dependency as a gem, but I'm getting the following: /opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/berkshelf-4.0.1/lib/berkshelf/berksfile.rb:89:in rescue in extension': Could not load an extension by the name halite'. Please make sure it is installed. (LoadError)

https://github.com/poise/halite#using-a-pre-release-version-of-a-cookbook

This is almost never a good idea.


TableCellBox | Going Crazy with some Graphic Cells

My colleague Uwe Laubdender found cases where the cellBox function doesn't work, e.g. with transformed graphic cells having a custom shape and a nested graphic, as in the example below:

Calling the function on such cells will likely creates a shifted rectangle “landing at the bottom edge of the pasteboard”:

This bug seems to result from running
 box = cell.pageItems[0].duplicate();

with too much confidence. Indeed the duplicate() method does not guarantee that the resulting object always coincides with the source. This needs to be fixed with caution.
Source code: https://github.com/indiscripts/IdGoodies/blob/2ba60ba80151396768303529428f39c540acd68f/snip/TableCellBox.jsx#L94
Test (IDML):
GetShapeofCell-TestTable-2022.zip

MEMO
There is a general issue with obj.duplicate()—regardless of transform states—if obj is a GraphicCell's page item beyond the 1st spread of the document. We also found that CoordinateSpaces.SPREAD_COORDINATES is irrelevant for such object.
A stronger algorithm is therefore needed. About to be solved here: https://gist.github.com/indiscripts/60a8945812fe371147f7f10d8f93cc16
(Work-in-progress.)

MEMO
The case of BUTTONS and MSO:

Used as Graphic Cell objects, buttons and MSO could be duplicated but the convertShape command wil fail. A simpler strategy is obviously needed to address such cases.
Here is the rule: the GC area always match the visible 'in-parent' bounding box of the abstract multi-state group. As a result, the commands of the form
myObj.resolve( [<Anchor>,<VisibleGeometry>,<ParentSpace>], <AnySpace> )[0]

still work fine with MSO or buttons :-)


mdbook serve doesn't work

After I run the command cargo install mdbook-katex and modify the .toml file. The command mdbook serve doesn't work.
The info was
2022-12-09 10:26:56 [INFO] (mdbook::book): Book building has started
Error: The katex preprocessor/renderer did not understand what you wantedto do
2022-12-09 10:26:56 [ERROR] (mdbook::utils): Error: The "katex" preprocessor exited unsuccessfully with exit code: 1 status

All the above work was done on a  Mac environment.
P.S. An extra question, is that ok for me just leave the options be emty and just put the following lines in the .toml file? It not, what should write under them? I can't find some documents to discuss this problem in detail.
[output.katex]

[preprocessor.katex]

For you reference, here is an example book.toml:
[book]
authors = ["Steven Hé (Sīchàng)"]
language = "en"
multilingual = false
src = "src"
title = "Steven's Notes"

[build]
build-dir = "docs"

[output.html]
git-repository-url = "https://github.com/SichangHe/notes"

[output.katex]

[preprocessor.katex]

Does this solve your problem? If not, could you post your minimum book.toml file?

Thanks for your help. But it still doesn't work. Here's my book.toml file.
[book]
authors = ["Orz"]
language = "en"
multilingual = false
src = "src"
title = "Notes"

[output.html]
additional-css = ["custom/custom.css"]
no-section-label = true

[output.html.fold]
enable = true
level = 0

[output.katex]

[preprocessor.katex]

Does custom/custon.css actually exist? Could you try it without that line?
When I try this book.toml on my Mac, I got OS error saying that the files don't exist. And, after I created them, the programs ran without any problem.
Could you print your mdbook and mdbook-katex versions?

Yes, I checked that custom.css actually exists.
The versions of the packages as follows

mdbook v0.4.9
mdbook-katex v0.2.17

I see the problem. Can you try using the latest mdbook? For your information, the latest mdbook is v0.4.22. The v0.4.9 is quite old and some things probably have changed.

Yes. The problem solved after I update the version of mdbook to 0.4.22. Thanks for your patient reply and help. I really like the repository since it make the input of mathematical formulas much more convenient :)

Good to know the problem is solved. You are welcome. I like the repository, too, and that's why I am trying to improve it.


Add "freeArgs: Any?" into destinations

It will be useful to have API to pass any kind of data into screen (screen metadata, deeplink info, etc..)

Implemented in scope of https://github.com/ComposeGears/Tiamat/pull/13


Update ABI types with latest protocols

fixed drop / lazynft constructor to take in royaltybps

This is done.


Extend the CFP

see my comment on the gitlab issue - i'd like to also put a header at the top of the page explicitly saying we updated the date (to avoid confusion for people)


[improve] Pass group ID to authorizer when using OAuth

Motivation
Currently, the KoP only supports checking the topic permission when doing the consume authorization, but Kafka support checking the topic and group ID permission.
Before introducing this change, let's understand why KoP can't check group ID permission.
When Kafka does the consume authorization check, it will first check the group ID permission in handleJoinGroupRequest method, then it will check the topic permission in the handleFetchRequest method.
However, Pulsar is using another way to check consume permission. See the org.apache.pulsar.broker.authorization.AuthorizationService#canConsumeAsync method, it requires passing the topic name and subscription to check both permissions in the same place, and the topic name is required param.
public CompletableFuture<Boolean> canConsumeAsync(TopicName topicName, String role, AuthenticationDataSource authenticationData,String subscription)

If we follow the Kafka way to check the consumer permission, we can't get the topic name when joining a group since the join group request does not contain the topic name. So we have to authorize permission in the fetch request.
However, to authorization consume permission in the fetch request, we can only get the topic name in this request. In this case, we can't authorize the group ID.
Modifications
Since we can't get group ID when handling fetch requests, we need to find a way to pass through group ID when doing the authentication.
In OAuth, we have a credentials_file.json file that needs to be config, for example:
{
	"client_id": "my-id",
	"client_secret": "my-secret",
	"tenant": "my-tenant"
}

Here we can add a new parameter into the config:
{
	"client_id": "my-id",
	"client_secret": "my-secret",
	"tenant": "my-tenant",
        "group_id": "my-group-id"
}

Then we can add these parameters to SaslExtensions, and send it to the broker.
Documentation
Check the box below.
Need to update docs?

[x] doc-required
(If you need help on updating docs, create a doc issue)

[ ] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

@Demogorgon314 Could you resolve the conflicts?

@BewareMyPower Resolved.


Add emulator jacobian plots

In creating the fixed RNN, it was useful to use output sensitivity plots to investigate model behavior.  This PR adds jacobian plots to the WandB training process.
Example
Resolves #1560
The jacobians are added to the end of the training script because reloading saved models had some missing metadata that made the gradient calculation much more difficult (probably custom layer data not saved in the trace).  Everything important is stored before attempting the gradient calculation.
Breaking Changes:

Updates TrainConfig defaults to new datasets and associated derived mapping hardcodes for tendencies,  (_output suffix -> _after_precpd suffix)

Minor Adjustments:

fixed the ability to specify tendency output names via config
fixed some inconsistencies in the keras model outputs vs. the MicrophysicsConfig.output_variables

New example with some axes labels: https://wandb.ai/ai2cm/crapcrap/runs/44jadbkr?workspace=user-aperkins


Fish prints error on startup

Issue description
On startup, fish prints set: Tried to change the read-only variable “_” both in my terminal emulator and the ttys , but not in the terminal emulator when the Xsession is started via slim. On lightdm or manual start through startx however the error persists.
Steps to reproduce
Setup fish as default shell via
programs.fish.enable = true ; and users.extraUsers.<username>.shell = pkgs.fish;
Start a terminal emulator with fish as shell.
Technical details

System: (NixOS: 17.09.1756.c99239bca0 (Hummingbird))
Nix version: (run nix-env (Nix) 1.11.15)
Nixpkgs version: (run "17.09.1756.c99239bca0")
Sandboxing enabled: (run build-use-sandbox = false)

I found some more Information; here is some context with high debug level:
<4> fish: io_buffer_t::read: blocking read on fd 3
<4> fish: Exec job 'set value (echo $variable | /nix/store/d8xpyjpammvl3839m4drsx1xk7m2d91q-gnused
-4.4/bin/sed 's/[^=]*=//')' with id 10
<3> fish: Skipping fork: no output for internal builtin 'set'
<3> fish: Set status of set value (echo $variable | /nix/store/d8xpyjpammvl3839m4drsx1xk7m2d91q-gn
used-4.4/bin/sed 's/[^=]*=//') to 0 using short circuit
<3> fish: Job is constructed
<4> fish: Continue job 10, gid -2 (set value (echo $variable | /nix/store/d8xpyjpammvl3839m4drsx1x
k7m2d91q-gnused-4.4/bin/sed 's/[^=]*=//')), COMPLETED, NON-INTERACTIVE
<5> fish: intern /nix/store/y7rdwg8vp8m9snbyy0mcixxbd3zpz1xj-fish-foreign-env-git-20170324/share/f
ish-foreign-env/functions/fenv.apply.fish
<4> fish: Exec job 'test "$key" = 'PATH'' with id 9
<3> fish: Skipping fork: no output for internal builtin 'test'
<3> fish: Set status of test "$key" = 'PATH' to 1 using short circuit
<3> fish: Job is constructed
<4> fish: Continue job 9, gid -2 (test "$key" = 'PATH'), COMPLETED, NON-INTERACTIVE
<4> fish: Exec job 'set -g -x $key $value' with id 11
<3> fish: Skipping fork: ordinary output for internal builtin 'set'
set: Tried to change the read-only variable “_”
<3> fish: Set status of set -g -x $key $value to 1 using short circuit
<3> fish: Job is constructed
<4> fish: Continue job 11, gid -2 (set -g -x $key $value), COMPLETED, NON-INTERACTIVE
<3> fish: Job is constructed

Looks like this is happening from the dynamical build environment for fish. This explains the special behavior of described in the original issue, my startx session runs inside of an fish session, so the environment is not build again.

This is due to differences between the ways that fish and POSIX shells work, exposed by the wrapping we do with the fenv tool, which allows us to load configurations designed for POSIX shells (like bash, for example) into a fish environment, despite the syntactical incompatibilities between the languages. In this case, the error message is reporting a totally harmless issue: _ is used to represent the name of the running process in a shell, and fish does not allow this variable to be manipulated manually. Because it gets changed in the bash environment in the course of the fenv call, fenv tries to change it in fish as well. Because fish does not allow this, it prints a warning.
There are some other messages we've suppressed, and we could take a similar approach here. I was thinking that maybe we can just have fenvcheck for the variable with that name and skip exporting it. What do you think, @rnhmjoj @cbarrett ?

That sounds right to me @therealpxc.

@therealpxc Sure. Something like this should do:
set ignore PATH _

if test "$key" = 'PATH'
  set value (echo $value | tr ':' '\n')
end

if contains $key $ignore
  set -g -x $key $value ^/dev/null
else
  set -g -x $key $value
end

While we are at it, are there any other warnings?

I was thinking that in the case of $_, we might as well not attempt to set, rather than doing so and suppressing the error.
I'm not aware of any other bad startup messages. Are you, @wucke13?

No, that was the only error message I got on startup. Looks like a reasonable fix to just suppress the message, as there aren't any follow up errors on this AFAIK.

I opened a PR  with @rnhmjoj's patch: https://github.com/NixOS/nixpkgs/pull/31646
Help with testing will be highly appreciated.

Can we close it?

On my end, #31646 did the trick.

On my end, there is no error left too.

When I SSH into my recently installed NixOS, I get:
set: Tried to change the read-only variable “_”
Welcome to fish, the friendly interactive shell

Could this issue have been reintroduced?
Subsequent invocations of fish are fine (like with fish or sudo -s).
Technical details

system: "x86_64-linux"
host os: Linux 4.9.84, NixOS, 17.09.3094.211309626af (Hummingbird)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 1.11.16
channels(root): "nixos-17.09.3094.211309626af"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

This was not backported to 17.09 I think, the fix will be in 18.03.

Indeed, installing the unstable version of fish-foreign-env solved it.  Thanks for the clarification.


add Ambient option for labeling new issues, features and pull requests

Please provide a description of this PR:
Coinciding with the announcement of Ambient Mesh, would be great if users could mark new Issues, Pull Requests and Feature Requests  with an Ambient label
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ X ] Developer Infrastructure

@GregHanson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3dc4be0c8dce7502e04fd955ba9ca57d7c7bea4f
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

related istio/bots PR: https://github.com/istio/bots/pull/549

used alphabetical ordering for placement within lists, but completely open to discussion on placement

/retest


refactor(transformer/class-properties): exit transform_class faster if nothing to do

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#7586  👈 (View in Graphite)
#7532 : 1 other dependent PR (#7516 )
#7531
#7533
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Fatal error: Class 'Memcached' not found

i run  this command "php artisan ide-helper:generate", then throws out this exception
 Fatal error: Class 'Memcached' not found in    /Applications/XAMPP/xamppfiles/htdocs/test/vendor/illuminate/cache/MemcachedConnector.php on  line 74
[Symfony\Component\Debug\Exception\FatalErrorException]
Class 'Memcached' not found.
i can find Class 'Memcached'。

Same issue here. I had to install memcached for my current php version. Since you are on macOS you can install php70-memcached via homebrew. You may need to install xcode-select.

Run this command inside Homestead that has Memcached installed.

It's an issue.
I don't want to install Memcached just to run "ide-helper:generate" smoothly.
Is there a way to avoid Class 'Memcached' not found error without Memcached get actually installed?
I use Lumen 5.4

My problem was in absence of .env file.
Once I put it back the error is gone.

I suspect this had to do something with cache driver config and memcached not being installed or some eager dependency resolved
@barryvdh it's quite old and one user reported he could fix it and this is the only issue I can find regarding memcache, I therefore vote for closing this :}


docs: upadate documentation about "PaddlePaddle" in "INTEGRATIONS"

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.452%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
7632

Relevant Lines:
8828

💛  - Coveralls


OVOSSkill full CRUD for events

Currently, there is no way to list existing events from the OVOSSkill methods. Once the feature exists in ovos-bus-client, the helper methods should be added to the base class

Related to https://github.com/OpenVoiceOS/ovos-bus-client/issues/80

my legacy code: self.add_event( "mycroft.skills.initialized", self.handle_boot_finished )
how do i do it in ovos please?

my legacy code: self.add_event( "mycroft.skills.initialized", self.handle_boot_finished )
how do i do it in ovos please?

the exact same way
please keep these questions in the QA discussions or chats, this is completely unrelated to the issue where you posted

that code does not work.  it never gets triggered.
On Sat, Mar 2, 2024 at 8:19 AM JarbasAI @.***> wrote:

my legacy code: self.add_event( "mycroft.skills.initialized",
self.handle_boot_finished )
how do i do it in ovos please?
the exact same way
please keep these questions in the QA discussions or chats, this is
completely unrelated to the issue where you posted
—
Reply to this email directly, view it on GitHub
https://github.com/OpenVoiceOS/OVOS-workshop/issues/175#issuecomment-1974841923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABS6UTYKCLMGVEVNQEPVOJ3YWH3XTAVCNFSM6AAAAABBZVNBJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZUHA2DCOJSGM
.
You are receiving this because you commented.Message ID:
@.***>

https://openvoiceos.github.io/ovos-technical-manual/skills_bus/
where is the list of events the OVOS EMITs please

I just asked to please not spam this issue and keep the discussion in a single place, i answered in the correct place.
This issue is about a missing feature for ovos-workshop and is meant to discuss adding that to ovos.workshop, not to give support to a totally unrelated question


Add level numbers to file names

I think it would be helpful to add numbers to the file names to indicate what level they are, much like in Patrick Massot's tutorial. E.g. 00-basic.lean, 01-I.lean, 02-conj.lean, etc.

I can't import files whose names begin with numbers, or which have - signs in, so I've gone with Level_03_conj.lean etc


[Fix #4324] Add Lint/InterpolationCheck cop

Adds the new cop as discussed in #4324 . I wrote the code, but there are many errors coming up which I've been trying to fix. Looking for help from maintainers/contributors so I can make further contributions without these hiccups. Please tell me what I'm doing wrong. Thanks!

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[ ] All tests are passing.
[ ] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

When add a new cop, an entry in https://github.com/bbatsov/rubocop/blob/master/config/enabled.yml is required.
Please try to run bundle exec rake in your computer. It executes rspec and rubocop for this project.

In spec of rubocop repository, the added cop has many false positives.
Because we use string interpolation in single quote for test. For example: https://github.com/bbatsov/rubocop/blob/00e1a2e5937dfa8f8146b2d75563edd70cdd1060/spec/rubocop/cop/security/eval_spec.rb#L55
So, maybe we should disable the cop in spec/ directory by our project's .rubocop.yml. https://github.com/bbatsov/rubocop/blob/00e1a2e5937dfa8f8146b2d75563edd70cdd1060/.rubocop.yml
And  in lib/ directory, the cop has several false positives. I guess the false positives should be disabled by inline comment. http://rubocop.readthedocs.io/en/latest/configuration/#disabling-cops-within-source-code

The cop raised some errors when I ran the cop in rubocop directory.
$ rubocop --only InterpolationCheck -d

(snip)

5 errors occurred:
An error occurred while Lint/InterpolationCheck cop was inspecting /home/pocke/ghq/github.com/bbatsov/rubocop/spec/rubocop/path_util_spec.rb:85:50.
An error occurred while Lint/InterpolationCheck cop was inspecting /home/pocke/ghq/github.com/bbatsov/rubocop/spec/rubocop/result_cache_spec.rb:157:55.
An error occurred while Lint/InterpolationCheck cop was inspecting /home/pocke/ghq/github.com/bbatsov/rubocop/spec/rubocop/cop/layout/end_of_line_spec.rb:16:33.
An error occurred while Lint/InterpolationCheck cop was inspecting /home/pocke/ghq/github.com/bbatsov/rubocop/spec/rubocop/cop/lint/syntax_spec.rb:50:0.
An error occurred while Lint/InterpolationCheck cop was inspecting /home/pocke/ghq/github.com/bbatsov/rubocop/spec/rubocop/processed_source_spec.rb:80:8.

It is a bug of the cop. Could you check the errors?
And if you execute your cop in large project(e.g. gitlab, redmine and ruby/spec), you may be able to find more errors if the errors exist.

Looks like you're off to a good start! I left some small comments. Unfortunately, I don't have time to look at the highlighting code just now.
It's extremely common to get sucked down the rabbit hole, trying to add too many features at once, when first starting out, as evidenced by the many abandoned PRs. 🙂 Because of this I tend to recommend making a very simple version of the cop first (i.e. just mark the entire node as offense) and get that merged.
Then submit enhancements PRs for improvements (e.g. highlight only the interpolated part of the string.) 🙂

@pocke  Thanks! Make changes accordingly.
@Drenmi Removed the code highlighting in this PR and will add it later!

Just a few small fixes, then it's good! 🙂

@Drenmi @pocke Thanks again! Fixed them.

After thinking about it. This cop should probably not check regular heredocs. I think this is what's causing all the offenses on RuboCop itself. So instead of inline disabling, we should add a check for it.
return if node.loc.is_a?(Parser::Source::Map::Heredoc)

@Drenmi I added the line, and removed inline disabling. But the offenses before inline disabling are coming up again.

@Drenmi Ping. I know this is late, but I haven't given up yet. Failed CI builds show some unrelated cops. Can you please take a look?

Is there a "blessed" way to indicate that no, i in-fact did not want to interpolate my string and it should actually have a '#{pattern}  in it?


[next] Layout xsGutter false has no effect

Problems
A couple of issues with xsGutter false after a code review:

It appears that a <Layout type="item" xsGutter={false}/> has no impact on it's own.  e.g. it is not in control of it's own gutter because of the .Layout-gutter-xs-16 > .Layout-typeItem
Gutters (default value) seem to still be generated by the code below (I'll isolate and try a test case):

<Layout container xsGutter={false}>
  <Layout item xsGutter={false}>foo</Layout>
</Layout>

Generated styles:
.Layout-gutter-xs-16-3374265422 > .Layout-typeItem-565831246 {
    padding: 8px;
}

This is created by:
  /**
   * Defines the space between the type `item` component.
   * It can only be used on a type `container` component.
   */
  xsGutter: PropTypes.oneOfType([
    PropTypes.bool,
    PropTypes.oneOf(GUTTERS),
  ]),
...
const GUTTERS = [8, 16, 24, 40];  // <=== NO MENTION of false/true
...
function generateGutter(theme, breakpoint) {
  const styles = {};

  GUTTERS.forEach((gutter) => {
    styles[`gutter-${breakpoint}-${gutter}`] = {
      margin: -gutter / 2,
      '& > $typeItem': {
        padding: gutter / 2,
      },
    };
  });

  return styles;
}

...
className={classNames({
   [classes[`gutter-xs-${xsGutter}`]]: container && xsGutter !== false,

Discussion
Assuming I can get some test cases to isolate the potential bug in xsGutter and validate/fix or invalidate that:
Shouldn't a container be able to have a gutter while allowing an item with no gutter?
/cc @oliviertassinari
Versions

Material-UI: next
React:
Browser:

This issue is no longer valid due to 9eff8e6b3cb6ed8e10684f78679eb979ca1e086a
Fixed just a few hours ago 👍

I'm reopening this issue only for this question:

Shouldn't a container be able to have a gutter while allowing an item with no gutter?

Shouldn't a container be able to have a gutter while allowing an item with no gutter?

That makes sense, we could expose a property on an item to remove the gutter added by the parent. I see one edge case so far with the first item and the last item. The padding is going to be wrong.

I've figured out this is not a big issue for me.  Logically it's not perfect because of the inter-dependency, but I just needed a slight tweak to my approach (deeply nested) to get my end-result.  I'm going to close for now and we can revisit if there is a clearer case of the need for it.


RSDK-2718 - factor out component/service_base

Major Changes

Removes resource_manager.cpp
Removes components/service_base.cpp
Makes consistent use of subtype_service in lieu of the above.

This change helps set up a better testing story for robot tests, coming next.

I can see why we'd want to do this - but subtype_service would be a pretty bad name for what we're using it for. we'd need to change it in this pr as well

I can see why we'd want to do this - but SubtypeService would be a pretty bad name for what we're using it for. we'd need to change it in this pr as well

Hah yeah, totally valid. I renamed to ResourceManager.
@zaporter-work per convo in previous PR, note that get_sub_svc() is now resource_manager()


Support WebXR for Wolvic

Add the new device type, WVR_DEVICE_ID
force to grant VR permission
we should remove this code in VRServiceImpl::OnPermissionResultsForMode after implementing the Permission feature
Create the WVR thread
WvrManager running on the WVR thread
GL command
Mojo communication
push/pull status of shared memory to communicate between chromium and wolvic
Add WVRSurfaceTexture for sharing SurfaceTexture object
Copy moz_external_vr.h from Wolvic repo

It would be helpful to see https://gitlab.igalia.com/commissions/webxr/development/-/issues/47#note_167981

LGTM, specially in prototype stage. Could you create tickets for all the pending tasks and issues you identified? (I.e. the TODO, but also problems observed).

Done.


Redis connectivity failing on including special characters in the password.

On deploying superset on K8s (with Terraform), connectivity with Redis fails on including special characters in the password.
Expected results
Superset should connect to Redis on inclusion of special characters in the password, or allowed special characters should be documented.
Actual results
ERROR:superset.views.base:invalid password
Traceback (most recent call last):
  File "/app/superset/views/base.py", line 183, in wraps
    return f(self, *args, **kwargs)
  File "/app/superset/utils/log.py", line 211, in wrapper
    value = f(*args, **kwargs)
  File "/app/superset/utils/cache.py", line 153, in wrapper
    return f(*args, **kwargs)
  File "/app/superset/views/utils.py", line 446, in wrapper
    return f(*args, **kwargs)
  File "/app/superset/views/core.py", line 618, in explore_json
    return self.generate_json(viz_obj, response_type)
  File "/app/superset/views/core.py", line 455, in generate_json
    payload = viz_obj.get_payload()
  File "/app/superset/viz.py", line 443, in get_payload
    payload = self.get_df_payload(query_obj)
  File "/app/superset/viz.py", line 493, in get_df_payload
    cache_value = cache_manager.data_cache.get(cache_key)
  File "/usr/local/lib/python3.7/site-packages/flask_caching/__init__.py", line 248, in get
    return self.cache.get(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/flask_caching/backends/rediscache.py", line 114, in get
    self._read_clients.get(self._get_prefix() + key)
  File "/usr/local/lib/python3.7/site-packages/redis/client.py", line 1606, in get
    return self.execute_command('GET', name)
  File "/usr/local/lib/python3.7/site-packages/redis/client.py", line 898, in execute_command
    conn = self.connection or pool.get_connection(command_name, **options)
  File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 1192, in get_connection
    connection.connect()
  File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 567, in connect
    self.on_connect()
  File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 643, in on_connect
    auth_response = self.read_response()
  File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 739, in read_response
    response = self._parser.read_response()
  File "/usr/local/lib/python3.7/site-packages/redis/connection.py", line 340, in read_response
    raise error
redis.exceptions.AuthenticationError: invalid password

Version Info. (Chart.yaml)
apiVersion: v1
appVersion: "1.0"
description: Apache Superset is a modern, enterprise-ready business intelligence web application
name: superset
maintainers:
  - name: Chuan-Yen Chiang
    email<EMAIL_ADDRESS>    url: https://github.com/cychiang
version: 0.1.0

I believe https://github.com/apache/superset/issues/13995 is the cause of your issue. The password needs to be passed into superset, but superset does not have the configuration necessary yet.

Optimistically closing this since the solution proposed has not been confirmed/denied (i.e. the issue is stale) and the issue is about the 1.0 release of Superset, whereas we are currently supporting the 1.5.x and 2.0.x releases. I'm happy to re-open this if anyone still sees it as an issue! Thanks!


[WIP] EJBCA plugin

This plugin uses EJBCA's soap api to create certificates.
Work in progress.

Any update on this PR?

Closing this due to inactivity. Feel free to re-open.


Failed to demangle superclass of RxCollectionViewSectionedReloadDataSource from mangled name '13RxDataSources023CollectionViewSectionedB6SourceCyxG'

Runtime error in our app with RxDataSources version 4.0.0.

We've released 4.0.1
Swift toolchain messed up static linking.

Thanks, will check it.

Issue still persists with 4.0.1 or master vis Swift Package Manager and Xcode 11 Beta 2:
failed to demangle superclass of RxTableViewSectionedAnimatedDataSource from mangled name '13RxDataSources018TableViewSectionedB6SourceCyxG'

Still blocked in Xcode 11 Beta 3
failed to demangle superclass of FlatMap from mangled name '7RxSwift8ProducerCy7ElementAA25ObservableConvertibleTypePQy_G'

@kzaher can you please reopen this

Having the same issue @kzaher

Noticing this on the XCode 11 public release as well (11A420a)

@gabrielPeart @Nickersoft do you have multiple targets to which you have linked the swift package? E.g. an internal framework which you use in different extensions?
I solved this problem in order to just link the package to one target. In my case just to my shared internal framework. I had linked it before to both, to my framework and to the main app.

setting DEAD_CODE_STRIPPING=No in build settings fixed the problem.

setting DEAD_CODE_STRIPPING=No in build settings fixed the problem.

this probably doesnt fix the demangle error does it?
I have the same issue when linking same dependency into multiple targets in project (eg. app and framework when the app has also dependency on the framework)

@zdnk Me too

@zdnk Me too

"Me Too" v4.5.0

ditto (hi @kwakueshun )

me too

My solution to this problem is to only add it to one library. If I added it to 2 libraries or 1 library and the app, I'll get the crash.

@mohamede1945 I am facing this issue today. (using Xcode 12, but possibly would have the same issue with Xcode 11)
I am using RxSwift/Relay/Cocoa amongst several app "modules" divided in separate frameworks. The solution I found is to have an Rx.framework which static links with all 3 libraries defined in Package.swift
However, each of these frameworks have their own Unit Test target in Xcode, which sometimes rely on RxTest...
The thing is RxTest statically links with RxSwift and we end up having RxSwift symbols in both Rx.framework & Test-target.
Which ends up with the issue of demangling superclasses...


Add log action and ability to log any rule.

If the "log_prefix" field is present in a rule, we emit an iptables LOG action in addition to the action for the rule itself.

I think it's probably best not to do it by default, but I can see that people might want the ability to add rate limits to their log rules (-m limit).

fiptgenerator is starting to get difficult to follow.  I spotted a couple of concretely unpleasant things:

drop_rules is wrongly named: it only produces one rule, and other code depends on this (such as the equally poorly named logged_drop_rules).
ipt_targets (~1000) are built in 3 different ways: inline, call out, or passed in.  Relatedly, _rule_to_iptables_fragments_inner() doesn't even use the on_allow parameter!

Any other refactoring ideas would be good.

Thanks Shaun - a few comments on this one above.  Actions:

I think we should add the rate limiting.
Make / reject the specific fixes.
If you can think of anything good to do, I feel like there's room to refactor and make it clearer.

drop_rules is wrongly named: it only produces one rule, and other code depends on this (such as the equally poorly named logged_drop_rules).

Actually, it returns a list containing a single rule.  It's designed to be overridden in a plugin (and our neflow plugin does hook that function).  that's why I didn't add the logging function to drop_rules directly; that API is part of the plugin API so I can't just add  a new parameter.  logged_drop_rules does handle there being multiple rules in drop_rules() return value.  It inserts its rule at the start of the list using slice assignment: foo[0:0]=prefix_list.

ipt_targets (~1000) are built in 3 different ways: inline, call out, or passed in. Relatedly, _rule_to_iptables_fragments_inner() doesn't even use the on_allow parameter!

Ugh, I don't think we ever pass in different on_deny values either.  I'll see if it'd be trivial to snip those out; I think we can remove a parameter from the API without breaking plugins.

Any other refactoring ideas would be good. I found I needed to read the entirety of rule_to_iptables_fragment() and its subfunctions to have confidence in it.

I'm slammed today so I don't have time to do more cleanup.

I think we should add the rate limiting.

Agreed, that's be really great to have, but I'd rather follow up with that in another PR.  We need to do a release this week and I don't want this to slip out due to feature-creep.


Improve arrow-rs examples

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
To help people get up to speed with a new library quickly, it is helpful to start with compiling examples. The arrow-rs docs have many small working examples,  but it would also be nice to also include some full featured examples.
clap-rs has a nice example of examples: https://github.com/clap-rs/clap/blob/v3.1.12/examples/README.md
This is especially useful as we start making them easier to find such as https://github.com/apache/arrow-cookbook/pull/185
Describe the solution you'd like
Here are some possible improvements

[x] https://github.com/apache/arrow-rs/pull/1615
[x] https://github.com/apache/arrow-rs/pull/1614
[x] https://github.com/apache/arrow-rs/pull/3153
[ ] Add example of reading from a CSV File, and computing some simple calculation (max of each columns?)
[ ] Add example of calling computation kernels (showing how to downcast)
[ ] Add automated checking (the way that clap does https://github.com/clap-rs/clap/blob/v3.1.12/examples/README.md#contributing)

I'm planning to work on this. What I'd personally do, is to have many small examples of increasing complexity. So, besides examples and recipes, it can be used as a tutorial, to learn Arrow topics step by step.
If people are happy with this, I'll start working on PRs for the next:

Creating arrays for primitive types

With the array constructor (e.g. Int32Array::from(vec![...]))
With a builder (using append_value and `append_null)
With collect()

Creating arrays with null values. I'm unsure about this one, if the above are simple enough, probably we can have this in the above examples. But worth having this here for consideration for now
Creating arrays of more complex types (e.g. Dictionary, Struct...)
Creating Schema
Creating RecordBatch
Reading from different formats

Parquet
CSV
JSON

Writing to different formats (same)
Data manipulation and kernels. Will expand on this when the rest are done, for now just couple of simple examples to have something.

Not sure how feasible it is, but would be amazing if we could render those examples (which will have documentation explaining what's going on) direct to the Arrow cookbook. I think it's a bit tricky, but doable. And I think it's better than having to maintain two different cookbooks/examples, or just having them in one place.
Feedback on any of this very welcome.

I don't think this is tracking anything actionable now, so closing this ticket


Use singular form for metadata properties

I made a few updates to the spec & database:

Changed continent to only allow an array instead of both a string and array to make accessing the values consistent
Updated the wording on how to name a variant file. It now explicitly states that the extlang subtag of an IETF language tag should be used to name the variant file.
Renamed sources to source to be consistent.
Renamed countries to country to be consistent.

It doesn't look like the API will need to be modified for these changes.

@Mottie You've just added the "Update dependencies" commit. I've added it to the spec branch accidentally, then removed it and pushed it to master. So this is my fault, seems like you synced the branch one second before I removed the commit. Since you now pushed it again, could you please remove it?

I didn't see any place in the API that needed updating.

I'll double check this asap.


Missing phonemes when converting from MusicXML to DS

Hi,
what is the best way to convert a MusicXML file to a Diffsinger script? When I try this I'm getting the rror:
ParamsError: The source file lacks phoneme parameters.
I basically understand what this means, MusicXML doesn't provide Phoneme's natively. So, how do I do that then? I thought opencpop-extension would specify those, so they could be used?
Thank you for any hint you have on this.

The source file needs to store a list of phonemes with their exact durations in the note attribute. Currently only a few project file formats have implemented this feature, such as acep, svip, tlp, etc.

Thank you for the explanation. However, I'm still not sure how to solve the problem(s) I currently have, maybe you have an idea.
My workflow right now is converting MusicXML to USTX and then using Diffsinger through OpenUTAU. However OpenUtau separates syllables a bit strange, so whole words are not processed, leading to wrong pronunciations in many cases. Plus, connected notes won't sing as they should, instead the lyric la is always inserted. I had hoped to solve these, by converting directly to Diffsinger, which should be able to process whole words and connected notes. But this doesn't look like it's working - even if I convert to a format that supports those parameters in between, like SVIP or USTX, I can't continue directly to DS withouth previously running the software, to get the phonemizer add the flags. Do you have any idea what I could try to improve that?
Thank you very much in advance if you have any advice, and for all your effort. I'll make a PR, as soon as I have the German translation ready.

musicxml represents a printed sheet music for human reader, while ustx represents a input to machine singing synthesis program. That's why they handle lyrics differently. We should have a smarter lyric conversion logic.
For multisyllable lyrics: In OpenUtau, we have to input the whole word in the first note, use + to distribute syllable and use +~ to extend the current syllable, which is different from a printed sheet music.

For "connected notes" (in OpenUtau we call them slur notes), they are represented in sheet music as two notes connected with a slur symbol:

In OpenUtau, input lyrics on the first note, and input +~ on the second note.


[Reflection] Try to read only the reflection sections.

(instead of the whole object).

@swift-ci please test

@mikeash unfortunately, this still crashes some testcases.

Build failed
Swift Test OS X Platform
Git Sha - fcc74e82de9642c94ebada17bd847dc9b798de13

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 32fc8f14d1412ba7576fb6db2dabce8380c7afcd

Build failed
Swift Test Linux Platform
Git Sha - fcc74e82de9642c94ebada17bd847dc9b798de13


Hanging connector

require_once __DIR__.'/vendor/autoload.php';

$inner = count($argv) > 1;

$loop = new \React\EventLoop\ExtEventLoop();

$connector = new React\Socket\Connector($loop);

runme($loop, $connector, $inner);

if (!$inner) {
    echo "Outer start\n";
    $loop->run();
}

function runme(\React\EventLoop\LoopInterface $loop, React\Socket\Connector $connector, $inner)
{
    $connector->connect('tcp://<IP_ADDRESS>:3306')->
    then(function (\React\Socket\ConnectionInterface $conn) {
        echo ("Hello MySQL!\n");
        $conn->close();
    },function ($e) {
        echo ("Bye MySQL!\n");
    })->done();

    if ($inner) {
        echo "Inner start\n";
        $loop->run();
    }

    echo "Exit runme\n";
}

it works proper and returns:
$ php ./testMysql.php
Exit runme
Outer start
Hello MySQL!
$ php ./testMysql.php  --inner
Inner start
Hello MySQL!
Exit runme

But if you go into \React\Socket\TcpConnector::waitForStreamOnce() and remove $canceller function in new Promise object like below, than it hangs again. Looks like it works in latest version of react a kind of accidentally as socket not stored obvious way, and in fact similar to code in v0.4.6.
private function waitForStreamOnce($stream)
    {
        $loop = $this->loop;

        return new Promise\Promise(function ($resolve, $reject) use ($loop, $stream) {
            $loop->addWriteStream($stream, function ($stream) use ($loop, $resolve, $reject) {
                $loop->removeWriteStream($stream);

                // The following hack looks like the only way to
                // detect connection refused errors with PHP's stream sockets.
                if (false === stream_socket_get_name($stream, true)) {
                    fclose($stream);

                    $reject(new \RuntimeException('Connection refused'));
                } else {
                    $resolve(new Connection($stream, $loop));
                }
            });
        });
    }

$ php ./testMysql.php  --inner
Inner start
.....HANGING
$ php ./testMysql.php
Exit runme
Outer start
...HANGING

Initial discussion here: https://stackoverflow.com/questions/47551054/php-7-1-pecl-event-libevent-is-hanging-in-weird-case

it works proper and returns:
[…]
But if you go into \React\Socket\TcpConnector::waitForStreamOnce() and remove $canceller function in new Promise object like below, than it hangs again. Looks like it works in latest version of react a kind of accidentally as socket not stored obvious way, and in fact similar to code in v0.4.6.

Thanks for reporting, but I'm not sure I follow the problem you're seeing? The first gist seems to work just fine and this only breaks when you manipulate this library? Note that v0.4.6 is somewhat outdated and we have significantly improved our code base and test suite since then.
Can the problem be reproduced with the latest version?

You are correct that problem appears only in case of library's manipulation. But as I understand problem happens because reference to stream/socket is not saved properly and for current version it works accidentally, just because reference is used in cancellation callback. So if I am right, I guess it points to conceptual problem/mistake in architecture that should be solved obvious way.

Thank you for raising this discussion and confirming this behavior! It looks like we may we have found an issue in the underlying EventLoop component thanks to your report and @rosmanov's excellent answer to your SO question.
I've filed a WIP-PR to highlight this issue in the EventLoop component: https://github.com/reactphp/event-loop/pull/123. I don't think there's much that needs to be done here in this component, so I think it makes sense to keep track of the progress there instead.
Thank you!


Vessel warp interface orb is kinda busted in other systems

What Happened?
It glitches out when the interface rises and moves around too much when the interface turns
What was supposed to happen?
No response
Platform
None
Mods
No response
Logs
No response

Seems to not happen if you reload configs in a system with a vessel


Added whitelist and scam

Real: verasity.io
Fake: verasiity.co
0x3c443388038E5103d342410d3D696882F11A2cd8
0x48E1A528413d69ba926395180880cF6CC515237A
0x60cE6FFE0700D899D8baD409e58BBa4135a65fD7
0x9E2627101091A84eD254cf71e7Ba0D9bB387cC1e
0xF02fDE2CAD522d14b0154627006725BD7c101484
0x2f93eb7f9F05C689B2e59c9C3C5D686D5eF03e07
0xc867fC7DeFAA790E184Ea73EdF800F4d8F99B0f7
0xdF9cbfF8ac388e82108E37BbA16914c0B7bE2fC1

Hi @HackenRescue - thanks for the PR - sorry for the delayed response.
Can you put the addresses in 1 record, so like;
addresses
 - '0x12345'
 - '0x98765'

Hi, we are happy to encourage good initiatives. Sure, we will take into
account your recommendations in future requests. Thanks!
2018-05-26 22:47 GMT+03:00 H<EMAIL_ADDRESS>
Hi @HackenRescue https://github.com/HackenRescue - thanks for the PR -
sorry for the delayed response.
Can you put the addresses in 1 record, so like;
addresses

'0x12345'
'0x98765'

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MrLuit/EtherScamDB/pull/862#issuecomment-392284131,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiT19TKgfvVz4P1sfIhUmwWc1YaKDAMeks5t2bE9gaJpZM4UIUy-
.

--
Best regards,
Evgeniya Broshevan
Hacken Team


Fix format query when cursors are empty (fixes Repo.all with limit)

A query used in the new tests called:
format_query(..., [])
which didn't match [cursors] in
defp format_query(%Query{action: :kill_cursors, extra: coll}, [cursors]) do

This seems to introduce more test failures. When I run the tests on my ecto-2 branch, I get 19 failures. When I run the tests on your ecto-2 branch, I get 21 failures.

Closing for lack of activity


Improvements suggestion

hi, @madebyollin ! in article you have asked about level1 optimisation flag - please, take a look at this code. I recommend you to compile your MPSGraph instances using suggested approach. Compiled version is usually faster :)

also, based on my experience, NCHW image tensors is slightly faster comparing to NHWC data layout. But be careful - MPSImage conversion to MPSGraphTensorData requires double tensor transposition. And these transpositions are better to perform as as separated graph - I've experienced a performance hit if I insert transpositions after placeholder.

Thanks for the tips! Turning on the level1 flag seems to have mysterious results (I tried it just on part 3 of the UNet to start):

Huge delay during start of run of the level1-compiled executable
Eventual segfault (Thread 8: EXC_BAD_ACCESS (code=1, address=0x440404410c010880)) in the level1-compiled executable's run

I can try to narrow down further and see if it works on some smaller subgraph, I guess.
I also do need to try NCHW - thanks for the suggestion! Checking my notes, I think I had assumed NHWC would be faster without ever verifying. I don't need to do any conversion to MPSImage AFAIK - but I will need to change the permutes used during self/cross-attention.


Relations (duplicates, related)

[ ] Find related games (based on genre for example)
[ ] Find duplicates

How easy would it be to code it so you can find instances of the same game but different region e.g. (U) / (E) / (J) / World etc. or even a different version e.g. (v1.1) (b1) etc.)?

Currently I am thinking on different approaches here:

Lookup by filename
lookup by gamelist entry
Lookup by HASH (requires support of DAT files)


Merge new changes

Hi Thomas, we hope you are doing well. We just found these two older pull requests made to the  repository. Can you please check if they are still applicable and let us know so that we can merge them with the master branch? Awaiting your response!

Hi Thomas, we hope you are doing well. We just found these two older pull requests made to the  repository. Can you please check if they are still applicable and let us know so that we can merge them with the master branch? Awaiting your response!

Closing the pull as it is no longer valid, as confirmed by Thomas.

Closing the pull as it is no longer valid, as confirmed by Thomas.


feat(footer): add email subscription link

For the Developer Blog, we wanted to give users another easy way to subscribe to content. We ended up linking our RSS feed to FeedBurner, which offers native email publishing based on feed content. The configured link can then point to something like this: https://feedburner.google.com/fb/a/mailverify?uri=WidenDeveloper

Down the road we could also implement an actual HTML form and allow subscribing directly within the blog, but this seemed like a wicked easy first pass. Once this gets merged, implementing apps of this theme just need to provide one new configuration option in their _config.yml.
@forsethc brought up the fact that the version of Ionicon in this theme are really old and the email icon looks kind of bad (we did see that the newer version of Ionicons looks much better: https://ionicons.com/ (current version is v5+). Perhaps we should think of upgrading soon too?

brought up the fact that the version of Ionicon in this theme are really old and the email icon looks kind of bad (we did see that the newer version of Ionicons looks much better: ionicons.com (current version is v5+). Perhaps we should think of upgrading soon too?

I wonder if it'd make sense to use the same icons we use in our application suite 🤔 🤔

I wonder if it'd make sense to use the same icons we use in our application suite where it makes sense 🤔 🤔

What icons are we using? Cory and I were looking into upgrading Ionicons in this theme repo, providing it's not too much work, but we can hold off if there should be some discussion on implementing app suite icons here instead.

@mskelton Thoughts on icons? You have interest in taking a crack at getting us on-brand with the app suite?

@dbeg I'll definitely take a look at getting the icons on brand once I get back from vacation next week.


Remove "pc." from API docs

Goes together with this PR https://github.com/playcanvas/playcanvas-jsdoc-template/pull/26

I would actually prefer that we fixed the .d.ts generation without aliasing any class names. I'm convinced we can hack around this. I don't want to have to make snap API decisions just to get this merged.

I would actually prefer that we fixed the .d.ts generation without aliasing any class names. I'm convinced we can hack around this. I don't want to have to make snap API decisions just to get this merged.

Use this PR instead https://github.com/playcanvas/engine/pull/2876


Comparison to ReactiveNative and React-Style

JSXStyle looks like an awesome solution for ReactJS.
But what is the story if I want to build a solution both for ReactJS and React Native?
There was a comment (twitter?) that if you wanted to reuse your styling information between react js and reactive native that you should use react-style.
What's the possibility of reuse of JSXStyle for React Native, if not in the immediate but at least in the intermediate future?
What problems does React-Style have that JSXStyle does not?

After your edit and re-reading of the readme, I think you answered the question of React-Style (not being inline the component when it really should be part of it).
How about the ReactiveNative part?

Sorry I forgot to respond to this.
The reason react-style is set up the way that it is is so we can easily generate static stylesheets from it (in theory). We hadn't thought too much about an approach that is more heavy on the static analysis and changes the way styles are expressed, as in this repo. I think if I had stayed at FB, I may have ended up convincing them to go this route :)
I believe @vjeux thinks that styles inside of the render() method makes it more cluttered, but I'm not sure if he's actually built an app with it yet :) Once you have higher level layout and style components it becomes pretty slick.


migrating from devise without kicking all sessions out?

Hey 👋 ! Thanks for creating clearance. It looks like a breath of fresh air!
We're currently using devise and hoping to transition to clearance. Ideally, we'd like to automatically recognize existing devise sessions and then "migrate" them to clearance on-the-fly, so users won't even notice that we switched.
I can handle the devise deciphering of cookies/sessions to find out if a user is logged-in, and then I guess we can use sign_in(user) in clearance to migrate. I have a couple of questions however, in case anyone has some experience with this, or maybe just ideas on the best way to do this:

Where is the best place to add this kind of on-the-fly migration code? Do we need a middleware for it? or is there a way to inject it somewhere else early enough before the require_login kicks in? also the initial request after deploying the change will have no clearance cookies set yet...
Is there a better/different way to transition from devise to clearance without logging everyone out?
When digging into this I noticed that devise uses signed cookies for the remember_user_token, whereas clearance just uses a plaintext cookie. Is this secure enough? I imagine signing cookies can eliminate hitting the database / timing attacks via brute-forcing the remember token...

Would appreciate any thoughts / tips. Thank you!

Our current workaround looks something like this (added to config/initializers/clearance.rb)
...

module Clearance
  class Session
    # monkey-patch so we can import the `remember_user_token` from devise
    def current_user
      if remember_token.present?
        @current_user ||= user_from_remember_token(remember_token)
      elsif cookies.signed[:remember_user_token].present?
        @current_user ||= ::User.find_by(:id => cookies.signed[:remember_user_token].first)
      end

      @current_user
    end
  end
end

Hi @gingerlime thanks for opening an issue. I haven't personally done such a migration but I've added some thoughts to your questions.

Where is the best place to add this kind of on-the-fly migration code? Do we need a middleware for it? or is there a way to inject it somewhere else early enough before the require_login kicks in? also the initial request after deploying the change will have no clearance cookies set yet...

Could you use Rails' prepend_before_action to ensure your migration code is run before the require_login before_action? You could look for the Devise token and call sign_in in this before block so that the current_user would be set.

Is there a better/different way to transition from Devise to clearance without logging everyone out?

I'm not sure, but your approach of finding the user via the Devise remember token and signing them in seems reasonable to me.

When digging into this I noticed that devise uses signed cookies for the remember_user_token, whereas clearance just uses a plaintext cookie. Is this secure enough? I imagine signing cookies can eliminate hitting the database / timing attacks via brute-forcing the remember token...

Thanks for opening a PR for this issue. I like the idea of using a signed cookie for the remember token as an attacker would have to guess the token and know the secret_key_base. I'll follow up further in the PR.
I'd like to make sure I understand the timing attack concern correctly. The concern is that because Clearance calls Clearance.configuration.user_model.where(remember_token: token).first an attacker could try tokens such as a, then b, etc, and measure the time the database took to respond. By varying the last character of the token and measuring the response time an attacker could eventually arrive at a valid remember_token and thus gain access to an account.
The mitigation would be to use a signed cookie because without the secret_key_base an attacker would always produce invalid cookie values and as such no remember token would be returned. This eliminates the call to the DB avoiding the timing attack.

Hey @eebs 👋 Thanks for getting back to me.

Could you use Rails' prepend_before_action to ensure your migration code is run before the require_login before_action? You could look for the Devise token and call sign_in in this before block so that the current_user would be set.

Yes, this seems like a great idea. I don't know why I didn't think of it first. I'll give it a try. If it works, then hopefully I can avoid monkey-patching the Session.

I'd like to make sure I understand the timing attack concern correctly. The concern is that because Clearance calls Clearance.configuration.user_model.where(remember_token: token).first an attacker could try tokens such as a, then b, etc, and measure the time the database took to respond. By varying the last character of the token and measuring the response time an attacker could eventually arrive at a valid remember_token and thus gain access to an account.
The mitigation would be to use a signed cookie because without the secret_key_base an attacker would always produce invalid cookie values and as such no remember token would be returned. This eliminates the call to the DB avoiding the timing attack.

Yes, precisely :) you captured it perfectly. it's not a super-simple attack to execute, but certainly possible for a determined attacker. Using a signed cookie eliminates hitting the database even for more casual tampering attempts.

Yes, this seems like a great idea. I don't know why I didn't think of it first. I'll give it a try. If it works, then hopefully I can avoid monkey-patching the Session.

Great, let me know how this goes!

Yes, precisely :) you captured it perfectly. it's not a super-simple attack to execute, but certainly possible for a determined attacker. Using a signed cookie eliminates hitting the database even for more casual tampering attempts.

Excellent, thanks. Let's move this conversation to the PR, I'll provide some thoughts shortly.

I think this would vary too much on a case by case basis. But feel free to document such migration (pull requests with such documentation are welcome).


NUMBERS-163: replacing LinearCombination and Summation with Sum class

Coverage decreased (-0.007%) to 99.659% when pulling 06a613d29c950acff30feb06ac95d54c0d5151ea on darkma773r:numbers-163-sum into d4c00eb68544f3adf258d09ab2c7daf3feb1f8c3 on apache:master.


[Bug]: Multiverse-Core lags server

/mv version -p output
[20:14:54 INFO]: [Multiverse-Core] Multiverse-Core Version: 4.3.13 [20:14:54 INFO]: [Multiverse-Core] Bukkit Version: 1.21-130-b1b5d4c (MC: 1.21) [20:14:54 INFO]: [Multiverse-Core] Loaded Worlds: [{"MVWorld@1671598906":{"Gen":"null","Type":"NORMAL","Env":"THE_END","Name":"world_the_end"}}, {"MVWorld@1679487306":{"Gen":"null","Type":"NORMAL","Env":"NORMAL","Name":"world"}}, {"MVWorld@1012331824":{"Gen":"null","Type":"NORMAL","Env":"NETHER","Name":"world_nether"}}, {"MVWorld@399703826":{"Gen":"null","Type":"NORMAL","Env":"NORMAL","Name":"first"}}] [20:14:54 INFO]: [Multiverse-Core] Multiverse Plugins Loaded: 0 [20:14:54 INFO]: [Multiverse-Core] Economy being used: EssentialsX Economy [20:14:54 INFO]: [Multiverse-Core] Permissions Plugin: Bukkit Permissions (SuperPerms) [20:14:54 INFO]: [Multiverse-Core] Dumping Config Values: (version 2.9) [20:14:54 INFO]: [Multiverse-Core]   enforceaccess: false [20:14:54 INFO]: [Multiverse-Core]   prefixchat: false [20:14:54 INFO]: [Multiverse-Core]   prefixchatformat: [%world%]%chat% [20:14:54 INFO]: [Multiverse-Core]   useasyncchat: true [20:14:54 INFO]: [Multiverse-Core]   teleportintercept: true [20:14:54 INFO]: [Multiverse-Core]   firstspawnoverride: true [20:14:54 INFO]: [Multiverse-Core]   displaypermerrors: true [20:14:54 INFO]: [Multiverse-Core]   enablebuscript: false [20:14:54 INFO]: [Multiverse-Core]   globaldebug: 0 [20:14:54 INFO]: [Multiverse-Core]   silentstart: false [20:14:54 INFO]: [Multiverse-Core]   messagecooldown: 5000 [20:14:54 INFO]: [Multiverse-Core]   version: 2.9 [20:14:54 INFO]: [Multiverse-Core]   firstspawnworld: world [20:14:54 INFO]: [Multiverse-Core]   teleportcooldown: 1000 [20:14:54 INFO]: [Multiverse-Core]   defaultportalsearch: true [20:14:54 INFO]: [Multiverse-Core]   portalsearchradius: 128 [20:14:54 INFO]: [Multiverse-Core]   autopurge: true [20:14:54 INFO]: [Multiverse-Core] Special Code: FRN002
Server logs
https://mclo.gs/QfwTcOO
Server Version
This server is running Paper version 1.21-130-master@b1b5d4c (2024-08-10T10:02:42Z) (Implementing API version 1.21-R0.1-SNAPSHOT)

Bug Description
I saw that server TPS and MSPT were unstable, I checked console and saw this:
[18:23:24] [Server thread/WARN]: [Multiverse-Core] "Multiverse-Core v4.3.13" has registered a listener for org.bukkit.event.entity.EntityCreatePortalEvent on method "public void com.onarandombox.MultiverseCore.listeners.MVPortalListener.entityPortalCreate(org.bukkit.event.entity.EntityCreatePortalEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [dumptruckman, Rigby, fernferret, lithium3141, main--].
Steps to reproduce
Unknown
Agreements

[X] I have searched for and ensured there isn't already an open or resolved issue(s) regarding this.
[X] I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

Duplicate of #2000, non issue


scala-cli: 0.1.20 -> 0.2.0

Description of changes
https://github.com/VirtusLab/scala-cli/releases/tag/v0.2.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

oops, duplicate of #217940


[Asset-Sync] Pave pathway for external contributions to make it to assets

Getting an issue out here to track this improvement after speaking to @christothes and @weshaggard. Context first:

Currently, one needs write access to the azure-sdk-assets repository to push new recordings.
PRs with new/adjusted tests must have recordings updated.
External contributors don't (and won't ever) have direct write access to the azure-sdk-assets repository.

What do we need? An easy way for external contributors to update these recordings.
@christothes reached out with a suggested pattern:

Running test-proxy for recordings always uses a fork of the assets repo

_Currently we use the default git credentials, and one cannot create a fork directly from the git CLI.

_Need to figure out how to "automatically" create a fork, given the fact that we don't actually have access to user config outside of default git creds/git committer email.

_If we are able to figure out how to create a fork, we will know the username of the account. Given that, we can update the proxy to always use fork for push by dynamically updating the remote url.

That push produces its own PR

Currently, data is stored in tags because we deliberately went to point in time. We will need to refactor back to branches and deal with any new errors that result.
If we refactor back go branches, merge conflicts will be possible / probably expected unless we keep the usage like we are still using tags.

The changes push the normal way to generate the language repo PR

External contributor creates PR here.

It is smart enough to link the assets PR in the changes PR

proxy would update the assets.json target repo and tag to point at the new tag in their pipeline.
This would give us an easy way to find the PR against the assets repo.

The CI knows to follow the fork assets PR to resolve the recordings to pass CIs

If we update the assets to their fork, this would automatically happen.

Assets PR is approved, merging the assets and updating the linked PR assets.json

A build from the assets repo will trigger and auto-commit updates to the linked PR assets.json.
Possibly don't have write access to the branch, so we need a fallback option to leave a code suggestion or a comment.

CI can optionally run again against the asset repo/main
Parent PR can now be merged

The top level statements are from Chris, any italic sub-bullets are details or gotchas. Frankly, parts of this could definitely work, but I also have serious reservations about what we'll be expecting the proxy to do given zero configuration. Right now, we are expecting that someone's git config is solid, but that's it. We don't require a PAT so it would be difficult to fork the assets repo on the fly. Willing to listen to suggestions here!
I believe that having a simple job that can be run against a PR to record changes just for the updated package and then (in descending order)

Run tests of affected packages in record mode.
test-proxy push
Push a commit to the branch reflecting updated assets.json tag.
Leave a code suggestion on the PR (requires assets.json to be a changed file).
Leave a comment with the tag they should use.

This fullfills the same purpose, means that you don't need to visually review a block of new recordings for malignant code, and has the dual purpose use of benefitting the management folks. Often all they need to do after updating a package version is to re-run recordings. It would be pretty cool to entirely skip that in favor of a PR comment!

This fullfills the same purpose, means that you don't need to visually review a block of new recordings for malignant code, and has the dual purpose use of benefitting the management folks.

IMO, lack of PR visibility for recording changes is closer to a bug than a feature. I'd personally love to see a solution that preserves that one advantage of having recordings in the same repo as the code.


Database name is hardcode to core and cannot specified in manifest

Deploy harbor operator and deploy harbor with manifest, found it failed to connect to database "core"
After create a database "core" in postgres, the core container works now, it seems that the database name is hardcoded and can not be specified.

@heww
Would you please confirm if it is fixed in the harbor?

Yes, the database name is fixed but can include a prefix.
For the core, notary server, notary signer the database names are core, notaryserver, notarysigner.
The prefix can be set by the prefix in the database field of the harbor spec. For example with a prefix harbor- the database names will be harbor-core, harbor-notaryserver, notarysigner

Will mention this in the doc


Failed to install with ConstraintsNotSatisfiable error

Describe the bug
When trying to install Web Terminal Operator 1.5 on Openshift 4.10, it gets stuck with an 'unknown failure'.
In the Conditions section, it states:
Type: ResolutionFailedTrue
Reason: ConstraintsNotSatisfiable
Message: constraints not satisfiable: no operators found in package cert-manager-operator in the catalog referenced by subscription cert-manager-operator, subscription cert-manager-operator exists
The only related thing I can see is that we also have the cert-manager operator 1.1.0 provided by Jetstack installed, but I can't see anything in the docs here about dependency requirements other than Dev workspaces.
Environment
Cloud:

[x] AWS
[ ] Azure
[ ] GCP
[ ] other (please specify)

OpenShift Version: 4.10.13

I have a similar bug in IBM OKD 4.10 & 4.11, complaining about missing devworkspace v1alpha1, when its there.

Same here:
constraints not satisfiable: subscription web-terminal requires redhat-operators/openshift-marketplace/fast/web-terminal.v1.5.1, subscription web-terminal exists, clusterserviceversion web-terminal.v1.4.0 exists and is not referenced by a subscription, @existing/openshift-operators//web-terminal.v1.4.0, redhat-operators/openshift-marketplace/fast/web-terminal.v1.2.1 and redhat-operators/openshift-marketplace/fast/web-terminal.v1.5.1 originate from package web-terminal

but it does not actually exist:
k get clusterserviceversion -A|grep -i terminal

These seem to be issues around the Operator Lifecycle Manager (OLM) installing the operator. I'm not sure there's much we can on our end to fix these issues, but asking on that end may yield more information -- we've run into a few issues in the past around installing operators, e.g.

https://issues.redhat.com/browse/OCPBUGS-2040
https://issues.redhat.com/browse/OCPBUGS-1436
https://github.com/operator-framework/operator-lifecycle-manager/issues/2830

In most cases, uninstalling the operator that is causing the issue and reinstalling it should fix the issue.

Similar issue encountered in web-terminal 1.7.0

apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: >
      {"apiVersion":"operators.coreos.com/v1alpha1","kind":"Subscription","metadata":{"annotations":{},"labels":{"app.kubernetes.io/instance":"c12-web-terminal"},"name":"web-terminal","namespace":"openshift-operators"},"spec":{"channel":"fast","installPlanApproval":"Automatic","name":"web-terminal","source":"sw-op-web-terminal-1-7-0","sourceNamespace":"openshift-marketplace"}}
  creationTimestamp: '2023-10-11T18:59:12Z'
  generation: 1
  labels:
    app.kubernetes.io/instance: cXX-web-terminal
    operators.coreos.com/web-terminal.openshift-operators: ''
  name: web-terminal
  namespace: openshift-operators
  resourceVersion: '60206'
  uid: 6b00d00c-3934-4795-9601-07fa56133230
spec:
  channel: fast
  installPlanApproval: Automatic
  name: web-terminal
  source: sw-op-web-terminal-1-7-0
  sourceNamespace: openshift-marketplace
status:
  catalogHealth:
    - catalogSourceRef:
        apiVersion: operators.coreos.com/v1alpha1
        kind: CatalogSource
        name: sw-op-advanced-cluster-management-2-8-0
        namespace: openshift-marketplace
        resourceVersion: '48924'
        uid: 7cb481f6-44a1-4bd0-9d1d-7594400a1076
      healthy: true
      lastUpdated: '2023-10-11T18:59:46Z'
    - catalogSourceRef:
        apiVersion: operators.coreos.com/v1alpha1
        kind: CatalogSource
        name: sw-op-compliance-operator-1-2-0
        namespace: openshift-marketplace
        resourceVersion: '48794'
        uid: 10a97d65-0471-4bd2-bb12-6546de710afb
      healthy: true
      lastUpdated: '2023-10-11T18:59:46Z'
    - catalogSourceRef:
        apiVersion: operators.coreos.com/v1alpha1
        kind: CatalogSource
        name: sw-op-metallb-operator-4-12-0-202307072355
        namespace: openshift-marketplace
        resourceVersion: '48985'
        uid: 8003458b-0c48-47d2-934f-20bc45eb8f4c
      healthy: true
      lastUpdated: '2023-10-11T18:59:46Z'
    - catalogSourceRef:
        apiVersion: operators.coreos.com/v1alpha1
        kind: CatalogSource
        name: sw-op-multicluster-engine-2-3-1
        namespace: openshift-marketplace
        resourceVersion: '48916'
        uid: 29cf2907-3919-4811-bece-241c68366246
      healthy: true
      lastUpdated: '2023-10-11T18:59:46Z'
    - catalogSourceRef:
        apiVersion: operators.coreos.com/v1alpha1
        kind: CatalogSource
        name: sw-op-node-healthcheck-operator-0-5-1
        namespace: openshift-marketplace
        resourceVersion: '48809'
        uid: 78d07780-d597-41c0-9b6a-91381d55a4ab
      healthy: true
      lastUpdated: '2023-10-11T18:59:46Z'
    - catalogSourceRef:
        apiVersion: operators.coreos.com/v1alpha1
        kind: CatalogSource
        name: sw-op-openshift-gitops-operator-1-8-3
        namespace: openshift-marketplace
        resourceVersion: '48973'
        uid: 089481e8-54e4-4332-b56e-a34cd2480185
      healthy: true
      lastUpdated: '2023-10-11T18:59:46Z'
    - catalogSourceRef:
        apiVersion: operators.coreos.com/v1alpha1
        kind: CatalogSource
        name: sw-op-rhacs-operator-4-1-3
        namespace: openshift-marketplace
        resourceVersion: '48761'
        uid: ee0f8606-331e-4df7-9e00-1a2362e0e32e
      healthy: true
      lastUpdated: '2023-10-11T18:59:46Z'
    - catalogSourceRef:
        apiVersion: operators.coreos.com/v1alpha1
        kind: CatalogSource
        name: sw-op-web-terminal-1-7-0
        namespace: openshift-marketplace
        resourceVersion: '48756'
        uid: 4e014993-b2b3-48f1-acdd-23f9b8976268
      healthy: true
      lastUpdated: '2023-10-11T18:59:46Z'
  conditions:
    - lastTransitionTime: '2023-10-11T18:59:46Z'
      message: all available catalogsources are healthy
      reason: AllCatalogSourcesHealthy
      status: 'False'
      type: CatalogSourcesUnhealthy
    - lastTransitionTime: '2023-10-11T19:05:09Z'
      message: >-
        error validating existing CRs against new CRD's schema for
        "devworkspaces.workspace.devfile.io": error listing resources in
        GroupVersionResource
        schema.GroupVersionResource{Group:"workspace.devfile.io",
        Version:"v1alpha1", Resource:"devworkspaces"}: Internal error occurred:
        error resolving resource
      reason: InstallComponentFailed
      status: 'True'
      type: InstallPlanFailed
  currentCSV: web-terminal.v1.7.0-0.1684429884.p
  installPlanGeneration: 1
  installPlanRef:
    apiVersion: operators.coreos.com/v1alpha1
    kind: InstallPlan
    name: install-85b9w
    namespace: openshift-operators
    resourceVersion: '50608'
    uid: ca72cbaf-a04a-4017-af8a-c82e150fdf3a
  installedCSV: web-terminal.v1.7.0-0.1684429884.p
  installplan:
    apiVersion: operators.coreos.com/v1alpha1
    kind: InstallPlan
    name: install-85b9w
    uuid: ca72cbaf-a04a-4017-af8a-c82e150fdf3a
  lastUpdated: '2023-10-11T19:05:09Z'
  state: AtLatestKnown


Add topic to Designer Ui Test

Allow users of Designer Ui to test questions in a context.

related to #38


Error in Transmission: Permission Denied

Hello!
I will start off and say great job on the container setup!
However, when downloading a file in Transmission, I am getting Permission Denied errors.
The only change I made was targeting the Downloads folder to a different place that is not in the same location as the rest of the config files.
Any help is greatly appreciated!

Found it was a config error


085 phonenumber not allowed

Expected behavior
Allow any phonenumber even when it starts with 085.
Actual behavior
See title
Steps to reproduce the behavior
Enter a phone number which starts with 085, this is not allowed in the Netherlands. When you enter a local extension like 020 it works fine.
But 085 is used for companies, just like 088
Environment

PrestaShop version: <IP_ADDRESS>
Mollie module version: 4.1.1
PHP version: 7.3.0

Hey, thanks for your message.
We've registered the error, and passed it to our engineers, and will update you on this thread.
--
Best Regards
Invertus Support Team

@jacob-v-dam We were not able to re-create the issue from our end. Would you be able to maybe share some detailed screenshots and steps of how we can reproduce this issue from our end?
--
Best regards
Invertus Support team

You can use my business number, this causes an error.
I use a one page checkout module, but this also happens with the normal checkout.

Thanks for that, will check further!
--
Best regards
Invertus Support team

Hey, unfortunately we could not encounter any errors, even when adding the same details as you've pasted above, we recreated the issue on PS1770 demo.
--
Best regards
Invertus Support team

Maybe you could also provide a screenshot of the error itself after you've done it with the same credentials from your end? It would definitely help us identifying the issue.
Thank you, and looking forward to your reply!
--
Best regards
Invertus Support team

@jacob-v-dam are you still encountering this issue? Or you've found a resolution?
Looking forward to your reply!
--
Best regards
Invertus Support team

I still am. I updated to version 4.1.2.

Thank you for your update, we're continuing the research on why this is happening, and will fix it as soon as possible!
Thank you for your patience.
Best regards,
Invertus Support team

Hello @jacob-v-dam could you clarify if the issue persists with the latest Mollie version 4.1.3? You can download it here - https://github.com/mollie/Prestashop/releases
If 085 phone is still not allowed, please let me know!
Looking forward to your reply!
Best regards,
Invertus Support team

Hello @jacob-v-dam could you clarify if the issue persists with the latest Mollie version 4.1.3? You can download it here - https://github.com/mollie/Prestashop/releases
If 085 phone is still not allowed, please let me know!
Looking forward to your reply!
Best regards,
Invertus Support team

Hello, hope you're having a nice day!
The official Mollie 4.2.0 was just released, the fix was implemented, you can download the latest version here - https://github.com/mollie/PrestaShop/releases/tag/4.2.0
Any feedback regarding the updated version is greatly appreciated!
--

Best regards,

Invertus Support team

Hello, hope you're having a nice day!
The official Mollie 4.2.0 was just released, the fix was implemented, you can download the latest version here - https://github.com/mollie/PrestaShop/releases/tag/4.2.0
Any feedback regarding the updated version is greatly appreciated!
--

Best regards,

Invertus Support team