[Question]: Incorrect foreground service type From Android 14 - Publishing overview - Play Store

Please check the following before submitting a new issue.

[X] I have searched the existing issues.
[X] I have carefully read the documentation.

Please select for which platform(s) you need help

[X] Android
[ ] iOS
[ ] Linux
[ ] macOS
[ ] Web
[ ] Windows

Your question
Incorrect foreground service type
From Android 14, developers must specify service types when foreground services are found in their app's manifest. Starting services with different types may cause your app to crash.
Your app's manifest declares com.baseflow.geolocator.GeolocatorLocationService, which starts in the foreground in the following place:
com.baseflow.geolocator.GeolocatorLocationService.com.baseflow.geolocator.GeolocatorLocationService.f
Make sure that service types passed to startForeground() match what is specified in your app's manifest.
geolocator: ^13.0.1
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION"/>

Version
13.0.1

I have the same problem, I still don't know how to solve it.

Dear @developerflutter,
When do you see this message? Is this message coming from the play store?
Kind regards,

Screenshots attached.

Dear @developerflutter,
Can you paste the contents of your app manifest to this issue? It helps a lot investigating and resolving this issue.
Kind regards,

<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION"/>
<uses-permission android:name="android.permission.FOREGROUND_SERVICE"/>
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_LOCATION"/>

<service
        android:name="id.flutter.flutter_background_service.BackgroundService"
        android:foregroundServiceType="location"
 />

Hi @developerflutter,
The geolocator plugin should automatically add the correct <service ../> element to the applications manifest file when the application is compiled into an appbundle or apk file.
Easiest way to validate this is by analyzing the .apk using Android Studio:

Make sure to build an .apk of your application.
Open Android Studio and go to "Build" -> "Analyze APK" (no need to open a project first).
Next navigate to the .apk file that you just build and is should show the final AndroidManifest file for your application.

In my tests the application contains the following service declaration (note that there was no need for me to add this myself to the AndroidManifest.xml file):
        <service
            android:name="com.baseflow.geolocator.GeolocatorLocationService"
            android:enabled="true"
            android:exported="false"
            android:foregroundServiceType="0x8" />

The value 0x8 translates to the location enum value as documented here: https://developer.android.com/reference/android/R.attr#foregroundServiceType
Can you verify if this is also the case for your application. If you add your own <service ... /> declaration please try to remove it. Or if the declaration in missing in your final AndroidManifest.xml file please try adding it manually in the android/app/src/main/AndroidManifest.xml by copy/ pasting the above XML.
Please let me know if this helped.


Create build pipeline and needed elements for nuget

Description

Create build pipeline and needed elements for nuget
Motivation and Context

Create build pipeline and needed elements for nuget

How Has This Been Tested?

Screenshots
Types of changes

[x] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
[x] New feature (non-breaking change which adds functionality to code)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[x] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[ ] Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
[ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project (only if there are changes in source code).
[ ] My changes require an update to the documentation (there are changes that require the docs website to be updated).
[ ] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
[x] I have read the CONTRIBUTING document.
[x] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
[x] I have added new tests to cover my changes.

@nfbot updatedependencies

@nfbot updatedependencies


fix crash for ios when localPort or connectedPort is null

@Yahui-Ren, with your changes, no event will be emitted, so the socket will never connect.


Child theme CSS

Hello. Nice work.
I was trying to do a child-theme to keep the main one in tact. Seems it doesn't support it? (just me or anyone else getting this issue?)

Sorry, I should have stated that this is more specifically towards the style.css file.
Doing this still works @import url('../reverie/style.css'); just thought it would do a link.rel on the html markup like Roots. Hope that clarifies it.
TIA

Just took a look at Roots theme (in their roots-actions.php line 111). They seem to apply a custom function to automatically input the HTML markup for the style.css for child theme. You can do the same thing but the reason that I didn't include is because 99% of the CSS, JS and other fancy stuffs are done by Foundation, thus I don't think the users will use the style.css to build their child theme.

I see. Can you point me in the right direction on how to do that? Just wish it was easier to add custom style sheets along reverie. That is, it loads like this in the HTML markup:

<!-- Included Foundation CSS Files -->
<link rel="stylesheet" href="http://justamemo.com/wp/wp-content/themes/reverie/css/foundation.css">
<link rel="stylesheet" href="http://justamemo.com/wp/wp-content/themes/reverie/css/app.css">

I took a look at the roots-actions.php file. I see what you are looking at:
  if (is_child_theme()) {
    $styles .= stylesheet_link_tag('/style.css', 1);
    $styles .= "\t<link rel=\"stylesheet\" href=\"" . get_stylesheet_uri(). "\">\n";
  } else {
    $styles .= stylesheet_link_tag('/style.css', 1);
  }

I'll add this to the child theme's header.php. With some edits of course. Unless there's another way? Please do tell. TIA

Just did the following in header.php if anyone else can use it in the same situation. HTH
    <link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/style.css">

    <!-- Included Foundation CSS Files -->
    <link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/foundation.css">
    <link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/app.css">

    <?php if (is_child_theme()) { ?>
    <!-- Include Child theme CSS file -->
    <link rel="stylesheet" href="<?php bloginfo('stylesheet_url'); ?>">
    <?php } ?>

Wound't it be best to use wp_enqueue_style for all the stylesheets? Then you can modify them in any way from a child theme. Even disable app.css, orbit.css, etc if you are not using them.
I'm starting a project tomorrow and will be trying out reverie, so I'll see if I can get it figured out in the next few days.


Use UNSAFE.getLong() to speed up BitSetMethods#anySet()

@JoshRosen
Please take a look

Can one of the admins verify this patch?

Jenkins, add to whitelist and test this please.

Merged build triggered.

Merged build started.

Test build #31800 has started for   PR 5897 at commit 4ca0ef6.

Test build #31800 has finished for   PR 5897 at commit 4ca0ef6.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31800/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #31808 has started for   PR 5897 at commit 63ee050.

Test build #31808 has finished for   PR 5897 at commit 63ee050.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31808/
Test FAILed.

From failed test:
bq. [error] oro#oro;2.0.8!oro.jar origin location must be absolute: file:/home/jenkins/.m2/repository/oro/oro/2.0.8/oro-2.0.8.jar
Pretty sure the above is not caused by my change

Merged build triggered.

Merged build started.

Test build #31809 has started for   PR 5897 at commit 093b7a4.

Test build #31809 has finished for   PR 5897 at commit 093b7a4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class ShuffleHandle(val shuffleId: Int) extends Serializable
  *   class SomethingNotSerializable
      logDebug(s" + cloning the object $obj of class $
abstract class Evaluator extends Params
abstract class PipelineStage extends Params with Logging
class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol
trait LDAOptimizer
class EMLDAOptimizer extends LDAOptimizer
class OnlineLDAOptimizer extends LDAOptimizer
class SaslEncryption
 static class EncryptedMessage extends AbstractReferenceCounted implements FileRegion
class SaslRpcHandler extends RpcHandler
public class SaslServerBootstrap implements TransportServerBootstrap
public class SparkSaslClient implements SaslEncryptionBackend
public class SparkSaslServer implements SaslEncryptionBackend
public class ByteArrayWritableChannel implements WritableByteChannel
class ParamGridBuilder(object):
abstract class Dialect
  class DialectException(msg: String, cause: Throwable) extends Exception(msg, cause)
case class HiveDatabase(
abstract class TableType
case class HiveStorageDescriptor(
case class HivePartition(
case class HiveColumn(name: String, hiveType: String, comment: String)
case class HiveTable(
trait ClientInterface
class ClientWrapper(
class IsolatedClientLoader(
protected trait ReflectionMagic
 protected implicit class InstanceMagic(a: Any)
 protected implicit class StaticMagic(c: Class[_])

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31809/
Test FAILed.

From https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31809/testReport/junit/org.apache.spark.deploy/SparkSubmitSuite/includes_jars_passed_in_through___jars/ :
sbt.ForkMain$ForkError: The code passed to failAfter did not complete within 60 seconds.
at org.scalatest.concurrent.Timeouts$$anonfun$failAfter$1.apply(Timeouts.scala:249)
at org.scalatest.concurrent.Timeouts$$anonfun$failAfter$1.apply(Timeouts.scala:249)
I think the above was not related to my change.
bq. This patch adds the following public classes (experimental)
This change doesn't add any public class.

Jenkins, retest this please.

Merged build triggered.

Merged build started.

Test build #31835 has started for   PR 5897 at commit 093b7a4.

Test build #31835 has finished for   PR 5897 at commit 093b7a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31835/
Test PASSed.

Jenkins, test this please.

Merged build triggered.

Merged build started.

Test build #31868 has started for   PR 5897 at commit 093b7a4.

Test build #31868 has finished for   PR 5897 at commit 093b7a4.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31868/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #31878 has started for   PR 5897 at commit 855374b.

Test build #31878 has finished for   PR 5897 at commit 855374b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31878/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #31934 has started for   PR 5897 at commit 75a467b.

Test build #31934 has finished for   PR 5897 at commit 75a467b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31934/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #31946 has started for   PR 5897 at commit 817e3f9.

Test build #31946 has finished for   PR 5897 at commit 817e3f9.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class ShuffleHandle(val shuffleId: Int) extends Serializable
  *   class SomethingNotSerializable
      logDebug(s" + cloning the object $obj of class $
abstract class Evaluator extends Params
abstract class PipelineStage extends Params with Logging
class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol
trait LDAOptimizer
class EMLDAOptimizer extends LDAOptimizer
class OnlineLDAOptimizer extends LDAOptimizer
class SaslEncryption
 static class EncryptedMessage extends AbstractReferenceCounted implements FileRegion
class SaslRpcHandler extends RpcHandler
public class SaslServerBootstrap implements TransportServerBootstrap
public class SparkSaslClient implements SaslEncryptionBackend
public class SparkSaslServer implements SaslEncryptionBackend
public class ByteArrayWritableChannel implements WritableByteChannel
class ParamGridBuilder(object):
abstract class Dialect
  class DialectException(msg: String, cause: Throwable) extends Exception(msg, cause)
case class HiveDatabase(
abstract class TableType
case class HiveStorageDescriptor(
case class HivePartition(
case class HiveColumn(name: String, hiveType: String, comment: String)
case class HiveTable(
trait ClientInterface
class ClientWrapper(
class IsolatedClientLoader(
protected trait ReflectionMagic
 protected implicit class InstanceMagic(a: Any)
 protected implicit class StaticMagic(c: Class[_])

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31946/
Test PASSed.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #32012 has started for   PR 5897 at commit b51dcaf.

Test build #32012 has finished for   PR 5897 at commit b51dcaf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32012/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32026 has started for   PR 5897 at commit 1719c5b.

Test build #32026 has finished for   PR 5897 at commit 1719c5b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class Model(Transformer):
class PipelineModel(Model):
class CrossValidator(Estimator):
class CrossValidatorModel(Model):
class JavaModel(Model, JavaTransformer):

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32026/
Test FAILed.

Merged build finished. Test FAILed.

[error] /home/jenkins/workspace/SparkPullRequestBuilder@2/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveWindowFunctionQuerySuite.scala:769: not found: type HiveCompatibilitySuite
[error]   extends HiveCompatibilitySuite with BeforeAndAfter {
[error]           ^
[error] /home/jenkins/workspace/SparkPullRequestBuilder@2/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveWindowFunctionQuerySuite.scala:828: value testCases is not a member of org.scalatest.BeforeAndAfter
[error]   override def testCases: Seq[(String, File)] = super.testCases.filter {
[error]                                                       ^
I don't think the above error was related to my change.
BitSetSuite passed:
[info] Test org.apache.spark.unsafe.bitset.BitSetSuite.basicOps started
[info] Test org.apache.spark.unsafe.bitset.BitSetSuite.traversal started
[info] Test run finished: 0 failed, 0 ignored, 2 total, 0.012s

Test build #771 has started for   PR 5897 at commit 1719c5b.

Merged build triggered.

Merged build started.

Test build #32037 has started for   PR 5897 at commit 473bf9d.

Test build #771 has finished for   PR 5897 at commit 1719c5b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #32037 has finished for   PR 5897 at commit 473bf9d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32037/
Test PASSed.

@tedyu also please file a JIRA that tracks this improvement and put it in the title. See how other PRs are opened.

SPARK-7450 has been filed

This looks fine; I have two minor nits because I'm really pedantic, but I'll just deal with it on merge.

bq. I'm really pedantic
I like that :-)

Merged to master and branch-1.4 (1.4.0).  Thanks!


ACS AEM reports works on author instance but not publisher

Required Information
Version: AEM 6.5.10 and ACS AEM Commons 5.0.6
Expected Behavior
When we run the ACS AEM report on the Author instance, it runs fine.
Actual Behavior
When we run it on the Publish instance, it fails and we get the following error:
18.02.2022 12:26:29.772 ERROR [<IP_ADDRESS> [1645205186151] GET /var/acs-commons/reports/users-on-jhi-manulife-sites/jcr:content.report.csv HTTP/1.1] org.apache.sling.engine.impl.SlingRequestProcessorImpl Writer has already been closed.
Steps to Reproduce
Log into /var/acs-commons/reports/users-on-jhi-manulife-sites.htm and execute report
Links
https://adobe-consulting-services.github.io/acs-aem-commons/features/report-builder/index.html

Also we see the following error on the client side. Is there a way to enable CORS for just ACS AEM Commons on the publisher?
`Ensure CORS response header values are valid
A cross-origin resource sharing (CORS) request was blocked because of invalid or missing response headers of the request or the associated preflight request .`


WIP notary delegation integration into docker

Adds newest notary code into docker, which includes delegations.
Docker changes:

We prioritize a releases delegation role as a highest priority, but fall back to the targets role if the releases delegation role does not exist
Update integration tests to comply with new notary error formats and server configuration format

Notary changes:

Also introduces remote snapshot signing (the snapshot key will be maintained on the server) to allow for delegation functionality
Key role information is now included in PEM headers rather than as a suffix on the key filename, but the code is backwards compatible with older keys on old repos/clients
Command line key rotation for a single key and/or having the server manage the snapshot key

Caveats:

Old clients cannot push to repos created or updated by new clients
Old clients cannot read keys on new repos created by new clients

Signed-off-by: Riyaz Faizullabhoy<EMAIL_ADDRESS>

Moving to code review as there is no feature impact (yet) as far as I can tell.
@riyazdf Can you explain what's "WIP" about this PR?

it looks like @GordonTheTurtle didn't trigger anything for this PR, weird.

@calavera apparently that can be if there's a network hiccup between github and our CI, running !rebuild will start them :-)

@icecrime this is WIP because we're aiming to add an additional cli command to notary to manage delegations, and add additional integration tests to docker/docker for these features.
cc @docker/security-team

I see. I'm going to move this back to design review as UX change are incoming.
Anything we can read to learn how this will surface in the Docker CLI?

@icecrime I'm not sure that any changes will surface to Docker CLI for this PR, maybe aside from a password environment variable.  The CLI changes we wanted to make were to notary client CLI so that we can use it in integration tests.
Here is a preview of a test-in-progress we wanted to add (this comparison view may break as this branch rebased).  It currently imports the notary library into the integration tests, in order to set up the delegation.  We'd like to add to the Notary CLI so we can just use the binary instead - the test is to make sure that in a future version (1.11?), when we add the releases delegation role and delegated keys, that this version of Docker (1.10) will be able to read from and write to it.
The test as written adds an extra environment variable for the delegation key, only because I just wasn't sure how shoehorn the password in for signing for this test.  I'm not sure we ultimately want to add that change this PR.

@cyli Thanks for clarifying, my bad for assuming that this would have more impact on Engine CLI side. Does it mean that we should proceed with code review here, or should we still wait for updates?

To my knowledge there shouldn't be any changes to the Engine CLI side (@diogomonica and @endophage please correct me if I'm wrong), so we should be able to proceed.
Thank you @icecrime and @aaronlehmann for the helpful comments so far! :smile:

For this PR, that leaves us with the changes in api/client/trust.go to review on Engine side, so I'm inclined to say LGTM as this is essentially a dependency bump.

LGTM.
@icecrime Your LGTM doesn't look very confident, so I'll leave to you to merge :)

Pending @aaronlehmann's comments.

ping @icecrime looks like the PR was updated :)

Update on my end: we're waiting on a couple more fixes on the notary side as well as some error message improvement in docker for the notary integration.  I'll ping once these are in :)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "notary-delegations" git@github.com:riyazdf/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~5
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Looks like we would not be able to merge this PR because of merge conflicts. Please rebase, fix conflicts, and force push to your branch.

removed WIP, thanks for being patient :)
The latest changes addressed the above comments, revendored notary, and updated docker with updated error messages and an integration test

LGTM

LGTM when green

If you don't mind squashing commits + tagging the notary release for bonus points ;-)

oooo ya tag, i always tag it for you all :P

Apologies for repeating this, since I think I asked this in a collapsed convo, but what should we tag with? Should we tag the commit with the docker commit, the docker version, or both? (asking in case we have to re-vender notary twice in the same docker version - then two commits would be tagged with the same docker version)

so for example engine api tagged 0.1.3 https://github.com/docker/docker/pull/19173 and make that pr to up the version... this is a lot how it is done on runc too... so like a semver version according to what you changed

also checkout this https://github.com/docker/docker/pull/19053

@jfrazelle Oh ok!  thanks!

Sounds good, I can definitely squash commits (I'm thinking 3 makes most logical sense, but let me know if you prefer just 1) and handle the tag.  I'm discussing with the team for the best version tag to use and should have this wrapped up tomorrow morning :)

so is this actually good to merge now?

Wait until the tag :)
On Jan 8, 2016, 03:44 -0800, Antonio<EMAIL_ADDRESS>wrote:

so is this actually good to merge now?
—
Reply to this email directly orview it on GitHub(https://github.com/docker/docker/pull/18887#issuecomment-169974261).

Added the tag docker-v1.10-1 (we can increment the last number if we need to revendor notary for this docker 1.10 version) and squashed down into 3 commits, thanks!

thanks! will merge when green :)

may the jenkins gods be ever in your favor :smile:


create LCs with latest AMI

Having confirmed that Delta now successfully reads AWS's AMI update webhooks, let's use this info.

@benwaffle this still seems pretty useful. do you want to merge at some point?

yeah, let's do it monday morning


Add SUSE linux support to installer

Build fails with
Failed to fetch store:/var/lib/apt/lists/partial/repo.mongodb.org_apt_ubuntu_dists_trusty_mongodb-org_3.2_multiverse_binary-i386_Packages  Empty files can't be valid archives

I think the merge should be fine, but you've got CI issues.


Published after rename Blog Slug

Just change "Blog" title to "Articles" and save.
After rename "blog" Slug to "articles" and save again.
1 post is Unpublished and impossible to change status to "Published".

I tried the steps but don't get the issue. Could you please post the content of the affected pages?

Oops, I'm not saying anything.
I had added an end of publication for March 18th (it is already midnight lol)


Questions about negative data.

Thank you for your great work! I have a few questions regarding the data you open-sourced on HuggingFace.

I understand that the data with type "mllm-hal" is constructed using the "image-weaken" method mentioned in your paper. Why is there only around 20k of this type of data, while the other type "llm-hal" amounts to 160k? Why is there such a significant difference in the number of data points between these two types?
As I understand it, you randomly selected around 160k data points from the ShareGPT-V, LLaVAR, and LLaVA-Instruct datasets to construct negative data. If we denote the data used to construct llm-hal as A and the data used to construct mllm-hal as B, does B completely overlap with A? Based on my tests, the numbers do not match up.
When I run the following code, the output is 167710 and 168180, indicating that these two parts do not completely overlap:

SSS = set()
with open(file_path, 'r') as f:
    datas = json.load(f)
    for data in datas:
        image = data['image']
        prompt = data['prompt']
        for cc in data['completions']:
            if cc['type'] == 'gt':
                SSS.add(cc['response'] + ' ' + prompt + ' ' + image)
print(57906 + 55445 + 54359)  # The sample sizes from the three datasets mentioned in Table 2 of your paper
print(len(SSS))

Could you please provide some clarification on these points? I look forward to your response.
Thank you for your time and assistance.

Hi! Thanks a lot for your interest in our work!
Indeed, the scale difference between image weakening and error injection is because by the time of this work, there was no acceleration package for MLLM inference, which makes the generation of image-weakened responses much slower. On the other hand, VLLM is able to greatly accelerate the generation of error injection responses, since they are completely based on LLM. Due to computational limitation, we chose to scale up error injection for negative responses.
However, we note that recently, there are acceleration packages for MLLMs, for example, LMdeploy: https://github.com/InternLM/lmdeploy

Thanks for your quick reply! Besides the above questions, I have one more:
Did you start the training from LLaVA-v1.5-7b (after SFT), or from LLaVA-1.5-7b (after pretraining only)?

Hi! Sorry for the late response. Actually we start from the checkpoint after SFT. I have updated the training script accordingly. Please directly load from the SFT version of LLaVA. Sorry for the misunderstanding!


Make debian docker

Adding a docker image that generated the debians and a script that runs everything and copies the files out.
Took out some useless steps on the cross compile docker.

I added both Brian and Katie as reviewers, but only one needs to do it, I just wasn't sure who to ask.

I added both Brian and Katie as reviewers, but only one needs to do it, I just wasn't sure who to ask.


Visual Exploration menu is missing from scatter plot

1: Create a scatter plot
2: Right click to get context menu
Notice that the Visual Exploration menu is not seen

Fixed!


Witness Result rendering

Following this update f353ad5b8d18e8022d199398f2c51280de534989, the extension can now render the results of verification rather than simply printing raw HTML returned from the verifier.
We should use the conventions established here to display the result: https://github.com/inblockio/aqua-verifier-webextension/issues/47#issuecomment-1016208813. Specifically this section:

Witness
⛓ Witness transaction hash 0x17cb36....db79d7
✅ ⌚ Witness event hash has been verified on Goerli
✅ 🌿 Witness Merkle Proof is OK
❌ ⌚ Witness event can not be verified on Goerli
❌ Witness event verification hash doesn't match
❌ 🌿 Witness Merkle Proof is corrupted

example witness_result response for a revision verification:
 witness_result: {
  actual_witness_event_verification_hash: "12e91cef09aaffd798a70a09cba3b91599b0e4f30e90ec158f0985e5abf8705ce0a825d5c4607b9303209412d5a71f008a18f501b303bd95a3197559fee6b350",
  doVerifyMerkleProof: true,
  etherscan_error_message: "",
  etherscan_result: "true",
  extra: null,
  merkle_proof_status: "VALID",
  tx_hash: "0xd03452da146dd6e56d53bc7962cd8e0aa22fb773edfac6b859cfb3c2a940e24a",
  witness_event_vh_matches: true,
  witness_hash: "df746ebbf91a138a748da376c60353c41b22389bcc393029da49e9a7b2e1e037005866f8c7c4484ea89fe12da1f26a32a044ea2747700c184e852f097163f358",
  witness_network: "goerli",
}

Because UX is still unclear, lets start with rendering.
UX Questions:

how is the user going to interact with this data
should links open in new window, what should be a link
how much of a hash should be presented to the user
list of results vs table
what is critical information needed for 'short' view and how should that be presented
how does information presented in a single revision row for a document relate to other rows in the table

Please use an imperative language for the git commit @lobogang there is no way to put this into the linter. ;-)


react-wordcloud native?

In the future, do you have a version for reaccion-native (d3-svg)?

Hi @warlock, don't plan to build one for react native.  Is this as simple as swapping d3 for d3-svg?

Probably. I Investigate when I return from a trip. I inform you soon.

still working?


Rocket/shoegaze template GitHub test

Ticket
https://wicmtdp.atlassian.net/browse/{TICKET_ID}
Changes

What was added, updated, or removed in this PR.

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

Testing

Screenshots, GIF demos, code examples or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Closing this PR that has WIP Github Actions work that's no longer needed.


Test errors after tensorflow installation on Ubuntu 20.04

Ubuntu20.04, Python 3.8.5
Installation of tensorflow (to enable skipped tests) results with tests errors.
Steps to reproduce:
git clone https://github.com/openvinotoolkit/datumaro
cd datumaro
python3 -m pip install virtualenv
python3 -m virtualenv venv
. venv/bin/activate
pip install datumaro
python3 -m unittest -v
//there are some skipped tests - required tensorflow and pandas)
pip install tensorflow
//during installation numpy 1.20.3 was uninstalled and 1.19.5 was installed
python3 -m unittest -v

Expected result:
No test errors after installation libraries required to perform initially skipped tests.
Current result:
Ran 390 tests in 11.807s

FAILED (errors=29, skipped=7)

ERROR: test_validate_annotations_segmentation (tests.test_validator.TestValidateAnnotations)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/sstrehlk/src/datum_p/tests/test_validator.py", line 803, in test_validate_annotations_segmentation
    actual_results = validate_annotations(self.dataset, 'segmentation',
  File "/home/sstrehlk/src/datum_p/datumaro/components/validator.py", line 1255, in validate_annotations
    stats = validator.compute_statistics(dataset)
  File "/home/sstrehlk/src/datum_p/datumaro/components/validator.py", line 1064, in compute_statistics
    _update_mask_stats_by_label(
  File "/home/sstrehlk/src/datum_p/datumaro/components/validator.py", line 1026, in _update_mask_stats_by_label
    area = ann.get_area()
  File "/home/sstrehlk/src/datum_p/datumaro/components/extractor.py", line 374, in get_area
    import pycocotools.mask as mask_utils
  File "/home/sstrehlk/src/datum_p/venv/lib/python3.8/site-packages/pycocotools/mask.py", line 3, in <module>
    import pycocotools._mask as _mask
  File "pycocotools/_mask.pyx", line 1, in init pycocotools._mask
ValueError: numpy.ndarray size changed, may indicate binary incompatibility. Expected 88 from C header, got 80 from PyObject

----------------------------------------------------------------------

It seems that there is incompatibility between numpy 1.19.5 and pycocotools 2.0.2. There is workaround for it:
pip install pycocotools==2.0.0

We already fought with this problem here: https://github.com/openvinotoolkit/cvat/pull/2756. As far as I remember, there was a problem in newer binary distributions of pycocotools and tensorflow - they were linked against the mismatching versions of numpy, and that caused the problem. Can you check if that is the case? What if we disable binaries for pycocotools on a problematic platform?

This is the same case, tensorflow installation results with downgrading of numpy, and then numpy is incompatible with the the newest pycocotools. Tensorflow is not mentioned in requirements.txt and some tests because of that are skipped, so initially there are no errors but only some skips. The problem is visible after installation of tensorflow and automatic downgrade of numpy. Installation of tensorflow enables some skipped tests, but results with errors (on Ubuntu 20.04) because of incompatibility between numpy and pycocotools. Manual downgrading of pycocotools to version 2.0.0 can help on this problem, and all tests then could pass, but I don't know what can be another consequence of pycocotools downgrading.


isort

Description
Adding isort.

Closing as out-of-date - isort is already being used at this point


Add line end pattern sign

If there's no $ at the end of pattern argument for grep, it matches files not with exact extension, but with extension starts with $EXT. So if you pass .js you get .json files in the list too.

I appreciate your contribution, however, I feel it's important to adhere to the base regex spec and allow users to have a predictable interface.  For example, webpack rule test parameter requires you to provide the ending $ to avoid matching .json when you mean to capture just .js:
const rules = [{
  test    : /\.(js|jsx)$/,
  ...
}]

Likewise, you can specify the end of the match in this application by providing a $.  Here's an example from a node script where I just want to match .js and .jsx files. (excuse the extra \ required for formatting around package.json limitations).
 "lint:diff": "NODE_ENV=lint EXT=\".js$|.jsx$\" LINT=\"npx eslint\" ./tools/git-diff-lint/git-diff-lint",

I've made this change because it's not clear from README that -e param is regex, not just file extension. Maybe it's better to set this param description not file extension, but file extension regex pattern or something like this?

Makes a lot of sense, thanks for the feedback.  I'll update the readme shortly.


feat: add default option parameter

The first implementation of https://github.com/pkgjs/parseargs/issues/82
This PR adds a new defaultValue parameter.
  const args = [];
  const options = {
    a: { type: 'string', defaultValue: 'HELLO' }
  };
  const result = parseArgs({ args, options }); // { values: { a: 'HELLO' } }

It lets the user specify an option's default value when it is not set by the args input.
When it is set, the option token is added automatically.
This pr does not include any process.env logic, but the user may set defaultValue: process.env.WHATEVER

Thanks for the PR! Personally I'm not totally sure this is worth adding, vs just expecting users to write values.foo ?? 'default'. but it's good to have something to discuss.

When it is set, the option token is added automatically.

This is definitely not right. The tokens array should represent the input exactly; no more and no less.

It’s very useful to provide the default value by configuration and not just in code, for example to include it in help output, or to ensure the default value is normalized/validated just like user-provided values.

Well, sure, but that doesn't mean it's necessarily worth adding to this parser itself. It's literally one line to implement it yourself:
let options = { foo: { type: 'string', default: 'bar' }, ...etc };
let { values } = parseArgs({ options });

Object.entries(options).forEach(([k, v]) => { values[k] ??= options[k].default });

This is definitely not right. The tokens array should represent the input exactly; no more and no less.

How would you support/implement the default value?
I think the use case is: "when there is no input for a given option, the application requires the default value"

How would you support/implement the default value?

Pretty much the same way you'd do it in userland: just before returning the parsed values, go through the configured options and set the default value for any configured key which has a default but which does not already have a value arising from the parse itself.
(There's details you'd still need to work out - how do you handle multiple options, in particular - but the general approach of modifying the values and not the tokens is the part I want to emphasize.)

(Adding to what @bakkot already said.)
I see the temptation to put the defaults into the tokens so they are represented. But the tokens just represent the parsing of the input arguments. Every token has an index property which is the index into the input arguments where the token came from.
(A different thing we could have represented might be "events" that occur in the parsing, and a default would fit into that.)

It’s very useful to provide the default value by configuration and not just in code, for example to include it in help output, or to ensure the default value is normalized/validated just like user-provided values.

I agree in general. However, parseArgs does not offer help and does not offer normalise/validate.

How would you support/implement the default value?

I suggest adding a default value which appears in returned values is sufficient. I know people sometimes want to know whether the value came from the input args or from the default value. I don't think this is the common case, and can be determined by looking in the tokens.

I think there is somewhat low value in adding support for defaults, but I think it is something people want to do and look for, and a good thing to consider and discuss. Thanks for raising it @Eomm . 😄

how do you handle multiple options

We can support it by accepting an array

I don't think this is the common case, and can be determined by looking in the tokens.

I may try to arrange an example or think a similar output is needed to get the "default-tokens".
To recap:

[ ] support array input when multiple = true
[ ] do not add into the tokens array the default value.

👍🏽

Personally would love to see this feature land! While I understand it is a one liner for users to add, we have the underlying utilities in place to apply run time validation and rich TypeScript support.
Light suggestion to rename defaultValue to default. We've conventionally used terse names where possible and in the context of an option config object I think default will naturally imply it's the default value (take meow for example).

@bakkot commented that not totally sure this is worth adding: https://github.com/pkgjs/parseargs/pull/142#issuecomment-1214171608 (and Aaron and I both agree not much code saved).
We have had multiple people expressing interest in default support, and for that reason I lean towards including it as something people look for that suits how they wish to configure their options.

https://github.com/pkgjs/parseargs/issues/82#issuecomment-1140539865
https://github.com/pkgjs/parseargs/issues/82#issuecomment-1213104953
https://github.com/pkgjs/parseargs/pull/142#issuecomment-1214428666
(this PR)

Anyone want to make an argument that we shouldn't include defaults?

Light suggestion to rename defaultValue to default. We've conventionally used terse names where possible and in the context of an option config object I think default will naturally imply it's the default value (take meow for example).

I second the suggestion for the shorter name. Someone using defaults is likely to have it appear multiple times in their configuration.

@Eomm You might want to update the PR title and description to reflect the change in naming from defaultValue to default.
This is a great addition — looking forward to seeing it land!

Now that parseArgs is in node we have been landing the changes in Node.js first.
For example #129 (123 comments in this repo during active development) and https://github.com/nodejs/node/pull/43459) (60 comments).
@Eomm has addressed all the code issues we have raised here.
Are you up for proposing it for Node.js @Eomm ? (Otherwise, I'm willing to give it a go. I have only made one upstream PR myself, so not an expert offer!)

Are you up for proposing it for Node.js @Eomm ?

Yeah! I will do it, it would be fantastic to try to submit a PR to Node.js core!
Thanks for the helpful example PR

Merged into Node core https://github.com/nodejs/node/pull/44631
I have updated this PR accordingly


Add DirectoryHTTPHandler

Similar to a FileHTTPHandler, the DirectoryHTTPHandler directly serves the files it can read from the file system. However, it finds them by looking inside a specific sub directory for that file.
DirectoryHTTPHandlers have a ‘server path’: the path where they will be hosted on the server. This is how it knows where to look on the file system: it removes the server path from the request. Then it uses that subpath, plus its root path, to know where to look:
// handles requests for `/server/path/`, looks inside the `.module` bundle's 'Stubs' dir for the files
let handler = DirectoryHTTPHandler(bundle: .module, subPath: "Stubs", serverPath: "server/path")

// how this may be used inside a RoutedHTTPHandler.
let path = "/path/to/my/mocks"

var handlers = RoutedHTTPHandler()
handlers.appendRoute(
    HTTPRoute("serverPath/*"), // (unfortunately, the RoutedHTTPHandler needs to know the route, too)
    to: DirectoryHTTPHandler(root: URL(fileURLWithPath: path), serverPath: "/serverPath")
)

It uses the FileHTTPHandler’s method of getting MIME types.
Additionally, adding some unit tests for this required us to make a change to the way we embed the test resources for the test target. Previously, the .process method put them all in the top level directory. That’s not handy for our DirectoryHTTPHandler; so we have changed that to .copy. That preserves the directory structure, and allows us to test better. Doing this also meant we needed to update the older tests to specify where they should be looking for their stubs as well (which is why I have changed some of them to insert "Stubs/").
Hope you like it.

really nicely done


import_targets: false has no effect (on Gprc.Tools in netcoreapp3.1 F# exe)

Description
Gprc.Tools stops the build from its targets file if the project being built is not a .csproj, but import_targets: false does not prevent those targets being loaded when used in the paket.references or paket.dependencies files.
(Found this because a package I added had Gprc.Tools as a dependency)
Repro steps
mkdir \temp\whatever
cd \temp\whatever
dotnet new console -f netcoreapp3.1 -lang F#
dotnet new tool-manifest
dotnet tool install paket
dotnet paket convert-from-nuget
dotnet paket add Grpc.Tools --project whatever
edit the paket.references to include 'Grpc.Tools import_targets: false'
or edit the paket.dependencies to include 'nuget Grpc.Tools import_targets: false'
dotnet restore
dotnet build

Git repo containing the same: https://github.com/marklam/paket-import-targets-false
Expected behavior
Project builds
Actual behavior
Error from Gprc.Tools' targets file
C:\Users\Mark\.nuget\packages\grpc.tools\2.37.0\build\_protobuf\Google.Protobuf.Tools.targets(51,5): error : Google.Protobuf.Tools proto compilation is only supported by default in a C# project (extension .csproj) [C:\temp\whatever.fsproj]
Known workarounds
None

I was having this issue when importing Grpc.AspNetCore into an F# project since it takes Grpc.Tools as a dependency. Although I'm not sure why, since the proto classes are generated in another project. Effectively it means you can't host Grpc in F# using Paket.
I found a workaround that allows the build to pass. See here: https://github.com/grpc/grpc/issues/20515#issuecomment-629415019. Since you aren't actually compiling any proto files anyway (for myself this is done in another C# project and referenced in) all this does is bypass the validation and allow the build to pass.
Ideally however target imports from transitive dependencies could also be disabled.

I think this is going to be similar to #4039: PackageReference nodes have different values for ExcludeAssets that can be set to control this behavior in msbuild, and paket isn't setting all of them just yet. Thankfully, #4040 shows this is a pretty simple process to add, so threading through the current import_targets behavior into including ExcludeAssets=build;buildMultitargeting;buildTransitive should be pretty simple to do.


src.replace is not a function

I am getting this error when I try to use this library:
TypeError: src.replace is not a function
Please report this to https://github.com/chjj/marked.
at Lexer.lex (/Volumes/External/projects/BuildCMS/node_modules/marked/lib/marked.js:138:6)
at Function.Lexer.lex (/Volumes/External/projects/BuildCMS/node_modules/marked/lib/marked.js:129:16)
at marked (/Volumes/External/projects/BuildCMS/node_modules/marked/lib/marked.js:1218:31)
at figurePage (/Volumes/External/projects/BuildCMS/nodePress.js:227:12)
at processPage (/Volumes/External/projects/BuildCMS/nodePress.js:160:23)
at page (/Volumes/External/projects/BuildCMS/nodePress.js:135:9)
at /Volumes/External/projects/BuildCMS/nodePress.js:110:16
at Layer.handle [as handle_request] (/Volumes/External/projects/BuildCMS/node_modules/express/lib/router/layer.js:95:5)
at next (/Volumes/External/projects/BuildCMS/node_modules/express/lib/router/route.js:131:13)
at Route.dispatch (/Volumes/External/projects/BuildCMS/node_modules/express/lib/router/route.js:112:3)

It might be that you are not passing an string trough but an object or array.

^ Most likely this.
#682

I have this same error. I'm using firebase with polymerfire. If i bind a firebase document to data then bind <marked-element markdown="[[data]]"> I'll get several of these errors.
I got around that by setting up this observer:
observers: [
  '_dataChanged(data, data.*)'
],

_dataChanged: function(data) {
  if (typeof data === "string") {
    this.$.markdown.markdown = data;
  }
}

That works fine but it would be nice if marked.js handled this check for me so i could just bind onto my data and go.


Deployment

Deployment
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that I can easily find and read info
Acceptance Criteria
Given a Prework Study Guide website
When I visit the website using the URL
Then I can access my website from any browser

We did it!~


# Failing example. There are no .go files (and hence no package) in the same directory
# as the main `go.mod` file.

mkdir -p /tmp/scratchpad/bitbucket-module-bad
cd /tmp/scratchpad/bitbucket-module-bad
go mod init bitbucket.org/foo/bar

mkdir baz
cat <<EOF > baz/baz.go
package baz

func Hello() string { return "Hello from bitbucket.org/foo/bar/baz" }
EOF

cd /tmp/scratchpad/bitbucket-module-bad
go build -v

Fails with:
$ go build -v
Fetching https://bitbucket.org?go-get=1
Parsing meta tags from https://bitbucket.org?go-get=1 (status code 200)
can't load package: package bitbucket.org/foo/bar: unknown import path "bitbucket.org/foo/bar": cannot find module providing package bitbucket.org/foo/bar

CC @myitcv @bcmills @heschik

#29268 is related.

I have been writing Go (it was the first language I really learned well) and so ./... seemed normal to me, but I was recently helping a very experienced C# engineer on board onto my team. We were pair-programming and we came across this issue and I used go install ./... and he was a little weirded out but liked it.

#31270 might be a dup of this.

I was following a tutorial for something (gRPC) and the tutorial makes use of modules, so I got to learn about them too \o/
However I had an issue where I had made a mistake and the error message from go build was not very helpful.
Below is pasted the file tree, the root go.mod, the code that was generating the error, the command being executed and the error message. The error turned out to be that the import path was pointed at a directory with no go source files, but the error reported was "cannot find module providing package"
.
├── go.mod
├── go.sum
└── part_1
├── api
│   └── proto
│       └── v1
│           └── todo-service.proto
├── cmd
│   ├── client-grpc
│   │   ├── client-grpc
│   │   └── main.go
│   └── server
│       └── main.go
├── create_todo_table.sql
├── go.sum
├── pkg
│   ├── api
│   │   └── v1
│   │       └── todo-service.pb.go
│   ├── cmd
│   │   └── server
│   │       └── server.go
│   ├── protocol
│   │   └── grpc
│   │       └── server.go
│   └── service
│       └── v1
│           ├── todo-service.go
│           └── todo-service_test.go
└── third_party
└── google
└── protobuf
├── any.proto
├── api.proto
├── compiler
│   └── plugin.proto
├── descriptor.proto
├── duration.proto
├── empty.proto
├── field_mask.proto
├── source_context.proto
├── struct.proto
├── timestamp.proto
├── type.proto
└── wrappers.proto
20 directories, 25 files
=======================================
~/go/src/shane/go.mod
module shane
require (
github.com/DATA-DOG/go-sqlmock v1.3.3
github.com/go-sql-driver/mysql v1.4.1
github.com/golang/protobuf v1.3.1
google.golang.org/grpc v1.21.0
)
~/go/src/shane/part_1/cmd/server
package main
import (
"fmt"
"os"
"shane/part_1/pkg/cmd"

)
func main() {
if err := cmd.RunServer(); err != nil {
fmt.Fprintf(os.Stderr, "%v\n", err)
os.Exit(1)
}
}
go build . # inside ~/go/src/shane/part_1/cmd/server
main.go:7:2: unknown import path "shane/part_1/pkg/cmd": cannot find module providing package shane/part_1/pkg/cmd

This appears to be fixed at head.
~/src/golang.org/x/build$ gotip version
go version devel +0915a19a Fri Dec 6 05:12:15 2019 +0000 linux/amd64

~/src/golang.org/x/build$ GO111MODULE=on gotip build ./vcs-test
can't load package: package ./vcs-test: no Go files in /usr/local/google/home/bcmills/src/golang.org/x/build/vcs-test

~/src/golang.org/x/build$ GO111MODULE=off gotip build ./vcs-test
can't load package: package golang.org/x/build/vcs-test: no Go files in /usr/local/google/home/bcmills/src/golang.org/x/build/vcs-test


[11.x] Verified & Unverified, Blade Directives

This PR introduces two new Blade directives that aim to check the email status of the authenticated user:
The verified directive:
@verified
    Your email address is already verified, thank you!
@endverified

The unverified directive:
@unverified
    Your email address is not verified. Click here to receive a new email to confirm your email address.
@endunverified

Both of them act related to hasVerifiedEmail method of the MustVerifyEmail interface.

This is the kind of thing I wonder why it doesn't exist in Laravel yet...

The value of auth()->guard{$guard}->user() is not guaranteed to have a hasVerifiedEmail method as it’s just type-hinted as Illuminate\Contracts\Auth\Authenticatable. This will fail if the developer is using something other than the default User model.

Disagree, because the MustVerifyEmail interface/trait is optional. Just using custom if directives or using @if directly is much clearer.

The value of auth()->guard{$guard}->user() is not guaranteed to have a hasVerifiedEmail method as it’s just type-hinted as Illuminate\Contracts\Auth\Authenticatable. This will fail if the developer is using something other than the default User model.

Disagree, because the MustVerifyEmail interface/trait is optional. Just using custom if directives or using @if directly is much clearer.

The use of these directives depends on MustVerifyEmail being in use. If MustVerifyEmail is not in use, then you don't need to use these directives.

Since this seems to be getting some early push back I'll just leave it up to the end-developer to use Blade::if to easily add this if you want.


Adding RDS - No RDS Access Credentials found in the AWS Secret Manager

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
14.17.6
Amplify CLI Version
6.3.1
What operating system are you using?
Ubuntu
Amplify Categories
storage
Amplify Commands
env
Describe the bug
Iam using CDK to deploy our RDS Serverless Cluster and related Secret Manager Secrets. When adding a new env to our App, i can select the RDS Cluster but not the related Secret and amplify throws "No RDS access credentials found in the AWS Secrect Manager." When looking at:
https://github.com/aws-amplify/amplify-cli/blob/81cc461ed5e02b2f296825283993ad026f1126d1/packages/amplify-category-api/src/provider-utils/awscloudformation/service-walkthroughs/appSync-rds-walkthrough.ts#L144-L147
It seems like the name has to be 'rds-db-credentials/${clusterResourceId}'. As we have a different naming convention, we cant name it like this. It would be nice if the secret is not found, that  promptWalkthroughQuestion is started with all secrets found in the account.
Expected behavior
If no Secret found with specific name, start  promptWalkthroughQuestion with all secrets
Reproduction steps

Create RDS with Secret and name the secret different than 'rds-db-credentials/${clusterResourceId}'
Add new env
Select DB
See Error

GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

I have marked this as a feature request. We will pick this up once the task gets prioritized.

I too have this issue.
So the fix, for now, is to name the Secrets Manager Secret as rds-db-credentials/]My ARN for my Secret] ? I haven't been able to get it to work this way either.

@Etep15 yes that would be a solution. What I did is to pull the amplify-cli and build my own version without the above code. I then get the list of all Secrets and can select accordingly.

So for anyone else running into this issue the key is to use the RESOURCE_ID of the RDS serverless cluster.
Not the ARN and not the DB cluster ID.
On the web console go to your RDS and pick the "Configuration" tab. In there is "Resource ID". This is what you want to use. So when creating your secret in the Secrets Manager the name should look like...
rds-db-credentials/cluster-XXXXXXXXXXXXXXXXXXXX
Obviously all those X's will be replaced with what you have listed as your Resource ID.
Once you have the secret created, run amplify api add-graphql-datasource and it should be happy.


BUG: unable to initialize proxmox api client not authorized to access endpoint

What steps did you take and what happened:
After installing all prerequisites and running the command
clusterctl init --infrastructure proxmox --ipam in-cluster --core cluster-api:v1.5.3

when watching pods creating i notice that the capmox-controller is in CrashLoopback.
Pod Logs:
I0124 23:54:17.007521       1 main.go:87] "setup: starting capmox"
I0124 23:54:17.008105       1 listener.go:44] "controller-runtime/metrics: Metrics server is starting to listen" addr="localhost:8080"
I0124 23:54:17.008556       1 main.go:126] "setup: feature gates: ClusterTopology=false\n"
E0124 23:54:20.031775       1 main.go:133] "setup: unable to setup proxmox API client" err="unable to initialize proxmox api client: not authorized to access endpoint"

clusterctl.yaml
PROXMOX_URL: "https://pve.dev.local/api2/json"
PROXMOX_TOKEN: "capi@pve!token1"
PROXMOX_SECRET: "REDACTED"
PROXMOX_SOURCENODE: "pve01"
TEMPLATE_VMID: "9000"
ALLOWED_NODES: "[pve01,pve02,pve03]"
VM_SSH_KEYS: "ssh-rsa ..."
CONTROL_PLANE_ENDPOINT_IP: "<IP_ADDRESS>"
NODE_IP_RANGES: "[<IP_ADDRESS>-<IP_ADDRESS>]"
GATEWAY: "<IP_ADDRESS>"
IP_PREFIX: "24"
DNS_SERVERS: "[<IP_ADDRESS>]"
BRIDGE: "vmbr0"
BOOT_VOLUME_DEVICE: "scsi0"
BOOT_VOLUME_SIZE: "64"
NUM_SOCKETS: "1"
NUM_CORES: "4"
MEMORY_MIB: "4096"
EXP_CLUSTER_RESOURCE_SET: "false"
CONTROL_PLANE_MACHINE_COUNT: "3"
WORKER_MACHINE_COUNT: "3"

providers:
  - name: in-cluster
    url: https://github.com/kubernetes-sigs/cluster-api-ipam-provider-in-cluster/releases/latest/ipam-components.yaml
    type: IPAMProvider

capi@pve!token1 is proxmox Administrator on / so it's cluster admin.
Yesyed the user on terraform and packer and ansible and everything works fine there.
What did you expect to happen:
The capmox-controller should connect to proxmox and continue provisioning
Anything else you would like to add:
Using kind as local kubernetes provisioner and docker rootless as driver, everything it at default configuration.
Environment:

Cluster-api-provider-proxmox version: 0.1.1
Kubernetes version: (use kubectl version):

Client Version: v1.29.1
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.27.3

OS (e.g. from /etc/os-release):

NAME="AlmaLinux"
VERSION="9.3 (Shamrock Pampas Cat)"
ID="almalinux"
ID_LIKE="rhel centos fedora"
VERSION_ID="9.3"
PLATFORM_ID="platform:el9"
PRETTY_NAME="AlmaLinux 9.3 (Shamrock Pampas Cat)"
ANSI_COLOR="0;34"
LOGO="fedora-logo-icon"
CPE_NAME="cpe:/o:almalinux:almalinux:9::baseos"
HOME_URL="https://almalinux.org/"
DOCUMENTATION_URL="https://wiki.almalinux.org/"
BUG_REPORT_URL="https://bugs.almalinux.org/"

ALMALINUX_MANTISBT_PROJECT="AlmaLinux-9"
ALMALINUX_MANTISBT_PROJECT_VERSION="9.3"
REDHAT_SUPPORT_PRODUCT="AlmaLinux"
REDHAT_SUPPORT_PRODUCT_VERSION="9.3"

It's systematic so i must be doing something wrong...

@dnviti
the PROXMOX_URL: "https://pve.dev.local/api2/json" is wrong,
Please just use PROXMOX_URL: "https://pve.dev.local"

It didn't work either way.
BTW this morning it gives me the error:
[default@capi-bootstrapper ~]$ clusterctl init --infrastructure proxmox --ipam in-cluster --core cluster-api:v1.5.3
Fetching providers
Error: failed to get provider components for the "proxmox" provider: failed to get repository client for the InfrastructureProvider with name proxmox: error creating the GitHub repository client: failed to get latest release: release not found for version v0.2.0, please retry later or set "GOPROXY=off" to get the current stable release: 404 Not Found

if i only run clusterctl init it works but it does not initialize the proxmox provider.

yeah, we are currently releasing v0.2.0.
you can enforece the version by
clusterctl init --infrastructure proxmox:v0.1.1 --ipam in-cluster --core cluster-api:v1.5.3
Fetching providers

yeah, we are currently releasing v0.2.0.
you can enforce the version by
clusterctl init --infrastructure proxmox:v0.1.1 --ipam in-cluster --core cluster-api:v1.5.3
Fetching providers

Nope, not working either, i'm going to wait for the v0.2.0 and try again.
Anyway, where can i check available providers/infrastructures? can't find the list anywhere...

please retry or put this in your clusterctl
providers:
  - name: proxmox
    url: https://github.com/ionos-cloud/cluster-api-provider-proxmox/releases/download/v0.1.1/infrastructure-components.yaml
    type: InfrastructureProvider

It starts but gives the same error
I0124 23:54:17.007521       1 main.go:87] "setup: starting capmox"
I0124 23:54:17.008105       1 listener.go:44] "controller-runtime/metrics: Metrics server is starting to listen" addr="localhost:8080"
I0124 23:54:17.008556       1 main.go:126] "setup: feature gates: ClusterTopology=false\n"
E0124 23:54:20.031775       1 main.go:133] "setup: unable to setup proxmox API client" err="unable to initialize proxmox api client: not authorized to access endpoint"

Can't really figure out why, i strictly followed documentation steps.

@dnviti Do you think the token is correct?
OR maybe you should add the port PROXMOX_URL: "https://pve.dev.local:8006"

nope that, my access is granted and managed by an HAProxy so i use another domain, that was a random example

I think I remember this issue:
Please disable privilege separation or use root token,

I think I remember this issue:
Please disable privilege separation or use root token,

yes, i disabled previously "Privilege Separation" also on the other user and it worked using ansible.
Now all started and that is the log.
NAME                                                                   READY  SEVERITY  REASON                       SINCE  MESSAGE
Cluster/proxmox-quickstart                                             False  Warning   ScalingUp                    4m16s  Scaling up control plane to 3 replicas (actual 1)
├─ClusterInfrastructure - ProxmoxCluster/proxmox-quickstart            True                                          4m24s
├─ControlPlane - KubeadmControlPlane/proxmox-quickstart-control-plane  False  Warning   ScalingUp                    4m16s  Scaling up control plane to 3 replicas (actual 1)
│ └─Machine/proxmox-quickstart-control-plane-xhdfp                     False  Warning   CloningFailed                4m21s  1 of 2 completed
└─Workers
  └─MachineDeployment/proxmox-quickstart-workers                       False  Warning   WaitingForAvailableMachines  4m24s  Minimum availability requires 3 replicas, current 0 available
    └─3 Machines...                                                    False  Info      WaitingForBootstrapData      4m23s  See proxmox-quickstart-workers-qllcb-ds486, proxmox-quickstart-workers-qllcb-twctl, ...

Should the VM template be created using a specific method? i used a standard almalinux cloud init image (Generic Cloud)...

Does your image have kubeadm, kubelet, kubectl, containerd installed?

Does your image have kubeadm, kubelet, kubectl, containerd installed?

nope, if i only need those dependencies i'll cook a new one right away!

Does your image have kubeadm, kubelet, kubectl, containerd installed?

nope, if i only need those dependencies i'll cook a new one right away!

you can add this almalinux to image-builder
otherwise, you can build ubuntu images.

v0.2.0 is now released
Which means that the issue that you had before, should be fixed.

v0.2.0 is now released https://github.com/ionos-cloud/cluster-api-provider-proxmox/releases/tag/v0.2.0
Which means that the issue that you had before, should be fixed.

I also developed this script: https://gitlab.com/dnviti/Bash-Scripts/-/blob/master/capi-proxmox-deps.sh
its purpose it's to prepare an image from scratch in au automated way.
it references another script of mine, to install docker and all its deps.

join this channel to get support: https://kubernetes.slack.com/archives/C06FC9P0FK7


"Module not found" when extending a class otherwise same code without extending no error

Bug Report
Every time when I try to extend the abtract class Command and I try to compile I get the error: Error: Cannot find module src/classes/commandBase

🔎 Search Terms

Module not found
class module not found

🕗 Version & Regression Information

v4.8.4

💻 Code
My project has the following structure:
   ├────tsconfig.json
   └────src
        ├───classes
        │   └───commandBase.ts
        ├───commands
        │   └───ping.ts
        ├...

tsconfig.json
{
  "compilerOptions": {
    "target": "ESNext",
    "module": "CommonJS",
    "rootDir": "./src/",
    "outDir": "./dist/",
    "strict": true,
    "moduleResolution": "node",
    "importHelpers": true,
    "experimentalDecorators": true,
    "esModuleInterop": true,
    "skipLibCheck": true,
    "allowSyntheticDefaultImports": true,
    "resolveJsonModule": true,
    "forceConsistentCasingInFileNames": true,
    "removeComments": true,
    "typeRoots": ["node_modules/@types"],
    "sourceMap": true,
    "baseUrl": "./"
  },
  "include": ["./**/**/*.ts"],
  "exclude": ["node_modules", "dist"]
}

commandBase.ts
abstract class Command {
  name: string;
  abstract execute(client: Client, message: Message, args: string[]): void;

  constructor(name: string) {
    this.name = name;
  }
}
export default Command;

ping.ts
import Command from "src/classes/commandBase";

class Ping extends Command {
  constructor() {
    super("ping");
  }
  async execute(
    client: Client<boolean>,
    message: Message<boolean>,
    args: string[]
  ): Promise<void> {
    const m = await message.channel.send("Ping");
    m.edit(
      `Pong! Latency is ${
        m.createdTimestamp - message.createdTimestamp
      }ms. Discord Chat API Latency is ${Math.round(client.ws.ping)}ms`
    );
  }
}

export default Ping;

🙁 Actual behavior
Error: Cannot find module 'src/classes/commandBase'.
However if you change import Command from "src/classes/commandBase"; to import Command from "../classes/commandBase"; everything is working fine when importing.
BUT the weird behavior starts now:
If you create a new file which import Command from 'src/classes/commandBase and exports a variable everything is working as intended. The error only appears when you extend a class.
file foo.ts
// This is working
import Command from "src/classes/commandBase";

const foo: Command = {
  name: "",
  execute: function (
    client: Client,
    message: Message,
    args: string[]
  ): void {
    throw new Error("Function not implemented.");
  },
};
export default foo;

🙂 Expected behavior
Since the module exists it should be able to import.

Unless providing a relative path the module will be imported using a module resolution algorithm, which with your configuration won't find modules in the src folder.
This is working as intended, and completely unrelated to extending a class.

The error only appears when I extend CommandBase (as I already mentioned in the text and in my examples). If I export a normal variable and in this file I import with "import Command from "src/classes/CommandBase" everything is working. The moment I extend a class it's not working.

Is this a runtime error, or a compile-time error?  I assume it's the former, in which case the error goes away in the second example because you only use the type so TS elides the import.  You're using moduleResolution node, but src/classes/commandBase generally won't work as an import specifier in node without specific configuration.

My mistake. What fatcerberus is saying is right. I did not realize that you're talking about a runtime error, and wrongly assumed the current setup leads to a compile time error.

As a general rule, in TS you need to use the import path that will work at runtime (i.e. the exact string you would pass to require() or use for an import statement in a plain .js file).  Anything else may compile but will then fail at runtime.

Autocompletion is done by the TS language server, so this is almost certainly a case where TS understands your imports but your runtime (assumedly node) doesn't, and your configuration should be adjusted to align.  What I said above still applies, at any rate.
It is weird that the console.log example works, though.

Could it be because CommandBase is abstract? The other class Bot is just a normal class which extends something.

No, because abstract classes can contain implementation and are part of the prototype chain. There's no check to see if a class actually does have any implementation.

Well i'm a bit helpless. As a workaround I can change the import path. But it still doesn't look right since it's working [sometimes]

What's the location of the "loader.ts"?

If you get tired of imports always looking like "../" or "./", or needing to change them as you move files, this is a great way to fix that.

This text is one of my biggest pet peeves in the documentation.  It's described as if it's some convenience feature that TS will take care of for you, but in reality it only works if your runtime environment also understands it, because TS emits the import paths you use verbatim.

What's the location of the "loader.ts"?

./src/loader.ts

// This is working
import Command from "src/classes/commandBase";

const foo: Command = {

This is because Command is only used in a type position, so the import is removed from the JS.
This thread is a monument to all our past bad decisions around modules and imports 🥲

PS D:\TypeScript-coding\05-Inheritance> node driver.ts
(node:14380) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use node --trace-warnings ... to show where the warning was created)
D:\TypeScript-coding\05-Inheritance\driver.ts:1
import { Shape } from "./shape";


Filter listings using Item Specifics

Is your feature request related to a problem? Please describe
There are a very limited set of filters in the filters page.
Describe the solution you'd like

Add additional filter fields for item specifics.

Upon further investigation, it seams that AllGoods has removed support for detailed filters on their website and mobile app. We will not implement this feature until AllGoods have these filters implemented in a easy to use manner.


Make instructions for how to run the tests complete

There are instructions in the README (introduced in PR https://github.com/kafka4beam/sasl_auth/pull/8) for how to run the test cases introduced in PR https://github.com/kafka4beam/sasl_auth/pull/8. These instructions are not complete. See, for example, this comment https://github.com/kafka4beam/sasl_auth/pull/8#discussion_r869313696 and other comments for the same PR. We should either update these instructions so they are complete or replace the instructions with a reference to a script that sets everything up automatically.

Fixed in PR https://github.com/kafka4beam/sasl_auth/pull/8 by replacing the instructions with a script that sets everything up.


Remove duplicate #include

Signed-off-by: Masashi Honma<EMAIL_ADDRESS>Notes:

Pull requests cannot be accepted until:

The submitter has accepted the online agreement here with a click through
or for companies or those that do not wish to create an mbed account, a slightly different agreement can be found here
The PR follows the mbed TLS coding standards

This is just a template, so feel free to use/remove the unnecessary things

Description
Remove duplicate #include
Status
READY
Requires Backporting
NO
Migrations
NO
Additional comments
make check passed
Todos

[ ] Tests
[ ] Documentation
[ ] Changelog updated
[ ] Backported

Steps to test or reproduce
make check passed

@masap Thank you for contribution!
As you may be aware, we cannot accept contribution until you have accepted our CLA, even a trivial fix such as this.
Since I believe you already have an Mbed account, it would be faster if you accept the clickthrough CLA
Thanks again for your contribution!

@masap Thank you for accepting our CLA!
Could you please add an entry in the ChangLog and credit yourself, as other entries are written?
You will probably need to add an entry in a new release entry, with the title:
= mbed TLS x.xx.x branch released xxxx-xx-xx

since we recently released version 2.16.0

This PR was replaced by #2318.

@RonEld I modified the ChangLog. I need to create a new PR because of lack of my knowledge of Github. So this PR was replaced by #2318.


Could not download gpt4all-lora-quantized-ggml.bin

I try to download gpt4all-lora-quantized-ggml.bin at https://the-eye.eu/public/AI/models/nomic-ai/gpt4all/gpt4all-lora-quantized-ggml.bin, but the browser show me this error code: ERR_HTTP2_PROTOCOL_ERROR

It works for me and for all those who used this. And beleive me those days. I think the problem is on your side.
Some countries may block some websites. Or maybe you have a filewall rule that prevents this or you have a bad configuration . Try another browser to see if this is a brouser issue.

I was able to download the bin file, however, I get this error when I execute the run.bat:
llama_model_load: loading model from './models/gpt4all-lora-quantized-ggml.bin' - please wait ...
./models/gpt4all-lora-quantized-ggml.bin: invalid model file (bad magic [got 0x67676d66 want 0x67676a74])

It is advised to use the install.bat
At the end of the script there is a conversion step where we use the lama.cpp code to convert the file.
git clone https://github.com/ggerganov/llama.cpp.git tmp\llama.cpp
move models\gpt4all-lora-quantized-ggml.bin models\gpt4all-lora-quantized-ggml.bin.original
python tmp\llama.cpp\migrate-ggml-2023-03-30-pr613.py models\gpt4all-lora-quantized-ggml.bin.original models\gpt4all-lora-quantized-ggml.bin

Best regards

Ok.  I ran uninstall.bat and then install.bat ... here was the output.  It does appear to have worked, but I thought you might be interested in the errors it mentions.  Note:  I originally downloaded using the Visual Studio option from github.
The default model file (gpt4all-lora-quantized-ggml.bin) already exists. Do you want to replace it? Press B to download it with a browser (faster). [Y,N,B]?B
Link has been opened with the default web browser, make sure to save it into the models folder. When it finishes the download, press any key to continue.
Press any key to continue . . .
Converting the model to the new format
'git' is not recognized as an internal or external command,
operable program or batch file.
1 file(s) moved.
C:\Users\mabrams\AppData\Local\Programs\Python\Python310\python.exe: can't open file 'C:\Users\mabrams\source\repos\gpt4all-ui\tmp\llama.cpp\migrate-ggml-2023-03-30-pr613.py': [Errno 2] No such file or directory
The model file (gpt4all-lora-quantized-ggml.bin) has been fixed.
Cleaning tmp folder
Virtual environment created and packages installed successfully.
Every thing is setup. Just run run.bat
Press any key to continue . . .

And interestingly, when I execute run.bat, I now get this message:
Ok
Traceback (most recent call last):
File "C:....\source\repos\gpt4all-ui\app.py", line 535, in
bot = Gpt4AllWebUI(app, args)
File "C:...\source\repos\gpt4all-ui\app.py", line 205, in init
self.prepare_a_new_chatbot()
File "C:...\source\repos\gpt4all-ui\app.py", line 210, in prepare_a_new_chatbot
self.chatbot_bindings = self.create_chatbot()
File "C:...\source\repos\gpt4all-ui\app.py", line 216, in create_chatbot
return Model(
File "C:...\source\repos\gpt4all-ui\env\lib\site-packages\pyllamacpp\model.py", line 54, in init
raise Exception(f"File {ggml_model} not found!")
Exception: File ./models/gpt4all-lora-quantized-ggml.bin not found!

oops
it looks like you have no git installed on your pc and that's why it is not working.
Thanks for the information. I'll add this to the installer.
You may start by installing git before running install.bat for the meanwhile.

Ok, just an FYI - between the several things I needed to do 1) get the install.bat to use "%choice%" instead of ".choice." 2) install python, 3) install git, run the uninstall.bat and then the install.bat ... now the command prompt that starts up when clicking run.bat is working.  However, it does peg my CPU at 100% and is moving very very slowly.  I can get to the web interface which looks reasonably good.  However the interaction is extremely slow.  I'm on a Windows 11 machine with this hardware:   Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz 3.19 GHz and Installed RAM 15.9 GB
As I very much agree with the intention of this project I will be happy to help however I can.   Thanks for doing this.  It's incredibly important work, imo, and very much appreciated.

you're welcome. I really did this for the community. I'm not paid to do it. I do it on my free time. So if others want to help, please grub one of the issues I did set and if you follow the rules it would be eazy to contribute.


Fix the environment detection for node.js bundlers like rollup

Bugfix for https://github.com/snapappointments/bootstrap-select/issues/2374

@caseyjhol
Why is this still not merged ?
I also cant use that library using
import 'bootstrap-select'
import '../../../node_modules/bootstrap-select/dist/css/bootstrap-select.min.css'

Is there a workaround ?!


link regex matches trailing parens, breaks twitter char counting

... which results in 403s when people try to publish tweets that trigger it. cc @kylewm

Here was the post @dissolve tried to publish https://ben.thatmustbe.me/note/2015/1/31/1/
and the truncated text Bridgy came up with
Hey #indieweb, the coming storm of webmention Spam may not be far away. Those of us that have input fields to send… (https://ben.thatmustbe.me/note/2015/1/31/1/)

which twitter counts as 141 characters because the final ) is matched by Bridgy but not Twitter

I was wrong. It wasn't the link regex causing the problem (although that was overmatching). It's an off by one in the ellipsizing code -- it didn't account for the ellipsis when determining where to truncate.

Here's the change to autolinking https://github.com/kylewm/webutil/commit/33796ae91248423bee1a107f3276e3ed035fe603
And here's the one that accounts for the ellipsis https://github.com/snarfed/activitystreams-unofficial/commit/1ff2828434eb1eb3f1fbfcb68f950127e9b8a3b5

thanks for the research and fix (and tests!) the a-u change looks good, feel free to deploy it if you want, but no pressure.
and thanks for the auto linking changes too! you're right, I had done that subdomains one. I am often lazy about updating submodule pointers when there's nothing else to commit, but I usually do try to at least push each repo's master, so I'm surprised that one didn't make it. meh.
greetings from Carmel btw: p

@kylewm, is this one fixed now?

Yes, but I didn't deploy it yet

oh, heh, then i deployed it yesterday. :P
confirmed by previewing https://ben.thatmustbe.me/note/2015/1/31/1/ on https://www.brid.gy/twitter/dissolve333 . it now omits the final "send."


[Feature] support lookup_string function

Why I'm doing:
What I'm doing:
Fixes #48435
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@Mergify backport branch-3.2 branch-3.3


Investigate RAM consumption during crash recovery

We have received occasional reports of servers OOMing during crash recovery.
Obviously, the checkpoint has to be loaded in its' entirety, but if more is loaded from disk, it could explain the OOMing as no series maintenance or chunk eviction is running. After a quick check, I could only see chunk descs being loaded. In extreme cases, even the relatively small chunk descs might cause an OOM, so unloading chunk descs will definitely be a way to reduce RAM usage during crash recovery.
But there might be other code paths where chunks might be loaded. This has to be investigated more thoroughly.
Obviously, having #447 in place would come in handy.
@matthiasr as discussed earlier today.

Random observation: A beefy Prometheus server seemed to ramp up its RAM usage during rebuilding the metrics index (xxx metrics queued for indexing).

Wild guess: If LevelDB gets a lot of updates, it might run into trouble cleaning up and hogs too much RAM.

I have decided to not tackle the LevelDB issues. This will be hairy at best, and it is going away in v2.0 anyway.
Evicting chunkdescs is however low hanging fruit. I'll create a PR shortly (for the 1.6 release).


Missing pins issue for single port memory using sky130

Hi, for below configuration file(no of ports=1), I am getting  issue('Should use a pin iterator since more than one pin vpb' and 'No pin found with name vpb on sky130_fd_bd_sram__sram_sp_colenda. Saved as missing_pin.gds' )  but if I change no of ports to 2, I am not getting issue. I guess this issue for generating single port memories. Can you please go through my configuration file and tell me if I am making any mistake as you have closed the issue.
Data word size
word_size = 8
Number of words in the memory
num_words = 16
num_rw_ports = 1
num_r_ports = 0
num_w_ports = 0
num_spare_cols = 1
num_spare_rows = 1
Technology to use in $OPENRAM_TECH
tech_name = "sky130"
Process corners to characterize
process_corners = [ "TT" ]
Voltage corners to characterize
supply_voltages = [ 3.3 ]
Temperature corners to characterize
temperatures = [ 25 ]
Output directory for the results
output_path = "temp"
Output file base name
output_name = "sram_16x8"
Disable analytical models for full characterization (WARNING: slow!)
analytical_delay = False
To force this to use magic and netgen for DRC/LVS/PEX
Could be calibre for FreePDK45
drc_name = "magic"
lvs_name = "netgen"
pex_name = "magic"
Originally posted by @NamrathaCTR in https://github.com/VLSIDA/OpenRAM/issues/200#issuecomment-1699561502

If you installed OpenRAM more than about a week ago you will need to rerun "make install" to get the updated sram library files.

I have downloaded workspace 1 day back and had run both make pdk and make install commands

I guess this might be the commit you have done regarding missing pins issue. I had run the make file to install sky130 libraries

SRAM_LIB_GIT_COMMIT ?= 9fcf3a78398037583b6d6c1ebac71957343c4bd8
is this the hash code change in make file which is related to 1 port issue? . I had run both make pdk and make install, It still gave me same midding pins error.
And can you please tell  is banking feature supported in OpenRAM? . I Tried using "num_banks = 2" in config file, it was giving error as " bl0 net is not found in timing paths."

I changed my version to OpenRAM v1.2.15 , and generated single-port sram for sky130 successfully.


Mazerunner Kata: Even published solution times out

Quite some time ago, I created the Mazerunner Kata to fill the gap of high-tier Clojure Katas. Unfortunately, no solution ever submitted, including the one I used to create the Kata, works. There have been several complaints already and I'd really appreciate your support to help me release this Kata.
http://www.codewars.com/kata/mazerunner

I'm sorry that you never got any response. Closing this as the author's solution doesn't timeout anymore with the new runner.


Delete Trash Can

Add trash can to Action column to all Calendar Coordinators (not CIOs)

Fixed here

Trash can icon does not work for 02 50 3870 4x

Fixed event delete button


This repo is not a template

Well this is embarrassing. Apologies for missing that in the previous update.


Remove unsupported associations

Remove unsupported associations. Also, review along with the rule that 'more than three parents in the term (listed in SubClass of) give @pnrobinson belly aches.'

note to self:
(is_a: MONDO:[0-9][0-9][0-9][0-9][0-9][0-9][0-9] !)

to do:

[ ] sync subclass relationships with external classes, maybe this will bring in additional support for subclassOf axioms

the workflow would be:
will get a ROBOT template with new subclass axioms, will remove support from existing Mondo terms and then the template with new subclass axioms will be merged into Mondo and subclasses without support will be deleted

note synchronizations will be source by source
start with:

DO
NCIT
...
Orphanet

can protect sublcasses that have label overlap, such as:
'DeSanto-Shinawi syndrome due to WAC point mutation' is a child of 'DeSanto-Shinawi syndrome'
This does not appear to be the current classification in Orphanet
Nico could query for all the subclass axioms where the label of the parent is contained in the label of the child and add support.

From Nico, these are regex expressions to search and replace
Search:
(is_a: MONDO:[0-9][0-9][0-9][0-9][0-9][0-9][0-9])( !)
Replace:
$1 {source="https://orcid.org/0000-0003-1967-3726"}$2

It would be simpler to write MONDO:\d{7,7} (or something similar depending on the language?
\d{7,7} means exactly seven digits.
From: Nicole Vasilevsky @.>
Reply-To: monarch-initiative/mondo @.>
Date: Wednesday, August 23, 2023 at 00:09
To: monarch-initiative/mondo @.>
Cc: Peter Robinson @.>, Mention @.***>
Subject: [EXTERNAL]Re: [monarch-initiative/mondo] Remove unsupported associations (Issue #5857)
From Nico, these are regex expressions to search and replace
Search:
(is_a: MONDO:[0-9][0-9][0-9][0-9][0-9][0-9][0-9])( !)
Replace:
$1 {source="https://orcid.org/0000-0003-1967-3726"}$2
—
Reply to this email directly, view it on GitHubhttps://github.com/monarch-initiative/mondo/issues/5857#issuecomment-1688993716, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABFW4PAQ6QC23ZBTZL5DABLXWUUXTANCNFSM6AAAAAAUOG2F3M.
You are receiving this because you were mentioned.Message ID: @.***>
The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.

Haha. Of course! Much better Peter!

We should hold off on this until Joe is done with the subclass sync: https://github.com/monarch-initiative/mondo-ingest/issues/92


Remind users to remove unused themes

It will be good idea to remind users to uninstall/disable unused themes after certain days.

Should this only be for themes that we've installed? If so, we'll need to track them. Then also track when they get activated. @parithon do you know off the top of your head if there's an event to listen to for theme activations? I'd guess so.

@all-contributors please add @raushanraja for ideas.
Great idea @raushanraja!


iOS: Measure startup memory footprint

Summary
As part of React Native Benchmark Suite, we are looking to surface the impact of a change on the memory footprint.
I hit an issue with the JavaScriptCore instance seemingly not being cleaned up properly, and somehow gets reused (see example output below). I haven't been able figure out what the deal is, but I think it might be valuable to check this in as is.
Changelog
[Internal] [Added] - Added initial memory footprint test (this will always pass for now)
Test Plan
This currently only outputs to the console:

Checkpoint
Initial usage
Avg. usage
Std. deviation

Start loading JS
+118 784
+11 878
±35 635 (±300%)

Start executing JS
+1 372 160
+902 348
±156 937 (±17%)

Done loading JS
+110 592
+42 188
±22 883 (±54%)

cc @hramos, @mhorowitz, @sweggersen, @danrydholm

This is currently blocked internally because of these failing unit tests:
Failing tests:
	RNTesterUnitTests:
		-[RCTModuleInitTests testCustomInitModuleInitializedAtBridgeStartup]
		-[RCTModuleInitTests testCustomInitModuleInitializedAtBridgeStartup]
		-[RCTModuleInitTests testExportConstantsModuleInitializedAtBridgeStartup]
		-[RCTModuleInitTests testExportConstantsModuleInitializedAtBridgeStartup]
		-[RCTModuleInitTests testExportConstantsModuleInitializedAtBridgeStartup]
		-[RCTModuleInitTests testExportConstantsModuleInitializedAtBridgeStartup]
		-[RCTModuleInitTests testExportConstantsModuleInitializedAtBridgeStartup]
** TEST FAILED **

Sample error console output:
RNTester/RNTesterUnitTests/RCTModuleInitTests.m:236: error: -[RCTModuleInitTests testExportConstantsModuleInitializedAtBridgeStartup] : failed - Runloop timed out before condition was met
RNTester/RNTesterUnitTests/RCTModuleInitTests.m:237: error: -[RCTModuleInitTests testExportConstantsModuleInitializedAtBridgeStartup] : ((_exportConstantsModuleNotificationSent) is true) failed
RNTester/RNTesterUnitTests/RCTModuleInitTests.m:239: error: -[RCTModuleInitTests testExportConstantsModuleInitializedAtBridgeStartup] : failed - Runloop timed out before condition was met
RNTester/RNTesterUnitTests/RCTModuleInitTests.m:240: error: -[RCTModuleInitTests testExportConstantsModuleInitializedAtBridgeStartup] : ((module.exportedConstants) is true) failed


Fresh Deployment with PointInTimeRecovery Fails

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
20
Amplify CLI Version
not sure
What operating system are you using?
mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
import { defineBackend } from '@aws-amplify/backend';
import { auth } from './auth/resource';
import { data } from './data/resource';
import { storage } from './storage/resource';
/**

@see https://docs.amplify.aws/react/build-a-backend/ to add storage, functions, and more
*/
const backend = defineBackend({
auth,
data,
storage
});

const dataResources = backend.data.resources;
dataResources.cfnResources.cfnGraphqlApi.xrayEnabled = true;
Object.values(dataResources.cfnResources.amplifyDynamoDbTables).forEach((table) => {
table.pointInTimeRecoveryEnabled = true;
});
Describe the bug
when enabling PIR it seems to fail when deploying from scratch, but works iteratively
Expected behavior
always works
Reproduction steps
enable the PIR and deploy from scratch
Project Identifier
No response
Log output

# Put your logs below this line

2024-06-14T12:38:27.467Z [INFO]: CloudFormationDeploymentError: The CloudFormation deployment has failed.

804

Resolution: Find more information in the CloudFormation AWS Console for this stack.

805

Cause: ❌ Deployment failed: Error: The stack named amplify-d2vgttdm5hfz44-nextjs14-branch-303eb35053 failed creation, it may need to be manually deleted from the AWS console: ROLLBACK_COMPLETE: Received response status [FAILED] from custom resource. Message returned: Backups are being enabled for the table: Post-h5podyoocvdqtcex6vi6tbuii4-NONE. Please retry later (RequestId: ef8a80c8-bfb6-49aa-8d36-40bb72b8a0b1), Embedded stack arn:aws:cloudformation:us-east-1:258175735278:stack/amplify-d2vgttdm5hfz44-nextjs14-branch-303e-amplifyDataPostNestedStackPostNestedStackR-BANCGW57TWX6/9e855760-2a4a-11ef-aee9-12ed87b41109 was not successfully created: The following resource(s) failed to create: [PostTable]. , Embedded stack arn:aws:cloudformation:us-east-1:258175735278:stack/amplify-d2vgttdm5hfz44-nextjs14-branch-303eb35053-data7552DF31-1DU99RJ0TCEHO/6b14da90-2a4a-11ef-a7cd-0e3bb866ed39 was not successfully created: The following resource(s) failed to create: [amplifyDataPostNestedStackPostNestedStackResourceB65AFCD3].

806

2024-06-14T12:38:27.470Z [INFO]: CloudFormationDeploymentError: The CloudFormation deployment has failed.

807

2024-06-14T12:38:27.470Z [INFO]: Resolution: Find more information in the CloudFormation AWS Console for this stack.

808

Cause: ❌ Deployment failed: Error: The stack named amplify-d2vgttdm5hfz44-nextjs14-branch-303eb35053 failed creation, it may need to be manually deleted from the AWS console: ROLLBACK_COMPLETE: Received response status [FAILED] from custom resource. Message returned: Backups are being enabled for the table: Post-h5podyoocvdqtcex6vi6tbuii4-NONE. Please retry later (RequestId: ef8a80c8-bfb6-49aa-8d36-40bb72b8a0b1), Embedded stack arn:aws:cloudformation:us-east-1:258175735278:stack/amplify-d2vgttdm5hfz44-nextjs14-branch-303e-amplifyDataPostNestedStackPostNestedStackR-BANCGW57TWX6/9e855760-2a4a-11ef-aee9-12ed87b41109 was not successfully created: The following resource(s) failed to create: [PostTable]. , Embedded stack arn:aws:cloudformation:us-east-1:258175735278:stack/amplify-d2vgttdm5hfz44-nextjs14-branch-303eb35053-data7552DF31-1DU99RJ0TCEHO/6b14da90-2a4a-11ef-a7cd-0e3bb866ed39 was not successfully created: The following resource(s) failed to create: [amplifyDataPostNestedStackPostNestedStackResourceB65AFCD3].

809

2024-06-14T12:38:27.575Z [ERROR]: !!! Build failed

810

2024-06-14T12:38:27.575Z [INFO]: Please read more about Amplify Hosting's support for SSR frameworks to find if your build failure is related to an unsupported feature: https://docs.aws.amazon.com/amplify/latest/userguide/amplify-ssr-framework-support.html. You may also find this troubleshooting guide useful: https://docs.aws.amazon.com/amplify/latest/userguide/troubleshooting-ssr-deployment.html

811

2024-06-14T12:38:27.575Z [ERROR]: !!! Error: Command failed with exit code 1

812

2024-06-14T12:38:27.576Z [INFO]: # Starting environment caching...

813

2024-06-14T12:38:27.576Z [INFO]: # Environment caching completed

814

Additional information
System:
OS: macOS 14.4.1
CPU: (12) arm64 Apple M2 Max
Memory: 122.33 MB / 32.00 GB
Shell: /bin/zsh
Binaries:
Node: 20.10.0 - ~/.volta/tools/image/node/20.10.0/bin/node
Yarn: 1.22.21 - ~/.volta/tools/image/yarn/1.22.21/bin/yarn
npm: 10.2.3 - ~/.volta/tools/image/node/20.10.0/bin/npm
pnpm: 9.1.4 - ~/Library/pnpm/pnpm
NPM Packages:
@aws-amplify/backend: 1.0.3
@aws-amplify/backend-cli: 1.0.4
aws-amplify: 6.3.6
aws-cdk: 2.145.0
aws-cdk-lib: 2.145.0
typescript: 5.4.5
AWS environment variables:
AWS_PROFILE = sandbox
AWS_STS_REGIONAL_ENDPOINTS = regional
AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
AWS_SDK_LOAD_CONFIG = 1
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

om the message Backups are being enabled for the table and the documentation it appears a different process is creating the PITR. was there a pervious build that attempted to enable this or was there any manual changes on the console?

Not that I'm aware, I had the amplify sandbox (continuous local sync) running locally, which worked fine. Then when creating the app from scratch in Amplify Hosting I ran into this. Haven't tried to reproduce it again so far. However, the code is public https://github.com/cdk-dev/website/ :)

Hi @skorfmann 👋 , just checking in to see whether you are continuing to observe the Backups are being enabled for the table error during the deployment or are you now unblocked?

Closing the issue due to inactivity. Do reach out to us if you are still experiencing this issue


Sync dataset editor

This PR implements the sql editor.
cc @xavijam

Let's wait for green ball, and then free to merge :es:, grande, máquina, ❤ .


Can't pull pgp key from user that was followed only locally

$ keybase pgp follow <user>
Publicly follow? [y/N]
Answer No to public follow.
Then, using keybase command line client
$ keybase pgp pull <user>
▶ ERROR Assertion <user> did not match any tracked users.
If the user is publicly followed, it works as expected.
Is this expected behavior?  (Why?)

I think it is intended but we also intend to fix it. For now, logout, then
pgp pull, then login. That should work around the issue. Let me know if
not.
On Wed, May 30, 2018 at 9:16 AM gunnarx<EMAIL_ADDRESS>wrote:

$ keybase pgp follow
Publicly follow? [y/N]
Answer No to public follow.
Then, using keybase command line client
$ keybase pgp pull
▶ ERROR Assertion did not match any tracked users.
Is this expected behavior? (Why?)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/12109, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_7uZ714rnad6WU2_9tQKJQmSUXs2ks5t3pumgaJpZM4UTQXI
.

I think it is intended but we also intend to fix it.

That answer is a bit hard to understand.
Anyway the workaround failed for me:
$ keybase logout
$ keybase login

Unfollowed a user I know:
$ keybase unfollow <user>
Followed again
$ keybase follow <user>
Answered yes to all questions except No to Public follow.
$ keybase pgp pull <user>
Same result.
Tried following you (max) similarly, but not public.
By the way:
$ keybase list-following
also does not include the user, so I suppose that is the root of the problem?

Just to document desired behavior (from my perspective) after doing non-public follow:

keybase list-following
lists all followed users and indicate for each if they are publicly or only locally followed
keybase pull pgp <user>  and similar commands work as intended.

No, I meant keybase logout
And then try to keybase pgp pull

Oh, ok.  Sorry for not reading your instruction correctly.  It was too unexpected for me that I should have to not be logged in...
You are correct, I can pull any key, whether they are followed or not, if I am logged out.
For the ticket, I suppose we have consensus that the behavior&message is unexpected and there is a plan to make  some change.  (I'm not clear on what you have planned though).
What about:
"keybase list-following
lists all followed users and indicates for each if they are publicly or only locally followed"
What do you think about that, and should I consider that a (separate) feature request?