Feat: Optionally use pigz to speed up tarball compression

Why are the changes needed?
In an (admittedly large) repository, fast registration has become quite slow for us. The culprit appears to be the compression of the code tarball which I have observed to take up to a minute. (I'm already ignoring non-relevant parts of the code base using a .flyteignore.)
What changes were proposed in this pull request?
In the fast package helper, where we currently compress the code tarball using cpython's gzip, I propose to check whether the user has pigz installed and if yes, leverage it to speed up the compression.
In our case, I'm seeing a speedup from ~60s to ~1-2s.
I expect that the majority of users will not run into these performance issues but for those that might, I propose to add a log message with a hint to install pigz in case the default compression mechanism takes to long.
I see that you recently refactored the fast registration logic @wild-endeavor, what do you think about this proposal?
Check all the applicable boxes

[ ] I updated the documentation accordingly.
[x] All new and existing tests passed.
[x] All commits are signed-off.

@fg91 Do you think it's worth refactoring the taring code path into a helper function?

Done https://github.com/flyteorg/flytekit/pull/2729/commits/d32822314c401205ee93b7801dcbd53af9301775

let's get this in and we can all test it.  we're shooting for a beta release soon with some larger changes, possibly some that is a bit backwards incompatible in some edge cases, so we will do a longer testing period.

If it's identical, can you add a note to clis.rst as well in the fast register section suggesting that people download this tool? I'm not sure how we never knew about this, sad. Thanks for enlightening us!

https://github.com/flyteorg/flytekit/pull/2729/commits/a1f6418cdd3436e5b61d9856404913cbeec099a3


Update managed-application-createuidefinition-functions.md

Fix typo in decodeUriComponent example.

@stuartpreston,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@tabrezm Please review these proposed changes. Thanks.

LGTM #sign-off


feat(applications): add event broadcasts nsip-project case team (BOAS-1434)

Describe your changes
WORK IN PROGRESS
BOAS-1434 Add Event Broadcasts - nsip-project case team
https://pins-ds.atlassian.net/browse/BOAS-1434
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[x] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[x] I have provided a description of the ticket
[x] I have included unit tests to cover any testable code changes

also check that re-seeding the DB works, as I know it clears down the case records etc in dev and Test, and we have had issues of the seeder failing after a schema change.
Otherwise all looks good, and I like the idea of the dummy data to enable us to easily work in local dev, nice one!

Reseeding tested and works fine.


Add support for Prettier

Will help enforce a greater style rather than using the Vscode extension.
https://www.npmjs.com/package/prettier

See: 094516d90ac5767e39635df3395d605f59d4d4eb a6e0d36892b6f3a3ced3d52911eb37a59e06fcad


framework:demodata console command options

Would be nice to have options on the framework:demodata command
Like the number of products, main-categories, sub-categories, etc...
Also, add an option for extra demo Sales Channels
For performance tests, this will be great to be able to simulate big stores and adjust server requirements...
Note: changing the hardcoded values from /vendor/shopware/core/Framework/Demodata/Command/DemodataCommand.php
to big values for the image media generator takes an unreasonable amount of RAM, this needs some optimization

Hello @TaiKamilla,
this options are already built in, e.g. you can use the -p option to define the number of products that should be generated, or -c for the number of categories.
For reference you can use bin/console framework:demodata --help to get a full list of supported options.
Kind regards
Jonas

Hi @keulinho ,
Thanks for your reply!
What about the amount of memory when creating 300K products with 2 images per product (600K images), it takes more than 60GB of RAM
I know this will take a couple of days but still, to test a production env would nice

Hey @TaiKamilla,
you could try to create a /build/media folder in your project root directory and provide some proper demo images there that should be used (.jpg and .png is currently supported).
That way the demodata generetor will use those images, instead of generating 2 new images per product.
This assumes that image generation and not the image saving inside the Core is the major bottleneck there, but it's definitely worth the try.
Probably the number of images and file size of the images you provide in the build/media folder will have an impact on RAM and runtime of the command.
Will be happy if you can share some results.
Kind regards
Jonas


Update Rudder

update rudder to fix the build for Android & iOS

Cherry pick is scheduled.

/cherry-pick release-1.39


Cannot read property 'utils' of undefined in Pixi.js plugin.

The plugin pixi-timer run with pixi.js 4.3.0, can see:

because can not found PIXI object, v3.0.8 is OK.
Are there something  specail in v4.3.0, How to do with it ?

After importing PIXI and before importing pixi-timer try:
window.PIXI = PIXI;
window.PIXI[ "default" ] = PIXI;

Fixed issuses for me with pixi-audio

If I use it with script tag to import the plugin, how to do with it ?

are you importing PIXI before pixi-timer?

It works~ when use script tag to import the plugin.
<script src="http://cdn.bootcss.com/pixi.js/4.3.0/pixi.min.js"></script>
<script type="text/javascript">
  window.PIXI = PIXI;
  window.PIXI[ "default" ] = PIXI;
</script>
<script src="../../build/pixi-action.js"></script>

But this is really not perfact, How to do something in the plugin source code to solve it.

try removing this line

in your ActionManager, maybe it helps

Can not work, new error:
Uncaught TypeError: Cannot read property 'actionManager' of undefined

and
move.html:24 Uncaught TypeError: Cannot read property 'MoveTo' of undefined

I have test pixi-timer, has same errors.

How to solver it in plugin's source code, or need to do something in pixi.js 's code.

The correct import for pixi.js is import * as PIXI from 'pixi.js'; Pixi has no default export.

@englercj done.
replace all the import * as PIXI from 'pixi.js';, then OK.
last friday ,I just replace the code in index.js.


Spline post-processing after finite difference

Nice paper. Can you confirm that,  in the data generation for the Poisson problem $-\Delta u = f$ for $u\in H^1_0$, the finite difference solution is actually post-processed by this line of code?
https://github.com/NBoulle/pde-learning/blob/61f9838d11c4620771fbaa604325872443b29e66/data/solve_gwf.m#L16

Yes, this is a code from https://github.com/neuraloperator/neuraloperator/tree/master/data_generation/darcy.


nether mod installation

nether mod installation
https://github.com/minetest-mods/nether
https://github.com/minetest-mods/nether/archive/refs/heads/master.zip

Per the mod documentation, we need to allocate at least 3000 node tall region to Nether.  Ideally, I would put this at the bottom of the world (-27k to -30k).  But, I do not yet know if anyone has built anything significant there or not.
However, the server also has defined everything above 18k as "reserved".  We could take a 3k tall section from there (start at very top and go down 3k, instead of building just above the warzone, which ends at 18k).

I have found a few travelnets down there. Maybe some underground bases here and there.

We need to carefully analyze how many additional nodes this mod will define.  Due to implementation details, a server is allowed at most 32,767 total "registered nodes".  EdenLost is already getting close to this limit.
(from the startup log spam)
Registered nodes: 26154
Registered items: 27546
Registered entities: 328

I wrote a crude mod to dump the stats on how many nodes each mod registers:
https://github.com/EdenLostMinetest/node_stats
I'm not sure what nodes are in "pandorabox_custom", but maybe we can remove those.  I am surprised at the count of nodes registered by scifi_nodes though.
$ cat worlds/world/node-stats.txt | sort -rn | head -n 20
4658 moreblocks
4203 scifi_nodes
2250 cblocks
1506 technic_cnc
1370 moretrees
1235 bakedclay
1198 letters
757 workbench
524 bridger
522 ??
520 mypaths
458 planet_mars
456 building_blocks
443 extranodes
416 pandorabox_custom
384 facade
382 pipeworks
318 street_signs
285 ethereal
269 farming


Rewrite deploy to be beatmap-based

Depends on #28 (has that commit cherry-picked in, see 350c85e60a9573edd52d102a9d4c7f658c184eff for actual changes)
This rewrites deploy to be beatmap-based rather than score-based. This allows us to only parse a beatmap once, and also group scores by their mods and re-use the difficulty attributes for significant performance (and probably memory) gains.

Ideally measure the perf/time difference/win it gets us! :D

Did some local benchmarking to figure out how much this is going to gain realistically. Obviously this isn't a direct comparison because it's comparing parallel processing of scores in pp order to processing scores per beatmap.
Regardless, the improvement is huge.
Before
Old deploy command takes roughly ~1min to process 1000 scores:

After
Processed multiple beatmaps each with thousands of scores within just a few seconds:


Feature/monthly update form navigation

This implements the basic version of the modified top navigation, where there's no link to pages after the current page.
I'll start looking into the matter of linking to pages beyond the current page if those later pages have already been completed, but this should be adequate for an initial release.
I'll leave this PR in draft for now.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@0d8abd3). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage        ?   97.54%
=======================================
  Files           ?       55
  Lines           ?     3624
  Branches        ?        0
=======================================
  Hits            ?     3535
  Misses          ?       89
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d8abd3...1b19343. Read the comment docs.


ocilib window directory....

Please give me a little detail on how to use it on the window platform.
-unzip the archive
-copy ocilib \ include \ ocilib.h to any place located in your includes path
-copy ocilib \ lib32 | 64 \ ocilib [x] .lib to any place located in your libraries path
-copy ocilib \ lib32 | 64 \ ocilib [x] .dll to any place located in your windows path
Exactly now C: \ Users \ ****** \ Documents \ Visual Studio 2015 \ Projects \ console_Ocilib
I'm working on a path but I don't know how to put the files.
please. The version is using oracle 11g r2, and the existing oci.dll oci.lib should also work together .. I'm not sure

Hi,
what is not clear ?
Let's say you have uncompressed the archive to c:\ocilib.

You have to add "c:\ocilib\include" to your project "include path" options
You have to add "c:\ocilib\lib32" or "c:\ocilib\lib64"to your project "library path" options
Then you can compile your project that includes "ocilib.h"
You can copy the ocilib(a|w).dll from the lib32 or lib64 folder to the folder where your exe is located
Or you can add "c:\ocilib\lib32" or "c:\ocilib\lib64" to the windows PATH environment variable

Regards,
Vincent

Closing as no news from op


Application fails to start

I get the following error when I try to start:
<frozen importlib._bootstrap>:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144 from C header, got 152 from PyObject
<frozen importlib._bootstrap>:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144 from C header, got 152 from PyObject
<frozen importlib._bootstrap>:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144 from C header, got 152 from PyObject
<frozen importlib._bootstrap>:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144 from C header, got 152 from PyObject
<frozen importlib._bootstrap>:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144 from C header, got 152 from PyObject
<frozen importlib._bootstrap>:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144 from C header, got 152 from PyObject
INFO:authentication:Loaded token <class 'xbox.webapi.authentication.token.AccessToken'> from file
INFO:authentication:Loaded token <class 'xbox.webapi.authentication.token.RefreshToken'> from file
INFO:authentication:Loaded token <class 'xbox.webapi.authentication.token.UserToken'> from file
INFO:authentication:Loaded token <class 'xbox.webapi.authentication.token.XSTSToken'> from file
Traceback (most recent call last):
  File "/home/USER/.local/bin/xbox-nano-client", line 8, in <module>
    sys.exit(main())
  File "/home/USER/.local/lib/python3.8/site-packages/xbox/nano/scripts/client.py", line 40, in main
    if len(discovered):
TypeError: object of type 'coroutine' has no len()
sys:1: RuntimeWarning: coroutine 'Console.discover' was never awaited

You are not running the latest version
From your virtual environment execute
pip install -U xbox-smartglass-nano

Thanks for that! I did that, and now I'm getting another error:
DEBUG:xbox.sg.protocol:Received DiscoverResponse from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received DiscoverResponse from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received DiscoverResponse from <IP_ADDRESS>
Traceback (most recent call last):
  File "/home/torma/.local/bin/xbox-nano-client", line 8, in <module>
    sys.exit(main())
  File "/home/torma/.local/lib/python3.8/site-packages/xbox/nano/scripts/client.py", line 59, in main
    loop.run_until_complete(async_main())
  File "/usr/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/home/torma/.local/lib/python3.8/site-packages/xbox/nano/scripts/client.py", line 35, in async_main
    await console.connect("", "")
  File "/home/torma/.local/lib/python3.8/site-packages/xbox/sg/console.py", line 381, in connect
    raise ConnectionError("Anonymous connection not allowed, please"
ConnectionError: Anonymous connection not allowed, please supply userhash and auth-token

I'm authenticated already for xbox-tui and that's working, but I'm not sure if this requires further authentication!

yeah, I did not re-implement authenticated connection... can you fallback to allow unauthenticated for now in xbox settings?

Ahh ok, I see.
As it turns out, my xbox-tui authentication broke once I updated too, so disregard that from earlier. Disabling authenticated for now, hopefully that's re-implemented soon!

I'm sorry for my confusion, but how would I allow unauthenticated connection in the xbox settings? I had assumed that was the "allow remote connection from any device", but I'm still getting the same error in both this and the following in xbox-tui:
Xbox SmartGlass main client started
Authenticating...
Traceback (most recent call last):
  File "/home/torma/.local/bin/xbox-tui", line 8, in <module>
    sys.exit(main_tui())
  File "/home/torma/.local/lib/python3.8/site-packages/xbox/scripts/main_cli.py", line 623, in main_tui
    main(Commands.TUI)
  File "/home/torma/.local/lib/python3.8/site-packages/xbox/scripts/main_cli.py", line 576, in main
    loop.run_until_complete(main_async(loop, command))
  File "/usr/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/home/torma/.local/lib/python3.8/site-packages/xbox/scripts/main_cli.py", line 391, in main_async
    auth_manager = await do_authentication(args)
  File "/home/torma/.local/lib/python3.8/site-packages/xbox/scripts/main_cli.py", line 265, in do_authentication
    auth_mgr.oauth = OAuth2TokenResponse.parse_raw(tokens)
  File "pydantic/main.py", line 538, in pydantic.main.BaseModel.parse_raw
  File "pydantic/main.py", line 515, in pydantic.main.BaseModel.parse_obj
  File "pydantic/main.py", line 362, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 6 validation errors for OAuth2TokenResponse
token_type
  field required (type=value_error.missing)
expires_in
  field required (type=value_error.missing)
scope
  field required (type=value_error.missing)
access_token
  field required (type=value_error.missing)
refresh_token
  field required (type=value_error.missing)
user_id
  field required (type=value_error.missing)

@tuxuser any advice? I haven't been able to get anything other than xbox-discover to work all day :(

I removed my ~/.local/share/xbox/tokens.json' file and tried re-running xbox-authenticate. That seemed to work for xbox-tui (which is no longer giving me an error), but xbox-nano-client` is still giving the following error:
DEBUG:xbox.sg.protocol:Received DiscoverResponse from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received DiscoverResponse from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received DiscoverResponse from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received DiscoverResponse from <IP_ADDRESS>
Traceback (most recent call last):
  File "/home/torma/.local/bin/xbox-nano-client", line 8, in <module>
    sys.exit(main())
  File "/home/torma/.local/lib/python3.8/site-packages/xbox/nano/scripts/client.py", line 59, in main
    loop.run_until_complete(async_main())
  File "/usr/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/home/torma/.local/lib/python3.8/site-packages/xbox/nano/scripts/client.py", line 35, in async_main
    await console.connect("", "")
  File "/home/torma/.local/lib/python3.8/site-packages/xbox/sg/console.py", line 381, in connect
    raise ConnectionError("Anonymous connection not allowed, please"
ConnectionError: Anonymous connection not allowed, please supply userhash and auth-token

I did a complete uninstall and reinstalled in a new venv. It looks like things are working a bit better now, but the application is still exiting with an error:
DEBUG:xbox.sg.protocol:Received DiscoverResponse from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received DiscoverResponse from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received DiscoverResponse from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Sending ConnectRequest to <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received ConnectResponse from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Sending LocalJoin message on ServiceChannel Core to <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received Ack message on ServiceChannel Ack from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received ConsoleStatus message on ServiceChannel Core from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Sending StartChannelRequest message on ServiceChannel Core to <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received Ack message on ServiceChannel Ack from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received StartChannelResponse message on ServiceChannel Core from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Acquired ServiceChannel SystemInput -> Channel: 0x6
DEBUG:xbox.sg.protocol:Sending StartChannelRequest message on ServiceChannel Core to <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received Ack message on ServiceChannel Ack from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Sending StartChannelRequest message on ServiceChannel Core to <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received Ack message on ServiceChannel Ack from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Sending StartChannelRequest message on ServiceChannel Core to <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received Ack message on ServiceChannel Ack from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Sending StartChannelRequest message on ServiceChannel Core to <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received Ack message on ServiceChannel Ack from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Sending Ack message on ServiceChannel Core to <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received StartChannelResponse message on ServiceChannel Core from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Acquired ServiceChannel SystemInputTVRemote -> Channel: 0x7
DEBUG:xbox.sg.protocol:Received StartChannelResponse message on ServiceChannel Core from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Acquired ServiceChannel SystemMedia -> Channel: 0x8
DEBUG:xbox.sg.protocol:Received StartChannelResponse message on ServiceChannel Core from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Acquired ServiceChannel SystemText -> Channel: 0x9
DEBUG:xbox.sg.protocol:Received StartChannelResponse message on ServiceChannel Core from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Acquired ServiceChannel SystemBroadcast -> Channel: 0xa
DEBUG:xbox.sg.protocol:Received Ack message on ServiceChannel Ack from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received Json message on ServiceChannel SystemBroadcast from <IP_ADDRESS>
DEBUG:xbox.sg.protocol:Received Json message on ServiceChannel SystemBroadcast from <IP_ADDRESS>
Traceback (most recent call last):
  File "/home/USER/.local/bin/xbox-nano-client", line 8, in <module>
    sys.exit(main())
  File "/home/USER/.local/lib/python3.8/site-packages/xbox/nano/scripts/client.py", line 59, in main
    loop.run_until_complete(async_main())
  File "/usr/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/home/USER/.local/lib/python3.8/site-packages/xbox/nano/scripts/client.py", line 41, in async_main
    await console.nano.start_stream()
  File "/home/USER/.local/lib/python3.8/site-packages/xbox/nano/manager.py", line 89, in start_stream
    await self._send_json(msg.dict())
  File "/home/USER/.local/lib/python3.8/site-packages/xbox/sg/manager.py", line 107, in _send_json
    return await self.console.json(data, channel=self._channel)
  File "/home/USER/.local/lib/python3.8/site-packages/xbox/sg/console.py", line 357, in json
    return await self.protocol.send_message(data, channel=channel)
  File "/home/USER/.local/lib/python3.8/site-packages/xbox/sg/protocol.py", line 133, in send_message
    if msg.header.pkt_type == PacketType.Message:
AttributeError: 'dict' object has no attribute 'header'

Both this and xbox-tui won't launch unless xbox-webapi-ex is installed (they coimplain about missing xbox.webapi.scripts.tui and xbox.webapi.authentication.manager respectively).

Works in python 3.9

Works in python 3.9


Add smooth transition to seeding

We should have some information about whether or not we're seeding, and use that to inform our decisions. We should also inform all the peers of when we become a seeder, so that they can send UnChokes to the right places

On second thought it seems like this is more or less already done?
We will never register as interested again, since we have all the pieces

This can be considered done for now, given that we use upload rate to choose peers when seeding.


Close the file when IOException occurs in AbstractMemoryHttpData.

Motivation:
An IOException may be thrown from FileChannel.read, and cause the fd leak.
Modification:
Close the file when IOException occurs.
Result:
Avoid fd leak.

@netty-bot test this please

@normanmaurer PTAL

@netty-bot test this please

@seedeed thanks a lot.


make test-integration fails on a clean docker daemon

I launched a brand new VM running minikube and set my env to point to the new, clean minikube daemon. When I run make test-integration, I get this:
ENG000656:service-catalog aaronschlesinger$ make test-integration
# Generate defaults
docker run --rm -ti -v /Users/aaronschlesinger/gocode/src/github.com/kubernetes-incubator/service-catalog:/go/src/github.com/kubernetes-incubator/service-catalog -v /Users/aaronschlesinger/gocode/src/github.com/kubernetes-incubator/service-catalog/.pkg:/go/pkg scbuildimage bin/defaulter-gen \
		--v 1 --logtostderr \
		--go-header-file "vendor/github.com/kubernetes/repo-infra/verify/boilerplate/boilerplate.go.txt" \
		--input-dirs "github.com/kubernetes-incubator/service-catalog/pkg/apis/servicecatalog" \
		--input-dirs "github.com/kubernetes-incubator/service-catalog/pkg/apis/servicecatalog/v1alpha1" \
	  	--extra-peer-dirs "github.com/kubernetes-incubator/service-catalog/pkg/apis/servicecatalog" \
		--extra-peer-dirs "github.com/kubernetes-incubator/service-catalog/pkg/apis/servicecatalog/v1alpha1" \
		--output-file-base "zz_generated.defaults"
Unable to find image 'scbuildimage:latest' locally
Pulling repository docker.io/library/scbuildimage
docker: Error: image library/scbuildimage not found.
See 'docker run --help'.
make: *** [.generate_files] Error 125

The workaround of course is to run make clean test-integration. I'm wondering if there's a way to docker build the build image if it doesn't exist, or, alternatively, push the image to a public registry.

We need to add .scBuildImage a precondition of test-integration target do this, should be pretty-standard.

done as part of #424

Closed by #424


npm run build doesn't work

I freshly cloned this repo and after npm i I ran npm run build and the following error occurs:
><EMAIL_ADDRESS>build /home/username/git/DanielYKPan/date-range-picker
> rimraf dist && webpack --config config/webpack.prod.js --progress --profile --bail

  0% compilingEntryModuleNotFoundError: Entry module not found: Error: Can't resolve './src/polyfills.ts' in '/home/username/git/DanielYKPan/date-range-picker'
    at moduleFactory.create (/home/username/git/DanielYKPan/date-range-picker/node_modules/webpack/lib/Compilation.js:362:29)
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/webpack/lib/NormalModuleFactory.js:234:19
    at onDoneResolving (/home/username/git/DanielYKPan/date-range-picker/node_modules/webpack/lib/NormalModuleFactory.js:59:20)
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/webpack/lib/NormalModuleFactory.js:126:20
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/async/dist/async.js:3838:9
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/async/dist/async.js:421:16
    at iteratorCallback (/home/username/git/DanielYKPan/date-range-picker/node_modules/async/dist/async.js:996:13)
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/async/dist/async.js:906:16
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/async/dist/async.js:3835:13
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/webpack/lib/NormalModuleFactory.js:121:22
    at onResolved (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/Resolver.js:70:11)
    at loggingCallbackWrapper (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/createInnerCallback.js:31:19)
    at afterInnerCallback (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/Resolver.js:138:10)
    at loggingCallbackWrapper (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/createInnerCallback.js:31:19)
    at Resolver.applyPluginsAsyncSeriesBailResult1 (/home/username/git/DanielYKPan/date-range-picker/node_modules/tapable/lib/Tapable.js:181:46)
    at innerCallback (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/Resolver.js:125:19)
    at loggingCallbackWrapper (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/createInnerCallback.js:31:19)
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/tapable/lib/Tapable.js:283:15
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/UnsafeCachePlugin.js:38:4
    at loggingCallbackWrapper (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/createInnerCallback.js:31:19)
    at afterInnerCallback (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/Resolver.js:138:10)
    at loggingCallbackWrapper (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/createInnerCallback.js:31:19)
    at Resolver.applyPluginsAsyncSeriesBailResult1 (/home/username/git/DanielYKPan/date-range-picker/node_modules/tapable/lib/Tapable.js:181:46)
    at innerCallback (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/Resolver.js:125:19)
    at loggingCallbackWrapper (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/createInnerCallback.js:31:19)
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/tapable/lib/Tapable.js:283:15
    at innerCallback (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/Resolver.js:123:11)
    at loggingCallbackWrapper (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/createInnerCallback.js:31:19)
    at /home/username/git/DanielYKPan/date-range-picker/node_modules/tapable/lib/Tapable.js:283:15
    at resolver.doResolve.createInnerCallback (/home/username/git/DanielYKPan/date-range-picker/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:44:6)
resolve './src/polyfills.ts' in '/home/username/git/DanielYKPan/date-range-picker'
  using description file: /home/username/git/DanielYKPan/date-range-picker/package.json (relative path: .)
    Field 'browser' doesn't contain a valid alias configuration
  after using description file: /home/username/git/DanielYKPan/date-range-picker/package.json (relative path: .)
    using description file: /home/username/git/DanielYKPan/date-range-picker/package.json (relative path: ./src/polyfills.ts)
      as directory
        /home/username/git/DanielYKPan/date-range-picker/src/polyfills.ts doesn't exist
      no extension
        Field 'browser' doesn't contain a valid alias configuration
        /home/username/git/DanielYKPan/date-range-picker/src/polyfills.ts doesn't exist
      .ts
        Field 'browser' doesn't contain a valid alias configuration
        /home/username/git/DanielYKPan/date-range-picker/src/polyfills.ts.ts doesn't exist
      .js
        Field 'browser' doesn't contain a valid alias configuration
        /home/username/git/DanielYKPan/date-range-picker/src/polyfills.ts.js doesn't exist
      .json
        Field 'browser' doesn't contain a valid alias configuration
        /home/username/git/DanielYKPan/date-range-picker/src/polyfills.ts.json doesn't exist

npm ERR! Linux 4.4.0-75-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "build"
npm ERR! node v6.10.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build: `rimraf dist && webpack --config config/webpack.prod.js --progress --profile --bail`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'rimraf dist && webpack --config config/webpack.prod.js --progress --profile --bail'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the ng-pick-daterange package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     rimraf dist && webpack --config config/webpack.prod.js --progress --profile --bail
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs ng-pick-daterange
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls ng-pick-daterange
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/username/git/DanielYKPan/date-range-picker/npm-debug.log

Same problem here, I forked this to fix some issues but I don't know how to build it, never worked on module packages before.


Grounding with context fails in Python 3.6

Hello,
I am facing a RuntimeError that is produced while working with the clingo Python API. Using previous clingo versions and Python 2, I was able to define a class, pass it to grounding via the named argument "context", and thereby use its methods from within a logic program through the @-syntax. Once I updated to clingo 5.2.1 and Python 3.6 this fails with a RuntimeError.
Here is a toy example of the problem.
import clingo
import sys
print(clingo.__version__)
print(sys.version)

def on_model(m):
    print(m)

class context_provider:
    def ausgeber(self,x):
        print('function call:',x)
        return clingo.Number(2)

context=context_provider()
prg=clingo.Control(['-n0'])
prg.add("base", [], "a(@ausgeber(1)).")
prg.ground([("base", [])],context=context)
prg.solve(on_model=on_model)

Under previous versions, running this Python script would return the expected output:
5.1.0
2.7.11 |Anaconda 2.2.0 (64-bit)| (default, Dec  6 2015, 18:08:32)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
('function call:', 1)
a(2)

Under Python 3.6 it no longer works:
5.2.1
3.6.2 |Continuum Analytics, Inc.| (default, Jul 20 2017, 13:51:32)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
~/Desktop/steady_ready_projects/circuit_enumeration/ASP_files/taking_control/context_function_module.py in <module>()
     20 prg=clingo.Control(['-n0'])
     21 prg.add("base", [], "a(@ausgeber(1)).")
---> 22 prg.ground([("base", [])],context=context)
     23 prg.solve(on_model=on_model)
     24

RuntimeError: <block>:1:3-15: error: error in context:
  SystemError: Objects/tupleobject.c:81: bad argument to internal function

Is there any way to overcome this problem? Thanks.
Best,
Torsten

This issue should be fixed with 5c67b2957bb3017ab5f834ce1ad23dda7c23544d. It is already fixed in the master branch. At some point the fix will be included in clingo 5.2.2.


Export / import to JSon request

Hi there, I have idea, because I am now often working with JSon on my iPad. Is there any chance to create internal func or external plugin to export and import model elements to standard JSon? It may helps I believe not only for me.

We have no plans to implement export/import JSON. However, if someone else wishes to do so they could develop their own plug-in. See https://github.com/archimatetool/archi/wiki/Developing-Import-and-Export-Plug-ins
I'll close this issues, because of reasons above.

Export can be easily done with jArchi and  JSON.stringify.
Import should be doable too, but that's a bit more work.


BFormCheckbox plain property not compatible with bootstrap-vue

In bootstrap-vue-2, the plain property seems to behave exact the opposite of the behavior of bootstrap-vue.
In bootstrap-vue from the documentation :
property plain, type Boolean, Default false, Render the form control in plain mode, rather than custom styled mode
In bootstrap-vue-3, the plain property has default value true and it's behavior is exactly the opposite of the behavior in bootstrap-vue.
If I set the property plain to true, the checkbox is rendered in custom styling.
This seams to me to be very confusing. If I set the plain property to true, I expect it to rendered plain (As the browser renders it)
Also it's not helping people migrating from bootstrap-vue.
Is this intentionally, or is this a bug?

@cdmoro : Do you agree that this is a bug and needs to be fixed?
If you agree, I'll have a look at reversing the plain property behavior

Yes, this is a bug, definitely. It would be nice if you could fix it, thanks!


HDDS-4129. change MAX_QUOTA_IN_BYTES to Long.MAX_VALUE.

What changes were proposed in this pull request?
Currently MAX_QUOTA_IN_BYTES is 1EB, which is not very exact. Later we need use this to determine whether quota is enabled or not.
We need to change it to long.max_value to be consistent with HDFS.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4129
How was this patch tested?
Existing UT

Closing this as HDDS-4089 planning to fix this issue to make ACL commands work with the external authorizer.

Closing this as HDDS-4089 planning to fix this issue to make ACL commands work with the external authorizer.

Hi @bharatviswa504 ,  I think this change has nothing to do with ACL commands. Is it something I don't understand?

Closing this as HDDS-4089 planning to fix this issue to make ACL commands work with the external authorizer.

Hi @bharatviswa504 , I think this change has nothing to do with ACL commands. Is it something I don't understand?

@captainzmc I think you can ignore it, the comment was intended for another PR: https://github.com/apache/hadoop-ozone/pull/1271#issuecomment-679274161

Sorry, @captainzmc I have posted the comment on the wrong PR. I was trying to search where I have posted, not able to figure out. You can ignore my comment.

Hi @ChenSammi @adoroszlai , I had added the initialization and change the old volume quota default value to -1 when OM starts. Could you help review this PR again?

Thanks for Sammi's review, fixed review issues.  @ChenSammi Could you help take another look?

+1.  After a thoroughly thinking, we choose a conservative way.
Thanks @captainzmc for the contribution and @adoroszlai for the review.


PSG volume stairsteps due to repeating values

There are various reports on the Discord as to the volume not being quite right on VERA PSG and it would appear to be related to this table:
https://github.com/X16Community/vera-module/blob/70a03e006b7445ec74bf9982b0cc80cfb4e3192b/fpga/source/audio/psg.v#L47
Namely, it contains repeating values (e.g. d4-d10 on the left hand side all map to d2). This causes lower volumes to be very imprecise making it difficult to find a good value for a voice and impacts things like envelopes, ADSRs, slides, etc.
Multiple solutions were proposed on the Discord, such as converting the output to linear, leaving it as is, or simple reducing the volume range to remove the duplicates (e.g. instead of 0-63, 0-39). The latter preserves the log but smooths out the transitions and saves LUTs.
I favor the reduced range, which would be something like:
        6'd0:  cur_volume_log = 6'd0;
        6'd1:  cur_volume_log = 6'd1;
        6'd2: cur_volume_log = 6'd2;
        6'd3: cur_volume_log = 6'd3;
        6'd4: cur_volume_log = 6'd4;
        6'd5: cur_volume_log = 6'd5;
        6'd6: cur_volume_log = 6'd6;
        6'd7: cur_volume_log = 6'd7;
        6'd8: cur_volume_log = 6'd8;
        6'd9: cur_volume_log = 6'd9;
        6'd10: cur_volume_log = 6'd10;
        6'd11: cur_volume_log = 6'd11;
        6'd12: cur_volume_log = 6'd12;
        6'd13: cur_volume_log = 6'd13;
        6'd14: cur_volume_log = 6'd14;
        6'd15: cur_volume_log = 6'd15;
        6'd16: cur_volume_log = 6'd16;
        6'd17: cur_volume_log = 6'd17;
        6'd18: cur_volume_log = 6'd18;
        6'd19: cur_volume_log = 6'd19;
        6'd20: cur_volume_log = 6'd21;
        6'd21: cur_volume_log = 6'd22;
        6'd22: cur_volume_log = 6'd23;
        6'd23: cur_volume_log = 6'd25;
        6'd24: cur_volume_log = 6'd26;
        6'd25: cur_volume_log = 6'd28;
        6'd26: cur_volume_log = 6'd29;
        6'd27: cur_volume_log = 6'd31;
        6'd28: cur_volume_log = 6'd33;
        6'd29: cur_volume_log = 6'd35;
        6'd30: cur_volume_log = 6'd37;
        6'd31: cur_volume_log = 6'd39;
        6'd32: cur_volume_log = 6'd42;
        6'd33: cur_volume_log = 6'd44;
        6'd34: cur_volume_log = 6'd47;
        6'd35: cur_volume_log = 6'd50;
        6'd36: cur_volume_log = 6'd52;
        6'd37: cur_volume_log = 6'd56;
        6'd38: cur_volume_log = 6'd59;
        6'd39: cur_volume_log = 6'd63;

The discussion on whether to fix this or not was ongoing and passionate (it starts here: https://discord.com/channels/547559626024157184/549247986820186153/1152646594240467106) but regardless, this issue is merely to track the issue. If the devs feel like it's not worth fixing for any particular reason, at least there is history.
IF it's decided not to fix, I highly recommend the documentation of VERA reflects this to avoid confusion in the future. And/or perhaps a ROM LUT that maps 0-39 to deduplicate volumes (if nothing is done, this is what I'll be doing in my own software).

Managed to render out a wave file, albeit from x16emu rather than the real hardware, which shows the current solution rather nicely:

First, the jump from 0 to min volume is rather high relative to the highest jumps towards max volume. The regions where the mapping results in the same volume can also be seen, showing up as a volume stall for what should be a continual increase in volume (this is from DreamTracker using the 0441 command, which just increases the volume by 1 per row.
The min volume likely can't be fixed as that's the step from 0 volume to the first volume (6'd1:  cur_volume_log = 6'd1;) though removing the stalls would result in a more linear curve.

I've tried increasing the table's resolution. But with only 200 LUTs remaining now from FX Update. It's deemed too expensive. Another idea I have is to decrease the table size by exploiting bit-shifts. But this requires the volume steps per half to be in power of 2 and VERA currently isn't like that as it is 12 steps per half. At least this will break compatibility less than the full linear method.

Also, if the curve is changed to 8 steps per half, it would effectively match Yamaha FM chips.

Also, if the curve is changed to 8 steps per half, it would effectively match Yamaha FM chips.

Talk about going full circle!
Turns out Yamaha already had it thought out huh?
Went a long way discovering, eventually behave the same as YMFM....

useless idea i have: instead of using a lut rom, have a rough computation of a log curve.
for a curve of a power-of-2 values per halving this is trivial, just shift right. For a 12-per value... not so much.
but i think i found a way.
note: first 16 values skip this calculation and go straight through.
note2: this is absolutely not any language in particular!
// Too lazy to figure out boolean formulas for these, sorry!
// I don't think it matters much for an LUT-based FPGA, however.
2b* ShfTable = {?,?,?,?,0,0,0,0,1,1,1,1,2,2,2,2}
2b* ThrTable = {?,?,?,?,0,1,2,0,1,2,0,1,2,0,1,2}
4b* LogTable = {1,2,3,4,5,7,8,9,11,12,14,15,?,?,?,?}

2b Shifts = ShfTable[i.[2~5]]
2b Third  = ThrTable[i.[2~5]]
5b Base   = LogTable[(Third << 2) | i.[1~2]] | b1_0000
// TODO: Is a shift expensive?
8b Output = LShift(Base, Shifts)

now my question is, how many fpga luts does that lut rom take? and how much would it take if it was 8 bits?
also have a random spreadsheet: curvetest.ods

I like your idea of using mod3 table and tried implementing it. It only increases LE count by about 64!  🥳
Alright, I'll make a PR of this and see the real increase after the whole thing is synthesized and routed on an actual hardware.

Wait, this is happening now?
Good to see changes!
But could you provide a spreadsheet that have old value vs new value and the real dB? So one could manually patch up their works?

See https://github.com/X16Community/vera-module/pull/22, the value is barely changed enough to be compatible

#22 merged so closing this out


vsm4r pseudocode looks garbled

I think the pseudocode for vsm4r is garbled, specifically the "B" term expressions for 2nd and 3rd rounds. Should they be this:
second round:
B = (X2 ^ X3 ^ Y0 ^ rk1)
third round:
B = (X3 ^ Y0 ^ Y1 ^ rk2)
I'm not an expert, so I'm guessing here. Can you please check?
Thanks.

There also seem to be mistakes in the pseudocode for vsm3c:

register vd is not in the function parameter list, but used in the function body;
a variable "round" is used - should this be "rnds"?
a function "FF" is used - should this be "FF_j"?

Is there validated code somewhere that I can refer to?
Thanks.

Rivos (cc @kdockser ) has published a public pre-version of their spike fork extended with vector-crypto support: https://github.com/rivosinc/riscv-isa-sim/tree/zvk-vector-crypto

Fixed these errors in vsm4r and vsm3c.

@kdockser, can you please provide an example command line that should be used to enable Zvk instructions in your spike fork? I'm getting an illegal instruction trap on every one.
Thanks.


DataContractJsonSerializer and oDataV4 from with CRM Plugin

Hi Scott,
I want to use the DataContactJsonSerializer from within CRM Plugin, where I need to serialize a payload from a web service that exposes OData V4. I am having difficulty serializing the payload.
How do I go about serializing without bringing in dependency to  NewtonSoft Json?
Thanks

Here is some example code:
public static string SerialiseEntityToJSON(this Entity entity)
{
    var setting = new DataContractJsonSerializerSettings()
    {
        UseSimpleDictionaryFormat = true,
        KnownTypes = new Type[] {typeof(ActivityParty),typeof(spark_Attachment)}
    };
    var entityTyped = entity.ToEntity<Entity>();
    var serializer = new DataContractJsonSerializer(typeof(Entity), setting);
    using (var ms = new MemoryStream())
    {
        serializer.WriteObject(ms, entityTyped);
        ms.Position = 0;
        var sr = new StreamReader(ms);
        return sr.ReadToEnd();
    }
}

I have used the same pattern for serializing but the serialized but returned is null. I am trying to serialize OData v4 response

Here is an example of a response I am trying to serialize using the DataContractJsonSerializer
{
@odata.context: "http://services.odata.org/V4/(S(tdsqxrjntoi2ta4i1nqyrtm3))/TripPinServiceRW/$metadata",
value: [
{
name: "Photos",
kind: "EntitySet",
url: "Photos"
},
{
name: "People",
kind: "EntitySet",
url: "People"
},
{
name: "Airlines",
kind: "EntitySet",
url: "Airlines"
},
{
name: "Airports",
kind: "EntitySet",
url: "Airports"
},
{
name: "Me",
kind: "Singleton",
url: "Me"
},
{
name: "GetNearestAirport",
kind: "FunctionImport",
url: "GetNearestAirport"
}
]
}


update proxy to raftstore-proxy-6.2

What problem does this PR solve?
Issue Number: ref #4982
Problem Summary:
update proxy to origin:raftstore-proxy-6.2
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/cc @hehechen @jiaqizho

/merge

/merge

/run-all-tests

/run-unit-test

/run-unit-test


HTTP 401 when getting photos in sparklr2 sample application

I've been trying out the oauth2 sample apps. Everything is working fine for the most part - I can use Tonr to retrieve and display the photos for user marissa via oauth login to sparklr2. However, on sparklr2 itself, I can't see any photos even after logging in, with an error "http://localhost:8080/sparklr2/photos  [HTTP/1.1 401 Unauthorized 2ms]" in the browser console on /index.jsp. I also get a 401 if I try to go directly to /photos, with this xml error:
<oauth>
<error_description>
An Authentication object was not found in the SecurityContext
</error_description>
<error>unauthorized</error>
</oauth>

Same happens for user paul. Any idea what's going on?
Here is part of the logs from around the error:
sparklr2 10:30:08.671 [DEBUG] FilterChainProxy - /photos?callback=pictureDisplay&format=json at position 4 of 10 in additional filter chain; firing Filter: 'LogoutFilter'
sparklr2 10:30:08.671 [DEBUG] AntPathRequestMatcher - Checking match of request : '/photos'; against '/logout'
sparklr2 10:30:08.671 [DEBUG] FilterChainProxy - /photos?callback=pictureDisplay&format=json at position 5 of 10 in additional filter chain; firing Filter: 'OAuth2AuthenticationProcessingFilter'
sparklr2 10:30:08.671 [DEBUG] BearerTokenExtractor - Token not found in headers. Trying request parameters.
sparklr2 10:30:08.671 [DEBUG] BearerTokenExtractor - Token not found in request parameters.  Not an OAuth2 request.
sparklr2 10:30:08.671 [DEBUG] OAuth2AuthenticationProcessingFilter - No token in request, will continue chain.
sparklr2 10:30:08.671 [DEBUG] FilterChainProxy - /photos?callback=pictureDisplay&format=json at position 6 of 10 in additional filter chain; firing Filter: 'RequestCacheAwareFilter'
sparklr2 10:30:08.671 [DEBUG] FilterChainProxy - /photos?callback=pictureDisplay&format=json at position 7 of 10 in additional filter chain; firing Filter: 'SecurityContextHolderAwareRequestFilter'
sparklr2 10:30:08.671 [DEBUG] FilterChainProxy - /photos?callback=pictureDisplay&format=json at position 8 of 10 in additional filter chain; firing Filter: 'SessionManagementFilter'
sparklr2 10:30:08.671 [DEBUG] FilterChainProxy - /photos?callback=pictureDisplay&format=json at position 9 of 10 in additional filter chain; firing Filter: 'ExceptionTranslationFilter'
sparklr2 10:30:08.671 [DEBUG] FilterChainProxy - /photos?callback=pictureDisplay&format=json at position 10 of 10 in additional filter chain; firing Filter: 'FilterSecurityInterceptor'
sparklr2 10:30:08.672 [DEBUG] AntPathRequestMatcher - Checking match of request : '/photos'; against '/me'
sparklr2 10:30:08.672 [DEBUG] AntPathRequestMatcher - Checking match of request : '/photos'; against '/photos'
sparklr2 10:30:08.672 [DEBUG] FilterSecurityInterceptor - Secure object: FilterInvocation: URL: /photos?callback=pictureDisplay&format=json; Attributes: [#oauth2.throwOnError(#oauth2.hasScope('read') or (!#oauth2.isOAuth() and hasRole('ROLE_USER')))]
sparklr2 10:30:08.672 [DEBUG] ExceptionTranslationFilter - Authentication exception occurred; redirecting to authentication entry point <org.springframework.security.authentication.AuthenticationCredentialsNotFoundException: An Authentication object was not found in the SecurityContext>org.springframework.security.authentication.AuthenticationCredentialsNotFoundException: An Authentication object was not found in the SecurityContext
	at org.springframework.security.access.intercept.AbstractSecurityInterceptor.credentialsNotFound(AbstractSecurityInterceptor.java:339)
	at org.springframework.security.access.intercept.AbstractSecurityInterceptor.beforeInvocation(AbstractSecurityInterceptor.java:198)

Fixed in commit 3c18f07. Thanks.


Merge 2.9.0 to master

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
No issue
✅ Checklist

[ ] Github issue details are up to date for people to QA.
[ ] I have tested all my changes.

🕵♂ Notes for Code Reviewer
Merge everything from 2.9.0 to master
👯♀ Paired with
"nobody"

@gguij004  can you run this on iphone and comment back pls.

@RaulUrtecho  thank you


Organizations' contact person email can be a user not registered in the platform

Prerequisites

[X] I've searched for existing issues

Describe the bug
This is a follow up issue from #2050, where we are setting preferred locale for notifications to be contact person's locale. Because contact person's email can be an email that doesn't belong to a user in the platform, we can't fetch their locale, so emails we send out can be in language they don't use.
To Reproduce
Steps to reproduce the behavior (after #2050 gets merged):

Create an organization or regulated organization
Edit the contact person information from the organization's page, use email that doesn't belong to a user from the platform
Log out from the account and sign in with the platform admin account
Go to account manage section, and suspend the organization's account
Check the email sent to the contact person's email, notice it's in the language of the admin panel when the suspension was happening

Expected behavior
Email should sent in contact person's working language.
Screenshots
No response
Details
No response
Additional context
No response

We may need to add settings for contact language. @cherylhjli do you have thoughts on this?

In talking to @cherylhjli about this today, it seems that it would make more sense to not send system e-mails to the contact person. Rather these should only go to the org admins/memebers as necessary. The contact email is really for external communication and appears on the public page.

@cherylhjli I was looking into this. The system is actually setup to send all of the internal notifications to an orgs contact person. In talking about this yesterday we were thinking that the contact person mentioned for the org was just for external communications. Is that correct? Does that mean that all org admins should get the emails instead?

@jobara Yes I think yesterday I was under the impression that the contact person that someone can add in the org's profile page is just for external communications. I think it would help to know what all the systems emails are for - if it's for things like verifying an email address, then it makes sense for org admins to get that email. But if an agreement or estimate has been approved, then the project contact would make more sense. Maybe we can discuss in January.

It looks like for projects and organizations the person to be notified is set through routeNotificationForMail and is currently set to the contact person. I'm not sure if this can take in multiple e-mail addresses or if instead at the site that notify() is called, we'd have to loop through the admins. If we want to have different cases for who to notify we may have to do it at the place where notify() is called.

In convo with @jobara
Cases:

Notifying about being invited as a community organization to an FRO engagement:
Notifying about being removed as a community organization to an FRO engagement:
Notifying about being invited as a community connector to an engagement:
Org is notified that the community connector accepted their invite:
Engagement related - an individual signs up for your engagement - open call
Engagement related - an individual leaves for your engagement - open call
Engagement related - an individual accepts the invitation to join the engagement - CC
Engagement related - an individual declines the invitation to join the engagement - CC
When you invite a CC as an organization successfully
When an estimate is returned for a project
When the agreement is received for a project

@cherylhjli just noticing that the project related emails go to the project contact person. However, again this can be for an email address that isn't registered as a user in the system and we don't know what language to send it in, so it will always send in English.

In the matrix channel discussion, @cherylhjli agreed that we could add a preferred language option. If possible we could pre-select the value set in the "What language(s) does your organization work in?" if there is only a single one picked.

I had a follow up conversation with @cherylhjli in the matrix channel. We've decided for now to send the org emails to the contact person after all and to add a preferred contact language option for them.


Fix createrawrequesttx

Don't merge yet. Redemption test failing locally even though I didn't change anything relevant.

Ok good to go

rebased


Corrections to bulk.md

Description
The description on how to use the API was incorrect. I had updated it with the correct implementation.
Issues Resolved
#616
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[x] Linter check was successfull - yarn run lint doesn't show any errors
[x] Commits are signed per the DCO using --signoff
[x] Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Do you think you could add a working sample into samples like https://github.com/opensearch-project/opensearch-py/tree/main/samples as part of this PR?

That's entirely different from guides. The equivalent on Python client is this one https://github.com/opensearch-project/opensearch-py/blob/main/guides/bulk.md

Do you think you could add a working sample into samples like https://github.com/opensearch-project/opensearch-py/tree/main/samples as part of this PR?

That's entirely different from guides. The equivalent on Python client is this one https://github.com/opensearch-project/opensearch-py/blob/main/guides/bulk.md

Should I try to update that bulk.md file to be closer in line to the ruby version ?

You're welcome to. Or you can also create an issue in the Python Repo.

sample

I think we need this to convince ourselves that the documentation is now correct.

Hey @dblock I realized that I had created this PR from main on my fork. I want to move it to a feature branch on my fork. How can I do so?
I think syncing main from my fork accidently closed this PR. How can I reopen it?

@AbhinavGarg90 You'd have to recreate the PR because the source and target branches are locked. However, for now, you can simply rebase your main branch onto the upstream/main branch, then force push, if you want the updates from upstream/main.

The guide has been reworked.


Batch Update: can I update more than one property with a single Update?

The wiki example is:
ctx.Users.Where(x => x.LastLoginDate < DateTime.Now.AddYears(-2))
         .Update(x => new User() { IsSoftDeleted = 1 });

If I had another column to update, for example "LastModifiedDate", is it possibile to write something like this?
ctx.Users.Where(x => x.LastLoginDate < DateTime.Now.AddYears(-2))
         .Update(x => new User() { IsSoftDeleted = 1, LastModifiedDate = DateTime.Now() });

I tried a similar code but I received "object reference null" exception.

Hello @lucaritossa ,
I'm sorry, I guess we made a BIG mistake in the wiki.
DateTime function such as DateTime.Now.AddYears(-2) cannot be used in LINQ.
By example, this following LINQ doesn't work (and doesn't use our library)
var list = ctx.EntitySimples.Where(x => x.LastLoginDate < DateTime.Now.AddYears(-2)).ToList();

The Wiki has been updated.
The following example should work
var date = DateTime.Now.AddYears(-2);
ctx.Users.Where(x => x.LastLoginDate < date)
         .Update(x => new User() { IsSoftDeleted = 1, LastModifiedDate = DateTime.Now() });

Let me know if that now correctly work.
Best Regards,
Jonathan

Help us to keep this library free: Donate

I'm happy we've found a bug in WIKI 😄  but my error appears a little bit different.
I'm trying to prepare a PoC for myself...
BTW my question is to be considered as replied because I have successfully updated more than one property with one Update action.
Thank you for your fast reply.
LR


"Invalid callv target #2" error if line before CO_BEGIN doesn't terminate with a semicolon

show_debug_message("Remove the semicolon on this line and die");
(function(){})();

Ugh this fix broke
return CO_BEGIN
//etc.
CO_END

Needs retesting in 2.3.7+

I think this is fixed now... deactivated the workaround for v0.5.0


Kestrel tries to use Kerberos

@Ninja4Code I'm working on you contribution.
Create Razor web app:
dotnet new razor -o WebNeg -au Individual
Add  the following AddAuthentication, AddAuthorization
using Microsoft.AspNetCore.Authentication.Negotiate;

var builder = WebApplication.CreateBuilder(args);
builder.Services.AddAuthentication(NegotiateDefaults.AuthenticationScheme)
   .AddNegotiate();
builder.Services.AddAuthorization(options =>
{
    options.FallbackPolicy = options.DefaultPolicy;
});

Run app and use F12 browsers tools, network tab.
But all I see is:

contributes to #28365
The default Negotiate package on Kestrel to use Kerberos, which is a more secure and peformant authentication scheme than NTLM.
The following snippet, from Program.cs, shows the Negotiate request:
using Microsoft.AspNetCore.Authentication.Negotiate;

var builder = WebApplication.CreateBuilder(args);
builder.Services.AddAuthentication(NegotiateDefaults.AuthenticationScheme)
   .AddNegotiate();
builder.Services.AddAuthorization(options =>
{
    options.FallbackPolicy = options.DefaultPolicy;
});

var app = builder.Build();

app.MapGet("/", () => "Hello World!");

app.Run();

NegotiateDefaults.AuthenticationScheme uses Kerberos by default.  The FallbackPolicy uses the DefaultPolicy meaning if Kerberos not available, Kestrel will fall back to NTLM.
Kerberos is known as the Negotiate AuthenticationType, whereas NTLM is known as the NTLM AuthenticationType.  This can be demonstrated by viewing a request in Fiddler where the WWW-Authenticate header contain either Negotiate or NTLM.
IIS and IISExpress support Kerberos and NTLM; however, Kestrel in disallows NTLM connections.
Steps to Reproduce:

Create an ASP.NET Core React app with dotnet new react.
Install the Microsoft.AspNetCore.Authentication.Negotiate package.
Add the preceding code for authentication and authorization.
Ensure authentication and authorization are in the pipeline in the correct order:

   app.UseRouting();
   app.UseAuthentication();
   app.UseAuthorization();

Run the app using Kestrel.
When navigating to the site, you may either see a sign-in prompt or 401 status code.
When analyzing the request in Fiddler, you notice a WWW-Authenticate: NTLM header.

Troubleshooting and Resolution
You'll need to check to see if the computer running the app has a valid service principal name (SPN) registration with the HTTP service.  These same steps can be run locally, on a VM, server or within a Docker container host.

Verify the computer has a valid SPN.
Run  setspn -L  to list all of the services your computer has an SPN registration for.
setspn -L <machinename>
Machine name is often synonymous with computer name.  If you don’t know your computer         name, type “$env:computername” in PowerShell.  Machine name is also a valid account name in Active Directory.  So even if your FQDN machine name is myhost1.example.com you'll use myhost1 in this command.
setspn -L myhost1
Readout is displayed.  If you don't see any service named http or HTTP then you don't have a valid SPN for Negotiate.
Add your machine name account to the http service.
Run the setspn -S command TWICE, once for the machine short name and once for the FQDN.

  setspn -S http/myhost1
  setspn -S http/myhost1.example.com

If successful you'll see a message that the service principal name was updated, otherwise and error is displayed.
Run setspn -L <machinename> command again to verify that the registration was successfully updated.
You should see two listings for http with your machine name as well as the FQDN.
Exit from the command line and start the app.
You should be able to navigate within the web site without sign-in prompts or 401 errors.
You can confirm this by analyzing the request in Fiddler, noticing the WWW-Authenticate: Negotiate header.
NOTE: In order to update setspn successfully, you'll need to run the command either with an elevated command prompt with an account with either Domain Admin or Account Operators permissions.

Document Details
⚠ don't edit this section. It's required for learn.microsoft.com ➟ GitHub issue linking.

ID: f22dcddb-0c25-be1a-9a02-9e71dce86bdb
Version Independent ID: 3e0e12c2-e544-5655-e001-d2ec180b11a8
Content: Kestrel web server implementation in ASP.NET Core
Content Source: aspnetcore/fundamentals/servers/kestrel.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub sign-in: @Rick-Anderson
Microsoft Alias: riande

@Ninja4Code can you review my question above, all I see is ....
Does setspn work on Azure AD? I'm not in a windows domain.

Rick,
Regarding your question about Azure, while I haven't tested this in Azure, the setspn will work in any Active Directory environment.  So I am confident it would work with Azure AD.
I would change the setspn section to this:
For a normal Windows server environment, you need to register the service principal name (SPN) with the Windows server machine with the account that is going to run the dotnet process for Kestrel:
setspn -S http/myhost1.example.com <accountname>
setspn -S http/myhost1 <accountname>

For a Windows Docker container environment, you will need to create a GMSA account on your domain and add it to the container host machine.  After you have done that, you need to register the service principal name (SPN) with the container host machine with the GMSA account.  I have a different set of instructions to set up the GMSA account if needed.
setspn -S http/myhost1.example.com GMSA-Account
setspn -S http/myhost1 GMSA-Account

Will I be listed as a contributor?

Will I be listed as a contributor?

No, you'll be listed as the author.

Ok, here's the revised text:
Troubleshooting and Resolution
You will need to check to see if the computer running the application has a valid service principal name (SPN) registration with the HTTP service.  These same steps can be run locally, on a VM, server or within a Docker container host.
Kerberos on Kestrel is considered a user-defined authentication system.  Therefore, the SPN needs to be registered to a user account, not a machine account.
Steps for non-container environments

The first step is to verify whether the account running dotnet.exe has a valid SPN on the container host.

Run the setspn -L command to list all of the services your computer has an SPN registration for.

setspn -L <dotnet-account>
setspn -L MySiteAccount

NOTE: In this example, MySiteAccount needs to be an Active Directory domain account.  This account is not used to run the setspn command, it is the account the SPN will be registered under.  You will use a privileged account to run the setspn command.

You will see a readout.  If you do not see any service named http or HTTP attached to the machine running the ASP.NET Core site then you do not have a valid SPN for Negotiate. We will assume the name of the machine running the site is myhost1.example.com.

Registered ServicePrincipalNames for CN=MySiteAccount, DC=com, DC=example:

HOST/myhost1.example.com

Above you see that MySiteAccount, does not have an entry attached to the http service for myhost1.example.com, which is the  server or computer the website will run on.  Since you do not see a valid registration, you need to add your account to the http service for the server myhost1.example.com

Run the setspn -S command TWICE once for the container host common  name and once for the FQDN.

NOTE: In order to update setspn successfully, you will need to run the command either with an elevated command prompt with an account with either Domain Admin or Account Operators permissions.
Syntax:
setspn -S http/<server with FQDN> <dotnet-Account>
setspn -S http/myhost1.example.com MySiteAccount
setspn -S http/myhost1 MySiteAccount

If successful you will see a message that the service principal name was updated.  If it fails, you will see an error.
Run the setspn -L  command again to verify that the registration was successfully updated.

setspn -L MySiteAccount

You should see two listings for http with your account listed for the container host.
Now exit from the command line and fire up the application again in a web browser.
You should be able to successfully able to navigate within the web site without login prompts or 401 errors.
You can confirm this by analyzing the request in Fiddler, noticing the WWW-Authenticate: Negotiate header.

For a Docker container you will need to check whether the Group Managed Service Account (GMSA)  account you set up Kerberos has a valid service principal name (SPN) registered with the container host for the http service class.  For this example, the assumption is that you have have already created a GMSA account, named MyGMSA.
Steps for Windows container environments

The first step is to verify whether the GMSA account has a valid SPN on the container host.
Run the setspn -L command to list all of the services your computer has an SPN registration for.

setspn -L <GMSA-Account>
setspn -L MyGMSA

You will see a readout.  If you do not see any service named http or HTTP attached to the container host then you do not have a valid SPN for Negotiate.

Registered ServicePrincipalNames for CN=MyGMSA,CN=Managed Service Accounts, DC=com, DC=example:

HOST/myhost1.example.com

Above you see that MyGMSA, the GMSA account does not have an entry attached to the http service for myhost1.example.com, which is the  container host the Docker container will run on.  Since you do not see a valid registration, you need to add your GMSA account to the http service for the container host machine myhost1.example.com

Run the setspn -S command TWICE once for the container host common  name and once for the FQDN.

NOTE: In order to update setspn successfully, you will need to run the command either with an elevated command prompt with an account with either Domain Admin or Account Operators permissions.
Syntax:
setspn -S http/<containerhost with FQDN> <GMSA-Account>
setspn -S http/myhost1.example.com MyGMSA
setspn -S http/myhost1 MyGMSA

If successful you will see a message that the service principal name was updated.  If it fails, you will see an error.
Run the setspn -L  command again to verify that the registration was successfully updated.

setspn -L MyGMSA

You should see two listings for http with your account listed for the container host.
Now exit from the command line and fire up the application again in a web browser.
You should be able to successfully able to navigate within the web site without login prompts or 401 errors.
You can confirm this by analyzing the request in Fiddler, noticing the WWW-Authenticate: Negotiate header.

@Ninja4Code  can you edit https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/includes/kerberos.md and replace the text in that file with your instructions?

Yes

From: Rick Anderson @.>
Sent: Thursday, February 23, 2023 7:20 PM
To: dotnet/AspNetCore.Docs @.>
Cc: Charles Owen @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Kestrel tries to use Kerberos (Issue #28432)
@Ninja4Codehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNinja4Code&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948610900626|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qHVg2cZbG3krKU%2BD9q60HkBDVAc5EbYuXebFcanYiQQ%3D&reserved=0 can you edit https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/includes/kerberos.mdhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fblob%2Fmain%2Faspnetcore%2Fincludes%2Fkerberos.md&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948610900626|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=r0pX%2BKnhtn%2Bl7S53tQn0mL19QWQTHQFBOJQJ3ywW0X8%3D&reserved=0 and replace the text in that file with your instructions?
[image]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F3605364%2F221061226-24993bb9-4c84-4e9a-bc8b-52577f53cd3b.png&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948611056866|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=rWs4tI1%2BpatnHCPe0QfyOT1pgfUfvRb%2F0KoOisHWEsY%3D&reserved=0
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fissues%2F28432%23issuecomment-1442611813&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948611056866|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tH4Vk56h3mBZcQ2ijmyGICJDVf0aGS4EddaHab3eEYk%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACYCAVXBLFHMSYJP2BOXJCLWY75GVANCNFSM6AAAAAAU65VLWY&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948611056866|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=5HQNf7%2FFD53I7vZIj9BOoBVYJBobI3ZwplPcvCm6xXs%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Just remembered, I need to add something about the docker run statement because it needs to have the security descriptor of the GMSA account for it to work in Kerberos.  It's just an additional line.

From: Rick Anderson @.>
Sent: Thursday, February 23, 2023 7:20 PM
To: dotnet/AspNetCore.Docs @.>
Cc: Charles Owen @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Kestrel tries to use Kerberos (Issue #28432)
@Ninja4Codehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNinja4Code&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948610900626|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qHVg2cZbG3krKU%2BD9q60HkBDVAc5EbYuXebFcanYiQQ%3D&reserved=0 can you edit https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/includes/kerberos.mdhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fblob%2Fmain%2Faspnetcore%2Fincludes%2Fkerberos.md&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948610900626|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=r0pX%2BKnhtn%2Bl7S53tQn0mL19QWQTHQFBOJQJ3ywW0X8%3D&reserved=0 and replace the text in that file with your instructions?
[image]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F3605364%2F221061226-24993bb9-4c84-4e9a-bc8b-52577f53cd3b.png&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948611056866|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=rWs4tI1%2BpatnHCPe0QfyOT1pgfUfvRb%2F0KoOisHWEsY%3D&reserved=0
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fissues%2F28432%23issuecomment-1442611813&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948611056866|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tH4Vk56h3mBZcQ2ijmyGICJDVf0aGS4EddaHab3eEYk%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACYCAVXBLFHMSYJP2BOXJCLWY75GVANCNFSM6AAAAAAU65VLWY&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948611056866|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=5HQNf7%2FFD53I7vZIj9BOoBVYJBobI3ZwplPcvCm6xXs%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

I have one last edit to make.  Do I just do the same replace as before?

From: Rick Anderson @.>
Sent: Thursday, February 23, 2023 7:20 PM
To: dotnet/AspNetCore.Docs @.>
Cc: Charles Owen @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Kestrel tries to use Kerberos (Issue #28432)
@Ninja4Codehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNinja4Code&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948610900626|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qHVg2cZbG3krKU%2BD9q60HkBDVAc5EbYuXebFcanYiQQ%3D&reserved=0 can you edit https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/includes/kerberos.mdhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fblob%2Fmain%2Faspnetcore%2Fincludes%2Fkerberos.md&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948610900626|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=r0pX%2BKnhtn%2Bl7S53tQn0mL19QWQTHQFBOJQJ3ywW0X8%3D&reserved=0 and replace the text in that file with your instructions?
[image]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F3605364%2F221061226-24993bb9-4c84-4e9a-bc8b-52577f53cd3b.png&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948611056866|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=rWs4tI1%2BpatnHCPe0QfyOT1pgfUfvRb%2F0KoOisHWEsY%3D&reserved=0
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fissues%2F28432%23issuecomment-1442611813&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948611056866|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tH4Vk56h3mBZcQ2ijmyGICJDVf0aGS4EddaHab3eEYk%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACYCAVXBLFHMSYJP2BOXJCLWY75GVANCNFSM6AAAAAAU65VLWY&data=05|01||8a529c58508b4a2fdaf108db15fd00fb|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638127948611056866|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=5HQNf7%2FFD53I7vZIj9BOoBVYJBobI3ZwplPcvCm6xXs%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

I have one last edit to make.  Do I just do the same replace as before?

Yes, and we can both edit it after you make a PR.

I submitted what should be my final edits.  I included some references to two other Microsoft articles about creating the gMSA account and a docker run statement that includes this credential spec file referring to the gMSA account that was created.  So my documentation is mostly coalescing what exists in disparate places.

From: Rick Anderson @.>
Sent: Friday, February 24, 2023 7:59 PM
To: dotnet/AspNetCore.Docs @.>
Cc: Charles Owen @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Kestrel tries to use Kerberos (Issue #28432)
I have one last edit to make. Do I just do the same replace as before?
Yes, and we can both edit it after you make a PR.
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fissues%2F28432%23issuecomment-1444837019&data=05|01||db81bc1592bd4db24b9808db16cb944a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638128835854275238|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=07AxJoeN3icLzOkNmCebd%2F1QL8RYH%2Bva%2BRwUisZXL5U%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACYCAVSV6WSNZFWWCXBYHJDWZFKP3ANCNFSM6AAAAAAU65VLWY&data=05|01||db81bc1592bd4db24b9808db16cb944a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638128835854275238|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=4342Sw5RHhMeS5vyeC6d70JVOI9CZaVBZbAHSAAwcnw%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@Ninja4Code  where did you submit them?
@Ninja4Code  can you edit https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/includes/kerberos.md and replace the text in that file with your instructions?

I submitted there as you requested.

From: Rick Anderson @.>
Sent: Saturday, February 25, 2023 1:04 PM
To: dotnet/AspNetCore.Docs @.>
Cc: Charles Owen @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Kestrel tries to use Kerberos (Issue #28432)
@Ninja4Codehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNinja4Code&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056167100|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=zJ3p5e1pDMwxoZ76lc7Ih8YKKaa5ypDYUUQV3C4ievU%3D&reserved=0 where did you submit them?
@Ninja4Codehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNinja4Code&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056167100|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=zJ3p5e1pDMwxoZ76lc7Ih8YKKaa5ypDYUUQV3C4ievU%3D&reserved=0 can you edit https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/includes/kerberos.mdhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fblob%2Fmain%2Faspnetcore%2Fincludes%2Fkerberos.md&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056167100|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=EeCduTZ71c0458ohHmOfNS490pQwp%2B67VmB57AoHzrk%3D&reserved=0 and replace the text in that file with your instructions?
[image]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F3605364%2F221061226-24993bb9-4c84-4e9a-bc8b-52577f53cd3b.png&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056323339|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=hspjEv13pBJgi8lblNOKeu0CJlkQAoT9zXvU2tFbD%2F4%3D&reserved=0
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fissues%2F28432%23issuecomment-1445171520&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056323339|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tJkqCigZTj%2FJ4%2BxozQzFqF%2B4y2KARbYSgCjEFRC5F1k%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACYCAVWGO33F3IXLWE45GDTWZJCUVANCNFSM6AAAAAAU65VLWY&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056323339|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=L7jo3pg20U3bynOctvK%2FBEZZZABmo3G5Zjjfw60%2FQjk%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

I submitted there as you requested.

I don't see a PR. Did you create a PR? If so, what's the PR #?
BTW, rather than answer questions with email, it's better to follow the link to the issue and respond in the issue.

Pull Request? No, will do though.  Sorry about that.

From: Rick Anderson @.>
Sent: Sunday, February 26, 2023 1:27 AM
To: dotnet/AspNetCore.Docs @.>
Cc: Charles Owen @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Kestrel tries to use Kerberos (Issue #28432)
I submitted there as you requested.
I don't see a PR. Did you create a PR? If so, what's the PR #?
BTW, rather than answer questions with email, it's better to follow the link to the issue and respond in the issue.
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fissues%2F28432%23issuecomment-1445279226&data=05|01||e07d55ae130b4e96572f08db17c294ef|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129896727427457|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=GHrCHAVrLDirQ1WPFCBDdZzTdCms0xoxBhpkMpLKUFo%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACYCAVWZWTPAMICQYDUDCSLWZLZWJANCNFSM6AAAAAAU65VLWY&data=05|01||e07d55ae130b4e96572f08db17c294ef|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129896727427457|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=oMTaA%2Bu4EMTTxllKB9O%2BuhK7BmgU8tki5U63nje64Mo%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Pull request should be there now.

From: Rick Anderson @.>
Sent: Sunday, February 26, 2023 1:27 AM
To: dotnet/AspNetCore.Docs @.>
Cc: Charles Owen @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Kestrel tries to use Kerberos (Issue #28432)
I submitted there as you requested.
I don't see a PR. Did you create a PR? If so, what's the PR #?
BTW, rather than answer questions with email, it's better to follow the link to the issue and respond in the issue.
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fissues%2F28432%23issuecomment-1445279226&data=05|01||e07d55ae130b4e96572f08db17c294ef|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129896727427457|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=GHrCHAVrLDirQ1WPFCBDdZzTdCms0xoxBhpkMpLKUFo%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACYCAVWZWTPAMICQYDUDCSLWZLZWJANCNFSM6AAAAAAU65VLWY&data=05|01||e07d55ae130b4e96572f08db17c294ef|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129896727427457|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=oMTaA%2Bu4EMTTxllKB9O%2BuhK7BmgU8tki5U63nje64Mo%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

#28502 got it thanks.

@Ninja4Code  You'll need to sign the agreement.

Please let me know when and where this gets published.

From: Rick Anderson @.>
Sent: Saturday, February 25, 2023 1:04 PM
To: dotnet/AspNetCore.Docs @.>
Cc: Charles Owen @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Kestrel tries to use Kerberos (Issue #28432)
@Ninja4Codehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNinja4Code&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056167100|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=zJ3p5e1pDMwxoZ76lc7Ih8YKKaa5ypDYUUQV3C4ievU%3D&reserved=0 where did you submit them?
@Ninja4Codehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNinja4Code&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056167100|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=zJ3p5e1pDMwxoZ76lc7Ih8YKKaa5ypDYUUQV3C4ievU%3D&reserved=0 can you edit https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/includes/kerberos.mdhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fblob%2Fmain%2Faspnetcore%2Fincludes%2Fkerberos.md&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056167100|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=EeCduTZ71c0458ohHmOfNS490pQwp%2B67VmB57AoHzrk%3D&reserved=0 and replace the text in that file with your instructions?
[image]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F3605364%2F221061226-24993bb9-4c84-4e9a-bc8b-52577f53cd3b.png&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056323339|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=hspjEv13pBJgi8lblNOKeu0CJlkQAoT9zXvU2tFbD%2F4%3D&reserved=0
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2FAspNetCore.Docs%2Fissues%2F28432%23issuecomment-1445171520&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056323339|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=tJkqCigZTj%2FJ4%2BxozQzFqF%2B4y2KARbYSgCjEFRC5F1k%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACYCAVWGO33F3IXLWE45GDTWZJCUVANCNFSM6AAAAAAU65VLWY&data=05|01||c46988427d9a422dd40708db175acf3d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638129451056323339|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=L7jo3pg20U3bynOctvK%2FBEZZZABmo3G5Zjjfw60%2FQjk%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@Rick-Anderson It looks like this was added via #28705 but then most of it was reverted again in #28713. Was this done on purpose?


Consider ignoring patches in versions comparison

https://github.com/FuelLabs/fuels-ts/blob/0068f54d1baadc493423a00f7776e3378ea9b530/packages/versions/src/lib/compareSystemVersions.ts#L19-L21
Brought up in this comment:

https://github.com/FuelLabs/fuels-ts/pull/1291/files#r1363178371

Related:

https://github.com/FuelLabs/fuels-ts/issues/1323

Closing as unnecessary. This level of strictness is not heeding anything/anyone. It only benefits us/them to remain completely up to date and in sync, even at patch level IMO.

Good catch. It was also addressed via:

https://github.com/FuelLabs/fuels-ts/issues/2207


Slightly concerned about the copyright issues

This project is amazing, I am planing to use it as an education tool for students in my AI classes.
However, this project seems to be using some copyrighted data, i.e., the rom data dump for the arcade machine.
This may be a bit problematic. I am working to change the sound tracks and sprites a bit.

The easiest way to replace the image data is probably to skip the tile decoding steps which decode the ROM dump tile data into a regular texture where each sprite or tile is a simple rectangle in the texture, and instead directly embed an offline-created tile texture, basically skip these two steps:
https://github.com/floooh/pacman.c/blob/709a31d728032c0c8cc0bdc5d76f12d83bd97644/pacman.c#L2825-L2826
You can find the pixel content of the tiles and sprites here:
http://www.retrogamedeconstructionzone.com/2020/01/graphics-in-early-arcade-games-tilemaps.html
(looking like this:

...only difference is the layout in the texture. All 256 8x8 tiles are arranged horizontally in a line, and below the 64 16x16 sprite tiles, so the texture's width is 8 * 256 = 2048 pixels, and the height is 8 + 16 = 24 pixels.
Hope this helps :)


pwd and os incompatibility

Hey, so been awhile, just noticed that added new features and also broke windows compatibility again XD
I am looking at ways to fix it myself but just a heads up!

Also, to all Windows Brothers
Use the Linux subsystem till then

Yah, 2.3.2 works, 2.3.3 got broken with pwd.

Been looking for a bypass but there aren't any direct analogues
Atleast none I can find
Any suggestions on where to look


StateDownloader should retry immediately after receiving empty reply from peer

What is wrong?
During a state sync, sometimes a peer won't have the trie nodes we requested, and so will send us an empty NodeData msg.  When that happens we just move on and those nodes are re-requested only after the timeout (20s) has passed.
How can it be fixed
Whenever we get an empty NodeData from a peer, we should look up the nodes that were originally requested to that peer and re-request them to a different peer.

Seems like we need to keep some sort of tracking around which peers do not have certain trie nodes so that we can get to a point where we know "no peers have this trie node".  I believe this is needed for us to get out of a stalled state sync as noted in #1073


Musa

completed styling of bus registration ui

I had chatGPT explain the conflicts
1.
<<<<<<< Musa

<bytecodeTargetLevel target="17" />

test

In the first set of changes, the target attribute of  is set to "16". In the second set of changes, it is set to "17".
To resolve this conflict, you need to choose which version or changes to keep. If you want to target bytecode level 16, you would remove the conflicting line  and keep . Similarly, if you want to target bytecode level 17, you would remove  and keep .
(I just removed yours so its cool, but see if you can update)

<<<<<<< Musa

>>>>>>> test
The conflict is in the configuration file of the project, specifically in the  section named "ProjectRootManager". It appears that two different branches or versions have made conflicting changes to this section.
The conflict is indicated by the markers <<<<<<< and >>>>>>>. Everything between these markers represents the conflicting changes made by different branches.
In the first set of changes, the languageLevel is set to "JDK_15" and the project-jdk-name is set to "16". In the second set of changes, the languageLevel is set to "JDK_17" and the project-jdk-name is set to "jbr-17".
To resolve this conflict, you need to manually choose which version or changes to keep. You can modify the code snippet to remove the conflict markers and select the desired values for languageLevel and project-jdk-name. Once resolved, you can commit the changes and complete the pull request.
(I will try delete the line and see what happens if you think I should). Just message me

I had chatGPT explain the conflicts
1.
<bytecodeTargetLevel target="16" />

<bytecodeTargetLevel target="17" />

In the first set of changes, the target attribute of  is set to "16". In the second set of changes, it is set to "17".
To resolve this conflict, you need to choose which version or changes to keep. If you want to target bytecode level 16, you would remove the conflicting line  and keep . Similarly, if you want to target bytecode level 17, you would remove  and keep .
(I just removed yours so its cool, but see if you can update)

The conflict is in the configuration file of the project, specifically in the  section named "ProjectRootManager". It appears that two different branches or versions have made conflicting changes to this section.
The conflict is indicated by the markers <<<<<<< and >>>>>>>. Everything between these markers represents the conflicting changes made by different branches.
In the first set of changes, the languageLevel is set to "JDK_15" and the project-jdk-name is set to "16". In the second set of changes, the languageLevel is set to "JDK_17" and the project-jdk-name is set to "jbr-17".
To resolve this conflict, you need to manually choose which version or changes to keep. You can modify the code snippet to remove the conflict markers and select the desired values for languageLevel and project-jdk-name. Once resolved, you can commit the changes and complete the pull request.
(I will try try delete the line and see what happens if you think I should). Just message me

I had chatGPT explain the conflicts
1.
<bytecodeTargetLevel target="16" />

<bytecodeTargetLevel target="17" />

In the first set of changes, the target attribute of  is set to "16". In the second set of changes, it is set to "17".
To resolve this conflict, you need to choose which version or changes to keep. If you want to target bytecode level 16, you would remove the conflicting line  and keep . Similarly, if you want to target bytecode level 17, you would remove  and keep .
(I just removed yours so its cool, but see if you can update)

The conflict is in the configuration file of the project, specifically in the  section named "ProjectRootManager". It appears that two different branches or versions have made conflicting changes to this section.
The conflict is indicated by the markers <<<<<<< and >>>>>>>. Everything between these markers represents the conflicting changes made by different branches.
In the first set of changes, the languageLevel is set to "JDK_15" and the project-jdk-name is set to "16". In the second set of changes, the languageLevel is set to "JDK_17" and the project-jdk-name is set to "jbr-17".
To resolve this conflict, you need to manually choose which version or changes to keep. You can modify the code snippet to remove the conflict markers and select the desired values for languageLevel and project-jdk-name. Once resolved, you can commit the changes and complete the pull request.
(I will try try delete the line and see what happens if you think I should). Just message me

The conflict is in the configuration file of the project, specifically in the  section named "ProjectRootManager". It appears that two different branches or versions have made conflicting changes to this section.
The conflict is indicated by the markers <<<<<<< and >>>>>>>. Everything between these markers represents the conflicting changes made by different branches.
In the first set of changes, the languageLevel is set to "JDK_15" and the project-jdk-name is set to "16". In the second set of changes, the languageLevel is set to "JDK_17" and the project-jdk-name is set to "jbr-17".
To resolve this conflict, you need to manually choose which version or changes to keep. You can modify the code snippet to remove the conflict markers and select the desired values for languageLevel and project-jdk-name. Once resolved, you can commit the changes and complete the pull request.
(I will try try delete the line and see what happens if you think I should). Just message me


Create new transaction that can record both room and item rental

How to Demo:
fields should be initialized
(no null fields)

Implemented last sprint