Improve validator exit process

Describe the bug
It takes so much time to process blocks with validator exits, we need to improve it

it showed that processing this method may take up to 6s

Right I saw that readOnlyMap over the entire validator set when studying the spec code. Is this how other clients do it?

readOnlyMap is just the map for our TreeBacked structure, but it's more expensive due to the way we access leaf nodes in Tree.
Other clients should loop through validator array in state too. I think the way to improve is just to loop only 1 time for all validator exits included in a block.


Deployments are created even if not used

Hi
I am just working on a  small test project with suite-extension. I have a Suite class with three @Deployment methods defined.
If running a single @Test method (or class) from the IDE I noticed that arquillian is really only running that single test but three archives are created nonetheless. If you have several deployments that are large this could be a huge loss of time during daily development.
Is there a way to streamline this?
Thanks!

As far as I remember there is no easy way of doing that..
You could try disabling some deployments in runtime..
Mayby that would help..


Clarification for Projection Matrix - intrinsic camera calibration?

Hi,
I followed the steps in you calibration guide
I used the MATLAB tool box to generate the intrinsic parameters. I successfully get the K matrix and Distortion parameters. How do I generate the Projection matrix needed in the intrinsic.yaml files? It doesn't look like a direct transformation of P = K*[R|T]. How is the matrix being used for a mono camera? Can someone please clarify? It is not very clear from the documentation

You don't have to put anything for the projection matrix. The example file is old. Any value in projection matrix will be ignored.

thanks @techoe, will do so.


Disable broken tests

Some tests broke because of missing c_jet_ptrs. We didn't catch this because they were ignored.

Can you also add a  commit that tests the ignored tests in CI?

Done. Not sure why CI doesn't run as usual

My guess is that CI file indentation might be wrong

I used the same identifier for multiple jobs. It is fixed now.

FTR, these tests were broken even before we have c_jet_ptr. Hopefully, we don't get this in this situation now that we check this in CI


Support xterm.js as terminal inside oni

If xterm.js is added, oni could be a full terminal + tmux + neovim replacement.

Adding xterm.js for me is not to reinvent the wheel, add functionality like tmux, which is self-contained and hard to beat . It is more like adding tty support so plugins, various service that can utilize the terminal environment
for example, if I developing code in windows environment, I can create a linux virtual machine and run necessary tools inside vm, even analyze the the source code, provides auto format tools using clang-format, etc

Neovim has already a terminal option, so as far as I know it's not reinventing the wheel.
Just avoiting bloating with js dependencies, with xterm.js has added funcionality that's not present or can be adapted from :terminal that is desirable then that's great and certainly worthy to integrate.

I get what you're saying about sticking to your knitting and I have no particular view about xterm.js as a terminal-in-browser solution. However, the reality is that while Neovim is fantastic, it's built-in terminal is not. Even if its most glaring deficits are fixed, it will still be far short of running your preferred shell in Tmux. Right now I'm running Alacritty (and my other terminal apps) in Tmux in Alacritty and the experience is pretty good. I'm very impressed with Oni but would only make the leap if it allowed me to replace everything I'm doing with my current set-up. The practical benefits of keeping them together are just too great -- e.g. open filepaths from error logs when running tests in terminal, etc etc.

Oh, and I would consider becoming deeply involved in the development process if this was a path that Oni might take.

Well, I am pretty sure there would be no obstacles if you decide to go ahead on this, I think it would be a great addition.
Any idea how the feature would work? (e.g. called by c-s-p, :terminal replacement, dockable terminal, etc)

I think that having an xterm.js component could be a great base for multiple plugins.
I'd personally be very happy if someone will start a feature for that and will gladly help if I can.


kvstore_basic: truncated reads should report the length of the full length

User story:

As an application developer, if my program does a lookup with a buffer that's too small, I'd like my program to be informed of the size of buffer it will need to allocate in order to read the entire value.

The current behavior of kvstore_basic_lookup doesn't actually report this: https://github.com/vmware/splinterdb/blob/7d608d2ac0b9d2cc8523ca18293ab81e2621e45c/src/kvstore_basic.c#L403-L452
Suggested by @rtjohnso here: https://github.com/vmware/splinterdb/pull/100#discussion_r744153776

With the variable-sized value support and reworked APIs, this issue is fixed.


Allow specifying default package to build to support cargo workspaces.

This is change allows specifying a package to build as part of the 'cargo web' parameters.
This change allows cargo workspaces to function by targeting a specific package to build and process by cargo web. Cargo web currently supports targeting a package with the '--package' argument, this can now be set from the screeps.toml.
An additional fix is needed in cargo-web to make workspaces fully functional but this change remains compatible even before that is integrated: https://github.com/koute/cargo-web/pull/246

Integrated into #24 via the extra_options build setting.


Revert use of -9 in restart server

reverting change from #953

#1052  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on  Graphite


core declaration code

Well, it's not an issue as such, but a question about the core for Reactor.
I have looked at the example code on the GitHub repo and those are useful, thanks.
The only thing I couldn't see was an example of how and where to declare the core.
The example of var core = App.sharedCore seems to assume that the sharedCore
has already been declared, but doesn't show the syntax of how to do so.
An example of how to declare the core will be very useful. Thanks.

Good call! That would be good to include somewhere in the documentation.
In the mean time, here's how I do it personally:
enum App {
    static let sharedCore = Core(state: AppState(), middlewares: [
        ReachabilityMiddleware(),
        VersionCheckMiddleware(),
        ErrorLogger(),
        AnalyticsMiddleware(),
        // etc..
        ])
}

Thanks for that. I'll close this, as I am implementing ReSwift instead.


Warn users when there is a bnb mismatch

This raises a warning if the bnb version is not supported by LitGPT. This helps with debugging ugly error such as the one in #1325
Fixes #1325

Does this look reasonable to you @awaelchli  or would you suggest even raising an error in this case?

While this fixes the issue with bnb, there are other pinned packages in pyproject.toml.
I recommend to make it more generic, maybe even parse the file with dependencies instead of hard-coding versions: they might (and will) be changed in the future.

@Andrei-Aksionov

While this fixes the issue with bnb, there are other pinned packages in pyproject.toml.
I recommend to make it more generic, maybe even parse the file with dependencies instead of hard-coding versions: they might (and will) be changed in the future.

I agree, ideally we can do that some time, but for now, let's patch this one particular use case error people are bumping into.


Remove typo in Configuration.md

Summary
This clears up the Browserify/browser notes in the configuration docs by correcting a typo and adding detail to link text.
Test plan
N/A. This is a documentation edit.

Current coverage is 87.76% (diff: 100%)

Merging #1905 into master will not change coverage

@@             master      #1905   diff @@
==========================================
  Files            38         38
  Lines          1250       1250
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1097       1097
  Misses          153        153
  Partials          0          0

Powered by Codecov. Last update d5dbfad...ff0ee86

thank you <3


Add custom engine support

I tried to get as minimal changes as possible to get this functioning.
I switched the default of specifying engines by their plugin name to their shared library file name.  This was primarily because any custom engine is going to be specified by its shared library filename, and the engines map previously mapped from plugin name to the RenderEngine pointer.  Given the user will likely desire to simply entire their render engine shared library file name, I made this switch.  Specifying --render-engine ogre is still supported, but one can now also specify --render-engine ignition-rendering-ogre as well.
Another step in getting https://github.com/ignitionrobotics/ign-rendering/issues/100 resolved.
Depends on https://github.com/ignitionrobotics/ign-gazebo/pull/373

Resolved both of your feedback suggestions @iche033 , this branch now depends on the ign-gazebo branch here https://github.com/ignitionrobotics/ign-gazebo/pull/373

I took a look at the failing tests and found that they are caused by issue with unloading the rendering engines. I made some fixes in pull request #158. Can you take a look?


New viz: recombinational suppression / inversions

I think there should be some way to be able to visualise recombinational suppression along the chromosome, perhaps split by clade, which would be able to highlight e.g. inversions.
There's an known inversion on chr17p of humans (https://www.nature.com/articles/ng1508), and some others picked up in https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>8567v2.full.pdf. I chatted to Ana about possible visualisations, and she was unsure how well a viz would work (as opposed to plotting p-values as below), but I think it's worth exploring. Probably a good way to do this is to take the recent 1000 genomes chr17 inferred tree sequence and mess with visualizations (e.g. edge /clade spans in cM ploted against frequency and coloured by age or against age and coloured by freq), to see if the know inversion starts to stand out at all.

Jessica Purcell's ant system would be another nice example to use to try on real genealogies.

Transferred to https://github.com/tforest/tseda/issues/7


Repo sync for protected CLA branch

The pull request is created from master637335432996528040 to master to fix git push error for protected CLA branch

@opbld15 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Not compiling sample C app on Intel edison

getting below error while compiling the program
fatal error : uuid/uuid.h : No such file or directory
#include <uuid/uuid.h>
at azure-iot-sdk-c/c-utility/adapters/uniqueid_linux.c:7:23
compilation terminated.
Please help and suggest. I'm completely stuck at this stage

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dbc93e54-4f28-a9ec-bf96-560ed3924078
Version Independent ID: b4e01330-06c9-9887-e8d7-4cfe7798853c
Content: Intel Edison to cloud (C) - Connect Intel Edison to Azure IoT Hub
Content Source: articles/iot-hub/iot-hub-intel-edison-kit-c-get-started.md
Service: iot-hub
GitHub Login: @rangv
Microsoft Alias: rangv

@sumitkvsl Thanks for reporting! I have assigned the issue to the author to investigate and update as appropriate.

@sumitkvsl I'm sorry for such a slow response to your question. I don't know if this is still an issue for you or not but, I'm responding to your question on behalf of the author.
When compiling on a Linux machine, make sure you have installed the uuid-dev package that contains the referenced header file.  For example, on Ubuntu you can install the package as follows:
sudo apt-get install uuid-dev

@sumitkvsl Since Intel has announced discontinuing the Edison board, we will be retiring this article.

#please-close


DOC-5345: Register members command update

my code snippet was just an example, this is not for the docs as it includes my individual config.
The changes from https://github.com/corda/corda-docs-portal/pull/1339/ are what you need instead.


Explicit requirement of Ruby >= 2.0, reflection of that in the changelog.

This is a PR as suggested in #1656.

Excellent, thank you for contributing to the project!


Replace recaptcha v3 with v2

Implement recaptcha v2 in the ProtestForm.
Currently recaptcha v3 is commented out since it rejected 50% of the users.
The recaptcha API (using  react-recaptcha-v3) is commented out in the api file and in ProtestForm,

Anyone working on that @guytepper ?

@webernir negative. wanna take this?

Yes. On it..
On Wed, Oct 7, 2020, 21:10 Guy Tepper<EMAIL_ADDRESS>wrote:

@webernir https://github.com/webernir negative. wanna take this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/guytepper/1km.co.il/issues/36#issuecomment-705106577,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASM772AB3TZA5LFZ24KYMTSJSVKVANCNFSM4SE4XRIQ
.


Add https://themes.gohugo.io/ link to description of repo

Add the https://themes.gohugo.io/ link to description of this (gohugoio/hugoThemes) repo so it’s easy and fast to access.

Done.


Users are able to "identify" items that should remain hidden

This was a feature that I was wanting prior to version 3.0.  The ability to add a magic item to a players inventory as a GM, but its true identity stays hidden until the GM changes the item to identified.  Now the option is there, but the player has the ability to identify the item themselves.  This should be a GM only option, and I am not seeing any settings in the config to change its visibility or permissions.

I totally agree with this. And the information need be hidden until identification, including the gp value.

I wrote up this world script that will hide the Identification buttons from a player when an item is Unidentified, so you can use this in the meantime while it gets scoped out by the system.
https://github.com/MaxPat931/Macros/blob/main/WorldScripts/HideUnidentify3.js
gandb, the details and gp value are hidden when unidentified, the description will automatically change from the Description to the Unidentified Description for the player.

I feel like this might be a good candidate for a new permission so that, say, trusted players are allowed to identify by themselves. That said, I'm not sure if that's purely in the gift of the core Foundry app itself.

I feel like this might be a good candidate for a new permission so that, say, trusted players are allowed to identify by themselves. That said, I'm not sure if that's purely in the gift of the core Foundry app itself.

I tottaly agree with you, but a lot of permissions aren't includded into the core, can be added into the dnd5e

I wrote up a world script that will hide the Identification buttons from a player when an item is Unidentified, so you can use this in the meantime while it gets scoped out by the system.
https://github.com/MaxPat931/Macros/blob/main/WorldScripts/HideUnidentify3.js
gandb, the details and gp value are hidden when unidentified, the description will automatically change from the Description to the Unidentified Description for the player.

 This works a treat.

Could this fit into the "Configure Visibility" options implemented in #4798?

@MaxPat931  the problem isnt description in the chat, is in all parts and forbiden player identify item without permission of DM, like the hideunidentify3.js from @zero127

I didnt say anything about chat, I just linked to the wrong issue initially since it is linked to the PR I meant to mention, Im asking that the option to remove the Identify button could be added into the new Configure Visibility setting group added in PR #4817 .
Your screenshots seems to be from a GM account, all of that information is hidden from a player if the item is Unidentified

The description above is from the "Unidentified Description" which is only available to GMs (see Mace of Disruption in the SRD)

There was a bug related to this that was fixed in 4.1.2 #4730, but that doesnt look like what you're showing

Oh, I understand now, sorry. Yes, but need block all things in the images


Soft Delete Limitation

Soft delete cant enable when the vNet endpoint is created to storage account. Please mentioned it as a limitation for soft delete
Error
Access denied
You do not have access
This storage account's 'Firewalls and virtual networks' settings may be blocking access to storage services. Try adding your client IP address to the firewall exceptions, or by allowing access from 'all networks' instead of 'selected networks'
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 78964956-a479-5fbe-710d-19e361542a36
Version Independent ID: 15e70532-6d39-47ed-6932-ef3eb88e33f0
Content: Soft delete for Azure Storage blobs (Preview)
Content Source: articles/storage/blobs/storage-blob-soft-delete.md
Service: storage
GitHub Login: @MichaelHauss
Microsoft Alias: mihauss

@kasunsjc Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Are you able to configure soft delete from an IP address within your VNET? Is the issue that you cannot configure soft delete using Azure Portal?

@kasunsjc - Thank you for taking the time to share your product and documentation feedback with us. Your input is valued because it helps us create the right documentation for our customers.
Due to the volume of issues in our queue, we are closing open issues older than 90 days. We hope to continue hearing from you. Thank you.


Allow custom directory structure

It seems like the ruleset requires the lib and spec directories to be at the root of the repository. We are looking at using the rules in a larger, mixed language monorepo where code typically lives in sub-directories based on the application name. In trying to adapt the gem example to fit our use case, we noted that the lib and spec directories are no longer available in the LOAD_PATH if these directories are not at the root. A simplified example can be found at: https://github.com/protocol7/rules_ruby/tree/subdirs/examples/gem
This uses a directory layout like:
├── BUILD
├── Gemfile
├── Gemfile.lock
├── MODULE.bazel
├── MODULE.bazel.lock
├── WORKSPACE.bzlmod
└── foo
    ├── lib
    │   ├── BUILD
    │   └── gem
    │       ├── BUILD
    │       └── add.rb
    └── spec
        ├── BUILD
        └── add_spec.rb

Is it possible to make the ruleset work for this type of use case?

There is nothing in the ruleset that forces you to use lib/spec directories at the root. In fact, the Selenium project keeps all Ruby code under rb/ directory, and everything works just fine. You can see the example here - https://github.com/SeleniumHQ/selenium/tree/trunk/rb.
Can you provide more details on the targets you try to run and what are the exact LOAD_PATH failures you see? Also, feel free to ask on #ruby channel in Bazel Slack - it might be faster to iterate on this issue there.

Thanks for the quick response and the confirmation that the ruleset is agnostic to the directory structure. Indeep, in our case it turned out to be a rspec configuration issue. I'll close this.


Support symlinks with packageDir option for import/no-extraneous-dependencies

https://github.com/import-js/eslint-plugin-import/blob/5680a1f8d41cd19f9c60d999a6fadf10994a0a64/utils/pkgUp.js#LL41C41-L41C54
The utils logic that supports whether or not a package.json exists does not check if one is symlinked. Can there be a check added after this check that uses https://nodejs.org/api/fs.html#fs_fs_lstat_path_callback to validate if a package.json exists?
This use case is specifically for interop with https://github.com/aspect-build/rules_js/ which will symlink package.json files to the area it runs eslint from.
CC @gregmagolan

Can you elaborate on what specifically isn't working right now? The ideal would be a PR with a failing test case :-)

Yeah I'll try and whip one up. Basically my current use case is this:
module.exports = {
  env: {
    node: true,
  },
  extends: ['@company/eslint-config'],
  rules: {
    'import/no-extraneous-dependencies': [
      'error',
      {
        devDependencies: true,
        // This ensures we check the root of the monorepo in addition to our local packages
        packageDir: [path.resolve(__dirname, '../'), __dirname],
      },
    ],
  },
}

This worked for us with rules_nodejs because the ruleset copied files over.
Now when trying to migrate to rules_js to be our test runner the error I get with the above is
  0:1  error  The package.json file could not be found  import/no-extraneous-dependencies

✖ 1 problem (1 error, 0 warnings)

Best I can tell is that the logic which finds the package.json is not find it. I checked the bazel runfiles and the files are there. If I disable this, then the test passes. The package is part of a pnpm workspace so I need to expose multiple package.json also.

I'm confused - why would you need to check the root from a subpackage? Typically each subpackage checks itself, and the root checks itself as well.

The reason I need to look up the tree is because if the config is also checking developer tools, those are usually at the root config so we keep one version and flatten the dependency graph. It doesn't make sense to have things like eslint or webpack declared in every subpackage. Shared tooling is hoisted to the top. In the case of this config, it's for an internal eslint plugin so it relies on some of these root level dependencies. If you don't give the rule a place to find them, it will complain about undeclared dependencies. Also applies to test code if you don't have something like expect in your package.json but it's at the root of the repo

I guess the alternative is if something expects a package downstream to provide deps it should declare things as devDependencies and peerDeps in which case I wouldn't need to specify multiple package.json roots right?

right - i understand the bazel model where you have a single package.json at the root. but, that also means you have a single eslint config at the root.
In this case, I see the eslint plugin is setting config defaults - and settting packageDir to an array of "the root" and then "the current dir" would make sense - but __dirname there is the directory of the plugin, and won't magically become the directory of individual subpackages. Are you expecting that the plugin's declared dependencies would be valid imports for everything else in the monorepo?

Yeah unfortunately we don't have a root config yet, that's a very large lift we are still pushing towards.
Yeah the model we have is that we use syncpack to align our dependencies so all our eslint dependencies are the same version across the repo no matter where they are declared

I'm not familiar with that tool - what i meant was, if you put the plugin's directory in packageDir, and it depends on X, but nothing else in the monorepo needs it, then the eslint rule will allow anything to import X as if they declared it, which kind of shreds the premise of bazel :-p

True, I see your point. In this case though the eslintrc is only used by this plugin dir and not by the broader repo. That isolates the trickledown you are describing.
I think the route I'm gonna take is to have the plugin specify what it needs via peerDependencies and devDependencies and then remove this packageDir field so that the rule only looks in the plugin's dir and nowhere else. This skips the symlink check it seems too? Not sure why.

That seems reasonable. node resolves symlinks by default I think, but perhaps this plugin doesn't.

Cool. thanks for being so quick to respond! I'll close this issue for now


Possible correction to homebridge-broadlink-rm/accessories/fan.js

Newb here. I had a problem with the fan accessory doing some strange ux in iOS of a temperature setting and heating and cooling/auto as if the fan were a thermostat and rendered my fan non-functional as I had it configured in json. I poked around the internet and apple's documentation on fan vs fanv2 and it led me to examine the fan.js file....I noticed that on line 4 it is shown as:
    serviceType () { return Service.Thermostat }

I dove into my raspi's folder:
/usr/lib/node_modules/homebridge-broadlink-rm/accessories/Fan.js
and nano'd the service from "Thermostat" to "Fanv2"
    serviceType () { return Service.Fanv2 }

and restarted homebridge. In iOS this brought back the old speed slider and the oscillation icon that I was used to previously before I upgraded and had found this problem and my fan became functional again. I don't know if any one else was having this issue, if I'm grasping the problem correctly, or if there was some way of configuring my fan as a thermostat that would have taken advantage of a temperature reading somehow to use with automations...but I thought I would post this in case it was an error or might help someone else.  I really appreciate the work that went into these plug ins. I can kinda decipher and troubleshoot some things like this, but I'm nowhere near being able to build these myself, thanks for all you do!

Wow!! Im so happy to read this, I was having the same issue with no idea how to fix it haha I will try thiis :)

I've tried this out but got the following error :\
"UnhandledPromiseRejectionWarning: Error: homebridge-broadlink-rm doesn't support accessories of type "fanv2"."

Im wondering if the capitalization of Fanv2 vs fanv2 is an issue? If thats not it, I believe that “Fan” is still a valid term. Try those and let me know...If neither works, I would try copy and paste from my above into the file and see if that might do it. I hope that helps!

THANK YOU! 👌💯
This should be corrected ASAP in public release. Would also be great if the fans from Broadlink acted like other fans in HomeKit (like a simple one I have with a good old "dumb thing = smart plug", from EVE), where I can choose the "correct" icon for it (e.g. floor, desk or ceiling) 🤓


Helm operator can't see some releases with error in flux deployment logs

As of today, the Helm operator fails to make releases for some charts: one of them is based on jupyterhub, the other is a custom built chart for internal services on our cluster
Here is a sample of the error inside the flux logs:
ts=2018-09-21T21:17:39.011194089Z caller=memcached.go:109 component=memcached err="Fetching tag from memcache: memcache: connect timeout to <IP_ADDRESS>:11211"
ts=2018-09-21T21:17:39.011319855Z caller=warming.go:170 component=warmer canonical_name=quay.io/weaveworks/flux auth={map[]} err="fetching previous result from cache: memcache: connect timeout to <IP_ADDRESS>:11211"
ts=2018-09-21T21:17:40.011659407Z caller=memcached.go:109 component=memcached err="Fetching tag from memcache: memcache: connect timeout to <IP_ADDRESS>:11211"
ts=2018-09-21T21:17:40.011782063Z caller=warming.go:170 component=warmer canonical_name=index.docker.io/jupyterhub/k8s-network-tools auth={map[]} err="fetching previous result from cache: memcache: connect timeout to <IP_ADDRESS>:11211"
ts=2018-09-21T21:17:41.015695493Z caller=memcached.go:109 component=memcached err="Fetching tag from memcache: memcache: connect timeout to <IP_ADDRESS>:11211"
ts=2018-09-21T21:17:41.015819684Z caller=warming.go:170 component=warmer canonical_name=k8s.gcr.io/kube-proxy-amd64 auth={map[]} err="fetching previous result from cache: memcache: connect timeout to <IP_ADDRESS>:11211"
ts=2018-09-21T21:17:42.021003002Z caller=memcached.go:109 component=memcached err="Fetching tag from memcache: memcache: connect timeout to <IP_ADDRESS>:11211"

Inside of the helm operator logs, we have:
ts=2018-09-21T21:21:17.076382565Z caller=status.go:75 component=annotator err="rpc error: code = Unknown desc = release: \"jupyterhub\" not found"

How did you refer to the chart on jupyterhub in your FluxHelmRelease resource? In helm-operator 0.2.1, you can only use charts that are in the git repo you've provided.
The flux logs appear to indicate that memcached isn't running. Maybe check that the pods for that deployment have started.

No follow-up, closing this issue for now. Please re-open if you have more info.


User enumeration still possible through password reset functionality

Laravel Version: 9.52.4
PHP Version: 8.2.3
Database Driver & Version:

It is still possible to determine whether a user exists with a given email address by comparing the time taken for a password reset request against a request made for a known non-existent user.
A user has posted a fix in the thread of an earlier issue (https://github.com/laravel/framework/issues/13658#issuecomment-785023918) but it would be good if it could be addressed by the framework itself  (as Symfony did - https://symfony.com/blog/cve-2021-21424-prevent-user-enumeration-in-authentication-mechanisms) so that all deployments are protected out-of-the-box. Is such a change in your roadmap?
Thanks
Steps To Reproduce:

Laravel's Timebox, which is currently in use on login verification could be used for this - rather than using a random delay (which isn't fully secure): https://github.com/laravel/framework/blob/10.x/src/Illuminate/Support/Timebox.php
That said, Laravel's registration form provides an easy enumeration vector by checking for a unique email address. It's an easier and quieter way to test enumeration via registration than using password resets.
Enumeration needs to be solved at a deeper level to properly eliminate it from the framework.

Right now, we don't consider user enumeration an issue as major social networks like Twitter, etc also allow for this through their password reset.


also detect iojs bin

see: https://github.com/bcoe/yargs/issues/138

Awesome!
btw, even if you specify #!/usr/bin/env node, node is merely a symlink to iojs. process.argv[0] will always be iojs :)


Adding my port of Franbach's miramare theme

Hi! This is my first PR here and I made a variant based on doom-gruvbox.
Miramare is a vim theme by @franbach and I think it is a refreshing variant of the good-old gruvbox theme.

Because there are more colors in doom-themes than miramare, I have used some analogous color tones to fill the missing colors.
Opinions are welcomed!

Some screenshots
Dired

Magit

Python and markdown

Shell

Org

Quite nice and earthy! I like it. I{ll give it a try soon.

Fixed syntax highlighting for React JSX. Screenshot here:

Very good job man. So far so good, you've really polished this theme as much as you could. I'll test it a little bit more but I think it can be merged soon.

I think one thing that can be improved is ivy-minibuffer-match-face-2 face to give it a little bit more of contrast, since the yellow color looks too dim. Maybe a red-ish color would do the job.

Hi @ema2159 , this is a good suggestion, I was so used to it that I didn't notice it was hard to see.
This is before:

This is after:

And for the sake of completeness:

I will push my commits if you think they are okay. Thanks!

That's perfect!

@sagittaros friendly ping. Please update the faces!

@ema2159 sorry! pushed

Done! Thank you very much for your work and time!


[webview_flutter] When sliding to the webview page, a vertical line appears

Flutter : stable(2.8.0)
iOS: iphone8 plus
webview_flutter: 3.0.0

use webview_flutter example, and change favoriteButton：
Widget favoriteButton() {
    return FloatingActionButton(
      onPressed: () {
        Navigator.of(context).push(MaterialPageRoute(builder: (context) {
          return Scaffold(
            appBar: AppBar(
              title: Text("Next"),
            ),
            body: Container(),
          );
        }));
      },
      child: Icon(Icons.favorite),
    );

when Next title page swipe to  pre page：
https://user-images.githubusercontent.com/12316547/148165308-f29b5bf7-2a4f-4844-8f17-90dbdead0746.mp4
a vertical line appears:

@OHeroJ
I tried the same on iOS simulator 12.3 and on iphone 6s but didn't see the line:

Can you downgrade the plugin version to 2.8.0 and see if you still get same behavior ?

@OHeroJ I tried the same on iOS simulator 12.3 and on iphone 6s but didn't see the line:

Can you downgrade the plugin version to 2.8.0 and see if you still get same behavior ?

This problem can be reproduced on the real machine。The models I can reproduce now：

iphone8 plus
iPhone14,2

@OHeroJ I tried the same on iOS simulator 12.3 and on iphone 6s but didn't see the line:

Can you downgrade the plugin version to 2.8.0 and see if you still get same behavior ?

[webview_flutter] 2.8.0 same behavior in real machine（iPhone8 Plus）.

Since I don't have the specific physical device (iphone 8 plus), I don't see the said behavior. Although I tried replicating the same on iPhone 8 and iPhone 8 plus simulators and don't see the behavior.

Keeping it open and labeling it for further investigation.

@cyanglaz https://github.com/flutter/flutter/issues/61340 ?

I have the same line, iphone 8 plus 14.6,flutter verson2.5.1

@maoemao  please follow up on the linked issue


⚠ Bofrost.at has degraded performance

In 9dd4091, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2004 ms

Resolved: Bofrost.at performance has improved in 763a040.


Foreach on Text

Ok text handling is now as usual, very cool;).
Now it would still be awful cool if you could use Foreach through the text variable.
Scenario is, I want to remove all special characters from a text.

Thanks for the suggestion, we will consider it

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 22.0.52547.0 and VS Code Extension Version 11.0.744315.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://freddysblog.com/2020/06/25/working-with-artifacts/


[Tracking Issue] Code Refactor

[x] Is this line unused?
Originally posted by @Flouse in https://github.com/ckb-cell/rgbpp-sdk/pull/26#discussion_r1533324544
fixed in https://github.com/ckb-cell/rgbpp-sdk/pull/38

[ ] Review the logic of BTC transaction fee calculation
https://learnmeabitcoin.com/technical/transaction/size/#weight

[ ] BTC Replace by Fee (RBF) feature
Allow a BTC transaction to be replaced

Enabling the RBF feature (allowing transactions to be replaced) is easy, but how to sign and send the same transaction again is a problem. The issue is that when we got the UTXOs to construct a transaction, we got them from the btc-assets-api. And once the transaction is constructed, it no longer contains some required properties for us to "reverse" the whole construction process and convert a Transaction to a PSBT.
For example, how does the process know which output (vout) in the transaction can be altered in order to pay more fees? And besides, what's the dust limit for each output? Since outputs can be normal UTXOs (dust_limit=1,0000) or RGBPP UTXOs (dust_limit=546)._limit=546).


adding authdb option to the credentials for mongodb

While testing the database backup for mongodb we encountered an error.  Authentication failed when trying to use the mongo shell.  Here is a copy of the error:
[2016/02/04 00:49:24][error]   MongoDB shell version: 3.0.1
[2016/02/04 00:49:24][error]   connecting to: localhost:27018/test
[2016/02/04 00:49:24][error]   2016-02-04T00:49:24.750+0000 E QUERY    Error: 18 Authentication failed.
[2016/02/04 00:49:24][error]   at DB._authOrThrow (src/mongo/shell/db.js:1236:32)
[2016/02/04 00:49:24][error]   at (auth):6:8
[2016/02/04 00:49:24][error]   at (auth):7:2 at src/mongo/shell/db.js:1236
[2016/02/04 00:49:24][error]   STDERR Messages:
[2016/02/04 00:49:24][error]   exception: login failed
When authenticating a user against mongo an option that can be passed is authenticationDatabase.  Without this option for our setup we get a login failed message. This pull request adds some unit testing for an authdb option and plumbs it through to the credential options function.
Please let me know if there are any additional changes (tests etc) required in order to get this changeset through.

This feature would be really helpful for my group.

Isn't it possible to specify this through additional_options = ["--authenticationDatabase=path"]
That way you should be able to specify whatever config which doesn't have a convenience config option available. Please try that and let me know if that solves your problem

I tried that first, and it works for this function:
  def mongodump
    "#{ utility(:mongodump) } #{ name_option } #{ credential_options } " +
    "#{ connectivity_options } #{ ipv6_option } #{ oplog_option } " +
    "#{ user_options } --out='#{ dump_packaging_path }'"
  end

where users_options is available.  However, in the shell function:
  def mongo_shell
    cmd = "#{ utility(:mongo) } #{ connectivity_options }".rstrip
    cmd << " #{ credential_options }".rstrip
    cmd << " #{ ipv6_option }".rstrip
    cmd << " '#{ name }'" if name
    cmd
  end

There is no way to get the additional options down the stack.  It looks like the mongo_shell function is skippable if the db.lock is set to false, but I'd like to use that feature if possible.
The authdb option seems to pop up quite a bit when I'm looking at the documentation for mongo.  It seems like a pretty standard option.  Why shouldn't it be included as a first class option?

aha, then it makes sense to add it there


Hapi support

Describe the solution you'd like
Some sort of modular take-what-you-need system for dealing with different frameworks and ecosystems.
Describe alternatives you've considered

Making sylph router the core of sylph and writing individual interaction layers for each ecosystem
Building specific support for the most popular ecosystems

Additional context

Definitely needs to be able to support Hapi, this is what got me considering wider support
Needs to be able to work in a way (even if it is plugin based) that creates the smallest amount of shipped code.
Should ideally provide support for additional custom or niche implementations

Scratch that! Guess they heard me
https://twitter.com/hapijs/status/1275887984114413569


Optimize GPT2 inference: Remove redundant autoregressive_latent_graph and enable streaming output

Thank you for this excellent implementation. I'd like to suggest an optimization that could significantly speed up inference and enable streaming output.
Currently, there are two GPT2 graphs:

autoregressive: Generates speech codes (originally for CLVP to select the best result)
autoregressive_latent_graph: Generates latents based on the best result

Since CLVP has been removed, we can streamline this to a single GPT2 graph that directly generates latents. I've implemented this with minimal changes:

In autoregressive_graph, add after cur = ggml_add(ctx0, cur, model.language_model_head_layer_norm_bias);:

// Output latents
ggml_tensor *final_output_2 = ggml_cont(
    ctx0, ggml_view_4d(ctx0, cur, 1024, 1, batch_size, 1,
                       cur->nb[1], cur->nb[2], cur->nb[3],
                       (test_dimension - 1) * sizeof(float) * 1024));

ggml_set_name(final_output_2, "output_latents");
ggml_set_output(final_output_2);
ggml_build_forward_expand(gf, final_output_2);

In the main inference loop, extract the latent:

extract_tensor_to_vector(ggml_graph_get_tensor(gf, "output_latents"), latent);

Benefits:

Faster inference by eliminating redundant GPT2 runs
Enables potential streaming output of latents
Simplifies code structure

This optimization could significantly benefit users looking to speed up inference or implement streaming latent generation.

@candlewill thanks for looking into this; I think this would be a good change to make, though I wasn't able to get it to work by naively applying it. If you have a working branch with this change applied would you be willing to make a pull request?

@candlewill Hey :) Would you mind uploading the required changes as patch file or sharing a forked git version with your optimization? I would be curious to try it out and have trouble applying the second part of your patch in the main inference loop.

I'm also interested in this. Increasing the overall performance when using single-threaded CPU (with AVX-512) would be awesome, if possible. And also, to identify which parts are loading (before message) and which parts come after the message is known.


Make sure only one import is performed at the time

We recently had performance issues that made the import take too long (more than 24hrs for RIPARIAS), therefore the import process is restarted the next day while the first one is still in process, this is something to be avoided.

After a quick investigation, I didn't found any integrated mechanism nor easy solution for that. Possible solutions:

create a file / an entry in the database / a Redis key to keep track of the running status (similar to Django maintenance mode)
actually use the status of django-maintenance-mode (skip import if already in maintenance mode) => doesn't seems great since we only put in maintenance mode in the middle of the process. Also, the site could be in maintenance mode for other reasons than a running import.
Check if using RQ's scheduler feature (in place of cron) could help avoiding the issue.


Transit-Gateway MulticastSupport

Add MulticastSupport attribute to TransitGateway that is currently supported by CloudFormation. Tested and validated as working.

Thanks!


[ENH,RTM] Finish up ApplyXFM implementation

It was half-implemented but commented out.

I wrote this on slack but I think you missed it: "shouldn't ApplyXFMRPT just inherit from FLIRTRPT? both their _post_run_hooks look the same.
or is this a goofy mixin thing?"


#101 - added documentation for truncating revision numbers in pipeline l...

Documentation for #101 -- belongs to PR947 for gocd

agreed

Looks ok to me now, obviously needs reviewing by staff!
Glad to be of help

Thanks, and sorry for all the required changes.

I just observed that the documentation for pipeline labels is not mentioning pipeline parameters.

I just observed that the documentation for pipeline labels is not mentioning pipeline parameter, e.g.
1.5.${COUNT}-#{param1}

looks good to me. thanks @alexschwartz for adding this & @paulclarkin for the review :+1:


Can rest api /v1/graph/routes pass route_hints?

I want to manually pass route_hints, I looked at the REST documentation
https://api.lightning.community/?javascript#v1-graph-routes
But there is no information on route_hints, must I use GRPC?

I think this is just a problem of the API docs. The route hints should work in REST.
Can you try this:
route_hints=[[{"node_id":"xxx","chan_id":"xxx"},{...}]]

Or something to that effect?
REST isn't really optimal for nested structures like this, but it should work in principle (might need some tweaking of the formatting to please the REST proxy library, this is just from the top of my head).

@henta were you able to resolve things in the end?

Closing due to inactivity. @henta feel free to re-open if you can't get it to work.


Azk running tests

Well, azk is an awesome tool for devs!
When I trying use it, I have a little doubt, I don't know if you have an problem/idea like this, but is very useful if I can run my tests directly in AZK. maybe: azk start test or something like this.
What you think about it?
Thansk in advance!

We have planned a binStubs scheme.
e.g.:

Azkfile

aliases({
  bundle     : { command: ["bundle", "exec"]}, // system: azkdemo (default)
  scaffold   : { alias: "bundle", append: ["rails", "g", "scaffold"]},
  test       : { alias: "bundle", append: ["rake", "test"], tty: true, context: 'test'},
  'import-db': { system: "mysql", command: ["mysql"], depends: false}
});

Ways of running:

$ azk script generator --path ./script
  ./script/bundle
  ./script/scaffold
$ azk shell [system]
$ azk exec test
$ azk exec scaffold -- post title:string body:text
$ azk exec test -C dev -T
$ azk exec -- bundle
$ ./script/scaffold post title:string body:text

This feature was suggested by @willian, for some time.

This is a good idea. Think not just about tests, but any kind of task or command.
Currently I use Docker + Fabric to define some tasks. Some tasks are just docker exec -it ....
Azkfile.js could support something like this:
systems({
  'app': {
    image: { docker: "azukiapp/python:3.4" },
    // ...
    tasks: {
      createsuperuser: function(run) {
        run('python manage.py createsuperuser');
      },
      migrate: function(run) {
        run('python manage.py migrate');
      },
      sometask: function(run, name) {
        run('echo Hello '+name);
      }
    }
  }
);

Allowing us to execute
$ azk task createsuperuser
$ azk task migrate
$ azk task hello:world

Each task would be just a function, with an argument (run function) that connect to container and execute the command passed. I think that this is more flexible and easier to reason about than another configuration section in a JSON-like way.

good point @geovanisouza92

This is really interesting! Any idea when will it be released?

as yet not @victorgama, there are some major priorities. But as soon as possible it will be done. I also like that she had already been implemented.

@gullitmiranda No problem. Will keep watching this issue until it is implemented. Thanks!


log-backup: fix bug: After br log pausing, the global checkpoint is still moving …

Signed-off-by: joccau<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close https://github.com/tikv/tikv/issues/12583
What's Changed:

Need to retry if failed to get task. If task is not existed, do nothing.
Need sleep and retry if the mistaken happens when etcd client send grpc to etcd.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

[ ]  Unit test
[ ]  Integration test
[x]  Manual test (add detailed scripts or steps below)
[ ]  No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
Please add a release note.

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with None.
If this PR will be picked to release branch, then a release note is probably required.

/cc @3pointer

/cc @kennytm @overvenus  PTAL

/run-all-tests

/run-all-tests

/merge

/run-test

/run-test

/rebuild

/rebuild

/run-build

/run-test

/run-test

/run-test

/run-test

/run-test

/run-test

/rebuild

/run-test

/test

/rerun-test

/run-test

/test

/run-test

/run-test

/run-test


Remove default constructor from SecretKey class

High Level Overview of Change
This Pull Request deletes the default constructor from SecretKey and PublicKey classes.
All the constructed Public Keys are valid, non-empty and contain 33 bytes of data. This PR establishes this invariant.
Additionally, the memory footprint of the PublicKey class is reduced. The size_ data member is declared as static.

Context of Change

Fix https://github.com/XRPLF/rippled/issues/2942
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Okay, that clarifies things, thank you. I had my reservations about the
getter functions, I did not think about the downstream effects of an
unseated optional.
I'll make the necessary changes :+1
Regards,
Keshava
On Thu, Aug 3, 2023 at 2:19 PM Scott Schurr @.***>
wrote:

@.**** requested changes on this pull request.
You got half of the point of my previous comment. But I was not clear
enough about the motivation. Sorry about that.
Every time code is about to access to contents of an optional it needs to
do one of two things:

Have some prior knowledge so it "knows" that the optional has valid
contents, or
Verify, locally, that the optional has a valid value prior to access.

If the code does not do one of those two things then that's a setup for a
crash in the future.
The safest choice of those two, particularly in the face of an evolving
code base, is to do the local check.
Putting all of the *Keys in ValidatorKeys into a single optional means
that with one check...
if (validatorKeys_.keys)
I can be assured that it's safe to access any and all of the *Keys in
ValidatorKeys::Keys.
If the *Keys are stored in three separate optionals, then I have to do
separate checks any time I access any of the keys.
So, by putting all three *Keys in a single optional it becomes both

Easy and
Compute efficient

to see whether accessing any of the *Keys is safe.
Just in case I'm still not clear, I've made a commit where the optional
is checked every time before the *Keys in ValidatorKeys are accessed.
That's the top-most commit here:
https://github.com/scottschurr/rippled/commits/chenna-ppp
https://urldefense.com/v3/__https://github.com/scottschurr/rippled/commits/chenna-ppp__;!!PZTMFYE!5M7yWugj9lZGIdANUq_dIy6g1tt-tb9qQGmaXwWXl0guoI4Y-N89ukBKjLpSwGW4UkqJTTR1a7_CbTGAOcOokG_iuA$
You're welcome to cherry-pick that commit if you want. But don't blindly
drop it in. Look at the places the checks are added. I might have messed
something up.
Does this all make sense? From a larger perspective we're pushing first
for safety and correctness. Once we have that, then we can make things
efficient.
In src/ripple/app/misc/impl/ValidatorKeys.cpp
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*discussion_r1283673587__;Iw!!PZTMFYE!5M7yWugj9lZGIdANUq_dIy6g1tt-tb9qQGmaXwWXl0guoI4Y-N89ukBKjLpSwGW4UkqJTTR1a7_CbTGAOcPUhHeNFg$
:

@@ -56,9 +56,7 @@ ValidatorKeys::ValidatorKeys(Config const& config, beast::Journal j)
}
else
{

           secretKey = token->validationSecret;

           publicKey = pk;

           masterPublicKey = m->masterKey;

           keys.emplace(token->validationSecret, pk, m->masterKey);

Nice use of emplace()!
In src/ripple/app/misc/impl/ValidatorKeys.cpp
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*discussion_r1283681301__;Iw!!PZTMFYE!5M7yWugj9lZGIdANUq_dIy6g1tt-tb9qQGmaXwWXl0guoI4Y-N89ukBKjLpSwGW4UkqJTTR1a7_CbTGAOcO8h0vLAw$
:

@@ -83,10 +81,11 @@ ValidatorKeys::ValidatorKeys(Config const& config, beast::Journal j)
}
else
{

       secretKey = generateSecretKey(KeyType::secp256k1, *seed);

       publicKey = derivePublicKey(KeyType::secp256k1, *secretKey);

       masterPublicKey = *publicKey;

       nodeID = calcNodeID(*publicKey);

       SecretKey sk = generateSecretKey(KeyType::secp256k1, *seed);

       PublicKey pk = derivePublicKey(KeyType::secp256k1, sk);

       keys.emplace(sk,

Nice use of emplace()!
In src/ripple/app/misc/ValidatorKeys.h
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*discussion_r1283684623__;Iw!!PZTMFYE!5M7yWugj9lZGIdANUq_dIy6g1tt-tb9qQGmaXwWXl0guoI4Y-N89ukBKjLpSwGW4UkqJTTR1a7_CbTGAOcMjB4KzLQ$
:

       SecretKey const& secret_,

       PublicKey const& public_,

       PublicKey const& masterPublic_

Please have the order of your constructor arguments match the order of the
public members in Keys. Putting them in a different order only promotes
confusion.
In src/ripple/app/misc/impl/ValidatorKeys.cpp
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*discussion_r1283688029__;Iw!!PZTMFYE!5M7yWugj9lZGIdANUq_dIy6g1tt-tb9qQGmaXwWXl0guoI4Y-N89ukBKjLpSwGW4UkqJTTR1a7_CbTGAOcNdLicbeg$
:

@@ -83,10 +81,11 @@ ValidatorKeys::ValidatorKeys(Config const& config, beast::Journal j)
}
else
{

       secretKey = generateSecretKey(KeyType::secp256k1, *seed);

       publicKey = derivePublicKey(KeyType::secp256k1, *secretKey);

       masterPublicKey = *publicKey;

       nodeID = calcNodeID(*publicKey);

       SecretKey sk = generateSecretKey(KeyType::secp256k1, *seed);

       PublicKey pk = derivePublicKey(KeyType::secp256k1, sk);

       keys.emplace(sk,

                    derivePublicKey(KeyType::secp256k1, sk), pk);

Notice that you are calling derivePublicKey() with the same arguments
twice. Since the arguments are the same the two calls return identical
results. I think, compute time wise, you're better off if you make the
emplace() call like this:
keys.emplace(sk, pk, pk);

In src/ripple/app/consensus/RCLConsensus.cpp
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*discussion_r1283705757__;Iw!!PZTMFYE!5M7yWugj9lZGIdANUq_dIy6g1tt-tb9qQGmaXwWXl0guoI4Y-N89ukBKjLpSwGW4UkqJTTR1a7_CbTGAOcN4EZtMIw$
:

@@ -105,13 +105,13 @@ RCLConsensus::Adaptor::Adaptor(
JLOG(j_.info()) << "Validator identity: "
<< toBase58(
TokenType::NodePublic,

                          *validatorKeys_.masterPublicKey);

                          *validatorKeys_.getMasterPublicKey());

The optional returning getter functions really miss the point of why the
three keys were gathered together into a single optional. If I'm not
confident that an optional I'm about to dereference is unseated I need to
check that optional -- does it have a value or not?
This function is not making that check. But it could make that check by
replacing the code on line 101 with...
if (validatorKeys_.keys)

If you make that single change they you can be confident that every time
you dereference any of the keys in validatorKeys_.keys there is a valid
key to access.
With the added getter function I'm back to not knowing whether the
returned value is useable. I should check the return value every time.
So I suggest that you remove the getter functions for two reasons:

They hide the fact that a single check will let me know that all (or
none) of the keys are valid.
Notice that ValidatorKeys has a bunch of public data members.
Embrace that. Go ahead and access the public data members as data members.

Does that make sense? It's possible I missed something. I'm open to being
wrong.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*pullrequestreview-1561794763__;Iw!!PZTMFYE!5M7yWugj9lZGIdANUq_dIy6g1tt-tb9qQGmaXwWXl0guoI4Y-N89ukBKjLpSwGW4UkqJTTR1a7_CbTGAOcNoocg2rQ$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AFB4TNM3DILL4JHNDLOY7I3XTQIW3ANCNFSM6AAAAAAZ43VWPQ__;!!PZTMFYE!5M7yWugj9lZGIdANUq_dIy6g1tt-tb9qQGmaXwWXl0guoI4Y-N89ukBKjLpSwGW4UkqJTTR1a7_CbTGAOcOvNq7B8w$
.
You are receiving this because you were assigned.Message ID:
@.***>

Thank you very much, I'll work on this tomorrow
Regards,
Keshava
On Wed, Aug 9, 2023 at 4:28 PM Scott Schurr @.***>
wrote:

@.**** commented on this pull request.
Your most recent changes regarding the optional in ValidatorKeys look
good to me. Nice work.
This is another partial review. I'm not done yet, but I wanted to get
these suggested changes to you before I leave for PTO.
In src/ripple/app/main/Application.cpp
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*discussion_r1286492055__;Iw!!PZTMFYE!5MegXq10PCh7U2wukkLXLgmRhYWWmYwwcNxX-32hxmC_0V5exwFibIAhFmMxSHsLohRbRzZFy_wqdGcDvvOpcSNKcw$
:

   // do not use the getter function from ValidatorKeys class because

   // const& is returned from this function

I think the comment here no longer applies. The comment should probably be
removed.
In src/ripple/app/main/Application.cpp
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*discussion_r1289329172__;Iw!!PZTMFYE!5MegXq10PCh7U2wukkLXLgmRhYWWmYwwcNxX-32hxmC_0V5exwFibIAhFmMxSHsLohRbRzZFy_wqdGcDvvPVz-gwYQ$
:

@@ -584,7 +584,7 @@ class ApplicationImp : public Application, public BasicApp
return *m_jobQueue;
}

std::pair<PublicKey, SecretKey> const&

std::optional<std::pair<PublicKey, SecretKey>> const&
nodeIdentity() override

Changing Application::nodeIdentity() to return an optional, is a problem
for all callers of nodeIdentity(). To safely use the new interface every
caller needs to check whether the optional is unseated before using it.
And, by the way, most of the places that were "fixed" to use the new
interface don't verify that the optional has a valid value. In my opinion
that's bad programming practice.
So I dug into the question. It turns out that the nodeIdentity is not
actually optional. It's always available shortly after the Application is
constructed. So the window where the nodeIdentity is unknown is very
short. And currently there are no callers of nodeIdentity() before the
value is known.
This leaves us in a place where we can say that calling nodeIdentity too
early in the boot process is a programming error. In fact, I think it's a
good idea to treat it like that.
With that in mind, I suggest that the nodeIdentity implementation be
changed to look like this:
std::pair<PublicKey, SecretKey> const&
nodeIdentity() override
{
    if (nodeIdentity_)
        return *nodeIdentity_;

    LogicError(
        "Accessing Application::nodeIdentity() before it is initialized.");
}

A LogicError has the effect of crashing the server with a good error
message. If the server is early in the boot process then crashing is often
a better choice that throwing an exception or just writing to the log.
Thoughts?
In src/ripple/app/consensus/RCLConsensus.cpp
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*discussion_r1289342420__;Iw!!PZTMFYE!5MegXq10PCh7U2wukkLXLgmRhYWWmYwwcNxX-32hxmC_0V5exwFibIAhFmMxSHsLohRbRzZFy_wqdGcDvvPv3HgG0Q$
:

@@ -799,10 +808,17 @@ RCLConsensus::Adaptor::validate(
validationTime = lastValidationTime_ + 1s;
lastValidationTime_ = validationTime;

if(!validatorKeys_.keys)
{

   JLOG(j_.fatal()) << "RCLConsensus::Adaptor::validate: ValidatorKeys "

This should become the same logging level as is chosen on line 216.
In src/ripple/app/consensus/RCLConsensus.cpp
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*discussion_r1289342450__;Iw!!PZTMFYE!5MegXq10PCh7U2wukkLXLgmRhYWWmYwwcNxX-32hxmC_0V5exwFibIAhFmMxSHsLohRbRzZFy_wqdGcDvvNKI_Wjgg$
:

@@ -210,12 +210,21 @@ RCLConsensus::Adaptor::propose(RCLCxPeerPos::Proposal const& proposal)
proposal.prevLedger().begin(), proposal.prevLedger().size());
prop.set_proposeseq(proposal.proposeSeq());
prop.set_closetime(proposal.closeTime().time_since_epoch().count());

if(!validatorKeys_.keys)
{

   JLOG(j_.fatal()) << "RCLConsensus::Adaptor::propose: ValidatorKeys "

I think that logging this as fatal() is overkill. I suggest error() or
even warn(). If a bug gets in that triggers this message then the logs
will be swamped with this log message. At fatal() level it is hard to
remove the message. And the recovery, simply returning, is benign.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/XRPLF/rippled/pull/4607*pullrequestreview-1566313966__;Iw!!PZTMFYE!5MegXq10PCh7U2wukkLXLgmRhYWWmYwwcNxX-32hxmC_0V5exwFibIAhFmMxSHsLohRbRzZFy_wqdGcDvvPmGwCm4g$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AFB4TNODJSMPQ456V5VF7X3XUQMILANCNFSM6AAAAAAZ43VWPQ__;!!PZTMFYE!5MegXq10PCh7U2wukkLXLgmRhYWWmYwwcNxX-32hxmC_0V5exwFibIAhFmMxSHsLohRbRzZFy_wqdGcDvvNt90aLyg$
.
You are receiving this because you were assigned.Message ID:
@.***>

thanks @scottschurr  I have address your recent comments

@ximinez  thanks for your comments, I have addressed them in 3bd70664ab94236c015f2876cd3c4dbc362e45e5
(except for the one about the assert statement)

thanks @ximinez  I have addressed the recent batch of comments 👍

@ximinez  thanks a lot for your detailed comments. I have addressed them in afa642506a5abc8896aff8f85ea260fd0971f96c

I notice the debug builds are still failing.

@ximinez  I've updated the unit tests to fix the failing builds. I'm surprised that the other platforms did not catch these failures!

@ximinez I have addressed your comments, thanks for your suggestions.
Apologies for missing the earlier review, it slipped my mind.

@ximinez @scottschurr Hello, thank you for looking into this PR. I believe I have addressed all the comments, please review it at your leisure. thanks!

thanks for your feedback @ximinez !

hello @scottschurr , would you be able to review this PR? thanks!

note: this is on Scott S's to-review list

awaiting update or reply from @ckeshava

@scottschurr I have addressed your comments

@scottschurr No, you are correct in saying that all the PublisherList's need to be available for good == true, including the localPublisherList.
The localPublisherList is set at https://github.com/ckeshava/rippled/blob/8aada82e2f7e1c3d37e79b3310eead77fe906cac/src/ripple/app/misc/impl/ValidatorList.cpp#L236
Note, the validUntil field is set to a very large value at line 244. (This is conditional on the non-emptiness of the local publisher list.)
If the local configuration file does not specify a [validators] section, then localPublisherList.list.empty() == true. This maintains the invariant that all the locally configured PublisherList's are perennially available.
I hope this clears things up

addressed all of your comments

@scottschurr and/or @ckeshava : for feedback that has been addressed, feel free to use the Resolve conversation button.
I think Option+click (or Alt+click on Windows/Linux) on Show resolved will expand/collapse all resolved conversations.

@scottschurr  I have incorporated your suggestions for the comment in ValidatorList.cpp file. thanks

Suggested commit message:
Remove default ctors from SecretKey and PublicKey: (#4607)

* It is now an invariant that all constructed Public Keys are valid, non-empty and contain 33 bytes of data.
* Additionally, the memory footprint of the PublicKey class is reduced. The size_ data member is declared as static.
* Fixes #2942

@ckeshava This PR has been through a lot of changes. Feel free to provide additional details that you think might be important.

Distinguish and identify the PublisherList retrieved from the local config file, versus the ones obtained from other validators.

I'd add this line in the commit message ^^
@ximinez  thanks for help, I couldn't have completed this PR without your contributions
@scottschurr  thanks for your comments scott, you helped point out important mistakes in the PR!


The test/test.css file has the wrong path for index.css

It should be ../index.css.  This fixes the other issues.

Fixed in https://github.com/suitcss/utils-text/commit/96223f6862be26059623ec6bdd1b64dc2da64881


failed to annotate 14:g.67664853del

https://www.genomenexus.org/variant/14:g.67664853del
https://www.cbioportal.org/results/mutations?Action=Submit&cancer_study_list=stad_tcga_pan_can_atlas_2018&case_set_id=stad_tcga_pan_can_atlas_2018_all&gene_list=FAM71D&tab_index=tab_visualize

@jjgao It seems fine for me, could you add a screenshot with the failed page?


Spell check all the things!

There's likely a boat full of spelling errors and grammatical atrocities in the code - log messages, doc strings and comments all need to be reviewed.
Feel free to contribute!

@schamp , cool. cool cool cool.
One thing: make sure you do this on the release branch!
cheers,
Nils

Kindly review PR #90  on spell check.

I wanted to do this

I have opened a new PR #93 on branch realease-2.0.0. You could check it.
Regards
Haripal


Async methods

Allow Async rank method as part of the baseranker

Thank you for taking this into your own hands! It's included in release 0.2.0


Wrong file name?

Thank you so much for all these explanations! I'm not really sure, but I think this might be a wrong filename? And should actually be a svelte route?!

Again, thanks so much!

Thank you! 😄

Nothing to thank for haha! Thank you:) I started my website, just because of this video;)


provide a way to refresh credentials

error: You must be logged in to the server (Unauthorized)

also, we shouldn't hide the output of the gcloud commands, as they sometimes ask for auth.

also, we shouldn't hide the output of the gcloud commands, as they sometimes ask for auth.

kctf config load (name)

works for reauth but it's not always working because we hide the stdout

kctf config load (name)

works for reauth but it's not always working because we hide the stdout

this is really annoying :P

this is really annoying :P


Extension Developer: Custom 'when' clauses for keyboard bindings & menus

I have come across the when property for KeyBindings & Menus in the Contribution points in the package.json file of my extension, but I would love to be able to based inside some logic of my extension to enable/disable showing & hiding certain menu options.
https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts
I could achieve this with a configuration but this seems wrong & a bit hacky for my situation, as I would not want the user to configure this value.
"configuration": {
    "type": "object",
    "title": "IIS Express Settings",
    "properties": {
        "iisexpress.serverRunning": {
            "type": "boolean",
            "default": false,
            "description": "This property is not to be set or used in settings.config its just used to display the correct menu items if the server is running or not"
        }
    }
}

So in my extension I could update the config value when IIS Express Server is running so that the Restart & Stop Server commands are only visible in the menu & keyboard bindings etc.
Can I suggest some form of API to allow the when property to work with some developer defined boolean that could be toggled from the extension developers codebase

There is an API-command which allows you set a context key. See https://github.com/Microsoft/vscode/issues/10471#issuecomment-239764839.
Closing this as of #10471 which should be considered for April


convert parallel tests into pytest

There's a pytest mpi plugin!.
Refactor current parallel tests to standard pytest structured test file. Add explicit functions to be invoked only when run using mpi.

that plugin was not useable


Don't use other module's functions and constants in long loops

Is your feature request related to a problem? Please describe.
This is from https://github.com/ChainSafe/lodestar/pull/3178#issue-996944825
If we use functions and constants of other modules in a for loop, tsc would compile it from
for (let i = 0; i < statuses.length; i++) {
    const status = statuses[i];
    if (hasMarkers(status.flags, FLAG_ELIGIBLE_ATTESTER)) {

to
for (let i = 0; i < statuses.length; i++) {
        const status = statuses[i];
        if ((0, util_1.hasMarkers)(status.flags, util_1.FLAG_ELIGIBLE_ATTESTER)) {
            let inactivityScore = inactivityScores[i];

as we can see, it keeps accesing util_1.* in a for loop and it makes the code slow, we should instead import functions/constants outside of the for loop
// this avoids importing FLAG_ELIGIBLE_ATTESTER inside the for loop, check the compiled code
    const { FLAG_ELIGIBLE_ATTESTER, FLAG_PREV_TARGET_ATTESTER_OR_UNSLASHED, hasMarkers } = constants;
    for (let i = 0; i < statuses.length; i++) {
        const status = statuses[i];
        if (hasMarkers(status.flags, FLAG_ELIGIBLE_ATTESTER)) {

in the case of processInactivityUpdates, this gives a 10% improvement
Describe the solution you'd like
We should apply the same fix to other places in beacon-state-transition and check the performance gain there

Beacon state transition has been reviewed in depth, fixing multiple issues including this one


Create Dialogues Content Database Backend

Should have :
DynamoDB search based on :

[x] Characters names in a scene (sort on presence of string in a list)
[x] Text content in dialogues

DynamoDB sorting based on :

[x] Date of creation (sort timestamp)
[x] Date of last modification (sort timestamp)
[x] Section Instance Id (sort on an int/id)
[ ] Status (possibility to have as much custom status as possible, like "in_writing", or "need_to_be_record" or "need_to_be_edited" etc) (sort on string or int/id that represent the status)

Other things :

[x] Update content in the database when its modified in the interface
[x] Update lastModifiedTimestamp when a content element is modified
[x] Core Botpress to Inoft Vocal Engine conversion
[x] Interface in the menus to import data from Botpress to the Inoft Vocal Engine
[ ] Give a warning when importing data and possibility to keep existing or override data if the Ids of some elements are conflicting
[ ] Delete data from database in the interface (half delete, keep in "archive mode", and keep in database with a special status)

Modified the Database Client in order to have it create the secondary indexes in a DynamoDB table

These functionalities have been moved to the inoft_vocal_engine, and are not for the inoft_vocal_framework (i'm just finishing up all the capabilities for this issue)


chore(debug-config): remove default logger and implement logger by namespace

:tada: This PR is included in version 4.15.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


fix(env): Remove section about having to use dotenv to use env vars in code

.env file is automatically loaded, so no dotenv needed.
closes https://github.com/prisma/prisma/issues/19519

The removal is correct, but I am not sure this closes the mentioned issue? The person is complaining that Prisma Client loads and pollutes their env although it shouldn't.

Yes, as you say we have other issues about that. This user was mostly misguided by the docs that tell them otherwise - so fixing the docs solves their immediate complaint.


DCM Floodlight doc

Description of the change
Created new doc for DCM Floodlight integration
Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ]  This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

Let's show + ADD MORE option too in dcm-floodlight-connection-settings2.png

All the suggestions are now incorporated. LMK if we're good to go, @akashrpo @utsabc

Things are looking good but we are exposing the advertiserId as this is a customer's account lets censor it


Can't contact LDAP server

After following instructions i've got this output:
https://gist.github.com/errst/43bbb3179ed29d00e30c88d9deb71e53
Specific detail:
ldap_sasl_bind(SIMPLE): Can't contact LDAP server (-1)
ERROR: Service 'ldap' failed to build: The command '/bin/sh -c useradd ldapadmin     && rm -fr /var/lock /usr/lib/systemd/system     && sed -i 's/checkHostname {/checkHostname {\nreturn();/g' /usr/lib64/dirsrv/perl/DSUtil.pm     && sed -i 's/updateSelinuxPolicy($inf);//g' /usr/lib64/dirsrv/perl/*     && sed -i '/if (@errs = startServer($inf))/,/}/d' /usr/lib64/dirsrv/perl/*     && setup-ds.pl --silent --file /ds-setup.inf     && /usr/sbin/ns-slapd -D /etc/dirsrv/slapd-dir     && sleep 3     && ldapadd -H ldap:/// -f /users.ldif -x -D "cn=Directory Manager" -w password' returned a non-zero code: 255
How can i achieve this issue? Thanks.

Something changed with 389-ds and it takes longer than 3 seconds to start now. I've updated the code in other places to be more dynamic but missed this reference.

This should be fixed now. I did a direct update, so I might have missed something. Please pull again and restart it. Then let me know how it goes. IF something does break, the last screen or two of logging should be sufficient. Thanks.

@jtgasper3 awesome, it worked. thanks.


Could not find or load main class org.gradle.wrapper.GradleWrapperMain

when i execute the command react-native run-android i gets this error
System:
OS: Windows 10
CPU: (8) x64 Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz
Memory: 3.02 GB / 7.86 GB
Binaries:
Node: 10.16.1 - C:\Program Files\nodejs\node.EXE
Yarn: 1.16.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.9.0 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version  <IP_ADDRESS> AI-183.6<IP_ADDRESS>22156
Steps To Reproduce
1.react-native init demo and cd demo
2.react-native run-android
Expected
It should install and run on device.
 Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081
The system cannot find the path specified.
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain

It was working absolutely fine before but as I created a new project from then i am getting this error.

In my case, I try many way people share but still not work
so:

I reboot my computer,
clear cache of user/admin/.gradle
remove and reinstall C:/Gradle
rename project folder to a normal name.

I don't know what make it run. but it work :)))


Run pip-compile for Each Extra

closes #21

You can see it running working here: https://github.com/WIPACrepo/MQClient/pull/50


This is not issue just query

Is this autoscaler scales only memory or scale cpu & disk
Regards
Abhilash S

is your question scaling based on  memory/cpu/disk, or scale the CPU/DISK allocation to app ?

Hi @boyang9527 thanks for your response, i mean is this autoscaler will scale memory/cpu/disk and allocate memorycpu/disk if resources or not enough for application running in a container. For example i am running application it is out of disk or more cpu core it will collect the cpu or disk or memory metrics and detect that cpu or disk or memory is out of resources then it will auto scale and allocate the resources ?????

Now we only support memory based scaling, i.e. collect memory usage and change the number of application instances based on the user defined policy.  We are working on the support of scaling based on response time and throughput(RPS).
CPU is shared among the containers in the same DEA/CELL, so it is problematic if we scale based on CPU.  We will reconsider this given there is a new feature in Garden that we can set CPU limit for each container.
Cloud Foundry application usually is not disk IO intensive, so we don't support scaling based on disk usage,  though the implementation is general enough to support any type of metric. Let us know if you have any use cases requesting this feature... so far it is not a priority in backlog.
By the way,  the scaling we talk about here is horizontal scaling. When scaling out, more instances will be added, while the  instances will have the same memory/disk allocation.

Hi @boyang9527  thanks for your information i agree with your discussion regarding disk scaling. Thank you for considering CPU scaling as a feature.


Connection pooling seems to be broken

We have this object from which we are fetching our queryEvaluator
object MyDataSource {
val queryFactory = new SqlQueryFactory
val apachePoolingDatabaseFactory = new ApachePoolingDatabaseFactory(
"SELECT 1",
10,
10,
new Duration(1000),
new Duration(10),
true,
new Duration(30000))
val queryEvaluatorFactory = new StandardQueryEvaluatorFactory(apachePoolingDatabaseFactory, queryFactory)
val queryEvaluator = queryEvaluatorFactory(dbConfig.driverClassName, dbConfig.url, dbConfig.username, dbConfig.password)
}
We are not explicitly closing connections, assuming that it is handled. We seem to be running out of connections on our MySQL db.
We are using the following dependencies
libraryDependencies += "com.twitter" % "querulous" % "1.2.0-generic"
libraryDependencies += "mysql" % "mysql-connector-java" % "5.1.12"

tsuna are you using scala 2.8.x or 2.9x. Did you recompile querulous 2.5.0 to work with 2.9.x?

I'm using querulous-core-2.5.0.jar downloaded by SBT from Twitter's Maven repo, in conjunction with Scala 2.8.1, Finagle 1.9.5, mysql-connector-java 5.1.13, commons-pool-1.5.4.jar, and commons-dbcp-1.4.jar.

Halp!  :)
Am I doing something obviously wrong?  Maybe I shouldn't be getting a new QueryEvaluator for each query?
This issue is a show stopper for me right now :(

also i seem to be getting the same MyDataSource.queryEvaluator still the issue.

I added some print statements in ApachePoolingDatabase in open() and close(), they're both called.  According to the dbcp javadoc this is the right thing to do as close is supposed to return the connection to the pool.
I think either Querulous isn't using Apache's DBCP API properly, or there's a problem in Apache's code.  All these layers of factories are giving me a nausea, I think I'll look at using another simpler connection pooling library or write my own.

This has been fixed, I believe, in the most recent versions. I ran into this issue a few weeks ago and fixed a race condition in FuturePool.


Please don't mutate package.json

Description
I'm using Yarn and using yarn patch to patch packages, but your postinstall script keeps adding patch-package to my scripts.
Problem Statement
Please don't mutate the package.json, or at least provide a way to disable this behavior.
Proposed Solution or API
Just ask users to edit it manually.
Alternatives
No response
Additional Information
No response

My app is not working after modifying package.json
I changed my babel and webpack configuration and managed to launch the app, but not all the components work, eg the menu:
MenuItem.tsx:62 Uncaught TypeError: Cannot read properties of undefined (reading 'children')     at MenuItem (MenuItem.tsx:62:11)     at renderWithHooks (react-dom.development.js:16305:1)     at mountIndeterminateComponent (react-dom.development.js:20074:1)     at beginWork (react-dom.development.js:21587:1)     at beginWork$1 (react-dom.development.js:27426:1)     at performUnitOfWork (react-dom.development.js:26557:1)     at workLoopSync (react-dom.development.js:26466:1)     at renderRootSync (react-dom.development.js:26434:1)     at recoverFromConcurrentError (react-dom.development.js:25850:1)     at performSyncWorkOnRoot (

@FezVrasta, you can shift to @gluestack-ui/nativewind-utils@alpha that way you can avoid change in package.json. Soon this will come to stable version.

@DennisHesler Please create a another issue with repo.

@FezVrasta, you can shift to @gluestack-ui/nativewind-utils@alpha that way you can avoid change in package.json. Soon this will come to stable version.

Does this still require patching the other packages or it works with the non-patched dependencies?


Fix bug: isSymbolReferencedInFile should return true for shorthand property assignment

Fixes #23308

We have the same issue with exportspecifiers..
import { abc } from "./bar";

export { abc };


Basic Navigation Server example doesn't work

Tested versions
v4.1.2.stable.mono.official [399c9dc39]
System information
Windows 10 - 4.1.20 stable mono win 64 - Forward + - Vulcan api
Issue description
Tried to get the basic navigation server example to work in C# but it wouldn't produce a viable path.
Steps to reproduce
Just run this. Included the original gd script as well.
using System.Linq;
using Godot;
using Godot.Collections;

public partial class server_gen : Node3D {
    private Rid? map;

    // Called when the node enters the scene tree for the first time.
    public override void _Ready() {
    }

    // Called every frame. 'delta' is the elapsed time since the previous frame.
    public override void _Process(double delta) {
        CallDeferred(server_gen.MethodName.GenerateMeshWithServer);
    }

    public override void _PhysicsProcess(double delta) {
        Dosomething();
    }

    public void GenerateMeshWithServer() {
        if (!map.HasValue) {
            NavigationServer3D.SetDebugEnabled(true);
            var navMesh = new NavigationMesh() {
                AgentHeight = 1,
                AgentRadius = 1,
                CellSize = 0.25f,
                GeometrySourceGroupName = "map",
                GeometrySourceGeometryMode = NavigationMesh.SourceGeometryMode.GroupsWithChildren,
                GeometryParsedGeometryType = NavigationMesh.ParsedGeometryType.StaticColliders,
            };

            var navigationMap = NavigationServer3D.MapCreate();
            NavigationServer3D.MapSetUp(navigationMap, Vector3.Up);
            NavigationServer3D.MapSetActive(navigationMap, true);

            var region = NavigationServer3D.RegionCreate();
            NavigationServer3D.RegionSetTransform(region, Transform3D.Identity);
            NavigationServer3D.RegionSetMap(region, navigationMap);

            navMesh = new NavigationMesh();
            navMesh.Vertices = new[] {
                new Vector3(0, 0, 0),
                new Vector3(9.0f, 0, 0),
                new Vector3(0, 0, 9.0f)
            };
            var x = (new[] { 0, 1, 2 }).Select(v=>Variant.From(v));
            navMesh.Polygons = new Array(x);

            NavigationServer3D.RegionSetNavigationMesh(region, navMesh);

            map = navigationMap;
            //GetTree().PhysicsFrame += Dosomething;
        }
    }

    private void Dosomething() {
        var start_position = new Vector3(0.1f, 0.0f, 0.1f);
        var target_position = new Vector3(1.0f, 0f, 1.0f);
        var     optimize_path = true;

        var path = NavigationServer3D.MapGetPath(
            map!.Value,
            start_position,
            target_position,
            false
        );

        var pathPoints = new Vector3[path.Length];
        for (int i = 0; i < path.Length; i++) {
            pathPoints[i] = path[i];
        }

        GD.Print("Path points: " + string.Join(", ", pathPoints));
    }
}

Minimal reproduction project (MRP)
MinimalProject.zip

What version are you on? 4.1.20 does not exist

What version are you on? 4.1.20 does not exist

v4.1.2.stable.mono.official [399c9dc39]

Can you please try this with a supported version, like 4.1.3 (only the latest patch version is supported, and it might already be fixed)

@AThousandShips  Does 4.2 support it as well?

Yes, testing with 4.2.1 would be appreciated as well 🙂, this was just to say that 4.1.2 isn't supported

Please try with GDscript first and if GDScript works and only C# doesn't double check all your C# types.
I am not a C# user so I can not tell you what is wrong with this C# code but it has been a common pattern in the recent past with C# specific navigation bugs that the wrong C# types where used so data arrays, especially the PackedArrays, got converted into empty arrays.

Yes, testing with 4.2.1 would be appreciated as well 🙂, this was just to say that 4.1.2 isn't supported

@AThousandShips Tried the same with

Server_gen.gd works as expected while server_gen.cs doesn't produce a path.

Please try with GDscript first and if GDScript works and only C# doesn't double check all your C# types.
I am not a C# user so I can not tell you what is wrong with this C# code but it has been a common pattern in the recent past with C# specific navigation bugs that the wrong C# types were used so data arrays, especially the PackedArrays, got converted into empty arrays.

@smix8  Shouldn't the documentation in this case also provide a proper barebones C# example? If that is not possible at this point, having someone familiar with the C# API provide guidelines would be useful

Anyone is welcome to write that code 🙂, we however do not require the C# code to be written when adding new documentation information as most people are more familiar with GDScript

@Akamitori
The problem of "not enough C# documentation. examples and support" is well known but a collective duty of the C# using community to fix.

Needs a C# user to verify or to convert example.

Closing as a C# version of that script exists in the documentation.


[conf] Make Gunicorn worker timeout and graceful timeout configurable

What changes were proposed in this pull request?
Add config option for gunicorn server
How was this patch tested?
maunal
Please review Hue Contributing Guide before opening a pull request.

LGTM!

Add these configs in hue.ini and pseudo_distributed.tmpl?

Added, thanks for the catch.


Update sparse_linalg_lobpcg.py

Update sparse_linalg_lobpcg.py to make it more reasonable and recent
Reference issue
Closes [gh-18568]
What does this implement/fix?
Change the examples to make more sense, e.g., use the tests that actually converge, although not checking the convergence

Does anyone know why circle-ci bench no longer runs?

Benchmarks are run with CircleCI and should always run. I am not sure why in this case CircleCI did not run though 🤷♂
The relevant config starts here:
https://github.com/scipy/scipy/blob/4bf18d332455f498b760e62657d8203d61b3c496/.circleci/config.yml#L135
@lobpcg please can you name properly your commit (and edit the title of your PR too)? For anyone having a look, it's difficult to see what is done. I remember you said you use VSCode, you should be able to change the "title" of the commit. I suppose you are only updating the message part.

For anyone having a look, it's difficult to see what is done.

Yeah, I had the same issue in #17675 until I saw that the description is below the main commit message (that is what should be the main commit message; the "update " is irrelevant, or actively detrimental).

Benchmarks are run with CircleCI and should always run. I am not sure why in this case CircleCI did not run though 🤷♂

Thanks for chiming in @tupui. If this keeps happening I guess we'll have to open an issue to investigate more thoroughly...

Benchmarks are run with CircleCI and should always run. I am not sure why in this case CircleCI did not run though 🤷♂

Thanks for chiming in @tupui. If this keeps happening I guess we'll have to open an issue to investigate more thoroughly...

@h-vetinari @tupui  CircleCI is surely a must in this PR that only edits a benchmark...

Maybe it's because of the draft mode?? But I thought I recalled seeing draft PRs running on CircleCI. Maybe something changed there.

Maybe it's because of the draft mode?? But I thought I recalled seeing draft PRs running on CircleCI. Maybe something changed there.

I only turned the draft mode today. It was not working prior to that too.

It seems CircleCI as a whole isn't running in this PR...? 🤔

Please help to make cicrle-ci running!
I have logged in to
https://app.circleci.com/pipelines/github/lobpcg/scipy
but do not know how to use it - maybe I need to configure it somehow? Or is it independent from the scipy repo one?

There is nothing to do on your side.
I don't know what is happening here to be honest. What you could try is to make another PR... it's really never happening.

No circle-ci in the new PR too, https://github.com/scipy/scipy/pull/18874 :-(

I have no clue sorry... I am not seeing everything on CircleCI so there is not much more I can do. @rgommers would you know why CircleCI is not being run there?

I can't find anything in CI config, repo settings or CI logs that seems related. I pushed a commit merging with main to see if that would trigger, but it doesn't. So I really have no idea. @lobpcg it shouldn't block merging this PR when it's ready - I am happy to verify it locally.

Since I only modify the benchmark (and move a few functions from it to _special_matrices.py) the only helpful ci is circle-ci, the one running the benchmarks and the one producing the documentation. I cannot run them locally without a very major effort.
At some point during my previous PR editing someone suggested that I configure and run cirle-ci myself rather than using the scipy quota, so I logged in to https://app.circleci.com/pipelines/github/lobpcg/scipy not really knowing what I am doing. Maybe this prevents the default scipy circle-ci running?
It appears that I may be able to start circle-ci manually from https://app.circleci.com/pipelines/github/lobpcg/scipy ...

Ah yes, that could be it. I've read that this is an issue CircleCI is picking up your fork instead. So yes maybe removing all that would help.
You can also run the benchmarks locally and post results here.

While waiting for reviews I am trying to add a new special matrix - the Laplacain, to be used in benchmarking and examples

One thing to consider is that adding to the public API (ie linalg) will probably make it much harder to find a reviewer as things then have to be reviewed far more rigorously. For the sake of not holding up the benchmark improvements, you might be best putting the code you have written for generating special matrices in the benchmark file. Once this is merged you can raise an issue explaining why these should have a spot in the public api.

While waiting for reviews I am trying to add a new special matrix - the Laplacain, to be used in benchmarking and examples

Since this PR is seeing regular commits, it was not obvious to me that at all that it's ready for review.
Where are you considering to add this Laplacian? If it's benchmark-only then it might still work for this PR, but otherwise it sounds like we should keep those things separate

@j-bowhay @h-vetinari I have opened the PR for review from @larsoner and @ilayn 3 days ago and have only made one (although it took a few commits) stylistic improvement to the 2 modified examples. This PR is waiting for review.
My previous similar PR has taken several months to get reviews, so the normal practice of incremental PRs does not quite work in my case and instead I try to put more beef in every single PR. I would be happy to remove the yet unfinished new example - the Laplacian - and move the 2 modified examples back to benchmarking from the public linalg temporarily postponing these changes to subsequent PRs, if the reviews of this PR could be made timely so that I could make all these subsequent PR within a reasonable time frame. But I cannot afford waiting months for every PR in a sequence.  So many bugs so little time.

@lobpcg as we discussed before in those PRs, I think the most optimal way is to somehow get your system to be able to compile and test the code on your local system. Otherwise we have to rely on Github CI/CD infrastructure which is making things quite difficult for all parties because like yourself we also have quite limited time and it becomes very difficult to watch you modify files manually probably here. Then you can catch the mistakes much easier and at your own convenience by running the tiny percent of the test suite without waiting 30 mins each time for the possible failures.
Please let me know if you need any support or guidance and we would be happy to help you with it here or offline. That would cut down the review time significantly.

@ilayn thank you for your kind offer to help! Yes, I run MS Win 11 with MS libraries and compilers, typically unsupported by open source. My last attempt has been to install the benchmark locally only to find out that it requires configuring an interface to BLAS/LAPACK, which I do have locally, but unable to find any documentation how to configure in benchmark, so give up. I have no access to any Linux, and installing/maintaining cygwin or a separate Linux instance may not worth the time only for my occasional PRs.
Unable to run benchmarking locally, it makes little sense to keep a local fork either, so in this PR, I edit files directly using GitHub web interface. It makes commits very messy, so reviewers cannot see well the history and need to review only the current snapshot, indeed. I try minimizing other inconveniences to scipy maintainers, using [skip azp] [skip actions] [skip cirrus] on most of my commits and currently running my own https://app.circleci.com/pipelines/github/lobpcg/scipy?branch=patch-1 (which I thought was free credits but now I see they want to charge me $ 165.00 for this month...).
The bottom line is that I am unsure how to improve my setup without wasting too much time.

I have updated the PR description to more fully describe the changes. Could someone please review this PR?

I think mixing the benchmark clean up with new matrices is not a good idea. The benchmark fixes would probably mergeable much more quickly.
Using a class-based design would be a first in the special matrices module, and would need a very compelling reason for using a very different API.

@h-vetinari As I have already written above, I am OK with splitting this PR into 2 parts: benchmark fixes with matrices defined privately in benchmarks and moving the matrix definitions from benchmark to public special matrices, if necessary. And adding the Laplacian matrix (already committed) and benchmark (finished but not yet committed) on the top of that as a 3d PR. Only takes more of my time and drags this for (much?) longer.

Only takes more of my time and drags this for (much?) longer since all these 3 hypothetical PRs need to be done sequentially one after the other as far as I can see.

That's not true. The more straight-forward the PR, the faster it can get merged. Many unrelated changes in a single PR slow down review, not speed it up (even moreso if you're introducing fundamentally different APIs).
Also, most of the people here work on scipy purely as volunteers; while we try to be quick, it can happen that things take a while.

@h-vetinari OK. Should I wait for another reviewer to concur with your request to split this PR into 3 parts, if I interpret your request correctly, or just make the change? Or maybe I should preferably start a new clean PR with phase 1 - just benchmarking fixes with only the benchmarking module involved? Turning this one into "in progress" so far?

I concur with @h-vetinari's request to split this into 3 PRs. There's precedent for large PRs to remain open for years due to lack of reviewer bandwidth. In my experience, time to review can scale non-linearly with the size of the PR.
Also, @lobpcg, if you're having trouble getting a dev environment set up, have you considered using a bootable usb linux install? Someone could probably set one up for you that already has a SciPy dev environment configured. You would just have to install it to a usb drive and could boot from that without having to install Linux on one of your machines.

All activity gets transferred to https://github.com/scipy/scipy/pull/18954. I'll keep this one as a draft until everything is done.

Also, @lobpcg, if you're having trouble getting a dev environment set up, have you considered using a bootable usb linux install? Someone could probably set one up for you that already has a SciPy dev environment configured. You would just have to install it to a usb drive and could boot from that without having to install Linux on one of your machines.

@steppi @ilayn yes, I think that it could be useful not only for me but in general to have a public bootable image with everything needed pre-installed to be booted into locally or/and on one of popular cloud providers, may be a quick tune if needed of one of already available free public images with dev tools.

@lobpcg Another possibility is to use github code spaces. We have instructions for that here https://scipy.github.io/devdocs/dev/dev_quickstart.html#other-workflows . The downside being your account only has limited number of free hours


Make TestLauncher be able to run tasks along with tests

@bot-gradle test RFM

@bot-gradle test RFM

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test RFM

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test RFM

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test rfm

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test rfm

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

OK, I've already triggered a build for you.

@bot-gradle cancel

Your PR is queued. See the queue page for details.

@bot-gradle test and merge

OK, I've already cancelled the pre-tested commit build.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge


Laravel deploy task should not call cache:clear

Q
A

Bug fix?
Yes

New feature?
No

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

cache:clear command will clear users' sessions if CACHE_DRIVER is the same as SESSION_DRIVER, I think users should call this task on demand instead of putting it in default deploy task.

ping @lasselehtinen @lucasmezencio

I think you're right @leo108..
LGTM @antonmedv.
Pull the trigger! 🙂

Please update changelog

@antonmedv Updated

@lasselehtinen sorry for distracting.

Imho you woud usually want to clear the cache upon deployments. I understand your issue, but you should split your redis cache database from the other redis databases (sessions, queues etc). This is the default for new 5.7 installs, see https://github.com/laravel/laravel/pull/4665

@antonmedv — i think the behaviour here should be that a cache clear is part of the recipe by default — as mentioned by @barryvdh , this is now the default in v5.7 installs, and can be configured by the user in earlier releases.
Flushing the cache during a deployment is what i would consider as expected behaviour — if you have your caches + sessions in the same location (ie: on the same redis db), then this is a bug in the setup or cache clearing logic, rather than an issue with how deployer is operating.
FYI — Laravel's artisan cache:clear command describes the action as the following..
Flush the application cache