Quickstart notebbok: Run Multi-Agent DDPG System.

I was playing around with the quickstart notebook but having this error on  Run Multi-Agent DDPG System (I tried locally and on colab):
UnparsedFlagAccessError: Trying to access flag --lp_termination_notice_secs before flags were parsed.

Hi @jbakambana, thanks for pointing this out. This was related to an issue with an external library that we use for scaling https://github.com/deepmind/launchpad/issues/14 .
We have a PR out for this fix (https://github.com/instadeepai/Mava/pull/291). I will let you know when to test this again.

Hi @jbakambana, the PR for the fix has been merged. The notebook should work again now 😄
Please let us know if there are still any issues. Thanks again for pointing this out!

Hi @arnupretorius , thanks for your feedback. The notebook is working now on colab. But the problem remains when I tried with Desktop even though I reinstalled Mava.

@jbakambana Try printing out your version of launchpad like,  pip show dm-launchpad-nightly.
It should be 0.3.0.dev20210730. It it isn't, it means the re-install failed for some reason. Please confirm that you have the latest setup.py when you re-installed Mava?

I got this:   Version: 0.3.0.dev20210809.  How do I check for the setup.py file?
.

@jbakambana If you are on the develop branch, please do a pull from master (git pull). That should pull an updated setup.py file. Then after that, re-installing Mava should work.

Thank you @KaleabTessera it's ok now!

My recent PR retroduced this, I am fixing this to work with latest LP.

Looks fixed.


DropDownMenu can't set maxHeight

DropDownMenu can't set maxHeight and can't see scroll when there are many items.

Thanks @TanTan-TT This will be fixed soon with the SelectMenu component.
Dupe of #642


Add updated contribution guidelines

All changes must be done in a feature branch, no direct merges in master
Anything making a change to src/ must roll the version number and update CHANGELOG.md

Also assign the issue to yourself

And move the guidelines to the top, before the how to get started


bugfix timer queue processor, change history cache size from 1024 to 256

bugfix timer queue processor, change history cache size from 1024 to 256

Coverage increased (+0.009%) to 66.822% when pulling e2e60040bdcdfdafdab609def7d7ec82f07a4746 on bugfix into 8eaced5a5fc0d4cb10e99c1d0580fc2ef24120b8 on master.


Use a fixed and generic entrypoint for model.yaml/RDF in a package

This issue is brought up in https://github.com/bioimage-io/bioimage.io/pull/104, lets continue the discussion here:
@oeway  wrote:

We had some discussion a while about when we place the model yaml inside a package, we should rename it to model.yaml. The thing is we will need some kind of fixed entrypoint (a bit like the setup.py file of a python package and index.html page of a website), otherwise we will need to search within the package which is not always possible (e.g. on zenodo it will generate more requests). Plus, we don't want really multiple yaml in one package.

And now while working on other RDF file, I am even thinking we should perhaps rename model.yaml to something more generic, so we can also pacakge datasets, notebooks, applications, and share the same entry point yaml file name. I thought about config.yaml but then noticed it might be confusing since we have config key in the model.yaml. I would propose something like rdf.yaml, rdf.bioimage.io.yaml, or bioimage.io.yaml.

@constantinpape wrote:

I agree, we should update this so we have a unified entry point.
I suggest we discuss this in a separate issue in the spec repo.

I would propose something like rdf.yaml, rdf.bioimage.io.yaml, or bioimage.io.yaml.

Would all be fine with me.

This is now implemented as rdf.yaml.


Changing Relay query parameter causes remount of route's component

setting a query string such as
<Link to={{...this.props.location, query: { c: "new" } />

without having a route change, is re-mounting all the components for that route. Is this a bug?
This is specific to a query that I pass down as a variable using prepareParams. If I pass a query that isn't associate with relay, then it acts as expected

This question is more suitable for the react-router repository.


User::NonRoamableId missing details.

Hi,
Description of User::NonRoamableId here would use some details.
Like when it's guaranteed to stay the same and when not. From my observations:

It's different for the same user on different machines (that's understandable, it's nonroamable).
It seems to be different, when the same user logs in locally and remotely.
It seems to stay the same after the restart.
It seems to be different in each app for the same user on the same machine but.

Or if it's guaranteed to be different for two local users (i.e. not domain users) on different machines.
I was not sure whether I can use it to reliably identify the user or not, so I had to do all this tests myself.
Thanks,
J.

Thank you @jjakubovic for your feedback. @jwmsft, can you address this?
Thank you!

Thanks @jjakubovic, @ginami. I've updated the doc with more information and some example code.

Thanks!


what is the type 4 transaction，send all

I find type 4 transaction in explorer but I cant find this type in https://github.com/OmniLayer/spec
https://omniexplorer.info/tx/47660514c47783a791174ef33828c0ed566e136741664851a7dd06ef5e4ede2b#collapseAmountData

Hi @zhangdaoling,
the spec is incomplete and doesn't fully describe the protocol we use, because it has evolved faster than we kept up.
The sendall transaction type transfers all tokens from one ecosystem to a specified destination.


Development Roadmap

Hi @mikecao, thanks for the great project that you've contributed. It definitely helped a lot of software and website developers.
Just wondering whether is there a roadmap on what you have in mind for the direction of this software.
This will probably help on new users and engage contributors for specific directions.
Thanks and all the best.

There is no specific roadmap for features other than the enhancements and bug fixes on this board. But my goal is to keep the app as small and simple as possible. I don't want it to be bloated like... well Google Analytics.

To be honest, it's way better than other "simple" tools. I tried to install one very simple Google Analytics alternative claiming it was very small and efficient. It efficiently crashed my quite powerful VPS 3 times before I was able to discover the cause. Poor IT support...
Excellent job. It was very easy to install and setup, also it is not a resource hog. Browsing around it has all the stats needed without all that GA non-sense. Love it.

Thanks for the quick replies!


Test classes should be marked as final and internal

Description
CodeIgniter\Test\FeatureTestCase and CodeIgniter\Test\TestResponse were inadvertently marked as @internal because they are extending PHPUnit\Framework\TestCase. In order for these two not to be marked as final, I added the pseudo-PHPDoc @no-final. A permanent fix for this is to make these two as abstract classes as they are intended primarily to be extended by test classes, but that's beyond this PR.
Checklist:

[x] Securely signed commits

I read that wrong. TestResponse should not be abstract - CIUnitTestCase should be.

CIUnitTestCase is already abstract so it is not affected. TestResponse is extended by the deprecated FeatureResponse and probably other test classes too. Either we set TestResponse as abstract and adjust tests directly instantiating it or make it as final and not extensible.

We can't really do either, but it shouldn't be detected as a test case anyways. Developers need to be able to access it directly for testing their responses, and our existing extensions rely on it even though they are deprecated.
I guess if there were some compelling reason why it needed to be @final we could copy all the code to FeatureResponse and ControllerResponse - but I think some classes are already checking for TestResponse so that would probably still be a breaking change.

I guess if there were some compelling reason why it needed to be @final we could copy all the code to FeatureResponse and ControllerResponse - but I think some classes are already checking for TestResponse so that would probably still be a breaking change.

Hmm, I guess I'll leave the temp fix of using the pseudo-type @no-final for now so it won't be touched by php-cs-fixer, and until such time we can revisit this.

@paulbalandan Why should test classes be marked as final and internal?
ExampleSessionTest extends SessionTestCase

https://github.com/codeigniter4/CodeIgniter4/blob/develop/admin/starter/tests/session/ExampleSessionTest.php
https://github.com/codeigniter4/CodeIgniter4/blob/develop/admin/starter/tests/_support/SessionTestCase.php

@kenjis Test classes are only for use in testing a library's code so it is not appropriate to be used in userland, thus @internal. Also, since their use is limited, ,then you don't need to have that flexibility of extending test classes, thus @final.
I see in your linked classes and issue that the test cases are final. This is a bug. The ones who created SessionTestCase and DatabaseTestCase failed to make these as abstract classes. Best practices would be that test cases (test classes containing a pool of common methods for use by child test classes) be made as abstract ones.

@paulbalandan Okay. I will fix the bug.


MSB4018 Access Denied hitting Ctrl-C

Description
Hit Ctrl-C during dotnet test run, got unhandled exception
Steps to reproduce
I had a test that hung. I was running with "console;verbosity=detailed". After waiting for a bit, I hit Ctrl-C. This happens most times. I have no idea why it says access denied, either it should catch this and ignore it or catch this and log it nicely.
Expected behavior
Regular error message not a callstack.
Actual behavior
Passed   Microsoft.Collections.Extensions.Tests.MultiValueDictionaryTests.MVD_Constructor8
Attempting to cancel the build...
^C
C:\git\corefxlab>C:\Program Files\dotnet\sdk\3.0.100-alpha1-009697\Microsoft.TestPlatform.targets(33,5): error MSB4018: The "Microsoft.TestPlatform.Build.Tasks.VSTestTask" task failed unexpectedly. [C:\git\corefxlab\tests\Microsoft.Experimental.Collections.Tests\Microsoft.Experimental.Collections.Tests.csproj]
C:\Program Files\dotnet\sdk\3.0.100-alpha1-009697\Microsoft.TestPlatform.targets(33,5): error MSB4018: System.ComponentModel.Win32Exception (5): Access is denied. [C:\git\corefxlab\tests\Microsoft.Experimental.Collections.Tests\Microsoft.Experimental.Collections.Tests.csproj]
C:\Program Files\dotnet\sdk\3.0.100-alpha1-009697\Microsoft.TestPlatform.targets(33,5): error MSB4018:    at System.Diagnostics.Process.Kill() [C:\git\corefxlab\tests\Microsoft.Experimental.Collections.Tests\Microsoft.Experimental.Collections.Tests.csproj]
C:\Program Files\dotnet\sdk\3.0.100-alpha1-009697\Microsoft.TestPlatform.targets(33,5): error MSB4018:    at Microsoft.TestPlatform.Build.Tasks.VSTestForwardingApp.Cancel() [C:\git\corefxlab\tests\Microsoft.Experimental.Collections.Tests\Microsoft.Experimental.Collections.Tests.csproj]
C:\Program Files\dotnet\sdk\3.0.100-alpha1-009697\Microsoft.TestPlatform.targets(33,5): error MSB4018:    at Microsoft.TestPlatform.Build.Tasks.VSTestTask.Cancel() [C:\git\corefxlab\tests\Microsoft.Experimental.Collections.Tests\Microsoft.Experimental.Collections.Tests.csproj]
C:\Program Files\dotnet\sdk\3.0.100-alpha1-009697\Microsoft.TestPlatform.targets(33,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Cancel() [C:\git\corefxlab\tests\Microsoft.Experimental.Collections.Tests\Microsoft.Experimental.Collections.Tests.csproj]

Diagnostic logs
Environment
Windows 10
vstest.console.exe 3.0.100-alpha1-009697

This note in Process.Kill doc may be relevant If the call to the Kill method is made while the process is currently terminating, a Win32Exception is thrown for Access Denied.

@danmosemsft, I tried to repro with a test that's supposed to hang but I'm not able to reproduce this. Could you help me with a consistent repro?

@danmosemsft is this still happening for you?

Yes but it may be a few days before I can try to form a repro.

Hey @danmosemsft, I'm closing this issue for now due to lack of information, feel free to comeback with a repro and I will reopen it.

Why not just add a catch for Win32Exception around Kill() inside VSTestForwardingApp.Cancel() ?

@danmosemsft, I'll need to reproduce the issue at least once before I go forward with a fix. Is possible to share the test you're running that consistently reproduces this issue? If you can't share here, please share the repro with me internally.


New version: twpayne.chezmoi 2.52.2

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Automated with GoReleaser
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-09-09 20:35:31.177 [FAIL] Installer failed security check. Url: https://github.com/twpayne/chezmoi/releases/download/v2.52.2/chezmoi_2.52.2_windows_amd64.zip Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 895.)

@wingetbot run


scroll alignment

Feature request:
It would be nice if there was a field to specify alignment within the scroll, similar to how scrollIntoView works (https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView)
A polyfill also supports these options:
https://github.com/magic-akari/seamless-scroll-polyfill
The reason is to scroll to an element, but have that element positioned start/center/end/nearest inside of the container.

Yes i have the same problem ..
Good feature 👍


ADBDEV-4938-51: Add assertions to return from dynamic_cast.

Add assertions to return from dynamic_cast.
dynamic_cast may return NULL, so I added assertions.

https://github.com/arenadata/gpdb/pull/806


patch - [CustomListView] item delegate default

feat: CustomListViewDelegate, default item delegate for the CustomListView
children. Used on CustomListView.viewDelegate.

deprecated: CustomListView.crossAxisAlignment, is now deprecated in favor of
CustomListView.viewDelegate.
Instead of:
CustomListView(
  crossAxisAlignment: CustomListViewItemAlignment.end,
);

Do:
CustomListView(
  viewDelegate: CustomListViewDelegate(
    crossAxisAlignment: CustomListViewItemAlignment.end,
    // can also specify other [CustomListViewItemDelegate] values
    // mainAxisLength: 80.0,
    // crossAxisLength: 80.0,
  ),
);

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Form layout

One of the missing things from django-bootstrap3 was the ability to layout a form. There were a couple of good attempts and PR's to add form layout through classes, but it never clicked. Some people switched to crispy because of the lack of layout. I don't mind people using crispy, but a little help with organizing a form layout would be nice.
I think this would be a good addition for the future.

I realize this might be seen as a contradiction to #5.

Bootstrap 4's FlexBox support should make this much easier to accomplish; I'm guessing the lack of math in Django's templates made this a bit tricky. Now that Bootstrap 4 automagically balances columns, layout options should be more straightforward. Unless you're thinking of something else?

Doesn't seem relevant anymore, new ticket if we run into this again.


GAN Images need to be added

Essentially the title, need both architectures of generator and discriminator + loss vs epochs graphs.

Done!


Caching hooks

Description
See https://github.com/hms-dbmi-cellenics/api/pull/514
Details
URL to issue

Link to staging deployment URL (or set N/A)

Links to any PRs or resources related to this PR

Integration test branch
master

Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.

Code updates
Have best practices and ongoing refactors being observed in this PR

[ ] Migrated any selector / reducer used to the new format.
[ ] All new dependency licenses have been checked for compatibility

Manual/unit testing

[ ] Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
[ ] Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
[ ] Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

[ ] Started end-to-end tests on the latest commit.

Documentation updates

[ ] Relevant Github READMEs updated or no GitHub README updates required.
[ ] Relevant Wiki pages created/updated or no Wiki updates required.

Optional

[ ] Staging environment is unstaged before merging.
[ ] Photo of a cute animal attached to this PR.

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6b09d70) 89.51% compared to head (5879ba8) 90.06%.

Files
Patch %
Lines

src/api.v2/helpers/worker/generateEtag.js
62.50%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   89.51%   90.06%   +0.55%
==========================================
  Files         168      169       +1
  Lines        3740     3746       +6
  Branches      428      429       +1
==========================================
+ Hits         3348     3374      +26
+ Misses        366      348      -18
+ Partials       26       24       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Component.plot_holoviews fails without layer_views

c.plot_holoviews appears to fail for default layer_views, as the folowing import does not exist anymore
https://github.com/gdsfactory/gdsfactory/blob/e8075ea63e5c909e661e998a4fd6d6fa58667369/gdsfactory/component.py#L1672
The solution is to use get_layer_views instead

I guess it is deprecated so maybe does not need fixing


Update ChangesetReader API and relaxing requirement for ECClassId in update change

This change include two fixes reported by developers

Make $meta.ClassName compatible with other APIs (classFullName).
Change unifier failed with update change was processed as the update does not have ECClassId. Now the check is more flexible and Api fallback to root class for the table and does not fail.

@mergifyio backport release/4.3.x


it is time to release a new version

1.2.0 is too old

I don't think "too old" is helpful feedback. Unless you have specific feedback/ issues, what do you want them to do, just package up the same release under a new version to make it look newer?

I'm going through the backlog.  I'll cut a release after I'm done.

I had to use the latest unreleased version, because sqlx.In is panicking on some input values in version 1.2.0.
In mean time, until @jmoiron makes a new release, if you are running into issues, you use:
go get github.com/jmoiron/sqlx@0794cb1f47ee444eda9624f952ab8a370bec22de # commit ID of current master

Any updates on this?

I'm using @kravemir's solution. Anticipating new release too.

1.3.0

1.3.0


"Hide shorts video" is unstable

"Hide shorts video" is very unstable and has performance issues.
problem

loading loop
It keeps doing a loading loop when most of the listings are shorts because of a simple process (if the href contains "short", clear it)

performance issues

solution

loading loop
The way removeShortVideo() is handled should be changed.

performance issues
Currently, we use mutationObserver to execute removeShortVideo() each time the DOM is updated.
We should use a different method of execution (e.g. event listener).

But I don't know how to do this, so if someone could do it for me, that would be great.

Although I cannot be helpful in resolving performance issues, I want to make some suggestion.
Personally, I often open YouTube videos in a new tab, so I searched, found this extension below.

https://github.com/einaregilsson/Redirector

I tried this extension, after adding a redirect rule, it works perfectly. (perhaps not use-friendly for non-programmer)
So I think using redirect maybe a good direction.

Hello, thanks a lot for building this, I have attempted to address some of these in #6 , please check it out


Bracket pair highlighting of folders in Explorer

I'd like to be able to have folder range highlighting in the Explorer view similar to how Bracket Pair highlighting works.

Not sure what this would look like We do have the indent guides, do they help here?


include apt::default recipe in nginx::package instead of nginx::repo

Using the nginx::package recipe fails on a node with outdated apt package index.
This includes the apt::default recipe in nginx::package instead of nginx::repo which should make no difference when installing nginx from the nginx apt repository (nginx::repo recipe).
This also fixes the kitchen-vagrant suites for ubuntu.

I don't think cookbook, that configures service[nginx], should include recipe[apt] at all. nginx and apt are very different things. If you wanna keep your package list up to date, you should include recipe[apt::default] somewhere else in node's run_list (basically, in first position).

Agreed. Using the package install_method will trigger an apt_repository resource, that will run an apt-get update.
Moving this resource and including the apt recipe directly in the default recipe is undesirable.


Updating the PerfView documentation

Corrected a few grammatical errors, etc.

@microsoft-github-policy-service agree company="Microsoft"

Thanks for approving, @brianrob!


Using Emoji causes an exception when submitting a proposal

Steps to reproduce:

Enter a proposal title that has an emoji such as ❤ or 💚
Click Submit
Observe exception

Here is a screen capture: https://www.dropbox.com/s/3ddem4b2ravz1ho/Screenshot 2015-03-30 09.52.25.png?dl=0
Let me know if you need any further info!

I've been able to successfully add emoji using sqlite as the database, so I don't think this is an OCW-specific problem. That said, I want to solve this for the Open Source Bridge deployment as well, since it's also running MySQL at the moment.
According to this StackOverflow answer, it's possibly to configure MySQL to use the utf8mb4 charset, which is required for glorious emoji storage.
I won't have time to try this for a little white, but if you do, please let me know if it works.


build: upgrade grid-helpers to 0.3.2

Upsteam has been released. Awaiting deploy to https://maven.vaadin.com/vaadin-addons/org/vaadin/addons/flowingcode/grid-helpers/0.3.2/grid-helpers-0.3.2.pom


All peers can be lost

Sometimes the linode will be the only peer, and sometimes there will be no peers at all.
Just like we continuously synchronize, we should have backup plans for the cases where all peers get removed (perhaps the linode or other hardcoded peers are automatically readded). Also, there should probably be some behavior where the linode is occasionally re-queried for a peer list.
TL;DR: the peerlist is still pretty fragile, we need some way to beef so peers don't get disconnected from the network. A secondary goal would be making malice difficult.

Is this still a problem?

The gateway doesn't remove peers anymore, and it will continuously try to form connections, so this is no longer a relevant issue. We just have to remain careful in the future not to ban peers too aggressively.


chore: fix clippy and test phases

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@98012e6). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2012   +/-   ##
=======================================
  Coverage        ?   80.17%
=======================================
  Files           ?       69
  Lines           ?     9739
  Branches        ?     9739
=======================================
  Hits            ?     7808
  Misses          ?     1471
  Partials        ?      460

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


stylish: format using check-stylish-network

First run of scripts/ci/check-stylish-network.sh to format files.
Required to unblock PR #3722

The formatting changes are now included in #3722 :+1:


setSrc throwing error in Opera 11.0/Win32/XP

Media element version 2.4.2
Error thrown at line 2470, column 3 in (src) : this.media.setSrc(src);
Calling code:

var player = new MediaElementPlayer('#media-player', {
	defaultVideoWidth: 320,
	defaultVideoHeight: 180,
	startVolume: 0.8,
	loop: true,
	enableAutosize: true
});

if (Ss.hasFlash) {
	player.setSrc(data.preview_url);
	player.load();
	player.setMuted(false);
	player.play();
}

Note: This works on Opera 11.60 for Mac, and IE/FF/Saf on both platforms

For reference, I am using the player to play .flv files.
It looks like on the Mac this.media is points to the Flash plugin but in Windows it points to the native Element.


feat: serialize config for stateless transaction validator config

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#127
#126  👈
#113 : 1 other dependent PR (#114 )
#111
#110
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 3.44828% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 44.05%. Comparing base (9e7eb6f) to head (b1f7d68).

Files
Patch %
Lines

...tes/gateway/src/stateless_transaction_validator.rs
3.44%
28 Missing :warning:

Additional details and impacted files
@@                                         Coverage Diff                                         @@
##           arni/config/gateway_network_connection/generalize_test_util/pt2     #126      +/-   ##
===================================================================================================
- Coverage                                                            46.12%   44.05%   -2.08%
===================================================================================================
  Files                                                                   16       16
  Lines                                                                  568      597      +29
  Branches                                                               568      597      +29
===================================================================================================
+ Hits                                                                   262      263       +1
- Misses                                                                 297      325      +28
  Partials                                                                 9        9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crates/gateway/src/stateless_transaction_validator.rs line 57 at r2 (raw file):

        ])
    }
}

If we reorganized the folders, I would put this code in a separate file called config.rs under the folder stateless transaction validator.
Code quote:
#[derive(Clone, Debug, Default, Serialize, Deserialize, Validate, PartialEq)]
pub struct StatelessTransactionValidatorConfig {
    // If true, validates that the resource bounds are not zero.
    pub validate_non_zero_l1_gas_fee: bool,
    pub validate_non_zero_l2_gas_fee: bool,

    pub max_calldata_length: usize,
    pub max_signature_length: usize,
}

impl SerializeConfig for StatelessTransactionValidatorConfig {
    fn dump(&self) -> BTreeMap<ParamPath, SerializedParam> {
        BTreeMap::from_iter([
            ser_param(
                "validate_non_zero_l1_gas_fee",
                &self.validate_non_zero_l1_gas_fee,
                "If true, validates transactions have non zero L1 resource bounds.",
                ParamPrivacyInput::Public,
            ),
            ser_param(
                "validate_non_zero_l2_gas_fee",
                &self.validate_non_zero_l2_gas_fee,
                "If true, validates transactions have non zero L2 resource bounds.",
                ParamPrivacyInput::Public,
            ),
            ser_param(
                "max_signature_length",
                &self.max_signature_length,
                "Validates transactions have calldata length less than or equal to this value.",
                ParamPrivacyInput::Public,
            ),
            ser_param(
                "max_calldata_length",
                &self.max_calldata_length,
                "Validates transactions have signature length less than or equal to this value.",
                ParamPrivacyInput::Public,
            ),
        ])
    }
}


Skipped not serializable | no ChunkGraph assigned errors

if you get an error like this
Skipped not serializable cache item 'Compilation/modules|container entry (default) [["./noop",{"import":["/workspace/node_modules/@module-federation/nextjs-mf/src/federation-noop.js"]}],["./index",{"import":["./pages/index.tsx"]}]]': No serializer registered for ContainerEntryModule <w> while serializing webpack/lib/cache/PackFileCacheStrategy.PackContentItems
         Creating an optimized production build ...
       (node:2474) [DEP_WEBPACK_MODULE_ID] DeprecationWarning: Module.id: Use new ChunkGraph API
       (Use `node --trace-deprecation ...` to show where the warning was created)
       Failed to compile.

       webpack/runtime/inverted container startup
       Module.id: There was no ChunkGraph assigned to the Module for backward-compat (Use the new API)

make sure process.env.NEXT_PRIVATE_LOCAL_WEBPACK = 'true' is set in .env or if that doenst work, on the command line.
NEXT_PRIVATE_LOCAL_WEBPACK=true next dev

Hey, how does that relate to https://github.com/module-federation/universe/issues/1104?
the issue still happens.

I got issue 1579 so I try using last version canary but still got this error
You had reproduce, can check on this repo

You need get server props or get initial props otherwise it static generates and there's no router to share.

You need get server props or get initial props otherwise it static generates and there's no router to share.

sorry I'm really not get your point, what exactly I should do ??

at version 8.1.0-canary I'm still get error 1530
at version 7.0.8 has issue share route 1579


Specify Nuxt 3 in ripple-ui-core/forms READMEs.

Issue:
It seems the nuxt modules provided by ripple-ui-core and ripple-ui-forms only work in Nuxt v3 (not v2) apps.
What I did

Added notes to READMEs for ripple-ui-core/forms packages re: Nuxt v3.

How to test

Checklist

For all PR's

[x] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

Hi @bgilhome-now 👋
Sorry for the crazy long response on this, you caught us during a major launch and we've been nailing things down for the past few weeks. I updated the package READMEs, as well as the root README and docs site https://ripple.sdp.vic.gov.au/ to make it much clearer what we use, and what versions.
Thanks for the feedback!


upgrade to kafka <IP_ADDRESS> release

NetflixOSS » suro » suro-pull-requests #25 SUCCESS
This pull request looks good

suro-pull-requests #194 SUCCESS
This pull request looks good

NetflixOSS » suro » suro-pull-requests #26 ABORTED

suro-pull-requests #195 SUCCESS
This pull request looks good


License?

Great project! Could you provide a license file please.

Good catch. Same license as the PBS-Go version. Made PR https://github.com/rubicon-project/prebid-server-java/pull/164


About Us

The About page is super important for recruiting:

We are taking a somewhat informal, "reach out to any member" approach to recruiting. Students need to know who they can reach out to!
Students want a place to visualize themselves in the club, and if they can see a great-looking about page, they will envision themselves on that page and want to join the club more.

We might want to think about moving some of the ethics stuff on the homepage to this about page.

MVP for this page is just getting our faces/emails/bios on there.

Closed by #34.


Add security headers to objects retrieved from S3

We can inject recommended security headers via CloudFront Functions (here) and as shown here:
function handler(event) {
    var response = event.response;
    var headers = response.headers;

    // Set HTTP security headers
    // Since JavaScript doesn't allow for hyphens in variable names, we use the dict["key"] notation
    headers['strict-transport-security'] = { value: 'max-age=63072000; includeSubdomains; preload'};
    headers['content-security-policy'] = { value: "default-src 'none'; img-src 'self'; script-src 'self'; style-src 'self'; object-src 'none'"};
    headers['x-content-type-options'] = { value: 'nosniff'};
    headers['x-frame-options'] = {value: 'DENY'};
    headers['x-xss-protection'] = {value: '1; mode=block'};

    // Return the response to viewers
    return response;
}

Currently working to add it to CloudFormation template.

Need to research this further and determine if this is needed / worth it.

Closing as stale


Any chance you could add some documentation

Hi,
Is this  a direct replacement for the IBM IA92 (wmqtt.jar) library or does this operate completely differently.
It would be handy if you could put the compiled jar up as well. Mavens a bugger in windows :D

This is completely different the interface is not the same so a drop in jar would not work.


Misc docstrings for assemble, add_gids, and PSparseMatrix constructor.

Please check carefully as my understanding is so far quite limited of the architechture of these internals!

Codecov Report

Merging #60 (dcf4995) into master (d5224f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   91.23%   91.23%
=======================================
  Files           7        7
  Lines        2190     2190
=======================================
  Hits         1998     1998
  Misses        192      192

Impacted Files
Coverage Δ

src/Interfaces.jl
90.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5224f7...dcf4995. Read the comment docs.

@fredrikekre I'll try to review this starting the 11th of February. Until then I am very busy with other appointments.

No worries. I will keep pushing docs to this branch as I figure things out then.


[Discussion] What should be promoted as the "right" approach

Thoth.Json is primarily focused on letting you write custom coders for your type. However, when removing JSON serialization in Fable 2, we gave it some auto (de)serialization capabilities. As expected, people are using these auto (de)serializers to make the Fable 2 upgrade easier. But there're some issues with this approach:

Decode.Auto makes reference to most of the "primitive" types supported by Fable. This pulls code from Fable polyfills increasing the bundle size even if the types are not used in the app at all: datetimes, maps, decimals, bigints (specially the last two and probably also longs).
As soon as the user wants to use a custom decoder for one type, they need to write decoders for all the other types.
The map is compiled as an arrays of arrays. This is done to avoid problems when the key is not easily converted to string, but it's confusing as most users will expect them to transform to JSON objects.

I'm the first one to acknowledge how difficult is to maintain a "magic" serialization library, and I'm super happy of removing it in Fable 2. But on the other hand, as we're promoting F# fullstack, users will expect to have an easy way to share the types between client and server without having to write so much boilerplate.
Possible solutions:

Leave it more or less as is and tell users that as soon as they have specific needs they should write custom decoders for the whole domain.
Try to balance custom and auto decoders, for example, by allowing to pass a dictionary/function with custom decoders that could override the default ones.
Have a different library that focus on the auto serialization? Could make sense to promote @zaid-ajaj SimpleJson like this? (though, for what I've seen SimpleJson has similar problems to those listed above).

I'm adding a fix to reflection in Fable 2.1 to prevent code duplication when calling typeof several times on related types.

As a side note, I don't like some of the decoders "custom". Custom had another meaning in Thoth.Json v1 and still have another meaning for people coming from Elm.
I would prefer to speak about manual and auto decoders.

As soon as the user wants to use a custom decoder for one type, they need to write decoders for all the other types.

I think if we works on #65 we should be able to control the decoders using manual decoders. And have something like that:
type ComplexTypeA =
    // I am using class end so I don't have to write a lot of code for the demo
    class end

    static member Decoder =
        Decode.Auto.generateDecoder<ComplexTypeA>()

    static member Encoder (x : ComplexTypeA) =
        Encode.Auto.generateEncoder<ComplexTypeA>()

type SimpleTypeB =
    // I am using class end so I don't have to write a lot of code for the demo
    class end

    static member Decoder =
        Decode.Auto.generateDecoder<SimpleTypeB>()

    static member Encoder (x : SimpleTypeB) =
        Encode.Auto.generateEncoder<SimpleTypeB>()

type Test =
    { FieldA : ComplexTypeA
      FieldB : SimpleTypeB }

    static member Decoder =
        Decode.object (fun get ->
            { FieldA = get.Required.Field "fieldA" ComplexTypeA.decoder
              FieldB = get.Required.Field "fieldB" SimpleTypeB.decoder }
        )

    static member Encoder (v : Test) =
        Encode.object [
            "fieldA", ComplexTypeA.Encoder v.FieldA
            "fieldB", SimpleTypeB.Encoder v.FieldB
        ]

Have a different library that focus on the auto serialization? Could make sense to promote @Zaid-Ajaj SimpleJson like this? (though, for what I've seen SimpleJson has similar problems to those listed above).

Any library that will really on reflection will have this problem. Unless we load the polyfills in an asynchrone way. Which then turn in a lot of problems especially for startup time.

Leave it more or less as is and tell users that as soon as they have specific needs they should write custom decoders for the whole domain.

No, we should work on the current feature and works on improving mixing auto decoders and manual decoders.

Try to balance custom and auto decoders, for example, by allowing to pass a dictionary/function with custom decoders that could override the default ones.

I am not for this solution, this mean the users will need to modify a dict based on its usage of the types. Which are potentially deeply nested in his code.
This is something that I had when working on the FormBuilder library and it was a really unpleasant experience.
IMO if people are using auto features they have to understand that there is a price for it and they need to be more rigorous when writing their code.

I do understand why people prefers auto decoders. But I really do think that using the manual decoders to control the auto decoders is the way to go. The compiler will help you will that so you will still benefit of the types system, intellisense etc.
What's missing for that is #65 so people can write the decoders and encoders.
If we go we some kind of a config registration, then the compiler will not be able to help you. You will most of the time end up going back and forth on your config things.

And thanks you I now understand why map as converted as arrays by the auto decoders.

The map is compiled as an arrays of arrays. This is done to avoid problems when the key is not easily converted to string, but it's confusing as most users will expect them to transform to JSON objects.

I still think #75 is needed in order to be sure we are supporting the same types as auto encoders and auto decoders. This is not the case right now. :)

For Girafe I have a working version here.

Auto decoders are great when you don't care about the actual output - you just want to send it over the wire. Manual decoders are great when you do care about the actual output, e.g. when you save it to a file or when the serialized version is persisted or lives a bit longer.
So I think there are scenarios for both type of decoders.
Maybe it's possible to simplify writing manual [en|de]coders if you just had to write one of them and get the other one for free? Would that be possible (of course without any reflection)?

So I think there are scenarios for both type of decoders

Yes, there is place for both of them. I personally think we should make mixing them easier. For the decoders, we are already here but not for the encoders.

Would that be possible (of course without any reflection)?

I do have plan to make the generation of Decoder/Encoder by using a generator #20. The tool by itself was kind of working for Thoth.Json v1 but I never really invest a lot of time in it. So when you wanted to write a manual decoder, you could generate it and fix the missing/special parts of it.

@MangelMaxime At the end I've come up with this for Giraffe. This should be quite performant because it's writing directly in the response body stream and doesn't need the intermediate string representation. You can use it with sequences too. The only problem is users must avoid Successful.OK because the Giraffe will apply the default JSON serialization causing problems in the server. Maybe Thoth.Json.Giraffe could shadow this.
module Json =
  open System.Threading.Tasks
  open Microsoft.AspNetCore.Http
  open FSharp.Control.Tasks.V2
  open Newtonsoft.Json
  open Newtonsoft.Json.Linq
  open Thoth.Json.Net
  open Giraffe

  let okRaw (token: JToken) =
    fun (next : HttpFunc) (ctx : HttpContext) -> task {
        ctx.SetStatusCode 200
        ctx.SetContentType "application/json; charset=utf-8"
        use stream = new System.IO.StreamWriter(ctx.Response.Body, NewLine = "\n")
        use jsonWriter = new JsonTextWriter(stream)
        do! token.WriteToAsync(jsonWriter)
        return Some ctx
    }

  let ok (body: 'T) (encoder: Encode.Encoder<'T>) =
    encoder body |> okRaw

  let okSeqRaw (tokens: JToken seq) =
    fun (next : HttpFunc) (ctx : HttpContext) -> task {
        ctx.SetStatusCode 200
        ctx.SetContentType "application/json; charset=utf-8"
        use stream = new System.IO.StreamWriter(ctx.Response.Body, NewLine = "\n")
        use jsonWriter = new JsonTextWriter(stream)
        jsonWriter.WriteStartArray()
        for token in tokens do
          do! token.WriteToAsync(jsonWriter)
        jsonWriter.WriteEndArray()
        return Some ctx
    }

  let okSeq (xs: 'T seq) (encoder: Encode.Encoder<'T>) =
    xs |> Seq.map encoder |> okSeqRaw

  let readBody (ctx: HttpContext) (decoder: Decode.Decoder<'T>): Task<'T> = task {
    let! json = ctx.ReadBodyFromRequestAsync()
    return
      match Decode.fromString decoder json with
      | Ok value -> value
      | Error er -> failwith er
  }

I am not for this solution, this mean the users will need to modify a dict based on its usage of the types. Which are potentially deeply nested in his code.

@MangelMaxime Consider the following example:
type Foo =
    | Foo of int
    // For some reason I want to serialize Foo as int
    static member Encode (x: Foo) =
        let (Foo i) = x
        Encode.int i

type ComplexTypeA =
    { FieldA: string
      // Many more fields here
      FieldZ: Foo }
    // I want to use Encode.Auto.generateEncoder() here (when it's available)
    // but one of the fields is Foo which has a manual encoder, so I can't
    static member Encode (x: ComplexTypeA) =
        Encode.obj [ ... ]

type Test =
    { FieldA : ComplexTypeA
      FieldB : SimpleTypeB }
    static member Encoder (v : Test) =
        Encode.object [
            "fieldA", ComplexTypeA.Encoder v.FieldA
            "fieldB", SimpleTypeB.Encoder v.FieldB
        ]

Just because we want to serialize Foo in a particular way, we cannot use auto encoders in any type that uses it. And there are other, worser, corner cases: for example, we can add the Foo field to a type later on and forget to change from auto to manual encoder, or Foo can be in a nested type and we don't take this into account when picking an auto encoder.
However, if we had the dictionary, we only need to remember to update it, whenever we want to have a manual encoder for some types.
let manualEncoders = Map [
    typeof<Foo>.FullName, (fun (x: Foo) ->
        let (Foo i) = x
        Encode.int i)
]

// An alternative would be to use a function instead of a dictionary
let manualEncodersFn (t: Type) (x: obj) =
    if t.FullName = typeof<Foo>.FullName then
        let (Foo i) = x :?> Foo
        Encode.int i |> Some
    else None

type ComplexTypeA =
    { FieldA: string
      // Many more fields here
      FieldZ: Foo }
    static member Encode (x: ComplexTypeA) =
        Encode.Auto.generateEncoder(manualEncoders)

Hum... You are probably right @alfonsogarciacaro
In fact, I don't think we have a perfect solution others than removing the auto features :trollface:
More seriously, I think here all the discussion is more focused on the Auto decoders API that is too limited perhaps. And perhaps adding new features to it is the way to go.
We need to think really carefully our moves because it can have big good or bad impact on user code.
One thing I am more or less certain of is that related to #77 I would consider that Auto features have to support most/all the F# types by default. And yes this is at the price of the bundle size but I am personally perfectly ok with that.
So then people, will "only" have to worry about their own types.

Also we would need to "real" example or case we want to support so everyone can understand have the same examples in mind to help communicates.

Continue discussion in #84


я не могу форматировать код

я нажимаю shift + alt + f , ничего не работает и появляется уведомление ,
Модуль форматирования документов для файлов 'csharp' не установлен.
Как установить модуль ?

I think the issues supposed to be in the English language here. Also, as contribution guide states, you can answer the questions on StackOverflow, rather than creating the issues here.
Still. Your problem is that there is no C# formatter found. Quick questions for you:

Do you have C# extension installed?
As far as I know, there is no any built-in formatter for C#, only code highlighting, so you need to install complete C# language support with this extension.

If after installing the extension above, formatter still doesn't work:

Did you disable any built-in extension related to CSharp language?
If so, try to turn them back on. In really rare cases disabling built-in extensions may break the functionality of other extensions.

Please, post an update here if any of the steps above helped you, so the maintainers can close the issue.
If nothing helped, create the issue manually using “Справка (Help)” → “Сообщить о проблеме (Report Issue)”, it will contain useful information about your version of Visual Studio Code and list of extensions.
Thank you!

@kirya355 Do you have additional information?


chore(main): release 2.5.2

:robot: I have created a release beep boop
2.5.2 (2024-09-10)
Bug Fixes

copilot: #189 "bad request: unknown integration" (372607d)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.5.2
:sunflower:


Fix GenericNack serialization

The current GenericNack serialize function has a bug in it where if a subsequent PID is lower that the previous PID it'll crash. This is because d becomes a negative number (as p < pid), and blp would become invalid (i.e. not a 16 bit number).
See the test that was previously failing.

thanks for PR


Added missing div in html, added missing semi colon in js files.

...s.

sorry put the wrong branch for the pull request please ignore.


Fail to build for AWS lambda in container in SAM CLI

Python: 3.11
SAM CLI, version 1.103.0
Installed in requirements.txt with:
> pip install "fastapi-cache2[redis]"
Looks to be a problem with pendulum but trying previous versions (2.1.0 and 2.1.1) didn't solve the issue.
PythonPipBuilder:ResolveDependencies failed
Traceback (most recent call last):
  File "/usr/local/opt/sam-cli/lib/python3.11/site-packages/aws_lambda_builders/workflows/python_pip/actions.py", line 64, in execute
    package_builder.build_dependencies(
  File "/usr/local/opt/sam-cli/lib/python3.11/site-packages/aws_lambda_builders/workflows/python_pip/packager.py", line 159, in build_dependencies
    self._dependency_builder.build_site_packages(requirements_path, artifacts_dir_path, scratch_dir_path)
  File "/usr/local/opt/sam-cli/lib/python3.11/site-packages/aws_lambda_builders/workflows/python_pip/packager.py", line 263, in build_site_packages
    raise MissingDependencyError(packages_without_wheels)
aws_lambda_builders.workflows.python_pip.packager.MissingDependencyError: {pendulum==2.1.1(sdist)}

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/opt/sam-cli/lib/python3.11/site-packages/aws_lambda_builders/workflow.py", line 371, in run
    action.execute()
  File "/usr/local/opt/sam-cli/lib/python3.11/site-packages/aws_lambda_builders/workflows/python_pip/actions.py", line 70, in execute
    raise ActionFailedError(str(ex))
aws_lambda_builders.actions.ActionFailedError: {pendulum==2.1.1(sdist)}
Builder workflow failed
Traceback (most recent call last):
  File "/usr/local/opt/sam-cli/lib/python3.11/site-packages/aws_lambda_builders/workflows/python_pip/actions.py", line 64, in execute
    package_builder.build_dependencies(
  File "/usr/local/opt/sam-cli/lib/python3.11/site-packages/aws_lambda_builders/workflows/python_pip/packager.py", line 159, in build_dependencies
    self._dependency_builder.build_site_packages(requirements_path, artifacts_dir_path, scratch_dir_path)
  File "/usr/local/opt/sam-cli/lib/python3.11/site-packages/aws_lambda_builders/workflows/python_pip/packager.py", line 263, in build_site_packages
    raise MissingDependencyError(packages_without_wheels)
aws_lambda_builders.workflows.python_pip.packager.MissingDependencyError: {pendulum==2.1.1(sdist)}

Related to #391 and #453


Warning: W/od.evomapmarke: Long monitor contention with owner AsyncTask...

I use library to preview image size: 16535x10394 19.2 MB.
This is code to load image png:
SubsamplingScaleImageView imgMappa = findViewById(R.id.imaMappa);
imgMappa.setImage(ImageSource.uri(Global.PATH_SD + documenti.getDsRecordID() + ".png"));
When I load image and zoom I have the following log in console:
Warning: W/od.evomapmarke: Long monitor contention with owner AsyncTask #11 (17713) at android.graphics.Bitmap android.graphics.BitmapRegionDecoder.decodeRegion(android.graphics.Rect, android.graphics.BitmapFactory$Options)(BitmapRegionDecoder.java:192) waiters=3 in android.graphics.Bitmap android.graphics.BitmapRegionDecoder.decodeRegion(android.graphics.Rect, android.graphics.BitmapFactory$Options) for 3.147s
Is it due to the size of the image? How can I solve?
Thank you

Yes I expect the size of the image causes this and there's nothing that can be done to make it faster, unless you actually are loading from an SD card and have the option of moving it to internal storage. Does the image still load and display correctly? If so then perhaps you can ignore these warnings.

yes the image is loaded correctly!!!
Thanks
Francesco

Il giorno 22 set 2021, alle ore 23:04, davemorrissey @.***> ha scritto:
Yes I expect the size of the image causes this and there's nothing that can be done to make it faster, unless you actually are loading from an SD card and have the option of moving it to internal storage. Does the image still load and display correctly? If so then perhaps you can ignore these warnings.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/davemorrissey/subsampling-scale-image-view/issues/532#issuecomment-925328817, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKXC6V5AUBE6D6O6GEBTETUDJAG5ANCNFSM4SL7FMWQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Good, I'll close this because the warnings are normal for such a large image.


33 messy error stack

Solves https://github.com/vnegi10/CryptoDashApp.jl/issues/33

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4604e37) 62.90% compared to head (b13d503) 62.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   62.90%   62.82%   -0.08%
==========================================
  Files           7        7
  Lines         496      495       -1
==========================================
- Hits          312      311       -1
  Misses        184      184

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Julia 1.9 CI on Windows fails due to https://github.com/JuliaGizmos/Blink.jl/issues/247. This will be fixed in another PR.


Creation time filter

Detailed Description
Add filter on creation time
Context

filter on  national/forecast, filter on gsp/{gsp_id}/forecast
Feature request from NG-ESO

Possible Implementation

add creation time filter in api. Then only return forecasts made before this date. These would not be the latest forecast made before that date.

Added this here for reference @JamieTaylor-TUOS


kubernetes.io/hostname is not a well-known label?

After migrating from autoscaler to Karpenter we have very weird log messages:
2023-09-21T02:03:38.125Z	DEBUG	controller.provisioner	ignoring pod, label kubernetes.io/hostname is restricted; specify a well known label: [karpenter.k8s.aws/instance-accelerator-count karpenter.k8s.aws/instance-accelerator-manufacturer karpenter.k8s.aws/instance-accelerator-name karpenter.k8s.aws/instance-category karpenter.k8s.aws/instance-cpu karpenter.k8s.aws/instance-encryption-in-transit-supported karpenter.k8s.aws/instance-family karpenter.k8s.aws/instance-generation karpenter.k8s.aws/instance-gpu-count karpenter.k8s.aws/instance-gpu-manufacturer karpenter.k8s.aws/instance-gpu-memory karpenter.k8s.aws/instance-gpu-name karpenter.k8s.aws/instance-hypervisor karpenter.k8s.aws/instance-local-nvme karpenter.k8s.aws/instance-memory karpenter.k8s.aws/instance-network-bandwidth karpenter.k8s.aws/instance-pods karpenter.k8s.aws/instance-size karpenter.sh/capacity-type karpenter.sh/provisioner-name kubernetes.io/arch kubernetes.io/os node.kubernetes.io/instance-type node.kubernetes.io/windows-build topology.kubernetes.io/region topology.kubernetes.io/zone], or a custom label that does not use a restricted domain: [k8s.io karpenter.k8s.aws karpenter.sh kubernetes.io]	{"commit": "637a642", "pod":
Those messages are for pods with hostname affinity or antiaffinity in deployments:
 affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: kubernetes.io/hostname
                operator: Exists
        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
          - podAffinityTerm:
              labelSelector:
                matchExpressions:
                  - key: app
                    operator: In
                    values:
                      - pod-worker
              topologyKey: kubernetes.io/hostname

Support for kubernetes.io/hostname is documented  for affinity purposes, so this caused by a misconfiguration, as I understand.
Please help us to find that misconfiguration.

Hi @oleksiytsyban, you should be able to use kubernetes.io/hostname as the topologykey for podAntiAffinity, but for nodeAffinity, Karpenter restricts use of the kubernetes.io/hostname label as it interferes with scheduling constraints.
Generally, all nodes should have the the kubernetes.io/hostname label, so I don't think you need the Exists there. For creating a node for these constraints, using any operator here doesn't make sense. All nodes will have the label, so Exists and DoesNotExist will always be true/false respectively. Using In doesn't make sense as we can't ensure the node will be created with that hostname.
What's the use-case for using hostname node affinity? Realistically, I could see us ignoring this if it's set in nodeAffinity, as pods should schedule to existing nodes even if they have this affinity requirement, but I'm not sure I'm understanding the use-case here.

I am running into this issue. My use case is I want all the same pods in the same namespace on the same node. Each namespace is a development environment, and I want max stability. If I put all the pods on the same instance, if I lose an instance to OOM, spot issues, etc I only lost one namespace. Where as right now, one namespace might be on five different instances. Which then means losing one instance might cause disruption to 1-5 namespaces. Given that all my pods are inter-dependent.
How would you recommend I create podAffinity per namespace without kubernetes.io/hostname?

I'd recommend you look at the Kubernetes docs on the best way to use namespaces: https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/#when-to-use-multiple-namespaces
More about namespace-based scheduling in Karpenter here: https://karpenter.sh/docs/faq/#how-can-i-configure-karpenter-to-only-provision-pods-for-a-particular-namespace
You should drive disruption tolerance by PDBs and if you want, you can use topology spread constraints. You can spread by arbitrary labels, or something like zone, or even capacity type.
Like my explanation above, using kubernetes.io/hostname in node affinity doesn't make sense, but you could use podAntiAffinity with a topology key of kubernetes.io/hostname if you have a hard requirement on one pod per node. AFAIK only using hostname on node affinity doesn't work.
Since it doesn't seem like there's a bug here for Karpenter, i'll close. @oleksiytsyban feel free to re-open another ticket if you feel there's a use case I didn't capture.


[Tracking] TAG Documentation Update: TAG Environmental Sustainability

Description
This issue supports updating the TAG README, Charter and moving documents to the TAG’s Gdrive. The work will be tracked in the TOC Tracking issue #1366.
Outcome
Updated document as per TOC guidelines
To-Do
The following points should be addressed:

PR updating TAG repo README in accordance to the template
PR updating TAG charter in the TOC repo charter folder according to the template
Move all TAG related shared documents ( Like meeting notes and slides ) to the<EMAIL_ADDRESS>drive for the TAG.
The aim of this update is to ensure no documents get lost in private or company accounts. Reach out to @riaankleinhans for assistance on that.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Comments
No response

Move all TAG related shared documents ( Like meeting notes and slides ) to the<EMAIL_ADDRESS>drive for the TAG. The aim of this update is to ensure no documents get lost in private or company accounts.

@riaankleinhans we currently have the APAC meeting notes document in the repo. Folks in China are unable to access all (or most) google products. They are unable to use gdrive, gdocs etc. If you recommend a different approach- please let us know. Maybe LFX could help- not sure.

toc tag charter template link: https://github.com/cncf/toc/blob/main/tags/resources/tag-formation-templates/template-tag-charter.md

Folks in China are unable to access all (or most) google products. They are unable to use gdrive, gdocs etc. If you recommend a different approach- please let us know. Maybe LFX could help- not sure.

@leonardpahlke on docs LFX does not have a solutions. I am a fan of managing things in GH.
If GDoc is a problem, and the community have the GH skills it make sense to switch to GH with meeting docs.

Our drive is managed by CNCF. So we are good 👍

All tasks on the list are now completed so closing this issue.


Overzealous subsidiary brain mask in the BOLD reference generation.

This issue focuses on the problem reflected by the picture in https://github.com/poldracklab/fmriprep/issues/963#issuecomment-364226789.
The problem was that, for some BOLD with strong INU would produce funky reference maps and useless masks. This was mainly caused by a very conservative configuration of Nilearn's calculate_epi_mask (upper percentile threshold).
Interestingly, when calculating the reference after HMC, STC & SDC this problem rarely happened on the preprocessed BOLD. For this reason, the BOLD ROIs would look okay.
The duality between reports is discussed in #963.
The problem writing out masks is addressed in #964.

Fixed with #966.


Turbolinks 3 partial replacement with "render" but URL is not changed.

How to change the URL with params when I need to replace just some divs of my page?

And it works, but the URL doesn't change.
How to change also the URL?

Looks like this question has come up before here with a suggestion here.


feat: add header.js

Please tell me any errors in this code! Thank you.

Good job, I think it would be good to add about page or components afterwards.\

Good job, I think it would be good to add about page or components afterwards.\

Thank you for the feedback! Adding an 'About' page or additional components sounds like a great idea. I'll look into implementing that in future updates.


Fixing static analysis issues

Running all the static analysis tools described here makes lots and lots of warnings and errors.
Some minor and some major (e.g.: cyclomatic complexity of some docker functions is very high, a big refactoring needs to be done.)
I'm not sure how to tackle this one, but I just add this as a reminder.

Current issues:
$ megacheck ./...
docker.go:221:20: os.Kill cannot be trapped (did you mean syscall.SIGTERM?) (SA1016)
docker.go:257:3: should check returned error before deferring hijack.Conn.Close() (SA5001)
docker.go:48:2: field running is unused (U1000)
The command "megacheck ./..." exited with 1.

Were easily fixed
0.01s$ gocyclo -over 19 $GO_FILES
22 cali (*DockerClient).StartContainer ./docker.go:191:1
The command "gocyclo -over 19 $GO_FILES" exited with 1.

^ like you say in https://github.com/skybet/cali/issues/18#issuecomment-378141923, this is gonna be a hard one to fix, but I'll take a look at what you've got on your fork.
Disabling this one for now
0.26s$ golint -set_exit_status $(go list ./...)
/home/travis/gopath/src/github.com/skybet/cali/cli.go:14:2: don't use ALL_CAPS in Go names; use CamelCase
/home/travis/gopath/src/github.com/skybet/cali/cli.go:14:2: exported const EXIT_CODE_RUNTIME_ERROR should have comment (or a comment on this block) or be unexported
/home/travis/gopath/src/github.com/skybet/cali/cli.go:15:2: don't use ALL_CAPS in Go names; use CamelCase
/home/travis/gopath/src/github.com/skybet/cali/command.go:11:1: comment on exported type Command should be of the form "Command ..." (with optional leading article)
/home/travis/gopath/src/github.com/skybet/cali/docker.go:24:2: struct field Id should be ID
/home/travis/gopath/src/github.com/skybet/cali/docker.go:36:2: struct field Id should be ID
/home/travis/gopath/src/github.com/skybet/cali/docker.go:51:1: comment on exported method DockerClient.InitDocker should be of the form "InitDocker ..."
/home/travis/gopath/src/github.com/skybet/cali/docker.go:112:1: comment on exported method DockerClient.AddEnv should be of the form "AddEnv ..."
/home/travis/gopath/src/github.com/skybet/cali/git.go:33:1: comment on exported method Git.Checkout should be of the form "Checkout ..."
/home/travis/gopath/src/github.com/skybet/cali/git.go:54:9: if block ends with a return statement, so drop this else and outdent its block
/home/travis/gopath/src/github.com/skybet/cali/git.go:90:1: exported method Git.Pull should have comment or be unexported
/home/travis/gopath/src/github.com/skybet/cali/git.go:143:6: func repoNameFromUrl should be repoNameFromURL
Found 12 lint suggestions; failing.
The command "golint -set_exit_status $(go list ./...)" exited with 1.
```

All look fairly simple, but not gone through them all yet.

Wasn't actually too hard to deal with the gocyclo issue afterall.
In https://github.com/skybet/cali/pull/46 I split out the code to run a container in non-interactive (and non-TTY) mode, into a method startContainerNonInteractive, which resulted in StartContainer becoming exactly 19 lines!
But then I had to add something to make it slightly longer.
I could do the same thing to split out another startContainerInteractive (and split out other parts of StartContainer too)


Circle config

Reverts 1.0.2, remove build status badge from VSM public page: https://docs.microsoft.com/en-us/vsts/extend/develop/manifest#approvedbadges

@justinklemm the 1.0.2 -> 1.0.1 is in there, just not showing in the PR for some reason...

Yeah I thought about that too. I think it would be worth it - to me little green badge is credibility. I'll circle back around in a bit and set it up. Do we have a travis account already?

Can you get to this? https://travis-ci.org/ghost-inspector/ghost-inspector-vsts-extension

Yes, thanks!


Mysensors: Refactor unit of measurement

Add dict with map of units to v_types.
Avoid numerous if, elif branches and return statements.
Add custom unit decoupled from other units.

:dolphin:

Cleaned up code, following the comments. Merging.


Consider making Tag::read_from[...] functions return Result<Option<Tag>>

Consider making Tag::read_from[...] functions return Result<Option<Tag>> and return Ok(None) when a file has no tag, but otherwise there were no errors. I think most users would like to handle errors and files without tags differently and at the moment you have to match on the id3::Result::kind
    /// An error kind indicating that the reader does not contain an ID3 tag.
    NoTag,

How I'm doing it at the moment:
    let tag = {
        let tag_res = Tag::read_from_path(path);
        match tag_res {
            Ok(tag) => Ok(tag),
            Err(e) => {
                if let ErrorKind::NoTag = e.kind {
                    Ok(Tag::new())
                } else {
                    Err(e)
                }
            }
        }
    }?;

Good idea! There already is a partial_tag_ok function, I added  the no_tag_ok helper function using the same convention.

damn, that was quick, thanks a lot 👍


Stream is not disconnected in case of using async=True and restarting Stream

Hi, I'm using tweepy==2.3.0
I'd like to restart streaming when list of keywords to track is changed.
So I'm calling Stream.disconnect() method.
The issue is the following:
When I do so, the self.running variable is setting to False.
However after this I run filter() again with new keywords and it's setting self.running (in _start method) back to True.
As per my opinion the loop in _run method has not enough time to end and make a condition test in while loop, so it started new thread but the first one remains running because self.running is True.
Maybe I do something wrong, the first solution I came up with is to add some sleep() before calling the second filter() method
However I'd like to have some way to wait till _run is actually ends (maybe some threading.Event() or something like this).

The issue is still not resolved. In 3.3.0 the only thing disconnect() does is to set self.running to False. This has to be fixed by using an event.

The issue is still not resolved.

In fact, for the moment there is Stream._thread variable that represents current thread running, you can join it before doing anything, so it should work correctly.

This is still an issue. I delete the Stream object before each loop iteration which then creates a new stream with updated filter terms.


can't start a room without signin

i deployed it on my server but can't start a room without signin
url for testing: https://commercifly.ml/
the problem:

Check your server/config/config.js file. change the below setting.
requireSignInToAccess : false,


Draft/add library

I imagined this sequence that could break the current implementation:

A rolling restart action is half done
unit 7 just finishes its restart and releases the lock (modifies relation data)
simultaneously: juju sends out relation changed events, juju changes leader from unit 42 to unit 999
unit 999 ignores relation-changed because it's not leader (received relation changed event first)
unit 42 ignores relation-changed because it's not the leader (received leader change state/info first)

The rolling restart process is now stalled.  Everybody ignored the relation changed events that were suppose to trigger the next ops manager lock wrangling.  I'm not completely sure this could happen, but it seems plausible.

I'm really impressed with it, especially the abstraction from only restarts to generic func_run.
One thing that wasn't entirely clear reading through was the event_acquire arg to RollingOpsManager.
In the example you gave, on.restart_action is passed, which is used as self.framework.observe(event_acquire, self._on_acquire_lock) and is never seen again. More for my understanding, could you please walk through what it's doing?

Thank you!
And I will add some docs around the "restart action". The summary goes something like this:
When we define the action in actions.yaml, we make our charm capable of receiving an event called "action_<action_name>". We don't need to define that anywhere in code. It's just "if there exists an action called foo in this charm, the charm can list for an event called action_foo, which fires when an operator runs the action against this unit.
We won't always want to trigger a restart based on an action. But we can, by telling the library to react based on charm.on.action_. (I decided to pass it in to give a charm author some flexibility.)

I imagined this sequence that could break the current implementation:
* A rolling restart action is half done

* unit 7 just finishes its restart and releases the lock (modifies relation data)

* simultaneously: juju sends out relation changed events, juju changes leader from unit 42 to unit 999

* unit 999 ignores relation-changed because it's not leader (received relation changed event first)

* unit 42 ignores relation-changed because it's not the leader (received leader change state/info first)

The rolling restart process is now stalled. Everybody ignored the relation changed events that were suppose to trigger the next ops manager lock wrangling. I'm not completely sure this could happen, but it seems plausible.

This sounds plausible.
I think that we can fix it by emitting a "process_locks" event on leader-elected. And also possibly tie it to update_status, though I'd like to avoid the latter if we can.

Thanks for the comments, all. I've been busy hammering at this on a live Juju instance, and haven't looped back to update the PR based on the comments. But I have read and appreciated all of them, and should have something updated to push soon :-)

Merged the code. Going to take the points still under discussion into separate issues/PRs.


Package.json: add<EMAIL_ADDRESS>to dependencies

Whoops! Wrong repo.

hahahahahhaha
Chris Williams
@voodootikigod http://twitter.com/voodootikigod | GitHub
http://github.com/voodootikigod
The things I make that you should check out:
SaferAging http://www.saferaging.com/ | JSConf http://jsconf.com/ |
RobotsConf http://robotsconf.com/ | RobotsWeekly
http://robotsweekly.com/
Help me end the negativity on the internet, share this
http://jsconf.eu/2011/an_end_to_negativity.html.
On Tue, Jun 2, 2015 at 11:24 AM, Rick Waldron<EMAIL_ADDRESS>wrote:

Whoops! Wrong repo.
—
Reply to this email directly or view it on GitHub
https://github.com/voodootikigod/node-rolling-spider/pull/15#issuecomment-107990088
.


Depositing negative amount fails with unexpected error

Depositing negative amount causes contract fail with InsufficientFunds error.
Expected(?) result: transaction fails with  NegativeValue
Probably problem is here:
deposit :: GovParams -> Api.Deposit -> GovernanceContract ()
deposit params (Api.Deposit amnt) = do
  ...
  let ...
      xGovValue = Validation.xgovSingleton params.nft (coerce ownPkh) amnt
      ...
      tx = sconcat [
          Constraints.mustMintValue               xGovValue
        ...
        ]
 ...

It creates Value with negative amount and tries to burn xGOV tokens, but there are no tokens in the wallet yet.
Not sure what need to be adjusted - contract logic or test case.

User cannot possess negative funds -- therefore the message is correct.
We check this assumption by delegating it to the blockchain's own assumptions

But there will be another error if user deposit positive amount first , and then deposit negative, and this time error will be  NegativeValue. It can be confusing.

Sure but it's pointless to introduce anything like that, this is a matter of UX and may be relegated to an error-out from the Contract monad but I'd delay that, or disregard it since this is meant not to be a finished product but an example. If someone comes in and modifies the code such that the security doesn't hold anymore, one may then think that the Contract check is an actual security guarantee.
Regardless I see no point in having clear error messages other than for the purpose of debugging, which this is not it.

Decided to cover both cases separately to kinda document contract behavior.
test cases added.


cdxgen silently crashes when generating SBOM for large Windows Docker Images

It appears that cdxgen is silently crashing when trying extract large layers from a Windows docker image.
When running cdxgen mcr.microsoft.com/dotnet/aspnet:8.0-windowsservercore-ltsc2019 -o aspnet.json -t docker -p --fail-on-error, the process will return without any error messages after hanging for about 1 minute trying the extract the first layer. In this case, the layer tar is 3.7GB.
Exporting smaller windows images, like nanoserver, works fine. So I have to assume that the problem is not related to Windows Images, but rather their size.

@Taha-cmd, thank you for the issue. We have not done much testing with Windows images. Could you add some console.log statements in the code and identify where the issue might be? Also, try playing with heap memory allocated to node using --max-old-space-size 8000.

Hi @prabhu, thank you for the quick response. Unfortunately, I don't have the experience to debug node.js applications nor do I have the capacity to try to learn it or to reverse-engineer what the code is doing. I was hoping that one of the project's maintainers would help,

Thanks @Taha-cmd. Have added labels. We don't have anyone full time on cdxgen. Hopefully someone would contribute a patch or sponsor an engineer's time to look into these.


Vim/nano/etc do not scale correctly, and scrolling doesn't work well.

Both vim and nano open at a size smaller than expected for the window size. In vim, this is &columns = 80, &lines=24. I can't resize vim (using e.g. ":set lines=30") to any size larger than 24. The command succeeds, but the new frame is not drawn. See photos:

Also, scrolling doesn't work well in vim. If I move a large number of lines, everything is redrawn (e.g. skipping to the top or bottom with G or gg works perfectly well). However, moving the cursor downwards one line at a time from the bottom of the screen only updates the bottom line (so that it skips from e.g. 21 to 33). Is this somehow related to the lack of scrolling in the shell? You mentioned you got rid of that to stop too many redraws. Here's a picture:

Thanks for the project! I wish I could do anything more useful than filing issues.
PS: I'm sure you know about this already, so I won't bother submitting it as an independent issue. If your shell input is longer than a line, it wraps back on its own line:

I've done to major updates to this which can be found in the latest release. https://github.com/i-am-shodan/ReTerm/releases/tag/release_20230731_1832
Feel free to create new issues


Port member default initialization from constructor to declaration (C++11)

Using clang-tidy's modernize-use-default-member-init check and
manual review of the changes, and some extra manual changes that
clang-tidy failed to do.
The changes were initially done by calling run-clang-tidy.py -fix with the provided config, and using the newly merged feature that gives us a compilation database (#32848). It's not perfect though, it made some bogus changes which led to compilation errors which I had to fix manually.

Alright, I went through all of core/ manually to move everything I could find to default initialization on declaration. clang-tidy only handled the cases ported to list initializers already, so there was a lot of manual work left.
Which also mean probably one or two PEBKACs that may result in a broken engine... we'll see :)

Marking as WIP again as it needs more testing, I spotted a few regressions:

Some text is missing in the project manager (welp)

Project manager crashes on exit with:

Thread 1 "godot-git" received signal SIGSEGV, Segmentation fault.
0x00000000045822bf in OS::print_error (this=0x0, p_function=0x58acd01 "unref", p_file=0x58acc80 "core/string_name.cpp", p_line=102, p_code=0x58acd07 "BUG!", p_rationale=0x58a21f0 "", p_type=Logger::ERR_ERROR)
    at core/os/os.cpp:120
120             _logger->log_error(p_function, p_file, p_line, p_code, p_rationale, p_type);
(gdb) bt
#0  0x00000000045822bf in OS::print_error (this=0x0, p_function=0x58acd01 "unref", p_file=0x58acc80 "core/string_name.cpp", p_line=102, p_code=0x58acd07 "BUG!", p_rationale=0x58a21f0 "",
    p_type=Logger::ERR_ERROR) at core/os/os.cpp:120
#1  0x00000000044026e8 in _err_print_error (p_function=0x58acd01 "unref", p_file=0x58acc80 "core/string_name.cpp", p_line=102, p_error=0x58acd07 "BUG!", p_message=0x58a21f0 "", p_type=ERR_HANDLER_ERROR)
    at core/error_macros.cpp:81
#2  0x000000000440260f in _err_print_error (p_function=0x58acd01 "unref", p_file=0x58acc80 "core/string_name.cpp", p_line=102, p_error=0x58acd07 "BUG!", p_type=ERR_HANDLER_ERROR) at core/error_macros.cpp:72
#3  0x00000000044ac554 in StringName::unref (this=0x7f37cf0) at core/string_name.cpp:102
#4  0x00000000044adb88 in StringName::~StringName (this=0x7f37cf0, __in_chrg=<optimized out>) at core/string_name.cpp:392
#5  0x0000000002df8a7e in Map<StringName, EditorDebuggerServer* (*)(String const&), Comparator<StringName>, DefaultAllocator>::Element::~Element (this=0x7f37cc0, __in_chrg=<optimized out>) at ./core/map.h:50
#6  0x0000000002df8aad in memdelete_allocator<Map<StringName, EditorDebuggerServer* (*)(String const&), Comparator<StringName>, DefaultAllocator>::Element, DefaultAllocator> (p_class=0x7f37cc0)
    at ./core/os/memory.h:128
#7  0x0000000002df86a6 in Map<StringName, EditorDebuggerServer* (*)(String const&), Comparator<StringName>, DefaultAllocator>::_cleanup_tree (this=0x69fb620 <EditorDebuggerServer::protocols>,
    p_element=0x7f37cc0) at ./core/map.h:496
#8  0x0000000002df8486 in Map<StringName, EditorDebuggerServer* (*)(String const&), Comparator<StringName>, DefaultAllocator>::clear (this=0x69fb620 <EditorDebuggerServer::protocols>) at ./core/map.h:651
#9  0x0000000002df90a8 in Map<StringName, EditorDebuggerServer* (*)(String const&), Comparator<StringName>, DefaultAllocator>::~Map (this=0x69fb620 <EditorDebuggerServer::protocols>, __in_chrg=<optimized out>)
    at ./core/map.h:671
#10 0x00007ffff779b867 in __run_exit_handlers () from /lib64/libc.so.6
#11 0x00007ffff779ba0a in exit () from /lib64/libc.so.6
#12 0x00007ffff7785ce1 in __libc_start_main () from /lib64/libc.so.6
#13 0x00000000019d158a in _start () at ../sysdeps/x86_64/start.S:120

Just to note, I've made some similar changes while developing some custom module in C++, and I've had linker errors related to undefined constructors, then after scons --clean which then forces full rebuild  I managed to compile everything again (MSVC 14.2).

Taking some notes for myself:

Some text is missing in the project manager (welp)

Reverting changes to scene fixes it, so I'll have to dig in there for the regression.

Project manager crashes on exit with:

After reverting all my changes... turns out it's a bug in the master branch and not this PR? :crying_cat_face:

Some text is missing in the project manager (welp)

I had removed too much stuff from the Label constructor by mistake, should now be fixed.

Project manager crashes on exit

Confirmed in the master branch, so it's not this PR. I opened #38729.

It seems to work well in my tests, so I'll merge. I'd still welcome a review by senior devs on the changes in core as my C++-fu is not the most extensive, but it should be fairly enough to fix any potential mistake that sneaked into this PR.


Provide support for preventing interference of autoscaling a single scale target when creating a new ScaledJob/ScaledObject

Proposal
We always recommend people to follow this guidance:

Only have one ScaledJob/ScaledObject with multiple triggers, instead of multiple instances
Do not mix and match ScaledJob/ScaledObject with your own HPA

However, we don't provide any prevention for this.
KEDA should automatically be rejecting new ScaledObject resources that are created which target a scale target which is already being autoscaled.
This should cover the following scenarios:

ScaledJob/ScaledObject targeting workload A, but workload A is already scaled by another ScaledJob/ScaledObject
ScaledJob/ScaledObject targeting workload A, but workload A is already scaled by another Horizontal Pod Autoscaler

Use-Case
Prevent end-users from having multiple actors scale workloads, either by accident or on purpose, to prevent flapping due to different criteria.
Anything else?
See https://github.com/kedacore/keda/discussions/3023 for the discussion

Just to be sure; are we effectively checking this today or was it closed by accident? (I think it's fine but just checking)

It was closed automatically because the feature is fully implemented.
Feature + Docs + Helm chart changes are merged (helm changes merge closed this)


RYA-443 Rya Streams Query Manager daemon program.

Description
Implemented an RPM installed CentOS 7 daemon service used to execute Kafka Streams jobs on the local machine. This is part of Rya Streams.
Tests
Wrote automated tests and executed the application on a CentOS 7 machine using the RPM.
Links
https://issues.apache.org/jira/browse/RYA-443

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/686/Build result: FAILURE[...truncated 3.04 MB...][INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 38:10 min[INFO] Finished at: 2018-02-08T22:18:44+00:00[INFO] Final Memory: 301M/2452M[INFO] ------------------------------------------------------------------------Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.1.5:attached-rpm (create-rpm-distribution) on project rya.streams.query-manager: Unable to query for default vendor from RPM: Error while executing process. Cannot run program "rpm": error=2, No such file or directory -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :rya.streams.query-managerchannel stoppedSetting status of b889bc0d60e3884ea31edbcb12fcc21331f77963 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/686/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/687/Build result: FAILURE[...truncated 3.01 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 40:57 min[INFO] Finished at: 2018-02-08T22:25:43+00:00[INFO] Final Memory: 546M/3106M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.1.5:attached-rpm (create-rpm-distribution) on project rya.streams.query-manager: Unable to query for default vendor from RPM: Error while executing process. Cannot run program "rpm": error=2, No such file or directory -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :rya.streams.query-managerchannel stoppedSetting status of 50a81217e5b16a4b1377f199aefc3a1c5a225216 to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/687/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

How do we want to deal with this project producing an RPM? The ASF jenkins doesn't have the rpm command installed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/691/Build result: FAILURE[...truncated 3.03 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 37:36 min[INFO] Finished at: 2018-02-14T20:56:07+00:00[INFO] Final Memory: 535M/2904M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.codehaus.mojo:rpm-maven-plugin:2.1.5:attached-rpm (create-rpm-distribution) on project rya.streams.query-manager: Unable to query for default vendor from RPM: Error while executing process. Cannot run program "rpm": error=2, No such file or directory -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR]   mvn  -rf :rya.streams.query-managerchannel stoppedSetting status of 6428ca81a5cb0ef5bd2e762452f1a6e46dff88fc to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/691/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing

I'm closing this because https://github.com/apache/incubator-rya/pull/279 takes it over.


Add pathogens to old phylo trees/runs

Summary:

What: Now that all phylo runs and phylo trees get created with a pathogen attached, update any old trees/runs that don't have pathogens.
Ticket: sc211476

Checklist:

[x] I merged latest <base branch>
[x] I manually verified the change
[x] I added labels to my PR
[ ] I tested in multiple browsers
[ ] I added relevant unit tests
[ ] I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

When adding pathogens to our unit tests, I'd originally added the pathogens to the db so every test didn't have to add pathogens to the db. I'm pretty sure that was the wrong call at this point, so I removed the automatic-pathogen-inserts and instead updated ~every test that needs pathogen info in the db to work properly.


options containing hyphens unrecognized

Options containing a hyphen, e.g. vorpal.command('t').option('a-b') are not added to args.options when given in the cli.
May I ask why vorpal doesn't simply wrap commander for command-parsing? I love what vorpal does, but this seems like reinventing the wheel - unless there's an obvious factor I'm missing...

Funny enough, I actually based the original code off commander. However, I needed it to do some things a little differently. For example, commander doesn't support multiple-worded commands, and this required a bit of refactor and deviation from commander's course. Vorpal also supports piped commands and will be supporting other bash logic such as &&, etc.
Does that clarify a bit? I'll definitely be fixing all of these points as soon as possible!

+1

Something that could be related to the same thing:
if you pass a literal argument value in quotes command "-value" it's not recognized as an argument but in this case as an option with name value

[ Accidentally wrote this in the PR instead of this ticket.  Moved it here. ]
Hi,
Just submitted a PR for this.  Yesterday I was trying to add a --dry-run option and noticed it wasn't passing through.  I debugged and found the cause and came up with various solutions, then found this open ticket.
The cause:
In util.buildCommandArgs, this line:
      var long = String(o.long || '').replace(/--no-/g, '').replace(/-/g, '');

...normalizes o.long to "dryrun", but when this option was first defined in util.parseArgs, it was normalized using minimist to "dry-run", so the match in util.buildCommandArgs here fails:
      exist = exist === undefined && parsedArgs[long] !== undefined ? parsedArgs[long] : exist;

In the PR I just submitted I opted for a simple, direct fix, changing .replace(/-/g, '') to .replace(/^-*/g, '') so that only leading dashes are replaced.  (I just now noticed I forgot to remove the /g, which is now superfluous).
The more bulletproof solution would be to use parsedArgs in both places, perhaps something like this:
function normalizeArg(str) {
      var obj = minimist([str]);
      var normalizedArg;

      for (var key in obj) {
        if (obj.hasOwnProperty(key)) {
          if (key !== '_') {
            normalizedArg = key;
            break;
          }
        }
      }

      return normalizedArg;
    };

...

      var long = normalizeArg(String(o.long || '').replace(/--no-/g, ''));

I did test this and it worked, but you can see it's a bit awkward due to the fact that parseArgs, like minimist, takes an array and returns an object with an added _ element.  Also, it sounds like the option parsing is going to be refactored at some point.  If it's desired, though, I can submit a separate PR that uses this approach.
I just now noticed that Travis CI builds failed with the same error I've been getting on my machine on gulp build.  To run the tests and get them to pass on my machine I had to edit dist/util.js as well as lib/util.js (but only checked in the latter, obviously).  This bugfix should work once gulp build is working again.
Hope this helps.  It would be great to have the ability to use hyphenated options because there are a lot of standard ones out there already.
Thanks.  Am really liking working with Vorpal so far.
.david


Encrypted Data fails Decryption

When data is encrypted it does not decrypt correctly when more than simple ASCII is used.

I believe this is resolved in #8


Worker added to JobInstance Event

It would be useful to be able to get the current worker object in the BEFORE_PERFORM event. Particularly this is to enable us to set custom proctitles.
Due to the shared fields and similar purpose I made JobInstanceEvent extend WorkerJobEvent.
Additionally added a guard in Process.php for calling setTitle out of the Process objects own process.

Added:

PHP 5.4+ is required for testing due to use of short array syntax

Hey Mathew,
Thanks once again.
Can you correct the spec file for Resque/Component/Job/Event/JobInstanceEvent missing WorkerInterface use, and add a similar example for the worker. See https://travis-ci.org/php-resque/resque/jobs/67620879#L196
On the PHP version support, I'd like to support 5.3 in the library if I could... I'd prefer to fix my usage of short hand array syntax (I thought I did)... Although I'm not sure of the reasoning (since unsupported etc)... Mmm.

Hey Mathew,
Thanks once again!
Can you correct the spec file for Resque/Component/Job/Event/JobInstanceEvent missing WorkerInterface use, and add a similar example as job, and performantjob for the worker. See https://travis-ci.org/php-resque/resque/jobs/67620879#L196
On the PHP version support, I'd like to support 5.3 in the library if I could... I'd prefer to fix my usage of short hand array syntax (I thought I did)... Although I'm not sure of the reasoning (since unsupported etc)... Mmm.

Personally I couldnt care less about 5.3 support, its two versions behind. The library still works, just cant be tested in 5.3 currently. I can do it though if thats the way you want to go.
I dont know much (anything) about phpspec currently. So I have refrained from making modifications except where missing classes / interfaces are concerned.

No worries.
Have a look at 0d5d496f522 to see the corresponding spec file changes for JobInstanceEvent.