[Widget test] Tapping DropdownMenuItem fails hit test

Steps to Reproduce

Create a new application project
change widget_test.dart to

import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  WidgetController.hitTestWarningShouldBeFatal = true;

  testWidgets('Clicking DropdownMenuItem should not fail', (WidgetTester tester) async {
    await tester.pumpWidget(MaterialApp(
      home: Scaffold(
        body: Builder(
          builder: (context) => DropdownButton<int>(
            key: Key('dropdown'),
            items: [
              DropdownMenuItem(key: Key('1'), value: 1, child: Text('1')),
              DropdownMenuItem(key: Key('2'), value: 2, child: Text('2')),
            ],
          ),
        ),
      ),
    ));

    await tester.tap(find.byKey(Key('dropdown')));
    await tester.pumpAndSettle();

    await tester.tap(find.byKey(Key('2')));
    await tester.pumpAndSettle();
  });
}

Run the test

Expected results:
The test is expected to succeed without any warnings or errors being thrown around
Actual results:
The test fails because the hit test for the line await tester.tap(find.byKey(Key('2'))); fails.

Logs

PS C:\Users\basro\Desktop\test\flutter_application_1> flutter test --verbose
[  +55 ms] executing: [C:\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +56 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] b22742018b3edf16c6cadd7b76d9db5e7f9064b5
[        ] executing: [C:\flutter/] git tag --points-at b22742018b3edf16c6cadd7b76d9db5e7f9064b5
[  +71 ms] Exit code 0 from: git tag --points-at b22742018b3edf16c6cadd7b76d9db5e7f9064b5
[        ] 2.2.0
[   +4 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +29 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/stable
[        ] executing: [C:\flutter/] git ls-remote --get-url origin
[  +25 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[ +100 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref HEAD
[  +29 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[  +80 ms] Found 1 files which will be executed as Widget Tests.
[   +6 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +47 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[        ] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'PubDependencies' is not required, skipping update.
[  +35 ms] Skipping pub get: version match.
[  +86 ms] Generating C:\Users\basro\Desktop\test\flutter_application_1\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[  +33 ms] running test package with arguments: [-r, compact, --timeout, 30s, --concurrency=14, --, C:\Users\basro\Desktop\test\flutter_application_1\test\widget_test.dart]
00:00 +0: loading C:\Users\basro\Desktop\test\flutter_application_1\test\widget_test.dart                                                                                [ +148 ms] test 0: starting test C:\Users\basro\Desktop\test\flutter_application_1\test\widget_test.dart
[   +5 ms] Stopping scan for flutter_test_config.dart; found project root at C:\Users\basro\Desktop\test\flutter_application_1
[   +2 ms] Compiler will use the following file as its incremental dill file: C:\Users\basro\AppData\Local\Temp\flutter_tools.9fdf716\flutter_test_compiler.e574d54\output.dill
[        ] Listening to compiler controller...
[   +8 ms] Compiling file:///C:/Users/basro/AppData/Local/Temp/flutter_tools.9fdf716/flutter_test_listener.6bec8238/listener.dart
[   +7 ms] C:\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev C:\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root C:\flutter\bin\cache\artifacts\engine\common\flutter_patched_sdk/ --incremental --no-print-incremental-dependencies --target=flutter
--debugger-module-names --experimental-emit-debug-metadata -DFLUTTER_WEB_AUTO_DETECT=true --output-dill C:\Users\basro\AppData\Local\Temp\flutter_tools.9fdf716\flutter_test_compiler.e574d54\output.dill --packages C:\Users\basro\Desktop\test\flutter_application_1\.dart_tool\package_config.json
-Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts --track-widget-creation --initialize-from-dill C:\Users\basro\Desktop\test\flutter_application_1\build\test_cache\build\c075001b96339384a97db4862b8ab8db.cache.dill.track.dill
[  +14 ms] <- compile file:///C:/Users/basro/AppData/Local/Temp/flutter_tools.9fdf716/flutter_test_listener.6bec8238/listener.dart
00:05 +0: loading C:\Users\basro\Desktop\test\flutter_application_1\test\widget_test.dart                                                                                [+5569 ms] <- accept
[        ] <- reset
[        ] Compiling C:\Users\basro\AppData\Local\Temp\flutter_tools.9fdf716\flutter_test_listener.6bec8238\listener.dart took 5591ms
[        ] test 0: starting test device
[   +4 ms] test 0: awaiting connection to test device
[   +1 ms] test 0: Observatory uri is not available
[   +6 ms] test 0: test harness socket server is running at port:56662
[   +1 ms] Using this directory for fonts configuration: C:\Users\basro\AppData\Local\Temp\flutter_tools.9fdf716\flutter_test_fonts.cf36d146
[   +1 ms] test 0: Starting flutter_tester process with command=[C:\flutter\bin\cache\artifacts\engine\windows-x64\flutter_tester.exe, --disable-observatory, --enable-checked-mode, --verify-entry-points, --enable-software-rendering, --skia-deterministic-rendering, --enable-dart-profiling, --non-interactive,
--use-test-fonts, --packages=C:\Users\basro\Desktop\test\flutter_application_1\.dart_tool\package_config.json, C:\Users\basro\AppData\Local\Temp\flutter_tools.9fdf716\flutter_test_listener.6bec8238\listener.dart.dill], environment={FLUTTER_TEST: true, FONTCONFIG_FILE:
C:\Users\basro\AppData\Local\Temp\flutter_tools.9fdf716\flutter_test_fonts.cf36d146/fonts.conf, SERVER_PORT: 56662, APP_NAME: flutter_application_1, UNIT_TEST_ASSETS: C:\Users\basro\Desktop\test\flutter_application_1\build\unit_test_assets}
[   +5 ms] test 0: Started flutter_tester process at pid 13132
[ +252 ms] test 0: connected to test device, now awaiting test result
[        ] test 0: Waiting for test harness or tests to finish
00:06 +0: Clicking DropdownMenuItem should not fail
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following assertion was thrown running a test:
Finder specifies a widget that would not receive pointer events.
A call to tap() with finder "exactly one widget with key [<'2'>] (ignoring offstage widgets):
DropdownMenuItem<int>-[<'2'>]" derived an Offset (Offset(8.0, 24.0)) that would not hit test on the
specified widget.
Maybe the widget is actually off-screen, or another widget is obscuring it, or the widget cannot
receive pointer events.
The finder corresponds to this RenderBox: RenderConstrainedBox#a92ad relayoutBoundary=up10 NEEDS-PAINT(creator: ConstrainedBox ← Container ← DropdownMenuItem<int>-[<'2'>] ← SizedBox ← IndexedStack ← Row ← Padding ← Container ← DefaultTextStyle ← Stack ← Listener ← _GestureSemantics ← ⋯, parentData: <none> (can use size), constraints: BoxConstraints(0.0<=w<=Infinity, h=48.0), size: Size(16.0, 48.0), additionalConstraints: BoxConstraints(0.0<=w<=Infinity, 48.0<=h<=Infinity))
The hit test result at that offset is: HitTestResult(RenderPointerListener#4ffa3@Offset(8.0, 24.0),
RenderSemanticsGestureHandler#36632@Offset(8.0, 24.0), RenderSemanticsAnnotations#b1bfe@Offset(8.0,
24.0), RenderSemanticsAnnotations#c0919@Offset(8.0, 24.0),
RenderCustomMultiChildLayoutBox#295fe@Offset(8.0, 24.0), _RenderInkFeatures#ee8e8@Offset(8.0, 24.0),
RenderPhysicalModel#5cd86@Offset(8.0, 24.0), RenderSemanticsAnnotations#b0f1e@Offset(8.0, 24.0),
RenderRepaintBoundary#066cf@Offset(8.0, 24.0), RenderIgnorePointer#4f73e@Offset(8.0, 24.0),
RenderAnimatedOpacity#b7673@Offset(8.0, 24.0), RenderRepaintBoundary#e2a32@Offset(8.0, 24.0),
RenderSemanticsAnnotations#241e3@Offset(8.0, 24.0), RenderOffstage#84140@Offset(8.0, 24.0),
RenderSemanticsAnnotations#59452@Offset(8.0, 24.0), _RenderTheatre#0aa69@Offset(8.0, 24.0),
RenderSemanticsAnnotations#66eaf@Offset(8.0, 24.0), RenderAbsorbPointer#c4c50@Offset(8.0, 24.0),
RenderPointerListener#533ad@Offset(8.0, 24.0), RenderCustomPaint#91e3b@Offset(8.0, 24.0),
RenderSemanticsAnnotations#7d419@Offset(8.0, 24.0), RenderSemanticsAnnotations#99934@Offset(8.0,
24.0), RenderSemanticsAnnotations#91061@Offset(8.0, 24.0), HitTestEntry#062cb(RenderView#eb2b7),
HitTestEntry#d0def(<AutomatedTestWidgetsFlutterBinding>))
If you expected this target not to be able to receive pointer events, pass "warnIfMissed: false" to
"tap()".
To make this error into a non-fatal warning, set WidgetController.hitTestWarningShouldBeFatal to
false.

When the exception was thrown, this was the stack:
#0      WidgetController._getElementPoint (package:flutter_test/src/controller.dart:934:11)
#1      WidgetController.getCenter (package:flutter_test/src/controller.dart:836:12)
#2      WidgetController.tap (package:flutter_test/src/controller.dart:271:18)
#3      main.<anonymous closure> (file:///C:/Users/basro/Desktop/test/flutter_application_1/test/widget_test.dart:32:18)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

The test description was:
  Clicking DropdownMenuItem should not fail
════════════════════════════════════════════════════════════════════════════════════════════════════
00:06 +0 -1: Clicking DropdownMenuItem should not fail [E]
  Test failed. See exception logs above.
  The test description was: Clicking DropdownMenuItem should not fail

[ +568 ms] test 0: Test harness is no longer needed by test process
[        ] test 0: finished
[   +1 ms] test 0: cleaning up...
[        ] test 0: ensuring test device is terminated.
[        ] test 0: Terminating flutter_tester process
[        ] test 0: Shutting down test harness socket server
[        ] test 0: Test process is no longer needed by test harness
[   +9 ms] test 0: flutter_tester process at pid 13132 exited with code=-1
[        ] test 0: deleting temporary directory
[   +2 ms] test 0: finished
00:06 +0 -1: Some tests failed.
[   +7 ms] Deleting C:\Users\basro\AppData\Local\Temp\flutter_tools.9fdf716\flutter_test_compiler.e574d54...
[   +3 ms] killing pid 21820
[  +43 ms] Deleting C:\Users\basro\AppData\Local\Temp\flutter_tools.9fdf716\flutter_test_fonts.cf36d146...
[   +2 ms] test package returned with exit code 1
[   +6 ms] "flutter test" took 6.909ms.
[   +3 ms]
           #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
           #1      TestCommand.runCommand (package:flutter_tools/src/commands/test.dart:468:7)
           <asynchronous suspension>
           #2      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1043:27)
           <asynchronous suspension>
           #3      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #4      CommandRunner.runCommand (package:args/command_runner.dart:196:13)
           <asynchronous suspension>
           #5      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:284:9)
           <asynchronous suspension>
           #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #7      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:232:5)
           <asynchronous suspension>
           #8      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
           <asynchronous suspension>
           #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #10     main (package:flutter_tools/executable.dart:91:3)
           <asynchronous suspension>

[   +4 ms] Running shutdown hooks
[        ] Shutdown hooks complete
[        ] exiting with code 1

PS C:\Users\basro\Desktop\test\flutter_application_1> flutter analyze
Analyzing flutter_application_1...
No issues found! (ran in 1.0s)

PS C:\Users\basro\Desktop\test\flutter_application_1> flutter doctor -v
[√] Flutter (Channel stable, 2.2.0, on Microsoft Windows [Version 10.0.19042.985], locale nl-NL)
    • Flutter version 2.2.0 at C:\flutter
    • Framework revision b22742018b (4 days ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\basro\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 51.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.56.2)
    • VS Code at C:\Users\basro\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 90.0.4430.212
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 90.0.818.62

• No issues found!

@Tregan
I am getting compile error on the setter : WidgetController.hitTestWarningShouldBeFatal = true;
Where is it coming from ?

@darshankawar This is included in the flutter_test package and makes it so that any hit test failures during tests fail the test, instead of just printing the warning.

Ah. Thanks. I was on 2.0.6 on which it gives that error. Running the test fails with below log:

 console error log

Testing started at 7:05 PM ...
/Users/dhs/Documents/Fluttersdk/flutter/bin/flutter --no-color test --machine --start-paused test/widget_test.dart
Running "flutter pub get" in bug_test...                         1,686ms

══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following assertion was thrown running a test:
Finder specifies a widget that would not receive pointer events.
A call to tap() with finder "exactly one widget with key [<'2'>] (ignoring offstage widgets):
DropdownMenuItem<int>-[<'2'>]" derived an Offset (Offset(8.0, 24.0)) that would not hit test on the
specified widget.
Maybe the widget is actually off-screen, or another widget is obscuring it, or the widget cannot
receive pointer events.
The finder corresponds to this RenderBox: RenderConstrainedBox#747ec relayoutBoundary=up10 NEEDS-PAINT(creator: ConstrainedBox ← Container ← DropdownMenuItem<int>-[<'2'>] ← SizedBox ← IndexedStack ← Row ← Padding ← Container ← DefaultTextStyle ← Stack ← Listener ← _GestureSemantics ← ⋯, parentData: <none> (can use size), constraints: BoxConstraints(0.0<=w<=Infinity, h=48.0), size: Size(16.0, 48.0), additionalConstraints: BoxConstraints(0.0<=w<=Infinity, 48.0<=h<=Infinity))
The hit test result at that offset is: HitTestResult(RenderPointerListener#8a870@Offset(8.0, 24.0),
RenderSemanticsGestureHandler#4c3d5@Offset(8.0, 24.0), RenderSemanticsAnnotations#dd5dd@Offset(8.0,
24.0), RenderSemanticsAnnotations#07230@Offset(8.0, 24.0),
RenderCustomMultiChildLayoutBox#367d5@Offset(8.0, 24.0), _RenderInkFeatures#50a91@Offset(8.0, 24.0),
RenderPhysicalModel#cbd4c@Offset(8.0, 24.0), RenderSemanticsAnnotations#45167@Offset(8.0, 24.0),
RenderRepaintBoundary#d808f@Offset(8.0, 24.0), RenderIgnorePointer#54611@Offset(8.0, 24.0),
RenderAnimatedOpacity#fd893@Offset(8.0, 24.0), RenderRepaintBoundary#7a168@Offset(8.0, 24.0),
RenderSemanticsAnnotations#12f36@Offset(8.0, 24.0), RenderOffstage#438a3@Offset(8.0, 24.0),
RenderSemanticsAnnotations#444d1@Offset(8.0, 24.0), _RenderTheatre#347ca@Offset(8.0, 24.0),
RenderSemanticsAnnotations#634ac@Offset(8.0, 24.0), RenderAbsorbPointer#7ba4e@Offset(8.0, 24.0),
RenderPointerListener#884aa@Offset(8.0, 24.0), RenderCustomPaint#d470b@Offset(8.0, 24.0),
RenderSemanticsAnnotations#54475@Offset(8.0, 24.0), RenderSemanticsAnnotations#66c57@Offset(8.0,
24.0), RenderSemanticsAnnotations#779f3@Offset(8.0, 24.0), HitTestEntry#5e9fe(RenderView#2b2ee),
HitTestEntry#f9f39(<AutomatedTestWidgetsFlutterBinding>))
If you expected this target not to be able to receive pointer events, pass "warnIfMissed: false" to
"tap()".
To make this error into a non-fatal warning, set WidgetController.hitTestWarningShouldBeFatal to
false.

When the exception was thrown, this was the stack:
#0      WidgetController._getElementPoint (package:flutter_test/src/controller.dart:934:11)
#1      WidgetController.getCenter (package:flutter_test/src/controller.dart:836:12)
#2      WidgetController.tap (package:flutter_test/src/controller.dart:271:18)
#3      main.<anonymous closure> (file:///Users/dhs/Documents/NCFlutter/bug_test/test/widget_test.dart:25:18)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

The test description was:
  Clicking DropdownMenuItem should not fail
════════════════════════════════════════════════════════════════════════════════════════════════════

Test failed. See exception logs above.
The test description was: Clicking DropdownMenuItem should not fail

 flutter doctor -v
[✓] Flutter (Channel stable, 2.2.0, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.2.0 at /Users/dhs/documents/fluttersdk/flutter
    • Framework revision b22742018b (4 days ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.55.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (3 available)
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                               •
      web-javascript • Google Chrome 90.0.4430.212

! Doctor found issues in 1 category.

I have a lot of false positives for hit test failures after 2.2.0 upgrade, in Dropdowns, in Dialogs and in TextInputs.
Adding warnIfMissed doesn't seem right.

This is still the case in Flutter 2.5.0 (stable) as well as master (2.6.0), even after these fixes: https://github.com/flutter/flutter/issues/80856 https://github.com/flutter/flutter/pull/86449

Logs
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following assertion was thrown running a test:
Finder specifies a widget that would not receive pointer events.
A call to tap() with finder "exactly one widget with key [<'2'>] (ignoring offstage widgets):
DropdownMenuItem<int>-[<'2'>]" derived an Offset (Offset(8.0, 24.0)) that would not hit test on the
specified widget.
Maybe the widget is actually off-screen, or another widget is obscuring it, or the widget cannot
receive pointer events.
The finder corresponds to this RenderBox: RenderConstrainedBox#56326 relayoutBoundary=up11 NEEDS-PAINT(creator: ConstrainedBox ← Container ← DropdownMenuItem<int>-[<'2'>] ← SizedBox ← IndexedStack ← Row ← Padding ← Container ← DefaultTextStyle ← Stack ← Listener ← _GestureSemantics ← ⋯, parentData: <none> (can use size), constraints: BoxConstraints(0.0<=w<=Infinity, h=48.0), size: Size(16.0, 48.0), additionalConstraints: BoxConstraints(0.0<=w<=Infinity, 48.0<=h<=Infinity))
The hit test result at that offset is: HitTestResult(RenderPointerListener#87fae@Offset(8.0, 24.0),
RenderSemanticsGestureHandler#30e25@Offset(8.0, 24.0), RenderMouseRegion#7436b@Offset(8.0, 24.0),
RenderSemanticsAnnotations#1af09@Offset(8.0, 24.0), RenderSemanticsAnnotations#88f0a@Offset(8.0,
24.0), RenderCustomMultiChildLayoutBox#f3440@Offset(8.0, 24.0), _RenderInkFeatures#2e86b@Offset(8.0,
24.0), RenderPhysicalModel#951c6@Offset(8.0, 24.0), RenderSemanticsAnnotations#768e8@Offset(8.0,
24.0), RenderRepaintBoundary#57e0a@Offset(8.0, 24.0), RenderIgnorePointer#6a967@Offset(8.0, 24.0),
RenderAnimatedOpacity#6514a@Offset(8.0, 24.0), RenderRepaintBoundary#a7174@Offset(8.0, 24.0),
_RenderFocusTrap#3f33a@Offset(8.0, 24.0), RenderSemanticsAnnotations#efb3d@Offset(8.0, 24.0),
RenderOffstage#604f5@Offset(8.0, 24.0), RenderSemanticsAnnotations#a6aa5@Offset(8.0, 24.0),
_RenderTheatre#3d8e8@Offset(8.0, 24.0), RenderSemanticsAnnotations#d19e7@Offset(8.0, 24.0),
RenderAbsorbPointer#24d5d@Offset(8.0, 24.0), RenderPointerListener#07cc4@Offset(8.0, 24.0),
RenderCustomPaint#ef1f3@Offset(8.0, 24.0), RenderSemanticsAnnotations#c5d6e@Offset(8.0, 24.0),
RenderSemanticsAnnotations#181df@Offset(8.0, 24.0), RenderSemanticsAnnotations#766c5@Offset(8.0,
24.0), RenderSemanticsAnnotations#e27c6@Offset(8.0, 24.0), HitTestEntry#cefd4(RenderView#c994c),
HitTestEntry#b7a91(<AutomatedTestWidgetsFlutterBinding>))
If you expected this target not to be able to receive pointer events, pass "warnIfMissed: false" to
"tap()".
To make this error into a non-fatal warning, set WidgetController.hitTestWarningShouldBeFatal to
false.

When the exception was thrown, this was the stack:
#0      WidgetController._getElementPoint (package:flutter_test/src/controller.dart:939:11)
#1      WidgetController.getCenter (package:flutter_test/src/controller.dart:841:12)
#2      WidgetController.tap (package:flutter_test/src/controller.dart:273:18)
#3      main.<anonymous closure> (file:///C:/Users/basro/Downloads/tmp/flutter_application_1/test/flutter_application_1_test.dart:25:18)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)

The test description was:
  Clicking DropdownMenuItem should not fail
════════════════════════════════════════════════════════════════════════════════════════════════════

flutter doctor -v
[√] Flutter (Channel master, 2.6.0-1.0.pre.238, on Microsoft Windows [Version 10.0.19043.1165], locale nl-NL)
    • Flutter version 2.6.0-1.0.pre.238 at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 53e851162e (5 hours ago), 2021-09-10 01:37:42 -0400
    • Engine revision 825c409164
    • Dart version 2.15.0 (build 2.15.0-93.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\basro\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 2020.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] VS Code (version 1.60.0)
    • VS Code at C:\Users\basro\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.26.0

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 93.0.4577.63
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 93.0.961.38

• No issues found!

Trying to hit the text of options in a PopupMenuButton also gets flagged with the warnIfMissed warning.

It's weird, this isn't always reliably a problem. For example, the first case below passes, but the second fails:
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  WidgetController.hitTestWarningShouldBeFatal = true;

   testWidgets('Clicking DropdownMenuItem should not fail', (WidgetTester tester) async {
    await tester.pumpWidget(MaterialApp(
      home: Center(
        child: Material(
          child: DropdownButton<int>(
            key: Key('button'),
            onChanged: (int? result) { },
            items: <DropdownMenuItem<int>>[
              const DropdownMenuItem<int>(
                key: Key('item'),
                value: 1,
                child: Text('111111111111111111'),
              ),
            ],
          ),
	),
      ),
    ));
    await tester.tap(find.byKey(Key('button')));
    await tester.pump();
    await tester.pump(const Duration(seconds: 1));
    await tester.tap(find.byKey(Key('item')).at(1));
  });

  testWidgets('Clicking DropdownMenuItem should not fail', (WidgetTester tester) async {
    await tester.pumpWidget(
      MaterialApp(
        home: Center(
          child: Material(
            child: DropdownButton<int>(
              onChanged: (int? value) { },
              key: Key('button'),
              items: <DropdownMenuItem<int>>[
                DropdownMenuItem(
                  key: Key('item'),
                  value: 1,
                  child: Text('1'),
                ),
              ],
            ),
          ),
        ),
      ),
    );
    await tester.tap(find.byKey(Key('button')));
    await tester.pump();
    await tester.pump(const Duration(seconds: 1));
    await tester.tap(find.byKey(Key('item')).at(1));
  });
}

Still seeing this, and yes, it seems like the length of the text matters. In my test case it failed with the text 'Foo' but passed with 'FooFoo'.

I decided to check this again, and the issue seems to have been fixed.
Flutter 3.7.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision b06b8b2710 (5 weeks ago) • 2023-01-23 16:55:55 -0800
Engine • revision b24591ed32
Tools • Dart 2.19.0 • DevTools 2.20.1


on windows, shift and mouse wheel cause diagonal scrolling when terminal has fixed width

to do this, I think upstream we'd need to expose isUserScrolling so that we can set that to false when the shift key is pressed and there's a horizontal scrollbar.
https://github.com/xtermjs/xterm.js/blob/1c087f6bcd510ba3ce34f72397dc156d8fc5003d/src/common/services/BufferService.ts#L23-L23

tried this, think maybe this needs an upstream fix
this._register(dom.addDisposableListener(xterm.element, 'wheel', (e) => { 			xterm.attachCustomKeyEventHandler((event: KeyboardEvent) => { 				if (event.shiftKey && this._hasScrollBar) { 					e.stopImmediatePropagation(); 					return false; 				} 				return true; 			}); 		}));

we either need to use a vertical scrollbar instead of the built in one to xterm.js or somehow intercept and stop the onWheel from getting to xterm when shift is held down and there's a horizontal scrollbar

for now, just disabling the mouse wheel scroll so this diagonal scrolling isn't possible


Star/favorites for links

Should be able to star/favorite a link, so it stays in the main list even after clicking.

Completed with V2.0.1


[Release-1.26] - New EtcdIsVoter Node condition should update status on a cluster-reset

Backport fix for New EtcdIsVoter Node condition should update status on a cluster-reset

#9048

Validated on Version:
-$ k3s version v1.26.12+k3s-3d70c8ad (3d70c8ad)

Environment Details
Infrastructure
Cloud EC2 instance
Node(s) CPU architecture, OS, and Version:
PRETTY_NAME="Ubuntu 22.04.1 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
Cluster Configuration:
3 node server
1 agent server
Steps to validate the fix

Create a k3s cluster with 3 servers and 1 agent
Snapshot the server and get the token
Delete/Terminate all nodes
Restore snapshot on a new fresh node
Validate it works
Validate Nodes and pods are ok
Validate that conditions field is properly set

Reproduction Issue:

Validation Results:

 sudo k3s etcd-snapshot save \
--s3 \
--s3-bucket=" " \
--s3-access-key="   " \
--s3-secret-key="   " \
--s3-region="" \
--s3-timeout=90s

---------- New node --------

sudo k3s server \
--cluster-reset \
--etcd-s3 \
--cluster-reset-restore-path="on-demand-ip " \
--etcd-s3-bucket=" " \
--etcd-s3-region="" \
--etcd-s3-access-key=" " \
--etcd-s3-secret-key="" \
--token=" "

~$ k3s -v
k3s version v1.26.12+k3s-3d70c8ad (3d70c8ad)
go version go1.20.12

~$ kubectl get node -o yaml

      conditions:
    - lastHeartbeatTime: "2024-01-17T10:22:07Z"
      lastTransitionTime: "2024-01-17T10:22:07Z"
      message: Node is not a member of the etcd cluster
      reason: NotAMember
      status: "False"
      type: EtcdIsVoter


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_3dty_uibp_/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_3dty_uibp_/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_3dty_uibp_/clone/recipe/meta.yaml:43: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_3dty_uibp_/clone/recipe/meta.yaml:43: missing_description: The recipe is missing a description
ERROR: /tmp/abs_3dty_uibp_/clone/recipe/meta.yaml:43: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_3dty_uibp_/clone/recipe/meta.yaml:43: missing_dev_url: The recipe is missing a dev_url
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_9cgj8o_woq/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_9cgj8o_woq/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_9cgj8o_woq/clone/recipe/meta.yaml:43: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_9cgj8o_woq/clone/recipe/meta.yaml:43: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_9cgj8o_woq/clone/recipe/meta.yaml:43: missing_dev_url: The recipe is missing a dev_url
WARNING: /tmp/abs_9cgj8o_woq/clone/recipe/meta.yaml:43: missing_description: The recipe is missing a description
Errors were found


TRG 5.07 Dependencies are present and properly configured in the Chart.yaml

https://eclipse-tractusx.github.io/docs/release/trg-5/trg-5-07#aligning-dependency-versions

Version version: 11.9.13 found in
https://github.com/eclipse-tractusx/bpdm/blob/eb05a1f02b11f6513d3545e6c29131efd4c4c70c/charts/bpdm/Chart.yaml#L56
https://github.com/eclipse-tractusx/bpdm/blob/eb05a1f02b11f6513d3545e6c29131efd4c4c70c/charts/bpdm/charts/bpdm-bridge-dummy/Chart.yaml#L32
https://github.com/eclipse-tractusx/bpdm/blob/eb05a1f02b11f6513d3545e6c29131efd4c4c70c/charts/bpdm/charts/bpdm-pool/Chart.yaml#L32
https://github.com/eclipse-tractusx/bpdm/blob/eb05a1f02b11f6513d3545e6c29131efd4c4c70c/charts/bpdm/charts/bpdm-gate/Chart.yaml#L32

Is the change to 12.X.X mandatory for Rel. 24.03 or could it be done in next release ? the impact and effort is huge for us, no use case would run cause of an empty database (no BPNs) @rybtim fyi

Info to this Check:
we don't have to upgrade postgres because 15 is still supported until ka 2027. so there's no rush and we won't do it now but after  release "24.03"

@HeyHardy as already written in direct chat, will leave the issue open for the next release 👍🏼

@HeyHardy i honestly don't know why we had this misscommunication, but YES we definitly need to align the postgresql version across all produts to be on postgresql 15!!
I'm totally lost why we have not enforced this

@RolaH1t for me this is a hard release blocker FYI

11.9.13 is 14.5.0 This makes it potentially incompatible

Postgres dependency is updated to 12.12.10 and is now compatible with the TRGs


Fix links in documentations

The main change (in term of importance) is the fix of two broken links that were
pointing to outdated sections ids.

Added a link to mermaidCLI in the sequenceDiagram section, to reflect the one in
the gantt section.

Converted some links to https.

I also isolated that the "Simple full example" section in usage.md is the one that is breaking the site (#484), however I don't really know how to fix it and I'm not in capacity of generating the documentation locally (don't really know how) to check and debug it, so I'm leaving it to you.

Fascinating that this commit somehow broke the build... I cant understand how that is possible. Merging anyways assuming the problem was on the travis side. Anyway, thanks! Important with good docs!


[Bug] DllNotFoundException: Unable to load DLL 'FirebaseCppApp-12_1_0'

Description
Exception: System.TypeInitializationException: The type initializer for 'Firebase.FirebaseApp' threw an exception. ---> System.TypeInitializationException: The type initializer for 'Firebase.LogUtil' threw an exception. ---> System.TypeInitializationException: The type initializer for 'Firebase.AppUtilPINVOKE' threw an exception. ---> System.TypeInitializationException: The type initializer for 'Firebase.AppUtilPINVOKE.SWIGExceptionHelper' threw an exception. ---> System.DllNotFoundException: Unable to load DLL 'FirebaseCppApp-12_0_0'. Tried the load the following dynamic libraries: Unable to load dynamic library 'FirebaseCppApp-12_0_0' because of 'Failed to open the requested dynamic library (0x06000000) dlerror() = dlopen failed: library "FirebaseCppApp-12_0_0" not found
DllNotFoundException: Unable to load DLL 'FirebaseCppApp-12_0_0'. Tried the load the following dynamic libraries: Unable to load dynamic library 'FirebaseCppApp-12_0_0' because of 'Failed to open the requested dynamic library (0x06000000) dlerror() = dlopen failed: library "FirebaseCppApp-12_0_0" not found
Reproducing the issue
We are in the process of updating out app to unity 2022.3.35f1
We updated our firebase version from 9.1.0 to 12.1.0. while the build succeeds, on arriving to the home screen we get the above errors. We have done some research into others who have faced this problem however none of their fixes have worked for us
Attempted Resolutions:

higher min sdk version (23 > 24)
Force resolving using EDM
Tried removing firebase/EDM and reinstalling
Tried removing firebase and install using the .tgz/package manager method
Tried updating EDM to the newest version
Tried relocating the FirebaseCppApp-12_1_0 files
Tried enabling 'any platform' for all FirebaseCppApp-12_1_0 files
Update Microsoft Visual C++ 2015-2022 Redistributable to the latest version
Updating Gradle to 8.0+
Updating NDK (not sure this valid)
Fresh unity install
Rolling back Firebase to Unity 12.0

Firebase Unity SDK Version
12.1.0
Unity editor version
2022.3.35f1
Installation Method
.unitypackage
Problematic Firebase Component(s)
No response
Other Firebase Component(s) in use
Analytics, Crashlytics, In-App Messaging, Remote Config
Additional SDKs you are using
No response
Targeted Platform(s)
Android
Unity editor platform
Windows
Scripting Runtime
IL2CPP
Release Distribution Type
Pre-built SDK from https://firebase.google.com/download/unity
Relevant Log Output
No response
If using CocoaPods for Apple platforms, the project's Podfile.lock

Expand Podfile.lock snippet

👀 Replace this line with the contents of your Podfile.lock!

Thanks for reaching out, @ClairePeta-36. Firebase version 12.0.0+ requires a higher version of AGP and Gradle to work. This is only available in the latest versions of the Unity Editor. Could you try using version 2022.3.41f1 and see if it works? Thanks!

@argzdev , I tried with 2022.3.41f1 but still same error. It doesn't happen when I install the built apk to an android device. However, in editor, in play mode it always shows up.
DllNotFoundException: FirebaseCppApp-12_0_0 assembly:<unknown assembly> type:<unknown type> member:(null) Firebase.AppUtilPINVOKE+SWIGExceptionHelper..cctor () (at /home/runner/work/firebase-unity-sdk/firebase-unity-sdk/linux_unity/app/swig/Firebase.App_fixed.cs:3958)
The project is at the latest unity supported gradle (com.android.tools.build:gradle:7.4.2).
This is really annoying. Google set a deadline to target API level 34. Firebase brings Android 14 support after 12.0.0. And we still dealing with dll errors.

We've recently fixed an issue with the unity-jar-resolver. The fix is now released in version 12.2.0. It should work correctly. Could you try?

@argzdev ,
Thanks for your quick response. I use Android Resolver version 1.2.182. I tried Firebase 12.2.0 too with this resolver version, it still throws the same error. Please note that, I can build it and run it in a real Android device. There is no problem in an Android device (with Android 14). This only happens in Editor, in Play mode.
I have many remote controls from Firebase RemoteConfig. So, the DLL error at the beginning, even for Editor's play mode, makes my development very difficult. It completely disables remote config activities.
2- I tried both of them, there is still error :(
3- FirebaseAnalytics, FirebaseMessaging, FirebaseRemoteConfig.
The error starts when it calls RemoteConfig methods as the following:
DllNotFoundException: FirebaseCppApp-12_2_0 assembly:<unknown assembly> type:<unknown type> member:(null) Firebase.AppUtilPINVOKE+SWIGExceptionHelper..cctor () (at /home/runner/work/firebase-unity-sdk/firebase-unity-sdk/linux_unity/app/swig/Firebase.App_fixed.cs:3958) Rethrow as TypeInitializationException: The type initializer for 'SWIGExceptionHelper' threw an exception. Firebase.AppUtilPINVOKE..cctor () (at /home/runner/work/firebase-unity-sdk/firebase-unity-sdk/linux_unity/app/swig/Firebase.App_fixed.cs:3978) Rethrow as TypeInitializationException: The type initializer for 'Firebase.AppUtilPINVOKE' threw an exception. Firebase.AppUtil.SetLogFunction (Firebase.LogUtil+LogMessageDelegate arg0) (at /home/runner/work/firebase-unity-sdk/firebase-unity-sdk/linux_unity/app/swig/Firebase.App_fixed.cs:4688) Firebase.LogUtil..ctor () (at /home/runner/work/firebase-unity-sdk/firebase-unity-sdk/app/src/LogUtil.cs:81) Firebase.LogUtil..cctor () (at /home/runner/work/firebase-unity-sdk/firebase-unity-sdk/app/src/LogUtil.cs:37) Rethrow as TypeInitializationException: The type initializer for 'Firebase.LogUtil' threw an exception. Rethrow as TypeInitializationException: The type initializer for 'Firebase.FirebaseApp' threw an exception. Firebase.RemoteConfig.FirebaseRemoteConfig.get_DefaultInstance () (at /home/runner/work/firebase-unity-sdk/firebase-unity-sdk/remote_config/src/FirebaseRemoteConfig.cs:164)

Thanks for the extra details, @seanlcnr. Hmm, that's interesting. I tried testing with our Firebase Unity Quickstart adding Firebase SDK v12.2.0 via Import Asset or Package Manager. Both methods seems to run correctly in the Unity Editor 2022.3.40f1.
I'm wondering, if it works on building an Android app, could it be a permission error? Can you check this Stack Overflow thread:

Remove Firebase and external library folder from Assets.
Import again.
Run Unity, you will get popup of unidentified developer. And you have only two options in popup so you can select to move to bin.
Then in system preferences -> Allow bundle.
Open Bin and drag and drop deleted bundle which is "FirebaseCppApp-11_6_0.bundle" to Assets in Unity.
Make sure settings allow that bundle.
Run Unity and it will run project successfully!

Either that, or the Firebase packages were not imported properly. You might have to try re-importing all Firebase packages including the ED4MU and then do a clean build. In case you've used Assets > Import Package > Custom Package, you can use Assets > External Dependency Manager > Version Handler > Uninstall Managed Packages to properly remove all added Firebase assets to make sure no random files are left before adding via Package Manager.
Let me know if these help!

@argzdev thanks for your detailed guide.
I did apply everything you said, but it still throws the same error. I also tried opening Unity as administrator mode.
FirebaseCppApp-12_2_0.dll
FirebaseCppApp-12_2_0.so
FirebaseCppApp-12_2_0.bundle

These files are under Assets/Firebase/Plugins/x86_64 folder. My OS is Windows 10 Enterprise LTSC - 64-bit. Does it really check exaclty this folder? Should I move these files to another folder? I think this is only a "read" operation. It doesn't try to write/change these files, it only reads, but cannot find the file some how. Does it still need an additional permission at the OS level?
By the way, Firebase version 11_1_0 works fine on the same OS, same Unity version, same project. However, it doesn't support Android 14 I guess. So I have to stay at 12_0_0+

I'm finding that recently the latest Firebase and ED4MU DLLs keep changing their platform settings either unmarking the current platform or unmarking all platforms which causes DLL not found errors like the one you've encountered.

Make sure all the DLL files in ExternalDependencyManager/Editor/1.2.182/ have Editor ticked as an included platform
Make sure the DLL files in Firebase/Plugins/ have Editor/Standalone/Android marked as included platforms for Firebase.Analytics.dll, Firebase.App.dll, Firebase.Crashlytics.dll, Firebase.Installations.dll, Firebase.Messaging.dll (or more depending on firebase modules being used) and Firebase.Platform.dll, Firebase.TaskExtension.dll and Google.MiniJson.dll include Editor/Standalone/iOS/Android
Make sure DLLs inside Firebase/<platform folder> have that platform selected marked as included

I'm not sure what causes these platform settings to change but I've ran into this issue multiple times with different projects since updating to Firebase 12.2.0

Thanks for the extra details, @seanlcnr. So far, I'm unable to reproduce the same behavior. I'm wondering if the issue is due to the different OS being used. Currently, I'm testing with a macOS Sonoma 14.6.1 , we don't have a Windows device ready for testing, so we'll try and figure something out. By the way, is there any difference in behavior if you import the Firebase SDK using the Assets > Import Package > Custom Package?

We are still experiencing this issue on all android builds, our IOS and windows builds are running as expected; we have noticed that when we open the apk in Android studio the file can be seen in the lib folder as shown below

We have tried updating to the latest unity version; 2022.3.43f1 with no difference, we have currently downgraded to the 11.9.0 firebase and targeting API 33 to see if that resolves the issue but so far no difference. We have tried all the version of EDM ranging from the one installed with the 11.9.0 firebase packages up to the latest release. Also tried on numerous computer with fresh installs of unity just incase it was something local

Sorry, we're still unable to reproduce the same behavior. Are you able to reproduce this behavior on a fresh project? If so, could you share with us an MCVE, so we can investigate further?

This morning i have tested a brand new project in 2022.3.35f1. Installed the gpgs-0.11.0 unity package, FirebaseCrashlytics_11.9.0 package, and the FirebaseAnalytics_11.9.0 package. I added a script to init firebase (FirebaseApp.CheckAndFixDependenciesAsync().ContinueWithOnMainThread()) on start. and on an android build i am still receiving the following error

It could be a configuration issue, but again, without a proper MCVE, it'll be difficult for us to investigate this further especially since we aren't encountering this behavior on our side. You may also try using our Firebase Quickstart for references. Thanks

谢谢你提供更多详细信息，@seanlcnr。嗯，这很有趣。我尝试使用我们的Firebase Unity Quickstartv12.2.0通过Import Asset或添加 Firebase SDK进行测试Package Manager。这两种方法似乎都可以在 Unity 编辑器2022.3.40f1或内置的 Android 应用中正确运行。
我想知道，如果它可以构建 Android 应用，那么这可能是权限错误吗？您可以查看这个Stack Overflow 线程吗：

从 Assets 中删除 Firebase 和外部库文件夹。
再次导入。
运行 Unity，您将看到未识别开发人员的弹出窗口。弹出窗口中只有两个选项，您可以选择将其移至 bin。
然后在系统偏好设置->允许捆绑。
打开 Bin，将已删除的 bundle “FirebaseCppApp-11_6_0.bundle” 拖放到 Unity 中的 Assets 中。
确保设置允许该捆绑。
运行Unity，项目将成功运行！

要么是 Firebase 包没有正确导入。您可能必须尝试重新导入所有 Firebase 包（包括 ED4MU），然后进行全新构建。如果您使用了Assets > Import Package > Custom Package，则可以使用Assets > External Dependency Manager > Version Handler > Uninstall Managed Packages正确删除所有添加的 Firebase 资产，以确保在通过 添加 之前没有遗留任何随机文件Package Manager。
如果这些有帮助的话请告诉我！
This worked for me, I also had the same error, I tried to delete all firebase packages and import the latest Firebase version 12.2.0 successfully resolved this error

Hi @Ls9257 . Thanks for your suggestion. Unfortunately, my condition still remains.
Btw, I just upgraded Firebase to 12.2.1. Nothing changed, there is still the same error.

I am experiencing the exact same issue. The error only occurred when I upgraded my project to use the latest Firebase SDK in order to support the new Target API Level.
Firebase Unity SDK Version
12.2.1
Unity editor version
2022.3.45f1
Installation Method
.unitypackage
Problematic Firebase Component(s)
Auth
Targeted Platform(s)
Editor
Unity editor platform
Ubuntu 20.04
Scripting Runtime
IL2CPP
Could the problem be a dependency issue. What is the required GLIBC version?
I ran a dependency check and got this:
~/git/FirebaseSample/Assets/Firebase/Plugins/x86_64$ ldd FirebaseCppApp-12_2_1.so
./FirebaseCppApp-12_2_1.so: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./FirebaseCppApp-12_2_1.so)
./FirebaseCppApp-12_2_1.so: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ./FirebaseCppApp-12_2_1.so)
./FirebaseCppApp-12_2_1.so: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./FirebaseCppApp-12_2_1.so)
	linux-vdso.so.1 (0x00007ffff5377000)
	libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fc7c0bd9000)
	libsecret-1.so.0 => /usr/lib/x86_64-linux-gnu/libsecret-1.so.0 (0x00007fc7c0b78000)
	libglib-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 (0x00007fc7c0a4e000)
	libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fc7c07e0000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fc7c0691000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fc7c066a000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fc7c0478000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fc7c4f57000)
	libgcrypt.so.20 => /usr/lib/x86_64-linux-gnu/libgcrypt.so.20 (0x00007fc7c035a000)
	libgio-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0 (0x00007fc7c0178000)
	libgobject-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 (0x00007fc7c0118000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fc7c00f5000)
	libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007fc7c0080000)
	libgpg-error.so.0 => /lib/x86_64-linux-gnu/libgpg-error.so.0 (0x00007fc7c005d000)
	libgmodule-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgmodule-2.0.so.0 (0x00007fc7c0057000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fc7c0051000)
	libmount.so.1 => /lib/x86_64-linux-gnu/libmount.so.1 (0x00007fc7bfff1000)
	libselinux.so.1 => /lib/x86_64-linux-gnu/libselinux.so.1 (0x00007fc7bffc6000)
	libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007fc7bffa8000)
	libffi.so.7 => /usr/lib/x86_64-linux-gnu/libffi.so.7 (0x00007fc7bff9c000)
	libblkid.so.1 => /lib/x86_64-linux-gnu/libblkid.so.1 (0x00007fc7bff45000)
	libpcre2-8.so.0 => /usr/lib/x86_64-linux-gnu/libpcre2-8.so.0 (0x00007fc7bfeb4000)

Hello, I'm also still having this issue.
My setup:
OS: windows 11
Target: Android (min 12, target: highest)
Unity version: 2022.3.47f1
Firebase parts included: Messaging, Analytics
Other plugins: vuforia
Testing on device:
Xiaomi Redmi 12 with Android 14
The error i'm getting is the following:
DllNotFoundException: Unable to load DLL 'FirebaseCppApp-12_2_1'. Tried the load the following dynamic libraries: Unable to load dynamic library 'FirebaseCppApp-12_2_1' because of 'Failed to open the requested dynamic library (0x06000000) dlerror() = dlopen failed: library "FirebaseCppApp-12_2_1" not found
The script I'm using to init Firebase is the following:
using UnityEngine;

using Firebase.Extensions;

public class FireBaseInit : MonoBehaviour{
	// Start is called before the first frame update
	void Start(){
		print("Starting firebase...");
		Firebase.FirebaseApp.CheckAndFixDependenciesAsync().ContinueWithOnMainThread(task =>{
			var dependencyStatus = task.Result;
			if (dependencyStatus == Firebase.DependencyStatus.Available){
				// Create and hold a reference to your FirebaseApp,
				// where app is a Firebase.FirebaseApp property of your application class.
				Firebase.FirebaseApp app = Firebase.FirebaseApp.DefaultInstance;

				// Set a flag here to indicate whether Firebase is ready to use by your app.
				print("Firebase initialized.");
			}else{
				UnityEngine.Debug.LogError(System.String.Format(
				"Could not resolve all Firebase dependencies: {0}", dependencyStatus));
				// Firebase Unity SDK is not safe to use here.
			}
		});
		Firebase.Messaging.FirebaseMessaging.TokenReceived += OnTokenReceived;
		Firebase.Messaging.FirebaseMessaging.MessageReceived += OnMessageReceived;
	}

	public void OnTokenReceived(object sender, Firebase.Messaging.TokenReceivedEventArgs token){
		UnityEngine.Debug.Log("Received Registration Token: " + token.Token);
	}

	public void OnMessageReceived(object sender, Firebase.Messaging.MessageReceivedEventArgs e){
		UnityEngine.Debug.Log("Received a new message from: " + e.Message.From);
	}
}

Which is basically the standard first thing you try, according to the documentation provided here: https://firebase.google.com/docs/unity/setup

I had the same problem with Mac OS. Solution: In Finder, open the FirebaseCppApp-12_2_0.bundle file in any text editor. A warning about an unknown developer will appear. Confirm, close the editor and the error will disappear in the UNITY editor.

Здравствуйте, у меня также все еще возникает эта проблема. Мои настройки: ОС: Windows 11 Цель: Android (минимум 12, цель: самая высокая) Версия Unity: 2022.3.47f1 Включены компоненты Firebase: обмен сообщениями, аналитика
Другие плагины: vuforia
Тестирование на устройстве: Xiaomi Redmi 12 с Android 14
Ошибка, которую я получаю, заключается в следующем: DllNotFoundException: Unable to load DLL 'FirebaseCppApp-12_2_1'. Tried the load the following dynamic libraries: Unable to load dynamic library 'FirebaseCppApp-12_2_1' because of 'Failed to open the requested dynamic library (0x06000000) dlerror() = dlopen failed: library "FirebaseCppApp-12_2_1" not found
Скрипт, который я использую для инициализации Firebase, следующий:
using UnityEngine;

using Firebase.Extensions;

public class FireBaseInit : MonoBehaviour{
	// Start is called before the first frame update
	void Start(){
		print("Starting firebase...");
		Firebase.FirebaseApp.CheckAndFixDependenciesAsync().ContinueWithOnMainThread(task =>{
			var dependencyStatus = task.Result;
			if (dependencyStatus == Firebase.DependencyStatus.Available){
				// Create and hold a reference to your FirebaseApp,
				// where app is a Firebase.FirebaseApp property of your application class.
				Firebase.FirebaseApp app = Firebase.FirebaseApp.DefaultInstance;

				// Set a flag here to indicate whether Firebase is ready to use by your app.
				print("Firebase initialized.");
			}else{
				UnityEngine.Debug.LogError(System.String.Format(
				"Could not resolve all Firebase dependencies: {0}", dependencyStatus));
				// Firebase Unity SDK is not safe to use here.
			}
		});
		Firebase.Messaging.FirebaseMessaging.TokenReceived += OnTokenReceived;
		Firebase.Messaging.FirebaseMessaging.MessageReceived += OnMessageReceived;
	}

	public void OnTokenReceived(object sender, Firebase.Messaging.TokenReceivedEventArgs token){
		UnityEngine.Debug.Log("Received Registration Token: " + token.Token);
	}

	public void OnMessageReceived(object sender, Firebase.Messaging.MessageReceivedEventArgs e){
		UnityEngine.Debug.Log("Received a new message from: " + e.Message.From);
	}
}

Это, по сути, стандартное первое, что вы пытаетесь сделать, согласно представленной здесь документации: https://firebase.google.com/docs/unity/setup
В редакторе у меня также возникает эта постоянная ошибка: Assembly 'Assets/ExternalDependencyManager/Editor/1.2.182/Google.IOSResolver.dll' will not be loaded due to errors: Unable to resolve reference 'UnityEditor.iOS.Extensions.Xcode'. Is the assembly missing or incompatible with the current platform? Reference validation can be disabled in the Plugin Inspector. Поскольку я на Windows, я, очевидно, не могу иметь отношения к XCode

I found that firebase must be placed in the Assets\Firebase directory. If this directory level is changed, the above problem will occur

This is when I changed the firebase directory to Assets\SDK\Firebase and found that there was no baseCppApp-12_3_0.so in the lib library

this is right ...,I don't know where the problem is ？


Abandoned packages

Running composer gives the user a warning about abandoned packages:
Package akaunting/money is abandoned, you should avoid using it. Use akaunting/laravel-money instead. Package semver/semver is abandoned, you should avoid using it. No replacement was suggested.
Maybe this packages should be replaced/removed for stability and lifecycle of the app.

I can look into using laravel-money but semver has no alternative.


[Enhancement] Added NumClassCheckHook and CI tests

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Extend and adapt NumClassCheckHook for working with mmcls library. The hook is very convenient for checking if your model classes number is equal to the dataset classes number and detect early mistakes in the training pipeline.
Modification
I added the NumClassCheckHook, adapting it to the mmcls environment. I also added an unit test for checking the correct working of the hook.
Checklist
Before PR:

[x] Pre-commit or other linting tools are used to fix the potential lint issues.
[x] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[x] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[x] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution, we will review it soon~

And please merge the latest master branch at first, because we made some changes about CI.


Route params doesn't handle '?' properly

I have
<Route name="article" path="/article/:articleId" handler={Article} />

Which I then use in one of two ways:
<Link to="article" params={{articleId: article.id}}>{article.title}</Link>

this.context.router.transitionTo('article', {articleId: article.id})

Now an article.id containing '?' in it completely breaks the routing. Only the URL changes, seemingly interpreting characters following '?' as query parameter name -- the route is activated with similarly wrong argument. If I add .replace('?', '%3F') in the manual call the route is activated with correct argument but the 'active' class isn't set in the link (and it does nothing to help with clicking the links)

failing test case on master would amazing :D (API has changed quite a bit but docs are up to date)

I think this might capture part of it, for URLUtils-test.js:
    describe('and some params contain special characters', function () {
      it('returns the correct path', function () {
        expect(formatPattern(pattern, { id: '?not=confused&with=query#string' })).toEqual('comments/%3Fnot=confused%26with=query%23string/edit');
      });
    });

Testing the reverse left as an exercise for the reader :-P


Operations that users can perform on a shared application is not clearly defined

Application owners are able to share their Applications with others users who belong to the same group[1]. This allows the Application owner to share their API subscription with other users in the same group. The user who is sharing the App should not be able to edit the Application owners App because they do not the own the App.
Currently the experience for the operations that a user can perform on a shared Application is not very good and undefined. Improvements are required to prevent shared users from updating shared Apps.
[1] https://docs.wso2.com/display/AM210/Sharing+Applications+and+Subscriptions

Needs to be fixed in 2.6.0 docs as well

Closing the issue as this is older than 3 years. Please reopen if the issue is valid still.


nucleotide-count: correct DNS typo to DNA

As errors go, that's pretty funny.
Thanks @Smarticles101 !


Fix/close flyout on click outside

To test

The event flyout should always close on click, except if:
a) The click occurs on a child of the flyout itself
b) The click occurs on another calendar event, or one of its children.

The above should be true for day, week and month modes.

Works pretty well 👌❤

:tada: This PR is included in version 1.5.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


does it work with GraphQL?

does it work with GraphQL?

Hello!
Sorry, this plugin aim only REST api.
We will check about GraphQL cache once it's api is finalized.
For now you can use GraphQL middleware: https://docs.strapi.io/developer-docs/latest/plugins/graphql.html#middlewares
// path: ./src/index.js

module.exports = {
  register({ strapi }) {
    const extensionService = strapi.plugin('graphql').service('extension');

    extensionService.use({
      resolversConfig: {
        'Query.categories': {
          middlewares: [
            /**
             * Basic middleware example #2
             * Enable server-side shared caching
             */
            async (next, parent, args, context, info) => {
              info.cacheControl.setCacheHint({ maxAge: 60, scope: "PUBLIC" });
              return next(parent, args, context, info);
            },
          ],
          auth: false,
        },
      }
    })
  }
}


Application only error responses are garbled

Using only a consumer secret/key, in order to use application auth only, I attempted to get the home timeline, which rightly should be denied.  However, printing the error results in:
2016/06/04 15:46:54 Get https://api.twitter.com/1.1/statuses/home_timeline.json?contributor_details=true&count=20&exclude_replies=true&include_entities=true returned status 403, x?
                    ?1
?0
  ????ұ?i?Bm ?8?n???X???????)?q?ǀM?????B?jM_ ?)!?&>9
                                                    .?ZfOi??????     9

Chances are, the body is compressed (Content-Encoding likely == 'gzip').  A possible solution may be (if this is the case): https://www.socketloop.com/tutorials/golang-read-gzipped-http-response
Also, ignoring the json decode here: https://github.com/ChimeraCoder/anaconda/blob/afffdbac178c0e78746ea42d7c1af963cb7ef28e/errors.go#L47 is likely not a good thing.  :)

Yup... grabbing the error and printing out the headers gives:
Content-Encoding":[]string{"deflate"}

Possible solution: https://play.golang.org/p/Ldasu_mpxl

@weingart Did you deploy the fix? I'm currently ignoring body if utf8.ValidString(apierr.Body) {...} but want to parse the response into a proper string.

Looks like this was fixed recently: https://github.com/ChimeraCoder/anaconda/pull/179

I also think this should be fixed now. Please let us know if you can still reproduce this issue with anaconda's master. Thanks for your report!


MenuItems show only at bottom splitActionBar

I am not able to add any MenuItem to upper actionBar at split mode ...

It's only one or the other. That's the nature of the beast, I'm afraid. More info here: http://developer.android.com/guide/topics/ui/actionbar.html#SplitBar


Boken on 1.20.1

Hey,
RC14 seems to be broken on 1.20.1:
Server-Version:
git-Purpur-2062 (MC: 1.20.1)*
java.util.concurrent.CompletionException: java.lang.NoSuchMethodError: 'java.util.Collection net.minecraft.network.protocol.game.PacketPlayOutScoreboardTeam.f()'
	at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]
	at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) ~[?:?]
	at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:649) ~[?:?]
	at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) ~[?:?]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1773) ~[?:?]
	at java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760) ~[?:?]
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?]
	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?]
	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?]
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?]
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?]
Caused by: java.lang.NoSuchMethodError: 'java.util.Collection net.minecraft.network.protocol.game.PacketPlayOutScoreboardTeam.f()'
	at net.megavex.scoreboardlibrary.implementation.packetAdapter.modern.team.AbstractTeamsPacketAdapterImpl$TeamDisplayPacketAdapterImpl.fillTeamPacket(AbstractTeamsPacketAdapterImpl.java:67) ~[PrimeCorePlugin-0.1.1-SNAPSHOT.jar:?]
	at net.megavex.scoreboardlibrary.implementation.packetAdapter.modern.team.PaperTeamsPacketAdapterImpl$TeamDisplayPacketAdapterImpl.updateTeamPackets(PaperTeamsPacketAdapterImpl.java:39) ~[PrimeCorePlugin-0.1.1-SNAPSHOT.jar:?]
	at net.megavex.scoreboardlibrary.implementation.team.TeamDisplayImpl.updateTeamPackets(TeamDisplayImpl.java:209) ~[PrimeCorePlugin-0.1.1-SNAPSHOT.jar:?]
	at net.megavex.scoreboardlibrary.implementation.team.TeamDisplayImpl.<init>(TeamDisplayImpl.java:37) ~[PrimeCorePlugin-0.1.1-SNAPSHOT.jar:?]
	at net.megavex.scoreboardlibrary.implementation.team.ScoreboardTeamImpl.<init>(ScoreboardTeamImpl.java:25) ~[PrimeCorePlugin-0.1.1-SNAPSHOT.jar:?]
	at net.megavex.scoreboardlibrary.implementation.team.TeamManagerImpl.createIfAbsent(TeamManagerImpl.java:77) ~[PrimeCorePlugin-0.1.1-SNAPSHOT.jar:?]
	at net.megavex.scoreboardlibrary.api.team.TeamManager.createIfAbsent(TeamManager.java:50) ~[PrimeCorePlugin-0.1.1-SNAPSHOT.jar:?]
	at de.primecodes.core.bukkit.listener.TabListListener.lambda$create$6(TabListListener.java:173) ~[PrimeCorePlugin-0.1.1-SNAPSHOT.jar:?]
	at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:646) ~[?:?]
	... 8 more

I'll take a look at it later today

I cannot reproduce this on Paper 1.20.1. Are you using a mojang mapped server jar? If not, could you write a minimal example that produces that exception?
@nicolube

As initaly stated, I'm using:
git-Purpur-2062 (MC: 1.20.1)*
Also RC-12 Works just fine. I haven't  tryed RC-13. But RC-14 does not work on Purpur

Ok, then I try to reproduce it tomorrow with a min plugin, we have it in a ratar large project.

Ahh, I think i found the issue, I still hat the API as RC10 included in a parent  module, my bad.

Ok, the issue still persits, here is a Demo Plugin:
https://github.com/nicolube/ScoreboardLibaryDemo
I tryed it on Linux Debian 11 / Linux Manjiro (OpenJDK 17).
Still throws the Stcktrace. See setup.sh for Server source.

Thanks for the demo, I was able to reproduce it. Should be fixed in the main branch, try setting the version to f5ff418eff. The main branch also has some significant internal changes so if you're having any other issues let me know, otherwise I'll make a new release

I put it into the main projects and put it on dev and ti looks normal.


Mark process-agent e2e tests with t.parallel() to speed up tests runs

What does this PR do?
Use t.Parallel for the windows and linux e2e test suites to allow them to run in parallel to speed up E2E test times.
Motivation
Following agent testing best practice.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Review the trivy output

Review the trivy output in Jenkins. Once the review is complete, set the scanAndReport function to "HIGH".

Fixed when I switched Trivy to only fail on issues with fixes. Trivy now reports no fixable issues at any severity level.


Apply NFKC normalization to unicode identifiers when storing bindings in the semantic model

Summary
Fixes #5003.
Python applies NFKC normalization to identifiers that use unicode characters. That means that F821 should not be emitted if ruff encounters the following snippet (but on main, it is), as from Python's perspective, these are all the same identifier:
𝒞 = 500
print(𝒞)
print(C + 𝒞)  # ruff says `C` isn't defined
print(C / 𝒞)
print(C == 𝑪 == 𝒞 == 𝓒 == 𝕮)  # ruff says `C`, `𝑪`, ... isn't defined

I fixed this false positive by changing the bindings field in ruff_python_semantic/scope.rs so that identifiers are always unicode-normalized according to NFKC before being stored in the hashmap. An alternative approach I played around with was to unicode-normalize identifiers in the AST itself. However, this would have had undesirable consequences: the formatter would have started eagerly normalizing unicode characters in identifiers when it reformatted a Python file.
Test Plan
cargo test

Ouch. I guess I need to start running benchmarks before filing PRs :)

Closing in favour of #10412


Expose GL_EXT_texture_compression_s3tc to virtual machine (virgl)

Now, UTM with VirGL seems like good solution for gaming on Mac (especially Portal/Portal2 with Steam for Linux).
But for now, linux version of Portal2 is not launching with messages about required OpenGL extensions are not supported.
phoenix@phoenix-vm:~$ .steam/steam/steamapps/common/Portal\ 2/portal2.sh
SDL video target is 'x11'
SDL video target is 'x11'

SDL failed to create GL compatibility profile (whichProfile=0!
SDL failed to create GL compatibility profile (whichProfile=0!

This system supports the OpenGL extension GL_EXT_framebuffer_object.
This system supports the OpenGL extension GL_EXT_framebuffer_blit.
This system DOES NOT support the OpenGL extension GL_EXT_framebuffer_multisample.
This system DOES NOT support the OpenGL extension GL_APPLE_fence.
This system DOES NOT support the OpenGL extension GL_NV_fence.
This system supports the OpenGL extension GL_ARB_sync.
This system supports the OpenGL extension GL_EXT_draw_buffers2.
This system DOES NOT support the OpenGL extension GL_EXT_bindable_uniform.
This system DOES NOT support the OpenGL extension GL_APPLE_flush_buffer_range.
This system supports the OpenGL extension GL_ARB_map_buffer_range.
This system supports the OpenGL extension GL_ARB_vertex_buffer_object.
This system supports the OpenGL extension GL_ARB_occlusion_query.
This system DOES NOT support the OpenGL extension GL_APPLE_texture_range.
This system DOES NOT support the OpenGL extension GL_APPLE_client_storage.
This system DOES NOT support the OpenGL extension GL_ARB_uniform_buffer.
This system supports the OpenGL extension GL_ARB_vertex_array_bgra.
This system supports the OpenGL extension GL_EXT_vertex_array_bgra.
This system supports the OpenGL extension GL_ARB_framebuffer_object.
This system DOES NOT support the OpenGL extension GL_GREMEDY_string_marker.
This system supports the OpenGL extension GL_ARB_debug_output.
This system supports the OpenGL extension GL_EXT_direct_state_access.
This system DOES NOT support the OpenGL extension GL_NV_bindless_texture.
This system DOES NOT support the OpenGL extension GL_AMD_pinned_memory.
This system DOES NOT support the OpenGL extension GL_EXT_framebuffer_multisample_blit_scaled.
This system supports the OpenGL extension GL_EXT_texture_sRGB_decode.
This system DOES NOT support the OpenGL extension GL_NVX_gpu_memory_info.
This system DOES NOT support the OpenGL extension GL_ATI_meminfo.
This system DOES NOT support the OpenGL extension GL_EXT_texture_compression_s3tc.
This system DOES NOT support the OpenGL extension GL_EXT_texture_compression_dxt1.
This system DOES NOT support the OpenGL extension GL_ANGLE_texture_compression_dxt3.
This system DOES NOT support the OpenGL extension GL_ANGLE_texture_compression_dxt5.
This system supports the OpenGL extension GLX_EXT_swap_control_tear.
This application requires either the GL_EXT_texture_compression_s3tc, or the GL_EXT_texture_compression_dxt1 + GL_ANGLE_texture_compression_dxt3 + GL_ANGLE_texture_compression_dxt5 OpenGL extensions. Please install S3TC texture support.
This application requires either the GL_EXT_texture_compression_s3tc, or the GL_EXT_texture_compression_dxt1 + GL_ANGLE_texture_compression_dxt3 + GL_ANGLE_texture_compression_dxt5 OpenGL extensions. Please install S3TC texture support.

For sure, glxinfo on host Mac reports that this extension is supported:
name of display: /private/tmp/com.apple.launchd.yWaOzqz1qJ/org.xquartz:0
display: /private/tmp/com.apple.launchd.yWaOzqz1qJ/org.xquartz:0  screen: 0
direct rendering: Yes
server glx vendor string: SGI
server glx version string: 1.4
server glx extensions:
    GLX_ARB_multisample, GLX_EXT_import_context, GLX_EXT_visual_info,
    GLX_EXT_visual_rating, GLX_OML_swap_method, GLX_SGIS_multisample,
    GLX_SGIX_fbconfig, GLX_SGIX_pbuffer, GLX_SGIX_visual_select_group,
    GLX_SGI_make_current_read
client glx vendor string: Mesa Project and SGI
client glx version string: 1.4
client glx extensions:
    GLX_ARB_context_flush_control, GLX_ARB_create_context,
    GLX_ARB_create_context_no_error, GLX_ARB_create_context_profile,
    GLX_ARB_create_context_robustness, GLX_ARB_fbconfig_float,
    GLX_ARB_framebuffer_sRGB, GLX_ARB_get_proc_address, GLX_ARB_multisample,
    GLX_EXT_buffer_age, GLX_EXT_create_context_es2_profile,
    GLX_EXT_create_context_es_profile, GLX_EXT_fbconfig_packed_float,
    GLX_EXT_framebuffer_sRGB, GLX_EXT_import_context, GLX_EXT_swap_control,
    GLX_EXT_swap_control_tear, GLX_EXT_texture_from_pixmap,
    GLX_EXT_visual_info, GLX_EXT_visual_rating, GLX_INTEL_swap_event,
    GLX_MESA_copy_sub_buffer, GLX_MESA_multithread_makecurrent,
    GLX_MESA_query_renderer, GLX_MESA_swap_control, GLX_OML_swap_method,
    GLX_OML_sync_control, GLX_SGIS_multisample, GLX_SGIX_fbconfig,
    GLX_SGIX_pbuffer, GLX_SGIX_visual_select_group, GLX_SGI_make_current_read,
    GLX_SGI_swap_control, GLX_SGI_video_sync
GLX version: 1.4
GLX extensions:
    GLX_ARB_get_proc_address, GLX_ARB_multisample, GLX_EXT_import_context,
    GLX_EXT_visual_info, GLX_EXT_visual_rating, GLX_OML_swap_method,
    GLX_SGIS_multisample, GLX_SGIX_fbconfig, GLX_SGIX_pbuffer,
    GLX_SGIX_visual_select_group, GLX_SGI_make_current_read
OpenGL vendor string: ATI Technologies Inc.
OpenGL renderer string: AMD Radeon Pro 5300M OpenGL Engine
OpenGL version string: 2.1 ATI-4.7.103
OpenGL shading language version string: 1.20
OpenGL extensions:
    GL_APPLE_aux_depth_stencil, GL_APPLE_client_storage,
    GL_APPLE_element_array, GL_APPLE_fence, GL_APPLE_float_pixels,
    GL_APPLE_flush_buffer_range, GL_APPLE_flush_render,
    GL_APPLE_object_purgeable, GL_APPLE_packed_pixels, GL_APPLE_pixel_buffer,
    GL_APPLE_rgb_422, GL_APPLE_row_bytes, GL_APPLE_specular_vector,
    GL_APPLE_texture_range, GL_APPLE_transform_hint,
    GL_APPLE_vertex_array_object, GL_APPLE_vertex_array_range,
    GL_APPLE_vertex_point_size, GL_APPLE_vertex_program_evaluators,
    GL_APPLE_ycbcr_422, GL_ARB_color_buffer_float, GL_ARB_depth_buffer_float,
    GL_ARB_depth_clamp, GL_ARB_depth_texture, GL_ARB_draw_buffers,
    GL_ARB_draw_elements_base_vertex, GL_ARB_draw_instanced,
    GL_ARB_fragment_program, GL_ARB_fragment_program_shadow,
    GL_ARB_fragment_shader, GL_ARB_framebuffer_object,
    GL_ARB_framebuffer_sRGB, GL_ARB_half_float_pixel,
    GL_ARB_half_float_vertex, GL_ARB_imaging, GL_ARB_instanced_arrays,
    GL_ARB_multisample, GL_ARB_multitexture, GL_ARB_occlusion_query,
    GL_ARB_pixel_buffer_object, GL_ARB_point_parameters, GL_ARB_point_sprite,
    GL_ARB_provoking_vertex, GL_ARB_seamless_cube_map, GL_ARB_shader_objects,
    GL_ARB_shader_texture_lod, GL_ARB_shading_language_100, GL_ARB_shadow,
    GL_ARB_shadow_ambient, GL_ARB_sync, GL_ARB_texture_border_clamp,
    GL_ARB_texture_compression, GL_ARB_texture_compression_rgtc,
    GL_ARB_texture_cube_map, GL_ARB_texture_env_add,
    GL_ARB_texture_env_combine, GL_ARB_texture_env_crossbar,
    GL_ARB_texture_env_dot3, GL_ARB_texture_float,
    GL_ARB_texture_mirrored_repeat, GL_ARB_texture_non_power_of_two,
    GL_ARB_texture_rectangle, GL_ARB_texture_rg, GL_ARB_transpose_matrix,
    GL_ARB_vertex_array_bgra, GL_ARB_vertex_blend,
    GL_ARB_vertex_buffer_object, GL_ARB_vertex_program, GL_ARB_vertex_shader,
    GL_ARB_window_pos, GL_ATI_blend_equation_separate,
    GL_ATI_blend_weighted_minmax, GL_ATI_separate_stencil,
    GL_ATI_texture_compression_3dc, GL_ATI_texture_env_combine3,
    GL_ATI_texture_float, GL_ATI_texture_mirror_once, GL_EXT_abgr,
    GL_EXT_bgra, GL_EXT_bindable_uniform, GL_EXT_blend_color,
    GL_EXT_blend_equation_separate, GL_EXT_blend_func_separate,
    GL_EXT_blend_minmax, GL_EXT_blend_subtract, GL_EXT_clip_volume_hint,
    GL_EXT_debug_label, GL_EXT_debug_marker, GL_EXT_depth_bounds_test,
    GL_EXT_draw_buffers2, GL_EXT_draw_range_elements, GL_EXT_fog_coord,
    GL_EXT_framebuffer_blit, GL_EXT_framebuffer_multisample,
    GL_EXT_framebuffer_object, GL_EXT_framebuffer_sRGB,
    GL_EXT_geometry_shader4, GL_EXT_gpu_program_parameters,
    GL_EXT_gpu_shader4, GL_EXT_multi_draw_arrays, GL_EXT_packed_depth_stencil,
    GL_EXT_packed_float, GL_EXT_provoking_vertex, GL_EXT_rescale_normal,
    GL_EXT_secondary_color, GL_EXT_separate_specular_color,
    GL_EXT_shadow_funcs, GL_EXT_stencil_two_side, GL_EXT_stencil_wrap,
    GL_EXT_texture_array, GL_EXT_texture_compression_dxt1,
    GL_EXT_texture_compression_s3tc, GL_EXT_texture_env_add,
    GL_EXT_texture_filter_anisotropic, GL_EXT_texture_integer,
    GL_EXT_texture_lod_bias, GL_EXT_texture_mirror_clamp,
    GL_EXT_texture_rectangle, GL_EXT_texture_sRGB, GL_EXT_texture_sRGB_decode,
    GL_EXT_texture_shared_exponent, GL_EXT_timer_query,
    GL_EXT_transform_feedback, GL_EXT_vertex_array_bgra,
    GL_IBM_rasterpos_clip, GL_NV_blend_square, GL_NV_conditional_render,
    GL_NV_depth_clamp, GL_NV_fog_distance, GL_NV_light_max_exponent,
    GL_NV_texgen_reflection, GL_NV_texture_barrier, GL_SGIS_generate_mipmap,
    GL_SGIS_texture_edge_clamp, GL_SGIS_texture_lod, GL_SGI_color_matrix

144 GLX Visuals
...

Yeah, looks like GL_EXT_texture_compression_s3tc support is present only when using software driver (swrast)
Forcefully adding MESA_EXTENSION_OVERRIDE=GL_EXT_texture_compression_s3tc env variable allows Source engine games to start but results in black screen.
If someone knows a workaround of any sort to make s3tc work with virtio_gpu, please let me know as well.

@formalsd yeah, MESA_EXTENSION_OVERRIDE allows game to start, but results in all graphics in greens, and segfault after splash screen.
https://user-images.githubusercontent.com/1833493/155366491-6b8a1c5a-5454-48bd-9974-01d80abb74a7.mp4

s3tc is now supported, this can be closed


pin conda-libmamba-solver's req on libmambapy to 0.22.*

Checklist

[X] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

The upcoming libmamba 0.23 will introduce API breaking changes. Patching requirement here to ensure users of the new solver don't update too early.
cc @wolfv @jezdez

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Diff (from CI):
$ python show_diff.py
Downloading: https://conda.anaconda.org/conda-forge/noarch/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/noarch/repodata.json.bz2
noarch::conda-libmamba-solver-22.3.0-pyhd8ed1ab_0.tar.bz2
-    "libmambapy >=0.22",
+    "libmambapy 0.22.*",
noarch::conda-libmamba-solver-22.3.1-pyhd8ed1ab_0.tar.bz2
-    "libmambapy >=0.22",
+    "libmambapy 0.22.*",
Downloading: https://conda.anaconda.org/conda-forge/linux-64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-64/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-armv7l/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-armv7l/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-aarch64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-aarch64/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-ppc64le/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/linux-ppc64le/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/osx-64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/osx-64/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/osx-arm64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/osx-arm64/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-32/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-32/repodata.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-64/repodata_from_packages.json.bz2
Downloading: https://conda.anaconda.org/conda-forge/win-64/repodata.json.bz2

Thanks Isuru!


Custom sink example?

I am considering to use glog instead a lot of custom code, but I cannot se from the docs how to achieve the following:

user shall select to either log to console or file (not both)
file should have encoded each line as a JSON, to be then be piped to a logging service.

I see from the code that glog support custom sinks, but I cannot find an example.

The code and the documentation is all what we have now.

OK, thanks.
Is there a way to pipe logs only to console or only to file?

I also need this feature. This feature has been requested in #470 .
@sergiud


Does tmux-tilish work on MacOS on M1 processors?

I have the same config on both an Intel Mac and an M1 Mac, and tmux-tilish works on the former but not the latter.
Is it tested on M1?
BTW, I'm also using tmux-continuum and it appears to work.
I installed tmux with brew.

Yes, it works on my M1 Mac.
My problem was caused by the way iTerm2 handles the Option (Alt) key, and I fixed it using the answer to the question
"Q: How do I make the option/alt key act like Meta or send escape codes?" here:
https://iterm2.com/faq.html


feat(motion-control): handle motor driver errors

Overview
This creates an interrupt that will trigger when the subsystem motor driver enters error state (due to over-temperature, short circuit, or open circuit detection). This interrupt will safely stop the subsystem motion controller and enter it into error state. It will also spawn a SPI message to retrieve the specific error, which will surface as a CAN message to the system.
Test Plan

[x] Verify pin setup correctly to output low when error state entered

Heat driver IC to >150*C (default over-temperature threshold) via heat gun

[x] Verify interrupt triggered when pin outputs low
[x] Verify subsystem motion controller enters error state when interrupt triggers
[x] Verify SPI communication to driver to gather specific error occurs when interrupt triggers
[x] Verify CAN message reports this specific error
[ ] Verify all of this during an actual move

Changelog
Review requests
Risk assessment

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (083a816) 83.71% compared to head (7a8dbfe) 83.47%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   83.71%   83.47%   -0.24%
==========================================
  Files         101      103       +2
  Lines        4028     4067      +39
==========================================
+ Hits         3372     3395      +23
- Misses        656      672      +16

see 11 files with indirect coverage changes


Upstreaming A3700

What are the plans to get the A3700 support into upstream? https://github.com/ARM-software/arm-trusted-firmware/blob/master/docs/marvell/build.txt talks about that platform already, but the bits aren't there yet. Please clarify.
Alternatively, I can open a ticket on upstream to remove those bits from the docs so that users like me don't get confused when trying to build non-existing code.

I was planning to push A3700 support this August, but my work gets delayed since we want to migrate the SERDES initialization to lower EL levels, while TF-A executes it through SMCC calls.  The same mechanism already implemented in A8K family. So I believe the final A3700 pull request will be created in September-October this year.

@kostapr Thanks, good that there is progress in sight!
I was recently discussing with Debian how to improve the user experience of ESPRESSObin by packaging a recent upstream bootloader (https://lists.debian.org/debian-arm/2018/08/msg00001.html) where ATF would be a building block. I have some further issues around u-boot, though. Will put you on CC when reporting.


Text to speech support ?

Hello guys,
i love this sdk..., its pretty awesome for getting started with  ePub reading!
i tryed it with TalkBack for blind users, working 100%!!!
the sample app allready provide the right base to build a ebook app
can you please add tts support for reading the Current chapter, or select * speak?
thanks!

thank you.
tts support would be a cool feature.
but im not sure how this could be implemented without restricting the api to only one specific use case.
We try to keep this as clean and extendable as possible.
I will think about it.

it would be good if the epub is only parced into text or display in a native window..., but at you know, its not realy important :P


Minor specification language change proposals on cmobase-0.5

Several minor language change proposals against the CMO draft specification 0.5.
These minor changes are mostly intended to avoid inadvertently constraining implementations, and to clarify the intent of the CMO group based on the discussions that have taken place in the group.

I've updated the bus initiator text in my working branch

Ignore this comment

I opened a pull request #37 that I hope addresses this PR. Please take a look and make any comments there.


Encode Trait

This allows us to call .encode(&mut Vec) on various types to generate the packets

We can merge this one after #5 or we can just merge this one and close #5

Changes Unknown when pulling cda3bbe8448e59afeb20c3d302d595a13ee91d51 on ChrisMacNaughton:encode-trait into ** on tomasvdw:master**.


IMultiTenantContextAccessor returns null when not using UseMiddleware

We have an issue when trying to use the Finbuckle.Multitenant library when using it in cases when we use Messaging (and no HttpRequests), meaning that we are not utilising the UseMiddleware, therefore the  IMultiTenantContextAccessor is not populated.
Can you please suggest a way how we can use this library in such scenarios?

Hi, my apologies for the slow reply. In this I recommend that you essentially mimic what the middleware is doing:
var accessor = context.RequestServices.GetRequiredService<IMultiTenantContextAccessor>();

if (accessor.MultiTenantContext == null)
{
    var resolver = context.RequestServices.GetRequiredService<ITenantResolver>();
    var multiTenantContext = await resolver.ResolveAsync(context);
    accessor.MultiTenantContext = multiTenantContext;
}

if (next != null)
{
    await next(context);
}

The key here is that it is getting an instance of ITenantResolver and simply calling ResolveAsync on it.
You can new up a TenantResolver yourself without DI but it's a little more trouble to plug in the needed ctor parameters:
public TenantResolver(IEnumerable<IMultiTenantStrategy> strategies, IEnumerable<IMultiTenantStore<T>> stores, IOptionsMonitor<MultiTenantOptions> options, ILoggerFactory loggerFactory)

If you have only a single strategy and store you can simplify things significantly:
// assumes you have a strategy and store instance
var identifier = await strategy.GetIdentifierAsync(context);
var tenantInfo = await store.TryGetByIdentifierAsync(identifier);
``

Hello @AndrewTriesToCode
As a continuation for this post, is it possible to just make _asyncLocalContext property of MultiTenantContextAccessor not internal ?
Because in cases, when used outside Asp.Net, it's impossible to populate this context from some custom code.
One always needs to create and register in DI own implementation of IMultiTenantContextAccessor.
If this proposal is considered contradicting to the library design, it would be great to extend the library somehow in other way to make usage outside of Asp.Net easier.

Hi I can give a more detailed answer later today but I'm assuming you are using the .Net Generic Host to handle DI and app lifetime. Is that correct?

Hi I can give a more detailed answer later today but I'm assuming you are using the .Net Generic Host to handle DI and app lifetime. Is that correct?

Hello @AndrewTriesToCode
Yes it is correct.
I've implemented own IMultiTenantContextAccessor to be able to populate multitenant context outside of HTTP flow and library works fine.
My request is just for simplifying the library experience for use cases like mine, non related to web apps.

Bot go away

Hello @AndrewTriesToCode
Can you please reopen this issue since it is still relevant and not addressed.

@AndrewTriesToCode This issue is not solved.

Yeah and I'll pin it to prevent closure. Sorry!

Thanx @AndrewTriesToCode
But what about resolution of this ? i.e. the only change is

is it possible to just make _asyncLocalContext property of MultiTenantContextAccessor not internal ?

Any reason it needs to be exposed? The MultiTenantContext property is public and lets you get/set the value of the AsyncLocal<IMultiTenantContext<T>?> just fine. The reason I like to keep it behind the property is because in the future I might switch our or augment the use of the AsyncLocal for technical reasons.
For example in the ASP.NET pipeline any middleware prior to the multi tenant middleware can't access the multi tenant context on the "unwinding" of the pipeline after main processing so in that case I'm considering making the logic a little smarter and intend for users to just use the property to get/set.


Matching up indexes when some values missing

Great library.
How do you go about matching up the indexes when some are missing?
See attatched - its for the 'lap' element from a swim.
Some of the 'total_distance' elements are 0 (resting period) but this means the indexes are missing from 'swim_stroke' making it pretty hard to match up the corresponding distance and stroke. Is this is a bug or is that the way the data comes through? I looked at the 'fix data' option but it only works for certain elements.

Hi, apologies for the delay getting back to you. Things have been quite hectic in the run-up to the holidays.

Some of the 'total_distance' elements are 0 (resting period) but this means the indexes are missing from 'swim_stroke' making it pretty hard to match up the corresponding distance and stroke. Is this is a bug or is that the way the data comes through? I looked at the 'fix data' option but it only works for certain elements.

It's the way the data comes through. Looking at the profile spreadsheet that comes as part of the download from the ANT developer area swim_stroke is an enumerated type where:
0 = freestyle
1 = backstroke
2 = breaststroke
3 = butterfly
4 = drill
5 = mixed
6 = im
So there is no swim stroke that would correspond with a resting period.
length_type may be of some help. It is also an enumerated type:
0 = idle
1 = active
I must admit, I have used the class much for analysis of swim files. Perhaps you can share a link to a swim FIT file? I'd be interested in taking a look at it in more detail when I get the chance.
What device(s) do you use to record swims?
Cheers, Adrian.

If I understand correctly, the problem of @robthompsonweb is not that swim_stroke = 0 for some points, but that most arrays have seven elements but some have only four elements. It's probably okay if the missing ones are not set, simply because there's no data for them, but the indices are not consistent, as swim_stroke[3] probably relates to total_distance[5].
For test files, there are at least five swim files in https://github.com/Runalyze/Runalyze/tree/master/tests/testfiles/fit, one from an outdoor swimming, two standard files for a 25m and 50m pool respectively and two files with additional data stored in developer fields.

Sorry for late reply - @laufhannes yes that is exactly the issue.
It seems in order to match up the indexes you need to look at first_length_index  or num_active_lengths and jump if its 0.
Example FIT file for the swim above attatched - guess it would be nice if you set these indexes to null or something.
example.txt


Migrating Guide: Code Splitting inaccuracy?

Hi, I was reading over the migrating documentation, and under the section for code-splitting it says:
function onClick() {
  import("./module").then(module => {
    module.default;
  }).catch(err => {
    console.log("Chunk loading failed");
  });
}

https://github.com/webpack/webpack.js.org/blob/develop/content/guides/migrating.md#code-splitting-with-es2015
Shouldn't the function inside the .then() return module.default?
  import("./module").then(module => {
-   module.default;
+   return module.default;
  }).

That is correct!!! Would love a PR for this!!!!

okay, super simple so I'm on it.

Merged.


Trusting all Servers and bypassing Basic Authentication

I am using Windows + Python + Selenium (latest) + Browsermob-proxy-py + Chrome, FF, IE.
I know this is no place for python, but I believe you could still help me. After following the installation instructions and the example provided by the documentation of browsermob-proxy-py, my code looks like this:
@pytest.fixture(scope="session", autouse=True)
def selenium_proxy():
    proxy = Client("localhost:9090")
    proxy.trustAllServers(True)
    proxy.basic_authentication("", HTACCESS_USERNAME, HTACCESS_PASSWORD)

    yield proxy.selenium_proxy()

    proxy.close()

Because the method trustAllServers is not available:
# I defined this method in browsermob-proxy-py/client.py
def trustAllServers(self, value):
    r = requests.post(url='%s/proxy' % (self.host),
                      data=json.dumps({'trustAllServers': value}),
                      headers={'content-type': 'application/json'})
    return r.status_code

I am running the browsermob proxy standalone version like this:
java -jar browsermob-dist-2.1.4.jar --port 9090
I did this by following the official browsermob-proxy documentation, which can be found here
Printing the response code for both methods: trustAllServers (Returns 200) and basic_authentication (Returns 404) <- Why?
The main issue is: when I try to load an URL with selenium the browser will say that the page cannot be loaded. If I run my tests with internet explorer, some weird unwanted windows configurations will take place and I will have to manually deactivate the LAN Proxy configuration in the Internet Options in order to recover my internet connection.
The console logs informs two main Problems:
...
Caused by: javax.net.ssl.SSLHandshakeException: General SSLEngine problem
...

and
...
Caused by: java.security.cert.CertificateException: No subject alternative DNS name matching <host> found.
...

I've been reading for hours and the solution I always end up finding is trusting all servers, which "I am already doing" with the trustAllServers method I defined. Maybe I am doing something wrong?
I already opened this issue at browsermob-proxy-py, you can find it here
Edit: I am trying to do something like this:
https://www.softensity.com/browsermob-proxy-qa/

Installing this Certificate to Trusted Root Certification Authorities on Windows solved most of my issues.
Now the remaining issue is handling the alert dialog window of any domain with the basic_authentication method. Giving "*" as domain-parameter returns 200 response status code. However, the alert window appears anyway.

I wasn't able to match all domains with a generic expression (empty string or *). But you can match all subdomains by just giving "domain.com". This solves my issue for now.


Clocker trying to stop already stopped docker daemon

I have 2 machines (using byon, trusty, docker 1.2) - when i create clocker cloud from scratch (both machines running docker daemon) everything works. Removing clocker cloud stops docker daemons.
Attempt to create clocker cloud again fails on stopping already stopped docker daemons.
From logs i suspect dockerhost status check returns 0 (docker stop/waiting in output) - it triggers dockerhost stop script execution failing with 1 exit status code.

I think this should have been fixed in #90.

@sjcorbett Agree


PageStorage gc for external pages my block creating tables

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
In PageStorageImpl::gcImpl clean_external_page, we hold the callbacks_mutex until all external page gc done.
https://github.com/pingcap/tiflash/blob/7acf7f59f300d448d99b79619634b2751c01ff2c/dbms/src/Storages/Page/V3/PageStorageImpl.cpp#L287-L298
while the time cost in clean_external_page is not ignorable and may block new StorageDeltaMerge from being created
https://github.com/pingcap/tiflash/blob/7acf7f59f300d448d99b79619634b2751c01ff2c/dbms/src/Storages/Page/V3/PageStorageImpl.cpp#L400-L408
https://github.com/pingcap/tiflash/blob/7acf7f59f300d448d99b79619634b2751c01ff2c/dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp#L342-L343

2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiFlash version?


Options for bivarmap_map

To discuss:

Maybe plotting the inset with the colormatrix might be optional (add a parameter for that)?

Another idea is to set the same plot using tmap, which might allow plotting larger maps (or maps with finer resolution). According to @mauriciovancine , it works.
It could be either a parameter in the bivarmap_map function, or another function bivarmap_tmap.


Can I have a ASP.net MVC (.Net framework) client  sample targeting IDServer4 please

I am not able find a any sample ASP.net MVC (.Net framework) client targeting Identity server4. Could you please help me out here?

https://github.com/IdentityServer/IdentityServer3.Samples/tree/master/source/Clients


git/script/makeReleaseNotes should be able to include conventional commit footers

See: 87f825781414f956b3d2cd5d4f0c2df60a6a939a
This would allow TODO items to appear in release notes previews in PRs, as well as common footers like BREAKING CHANGE and refs.
Might want this to be on by default, possibly even on and non-configurable. Arguably a bug that these are presently omitted.

Discussed and we're going to make this behavior default and, for now, non-configurable.