Files which do not finish executing are not re-executed

If trigger watches a file which contains some sort of loop or long-running task, and the watched file changes, trigger does not re-execute. It would be nice to have an option where trigger would abort all previous executions of a script, even if they are still running, when it detects changes to one or more of the watched files.
Here's a repro:

Create index.js:

setInterval(function(){
  console.log('The time is: '+(new Date()).getTime())
}, 1000);

Start watching index.js with a trigger:

$ tg node index.js
The time is:<PHONE_NUMBER>074
The time is:<PHONE_NUMBER>075
...
...
...

Execute a touch on index.js

$ touch index.js

Note that trigger does not re-launch node index.js

Thank you for the report. The current behavior is indeed intentional, but I agree that it would be nice to have an option (--force? --interrupt?) with the described behavior.
The child process would probably have to be run in the background and inotifywait would then trigger the termination & re-execution of the child process.

The trouble with adding options to the existing command is that the trigger script consumes 1...n parameters as file names to monitor. If you wanted trigger to monitor a silly file named --interrupt, for example, there would be a conflict in file/option processing.

If you added an option for --interrupt, and you also wanted trigger to monitor a silly file named --interrupt, there would be a conflict in file/option processing.

I think this kind of problem is usually solved by passing -- to separate options from arguments, like so:
trigger nodejs --interrupt -- index.js --silly-file

On the other hand...

I guess it would work to require parameters to come immediately after trigger:
Good:
trigger --interrupt nodejs index.js

... I think this would be a very good solution for trigger :+1:

Resolved in the newest version


Fix Image topic property not populating

I might have misunderstood something here, but seems to me like we can use the same method of extracting the MessageType that is being used in MessageFilterDisplay.

@audrow hoping you're the right person to ping here. Not even sure a PR is the right venue for a tiny one-line change like this. I'd love to not have to always type the image topic though, and the change is already used elsewhere in rviz. Any thoughts?

This looks like a good change to me - thanks, @paulerikf. I'll try it locally in the next day or so.

@ahcorde mentions that the macOS warning is unrelated in another issue: https://github.com/ros2/rviz/pull/722#issuecomment-871447535
Does that essentially mean this is good to go?

Thanks for the PR @paulerikf!


[ BLAS ] use openblas function to set num threads

This patch use openblas_set_num_thread() to set the number of thread
for BLAS computation, instread of set environment variables
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1880. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.


Fixed query checker for SQLDatabaseChain

Fixed query checker for SQLDatabaseChain
When SQLDatabaseChain's llm attribute was deprecated, the query checker stopped working if SQLDatabaseChain is initialised via from_llm method. With this fix, SQLDatabaseChain's query checker would use the same llm as used in the llm_chain
Who can review?
@hwchase17 - project lead

great catch


How to disable close modal-sheet

Hello friends
how to make my modal-sheet always be displayed on screen as 100px drag max 500px and can't close modal-sheet when height is 100px

Same problem here. If you do the following, you still can close the sheet if you drag fast. isOpen={true} onClose={()=>{}}

Try this workaround https://github.com/Temzasse/react-modal-sheet/issues/6#issuecomment-967702561

Duplicate of #6


Add version tags

Would it be possible to add version tags & maybe publish in the official package set so it is easier to use with spago?

Wanted to rename the package, as per #1 . And did that. I'm publishing the dependencies first of this project then I'll publish this onto spago.

Now published on package set :)


build.cmd/sh changes

Notes for @aspnet contributors

build.cmd no longer runs tests. Run build.cmd -test
Build scripts in subfolders work again. Example: running the build.sh script will build and test only those projects found in the matching subdirectory.

$ src/Servers/Kestrel/build.sh -test

I didn't add a build.cmd script in every subfolder, but feel free to add new ones. Use src/DataProtection/build.{cmd,sh} as examples.

Changes:

Add flags like -test and -pack to control running just test or packaging
Add flags like -managed, -native, and -nodejs to control building sub-types of projects
Remove KoreBuild bootstrapper flags
Added build scripts specifically for CI which runs all builds in of all types on all targets.

These scripts will change a little more when we adopt Arcade SDK, but not much.
Resolves https://github.com/aspnet/AspNetCore/issues/4247

PR build failures uncovered a product issue: https://github.com/aspnet/Extensions/issues/815 I'm going to revert some of these changes temporarily until we can resolved.

Is build /t:resx still a thing? If not how do we update resource files?

resx should be included in the buildfromsource.md.

/AzurePipelines run all

🔔 I'm going to merge this soon. Please take a look if you want to provide additional feedback.

🚢 🇮🇹


insertOne() May Modify Data Class Attribute Name

If data class' attribute contain one lower case alphabet at the beginning
data class Test(
    val pValue: String = "",
)

insertOne() will write its data to a different name, with
val col = database.getCollection<Test>("test")
col.insertOne(Test())
println(database.getCollection("test").find().toList())

will get [Document{{pvalue=}}] instead of [Document{{pValue=}}]

This is not really related to kmongo. KMongo uses by default the jackson mapping engine, that uses itself the jaba bean naming conventions. See https://stackoverflow.com/questions/30205006/why-does-jackson-2-not-recognize-the-first-capital-letter-if-the-leading-camel-c for more details


Device on/off state

Preconditions

[X] The support request template is not a better fit to my question

Issue
When I turn my Apple TV off, the plugin Shows AppleTV as active still.
Is the expectation that we would toggle the AppleTV bridge on/off to get automation or is it suppose to sync up with the state of the actual Apple TV? ie if I use AppleTV remote to turn on / off the device that the plugin state would update.

Have you read the following form the README?

If using audio output devices other than the Apple TV itself, the Apple TV is always reported as powered on. This is a known issue of the dependency pyatv, see https://github.com/postlund/pyatv/issues/1667. As a result, the Apple TV device will only be shown as off in HomeKit when powered off via the Apple TV device in HomeKit. After restarting the plugin the device will always be shown as on.

Ah shoot, I did read that part but didn't think much of it until you mentioned it just now. 🤦🏻♂

Ah shoot, I did read that part but didn't think much of it until you mentioned it just now. 🤦🏻♂

Yeah, that a pretty silly limitation ... however, nothing that I can fix.
I guess it's a good excuse for a good sound system 😂

hah, I wish. Theater audio set up is a pain. I suppose I could create scenes to turn the plug in on / off which then can trigger my other automations. Will give that a try.


"Dewestize" runners and improve output

The first half of this pull request removes the runner package's dependency on west. This makes it possible to use some of these utility classes from other scripts in the code base without requiring anything not in requirements.txt.
The second half takes advantage of some of the outut-related changes in the first half to make the build/flash/debug output a little nicer and match the built-in command output more closely.

The first half of this pull request removes the runner package's dependency on west. This makes it possible to use some of these utility classes from other scripts in the code base without requiring anything not in requirements.txt.

Can you elaborate as to why this is desired/needed?

The first half of this pull request removes the runner package's dependency on west. This makes it possible to use some of these utility classes from other scripts in the code base without requiring anything not in requirements.txt.

Can you elaborate as to why this is desired/needed?

This was actually a downstream feature request, so that utility classes like BuildConfiguration could be defined once and used elsewhere.

@carlescufi I think the confusion may be definitional. By "runners", I mean the package by the same name which is in scripts/west_commands/runners. The run_common.py file is just common code shared by several west extension commands (build, flash, etc.) that rely on the runners package.


Do not set variant nor background unless explicitly requested

In response to setting background option (n)vim reloads colors.
With init.lua handling of background matching, switching to light background enforces dawn variant, ignoring further background changes.
A straightforward fix would be to remove the code that sets variant and background without user input and update palette.lua to factor in vim.o.background value when deciding on palette.
As an improvement, I'd like to propose two modes of operation:

respect background (default) - if variant doesn't match background, use default variant for background
respect variant - if variant doesn't match background, set matching background

Forgive me if I'm misunderstanding, but I believe things currently behave as such:

If user sets any variant, that variant would disable any automatic switching
If user does not set a variant, match background

Please clarify your expected behaviour. It kind of sounds like you are wanting to the variant to switch if you manually set vim.o.background?
Appreciate you 😌

Right now, if user doesn't set variant:

if background is dark, variant is not set and palette.lua defaults to main palette
if background is light, variant is set to dawn, which ignores any future changes to background option

In combination with (n)vim behaviour of reloading colors on background change this results in a confusing behaviour.
Specifically, if I start with dark background and switch to light, colors switch to dawn palette as expected. But then when I switch to light background, dawn palette persists even though I didn't set it explicitly.
My basic expectation is for theme to follow background color, unless I set it explicitly.

I would greatly appreciate (and am going to take a shot at implementing) if this scheme would go beyond basic expectation by offering a, what I believe could be a default, mode of operation where it only uses a variant if it matches currently chosen background.
Specifically:

main and dawn are implicit
moon is used in place of main if and only if background is dark and variant is explicitly set to moon
Toggle function toggles by setting: background=light; vim.g.rose_pine_variant=nil, background=dark; vim.g.rose_pine_variant=nil, and background=dark; vim.g.rose_pine_variant='moon'

Thanks for explaining, I would gladly look at PR for this functionality – that does sound like a reasonable default

This should be working on the canary branch. There are other changes on the canary branch such as moving all config to lua (currently undocumented)

My apologies for long silence, had a few busy weeks.
Just checked and it works like a charm:

Switching background reloads theme to a light or the configured dark variant
Calling setup function doesn't reload colors, yet on the next load selects the new variant if background color matches

This is the first lua theme I saw do this, which makes for an easy way to set up theme for future selection without employing vim global variables

👍


[tesseract] update to 5.0.0

Library name: tesseract
New version number: 5.0.0-alpha-20201231
https://github.com/tesseract-ocr/tesseract/releases/tag/5.0.0-alpha-20201231
https://abi-laboratory.pro/?view=timeline&l=tesseract
5.0.0-alpha is only 36% backward compatible.
So vcpkg should have options to build the old 4.1.1 as well as new 5.0.0-alpha (with HEAD_REF master).
Opening a new issue as suggested by @NancyLi1013 in https://github.com/microsoft/vcpkg/issues/10624#event-4283543880

@Shreeshrii ,The latest stable version of tesseract is 4.1.1. 5.0.0 is a pre-release and very unstable. After the upgrade, it may affect the ports that depend on it, so we will not upgrade for the time being. I will upgrade after the latest stable version is released. ,Thanks.

@JonLiu1993 Can you advise what changes I need to make, if I want to create a local port for tesseract5  with  the latest HEAD_REF from master branch?

@Shreeshrii ,Modify it like this and install it locally：
CONTROL:
Source: tesseract
Version: 5.0.0
Homepage: https://github.com/tesseract-ocr/tesseract
Description: An OCR Engine that was developed at HP Labs between 1985 and 1995... and now at Google.
Build-Depends: leptonica, libarchive

Feature: training-tools
Description: build training tools
Build-Depends: icu, pango, cairo, fontconfig

Feature: cpu-independed
Description: build on any cpu extension commands support

portfile.cmake
vcpkg_from_github(
    OUT_SOURCE_PATH SOURCE_PATH
    REPO tesseract-ocr/tesseract
    REF ca114ace387f86821ce061713dc9aa3cc33a3cad #pre-V 5.0.0
    SHA512 017723a2268be789fe98978eed02fd294968cc8050dde376dee026f56f2b99df42db935049ae5e72c4519a920e263b40af1a6a40d9942e66608145b3131a71a2
    HEAD_REF master
    PATCHES
        fix-tiff-linkage.patch
        fix-text2image.patch
        fix-training-tools.patch
)

# The built-in cmake FindICU is better
file(REMOVE ${SOURCE_PATH}/cmake/FindICU.cmake)

string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "static" BUILD_STATIC)

vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
    training-tools  BUILD_TRAINING_TOOLS
)

if("cpu-independed" IN_LIST FEATURES)
    set(TARGET_ARCHITECTURE none)
else()
    set(TARGET_ARCHITECTURE auto)
endif()

vcpkg_configure_cmake(
    SOURCE_PATH ${SOURCE_PATH}
    PREFER_NINJA
    OPTIONS ${FEATURE_OPTIONS}
        -DSTATIC=${BUILD_STATIC}
        -DUSE_SYSTEM_ICU=True
        -DCMAKE_DISABLE_FIND_PACKAGE_LibArchive=ON
        -DCMAKE_DISABLE_FIND_PACKAGE_OpenCL=ON
        -DLeptonica_DIR=YES
        -DTARGET_ARCHITECTURE=${TARGET_ARCHITECTURE}
)

vcpkg_install_cmake()

vcpkg_fixup_cmake_targets(CONFIG_PATH cmake)
file(READ ${CURRENT_PACKAGES_DIR}/share/tesseract/TesseractConfig.cmake TESSERACT_CONFIG)
string(REPLACE "find_package(Leptonica REQUIRED)"
               "find_package(Leptonica REQUIRED)
find_package(OpenSSL REQUIRED)
find_package(ZLIB REQUIRED)
find_package(BZip2 REQUIRED)
find_package(LibXml2 REQUIRED)
find_package(zstd REQUIRED)
find_package(LibLZMA REQUIRED)" TESSERACT_CONFIG "${TESSERACT_CONFIG}")
file(WRITE ${CURRENT_PACKAGES_DIR}/share/tesseract/TesseractConfig.cmake "${TESSERACT_CONFIG}")

vcpkg_copy_tools(TOOL_NAMES tesseract AUTO_CLEAN)

if("training-tools" IN_LIST FEATURES)
    list(APPEND TRAINING_TOOLS
        ambiguous_words classifier_tester combine_tessdata
        cntraining dawg2wordlist mftraining shapeclustering
        wordlist2dawg combine_lang_model lstmeval lstmtraining
        set_unicharset_properties unicharset_extractor text2image
    )
    vcpkg_copy_tools(TOOL_NAMES ${TRAINING_TOOLS} AUTO_CLEAN)
endif()

vcpkg_copy_pdbs()

file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)

# Handle copyright
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)

You can directly copy my control file and portfile file to your local corresponding file and build

Thank you for the files. I tried using them on AArch64 but the build is failing - relative to webP. I opened a new issue for that at https://github.com/microsoft/vcpkg/issues/16040
I also tried using --head option in Github Actions. That too is failing.
https://github.com/Shreeshrii/tesseract/actions/runs/536880153
Without the --head option, the SHA didn't match.
https://github.com/Shreeshrii/tesseract/actions/runs/536925557
I am now trying after changing the SHA for REF.
https://github.com/Shreeshrii/tesseract/actions/runs/537076508

My workaround for building tesseract 5 on windows is to use vcpkg for leptonica and then build tesseract from --head of master branch using cmake. https://github.com/tesseract-ocr/tesseract/blob/master/.github/workflows/vcpkg.yml

@Shreeshrii ,It looks great, but I'm sorry, I don't know the ymal file you wrote very well, so I can't give my advice.

Tesseract 5.0.0 has been released. Please update vcpkg to use the new version.

Tesseract 5.0.0 has been released. Please update vcpkg to use the new version.

Yes, tesseract readme has blow:
Major version 5 is the current stable version and started with release 5.0.0 on November 30, 2021. Newer minor versions and bugfix versions are available from GitHub.

Any plan for update?

How  can I get my vcpkg Tesseract to update to 5.1?  I tried  with --head and it still only does 4.1.1

How long before 5.1 is available to install?

vcpkg search tesseract still only brings back 4.1.1

@quaesitor-scientiam ,I will update tesseract to 5.1.0

Performed a git pull this morning
Still no 5.1 listed
PS S:\GitRepro\vcpkg> vcpkg search tesseract
ffmpeg[tesseract]                         Tesseract, needed for ocr filter
tesseract                4.1.1#10         An OCR Engine that was developed at HP Labs between 1985 and 1995... and n...
tesseract[cpu-independed]                 build on any cpu extension commands support
tesseract[training-tools]                 build training tools
The result may be outdated. Run `git pull` to get the latest results.

@quaesitor-scientiam, I'm really sorry, when I submitted this pr, the test was successful locally, but when I submitted it to CI for testing, it couldn't be tested successfully on both windows and linux, and I tried to solve it in the past but there is still a block, I Will try to solve these problems as soon as possible, I hope you can understand

Thanks for the update.  I am not familiar with how the Github CI works and how to see status.  Eventually I might figure that out.

I overwrote my local config directly with these changes in this pr  https://github.com/microsoft/vcpkg/pull/24114 and it works fine

It's hard to understand why CI tests fail...

I overwrote my local config directly with these changes in this pr #24114 and it works fine
It's hard to understand why CI tests fail...

Yes，I'm also confused, I did the 5.1.0 version update locally early on, but it's wrong on CI I'm confused, I tried to modify it, but I put it on hold for other things in the middle

Also for reference, 4.1.1 won't build on mac-osx arm64, their cmake tooling tries to optimize for an architecture that doesn't exist

@JonLiu1993
Hi,
Tesseract is the 10th most stared project among the C++ based projects in GitHub.
Tesseract version 5.2.0 was release a few days ago. Could you please finish the work you started in February?

@JonLiu1993
Hi,
Tesseract is the 10th most stared project among the C++ based projects in GitHub.
Tesseract version 5.2.0 was release a few days ago. Could you please finish the work you started in February?

I will finished it


Preserve extra arguments for connected signals when changing node type

Closes #27174. This seemed like a simple fix and after testing I don't see any problems, however I'm wondering if there is a particular reason the binds were not kept before.

however I'm wondering if there is a particular reason the binds were not kept before.

I think it was probably an oversight, I don't see a reason for not keeping the binds.

Thanks!

Cherry-picked for 3.1.1.


Fix stale DOM with async preact-router

This PR fixes an issue that is most noticeable with the Async component in our cli. The issue is that the previous page is not unmounted correctly when switching routes. When this happens the vnode's _dom property is wrong. The changes fix this problem, but I still haven't found a way to turn it into a decent test case.
Adds +1 B :tada:
EDIT: Found a test case that reproduces the exact issue :tada:

Coverage remained the same at 98.223% when pulling<PHONE_NUMBER>87c2d911824f6e532e009c1e1632f7 on fix_async_router into f7c7f2f68475cd5c113a7f3ac00e8206c7b7be72 on master.


Thanks

This isn't really an issue - I just wanted to say thanks for making this available.  It has been really helpful to me.
Feel free to close this as done :-)
Thanks,
Anthony.

Thank you for the kind words! 👍


Use const fn instead of const macros

This removes field_const, field_storage_const, field_const_raw, affine_const, jacobian_const macros, and replaces them with const fns Field::new, FieldStorage::new, Field::new_raw, Affine::new, Jacobian::new.

If you want to review the large diffs of src/ecmult/const.rs and src/ecmult/const_gen.rs files, it's generated by make gen.

I am not sure if the failing tests are ok, I also did not review the generated files full of constants.

@drahnr Which tests are failing?

Nevermind, looks good to me :)


Add stop_finder.json

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#59  👈
#58
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite


Better resource handling when attaching/detaching webxr hands

See https://forum.babylonjs.com/t/duplicate-instancedmesh-webxr-hand-points-upon-vr-re-entry/52613?u=raananw
In general - resources were kept to be reused, but some of them were recreated on each generation of xr hands.
This PR also improved the disposed resources on session end - all resources

Snapshot stored with reference name:
refs/pull/15531/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15531/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15531/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15531/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15531/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15531/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15531/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15531/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15531/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15531/merge/testResults/webgpuplaywright/index.html

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15531/merge/testResults/webgl1/index.html
If tests were successful afterwards, this report might not be available anymore.

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15531/merge/testResults/webgl1/index.html
If tests were successful afterwards, this report might not be available anymore.


Obtain your data

Hello, I speak as a representative of a group of students from the Universidad Complutense de Madrid (UCM), Spain.
We wanted to make easier for people to exercise their right of access to personal data. Instead of starting from 0, we are creating a fork of your project that it's available at repo, or justgetmydata.com
We wanted to ask the project if you could give us a few pointers and a bit of advice, and if you would accept a Pull Request with a button (or another kind of link or reference) to our project, Just Get My Data.

Hello @daviddavo and fellow students of UCM!
First of all sorry for not replying earlier! I feel delighted that you've drawn inspiration from our project and are doing a spinoff with another very useful idea. In terms of tips, it's hard to say without a question, I think the repository is fairly easy to maintain and you got to be patient, for it won't grow out of nowhere.
As for the button, we don't mind having one on yours site to link to us and vice-versa. We won't promise that we'll keep it if we notice that the project has gone rogue or unmaintained.
Let us know what you folks want to know

The question is, where should we put the link?
We have placed it in the header as another button, but tell us if you consider another place to put it.

Let's discuss there how it looks


is_external is missing in SubnetResources struct

to correctly implement VPC support we need to have access to is_external boolean inside the subnet ressource

fixed in https://github.com/nutanix-cloud-native/prism-go-client/pull/177


What's the main difference between 3 branches?

What's the main difference between 3 branches?

You only need to pay attention to the master branch.


Sync .github/workflows directory with azure-sdk-tools for PR 6440

Sync .github/workflows directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/6440  See eng/common workflow

Overriding check-enforcer. There's no pipeline that'll run that'll test these changes.

/check-enforcer override


Game controller navigation

I was wondering if supporting navigation with a game controller (gamepad or joystick) would be possible with a Gemini client like Lagrange.
The reason I ask is because I use an unusual Linux distro called Batocera that is meant to be controlled with a gamepad and joysticks. For that reason they don't have we browsing capabilities I suppose. They do have a file manager called OD Commander that is bundled as what they call a Port (which I believe is like an AppImage). I think a retro-gaming an media-center distro like this could really benefit from using a Gemini client to navigate through their Wiki, access content and much more.
Please feel free to close the issue if it's too off topic, but I would love to hear your thoughts on the technical feasibility of using Lagrange within Batocera.

I think this would be feasible to implement, and would actually be useful also in a regular Android TV kind of setup. I can't comment specifically about Batocera because I'm unfamiliar with it but thanks to SDL the unlying platform is pretty much abstracted away.
For v1.18 I've been improving usability of the UI when one only has a keyboard, making focus navigation more sophisticated and fixing some event conflicts, etc. This work is directly applicable — required, even — for game controllers as well.
What still needs implementing:

Handling the various game controller / joystick axis and button events. They can be directly mapped to pre-existing event handling, like trackpad navigation, scrolling and key actions.
Making the game controllers / joysticks bindable in the Preferences ("Keys" tab).

That sounds very promising! I have just reached out to the Batocera community via Reddit to gauge interest. I think it would be an exciting experiment to make Lagrange available in there, as a Port to begin with I presume. I'll try to get that to work myself or see if I can get some help to do it.
If you are curious about Batocera and you have a USB drive laying around, I'd encourage you to flash Batocera's latest build for x86 systems into it and boot it on any PC. Alternatively, ETA Prime is a good Youtube channel to learn about it.
I would expect a community around retro-gaming and media preservation would be very receptive to the Small Internet concept, particularly considering the nostalgic side of it. They already seem to put a lot of effort putting together content around old games and consoles they are passionate about, the Gemini protocol could provide a more flexible alternative for them to contribute to their passion projects.  I am hopeful the Batocera community could give the gemini-space a good boost.
Thanks for the prompt reply and the positive take on my suggestion.

UPDATE: runs like a charm! Following the documentation for Ports I managed to get the Lagrange AppImage running without issues on Batocera. Of course I need a mouse and keyboard to use it for the moment. Looking forward to the improved keyboard support and eventually game controller support, whenever you find the time to add them. :family: Thanks!


removing noSchedule  and noExecute toleration from sidecar controller…

… pods
Pull request checklist

This pull request fixes the following issue.

https://github.com/IBM/ibm-spectrum-scale-csi/issues/711

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature Enhancement
[ ] Test Automation
[ ] Code Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Community Operator listing
[ ] Other (please describe):

What is the current behavior?

Sidecar controller pods were not evicting when node on which pods were scheduled becomes not-ready.

What is the new behavior?

When node is down, sidecar controller pods scheduled on it are evicted after 330 seconds.
330 sec (300 seconds default pod eviction timeout, 30 seconds for node status to update to not-ready)
Pods are scheduled to another healthy node.

How risky is this change?

[x] Small, isolated change
[ ] Medium, requires regression testing
[ ] Large, requires functional and regression testing

Private Build: quay.io/nitish3356/csi:operator-pods-not-restarting-fix


Replace pie charts with bar charts

Closes #31

Merge Reverted! please change city names and add at least 3  data series (confirmed, recovered, dead) for each city.


CAMEL-10952 Initial work adding Kinesis Firehose

Looks promising! Thanks!
@davsclaus can you please review when you get a chance?

It may be nice to be able to set that awsClient option on the component so all endpoints uses that, so you dont have to refer to it in the endpoint uri, with the # style.
And if its on component level we can make it easier to configure using spring boot in its application.properties file.

@tigertoes don't forget to add the component into the export section of pom here: https://github.com/apache/camel/blob/master/components/camel-aws/pom.xml#L33-L47

I've noticed that after building locally the build process has modified files in META-INF of camel-aws-starter. Do these changes also need to be committed in?

Yeah or if you dont include them they will be re-generated automatic.
@oscerd looks good you are welcome to take this and get it merged

Sure. I'll merge tomorrow

Thanks. The PR has been merged. Can you close this PR?

Thanks for all the feedback and merging!

you're welcome! :-)


chore: parameterised matrix job to reduce code duplication

Resolves PR Comment
A separate job for each language will be run, currently running two jobs: test and test(php).
For test, helper tests step will run tests for all the languages.
For test(php), helper tests specific to php will be run only.
This can be easily extended for all other languages
Check the workflow run here, test(php) is failing because mono repo hasn't been setup on my sonar account.
Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[ ] Run make test-docker
[ ] Verify affected language:

[ ] Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
[ ] Run make test in twilio-go
[ ] Create a pull request in twilio-go
[ ] Provide a link below to the pull request

[ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
[ ] I have read the Contribution Guidelines and my PR follows them
[ ] I have titled the PR appropriately
[ ] I have updated my branch with the main branch
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added the necessary documentation about the functionality in the appropriate .md file
[ ] I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

Changes should be made to the main branch as there are conflicts with the implementation.


[Feature request] - support 'on-demand' FSx scratch?

After struggling a little with NFS bandwidth issues with EFS/EBS scratch space for larger clusters, FSx has been working like a dream.  Is there any concept however of only mounting FSx to the compute node(s) and having it be deleted when no compute nodes are running (maybe with its own [longer] timeout)?  I wouldn't mind waiting a little longer for compute nodes to come up (if pcluster was also creating a new FSx) as a compromise to vastly reduced monthly costs for bursty workloads.  Currently creating/deleting entire clusters as a spend-thrift workaround is a little unwieldy.
Also, I love the new SLURM queues - super intuitive and functions well - awesome work, thank you!

Hey, Rob. Thanks for the feature request, and for your interest in ParallelCluster. It's particularly great to hear that you're enjoying the functionality introduced in v2.9.
This would be a difficult feature to implement in the short term. There are a few complicating factors, with the biggest one stemming from the fact that, in general, ParallelCluster manages resources via CloudFormation. Provisioning FSx instances dynamically would require us to replicate this functionality.
That said, better managing costs related to idle FSx file systems is a common customer request. I'll capture this request so we can use it as input when considering future changes.
There are a couple of workarounds you could use to save costs. The simplest solution is probably to utilize FSx's HDD-based file systems. The pricing information can be found here.
Another, more involved workaround would be to utilize hooks defined by slurm, such as the epilog and prolog scripts. This would provide the dynamic behavior you're requesting.

Currently creating/deleting entire clusters as a spend-thrift workaround is a little unwieldy.

What are your pain points here? Is there anything we can do here to make this less unwieldy? Is it mostly the time it takes for the delete/create cycle?

Regarding the following from my first response:

There are a couple of workarounds you could use to save costs. The simplest solution is probably to utilize FSx's HDD-based file systems. The pricing information can be found here.

I should add that, unfortunately, we don't support the creation of HDD file systems as part of the creation of a cluster. We're hoping to provide this functionality in the near future. You should still be able to use HDD file systems by creating one outside of the pcluster CLI and specifying that file system's ID as the fsx_fs_id parameter in the [fsx] section of the config file.

Thanks for the swift reply!
I have to admit I wasn't totally sure whether the SCRATCH_1/2 were HDD or SSD, sounds like this is the latter which is good to know.
As for the pain-points, it is really just the auto-shutdown/scale-to-zero that is the most helpful.  Before FSx it was really nice to have a fire-and-forget job queue where the only persistent cost was a small master node and small EBS volume (or two).  Having even the cheapest FSx is I suppose not dissimilar to having a (e.g.) c5a.xlarge RI, which I'm wondering may actually be more functional as a master to host a large shared EBS volume and double up as a dev instance/playground...
Thanks for considering the request and for the detailed and thoughtful response.  I used to use starcluster back in the day and it is great to see pcluster being so actively developed.  It feels a little silly quibbling over $30/month but in the non-profit/academic world it is really nice to be able to burst costs/usage to align with particular projects/grants - makes the accounting much easier.

HDD support has been added with: https://github.com/aws/aws-parallelcluster/pull/2137 and released as part of 2.10.0 release.


Settings?

How do you set the autoprefixer, e.g. "last 2 versions"?

it's been a year, you could have fixed that. still same BS


bin: set alias for vscode

Probably something like /Applications/Visual Studio Code.app/Contents/SharedSupport/bin/vscode or maybe just code.

See this new approach https://code.visualstudio.com/docs/setup/mac#_launching-from-the-command-line


Build URLs using urljoin

This PR makes a small change to how URL's are created when a Host is specified.  Previously, the URL was built by using string concatenation.  This changes it to use urljoin.
This fixes the edge case where a host is entered containing a trailing slash (i.e. https://example.com/ rather than https://example.com).  Once merged, it should work with or without trailing a slash.
supersedes #1216

arg.. CI is failing with this change.. need to investigate when I have a few mins.

The second test_wrong_url case failed, because
assert urljoin("telnet://<IP_ADDRESS>", "/") == '/'

instead of
assert "%s%s" % ("telnet://<IP_ADDRESS>", "/") == 'telnet://<IP_ADDRESS>/'

which changed the failure exception from requests.
This is because urljoin knows you can't put a path on a telnet: URL, and since it's job is to fill in missing bits on the second parameter by taking from the first, it does that by taking nothing from the first.
I suspect urljoin might be the wrong thing to use here, unless we can validate the input earlier so that we get a meaningful exception with the input value, rather than a complaint about a / that was not a parameter provided by the user/caller.
Also, I'm suspicious that this is doing the wrong thing anyway, as if the base_url contains a path and does not end in a /, it now loses the last path element, against due to how urljoin is defined.
>>> urljoin("http://<IP_ADDRESS>/root/path/", "extra")
'http://<IP_ADDRESS>/root/path/extra'
>>> urljoin("http://<IP_ADDRESS>/root/path", "extra")
'http://<IP_ADDRESS>/root/extra'

I suspect this change will break examples/browse_docs_test.py, for example, due to how urljoin handles absolute paths on the second parameter.
>>> urljoin("https://docs.locust.io/en/latest/", "/")
'https://docs.locust.io/'


Feature Request for passing secrets via environmental variables

In version 1 of your bot secrets were passed by a file named as variables.js. So it was easy for us to change each variable into process.env.variablesecret. But now version 2 uses json to pass secrets. So it's little bit pain to search through the JavaScript files and change the required things to environmental variables. I managed to do so and the bot is working very well.
I came across this repo yesterday https://github.com/Dragory/modmailbot/blob/master/docs/configuration.md#environment-variables
Config.js
// Load config values from environment variables
const envKeyPrefix = "MM_";
let loadedEnvValues = 0;

for (const [key, value] of Object.entries(process.env)) {
  if (! key.startsWith(envKeyPrefix)) continue;

  const configKey = key.slice(envKeyPrefix.length)
    .toLowerCase()
    .replace(/([a-z])_([a-z])/g, (m, m1, m2) => `${m1}${m2.toUpperCase()}`)
    .replace("__", ".");

  config[configKey] = value.includes("||")
    ? value.split("||")
    : value;

  loadedEnvValues++;
}

This repo uses config.ini to pass secrets and at same time secrets can be passed by adding a predefined prefix and changing the variables names into snake case.
So in near future can you please add a feature so that it's easy for us to pass secrets via environmental variables.
Thank you for making a very beautiful bot.

I will look into this! Thanks for the support.

I've added support for repl.it, if you must, you can change it to work with your workspace.

Thanks for your quick response. I really appreciate it. Keep up good work. And I added a badge for your repl. You can add on your readme.md it make it for beautiful.

Thank you, I have added this to the readme


Update UserGuide

Details

Update the table of content with a link to the adding comment header within the manual testing section of the developer guide.
Update the Command Summary of UserGuide.
Fixed example of edit in Command Summary.
Add comment command under Features Component.
Add comment command under Table of Content
Modified Add Show to account for comment.
Modified Edit Show to account for comment.

Codecov Report

Merging #153 (b7f3124) into master (ddbf04c) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #153      +/-   ##
============================================
- Coverage     53.78%   53.60%   -0.18%
+ Complexity      340      339       -1
============================================
  Files            79       80       +1
  Lines          1415     1414       -1
  Branches        146      144       -2
============================================
- Hits            761      758       -3
- Misses          600      602       +2
  Partials         54       54

Impacted Files
Coverage Δ

...eedu/trackermon/logic/parser/TrackermonParser.java
78.94% <0.00%> (-4.39%)
:arrow_down:

src/main/java/seedu/trackermon/ui/MainWindow.java
0.00% <0.00%> (ø)

...c/main/java/seedu/trackermon/ui/ShowListPanel.java
0.00% <0.00%> (ø)

...main/java/seedu/trackermon/ui/ShowDetailsCard.java
0.00% <0.00%> (ø)

...a/seedu/trackermon/logic/commands/FindCommand.java
100.00% <0.00%> (ø)

.../seedu/trackermon/logic/commands/ClearCommand.java
0.00% <0.00%> (ø)

...seedu/trackermon/logic/commands/CommandResult.java
88.23% <0.00%> (+2.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbf04c...b7f3124. Read the comment docs.


impl touch events for emscripten

I admit that I don't review emscripten carefully, because the event loop system needs a rework anyway. However that looks good, thanks!


Finding polygons fails for some queries, even when Polygons exist

Problem description

What did you do?

Search for "Cape Town, South Africa", via ox.graph_from_place("Cape Town, South Africa")

What did you expect to happen?

Get the result withou an exception

And what actually happened instead?

It threw the following exception
    ox.graph_from_place("Cape Town, South Africa")
  File "/home/peter/miniconda3/envs/osmnx-examples/lib/python3.9/site-packages/osmnx/graph.py", line 327, in graph_from_place
    gdf_place = geocoder.geocode_to_gdf(
  File "/home/peter/miniconda3/envs/osmnx-examples/lib/python3.9/site-packages/osmnx/geocoder.py", line 110, in geocode_to_gdf
    gdf = gdf.append(_geocode_query_to_gdf(q, wr, by_osmid))
  File "/home/peter/miniconda3/envs/osmnx-examples/lib/python3.9/site-packages/osmnx/geocoder.py", line 166, in _geocode_query_to_gdf
    result = _get_first_polygon(results, query)
  File "/home/peter/miniconda3/envs/osmnx-examples/lib/python3.9/site-packages/osmnx/geocoder.py", line 226, in _get_first_polygon
    if result["geojson"]["type"] in polygon_types:
KeyError: 'geojson'

Environment information

Ubuntu 20
3.9
1.1.1
Provide a complete list of your environment's packages and their versions (for example, run conda list or pip list then paste the output between the two "details" tags below)

# packages in environment at /home/peter/miniconda3:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                        main
brotlipy                  0.7.0           py38h27cfd23_1003
ca-certificates           2020.10.14                    0
certifi                   2020.6.20          pyhd3eb1b0_3
cffi                      1.14.3           py38h261ae71_2
chardet                   3.0.4           py38h06a4308_1003
conda                     4.9.2            py38h06a4308_0
conda-package-handling    1.7.2            py38h03888b9_0
cryptography              3.2.1            py38h3c74f83_1
idna                      2.10                       py_0
ld_impl_linux-64          2.33.1               h53a641e_7
libedit                   3.1.20191231         h14c3975_1
libffi                    3.3                  he6710b0_2
libgcc-ng                 9.1.0                hdf63c60_0
libstdcxx-ng              9.1.0                hdf63c60_0
ncurses                   6.2                  he6710b0_1
openssl                   1.1.1h               h7b6447c_0
pip                       20.2.4           py38h06a4308_0
pycosat                   0.6.3            py38h7b6447c_1
pycparser                 2.20                       py_2
pyopenssl                 19.1.0             pyhd3eb1b0_1
pysocks                   1.7.1            py38h06a4308_0
python                    3.8.5                h7579374_1
readline                  8.0                  h7b6447c_0
requests                  2.24.0                     py_0
ruamel_yaml               0.15.87          py38h7b6447c_1
setuptools                50.3.1           py38h06a4308_1
six                       1.15.0           py38h06a4308_0
sqlite                    3.33.0               h62c20be_0
tk                        8.6.10               hbc83047_0
tqdm                      4.51.0             pyhd3eb1b0_0
urllib3                   1.25.11                    py_0
wheel                     0.35.1             pyhd3eb1b0_0
xz                        5.2.5                h7b6447c_0
yaml                      0.2.5                h7b6447c_0
zlib                      1.2.11               h7b6447c_3

Provide a complete minimal reproducible example
import osmnx as ox
ox.graph_from_place("Cape Town, South Africa")

This might not be a bug, perhaps not all values of results can be expected to have a geojson, but if I simply add a check if 'geojson' in result than it does what I want, which is keep iterating through the list until it finds a Polygen.
I tried dict and OSM ID version of query, and different little tweaks to the query string, they all get the same results.

Interesting. Yes I would expect every value to have a geojson but apparently not. I'll add this check to fix that in #716.


Blazor - SSB iOS and Windows Authentication issue

Describe the bug
When logging into a Blazor SSB Project with Windows Authentication enabled using iOS, the page is unresponsive to input.
To Reproduce
Steps to reproduce the behavior:

Using ASP.NET Core 3.0 preview 9
Create a project using the Blazor Server App template with Windows Authentication option selected.
Connect to the created website using an iOS device. After logging in the hamburger control does not open.

Here's the log:

[Info] [2019-09-13T13:03:07.510Z] Information: Normalizing '_blazor' to 'http://user:58219/_blazor'. (blazor.server.js, line 1)
[Error] WebSocket connection to 'ws://user:58219/_blazor?id=a9_65NTKLSIg1jh3OZbp6Q' failed: Unexpected response code: 401
[Error] [2019-09-13T13:03:07.575Z] Error: Failed to start the transport 'WebSockets': Error: There was an error with the transport.
log (blazor.server.js:1:5021)
(anonymous function) (blazor.server.js:1:47994)
(anonymous function) (blazor.server.js:1:40129)
a (blazor.server.js:1:39051)
promiseReactionJob
[Warning] [2019-09-13T13:03:07.578Z] Warning: Call to HttpConnection.stopConnection(Error: WebSocket closed with status code: 1006 ().) was ignored because the connection hasn't yet left the in the connecting state. (blazor.server.js, line 1)
[Error] [2019-09-13T13:03:07.616Z] Error: Failed to start the transport 'LongPolling': TypeError: undefined is not an object (evaluating 'this.transport.onreceive=this.onreceive')
log (blazor.server.js:1:5021)
(anonymous function) (blazor.server.js:1:47994)
(anonymous function) (blazor.server.js:1:40129)
s (blazor.server.js:1:39004)
promiseReactionJob
[Error] [2019-09-13T13:03:07.616Z] Error: Failed to start the connection: Error: Unable to connect to the server with any of the available transports. WebSockets failed: Error: There was an error with the transport. ServerSentEvents failed: Error: 'ServerSentEvents' does not support Binary. LongPolling failed: TypeError: undefined is not an object (evaluating 'this.transport.onreceive=this.onreceive')
log (blazor.server.js:1:5021)
(anonymous function) (blazor.server.js:1:45885)
(anonymous function) (blazor.server.js:1:40129)
a (blazor.server.js:1:39051)
promiseReactionJob
[Error] [2019-09-13T13:03:07.616Z] Error: Error: Unable to connect to the server with any of the available transports. WebSockets failed: Error: There was an error with the transport. ServerSentEvents failed: Error: 'ServerSentEvents' does not support Binary. LongPolling failed: TypeError: undefined is not an object (evaluating 'this.transport.onreceive=this.onreceive')
log (blazor.server.js:15:27319)
S (blazor.server.js:8:104321)
(anonymous function) (blazor.server.js:8:104045)
(anonymous function) (blazor.server.js:8:100600)
a (blazor.server.js:8:99498)
promiseReactionJob
[Error] Unhandled Promise Rejection: Error: Cannot send data if the connection is not in the 'Connected' State.
(anonymous function) (blazor.server.js:8:100661)
a (blazor.server.js:8:99498)
promiseReactionJob

@BrennanConroy would you know what might cause this error?

Well a 401 is the unauthorized http code.
Could you gather server side logs so we can see why auth might have failed?

Sure, here's the log.
ex190913.log

Not sure where you got those logs. But we need the logs from ASP.NET Core, see https://docs.microsoft.com/aspnet/core/fundamentals/logging/?view=aspnetcore-2.2 for details on the logging.

Sorry, is this what you were looking for?

Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 GET http://user:58219/_framework/blazor.server.js
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 GET http://user:58219/css/bootstrap/bootstrap.min.css
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 GET http://user:58219/
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 GET http://user:58219/css/open-iconic/font/css/open-iconic-bootstrap.min.css
Microsoft.AspNetCore.Routing.EndpointMiddleware: Information: Executing endpoint '/_Host'
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 GET http://user:58219/css/site.css
Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker: Information: Route matched with {page = "/_Host"}. Executing page /_Host
Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker: Information: Executing an implicit handler method - ModelState is Valid
Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker: Information: Executed an implicit handler method, returned result Microsoft.AspNetCore.Mvc.RazorPages.PageResult.
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware: Information: The file /css/open-iconic/font/css/open-iconic-bootstrap.min.css was not modified
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware: Information: The file /css/bootstrap/bootstrap.min.css was not modified
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware: Information: The file /_framework/blazor.server.js was not modified
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware: Information: The file /css/site.css was not modified
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 21.8805ms 304 text/css
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 27.352400000000003ms 304 text/css
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 30.258300000000002ms 304 application/javascript
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 24.803700000000003ms 304 text/css
Microsoft.AspNetCore.Authorization.DefaultAuthorizationService: Information: Authorization was successful.
Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker: Information: Executed page /_Host in 28.050600000000003ms
Microsoft.AspNetCore.Routing.EndpointMiddleware: Information: Executed endpoint '/_Host'
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 38.257200000000005ms 200 text/html; charset=utf-8
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 GET http://user:58219/_framework/blazor.server.js
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 GET http://user:58219/css/bootstrap/bootstrap.min.css
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 GET http://user:58219/css/site.css
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware: Information: The file /_framework/blazor.server.js was not modified
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware: Information: The file /css/bootstrap/bootstrap.min.css was not modified
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware: Information: The file /css/site.css was not modified
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 10.2482ms 304 application/javascript
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 8.0576ms 304 text/css
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 9.4864ms 304 text/css
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 GET http://user:58219/css/open-iconic/font/css/open-iconic-bootstrap.min.css
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware: Information: The file /css/open-iconic/font/css/open-iconic-bootstrap.min.css was not modified
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 5.477ms 304 text/css
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 POST http://user:58219/_blazor/negotiate text/plain;charset=UTF-8 0
Microsoft.AspNetCore.Routing.EndpointMiddleware: Information: Executing endpoint '/_blazor/negotiate'
Microsoft.AspNetCore.Routing.EndpointMiddleware: Information: Executed endpoint '/_blazor/negotiate'
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 20.950300000000002ms 200 application/json
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request starting HTTP/1.1 POST http://user:58219/_blazor/negotiate text/plain;charset=UTF-8 0
Microsoft.AspNetCore.Routing.EndpointMiddleware: Information: Executing endpoint '/_blazor/negotiate'
Microsoft.AspNetCore.Routing.EndpointMiddleware: Information: Executed endpoint '/_blazor/negotiate'
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 6.2174000000000005ms 200 application/json

@rkone those look like the right logs. Could you bump up the application's log level to Debug? It should have more details as to what's going on.

I was already looking through it (but still not seeing anything):
BlazorAppDebugLog.txt

It looks like you're using Chrome, could you try a different browser and see if you get the same results.
There have been issues in the past (and maybe the present) with chrome not working well with websockets and windows auth. https://bugs.chromium.org/p/chromium/issues/detail?id=423609

Oh, and Android Chrome works too.

Took a look at this and it looks like Safari does not support authentication over websockets. Edge and Chrome on iOS are really using Safari under the covers which explains why they also aren't working.
You can see the bug on Safari here: https://bugs.webkit.org/show_bug.cgi?id=80362
If you want to workaround the issue you can try to use Cookie Auth in combination with Windows Auth. For example the negotiate will do Windows Auth and the server will return a cookie which will be set on the WebSocket automatically by the browser and when the WebSocket connects the server will see the cookie and know the Windows Identity based on that.

@BrennanConroy Thanks very much for looking into that!
I see in fact this is (technically) covered in the docs at https://docs.microsoft.com/en-us/aspnet/core/signalr/authn-and-authz?view=aspnetcore-2.2#windows-authentication:

Windows Authentication is only supported by the browser client when using Microsoft Internet Explorer or Microsoft Edge.

This will confuse people because in fact it does work in Chrome on Windows as well, even if we don't "support" that.
@danroth27 We should consider changing the "file new" dialog in VS so that, when you choose Windows Authentication, it also displays a warning saying something like Windows Authentication is only supported for clients running Microsoft Edge on Windows. Mobile browsers are not supported..


BugID:1761:Add the source code of weight scale.

[Detail]
Issue description:
#1761
Rootcause:
Solution:
Requirement description:
Solution:
[Verified Cases]
Build Pass:
Test Pass:
Signed-off-by: wzhiyuan-nit<EMAIL_ADDRESS>

感谢提交 Pull Requests！
Thanks for submitting a pull request.

Security Check : 3c47d13590a7487d1098dabdbb77b157a30d30a5

auto build success,number:211

autotest fail,number:1564


allow multiple files to be directly mentioned in OCL

Currently OCL supports only file in 'deployer'. We must change this to allow multiple files.

[ ] change deployer field to a Map - key must be file name (with correct file extension) and value must be the file content.
[ ] change deployment module to directly create files with the names from the OCL instead of the fixed names.
[ ] Test if the scripts can contain for example a shell script, a python script.
[ ] Update samples.

I will take it


Azure PowerShell command to get fingerprint in the Connect to a Linux VM page fails

Azure PowerShell command from step 3 in this section fails!

Invoke-AzVMRunCommand -ResourceGroupName 'myResourceGroup' -VMName 'myVM' -CommandId 'RunPowerShellScript' -ScriptString 'ssh-keygen -lf /etc/ssh/ssh_host_ecdsa_key.pub | awk '{print $2}''
This command fails with the below error message,

Invoke-AzVMRunCommand: A positional parameter cannot be found that accepts argument 'print $2'.

So I updated the command like this,
Invoke-AzVMRunCommand -ResourceGroupName 'myResourceGroup' -VMName 'myVM' -CommandId 'RunPowerShellScript' -ScriptString 'ssh-keygen -lf /etc/ssh/ssh_host_ecdsa_key.pub'
But this command fails with the below error message,

Invoke-AzVMRunCommand: Run command OS type 'Windows' does not match the target OS Linux.
ErrorCode: Conflict
ErrorMessage: Run command OS type 'Windows' does not match the target OS Linux.
ErrorTarget:
StatusCode: 409
ReasonPhrase: Conflict
OperationID : 58758139-04c4-4e3e-a1e5-186979deb7ff

I ended up using -CommandId 'RunShellScript' -ScriptString 'ssh-keygen -lf /etc/ssh/ssh_host_ecdsa_key.pub'
Not sure if I missed any step or this document needs to be updated
Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4f6a10f6-2d61-8956-e98b-21387a43a073
Version Independent ID: f82eb7ff-7ade-8644-b57a-17ad978422be
Content: Connect to a Linux VM - Azure Virtual Machines
Content Source: articles/virtual-machines/linux-vm-connect.md
Service: virtual-machines
GitHub Login: @mattmcinnes
Microsoft Alias: mattmcinnes

@karthick-in
Thanks for your feedback! We will investigate and update as appropriate.

Hi @karthick-in
It seems like you are trying to run a PowerShell script on a Linux VM using the Invoke-AzVMRunCommand command. However, the error message indicates that the target OS is Linux, not Windows, so the PowerShell script cannot be executed.
You are correct that the CommandId parameter should be set to RunShellScript instead of RunPowerShellScript to run a shell script on a Linux VM. The correct command should be:
Invoke-AzVMRunCommand -ResourceGroupName 'myResourceGroup' -VMName 'myVM' -CommandId 'RunShellScript' -ScriptString 'ssh-keygen -lf /etc/ssh/ssh_host_ecdsa_key.pub'
I Think it helps! If there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.

Hi @Naveenommi-MSFT thanks for the response.
The parameter -VMName 'myVM' in step 3 (Validate the returned fingerprint.) in this section is referring to a linux VM, right? (to print the VM's fingerpirint)
If so, does the CommandId parameter needs to be updated in the documentation?

@karthick-in
Thank you for bringing this to our attention.
I've delegated this to content author @mattmcinnes, who will review it and offer their insightful opinions.

Hi @karthick-in , thank you for the feedback!
Looks like the article was indeed invoking the incorrect command. It was using Windows PowerShell terminology in the 'Windows' tab despite the connection being remote to a Linux VM. The documentation has been updated and should be live in the next few days!

#please-close


meta-mender-nxp: Add i.MX7D Sabre

https://www.nxp.com/design/development-boards/i.mx-evaluation-and-development-boards/sabre-board-for-smart-devices-based-on-the-i.mx-7dual-applications-processors:MCIMX7SABRE
Signed-off-by: Joris Offouga<EMAIL_ADDRESS>

Nice, thanks!


Loss value

I have tried implementing this for a project of mine and the loss went negative. Is this expected? Should I take the absolute of my residual before passing it to the loss function?

If you call the loss in general.py, it should never go negative. The loss produced by adaptive.py is actually a negative log-likelihood, so it can go negative depending on the value of the scale parameter.

makes perfect sense, thanks for the quick response


Update ControlPanelBase.cs

It seems to me that PortalController.Instance.GetCurrentPortalSettings().ControlPanelSecurity == PortalSettings.ControlPanelPermission.ModuleEditor, at line 184, is preventing Admin > Site Settings > Usability Settings > Control Panel Settings from being set to anything other than Module Editors. If this setting is set to Page Editors the module cannot be edited.

Declan, can you provide a Jira ticket for this where you explain the use case? I'm not 100% sure on what this is trying to fix. A sample on how to reproduce would be helpfull.

@cnurse and I discussed this last night - here's the relevant text:
[20/03/2015 21:20:05] cathalconnolly: the current check is if the site allows module editors to see the control panel and they are an editor on 1 or more modules on a page
[20/03/2015 21:20:15] cathalconnolly: changing it to Declans changes that logic
[20/03/2015 21:20:37] Charles Nurse: I agree
[20/03/2015 21:20:52] Charles Nurse: The point is that admins MUST allow Module Editors to access the controlpanel
[20/03/2015 21:21:07] Charles Nurse: otherwise that setting is meaningless
[20/03/2015 21:22:07] Charles Nurse: Now - this is only a property that returns IsModuelAdmin
[20/03/2015 21:22:25] Charles Nurse: the visibility may be enforced later in conjunction with the ControlPanelMode
[20/03/2015 21:22:52] Charles Nurse: But if this is all that controls the visibility then we can't change it
[20/03/2015 21:23:00] cathalconnolly: yup
[20/03/2015 21:23:22] Charles Nurse: So you should check the usage of the property
[20/03/2015 21:23:45] cathalconnolly: i figured it should be ControlPanelPermission.PageEditor or (ControlPanelPermission.ModuleEditor && _IsModuleAdmin;)
[20/03/2015 21:25:00] Charles Nurse: I guess what I am saying is that the property name is IsModuleAdminInternal
[20/03/2015 21:25:16] Charles Nurse: to satisfy the name of the property the change is actually valid
[20/03/2015 21:26:01] Charles Nurse: we need to check how the property is used
[20/03/2015 21:26:19] Charles Nurse: ie - is the extra check in this property redundant
[20/03/2015 21:26:31] Charles Nurse: because the security setting is checked later
[20/03/2015 21:26:56] cathalconnolly: sure -i'll follow it through but its only refernced in controlbar.ascx

Vicenç,
It is detailed here https://dnntracker.atlassian.net/plugins/servlet/mobile#issue/DNN-6087

Cathal I'll leave that up to you since you seem more familiar with that

This is an incorrect fix for the issue referenced.  This is demonstrated by the comment in the JIRA ticket that other modules work OK, but the HTML module does not work.
This fix basically ignores/overrides the Site Setting for Control Panel Visibility.
The correct fix is in the module that fails to work properly.


Support CDK pipeline

We haven't gotten around to putting in official support, but some mentioned they got it to work by conditionally defining the PipelineStack. Some rough pseudocode looks alike:
  if (app.local) {
    new ApplicationStack(app, 'api', { tags });
  } else {
    new PipelineStack(app, 'BackendPipeline');
  }

Requests:

Jannik https://discord.com/channels/983865673656705025/990876984886321192/991202417205071882
Blue https://discordapp.com/channels/983865673656705025/983866416832864350/1019048682466840626

Is there a timeline on when this might be officially supported? We currently use cdk with code pipeline and this is blocking us from moving towards SST.

I think somebody on Discord got this to work. Might want to search on there. But official support for it is a bit lower priority on our roadmap.


[E2E] automated e2e tests should fail gracefully when test bed setup is not ideal or some environment vars are not set

With the swarm test automation and govc integration, there are bunch of env variables need to be set inorder to execute tests locally. In an absence of ideal testbed or env. vars, tests are failing with out giving proper error message. It creates lot of confusion to the user and ends up spending more time.
This issue is to streamline the failure and provides meaningful information to user when run into test setup issues.

remove unnecessary environment variables from contributing.md too.

/CC @msterin

Here's my suggestion (copied from #1517 )

Verify the required environment variables are properly initialized before running e2e test
Clean up the Config DB if it already exists before running each test group
Maybe more...

@ashahi1  is already having partial fix so bringing back to his plate

Fixed as part of PR #1530


feat: Dynamic Service Worker

Update ServiceWorker at every build with the correct API URL

What do you think about the location /script? I'm not really sure myself.


Windows + libsoup 3.x

Comment:
I understand that libsoup 3.x requires nghttp2. I have helped compile that.
However, today, the blocker is on gir gobject-introspection not working correctly.
Would it be ok to release libsoup3 without gir for windows?
xref: https://github.com/conda-forge/libsoup-feedstock/pull/45

@conda-forge-admin please rerender

In a previous build the following used to be used to copy a known working of the files over:
:: The gir files produced by the build are currently broken, don't know why...
copy %RECIPE_DIR%\gir\*typelib %LIBRARY_LIB%\girepository-1.0\
if errorlevel 1 exit 1
copy %RECIPE_DIR%\gir\*gir %LIBRARY_PREFIX%\share\gir-1.0\
if errorlevel 1 exit 1

Perhaps this can be a clue https://github.com/conda-forge/librsvg-feedstock/blob/main/recipe/bld.bat

I don't think we should release a Windows build of libsoup 3 without gobject-introspection, as it feels like a step backwards from what libsoup 2 offered.
However, I won't be the one putting in the fix due to a lack of time and resources, so if you insist we proceed then I am ok with that.

feels like a step backwards from what libsoup 2 offered.

I get it. but honestly, given the time resources we have, it isn't all that meaningful to keep building two branches, especially when one is of quite an old version.
PS. a made a few PRs to your feedstocks to help keep libraries in sync. Let me know if you need my help maintaining by adding me as a maintainer there.


Compile errors when setting engines.vscode to *

Testing #14290

open your extensions package.json file
change the engine.vscode property to *
run npm run postinstall (assuming you have the vscode module as dev-dependency)

Import references to 'vscode' will have errors:

We should add a marker after the module declaration such that it doesn't get removed by older versions of the node module

We will add this to the release notes

release noted in https://github.com/Microsoft/vscode-docs/commit/fd47d661fa748f7c2e54b764207013bf5346be5d

I added a link to http://code.visualstudio.com/updates#_authoring-in-typescript in the release notes.


Add an Environment Variable 'refresh' before installing package

Some packages, like RabbitMQ in the Chocolatey Repo, can have their installation customized based on Environment Variables (questionable but common method in *nix environment, and ported applications).
When using DSC and setting variables via the Environment resource (which, btw does not support [EnvironmentVariableTarget]), you'd need to restart before being able to install such package. Would it be possible to add a refresh Environment variable to the process that runs the install-package?
Would you consider a PR with the above?
Here's what the resulting configuration could look like:
        Environment RMQBase {
            Ensure            = 'Present'
            Name              = 'RABBITMQ_BASE'
            Value             = $Node.RabbitMQBase
        }

        Environment ErlangHome {
            Ensure            = 'Present'
            Name              = 'ERLANG_HOME'
            Value             = 'C:\Program Files\erl8.0'
        }

        PackageManagement RabbitMQ
        {
            Ensure            = 'present'
            Name              = 'RabbitMQ'
            Source            = 'Chocolatey'
            DependsOn         = '[Environment]ErlangHome'
        }

The workarounds atm are: restarting, wait for next run, hack by killing session and restarting it, create custom PackageManagement resource to add the functionality...

By the way, the core functionality should probably be provided by PackageManagement module (as in, not the DSC resource), or the Chocolatey provider.
I believe this behaviour has been fixed in Chocolatey v9.10 (issue 664), but I believe we're still waiting for the full re-work of the Chocolatey provider.

@gaelcolas.  We welcome contributions from the community, i.e., accept PR.
You are right. We do not have OneGet-Chocolatey provider yet.

I talked with @grayzu about this, and I'm not sure about how to implement such refresh in the LCM, but would be happy to submit a PR if given a bit guidance.

This issue was moved to OneGet/oneget#255


unipept command: pass peptide(s) as command line argument(s)

@tvwillem @bmesuere would it be an option to allow passing peptide(s) as command line argument(s)? This would make a stronger analogy to the Single and Multi-peptide analysis tools in the Unipept webinterface. Multi-peptide Analysis would then correspond to reading multiple peptides from stdin. Single Peptide Analysis would then correspond to passing the peptide as an argument (bypassing reading from stdin).
As such, we could write (~single)
$ unipept pept2prot ENFVYIAK
sequence,uniprot_id,taxon_id
ENFVYIAK,P42654,3906
ENFVYIAK,Q96453,3847
ENFVYIAK,C6TH93,3847
ENFVYIAK,C6TM63,3847
ENFVYIAK,I1LUM3,3847
ENFVYIAK,F6H2P0,29760
ENFVYIAK,E1U3Z1,3827
ENFVYIAK,I3SLC5,3880
ENFVYIAK,M0TAI1,214687
ENFVYIAK,I1M3M0,3847
ENFVYIAK,G7LIR4,3880
ENFVYIAK,M0TY03,214687

Instead of the equivalent (~multi)
$ echo ENFVYIAK | unipept pept2prot
sequence,uniprot_id,taxon_id
ENFVYIAK,P42654,3906
ENFVYIAK,Q96453,3847
ENFVYIAK,C6TH93,3847
ENFVYIAK,C6TM63,3847
ENFVYIAK,I1LUM3,3847
ENFVYIAK,F6H2P0,29760
ENFVYIAK,E1U3Z1,3827
ENFVYIAK,I3SLC5,3880
ENFVYIAK,M0TAI1,214687
ENFVYIAK,I1M3M0,3847
ENFVYIAK,G7LIR4,3880
ENFVYIAK,M0TY03,214687

However, I believe we already agreed upon the fact that arguments would be interpreted as file names. Could both interpretations be combined?
Original issue by @pdawyndt on Tue May 13 2014 at 21:45.
Closed by an unknown user on Mon May 19 2014 at 11:35.

File input should be done with the -i option. (So it does not overlap with the above mentioned usage)
I falsely reported in a meeting this seemed ugly as -- seemed required, however it seems I was wrong and it does work as explained above.
Original comment by ghost on Mon May 19 2014 at 11:35.

@tvwillem I immediately wanted to replace all the examples in the case studies section I'm compiling for your thesis, as this the new usage is prettier than the old one. However, in doing the comparison for the first example, I noticed that there's something wrong when using the old syntax: the first input line gets eaten !!
$ echo ENFVYIAK | unipept pept2prot                    # where's the output of ENFVYIAK ?
$ echo -ne 'ENFVYIAK\nAAAAAA\n' | unipept pept2prot    # where's the output of ENFVYIAK ?
sequence,uniprot_id,taxon_id
AAAAAA,B1JV19,406425
AAAAAA,B4EDU1,216591
AAAAAA,B6BCG3,439496
AAAAAA,G9A8S4,1117943
AAAAAA,H1J113,794903
AAAAAA,M4UG15,1262456
AAAAAA,I6ASY3,278956
AAAAAA,E3HG86,762376
AAAAAA,Q8XXN0,267608
AAAAAA,D0MXH8,403677
AAAAAA,L8VTU0,985077
AAAAAA,B8AMV9,39946
AAAAAA,A2VX15,350702
AAAAAA,I3XBF3,1185652
AAAAAA,D8NAG4,305
AAAAAA,L9PRJ2,1198452
AAAAAA,H8X2L6,1136231
AAAAAA,I0IAB9,1142394
AAAAAA,G7HJJ1,1055524
AAAAAA,L8V6H5,985076
AAAAAA,A0AW41,290399
AAAAAA,A4I079,5671
AAAAAA,B9FB00,39947
AAAAAA,G8BAV5,578454
AAAAAA,C3MFJ4,394
AAAAAA,C6BJR9,428406
AAAAAA,E2T0Z7,658664
AAAAAA,Q4QBD5,5664
AAAAAA,F0YJD2,44056
AAAAAA,A1SDN3,196162
AAAAAA,G0A8W1,1005048
AAAAAA,G0S9H0,759272
AAAAAA,E9BG64,981087
AAAAAA,G9ZUB1,1054213
AAAAAA,B0FBR7,9606
AAAAAA,G7HVL2,1110505
AAAAAA,C1N5N4,564608
AAAAAA,B2U7T1,402626
AAAAAA,C5AA06,626418
$ unipept pept2prot ENFVYIAK                           # OK
sequence,uniprot_id,taxon_id
ENFVYIAK,P42654,3906
ENFVYIAK,Q96453,3847
ENFVYIAK,C6TH93,3847
ENFVYIAK,C6TM63,3847
ENFVYIAK,I1LUM3,3847
ENFVYIAK,F6H2P0,29760
ENFVYIAK,E1U3Z1,3827
ENFVYIAK,I3SLC5,3880
ENFVYIAK,M0TAI1,214687
ENFVYIAK,I1M3M0,3847
ENFVYIAK,G7LIR4,3880
ENFVYIAK,M0TY03,214687
$ unipept pept2prot ENFVYIAK AAAAAA                    # OK
sequence,uniprot_id,taxon_id
ENFVYIAK,P42654,3906
ENFVYIAK,Q96453,3847
ENFVYIAK,C6TH93,3847
ENFVYIAK,C6TM63,3847
ENFVYIAK,I1LUM3,3847
ENFVYIAK,F6H2P0,29760
ENFVYIAK,E1U3Z1,3827
ENFVYIAK,I3SLC5,3880
ENFVYIAK,M0TAI1,214687
ENFVYIAK,I1M3M0,3847
ENFVYIAK,G7LIR4,3880
ENFVYIAK,M0TY03,214687
AAAAAA,B1JV19,406425
AAAAAA,B4EDU1,216591
AAAAAA,B6BCG3,439496
AAAAAA,G9A8S4,1117943
AAAAAA,H1J113,794903
AAAAAA,M4UG15,1262456
AAAAAA,I6ASY3,278956
AAAAAA,E3HG86,762376
AAAAAA,Q8XXN0,267608
AAAAAA,D0MXH8,403677
AAAAAA,L8VTU0,985077
AAAAAA,B8AMV9,39946
AAAAAA,A2VX15,350702
AAAAAA,I3XBF3,1185652
AAAAAA,D8NAG4,305
AAAAAA,L9PRJ2,1198452
AAAAAA,H8X2L6,1136231
AAAAAA,I0IAB9,1142394
AAAAAA,G7HJJ1,1055524
AAAAAA,L8V6H5,985076
AAAAAA,A0AW41,290399
AAAAAA,A4I079,5671
AAAAAA,B9FB00,39947
AAAAAA,G8BAV5,578454
AAAAAA,C3MFJ4,394
AAAAAA,C6BJR9,428406
AAAAAA,E2T0Z7,658664
AAAAAA,Q4QBD5,5664
AAAAAA,F0YJD2,44056
AAAAAA,A1SDN3,196162
AAAAAA,G0A8W1,1005048
AAAAAA,G0S9H0,759272
AAAAAA,E9BG64,981087
AAAAAA,G9ZUB1,1054213
AAAAAA,B0FBR7,9606
AAAAAA,G7HVL2,1110505
AAAAAA,C1N5N4,564608
AAAAAA,B2U7T1,402626
AAAAAA,C5AA06,626418

Original comment by @pdawyndt on Mon May 19 2014 at 17:51.

@pdawyndt noted, Side effect from the fasts parsing.
Original comment by ghost on Mon May 19 2014 at 17:53.

Should be fixed now in unipept 0.5.3
Original comment by ghost on Mon May 19 2014 at 21:51.


All videos marked as read when clicking a single notification from notification list

I saw all the notification ids get passed to the edit call.

this is annoying, should be fixed soon.


About initial learning rate

Hi,
May I know what's the initial learning rate used in Cifar10 and Cifar100 experiments (-b 128 on 2 GPU cards)? The default value 0.1 or the sample value 0.05? Many thanks in advance!

Hi!
Following the original LUA implementation, for BS=128, the learning rate should be 0.1, since they use lr=0.05 for BS=64 and 0.025 for BS=32.

Hi!
Following the original LUA implementation, for BS=128, the learning rate should be 0.1, since they use lr=0.05 for BS=64 and 0.025 for BS=32.

Thanks!


Improve the warning given when using channel before it's defined

Issue: https://github.com/storybooks/storybook/pull/1514 fixed an issue where a "fake" channel that threw a warning broke RN. This left us without a warning
What I did
Instead, let's throw directly and check for that in the RN initializer.
How to test
Check RN-vanilla, plus general testing (CI + CRA-ks).
Note
This is targeted to #1514, we should change the target when that is merged.
Sometimes it's possible things grab the channel and don't access it, which might be a problem.
Another approach would just be to log a warning rather than throwing.

LGTM, ready to merge @tmeasday

Merge to master @ndelangen ?

Ow I didn't notice this isn't actually based on master.
In that case, we first need to rebase on master, or merge into it's current base, and proceed from there.
This particular change look good to me, I haven't seen #1509-fix-react-native-example

That's been merged I think. Let me mess with the PR

Codecov Report

Merging #1515 into master will decrease coverage by 5.93%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1515      +/-   ##
=========================================
- Coverage   20.53%   14.6%   -5.94%
=========================================
  Files         241     202      -39
  Lines        5220    4657     -563
  Branches      639     501     -138
=========================================
- Hits         1072     680     -392
+ Misses       3659    3554     -105
+ Partials      489     423      -66

Impacted Files
Coverage Δ

lib/addons/src/index.js
0% <0%> (ø)
:arrow_up:

app/react-native/src/preview/index.js
0% <0%> (ø)
:arrow_up:

addons/info/src/components/theme.js
0% <0%> (-100%)
:arrow_down:

addons/info/src/index.js
0% <0%> (-91.31%)
:arrow_down:

addons/info/src/components/Story.js
0% <0%> (-73.81%)
:arrow_down:

addons/info/src/components/markdown/text.js
0% <0%> (-66.67%)
:arrow_down:

app/react/src/client/preview/client_api.js
42.04% <0%> (-46.6%)
:arrow_down:

addons/info/src/components/PropVal.js
0% <0%> (-43.16%)
:arrow_down:

app/react/src/server/babel_config.js
44.82% <0%> (-39.05%)
:arrow_down:

addons/info/src/components/Node.js
0% <0%> (-38.89%)
:arrow_down:

... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d55c2...9cd69c8. Read the comment docs.

@UsulPro -- why does it fail? In what context? Storyshots?

@tmeasday it fails if I run Jest test which imports this file. Actually I already have fixed this just by removing this line inside the not covered code

A Jest test -- is it storyshots or something else?

I faced it in #1501 (addon-info)
But the easiest way to reproduce it -- just insert const channel = addons.getChannel(); in *.test.js and run Jest.
Actually, I agree - fake channel it the best and right way to deal with it. In my case, I don't test part of code related to channel since it's a very small piece of code so I left it uncovered. Maybe I should write a test for that later.

Yeah i'm not sure. I couldn't figure out a better way to warn people about the addons.getChannel() = undefined problem (which otherwise leads to a vanilla "can't access X on undefined" issue), and how they might solve it
Fake/mock channel seems pretty reasonable. With jest you can do it with one line I reckon.

With 4.0 I will change channel to be a Promise


Redesign the car classification demo

Make it work without the DS-flavor configs. Move the current module to the flavors directory under the name module-remote-ds-conf.yml.
Also, display the track id.

Track id is already displayed in the module's drawfunc.
Nvtracker parameter display-tracking-id concerns display through nvosd.


After odering, attempting to go home results in only Navbar

After choosing a city, restaurant, and placing a test order (and fiddling about with some of the checkboxes afterwards), clicking the "Home" button caused the loadspinner to briefly appear and then disappear, but the home page never rendered. The result was only the navbar and a black screen underneath

Thanks for reporting!

Thanks, I'm working on donejs 3, will make sure this is resolved.

I'm not seeing this happen in donejs 3. I'll release to prod and confirm.


How to set up custom services ?

I have installed this theme, and then I'm following the instructions of Homer documentation to set up custom services card, but nothing change.
Like, no data display or status, is this normal ?

Hey, this is probably an issue on your end and not on the end of my theme. Please make an issue on the Homer GitHub.


Is LaTeX discussed at all?

What is the project position on LaTeX? LaTeX for chemistry in itself it could easily be (and probably is) the subject another book. However it's very useful when it comes to e.g. axes labels, is it going to be introduced anywhere?

Let’s leave it out of simple plotting? Advanced plotting could include it though (basically referring to the use of it without in depth coverage).

Happy with that.

I think we can include a “LaTeX cheat sheet” for typical plotting uses, or maybe an appendix (who doesn’t love a good appendix?).

One appendix/SI at a time Benjamin


docs: update comparison

Adds "declarative" as an option for API definition for React Query. With v3, you can now configure all of your queries and mutations up front before calling them.

Ah, nice. Gotta check this out. Just out of interest: did we inspire you or was that on your list anyways? ^^

We've been working on it almost since v2 shipped earlier this year. But to be fair, it's still not the "generative" declarations like RTK. For example, RTK does a lot of cool heavy-lifting for you via configutation and entity types and auto-invalidation etc, (super cool btw), where RQ, despite supporting a declarative api, still requires that you wire up queries/mutations to work together.  This does bring RQ one step closer to being able to do the auto-link stuff too, but we'll have to see if we go in that direction with the core, or just ship that out to utility wrappers / plugins/ who knows :)

To be fair, while it's cool, it also adds a bit of a first hurdle of concepts to learn, so it's maybe better if we don't all have the same featureset in the end :sweat_smile:
I'm just skimming the docs over at https://react-query-beta.tanstack.com/overview - I assume I should be looking at the right place, but can't find anything regarding a declarative definition. Can you point me to the right spot?
Oh, and I noticed that you are adding the size of RTK and RTK-query in the size comparison table. That's not 100% correct as in that case you're adding immer twice. So you can substract another 5.4kb from that ;)
But it's very cool to be on that list :tada:
Although it's a bit sad to see urql not on that list any more - it's a cool library and was a big inspiration for the entityTypes (it's their default cache invalidation model). But yeah, space is limited I guess.

Happy release day!


MM-12803 - Fixing permanent banner styling

Summary
MM-12803 - Fixing permanent banner styling
Ticket Link
https://mattermost.atlassian.net/browse/MM-12803
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Ran make check-style to check for style errors (required for all pull requests)
[ ] Ran make test to ensure unit and component tests passed
[ ] Added or updated unit tests (required for all new features)
[ ] Needs to be implemented in mobile (link to PR or User Story)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[x] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-01c96332bf0b8ebdd.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-01c96332bf0b8ebdd

@asaadmahmood I took a look and now it looks like when the banner is dismissable, the padding below the banner text is missing:

Spinmint test server destroyed

@lindalumitchell Have a look again.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: https://i-0719bb8382f53a282.test.spinmint.com
Test Admin Account: Username: sysadmin | Password: sysadmin
Test User Account: Username: user-1 | Password: user-1
Instance ID: i-0719bb8382f53a282

Thanks @asaadmahmood, I took another look on a new spinmint, but now it looks like it's showing the original issue again: When non-dismissable, the banner covers some content:

Looks like those changes happened because of some recent changes that @crspeller did. Let me see what happened.

@lindalumitchell Talked to @crspeller The changes that he did are not in for 5.5. So we can get my changes in for 5.5 and test it on the 5.5 RC. It should work fine there.

Ah I see, thanks @asaadmahmood. Which means we may need a v5.6 ticket then? I can follow up on that. So let's get this merged in for the 5.5 RC and we'll test it there as you said. Thanks!

(Notes for reference) Thanks Asaad; I see you put in a ticket for v5.6 (MM-12902). So we'll test this on RC2 after this PR is merged. Looks like Amy labeled it Ready to Merge, and it's also Cherry Pick Approved.

Spinmint test server destroyed


fix: fixed turbo

#247  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bob-obringer and the rest of your teammates on  Graphite


check compatibility of winbox with nuxt3

to properly integrate winbox / winbox-vue into nuxt, a plugin may be required
see https://github.com/wobsoriano/vue-winbox/issues/9

@ctot-nondef demonstrated a way to use winbox in 8967ad351611f7333e437d8f6a0d36ba088309f6
@ttechnicus please confirm that this is a viable solution and how to get and manipulate WinBox'es state.

Branch has been successfully merged into develop


-Wunused-member-function is reported incorrectly

clangd reports -Wunused-member-function for the following code:
#include <memory>

namespace {

struct deleter {
    void operator()(int* ptr) const noexcept { // -Wunused-member-function
        delete ptr;
    }
};

} // namespace

void f() {
    std::unique_ptr<int, deleter>(new int);
}

When compiling, clang++ does not report -Wunused-member-function. clang-tidy and clang-check also don't rerpot the warning.
When using Google Test's TEST() macro, the same thing happens:
#include <gtest/gtest.h>

namespace {

TEST(Something, something) { // -Wunused-member-function
    // ...
}

} // namespace

At its core this is the same as #137.
The root cause is that we don't parse the bodies of functions in headers - in this case the unique_ptr destructor. This is for performance reasons: it saves a lot of time parsing and also avoids instantiating a lot of templates. The tradeoff is accuracy, we miss certain types of diagnostics and occasionally generate spurious diagnostics like this one.
I can't think of a great workaround for this other than turning off -Wunused entirely :-
The skip-function-bodies optimization is pretty important: it roughly halves clangd CPU usage and latency, with even more dramatic results in some cases (https://reviews.llvm.org/D41495)

Truning off -Wunused-member-function is applicable for me, but I can't find a way to do that only for clangd. Clangd doesn't have a command line option like --extra-arg in clang-tidy. I still want to find out unused member function when compiling.

Can --extra-arg be added to clangd? Or can clangd (or the underlying clang library) not report this warning by default when not parsing function bodies in headers? Missing this warning is better than reporting it spuriously.

I think clangd/libclang-cpp can suppress -Wunused-member-function when the class is passed to an uninstanced template.

Can --extra-arg be added to clangd

We're looking at adding configuration that will let you do the equivalent (probably by adding args to a file like ~/.config/clangd). It's still in the design phase though.

Or can clangd (or the underlying clang library) not report this warning by default when not parsing function bodies in headers?

Well, it doesn't report them by default - only when -Wunused or similar is in compile_commands.json. I understand this is generated by your build system and you want the flag enabled there. You could use a tool to filter these arguments out of compile_commands. (Until clangd has options to help you)

Missing this warning is better than reporting it spuriously.

This is really a question of opinion and tradeoffs , I think - losing the warning for non-templated code would be a shame.

I think clangd/libclang-cpp can suppress -Wunused-member-function when the class is passed to an uninstanced template.

This actually seems pretty hard to do accurately, to me... patches welcome though.

So a chromium guy hit a similar issue.
Reproduce case (with "clangd.fallbackFlags": ["-Wall",  "-Werror"]):
// t.h
namespace {
void foo() {} // intend to not inline
}

void ff() {
    foo();
}

// t.cc
#include "t.h"

Open t.cc, it will prompt up In included file: unused function 'foo' diagnostic on the #include line.
We skip function bodies when building the preamble, so the foo() is not recognized as used. It seems that all unused diagnostics from the preamble region are unreliable, maybe we can drop them instead of annoying people?

@hokein Rather than preamble region you're talking about in included files, right?
We already only promote errors from included headers into the main file[1], so -Werror is the trigger here. I think we should just not respect -Werror for this purpose (i.e. only show includes from other files that were orginially errors). WDYT?
[1] https://github.com/llvm/llvm-project/blob/4b53495c4ba2ba410f6383f9c57593e838ec0d57/clang-tools-extra/clangd/Diagnostics.cpp#L127

Rather than preamble region you're talking about in included files, right?

Yeah, exactly.

We already only promote errors from included headers into the main file[1], so -Werror is the trigger here. I think we should just not respect -Werror for this purpose (i.e. only show includes from other files that were orginially errors). WDYT?

this sounds good to me, let me prepare a patch.

This can now be done with config:
CompileFlags:
  Add: -Wno-unused-member-function

This can now be done with config:
CompileFlags:
  Add: -Wno-unused-member-function


feat(write_labels): store all sparse X  and raw.X in canonical form

When writing labels if the sparse matrix support canonical form, then it is converted to canonical before writing the label h5ad file out. A test has been added to verify the out of write labels is canonical.
This PR is a result of the fix in https://github.com/chanzuckerberg/single-cell-curation/pull/598 failing to resolve the seurat value cause by non-canonical matrix. https://github.com/chanzuckerberg/single-cell/issues/519 the original bug.
This was test in rdev.  Here are the steps:

create an rdev environment off of portal main.
Replace the cellxgene-schema requirement in requirement-processing.txt with cellxgene-schema@git+https://github.com/chanzuckerberg/single-cell-curation.git@8c57ca36fe648842fd1128af84a58fcce1390d73#subdirectory=cellxgene_schema_cli
Download https://corpora-data-prod.s3.us-west-2.amazonaws.com/b38bf00a-d413-4823-8766-fc411c61d35a/raw.h5ad
migrate the dataset to 3.1.0 $ cellxgene-schema migrate raw.h5ad migrated.h5ad
create a collection and submit the migrated.h5ad.
After around 2 hours the collection will be updated with the new dataset.

For the unit-tests a COO_matrix is used. It allows creating noncanocal matrixes.

Update the rdev with the changes and ran submissions. The run is still clean https://memory-frontend.rdev.single-cell.czi.technology/collections/e5f6eb8f-422a-4e85-b249-e17fb71dd5dc


[Doc Improvement][Dev comm Profile photo][2713736]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/get-teams-context.md
92
5
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 914f2ef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/get-teams-context.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/how-to/get-teams-context.md
92
5
link
:white_check_mark:

msteams-platform/concepts/build-and-test/apps-localization.md
90
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit f52c636:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/get-teams-context.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/apps-localization.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Formatting error

After a change in microdown where lines were joined into a single line rather than keeping original crs, the hierarchy listing is broken:

Personally I do not think the hierarchy should be shown there in the first place as it can be shown in the browser already, but that is an other issue.

I believe the best solution here is to let Beautiful comments define its own textStyler that keeps linebreaks, and perhaps also uses smaller font for headings.

Fixed by suggestion above some time a while back


Update to 0.22.1 fails in CI

I opened a PR for the latest and greatest Zeebe Node library 0.22.1, but the CI fails with an error:
node_modules/@nestjs/core/nest-application.d.ts(44,5): error TS2416: Property 'enableCors' in type 'NestApplication' is not assignable to the same property in base type 'INestApplication'.
  Type '(options?: CorsOptions) => void' is not assignable to type '(options?: CorsOptions) => this'.
    Type 'void' is not assignable to type 'this'.

Needed to update the nest packages - fixed and merged.


FR: Nextcloud: add more configurable options

Issue description
Nextcloud service config is too restrictive and doesn't allow migrating from existing manually set-up nextcloud instance.

Nextcloud service doesn't allow usage with different servers, such as Caddy.
User and Group used for nextcloud data are hardcoded, so a user can't integrate existing server setup.
Data directory path is hardcoded and fixed inside nextcloud home directory.

Ping @Ma27 @globin

There are indeed several cases including migration from a manually set up instance that are rather hard to cover. Unfortunately I lack time to start (another) big task right now, but if you want to file a patch (for one or all bullet points), feel free to ping me :)

This issue contains at least three different things, some only useful when initially migrating over.
I propose filing individual issues, so they're actionable - but as @Ma27 mentions, he probably won't be able to work on these, so contributions welcome :-)

I don't see what's not actionable about the FR. This is a regular tracking issue, describing a set of real problems stemming from the poor usability of Nextcloud service. Individual PR/issues may be linked here and acted upon. I don't mind spamming Issues with separate issues instead though, if you'd rather.
This inherently has nothing to do with migrating, by the way, just inflexibility with integrating into existing set-up.

The issue regarding being able to use it with different servers in front is probably best covered in https://github.com/NixOS/nixpkgs/issues/22067, as it's not nextcloud-specific at all.
The part of "initially migrating over" was mostly about the configurable system user and data directory location:
I don't think there's that many valid usecases of explicitly needing to configure this differently when creating a new instance - and existing installations can just be chowned and data be moved/mounted to the default location - which is probably simpler than increasing complexity in the module (and maybe a reason why no-one else did implement this so far).
If you have a different opinion, it's probably best to create a new issue/PR specific to that.

I generally agree, and thanks for the link. Although, data directory being hardcoded is not how most of the services in NixOS are implemented, so I see it as a genuine issue, so I'll probably create a PR/issue for this.


Show tracks on hover

Hi, thank you for this!
Is there a way to show the tracks when you hover over the content?
I've tried a mouse-enter / mouse-leave listener to change the alwaysShowTracks, but unfortunately the Scrollbar doesn't do anything with the value

This does the trick:
(.SCSS)
.element {
 .scrollbar-track.show,
  .scrollbar-track:hover {
    opacity: 0;
    transition: 0.3s ease-in-out;
    background-color: ${({ theme }) => theme.main};

    .scrollbar-thumb {
      background-color: ${({ theme }) => theme.textColor};
    }
  }

  &:hover {
    .scrollbar-track.show,
    .scrollbar-track:hover {
      opacity: 1;
    }
  }
}