Sync: GIST NOT SAVED when uploading settings to gist

🐛 Describe the bug
I'm trying to set up my sync, used to work find but today I noticed I'm getting the following error when trying to upload settings:

🌴 Visual Studio Code Version : [ 1.38 ]
🌴 Code Settings Sync Version : [3.4.2 ]
🌴 Operating System : [ Windows 10 ]
🌴 Occurs On: [Upload]
🌴 Proxy Enabled: [ No ]
🌴 Gist Id: [0ff283486d00810e5af0740e91352207]

Hello,
I'm having the same issue:

Version: 1.38.0 (user setup)
Commit: 3db7e09f3b61f915d03bbfa58e258d6eee843f35
Date: 2019-09-03T21:49:13.459Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

Has anyone experienced the same issue?

I have uninstalled and reinstalled the extension, even creating a new GIST, but to no avail.

It should be fixed on the latest version of Settings Sync v3.4.3. Let me know if it persist. I will reopen this issue.

Hey!
I've installed the updated version but unfortunately, the error persists:

Should I completely remove the extension and try again?
Is there any "special" procedure I should follow?
Best regards.

Try removing the extension and restarting the code and installing extension. Then reset the extension settings and try to upload on new gist.
@vcorreia

Try removing the extension and restarting the code and installing extension. Then reset the extension settings and try to upload on new gist.
@vcorreia

Followed your steps, but got the same error:

Okay, can you upload your Users folder in compressed form ( removing confidential things) so i will try to reproduce it later?
I will update the GitHub api too to the latest version as a part of next release of Settings Sync.

Which folder, exactly?
I'm using a corporate machine, due to group policies I don't have access to all folders.

I've also updated to latest version, and check it out. Same error as @vcorreia. I'm on a personal machine so I don't have corporate issues. I'm working from a windows machine and not sure which folder you want?

Hello everyone,
I've been caught up by work and have not had a chance to see if the issue had any updates.
@taigi100 , have you had any luck syncing your settings?

I'm using a corporate machine, due to group policies I don't have access to all folders.

@vcorreia and @taigi100
User folder contains your settings.json and other files. I like to reproduce this error on the files you have. So you need to share the folder in compressed form (you can remove the confidentials files)

@vcorreia nope, still not working
@shanalikhan mentioned of a User folder. With some googling I think he is referring to %AppData%/Code/User.
I have attached my settings.json and syncsettings below
User.zip

I have exact the same Problem, with a german error message.
Because I used the Profile Switcher Extension (aaronpowell.vscode-profile-switcher) my settings.json is about 966 Lines long. May be this could caused the problem?

@taigi100 I can see that u uses this extension too !
@shanalikhan can this be the problem? Is there a max size for a gist?

Yeah, after removing the extension everything works likes expected ! :-) !

Because I used the Profile Switcher Extension (aaronpowell.vscode-profile-switcher) my settings.json is about 966 Lines long.

What really is there in 966 lines of configurations?
I have to see how GitHub limit users in Gist in terms of length.

"This gist exceeds the recommended number of files (~10). To access all files, please clone this gist. To share more, create a repository."

Guys,
After removing the extension Profile Switcher Extension, I was also able to sync properly!

FYI - Removal of Profile Switcher seemed to resolve the problem for me.

@vcorreia @mcollier
In my case deleting profile switcher isn't really an option, looked a long time for it. The combination of sync and profile switcher was amazing tho.

Can you guys open issue on Profile Switcher and let author know about it, linking this issue.
I have tried on Ubuntu, Windows and its working perfectly. I will try to spend some time on it later on.

@shanalikhan I'm going to try some more.  Likely re-enabling Profile Switcher and observe results. The challenge I'm having is understanding why_ Settings Sync is unable to save.  Is there a way to get more detailed debugging information from Settings Sync that may show what failed?  For example, is there a way to see the error coming from GitHub, as @Zed-M suggested earlier?

Can you guys open issue on Profile Switcher and let author know about it, linking this issue.
I have tried on Ubuntu, Windows and its working perfectly. I will try to spend some time on it later on.

Thank you for your investment on this issue.
I have tried all combinations, including a fresh vscode installation, with only sync extension installed and even that has not worked :|

I will try to spend some time on it later on.
@mcollier and @taigi100
Can you guys provide me concrete steps to reproduce it (including installing profile switcher). I will get the settings from https://github.com/shanalikhan/code-settings-sync/issues/1039#issuecomment-537976629

I have tried all combinations, including a fresh vscode installation, with only sync extension installed and even that has not worked :|

@vcorreia
Are you getting this same exception on event fresh install and Settings Sync configured. Can you post your console logs?

@shanalikhan I'm not sure I would be able to provide some exact steps. It's one of those bugs that seemed to work find and then suddenly stopped working. I'll try to check it out more in depth after I'm done with some current projects I'm working on.

👋  Howdy all, author of Profile Switcher here.
Let me know what I can do to help debug/resolve this. If it seems there's a problem that the max size of a gist is being hit (is there a max size, I'm unsure) I'll have to think more creatively around how the extensions are tracked for profiles. (I'm aware that the extension tracking support I added caused the settings.json file to explode in size.)

@shanalikhan I don't have profile-switcher and I still get the error.

"This gist exceeds the recommended number of files (~10). To access all files, please clone this gist. To share more, create a repository."

If I remove the gist and upload again it creates a new one, but on the second upload it fails again.

@shanalikhan I don't have profile-switcher and I still get the error.

"This gist exceeds the recommended number of files (~10). To access all files, please clone this gist. To share more, create a repository."

If I remove the gist and upload again it creates a new one, but on the second upload it fails again.

Same here. I've been using code-settings this way, by deleting the first gist and uploading again...

I had the same issue, to solve this problem I add "aaronpowell.vscode-profile-switcher" to list of folders ignored during upload to gist. Settings can be found in %AppData%/Code/syncLocalSettings.json.

I had the same issue, but with the webhint extension. This extension adds the folder webhint.vscode-webhint/node_modules/ to the User globalStorage folder, which seems like a mistake. Maybe profile-switcher is doing the same thing?
The node_modules folder contains dozens (hundreds?) of JSON files, which all get uploaded causing the gist to get locked by GitHub.
Maybe a universal fix would be adding node_modules to the default list of ignored folders.

Yeah, with Profile Switcher, both settings.json and globalStorage can become massive.

:(

Add node_modules to the ignoreUploadFolders, now all work again.
code ~/.config/Code/User/syncLocalSettings.json
{
    "ignoreUploadFolders": [
        "node_modules",
        "workspaceStorage"
    ],

it maybe be cause by this (https://github.com/shanalikhan/code-settings-sync/issues/1039#issuecomment-549186953),
I find %AppData%/Code/History is massive, and then add "History" into syncLocalSettings.json
"ignoreUploadFolders": [
"History",
"workspaceStorage"
],
, after add it, settings sync work again

"History",
    "workspaceStorage"

Esto me funciono correctmente al dia de hoy

it maybe be cause by this (#1039 (comment)), I find %AppData%/Code/History is massive, and then add "History" into syncLocalSettings.json
"ignoreUploadFolders": [
    "History",
    "workspaceStorage"
],

after add it, settings sync work again

it maybe be cause by this (#1039 (comment)), I find %AppData%/Code/History is massive, and then add "History" into syncLocalSettings.json
"ignoreUploadFolders": [
    "History",
    "workspaceStorage"
],

after add it, settings sync work again

Thank you, guys. Super helpful!

I add node_modules and History to ignored Folders, and it worked.


Kemono's extension doesn't show all the content of the web(s)

Source information
Kemono 1.4.10
Source language
All
Steps to reproduce
Open entrie in kemono (artist's profile)
Expected behavior
Should show all its "chapters" (only those that have images, ofc)
Actual behavior
It skips some
Mihon/Tachiyomi version
0.16.3
Android version
Android 12
Other details
I'm having this experience right now with hxd9585's profile in Kemono, for example, the "chapter" 12月 (1) is on the website but it doesn't come up in the extension, and has images, ofc
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

check extension settings for number of chapters loaded.

check extension settings for number of chapters loaded.

It's not that!!
I already checked it, some "chapters" simply don't appear even with the settings in maximum posts
Can u open this or sum idk

For clarity, which 12月1 are you talking about? Give the date(year) of the upload, there are multiple 12月1 as it only indicates that it's the first upload in the month of December.

There may be several on the web with that same name, but the point is that the extension does not show them all
The one I'm talking bout Is the actually very first one in that artist's profile, 12月 (1), with the "( )"


Modal dialogs and consistency

Gitea version (or commit ref): 1.4.0rc1
Can you reproduce the bug at https://try.gitea.io: Yes

Description
There are multiple kinds of modal dialogs in Gitea with completely different semantics. They share strings in the translation file, blocking any attempt to have a decent user experience.
One kind is the 'delete' dialogs with a trashcan that offer 'No' and 'Yes' choices, see #3589. These can't be dismissed (cancelled) by clicking in an empty region.
Another kind is the 'Label Modification' [sic] dialog which acts completely different for some reason. This 'No' choice uses the 'No' string of the 'delete' dialogs, so I can't turn this into 'Cancel'. Good news is this one can be dismissed by clicking outside of it. But out of the blue this one sports a 'Modify √' button with a check-mark for fun.
I keep running into all kinds of user interface inconsistencies; I can't document all of them in the spare time that I have. Is there anyone even paying attention to Gitea as a whole? It feels like it's just different parts cobbled together. Sorry for the frustration.
Just dumping some other issues (I've got tons more) for future reference:

there is no way to tell you're filtering a repository issue list other than clicking all drop-down boxes
the 'new release' button on the releases page has a smaller size/font than other pages
button order in 'create release' and 'edit release' is different
clicking a milestone name opens its list of issues, clicking an issue name does nothing
on the installation page, checkboxes have flying tooltips, these are nowhere to be found elsewhere
the sub header text on the 'create milestone' and 'edit milestone' is different
same for the sub header on 'create release' and 'edit release' (I'm fixing both in my translation)
open milestones are colored green, closed milestones are colored red (see #3590 too)
the 'Initial commit' string can't be changed from the translation file
the 'ZIP' and 'TAR.GZ' strings (releases page) can't be changed from the translation file

Screenshots

The 'Add Time' dialog decides to spice things up by randomly changing button order.

Is there anyone even paying attention to Gitea as a whole? It feels like it's just different parts cobbled together. Sorry for the frustration.

Yeah, you're not wrong. Both from a UX and a code point of view there should probably be more attention to the project as a whole, but in an open source project such as this one, where a lot of people come and go (myself included), it can be quite hard to have 'core developers' who keep track of everything and create cohesion in the project.

@thehowl Thanks for the reply.
The entire thing is frustrating because Gitea is pretty amazing. It's an awesome standalone (self-hosted) development tool. But the UI and translation issues make it a diamond in the rough. Appreciated by those seeing its potential.
With a bit of polish and marketing, I'm pretty sure it could be one of the most popular open source development tools. It's easy. It's functional. It's great. Except for the paint job.

About that: I've actually worked on a blogpost for the next version (1.4) which is more appealing than the previous posts. I'm sure another pair of eyes to check on it wouldn't hurt, if you have the time :) https://github.com/go-gitea/blog/pull/54

@thehowl Took a look, sent a PR. Great work. I found the original style a bit over-excited, so I tried to reword it using the voice of my recent translation work.

The repository settings 'Danger Zone' is again different, but looks very good for invasive operations (old wording shown here).

It has been improved by #24289 , no "black" dialog any more.


Error with jaxlib

Hello,
I run the command: panpipes ingest config and dot this error:
RuntimeError: This version of jaxlib was built using AVX instructions, which your CPU and/or operating system do not support. You may be able work around this issue by building jaxlib from source.
Thank you,

"conda install jax" solves the problem :)
Thank you

thanks for using panpipes!


Pass on context provided by node-sass to proxied custom importer

node-sass passes context to custom importers. #267 broke this chain and this restores it. Discovered in response to this.

Okay, I'll need to see why tests are failing but it's late. I'll take a look tomorrow.

Oops, duplicate of #277. Sorry for the noise.


Deprecation: Transformers will no longer support past_key_values to be tuples

As reported by @ArthurZucker:

Quick question, I am seeing this in peft: https://github.com/huggingface/peft/blob/f2b6d13f1dbc971c7653aa65e82822ea2d84bb38/src/peft/peft_model.py#L1665 where there is a reliance on get_seq_length() which we are deprecating + we will no longer convert the cache to tuple object automatically in 2 releases

This will presumably affect all prompt learning methods and thus needs to be fixed soon.
For Llama, I identified the following tests, which would result in past_key_values being tuples and can serve as a starting point to work on this issue:
tests/test_decoder_models.py::PeftDecoderModelTester::test_inference_safetensors_70_test_trl_internal_testing_tiny_random_LlamaForCausalLM_prefix_tuning
tests/test_decoder_models.py::PeftDecoderModelTester::test_passing_input_embeds_works_70_test_trl_internal_testing_tiny_random_LlamaForCausalLM_prefix_tuning
tests/test_decoder_models.py::PeftDecoderModelTester::test_training_prompt_learning_tasks_72_test_trl_internal_testing_tiny_random_LlamaForCausalLM_prefix_tuning

(note that there are more tests that would fail, this is just a selection)
I haven't really worked on the prompt learning methods in PEFT and know little about the inner workings of transformers cache, so any support would be welcome.

@BenjaminBossan @ArthurZucker  Can you provide more information regarding deprecation of get_seq_length(). I have some idea about prompt learning methods and transformer's KV Cache.

Hi @piyush-llm 👋
Alongside a Cache, the prepare_inputs_for_generation method also returns cache_positions on models that have received the update. This new tensor contains the indexes of the cache that will be updated, so its last value can be used as the sequence length :)

Thanks for the details. Also check out #869 for discussion and code snippets.

As reported by @ArthurZucker:

Quick question, I am seeing this in peft: https://github.com/huggingface/peft/blob/f2b6d13f1dbc971c7653aa65e82822ea2d84bb38/src/peft/peft_model.py#L1665
where there is a reliance on get_seq_length() which we are deprecating + we will no longer convert the cache to tuple object automatically in 2 releases

This will presumably affect all prompt learning methods and thus needs to be fixed soon.
For Llama, I identified the following tests, which would result in past_key_values being tuples and can serve as a starting point to work on this issue:
tests/test_decoder_models.py::PeftDecoderModelTester::test_inference_safetensors_70_test_trl_internal_testing_tiny_random_LlamaForCausalLM_prefix_tuning
tests/test_decoder_models.py::PeftDecoderModelTester::test_passing_input_embeds_works_70_test_trl_internal_testing_tiny_random_LlamaForCausalLM_prefix_tuning
tests/test_decoder_models.py::PeftDecoderModelTester::test_training_prompt_learning_tasks_72_test_trl_internal_testing_tiny_random_LlamaForCausalLM_prefix_tuning

(note that there are more tests that would fail, this is just a selection)
I haven't really worked on the prompt learning methods in PEFT and know little about the inner workings of transformers cache, so any support would be welcome.

is it ok to just convert past_key_values from a tuple to a list ?

is it ok to just convert past_key_values from a tuple to a list ?

Unfortunately not, it would be expected to be a Cache object.

An update from the internal discussion: So Cache shouldn't be used at all during training. At the same time, the role of past_key_values will be migrated to mean "cache". This probably means that going forward, we cannot use past_key_values at all for the purpose of injecting "virtual tokens" (or rather, embeddings) as we do right now for prompt learning.
I had hoped that this can be avoid, but it smells like this whole approach needs a rewrite. One idea would be to calculate the virtual embeddings as we do right now (PeftModel.get_prompt) but instead of handing them off to past_key_values, they need to be injected via a pre-forward hook (or, if that's not feasible, we need to monkey patch forward :see_no_evil:).
For generating, we'll probably still need a separate code path, since we do want to use caching for generation.

@JerryLife Could you please try of this suggestion fixes it for you:
https://github.com/huggingface/peft/issues/869#issuecomment-2263322623
Please let me know if it works or not, the more data I have, the better I can plan the fix.

Thank you for your prompt help! It works on my side. Here are more details.
Modules: peft==0.13, transformers==4.44.2
Model: MistralForCasualLM
My workaround

Define a custom get_prompt function

def custom_get_prompt(self, batch_size: int, task_ids: Optional[torch.Tensor] = None) -> torch.Tensor:
    """
    Returns the virtual prompts to use for Peft. Only applicable when using a prompt learning method.
    """
    peft_config = self.active_peft_config
    prompt_encoder = self.prompt_encoder[self.active_adapter]
    prompt_tokens = (
        self.prompt_tokens[self.active_adapter]
        .unsqueeze(0)
        .expand(batch_size, -1)
        .to(prompt_encoder.embedding.weight.device)
    )
    if peft_config.peft_type == PeftType.PREFIX_TUNING:
        prompt_tokens = prompt_tokens[:, : peft_config.num_virtual_tokens]
        if peft_config.inference_mode:
            past_key_values = prompt_encoder.embedding.weight.repeat(batch_size, 1, 1)
        else:
            past_key_values = prompt_encoder(prompt_tokens)
        if self.base_model_torch_dtype is not None:
            past_key_values = past_key_values.to(self.base_model_torch_dtype)
        past_key_values = past_key_values.view(
            batch_size,
            peft_config.num_virtual_tokens,
            peft_config.num_layers * 2,
            peft_config.num_attention_heads,
            peft_config.token_dim // peft_config.num_attention_heads,
        )
        if peft_config.num_transformer_submodules == 2:
            past_key_values = torch.cat([past_key_values, past_key_values], dim=2)
        past_key_values = past_key_values.permute([2, 0, 3, 1, 4]).split(
            peft_config.num_transformer_submodules * 2
        )
        if TRANSFORMERS_MODELS_TO_PREFIX_TUNING_POSTPROCESS_MAPPING.get(self.config.model_type, None) is not None:
            post_process_fn = TRANSFORMERS_MODELS_TO_PREFIX_TUNING_POSTPROCESS_MAPPING[self.config.model_type]
            past_key_values = post_process_fn(past_key_values)

        ############################## Workaround for PEFT 0.13 ##############################
        past_key_values = DynamicCache.from_legacy_cache(past_key_values)
        ######################################################################################

        return past_key_values
    else:
        if peft_config.peft_type == PeftType.MULTITASK_PROMPT_TUNING:
            prompts = prompt_encoder(prompt_tokens, task_ids)
        else:
            if peft_config.inference_mode:
                prompts = prompt_encoder.embedding.weight.repeat(batch_size, 1, 1)
            else:
                prompts = prompt_encoder(prompt_tokens)
        return prompts

Monkey patch the function on PeftModel

from peft import PeftModel
patch = gorilla.Patch(peft.PeftModel, 'get_prompt', custom_get_prompt, settings=gorilla.Settings(allow_hit=True))
gorilla.apply(patch)

Then, it magically works on my side. Thank you again for your asssitance!

Thanks a lot @JerryLife this really helps us move forward.

Modules: peft==0.13

If you could give me access to PEFT version 0.13, that would make my life a lot easier ;-)

@BenjaminBossan I am sorry for the typo. I have corrected it as peft==0.12.0 and I am looking for 0.13 in the near future ;). Thank you for your efforts!


mongodb: do not add blank parameter in ipv4

A very recent commit [1] broke IPv4 usage [2].
When running ipv4, the provider will execute:
/bin/mongo admin --quiet "" --host <IP_ADDRESS>:27017 --eval
"printjson(rs.conf())"
mongo CLI does not like empty parameters like "" so we need to pass a parameter (--ipv6)
only when we actually need it.
This patch adds more conditionals to properly add the parameter only
when needed, and bring back ipv4 support.
[1] a77d1a191419a3f1f468707aefa69abd689c3e4b
[2] https://bugs.launchpad.net/tripleo/+bug/1536083

Maybe make that whole block a function:

     if ipv6_is_enabled

       out = mongo([db, '--quiet', '--ipv6', '--host', host, '--eval', cmd])

     else

       out = mongo([db, '--quiet', '--host', host, '--eval', cmd])

     end

It would be called with (host, cmd) as parameters.  Than would factorize a little.

I'm testing the code right now, please review but don't merge it yet.


Suggested tweaks to tutorial in docs

Remove preceding $ character in bash code blocks for easier copy/paste via mdbook feature.
Add code block hints
Consolidate npm deps installation steps, combining into single command
Fix typo
Add missing typescript imports
update document ref

Merged, thank you!


Merge changes from my fork back to main Repo

What's inside (inspired by rexm/Handlebars.Net/issues/294):

fixes to multiple Github issues:

BlockParams support (rexm/Handlebars.Net/issues/301)
Support returning objects from helpers (rexm/Handlebars.Net/issues/264)
Lookup helper (rexm/Handlebars.Net/issues/268)
JObject performance problems (rexm/issues/308)
Support more advanced helper construction (rexm/Handlebars.Net/issues/151)
Support helper resolvers (rexm/Handlebars.Net/issues/336)
Other issues

global refactoring (without breaking changes to the public API)

use zjklee/ExpressionShortcuts to improve maintainability of Expression Trees

improvements to extensibility
performance improvements (depends on template complexity):
  - 2-10x compilation time improvement
  - 2-10x execution time improvement
  - up to 20x less memory consumption during compilation and execution

Due to the nature and amount of changes I'm not able to extract them to a separate PRs one for each issue at this point.
I'd continue to support my fork (and back-port changes here) until the PR is merged.

@rexm any chance you'll have time to take a look?


Wrap insertion target in a fragment if it does not support children

Fixes #3499
Problem:
Reparenting directly into a conditional clause with an image inserts the element into the image.
Fix:
This is due to a more broad issue, caused by reparenting into elements which don't support children. This PR fixes it by creating a fragment for the insertion target and the inserted element when the parent doesNotSupportChildren.
Before:

After:

Does this mean that I can now reparent into an image anywhere, and it'll create a fragment? If so, that's definitely not the desired behaviour; we should continue to prevent a reparent (as we already do in a number of situations)


pipenv shell fails to find /usr/local/bin/bash in pexpect

Issue description
I can't run pipenv shell. This is different to the other issues related to this issue, since my SHELL variable is correctly configured. It seems to be something pexpect is doing wrong.
Expected result
Successfully running pipenv shell
Actual result
$ pipenv --version
pipenv, version 2018.7.1
$ echo $SHELL
/usr/local/bin/bash
$ stat $SHELL
16777220<PHONE_NUMBER> lrwxr-xr-x 1 keegan admin 0 30 "Jun 15 08:03:49 2018" "Jun 15 08:03:49 2018" "Jun 15 08:03:49 2018" "Jun 15 08:03:49 2018" 4194304 0 0 /usr/local/bin/bash
$ pipenv shell --verbose
Launching subshell in virtual environment…
Traceback (most recent call last):
  File "/usr/local/bin/pipenv", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.7/site-packages/pipenv/vendor/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/pipenv/cli.py", line 664, in shell
    three=three, python=python, fancy=fancy, shell_args=shell_args, pypi_mirror=pypi_mirror
  File "/usr/local/lib/python3.7/site-packages/pipenv/core.py", line 2163, in do_shell
    shell.fork_compat(*fork_args)
  File "/usr/local/lib/python3.7/site-packages/pipenv/shells.py", line 107, in fork_compat
    self.cmd, ['-i'], dimensions=(dims.lines, dims.columns),
  File "/usr/local/lib/python3.7/site-packages/pipenv/vendor/pexpect/pty_spawn.py", line 204, in __init__
    self._spawn(command, args, preexec_fn, dimensions)
  File "/usr/local/lib/python3.7/site-packages/pipenv/vendor/pexpect/pty_spawn.py", line 276, in _spawn
    'executable: %s.' % self.command)
pipenv.vendor.pexpect.exceptions.ExceptionPexpect: The command was not found or was not executable: -/usr/local/bin/bash.

Note: /usr/local/bin/bash is a symlink to /usr/local/Cellar/bash/4.4.23/bin/bash (managed by brew). Setting SHELL to that value or /bin/bash both fail.
Steps to replicate
Provide the steps to replicate (which usually at least includes the commands and the Pipfile).

$ pipenv --support
Pipenv version: '2018.7.1'
Pipenv location: '/usr/local/lib/python3.7/site-packages/pipenv'
Python location: '/usr/local/opt/python/bin/python3.7'
Other Python installations in PATH:

2.7: /usr/local/bin/python2.7

2.7: /usr/local/bin/python2.7

2.7: /usr/bin/python2.7

3.7: /usr/local/bin/python3.7m

3.7: /usr/local/bin/python3.7

2.7.15: /usr/local/bin/python

2.7.10: /usr/bin/python

2.7.15: /usr/local/bin/python2

3.7.0: /usr/local/bin/python3

PEP 508 Information:
{'implementation_name': 'cpython',
 'implementation_version': '3.7.0',
 'os_name': 'posix',
 'platform_machine': 'x86_64',
 'platform_python_implementation': 'CPython',
 'platform_release': '17.6.0',
 'platform_system': 'Darwin',
 'platform_version': 'Darwin Kernel Version 17.6.0: Tue May  8 15:22:16 PDT '
                     '2018; root:xnu-4570.61.1~1/RELEASE_X86_64',
 'python_full_version': '3.7.0',
 'python_version': '3.7',
 'sys_platform': 'darwin'}

System environment variables:

STY
SRCPATH
MAILCHECK
LANG
XPC_FLAGS
HISTCONTROL
OLDPWD
TERM_SESSION_ID
EDITOR
COLORTERM
PERL_MB_OPT
__CF_USER_TEXT_ENCODING
LOCKPRG
ITERM_SESSION_ID
SSH_AUTH_SOCK
USER
GOPATH
PWD
HOME
WINDOW
TERM_PROGRAM
TERM_PROGRAM_VERSION
Apple_PubSub_Socket_Render
ITERM_PROFILE
PERL_MM_OPT
TMPDIR
PERL_LOCAL_LIB_ROOT
XPC_SERVICE_NAME
SHELL
TERM
PERL5LIB
COLORFGBG
SHLVL
LOGNAME
GOBIN
PATH
HISTSIZE
HISTFILESIZE
TERMCAP
_
PYTHONDONTWRITEBYTECODE
PIP_PYTHON_PATH

Pipenv–specific environment variables:
Debug–specific environment variables:

PATH: /Users/keegan/.cargo/bin:/usr/local/opt/go/libexec/bin:/Users/keegan/bin:/Users/keegan/google-cloud-sdk/bin:/Users/keegan/.yarn/bin:/Users/keegan/perl5/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/keegan/.cargo/bin:/usr/local/opt/go/libexec/bin:/Users/keegan/bin:/Users/keegan/google-cloud-sdk/bin:/Users/keegan/.yarn/bin:/Users/keegan/perl5/bin:/Users/keegan/go/bin:/Users/keegan/go/bin
SHELL: /usr/local/bin/bash
EDITOR: vim
LANG: en_GB.UTF-8
PWD: /Users/keegan/go/src/github.com/weaveworks/kubediff

Contents of Pipfile ('/Users/keegan/go/src/github.com/weaveworks/kubediff/Pipfile'):
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
attrs = "*"
tabulate = "*"
PyYAML = "*"

[dev-packages]

[requires]
python_version = "3.7"

Hmmm interesting. @uranusjr does this not follow symlinks currently?

It shouldn’t need to. I use Hombrew Bash myself on Mac as well, and it works correctly. Given /bin/bash also fails I’m inclided to think this is caused by something else…
@keegancsmith Did pipenv shell frun correctly before this version?

I only occasionally do python development these days, so the last time I would of used pipenv shell would of been a few months ago. I believe I used it back then, but I'm not 100% certain. I'm happy to try another version if you provide instructions. I have tried pipenv installed from both pip and brew.

It’s fine. We switched to a new shell implementation recently, and if it worked previously, it is probably related to the new implementation.
I will try to debug it when I have access to my main Mac (which has the same Homebrew setup as yours).

@keegancsmith @Whisprin Can you run this with the Python you install Pipenv for me?
(For Homebrew, this would be /usr/local/Cellar/pipenv/2018.7.1/libexec/bin/python by default.)
from pipenv.shells import _detect_emulator, detect_info
print(_detect_emulator())
print(detect_info())

And if detect_info returns a tuple, could you check if the second command is valid?
Example (from my Mac):
$ python
>>> from pipenv.shells import _detect_emulator, detect_info
>>> print(_detect_emulator())

>>> print(detect_info())
('bash', '/usr/local/bin/bash')
>>>

$ /usr/local/bin/bash -c help
GNU bash, version 4.4.23(1)-release (x86_64-apple-darwin17.5.0)
These shell commands are defined internally.  Type `help' to see this list.
Type `help name' to find out more about the function `name'.
Use `info bash' to find out more about the shell in general.
Use `man -k' or `info' to find out more about commands not in this list.

[tons of output… OK this command works.]

I see it is detecting a stray - prefix for the shell abs path.
$ /usr/local/Cellar/pipenv/2018.7.1/libexec/bin/python
Python 3.7.0 (default, Jun 29 2018, 20:13:13)
[Clang 9.1.0 (clang-9<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from pipenv.shells import _detect_emulator, detect_info
>>> print(_detect_emulator())

>>> print(detect_info())
('bash', '-/usr/local/bin/bash')
>>>
$ /usr/local/bin/bash -c help | head
GNU bash, version 4.4.23(1)-release (x86_64-apple-darwin17.5.0)
These shell commands are defined internally.  Type `help' to see this list.
Type `help name' to find out more about the function `name'.
Use `info bash' to find out more about the shell in general.
Use `man -k' or `info' to find out more about commands not in this list.

A star (*) next to a name means that the command is disabled.

 job_spec [&]                            history [-c] [-d offset] [n] or hist>
 (( expression ))                        if COMMANDS; then COMMANDS; [ elif C>

So it seems shellingham parses the output of a ps command. Here is mine:
$ ps -ww -o pid= -o ppid= -o args=
 1480  1477 /Applications/iTerm.app/Contents/MacOS/iTerm2 --server login -fp keegan
 1482  1481 -bash
 1556  1482 screen
 1558  1557 -/usr/local/bin/bash
 1706  1558 /Applications/Emacs.app/Contents/MacOS/Emacs-x86_64-10_10 -nw
77061  1706 /usr/local/bin/aspell -a -m -B --encoding=utf-8
 1562  1557 -/usr/local/bin/bash
87033  1557 -/usr/local/bin/bash
84732  1557 -/usr/local/bin/bash
89065  1557 -/usr/local/bin/bash
80216  1557 -/usr/local/bin/bash

note I use GNU screen, if that makes a difference.
I can see in the vendored sourcecode if it finds a shell in a known list of shells, it doesn't strip - from the process path. However, it does in other cases. So you just need to handle that. I see the upstream has changed quite a bit in master, so maybe this problem is no longer present in the latest version of shellingham.

Ah, I see the problem now. I was handling the shell path incorrectly if you chsh the login shell to point to an absolute path. I will use this information to fix it. Thanks so much for the help!

Will there be a new release containing the bug fix?

Is this not fixed yet in the latest on PyPI?  Pretty egregious bug for a high-profile project:
⏵ pipenv --version
    pipenv, version 2018.10.13
⏵ pipenv shell
...
pipenv.vendor.pexpect.exceptions.ExceptionPexpect: The command was not found or was not executable: fish.

    ⏵ python3
    >>> from pipenv.shells import _detect_emulator, detect_info
    >>> detect_info()
    ('fish', 'fish')
    ^D

    ⏵ env PIPENV_SHELL="$SHELL" pipenv shell
    Loading .env environment variables…
    Launching subshell in virtual environment…

    ⏵  source .../dev-TrP3E4Ut/bin/activate.fish
    (dev-TrP3E4Ut) ... ⏵

    # worked.

Your problem seems to be different from the OP. She’ll detection works correctly, but fish is not found. Is it in PATH? What is your $SHELL?

Hi, it is in the path, but the code appears to be looking for an absolute path:
⏵ echo $SHELL
/usr/bin/fish

Is fish in your PATH?

Yes it is in /usr/bin which is in the PATH.  pipenv shell used to work until I updated it yesterday.


[FINE] Add supported_consoles to VM

In an effort to consolidate all of the console logic for consistency across UIs and resolve some outstanding issues, it is being moved from the classic ui to the models themselves. This change utilizes the SupportsFeatureMixin to handle the logic for support methods and unsupported error reasons. Then based off of the change, a single attribute is added that will return all of the possible consoles with enablement, visibility, and appropriate message, which will be used when retrieving console information via the API.
Fine version of https://github.com/ManageIQ/manageiq/pull/16519
@miq-bot assign @simaishi
@miq-bot add_label blocker

@simaishi, LGTM :+1:


User specific view

Feature Description

Admin vs single/ multi-namespace users

Admins can view admin-privileged UI components and data including appwrappers in all namespaces such as:

AWs running across namespaces
AWs preempted across namespaces
AWs pending across namespaces
AWs priority across namespaces
AWs exceeding quotas

Normal users can only view appwrappers they submitted in specific namespaces and their metadata such as:

Status of AW
Priority number of AW
Priority class of AW
Quota of AW

Addressed: https://github.com/project-codeflare/mcad-dashboard/pull/47


Calculating query complexity

This pull request adds a helper function to calculate query complexity independently from query execution, see #16.
I was unsure if other tests should also use this functionality. Some don't just use the complexity value, but also errors found in ValidationContext after validating, so that would require some modification.

Added an example and fixed the test to take a value that actually gets calculated.


[AMBARI-24467] - Report Component Instance On Agent Registration

What changes were proposed in this pull request?
AMBARI-24416 attempted to fix a problem where component versions were no longer reported  on startup since the agents were switched to a push-style framework using STOMP endpoints for information.
It added a new endpoint and some logic to push version information to Ambari Server when agents were registered. This uses the old style version information, not the new style for mpacks.

The endpoint needs to accept version structured output
Agents must use the correct information about mpack name/version to obtain the right component versions

How was this patch tested?
Changes component versions and restarted agents so that correct versions were reported.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3599/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3600/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3604/
Test FAILed.
Test FAILured.


Unable to parse % traceroute -n;

Hello,
it seems that parsing of % traceroute -n; output isn't supported which is a pity :/
Traceback (most recent call last):
  File "traceroute.py", line 28, in <module>
    main()
  File "traceroute.py", line 24, in main
    traceroute = trparse.loads(out)
  File "venv/local/lib/python2.7/site-packages/trparse.py", line 135, in loads
    rtt = float(probes_data[i+2])
ValueError: invalid literal for float(): <IP_ADDRESS>

A-ha, problem is in traceroute's output:
 8  <IP_ADDRESS>  3.792 ms  2.809 ms  3.774 ms
 9  <IP_ADDRESS>  4.922 ms <IP_ADDRESS>  4.940 ms <IP_ADDRESS>  9.219 ms
10  <IP_ADDRESS>  8.034 ms <IP_ADDRESS>  7.223 ms  6.694 ms
11  <IP_ADDRESS>  7.846 ms  6.408 ms  6.928 ms

I know it's a dirty fix, but it works:
            elif RE_PROBE_NAME.match(probes_data[i]):
                # Matched a name, so next elements are IP and rtt
                name = probes_data[i]
                ip = probes_data[i+1].strip('()')
                j = i + 1
                while j < len(probes_data):
                    if len(probes_data[j].split('.')) > 2:
                        probes_data.pop(j)

                    j += 1

                rtt = float(probes_data[i+2])
                i += 3

Same problem here.
The library supposes that the output will be in format HOP NAME (IP) PROBES:
 1  <IP_ADDRESS> (<IP_ADDRESS>)  1.349 ms
 2  3-161-45-187.static.in-addr.vialink.com.br (<IP_ADDRESS>)  4.803 ms
 3  <IP_ADDRESS> (<IP_ADDRESS>)  6.985 ms
 4  49-170-45-187.static.in-addr.vialink.com.br (<IP_ADDRESS>)  6.404 ms
 5  65-161-45-187.static.in-addr.vialink.com.br (<IP_ADDRESS>)  9.264 ms

Only IP output (HOP IP PROBES) is not currently supported:
 1  <IP_ADDRESS>  3.860 ms
 2  <IP_ADDRESS>  2.863 ms
 3  <IP_ADDRESS>  9.664 ms
 4  <IP_ADDRESS>  8.769 ms
 5  <IP_ADDRESS>  10.631 ms

I don't know if this is a simple fix. I'll try to fix it and, if I can, propose a patch to the project owner.

I realized two things:

@lbenitez000 doesn't answer issues from this project since Dec 2, 2016. Is this project still maintained?
This project is very similar to https://github.com/ckreibich/tracerouteparser.py/

The last project doesn't exist in Pypi (to be installed with pip). This is way I'm using this one;
This project imports cStringIO, although its not used. The project from ckreibich also imports this module (and uses it). So, is this project based somehow in the ckreibich traceroute parser?

The new version, v0.3.0, still doesn't support traceroute -n outputs.

To make traceroute -n work please use the following
RE_PROBE_NAME_IP = re.compile(r'(\S+)\s+(?:\((\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})|([0-9a-fA-F:]+)\))*')


Add GitHub action to verify gradle-wrapper.jar

PR description
Checks that the gradle wrapper jar is from an official release since a maliciously modified jar added as part of a gradle upgrade would be a significant security risk but is hard to verify from the code diff.  This checks the jar comes from an Official Gradle release.
See https://github.com/gradle/wrapper-validation-action for more details.
Changelog

[x] I thought about the changelog and included a changelog update if required.

SPDX seems like a good idea. Added.


Build esp-idf-template with eclipse, Cann't find sdkconfig.h

@projectgus
There is two errors:
First, cfg = WIFI_INIT_CONFIG_DEFAULT();  //Syntax Error
Second, cannot find sdkconfig.h

Hi @AnalogLamb,
Thanks for reporting this issue. There is a problem opening esp-idf projects in Eclipse on Windows right now. #17 describes the issue as well - the build succeeds but Eclipse fails to find all the header directories parsing the build output, so it reports these kind of errors.
You can work around the issue for now by editing the "Include directories" for the project, as mentioned in the other issue. But we're working on a fix now.
I'm going to close this issue as a duplicate of #17, but please Subscribe to the other issue for updates to the bug.
Thanks,
Angus


[2.0.0] iit and ddescribe not defined

Personally I feel the main reason to use this over the existing jasmine node runner is for iit and ddescribe support. It now appears to be missing from 2.0 branch.
Failures:
  1) x encountered a declaration exception
    Message:
      ReferenceError: iit is not defined

It is sad, but check this https://github.com/mwise/jasmine-focus, it's a pseudo-plugin to jasmine and it works perfectly for me. :D

Thanks for the reply. I recently found out this is now baked into Jasmine Core 2.1 as fdescribe and fit. So I'm just using the node runner built into jasmine now. It's a bit more of a pain to setup the jasmine-reporters yourself but its also more flexible.


Spanner getkey moved, added key conveniences

Moved getkey to its own schema operations class. added conveniences for users to make keys

@balopat travis rolled back a deployment and it's all good now!


upstream connect error or disconnect/reset before headers. reset reason: connection termination

Bug description
When I deploy a service after some point I am getting
upstream connect error or disconnect/reset before headers. reset reason: connection termination error. It is random and i have found out that it only happens (not all the time) but if i got error it is definitely after this line connection is no more.
kubectl logs -n namespace $POD  -c istio-proxy
2020-09-24T17:12:35.507004Z     warning envoy config    [bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamAggregatedResources gRPC config stream closed: 13,

Also after getting this error and can't connect to my Istio endpoint/service, 30 minutes later (roughly) i get this line
2020-09-24T17:43:49.473767Z     warning envoy config    [bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamAggregatedResources gRPC config stream closed: 13,

connection is reinstated and i can connect the service again. It does not happen all the time but when it happens it lasts 30 min exact time to be connection reinstated.
I made a curl test every 30 seconds and it starts at 2020-09-24-17-12 and finishes at 2020-09-24-17-43
tracing-rest-checker-pg8hp tracing-rest-checker 2020-09-24-17-11
tracing-rest-checker-pg8hp tracing-rest-checker {"data":{"names":["proba"],"ndarray":[[0.39731466202150834]]},"meta":{}}
tracing-rest-checker-pg8hp tracing-rest-checker
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker 2020-09-24-17-12
tracing-rest-checker-pg8hp tracing-rest-checker {"data":{"names":["proba"],"ndarray":[[0.39731466202150834]]},"meta":{}}
tracing-rest-checker-pg8hp tracing-rest-checker
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker 2020-09-24-17-12
tracing-rest-checker-pg8hp tracing-rest-checker upstream connect error or disconnect/reset before headers. reset reason: connection termination
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker 2020-09-24-17-13
tracing-rest-checker-pg8hp tracing-rest-checker upstream connect error or disconnect/reset before headers. reset reason: connection termination
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
...
...
...
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker 2020-09-24-17-42
tracing-rest-checker-pg8hp tracing-rest-checker upstream connect error or disconnect/reset before headers. reset reason: connection termination
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker 2020-09-24-17-43
tracing-rest-checker-pg8hp tracing-rest-checker upstream connect error or disconnect/reset before headers. reset reason: connection termination
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker 2020-09-24-17-43
tracing-rest-checker-pg8hp tracing-rest-checker upstream connect error or disconnect/reset before headers. reset reason: connection termination
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker 2020-09-24-17-44
tracing-rest-checker-pg8hp tracing-rest-checker {"data":{"names":["proba"],"ndarray":[[0.39731466202150834]]},"meta":{}}
tracing-rest-checker-pg8hp tracing-rest-checker
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################
tracing-rest-checker-pg8hp tracing-rest-checker 2020-09-24-17-44
tracing-rest-checker-pg8hp tracing-rest-checker {"data":{"names":["proba"],"ndarray":[[0.39731466202150834]]},"meta":{}}
tracing-rest-checker-pg8hp tracing-rest-checker
tracing-rest-checker-pg8hp tracing-rest-checker ################################################################################

Based on the suggestion I also got the before and after proxy config dump with
 while true ; do  kubectl exec -n istio-system  $(kubectl get pods -n istio-system -l app=istiod -o name) -- curl 'localhost:8080/debug/config_dump?proxyID=tracing-and-logging-rest-tracing-0-model1-865b5596fd-jl2vp.emtech'  > after/after_config_dump.txt-$(date -d '1 hour ago' +%Y-%m-%d-%H-%M); sleep 300;  done

Details logs are attached
istio-bug.zip
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ X] User Experience
[ ] Developer Infrastructure
Expected behavior
To be able to connect endpoint all the time.
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version --short and helm version if you used Helm)
$ istioctl version --remote
client version: 1.6.8
control plane version: 1.6.8
data plane version: 1.6.8 (7 proxies)
$  kubectl version --short
Client Version: v1.18.6
Server Version: v1.16.13
How was Istio installed?
istioctl install
Environment where bug was observed (cloud vendor, OS, etc)
I have seen this bug on
AWS EKS 1.17
Kind 1.17 Cluster (onprem)
Azure AKS 1.16

@howardjohn   as you requested on https://github.com/istio/istio/issues/19321  also @marziman  can be interested on this too

You can do
git diff after/after_config_dump.txt-2020-09-24-17-40  after/after_config_dump.txt-2020-09-24-17-45

to get what has changed to fix connection as connection is reinstated at 2020-09-24-17-43 at 49th seconds.

is related https://github.com/istio/istio/issues/19321

@howardjohn do you think we can get help in this new issue? As you requested to create a new one, @omerfsen was so kind to do so.
I know you are all busy, but it would be a big help if you guys take a look 🙏🏻
cc @chadlwilson

@puneetloya @a8j8i8t8 this shall be the right issue, as I saw you observed this too

Every ca. 30minutes we have a TCP disconnect and our mongo database fails with exception (Got socket exception on connection )

Is it a 1 time disconnect, or is it broken for 30 mins then recovers? These are very different problems. Both of them it is useful to get a diff of the config berfore and after

Every ca. 30minutes we have a TCP disconnect and our mongo database fails with exception (Got socket exception on connection )

Is it a 1 time disconnect, or is it broken for 30 mins then recovers? These are very different problems. Both of them it is useful to get a diff of the config berfore and after

My issue was it is broken for 30 min then recovers and after some time it is down again for 30 min and recovers again

@christian-posta Can i get your opinion on this? Have you came across in the field?

Is someone looking into this from the maintainers? Can we help with any information. Just let us know please, how we could assist 🙏🏻

Any update ?

@leecalcote Can i also get your opinion on this ?

Ok let me also ask the status here.
Colleagues, are you going to do something with this issue or do you just keep it like this?
@howardjohn I think we provided all infos you asked us. Now it is your turn. Did anybody at all tried to reproduce it?
Thanks & BR

I have more debug input for this:
I set debugging on istio-proxy:
istioctl proxy-config log  tracing-rest-tracing-0-model1-68f4845d6-8hx46.prod --level grpc:debug,upstream:debug,config:debug

I am attaching the logs:
It started at 2020-10-08T16:24:58
with
istio-proxy 2020-10-08T16:24:58.173837Z	warning	envoy config	[bazel-out/k8-opt/bin/external/envoy/source/common/config/_virtual_includes/grpc_stream_lib/common/config/grpc_stream.h:92] StreamAggregatedResources gRPC config stream closed: 13,

grpc_log.log

I have checked the time with same grpc 13 error but no upstream error received and found out that when following happens it definitely breaks connection for 30 min. The log starts like following: (it is line 738 on attached grpc_log.log I have attached on my previous comment)

2020-10-08T20:04:45.166604Z	debug	envoy config	[external/envoy/source/server/listener_manager_impl.cc:412] use in place update filter chain update path for listener name=virtualInbound hash=13528217587319322972
2020-10-08T20:04:45.166649Z	debug	envoy config	[external/envoy/source/server/listener_manager_impl.cc:129]   filter #0:
2020-10-08T20:04:45.166656Z	debug	envoy config	[external/envoy/source/server/listener_manager_impl.cc:130]     name: envoy.listener.original_dst
2020-10-08T20:04:45.167268300Z 2020-10-08T20:04:45.166679Z	debug	envoy config	[external/envoy/source/server/listener_manager_impl.cc:137]   config: {
2020-10-08T20:04:45.167275000Z  "@type": "type.googleapis.com/envoy.config.filter.listener.original_dst.v2.OriginalDst"
2020-10-08T20:04:45.167281400Z }
2020-10-08T20:04:45.167287100Z
2020-10-08T20:04:45.167292600Z 2020-10-08T20:04:45.166688Z	debug	envoy config	[external/envoy/source/server/listener_manager_impl.cc:129]   filter #1:
2020-10-08T20:04:45.167298800Z 2020-10-08T20:04:45.166691Z	debug	envoy config	[external/envoy/source/server/listener_manager_impl.cc:130]     name: envoy.listener.tls_inspector
2020-10-08T20:04:45.167305400Z 2020-10-08T20:04:45.166699Z	debug	envoy config	[external/envoy/source/server/listener_manager_impl.cc:137]   config: {
2020-10-08T20:04:45.167312000Z  "@type": "type.googleapis.com/envoy.config.filter.listener.tls_inspector.v2.TlsInspector"
2020-10-08T20:04:45.167335300Z }
2020-10-08T20:04:45.167342400Z
2020-10-08T20:04:45.167348100Z 2020-10-08T20:04:45.166734Z	debug	envoy config	[external/envoy/source/server/listener_manager_impl.cc:129]   filter #2:
2020-10-08T20:04:45.167354600Z 2020-10-08T20:04:45.166738Z	debug	envoy config	[external/envoy/source/server/listener_manager_impl.cc:130]     name: envoy.listener.http_inspector
2020-10-08T20:04:45.167361200Z 2020-10-08T20:04:45.166746Z	debug	envoy config	[external/envoy/source/server/listener_manager_impl.cc:137]   config: {
2020-10-08T20:04:45.167367800Z  "@type": "type.googleapis.com/envoy.config.filter.listener.http_inspector.v2.HttpInspector"
 2020-10-08T20:04:45.167374300Z }
2020-10-08T20:04:45.167379600Z
2020-10-08T20:04:45.174103800Z 2020-10-08T20:04:45.173850Z	debug	envoy config	[external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:678] Secret is updated.
2020-10-08T20:04:45.175023300Z 2020-10-08T20:04:45.174863Z	debug	envoy config [external/envoy/source/extensions/transport_sockets/tls/ssl_socket.cc:678] Secret is updated.
.....

One thing i have found out that I have 2 virtualservers and when error happens it redirect traffic to :5001 port (which is grpc service)
kubectl get virtualservices.networking.istio.io -A |grep tracing-rest
prod        tracing-rest-grpc      [istio-system/seldon-gateway]   [*]     10h
prod        tracing-rest-http      [istio-system/seldon-gateway]   [*]     10h

When error happens traffic routed to :5001 (the one that runs grpc endpoint)

and then ~30 min later it goes back to normal (because traffic is routed to :8000)

/notstale

/notstale

@howardjohn and other istio developers can we please not mark this issue as stale? Is the above provided evidence by @omerfsen does not point to any issue? To me this issue seems like the only reason we are not able to run tcp proxies successfully with Istio. I mean to say it does work but with intermittent disconnectivity.
I have been using Kafka and Cassandra with Istio for the past few months but it does come down to the disconnections that happen and recover with every time envoy gets refreshed(every 30 mins), assuming that the refresh is flushing out all connections.
The apps that connect to these Istio based statefulsets do not have a graceful way to connect back once they are in this state or atelast they stay in the failed state for a long time. Do you need more evidence? I can help out.
Also is this even a Istio issue or an envoy tcp proxy bug?

@howardjohn and other istio developers can we please not mark this issue as stale? Is the above provided evidence by @omerfsen does not point to any issue? To me this issue seems like the only reason we are not able to run tcp proxies successfully with Istio. I mean to say it does work but with intermittent disconnectivity.
I have been using Kafka and Cassandra with Istio for the past few months but it does come down to the disconnections that happen and recover with every time envoy gets refreshed(every 30 mins), assuming that the refresh is flushing out all connections.
The apps that connect to these Istio based statefulsets do not have a graceful way to connect back once they are in this state or atelast they stay in the failed state for a long time. Do you need more evidence? I can help out.
Also is this even a Istio issue or an envoy tcp proxy bug?

not statle

not statle

Could this be related / addressed by enabling TCP keep alive in the DestinationRule config?
Could the absence of the above setting be making envoy terminating TCP connections and thus disrupting HTTP persistent connections?

Could this be related / addressed by enabling TCP keep alive in the DestinationRule config?
Could the absence of the above setting be making envoy terminating TCP connections and thus disrupting HTTP persistent connections?

@pantelis-karamolegkos I have tried keep alives, let me experiment a little bit more with it. But according to you, does proxy sidecar not terminate all existing connections when istiod sends out an proxy update every half an hour?

@pantelis-karamolegkos I have tried keep alives, let me experiment a little bit more with it. But according to you, does proxy sidecar not terminate all existing connections when istiod sends out an proxy update every half an hour?

Hi there, I met the same error when calling an external destination as service entry. It is also random - most of the times the call succeeds but sometimes it fails with such error. I checked the client side envoy proxy log but did not find something unusual.  And I am sure the request does not reach the external service. Any hint how can I proceed to investigate this issue ?

Hi there, I met the same error when calling an external destination as service entry. It is also random - most of the times the call succeeds but sometimes it fails with such error. I checked the client side envoy proxy log but did not find something unusual.  And I am sure the request does not reach the external service. Any hint how can I proceed to investigate this issue ?

Hi, I met the same error.
We have two external domain thosse are api-dev.-----.com / api-qa.-----.com
We can access api-dev.-----.com but cannot access api-qa.-----.com
api-dev api call:
# curl https://api-dev.-----.com/-----/v2.0/version
{"return":0,"message":"OK","value":{"revision":"97b0ddc.202101250444","version":"v2.0"}}

api-qa api call:
# curl http://api-qa.-----.com/-----/v2.0/version
upstream connect error or disconnect/reset before headers. reset reason: local reset

istio-proxy error message:
{"response_flags":"LR","start_time":"2021-01-29T06:56:34.281Z","method":"GET","request_id":"f292923e-74d6-9638-a01a-66c3a7fbe85e","upstream_host":"/-----:80","x_forwarded_for":null,"requested_server_name":null,"bytes_received":0,"bytes_sent":84,"upstream_cluster":"outbound|80||api-qa.-----.com","downstream_remote_address":"-----:54600","authority":"api-qa.-----.com","path":"/-----/v2.0/version","protocol":"HTTP/1.1","upstream_service_time":null,"upstream_local_address":null,"duration":10000,"upstream_transport_failure_reason":null,"route_name":"default","downstream_local_address":"-----:80","user_agent":"curl/7.68.0","response_code":503}

Is this a bug of istio?

Hi, I met the same error.
We have two external domain thosse are api-dev.-----.com / api-qa.-----.com
We can access api-dev.-----.com but cannot access api-qa.-----.com
api-dev api call:
# curl https://api-dev.-----.com/-----/v2.0/version
{"return":0,"message":"OK","value":{"revision":"97b0ddc.202101250444","version":"v2.0"}}

api-qa api call:
# curl http://api-qa.-----.com/-----/v2.0/version
upstream connect error or disconnect/reset before headers. reset reason: local reset

istio-proxy error message:
{"response_flags":"LR","start_time":"2021-01-29T06:56:34.281Z","method":"GET","request_id":"f292923e-74d6-9638-a01a-66c3a7fbe85e","upstream_host":"/-----:80","x_forwarded_for":null,"requested_server_name":null,"bytes_received":0,"bytes_sent":84,"upstream_cluster":"outbound|80||api-qa.-----.com","downstream_remote_address":"-----:54600","authority":"api-qa.-----.com","path":"/-----/v2.0/version","protocol":"HTTP/1.1","upstream_service_time":null,"upstream_local_address":null,"duration":10000,"upstream_transport_failure_reason":null,"route_name":"default","downstream_local_address":"-----:80","user_agent":"curl/7.68.0","response_code":503}

Is this a bug of istio?

Hi, running into the same error for istio version 1.6.14
I've a multicluster installation, using serviceentries to communicate which fail at random with:
503, upstream connect error or disconnect/reset before headers. reset reason: connection termination

I've run into this recently - it was solved by checking the workloads on GCP and deleting ones that were taking so much resources that the one workload causing this issue didn't have enough resources (CrashLoopBackOff)

Hi @omerfsen Do you find any solution for this issue? Any help will be really greatful? Anyone who has fixed it may be with some work arounds?

Hi @omerfsen Do you find any solution for this issue? Any help will be really greatful? Anyone who has fixed it may be with some work arounds?

It was about service name not starting with http though not %100 sure

Hi, running into the same error for istio version 1.8.5
We got local reset and connection termination randomly. Is there any solution to fix it?
503, upstream connect error or disconnect/reset before headers. reset reason: connection termination

I see the same issue in 1.9.2

not stale

Same here when using istio 1.10.
HTTP 503 - upstream connect error or disconnect/reset before headers. reset reason: connection termination
In envoy logs I see:
2021-08-23T17:00:32.627283Z	warning	envoy config	StreamAggregatedResources gRPC config stream closed: 14, transport is closing

Why is this closed?

In my case I was missing the ingress host in the hosts field for the VirtualService. After adding it, the proxy was able to route it to the target service.
FYI im not using a gateway, but nginx ingress instead.

Hi I am also facing the same issue can anyone give the solution to this

We're facing the same issue, randomly happened on production, with istio-1.7.3 deployed.
At fist, I though it's releated to
https://github.com/istio/istio/issues/17383
https://github.com/istio/istio/issues/17139
which should have been fixed by https://github.com/istio/envoy/pull/109/commits
then I realized that istio-1.7.3 has istio/envoy:1.21.2 which already contains the fix, I think this issue should be re-opened and reconsidered.

@howardjohn @ramaraochavali
Can you please re-open this issue?
It is now 2 years and many people face this issue in production. Can you please prioritize it, as this has bad implications on connections.
There were enough reports and if further info needed, I am sure we all can provide infos.
Thanks!

facing same issue we are using istio version 1.13.0 and we are using nginx ingress not gateway.

Hey folks - understood the concerns when seeing errors like this. However, this issue is not going to be a helpful path forward. This is a very generic error message that basically means "the request did not work". Without specific context (in the form of istioctl bug-report, logs, configs, etc), its impossible to make forward progress.
So I am not trying to dismiss this entirely - but please open new issues with details about your case so we can help.
Also see https://istio.io/latest/blog/2021/upcoming-networking-changes/ since that is a fairly basic one that could trigger this.
Thanks!

We have faced this issue too. I've found the root cause in our case. Hope this will helps you guys.
Context:
We have two services service-a and service-b. They are Nestjs projects, running on Node 12. service-a requests HTTP to service-b.
service-a got 503 with error upstream connect error or disconnect/reset before headers. reset reason: connection termination. But service-b stills processed. it happens randomly.
After tracing the logs, we saw that the error occurs when the request from service-a to service-b took too long.
I tried to config Istio timeout but it didn't work.
I created 2 new sample services in local. Set service-b to response slowly. And I got Error: socket hang up code ECONNRESET after 2 minutes. That makes I think the root cause is the HTTP server, not Istio.
Focus on the error from Nodejs, I found out that Node HTTP server will disconnects the socket connection after amount of time. And that amount of time can be set via the option timeout
I increase the timeout value of service-b and it works. You could find the similar setting on your HTTP server.
@Injectable()
export class AppService implements OnApplicationBootstrap {
  private readonly logger = new Logger(AppService.name);
  constructor(private readonly refHost: HttpAdapterHost<any>) {}

  onApplicationBootstrap() {
    const server: Server = this.refHost.httpAdapter.getHttpServer();
    server.timeout = 300000; // 3 minutes
  }
}

REMEMBER to increase the socket timeout of service-a if the flow is like the image below, because the HTTP request to service-a can be terminated too.

Conclusion:

Increasing soket timeout is temporary solution. You should think about event base, or save the request state and use it for the retry request.
Istio timeout actually works. It effects when Istio's timeout is smaller than HTTP server socket timeout.

I just restarted my computer and it fixed it

I also faced this issue with my homelab, not sure if it caused by daily computer shutdown.  I restarted istio gateway pod, and everything back to works again.


This page is missing the audio part of the title!

Welcome! Please use this template for reporting documentation issues on https://developers.google.com/web/.
For questions about Chrome DevTools, checkout the
google-chrome-devtools tag on StackOverflow.
For questions about Chrome, check the google-chrome
tag. If you think you've found a Chrome bug, check out our
feedback page for more details on how to file it.
Page Affected: https://developers.google.com/web/TODO
What needs to be done?
Please provide description of what's needs to be done here. Please be sure to include the link to the original page
and any supporting links/data.

[ ] Appropriate type-something label has been added.
[ ] Appropriate section-something label has been added.

Hi, Can you please let us know the page you're referring to? Thanks!

sorry i did not see this until it was just closed.
https://developers.google.com/web/fundamentals/media/video
the title is under Media & VR | Video and Audio Playback | Using
and  but, I do not see any audio example here. I can make audio tag
work and new Audio() work in plan HTML5 but when trying to work with Vuejs
it's a not go.
Jerry
On Mon, Sep 23, 2019 at 1:51 PM Pete LePage<EMAIL_ADDRESS>wrote:

Closed #8109 https://github.com/google/WebFundamentals/issues/8109.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/WebFundamentals/issues/8109?email_source=notifications&email_token=AHB5NERT22FZFYEFZR5CVZLQLD62FA5CNFSM4IWFOVXKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTZCWXNQ#event-2655349686,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHB5NER6DHLHJZFTUAI32M3QLD62FANCNFSM4IWFOVXA
.


Add Promo Banner to meltano.meltanodata.com

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1351
Originally created by @kressaty on 2019-12-03 22:09:31

We should feature that the exact dashboard someone is viewing can be their own, for their own data! Open to ideas, but my initial thought is a persistent purple banner at the very top of the page with this copy:
"See Your Company's Data in Meltano For Free!"
And a link to https://meltano.com
@dmor thoughts on the copy?

View 6 previous comments from the original issue on GitLab


[ALLUXIO-2813] Add CreateUfsFileOptions

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15183/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15188/
Test PASSed.


Build Error [Linux PopOs]

What happened?
Attempting to build a static Laravel application in Linux PopOS (Ubuntu 22.04 compatible) using the Shell script complains of Extension [hash] not exist!.
EMBED=/data/src/laravel/project ./build-static.sh
Notice from the phpinfo() output that Hash is enabled.
System Info:
OS: Pop!_OS 22.04 LTS x86_64
Host: 20M9000XUS ThinkPad P52
Kernel: 6.8.0-76060800daily20240311-generic
Uptime: 19 days, 7 hours, 7 mins
Packages: 4055 (dpkg), 1 (pkg), 83 (flatpak), 15 (snap)
Shell: bash 5.1.16
Resolution: 1920x1080, 1920x1080
DE: GNOME
WM: Mutter
WM Theme: Pop
Theme: Nordic-Polar-Hitz [GTK2/3]
Icons: breeze [GTK2/3]
Terminal: konsole
Terminal Font: JetBrains Mono 12
CPU: Intel i7-8850H (12) @ 4.300GHz
GPU: NVIDIA Quadro P2000 Mobile
GPU: Intel CoffeeLake-H GT2 [UHD Graphics 630]
Memory: 34193MiB / 47797MiB

Please advise how to resolve this issue.
Build Type
Official static build
Worker Mode
No
Operating System
GNU/Linux
CPU Architecture
x86_64
PHP configuration
System 	Linux hitz-pad 6.8.0-76060800daily20240311-generic #202403110203~1714077665~22.04~4c8e9a0 SMP PREEMPT_DYNAMIC Thu A x86_64
Build Date 	May 13 2024 15:38:09
Build System 	Linux
Server API 	Built-in HTTP server
Virtual Directory Support 	disabled
Configuration File (php.ini) Path 	/etc/php/8.3/cli
Loaded Configuration File 	/etc/php/8.3/cli/php.ini
Scan this dir for additional .ini files 	/etc/php/8.3/cli/conf.d
Additional .ini files parsed 	/etc/php/8.3/cli/conf.d/10-mysqlnd.ini, /etc/php/8.3/cli/conf.d/10-opcache.ini, /etc/php/8.3/cli/conf.d/10-pdo.ini, /etc/php/8.3/cli/conf.d/15-xml.ini, /etc/php/8.3/cli/conf.d/20-calendar.ini, /etc/php/8.3/cli/conf.d/20-ctype.ini, /etc/php/8.3/cli/conf.d/20-curl.ini, /etc/php/8.3/cli/conf.d/20-dom.ini, /etc/php/8.3/cli/conf.d/20-exif.ini, /etc/php/8.3/cli/conf.d/20-ffi.ini, /etc/php/8.3/cli/conf.d/20-fileinfo.ini, /etc/php/8.3/cli/conf.d/20-ftp.ini, /etc/php/8.3/cli/conf.d/20-gd.ini, /etc/php/8.3/cli/conf.d/20-gettext.ini, /etc/php/8.3/cli/conf.d/20-iconv.ini, /etc/php/8.3/cli/conf.d/20-mbstring.ini, /etc/php/8.3/cli/conf.d/20-mysqli.ini, /etc/php/8.3/cli/conf.d/20-pdo_mysql.ini, /etc/php/8.3/cli/conf.d/20-pdo_pgsql.ini, /etc/php/8.3/cli/conf.d/20-pdo_sqlite.ini, /etc/php/8.3/cli/conf.d/20-pgsql.ini, /etc/php/8.3/cli/conf.d/20-phar.ini, /etc/php/8.3/cli/conf.d/20-posix.ini, /etc/php/8.3/cli/conf.d/20-readline.ini, /etc/php/8.3/cli/conf.d/20-shmop.ini, /etc/php/8.3/cli/conf.d/20-simplexml.ini, /etc/php/8.3/cli/conf.d/20-soap.ini, /etc/php/8.3/cli/conf.d/20-sockets.ini, /etc/php/8.3/cli/conf.d/20-sqlite3.ini, /etc/php/8.3/cli/conf.d/20-sysvmsg.ini, /etc/php/8.3/cli/conf.d/20-sysvsem.ini, /etc/php/8.3/cli/conf.d/20-sysvshm.ini, /etc/php/8.3/cli/conf.d/20-tokenizer.ini, /etc/php/8.3/cli/conf.d/20-xmlreader.ini, /etc/php/8.3/cli/conf.d/20-xmlwriter.ini, /etc/php/8.3/cli/conf.d/20-xsl.ini, /etc/php/8.3/cli/conf.d/20-zip.ini
PHP API 	20230831
PHP Extension 	20230831
Zend Extension 	420230831
Zend Extension Build 	API420230831,NTS
PHP Extension Build 	API20230831,NTS
Debug Build 	no
Thread Safety 	disabled
Zend Signal Handling 	enabled
Zend Memory Manager 	enabled
Zend Multibyte Support 	provided by mbstring
Zend Max Execution Timers 	disabled
IPv6 Support 	enabled
DTrace Support 	disabled
Registered PHP Streams	https, ftps, compress.zlib, php, file, glob, data, http, ftp, phar, zip
Registered Stream Socket Transports	tcp, udp, unix, udg, ssl, tls, tlsv1.0, tlsv1.1, tlsv1.2, tlsv1.3
Registered Stream Filters	zlib.*, string.rot13, string.toupper, string.tolower, convert.*, consumed, dechunk, convert.iconv.*

-- ---------

hash
hash support 	enabled
Hashing Engines 	md2 md4 md5 sha1 sha224 sha256 sha384 sha512/224 sha512/256 sha512 sha3-224 sha3-256 sha3-384 sha3-512 ripemd128 ripemd160 ripemd256 ripemd320 whirlpool tiger128,3 tiger160,3 tiger192,3 tiger128,4 tiger160,4 tiger192,4 snefru snefru256 gost gost-crypto adler32 crc32 crc32b crc32c fnv132 fnv1a32 fnv164 fnv1a64 joaat murmur3a murmur3c murmur3f xxh32 xxh64 xxh3 xxh128 haval128,3 haval160,3 haval192,3 haval224,3 haval256,3 haval128,4 haval160,4 haval192,4 haval224,4 haval256,4 haval128,5 haval160,5 haval192,5 haval224,5 haval256,5
MHASH support 	Enabled
MHASH API Version 	Emulated Support

Relevant log output
Doctor check complete !
+ ./bin/spc download --with-php=8.3 --for-extensions=ctype,dom,fileinfo,filter,hash,iconv,json,libxml,mbstring,openssl,pcre,session,tokenizer --for-libs=bzip2,freetype,libavif,libjpeg,liblz4,libwebp,libzip,brotli --ignore-cache-sources=php-src

In DependencyUtil.php line 169:

  Extension [hash] not exist !

download [--shallow-clone] [--with-openssl11] [--with-php WITH-PHP] [--clean] [-A|--all] [-U|--custom-url CUSTOM-URL] [-Z|--from-zip FROM-ZIP] [-e|--for-extensions FOR-EXTENSIONS] [-l|--for-libs FOR-LIBS] [--without-suggestions] [--ignore-cache-sources IGNORE-CACHE-SOURCES] [-R|--retry RETRY] [--debug] [--no-motd] [--] <sources>

This looks similar to #840. Could you try to set the PHP_EXTENSIONS explicitly while we're working on fixing the script, please? cc @crazywhalecc

@dunglas Core,hash,json,Reflection,SPL,standard should be skipped, is this correct?

This looks similar to #840. Could you try to set the PHP_EXTENSIONS explicitly while we're working on fixing the script, please? cc @crazywhalecc

Even with PHP_EXTENSIONS:
EMBED=/data/src/laravel/project ./build-static.sh PHP_EXTENSIONS=ctype,curl,dom,fileinfo,filter,hash,mbstring,openssl,pcre,session,pdo,pdo_mysql,pdo_sqlite
...it still fails with the same error.

@djamez You can remove hash from your extension list and build again.
Currently spc does not allow passing any unsupported extensions, but we haven't ignore these constant extensions (no matter what extensions you choose, it's always included). I'm working on it: Ignore all internal extensions which are always enabled https://github.com/crazywhalecc/static-php-cli/pull/473

@djamez Remove hash. Hash is an internal extension, it will be enabled whether you use. But the previous spc prohibits passing in any unsupported extensions (including hash).
After https://github.com/crazywhalecc/static-php-cli/pull/473 merged, you can pass hash without any interrupt.

Seems you are linking wrong libc (glibc). static-php-cli and frankenphp need musl-libc to link, but I'm not sure build-static.sh and frankenphp workflow may be linked in a wrong libc. cc @dunglas

We strongly recommend using the Docker image we provide to run the script. It's not entirely mandatory,  but if you don't you need to install musl etc by yourself.


lxc/copy: Updates copyContainer to not modify volatile.idmap.next

Signed-off-by: Thomas Parrott<EMAIL_ADDRESS>

@stgraber because the update request is a PUT request, stripping the volatile.idmap.next from the request meant it was totally removed on the target. Instead I used the existing request that gets the etag to load the existing config and copy the value into the PUT request.


Can Apply Filter in Live Camera?

Can i apply your filters on live camera? If yes, then how? please guide me and show me any example if possible. Thank you.

Please try to get the image from camera as bitmap and then use filters on that bitmap.

I want live filter, not on captured image.

@SohailYaseen did you find a solution?

@kukalajet I didn't spend much time. You can try, if you found any solution share with me.


add SNS, SQS, new Lambda resources, CloudWatch Event Rule, some type additions and fixes

Thanks again!

my pleasure


Optional window override prop

This simple PR adds an optional window prop to allow the consumer to specify which frame to event-listen in.
I needed to consume react-with-gesture inside an iframe setup by ryanseddon/react-frame-component. The iframe doesn't capture the parent's window events!
Example
const gestureProps = useGesture({
    window: window.document.getElementsByTagName('iframe')[0].contentDocument,
    onAction: { ... }
})

@janbaykara made a patch release<EMAIL_ADDRESS>

@janbaykara had to revert it due to https://github.com/react-spring/react-with-gesture/issues/44
do you know how to handle window in node environments like next/jest/etc?

generally you can flip a flag in componentDidMount() as this only renders on the client-side... at least in Next.js, then return null in render() if flag is false

Apologies! This solution has worked for me in Gatsby projects in the past.

@janbaykara wanna resubmit? i merge it tomorrow. The pr itself is nice, just had to act quickly because i had some other tasks to finish first (see roadmap).

Hi @drcmda — I was away for a few days, have resubmitted the PR with fixes in #48.


Windows 8.1 building error: EPERM - syscall 'spawn' in nsis-gen

I'm attempting to compile the example project with an npm link'd version of nw-builder-phoenix in Windows 8.1. When I compile, I get a permissions error when nsis-gen attempts to spawn makensis.exe.

I downloaded nw-builder-phoenix to C:\Users\dev\nw-builder-phoenix and then ran npm install there as well as npm link.
I copied nw-builder-phoenix/assets/project to C:\Users\dev\nwtest. I ran npm link nw-builder-phoenix to ensure it was using the local version I needed. I also ran npm install. I can confirm that the node_modules has a junction created for nw-builder-phoenix.
I modified sample application's package.json to bring it up to date and adapt it to Windows:

{
  "name": "project",
  "version": "0.1.0",
  "description": "description",
  "main": "index.html",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1",
    "build": "cross-env DEBUG=* build --tasks win-x64 ."
  },
  "author": "evshiron",
  "license": "MIT",
  "build": {
    "appId": "io.github.evshiron.nwjs-builder-phoenix.project",
    "nwVersion": "0.25.2",
    "packed": false,
    "targets": [
      "nsis7z"
    ],
    "strippedProperties": [
      "build"
    ],
    "outputPattern": "${NAME}-${VERSION}-${PLATFORM}-${ARCH}",
    "win": {
      "productName": "Project",
      "companyName": "nwjs-builder-phoenix",
      "copyright": "copyright",
      "icon": "./assets/pd.ico"
    },
    "nsis": {
      "diffUpdaters": true
    }
  },
  "devDependencies": {
    "cross-env": "^5.0.5",
    "nwjs-builder-phoenix": "1.14.6",
    "typescript": "^2.2.1"
  },
  "window": {
    "icon": "./assets/pd.png"
  }
}

When I run npm run build, I get:
  build:nsisBuild build args are C:\Users\dev\nwjs-builder-phoenix\assets\nsis\makensis.exe,/NOCD,/INPUTCHARSET,UTF8,C:\Users\dev\AppData\Local\Temp\tmp-2596wIhETQ3vt3XN +0ms
{ Error: spawn EPERM
    at exports._errnoException (util.js:1022:11)
    at ChildProcess.spawn (internal/child_process.js:317:11)
    at Object.exports.spawn (child_process.js:491:9)
    at Object.<anonymous> (C:\Users\dev\nwjs-builder-phoenix\src\lib\nsis-gen\index.ts:28:19)
    at step (C:\Users\dev\nwjs-builder-phoenix\dist\lib\nsis-gen\index.js:32:23)
    at Object.next (C:\Users\dev\nwjs-builder-phoenix\dist\lib\nsis-gen\index.js:13:53)
    at C:\Users\dev\nwjs-builder-phoenix\dist\lib\nsis-gen\index.js:7:71
    at Promise (<anonymous>)
    at __awaiter (C:\Users\dev\nwjs-builder-phoenix\dist\lib\nsis-gen\index.js:3:12)
    at Object.nsisBuild (C:\Users\dev\nwjs-builder-phoenix\dist\lib\nsis-gen\index.js:53:12)
    at Builder.<anonymous> (C:\Users\dev\nwjs-builder-phoenix\src\lib\Builder.ts:729:15)
    at step (C:\Users\dev\nwjs-builder-phoenix\dist\lib\Builder.js:40:23)
    at Object.next (C:\Users\dev\nwjs-builder-phoenix\dist\lib\Builder.js:21:53)
    at fulfilled (C:\Users\dev\nwjs-builder-phoenix\dist\lib\Builder.js:12:58)
    at <anonymous> code: 'EPERM', errno: 'EPERM', syscall: 'spawn' }

Here you can see that I've added a debug message in nw-builder-phoenix/src/lib/nsis-gen/index.ts to echo out the build args: C:\Users\dev\nwjs-builder-phoenix\assets\nsis\makensis.exe,/NOCD,/INPUTCHARSET,UTF8,C:\Users\dev\AppData\Local\Temp\tmp-2596wIhETQ3vt3XN.
If I run this directly in the command prompt (normal user), I get Access is denied:
C:\Users\dev\nwtest>C:\Users\dev\nwjs-builder-phoenix\assets\nsis\makensis.exe /NOCD /INPUTCHARSET UTF8 C:\Users\dev\AppData\
Local\Temp\tmp-2596wIhETQ3vt3XN
Access is denied.

If I run the project without the link step (using the downloaded npm package of nw-builder-phoenix), I don't run into this error. My question is, how do you get around this when you're developing nw-builder-phoenix?
My aim is to get access to the generated nsis script so I can modify it before it is called.

I think I figured this out - I used git in cygwin to clone the repo, but I used the regular windows console to execute the npm link and npm build. I think think checking out the executable in the context of cygwin messed up the executable, perhaps because there's no .gitattributes marking the .exe as a binary file.
Key lesson: if you are hacking on nwjs-builder-phoenix locally, git clone nwjs-builder-phoenix must be done from the normal windows cli.


tsc target did not work expectedly when compile ES2022 to ES2015

🔎 Search Terms
target  ES2022  ES2015
🕗 Version & Regression Information
TS 4.5
⏯ Playground Link
No response
💻 Code
npx tsc --target es5 index.ts --outFile indexout.js
index.ts:
const arr = [1, 2, 3, 4, 5];
arr.at(1); // 2
🙁 Actual behavior
indexout.js:
const arr = [1, 2, 3, 4, 5];
arr.at(1); // 2
🙂 Expected behavior
Array.at is a new feature in ES2022
The target is ES5, the output js should not include Array.at
so the indexout.js can not work on the old browser.
Additional information about the issue
No response

TypeScript will only downlevel newer syntax. If the function you're trying to call does not exist at your runtime it's your responsibility to polyfill it.

Thanks I understand


Add the hasListeners method to client socket.

Fixes: #295

@thoov apologies for the direct ping, but I would love to get this merged :)

@Pringels What's the use case of having these methods?
Native WebSocket client and server implementation don't have these methods

@Atrue this change simply extends the already existing limited socket.io support, not Native WebSockets.

@Pringels Please use yarn to install packages and make sure you don't have any updated lock files

@Atrue please take another look. I've also updated the off() method to match the Emitter class as described here: https://socket.io/docs/v4/client-api/#socketoneventname-callback


Fix brew cask install … command in README.md

Fix README.md file by using the correct brew cask install … command instead of the not working brew install … command.

Thanks!


Add softmax support

I still have yet to implement the Accelerate implementation due to my main Windows environment. I will try to implement the Accelerate implementation shortly.

Oh and one more thing: could you also check the box for softmax in the README?


Update routing to use filepath instead of frontmatter.path to generate routes

Description
We have too many MDX guides that are put in seemingly random locations on the file system. This makes it difficult to find and edit a file via the URL since you first have to either click the "Edit page" button, or use your editor's global find feature to find a path that matches the URL.
This PR seeks to eliminate the confusion and make locating a guide at a particular URL much more straight forward. Instead of letting the developer define a custom path on frontmatter, the filepath of the MDX file itself will determine the URL for the guide. This eliminates the path property altogether.
To ease the transition, a build error will occur with a helpful error in the console if a path property is detected alerting the developer that the property has been removed and a recommendation for where to move the filepath if it differs from the path.
All guides have been updated to remove the path property and all of them are located in the proper location.
Reviewer Notes
NOTE: This WILL affect any open PRs that introduce new guides or update the path. If this gets merged beforehand, we will want to get these changes pulled into those branches and apply the updates, otherwise the build will fail.
Specifically, this looks like it affects these PRs (at the time of this writing):

https://github.com/newrelic/developer-website/pull/1904

cc @alexronquillo @jaesius so you know about these changes 🙂

I've added this the PR to the deven github project board for review. Thanks!

This is fine with me. I think we've never really defined how we were supposed to organize the filesystem since the paths were arbitrary, so over time we've sometimes placed them to match the path, sometimes we've organized them by topic (especially when we didn't know where they would eventually end up), etc.
Thanks for all the work on this @jerelmiller having only one way to organize docs will certainly make decision-making easier on us :)


Implement more realistic weather model

Requires desimodel >= 0.9.8.

Tests are passing (now that desisurvey 0.10.4 is tagged).
The changes here are relatively minor so I plan to merge and tag this soon, in preparation for bigger changes in the next version (coordinated with some big changes to desisurvey).  Let me know if I should hold off.


No good at supporting Chinese encoded in ANSI

My Chinese text file was save in ANSI-encoding,when I open it in the editor, it does not showed normally.

ANSI-encoding can mean many different things depending on where you're using it. Can you give us more information on exactly what encoding is not working?

Here is the file I create with notepad in my Windows 7~
testFile.txt

This file displayed ok in  EditPlus but not Atom

Just having the file doesn't help unless you can tell me what encoding is being used.
@50Wliu do you have any ideas what encoding is used by default on Chinese Windows 7?

Unfortunately not, it just works™ for me and I never had to check.
I'll test with the file though and see if I can figure it out.

Thank you very much @50Wliu :bow:

Encoding Selector's auto-detect tells me that it's encoded as the deprecated gb2312.  Makes sense since it's one of China's official character sets.
@seajean Please open up the Encoding Selector (Ctrl+Shift+U) and choose the first option, Auto Detect.

It works fine now, thanks~ If  there is a encoding select menu in the toolbar -> view,it will be better.


[BUG] Very out of date package JSON, breaking documentation example.

Describe the bug.
The documentation example https://www.asyncapi.com/tools/generator is to run using:
docker run --rm -it --user=root -v ${PWD}/example:/app/example -v ${PWD}/output:/app/output \
asyncapi/cli generate fromTemplate https://bit.ly/asyncapi @asyncapi/html-template -o example

However, the versions in the asyncapi/cli:2.8.0 (and many others) are out of date: package.json.
{
  "name": "@asyncapi/cli",
  "description": "All in one CLI for all AsyncAPI tools",
  "version": "2.8.0",
  "author": "@asyncapi",
  "bin": {
    "asyncapi": "./bin/run_bin"
  },
  "bugs": "https://github.com/asyncapi/cli/issues",
  "dependencies": {
    "@asyncapi/avro-schema-parser": "^3.0.23",
    "@asyncapi/bundler": "^0.6.3",
    "@asyncapi/converter": "^1.6.2",
    "@asyncapi/diff": "^0.4.1",
    "@asyncapi/generator": "^1.17.25",

resulting in the following errors:
◑  Generation in progress. Keep calm and wait a bit..Template @asyncapi/html-template successfully installed in /usr/local/lib/node_modules/@asyncapi/cli/node_modules/@asyncapi/generator/node_modules/@asyncapi/html-template.
Version of used template is 3.0.0.
◇  Generation failed
Generator Error: This template is not compatible with the current version of the generator (1.17.25). This template is compatible with the following version range: >=2.0.0 <3.0.0.

Expected behavior
Working example from homepage
Screenshots

How to Reproduce
Run the example from the homepage: https://www.asyncapi.com/tools/generator
🥦 Browser
None
👀 Have you checked for similar open issues?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to work on this issue ?
No, someone else can work on it

For example, current generator version is: 2.4.1 https://github.com/asyncapi/generator/releases

The error Generator Error: This template is not compatible with the current version of the generator (1.17.25). This template is compatible with the following version range: >=2.0.0 <3.0.0. is happening to me as well. I think the latest version of the generator should be used instead ( current version here ) which is 2.5.0 today

Does anyone know what the workaround is?

I am using html-template so, I am using an specific version of it. -> 2.3.14
With the example above it could be something like: docker run --rm -it --user=root -v ${PWD}/example:/app/example -v ${PWD}/output:/app/output \ asyncapi/cli generate fromTemplate https://bit.ly/asyncapi<EMAIL_ADDRESS>-o example
You can use a compatible version if you are using html-template here

The error Generator Error: This template is not compatible with the current version of the generator (1.17.25). This template is compatible with the following version range: >=2.0.0 <3.0.0. is happening to me as well. I think the latest version of the generator should be used instead ( current version here ) which is 2.5.0 today

tried changing it in package.json and then installing cli. installed version of the generator seems OK but then I received following error while using generate:
    return oclifHandler(err.message);
           ^

TypeError: oclifHandler is not a function

I tried the same. But, when installing the CLI it comes with an older version of the installed packages which causes conflicts.

using the option --use-new-generator while generate overcomes the problem

I'm running into a similar issue when running asyncapi generate with the latest version (2.11.1) of asyncapi install.
No docker involved, just a simple command line argument. I've tried install via brew or via pkg, with the current or with an older version, and I'm still getting the same error:
asyncapi generate golang -packageName=model my-asynapi-file.json -o model.go

/opt/homebrew/Cellar/asyncapi/2.11.1/libexec/lib/node_modules/@asyncapi/cli/bin/run_bin:12
    return oclifHandler(err.message);
           ^

TypeError: oclifHandler is not a function
    at /opt/homebrew/Cellar/asyncapi/2.11.1/libexec/lib/node_modules/@asyncapi/cli/bin/run_bin:12:12

Looking at the code, the problem seems to be linked to a problem loading @oclif/core/handle.
const oclif = require('@oclif/core');

oclif.run()
  .then(require('@oclif/core/flush'))
  .catch((err) => {
    const oclifHandler = require('@oclif/core/handle');
    return oclifHandler(err.message);
  });

However,  things look consistent in the package.json:

Hello, people just to put some context here to keep backward compatibility we are currently maintaining two versions of generator currently:- 2.4.1 and 1.7.25.
So, to use templates requiring newer version please use the flag --use-new-generator as mentioned here

Hi @Shurtu-gal , could you please explain how to use this flag with the asyncapi generate golang command? The flag doesn't seem to have any effect there

Hi @Shurtu-gal , could you please explain how to use this flag with the asyncapi generate golang command? The flag doesn't seem to have any effect there

This command is there for generating models and uses modelina under the hood. So this flag doesn't make sense there.
Could you specify your problem?

I mentioned it a bit earlier
https://github.com/asyncapi/cli/issues/1562#issuecomment-2510642166
Sorry for piggy-backing on this issue, the error message was the same so I assumed the issues must be related.
If the --use-new-generator flag is only for the fromTemplate mode, how do I fix the generate problem?

I mentioned it a bit earlier #1562 (comment)
Sorry for piggy-backing on this issue, the error message was the same so I assumed the issues must be related.
If the --use-new-generator flag is only for the fromTemplate mode, how do I fix the generate problem?

The command should be asyncapi generate models golang -packageName=model my-asynapi-file.json -o model.go

Thanks!, I was missing the "models" keyword!  :)

Closing this issue then. Feel free to open it and comment in case any thing is still unresolved.


Release 1.0.0

Codecov Report

Merging #35 (7bc4574) into develop (a32a7c4) will decrease coverage by 1.03%.
The diff coverage is 91.53%.

@@             Coverage Diff             @@
##           develop      #35      +/-   ##
===========================================
- Coverage    93.94%   92.91%   -1.03%
===========================================
  Files            8        8
  Lines          594      578      -16
  Branches        83       85       +2
===========================================
- Hits           558      537      -21
- Misses          20       23       +3
- Partials        16       18       +2

Impacted Files
Coverage Δ

esparto/_adaptors.py
100.00% <ø> (ø)

esparto/_contentdeps.py
100.00% <ø> (ø)

esparto/_options.py
100.00% <ø> (ø)

esparto/_publish.py
88.06% <ø> (ø)

esparto/_content.py
92.53% <88.24%> (-1.25%)
:arrow_down:

esparto/_utils.py
92.59% <90.48%> (+5.09%)
:arrow_up:

esparto/_layout.py
90.86% <91.97%> (-2.26%)
:arrow_down:

esparto/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32a7c4...7bc4574. Read the comment docs.


Incident type and Incident Priority not displayed in UI

I run the install.sh file without make any changes in the .env file and after running that file i am able to see 3 containers running and i lauched the dispatcher UI page that also loading fine. when i try to select "Type and Priority" i am seeing as "No Data Available". Please help me why i am getting like this. Do i need to configure in .env to see those values.

@Martin1196155 these need to be created in the Dispatch Web UI at https://<DISPATCH_URL>/incidents/types and https://<DISPATCH_URL>/incidents/priorities. I'd suggest you create the Service and Document before you create them.


nyc not respecting sourceMappingURL

https://www.typescriptlang.org/docs/handbook/compiler-options.html under the mapRoot option my transpiled .js files looks for source maps in a different directory (this also applies for Webpack).
My transpiled file includes at the bottom:
//# sourceMappingURL=http://localhost:9228/application/index.js.map
However the nyc output is:
An error occurred while trying to read the map file at /home/karl/dev/edsc/.build/application/http:/localhost:9228/application/index.js.map
It just appends it. This is a bug since it clearly states URL in sourceMappingURL.
I am however suspecting that nyc uses https://github.com/evanw/node-source-map-support so?

@basickarl I don't know that I've ever tried loading source-maps loaded via a URL; perhaps this is better classified as a feature request?

@bcoe It states URL and not Path for example hence it's a bug.

nyc is a node.js tool, there is currently no support for loading from remote URL's.  sourceMappingURL is a standard name defined outside nyc (originally by browsers I believe).  The fact that it says URL does not mean that nyc supports URL's.  Again the key point is that nyc is a node.js tool.
I view this as both a bug and an enhancement request.  The bug is that we should not combine absolute URL's with the local path.  Actually supporting load from URL's is an enhancement.