Unit tests would help reference implementation readability

It's kind of https://github.com/plume-sig/zk-nullifier-sig/issues/72#issuecomment-1950386486, but letting moving forward meanwhile.
I added a test which should be showing that hashing to curve isn't correct (at least on signing; before #84 ). As there's many conversions and different formats/endings the test isn't super readable, so it's quite probable I just messed up along the way. This is quite easy to check if anybody would add a hash_to_curve test which a current implementation would pass.
Anyway this/such test is a good contribution to the code. Mine was born when my implementation yielded a signature (V1) different from the current one using the same inputs which correctness I double-checked. (Yep, it's quite probable I messed up implementation and that test; it's enough to have just two errors for this. On the other hand it's god enough signal to dig into this.)

Hey, we thought they were correct because JS and Rust outputs agreed. Can you add logging and check where in the process your numbers diverge?

Yes and no. Current implementation (and their output) were introduced before hash_to_curve spec was finalized IIRC. That's why it's the place I'm testing after verifying my inputs. So it wouldn't be a surprise that those implementation do match and are "correct" w.r.t. some interim hash_to_curve spec.
If it's the case then it's possible to say PLUME will be using that hash_to_curve variant and call that the day; but I believe implementors and other participants/users won't be very happy with an approach like this.

And also it's the reason why I believe a hash_to_curve unit test would be beneficial for the project.

Yes and no. Current implementation (and their output) were introduced before hash_to_curve spec was finalized IIRC. That's why it's the place I'm testing after verifying my inputs. So it wouldn't be a surprise that those implementation do match and are "correct" w.r.t. some interim hash_to_curve spec.
If it's the case then it's possible to say PLUME will be using that hash_to_curve variant and call that the day; but I believe implementors and other participants/users won't be very happy with an approach like this.

Oh interesting, what changed between the draft spec and the final spec? I thought they were the same but might be mistaken. Yeah it's possible we are not up to date or have an error, I'm happy to update to the latest version of things and a unit test sounds great.

Seems that all implementations are using the same function in the end of the day. But I fail to see why they have so much layers before they actually call it (arkworks flavor do conversion, and still there's complex twists which makes everything difficult to read and doesn't leave me with any sense of purpose).
I mean I feel like it's likely the thing should be ok, but this is a thing that demands unit testing of it. Should be ok, since it seems improbable that any conversion error would be reproduced in JS.

Seems that all implementations are using the same function in the end of the day. But I fail to see why they have so much layers before they actually call it (arkworks flavor do conversion, and still there's complex twists which makes everything difficult to read and doesn't leave me with any sense of purpose).
I mean I feel like it's likely the thing should be ok, but this is a thing that demands unit testing of it. Should be ok, since it seems improbable that any conversion error would be reproduced in JS.

You said you saw an inconsistency, what exactly was that in what program, inconsistent with what result? The ark works was an early proof of concept, I'm happy to mark it as deprecated.

hash_to_curve is ok, I checked that another way; so the point of this one is just quite confusing approach, which would be much cleared with unit tests.

You said you saw an inconsistency, what exactly was that in what program, inconsistent with what result? The ark works was an early proof of concept, I thought the consensus was to hazard that and leave it alone?

Oh... Than it's maybe would be a good idea to move it to it's own repo and archive it.
Both implementations has overlays for the hash_to_curve for some reason. And I use plume_arkworks as the reference, and its overlay has compute_h(pk, msg) which basically do nothing but calls another helper (with a more helpful order of arguments) which in the end of the day hashes [msg, pk] so it took from the correct order so the value checks.

Ok this issue il just mark the same as #24 then?

I don't think so, since I like to read it "we need a set of verified test vectors which would any implementor use, and which would show that their implementation is correct". At least I consider that practice as best. It can be read as a weaker thing "while we have no test vectors let's try different implemetations to approve each other". But it doesn't say anything about internal testing, so at extreme it could be read as "we don't need unit tests if integrational of different implementations match".
And this one about the fact that there're some places in current implementation working with which would be really facilitated by the presence of unit tests.


WIP: Jq rule composition

What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist

[ ] I have self-reviewed this PR
[ ] I have added tests that prove the feature works or the fix is effective

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.bobra200 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Reset db on wallet reset

Abstract
Reset db on Wallet::reset
This is supposed to be handled by loadFromDisk, but perhaps on some edge cases it will not trigger
Testing

Idk this is just a guess

I don't think this is what was happening in the report


Quick switch fonts for every edit pages.

I write mark down, HTML and python. All three are use Consolas font, but I really want every page could using  different fonts, and can quickly switch in the bottom of the editor. Just like switching the compiler. I think this function is lacking in VSCODE. VSCODE is a good editor, but every time when I want to switch the font I would go to changes in the panel.
Sorry,My English is poor..but I think you will know it.

@inf1nityhhd You can use language specific settings in your settings.json:
"editor.fontFamily": "Consolas",
"[html]": {
  "editor.fontFamily": "Hack",
},
"[markdown]": {
  "editor.fontFamily": "Arial",
}


docker login

when we push the container image to docker hub, we are not prompted for credentials.
We have to use "docker login" to be authenticated.

Solved with commit ce1f30a20f2f92083bb154e3e6e9ad74e8248479


Provide journals in logging output (raul/f3 request)

Every Lotus instance contains a set of json-formatted journal files.  These are sort of like an execution trace for that Lotus.  The journal json files are located in $LOTUS_HOME/journal/.  (If $LOTUS_HOME is not set, it defaults to ~/.lotus for the user who started lotus, typically ubuntu.)
This issue is to track F3's request that these get pumped into wherever we are directing all the other logs to help them debug.  Not sure if the bot itself should do this or if we write a separate daemon that users inotify to decide when to ship the log out.
FYSI here's a sample line from a journal file:
{"System":"sync","Event":"head_change","Timestamp":"2021-04-07T20:15:51.881298228Z","Data":{"From":[{"/":"bafy2bzaceaz7ra62nv56uj3c4xscrvsfwc5hmfhequsvu3ob46jzrhhf5o7fi"},{"/":"bafy2bzaced46sac3pc4j4zqqo7hjkbzcacu2gje4qr7ja6537z6yidvrjhgrk"},{"/":"bafy2bzacebltiv6nuzfhivjj763ev5m4362vwqksoluog4e46bjbne7s67irs"}],"FromHeight":650020,"To":[{"/":"bafy2bzacebj3th5cesgalh6gs7272ervhtg5bjmgn6y7z4fpllsuepmt7y7fw"},{"/":"bafy2bzaceasknps4yfak3dzmsd4zuln7lor7qqe5f6v5zroqg2gwehmofx56k"},{"/":"bafy2bzaceauxjxsuuap26k575h3w2b5kmlno2chz733w7cfofvhjy2iw5iasq"},{"/":"bafy2bzacebtkogvidotfc3ns5k5jdk7ri4qbnnoih7pypxznirlil2dzwmyhq"},{"/":"bafy2bzacedmehtt5ezuvf5d7wrwv35j4bwmvtttpsjsvx2lakv7isuw6qpetq"}],"ToHeight":650602,"RevertCount":0,"ApplyCount":577}}

is there any way to get these through the API?
otherwise, this will be possible potentially through logz.io if the journal is being read to logs in the infra deployment, but otherwise is inaccessible to the dealbot since it'll live in the lotus container rather than the dealbot container.

If you're instantiating a lotus node programmatically, you can override the journal through DI with an alternate implementation that you control.
However, for our purposes, just shipping the journals to ES is enough. If the dealbot data contains the deal CID, that's enough to correlate.

I am pretty sure we are not instantiating the node programmatically, but rather grabbing the api key from a normal lotus node running on the same machine and communicating of the normal Lotus JSON-RPC API.
That said -- the dealbot only contains the Payload CID (sometimes called Data CID) -- we may need to make a separate ticket to add tracking for the Deal CID (aka storage deal proposal CID right?)

If you're instantiating a lotus node programmatically, you can override the journal through DI with an alternate implementation that you control.

@raulk  Could we do this in Lotus instead?  Simplest implementation I can think of is an API call like RegisterJournalListener that lets the caller register a function that receives every message being written to the journal.  Dealbot would then use this hook to write the journal entries into logz.io or any other log aggregator.
This would allow the Dealbot project to just run vanilla lotus rather than patch the Lotus source to change the dependency injection.  Doesn't it feel like a better separation of concerns between Lotus and Dealbot?

I think the goal long term is to not need an API (this is internal debug info and not something a lotus client will regularly need permissions to get).
Rather, we expect that the lotus container k8s setup would be able to be run such that journal logs are piped to a log aggregator. That should be doable fully at the terraform level, and is an ask for infra, not an ask for lotus API.

@mgoelzer - is this needed to be surfaced in the dashbord? or is this for diagnostics and okay to be surfaced through log aggregator, as suggested in this issue?

I think log aggregator only is fine, but let double check.

Raul, has confirmed.  surfaced through log aggregator is what we want.

As of a few days ago, these are being sent now to logz.io.  I think we can likely close this issue. @raulk maybe you can confirm this is usable.

Is this what's causing the data limits to be exceeded?

Pretty sure this is good to go, closing the tracking issue out. Can reopen as needed.


Chat example seems broken

I got an error while testing the chat example.

When the "EventFromRecord" method is called, the block type is invalid.
  func EventFromRecord(ctx context.Context, dag format.DAGService, rec thread.Record) (*Event, error) {
	block, err := rec.GetBlock(ctx, dag)
	if err != nil {
		return nil, err
	}

	fmt.Printf("Type: %T", block) // Added for debug purpose. *cbornode.Node is printed

	event, ok := block.(*Event)
	if !ok {
		return nil, fmt.Errorf("invalid event")
	}
	return event, nil
  }

For debug purpose, I added the following line to test the type
fmt.Printf("Type: %T", block)
which returns *cbornode.Node while block.(*Event) was expected.
Maybe the method "EventFromNode" should be used instead of "EventFromRecord" ?

Hey @abour, thanks for the report. I'll take a look tomorrow.

@abour, here's a fix: https://github.com/textileio/go-threads/pull/178


[SCB-889] add SCBEngine reference to BootEvent

Coverage increased (+0.004%) to 86.184% when pulling 56ef96b0af72d45af742fe6ad5b0ea865ad3cb10 on wujimin:BootEvent-ref-SCBEngine into be33086dbde190ceec425aeea3ae5662fbf6b633 on apache:master.


About the heda_tilt in manipulation part

Hi,
Thank you very much for such a good open source work. Due to my limited knowledge in this area, I have few questions when reading your code.

Do all the pose and point in the center_robot/pick/place output are relative to camera coordinate system?

I wan to use the ok-robot-manipution in our robot controller project, but I have a question about the head_tilt parameter.
As this parameter is not always included by the camera intrinsics, and the Anygrasp code didn't use it to generate a grasp pose originally.
Does there any formula to help understand how heda_tilt  is applicated in your work, and if our camera doesn't have the heda_tilt parameter, how could we to alter the manipulation part code ?

What does crop'flag mean and what is its purpose to use?

Thanks again!  Looking forward to your reply.

When using the example_data, you scaled the depths from the depth image and scaled the head_tilt using head_tilt / 100, but when using the communication, you left out the scale process，could you tell the difference between them please? Thank you very much!

Hi yu3jun,

Yes, The poses and points for all three functions are in camera coordinate frame.
head_tilt is the camera tilt [radians] in vertical direction. It is not exactly a camera intrinsic parameter, we get this information from camera state obtained from hello stretch apis and send it along with intrinsic parameters from robot side.

Re scaling - Essentially the colors should be in 0-1 range, depth should be in meters and head_tilt in radians. We scaled the colors, depth and head_tilt as we were saving the data in different scales.

It was not used in the final version but initially we attempted to crop out just the object point cloud and send it to anygrasp code [instead of sending the whole image point cloud] whenever no poses were found as a failure correction mechanism. The crop_flag is to show whether this mechanism is being applied or not. However, we found out that this is not improving the performance significantly. So we removed this flag in the final version of code.

let us know if you have more questions,

Thanks for your patient answer! Thank you very much!

Why head/100 instead of head * π/180 ?


⚠ Tyre Pharmacy has degraded performance

In d50c013, Tyre Pharmacy (https://tyrepharm.ru/) experienced degraded performance:

HTTP code: 200
Response time: 5820 ms

Resolved: Tyre Pharmacy performance has improved in 0147c5f after 9 minutes.


[TEST] Fix flaky test_recovery_from_im_deletion

What's the test to develop? Please describe
Test case test_recovery_from_im_deletion is flaky on master(2/10 failures) and v1.5.x (3/10 failures) in recent build
All failure due to
kubernetes.client.exceptions.ApiException: (0) Reason: Handshake status 500 Internal Server Error -+-+- {'content-length': '51', 'content-type': 'text/plain; charset=utf-8', 'date': 'Thu, 29 Jun 2023 01:58:33 GMT'} -+-+- b'container not found ("longhorn-testvol-bjhqea-dep")'

and happened at the same place
# Step7
        pod_names = common.get_deployment_pod_names(core_api, deployment)
        wait_pod(pod_names[0])

        command = 'cat /data/test'
>       to_be_verified_data = exec_command_in_pod(
            core_api, command, pod_names[0], 'default')

test_ha.py:3381:

Describe the items of the test development (DoD, definition of done) you'd like

[ ] Fix and verify on pipeline

Additional context
N/A

Test case test_recovery_from_im_deletion has continuously passed in the last 3 builds in master, v1.5.x, v1.4.x, and v1.3.x branches.


Add SQLite3 Input Stream

As described in Pull Request #55, add seq.sqlite3(arg, sql_statement) to input streams API. arg can be any of

Connection string
SQLite connection
SQLite cursor

The input stream comes from the sqlite3 execute(sql_statement) function which returns an iterable of tuple rows

Resolved by #55


Add a header image to readme

Discussed in https://github.com/spenserblack/actions-wiki/discussions/29

Originally posted by jcbhmr March 17, 2023
Something like this? Might want to make the filenames actually line up, but the quick "what does this action do" is nice. even if there's already a title, an image like this clearly gets across what this action does and would be a good addition IMO

it's sort of like a blog post; they are better when they have an image, even if the image is only tangentially related to what the content is. I mean, just look at this: https://web.dev/blog/

wtf are these images?! they have almost nothing to do with html or js, and yet it's still better than just a plain text post. it helps break it up, and adds some "oh yeah that one" sort of like a profile picture for the project. it's like a "meme" in the truest technical sense of the definition.

I'm debating if this should be a header (on its own line), or adjacent to some text, like the features list.

imo <div align=center> with an image in it looks pretty good


External css files are not getting bundled into main.css - Prod build - latest angular-seed

Hello,
I am trying to get the latest angular-seed code (last sync up was on Oct 3rd)..  for some reason, external scripts are not getting bundled into main.css file with Prod build. It was working fine before
Has anyone tried to integrate external scripts with the latest angular-seed code?

I'm submitting a ...  (check one with "x")
[X ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior
I am using external css files - PrimeNG and Ultima, these files are not getting bundled into main.css with the latest Angular seed code

Expected behavior
External scripts are bundled into main.css

Minimal reproduction of the problem with instructions
Using the latest angular-seed , add external scripts and see if it is getting bundled into prod build main.css

What is the motivation / use case for changing the behavior?
Getting the latest angular-seed code

Please tell us about your environment:
Chrome, Windows 10,

Angular Seed Version: 2.0.X
2.1.0

Node: node --version = 6.9.1

Would you share the content of your project.config.ts file? You need to declare the external CSS files there. In case you're using third-party components, their CSS should be automatically bundled if they have proper script references to it.

Please find the project.config.ts code below..
This was working before with the code I sync'd beginning of this month, I am having issues with latest seed code
import { join } from 'path';
import { SeedConfig } from './seed.config';
/**

This class extends the basic seed configuration, allowing for project specific overrides.

As soon as I revert back the build.html_css changes , css files are getting bundled

What changes did you do there?

I have reverted back build.html_css changes to Sep10 commit..
https://github.com/mgechev/angular-seed/blob/791b8103f500c18da3eea7c48ee0ebf7be5d501c/tools/tasks/seed/build.html_css.ts

Yesterday Valentin fixed external css function.. I will try it again..
https://github.com/mgechev/angular-seed/commit/e877f6c482ec0b68ef5076b174d2cfbe669f9cc6
if you look at the fix, getexternalcss was processing scss files, that has been fixed.. hopefully it will work for me now.. I will keep you posted

Thanks to Valentin.. external css is getting injected now.. but couple of things I have noticed

main.css is not a minified version.. looks like a regular css file
build.fonts is removed (not sure why) in the latest prod build section of gulpfile.ts - because of which external fonts are not getting copied to dist/prod folder.. I have fixed it in my local version.. now external fonts are getting copied in my local version

Thanks
SK


Fix click focus and transform overlap for expandable row chevron

Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:
RSP

Just going to merge into the original PR actually


⚠ Jenkins Plugins Artifactory has degraded performance

In 890bb14, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1176 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 3052e34 after 16 minutes.


Badge notifications spec

Proposal to bring badge notifications into Windows App SDK.

For status checks on the develop branch, please use TransportPackage-Foundation
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=57248)
and run the build against your PR branch with the default parameters.
For status checks on the main branch, please use microsoft.ProjectReunion
(https://dev.azure.com/ms/ProjectReunion/_build?definitionId=391&_a=summary)
and run the build against your PR branch with the default paramters.

There is no need to end the folder name with spec (BadgeNotificationSpec) as this is already under the "specs" directory. Other spec folders don;t append "Spec" to their folder name (ex, AppLifeCycle, AppNotificationBuilder)

Closing for now. I will reactivate when I get some focus time to continue this work 😊.


A11y_AzureDataStudioExtensionAzureSQLMigration_Migratetoazuresql_MigrationMode_ScreenReader: ORCA screen reader is unnecessary announcing text unselected when we navigate to "Resource group" and "Azure database migration service" dropdown.

Actual Result:
ORCA screen reader is unnecessary announcing 'text unselected' when we navigate to "Resource group" and "Azure database migration service" dropdown.
Expected Result:
ORCA screen reader should not announce unnecessary 'text unselected' when we navigate to "Resource group" and "Azure database migration service" dropdown.
Git hub Tags:
#A11yTCS; #A11yMAS; #A11ySev2; #DesktopApp; #Benchmark; #ORCA; #WCAG1.3.1; #FTP; #SH-AzureDataStudioExtensionAzureSQLMigration-Linux-Jul23; #SQL Migration extension for Azure Data Studio; #Linux; #Element:Dropdown;
Environment Details:
Application Name: Azure Data Studio extension 'Azure SQL Migration'
Operating System: Ubuntu 20.04.2 LTS
Azure data studio 1.44.1
Azure SQL Migration v1.4.8
Screen Reader: ORCA
Repro Steps:

Install Azure data studio application and open it
TAB till Extension press ENTER key and install Azure SQL Migration extension.
TAB till Respective server and right click. TAB till manage and press ENTER key.
TAB till Azure SQL Migration and press ENTER key. TAB till "migrate to azure sql" and press ENTER.
Select start new session and fill all the data and press ENTER on next button.
Select the respective databases and ENTER on next button.
Fill all the necessary details and press ENTER key on Next button till "Azure database migration service" page appears.
Start ORCA screen reader. TAB to "Resource group" and "Azure database migration service" dropdown and observe the issue.

User Impact:
The screen reader users will get incorrect information and will get confused whether the control is selected or not.
Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.
Attachment:
23898_Issue.webm

@PoojaNamde , I checked the issue in Ubuntu 20.04. I do not see it now. Can you verify if the issue is still there.

#Closed; #Regressed:09-11-23;
Verified this issue in the Azure data studio 1.46.0 version. Issue is fixed hence closing the bug.


Atomic Design Workflow

Helpful instructions and tips for converting existing components to Atomic Design Organization
Install CF Sandbox

Follow the installation instructions.
Click around to ensure the local server is rendering the sandbox correctly.
Stop the server (ctrl+c).

Link your component
1. Navigate to the root of your component (not the CF repo)
cd capital-framework/src/cf-pagination
You can now run an npm script from the root of the CF repo.
cd capital-framework
2. Run the NPM Link command
npm link
npm run cf-link
To add your component to this command, edit the script in package.json
3. In a new tab navigate to the root of CF Sandbox
cd capital-framework-sandbox
4. Run the component NPM Link command
npm link cf-pagination
Run the same command from the root of the Sandbox repo.
npm run cf-link
Again, to add your component to this command, edit the script in this repos package.json
5. Run the build command
npm run build
6. Start the server and check out the changes
npm start
When you’re done working on or reviewing a component, run npm unlink component-name && npm install component-name
Building your component

In CF Sandbox create a new preview branch, start the server, and adjust markup as needed
cd /capital-framework-sandbox
git checkout -b cf-pagination-example
npm start

Checkout the v4 branch of CF
cd /capital-framework
git checkout prerelease-ver-4

Create a new branch for your atomic component
git checkout -b atomic/pagination

Save your changes

When you save, CF Sandbox will build the files (may still need a manual page refresh)

Code organization
Both prefixing and organizing elements by their type is the easiest way to keep track of them. All elements should be prefixed by the first letter of it's type (ex m-pagination) and placed in a corresponding directory (ex. /src/molecules/pagination.less). To save yourself the trouble of moving things multiple times, we found it easiest to break up the component in it's top level stylesheet, then move each class to it's appropriate sub-directory.
Questions
Feel free to ask questions or post your own tips here or in the Atomic Design channel.

Ans and I discussed what should and shouldn't be updated to an atomic element during the workshop today. The guidelines we came up with are:

If it can't stand on it's own as an element, for example a paragraph or list item have minimal styles added to them and don't need a class name every time they are used, but a button is more complex and so it should be atomized.
If it's not a utility, utilities are adjustments and helpers, not elements that can stand on their own, and don't need to be atomized (another example are the layout styles, though we discussed those should probably get a u- prefix).

Does everyone agree, disagree, fall somewhere in the middle? I'm sure we'll discover more instances as we move along, so feel free to discuss here as that happens.

Those rules make sense on their face. As you say, I'm sure we'll come across things that are still not straightforward as we go, but we can discuss them when that happens.
I am curious, though, to know which layout styles you think should probably get a u- prefix.

Nearly everything, other than the Hero and FCM it's all layout utilities and very little is able to stand out as a component.

I've updated both of my PRs (https://github.com/cfpb/capital-framework/pull/326/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R29 and https://github.com/jimmynotjim/capital-framework-sandbox/pull/11/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R14) to include an automated NPM Linking script. Once those are in, it'll be easy for everyone to add their own component to the scripts and remove a lot of the manual linking pains.

Kim brought up two concerns in chat, that we should probably discuss a bit before (and during) Thursday's meeting.

How do we handle dependency changes (ex who's responsible for updating all the other components button markup, how do we keep the scope tight in the buttons PR)?
What's the priority order for updating components (ex bottom up or easiest to hardest)?

How do we handle dependency changes (ex who's responsible for updating all the other components button markup, how do we keep the scope tight in the buttons PR)?

I think it makes the most sense for the person updating a component to also update any other component that depends on it to use the new class names.

What's the priority order for updating components (ex bottom up or easiest to hardest)?

I'm not sure it matters, if we're going for a bit, all-at-once release of v4.

In a case like changing buttons or grid, once those get changed a lot of other stuff changes with it. Since the markup is going to be changing a lot, it probably makes sense to get stuff like atoms and utilities in first so that people using them in organisms can properly test and account for the new changes. Otherwise, the work involved with things like buttons and grid is going to hold them up so that they don't get merged.

We've completed this work.


Statistical report for constant time compare tests?

Hi,
I'm the maintainer of Credential. We're currently trying to harden our constant time equality check in Credential, and we're looking for a good statistics test to ensure that our timing is constant enough to thwart timing attacks.
Your experience and feedback would be very useful. Please take a look at this proposed constant time string comparison. I'm especially interested in producing a test suite that can guarantee statistically significant constant time equality comparisons, and I believe such tests would be useful to node.bcrypt, as well.
Thanks!

You should check out this module: https://www.npmjs.com/package/scmp
Otherwise, posting on stack overflow will be better, not here.

My assertion is that none of our libs are complete without a statistical proof that our constant time comparisons are constant enough to thwart actual timing attacks. See Crosby et al:

"We have shown that, even though the Internet induces significant timing jitter, we can reliably distinguish remote timing differences as low as 20 µs. A LAN environment has lower timing jitter, allowing us to reliably distinguish remote timing differences as small as 100 ns (possibly even smaller). These precise timing differences can be distinguished with only hundreds or possibly thousands of measurements." Crosby et al., "Opportunities and Limits of Remote Timing Attacks"

So if we're going to implement libraries and call them secure, we need to prove it in our test suites. Wouldn't you agree? With Credential, I don't just expect people to trust that it's secure. I'm putting my money where my mouth is..
Because what we do in our libraries potentially impacts the personal security of millions of people, I think it's our responsibility as security library maintainers to provide assurances that we take these things seriously.

Strictly speaking, hash functions like bcrypt and scrypt aren't "vulnerable" to timing attacks. I may update the comparison function at some point, but a timing attack would only reveal information about the hash itself and not the values inside since the comparison tests one hash against another. Does that make sense?
Take a look at http://security.stackexchange.com/a/46215 for more, and better IMO, information.

That comment is the result of a complete misunderstanding about how timing attacks work. Timing attacks don't have to guess a correct password to achieve a breach. They only need to find a string that produces the same hash. In other words, even finding a hash collision (not the user's password) can give an attacker access to the account in question, and if they find a colliding hash, they have a relevant chance that the string they found is the user's password, which matters not at all for that one system, but does have the implication that the attacker is one step closer to gaining access to that user's other accounts on other systems.
Timing attacks work in a similar manner to how playing hangman works, but they're not about guessing the user's password. They're about finding a string that hashes to the same string as the stored hash -- which is easier than finding the real password.
In other words, timing attacks are about tricking the system into letting you into a particular user's account, regardless of whether or not you've actually found the password.
It's really very simple: If you can find a string that results in the password hash library returning true, you can use that string to get into the user's account, even if that string is not the user's real password.

They only need to find a string that produces the same hash.

That's called a first-preimage attack. It would be astonishing if bcrypt was vulnerable to first-preimage attacks, and in such an eventuality, the only responsible action would be to abandon it entirely; a constant-time hash comparison algorithm would be worthless. And due to the nature of how one-way hashes work, a timing attack does not aid in finding a preimage -- that's where you may be getting confused.
For more discussion of this topic, see https://github.com/codahale/bcrypt-ruby/pull/43.

Thanks @jfirebaugh. I'm not a security professional, but I'm very interested in getting this right: not just getting it right, but proving that we've thought these considerations through and put all our assumptions to the test.
If it's worth putting constant time equality into our libraries, then it's also worth proving that they're constant. Otherwise, we should use === and be done with it in order to reduce the complexity (read: potential attack surface) of the libraries.
If it's not worth using them, then we should be able to easily prove that, too. IMO, the best proof is a user-reproducible brute force vs timing attack demo in the repository, or linked from the library documentation.

I really appreciate all the great information in this thread. Thanks a lot. :)


Refactor Raylib-Wrapper Utility for Better Extensibility

We are in the process of refactoring the raylib-wrapper utility, which reads the JSON raylib-api generated from raylib-parser and outputs the raylib Nim module. The goal is to make the code more modular and extensible to allow generating Nim wrappers for other raylib projects as well. This issue will track progress for the refactor and related tasks.
Tasks:

[x] Split logic: Separate the preprocessing of the API (converting C types to Nim, applying transformations to names of functions/enums/objects) from the logic responsible for generating the final output.
[x] Refactor output generation: The second part of the code that generates the final Nim output has been rewritten for better cleanliness and extensibility.
[x] Rewrite preprocessing: Refactor the part that handles the API preprocessing, making it modular and easier to maintain.
[x] Add support for other raylib projects: Extend the wrapper generator to support Nim wrappers for additional raylib-based projects.
[x] Documentation: Document the refactoring and how to extend the tooling, allowing others to contribute to wrapper generation.

Additional Notes:

The code should be easy to extend with other raylib projects.
Clear documentation will help maintain long-term utility and ensure others can contribute easily.

Ask for volunteers in the forums for wrapping raygui/rres/rpng/physac/etc.


feat: Add support for RemovalPolicy in config

Closes #304
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: 69a7de9c43c1940e80bb1881d81955564bfb5a40
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: 022b5b30c85d6b817d903d906449f32bfcb191c8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: 2d38d6fc506b2052fa81560e32322ec30595d649
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


macos-install.sh: remove install brew-cask

As of Release v0.60.0 · caskroom/homebrew-cask:

it is no longer necessary to brew install brew-cask

Doing so will in fact return an error.

Resolve #704 partially


⚠ Bofrost.de has degraded performance

In 6443af9, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1325 ms

Resolved: Bofrost.de performance has improved in 1c0b795 after 1 hour, 46 minutes.


Compiler crash when building Atomics on Windows

Describe the bug
The compiler crashes when building the Atomics module from apple/swift-atomics package.
Assertion failed: Loc.isValid() && "Can't get file characteristic of invalid loc!", file D:\a\1\s\llvm-project\clang\lib\Basic\SourceManager.cpp, line 1473
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace.
Stack dump:
0.      <eof> parser at end of file
 #0 0x00007ff6c9a04345 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x4d14345)
 #1 0x00007ffd1c16d88d (C:\Windows\System32\ucrtbase.dll+0x6d88d)
 #2 0x00007ffd1c16e761 (C:\Windows\System32\ucrtbase.dll+0x6e761)
 #3 0x00007ffd1c1700c1 (C:\Windows\System32\ucrtbase.dll+0x700c1)
 #4 0x00007ffd1c1703f1 (C:\Windows\System32\ucrtbase.dll+0x703f1)
 #5 0x00007ff6c989cf72 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x4bacf72)
 #6 0x00007ff6c9844ce8 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x4b54ce8)
 #7 0x00007ff6c5ef7a29 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x1207a29)
 #8 0x00007ff6c5f12141 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x1222141)
 #9 0x00007ff6c5f1934f (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x122934f)
#10 0x00007ff6c84ef776 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x37ff776)
#11 0x00007ff6c84e377e (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x37f377e)
#12 0x00007ff6c84e0921 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x37f0921)
#13 0x00007ff6c850a083 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x381a083)
#14 0x00007ff6c822664c (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x353664c)
#15 0x00007ff6c83a1ef4 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x36b1ef4)
#16 0x00007ff6c820c795 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x351c795)
#17 0x00007ff6c820c5a8 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x351c5a8)
#18 0x00007ff6c81f5c2c (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x3505c2c)
#19 0x00007ff6c81f2e3a (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x3502e3a)
#20 0x00007ff6c99e4994 (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x4cf4994)
#21 0x00007ff6c99e4b7f (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x4cf4b7f)
#22 0x00007ff6c99e454f (C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\bin\swiftc.exe+0x4cf454f)
#23 0x00007ffd1c12268a (C:\Windows\System32\ucrtbase.dll+0x2268a)
#24 0x00007ffd1f487974 (C:\Windows\System32\KERNEL32.DLL+0x17974)
#25 0x00007ffd1f8ba2f1 (C:\Windows\SYSTEM32\ntdll.dll+0x5a2f1)

Steps To Reproduce
Steps to reproduce the behavior:

Clone https://github.com/apple/swift-atomics;
Change directory to swift-atomics;
Run swift build.

Expected behavior
The Swift package should compile successfully.
Screenshots

Environment (please fill out the following information)

OS: Windows Server 2019 Datacenter (1809)
Swift version: 5.6.2
Visual Studio: Community 2019, 16.11.18

Additional context
Regarding to #60534, you should first run mklink /D C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\lib\swift\clang C:\Library\Developer\Toolchains\unknown-Asserts-development.xctoolchain\usr\lib\clang\13.0.0 to correctly set up Clang headers.

Anyone to provide some hints into the problem👀 Blocking Atomics also means blocking NIO and some other libraries as well.


feat(nexus): change create_v2 gRPC to have separate name and uuid

Add a separate name field to the CreateNexusV2 gRPC, which is a
freeform string used directly in the Nexus structure in Rust instead
of being derived from the uuid field by prefixing "nexus-" to it.
Fixes CAS-1007

bors try

bors merge


Add new custom http.conf above includes for NPM-generated files

Added a new clause for custom http_top.conf above the include clauses for NPM-generated files. Allows for more flexibility with adding custom nginx .conf files to NPM
Use case: adding a configuration change needs to be present before other custom configuration files are called and reference configuration from the custom http_top.conf file.
Example: add a new log_format in http_top.conf, then referencing it in a access_log clause in server_proxy.conf.
Could also simply move the existing include for http.conf, but opted not to in case it breaks existing uses of http.conf.

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-850

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-850

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-850

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-850

I'm ok with this as there doesn't seem to be a nicer way of doing this yet. Definitely looking to improve this global configuration stuff in future


select text addition and logic to countselected

I added selectAllText and deselectAllText
I also added logic to countSelectedText to detect singular

#1529

Hi,
Do you know when the changes on GitHub get reflected on https://cdnjs.com/libraries/bootstrap-select/1.11.2?
Thanks!

It'll be released with 1.12.0. Most likely this week.


How to change backgroundColor while children are rendering.

When the children within pager are loaded/rendering the background color of the content is white, I need to change it as my interface is mainly black.
I tried to change the color using backgroundColor: 'black' in style prop but it doesn't seem to work.

You need to change style for each child view https://github.com/callstack/react-native-pager-view/blob/master/example/src/BasicPagerViewExample.tsx#L39

You need to change style for each child view https://github.com/callstack/react-native-pager-view/blob/master/example/src/BasicPagerViewExample.tsx#L39

I tried to change the color of the child as mention above using style={{ backgroundColor: 'black' }} and it doesn't seem to have any effect

Could you provide a code snippet ? Or can you compare your code with this example ?  https://github.com/callstack/react-native-pager-view/blob/master/example/src/BasicPagerViewExample.tsx#L39

Could you provide a code snippet ? Or can you compare your code with this example ? https://github.com/callstack/react-native-pager-view/blob/master/example/src/BasicPagerViewExample.tsx#L39

The code is similar to the example above , the issue can be observed when the app just starts, or child list are re-rendered,
I think it is not related to child views at all, it is something related to how the component is displayed when it is just about to render its children, but I can't find the source code where the background color of the 'default view' is set

Child views are added dynamically ?

Child views are added dynamically ?

Yes, the entire list is sometimes replaced with a new one, and for a portion of second the background becomes white

Child views are added dynamically ?

Is there any solution to changing the color of the flickering background ?


User objects as Authors

When adding an author to an artifact, the system should look for users who match the author and allow a SEARCCH user object to be added as an author. Or -- allow the submitter to choose an existing user as an alternative to inserting author information.

Shouldn't the referenced user be able to veto this before it happens?  I would suggest an invite that the target user can either accept or reject.  Admins maybe can do it.
Either way, I think the first step is simply replacing one author with the current user making the changes.

I'm more in favor of invites and pushing as much onto the community as possible. Admins should have the ability but the primary responsibility for creating complete records ought to be the community.
I don't think that replacing an author with the current user makes sense. There is always the possibility that someone other than the author owns the record. E.g.,  I've imported a ton of artifacts and am the defacto owner, but I am not the author on 98% of the artifact records that I own.
I look at this feature as similar to the tagging feature in Facebook photos. Maybe we allow the importer (person or automated) to tag an existing user as an author. Give users an option to allow automated tagging or requests for tagging that must be approved by the user. Either way, push an email to the user telling them they've been tagged as an author or have a tag request to approve.


Solve the current problems with authentication and support OAuth2

as proposed by pjropachev on the official api issue
From my point of view the following several things that should be done:
Solve the current problems with authentication and support OAuth2 (support Basic Authentication access for EWS ending October 13, 2020).

I'm just starting to look into what needs to be done for my java app to support OAuth2. Seeing this message makes me believe that it hasn't been addressed yet. Is that correct?


RS-Coder improvements

Improve ReedSalomonCoder class by adding this functions:

Split coder into two seperate classes, file preparer and coder,
bit stream to 'Gf2Polynomial` parser,
Split GenPoly,Coder and Decoder into three seperate modules

[ ] Add raw string encoding (support for providing raw bits)
[ ] Add support for formating bit values (from int64 to bit string)


[hmac,dv] Fix clearing of wipe_secret_triggered flag

This decouples the clearing of the wipe_secret_triggered flag from reading the digest CSRs and triggers it where necessary through the smoke sequence. This also captures the previous digest before a transaction is aborted to compare with it in the next transaction.
This should address issue #23930. It is not easily reproducible but we will be able to tell eventually from the nightly regressions and also running a -rx 2 regression locally.

I am merging this as it doesn't affect the FPGA tests. All other tests passed.


Support wsl on windows

Hi,
Would that be possible to support ansible-lint command execution on WSL ?
Thanks

I don't know how if/how ansible-lint can be used with WSL.
Unfortunately  I don't have the setup/time/motivation to test it.
If it is "callable" from the command-line then it should work from within the plugin; I guess.
Any contributions in that regard are welcome though.

I can call ansible-lint from WSL using wsl --shell-type login ansible-lint command. Example:
$ wsl --shell-type login ansible-lint --version
ansible-lint 6.22.1 using ansible-core:2.16.2 ansible-compat:4.1.11 ruamel-yaml:0.18.5 ruamel-yaml-clib:0.2.8

Setting this command to plugin's command field give me Unable to call Ansible Lint error. Any ideas?

@a-besson , @NL9 FYI: The plugin now officially supports WSL. You might want to try it out.


Colab installation Issue

Environment: Colab
I am trying to use run the 0_dl_trainval_data.py file, but receiving multiple errors after. It seems the issue is with the in finrl installation. I initially tried to install using pip install -r requirements.txt, which resulted in
× python [setup.py](http://setup.py/) egg_info did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
  Preparing metadata (setup.py) ... error
error: metadata-generation-failed

Then I tried to downgrade to v65.5 using :
!pip3 install setuptools==65.5.0
with no luck.
Finally, I tried using the recommended way;
!pip install wrds
!pip install swig
!pip install git+https://github.com/AI4Finance-Foundation/FinRl.git

followed by:
!git clone https://github.com/AI4Finance-Foundation/FinRL-Meta
%cd /FinRL-Meta/
!pip install git+https://github.com/AI4Finance-LLC/ElegantRL.git

Even after all that, I got
No module named binance
then ran pip install python-binance  with success. Re-runing the file led to;
No module named Ta-Lib which I tried to install using;
#install talib
!wget http://prdownloads.sourceforge.net/ta-lib/ta-lib-0.4.0-src.tar.gz
!tar xvzf ta-lib-0.4.0-src.tar.gz
import os
os.chdir('ta-lib')
!./configure --prefix=/usr
!make
!make install
os.chdir('../')
!pip install TA-Lib

With no luck.
Is there something I could be doing wrong?

using pip install ta-lib==0.4.19 , i fix this


Fix getFlowVersion

Fix getFlowVersion to work with the lastest Flow CLI.
Fixing the issue reported here https://github.com/onflow/flow-js-testing/issues/233

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

I tried to do a PR here https://github.com/onflow/flow-js-testing/pull/235 .
Sorry if I didn't respect some standards or rules, I'm not used to do PRs on open source repo.
Also I was not able to run tests locally.


Code not working has errors looks like classes/files are missing please help

Code not working has errors looks like classes/files are missing please help

Hi _calendarController not found kindly to help


Google Account Deletion Needs to Clear Group Memberships

Current Google Account deletion doesn't remove the Google groups memberships of the account, and membership.

Marking as closed -- not an issue


How can I fix this?

Found new resource NativeUI in C:/FXServer\server-data/resources//NativeUI
Resource loading for NativeUI failed:
Could not open resource metadata file C:/FXServer/server-data/resources//NativeUI/resource.lua.

NativeUI is not a FiveM resource but a library that you can use to build NativeUI menus in C# projects in for FiveM if you need it and resource.lua is not even the correct name for the FiveM manifest as it's name should be __resource.lua


source ip in the route

for stream going forward by veth0, the related route could be set with source ip of eth0 , especially in multiple interfaces case

@ty-dc  update

https://github.com/spidernet-io/spiderpool/pull/2489 is only for ipv4, for ipv6, maybe it doesn't work in some kernel version.


fix: migrate from k8s.gcr.io to registry.k8s.io

This fix is a part of an umbrella issue https://github.com/kubernetes/k8s.io/issues/4780

@CIPHERTron, please, squash all the commits into a single one and force-push to the same branch.

@CIPHERTron, please, squash all the commits into a single one and force-push to the same branch.

Done! @fidencio Lmk if there are any more changes.

/test
/test-tdx

Hi @CIPHERTron !
This PR breaks our CI because it seems that registry.k8s.io does not contain registry.k8s.io/coredns:v1.8.6. We install k8s with kubeadm, what else should be changed to pull the right coredns image?

/test

Thanks for checking this out, @wainersm!

Hey, I've digged a bit into this issue. The problem @wainersm mentioned isn't caused by the change of the container registry. Actually, k8s.gcr.io and registry.k8s.io contain the same images:
❯ crane ls registry.k8s.io/coredns # or `crane ls k8s.gcr.io/coredns`
...
1.2.2
1.2.3
1.2.4
1.2.6
1.3.0
1.3.1
1.5.0
1.6.2
1.6.5
1.6.6
1.6.7
1.7.0

But the coredns images were moved to coredns/coredns :
❯ crane ls registry.k8s.io/coredns/coredns # or `crane ls k8s.gcr.io/coredns/coredns`
sha256-017727efcfeb7d053af68e51436ce8e65edbc6ca573720afb4f79c8594036955.sig
sha256-8e352a029d304ca7431c6507b56800636c321cb52289686a581ab70aaa8a2e2a.sig
sha256-a0ead06651cf580044aeb0a0feba63591858fb2e43ade8c9dea45a6a89ae7e5e.sig
sha256-b82e294de6be763f73ae71266c8f5466e7e03c69f3a1de96efd570284d35bb18.sig
v1.10.0
v1.10.1
v1.6.6
v1.6.7
v1.6.9
v1.7.0
v1.7.1
v1.8.0
v1.8.3
v1.8.4
v1.8.5
v1.8.6
v1.9.3
v1.9.4

Hey, I've digged a bit into this issue. The problem @wainersm mentioned isn't caused by the change of the container registry. Actually, k8s.gcr.io and registry.k8s.io contain the same images:
❯ crane ls registry.k8s.io/coredns # or `crane ls k8s.gcr.io/coredns`
...
1.2.2
1.2.3
1.2.4
1.2.6
1.3.0
1.3.1
1.5.0
1.6.2
1.6.5
1.6.6
1.6.7
1.7.0

But the coredns images were moved to coredns/coredns :
❯ crane ls registry.k8s.io/coredns/coredns # or `crane ls k8s.gcr.io/coredns/coredns`
sha256-017727efcfeb7d053af68e51436ce8e65edbc6ca573720afb4f79c8594036955.sig
sha256-8e352a029d304ca7431c6507b56800636c321cb52289686a581ab70aaa8a2e2a.sig
sha256-a0ead06651cf580044aeb0a0feba63591858fb2e43ade8c9dea45a6a89ae7e5e.sig
sha256-b82e294de6be763f73ae71266c8f5466e7e03c69f3a1de96efd570284d35bb18.sig
v1.10.0
v1.10.1
v1.6.6
v1.6.7
v1.6.9
v1.7.0
v1.7.1
v1.8.0
v1.8.3
v1.8.4
v1.8.5
v1.8.6
v1.9.3
v1.9.4

Would bump to k8s 1.26.0 fix that? Or perhaps we should be passing the registry and let kubeadm uses its default.

Would bump to k8s 1.26.0 fix that? Or perhaps we should be passing the registry and let kubeadm uses its default.

@wainersm Sorry, I'm not sure what exactly the initial issue was or where this is configured in the fist place. The logs of the CI runs don't exist anymore.

Well this code seems to be gone anyway. https://github.com/search?q=repo%3Aconfidential-containers%2Fcloud-api-adaptor k8s.gcr.io&type=code
But there is a CSI IBM patch with the old registry.


Using pagination can break the subsequent API calls

Describe the bug
When using pagination (cursor or page-based) spotifyAxiosInstance.defaults.baseURL is changed but never set back to it's original state. That causes any subsequent API calls which are not related to pagination to break (wrong url)
To Reproduce
Steps to reproduce the behavior:

Search for tracks using searchTracks
With recieved page call getNextPage()
Search for tracks again
See error (the API call fails because baseURL is different)

    const instance = spotify.getAxiosSpotifyInstance();
    console.log(instance.defaults.baseURL); // https://api.spotify.com/v1
    const page = await spotify.searchTracks('lil');
    await page.getNextPage();
    console.log(instance.defaults.baseURL); // https://api.spotify.com/v1/search
    try {
        await spotify.searchTracks('peep');
    } catch (e) {
        // fails here, result call is https://api.spotify.com/v1/search/search?q=... instead of https://api.spotify.com/v1/search?q=...
        console.log('error!');
    }

Expected behavior
spotifyAxiosInstance.defaults.baseURL is not mutated in pagination so that user can request next page and make subsequent searchTracks calls without errors
Additional context
This is an easy fix. Instead of using getAxiosPageInstance inside page.ts or cursor-based-page-.ts use a method that does not modify baseURL like:
    private getPagingUrl() {
        return this.href.split('?')[0];
    }
// ... //
// inside getPrevious/NextPage
 const response = await getAxiosSpotifyInstance().get(
            `${this.getPagingUrl()}/`,
            {
                params,
            }
        );

To prevent duplication, that method could be placed inside uitls.ts or Page and CursorBasePage could extend a Pagining class that has that method.
Thank you for this awesome package btw :)

Thanks for reporting!!! I saw you forked the repo, are you working on the issue? Or we can assign to another person?
And thank you for using the package :heart:

This is just a simple fix so you should expect a pr tomorrow :)


WinUSBDongle constructor interface mismatch

After updating to the most recent version, my HW1 with WinUSB does no longer work.
At first sight it might be because the interface doesn't match :
class WinUSBDongle(Dongle, DongleWait):
def init(self, device, debug=False):
...
return WinUSBDongle(dev, ledger, debug)
I can get it to work by simply removing the ledger variable from the instantiation. Although I have no idea if that's the right fix.

You're right, I just pushed a fix for that - thanks for reporting.


Getting Syntex error on running Nodejs Server with react APP using babel-preset-react-app 3.0.1

Hi,
I am having an issue when i am running a nodejs server with the create-react-app for server side rendering.
SyntaxError: Unexpected token import
Well it seems that babel is not being added on the server side even with using below code on my nodejs server.
require('babel-register')({ ignore: /\/(build|node_modules)\//, presets: ['react-app'] })
I have managed to resolve this issue by adding the babel-preset-react-app 2.0.1(Basically degrade it from 3.0.1 to 2.0.1)
Just wanted to let you guys know that if it is a bug? or please someone clarify that why it was fixed with the previous version of the preset of the react-app.
Thanks,

This is expected because we removed the CommonJS transform in it. If you use react-app preset for Node apps, please include the CommonJS transform manually in addition to it.


Missing Attribute in exports?

https://github.com/tommikaikkonen/redux-orm/blob/master/src/index.js#L38
Shouldn't Attribute be listed here along with the other fields types? It's the only one excluded.

Yes. Will make a fix. Thanks 👍


Feature/post-selection

Added post selection capability for expectational value tensor networks
A dict must be supplied into a new fucntion called .get_expectational_value_postselect().
I chose to make a new function as to not deviate the original function from the original .get_expectational_value() api. However the post selection coud easily be integrated if we choose too.
The are two fucntions which handle post selection: _measure_qubit_state and measure_qubits_state. Currently these just cap the post selection qubits with |0><0| or |1><1|. Therefore it does not not work with the pytket api atm. They also do not currently work with mid circuit measurment. But I envisage this will not be a huge amount of work.
Finally I added a map which relates the sticky index to the pytket qubit object. This makes it compatible with qubitids other that q[i] for example a[i] now work.
Extra LCU tests have been added.
An extra utils file was created to hold the statevector poste selection functions. These needed to be created to test the tensor network post selection. They will be going to pytket as a PR and will hence be removed when that happens.
I can add some example notebookes if you think this would be helpful.

I wonder if this belongs to this module anymore... In general I start wondering if TensorNetwork class should be a converter in itself or converter should be a separate (factory) function...

Yes I agree that it should probly go somewhere else.

@PabloAndresCQ @NathanCQC I am now happy with this to be merged.


Autofilter Scroll

Is it possible to scroll within the autofilter selection page?  i.e. when i select the autofilter, only a subset of the items in the column are listed and there does not appear to be a way to scroll within that list.

This is fixed on master, so if you install with git clone https://github.com/quantopian/qgrid.git you should get the fix.
I'll close the issue once I create a new release and post it on pypi.


Sdk resolver updates

Add more abilities to SDK resolvers

Return any number of paths (zero, one, or many) in a successful result
Return MSBuild items and properties to add to the evaluation result

Resolves #5239

test?

test?

It's still a draft :-)

/azp run

@rainersigwald @Forgind @BenVillalobos I think this is basically ready for review.  I think I still need to update the XML documentation for the new and refactored APIs, but otherwise this should be ready.

@rainersigwald @Forgind I think I've addressed all the feedback and this is ready to merge.  I'd appreciate a signoff.  Thanks!


[SPARK-18777][PYTHON][SQL] Return UDF from udf.register

What changes were proposed in this pull request?

Move udf wrapping code from functions.udf to functions.UserDefinedFunction.
Return wrapped udf from catalog.registerFunction and dependent methods.
Update docstrings in catalog.registerFunction and SQLContext.registerFunction.
Unit tests.

How was this patch tested?

Existing unit tests and docstests.
Additional tests covering new feature.

Test build #76380 has started for PR 17831 at commit 9edc5e9.

Test build #76380 has finished for PR 17831 at commit 9edc5e9.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76380/
Test FAILed.

Test build #76381 has started for PR 17831 at commit ced8814.

Test build #76381 has finished for PR 17831 at commit ced8814.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76381/
Test FAILed.

Test build #76382 has started for PR 17831 at commit e8615c2.

Test build #76382 has finished for PR 17831 at commit e8615c2.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76382/
Test FAILed.

Test build #76383 has started for PR 17831 at commit 18c0253.

Test build #76383 has finished for PR 17831 at commit 18c0253.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76383/
Test PASSed.

Thank so for doing this, will let me cleanup some of my PySpark notebooks :)

LGTM, since this is just exposing existing functionality I think it makes sense to merge into 2.2 as well, but I'll leave this for a day incase anyone has any comments about this.

Python interface udf.register needs to be consistent with the scala one.

I don't think the Scala API is particularly consistent and I'd argue that this does actually match the current API as much as is reasonable. Looking at the udf.register interface defined in UDFRegistration.scala this does return either a UserDefinedAggregateFunction or UserDefinedFunction when passed in UserDefinedAggregateFunction or a Function0 through Function22. depending on which function is passed in most of the time. We do return Unit for the private registerJavaFunction & when registering a UDF1 through UDF22 . (Also @gatorsmile this doesn't change the scala API, its really just plumbing through the existing Scala API to Python).

In Scala API, we have five different ways to register UDFs. We have to be more careful when changing the external APIs. It makes the users confused if we make the APIs more diverse. I do not suggest to make any further change in Python UDF, until we figure out how to make us easy to add more UDF types.

I agree we need to be careful when making external API changes, but this is a pretty clear win for Python users and it matches the Scala API so I think improving this for Python users shouldn't necessarily block on any unification of the Scala API (is their a plan to improve this or JIRA associated with the planned Scala API changes I could subscribe to notifications on)?

So far, one of the biggest issues is we always assume UDF is deterministic. It could cause incorrect results after query optimization. I am working on a UDF API change to add more types for UDFs. Will submit a PR recently.
We can revisit this PR later.

I feel like that's an unrelated challenge. I'm happy to see other improvements but I'm worried that we will hold up changes for things which aren't happening soon - is there a JIRA for these changes?

@gatorsmile This sounds reasonable but I am not sure if I fully understand your concerns.
If anything this brings PySpark closer to the Scala API. At this moment we have
 registerFunction(self, name: str, f: Callable[[T], U], returnType: DataType) -> None: ...

and we would move to:
 registerFunction(self, name: str, f: Callable[[T], U], returnType: DataType) -> Callable[[Column, ...], Column]: ...

This, as pointed out by @holdenk, matches register API for Function0 .. Function22.
If you're planning breaking changes in the Scala API, it may render this PR obsolete, but we don't commit here to any particular implementation. The only promise here is that registering udf for SQL applications, returns an object, which can be used with DataFrame API.  I believe this sounds like a reasonable requirement for any upcoming API.

I want to know the UDF API change in more details and see if that blocks this PR. I would appreciate if I can check the details.

Test build #76416 has started for PR 17831 at commit bce80c4.

Test build #76416 has finished for PR 17831 at commit bce80c4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76416/
Test PASSed.

@zero323 Will ping you when my PR is submitted. You can then add the UDF changes in Python.

@HyukjinKwon @holdenk Spark 2.2 RC has been out. This PR is not a bug fix. Thus, this PR will be merged to the master branch instead of 2.2. I will submit a PR to show the changes soon.

JIRA: https://issues.apache.org/jira/browse/SPARK-20586 is opened.

Thanks @gatorsmile

I think there is no conflict between #17848 and this. As of 2.2 we no longer return UserDefinedFunction from udf (and we never documented UserDefinedFunctions) so changes will have to be reflected in the arguments of udf and UserDefinedFunction.__init__.

It sounds orthogonal to me as well. LGTM.

cc @viirya too who I believe is appropriate to review this.

Thanks for making this PR with the details @gatorsmile it appears to be orthogonal to this change. Historically we've treated Python API parity fixes as closer to bug fixes rather than new features which is why I was thinking this made sense for 2.2, but I'll defer to your expertise in SQL and we can just target this for master.

@gatorsmile want to know if you're ok with this going into master or if you still have concerns about this if its targeted to 2.3?

This change LGTM.
I go to check #17848. It seems to me that the PR simply adds two flags into ScalaUDF. It appears that there is not API change regarding with existing UDF registration. I agreed with @holdenk and @HyukjinKwon that it is orthogonal to this change for now.

Thanks! Merging to master.

Thanks everyone.


Header constants cleanup

Feature Request
Get rid of unnecessary items.
Move what we can to internal

Fixed, will release in the next minor version rev.


running process_schemas.py creates diff in generated file

The generated file that is the result of running process_schemas.py is not predictable.  It should be written out the exact same, every time.
There is an existing issue open for the non-stable order of the postMethods, #116 .  This bug is for non-postMethods write consistency.
This gist is the diff resulting from a run of process_schemas.py on the latest master: https://gist.github.com/dcolligan/db8d3b24dc821fd23d8f

Let's land @mollyzhang's textwrap change, once that's got its indentation
and wrap width correct? Some of the differences look to be instability from
wrapping which will be changed by her work.
On Fri, Feb 20, 2015 at 1:19 PM, Danny Colligan<EMAIL_ADDRESS>wrote:

The generated file that is the result of running process_schemas.py is
not predictable. It should be written out the exact same, every time.
There is an existing issue open for the non-stable order of the
postMethods, #116 https://github.com/ga4gh/server/issues/116 . This bug
is for non-postMethods write consistency.
This gist is the diff resulting from a run of process_schemas.py on the
latest master: https://gist.github.com/dcolligan/db8d3b24dc821fd23d8f
—
Reply to this email directly or view it on GitHub
https://github.com/ga4gh/server/issues/165.

Right, solving #164 and #116 may resolve this issue.

Okay, now that @MollyZhang has closed the two above issues, do we think we can close this one?  @jeromekelleher
I vote for yes, until we see any difference pop up.

Agree with @dcolligan.

Agreed.


Uncaught TypeError: editorBuffer.getLastRow is not a function

[Enter steps to reproduce below:]

...
...

Steps to reproduce: just alt+click in a text file.
Stacktrace
Uncaught TypeError: editorBuffer.getLastRow is not a function
/Users/lweingart/.atom/packages/sublime-style-column-selection/lib/sublime-select.coffee:90
Hide Stack Trace
TypeError: editorBuffer.getLastRow is not a function
at _screenPositionForMouseEvent (/Users/lweingart/.atom/packages/sublime-style-column-selection/lib/sublime-select.coffee:90:57)
at atom-text-editor.onMouseDown (/Users/lweingart/.atom/packages/sublime-style-column-selection/lib/sublime-select.coffee:53:25)
Installed Packages
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Fixed in recent release


Fix SAI object create error in libsai adapter

Populate SAI obj-id as P4 match key.
No change in SAI API headers.

Match key:
* hdr.vxlan.vni:VNI   : EXACT     3c0000
Action entry: dash_ingress.set_outbound_direction -

[01:04:43.937] [bmv2] [D] [thread 40] Entry 0 added to table 'dash_ingress.dash_acl_group|dash_acl'
[01:04:43.937] [bmv2] [D] [thread 40] Dumping entry 0
Match key:
* meta.stage1_dash_acl_group_id:dash_acl_group_id: EXACT     0001
Action entry: dash_ingress.set_acl_group_attrs - 0,

[01:04:43.938] [bmv2] [D] [thread 16] Entry 1 added to table 'dash_ingress.dash_acl_group|dash_acl'
[01:04:43.938] [bmv2] [D] [thread 16] Dumping entry 1
Match key:
* meta.stage1_dash_acl_group_id:dash_acl_group_id: EXACT     0002
Action entry: dash_ingress.set_acl_group_attrs - 0,

[01:04:43.939] [bmv2] [D] [thread 40] Entry 0 added to table 'dash_ingress.eni|dash'
[01:04:43.939] [bmv2] [D] [thread 40] Dumping entry 0
Match key:
* meta.eni_id:eni_id  : EXACT     0003
Action entry: dash_ingress.set_eni_attrs - 27100000,86a00000,86a00000,1,10310ac,90000,1,1,1,1,1,0,0,0,0,0,2,2,2,2,2,0,0,0,0,0,

[01:04:43.939] [bmv2] [D] [thread 16] Entry 0 added to table 'dash_ingress.eni_ether_address_map|dash'
[01:04:43.939] [bmv2] [D] [thread 16] Dumping entry 0
Match key:
* meta.eni_addr:address: EXACT     aacccccccccc
Action entry: dash_ingress.set_eni - 3,

[01:04:43.940] [bmv2] [D] [thread 40] Entry 0 added to table 'dash_ingress.outbound.eni_to_vni|dash_vnet'
[01:04:43.940] [bmv2] [D] [thread 40] Dumping entry 0
Match key:
* meta.eni_id:eni_id  : EXACT     0003
Action entry: dash_ingress.outbound.set_vni - 90000,

[01:04:43.940] [bmv2] [D] [thread 16] Removed entry 0 from table 'dash_ingress.outbound.eni_to_vni|dash_vnet'
[01:04:43.941] [bmv2] [D] [thread 40] Removed entry 0 from table 'dash_ingress.eni_ether_address_map|dash'
[01:04:43.941] [bmv2] [D] [thread 16] Removed entry 0 from table 'dash_ingress.eni|dash'
[01:04:43.941] [bmv2] [D] [thread 40] Removed entry 1 from table 'dash_ingress.dash_acl_group|dash_acl'
[01:04:43.942] [bmv2] [D] [thread 16] Removed entry 0 from table 'dash_ingress.dash_acl_group|dash_acl'
[01:04:43.942] [bmv2] [D] [thread 40] Removed entry 0 from table 'dash_ingress.direction_lookup|dash'

Hi @mukeshmv I think it'd be good to add tests in vnet_out.cpp to DELETE objects as well. I did this in the course of pending https://github.com/Azure/DASH/pull/164 and discovered an error in the libsai adaptor for DELETE: https://github.com/Azure/DASH/issues/158
Please see my submitted changes in https://github.com/Azure/DASH/pull/164 for dash-pipeline/SAI/templates/saiapi.cpp.j2, dash-pipeline/SAI/templates/utils.cpp.j2 and dash-pipeline/tests/libsai/vnet_out/vnet_out.cpp and consider applying the template fix and adding similar delete operations in reverse order. It might expose some hidden issue of the changes you're proposing (I suppose it'd be nicer if I'd already submitted these fixes in a separate PR but I was working on saithrift at the time.)

Hi @mukeshmv I think it'd be good to add tests in vnet_out.cpp to DELETE objects as well. I did this in the course of pending #164 and discovered an error in the libsai adaptor for DELETE: #158

Thanks for the suggestion @chrispsommers. I tried reverse object deletes including the ENI object with your SAI template "==" fix and it went through fine. So this change does not introduce any new issues for Delete operation. I will add this ENI object to the delete test after your fix gets merged.

Hi @mukeshmv I think it'd be good to add tests in vnet_out.cpp to DELETE objects as well. I did this in the course of pending #164 and discovered an error in the libsai adaptor for DELETE: #158

Thanks for the suggestion @chrispsommers. I tried reverse object deletes including the ENI object with your SAI template "==" fix and it went through fine. So this change does not introduce any new issues for Delete operation. I will add this ENI object to the delete test after your fix gets merged.
@mukeshmv thanks for trying it out, that is good validation! The fix will get merged soon.

@chrispsommers I have added the ENI object create and delete to the ptf and pytest as well. Pls check.

Test job fail is due to conflict with recent ACL group PR merge. Will fix the tests.

@chrispsommers I am keeping my sai thrift test changes commented out for now.
They were working initially, but I am noticing that after rebasing to the tip where new P4 tables and parameters have been added to the dash pipeline the sai thrift test is not configuring the P4 correctly.
I suspect this is an artifact of using pre-built saithrift client and server docker container images, probably the latest SAI API changes are not reflected in the auto-generated rpc code. Because the vnet_out test is working fine.
Can you update the containers and let me know I can try again ?

Hi @mukeshmv, two questions:

sai thrift test is not configuring the P4 correctly.

Can you explain further - is there an actual error thrown, or are you saying the resulting configuration isn't correct?

The pre-built containers don't include build artifacts, they are "builders" and contain only tools. The artifacts are modified in your host filesystem using volume mounts. See volume-mounts. The only exception is the saithrift client which contains python saithrift wrappers based on the P4 code -> sai header generation. That container is always rebuilt in-place, not downloaded.
2. Are you doing make all to ensure all the saithrift artifacts, including the saithrift client docker, are being rebuilt?

Turns out that the sai_api_query was not returning the Dash ACL impl table. Adding that fixed the saithrift issue. Thanks @chrispsommers for your help debugging.


AFFL_AccRecordType_TDTM not checking for null

If an Account is changed from a null record type to a non-null record type and doesn't have a primary affiliation mapping for that record type, keyAfflFieldNewType (line 77) is equal to null. This causes an exception when it is added to the query on line 155. This can be fixed by changing line 87 to "} else if (keyAfflFieldNewType != null) {".

Thank you for this detailed bug report, @kyleschmid. If you are interested in contributing to the project, you could send a pull request with the fix. We'd be more than happy to review and merge it. :-)

Just created a pull request.

**lurch: add

Tracking W-011653

Included in beta release 1.19 (Beta 4)

Included in production release rel/1.19


Demo: On-chain Messaging version of Frequency via example-client-frequency

This demo should use example-client-frequency
As a developer using frequency and example-client-frequency, I should be able to send a message and see it presented in the block

Dev has frequency running locally (or devnet)
Dev connects example-client-frequency to that frequency instance
Dev can push a button to create a new hard coded Arvo on-chain schema
Dev can see a list of active schemas

Schema Id
Model Type
Payload Location
Decoded Model (Not the hex, but the JS object as JSON)

Dev can select an active on-chain schema and put in JSON that validates locally against the Arvo schema model

Alt: Put in field that allow you to build the message
Then validate

Dev can then submit the message to the chain (example-client-frequency does the Arvo serialization from the JSON)

ArvoBinary serialization should happen

Dev can then wait and see the call in Polkadot js
Dev can then request the messages for the same schema in example-client-frequency and see the Messages' JSON data (arvobinary -> parse with schema -> serialize to JSON)

SuggestedJSON.stringify(data, null, ' '); for readablity

Closed with #7


html-webpack-plugin doesn't work

Problem solved

Please try one of the support options in the issue template for support questions.

@shellscape Yeah, i sended this question in gitter webpack, but there nobody answers questions

@shellscape And if you think that the problem is in the webpack, then no, html-webpack-plugin normally work with webpack-dev-server

@shellscape You can not help? Can I wrong use webpack-serve?

@artemirq please don't post successive messages, edit your prior message instead. webpack-serve is not webpack-dev-server. unless you can point to a particular cause in the code, then you're asking for support, which we don't provide here. You'll have to be patient and wait for an answer on Gitter or StackOverflow.

@shellscape Sorry, but Github on smartphone doesn't have function to edit messages

webpack-serve is trying to replace webpack-dev-server. doesn't it means there should works like webpack-dev-server ?


Update minimum-requirements.md

Minor fix to supported versions:
SENSE service does not exist on Win10 LTSC 2015 (I.e. our service was first included to Windows 10 build 1607 = LTSC 2016 or later)

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks


Add option to enable coloring of power text depending on power type

Add option to enable coloring of power text depending on power type similar to modUI.
Mana = blue
Energy = yellow
Rage = red

Just tried it on modui and it appears rogues powertext is still blue, altough warriors have red text for rage.
I'll implement this in a future update!


fs: report correct error mode for non-existent TLF errors

If someone tries to write to a non-existent TLF, we should report a "write" error, instead of a "read" error.
Issue: KBFS-1521
Issue: DESKTOP-1868
Issue: keybase/client#4271

lgtm


ORC-1204. ORC MapReduce writer to flush when long arrays

What changes were proposed in this pull request?
This adds a new configuration for the row by row writer that sets a limit of how many items will be buffered in the VectorizedRowBatch before it is sent to the ORC Writer. This does not change the behavior of the core writer, where the application already has control over the size of the batch.
Why are the changes needed?
We are getting OOM when writing rows with long arrays with the row-by-row writer. Heap dumps show that it is the ColumnVector inside the array that is taking large amounts of memory.
How was this patch tested?
Updated a couple unit tests and added two more.

32k was based on the 1k rows and wanting to let lists have ~30 elements/row before we cause an early flush.

Thank you! Merged to main.


Verify in smoke tests that JVM metrics are exported

This PR implements smoke tests verifying that our micrometer metrics get consumed by the collector correctly (and runtime. is added).

Applied same fake-backend changes as in the upstream javaagent project
Bumped otel-collector version
Changed windows otel-collector image to contrib (has signalfx receiver)

I had to revert the Windows collector image changes and disable metrics on Windows: as it turned out, the otel-collector-contrib image is missing the changes from this PR: https://github.com/open-telemetry/opentelemetry-collector/pull/2272
And it just doesn't work in docker right now. I'll create a separate issue for this matter.


How to make the search request only return videos with subtitle?

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

My goal is to download videos with human uploaded subtitle. The pipeline which I am currently execute is search some query first then parse the info.json to filter out the videos with human made subtitle and download them.
But as we all know videos with human made subtitle is much less than the videos without human made subtitle and considering that each search request only return ~500 results. How can I grasp these precious resource to make the returned results more efficient, which means that I can make only the videos with subtile return rather than all videos with or without subtitle in advance.
Do youtube-dl have any parameter that I can set when do each search request to achieve this purpose?

A mechanism under yt-dl's control would have to filter based on the extracted metadata (like --match-filter ...), so it wouldn't help with your problem.
The v3 YT search API has this parameter:

videoCaption:string
The videoCaption parameter indicates whether the API should filter video search results based on whether they have captions. If you specify a value for this parameter, you must also set the type parameter's value to video.
Allowed values are:
any
closedCaption
none

The yt-dl extractor uses https://www.youtube.com/youtubei/v1, which doesn't have this option.

With https://github.com/ytdl-org/youtube-dl/pull/27749, you can pass search URLs like https://www.youtube.com/results?search_query=python&sp=EgIoAQ%253D%253D. You can find the correct sp param by applying the filters you want on the website

That's nice. I must find that YouTube 101 course ...
Apparently just sp=EgQQASgB for videos with subtitles/CC. You can't use this with the ytsearch... pseudo-schemes, and you need the git master (or the PR).
Unfortunately, with https://www.youtube.com/results?q=ditempat&sp=EgQQASgB we still appear to run out of result pages (31, 538 results). I guess that the subtitles/CC filter isn't effective because videos get subtitled automatically, and those are the ones that OP wanted to exclude.
This presentation (PDF) was useful for terminology.

I'm pretty sure the "subtitles/CC" filter excludes automatic captions

Looks right. It's just that ditempat is a very productive query. With ditemaptx, the subtitle filter picks 7 from 227 unfiltered results.

you can pass search URLs like https://www.youtube.com/results?search_query=python&sp=EgIoAQ%253D%253D. You can find the correct sp param by applying the filters you want on the website

This is not robust. Those codes are the result of Base64 encoding a ProtoBuf message. As such, hardcoding all combinations would result in hundreds of sp values. Some example code:
package main

import (
   "encoding/base64"
   "github.com/89z/format/protobuf"
)

func main() {
   subtitles := protobuf.Message{
      2: protobuf.Message{
         5: protobuf.Varint(1),
      },
   }
   sp := base64.StdEncoding.EncodeToString(subtitles.Marshal())
   println("youtube.com/results?search_query=cats&sp=" + sp)
}

If you look at the result, youll notice that the Subtitles/CC filter has been applied:
youtube.com/results?search_query=cats&sp=EgIoAQ==

Full list of the filters here:
https://github.com/89z/mech/blob/v1.50.8/youtube/filter.go

The yt-dl extractor uses https://www.youtube.com/youtubei/v1, which doesn't have this option.

Thats not true:
POST /youtubei/v1/search HTTP/1.1
Host: www.youtube.com
X-Goog-Api-Key: AIzaSyAO_FJ2SlqU8Q4STEHLGCilw_Y9_11qcW8

{
 "params": "EgIoAQ==",
 "query": "cats",
 "context": {
  "client": {
   "clientName": "MWEB",
   "clientVersion": "2.20220322.05.00"
  }
 }
}

The yt-dl extractor uses https://www.youtube.com/youtubei/v1, which doesn't have this option.

Thats not true:

So read that

... doesn't have this option according to the misleading documentation that I found ...

Thanks

That's robust as long as people don't do a JavaScript on the ProtoBuf encoding spec.

I don't understand this sentence.

Randomly changing the specification in incompatible ways, I mean.

Randomly changing the specification in incompatible ways, I mean.

I doubt it. The same format has been used for at least seven months:
https://github.com/89z/mech/commit/f25e6665
and its never been obfuscated like JavaScript. Outside of the weirdness of ProtoBuf itself, it seems pretty stable and normal to me.

https://github.com/ytdl-org/youtube-dl/issues/30794#issuecomment-1084325581 seems to be the answer OP wanted. PR branch or git master needed, though.


CIF-889 - move mini card readme to correct place

Description
Move mini card readme.md to correct place
Related Issue
CIF-889
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] Documentation

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[x] I ran all tests locally and they pass.

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage     62.32%   62.32%
  Complexity      166      166
=========================================
  Files            26       26
  Lines           937      937
  Branches         64       64
=========================================
  Hits            584      584
  Misses          324      324
  Partials         29       29

Flag
Coverage Δ
Complexity Δ

#karma
95.16% <ø> (ø)
0 <ø> (ø)
:arrow_down:

#unittests
54.19% <ø> (ø)
166 <ø> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3acc3d...43edf99. Read the comment docs.


does the image label overlap?

I wonder if different labels can have overlapping? Original label is given all 18 channels, I doubt if every image has all the labels involve, and if different labels can point to a same pixel?

Hello @Roberyan ,
All labels have been annotated with the same nomenclature of 18(+1) classes, without any overlapping or hierarchical notion. Each pixel has a single annotation.
A detailed semantic description of the classes is available in the appendix (page 16) here : https://arxiv.org/pdf/2310.13336v1
Hope this helps!

Hello @Roberyan ,
You are right. Not every image contains all 18 labels and you also can map different labels to the same pixel, such as mapping 13,14,15,16,17,18,19 classes into 13.

thanks for your help!


Item Changing Zipped With Item Changed Test

Git doesn't like the same branch name apparently, so I pushed this to a new branch.
This the new PR for #508.

@jlaanstra :+1: or :-1: or :fire: this PR?

Closing out this PR as it's hella old (sorry about that). If you still want to PR this in then please do it against develop branch which is RxUI v7.


Only paramaters in the menu are added

When using this with something like VRCFaceTracking, the paramaters for things like Eyex, EyesY, ect, aren't showing up in the JSON file.
This mod seems to only add things to the JSON if they're in the menu. This is a problem because I really don't want to fill my menu with all of my FaceTracking values.
It would be much better if all of the paramaters from the animator were added to the generated JSON.
Thank you.

Would the parameters you're talking about be referenced to issue #3 ? (CVRParameterStream), or would this be something involving the CVRFaceTracking Component, or is this something specific only to the baseAnimator?

I probably could of been more descriptive, but I'm pretty sure this is its own issue.
here's a JSON of my avatar's generated JSON file
{
  "id": "avtr_f2813792-2cfb-455b-a470-7de5ecfae702",
  "name": "BizzMinase",
  "parameters": [
    {
      "name": "Eye Tracking",
      "input": {
        "address": "/avatar/parameters/Eye Tracking",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/Eye Tracking",
        "type": "Bool"
      }
    },
    {
      "name": "WearNecklace",
      "input": {
        "address": "/avatar/parameters/WearNecklace",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/WearNecklace",
        "type": "Bool"
      }
    },
    {
      "name": "WearWatch",
      "input": {
        "address": "/avatar/parameters/WearWatch",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/WearWatch",
        "type": "Bool"
      }
    },
    {
      "name": "Wear Choker",
      "input": {
        "address": "/avatar/parameters/Wear Choker",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/Wear Choker",
        "type": "Bool"
      }
    },
    {
      "name": "SelectOutfit",
      "input": {
        "address": "/avatar/parameters/SelectOutfit",
        "type": "Int"
      },
      "output": {
        "address": "/avatar/parameters/SelectOutfit",
        "type": "Int"
      }
    },
    {
      "name": "UndressOuter",
      "input": {
        "address": "/avatar/parameters/UndressOuter",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/UndressOuter",
        "type": "Bool"
      }
    },
    {
      "name": "UndressTop",
      "input": {
        "address": "/avatar/parameters/UndressTop",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/UndressTop",
        "type": "Bool"
      }
    },
    {
      "name": "Undress Bottom",
      "input": {
        "address": "/avatar/parameters/Undress Bottom",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/Undress Bottom",
        "type": "Bool"
      }
    },
    {
      "name": "Undress Shoes",
      "input": {
        "address": "/avatar/parameters/Undress Shoes",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/Undress Shoes",
        "type": "Bool"
      }
    },
    {
      "name": "Undress Inner",
      "input": {
        "address": "/avatar/parameters/Undress Inner",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/Undress Inner",
        "type": "Bool"
      }
    },
    {
      "name": "Undress Gloves",
      "input": {
        "address": "/avatar/parameters/Undress Gloves",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/Undress Gloves",
        "type": "Bool"
      }
    },
    {
      "name": "HoodUp",
      "input": {
        "address": "/avatar/parameters/HoodUp",
        "type": "Float"
      },
      "output": {
        "address": "/avatar/parameters/HoodUp",
        "type": "Float"
      }
    },
    {
      "name": "HeartBeat Range",
      "input": {
        "address": "/avatar/parameters/HeartBeat Range",
        "type": "Float"
      },
      "output": {
        "address": "/avatar/parameters/HeartBeat Range",
        "type": "Float"
      }
    },
    {
      "name": "HeartBeat Volume",
      "input": {
        "address": "/avatar/parameters/HeartBeat Volume",
        "type": "Float"
      },
      "output": {
        "address": "/avatar/parameters/HeartBeat Volume",
        "type": "Float"
      }
    },
    {
      "name": "HeartRate Monitor",
      "input": {
        "address": "/avatar/parameters/HeartRate Monitor",
        "type": "Bool"
      },
      "output": {
        "address": "/avatar/parameters/HeartRate Monitor",
        "type": "Bool"
      }
    }
  ]
}

Here's a screenshot of my controller's parameters

Notice things like HRPercent (used by a very cool OSC application) are missing from the generated JSON.
As you can see, a lot of the parameters are not shown in the generated JSON file, and the only ones that do show up are ones that I've added to my Avatar's Advanced Parameters Menu, but the way CVR works is every parameter in the Controller, unless it starts with a "#" symbol, is automatically networkedl; It doesn't need to be in the menu to sync. For a lot of avatars I've been Working on, I don't tend to put any of the OSC controlled parameters into the menus.
Another thing I've just noticed - not to pile on here, but when paremeters are added to a menu with a space in their name, that Space is removed from them in the Animator, so something like HeartRate Monitor becomes HeartRateMonitor, but in my JSON, it's becoming "HeartRate Monitor", the same as in the menu.

but the way CVR works is every parameter in the Controller, unless it starts with a "#" symbol, is automatically networkedl;

This I did not know. I thought that only the ones in the Advanced Settings would sync. Thank you for the clarification. I will work on supporting reading parameters from the baseAnimator.

Yeah I'm not surprised its not very well known and the documentation doesn't mention a lot of these things yet. A lot of people are also auto-converting avatars, which puts everything into the menu even though it doesn't need too.

This change has been implemented in the latest commit and is awaiting release.

Right as I was writing the release notes for the version that implemented this, @kafeijao made their own OSC Mod, which is like a hundred times better than this lol. I'd highly recommend using that, however, if you wish, I can publish that draft release that's been sitting there for a good month now.


Support create & drop index.

What would you like to be added:
Why is this needed:
Support create index.
https://dev.mysql.com/doc/refman/8.0/en/create-index.html
https://dev.mysql.com/doc/refman/8.0/en/drop-index.html

Assign to me pls :)

I will take on this task.