Allow toggling multi room flag more seamlessly

Feedback/request from a user:

At times I want to play music in multiple rooms at the same time, but at times my girlfriend would like to listen to certain music in let’s say the living room as I am listening to different music in let’s say the bedroom.
Is there a more elegant way to achieve this than going into the settings and adding or removing the DISABLE_MULTI_ROOM command every time I would like to switch between local and multiroom playback?

This will require having some simple UI I guess

This could be accomplished, by setting the master ip to localhost. Just needs some way to force the server.

Why not do it more Sonos-style by adding ‘zones’, with in practice is device groups which each can be played to individually. To use this, each zone would be its own BT device or Airplay/Spotify Connect device. Dunno if this is possible but surely would be nice.

@klausagnoletti i think zones will be implemented by this PR: #153

Changing device mode (MULTI_ROOM; STANDALONE) is now possible via the "secret" UI at http://<DEVICE_IP>:3000/secret. For now this is experimental, meaning that we don't advertise it too much as it still needs polishing and moar features will be added.
Groups/zones will be addressed in the future, for that follow #188.
I'll close this issue for now.


feat: Monotonicity of Finsupp.support

Yeah you're right. I forgot to add the ⊆ version even though support is Finset-valued.
bors merge


How is it possible to load fonts from a CDN?

I would like to know the best practices available about loading CSS-stored fonts (like the ones at Google Fonts) from a CDN.

At the end, I just need to automatically insert <link href='https://fonts.googleapis.com/css?family=Roboto' rel='stylesheet' type='text/css'> to the generated page.

Just use a custom template.

Okay, thank you!


SAMbA Source code missing

The examples use imports from br.uff.spark.advancedpipe.*, but the source code for this package is nowhere to be found.  Should it have been included in this repository?

Hello.
Thanks for reporting the issue.
We did include package br.uff.spark.advancedpipe in the Docker image, but you may have experienced a "double import" problem.
After the verification of README, I found  the line:
import import br.uff.spark.advancedpipe.{ExecutionPlanning, FileElement}
with keyword import typed twice.
If you are using the sample provided in the README.md, so this is likely the problem.
I already fixed the documentation.
Let me know if it worked.
Regards,

I found the class files only on /SAMbAFiles/SAMbA/jars/spark-core_2.11-2.4.0-SNAPSHOT.jar inside the container. Is this correct ?


Data loader for Maxtext training emulator for storage

The standalone data loader, sets up the model and data iterator similar to the train_loop. The data loader iterates  through batches of data, but does not actually train the model.
The data loader mimics the interactions of the TPU VM hosts with the storage systems such as GCS.

Missing CLA is due to pulling in commits from main -
❌ https://github.com/google/maxtext/commit/89012c22a4ff3fc7e0ba5c0a3075df54038d18f2 Author: @a-googler<EMAIL_ADDRESS>


View with no frame -- consume zero character space

Need an option for a view to have no Frame.
When you do:
v.Frame = false
you still get a border, its just spaces instead of a visible line.  I need a view option that consume no visual space for its border.

I'll look into it after closing #60. I need to check what implications this change would have from the internals point of view.

Depending on your use case, you can working around this with using a negative coords.
This got me a status bar at the top of my screen for example:
if v, e := g.SetView("status", -1, -1, maxX, 1); e != nil { }

I have used that in some cases, but I have other cases where a view is small and is not near the edges of the window.

Hi,
is there any progress in this issue?


formatOnType breaks iterable unpacking when the collecting variable leads

*a, b, c = 1, 2, 3

becomes:
* a, b, c = stuff

Notice the leading space.

*, a = [1]

breaks similarly.


[BUG] Interface 'Maatwebsite\Excel\Concerns\withHeadings' not found

Prerequisites

[ X] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
[X ] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[X ] Checked that your issue isn't already filed.
[ X] Checked if no PR was submitted that fixes this problem.
[X ] Filled in the entire issue template

Versions

PHP version:  PHP 7.4.1
Laravel version:  v6.10.1
Package version:  3.1.18

Description

I've created a job that run with database queue in laravel that makes a query then exports this query (array) as csv with headers.
Steps to Reproduce
App\Jobs\CalculateForecastPreview.php
 public function handle()     {         $data = new ForecastPreviewsExport($this->forecasts);  ....
App\Exports\ForecastPreviewsExport.php
`<?php
namespace App\Exports;
use Maatwebsite\Excel\Concerns\FromArray;
use Maatwebsite\Excel\Concerns\withHeadings;
class ForecastPreviewsExport implements FromArray, withHeadings
{
protected $forecasts;
public function __construct(array $forecasts)

{
    $this->forecasts = $forecasts;
}

public function array(): array
{
    return $this->forecasts;
}

public function headings(): array{
    return [
        "id",
        "filial",
        "production",
        "partnership_production",
        "user_name",
        "directorships_id",
        "created_at",
        "updated_at",
    ];
}

}`
Then run in Terminal
 php artisan queue:work

composer.json
"maatwebsite/excel": "^3.1"
\config\app.php
`
'providers' => [
...
Maatwebsite\Excel\ExcelServiceProvider::class,
]
'aliases' => [
...
'Excel' => Maatwebsite\Excel\Facades\Excel::class,
]
`
I've already tried composer update, composer auto-dump, etc
Expected behavior:
Run the job successfully

Actual behavior:
Exception
Jan 23 07:43:19 silent-plateau php [2020-01-23 12:43:19] production.ERROR: Interface 'Maatwebsite\Excel\Concerns\withHeadings' not found {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Interface 'Maatwebsite\\Excel\\Concerns\\withHeadings' not found at /home/forge/forecast.parceirodeconsorcio.com.br/app/Exports/ForecastPreviewsExport.php:8) Jan 23 07:43:19 silent-plateau php [stacktrace] Jan 23 07:43:19 silent-plateau php #0 /home/forge/forecast.parceirodeconsorcio.com.br/vendor/composer/ClassLoader.php(444): include() Jan 23 07:43:19 silent-plateau php #1 /home/forge/forecast.parceirodeconsorcio.com.br/vendor/composer/ClassLoader.php(322): Composer\\Autoload\\includeFile() Jan 23 07:43:19 silent-plateau php #2 [internal function]: Composer\\Autoload\\ClassLoader->loadClass() Jan 23 07:43:19 silent-plateau php #3 /home/forge/forecast.parceirodeconsorcio.com.br/app/Jobs/CalculateForecastPreviews.php(54): spl_autoload_call() Jan 23 07:43:19 silent-plateau php #4 [internal function]: App\\Jobs\\CalculateForecastPreviews->handle() Jan 23 07:43:19 silent-plateau php #5 /home/forge/forecast.parceirodeconsorcio.com.br/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(32): call_user_func_array() Jan 23 07:43:19 silent-plateau php #6 /home/forge/forecast.parceirodeconsorcio.com.br/vendor/laravel/framework/src/Illuminate/Container/Util.php(36): Illuminate\\Container\\BoundMethod::Illuminate\\Container\\{closure}() Jan 23 07:43:19 silent-plateau php #7 /home/forge/forecast.parceirodeconsorcio.com.br/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(90): Illuminate\\Container\\Util::unwrapIfClosure() Jan 23 07:43:19 silent-plateau php #8 /home/forge/forecast.parceirodeconsorcio.com.br/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(34): Illuminate\\Container\\BoundMethod::callBoundMethod()

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

i have this proble also can u help me please?


[5.2] Fix multi-upload validations issues on php7

validating multiple files that stored in single input as array if validations fails and your project run on php7 you end up with this error
local.ERROR: Exception: Serialization of 'Illuminate\Http\UploadedFile' is not allowed since the files object will never be removed from the stored array
for full details on this issue see issue report #14143

This change still doesn't make any sense. No behavior has been changed at all from what I can tell.

@taylorotwell this is the weirdest issue i ever encounter with laravel i played with it for several days now and did not found any logical reason of why it's happening only in php7 as you can see in this issue report #14143 the only reason i found was this note in php docs site array-filter can you kindly look at the issue report and see why it's happening i'm losing my mind searching for a good reason

This started happening to me yesterday after doing composer update. I did notice a lot of Symfony updates when I did that. Before the update, file validation on mimetype was failing but no messages were displayed from the error bag. After the update, I would get a brief error page followed by a redirect. I managed to get this screen grab before the redirect -

I'm using a FormRequest for validation and solved the issue by adding $dontFlash to the request properties. Validation works as expected now and there is no error page displayed before the refresh.
The project is only a couple weeks old and was using Laravel 5.2.* in composer.json. I don't "think" I saw Laravel download anything when I did the update but I could be mistaken.

Can you paste a sample HTML form to recreate this?

Here's a scaled down version of my form:
<form method="POST" action="/agency/22" accept-charset="UTF-8" enctype="multipart/form-data">
	<input name="_method" type="hidden" value="PATCH">
	<input name="_token" type="hidden" value="8EslY95c25Xdv1XJlknh9ZTFVbMv9RD5r6sdLo4A">
	<input multiple="multiple" name="agreement[]" type="file">
	<input class="btn btn-primary" type="submit" value="Save Contact">
</form>

Here's a scaled down version of my FormRequest:
<?php
namespace App\Http\Requests;
use App\Http\Requests\Request;

class Agency extends Request
{
	// Solves the issue of missing error messages for the files array
	protected $dontFlash = ['agreement'];

    public function authorize()
    {
        return true;
    }

    public function rules()
    {
         return [
			'agreement.*' =>'mimes:pdf',
        ];
    }

    public function messages()
    {
    	return [
    			'agreement.*' => 'Only PDF files are accepted',
    	];
    }
}

My issue was resolved when I added $dontFlash to the FormRequest. I also left a comment in #1443 that may explain what's going on and why the files array is not being removed.

@3alampro as a workaround you could try adding the property protected $dontFlash = ['images']; to app/Http/Requests/UploadFiles.php.

thank you @alwarren I'm already using this workaround in my projects but this is issue in laravel and how it handles file objects when redirecting back withInput and errors 😢 hopefully I'll have more time to explore it more and see if i can find better solution than this PR

@taylorotwell See the comment on the array_filter callback becoming undefined in Issue #14143 .
I just checked some PHP release dates against the Laravel repo. The recursive code added to Illuminate/Http/RedirectResponse.php predates PHP 7.0 by a few months. Not sure if the 7.0 update is causing this but it seems reasonable.
That said, I think the suggested fix may be an acceptable approach.

I have pushed a fix to 5.2 that should address this.


Remove trailing semicolon from the auth summary

As I understand, the semicolon is used to separate policies list from the roles list. Anyhow, the semicolon also remains at the end as well, which does not look good. Can it be trimmed? 😊

What does your Authorize attribute on your controller look like?

Hi, @mattfrear,
The code looks like this:
[Authorize("policy.read")]
public class ItemsController : ControllerBase
{
    [Authorize("poliy.write")]
    [HttpGet]
    public async Task<IActionResult> GetItem(int id)
    {
    }
}

The generated summary looks like this:
/Items/{id} (Auth policies: policy.read, policy.write;)

So, everything seems OK - it's just that extra semicolon at the end of the policy list, which seems unnecessarily.

Thanks for your PR, but next time you should probably check the code compiles and tests pass before submitting. I have implemented your functionality and will release it when I get a chance.

Released https://www.nuget.org/packages/Swashbuckle.AspNetCore.Examples/2.8.0


[Question] [Worker] Process won't kill

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
I ran a java command in the shell task, I set the max memory of the task to 30M, I expected the java process will be killed when it reaches the max memory, but it won't, can you give me some tips, thanks.

What you expected to happen
I expected the java process will be killed when it reaches the max memory
How to reproduce
please see the pic above.
Anything else
No response
Version
3.1.x
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Did you turn on the switch of task.resource.limit.state?
https://dolphinscheduler.apache.org/zh-cn/docs/3.1.7/guide/task/appendix

@SbloodyS , Hello, I refer to the link you mentioned above, then it directed me to this URL:  https://dolphinscheduler.apache.org/zh-cn/docs/3.1.7/architecture/configuration, but I didn't find where to configure. Thanks.


AN-614: Allowed security scheme must exist in config.json

AN-614: used zod.superRefine() in order to validate that the security scheme enabled under ois.apiSpecifications.security is defined in ois.apiSpecifications.components.

+1 LGTM.
I think we should also verify that the the security scheme value is set via the apiCredentials https://docs.api3.org/airnode/v0.6/grp-providers/guides/build-an-airnode/api-security.html#step-3-specify-the-values-for-the-defined-security-schemes but we can do that as a separate issue? WDYT?

Right, I thought about doing that at first but then I realized that securityScheme is optional in apiCredentials but maybe I could still do a one-way check (if apiCredentials.securitySchemeName is defined then check if ois.apiSpecifications.components.securitySchemeName is also defined. WDYT?

Mhh, actually maybe we can bring this up at the call. I can imagine an user taking full OAS of their API, making a few changes to convert it to OIS and enable only a subset of triggers and security schemes. That suggests we should not do this check and allow "unused" security schemes.
However, for enabled security schemes (via the security field) we need make sure that  the value is defined in apiCredentials.

Mhh, actually maybe we can bring this up at the call. I can imagine an user taking full OAS of their API, making a few changes to convert it to OIS and enable only a subset of triggers and security schemes. That suggests we should not do this check and allow "unused" security schemes. But for other users this will be an annoying error they'll need to debug shrug .

Yes, and this has been how I've been approaching "reference" validation in Airkeeper and Airkeeper. For those config files I'm only adding checks for things being referenced but unused things are not being validated for convenience since having those config values there don't really hurt and makes testing easier when switching between config values.

However, for enabled security schemes (via the security field) we need make sure that the value is defined in apiCredentials.

The thing is that we only care about apiCredentials.securitySchemeValue being set when securityScheme.type is apiKey or http 🤔

The thing is that we only care about apiCredentials.securitySchemeValue being set when securityScheme.type is apiKey or http 🤔

No. I mean when you have a security scheme that is defined and also enabled. Such as this then we should verify the value is also supplied in apiCredentials (here). Essentially, making sure that user defined  the step 3 from the docs.

The thing is that we only care about apiCredentials.securitySchemeValue being set when securityScheme.type is apiKey or http thinking

No. I mean when you have a security scheme that is defined and also enabled. Such as this then we should verify the value is also supplied in apiCredentials (here). Essentially, making sure that user defined the step 3 from the docs.

But what if the Airnode is only relaying metadata using securitySchemes? https://docs.api3.org/airnode/v0.4/grp-providers/guides/build-an-airnode/api-security.html#relayed-meta-data-security-schemes

Oh, I see what you mean now. Yes, we only care about those two. But if they are defined and used, there should be a value defined for them in apiCredentials

Thanks for the thorough and detailed code review @Siegrift 🙏🏻


Broken link on pattern library

Expected Behavior
The “pattern library by hankchizljaw” should link to https://hankchizljaw.io.
Actual Behavior
It seems to link internally instead.
Steps to Reproduce the Problem

Look at the sidebar and find the link
Click it
Feel the devastation of a broken link

Closed with #12, by @tcaruth 🎉


Community governance

With the addition of the community package to Carbon for IBM we need to establish guidelines and documentation for what the purpose of the community package is and how to contribute to it.
### Tasks
- [ ] Add a README to document the package purpose
- [ ] Add documentation on governance of the package
- [ ] Explore what we can adopt from [ibm-cloud-community](https://github.ibm.com/ibmcloud/cloud-pal-community#contribution-ownership-and-statuses)
- [ ] Draw it out in Mural??

### Future considerations
- [ ] Define how components may be migrated from `ibm-products-community` to `ibm-products`
- [ ] Define relationship with design process

David meeting with Stephanie and Clayton tomorrow on governance for their PALs.

Closing this since this now overlaps with Labs/Innovation.


Status of IconVG Project and Roadmap to Production Readiness

Hello,
I’m interested in the IconVG project and its potential use for efficient presentation of simple vector graphics. However, I’ve noticed that the project has had little traffic since 2022, and the last commit is from around 4 months ago. Given that the format is still marked as experimental and subject to incompatible changes, I was hoping to ask a few questions:

What is the current status of the IconVG project?
Is it still actively being developed or maintained, even though contributions appear to have slowed down?

Is there an expected timeline for when IconVG might reach a more stable or production-ready state?
I   ’m curious to know whether the project is still in the experimental phase, or if there's a roadmap towards achieving a stable release.

What are the key areas of the project that are still under active development or planned improvements?

Thank you for your time and for the work that has gone into this project so far!
I look forward to hearing about any future updates.

It's not actively being developed. Maybe it will be again, in the future, but not today. Sorry.


Weird select input field when opening the advanced options for the first time

When you first open the settings page and advanced options are closed this weird select field shows along the multiple selection field when you open it.
If it's open when you get to the settings screen the bug doesn't happen.

I couldn't reproduce it. Could you upload a screenshot?


Repeating notifications for already available media

Description
Some shows keep sending out "Media available" notifications
Version
1.6.0
Steps to Reproduce

Run Sonarr Scan
Get notifications about shows that have already sent out notifications

Screenshots
No response
Logs
Did not fit here.
https://privatebin.pavel.gg/?e875bfc935dfde5a#FNL9GfiCgcnGjWjj4uWScYQuU9CjeuMZVYShyeDfxFDt

Platform
desktop
Device
Any
Operating System
Docker on Ubuntu
Browser
Any
Additional Context
Most likely caused by #465
Code of Conduct

[X] I agree to follow Overseerr's Code of Conduct

This is has possibly been fixed in the develop. Can you test out with the develop tag?

Yeah seems to be solved by #444
I assume that the underlying issue for episode number mismatch us caused by #465 however.

Episode mismatch is caused by the difference in database yes but the notification issue is completely unrelated is what I meant.

Alright, can be closed when #444 is merged into main


Ensure objectWillChange.send() is called from the main thread.

stephencelis > We try to note this in the README's FAQ, but TCA does not have an opinion on threading, and does no work to run on the main thread. The fact that it typically runs on the main thread in SwiftUI applications is due to the fact that most SwiftUI actions are sent on the main thread. If you want to run TCA on a background queue, you need to send actions to the store on that queue, and your reducer must receive effects on that queue.

If we are sending actions to the store from a background queue and receiving effects on that queue, we must also ensure that objectWillChange.send() will always be called from the main thread.

Publishing changes from background threads is not allowed.

Hi @mycroftcanner, this change will have very far reaching and potentially dangerous ramifications. SwiftUI is very particular with how it gets notified of state changes, and I really have no idea how SwiftUI would handle this situation.
The best way to handle this is to make sure to always .send from the main thread in your UI code, and to make sure you effects always deliver on the main thread via .receive(on:). This puts the responsibility on you rather than baking this notion directly into the library.
Also, it is not true that you can never send actions to a store on a background thread. It's only true if you are using ViewStore in a SwiftUI view because updates to the @ObservedObject must be done on the main thread. If you are not using that then you are free to send actions on a background thread.
However, you must also be aware that the store does no synchronization whatsoever, so you must further make sure that all actions are sent from the same thread. You should not send actions from multiple threads.

Hi @mycroftcanner, this change will have very far reaching and potentially dangerous ramifications. SwiftUI is very >particular with how it gets notified of state changes, and I really have no idea how SwiftUI would handle this situation.

I'll do some more testing but it seems that as long as objectWillChange.send() is called on the main thread, SwiftUI doesn't seem to mind.

The best way to handle this is to make sure to always .send from the main thread in your UI code, and to make sure you effects always deliver on the main thread via .receive(on:). This puts the responsibility on you rather than baking this notion directly into the library.

I was doing just that but ran into some serious performance issues when my reducers. I have a complex hierarchy of recursive reducers driving some ASCollectionNodeController and it seems that when I navigate a few level down the hierarchy you can really feel some lag when actions are sent to the reducer while scrolling down (when you use Texture / AsyncDisplayKit you tend to notice the slightest lag as it is virtually frictionless as long as you stay away from the main thread.)
All my effects are already running in the background. Running the reducer on a background thread completely eliminated the lag. I'll create a sample project if you want to take a look.

Also, it is not true that you can never send actions to a store on a background thread. It's only true if you are using ViewStore in a SwiftUI view because updates to the @ObservedObject must be done on the main thread. If you are not using that then you are free to send actions on a background thread.

I didn't say you can never send actions to a store on a background thread.

However, you must also be aware that the store does no synchronization whatsoever, so you must further make sure that all actions are sent from the same thread. You should not send actions from multiple threads.

All my actions are sent from the same thread. It would be nice to be able to pass a queue to ViewStore.

Can you profile your code and see where the slow down is? There is a chance you are running into a performance problem with the reflection computation that case paths do. If that's the case then you may want to hand write the case paths to see if it improves performance. The reflection is many times slower than a hand-rolled case path, but the overall time is still so small that it isn't usually noticeable unless the code is being called many times.

I didn't say you can never send actions to a store on a background thread.

Sorry, I was only commenting on this pull quote: "Publishing changes from background threads is not allowed". Not sure where that was stated, but it's not a claim we make as a universal truth. Only in the context of SwiftUI.

Can you profile your code and see where the slow down is? There is a chance you are running into a performance problem with the reflection computation that case paths do. If that's the case then you may want to hand write the case paths to see if it improves performance. The reflection is many times slower than a hand-rolled case path, but the overall time is still so small that it isn't usually noticeable unless the code is being called many times.

I didn't say you can never send actions to a store on a background thread.

Sorry, I was only commenting on this pull quote: "Publishing changes from background threads is not allowed". Not sure where that was stated, but it's not a claim we make as a universal truth. Only in the context of SwiftUI.

Oh the quote is from the purple Xcode warning that appear when you call objectWillChange.send from a background thread.
I'll profile the code again tomorrow. Could you please provide an example of a hand-rolled case path?

Sure thing, if you have a nested enum action like this:
enum AppAction {
  case profile(ProfileAction)
}

enum ProfileAction {
  case buttonTapped
}

You can typically just do /AppAction.profile in order to construct a CasePath<AppAction, ProfileAction>. However, that is using reflection stuff under the hood to figure things out. Instead you can just construct one directly:
let profileCasePath = CasePath<AppAction, ProfileAction>(
  embed: AppAction.profile,
  extract: {
    guard case let .profile(action) = $0 else { return nil }
    return action
  }
)

You can also house this value as a static in the CasePath type:
extension CasePath where Root == AppAction, Value == ProfileAction {
  static let profile = Self(
    embed: AppAction.profile,
    extract: {
      guard case let .profile(action) = $0 else { return nil }
      return action
    }
  )
}

And then in your pullbacks you can even do:
reducer.pullback(state: ..., action: .profile, environment: ...)

Ideally Swift would be able to write this code for us like it does for key paths, and then we could eliminate the boilerplate and get the performance benefits. However, until then it can be sometimes necessary to do these hand rolled case paths in particularly hot code paths.

This part is easy:
extension CasePath where Root == AppAction, Value == UserCollectionAction {
  static let search = Self(
    embed: AppAction.search, extract: {
      guard case let .search(action) = $0 else { return nil }
      return action
    }
  )
}

public let appReducer = Reducer<AppState, AppAction, AppEnvironment>.combine(
  campaignsReducer.pullback(
    state: \.campaigns,
    action: /AppAction.campaigns,
    environment: \.campaigns
  ),
  settingsReducer.pullback(
    state: \.settings,
    action: /AppAction.settings,
    environment: \.settings
  ),
  Reducer.empty.itemCollection(
    state: \.search,
    action: .search,
    environment: \.search,
    itemReducer: igUserReducer,
    done: IGUserAction.done

However in my high order reducer, I have difficulties creating a case path using this let profileCasePath = CasePath<AppAction, ProfileAction>([...] construct.
public extension Reducer {
  /// Enhances a reducer with collection logic.
  func itemCollection<ItemState, ItemAction, ItemEnvironment>(
    state: WritableKeyPath<State, ItemCollectionState<ItemState, ItemAction>>,
    action: CasePath<Action, ItemCollectionAction<ItemState, ItemAction>>,
    environment: @escaping (Environment) -> ItemCollectionEnvironment<ItemState, ItemEnvironment>,
    itemReducer: Reducer<ItemState, ItemAction, ItemEnvironment>,
    done: ItemAction? = nil
  ) -> Reducer where ItemState: Equatable & Identifiable, ItemAction: Equatable {
    Reducer<
      ItemCollectionState<ItemState, ItemAction>,
      ItemCollectionAction<ItemState, ItemAction>,
      ItemCollectionEnvironment<ItemState, ItemEnvironment>
    >.combine(
      itemReducer
        .forEach(
          state: \.items,
          action: /ItemCollectionAction<ItemState, ItemAction>.item(id:action:),
          environment: { $0.item }
        ),
      .init { state, action, environment in

Thanks again for your suggestions. Using hand rolled CasePath improved the performance a lot.
We still had some issues with performance... One of the API calls we were hitting was returning 1000 results instead of the 50 we expected. We removed all the extraneous struct copies we were making and got rid of most of the bottlenecks and implemented a workaround so that we wouldn't have to create a thousand states at once.
Interestingly, having the reducer running on a background had barely any impact on the user experience even under high load.
I'll close the PR but it would be interesting to thing what changes would be necessary to easily run TCA in the background (dealing with SwiftUI, etc.)


👻 fix id collision

if transferId's collide in the same block amount are added in PendingTransfer which enables recoverability of funds

nice! @tabshaikh I also added a convenience function of withdrawFrom() (a common request of WETH variants).


Placeholder for implementation of barrier to irreversible expensive actions

Describe the issue
Placeholder for implementation of #741
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context
Add any other context, attachments or screenshots
Definition of done

Exact steps tbd

Not going to pursue at this moment.


Callbacks must not be able to unwind into sqlite code

Unwinding across an FFI boundary is undefined behaviour, and thus must not be possible using safe Rust code. The implementation of Connection::busy_handler looks like this:
https://github.com/jgallagher/rusqlite/blob/52607646dcd847d1da69e93c575dbff6eabb348f/src/busy.rs#L48-L65
If the user-provided callback panics, the panic may unwind out of busy_handler_callback and into sqlite, which is undefined behaviour. To fix that, every single user-supplied callback that ends up getting called by sqlite must be protected by putting it inside catch_unwind.

And:

config_log
trace
profile
commit_hook
rollback_hook
update_hook
sqlite3_bind_pointer and free_array ?
wait_for_unlock_notify ?
vtab

https://github.com/rust-lang/rust/pull/55982 ?

Indeed that would fix the unsoundness, but I don't recommend waiting for it to land, nor is aborting necessarily the right thing to do here - for example rlua allows transferring panics through Lua code and resuming them when control is returned back to Rust, which might be a better choice here as well.


Questions: The SBOM check failed when the latest release provides the asset sbom.tar.gz

Refer to checks sbom, sbom check passes if the latest release on Github includes an asset which name contains sbom. Karmada has provided the asset sbom.tar.gz in its latest release v1.10.3(https://github.com/karmada-io/karmada/releases/tag/v1.10.3), but still failed in sbom check. Could someone explain why this is happening? Thanks a lot~

Hi @zhzhuang-zju 👋
I think the problem is related to the latest release found by CLOMonitor, not the sbom check. If you click on the recent release link in the Karmada page in the CLOMonitor UI, you'll notice that it takes you to the v1.8.6 release, not to v1.10.3 as expected. That version doesn't include the sbom asset, so the check doesn't pass.
This may be happening due to the way we are fetching the releases. We get the last 30 releases, sorted by the creation date (descending). But maybe, v1.10.3, v1.9.5 and v1.8.6 were released approximately at the same time, and the creation date isn't good enough to pick the latest.
I think we can fix this getting the latest release in a different way (the repo has a latest release field), we'll look into it 🙂

Quick update: I've just remembered why we weren't already using the latest release field 😅
Sometimes the latest release is marked as pre-release, and we don't count that one as an official release. That's why we need to get some and pick the most recent one that isn't a pre-release.
I think we'll try to rely on the latest release field as the first option if it points to a version that isn't a pre-release (this should fix this case), and otherwise fallback to the current mechanism.


feat: vue version upgrade and sso

Description

Motivation and Context

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Git leaks report

Description
File
Line
Secret

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
browser/flagr-ui/src/utils/apiUtil.js
117-117
ey****DE

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
17-17
ey****Nw

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
26-26
ey****PM

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
29-29
ey****TM

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
32-32
ey****Aw

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
339-340
"p****d"

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
357-358
"p****d"

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
380-381
"p****d"

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/handler/subject_test.go
63-63
ey****EI

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/handler/subject_test.go
74-74
ey****y4

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/alice.key
1-51
--****--

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/bob.key
1-51
--****--

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/carol.key
1-51
--****--

Git leaks report

Description
File
Line
Secret

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/handler/subject_test.go
63-63
ey****EI

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/handler/subject_test.go
74-74
ey****y4

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/alice.key
1-51
--****--

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/bob.key
1-51
--****--

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
17-17
ey****Nw

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
26-26
ey****PM

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
29-29
ey****TM

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
32-32
ey****Aw

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
339-340
"p****d"

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
357-358
"p****d"

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
380-381
"p****d"

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/carol.key
1-51
--****--

Git leaks report

Description
File
Line
Secret

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/handler/subject_test.go
63-63
ey****EI

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/handler/subject_test.go
74-74
ey****y4

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/alice.key
1-51
--****--

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/bob.key
1-51
--****--

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/carol.key
1-51
--****--

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
17-17
ey****Nw

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
26-26
ey****PM

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
29-29
ey****TM

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
32-32
ey****Aw

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
339-340
"p****d"

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
357-358
"p****d"

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
380-381
"p****d"

Git leaks report

Description
File
Line
Secret

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/handler/subject_test.go
63-63
ey****EI

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/handler/subject_test.go
74-74
ey****y4

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/alice.key
1-51
--****--

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
18-18
ey****Nw

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
27-27
ey****PM

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
30-30
ey****TM

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/bob.key
1-51
--****--

Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
pkg/config/middleware_test.go
33-33
ey****Aw

Identified a Private Key, which may compromise cryptographic security and sensitive data encryption.
pkg/handler/testdata/certificates/carol.key
1-51
--****--

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
340-341
"p****d"

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
358-359
"p****d"

Identified a HashiCorp Terraform password field, risking unauthorized infrastructure configuration and security breaches.
pkg/config/middleware_test.go
381-382
"p****d"

Sonar scan report
:x: Sonar quality gate failed, open sonar dashboard for more details.
Exclusions: ,*.html,*.xml,*.yml,*.yaml,*.json,*.out,*.py,**/mock*.go,**/_gen.go
Sonar detailed coverage report
New code coverage is: 22.4%

File name
coverage

configure_flagr.go
0.0%

constraint.go
97.0%

create_constraint_parameters.go
0.0%

create_constraint_responses.go
0.0%

create_flag_parameters.go
0.0%

create_flag_responses.go
0.0%

create_segment_parameters.go
0.0%

create_segment_responses.go
0.0%

create_tag_parameters.go
0.0%

create_tag_responses.go
0.0%

create_variant_parameters.go
0.0%

create_variant_responses.go
0.0%

crud.go
93.1%

crud_flag_creation.go
86.0%

data_record_frame.go
93.8%

data_recorder.go
100.0%

data_recorder_kafka.go
80.2%

data_recorder_kinesis.go
86.8%

data_recorder_pubsub.go
56.3%

db.go
77.5%

delete_constraint_responses.go
0.0%

delete_flag_responses.go
0.0%

delete_segment_responses.go
0.0%

delete_tag_responses.go
0.0%

delete_variant_responses.go
0.0%

e2r.go
0.0%

error.go
100.0%

eval.go
87.2%

eval_cache.go
87.0%

eval_cache_fetcher.go
91.0%

export.go
81.1%

find_all_tags_responses.go
0.0%

find_constraints_responses.go
0.0%

find_distributions_responses.go
0.0%

find_flags_responses.go
0.0%

find_segments_responses.go
0.0%

find_tags_responses.go
0.0%

find_variants_responses.go
0.0%

fixture.go
100.0%

fixture.go
100.0%

flag.go
96.9%

flag_snapshot.go
43.8%

flagr_api.go
0.0%

get_export_eval_cache_json_responses.go
0.0%

get_export_sqlite_responses.go
0.0%

get_flag_entity_types_responses.go
0.0%

get_flag_responses.go
0.0%

get_flag_snapshots_responses.go
0.0%

get_health_responses.go
0.0%

handler.go
89.3%

jwt_middleware.go
73.6%

main.go
0.0%

Sonar detailed issues report

File
Line
Message

pkg/config/middleware.go
40
Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed.

Dockerfile
4
Replace as with upper case format AS.

browser/flagr-ui/src/components/Callback.vue
16
../utils/apiUtil import is duplicated.

browser/flagr-ui/src/components/Callback.vue
18
../utils/apiUtil import is duplicated.

browser/flagr-ui/src/components/Callback.vue
28
Remove this commented out code.

browser/flagr-ui/src/components/DebugConsole.vue
155
Remove this commented out code.

browser/flagr-ui/src/components/Flags.vue
159
@element-plus/icons import is duplicated.

browser/flagr-ui/src/components/Login.vue
14
../utils/apiUtil import is duplicated.

browser/flagr-ui/src/components/Login.vue
20
Consider removing this try statement as promise rejection is already captured by .catch() method.

browser/flagr-ui/src/utils/apiUtil.js
135
Refactor this code to not use nested template literals.


Error Creating App Service

{
"profileName": "Evo",
"jobId": "3a7acda1-7d40-4090-864c-4b8982cef1af",
"projectId": "15055.727788750173",
"time": "2023-10-07T04:52:59.901Z",
"log": [
"Creating Azure resources...",
"Checking the Existence of the Resource Group ...",
"Creating Resource Group ...",
"> Creating App Registration ...",
"App create failed, retrying ...",
"App create failed, retrying ...",
"App create failed, retrying ...",
"App create failed, retrying ...",
"App create failed after 3 retries. Error: Request failed with status code 401",
"{"name":"CREATE_APP_REGISTRATION","message":"App create failed! Please file an issue on Github.","stack":"Error\n    at new CustomizeError (C:\\Program Files\\Bot Framework Composer\\resources\\app.asar.unpacked\\extensions\\azurePublish\\dist\\extension.js:276418:25)\n    at createCustomizeError (C:\\Program Files\\Bot Framework Composer\\resources\\app.asar.unpacked\\extensions\\azurePublish\\dist\\extension.js:276423:10)\n    at BotProjectProvision.createApp (C:\\Program Files\\Bot Framework Composer\\resources\\app.asar.unpacked\\extensions\\azurePublish\\dist\\extension.js:277931:17)"}",
"{"name":"CREATE_APP_REGISTRATION","message":"App create failed! Please file an issue on Github.","stack":"Error\n    at new CustomizeError (C:\\Program Files\\Bot Framework Composer\\resources\\app.asar.unpacked\\extensions\\azurePublish\\dist\\extension.js:276418:25)\n    at createCustomizeError (C:\\Program Files\\Bot Framework Composer\\resources\\app.asar.unpacked\\extensions\\azurePublish\\dist\\extension.js:276423:10)\n    at BotProjectProvision.createApp (C:\\Program Files\\Bot Framework Composer\\resources\\app.asar.unpacked\\extensions\\azurePublish\\dist\\extension.js:277931:17)"}. See provision.Evo.log in your bot folder"
]
}

Thanks @WasanthaK

Which version of Composer are you using?
Is this a C# .NET or Node.js Composer bot?

Closing due to lack of response.


Remove redundant code in ONNX InferenceService sample

What this PR does / why we need it:
Remove redundant code in ONNX InferenceService sample notebook.
Some modules are imported in multiple times.

Hey @nuka137, aren't those imports used down the line within the same notebook?

@adriangonz
Yes, that's right.
But, these import lines also exist in third code block.
from PIL import Image
import numpy as np
import google.protobuf.json_format as json_format
import assets.onnx_ml_pb2 as onnx_ml_pb2
import assets.predict_pb2 as predict_pb2
import requests

So, I think we can remove redundant import lines.

/retest

@adriangonz

But, these import lines also exist in third code block.
So, I think we can remove redundant import lines.

Is there any comments about my idea?

@adriangonz

But, these import lines also exist in third code block.
So, I think we can remove redundant import lines.

Is there any comments about my idea?

Good spot @nuka137 ! Looking good from my side, although there seems to be a failing test. I've kicked it off again. If it passes, this looks good from my side.
/test kubeflow-kfserving-presubmit

Good spot @nuka137 ! Looking good from my side, although there seems to be a failing test. I've kicked it off again. If it passes, this looks good from my side.
/test kubeflow-kfserving-presubmit

/lgtm

/lgtm

/approve

/approve


Fix the inference generator shell variable substitution

Description

Fixing the inference generator shell scripts. The SRVC_URL might have a wrong variable substitution syntax.
How Has This Been Tested?

Was not tested. It's pretty generic knowledge about shell variable substitution.
Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

Nack.
I don't think this is a problem or needed. Per https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/ and https://kubernetes.io/docs/tasks/inject-data-application/define-interdependent-environment-variables/ the envs get expanded with the $(VARNAME) syntax.


augmenting job triggers page

adding explanation on how run on schedule works
docs project
What are you changing in this pull request and why?

Checklist

[ ] Review the Content style guide and About versioning so my content adheres to these guidelines.
[ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

[ ] Add page to website/sidebars.js
[ ] Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

[ ] Remove page from website/sidebars.js
[ ] Add an entry _redirects
[ ] Ran link testing to update the links that point to the deleted page

Just adding my notes/todos:

When to use Schedule Days vs Cron
Schedule

enter a value between 1 and 23 (so what is midnight!??) - why would you use this?
at exact intervals - how to select multiple times, or half hour intervals?

perhaps a table with the three ways would help with different examples?

hey @ernestoongaro! thank you again for the awesome insight - i think this is ready for a final docs review 🙌 . I'll go ahead and ask for one but wanted to let you know in case you wanted a final look at the deploy preview

@mirnawong1 one final review and I added a quick change to point to the Admin API (as that is what is relevant for scheduling). I also want to point out there is a file edited here that doesn't seem to be related website/sidebars.js
Besides that I'm good to go!

@mirnawong1 one final review and I added a quick change to point to the Admin API (as that is what is relevant for scheduling). I also want to point out there is a file edited here that doesn't seem to be related website/sidebars.js
Besides that I'm good to go!

great thank you @ernestoongaro . the sidebar.js change was from yesterday when i was trying to fix the failed checks 👍


BREAKING CHANGE: Change all resources to start with 'MSFT_SQLServer'

In issue #134 @luigilink raised the question that some resources starts with 'MSFT_SQL' while most start with 'MSFT_SQLServer'.
It wasn't addressed in that issue, focus was to change all resources to use the prefix 'MSFT'. But since that is fixed we could continue with this question.
Since changing this would become a breaking change, I set the title accordingly.
All in favor to change the resource names to one naming convention? :) If so, then I also think we should add that naming convention to the contributing section in this modules README.md.

[x] MSFT_xSQLAlias -> PR #223
[ ] MSFT_xWaitForAvailabilityGroup

👍
Can we also choose a name convention for tests, like:
MSFT_xSQLServerRole.Tests.ps1 => xSQLServerRole.Tests.ps1

@luigilink PowerShell team is using the prefix 'MSFT_' for tests over at PSDscResources. So I think we keep it the same.

Naming convention has been added to the specific guidlines

There is two suggestions for renaming the resource xWaitForAvailabilityGroup. And of course there is always the option to keep the name as is.
@randomnote1 suggested 'xWaitForAlwaysOnAvailabilityGroup'. Which would better explain that it is Always On Availability Groups it handles, and not any other Availability Groups.
@johlju suggested xSQLServerAlwaysOnWaitForAvailabilityGroup? It is long, but it is similar to the other AlwaysOn resource, and it would be easier to find the resource with Get-DscResource xSQLServer*.

To all: Please comment what you think of renaming the resource xWaitForAvailabilityGroup.

I vote for 'xSQLServerAlwaysOnWaitForAvailabilityGroup'. This is more consistent with the rest of the resources.

In light of the resource name length issue presented in in issue #716 , I think we should resume discussion and expand upon this issue.
A common theme I've been reading in the issues is that the names of the resources in the xSQLServer module are too long. Even if they worked with Azure Automation, they are considered to be too long. With that said, some of the names are extremely long due to the naming conventions that have been adopted (eg. xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership).
The basic format of the naming convention appears to be:
<Module Identifier><Action><Feature><Feature Property>
If we could publish guidance on what our naming convention is for each item, I think it could result in shorter name lengths. This published guidance would be part of the contributing guidelines. For example:

Module Identifier

SQL - I think xSQLServer for the module identifier is redundant since the module is named xSQLServer. This is also seven characters shorter. A good reference for this is the SharePointDSC module. They use "SP" as the prefix for all their resources.

Action (can be omitted)

WaitFor

Feature (List is incomplete)

AvailabilityGroup - I don't think we need the "AlwaysOn" qualifier for this.
Database

Feature Property (can be omitted)

DatabaseMembership
RecoveryModel

Some examples using this proposed method:

SQLAlwaysOnDatabaseMembership
SQLDatabaseRecoveryModel
SQLSetup
SQLWaitForAvailabilityGroup

I'm looking forward to hearing your thoughts on this.

@randomnote1 Thanks for bringing the issue of naming convention up, and coming with a good suggestion. Could you please move this to a separate issue for naming convention?
Then this issue will be obsolete it we move ahead with changing the naming convention.

Created issue #851 to track this.

This has been resolved in issue #851.


Add summary of our .NET SDK upgrade in visual Studio

Summary
Customers frequently ask about our upgrade behavior with Visual Studio. We will always update the version of the .NET SDK that's installed and managed by Visual Studio so I thought it worth documenting that.

Internal previews

📄 File
🔗 Preview link

docs/core/porting/versioning-sdk-msbuild-vs.md
docs/core/porting/versioning-sdk-msbuild-vs

@gewarren am I allowed to merge or are doc updates on lockdown too?


Error on Windows11 when fetching installed softwares details

Error print:
[×] Error in Fetching Installed Software details
Debug : time data '2024-02-10 17:14:12' does not match format '%Y%m%d'

Required change is '%Y%m%d' -> '%Y-%m-%d %H:%M:%S'

On next run below error poped up
[×] Error in Fetching Installed Software details
Debug : time data '20240602' does not match format "'%Y-%m-%d %H:%M:%S'"


Need help selecting SPECIFIC element

Been searching like mad for any kind of documentation or a discussion forum for Stylebot, no luck. If I'm in the right place, please direct me.
When using Stylebot to customize a site, I click on the omnibox CSS icon, and select the element I want to hide. However, often times, the element appearing in the stylebot selection widnow is something generic like "tr td img". Hiding or styling that element affects ALL the images on the page, rather just that specific element. If I look at the page source, the part I want might be in something like #header or something else like .thead, but I just don't have any idea how to make stylebot pick just that...
Can someone point me in the direction of more detailed documentation or help?

Hi basilvino,
Sorry for not replying to this earlier. I am the only guy who's handling support or development on stylebot, and I have had very little time to devote to stylebot lately. As a result, I sometimes miss out on replying to issues.
The default way stylebot works is by forming as a general a selector possible (Medium level of specificity explained here: https://github.com/ankit/stylebot/wiki/Levels-of-specificity-for-selection-of-elements).
Obviously, this is by no means perfect, and one of the features I might look to add in the future is to let the user pick between multiple possible selectors (so that you can choose if you want to have a specific or a more generic selector)


Automatically update API docs on release

Uses Quarto/quartodoc to build documentation instead of Sphinx.
Adds a Workflow to automatically build and upload the API docs on every push to main.

@ihnorton those warnings are for method arguments that are not referred in the method's docstring.

I like the updated theme, thanks for doing this!


http://elm-lang.org/examples/key-presses

http://elm-lang.org/examples/key-presses gives different results on firefox (42.0 Ubuntu)
and chromium
firefox: "The last key you pressed was: '\0'"  for letters
chromium: "The last key you pressed was: 'a'" (for letter 'a')
chromium: arrows ignored
firefox: arrows decoded to '%' '(' '\''  '&'

You are reporting this in the wrong repository. The right repository for reporting it is the one that already has a report of this issue (https://github.com/elm-lang/core/issues/326) as well as a pull request fixing it (https://github.com/elm-lang/core/pull/435).

Please close this issue.


Improve typing for load() function

Description of change
More accurate typing is provided for load() method of Loader.

Codecov Report

Merging #5990 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #5990   +/-   ##
=======================================
  Coverage   70.55%   70.55%
=======================================
  Files         208      208
  Lines       10530    10530
=======================================
  Hits         7429     7429
  Misses       3101     3101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e1e4a...0066e7f. Read the comment docs.


DOC: tone down the text of the "legacy" admonition

The "may be removed in the future" phrase was making users panic and mix "legacy" and "deprecated". Thus try to be more precise in what message we are sending.
See, for instance,
https://github.com/scipy/scipy/issues/21571, https://github.com/scipy/scipy/issues/21258, or an "interp1d is not supported anymore" comment on SO, to name just a few.

Thanks Pamphile! Let's see what kind of effect will https://github.com/scipy/scipy/pull/21849 have :-).


Add section with list of available plugins.

we've added them a while ago. We have 3 plugins now, more to come. They are in https://github.com/sb-mig/sb-mig/blob/master/README.md file


[CUR-1031] fix: update sanity query for equality of subject title

Description
Music year: 2017

List of changes
Changed GQL query to search by title instead of slug (no slug available in sanity)
Changed query to look for equality instead of matching

Issue(s)
PE and RE had switched explainers in prod due to fuzzy matching during querying. Hadn't had the issue before as most subjects are single words and not phrases
How to test

Go to https://deploy-preview-2966--oak-web-application.netlify.thenational.academy/teachers/curriculum
Click on Physical education primary/secondary
You should see the correct explainer
Same for RE

Screenshots
How it used to look (delete if n/a):

How it should now look:

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

Questions, if no slug how was this producing any of the correct results?

Questions, if no slug how was this producing any of the correct results?

Yeah, it had me stumped too. But it was using "match" on subjectSlug, so for one worded subjects ("maths") and ("Maths"), then it would be fine. stuff like art and design / cooking and nutrition are fine as there's no other likeness in other subjects. @SarahMcKinless' theory of them both having 'education' got pretty inconsistent results
Using matches:

Using eq:

If this works as a hot fix we should add a slug in after the fact, else changes to title will break in future updates to the content

If this works as a hot fix we should add a slug in after the fact, else changes to title will break in future updates to the content

I thought the same thing. Notion ticket here: https://www.notion.so/oaknationalacademy/Tech-debt-Create-slug-field-in-sanity-for-curriculum-overview-13726cc4e1b180df8395cc67e39c60fb?pvs=4

Yeah, it had me stumped too...

But there is no subjectSlug still right? So is that don't a fuzzy match on all the fields or something?

Yeah, it had me stumped too...

But there is no subjectSlug still right? So is that don't a fuzzy match on all the fields or something?

It's filtering just on the "Subject" field which is just the title
subject: { matches: $subjectSlug }

:tada: This PR is included in version 1.618.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Default bitstream

This PR adds default bitstream which sets all unused IOs to input mode to the qlf_k4n8 FASM database.

@lnsharma @tpagarani I see that from now on "slow" and "fast" VPR arch variants should now have different timings. How do I generate them for both corners? I've found design_variables_slow.yml and design_variables_fast.yml under FPGA2424_QLFK4N8_UMC22_task but they have the same content.

@lnsharma @tpagarani I've removed the updated VPR arch XML as it is already pushed. I left only the default bitstream. Please review an merge.


Prepend /bin/sh when running dump-test-vectors.sh

While this should be redundant, it is not in my experience. Though I had the execution permission set, my system did not want to execute this script. It is not clear to me why, since the error would only say "file not found", hence I opted for this simple workaround.

I found the real issue! Let me change the PR.

@mitschabaude This should work on all platforms that worked before, as all platforms that had /bin/bash should have /bin/sh too, but FWIW I don't see how the script could be executed on Windows given that it depends on Bash.

cool, thanks!


Support ID scalar as a custom scalar

This changes the generation of the ID scalar to be treated as a custom scalar that can be modified by the user.
This is implemented by request from #3379.

This looks good, thanks for doing it so quickly. It seems to be failing on one of the codegen test configurations though. 🤔

Detected SAST Vulnerabilities


Common replacement - Better replace "will be sealed off" things in one code

Summary
Brief explanation of the feature you'd like to request.
https://github.com/quisquous/cactbot/blob/e524fe8b9dafa6256feaa1094a480028889baf92/ui/raidboss/timeline.js#L41-L67
I think common replacement things needs to be gather in common.js or something and make it replace after GetReplacedSync function. like, GetReplacedCommon executes afterGetReplacedSync,  GetReplacedText happens.
':([0-9]{4}):(.*) will be sealed off': ':$1:15초 후에 $2(이|가) 봉쇄됩니다\.',
This needs to be in every [areaName].js file which contains "will be sealed off" things now.
This makes code maintenance complicated.
I think making replaceCommon will make better translating timelines.
or merge replaceCommon with replaceSync before using replaceSync object to replace timelines
Example
const replaceCommon = {
  ':([0-9]{4}):(.*) will be sealed off': {
    de: ':$1:Noch 15 Sekunden bis sich der Zugang zu $2 schließt',
    fr: ':$1:Fermeture $2 dans',
    ja: '$1:$2の封鎖まであと',
    ko: ':$1:15초 후에 $2(이|가) 봉쇄됩니다',
  },
  'is no longer sealed': {
    de: 'öffnet sich erneut',
    fr: 'Ouverture ',
    ja: 'の封鎖が解かれた',
    ko: '의 봉쇄가 해제되었습니다',
  },
}

Something like this
Some problem with is no longer sealed
Some timeline has specific area names in front of is no longer sealed. like,
https://github.com/quisquous/cactbot/blob/e524fe8b9dafa6256feaa1094a480028889baf92/ui/raidboss/data/02-arr/raid/t5.txt#L11
Actually, there is no need to specify the area name, but it just did. This makes example code I wrote above does not change correctly because of space-bar differences by languages. Especially, Japanese(does not use spacebar between words) and Korean(has postpositional particle).
Usually, it's like,
https://github.com/quisquous/cactbot/blob/e524fe8b9dafa6256feaa1094a480028889baf92/ui/raidboss/data/05-shb/dungeon/akadaemia_anyder.txt#L6
So, this does not differ by spacebar usage.
Example
"바하무트의 오른손 is no longer sealed" should be "바하무트의 오른손의 봉쇄가 해제되었습니다" (bold font is area name)
So, we need to remove spacebar between area specified names and "is" on Korean translation.
But,
".*is no longer sealed" → ".*의 봉쇄가 해제되었습니다"
does not need to remove spacebar.
Solution
I think just not writing specific area name in front of is no longer sealed is better.
Like, change 00:0839:The Right Hand of Bahamut is no longer sealed to 00:0839:.*is no longer sealed
is no longer sealed is only used when resetting timeline sync. So, it does not need specific area names.

This is a really good idea.

I think common replacement things needs to be gather in common.js or something and make it replace after GetReplacedSync function. like, GetReplacedCommon executes afterGetReplacedSync, GetReplacedText happens.

I'm not sure the right place to put this.  Probably this could just live in popup-text.js as well?  It seems fairly raidboss-specific.
I think there are a number of other "common" translations that could definitely be added there, like all the ones added from translate_fight.py: https://github.com/quisquous/cactbot/blob/master/util/translate_fight.py#L54-L76
I'm not sure what you think, but I wonder if it would be good to separate out common texts from common syncs separately? This would help with collisions in #1008.
I think the other addition to this is that I want the tests in #1008 to take this common replacement into account when figuring out what needs translations and what does not.

Some timeline has specific area names in front of is no longer sealed. like,

Yes, agreed that these can all be changed to 00:0839:.*is no longer sealed.  Having to remove a space is also pretty awkward.
Are there any cases that need the specific zone with "is no longer sealed"? I am having a hard time thinking of any, so hopefully there are not.

#1049 is dealing with this.


[cinder-csi-plugin] Bump driver version to 1.2.1

What this PR does / why we need it:
Bump cinder csi driver version to 1.2.1
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

[cinder-csi-plugin] Bump Cinder CSI Driver version to 1.2.1

/test cloud-provider-openstack-multinode-csi-migration-test


Randomised name generation

I'd like to be able to randomise the name generation such that two compilations result in entirely different names. This makes it harder to reverse-engineer the compilation since every continuous integration build of the software would have far less in common.
I propose either of the following, and will put together a PR if it would be likely to be accepted:

Make DefaultNameGenerator and NameGenerator public, and add a public accessor in CompilerOptions (I'll supply my own, likely a subclass of DefaultNameGenerator)
Or, add CompilerOption.randomiseNameGeneration, and have DefaultNameGenerator.reset() shuffle instead of sort those two arrays.

I'm leaning toward saying no to this, because we want builds to be completely deterministic. It's not a bad idea though so I would encourage you to publish it and maybe we can link to it from the wiki somewhere even if we don't accept it into the official project.

It's been done before. At one point we have a special NameGenerator that
takes in a seed to randomize the variable names.
The level of obfuscation and the size penalty makes it not worth it so I
deleted it at some point (IIRC).
On Wed, Jul 6, 2016 at 11:02 PM, Tyler Breisacher<EMAIL_ADDRESS>wrote:

I'm leaning toward saying no to this, because we want builds to be
completely deterministic. It's not a bad idea though so I would encourage
you to publish it and maybe we can link to it from the wiki somewhere even
if we don't accept it into the official project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/closure-compiler/issues/1873#issuecomment-230905565,
or mute the thread
https://github.com/notifications/unsubscribe/ABjAWisb8d4lNFA1hP78BolHHaBIDhwuks5qTBfggaJpZM4JGQ6S
.

@acleung I've found a way to prototype it using reflection (to work around the package protection), by calling favors() followed by reset() to establish randomised values of CharPriority.occurrence while preserving the order of sections lowercase, uppercase, numbers, symbols. This results in identical file size but entirely random output. Would this impact compressed size? Otherwise I'm not sure what the size penalty could be.  So my PR would be just to make this class and interface public, with a public options setter.

I've actually considered adding this in as well. It makes it harder for malware to target your code if it is constantly changing.
I was simply going to make a custom build to do this however.

If there is enough interest, it is probably worth rewriting one. If it
takes in a seed, it doesn't break the compiler's determinism requirement.
It impacted compressed size because the name generator does tricky things
that compress well after gzip.
On Thu, Jul 7, 2016 at 5:42 AM, Chad Killingsworth<EMAIL_ADDRESS>
wrote:

I've actually considered adding this in as well. It makes it harder for
malware to target your code if it is constantly changing.
I was simply going to make a custom build to do this however.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/closure-compiler/issues/1873#issuecomment-231066349,
or mute the thread
https://github.com/notifications/unsubscribe/ABjAWoN2MjexvTJsQ6Cdqsh3OJwf2pP4ks5qTPRFgaJpZM4JGQ6S
.

Isn't it enough to simply randomize the order of supported characters?
https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/DefaultNameGenerator.java#L84-L96

It's what I used to do, before sort was added: https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/DefaultNameGenerator.java#L171

I have a working prototype, which I'll clean up and post as a PR if I it's likely to be accepted.

Randomizing the support letters was the previous approach. It still have a
bit of size penalty but probably not significant enough for most
applications.
On Mon, Jul 11, 2016 at 7:59 AM, Steve Spencer<EMAIL_ADDRESS>wrote:

I have a working prototype
https://github.com/google/closure-compiler/issues/1873#issuecomment-230986761,
which I'll clean up and post as a PR if I it's likely to be accepted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/closure-compiler/issues/1873#issuecomment-231760512,
or mute the thread
https://github.com/notifications/unsubscribe/ABjAWpNCGl-eza2IYlQ6CBZZd6sU0eJgks5qUlpTgaJpZM4JGQ6S
.

have a working prototype, which I'll clean up and post as a PR if I it's likely to be accepted.

@supersteves can you relink to your patch? The earlier link isn't right.

@dimvar I was linking to the comment above.

by calling favors() followed by reset() to establish randomised values of CharPriority.occurrence while preserving the order of sections lowercase, uppercase, numbers, symbols.

Effectively it's as if I've shuffled each subsection of the char arrays if it weren't for the Array.sort recent additions. By subsection I preserve the grouping of lowercase, uppercase and numbers, but reorder the array within those subsequences (sort-of preserving the same camelcase).
This approach works well, but no patch yet, it's a reflection based prototype/hack in external code, I'll need to rework it into a PR and will only do it if it's likely to be of interest.

It seems that your approach is what others in this thread also recommend, so yes, we'll likely accept it.

I'm certain I've seen existing code that does this already. Let me see if I can get it open-sourced so you don't have to duplicate the work.

OK, @blickly just assigned the issue to you.

Should be fixed by https://github.com/google/closure-compiler/commit/2bb100fb42b9f50e28319291e07e451354c078ed

:+1: Thanks!


Host firewall tests

This PR disables the host firewall by default in CI. It will only be enabled for all tests when the label ci/host-firewall is set. Tests that specifically enable the host firewall (see below) will still run regardless of the label.
The two last commits then add two new tests for the host firewall:

A test of a fromCIDR+toPorts host policy (based on the existing fromCIDR+toPorts test) from the third node.
A NodePort test with an ingress+egress host policy (initially written to catch a potential regression on the path client->node1->backend@node2).

I verified ci/host-firewall works by running the tests with that label in #12672.

test-me-please

Coverage increased (+0.003%) to 37.184% when pulling 9bb45034a98c8c2e41b1965ef91ffeccc771305e on pr/pchaigno/host-firewall-ci into 359162905e2b14155e417fa36bb8bfe1c4278707 on master.

retest-net-next

test-me-please

retest-gke

test-me-please

retest-4.9

retest-gke

From experience, having a label to run a particular set of tests will make the code to regress as soon this PR is merge. Even we are not enabling the host firewall by default, what's wrong on having more coverage for the host firewall?

My original post was a bit unclear so not sure we're on the same page. The new host firewall tests I added will run regardless of the ci/host-firewall label. I've clarified that :point_up:
On the general risk of regressions once we stop testing something, I agree. That is partly why I'm only making this change now that we also have some first host firewall tests.
Then, why don't I want the host firewall enabled by default in all tests? Because (1) with #12345, enabling the host firewall changes the path of packets in some cases (pod1@node1>node1 and pod1@node1->node2) and (2) it's not the default setup most users will run. I intend to use the new label to run additional tests on PRs that may impact the host firewall.

From experience, having a label to run a particular set of tests will make the code to regress as soon this PR is merge. Even we are not enabling the host firewall by default, what's wrong on having more coverage for the host firewall?

My original post was a bit unclear so not sure we're on the same page. The new host firewall tests I added will run regardless of the ci/host-firewall label. I've clarified that

:+1:

On the general risk of regressions once we stop testing something, I agree. That is partly why I'm only making this change now that we also have some first host firewall tests.
Then, why don't I want the host firewall enabled by default in all tests? Because (1) with #12345, enabling the host firewall changes the path of packets in some cases (pod1@node1>node1 and pod1@node1->node2) and (2) it's not the default setup most users will run. I intend to use the new label to run additional tests on PRs that may impact the host firewall.

Why can't we deploy Cilium to run with host firewall and run these tests (besides the setups that we already have)?

test-me-please

I pushed an update but this is currently blocked by #12834 so switching to draft.

test-me-please

test-me-please

test-me-please

retest-runtime

test-me-please


Update system-defined-device-properties2.md

fix old links

@DJm00n, thanks for the PR! I will add your suggested changes to an internal work item already in progress to update the links in the install docs.

Thanks @barrygolden !


[main] Upgrade to latest dependencies

Cron. -knative-prow-robot
/cc we don't use Prow
/assign we don't use Prow
Produced via:
./hack/update-deps.sh --upgrade --release v0.23
./hack/update-codegen.sh

Details:
bumping knative.dev/hack b6ab329...b5f6e25:
  > b5f6e25 Update OWNERS_ALIASES to match autogen in community (# 62)
bumping knative.dev/pkg 0c5259d...78b8140:
  > 78b8140 Use semantic equality for status update retries (# 2103)

Codecov Report

Merging #242 (0e46386) into main (7b8bf1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   80.32%   80.32%
=======================================
  Files          20       20
  Lines         747      747
=======================================
  Hits          600      600
  Misses        133      133
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8bf1e...0e46386. Read the comment docs.


check non Promises objects in latest Lab

Łukasz Pior found that there were some major changes some objects are not Promises anymore, some properties were renamed. We should check these Promises to make sure everything works.

https://github.com/jupyterlab/jupyterlab/blob/8413909e6c954288d5d3f3725ad2733a39fec125/CHANGELOG.md#changes-for-developers
There were some backward-incompatible changes between 0.32 and 0.33 (in semver while your version is less than 1.0, minor versions count as major, with backward incompatible changes allowed). The most prominent promise that is now synchronous is the connectTo mentioned in that change log.

Fixed

[x] connectTo
[x] panel.notebook renamed to panel.content

Found another issue I'm not seeing in the changelog. Publishing gist is not working.
Invoking it via toolbar or context menu causes:
Modal.js:42 Uncaught (in promise) TypeError: Class constructor f cannot be invoked without 'new'
    at new t (Modal.js:42)
    at e.create (gistPublishModal.js:73)
    at gistPublishModal.js:40

@LeeTZ you can merge PR I did and I will fix gist related issue in separate PR

@afshin can you please check if you will find any info what may cause errors when extending Dialog class.

Dialog problem fixed


Add New persona ANNA as discussed with cpacker

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Created a defined Persona called anna_pa.txt, a personal assistant for research.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Pre-defined already

[merged]


Text editing with corrections in readme (PT-BR)

Translate text to PT-BR instead of PT-PT.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Part of #18309

@ricardo-mello Thank you for  creating this PR.  However, since it was created, the underlying document has changed.  Can you please review and resolve the current merge conflicts?  It could be the changes to the underlying document are so significant that your changes are no longer relevant.  If the latter is the case, it might be easier to just close this PR and create a new PR with any changes you still feel are important to make.
If you need any assistance or have questions about resolving the merge conflicts, please reply back or contact someone in the Contributors Room on Gitter.
Thank you.


Bug: Production Backend Server crash because of bad merge changes

Issue Template
Description
The production backend server crashed due to a bad merge of recent changes.
Steps to Reproduce
Please provide step-by-step instructions on how to reproduce the issue:

Deploy the latest changes from the merged branch to the production server.
Observe the server crash

Expected Behavior
The backend server should handle the incoming requests without crashing, maintaining stability and performance.
Actual Behavior
The server crashes intermittently under high load, leading to downtime and service interruptions. Error messages indicate potential memory leaks and uncaught exceptions in the merged code.
Screenshots

Additional Context
Add any other context or information about the issue here.

Assigned @mehul-m-prajapati


can I  use the local F2D directly, not using urn.

Hi Michael，
Leaflet data needs server-side generation. Can I generate it locally?
Thanks!

Great question!
Yes, you can generate the images locally.
I wrote two blog posts, about 2D leaflet drawings, hoping that would help someone.  The first blog post covers leaflets and how to generate them locally.  This second blog post, covers the 'diff' part.
Take a look at the first blog post here:
https://forge.autodesk.com/blog/viewing-large-ocrterrain-images-forge-viewer
... and look for the title "2. Converting a large image (an OCR scan)"...
That should help you generate your own local leaflets.
It has a bash script to help convert, a large TIFF image (ie. OCR scan) into a bunch of jpg's (image tile pyramid) which you can then dump into folder and do this '2D compare' demo.
Note: this comparison code, is only for pixels... not for F2D vector stuff.  That will be a follow up blog post.  Is that what you are more interested in ?  F2D comparison?

Yes, I'm very interested in the comparison of F2D vector stuff , and if you post your follow-up blog ,  I'm glad to read your article.Thank you for answering my question. I will read your first blog  to find some inspiration.


Issue while converting with int8 support

Describe the bug
Hi! First of all thank you a lot for you great work! But when I try to add int8 support I got some errpor - can you pls help me to understand what needs to be changed?
Traceback (most recent call last):   File "convert_to_trt.py", line 39, in <module>     device=device)   File "/root/space/mmdetection-to-tensorrt/mmdet2trt/mmdet2trt.py", line 147, in mmdet2trt     int8_calib_algorithm=int8_calib_algorithm)   File "/root/space/torch2trt_dynamic/torch2trt_dynamic/torch2trt_dynamic.py", line 561, in torch2trt_dynamic     config.set_calibration_profile(profile) AttributeError: 'tensorrt.tensorrt.IBuilderConfig' object has no attribute 'set_calibration_profile'
To Reproduce
`opt_shape_param = None
config_path = '/user_home/packages_atss_stage2/logs_packages_atss/stage2_packages_atss.py'
model_path = '/user_home/packages_atss_stage2/logs_packages_atss/epoch_10.pth'
result_path = '/user_home/packages_atss_stage2/logs_packages_atss/int8_mmdet_to_trt.pth'
fp16 = False
int8 = True
device = 'cuda:0'
trt_log_level = 'VERBOSE'
return_wrap_model = False
max_workspace_size = 1 << 30    # some module and tactic need large workspace.
trt_model = mmdet2trt(config_path,
model_path,
opt_shape_param=opt_shape_param,
fp16_mode=fp16,
int8_mode=int8,
max_workspace_size=max_workspace_size,
trt_log_level=trt_log_level,
return_wrap_model=return_wrap_model,
device=device)
torch.save(trt_model.state_dict(), result_path)`
enviroment:
Docekr file from repo
Additional context
Add any other context about the problem here.

Hi
Guess It is caused by TRT version. Update TRT 7.1, rebuild mmcv and amirstan_plugin might fix this.
The time when I create the dockfile, mmcv did not have a cuda11 prebuild version, and all images with TRT7.1 (20.06~) are cuda11. I will create a new one this weekend.

Updating to TRT 7.1 even keeping cuda 10.2 (installed before) worked for me. Additionally I just had to re-build amirstan_plugin. mmcv kept as is.

@vedrusss Cool! Thanks for your report. And It seems that K80 does not support int8. Read support matrix and fp16 slower than fp32 for detail.
@maksimovkonstantin There might be something wrong with the prebuild mmcv-full+cu11, I have report to openmmlab, hope they can solve the problem. It might take some time. You can follow @vedrusss.


Update manager.yml

The actions used to add reviewers was not working anymore, it was failing with
 Error: HttpError: Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the [organization/repository] repository.

even if the collaborator is part of the repo and org.
Other folks were also noticing this error : https://github.com/delivery-much/actions-assigner/issues/7#issuecomment-1439246668 so I don't think it's something on my end. I updated with another one that does the same thing.

Checks are failing for unrelated reasons, I'll try to spend some time to update this to ruby 3.1 this week if possible

@Shaeli I found a solution in https://github.com/github/entitlements-config/pull/26
When it gets merged, you will be able to add the changes to your branch and hopefully it'll unblock you :)


[ja]docs/concepts/security/security-checklist.md #47547

Description
Translated content/en/docs/concepts/security/security-checklist.md into Japanese.
The following Open Issues have been addressed https://github.com/kubernetes/website/issues/47547
Issue
https://github.com/kubernetes/website/issues/47547
Closes: #

@Okabe-Junya
Thank you for your confirmation.
This is our first submission. We apologize for any inaccuracies.
We have made several updates following the guidance below, including the points you mentioned.
We have referred you to other documents committed to the master branch for any unclear points.
We hope you will check them when you have a chance. Thank you in advance.

参考: https://kubernetes.io/ja/docs/contribute/localization/#style-guide

@t-inu
こちらレビューいただくことはできますか？
自分の方でも確認してlgtm, approveできたらと思います

@luna029
I've reviewed until the "認証と認可" section.
Thereafter, please modify the followings first. Then I'll resume the review.

pod -> Pod
Remove spaces between words (except between English words)

@t-inu
Thank you for pointing out some things.
My understanding has improved. Please let me correct it again. I plan to address it over the weekend.
I would also like to add the following translation guidelines along with example sentences to the points I have been pointed out.
https://kubernetes.io/ja/docs/contribute/localization/#style-guide
I appreciate your help.

@luna029

Please let me correct it again. I plan to address it over the weekend.

Are you still working on the corrections for the “ネットワークセキュリティ” section and after?
Please let us know the status.

@t-inu
I apologize for the delay.
I have updated it so I hope you will proceed with your review.


Lazysizes integration together with slick slider

Hi, there!
Recently I've implemented your plugin into my project and it works really great! I managed to enable it for content of type: images, background_images and iframe videos. In my project I use a lot of sliders as each sliding element contains various content of the types mentioned above. My problem is that right now all the sliding items are all 'lazyloaded' at once, immediately right after the particular slider gets visible into the view port. This is Ok to a certain extent, but as my big struggle is to reduce the page response and load time, I want to gain control over state of sliding elements and lazyload only those of them which are visible into the current active slide. I know that slick slider has lazyloading function as well, but the main reason that I choose your plugin is that it is SEO friendly, while most of the other lazyloading plugins do not guarantee that. So my question is: "Is it possible to lazyload only elements visible into the current active slide inside slick slider?" I believe that I can reduce the number of request this way and achieve some performance improvement. And if this is possible, then google will still be able to see and index all the content inside my sliders, right?
These are my lazysizes configurations which I include into the head part of my pages:
<script>(function(){
window.lazySizesConfig=window.lazySizesConfig||{};
window.lazySizesConfig.loadMode=1;
window.lazySizesConfig.expand=10;
window.lazySizesConfig.expFactor=1.5
})();
</script>

<script src="/plugins/ls.unveilhooks.min.js" type="text/javascript"></script>
<script src="lazysizes.min.js"></script>

Right after these, I include slick slider js scripts and initialization.
Looking forward for your answer! Any help or advice will be appreciated!
Greetings,
Eli

I would need an example. Please create a jsfiddle/codepen...

also if the slick slider is the first section of the page, will all the images from all the slides will be loaded immediately
here is an example so we can check
https://codepen.io/aatalla/pen/yEExKO

@a-atalla
I can not fully replicate your issue, but I see some problems. First what I see:

As you can see there are only three images loaded and not all and lazysizes does a pretty good job here, because lazysizes starts to download only the first visible image and then after that preloads the next two images are loaded. No other lazyloader is so intelligent to postbone the preload images.
But now to your main problem:
If you remove your slick initialization code (and this might happen in your app). lazysizes will download all images. The reason for this is that you do not specify image dimensions.  Only if those images are loaded or slick slider is initialized they are not in view anymore.
You can solve this by:
a) specifying image dimensions (check documentation) and pre defining the slider (set height and overflow hidden) good solution a little bit more work
b) initializing lazysizes after slick slider (check documentation) bad solution, but easy to implement.

Hi!
Thank you for your quick answer and excuse my late response! I checked your demo and I also created mine. Here it is https://jsfiddle.net/estefanova/hopn3wv7/55/ . From what I see in my demo everything is working perfectly and as expected. I read your detailed explanations so I will recheck the implementation in my local project( like order of scripts inclusion and execution ) because I assume that probably something there is not quite Ok.
Thank you very much once again!
Greetings

Also use window.lazySizesConfig = {loadHidden: false} for slick with property - fade: true.

@estefanova Thanks for responding to this post with your solution. It really helped me with a very similar issue I was having with slick and lazyloading