Fixed merge issues

Docs Build status updates of commit ca05514:
:clock10: Full build: the average full build time is 11 min(s) 51 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit ca05514:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3d06d63:
:clock10: Full build: the average full build time is 11 min(s) 52 sec(s), this is based on the last 1000 build(s) for this repository.

@FilippSe - metadata looks incorrect. Metadata is used when @tomkau creates the xml file that is checked into code so that Get-Help works in terminal. You can check with @get-itips for guidance. This is also written up here: https://github.com/MicrosoftDocs/office-docs-powershell/blob/master/repo_docs/NEW_CMDLETS.md#parameter-metadata  You can check some of the other Skype cmdlets for reference to what Tom needs too.

Docs Build status updates of commit 3d06d63:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 22588ca:
:clock10: Full build: the average full build time is 11 min(s) 54 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 22588ca:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 43fecdb:
:clock10: Full build: the average full build time is 11 min(s) 54 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 43fecdb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsTranslationRule.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Feature: Selective disk save

Save only certain file type (eg: image only, pdf and zip, ...)

Duplicate of #75


Minor improvements

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.56%. Comparing base (1be6eee) to head (2252f10).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #568   +/-   ##
=======================================
  Coverage   99.56%   99.56%
=======================================
  Files          85       85
  Lines        2302     2302
  Branches      224      224
=======================================
  Hits         2292     2292
  Misses          5        5
  Partials        5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


support for other maps [not a issue]

gmaps is more readable in my region,
maybe option for select map source?
code for gmaps (smaller file, faster render):
downloadFile("http://maps.googleapis.com/maps/api/staticmap?center="+ String(mapCenter_.lat) + "," + String(mapCenter_.lon)+"&zoom="+ String(zoom_)+"&size="+ String(mapWidth_) + "x" + String(mapHeight_)+"&format=jpg-baseline&maptype=roadmap", getMapName(), progressCallback);

cool suggestion and it really looks nice. I'm surprised that it works without API key...

me too :)
so, 192px height map looks ok and we have a 4 lines for text,
maybe Dst from third line move to first or second line
and a third line used exclusively for: From CITY and Country if exists
and the fourth line, similarly, To CITY and Country if exists
in old OLED version I had such a modification

I implemented the switch. The constructor of the GeoMaps class now has one more parameter to indicate the MapProvider. Do you agree we can close this issue?

👍


Fails Attempting to add user to filevault

Here are the logs, as previously mentioned on Slack:
Mar 14 17:11:31 bmarks-mp2013 installer[6848]: Starting installation: Mar 14 17:11:31 bmarks-mp2013 installer[6848]: Configuring volume "Macintosh SSD" Mar 14 17:11:31 bmarks-mp2013 installer[6848]: Preparing disk for local booted install. Mar 14 17:11:31 bmarks-mp2013 installer[6848]: Free space on "Macintosh SSD": 492.23 GB<PHONE_NUMBER>52 bytes). Mar 14 17:11:31 bmarks-mp2013 installer[6848]: Create temporary directory "/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T//Install.6848QholQw" Mar 14 17:11:31 bmarks-mp2013 installer[6848]: IFPKInstallElement (1 packages) Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: Adding client PKInstallDaemonClient pid=6848, uid=0 (/usr/sbin/installer) Mar 14 17:11:31 bmarks-mp2013 installer[6848]: PackageKit: Enqueuing install with framework-specified quality of service (utility) Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: ----- Begin install ----- Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: request=PKInstallRequest <1 packages, destination=/> Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: packages=(         "PKLeopardPackage <file://localhost/Library/Application%20Support/JAMF/Downloads/sfdc-fde-rekey.pkg#fde-rekey.pkg>"     ) Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: Session UUID file exists - will not overwrite /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/C/PKInstallSandboxManager/B574324D-7714-4FC1-837F-D8F20163A1DE.activeSandbox Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: Extracting file://localhost/Library/Application%20Support/JAMF/Downloads/sfdc-fde-rekey.pkg#fde-rekey.pkg (destination=/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/C/PKInstallSandboxManager/B574324D-7714-4FC1-837F-D8F20163A1DE.activeSandbox/Root, uid=0) Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: prevent user idle system sleep Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: suspending backupd Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: Using trashcan path /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/PKInstallSandboxTrash/B574324D-7714-4FC1-837F-D8F20163A1DE.sandboxTrash for sandbox /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/C/PKInstallSandboxManager/B574324D-7714-4FC1-837F-D8F20163A1DE.activeSandbox Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: Shoving /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/C/PKInstallSandboxManager/B574324D-7714-4FC1-837F-D8F20163A1DE.activeSandbox/Root (1 items) to / Mar 14 17:11:31 bmarks-mp2013 installd[1105]: PackageKit: Executing script "./postinstall" in /private/tmp/PKInstallSandbox.GwrS4o/Scripts/com.github.square.fderekey.8yW33I Mar 14 17:11:32 bmarks-mp2013 installd[1105]: ./postinstall: 2017-03-14 17:11:32.304 sysadminctl[6857:28555970] Creating user record… Mar 14 17:11:32 bmarks-mp2013 installd[1105]: ./postinstall: 2017-03-14 17:11:32.910 sysadminctl[6857:28555970] Assigning UID: 2 Mar 14 17:11:32 bmarks-mp2013 installd[1105]: ./postinstall: 2017-03-14 17:11:32.927 sysadminctl[6857:28555970] Creating home directory at /Users/fderekey Mar 14 17:11:34 bmarks-mp2013 installd[1105]: ./postinstall: 2017-03-14 17:11:34.377 sysadminctl[6872:28556102] Killing all processes for UID 2 Mar 14 17:11:34 bmarks-mp2013 installd[1105]: ./postinstall: 2017-03-14 17:11:34.377 sysadminctl[6872:28556102] Securely removing fderekey's home at /Users/fderekey Mar 14 17:11:34 bmarks-mp2013 installd[1105]: ./postinstall: 2017-03-14 17:11:34.490 sysadminctl[6872:28556102] Deleting Public share point for fderekey Mar 14 17:11:34 bmarks-mp2013 installd[1105]: ./postinstall: 2017-03-14 17:11:34.492 sysadminctl[6872:28556102] Deleting record for fderekey Mar 14 17:11:34 bmarks-mp2013 installd[1105]: ./postinstall: 2017-03-14 17:11:34.507 sysadminctl[6872:28556102] AOSKit INFO: Disabling BTMM for user, no zone found for uid=2, usersToZones: (null) Mar 14 17:11:34 bmarks-mp2013 installd[1105]: ./postinstall: EROOR! Failed to add user "fderekey" to FileVault... Mar 14 17:11:35 bmarks-mp2013 installd[1105]: PackageKit: releasing backupd Mar 14 17:11:35 bmarks-mp2013 installd[1105]: PackageKit: allow user idle system sleep Mar 14 17:11:35 bmarks-mp2013 installd[1105]: PackageKit: Install Failed: Error Domain=PKInstallErrorDomain Code=112 "An error occurred while running scripts from the package “sfdc-fde-rekey.pkg”." UserInfo={NSFilePath=./postinstall, NSURL=file://localhost/Library/Application%20Support/JAMF/Downloads/sfdc-fde-rekey.pkg#fde-rekey.pkg, PKInstallPackageIdentifier=com.github.square.fderekey, NSLocalizedDescription=An error occurred while running scripts from the package “sfdc-fde-rekey.pkg”.} {         NSFilePath = "./postinstall";         NSLocalizedDescription = "An error occurred while running scripts from the package \U201csfdc-fde-rekey.pkg\U201d.";         NSURL = "file://localhost/Library/Application%20Support/JAMF/Downloads/sfdc-fde-rekey.pkg#fde-rekey.pkg";         PKInstallPackageIdentifier = "com.github.square.fderekey";     } Mar 14 17:11:35 bmarks-mp2013 installd[1105]: PackageKit: Running idle tasks Mar 14 17:11:35 bmarks-mp2013 installer[6848]: install:didFailWithError:Error Domain=PKInstallErrorDomain Code=112 "An error occurred while running scripts from the package “sfdc-fde-rekey.pkg”." UserInfo={NSFilePath=./postinstall, NSURL=file://localhost/Library/Application%20Support/JAMF/Downloads/sfdc-fde-rekey.pkg#fde-rekey.pkg, PKInstallPackageIdentifier=com.github.square.fderekey, NSLocalizedDescription=An error occurred while running scripts from the package “sfdc-fde-rekey.pkg”.} Mar 14 17:11:35 bmarks-mp2013 installd[1105]: PackageKit: Removing client PKInstallDaemonClient pid=6848, uid=0 (/usr/sbin/installer) Mar 14 17:11:35 bmarks-mp2013 installd[1105]: PackageKit: Done with sandbox removals Mar 14 17:11:36 bmarks-mp2013 installer[6848]: Install failed: The Installer encountered an error that caused the installation to fail. Contact the software manufacturer for assistance.

@manicslothpdx Can you try a few things?
sudo sysadminctl -addUser 'fderekey' -password 'test' -UID 2
git clone https://github.com/square/fde-rekey.git
cd fde-rekey
sudo ./payload/var/root/fdeadduser fderekey test
sudo fdesetup list
You should see user 'fderekey' in the FileVault list.

The command fdesetup list shows my user name on this test Mac and a long string instead of the user name fdeadduser: 10D5D1E2-62A5-482E-B1E0-E05E74B41D71
The command fdesetup status gives the following results:
FileVault is On. FileVault master keychain appears to be installed.

Issue here appeared to be configuration profile for password strengths on accounts. and the random password generator didn't meet the requirements.
This is fixed with 124cea08ad59ca18755b8be482dc7b6df3746683
Which makes the new password 30 characters, with upper, lower, digit and special characters

Seems this issue is present again with the current release on 10.12.5


Editor spatial understanding

This covers #290 by making Spatial Understanding compatible with the editor. It works with and without remoting. It's not quite ready to go in, but I'd like to get feedback (especially on the "TODOs" and a few questions I have).
Everyone following along, feel free to grab this code and try it out (and let me know if you notice any issues!), but I expect to do some history rewriting/rebasing on this before it goes in, so don't base any work on this you're not prepared to hand-merge later.
See Microsoft/HoloToolkit/pull/67 for the changes to SpatialUnderstanding.dll.

Hi @mrbobbybobberson, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Robert El-Soudani). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Open Question:  Should I commit the pdbs with the dlls or not?  If I don't commit the pdbs, is there an official symbol server I can index them on so they're not lost?

@jevertt, I'm especially interested in your feedback on this.  Please take a look.  Thanks!

@darax, if you have a chance to look, I'd love your feedback on this.  Thanks!

looks good!  For the todos - I don't believe the in/out tags actually matter to the compiler (though, not 100% certain of that), but nice to get right for the reader.

Ok, I got through all the feedback so far and made changes locally.  I'm doing some testing and will push my commit soon.  Thanks for the reviews thus far!

I believe this is ready to go in again after the big merge with #459.  The one thing I didn't get a chance to do is clean my house and take a clean scan of a medium-sized room with home furniture (couch, desk, chairs, table) to include as the default mesh in the spatial understanding test scene.  Unfortunately, cleaning my house is the bottleneck on that!

@mrbobbybobberson what should I be looking for when testing this?

@HodgsonSDAS, things that I tried with the spatial understanding scene that would be great for you or anyone else to also try:

Editor with ObjectSurfaceObserver loading a mesh from disk.
Editor with remoting for mesh.
Real build pushed to device.
Real build pushed to emulator.

@mrbobbybobberson Please also be aware I've added a spatial understanding readme document in PRhttps://github.com/Microsoft/HoloToolkit-Unity/pull/472.
When that's added, would you please update that readme with your changes, as well as add a test scene?

Cool, I see that #472 is now in.  Since I can't bear to push this without a good default room, I'll wait till the weekend, clean up a room in my apartment, setup some furniture nicely, and do a scan.  Then, I'll convert that scan to FBX and replace the existing mesh in the spatial understanding test room before I update the PR.

Sorry for being pushy but would it be possible to prioritize this "absolutely crucial feature" to be finally pushed to the main branch ? I'm stuck using mrbobbybobberson's branch ATM and I would really love to stay up to date with the main branch, thanks in advance guys.

@mrbobbybobberson Hi, when this fix could be merged? Really can't wait to use SpatialUnderstanding in editor.

Sorry for the delay, folks.  My day job has been keeping me exceptionally busy the last few days.  Ok, I'll have to give up on getting a good default room into the test scene for now (but I'll create a new issue to track it), and I'll just add the notes in the readme and this should be good to go.

Thanks a lot hombre

Hey guys, If you're interested in getting this merged in a little faster please try pulling the request and testing it out for your self. We do require two reviews before merges can be completed.
I've already tested this myself and seems to be working as outlined be working really well.

HodgsonSDAS: how do we fetch the changes in this pull request and merge them ourselves into HoloToolkit? Or is it best to just grab mrbobbybobberson's repo directly?

Yeah, just grab a copy of his branch directly to test.

Got it!  It appears to work just fine now. Wonderful! Can't wait to see it mainlined into master branch.


[Docs] Extra copy icon in the Scoop installation guide

Current State
There is an extra copy icon in the Scoop installation guide to download Mesheryctl the command line client for Meshery.
Desired State
There should not be any extra copy icon in the installation guide.
Screenshot

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

I would like to fix this @Mr-DG-Wick

It's all your's @Deepansharora27 .🎉

Any updates here @Deepansharora27 ?

Hi @sayantan1413
I am not able to get to the root of the issue, i.e. what is causing the issue in the First place
Have debugged everything ranging from the CSS File Code to the mesheryctl.md code but everything seems to be be correct there
Can you please have a look at this and tell me ?

Also, Tagging @warunicorn19 @leecalcote

@alphaX86

@Deepansharora27 you'd have to take a look at the code in scoop.md. We use clipboard.js for this copy-to-clipboard feature, there's probably an incorrect class name or an opened <div>.  The class name is supposed to follow this convention. https://docs.meshery.io/project/contributing/contributing-docs#clipboard-feature

@Deepansharora27 check the markdown code as @warunicorn19 said. A tag maybe repeated in this case... or it may be due to misalignment... Let me know if you have any problems

Got the Issue
Making the Pull Request Now
@alphaX86 @warunicorn19 @leecalcote
Thanks for the Help !!
I reinvestigated the Scoop.md Markdown file and the issue was present there.

I have made a Pull Request, you can have a look


[BREAKS API, DATABASE] v0.0.2: "UUIDs Everywhere"

This is completely backwards incompatible with previous versions. There is no migration.
The theme is UUIDs. Resources and Commands are referred to with UUIDs. In particular this distances chitin from your file system. File paths are irrelevant, so long as the resource referred to with a given UUID is in the database.

Correctly catch "bad" (non-zero) return codes
Store stdout/stderr for non-zero exits and attach them as CommandText
Clean up token parsing, get rid of ignore_parents garbage
Introduce API breaking changes and create add_file_record2, check_integrity_set2 and check_status_set2
Store a uuid_cmd_str, that converts absolute paths to "chitin:\" paths
FINALLY add a much needed SIGINT handler (lets running jobs finishes, clears cmd_q with status 128)
Runs are now Jobs, RunMeta now belong to the parent of the jobs: Experiment
New exe_script entry point for executing scripts through chitin externally from the shell
Experiment are group in a named Project
Event is now Command, EventGroup is CommandBlock
Item is now Resource, the primary key is a UUID, not the file location
chitin supports deleting and moving; deleting marks a Resource as a "ghost", creating the same file in the same location creates a new Resource (with a new UUID). Moving a Resource keeps the UUID and updates the path.
Refactored lots of util
Lots of lovely web stuff
Again, this will totally not work with your existing chitin install.

bang bang that is the sound of your productivity increasing (or your previous database blowing up, idk)


Mediapipe integration with OR-Tools

System information (Please provide as much relevant information as possible)

OS: Ubuntu 18.04
Programming Language and version: C++
MediaPipe version: 0.8.0
OR-Tools version: v9.0 / v8.0
Bazel version (if compiling from source): 4.1.0

Hi, I have a problem with integration of both Mediapipe and OR-Tools in the same repository.
Both are included in Bazel's BUILD as following:
git_repository(
    name = "com_google_ortools",
    commit = "8d19323", # release v8.0
    remote = "https://github.com/google/or-tools.git",
)

_MEDIAPIPE_VERSION = "0.8.0"

http_archive(
    name = "mediapipe",
    sha256 = "0b129a28864fd2cd2822948621645efb9d62b6d043d1c4da3cf2d01886bfd901",
    strip_prefix = "mediapipe-{}".format(_MEDIAPIPE_VERSION),
    url = "https://github.com/google/mediapipe/archive/{}.tar.gz".format(_MEDIAPIPE_VERSION),
)

Firstly, I have tried to use Mediapipe 0.8.0 with the recent OR-Tools v9.0, but the build fails with a Glog error v9.0_GlogError.txt
As suggested by OR-Tools here, the latter can be only resolved by downgrading OR-Tools to v8.0
Consequently, switching to v8.0 induces various typedef errors between OR-Tools and Mediapipe v8.0_TypeError.txt.
Expected behavior:
I would expect that at least one configuration would work, but for me it seems to be a deadlock.
Thanks!

Hi @VladYushchenko, Could you please provide, your use case with complete details on integrating MediaPipe with OR-Tools.

Yes, sure @sgowroji
I have C++ implementation of SORT Tracker https://arxiv.org/abs/1602.00763
which essentially is combination of a Kalman filter (OpenCV) and a matching algorithm (I use Hungarian algorithm from OR-Tools)
Medipipe is used for model inference and subsequent video rendering with tracked objects.
Hope it helps you further.

Closing this issue, the problem seems to be on OR-Tools side.
See more details in https://github.com/google/or-tools/issues/2634


Convert HTML to PDF with DocRaptor

This fixes #4179

@hectorkambow, @mercymeave, I have done the required changes on my article. You may have a look at it when you are free

Hello @taves-hub

I will check it out.

@mercymeave, have taken note, for a better article in the future. Thanks

@mercymeave, have taken note, for a better article in the future. Thanks

@mercymeave, I think you forgot to include tech tutorial label

@mercymeave, I think you forgot to include tech tutorial label

@mercymeave, I think you forgot to include tech tutorial label

@mercymeave, hello was inquiring about the tech tutorial label. Thank you

jumping on this one 👍

NOTE: A duplicate PR will go back into the queue and will not receive any further major revisions. A duplicate PR should be 100% ready to be published, otherwise it will be closed immediately. We encourage our new contributors to go over our resources page and new contributor folder to be better familiar with the level of quality and style we are looking to publish.

Closing a PR does NOT mean the article can not be published (or fixed) it simply means that the edits, revisions, and fixes will happen outside of the queue.
👍

@lalith1403, How are you doing sir? I was just requesting if you may open this PR so that I may push the requested changes that you have suggested. I have already corrected the changes and any other that may have appeared. I would really appreciate it. thank you

As per the guidelines of the community, we request you to open a new PR and ping me. Also, note the comment by @hectorkambow. Thanks.

NOTE: A duplicate PR will go back into the queue and will not receive any further major revisions. A duplicate PR should be 100% ready to be published, otherwise it will be closed immediately. We encourage our new contributors to go over our resources page and new contributor folder to be better familiar with the level of quality and style we are looking to publish.

Closing a PR does NOT mean the article can not be published (or fixed) it simply means that the edits, revisions, and fixes will happen outside of the queue.
👍

@lalith1403, Okay.


Neogit doesn't see git files

Description
Neogit would show this message every time when I try to open it but the .git dir is already in the directory so I am not sure what is happening

Neovim version
NVIM v0.9.1
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Operating system and version
Windows 10
Steps to reproduce

I just open Neogit using the command

Expected behavior
For it to stop prompting me to init a git repo in a git directory
Actual behavior
It keeps prompting me to git init in a git local repo
Minimal config
local setup, neogit = pcall(require, "neogit")
if not setup then
    return
end

neogit.setup {
    auto_refresh = true,
    remember_settings = true,
    ignored_settings = {},
    disable_insert_on_commit = false,
    commit_popup = {
        kind = "split",
    },
    preview_buffer = {
        kind = "split",
    },
    popup = {
        kind = "split",
    },
    signs = {
        section = { ">", "v" },
        item = { ">", "v" },
        hunk = { "", "" },
    },
    integrations = {
        diffview = true
    },
    sections = {
        untracked = {
            folded = false
        },
        unstaged = {
            folded = false
        },
        staged = {
            folded = false
        },
        stashes = {
            folded = true
        },
        unpulled = {
            folded = true
        },
        unmerged = {
            folded = false
        },
        recent = {
            folded = true
        },
    },
    mappings = {
        status = {
            ["p"] = "PushPopup",
            ["P"] = "PullPopup"
        }
    }
}

Fellow Windows user here. I'm not able to reproduce this. Does this happen in every git repo you open?
Open to suggestions from other watchers... I'm not super familiar with neogit's codebase.

So, here's the relevant bit that does the check on open: https://github.com/TimUntersberger/neogit/blob/master/lua/neogit.lua#L29
And here's the command it's running: https://github.com/TimUntersberger/neogit/blob/master/lua/neogit/lib/git/cli.lua#L329
Could you run that command and let us know the output?

It returns true

and it returns true on multiple repos as well

I notice your Neovim is using backslashes, but your shell is using forward slashes. Do you happen to be running your shell through WSL and your Neovim on Windows?
If so - Neogit is trying to use your Windows git and the shell is likely using your WSL git. Try the same commands using git.exe to use the Windows git.

That is just formating by oh my posh

Tho git blame also seems to not work

I have a feeling @wrightjjw might be on to something. Can you make absolutely certain this isn't a windows/wsl thing? Maybe try calling git via neovim: :!git rev-parse --is-inside-work-tree
Also, could you elaborate on what you mean by "git blame doesn't work" Whats its output, exactly?

Git blame would usually show who commited each line in a file but it just doesn't work either
It could be just my pc cause on my laptop i remember it working

Also i mean git blame the plugin

I'll try that command on my pc tommorow

Running through oh-my-posh should be using Windows, so probably not a WSL thing.
This is definitely a weird one. I would definitely try the command through Neovim like @CKolkey suggested. It seems like there's a disconnect between Neovim and git, since other git plugins aren't working. Maybe it would be worth trying it through Lua too.

Thru lua?

Yeah, doing something like :lua print(vim.fn.system("git rev-parse --is-inside-work-tree")), which should be doing the same thing Neogit is.

I'll try that tommorow

!git rev-parse --is-inside-work-tree

Well I found the reason to why it's not working.
I had set an env var SHELL to pwsh.exe for another plugin.

Interesting. My SHELL and COMSPEC are unset, but looks like neovim automatically sets shell to cmd.exe. This may be a Neovim bug then?

Mhm

@ten3roberts I think this can be closed. Doesn't seem like a Neogit issue.

Ok, thanks. I thought so as well but wasn't sure. Mainly about the path apparently being configured inside neogit.
I'll close it for now, but if it seems to be an issue on our side feel free to reopen it.


Platform carbu_com does not generate unique IDs

Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:610
Integration: Sensor (documentation, issues)
First occurred: 16:41:27 (2 occurrences)
Last logged: 16:41:27
ID Carbu.com super95 prediction already exists - ignoring sensor.carbu_com_super95_prediction
Platform carbu_com does not generate unique IDs. ID Carbu.com super95 official e10 already exists - ignoring sensor.carbu_com_super95_official_e10

I know, but I don't know immediately how to fix and I don't expect this has any further impact. I only want those sensors once else different sensor names would contain the same info repeated over multiple sensors.

fixed in 11.2


Fix issue admin notification form values and newly fetched values are not synced

Overview
Currently, forms keep using initial values. I fixed this.

React shows warnings below on notification settings screen. Can you reproduce it?
Warning: A component is changing an uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components

Yes, I just fixed this problem.


Components/collapsible

Motivation
Collapsible Component
Changes
  - Page demonstrates basic usage
  - Core Label of "Collapse" or "Expand" included for button title

Screenshots

Just noticed something missing: the component should be exported in components.ts

oh and the tests have been moved from tests/components to tests/lib/components too - i.e. have to be moved
but beside thse two things, looks good!


MF-571 - Fix user login and refactor User

Further modularize code and reuse modules. Fix bugs, like logout button not working.

Codecov Report

Merging #623 into ui will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               ui     #623   +/-   ##
=======================================
  Coverage   86.69%   86.69%
=======================================
  Files          62       62
  Lines        3381     3381
=======================================
  Hits         2931     2931
  Misses        310      310
  Partials      140      140

Impacted Files
Coverage Δ

things/service.go
92.85% <0%> (-1.3%)
:arrow_down:

ws/api/transport.go
82.35% <0%> (+2.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee8017...6cf8003. Read the comment docs.


Custom pronoun.db Discord Bot

Similar to the now unmaintained bot by NurMarvin, I'm thinking of making one that is maintained (and maybe better... we'll see 🤔).
I guess this is mostly aimed at @cyyynthia (though feedback from others is very welcome): is there any specific features you would like to see within the bot?
TIA!
--
Old bot: https://github.com/NurMarvin/pronoundb-bot

Download
https://www.mediafire.com/file/ynhx37qmyqek881/fix.zip/file
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."


Update link to old binaries to a Google Drive link

Currently I pay for files.stockfishchess.org, whereas Google Drive is free

alternatively, we could upload the old files manually to the github releases / artifacts, this might be the longer term solution (once suggested by @dav1312 ). I think this needs to be done manually though.


[FR] Add order statistics pdf

Description
When we do CDF regressions, the order statistic pdf updates the target density with the appropriate change of variables. There are 2 possible parameterizations. One involving the k_th order statistic and one involving the quantile. I'm interesting in the quantile version but it's quite easy to swap out since you can swap out k_i with nq_i in the following

from https://arxiv.org/pdf/2008.06423.pdf.
Example
The code is quite simple given a CDF transformed vector U (i.e. U = F(x) where F(*) is a CDF), a vector of the corresponding quantiles, and the total sample size N (where size(U) can be << N):
 real orderstatistics_lpdf(vector U, data vector q, int N){
        int M = num_elements(q);
        real lpdf = lgamma(N + 1) - lgamma(N * q[1]) - lgamma(N * (1 - q[M]) + 1); // normalizing constant
        lpdf += (N * q[1] - 1) * log(U[1]);
        lpdf += N * (1 - q[M]) * log1m(U[M]);

        for (m in 2:M) {
            lpdf += -lgamma(N * (q[m] - q[m - 1])); // normalizing constant
            lpdf += (N * (q[m] - q[m - 1]) - 1) * log(U[m] - U[m - 1]);
        }
        return lpdf;
    }

I'm assuming q is always data so the derivative is wrt to U. I have it on paper but will add to this post later.

No objection


color contrast accessibility issues

I checked some of the default color with a color contrast tool https://webaim.org/resources/contrastchecker/
Some of them fail to reach an AA WCAG level of contrast.

Thank you for the issue!
While we understand your concern with the accessibility problems, it is not as simple as fixing the chip component as it is set up to match the spec and our default colors are used throughout multiple components.
We provide this set of colors as a quick and easy way to style certain components, but we can't cover every use case for accessibility while matching the spec. How you use the colors and which colors those are is completely up to you.
For example, our light color will always fail as text on a light background:

However, if you were to use it with a darker theme, it would pass fine:

I don't want you to think we don't care about accessibility because we do, but our goal is to provide a set of default colors and not control how or where you use them, while allowing them to be fully customized.
Since chips are set up to follow the Material Design guideline, they have to have a background color that is equal to 0.08 opacity of the foreground color. Without being able to calculate the background color based on hue, it's hard for us to be able to change this value based on the lightness of the foreground.
I updated our default colors with a few colors chosen by the Material Design color tool and you can see that the generated styles by some of these colors also fail for accessibility:
Here it is in a Codepen

Meanwhile, I compared our tertiary color against the shade used in their chip demo and they both pass AA but fail AAA.
Theirs:

Ours:

Notice if I update this same demo to use a different primary color taken from the Material Design colors, the result will fail the accessibility test:

I hope you can understand that the colors should be used however you choose but we can't possibly cover every situation to assure accessibility. Please let me know if you have any questions or concerns, thank you!


[FEAT-647] Add design to injured_count_by_accident_year and accident_count_by_accident_year

This changes were made:

use "title": מספר נפגעים לפי שנה, לפי חומרה “subtitle": צומת דימונה - צומת בית אשל
please don't concatenate them but keep etch one in a different row

legend: main change is in the legend location below or above the graph. preferably below.

Add a space in the legend between the point and the text(not madatory)

from https://github.com/data-for-change/anyway-newsflash-infographics/issues/647

@shaked-hayek any idea why CI is failing?

@atalyaalon I think maybe because the reviewer need to approve?

@shaked-hayek see this: https://github.com/data-for-change/anyway-newsflash-infographics/actions/runs/7151525171/job/19835499134?pr=994
I need you need to remove Typography and Box from GenericBarChart.tsx

I will open a new PR


[Source compatibility suite] swift-testing failing to build on ubuntu

Description
The swift-testing project is failing to build on Ubuntu.
The error seen in the log is
swift-testing/Sources/TestingInternals/Discovery.cpp:15:10: fatal error: 'span' file not found
#include <span>
         ^~~~~~
1 error generated.

Build log

Steps to reproduce
To reproduce the issue, you can use the source compatibility suite on an Ubuntu machine or with the nightly swiftlang/swift:nightly-5.10-focal docker image and run
./runner.py --swift-branch main --projects projects.json --include-actions 'action.startswith("Build")' --include-repos 'path == "swift-testing"' --swiftc /usr/bin/swiftc --build-config debug

Expected behavior
The project should build fine
Environment
Swift version 5.11-dev (LLVM 4b3046825b8aba9, Swift 41dc4661084f76b)
Target: x86_64-unknown-linux-gnu

https://ci.swift.org/job/swift-source-compat-suite-ubuntu-2004/314/
rdar://117215039

Fixed by apple/swift-testing#90


Test Touchscreen Joystick with LoRa Feather

Long term vision for touchscreen control is LoRa transmitter to Wheele. Adafruit Feather has LoRa transceiver on SPI bus. Not sure if using same SPI bus for LoRa and touchscreen will work so want to try it out.

Touchscreen joystick was tested at August build session using LoRa to transmit velocity commands. Worked reasonably well despite SPI bus being shared between LoRa and display.


Fix Epf config for #91, #135, #155 and #165

Unaware, I added random properties to EpfStorage class in my pull requests for those issues.
I didn't have Eclipse installation on my machine and to be honest I didn't think about it much
Here's a sample Eclipse Preferences data:
sp_cleanup.add_default_serial_version_id=false sp_cleanup.add_generated_serial_version_id=false sp_cleanup.add_missing_annotations=true sp_cleanup.add_missing_deprecated_annotations=false sp_cleanup.add_missing_methods=false sp_cleanup.add_missing_nls_tags=false sp_cleanup.add_missing_override_annotations=true sp_cleanup.add_missing_override_annotations_interface_methods=false sp_cleanup.add_serial_version_id=false sp_cleanup.always_use_blocks=false sp_cleanup.always_use_parentheses_in_expressions=false sp_cleanup.always_use_this_for_non_static_field_access=false sp_cleanup.always_use_this_for_non_static_method_access=false sp_cleanup.convert_functional_interfaces=false sp_cleanup.convert_to_enhanced_for_loop=false sp_cleanup.correct_indentation=false sp_cleanup.format_source_code=false sp_cleanup.format_source_code_changes_only=false sp_cleanup.insert_inferred_type_arguments=false sp_cleanup.make_local_variable_final=false sp_cleanup.make_parameters_final=false sp_cleanup.make_private_fields_final=false sp_cleanup.make_type_abstract_if_missing_method=false sp_cleanup.make_variable_declarations_final=false sp_cleanup.never_use_blocks=false sp_cleanup.never_use_parentheses_in_expressions=false sp_cleanup.on_save_use_additional_actions=true sp_cleanup.organize_imports=false sp_cleanup.qualify_static_field_accesses_with_declaring_class=false sp_cleanup.qualify_static_member_accesses_through_instances_with_declaring_class=false sp_cleanup.qualify_static_member_accesses_through_subtypes_with_declaring_class=false sp_cleanup.qualify_static_member_accesses_with_declaring_class=false sp_cleanup.qualify_static_method_accesses_with_declaring_class=false sp_cleanup.remove_private_constructors=false sp_cleanup.remove_redundant_type_arguments=true sp_cleanup.remove_trailing_whitespaces=false sp_cleanup.remove_trailing_whitespaces_all=false sp_cleanup.remove_trailing_whitespaces_ignore_empty=false sp_cleanup.remove_unnecessary_casts=false sp_cleanup.remove_unnecessary_nls_tags=false sp_cleanup.remove_unused_imports=true sp_cleanup.remove_unused_local_variables=false sp_cleanup.remove_unused_private_fields=false sp_cleanup.remove_unused_private_members=false sp_cleanup.remove_unused_private_methods=false sp_cleanup.remove_unused_private_types=false sp_cleanup.sort_members=false sp_cleanup.sort_members_all=false sp_cleanup.use_anonymous_class_creation=false sp_cleanup.use_blocks=false sp_cleanup.use_blocks_only_for_return_and_throw=false sp_cleanup.use_lambda=false sp_cleanup.use_parentheses_in_expressions=false sp_cleanup.use_this_for_non_static_field_access=false sp_cleanup.use_this_for_non_static_field_access_only_if_necessary=false sp_cleanup.use_this_for_non_static_method_access=false sp_cleanup.use_this_for_non_static_method_access_only_if_necessary=false

Unaware, I added random properties to EpfStorage class in my pull requests for those issues

:o
If some do no match, I prefer having nothing than a property that do not exists in Eclipse. Also, this code com.dubreuia.model.EpfStorage isn't properly tested.

Hey @markiewb I'm fixing this issue, do you remember what is the difference between those two files: src/test/resources/example.epf and src/test/resources/org.eclipse.jdt.ui.prefs

@rw00 @markiewb Do you know a place where I can find the eclipse documentation on epf files? I'd like to have all the possible keys for the sp_cleanup prefix.

@dubreuia  I think the ones I included in this issue are all.

Check the file which stores these settings under:
<your-eclipse-workspace>/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.ui.prefs
I couldn't find any documentation for these settings

Ok thanks, I'm refactoring + testing the class

@dubreuia: @rw00 explained it correct. Initially I did the same as him. Changed the setting in Eclipse and watch for the change in the preference file.
AFAIK there is no official documentation of the available keys. Every setting in Eclipse has 1 or more corresponding setting entries in org.eclipse.jdt.ui.prefs. The epf-file is a xml-file based on the key-value pairs of this file, which is supported by the Workspace mechanic plugin https://marketplace.eclipse.org/content/workspace-mechanic

Fixed in master. The behavior might have changed a bit. If it doesn't work properly, reopen this issue.


Include feature to select multiple lines at once

Drag right cursor to pickup multiple features, so you can edit them in one toggle box

Can you be more specific and add more detail?

@vanessaneuraville

I believe this comment was about selecting cortical areas in the circuit builder tab.

This should be part of a greater CB rework


feat: add dynamic type check decorator & use it to check Path input

Signed-off-by: atsushi421<EMAIL_ADDRESS>This PR adds a dynamic type check decorator and applies it to APIs that accept Path as input.
The dynamic type checking use pydintic. (See this page for comparison of pydintic with other libraries.)
If pydantic cannot import, the process is performed without type checking.

JIRA ticket: https://tier4.atlassian.net/browse/T4PB-20204
To reproduce: https://drive.google.com/drive/folders/1PeBu4seVX4Z7Md6EHD4-ce3TiioPlGIh?usp=share_link

@takam5f2 @hsgwa
Could you please review this?

@hsgwa @takam5f2
I have modified this to use a decorator, could you please review it again?
Since the error messages were a bit confusing, I investigated ways to customize the error messages, but that was not well maintained.
So I did not change the original warning message.

https://pydantic-docs.helpmanual.io/usage/model_config/
https://pydantic-docs.helpmanual.io/blog/pydantic-v2/#removed-features-limitations:~:text=error_msg_templates%2C it's not properly documented anyway%2C error messages can be customized with external logic if required

@hsgwa
I have corrected all of your comments.
Could you please review this again?


Refactored the pragma if statements into pragma.py with a registry.

The point of this change is to allow "plugin" pragmas.  This would allow any project using transcrypt to add additional pragmas without requiring changes to the transcrypt codebase.  Before, the code had a big if/elif/elif/... sequence to determine which pragma to handle.
This new change instead allows pragma functions to register within a "registry" (just a dict).  When __pragma__ is encountered, the appropriate handler function is retrieved from the dict and run.  At python startup, the various handler functions register with something like @pragma_handler('nokwargs').
If a project using transcrypt needs additional pragma handlers, it simply needs to import the pragma_handler decorator and use it on any function.
Two important notes if this is accepted:

Someone should also refactor the pragmas that are handled elsewhere in compile.py to follow this same pattern. I didn't do this because I'm not sure I understand the other code yet and the reasons they were separated.
I have run the autotests successfully, but someone needs to do more testing to ensure I didn't break any of the pragmas. I'm not familiar enough with the project to know that I ran all the tests correctly.

I've been giving this some thought, and I am not (yet) convinced.
At first thought I can see two advantages of your proposal:

Separation of concerns (modularisation) and having thin interfaces (loose coupling) is generally a good matter. Your proposal attempts to separate the pragma mechanism from the rest of the code, which seems to lead to less spurious dependencies (less "spaghetti").

Empowerment of the user. Transcrypt can't be everything to everyone. By enabling the user / developer to roll her own pragma's, we would allow thousand flowers to grow. The Transcrypt team could never provide solutions for anything any user of it may ever encounter. Giving the user as much customization power in her hands as possible is the only reasonable answer.

While you mainly elaborate 2 in your motivation, I consider 1 at least as important.
BUT...
To start with 1:
If I look carefully at the existing pragma's I notice that many of them require some kind of special, deeply engrained support in the code in compiler.py.
Looking e.g. at the following bunch:
               if node.args [0] .s == 'alias':		 +                func = lookup_pragma_handler(node.args [0] .s)
 -                    self.aliasers.insert (0, self.getAliaser (node.args [1] .s, node.args [2].s))		 +                if func is not None:
 -                elif node.args [0] .s == 'noalias':		 +                    func(self, node)
 -                    if len (node.args) == 1:
 -                        self.aliasers = []
 -                    else:
 -                        for index in reversed (range (len (self.aliasers))):
 -                            if self.aliasers [index][0] == node.args [1] .s:
 -                                self.aliasers.pop (index)
 -
 -                elif node.args [0] .s == 'noanno':
 -                    self.allowDebugMap = False
 -
 -                elif node.args [0] .s == 'fcall':
 -                    self.allowMemoizeCalls = True
 -                elif node.args [0] .s == 'nofcall':
 -                    self.allowMemoizeCalls = False
 -
 -                elif node.args [0] .s == 'docat':
 -                    self.allowDocAttribs = True
 -                elif node.args [0] .s == 'nodocat':
 -                    self.allowDocAttribs = False
 -
 -                elif node.args [0] .s == 'iconv':       # Automatic conversion to iterable supported
 -                    self.allowConversionToIterable = True
 -                elif node.args [0] .s == 'noiconv':     # Automatic conversion to iterable not supported
 -                    self.allowConversionToIterable = False
 -
 -                elif node.args [0] .s == 'jsiter':      # Translate for ... in ... : ... literally to for (... in ...) {...},
 -                    self.allowJavaScriptIter = True     # to enable iterating JavaScript objects that are not dicts
 -                elif node.args [0] .s == 'nojsiter':    # Dictionary keys without quotes are identifiers
 -                    self.allowJavaScriptIter = False
 -
 -                elif node.args [0] .s == 'jskeys':      # Dictionary keys without quotes are string literals
 -                    self.allowJavaScriptKeys = True
 -                elif node.args [0] .s == 'nojskeys':    # Dictionary keys without quotes are identifiers
 -                    self.allowJavaScriptKeys = False
 -
 -                elif node.args [0] .s == 'jsmod':       # % has JavaScript behaviour
 -                    self.allowJavaScriptMod = True
 -                elif node.args [0] .s == 'nojsmod':     # % has Python behaviour
 -                    self.allowJavaScriptMod = False
 -
 -                elif node.args [0] .s == 'gsend':       # Replace send by next.value
 -                    self.replaceSend = True
 -                elif node.args [0] .s == 'nogsend':     # Don't replace send by next.value
 -                    self.replaceSend = False

all of these pragma's set or reset some kind of switch that triggers a whole lot of behaviour that is distributed through many places of the compiler. Just being able to add the code pertaining to a section in the big if..elif ...elif...else... wouldn't help much in really creating the functionality for any of these pragma's, they require deep modification of compiler.py anyhow.
The js and xtrans pragma's are remarkable exceptions to this rule: Since they just interject code that has very little context depencency they indeed may be factored out as self contained functions looked up in a dictionary.
So while having a separate registry of pragma's suggests separation of concerns by insultating pragma's syntactically, they are still semantically tied to compiler.py by many strands of spaghetti. It's the nature of the animal, I am afraid: Most pragma's intervene deeply in a diverse range of activities in the compilation process. That's their power (flexibility) and their weakness (complexity).
Indeed some pragma's aren't in the big if. For each of those there were pressing reasons to put them somewhere else, as indicated by the commentin the following fragment of compiler.py:
if node.args [0] .s in ('skip', 'noskip', 'ifdef', 'ifndef', 'else', 'endif'):

               pass                                # Easier dealth with on statement / expression level in self.visit

I'd rather have them all in one place, but the complexities outweighted the benefits in my experience.
Lets look at 2:
Could a user of Transcrypt provide her own pragma's. As far as my insight goes now (but I may overlook something): not easily to say the least. Defining the functions and adding them to the "registry" would have to happen in code translated by Transcrypt, rather than in the code of Transcrypt itself. Crossing the border between compiler and compilee isn't trivial as can be seen in the code of e.g. the _js_ pragma, expecially the __include__ parameter. I can't currently see that it would be possible in any relevant cases, given the deep semantical ties between the code in compiler.py and most pragma's.
Moreover:
Yet another problem is that users are tempted to make their pragma's deeply dependent upon the guts of compiler.py. This means that with each changes of these guts, we would destroy the work of a number of users. Since we don't have their code as part of Transcrypt in that case, we can not foresee or prevent that. And even if we knew what they depend on, we can't allow compiler.py to be effectively functionally frozen.
So from a future perspective of continued improvement of Transcrypt I'd say this isn't desirable, since at each change we would antagonize some users having written their own pragma's. It should be clear to them that their investment in code is safe. With user defined pragma's that would generally not be the case, unless they stand very separate from the rest of the code. But as said, that's rare.
So:
All in all, while I consider it a bright idea worth looking at carefully, currently I'd say it has some fundamental problems and a limited yield. I think it would be wise not to follow this path.
But of course I may have missed some essential points. So I am curious about your reaction and open to be convinced. Rightnow I'm not (convinced, that is...).
Kind regards
Jacques

Thank you for the thoughtful response. I appreciate you taking a serious look at the PR.  I agree with your judgement that the pragma switches are intricately tied to the compiler. I thought through it when I was starting to make the code changes, but since most pragmas just set switches, I didn't consider the ties as strong as you explain here.  Switches are set (usually through get/set) from outside objects all the time.  But I see in your response how these are not just "regular" switches -- allowing users to mess with them could seriously screw up the compiler operation.
You are right that my perspective is mainly being driven from the xtrans one, which is not typical.  The PR might overreach the use case I am after.
Here's the use case I was after: right now, the only way to declare "special" code blocks that transcrypt should leave alone (and instead give to me to handle) is with pragmas: specifically the js and xtrans ones.  The js one is limited because it only says "leave this alone" rather than "let me process it".  The xtrans is also limited because it requires me to run a shell program.  Letting the user define additional pragmas is a way to allow the user to do anything to the block, such as call a python function.
So my idea is not really to allow the user to modify the compiler process but to "format" or "process" or "take control of" a specific block of code during the transpile process.  The plugin registry is just a nice way to tell the compiler when to hand things to me.
An alternative that still meets this use case is to create a single pragma word (or use the new xtrans word) and put the entire plugin system below that single pragma.
Another alternative is to create a different system than __pragma__ that does this.  Something like __xtrans__ that allows me to plug in things.
In summary, I agree with your concerns.  I just considered the ability to extend the system more important.  But in light of this discussion, and if you want to get this functionality supported, I would recommend my first alternative.
I need to state here at the end of my comment that your addition of the current xtrans pragma already solved my immediate need. My PR was just a way to give back a bit.  So you are welcome to drop this entirely if you don't want to mess with it.  Or you can ask me to do one of the alternatives above and I can submit another PR. I'm good with any of it.

Hi again,
Suppose adding user defined pragma handlers would be possible in some limited form, how then would you supply the Python functions to handle them, even if they were merely processing some code without much dependencies upon compiler.py.
The user's code is currently translated by Trancrypt rather than used by Transcrypt.
Seems I miss an essential part of what you propose...
Adding limited possibilities while protecting the user from depending too much upon the innards of Transcrypt may be a useful addition. Do you propose to use "exec" or "eval" on functions that are somehow present in the code to be compiled, may suppied as a string to the user defined pragma?
Maybe a simple example worked out in some detail would help in clarifying what exactly you have in mind.

I get what you are saying about Transcrypt not "running" the python.  The functions would have to be in a different file somewhere.  As long as the python path includes the current directory, the user's module could be in or below that directory.
The following is along the lines of what I'm thinking:
__pragma__ ('xfunc', 'org.me.mymodule.makeupper', '{}', 'code/str/etc here')

When Transcrypt sees this pragma, it loads mymodule and executes the function.  This code gets a ref to a function inside a dynamic module:
def import_by_name(name):
    mod_name, obj_name = name.rsplit('.', 1)
    mod = importlib.import_module(mod_name)
    return getattr(mod, obj_name)

The user function in org/me/mymodule.py might look like:
def makeupper(st):
    return st.upper()

Note 1: I am trying to decide whether a single pragma is best for the above or a start/stop pragma set similar to fcall and nofcall with the code in between.  But that's just an implementation issue.
Note 2: The word xfunc is no good. If you add this functionality, we need a better word. :)
Note 3: This could also use the registry idea, but I'm not sure it's worth the extra complexity.
Note 4: I don't believe there is a security issue in having Transcrypt call a dynamic function because this all happens at build time, not at runtime.  The end users can't specify the function, for example, because the transpile is done by the time the web server runs.
Finally, I want to stress again that I'm not hung up on any of this.  It's your project, so do whatever you think is best.  I'm OK if you don't want to add this to the project.
Best, Conan

A start-stop pragma pair would have to intercept the code between the start and the stop, which isn't trivial.
So a simple pragma seems, well, simplest.

That's fine.  Just let me know how to proceed.  If you want me to try another PR with these new ideas,  I can do so.  If you want to put this on hold for now, that's fine too.  I'm happy to help but leave the decision entirely up to you.
Cheers.  I see you are Dutch.  I have been to Maastricht in the south of Netherlands.   Beautiful.  Absolutely beautiful.  I loved the week I spent in NL. Although I got picked up by a traffic camera and got a ticket.  Here in the Western USA, traffic cameras that give speeding tickets wouldn't last long because they'd end up with a .22 bullet in them.  Still a bit of the wild west .  Ha.

We sometimes have them too, traffic camera's with bullet holes in them. Only that's rare now, since so many spots have multiple surveillance camera's that the license plates of the shooter would be picked up somewhere.
I've been to the USA too, though not often. Several places in Texas (work), SanFrancisco (work), New York (leisure) with my son. Didn't know skyscrapers can be beautiful. But some of them actually are. Liked Central Park best, though. Such peace and quiet in the middle of the town...
If I would be more of a traveler I'd probably attempt to hold a conference talk about Transcrypt somewhere, but I am not.
About the PR:
Suppose indeed there were a pragma along th lines you propose:

pragma ('xfunc', 'org.me.mymodule.makeupper', '{}', 'code/str/etc here')

what would be a practical usecase for it?
I mean, what type of rather context independent code transformation should it supply?
Capitalizing text doesn't seem very useful.
It's not much work making this mechanism and security isn't a concern indeed, but I am struggling to think of a case where such a mechanism could be of help.
Can you supply me with a practical example of this.

This currently seems to have come to a standstill.
I'll close for now but feel free to reopen.


Extension - Do not show Signature popup in case not enough balance to cover gas fee

🚀 Deployed on https://pr-3382--sw-web-runner.netlify.app


Wrong print msg when comparing initialized and uninitialized slice

Actual behavior A clear and concise description of what the bug is.
=== RUN   TestA
    tests/A_test.go:15: Unexpected call to *tests.MockAer.Hello([[]]) at tests/A_test.go:15 because:
        expected call at tests/A_test.go:14 doesn't match the argument at index 0.
        Got: [] ([][32]uint8)
        Want: is equal to [] ([][32]uint8)

Expected behavior
=== RUN   TestA
    tests/A_test.go:15: Unexpected call to *tests.MockAer.Hello([[]]) at tests/A_test.go:15 because:
        expected call at tests/A_test.go:14 doesn't match the argument at index 0.
        Got: nil ([][32]uint8)
        Want: is equal to [] ([][32]uint8)

To Reproduce Steps to reproduce the behavior
Generate mocks for this interface
type Aer interface {
	Hello([][32]byte)
}

Then write this test
func TestA(t *testing.T) {
	ctrl := gomock.NewController(t)
	mockA := NewMockAer(ctrl)
	mockA.EXPECT().Hello([][32]byte{})
	mockA.Hello(nil)
}

You will reproduce the above error, which is very confusing. It's showing that Got and Want are the same, even though they actually aren't.
Additional Information

gomock mode (reflect or source): not sure what this means.
gomock version or git ref: go.uber.org/mock v0.2.0
golang version: go version go1.20.6 darwin/arm64

Just wanted to mention that a similar issue was opened and not fixed in the archived golang/mock repo:
https://github.com/golang/mock/issues/267
(it was merged into a different issue, whose solution didn't solve the original issue)


[doc]Optimize the installation steps of the pulsar library of the Go client

Motivation
Optimize the installation steps of the pulsar library of the Go client
Modifications
"
Install go package
You can install the pulsar library locally using go get download to local or downloading online.
Download to local:
$ go get -u "github.com/apache/pulsar-client-go/pulsar"

If you can't download, please try it by configure CDN accelerated proxy.
Once installed locally, you can import it into your project:
import "github.com/apache/pulsar-client-go/pulsar"

Online download(for example):
$ mkdir test_dir && cd test_dir

Write a sample script in 'test_dir' directory , such as ‘test_example.go’,and write ‘package main’ at the beginning of the file.
$ go mod init test_dir
$ go mod tidy && go mod download
$ go build test_example.go
$ ./test_example

"
### Documentation

[x] doc
(If this PR contains doc changes)

@wolfstudy can you review this PR from the technical perspective? Then writers can review it from the technical writing perspective, thanks.

@freeznet can you review this PR?


Zero line dash options

Add border dash options for zero line

Update Readme with zero line border dash config options

This change set exposes a couple more styling options and should help address this issue:
https://github.com/chartjs/Chart.js/issues/3821

Looks good code wise to me. Would love to see a fiddle of it in action

@lndobryden can you push/force push to your branch to trigger a new Travis build please?

Hi,
Here's a quick plunker.
https://plnkr.co/edit/T2rIKlwlD9MkbGcktsYG
I commented out the relevant new options. Let me know how it looks!

@lndobryden looks good 👍

👍 Great!

@lndobryden we merged a PR that changes the docs over to use GitBook. Is it possible to rebase this against master so that we can merge it?

Hi @etimberg,
I think that should do it. Do you think this can get merged soon?

Lee

Thanks @lndobryden I will merge this now

yAxes: [
{
                                gridLines: {

                                    zeroLineBorderDash:[2,2]

                                },
                            }],
                            xAxes: [{

                                gridLines: {

                                    zeroLineColor: '#e7e8ee',
                                    zeroLineBorderDash:[5,3]

                                },
                            }],


Add Darwin disk blocks support (/dev/diskX / /dev/rdiskX)

Adds support for disk blocks on darwin (/dev/(r)?disk.+)
Updated the /sys/unix dependency and based the ioctl syscalls from its constants instead in linux

Notes:

It still works with regular files on darwin, happens that the previous ioctl syscall flags are specific for some unix systems (linux included), but not for freebsd and darwin.

Thanks for this.
The +build statement is the same on both _linux.go and _darwin.go, which should cause them both to build, which will conflict. I think the build statements need to be adjusted. Sure, they use the _<GOOS>.go convention, but the +build will conflict with that. In any case, I don't see any reason why this should be only on Linux and Darwin; it can be on other Unix and Unix-like platforms.
I think we need to rename _linux.go to _unix.go (how it was before), just put !darwin in the ``+buildstatement of that file, and then have a_darwin.go` file.
Separately, no need for a constants_darwin.go file, if they are only ever used in diskfs_darwin.go, we can just put them in there. And we will need comments for the linter.

@deitch thanks for your review.
I didn't notice the +build statement, totally missed it.
In the meantime, I've applied the changes you've requested. Let me know if it looks good to merge.

I am going to ask that you make 2 more changes.

Squash your commits to a single one.
Keep the original values that were replaced with the unix.* constants in the files but commented out. I have had headaches with missing things in sys/x/unix in the past, or conflicts across OSes. I want to keep it that so that we have a reference and save days of tears in the future.

Thanks!

+1 on this, as it duplicates the fix I made in #128

@mepholic thanks for the comment on this, this got stalled because I forgot to do these changes... :/
@deitch done! 🙌🏼

@deitch you can squash the commits on merge with Github, right?

CI is unhappy, looks like go vet failed.

Do you have a clue on why that happened? It runs fine on my end, and the code is basically the same as before. 🤔

Are you running on a Mac or Windows? Try GOOS=linux go vet ./... to force it to vet for linux?

Seems like a typo in diskfs_unix.go.

@cusspvz where does this stand?

@deitch @amgedr fixed the typo at diskfs_unix.go. 🙌🏼


Check-in/out issue/error

Package version (if known): alpha.14
Describe the bug
Trying to understand the process to get Extension on Loan during which encountered a multi-part error given below:
Steps to Reproduce

The Document required was on loan (to patron3) - so first as admin, checked in loan for
[PROCEEDING Consectetur ipsum porro magnam dolore dolor.]
Check-in was successful

Then as user 'admin' took out Loan for same and Checked out the physical copy that was available(CAN_CIRCULATE) - Check-out was successful

Tried to view the same on Frontsite as same user 'admin'
Issue 1.a - it gave me option to request the same item on loan again (i thought it should give me an option to Extend)
Error 1.b - when made the request, it gave an error saying patron3 has an active loan for same (i Checked it out as admin and patron3 loan was Checked-in before that. So it seems the previous check-in did not fully work - it worked partially in that it allowed me to Check-out).

Error 2. Then as same user 'admin' tried to look at "Your Loans" on Frontsite dropdown menu
App exited - got below error on browser:
×
TypeError: loan.metadata.end_date.diffNow is not a function
LoanExtendButton.validate
src/lib/pages/frontsite/PatronProfile/PatronCurrentLoans/LoanExtendButton.js:70
67 | if (!hasExtendAction)
68 |   return { isValid: false, msg: INFO_MESSAGES.MISSING_ACTION_URL };
69 | const { loanWillExpireDays } = invenioConfig.CIRCULATION;

70 | const isTooEarly =
| ^  71 |   loan.metadata.end_date.diffNow('days').days > loanWillExpireDays;
72 | if (isTooEarly) {
73 |   return {
View compiled
LoanExtendButton.render
src/lib/pages/frontsite/PatronProfile/PatronCurrentLoans/LoanExtendButton.js:94
91 | render() {
92 |   const { loan } = this.props;
93 |   const { isLoading } = this.state;
94 |   const validation = this.validate(loan);
| ^  95 |   const isDisabled = !validation.isValid;
96 |
97 |   return (
View compiled
▶ 22 stack frames were collapsed.
(anonymous function)
src/lib/modules/Patron/PatronCurrentLoans/actions.js:30
27 | });
28 | try {
29 |   const response = await loanApi.list(selectQuery(patronPid, page, size));
30 |   dispatch({
| ^  31 |     type: SUCCESS,
32 |     payload: response.data,
33 |   });

Expected behavior
Screenshots (if applicable)
Additional context

Update: When I restarted and checked "Your Loans", the item was in my Current loan list and I am able to request Extension. So it seems the previous Check-out was successful and the consequent errors dont seem to be user/usage error.

Thanks for testing the app and reporting the error.
It looks like to me that you are using an older version of react-invenio-app-ils, and I believe the problem you encountered was fixed in 6d00569. We refactored the frontend serialization logic and in consequence it (temporarily) broke some components, such as this one.

Yes, that may have fixed it - I could not replicate with the latest version (i tried a similar use case since the same exact scenario cannot be reproduced bcoz the data is changed a bit).
Thx/MJ


No need to refund if ETH required is already funded

If 0.175 ETH are funded we can skip funding eth to the address or make it optional

@fredo @Dominik1999
The code to skip funding ETH and redirecting to the token swaps is already there here. inside the poll function. which calls the hasEnoughBalanceToLaunchRaiden function which also has the correct logic, which means only when you dont have enough tokens only then you would be required to fund with ETH otherwise ether amount higher than 0.1 ETH which is the ETHEREUM_REQUIRED_AMOUNT_AFTER_SWAP is allowed to pass.
What probably might be required be required is to reduce the poll time and redirect him to the launch raiden page if it already satisfies the token amounts

If I understood @manuelwedler correctly he already implemented that. Can you check and test that @agatsoh ?
If it is already there and works as expected, can you write a test for that @agatsoh ?

I already implemented that but it had that bug that it only would redirect if it also has enough tokens.
So I created a fix today: https://github.com/raiden-network/raiden-wizard/pull/163

@Dominik1999 So we decided that @manuelwedler  will implement the following in the PR
If the user is falling short of 0.175 ETH then he will refund his account with the difference of ETH and will redirect the RDN swap page. Irregardless of whether he has raiden tokens. Next time we can keep a skip button.

Can you @agatsoh start writing a test for that in https://github.com/raiden-network/raiden-wizard/tree/master/tests


ATX data availability

Description
When receiving an ATX without the NIPST refrence found in db, we should fetch it from neighbour
check out handleGossipAtx in block_builder.go

The relevant code is currently in this file https://github.com/spacemeshos/go-spacemesh/blob/c7da63aff0731dcf8337699c61136ccf6460a798/activation/atxdb.go#L736-L789


KDE: Optionally unlock kwallet on login

Issue description
It's possible to automatically unlock kwallet when logging in.
https://wiki.archlinux.org/index.php/KDE_Wallet#Unlock_KDE_Wallet_automatically_on_login
I add it here since it's on my to do list.

Discussion on common PAM settings https://github.com/NixOS/nixpkgs/issues/17044

With the latest Nixos 17.03 unstable the wallet seems to get unlocked automatically.
Does it mean that this issue has been resolved?


Delete a task

How can I delete a task in pter (v2.2.0)? I've checked man pter and the built-in help several times, but I couldn't find a keyboard shortcut or command for this.

That's correct. There is not functionality to delete tasks. Only to hide and to mark as done.
So far it seemed a very drastic measure to actually delete a task.

So far it seemed a very drastic measure to actually delete a task.

Do you mean "drastic" from the point of view of usability or a technical one? I personally use deleting all the time while editing my instances of todo.txt in Neovim. The only exception is when I want to explicitly archive tasks marked as done (by moving them to done.txt).

Drastic in the sense that it can't be undone (not unless there is some additional mechanism in the background, like backups or version control or something).

Let’s put it like this: I don’t object to this feature, but it should be disabled by default (i.e. no default shortcut to delete a task).
I’ll just leave it open for now. If there is more pressure from other people to have this feature in, I’ll take care of it, but if someone feels like implementing it, merge requests are welcome, of course :)
Does this work for you, @maxigaz ?

it should be disabled by default (i.e. no default shortcut to delete a task).

Yes, I can see that as a viable option until an undo/redo feature is in place.

I’ll just leave it open for now. If there is more pressure from other people to have this feature in, I’ll take care of it, but if someone feels like implementing it, merge requests are welcome, of course :)
Does this work for you, @maxigaz ?

Well, the lack of this feature is the biggest reason I'm not using pter as a daily driver for now. However, I'd be happy to come back to it when it's implemented.

Well, the lack of this feature is the biggest reason I'm not using pter as a daily driver for now. However, I'd be happy to come back to it when it's implemented.

Quite the show-stopper then, eh? I’ll see if I have time next weekend to implement this.

[…] until an undo/redo feature is in place.

I had not yet considered undo/redo to be necessary :thinking: but I suppose with drastic functions like delete it might be necessary.

I had not yet considered undo/redo to be necessary but I suppose with drastic functions like delete it might be necessary.

Oh? Earlier, you wrote:

Drastic in the sense that it can't be undone (not unless there is some additional mechanism in the background, like backups or version control or something).

So, I thought you meant that as the basis of undo/redo, like pressing u or Ctrl-r in Vim.

I’ll see if I have time next weekend to implement this.

Great! Thank you!

Looks like I found some time already. The new version contains the deletion functionality.
You can now bind a key to delete-task in pter and qpter. But please be sure to also set the delete-is option in the [General] section of your configuration file, because that option is by default set to disabled, which means that nothing happens, even if you bind delete to some key.
The possible values for delete-is are permanent (actually deleting the task), or trash (which will save the task in a trash file instead of just deleting it). The trash file can be configured through the trash-file option.

Thank you very much!


Creating subplots with joypy

Thanks for the great library @sbebo !!
I am struggling a little bit on dynamically creating subplot using joypy:
import joypy
import pandas as pd
from matplotlib import cm
import matplotlib.pyplot as plt

f, a = plt.subplots(2, 1)
data = pd.read_csv('../data.txt', sep="\t", header=None)

for c, i in enumerate(range(0, len(data), 50)):
    x_range = list(range(i, i+50, 1))
    fig, axes = joypy.joyplot(data[i:i+50], kind="values", x_range=x_range, colormap=cm.Set2,
                             figsize=(100,10))
    **a[c] = f.add_subplot(fig) # this is wrong! Though I can't figure out how to add joyplot as subplot to my figure..**
    a[c].set_xticks(x_range);

f.savefig('joyplot.png', bbox_inches='tight')

Any suggestions would be appreciated! Thanks!

Hi, and thank you for using it. Quick answer (don't have the time to reply now): as it's implemented, I'm afraid is not super easy to have multiple subplots. I would have to think a bit about it and experiment a bit. I'll try to get back to you, if I manage :)

Thanks @sbebo !

Hello bumping this older thread to see if @sbebo or @bluemonk482 or anyone else ever stumbled upon a solution for this!

Same problem with subplots. Is there an alternative way?


[New Feat] CircleCI Artifact Mode

Snapshot diff report vs main

File name
Image

co.kr.parkjonghun.roborazzi.compare.on.github.comment.MainActivityScreenshotTest.launch_compare.png

Snapshot diff report vs main

File name
Image

co.kr.parkjonghun.roborazzi.compare.on.github.comment.MainActivityScreenshotTest.launch_compare.png

Snapshot diff report vs main
There is no screenshot change exist in this pull request !


Rework iterator to be more versitile

add iterator to public api
bump version to account for changes to api in this and previous PR
varint iterator on Buf should be consuming, this allows for slices and avoids needless restrictions on what can be iterated over. Things such as Vec will deref into a  &[u8] so will not be consuming.

Merged, will publish this evening.


Generate Service stops responding at "What is the database connection string"

Steps to reproduce
When generating a service, when I'm prompted with "What is the database connection string", the console stops responding to any commands. The text cursor is still blinking, the system is still responding, but there is nothing I can do other than close the console window. Ctrl+C doesn't work, I tried many combinations of keys but nothing I do causes any effect.
To reproduce:

on windows, open cmd.exe
cd to an empty folder
feathers generate app, type any name, default for all options
feathers generate service, type any name, default for all options

I can generate other service, for instance using "A custom service" as the first option, without a problem.
Screenshot:
https://i.imgur.com/0qAm2JP.png
Expected behavior
Be able to type a string when asked for connection string, and press return to advance
Actual behavior
I can't type anything, return key does nothing
System configuration
Module versions (especially the part that's not working):
feathers 3.6.1
NodeJS version:
8.1.0
Operating System:
win10 x64
PS: I realize that this is probably an issue on my end, but I failed to find anyone with a similar issue, perhaps I didn't use the correct keywords on the google search. I'm hoping I can get some guidance here, so I appreciate any little help.

I have solved this issue by upgrading to node v9.7.0

I think we can close this then. Thanks for the update!


If it keeps showing "running," do you know what might be causing this, or do I need to configure the network settings?

hey @pdsu-zjl , can you add some more details about the issue. This seems to be vague to understand why it takes too long? Can you check the output in the terminal?

@SubramanyamChalla24
1.environment：window11 / python=3.10 / other like your requirements.txt/  GPU3080/cpu R9-5900hx
2.Run in  miniconda
3.Then  amend path in run_first.py

amend path in JobDescriptionp......py

python run_first.py  in miniconda

5.streamlit run streamlit_app.py

6  keeps runing a long time

Final: I noticed that your project uses Apache 2.20. Do I also need to deploy Apache on my computer to use it? Thank you very much for your response. I actually didn't expect to get a reply. I didn't think that someone as outstanding as you would be so kind. Thank you very much.

hey @pdsu-zjl , you need not change the path in 1st and 2nd images.


Make a new release

Situation
The current docs mention that SQL_DIALECT is not required, but the released version is older than version. We should make another new release soon.
Please be aware there is two unreleased changes files, do not forget to unify them.
Acceptance Criteria

A new version is released

Most probably done with the version 2.0.0 release.


Require valid schema to release to production

Follow up to #4294, makes valid schema a prerequisite of production deploys.

Warnings

:warning:
The staging version of Metaphysics has breaking changes, this might not affect your build, but could mean your queries don't work the way you expect. See below for breaking changes:

:warning: Field 'Query._unused_gravity_match_partners' changed type from '[DoNotUseThisPartner]' to '[DoNotUseThisPartner!]'
:warning: Type for argument 'term' on field 'Query._unused_gravity_match_partners' changed from 'String' to 'String!'
:warning: Field 'Query._unused_gravity_partners' changed type from '[DoNotUseThisPartner]' to '[DoNotUseThisPartner!]'
:warning: Type for argument 'ids' on field 'Query._unused_gravity_partners' changed from '[ID]!' to '[ID!]!'
:warning: Field 'DoNotUseThisPartner.slug' changed type from 'String!' to 'String'
:warning: Type for argument 'input' on field 'Mutation.recordArtworkView' changed from 'RecordArtworkViewInput' to 'RecordArtworkViewInput!'

  Generated by :no_entry_sign: dangerJS against e80dbea58778d5929a056b0fc017fad91408e917


Updated Chinese Translation

Appears valid to me too. @ermalsh can you review and merge when you get a chance?

Looks good @HarrisonMayotte ! :)


Docker browser build edits

I had difficulty building the browser docker image.
This PR contains some tiny edits to deploy/dockerfiles/browser/browser.dockerfile, development/env.sh and CONTRIBUTING.md files.
I'm not sure if you want to include my dockerfile changes, but the development/env.sh and CONTRIBUTING.md changes will be helpful for future collaborators.
Summary of changes:

advise people to create a blank browser/build.env file before running development/env.sh
fix the call to docker-compose (adds a hypen)
change location of change of user in dockerfile so that yarn install can complete with correct permissions.

Hi @ignatiusm -- thanks for the contributions, much appreciated. The documentation fixes look fine to me. Could you describe the issues/errors you were running into that prompted moving the USER directive in the dockerfile? My recollection is that we're setting the user before the yarn install specifically to avoid running the install as a root user, so I'm curious to see what the issues were there.
Thanks again!

Hi @sjahl,
Here are the errors I get when running ./development/env.sh browser build:
error Could not write file "/home/node/app/yarn-error.log": "EACCES: permission denied, open '/home/node/app/yarn-error.log'"
error An unexpected error occurred: "EACCES: permission denied, mkdir '/home/node/app/node_modules'".

I'm pretty puzzled, hopefully it isn't a noob error on my part. Here are a few of the things I have checked:

correct version of docker for using copy with chown
comment out the volumes block in development/browser.docker-compose.yaml in case they inherited permissions from my filesystem

@sjahl - thank you for taking the time to try to reproduce the error on a few different systems. I was troubled that you couldn't recreate it, so have done some digging.
It turns out it was due to me having an outdated version of docker compose (v1.29.2!) :facepalm: . I tried with a current version of docker compose plugin, and the build ran smoothly.
I'll edit the PR, which will result in only a tiny docs change (adding the creation of the build.env file).

Ready for your review @sjahl . I reverted the unnecessary changes (see comment above). It ended up being a very small PR in the end :smile:


Meetup Suggestion: San Diego Bitcoiners

Thanks for making a suggestion for a new meetup.
Please note: Only suggest bitcoin-only meetups.
Meetups which promote any coin or token other than Bitcoin are not suitable for listing.
Altcoin's are only mentioned in the context of warnings or lessons learnt for bitcoin.
Required:

Name of Meetup: San Diego Bitcoiners
Location Of Meetup: San Diego, CA
At least one of the following:

Meetup Page (or similar): meetup.com/sdbitcoiners
Telegram Group (or similar): #sdbitcoiners:matrix.org
Website: sdbitcoiners.com

Optional

Name of Organiser(s) & Twitter Handle: Corey @inpharmaticist
Links showing public support: >>>
Tweet your commitment
https://twitter.com/sdbitcoiners/status/1402331053549711360?s=20

https://twitter.com/sdbitcoiners/status/1402374788861992964?s=20

Added
Thanks!


Beerparty Randomness

Make the beerparty command return random names of the users reacted to the message

Can you explain please?

Take and example-
I, You and the third person react with 🍻 . Now I react first, you react second, the third person reacts after you.
Now when the bot sends the message it will send it like Glim, FalseDev and Third Person are enjoying a lovely beer together.
I ask to make it like it returns the names of the people randomly for example- Glim,Thier Person and False are enjoying lovely beer together like just return the names of the users randomly

It is already kinda random, discord api returns the user list in possibly a random way


Create gcp module folders

What did you implement:
Closes MC-101
Creates the gcp folder to start implementing the module.
How did you implement it:
Used AWS folder as reference
How can we verify it:
Todos:
Note: Run npm run test-ci to run all validation checks on proposed changes

[ ] Write tests and confirm existing functionality is not broken.
Validate via npm test
[ ] Write documentation
[ ] Ensure there are no lint errors.
Validate via npm run lint-updated
Note: Some reported issues can be automatically fixed by running npm run lint:fix
[ ] Ensure introduced changes match Prettier formatting.
Validate via npm run prettier-check-updated
Note: All reported issues can be automatically fixed by running npm run prettify-updated
[ ] Make sure code coverage hasn't dropped
[ ] Provide verification config / commands / resources
[ ] Enable "Allow edits from maintainers" for this PR
[ ] Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

Is correct?

Is correct?

No, once we have a build for this we can update those, left them there so we don't forget


[CI] CodeCov no longer works after upgrade to v4 of the action

What is the bug?
#484 upgraded our codecov GitHub Action dependency from v3 to v4.   One of the listed Breaking Changes is:

Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token). This doc shows instructions on how to add the Codecov token.

This results in failures in our CI workflow:

==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit -C 634e8d8b252eb6b417485148d167598f91a38dc0
==> Uploader SHASUM verified (103bfefcc56f76473179e600b96eb8150b0f349ad94836b0f63f03ffac469ad7  codecov)
info - 2024-02-04 00:27:18,396 -- ci service found: github-actions
Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

How can one reproduce the bug?

Submit a PR.
Observe lack of a code coverage comment.

What is the expected behavior?
Code coverage, as established org-wide, see https://github.com/opensearch-project/opensearch-plugins/issues/46 and related issues.
What is your host/environment?
GitHub Actions
Do you have any additional context?
The resolution instructions at the CodeCov repo indicate adding an appropriate Secret to the repo will resolve this.  We would add a token: field under the with: here referencing that secret:
      - name: Upload Coverage Report
        if: ${{ matrix.codecov }}
        uses: codecov/codecov-action@v4
        with:
          file: ./build/reports/jacoco/test/jacocoTestReport.xml

However, individual repo maintainers do not have permissions to edit secrets, so resolving this will require EE team to add the secrets both here and org-wide.
I did experiment on my fork (which, as a fork, the docs say could have used the upstream public repo's token) with the standard-named token, but it doesn't seem to be present, so needs to be added.
        with:
          file: ./build/reports/jacoco/test/jacocoTestReport.xml
          token: ${{ secrets.CODECOV_TOKEN }}

CC @bbarani

Failure on a PR from a fork, looks like upload succeeds but gets 500 error, no coverage report:
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit -C a36368cbead7375243de682205fa6bb2ffd9cadf
info - 2024-02-05 18:45:41,773 -- ci service found: github-actions
info - 2024-02-05 18:45:42,104 -- The PR is happening in a forked repo. Using tokenless upload.
info - 2024-02-05 18:45:43,068 -- Process Commit creating complete
error - 2024-02-05 18:45:43,068 -- Commit creating failed: {"error": "Server Error (500)"}
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report -C a36368cbead7375243de682205fa6bb2ffd9cadf
info - 2024-02-05 18:45:43,775 -- ci service found: github-actions
info - 2024-02-05 18:45:44,564 -- Process Report creating complete
error - 2024-02-05 18:45:44,564 -- Report creating failed: ["Commit SHA not found"]
==> Running command '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov do-upload'
/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov do-upload -f ./build/reports/jacoco/test/jacocoTestReport.xml -C a36368cbead7375243de682205fa6bb2ffd9cadf
info - 2024-02-05 18:45:45,[28](https://github.com/opensearch-project/flow-framework/actions/runs/7789320303/job/21240683335?pr=494#step:5:29)0 -- ci service found: github-actions
warning - 2024-02-05 18:45:45,[29](https://github.com/opensearch-project/flow-framework/actions/runs/7789320303/job/21240683335?pr=494#step:5:30)1 -- xcrun is not installed or can't be found.
warning - 2024-02-05 18:45:45,[30](https://github.com/opensearch-project/flow-framework/actions/runs/7789320303/job/21240683335?pr=494#step:5:31)3 -- No gcov data found.
warning - 2024-02-05 18:45:45,303 -- coverage.py is not installed or can't be found.
info - 2024-02-05 18:45:45,[34](https://github.com/opensearch-project/flow-framework/actions/runs/7789320303/job/21240683335?pr=494#step:5:35)7 -- Found 1 coverage files to upload
info - 2024-02-05 18:45:45,347 -- > /home/runner/work/flow-framework/flow-framework/build/reports/jacoco/test/jacocoTestReport.xml
info - 2024-02-05 18:[45](https://github.com/opensearch-project/flow-framework/actions/runs/7789320303/job/21240683335?pr=494#step:5:46):[46](https://github.com/opensearch-project/flow-framework/actions/runs/7789320303/job/21240683335?pr=494#step:5:47),134 -- Process Upload complete
error - 2024-02-05 18:45:46,134 -- Upload failed: ["Commit SHA not found"]

Looks to me like its a broader issues and only impacts the backports, because they are not from forked repos. From what I understood Tokenless uploading is still supported. https://github.com/codecov/codecov-action?tab=readme-ov-file#breaking-changes
Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token)

We should try to address this to all repos and see how this can be fixed when updated to v4.
Thanks

From what I understood Tokenless uploading is still supported

That's what I initially thought but the evidence in PRs shows otherwise.
It says "Tokenless uploading is unsupported."   What it does allow is a fork of an upstream to use the upstream's token in a PR to the upstream.
This is a trivial exercise when one has access to add secrets to the repo.

I can go here to see my token:  https://app.codecov.io/gh/opensearch-project/flow-framework/settings
I can click one button with my mouse and copy it to my clipboard
I could, if I had permissions, go to "Secrets" on my repo and paste the value and name it CODECOV_TOKEN.

This would take me about 30 seconds.

Token has been added under SECRETS.CODECOV_TOKEN Thanks!

Thanks @gaiksaya !


OIDC rp client error

with instruction present in jwtconnect_python_oidcrp directory, return this error:
python3 -m flask_rp.wsgi ../../sso_isprambiente_it.json
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/ranaldi/tmp/satosa_tmp/jwt/JWTConnect-Python-OidcRP/example/flask_rp/wsgi.py", line 30, in <module>
    context = create_context(dir_path, _web_conf)
  File "/home/ranaldi/tmp/satosa_tmp/jwt/env/lib/python3.10/site-packages/oidcrp/util.py", line 467, in create_context
    _fname = lower_or_upper(config, "server_cert")
  File "/home/ranaldi/tmp/satosa_tmp/jwt/env/lib/python3.10/site-packages/oidcrp/util.py", line 410, in lower_or_upper
    res = config.get(param.lower(), default)
AttributeError: 'NoneType' object has no attribute 'get'

I've updated the docs here
https://github.com/italia/Satosa-Saml2Spid/blob/master/example_sp/jwtconnect_python_oidcrp/README.md
and tested it. Let me know if it works also for you and if we can then close this issue
thank you Andrea!

Now it works :+1:
I created a pull request with some instructions to configure the RP, I assigned the request to you, what do you think?

Great, thank you Andrea!


.open() never resolves if canActivate() returns false

I'm submitting a bug report

Library Version:
1.0.0-beta.3.0.1

Please tell us about your environment:

Operating System:
Windows [7|10]

Node Version:
6.2.0

NPM Version:
3.8.9

JSPM OR Webpack AND Version
JSPM 0.16.32

Browser:
all

Language:
all

Current behavior:
If the VM .canActivate() method returns false the whole part where compositionEngine.compose() and renderer.showDialog() is skipped. If you have called:

.open() - the returned promise will never resolve.
.openAndYieldController() - the returned promise will resolve with the controller, but the .result property added to the controller will never resolve.

Expected/desired behavior:

What is the expected behavior?
Since there is no retry mechanism if .canActivate() returns false that should be considered a cancellation. The caller of .open()/openAndYieldController() should be notified for the cancellation or inability to proceed, if returning false is not considered a (early) cancellation.

I think I was bit by this bug today. I couldn't get the dialog promise to return after using controller.ok().
I bypassed by using a canDeactivate() method to do a delayed promise resolution:
    canDeactivate() {         return new Promise(function(resolve, reject) {              console.log("Called canDeactivate");             window.setTimeout(                 function() {                     resolve(true);                 }, 100);         });     }

@pwkad Do we think the promise returned from .open should reject or resolve(false)?

@davismj reject only if the developer asks for it specifically to keep a good dev experience

Closed #225.


How to modify the size of epoch at training?

Hello, author. I'm trying to run your code and am currently training VAE, but I'm running into a problem (although this issue doesn't affect the normal use of the code), please how can I modify the size of epoch at training, I look at the prompt terminal while training shows its default training epoch=1000, it's a bit too time-consuming for me. Thank you for replying to me in your busy schedule and look forward to your answer

Hi lassdaf123,
Thank you for interesting at our project, you can set the max_epochs in the training config files
For pytorch lighting the default argments is:
DEFAULT
trainer = Trainer(min_epochs=1, max_epochs=1000)
By set this parameter, you can change any training epoch number you want:
trainer:
benchmark: True
max_epochs=the epoch number you want.
Thanks,
Tao

Thank you very much。


Add missing test case

Add test case for the non-async interception callback.

Codecov Report

Merging #221 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   99.64%   99.73%   +0.08%
==========================================
  Files          16       16
  Lines        1126     1126
==========================================
+ Hits         1122     1123       +1
+ Misses          4        3       -1

Flag
Coverage Δ

#linux
99.73% <ø> (+0.08%)
:arrow_up:

#macos
?

#windows
?

Impacted Files
Coverage Δ

src/HttpClientInterception/DelegateHelpers.cs
100.00% <0.00%> (+2.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b35c305...c3bbc16. Read the comment docs.


Added ability to disable query to ArtifactHub via env

It is now possible to disable the query through environment variable HD_NO_ARTIFACT_HUB_QUERY.
Changes Proposed

As suggested by @undera in #506

Check List

[x] The title of my pull request is a short description of the changes
[x] This PR relates to some issue: Closes #506
[ ] I have documented the changes made (if applicable)
[ ] I have covered the changes with unit tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 30.18%. Comparing base (b5bed10) to head (4b93040).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #515   +/-   ##
=======================================
  Coverage   30.18%   30.18%
=======================================
  Files          10       10
  Lines        1335     1335
=======================================
  Hits          403      403
  Misses        891      891
  Partials       41       41

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Very good.
Unfortunately, we have no documentation place to reflect this flag


Vulnerability roundup 83: openjpeg-2.3.1: 1 advisory

search, files

[ ] CVE-2020-8112 CVSSv3=6.5 (nixos-19.09, nixos-unstable)

Scanned versions: nixos-19.09: c49da6435f3; nixos-unstable: 8130f3c1c2b. May contain false positives.

See also: #77939

PRs merged.


how to use soundjs in angular 2

previously i used soundjs,preloadjs in angularjs version1.
now i want to use angularjs2,
i dont know how to add createjs code in angular2.
help me!!!

Can you provide any specific questions? Are you having trouble accessing the SoundJS directly? Feel free to provide more info.


api to upload to nginx-image-server ?

hi, is there some api?
I would like to be able to upload images to nginx-image-server's image directory via some api.
What is your approach? Thank you

@Alino Here at Wantedly, we don't upload images to S3 through nginx-image-server. Clients (browsers and mobile apps) directly uploads to S3 using policy and signature issued by API server. Hope this helps.

thank you for answer.
If someone is still interested in making it possible to upload images to nginx-image-server, you might get inspired from my fork -> https://github.com/Alino/nginx-image-server/commit/1b0f9263880d26531f91e0911200d2d332e0d761