Added missing meta files for readme, license

Summary
Adds a few missing meta files for the readme, license.

@jeffcampbellmakesgames Hey! Sorry, did not notice you made a PR, and I was changing the branch from master to dev, to try to have a mimic a similar setup to what you explained to me. Deleting the branch closed the PR automatically  (obviously).
If you want create a new one, please do :)

@jeffcampbellmakesgames Hey! Sorry, did not notice you made a PR while I was changing the branch from master to dev, to try to mimic a similar setup to what you explained to me. Deleting the branch closed the PR automatically (obviously).
If you want create a new one, please do :)

No worries, super small addition that I see has been made on the repo since then. If I see other opportunities to PR something back I will!


How to use DCell to connect the remote node and use the actor?

Hello,I am a newer. I want to know how to connect remote ip by DCell.Maybe that is a simple question for you!!!Could Any one can reply ?
such as in my computer is my_ip and the remote server machine is remote_ip.
should it be right to do ?
The code in my local computer
require 'dcell'
DCell.start :id => "node1", :addr => "tcp://my_ip:4001",:directory => {:id => 'remote_node',:addr => 'tcp://remote_ip:4002'}
The code in my remote computer
require 'dcell'
DCell.start :id => "remote_node", :addr => "tcp://remote_ip:4002"
How to do?

Hello @firesky594, please ask about this on the Google Group:
https://groups.google.com/forum/#!forum/celluloid-ruby
This issue tracker is for bugs and feature requests.

Hello @firesky594,
on the server node you have to setup DCell with real IP(externally visible), on the client you don't have to setup anything as it should discover the server node via registry.

Hello  @digitalextremist , I am sorry..I use github  for a short time :)
Hello @niamster , Is it like this?
On the server:
DCell.start :id => "remote", :addr => "tcp://real_IP:1234",
:registry => {
:adapter => 'redis',
:server => 'real_IP',
:port => 6379
}
On the client :
DCell.start :id => "local", :addr => "tcp://local_IP:1234",
:registry => {
:adapter => 'redis',
:server => 'real_IP',
:port => 6379
}
Thank for reply :)

Hello @firesky594
If you are using current master the server will look like:
require 'dcell'
require 'dcell/registries/redis_adapter'

registry = DCell::Registry::RedisAdapter.new redis_options
DCell.start id: 'remote', registry: registry

And for the client as simple as
require 'dcell'
require 'dcell/registries/redis_adapter'

registry = DCell::Registry::RedisAdapter.new redis_options
DCell.start registry: registry
remote = DCell::Node['remote']

Where redis_options correspond to the native options of redis-rb GEM.
Check out examples in DCell repo.


fix: update status description to show uncropped message and correctly display Details url when tests fail

Codecov Report
Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (399d6d8) 93.24% compared to head (8d2b5ad) 93.17%.

Files
Patch %
Lines

src/action.ts
16.66%
5 Missing :warning:

src/error.ts
61.53%
5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff               @@
##           typescript      #88      +/-   ##
==============================================
- Coverage       93.24%   93.17%   -0.07%
==============================================
  Files               4        5       +1
  Lines             459      469      +10
  Branches           36       36
==============================================
+ Hits              428      437       +9
- Misses             31       32       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implement Connector Inteface for Harvard

Connector implementation for reading Harvard pilot data from xlsx file has been written and tested - will close this issue once the class has been adjusted to accommodate final data with user Role

release 1.3.0 of pass-grant-cli closes this


tcl: add a fallback from hardcoded TCLRL_LIBRARY path

TL;DR This fixes the last niggling little deployment problem with non-Ubuntu systems and bazel-orfs GUI.
Not pretty, but good 'nuf to use around the house.

@oharboe why is this needed? If TCL readline is installed correctly the TCLRL_LIBRARY should be defined in the header:
https://github.com/flightaware/tclreadline/blob/20f1425cec34eeef8f24f1e942e0be4038b8df3a/tclreadline.h.in#L16
Also not a huge fan of hardcoding the version number into the embedded tcl script, second, you should either define this in a namespace for tcl do "find_path" isn't just a random function in the tcl environment or you need to cleanup after yourself.
I would like to know better what the actual issue was that this is addressing, since in a headless build for bazel, why add tclreadline?

@oharboe why is this needed?

It is the final hack at the end of a long story...

If this cruft is to be "acceptable" I think it's worth knowing what the story is. Keep in mind there are no comments or anything describing the issue, so the next person who encounters this code will wonder why this is needed.
This feels like there is an issue with your tclreadline install and it would be better to fix that than have some code that isn't in opensta or the tclshrl builds.

@gadfort Added some gory details on why we have to look up the path dynamically.

@maliberty I don't understand the pr-merge failure, pr-head passes and this PR is on top of the most recent master, so pr-merge and pr-head should be identical.

This feels like there is an issue with your tclreadline install and it would be better to fix that than have some code that isn't in opensta or the tclshrl builds.

This is a good point.  The sta app will not work with this approach.  I believe you are sta for power reporting.

@maliberty mystery pr-merge error?

I see the same two tests failed in many builds:
626 - psm.gcd_write_sp_test_vdd (Failed)
628 - psm.gcd_em_test_vdd (Failed)
I think it worth taking a look at it doesn't seem to be some random flakiness.

@maliberty ctest --test-dir build -j 32 had failures locally without https://github.com/The-OpenROAD-Project/OpenROAD/pull/5961
I propose to merge this as-is or that I wait for https://github.com/The-OpenROAD-Project/OpenROAD/pull/5961 to be merged, then merge with master and do a rebuild of this PR.

@maliberty Fixed!


Can H2ogpt be used to conduct RLHF?

Is there any way that can use H2ogpt to easily conduct RLHF for a LLM?
Also, does H2ogpt support multi-gpu inference when the model is too larger?
For example, when using Falcon40b, it seems even an 80G GPU will encounter an out-of-memory issue. Instead of using quantization, is it possible to spread the memory burden on multiple GPU?

RLHF is supported in LLM Studio by H2O.ai but not in h2oGPT.  HF implemented versions of RLHF and could be added to h2oGPT if someone desired it.
Yes, just pass --use_gpu_id=False and we'll spread model over GPUs for inference if the model supports it.

Is there any guideline or instruction about how to use LLM studio to conduct RLHF?

See https://github.com/h2oai/h2o-llmstudio and ask the primary authors @psinger  and @pascal-pfeiffer .
Also check out our discord where LLM studio is discussed: https://discord.com/channels/1097462770674438174/1100718594809147402

Thank you very much!


Do not cache parse errors

Motivation
Title. Otherwise we fail to report the error second time
Test plan
See included automated tests.
cc @nroman-stripe

Thanks!


request.getResponse returned 501 error.

tried to invoke a speech to text api. By invoking the uri : https://speech.platform.bing.com/speech/recognition/interactive/cognitiveservices/v1?language=pt-BR
passed a wav file as an input.
When called request.GetResponse(). gave an exception "remote server returned an error : 501. Not implemented"

The documentation for the REST API is here:
https://docs.microsoft.com/en-us/azure/cognitive-services/speech/getstarted/getstartedrest
The sample on that page is working, assuming you are supplying correct parameters (keys, wave file format etc).
Wolfgang

I am closing the issue due to lack of response. Please open a  new one if you still have issues.


Documentation

Fixing documentation parameter lazy -> lazyLoad
Please provide enough information so that others can review your pull request:
Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure you test on both platforms if your change affects both platforms.
The code must pass tests and shouldn't add more Flow errors.
Code formatting
Look around. Match the style of the rest of the codebase.

test failure is not related to this commit it's just a documentation fix


WIP: Improve t8n pipeline allowing for invalid tx fields during t8n.evaluate

Following this issue: #242, but only for tx fields.
Allows for an invalid transaction field to be used within t8n.
WIP: Currently this adapts the previous issue: #243, where a tx.to address is set to None. Testing this filled test on hive for geth now correctly returns an appropriate response.
error="invalid transaction 0: rlp: input string too short for common.Address, decoding into (types.BlobTx).To

I don't really like the idea of the framework automatically replacing a value that it thinks it's correct for the tester in the case of an overflow.
For example, what is the "correct" equivalent of the overflowing timestamp value when testing the beacon root pre-deploy?
There is no single answer to this because there could be different bugs in different clients:

The client implementation internally wraps around when setting uint64 to $2^{64}$ to zero, so the test equivalent would be sending a 0 to t8n in the timestamp and verifying that the storage is set to zero in the appropriate places, and then setting $2^{64}$ on the built header rlp.
The client for some bizarre reason interprets $2^{64}$ as $2^{64}-1$, so the test equivalent would be sending a $2^{64}-1$ to t8n in the timestamp and verifying that the storage is set to $2^{64}-1$ in the appropriate places, and then setting $2^{64}$ on the built header rlp.
The client implementation internally uses uint256 and $2^{64}$ is read as is, so the test equivalent would be sending a $2^{64}$ to t8n in the timestamp and verifying that the storage is set to $2^{64}$ in the appropriate places, and also setting $2^{64}$ on the built header rlp.

(1) and (2) are somewhat doable just in this framework, for both of them we have:

a value that goes to the t8n
a value that ends up in the header RLP

but both of these values require care from the tester, and there could be multiple test cases with different values on each.
(3) is more complicated and requires either:

support from t8n to modify the storage appropriately in the result or
execution-spec-tests having the means to modify the alloc values returned by t8n and then calculating the state root and placing the modified state root in the header, along with the modified timestamp value

Sure we could simply modify the values passed to t8n and then modify the header and call it a day, but the problem is that this is not an effective test case because if the client incorrectly reads an overflowing timestamp header field and then proceeds to execute the block, but the state root is still incorrect, it will still return INVALID and the test will pass, but we didn't catch the bug where the client did read the incorrect header.
Another topic is that there are at least two different places where there is incorrect parsing of a fields:

On engine_newPayload via the Engine API
Via syncing when reading the block in RLP format

(1) is how we already test on the pyspec sim, but for (2) I don't think we have an easy way to deliver this block yet, as we would need to peer with the client via devp2p, send an engine_forkchoiceUpdated without a prior engine_newPayload and then handle block serving via the devp2p.

I think for this PR we can settle with making options (1) and (2) feasible and open issues to track the viability of (3) and the hive syncing tests on the hive repo.
For (1) and (2) I would suggest we create an special object that has attributes that contain:

the value sent to the t8n tool
the value that goes into the header RLP and the Engine API field for hive

And then behave accordingly when preparing the environment JSON output to t8n,  and the header building/JSON for the Engine API.


adding MOCK_POST_DATA variable

I need to mock the POST request body (for unit testing). Relevant stackoverflow question: http://stackoverflow.com/questions/40867377/mock-slim-endpoint-post-requests-with-phpunit
It seems as this is impossible with Slim so far (as the RequestBody directly reads from php://input which is read only). I therefore made this pull request to enable this behaviour.
What I've done:

I've added a new variable MOCK_POST_DATA  to the environment
I'm processing this variable while constructing the request.
I've added a unit test to confirm it works as expected
I tried it in an actual project.

If there is a better way to archive this functionality I'm very open for suggestions, and will improve the code if necessary.
I'm choosing the 3.x branch for merging as there is currently no development branch.

wooops I'm sorry, I did not realize this is a fork. I'm gonna try again at https://github.com/slimphp/Slim


Custom input class

Currently there is no way specify custom css classes to be applied to the input element. This makes it inconvenient to integrate the date picker with existing css frameworks, as separate styles must be specified for the datepicker input.
It would be nice if an option were provided to pass custom classes to the input element.

This is quick fix.  I'm going to make more cleaner way to do this.
mounted() {
            var input = this.$el.querySelector('input');
            //Add class
            input.className = 'form-control';
            //Add style
            input.style = 'background-color: #ffffff';
      }

Support added in c8d29bf

Here's how I styled the cells on the calendar--had to fight against the hyper-specific inline rules the library outputs in order to change the colours from blue to pink:
    mounted() {
        const specificityHax = `
            .vdp-datepicker__calendar .cell:not(.blank):not(.disabled).year:hover { border: 1px solid ${colors.pink}; }
            .vdp-datepicker__calendar .cell:not(.blank):not(.disabled).month:hover { border: 1px solid ${colors.pink}; }
            .vdp-datepicker__calendar .cell:not(.blank):not(.disabled).day:hover { border: 1px solid ${colors.pink}; }
            .vdp-datepicker__calendar .cell.selected {
                background: none;
                background-color: ${colors['pink-lighter']};
                color: ${colors['black-darker']};
            }
            .vdp-datepicker__calendar .cell.selected:hover {
                background: none;
                background-color: ${colors['pink-lighter']};
                color: ${colors['black-darker']};
            }
        `;

        const style = document.createElement('style');
        if (style.styleSheet) style.styleSheet.cssText = specificityHax;
        else style.appendChild(document.createTextNode(specificityHax));
        document.getElementsByTagName('head')[0].appendChild(style);
    },

This code appends <style> into the document head with those rules. I recommend browsing the styles in your dev tools and override the styles on the same classes they are originally on.
Here is what that code produces:

This does not seem to be necessary anymore. The styles are not inline (anymore?).
I am able to override each class within my site-wide linked CSS without the need for any JavaScript.

Hello @DeltaBravo How did you do that? Can you explain or show an example


Slows down Fx startup

Firefox 45dev 64b on Linux Mint.
With disabled extension Fx is usable after around 6 seconds. I see below 0.5 second delay between painting of new tab search bar and speedial thumbnails.
Enable extension and restart two times.
I see ~3 seconds delay between when search bar on new tab page is visible, and when speeddial thumbnails are loaded. Fx startup time increase to ~9 seconds.
This is somehow related to extension configuration, because I see this behavior in other extensions (Google™ Translator)

This add-on isn't doing much. If there is a slow down, it's probably Firefox internals for general add-on loading. I tested and could see a slow down. I assume you tested with only this add-on and no others installed? It would be much more interesting if you'd tested with 10 others installed and then give me figures for having this add-on enabled/disabled. To reproduce I'd also need the names of all these add-ons... But I doubt I can do much any way.

I was testing all my addons one by one because of this slowness, but above numbers (6s -> 9s) are from my current setup:
Add-on Update Checker	2.15	true	{891f0410-aaa2-11e0-9f1c-0800200c9a66}
Classic Theme Restorer	<IP_ADDRESS>	true	ClassicThemeRestorer@ArisT2Noia4dev
Cookie Controller	4.5	true	{ac2cfa60-bc96-11e0-962b-0800200c9a66}
Distill Web Monitor (formerly AlertBox)	1.4.9	true<EMAIL_ADDRESS>FEBE	8.8.1	true	{4BBDD651-70CF-4821-84F8-2B918CF89CA3}
Feed Sidebar	<IP_ADDRESS>-signed	true<EMAIL_ADDRESS>FindBar Tweak	2.1.5	true	fbt@quicksaver
FireGestures	1.10.3	true<EMAIL_ADDRESS>Greasemonkey	3.7beta2	true	{e4a8a97b-f2ed-450b-b12d-ee082ba24781}
Hide Caption Titlebar Plus	3.0.5	true<EMAIL_ADDRESS>OmniSidebar	1.6.9	true	osb@quicksaver
uBlock Origin	1.6.0	true<EMAIL_ADDRESS>YouTube High Definition	43.3	true	{7b1bf0b6-a1b9-42b0-b75d-252036438bdc}

This 3 seconds delay looks "constant". For example (approximately):
Using clean profile:

no extension 3s
with otntc 5s
with ublock 4s
with ublock + otntc 7s

Third extension with this behavior is "YouTube Plus"

What I meant to say was that I can't see a slow down. Enabled or disabled, Firefox takes 10 seconds to start(I've got quite a few more add-ons than you). Also, enabling and disabling the add-on is practically instantaneous. I assume there are several add-ons that use the same internals as this one, so they are loaded in any case for me, but not for you...


Issue with Codeium in Rstudio Server http://<IP_ADDRESS>:8787/

I hope this email finds you well. My name is Tianrui, I am a new user about Codeium. I installed this plugin on edge browser,I want to use this plug-in on the Rstudio server web page, the URL is http://<IP_ADDRESS>:8787/.
I tried adding the following content to the Allowlist in the settings: http://<IP_ADDRESS>.* or <IP_ADDRESS>.*
But it still doesn't work,I don't know if it's because I set it up wrong, or if it's not working properly due to other circumstances. I really need your help, thank you very much.
Thank you in advance for your assistance.
Best regards,
Tianrui

We haven't tested/explicitly supported RStudio web, so this is probably expected. Do you know what type of text editor library it's using?


Translation for complex workflow states

The translation of the recommendation label is not Ablehnung (nicht berechtigt) but Verwerfung (nicht zulässig). See translation of the state name and the action word of this state.
Also the translation Genehmigung should be Zulassung.

Done in transifex


where the asset/color.json ？

where  is the asset/color.json ？

here is the assets/color.json.
https://github.com/nshmura/RecyclerTabLayout/blob/master/demo/src/main/assets/colors.json


[BUG][NOWEB] - Connection Closed

While sending text using POST Method, I'm getting Error: Connection Closed

Version
{
  "version": "2024.9.1",
  "engine": "NOWEB",
  "tier": "PLUS",
  "browser": "/usr/bin/google-chrome-stable"
}

Engine I'm using NOWEB engine.
Requests - Responses
{
 "statusCode": 500,
 "timestamp": "2024-09-06T13:23:50.231Z",
 "exception": {
   "stack": "Error: Connection Closed\n    at sendRawMessage (/app/node_modules/@adiwajshing/baileys/lib/Socket/socket.js:59:19)\n    at sendNode (/app/node_modules/@adiwajshing/baileys/lib/Socket/socket.js:78:16)\n    at query (/app/node_modules/@adiwajshing/baileys/lib/Socket/socket.js:142:15)\n    at getUSyncDevices (/app/node_modules/@adiwajshing/baileys/lib/Socket/messages-send.js:168:30)\n    at /app/node_modules/@adiwajshing/baileys/lib/Socket/messages-send.js:401:57\n    at Object.transaction (/app/node_modules/@adiwajshing/baileys/lib/Utils/auth-utils.js:136:32)\n    at relayMessage (/app/node_modules/@adiwajshing/baileys/lib/Socket/messages-send.js:307:30)\n    at Object.sendMessage (/app/node_modules/@adiwajshing/baileys/lib/Socket/messages-send.js:677:23)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)",
   "message": "Connection Closed",
   "data": null,
   "isBoom": true,
   "isServer": false,
   "output": {},
   "name": "Error"
 },
 "request": {
   "path": "/api/sendText",
   "method": "POST",
   "body": {
     "chatId"<EMAIL_ADDRESS>     "reply_to": null,
     "text": "Hi there!",
     "session": "warmer_tt"
   },
   "query": {}
 },
 "version": {
   "version": "2024.9.1",
   "engine": "NOWEB",
   "tier": "PLUS",
   "browser": "/usr/bin/chromium"
 }
}

hi! Does the session restart or retry helps with this error?
We reconnect the session every 30 minutes and it's not available for about 2 seconds during this time - it could be this issue.
May be you could attach docker container logs for this case? It'd really help :pray:


[Question] SKE node_pool order important ?

Hello,
I am using the terraform provider in the latest version (currently v.0.19.0).
When I define a stackit_ske_cluster and add a node_pools list this list seems to be required to keep the initial order.
Adding new items to the end of the list is working fine, but when you start to delete items from the "middle" of the list the terraform plan output seems like it is trying to keep everything "in-order".
Just as an example - I have the following configuration
resource "stackit_ske_cluster" "example-cluster" {
  name               = "example"
  project_id         = 1-2-3-4-5
  kubernetes_version = "1.28"
  node_pools = [
    {
      name         = "example-01"
      machine_type = "c1.3"
      minimum     = 1
      maximum     = 2
      os_version  = "3815.2.2"
      volume_size = 50
      volume_type = "storage_premium_perf2"
      availability_zones = ["eu01-1"]
    },
    {
      name         = "example-02"
      machine_type = "g1.4"
      minimum     = 1
      maximum     = 2
      os_version  = "3815.2.2"
      volume_size = 50
      volume_type = "storage_premium_perf2"
      availability_zones = ["eu01-1"]
    },
  ]
}

If I run terraform apply all is great. But if I now go ahead and just reorder those two so it becomes this
resource "stackit_ske_cluster" "example-cluster" {
  name               = "example"
  project_id         = 1-2-3-4-5
  kubernetes_version = "1.28"
  node_pools = [
    {
      name         = "example-02"
      machine_type = "g1.4"
      minimum     = 1
      maximum     = 2
      os_version  = "3815.2.2"
      volume_size = 50
      volume_type = "storage_premium_perf2"
      availability_zones = ["eu01-1"]
    },
    {
      name         = "example-01"
      machine_type = "c1.3"
      minimum     = 1
      maximum     = 2
      os_version  = "3815.2.2"
      volume_size = 50
      volume_type = "storage_premium_perf2"
      availability_zones = ["eu01-1"]
    },
  ]
}

and I execute a new terraform plan I expect no changes because I basically only changed the order of items. But the output implies that it would go ahead and recreate the first nodepool with new machine type etc.
  # stackit_ske_cluster.example-cluster will be updated in-place
  ~ resource "stackit_ske_cluster" "example-cluster" {137e6752a0aa
        name                    = "example"
      ~ node_pools              = [
          ~ {
              ~ machine_type       = "c1.3" -> "g1.4"
              ~ name                    = "example-01" -> "example-02"
                # (10 unchanged attributes hidden)
            },
          ~ {
              ~ machine_type       = "g1.4" -> "c1.3"
              ~ name                  ="example-02" -> "example-01"
                # (10 unchanged attributes hidden)
            },
        ]
        # (3 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

I faced this issue with my other SKE cluster which contains 7 NodePools [ is-01, sol-01, sol-02, sol-03, is-02, ut-01, ut-02] (in this order).
I want to delete sol-01, sol-02, sol-03 and expected no changes besides that it would delete 3 objects. But instead it would delete 3 objects ( is-02, ut-01, ut-02) and change 3 objects (change sol-01 to match is-02, change sol-02 to match ut-01 etc.). And by change I mean it would change (as in my example above) machine-type, name, labels, availability zone etc.
My question would simply be - is this really what is going to happen in the background ? Or is this just terraforms plan output and the provider catches those order issues and does not touch 6 different node_pools, just because I wanted to delete 3 which would change the order.
Greetings,
JanGrosse

Hi @JanGrosse,
Even though the plan looks strange, the correct payload is sent to the SKE API, which has a single endpoint for creating/updating a cluster. This receives the list of nodepools as an array of objects, and each nodepool is uniquely identified by its name.
This is a valid concern and was already raised here (#372), which seems to be a shortcoming of the terraform-plugin-framework. A possible workaround from our side would be to use nested blocks, but we won't do it as these were discouraged in favor of what was are using right now (as explained here)

Hi @joaopalet ,
thank you for the detailed informations. Okay, so I understood from the closed issue that only the terraform plan output looks strange and in the end the correct payload is send towards the SKE API. So as there is currently no feasable workaround would it make sense to add this kind of information into the provider documentation itself ? There might come additional colleagues facing the same output and starting to wonder what will happen if they apply the terraform plan output 😄
But besides that my question is answered, thank you, I am going to close the issue.
Greetings,
JanGrosse.

Thanks for the suggestion @JanGrosse!


Disabling access logging through Telemetry API does not disable logging for TCP calls

Bug Description
When disabling the access logging through the Telemetry API, all HTTP calls stop being logged (as expected), but TCP calls are not.
For example, one of out workloads still logs outgoing calls to Google APIs (on port 443), Graphite (port 2003) and Consul (port 8300). All non-HTTP traffic.
The telemetry config to disable the logs looks like:
  accessLogging:
  - disabled: true
    providers:
    - name: envoy

Access logging has been configured with a custom format and encoding (JSON)
Version
Istio ASM 1.12.4

Additional Information
No response

can you share a your configdump?

A config_dump for an instance with this issue can be found here: https://gist.github.com/rolandkool/f351483eb7caf0a8065c40ae72ca2a35

A config_dump for an instance with this issue can be found here: https://gist.github.com/rolandkool/f351483eb7caf0a8065c40ae72ca2a35

can you try this with 1.13?

I cannot reproduce this with 1.13, so I assume it was fixed in that release.

I cannot reproduce this with 1.13, so I assume it was fixed in that release.

yes, I think those fixes did not backport to 1.12

Just wanted to check if this is this resolved by https://github.com/istio/istio/pull/36586 and https://github.com/istio/istio/pull/36661?

Just wanted to check if this is this resolved by #36586 and #36661?

I did not reproduce this on v1.13, so I would say yes.


Date values BC are sorted by absolute values

There is a problem with sorting. I want to include historical dates (both AD and BC) in the YAML frontmatter of the files. I enter calendar dates BC in the YAML frontmatter with a leading negative sign; for example, -0715-01-01 for 1 January 715 BC. With "Sort files by properties (ascending)" all negative dates are sorted by their absolute values. Is there a solution to this? Thank you very much!

Hey! This should be fixed in the latest release (1.0.2)


When i use filebeat plugin,need i start filebeat?

Log-Pilot will start filebeat process by itself and support live configuration reload.


Updated language list

@aahill

@rlagh2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


OutOfMemoryError: Java heap space in Libreoffice with AdoptOpenjdk 13.0.1-hotspot

Windows10 64-bit
LibreOffice 6.3, LanguageTool 4.7
Every time a tect document is opened, an OutOfMemoryError: Java heap space is thrown.
This problem is present with AdopOpenJDK 13.0.1 with HotSpot JVM.
It does not occur with Oracle Java (from 8 to 13,0,1), openjdk 13.0.1, or AdoptOpenJDK  13.0.1 with OpenJ9 JVM

@HelmutL Delete the folder bin/client in the JDK directory and test again. I suspect the client VM is requested which by default uses a significantly smaller heap. We‘re one of very few providers that still ships a client VM.

It seems this is the trick. After deleting the client directory it seems to run ok (tested with jdk-14.0.1+7 with hotspot). When the directory is present, the error occurs.

Great to hear. Please report to LibreOffice that they should stop requesting the client VM (most vendors do not ship it anyway and the server VM is the default on 64 bit Windows) or configure an appropriately large heap with -Xmx. The default maximum is 256 Mb as specified by Oracle.


Add support for JS logging

Hey, I'm interested in this library's approach to logging as I'm currently using kotlin-logging and I do find your approach more sensible.
However, since I'm mostly involved in Kotlin MPP with JS, I cannot make the move and try this out until JS support is provided.
I hope you don't mind me creating this issue mainly for me to track progress on logging for JS, even if I end up just receiving a "merged/closed" notification at some point! :)
Now, in terms of implementation, I read a comment of yours on Reddit saying that you're planning on providing logging for JS by integrating with winston in a la4k-winston. My question for you is: how do you plan on tackling browser logging?
This is an open issue on winston's issue tracker: https://github.com/winstonjs/winston/issues/287 and I'm not sure if there is already a "good" solution for it, even though some solutions seem to have appeared.
I don't exactly have any metrics on this, but I'd guess that most kotlin-js and kotlin-multiplatform projects target browser JS and don't much care about Node, so my take on this is that browser logging is likely more important than logging on Node, or at least for me it is.
At least in my case, as a library developer, I'm interested in allowing library users to "turn on" browser logging in development mode when using my library, so that they can see library logs as "things happen" in the browser.
What are your thoughts on this? What's your take on JS logging and browser logging in general?

This could possibly be used until winston as an "official" solution: https://www.npmjs.com/package/winston-transport-browserconsole (also suggested in the issue linked above).
Would it be provided by la4k-winston by default?

I am so sorry. It is December 20th, and I have only just now noticed your issue. I will respond sometime tomorrow in more detail.

I've reread what you posted and read over the Winston issue you provided. From what I can see, you want users of your library to be able to have logging regardless of where your library is being run. To this end, I'm not sure trying to cram Winston in the browser is the best way to go. Ultimately, where do you want browser logs to end up?
I released LA4K 0.5.0 yesterday. la4k-winston is present for NodeJS targets, but all targets (including the browser), also have a la4k-console bridge available. This just prints logging events via Kotlin's println() function. See here.
I haven't messed with LA4K in the browser yet, you will need (I think) to include the JS for la4k-api and la4k-console. Then activate the bridge (documented in the link above), then include the JS for your library.

Yeah, I explored the repo a bit after your comment. la4k-console is all I need, I believe. I just want users of the library to be able to see logs in the browser console during development.
Thanks! Hopefully I'll give this library a try at some point, for now I'll close this issue as the support for JS seems to be here already! :)

Very well. Please reopen this issue if you have difficulties.

@nunocastromartins - I wanted to check in with you and see how things are going with regard to this library.

Hey, thanks for checking in but unfortunately I've got nothing to report. The development of the project in which I was considering using this library is currently halted until I finish a different project. This is currently on my backlog but I won't get to it until possibly quite a bit in the future.


Update GCP setup step in GitHub workflows

Remove use of service_account_email from GCP setup in CI workflows.
:memo: Checklist

[x] All user-facing changes have changelog entries.
[x] The changes are reflected on docs.tenzir.com, if necessary.
[x] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions

File-by-file

Merging this, as the CI error is not related to the changes introduced by this PR. Efforts to resolve the underlying issue will be tracked in another PR.

Merging this, as the CI error is not related to the changes introduced by this PR. Efforts to resolve the underlying issue will be tracked in another PR.


Changed assembly output: dir/zip/tar.gz by default, no dir for production

The build has failed due to a connection timeout for repository.jboss.org.  Would it be possible to re-trigger it? I can't see the "restart build" button for this repository, so, I guess I don't have permissions to do so.

Unfortunately, AFAIK Travis only allows us to restart the last ever build (from a PR, from a branch...)


Rework provider and fetching documentation

All the current fetching functions were collected in one manual page, together with a very general description of providers, algorithm fetching and the providers we deliver.
Some of that is reference material that does belong in manual section 3, but the more general description is better placed in manual section 7.
This also includes provider-base(7), which describes the base tables of functions that libcrypto and the provider pass to each other, thereby providing a baseline with which they can communicate further with each other.  This also contains an example for a ficticious provider, providing an implement of a fictitious algorithm for a fictitious operation.

This work is incomplete in itself, as provider(7) refers to other pages in section 7 that are yet to be written.  I'm unsure if that should be for this PR or follow up PRs.  Maybe this one is big enough as it is?

I've added provider-base(7), showing approximately how i imagine the contents of the dispatch tables being described.

Lots of comments addressed

I've decided that this set will be enough for this PR.  We will still need to document the CIPHER, DIGEST, KEYEXCH and KEYMGMT operations, but I'd like to leave that to other PRs.
(part of this decision is giving others a chance to document as well :wink:)

Side discussion aside, where are we with this?

Merged.
e4c0ec6278f1fbfc50fcdd09769f65ca80866f6b Documentation: Add provider(7), for general description of providers
2cafb1dff3ef13c470c4d2d7b1d8a1f7142d8813 Documentation: Move the description of the fetching functions
d4c69c69d171edb17b4d609c15891a9599809ed0 Documentation: add provider-base(7), describing the base functions


Contexts-as-services

This is something that is implemented in e.g. the symfony extension, but we could do it in core
Rather than instantiate a Context we should ask the registered (PSR) containers if they know how to provide it. This would enable some more interesting auto wiring stuff

The hard part here is ensuring isolation. We need to make sure that the containers do reset the state of those services (or recreate them) between scenarios

@stof very good point - PSR-11 has no opinion on it of course


UI - DISABLE_CACHE=true is required when launching UI for changes made to the assistant to take effect

gptscript version v0.0.0-dev+160a7334
Steps to reproduce the problem:

Launch UI -  GATEWAY_URL=https://gateway-api.gptscript.ai gptscript --ui --disable-cache
Create an assistant.
Edit this assistant and add a tool.
Restating the script or running the script from Home page does not result in changes being picked unless DISABLE_CACHE=true is used when launching UI.

This should be fixed, please give it another look @sangee2004

This issue is not seen when testing with  commit id - c5e7e2937


Add app labels to TaskInfo.

See #1051 and MESOS-2120.

https://github.com/mesosphere/marathon/issues/1121


mitmdump doesn't raise done() event

done() function isn't invoked when CTRL+C is pressed.
This event is super important. I need it in order to close a file I'm writing output to, and because the event isn't being raised, the file never closes and buffered data is not written to the filesystem.
Steps to reproduce the problem:
import random
import sys
import os
import json
from datetime import datetime

class RequestsLogger:

    def __init__(self):
        self.requests = []

    def request(self, flow):
        req = flow.request
        client_conn = flow.client_conn

        info = {
            "scheme": req.scheme,
            "url":  req.url,
            "method": req.method,
            "time": str(datetime.now()),
            "host": req.host,
            "dst_port": req.port,
            "headers": dict(req.headers),
            "client_info": {
                "src_addr": client_conn.address[0],
                "src_port": client_conn.address[1],
                "username": os.getlogin()
            }
        }

        self.requests.append(info)

    def done(self):
        print('this should be printed at shutdown')
        print('got {} requests', len(self.requests))

addons = [
    RequestsLogger()
]

Run with mitmdump -s some_file_name.py -q
System information
Mitmproxy: 4.0.4 binary
Python:    3.6.6
OpenSSL:   OpenSSL 1.1.0h  27 Mar 2018
Platform:  Windows-10-10.0.17763

Thanks for the report! Also refs #3584

I had the same problem.

I cannot reproduce this anymore on main, this seems to be fixed. Thanks again for the report and sorry that it took so long. :)


Activity bar active indicator cleanup

This PR cleans up the sizing of activity bar elements. Previously they were 48x40 which would make them an odd size whenever you used activityBar.activeBackground:

So now they are an even 48px (square) and I've also adjusted the padding/margin so that there is no top margin on the first item (fixes #84353):

And lastly I introduced a new color token, activityBar.activeFocusBorder, for the active border when in focus, which is off by default (fixes #83328):

FYI @bpasero

activityBar.activeFocusBorder works as expected.
As for the cleanup of the activity bar sizes. I like that they are squares know. What I do not like:

The active border is now too long, and is even stronger than before. Before I could somehow survive it, but now I feel like it has gone over the top and that is simply screaming in my face for attention
When the active border is on the first element the border goes all the way to the top title. I understand some user requested for this to be removed, however I disagree with this and simply find it ugly

I think decreasing just the size of the active border would solve my both concerns

The active border is now too long, and is even stronger than before...I think decreasing just the size of the active border would solve my both concerns.

This is an effect of making the items square, we can't really make the border shorter without making the container back to the old size. besides, it would look really weird to have it this way if you use a background color (see below). And the width is at 2px, 1px was way too hard to notice, especially being at the left-most side of the screen where things behind affects the contrast.

When the active border is on the first element the border goes all the way to the top title. I understand some user requested for this to be removed, however I disagree with this and simply find it ugly

This is actually something that always bothered me, other apps don't have this top margin:

So if you're not a fan of these changes I can simply just do the focus color token.

I am not a fan of these changes, however I do not think I should be the one to decide against this. They are not bad changes, I just do not like strong UX in area which I personally do not find important in my day to day flow.
If you like them I think it is fair to push them to insiders and we can get more feedback and then decide.
We can also do the middle ground, decrease the width back to 1 px and keep the height increase. I am flexible.

I'll post this to our UX channel and see what the feedback is before merging in then.

Good idea. Thanks!

Got several 👍  from the UX channel, will merge this in and look at the feedback next week for insiders.


Handle situations where parsers create GuacNodes without the required identifier fields

As with https://github.com/guacsec/guac/issues/236, we saw a bug where a parser was allowed to create a GuacNode/Edge without filling up an identifier.

We have PkgEqual and HashEqual to state two nodes are identical, the client GraphQL enforces what fields are mandatory


Diffing 'Level Blueprints'

Hi,
I am using UE4.20.3
I am able to diff blueprints, but not the level blueprints. Maybe I am doing it wrong I right click on the .'umap' and do diff, is there another way I should be doing it?
Thanks,
Simon

Yes, sadly Unreal Engine does not allow this for now.


Implement full archive for Custom Photo Roster Photo View

Parked until I get direction on the approach to use

This will be a custom archiver provider using the Yale libraries provided.

This is done in m3. The demo environment uses a hardcoded photo for all students due to the mock services. It currently puts the data into its own custom directory but that will be eventually put into the main roster archive directory. The way this is written it should just work when wired up with the real environment.


Include junit as testImplementation

this fixes #178
Otherwise including multipicker in the implementation will also include junit in the implementation (discouraged).
More information:

https://docs.gradle.org/current/userguide/declaring_dependencies.html
https://developer.android.com/training/testing/unit-testing/instrumented-unit-tests#setup

Any status on this?

Any status on this?


ffmpeg is needed to download certain videos

maybe package the ffmpeg into the .exe? Or ask the user to install it

Standalone ffmpeg executables are now packaged in the latest release.


Update configuration.md

fixed broken links

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:omercnet/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Current coverage is 52.97%

Merging #1415 into master will decrease coverage by -4.19% as of 8c5ff80

@@            master   #1415   diff @@
======================================
  Files          123     123
  Stmts        11357   11357
  Branches       800     729    -71
  Methods          0       0
======================================
- Hit           6492    6016   -476
+ Partial        800     729    -71
- Missed        4065    4612   +547

Review entire Coverage Diff as of 8c5ff80

Uncovered Suggestions

+0.28% via ...ge/driver/gcs/gcs.go#182...213
+0.23% via ...ge/driver/gcs/gcs.go#85...111
+0.21% via ...ge/driver/gcs/gcs.go#471...494
See 7 more...

Powered by Codecov. Updated on successful CI builds.

LGTM

LGTM


Request to include Domain names and Outbound ports for ADLS Gen2 and Azure SQL

I am helping a client to implement Purview SHIR for ADLS Gen2 and Azure SQL. I reviewed the online documentation and could not find what's the corresponding domain name and outbound ports for these two data sources. It's only referring to "Various Domains" and it would certainly help to include references to the most popular Azure Data services.

I have found similar documentation for ADF SHIR and it's listing ADLS Gen2 and Azure SQL. But it's not clear if this same guidance is applicable to Purview SHIR. For example, what domain name(s) should be listed if Purview SHIR is using Service Principal inside an Azure Key Vault to access ADLS Gen2?

Source: https://docs.microsoft.com/en-us/azure/data-factory/create-self-hosted-integration-runtime?tabs=data-factory#ports-and-firewalls
Thanks,
Nate Couto

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9e632aab-071d-60ae-748f-458c6e8715b1
Version Independent ID: 9089b4ae-3818-dcfb-f5e7-9118516bb167
Content: Create and manage Integration Runtimes - Azure Purview
Content Source: articles/purview/manage-integration-runtimes.md
Service: purview
Sub-service: purview-data-catalog
GitHub Login: @viseshag
Microsoft Alias: viseshag

@natecouto  Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@natecouto - Thank you! I'll work on getting some of those additional/most popular Azure source domains added. We will not be able to support a list of all possible domains, but I can certainly add some of the most used here.
I'll get those added this week.


Feature/BE-43: Backend Unittests [2]

Added tests for Bidding System and Recommendation System APIs.
7 total for Bidding System.
6 total for Recommendation System.
Tests check for multiple things, added comments about what each test checks for.
To run all the tests python manage.py test .
To run a single test python manage.py test -k <name_of_the_function>
To remove results rm test-output/*

Changed the name of the PR to be consistent with the first unittest PR we had.
Due to the most recent bugfix and hotfix PRs, some of the previously written unit tests were not working properly. Updated those unit tests to reflect the most recent changes on our models.
Also there was a print statement left in one of the Recommendation related APIs. Removed that as well. Now, it's ready to go.


rofi quirk

I use rofi as a replacement for dmenu and noticed if more then 8 clips in the list, clipmenu will start when called, selecting the 9th line.   Editing dmenu_lines=${CLIPMENU_LINES} solved the selector starting allways from first line.  Guess it's a tiny headsup for any rofi users:)
Thanks for a great clipboard alternative!

Didn't know about rofi, interesting. Let me take a look later today and see what can be done.

I think this is a bug (or just a difference in functionality?) in rofi. I repro this but I think it's just the way that rofi's version of -l works. I'll go ask the author.

Bug acked upstream. Seems it's a wontfix for the author, sadly.

Will be fixed, might take some time to avoid breakage.

Thanks @DaveDavenport!


[WebGL] Context loss experienced in Neuron sim

The Neuron sim, as of commit 4bc9d97e53c6df522973ee9e962d975b61c1f568, was running overnight, and was still running the following morning, but shortly after that it hit the context loss error captured in the screenshot below.  All it all, it was probably running for about 16 hours before this error was encountered.

I pressed the "ignore" option to continue, and it ended up hitting an exception, shown below.  All of the WebGL items (the particles) had disappeared at that point.

It looks like this issue was probably raised against scenery 0.1.  Scenery 0.2 does not yet have context loss support.  We need to add this in #347 and also for WebGLNode.

Plan to implement in https://github.com/phetsims/scenery/issues/347, closing this issue.


control.runInParallel option to run new fiber until pause

Not sure how feasible this is?
Is your feature request related to a problem? Please describe.
control.runInParallel adds a new fiber that runs 'in parallel' to the current fiber. However, it will continue to run the code in the current fiber before moving on to the new fiber: https://makecode.com/_WWrW5qKXP359 always results in the screen turning white, because the call following runInParallel is always invoked before the handler itself
control.runInParallel(function () {
    scene.setBackgroundColor(1) // runs second
})
scene.setBackgroundColor(2) // runs first

Ideally, it would be nice to have an option to yield to the spawned fiber and then return control when that fiber next yields - e.g. as an optional flag invokeImmediately
control.runInParallel(function () {
    scene.setBackgroundColor(1) // a
    pause(1)
    scene.setBackgroundColor(3) // c
}, /** invokeImmediately **/ true)
scene.setBackgroundColor(2) // b

where the order of execution above would go from line a, pause and yield to b, and finally return to c.
This gets particularly tricky, as I think the ideal behavior would be that it would do this without yielding to other fibers - that is, even if other fibers are waiting to run in the snippet above, the call to runInParallel, line a, the pause, and then line b would all be guaranteed to occur consecutively, without yielding to other fibers.
Describe the solution you'd like
an optional parameter on control.runInParallel to immediately pass control to the invoked function, as described above
Describe alternatives you've considered
I asked michal and the closest workaround we came up with would be a trivial pause after the call to runInParallel:
control.runInParallel(function () {
    scene.setBackgroundColor(1) // runs second
})
pause(0)
scene.setBackgroundColor(2) // runs first

This mostly works (besides 0 being broken right now, and needing to pass 1ms instead: https://github.com/microsoft/pxt-arcade/issues/1098), but it does yield to all other waiting fibers instead of just the newly created one - other fibers might run in between, when the intention is to only yield to the function you just created. I guess another alternate option would be to have two separate events that trigger, with the only difference being that one is run in parallel and one is not.
Additional context
This came up while working on https://github.com/microsoft/pxt-arcade/issues/1057. It's not blocking, but is a real nice to have - it would make overlap events like the ones in ping (where the speed of the ball is reversed on contact with a paddle ) a lot smoother - without some sort of yield to the overlap event the ball can clip all the way through (continuing the current velocity for all remaining steps) and then turn around on the next frame - especially when moving at a high speed, and at times causing the ball to go all the way off the screen and cause a score when the ball was 'blocked' and in the process of turning around

We need a background fiber that integrates into the game loop.

From: Joey Wunderlich<EMAIL_ADDRESS>Sent: Monday, June 24, 2019 5:58:49 PM
To: microsoft/pxt-arcade
Cc: Subscribed
Subject: [microsoft/pxt-arcade] control.runInParallel option to run new fiber until pause (#1099)
Not sure how feasible this is?
Is your feature request related to a problem? Please describe.
control.runInParallel adds a new fiber that runs 'in parallel' to the current fiber. However, it will continue to run the code in the current fiber before moving on to the new fiber: https://makecode.com/_WWrW5qKXP359https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmakecode.com%2F_WWrW5qKXP359&data=02|01|jhalleux%40microsoft.com|cc7c6b8429574e11b3b608d6f90848a4|72f988bf86f141af91ab2d7cd011db47|1|0|636970211314931229&sdata=ts0kwh%2FFZMFpnEIReK7j4E532SJ%2BdeLQrenSF5QZ%2FaA%3D&reserved=0 always results in the screen turning white, because the call following runInParallel is always invoked before the handler itself
control.runInParallel(function () {
scene.setBackgroundColor(1) // runs second
})
scene.setBackgroundColor(2) // runs first
Ideally, it would be nice to have an option to yield to the spawned fiber and then return control when that fiber next yields - e.g. as an optional flag invokeImmediately
control.runInParallel(function () {
scene.setBackgroundColor(1) // a
pause(1)
scene.setBackgroundColor(3) // c
}, /** invokeImmediately **/ true)
scene.setBackgroundColor(2) // b
where the order of execution above would go from line a, pause and yield to b, and finally return to c.
This gets particularly tricky, as I think the ideal behavior would be that it would do this without yielding to other fibers - that is, even if other fibers are waiting to run in the snippet above, the call to runInParallel, line a, the pause, and then line b would all be guaranteed to occur consecutively, without yielding to other fibers.
Describe the solution you'd like
an optional parameter on control.runInParallel to immediately pass control to the invoked function, as described above
Describe alternatives you've considered
I asked michal and the closest workaround we came up with would be a trivial pause after the call to runInParallel:
control.runInParallel(function () {
scene.setBackgroundColor(1) // runs second
})
pause(0)
scene.setBackgroundColor(2) // runs first
This mostly works (besides 0 being broken right now, and needing to pass 1ms instead: #1098https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-arcade%2Fissues%2F1098&data=02|01|jhalleux%40microsoft.com|cc7c6b8429574e11b3b608d6f90848a4|72f988bf86f141af91ab2d7cd011db47|1|0|636970211314931229&sdata=2Ekb908TLQIjMHmwdbiy0wYa8JfSiEzBBJE758xr2YY%3D&reserved=0), but it does yield to all other waiting fibers instead of just the newly created one - other fibers might run in between, when the intention is to only yield to the function you just created. I guess another alternate option would be to have two separate events that trigger, with the only difference being that one is run in parallel and one is not.
Additional context
This came up while working on #1057https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-arcade%2Fissues%2F1057&data=02|01|jhalleux%40microsoft.com|cc7c6b8429574e11b3b608d6f90848a4|72f988bf86f141af91ab2d7cd011db47|1|0|636970211314941218&sdata=EgdgT0rcxoMqPncxvxNHxyE3fBSR%2Fpi%2FClOFXEPsTtc%3D&reserved=0. It's not blocking, but is a real nice to have - it would make overlap events like the ones in ping (where the speed of the ball is reversed on contact with a paddle ) a lot smoother - without some sort of yield to the overlap event the ball can clip all the way through (continuing the current velocity for all remaining steps) and then turn around on the next frame - especially when moving at a high speed, and at times causing the ball to go all the way off the screen and cause a score when the ball was 'blocked' and in the process of turning around
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-arcade%2Fissues%2F1099%3Femail_source%3Dnotifications%26email_token%3DAA73QKJZ4257BNIMAU35ZNDP4FUUTA5CNFSM4H3DOL22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3NOPVA&data=02|01|jhalleux%40microsoft.com|cc7c6b8429574e11b3b608d6f90848a4|72f988bf86f141af91ab2d7cd011db47|1|0|636970211314941218&sdata=5AA9JZ%2BER3enFcC5wnRjNjzkcNkL3WkuSZ3aCbN%2FUYI%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKMROOE3DWDNCW3GHDLP4FUUTANCNFSM4H3DOL2Q&data=02|01|jhalleux%40microsoft.com|cc7c6b8429574e11b3b608d6f90848a4|72f988bf86f141af91ab2d7cd011db47|1|0|636970211314951212&sdata=%2Fmdt8h%2F2C0Of6lhO%2Bp5bH528AvcQ1MCMCS2ce4C7LCM%3D&reserved=0.

This would require non-trivial changes in codal and our Linux scheduler.

Closing old bug.


Mega-precision in aircraft strips..

Aircraft speed or altitude being displayed as floating point with 14 decimal places..

Covered in openscope/openscope#152. Should get some work on it very soon.

The ATC repository is being migrated to it's new home at https://github.com/openscope/openscope,
and thus, all issues are being closed. If this is still an issue with the latest version of the sim
(accessible at http://www.openscope.co), or is a feature you still think we are lacking,
please reopen the issue at the new repo.
Please note that the vast majority of these issues have been copied to the new repository, or else are covered by other issues created there. See the below screenshot for what it looks like when your issue is known in the new repo:

Thank you!
Closing this issue.


ENH: Adding a scale legend to plot_topo and other plotting functions

Describe the new feature or enhancement
Plotting functions like plot_topo could use a scale legend to visually describe the exact scale of subplots being represented by each subplot. Something like this :

The proposed scale legend showcases the X and Y scale used by each channel type in the initial plot and also the scale for each subplot on click. The parameter could also take an input to customize where the scale legend is located with inputs such as (Left and Right) or custom location parameters.
This would potentially be a multi PR approach with the initial focus specifically for plot_topo and its different forms such as plot_evoked_topo, plot_topo_image_epochs etc.
Describe your proposed implementation
One way of implementing this would be to add the Scale Legend as a separate subplot for each channel type with specifically mapped default locations. Since plot_topo currently only works with unified=True, this would be the easiest way to implement it. This does mean a new Scale_Legend class is created in the process.
Describe possible alternatives
Another potential method is to work with a custom class created from matplotlib.legend. This does bring a unique set of complications based on how it interacts with unified=True inside plot_topo and the subplots as well. Theoretically, this method would be easier to maintain, although since it's still a custom child class it wouldn't differ by much.
Thoughts? @larsoner @agramfort @jasmainak @drammock @rob-luke
References:

Example Image used above (Pg 35)

note that this is already done automatically for mne.viz.plot_compare_evokeds(evoked.pick('eeg'), axes='topo') (see bottom right corner of plot).  See if it is easy to use the same helper function for both plot_compare_evokeds and evoked.plot_topo (and if not, maybe refactor it so that it would be possible).

note that this is already done automatically for mne.viz.plot_compare_evokeds(evoked.pick('eeg'), axes='topo') (see bottom right corner of plot). See if it is easy to use the same helper function for both plot_compare_evokeds and evoked.plot_topo (and if not, maybe refactor it so that it would be possible).

Ahh, A little refactoring and extending the _draw_legend_pce to deal with 2 channel types instead of just one should be enough to add a scale legend to evoked.plot_topo

Time for PR :)

Great idea, thanks @ramkpari

FYI for now plot_compare_evokeds(..., axes="topo") can get you an axis in the lower right with a scale bar
https://mne.tools/dev/auto_tutorials/evoked/20_visualize_evoked.html#topographical-subplots


add python and rust pre-commit lint/formatting

Description
Use pre-commit hooks, to apply python lint/formatting and rust formatting automatically before making commits.
Only once, when cloning the repo / pulling these changes, it's needed to install pre-commit:
pip install pre-commit

and run:
pre-commit install

Related Issue
None.
Type of change
Not affecting the existing codebase.
How Has This Been Tested?
On some test commits.
Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings

Cool stuff! Question though, why are you supporting Flake and Black in the same time? Those lints doesn't work too well together.

Cool stuff! Question though, why are you supporting Flake and Black in the same time? Those lints doesn't work too well together.

I documented a bit and found things like this:

Does back replace flake8 ?
Not at all. Black only reformats, you still run flake8 to check for various issues not covered by black. Flake8 very close to be perfectly compatible with black.

And acrually that was right when I tested, black reformat the files, but doesn't check some issues that are only mentioned by flake8 (for example, using f strings with no placeholder ... ). The configuration that is used eliminates the contradicting rules and worked fine.


DBZ-1944 moving files that are used only in includes to partials

... so that Antora doesn't create a separate page for them that would be meaningless or confusing to users or search engines.

Applied to master; thanks a lot, @ahus1!
Now I'd like to apply the same change to older branches, too. But simply cherry-pick won't work, as there some differences and merge conflicts, subsequently. So I'm trying to figure out the steps for reproducing the same change on other branches.
One step would be to search and replace "include::../../modules" -> "include::{partialsdir}/modules". But I'm struggling with the relocation of included files; is there a simple pattern for that change? Thanks again!

@gunnarmorling - for the includes I did the following:

move all assemblies (except mysql as they are used in the navigation) to the partials folder
move all modules to the partials folder
replace include::../../modules and include::../../modules with include::{partials}/modules
replace include::../../assemblies and include::../assemblies with include::{partials}/assemblies

No include should remain starting with ".." except for the _attributes.adoc file.


RFC: Everything is a buildpack

Given the discussion at the last WG meeting, I'd like to present two options that integrate this RFC with #3. If we like one of these options, I'll modify this issue accordingly and convert it to a PR.
Option #1
Changes:

"orders" become buildpacks and are defined in a buildpack.toml, just like normal buildpacks
A buildpack is either a single buildpack implementation or an ordering of other buildpack IDs/versions (with no code present).
As orders are now buildpacks, they must have versions.
A single bulidpack.toml can contain any number of bulidpacks.
Apps can use an inline buildpack.toml to define any number of inline buildpacks or additional orderings (of inline or other buildpacks).
Buildpacks can share code/files if they share a buildpack.toml
default version symlinks are only created when the builder is created, and are not included in CNB packages
labels go away

buildpack.toml example for a single repo that provides a node buildpack, an npm buildpack, and an order definition:
[[buildpacks]]
id = "io.buildpacks.nodejs"
name = "Node.js Buildpack"
version = "0.0.9"
groups = [
   { id = "io.buildpacks.node", version = "0.0.5" },
   { id = "io.buildpacks.npm", version = "0.0.7" },
]

[[buildpacks]]
id = "io.buildpacks.npm"
name = "NPM Buildpack"
version = "0.0.7"
path = "./npm-cnb/"
[buildpacks.metadata]
...
[[buildpacks.metadata.dependencies]]
...

[[buildpacks]]
id = "io.buildpacks.node"
name = "Node Engine Buildpack"
version = "0.0.5"
path = "./node-cnb/"
[buildpacks.metadata]
...
[[buildpacks.metadata.dependencies]]
...

Layer format, where <sha256> = sha256(buildpack.tgz):
/cnb/blobs/<sha256>/
/cnb/by-id/io.buildpacks.nodejs/0.0.9 -> /cnb/blobs/<sha256>/
/cnb/by-id/io.buildpacks.npm/0.0.7 -> /cnb/blobs/<sha256>/
/cnb/by-id/io.buildpacks.node/0.0.5 -> /cnb/blobs/<sha256>/

Option #2
This is the same as option #1, but without allowing multiple buildpacks per buildpack.toml. This is cleaner, but doesn't let you define orders in the same place as buildpacks. This also means inline buildpacks lose the ability to define orders.
Changes:

"orders" become buildpacks and are defined in a buildpack.toml, just like normal buildpacks
A buildpack is either a single buildpack implementation or an ordering of other buildpack IDs/versions (with no code present).
As orders are now buildpacks, they must have versions.
Apps can use an inline buildpack.toml to make themselves buildpacks, but there's no mechanism for specifying orders of other buildpacks.
default version symlinks are only created when the builder is created, and are not included in CNB packages
labels go away

buildpack.toml examples for a node buildpack, an npm buildpack, and an order definition (all separate):
id = "io.buildpacks.nodejs"
name = "Node.js Buildpack"
version = "0.0.9"
groups = [
   { id = "io.buildpacks.node", version = "0.0.5" },
   { id = "io.buildpacks.npm", version = "0.0.7" },
]

id = "io.buildpacks.npm"
name = "NPM Buildpack"
version = "0.0.7"
path = "." # default
[metadata]
...
[[metadata.dependencies]]
...

id = "io.buildpacks.node"
name = "Node Engine Buildpack"
version = "0.0.5"
path = "." # default
[metadata]
...
[[metadata.dependencies]]
...

Layer format (three layers necessary):
/cnb/buildpacks/io.buildpacks.nodejs/0.0.9/

/cnb/buildpacks/io.buildpacks.npm/0.0.7/

/cnb/buildpacks/io.buildpacks.node/0.0.5/

The big advantage of making it one file is potentially simplifying the inline buildpack use case since people will already have a buildpack.toml. It seems like inline buildpacks deserve their own RFC.

Superseded by #10


Refactor project for Storybook and improved testing

Refactored project to:

Replace KSS style guide with StorybookJS
Replaced legacy Qunit/Karma-based tests with Jest
Configured Happo.io for cross-browser visual regression testing

My suggestion for reviewing this PR is to check it out locally on your machine, install the dependencies, and run the various Storybook and testing features. Get familiar with the new features and then how they are implemented in the project.


Use Docker's new "secrets" feature.

Docker has recently release support for uploading "secrets" into the Docker Swarm. These appear as files to the container and can be read and set as appropriate.
It should be pretty easy to use the current approach or use the secrets approach. A bit of re-work might be necessary, but it will likely just be testing and documentation changes.

The testbed demonstrates how to do the secrets for Docker. Leaving this code base as is since orchestration systems like Kubernetes does it differently and allows for direct linking instead of requiring secrets live in /run/secrets.