Doxygen not in path -> more explicit message?

Doxygen wasn’t in my path... I think we could make the error message more explicit
CMake Error at cmake/blt/cmake/SetupDocs.cmake:36 (add_dependencies):
  Cannot add target-level dependencies to non-existent target "doxygen_docs".

  The add_dependencies works for top-level logical targets created by the
  add_executable, add_library, or add_custom_target commands.  If you want to
  add file-level dependencies see the DEPENDS option of the add_custom_target
  and add_custom_command commands.
Call Stack (most recent call first):
  src/docs/doxygen/CMakeLists.txt:7 (blt_add_doxygen_target)

How about making find doxygen required?

https://github.com/LLNL/blt/blob/e5564c491cb9032e529768ffc1e7b2696659da92/cmake/thirdparty/SetupThirdParty.cmake#L72

Or testing DOXYGEN_FOUND when entering the blt_add_doxygen_target.

https://github.com/LLNL/blt/blob/e5564c491cb9032e529768ffc1e7b2696659da92/cmake/SetupDocs.cmake#L27
IMO, 1. is legitimate here. But I may be wrong...

common pattern is to guard any of your blt_add_doxygen_target() commands with DOXYGEN_FOUND in  your CMake -- it would be good to add a sanity check in blt_add_doxygen_target() as well that gives helpful advice.

I don't think we want to require doxygen, as not all users of BLT are using doxygen -- also folks want to be able to turn off docs

OK, I think I got it:

BLT allows to (de)activate doxygen with ENABLE_DOXYGEN which is set to ON by default.
The project has to ensure that doxygen is found and protect calls to blt_add_doxygen_target with DOXYGEN_FOUND.

However, if I do that, I will not be warned that I asked for doxygen documentation, and it was skipped because it is not in my PATH.
Also, BLT documentation says that:

blt_add_doxygen_target
A macro to create a named doxygen target for API documentation. Assumes there is a Doxyfile.in doxygen configuration file in the current directory. This macro is active when BLT is configured with a valid DOXYGEN_EXECUTABLE path.

However my macro was active even in DOXYGEN_EXECUTABLE was not available.
What about this alternate pattern:

In project, protect calls to blt_add_doxygen_target with ENABLE_DOXYGEN
In BLT, ensure that when blt_add_doxygen_target is called, DOXYGEN_FOUND is true.

If that sounds right it volunteer to make the changes in BLT and documentation.


Best practices for configuring max_outbound_frames

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: Best practices for configuring max_outbound_frames
Description:
We run envoy through istio service mesh. Recently, one of the service sidecars fails frequently on too many outbound frames error when streaming large files. By increasing the max_outbound_frames setting on that sidecar fixes that problem.
I’m wondering what is the best practices for configuring this value in service mesh? Shout I increase the value for the entire mesh? What about edge proxies?
[optional Relevant Links:]

Any extra documentation required to understand the issue.

cc @antoniovicente @yanavlasov

You can also set a max_concurrent_streams in http2 option. Running 100 streams in the same connection is pretty good vs a fixed value 1 on http1 :)

It is possible that the service that streams files does so in very small increments (i.e. 100 bytes at a time) and if the client is slow at reading it may cause the error you indicate.
The default value for max_outbound_frameswe have been picked based on experience to make it work well with the recommended edge setting. Your case may be different, if for instance your service likes to send small data frames (or chunks, depending on the protocol), and in this case you may want to increase this number. This limit is there to prevent resource based DoS attacks. If you find that your proxies run out of memory you may need to do more tuning, such as reducing window sizes and tuning the service to send larger frames.
The service mesh case it tricky, since if you  increase this limit just on sidecars that see errors now, you may end up pushing the problem to other sidecars. You can increase it gradually throughout the mesh until the problem goes away.

@yanavlasov the downstream client is an edge proxy which we have configured following the recommendations https://www.envoyproxy.io/docs/envoy/latest/configuration/best_practices/edge. It means the edge proxy has a smaller initial_stream_window_size: 65536. I think that’s part of the cause of this issue too.
I tested by increasing the edge proxy initial_stream_window_size to the default value 268435456, the problem went away too.

Sorry for not responding sooner. I assume that you have changed initial_stream_window_size in the edge proxy cluster settings, right?  Perhaps the edge proxy was the bottleneck, or you have a high latency between edge proxy and mesh and as such low stream window cause the available bandwidth the be underutilized.

@yanavlasov @alyssawilk Sorry for commenting on old issue.
For a streaming GRPC service, we are hitting a connection reset after 512 MB because of flow control. We set initial stream window size as 64 KiB and connection window size as 1MB. We see outbound flood metrics getting incremented whenever the connection is closed. The max outbound frames is set to default 10000 We can increase that limit but wondering where is this 512 MB limit coming from based current window sizes.
And are there any side affects of increasing the max outbound frames or any other config tweak can help.
Thank you
cc: @lizan

@alyssawilk @yanavlasov any thoughts?

@alyssawilk @yanavlasov gentle ping ^^. Could you please help with this?

Because Envoy does eager serialization in many cases, increasing max outbound frames slightly increases the possibility of adversaries to send malicious traffic flows clogging your Network::Connection with frames they will never read.  If you have legitimate tragic being affected I'd definitely increase the limit and just make sure you have overload manager configured to protect against OOMs.

Thank you so much @alyssawilk

Any insight on the 512 MB limit?

Not offhand - I assume it's how much data it takes to hit the required number of frames but AFIK it depends on payload and isn't fixed.  If changing the frame limit doesn't help we can try to look into it.

If changing the frame limit doesn't help we can try to look into it.

It certainly helped. We have increased the max_outbound_frames things are working fine. Thank you.


fix: Added task selection for the EU benchmark

Added task for the EU benchmark for MMTEB.

The approach is outlines in the notebook, but mainly follows the approach:

select EU tasks
remove irrelevant tasks (no license, low quality, code, african etc.)
Apply iterative task selection removing the most predictable task (under some conditions, see notebook)
Based on the selected task refine the filtering until satisfied

This still needs some review, but generally I think it is close to being finalized. Let me know what you think, I would especially like your opinion on the datasets for languages that you speak.
Note: many of the changes are updates to metadata. This is simply to determine the quality of some of the datasets.

Also, I don't know if this was a conscious decision but we're missing Romani in the language list. I would personally like to see it, since it's spoken by a large enough minority in Europe.

Also, I don't know if this was a conscious decision but we're missing Romani in the language list. I would personally like to see it, since it's spoken by a large enough minority in Europe.

Def. an oversight. Will add it tomorrow

if you want me to run any of the datasets under # was added after models were run, lmk

let us wait until we have the downsampled retrieval datasets as well from @vaibhavad and @orionw, then we can run the all in one go.

I will set this PR to merge. I will message @imenelydiaker if she can take a look and if any additional concerns are raised then we will naturally redo it it again


Improve performance when applying filter over a large dataset

Description
When trying to apply a quick filter through the filter text field, each change in the input value will cause a render of the Grading component, since the change will update the filterValue field in the state.
Since all calls to gridApi.setQuickFilter are from the input field itself, there is actually no need to keep filterValue in the component state, and the filter text can be passed from event.target.value directly.
This improves performance greatly, especially when the set of grading data is very large (often the case for lecturers).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 34.413%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/academy/grading/Grading.tsx
0
6
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.006%

Covered Lines:
4526

Relevant Lines:
12230

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 6 (0.0%)  changed or added relevant lines in 1 file are covered.
10 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.005%) to 34.413%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/academy/grading/Grading.tsx
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/pages/academy/grading/Grading.tsx
10
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
4526

Relevant Lines:
12230

💛  - Coveralls


Search for a Consultant sometimes hangs

WIN10 laptop, Chrome.
This has occurred a handful of times for me. Never on an initial search, but randomly when I repeat searching for a consultant 3 or 4 times.
Here is the screenshot. I've left it for several minutes and it remains. If I refresh the page, I return to my prior page with the same consultant.

Created a ticket for this issue: TST-240

Seems to be fixed, can't duplicate now..


Add link to security and privacy questionnaire in security and privacy warnings

Hrm, apparently I didn't base that branch in the right place, the PR is only for the last commit

Heh, yeah. I'll cherry pick it tomorrow if you don't rebase yourself before then.


[FEATURE] Move Sort By to Filters on mobile

Description
With the new design, sort by has been removed from the navbar on mobile. It should be implemented on Filters on mobile view inside SfAccordion which is related to #657

Acceptance criteria

[ ] Sort by is moved to Filters on mobile

duplicated by #398


slow getTables

it's this query, that's slow
SELECT ist.*
FROM INFORMATION_SCHEMA.TABLES as ist
    INNER JOIN sysobjects AS so ON ist.TABLE_NAME = so.name
WHERE (so.xtype='U' OR so.xtype='V') AND so.name NOT IN ('sysconstraints', 'syssegments')
ORDER BY TABLE_SCHEMA, TABLE_NAME;

(in my testcase > 20s)
SELECT * FROM information_schema.TABLES;

takes 4 seconds
and
SELECT * FROM sysobjects;

as well 4 seconds.
This query
SELECT *
FROM INFORMATION_SCHEMA.TABLES as ist
INNER JOIN sysobjects AS so ON ist.TABLE_NAME = so.name;

takes 4 seconds too, so the filtering can be done in PHP.

is it the ordering or the filtering which slows it down?

without ordering: 11s

So I think removing the ordering is the best option.
Cheers guys.

So then we'll be able to decrease timeout limits back to 30s? :-)

https://keboola.zendesk.com/agent/tickets/8129


Problem with rx.setFrequency();

Hi and thank you for you useful library. I've recently installed your library and I want to use it with a SI4703 board connected to an ESP32. But when I use rx.setFrequency(), the program freezes. After an accurate control, I've found that the programs run infinitely on the first while contained in the waitAndFinishTune() void.
the hardware connections are OK, and if I run checkI2C(), the hardware is correctly found at 0X10 (I2C device found at address 0x10
done).
If I ask for the partnumber and other informations, all is correctly showed, but the firmware value is 0 (device not powered up?)
can you help me to found the problem ??
Thank you.

@Scugnizzo , @pu2clr
I have run into the exact same issue using esp32-s3.  I was wondering if this had been worked?  As far as I can tell, it is exactly the same place waitAndFinishTune()- in this line of code:
do
    {
        getStatus();
    } while (reg0a->refined.STC == 0);

The code is executing getStatus(); but it seems  reg0a->refined.STC == 0 condition is the problem.
@Scugnizzo can you confirm some more information about your configuration?  For instance...I am running with the following:

External Reference Clock - no crystal
On Si4703 GPIO2 - not connected
On Si4703 GPIO1 and GPIO3 = +3.3v (High)

One of the other things that is giving me fits is my reference clock is coming off the 32kHz pin of a DS3231 real-time clock chip which is also on I2C.  I am wondering how how important the order of initiating the I2C devices is.  For example, right now my setup looks like this:
   rx.setup(RESET_PIN, ESP32_I2C_SDA,OSCILLATOR_TYPE_REFCLK);     rtcDS3231.begin();     rx.setVolume(6);     delay(500);     // Select a station with RDS service in your place     Serial.println("\nThe River 100.3MHz");     rx.setFrequency(10030);
and it freezes as mentioned above.
Let me know if I can assist in any way.
Appreciate any help!
Fish

I did some more digging.  There is a post here which suggests other people experience this as well with this library:
https://forum.arduino.cc/t/esp32-si4703-fm-module-not-responding/1184277
Their solution was to use a different library - but I would like to see if we could resolve this.  Ricardo put a lot of work into these libraries and I'd like to stick with this one if we can make it work.  I am just not very experienced enough a coder to know where to go from here.

@pu2clr @Scugnizzo
o.k.  I downloaded pu2clr library for the RDA5807.  It works well on esp32-s3.  In fact, I am listening with headphones and don't need an amplifier!  I would want to turn the volume down a bit since at vol=0 it is comfortable.  Also seek doesn't work but frequency up and down do - im sure I can figure those out.
The point is, I can rule out my antenna, reference clock input, etc.  It is definitely something with the esp32-s3 and the various libraries.
Fish.

Same issue here, with an ESP32-D0WD (lolin32 lite board)
Tested with various libraries, always stuck in the same place.
I have been looking in the code, datasheet an AN... but still no clue of the source of the bug.
Sadly I do not have any "known working" board to try to compare.
PN........................:1
Manufacturer..............:1
CHIP Version..............:4
Device....................:1000
Firmware..................:0
Estacao 88.4MHz

OK, I found the issue in my case : I was using the 3V supply from my esp32 devboard to power the SI4703 module.
It is not powerfull enough, at some point the si4703 start drawing too much current and the 3V supply drop to ~1V.
Solution : I used and external 3.3V power supply and everything is good now.
Hope this help !

Not for me! I already use an external 3.3 V power supply.....Il 14 giu 2024 15:37, Mathieu Cassard @.***> ha scritto:
OK, I found the issue in my case : I was using the 3V supply from my esp32 devboard to power the SI4703 module.
It is not powerfull enough, at some point the si4703 start drawing too much current and the 3V supply drop to ~1V.
Solution : I used and external 3.3V power supply and everything is good now.
Hope this help !
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


installation error

Collecting av==10.* (from faster-whisper<1.0.0,>=0.10.1->speechlib)
Using cached av-10.0.0.tar.gz (2.4 MB)
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [74 lines of output]
Compiling av\buffer.pyx because it changed.
[1/1] Cythonizing av\buffer.pyx
Compiling av\bytesource.pyx because it changed.
[1/1] Cythonizing av\bytesource.pyx
Compiling av\descriptor.pyx because it changed.
[1/1] Cythonizing av\descriptor.pyx
Compiling av\dictionary.pyx because it changed.
[1/1] Cythonizing av\dictionary.pyx
Compiling av\enum.pyx because it changed.
[1/1] Cythonizing av\enum.pyx
Compiling av\error.pyx because it changed.
[1/1] Cythonizing av\error.pyx
Compiling av\format.pyx because it changed.
[1/1] Cythonizing av\format.pyx
Compiling av\frame.pyx because it changed.
[1/1] Cythonizing av\frame.pyx
performance hint: av\logging.pyx:232:5: Exception check on 'log_callback' will always require the GIL to be acquired.
Possible solutions:
1. Declare 'log_callback' as 'noexcept' if you control the definition and you're sure you don't want the function to raise exceptions.
2. Use an 'int' return type on 'log_callback' to allow an error code to be returned.
Error compiling Cython file:
------------------------------------------------------------
...
cdef const char *log_context_name(void *ptr) nogil:
cdef log_context obj = <log_context>ptr
return obj.name
cdef lib.AVClass log_class
log_class.item_name = log_context_name
^
------------------------------------------------------------
av\logging.pyx:216:22: Cannot assign type 'const char *(void *) except? NULL nogil' to 'const char ()(void *) noexcept nogil'. Exception values are incompatible. Suggest adding 'noexcept' to the type of 'log_context_name'.
Error compiling Cython file:
------------------------------------------------------------
...
# Start the magic!
# We allow the user to fully disable the logging system as it will not play
# nicely with subinterpreters due to FFmpeg-created threads.
if os.environ.get('PYAV_LOGGING') != 'off':
lib.av_log_set_callback(log_callback)
^
------------------------------------------------------------
av\logging.pyx:351:28: Cannot assign type 'void (void *, int, const char , va_list) except * nogil' to 'av_log_callback' (alias of 'void ()(void *, int, const char *, va_list) noexcept nogil'). Exception values are incompatible. Suggest adding 'noexcept' to the type of 'log_callback'.

Solved, install python version 3.11


Updated setup instructions to fork the repo instead of directly creating a clone

Updates needed to play well with the MLOps section where we'll need to create our own GitHub Actions in our own repo.

@luisquintanilla this is ready for your review


[SR-1179] Compiler bug: initialising subclass skips to super when using Whole Module optimisation

Previous ID
SR-1179

Radar
None

Original Reporter
timwindsorbrown (JIRA User)

Type
Bug

Environment
Whole Module optimisation

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug, Miscompile, OptimizedOnly

Assignee
None

Priority
Medium

md5: c2c39cc40e2d6cf403c4fc4ca19d6ecc

relates to:

SR-1117 Overridden function is not being called when sublassing generic class in Release Build with Whole Module Optimization

Issue Description:
When running with Whole Module Optimisation, a subclassed object is initialized as it's parent. I've only seen it happen once, but I created a project to demonstrate it.
https://github.com/TimMumsnet/TestChatApp.git
If you run the project on release configuration, a crash will occur because of the bug.

Closing because the issue is very old and the reproduction is no longer accessible.


Installer CLI Argument to Upload Templates to S3 [WIP]

Depends
Relies on #442
Associated Tickets
Satisfies https://mesosphere.atlassian.net/browse/DCOS-9268
Overview
This uses a config.yaml with a few new keys:
---
  cloudformation_s3_url: https://s3-us-west-2.amazonaws.com/jeremy-testing/dcos
  cloudformation_s3_bucket: jeremy
  cloudformation_s3_key: dcos
  cloudformation_s3_region: us-west-2
  zk_super_credentials: super:jeremysecret
  zk_master_credentials: dcos-master:jeremysecret1
  zk_agent_credentials: dcos-agent:jeremysecret2
  # disabled|permissive|strict
  security: permissive

cloudformation_s3_bucket
cloudformation_s3_key
cloudformation_s3_region

TODO

[ ] Add unit tests
[ ] Add integration tests

@lingmann This is ready for an initial pass by you.

This needs to be reworked. The goal is that when you're generating cloudformation templates, as part of that I can say "target this path in this s3 bucket" and we'll do that. Don't want a separate independent upload path.
This needs to be rebased on master (right now it has a ton of random commits in it doing all sorts of other random things).
If just sharing between two people, just pushing to a second repo is enough that someone else can get / look at it.

The goal is that when you're generating cloudformation templates, as part of that I can say "target this path in this s3 bucket" and we'll do that.

I hear you saying that --aws-cloudformation utility should also do an upload to S3 in the same CLI argument? Is that correct?

his needs to be rebased on master

As pointed out in my PR description, this is based on #442, and requires it as a dependency. It's here for @lingmann to review, per our design meeting yesterday.

Yes, in addition to --aws-cloudformation, when that option is given a person should be able to give the s3 bucket + path in that bucket where the templates should end up. --s3-bucket-path=foo/bar/baz.
That should implicitly cause things like the cloudformation s3 url to be set correctly.

The only issue I see with that functionality is where someone may want to host their templates somewhere other than S3. In that case, making two separate action arguments makes sense.
In line with your suggestion, we could upload only if --s3-bucket-path is set, however, I have those settings in the config.yaml, so we could just upload automatically if the s3 parameters are present.

@lingmann Can you weigh in on this functionality?

@malnick AWS CloudFormation does not allow launching templates which are stored in anything other than an s3 bucket.

That's not true, you can have the templates locally and launch them with the AWS CLI.

In which case you wouldn't be using the upload to s3 argument...

Our advanced templates also cannot be launched from the AWS CLI like that, because they reference eachother

Right, so back to my original suggestion: I have 3 new S3 parameters in the config.yaml to handle uploading to a specific bucket/key in a given region. If those are set, we automatically upload, if they are not, we generate and stop. This is similar to what you had with the CLI flag, and allows us to put complete action configuration in one place, though I could fall on either side of that configuration argument (flag vs. config).

your code here currently adds an argument to upload them: https://github.com/dcos/dcos/pull/527/commits/536e857c1190fe15e79ca1dfa8f26582c60a86b1
That is what I was reviewing code wise.... If that's not at all what is going to be implemented ...

Ok, so I realize now what your initial argument is: what and when to call the CLI flag that uploads to S3.
I agree, we should use a boolean flag with the CF generation flag. I do not agree that we should configure how that upload flag operates using flags, since we require three different S3 parameters, we can simply keep the keys I've added for S3 uploads in the config.yaml.
Does that sound sane to you?

Example:
--aws-cloudformation -> generates templates
--aws-cloudformation --upload-s3 -> generates templates, uploads to S3 if S3 config is present.

Putting the code for this into https://github.com/dcos/dcos/pull/442


Technical deep-dive: Retrofitting "backpressure" in yamux

tl;dr: Write a technical blogpost on how we configure yamux to retroactively fit "backpressure" on new streams.
Why
I know that the focus is on rolling out QUIC but all of Ethereum for example still runs on yamux and lighthouse is afaik the client with the largest deployment share. From that perspective, I don't see yamux going away in the next 2 years. Pretty much any production deployment of rust-libp2p still runs on yamux today.
Backwards-compatibility is a super interesting topic and I'd assume that most experienced engineers will appreciate the complexity involved in retrofitting a feature without breaking existing clients.
What
In a nutshell, https://github.com/libp2p/specs/pull/547 is adjusting the spec to what we ended up doing. I think there are at least two interesting things to write about here:

A description of the actual solution: Definition of an ACK backlog on the "opening" end and a buffer of the same size on the receiving end.
How we implemented it in rust-libp2p: Poll-based functions that suspend once we hit the ack backlog and wake up the corresponding task as soon as we can open more streams. This integrates seamlessly into Rust's async/await architecture: A task trying to open a new stream will not only suspend until the underlying IO socket is ready but also until the remote is ready to accept a stream (i.e. our ACK backlog is < 256).

I'd expect the Rust part of this blogpost to be the more interesting bit but the overall solution is IMO still interesting for the wider libp2p community.
Any vetos on posting this on the libp2p blog?

Same objections as on https://github.com/libp2p/specs/pull/547 apply here. I'd prefer to keep the discussion on the specs issue. That said, given the hacky nature of the "backpressure" in yamux, I don't think this is a very interesting topic for a blog post to begin with.

Same objections as on https://github.com/libp2p/specs/pull/547 apply here. I'd prefer to keep the discussion on the specs issue.

Sure! I am currently waiting for a reply there :)

That said, given the hacky nature of the "backpressure" in yamux, I don't think this is a very interesting topic for a blog post to begin with.

It is not ideal, sure but given the constraints (backwards-compatibility), I think the outcome is quite nice.
Let's debate this once we have the specs issue resolved.

I think "retrofitting backpressure" is a difficult challenge worth talking about. That said, I think our time is better spent on e.g. getting https://github.com/libp2p/rust-libp2p/pull/3454 merged or writing about rust-libp2p's WASM capabilities (https://github.com/libp2p/rust-libp2p/pull/4015).
I am afraid our human resources are a zero-sum-game, i.e. the time we spent on this blog post we won't spend on higher impact items.

Closing as not desired.


Two bug fixes to HA guide for kubeadm:

Two bug fixes to HA guide for kubeadm:

In the provided configuration file for kubeadm init the value for apiserver-count needs to be put in quotes.
In addition to /etc/kubernetes/pki/ca.* also /etc/kubernetes/pki/sa.* need to be copied to the additional masters. See this comment by @petergardfjall for details.

This PR obsoletes "Certs" #7425 in which I had accidentally included the commits from another PR "HA guide for kubeadm" #7410.

This change is

Thank you @mattkelly for noticing!

/assign @jamiehannaford

/approve

/lgtm

I cannot confirm this. My ansible-based installer copies /etc/kubernetes/pki/[sc]a.* and this works just fine.

@mbert thanks for your reply. Just want to report it to you as I met the problem yesterday.
I'll try to reproduce the experiment later(might be next week) to confirm it.

Hallo allemaal
Ik heb een vraag over dit onderwerp
Blijkbaar is dit onderwerp mijn schuld maar ik moet zeggen dat ik geen idee
heb dat er aan de hand is alleszins sorry kan ik iets doen ik heb nog ma
2dagen terug internet kun je me wijzer maken
Sorry voor iedereen
Grtz
Op di 3 apr. 2018 10:23 schreef pc<EMAIL_ADDRESS>
Just copy ca.* and sa.* might not enough for a healthy HA cluster(which
kube-dns is available), at least in my environment.
kubectl -n kube-system logs --tail=100 kube-apiserver-master-101
(omitted)
I0402 08:20:49.869570       1 logs.go:41] http: TLS handshake error from <IP_ADDRESS>:52040: remote error: tls: bad certificate
I0402 08:20:49.875724       1 logs.go:41] http: TLS handshake error from <IP_ADDRESS>:52042: remote error: tls: bad certificate
I0402 08:20:49.882795       1 logs.go:41] http: TLS handshake error from <IP_ADDRESS>:52044: remote error: tls: bad certificate
I0402 08:20:49.888439       1 logs.go:41] http: TLS handshake error from <IP_ADDRESS>:52046: remote error: tls: bad certificate
[root@cloud07-pengchao-dev-02 pki]# kubectl get ds,deploy,svc,pods --all-namespaces
NAMESPACE     NAME            DESIRED   CURRENT   READY     UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
kube-system   ds/kube-proxy   3         3         3         3            3                     3h
NAMESPACE     NAME              DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
kube-system   deploy/kube-dns   1         1         1            0           3h
NAMESPACE     NAME             TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)         AGE
default       svc/kubernetes   ClusterIP   <IP_ADDRESS>            443/TCP         3h
kube-system   svc/kube-dns     ClusterIP   <IP_ADDRESS>           53/UDP,53/TCP   3h
NAMESPACE     NAME                                              READY     STATUS             RESTARTS   AGE
kube-system   po/kube-apiserver-master-101            1/1       Running            0          3h
kube-system   po/kube-apiserver-master-102            1/1       Running            0          3h
kube-system   po/kube-apiserver-master-103            1/1       Running            0          3h
kube-system   po/kube-controller-manager-master-101   1/1       Running            0          3h
kube-system   po/kube-controller-manager-master-102   1/1       Running            0          3h
kube-system   po/kube-controller-manager-master-103   1/1       Running            0          3h
kube-system   po/kube-dns-6f4fd4bdf-cq57q             1/3       CrashLoopBackOff   138        3h
kube-system   po/kube-proxy-chtd8                     1/1       Running            0          3h
kube-system   po/kube-proxy-fnx7h                     1/1       Running            0          3h
kube-system   po/kube-proxy-pjsx5                     1/1       Running            0          3h
kube-system   po/kube-scheduler-master-101            1/1       Running            0          3h
kube-system   po/kube-scheduler-master-102            1/1       Running            0          3h
kube-system   po/kube-scheduler-master-103            1/1       Running            0          3h
When I followed Option 1: Copy with scp later(see #7949
https://github.com/kubernetes/website/pull/7949), everything is ok.
In my opinion, all the certs need to reuse the first master's except
apiserver.*, which could recreate by kubeadm then.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/pull/7451#issuecomment-378169226,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab4yoW_Rijfg_GHUfCW_eSY-v5quEzoiks5tkzGFgaJpZM4SKsb9
.


Code lens corruption

Issue Type: Bug
While heavily editing a file, I keep getting code lenses in many wrong place and overlapping. Even closing and re-opening the file doesn't seem to help.

/cc @jrieken
VS Code version: Code - Insiders 1.41.0-insider (3b17b7943842e84912a5507111a6cd790db18a46, 2019-11-18T16:15:22.989Z)
OS version: Windows_NT x64 10.0.19025

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.93GB (16.01GB free)

Process Argv

Screen Reader
no

VM
0%

Hm, likely due to the perf optimisations and the fact that code lens widgets are created lazy...


Update README.md License Section

Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Steps to Reproduce

Open README
Go to License Section

Expected Behavior
React is now MIT licensed.
Actual Behavior
README says BSD licensed.

The README should have said React Native (still BSD) instead of React. Anyone want to send a PR to make that change at the bottom?

PR Landed. Thanks!


Update docker-compose.yml

The changes include adding comments for clarity, referencing the PALICO_SERVICE_KEY from a .env file for security, adjusting the port specification format, and refining the overall formatting for better organization.

LGTM, thanks!


[Remote Routing Table] Create Service for remote routing table storage

Is your feature request related to a problem? Please describe
Create a RemoteClusterStateService which would orchestrate the upload to blob storage. This service would be similar to RemoteClusterStateService
Related component
ShardManagement:Routing

[Triage - attendees 1 2 3 4 5 6 7 8]
@himshikha Thanks for creating this issue; however, it isn't being accepted due to not having enough detail on why the change should be made nor the impact when it is resolved. Please feel free to open a new issue after addressing the reason.


[FLINK-32112][docs] Fix the deprecated state backend sample config in Chinese document

What is the purpose of the change
This PR Fix the deprecated state backend sample config in Chinese document
Brief change log
update state backend sample config in Chinese document
before  -> state.backend: filesystem
after     -> state.backend: hashmap
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Hi @WencongLiu . Hi @reswqa  . I created a new PR to merge this commit to branch 1.17-release. Please review it. Thanks .


Is it possible to add dropdowns to resources

What i meant is, is it possible to add a dropdown like this into the resource view.

Any ETA on this as a new feature? Awesome work, Stephen 💃

@Bosseskompis
Sorry, not yet.


Translation / Language Support and abapGit Questions

Hi,
Firstly, let me say what an awesome project this is!
I have been playing around with abapGit and abapGitServer to determine if we will be able to use it as part of our development and delivery process.
I do have a few questions though:

Does abapGit support multiple languages ? For example a Data Element that is translated into other languages, would abapGit pick up translation changes?

Is it possible to pull specific commits on the master branch? For Example,  I have committed C1 -> C2 -> C3 on the master branch  from a DEV system. A consumer(User system) has previously pulled C1, Now the consumer system want to update the solution, but only wants to update to C2, not the latest commit C3.

I mainly use the Java GUI and ADT on MacOs, and have run into a few issues that are already logged as issues. Does abapGit support the Java GUI, or are you mainly focusing on the WIN GUI at this stage?

I suspect there will be quite a few object types in our solutions that is not currently supported by abapGit, if I am able to add the unsupported objects, how would I create a pull request via abapGit?

Thanks in advance.

1: yes
2: yes, tag your commits, eg one tag for each released version
3: there are problems on the Java GUI, see open issues, we will probably move towards supporting ADT instead of Java GUI, but there is a long way to go
4: it is via the Github flow, fork abapGit, install the fork in your SAP system, do the changes, push to the fork, open pull request. Make sure there is open issues for the tasks you are working on 😄

Thanks larshp!
Much appreciated.

Thanks Lars, yes I have had a look at abapGit-Plugins, and I have read the readme.
Will the objects supported by abapGit-Plugins be migrated to form part of abapGit object support in the future?


Possible fix for Terraform v0.11(output to non-existing resource)

With v0.11 Terraform now checks outputs for errors so as not to propagate them through modules etc and help in debugging. This seems to fix the error when using only HTTP or HTTPS listener.
More here (near the bottom):
https://www.terraform.io/upgrade-guides/0-11.html

LGTM, thanks @mbolek


calico-node logs spammed with "bird: KIF: Ignore kube-ipvs0 that is not UP"

Expected Behavior

calico-node pods logs are not spammed with useless messages.

Look at any of the calico-node pods logs.

Context

Massively spamming logs with useless messages is bad for obvious reasons.
Your Environment

Calico version: 3.27.0 (docker.io/calico/node:v3.27.0 image)
Orchestrator version (e.g. kubernetes, mesos, rkt): kubernetes 1.28.5
Operating System and version: Ubuntu 22.04.3 LTS, kernel version 6.2.0-39-generic
Link to your project (optional): N/A

Looking at the bird configuration file /etc/calico/confd/config/bird.cfg inside a calico-node pod, it looks like the kube-ipvs0 interface should be ignored, specifically mentioning kube-proxy in ipvs mode
# cat /etc/calico/confd/config/bird.cfg
[...]
protocol direct {
  debug { states };
  interface -"cali*", -"kube-ipvs*", "*"; # Exclude cali* and kube-ipvs* but
                                          # include everything else.  In
                                          # IPVS-mode, kube-proxy creates a
                                          # kube-ipvs0 interface. We exclude
                                          # kube-ipvs0 because this interface
                                          # gets an address for every in use
                                          # cluster IP. We use static routes
                                          # for when we legitimately want to
                                          # export cluster IPs.
}
[...]

so it's quite weird that bird still complains about that interface.

same problem...

Upgraded to v3.27 today with these steps from the docs having the same issue: https://docs.tigera.io/calico/latest/operations/upgrading/kubernetes-upgrade#upgrading-an-installation-that-uses-the-operator

I can take a look at this, @caseydavenport can you please point me to the exact source code bird is compiled from? I see there's a bird mirror at https://github.com/projectcalico/bird/, and judging by the version in the calico-node:v3.27.0 image (BIRD version v0.3.3+birdv1.6.8), I would guess it's https://github.com/projectcalico/bird/tree/v0.3.3 ? Although that branch looks 5 years old, so I'm not sure.

@lbogdan thanks!
The BIRD_IMAGE is overridden by the build process using the version taken from metadata.mk here: https://github.com/projectcalico/calico/blob/master/metadata.mk#L28-L29
I think we stopped cutting formal releases of our BIRD fork and instead pin to commit builds instead.

Thanks a lot!
Found the commit that introduced this: https://github.com/projectcalico/bird/commit/3d15998f2410ff7043dbaa96879e2d9a11b1c3dc .

@caseydavenport Any reason bird is ran with -d (debug) here https://github.com/projectcalico/calico/blob/a684f90bec0bc99ccade9424d2312ac641ffd3dd/node/filesystem/etc/service/available/bird/run#L3 ?

Ok, so I managed to hack around it by replacing that -d with -f (runit expects bird to run in the foreground) in /etc/service/available/bird/run in the calico-node image.
Just FYI, I also published a "fixed" image at docker.io/lbogdan:calico-node:3.27.0-0 built from the following Dockerfile:
FROM calico/node:v3.27.0

RUN sed -i s/-d/-f/ /etc/service/available/bird/run

[!CAUTION]
People annoyed by this that want to fix it until a new Calico release should probably NOT use this image (especially in production), but build their own.

@caseydavenport Would the above be a suitable approach? If so, I could open a PR.

@lbogdan great sleuthing! Agree with your assesment. From what I can tell, the other instances of ignored interfaces do so silent without any DEBUG level logging, so we probably just want to remove the log line from the BIRD code itself and keep the -d flag - WDYT?

It would be nice if bird's log level was configurable, but I guess that'd be a bit more involved.
Which branch should one use to create a projectcalico/bird PR? I see the default branch there is feature-ipinip.

It would be nice if bird's log level was configurable (and set to INFO by default), but I guess that'd be a bit more involved.

Yeah I agree. If that's something you'd be interested in taking on I'm all for it, though I'd be happy with simply removing the log for now since as you say it's more involved.
feature-ipinip is the correct branch :+1:

@caseydavenport This should be reopened until bird version is updated in calico/metadata.mk.

@lbogdan Thanks for the work you're already doing on this!  Regarding the question of the BIRD logging level being configurable...  I could be wrong, or the existing implementation might not be working as intended, but I believe that the BIRD logging level already should be configurable.  My understanding is that it works as follows.

The -d option, when we run BIRD, only enables the possibility of debug-level messages.  It doesn't necessarily mean that debug-level messages will be emitted.

There's a logSeverityScreen field in the BGPConfiguration resource which controls both the logging from confd (our component that generates and maintains the BIRD config) and the logging from BIRD itself.  When logSeverityScreen is debug, the BIRD config includes debug all;.  When logSeverityScreen is info, the BIRD config includes debug { states };.  For other logSeverityScreen values there is no debug ... directive in the BIRD config.

If my reasoning is correct, it implies that you must have had logSeverityScreen: Debug in order to see those kube-ipvs0 messages.  Was that the case?

Was that the case?

@nelljerram No, from my experimentation, the existence (or not) of the debug statements in the bird configuration file didn't have any effect in regard to this specific debug message. I get the log messages from a default calico install from https://raw.githubusercontent.com/projectcalico/calico/v3.27.0/manifests/calico.yaml.
Looking at the code, it indeed looks like it's not influenced by any configuration settings.

Interesting, thanks.  It seems we have misunderstood what our existing mechanism does.  I don't think it's a high priority, given that you've already fixed the most important spam case, but if you feel like digging into this further that would be welcome.

From bird's documentation, it looks like the log statement can be used to control this, from the configuration file:

log "filename" [limit "backup"] | syslog [name name] | stderr all|{ list of classes }
Set logging of messages having the given class (either all or { error|trace [, ...] } etc.) into selected destination - a file specified as a filename string (with optional log rotation information), syslog (with optional name argument), or the stderr output.
Classes are: info, warning, error and fatal for messages about local problems, debug for debugging messages, trace when you want to know what happens in the network, remote for messages about misbehavior of remote machines, auth about authentication failures, bug for internal BIRD bugs.
Logging directly to file supports basic log rotation -- there is an optional log file limit and a backup filename, when log file reaches the limit, the current log file is renamed to the backup filename and a new log file is created.
You may specify more than one log line to establish logging to multiple destinations. Default: log everything to the system log, or to the debug output if debugging is enabled by -d/-D command-line option.


732 rems admin UI

Describe your changes
Added react application for rems admin ui. Start the UI from the /frontend folder with npm run dev (I still have to update docker stuff to start it when running docker and update the hard coded URLs to use env variables).
Test the following functionality -

Added Login with keycloak, once logged in you can view the data. On page refresh or logout button will go back to login page. ( https://jira.mitre.org/browse/REMS-734)
3 tabs with each of the data in the DB, there is a reset DB button which opens up dialog to double check user wants to reset full database. (REMS-732)
Clear single items. For rems case colleciton it will also clear out any patient questionnaire with that rems case. If there is a prescriber form it will remove the case number from the case we're deleting from that form. (https://jira.mitre.org/browse/REMS-733)
Added backend support for getting and deleting data.

Issue ticket number and Jira link
https://jira.mitre.org/browse/REMS-734 https://jira.mitre.org/browse/REMS-732 https://jira.mitre.org/browse/REMS-733
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

[ ] Review the code changes and make sure they all make sense and are necessary.
[ ] Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

This UI looks and functions great. It would be nice to have a different banner color from the other apps though.

It would also be nice to have the status just show a met requirements column only show the status like the ETASU status buttons and would then have a popup that shows the full etasu status when clicked on. This is likely too much work for this set of issues, we should write a new ticket for this change.

The login page has an extra ';' underneath the sign in button. See the attached image.

There should be some info on starting the frontend in the README as well

Can you also make it so the frontend runs with the same command as all the others, 'nom start' ?


Remove onMounted hook at NuxtStar.vue

Hello, Aurion!👋 Thank you a lot for you're helpful npm package!
Is it possible to instead:
onMounted(() => {
    grad.value = getRandomId()
    isReady.value = true
})

do this:
    grad.value = getRandomId()
    isReady.value = true

remove the onMounted hook
move this piece of code before the closing script tag (or just after getRandomId function).

🟩 Why it's important: if the onMounted hook is present - there is a delay of about 2 seconds before the stars are displayed.
That is, the main content of my page is loaded, and only after 2 seconds the append component with stars happens.
🕹I tested the work after 1. removing onMounted, and 2. moving a piece of code before the closing script tag - ✅everything works correctly.
I would be very happy if it could be realized!

Hello,
This system was useful because it prevented the stars from ‘flashing’. The stars would appear at a rating of 0 before getting their real rating after a few seconds.
That's why I implemented this solution with onMounted() on first case.
I've reworked this part and added a skeleton system to hide the loading of stars while displaying a placeholder. I've added a property that lets you change the colour of the skeleton.
Its available in the last version v0.1.5
I hope you like it

Hello Aurion 👋, thank you for adding skeleton for star.
I reinstall the package, and skeletom looking good! 😊🔥
Also - thank you for your explanation of the reason for adding onMounted.


Changes for Linux script

d43a1c1: Functional change, to look for existing CSS in the correct place.
587a445: Cosmetic change, since I think the excess whitespace makes it hard to read the various messages.
7b1247f: Cosmetic change, standardising capitalisation and punctuation.

Also, I suspect some of this might apply to the Mac version of the script, but I don't have a Mac to test it on.

Thanks! Appreciate the help with that. I don't have Linux to test on, so I was kinda guessing at the output (echo and echo -e act a little differently I think).
1st and 3rd commits definitely apply to Mac though, so I'll get those fixed.

No problem! Thanks for your work on this project.


Feature suggestion: Log the x-github-request-id

Would be nice if there was someway of logging the x-github-request-id header.
It would be helpful to have this in cases where the attempt to get a token from app/installations/<installation_id>/access_tokens fails with a "Network Error" where it fails to reach api.github.com for some reason versus any case when GitHub.com is responding with an error.

The x-github-request-id header is set on responses. If we cannot reach api.github.com, we do not have the x-github-request-id response header, or am I missing something?

There are 3 cases:

Client requests access token and receives it. In this case the x-github-request-id can be logged.
Client requests access token and receive an error from GitHub. In this case the x-github-request-id can be logged and is super useful for zooming in on logs.
Client makes a request (possibly through some maze of proxies) and receives no response whatsoever. This makes it easier to point at the network as the place to begin troubleshooting.

For case 2., in case of a request error, it should log the full request + response (with credentials redacted), it's the standard @octokit behavior. Do you have an example build where actions/create-github-app-token failed? It would be helpful to see logs
For case 1., we can add that if it's helpful, pull request welcome
For 3., a similar error should be logged as in 2., only lacking a response property


Fix env variables issues

Description
As title, assing a missing env variable to Azure
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?
N/A
Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

master

PR #65

PR #67   👈

This stack of pull requests is managed by Graphite.


chore: Update send-metrics.mdx

folloiwng -> following
Description
chore: There was a typo on a documentation page at (https://developer.newrelic.com/contribute-to-quickstarts/instrument-library/send-metrics/)
Reviewer Notes
Just a simple typo fix
Related Issue(s) / Ticket(s)
If there are any related GitHub Issues or JIRA tickets, add links to them here.

issue

Screenshot(s)
If relevant, add screenshots here.
Use Conventional Commits
Please help the maintainers by leveraging the following conventional commit
standards in your pull request title and commit messages.
Use chore

for minor changes / additions / corrections to content.
for minor changes / additions / corrections to images.
for minor non-functional changes / additions to github actions, github templates, package or config updates, etc

git commit -m "chore: adjusting config and content"

Use fix

for minor functional corrections to code.

git commit -m "fix: typo and prop error in the code of conduct"

Use feat

for major functional changes or additions to code.

git commit -m "feat(media): creating a video landing page"

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Best way to format dates for display purposes

I have looked trough the documentation but haven't found any mentions about formatting dates while taking the current region, locale and timezone into account.
I display dates in various forms throughout my app and when for example using myDate.toFormat("HH:mm") to display the time of a date, this is displayed as GMT even though my device is GMT+1. To get the time displayed in the current timezone of the device I do this:
let dateRegion = DateInRegion(myDate, region: Region.current)
dateRegion.toString(.time(.short))

This works, but is there an easier way, without having to create a DateRegion with the current region everytime?
When working with dates and formatting them to, for example, send them to my API, always having them as GMT seems logical, but when DISPLAYING dates it would be nice if the current regional settings of the device would be used by default.

I have to write those codes in 6.0.x:
myDate.in(region: Region(zone: TimeZone.current)).toFormat("yyyy-MM-dd")

while the build-in DateFormatter uses the system timezone  by default:
https://developer.apple.com/documentation/foundation/dateformatter/1411406-timezone


[libs/movex] Remove "applyAction" method from MovexResourceObservable

Where
libs/movex/src/lib/client/MovexResourceObservable.ts
What
Remove the unused applyAction

Why

Readability and decrease size

Definition of done

the function is gone
all tests are still passing yarn test

PR created ^^ (#64)


Separate section for libraries?

Right now software libraries are under Desktop, if giulioscattolin/google-gnss-logger is anything to go by.
If I wanted to add, say, https://github.com/stenseng/ntripstreams  - shouldn't this be under a libraries section?

Yes, I'm fine splitting out libraries into their own section - what you say makes sense. Pull requests welcome! :)


Fix first sentence in docs

"create and access to a pool" didn't make any sense, so I rewrote it to reflect some of the similar stuff we have on the website.

ping @moxiegirl

LGTM

The whole paragraph reads kind of funky to me, but it looks better with the change.

LGTM - @bfirsh @MHBauer are we good to merge this?

Go for it. Don't let me hold anything up.


4.0 beta10 to beta11 unable to open Project>Project Settings

Godot version
v4.0.beta11.official.91713ced8
System information
win10 OpenGL Renderer: NVIDIA GeForce GT 1030/PCIe/SSE2
Issue description
project upgrade from beta10 to beta11, Project Settings no workd;
when click Project Settings ,godot is freeze
Steps to reproduce

open project
click Project Settings
godot is freeze

Minimal reproduction project
beta11-freeze_demo.zip

4.0.1 also

good news: it work,
bad news: I didn't do anything
Today, I just opened the project and it suddenly turned out to be normal without any problems. It's really strange......


image metadata output different for iiif vs simple

The Simple image derivative script seems to output a different image metadata path than the IIIF script to the csv and other files, which breaks the search thumbnail preview.

IIIF:
"/img/derivatives/iiif/images/obj4/full/250,/0/default.jpg",/img/derivatives/iiif/obj4/manifest.json,"/img/derivatives/iiif/images/obj4/full/1140,/0/default.jpg"
Simple:
img/derivatives/simple/obj11/thumbnail.jpg,img/derivatives/simple/obj11/fullwidth.jpg

the IIIF script puts a / in front of img. (It also includes quotations, which I'm not sure make a huge difference). The Simple script breaks the thumbnail display in the search page because it's missing that / and the path ends up running together like localhost:4000/waximg/derivatives/... instead of localhost:4000/wax/img/derivatives/...
The thumbnail images don't show up on the search page and jekyll gives this error (showing the path name run-in without the /):
 ERROR '/waximg/derivatives/simple/obj11/thumbnail.jpg' not found.
I was able to manually fix the thumbnail error by adding slashes to all the thumbnail pathways in the search/index.json, but it would be extremely annoying to do if I had a lot more images. Both the scripts should output the same path format.

oh I didn't realize I had to change the viewer to simple_image_viewer, that fixed the display issue!

The thumbnail image don't show up on the search page and jekyll gives this error (showing the pathname runin without the /)
[2020-10-18 23:24:43] ERROR '/waximg/derivatives/simple/obj11/thumbnail.jpg' not found.

I was able to manually fix the thumbnail error by adding slashes to all the thumbnail pathways in the search/index.json, but it would be extremely annoying to do if I had a lot more images

@leucotic you 100% caught a bug, thanks for the heads up!
if you need a less tedious fix while I work on a patch in the wax_tasks gem, you can temporarily fix this in your site by adding a slash between ${url} and ${item.thumbnail} in assets/search-ui.js:
https://github.com/minicomp/wax/blob/main/assets/search-ui.js#L14
(I'll leave this issue open until I release the patch.)

Thank you! I will try that.
(I'm just learning the framework for now and gathering materials for a collection, I don't have a live site yet, but I will soon, hopefully!)

This has been fixed in wax_tasks#74 and released on rubygems.org.
bundle update wax_tasks will pull in the newest version 1.1.5


Redirect legacy notebooks URL to current observability one

Signed-off-by: Joshua Li<EMAIL_ADDRESS>Description

register a new app with id notebooks-dashboards to redirect old notebooks URLs to current URL

This is used to support old notebook reports
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] New functionality includes testing.

[x] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I understand this functionality added to support old URLs of notebooks. But how do users end up on these URLs? Are they from reporting?

Yes, report definition stores the source URL in OpenSearch, reports that were created before observability will keep using the old URL


(BKR-1054) Retry when RSA keygen fails

There is some sort of race condition that occurs when trying to
generate RSA keys during testing with ruby 2.2.5 and OpenSSL. This
change adds a retry to the key process generation.

@kevpl how do you feel about PRs that change product code to fix flaky spec tests? 🙈

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3483/

@ferglor you should also take a look here, so we can get the test machine rolling green again!

👍 lgtm


Implement a basic rendering system

As our rendering engine is primarily for 3D, we'd need a basic rendering system that shows 3D models with lighting and shadows.

Implemented data structures for Camera and Entity-based transforms via #32. Veldrid integration and the Graphics abstractions are still WIP.

Closed via https://github.com/vignetteapp/sekai/commit/de8096bb04ad9085cd34474ad6830fbc6f19e571


Compile failure on Linux Swift 5.1

/package/.build.production/checkouts/aws-sdk-swift-core/Sources/AWSSDKSwiftCore/XML.swift:424:31: error: 'XMLParser' is unavailable: This type has moved to the FoundationXML module. Import that module to use it.
        func parser(_ parser: XMLParser, didStartElement elementName: String, namespaceURI: String?, qualifiedName qName: String?, attributes attributeDict: [String : String] = [:]) {
                              ^~~~~~~~~
Foundation.XMLParser:2:18: note: 'XMLParser' has been explicitly marked unavailable here
public typealias XMLParser = AnyObject
                 ^
/package/.build.production/checkouts/aws-sdk-swift-core/Sources/AWSSDKSwiftCore/XML.swift:436:31: error: 'XMLParser' is unavailable: This type has moved to the FoundationXML module. Import that module to use it.
        func parser(_ parser: XMLParser, didEndElement elementName: String, namespaceURI: String?, qualifiedName qName: String?) {
                              ^~~~~~~~~
Foundation.XMLParser:2:18: note: 'XMLParser' has been explicitly marked unavailable here
public typealias XMLParser = AnyObject
                 ^
/package/.build.production/checkouts/aws-sdk-swift-core/Sources/AWSSDKSwiftCore/XML.swift:440:31: error: 'XMLParser' is unavailable: This type has moved to the FoundationXML module. Import that module to use it.
        func parser(_ parser: XMLParser, foundCharacters: String) {
                              ^~~~~~~~~
Foundation.XMLParser:2:18: note: 'XMLParser' has been explicitly marked unavailable here
public typealias XMLParser = AnyObject
                 ^
/package/.build.production/checkouts/aws-sdk-swift-core/Sources/AWSSDKSwiftCore/XML.swift:447:31: error: 'XMLParser' is unavailable: This type has moved to the FoundationXML module. Import that module to use it.
        func parser(_ parser: XMLParser, foundComment comment: String) {
                              ^~~~~~~~~
Foundation.XMLParser:2:18: note: 'XMLParser' has been explicitly marked unavailable here
public typealias XMLParser = AnyObject
                 ^
/package/.build.production/checkouts/aws-sdk-swift-core/Sources/AWSSDKSwiftCore/XML.swift:451:31: error: 'XMLParser' is unavailable: This type has moved to the FoundationXML module. Import that module to use it.
        func parser(_ parser: XMLParser, foundCDATA CDATABlock: Data) {
                              ^~~~~~~~~
Foundation.XMLParser:2:18: note: 'XMLParser' has been explicitly marked unavailable here
public typealias XMLParser = AnyObject
                 ^
/package/.build.production/checkouts/aws-sdk-swift-core/Sources/AWSSDKSwiftCore/XML.swift:455:31: error: 'XMLParser' is unavailable: This type has moved to the FoundationXML module. Import that module to use it.
        func parser(_ parser: XMLParser, parseErrorOccurred parseError: Error) {
                              ^~~~~~~~~
Foundation.XMLParser:2:18: note: 'XMLParser' has been explicitly marked unavailable here
public typealias XMLParser = AnyObject
                 ^
/package/.build.production/checkouts/aws-sdk-swift-core/Sources/AWSSDKSwiftCore/XML.swift:459:31: error: 'XMLParser' is unavailable: This type has moved to the FoundationXML module. Import that module to use it.
        func parser(_ parser: XMLParser, validationErrorOccurred validationError: Error) {
                              ^~~~~~~~~
Foundation.XMLParser:2:18: note: 'XMLParser' has been explicitly marked unavailable here
public typealias XMLParser = AnyObject
                 ^
/package/.build.production/checkouts/aws-sdk-swift-core/Sources/AWSSDKSwiftCore/XML.swift:412:50: error: use of undeclared type 'XMLParserDelegate'
    fileprivate class ParserDelegate : NSObject, XMLParserDelegate {
                                                 ^~~~~~~~~~~~~~~~~
/package/.build.production/checkouts/aws-sdk-swift-core/Sources/AWSSDKSwiftCore/XML.swift:221:26: error: 'XMLParser' is unavailable: This type has moved to the FoundationXML module. Import that module to use it.
            let parser = XMLParser(data: xmlData)
                         ^~~~~~~~~
Foundation.XMLParser:2:18: note: 'XMLParser' has been explicitly marked unavailable here
public typealias XMLParser = AnyObject
                 ^

Fix is
#if canImport(FoundationXML)
import FoundationXML
#endif

Can probably PR later today. Just upgrading some infrastructure.

Added PR #125


Prefetch renditions in images index view

The goal of this PR is to reduce the number of queries when rendering images in the image's index view by prefetching renditions (See #8069).
In the bakerydemo build, this reduces the number of queries from 42 to 23. It makes sense since, by default, we render 20 images. Instead of fetching each image's rendition, we fetch all in one go which saves us 19 queries!

I've added some docs and a release note.

Merged (25c43273a9bf527f8ec307fb0e4905f79a27f531 and previous), thanks!


Add python version to README

Adds requirement of Python 3.6+

fyi @tfdahlin

@RONNCC I don't think we really need this, since it's covered by the badge at the top of the README

Coverage increased (+0.009%) to 94.754% when pulling 7287a90e8205e6919d598338e9945d86855fb21b on RONNCC-patch-1 into ff8335d7884fd9c4272ffd7edc5720ea02fdf6b1 on master.

Coverage increased (+0.009%) to 94.754% when pulling 7287a90e8205e6919d598338e9945d86855fb21b on RONNCC-patch-1 into ff8335d7884fd9c4272ffd7edc5720ea02fdf6b1 on master.

Codecov Report

Merging #803 (7287a90) into master (ff8335d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #803   +/-   ##
=======================================
  Coverage   94.77%   94.77%
=======================================
  Files          15       15
  Lines        1224     1224
=======================================
  Hits         1160     1160
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8335d...7287a90. Read the comment docs.

@tfdahlin  ah good point


UP007 false negative with quoted type

UP007 won't recognize cases like
from typing import Optional

def foo(_: Optional["myclass"]):
    pass

While it recognizes
from typing import Optional

def foo(_: Optional[myclass]):
    pass

reproduces with 0.0.277 and on the playground

I think this follows pyupgrade’s behavior, but I need to look into if that’s true, and why.

I think this is the correct behavior (in some cases). E.g., this fails for me on 3.11:
from typing import Optional

def foo(_:  "myclass" | None):
    pass

With:
Traceback (most recent call last):
  File "/Users/crmarsh/workspace/ruff/foo.py", line 4, in <module>
    def foo(_:  "myclass" | None):
                ~~~~~~~~~~^~~~~~
TypeError: unsupported operand type(s) for |: 'str' and 'NoneType'

However, it's sometimes okay, e.g. this is fine:
from typing import Optional

class MyClass:
    pass

def foo():
    x: "MyClass" | None = MyClass()

foo()

But this is not:
from typing import Optional

class MyClass:
    pass

def foo():
    x: "MyClass" | None = MyClass()

    def bar(x: "MyClass" | None):
        pass

foo()

It has to do with when Python evaluates annotations at runtime (e.g., any parameters to functions need to be evaluated at runtime because they get added to __annotations__). We can support this in more cases but it's not safe to do everywhere.


Upgrade to Akka 2.4.0

Closed with https://github.com/RBMHTechnology/eventuate/commit/d2ae410f9bf21b2e8680a512844d01301eae2a9b


the wrong box placement in character editor

Describe your bug here. Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version.
when I try clicking on the icon rename box something a little bit weird happened
it didn't decide to type in that box instead it decided to type in the rename and I couldn't rename the icon but to go to notepad and rename the icon
https://youtu.be/CJvLRiCJf2c
please fix this Jorden
Command Prompt/Terminal logs (if existing)
idk

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
idk

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
I only added scripts
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here.
Yes

my guy this footage is NOT clear enough 😭

my guy this footage is NOT clear enough 😭

hold on I will use my Windows computer instead of my dindows, I got the Windows PC from the Milky Way from the other universe

https://youtu.be/x7GZK6vW1Do

Issue does not occur for me.

closing due to no further response


exception handling for invalid date parsing

Steps:

Add an invalid due Date like

Result:
Sidebar is empty. Found no errors in the console.

After removing the task line or fixing the date, the Calendar wrapper shows up again.

Hi @limex thanks for the report, this is a known issue, the timeline view broke because an exception thrown by the moment library during parsing dates. I will fix it in the next release.

Same Issue. Curious the Dataview Taskido detect it as Invalid.


add RotateDaily

add RotateDaily

I don't believe in rotating on a per-time basis.  This has come up before - https://github.com/natefinch/lumberjack/issues/17
If you need to, you can implement this outside of Lumberjack and just call the rotate method manually... however I don't really recommend it.


Make video capture behave like photo capture re. storage options

This makes video work on Android without storage permissions (the default). It also
prevents videos from showing up in Google Photos on some phones.

r? @keybase/react-hackers
Don't think this warrants a hot fix, since the current behavior is a black bar (and was present in the last release, too).


Provide list of recent recordings as attribute of each camera

Is your feature request related to a problem? Please describe.
The binary_sensor presented through home assistant when motion is detected doesn't work reliably for me as I actively (through automation) arm and disarm my cameras. If a camera happens to be disarmed when the list of video is checked, no motion detection is reported and the video is missed. Sometimes, there are multiple videos since the last refresh and only the most recent is (sometimes) spotted.
Describe the solution you'd like
I would like a list (of tuples) of clips (maybe limited to most recent X), their creation timestamps and their URLs to be added to the camera entity as an attribute. To support download of these files, I suggest enhancing the download videos service to accept an optional clip URL that must be one of those listed in the attributes. If I was really wishing, I would love a binary_sensor that indicates that the file list has changed (but this feels like something easily done with template magic in home assistant).
Additional context
I wanted to have a go at making this myself but I couldn't get my head around forking the blinkpy library and using that fork in a custom_component. I have already built an addon that sniffs for DHCP packets that match my cameras and fires an event into home assistant so I can reliably detect when a camera comes online. I would like that event to trigger a refresh of blink and then use the list of clips requested here to figure out whether there was motion or not (irrespective of the arming status). I can also populate an input_select with the list of clips which I can download locally and then serve through the local_file camera integration.

I have now pushed the addon to my repo having added ICMP pinging to watch for the camera to go offline. Testing so far shows detection of camera activity is good and I use the offline trigger to refresh blink. I used the blink app to update the thumbnail picture and saw that the offline event firing in HA was the same as the new thumb being shown in their own app.
FWIW, I now use local_file camera entities in my HA dashboards and use the blink entities in the background. If the refresh detects motion, I download the video and change the local camera to show that motion. If no motion, update the thumb and show the still image. It gives a semi live experience!
Now I can reliably detect camera activity without spamming blink servers, I would love to get at the full list of video clips and their timestamps rather than relying on the binary sensor to decide if there was motion ...

Yes, that does look useful.
You're right, this is perhaps more about the HA integration if this API can be reused.
Looking at the code, I guess I could:

Detect camera activity
Request all videos since time of previous activity
Use shell script / python to read list of files downloaded
Grep file name for camera name and timestamp

Would the library know time of last refresh or is this something I should track? Pretty sure I can do it in HA if needed and can then pass into call to download videos service?

Can I reuse the auth being used (saved?) by the HA integration or would I need to separately authenticate the external version?


docker cp not working properly

Hello,
Fist of all, thanks for the driver and the work you put into it, it's great, it saves me a lot of time when creating containers.
I discovered a bug, the issue is the following:
When I start the container the volume correctly mounts.
Then, while the container is running I run a "docker cp".
When the "docker cp" ends the volume unmounts (i.e. the "mountpoint" folder is no longer there)
The running container does not like that.
Doing a "docker cp" with an stopped container or starting and stoping the container work just fine.
If you could fix it or give me some indications on where to look would be really nice (I cannot do it without help due to my total lack of knowledge of Go and Docker drivers)
Thans!

Good day! I am glad you found docker-on-top useful. I might be able to have a deeper look in your problem in a few days.
Meanwhile, it would be useful if you provided a minimal reproducible example: which containers I need to start and which commands to run (starting with the volume creation) to reproduce the issue.
Logs can be useful too. If you're running the docker-on-top executable manually, you can just provide the output it generates. If you're using a systemd service, you can access the logs via sudo journalctl -u docker-on-top.service (to see logs generated previously) or sudo journalctl -u docker-on-top.service --follow to access logs in the real time.

WoW, that was quick!
I have attached a zip file with the reproductible example: test.zip
It contains these files:

An script with the steps to do to reproduce the issue. Is better to follow it step by step rather than executing it.
A docker-compose.yaml file with the container and volume information
The logs of an erroneous run. From what I see, it mounts the volume first when the container is run, then again with the cp, then an unmount also with the cp, and an unmount with an error when the container is stopped.

спасибо (which is most of the Russian I remember from the time when I had time to learn languages 😉)

Hello again!
I was able to reproduce the issue. The docker-on-top code erroneously assumes that a volume could only be mounted several times if there are several containers using it, and, vice versa, if it's only mounted in one container, it should be mounted just once. The assumption breaks when using docker cp (apparently, docker temporarily mounts the same volume to another place to perform the copy).
I will look into it soon and, hopefully, fix it by the end of the week

Hm. After a deeper investigation, it appears to me that this is a bug of dockerd rather than docker-on-top. At least, according to the documentation, the assumption I described above that docker-on-top makes is valid.
Upstream issue: moby/moby#47964
It's taking longer than I was hoping it would... But I hope this week I will have enough time to try and submit a patch for dockerd

Thanks for all the effort you are putting into it even if the bug it's not in docker-on-top. I will keep an eye also in the upstream issue to see if it gets fixed.

Hello there! It's been a while.
A few days ago I submitted a PR: moby/moby#48096. It fixes the issue on Linux, however, it's not yet ready for merge:

There are a few TODOs fixing which will improve the code quality,
I only implemented the linux/unix version, the current patched version won't build on windows at all,
Integration tests are not implemented,
etc. See the first PR message for details.

I opened the PR because I wanted to synchronize with the maintainers and agree in which direction I should be going (and also ask them some questions about the code) but opening the PR alone did not attract them. Maybe I should ping a particular person but after (briefly) glancing through the contribution guidelines I didn't find which person I should ping.
Moreover, in the next couple of weeks I may not have much time to work on this, even if someone does come there to answer my questions.

Anyway! Back to Docker-on-Top! I see three things that can be done about this issue (#18):

Before it's resolved, there's a workaround. If you need to docker cp from/to a container that uses a docker-on-top volume, stop the container first, then docker cp, then start the container again. Kinda sucks but... ¯\_(ツ)_/¯

The right way to fix this issue would be to patch the upstream (https://github.com/moby/moby, aka dockerd) because this bug occurs due to dockerd violating what's stated in their plugin API docs, namely, the fact that mount ID is unique for every mount.
If you, @andergnet, or anyone else decide to take this path, you are free to base your solution on top of what I've already implemented in moby/moby#48096, if you want to.

But I have a feeling that the upstream bug is not going to be resolved anytime soon. So, I'm ready to accept a patch for docker-on-top itself, working around the plugin API issue.

Details about what to patch in docker-on-top
The patch would need to alter the way docker-on-top tracks mounts: currently, for every mount ID there's a corresponding (empty) file created when it's mounted and deleted when it's unmounted, and it's only the first mount and the last unmount that we care about: that's when there's real work to do.
But it doesn't work because with docker cp on a running container, dockerd may issue a Mount/Unmount request with the same ID as it did before. So, it should be reworked to track multiple mounts with the same id.
Before making the patch, check if docker allows two docker cps running on the same container at the same time. If not (i.e., they are scheduled one after another), there should be no more than 2 mounts with the same ID possible (it will make your work much easier).

Thanks for the update, I have been following the [lack] of progress of the PR, I hope someone gets in touch and fixes it.
The workaround I have taken for the time being is to check whether the container is running or not, if it's not do a docker cp, if it is do a cp from the mountpoint folder. It's a script so it does not really hurt.
I may try to send you a PR, I have looked into the code and it does not seem too hard:

Add a counter to the VolumeInfo structure
On mount check whether the file exists or not, if it does exist, increase the counter
On unmount read the file, decrease the counter and only delete it when the counter reaches zero.
Theory looks solid, we'll see how practice goes

Just a quick update, I'm working on a solution I hope to finish it by the end of the week.

I have just sent you a pull request that fixes this issue, I hope it is to your liking ☺.


EmsEvent: set container_node_id by ems & name when event has no UID

Workaround for #9600 - not a full fix but ensures in practice container_node_id is set.
Covers both missing involvedObject.uid and node name given as uid which I'm seeing in some events.
#9600 doesn't currently have it's own BZ (not even sure it's user-visible, maybe in node Timeline?)
but this fix is important for node event -> policy support (#9601, #9813) whose BZs are:
https://bugzilla.redhat.com/show_bug.cgi?id=1341253 (master)
https://bugzilla.redhat.com/show_bug.cgi?id=1346057 (darga)
@miq-bot add-label bug, providers/containers, darga/yes

I split this from #9601, it turnd out cleaner to have container_node_id set in the first place.
@moolitayer or @dkorn please review.

@cben IMHO, until the issue will be fixed in k8s (I'll open an issue), the workaround should be placed in event_catcher_mixin.rb, specifically, when handling a Node event here:
https://github.com/ManageIQ/manageiq/blob/master/app/models/manageiq/providers/kubernetes/container_manager/event_catcher_mixin.rb#L77
in this case, the condition will be something like: if event_data[:uid].nil? || event_data[:uid] == event_data[:name]
This will handle the problem during the event processing and will save the lookup fail for every node in https://github.com/ManageIQ/manageiq/pull/9913/files#diff-edcc6e6ea6f974c08f1323b292309dc6L157

I've opened a k8s issue after sync with @dkorn
I'd like to get confirmation this is indeed an k8s issue, then we can talk about a workaround

I've opened a k8s issue after sync with dkorn

Thanks!

I'd like to get confirmation this is indeed an k8s issue, then we can talk about a workaround

Whether feature or bug, we're quite confident that's what k8s currently does.
I want some workaround before code freeze for node policies to function.
I moved it into catcher as @dkorn suggested, will push -f once I test it.

Whether feature or bug, we're quite confident that's what k8s currently does.
I want some workaround before code freeze for node policies to function.
I moved it into catcher as @dkorn suggested, will push -f once I test it.

ok please add a "# workaround for https://github.com/kubernetes/kubernetes/issues/29289"

ok please add a "# workaround for kubernetes/kubernetes#29289"

@cben @moolitayer let's handle that. I assume other than that we're ready to merge this, right?

Don't merge yet, I'm testing the new workaround version.

I'd like to see a spec for the workaround

@moolitayer @dkorn PTAL
Added extensive tests based on live data.
Change the workaround to force uid to nil when it's known useless uid == name but we didn't find the node.  This avoids later unecessary lookups.

Fixed rubocop, except for method under test being too complex, refactoring which is out of scope here.

LGTM :+1:

cc @gmcculloug

@lfu Please review

Ping @lfu @gmcculloug - any chance you can review before freeze?

@miq-bot add-label blocker
per BZ https://bugzilla.redhat.com/show_bug.cgi?id=1346057 being blocker+
This is essential for node events to trigger control policies.

Darga backport details:
commit 9c639d6cd5beb66512e1760df7cbef7d97b9971a
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Tue Jul 26 07:50:21 2016 -0400

    Merge pull request #9913 from cben/container_node_id

    EmsEvent: set container_node_id by ems & name when event has no UID
    (cherry picked from commit 99bc55119113e42f8eafded570a64b05ba66bb7b)


Enhanced Damage/Defense

Hello,
Looking through d2go code; it looks like you're getting the item stats directly from memory. Can you confirm, then, that meta stats such as Enhanced Defense, Enhanced Damage do not work at all for d2go and koolo?
I've been putting lines like this in the NIP files:
[name] == sharkskinbelt && [quality] == unique && [flag] != ethereal # [enhanceddefense] >= 150
but now I'm realizing this will never be true, as there is never a value for enhanceddefense.
Can you confirm that please? I would like to change my NIPs if that's the case.

Yes, you are right, are not working. Are those stats calculated somehow?

For an Spirit Shield, this is what we read:

And this is the object:

Well, I am not an expert in memory, but I do have a working python memory reader that gets every piece of information from D2R that I know how to get. In a sense, my [private] project is similar to d2go (but is in python). I could be wrong about the following, so you should try to consult with someone else if possible. But as far as I understand it, there are only two ways to get these values:

The one I am not currently able to do (100% accuracy, fast)
The one I am probably able to do (90+% accuracy, slow)
The one I am currently doing (varying accuracy)

The problem
Let me first explain the issue in short (again, my understanding, could be incorrect):
The game doesn't care what the enhanced defense or enhanced damage or resist all is. These values are only for item tool tips. The game only cares what defense or damage or each resist the item has. This makes sense when you think about it, because those are the things actually used in calculations. So these three are actually not item stats - they are tool tip stats. They are used on the server side for generating the item, but are only sent to the client for tool tips.
1. The solution that would work 100% of the time, and is fast, that I don't know how to do
If you roll your mouse over an item and scan memory for the ED value as string, for example +15% Enhanced Damage, you will find the tool tip lines represented pretty clearly. However, I'm not aware of how to reliably find these tool tips (the offsets), and they do seem to be fleeting (the value seems to move around and change). The best solution I know of would be to read the tool tip directly from in-game memory. Unfortunately I'm not good enough to do this myself.
2. The one I am probably able to do (90+% accuracy, slow)
It should be possible, knowing about the above, to scan the memory in real time and determine the tool tip being shown and get the strings. Basically, you need to figure out the memory offset range from the base address, that these tool tips are always showing in. Then you need to know something about the item you are rolling the mouse over. For example you know you are hovering an identified Shako. Then you scan in reverse order (as the tool tips lines are listed backwards), to find the Shako lines, then read the rest to get the values. This is potentially error-prone, because like I said the values seem to pop in and out of existence, so you may need to scan in a loop until you get all the values. I will probably work on this method myself soon.
3.  The one I am currently doing (varying accuracy)
The only way I know of to avoid any new memory scanning or reading, is to apply the following logic (pseudo-code). Though it's not pictured in your screenshot, you should be able to access the item's base stats in addition to its stats. I will show you the enhanced defense logic, because it is more clear. The damage logic should be fairly obvious after reading this.
# this is not the entire code. you also need to calculate for the base item of runewords, etc. This is just an example so you get the basic idea.

defense = defense in "stats"
for item in the item's sockets:
  defense -= any defense from those items

if item.quality is unique or item.quality is set or item.is_runeword:
 properties = get the properties from properties.txt
 does it only add enhanced defense (no +defense) ?
 yes: is it always the same amount of ED?
     yes: you have your answer
     no:
        defense -= any static defense added if it is always the same (for example magefist always adds 15 defense)
        enhanced defense = the percent increase from base defense to defense
        (if the item adds varying defense and varying enhanced defense, there is no way to know accurately which one is which)

There is more to it but that's an example of the logic needed. It is very accurate for some items (for example Fortitude Runeword armor. It has static +15 defense and 300% ed, so all you need to do is calculate the 0-15% superior item defense). It is extremely inaccurate for items with small values (for example magefist, because it only has 24-25 defense, but has a 10-range enhanced defense). It is also inaccurate for items which add varying +defense and varying enhanced defense at the same time. So it is not a great solution, which is why I may move to scanning memory range soon, if it's not too slow.
For your spirit shield, since the runeword doesn't add any defense, the calculation is just
round_up ((170 - 148)/148) * 100 = 15%


Impossible to connect

Hello,
The run_cil.py script cannot connect to the server. When trying to establish a connection, I get a connection refused or connection timed out errors. I know this is not a firewall or network reachability problem as I can run the manual_driving.py script and can control the vehicle remotely.
Find the output generated by running run_CIL.py below. I'd appreciate if any potential solution is shared.
 === Conv 0   :   5 2 32
Dropout 0
Tensor("Network/conv_block0/relu1:0", shape=(?, 42, 98, 32), dtype=float32)
 === Conv 1   :   3 1 32
Dropout 1
Tensor("Network/conv_block1/relu2:0", shape=(?, 40, 96, 32), dtype=float32)
 === Conv 2   :   3 2 64
Dropout 2
Tensor("Network/conv_block2/relu3:0", shape=(?, 19, 47, 64), dtype=float32)
 === Conv 3   :   3 1 64
Dropout 3
Tensor("Network/conv_block3/relu4:0", shape=(?, 17, 45, 64), dtype=float32)
 === Conv 4   :   3 2 128
Dropout 4
Tensor("Network/conv_block4/relu5:0", shape=(?, 8, 22, 128), dtype=float32)
 === Conv 5   :   3 1 128
Dropout 5
Tensor("Network/conv_block5/relu6:0", shape=(?, 6, 20, 128), dtype=float32)
 === Conv 6   :   3 1 256
Dropout 6
Tensor("Network/conv_block6/relu7:0", shape=(?, 4, 18, 256), dtype=float32)
 === Conv 7   :   3 1 256
Dropout 7
Tensor("Network/conv_block7/relu8:0", shape=(?, 2, 16, 256), dtype=float32)
Tensor("Network/reshape:0", shape=(?, 8192), dtype=float32)
 === FC 0   :   512
Dropout 8
Tensor("Network/fc1/relu9:0", shape=(?, 512), dtype=float32)
 === FC 1   :   512
Dropout 9
 === FC 2   :   128
Dropout 10
 === FC 3   :   128
Dropout 11
 === FC 4   :   512
Dropout 12
 === FC 5   :   256
Dropout 13
 === FC 6   :   256
Dropout 14
Tensor("Network/Branch_0/fc7/relu15:0", shape=(?, 256), dtype=float32)
 === FC 8   :   256
Dropout 15
 === FC 9   :   256
Dropout 16
Tensor("Network/Branch_1/fc10/relu17:0", shape=(?, 256), dtype=float32)
 === FC 11   :   256
Dropout 17
 === FC 12   :   256
Dropout 18
Tensor("Network/Branch_2/fc13/relu19:0", shape=(?, 256), dtype=float32)
 === FC 14   :   256
Dropout 19
 === FC 15   :   256
Dropout 20
Tensor("Network/Branch_3/fc16/relu21:0", shape=(?, 256), dtype=float32)
 === FC 17   :   256
Dropout 21
 === FC 18   :   256
Dropout 22
Tensor("Network/Branch_4/fc19/relu23:0", shape=(?, 256), dtype=float32)
Restoring from  D:\auto_dev\CARLA\CARLA_0.8.2\PythonClient\agents\imitation/model/model.ckpt-450000

D:\Program Files\Python\Python36\lib\site-packages\h5py\__init__.py:36: FutureWa
rning: Conversion of the second argument of issubdtype from `float` to `np.float
ing` is deprecated. In future, it will be treated as `np.float64 == np.dtype(flo
at).type`.
  from ._conv import register_converters as _register_converters
INFO: listening to server localhost:2000
INFO:tensorflow:Restoring parameters from D:\auto_dev\CARLA\CARLA_0.8.2\PythonCl
ient\agents\imitation/model/model.ckpt-450000
INFO: Restoring parameters from D:\auto_dev\CARLA\CARLA_0.8.2\PythonClient\agent
s\imitation/model/model.ckpt-450000
INFO: START
ERROR: (localhost:2000) failed to read data: timed out
ERROR: (localhost:2000) failed to read data: [WinError 10054] An existing connec
tion was forcibly closed by the remote host
INFO: START
ERROR: (localhost:2000) failed to read data: timed out
ERROR: (localhost:2000) failed to read data: [WinError 10054] An existing connec
tion was forcibly closed by the remote host
INFO: START
ERROR: (localhost:2000) failed to read data: timed out
ERROR: (localhost:2000) failed to read data: [WinError 10054] An existing connec
tion was forcibly closed by the remote host
INFO: START
ERROR: (localhost:2000) failed to read data: timed out
ERROR: (localhost:2000) failed to read data: [WinError 10054] An existing connec
tion was forcibly closed by the remote host
INFO: START
ERROR: (localhost:2000) failed to read data: timed out
ERROR: (localhost:2000) failed to read data: [WinError 10054] An existing connec
tion was forcibly closed by the remote host
INFO: START
ERROR: (localhost:2000) failed to read data: timed out
ERROR: (localhost:2000) failed to read data: [WinError 10054] An existing connec
tion was forcibly closed by the remote host

Same problem here . Any update to the question would be life saving.

Are you running on windows ? I can't reproduce the error =/

Yes I am running on windows.

I am running on Windows too.
On 19 June 2018 at 13:39, soham2017<EMAIL_ADDRESS>wrote:

Yes I am running on windows.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/carla-simulator/imitation-learning/issues/32#issuecomment-398384252,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQUNuRrjKqlABuKpKz6xCvRM2iV8QwABks5t-PEAgaJpZM4T6hx4
.

I am running on Ubuntu, meet the same problem... @felipecode

Same problem here. I guess its due to carla version. Someone had similar problem but with the python client. I think the older version shall be installed inorder to work with imitation learning.
https://github.com/carla-simulator/carla/issues/697

I'm using carla <IP_ADDRESS>, but I'm still facing this problem. Any idea how to fix it?
@arashroomi @soham2017 @eds89

Still encountering this problem

For carla 0.8.2, use the param -carla-server to start carla simulator.  ./CarlaUE4.sh -carla-server

For carla 0.8.2, use the param -carla-server to start carla simulator.  ./CarlaUE4.sh -carla-server


Update credits page, fix major landscape.io warnings.

Current coverage is 94.59% (diff: 0.00%)

Merging #225 into UIA will increase coverage by 0.02%

@@                UIA       #225   diff @@
==========================================
  Files            47         47
  Lines         18935      18933     -2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          17908      17910     +2
+ Misses         1027       1023     -4
  Partials          0          0

Powered by Codecov. Last update d688320...70c277e

All good. Just small grammar typos like: "The main layout..", "A special layout..." ".. a combination of 64-bit Python and 32-bit app...."


Log transaction events

Feature description

Log transaction events so big dipper would be able to display how much a user withdraws etc

Implementation proposal

@ryuash Do you have other examples of things missing? These should be transactions not event

@ryuash Just verified, and the logs field should already be there:
query Transaction {
  transaction(limit: 1) {
    logs
  }
}

perfect


Cant enable AV1 codec

Netflix add-on version
Version 1.21.0+matrix.1
Operative systems used
Android
Kodi version used
Kodi 20 (Nexus)
Description of the bug
I can't enable the AV1 codec on the latest version of the addon. It's not even there

Steps to reproduce the behavior
No response
Debug log - mandatory
Null
Possible fix
No response
Additional context
No response
Screenshots
No response

Kodi 20 cannot support DRM AV1
so to get AV1 you need Kodi 21

Kodi 20 cannot support DRM AV1 so to get AV1 you need Kodi 21

Yikes. I don't to break my add-ons in half so I'll just until kodi 21 becomes stable. I guess I'm keeping my Netflix app up and running ATM 🤣😂


Xcode Tips

推荐收录
链接
For the developers out there, Xcode 13.3 has a new opt-in build mode that results in faster builds. Activate with efaults write com.apple.dt.XCBuild EnableSwiftBuildSystemIntegration 1.
https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-13_3-release-notes#Build-System

efaults fix to defaults


Nested class, More of a question.

Current Environment:
python version = 3.6.8
attrs = "^21.2.0"
I have a json structure like this

i have define attrs class for each of the individual properties i.e. Address, Retailer, Location etc
i was hoping to create a class like this,

And use the attr.as dict to create the whole JSON in the required format.
Could not get this to work as expected.
Any suggestions on this approach would be very helpful.
Apologies in advance if opening an issue is not the right thing for this.

Have you created different classes for Location, Address, Retailer and ProductMix? I tried by creating a new attr.s class for location and providing the attr.ib(type=Location) in the Source class and it worked fine. Try out with this code and see if it works for u. Here is link to the colab file here

As pointed out, I think you're conflating = with :.
In the mode you're using, you have to use = attr.ib() for all fields.
In 3.6 you should be able to write:
@attr.define
class Source:
    store_id: int
    name: str
    address: Address
    location: Location
    # ...

(if Address etc are defined that is)
But I already suspect that you might need more control over your serialization/deserialization. You should have a look at https://cattrs.readthedocs.io/ as an add-on. Bear in mind that your Python version is so old that you can only use cattrs<1.1.0.

Thank you for the directions @hynek and @MrinalTyagi
Using this within the context of apache airflow dag's whose stable version happens to be on 3.6.8
cattrs is definitely on the cards, will edit/close this comment with the end results.
Oh, awesome library this !!

@hynek
Staying true to your suspicion, is it a good idea to achieve omit if default through
field_transformers
Basically, skip values that are equal to their default or factory values in the dict.
Trying cut down on external dependencies by not opting for cattrs.
Was not sure if operating on the dict, generated post attr.as_dict, to remove the none values would be efficient as the attrs class would be called in a loop [~800k rows]
Kindly advise.

@gautam-ergo To us keep our bug tracker well-managed, please direct questions to Stack Overflow. You might find more people are reading those there instead of relying only on the core development team to respond.
Closing since I don't think there's an actual bug report here.
Thanks.