[WIP] Compatibility with 16 bit files

Resolves #166  and Resolves #170
Changes:

Create image i/o functions  to centralise image reading and writing in functions of the ads_utils module. (here)
Wrote those functions to correctly convert non-8bit images (e.g. 16 bit images) to 8bit (this is the default option, but can chose any bit depth to be the range in the loadedvariable).
Refactored all AxonDeepSeg files to use this new i/o functionality (e.g. calling ads.imread() instead of imagio.imread()).

@vs74 or @jcohenadad : This branch is ready to review. AxonDeepSeg should now correctly handle 16 bit images (or any other bit value).
To test:

Download this 16 bit image and rename it to image_16b.png:

Checkout master and make sure it's pip install -e . was run.
Run the following command in the folder with the above image: axondeepseg -t SEM -i image_16b.png -s 0.07
You should notice that the command outputs an error, and didn't properly segment the image.
Now checkout this branch (mb_issue170); if you didn't to a fresh clone, make sure you git pull after.
pip install -e . again
Run the following command in the folder with the above image: axondeepseg -t SEM -i image_16b.png -s 0.07
The image segmentation should complete succesfully, and output well-behaved masks.

Coverage increased (+0.3%) to 82.966% when pulling 2227bc0cf82b81f4a337fb4e63a2a0a21b0b0364 on mb_issue170 into f216bb88d3e7cafa53aea98d6db3ed77245f3172 on master.

Mathieu to do:

[ ] Verify that notebooks use the new image i/o functions

@vs74 or @jcohenadad This PR is now ready for review. Instructions on how to do so are located in this comment: https://github.com/neuropoly/axondeepseg/pull/243#issuecomment-531874814


[Protection] Add PlayFab detection

https://store.steampowered.com/app/1546930/Angry_Angry_Shark/
Incorporates 3rd-party DRM: Playfab.com
100000 machine activation limit

PlayFab (https://azure.microsoft.com/en-us/products/playfab) is not purely a DRM, but rather an all-around game development service that appears to contain some DRM elements, though possibly purely optionally. Before detection is added, it needs to be investigated if PlayFab inherently includes DRM, or if we'll have to detect only the DRM components themselves. The duplicate issue appears to reference an older version of PlayFab, seemingly before it was acquired by MS (https://blogs.microsoft.com/blog/2018/01/29/microsoft-acquires-playfab-accelerating-game-development-innovation-cloud/).
Relevant comment from duplicate issue: https://github.com/mnadareski/BurnOutSharp/issues/202#issuecomment-1352946747


CI: Prune 2.3 (and 2.3-alike jruby version)

This PR drop 2.3 from the CI matrix.
https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/

Hey! Is there any possibility we could have a release with 2.3 support before this gets merged and released? 3.0.0 was released quite some time ago and I'd love to use some features that are already in the master branch with Ruby 2.3.
Specifically, I'd love to replace the ansi gem with rainbow in rpush, but we're not yet ready to drop Ruby 2.3 there. :)

Closing this: easy to do when we want to.


Location View Map Address Search

On the Location View Map page, allow the user of the app to enter an address. It should autocomplete like the Google Maps search bar. When a location is selected, the map should set that location's coordinates as its center. This may be a helpful resource.

Update: This should actually be on the TableMap component.

(Note for the future: We will probably want to refactor a bit and move the Wrapper down to the TableMap level, and also rename TableMap to be more generic)

This documentation should be somewhat helpful. Here are some steps you will need to follow:

For now, on LocationViewMap, it will be necessary to add libraries={["places"]} to the <Wrapper> component. This enables us to utilize the Places API.
After that, add an <input> component within the TableMap component. Make sure it has an ID attribute. This will be the textbox where the user can enter searches.
Next, after the map has been created and set (around line 34 in TableMap.js), create a new Autocomplete, passing in the <input>.

This should enable the autocomplete to appear in a basic way. There will be a lot more to do after this, but hopefully this will get things started.

This has been completed!


Log all accesses to toStringTag

Open questions:

Not sure how to make the accessors simply set and get the actual property on the object, so I currently patch them through to a string property. I don't think this is best practice, and the ugly internal string property does show up when I console.log() the object.
Is this the right level/type of logging we want for this?

What's the motivation for this? (This should be included in the PR and commit descriptions.)

What's the motivation for this? (This should be included in the PR and commit descriptions.)

My bad, I'll add it in.
One of the questions brought up in #1607 is whether or not the change would be breaking, so we wanted to get some visibility into how many workers actually use the toStringTag property on built-in objects (i.e. ResouceTypes). This would allow us to find out if a worker is getting or setting the property.

Ah, I see.
My opinion: I don't think we should worry about it. This is like worrying that adding a new method to an existing API could beak someone, because they might be checking for the existence of that method. It's extremely unlikely, and if we worry about stuff like that we'll never get anything done. So I'd say it's fine to proceed without this logging change and without a compat flag.
Honestly the more likely breakage is from people expecting that request.toString() returns [object Object] instead of [object Request], but I don't think this change would actually detect that. I still think this isn't likely, though.

I agree, especially since Node and Chromium already set the toStringTags correctly.
FYI, based on my testing, this change would actually detect what you mentioned.

FYI, based on my testing, this change would actually detect what you mentioned.

I think it will actually log any time anyone calls toString() on a JSG type at all? But people almost certainly do do that (probably by accident, but still), so this log line would be expected to show up immediately, but it doesn't actually tell us if changing the result would break anyone.

Yep, logging on the get here is not likely to tell us anything useful. Logging on the set would at least tell us if someone is trying to work around the lack of our APIs having a ToStringTag. In my original comment I in the other PR I had indicated that I believed the risk of breaking anyone here was really quite low. Logging like this is how we've made clear determinations in the past about whether a change is likely breaking but I think this is one case where we can likely base the decision off judgement.

Okie dokie, lemme close this and try to merge the other change in then. :-)


Error when applying CustomScriptExensions

What happened? Provide a clear and concise description of the bug, including deployment details.
After the successful deployment of an hostpool with the AVDAccelerator you can not deploy another CustomerScriptExtension to the session hosts.
The deployment will fail with the error below.
The deployment will work if you uninstall the CustomScriptExtension which was deployed through the accelerator.
Please provide the correlation id associated with your error or bug.
{"code":"DeploymentFailed","target":"/subscriptions/SUBCRIPTION-ID/resourceGroups/RESOURCEGROUPNAME/providers/Microsoft.Resources/deployments/Microsoft.CustomScriptExtension-20240916121334","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see
https://aka.ms/arm-deployment-operations
for usage details.","details":[{"code":"OperationNotAllowed","message":"Cannot update handlerVersion or autoUpgradeMinorVersion for VM extension 'CustomScriptExtension'. Change is in conflict with other extensions under handler 'Microsoft.Compute.CustomScriptExtension', with typeHandler version '1.10' and autoUpgradeMinorVersion 'True'."}]}
What was the expected outcome?
No response
Relevant log output
No response

@BenMartinBaur  thanks for your feedback, we are reviewing it.

@BenMartinBaur the version we are using in AVD LZA is 1.10.17, you can only have one version of the Custom Script Extension applied at a time.
The following is a snippet of the extension properties:
ResourceGroupName       : <RGName>
VMName                  : <VMName>
Name                    : AzureFilesDomainJoin
Location                : <location>
Etag                    : null
Publisher               : Microsoft.Compute
ExtensionType           : CustomScriptExtension
TypeHandlerVersion      : 1.10
Id                      : <ID>
PublicSettings          :
ProtectedSettings       :
ProvisioningState       : Succeeded
Statuses                :
SubStatuses             :
AutoUpgradeMinorVersion : True
ForceUpdateTag          :
EnableAutomaticUpgrade  : False
InstanceView            :

However, you can run multiple custom scripts by updating the existing extension with a new configuration or by removing and reapplying the extension with the updated script.
Options for Running Multiple Scripts

Update Existing Extension: Modify the configuration of the current Custom Script Extension to include the new script.
Reapply Extension: Remove the existing Custom Script Extension and then reapply it with the new script configuration.

The following is an example of updating the script in the extension:
Set-AzVMExtension -ResourceGroupName <ResourceGroupName> -VMName <VMName> -Name CustomScriptExtension -Publisher Microsoft.Compute -ExtensionType CustomScriptExtension -TypeHandlerVersion 1.10 -Settings '{"fileUris": ["<URL_to_script>"], "commandToExecute": "./<script_name>.sh"}'


Defective regex search (find in files ("Ctrl + Shift +F"))

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.71.0
OS Version: Windows 10

Steps to Reproduce:

Create a Folder with a file that contains consecutive multi-line comments, such as:

/*test1*/
/*test2*/

Open the concerning folder with VSCode and make sure the file is not yet opened in the editor.
Go to find "Find in files" ("Ctrl + Shift +F")
Activate usage of regular expressions for the search
In the search field insert the following regular expression to search for multi-line comments:
(^[\s\t]*)\/\*((?!\*\/)(.|\n))+\*\/
In the replace field insert a string like
TEST
Search or Click "replace all"
Preview and final result becomes

TESTTEST
/*test2*/

However, expected result is

TEST
TEST

Repeat the steps 1 - 7 above, but this time with the file opened in editor (do twice step 7: search and/or "replace all") or, alternatively, do steps 1 - 7 directly in the editors search field ("Ctrl + F")
Now, the obtained and expected result are consistent (see step 9) !

This appears to be a very serious bug when working with multiple (many) files.
Also it raises suspiscion, that other mult-line searches and replacements might be defective too.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

The bug remains in 1.71.0 .

Sorry for the trouble, this is https://github.com/microsoft/vscode/issues/131507


[feature] Enable Image link & alt rendering just like anchor rendering

Version and OS
<IP_ADDRESS> via Docker-compose on Linux
Is your feature request related to a problem? Please describe.
Changes in the image links/alt are not detected.
Describe the solution you'd like
Just like we render anchor text by enabling in the global filter, if we can add an option to render img src link & alt text then that will serve the purpose.
Describe the use-case and give concrete real-world examples
There are many websites that have Images that don't have links or text associated with them these image changes are never detected but if we render the alt & img scr tag url then the problem can be solved.
Additional context

If this can be limited to per watch filter instead of global filter then this would be even better.

That's a good request, I wonder if it should be ON by default for new watches?

That's a good request, I wonder if it should be ON by default for new watches?

As most of the users would be used set their triggers without image watches, I suggest keeping it OFF by default, rest the call lies with you! :)

I need both anchor and image, but per watch filter will be great.


Refactor AWQ support

This PR is intended to streamline the development of supporting AWQ weight quantization for new models and make it easier to maintain. Posting here as a draft for review.

Minimizes dependency on llm-awq code
Integrates quantized linear into existing tensor parallel layers
Decomposes quantized weight loading logic where possible
Support tensor parallelism

Special thanks to @robirv938, @ri938, and @casper-hansen for making lots of progress on AWQ support

closing because this is now implemented in the main repo:)


Refactor migrating docs to make them clearer.

Summary

This pull requests removes the confusing brackets system for the migrating guide and instead just puts everything into two sections - Changes and Removals. An Additions section will be added eventually detailing the new interactions support.
If a dev wants to find something specific within the guide, they can just use the sidebar to find it quickly.
Checklist

[x] This PR is not a code change (e.g. documentation, README, ...)

yea i mostly just copied from the dpy gist, im gonna download and check if this works first

yea i mostly just copied from the dpy gist, im gonna download and check if this works first

If you tell me how to test it then I'll do it myself

Additions should not be added as this is not breaking changes.

Additions should not be added as this is not breaking changes.

OK 👍

on windows powershell I cd into the docs dir then do .\make html, then you find html in the _build/html dir
I dont know how I set this up actually


ISPN-12607 Only compute the accurate size when enabled

https://issues.redhat.com/browse/ISPN-12607
Please do not close the issue, I have not yet implemented the approximate size metrics that are supposed to always be available.
ISPN-12607 Only compute the accurate size when enabled

In clustered cache stats
In REST cache details

ISPN-12607 Only report client size in Micrometer integration
ISPN-12607 Use sizeAsync in KeyValueStoreImpl
ISPN-12607 Deprecate getTotalNumberOfEntries()
ISPN-12607 Use dynamic stats update threshold

Merged, thanks


analytics.js and key

Hey, using Segment as suggested in the docs, how did you figure out getting your Segment write key into the vendors?
Thanks!

Hi, thanks for your interest in this library.
Trying to understand your question,
if you mean analytics vendor name by key,
In the case of Google Analytics,
key name is defined here
https://github.com/segment-integrations/analytics.js-integration-google-analytics/blob/master/lib/index.js#L35
which is set here
https://github.com/segmentio/analytics.js-integration/blob/master/lib%2Findex.js#L51
and used here
https://github.com/segmentio/analytics.js-core/blob/master/lib%2Fanalytics.js#L132
and would be used in your vendor file like this example
https://github.com/nfl/react-metrics/blob/master/examples%2Fvendors%2FGoogleAnalytics.js#L86
Does it answer your question?

@taak77 apologize for lack of clarity. I guess my challenge is, I use Segment so I don't have to write and store my individual tools' keys. One key, Segment's, and it will push to everything. I was wondering if you have a suggestion for how to set it for analytics.js given many of the community has been complaining about a AMD solution https://github.com/segmentio/analytics.js/issues/398 versus the getting your own analytics.js file via their script and your key.

@mmahalwy ok, i think i understand your question now.
If you bundle analytics.js, you need to call analytics.initialize manually and pass the configuration by yourself, so you can't take advantage of Segment console to enable/disable integrations w/o code change.
if you load analytics.js from their CDN with your key, analytics.js will automatically reflects the integration settings from your Segment console.
So i would load analytics.js from their CDN.


SARAALERT-1311: Accessible Reports Table

Description
Jira Ticket: SARAALERT-1311
This Pull Request adds Aria-Labels to the Reports Table on the Patient page. This makes the table easier to access using screen reader technology. The aria-labels are not exact 1:1 representations of the DOM. If they were, using the table would be very clunky. Instead, they are summaries of each row, formatted to be easily understood.
The easiest way to test screen-reader capabilities is to download the WAVE Chrome Extension.
If you WAVE the Patient Page, you should see the newly-created aria-labels
Important Changes
CurrentStatus.js

The changes here slightly improve the accessibility of the Header. Previously, the Notification Status would only be shown visually (without any screen-reader functionality).

CustomTable.js

Adds the ability for the programmer to pass in an optional prop of rowAriaLabels to provide better accessibility going forward.

AssessmentTable.js

Generates the ariaLabels for the Reports Custom Table. The code here is pretty well documented.

Checklists
Submitter:

[x] This PR describes why these changes were made.
[x] This PR is into the correct branch.
[x] This PR includes the correct JIRA ticket reference.
[x] Code diff has been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] If UI changes have been made, Chrome Dev Tools Lighthouse accessibility test has been executed to ensure no 508 issues were introduced.
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[x] Test fixtures updated and documented as necessary

@sgober  :

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code
[ ] If applicable, you have tested changes against a large database, and considered possible performance regressions

@hackrm  :

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code
[ ] If applicable, you have tested changes against a large database, and considered possible performance regressions

@tstrass  :

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code
[ ] If applicable, you have tested changes against a large database, and considered possible performance regressions

This PR adjusts behavior that doesn't follow best accessible practices. A follow-up PR will be submitted later that better addresses these features.


Can't verify license request signature; either the platform is wrong or the key has changed!

The title says everything
Windows 10
Google Chrome 87.0.4280.88 (Official Build) (64-bit)

SOLUTION:- ROLL BACK YOUR WINDOWS TO OLDER VERSION(2004)


Bug: after deleting an account it's almost impossible to use OpenSauced again

Describe the bug
While doing some onboarding tests, I tried deleting my account to be able to re-connect and re-do the onboarding process, but noticed that after deleting my account the platform is virtually inaccessible.
Immediately after deleting my account, the following URLs all throw the same error:

Feed and Explore page --> https://app.opensauced.pizza/feed
User Profiles --> https://app.opensauced.pizza/u/bdougie
Repo Pages --> https://app.opensauced.pizza/s/meta-llama/llama3
etc.

After deleting site cookies
I was able to at least use the public pages (see URLs above), but as soon as I tried clicking on "Connect with GitHub", the application would break again without letting me reconnect
Why is this a problem?
If a churned user ever wanted to come back to use OpenSauced, we are making it impossible for them to do so. Ideally, they should still be able to navigate the page as a non-logged in user, and if they wanted to -- connect their github accounts again.
Steps to reproduce

Go to User Settings
Click on "delete account"
After confirmation, try to navigate to https://app.opensauced.pizza/feed or any other public URL
See error message
Delete cookies
You should be able to navigate the site as usual
Try clicking on "Connect with Github"
Get error screen again

Thanks @vivitt. We'll take care of deleting your account manually so you can reconnect, and look further into this issue.
What trouble were you having to need to delete your account?

Hi @brandonroberts, sounds good, thanks!
I couldn't see my profile picture and my GitHub activity, and navigating to my user page throws a 404 error. As I didn't have previous activity on my account, I tried deleting it to see if it would solve the issue.

@vivitt I removed your user account, so you can connect again and see if its resolved


Use an array of InstanceNames

Draft PR of a change to use an array of InstanceNames to identify joysticks instead of a single InstanceName, based on a report in Discord: https://discord.com/channels/608690978081210392/1313961757672472687

Fun exercise but confirmed not needed :)


Docs needed for testing/using Webhooks

I've added docs in the README for the example site I created on how to setup webhooks, if you want to copy or borrow them for the DSP docs.

I have found ngrok immensely useful.


[CHORE] Update code syntax

Sorry, tried to open a PR on my forked repo. Ended up creating it here instead... 😅


clean(df) throwing 'smart_int' is not defined error.

if smart_int is replaced by is_numeric it's not throwing error.

No longer relevant


Service pages are not creating the titles properly

Currently the page title is not set

This is because meta data is not getting passed into the services pages properly.


We should re-use the NewTestBlueprint() constructor in the testutil package. But the current implementation in testutil looks a bit rigid

Ideally, we should re-use the NewTestBlueprint() constructor in the testutil package. But the current implementation in testutil looks a bit rigid. Maybe in the future we can add better builder interfaces to them.
E.g.,
package testutil

 // without any embedded default action
func NewTestBlueprint() *crv1alpha1.Blueprint

func BlueprintWithAction(blueprint *crv1alpha1.Blueprint, action *crv1alpha1.BlueprintAction) *crv1alpha1.Blueprint

func ActionWithArtifact(action *crv1alpha1.BlueprintAction, artifact *crv1alpha1.Artifact) *crv1alpha1.BlueprintAction

func ActionWithPhase(blueprint *crv1alpha1.Blueprint , phase *crv1alpha1.BlueprintPhase) *crv1alpha1.BlueprintAction

Originally posted by @ihcsim in https://github.com/kanisterio/kanister/pull/1337#discussion_r844485848

Valid 🚀

:rocket:


Pull command fails with an invalid zip file

After https://github.com/massmep/env/commit/fac98b4da0412e97ffd0387433f471b48478b262, pull.go now properly handles failures when pulling. However, the command itself is still failing periodically, with zip: not a valid zip file.

Looks like CheckAsyncRetrieve in lib/retrieve.go returns an empty value sometimes, and other times, returns a well formatted value. Checks should be added to handle the empty value- maybe continue waiting, as opposed to stopping prematurely?

Temporary solution is to keep callingCheckAsyncRetrieve  until a valid value is returned, mostly to save the end user the trouble of repeatedly calling pull.

Function will return if an error code, or an error message appears in the returned data.

Changes made, and pushed. CheckAsyncRetrieve may want to return an actual error now, rather than an implied one.

Changes made in https://github.com/massmep/env/commit/5f328f7feb3884f282eb779fb00fe28665086624

Next step is for CheckAsyncRetrieve to properly return error objects as opposed to an implied error for clarity.


Problem with specifying run name

I created the summary writer object like follows:
self.writer = SummaryWriter('logs', self.name + '_' + datetime.now().strftime('%D-%T'))
Scalars I render in multiple experiments end up displayed in single run named '.', so I can't distinguish between experiments. I used tensorboard packed with tensorflow-1.1 and tensorboardX-1.0

http://tensorboard-pytorch.readthedocs.io/en/latest/tensorboard.html
So if you pass something to the first argument (which overrides the default), the second argument will have no effect.
For your case, you can use SummaryWriter('logs/' + self.name + '_' + datetime.now().strftime('%D-%T')). And be care with the slashes or colons.

oh, sorry. Should've read the docs more carefully. Works now.


Add Photon OS support

Support for Linux based platform PhotonOS

Make netmgr calls to manage the Photon OS network

Signed-off-by: Dheeraj Shetty<EMAIL_ADDRESS>

@cppforlife Added the tests for the code changes

@cppforlife Please let me know if there is anything that I need to do from my side.

Does this mean we should not write the VMware Copyright in this repo at
all?

correct, all of this code is copyrighted by CFF (
https://github.com/cloudfoundry/bosh-agent/blob/master/NOTICE#L1)
On Fri, Mar 16, 2018 at 2:48 PM, Dheeraj<EMAIL_ADDRESS>wrote:

@DheerajSShetty commented on this pull request.
In platform/net/photonos_net_manager.go
https://github.com/cloudfoundry/bosh-agent/pull/159#discussion_r175222137
:

@@ -0,0 +1,233 @@
+// Copyright © 2018 VMware, Inc. All Rights Reserved.
+// SPDX-License-Identifier: Apache License 2.0

Hi Luan,
May I know where should I add these CopyRights? Does this mean we should
not write the VMware Copyright in this repo at all?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cloudfoundry/bosh-agent/pull/159#discussion_r175222137,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALV90kRygxdhRgPStp6dpw-E2ZC_6aeks5tfDMRgaJpZM4SAyCy
.

I will remove the Copyright

@cppforlife @luan I have removed the CopyRights from the file

🔗 Pivotal Tracker, Story #155951359

Certificate manager calls a script managed by PhotonOS. Added tests for the method GetConfiguredNetworkInterfaces()

Squashed changes

I have added a script to PhotonOS which does certificate management. Also made sure the tests pass.
I have squashed changes and named it "Add PhotonOS support"
Please let me know if there is anything to be changed.

Closing due to inactivity. Feel free to open again.


Rancher deployed Fleet doesn't persist workspace changes

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Deploy a k8s 1.18 cluster using custom nodes.
Create a new Fleet workspace.
Move cluster to new workspace.
Upgrade k8s to 1.19

Result:
Cluster has moved back to the fleet-default workspace in the UI.
Expected Result:
Cluster should stay in the workspace it was moved to
Other details that may be helpful:
Have tested adding a clusterID and upgrading the fleet-agent app to use that but still results in the cluster moving back to fleet-default
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.5.6
Installation option (single install/HA): HA

gz#15537

I am not able to reproduce this issue. What I did:

Create a custom k8s 1.18 cluster in rancher.
Create a new fleetworkspace w1, assign cluster to w1.
Upgrade cluster to 1.19
Cluster stays in w1 workspace.

Let me know if there are other details that can help me reproduce this issue.

@StrongMonkey my bad with the repro instructions sorry.  It appears that this is only happening when you use RKE templates.  So following your steps above beginning at 3:
3. Convert custom cluster to RKE template.
4. Create new revision with new k8s version
5. Apply new revision to the custom cluster
6. Cluster has moved back to fleet default workspace.

The bug is reproduced with Rancher server rancher\rancher:v2.5.6.
Steps:

Deploy a k8s 1.18 cluster using custom nodes.
Create a new Fleet workspace.
Move cluster to new workspace.
Convert custom cluster to RKE template.
Create new revision with new k8s version
Apply new revision to the custom cluster

Result:
Cluster has moved back to fleet default workspace.

The bug fix is verified with Rancher server rancher\rancher:master-head version 2dca0c6 and rancher\rancher:v2.5-head version 51253e5
The workspace is copied when cluster is upgraded using RKE template. Cluster remains in new workspace.

Tested an upgrade use case for this issue.
Steps:

Deploy Rancher v2.5.6
Deploy a k8s 1.18 cluster using custom nodes.
Create a new Fleet workspace.
Move cluster to new workspace.
Convert custom cluster to RKE template.
Create new revision with new k8s version (1.19)
Upgrade Rancher setup to v2.5-head
Apply new revision to the custom cluster

Result:
The workspace is copied when cluster is upgraded using RKE template. Cluster remains in new workspace.


website content changes modified for v0.12.0

Description

Changes made to 0.12.0 version in the main page content.
Whats new section has 0.12.0 version added.

Don't update submodules

I will try again. Actually, I did not update those two sub modules, I didnt add them to the commit as well, but for some reason nnvm and ps-lite got added.

I have created a new PR - https://github.com/apache/incubator-mxnet/pull/8478 not commit the submodules. You can discard this PR.


Timelapse Animation Feature

Describe the solution you'd like
An option to animate the 3D graph based on the creation date of notes (in the same way that the 2D graph can generate an animation)
Additional context
I would like to be able to visualize the time-based generation of the 3D graph, perhaps modifying the perspective as the timelapse animation occurs.
Thanks for considering :)

That would be great


Handling different torrent names on trackers

Hi there!
I recently joined a new tracker, and I've put the cross-seed to use. To my surprise, cross-seed did not find any torrent available for cross-seeding, even though I could see them on the listed torrents page.
The only difference was that if the original release was named (for example):
The.Very.Cool.Show.S01E01.And.A.Nice.Episode.Title.1080p.WEB-DL.DDP5.1.x264-GR0UP
On this tracker it was listed as:
The Very Cool Show S01E01 And A Nice Episode Title 1080p WEB DL DDP5 1 H 264 GR0UP
So dots and dashes have become spaces, x264 was changed to H 264 (or H.264) but the file was exactly the same, and it was listen in the description/NFO. Don't know why this particular tracker would name all the releases this way, but it prevents cross-seed to catch them properly.
This also becomes problematic if the torrent names have been altered (looking at you, eztv). If there's a [eztv.re] at the end of the torrent name and the files in both versions are exactly the same (be it packed or unpacked) – cross-seed does not find them.
Is there any logic in place to remedy that?

This tool should handle spaces, dots, dashes, etc but wont take into account nfo files and the such.  I think there's an option to allow some variance of size and I think @mmgoodnow talked about making it a bit more flexible regarding folder structure and such.  Basically, look thru the existing issues here (open and closed) and you'll find people already discussing what you're seeing

Oh, absolutely; I imagine handling NFOs in addition to everything would be a pain, so it's outside the scope – and righfully so. It's just the naming conventions to catch all possible cross-seeds.
Thanks!

a few things:

you can check what's causing the rejections in the verbose logs. There are no checks for the name a torrent was listed as on the indexer, but there is a check for the file trees. My guess is that it's getting caught up there, and that there actually is a difference in the file/folder names, which means that we'd need to open the can of worms that is renaming files in your torrent client in order for the cross-seeding to work.

cross-seed will generally not work as well with public trackers due to many common repackaging and renaming practices. It was designed primarily for private trackers, which have more strict naming conventions and enable tools like this to exist.

All that said, @akesher123 has been working on this in #300


drivers: sdhc: set 'sdhc_driver_api' as 'static const'

This change marks each instance of the sdhc_driver_api as static const. The rationale is that sdhc_driver_api is used for declaring internal module interfaces and is not intended to be modified at runtime. By using static const, we ensure immutability, leading to usage of only .rodata and a reduction in the .data area.
Additionally, it's worth noting that the directory drivers/sdhc/sdhc_cdns/ might have been added unintentionally, as CMakeLists.txt is searching for the files located outside this directory.

@danieldegrasse Already split the PR into two separate commits, thanks.

@danieldegrasse, since this PR https://github.com/zephyrproject-rtos/zephyr/pull/67727 already addressed https://github.com/zephyrproject-rtos/zephyr/pull/66996/commits/0626d7fe03f450146a28e3dd354744d4a5101014 so I just update to remain just one commit.


hexToBytes should accept and trim strings with leading 0x

This started with testing a simple Clarity contract that can stack its own STX through pool delegation.
The Short Story
Would there be an issue if the hexToBytes function were to check if the string starts with 0x, and remove it before processing the string?
Happy to submit a PR! :rocket:
The Long Story
There were two function parameters that needed to be (buff 1) and (buff 20) to represent the pox address in delegate-stx.
The hex values were each stored in a constant:
(incorrect code below for illustration)
const poxVer = "0x01";
const poxHash = "0x13effebe0ea4bb45e35694f5a15bb5b96e851afb";

My first instinct was to use bufferCVFromString() on these two values, but the buffers were not the correct length as they were literally processing the string and returning (buff 3) and (buff 40). This made makeContractCall() fail with the tx options.
Next step was @friedger's suggestion to use bufferCV() and hexToBytes(), and after passing the string the contract call would be created but the broadcastTransaction() step would fail due to BadFunctionArguments.
After updating the constant to remove the leading 0x everything worked as expected, but it was quite the fight to get there and identify each problem.
(correct code below)
const poxVer = "01";
const poxHash = "13effebe0ea4bb45e35694f5a15bb5b96e851afb";

Relevant TX:
https://explorer.stacks.co/txid/0xdbbecf8113b530bd12ca67c425cc1c27a0bf7916ded65e106cf0ecc8fb28c75a?chain=mainnet

yeah would be helpful! please feel free to create a pr :)

Based on the discussion in hirosystems/clarinet#786 and my notes in the original issue, I think it'd be nice if bufferCVFromString() would check for and pass along the hex string as-is.
Maybe something like this in bufferCV.ts? Can add to the open PR.
export const bufferCVFromString = (string: string): BufferCV =>
  string.startsWith("0x")
    ? bufferCV(hexToBytes(string))
    : bufferCV(utf8ToBytes(string));

If we propose using 0x as marker for hex encoding, we should be consistent and do it all over the library and not allow non prefixed hex strings.
For the developers, it is confusing how to handle hex strings.
I'd propose bufferCVFromHexString


Test packages are installed

Adds a unit test that checks to see if any packages that are referenced in .R source files (via library(), require(), requireNamespace(), :: or :::) are not installed.
Runs the test during CI/CD build.
I guess this could replace the check in the Dockerfile (using check.R). Which is good because you have to remember to add files to the Dockerfile in 2 places. Now the unit test will tell you what is missing.
Outside of CI/CD, you can run the tests like this:
R -q -e 'testthat::test_dir("app/tests")'

I encourage you to squash all the fiddly little commits if you merge this. 😀

Agreed, added one more commit to take that out.

looks like the build failed from the CI above, but on the build logs viewer it looks like it passed?

Yeah, that was a spurious failure. It has built successfully since then but github is not picking up on that for some reason.

woops, i forgot to squash, sorry about that. hope thats okay

No worries!


feat(deps): update icr.io/ext/sysdig/agent docker tag to v13.2.0

This PR contains the following updates:

Package
Update
Change

icr.io/ext/sysdig/agent
minor
13.1.1 -> 13.2.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.25.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Notebooks are returning NetCDF objects rather than Xarray objects

Description
Since last update, using the attribute resp.get(asObj=True) returns NetCDF4 objects instead of xarray on my machine. Tested in notebooks and in pure python script.

@huard
Could it be that the new converter tools in Birdy 0.6.0 are causing this? It used to return xarray objects but I am now getting just ordinary NetCDF objects.

@richardarsenault Yes, correct. I did some refactoring and did not notice the "converter checker" did not find xarray anymore. Will fix rapidly.

Works now with the current version, thanks


Windows 10 bundle install (ruby 2.4.2) problem

Operating system: ✍ Windows 10
Last upstream commit (run git log --author="Robert Lord" | head -n 1): ✍ cf29f6786c288b6111239b8e8b211f8ae2fbc4c3
Browser version(s): ✍ Firefox 56.0.2
Ruby version (run ruby -v):  ✍ 2.4.2

✍ bundle install problem with ruby version 2.4.2 on windows
Gem::InstallError: nokogiri requires Ruby version < 2.4, >= 1.9.2.
An error occurred while installing nokogiri (<IP_ADDRESS>), and Bundler cannot
continue.
Make sure that `gem install nokogiri -v '<IP_ADDRESS>'` succeeds before bundling.

After some 'google' investigation I use uru to install Ruby version 2.3.3. After that I install DevKit.
Use uru to select ruby 2.3.3 and bundle install command successfully finished.
https://github.com/oneclick/rubyinstaller/wiki/Development-Kit

:+1:


automatic generete keys in migration

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no

Tests pass?
yes

Fixed issues
not found

This is very risky behavior. The algorithm for generating key names can never change, because you will not be able to delete the existing keys. The same if the name of a table or column will be changed.

I agree with @rob006. It is better to name keys yourself in this case.

Thanks for the pull request anyway. I appreciate it.

I use it in real project and all right.
If you whant to generete key himself - you can.
If you create migration with revert - you can use revert methods support this methenism.
Even if the algorithm for generating the name change, it will change the same everywhere. Otherwise, it will not be programming. So the problems can not arise.
A very short discussion of such a significant simplification, which is absolutely not hurt the existing mechanism. (

Even if the algorithm for generating the name change, it will change the same everywhere.

But it will not change existing keys names and new algorithm will generate a different name than when key was created.

Well, probably algorithm won't change but the thing is that you can't have 2 keys with the same name and in this case it could go bad... Need more time to check all cons and pros.

@rob006

But it will not change existing keys names and new algorithm will generate a different name than when key was created.

Is the existing scheme allows you to do this?
@samdark

Well, probably algorithm won't change but the thing is that you can't have 2 keys with the same name and in this case it could go bad... Need more time to check all cons and pros.

A khow this. And The proposed mechanism solves this problem. The key name is always generated by the following rule: "$type_$tablePrefix_$tableName_" . implode('_', $columns)

One more thing. There's a limitation on FK name length.

Is the existing scheme allows you to do this?

I do not understand your question. Currently I, as a developer, decide about the name of the key, so I know it and I can always use it. In your solution I do not know the name of the key that I create - it dependents on the automagic that generating key name. So if I create a key, and after a year I want to delete it, then if in the meantime the algorithm that generates the key will change, I will not be able to do that because the migration will generate a different key name than a year ago. The same thing happens if in the meantime I change the name of the table - existing key name will not change and will use previous table name.

I know. And The proposed mechanism solves this problem.

No, it doesn't. You can still have combinations of tables and columns names that will create the same key name.
Migration::addForeignKey(null, 'test', ['a_b', 'c'], ...);
Migration::addForeignKey(null, 'test', ['a', 'b_c'], ...);

@samdark

One more thing. There's a limitation on FK name length.

With automatic generation if FK length will be wrong - there will be the same as now, if you manually write the same length.
@rob006

Currently I, as a developer, decide about the name of the key, so I know it and I can always use it.

Automatic generate is option. If you whant to decide about the name of the key - you still can do this. Moreover, you can get the current key name from the method getKeyName($type, $table, $columns)

So if I create a key, and after a year I want to delete it, then if in the meantime the algorithm that generates the key will change, I will not be able to do that because the migration will generate a different key name than a year ago.

And what are you doing now to remove the old foreign key? You will find it in the database. And you can delete it with old mechanism if you can not do it with the help of automatic generation.

The same thing happens if in the meantime I change the name of the table - existing key name will not change and will use previous table name.

If the table name changed - you need to hand in any case take care of it. To do this, there are 2 ways: you can regenerate all foreign keys in this table in accordance with the automatic generation, but you can just use the old mechanism.

No, it doesn't. You can still have combinations of tables and columns names that will create the same key name.

If you use such names of the columns in a table, then, sorry, but there's something wrong with you. Consider this - the same as to take into account the fall of a meteorite on your computer.
I suggested this pull request because very successfully using this path itself. And this saves time for the creation of indexes and keys.

With automatic generation if FK length will be wrong - there will be the same as now, if you manually write the same length.

Nope. Limitations are known so generation could be adjusted to fit names into the length.

@samdark

Nope. Limitations are known so generation could be adjusted to fit names into the length.

I do not understand what you mean. The same problem existed before my code. I did not decide it. I did not create it - it just is.

And what are you doing now to remove the old foreign key? You will find it in the database.

No. I will find key name in specified migration code - in many cases I don not have access to database of all installations. If application has 5 instances, each one could run specified migration in different time and have different key names. This behavior breaks main migration purpose - represents specified state of database. If result of migration depends on time when it is run, it means that something is wrong. This is the same type of solution like magic_quotes in PHP - it was intended to simplify common operations, but turned out to be completely unreliable and using this was a bad practice.

If you use such names of the columns in the One table, then, sorry, but there's something wrong with you.

It was only a example, use your imagination. :) Assuming that your solution is bulletproof and no one ever will create a database that will break it, is simply naive. There already were similar problems with migration names (#10876), so I'm sure that same issues will return also in this case. But this time you can not ever fix this, because any change in the algorithm will break existing migrations that rely on this feature.
There is also existing and more reliable solution for this: http://www.yiiframework.com/doc-2.0/guide-db-migrations.html#foreign-keys

@rob006

No. I will find key name in specified migration code - in many cases I don not have access to database of all installations. If application has 5 instances, each one could run specified migration in different time and have different key names. This behavior breaks main migration purpose - represents specified state of database. If result of migration depends on time when it is run, it means that something is wrong. This is the same type of solution like magic_quotes in PHP - it was intended to simplify common operations, but turned out to be completely unreliable and using this was a bad practice.

OK. In your case, you can use the old mechanism. My pull request is - it is an option for more localization projects.

Assuming that your solution is bulletproof and no one ever will create a database that will break it, is simply naive

My wife manages to kill a Linux system in a couple of months. For talented people, nothing is impossible - then I agree with you.

There already were similar problems with migration names (#10876), so I'm sure that same issues will return also in this case. But this time you can not ever fix this, because any change in the algorithm will break existing migrations that rely on this feature.
There is also existing and more reliable solution for this: http://www.yiiframework.com/doc-2.0/guide-db-migrations.html#foreign-keys

I never touched any of the existing mechanisms. Only the added option of automatically generating, if key name set null - that's all.

I've meant that if we'd ever adopt this generation it should not generate names which are out of maximum key name length database limit.

I've meant that if we'd ever adopt this generation it should not generate names which are out of maximum key name length database limit.

OK. I will fix it.

The PR seems to be abandoned.


1.1.0 Does Not Work - Wrong AMI Architecture

There appears to have been a PR #35 that was merged in, but no new release was created that actually allows the use of this module in the terraform registry.
I know this because I am currently trying to use this module and am getting an obscure error in the activity log of the ASG. This error led me to do some investigation and the AMI that was selected for the launch configuration is arm64 architecture -- which is not compatible with an instance type of t2.nano.
I believe all that needs to be done is to create a new GitHub release that includes the recently merged changes to resolve this, unless I am misunderstanding.

You were right, I forget to create the new release.
The change is now available on the release v1.1.1


Don't export fuselage and wings segmentwise.

Description
Fixes #897. See description in issue.
How Has This Been Tested?
existing unit and integration tests
Checklist:

[ ] A test for the new functionality was added.
[x] All tests run without failure.
[x] The new code complies with the TiGL style guide.
[ ] New classes have been added to the Python interface.
[ ] API changes were documented properly in tigl.h.

Codecov Report

Merging #899 (5b0903a) into master (8127fbd) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   69.30%   69.28%   -0.02%
==========================================
  Files         295      295
  Lines       24748    24744       -4
==========================================
- Hits        17151    17144       -7
- Misses       7597     7600       +3

Impacted Files
Coverage Δ

src/exports/CTiglCADExporter.cpp
63.80% <50.00%> (-1.33%)
:arrow_down:

src/geometry/CTiglTriangularizer.cpp
85.38% <0.00%> (-1.76%)
:arrow_down:


getNodeRequestOptions does not honor all the https.request options

https://nodejs.org/api/https.html#https_https_request_url_options_callback documents the options for calling https.request but there is a side note about all the possible tls.connect options.

The following additional options from tls.connect() are also accepted: ca, cert, ciphers, clientCertEngine, crl, dhparam, ecdhCurve, honorCipherOrder, key, passphrase, pfx, rejectUnauthorized, secureOptions, secureProtocol, servername, sessionIdContext, highWaterMark

These options are not implemented or possible to set through getNodeRequestOptions,
this makes it impossible to pin a ca / certificate or specific protocols.

@julianhille Since you closed the PR, you probably want to close this issue as well, right? Because I actually think that passing on more request options is a better idea, than using https.Agent. Why? Because you cannot do that, when using an httpsProxy as well. If the cert/key options are set on an httpsProxy, it will be used to authenticate to the Proxy instead of the target server.
I think, because neither the httpsProxy maintainer, nor this repo moves this forward, I will be creating a fork and make the small change there. Projects seem both pretty abandoned.


Clean XML before processing

to pevennt empty  which distracting the calculation

Add normalizer function which clean up all empty


Installed builds should auto-update themselves

This will depend on #112

Alto depends on #763

Nevermind, will use this issue for switching to electron-builder


Relative picture paths not interpreted

From an html file located at :
C:\Users\Test\SHEETS\Test.html
And a picture located at :
C:\Users\Test\SHEETS\FILES\Test\Picture 1.png
The following markdown picture code is not interpreted :
![PictureTitle](FILES\Test\Picture 1.png)
I'm migrating from marked.js to this awesome parser but this is a blocker for me.
I'm working on a local HTML catalog used on a Windows OS.

Spaces are not allowed in URL you should escape or encode those:
example

Oops. My example is not that good.
It does not work with an url without spaces, but if i replace "" by "/" in it, it's ok.
I think the problem is related to my Windows local paths.

I think it's better to read commonmark spec about all edge cases http://spec.commonmark.org/0.28/#links.
PS. marked does not follow CM spec, but migration should not be too difficult.

Thanks for this spec, i'll update my Mardown code so.


Make sure all intended headings have anchors

Fixes the code part of https://github.com/cert-manager/website/issues/484

/assign @jakexks

/assign @maelvls

Good idea. I only assigned jakexks because the bot told me to: https://github.com/cert-manager/website/pull/491#issuecomment-808730877

Thanks for the fix!! 🙏
/lgtm
(Jake is on vacation I think 😅)

/approve


Image Segmentation in Isaac Gym (the Omniverse version)

Hello,
Is there any support to be able to use the Image Segmentation capabilities from Isaac ROS Image Segmentation in parallel environments in Omniverse Sim/Gym? The ROS2 layer would have to be stripped away as it's not appropriate for the parallel Gym environments used during the RL training. Is this possible?

Possible, yes, but it would take some work to strip away the ROS 2 layer and integrate the same underlying libraries with Isaac Gym. Alternatively, you can integrate Isaac Gym and Isaac ROS through your own ROS 2 application.

ROS is inappropriate when I have over 10k parallel environments running in
Isaac Gym. The power of Isaac Gym is only fully realized when all code runs
on the GPU. Having ROS in the middle removes the primary performance
benefits of Isaac Gym.
On Mon, Mar 6, 2023 at 1:59 PM Hemal Shah @.***> wrote:

Possible, yes, but it would take some work to strip away the ROS 2 layer
and integrate the same underlying libraries with Isaac Gym. Alternatively,
you can integrate Isaac Gym and Isaac ROS through your own ROS 2
application.
—
Reply to this email directly, view it on GitHub
https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_image_segmentation/issues/15#issuecomment-1456774630,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABAYEB4AUK4SHEWBHE7PZRLW2YXZJANCNFSM6AAAAAAVPCAXBI
.
You are receiving this because you authored the thread.Message ID:
@.***
.com>

Isaac ROS Image Segmentation functions using the underlying PeopleSemSegNet model, which is independently available on NGC here. The model is distributed as a set of .etlt files, which can be decoded into a model engine plan file using tao-converter (available here) and then loaded by any standard inference engine (Triton, TensorRT, Pytorch, etc.).
You should be able to write your own wrapper function in Python, etc. that loads the model into your inference engine of choice encodes input images, runs inference, and decodes the output images.


About yii2 PR 14701

I think
after merge this PR
https://github.com/yiisoft/yii2/pull/14701
we need use
"psr/http-message": "~1.0.0",
too?

In particular: method getHeaders() and corresponding virtual property $headers are no longer return HeaderCollection

i.e. change
https://github.com/rob006/yii2-simple-auth/blob/ed5e107df095c3f3987e69d2e01dac2c86dbce43/src/ActionFilter.php#L100-L104
like
if (!Yii::$app->getRequest()->getHeaderLine($this->headerName)) {
    return false;
}
$token = Yii::$app->getRequest()->getHeaderLine($this->headerName);

or
if (!Yii::$app->getRequest()->hasHeader($this->headerName)) {
    return false;
}
$token = Yii::$app->getRequest()->getHeader($this->headerName);

?

You're right, but this extension does not yet support Yii 2.1 (which is not even released).
There are also other PRs/ideas which may affect this extension, e.g. #14645.
I have to wait until Yii 2.1 will be released, there is no point to try to fix this earlier.

Yii 2.1 will not be released.


feat: Values preserved between view switches

Description

This PR adds a feature. On 'column-review.html', the input values are preserved when switching between table view and grid view.

Related Issues
Closes #317
Testing

[ ] Yes
[X] No, not needed (give a reason below)
[ ] No, I need help writing them

I was unable to write tests for this as it is javascript
Reviewer Focus
This is a small PR, but I need some help to figure out if this is the correct solution.
I decided to move the input values with Javascript and not persist the values when switching views. From my perspective, this is what the user expects... But I can easily be persuaded to change this?
Checklist

For all PRs that are not general documentation

[ ] Tests accompany or reflect changes to the code
[X] Tests ran and passed locally
[X] Ran the linter and formatter
[X] Build has passed locally
[X] Relevant documentation has been updated

When I test it by adding a description in the card view and switch to table view, the description is not shown in the table view. However, the value is preserved in the sense that when I return to card view, it's still there.
So, I'm thinking that this isn't working as expected? :)

You are right. I failed to correctly rename a variable. It works now

Fixed: DataType and Excluded flag are now preserved when switching views


CloudCopy

https://github.com/Static-Flow/CloudCopy

This is actually already covered by aws.exfiltration.ec2-share-ebs-snapshot, since CloudCopy shares the EBS snapshot with an attacker controlled account:

Run "modify-snapshot-attribute" on new snapshot to set "createVolumePermission" to attacker AWS Account


NPM does not running the setup project

What version of Turborepo are you using?
1.0.23
What package manager are you using / does the bug impact?
npm
What operating system are you using?
Linux
Describe the Bug
When I run on terminal npx create-turbo@latest and select NPM as a package manager when I try to run all with npm run dev the terminal crashes on the web app.
npm run dev

><EMAIL_ADDRESS>dev /home/USER/Documents/teste-npm
> turbo run dev --parallel

• Packages in scope: config, docs, tsconfig, ui, web
• Running dev in 5 packages
web:dev: cache miss, executing 2e29dcd43d4559d1
docs:dev: cache miss, executing bb0a8a9dc4fcd3ab

web:dev: ><EMAIL_ADDRESS>dev /home/USER/Documents/test-npm/apps/web
web:dev: > next dev

docs:dev: ><EMAIL_ADDRESS>dev /home/USER/Documents/test-npm/apps/docs
docs:dev: > next dev --port 3001

web:dev: sh: 1: next: not found
web:dev: npm ERR! code ELIFECYCLE
web:dev: npm ERR! syscall spawn
web:dev: npm ERR! file sh
web:dev: npm ERR! errno ENOENT
web:dev: npm ERR<EMAIL_ADDRESS>dev: `next dev`
web:dev: npm ERR! spawn ENOENT
web:dev: npm ERR!
web:dev: npm ERR! Failed at the<EMAIL_ADDRESS>dev script.
web:dev: npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
web:dev: npm WARN Local package.json exists, but node_modules missing, did you mean to install?

web:dev: npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/USER/.npm/_logs/2021-12-25T21_20_42_657Z-debug.log

Expected Behavior
The same when running with Yarn.
To Reproduce
On terminal:
npx create-turbo@latest
// Select NPM as a package manager

Open the path to the directory and run:
npm run dev

I already have a project with Turbo and now I am using Yarn but the company wants to use NPM as default.

What version of node are you using ?
Cause I had this error while using a node version older than 14, after changing it to 16.2 it worked

@Karyum I was using 14.18.2 but when I change to Node v16.13.1 it works. Thanks

It seems my version of NPM. In package.json it's declared to use version equal or above 14 for Node and version equal ou superior 7 for NPM. I was using Node v14 with NPM v6.


Assertions [launcher] Process exited with error code 1

When I run tests assertion errors exit with code 1 rather than continue with step executions
AssertionError: expected 'X' to include 'Y'
[launcher] Process exited with error code 1
I'm also not getting any console report colours compared to execution directly via cucumberjs
My setup if fairly simple:
protractor.conf.js
exports.config = {
  seleniumAddress: 'http://localhost:4444/wd/hub',
  directConnect: true,
  specs: ['test/features/*.feature'],
  // set to "custom" instead of cucumber.
  framework: 'custom',

  // path relative to the current config file
  frameworkPath: './node_modules/protractor-cucumber-framework',

  // relevant cucumber command line options
  cucumberOpts: {
    require: 'test/features/*.js',
    format: "pretty"
  },
  onPrepare: function() {
    browser.ignoreSynchronization = true;
    browser.baseUrl = "http://localhost:3000";
  }
};

stepDefinitions
var chai = require('chai');
var chaiAsPromised = require('chai-as-promised');
chai.use(chaiAsPromised);

var expect = chai.expect;

module.exports = function() {
    this.When(/^I sign in as "([^"]*)"$/, function (arg1, next) {
      browser.get("/");
      // Assertion error here will exit the process
      expect(browser.getTitle()).to.eventually.contain("X");
      element(by.css('[type="email"]')).sendKeys('a@a.com');
      element(by.css('[type="password"]')).sendKeys('password');
      element(by.css('[type="submit"]')).click();
      next();
    });
}

Thanks

The color issue should be fixed by https://github.com/mattfritz/protractor-cucumber-framework/pull/7 v0.3.0
How many features do you have in your suite? If you have only one, the I sign in as ... step will fail which should fail the feature as well and stop execution. If you have more features, it should move on to those after this feature fails. Let me know and I'll take a look.

Thanks for fixing the color.
The other features are not being executed but it just dumps all of them as passed.  I simplified my test, here are the results (all the scenarios should fail as the title is not X,Y or Z)
feature 1
Feature: XY
  Scenario: I want X
    When I want X
  Scenario: I want Y
    When I want Y

feature 2
Feature: Z
  Scenario: I want Z
    When I want Z

step definition:
var chai = require('chai');
var chaiAsPromised = require('chai-as-promised');
chai.use(chaiAsPromised);

var expect = chai.expect;

module.exports = function() {

    this.When(/^I want X$/, function (next) {
      browser.get("/");
      expect(browser.getTitle()).to.eventually.contain("X");
      next();
    });

    this.When(/^I want Y$/, function (next) {
      browser.get("/");
      expect(browser.getTitle()).to.eventually.contain("Y");
      next();
    });

    this.When(/^I want Z$/, function (next) {
      browser.get("/")
      expect(browser.getTitle()).to.eventually.contain("Z");
      next();
    });
};

output:
Feature: XY

  Scenario: I want X   # test/features/test.feature:2
    When I want X      # test/features/stepDefinitions.js:9

  Scenario: I want Y   # test/features/test.feature:4
    When I want Y      # test/features/stepDefinitions.js:15

Feature: Z

  Scenario: I want Z   # test/features/test2.feature:2
    When I want Z      # test/features/stepDefinitions.js:21

3 scenarios (3 passed)
3 steps (3 passed)
0m00.009s
AssertionError: expected 'A Title' to include 'X'
[launcher] Process exited with error code 1

My expectation was for all to be executed with inline errors - here is what happens if I execute via cucumber - I haven't setup selenium so it's just failing on 'ReferenceError: browser is not defined...', but it's reporting errors correctly for each scenario and it's summarising the errors at the end
Feature: XY

  Scenario: I want X   # test/features/test.feature:2
    When I want X      # test/features/stepDefinitions.js:9
      ReferenceError: browser is not defined...

  Scenario: I want Y   # test/features/test.feature:4
    When I want Y      # test/features/stepDefinitions.js:15
      ReferenceError: browser is not defined...

Feature: Z

  Scenario: I want Z   # test/features/test2.feature:2
    When I want Z      # test/features/stepDefinitions.js:21
      ReferenceError: browser is not defined...

Failing scenarios:
test/features/test.feature:2 # Scenario: I want X
test/features/test.feature:4 # Scenario: I want Y
test/features/test2.feature:2 # Scenario: I want Z

3 scenarios (3 failed)
3 steps (3 failed)
0m00.003s

It's hard to tell without the browser object, but I can replicate the issue. Since chai-as-promised returns a promise and does not throw an exception, the callback is not handling failure because it's not being notified.
Try using:
expect(browser.getTitle()).to.eventually.contain("X").and.notify(next);

instead of:
expect(browser.getTitle()).to.eventually.contain("X");
next();

and see if you get better results. If you are using vanilla chai on other steps (without eventually), it should throw an exception instead and fail the step.
Give that a shot and let me know what you find. I don't think this is a bug with the plugin since it is using a standard cucumber reporter, not the protractor reporter.

Hi @mattfritz I was having a problem with protractor-cucumber-framework for which I created an issue on protractor's github (https://github.com/cucumber/cucumber-js/issues/492) I had added what you suggested:
   this.Then(/^I see that the slider has moved/, function (done) {
        browser.sleep(500);
        sliderWidgetPage.getImageAndAttribute(0,'data-url').then(function (attrVal) {
            expect(attrAtX1Time).to.eventually.equal(attrVal).and.not.notify(done);

        });
     done();
    });
```javascript

Although it closes the browser,  but no matter if I "force" the `expect` to fail, it always passes, so it does not works for me! what would you suggest?  please help!

that last done() is getting called immediately and not waiting for the  getImageAndAttribute nor the browser.sleep promises to complete. Your step is done at that point and everything in the then is ignored. There are several ways to do this. If you're using a current version of cucumber that knows about promises you can just return the promise...
    this.Then(/^I see that the slider has moved/, function () {
        return browser.sleep(500).then(function () {
            return expect(sliderWidgetPage.getImageAndAttribute(0,'data-url')).to.eventually.equal('expectedValue');
        });
    });

if not you'll need to use the done callback
    this.Then(/^I see that the slider has moved/, function (done) {
        browser.sleep(500).then(function () {
            expect(sliderWidgetPage.getImageAndAttribute(0,'data-url')).to.eventually.equal('expectedValue').and.notify(done);
        });
    });

Hope that helps

I had removed the browser.sleep() and I left it as this:
   this.Then(/^I see that the slider has moved$/, function (done) {

        expect(sliderWidgetPage.getImageAndAttribute(0,'data-url'))
            .to.eventually.equal(attrAtX1Time).and.notify(done);
        });

And I got this error with both suggestion that you made:
Using the selenium server at http://localhost:4444/wd/hub
[launcher] Running 1 instances of WebDriver
..F

(::) failed steps (::)

Error: Step timed out after 5000 milliseconds
    at Timer.listOnTimeout (timers.js:92:15)

What am I doing wrong?  I had followed also this example:
http://stuff.aftnn.org/acceptance-testing-cucumber.js-protractor/index.html#18
Thanks for your assistance!

Depends on which version you're using of the 2 you posted. If it's the first version then that tells me that getImageAndAttribute didn't resolve within 5 seconds. If you're using the second version where you're returning the promise then you need to remove the done parameter from the function signature as that tells cucumber to wait until it is called.

https://github.com/nathanboktae/chai-dom/issues/33


Update ios.latest-os-version in gulpfile.js

This PR updates the latetst iOS version from 14.2 to 14.3

Nice, thanks @Ein-Tim.


remove bch blockchain explorer from config

Found that BCH notifications were crashing bcmonitor.js to crash and resulting in notifications not reaching clients correctly. Simplest fix for now is to just remove bch blockchain explorer.


Full screen modals

Hi Joe, Thank you for releasing this library, it makes it so much easier to develop turbo apps.
I am wondering how I can achieve fullscreen modals? Currently, I am overriding the controller function like so:
func controller(_ controller: VisitableViewController, forProposal proposal: VisitProposal) -> UIViewController? {

    if proposal.url.absoluteString.contains("/users/sign_in") {
      turboNavigator.modalNavigationController.modalPresentationStyle = .fullScreen
      turboNavigator.modalNavigationController.isNavigationBarHidden = true
    } else {
      turboNavigator.modalNavigationController.modalPresentationStyle = .pageSheet
    }

    return VisitableViewController(url: proposal.url)
  }

But I was wondering if there was a better way to do it. Or if there could be some kind of path configuration option we can add to choose between the different modal display options.
Please let me know if there is a better place for me to ask questions.

That's pretty much exactly how I'm doing it, too!
extension TurboTabBarController: TurboNavigationDelegate {
    func controller(_ controller: VisitableViewController, forProposal proposal: VisitProposal) -> UIViewController? {
        // Signed in or registered - reload tabs and app.
        if proposal.presentation == .clearAll {
            pathConfiguration.reload()
        }

        if proposal.controller == .newSession {
            return NewSessionController(router: self)
        } else if proposal.controller == .newUser {
            return NewUserController(router: self)
        } else if proposal.controller == .signOut {
            return SignOutAlertPresenter(router: self).controller
        }

        modalNavigationController.modalPresentationStyle = .automatic
        return controller
    }

    func session(_ session: Session, didFailRequestForVisitable visitable: Visitable, error: Error) {
        if error.isUnauthorized {
            modalNavigationController.modalPresentationStyle = .fullScreen
            route(Endpoint.newUserSession)
        } else {
            ErrorPresenter.present(error, on: visitable) { session.reload() }
        }
    }
}

Would you like to add some notes to the README on how to do this? Maybe a new "cookbook" section or something could work.

Hi Joe, Thank you so much for sharing that information with me! I would be happy to add that to the README. I will open a PR shortly.

Excellent - thank you!

Hi Joe, I am in the process of writing the "cookbook" section of the README.
I see that you have access to a controller property on the VisitProposal object. Is that something that you add as an extension? I see that you already have such extension code here:
https://github.com/joemasilotti/TurboNavigator/blob/main/Sources/TurboNavigator/VisitProposalExtension.swift
public extension VisitProposal {
    var context: Navigation.Context {
        if let rawValue = properties["context"] as? String {
            return Navigation.Context(rawValue: rawValue) ?? .default
        }
        return .default
    }

    var presentation: Navigation.Presentation {
        if let rawValue = properties["presentation"] as? String {
            return Navigation.Presentation(rawValue: rawValue) ?? .default
        }
        return .default
    }
}

Would you be able to share how you map the "proposal url" to the "controller" enum? I am thinking I would like to add instructions for that as well.
I am thinking it should be something like this:
public extension Navigation {
  enum Controller {
    case `default`
    case newSession
    case newUser
    case signOut
  }
}
public extension VisitProposal {
  var controller: Navigation.Controller {
    if url.path.hasSuffix("/users/sign_in") {
      return .newSession
    }
    if url.path.hasSuffix("/users/sign_out") {
      return .signOut
    }

    if url.path.hasSuffix("/users/sign_up") {
      return .newUser
    }

    return .default
  }
}

Please let me know if this is correct.
Thank you.

Beautiful, Thank you Joe! I will open the PR tomorrow. Looking forward to your review!


puzzleGenerator-maxElder

I made a small piece of code that generates a random puzzle from the given inputs. I have a fair bit of experience coding, including making games with sprig.

Nice! I think this is Blot worthy. You just need to make sure the file has the right metadata.
How would you extend this to make the puzzle pieces more irregular?

I could probably change the connector node piece things to be different shapes if this isn't enough. I'll double check the metadata to make sure nothing is wrong.

It could be developed more but I think you've earned your Blot. Congrats you can order it here.


document the option of manually loading and writing the json metadata

MultiZarrToZarr uses fsspec.open_files to open all files at once. Even though this makes sense for remote filesystems, it fails with a lot of small files on a local filesystem: opening a lot of files at once will exceed the limit for open file descriptors. It is still possible to use MultiZarrToZarr in this case because path can be passed the pre-loaded metadata. This, however, is currently undocumented.
Writing to a file object is also not possible (I was trying to use fsspec's compression support), but translate will return the metadata if it doesn't receive a value for outpath. While this is documented, I didn't immediately understand how to use that so I hope this might make it a bit clearer.

It might be better to change the behavior of both, though: MultiZarrToZarr.__init__ could read the files in batches (if fsspec.open_files supports that), and I think translate should be split into translate and a new write_metadata function: changing the return value based on the input parameter feels a bit strange to me.

MultiZarrToZarr.init could read the files in batches (if fsspec.open_files supports that)

fsspec.open_files returns an OpenFiles instance, which when used in a with context to open all of them at once. However, the instance is also a list, and you can slice or iterate over it, to get the OpenFile (no s!) instances. The actual real file is only opened when these are put in a context:
ofs = fsspec.open_files(...)
batch = ofs[:10]
for of in batch:
    with of as f:
        # use f

Unfortunately, batch is not an OpenFiles instance, but a normal list here (could be fixed), so you can't do with batch and open all the files in the subset at once in a single context.

The following in fsspec appears to fix the comment above, if we want it
--- a/fsspec/core.py
+++ b/fsspec/core.py
@@ -204,6 +204,12 @@ class OpenFiles(list):
                     break
         [s.__exit__(*args) for s in self]

+    def __getitem__(self, item):
+        out = super().__getitem__(item)
+        if isinstance(item, slice):
+            return OpenFiles(out, mode=self.mode, fs=self.fs)
+        return out
+
     def __repr__(self):
         return "<List of %s OpenFile instances>" % len(self)


Bump Dependencies #10872025584

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/10872025584

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Multiple messaging extensions and configuration

When using multiple messaging extensions in the manifest there is no way to configure anyone but the first of the messaging extensions registered in the manifest file.
Is the only solution to deploy multiple Teams Apps just to have multiple different configurations?

@wictorwilen Currently, only 1 message extension per app is supported. You can have multiple commands within the same messaging extension.

True! The setting is on a message extension level rather than command level. Thankss


cache location is required when cache type is "S3"

Found a bug? Maybe our Slack Community can help.

Describe the Bug
When using the complete example, an error is returned stating that the CodeBuild cache location must be set when cache_type is S3.
Expected Behavior
I would expect the cache location to be set using the context's id when using the defaults.
Steps to Reproduce
Steps to reproduce the behavior:

Copy the complete example from this project.
Update region and availability_zones variables to use us-east-1 rather than us-east-2.
Set VPC module to use master rather than 0.25.0 (which is latest) or the version in this example.
Set Subnets module to use 0.39.3 rather than 0.34.0.
Remove/comment out the build_environment_variables in the tfvars file.
Add sensitive = true to container_definition_json and container_definition_json_map outputs.
terraform init && terraform plan

Screenshots
│ Error: cache location is required when cache type is "S3"
│
│   with module.ecs_web_app.module.ecs_codepipeline.module.codebuild.aws_codebuild_project.default[0],
│   on .terraform/modules/ecs_web_app.ecs_codepipeline.codebuild/main.tf line 292, in resource "aws_codebuild_project" "default":
│  292: resource "aws_codebuild_project" "default" {

Environment (please complete the following information):
Anything that will help us triage the bug will help. Here are some ideas:

OS: OSX
Version 11.2.3
Module version 0.63.0

Additional Context
Assumed role in use during terraform plan has permission boundaries which prevent access to regions other than us-east-1.
However, this was the only region provided and the debug logs don't imply a region other than us-east-1 was accessed.

Tried this again with creds which aren’t subject to the same permission boundary and got the same error.
I will dig into these modules again tomorrow and see if I can find the issue. Hoping someone recognizes what might be happening though.

#147 will fix this.


Update README.md

#2 Added here a basic setup example - we should write a detailed guide or an example like this one  maybe over there.

There's already docs for implementing Lucia in Astro. I don't see why need to add duplicate info when the only thing different is the adapter initialization, which is already explained in the README.


Unable to retrieve queue and history items from MediathekArr Downloader

Hi!
freshly installed MediathekArr gives me the following error:
Unable to retrieve queue and history items from Mediathekarr Downloader: Could not convert string to decimal: Unknown. Path 'slots[2].mb', line 32, position 21. (Json snippet '     "mb": "Unknown"<--error-->,')

It seems that files get downloaded, but nothing is reported back to sonarr?

The download client is shown as "unavailable due to errors" afterwards.

This was an error on my part. I misread the docker-compose and entered the wrong values for my environment. After fixing this, this works.

Can you go into detail on what the issue was?

I put the wrong values in my DOWNLOAD_FOLDER_PATH_MAPPING which made strange errors. Fixing my volume mount and DOWNLOAD_FOLDER_PATH_MAPPING fixed most of these problems.

Can you go into detail on what the issue was?

Do you have this issue? If yes, please share your docker compose / unraid settings


[FEATURE] Refresh button when branch changes

Feature Description
Sometimes when reviewing large PRs, reviewers can be reviewing stale data if the branch has been updated since last loading the page. GitHub has a nice little feature that pops up an orange "refresh" button if the underlying branch changes. It would be great if Gitea had something similar.
From zeripath: "there are a couple of things that could be used for this. Probably the best thing to do would be for the webpage to register with the eventsource and get that to listen for the notify"
Screenshots

Yes, eventsource can be used in theory for server-to-client updates. I have the general impression that our eventsource is rather unstable and I think in the long run, we'd be better to switch it to websockets.

Yes, switching to websocket is a final way we need to do.

Honestly when I wrote the eventsource I looked at all of the alternatives and thought that as we only needed server side events  a websocket was not the way to go.

Yes, eventsource can be used in theory for server-to-client updates. I have the general impression that our eventsource is rather unstable and I think in the long run, we'd be better to switch it to websockets.

What evidence do you have that the eventsource is unstable?

Can this not be completed as easily using the eventsource? Or is the idea that we don't want to keep adding to it?

Eventsource works basically fine. Its heavily being used for similar usecases in some projects like woodpecker. But the most sustainable solution would probably be following the graphql (#14721) idea. Adding eventsources / own websocket protocols for such large projects like gitea don't scale in my opinion. If you are really searching for a quick and dirty solution, I would rather suggest to use some kind of polling with setTimeout / setInterval every 3 seconds as those api endpoints already exists.

An uniform websocket service could be used in many pages/features. Gitea should move forward to be more instantly in code review or other collabrations.
i.e. We need to update the new comments when we stay in the issue page, need to see the review comment update and the refresh button on code review page.
EventSource will need server-side long pull technical which belongs to HTTP 1.1. By Websocket, we could send and receive multiple types messages in one page. And because of Golang's high performance, over 1M connection could also be possible.

Any progress on this. Would love to add lazy loading of large pull requests as well. Happy to pull or do some little tasks for ya'll

Any progress on this? Would love to add lazy loading of large pull requests as-well. Happy to pull or do some little tasks for ya'll

I have not heard of any progress yet. I think it's probably important to point out that these three things are separate issues:

Refresh Page notice (this PR) - existing eventsource implementation is fine
Lazy Load diffs (much improved with (https://github.com/go-gitea/gitea/pull/17739 https://github.com/go-gitea/gitea/pull/16829, but also see https://github.com/go-gitea/gitea/issues/12141)
Eventsource -> websocket (new issue?)

I'm up for solving this if the bounty still stands and noone else is working on it?

@maxbol I working

@maxbol I am also working on it

@maxbol I am also working on it

Sse seems fine imo
https://stackoverflow.com/questions/5195452/websockets-vs-server-sent-events-eventsource

Recommended reading if you decide on going the GraphQL route: https://wundergraph.com/blog/deprecate_graphql_subscriptions_over_websockets
And:
https://www.the-guild.dev/blog/subscriptions-and-live-queries-real-time-with-graphql


Release 0.38.0

Adds support for Swift 4.2
Fixes an issue with VisualRecognition CoreML when running on devices with Apple A12 Bionic.

:tada: This PR is included in version 0.38.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

The AssistantV1 gives the following error when i fork this version.
swift-sdk/Source/AssistantV1/Models/CreateValue.swift:18:8: No such module 'RestKit'

Tried to fork this version. Earlier it gave restkit not found error. On "carthage update" it was solved.
Later, on building i got this error.
/swift-sdk/Source/AssistantV1/Assistant.swift:1840:21: Use of undeclared type 'UpdateEntity'

@addu1 I cloned your repo, did a carthage update and had no problem building AssistantV1. Which Xcode version are you using?

@AnthonyOliveri yes it works fine. I don't know what went wrong. It was referring towards conversationv1 UpdateEntity file. So I just removed and wrote it again and selected the Assistantv1 UpdateEntity. Thanks btw, I was also able create react native bridge for iOS with your help.

Glad to hear it @addu1!


Terminal freeze after typing

Windows Terminal version
1.12.10733.0
Windows build number
10.0.22581.200
Other Software
No response
Steps to reproduce

Start Terminal. (cmd or powershell) You can interact with it (move windows, create new tab, go to settings)
Start to type. Terminal is now freeze, you cant interact with it
alt+tab
You can now intaract with it
Type again in the console. Terminal is again stuck

Expected Behavior
No gui freeze
Actual Behavior
Terminal freeze after typing

Might be related to Windows version in some way? The same Terminal build works fine on my desktop with 22000 stable, but not laptop with 22581 dev.

Update: also reproduces on Terminal 1.13 preview.

Same issue on both Terminal and Terminal Preview on 22581.200

Thanks for the report! This is actually already being tracked by another issue on our repo - please refer to #12746 for more discussion.
/dup #12746


recent_topics: Fix buggy scrolling.

The knob of the scroll bar scrolled out of view in both Firefox and
Chromium and on Firefox it even cut off the last entry.
Fixes #15511.

Testing Plan:
GIFs or Screenshots:

Thanks @Gittenburg for fixing this. LGTM.


keyPress Time Question

Since there isn't an official forum to post these noob questions on yet... I'll just go ahead and embarrass myself here. I'm a big fan of the Replit and Kaboom mix so far!
I have beginner questions about how to run an action for a set period of time after a keypress. For example:
keyPress("space", () => {   bill.action(() => {     bill.angle += dt();   }); });
If this could rotate bill for 2 seconds and stop. I tried adding an await wait(2); but get an async function only error but I don't really want it to wait or loop correct.?  I don't think action() take a time argument?
Any help would be most appreciated!

One way to think about it is if you have some variable "running" which is false by default.
in an action you check to see if "running" is true, if so , then do your angle change.
Now when you click the space bar - set "running" to true, and set a wait for some time to set it to false.
every frame, that action will be checking the value of "running" and either keep changing the angle or not.
So what I mean is have some action that runs every frame, but it checks some var to see if it should "run" this frame.
Then just have that var be false by default, and true for some small time frame.
While it's true, your action will run, then stop again when your timer sets the var to false again.

Ah gotcha... thanks so much for the explainer. Makes sense. I wasn't sure if there was a baked-in method that does just that. It would be great to have a Discord or Slack server to chat and share. Maybe down the line.


Using a string with INPUT# seems to change the string length, expected?

I'm trying to make my disk reading routines performant. A file name in the directory of a disk is 16 characters long. When I use INPUT# to read the string, it seems to change the string variable to be around 50 characters big.
DIM device as BYTE: device = 8
DIM fileName AS STRING * 16
DIM fileTrack AS BYTE
DIM fileSector AS BYTE
DIM fileType AS BYTE
DIM discard as BYTE

OPEN 15, device, 15
OPEN 2, device, 2, "#"

REM read track 18 sector 1 into disk drive ram
PRINT #15, "u1 2 0 18 1"

REM read the first two bytes out of disk memory (pointer to next track/sector)
READ #2, discard, discard

REM read the directory entries
FOR counter AS BYTE = 0 to 7

    REM read first 3 bytes of dir entry
    READ #2, fileType, fileTrack, fileSector

    REM no entry here -- move on
    IF fileType = 0 AND fileTrack = 0 AND fileSector = 0 THEN CONTINUE FOR

    INPUT #2, fileName

    PRINT "-";fileName;"-"

NEXT counter

The device returns A0 bytes after the file name while STATUS is zero (=no error). Is A0 a valid terminator? I don't think so but I'll try to look it up in the 1541 manual.

@neilsf For the disk name and file name, it's always 16 bytes padded with A0. It's used to fill in the rest of the name if the name is shorter than 16 bytes.
This is really just an artifact of me trying to figure out how to use the language to get a specific amount of characters from the logical file. I thought perhaps the code would for terminate the input based on the size of the string, versus creating a new string.
I think I can close this since this is the expected behavior.

Okay, if it's a padded string, you can't use INPUT# to read it as a whole, but you can use GET# to get it char by char.


improve tsconfig.json

don't emit JS when there are TypeScript errors
specify LF as new line delimiter, to avoid pseudo-diffs between different OS'es (default delimiter depends on OS)
exclude node_modules, so that IDE's that solely rely on tsconfig.json (such as Atom and typescript.java Eclipse plugin) would work properly (and quickly)

I sent a PR to fix this issue


feat: First draft for Dynamic Menu Items - Menu Button Widget

First draft for #636

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Create the PR against main instead of v1.4. Therefore, closing it.

I have added the screenshot of the error state.
Also, I have already added a video in the issue #636's description which the team can refer. In case you missed it, it's here.
cc: @dilippitchika  @somangshu

@dilippitchika, @dhruvikn  - The changes are for the Menu Button Widget. A new property - Menu Items Source is added. Could you please confirm the below understanding:

Menu Items Source is a widget property.
The previous implementation for menu item is now available as part of Menu Items Source - Static.
Menu Items Source - has two source types (Static) and a new Source 'Dynamic'.
Once user selects Dynamic source, user can further set properties and styles.
onClick can fetch the selected values by using currentItem.<attribute_name> of the object.

Yes @jnikhila, that's correct. Just a couple of pointers though -

Once user selects Dynamic source, user can further set properties and styles. They can also utilize currentItem and currentIndex here.
We have also added two more new widget properties - Source Data and Configure Menu Items. These properties are only required when Menu Items Source is set to Dynamic.

Hey @danciaclara @jnikhila, just putting this here - I'll be happy to jump on a call to discuss the widget in depth and clarify any doubts you might have. Please let me know if needed. 🙂

Thanks @dhruvikn - Could you please share your thoughts on this comment?

Hey @jnikhila, I completely agree with @danciaclara's comment. Menu Item Properties are the same for both Menu Items Source - Static and Dynamic. We can remove the Dynamic Menu Item properties section as it looks repeated.
Furthermore, cross-referencing, as @danciaclara suggested,

Just in the main Menu Button properties table, cross reference to the Static and Dynamic subsections in the description.

sounds great and helpful.

Hey @jnikhila, I completely agree with @danciaclara's comment. Menu Item Properties are the same for both Menu Items Source - Static and Dynamic. We can remove the Dynamic Menu Item properties section as it looks repeated.
Furthermore, cross-referencing, as @danciaclara suggested,

Just in the main Menu Button properties table, cross reference to the Static and Dynamic subsections in the description.

sounds great and helpful.

I thought @danciaclara is asking to remove the Item configuration properties. @danciaclara - Are you suggesting to remove the two tables that we added for static and dynamic items properties or should we keep one table properties and call it as Menu Item source properties and then cross-reference to static and dynamic.
@dhruvikn - Your thoughts?

@jnikhila - I think the changes that you pushed recently are exactly what I and @danciaclara were talking about. 🙂
@danciaclara please confirm once.
However, one nitpick from me.

@danciaclara - Removed the error message and added ticket #683 to add it to the Troubleshooting section.


Audit fixes: Denom validation and multiHopSwap input check

validate token denoms
validate matching input tokens on multi-hop swap

https://github.com/neutron-org/neutron-tests/actions/runs/9308510496

https://github.com/neutron-org/neutron-tests/actions/runs/9310625760

https://github.com/neutron-org/neutron-tests/actions/runs/9319434742


Problem running OpenScenario files

Hi,
i am new to Carla and i want to simulate OpenScenarios. I've got the packaged version of Carla and the scenario runner, both same versions.
Starting 'normal' with the scenario runner included scenarios is fine, but when I open OpenScenario files (also the included ones), I get an error everytime.
After starting the server I execute (as example):
'..\scenario_runner-0.9.10>python scenario_runner.py --openscenario C:\Users\windb\Desktop\scenario_runner-0.9.10\srunner\examples\PedestrianCrossingFront.xosc --output'
and the manual_control.py from the scenario runner.
My output is:
File "C:\Users\windb\Desktop\scenario_runner-0.9.10\srunner\scenariomanager\scenarioatomics\atomic_criteria.py", line 829, in update
current_wp = self._map.get_waypoint(current_loc, lane_type=carla.LaneType.Any)
OverflowError: can't convert negative value to unsigned int
can't convert negative value to unsigned int
Destroying ego vehicle 259
ERROR: failed to destroy actor 259 : unable to destroy actor: not found
No more scenarios .... Exiting
Thanks for your help!

Hey @WhyTrouble, that isn't related to OpenScenario, but to a Windows error. Check this issue here for more information. We are working on it.
In the meantime, if you don't care that ScenarioRunner doesn't correctly detect that the vehicle has entered the sidewalk, change that line to

current_wp = self._map.get_waypoint(current_loc, lane_type=carla.LaneType.Any)

and the simulation won't give you any errors.


other repository tests

/review-bot https://github.com/zeronsoftn/shim-review/blob/zeronsoftn-shim-x86_64_ia32_aarch64-20230915

/review-bot https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20230915

/review-bot https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20230915

/review-bot https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20230915

/review-bot https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20230915

/review-bot https://github.com/zeronsoftn/shim-review/tree/zerox-shim-x86_64_ia32_aarch64-20230925

/review-bot https://github.com/MuthuvelKuppusamy/shim-review/tree/microfocus-shim-x64-ia32-20230224

@THS-on Hi!
To use Bot, you need the following content in your Dockerfile.
# REVIEW
RUN echo "::review hash-start" && \
    for name in $(find /work/output/ -type f -name "shim*.efi"); do sha256sum $name; done && \
    echo "::review hash-end"

And trigger again as shown below.
/review-bot https://github.com/MuthuvelKuppusamy/shim-review/tree/microfocus-shim-x64-ia32-20230224
sbat: sbat.mfzenworks.csv
vendor-cert: microfocus_zenworks_secureboot1.cer

@jclab-joseph thanks! This is not my Shim, so I cannot change the Dockerfile. The other information are still very useful.

/review-bot https://github.com/MuthuvelKuppusamy/shim-review/tree/microfocus-shim-x64-ia32-20230224
sbat: sbat.mfzenworks.csv
vendor-cert: microfocus_zenworks_secureboot1.cer

@THS-on Now you can do it without modifying your Dockerfile. :)
https://github.com/jc-lab/shim-review-bot/issues/3#issuecomment-1735152415

/review-bot https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20231017

/review-bot https://github.com/zeronsoftn/shim-review/tree/zerox-shim-x86_64_ia32_aarch64-20231017

/review-bot https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20240404


Antrea agent configuration file to enable and configure secondary network specific OVS parameters.

Antrea agent configuration file to enable and configure secondary network specific OVS parameters. Required to enable service function chaining.
Signed-off-by: Adwait Patil<EMAIL_ADDRESS>

@jianjuns @antoninbas This the replica of https://github.com/antrea-io/antrea/pull/4404. when @adwaitni was looking to address the conflict, this branch got closed.
Please use this new PR to review the file changes and merge.

@adwaitni : we got this error again. Could you fix it?

The Helm chart documentation is out-of-date; please run 'make helm-docs' in 'build/charts/' and commit the changes

@adwaitni : another Go formatting issue:

pkg/config/agent/config.go:315: File is not gofmt-ed with -s (gofmt)
Enable     bool                yaml:"enable,omitempty"

/test-all

/test-all

/test-all

@adwaitni please resolve the conflicts asap.

@jianjuns, after @adwaitni's rebase I see the review "compare" has some misleading diffs. But, the actual commit looks good to me https://github.com/antrea-io/antrea/pull/4440/commits/9f9de4403448db3876e6ccc326567df120c06685

/test-all

/test-all

/test-e2e

/test-conformance

/test-all

/test-all

/test-all

Please let me know if there is anything else to be taken care of.

@antoninbas please trigger /test-all from your end. As we know from last week, @adwaitni or myself triggering /test-all fails always and @jianjuns mentioned some permission issues.

@arunvelayutham I have started the Github workflows. If they pass, I will run e2e jobs.

@arunvelayutham @adwaitni please check all Github workflow failures. In particular:

manifests are not generated properly
it seems that Antrea fails to deploy as all the Kind jobs are failing

/test-conformance

/test-e2e


[analyzer] Unexpected non_exhaustive_switch_expression error

Consider the following case:
void main() {
  SomeClass? first = SomeClass();
  SomeClass? second = SomeClass();

  final result = switch ((first, second)) { // <-- shows an error
    (== null, != null) => true,
    (!= null, == null) => false,
    (== null, == null) => false,
    (!= null, != null) => process(first, second),
  };
}

bool process(SomeClass first, SomeClass second) => true;

class SomeClass {}

Analyzer shows: The type '(SomeClass, SomeClass)' is not exhaustively matched by the switch cases since it doesn't match '(SomeClass(), SomeClass())', but shouldn't the last line ((!= null, != null)) cover this case?

Agree it's probably an analyzer bug.
CFE accepts the code, and it looks very much like something that should work.
(The example is even more weird because the matched value type is (SomeClass, SomeClass), so the first three cases are statically known to not match, and the fourth case should, equally statically, be known to always match.
It requires unsound null safety, which no longer exists, but may still be in the tool code, to have the fourth case not match, but then one of the first three still still should.)

Yeah, great point. Even if I remove the ? from declarations, there is still no error about the first three matches...

@scheglov

I believe this implementation is  from _fe_analyzer_shared. @johnniwinther
CFE reports similar error.
bin/test.dart:3:19: Error: The type 'Object?' is not exhaustively matched by the switch cases since it doesn't match 'null'.
 - 'Object' is from 'dart:core'.
Try adding a wildcard pattern or cases that match 'null'.
  var v = switch (o) {
                  ^