Incorrect "Dayname" attribute when going from DST to Standard Time

Describe the bug
The day after switching DST to Standard Time the upcoming sunday (tomorrow) the sensor attributes incorrect daynames. See picture below
Expected behavior
Expected Day 3 to be Monday, Day 4 to be Tuesday etc.
Screenshots

Solcast Integration Version

Integration Version v4.2.4

Desktop (please complete the following information):

OS: Windows 11
Browser Chrome
Version  130.0.6723.70

Smartphone (please complete the following information):

Device: Iphone 14+15
OS: 18
Browser Companion App

Additional context

I get the same on mine.  Its now just after midnight British Summer Time (UTC+1) so pv_today says Saturday
pv_Tomorrow says its going to be Sunday
As does the D3 sensor, also going to be Sunday
And D4 says it will be Monday
Key point is that the clocks have not yet changed from DST, its the future projected days are wrong.
I dare say it will sort itself out after DST swaps, but is an amusing wrinkle

BST ends tomorrow, so let's wait and see. Did either of you notice this happening during the week in the seven day lead up to the switch? I wonder if you were getting two thursays, then two wednesdays, etc. as the transition loomed.
The day name is likely a symptom and that the data for tommorow and day 3 will be identical, with further days ahead shifted.
dayname is set using start_utc.astimezone(self._tz).strftime("%A"), which is pretty simple.
start_utc is set to self.get_day_start_utc() + timedelta(days=futureday) being the start of 'today' i.e. midnight local in universal coordinated time, and this reference point is used to build the forecast data too.
get_day_start_utc() returns dt.now(self._tz).replace(hour=0, minute=0, second=0, microsecond=0).astimezone(timezone.utc), which is getting the local time now and setting hour/min/sec to zero i.e. midnight local just gone, then converts this to universal coordinated time.
This is bending my mind while I actually laugh out loud. It will have been a bug forever.
One hour of the day disappears going off daylight time. So what??? Is it because BST is only one hour away from UTC? Probably.
I am going to have to simulate this in a Python test using your TZ!
Any clues from others?

Did either of you notice this happening during the week in the seven day lead up to the switch? I wonder if you were getting two thursays, then two wednesdays, etc. as the transition loomed.

I have noticed it for some days now, so when the upcoming Sunday was D7 it probably started.
And thank you for the explanation :)

I have mentally worked this out without a sim.
It is because of the one hour shift from UTC.
What the code needs to do when calculating the start of future days in UTC is to use the time zone that would be in force as-at that date... So it is getting things wrong by an entire day.
But the forecast data returned will be correct for the day I think. You can verify this by looking at up-coming days in the Energy dashboard.
Thanks for pointing it out!
This will likely be fixed in v4.2.5.

But the forecast data returned will be correct for the day I think. You can verify this by looking at up-coming days in the Energy dashboard.

I can confirm that the forecast data looks correct.
Thanks again 👍

dayname is set using start_utc.astimezone(self._tz).strftime("%A"), which is pretty simple.

This is the problem.  Assuming that dayname is set using start_utc.astimezone(self._tz).strftime("%A") this is a feature of HA, you're sort of SOL, here.  There's no one good solution.
If you could pick the middle of the day (e.g. midday), you'd be fine, but if dayname is choosing the start of the day, you're out of luck.
When I had to worry about this in another life, and ran into this problem, and had a choice of what time of day (it didn't have to be the beginning of the day), we chose UTC+14:30 as the time - because was always going to fold back to the correct day no matter what time zone or daylight saving zone you were in.  Worked in NZ in summer, and East Coast US in winter.  We didn't have customers in Alaska, nor ever expected any, so were prepared to live that that baked in tech debt).

I wonder if you were getting two thursays, then two wednesdays, etc. as the transition loomed.

Just before midnight I could see today was Friday, tomorrow Saturday, D3 and D4 both Sunday

One hour of the day disappears going off daylight time. So what??? Is it because BST is only one hour away from UTC? Probably.

I'm expecting an extra hour of the day (night) not an hour less, two 1-2AM's as the clocks adjust from BST to UTC
And impressively the Solcast detailed half hourly forecast correctly shows the duplicated 01:00 and 01:30 slots with the different time zones

We saw a similar thing here - we had a warning for a week or so that there was a day with only 46 out of 48 half hours.

This will likely be fixed in v4.2.5.

It'll take us a whole year to check that it works 😂

It'll take us a whole year to check that it works 😂

All these young kids who have never actually set the time on their PCs for testing time zone related stuff.

dayname is set using start_utc.astimezone(self._tz).strftime("%A"), which is pretty simple.

Now that I've squinted at the code:
midday_utc = self.get_day_start_utc() + timedelta(days=futureday) + timedelta(hours=12)
 "dayname": midday_utc .astimezone(self._tz).strftime("%A"),

@gcoan are you able to share what Tuesday next week detailedForecast attribute looks like? Does it start at 00:00:00+00:00 or different?

Here is exactly the logic that is being followed, and I'm pretty sure it's quite wrong.
'Now' here is the early hours of the 26th Oct in the UK. BST. On Monday in the UK midnight UTC will be 00:00:00+00:00 and not what is being calculated. Correct?
The integration thinks it's 11pm on the day prior.
from datetime import datetime as dt
from datetime import timedelta, timezone
import pytz

tz = pytz.timezone("Europe/London")

now = dt.now().astimezone(tz)
print('Now:', now.replace(microsecond=0).isoformat())
day_start = now.replace(hour=0, minute=0, second=0, microsecond=0).astimezone(timezone.utc)
print('Day start UTC:', day_start.isoformat())
monday = day_start + timedelta(days=2)
print('Monday day start UTC:', monday.isoformat())

print(f'\nMonday day start converted to {tz}:', monday.astimezone(tz).isoformat())

Output:
Now: 2024-10-26T02:36:37+01:00
Day start UTC: 2024-10-25T23:00:00+00:00
Monday day start UTC: 2024-10-27T23:00:00+00:00

Monday day start converted to Europe/London: 2024-10-27T23:00:00+00:00

This looks better to me.
The timedelta must be applied to the local midnight, and not the day_start_utc.
from datetime import datetime as dt
from datetime import timedelta, timezone
import pytz

tz = pytz.timezone("Europe/London")

def get_day_start_utc(days_ahead):
    now = dt.now().astimezone(tz).replace(microsecond=0)
    nowplus = (now + timedelta(days=days_ahead)).astimezone(tz)
    day_start = nowplus.replace(hour=0, minute=0, second=0, microsecond=0).astimezone(timezone.utc)
    print('Now:', nowplus, 'Day start UTC:', day_start.isoformat())

for d in range(8):
    get_day_start_utc(d)

Output:
Now: 2024-10-26 03:10:30+01:00 Day start UTC: 2024-10-25T23:00:00+00:00
Now: 2024-10-27 02:10:30+00:00 Day start UTC: 2024-10-27T00:00:00+00:00
Now: 2024-10-28 02:10:30+00:00 Day start UTC: 2024-10-28T00:00:00+00:00
Now: 2024-10-29 02:10:30+00:00 Day start UTC: 2024-10-29T00:00:00+00:00
Now: 2024-10-30 02:10:30+00:00 Day start UTC: 2024-10-30T00:00:00+00:00
Now: 2024-10-31 02:10:30+00:00 Day start UTC: 2024-10-31T00:00:00+00:00
Now: 2024-11-01 02:10:30+00:00 Day start UTC: 2024-11-01T00:00:00+00:00
Now: 2024-11-02 02:10:30+00:00 Day start UTC: 2024-11-02T00:00:00+00:00

The timedelta must be applied to the local midnight, and not the day_start_utc.

My only comment (and it is nitpicking, but can avoid problems, particularly around British standard vs summer time, given how close it is to UTC), is that if the timedelta is be applied to the local midday of the given day, and not the midnight (start) of the given day, it will never run into the transition, particularly for time zones that exist on or around UTC.
nowplus = (now + timedelta(hours=12) + timedelta(days=days_ahead)).astimezone(tz)
This obviously won't help you find the start of the day, but will help you land smack bang in the middle of the day (from whence it is simple to find) the:

name
start
end
etc.

I'll push a commit soon and you can see what I am doing about it. There is more than one issue.

The day name is wrong.
The determination of a future date day_start_utc is wrong when transitioning to or from summer time. The day totals will look right, however the forecast hours built for the Energy dashboard will be shifted by an hour for all days after the transition, until the transition occurs which will 'right' things.
The intervals included in forecast slices is wrong when transitioning. This is 48 usually, could be 46 when transitioning to summer time, could be 50 when transitioning to standard time. Presently a flat 48 intervals are grabbed, which does not throw anything off because the sun does not shine around midnight. This throws off the forecast interval check, however, and makes my eye twitch.

but will help you land smack bang in the middle of the day

How? 'Now' could be 10pm...

How? 'Now' could be 10pm...

Indeed.
Sorry, my first suggested edit was more correct
midday_utc = self.get_day_start_utc() + timedelta(days=futureday) + timedelta(hours=12)
 "dayname": midday_utc.astimezone(self._tz).strftime("%A"),

Anyway, await your commit.  I'm sure you know what you're doing, and a second set of out of focus eyes, that have done this before, will help spot any gotchas.

Something's still wrong. I set my dev rig to London time and both tomorrow and Monday (day_3) still show as Sunday. day_4 shows Monday
The forecasts interval count validation appears okay.
I better fix this quick or I'm going to be messing with the dev rig clock.

The intervals test is (mostly) working as expected.
{'intervals': 48, 'correct': True}
{'intervals': 50, 'correct': True}
{'intervals': 48, 'correct': True}
{'intervals': 48, 'correct': True}
{'intervals': 48, 'correct': True}
{'intervals': 48, 'correct': True}
{'intervals': 26, 'correct': False}
{'intervals': 0, 'correct': False}

Easy fix @BJReplay.
It's all working now.

@gcoan are you able to share what Tuesday next week detailedForecast attribute looks like? Does it start at 00:00:00+00:00 or different?

Sorry Steve, I went to bed and only just saw your message.
As suspected, Tuesday's forecast starts at 23:00:

Of course no sun at that time of the night but all the rest of the forecast for the week will be off by an hour.
It looks like you were on the case anyway by setting your HA to London time zone.  Do you need me to test anything ?

The DST clock change causes such chaos.  Great job in fixing it quickly.
Looking at Predbat's forecast it doesn't have any awareness of the DST change, everything is in (current) local time so it trips through 1am, 2am, 3am Sunday with no recognition that there will be duplicated times.   Hey ho.
Solcast more of an issue because the forecasts are all in UTC and everything is converted back to local TZ.
Out of interest, do you have TZ changes in Australia?
The European Council voted to scrap the TZ change in 2018 but its not been enacted yet https://www.consilium.europa.eu/en/policies/seasonal-time-changes/
UK still occasionally talks about change but I don't believe it's on anyone's political agenda

Out of interest, do you have TZ changes in Australia?

We do everywhere except Queensland (their farmers think it fades the curtains and confuses the cows) the Northern Territory (who mostly have desert and put on sweaters when it is below 25C), and Western Australia (who think they live in a different country to the rest of us).

Do you need me to test anything?

I'm not sure that I do. Daylight time ends for you tomorrow, when normal v4.2.4 service will resume. v4.2.5 is awaiting confirmation that setting a hard limit by individual API key works for anyone else but @BJReplay and I. (I'm pretty sure it does. 😉) That and a bit more bake-in testing.
If you're really keen to smell the future then you could shoehorn in the files at https://github.com/autoSteve/ha-solcast-solar/tree/Hard-limit-by-API-key. Almost every file has changed.

Feature request for Churchill Time....
https://www.bbc.co.uk/news/articles/c0mznrv3jvmo


Styles not working

When I try to insert colours into my Xsheet, it is displayed in other Cols but the original. Either I don't know how to use it or something is wrong.

This does not appear to relate to the Dwango OpenToonz plugins.
Recommend closing and reopening as an OpenToonz issue if appropriate.
@ang122  What do you say, is this a plugin issue specifically related to the Dwango plugins?


Bug: Cannot assign to read only property 'key' of object

Lexical version:
"lexical": "0.17.1"
Describe the bug
When using your example, an error message appears when selecting two lines of text consecutively：Cannot assign to read only property 'key' of object '#
Reproduction
https://github.com/mdx-editor/editor/blob/main/src/examples/html.tsx
To Reproduce
Steps to reproduce the behavior:

Select two lines of text  （ar A paragra）
Click the button Make selection orange

Expected behavior
This is almost certain to happen. I hope it works normally. Thank you.
Screenshots

Desktop (please complete the following information):

OS: Windows  Must appear
Browser Chrome

I think you've reported this bug to the wrong project, I would report this over at https://github.com/mdx-editor/editor


Create Cybernova.toml

Hi Bengt,
Since I'd deployed the post genesis validator, tested shielded/shielding transfers on masp, bond/unbond, voting proposals and experienced prometheus monitor. I'd like to continue contributing to testnets. Looking forward to being in pre-genesis validators.
Here is my submitted PRs (though closed):
For testnet-15: https://github.com/anoma/namada-testnets/pull/2568
For testnet-14: https://github.com/anoma/namada-testnets/pull/1607
For testnet-13: https://github.com/anoma/namada-testnets/pull/1515
For testnet-12: https://github.com/anoma/namada-testnets/pull/1451
Thanks in advanced.
Description
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[ ] Only one toml is added in this PR
[ ] The file being added is indeed a .toml file
[ ] The toml being added is to the correct folder, and only to the correct folder
[ ] The eth_hot_key and eth_cold_key are present
[ ] The email, discord, elements telegram, and twitter fields are present and valid

Successfully validated transactions.toml file for commit hash e9fc22e


jitPack not found lib

@TimScriptov
Jadx now available on Maven Central please check this wiki page for usage help.


Can't push environment file

Forge CLI Version
1.8.0
PHP Version
8.3.1
Description
forge env:push api.signalspot.io .env.production
==> Uploading [.env.production] Environment File
An unexpected error occured. Please report this issue here:
https://github.com/laravel/forge-cli/issues/new/choose

Forge CLI Version: 1.8.0
PHP Version: 8.3.1
Operating System: Darwin
Error Message: {
"message": "Server Error"
}.

Steps To Reproduce
Just trying to push env file

Hi @Tachii. Could you please email Forge support? Thanks


Add Nong Song:

Song Name
Grazhdanskaya Oborona - Lunar Abyss
Artist Name
levanfors (Egor Letov x LCHAVASSE)
Source
Youtube
Youtube Link
https://youtu.be/qjb3G2_K-bE?si=B9PL2hmI3xvrsM5Z
Direct File Link
No response
Song ID
645631
Start Offset [ms]
0
Extra
Duelo Maestro

reject
this sounds horrible and the songs don't fit together at all


Fix broken tests after merging with master

At least currently some failures like this one:
Failures:

  1) Api::Json::VisualizationsController behaves like visualization controllers main behaviour tests exclude_shared and only_shared filters
     Failure/Error: private_tables_enabled: true

       expected: true
            got: false

       (compared using ==)
     Shared Example Group: "visualization controllers" called from ./spec/requests/api/json/visualizations_controller_spec.rb:8
     # ./spec/support/factories/users.rb:68:in `create_user'
     # ./spec/requests/api/json/visualizations_controller_shared_examples.rb:105:in `block (3 levels) in <top (required)>'

The problem seems to be that the user is already created by a previous stage:
(rdb:1) user.valid?
false
(rdb:1) user.errors
{:email=>["is already taken"]}

hard to control as far as we have duplicate code (just check git grep<EMAIL_ADDRESS>

the user in section before(:all) was colliding with the one created in the include_context 'visualization creation helpers'


[Event request]Table 7321 "Warehouse Shipment Line" - "Qty. to Ship" - OnValidate --> OnBeforeValidateQtyBalanced

Please, could we have a publisher "OnBeforeValidateQtyBalanced" in  "Qty. to Ship" - OnValidate inTable 7321 "Warehouse Shipment Line"?
The issue is like this one #15501
Could be great have similar event on every table where the procedure UOMMgt.ValidateQtyIsBalanced is called
`field(21; "Qty. to Ship"; Decimal)
{
Caption = 'Qty. to Ship';
DecimalPlaces = 0 : 5;
MinValue = 0;
        trigger OnValidate()
        var
            ATOLink: Record "Assemble-to-Order Link";
            Confirmed: Boolean;
            IsHandled: Boolean;
        begin
            GetLocation("Location Code");

            IsHandled := false;
            OnBeforeCompareShipAndPickQty(Rec, IsHandled);
            if not IsHandled then
                if ("Qty. to Ship" > "Qty. Picked" - "Qty. Shipped") and Location."Require Pick" and not "Assemble to Order" then
                    FieldError("Qty. to Ship", StrSubstNo(Text002, "Qty. Picked" - "Qty. Shipped"));

            IsHandled := false;
            OnBeforeCompareQtyToShipAndOutstandingQty(Rec, IsHandled);
            if not IsHandled then
                if "Qty. to Ship" > "Qty. Outstanding" then
                    Error(Text000, "Qty. Outstanding");

            Confirmed := true;
            if (CurrFieldNo = FieldNo("Qty. to Ship")) and
               ("Shipping Advice" = "Shipping Advice"::Complete) and
               ("Qty. to Ship" <> "Qty. Outstanding") and
               ("Qty. to Ship" > 0)
            then
                Confirmed :=
                  Confirm(
                    Text009 +
                    Text010,
                    false,
                    FieldCaption("Shipping Advice"),
                    "Shipping Advice",
                    FieldCaption("Qty. to Ship"),
                    "Qty. Outstanding");

            if not Confirmed then
                Error('');

            if CurrFieldNo <> FieldNo("Qty. to Ship (Base)") then begin
                "Qty. to Ship" := UOMMgt.RoundAndValidateQty("Qty. to Ship", "Qty. Rounding Precision", FieldCaption("Qty. to Ship"));
                "Qty. to Ship (Base)" := MaxQtyToShipBase(CalcBaseQty("Qty. to Ship", FieldCaption("Qty. to Ship"), FieldCaption("Qty. to Ship (Base)")));
          // >> NEW EVENT
          OnBeforeValidateQtyBalanced(Rec, xRec, IsHandled);
          if not IsHandled then
          // <<  NEW EVENT
                UOMMgt.ValidateQtyIsBalanced(Quantity, "Qty. (Base)", "Qty. to Ship", "Qty. to Ship (Base)", "Qty. Shipped", "Qty. Shipped (Base)");

            end;

            if "Assemble to Order" then
                ATOLink.UpdateQtyToAsmFromWhseShptLine(Rec);
        end;
    }`

Event publisher:
[IntegrationEvent(false, false)]
local procedure OnBeforeValidateQtyBalanced(var WarehouseShipmentLine: Record "Warehouse Shipment Line"; xWarehouseShipmentLine: Record "Warehouse Shipment Line";  var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Fix to include interface methods on sub projections

Currently ClientApiGenerator.createSubProjectionType ignores the interface fields when the type implements an interface. For example, when passing the following schema, the name method for the Search_DirectorProjection sub projection class is not being generated.
type Query {
    search(title: String): [Show]
}

interface Show {
    title: String
    director: Director
}

interface Person {
    name: String
}

type Director implements Person {
    name: String
    shows: [Show]
}

This commit fixes that by not excluding the interface fields as the resulted query would still be valid.
fix #156

Thanks, @srinivasankavitha, for reviewing and testing these changes! I don't have permission to merge, so I'll let it for you or another maintainer.


WIP: Benchmark setup

Description
While working on CVXCORE, it became apparent that a benchmarking setup was required to assess the performance more easily. This PR adds a basic framework, which can be extended going forward (both in terms of features, and benchmarks).
Features (to be discussed which ones are relevant):

Timing the current branch only
Interactively compare two branches
Run benchmarks multiple times to get the best, worst, mean, and standard deviation
Include information about the local machine (CPU model, available RAM) -> I would remove this, as it adds two additional dependencies
Normalization of results

Open points:

Where should the data for the benchmarks be stored? (@rileyjmurray mentioned it might go into a new repo)
What to do with the existing tests/test_benchmarks -> potentially could be kept small versions as unit tests and larger versions as benchmarks
CI integration
Documentation
Dependencies

Possible extension:

Allow comparison of multiple solvers for compilation + solve time

Related issue: #1631
Type of change

[x] New feature (backwards compatible)
[ ] New feature (breaking API changes)
[ ] Bug fix
[ ] Other (Documentation, CI, ...)

Contribution checklist

[x] Add our license to new files.
[x] Check that your code adheres to our coding style.
[ ] Write unittests.
[ ] Run the unittests and check that they’re passing.
[ ] Run the benchmarks to make sure your change doesn’t introduce a regression.

Would it make any sense to just start a new benchmarking repo, since we don't want to add any dependencies to cvxpy? You could put the data there too.

Sounds good. I made a repo here: https://github.com/cvxpy/benchmarks


[BUG] How motion parameters estimated by the MRI scanner should be encoded?

Describe your problem in detail.
Currently, the physiology section reads:
https://github.com/bids-standard/bids-specification/blob/05f64ed77c5e6401ca39b479f02597acff4dba92/src/modality-specific-files/physiological-and-other-continuous-recordings.md?plain=1#L174-L175
while a new "Motion" section was integrated as a BEP in #443.
The question is whether these motion parameters should also be encoded with the _motion suffix or the _physio suffix.
Describe what you expected.
No response
BIDS specification section
https://bids-specification.readthedocs.io/en/stable/modality-specific-files/physiological-and-other-continuous-recordings.html#recommendations-for-specific-use-cases
and
https://bids-specification.readthedocs.io/en/stable/modality-specific-files/motion.html

Or get some inspiration from the way motion related time series are described in the functional derivatives BEP?

The way I see it is that the current "raw" specification is unclear (at best) or conflicting (at worst) between the two physio and motion specs. The problem is relatively contained by the specificity of the physio specs, which (weirdly, IMHO) point at "motion parameters estimated by the MRI scanner" (i.e., other motion tracking options seem to be dismissed).
Once motion has permeated the "raw" spec as its own suffix, this looks to me like the "MRI scanner" should be considered a motion tracking device and therefore should be encoded as _motion and remove the note from physio.
A different topic (which IMHO deserves its own issue) is harmonizing motion between raw and derivatives. I can't quite understand how motion in "raw" was not dealt with within physio as it seems to be the intent in the phrasing of physio for a long while ago. If that issue were opened, I honestly feel motion in "raw" should be deprecated and encoded with physio. I would not propose deprecation of the motion "derivatives" though.

I can't quite understand how motion in "raw" was not dealt with within physio as it seems to be the intent in the phrasing of physio

One of the difference though is that motion data as introduced in the motion BEP is a datatype in its own right recorded with nothing along, where as physio files correspond to data recorded along with another datatype.

the "MRI scanner" should be considered a motion tracking device and therefore should be encoded as _motion

Unless I am wrong, if done according to the motion, that would imply moving the motion file to a motion folder and users of the datasets would then have to rely on the scans.tsv to know how to match the motion file with its MRI file counterpart. Isn't that more complex than treat this as a physio file?

Okay, that makes a lot of sense. I missed that motion/ folder in the structure. IMHO it would make more sense to have used beh/ and _physio, but I can see the difference now.
Okay, I guess this should be more clear in the physio specs (and since I have only skimmed through motion, I cannot say about that side).
Thanks for the clarification @Remi-Gau, very much appreciated!

I guess I can close this issue since these motion parameters should be encoded as a physio file under the modality that corresponds.


Uncaught TypeError: Cannot read property 'top' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 0.166.0
System: Mac OS X 10.10.1
Thrown From: minimap package, v3.3.3
Stack Trace
Uncaught TypeError: Cannot read property 'top' of undefined
At /Users/jazzhilmer/.atom/packages/minimap/lib/minimap-view.coffee:353

TypeError: Cannot read property 'top' of undefined
  at MinimapView.module.exports.MinimapView.updateScrollY (/Users/jazzhilmer/.atom/packages/minimap/lib/minimap-view.coffee:353:64)
  at MinimapView.updateScrollY (/Users/jazzhilmer/.atom/packages/minimap/lib/minimap-view.coffee:1:1)
  at MinimapView.module.exports.MinimapView.updateScroll (/Users/jazzhilmer/.atom/packages/minimap/lib/minimap-view.coffee:368:6)
  at MinimapView.updateScroll (/Users/jazzhilmer/.atom/packages/minimap/lib/minimap-view.coffee:1:1)
  at /Users/jazzhilmer/.atom/packages/minimap/lib/minimap-view.coffee:268:8

Commands
     -7:19.7 window:update-available (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-seti-syntax.theme-seti-ui.find-visible)
     -6:22.9 core:paste (atom-text-editor.editor)
  3x -6:22.1 core:save (atom-text-editor.editor)
  2x -6:20.4 core:paste (atom-text-editor.editor)
  4x -6:18.5 core:save (atom-text-editor.editor)
     -4:16.0 find-and-replace:show (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-seti-syntax.theme-seti-ui.find-visible)
     -4:14.7 core:paste (atom-text-editor.editor.mini)
     -4:07.0 core:copy (atom-text-editor.editor)
     -4:05.4 editor:newline (atom-text-editor.editor)
     -4:04.9 core:paste (atom-text-editor.editor)
  4x -3:57.0 core:save (atom-text-editor.editor)
     -0:05.6 core:paste (atom-text-editor.editor)
  3x -0:05.0 core:save (atom-text-editor.editor)
     -0:02.1 core:undo (atom-text-editor.editor)
     -0:00.4 core:paste (atom-text-editor.editor)
  3x -0:00.0 core:save (atom-text-editor.editor)

Config
{
  "core": {
    "disabledPackages": [
      "emmet-atom",
      "autocomplete",
      "autocomplete-plus",
      "close-tags"
    ],
    "themes": [
      "seti-ui",
      "seti-syntax"
    ]
  }
}

Installed Packages
# User
autoclose-html, v0.12.0
less-than-slash, v0.2.0
linter, v0.7.3
minimap, v3.3.3
seti-syntax, v0.1.7
seti-ui, v0.3.6

# Dev
No dev packages

/cc @atom/core

Please see #206.


Make features extending/implementing non-features an error or warning

In practice, it shows that implementing a non-feature interface or extending a non-feature class is a common mistake, that's quite confusing. Make this an error, so the processor can point the problem out more effectively.
Now, "importing" foreign interfaces into a feature may be a useful strategy to support integration with foreign code. This should definitely be supported, but make this an explicit act by adding a @Feature.Import annotation, which suppresses the error.

Duplicate of #55

It's a warning now. Change it to an error for 0.2.

Oops, reopened the wrong issue


path to cmake hardcoded in OS build instructions.

This will break for example if cmake is installed via homebrew when it will be located in:
which cmake
/usr/local/bin/cmake
The offending line is:
https://github.com/google/or-tools/blob/e3bfbac67694ca9fb9c94c7581369a5c563dd61e/makefiles/Makefile.unix#L221

Can you try with
CMAKE=/usr/local/bin/cmake make third_party
?

Do you mean like this?
MacBook-Pro:or-tools username$ CMAKE=/usr/local/bin/cmake make third_party
cd dependencies/sources/gflags-2.1.2 && \
	/Applications/CMake.app/Contents/bin/cmake -D BUILD_SHARED_LIBS=ON \
		 -D BUILD_STATIC_LIBS=ON \
	         -D CMAKE_INSTALL_PREFIX=../../install \
		 -D CMAKE_CXX_FLAGS=-fPIC \
	         .
/bin/sh: /Applications/CMake.app/Contents/bin/cmake: No such file or directory
make: *** [dependencies/install/bin/gflags_completions.sh] Error 127

it still seems to look for the one in /Applications/CMake.app/Contents/bin/cmake

Can you try changing CMAKE =  into CMAKE ?=  in the Mac section of
makefiles/Makefile.unix ?
Le 14 déc. 2015 20:56, "Martin West"<EMAIL_ADDRESS>a écrit :

Do you mean like this?
MacBook-Pro:or-tools username$ CMAKE=/usr/local/bin/cmake make third_partycd dependencies/sources/gflags-2.1.2 &&
/Applications/CMake.app/Contents/bin/cmake -D BUILD_SHARED_LIBS=ON
-D BUILD_STATIC_LIBS=ON
-D CMAKE_INSTALL_PREFIX=../../install
-D CMAKE_CXX_FLAGS=-fPIC
.
/bin/sh: /Applications/CMake.app/Contents/bin/cmake: No such file or directory
make: *** [dependencies/install/bin/gflags_completions.sh] Error 127
it still seems to look for the one in
/Applications/CMake.app/Contents/bin/cmake
—
Reply to this email directly or view it on GitHub
https://github.com/google/or-tools/issues/127#issuecomment-164541842.


Zabbix datasource gives "wide" as only option for queries

Hello,
All the Query that were previously working have disappeared.
In its place in all it says: WIDE

What can be causing this?

Not sure why this would happen suddenly if you hadn't altered the queries. What do your queries look like?

@knightss27 is a Metrics from Zabbix Server with de Zabbix dataSoure

Ok, great! I just realized I've seen this issue before. Can you try disabling the "data alignment" option for the Zabbix datasource?
You can see here as well:
https://github.com/knightss27/grafana-network-weathermap/issues/7#issuecomment-1131874184
Please let me know if it works! I might add this to the FAQ if it does.

@knightss27 nice!!, It is already working correctly.

I'm still experiencing this issue on some dashboards, even after disabling data alignment on the dashboards and also on the datasource as a whole.
Has anyone else had similar issues?


Add strict expansion mode

Currently it is possible for values from a JSON-LD document to be dropped during expansion if an object key is not valid in the @context. For my use case, Linked Data Proofs, I need to catch invalid inputs. I propose to add a "strict expansion" mode in json-ld's expansion options, which when enabled, causes unexpanded terms to trigger an error that would otherwise be dropped.

It became clear that I was wrongly discarding non-IRI properties. In fact, it is possible for a JSON-LD document to include properties that are not IRIs. The expansion algorithm will only discard non-IRI/keyword properties that do not include a : character. We may need to rethink what the "strict" mode is. Should we raise an error when the expanded key:

is dropped (because it is not a keyword and does not include a ; character); or
it is not an IRI nor a keyword (current behavior, rejecting valid JSON-LD documents).

Should we raise an error when the expanded key:

is dropped (because it is not a keyword and does not include a ; character); or

Yes. (I assume you mean a : character)

it is not an IRI nor a keyword (current behavior, rejecting valid JSON-LD documents).

I'm not sure. What would be an example?


change design of module create / boot

idea is to combine create and boot of a module via a factory func
type ModuleFactory func(ctx context.Context, config cfg.Config, logger mon.Logger) (Module, error)

I like it

maybe changes also are required for /pkg/currency/module.go:46

maybe changes also are required for /pkg/currency/module.go:46


CDN is broken for 9.3.0

curl -L https://unpkg.com/rapidoc/dist/rapidoc-min.js responses Cannot find "/dist/rapidoc-min.js" in<EMAIL_ADDRESS>

Thanks,
9.3.0 and 9.3.1 were suppose to be internal releases and shouldn't have been published to npm
We are unable to unpublish it as  it crossed more than 300 downloads
However we have now deprecated 9.3.0 release.
Please use the release 9.3.2
Releases in github is fixed to reflect this change.
Please create a new issue if there you are still facing this problem with the latest - 9.3.2 release


Incorrect file paths being logged when trying to validate .mjml files via glob

Describe the bug
Incorrect file paths being logged when trying to validate .mjml files via glob
To Reproduce
Steps to reproduce the behavior:
Create a index.mjml file in a nested directory (./foo/bar/baz/index.mjml):
<%# This Source Code Form is subject to the terms of the Mozilla Public
  # License, v. 2.0. If a copy of the MPL was not distributed with this
  # file, You can obtain one at http://mozilla.org/MPL/2.0/. %>

<mj-section>
  <mj-column>
    <mj-text css-class="text-header">
      Is this you signing up?
    </mj-text>
  </mj-column>
</mj-section>

<%- include('/partials/location/index.mjml') %>

<mj-section>
  <mj-column>
    <mj-text css-class="text-body">

        If yes, use this verification code in your registration form:

    </mj-text>

    <mj-text css-class="code-large"><%- code %></mj-text>

    <mj-text css-class="text-body-no-margin">
      It expires in 5 minutes.
    </mj-text>
  </mj-column>
</mj-section>

<%- include('/partials/automatedEmailChangePassword/index.mjml') %>

pwd # /tmp/mjml-validate-test
tree foo/

foo/
└── bar/
    └── baz/
        └── index.mjml

## OR
find foo -type f # foo/bar/baz/index.mjml

Now, if I run npx mjml --validate "foo/**/*.mjml" in my root directory (/tmp/mjml-validate-test), I get the following validation errors:
Line 1 of /private/tmp/mjml-validate-test/foo/bar/baz/foo/bar/baz/index.mjml (%#) — Element %# doesn't exist or is not registered
Line 13 of /private/tmp/mjml-validate-test/foo/bar/baz/foo/bar/baz/index.mjml (%-) — Element %- doesn't exist or is not registered
Line 31 of /private/tmp/mjml-validate-test/foo/bar/baz/foo/bar/baz/index.mjml (%-) — Element %- doesn't exist or is not registered

Command line error:
Validation failed

Expected behavior
/private/tmp/mjml-validate-test/foo/bar/baz/index.mjml

Actual behavior
/private/tmp/mjml-validate-test/foo/bar/baz/foo/bar/baz/index.mjml

Note how the "/foo/bar/baz/" file path part seems to be duplicated.
-/private/tmp/mjml-validate-test/foo/bar/baz/foo/bar/baz/index.mjml
+/private/tmp/mjml-validate-test/foo/bar/baz/index.mjml

MJML environment (please complete the following information):

OS: macOS
MJML Version: 4.12.0
MJML tool used: CLI

npx mjml --version
# mjml-core: 4.12.0
# mjml-cli: 4.12.0

Email sending environment(for rendering issues):

Platform used to send the email [e.g Putsmail]

Affected email clients (for rendering issues):

Email Client [e.g Gmail]
OS: [e.g. Windows]
Browser [e.g. Google Chrome]

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Unfortunately, I don't know enough about mjml yet to know if <%- include('/partials/location/index.mjml') %> syntax is valid or if we're doing some pre/post processing internally, but that seems to explain these validator errors:
(%#) — Element %# doesn't exist or is not registered
(%-) — Element %- doesn't exist or is not registered
(%-) — Element %- doesn't exist or is not registered

<%- include('/partials/location/index.mjml') %> is not a MJML include (it's weird that the regexp does grab them tho)
cc @kmcb777 can you check if we didn't broke something while updating the watch ?


Windows Server 2025 drivers

Two days ago, Microsoft released a preview for Windows Server 2025, see https://www.microsoft.com/en-us/software-download/windowsinsiderpreviewserver
I tried to install it, but it does not accept the Windows Server 2022 drivers for vioscsi, nor the Windows 11 one.
Maybe it just needs a modified .inf file, as I don't assume anything changed in the driver API compared to Win11/Win22?
Anyway, it would be nice to be able install the 2025 version, so my feature request is to include a w2k25 release of the drivers.

Hi @kroese
What build number of Windows Server do you have?

@kroese
Did you try a "normal" vNext preview rather than Azure version ?

Do you run QEMU directly or via libvirt?

So, I got almost all of the drivers to work, by hard code activating directly via powershell. I just wanted to share it with you, because it seems to be a certificate issue as well.
My environment:

Proxmox 8.1
CPU AMD GX-424CC
SeaBios
pc-q35-8.1
Virtio SCSI Single
Virtio NIC
Windows Server Datacenter Core Version 10.0.26063.1

About the installation:
I had no issues here, as disk driver I selected the directory amd64\2k22and then picked the driver.
I wrote a script, that

runs the main installer on the root path of the virtio disk
installs the certificates to the Windows Certificate Store
installs all drivers, one after another
installs the qemu guest agent

# Define the paths to the MSI files
$virtioWinMSI = "D:\virtio-win-gt-x64.msi"
$guestAgentMSI = "D:\guest-agent\qemu-ga-x86_64.msi"

# Install Virtio-Win MSI
Start-Process msiexec.exe -ArgumentList "/i `"$virtioWinMSI`" /qn" -Wait

# Add the Root CA for the drivers to the TrustedPublisher and the Root CA store
Import-Certificate -FilePath "D:\cert\Virtio_Win_Red_Hat_CA.cer" -CertStoreLocation "Cert:\LocalMachine\TrustedPublisher"
Import-Certificate -FilePath "D:\cert\Virtio_Win_Red_Hat_CA.cer" -CertStoreLocation "Cert:\LocalMachine\Root"

# Install Virtio drivers
pnputil -i -a "D:\amd64\2k22\vioscsi.inf"
pnputil -i -a "D:\amd64\2k22\viostor.inf"
pnputil -i -a "D:\Balloon\2k22\amd64\balloon.inf"
pnputil -i -a "D:\NetKVM\2k22\amd64\netkvm.inf"
pnputil -i -a "D:\fwcfg\2k22\amd64\fwcfg.inf"
pnputil -i -a "D:\pvpanic\2k22\amd64\pvpanic.inf"
pnputil -i -a "D:\pvpanic\2k22\amd64\pvpanic-pci.inf"
pnputil -i -a "D:\qemufwcfg\2k22\amd64\qemufwcfg.inf"
pnputil -i -a "D:\qemupciserial\2k22\amd64\qemupciserial.inf"
pnputil -i -a "D:\smbus\2k22\amd64\smbus.inf"
pnputil -i -a "D:\sriov\2k22\amd64\vioprot.inf"
pnputil -i -a "D:\viofs\2k22\amd64\viofs.inf"
pnputil -i -a "D:\viogpudo\2k22\amd64\viogpudo.inf"
pnputil -i -a "D:\vioinput\2k22\amd64\vioinput.inf"
pnputil -i -a "D:\viorng\2k22\amd64\viorng.inf"
pnputil -i -a "D:\vioscsi\2k22\amd64\vioscsi.inf"
pnputil -i -a "D:\vioserial\2k22\amd64\vioser.inf"
pnputil -i -a "D:\viostor\2k22\amd64\viostor.inf"

# Install QEMU Guest Agent MSI
Start-Process msiexec.exe -ArgumentList "/i `"$guestAgentMSI`" /qn" -Wait

At the end, only one device is not recognized (no idea, which it actually is, though):

@fkonradmain
It will be better to use Win11 drivers for WS2025
Vadim.


CB-16174 Drop operational database template for versions before 7.2.10

See detailed description in the commit message.

Follow-up to  #12169.

Thanks, I've pushed the fixes (hopefully).
I could find the OpdbServiceEndpointCollectorTest error from the checks link, but not the other one.
(The unit-test link lead to a missing jenkins page )


Get-Process Should have a  Property "commandline"

Get-Process Should have a  Property "commandline"
Expected behavior
linux:
(Get-Process xxx).commandline   can return Process's commandline ,not need "ps -ef |grep xxx"
windows:
(get-wmiobject -query "select * from win32_process").commandline
Not intuitive

related to #3322

@KevinMarquette: Good find; I'd say it's a duplicate.


Starfish.grid_tools not found in non-editable installation.

I am having issues accessing functions in grid_tools module after the recent changes.
Is this just something I have missed?
As an exmaple
pip install https://github.com/iancze/Starfish/archive/develop.zip#egg=astrostarfish
python -c "from Starfish.grid_tools import *"

Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'Starfish.grid_tools'

or
python -c "from Starfish.grid_tools.interfaces import download_PHOENIX_models"

Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'Starfish.grid_tools'

In this environment I only installed Starfish using the pip line above (no repo clone).
If I clone the repo and run pip install -e .  from the starfish repo then the commands above do work.
I assume there would be a simple change to  __init__.py would possibly solve this. As to what the change is I am not sure.
I think this would also be a problem with pip install astrostarfish when it is uploaded to PyPI.

I can reproduce the problem using the python:latest docker image. This is odd, at first glance, since the folder structure follows the python package schema correctly as far as I can tell. I will investigate further tomorrow.

Turns out the fix was easier than I thought! I managed to execute the code below without issue:
$ docker run --rm -ti python:latest bash
/# pip install git+https://github.com/iancze/starfish@develop#egg=astrostarfish
/# python -c "from Starfish.grid_tools import *"
/# python -c "from Starfish.grid_tools.interfaces import download_PHOENIX_models"

If the issue continues, open this back up @jason-neal, but hopefully it is solved!

Thanks, find_packages() did the trick.


Install go-init in dev image

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Documentation:

Does this PR introduce a user-facing change?:

NONE

/test all

/retest

/retest

/test pull-kubecarrier-e2e-v1.16.4


Disconnect doesn't support autocompletion

Godot version:
3.2.1
Issue description:
You disconnect the same signals that you would connect, so it makes sense that both methods should suggest the same signals (and methods) in autocompletion. This can be probably copy-pasted.

Are you considering adding that to maintenance (3.x) version? With 4 there is much rework (which breaks compat) in that area already taken (with Callables).


Applying Policy error:   code line 1667 [: Illegal number: in Declarative mode

Applying Policy error code line 1667 in Declarative mode, first of all this happens in two scenarios when you try to apply policy and after you terminate it during the process even though not most of the time. second scenario is just by default after installation in some cases which i eventually don't know exactly.
The Bad thing when this error occurs in my experience i just have to reinstall the open-appsec again otherwise, one won't be able to apply policy again in declarative mode.
open-appsec-ctl -ap /usr/sbin/open-appsec-ctl: 1667: [: Illegal number: Policy didn’t changed. Policy path: /etc/cp/conf/local_policy.yaml root@kobe-vault:/tmp#

i have the same problem ... without any additional error information .. and during te applying the original version of the policy
mode : declarative mode

Hi,
we've managed to recreate it and are looking into it, I'll update here on our progress

Hi @epaphrasmakoko @AndyAdm,
Could you please share the full details of the flow, both the policy file and the command you've used to update the policy? you can send it to<EMAIL_ADDRESS>as well.
Thank you!

i have the whole file from debug command, i have the whole dump, so i should provide the the policy file only ? and in case of the command is app above in picture

i am using the default

Hi @epaphrasmakoko
The following change in /usr/sbin/open-appsec-ctl , in is_apply_policy_needed(), have allowed policy to be updated (after a file modification) in my environment.
Change the following line:
if [ "${local_policy_modification_time}" -eq "${last_local_policy_modification_time}" ] || [ -z ${last_local_policy_modification_time} ]; then
To:
if [ "${local_policy_modification_time}" == "${last_local_policy_modification_time}" ]; then

Let me check it now


Can't see Outlook/Exchange Calendar

Sorry forgot to add details and editing doesn't work...
When I try to configure Calendars (for events), Outlook/Exchange calendar is not given as an option. I have MS Office installed, do I need something else, or is this just missing?

Itsycal shows the calendars you've added to the Mac Calendar.app (not including delegate calendars). It doesn't talk directly to Google or Exchange or anywhere else. Try adding your accounts to the Mac Calendar?

Thanks that helped. After I added it to Calendar config it was also visible itsycal.

Itsycal shows the calendars you've added to the Mac Calendar.app (not including delegate calendars). It doesn't talk directly to Google or Exchange or anywhere else. Try adding your accounts to the Mac Calendar?

have added the exchange server account in mac calendar, itsycal still doesn't pickup the events from that calendar. have tried restarting itsycal. Doesn't help.

Can you see the calendar listed in Itsycal's preferences? If so, is there a checkmark next to it?


Confusion on the reddit dataset

Hi! I'm very interested in your work. When I run code on reddit datasets,I encountered this errors.
adj = adj.cuda()
RuntimeError: torch.cuda.sparse.FloatTensor is not enabled.

Hi @tonyandsunny , can you let me know your pytorch version?

0.4.1

@tonyandsunny you would need to use torch >= 1.0.0 as specified by README


Show source in line diagnostics

I noticed that in the Wiki page for "UI customization" -> "Show source in diagnostics" it's now recommended to not alter the original diagnostics, but to modify the deepcopy instead. This correctly shows the formatted diagnostics in virtualtext.

But not when calling vim.lsp.diagnostic.show_line_diagnostics()

Is there a way to achieve this behavior?

Please don't delete the issue template. This sounds like a usage questions so I'll direct you to ask our on discourse.

Apologies, the template seemed specifically for bug reports, and as you mentioned, this is more of a usage question. Thanks for the reference.


t.plan not working in async functions

t.plan isn't working when using async/await.
test('generate screenshots', async t => {
    t.plan(2);

    const streams = await new Pageres()
        .src('yeoman.io', ['480x320', '1024x768', 'iphone 5s'])
        .src('todomvc.com', ['1280x1024', '1920x1080'])
        .run();

    t.is(streams.length, 5);
    streams[0].once('data', data => t.true(data.length > 1000));
});

This will throw an error Assertion count does not match planned. When using t.plan(1) it works correctly but off course doesn't test the length of the data.
This was pointed out here https://github.com/sindresorhus/pageres/issues/213#issuecomment-147634374.

I think it's worth explaining why it does not work. When using promises in AVA, it is advertised that t.plan() is not needed, because test finishes when promise resolves/rejects. So that's exactly what happens here, async functions are converted into promises by babel. So when a promise resolves, the test is done here and it does not wait for data event.

Here's a another simple example of t.plan()'s epic fail, along with the working snippet from the README...
test 'bar', (t) ->
	t.plan 2
	setTimeout ->
		t.is 'bar', 'bar'
		t.same ['a', 'b'], ['a', 'b']
	, 100

test 'simple async', (t) ->
	t.plan 1
	setTimeout ->
		async.start
			success: ->
				t.pass()
  		fail: (err) ->
				console.log "errrored #{err}"
	, 500

 ✖ simple async Assertion count does not match planned
 ✔ bar (107ms)

Any chance this will be fixed anytime soon?   Seems like a pretty basic/necessary part of any "asynchronous" testing framework, no?
Can I help?  How?

@mralexgray This is completely irrelevant to the issue, which is concerning ES2016 async functions, not async in general. Please don't use unproductive words like "epic fail". We have a passing test for t.plan with an async assertion. It, however, seems like your success function is never called. Happy to be proven wrong with a failing test, though.

Huh, you're right.
In my original code (which I swear I had tried before posting)...
test 'async', (t) ->
  t.plan 1
  setTimeout ->
    async.start
      success: ->
        t.pass()
      fail: (err) ->
        t.fail()
  , 500

Maybe I had mistakenly put t.plan 2 ... or also had a t.end() in one of my callbacks?  Regardless, it's working now!  Sorry for the tongue-in-cheek dramatics.  Was just being cheeky 😇

@sindresorhus BTW, in your example of the passing test, are you using 'bluebird' promises?  If so, it may be worth mentioning in the README's "promises" section that that is what YOU guys are using, and is an option for test-writers, as well. :-)

We're using Bluebird, yes, but that's an implementation that shouldn't be dependent upon.


docs: Remove references to the post install hook

Fixes #N/A
Description

Remove post install hook reference from the migration guide

How was this change tested?

N/A

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 79.311%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
91.67%

pkg/fake/utils.go
2
94.56%

Totals

Change from base Build<PHONE_NUMBER>8:
-0.04%

Covered Lines:
5938

Relevant Lines:
7487

💛  - Coveralls


Support multi-run with hydra + DDP

Support multi-run with hydra + DDP (when output_subdir is non-None).
Implementation of the idea from #11617 in a restricted setting (when saved config is actually present).

Before submitting

[x] Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Hey @nisheethlahoti
Would you like to continue this work? No pressure, just want to make sure it the PR goes stale :)

@awaelchli  I realized that the implementation above isn't entirely correct (it doesn't properly handle user overrides that start with hydra.). I know the basic sketch of a correct implementation, but don't have time to get it done right now. Maybe in a couple weeks.

@nisheethlahoti @awaelchli I ran into the problem of a sweep/multirun of multiple PL training jobs with DDP resulting in spawned ddp processes (train_ddp_process_1, etc.) creating multiple output folders of the same multirun, each folder containing a copy of multirun.yaml and DDP subprocess log files. This is partially because my hydra.sweep.dir is created dynamically using the resolver now, and of course subprocesses are not launched at the same time as the main one. Another thing is lightning.fabric.strategies.launchers.subprocess_script._hydra_subprocess_cmd doesn't take RunMode into consideration so that in a multirun hydra.sweep.dir is not used to override a DDP subprocess.
I came up with my own solution (https://github.com/facebookresearch/hydra/issues/2070?notification_referrer_id=NT_kwDOA_4VdbMzMjE4MDA3MzYzOjY2OTgzMjg1#issuecomment-1719461255).
I think in your solution using hydra.runtime.output_dir at https://github.com/Lightning-AI/lightning/blob/8d0dbe83b15cc1be970af626015d72459e66feed/src/lightning/fabric/strategies/launchers/subprocess_script.py#L158-L168 may not be a good idea if hydra.run.dir is created dynamically using resolvers like now or other custom resolvers defined by the user. It doesn't seem necessary to pass config.yaml to the subprocess as long as you take hydra.sweep.dir into consideration. Maybe I'm missing something? The only minor problem my solution is not able to solve is that the last ran subprocess will create a multirun.yaml that overwrites the one created by the main process, but that's a Hydra problem (no option to disable multirun.yaml creation in Hydra anywhere yet). You can see my comments in the aforementioned issue for Hydra for more details.


Increase UR5e wrist3 joint position limits to use full mechanical range

Increasing this limit helps the robot plan shorter paths to some poses during objectives like Pick and Place Object, since now it can just rotate the wrist a little bit further rather than needing to perform a big joint flip motion.


How to set scope when using the torii adapter

Not sure this is documented anywhere -- I couldn't find it anyway -- but I discovered the way to pass the scope option when using the torii firebase adapter is:
this.get('session').open('firebase', { provider: 'github', settings: { scope: 'user,gist' }})

I discovered this after seeing https://github.com/firebase/emberfire/pull/325.
Perhaps this belongs in the authentication section of the emberfire guide? https://www.firebase.com/docs/web/libraries/ember/guide.html#section-authentication

Thanks!
I'll pass it along to the docs people and get it updated.

Good stuff, thanks!

Scope is mentioned in our newest docs https://github.com/firebase/emberfire/blob/master/docs/guide/authentication.md


pull request for e2e test at 01/24/2017 03:15:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Change order_id from usize to i32

the API changes existing order id to a negative number if they are entered via GUI

Ok, thanks, wasn't aware of that, will update.

commit 0f90dcb54e76ec6edf19e34df509ce426b5170d8


Onedb shows ruby errors instead of more readable errors

Description
When running the command onedb update-body with some object that doesn't exist or with OpenNebula service stopped, it shows ruby errors:
$ onedb update-body vnet --id 133
undefined local variable or method `o' for #<OneDBLive:0x000055f0d8d3e978>

To Reproduce
Run the command with object that doesn't exist.
Expected behavior
It should show an specific and readable error.
Details

Affected Component: CLI
Version: 5.10 and master.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

PRs to merge in 5.10 and master:

code: https://github.com/OpenNebula/one/pull/4338
docs: https://github.com/OpenNebula/docs/pull/988


Ldop 190 jenkins swarm slave

This PR has:
Jenkins Master with swarm-slave plugin so it can auto detect the swarm-slaves.
Jenkins swarm-slave container set up with a new version of docker so that we can use pipeline builds.
(These currently point to my docker-hub images but once we push them up to dockerhub we can swap)
Sensu fixes: The way the ./ldop swarm init command was created it destroyed all the original sensu checks. We added a couple steps to the swarm init script which copies the original checks into sensu before adding the new extension ones.

Taking down this pull request until we come up with a better way to pull down sub module code for sensu fix.


Optional image model provider to character and runtime

Is your feature request related to a problem? Please describe.
Currently, users can only select a single model provider for both text and image generation. This becomes limiting when a provider excels at text generation but offers subpar image generation capabilities, or vice versa.
Describe the solution you'd like
We propose adding an optional image model provider setting that would take precedence over the default model provider when configured. If no image provider is specified, the system would continue using the default model provider, maintaining backward compatibility.
Describe alternatives you've considered
We've explored using a single provider (such as Heurist or OpenAI) for both text and image generation. While this works adequately, it limits flexibility. For instance, if you want to use a fine-tuned model from a specialized image generation service, this isn't currently possible.
Additional context
I've implemented a similar solution that allows me to use OpenAI for text generation while leveraging a custom fine-tuned model on fal.ai for image generation.

Added in #491


Feature Request: Open the same folder in multiple windows

Please allow user to open the same folder in multiple windows.
This would provide a workaround to the same multi-monitor issues mentioned in other issues that have been open for years.
I love VSCode, but the inability to use it effectively on multiple smaller monitors compared to one massive monitor is a significant limitation.
I would expect the following to produce two VSCode windows with the same folder open:

Open VSCode with NewWindow (nothing opened)
Repeat step 1 so there are now two VSCode windows open
Select First window
Select File | Open Folder
Pick any folder (say c:\dev)
Select Second Window (e.g. Alt+Tab in Windows)
Select File | Open Folder
Pick the same folder as step 5.

Expected Behavior:
Two windows are open on the same underlying folder.
Actual Behavior:
First window is activated and brought to the foreground; second window is unchanged.

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


TypeError: expected str, bytes or os.PathLike object, not NoneType

🐛 Bug
I am summarizing the source of the issue to speedup the fix.
After this line of code
https://github.com/PyTorchLightning/pytorch-lightning/blob/90929fa4333e5136020e9f9dcb7c1133e4c290f3/pytorch_lightning/accelerators/ddp_backend.py#L119
I have that env_copy['PL_GLOBAL_SEED'] is None and having an environment variable set to None breaks subprocess.Popen here
https://github.com/PyTorchLightning/pytorch-lightning/blob/90929fa4333e5136020e9f9dcb7c1133e4c290f3/pytorch_lightning/accelerators/ddp_backend.py#L127
My fix at the moment is to add
if env_copy['PL_GLOBAL_SEED'] is None:
                del env_copy['PL_GLOBAL_SEED']

after
https://github.com/PyTorchLightning/pytorch-lightning/blob/90929fa4333e5136020e9f9dcb7c1133e4c290f3/pytorch_lightning/accelerators/ddp_backend.py#L119
Environment
* CUDA:
	- GPU:
	- available:         False
	- version:           10.2
* Packages:
	- numpy:             1.18.5
	- pyTorch_debug:     False
	- pyTorch_version:   1.6.0
	- pytorch-lightning: 0.10.0rc1
	- tqdm:              4.48.0
* System:
	- OS:                Linux
	- architecture:
		- 64bit
		-
	- processor:         x86_64
	- python:            3.7.7
	- version:           #100-Ubuntu SMP Wed Apr 22 20:32:56 UTC 2020

Hey @rotabulo thanks for the report, could you describe the case/give a code example where PL_GLOBAL_SEED is None at this step?

I got the same error while training. I am using pytorch_lightning:1.3.8, torch: 1.9.0+cu102.
It seems to happen at random, so i am not sure how to reproduce it.
Here's the pytorch lightening error message

Traceback (most recent call last):
File "train.py", line 203, in
trainer.fit(model)
File "/home/sid/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 460, in fit
self._run(model)
File "/home/sid/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 758, in _run
self.dispatch()
File "/home/sid/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 799, in dispatch
self.accelerator.start_training(self)
File "/home/sid/miniconda3/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py", line 96, in start_training
self.training_type_plugin.start_training(trainer)
File "/home/sid/miniconda3/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 144, in start_training
self._results = trainer.run_stage()
File "/home/sid/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 809, in run_stage
return self.run_train()
File "/home/sid/miniconda3/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 909, in run_train
self.training_type_plugin.reconciliate_processes(traceback.format_exc())
File "/home/sid/miniconda3/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/ddp.py", line 383, in reconciliate_processes
torch.save(True, os.path.join(sync_dir, f"{self.global_rank}.pl"))
File "/home/sid/miniconda3/lib/python3.8/posixpath.py", line 76, in join
a = os.fspath(a)
TypeError: expected str, bytes or os.PathLike object, not NoneType

Can we re-open here or get some guidance how we can make reproducible? I see this at random (re-run does not produce it) on DDP on slurm. Too many workers?


"Other You" follower changes appearance

"Other You" follower will change appearance when player changes appearance at enhance.
Fixed in mod linked below.

Details
https://www.nexusmods.com/starfield/mods/5426
Game Version
1.7.36
Language
English (EN)
New Game
Yes
Reproduction Steps
https://www.nexusmods.com/starfield/mods/5426

Based on a bit of digging by connerria, it doesn't appear that "Other You" is supposed to change their look when you do. This dialogue distinctly mentioned you having a difference appearance to them.

Now that the Creation Kit's been released we've gotten original source code (and comments!,) so I've decided to go back and check the Other You Elite Crew Script. Troublingly it revealed this to be intended behavior as the CopyAppearance function apparently is not completely persistent:
State hasbeentriggered
    Event OnLoad()
        ;do nothing
    EndEvent

    Event OnUnload()
        gotostate("WaitingForPlayer") ;Copy Appearrance needs to be called once per Load since it can reset
    EndEvent
EndState

If you want to work around this issue my recommendation is doing something like the following:
State hasbeentriggered
    Event OnLoad()
	;Copy Appearrance needs to be called once per Load since it can reset
        ;have this actor match the player
        Actor PlayerREF = Game.GetPlayer()
        Self.WaitFor3dLoad() ;wait for 3d to fully load
        CopyAppearance(PlayerREF)
    EndEvent

    Event OnUnload()
        ;Do Nothing
    EndEvent
EndState

This will avoid calling ForceRefTo multiple times (and just generally avoids repeating work that's already been done,) while still avoiding the issue BGS ran into, but it will bring back the non-immersive face swap.
I haven't had any issues without CopyAppearance being repeatedly called, personally. But that's just me. I'm not sure what the correct path forward for your project is. :)
Best Regards
- EpicestGamer


[Docs] Required version of java is different in different parts of the documentation

The required version of java to run Ghidra is different in different places in the documentation.

https://ghidra-sre.org "Installation Guide" points to https://htmlpreview.github.io/?https://github.com/NationalSecurityAgency/ghidra/blob/stable/GhidraDocs/InstallationGuide.html, which states you need JDK 17
https://ghidra-sre.org/InstallationGuide.html (which I now think is abandoned) states that you need JDK 11
The wiki (https://github.com/NationalSecurityAgency/ghidra/wiki/Frequently-asked-questions) also states you need JDK 17
The README.md in the repo root says you need JDK 21

It would be nice if someone who can update the docs could spend a few minutes and try to at least add notes to what I'm assuming are very-out-of-date documentation that said docs are no longer valid. A couple of the pages here (particularly https://ghidra-sre.org/InstallationGuide.html) show up very high in in search results and I now need to uninstall JDK11.

100%

The org page you link to is not owned/operated by NSA

With respect to the ghidra-sre guide, it states "The installation information provided is effective as of Ghidra 9.2 and is subject to change with future releases." So it is 3 years out of date.

https://ghidra-sre.org/InstallationGuide.html should be deleted...I'll try to make that happen.
The rest of the issues you bring up are a result of different git branches requiring different versions of the JDK.  Currently, the master branch, which does not correspond to anything we've released yet, requires JDK 21.  The latest release we've put out, which always corresponds to our stable branch, requires JDK 17.  When we release Ghidra 11.2, the updated stable branch will require JDK 21, and some of the confusion will be cleared up.
The README.md in the repo root should say JDK 21, since that corresponds to the master branch.
Ultimately, the InstallationGuide.html found within the docs directory of the release you downloaded will tell you the correct version of the JDK to use for whatever version of Ghidra you are running.


Use Webpack as module system, compiler and minifier

Webpack has been tested enough internally to be roadworthy at this point.  It will handle our CommonJS bundling (with the much-needed multi-bundling included), our CSS and JS compilation and uglifying.
We can remove a lot of the devDependencies in package.json with this, including Browserify and our CSS/JS deps, and get the bloat down.

Might be interesting to use the "hot loader" as well:
https://github.com/webpack/docs/wiki/hot-module-replacement-with-webpack
So, we're solving issue #47 as well ( https://github.com/rehabstudio/fe-skeleton/issues/47 )


Decoder Attention Module needs a FF network as well in perceiver_io.py script

Hi,
According to perceiver io paper's (https://arxiv.org/abs/2107.14795) architectural details, they mention that the decoder attention block contains a cross attention block (4), which is already implemented in the perceiver_io.py script (Line 151), followed by a Feedforward network, given by equation (6) in the paper, which is not present in that script. I am not aware of the repercussions of not having FF in the decoder module but it might be a good idea to have it in the implementation.
Something like  self.decoder_ff = PreNorm(FeedForward(queries_dim))  would do the job.
Experimentally, the authors had found that omitting equation (5) is helpful.

@Hritikbansal indeed! I missed this detail, and I've added it into the latest version :) thanks!

Hi @lucidrains, thanks for taking a note of this.
I looked at the latest change, and I believe that it should be
 latents = self.decoder_ff(latents) + latents
instead of
 latents = self.decoder_ff(latents) as per equation (6) in Line 182.
Thanks a lot for your work on this implementation! It is really helpful :)

@Hritikbansal No problem! So I actually reverted it for now, because I am reading their public implementation https://github.com/deepmind/deepmind-research/blob/master/perceiver/perceiver.py#L620 and I don't see this feedforward

@Hritikbansal not sure what's going on, so I made it optional with a decoder_ff flag! hope that is good for you!


Allow the editor dock to have a lower width

Closes #23079

This is how it looks on a new project on my side :

Thanks!


Allow users to store their own presets

Is your feature request related to a problem? Please describe.
The currently available quick presets are useful. The main limitation is that users cannot adjust these settings.
Describe the solution you'd like
Add models, endpoints, and UI such that users can create their own presets. For now, it is sufficient to keep the presets in the categories frequency, impact, quality, chromosomes, and "flags etc.". Inheritance does not need to be configurable. Users should be able to adjust the entries in each category, starting out from the factory defaults.
The UI shall be implemented in Vue.js and thus this will be a bollonaster only feature.
Describe alternatives you've considered
N/A
Additional context
N/A

Resolution Proposal
We will need to implement new models, endpoints, and UI in the variants app. Integration into the variant filtration UI will be done by configuring the default presets for a project.
Affected Components
VarFish server
Affected Modules/Files

variants

Required Architectural Changes
None
Required Database Changes

Introduce models for representing the query presets.
Introduce a new model for storing the default query presets per project.

Backport Possible?
No
Implementation Plan

[ ] Add models for representing preset sets
[ ] Add UI to create preset sets by copying from factory defaults or existing presets set
[ ] Add UI for editing the preset sets
[ ] Add model for storing default presets set for a project
[ ] Add UI for displaying and showing the default presets set for project


Fix bottom sheet shadows

Platforms Impacted

[ ] iOS
[ ] macOS

Description of changes
The background color of the shadow view needs to be set for the bottom sheet shadows to display correctly.
Binary change:

File
Before
After
Delta

libFluentUI.a
29,091,992 bytes
29,094,680 bytes
2,688 bytes

Verification

Before
After

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[ ] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

Oh wow, my eyes were totally deceiving me into seeing a shadow hahaha. Thanks for catching this!


Add files via upload

Added Carter integration, adapted from https://github.com/TheMechanic57/Carter-Discord-Boilerplate

Testing will be preformed


Mqtt gateway

Hi!
Here is the pull request for the mqtt gateway. I'm using the latest version, but if everything works well i will add the "stable" version too :)

@ReverseEngineeringDE can you accept the pull request please ?

See Saic-Home-Assistant-Addon, this pull request is not longer required.


Design and implement support for Hub methods returning Streams and IObservable

We want to support Hub methods returning streams of data, like this:
public IObservable<Thingy> Subscribe()
{
}

public Stream DownloadFile()
{
}

We need a design and implementation to support this.

Related, but not covered here: Sending binary data to the Hub. We can do this using byte[] right now, we just have to make it as efficient as possible.

As a little proof of concept, not quite related to SignalR, but which I made because SignalR didn't support it: WebStreams, eg: https://github.com/WebStreams/WebStreams.Samples/blob/master/StockTickerController.cs
And methods can also consume observables: https://github.com/WebStreams/WebStreams.Samples/blob/master/ChatRoomController.cs#L48
I used Orleans as the "backplane", but that's not in any of those repos.

Nice!


Configuration location improvements

I'm working on distributing blockstack with the native macOS app. As part of this, I'd like to make sure that blockstack's configuration gets installed in an appropriate location inside ~/Library (like other macOS apps)
It looks like we can currently set the location of the configuration file using the
BLOCKSTACK_CLIENT_CONFIG environment variable.
Running BLOCKSTACK_CLIENT_CONFIG=/Users/larry/my-blockstack-config/client.ini creates that config file and a few other files in that same directory.

It seems weird to be able to specific an arbitrary name for client.ini but not of the other files.

It doesn't seem to be possible to change the location of BLOCKSTACK_METADATA_DIR without editing the configuration file after it is created. BLOCKSTACK_METADATA_DIR is hardcoded to ~/.blockstack/metadata even if BLOCKSTACK_CLIENT_CONFIG creates another directory.

I'd expect that metadata would default to being in a subdirectory of the client configuration directory.
Would it make more sense to instead have an environment variable or command line option to specify the a configuration directory and have the layout of files and subdirectories within that folder be consistent? (or am I using this wrong?)
Something like:
BLOCKSTACK_CLIENT_CONFIG_DIR=~/my-blockstack-config blockstack
or
blockstack --config=~/my-blockstack-config

@larrysalibra we're merging CLI into Core. We took care of most earlier Github issues and it's better to start new issues on the Core repo -- thanks!

We've move/migrate any remaining issues from this repo as well. Should be done this week.

roger!


Doc improvement for new users

This addition helps users use the gilbert tools to work on the site, updatingand serving static output as needed.

And more thanks!


Better registration of the main layout component

I am closing this since the default way of providing the main layout using a parameter already allows for more complex "registration". The component containing the router can inject services and programatically change what main layout is to be used so I dont really see a reason for any other way to register the main layout to exist.


Avoid dead code warnings for users of async.

This fixes #105 (rather than 150, as incorrectly claimed in the commit comments.)


Poetry fails to install dependencies for vector-db-benchmark.

The poetry install command mentioned in the Run the client section of your README file doesn't run as expected and returns with the error:

No dependencies to install or update

Installing the current project: vector-db-benchmark (0.1.0)
Warning: The current project could not be installed: No file/folder found for package vector-db-benchmark
If you do not want to install the current project use --no-root.
If you want to use Poetry only for dependency management but not for packaging, you can disable package mode by setting package-mode = false in your pyproject.toml file.
In a future version of Poetry this warning will become an error!

Ubuntu 23.04
Python 3.10.14
Any ideas how to solve the issue?

maybe like this ?
cd vector-db-benchmark/
poetry install


forge test --debug hangs on large-ish memory expansion

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (f6361e6 2022-12-01T15:20:08.643454Z)
What command(s) is the bug in?
forge test --debug testCheckMem
Operating System
macOS (Intel)
Describe the bug
Using the following test:
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

import "forge-std/Test.sol";

contract MemTest is Test {
    function setUp() public view {}

    function testCheckMem() public {
        uint256 _ptr = 1e6;
        uint256 val;
        assembly {
            mstore(_ptr, 1)
            val := mload(_ptr)
        }

        assertEq(val, 1);
    }
}

Run forge test --debug testCheckMem, then G to go to the end of the execution.
The forge process now stays stuck on 100% for 5+ minutes, even without further interactions with the debugger.

A process sample suggests that forge is continuously allocating and moving memory with plenty of calls such as
_malloc_zone_malloc  (in libsystem_malloc.dylib)
_platform_memmove$VARIANT$Haswell  (in libsystem_platform.dylib)

@brockelmore any ideas or suggestions where to start debugging this?

Yeah so the TUI is very poorly designed and is 99% tech debt from getting a basic MVP (but its a relatively low usage feature so it never got much love).
My guess is that given we draw the page every 200ms, there is a decent chance we are allocating a ton of stuff each time. I am gonna profile it and post it here...

As I suspected, we do a ton of allocations due to strings and building up the TUI. So converting things to &str, &'static str, etc should help a lot

@brockelmore should we add a 1-line doc on the README on how to generate flamegraphs?

@brockelmore should we add a 1-line doc on the README on how to generate flamegraphs and in which platforms it works / doesnt (i haven't tried generating one in a couple months, but mac's lack of pprof made that not super easy)

I believe it should work on macos via dtrace (the above was ran on macos w/o anything besides cargo flamegraph). just have to run the tracer as root.
sudo cargo flamegraph --manifest-path ./path/to/foundry/Cargo.toml --bin <package> -- <[OPTIONS]>


Spinner looks weird when centered on odd number parent container widths...

When I add the spinner to my site I noticed that half of the time it looks really weird on Chrome. Looks fine on Safari and Firefox.
It seems it looks weird when the parent container of spinner has a width with an odd number of pixels...
Check out the weirdness: https://drive.google.com/file/d/13aGRQdhJ-d6pxOo1fZPl3sfwJijRcnWx/view?usp=sharing
Is this some sort of rounding error?

@benmcmaster Can you share the code to reproduce? E.g. by forking this StackBlitz example: https://stackblitz.com/edit/spin-js-starter?file=index.ts

Closing since I don't have a way to reproduce this.


feat: add autofix for logical to inline properties in valid-styles rule

Context
As per internal discussions, let's add an autofix into the valid-styles rule. Some of this logic exists in the valid-shorthands rule, but it makes sense to move the erroring here for the repos in which valid-shorthands is not enabled.
I've kept the descriptor in the autofix short and simple to avoid clutter on a lint error that will likely crop up a lot, but can also link to https://fb.workplace.com/groups/stylexfyi/posts/1769833193785624 or something related as context. Open to feedback here!
As a next step, we should work towards splitting up the valid-styles rule into more discrete chunks to increase the granularity of error reporting/messaging (perhaps after the codemodding)
Tests
Added tests for the following styles:

marginStart -> marginInlineStart
marginEnd -> marginInlineEnd
marginHorizontal -> marginInline
marginVertical -> marginBlock
paddingStart -> paddingInlineStart
paddingEnd -> paddingInlineEnd
paddingHorizontal -> paddingInline
paddingVertical -> paddingBlock

Pre-flight checklist

[ ] I have read the contributing guidelines
Contribution Guidelines
[ ] Performed a self-review of my code

LGTM (once message bikeshedding is complete)

I had to google this #til Parkinson's Law of Triviality


Document dynamic tag limitation

We document a useful dynamic tags pattern here: https://docs.astro.build/en/core-concepts/astro-components/#dynamic-tags
TIL that this does not work for client:* components and we should document this caveat.
Details here: https://discord.com/channels/830184174198718474/1021446382982266910/1021468769102598206

I think this was closed by #1596? Closing here, but reopen if I got this wrong!

Yes! Thank you 💜


Ajson

Can I ask why you switched from arduinojson to ajson?
I'm looking at integrating this project now so trying to get to grips with it.
Looking at the json string I thing you limit of 8 lights is to do with you json print buffer size. I can do 10 actually. But it breaks once my strong goes over 4096 chars.
The original hue strip light I think can only be one colour at a time. Just looking at their promo video. So one solution would be to set how many hue lights u want to a max of 8, then dividing the strip up by that number?
I'm going to try and use spiffs to store the led state so that u can name the lights, add groups etc.

Just seen this in the API docs
Starts a search for new lights. As of 1.3 will also find switches (e.g. "tap")

The bridge will search for 1 minute and will add a maximum of 15 new lights. To add further lights, the command needs to be sent again after the search has completed. If a search is already active, it will be aborted and a new search will start.

At the time I tried wrapping my head around ArduinoJson, but found it cumbersome to use (I am not a fluid C/C++ programmer).
Your idea to "set how many hue lights u want to a max of 8, then dividing the strip up by that number" sounds good to me, actually I had been thinking of the same some time ago, but didn't really want to acknowledge that the ESP8266 might not be capable of doing more.

@sticilface still interested in implementing this?


Travis always gives error

Like even here https://github.com/pages-themes/slate/pull/59

The problem is rubocop: https://travis-ci.org/github/pages-themes/slate/builds/765322596#L468
Just edit the .rubocop.yml file as shown here: #54

Thank you for your answer. It worked for my 2 request: https://github.com/pages-themes/slate/pull/58 and https://github.com/pages-themes/slate/pull/57. But it din't here: https://github.com/pages-themes/slate/pull/59. Can u explain why?

No problem!
#59 failed because your markup used an illegal font-size value.
The CSS specification expects real numbers to be in North American decimal style, so change , to . in the style-sheet:
diff --git a/_sass/jekyll-theme-slate.scss b/_sass/jekyll-theme-slate.scss
index 5b244dc..414d488 100644
--- a/_sass/jekyll-theme-slate.scss
+++ b/_sass/jekyll-theme-slate.scss
@@ -418,7 +418,7 @@ Small Device Styles
   }

   code, pre {
-    font-size: 0,688em;
+    font-size: 0.688em;
   }

 }
@@ -468,7 +468,7 @@ Small Device Styles
   code, pre {
     min-width: 240px;
     max-width: 320px;
-    font-size: 0,688em;
+    font-size: 0.688em;
   }

 }

It worked. Thank you.


Horizontally draggable quasar q-cards

I've seen a few 'solutions' online about this but to no avail for us. We're working with the quasar framework and trying to setup a horizontally wrapped set of  that are are draggable (for re-ordering). Below is the basic stub of the code we're working with to get this going. However, we're not able to get the cards to layout horizontally everything is stacked in a list. What are we doing wrong?
<template>

    <draggable
      v-model="items"
      group="items"
      direction="horizontal"
      item-key="id"
      @start="drag = true"
      @end="drag = false"
    >
      <template #item="{ element }">
        <q-card class="card">
          <q-img
            src="~assets/temp/bb-auto.png"
            :alt="`Image ${element.name}`"
          >

              Image {{ element.name }}

          </q-img>
        </q-card>
      </template>
    </draggable>

</template>

might be unrelated, but your item-key is id which is not part of your items object ... maybe change it to item-key="name"
Other than that horizontal is the standard if you don't provide the prop, so maybe you want vertical? The Sortable doc states that it detects it automatically, so maybe try to not specify it at all.
If possible provide a jsfiddle or some kind of sandbox example to make sure it is not caused by your setup

Thanks for the response. It turns out my overall layout was wrong in and of itself. I got that sorted and was then able to back that into the layout I needed. Below is the working code. I needed to treat the  container as if it was my row.
<template>
  <draggable
    v-model="items"
    group="items"
    class="q-pa-md row items-start q-gutter-md"
    direction="horizontal"
    item-key="name"
    @start="drag = true"
    @end="drag = false"
  >
    <template #item="{ element }">
      <q-card class="card">
        <q-img src="~assets/temp/bb-auto.png" :alt="`Image ${element.name}`">

            Image {{ element.name }}

        </q-img>
      </q-card>
    </template>
  </draggable>
</template>

If this is a quasar-style component,there should be a ‘content-class’ prop.


[exiv2] update to 0.27.5

Fix #21754
Fix #21943
Update [exiv2] to the latest version0.27.5
All features have been tested successfullly in the following triplet:

x86-windows
x64-windows
x64-windows-static

Thanks for the update!


Problem: Task Templates Last Task showing status of task ID from another project

Issue
When there are multiple projects, under 'Task Templates' the 'Status' and 'Last Task' fields can show status and task ID from a task ran in another project.
Impact
Web-Frontend (what users interact with)
Installation method
Package
Database
BoltDB
Browser
Firefox
Semaphore Version
2.10.22-e44910d-1721658299
Ansible Version
ansible [core 2.16.9]

Logs & errors
Screen shots show 'Last Task' status of task<PHONE_NUMBER> ran under 'VLAN Demo' project also shows same task ID status under another project named 'GNS3'. If you click on the last task ID link under the GNS3 project it does nothing since the task was not ran under that project.

Manual installation - system information
nginxx
Configuration
Can be recreated by creating two projects (e.g. named Project1 and Project2). Create a Task Template under each project to run an Ansible playbook. Run the Task template in Project1, switch to Project2 and observe that the last task from the task ran in Project1 is being shown in Project2
Additional information
This problem does not exist in e.g. SemaphoreUI v2.9.112f

Just to add more details to this issue. I did a fresh install of Semaphore 2.10.22 using MySQL (MariaDB) as the back end and the problem does not exist. So, this seems to only be a problem with Semaphore 2.10.22 when using BoltDB.


Use google.protobuf.timestamp instead of uint64 for timestamp

for better semantic and save space.

Done.


Add description to schemes

A description is a one-liner describing the key features of the scheme.
I've added descriptions for most schemes, but some are still missing. Please add them if you feel you know a scheme well.

We're still missing descriptions for

ntru-prime
three-bears
FALCON
LUOV
mqdss
Picnic
SPHINCS+

A sentence about ntru-prime for @dingens 🙂 I think it's best characterized by this sentence from the spec "NTRU  Prime  uses  a  prime-degree  number  field  with  a  large  Galois  group  and  an  inert modulus, minimizing the number of ring homomorphisms available to the attacker." Or in other words; ntru-prime is a version of NTRU that reduces the attack surface by using a prime-degree number field.

I'd like to merge this now so we can already use the new schema (in the pending pull requests) and use the data that is there so far. We could then continue tweaking the descriptions in a new branch (and PR). OK?

I'd like to merge this now so we can already use the new schema (in the pending pull requests) and use the data that is there so far. We could then continue tweaking the descriptions in a new branch (and PR). OK?

fine with me


Special characters problem

Ok. Back again with a new issue that i cant figure it out this time :(
My problem is that i use special characters in my json file that can't be recognized by the plug-in. What i mean is that in Greek Language the letters α, ά or ε, έ are the same letters but if you type the letter α in the search input field it doesn't highlight also the letters ά in the results list ! How can i fix this issue Sergio?
Thanks!

Hi,
Are you knowledgeable with javascript?
Because of this kind of problems I made available a callback option so that you can manipulate the string/word comparison.
Check out option normalizeString:
http://projects.sergiodinislopes.pt/flexdatalist/
Code (normalizeSpecialCharacters function must be implemented by you, that can replace special characters):
$.flexdatalist({
[..]
normalizeString: function (string) {
return normalizeSpecialCharacters(string);
}
});
In the documentation, you'll find a reference to a plugin:
https://github.com/dundalek/latinize
Would this plugin help solve your problem?
Sérgio

Thanks for quick reply Sergio. i m not so sure about "latinize" plug-in but i think that this plug-in just replace one character to another eg. "ά" to "α" etc.
What i m trying to do is to make flexdatalist understand that "ά" is equal to "α" and vice versa, NOT REPLACE "ά" with "α" etc.
Is this possible with "Latinize" plug-in ?
Once again thanks for looking into my issue.

Fair point. Yeah, the plugin will replace "ά" with "α" just for comparison sake in the search (not changing the source string).
Unfortunately, AFAIK, javascript regex is not very good with special characters. :\
One solution, that I'm trying to avoid, is having all special characters mapped to non-special characters... but, that would considerably make the plugin bigger in size.
If someone more knowledgeable can help with this, I would appreciate it.
Sérgio

Hi Sergio. i tried almost everything but doesn't work :(
My best approach was this :
i wrote a js code that convert "ά" to "α" but this happens inside the input field and not inside the hilight function of your plugin.
<script type="text/javascript">
$(function() {
    $(".location-search-field").keyup(function() {

        $(this).val($(this).val().replace(/ά/g, "α"));

        });
});
        </script>

is there any way to implement that code to take action inside the hilight function?

Hi,
If you can make the plugin work for you case, great. It's definitely a problem that I'll keep thinking on a solution.
Working in portuguese language projects, I face the same problem/limitation. :\
Sérgio

hi there sergio is there any solution for this?

hi there sergio is there any solution for this?


How i can add reaction serverside.

Hi!
I used version 3 before but after upgrading version 4 I can't find the way to create a new reaction in serverside. Because I need to do some logic before add new reaction.
Documents only show create new in client side
const client = stream.connect(STREAM_API_KEY, userToken,  APP_ID);
let like = await client.reactions.add("like", activityId);
Thanks for the help.

Hey @phongloihong did you find a way around this? I'm trying to do the same thing.

Hi @frenchdonuts
I'm moved reaction action to the client-side and use webhook to update in my local database


Merge Cells with Wrap Text Breaks Height

I'm attempting to merge two cells in a row. I have the row style set to alignment: { wrap_text: true }.
My expectation is that the height of the row would stretch vertically to fit the contents of the cell (which Excel does when merging cells).
However, the cell height remains fixed and causes the cell contents to be unreadable.
Here's a screenshot
Notice in the highlighted section you only see the bottom portion of text.

Without merging
The text wraps correctly and the height of the cell is adapted.

Basically what I'm doing
excel  = Axlsx::Package.new
wb     = excel.workbook
style  = wb.styles.add_style(alignment: { wrap_text: true })
wb.add_worksheet(name: 'Some File') do |sheet|
  array_of_text.each_with_index do |text, row_num|
    row_num += 1
    sheet.add_row [text], style: style
    sheet.merge_cells("A#{row_num}:B#{row_num}")
    sheet.column_widths 30
  end
end

Am I doing something wrong or is this a bug?

I'm having this issue as well…

This seems to be an Excel limitation (!)
ref Microsoft forum (source)

Am still facing this issue, any solution ?


Download Code from Currently Opened Folder in VSCode Workspace

Currently in VSCode.dev, the user has the option to download their currently opened code in the workspace to their local machine:

They can then select which folder in their local machine they want this code to be downloaded to. It appears that this feature is implemented by VSCode itself. Is it possible that this can be exposed to where those developing VSCode extensions can use this feature? For example, this can be exposed via a command that can be used with other components

This is a request from Azure Functions ^

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

@lramos15 Any update on this? Thanks

No progress. Is the ask for extension to be able to download arbitrary data to the users machine?

@lramos15 It's about exposing the option to "Download" the code programmatically - without having the user click this button. Something such as a VS Code workbench command that would download their workspace code as a zip for example would work
We have this view that will make it easier to get started. The "Save project code" button here is limited because clicking on it gives the user a message popup to right click their workspace and select "Download..." - seen in screenshot in the initial post. Ideally - we want this to happen automatically but the functionality the "Download..." button exposes is not available today to my knowledge

@lramos15 ICYMI. Thanks

Have you tried executing the explorer.download' command from your extension?

@lramos15 I see - this is what we're looking for but is there a way to select only specific files/folders to download that are in the workspace? Are there docs on this cmd?

There are not. This command is very explorer scoped, as evidence by the name. It takes the explorer selection and downloads that otherwise it downloads the whole workspace. This feature request you filed as I understand it would be to expand this to take a list of URIs to download or something similar but it is not currently prioritized and is on the backlog.


Upgrade center crash

Bug Report
Describe the bug
When going into upgrades menu it will freeze your game and you will have to close it from taskbar
To Reproduce

Go to 'upgrade station'
Click on 'button'
See error

Expected behavior
I expected it to open the upgrade menu but it crashed my game.
Screenshots
Game Info (please complete the following information):
Other Mods
e.g. Gold Largos, Science Favorites, etc. (Both from UMF and SRML)*
no other mods
Game Version
1.4.2
Mod Version
pre-alpha of Vikdis
Additional context
impossible to progress because of this

Seeing as Science Favorites hasn't worked in a year im closing this bug report. If it still happens when you remove the mod, make a new report.


Thanks for the report! There really isn't much to do to make run_cloud.sh run on OSX...how about we change the description of this issue to "run_cloud.sh should work on OSX"? And we can track all dependent issues here:
https://github.com/uProxy/uproxy/issues/2598

I looked into this. There are complications with --net=host on Docker for Mac which make this hard. The issue is the link from the SSH container to the Zork container: uproxy-sshd needs to know where to contact Zork - this is pretty easy on Linux because we can just use docker0s IP but Docker for Mac has no bridge. We can instead use the system's current IP but since that's likely to change when the user switches wifi networks it's not a great solution.


Aligned image download progress indicator

Changes Unknown when pulling 5d3ef1af8ed2e36216433e919b93d156b40824a3 on align-style-container-progress into ** on master**.

LGTM


Move otel operator CRDs to templates

Partially resolves #1167. See the issue for more details. I ended up patching both the webhook name and the certificate name in addition to the namespace in the CRD.
I verified the upgrade procedure manually.

Looks like the failing test is flaky, it passes locally for me.

You will need to bump the minor version of the chart and regenerate the examples via make generate-examples CHARTS=opentelemetry-operator.

Similar to how managing the CRDs via the crd directory is optional I think installing the CRDs via the template should be optional as well. We should add a new section to the values.yaml that allows controlling when the templated CRDs are installed.

Does a top-level installCrds option sound good? Or do we want something more elaborate?

Since we're allowing templating, it feels possible someone will want to set a specific value, so I think a section called crds or installCRDs with an enabled field is good.

+1 to tyler's recommendation

Added a crds section to the values file, with a create: true option. This makes it consistent with other create-stuff options that currently exist.
It's increasingly annoying to automatically convert CRDs published by the operator into the form the Helm Chart wants. I added a make function to make this easier, but at some point we may want to look for a more holistic solution here.
@TylerHelmuth can you have another look? Also @pavolloffay.

I think something I'm missing here is that this change only works with cert-manager enabled. I should inject the caBundle directly when using a Secret. Please don't merge this until then, I'll get to it tomorrow morning.

Currently the chart has a cert-manager requirement by default, but supports other options. We definitely need the CRDs to work without the cert manager like they were before. I'm ok with the CI continuing to use cert manager for now since that is our default requirement

Thinking about it a bit more, that change isn't necessary in this PR, as there's no conversion webhooks defined, and the CRDs don't need a caBundle. So we can merge this as-is and solve this problem in the actual upgrade do 0.99.0.

I've added running e2e tests without certmanager to the CI. We can remove it later if you want, but I'd like to have confidence everything works right in both cases for the CRD migration.