Solicit general feedback from the community

Mark will post to a few online Magician community forums and see what the reaction and feedback is from them.

Status:  In-flight.

Posted a topic in the Theory 11 Forum.
eMailed a request for an article to iTricks.com.
eMailed a request for feedback to Penguin Magic (Lee had mentioned that they attempted this once).
Posted a topic in The Magic Cafe Forum

We just got a tepid response from the forums.  Only 2 posts in the first few days.  We are having much better luck by directly contacting magicians, recruiting them as 'Consulting Magicians' and getting direct feedback from them.
We can leave this open and set it for Milestone 3 -- basically, when the project is wrapping up, hit the forums with a link to our deployed site and get more feedback.

Got a killer post this morning from Justin Morris http://www.morrismagic.ca.
From: theory11 forums<EMAIL_ADDRESS>Subject: Online Magic Act Generator - New reply to watched thread
To: mnelson<EMAIL_ADDRESS>Date: April 2, 2015 at 8:58:54 AM HST
theory11 forums
mnelson, Justin.Morris replied to a thread you are watching at theory11 forums.
Online Magic Act Generator
Justin.Morris
I just checked out yours and penguins. I can't really get Penguin's to do anything. Your layout is much better, being able to browse sets and routines would be really interesting. One suggestion would be to add search filters (most liked, most popular , newest, category, materials, price etc)
I would have found this very interesting when I started out. People generally love to share and brag, so I can see people contributing set ideas and routine ideas. It would really motivate people to share quality work if there was some sort of (tangible?) reward system for those whose routines, and sets they share are most liked or something.
Two challenges and two thoughts. First as Ibimania suggested, it takes away some of the art of it when you use other people's canned shows and routines. There's something beautiful about creating something yourself and performing it. That said, a beginner will use sets of purchased tricks and use the same canned patter, and will have great success as a hobbyist (and even perhaps a few paid gigs). The professional will branch from there and create their own material and own patter that reflects them. They won't share that, however that's not necessarily the aim. It might be interesting to think about a) adding an element that encourages growth in the area of creativity, and b) finding some way to target and encourage participation from those who have moved beyond canned patter.
The second challenge is that material could be so easily ripped form another magician. "I saw Wayne Houchin put these trick together with this theme , to this music, and say this _, so I will write this as my own idea and share it." Aside from a report button and encouraging credit to be given, I don't know if you could ever police that. I wouldn't like to find my show up on something like this.
One final thought. I am not super creative. When it comes to tricks, I can easily modify someone's idea, but I have only made one workable effect that I use in my show. The rest are purchased effects that I have adapted to fit my show.
I'm a presenter. Give me anything and I can present it. However it takes me ages to create because I'm not a creator. The same with scripting. give me a script that I can tweak, and I can work with that. Creating my show has taken years (That's not a bad thing - like aging a wine, but some people can crank that stuff out). So I can see two sides to this. It may be interesting to help people see potential by letting a few people contribute routines to one set. For example, someone puts together three effects and gives a nice patter and theme to it. Someone else could add a different twist to the theme and patter, and others could do the same. Then someone looking at the sets could see the set and four or five different themes like time travel, murder mystery, pop culture, and science fiction. This might help people learn how to think out of the box. They don't always have to present an effect as "Let's try an experiment..."
Ultimately, would something like this be helpful? Not sure. But I think there are enough creative and generous people who would love to share and contribute to this to make it work (lots of helpful magicians on forums), but I can also see professionals closely guarding their material. Others would add material of their creation to help sell it - also helpful.
I flip flop, but there's a lot of potential that's worth exploring.


No script tag injected in HTML file

As the title says, the script tag that's supposed to be injected into HTML files is not there.
I noticed this error once (and never again after that, however the problem persisted, so I doubt it has anything to do with this but I'm adding it just in case):
----------------------------------------
Exception occurred during processing of request from ('<IP_ADDRESS>', 46302)
Traceback (most recent call last):
  File "/usr/lib/python3.11/socketserver.py", line 691, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/lib/python3.11/socketserver.py", line 361, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python3.11/http/server.py", line 667, in __init__
    super().__init__(*args, **kwargs)
  File "/usr/lib/python3.11/socketserver.py", line 755, in __init__
    self.handle()
  File "/usr/lib/python3.11/http/server.py", line 432, in handle
    self.handle_one_request()
  File "/usr/lib/python3.11/http/server.py", line 420, in handle_one_request
    method()
  File "/home/kwyntes/.local/pipx/venvs/reloadserver/lib/python3.11/site-packages/reloadserver/__init__.py", line 73, in do_GET
    super().do_GET()
  File "/usr/lib/python3.11/http/server.py", line 674, in do_GET
    self.copyfile(f, self.wfile)
  File "/home/kwyntes/.local/pipx/venvs/reloadserver/lib/python3.11/site-packages/reloadserver/__init__.py", line 39, in copyfile_interceptor
    outputfile.write(source.read().replace(b'', SCRIPT_TAG + b''))
  File "/usr/lib/python3.11/socketserver.py", line 834, in write
    self._sock.sendall(b)
BrokenPipeError: [Errno 32] Broken pipe
----------------------------------------

Reloading does work properly in the directory listing though.

Can you post the file you're seeing the issue with?
It decides whether to inject the script tag based on the content-type header (as determined by Python's http.server), and uses the closing  tag to determine where to insert the script. If either the content-type is incorrect or the closing tag is missing, the script won't be injected.

Ah I just found out the file was indeed missing a closing  tag, so that fixes it.
It would be nice however to have the script tag be appended/prepended to the file in case of a malformed document such as this one though, since then the reloading doesn't break whenever something messes up the HTML file (bad codegeneration for example).

Not a bad idea. The other option would be to print an error message when that happens.
Which do you think would have been more useful in your case?

A warning that the file contains malformed HTML (or at least a missing closing  tag) while still injecting the script tag would be a nice in-between I think.

Fixed by #4


Display link to repository after branch deletion

Closes #1487.
The link is still crossed out and "Deleted" is still displayed, but it's clickable and you will be redirected to the repository.

@rzpio Do you have a test PR I can try this out on?


WebExtension menus ContextType is missing viewType property

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/OnClickData
fired from an onShown event. I also looked at when it is fired from inside an add-on popup.
So I looked at the info object and this is how it actually looks in Firefox 65:
"usual tab":
contexts: Array [ "page", "all" ]
editable: false
frameId: 0
menuIds: Array [] // empty
viewType: "tab"

popup:
contexts: Array [ "page", "all" ]
editable: false
frameId: 0
menuIds: Array [] // empty
pageUrl: "moz-extension://2dacb47d[...]/popup/qrcode.html"
targetElementId: 3187
viewType: "popup"

contexts and menuIds are documented in onShown, but the following ones are nowhere documented:

viewType (seems to be useful, but undocumented)

There is already a page for ViewType, but I've added it to the OnClickData page in the appropriate place as:
viewType {{optional_inline}}
{{WebExtAPIRef("extension.ViewType", "ViewType")}}. The type of extension view.


Minor refactoring to make things easier to read.

Making the interpreter pattern actually match the spec of the pattern, each node should implement the interface. (Related to issue #48).

Not strictly needed, but it does make the code easier to read, so it is accepted.


Add Query.Select(IEnumerable) overload

It would be very helpful if you could add an overload to Query.Select that accepts a IEnumerable<string>.
I have a list of columns as an IEnumerable but in order to add to the select list i need to unnecessarily convert them to an array.

Would you mind adding a PR for this?


Virtual Keyboard-Backspace button not working with Web Browser widget (4.15)

The backspace button on the virtual keyboard example does not remove characters from web browser widget text boxes.
I had created my own virtual keyboard in 4.14 and everything worked fine (my personal keyboard: https://www.youtube.com/watch?v=iOMRT9dZuh4). Porting the project to 4.15 broke the Enter and Backspace virtual keys but all other keys work fine. I used your project to see if your's was having the same issue which sadly it is when using 4.15. I'm pretty sure this issue is an engine bug since its not just my project having issues so I filed a bug report on Epic's Answer Hub but I'm still waiting for someone to reply.
Bug Report: https://answers.unrealengine.com/questions/572915/press-key-bp-node-not-emulating-enter-or-backspace.html

Just giving an update. I finally convinced Epic that it was a bug and they entered it into the bug logger. Looks like it going fixed in 4.16 :D
https://issues.unrealengine.com/issue/UE-43370

Great! sorry for the lack of replying, must have missed this one. Good thing that epic has fixed it now though


Wild guess at inability to find LGTM

I did a small amount of debugging-- I can say that the Etag github returns doesn't change if you e.g. delete a comment from the PR.

Were you looking at the events api?  I doesn't show comments at all...  Labels, assignments, subscriptions...

On which API endpoint is my question. The etag is changing when I add/remove the label from this PR at https://api.github.com/repos/kubernetes/contrib/issues/996/events

Oh, it's the issues/PR#/events api.

hm, maybe it's only particular PRs. I'm no longer confident this change will help...

oh, i have little confidence this PR will help. But it'll definitely give us some more debugging info.

OK, yeah, adding/removing a label causes the Etag to change, but deleting a comment does not, and I observe a false cache hit in that case.


Set 'strtol' family to parse in decimal only

In opt_long(also opt_int), opt_ulong, opt_imax, opt_umax, now they all
call the 'strtol' function family with '0' for the 'base' parameter. And
according to 'man 3 strtol', this means those functions are capable for
parsing both decimal and octal numbers.
This will confuse users while using many apps of openssl command if the
input string is prefixed with a '0', e.g. "0123456" will not be
(dec)123456, but (oct)123456, which is (dec)42798, and something like
"088888888" will be failed.
It's strange to only support octal besides decimal, so let's kill octal
supporting in command ling arguments parsing to avoid chaos.
Signed-off-by: Paul Yang<EMAIL_ADDRESS>
Checklist

Oops, it seems base 0 also means it can process with hex format, but is it common to specify a 'count' or a 'time' in hex or oct format?

Is it common to specify any of those with a leading 0?

It's not common if the args are specified from command line, but it might be common if specified in a script or code. For instance, if someone wants to generate a bundle of different sized random number files for some purposes, the files may seem like: "001.rnd, 002.rand, ... 999.rnd", so one possible way is to generate the file names first and call openssl as openssl rand DDD > DDD.rnd in a loop. Then the command will fail as:
rand: Can't parse "008" as a number
rand: Use -help for summary.

So I think at least it should be documented in both pod files and -help options of the apps, if we still want to accept hex and oct for those args.

Hmmm, or just clarify it in the outputted error prompt is enough, say "leading 0 or 0x is treated as oct or hex number respectively"

-1 for suggest code modification. Error message, yes, sure. -help, yes, but not suggested code modification.

Okay, I'll perfect the error messages, -help and corresponding docs.

@kroeckx @dot-asm I have put words in the error message of opt_long-like functions. Please review again. And I think just clarifying the error message might be informational enough, so do you think it's necessary to update those '-help' or docs also?

Updated.

Red cross from travis is relevant, i.e. needs to be addressed.

Updated: remove NULL at end of array; fix travis-ci failure
@dot-asm @levitte

Merged.  7447c49f0db741f886a9a187e29deef2e2e394db


Deletion of data on offen.dev is not possible

An error occurred: null is not an object (evaluating 'n.resolution')
getDefaultStats@https://offen.offen.dev/vault/index-4e527f4741.js:13:62786
https://offen.offen.dev/vault/index-4e527f4741.js:13:94653
https://offen.offen.dev/vault/vendor-35fb249183.js:13:18998
Le@https://offen.offen.dev/vault/vendor-35fb249183.js:13:13450
Ge@https://offen.offen.dev/vault/vendor-35fb249183.js:13:13937
https://offen.offen.dev/vault/vendor-35fb249183.js:13:14301

Steps to reproduce

Open https://offen.offen.dev/auditorium/
Click "Delete"

I have UBlock Origin installed but as the analytics was tracked I don't think that's the reason.
I also checked the opt-out button, and that one works, and seem to delete the data just fine. Opt in again works too, but delete still fails.

I have UBlock Origin installed but as the analytics was tracked I don't think that's the reason.
I also checked the opt-out button, and that one works, and seem to delete the data just fine. Opt in again works too, but delete still fails.

Thank you for reporting this issue. I can repro and it seems this got introduced in #539
Good news is it didn't make into a release yet (we run offen.offen.dev off the development branch more or less) and it also only caused the UI to break when data was still being deleted.
I'll deploy the fix once 2ec2d50 has been built.

Thank you for reporting this issue. I can repro and it seems this got introduced in #539
Good news is it didn't make into a release yet (we run offen.offen.dev off the development branch more or less) and it also only caused the UI to break when data was still being deleted.
I'll deploy the fix once 2ec2d50 has been built.


[Feature] Provide time as argument

Workflow version
2023.3
Alfred version
5.1.2
macOS version
Ventura, 13.5 (22G74)
Debugger output
...

More details
It would be great to provide a time via argument (e.g.,shutdown 120s, or shutdown 1h) for a timed shutdown.

Thank you for the request, but at this time I don’t intend to add a custom argument for shutdown. Especially if I were to interpret the hours/minutes/seconds as in my other workflows, that’d mean adding code to it and I like that the current iteration has zero code in it: it makes for a good learning resource in a moderately complex set up.


[stable/spinnaker]: Allow kubeconfig to be referenced in encrypted s3 bucket

Signed-off-by: Brian<EMAIL_ADDRESS>
What this PR does / why we need it:
This allows users to take advantage of https://www.spinnaker.io/reference/halyard/secrets/s3-secrets/#secrets-in-s3 and set their kubeconfig to be stored in an s3 bucket instead of a kubernetes secret or the use of a service account. The advantage here being that the secret can be  kept locked and encrypted in s3 and there may be other encryption methods in the future to use for users.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/lgtm

@bnutt Awesome work! I'm trying to use this, but i have some issues....

Why do I need to still creating a secret if I want to use just encryptedKubeconfig, when I try without secret I got volume mount errors in halyard POD.

Why I got AccessDenied in bootstraping by "install-using-hal" POD? I check for my "assume_role"  annotation, whats wrong with?
Bucket: mybucket-tests
Path to kubeconfig: spinnaker/kubeconfig/config
String: encrypted:s3!r:us-east-1!b:mybucket-tests!f:spinnaker/kubeconfig/config

Version: 2.0.0-rc3


DBAL query builders must be immutable

Already done on ORM level, must alter few implementations after covering with unit tests.

For future versions.


Add CalcResult class

Provides the ability to use standard arithmetic operators
Replaces the usual approach to throw an exception or return the null in case of an execution failure

I suggest you to look into the Integer<T> struct implementation that was removed from this repository. May be we can revive such struct by overloading its operators that will use our dynamically compiled delegates for basic operations.

@Vovanda after this will be finished you can also try to compare our solution with existing one (https://github.com/linksplatform/Numbers/issues/31), or may be we can use some ideas from Jon Skeet`s implementation.


To support health probe in application gateway

https://github.com/aztfmod/terraform-azurerm-caf/blob/master/modules/networking/application_gateway/application_gateway.tf#L187
to add health probe creation and configuration for AGW

Closing as integrated into 5.4.2


targetSDK is missing in JSON output

I don't know if it is a bug or a missing feature:
If I import the JSON output from the externallyhosted.py script to Google Play Console, the "Target SDK" field in release management is empty ("-").
As from November 1, 2019, Google requires a target API level of 28+ for new apps and/or updates, this will probably cause some problems. As no target SDK is provided in the JSON, Google seems to use the minimum SDK value (which is 24+ in this case) and warns me, that the app won't be compliant with the new rules.
Is it planned to add the targetSDK to the JSON file in the future?
Thank you very much in advance and best regards!

The target sdk should not be relevant for this feature.  See (issue 26)]https://github.com/google/play-work/issues/26].
When uploading externally hosted apks the target sdk version should not be checked and IIRC the value isn't even checked in the json file.

Thank you for the responst @hdurer , maybe Google changed this as well and is now checking the target sdk version. I got an email from Google, just a few quotes below:

Hello Google Play Developer,
This is a reminder that starting November 1, 2019, updates to apps and games on Google Play will be required to target Android 9 (API level 28) or higher. After this date, the Play Console will prevent you from submitting new APKs with a targetSdkVersion less than 28.

Action required
Please ensure that your apps are configured to target at least Android 9 (API level 28) by November 1, 2019. For technical advice on how to change your app's target API level to meet these requirements, refer to the migration guide.

They included a list in the email with all my applications that are affected. The list included all three of my externally hosted apps, for which I created the JSON with the externallyhosted.py script.
I will try to open a ticket with Google to make sure that the targetAPK level won't be checked in te future for externally hosted apps, and that I can carry on with my process for new apps. I will update this issue as soon as I get an answer.
Thank you very much for your help so far!

Hello again, @hdurer
I finally got a response from Google Support:

I'm sorry that we can't verify the comment that you've got.

But when you receive the alert email from our team, since November 2018, all app updates on Google Play have been required to target API level 26 (Android 8.0) or higher.

You can refer to this blog post
https://android-developers.googleblog.com/2019/02/expanding-target-api-level-requirements.html

So what I understand is the following:
Since November 2018 apps are required to target API level 26. We uploaded externally hosted apps after November 2018 w/o the targetSDK (because it is not exported to the JSON) and did not get blocked or anything.
So I assume you are right and the targetSDK is not relevant for externally hosted apps, and this should not change with the raise to API level 28 in November 2019. I will now close this issue and hope Google won't change it's mind on this.
Thank you very much for your help!


DbUpdateConcurrencyException during update

Contact and ContactDetail entities are used for the one-to-many related database model. Since the Contact entity is Aggregate root, the Contact entity is used to create the ContactDetail record. (like the basket and basketitem object in the eshoponweb application).
The problem is that I am encountering DbUpdateConcurrencyException in _repository.UpdateAsync(contact) code.
Thank you in advance for your help on the subject.
`var contact = await _contactRepository.FirstOrDefaultAsync(new GetContactWithDetailsByContactIdSpec(contactId));
contact.AddDetail(contactDetail);
await _contactRepository.UpdateAsync(contact);
return contactDetail;
`

Can you show more code? That all looks fine. Is there a stack trace? What version of EF, etc. are you using?

Thank you for response @ardalis . This is  repository link https://github.com/abircannet/PhoneBookApp/tree/Development

Sorry for being late.
Exception stack trace:
   at Npgsql.EntityFrameworkCore.PostgreSQL.Update.Internal.NpgsqlModificationCommandBatch.<ConsumeAsync>d__8.MoveNext()    at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.<ExecuteAsync>d__29.MoveNext()    at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.<ExecuteAsync>d__29.MoveNext()    at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.<ExecuteAsync>d__9.MoveNext()    at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.<ExecuteAsync>d__9.MoveNext()    at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.<ExecuteAsync>d__9.MoveNext()    at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.<SaveChangesAsync>d__103.MoveNext()    at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.<SaveChangesAsync>d__107.MoveNext()    at Npgsql.EntityFrameworkCore.PostgreSQL.Storage.Internal.NpgsqlExecutionStrategy.<ExecuteAsync>d__72.MoveNext()
at Microsoft.EntityFrameworkCore.DbContext.d__60.MoveNext()
at Microsoft.EntityFrameworkCore.DbContext.d__60.MoveNext()
at Ardalis.Specification.EntityFrameworkCore.RepositoryBase1.<SaveChangesAsync>d__10.MoveNext()    at Ardalis.Specification.EntityFrameworkCore.RepositoryBase1.d__6.MoveNext()
at Cdr.ContactMicroservice.Domain.Services.ContactService.d__3.MoveNext() in C:\Users\abirc\Desktop\Rise\SolutionRepo\PhoneBookApp\PhoneBookSolution\ContactMicroservice\Cdr.ContactMicroservice.Domain\Services\ContactService.cs:line 37`
I try EF Core Version 6.0.8 and 6.0.10

When I test with MSSQL and SQLite, there is no problem.

Can you try doing the same query with your DbContext but without using Specification? I'm assuming if you send the same set of expressions directly to the DbContext you will get the same exception. @fiseni can send you some more info.

@abircannet did you manage to test directly with DbContext without specs and repository?
Closing the issue due to inactivity. Feel free to re-open it if you need further assistance.


Watching Modules / Themes razor files

So, here the goal is to update a razor file in the application Packages folder when it has been modified in the related module project. This by using dotnet watch.

The 1st strategy was to apply it on the main app but e.g with Orchard.Cms.Web there are so many ProjectReference that it was taking quite a long time to react on a file change, about 15 s.

We can limit this by using the attribute Watch="false" for the project references we don't want to watch. E.g for the core projects in Module .csproj files. Or, in a referenced Bundle .csproj file, for the modules projects except those we want to watch...

Note: we would not need this if a web app references a bundle but as a package, and only a few local modules as projects. Anyway, not so good to have to modify .csproj files.

So, here the strategy is to launch dotnet watch on each individual module we want to watch. Then, when a module razor file is modified, it is updated in the Packages folder after 2 or 3 s.

In .AsModule.props, razor files are added to the watchlist by using <Watch Include="..." />.

And there is a custom target CopyPackageRazorFiles which uses an ApplicationDirectory property as an input parameter.

Then, from a Module directory you can execute.
dotnet watch msbuild /t:CopyPackageRazorFiles /p:ApplicationDirectory=..\..\Orchard.Cms.Web

But simpler to use a batch file to watch multiple modules. As an example, see the watch.cmd file that needs to be run from the Orchard.Cms.Web directory. Here, we only watch 2 modules but you can add / remove the modules you want. Note: don't watch modules which are not referenced by the app.
@echo off
set "application=%cd%"
set "modules=%application%\..\OrchardCore.Modules"
set "themes=%application%\..\OrchardCore.Themes"
set "targets=/t:CopyPackageRazorFiles"
set "props=/p:ApplicationDirectory=%application%"
set "watch=start dotnet watch msbuild %targets% %props%"

cd %modules%\Orchard.Demo & %watch%
cd %modules%\Orchard.Body & %watch%
cd %application%

Best

I think watch.cmd should be moved to samples.

@agriffard thanks for testing.
@Jetski5822 Ok
So, i can put a watch.cmd file in the OrchardCore.Mvc sample. OrchardCore.Nancy project doesn't need it. Then push the changes, then update .gitignore, as suggested by @agriffard, to ignore future changes of this command file.
But if we do this, maybe we can also keep the one already in Orchard.Cms.Web, so people can work on our solution and watch the modules they want without committing any change on this cmd file ...
It's as you want, i'm waiting for your confirmations.
I was also thinking to use a PowerShell script but i'm not confortable with PS. But i can learn it and can be done in another PR if better.

@Jetski5822 Done (forgot what i said above).
So, now the watch.cmd file is in the mvc project sample. And, through .gitignore, it is ignored in the cms web app, e.g if someone copy / paste it here.

Lgtm

So, if we only reference the tool in the web app and start it from there, there are too many project references and it is very slow.

Maybe some feedback to give to the team so they fix it.

Ok, no problem, let me know if you have some feedback on this.
When i said it is very slow, i mean when we want to use the tool to react on razor file changes. But maybe not so slow when used in a regular way, e.g to rebuild a project when a source file change.
Maybe we can override the behavior to only watch razor files. But i didn't do this because if someone reference AsModule and still want to watch its project in a regular way. Not sure but maybe i tried this and it was still slow because of the number of project references ...
What would be good, through the .csproj file, is to specify the project references we want to watch (not necessarily all). Maybe it's possible, i will take a look on this.

Should just be the projects, not the packages

Yes, dotnet watch is already watching only project references.

So this should be ok not to add this to all projects and just use the web app. What do I need to change to your PR to test it without the line in each project?

So this should be ok not to add this to all projects and just use the web app.

Yes, i have a solution for doing this. But it was slow because in our solution we have hundred of project references.
But, if you only reference packages unless 2 or 3 modules you are developping, then it's ok. I already try it. But for people which are working with our solution, then it becomes slow.

For infos, there is this line in the µSoft code
<_DotNetWatchProjects Include="@(ProjectReference->'%(FullPath)')" Condition="'%(ProjectReference.Watch)' != 'false'" />

So we can exclude projects to be watched but by specifying Watch="false" in some project references in the .csproj file. But maybe we can do this on the flywhen calling the tool with some parameter ...

Otherwise, to test it from the main app we need to reference the tool in the main app, call dotnet watch from the main app directory and specify a task to be executed.
So, you can't test it directly. I would need to re-write a specific target in the main app .csproj file.

So, now you can test it by launching the mvc sample app, running watch.cmd in its directory, then updating the OrchardCore.Modules\Orchard.Mvc.HelloWorld\Views\Home\index.cshtml view.

To test it through the web app, do the same but before copy / paste the watch.txt file from the mvc sample app, and update it with the project paths of the modules you want to watch.

Here, i also moved back App_Data publishing in AsBundle but with the condition that App_Data\Sites exists. This to prevent from having to create a new aspect package. Note: *.log are excluded. Let me know if it is ok and / or if i need to create a distinct PR for this.

Best.

Now you just have to run watch.cmd from the web app directory, then all razor files are watched.

To watch the app in a regular way, set WatchOnlyPackageRazorFiles to false in the .csproj file.

Best.

In the last commit i just did some renamings.
So, modules can be referenced as packages and also as projects. When referenced as project, some msbuild variables were using the PackageProject term. But for clarity i think it's better to use the ModuleProject term, e.g for the ModuleProjectReferences var and so on.
I didn't do that before because there are Modules but also Themes, but we are talking about Modular apps, we use AddModules() and UseModules() ... So, i think we can also use here the Module word.
Note: We could also unify the name of modules and themes manifest files. Then we would not need anymore the .AsTheme package ...

So, as discussed, in the last commit the App_Data stuff is done through the OrchardCore.cms bundle.

One little drawback i see here is that if an user want to create a custom cms bundle he will not have to just reference the AsBundle package. He would also have to embed itself the App_Data stuff.

One solution would be to create a new AsCmsBundle aspect package which adds the App_Data stuff, and which also references the AsBundle package. But maybe not good to have too much aspect packages, and not so hard to embed a .props file based on our cms bundle as an example.

Finally, maybe better to let the regular AsBundle doing specific things but by checking some specific properties / contexts. For App_Data, i was just checking that the App_Data\Sites folder exists.

So, let me know if it is ok, if you prefer a new AsCmsBundle package, or just revert back this last commit.

I am ok with either:

add a .props in the OrchardCore.Cms project, and let people reuse this file if they want the same logic.
create a variable that AsBundle can detect and use to publish custom files, that would be defined in the OrchardCore.Cms project

I see you already did a .props file, so we are good?

For App_Data, as you want, i'm ok with both solutions. In this well known case, in place of checking a variable in AsBundle i would have just checked if the App_Data\Sites folder exists.

I've also updated the generation of the manifest file which is now outputed to the obj folder.

Finally, it makes sense that people need to embed their custom .props / .targets when they do custom bundles. And App_Data belongs to our cms bundle, so i think we are ok.

I did some tests for the generation of Module.txt in the obj folder. This with modules / themes with or without manifest files.

I tried a publish with OrchardCore.Cms referenced as a project.

I didn't check it with OrchardCore.Cms referenced as a package because it will be simpler when it will be published on myget. Otherwise i would need to use a local feed, re-pack all projects ...

But i checked that the new simple .props file is embedded with OrchardCore.Cms when it is packed.

So, i think we are good.

So, i've packed all projects (local feed) and i've done more tests.

New web app which references Orchard.Cms.Web as a package.
Publish this web app and run it from the publish folder.
New theme which references AsTheme as a package.
Watching modules razor files.
Manifest file generation.
Precompiled views.

So, i think we are ok but just seen your message on skipe, i will answer you.

Solved conflicts.

Can i merge this one? If so, do i need to merge the last master for retrying it?


minc2_simple: init at unstable-2018-12-20

Motivation for this change
Add a package.  Fresh version of #51094.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[NA] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[NA] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@jonringer -- all resolved, thanks.

@jonringer -- sure, done.

Added.

Done

@GrahamcOfBorg build minc2_simple python27Packages.minc2_simple python37Packages.minc2_simple python38Packages.minc2_simple

it looks like there's failure on aarch, may want to put platforms to "x86_64_linux", don't want hydra to constantly try to rebuild an unsupported package

Is there a way to do this other than platforms = stdenv.lib.intersectLists platforms.linux platforms.x86_64;?

@jonringer @risicle - upstream has merged my changes to automatically install the headers so I've updated to the most recent commit.  Tests are still broken upstream but I've filed an issue (but note the Python tests which depend on the C library work correctly.)


[stable/metrics-server] Bugfix / Add Missing Permissions

What this PR does / why we need it:

Add namespace resource to cluster role resource permission and nodes resource to aggregated reader cluster role permissions. These are required for scraping metrics per

https://github.com/kubernetes-incubator/metrics-server/blob/2614b8aa74e12eefb3e9aeb2d9c15c1748f7e95b/deploy/1.8%2B/resource-reader.yaml#L13
https://github.com/kubernetes-incubator/metrics-server/blob/2614b8aa74e12eefb3e9aeb2d9c15c1748f7e95b/deploy/1.8%2B/aggregated-metrics-reader.yaml#L11

Bump image version to latest at 0.3.3

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

This PR is partially duplicated here: https://github.com/helm/charts/pull/16606 (without the metrics server version bump), partially here: https://github.com/helm/charts/pull/16060 (with metrics server version bump and half of the permissions) and partially here: https://github.com/helm/charts/pull/15919 (only with metrics server version bump).

/assign @olemarkus

If this PR build properly we can close all other PR related to metrics-server.

@bryantbiggs could you please include in your PR this typo fix?
https://github.com/helm/charts/blob/4d456a565594f7fb072a220aece0b358e80403ec/stable/metrics-server/values.yaml#L26 "netwok" -> "network"

@bryantbiggs thank you too. I hope the test build is successful because the bump from 0.3.2 to 0.3.3 created some problems in my PR: https://github.com/helm/charts/pull/16060
For that reason I splitted the PR: https://github.com/helm/charts/pull/16606

/lgtm

@bryantbiggs as expected... the metrics-server bump break the build. :(

I am curious if this is related to the bump or if this is due to a change in the test platform. It looks like it struggles to remove the deployment, but I don't see a diff locally. Would be good if https://github.com/helm/charts/pull/16514 was in a good state.

@olemarkus and what to fix this https://github.com/helm/charts/pull/16606?

Finally the permissions are fixed. https://github.com/helm/charts/pull/16654
@bryantbiggs now this is outdated. I'll create a new PR in order to have a PR to update the metrics-server version.

Created https://github.com/helm/charts/pull/16656

I'm ready also to create a PR for whitespace formatting and to remove trailing blank lines as suggested by @bryantbiggs
https://github.com/PierluigiLenociAkelius/charts/commit/a8bbdcbf2d9b29ba049dd11a369453669429dd66


Update machine-learning-linear-regression-in-azure.md

Modifying the date from 7/2015 - 12/11/2015.  I am not sure why the date has not been updated from previous changes.

Hi @KBaroni, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


ioSender 2.0.35 Program limits

I'm using 2.0.35 on several PCs.  All running win 10.  On one of them, ioSender does not show Program Limits in the Grbl Tab when there is a loaded GCode program.  On the other machines, it does show limits.

Closing as this has been fixed in later versions.


Jenkins associate input parameter with git ref

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Use case
The current Jenkins connection assumes that the repo clone by the Jenkins job is the same as the business logic repo that we want Dota metrics from.
In this use case, we want to support separated Jenkins repositories that services leverage to build their app.
Let’s assume we have two git repos: “webapp” and “jenkinsfiles”. If I create a devlake project for the webapp, the GitHub connection in that project points to repo1 (webapp) while the Jenkins connection points to repo2 (jenkinsfiles). When Jenkins runs a new deployment job, it will clone a git SHA from repo2 (jenkinsfiles) not repo1 (webapp). The only link Jenkins knows about back to repo1 is a Jenkins input parameter called “TAG” that gets passed to the job. TAG is a git ref in repo1.
Note: putting the GitHub and Jenkins connections in same project is not enough today. So a deployment is performed with a "devops-setting commit" in repo 2(jenkinsfiles) and a "business-code commit" in both repo 1(webapp), and we should use the latter commit to measure DORA.
If we could specify in the Jenkins association which input parameter defines the git tag/sha, then we would get correct metrics.
Description
If we could specify in the Jenkins association which input parameter defines the git tag/sha, then we would get correct metrics
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@saada  Could you show me how to pass tags to jenkins' job and where the tag parameter will appear?

Given a jenkinsfile like this

pipeline {
    agent any
    parameters {
        string(name: 'PERSON', defaultValue: 'Mr Jenkins', description: 'Who should I say hello to?')
        text(name: 'RELEASE_TAG', defaultValue: '', description: 'Enter git ref for web app repo')
        choice(name: 'CLUSTER', choices: ['qa', 'prof'], description: 'Pick cluster')
    }
    stages {
        stage('deploy to cluster') {
            steps {
                echo "Deploying ${params.RELEASE_TAG} TO ${params.CLUSTER}"

               ...
            }
        }
    }
}

The parameter in this case is called "RELEASE_TAG". But in another job it could be called TAG or GIT_REF.

Thank you for your reply,  it's not diffcult to support this.
My questions are: when should we  use repo2(jenkins file)'s  commit sha, when shoud we use repo1(parameter in jenkins file)'s commit sha ? and how to config it(when ? where ?) ?
Do you have any ideas?

Ideally it would be configured via a new feature exposed here.

If there's a new field in here called Jenkins parameter to use when calculating DORA metrics: where I can enter in there
parameter names such as TAG or GIT_REF or GIT_SHA or REPO_TAG. It's important to support various git references here. It might be a tag, sha, branch, etc.

@saada
User can custom parameter name doubtly.  But is there is a git ref/tag/branch, we cannot fetch the commit sha behind the ref/tag/branch, and the commit_sha field in cicd_pipelint_commits will be v0.x.x or release-xxx(not the commit sha).
Is this acceptable and expectale?

@d4x1 that would work. Thank you. Might want to clarify in the UI as well that SHAs won't work.

@d4x1 that would work. Thank you. Might want to clarify in the UI as well that SHAs won't work.

Got it, it will be completed next week. (I am busy with my personal matters)

Thank you so much, no rush! Best of luck

Hi @saada , it seems we need more time to re-think the solution. The previous solution we came up with could not solve your problem.

Hi, @saada, I'm proposing a solution for you use case, would you like to take a look if it can solve your problem or anything is missing. Thanks.

I leave this comment mainly to record why I don't code to completed this feature directly.
Devlake can fetch build parameters, and regard some of them (such as GIT_SHA ) as commit_sha in cicd_pipelint_commits , but this can lead to DORA metrics be calculated incorrectly after an diccussion with @klesh.
So I think the best way is to use webhook so far.

Webhook solution is fine by me. Can we document a tutorial on how to implement this solution? Thank you

I think @Startrekzky  is working on this.


Cannot provide a value for property 'ModalService' on type 'BlazorBootstrap.Modal

https://demos.blazorbootstrap.com/modals
This is the example I followed and created a component and a page. But when I run it it throws error
"InvalidOperationException: Cannot provide a value for property 'ModalService' on type 'BlazorBootstrap.Modal'. There is no registered service of type 'BlazorBootstrap.ModalService'."

I am only following Modal example, why it is throwing ModalService error?

Pls ignore I was able to figure this out.


feat(query): add new query for tencentcloud CLB resource

Hello, There is something new query for TencentCloud TKE resource:
clb_instance_log_setting_disabled
clb_listener_using_insecure_protocols
Please help review the PR
Thanks
I submit this contribution under the Apache-2.0 license.

This is my local test


Investigate theming support

There's a chance that a number of updates we need to do on the UI can be handled via Backstage's theming support.  However we need to better understand how themes apply to components across plugins, and if there's a chance we may introduce visual inconsistencies with this approach.
@invincibleJai @debsmita1 @divyanshiGupta @jerolimov FYI, feel free to add anything I've missed, thanks!

Happy for any collaboration on this one btw, my current plan is to investigate what's there, take notes and document gaps.

I found there's excellent support for theming, however I also found that there's a couple versions of Material involved under the theming hood.  I've been having a look at the upstream theme code which includes a nice interface and I had a thought to try mapping the values in @patternfly/react-tokens to the pallette interface and also update my current effort to use the non-deprecated theming API.

Doc link is in https://github.com/janus-idp/backstage-showcase/issues/532 so this one's all set.


Newer version of nbsphinx.

Still trying to fix read the docs problem.

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   99.73%   99.73%
=======================================
  Files          28       28
  Lines        2253     2253
=======================================
  Hits         2247     2247
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56338f2...22c727f. Read the comment docs.


python310Packages.pyutil: 3.3.0 -> 3.3.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pyutil is: Pyutil, a collection of mature utilities for Python programmers
meta.homepage for python310Packages.pyutil is: https://github.com/tpltnt/pyutil
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.3.2 with grep in /nix/store/s53mjssi2ks1cafgbm9wh9d6nylszbxx-python3.10-pyutil-3.3.2
found 3.3.2 in filename of file in /nix/store/s53mjssi2ks1cafgbm9wh9d6nylszbxx-python3.10-pyutil-3.3.2

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath
blocksat-cli
python310Packages.blocksat-cli
python310Packages.pyutil
python310Packages.zfec
python311Packages.blocksat-cli
python311Packages.pyutil
python311Packages.zfec
tahoe-lafs

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s53mjssi2ks1cafgbm9wh9d6nylszbxx-python3.10-pyutil-3.3.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pyutil https://github.com/r-ryantm/nixpkgs/archive/cd16b0bdb85ce735a68cdbe4201a4ffdfcf16222.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s53mjssi2ks1cafgbm9wh9d6nylszbxx-python3.10-pyutil-3.3.2
ls -la /nix/store/s53mjssi2ks1cafgbm9wh9d6nylszbxx-python3.10-pyutil-3.3.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

python311Packages.blocksat-cli

6 packages built:

blocksat-cli (python310Packages.blocksat-cli)
python310Packages.pyutil
python310Packages.zfec
python311Packages.pyutil
python311Packages.zfec
tahoe-lafs

Maintainer pings
cc @prusnak for testing.

Result of nixpkgs-review pr 215219 run on aarch64-darwin 1

2 packages failed to build:

blocksat-cli (python310Packages.blocksat-cli)
python311Packages.blocksat-cli

4 packages built:

python310Packages.pyutil
python310Packages.zfec
python311Packages.pyutil
python311Packages.zfec

@ofborg build python310Packages.pyutil python310Packages.zfec python311Packages.pyutil python311Packages.zfec

@ofborg build blocksat-cli

Result of nixpkgs-review pr 215219 run on aarch64-darwin 1

1 package failed to build:

python311Packages.blocksat-cli

5 packages built:

blocksat-cli (python310Packages.blocksat-cli)
python310Packages.pyutil
python310Packages.zfec
python311Packages.pyutil
python311Packages.zfec


Adding the standalone min js throws Range out of order in character class error

I added the standalone min file to my html and its throwing below error in console. However adding teh unminified version worsk fine.
sway-standalone-min.js:26 Uncaught SyntaxError: Invalid regular expression: /[Ã€-ÃŸ][Â€-Â¿]|[Ã -Ã¯][Â€-Â¿]{2}|[Ã°-Ã·][Â€-Â¿]{3}/: Range out of order in character class

Can you confirm if this is still the case, on master?

Closing until more information becomes available.


Import KeysView, ValuesView from collections.abc to unblock Python upgrade

When depending on this library, it's currently not possible to upgrade past Python 3.6 as KeysView, ValuesView and many other things are no longer exposed via collections but via collections.abc (see: https://github.com/python/cpython/issues/70176). This change is backwards compatible and is tested to work from Python 3.6.* to Python 3.10.* at least.

thanks for this patch!  it effectively drops support for Python < 3.3, but that's fine since they've been end-of-lifed.  I added version constraints since it looks like sqlalchemy 1.4 has compatibility issues (we'll have to look into it eventually, but I wanted to unblock you).  I'll publish the package shortly
🥂

Thanks @dpep!


Backport: Cannot add node template for AWS China regions

Backport https://github.com/rancher/rancher/issues/19287

Can be tested on rancher/rancher:v2.2.2-rc1

reproduced on rancher:v2.2.1.
Steps taken:

Create an AWS node template
Select cn-north-1 or cn-northwest-1
give in the aws key and secret
Click Create
Error AuthFailure: AWS was not able to validate the provided access credentials is seen.

Verified on rancher/rancher:v2.2.2-rc1.
Steps taken:

Create an AWS node template
Select cn-north-1 or cn-northwest-1
give in the aws key and secret
Click Create
No error is seen on the UI. Proceed to create the node template.
Create a cluster using this node template. Cluster launches successfully.

Created an AWS cluster for region cn-north-1. Unable to create a cluster for region cn-northwest-1, issues tracked separately in https://github.com/rancher/rancher/issues/19379.


add geom_beeswarm()

I saw you were adding new type of plots. Swarm plot is very useful and it is similar to the violinplot but each point is shown in a way overlap is prevented.
Here is the ggbeeswarm for reference.

Looks interesting, thank you. Note however that some of these charts can be done using geom_dotplot() or geom-ydotplot().


Error: Chunk.initial was removed. Use isInitial() in BannerPlugin

I'm submitting a bug report
Webpack version:
2.1.0-beta.{16,17}
Please tell us about your environment:
OSX 10.10, 10.11 / Linux
Current behavior:
BannerPlugin causes build failure.
Expected/desired behavior:
BannerPlugin should not fail due to API change.
There is already a similar issue for ExtractTextPlugin (#2764), not sure if these should be merged or not. Currently I have reverted to beta.15 which is the last version where both plugins work.
Thanks for all the hard work, it's very appreciated.

fixed


Modbus RTU slave mode

Is it possible to run mbusd in reversed mode? So

on one end, mbusd is TCP server as it is now, but in Modbus/TCP master mode
on the other end, mbusd is connected to RS-485 and behaves as Modbus/RTU slave

So, basically, if there is some "dumb" mode, where mbusd just understand Modbus/RTU framing, crc and not the content and pack/unpack messages to/from TCP.

Sorry, but currently mbusd acts only as a gateway from TCP to RTU network, and reverse mode is not supported.

Ok, thank you.


Cache tool environments in uv tool run

Summary
The basic strategy:

When the user does uv tool run, we resolve the from and with requirements (always).
After resolving, we generate a hash of the requirements. For now, I'm just converting to a lockfile and hashing that, but that's an implementation detail.
Once we have a hash, we also hash the interpreter.
We then store environments in ${CACHE_DIR}/${INTERPRETER_HASH}/${RESOLUTION_HASH}.

Some consequences:

We cache based on the interpreter, so if you request a different Python, we'll create a new environment (even if they're compatible). This has the nice side-effect of ensuring that we don't use environments for interpreters that were later deleted.
We cache the from and with together. In practice, we may want to cache them separately, then layer them? But this is also an implementation detail that we could change later.
Because we use the lockfile as the cache key, we will invalidate the cache when the format changes. That seems ok, but we could improve it in the future by generating a stable hash from a lockfile that's independent of the schema.

There are a lot of TODOs, but it'd be nice to get alignment on the strategy before I spend time knocking them out.
Closes https://github.com/astral-sh/uv/issues/4752.

Gonna open a new PR when it's ready to avoid notification spam.


Hosted Domain Restriction to Oauth2

As discussed in #292  i am trying to use the googleapis_auth package and trying this code from the docs:
import "package:http/http.dart" as http;
import "package:googleapis_auth/auth_io.dart";

...

var id = ClientId("....apps.googleusercontent.com", "...");
var scopes = [...];

var client = http.Client();
obtainAccessCredentialsViaUserConsent(id, scopes, client, prompt)
    .then((AccessCredentials credentials) {
  // Access credentials are available in [credentials].
  // ...
  client.close();
});

void prompt(String url) {
  print("Please go to the following URL and grant access:");
  print("  => $url");
  print("");
}

But i want to restrict the logins to just @foobar.com domains so only users with a @foobar.com email can login.
I have found that this can be do via the hosted_domain oder hd parameter via this Stackoverflow entry.
But i dont know how i can use this in a Dart/Flutter Project.

Got it working! https://github.com/google/googleapis.dart/pull/323

@kevmoo works perfectly 😊👍

@kevmoo found an issue:
when using web version import "package:googleapis_auth/auth_browser.dart". I cant use obtainAccessCredentialsViaUserConsent with hosted domains.

@Y0ngg4n – would you open a seperate issue? Are you missing an API?


Tests written for frontend code

@anikethsaha, For now, I have written tests for the client folder. You can view them and give some feedback.

@anmol5varma Thank you for your help.
Actually, I have never used enzyme and not even sure whats this shallow thing.
Is it the same as snapshots?
I just need some time to review it cause I am getting along with enzyme.
So I will try my best to review it within a couple of days or hours 😁  .

BTW, this project structure looks much better than a single test folder at root. Thanks for that too 👍

@all-contributors please add @anmol5varma for infrastructure and tests

@all-contributors please add @anmol5varma for infrastructure and tests

@anikethsaha We can definitely try using render for the simple components but for router wrappers and redux wrappers using render will be a little tricky. We'll have to provide with a lot of mock data. Moreover, since this is boilerplate repo the team using it might not know the difference between render and shallow and mount and the tests might start failing if they add some wrapper modules like redux or routers or the UI elements libraries like material UI or react-bootstrap.

ohhh... yeah that's a thinkable point.
OK, we should drop the idea of rendering for now then.
👍


check peer compatibility when installing packages

npm ls >/dev/null after installation, but not when installed by a consumer

aleady handled: https://github.com/travi/travis-scaffolder-javascript/blob/7a9324060f79580ba3da8629ff6fcb5c17d756b5/src/scaffolder.js#L23


update packages

@mddub
This package has quite some outdated packages and some security issues.
$ npm install
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
added 19 packages from 246 contributors and audited 87 packages in 4.445s
found 10 vulnerabilities (2 low, 6 moderate, 1 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

This is a partial fix for https://github.com/mddub/minimed-connect-to-nightscout/issues/6
Only problem I have is with getting test/transform.js ok and I can't test this package because I don't use minimed.
The following test does not yet work:
  it('should discard data more than 20 minutes old', function() {
    var now = Date.now();
    var THRESHOLD = 20;
    var boundary = now - THRESHOLD * 60 * 1000;
    expect(
      transform(
        f.data({'currentServerTime': now, 'lastMedicalDeviceDataUpdateServerTime': boundary})
      ).entries.length
    ).to.be.greaterThan(0);

```

It errors with:

```
RangeError: Invalid time value
    at Date.toISOString (<anonymous>)
    at timestampAsString (C:\Users\pietergit\Documents\src\minimed-connect-to-nightscout\transform.js:23:30)
    at deviceStatusEntry (C:\Users\pietergit\Documents\src\minimed-connect-to-nightscout\transform.js:66:16)
    at module.exports (C:\Users\pietergit\Documents\src\minimed-connect-to-nightscout\transform.js:129:20)
    at Context.<anonymous> (C:\Users\pietergit\Documents\src\minimed-connect-to-nightscout\test\transform.js:37:7)

```

Can you or come other minimed-connect-to-nightscout user help complete this PR?

And thanks for calling attention to the failing test - I fixed it in #8.

@mddub thanks for fixing the test. I did the changes you suggested. Can you please publish it to npm as a 1.1.1 version, and I will include it in the 0.10.3 Nightscout release.

@PieterGit Thanks, I've published v1.1.1 to npm: https://www.npmjs.com/package/minimed-connect-to-nightscout

@mddub thanks for making the release. I integrated it into Nightscout with this PR
https://github.com/nightscout/cgm-remote-monitor/pull/3701
This will be released with Nightscout 0.10.3


fix: Favorites are not in sync with the schedule

Description
A few days ago I marked some items as favorites (The check-in on September 2:nd for example). After updating the app, some items were slightly changed and they seemed to be unfavoritized in the schedule. The old item still remained on the favorites tab though, so marking the new item as a favorite resulted in duplicates.
Steps To Reproduce

Mark an item as favorite
Change an item and update the app (not sure if a shorebird code push is required to see the bug)
See desynchronized state

Expected Behavior
A change in the schedule should be reflected in the favorites.
Screenshots

Thanks for reporting this! I'll get a fix out shortly 👍

This should be closed as part of https://github.com/felangel/flutter_and_friends/commit/90e34934f0e7de02cccc814400fa7f635d2bd930


Correct indentation on code markers

do we not have a something to colorize this ?

There are a number of command line snippets like that, yes. What would you prefer from the list on http://highlightjs.readthedocs.io/en/latest/css-classes-reference.html? bash, perhaps?

I was also assuming to leave fixed-space snippets that are just for illustrative purposes (like a folder tree), in plain code.


mem-ruby: Fix errors in CHI protocol due to recent update in slicc

Discussion: https://github.com/gem5/gem5/pull/1651

See #1690.


Add functionality to give custom input to model (interactive mode)

This enhancement will make it possible to see the ML model's output for any given string of text. This would be incredibly useful for sanity checks and future interactivity.

Relevant (originally from #12):

Not sure how to encode strings into a format the model will accept after it has been saved and reloaded in a different environment. May have to find some way to serialize this as well, through the model or otherwise.

Keras has an experimental pre-processing layer called TextVectorization that may work here. The TextVectorization layer has some advantages that make it a great fit for this problem:

Would reduce complex custom logic in amaranth/ml/train.py
Tightly couples text vectorization with model
Looks to be serializable, like all other Keras layers, fixing this problem

Of course it's not a perfect solution:

This layer is experimental, may not perform well, may have bugs

It's worth noting that the layer has been experimental since at least November of 2019, so it may be somewhat stable by now.

After some testing, the experimental TextVectorization layer from Keras is definitely serializable, and works exceptionally well in this project. One issue I ran into was a ValueError being thrown when the model is read back in after serialization. Looks like it's already been solved here. Unfortunately though, this fix isn't available in the latest stable Tensorflow release. We may have to switch to one of the nightly builds to get this to work properly.


Update contributing guidelines

On the contributing guidelines, we state that we have a feature coming soon that will allow users to follow a case.  This feature has been implemented (hooray!) so we need to update the text to state it is a feature and give a brief synopsis of how it works.

The commit addressing this issue has been merged into master.


Git pull (Question)

Hey jean, Im trying to pull the current changes that you've made recently after cloning your git repo about 20 days ago. Im still new to git, and I don't think when I cloned your repo it made it into a git repository on my machine, should I create one and submit a pull request? Would you mind helping me, I don't want to interfere, with your repo and need some help?

The error im receiving is

Hi, this is simply a merge conflict as you have local changes that would be overwriten if you pull the latest changes.
Could you run a git diff, please, so I can see what are those changes (if there is no sensible data in these) and then tell you what to do next?

Hello, Jean when I run git diff it doesn't show anything for me. I have settings setup on my machine that if this was a git repository, which it is it would show on the right hand side, ill pull up a project to show you what it looks like, for some reason its not showing that simple-bar is a git repo on my machine, from the git clone that I made 20 days ago.

Some how simple-bar is not being recognized as a git project at all from the git clone.

Here I just pulled my VS-Code theme from my GitHub to show you what a git repository project would look like on my terminal machine

I see, I you don't mind losing your local changes in your simple-bar folder you could remove it then reinstall it. You won't lose any settings as they are stored in Übersicht local storage.

I don't mind at all, I just didnt want anything to be messed up on your end, ill do that today, and thank you so much for your help.


Editor stuck when closing project on macOS

Godot version:
3.1
OS/device including version:
MacOS 10.14.4
Issue description:
stucked when close some project
Steps to reproduce:

Open the project :
https://github.com/zszen/godot_lesson/tree/master/dodge_the_creeps
Do something or not
close the project
stuck ....

I found that not all project stuck. Only someone. I don't know what is speciel with it. So I upload the code for report.
Minimal reproduction project:
https://github.com/zszen/godot_lesson/tree/master/dodge_the_creeps

I cannot reproduce the issue on Linux with Godot 3.1.1.
This might be a duplicate of #29107.

@akien-mga maybe cause by the simbol "!". From start the game learning, I fill with "Dodge The Creeps!" for the name. But it also stucked after I remove the simbol. I guess is it.

Can anyone still reproduce this bug in Godot 3.2.3 rc1 or any later release?

Closing due to lack of update. Please comment if you can still reproduce this issue in the latest stable version of Godot.


unable to add ng-showdown in Electron app

I am trying to build a cross-platform app using electron js. In the app I am not able to integrate ng-showdown

ng-showdown requires angular to be previously loaded.

@tivie it is working fine on browser but in an elctron it is not working

I believe this has something to do with electron itself. I can't help you much there, since I'm not familiar with that framework. Maybe ask in their forums?
If there's something we need to change in our library to make it compatible, we will hapilly try to implement it.

Many thanks for such a humble reply. I will let you know if I get
information regarding to the error.
On Jun 22, 2016 8:54 PM, "Estevão Soares dos Santos" <
<EMAIL_ADDRESS>wrote:

I believe this has something to do with electron itself. I can't help you
much there, since I'm not familiar with that framework. Maybe ask in their
forums?
If there's something we need to change in our library to make it
compatible, we will hapilly try to implement it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/showdownjs/ng-showdown/issues/29#issuecomment-227779553,
or mute the thread
https://github.com/notifications/unsubscribe/AIK06dXk_uq5MweekyVuEQttDtVAdsp6ks5qOVOMgaJpZM4I6thp
.

Closing, let us know what you find out!

I have encountered the same issue with this library and with angular-moment actually.
The issue comes from the way angular and the dependencies are required. Somehow, something is wrong with the ifs deciding wether require is supported and the module tries to start with the wrong require way.
Angular Moment has fixed this issue this way :

 +	var isElectron = window && window.process && window.process.type;
  	if (typeof define === 'function' && define.amd) {
  		define(['angular', 'moment'], angularMoment);
 -	} else if (typeof module !== 'undefined' && module && module.exports && (typeof require === 'function')) {
 +	} else if (typeof module !== 'undefined' && module && module.exports && (typeof require === 'function') && !isElectron) {
  		module.exports = angularMoment(require('angular'), require('moment'));
  	} else {
  		angularMoment(angular, (typeof global !== 'undefined' ? global : window).moment);


Line 31 updates to security roles

Changes on line 31:

Entity -> table
The mention of a PM assigning access to the project table feels misleading when talking about security roles. I'd reword to mention that access to related tables is needed and that access is granted via the security roles assigned to the user. As we're talking security roles, it would be logical to mention that access is done through security as opposed a PM assignment.

Line 33:
More as a comment. This line needs more context. I've read this a few times but I fail to see how this information is relevant for this page. It needs more context.

@anttipajunen I have reached out to the author and am waiting to hear back.


Lease times - is there a way to set an unlimited lease time?

Hi @offbynull , I've now discovered this android implementation and I was curious as to whether I can specify an unlimited lease time when mapping a port - it seems like the lease time is required by example mapper.mapPort() function
Can you advise me whether this is possible?
Thanks!

Hey,
The library isn't maintained anymore. I need to update the readme to
reflect that. I suspect there are much better (and newer) libraries
available that have Android support.
But, to answer your question, if I recall correctly unlimited leases
weren't supported across all protocols. Even if they were, an unlimited
lease will end up lingering if your application crashes, which I suspect
many people won't like.
On Wed, Mar 27, 2024, 4:53 PM risharde @.***> wrote:

Hi @offbynull https://github.com/offbynull , I've now discovered this
android implementation and I was curious as to whether I can specify an
unlimited lease time when mapping a port - it seems like the lease time is
required by example mapper.mapPort() function
Can you advise me whether this is possible?
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/offbynull/portmapper/issues/49, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQPQIWC53UFZBDGNVHC5J3Y2MWTNAVCNFSM6AAAAABFLT3RYWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTCOBYHAYDOMA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for the response! Really appreciate it! I have been looking at other
libraries and thought I understood yours the best out of them - new is
ironicly not what I am looking for since I need something that works with
as low as android 5. Your library has helped alot so far!
On Wed, Mar 27, 2024, 9:40 PM Kasra Faghihi @.***>
wrote:

Hey,
The library isn't maintained anymore. I need to update the readme to
reflect that. I suspect there are much better (and newer) libraries
available that have Android support.
But, to answer your question, if I recall correctly unlimited leases
weren't supported across all protocols. Even if they were, an unlimited
lease will end up lingering if your application crashes, which I suspect
many people won't like.
On Wed, Mar 27, 2024, 4:53 PM risharde @.***> wrote:

Hi @offbynull https://github.com/offbynull , I've now discovered this
android implementation and I was curious as to whether I can specify an
unlimited lease time when mapping a port - it seems like the lease time
is
required by example mapper.mapPort() function
Can you advise me whether this is possible?
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/offbynull/portmapper/issues/49, or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABQPQIWC53UFZBDGNVHC5J3Y2MWTNAVCNFSM6AAAAABFLT3RYWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTCOBYHAYDOMA>

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/offbynull/portmapper/issues/49#issuecomment-2024247360,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AICMFI7FRGBJI44ESU3X3YLY2NYJRAVCNFSM6AAAAABFLT3RYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUGI2DOMZWGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Display Helpful Context When the User Has No Permissions

As ...
Patti - Platform Admin
I want ...
Nautobot to show content to the user when they are logged out or do not have any permissions and when the HIDE_RESTRICTED_UI settings is enabled
So that ...
It is clear to the user they are not logged in, and so that they see something, instead of just the blank nav bar.
I know this is done when...

Nautobot no longer displays blank white space when the user is logged out.
The Platform Admin has the ability to customize the displayed content. For instance, they may wish to include instructions on how to request access to the system.
Explore if it makes sense to display the login form when local or LDAP auth is in use.

Optional - Feature groups this request pertains to.

Security (Secrets, etc)
UI/UX

Database Changes
None
External Dependencies
None

Probably also desirable to hide the search box(s) in this case.

Agreed, see https://github.com/nautobot/nautobot/issues/1645


sort and group images according to resolution

Aim
To write a python script to sort the images in our pc folders according to the resolution and group them by the resolution, by creating separate folders
Details
Is your feature request related to a problem? Please describe.:

Describe the solution you'd like:
In order to find a solution to this problem, this is a python script which sorts images according to resolution and group them into sub folders according to resolution
please assign this issue to me.
Thanks in advance

@RJ535315 assigned to you

@kaustubhgupta please check and review the PR that i've submitted related to this issue. thank you.


Update works only for find method

Hi,
Please, could you explain this one?
Success - it changes everything correctly
var find = userRepo.Find(user.UserId);
find.Password = "p@ssword";
unitOfWork.SaveChanges();

Fail - it doesn't change anything
var find = userRepo.GetFirstOrDefault(predicate: c => c.UserId == user.UserId);
find.Password = "p@ssword";
unitOfWork.SaveChanges();

Is it your intention or a bug?

I've already find a solution (disableTracking: false).
var find = userRepo.GetFirstOrDefault(
    predicate: c => c.UserId == user.UserId,
    disableTracking: false);
find.Password = "p@ssword";
unitOfWork.SaveChanges();


JDK 17 JFR config, tackle the old issue

2022-03-24T18:38:05.1101147Z [ERROR] Failures:

2022-03-24T18:38:05.1135858Z [ERROR]   JFRTest.jfrOptionsSmokeTest:157->jfrOptionsSmoke:288 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel-integration-tests/mandrel-integration-tests/ts/testsuite/target/archived-logs/org.graalvm.tests.integration.JFRTest/jfrOptionsSmokeTest/build-and-run.log and check these offending lines:
2022-03-24T18:38:05.1136786Z [warn][jfr,setting] Exception occurred when setting value "150/s" for class jdk.jfr.internal.Control ==> expected: <true> but was: <false>
2022-03-24T18:38:05.1137983Z [ERROR]   JFRTest.jfrSmokeTest:83->jfrSmoke:135 build-and-run.log log should not contain error or warning lines that are not whitelisted. See /home/runner/work/mandrel-integration-tests/mandrel-integration-tests/ts/testsuite/target/archived-logs/org.graalvm.tests.integration.JFRTest/jfrSmokeTest/build-and-run.log and check these offending lines:
2022-03-24T18:38:05.1138995Z [warn][jfr,setting] Exception occurred when setting value "150/s" for class jdk.jfr.internal.Control
2022-03-24T18:38:05.1139758Z OpenJDK 64-Bit Server VM warning: Option FlightRecorder was deprecated in version 13.0 and will likely be removed in a future release. ==> expected: <true> but was: <false>
2022-03-24T18:38:05.1140150Z [INFO]
2022-03-24T18:38:05.1140415Z [ERROR] Tests run: 13, Failures: 3, Errors: 0, Skipped: 1

Fixed by https://github.com/oracle/graal/issues/4431


Add 'main' parameter in package.json.

This should resolve #5 issue.

Thank you! Just published the new 1.2.1 release, to npm as well :)


Background does not follow overlong code block

Having an overlong code-block, will enhance the code-block with a scrollbar. If you scroll, the background does not follow the content.
I think this explains it best:
Normal view:

Scrolled:

Is it fixable to have the background expand over the whole content?

I have not been able to reproduce this issue on OSX (Chrome, Safari, Firefox) or Linux (Firefox).
What OS and browser are you running? And how does the generated HTML look like?

Hi @eliasson, thanks for your reply.
I'm using Firefox nightly on Linux. I also tested it on Chromium and there is the same behavior.
The page is already live at https://dunst-project.org/faq/

@bebehei the reason seems to be that your site is not using article as the Content Type and previously the styling only was applied to .li-article. I just made a commit that applies the styling for base elements.
Please let me know if this resolves your issue.

Thank you for your fast reply. It did not work on the first try. It turns out that, the our website also uses incompatible overwrites and this bug results by a combination of both. 🙈
It works now like a charm.
@eliasson Could you please update also the minified css file? Both files are currently not in sync. After that, this bug is definitely fixed.
Sorry for the noise.

Great. The minified CSS is also updated now.


Last Week In Pony - April 22, 2018

Hey you, wanna submit a Last Weeks Playground link?
Just add your link with some description of what it exhibits as a comment here and don't forget to vote on other submissions.

Audio from the Pony development sync for April 18, 2018...
https://pony.groups.io/g/dev/files/Pony Sync/2018_04_18


[SDK] Fix: Custom auth profile label

PR-Codex overview
This PR focuses on fixing the display of the "Custom Auth" profile type label in the LinkedProfilesScreen component and enhancing unit tests for various profile types.
Detailed summary

Updated LinkedProfilesScreen.tsx to return "Custom Profile" for custom_auth_endpoint.
Added unit tests in LinkedProfilesScreen.test.tsx for:

Email, Google, Phone, Wallet, Cognito profiles.
Custom Auth profile type.
Handling of unknown and guest profile types.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Merge activity

Dec 9, 8:46 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


[Bug] Crash on user kick

What's the bug?
Whenever someone gets kicked from a server the bot crashes with the following error:
error: Uncaught DiscordAPIError:
GET /guilds/<guild>/members/<kicked> returned 404
(10007) Unknown Member
      throw new DiscordAPIError({
            ^
    at BucketHandler.execute (https://raw.githubusercontent.com/harmonyland/harmony/daca400ae9feab19604381abddbdab16aa1ede2b/src/rest/bucket.ts:224:13)
    at eventLoopTick (ext:core/01_core.js:181:11)
    at async BucketHandler.push (https://raw.githubusercontent.com/harmonyland/harmony/daca400ae9feab19604381abddbdab16aa1ede2b/src/rest/bucket.ts:55:13)
    at async RESTManager.make (https://raw.githubusercontent.com/harmonyland/harmony/daca400ae9feab19604381abddbdab16aa1ede2b/src/rest/manager.ts:236:12)
    at async RESTManager.get (https://raw.githubusercontent.com/harmonyland/harmony/daca400ae9feab19604381abddbdab16aa1ede2b/src/rest/manager.ts:259:12)
    at async MemberRolesManager._resolveMemberPayload (https://raw.githubusercontent.com/harmonyland/harmony/daca400ae9feab19604381abddbdab16aa1ede2b/src/managers/memberRoles.ts:22:23)
    at async MemberRolesManager.array (https://raw.githubusercontent.com/harmonyland/harmony/daca400ae9feab19604381abddbdab16aa1ede2b/src/managers/memberRoles.ts:50:17)

How do we reproduce it?

Create a .env file containing the following: token=<your bot token> and download this code.
Once the bot is online kick any user from a server
Crash

What should have happened?
Nothing should've happen.
What is actually happening?
The bot crashes
What versions you're using?

OS: Arch Linux 6.3.4-arch1-1
Deno: Deno 1.33.2 (release, x86_64-unknown-linux-gnu)
Harmony: Harmony commit daca400

It seems like this happens because of the event guildMemberRemove trying to get a member object but fails to fetch the member's roles

@Blocksnmore Can you try it with the latest commit? It works fine with the fix for me

@Blocksnmore Can you try it with the latest commit? It works fine with the fix for me

The bot isn't crashing anymore so it seems to be fixed.


Remove thread_pool_attached_executors as they are not used anywhere

This is partly for #3077
The thread_pool_attached_executor is not used in any code and has no obvious purpose. The pool_executor that works with the thread pools created by the resource manager supercedes it I believe.

Note that I'm expecting some push back for this PR and I partly wanted to test if everything builds ok with this removed.

The only place where it is used in hpx::compute::block_executor. One of the features this executor provides is the ability to schedule tasks to a given set of cores, while still allowing for the possibility of stealing. So my suggestion would be, instead of removing it, allow it to attach to a given thread pool configured using the resource partitioner.

All one needs to do is create a pool with the cores you want to use and use a pool executor.

Pools can't be created dynamically, and there is no stealing between pools.

Dynamic pools will be supported in future. Feel free to create an issue requesting this.
The executor does not control stealing, it only tells the tasks which cores to run on - stealing is the job of the scheduler and this belongs to the pool.

@biddisco do you think we can close this? I think the thread_pool_attached_executors could be replaced by something better in the future, but at the moment they don't have a direct replacement and don't hurt anyone (or have they caused headaches for you while working on your executors?). In the end they're similar to a NUMA executor in that they let you schedule tasks on a subset of resources of a thread pool, without actually creating an actual thread pool.

I'm going to close this for now. We can always reopen once we have a proper plan for what to do with all the executors.


[macOS] Disable spotlight indexing

Description
It turned out we have a few CPU-consuming processes on the base image after the generation. These mdworker processes belong to spotlight search indexing, and it looks like we don't use spotlight at all so the indexing can be safely turned off.

Related issue:
n\a
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run macos1013, macos1014, macos1015, macos110


Can't resolve './reducers'

The Title of my Issue is the error I'm getting here's my code
// NodeJS imports
import { createStore, applyMiddleware, compose } from 'redux';
import thunk from 'redux-thunk';
import rootReducer from './reducers';
// Quick Initializations
const initialState = {};
const middleware = [thunk];
// Create the Store
const store = createStore(
rootReducer,
initialState,
compose(
applyMiddleware(...middleware),
window.REDUX_DEVTOOLS_EXTENSION && window.REDUX_DEVTOOLS_EXTENSION()
)
);
export default store;

The issue tracker here on GitHub is reserved for bug reports and feature requests. For usage questions (which is what I believe this is), please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out. Thanks!


feat: [#1514] Port DotNet CLU Recognizer component to JS

Fixes # 1514
#minor
Purpose
This PR ports the CLU Recognizer's component from DotNet to JS.
Changes

Updated DotNet's and added JS README.md.
Ported DotNet's CLU folder to JS.
Ported DotNet's root folder to JS.
Few implementations in DotNet couldn't be ported to JS and has been adapted to work similarly.
Added code documentation.

Tests
The following image shows a Composer bot working with the JS CLU Recognizer's component.

Applied fixes, thanks @ceciliaavila

/promoted 1518


add links to the examples

on the examples page, add links(GitHub) to each example page with a source code link

did it, but more explanations are needed to clarify what it does


Bitwarden Admin Page - Eye Cancer

Bitwarden admin page is blindingly white when using organizr-dark.css

+1 for dis.
So much eye cancer. Like being flashbanged after being hoodwinked for a week.

Where is this menu? I dont have it.

It's the admin menu. Append /admin to your URL and login with your admin token.

https://github.com/gilbN/theme.park/commit/539c8ad489efa1ee06b4a4cb7eb4be5ab8755d68 check it

Looks great to me. Thanks!


roboto mono face, bold, and matching paren moves cursor

to reproduce:

open the following jsfiddle: http://jsfiddle.net/1c0f6aqL/1/
Click anywhere in the codemirror in the lower-right
type '()'
the cursor jumps left, in between the parens, instead of remaining to the right.

note: the bold is involved, if you just stick with just the regular weight, it's fine.
this is where we first encountered this bug:
https://github.com/twosigma/beaker-notebook/pull/2366
but then it seemed ubuntu mono had problems too:
https://github.com/twosigma/beaker-notebook/pull/2376
and eventually we figured out we could lose just the bold and that would fix it.

This appears to be due to the browser not loading/initializing the bold version of the font until it absolutely has to, and then doing so asynchronous, so that when CodeMirror measures the size of the parentheses, it is getting measurements for some stand-in font, which it uses to calculate the cursor position. And then,  a few moments later, the browser drops in the actual font (apparently before it even draws) which has different dimensions.
A workaround would be to include a bit of hidden bold roboto mono text somewhere in the page, to force the font to be initialized before CodeMirror tries to use it. I'm afraid that's all I can suggest -- I am not aware of any events that, if I don't know in advance what font is going to be used, will tell me that the font of an element was loaded.

thank you for researching and explaining that, we were quite baffled.

cc @paulirish -- could this be related to the issue around the browser not fetching the font until a recalc is tripped?
I wonder if a force recalc and an explicit wait for the font to be downloaded until the cursor position is calculated in codemirror could be a fix...


print warnings (or fail?) when deps (and ebin?) folder exists

Having a deps folder can lead to rather interesting situations which are absolutely baffling. I think at least a warning should be printed to hint users to the fact that those folders can have strange effects and that they probably want to delete them.

Does it still? I thought that might have gone away as an issue after https://github.com/rebar/rebar3/pull/619 was merged.

It did for me the other way, but it might have been because deps included stuff that wasn't in the dependencies any more.

Na, it should be that anything in deps/ is completely ignored, it shouldn't be found at all. So if it is still doing anything with them something is wrong.

Odd! But that is a sane default behaviour. I'll close this ticket and when I manage to re-produce what I ran into yesterday open a new one as a bug against the expected behaviour of ignoring desp


Cannot edit saved files if libxerces2-java is installed

LightZone can't open JPEG-LZN files if libxerces2-java is installed on Ubuntu 15.10. Metadata in Info panel are empty for the lzn files. LZ gives a lot of XMLExceptions like following when executed in a terminal.
com.lightcrafts.utils.xml.XMLException: Expected child "Controls" under "HTML"
	at com.lightcrafts.utils.xml.XmlNode.getChild(XmlNode.java:142)
	at com.lightcrafts.ui.templates.TemplateTreeNode.<init>(TemplateTreeNode.java:37)
	at com.lightcrafts.ui.templates.TemplateNamespaceTreeNode.<init>(TemplateNamespaceTreeNode.java:30)
...

sudo mv /usr/share/java/xercesImpl-2.11.0.jar{,.bak} fixes the problem.

I do not have this jar file on my computer (Fedora 23) yet I still have the same issue when I try to click the edit button on one of my Nikon .NEF files. It also displays an error box with: "this file has no version number"
trace.txt

I think this issue was fixed with b70a616, a8d6591, and c53272.


Updating the logic for controlling the quickfix flag

Before submitting a pull request, please make sure the following is done...

Fork the repo and create your branch from master.
If you've added code that should be tested, do a sanity check on vim8 and neovim
If you've changed APIs, update the README and documentation ./doc/prettier.txt

Please use the simple form below as a guideline for describing your pull request.
Thanks for contributing to vim-prettier

Summary

Negation flags are usually more confusing to understand specially when
the default is having it enabled.

Test Plan
Ensures that the quickfix controls are respected by .vimrc configuration overwrites

I updated the control flags introduced on https://github.com/prettier/vim-prettier/pull/122
cc @docwhat


HAWQ-362. Master RM should Recalculate Segment's Allocation Status if Segment's RM is restart

Please review, Thanks!

The code change is ok to me. +1

The overall fix looks good. +1


fix(font-size): add fontSize defaultTheme

To Reviewers

[ ] Skipping review is not a problem (style, chore ONLY)
[X] Not that difficult

Type of Change

[ ] New feature
[X] Bug fixes
[ ] Feature improvement

[ ] These changes require a usage change

[ ] Others (performance improvement, refactoring, CI/CD, etc.)

Checklist

[ ] Updated Storybook documents
[ ] Tested with console(if usages are changed)

Description

Add fontSize defaultTheme because of existing fontSize in console

Things to Talk About

:tada: This PR is included in version 1.1.0-beta.487 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Convert prefix conversion to use curies package

The curies package c/o @cthoyt should be able to more elegantly convert prefixes to CURIEs.
See https://github.com/cthoyt/curies
Example:
converter = Converter.from_reverse_prefix_map({

    "http://purl.obolibrary.org/obo/CHEBI_": "CHEBI",

    "https://www.ebi.ac.uk/chebi/searchId.do?chebiId=": "CHEBI",

    "http://purl.obolibrary.org/obo/MONDO_": "MONDO",

})

converter.expand("CHEBI:138488")
'http://purl.obolibrary.org/obo/CHEBI_138488'

converter.compress("http://purl.obolibrary.org/obo/CHEBI_138488")
'CHEBI:138488'

converter.compress("https://www.ebi.ac.uk/chebi/searchId.do?chebiId=138488")
'CHEBI:138488'

happy to accept suggestions/PRs for extra utilities in this package, too, as long as they're general!

Will implement universalizer here, which uses curies/Bioregistry prefixes. Any subsequent changes to node normalization will happen in universalizer.


Add median

This PR adds a function computing the median (in the naive/basic way).

It should be possible to do this in (expected) linear time - without a much more complex implementation - by reusing the existing quickselect implementation, specifically the one using median of medians if you want guaranteed linear time (see here for an example usage of quickselect using median of medians).
To use this, you'd probably want to first shallowcopy the array (since quickselect mutates it).
Then the case of an odd number of elements would be easy enough: Just local i = quickselect(copy, math.ceil(#copy / 2)); return copy[i].
For an even number of elements, you'd still do local i = quickselect(copy, math.ceil(#copy / 2)). Since this partitions copy, you can now do local j = quickselect(copy, 1, nil, i + 1), to get the next largest element after the middle element to the right. (You could of course also just save the element at copy[i], then do a local j = quickselect(copy, #copy/2 + 1)).

My original plan was to add median.lua and quick_median.lua. I overlooked the fact that the second one it is basically implemented. I will update this PR.

Changed {unpack(list)} to a loop because unpack(list) puts the items on the stack, which is problematic for large lists (the stack is limited and can overflow; on 5.1 / JIT it's pretty "small", about 16k / 65k). Also removed the else since it is redundant with the early return.


C-style array syntax doesn't work.

This does not work:
int a[] = { 1, 2, 3};
this, of course, does:
int [] a = { 1, 2, 3 };
Reported by: patn
Original Ticket: "beanshell/bugs/51":https://sourceforge.net/p/beanshell/bugs/51

The first part of this appears to be fixed, probably by #89.
There is still a bit of weirdness however.  Declaring these two in sequence causes an error:
int a[] = { 1, 2, 3};
int [] a = { 1, 2, 3 };
// Error: Evaluation Error: Typed variable declaration : Typed variable: a was previously declared with type: int : at Line: 10 : in file: <unknown file> : int [ ] a = {

I would think that the two declarations are equivalent, yet they appear to be different.
On the other had, this works fine:
      int a[] = {1,2,3};
      a = new int[] {1,2,3};

The error is correct, we cannot redeclare a typed variable regardless if it is of the same type or not. This should give you a compile error in java as well.
@opeongo Thank you for verifying!
Closed: works as implemented

In BeanShell it is possible to redeclare a variable to the same type.  This code works just fine:
int[] a = new int[] {1 ,2, 3};
int[] a = new int[] {4 ,5, 6};
int[] a = new int[] {7 ,8, 9};

This is unsurprising to me, declared variables can be encountered in loops where the interpreter will re-execute them many times.
However, I thought int[] a and int a[] were essentially the same thing, so I was surprised that the redeclaration fails in this case.  Not a problem, just unexpected.

This is unsurprising to me, declared variables can be encountered in loops where the interpreter will re-execute them many times.

What you are observing is the block scope of the loop this will be a new variable declaration every time the loop is executed which is not the same as inline.
Redeclaring an existing scoped variable, even with same type should actually cause an error.
Alternatively the type does not change with the different array declaration syntax so this should not throw an error.
I suggest we investigate the impact of both scenarios before deciding on a fix.
ReOpen:  Not resolved

I think that the current behavior is the least surprising and more correct (Java seems to think so as well)... I vote we close

Agreed with @jimjag - closed


Project dead?

Is this project dead? I do have a bug to report but no point if this is not maintained anymore.

God question

It would be a very sad day if that's the case, there's no other mature slider that has the same feature-set.

swiper has a very high complexity and a variety of features which can be mixed in unending ways which causes a lot of edge cases - I guess this project needs many many unpaid hours to fix all reported bugs.
you could fix the bug and prepare a good merge request - we did that in the past and they were merged. if you need the maintainer to fix them for you you might try to hire him for some hours

There are 29 pull request and they aren't merged from 2015. So not about fixing is discussion but overall check of all that work.


Move signature validation to ledger & clean it up

See each commit for details. I have a feeling this won't pass the CI though.

I have a feeling this won't pass the CI though.

I should have more faith, this is G2G.


[proto] remove protobuf defns from types/

Motivation
Isolate proto definitions and associated logic from the rest of the code base.
This PR is aa significant first step along this path;  it is the smallest atomic change that I have been able to identify as it includes only the immediate butterfly effects of moving the types/proto files and the associated conversion functions.
Work on this effort followed from a conversation with Hui Ding.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Ensure that pre-existing tests are maintained, augment protobuf conversion tests where appropriate.
Related PRs
This is the first step of a multiple PR process.  Subequent PRs (not yet started) will focus on the protobufs and associated services defined in admission-control and storage.

@bors-libra r+

:pushpin: Commit 70ef3d3 has been approved by davidiw

:hourglass: Testing commit 70ef3d34504e679d70743dff1ee9e2e66de77cce with merge 8ba5fa27abbf020312d22c8401b31db52ae4385b...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing 8ba5fa27abbf020312d22c8401b31db52ae4385b to master...

wow, I thought it's eliminating proto from codebase, but still good try :)

wow, I thought it's eliminating proto from codebase, but still good try :)

Give it time.