Add podman-entitlement GitHub Action.

Description
When building images that need Red Hat content beyond what is available in the Universal Base Image repositories, Red Hat subscription is needed. To avoid changing the Dockerfile and invoke subscription-manager register manually, this GitHub Actions calls that step in separate temporary container and uses /etc/containers/mounts.conf to configure subsequent podman build invocations to have access to the entitlements.
Note that for example registry.access.redhat.com/ubi9-minimal does not have subscription-manager at all so the approach with tweaking the Dockerfile and somehow passing the subscription credentials to the podman build invocation does not work with those images at all.
Related Issue(s)

https://github.com/redhat-actions/common/issues/32

Checklist

[ ] This PR includes a documentation change
[ ] This PR does not need a documentation change

[ ] This PR includes test changes
[ ] This PR's changes are already tested

[ ] This change is not user-facing
[ ] This change is a patch change
[ ] This change is a minor change
[ ] This change is a major (breaking) change

Changes made

Add new GitHub Action podman-entitlement

I've been playing with this approach for a while in https://github.com/adelton/redhat-entitlements because I'd need it for RHEL-based container image builds and tests of https://github.com/freeipa/freeipa-container. With RHEL 9 release this week, I updated and tested the approach to use ubi9.
I currently did not include any tests with this PR because

we'd need some valid subscription credentials in this repository to actually consume them and test the approach;
it might be useful to actually test this from some external repository, to make sure the redhat-actions/common/podman-entitlement "path" to the Action works.

Please let me know how you'd like tests for this Action to be laid out.

I've now updated the code to make it a bit more readable.


Rename /etc/scylla/ami_disabled to smi_disabled

@fruch Any idea about this? no description

it's talking about the old hack to disable scylla from booting
https://github.com/scylladb/scylladb/blob/72dbce8d4638964f1f0b32c2027247e7dcc4b99d/dist/common/scripts/scylla_prepare#L145
it's there from the days before using systemd, and I don't think SMI is using this option anymore (i.e. it can be remove from scylla-core)

I think this can be just drop from scylla-core, so sent PR at https://github.com/scylladb/scylladb/pull/12043 https://github.com/scylladb/scylla-machine-image/pull/412

I think this can be just drop from scylla-core, so sent PR at scylladb/scylladb#12043 #412

Closing


[Port to M153] Add logging to clone/mount paths

Port of #1267 to M153

/azp Run GitHub VFSForGit Mac Functional Tests

/azp run GitHub VFSForGit Mac Functional Tests


Remove scrollbars on windows for action-sheet / resvolves #13966

Remove scrollbars on windows and resolves:
https://github.com/ionic-team/ionic/issues/13966
Short description of what this resolves:
Remove scrollbars on windows for action-sheet
Changes proposed in this pull request:

Change overflow: scroll into overflow: auto

Ionic Version: 3.x
Fixes: #13966

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!


Rename practices display name

The display name of "Practices" should become "Common Practices". The plugin identifier should remain "practices".

Tackled in

https://github.com/kubeshop/monokle-core/pull/421


[Suggestion] Add babel-polyfill to the project

Hi I was just testing this with JavaFx webview, I got an error when trying to run the site:
TypeError: undefined is not a function (evaluating 'Object.assign')
I solved it by installing babel-polyfill
I think I'm using a custom implementation of webkit that comes with the framework.
Thought you may wanted to know.

nah, I might only add Object.assign polyfill, you don't need all of babel-polyfill.


Add change discription backround color as option to the overidable functions

Could be really usefull to make it go red if we warn the user for an empty class for example.
If not to much of a hassle :P

Actually, error coloring might be quite useful :)

Right!
But maybe you got some better idea's how to error color nodes ;)

Hey @Vi-So this finally got implemented, you can add coloring logic within GetStatusBackgroundColor :)


No need for interpolation here

Found a place that interpolation wasn't needed. Quick fix :metal:

:+1:

👍


unsupported arch library

Describe the bug
When I run eCapture, I get an error：
unsupported arch library ,ELF Header Machine is :EM_386, must be one of EM_X86_64 and EM_AARCH64
To Reproduce
Steps to reproduce the behavior:

./ecapture tls --libssl=/system/lib/libssl.so
module run failed

OS: android
Kernel Version: 5.4.40

Yes, the 32-bit libssl.so is not supported for now.

Hello, do you have any other questions?


Do not remove line breaks

function foo() {
}

function bar() {
}

After fix becomes
function foo() {
}
function bar() {
}

Somehow related to #90

I'm closing this in favor of #110 since that issue will solve this issue.


Function to get the readable names of gamepad buttons (and vice versa)

Feature Request:
It would be awesome if there were built-in functions to get a user-readable name of a gamepad/joystick button from its button_index, and vice versa. This functionality already exists for keyboard keys with OS.get_scancode_string() and OS.find_scancode_from_string(). Functions to get the names of joystick axes would be cool too.

Should this be in OS like get_scancode_string() or in Input, like the rest of the joystick functions?

I would put it in Input personally. From a game making standpoint it doesn't have much to do with the OS.


Aspect for placeholder image

It was mentioned already (https://github.com/luberda-molinet/FFImageLoading/issues/715) but I don't know if you get notified about comments in closed issues. So, let me bring this up with new suggestions:
You have that nice LoadingPlaceholder ready and usable, the only problem is that, unlike the actual content that goes into the CachedImage, the placeholder is not supposed to be using the same Aspect in many cases but stay at a constant, original size, centered. So, if you could just change the aspect while loading (or allow us to supply a LoadingAspect) would be terrific.
Or, maybe as an alternative, you could give use event handlers that we could override, BeforeLoading and AfterLoading? You seem to have the appropriate handlers but only internally, not available for users. TaskParameter.OnLoadingPlaceholderSet?
I could probably create my own full task loader and include this but that would be major surgery while you could simply provide the hooks already in place...

We could make those hooks available. It's a good idea.

As a workaround you can use ImageMagick and add transparent padding to the gif.
The command for ImageMagick I used is:
magick loader.gif -coalesce -repage 0x0 -background none -gravity center -extent 600x600 +repage test1.gif

@deakjahn after this: https://github.com/luberda-molinet/FFImageLoading/commit/93612514d9b9adc18091e0af58bd611f43a9a835
aspect ratio should be changed correctly, but I agree - we should provide some hooks too.


"Click Predict to see the predict result" text should not display after the user clicked predict button  in evaluate page

System Information (please complete the following information):

Model Builder Version (available in Manage Extensions dialog):
Visual Studio Version

Describe the bug
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Additional context
Add any other context about the problem here.

,@romalpani, And I think the predict button has to be disabled while prediction is in progress.

@zewditu Yes! And we should have a spinner next to it while prediction is going on (same as Train).

@romalpani  sounds good! And that might also need to change the place where to displat the  prediction result .

@romalpani   I think do we need to prompt the user to  click predict button when the tryout value is changed after the user makes the first prediction,
if yes do we need still to say " Click predict to see predicted result" or something else?

Verify this issue on latest main build: <IP_ADDRESS>2301
For Data classification, Value prediction:

The text "Click Predict to see the predict result" is not display after clicking "Predict" button;
The "Predict" button is disabled while predicting;
There is a spinner under "Results" during predicting.

But I found other issues on Recommendation, Image classification, could you help to take a look?
Recommendation
The spinner above predicted rating should not be displayed since it already has the result.

Image classification
The spinner shows too early, it should be displayed after loaded the image, rather than appearing as soon as click the "Browse an image" link.

Not repro this issue on main: <IP_ADDRESS>5901
Recommendation:

Image classification:


Launch the proxy by ./proxyMain, wait a time period without launching RPMP nodes, the proxy will kill itself then.

See PR #109


More modular fields code

We should probably improve how we handle fields in the iD codebase.  This is something that @kepta and I were talking about recently.
All of our fields are currently written in a way that you can't just create a field, it's expected that presets "own" fields.  The problem with this is when we want to create a special field inside some other field, the only way to do this is to duplicate a lot of code.
This impacts the bridge/tunnel radio field #3911 and @kepta's lane editor #3822, and whatever other "advanced" fields we want to create.  In the case of the #3911, just to add a "Type" combo, I had to copy over a lot of the code from combo.js.  This code duplication adds a bunch of technical debt, and we should clean it up once we find a better way.
We can probably fix this by splitting this UIField constructor (factory?) out into its own module, making sure to account for all the preset closure variables that it depends on (e.g. it should have its own dispatch, etc).  We might be able to do this without a major semver bump.

@bhousel I really like the idea. After working on #3822 I realised we definitely need something like this.
It would be great if we could chalk out the list of things we would need to do for this refactor.
And also I was wonder for this new refactor will we still have the
https://github.com/openstreetmap/iD/blob/8dc7792027c3ae17793169a6e24b3b8836741728/modules/ui/preset.js#L30 custom events or should we look into other design patterns, since we are changing the whole submodule.

A field in a field.. This is cool that it works.
I liked the previous trimmed down design of this layer field, so I will make sure we can construct fields without the label, frame, form buttons if we want to.

This is amazing @bhousel !!

Done in #4214 😄


Add StopImpl as a callback

The original requirement is from DM, when a DM job is paused, the business logic doesn't know when to delete business metadata(such as DM checkpoint). The business requires a StopImpl callback, which can be triggered when a job master is stopped(the same as paused).
Besides the current implementation of job pause has a drawback, it relies on the availability of p2p message channel. Supposing the job master runs into an abnormal status, which means it can't handle OnJobManagerMessage properly or it always exits before OnJobManagerMessage finishes, the job master can't be paused.

close by pr https://github.com/pingcap/tiflow/pull/6852


Remove unused variable and fix comment typo

Remove oldhostname variable (unused) and typo in comment from sethostname

@wolfgang-desalvador would you mind rebasing and checking if this PR is still needed?


Add sort to Hit.

If you specify sort in an elasticsearch query, you'll get back a field called sort with the value that used for sorting that specific hit---this is sueful if you do any kind of fancy sorting or if passing _source=False but still want to paginate e.g. id-s.
Let me know if there's any kind of convention I've not adhered to, first time contributing to this repo.
On a related note---is there any reason why Hit doesn't have all public fields? I wanted to extract id and sort from my hits, and I currently have to clone to do that, even if I use into_hits. If Id, Index, Type derived Deserialize, they could be used as member types, removing the need for the conversion performed by the corresponding accessors.
Thanks a lot for this library! Using it over the official one for a couple of reason, but a big one is the presence of a SyncClient.

@mwilliammyers is there anything I can do to help get this PR merged? It's only a tiny change, hoping I don't need to depend on a git revision

Sorry for the extremely late response. I merged it in.
We are probably not going to be doing any more releases to crates.io but you can still use a git rev (but from this repo now that I have merged it).
I am curious about your other reasons for using this client over the official one; does the official client lack some features (besides a sync client)? We thought about doing a sync client for the official client but it doesn’t reduce any dependencies (it actually adds some because reqwest’s sync client just wraps tokio) and we figured it would be much harder to support both.

is there any reason why Hit doesn't have all public fields?

I am not sure; that was before my time here :) but I think most of the fields are exposed via getters. Let me check the docs...

Thanks for the response!
Sorry to hear that this repo is not going to see any more releases. I think
realistically the only reason is the sync client. We don't have any async
rust in our stack---there's been a lot of churn in the ecosystem for one,
but also doing async adds a lot of viral complexity to an application
especially when trying to preserve load shedding, back pressure and mixing
computational and io workloads. Ultimately async is an optimisation which
in our case would be very much unnecessary---with a few dozen threads our
services can handle everything that's thrown at them.
I can understand though that maintaining sync and async is a significant
burden. The rust world seems to be very much moving inexorably towards
async everything, so we may need to reconsider our position sooner or
later---it won't be a small job. I'm still holding out hope that writing
sync servers will remain viable in the long run
On Wed, 17 Jun 2020, 22:08 William Myers<EMAIL_ADDRESS>wrote:

Sorry for the extremely late response. I merged it in.
We are probably not going to be doing any more releases to crates.io but
you can still use a git rev (but from this repo now that I have merged it).
I am curious about your other reasons for using this client over the
official one; does the official client lack some features (besides a sync
client)? We thought about doing a sync client for the official client but
it doesn’t reduce any dependencies (it actually adds some because reqwest’s
sync client just wraps tokio) and we figured it would be much harder to
support both.
is there any reason why Hit doesn't have all public fields?
I am not sure; that was before my time here :) but I think most of the
fields are exposed via getters. Let me check the docs...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/elastic-rs/elastic/pull/413#issuecomment-645625501,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGDUMELB6OJU2WXFJFRIK3RXEWDDANCNFSM4LRC2C5A
.


Add install of dotnet tools

Description

Add support to add dotnet tools to the toolset.
Add new section under dotnet.
Add installer for dotnet tools.
Add tests for dotnet tools.
Add installed dotnet tools to software report.

Related issue:

Closes #4818

Check list

[x] Related issue / work item is attached
[x] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2016, windows2019, windows2022, ubuntu1804, ubuntu2004

@miketimofeev can you please fire another build to test the latest changes?

/azp run windows2016, windows2019, windows2022, ubuntu1804, ubuntu2004

I can see in the log that the tool it's failing to install on windows and I can't find any mention to it in linux.
For Windows there is no detail that I can find about the failure reason.
For Linux I suspect that's my code... 😊 I'm not used to linux and I'm not familiar with the jq library, so it's highly likely that's the reason.
I believe I've now fixed the tests, the framework wasn't happy about the string generation for the context and condition messages.
Really appreciate if you guys could review and fix any syntax errors that are there.

Hey @miketimofeev another spin please 🙂

/azp run windows2016, windows2019, windows2022, ubuntu1804, ubuntu2004

@miketimofeev and again please.
(I can't figure out from the log what's wrong with the dotnet tool install... can you run it with debug output?)

hey @miketimofeev sorry for nagging you again with this, but can you run the build again?
If possible with debug output to understand why the dotnet tool install it's failing on Windows.
Thanks! 😄

Hi @josesimoes . I queued builds for your PR.

Hopefully the install part is fixed for Windows and the Pester tests too.
Please fire a new build.

@miketimofeev done and rebased with main! Please fire another build to check all these.

/azp run windows2016, windows2019, windows2022, ubuntu1804, ubuntu2004

@miketimofeev please fire it again as the running one was canceled with the latest changes...

@josesimoes could you please fix this comment as well?
https://github.com/actions/virtual-environments/pull/4820/files#r781244560

@josesimoes could you please fix this comment as well? https://github.com/actions/virtual-environments/pull/4820/files#r781244560

Done!

/azp run windows2016, windows2019, windows2022, ubuntu1804, ubuntu2004

@al-cheb the Pester test keeps failing for the tool, even with the latest changes you've suggested. I'm not familiar that framework so appreciate if you could look into that and letting me know what should be the correct syntax to use. Thanks!

@al-cheb the Pester test keeps failing for the tool, even with the latest changes you've suggested. I'm not familiar that framework so appreciate if you could look into that and letting me know what should be the correct syntax to use. Thanks!

@josesimoes you need to pass the testcases param and variable, something like this
https://github.com/actions/virtual-environments/blob/2e47a52b7e29c54c85559fc8f925dc7363c9f274/images/linux/scripts/tests/Android.Tests.ps1#L45-L60

@josesimoes you need to pass the testcases param and variable, something like this

@miketimofeev please check if my last commit is what you would like to see there

/azp run ubuntu1804, ubuntu2004

The test seems to be running now with the proper command, but it fails when trying to call it... Something missing in the .NET SDK configuration to be able to run dotnet tools?

The test seems to be running now with the proper command, but it fails when trying to call it... Something missing in the .NET SDK configuration to be able to run dotnet tools?

The main issue is  we install ngbv tool at user wide ~/.dotnet/tools folder which is not presented in PATH. Another issue we have to install this tool at system wide folder due to remove a user profile after an image generation has been finished. Any thoughts about system wide path?

I'm not sure why ~/.dotnet/tools isn't on the path by default on GitHub Action agents. But the workaround my own GitHub Action uses seems easy enough since it's always run in a script.
If the intent here is to make nbgv Just Work on agents without having to install the tool, that's fantastic. For this to be a good user experience, I agree we'd need that path added to PATH by default.

I'm not sure why ~/.dotnet/tools isn't on the path by default on GitHub Action agents. But the workaround my own GitHub Action uses seems easy enough since it's always run in a script.

That seems to be the case. On Windows machines it's all good. On Linux, not so god... But the workaround seems to be clear-

If the intent here is to make nbgv Just Work on agents without having to install the tool, that's fantastic. For this to be a good user experience, I agree we'd need that path added to PATH by default. That would help all other dotnet tools to just work as they do on local dev boxes as well.

That's exactly the point of all this! 😉

@al-cheb are we good with adding the tools path on the .NET SDK installer script?

In that case, I only see to install the tool to the /etc/skel/.dotnet as we do for rust - https://github.com/actions/virtual-environments/blob/af645a7b5e433a9fcc3ea1d6388896e0e3a8cad8/images/linux/scripts/installers/rust.sh

In that case, I only see to install the tool to the /etc/skel/.dotnet as we do for rust - https://github.com/actions/virtual-environments/blob/af645a7b5e433a9fcc3ea1d6388896e0e3a8cad8/images/linux/scripts/installers/rust.sh

@al-cheb if you install a dotnet tool in a specific path it will become a local tool instead of a global tool, which defeats the purpose of all this. Me thinks...

In that case, I only see to install the tool to the /etc/skel/.dotnet as we do for rust - https://github.com/actions/virtual-environments/blob/af645a7b5e433a9fcc3ea1d6388896e0e3a8cad8/images/linux/scripts/installers/rust.sh

@al-cheb if you install a dotnet tool in a specific path it will become a local tool instead of a global tool, which defeats the purpose of all this. Me thinks...

It's a small hack - The /etc/skel directory contains files and directories that are automatically copied over to a new user's home directory when such user is created by the useradd program. -> ~/.dotnet/tools

@al-cheb done, but not entirely sure if that's correct or not 🤪

if you install a dotnet tool in a specific path it will become a local tool instead of a global tool, which defeats the purpose of all this. Me thinks...

FWIW using --tool-path instead of -g does exactly the same thing, but installs to a different location. This isn't the same thing as installing a tool locally in some specific project manifest. You could literally do dotnet tool install --tool-path $HOME/.nuget/tools and have that be equivalent to using the -g switch, I'm pretty sure.

@al-cheb is the new install path OK? or should I point it to the existing prependEtcEnvironmentPath ?

@al-cheb is the new install path OK? or should I point it to the existing prependEtcEnvironmentPath ?

The path should be /etc/skel/.donet/tools and this path should be temporary add to PATH during the test like we do for rust - https://github.com/actions/virtual-environments/blob/af645a7b5e433a9fcc3ea1d6388896e0e3a8cad8/images/linux/scripts/tests/Tools.Tests.ps1
and software update - https://github.com/actions/virtual-environments/blob/af645a7b5e433a9fcc3ea1d6388896e0e3a8cad8/images/linux/scripts/SoftwareReport/SoftwareReport.Rust.psm1
 $env:PATH = "/etc/skel/.dotnet/tools:$($env:PATH)"

@al-cheb done. Please check

I've just rebased the PR branch, should be good to go for a new build? @miketimofeev please

/azp run windows2016, windows2019, windows2022, ubuntu1804, ubuntu2004

Running - pending wait for my updates.

@al-cheb done! Please review and fire build.

/azp run ubuntu1804, ubuntu2004

@al-cheb  🥳 Linux VMs build 🟢  with test and version output as expected!!
Can you please run the Windows pipelines to check those?

/azp run windows2016, windows2019, windows2022

/azp run windows2016, windows2019, windows2022

Test in Windows is still failing.
Looking at the log there is no output of nbgv tool being installed, nor any error, which is odd...
I'm thinking on adding a couple of output messages there to check the progress and trying to figure out what's happening at that point. Is that OK with you guys?

@miketimofeev I've just added a progress output message to dotnet tool install loop, to understand what could be happening there. Can you please fire the build for one of the Windows pipelines?

@al-cheb done!

/azp run windows2016, windows2019, windows2022

No, We should chi and verify the changes made.

And also remove those also.

And also remove those.

Done.

/azp run windows2016, windows2019, windows2022, ubuntu1804, ubuntu2004

/azp run ubuntu1804

/azp restart ubuntu1804

/azp where ubuntu1804

@josesimoes thank you for your contribution!
The changes will be deployed next week.

@miketimofeev happy to have contributed! 😄
And that this will make it easier to add other dotnet tools in the future.


Adds importmap installation guide under install section

Changes
This PR adds a guide on installing stimulus-flatpickr with import maps.
Example
./bin/importmap pin flatpickr stimulus-flatpickr@beta

Pinning "flatpickr" to<EMAIL_ADDRESS>Pinning "stimulus-flatpickr" to<EMAIL_ADDRESS>Pinning "stimulus" to<EMAIL_ADDRESS>
You can then use it in your application.js entrypoint like you would any other module.

thanks


MissingPluginException when trying to use

I followed the docs and i tried to use the example code for getting the distancebetween two geo points below:
double distanceInMeters = await Geolocator().distanceBetween(52.2165157, 6.9437819, 52.3546274, 4.8285838);
          print(distanceInMeters);

This didn't work however and i got an exception:
Unhandled Exception: MissingPluginException(No implementation found for method distanceBetween on channel flutter.baseflow.com/geolocator/methods)

Any ideas why this is happening? I ran packages get,upgrade, even flutter upgrade and still the same issue. Is this method deprecated or removed?

@ShehabSN, I have been looking in to this issue but having a hard time reproducing it. Using the example app (part of the Geolocator plugin). Could you maybe supply a bit more information? Questions right out of the box are:

Which version of the plugin are you using (maybe you are using an outdated version and you should update, we tested with 5.1.1 and 5.1.2)?
Do you get this error on both (Android and iOS) platforms (I tested both platforms and both worked)?
Which version of Flutter do you use?

Closing this issue because of lack of activity. Feel free to re-open it and supply the requested additional information when the issue resurfaces.

Hi - I'm having this issue as well in trying to run unit testing. Perhaps it is because I'm calculating distances before creating a GeoLocator object/stream and starting to get any location. That said, I'm not clear why the distanceBetween function is a Future function; I would have thought it would make sense to be a static class method.
Code to reproduce this is below.
car_trip.dart:
import 'package:geolocator/geolocator.dart';

class CarTrip {
  double tripDistance = 0; // Distance in meters
  var _geoLocator = Geolocator();

  List<Position> _tripWaypoints; // List of positions returned by GPS in a trip

  Future<void> addWaypoint(Position newWaypoint) async {
    if (_tripWaypoints == null) {
      _tripWaypoints = [newWaypoint];
    } else {
      Position priorWaypoint = _tripWaypoints.last;
      tripDistance += await _geoLocator.distanceBetween(priorWaypoint.latitude,
          priorWaypoint.longitude, newWaypoint.latitude, newWaypoint.longitude);
      _tripWaypoints.add(newWaypoint);
    }

    print("NewWaypoint: ${newWaypoint.latitude}, ${newWaypoint.longitude}");

    // TODO: Add trip time.

  } // addWaypoint
} // class CarTrip

car_trip_test.dart:
import 'package:carcost/cartrip.dart';
import 'package:geolocator/geolocator.dart';
import 'package:flutter_test/flutter_test.dart';

main() {
  TestWidgetsFlutterBinding.ensureInitialized();
  test('Distance between waypoints should be non-zero.', () async {
    // Unit test
    Position pos1 = Position(latitude: 33, longitude: 33);
    Position pos2 = Position(latitude: 34, longitude: 34);

    CarTrip testCarTrip = CarTrip();
    await testCarTrip.addWaypoint(pos1);
    await testCarTrip.addWaypoint(pos2);
    print("Test distance is ${testCarTrip.tripDistance} ");
    expect(testCarTrip.tripDistance, 145000);
  });
}

Hi,
I have the same issue when I call Geolocator.isLocationServiceEnabled() in a background isolate function.
Have you a workaround to fix it?
Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, 2.10.5, on macOS 12.3.1 21E258 darwin-arm, locale fr-FR) [✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1) [✓] Xcode - develop for iOS and macOS (Xcode 13.4.1) [✓] Chrome - develop for the web [✓] Android Studio (version 2021.1) [✓] VS Code (version 1.67.2) [✓] Connected device (4 available) [✓] HTTP Host Availability
geolocator: ^8.2.1

Hi @dangabdolfo,
The solution to this is described in this comment.


Uptake newer versions of multi_json & oj (OR) relax version restrictions to minor instead of patch

hi,
We are using this plugin along with few other Fluentd plugins and observed that very strict/exact version dependencies for the plugin dependencies not allowing us to uptake the newer versions. Would it be possible to uptake the newer versions available for multi_json and OJ ? OR it would be nice to relax the version restrictions to a minor version instead of patch ? i.e. replacing "multi_json ~> 1.14.1" with "multi_json ~> 1.14".
Thanks

https://github.com/splunk/fluent-plugin-kubernetes-metrics/pull/131

Thanks.


Add a GitHub action to auto deploy the site with non-whitelisted plugins

It looks like from this repo here: https://github.com/jeffreytse/jekyll-deploy-action. We can setup a GitHub action to auto deploy the site to a gh-pages branch with plugins that are not deemed safe by GitHub.

This is done and we can now auto deploy with gems that are not whitelisted by GitHub!


[QA] CLI Dashboard > Sitemap: Confusion in sitemap report

I have observed that matrics being shown on Sitemap > Landing page > No of Frames and No frames with associate cookies creates more confusion.
This matrics helps when analysing the single site URL but for site map we need to showcase these data such a way that it does not.

Screenshot

Site map

URL

Sitemap shows the no of pages, not the frames.
For https://www.hindustantimes.com/images/popup/sitemap/sitemap-index.xml Sitemap landing pages shows 20 frames but if we observe the individual URL's landing page it has 7+7+7+9+17 so it not near to the count it shows!

@mayan-000 Yes, your explanation stands out valid but we need to figure it out how the same thing we can convey to the end users.
The solution that I can think of : We can add a tooltip which can help the user to give the clear understanding about the same.
What do you think?
CC @ayushnirwal

Yes, the tooltip works. I will update the UI with that as per bandwidth availability.
@kjnanda

The Cookie modification issue has been moved to v0.6.
All the icons added on the top bar were reverted in PR347
So as of now, we have the same old UI on the top bar.
Due to the above reasons, I am closing this issue.

Closed this by mistake, reopened now.

Addressed and released as a part of v0.5


404 should be returned when there is a layout but no view

Describe the bug
If you have<EMAIL_ADDRESS>but no<EMAIL_ADDRESS>then opening / returns the layout without any contents
Expected-behavior
It should return the "route not found" page as there is no @index.tsx
Reproduction
start.vaadin.com -> new project -> download -> run
System Info
24.4.1

It seems not possible to reproduce, start.vaadin.com generates a Java MainLayout project. Steps for Hilla:
start.vaadin.com → new project → add Hilla view (adds as index) → download → delete Hilla @index.tsx view


The Side Navigation Bar's scroll is no working

When you click on anything in the side navigation bar, you can not scroll down using the scroll bar. The scroll bar disappears when you hover the mouse over it
https://github.com/reactjs/react.dev/assets/24520095/330119ff-1de8-4227-abb7-5c475deb82ac

Hi, I have fixed this issue. It will be added soon if the React Team will merge the Pull Request.
https://github.com/reactjs/react.dev/assets/114233864/0213b6ce-360b-4f3a-9872-0ef7cc9329e8


Add example of spacy pipeline with gliner-spacy

Provide an example on how to integrate gliner-spacy into a spacy pipeline.
In this pipeline I wanted to tokenize my sentences by entities, and by words if they weren't in any entities.
If you see potential code optimization feel free to share

Thanks for this! I'll take a look and merge shortly. I think examples like this will help others!

This is great, thanks! There are ways to retokenize the doc so that entities are treated as a single token rather than a multi-word span.
from spacy.pipeline import merge_entities

nlp = spacy.load("en_core_web_sm")
nlp.add_pipe("merge_entities")

Is this what you are trying to achieve? If so, want to modify the example before I merge?

Hi William,
Thanks for the quick feedback.
Indeed that's the function I was looking for.
I improved the example

Thanks so much! Happy to help. I may make a youtube video with the merge pipe. I just realized I never did a video on that.


Optimise some things a bit

A couple of optimisations:

Index the string cache by pointer instead of value, since it's quicker to hash and compare, and we're optimising for caching the exact same literal, which will always have the same pointer.
Use a reference to the strings in the string cache instead of cloning, to avoid some overhead.
Specialize deserialize_seq to index into arrays instead of iterating. (Note: the bigger effect here is probably the fact that indexing is infallible, which avoids the overhead of try ... catch.)
Specialize deserialize_map to index into Object.entries instead of iterating.
Serialize arrays by setting indices instead of using push. (No idea why this is faster, but it is.)

Benchmark
Before
After
Change

Parse canada
46.56 ms/iter
25.71 ms/iter
-44.78%

Parse citm_catalog
10.39 ms/iter
7.12 ms/iter
-31.47%

Parse twitter
9.11 ms/iter
8.08 ms/iter
-11.31%

Serialize canada
11.84 ms/iter
8.88 ms/iter
-25.00%

Serialize citm_catalog
7.62 ms/iter
6.23 ms/iter
-18.24%

Serialize twitter
14.99 ms/iter
14.28 ms/iter
-4.74%

Thanks. I think I had a slightly simpler optimisation branch for arrays somewhere, let me dig that up first before looking deeper.

Specialize deserialize_seq to index into arrays instead of iterating. (Note: the bigger effect here is probably the fact that indexing is infallible, which avoids the overhead of try ... catch.)
Specialize deserialize_map to index into Object.entries instead of iterating.

Looking at my branch, I did these optimizations too, but instead of extending my own *Access types, I used serde::de::value::{Seq, Map}Deserializer. That way, there's no need to go via wrapping-unwrapping Results for the "source is an array" case.
I have some more questions about other optimizations, but if you could change the PR to use those serde built-ins too, we can probably avoid some merge conflicts + make the code a bit simpler.

I have some more questions about other optimizations, but if you could change the PR to use those serde built-ins too, we can probably avoid some merge conflicts + make the code a bit simpler.

Okay, done.

Can you rebase to clean up the history a bit? I could squash everything, but I'd prefer to keep the optimisations in separate commits like you did, just drop the commits with reverted changes (and reverts themselves).

Can you rebase to clean up the history a bit? I could squash everything, but I'd prefer to keep the optimisations in separate commits like you did, just drop the commits with reverted changes (and reverts themselves).

Done.

Perfect, thanks.

Added one more small optimisation and released as 0.4.3.


Add ability to send message as html

Much needed function for me and the bot we're developing using this awesome library, thought a pull request would be in order.
XHTML-IM protocol: http://www.xmpp.org/extensions/xep-0071.html

:+1:

Thank you


Feature power plan

I added a task that allows changing windows power-plan to "High performance" or "Balanced" or "Power saver".

This PR is included in version 1.0.0 :tada:


[Feature] Floating Animation to the Image

Description
Help to grab more user attention.
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

Congratulations, @Damini2004! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Well, I guess this is not needed as of now. Have a look into other issues for Admin Dashboard. @Damini2004


VS Code Open Projects Extensions is not working[Extension Bug]

Extension - visual-studio-code-recent-projects
Author: @thomaspaulmann
Description
VS Code extension to see the recent projects is not working on my MBA, I reinstalled it but still, there is no response from the extension. it just says "Something Went Wrong!"
Raycast version
Version:  1.27.1

duplicate of #808

Got the same

Hey @thomaspaulmann! Seems like a wrong author has been mentioned here. I've checked that the PR fixes the bug

Got the same

getting the same error

Working on my end now


bad syntax highlighting for compound POSIX shell script conditionals

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.93.1 (Universal)
OS Version: macOS 14.6.1 (23G93)

Steps to Reproduce:

if [ "$#" -gt 1 ] && [ "$1" = '-p' ]; then
    PREFIX="$(shift)"
fi

VSCode incorrectly highlights the logical and (&&) as a variable reference or plain text, rather than a stock keyword, when used in compound, conjunction boolean expressions.
Compare the VSCode behavior with the HTML rendered above, whose GitHub linguist parser correctly colorizes the double ampersand as a built-in, logical operator.

I see the correct punctuation.separator.statement.and.shell scope

editor.action.inspectTMScopes

@mcandre it looks like the textmate scope for the && is reasonable, and we don't want to change the default color for the && in shell script at this time. You could change it in your settings with something like this:
  "editor.tokenColorCustomizations": {
    "[*Dark*]": {
      "textMateRules": [
        {
          "scope": "punctuation.separator.statement.and.shell",
          "settings": {
            "foreground": "#4e42f4"
          }
        }
      ]
    }
  },

we don't want to change the default color for the && in shell script at this time

Curious to hear more context behind this blocker.

Users are very sensitive to syntax highlighting color changes, even when it's a strict improvement.


Kernel 4.18 support

Porting kernel patches to v4.18

Could you please remove realsense-viewer stuff, it's not related and will create conflict in one day.

Could you please remove realsense-viewer stuff, it's not related and will create conflict in one day.

Done


source code contains unsafe code or System.Reflection.Emit.DynamicMethod, compiled error

unsafe code
error CS0227: 不安全代码只会在使用 /unsafe 编译的情况下出现
System.Reflection.Emit.DynamicMethod
Dynamic code generation is not supported on this platform.

Reflection.Emit is not currently supported on CoreRT. It depends on either having an interpreter, or a JIT. We only have prototypes for both.


[T3A3][W10-A4]Wang Xien Dong

Ready to merge

Good effort @xdrawks Some comments added. Please close the PR after reading comments.


How to zoom in IOS device's❓

Question
I am able to zoom in android but unable to zoom in the IOS device's is there any solution for IOS device's.
What I tried
No response
VisionCamera Version
2.13.1
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

Incomplete issue. No reproduction steps. No iOS device name. No iOS OS version.

Hey I know this is your first issue on GitHub, but you gotta think about my perspective. How do you expect me to help you if I don't have any information? For me everything works, on an iPhone 11.
I have even written a guide for zooming, and the example app is able to zoom.


Restore windows file explorer.exe

Before you start...

[X] Have you refreshed the page? You might be using an old version of the site.
[X] Have you checked for an existing issue on this topic? If there is one, post a comment on it instead.

What browsers are you seeing the problem on?
Microsoft Edge
Description
I tried files for a while but it really started slowing my machine.  Especially for typing.  I uninstalled, but now I get an error message that is some version of "application not found" when I try to use native explorer.exe.
Any suggestions on how to get back to a working explorer?
Steps To Reproduce
Uninstall
Reboot
Try to use explorer.exe
Expected behavior
Use native explorer.exe
Relevant Assets
No response

This is the repo for the website, not the app. Please open the issue again in https://github.com/files-community/files.


How to operate json-to-js on single js file or bulk way on top level folder

Hi,
I tried this in terminal:
json-to-js test.js it took some time but showed no result nor modification on the file nor any new file created.
I would like some clarification on how to use pbpaste | json-to-js | pbcopy too.
Thanks in advance.

It sounds like you want to write some javascript to a file?
If it's from the clipboard on a mac, this should work pbpaste | json-to-js > test.js
pbpaste | json-to-js | pbcopy just takes your clipboard and pipes it into json-to-js and then replaces your clipboard with the output


Fix qasm_simulator measure sampling bug

Summary
Fixes bug where measure sampling was incorrectly done if the same qubit was measured more than once.
Fixes #2664
Details and comments

NIce work


Update README.md

dummy change to re-trigger ci build

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

merging

@conda-forge-admin, please rerender


Update auth wrapper to fix segfault

This updates the call_credentials_callback function to avoid needing use ($authWrapper), which seems to have been triggering the segfaults.

Codecov Report

Merging #161 into master will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   85.63%   85.65%   +0.01%
==========================================
  Files          47       47
  Lines        2493     2503      +10
==========================================
+ Hits         2135     2144       +9
- Misses        358      359       +1

Impacted Files
Coverage Δ

src/ApiCore/AuthWrapper.php
95% <91.66%> (-5%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f0b8f...369a3df. Read the comment docs.

I am overjoyed to see this fix to what is almost certainly one of the more bizarre bugs ever seen.


omnibus documentation changes

Hypatia is way behind on documentation.  Start trying to flesh more of it out; this is not super organized, and covers a number of general topics.

Andy, can I ask you to have a look at a couple of these?


chore(package): update file-loader to version 1.0.0

Closes #573

Codecov Report

Merging #576 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   98.61%   98.61%
=======================================
  Files         250      250
  Lines        3963     3963
=======================================
  Hits         3908     3908
  Misses         55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb2bcb...524b0ca. Read the comment docs.


Return bytea hex values without \\x prefix

By default, Hasura returns bytea values (the type used by Chaingraph for binary data) in the bytea hex format, which is prefixed with \x (which when escaped in JSON responses, looks like \\x). There's an open issue about returning values in other formats, but no movement to make this default configurable (beyond using computed fields and hiding the source field from the public schema): https://github.com/hasura/graphql-engine/issues/3336
Chaingraph v1 stuck with this default, but it would be nice to polish the API in v2 to not require these unexpected prefixes.
The view strategy in #29 might be a perfect solution to this issue. When #29 is implemented, we should hex-encode (encode(VALUE, 'hex')) every bytea value at the view layer such that Hasura exposes the fields as strings.

Any news about this feature ?


Return folder as part of file metadata

Description

Review Time Estimate

[ ] Immediately
[ x] Within one week
[ ] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[x] I have updated the CHANGELOG.md.
[ ] I have signed the CLA
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

The file /metadata route calls jsonfile, that now has a "paths": with the folder's path, or "/"
From issue 228

For issue 228
api.Files jsonfile, adds to fields "downloads" and "views"
added to CHANGELOG.md
Will create a new issue, to turn above toString() fields into int, along with "size" which in now also a string

did you intend to close this issue?


Code Coverage: Improved the coverage generator

Fixed issue #https://github.com/nnsuite/nnstreamer/issues/1275.
This commit is to improve the exsiting coverage generator
to fix an unexpected situation that we sometimes have got a
code coverage report based on out-of-date version.
Changelog

Rewrote the operation flow of coverage generator
Keep the bash writing style with a standard grammar
to support a compatibility  between different bash versions
Added debug message to figure out a reason in case of an error
Improved gbs build command to avoid incorrect reference of a
repository cache folder.

Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>

:memo: Version: 1.20190225. Thank you for submitting PR #495. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

This PR is merged as an urgent comment.


[Synapse]Reimport notebook Failure

Description

Import notebook to a new workspace Failure due to redundant parameters
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Synapse

@jsntcy  would you mind review this? Thanks in advance~^_^


[BUG]  error: use of undeclared identifier '__double2half'; did you mean '__double2hiint'?"

When I launch the script with deepspeed ,there is a error " error: use of undeclared identifier __double2half; did you mean __double2hiint?"
##1. The script as following:
`
import torch
from transformers import AutoTokenizer, AutoModelForCausalLM, pipeline
import time
import os
import deepspeed
model_id = "/home/user/workspace/workspace/gpt2"
payload = "Hello my name is Philipp. I am getting in touch with you because i didn't get a response from you. What do I need to do to get my"
local_rank = int(os.getenv('LOCAL_RANK', '0'))
world_size = int(os.getenv('WORLD_SIZE', '1'))
print("world_size",world_size)
generator = pipeline('text-generation', model=model_id,
device=local_rank,torch_dtype=torch.float16)
print("generator")
generator.model = deepspeed.init_inference(generator.model,
mp_size=world_size,
dtype=torch.float16,
replace_with_kernel_inject=True)
string = generator(payload, do_sample=True,num_beams=1, min_length=256,max_new_tokens=256,pad_token_id = 50256)
if not torch.distributed.is_initialized() or torch.distributed.get_rank() == 0:
print(string)
`
##2. the H/W and S/W
ds_report:
`
'
DeepSpeed C++/CUDA extension op report
NOTE: Ops not installed will be just-in-time (JIT) compiled at
runtime if needed. Op compatibility means that your system
meet the required dependencies to JIT install the op.
JIT compiled ops requires ninja
ninja .................. [OKAY]
op name ................ installed .. compatible
async_io ............... [NO] ....... [OKAY]
cpu_adagrad ............ [NO] ....... [OKAY]
cpu_adam ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
random_ltd ............. [NO] ....... [OKAY]
[WARNING]  sparse_attn is not compatible with ROCM
sparse_attn ............ [NO] ....... [NO]
spatial_inference ...... [NO] ....... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
utils .................. [NO] ....... [OKAY]
DeepSpeed general environment info:
torch install path ............... ['/opt/conda/lib/python3.8/site-packages/torch']
torch version .................... 1.13.0a0+git941769a
deepspeed install path ........... ['/home/user/workspace/DeepSpeed/deepspeed']
deepspeed info ................... 0.9.0+f662bfcd, f662bfcd, master
torch cuda version ............... None
torch hip version ................ 5.4.22801-aaa1e3d8
nvcc version ..................... None
deepspeed wheel compiled w. ...... torch 1.13, hip 5.4
'
##3. launch command:
deepspeed --num_gpus 4 gpt2_deepspeed.py
##4. the error detail as following:
Using envvar MAX_JOBS (32) as the number of workers... [1/5] /opt/rocm/bin/hipcc  -DWITH_HIP -DTORCH_EXTENSION_NAME=transformer_inference -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1013\" -I/home/user/workspace/DeepSpeed/csrc/transformer/inference/includes -I/home/user/workspace/DeepSpeed/csrc/includes -isystem /opt/conda/lib/python3.8/site-packages/torch/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include/TH -isystem /opt/conda/lib/python3.8/site-packages/torch/include/THC -isystem /opt/conda/lib/python3.8/site-packages/torch/include/THH -isystem /opt/rocm/include -isystem /opt/rocm/miopen/include -isystem /opt/rocm/hip/include -isystem /opt/conda/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -std=c++14 -O3 -std=c++14 -g -Wno-reorder -fPIC -D__HIP_PLATFORM_HCC__=1 -DUSE_ROCM=1 -DCUDA_HAS_FP16=1 -D__HIP_NO_HALF_OPERATORS__=1 -D__HIP_NO_HALF_CONVERSIONS__=1 -O3 -std=c++14 -U__HIP_NO_HALF_OPERATORS__ -U__HIP_NO_HALF_CONVERSIONS__ -U__HIP_NO_HALF2_OPERATORS__ -DROCM_VERSION_MAJOR=5 -DROCM_VERSION_MINOR=4 --amdgpu-target=gfx900 --amdgpu-target=gfx906 --amdgpu-target=gfx908 --amdgpu-target=gfx90a --amdgpu-target=gfx1030 -fno-gpu-rdc -c /home/user/workspace/DeepSpeed/csrc/transformer/inference/csrc/layer_norm.hip -o layer_norm.cuda.o FAILED: layer_norm.cuda.o /opt/rocm/bin/hipcc  -DWITH_HIP -DTORCH_EXTENSION_NAME=transformer_inference -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1013\" -I/home/user/workspace/DeepSpeed/csrc/transformer/inference/includes -I/home/user/workspace/DeepSpeed/csrc/includes -isystem /opt/conda/lib/python3.8/site-packages/torch/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -isystem /opt/conda/lib/python3.8/site-packages/torch/include/TH -isystem /opt/conda/lib/python3.8/site-packages/torch/include/THC -isystem /opt/conda/lib/python3.8/site-packages/torch/include/THH -isystem /opt/rocm/include -isystem /opt/rocm/miopen/include -isystem /opt/rocm/hip/include -isystem /opt/conda/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -std=c++14 -O3 -std=c++14 -g -Wno-reorder -fPIC -D__HIP_PLATFORM_HCC__=1 -DUSE_ROCM=1 -DCUDA_HAS_FP16=1 -D__HIP_NO_HALF_OPERATORS__=1 -D__HIP_NO_HALF_CONVERSIONS__=1 -O3 -std=c++14 -U__HIP_NO_HALF_OPERATORS__ -U__HIP_NO_HALF_CONVERSIONS__ -U__HIP_NO_HALF2_OPERATORS__ -DROCM_VERSION_MAJOR=5 -DROCM_VERSION_MINOR=4 --amdgpu-target=gfx900 --amdgpu-target=gfx906 --amdgpu-target=gfx908 --amdgpu-target=gfx90a --amdgpu-target=gfx1030 -fno-gpu-rdc -c /home/user/workspace/DeepSpeed/csrc/transformer/inference/csrc/layer_norm.hip -o layer_norm.cuda.o Warning: The --amdgpu-target option has been deprecated and will be removed in the future.  Use --offload-arch instead. Warning: The --amdgpu-target option has been deprecated and will be removed in the future.  Use --offload-arch instead. Warning: The --amdgpu-target option has been deprecated and will be removed in the future.  Use --offload-arch instead. Warning: The --amdgpu-target option has been deprecated and will be removed in the future.  Use --offload-arch instead. Warning: The --amdgpu-target option has been deprecated and will be removed in the future.  Use --offload-arch instead. In file included from /home/user/workspace/DeepSpeed/csrc/transformer/inference/csrc/layer_norm.hip:8: /home/user/workspace/DeepSpeed/csrc/includes/conversion_utils_hip.h:270:12: error: use of undeclared identifier __double2half'; did you mean '__double2hiint?     return __double2half(val);            ^~~~~~~~~~~~~            __double2hiint /opt/rocm-5.4.0/include/hip/amd_detail/amd_device_functions.h:440:30: note: __double2hiint declared here __device__ static inline int __double2hiint(double x) {                              ^ In file included from /home/user/workspace/DeepSpeed/csrc/transformer/inference/csrc/layer_norm.hip:12: /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:278:43: error: excess elements in struct initializer     constexpr __half2_raw zero = {0x0000, 0x0000};                                           ^~~~~~ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:285:42: error: excess elements in struct initializer     constexpr __half2_raw inf = {0x7C00, 0x7C00};                                          ^~~~~~ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:292:46: error: excess elements in struct initializer     constexpr __half2_raw neg_inf = {0xFC00, 0xFC00};                                              ^~~~~~ In file included from /home/user/workspace/DeepSpeed/csrc/transformer/inference/csrc/layer_norm.hip:8: In file included from /home/user/workspace/DeepSpeed/csrc/includes/conversion_utils_hip.h:9: In file included from /home/user/workspace/DeepSpeed/csrc/includes/ds_kernel_utils_hip.h:24: In file included from /opt/rocm-5.4.0/include/hip/hip_cooperative_groups.h:38: /opt/rocm-5.4.0/include/hip/amd_detail/amd_hip_cooperative_groups.h:527:3: error: static assertion failed due to requirement 'integral_constant<bool, false>::value': Tile size is either not a power of 2 or greater than the wavefront size   static_assert(is_valid_tile_size<size>::value,   ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /opt/rocm-5.4.0/include/hip/amd_detail/amd_hip_cooperative_groups.h:563:39: note: in instantiation of template class 'cooperative_groups::thread_block_tile_base<64>' requested here class thread_block_tile_type : public thread_block_tile_base<tileSize>, public tiled_group {                                       ^ /opt/rocm-5.4.0/include/hip/amd_detail/amd_hip_cooperative_groups.h:624:43: note: in instantiation of template class cooperative_groups::thread_block_tile_type<64> requested here class thread_block_tile_internal : public thread_block_tile_type<size, ParentCGTy> {                                           ^ /opt/rocm-5.4.0/include/hip/amd_detail/amd_hip_cooperative_groups.h:650:46: note: in instantiation of template class cooperative_groups::impl::thread_block_tile_internal<64, void> requested here class thread_block_tile<size, void> : public impl::thread_block_tile_internal<size, void> {                                              ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:343:44: note: in instantiation of template class cooperative_groups::thread_block_tile<64, void> requested here         data[0] = element<Op>(data[0], warp.shfl_xor(data[0], i));                                            ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:352:46: error: no member named 'shfl_xor' in cooperative_groups::thread_block_tile<64, void>         data[0] = element<Op1>(data[0], warp.shfl_xor(data[0], i));                                         ~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:353:46: error: no member named 'shfl_xor' in cooperative_groups::thread_block_tile<64, void>         data[1] = element<Op2>(data[1], warp.shfl_xor(data[1], i));                                         ~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:362:46: error: no member named 'shfl_xor' in cooperative_groups::thread_block_tile<64, void>         data[0] = element<Op1>(data[0], warp.shfl_xor(data[0], i));                                         ~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:363:46: error: no member named 'shfl_xor' in cooperative_groups::thread_block_tile<64, void>         data[1] = element<Op2>(data[1], warp.shfl_xor(data[1], i));                                         ~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:364:46: error: no member named 'shfl_xor' in cooperative_groups::thread_block_tile<64, void>         data[2] = element<Op3>(data[2], warp.shfl_xor(data[2], i));                                         ~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:373:46: error: no member named 'shfl_xor' in cooperative_groups::thread_block_tile<64, void>         data[0] = element<Op1>(data[0], warp.shfl_xor(data[0], i));                                         ~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:374:46: error: no member named 'shfl_xor' in cooperative_groups::thread_block_tile<64, void>         data[1] = element<Op2>(data[1], warp.shfl_xor(data[1], i));                                         ~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:375:46: error: no member named 'shfl_xor' in cooperative_groups::thread_block_tile<64, void>         data[2] = element<Op3>(data[2], warp.shfl_xor(data[2], i));                                         ~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:376:46: error: no member named 'shfl_xor' in 'cooperative_groups::thread_block_tile<64, void>'         data[3] = element<Op4>(data[3], warp.shfl_xor(data[3], i));                                         ~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:412:18: error: no member named 'meta_group_size' in 'cooperative_groups::thread_block_tile<64, void>'     if (warp_arg.meta_group_size() > 1 && total_warps != 1) {         ~~~~~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:413:22: error: no member named 'thread_rank' in 'cooperative_groups::thread_block_tile<64, void>'         if (warp_arg.thread_rank() == 0) {             ~~~~~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:417:54: error: no member named 'meta_group_rank' in 'cooperative_groups::thread_block_tile<64, void>'                     reduce_buffer + elems * warp_arg.meta_group_rank() + i, data + i);                                             ~~~~~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:424:22: error: no member named 'meta_group_rank' in 'cooperative_groups::thread_block_tile<64, void>'         if (warp_arg.meta_group_rank() == 0) {             ~~~~~~~~ ^ /home/user/workspace/DeepSpeed/csrc/includes/reduction_utils_hip.h:425:26: error: no member named 'thread_rank' in 'cooperative_groups::thread_block_tile<64, void>'             if (warp_arg.thread_rank() < warp_arg.meta_group_size()) {                 ~~~~~~~~ ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated when compiling for gfx1030.
##Expected behavior
Has anyone encountered the same error and how to solve it? thanks you!
##Screenshots
If applicable, add screenshots to help explain your problem.
##System info (please complete the following information):

OS: Ubuntu 20.04

GPU：GPU : MI100 * 8

Python version: Python 3.8.13

Any other relevant info about your setup

##Docker context
rocm/pytorch:latest

Hi @WeiMa01 thanks for reporting this issue. It looks like this might be a problem in the hipification of our CUDA code. Could you please share if you were able to run this example previously (perhaps with an older version of ROCm/DeepSpeed)? I'll look into this further. Thanks

Hi @WeiMa01 thanks for reporting this issue. It looks like this might be a problem in the hipification of our CUDA code. Could you please share if you were able to run this example previously (perhaps with an older version of ROCm/DeepSpeed)? I'll look into this further. Thanks

Hi @mrwyattii I can run the script normally on the NVIDIA V100 GPU  before, but this error occurs when I transplant it to the MI100 server, and I have not run it with other version of ROCm/DeepSpeed on AMD GPU before.

I also got stuck at this issue:
error: use of undeclared identifier '__double2half'; did you mean '__double2hiint'?


Dask merge concat fill value

This PR refines the approach taken with handling the cube.fill_value by merge and concatenate.
This PR extends the expected behaviour of numpy with regards to how it manages the fill_value when combining masked arrays and/or ndarrays to cubes (it is valid for a cube to have a fill_value even though it has a ndarray payload).
In summary, when combining cubes via merge or concatenate, the resultant cube will have:

a fill_value that is non-None iff all cubes have the same non-None fill_value
a fill_value that is None, if:

at least one cube has a fill_value of None, or
the candidate cube and the proto-cube have a different fill_value

This simply means that,

if the cube.fill_value is set to a non-None value, and the cube has a masked payload, then the masked array returned by cube.data will have a fill_value that matches the cube.fill_value.
if the cube.fill_value is set to None, and the cube has a masked payload, then the masked array returned by cube.data will have the default fill_value generated by numpy for that specific dtype.

Ping @djkirkham and @lbdreyer ... :smile:

This looks very close!
The testing of concatenate isn't less complete than the testing of merge, but there are endless combinations (masked/unmasked, fill_value_same/fill_value_diff/fill_value_None, lazy/real etc) that we can test for... I want to go through some possible important combinations that we are missing.
but otherwise I'm happy with the changes.

I've looked into testing of concatenate a little more and ignoring the endless combinations we could test I think there are two missing combinations that we should at least consider.

There doesn't appear to be a test for concatenating cubes that are masked and unmasked where both have a fill value of None.

Also there isn't testing of fil value when both cubes are unmasked.

@lbdreyer Okay, so I've addressed your review actions in the simplest way possible. Adding a concatenate equivalent to the merge TestDataMergeCombos isn't really practical and would involve quite a bit of effort, so I've added the missing test coverage through new tests and adding to existing tests.

@bjlittle if you adress my last comment I will happily merge this in

@lbdreyer Thanks :+1:


improve sample certificate creation Makefile

create a root-ca config
leave intermediate files to save work when creating multiple intermediate certificates

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: elevran
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: frankbu
If they are not already assigned, you can assign the PR to them by writing /assign @frankbu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @frankbu

@elevran: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
520d9cfca33c5e3be5cbd87e92ba03aeb7ab9a41
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elevran: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
520d9cfca33c5e3be5cbd87e92ba03aeb7ab9a41
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
520d9cfca33c5e3be5cbd87e92ba03aeb7ab9a41
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elevran: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
520d9cfca33c5e3be5cbd87e92ba03aeb7ab9a41
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
520d9cfca33c5e3be5cbd87e92ba03aeb7ab9a41
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
520d9cfca33c5e3be5cbd87e92ba03aeb7ab9a41
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: elevran
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elevran: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
520d9cfca33c5e3be5cbd87e92ba03aeb7ab9a41
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
520d9cfca33c5e3be5cbd87e92ba03aeb7ab9a41
link
/test istio_auth_sds_e2e

prow/e2e-simpleTests-cni.sh
e0c02e9c7b0d3efc715b2722cead3de4d49655c9
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elevran: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
520d9cfca33c5e3be5cbd87e92ba03aeb7ab9a41
link
/test istio_auth_sds_e2e

prow/e2e-simpleTests-cni.sh
e0c02e9c7b0d3efc715b2722cead3de4d49655c9
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
e0c02e9c7b0d3efc715b2722cead3de4d49655c9
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elevran: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
520d9cfca33c5e3be5cbd87e92ba03aeb7ab9a41
link
/test istio_auth_sds_e2e

prow/e2e-simpleTests-cni.sh
e0c02e9c7b0d3efc715b2722cead3de4d49655c9
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
e0c02e9c7b0d3efc715b2722cead3de4d49655c9
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
e0c02e9c7b0d3efc715b2722cead3de4d49655c9
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth


KAFKA-5525: Streams reset tool should have same console output with or without dry-run

Fixed console output to be consistent with/without dry-run option

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5739/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5725/
Test PASSed (JDK 8 and Scala 2.12).

@mjsax any news about merging this already approved PR ?

I can't merge anything. I am not a committer. \cc @guozhangwang @dguy

This LGTM. Thanks!

Merged to trunk.


Hyperlinks in image description do not work

My image descriptions have hyperlinks to refer to Licenses and Authors. However the links seem unclickable.
Example of issue:
visit https://beta.water-fountains.org/zurich?lang=de&queryType=byId&database=wikidata&idval=Q27230005

@mmmatthew fixed in 5.8.0


Automated rendering process

The rendering now automatically restarts after reaching maxframes (as per #15)

The new renderings use the default settings
Pressing R disables autorestarting
This behavior can be toggled by changing autorestart

Writing frames to the disk can be toggled by changing writeframes (as per #16)

The name is a bit misleading. The process is only semiautomatic for several reasons.
1: Depending in the image and settings used, a rendering may appear complete after significantly different amounts of time, and after a very different number of frames have been generated.
2: At the moment, ‘compile-all.sh’ does not execute automatically. Frame generation must be stopped manually after an appropriate number of iterations have completed, then the user must run ‘compile-all.sh’ independently of the Processing script.


Server-side socket events

Hey team Sails, hope things are well. Wondering... is there a way to listen for server-side  socket event? My end goal is to notify all clients subscribed to a room when a client leaves or enters the room. To do so, I figured I would have the server broadcast connect and disconnect events, but I'm not sure how to listen for / respond to those events. Any ideas on how to handle something like this?
Thanks!

Hi @dhcole!  FYI, this forum is strictly for bug reports on the Sails core.  For support in the future, please use our Google Group, live chat or StackOverflow.

You can get the underlying [socket.io](http://socket.io) instance via `sails.io`, giving you access to `sails.io.on()` and `sails.io.emit()`.  However, this isn't the recommended method of handling client "presence".  Instead, you can use Sails' [resourceful pubsub](http://sailsjs.org/documentation/reference/web-sockets/resourceful-pub-sub) methods to notify all subscribers to a "room" model whenever a client connects or disconnects.  For a simple example of using resourceful pubsub (and some of the lower-level [`sails.sockets.*` methods](http://sailsjs.org/documentation/reference/web-sockets/sails-sockets)), see [SailsChat](https://github.com/balderdashy/sailschat).

I cant do it :'(

@joaolucas89 sorry to hear that. Can you create a repo that demonstrates the issue you have?


[SPARK-17230] [SQL] Should not pass optimized query into QueryExecution in DataFrameWriter

What changes were proposed in this pull request?
Some analyzer rules have assumptions on logical plans, optimizer may break these assumption, we should not pass an optimized query plan into QueryExecution (will be analyzed again), otherwise we may some weird bugs.
For example, we have a rule for decimal calculation to promote the precision before binary operations, use PromotePrecision as placeholder to indicate that this rule should not apply twice. But a Optimizer rule will remove this placeholder, that break the assumption, then the rule applied twice, cause wrong result.
Ideally, we should make all the analyzer rules all idempotent, that may require lots of effort to double checking them one by one (may be not easy).
An easier approach could be never feed a optimized plan into Analyzer, this PR fix the case for RunnableComand, they will be optimized, during execution, the passed query will also be passed into QueryExecution again. This PR make these query not part of the children, so they will not be optimized and analyzed again.
Right now, we did not know a logical plan is optimized or not, we could introduce a flag for that, and make sure a optimized logical plan will not be analyzed again.
How was this patch tested?
Added regression tests.

cc @yhuai @JoshRosen @rxin

Test build #64377 has started for PR 14797 at commit 25c451a.

Test build #64377 has finished for PR 14797 at commit 25c451a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
          logWarning(s\"All labels belong to a single class and fitIntercept=false. It's a \" +
   * Set thresholds in multiclass (or binary) classification to adjust the probability of
class MultinomialLogisticRegression @Since(\"2.1.0\") (
          logWarning(s\"All labels belong to a single class and fitIntercept=false. It's\" +
  /** Margin (rawPrediction) for each class label. */
  /** Score (probability) for each class label. */
  class MultinomialLogisticRegressionModelWriter(instance: MultinomialLogisticRegressionModel)
 class ALSWrapperWriter(instance: ALSWrapper) extends MLWriter
 class ALSWrapperReader extends MLReader[ALSWrapper]
 class GaussianMixtureWrapperWriter(instance: GaussianMixtureWrapper) extends MLWriter
 class GaussianMixtureWrapperReader extends MLReader[GaussianMixtureWrapper]
 class IsotonicRegressionWrapperWriter(instance: IsotonicRegressionWrapper) extends MLWriter
 class IsotonicRegressionWrapperReader extends MLReader[IsotonicRegressionWrapper]
 class LDAWrapperWriter(instance: LDAWrapper) extends MLWriter
 class LDAWrapperReader extends MLReader[LDAWrapper]
  class MultilayerPerceptronClassifierWrapperWriter(instance: MultilayerPerceptronClassifierWrapper)
class JavaClassificationModel(JavaPredictionModel):
class LogisticRegressionModel(JavaModel, JavaClassificationModel, JavaMLWritable, JavaMLReadable):
class DecisionTreeClassificationModel(DecisionTreeModel, JavaClassificationModel, JavaMLWritable,
class RandomForestClassificationModel(TreeEnsembleModel, JavaClassificationModel, JavaMLWritable,
class GBTClassificationModel(TreeEnsembleModel, JavaPredictionModel, JavaMLWritable,
class NaiveBayesModel(JavaModel, JavaClassificationModel, JavaMLWritable, JavaMLReadable):
class MultilayerPerceptronClassificationModel(JavaModel, JavaPredictionModel, JavaMLWritable,
class LinearRegressionModel(JavaModel, JavaPredictionModel, JavaMLWritable, JavaMLReadable):
class DecisionTreeModel(JavaModel, JavaPredictionModel):
class RandomForestRegressionModel(TreeEnsembleModel, JavaPredictionModel, JavaMLWritable,
class GBTRegressionModel(TreeEnsembleModel, JavaPredictionModel, JavaMLWritable, JavaMLReadable):
class GeneralizedLinearRegressionModel(JavaModel, JavaPredictionModel, JavaMLWritable,
class JavaPredictionModel():
class SubstituteUnresolvedOrdinals(conf: CatalystConf) extends Rule[LogicalPlan]
case class UnresolvedInlineTable(
case class UnresolvedTableValuedFunction(functionName: String, functionArgs: Seq[Expression])
case class UnresolvedOrdinal(ordinal: Int)
case class Literal (value: Any, dataType: DataType) extends LeafExpression with CodegenFallback
abstract class PlanExpression[T <: QueryPlan[_]] extends Expression
abstract class SubqueryExpression extends PlanExpression[LogicalPlan]
case class ListQuery(plan: LogicalPlan, exprId: ExprId = NamedExpression.newExprId)
case class Exists(plan: LogicalPlan, exprId: ExprId = NamedExpression.newExprId)
case class SubqueryAlias(
class QuantileSummaries(
  case class Stats(value: Double, g: Int, delta: Int)
class JDBCOptions(
abstract class ExecSubqueryExpression extends PlanExpression[SubqueryExec]
class OrcFileFormat extends FileFormat with DataSourceRegister with Serializable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64377/
Test FAILed.

Test build #64682 has started for PR 14797 at commit 7771c6a.

Test build #64682 has finished for PR 14797 at commit 7771c6a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64682/
Test FAILed.

Merged build finished. Test FAILed.

Test build #64791 has started for PR 14797 at commit 02b2896.

Test build #64791 has finished for PR 14797 at commit 02b2896.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64791/
Test PASSed.

LGTM

Looks fine.

Merged this into master and 2.0 branch, thanks!

This does not catch all the cases. In CTAS, we still optimize the query. By following the way in this PR, I can try to fix that case. Thanks!

@gatorsmile want to put the regression tests at here? Or, you have already have a pr?

The test failure in Spark 2.0 has been fixed in https://github.com/apache/spark/pull/14951. However, after this fix, we still optimize the query in CTAS twice, as reported in this PR. Thus, I plan to fix it soon. Thanks!

Thanks! Is there a jira?

Just created a JIRA: https://issues.apache.org/jira/browse/SPARK-17409
FYI, Spark 2.0.1 has been fixed by this PR, but Spark 2.1.0 has the issue due to the related codes have been changed.


A ton of ship updates

I present to you
(probably) functioning Station Administrator job that I don't know how to make an NPC/ghost role spawner for.
SA access card in the spawn room for the trade station command to fix this issue. ^
Faction access doors on every NPC ship (minus a couple specific cases)
NPCs on every NPC ship (who are armed with weapons!!)


restart-app-instance won't be recorded in `cf events" ?

On cf version  "build": "v11.2.0",,   I executed cf restart-app-instance <app> <instance-number> cmd,   the application instance was restarted as expected, but I can't find the audit log for this action in cf events
>>>cf restart-app-instance asmon 0
Restarting instance 0 of application asmon as xxxx
OK

>>> cf app asmon
Showing health and status for app asmon in xxxxx

name:              asmon
....

type:           web
instances:      1/1
memory usage:   1024M
     state     since                  cpu      memory         disk           details
#0   running   2019-09-30T05:28:07Z   162.8%   170.1M of 1G   259.4M of 1G

>>> cf events asmon
Getting events for app asmon in xxxx

time                          event                      actor                description
2019-09-25T10:13:44.00+0800   audit.app.ssh-authorized   xxxx   index: 0
....

I expected a restart record on  2019-09-30T05:xx:xxZ in cf events output.

restarting an app instance is not the same as restarting an app. we don't have an audit event for restarting app instances and there's currently no plan to introduce one.


Keyboard mapping doesn't work properly

The keyboard mapping is a bit buggy:

ALT-GR mapping doesn't work on Windows
Control and Command are switched on macOS

Do you refer to the keyboard mapping of Capella, run though Guacamole?

The keyboard mapping which is done by Guacamole.

The keyboard mappings are better when using the new connection method Xpra. Users with keyboard mapping issues can therefore switch to the alternative connection method.
To keep the list of issues clean, I'll close this issue due to the low priority.


Does not seem to be a light level for block mappings

Seems to be missing light level for blocks in mapping

https://github.com/FabricMC/yarn/blob/1.19.2/mappings/net/minecraft/block/AbstractBlock.mapping#L986 🤔

Ok just wondered if it was to be expected


A mismatch between best hyperparameters and hyperparameters ranges

Hello. We were trying to develop a new method on top of AdaLoRA and are faced with an inconvenience regarding the hyperparameter search used for GLUE.

With Appendix Section C, you have provided hyperparameter ranges used during hyperparameter search, and then you report best-performing learning rates. Although, the best-performing values that you have reported are not included in the search range. E.g., for the STS-B dataset, you use a learning rate equal to 2.2e-3, which is not listed in Section C.2.
Could you help me understand what I am missing and which ranges I should use to ensure the reproducibility of your hyperparameter search?

Furthermore, which ranks/target ranks are used to obtain results from Table 1?
E.g., For AdaLoRA with 0.32M of trainable parameters, according to Appendix C.1, I should use r=4 and target_rank=2. However, scripts provided with this repository contain various ranks beyond these values.
For CoLA and MNLI datasets r=3 and target_rank=1
For others, r=2 and target_rank=1.
Am I correctly understanding that to reproduce results from Table 1 with 0.32M parameters, I should strictly use r=4 and target_rank=2?

@kefirski Hello, I've encountered the same issue. I also tried setting r=2 and target_rank=1 on the MRPC dataset, but I found that the performance is not as good as the original settings in the script. Have you faced a similar issue, and how did you resolve it?

Furthermore, which ranks/target ranks are used to obtain results from Table 1?
E.g., For AdaLoRA with 0.32M of trainable parameters, according to Appendix C.1, I should use r=4 and target_rank=2. However, scripts provided with this repository contain various ranks beyond these values.
For CoLA and MNLI datasets r=3 and target_rank=1 For others, r=2 and target_rank=1.
Am I correctly understanding that to reproduce results from Table 1 with 0.32M parameters, I should strictly use r=4 and target_rank=2?

Furthermore, which ranks/target ranks are used to obtain results from Table 1?
E.g., For AdaLoRA with 0.32M of trainable parameters, according to Appendix C.1, I should use r=4 and target_rank=2. However, scripts provided with this repository contain various ranks beyond these values.
For CoLA and MNLI datasets r=3 and target_rank=1 For others, r=2 and target_rank=1.
Am I correctly understanding that to reproduce results from Table 1 with 0.32M parameters, I should strictly use r=4 and target_rank=2?

I've encountered the same issue. I also tried setting r=4 and target_rank=2 on the MRPC dataset, but I found that the performance even worse than the original settings in the script. Have you faced a similar issue, and how did you resolve it?


Update xenium mouse brain datasets

Based on our discussion, made some changes to the dataset implementation scripts:

Adding all columns in adata.obs to observation.tsv for quality control
Changing the format for samples.tsv for snakemake workflow to identify the number of clusters
using region_level_2 as the current cluster label input.

Let me know if it's ok or if there's anything else u'd like to change. Thanks!

Looks good! Thanks for having a second look at the script Jieran.

Thanks for reviewing it!


Could you please publish a new version of rubygems?

Currently, the latest version cannot be installed with the gem command.

Thanks to your kindly reminder. Just release v0.2.0.


About checkpoint.pth.tar

Could I delete checkpoint.pth.tar when pre-trained is completed?
And, could I rollback my pre-trained model by specifying the checkpoint.pth.tar?

I am not sure what you mean. The checkpoint.pth.tar records the latest checkpoint.

Thks


Track cast target formal type

SIL type lowering erases the distinction between certain types, and it's not really proper for IRGen to take a lowered type and realize metadata for it anyway. This is a painful refactoring that is meant to address these issues. For now, it's NFC.

@swift-ci Please test

@swift-ci Please test source compatibility

Build failed
Swift Test Linux Platform
Git Sha - 5241b0aefc6f5886815238b11751ab1deae550a5

@swift-ci Please test Linux

Build failed
Swift Test OS X Platform
Git Sha - 5241b0aefc6f5886815238b11751ab1deae550a5

@swift-ci Please clean test


What's the long-term support roadmap for this project?

With the new API's supporting OpenAPI what's the long-term roadmap of this project to be? As the new API's don't cover the old API's completely yet, there's still plenty of support for this project!

I'm current in the process of having the SDK files been generated automatically from eBay's OpenAPI files. I will also keep support for the old APIs. I don't have a timeframe yet but I would like to have something in place over the next few months.

Would it be possible to come up with contribution guidelines for this project? Or make the build instructions available so that the project can continue?

@henryturk there are many good generators out there, feel free to give them a try, i did myself and they work pretty well: https://github.com/michabbb/php-ebay-sdk


Add changesets and release action, remove lerna

If https://github.com/livekit/client-sdk-js/pull/246 gets approved (and works) we can take the same approach with this repo.

I tried this out yesterday again and started to see some TS linking errors appear when trying to
yarn link livekit-client
on this branch. Will investigate before merging this.

the culprit of the linking errors was https://github.com/livekit/client-sdk-js/pull/256


Deployers broken after patch 0.5.0i

Describe the Bug
Applies to Create Fabric 1.18.2, 1.19.2: any 0.5.0i (including latest dev)
When a deployer kills a mob, it gets achievement "Monster Hunter" and zombies around that deployer start pathfinding to it.
Additionally, in 1.19.2 the mob loot drops on the ground instead of going into Deployers inventory, whereas in 1.18.2 it works correctly.
Everything works correctly prior 0.5.0i and also on any Create Forge patch, including 0.5.0i.
Reproduction Steps
https://youtu.be/E_5w9QOCDGI
Expected Result
Deployer should work like on Create Forge or Create Fabric 0.5.0g and prior.

Mob loot should go to Deployers inventory.
Mobs shouldn't be agroed on Deployers
Deployers shouldn't get achievements

Screenshots and Videos

https://youtu.be/E_5w9QOCDGI
Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.0i
Minecraft Version
1.19.2
Other Mods
No response
Additional Context
No response

attacking the deployer back is a feature, there's a config for it. Some reason, they're pathfinding to (0, 0, 0) instead of the actual pos though.
I want to keep the advancement granting because I think it's hilarious.

Well I think the biggest problem from these is in 1.19, that the loot drops on ground instead of going into deployers inventory.

Actually, pathfinding to (0, 0, 0) is identical behavior to Forge on 1.18, and doesn't happen on 1.19.

item collecting is fixed with my last 2 commits.

Yes, but should the zombies even pathfind to the deployers? It doesn't make much sense.

yes, it's intentional.


Edit ruleset page

Create a page that allows editing the latest ruleset version in order to create a new one
Path: GET /rulesets/<path>/edit
Get data from: GET /i/rulesets/<path>
Submit data to: PATCH /i/rulesets/<path>
Sketch:

Related to #36

I will postpone this and begin by the latest ruleset page (#32) which is needed to be able to access to the edit page.


Fix zoom issues

Fix issues #12 and #141 as discussed with @Luthaf.

The Python test failure is unrelated to this PR, I'll fix it separately. I guess some float formatting code was updated and broke the tests.
The npm linting error is related to these changes though, you can run these tests with npm test to reproduce the error locally. You can use // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access on (event as any).wheelDelta to allow any on this specific line, and cast the result to a number for "Unsafe assignment of an any value".

You can rebase this branch on top of master to get the fix for the python tests (#211)

Merged! Thanks a lot @slietar

Cool! Thanks


2.0.4-Preview9 Connection Issue

Attempting use connect-exchangeonline command not working as intended, depending on the circumstance. Running the command by itself is fine. Running it in a script is not either A: not launching the credentials window or B: after credentials window it doesn't continue on with the rest of the script - depending on how it's being ran.
This issue started with 2.0.4. I figured out it was this version by installing version 2.0.3 and my script started working fine again. I have no idea how to provide further information in this. Please let me know what I can do to help out.

I just realized that 2.0.4 has been released for a month. That'd be the version I was on, not Preview9.

If you do not see any document update, please go ahead and close this one. Thanks

@whatanatta, thank you for your feedback. Here we are limited to documentation issues and improvements.
In this case, if you are experiencing this issue outside the script using the latest version, I recommend opening a support ticket to report it.
Please follow this link to contact support for business products:  https://docs.microsoft.com/office365/admin/contact-support-for-business-products.
You can also provide feedback about this issue on the product team blog.
Version 2.0.4 starts using a different authentication library, and I think this issue is well known by the product team and was reported before:
https://github.com/MicrosoftDocs/office-docs-powershell/issues/7326
Please keep us posted here on the resolution to feed whatever information you discover into the content.

@dariomws  Thank you very much for the contribution and sharing this explanation. @whatanatta Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed here to close it.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Replace Chasm of Fire Cannon Spot

Is your feature request related to a problem?
No
A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]
More kills / exp and safer cannon reload
Describe the solution you'd like
Replace it
Describe alternatives you've considered
None
Additional context
Screenshot here: https://i.imgur.com/WKxEvKw.png
It can allow you to attack 1-2 extra Demons at a go.

Since it seems like this is a range spot, I think ill add it as another spot and leave the current one up also


Add a docker.save target

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
4143c7fbfc4c1bdd8bd33cd150d67f0235282896
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
349523b2f7b3ab7ee9f1228a17cbc27813973a99
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn I don't recall why we need this target.  I believe either you or @geeknoid had requested this work and it may be part of the release workflow.  If this work is needed, please let me know and I'll finish it.
Cheers
-steve

If you want this to be published as part of the istio release we need this target

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
944b013d5ade72e671b2ef9d3f7842984a3f0dfb
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

If you want this to be published as part of the istio release we need this target

@howardjohn PTAL.  tx.
Cheers
-steve

Looking at CNI (I was checking to determine if it had a docker.save target) I see:
mkdir -p /work/out/linux_amd64/release/docker
time (docker save -o /work/out/linux_amd64/release/docker/install-cni.tar istio/install-cni:5f438d5ab98dd1f97ff7c0f5e437e044c314a9c3 && gzip /work/out/linux_amd64/release/docker/install-cni.tar)

I think we should have consistency in our directory locations.  I am unclear if we want things in
GOOS_GOARCH/release/docker or
GOOS_GOARCH_release/docker.
Can you clarify.
Thanks
-steve

we want GOOS_GOARCH/release/docker, this ksnhow istio/istio does it as well
On Mon, Oct 14, 2019, 4:41 AM Steven Dake<EMAIL_ADDRESS>wrote:

Looking at CNI (I was checking to determine if it had a docker.save
target) I see:
mkdir -p /work/out/linux_amd64/release/docker
time (docker save -o /work/out/linux_amd64/release/docker/install-cni.tar istio/install-cni:5f438d5ab98dd1f97ff7c0f5e437e044c314a9c3 && gzip /work/out/linux_amd64/release/docker/install-cni.tar)
I think we should have consistency in our directory locations. I am
unclear if we want things in
GOOS_GOARCH/release/docker or
GOOS_GOARCH_release/docker.
Can you clarify.
Thanks
-steve
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/operator/pull/331?email_source=notifications&email_token=AAEYGXKFDOJ7ADNGHNMFVU3QORLFFA5CNFSM4I6ZLOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBEJMJY#issuecomment-541627943,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXMJQXR2S5V65WBACTTQORLFFANCNFSM4I6ZLOHQ
.

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
5dbdbc4ef53cc5f5a0ad3b357efb1bbac7ca71fe
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.