Cannot regenerate regression result

Running poetry run python tests/regression_results/generate_regression_results.py and then poetry run pytest tests/test_regression_against_cases.py::test_regression_against_case\[SPARC_PRD\] doesn't pass.
>       assert_allclose(dataset, reference_dataset, rtol=1e-8, atol=0)
E       AssertionError: Left and right Dataset objects are not close
E
E
E       Differing data variables:
E       L   radiated_power_method                 object RadiationMethod.Radas
E       R   radiated_power_method                 <U5 'Radas'
E       L   core_radiator                         object Impurity.Xenon
E       R   core_radiator                         <U5 'Xenon'
E       L   profile_form                          object ProfileForm.prf
E       R   profile_form                          <U3 'prf'
E       L   SOL_momentum_loss_function            object MomentumLossFunction.KotovRe...
E       R   SOL_momentum_loss_function            <U11 'KotovReiter'
E       L   lambda_q_scaling                      object LambdaQScaling.EichRegression15
E       R   lambda_q_scaling                      <U16 'EichRegression15'
E       L   energy_confinement_scaling            object ConfinementScaling.ITER98y2
E       R   energy_confinement_scaling            <U8 'ITER98y2'
E       L   fusion_reaction                       object ReactionType.DT
E       R   fusion_reaction                       <U2 'DT'

tests/test_regression_against_cases.py:26: AssertionError

Need to change https://github.com/cfs-energy/cfspopcon/blob/main/cfspopcon/file_io.py#L50C26-L50C26
to if val.dtype == object or val.dtype.type == np.str_:

Also fixed by wiping out .venv and reinstalling

For future reference the problem here was a result of installing netcdf4.
xarray automatically switches from scipy to netcdf4 as i/o backend if it finds netcdf4 and this results in having strings inside the dataset encoded as np._str instead of object.
The conversion logic to promote a string to an enum instance didn't account for this possibility, which is fixed by @tbody-cfs's suggestion above and implemented in #14

closed by #14


abort on disconnected

as @pcrumley pointed out in https://github.com/swift-nav/swift-toolbox/pull/1033, the curl should abort on channel disconnected.

Cc @notoriaga


CI: Add support for RHEL-9

From now the rhel-8-y status is the latest unreleased RHEL-8 and the rhel-x status is pre-released RHEL-9.

please add the following to tests/tasks/setup_ipa.yml before the call to the hostname module which requires the hostname package:
- name: ensure hostname package is installed
  package:
    name: hostname
    state: present

That should make the rhel-x test pass (or at least get a little farther)

There is a issue installing IPA server:
TASK [ipaserver : Install - Ensure that IPA server packages are installed] *****
task path: /tmp/freeipa-repo/roles/ipaserver/tasks/install.yml:5
fatal: [/cache/rhel-x.qcow2]: FAILED! => {"changed": false, "failures": ["No package ipa-server available."], "msg": "Failed to install some of the specified packages", "rc": 1, "results": []}
https://github.com/freeipa/ansible-freeipa/blob/master/roles/ipaserver/tasks/install.yml#L5

There is a issue when installing IPA server:
TASK [ipaserver : Install - Ensure that IPA server packages are installed] *****
task path: /tmp/freeipa-repo/roles/ipaserver/tasks/install.yml:5
fatal: [/cache/rhel-x.qcow2]: FAILED! => {"changed": false, "failures": ["No package ipa-server available."], "msg": "Failed to install some of the specified packages", "rc": 1, "results": []}
https://github.com/freeipa/ansible-freeipa/blob/master/roles/ipaserver/tasks/install.yml#L5

@rjeffman is there a ipa-server package in rhel9?  Has it been renamed?  The certificate role uses this to get the ipa role used to install ipa: https://github.com/linux-system-roles/certificate/blob/master/tests/tasks/setup_ipa.yml#L12
do we need to use a newer version of this role on rhel9?

There is no IPA on rhel9 at this time.

[citest bad]
@jharuda @rjeffman there will be failures in the rhel-x tests - do we want to just ignore these for now?

there will be failures in the rhel-x tests - do we want to just ignore these for now?
By ignoring you mean to merge it for now, right? I think we can do it and expect failures for RHEL-x tests until there is the package in RHEL9.

I agree on merging this, an live with rhel-x failing while IPA packages are not ready (BTW, there were some nice improvements in the packages this week).


How to reproduce v1.13 behaviour with v2 in a BYO PKI scenario

Question
Hi I was starting to use cosign v1.13 in a bring your own PKI scenario.
And was able to sign and verify my images without any issue.
Then I've decided to move to v2 and obviously
$COSIGN verify --cert $SIGNATURE.pem --certificate-chain $CA.pem $REGISTRY$IMAGE
Does not work anymore (cf #2056 )
So my question is what I have to do to bring back the same behaviour in my context (no fulcio, no rekor).
I'm far from understanding all the things involved here but reading #2632 let le think my PKI is not 'fulcio like' and I need to wait for modifications regarding BYO PKI.

cosign verify --certificate-chain bundle.pem --certificate cert.pem  <IMAGE> is currently broken as noted in #2632. Also note that if the certificate you've provided doesn't conform to Fulcio's certificate profile, where an identity is included in it, the command will fail.
To work around this, you can do your own verification of the certificate using the chain and extract the public key to use with cosign verify --key key.pem <IMAGE>. You can use step's CLI https://smallstep.com/docs/step-cli/reference/certificate/key to do so.

Also note that if the certificate you've provided doesn't conform to Fulcio's certificate profile, where an identity is included in it, the command will fail.

And this will the case even when #2632 will be fixed?

Correct. With Cosign 2.0, we swung the pendulum more towards identity verification. We will need to think through how to do byo-pki without impacting the required checks for identity.

@Fassino I think what you're noticing is that the procedures for verifying in a BYO PKI setting and a "public Sigstore infra" setting are very different. The 2.0 release made the "public Sigstore infra" setting a lot nicer by default, but this wound up making BYO PKI worse.
At the moment, there's no easy way to rely on Subject Name; on my roadmap for the next couple months is to make this possible and a lot clearer.

I can across a similar behavior change with BYO PKI and wanted to note the changes I had to make.
Previously I was using the following invocation (where $IMAGETOSIGN is the reference to a given image by hash ):
$ COSIGN_EXPERIMENTAL=1 SIGSTORE_ROOT_FILE=./files/cas/fullchain.pem cosign verify --rekor-url="" $IMAGETOSIGN -a foo=bar

With 2.0.2 ( and main build as of yesterday ) that not longer works, so you have to change a few flags:
My signing certificate can be extracted with openssl ( don't need to use step ? )
$ openssl x509 -in ./files/code/DockerBuild.crt -pubkey -noout > pubkey.pem

Then the cosign invocation can become:
$ cosign verify --insecure-ignore-sct --insecure-ignore-tlog -a foo=bar --key pubkey.pem $IMAGETOSIGN
WARNING: Skipping tlog verification is an insecure practice that lacks of transparency and auditability verification for the signature.

Verification for index.docker.io/vertexproject/xxxx@sha256:xxx --
The following checks were performed on each of these signatures:
  - The specified annotations were verified.
  - The cosign claims were validated
  - The signatures were verified against the specified public key

[{"critical":{"identity":{"docker-reference":"index.docker.io/vertexproject/xxxx"},"image":{"docker-manifest-digest":"sha256:xxx"},"type":"cosign container image signature"},"optional":{"Subject":"","foo":"bar"}}]


feat(): added network select to the strategy popup

created a new Autoocmplete component

Fixes #1659
This needs to be merged to be able to test this PR properly. But you can still test the interactions.
https://github.com/snapshot-labs/snapshot-hub/pull/262

Looks great!

We should keep same dropdown element styling as in the other dropdowns.
There should be a placeholder when no network is selected
We should add a transition when the dropdown appears

@midgerate you can delete the components.d.ts file

The input is not same size as the others we have:

@mktcode it's matching the new shot inputs which are intended to be shorter hight for now because the label is above the input.

There are still errors, this should not be merged yet.

What errors? o.0

@mktcode @samuveth @bonustrack do we need to search by chain number?

@midgerate would be a good feature IMO

@midgerate @samuveth here it just searches the entire object it seems. But I don't think people gonna search by RPC node url. :D Name and chain ID sounds goood to me.

I can see the placeholder from the input behind the dropdown

Your change look great @mktcode

Please wait before merging this PR, we need to handle calculation on Score API

@bonustrack what is left to be done on scope API?

@midgerate I've done the change to take network in consideration, can you make sure everything is working as expected and merge this PR?

Okay @bonustrack

Tested on Rinkeby and Mainnet, everything seems to work well.

Tested with multiple networks together and it looks to be working.


Merge from upstream.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 31 committers have signed the CLA.:x: Neumann-A:x: cenit:x: cbezault:x: emptyVoid:x: eao197:x: chausner:x: JackBoosY:x: martinmoene:x: Cheney-W:x: mloskot:x: hkaiser:x: xgcssch:x: Helco:x: grdowns:x: doomtr666:x: huangqinjin:x: coryan:x: PhilLab:x: Kwizatz:x: myd7349:x: NNemec:x: driver1998:x: b-r-o-c-k:x: nunoplopes:x: NancyLi1013:x: PhoebeHui:x: wangli28:x: ewertons:x: GitMensch:x: SuperWig:x: tronicalYou have signed the CLA already but the status is still pending? Let us recheck it.


Feature Request: add support for auth0-lock authentication

Hi
I just implemented auth0-lock integration in my fork, to use in my latest app. This is the commit:
https://github.com/nexbit/aurelia-authentication/commit/17ed43a99ac4b514c2e6a024190cb38f35f8d147
It is a bit rough, and I don't know how to implement proper testing for this, but at least it works..
Key points:

It predates the oauthType config property, checking if it is equal to auth0-lock to use the auth0Lock.js provider. It's a bit hacky, but it'd be better if that property was named type like it used to be in the past..
It expects a global Auth0Lock class defined. One should load the lock-9.1.min.js script directly in index.html
It supports only the token responseType
Only tested in popup mode (speaking of lock options), probably not working in redirect mode, but it should be trivial to adjust

Let me know if anyone is interested in merging this, and what can be done to improve it (especially how to implement tests).
Thx
UPDATE: I changed the commit, the old one was wrong. The relevant files are only auth0Lock.js (added) and authentication.js (changed).

Re type: i only changed it to quickly copy changes from sahat. But you have a point with using type

Ok.. maybe we can reintroduce a new externalProvider config property,
and let the oauthType to be used only for existing oauth providers.
The externalProvider property should accept a string that is the name
used to register the provider class with the aurelia default DI
container. For example my auth0Lock provider could be moved to an
external plugin that simply register the class with the DI container,
and your code then loads it.
What do u think?
doktordirk wrote:

Re type: i only changed it to quickly copy changes from sahat. But you
have a point with using type
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SpoonX/aurelia-authentication/issues/146#issuecomment-222070959,
or mute the thread
https://github.com/notifications/unsubscribe/AEs96x0sKvC1CL2EU6HydUDiBKgzpynBks5qFpBJgaJpZM4IoBsa.

generally having better IoC there would have been nice indeed. for now, i think it's fine as you did it i think. mind throwing together a 'proper' PR? would be a great addition imho

What about testing? The PR would completely miss them if I open it now.. I don't know if the auth0 guys have some service mock ready to use, but now I don't have enough time to find or implement it in testing code.

alas we don't test the actual services right now anyways. so i guess just copy the oath2 test and adapt it to your needs

Resolved by https://github.com/SpoonX/aurelia-authentication/commit/f8aeef58108708707ffda06cd6c2ce78707adfd2


⚠ Bofrost.de has degraded performance

In d03be96, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2241 ms

Resolved: Bofrost.de performance has improved in 53e6f92 after 13 minutes.


MM-27941: Sends the root post create_at time to the API when replying.

Summary

Ticket Link

Related Pull Requests

https://github.com/mattermost/mattermost-server/pull/16219
https://github.com/mattermost/mattermost-redux/pull/1288

Screenshots

Closing this in favour of https://github.com/mattermost/mattermost-server/pull/16560.


Add dependencies takeback button

Add experimental takeback button to dependencies view.
It also depends on #920 because timestamp.js was not working.
Refs #791 #727

Is adding new interface acceptable?
Preview:

@t-yuki enhancing the interface is great! Only it's not clear to me what "take back" button means. Should it be just called "Run" or "Query" or "Execute"?

I changed the label to "Analyze Dependencies".
Also I added a missing file.
PTAL.

Can you paste another image?
So the endTs and lookback is the same concept here as in the span query (main screen). Can you verify the fields are named the same and look similar? (for continuity's sake across the screens). Hard to tell, and they may already be.
I'm quite excited as I was interested in being able to see dependencies from a period besides yesterday.
I wouldn't necessarily say "analyze dependencies" as not all stores will do that online, but it is a minor point and I don't know a better word either!
@jcarres-mdsol @eirslett @kristofa any thoughts?

It queries to /dependency?endTs=1234&startTs but no effect for server side.
Instead, dependency.js converts startTs to lookback and sends a query with that parameter.
However, error cases like startTs > endTs is not handled well. (it ignores startTs simply)
Screens here:

Thanks.
As far as I'm concerned, let's merge.
I did ping others, so will merge tomorrow unless feedback says otherwise.

1.31.0 is on the way with this


Eloquence treats parameter grouping query as subquery

Laravel support parameter grouping via a where method that takes exaktly 1 argument (a closure) : https://laravel.com/docs/7.x/queries#parameter-grouping
$users = DB::table('users')
           ->where('name', '=', 'John')
           ->where(function ($query) {
               $query->where('votes', '>', 100)
                     ->orWhere('title', '=', 'Admin');
           })
           ->get();

produces
select * from users where name = 'John' and (votes > 100 or title = 'Admin')

Subqueries are also supported with almost the same syntax. The only difference is that the where method takes a closure as the first argument and a value as a second argument.
$users = User::where(function ($query) {
    $query->select('type')
        ->from('membership')
        ->whereColumn('user_id', 'users.id')
        ->orderByDesc('start_date')
        ->limit(1);
}, 'Pro')->get();

Notice the "'Pro'" value on the last line.
Eloquence seems to interpret where(closure) as where(closure,null).
Im my case Eloquence changes the correct query:
select * from users where (name LIKE ?)

to the syntactically incorrect query
select * from users where (select * where name LIKE ?) is null

The php code to generate the query is:
$sql = static
            ::where(
                function ($query) use ($q) {
                    $query
                        ->where('name', 'LIKE', '%'.$q.'%');
                }
            )
            ->toSql();

I will try to troubleshoot this further.

Check out https://github.com/jarektkaczyk/hookable/pull/27, still waiting for it to be merged but it worked for me.

@jarektkaczyk :)

Oh, I'm facing the same problem.


Added support for the choose_sticker action.

Added support for the choose_sticker action in the method sendChatAction.
https://core.telegram.org/bots/api#november-5-2021

@awskt  great addition! please target your PR to develop branch.


update client URL to dynamically pull latest version

The current URL for the F@H client within the template is statically defined to use version 7.6.9.
This PR updates the URL to use a dynamic one, based on scraping of the download.js manifest from the FAH website, ensuring clients are always pulling the latest recommended version.

Apologies for the messy pull; I'm not editing on my usual machine.

Thanks for your PR! I'm thinking the template is already too fragile to support fetching the latest version. For example, the package is not installed conventionally with apt/dpkg. There are also no tests. Because of these reasons, I am reluctant to accept this PR. If there is more demand, then I will consider doing an AMI build and tests that should be more robust. Unfortunately, I believe the non-free NVidia packages would prevent sharing a pre-made AMI.

For what it's worth, I've been testing this for the last few days with no issues and will probably just maintain a forked version if it's not included in the mainline.
Feel free to close or merge, whatever you feel is best.


Custom tooltip breaking angularjs viewModel separation?

Hi!
First of all, let me just say I'm loving using this wonderful plugin. It' reduced our team development time tremendously. So, thanks!
Moving on, one of the most prominent aspects of any application in Angular is how DOM operations are dealt with in the view, mostly via directives, and the view logic is deferred to the controller.
In the app I'm currently developing, we make heavy use of charts. We've now reached the point where we're customizing the interface and our client has asked us for very specific tooltips.
The way angular-nvd3 implements this functionality is by passing a tooltip object in the config attribute.
In that object it's possible to specify a function which returns an html string which then gets added to the DOM. So, in essence, we're back to manipulating the DOM from the controller. Doesn't this go against 'the Angular way' of doing things? Or am I missing something here?
Here's a concrete problem our team came across:

What would be the best strategy to create a reusable tooltip component, rather than having to redefine the HTML string in every controller?

Obviously one could use the  <script> directive and create a template in the corresponding view, but then that defeats the point as you'd have to define that template in every view that would use a tooltip. Refactoring that template to the index.html screams bad structure to me. We're left with isolating the template in it's own file which seems like the best option, however, since that file never gets loaded and included in the DOM tree, we have to remember to manually load it into the $templateCache so we can then access it in the controller.
Regardless of whichever option you choose, it's always necessary to $compile the template against the current scope as there's no ng-include (or similar directive) to do that for you. As per 'the Angular way', compiling - meaning DOM manipulation - should be done in directives rather than the controller but since this tooltip template is dynamically injected into the DOM rather than statically defined, there's really no way to do this in a directive (or is there?).
So, to sum up, rather than receiving a function which generates an HTML string, shouldn't this property be a templateURL instead? I understand this is an nvd3 problem because that's the way they expose a custom tooltip, but for this particular scenario, it doesn't work well with Angular, so perhaps some compilation is necessary for similar properties?
Lastly, am I overcomplicating things?

Hi, @tiansivive. I have been running into problems trying to minify my application scripts (I keep getting the unexpected token: < error), and I believe it's due to having html strings in these custom tooltip functions in the various chart configs. Did you employ a strategy to get around this? Thanks!

Sorry about the late reply @bennettatoms
I didn't have any such issues with the html strings, or with the minification process. And I can't really think of an issue on why minifying should be an issue. Perhaps you had some escaped char sequence by mistake? On the other way, may sure the html is properly sanitized.
I'll leave my approach here just in case:
        var templateUrl = $sce.getTrustedResourceUrl('modules/core/components/tooltip.nvd3.component.tmpl.html');
        var elem = null;
        var $tmplChildScope = $scope.$new(false);
        $templateRequest(templateUrl).then(function(template) {
            elem = $compile(template)($tmplChildScope);
        }, function() {
            // An error has occurred
        });

That's it! Just fetch the sanitized template, instantiate a new $scope, and compile the html against that new scope.

@tiansivive Could you post your entire contentGenerator function in the tooltip object? I am curious what you have the contentGenerator function return since in your example the elem is a jQuery object.

If I was more ambitious I would look into using multi-slot transclusion to allow for tootip, title, etc be defined as so
  <nvd3 options="$ctrl.options" data="$ctrl.data" config="$ctrl.config" >
    <nvd3-title>
      <!-- -->
    </nvd3-title>
    <nvd3-tooltip>
      <!-- -->
    </nvd3-tooltip>
  </nvd3>

@manbearwiz Sure. I removed the details as they were irrelevant to this discussion, but left the overall structure
function contentGenerator(data){

	if(data.point){
		//process data

		//and then update $scope variables
		$tmplChildScope.var = something;
	}

	/*don't forget to $digest as since we're doing the compilation manually,
	Angular won't know the $tmplChildScope values changed and
	won't update the view accordingly*/
	$tmplChildScope.$digest();

	if(elem !== null) return elem.html(); //return the elem's html
}

Basically, any html returned from the contentGenerator gets appended to the DOM. Before that happens, we want to compile the template so we can use ng directives and bind models to the view. Because our template isn't part of the DOM we manually tell angular to $compile when the appropriate controller gets instantiated. From there, we just have to guarantee that whenever the contentGenerator gets fired, we update the $scope and tell Angular it has been updated. Angular then sorts everything out and all we need is the resulting html.
Regarding your transclusion suggestion, I think it's certainly possible to do something like that, and, imo, make code more maintainable however, I think that would involve a major overhaul of this plugin.
To be fair, I originally came across this issue for a work project but I've since quit my job and haven't had the need of using nvd3 or angular-nvd3 again, so I might be remembering things wrong and such a solution could be easily added.


Update Sylius docs page broken link in README.md

I'm closing, as the correct link has been squashed and merged in #23


conformance-e2e: Add test case for experimental LB control-plane

This adds a test case to the matrix to run conformance tests with the experimental control-plane (pkg/loadbalancer/experimental).

/ci-e2e-upgrade

/ci-e2e-upgrade


Scroll on summaries and full screen search are bad

When something happens be it details of summary expanding or keyboard expanding page scrolls down by which point you lose the beginning of content in favor of end. The full screen search experience is fairly broken on mobile.

We will close this issue by inactivity, fell free to reopen it.

The bad scroll when page expands still happens. I'm unclear what my problems with full screen search were.

I can't reopen it myself.

Hi @janat08 ,
I will reopen it. But I can't help so much because I didn't understand the issue itself. Can you show more about it? Can you provide a codepen?
At least a codepen, to catch the code and wrong behaviour.

Expand summary/details. The page will scroll to bottom of the details. It’s not the desired behavior, as people read from the top and not bottom. https://github.com/beercss/beercss/blob/main/docs/EXPANSION.md

If there’s a fix to scroll behavior, I assume that i wanted it to apply to full screen search for when the results list gets rerendered by htmx.

I think this is a behavior of browser, we don't have any code to scroll it to up/down, <summary>/<details> are just CSS/HTML. Maybe you can add a JS on summary?
<summary onclick="window.scrollTo(0, 0);">...</summary>

Or you can set a no-scroll helper on container <body class="no-scroll"> or <main class="no-scroll"> to prevent scroll.

Ok then I suppose there’s reason they want you to see bottom so as to not miss it. Must be a no fix.


License Violation

The code in this repository is a modified version of the code found in the PaperMC/website repository. As per the license file found in the original repository, you are required to keep all original copyright notices.

We follow the same license
https://github.com/LeavesMC/Website/blob/main/LICENSE

You do follow the same license, but you have removed the original copyright attributions to PaperMC.

You do follow the same license, but you have removed the original copyright attributions to PaperMC.

Sorry, I will deal with this soon.


(Un)selectable text

Is there a means to make the text selectable, for copy/pasting purposes?

Which text?

Anything in any of the columns.

There is a copy button just for that


GH4000 timestamp

We are testing a brand new Teltonika GH4000 but the datetime is wrong. The packet is decoded as a future date. In fact, one year is added and a month is substracted. Is it possible to use the traccar software with a GH4000 device ?

Sorry, I erased the beggining. Here is the complete line in the log file:
2015-02-09 15:55:21 DEBUG: [5027 <- X.X.X.X] - HEX:<PHONE_NUMBER>000157070a50f8cc0d0b5f421e42ae404de346006e6b00001001015702dc00000035e9090e250150f8cc0d0b5f421e42ae404de346006e6b00001001015702dc00000035e9090e250150f8cc0d0b5f421e42ae404de346006e6b00001001015702dc00000035e9090e250150f8cc0d0b5f421e42ae404de346006e6b00001001015702dc00000035e9090e250150f8cc0d0b5f421e42ae404de346006e6b00001001015702dc00000035e9090e250150f8cc0d0b5f421e42ae404de346006e6b00001001015702dc00000035e9090e250150f8cc0d0b5f421e42ae404de346006e6b00001001015702dc00000035e9090e250150f8cc0d0b5f421e42ae404de346006e6b00001001015702dc00000035e9090e250150f8cc0d0b5f421e42ae404de346006e6b00001001015702dc00000035e9090e250150f8cc0d0b5f421e42ae404de346006e6b00001001015702dc00000035e9090e25010a00004def

I have documentation for GH3000, but not for GH4000. So, I guess there might be some differences in the format. GH3000 sends time in seconds since 2007.01.01 00:00. When I apply that logic to messages from your device I get 2016 year.

I asked to Teltonika for the GH4000 documentation. I'm waiting the anwer. When I get it, I will send it to you.
By now, I only get his from the GH4000 user guides:
"Factory set time (2008.01.01) is used until device gets first fix. Device gets time information (UTC (GMT0) from satellites when it is placed under clear sky)."

Finally Teltonika send me the new Firmware. I think that the issue is not solved. The device is getting stuck when GPS is not available: keeps last hour valid GPS position but future date. The device sends positions with same future datetime and position until GPS signal is recovered. Maybe this is kind of warning for the AVL service to know that positions are not updated .
This can be fixed in database. So, for me, this issue can be closed.

I guess the easiest solution is to filter positions with invalid time when we insert them into the database, but the problem then would be when we get into year 2016 and the time would be valid.

Hi @ all - is this issue already fixed/solved??

It seemed to be a Teltonika issue, so it's better to contact them and clarify if it's fixed.

Yes, thank you very much.


neovim-remote: move from python-packages to /neovim/neovim-remote.

Motivation for this change
As noted on #22405, neovim-remote doesn't belong in python-packages.  I'm not positive that it belongs under /neovim/, but that makes the most sense to me.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

While you're at it, could you add the meta section?

By the way, if you have Python PR's, feel free to cc me.


Assigning 'FriendlyName' to imported certificate

I've noticed the imported certificate can only be identified because it is Issued to: "localhost" and has Friendly Name: <None>.  To fix, add this line to the generated "importcert.ps1":
(Get-ChildItem -Path Cert:\LocalMachine$_$($result.Thumbprint)).FriendlyName = "CosmosDBEmulatorCertificate"
Alternatively, maybe a 'Friendly Name' could be placed in the certificate itself (not sure if this is possible).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 109ed3f8-faf1-92b9-bf50-4be52e9099d4
Version Independent ID: ebc5326a-46da-6bc1-1f47-01a8e16d11fb
Content: Develop locally with the Azure Cosmos Emulator
Content Source: articles/cosmos-db/local-emulator.md
Service: cosmos-db
GitHub Login: @deborahc
Microsoft Alias: dech

@pwl-kdk Thanks for your comment. We are actively investigating and will get back to you shortly.

@pwl-kdk Thank you for the detailed feedback.
This is being assigned to the content author to evaluate and update as appropriate.

@pwl-kdk the certificate already has a friendly name by default, you are probably using an older version of the emulator. I see the name by default.

@pwl-kdk Further update, not sure if my response above solves the problem, you are probably referring the friendly name within the tool itself. I shared this issue with the dev who works on the emulator, and he mentioned that he plans to apply the change in the emulator’s code with the next release.
We will close this issue if there aren't further questions.

#please-close

Thank you @SnehaGunda .  Glad to hear it is being passed on.


Remove/Delete Engagement

Add an option to the Engagement Scene to Remove/Delete the Engagement.
This should only be available when the Project/Engagement is In Development.

Would be nice if this was backed by a canDelete field from our API. I'll raise this in Slack.

@CarsonF Where did we land on adding the canDelete field before doing this? I saw you and Michael had a brief discussion on Slack, but it didn't seem like a decision was reached.

Working in conjunction with https://github.com/SeedCompany/cord-api-v3/issues/1526

Working in conjunction with https://github.com/SeedCompany/cord-api-v3/issues/1526

@CarsonF the deleteEngagement mutation is working for both language and intern types and ready for a UI button.
@michaelmarshall FYI..

@CarsonF the deleteEngagement mutation is working for both language and intern types and ready for a UI button.
@michaelmarshall FYI..

Yeah I think this was more so for the canDelete boolean property, so we know whether to show or hide the UI button.

Yeah I think this was more so for the canDelete boolean property, so we know whether to show or hide the UI button.

@CarsonF I've confirmed that we can get a canDelete engagement property on a project's readOne.

@CarsonF I've confirmed that we can get a canDelete engagement property on a project's readOne.


Git diff view is wrong.

VSCode Version: 1.14.0
OS Version: macOS 10.12.5

This is what I have in VSCode:

And this is in SourceTree:

What I got in VSCode is wrong.
I reported this problem when running 1.11.2 in https://github.com/Microsoft/vscode/issues/25274. Now seems it's back.

Is this with Git as SCM provider?

Can you scroll all the way down? I believe Code is showing you those changes further down.


/_oauth is a 403 error screen

after a successful google login I am redirected back to my app where the page throws a 403 error

2019/11/11 05:45:46 [error] 11159#11159: *308 lua entry thread aborted: runtime error: /usr/local/openresty/nginx/access.lua:65: attempt to index upvalue 'domain' (a nil value)
This error is being thrown when I add a resolver <IP_ADDRESS> to the config

https://github.com/cloudflare/nginx-google-oauth/pull/52 should fix the "upvalue domain" error.


Add declarative example

Add declarative example:
Object {
    flex = {
        flex_direction = "row",
        flex_wrap = "wrap",
        justify_content = "center",
        align_items = "center",
        align_content = "center",
    },
    w = 400,
    h = 100,
    align = lvgl.ALIGN.CENTER,

    -- Button with label, inside a container
    Object {
        w = 150,
        h = lvgl.PCT(80),
        bg_color = "#aa0",

        Button {
            Label {
                text = string.format("BUTTON %d", 1),
                align = lvgl.ALIGN.CENTER
            }
        }:center()
    }:clear_flag(lvgl.FLAG.SCROLLABLE),

    -- Label inside a container
    Object({
        w = 150,
        h = lvgl.PCT(80),
        Label {
            text = string.format("label %d", 2)
        }:center()
    }):clear_flag(lvgl.FLAG.SCROLLABLE)
}

Really impressive! Just one thing which bothers me: how does the user know that flex_direction is inside a flex? It makes sense, but as it doesn't mimic LVGL's C API basically everything needs to be documented.
Or am I missing something?

flex_direction is inside a flex?

It doesn't need to be.
It's one of the several optimizations made in luavgl to group the parameters related together, like the align we mentioned before. Use the LVGL's C API style will also work.
It certainly does need documentation https://github.com/XuNeo/luavgl/blob/master/src/lvgl.lua

I see, very nice!


Improved bundle validation

Added full fhir schema validation to fhir bundle.
Added additional DM property checks
Several card tests currently failing because the '02 data has multiple Observations without short references.

If tests fail because the examples are not conformant to the spec, then we should change the them to ignore the specific failures and report it to have the examples updated.


This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access

i follow the readme:
batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.
error: failed to fetch some objects from 'https://github.com/ChmaraX/forensix.git/info/lfs'

is there a way to get the ML model or create it myself?

You can clone repository without the model and just pull docker images (./install.sh) from dockerhub with the model already in it.


Support for Govee Bluetooth Meat Thermometer (H5182, H5183)?

I've loved this plugin for my H5072 & H5075 thermometer's.
Any chance of it working with the bluetooth meat thermometer's? I just purchased a one of each of the following. One for my smoker and one for my pool. I'd be thrilled it I could get them connected to homebridge like my other Govee devices.

@jimiamoore If your H5182 / H5183 doesn't work out of the box, in all likelihood some changes to the plugin are required.
Great place to start is to follow the steps I provided here for a request to add support for H5101: https://github.com/asednev/homebridge-plugin-govee/issues/10#issuecomment-751133143
If you can provide raw payloads from your H5182 / H5183 sensors, I would be happy to expand the support for them.


Modernize and cleanup cookbook

Description
Describe what this change achieves
Issues Resolved
List any existing issues this PR resolves
Check List

[ ] All tests pass. See TESTING.md for details.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

          1 Warning

:warning:
This is a big Pull Request.

  Generated by :no_entry_sign: Danger

I'm going to make a PR in actionshub/chef-delivery so we can install any dependent gems for running rspec. That should fix the delivery check error.


tRNA modification levels

trm7 delta
2′-O-methylcytidine level in tRNA ~reduced~ abolished/ Cm
2′-O-methylguanosine level in tRNA ~reduced~ abolished / Gm
1-methylguanosine level increased /m1G increased
normal  pseudouridine    level in tRNA
7-methylguanosine in tRNA reduced/ m7G  reduced
N2- methylguanosine in tRNA reduced / m2G  reduced
....that was a learning curve...

trm732
2′-O-methylguanosine level in tRNA normal/ Gm
7-methylguanosine in tRNA normal / m7G
N2- methylguanosine in tRNA rnormal / m2G
note to self (as above)
2′-O-methylcytidine level in tRNA reduced/ Cm reduced
1-methylguanosine level increased /m1G increased
normal pseudouridine level in tRNA

trm734
2′-O-methylcytidine level in tRNA norma/ Cm
note to self (as above)
2′-O-methylguanosine level in tRNA reduced abolished / Gm
1-methylguanosine level increased /m1G increased
normal pseudouridine level in tRNA
7-methylguanosine in tRNA reduced/ m7G reduced
N2- methylguanosine in tRNA reduced / m2G reduced

PMID:25404562

one more
decreased wybutosine formation (yW)

We have done almost all phenotypes for modified residues in tRNA as normal/increased/decreased etc. modification process phenotypes (the exception is queuosine, which a bit of an oddball but maybe should be changed to match the rest).
So I'll do these as process phenotypes too, for consistency (also, "abolished level" makes no sense). They can have "x level in tRNA" phrases as related synonyms.
Can you check this list to make sure it's complete? It can be a bit challenging to make sure I've cribbed everything from all the comments; a single comprehensive list is easier to use.
abolished tRNA cytosine 2'-O-methylation (additional synonym: abolished tRNA 2'-O-methylcytidine formation, and similar for the rest)
abolished tRNA guanosine 2'-O-methylation
increased tRNA guanosine 1-methylation (add'l syn: N1-methylation)	GO:0002939
normal tRNA pseudouridylation	GO:0031119
decreased tRNA guanosine 7-methylation	GO:0106004
decreased tRNA guanosine N2-methylation	GO:0002940
normal tRNA guanosine 2'-O-methylation
normal tRNA guanosine 7-methylation
normal tRNA guanosine N2-methylation
decreased wybutosine biosynthesis	GO:0031591

I think that's all of them but I don't see them in canto yet?

normal tRNA pseudouridylation FYPO:0007017
normal tRNA guanosine 2'-O-methylation FYPO:0007018
normal tRNA guanosine 7-methylation FYPO:0007019
normal tRNA guanosine N2-methylation FYPO:0007020
abolished tRNA cytosine 2'-O-methylation FYPO:0007021
abolished tRNA guanosine 2'-O-methylation FYPO:0007022
increased tRNA guanosine 1-methylation FYPO:0007023
decreased tRNA guanosine 7-methylation FYPO:0007024
decreased tRNA guanosine N2-methylation FYPO:0007025
decreased tRNA wybutosine biosynthesis FYPO:0007026
edit file: 4f3372764e0e885ec97cf4417808e8d47a70623e
release: b433bc3c036054f6a8b57b3e72e865df4d60549b

but I don't see them in canto yet?

I always include the above information (term names & IDs, and the github links) when new terms go in. If you don't see new FYPO IDs in a ticket, you won't see the terms in Canto because they haven't actually been added yet. This has been true for as long as FYPO has existed.


Problem: signature in mac bundle is not correct

Solution:

codesign after all the modifications

Sweet thanks!

Good catch. I added nuke-refs afterward and forgot to test this again on a mac.


Add restful api routing group selector

Description
Add RESTful API method of selecting routing group
Allows user to set a RESTful API endpoint that would return routing group.

Additional context and related issues
https://trinodb.slack.com/archives/C059KUNPTSP/p1720619490704499

Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
* Added RESTful API method for selecting a routing group. Users can now set a RESTful API endpoint that returns a routing group.

Took a quick look at the flow. This seems to follow the model, where rules identify the right group, and then the router finds the right Trino cluster within that group. @willmostly can verify it further!

Also, I was wondering if you have bandwidth; then, is it possible to refactor the Rules logic into its interface and modules, which
could be configured via the config file? Similar to what I did for the router. I estimate it be a few days of effort.

@vishalya can you explain more on what you mean by Rules logic?

Rebased and ready for PR! PTAL :)

@vishalya can you elabore more on what you meant by refactor the Rules logic into its interface and modules ? is this different than what onestar is planning at https://github.com/trinodb/trino-gateway/issues/409 ?
i don't mind refactoring, but i think that should go onto other PR so can you check this one first?

We just allow configuration of URL and what info is sent to the external service and what we expect as the result. I think it make more sense to call the other rules type something like EXTERNAL or EXTERNAL_SERVICE

I see your point. Routing logic does not come with the package Trino Gateway, so a separating word makes it more clearer to user.
How about file name to ExternalRoutingGroupSelector and rulesType to EXTERNAL? Don't really think we need to have service there as you know it's a service :)
I'll make changes to EXTERNAL on docs too.

External sounds good @Chaho12

I don't think we should use "blacklist" to represent disallowed headers. The keyword isn't recommended in many software projects, e.g. https://developers.google.com/style/word-list#blacklist & https://www.splunk.com/en_us/blog/learn/blacklist-whitelist-inclusivity.html


User created site on MSU Commons and was not automatically made admin

Kristen Mapes created https://introdh2022.commons.msu.edu/ and was unable to edit it. On investigation I found her user ID did not pick up admin status. Her role was listed as "none"

This appears to be related to the update to WP 6. Closing.


Enable more clippy lints for automated code review

https://rust-lang.github.io/rust-clippy/master/index.html#/import?groups=cargo,complexity,correctness,deprecated,nursery,pedantic,perf,restriction,style,suspicious

Let me introduce you to a comprehensive list of optional clippy lints :P
However, I dislike the fact that optional lints used to pollute source files. Starting from 1.74.0 there is a way to specify them in Cargo.toml, we should use that.


How do I access state.data on signinCallback.

If I want to put the url being accessed in state while the user is being sent to the OIDC provider I think I could do this.
      auth.signinRedirect({
        state: '/some/relative/url',
      })

I can see this is stored as data under the stateStorage. But when the Callback comes back I can't seem to find a way to intercept it. The onSigninCallback only gets the User object. What am I missing.

This state will be part of the User you get when all is done.
See here: https://authts.github.io/oidc-client-ts/classes/User.html#state

Talk about missing the obvious, thanks.


Add schema for resource manager

https://docs.cloud.oracle.com/en-us/iaas/Content/ResourceManager/Concepts/terraformconfigresourcemanager.htm

completed in #6


Feature: add socket io support

Add SocketIO support #611
Now is a simple implement , more feature will be append soon.
Pick up some function to separate file, please check it.
By the way, i have not found a public socketio server as a default value, is any good idea to improve it?

Hey @moonrailgun,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 999f8110-5de6-11ea-8706-0d65ca3fb05e

@moonrailgun https://amritb.github.io/socketio-client-tool/ fyi this open source tool is feature rich!

Hey @moonrailgun,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: c8f12800-5e00-11ea-8706-0d65ca3fb05e


chore(main): release 3.0.2

:robot: I have created a release beep boop
3.0.2 (2024-08-14)
Bug Fixes

documentation: Update documentation to reference resource group (#500) (2b25373)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v3.0.2
:sunflower:


Support of Outscale providers

Hello Rancher team,
At Outscale, we have implemented a node driver in order to create clusters from Rancher.

Docker plugin
Ui plugin

We now would like to go one step further and make that driver available rancher natively.
Could you explain to us the process to make this possible ?
Thank you,
Best regards,
Maxime

Up

The main PR to rancher/rancher got merged to release/v2.6 before we branched release/v2.7 off it, so the changes are in branches for both the next 2.6.x and 2.7.0 release.
@outscale-mdr , merged your PR and moved this issue to test. Since your team is handling testing, could you or anyone from your team please test it on v2.6-head Docker image and confirm it's working as expected (you have the driver available to be enabled and once enabled it works)?

Hello @snasovich,
I just get back to work today. Sorry for the delay.
Thank you for the update, I will test it and will confirm you that it is working.

Hello,
Do I need to do something for the dashboard ? Like pushing our logo here ?
Best regards,
Maxime

I confirm that the plugin works in the v2.6.9-rc2

Hi Maxime @outscale-mdr , thanks for confirmation. Does this mean this issue can be closed ^?
thanks.

@sowmyav27 The changes are in both rancher 2.6-head and 2.7. @outscale-mdr confirmed it works in v2.6.9-rc2. I think that's good enough to close. If they have any issues on 2.7, they can reach out

Thanks to all the team ! I'm closing this issue.


In Android Studio, When target is recognized as an android_binary,  what the bazel-plugin do to build command and android_binary()?

Because when target is an android_binary, the built apk works fine, but when target is aar, when the aar imported into an android project, the generated apk don't work normally .

Hello @wingdi, Could you please elaborate your query with complete details and minimal steps to reproduce it. Thanks!

Hi there! Thank you for raising this issue. We're doing a clean up of old issues and will be closing this one since it seems to have stalled. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.


page_service doesn't handle messages split across TCP packets correctly

I noticed while reading the code that FeMessage::parse function consumes the bytes it reads from the buffer, even if the whole message is not present. That causes trouble if the message is split across multiple TCP packets. To reproduce, I created a proxy that forwards the data one byte at a time, i.e. each byte is sent as separate TCP packet:
# start pageserver, listening on port 64000
./target/debug/pageserver -l <IP_ADDRESS>:64000

# in another terminal, create proxy:
socat -b1 TCP-LISTEN:64002,reuseaddr TCP:localhost:64000

# connect with psql:
psql -p 64002 -h localhost

# pageserver panics:
thread 'tokio-runtime-worker' panicked at 'cannot advance past `remaining`: 80 <= 8', /home/heikki/.cargo/registry/src/github.com-1ecc6299db9ec823/bytes-1.0.1/src/bytes_mut.rs:953:9

If you replace -b1 above with a higher number, it works.

Can this be handled with a BufReader?

Fixed by commit 3b9e7fc5e6715a694b27e059ee7eedd1f6f44735

Can this be handled with a BufReader?

BufReader only changes the performance characteristics of the underlying std::io::Read I believe, so no. I used a BufReader anyway though, for the performance reasons, and for symmetry with the output side of the stream which already used BufWriter. But this got fixed by the other refctorings in 3b9e7fc5e6715a694b27e059ee7eedd1f6f44735


Add integration tests for Horizon

take into account that running the integration tests for horizon takes a while:
Ran 68 tests in 2742.159s
So Im not sure if we have some kind of time limit on the test runner that would kill the CI job if it goes over X minutes. In that case, it should be changed to account for this tests I guess.

Travis doesn't like your formatting :) But from my side
+1

Fix indentation problem

One test requires network with name public .So i suggest add following command also to setup .
neutron net-create public
neutron subnet-create public <IP_ADDRESS>/24 --name ext-ne
Maybe subnet is no needed.


return-undefined false positive

Bug Report

TSLint version: 5.3.0
TypeScript version: 2.3.3
Running TSLint via: CLI

TypeScript code being linted
export function t(p: (a: any) => any): void {}
t((a) => { return undefined; });

with tslint.json configuration:
{
  "rules": {
    "return-undefined": { "severity": "error" }
  }
}

Actual behavior
ERROR: ...: `void` function should use `return;`, not `return undefined;`.

Expected behavior
No error, as the function parameter is typed as returning any - not void.
Prior to updating to the latest version of TSLint, the configuration did not see an error effected. No error is effected if 5.2.0 is used.

looks like a direct result of #2731. notice the test baseline that got changed: https://github.com/palantir/tslint/pull/2731/files#diff-bd90f0718fe7a8725e9db572ef333339R36
can you provide a bit more context around the code your'e trying to lint here? should it really be typed any?
... either way, this behavior is kind of surprising, so we should probably revert that part of the rule change @andy-hanson

@adidahiya Sure. The typings aren't mine and any is reasonably appropriate for the usage.
It's a transactionUpdate parameter in the Firebase JavaScript client:
transaction (
  transactionUpdate : (a : any ) => any ,
  onComplete ? : (a : Error | null , b : boolean ,
  c : firebase.database.DataSnapshot | null
) => any , applyLocally ? : boolean ) : firebase.Promise < any > ;

I need to implement that interface in a mock.

@adidahiya And the code the fails the linting is the test for the mock:
return mockRef
    .transaction((value) => {

        return undefined;
    })
    .then(({ committed, snapshot }) => {

Firebase transactions return undefined if nothing is updated.

Seeing as though this is a breaking change, is it going to be considered a bug? Or should I implement the trivial workaround that'll be required if this is indeed how you want the rule to work?

I consider it a bug. Will label it as such.


feat: Add create pure and kill pure transaction for version > 0.9.30

In polkadot v0.9.30 some transactions had their name changed:

anonymous became createPure
killAnonymous became killPure

This PR add those 2 transactions to txwrapper-substrate without deleting the anonymous ones, a future PR should handle this.

Thanks for your review, i modified it :)


Update C++ ISO3DFD readme file

Restructured the readme to match new template, rewrote several sections for clarity, and shortened the DevCloud information to make it more concise.
Existing Sample Changes
Description
Restructured the readme to match new template, rewrote several sections for clarity, and shortened the DevCloud information to make it more concise.
Fixes Issue#
External Dependencies
N/A
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[x] Documentation

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Command Line
[x] VSCode

@ishaghosh27 please review.
@IgorOchocki and @jimmytwei added for notifications.


Problem Overview
In Amphion/bins/svc/inference.py, acoustics_dir is not assigned a value and is set to None. Is this correct? Because while debugging inference.py, I found that due to acoustics_dir being None, an error occurs at line 192 in Amphion/models/svc/base/svc_dataset.py: ``spk2id_path = os.path.join(args.acoustics_dir, cfg.preprocess.spk2id). The error message is TypeError: expected str, bytes, or os.PathLike object, not NoneType.
Steps Taken
Amphion/bins/svc/inference.py:
   parser.add_argument(
        "--acoustics_dir",
        type=str,
        help="Acoustics model checkpoint directory. If a directory is given, "
        "search for the latest checkpoint dir in the directory. If a specific "
        "checkpoint dir is given, directly load the checkpoint.",

)

Screenshots

Hi @mysxs, did you specify the --infer_expt_dir when inference? You can refer to this part as the instruction.

Hi @RMSnow ,thank your apply,OK I fixed this issue and a new problem appeared: when I run the inference, an error is reported, and it is written in Amphion/models/base/new_inference.py that it says ckpt_list = [ckpt for ckpt in Path(vocoder_dir).glob("*.pt")] that need a .pt file, but I use Hifi-Gan, It doesn't have a .pt file, there are many .bin files, which .bin file should I specify?

Hi @mysxs !
You may refer to issue 105 for the checkpoint loading problem.
We are going to provide an official update to solve this issue later. Before that, you could use our pretrained BigVGAN vocoder if you don't want to implement your inference code.
You may find quick reference guides from our hugging face pages svc and vocoder.
If you have any other problem, feel free to contact us!

Hi Adorable-Qin~ I have resolved the issue. Thank you for your response.

Glad to hear that!
We will close this issue. Feel free to re-open it once you have other questions!


Rename exported assets to a descriptive name

Currently this is an issue with Megascans, and I recall Quixel mentioning that they cant give the textures descriptive names due to how they index the file names. It would be extremely helpful to mitigate this when exporting to Painter by either using the name given in Bridge, or coming up with some other naming scheme. As it is, importing several textures will create extremely unreadable filenames in the Shelf.

Yeah i can look into this and see if i can come up with a better naming scheme or extract somehow the bridge display name for the textures

@MackenzieShirk i've tried to implement this in the plugin but the current JS API of Substance Painter uses the file path as the display name for imported assets so the only way to implement this kind of feature would be to duplicate the assets in the file system rename them using the configured naming scheme of Bridge and then import them into Painter, this method is far from ideal since it will require write and read access of the file system and thus causing not permitted errors


Added timber logs

Timber gives us a better way to log errors or debug statements over the default logging utility. In the PR, the library has been configured in such a way that for debug builds all the logs will be printed to the logcat and for the release builds only statements logged with the priority ERROR will be sent to Crashlytics. It is important to send only a limited number of logs to Crashlytics as it remembers only the last eight reports.
A general rule of thumb that I followed is the exceptions that might occur due to backend response and our logic should be reported so that we can update or fix such things. And exceptions such as IOExceptions (during disk IO) or NetworkExceptions can be ignored as this is something that is dependent on runtime and cannot be handled by us.
Critical exceptions are logged with ERROR
Exceptions that are critical but not needed to send to Crashlytics are logged with priority WARN.
Exceptions of least priority are just logged as DEBUG.
Logs are sent to firebase as expected

Good work on the code comments!

This PR also fixes https://github.com/microsoft/rural-crowdsourcing-toolkit/issues/115


SAMD5x/E5x PACs missing register field TC.CTRLA.DMAOS

Another SVD mismatch with the reference manual.
Pretty much what it says on the tin. The DMAOS field of the CTRLA register for TC peripherals is not present in the SVD files for all processors in the SAMD5x/E5x family, but is present in the Reference Manual. All possible TC mode configurations (COUNT8, COUNT16, COUNT32) in the associated PACs are missing this field.

Is this fixed with the new svds?


ALPN filter incorrectly applies to non-Istio TLS traffic

Bug Description
setup:

ssl terminating on istio gateway
backend app listens on https with istio sidecar injected
destination rule has tls mode as SIMPLE

curl accessing gateway's https port:

with 1.13.x

works

with 1.14.x

fails with upstream connect error or disconnect/reset before headers. reset reason: connection termination error
works - when mTLS is disabled in peer authentication
works - when istio sidecar isnt injected to the app

Version
$ istioctl version
client version: 1.14.1
istiod version: 1.13.5
istiod version: 1.14.1
data plane version: 1.14.1 (1 proxies)

$ k version --short
Client Version: v1.23.5
Server Version: v1.21.11
WARNING: version difference between client (1.23) and server (1.21) exceeds the supported minor version skew of +/-1

Additional Information
a very basic golang server is used to reproduce the problem
how to reproduce:

install istio 1.13 and 1.14 as canary revision
install istioctl (1.13.x or 1.14.x) on local and make it available in PATH to deploy gateway
clone git@github.com:deepakdeore2004/istio-bug-1-14.git and change directory to k8
./run.sh, provide istio revision to deploy gw and app with istio sidecar
curl -k https://gateway-lb
delete the namespace and repeat same test with another revision

in 1.14, disabling mTLS with peer authentication OR removing istio sidecar from the app works fine
alpn has some difference with the version
1.13:

1.14:

tcpdump is installed on app pod so kubectl sniff can be used like this:
k sniff -n test-1-13-5-20220827 test-http-server-8080-and-8443-746f8679f5-d6sgl

Looks this is expected, I cannot recalll what cause this diff between 1.13 and 1.14. @howardjohn @ramaraochavali do you know what has changed

I think I know what happens, its not what I expected originally.. and I am also pretty sure its broken in 1.13 as well.
Basically Istio inserts the istio.alpn filter for HTTP traffic into the HCM. The purpose of this is to dynamically set the ALPN from things like h2 -> istio-h2, http/1.1->istio-http/1.1, etc. On the server side, we detect these istio-x variants to identify if its mTLS. We need the istio-http ones (vs just istio) to distinguish HTTP vs TCP for auto sniffed protocols - in theory we could still sniff after we terminate TLS, but the Envoy config model doesn't really support that, so we need the client to tell us what protocol it is.
The problem arises when we aren't sending mTLS, we still apply the ALPN filter. This is unavoidable in the current implementation, since its applied at the HCM level (shared), but we need to enable/disable on a per-cluster basis.
The 1.14 regression was just making this broken for gateway -> sidecar as well; it was always broken for sidecars.

Possible options:

Make the ALPN filter more expressive to allow selectively disabling (or apply to cluster directly somehow)
Stop with the istio-httpX stuff and just pick one of them (say istio-http/1.1). We never actually distinguish between the 3 version variants - always match on all of them together. With this, we can just drop the filter entirely and set the ALPN directly in the cluster, I believe (not validated whether this will work). One downside is we would be "lying" and always declaring http/1.1 (or always h2), when we are not actually using those protocols
something else?

@briansonnenberg is going to work on this but I cannot assign them since they are not in Istio org yet

The real solution is using HBONE for Istio TLS. Custom ALPN is a true abuse and unlikely to receive support from upstream Envoy. It needs to be deprecated.
A workaround for per-cluster selection is to use StreamInfo::clusterInfo() in the filter to adjust its behavior. That will break with filters that change routes, but might help temporarily.

HBONE will only solve this once non-HBONE mTLS is entirely removed, IIUC. Which is likely to be years from now due to our backwards compatibility requirements

@howardjohn we have fairly short support window and Istio is the only data plane that uses these ALPNs. I think we need to start accepting HBONE traffic ASAP, and then take deprecation cycle to stop sending on HBONE traffic, but that doesn't seem to be anything special.

@costinm for thoughts. I really don't dig a deeper hole for the ALPNs hacks if we can avoid it.

We have almost never broken data plane version skew compatibility historically. Even today we still upgrade users directly from Istio 1.4 to Istio 1.15 and have those proxies communicate.

If we truly want compatibility then unfortunately we can't fix bug or any other data plane either :) Whoever runs 1.4 proxy is already taking massive amount of risks with public CVEs.

1.4 is just an example. Even if we have the strictest interpretation of backwards compat and only support skew between supported versions, we will still have mTLS around for at least a year. I suspect we will end up needing a longer period of time though, since HBONE will not be stable on initial merge. So we have at minimum ~6 months to HBONE as a requirement + 1 year to deprecate mTLS most likely.
Bug fixing is largely not an issue on version skew. The shared protocol between two proxies is fairly small - TLS with a shared root, and our ALPN hack. Maybe MX if we also want to make sure telemetry works as well. The version skew support is not around ensuring the behavior of an individual proxy is identical between versions (which is a far higher bar), just that 2 proxies can communicate

I'm not suggesting to drop to the support for old ALPN hack before the regular deprecation cycle. But this bug could be avoided by using a tunnel, so if we support that as an option, it seems like a no-brainer to invest into that rather than fixing the old path. We'd have to run dual protocols in any case, and there's no problem listening for both on the sidecars.

I don't see how it can be avoided by introducing HBONE without dropping old mTLS. The issue is the config is at the HCM level, and the HCM is shared by ~everything, so the filter must be present which will lead to overwriting the ALPN.
I think it will actually impact HBONE as well - we will be using our ALPN hacks in HBONE because we cannot selectively enable/disable it at a cluster level.

The effort should be on supporting HBONE. If it takes changes to istio_alpn filter to opt-out, then that should be the work. There are many things that need to happen for HBONE besides that.

Ok, well I think it turns out the changes need to support HBONE and to fix this bug are the same, so I think that makes everyone happy.

@howardjohn this needs fix or can be closed?

Needs a fix
On Sun, Jan 1, 2023, 6:53 PM Deepak Deore @.***> wrote:

@howardjohn https://github.com/howardjohn this needs fix or can be
closed?
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/40680#issuecomment-1368618619, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXO57GKELPPQTSNLT73WQI7KXANCNFSM57XSNYFA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I've put together a Design Doc for fixing this: https://docs.google.com/document/d/1T8NvwK2hnRjU-LWWtZ_Wk6kIVkeZqYEcP_LQ3dEkO-8/edit?usp=sharing. Hopefully we can discuss at the next WG meeting

Despite recent changes in istio-proxy and istiod, I am still able to reproduce this issue. I also noticed that this issue can be reproduced in Istio 1.13 when STRICT PeerAuthention is enabled. To fix it, it's necessary to disable mTLS on app's TLS port. What's more, disabling mTLS with and without global STRICT PeerAuthentication solves the issue in Istio 1.18.
version | resources                                | TLS handshake
------- + ---------------------------------------- + --------------
1.13    | Gateway (SIMPLE)                         | succeeds
        | DestinationRule (SIMPLE)                 |
------- + ---------------------------------------- + --------------
1.18    | Gateway (SIMPLE)                         | fails
        | DestinationRule (SIMPLE)                 |
------- + ---------------------------------------- + --------------
1.13    | Gateway (SIMPLE)                         | fails
1.18    | DestinationRule (SIMPLE)                 |
        | PeerAuthentication (STRICT/istio-system) |
------- + ---------------------------------------- + --------------
1.13    | Gateway (SIMPLE)                         | succeeds
1.18    | DestinationRule (SIMPLE)                 |
        | PeerAuthentication (STRICT/istio-system) |
        | PeerAuthentication (DISABLE/app selector)|
------- + ---------------------------------------- + --------------

Taking the above into account, I wonder if we really need those recent changes in istio.alpn filter, because it seems to me that disabling PeerAuthentication solves the problem and has the same limitations - no peer metadata exchange. And if disabling alpn filter does not fix TLS handshake when STRICT PeerAuthentication is enabled, does this change still make sense?
cc: @ksubrmnn @keithmattix @howardjohn

Hmm this tells me that the Envoy PeerAuthentication implementation makes an assumption that mTLS == Istio mTLS which IMO is a faulty assumption. What I think should happen is that PeerAuthentication mtls == STRICT should make the target services have require_client_certificate set to true.

STRICT mTLS means it must be Istio mutual TLS. In your case 3, its not Istio mutual TLS -- its 'application level' TLS and is correctly rejected.

If STRICT mTLS is only Istio mutual TLS, then we need to update our public-facing docs and type comments because I don't see that anywhere: https://istio.io/latest/docs/reference/config/security/peer_authentication/

STRICT does not equal istio mtls

I am a bit confused ... maybe terminology issue. Let me be more explicit.
First the docs. They say "Connection is an mTLS tunnel" which is a bit ambiguous but does clearly rule out "SIMPLE" TLS.
Next is implementation. Strict will check a incoming connecting is TLS and has a valid SPIFFE mesh certificate. The only variance from "Istio mutual" TLS is that I don't think it enforced the ALPN.

They say "Connection is an mTLS tunnel" which is a bit ambiguous but does clearly rule out "SIMPLE" TLS.

Agreed - I'm realizing now I misunderstood the implications of @jewertow's experiment. SIMPLE TLS should, in fact, be blocked by an mTLS STRICT PeerAuthentication. However, I do think that my message is correct in form if not in function. More on that below:

Strict will check a incoming connecting is TLS and has a valid SPIFFE mesh certificate

This is the disconnect. The API for PA states is all about mTLS specifically, meaning a client cert must be presented. This diverges from @jewertow's original experiments, but If DestinationRule MUTUAL is set (vs. ISTIO_MUTUAL), then a STRICT PA should not block the traffic.

I feel quite confident that the correct behavior is to verify as I specified. It is both logically correct (if not that verification... what are you verifying?) and the existing behavior since Istio inception.
The doc is misleading because we mostly interchangablely use mTLS to mean "Istio mTLS" incorrectly, and generally intermix application layer and mesh transport layer everywhere. But it's a doc issues not behavioral.

I mean if they set MUTUAL and then present an Istio mesh certificate sure.. but then that is really "Istio mTLS" done manually; doesn't change the actual behavior on the server side

I think we need to update the inboundStrictFilterChainMatchOptions,. As with a DR specify simple or MTLS mode, we will not override alpn now. So the inbound alpn is ["http/1.1", "h2c"], so we could not match ["istio-http/1.0", "istio-http/1.1", "istio-h2"]

@howardjohn fair enough re: the docs. My position is based on my reading of the docs only, so I'll defer to you on the history and intent. We should definitely correct the docs though.

I think we need to update the inboundStrictFilterChainMatchOptions,. As with a DR specify simple or MTLS mode, we will not override alpn now. So the inbound alpn is ["http/1.1", "h2c"], so we could not match ["istio-http/1.0", "istio-http/1.1", "istio-h2"]

https://github.com/dubbo-go-pixiu/dubbo-go-pixiu/blob/53014058bac52d74fd98ba94a0a8b0e2c2b92c3e/pilot/pkg/networking/core/v1alpha3/filterchain_options.go#L127 it already is the istio- ones

But we donot do alpn overwrite now, so it cannot match the filterchain.

We do the ALPN overwrite - the change was only to not do it for non-ISTIO_MUTUAL. It doesn't make sense to set the ALPN overwrite for SIMPLE since it's not mTLS?

When I enabled debug logs in ingress gateway, I noticed override with 3 ALPNs even though the cluster had istio.alpn_override: false, so I think current implementation of skipping ALPN override is not correct. I submitted a fix: https://github.com/istio/proxy/pull/4865.

Is there a summary for why Istio needs to have a fork of mTLS for its mesh transport? It's really not ideal and seems to be a historic artifact that we should be working to eliminate, instead of promoting further. HBONE would get us there quickly, but it's been multiple years waiting for it, so we should probably not expect it to happen soon, and make incremental changes. From what I remember:

istio-metadataexchange ALPN is metadata exchange ALPN. We can get rid of it with WDS in the upcoming version.
istio-h2, etc: is this about sniffing on the client? Envoy can sniff on the server now, so not sure why we can't sniff twice.

Anything else?

Can you explain what you mean by a "fork" of mTLS?

By that I mean that we need to distinguish between any mTLS and "istio mTLS" - that's by definition a new protocol based of mTLS. A client speaking regular mTLS (e.g. gRPC) cannot access the sidecar directly. The fact that we define new non-standard ALPN tokens  (not present in https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml#alpn-protocol-ids) means Istio requires a sidecar to be in the mesh.

Technically we don't check the ALPN in STRICT mode so you can use it in that case.

Anything else?

A major purpose is distinguishing "application TLS" from "mesh TLS".

A major purpose is distinguishing "application TLS" from "mesh TLS".

So the only reason is because we cannot sniff istio-enabled vs application TLS in "permissive mode" on the server? why isn't auto-mTLS solving this?

A major purpose is distinguishing "application TLS" from "mesh TLS".

So the only reason is because we cannot sniff istio-enabled vs application TLS in "permissive mode" on the server? why isn't auto-mTLS solving this?

That only works if the clients are in the mesh and have auto-mTLS activated (it can be "not activated" by turning it off globally, a DISABLE DR, or not going through an in-scope Service (direct to pod, exportTo, sidecar scope, etc)).

When I enabled debug logs in ingress gateway, I noticed override with 3 ALPNs even though the cluster had istio.alpn_override: false, so I think current implementation of skipping ALPN override is not correct. I submitted a fix: istio/proxy#4865.

which istio version has this fix?

I think this landed in 1.19


[rv_dm,dv] The test sequences for rv_dm are full of hex constants

Description
It's a bit hard to get at the history properly here, but DMI operations all seem to be specified with magic hex constants instead of using the structures that are available through dm_pkg.
To get a list of examples, run git grep "'h" hw/ip/rv_dm/dv/. There are a couple of false positives, but I estimate 30 cases that aren't.

Tagging as being part of the M4 milestone because I'm not really convinced the existing code gives much confidence in the block. I have a strong suspicion that the magic constants were extracted from wave dumps. Getting to the bottom of this might also flush out some other strange assumptions.

I've just spent a bit of time hunting down hex constants(!) and filing PRs to get rid of them. I believe this will be done once #24134 and #24135 are merged.

Now both of those PRs are merged, I believe this is resolved.


new install and setup page

Description (required)
This PR is in advance prep for sidebar reorg PR #8239 and attempts to provide more a more complete picture of "getting started" with a new project (without being overly long or overwhelming). The intention is to set users up for success on this one page, vs needing to click several pages before they are actually working successfully on their project.
It rewrites the Auto Install page to include:

manual installation, as well as installation starting from a theme (as before this was misleading since you can't do it AFTER installing Astro)
very quick explanation of how to get started and work in dev mode, including the dev toolbar
quick mention of build/preview/deploy so that people can very early on, before they mess up a blank project too much, ensure that they have a working foundation
calls attention to the section that WILL be removed from the sidebar re: configuration (e.g. TypeScript, Editor Config etc.) as a next step. These items will now be easier to see, and recommended up front as "setup" immediately after "install"

This PR separates out the new content from the sidebar nav changes that will happen later.
Notably, this does NOT perform all the housekeeping tasks like deleting the manual install page, moving anything out of the sidebar that is now mentioned on this page etc. It's just to keep the "big" sidebar PR to minimum content changes!

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
install/auto.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Thank you @rgilsimoes ! You've identified some areas that could be improved for sure! I am taking some of these suggestions and there's one I'll have to think a little harder about, since I think it probably needs a bit more of a rewrite!  🙌


Feature: WINEPREFIX

Hey,
plugins work great, thank you. :heart:
It would be really cool to be able to define a WINEPREFIX per each link. So, most probably, we'd need:

setenv("WINEPREFIX", blah_blah"); to appear before this execl,

a third column in ~/.config/airwave/airwave.conf (nb. what happens now if I put a = in dll/so name?),

a third column in the graphical configuration app.

I did this today for abique/vstbridge, but that seems a lot easier. Maybe it's not… :cat: Please, please, when you get a chance…

The feature is implemented in the new version (1.0.0).

Great, thank you. :heart:


Added Implementation of queue and stack using linked list

Fixes #[Add issue number here."First steps for issues #IssueNumber]
Language: [Add here in what language you have implemented this data structure or algorithm.]

there are two basic problems with the code. It is not modular and not properly indented, fix and would be happy to merge. Thanks :)

Indent the code then again make a PR.


Auto Updater

Is your feature request related to a problem?
It is not related to a problem, I just like having the latest updated build, and I run my server on a command line install. So, it is difficult to update.
Describe the solution you'd like.
Add an option in the config file to update to the latest jar on server reboot. If this were added, I would officially swap to Purpur from PaperMC. I have an automated script created that will auto update paper.
Describe alternatives you've considered.
I have tried using serverjars from serverjars.com, but it causes multiple Java syntax errors and frequent crashes.
Agreements
Please agree to the following.

[Yes ] I have searched for and ensured there isn't already an open issue regarding this.
[ Yes] I have ensured the feature I'm requesting isn't already in the latest supported Purpur build.

Other
Add any other context or screenshots about the feature request below.

Please fill out the proper template.

Sorry, first time opening an issue. It's fixed.

Auto updating is a very dangerous practice, but you can use Purpur's download API to get the latest version https://purpur.pl3x.net/api/v1/purpur/1.17/latest/download

I am aware of the issues involved with auto updating, I was just wondering if you could create an optional way to do so.

We will not create an option for this, but you can update your script to download from the link I specified above.

Ok, thanks!


Iar toolchain and tests

First version of tests and improved toolchain for IAR's toolchain

@JonatanAntoni Is there somebody that can review this?


Make Your Own Dinokiki link should be different - Nav

Make Your Own Dinokiki link at the navigation should be different or have a detail indicating that it will open in a new tab.
_
O link Make Your Own Dinokiki deveria ser diferente ou ter um detalhe indicando que vai abrir em uma nova guia.

I think it should be like that.


Method on toggling helper for existing toggles

Hi, really appreciate the plugin!
I think there's one method missing from the toggling helper, which is a sort of method that can trigger existing entry points one to one (the simplest one, probably). Basically nvim-treesitter-context and nvim-treesitter-refactor come with these for example.
vim.keymap.set("n", "yot", "<cmd>TSContextToggle<cr>", { desc = "toggle context" })
vim.keymap.set("n", "]ot", "<cmd>TSContextEnable<cr>", { desc = "enable context" })
vim.keymap.set("n", "[ot", "<cmd>TSContextDisable<cr>", { desc = "disable context" })
-- ... same for `TSBufToggle refactor.highlight_definitions` etc

should become
require'impairative'.toggling {
    enable = '[o',
    disable = ']o',
    toggle = 'yo',
}
:toggle(
  key = "t",
  name = "tscontext",
  enable = "<cmd>TSContextEnable<cr>",
  disable = function() vim.cmd("TSContextDisable") end,
  toggle = "<cmd>TSContextToggle<cr>",
)

Note though that:

Rather than :toggle, I prefer to name it :manual (since toggling is the name of the helper object, and this new method is not the main way to use it. "manual" better conveys the meaning)
It won't use the <cmd>Command<cr> syntax - just Command (because this is what :command_pair does)

Other than that - good suggestion!

Awesome, thanks 👍🏻


Pass the AbsoluteUri to Process.Start rather than the URI

Pass a string to Process.Start so that it compiles

OPS Build status updates of commit ed8e856:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/sdk/rendering-cards/net-wpf/actions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Double import/export labels

Which version of Skybrud.Umbraco.Redirects.Import are you using? (Please write the exact version, example: 4.0.1)
4.0.1
Which version of Skybrud.Umbraco.Redirects are you using? (Please write the exact version, example: 4.0.15)
4.0.18
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
12.3.3
Bug description
I have migrated a project from Umbraco 8 > 10 > 12.
Now installed redirects package:
<PackageReference Include="Skybrud.Umbraco.Redirects" Version="4.0.18" />
<PackageReference Include="Skybrud.Umbraco.Redirects.Import" Version="4.0.1" />

But I am seeing double import/export labels here:

Hi @bjarnef
This is an issue introduced in 12.3 - you can read a bit more about why this is now happening here: https://github.com/umbraco/Umbraco-CMS/commit/cb4d8e34ce9e2b124a2b1c74b4a4309ae456d64f#commitcomment-134362951
I'll keep an eye on if Mads makes a reply, or what the best approach to fix this is. Problem is that I'm specifying both a label and a label key, which now means that both are shown. If not fixed in Umbraco, I could just remove the label from my code.

Hi @abjerner
Okay, makes sense.. I will check the changes made as it used to work with label and label-key - in fact I think the label acted as fallback in case a localization didn't exist for a specific language/culture.

I can see my PR to fix this in Umbraco was closed, although it may have been automatically/accidentally closed since the branch that the PR targeted was deleted.
So it might be easier just to fix this directly the this package - hence a81661a90f881ddd7622006dc91bdc5ac260ddd6
I hope to push this over the weekend as part of the v4.0.2 release 😉


Operations

Fixes #41  and starts to approach #42
Added base functionality for performing operations and some basic operations.  Still needs documentation and examples.

Coverage increased (+0.09%) to 97.613% when pulling 936ce6a8330628abcc2c5568378f0d3e8438eaa8 on operations into 57ee22c44ad58db5501309d774141babf149fad4 on master.


Manual: Document include/exclude examples for backup and and restore

This issue is about adding examples for --exclude and --include to the manual for the backup and restore commands.
Information is currently hidden in the following issues:
https://github.com/restic/restic/issues/373
https://github.com/restic/restic/issues/226
https://github.com/restic/restic/pull/231
https://github.com/restic/restic/issues/1016
https://github.com/restic/restic/issues/1005

I'm going to try to produce something for this today.

@fd0 Is it possible to get this assigned? Just want to make sure work isn't duplicated for Hacktoberfest?

Hm, I cannot assign people from outside the restic org, but it's yours. Can you please hold off a little bit, until #1300 is merged? Thanks!

These exclude-file comments were really helpful, thanks!  A couple of additional questions that might be worth including:

Can you have multiple --exclude-files?  restic help backup says it can be specified multiple times, the docs say "specify [exclude patterns] with multiple --exclude‘s or one `--exclude-file" (emphasis added)
What's the format of the exclude file?  A filter on each line?  Are comments allowed?

Yes, you can specify --exclude-file multiple times, the results will be merged into one big list of excludes.
One filter pattern per line, when the line starts with # it's a comment.

The section in the manual should also mention CACHEDIR.TAG and link to http://www.brynosaurus.com/cachedir/

How about the attached patch? I think it covers all the major points, much of the wording is copied from your comments in the bug-reports.
more-examples.diff.txt

Would you mind submitting a pull request? :)

Sure, see #1499. HTH. I have read over CONTRIBUTING and I think I have done the necessary. If I missed something please tell me.
Merry christmas, BTW. ;-)

Thanks! :)


iOS build improvements, plugin part

Related to PR: https://github.com/LeastAuthority/destiny/pull/216
@ewanas Please check and merge on top of your changes or we can directly merge to ios-build branch

Changes already incorporated.


[REVIEW] Pradumnasaraf

GitHub Profile Link
https://github.com/Pradumnasaraf

GitHub Profile Link
https://github.com/Pradumnasaraf

hey there thanks for summiting an issue

the hi I am Pradumna Saraf is not  very much visible in dark mode i would recommend using blue color

the android text is not visible in light mode but visible in dark

your profile looks cool

GitHub Profile Link
https://github.com/Pradumnasaraf

hey there thanks for summiting an issue

the hi I am Pradumna Saraf is not  very much visible in dark mode I would recommend using blue color

the android text is not visible in light mode but visible in dark

your profile looks cool

Appreciate Your feedback

Reviewed on live stream https://www.youtube.com/watch?v=xsZIKzE7gy8
Looks great, some thoughts

SVG at the top is blank
contribution graph looks well balanced

Reviewed on live stream https://www.youtube.com/watch?v=xsZIKzE7gy8
Looks great, some thoughts

SVG at the top is blank
contribution graph looks well balanced

Thank You :)


CARDS-2242: Optimize the unsubmitted forms restriction for faster execution

To test:

start in proms mode
as admin, create two patients each with a visit set for later today (fill in the names as well)
as admin, fill in the forms for one patient; the forms should not appear as submitted
as the other patient, fill in and submit the surveys
as admin, create a new user and add it to the Trusted group
log in as the new user
check that on the regular dashboard you can see the submitted forms for one user, and only the meta-forms for the other one (patient info, visit info, survey events)
check that on the clinic dashboard you can see both visits in the Appointments table, and only the submitted forms in the other tables, including the patient name

tested post merge - all good!


Fix gmail STARTTLS port

gmail uses port 587 for STARTTLS: https://support.google.com/mail/answer/7126229

Thanks, rebased to master in 7699ed3fc8a5ff4ba3e2b936c85e7008ed72d508.


RFM - dropit.install

I DON'T Want To Become The Maintainer

[x] I have followed the Package Triage Process and I do NOT want to become maintainer of the package;
[x] There is no existing open maintainer request for this package;

Checklist

[x] Issue title starts with 'RFM - '

Existing Package Details

Package URL: https://chocolatey.org/packages/dropit.install
Package source URL: https://github.com/dtgm/chocolatey-packages/tree/master/automatic/dropit.install/

Date the maintainer was contacted (in YYYY-MM-DD): 2021-12-13
How the maintainer was contacted: email

Closing due to the following comment.
Only the meta-package should be opened as an RFM request unless there are different maintainers for the install/portable package.


Request: User-to-Admin message system plugin

Hi guys :) I came here to suggest you a plugin where users can easily talk with the server admins in order to ask questions or report players with a simple command like /uta . The admin group read the message sent to them and then they can talk to them in private. Is this possible? Thanks.

I am sure it is possible. But this is not really the place for plug-in suggestions. That would be here: https://rocketmod.net/viewforum.php?f=9


Fix SemVer

[main/WARN]: Mod snowdrift (${version}) does not respect SemVer - comparison support is limited.

Fixed in 1.2.1~

Fixed in 1.2.1~


⚠ Samsung has degraded performance

In dcb79fb, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2702 ms

Resolved: Samsung performance has improved in a5bcfff.


Reproduce the Crashing app after Tauri upgrade

waiting for tauri upgrade #324
the crash might be related to production build only


typo: resources/resource-manager/Microsoft.Features

registerd -> registered

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-js

Automation for azure-sdk-for-python

Automation for azure-sdk-for-node

Automation for azure-sdk-for-go


Could we use histogram matching and threshold cutting to normalize all the data before segmentation?

Just question about the appearance transformer.
As shown in the paper, the intensity variance of brain T1 MR images seems to be caused by no histogram matching. Could traditional pre-processing overcomes the mentioned appearance variance, especially of brain MR image? What kind of specific appearance variance could the appearance transformer solve?
Best,
Dongming

@Barnonewdm,
Yes, you could try to do some intensity normalization preprocessing, and depending on the data, this may indeed work. In this case, (if it works on all data, including test data), the appearance transform might not be necessary. However, in several problems we've tackled in the past, especially on noisier, highly variable clinical data acquisitions, appearance normalization via methods like histogram matching tended to fail, so we wanted a method that does not require this normalization done a priori.
In brainstorm, note that the appearance transformer does not need to be perfectly accurate -- instead, because of the way we regularize it smoothly, the transformer simply needs to approximate an appearance transform that characterizes the type of appearance present in this image, so that our method can synthesize a similar image with accurate label.
Hope this helps!

@adalca
Could it be interpreted as the appearance transformer actually copes with style transfer instead of the noise removment？This style variance exits even on the same midality (T1, brain) due to the highly variant data acquisitions. The exact style transfer is unable to be easily normalized by histogram matching?

@Barnonewdm yes, exactly!


Not accepting Authorization Header

Hello,
we are running a Kong 1.5 with this kong-oidc plugin. For Auth we are running a Keycloak Service.
Normal requests with a browser are working perfectly. The first time to an Ingress the user gets redirected to the login page, after login the user can use the service.
Now we want to be able to send Requests using an API/cUrl. Therefore I retrieve a JWT and send it using the following command:
curl -H 'Accept: application/json' -H "Authorization: Bearer $TOKEN" https://api.host.com/echo/ -i -L
As a result, I get redirected to the auth endpoint, which in turn asks me to login:
HTTP/2 302
date: Fri, 14 Feb 2020 12:07:50 GMT
content-type: text/html
content-length: 110
location: https://auth.host.com/auth/realms/users/protocol/openid-connect/auth?response_type=code&client_id=users-kong&state=3ee1c1c1eba001c0a4793113a4b7b39a&redirect_uri=https%3A%2F%2Fapi.host.com%2Fecho&nonce=9d5087eeaa15f81c10eb20db096c6091&scope=openid
set-cookie: session=dDSJcboEzlvDJz82MILWzw..|1581685670|bEP7I5rj-OV-Cqoyo7ahHeM_C2ftnIMVg_zZW1wvJDaYdDunXH-Uvv1OofDpBvPIMXETW2zsMvUsYOqHI2hWpvOIB4ALS2LVcdu4vUL4NzBPXJG9-NH0cGby8XfR8aOwqjK1gSOjrYUmUJyjrIFp_EHCBprtoB7b1q_zqkvZFNfj3xFrzQwIMcapar-moIbBb_nyBtsbvm_zdgXidp1dOQ..|btsKjY78zs8rmbcJ95xZGqDPi-U.; Path=/; SameSite=Lax; Secure; HttpOnly
cache-control: no-cache, no-store, max-age=0
x-kong-response-latency: 31
server: kong/1.5.0

HTTP/2 200
content-type: text/html;charset=utf-8
content-length: 3929
cache-control: no-store, must-revalidate, max-age=0
set-cookie: AUTH_SESSION_ID=8d5e1b68-3855-4510-bcbd-68f65145ed9f.keycloak-0; Version=1; Path=/auth/realms/users/; Secure; HttpOnly
set-cookie: KC_RESTART=eyJhbGciOiJIUzI1NiIsInR5cCIgOiAiSldUIiwia2lkIiA6ICI3MmQ4MjI1Ny1hNjU3LTRkY2QtYjE4Yy02MmYzNDAwN2I0MWMifQ.eyJjaWQiOiJ1c2Vycy1rb25nIiwicHR5Ijoib3BlbmlkLWNvbm5lY3QiLCJydXJpIjoiaHR0cHM6Ly9hcGkucmFwaXRhZy5jb20vZWNobyIsImFjdCI6IkFVVEhFTlRJQ0FURSIsIm5vdGVzIjp7InNjb3BlIjoib3BlbmlkIiwiaXNzIjoiaHR0cHM6Ly9hdXRoLnJhcGl0YWcuY29tL2F1dGgvcmVhbG1zL3VzZXJzIiwicmVzcG9uc2VfdHlwZSI6ImNvZGUiLCJyZWRpcmVjdF91cmkiOiJodHRwczovL2FwaS5yYXBpdGFnLmNvbS9lY2hvIiwic3RhdGUiOiIzZWUxYzFjMWViYTAwMWMwYTQ3OTMxMTNhNGI3YjM5YSIsIm5vbmNlIjoiOWQ1MDg3ZWVhYTE1ZjgxYzEwZWIyMGRiMDk2YzYwOTEifX0.8FLhVsK7FD3gZpKfGJcRnD4hnUN2p7wxwCQtO9Wr3NE; Version=1; Path=/auth/realms/users/; Secure; HttpOnly
x-xss-protection: 1; mode=block
x-frame-options: SAMEORIGIN
content-security-policy: frame-src 'self'; frame-ancestors 'self'; object-src 'none';
date: Fri, 14 Feb 2020 12:07:50 GMT
x-robots-tag: none
strict-transport-security: max-age=31536000; includeSubDomains
x-content-type-options: nosniff
content-language: en
x-kong-upstream-latency: 8
x-kong-proxy-latency: 0
via: kong/1.5.0

<html of login page>

We defined the introspection_endpoint which is was expecting to solve the problem, though nothing changed.
Can you help me? What am I doing wrong?
Thanks a lot!

I think I've seen something similar.
Out of interest, does it work for other javascript based clients?
Here's an example of a node version, just input your token and url.
`var https = require('follow-redirects').https;
var fs = require('fs');
var options = {
'method': 'GET',
'hostname': 'XXXXXX',
'path': '/XXXX',
'headers': {
'Content-Type': 'application/json',
'Authorization': 'Bearer TOKEN'
},
'maxRedirects': 20
};
var req = https.request(options, function (res) {
var chunks = [];
res.on("data", function (chunk) {
chunks.push(chunk);
});
res.on("end", function (chunk) {
var body = Buffer.concat(chunks);
console.log(body.toString());
});
res.on("error", function (error) {
console.error(error);
});
});
var postData = JSON.stringify({});
req.write(postData);
req.end();`

We were able to fix the problem. The issue was, that the introspection endpoint wasn't set correct. I was expecting, that the value for introspect was taken from the .well_known configuration, which it does not.

@BaloMueller I am facing the same problem, would be possible you detail the solution ?, how can I set correctly the  introspection_endpoint ?.

I set the following properties:
introspection_endpoint: https:///auth/realms//protocol/openid-connect/token/introspect
introspection_endpoint_auth_method: client_secret_post


Search curation on gene symbol

G2P-263

The current search returns the following format:
{
            "id": "G2P03531",
            "gene": "ATM",
            "genotype": "monoallelic_autosomal",
            "disease": "ATM-related cancer",
            "panel": [
                "Cancer"
            ]
        }

For the draft, you should also return:
"genotype": "monoallelic_autosomal"
"disease": "ATM-related cancer"

The current search returns the following format:
{
            "id": "G2P03531",
            "gene": "ATM",
            "genotype": "monoallelic_autosomal",
            "disease": "ATM-related cancer",
            "panel": [
                "Cancer"
            ]
        }

For the draft, you should also return:
"genotype": "monoallelic_autosomal"
"disease": "ATM-related cancer"
"panel": [
                "Cancer"
            ]

It now returns this
{
            "id": "G2P03823",
            "gene": "TAC3",
            "date_created": "2024-08-08T14:08:26.046997Z",
            "date_last_updated": "2024-08-08T14:08:26.046997Z",
            "curator_first": null,
            "curator_last_name": null,
            "json_data": {
                "genotype": "",
                "disease": "",
                "panel": [
                    "Eye disorders",
                    "Skin disorders",
                    "Skeletal disorders"
                ]
            },
            "curator_email": "[dlemos@ebi.ac.uk](mailto:dlemos@ebi.ac.uk)"
        },
}

Let me know if you want me to add or remove stuff

The endpoint works as expected. I only have a comment about the key json_data, this is not necessary.

okay do you want me to return it like this instead
"genotype": "",
  "disease": "",
   "panel": [
                    "Eye disorders",
                    "Skin disorders",
                    "Skeletal disorders"
                ]

The endpoint works as expected. I only have a comment about the key json_data, this is not necessary.

okay do you want me to return it like this instead
"genotype": "",
  "disease": "",
   "panel": [
                    "Eye disorders",
                    "Skin disorders",
                    "Skeletal disorders"
                ]

Updated it to this
{
            "id": "G2P03825",
            "gene": "TAC3",
            "date_created": "2024-08-09T09:24:31.517463Z",
            "date_last_updated": "2024-08-09T09:24:31.517463Z",
            "curator_first": null,
            "curator_last_name": null,
            "genotype": "",
            "disease_name": "MPI-related congenital disorder of glycosylation, type ib",
            "panels": [
                "Cancer disorders",
                "Skeletal disorders"
            ],
            "curator_email": "[dlemos@ebi.ac.uk](mailto:dlemos@ebi.ac.uk)"
  },

Thanks for the update. It looks good!


The color of lualine theme is different from the screenshot

This is screenshot in README

This is my local looks, the background colors of lualine are different from above.

Lualine needs you to specify theme, have you done that? Colors can be different, because lualine is simply not setted to use catppuccin

Lualine will detecte the colorscheme by using g:colors_name automatically
Although I specify the theme manually, it is still different from the screenshot
I noticed that the code here does not set the correct color

Screenshot of README used feline not lualine.

Will be good if lualine colors change to make different from tokyonight colorscheme

Will be good if lualine colors change to make different from tokyonight colorscheme

Agreed. Why have Lualine integration when the theme doesn't apply the colours?

@gmcmillan82 What do you mean? The current lualine colors are already from the catppuccin integration, not tokyonight (though might looks similar), while you can still configure the colors manually like this config.

Yeah my bad, I know they look similar. I just expected the lualine theme to closer resemble the main catppuccin theme, as currently it feels like it's from a different theme altogether.

Maybe:

Customize the lualine highlights in your own config like I mentioned before
Create a new issue asking for a change / make it a PR by yourself, though this might be for long as it will be a breaking change that changes many users' Neovim appearance
Try other statusline plugins like feline.nvim and heirline.nvim so that it will be even easier to manually define highlights

On the other hand, @mrbeardad I guess that this issue can be closed as there're no more things unsolved under the title of this issue?

Feel free to op-open if you have other issues :heart: