Updates outdated dependencies.

A few dependencies are left outdated. Other packages (e.g. Angular2
beta) have exact peer dependencies encoded in their package.json files.

We are going to have one error or another. For example, if you upgrade es6-shim to 0.35.0, the dependency is now up to date, but you will get the following error with npm install.
<EMAIL_ADDRESS>/Users/jm/Projects/github.com/jarrettmeyer/angular2-npm-starter
└── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

I suppose the question is: Which error would you rather have?

I would rather have the unmet error. That way we have the latest dependencies. It doesn't break any code so we are good. Merging this in. Thanks!


[SMALLFIX] Read entire buffer in buffered instreams

Fixes a bug where the buffer would not be read from if the read goes exactly to the end of the buffer.

LGTM, should those new fixes/improvements go into master or branch-1.1 ?

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10309/Failed Tests: 2org.alluxio:alluxio-core-client: 2alluxio.client.block.BufferedBlockInStreamTest.bulkReadTestalluxio.client.block.BufferedBlockInStreamTest.singleByteReadTest
Test FAILed.

the code LGTM. please fix the tests

@ifcharming I think we will continue to pull changes from 1.1 to master, and I think this fix should be included if a patch release is made.
@apc999 updated, thanks.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10310/
Test PASSed.

Merged build finished. Test PASSed.

LGTM

LGTM


Slight improvement in the default 'ALT-C', 'CTRL-T' & compgen functions.

[x] I have read through the manual page (man fzf)

[x] I have the latest version of fzf

[x] I have searched through the existing issues

Info

Category

[ ] fzf binary

[ ] fzf-tmux script

[x] Key bindings

[x] Completion

[ ] Vim

[ ] Neovim

[ ] Etc.

Shell

[x] bash

[x] zsh

[x] fish

Problem / Steps to reproduce
While messing around and customizing my fzf I saw that the default bash compgen_dir & compgen_path functions are using sed to remove the leading './':
https://github.com/junegunn/fzf/blob/7c40a424c0bf5a8967816d51ead6a71a334f30bb/shell/completion.bash#L28
https://github.com/junegunn/fzf/blob/7c40a424c0bf5a8967816d51ead6a71a334f30bb/shell/completion.bash#L20
Whereas the default 'ATL_C' command is using cut:
https://github.com/junegunn/fzf/blob/7c40a424c0bf5a8967816d51ead6a71a334f30bb/shell/key-bindings.bash#L7
While not a big issue per se, the cut approach is probably faster and I'd suggest to also include it in the compgen functions.
P.S. Looking through the files for the other shells, I also saw inconsistent use of sed:
https://github.com/junegunn/fzf/blob/7c40a424c0bf5a8967816d51ead6a71a334f30bb/shell/completion.zsh#L20
https://github.com/junegunn/fzf/blob/7c40a424c0bf5a8967816d51ead6a71a334f30bb/shell/completion.zsh#L28
https://github.com/junegunn/fzf/blob/7c40a424c0bf5a8967816d51ead6a71a334f30bb/shell/key-bindings.fish#L17
https://github.com/junegunn/fzf/blob/7c40a424c0bf5a8967816d51ead6a71a334f30bb/shell/key-bindings.fish#L67

Thanks for the suggestion.
The two commands are not identical. sed only removes ./ while cut removes any two characters.
# sed here removes `./`
ls **<tab>

# Each line of find output starts with /tmp, so sed does nothing
ls /tmp/**<tab>

My bad, didn't pay enough attention, to actually properly test this and see why it was using sed in the first place.
At least I bothered checking the other shells key-bindings, so my issue was not a complete waste of everybody's time.


Drop improvement

Improvement on event handling, no more event when the drop is not open to avoid useless process on the other on the page
Add new props to set the same width for the drop than the button
add little task to create a js file not minified to test in local with link
fix a little miss variable where the number was sent instead of a boolean ( work too because a number is true but fixed now )
Add uts
Fix uts with the old event system

Change the event mousedown with click because we by pass the click event on child element if we catch the mousedown before ( event ordering )

Codecov Report

Merging #1090 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
- Coverage   99.76%   99.75%   -0.02%
==========================================
  Files         330      330
  Lines        8177     8192      +15
  Branches     1953     1957       +4
==========================================
+ Hits         8158     8172      +14
- Misses         19       20       +1

Impacted Files
Coverage Δ

src/components/drop/Drop.tsx
100% <100%> (ø)
:arrow_up:

src/components/drop/DropPod.tsx
97.14% <100%> (-1.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41cb75b...5d04cba. Read the comment docs.

There is a new miss, I don't know if it's easy to fix?

coverage fixed


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

training in colaboration :-)


add mutate webhook of pod

Ⅰ. Describe what this PR does
Adding a mutate webhook of pod. it can affect the results of scheduling no matter if it has used a dataset or not.
Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
create two dataset, and create a pod mounting one of them.
Ⅴ. Special notes for reviews

Thanks for your great work! @yangyuliufeng

Separate the certificate management logic from the webhook .
Maybe we can avoid put the logic into the entry function in future:   (a *MutatingHandler) Handle(ctx context.Context, req admission.Request) admission.Response

Is some useful information for this pr, @yangyuliufeng @cheyang

Is some useful information for this pr, @yangyuliufeng @cheyang

This is just a demo, I'm coding a Formal development now

Codecov Report

Merging #725 (1900d47) into master (2a8602e) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   12.52%   12.43%   -0.10%
==========================================
  Files          93       93
  Lines        4279     4310      +31
==========================================
  Hits          536      536
- Misses       3683     3714      +31
  Partials       60       60

Impacted Files
Coverage Δ

pkg/ddc/base/runtime.go
47.12% <0.00%> (-26.09%)
:arrow_down:

pkg/utils/runtimes.go
29.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8602e...1900d47. Read the comment docs.

Thanks, @yangyuliufeng .Let's merge the PR first, then enhance it in later PR.


build issue when included in a Gatsby (React) project

versions:
Gatsby 2.3.0
React 16.8.5
Gatsby is all pre-configured, but I'm pretty sure it's webpack under the hood.
Code
import 'splitting/dist/splitting.css'
import 'splitting/dist/splitting-cells.css'
import Splitting from 'splitting'

const Component = () => {
  useEffect(() => {
// component Did mount
    Splitting()
  }, [])

Error log:

TypeError: Cannot read property 'depends' of undefined
resolvePlugins
node_modules/splitting/dist/splitting.js:130
 127 |     deps.unshift(by);
 128 |
 129 |     // recursively call this function for all dependencies
> 130 |     each(plugins[by].depends, function(p) {
 131 |         resolvePlugins(p, by, deps);
 132 |     });
 133 | } else {
View compiled
resolve
node_modules/splitting/dist/splitting.js:167
 164 |  * @returns {import('./types').ISplittingPlugin[]}
 165 |  */
 166 | function resolve(by) {
> 167 |     return resolvePlugins(by, 0, []).map(selectFrom(plugins));
 168 | }
 169 |
 170 | /**
View compiled
(anonymous function)
node_modules/splitting/dist/splitting.js:304
 301 | }
 302 |
 303 | ctx = el['🍌'] = { el: el };
> 304 | var items = resolve(opts.by || getData(el, 'splitting') || CHARS);
 305 | var opts2 = copy({}, opts);
 306 | each(items, function(plugin) {
 307 |   if (plugin.split) {
View compiled
Splitting
node_modules/splitting/dist/splitting.js:297
 294 | opts = opts || {};
 295 | var key = opts.key;
 296 |
> 297 | return $(opts.target || '[data-splitting]').map(function(el) {
 298 |   var ctx = el['🍌'];
 299 |   if (!opts.force && ctx) {
 300 |     return ctx;
View compiled
(anonymous function)
src/components/do-and-are.js:20
 17 |   //   charsClass: 'char',
 18 |   // })
 19 |   // tl.set(st.current.chars, { yPercent: 100 })
> 20 |   Splitting()
 21 | }, [])
 22 |
 23 | if (intersected) {
View compiled
▶ 22 stack frames were collapsed.
(anonymous function)
/Volumes/Data/DOCUMENTS/_htdocs/mevishaslam.com/2019/.cache/app.js:56
 53 | const preferDefault = m => (m && m.default) || m
 54 | let Root = preferDefault(require(`./root`))
 55 | domReady(() => {
> 56 |   renderer(<Root />, rootElement, () => {
 57 |     postInitialRenderWork()
 58 |     apiRunner(`onInitialClientRender`)
 59 |   })

perhaps a screenshot is a bit more readable:

I believe this is related to #26 and #27. I can't tell from what you've shown, but I believe you're just using
, which React changes to
. Splitting currently has issues with that, because there's no "true" plugin.
The fix is to use
 until we get #27 fixed and pushed.
https://github.com/shshaw/Splitting/issues/26#issuecomment-416968542

yes that's it!

This was an issue for me today using React 17.0.2 in Next 12.0.5 and Splitting ^1.0.6


Upgrade jupyterhub-fancy-profiles version on imagebuilding-demo

Following on from https://github.com/2i2c-org/infrastructure/issues/4522, we want to upgrade jupyterhub-fancy-profiles on the other two hubs we have it running:

imagebuilding-demo
sciencecore

The second has users, so let's deploy to the first one!
This would involve replicating the changes from https://github.com/2i2c-org/infrastructure/issues/4522 to the imagebuilding-demo hub config. Since imagebuilding is enabled there (unlike VEDA), you probably also need to intentionally enable dynamic image building - see https://github.com/yuvipanda/jupyterhub-fancy-profiles/pull/58/files#diff-26e325937baab623ebecf944e3691cfc6d509853168cf154a403089ea6a93a1e for what that may look like.
Definition of done

[ ] Imagebuilding demo hub has new version of jupyterhub-fancy-profiles
[ ] dynamic image building, unlisted choice and selecting an existing image work
[ ] There's another issue opened about upgrading this in the sciencecore hub

So I haven't applied any changes yet, but already I'm struggling to build an image. I'm not sure if the imagebuilding-demo has restricted repos it can build? I can't see anything specified in config.

I am pretty sure that #4634 covered what is being ask to be done here, but @yuvipanda please ping me if I missed something.

I am still receiving the above error trying to use the dynamic image building option. But since it was present before I began any of the work in this issue, I'll close it and open another one with a spike to investigate what's going on here.
The pre-defined images and selecting an existing image both work.

I'm actually getting the same error message on sciencecore for https://github.com/binder-examples/requirements....

Ok, you're supposed only provide binder-examples/requirements, not the full URL. That is... very counter-intuitive if you're coming from mybinder.org and/or are prone to just copy-pasting URLs.

Yeah, so dynamic image building works fine

New issue for sciencecore: https://github.com/2i2c-org/infrastructure/issues/4635

I don't see the ability to build images anymore:


zh_trans: docs/setup/independent/create-cluster-kubeadm.md & docs/reference/setup-tools/kubeadm/generated/kubeadm_alpha_phase_addon.md

Netlify Link URL: /zh/docs/setup/independent/create-cluster-kubeadm

/assign @chenrui333

@tengqm 感谢指正，已修改

@tengqm 已修正

/cc @chenrui333  @tengqm

@tengqm 已修改 感谢指正

made couple of comments to this giant PR for discussions.
Overall, I think it looks good! Thanks!

/lgtm

The document has been modified. Thanks for the help of two friends. @chenrui333 @tengqm 😄

/lgtm

/approve

np, thanks for the contribution!


Update Fedora/CentOS cloud image to latest.

Updated CentOS to latest 1809. Need to update Fedora.


Typing on a selected cell should enable editing and replace contents

This is a feature your muscle memory will expect from using a spreadsheet, especially when encountering an empty cell. Arrow-key navigate to a cell, then start typing to replace its contents. Rather than having to hit enter and then select-all.
Edit: This is a tough one.. beyond listening only to character keys (A-Z, 0-9, @#@, etc. rather than left/right/tab), we actually want to insert what you typed, as if you had been editing in the first place.

GreenJello in freenode's #javascript suggested:
So there's a hidden . When they select a cell, I set focus to that input and start listening to the input event. When the input event is triggered, I activate "edit mode" on that cell and apply the value of that  (what they started typing) to that cell. As opposed to listening to the onkeypress event and determining.
a hidden bonus of that is that it would enable copy & paste :O


webcam_restartfeed spec uses 'msg' instead of 'message'

Most spec files use 'message' as the return message when a problem occurs.  However, spec/usb_webcam/webcam_restartfeed.yaml uses 'msg', and there is no 'result' field.

Fixed in pull request (https://github.com/TimesysGit/board-farm-rest-api/pull/16)


Incorrect color rendering

Hello.
I ran into strange bug. I think it's depends on the latest updates of the G. Chrome or something like that, because it did not appear before.
I use the latest version of the pixi.js lib for current time - it's 4.5.6.

When I use the PIXI.WebGLRenderer - colors of all sprite have changed. (became dimmer)
When I use the PIXI.CanvasRenderer - colors are still right untill I change text in any instance of PIXI.Text component. ... after that all sprites became dimmer too.
For view I'm attaching a screenshot of the color changing and URL of this picture on G. Drive.

https://drive.google.com/file/d/0B9xC8Ta34EqSTFNfWmtIdml1d1U/view
P.S. Sorry for my english. :-)

Do you use tint on sprites? If not, then you have a problem with videodrivers.

No, I don't use any tint for sprites. Also I checked it with another device but got the same behavior. ... so I think it is not videodrivers

But not reproduced after Chrome update


Use EpochNo instead of SlotNo in Pool, Cert and Certs rules

Description
Slightly simplify rules by not passing slotNo around when not required.
Closes https://github.com/IntersectMBO/cardano-ledger/issues/4692

Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
New section is never added with the code changes. (See RELEASING.md)
[ ] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated.
If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[ ] Self-reviewed the diff

FYI. applyTx from Cardano.Ledger.Shelley.API.Mempool will also be affected by my comment. Which has two alternative solutions that I can think of, but we can talk about if you run into problems in the ApplyTx interface

Closing, since i redid all in this PR: https://github.com/IntersectMBO/cardano-ledger/pull/4765


Only expose new context token via sw-context-token header after regis…

…tration
After a user registration the context token in the sw-context-token header is
not valid. The new and the old token are exposed as comma seperated values.

1. Why is this change necessary?
The documentation said you can use the sw-context-token header and use it for the next request.
The registration creates a new token but then the old and the new token are returned both comma separated.
When you use the token for the next request your context is not valid anymore.
2. What does this change do, exactly?
Only setting the sw-context-token from request when no token is present
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

hey @nlx-sascha, the issue seems to have been fixed already but your tests seems good. would you mind if we just merge your test? (just needs some minor changes, e.g. removed api version and then it is running on trunk).

Hey @J-Rahe , sure use the tests as this would help to finde regressions.
Can you point me to the change that fixes the issue.

@nlx-sascha, look here . That seems to be the same file you changed.

@J-Rahe thanks.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-14004
Please use this issue to track the state of your pull request.

Hey @nlx-sascha, your test was merged :)


fix(seeder): fix factory typing for entity with parameters in constru…

Given an Entity with parameters in constructor and his factory :
@Entity()
export class Project {

  [OptionalProps]?: 'createdAt';

  @PrimaryKey()
  id!: number;

  @Property()
  name!: string;

  constructor(name: string) {
    this.name = name;
  }
}

export class ProjectFactory extends Factory<Project> {
  model = Project;

  definition(faker: Faker): Partial<Project> {
    return {
      name: 'Money vault',
    };
  }
}

This will result in a typescript error:

This PR fix the typing to allow any parameters in model constructor.

Codecov Report

Merging #2745 (3fece75) into master (f6e26ba) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 3fece75 differs from pull request most recent head 4087819. Consider uploading reports for the commit 4087819 to get more accurate results

@@            Coverage Diff            @@
##            master     #2745   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          193       193
  Lines        11559     11559
  Branches      2644      2644
=========================================
  Hits         11559     11559

Impacted Files
Coverage Δ

packages/seeder/src/Factory.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e26ba...4087819. Read the comment docs.


maybe mistake in xy offset in error message

when File broken, the error message maybe have mistake:
Read or write failed. IReadBlock failed at X offset 7, Y offset 28: /tmp/200504_08_83807.tif, band 1: IReadBlock failed at X offset 7, Y offset 7: TIFFReadEncodedTile() failed.
you can see, when error occur, the error message is not consistent.  xy=[7,28]  , xy=[7,7]

The error message comes from Rasterio/GDAL, nothing to do with rio-tiler. Sorry

@vincentsarago
A digression. Can we organize COG-TIFF tiles according to the size projected by Mercator, so that tiles are not crossed each time they are fetched. In this way, only the smallest HTTP request needs to be sent.

from here

@tsjsdbd you need to create a web-optimized COG, meaning you need to have the data and the overview aligned with the WebMercator grid
see https://gdal.org/drivers/raster/cog.html#reprojection-related-creation-options

TILING_SCHEME=CUSTOM/GoogleMapsCompatible/other: Default value: CUSTOM. If set to a value different than CUSTOM, the definition of the specified tiling scheme will be used to reproject the dataset to its CRS, select the resolution corresponding to the closest zoom level and align on tile boundaries at this resolution. The tile size indicated in the tiling scheme definition (generally 256 pixels) will be used, unless the user has specified a value with the BLOCKSIZE creation option, in which case the user specified one will be taken into account (that is if setting a higher value than 256, the original tiling scheme is modified to take into account the size of the HiDPi tiles). In non-CUSTOM mode, TARGET_SRS, RES and EXTENT options are ignored. Starting with GDAL 3.2, the value of TILING_SCHEME can also be the filename of a JSON file according to the OGC Two Dimensional Tile Matrix Set standard, a URL to such file, the radical of a definition file in the GDAL data directory (e.g. FOO for a file named tms_FOO.json) or the inline JSON definition.

or https://cogeotiff.github.io/rio-cogeo/Advanced/#web-optimized-cog

Thank you very much, the performance has been greatly improved.
before：

after：


Automate Health/Fortune deduction - drag and drop damage chat card on token

Evaluate options to apply damage (half/double damage, afeter/before armor rating)

Complete. Solution adopted is: select tokens and then click "Apply Damage" on damage chat message.


Examples required - User friendly improvement

Hello,
For context, I'm attempting to develop a UAVcan implementation using cannard, on a STM32 using RTOS.
I find the examples on the readme satisfactory and I believe we could benefit from full a example of publishing and subscribing to messages and services.
I don't mean specifically for my case (would also be nice), but a very generic (maybe heartbeat publish and subscribe?) implementation, fully written on a C example.
Could this be arranged? If there is anything I haven't found using the current version found on this repo.
Thank you for this amazing protocol and amazing work.

Thanks for the kind words.
We have full-featured demos here, but they are for an earlier revision of this library where the API is slightly different: https://github.com/UAVCAN/demos
The full API diff can be seen here (scroll to canard.h and ignore the rest):
https://github.com/UAVCAN/libcanard/commit/cf0a8bc67ddf98dfccf157695533ac5324e021eb#diff-6d1addc3815ef077e06339f13578aa999d57eba65be6a707e2fe55d4e0038509

Thank you for such a quick answer Pavel,
I was hoping I could get a barebones example of a publish and subscribe to a heartbeat message for example.
The given examples are great but very complex ( at least to me ) to understand the steps required to implement such basic functions.
When I mean "barebones" I'm actually trying to get little increments at a time, the protocol is great but with a very steep learning curve. For example, ROS has tutorials for publishing and subscribing...
I'm not saying to get a full wiki and all going on, but maybe a little beginner-friendly approach wouldn't hurt.
Maybe a simple (and possibly separate examples) to publish and subscribe to the heartbeat messages would be a good start?
Once again, there are just suggestions, but coming from someone who has average knowledge in programing and really sees the potential of this protocol.

While not exactly a bare bones example, this Sapog repository is closer to what you need than the demo repository:

it runs on actual hardware instead of just as a process on a computer
uses Canard v2
is supposed to become a reference project for new adopters
See that first. I haven't planned on when I will be making bare bones examples yet.

This is somewhat closer to what I was looking for. Im attempting to implement libcannard to talk to a PX4 autopilot, using a Nucleo board STM. I know there are examples out there, but none are using the latest libcannard...
Thank you for your sugestion, if in the future you do a barebones, please let me know.

I think I have an example using Zephyr RTOS somewhere, but its also using the canard V1 API. If I find some time I'll update it and share.

This is somewhat closer to what I was looking for. Im attempting to implement libcannard to talk to a PX4 autopilot, using a Nucleo board STM. I know there are examples out there, but none are using the latest libcannard...
Thank you for your sugestion, if in the future you do a barebones, please let me know.

If you are interested here is my repo where libcanard v2 is used: https://github.com/ValeriiKim/Modrob-UAVCAN/blob/master/src/SENSOR_MODULE/main.cpp

The demos have been updated to use the new libcanard v3: https://github.com/OpenCyphal-Garage/demos/pull/12

This is somewhat closer to what I was looking for. Im attempting to implement libcannard to talk to a PX4 autopilot, using a Nucleo board STM. I know there are examples out there, but none are using the latest libcannard...
Thank you for your sugestion, if in the future you do a barebones, please let me know.

I don't know if it's fair to call the use of STM32Cube "barebone", but here is a simple Libcanard 2 example for it, with project generation from .ioc - https://github.com/Dmivaka/STM32-HAL-Libcanard

one simple demo is  better than 1000 words😂.  i am a beginner of uavcan, and it's difficult for me to find out  such as: how the demo work, what is the relation ship between libcanard and DSDL? how can i use  libcanard  with DSDL?  it's  all  question ...

The demos I linked earlier illustrate both. Take a look at this one: https://github.com/OpenCyphal-Garage/demos/tree/main/differential_pressure_sensor
It is a very basic application that incorporates both libcanard and DSDL code generation (via Nunavut). You can easily port it to an embedded platform (it can be run on GNU/Linux out of the box).
You can also check out @aentinger's Arduino Cyphal and its examples -- it might be more approachable.

The demos I linked earlier illustrate both. Take a look at this one: https://github.com/OpenCyphal-Garage/demos/tree/main/differential_pressure_sensor
It is a very basic application that incorporates both libcanard and DSDL code generation (via Nunavut). You can easily port it to an embedded platform (it can be run on GNU/Linux out of the box).
You can also check out @aentinger's Arduino Cyphal and its examples -- it might be more approachable.

Thanks a lot！ maybe those demo can be join into the README.md to give other more help, even if it's just a link.

Would you still be interested in adding more minimal samples (like a heartbeat subscriber & publiser) to eg the demos repository? I have found myself looking for something like this a couple of times now and would love to implement it.

Would you still be interested in adding more minimal samples (like a heartbeat subscriber & publiser) to eg the demos repository?

Yes.

I have found myself looking for something like this a couple of times now and would love to implement it.

Please do. As an alternative to the demos repo, you can also publish a link to your example here: https://forum.opencyphal.org/t/libcanard-examples-starters-tutorials/935


Add a way to select storage file

Not sure if its a niche thing but I really like this tool but I also want to have multiple "notebooks" with different things in them. At the moment I have two different files that I select between by editing my config file to show which ever folder I like but I was wondering if it would be possible to have this as an option inside the app?

Hi, this is already possible via command line arguments. You can use the CLI arguments tjournal -j <FILE PATH> for json files and tjournal -s <FILE PATH> for sqlite db files.
Here is a quote from the output of the help command:
Options:
  -j, --json-file-path <FILE PATH>    Sets the entries Json file path and starts using it
  -s, --sqlite-file-path <FILE PATH>  Sets the entries sqlite file path and starts using it

Please let me know if this solved your issue so we can close this one :wink:

O this is actually perfect thank you


Broken all of a sudden

Probably some server-side shenanigans, or my local IP is blacklisted.
Relevant traceback:
  File "/srv/data/home/somini/.local/bin/rtpplay-dl", line 62, in main
    raw_pg = rtp.get_program(sid)
  File "/usr/local/lib/python3.8/dist-packages/rtpplayapi/api.py", line 152, in get_program
    return self.__request("get-program/{}?include_webparams=true&include_epg=1".format(program_id))
  File "/usr/local/lib/python3.8/dist-packages/rtpplayapi/api.py", line 73, in __request
    self.__set_token()
  File "/usr/local/lib/python3.8/dist-packages/rtpplayapi/api.py", line 61, in __set_token
    r = requests.get(self.config.AUTH_URL_ENDPOINT, headers=headers).json()
  File "/usr/local/lib/python3.8/dist-packages/requests/models.py", line 910, in json
    return complexjson.loads(self.text, **kwargs)
  File "/usr/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.8/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None

FYI, this works: https://github.com/ytdl-org/youtube-dl/pull/29824


perf(itemLookup): use map instead of object

ENG: Map performs better for larger collections, and is the better cache implementation. Also comment out noisy log message which is triggered a lot during normal operation.

LGTM


How to acquire actual terminating message from either UserProxyAgent or AssistantAgent(s)?

I wanted to know how to get the literal terminating message from the Agent that terminates the GroupChat? I need to know the output for my own custom uses, since I intend on changing the terminating message to be either "GOOD" or "BAD" instead. But more importantly, I want to know exactly which of those terms were outputted for the conversation to be terminated.
I understand that prompting the output that mentions "TERMINATE" will terminate the whole process by default or by the given function:
is_termination_msg=lambda msg: "TERMINATE" in msg["content"]
Writing a function like this will get the job done in terms of termination:
check_compatibility = lambda msg: "GOOD" in msg["content"] or "BAD" in msg["content"]
But how would I find out exactly which term - "GOOD" or "BAD" was outputted by the agent? If it helps, I want the terminating GOOD/BAD message to be delivered by the UserProxyAgent.
What I have tried:

I have tried checking user_proxy.chat_messages but that only gave me the message without the terminating message sadly.
Attempted to change the default_auto_reply to output the actual terminating message based on a conditional function... but I just don't know which variable in the class to reference.

@afourney fyi

@mathematicsofpaul  The last message either contains the termination string or it reaches the max reply round.

answered in June.


cmd/compile: not enough arguments error should be multiple lines

Getting errors like this:
./ipsock_test.go:223: not enough arguments in call to filterAddrList, got (func(IPAddr) bool, []IPAddr, func(IPAddr) Addr) want (func(IPAddr) bool, []IPAddr, func(IPAddr) Addr, string)

Please make them:
./ipsock_test.go:223: not enough arguments in call to filterAddrList
	have (func(IPAddr) bool, []IPAddr, func(IPAddr) Addr)
	want (func(IPAddr) bool, []IPAddr, func(IPAddr) Addr, string)

to match other similar error from the compiler. Note the use of "have" not "got", because then both prefixes are the same length (even in most variable width fonts), so that it is easier to visually diff the two.
Thanks.

Two other nits I noticed while looking at this more closely:
fmt.Println(1, 2, (3)...)

causes us to print:
have (number, number, number)
want (...interface{})

which is misleading because it doesn't reflect that this is a ... call.
Also, given
func f() (string, string) { return "", "" }
func g(string, string, string) {}

calling g(f()), gives:
have ((string, string))
want (string, string, string)

and the extra parentheses are unnecessary.


Running with a sandbox

What would you like to have implemented?
Is it possible to run Chromium without the --no-sandbox flag?
Why would it be useful?
For safety when executing foreign code.
When attempting to run without a sandbox:
 ERROR   Error: Failed to launch the browser process!
[0703/095854.412457:WARNING:resource_bundle.cc(435)] locale_file_path.empty() for locale
[0703/095854.412718:FATAL:zygote_host_impl_linux.cc(116)] No usable sandbox! Update your kernel or see https://chromium.googlesource.com/chromium/src/+/master/docs/linux/suid_sandbox_development.md for more information on developing with the SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.
#0 0x5620dd3b8b29 (/tmp/chromium+0x48e4b28)
#1 0x5620dd328173 (/tmp/chromium+0x4854172)
#2 0x5620dd338d25 (/tmp/chromium+0x4864d24)
#3 0x5620de8be36e (/tmp/chromium+0x5dea36d)
#4 0x5620dd2cb110 (/tmp/chromium+0x47f710f)
#5 0x5620de8c5157 (/tmp/chromium+0x5df1156)
#6 0x5620dd2c4801 (/tmp/chromium+0x47f0800)
#7 0x5620dd32449d (/tmp/chromium+0x485049c)
#8 0x5620dd3241bc (/tmp/chromium+0x48501bb)
#9 0x7f94f470a02a __libc_start_main
#10 0x5620db4aea2a _start

@williamjulianvicary it seems like you're trying to overwrite default args provided by chromium-aws package.
When launch() it you could exclude/include any flags. Can you provide your args you passing to it?

@Dadidam I was actually using the package to do the extraction only, ignoring the wrapping and essentially calling the await for the chromiumPath manually and pushing that to the relevant ENV var for puppeteer core.
In the end I tweaked the approach and instead I'm now overriding the launch() method on puppeteer with this:
puppeteer.launch = async function launch(options = {}) {

    const newOptions = {
        args: chromium.args,
        defaultViewport: chromium.defaultViewport,
        executablePath: process.env.CHROMIUM_PATH,
        headless: true,
        ignoreHTTPSErrors: true
    };

    return await this._launcher.launch(newOptions);
}

Ideally I was hoping to be able to include the sandbox, but I have a feeling thats just not a supported approach with AWS.

According to the error you've got - something wrong with your CHROMIUM_PATH. Have you got the same error using chromium.executablePath locally for instance?

It was the args that are provided by chromium.args that were missing from my initial call (I wasn't launching with the above options before - which works fine now).
It seems the options provided by chromium.args aren't just a suggestion, they're required by the packaged Chromium instance (at least some of them).

@williamjulianvicary It's not possible unfortunately (this is a limitation of the AWS Lambda environment).
And yes, about half of the chromium.args are required, the rest are there to make it more consistent or performant.


Steam Pump only outputs steam via IE pipes via a pump.

Only way I have found to get steam out of the tank is via an Immersive Engineering Pump and pipes.
Doesn't seem to work for anything else in any other other modpack.
Tested on over a dozen mods so far.

I used Extra Utilities fluid transfer modes during development/testing for the mod. It might be something weird with the valve/vent capabilities.

I'll try it out with the mod you used for now then.
I'd like to identify the issue and resolve that asap.

Tested, works great,  though pipes dont visually attach.
It seems that IE and EU are the only mods this works with though, so that explains people having trouble.

Simple Wooden Pipes also works!

Found the issue. The blocks that pipes are to connect to need to extend a different object type. I'll fix that once I can make commits.

Sent an invite to the repo.


[test] Fix deprecation warning in IPCMagicCheck

Replace pre_run with prerun_cmds

@jenkins-cscs retry daint

Codecov Report

Merging #1387 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1387   +/-   ##
=======================================
  Coverage   91.75%   91.75%
=======================================
  Files          83       83
  Lines       12712    12712
=======================================
  Hits        11664    11664
  Misses       1048     1048

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cb7d4f...a5e3cdf. Read the comment docs.


fix the bug in cvrptw_break.py

core bug is passing the dict rather than a list to the
SetBreakIntervalsOfVehicle API call.
Also fixed the ad hoc approach to setting the node_visit_transit
values that relied on knowledge of the ORTools internal
implementation.  Instead, use the IndexToNode call.
Example now works for more than one vehicle.
Should close #1730

Thx !

Looking at the C++ side, one issue that came up in the bug reports was that the API accepts pretty much anything without complaining, even if the input is wrong.  Would it make sense to put a test in somewhere, for example:
void RoutingDimension::SetBreakIntervalsOfVehicle(
    std::vector<IntervalVar*> breaks, int vehicle,
    std::vector<int64> node_visit_transits) {
  if (breaks.empty()) return;
  DCHECK_EQ(node_visit_transits.size(), Size())

(in routing.cc, line 6840ish)
(Guessing that Size() is what is wanted here...something that is equal to the number of indices, like index_to_node_.size())
Why?  In the discussion of issue #1243, @braktar commented that he was able to pass in an array of 4 items, and the call failed, but it worked when he passed in an 8 item array with vehicle start/ends set to zero (https://github.com/google/or-tools/issues/1243#issuecomment-537390725)
In the example that I fixed, a dict was passed and it didn't fail.  I don't know for sure how that was able to happen, but from scanning the SWIG docs I assume the dict was auto-converted to a list.  That should be prevented by a typemap perhaps?  But I'm clueless as to how to do that.

And you'll want to get the RegisterTransitCallback index too ? (half joking)
https://github.com/google/or-tools/blob/e2f572c9999dbfd12707e7870df9aaa26c8d3c9d/ortools/constraint_solver/routing.cc#L6835-L6859

Ha ha yeah. I do want ice cream with my cake.
It seems my “super power” is finding bugs and diagnosing reasons why for the bug. But sadly, the super power doesn’t carry over to fixing bugs yet. Working on that though.
I’ll tweak those lines in my dev environment and see if I can’t make a clean fix with a test.

Hey, was wondering if this fix was suppose to be in the 8.2.8710 version ? Its the latest version (from pip install) and I can't run this example.

There seems to be a bug in the 8.2 version currently up. It segfaults on this cvrptw_breaks code. The 8.1 version I have works, and yesterday’s git master works. I haven’t had a chance today to write down the exact versions that work.
James


chore: bump to v1.15.0-rc1

null
Closes #977

Thank you @kim-em, done.

For posterity: I believe the CI failure here is lean4#5548, and that a fix may be adding a ulimit -s 16000 to expand the stack space given that issue.

Done. Let's see...

It's likely that the current issue is related to the following:

Zulip Topic
Mathlib PR

I am waiting for the above PR to be merged, after which I will re-run the CI jobs.

@pitmonticone The fix for that build failure is:
diff --git a/equational_theories/MemoFinOp.lean b/equational_theories/MemoFinOp.lean
index 22c326ad..dd74d59d 100644
--- a/equational_theories/MemoFinOp.lean
+++ b/equational_theories/MemoFinOp.lean
@@ -132 +132 @@ elab "finOpTable" str:str :term => do
-  discard <| withCurrHeartbeats <| Tactic.run mv.mvarId! do Lean.Elab.Tactic.evalTactic (← `(tactic| decide!))
+  discard <| withCurrHeartbeats <| Tactic.run mv.mvarId! do Lean.Elab.Tactic.evalTactic (← `(tactic| decide +kernel))

Thanks. I'll do it later today.


RUM-1844: Add Method Call Telemetry

What does this PR do?
Adds telemetry for view tree traversal time
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1940 (ba05245) into develop (1bd46ae) will decrease coverage by 0.01%.
Report is 16 commits behind head on develop.
The diff coverage is 85.96%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1940      +/-   ##
===========================================
- Coverage    83.35%   83.34%   -0.01%
===========================================
  Files          481      483       +2
  Lines        17413    17468      +55
  Branches      2590     2600      +10
===========================================
+ Hits         14513    14557      +44
  Misses        2192     2192
- Partials       708      719      +11

Files
Coverage Δ

...dog/android/sessionreplay/SessionReplayRecorder.kt
96.19% <100.00%> (+0.04%)
:arrow_up:

...nreplay/internal/recorder/ViewOnDrawInterceptor.kt
96.15% <100.00%> (+0.32%)
:arrow_up:

...nternal/recorder/listener/WindowsOnDrawListener.kt
94.59% <100.00%> (+4.94%)
:arrow_up:

...ay/internal/recorder/telemetry/TelemetryWrapper.kt
100.00% <100.00%> (ø)

...ternal/recorder/telemetry/MethodCalledTelemetry.kt
76.47% <76.47%> (ø)

... and 20 files with indirect coverage changes


Implementaion of numpy.ndarray.itemset in CuPy

Description
Hello.
I'd like to implement the functin of numpy.ndarray.itemset in CuPy #6078.
I don't know how to implement the function as a class method of cupy.ndarray.
From the document of NumPy, this function was implemented as a inplace function.
>>> np.random.seed(123)
>>> x = np.random.randint(9, size=(3, 3))
>>> x
array([[2, 2, 6],
       [1, 3, 6],
       [1, 0, 1]])
>>> x.itemset(4, 0)
>>> x.itemset((2, 2), 9)
>>> x
array([[2, 2, 6],
       [1, 0, 6],
       [1, 0, 9]])

Normally, funtion requires a variable to return values, but this method doesn't require it.
How Can I implement this function?
Sincerly,
Additional Information
No response

Hi @oishigyunyu, thanks for the interest. cupy.ndarray class methods are defined at: https://github.com/cupy/cupy/blob/9816e20b3915dd28bc54a7549f28f69633ceb112/cupy/_core/core.pyx#L95

@kmaehashi
Thank you for your suggesting.
I will work on this issue, then I will reopen the pull request.

Moving the discussion to #7569


Project: Microsoft Learn contributor copilot

Project Name
Microsoft Learn contributor copilot
Description
This is a copilot that does RAG with the Microsoft Learn contributor guide and platform manual - these two massive sets of internal documents define how we write our public-facing documentation on learn.microsoft.com. By feeding that information to a copilot, we make it much easier and faster for Microsoft FTEs to learn how to contribute to the docs.
Technology & Languages

[ ] JavaScript
[ ] Java
[ ] .NET
[X] Python
[X] AI Studio
[X] AI Search
[ ] PostgreSQL
[ ] Cosmos DB
[ ] Azure SQL

Project Repository URL
https://github.com/PatrickFarley/help-bot
Deployed Endpoint URL
(private)
Project Video
https://www.youtube.com/watch?v=15ugeNNY1hM
Team Members
PatrickFarley, jonburchel

Hello @PatrickFarley, thank you for participating in RAG Hack!
The team is working hard to distribute badges. Please have each team member fill out this form:
aka.ms/raghack/badge-dist
Thank you!


ControlPath should be "more unique"

Currently, ControlPath only set to %h but according to this wiki entry it should try to be as unique as possible.

Note that the control socket is named "fred@server.example.org:22", or %r@%h:%p, to try to make the name unique. The sockets should be given unique names. The combination %r,  %h and %p stand for the remote user name, the remote host and the remote host's port.

I think I ran into problems because I played around a bit and used different users with knife-solo on a test setup. The hostname (%h) was always the same and I ran into issues.
rsync: connection unexpectedly closed (8 bytes received so far) [sender]
rsync error: error in rsync protocol data stream (code 12) at /SourceCache/rsync/rsync-45/rsync/io.c(453) [sender=2.6.9]

Only after using --ssh-control-master no which succeeded, did I investigate further and think this might have caused the problem.

Fair point. Probably should have the user and port in there. Though I've seen cases where the file name gets too long so could be we should just build some sort of a specific-to-knife-solo hash.
Another thing that came to light in all this is that we could probably gain similar efficiency by pre-staging everything to a local tmp and doing a single rsync. Assuming people aren't rsyncing huge swaths of data anyway.

Going to close this in favor of #448 - while we could include user & port, I worry about the length of the socket name.
Control master is also a somewhat subtle ssh feature which could cause other oddities if people aren't used to it and doing things like switching users, proxying ports, etc, etc.
Pretty sure doing one bulk rsync is doable and should get us similar (or better) speed with less complexity.


Documentation does not mention the mark element

Bootstrap styles the mark element, but the documentation does not mention it or have any reference to the element.

It is mentioned in the docs :slightly_smiling_face:
Here: https://getbootstrap.com/docs/4.5/content/typography/#inline-text-elements

My apologies, you're right. I missed this when searching in the search bar since Algolia did not pick up on it.
Since the mark element is a semantic equivalence to the marker pen which comes in different colors, it might be of interest to illustrate using the mark element together with classes.

You can use the mark tag to highlight text.

You can use the mark tag to highlight text.

You can use the mark tag to highlight text.

You can use the mark tag to highlight text.

You can use the mark tag to highlight text.

No plans to add mark-specific classes or to document it with .bg- utilities since that'd most likely require text utilities as well, which is covered on the utilities docs :).


Minor correction in webpack.config.js

Minor correction in webpack.config.js,
Diff correction to include the comma

@EugeneHlushko , don't merge yet, the issue is repeated many times in the docs, let's create one PR for all

Checked the guides directory, and using a regex I added a comma to the last item in an object when a new item is appended to the end of that object.
@EugeneHlushko

Me too, this problem is so common that there is a JS proposal for it :D

Another related suggestion:
the diff signs (+/-) make it difficult for the reader to copy/paste, if the diff is going to be kept, it would be better to remove the diff signs, I think the colors (green/red) would be enough for the reader.
something like this should work:
function removeDiffSigns() {
  const diffElements = document.querySelectorAll(
    "code.language-diff > span.inserted, code.language-diff > span.deleted"
  );

  diffElements.forEach(function(diffElement) {
    diffElement.innerHTML = diffElement.innerHTML.replace(/^[+-]/, '');
  });
}

This makes me want to have trailing comma rule in our configs

Agree, here is a quote from Mozilla: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas

Trailing commas (sometimes called "final commas") can be useful when adding new elements, parameters, or properties to JavaScript code. If you want to add a new property, you can simply add a new line without modifying the previously last line if that line already uses a trailing comma. This makes version-control diffs cleaner and editing code might be less troublesome.
JavaScript has allowed trailing commas in array literals since the beginning, and later added them to object literals (ECMAScript 5) and most recently (ECMAScript 2017) to function parameters.

@ejez do you want to re-work this PR into changing all "diff" code snippets in guides to have trailing comma and reduce the amount of diff size on them?

Will do when I get home...
You mean all code snippets, not only those having diffs.

@EugeneHlushko
done


Exception at<PHONE_NUMBER>010930: EReadError:

C:>deliver.exe -d -f bin.enc
Exception at<PHONE_NUMBER>010930: EReadError:
Stream read error

that issue is duplicate of https://github.com/0xsp-SRD/mortar/commit/18736a408b53ad0ff3d62c97a4d08b976e14518d and already fixed, fetch new clone of encryptor and make sure to use correct arch


Add user perf

Adds User Performance metric, called Score (not userPerf)
For Feature #19
Please use squash merge
Work In Progress

Replaced by #46


Use the date object returrn;

What are the methods to manipulate the date object returned after the user selects

Ok wait is it still like our normal Date object in javascript?

@Zedonboy yep!


[Composer Autofill] : IO package functions are not loaded in composer

Nothing loaded in composer auto fill related to the ballerina/io package

Fixed in 0.975.0


Changes of tasks affect previous task, not current

Are you using "tree-sitter" branch?
Yes
Describe the bug
When doing cit or <leader>ois on the current task, actually changes the previous task. This used to work fine before.

Steps to reproduce
Add two tasks and try updating the second one.
Expected behavior
The second one updates.
Emacs functionality
No response
Screenshots and recordings
No response
OS / Distro
Manjaro Linux
Neovim version/commit
0.5
Additional context
No response

Folding is not really well tested, since I'm not using it myself. It definitely needs more care.
Why are you reloading your init.vim? In my previous comment I meant to reload the org file by editing it via :e!.
Todo keyword colors are colored through treesitter, but added manually to the queries, since they can be dynamic. There might be a situation where those are not sourced, usually when something errors out. I need to figure out a way how to source them no matter if something errors out or not.

I was just commenting what makes folding work. :e! doesn't help for folding.
I'll try :e! for the original bug :wink:

Ok. Please file a separate issue for this, with reproducible steps, so I can keep track of it.

Ok so :e! does fix the original bug :clap:

@gerazov ok, but you can still reproduce the bug? If yes, let's reopen this.

Skipping the undo doesn't help, btw how do you clear the todo with fast access?
I think it is tree-sitter at the end. Here's what I have

I ran :TSUpdate, using neovim 0.5.1 and still get this behavior.
My steps are:

opening a file that looks like this:

* heading 1
* heading 2
* heading 3

have cursor on heading 2, type oit and create new TODO heading below heading 2
exit insert mode and type >> to demote the TODO heading
heading 2 gets demoted under heading 1

Some relevant config from init.vim:
"----------------------------------------------
" Org-Mode
"----------------------------------------------
lua << EOF
local parser_config = require "nvim-treesitter.parsers".get_parser_configs()
parser_config.org = {
  install_info = {
    url = 'https://github.com/milisims/tree-sitter-org',
    revision = 'main',
    files = {'src/parser.c', 'src/scanner.cc'},
  },
  filetype = 'org',
}

require'nvim-treesitter.configs'.setup {
  -- If TS highlights are not enabled at all, or disabled via `disable` prop, highlighting will fallback to default Vim syntax highlighting
  highlight = {
    enable = true,
    disable = {'org'}, -- Remove this to use TS highlighter for some of the highlights (Experimental)
    additional_vim_regex_highlighting = {'org'}, -- Required since TS highlighter doesn't support all syntax features (conceal)
  },
  ensure_installed = {'org'}, -- Or run :TSUpdate org
}

require('orgmode').setup({
  org_agenda_files = {'~/Sync/orgs/*'},
  org_default_notes_file = '~/Sync/orgs/refile.org',
})
EOF

I think that fixed the issue for me.  I'll continue to test and try to reproduce it but looks good!


Adjust dependencies for Demo installation.

Did not work on Ubuntu. New ones confirmed to work.

Thanks for testing!


Resetting text when open settings and go back

Resetting text when I open settings and go back to main ui.

Fixed in ba7fcf6


bluemuse and psychopy timestamps in different units

@jdpigeon  @kowalej @derekbeaton
I think I've got to the bottom of the problem observed by Derek that the markers column in the data##.csv file is all empty when connecting with bluemuse.
The problems seems to be due to the units of the timestamps.
Example: here are the first few lines of an output data.csv file
timestamps,TP9,AF7,AF8,TP10,Right AUX,Marker0
1527976488650.125,999.512,-912.598,-915.527,-690.918,-603.516,2
1527976488654.031,-991.699,-794.434,-822.266,-475.586,-398.926,0
1527976488657.938,953.613,-875.488,-916.504,-496.582,-496.094,0
1527976488661.844,-913.574,-988.770,-990.234,-634.277,-632.324,0
1527976488665.750,811.523,-881.348,-893.555,-813.965,-727.051,0
The problem is that, apart from the first row, the final column contains all zeros.
To check this I added in the following line underneath the while loop in lsl-record.py
open('jg_markers_test.csv', 'w').writelines(['%s %s\n' %(m[0][0], m[1]) for m in markers])
Here are the first few lines of this output file
2 1848.45728328
1 1849.20626896
2 1849.79690854
1 1850.48569322
2 1851.05877687
2 1851.61607933
1 1852.19659235
Basically it looks like the timestamps from psychopy are different to the ones output by bluemuse.
This confuses the final few lines of lsl-record.py, which look for the closest value in the eeg timestamps matching each psychopy marker
https://github.com/alexandrebarachant/muse-lsl/blob/master/lsl-record.py#L99
Now trying to figure out what to do about this.

Makes total sense. Can we just standardize everything to the Unix time stamp no regionalization or anything?

well ideally bluemuse should be updated to use the same timestamps as
psychopy
in the meantime as a fix would be useful to have some kind of conversion
function.
in order to do this will need to know the units used. which I'm really not
sure of.
Do you recognize the units in the two sets of outputs I listed?
On 2 June 2018 at 18:16, Dano Morrison<EMAIL_ADDRESS>wrote:

Makes total sense. Can we just standardize everything to the Unix time
stamp no regionalization or anything?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NeuroTechX/eeg-notebooks/issues/10#issuecomment-394120956,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYSAumBt-CmSVWPvXWdkSNzuK0valysks5t4w6ygaJpZM4UX3C6
.

--
Dr. John Griffiths
Post-Doctoral Research Fellow
Rotman Research Institute, Baycrest
Toronto, Canada
and
Honorary Associate
School of Physics
University of Sydney

Fix for this is on my muse-lsl fork.
https://github.com/JohnGriffiths/muse-lsl/commit/28d9c798636317ac90c0b01067f3cea2a968fe71
It optionally converts UTC timestamps (as used by bluemuse) to match the  pylsl.local_clock() units used in the psychopy markers stream.
Also updated run_experiment.py to allow it to be activated with a command line flag.
Usage is now as follows:
python scripts\run_experiment.py -e mlsl_N170_test -c 1
Note if running on linux, mac, or Windows using dongle rather than bluemuse, either use -c 0 or (better) omit that flag (0 is the default).
Running with this fix the markers appear to be being lined up correctly with the EEG timestamps and are now appearing in the .CSV file . Test runs with N170 experiment produces similar ERPs in TP sensors as seen from runs on Linux systems.
I have temporarily switched the submodule reference to my muse-lsl fork as this fix needs to be available immediately.
This is temporary because eeg-notebooks will be switching over to using the refactored muse-lsl soon anyway (probably in the next few weeks).
We should review how this timestamps conversion is done, and whether there is a better way to do it as part of the muse-lsl refactor.

I talked to Alexandre about this. He thinks what we've done (switching to UTC) makes perfect sense and will work fine.
However, he pointed out one thing, which is that if we move away from local_clock we will miss out on LSL's time correction feature that you can see explaine here: https://github.com/sccn/labstreaminglayer/wiki/TimeSynchronization.wiki#synchronization-process-offset-correction and implemented here: https://github.com/alexandrebarachant/muse-lsl/blob/master/lsl-record.py#L77
That time correction value is vanishingly small when the signal generation and recording processes are running on the same machine (~ 10 x 10^-12). However, apparently, they can make a difference when the LSL streams are originating on different computers.
It would be cool to allow the multi-machine set up and use all of LSL's time synchronization functionality, but I'd hesitate to do anything that would make it more complex to use or break it for BlueMuse on Windows.
I want to get this straight: is there a .NET function to git sub millisecond accurate local system time? If so, I actually think we should consider changing ALL of the timestamps in muse-lsl and eeg-notebooks to local_clock.

There are multiple APIs which can generate submillisecond timestamps in .NET, in fact these APIs may use the exact same system level API that the LSL Boost "local_clock" taps into.

I believe this was fixed in the latest BlueMuse version: https://github.com/kowalej/BlueMuse/commit/25f06e0abb9662f0c6968d9f30544e592b365aa2


reusable value-objects w/ better type safety

I didn't really understand the point of traits until recently and now I can't live without them. And since I didn't find anything about traits on here, I wanted to share my findings. Is this something you are interested in?

In this first example, the two arguments workEmail and personalEmail are switched. But according to the signature of updateEmail, everything is in order since both arguments are of type string:
final class User
{
    public function updateEmail(string $workEmail, string $personalEmail): void
    {
        /* ... */
    }
}

$user = new User();
<EMAIL_ADDRESS>'john_doe@acme.com');

Here we created the value-object EmailTrait to wrap any email-value. But instead of a class, the value-object is a trait. We re-use the trait in WorkEmail and PersonalEmail. Both have the same behavior as EmailTrait but have their own type WorkEmail and PersonalEmail respectively.
trait EmailTrait
{
    private string $email;

    private function __construct(string $email)
    {
        if (!filter_var($email, FILTER_VALIDATE_EMAIL)) {
            throw new \InvalidArgumentException(/* ... */);
        }

        $this->email = $email;
    }

    public static function fromString(string $email): self
    {
        return new self($email);
    }

    public function toString(): string
    {
        return $this->email;
    }
}

final class WorkEmail
{
    use EmailTrait;
}

final class PersonalEmail
{
    use EmailTrait;
}

Now in this second example, the signature of updateEmail is absolutely clear about its argument types and can't be misused:
final class User
{
    public function updateEmail(WorkEmail $work, PersonalEmail $personal): void
    {
        /* ... */
    }
}

$work = WorkEmail::fromString('john_doe@acme.com');
$personal = PersonalEmail::fromString('jonny1337@aolmail.com');

$user = new User();
$user->updateEmail($work, $personal);

This is especially helpful, when there are a lot of primitive values that behave essentially the same, but represent different things in the domain (IDs, postal addresses, event-objects etc.).

Hello,
You can achieve the same result with inheritance.
Can you explain why you prefer to use traits ?

@sebastianstucke87 Because you didn't find any article about traits, here us one that could help to understand more features about traits.
Overriding & Extending a PHP Trait Method | Andy Carter
https://andy-carter.com/blog/overriding-extending-a-php-trait-method

Using traits in Value Objects is an indicator that you are using Value Objects incorrectly. A Value Object is a Minimum Viable Universal Unit, not a Unique Unit. It is not good to create a unique Value Object for each variable (DRY).
An exception can be Value Objects for identifiers for which the uniqueness of the type is important, and the code is almost always identical.
final class Email
{
    private string $email;

    public function __construct(string $email)
    {
        if (!filter_var($email, FILTER_VALIDATE_EMAIL)) {
            throw new \InvalidArgumentException(/* ... */);
        }

        $this->email = $email;
    }

    public function getEmail(): string
    {
        return $this->email;
    }

    public function __toString(): string
    {
        return $this->email;
    }
}

final class User
{
    public function updateEmail(Email $work, Email $personal): void
    {
        /* ... */
    }
}

$user->updateEmail(
    new Email('ohn_doe@acme.com'),
    new Email('jonny1337@aolmail.com'),
);

For more control over the data structure, you can use the Value Object to describe a group of object properties.
final class UserContactData
{
    private Email $work;
    private Email $personal;

    public function __construct(Email $work, Email $personal)
    {
        $this->work = $work;
        $this->personal = $personal;
    }

    public function getWorkEmail(): Email
    {
        return $this->work;
    }

    public function getPersonalEmail(): Email
    {
        return $this->personal;
    }
}

final class User
{
    private UserContactData $contact_data;

    public function changeContactData(UserContactData $contact_data): void
    {
        $this->contact_data = $contact_data
    }
}

$user->changeContactData(new UserContactData(
    new Email('ohn_doe@acme.com'),
    new Email('jonny1337@aolmail.com'),
));

If you are using the Doctrine, then you can describe it through Embeddables.

The topic of traits has already been raised in another issue #130. So far, there are no adequate examples of using traits.
I would also like to see a good example of using traits here.


Removes trailing whitespace in Makefile

Removes the trailing whitespace after the "build :" and "start :" options.

This issue was resolved in another commit.


max_bin and number of unique splits for a feature

For a given max_bin parameter, should one expect at most max_bin / max_bin - 1 unique splits for a single continuous feature across the whole generated forest? @guolinke @chivee

It is true in single tree, but not for the whole forest.
BTW, the max_bin is a limitation of num_bin. For example, for a 0/1 feature, the num_bin of that feature will be 2 even set max_bin to a large number.

@guolinke I have run a fitting procedure (using python lib) with {'max_bin': 63} in Booster params, but after scanning the first tree of the model file I see 99 unique thresholds for feature 251 (snippet with 'split_values' / 'thresholds'
SplitsExample2.txt). For completeness sake, here is the python code parsing unique threshold values
f = open("SplitsExample2.txt")
# parse feature ids
featureLine = f.readline()
featureLine = featureLine[featureLine.find('=') + 1:]
features = [int(x) for x in featureLine.split(' ')]
# parse split values
thresholdLine = f.readline()
thresholdLine = thresholdLine[thresholdLine.find('=') + 1:]
thresholds = [float(x) for x in thresholdLine.split(' ')]
# count unique splits
assert len(features) == len(thresholds), "wrong file"
threshUnique = np.unique([thresholds[i] for i in range(len(features)) if features[i] == 251])
print(len(threshUnique))
print(threshUnique)

This should be sufficient to explain what I am trying to do. If this does not look correct, I can try and produce reproducible example with toy data.

@aftersought
Sorry, I was wrong. unique splits for a feature will be smaller than num_bin only when there is only one features.

@guolinke
Could you please explain in a couple of words, how that works? I am curious because as far as I can see once the Dataset is created all the feature data going in it can be erased. Without recourse to that data, LightGBM can presumable only work with discretized splits (which are presumably limited by max_bin param), and cannot create new splits?
This is also collaborated somewhat by the fact that across a pretty large forest generated on a large dataset (10^8 records) I can only see at most ~1.5 * max_bin splits for a single feature.

For example, assume there are two independent features, A and B.
If the root is split by Feature A, and data is partitioned evenly in its two children. Then in these two subtrees, we both can use Feature B to split independently.
As a result, there is a combination. The total number of unique split is exponentially growth with number of features.

@guolinke
I am not sure we are talking about the same thing. Suppose we have two features, A and B, and max_bin=2. How many unique threshold values for feature A can we see in dataset? For example, if a main node is split by feature A on threshold=1, can the left child then be split on feature A on some other threshold (not 1)? And if yes, where does the value of that threshold come from if the underlying feature data is already erased by the user and Dataset only stores discrete representation (as per docs)?

a simple example with 4 samples, with two features, whose num_bin=2.
Id A B
1 0 0
2 0 1
3 1 0
4 1 1
if root is split by feature A, then there are one split for Feature A, two splits for feature B.
if root is split by feature B, then there are one split for Feature B, two splits for feature A.
So for both Feature A and B, the number of unique splits could be 1 and 2.
if there are 3 feature with num_bin=2, the number of splits of any feature could be 1, 2, 4.
...

Sorry, I think I mis-understand your question.
You are counting the same thresholds in different nodes as the one unique split?

@guolinke Yes, exactly! If they have same feature index.

okay, in that case, it should be smaller than max_bin for numerical features.
I think maybe there are somethings wrong in your training.
I remember we had a bug that the max_bin cannot be passed correctly in python package.
you can try the latest code.

@guolinke My current LightGBM version is 2.0.11. I will try to produce a simpler example then.

@aftersought I remember that issue is fixed after 2.0.11. So you can try the new version I just update today.

@guolinke Unfortunately I still see the same issue with v2.0.12 ('max_bin':63, actual maximum of unique threshold for one of the factors in the very first tree: 81). I will try to produce a minimal example, as I am not sure what am I doing wrong.

@guolinke Here you go
import gc
import numpy as np
import lightgbm as lgb

obs_count = 10000000
factor_count = 10
max_bin = 63

def generate():

    # generate training data
    factors_train = np.random.randn(obs_count, factor_count)
    target_train = np.sum(factors_train, axis=1)
    lgb_train = lgb.Dataset(factors_train, target_train, free_raw_data=True)
    lgb_train.raw_data = None

    # train and save model
    params = {
        'objective': 'regression_l2',
        'learning_rate': 0.01,
        'metric': 'l2',
        'verbose': 0,
        'num_threads': 4,
        'num_leaves': 10000,
        'min_data_in_leaf': 1000,
        'max_bin': max_bin
    }
    booster = lgb.train(params, lgb_train, num_boost_round=1)
    booster.save_model("model.txt")

def check():
    current_tree = None
    features = None
    thresholds = None

    # read the model and find the maximum number of splits
    for line in open("model.txt"):
        if line.startswith("Tree="):
            current_tree = int(line[line.find('=') + 1:])
        elif line.startswith("split_feature="):
            if not current_tree:
                continue
            # parse feature ids
            line = line[line.find('=') + 1:]
            features = [int(x) for x in line.split(' ')]
        elif line.startswith("threshold="):
            if not current_tree:
                continue
            # parse split values
            line = line[line.find('=') + 1:]
            thresholds = [float(x) for x in line.split(' ')]
        elif len(line) <= 1:
            # count unique splits for each factor
            if features and thresholds:
                assert len(features) == len(thresholds), "wrong file"
                for f in range(factor_count):
                    thresholds_unique = np.unique([thresholds[i] for i in range(len(features)) if features[i] == f])
                    if len(thresholds_unique) > max_bin:
                        print("Factor {} has {} unique splits in tree {}".format(
                            f, len(thresholds_unique), current_tree))
                        print(thresholds_unique)
                        return False
            # reset for next tree
            current_tree = None
            features = None
            thresholds = None
    return True

generate()
check()

My observation is that there are never more than (2 * max_bin) unique splits.

@aftersought
I run your code many times, and it always return True.

@guolinke Apologies, this was for an older version of the package. I have updated the code in place for the last version, please check.

@aftersought
you didn't pass params to Dataset object. As a result, the max_bin is not be passed.
@StrikerRUS @wxchan Do you think we should pass the params in lgb.train to non-constructed Datasets ?

@guolinke Yes, that solves it for the test (and presumably for my main dataset. will check). Were params always part of Dataset constructor? Anyway, thanks for checking.


Sample code and HOL are out of date

This section from page 10 of the HOL (with code demonstrating it in Exercise2/Step09) shown below references a deprecated function ForEach which will not compile. What is a correct blocking operator to use? Do()? In old versions of the HOL it used a Run() blocking operator, which doesn't exist.
IObservable<int> source = Observable.Range(0, 10);

source.ForEach(
  x  => Console.WriteLine("OnNext:  {0}", x),
  ex => Console.WriteLine("OnError: {0}", ex.Message),
  () => Console.WriteLine("OnCompleted")
);
`

@gardnerbp to be honest, I'm not really sure why it should be anything more than a Subscribe here. Would you be interested in submitting a PR to update it?

Sure, would love to get the documentation more up to date. Probably best if I work my way through the entire HOL to see if there are other anomalies first tho'.

Closing due to inactivity.


Path variables are not compatible with API Gateway

Description
It is possible to extract variables from path when using sam local start-api but not all supported cases are valid for deployment to AWS API Gateway.
Steps to reproduce
Create lambda and SAM template to be triggered by path with variables:
TheFunction:
    Type: AWS::Serverless::Function
    Properties:
      CodeUri: .
      Handler: app.lambdaHandler
      Runtime: nodejs8.10
      Events:
        Aliases:
          Type: Api
          Properties:
            Path: /{product}/prefix_{type}_suffix/{id}.json
            Method: get

Start local API and invoke URL http://<IP_ADDRESS>:3000/good-stuff/prefix_type_A_suffix/123.json
You can see that path parameters were successfully parsed:
console.log(event.pathParameters);
{ product: 'good-stuff', type: 'type_A', id: '123' }

But when trying to deploy such template to API Gateway you will get error Resource's path part only allow a-zA-Z0-9._- and curly braces at the beginning and the end.
Observed result
All works fine!
Expected result
I'd expect SAM CLI to tell me that such format is not supported.
As a workaround, you have to define path like /{product}/{param_with_type}/{id_with_extension} and parse variables out of path parameters, or just setup proxy integration and parse path parts on you own (or by some framework which will do all the routing for you), which is fine as such path variables are not supported in AWS API Gateway now, as far as I know.
Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

OS: Windows
sam --version: SAM CLI, version 0.11.0

It is a a year later but I get the same error about the path when deploying a SAM template that includes "Path: "/users/{+proxy}"". Is this not possible?

@napter did you try: "Path: /users/{proxy+}"? That should work better.


Handle saved color overflow in basic color picker

Feature Description
Display scrollbar (correctly scrolling all but the header and the close-icon) in basic color picker if contents overflow due to too many saved colors.

Normal
Overflow

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Updated files

It looks like the behaviour is almost as expected already now. The improvements could be the following:

Consider admin bar -- currently the header part of the color picker can get hidden behind it
Ensure only unique custom colors can be added, currently allows duplicates (might deserve its own issue but I'm planning to fix this since I'm already working on the color picker anyway)

Verified in QA


Upgrade to Expo SDK 47

Why
Expo SDK 47 was launched. This upgrades Snack to SDK 47 and drops support for SDK 44.

Whenever SDK 47 is launched, I'll update the dependencies and merge this PR.
Done!

What still needs to be done:

Release new snack-content and snack-sdk packages on npm
Update website to use SDK 47 by default
Update Appetize with the latest Expo Go versions for SDK 47

How
Followed upgrade guide
Test Plan
See staging

Tested a bunch of snacks to validate that this change works:

https://staging.snack.expo.dev/@bycedrictest/snackforthat-elastic-scroll
https://staging.snack.expo.dev/@bycedrictest/snackforthat-three-3d-playground
https://staging.snack.expo.dev/@bycedrictest/snackforthat-gesture-handler-playground
https://staging.snack.expo.dev/@bycedrictest/snackforthat-nativewind -> web support seems limited, and no refresh after change (reload does work)
https://staging.snack.expo.dev/@bycedrictest/snackforthat-react-navigation
https://staging.snack.expo.dev/@bycedrictest/snackforthat-twitter-splashscreen -> no web support


What's the test period when testwhileidle=true?

Expected behavior
Keep connections in Jedis pool alive and not be killed by Redis server. Our Redis server turn on timeout function, i.e., when a connection is idle for, e.g., 1 minute, Redis server will consider it timeout and close connection. However at client side Jedis doesn't know this.
Actual behavior
I cannot find any information about the period of testWhileIdle, I'd like to make sure that Jedis will test the connection in period <1 minute, such that My Redis server won't kill my connection in Jedis pool

It's a property of Apache Commons-Pool
see: https://commons.apache.org/proper/commons-pool/apidocs/org/apache/commons/pool2/impl/BaseGenericObjectPool.html#getTestWhileIdle--


Missing Documentation on the Autotuner

Hi,
Under docs/ I don't seem to find documentation on Shark's autotuner. Is there any documentation/notes/tutorials on what the optimization/tuning space is like, which MLIR dialects are optimized in the tuning process, and directions on how to use your own models for tuning with Shark? Also, is there any evaluation data on NNs including language models?
-Hashim

Hi, does anyone have any pointers on this documentation?


Duplicated INI entry fixes

INI values no longer duplicate and are correctly represented on Server start when configs are updated. This should fix the issues people were having with RCON, it was working for me when I built it.
For easier testing, I also added the Update config trigger when the save buttons are pressed when adding additional settings through text in the multipliers tab as well as when saving the config in the administration.

Good spot on the Append. LGTM.


Can The HTML Reporter Output Single Inline HTML Index File

I was wondering if there was a way to output a single index.html file (that has all the required CSS/JS as well) when using the HTML reporter option.  Currently, since our source code is included in the Coverage JSON file, it produces sub-directories with its own index.html, CSS, JS, etc..
The use case is that I would like to upload the resulting single HTML file to a Google Could Storage bucket for anyone with access to view directly from the link.  Since GCS is not a true file system, simply uploading all the files that are produced will not work.
Is this possible to do or do you know any tools that would make this inline merge work?  Thank you for your time! Your tool is awesome btw.

@gowritharanmageswarasc sorry for the slow reply! have been more busy with work and life stuff than usual over the past few months.
I like this idea! one thought that comes to mind, is that it would be nice if reports in general were more configurable -- make it easier to provide your own report.
Would love help thinking about how to implement this (and implementing it). The repo we will be working in is actually here.
We have a community slack now if you feel like talking about this feature.


Enhancement: Ability to upload .csv onto change queue and auto accept

As a user of AIMS I want the ability to simply add multiple items to the change queue from a correctly formatted .csv and have them automatically accepted
Users will need to add or modify addresses.
For modify, any parameter of the address could be modified (e.g. position type).
The developer will need to advise the required format of the .csv.
The purpose of this enhancement is to facilitate data quality improvement work.
Note, this is similar to https://github.com/linz/QGIS-AIMS-Plugin/issues/207 except that I need the items to be automatically accepted rather than the user accepting each one individually.
The reason for this is that I have been made aware of a bulk load of 65,000 addresses. There may be more large bulk loads.
I still need https://github.com/linz/QGIS-AIMS-Plugin/issues/207.

I am currently able to accept 10 addresses per minute. To accept 65,000 addresses would take 108 hours.

Concerning those to be modifying - Will the AIMS feature Id of the address to be modified be supplied in the .csv?

Tell me what the .csv needs.
Would it be more practical to have two tools? One for adds only, one for modifys?

One tool would be desirable as long as the .csv is explicit as to the actions of each record.
There will need to be a sit down to understand the requirements. currently I am unsure of my availability for this piece of work and as mentioned in #207 I will follow this up Monday.

The requirement is to have a method to load changes onto the queue and either accept them or leave them on the queue.
This method can be accessed by the users using execute via command line.
Users will be limited to senior addressing analysts, i.e. myself and @jason-bedford
The input file will be a .csv file. I will create an example .csv for @SPlanzer to review before development commences. It must include;

Action (add/mod)
New Status (proposed, current, historic)
Address ID
Every field (new values populated for edits/adds, existing values populated for fields that aren't changing)
Accept ('t' = accept, 'f' = leave on queue)

If a change fails API validation, it will remain on the queue.
@SPlanzer estimates effort at:
1 week full time to develop
1 week 35% of time to support testing and deploy

@SPlanzer , @Deb-Jones ,
thanks, just let you know that I've seen your last update in proposal.

Hi @deb I will start this this week.
As a first step we need an example csv file so that we can ensure we both agree on the files format that will be read and processed.
If you have one please share it else I will create and share one as part of project initiation.

The beginning of a test .csv  can be created with the below SQL.
@Deb-Jones, please see attached an example of a csv I will use for development. Please review this to ensure this is inline with what you are able / expect to provide to a cmd line tool.
note this very simple and only attempts a few simple new, retire and update cases. As development progreses I will create more complex examples.
SELECT
      'NEW' as action, --one of ('NEW', 'DEL', 'UPD')
       true as auto_accept, -- Boolean
       addressid,
       addressableobjecttype,
       ST_ASTEXT(addressableobjectaddressposition),
       addresstype,
       unittype,
       unitvalue,
       leveltype,
       levelvalue,
       addressnumberprefix,
       addressnumber,
       addressnumbersuffix,
       addressnumberhigh,
       roadprefix,
       roadname,
       roadtypename,
       roadsuffix,
       waterroutename,
       watername,
       addressableobjectpositiontype,
       'this is a test' as comment
  FROM
        aims_stage.address_publish
  WHERE
        latest = true
  LIMIT 40

example.csv.txt
*Note: GitHub doesn't support attaching .csv. It may be simpler to open in spreadsheet tools if you drop the ".txt"

The repository for development is to be the address data quality repo
please track any issues here

Also note all references to DEL are now 'retire' to reduce any confusion by having the semantics reflect the system's actions.
therefore actions in the spreadsheet shall be one of:

new
retire
update

@Deb-Jones I will be ready to test this tomorrow.
First I will need to do some ground work to get you access to the AIMS installation on the LI-experimental server. It would be good to have some of your time the second half of this week to run the solution by you and get some testing done

This is with @Deb-Jones for testing.
I am closing the dev ticket. Enhancements and bugs to be tracked against code repo

Thanks @SPlanzer .


Synthesize different core versions

Synthesis and verilog generation are currently kinda copy-pastey, and that's fine for now - cleaning this up (maybe unifying the two?) can be done later.
Fixes #402.

Action run is here: https://github.com/kuznia-rdzeni/coreblocks/actions/runs/5424401768
There is surprisingly little difference between basic and full configurations, which is weird. However, the carry, RAM and DFF fields are different, and the synthesis time for full was longer.

By the way: current configurations look weird. In particular, the ROB is quite large (128 entries) compared to RS sizes (4 and 2 entries).


[JENKINS-51876] inform about using a deprecated constructor

JENKINS-51876

Adds a log message on deprecated constructors
Deprecate constructor that should be deprecated also

my idea, it is to keep them for a couple of version and start to remove the old ones.


1:1 pvp mechanics 1.8

I talked to some people and perhaps 1:1 does not make the most sense. A lot of people like custom knockback. I am closing this for now.


Initial BQ system tests

Uses #1046 as a base.

Lint angry with long lines.

Rebased after landing #1046.

LGTM (please file issue / find other way to follow up with the protected access)


Organize Arguments (for documentation and paper writing)

Work with Alexander to write out all possible arguments.
Questions:
a) are there arguments that can go together, and some that can't?
b) can we get examples of all forms of triples representation?
Users should be able to extract everything from minimal triples, to enhanced triples, to everything in between.

"add_aux" flag for extracting future and past tense


Unlock environment variables

Description

Any environment variable can be added in the template without getting removed by the operator
Operator controlled env variables can be set from the template. The operator will set only the empty ones.
Common environment variable handler function

Breaking change:
If a variable must be set by the operator, then the variable has to be removed from the template, or the value should be empty.
Issue link
/
Checklist

Purpose

[ ] Bug fix
[x] New functionality
[ ] Documentation
[x] Refactoring
[ ] CI

Test

[x] Unit test
[ ] E2E Test
[x] Tested manually

Introduce a breaking change

[x] Yes (description required)
[ ] No

I haven't tested it, but looks good to me.


Index result query to meilisearch

Closes #7
What's inside this PR ?

Addition of a transformer function inside the plugin options, to transform the data to the correct format before indexing it
Indexing of the data & error log if it occurs
Update of the front-end to retrieve & display the indexed data
Removal of the test testing the article list, as the playground homepage has changed, and this point is going to be done in #8
Documentation update (CONTRIBUTING.md and README.md)

How to test ?
You can test with a MeiliSearch running in local, or by providing a .env file inside the playground folder with the following environment variable :
GATSBY_MEILI_SERVER_ADDRESS
GATSBY_MEILI_API_KEY
GATSBY_MEILI_INDEX_NAME

Then, run:
yarn playground:build // Generate a single build
or:
yarn playground:dev // Generate a build with watch mode

Screenshots

🔥🔥🔥 Good job, I have some questions and changes suggestions
Should skipIndexing be added in this PR?
The tests will be added in the next PR?

I'm following the plan we built together, which can be found here.
The skipIndexing option shouldn't be long, so I can add it to this PR if you prefer.
As for the testing, I prefer to keep it in a next PR as it is going to be a huge one, and I don't want this one to become unreadable :)


Add retry on fetching basebackup

Steps to reproduce
Make connection between pageserver and compute unstable, try to start compute
Expected result
It retries until it works
Actual result
It errors out saying "failed to fetch basebackup".
Environment
Logs, links

Made PR: https://github.com/neondatabase/neon/pull/6537

Merged

It's released


no header.sh

${SOURCE_CODE_HOME}/build/script/download-spark.sh
source $(cd -P -- "$(dirname -- "$0")" && pwd -P)/header.sh
there is no header.sh file

If you want to download spark, you can using the following command:
wget https://download-resource.s3.cn-north-1.amazonaws.com.cn/osspark/spark-2.4.1-os-kylin-r3.tgz

This script is using for binary package, you can download spark with this script after packaging. Then spark will be decompressed to ${KYLIN_HOME}/spark
${KYLIN_HOME}/bin/down-spark.sh


What do you think of adding a templating engine?

Hello,
Looking at the GRCPool code, there is html in classes, some Bootstrap widget classes and of course views.
It seems we could extract the html using a templating engine. Twig is quite capable. Bootstrap components can be implemented as macros, and views would extend a layout page (replacing html in GrcPool_WebPage ->display()).
What do you think? I would be willing to give it a shot.

Hi, a templating engine would be better for sure. I am moving the repo to the community site and pulled some of the functionality out of it to make it simpler for collaborating and if somebody wants to make their own pool. So that repo would be best to use...


Ability to document class instances better

Example:

/**
 * Checkit is used for validation
 * @see {@link https://github.com/tgriesser/checkit}
 * @class
 */
var Checkit = require('checkit');

/**
 * @classinstance
 * @classdesc validates an object
 * @property {Function} run - executes the validation, returns a promise
 * @throws Checkit.Error
 * @returns {Promise}
 * @see {@link https://github.com/tgriesser/checkit#checkitrun}
 */
var validate = new Checkit({})

Why not just use @type {Checkit}, which indicates that validate is a Checkit instance?

 validate :Checkit
Output:
validates an object
Type:
Checkit
Properties:
Name	Type	Description
run	function
executes the validation, returns a promise
Ignores the returns, throws, see.
Is there anyway to add those?

I took a closer look at your example. I'm not sure the docs you have right now are correct--presumably it's the Checkit instance's run method, and not the instance itself, that returns a promise.
The normal way to document this in JSDoc-land would be to just document Checkit (including its run method) and indicate that validate's type is Checkit, as I suggested. Something like this:
/**
 * Checkit is used for validation.
 * @class
 * @see {@link https://github.com/tgriesser/checkit}
 */
var Checkit = require('checkit');

/**
 * Run the validator.
 * @function Checkit#run
 * @param {Object} obj - The object to validate.
 * @returns {Promise}
 * @see {@link https://github.com/tgriesser/checkit#checkitrun}
 */

/**
 * Validator.
 * @type {Checkit}
 */
var validate = new Checkit({});

If I understand correctly, you want JSDoc to automatically show that validate has a method called run, and to display all the docs for that method in the same place as validate. It's true that, at the moment, there is no convenient way to do that for class instances. I'm not sure a @classinstance tag is the best way to solve the problem, but I think I get what you're asking for now. (If I'm incorrect, please let me know.)

This is exactly what I'm looking for.
Also, after running the example above, unfortunately I'm still not seeing the param, returns, and see.

Yes, that's because nobody has implemented this feature request yet. :)


Feat: a hook

I'd like to provide you with a comprehensive React hook solution.
Key features:

supports React 16.x and 17.x

I'm going to support 18.x, but hook testing library still does not work well with it

integration with a generated client
conditional requests
watching for variable updates
refresh on demand
cache

with a TTL
customizable implementation

with a customizable error handling

this actually has to be either another package or a part of the generated code, along with the client.


Fixed typo on README.md file

wil -> will

Issue #, if available:
Description of changes:
There are two simple typo. wil on README.md (line number 156, 157) should be will
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for your contribution~~~