Output the currency value as floating point number to Survey Data JSON

When using the third-party inputMask-widget (https://github.com/RobinHerbots/inputmask) it should be supported to output currency values as consistent floating point numbers to Survey Data JSON (only when autoUnmask property is set). Until now currency values are always stored as string within Survey Data JSON.

Setting unmaskAsNumber to true (https://robinherbots.github.io/Inputmask/#/documentation/numeric) should solve that issue.


database/sql: transaction leak

What version of Go are you using (go version)?
go version go1.11 darwin/amd64
postgresql 10.5-1.pgdg90+1 in docker
// postgres.conf
max_connections = 1000                  # (change requires restart)
idle_in_transaction_session_timeout = 5000      # in milliseconds, 0 is disabled

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/nzlov/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/nzlov/workspace/go"
GOPROXY=""
GORACE=""
GOROOT="/Users/nzlov/program/go"
GOTMPDIR=""
GOTOOLDIR="/Users/nzlov/program/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/_9/6616bz990gb21ds_kw9tv1x40000gn/T/go-build672159973=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Sorry.I don't know.  Use revel v0.13.1 and gorm. Maybe #22976.
What did you expect to see?
Rollback the transaction
What did you see instead?
The transaction hangs up and massive db lock wait timeouts
No Commit Error.
No Rollback Error.
debug/pprof
55 @ 0x42dd8b 0x42de33 0x405a5e 0x40574b 0x6e6d4b 0x45bb71
#	0x6e6d4a	database/sql.(*Tx).awaitDone+0x4a	/Users/nzlov/program/go/src/database/sql/sql.go:1914

2 @ 0x42dd8b 0x43dd6d 0x6e1c18 0x45bb71
#	0x6e1c17	database/sql.(*DB).connectionOpener+0xe7	/Users/nzlov/program/go/src/database/sql/sql.go:1001

2 @ 0x42dd8b 0x43dd6d 0x6e1d4b 0x45bb71
#	0x6e1d4a	database/sql.(*DB).connectionResetter+0xfa	/Users/nzlov/program/go/src/database/sql/sql.go:1014

postgres in docker

999 | 5880 | 5858 | 0 | 09:58 | ? | 00:00:01 | postgres
-- | -- | -- | -- | -- | -- | -- | --
999 | 6021 | 5880 | 0 | 09:58 | ? | 00:00:01 | postgres: checkpointer process
999 | 6022 | 5880 | 0 | 09:58 | ? | 00:00:00 | postgres: writer process
999 | 6023 | 5880 | 0 | 09:58 | ? | 00:00:02 | postgres: wal writer process
999 | 6024 | 5880 | 0 | 09:58 | ? | 00:00:00 | postgres: autovacuum launcher process
999 | 6025 | 5880 | 0 | 09:58 | ? | 00:00:02 | postgres: stats collector process
999 | 6026 | 5880 | 0 | 09:58 | ? | 00:00:00 | postgres: bgworker: logical replication launcher
999 | 6167 | 5880 | 0 | 10:00 | ? | 00:00:06 | postgres: postgres shanshou <IP_ADDRESS>(40332) idle
999 | 6556 | 5880 | 0 | 10:06 | ? | 00:00:00 | postgres: postgres shanshou <IP_ADDRESS>(57254) idle
999 | 6557 | 5880 | 0 | 10:06 | ? | 00:00:00 | postgres: postgres shanshou <IP_ADDRESS>(57255) idle
999 | 8926 | 5880 | 0 | 10:30 | ? | 00:00:00 | postgres: postgres shanshou <IP_ADDRESS>(51001) idle
999 | 8927 | 5880 | 0 | 10:30 | ? | 00:00:00 | postgres: postgres shanshou <IP_ADDRESS>(51002) idle
999 | 8944 | 5880 | 0 | 10:31 | ? | 00:00:00 | postgres: postgres shanshou <IP_ADDRESS>(51019) idle
999 | 9666 | 5880 | 0 | 10:39 | ? | 00:00:03 | postgres: postgres shanshou <IP_ADDRESS>(47046) idle
999 | 9718 | 5880 | 0 | 10:39 | ? | 00:00:00 | postgres: postgres shanshou <IP_ADDRESS>(53736) idle
999 | 11696 | 5880 | 0 | 10:59 | ? | 00:00:11 | postgres: postgres shanshou <IP_ADDRESS>(42800) idle
999 | 11715 | 5880 | 0 | 10:59 | ? | 00:00:11 | postgres: postgres shanshou <IP_ADDRESS>(42836) idle
999 | 14587 | 5880 | 0 | 11:13 | ? | 00:00:00 | postgres: postgres shanshoulog <IP_ADDRESS>(37358) idle
999 | 16079 | 5880 | 0 | 11:32 | ? | 00:00:00 | postgres: postgres shanshou <IP_ADDRESS>(45886) idle
999 | 16081 | 5880 | 0 | 11:32 | ? | 00:00:00 | postgres: postgres shanshoulog <IP_ADDRESS>(45888) idle
999 | 17133 | 5880 | 0 | 11:46 | ? | 00:00:00 | postgres: postgres shanshou <IP_ADDRESS>(41586) idle
999 | 17178 | 5880 | 0 | 11:46 | ? | 00:00:00 | postgres: postgres shanshou <IP_ADDRESS>(41634) idle

I'll look into it.

What postgres database driver package and version are you using?

I don't think there is sufficient information here to work from.
I'll need:

The postgresql Go driver package and version you are using.
A sample code, or description of the code that duplicates this issue. If filed on the golang issue tracker, it would be best to not require the gorm dependency.

Feel free to ping this same issue with details and I'll re-open.


Bump version # to 6.4.2

Codecov Report

Merging #1048 (66518b3) into master (2a2330c) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 66518b3 differs from pull request most recent head f9721cf. Consider uploading reports for the commit f9721cf to get more accurate results

Flag
Coverage Δ

packit-e2e
68.64% <ø> (ø)

testsuite
49.59% <ø> (ø)

unittests
13.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


[espresso] [video_player] Update espresso guava version

Updates the guava version in espresso to use the latest stable version: https://github.com/google/guava
In https://github.com/flutter/plugins/pull/5011, the exoplayer version in video_player was increased. This made it incompatible with the espresso plugin. And this broke image_picker which depends on espresso and video_player.
For image_picker:
No version change: Only updating espresso dev_dependeny for CI.
No CHANGELOG change: Only updating espresso dev_dependeny for CI.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

landing on red to fix CI


deps: update com_google_cel_cpp (#22315)

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

This is only needed if we don't get a fix for the antlr4 in a sensible timeframe
I'd rather minimise local changes to our envoy fork if we can, just to make our life easier when we version shift


Fix: Expense - Not here page shows up briefly when deleting the expense

Explanation of Change

This PR will not here page briefly appears when deleting the expense by navigating to target url then perform actual delete when the report details unmounted.
Fixed Issues

$ https://github.com/Expensify/App/issues/45576
PROPOSAL: https://github.com/Expensify/App/issues/45576#issuecomment-2309556187
Tests

Open App
Go to DM.
Submit two expenses to the user.
Open any of the transaction thread.
Tap on the report header.
Tap Delete expense..
Delete the expense.
Verify Not here page will not show up when deleting the expense.
Verify [Deleted Expense] text not shown in report details page

[X] Verify that no errors appear in the JS console

Offline tests

Same as test
QA Steps

Same as test

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/d19a4fed-3024-44a6-8ccc-b6325749df4a

Android: mWeb Chrome
https://github.com/user-attachments/assets/9102a78d-2d3c-4264-a707-16475c80a535

iOS: Native
https://github.com/user-attachments/assets/a3599a80-78f5-48fd-a7a6-a9d30a916909

iOS: mWeb Safari
https://github.com/user-attachments/assets/25ff0228-3140-45ce-82d9-68eaa7425b5c

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/eb0fd82b-2afc-4b0f-bfa0-ca7f59643479

MacOS: Desktop
https://github.com/user-attachments/assets/855184ac-a02e-4e9a-ac16-c0ffdb191f55

TS is also failing

@luacmartins @alitoshmatov do you know why this error shown? seems not directly related with the PR

@wildan-m
When expense has a comment, navigation is behaving a little bit different. When you delete the expense:

Modal is closing
Existing expense page is shown
Then Expense report is shown

I think this is too much, can't we just navigate to the final page instantly?
https://github.com/user-attachments/assets/d847b408-d81f-43dc-bf9e-e3455c088032
https://github.com/user-attachments/assets/eee8eccc-f2ab-439a-b4d5-8e3d0533648d

@alitoshmatov Thanks for your feedback I've got this loading error in dev and staging
Seems BE?
Unexpected error deleting this expense. Please try again later
https://github.com/user-attachments/assets/88bb7c2e-537e-43eb-ba9d-aba0972c6c11
I'll try to fix the issue after that BE issue resolved

@wildan-m is that consistently reproducible? Do you have a requestID for a failing request?

@luacmartins yes, it consistently reproduced, I think it's FE.
Asking if anyone else has experienced the same.
https://expensify.slack.com/archives/C01GTK53T8Q/p1732632553483729

@alitoshmatov can you retest with this new merged main? I can't reproduce your mentioned issue I can only reproduce the loading issue which is also occurred in staging.

@wildan-m When expense has a comment, navigation is behaving a little bit different. When you delete the expense:

Modal is closing
Existing expense page is shown
Then Expense report is shown

@alitoshmatov actually that behavior is current main behavior, we can't see that clearly because it's deleting and navigation fast. If we throttle the CPU, we'll see it better
https://github.com/user-attachments/assets/0d3acf1f-8e34-47e7-9311-4bfd399bc5ee
Should we change that behavior?

Also, I've noticed that isDeletedParentAction returned by DeleteMoneyRequest API is false, where it expected to be true

I found the backend bug for this. I'll work on a fix.

IIRC the expected behavior if there is a comment when deleting expense is -- it should navigate to the existing expense page, not the parent report. @luacmartins do you know if the expected behavior changes?

It seems like the behavior has changed as you mentioned.

@alitoshmatov actually that behavior is current staging behavior, we can't see that clearly because it's deleting and navigation fast. If we throttle the CPU, we'll see it better

I see

if there is a comment when deleting expense is -- it should navigate to the existing expense page, not the parent report

So we decided the behavior should be as you said, right?

That's my understanding

@luacmartins @alitoshmatov should we fix the behavior that accidentally changed by this PR https://github.com/Expensify/App/pull/45563 here?

I don't think we should change that as part of this PR. If we decide to change it, we should do so in a separate one.

I don't think we should change that as part of this PR. If we decide to change it, we should do so in a separate one.

@luacmartins @alitoshmatov Then should this behavior  be accepted, since the navigation successfully takes us to the correct screen, but then the useEffect in ReportScreen re-navigates us to the parent report. Right?

Yes, I agree.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/ccef5ec9-8deb-47a0-8b0f-86da812f674b

Android: mWeb Chrome

iOS: Native

https://github.com/user-attachments/assets/a5cda677-3ccd-4c63-976e-8c43e81cd49f

iOS: mWeb Safari

https://github.com/user-attachments/assets/28895c2f-e26c-470f-af50-8558b3eb40ee

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/7f3a6f9d-cc93-471c-97d4-ec4a6614f3d8

MacOS: Desktop
https://github.com/user-attachments/assets/be15d6ab-59e1-4276-aa65-385ce5220b64

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@luacmartins @alitoshmatov I just remember that there is a feedback on successData regarding similar pattern we use here. To avoid similar issue should we patch this PR a bit? we'll make the success data to null instead. Here is the patch https://github.com/Expensify/App/pull/53616


Re-read /etc/hosts upon change

Re-read /etc/hosts periodically in DefaultHostsFileEntriesResolver
Motivation:
io.netty.resolver.DefaultHostsFileEntriesResolver parses /etc/hosts only once, upon creation.
With these changes DefaultHostsFileEntriesResolver will periodically re-read configuration.
Modification:

Made HostsFileEntriesProvider.Parser dependency injectable via constructor to be able to test my changes
Added entries expiry check and re-read before resolving addresses
address now uses addresses function inside

Result:
DefaultHostsFileEntriesResolver now re-reads data from hosts file every 10 seconds.
Fixes #.
#11661

@comchi did you sign our ICLA yet ? https://netty.io/s/icla

@normanmaurer yes, I signed it yesterday


53005 "DNS resolution for signaling failed"

I am getting this error from delegate when I try to connect room via valid token and valid room name for video call
func roomDidFailToConnect(room: Room, error: Error) {
Error Domain=com.twilio.video Code=53005 "DNS resolution for signaling failed" UserInfo={NSLocalizedDescription=DNS resolution for signaling failed}
}
how to solve this problem?
what is reasons of this error?

Lets use the other issue you filed: https://github.com/twilio/twilio-video-ios/issues/91


Add support for adding virtual-network-links outside of private-dns-zone creation

Description

Add a sub-module for creating virtual-network-links in a separate landing zone and not as part of private-dns-zone creation
Sometime private-dns-zones and vnets are not created together in the same even landing zone or even same level. Separating the vnet-link module would enable users to create vnet-links in a separate lz linking the dependencies

Dependencies

This requires changes in https://github.com/Azure/caf-terraform-landingzones repository. PR to merged for these changes to work: https://github.com/Azure/caf-terraform-landingzones/pull/251

Testing

Added a sample config tfvars file to  showcase the usage

Issue: https://github.com/aztfmod/terraform-azurerm-caf/issues/672

Can you add the example in the pipeline? Then we are good to merge
https://github.com/aztfmod/terraform-azurerm-caf/blob/patch.5.4.3/.github/workflows/standalone-scenarios.json


drop Scala 2.10

👍  Dang, it does look like play-json is lagging. I wonder if they have an equivalent in Lagom.


[BUG] Resource not found in Microsoft Graph: https://graph.microsoft.com/beta/deviceAppManagement/mobileApps/807c5fc5-7e4c-4a57-b919-4f1fc8139e0f

Describe the bug
Since 16.11 I am receiving following error "Resource not found in Microsoft Graph: https://graph.microsoft.com/beta/deviceAppManagement/mobileApps/807c5fc5-7e4c-4a57-b919-4f1fc8139e0f"  when running IntuneCD backup like:
IntuneCD-startbackup
--mode=1
--output=json
--path="$(Build.SourcesDirectory)/$(BACKUP_FOLDER)"
--exclude CompliancePartner ManagedGooglePlay
--append-id
--ignore-omasettings
Screenshots

Run type (please complete the following information):

Mode: 1
Client Azure Pipeline
Version Latest

It looks like it's trying to retrieve an app configured on an Enrolment Status Page configuration that does no longer exist. Can you verify you do not have any old removed apps still present in the ESPs?

Seems like it. I was having same idea, but esp gui showed just existing apps. Anyway when I made some random edit, save esp profile and run backup again, issue was solved. So I guess there was some missing app (but gui didn't show it).
Anyway some try catch for such cases would be helpful.


Loading future DASH segments in v4.x

Have you read the FAQ and checked for duplicate open issues?
yes - this is (probably) identical to (closed) Ticket 3717
What version of Shaka Player are you using?
3.3.1
Can you reproduce the issue with our latest release version?
yes
Can you reproduce the issue with the latest code from master?
didnt check
Are you using the demo app or your own custom app?
both
If custom app, can you reproduce the issue using our demo app?
yes
What browser and OS are you using?
Chrome/Edge/Firefox
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
n/a
What are the manifest and license server URIs?

https://sdn-global-streaming-cache.3qsdn.com/24666/files/21/10/11/3960246/24666-GVQnP7CqzRgXNDW.ism/manifest.mpd
What configuration are you using?  What is the output of player.getConfiguration()?

{"preferredAudioLanguage":"auto","abr":{"enabled":true,"switchInterval":6},"manifest":{"disableText":true},"streaming":{"smallGapLimit":1,"jumpLargeGaps":true,"ignoreTextStreamFailures":true,"useNativeHlsOnSafari":false}}
What did you do?

Loading the Manifest "https://sdn-global-streaming-cache.3qsdn.com/24666/files/21/10/11/3960246/24666-GVQnP7CqzRgXNDW.ism/manifest.mpd" to the Player
What did you expect to happen?
The Video should be played until the end and then stop
What actually happened?

I already had an own Ticket on this - and Ticket 3717 was dealing with this too (but is closed now). From my Understanding, this should have been fixed in 3.3.1 - but it clearly isnt.
SHAKA starts to load non-existing ("phantom") Chunks like:
https://sdn-global-streaming-cache.3qsdn.com/24666/files/21/10/11/3960246/24666-GVQnP7CqzRgXNDW.ism/dash/24666-GVQnP7CqzRgXNDW-audio=128000-150.m4s
https://sdn-global-streaming-cache.3qsdn.com/24666/files/21/10/11/3960246/24666-GVQnP7CqzRgXNDW.ism/dash/24666-GVQnP7CqzRgXNDW-video=2793000-150.m4s
which leads to 404 - for some reason, it never stops requesting them, what leads to a ton of issues in the CDN, as millions of requests are processed there for non-existing Material.
This is ONLY happening in DASH, not in HLS.
(compare the HLS Manifest: https://sdn-global-streaming-cache.3qsdn.com/24666/files/21/10/11/3960246/24666-GVQnP7CqzRgXNDW.ism/manifest.m3u8)

Got this problem too. The main reason is that your Dash manifest is using Segment Template, where segments created based on  duration and timescale . For some reason, when combine with certain content it will generate "phantom" segment like that at the end of the content duration.
You can change your origin (unified streaming) setting to not use Segment Template (using byte-range for example) and the problem will gone.

Thanks for that insight. Ill talk with the backend team, if thats possible. But im sure, Shaka will fix this soon 😉

Can you test with v4.3.3? Thanks!

@shaka-bot reopen

Sorry, I did not see the last Comment on this before.
I sadly must confirm, that nothing changed - the given DASH URLs above still dont work, the same (non-existing) Chunks are trying to be loaded and the Player dies.

Hi @avelad, looks like this is happening to us, too. We're using the latest Shaka version. I'll share a manifest that has the problem.

@Canta, thank you for your insights.  We will work on this when we have time, but the team is very much overloaded these days.  It may be best for someone else in the community to investigate and try to determine the root cause.

@joeyparrish , I've been doing a quick search on the code, but I'm also on a tight agenda, so can't do much about this right now. Here are some notes nonetheless:

The original problem and mine looks the same, but I now realize that @boredom2 manifest is VOD, while mine is LIVE. That's static vs dynamic, and they have different logics. So most likely this is not the same issue. For the time being, I see no problem in using this ticket to analyze both, but the original problem looks like a "end + 1" problem, while mine is a jump in time.

I can see in lib/media/presentation_timeline.js this code for getting live edge timestamps:

  getLiveEdge_() {
    goog.asserts.assert(this.presentationStartTime_ != null,
        'Cannot compute timeline live edge without start time');
    // Date.now() is in milliseconds, from which we compute "now" in seconds.
    const now = (Date.now() + this.clockOffset_) / 1000.0;
    return Math.max(
        0, now - this.maxSegmentDuration_ - this.presentationStartTime_);
  }

That means there's 3 variables involved: now, start time, and max segment duration. Given that both times don't change (my clock is fine, and manifest start time only changes after restarts that didn't happened), I suspect something may be happening with the max segment duration calculation.
If you take a look at the manifest I've uploaded before, you can see the video and subs chunks are all repeated with the same duration, but audio is not. That's because the chunk duration (6 seconds) is a multiplier of the video GOP times, but not a multiplier of the audio cutting times. And if you take a look at the screenshots, the rendition with trouble is the audio one being played. So perhaps max segment duration is doing something wrong, altering the live edge timestamp in a way the player jumps in time.
Another posibility of the same problem would be that clockOffset_ variable, affecting now. IDK where that offset comes from but, if it's from MPD@presentationTimeOffset, there isn't one in my manifest, so should be 0.
Those are points to take a look at.

Looking at git log ./lib/media/presentation_timeline.js, I saw this change: https://github.com/shaka-project/shaka-player/commit/ea6774a1fde3569df4a00992ed17093abefc73e9. Didn't take a deep look at it, but it talks about handling "future segments". It's from March 2023, which would explain why I didn't saw this problem years ago. This could be another debug line.

If I clear my agenda, I'll take a look at it. In the meantime, I'll let quick notes so others can follow. @lifofernandez

Hi @joeyparrish and @avelad, I'll share some research I did on this issue.
When Segment Template generates information of the streams, It creates a TSI for each one, appends and evicts segments to this TSI but does not always update the startNumber with each downloaded manifest.
So I assumed that with an updated startNumber, according to the current manifest, the math to compose the segment number would be within the expected.
Given this I modified the TSI's appendTemplateInfo method so that if the startNumber of the incoming manifest is different from this.templateInfo_.startNumber, it is recorded in acctualStartNumber (a different variable so as not to introduce new bugs or spread the problem to highers levels of abstraction).
if (this.templateInfo_.startNumber !== info.startNumber) {
    console.log(`TSI appendTemplateInfo:
    currentStartNumber ${this.templateInfo_.startNumber}
    and newStartNumber ${info.startNumber} differs.`);
    this.acctualStartNumber_ = info.startNumber;
    console.log(`TSI acctualStartNumber_:`, this.acctualStartNumber_);
}

A part of  this new actual acctualStartNumber  in the calculation, It was also necessary to modify position contemplating the amount of evicted segments (correctedPosition) so that the number is the expected one.
const segmentReplacement = correctedPosition + this.acctualStartNumber_;

Future chunk numbers are no longer observed, but it did produce many Possible encoding problem detected! Unexpected buffered range for reference. By setting the variable timeReplacement in seconds instead of units (range.start  instead of range.unescaledStart and scaledPresentationTimeOffset  instead of unscaledPresentationTimeOffset) the warnings of encoding problems decreased considerably.
const timeReplacement = this.templateInfo_.scaledPresentationTimeOffset + range.start;

Although it is necessary to review and fine-tune all the variables involved to achieve the best possible reproduction, I hope these notes helps to find the cause and fix of the problem.


reformatting all files with scalafmt

Yet another PR that reformats the whole codebase. Let's hope that we got it right this time.

[X] Ran make fmt-fix (or had formatting run automatically on all files edited)

LGTM!


Career portal XML Feed

Can't access the XML feed for our Career portal. From the documentation (http://bullhorn.github.io/career-portal/search-engine-indexing.html) the feed should site at [your career portal root]/feed, but can't seem to access at all.
Current behavior
404 page Not Found
Expected behavior
XML feed of jobs. Are there any other steps needed to get this working?
Steps to replicate behavior

The career portal is hosted here: https://zzandd.com/clients/remedium/careers/
According to the docs, this should be the XML. https://zzandd.com/clients/remedium/careers/feed

Screenshots
Current
Expected

Hello! This feature requires the "advanced hosting" option. That version utilizes server side rendering on a node server to deliver and generate content.
I see currently that the static version of the portal is being used.

Hi Adam
If you can't swap to advanced hosting and using WordPress have look at Matador Jobs we have the XML all working

Hi again @charlesabarnes,
Wondering if you could provide a little more guidance.
http://bullhorn.github.io/career-portal/advanced-install.html
Have been following the advanced setup, but getting stuck on the 4th step. Does the application need to be built first before this will startup?
Thanks so much for the help.
Cheers
Adam

Hello,
I need/would like to update these steps.  Instead of downloading a zip archive of the portal, I suggest cloning the repository first, building the app, then starting from your build files.
You can find details about building here

Thanks again for the quick reply @charlesabarnes. Really appreciated.
Think that's done it now thank you, it was that step that was throwing me off. Loading onto AWS now for further testing, but should hopefully be good to go.
Cheers


update sphinx to v3.3

[x] Closes #4487

Thanks for the pointer @keewis. Let's see if this works.

it did. Thanks, @mathause.


[Feature Request] It is recommended to add multi-segment selection support

Like this:

@AAABingBing This can generate a lot of bugs hard to fix. Using two selections, the feature to fast refresh will not work correctly. The extension watches your current selection to update the snap screen, with two or more selections it will break. Sorry, but it's not possible for te moment

@AAABingBing This can generate a lot of bugs hard to fix. Using two selections, the feature to fast refresh will not work correctly. The extension watches your current selection to update the snap screen, with two or more selections it will break. Sorry, but it's not possible for te moment

I can understand
Indeed, there are not many such usage scenarios


Identical attribute / encoding names connect without showing in the Matching interface

We should either add the connections when the names match, or wait for the user to explicitly establish them.

I can see the benefit in auto-establishing these matchings, but my intuition says these ought to behave like the general case and not doing anything special at all (i.e. the wait-for-the-user option).


python310Packages.hypothesis: export package without tests

Description of changes
To reduce the runtime closure of any package which uses hypothesis, avoid having to use a version that exports tests altogether. The test suite will still be ran for PRs, but we can avoid it in normal usage of hypothesis itself.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This needs a rebase after my changes to pytest/pytest-async and the latest hypothesis update that introduced a dependency on exceptiongroup. Will push my changes to python-updates shortly.

To reduce the runtime closure of any package which uses hypothesis, avoid having to use a version that exports tests altogether

Sorry, I don't get how hypothesis affects the runtime closure of anything, if it is only ever in nativeCheckInputs.
In fact with all the indentation changes and refordering I don't see the relevant change anywhere.

Just click ignore whitespace changes https://github.com/NixOS/nixpkgs/pull/181518/files?w=1

lost interest in this


LOG4J2-3579 Add privileged execution for ServiceLoading

Add privileged actions on caller side
Fixes https://issues.apache.org/jira/browse/LOG4J2-3579

I prefer this approach as opposed to #1006.

Closed, solution is done with https://github.com/apache/logging-log4j2/pull/1008


add name of property in the exception wrongType

It would be very nice to have name of property when exception wrongType is fired
else debugging of model would be a pain
also ideally would say something like (exception wrongType for field 'address', 'string' expected', 'int' provided

Agreed. That will take a bit of effort, but certainly something to explore adding. PR welcomed if you have a solution.

I'm going to go ahead and close this out. The introduction of Codable in Swift 4 mostly deprecates JSONJoy. See the notice here.


[TF 2.1rc0] The {predict,train,test}_on_batch trace functions with fixed batch size

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Debian Stretch
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): 2.1.0rc0
Python version: 3.5.3

Describe the current behavior
When using the updated predict_on_batch method wrapped now in tf.function, the traced calls have a fixed batch size. Therefore, if batch size changes regularly, the function is retraced all the time. For example, the following
import numpy as np
import tensorflow as tf

model = tf.keras.Sequential([
    tf.keras.layers.Dense(1, input_shape=[1])
])
model.compile(optimizer=tf.optimizers.Adam(),
              loss=tf.losses.MeanSquaredError())

for i in range(1, 300):
    model.predict_on_batch(np.ones([i, 1]))

gives
WARNING:tensorflow:5 out of the last 5 calls to <tensorflow.python.keras.engine.sequential.Sequential object at 0x7f2185a37630> triggered tf.function retracing. Tracing is expensive and the excessive number of tracings is likely due to passing python objects instead of tensors. Also, tf.function has experimental_relax_shapes=True option that relaxes argument shapes that can avoid unnecessary retracing. Please refer to https://www.tensorflow.org/tutorials/customization/performance#python_or_tensor_args and https://www.tensorflow.org/api_docs/python/tf/function for more details.
WARNING:tensorflow:6 out of the last 6 calls to <tensorflow.python.keras.engine.sequential.Sequential object at 0x7f2185a37630> triggered tf.function retracing. Tracing is expensive and the excessive number of tracings is likely due to passing python objects instead of tensors. Also, tf.function has experimental_relax_shapes=True option that relaxes argument shapes that can avoid unnecessary retracing. Please refer to https://www.tensorflow.org/tutorials/customization/performance#python_or_tensor_args and https://www.tensorflow.org/api_docs/python/tf/function for more details.
...

The same issue happend with train_on_batch and test_on_batch.
Describe the expected behavior
The {predict,train,test}_on_batch methods are traced with undefined batch size.
Alternatively, the behaviour could be configurable. Each of {predict,train,test}_on_batch could take undefined_batch_size=True/False argument; personally I vote for a default value of undefined_batch_size=True.
And I just realized: if *_on_batch methods are used with sequences (for example sentences in NLP), then the retracing would happen on every call. So instead, it would be better to allow passing experimental_relax_shapes to the *_on_batch or even to .compile call.
Code to reproduce the issue
Available above.
Other info / logs

Issue replicating for the given code for TF version 2.1rc0, kindly find the gist of colab.Thanks!

That's not good.
Thanks for providing such a simple and clean repro of the issue. You are correct; passing experimental_relax_shapes when we make the function (https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/keras/engine/training_v2_utils.py#L122) resolves the issue. Would you like to make the fix PR? (Otherwise I'm happy to do it.)

I have created the PR -- however it is just a "raw" change. Maybe some tests are also required? But I do not know to do them.
Also, the PR is against the master, but maybe it should be backported for TF2.1? Otherwise the final TF2.1 will have suboptimal _on_batch methods.

PR, for reference: https://github.com/tensorflow/tensorflow/pull/35019
@goldiegadde @martinwicke For getting it into 2.1
@yhliang2018 @bitfort We should be able to test this in microbenchmarks. (experimental_relax_shapes doesn't change semantics, only performance.)

@foxik once the PR is merged into master, please request a CP to r2.1 branch.

@goldiegadde The PR has been merged into master as  f835a4a, so I am asking for a CP to r2.1. Is it enough to ask here or should I do something else?

I can handle the cherrypick. (I have another cherrypick request anyway, so adding one more is not any more work.) Thanks for the report and fix; this will greatly improve 2.1.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): 2.2.0rc2
Python version: 3.7.4

With the code above, I get the retracing warnings again in TF2.2.0rc2:
WARNING:tensorflow:11 out of the last 11 calls to <function Model.make_predict_function..predict_function at 0x7fbc0061f5f0> triggered tf.function retracing. Tracing is expensive and the excessive number of tracings is likely due to passing python objects instead of tensors. Also, tf.function has experimental_relax_shapes=True option that relaxes argument shapes that can avoid unnecessary retracing. Please refer to https://www.tensorflow.org/tutorials/customization/performance#python_or_tensor_args and https://www.tensorflow.org/api_docs/python/tf/function for more details.

@robieta Unfortunately, it again does not work with TF 2.2.0rc3

@foxik I'm no longer part of TensorFlow, but I'm sure @omalleyt12 can help you out. (This seems to have been lost when https://github.com/tensorflow/tensorflow/commit/10666c59dd4858645d1b03ce01f4450da80710ec dropped training_v2_utils.py, from the cursory skim that I did.)

Any update on the issue?


Add .NET GitHub Action reference

Fixes #25194.
Preview link.

LGTM.
@mikadumont may want to review before we publish it.

Thanks for the reviews!


add unserialize for transaction

Codecov Report

Merging #3 (2b243d4) into master (452f2d6) will decrease coverage by 0.15%.
The diff coverage is 96.07%.

@@             Coverage Diff             @@
##            master       #3      +/-   ##
===========================================
- Coverage   100.00%   99.84%   -0.16%
===========================================
  Files           25       25
  Lines         1230     1270      +40
  Branches       134      139       +5
===========================================
+ Hits          1230     1268      +38
- Misses           0        1       +1
- Partials         0        1       +1

Impacted Files
Coverage Δ

bsvlib/transaction/transaction.py
98.88% <95.74%> (-1.12%)
:arrow_down:

bsvlib/utils.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 452f2d6...2b243d4. Read the comment docs.