implement this whispers model

this is just a suggestion I will try to implement it and show you how i did it using chatgpt as I don't really know how to code at all
https://github.com/EtienneAb3d/WhisperHallu

Thanks. i have already seen that project.
since we already have VAD and AI Noise cancellation, i think the only thing that differs is the addition of voice markers.
And their implementation has some drawbacks we have to think about.

What about voice markers while using fine tuned models? their transcription might be completely different.
At worst, this means 3 times the processing time compared to a regular transcription, because it retries it in 3 different ways when the first addition of voice markers failed to transcribe. So might be not useful for realtime transcriptions.

 By adding audio to recordings just to cut them out later in the transcription. But if it works and is fast enough, i think we can live with it until there is a better Speech 2 Text model
And i just read that they are cutting silence parts from the recordings. Thats actually something thats currently not really done by me. Since i have code for that already in the Bark plugin without using ffmpeg, i think i can add it and see how that improves it.

I will try to help on my side gonna keep you updated

thanks.
I added the silence cutting already in the master branch. Not 100% sure if it helped in preventing hallucinations.
Worked relatively fine in my testing. only rarely some hallucinations, mostly when realtime transcribing.
final transcribtion was fine most of the time. Will have a look if i can improve it a bit more.

@Sharrnah I cannot thank you enough

Improved the silence trimming so it only cuts in the middle of a found silence part (to prevent it cutting into the start of words for example)
Also added normalization so very loud or quite parts are moved more into normal ranges (which is also a thing the WhisperHallu project seems to do)
actually found another issue while working with the silence trimming and normalization features
which reduced the recording quality when it had to resample the audio because WASAPI did not allow requesting the correct samples from the audio device directly.
(turns out, resampling each audio chunk seperately and then merging it together isn't so great)
So thats fixed now as well in the master branch which should increase the audio quality and might improve the transcription quality with it. (even though Whisper is quite resilient to some noise).
So if the silence trimming does not help, that might help a bit.
I guess we are now just missing voice markers to have pretty similar functionality.

@dolev765 Looked a bit into how they do the voice marker logic.
But one thing i am unsure about is: They add voice markers based on the language.
But what is if you set the Whisper A.I. to autodetect the language. Then the language is not know beforehand. Would that mean we have to run the audio through the AI once before to just find out the language? (which might be wrong anyway).
Might not be an issue if you set the language yourself, but you don't always know what language other people talk beforehand so i like to keep it on auto most of the time except when i talk myself and i know what language i speak.
🤔

thanks. But we already have a seperate AI that can detect the language of text.
However we would need to guess the language based on audio, as thats what we first have before the actual transcription. And it would have to be faster than Whisper itself. (and probably more accurate)

Implemented a first iteration of voice markers. ( see here: https://github.com/Sharrnah/whispering/blob/main/Models/STT/whisper_audio_markers.py )
haven't decided yet if to enable it by default and where to put the option to enable / disable it in the UI yet (besides the Advanced -> Settings).
Even found a little issue with the original implemented regex, as it could keep parts of the voice markers text in the result.

Since voice markers are integrated now in the newest version, i will close this issue.
Feel free to open a new one if you find any issues.

Implemented a first iteration of voice markers. ( see here: https://github.com/Sharrnah/whispering/blob/main/Models/STT/whisper_audio_markers.py )
haven't decided yet if to enable it by default and where to put the option to enable / disable it in the UI yet (besides the Advanced -> Settings).
Even found a little issue with the original implemented regex, as it could keep parts of the voice markers text in the result.

Wow thats amazing to hear I will try it out and tell you how it goes


Error during parsing: Unknown directive 'rule'...strange

# caddy --port 8080 -conf ~/caddyipf
2018/06/19 03:53:19 /root/caddyipf:2 - Error during parsing: Unknown directive 'rule'

# caddy -plugins
Server types:
  http

Caddyfile loaders:
  short
  flag
  default

Other plugins:
  http.basicauth
  http.bind
  http.browse
  http.errors
  http.expvar
  http.ext
  http.fastcgi
  http.filter
  http.gzip
  http.header
  http.index
  http.internal
  http.ipfilter
  http.limits
  http.log
  http.markdown
  http.mime
  http.pprof
  http.proxy
  http.push
  http.redir
  http.request_id
  http.rewrite
  http.root
  http.status
  http.templates
  http.timeouts
  http.websocket
  on
  tls
  tls.storage.file

# cat ~/caddyipf
ipfilter / {
 rule allow
 ip <IP_ADDRESS>
}

How should I do?

How do you resolved the issue?

How do you resolved the issue?

You have to put the ipfilter directive inside a parent block, for example,
:80 {
ipfilter / {
rule allow
ip <IP_ADDRESS>
}
}

Thanks, good to know. :)


Remove Snapshot from version 0.11

Minor change. Will merge as soon as the build goes through.

@PraveenAdlakha : I have merged it. Because of an issue with the merge script, the pull request didn't get closed. Please close it.


DatePicker returns time for different timezone

I have a DatePicker for selecting The time without the DatePicker:
    <MatDatePicker NoCalendar="true" EnableTime="true" DateFormat="H:i" Enable24hours="true" @bind-Value="Effort" />

I select 00:30 from the picker. But the value that is returned is actuall 23:30. I assume this is based on a default time zone.I tried to set the localization as demonstrated in this article but without success: https://chrissainty.com/simple-localisation-in-blazor/
Any idea how to solve that?

this is related to issue #164.
So far can be closed then I guess.


Update NOA to include approval for Grant Only

[ ] Confirm Award Grant Only or Confirm All
[ ] Remove the hidden variable that calculates eligibleAmount=data.assessment.totalFederalAward+data.assessment.totalProvincialAward; in the form definition
[ ] Execute any necessary rounding on workflow and persist to the DB ready to be displayed anywhere as needed.

Closing as this is replaced by other tickets which allow student to select grant only.


RR Dec 19 Summary post created - Tanjimon

RR Dec 19 post ready for review and posting to the site.

Approving


"CAMEL-16414:camel-kafka set custom timestamp"

Should the same changes be done in vertx-kafka ?

changes done. please review

Should the same changes be done in vertx-kafka ?

it should be better to create a seperate jira for this. comments welcome

Should the same changes be done in vertx-kafka ?

it should be better to create a seperate jira for this. comments welcome

yeah it would make sense, a separate JIRA with separate PR


ImportError: No module named 'chatterbot.adapters.storage'...

Just updated to the latest git version of chatterbot, and I now get this error when running chatbot = ChatBot(... command. Before the update everything worked quite well. Do I need to change something in the way I initialize a bot? I did not update it for a long time actually, so it's possible I missed something. Thanks!
chatbot = ChatBot("Chatbotname", logic_adapters=[         "chatterbot.adapters.logic.TimeLogicAdapter",         # "chatterbot.adapters.logic.ClosestMeaningAdapter",         # "chatterbot.adapters.logic.ApproximateSentenceMatchAdapter",         "chatterbot.adapters.logic.ClosestMatchAdapter",         # "chatterbot.adapters.logic.MathematicalEvaluation"     ],                       input_adapter="chatterbot.adapters.input.VariableInputTypeAdapter",                       output_adapter="chatterbot.adapters.output.OutputFormatAdapter",                       storage_adapter="chatterbot.adapters.storage.MongoDatabaseAdapter",                       database='Chatbotname-database',                       tie_breaking_method="random_response"                       )
Traceback (most recent call last):   File "D:/Projects/Python/Code/server/app.py", line 764, in <module>     storage_adapter="chatterbot.adapters.storage.MongoDatabaseAdapter",   File "D:\Projects\Python\Code\server\chatterbot\chatterbot.py", line 32, in __init__     utils.validate_adapter_class(storage_adapter, StorageAdapter)   File "D:\Projects\Python\Code\server\chatterbot\utils.py", line 112, in validate_adapter_class     if not issubclass(import_module(validate_class), Adapter):   File "D:\Projects\Python\Code\server\chatterbot\utils.py", line 64, in import_module     module = importlib.import_module(module_path)   File "C:\Python34\lib\importlib\__init__.py", line 109, in import_module     return _bootstrap._gcd_import(name[level:], package, level)   File "<frozen importlib._bootstrap>", line 2254, in _gcd_import   File "<frozen importlib._bootstrap>", line 2237, in _find_and_load   File "<frozen importlib._bootstrap>", line 2221, in _find_and_load_unlocked ImportError: No module named 'chatterbot.adapters.storage'; 'chatterbot.adapters' is not a package

Oh, haha. Well. Obviously, i just had to remove ".adapters" from all adapters, I see the change in directories now. Sorry to bother. Will keep digging into further things that changed.  Sorry about this.

@Nixellion Thanks for the heads up. I will make changes to correct the broken link.


Investigate use of context + observedBits for performance optimization

I've written about this in several places recently, so I might as well consolidate the information as an issue.  I'll copy and paste from the other stuff I've written as appropriate.
Prior discussions and materials for reference:

For an overview of how calculateChangedBits and unstable_observedBits work, see the post Bitmasks and the new React Context API
A long Reddit comment I wrote on how React-Redux handles updates, and how bitmasks might help with optimization
My React RFC proposal for making Context.Provider accept a calculateChangedBits prop
Discussion of hypothetically auto-determining what state fields a component accesses  (based on other plans from the "Remixx" project)

Summary and Use Case
In React-Redux v5 (the current version), every instance of a connected component is a separate subscriber to the store.  If you have a connected list with 10K connected list items, that's 10,001 separate subscriber callbacks.
Every time an action is dispatched, every subscriber callback is run.  Each connected component checks to see if the root state has changed.  If it has, that component re-runs the mapState function it was given, and checks to see if the values it returned have changed.  If any of them have, then it re-renders your real component.
In v6, we're changing it so that there's only one subscriber to the Redux store: the <Provider>.  When an action is dispatched, it runs this.setState({storeState : store.getState()}), and then the store state is passed down to connected components using the new React.createContext API.  When React sees the value given to the Context.Provider has changed, it will force all of the associated Context.Consumer instances to update, and that's when the connected components will now re-run their mapState functions.
So, in v5, there's 10,001 subscriber callbacks and 10,001 mapState functions executed.  In v6, there's only 1 subscriber callback executed, but still 10,001 mapState functions, plus the overhead of React re-rendering the component tree to update the context consumers.  Based on what we've seen so far, the overhead of React updating is a bit more expensive than it was to run all those subscriber callbacks, but it's close.  Also, there's other benefits to letting React handle this part of the work (including hopefully better compatibility with the upcoming async timeslicing stuff).
However... as many people have pointed out, in most apps, for any given action and state update, most of the components don't actually care about the changes.  Let me give a different example.  Let's say that our root state looks like {a, b, c, d}.  Doesn't matter what's inside those, but for sake of the argument let's say that each top-level slice holds the data for 2500 items, and a separate connected component for each item.
Now, imagine we dispatch an action that updates, say, state.a[1234].value.  state, state.a, and state.a[1234] will be updated to new references by our reducers, but state.b, state.c, and state.d are all the same.
That means that only 2500 out of 10K components would have any interest in the changes at all - the ones whose data is in state.a.  The other 7500 could really just skip re-running their mapState functions completely, because the top-level slices their data is in haven't changed.
So, what I imagine is a way for a connected component to say "hey, I only want to re-run my mapState function if state.b or state.c have changed".  (Technically, you could do something sorta like this now with some of the lesser-known options to connect, I think, but lemme keep explaining.)  If we did some magic to turn those state slice names into a bitmask pattern, and <Provider> ran a check to calculate a bitmask pattern based on which state slices did change, then we could potentially use that to skip the update process entirely for any components that didn't care about these changes, and things would be a lot faster as a result.
Where the proxy stuff comes in would be some real "magic" , where we could maybe "automagically" see which state fields your mapState function tries to read.  It's theoretically possible, but very very complex with lots of edge cases.  If that doesn't work, we'd maybe let you pass an option to connect that says subscribeToStateSlices : ["a", "c"] or something like that.
Potential Implementation Details
Calculating Changed Bits from State
In the RFC, I wrote this hand-waved function:
function calculateChangedBitsForPlainObject(currentValue, nextValue) {
    // magic logic to diff objects and generate a bitmask
}

Here's how I imagine an un-hand-waved implementation would work.
Let's say we've got a Redux store whose top-level state looks like {a, b, c, d}.  The contents of those state slices is irrelevant - we can assume that the values are being updated immutably, as you're supposed to do with Redux.
A standard shallow equality check loops over the keys for two objects , and for each key, checks to see if the corresponding values in the two objects have changed.  If any have changed, it returns false ("these objects are not equal").  I would want to implement a similar function that returns an array of all keys whose values have changed in the newer object (such as ["a", "c"]).
From there, I would run each key name through a hash function of some sort, which hashes the key string into a single bit.  I briefly experimented with using a "minimal perfect hashing" library a while back as an early proof of concept.
So, every time the Redux store updated, the React-Redux <Provider> component, as the sole subscriber to the store, would determine which keys had their values changed and generate the changedBits bitmask accordingly.  It wouldn't be a "deep" comparison of the state trees, but rather a quick and simple "top level" list of changes, at least as a default implementation.
Connected components would by default still subscribe to all updates, but we would provide a way for the end user to indicate that a connected component only cares about updates to certain state slices (hypothetical example: connect(mapState, null, null, {subscribeToStateSlices: ["a", "d"]})(MyComponent).
Calculating Component Usage of State Slices
This is the tricky part.  In an ideal world, a connected component could wrap up the store state in an ES6 Proxy, call its mapState function with that wrapped state, and track which fields had been accessed.  Unfortunately, there's tons of edge cases involved here.  @theKashey has been doing a lot of research on this as part of the Remixx project he's working on.  Quoting his comment:

So, let me explain what I've got today:
Proxyequal - as a "base layer". Wraps state and records all the operations on it. After being used it will produce a list and a trie with all values used, and how exactly they were used. Ie then you are doing state.a.b - you need only b, but could early-deside(memoize in this case) if a still the same.
This library is all you need to make a first step. But not the second step.
The problems are

selectors are not constant. In the different conditions, they may access different keys - state.items[props.key] - so their work should be reestimated every run.
there is no "every run" with memoization. On the second run memoized selector will do nothing.
this situation is easy to detect, proxyequal ships shouldBePure helper, which could test, that some function is doing the same every run.
but memoization and memoization cascades is something good to have.

So the plan is:

create a function, which could wrap any other memoization library, and "bubble" "access trie" to the top, in case of memoization
amend connect to throw in debug mode, if mapStateToProps is not absolutely pure
collect all "access tries" on the top level, and do the job.
but it is still a bit fragile.
probably call all mapStateToProps in dev mode (or in tests), and throw throw errors, if something got unpredicted updated, ie was not "reading" some keys before.

Another option:

add another option to connect, with information about "what it will do, which parts of the state it gonna access". In case of breach - console.log settings to be updated.

Ie be more declarative and let js help you write down these declarations.
All this stuff is hard to write, but easy to test. But this behavior doesn't sound like something production ready.

Use of calculateChangedBits
I had originally assumed that each Context.Provider could accepts a calculateChangedBits function as a prop.  However, I was wrong - you actually pass one function as an argument to createContext, like React.createContext(defaultValue, calculateChangedBits).  This is a problem, because we're likely to use a singleton-style ReactReduxContext.Provider/Consumer pair for all of React-Redux, and that would be created when the module is imported.  It would be really helpful if we had the ability to pass it as a prop to each Context.Provider instead.  That would let us be more dynamic with our change calculations, such as handling an arrayor an Immutable.js Map as the root state  instead of a plain object.
At Dan Abramov's suggestion, I filed React RFC #60: Accept calculateChangedBits as a prop on Context.Providers to discuss making that change.  Sebastian Markbage liked the writeup itself, but was hesitant about the actual usage of the bitmask functionality on the grounds that it might change in the future, and whether it was appropriate for our use case.  The discussion hasn't advanced further since then.
Personally, I think the bitmask API is exactly what React-Redux needs, and that we're the kind of use case the API was created for.
One potential alternative might be a "double context" approach.  In this approach, we might create a unique context provider/consumer pair whenever a React-Redux <Provider> is instantiated, use the singleton ReactReduxContext instance to pass that unique pair downwards to the connected components, and put the data into that unique context instance.  That way, we could pass in a calculateChangedBits function to the createContext call .  It seems hacky, but that was actually something Sebastian suggested as well.
Potential Improvements
@cellog did some quick changes to our existing stockticker benchmarks, which uses an array of entries.  I think it was basically bitIndex = arrayIndex % 31, or something close to that - something simple and hardcoded as a proof of concept.  He then tweaked his v6 branch (#1000 ) to calculate observedBits the same way, and compared it to both v5 and the prior results for that branch.  I don't have the specific numbers on hand, but I remember he reported it was noticeably faster than the v5 implementation, whereas the prior results were a bit slower than v5.  (Greg, feel free to comment with the actual numbers.)
So, conceptually it makes sense this could be an improvement, and our first test indicates it can indeed be an improvement.
Timeline
At this point, I don't think this would be part of a 6.0 release.  Instead, we'd probably make sure that 6.0 works correctly and is hopefully equivalent in performance to v5, and release it.  Then we could research the bitmasking stuff and put it out in a 6.x release, similar to how React laid the foundation with a rewrite in 16.0 and then actually released createContext in 16.3.

32 bytes are not enough, I am not sure we could create a really good hash function to serve as a bloom filter. What about shouldContextUpdate?
I've actually have another idea for optimization, which works quite well in my case - react-redux-unbranch. Idea is simple - every connect is a Provider for all the nested connects. It form a real "tree", the same as reselect memoization cascade, and if some keys of the store are not being used in the left branch - it's easy to detect and ignore all the changes of the unused keys in the future.
Ie it does not track "the key usage", but work with "unusage".
As long after the each step deeped to the tree you have less and less keys used in exactly "that" branch - sooner or later we will enter the state, when 32 bits are actually enough.
What if maintain more than one connection to the redux store? Divide and Conqueror!

Just tracking a top level slices is way more easy task, especially in terms if amount of information one have to store(just first part of a key used), but would help a lot in 99% cases.
It also wipes out memoization problem I've mentioned before, as long from run to run selector could access different keys, but almost every time it will use the same slices. This assumption could lead to propasal that any connect could only start using some slice, but not end.
This makes used keys hoisting much easier - one have to report only a few short slice names. This makes observability easier and faster, as long to track top level slices one need to wrap with proxies only Store itself, not deeply nested objects.
The only problem here - it's easy to make this slice-level tracking works, I could give you a working example in a day, but it will be hard to move to "two levels deep" tracking in the future.
Are you considering having 2 react-redux? One as I described - simple, and capable to handle 99% applications, and the second, we are unable to build right now, but may be in the future....

Sounds good for me. Look like there are 3 tasks as result:

Find the changed slices on store update. Just a not shallow equal ones.
Track the slice usage inside mapStateToProps. Using a simple one level proxy. Double check how memoization work with it, probably work well, as long something will has to access store.slice to perform shallow equal.
Given names of used slices - produce a bit mask. Probably in keys enumeration order. Here one have to include "checksum" in case or reduces update and thus enumeration change.

More "deep" tracking could work as a separate layer
We don't need proxies for this stuff, but could use standard getters. This moment requires some performance testing.

Sounds reasonable.  I think our two v6 branches (#995 and #1000 ) are sufficiently far along that we could try adding this functionality to them to see how well it works.
Perhaps there's some way we could set it up in "dummy/no-op mode" to begin with - calculate the changes, and somehow log/collect results on whether they would have been "correct" or not.

Which one could I pick for a spike?

Before changedbits, I was getting 14 fps, 5 was 16. After, I got 24 fps, 5 still at 16. It's a huge difference.
P. S. I don't think we need to change context API to accept a prop. We just accept context as a prop on our provider, and as a connect option in connect. This optimization is going to be a rare use case, most users won't need it

But you can see the difference in the react-redux-benchmarks repo for yourself, don't take my word for it

@theKashey : go with #1000 for now, since Greg's already done some fiddling with changedBits on that branch.

FYI https://github.com/cellog/react-redux/blob/observedBits/src/utils/observedBits.js
This version is not unit tested, and has some known bugs. Basically, it allows you to pass in a state shape, and it spits out an object that can return a context to use, as well as utilities to pass in a key to the state map and get a bitmap back.

P.S. just learned that in a component without sCU, observedBits is pretty useless. If sCU simply returns false, however, it limits re-renders as expected. So we will want to use PureComponent to limit unnecessary re-renders when props don't change, or something similar

@cellog : observedBits only comes into play when the Context.Provider is given a new value.  If the component rendering the Context.Consumer re-renders, then yes, the render prop callback should execute too.

I think I was unclear. I constructed this test:
  test("context", () => {
    const mapper = bits.makeArrayMapper(40)
    const FancyContext = mapper.context()
    const updates = []

    class Li extends React.Component {
      shouldComponentUpdate() {
        return false
      }

      render() {
        const { i } = this.props
        return (
          <FancyContext.Consumer unstable_observedBits={mapper.getBits(i)}>
            {state => {
              updates.push(i)
              return
{state[i]}

            }}
          </FancyContext.Consumer>
        )
      }
    }
    class Updates extends React.Component {
      constructor(props) {
        super(props)
        this.state = {
          info: Array(40)
            .fill(1)
            .map((_, i) => i + 1)
        }
        this.mapper = (thing, i) =>

      }

      render() {
        return (
          <FancyContext.Provider value={this.state.info}>

{this.state.info.map(this.mapper)}

            <button
              onClick={() =>
                this.setState(state => {
                  const info = [...state.info]
                  info[3] = "hji"
                  info[27] = "wow"
                  return { info }
                })
              }
            >
              set
            </button>
          </FancyContext.Provider>
        )
      }
    }

    const tester = rtl.render(<Updates />)
    expect(updates.length).toBe(40)
    rtl.fireEvent.click(tester.getByText("set"))
    expect(updates.length).toBe(43)
  })

but until I added that sCU that returns false, I was getting 80 updates. So it's not enough to use observedBits, we have to also prevent re-render the normal way too

Yeah, I think that's still basically what I was saying.  observedBits does nothing to stop a normal re-render.  It only comes into play when a context update is being triggered.  If the component that is rendering the consumer re-renders, everything inside it re-renders.

@markerikson - PR drafted.

Looked into this in #1021. It didn't seem to make a huge difference for now.

I'd like to look at this further after 6.0 goes final, so I'll reopen it as a marker.

A bit of further discussion: https://spectrum.chat/thread/3d6d5795-227a-49d4-b275-316db611a002 .


wasi: Test that pollables may be used multiple times

We didn't have a test that covered using a pollable multiple times in the test-programs, despite relying on that behavior in the preview1 adapter.

@pchickey and @guybedford, does this look like enough to have caused a test failure in the jco work?

Unfortunately I tried this in JCO and it is definitely passing, so I don't think this is capturing a case. JCO pollables will only ever resolve once as they are promise-based, after which they will be always-resolving. @elliottt let me know if I can help debug further at all.


Configuration of Lian Li Uni Hub

Sorry, i am sure that this is very very simple, but i am completely new in this, and i am going crazy
This is the only component that i need to use in icue.

I am trying to setting it up in settings.json with the file devices.json empty (i dont know how to use it)

The result is a just an empty device:

Thank you in advance!

Solved. Simply the devices.json was not completely empty (it had [ ] and Icue recognized the device by default. The solution has been to properly fill the devices.json file. It does not shown the images and follow the keyboard layout but things to learn and change


[nodes] minor typing fixes

Makes a number of optional things Optional[]
See line 491 for a class property that doesn't seem to exist?
I couldn't figure out the rest of the typing warnings. The tests pass so I assume I haven't broken anything :)

@lstein I need to be a required reviewer before any changes are made to at least the nodes branch. There are some potential errors in this PR, and this is against brand new code that isn't even hooked up yet.

Sorry, I shall fix that.
Will you revert?
On Mon, Feb 6, 2023 at 10:59 AM Kyle Schouviller @.***>
wrote:

@lstein https://github.com/lstein I need to be a required reviewer
before any changes are made to at least the nodes branch. There are some
potential errors in this PR, and this is against brand new code that isn't
even hooked up yet.
—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/pull/2547#issuecomment-1419319237,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVK5PWPNHRDCZRTTNGLWWENURANCNFSM6AAAAAAUSMZRIA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

I only see one potentially major issue and one minor issue. The rest looks good, but I'm worried there may just be missing test coverage and I'll forget about the change by the time I get to look at code again (got a bunch of time last night, but that's been rare).

PR #2552 adds you as codeowner. I have also turned on branch protection for nodes so that all changes need to go through PRs and reviewed by the codeowner.

I'm giving you override privileges.
Lincoln
On Mon, Feb 6, 2023 at 11:31 AM Kyle Schouviller @.***>
wrote:

It would be preferred for a little while, unless others intend to work
within the branch heavily.

From: Lincoln Stein @.>
Sent: Monday, February 6, 2023 8:24:23 AM
To: invoke-ai/InvokeAI @.>
Cc: Kyle Schouviller @.>; Review requested @.>
Subject: Re: [invoke-ai/InvokeAI] [nodes] minor typing fixes (PR #2547)
PR #2552https://github.com/invoke-ai/InvokeAI/pull/2552 adds you as
codeowner. I have also turned on branch protection for nodes so that all
changes need to go through PRs and reviewed by the codeowner.
—
Reply to this email directly, view it on GitHub<
https://github.com/invoke-ai/InvokeAI/pull/2547#issuecomment-1419361357>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AAO3P354JXV2TRD5D6XVHKTWWEQTPANCNFSM6AAAAAAUSMZRIA

.
You are receiving this because your review was requested.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/pull/2547#issuecomment-1419372294,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVNDTZYPZEYTHJ4K7GDWWERMZANCNFSM6AAAAAAUSMZRIA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

Okay @psychedelicious I fixed and pushed the output nodes method.


[code]: add solution to challenge

Add the solution code for challenge 13

Resolved issue: https://github.com/akebu6/Kotlin-Code/commit/d102f496cf5e86097680c78bf3c7deba566d665f for issue #10


Instance type changes

What does this PR change?
Use t3(a) instance types for bastion host and mirror. They are cheaper an more powerful.
But this has changes to the device names which are important for the mirror.
Try to handle all of this in terraform and salt.

@rjmateus Not sure if this is it the right way to handle it. I wonder why AWS Console show different device names than we finally get? Maybe there are other places where we need to do changes?

@mcalmer I'm not sure about that. I would say we should test it and see if it solves the issue.

I think @maximenoel8 PR does the same but also more at other places. So I close this one in favor of https://github.com/uyuni-project/sumaform/pull/1183


I added the function that load mesh on blender UI.

There are buttons that create or delete mesh on blender UI.
I used wheel for mesh.
The location of the wheel is determined by the slider values.
If you click the mesh create button, 'ik-control' follows the mesh.

Do you have a some time for explain your code? we need some help for our GUI functions for simulation.


Added npmignore to ignore db and tooling folders when npm package is generated

The db folder shou;d not be added to the npm package, it was created for development purpose only.
I added an example to README documentation explaining how to import Industry type.

I uploaded the changes.

I uploaded changes to remove build, cjs, esm, iiffe and umd directories before calling rollup-all. You could add this sequence in rollup-all and generate all the required directories inside of the build directory.

I uploaded changes to remove build, cjs, esm, iiffe and umd directories before calling rollup-all. You could add this sequence in rollup-all and generate all the required directories inside of the build directory.

the latest version of rollup-all does this now, can you update to it?

I uploaded the changes. I had to keep 'yarn clean' to remove build folder before to run rollup because if there are files that were removed from src, when a new version is created they are not removed from build folder. To recreate it, try adding a file (i.e. example.txt) inside the build folder, then run 'yarn build' without 'yarn clean' and you'll see that the example.txt is there and it's not right.


Problems after configuration

The plugin is set up and shows me the devices and the IDs. Devices in the HomeKit are displayed. My Config:
{             "platform": "NukiPlatform",             "hostNameOrIpAddress": "SERVER_IP",             "hostCallbackApiPort": 40506,             "bridgeIpAddress": "BRIDGE_IP",             "bridgeApiPort": 8080,             "bridgeApiToken": "TOKEN",             "bridgeRebootSwitch": false,             "devices": [                 {                     "nukiId": OpenerID,                     "isRingToOpenEnabled": true,                     "isContinuousModeEnabled": false,                     "unlatchFromLockedToUnlocked": false,                     "unlatchFromUnlockedToUnlocked": false,                     "unlatchLock": false                 },                 {                     "nukiId": SmartLockID,                     "isRingToOpenEnabled": false,                     "isContinuousModeEnabled": false,                     "unlatchFromLockedToUnlocked": false,                     "unlatchFromUnlockedToUnlocked": false,                     "unlatchLock": false                 }             ]         }
Problem 1: If the Smart Lock device is removed, nothing works anymore - message "No config for device".
Problem 2: I don't see a second button for "Ring to Open".
Problem 3: Nothing happens when you press a button in HomeKit. Neither with the Opener nor with the SmartLock. Message in the terminal:
[NukiPlatform] OpenerID - Unlock
[10/5/2019, 3:28:20 PM] [NukiPlatform] Error while communicating with the Nuki Bridge. Status Code: 404

Nuki Bridge is available and "online". App and native SmartLock integration work fine.

Problem 1: If the Smart Lock device is removed, nothing works anymore - message "No config for device".

Can you explain what is meant with "device is removed"? Are you removing the device from the Nuki Bridge, the config.json or physically?

Problem 2: I don't see a second button for "Ring to Open".

Configuration (RTO and continuous mode) are exposed as a separate switch.

Problem 3: Nothing happens when you press a button in HomeKit. Neither with the Opener nor with the SmartLock. Message in the terminal

Do you have the latest firmware on the Nuki Bridge?

Can you explain what is meant with "device is removed"? Are you removing the device from the Nuki Bridge, the config.json or physically?

I have removed it from the config.json, so I have only one array element (the Opener).

Configuration (RTO and continuous mode) are exposed as a separate switch.

The separate switches are only shown if I add the Opener AND the Smart Lock to the array of devices in the config.json. For example:
 "devices": [
                {
                    "nukiId": OPENERID,
                    "isRingToOpenEnabled": true,
                    "isContinuousModeEnabled": false,
                    "unlatchFromLockedToUnlocked": false,
                    "unlatchFromUnlockedToUnlocked": false,
                    "unlatchLock": false
                }
            ]

=> No buttons.
 "devices": [
                {
                    "nukiId": OPENERID,
                    "isRingToOpenEnabled": true,
                    "isContinuousModeEnabled": false,
                    "unlatchFromLockedToUnlocked": false,
                    "unlatchFromUnlockedToUnlocked": false,
                    "unlatchLock": false
                },
{
                    "nukiId": SMARTLOCKID,
                    "isRingToOpenEnabled": false,
                    "isContinuousModeEnabled": false,
                    "unlatchFromLockedToUnlocked": false,
                    "unlatchFromUnlockedToUnlocked": false,
                    "unlatchLock": false
                }
            ]

=> No buttons.
 "devices": [
                {
                    "nukiId": OPENERID,
                    "isRingToOpenEnabled": false,
                    "isContinuousModeEnabled": false,
                    "unlatchFromLockedToUnlocked": false,
                    "unlatchFromUnlockedToUnlocked": false,
                    "unlatchLock": false
                },
{
                    "nukiId": SMARTLOCKID,
                    "isRingToOpenEnabled": true,
                    "isContinuousModeEnabled": false,
                    "unlatchFromLockedToUnlocked": false,
                    "unlatchFromUnlockedToUnlocked": false,
                    "unlatchLock": false
                }
            ]

=> Button for RTO visible.

Do you have the latest firmware on the Nuki Bridge?

Yes.

Can you please double-check whether you have mapped the IDs to the correct devices? Maybe you have switched the Opener ID and the SmartLock ID?

Ok, I found the bug in the code, I accidentally used the wrong index when loading the configuration.  Fixed with #14, new version 0.5.2 is on NPM.

Now everything works fine. :-) 👍

You can remove all devices from the config, restart homebridge (which should remove the devices from HomeKit), then re-add the Opener to the config.

Homebridge hiccups. I've cleared the device cache, now it's running.
One thing: The change from Unlocked to Locked at the Opener could be a bit faster. Locked -> Tap -> Opener opens -> Unlocked -> 10-15 seconds wait -> Locked. If it is not dependent on iOS or the HTTP API...

I'm waiting for the callback from the Nuki Bridge that signals that the opener is "locked" again, it is not a timeout set by me. We should wait for the new Nuki Bridge update in Q4, which should enhance the liability and speed. If that does not help, feel free to open a new issue.


Getting exception with message "Forbidden" from starting sample (forms)

Description
I have been following Xamarin.Forms-API install guide with included example (xaml).
The LoadingPlaceholder shows up ok, then the ErrorPlaceHolder. In the Error-event I get 4 Exceptions, I think they are the same. The message is "Forbidden" and the stack trade below
------------------------------------------------------------------------------------->
at FFImageLoading.Retry+d__01[T].MoveNext () [0x0015b] in C:\projects\ffimageloading\source\FFImageLoading.Common\Helpers\Retry.cs:32  --- End of stack trace from previous location where exception was thrown ---   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <fcbf47a04b2e4d90beafbae627e1fca4>:0    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <fcbf47a04b2e4d90beafbae627e1fca4>:0    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <fcbf47a04b2e4d90beafbae627e1fca4>:0    at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <fcbf47a04b2e4d90beafbae627e1fca4>:0    at System.Runtime.CompilerServices.ConfiguredTaskAwaitable1+ConfiguredTaskAwaiter[TResult].GetResult () [0x00000] in :0
at FFImageLoading.Cache.DownloadCache+d__16.MoveNext () [0x00413] in C:\projects\ffimageloading\source\FFImageLoading.Common\Cache\DownloadCache.cs:58
..../goes on for a while/
<-------------------------------------------------------------------------------------
Im running android and tested both enableFastRenderer true and false
I have been writing to file system loaded loaded images from urls in same project.
Steps to Reproduce
Follow Xamarin.Forms-API install guide with included example (xaml).
Expected Behavior
Not crash
Actual Behavior
Crash
Basic Information

Version with issue:
Xamarin.FFImageLoading.Forms <IP_ADDRESS>0
Xamarin.FFImageLoading.Svg.Forms <IP_ADDRESS>0
Xamarin.FFImageLoading.Transformations <IP_ADDRESS>0

Last known good version: You tell me

Platform:
Only tested on android phone, Samsung Galaxy S7, Android 8.0, API 26

Screenshots

Reproduction Link / Code

It can be your internet provider. Could you make a repo?

No its not, but nice stalling technique... I have left FFImageLoading weeks
ago, so no to the repo as well, but as I said, I have been following
Xamarin.Forms-API
install guide
https://github.com/luberda-molinet/FFImageLoading/wiki/Xamarin.Forms-API
Den lör 20 okt. 2018 kl 11:38 skrev Daniel Luberda<EMAIL_ADDRESS>
:

It can be your internet provider. Could you make a repo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/luberda-molinet/FFImageLoading/issues/1126#issuecomment-431565408,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVNhfD_r39xwh_z57N8VCgCMV4FULd-yks5umu8DgaJpZM4W7-y9
.


130 conform to request data model spec 20

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

36 of 349 (10.32%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-15.0%) to 65.183%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sdx_datamodel/parsing/connectionhandler.py
36
40
90.0%

src/sdx_datamodel/models/connection_qos_unit.py
0
26
0.0%

src/sdx_datamodel/models/connection_scheduling.py
0
26
0.0%

src/sdx_datamodel/models/api_response.py
0
33
0.0%

src/sdx_datamodel/models/connection_qos_metrics.py
0
76
0.0%

src/sdx_datamodel/models/connection_v2.py
0
148
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-15.0%

Covered Lines:
1103

Relevant Lines:
1652

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

34 of 347 (9.8%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-15.1%) to 65.129%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sdx_datamodel/parsing/connectionhandler.py
34
38
89.47%

src/sdx_datamodel/models/connection_qos_unit.py
0
26
0.0%

src/sdx_datamodel/models/connection_scheduling.py
0
26
0.0%

src/sdx_datamodel/models/api_response.py
0
33
0.0%

src/sdx_datamodel/models/connection_qos_metrics.py
0
76
0.0%

src/sdx_datamodel/models/connection_v2.py
0
148
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-15.1%

Covered Lines:
1101

Relevant Lines:
1650

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

236 of 318 (74.21%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.0%) to 79.205%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sdx_datamodel/parsing/connectionhandler.py
34
38
89.47%

src/sdx_datamodel/models/connection_scheduling.py
22
27
81.48%

src/sdx_datamodel/models/connection_qos_unit.py
18
27
66.67%

src/sdx_datamodel/models/connection_qos_metrics.py
58
77
75.32%

src/sdx_datamodel/models/connection_v2.py
104
149
69.8%

Totals

Change from base Build<PHONE_NUMBER>:
-1.0%

Covered Lines:
1303

Relevant Lines:
1621

💛  - Coveralls

I'm going to ignore the drop of test coverage on models, because that is generated code.


Handling duplicate global/CB declarations in multi-file Slang code

When the compiler gets multiple .slang files as input to a compile request, it groups them all into a single translation unit. In the simplest terms, you could think of this as being like concatenating the input files into one, and then feeding that to the compiler (but that isn't quite accurate).
Right now, a problem arises if you feed in both MyVS.slang and MyFS.slang where those files duplicate some shader parameter declarations (e.g., a cbuffer declaration in a file that both of them #include). Right now the front-end fails to diagnose the colliding declarations (even though they are in the same translation unit), and then parameter layout identifies them as the "same" shader parameter (any two globals with the same name are counted as the same parameter right now).
This means that there is only a single layout object created (based on whichever declaration gets seen first). Later, when legalizing IR-based code, we will end up trying to split the type of one cbuffer declaration using the type layout of the other, so that things break when looking up a field in a layout that knows nothing about that field.
This is a complex, messy situation.
The simplest fix (and seemingly the correct one) is to have the front-end reject code like I just described, by diagnosing the duplicate variable declarations. This would be a bit confusing in the above case, since the "duplicate" declarations both come from the same file.
It is possible that similar bugs could arise in the multiple-TU case, where different declarations that represent the same parameter are allowed. In those cases the likely fixes would be:

Merge field information from all matching declarations of a parameter. We already have support for such things in StructTypeLayout, so it might be a simple fix.

Have the lookup process for entries in a StructTypeLayout use indices instead of field decl-refs. That would require tuple elements to track a field index and not just a decl-ref, but it might be worth it.

Talking this over with Nir, it seems like the simplest solution from the perspective of Falcor would be if we just treated multiple .slang files passed to the API the same way we treat multiple .hlsl files. And honestly that seems like a reasonable request, and seems to be the intent what is being expressed by Falcor's use of the Slang API. I potentially got confused because when using the command-line interface there is no way to have multiple Slang translation units at once.
Okay, so if we need to support the use case of multiple .slang translation units, which could each declare matching cbuffers, then this isn't a front-end issue (or at least isn't just a front-end issue), and we do need to find a way to make the type legalization able to handle cbuffers that might be declared  in multiple TUs (or more generally, parameters using aggregate types declared in multiple TUs).

Closing.
We have moved past this model. The need to handle overlapping cbuffers and other global shader parameters across translation units was a huge pain for the code, and the actual intent can be achieved much more easily using proper Slang mechanisms.


Setup CI

at present I’m unable to build Blazor projects located outside of the Blazor repo folder using VS 2017 15.5.6, will the CI be publishing Blazor components to a public myget feed ?

Update: We now have CI running (AppVeyor, Travis, and internal). AppVeyor and Travis are running the E2E tests too on Windows, Mac, and Linux.
We don't yet have the tests running in the internal CI, because we'd have to install some browsers on all the agents. Leaving this issue open until that is done.

In progress at https://github.com/aspnet/AspNetCore/pull/5158


Update docs

Added a contributing.md file.
fixes #3

LGTM!

@all-contributors please add @RTrex for doc


[Bug] RTL + VariableWidth causes the slide to go to wrong direction when swipping

Wrong slide activated when trying to swipe the carousel on RTL page.
[ https://jsfiddle.net/ct0L75b0/  ]
====================================================================
Steps to reproduce the problem

Define a width for the slider using CSS
Define both RTL and VariableWidth as true
Try to swipe

====================================================================
What is the expected behaviour?
If I swipe to the right, the carousel should go for the same side as my finger, but after release, it goes to the opposite direction, for the wrong slider.
For example:

I have slides #1, #2 and #3.
I'm on an RTL page, so slide #1 is on the right and slide #3 on the left
If I swipe right, it's expected slide #3 to become active

====================================================================
What is observed behaviour?
In the same situation as above:

If I swipe right, the carousel "bounce" and slide #1 become active

====================================================================
More Details

Chrome Version 61.0.3163.100
jQuery 3.2.1 / Slick 1.8.1

Any solution ?

Do you find solution?

The easier solution is to manually apply a direction property on "slick-list".
<div class="slick-list draggable" style="direction: ltr">
</div>


Android - Subscription not reflected in ra

Description
I created 3 subscription plan on my google play console. Only one of them get reflected in application.
I am using
import { initConnection, requestPurchase, useIAP } from 'react-native-iap';
const {  subscriptions } = useIAP();
initConnection()
.then(async log => {
console.log('subscriptions', JSON.stringify(subscriptions));
})
.catch(e => {
console.log(e);
});
This prints only one product in log.
Expected Behavior
I want to show all 3 in application
Environment:

"react-native-iap": "^12.12.2",

It work work over time, when I did mine, it took some few days after some tries, I started working properly and perfectly

I have the same issue. Is it necessary to upload a new build after creating a new subscription on Google play console?

It’s not necessary, the device will connect with the play store server and reflect update,

It’s not necessary, the device will connect with the play store server and reflect update,

But I've created new subscriptions and these are not reflecting in the app. But the one that I created 2 weeks ago, it was reflecting after few minutes. Do you know what could be the reason?

It’s not necessary, the device will connect with the play store server and reflect update,

But I've created new subscriptions and these are not reflecting in the app. But the one that I created 2 weeks ago, it was reflecting after few minutes. Do you know what could be the reason?

That’s should be an issues with your code then

@Accoladecreative  Do you know how long it will take to show a new subscription in the app?

For the first time, it can take few days. I will say 3 days max with the ones I’ve worked with.
Then ones it started already, it will always reflect every changes immediately

I resolved the issue by clearing the cache for Google Play Store and waiting for 5-10 minutes. Afterward, all the subscription products created on the Google Console were properly reflected in my application.

How you clean the cache for google play store?
On Mon, 19 Feb 2024 at 9:12 AM, Hemangi @.***> wrote:

I resolved the issue by clearing the cache for Google Play Store and
waiting for 5-10 minutes. Afterward, all the subscription products created
on the Google Console were properly reflected in my application.
—
Reply to this email directly, view it on GitHub
https://github.com/dooboolab-community/react-native-iap/issues/2677#issuecomment-1951660565,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4XC7SVAEEZWHUUMKOSY3XTYULGLRAVCNFSM6AAAAABCGWWQS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGY3DANJWGU
.
You are receiving this because you commented.Message ID:
@.***>


Server query doesn't work on modded and/or 1.7

Minecraft server query doesn't work on either modded or 1.7. This is not clear and requires some testing.
This is consistent with the python library/cli mcstatus. Ping and status commands still work, just  not query

I've determined the issues is with the async-minecraft-ping's StatusResponse struct and the serde_json deserialization. A 1.7.10 (and/or modded) server uses a Stringrather than an object for the "description" property that causes an invalid json response:
invalid JSON response: "{"description":"A Minecraft Server", players: {..........

while a 1.16 (and/or vanilla) server uses a json object for the description property:
"{"description":{"extra":[{"text":"A Minecraft Server"}],"text":""},"players":{........

The error originates in the async-minecraft-ping crate and needs further testing. Still unsure if the difference between the json responses is because of the version difference or mod vs vanilla.
After fixing the issue, it may be a good idea to support better error messages for async-minecraft-ping since the resulting error was invalid JSON response while the serde_json error it was converted from was invalid type: map, expected a string at line 1 column 15

Lastest pull request to async-minecraft-ping fixed this issue


If RawData is linking the linking RawData option should not be there

Currently, if a raw data is linking and you open the page in another tab, you could link to another RawData via the GUI. We do not tested if it was actually possible but the option should not be there.
cc @jessicalmetcalf

This was solved in: https://github.com/biocore/qiita/pull/1738


Small improvements after #417

A type annotation was overwritten by #417.
Also: Shouldn't allow_truncated be False by default?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 19 (94.74%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 94.522%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cantools/database/utils.py
18
19
94.74%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
6712

Relevant Lines:
7101

💛  - Coveralls

I looked again and it is indeed False by default. I am a little confused now, sorry 😄

I pushed a change and now this test fails:

FAIL: test_motohawk_decode_truncated (tests.test_database.CanToolsDatabaseTest)
Decoding truncated frames.
Traceback (most recent call last):
File "/home/runner/work/cantools/cantools/tests/test_database.py", line 638, in test_motohawk_decode_truncated
self.assertEqual(decoded, {'AverageRadius': 0.0, 'Enable': 'Disabled'})
AssertionError: {'Enable': 'Disabled', 'AverageRadius': 0.0, 'Temperature': 251.43} != {'AverageRadius': 0.0, 'Enable': 'Disabled'}

However, the temperature field should be in the valid range?

BO_ 496 ExampleMessage: 8 PCM1
SG_ Temperature : 0|12@0- (0.01,250) [229.52|270.47] "degK"  PCM1,FOO
SG_ AverageRadius : 6|6@0+ (0.1,0) [0|5] "m" Vector__XXX
SG_ Enable : 7|1@0+ (1,0) [0|0] "-" Vector__XXX

All fields of the message are inside the available two bytes.

hm, I vaguely remember that there was an issue, but I forgot what it was.  I think it is the latter...

@juleq: this should be merged IMO...


[BUG] ImageInput::open causes uncaught exception in macOS sandbox environment

OIIO Version <IP_ADDRESS> running in sandbox on macOS. I would usually just forgo the sandboxing altogether, but I'm making a QuickLook plugin that requires it.
Essentially, the plugin becomes authorized to read a file by the user requesting to QuickLook a file, and eventually that absolute file path gets passed to ImageInput::open. I'm not exactly sure why opening from an absolute file path would necessitate the creation of a directory_iterator, but I am not intimately familiar with the underworking of OIIO.
terminating with uncaught exception of type boost::filesystem::filesystem_error: boost::filesystem::directory_iterator::construct: Operation not permitted

Specifically a uncaught exception occurs when boost's directory_iterator is constructed. I know it's somewhere in filesystem.hpp as that is the only place where it gets called, but I'm not compiling from OIIO source so I don't get a fun stack trace to narrow it down. That's the next step, just wanted to put this on the radar!

I'm not sure why this is hitting an exception for you, but I think I do see where an exception can go uncaught. I will have a fix shortly.

Proposed solution in #2522

Looks like that would solve the exception! Now to see if ImageInput::open can actually read a sandbox-scoped file path...


[cluster-test] add json rpc address configuration

Motivation
Add json rpc address configuration for cluster tests. It is same with current rpc default config, specify it so that we can change default config to localhost only when we need.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
cluster test passed
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/libra/developers.libra.org, and link to your PR here.)

@bors-libra land


Is it possible to use classical converter with parameters in MultiBinding ?

Hi,
Is it possible to use classical converter with parameters in qc MultiBinding ?
More clearly, I want to bind the Text property of a TextBlock to display a text like this :
MyApplication v1.0
MyApplication comes from a string resource and 1.0 might comes from a IValueConverter class type to which I may pass the parameter myParameter .
I tried the XAML code below,
<TextBlock Text="{qc:MultiBinding '$V0 + \' v\' + $V1', V0={x:Static resx:Resources.String225}, V1={Binding Converter={StaticResource ProgramVersionConverter}, ConverterParameter='myParameter'}}"/>
But I get this Exception at runtime :
System.Windows.Markup.XamlParseException: 'Unable to set' Binding 'on property' V1 'of type' MultiBinding '. A 'Binding' can only be defined on a DependencyProperty of a DependencyObject. '
Am I in the rigth way or it is not possible to do it ?
Thank you for your attention.
Regards

I found the asnwer, I should have used P0 instead of V0 for the Converter .
P0 is accepting Binding expression whereas V0 accept constant expression.
The right way to write it is :
<TextBlock Text="{qc:MultiBinding '$V0 + \' v\' + $P0', V0={x:Static resx:Resources.String225}, P0={Binding Converter={StaticResource ProgramVersionConverter}, ConverterParameter='myParameter'}}"/>


Vickel: Watch coinfomania.com

Vickel requests the watch of the watch_keyword coinfomania\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

coinfomania\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


[DO-NOT-MERGE][SPARK-33228][SQL][2.4] Don't uncache data when replacing a view having the same logical plan

What changes were proposed in this pull request?

SPARK-30494's updated the CreateViewCommand code to implicitly drop cache when replacing an existing view. But, this change drops cache even when replacing a view having the same logical plan. A sequence of queries to reproduce this as follows;
// Spark v2.4.6+
scala> val df = spark.range(1).selectExpr("id a", "id b")
scala> df.cache()
scala> df.explain()
== Physical Plan ==
*(1) ColumnarToRow
+- InMemoryTableScan [a#2L, b#3L]
      +- InMemoryRelation [a#2L, b#3L], StorageLevel(disk, memory, deserialized, 1 replicas)
            +- *(1) Project [id#0L AS a#2L, id#0L AS b#3L]
               +- *(1) Range (0, 1, step=1, splits=4)

scala> df.createOrReplaceTempView("t")
scala> sql("select * from t").explain()
== Physical Plan ==
*(1) ColumnarToRow
+- InMemoryTableScan [a#2L, b#3L]
      +- InMemoryRelation [a#2L, b#3L], StorageLevel(disk, memory, deserialized, 1 replicas)
            +- *(1) Project [id#0L AS a#2L, id#0L AS b#3L]
               +- *(1) Range (0, 1, step=1, splits=4)

// If one re-runs the same query `df.createOrReplaceTempView("t")`, the cache's swept away
scala> df.createOrReplaceTempView("t")
scala> sql("select * from t").explain()
== Physical Plan ==
*(1) Project [id#0L AS a#2L, id#0L AS b#3L]
+- *(1) Range (0, 1, step=1, splits=4)

// Until v2.4.6
scala> val df = spark.range(1).selectExpr("id a", "id b")
scala> df.cache()
scala> df.createOrReplaceTempView("t")
scala> sql("select * from t").explain()
20/10/23 22:33:42 WARN ObjectStore: Failed to get database global_temp, returning NoSuchObjectException
== Physical Plan ==
*(1) InMemoryTableScan [a#2L, b#3L]
   +- InMemoryRelation [a#2L, b#3L], StorageLevel(disk, memory, deserialized, 1 replicas)
         +- *(1) Project [id#0L AS a#2L, id#0L AS b#3L]
            +- *(1) Range (0, 1, step=1, splits=4)

scala> df.createOrReplaceTempView("t")
scala> sql("select * from t").explain()
== Physical Plan ==
*(1) InMemoryTableScan [a#2L, b#3L]
   +- InMemoryRelation [a#2L, b#3L], StorageLevel(disk, memory, deserialized, 1 replicas)
         +- *(1) Project [id#0L AS a#2L, id#0L AS b#3L]
            +- *(1) Range (0, 1, step=1, splits=4)

Why are the changes needed?

bugfix.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Added tests.

Test build #130323 has started for PR 30157 at commit aba6916.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34925/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34925/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34925/
Test PASSed.

Test build #130323 has finished for PR 30157 at commit aba6916.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130323/
Test PASSed.

@maropu So this is not merged to branch-2.4, right? Is it not needed?

@maropu nvm, I saw the git log you committed it later.


Display the latest compatible version of an add-on, instead of the latest

This checks the user agent string for Thunderbird versions numbers, and compares them to the compatible versions for the add-on. It should allow add-on authors to upload beta-compatible versions without the add-on being shown as incompatible with ESR versions. At least in the detail view, for now.

I'll have to examine this when I'm back next week, but doing it only on the detail view seems super sketchy and confusing given that you typically decide to install an add-on from the search list or the discovery pane, not from the detail view.

I think it actually happens in all the views, and I'm trying to check that now, but my install is putting up a fight and won't start properly.

I merged this manually and resolved the conflicts before testing it. https://github.com/thundernest/addons-server/commit/cf94571bcdd01fa25b3442910903553c8f943b3e

Sorry, haven't had time to deal with this.

I feel like this might produce issues on the site when people visit it in Firefox though. For example, if you have a current version for 60.* and you upload a version for TB65, that will be the "newest version" according to the site, and so people won't be able to download the version for release via Firefox/Chrome without going into the version history(which they probably won't realize they have to do).

That's already the case, so at least we're not making things any worse. Perhaps there needs to be a setting for whatever is the current version, and use that when the UA string isn't from Thunderbird.

Yes, I'm going to push this and your other PRs live tomorrow morning. It doesn't make the experience worse, at least, so I think it's fine.
My main problem with it is that I think encouraging add-on authors to upload beta versions still creates a bad experience if you're not visiting the site in Thunderbird. That's probably how the vast majority of people install add-ons though, so I'm not too worried about it.
There is a 'current version' right now it's just that there's no easy way for an author to change it, it's just automatically changed whenever an approved version is added or one is deleted/unapproved.
I'm not sure if adding UI for that is even worth it, really. I guess it depends on how many times we're going to universally break add-on backwards compatibility in betas. Hopefully we won't make a habit of it.

I meant the current version of Thunderbird.


Define all common icons in src/base/icons/icons.json

@djahnie and me introduced an "icon service" for the bike kitchen theme and used it for the "pickup" and "feedback" icons.
To make the transition complete, we should define all common icons in Karrot in src/base/icons/icons.json and replace all direct usages with references to the icon service (e.g. $icons('pickup'))

I noticed some icons appear both with fa-fw class and without it. There are 3 solutions I can think of that are worth discussing before implementing everywhere:
make two copies of every icon that sometimes appears with fa-fw. ex. place and place_fw. This seems to be the direction the code is already going https://github.com/thumbsupep/karrot-frontend/blob/issue_1529/src/base/icons/icons.json#L7-L8
provide the get function with a second parameter that will specify whether to get the icon with fa-fw appended as a classname or not https://github.com/thumbsupep/karrot-frontend/blob/issue_1529/src/base/icons/index.js#L13
use template literals (it's an es6 thing) to add fa-fw inline whenever it's needed https://github.com/thumbsupep/karrot-frontend/blob/issue_1529/src/places/components/PlaceHeader.vue#L267
I'm in favor of option 2. it's backwards compatible for anywhere already using the icon method, will allow us to store potentially half as many icon names, and we're abstracting the fa-fw post-fix classname
My question is if it's more of a performance hit to append a string and call the turnery operator any time we get an icon. vs. just doing a lookup on an object of potentially twice the size.
I think the performance implications of both of those things are negligible, which puts me in favor of option 2.

fa-fw tells Font Awesome to make the icon fixed width. This is usually helpful to vertically align content. More on that: https://stackoverflow.com/questions/41140132/what-is-the-purpose-of-the-fa-fw-class
Besides Font Awesome, we sometimes use Material Icons. No matter which option you choose, it should allow replacing a FA icon with a Material icon or something else.
That rules out option 3, so you could go with option 2. I'm also fine with option 1 because it has less complexity. (Reducing complexity is more important than reducing duplication)

ah that makes sense. I'll stick with option 1. thanks!


No way to report issues for FastAnim

There's no way to report issues/bugs/crashes for the FastAnim mod.

FastAnim is no longer being supported.
I ended up finding out the mod did nearly nothing, and I find it unethical to continue the mod solely for downloads.


Clarification on US #427 Acceptance criteria 8 Confirmation messages after successfully creating a category

Dear Mr. Oleg
In Acceptance Criteria 8 of User Story #427 : "After successfully creating a category, the admin user should receive a confirmation message that the category has been added."
In this point, we suggest clarifying exactly how the administrator user receives the message:

Do we understand correctly that the confirmation message appears on the screen?
Can we specify that the text of the message should be: “Category was successfully created”?
After successfully creating a category, 'Categories' page is displayed ?

Waiting for your reply.
Sincerely, Anastasia Shoshu.

At the rally on 12/29/2023 with BA Oleh Nakonechniy and Ihor Kohut confirmed making these changes. They are added to the US.


[SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/catalyst/dynamicpruning

What changes were proposed in this pull request?
Follow-up work for #25600. In this PR, we move sql/dynamicpruning to sql/catalyst/dynamicpruning.
Why are the changes needed?
Fix the unexpected public APIs in 3.0.0 #27560.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UT.

cc @cloud-fan @maryannxue

Test build #118427 has started for PR 27581 at commit ec7ba69.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23184/
Test PASSed.

Test build #118427 has finished for PR 27581 at commit ec7ba69.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118427/
Test FAILed.

Test build #118541 has started for PR 27581 at commit 9329ce1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23296/
Test PASSed.

Nice!

Test build #118541 has finished for PR 27581 at commit 9329ce1.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118541/
Test FAILed.

retest it please

retest this please

Test build #118564 has started for PR 27581 at commit 9329ce1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23319/
Test PASSed.

Test build #118564 has finished for PR 27581 at commit 9329ce1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118564/
Test PASSed.

thanks, merging to master/3.0!

Thanks for the review.


new feature for 'watch helpful videos' section!!

Feature idea.
INFINITE SCROLL
I would like display your youtube  links in a better way by adding infinite scroll feature. which will enhance the look of this section and increase the user experience.
here is an example of how infinite scroll works
https://github.com/OSCode-Community/OSCodeCommunitySite/assets/123810454/f02b3f23-0ba2-4806-bbc2-d0b38a57ad63
currently the section looks like this

it is a bit clustered and not very appealing
I believe in a crowded online landscape, this feature will make your website stand out and provide a better user experience and engagement.
If you like my idea then @MonalikaPatnaik please assign it to me under the label GSSOC 2023.
Thank you

Hey @MonalikaPatnaik if you like my idea then please assign it to me under the label GSSOC 2023.

Hey yes yes...i loved your idea..you can start working on this!
Sorry for the delay!

no problem , also could you please add level tag

Hey level labels are added to the issues once their related PR is merged! I have mentioned it in the GitHub discussion too..

Will add level label to this once your PR gets approved and merged

@MonalikaPatnaik can i do this task under gssoc'23

Hey i think no further changes are req in this section


Zoom keeps crashing when PowerToys is installed.

Microsoft PowerToys version
0.49.1
Running as admin

[ ] Yes

Area(s) with issue?
General
Steps to reproduce
Install PowerToys. Open Zoom.
✔ Expected Behavior
Zoom should works fine.
❌ Actual Behavior
Zoom can be opened but but repeatedly showing the following error rendering it is completely unusable.

Uninstalling PowerToys solved the problem direcly.
I am not so sure but I think it has to do with the Video Conference Mute.
Other Software
Zoom version 5.8.3 (1581).

Duplicate of #13984

Thanks for reporting this. This issue is a duplicate.
I'm linking this issue to #13984 to centralize the discussion thread for tracking.
Thanks for your help to make PowerToys a better piece of software!

Having a similar issue with GoToMeeting's desktop client.  It will connect and audio is available but the interface goes unresponsive and the cursor is a spinning circle.  Have to click on it and get the "wait or close" error message.  Closing gives a message about there being a problem with GoToMeeting.


Fixed minor bug with DeviantartRipper

Category
This change is exactly one of the following (please change [ ] to [x]) to indicate which:

[x] a bug fix (Fix #790 )

Description
Now checks that a link starts with http before trying to download it
Testing
Required verification:

[x] I've verified that there are no regressions in mvn test (there are no new failures or errors).
[x] I've verified that this change works as intended.

[x] Downloads all relevant content.
[x] Downloads content from multiple pages (as necessary or appropriate).
[x] Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.

[x] I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

[ ] I've added a unit test to cover my change.

None of the failed tests are because of these changes


Diagram Error: path /80 vs port :80?

Hello,
In the diagram, the first blue square (from left to right), under "IIS: w3wp.exe: ASP.NET Core Module" shows the following URL:
http://contoso.com/80

The intended URL is probably:
http://contoso.com:80

to indicate the HTTP port IIS is listing on, not the URL path /80.
Thanks,
Brian

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f79e1c0d-cd31-acba-28b0-13e2994fad21
Version Independent ID: 72fa2c87-1098-6f75-13b7-9fedc05021e9
Content: ASP.NET Core Module
Content Source: aspnetcore/fundamentals/servers/aspnet-core-module.md
Service: asp.net-core
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

Yes, thanks for reporting that @bchavez ... I'll fix the image.


Feature/exercise

Create new freature
in feature page , cliking on "Start Exercise" and in "Exercixe" tab you can see exercise plane each day for 30 days

Codecov Report

Merging #227 (f9e44c8) into develop (21faa13) will decrease coverage by 1.88%.
The diff coverage is 59.15%.

@@             Coverage Diff             @@
##           develop     #227      +/-   ##
===========================================
- Coverage    99.22%   97.34%   -1.89%
===========================================
  Files           40       42       +2
  Lines         1546     1617      +71
===========================================
+ Hits          1534     1574      +40
- Misses          12       43      +31

Impacted Files
Coverage Δ

app/main.py
96.55% <ø> (ø)

app/routers/profile.py
89.32% <35.29%> (-10.68%)
:arrow_down:

app/routers/exercise.py
50.00% <50.00%> (ø)

app/routers/user_exercise.py
73.07% <73.07%> (ø)

app/database/models.py
96.63% <100.00%> (+0.17%)
:arrow_up:

app/routers/telegram.py
94.11% <0.00%> (-5.89%)
:arrow_down:

app/telegram/handlers.py
98.38% <0.00%> (-1.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21faa13...af3d449. Read the comment docs.

Hi
I fix all conflict files
Thanks
Oron

fix conflict files
Oron

fix all comments

fix conflict files

Fix conflict files

Fix conflict files

Hi
I fix all conflict files

Hi Yam
I still wating to response from Microsoft support ,
Meanwhile, I write the contact by my self and I remove all pictures, Because of copyright,
I convert exercise files from png to html file.
I create new path for html files  and I change the config file , so you can approve my pull request.
If Microsoft support, will return my and alowed my to use their images and screen shot , I just chage the path in the config file.
Hopefully now you can approve my pull request
Thanks
Oron

Hi Yam
I still wating to response from Microsoft support ,
Meanwhile, I write the contact by my self and I remove all pictures, Because of copyright,
I convert exercise files from png to html file.
I create new path for html files and I change the config file , so you can approve my pull request.
If Microsoft support, will return my and alowed my to use their images and screen shot , I just chage the path in the config file.
Hopefully now you can approve my pull request
Thanks
Oron

The images are still there.

Hi Yam
I remove all exercise images from the project
Thanks
Oron

fix all conflict files

The HTM files belong to Microsoft.

No. I wrote them ,

The HTM files belong to Microsoft.

No, I wrote the HTM file , I wrote in word and save as htm file.

The HTM files belong to Microsoft.

No, I wrote the HTM file , I wrote in word and save as htm file.

The content of the HTML was taken from the app, or from other sources.
You must not copyright content of others without their explicit approval, it's called plagiarism and it's usually illegal.
Please use Open Source documents which published under permissive licenses such as CC-BY, MIT, Apache 2 etc, or get the explicit approval of the original content creator.

Please use Open Source documents which published under permissive licenses such as CC-BY, MIT, Apache 2 etc, or get the explicit approval of the original content creator.

Ok , got checking another solution
Thanks
Oron

Please use Open Source documents which published under permissive licenses such as CC-BY, MIT, Apache 2 etc, or get the explicit approval of the original content creator.

Ok , got checking another solution
Thanks
Oron

Hi Yam
I gon a permission from microsoft support
Is it Ok for you?
Thanks
Oron

Hi Yam
I gon a permission from microsoft support
Is it Ok for you?
Thanks
Oron

No man. You can't contact Microsoft Support and ask them question regarding copyright, and obviously not about copyright of applications that belongs to 3rd party.
I've done the work for you and read the ToS of Microsoft Store. It says under subsection 33a:

a. Notices and procedure for making claims of intellectual property infringement.
Microsoft respects the intellectual property rights of third parties. If you wish to send a notice of intellectual property infringement, including claims of copyright infringement, please use our procedures for submitting Notices of Infringement (https://www.microsoft.com/info/cpyrtInfrg.aspx). ALL INQUIRIES NOT RELEVANT TO THIS PROCEDURE WILL NOT RECEIVE A RESPONSE.
Microsoft uses the processes set out in Title 17, United States Code, Section 512 to respond to notices of copyright infringement. In appropriate circumstances, Microsoft may also disable or terminate accounts of users of Microsoft services who may be repeat infringers.

Also, on Microsoft copyright portal they are not permitting to work with their content.
Note that in this page they explicitly write:

Do not alter the screenshot except to resize it.
Do not use portions of screenshots.
Do not include screenshots in your product user interface.
Do not use screenshots that contain third-party content.
Do not use screenshots that contain an image of an identifiable individual.

Please also note that the content creators are not Microsoft, but another person named SnegX. I don't know how to content him.

OK
First thanks a lot for your help 👍
I think the best and right solution would be to just ask a gym instructor about a 30 day workout program. This will be my original exercise program 💯
What do you think ?

That's an option, but why not go for an easier one? :)
Just Google workout plan open source and find something that provided as-is with a free license.

Hi Yam
I found an application with a free license.
https://veevapps.wordpress.com/2017/04/20/lose-weight-in-30-days-privacy-policy/
Hopefully now I can finish my task :) 👍

Hi Yam
I corresponded with the writer , Vera Mo<EMAIL_ADDRESS>and he gave me permission to create screenshot from his application.

Hopefully now you can approve my pull request.
Thanks
Oron

Please let them know you are going to integrate it into another application.
This is an important disclaimer which can affect the licensing.

Dear VeraApps,
For the past month I have been working on an open source calendar project.
I wanted to know if I could use content from your app (pictures and text of the exercises) and incorporate it into the calendar, in a way that everyone could use.
The project is published under the Apache2 license.
Here is a link to the project: https://github.com/PythonFreeCourse/calendar
Best Regards,
Oron

Hi
I send them an email , waiting for them response
Thanks
Oron

Hi Yam
Veev answer me . I  cannot use pictures and text of exercises.
I move to the next solution . write exercises by my self.
Thanks
Oron

Hi Yam
Since I did not find any open source with exercises , I wrote 30 exercise by my self with som help from gym instructor.
I wrote it in word and convert to HTM files.
Insted of "How to do..." I just add link to YouTube (I do not need license to publish).
Please let me know if its OK with you.
Thanks
Oron

That's OK Oron.
I appreciate your devotion to the goal.
From my side, you have finished the work on this ticket - it is considered a ticket for the certificate.
If you want to complete it for yourself - feel free to continue.

Hi Yam
Thanks a lot for your suppoer 👍
I really enjoyed learning from you python
Oron

Codecov Report

Merging #227 (ec126c3) into develop (2730ecf) will decrease coverage by 0.09%.
 Consider uploading reports for the commit 6f784b5 to get more accurate results

@@             Coverage Diff             @@
##           develop     #227      +/-   ##
===========================================
- Coverage    93.95%   93.85%   -0.10%
===========================================
  Files           93       93
  Lines         4383     4329      -54
===========================================
- Hits          4118     4063      -55
- Misses         265      266       +1

Impacted Files
Coverage Δ

app/main.py
96.00% <ø> (-0.08%)
:arrow_down:

app/routers/profile.py
85.60% <35.29%> (-7.44%)
:arrow_down:

app/routers/exercise.py
50.00% <50.00%> (ø)

app/routers/user_exercise.py
72.41% <72.41%> (ø)

app/database/models.py
97.51% <100.00%> (+0.26%)
:arrow_up:

app/routers/event.py
95.05% <100.00%> (ø)

app/routers/share.py
100.00% <0.00%> (ø)

app/database/schemas.py
100.00% <0.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2730ecf...6f784b5. Read the comment docs.


Reposition search-choice / search-field

Hi,
This one is more a CSS / HTML related question, and not a bug:
Is it possible to reposition the user selections boxes below / above the search-field (and not inside of it) in Multiple-Select mode?
Currently, each selection (li: 'search-choice') is nested inside ul: 'chosen-choices', but the 'search-field' is also placed as sibling.
Is there a way to change the structure so the selection would be below of the search-field?
Thanks.

Hi @bgadiel, I'm not sure.
You can do pretty much everything using CSS to customize it, but you are not able to change the HTML from Chosen as they hardcoded it.

@leocaseiro, thank you.


Consider using hardcoded revision number from stabilization/2409.

You are using stabilization_branch/2409 for this sim in README :
cd $DEMO_BASE
git clone https://github.com/o3de/o3de.git -b stabilization/2409
cd $DEMO_BASE/o3de
git lfs install
git lfs pull
python/get_python.sh
scripts/o3de.sh register --this-engine

It is totally fine, but keep in mind that this is a stabilization branch, and a number of folks from O3DE are working on release. If I were you, I would consider to use given, hard, revision number from stabilization/2409, until o3de version 2409 will be released.

I see no reason for using the stabilization branch for now, I would stick to the official release. @boczekbartek ?

Or use release 2310.3 as @jhanca-robotecai proposed!

If demo works on release 2310.3 it is fully fine with me to switch.


Browser support

Hi Eduardo,
Just wanted to ask what kind of browser support your aiming for with this? I was trying to build a similar thing a while back and ran into issues with ie8 and some older version on android not being able to read the contents on the :after or :before pseudo elements. See this question I posted http://stackoverflow.com/questions/12959199/how-can-i-capture-after-content-in-ie8/13138505#13138505
In the end I found this project https://github.com/JoshBarr/on-media-query which started using the font-family property instead to get around these issues. I used it a few times but went back to declaring my breakpoints in both styles and javascript. By the looks of it that project has been abandoned a bit.
Things may be at a point where the browsers that cannot read the contents on the :after or :before pseudo elements no longer matter but I thought i'd give you a heads up incase you were not familiar with JoshBarr's project.
Carl.

Actually thinking about it I wonder if the support for reading these values nicely overlaps with support with media queries. Back when I was trying to do this before I was serving respond.js to ie8 to emulate media queries. I have since learnt the error of my ways and now no longer try to polyfill media queries.
So the dream of declaring media queries once might be back on for me! I'll have to give your script a run and do some mobile testing. I'll let you know if I find anything interesting :)

@codekipple thanks for the heads up. This article also describes how the font-family property in the <head> can be used, so it's definitely something we can add to this script if it allows more people to use this script.
Let me know how you get on with your tests.
Thanks!


Advice on when/how to insert trace-id into logging context?

Hello! Thanks a lot for this library!
I would like to use MDC.put to put the trace-id into the logging context so that it gets included in all logs. But when I should do that? I guess I would need to define my own phase and insert it between Features and OpenTracingStart. Or? Thank you!

Hi Jakub, Thanks for your message!
As the OpenTracingStart phase is inserted before the Features phase, I recommend that you intercept the Features phase.
You can add a code block to the phase in your module function as such:
intercept(ApplicationCallPipeline.Features) {
   MDC.put("traceId", GlobalTracer.get().activeSpan().context().toTraceId())
}

Please let me know if you have any questions!
Francois

Thanks a lot! I fixed that via
    intercept(ApplicationCallPipeline.Features) {
        println("Intercept before: spanContext=" + current().spanContext)
        proceed()
        println("Intercept after: spanContext=" + current().spanContext)
    }

though I am not abandoning OpenTracing for OpenTelemetry. I will steal all the ideas from your code :-)

You're welcome! :)


Calling include? messes up relationship

I discovered this rather odd bug when I added authorization to my application. I noticed that when I added an extra iteration on a relationship in the authorization code, strange things happened in my view - references in the relationships multiplied!
I reproduced the issue as follows:
class Foo
  include Mongoid::Document
  has_and_belongs_to_many :bars, :class_name => 'Bar', :inverse_of => :foos
end

class Bar
  include Mongoid::Document
  has_and_belongs_to_many :foos, :class_name => 'Foo', :inverse_of => :bars
end

require 'mongoid'
require './foo'
require './bar'

Mongoid.database = Mongo::Connection.new('localhost','27017').db('bugs')
Mongoid.master.collections.reject { |c| c.name =~ /^system/}.each(&:drop) # Clean sheet

foo = Foo.create
foo.bars << Bar.create
puts foo.bars.count # 1, as expected

foo = Foo.first
puts foo.bars.to_a.count # 1, as expected
puts foo.bars.to_a.count # 1, as expected

foo = Foo.first
bar = Bar.first
puts foo.bars.include?(bar) # true, as expected
puts foo.bars.to_a.count # 1, as expected
puts foo.bars.to_a.count # 2, not expected!

Related to #1431.

The fix in #1431 fixes the case of #1445 only when #include? is called with the first element or no elements are found; any elements found beyond the first will result in duplicates. The reason for this is that elements will have been added to the loaded array, but since @executed = true never gets to be called, #each will start adding more from the beginning again.
One potential fix is to rewrite Mongoid::Relations::Targets::Enumerable#each as such:
    def each
      if loaded?
        loaded.each do |doc|
          yield(doc)
        end
      else
        unloaded.each do |doc|
          loaded.push(added.delete_one(doc) || doc)
        end
        @executed = true
        unloaded.each do |doc|
          yield(doc)
        end
      end
      added.each do |doc|
        yield(doc)
      end
    end

A potential problem with that is that it will eagerly load all elements before yielding. Another solution might be to clear the array before starting to load:
    def each
      if loaded?
        loaded.each do |doc|
          yield(doc)
        end
      else
        loaded.clear
        unloaded.each do |doc|
          yield(doc)
          loaded.push(added.delete_one(doc) || doc)
        end
      end
      added.each do |doc|
        yield(doc)
      end
      @executed = true
    end

I can verify that magnusstahre's solution solved the issue with the following monkey patch:
module Mongoid #:nodoc:
 module Relations #:nodoc:
   module Targets #:nodoc:
     class Enumerable
       def each
         if loaded?
           loaded.each do |doc|
             yield(doc)
           end
         else
           unloaded.each do |doc|
             loaded.push(added.delete_one(doc) || doc)
           end
           @executed = true
           unloaded.each do |doc|
             yield(doc)
           end
         end
         added.each do |doc|
           yield(doc)
         end
       end
     end
   end
 end
end

However, I assume this will affect performance negatively.

Thanks for all the suggestions - the best solution here was close to these, but to delete_one from the loaded array instead - the first pass would always catch duplicates in the added, the second pass would pull the duplicates from the loaded. This would be faster than a double iteration, and avoids removal of added docs that got transferred to the loaded array by performing a clear.


[BUG] Custom menu example not working properly on stackblitz

[ ] Bug report
stackblitz example that I forked
I added the class newClass in custom-menu.component.html and it does not appear in HTML inspection.
In the documentation it mentions adding the customMenuRef like this
<ngx-editor-menu
  [editor]="editor"
  [toolbar]="toolbar"
  [customMenuRef]="customMenu"
>
</ngx-editor-menu>

but the app.component.ts file doesn't tell how to create this ref. Maybe I'm missing something.
I'd very happy to create a PR to documentation once I find the fix.
I've already tried adding these to app.component.ts
customMenu = new CustomMenuComponent();
customMenu = CustomMenuComponent;
Best

Now I understand how it works. The top menu option for CodeMirror was not visible when stackblitz opened. (menu was cut off)
but I'm still curious how does the reference work here?

Now I understand how it works. The top menu option for CodeMirror was not visible when stackblitz opened. (menu was cut off)
but I'm still curious how does the reference work here?

Glad you figured it out. the documentation is little dull as of now, I couldn't find time to work on it. If you think anything can be improved anywhere in the documentation to avoid these scenarios, feel free to suggest improvements. All contributions are welcome.
Thanks.

Glad you figured it out. the documentation is little dull as of now, I couldn't find time to work on it. If you think anything can be improved anywhere in the documentation to avoid these scenarios, feel free to suggest improvements. All contributions are welcome.
Thanks.


allow fastLinkJS lowercased alias fastlinkjs

Low priority recommendation
sbt fastLinkJS works while sbt fastlinkjs does not.
camelCasing is idiomatic for source code, but a bit weird and tiresome for command-line tools. As far as I know, it's not common in the linux world where cli usage is heavy and users want to be able to execute commands effortlessly and fast, to have to worry about uppercasing every subsequent word in a command.  The sbt cli would feel a bit more ergonomic for people of that unix background if lower-cased versions of the command were allowed as well.

Thank you for taking the time to write your suggestions.
Unfortunatley, I have to disagree with this one. I agree that CLI tools would usually use all lower or kebab case, this is not sbt idiomatic: one example is sbt's core command testQuick.
I feel for the Scala.js sbt plugin, it is more important to be consistent with sbt than with general CLI feel.
You are of course free to upstream this to sbt (but I suspect that this will likely not get done, even just for compatibility reasons).
I'll close this opportunistically because I'm pretty sure @sjrd will agree. @sjrd in case you don't, please re-open :)


Merge pull request #1 from ccosse/master

scannind with master

http://apache.asymptopia.org/~dbenj/ggmc/
Hi Devon,
You probably already saw an email(s) from GitHub indicating that I did the
commit, pull and merge under your account.
I also went ahead and setup your personal webpage directory on the server
just to verify that it works as expected.
Your files on the server (also GitHub) are current and you could do the
following to verify:

cd ~public_html/ggmc
git status

-Charles
On Thu, Mar 10, 2016 at 8:56 PM, cloudking22<EMAIL_ADDRESS>wrote:

Closed #4 https://github.com/ccosse/ggmc/pull/4.
—
Reply to this email directly or view it on GitHub
https://github.com/ccosse/ggmc/pull/4#event-585745010.


Publish only ES modules, remove CJS target

Moving forward, this will be an ESM package.

Delayed indefinitely. :/


Fix/pkg versions

This PR:

addresses known vulnerabilities as reported by GitHub / npm.
fixes resource deallocation bugs, allowing Mocha to exit properly

closes the database after tests run
closes the session store after tests run

In other news, in debugging this for multiple hours today, I finally came across the solution… in an issue & PR which I had already contributed to a package last year. D'oh.


[WFCORE-2805] Use Xalan from JRE rather than our own fork

https://issues.jboss.org/browse/WFCORE-2805

@n1hility please approve

this requires further discussion

@n1hility where is the discussion going to happen? cc @wolfc

I am closing this PR as there has been no progress on this PR since June 2017.
Do not hesitate to reopen it if there is progress or an updated conversation about it, thanks


Multi-command with single key binding

please add a feature which will allow to perform multiple command with single key binding or keyboard shortcut

/duplicate of #871