List napa as dependency

I couldn't run npm install svg-to-geojson without having napa installed, either globally or local to the directory I was installing to. I think this would be nice to mention in the README?

Napa has now been removed as a dep.


feat: Separate ws subscribe requests

This separates all of the subscribe messages for our websocket providers into different messages.
Why
Almost all of the websocket providers batch every ticker they need to fetch into a single subscribe request. The result of this is that if a single market in that request fails, every one of the markets a provider is responsible for will not be fetched.
What
I've moved each market to a separate subscription request. This means that after a provider is spun up and a connection is created, the provider will attempt to make X Subscribe requests on that connection, where X is the number of markets it is responsible for fetching.
Our ws providers do not open multiple connections (afaict in this code path) so this change does not affect the number of open tcp connections and so should have zero impact on performance outside of slower startup time for fetching prices and slightly higher network consumption because of duplicated data sent during multiple subscribe requests that were previously being batched.

Dashboard looks good w/ these changes.
https://skipprotocol.grafana.net/dashboard/snapshot/2N7xOugZDVH7SnZxlc0XO8A5LJih9v9Q


⚠ Exoticaz has degraded performance

In f7efe80, Exoticaz ($EZ) experienced degraded performance:

HTTP code: 200
Response time: 5226 ms

Resolved: Exoticaz performance has improved in e52bed2.


Markup documentation indentation

From @KnisterPeter on December 1, 2015 18:20
Indentation is broken if elements are non-self-closing without closing tag (e.g. <input>)
Copied from original issue: sinnerschrader/patternplate-server#33

@KnisterPeter is this still a thing with React 0.14?

This appears to have been fixed with one of the client updates since December 1th


22.1-4 solution has no proof of algorithm complexity

if the neighbor is not already present in the new adjacency list of u

Traversing through adjacency list could take N operations if the adjacency list is full.
It should be explicitly stated that there is no need to. There are two cases depending on if we have already traversed the neighbour adjacency list in initial multigraph. If we did then we have already added u there during that traverse. If no then you should only check if u is a first element of neighbour adjacency list as we could not add anything else after it during current traverse.
This solution only works if initial multigraph is undirected. Am I understanding right if this is the case?

Hey, try this: https://walkccc.github.io/CLRS/Chap22/22.1/#221-4

It made me think for a while, but it is a nice one! Maybe it could have more proof in it to ease understanding.

I've rewritten the answer and tried to make it more readable!

Now it is the same as one I have created this issue about and is wrong because of the same reason. :( When you check if v belongs to new adjacency list of u it can take N operations and the algorithm complexity will be O(V + E * V).

I know what you were talking about!
I've corrected the solution with a matrix M of size |V|^2.
Please check it!

It is simple and correct now. Thanks. This repo should use it too.

Thanks, too. You can try to search solutions in my website if any further help is needed: http://walkccc.github.io/CLRS


Cervical Cancer Screening Pull Request

This is a pull request for the CDSS app I have developed.

The pull Request is based on the flowcahrt attached!
Cervical Cancer Screening Algorithm.pdf

New Pull Request

Final Commit with working Test Fixture


test test_rocks_titan_basic_ops_large_min_blob_size may hang forever

What did happened?
running 1 test
18:41:10  test engine::tests::test_rocks_titan_basic_ops_large_min_blob_size ...         SLOW [> 60.000s] engine_rocks engine::tests::test_rocks_titan_basic_ops_large_min_blob_size
18:42:06          SLOW [>120.000s] engine_rocks engine::tests::test_rocks_titan_basic_ops_large_min_blob_size
18:43:02          SLOW [>180.000s] engine_rocks engine::tests::test_rocks_titan_basic_ops_large_min_blob_size
...
SLOW [>4740.000s] engine_rocks engine::tests::test_rocks_titan_basic_ops_large_min_blob_size

detail: https://ci.pingcap.net/view/ghpr_tikv/job/cron_tikv_ghpr_coverage/622/console

/cc @Connor1996 @v01dstar PTAL.
@purelind found this case timeouted very frequently recently. E.g., https://do.pingcap.net/jenkins/blue/organizations/jenkins/tikv%2Ftikv%2Frelease-8.4%2Fpull_unit_test/detail/pull_unit_test/23/pipeline
https://do.pingcap.net/jenkins/blue/organizations/jenkins/tikv%2Ftikv%2Frelease-8.4%2Fpull_unit_test/detail/pull_unit_test/22/pipeline

Encountered it in the 8.4 branch as well, and it occurs quite frequently.

PTAL @v01dstar

I can't reproduce this on my laptop or with the CI's docker image. Is it possible to get the stack trace of the failed test? Just to know where it stuck may help.

@v01dstar Found another failure with the master branch: https://do.pingcap.net/jenkins/blue/organizations/jenkins/tikv%2Ftikv%2Fpull_unit_test/detail/pull_unit_test/2259/pipeline


no convex/config.ts? and no just?

I downloaded and installed the convex binary as explained.
However, in my ai-town folder, there is no file ./convex/config.ts
and when I try npm run dev I get:

<EMAIL_ADDRESS>predev
just convex dev --run init --until-success

'just' is not recognized as an internal or external command,
operable program or batch file.
what am I doing wrong?
I'm on windows 11.

It's convex/constants.ts we need to update the README for that.
You'll need to install just. I don't know how to do that on Windows ...
You're probably best using Pinokio (https://pinokio.computer/) if
installing AI town on Windows.
.m
On Tue, May 21, 2024 at 11:14 PM menguzat @.***> wrote:

I downloaded and installed the convex binary as explained.
However, in my ai-town folder, there is no file ./convex/config.ts
and when I try npm run dev I get:
@.*** predev
just convex dev --run init --until-success
'just' is not recognized as an internal or external command,
operable program or batch file.
what am I doing wrong?
I'm on windows 11.
—
Reply to this email directly, view it on GitHub
https://github.com/a16z-infra/ai-town/issues/237, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACWEFGFKNVJKO3LCI4L6CHDZDQZTXAVCNFSM6AAAAABIC5UF6GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYDSNRVGY4DANA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

There's a link in the README on installing just: https://github.com/casey/just?tab=readme-ov-file#installation


Everything turns black

According to your testing, does the issue occur with ONLY Portal Gun mod and Immersive Portals mod and Farbic API?
Yes
Describe the issue
When shooting the exit portal onto something, the whole world turns black and i can't see anything but the portal. I'm using Fabric (latest) for 1.20.4 and using version 6.2.1 of the mod which says it's for 1.20.4
Post the log here
No response

Are you using any rendering-related mods? Does the issue really occur with only fabric api, iPortal and portal gun mod? Can a normal nether portal render?


add :integer type

Resolves #42

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


All pipelines connections are secured by default from the client perspective

All pipelines connections are secured by default from the client perspective
Self-signed certificate: rhods/job/rhods-smoke/5967/console
Trusted certificate: I didn't find a way to run it with Jenkins. Not going to share the cluster here. Tested locally and passed

It could be useful for some test scenarios, no ?

I don't think a customer will send unencrypted data. The client is a computer that is not running in OpenShift.


Output Blazor version info in blazor.js or similar file

I don't think this is super important, but it would be nice to know what version of a Blazor my website is running by inspecting via view source code

Thanks for the suggestion.
Technically it is already possible to determine the version (e.g., by using ILDasm or ILSpy on the Microsoft.AspNetCore.Blazor.dll file delivered to your browser). I appreciate this isn't as convenient but it is an option if you need it.
Since this is a very obscure requirement, I hope you don't mind but I'm going to close it as "probably not, at least for now". We can always reconsider if more people keep asking for it in the future.


Add (caching) support for LocationAreaEncounters

The pokeapi has an attribute that doesn't follow their typical NamedAPIResource pattern: LocationAreaEncounters. Per the docs, when looking up a pokemon's location_area_encounters, it returns a string (URL to list LocationAreaEncounter).
It would be really awesome if pokebase's API implemented lookup and caching for this nonstandard resource. I glanced over the code in hopes of submitting a PR, but as a relative python n00b, I'm having some trouble gauging how best to do this. I'd rather not re-implement caching for this API endpoint outside pokebase.

FYI I requested background from the friend folks on slack

So here's the funny part ... the way location_area_encounters are shown in the PokeAPI docs, they should be automatically handled by creating NamedAPIResource objects (now APIResource objects). But they are implemented differently, so they are not handled by make_obj, hence why they need special handling now that I hadn't accounted for.
I've filed an issue on PokeAPI, but in the meantime I'll add special handling for them, to be included in the next release. (And then hopefully I can get a clear answer on what PokeAPI's planned way to handle them is, and clean up the wrapper code and the PokeAPI docs)
Good catch and thanks for the help! I'll close this issue once I write the fix and push the next release to PyPI.


Feat: Project Contributors List Page

What feature?
This is to create a new page for the project contributors. It will contain all the unique contributors with their profile pictures, names, and social handles. The page will look similar to the project page. It will contain a navbar, search bar, and footer but not a filter. The data will fetch from project.json.
Add screenshots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

previously we had contributors list, we don't want to add now


Merge of dev doc

cleaning code,
adding docs for graphs and preprocessing (to be written)
changing user_fooder to have only private attributes and handling the subsequent modifications

OK nickel.


I have just double checked that this now works correctly. It was a fix from @joaomoreno


Bypassing Maximum 4097 Tokens.

Hi @ysymyth, can you help me bypass the "This model's maximum context length is 4097 tokens. However, your messages resulted in 4238 tokens. Please reduce the length of the messages." error? Because many times I tried for this parameter:
n_generate_sample=5,
n_evaluate_sample=1,
n_select_sample=5
It always returns the error I mentioned above (both models, GPT4 and GPT-3.5-Turbo. Thank You.
To re-run your experiment on creative writing, what parameter should I use?

what's your error like? also, I think gpt-4 has 8192 tokens now?

Close it for now, feel free to open new ones.


Invalid param client_key error even with requireClientAuthentication.password disabled for Auth header

When the new requireClientAuthentication.password: false option is used (#346) to turn off client_secret, I'm getting an error on the is.vschar() check that has a regex requiring at least one char.  How is #346 and #377 being used by others?

ok, the trouble occurs only when using the Authenticate method for credentials.  Editing title.

Good catch! #404 was merged.


Doing a hot restart while the debugger is paused hangs.

Doing a hot restart while the debugger is paused hangs, which, because of https://github.com/flutter/flutter/issues/13395, then turns into a crash.
To reproduce, do flutter run, pause the debugger in the observatory, then hit R at the flutter terminal.
Marking m3 because this will affect users early in their development with Flutter.

This does affect IDEs too. The user hits restart and it seems to hang with "Performing hot reload" in the status bar and they just remain at the breakpoint. Hitting continue does nothing (sends a resume to observatory, but it's unresponsive and eventually you get timeout errors).
I had a report at https://github.com/Dart-Code/Dart-Code/issues/756

@mjohnsullivan told me he'd had some issues restarting lately; I suspect it could be this.

It's especially annoying in IDE's that have auto-reload on save (and you don't disable it).  It can be convenient, and some  user's may wish for it.
But if you had a breakpoint, you modify that file after figuring out a fix, but forget to hit "continue" before saving then you will have to stop the app and re-run it.  For me, when testing on iOS (android is faster), even for a somewhat small app that takes about 30 seconds (and you have to manually catch up to your previous state) which is really annoying when you're accustomed to the convenience of flutter reloading. (and does add up over time)

I suppose I should note, it seems to be a problem for me with reloads OR restarts.

@aam was this possible fixed by your fix for the timeout issue (comments suggest so)?
https://github.com/flutter/flutter/issues/17434#issuecomment-390264682

Similarly to https://github.com/flutter/flutter/issues/17434, this is fixed by the same patch that landed in https://github.com/flutter/flutter/commit/89cb5d268d2fc939f180dcee29df7a729fd051ef.

This issue hasn't been fixed for me. I'm still receiving it today.

Flutter 1.3.8 • channel beta • https://github.com/flutter/flutter.git
Framework • revision e5b1ed7a7f (2 weeks ago) • 2019-03-06 14:23:37 -0800
Engine • revision f4951df193
Tools • Dart 2.2.1 (build 2.2.1-dev.0.0 571ea80e11)

@ThinkDigitalRepair are you hitting this from an editor or command line? If an editor, does it happen from the command line? And can you repro it on a newly-created flutter create project?

Editor. From Intellij. I get a lot less issues with command line

On Mar 25, 2019, at 3:11 AM, Danny Tuppeny<EMAIL_ADDRESS>wrote:
@ThinkDigitalRepair https://github.com/ThinkDigitalRepair are you hitting this from an editor or command line? If an editor, does it happen from the command line? And can you repro it on a newly-created flutter create project?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/flutter/flutter/issues/13396#issuecomment-476130435, or mute the thread https://github.com/notifications/unsubscribe-auth/AV-HfXUpShDug1OP8ahMj9xd168TSZWQks5vaKDpgaJpZM4Q4qsv.

I don't know about getting lots from IntelliJ, but if you're able to reproduce it from the command line running with the -v flag (or in VS Code using the Dart: Capture Logs command), could you open a new issue and include the logs?

@DanTup I'm seeing this consistently with VSCode. To reproduce: set breakpoint in your code, once debugger is paused at breakpoint, click hot-restart in the debugging "mini floating toolbar" in VSC, VSC dispalys in boittom right hand corner the usual floating dialog "Syncing files to device XXXXX" and its just stays there forwever, progress indicator of dialog keeps going, hot-restart never actually completes.

@maks I don't seem to be able to reproduce - can you test this on a new clean project (eg. with Flutter: New Project or examples/flutter_gallery from the SDK) and give exact instructions on what you're doing (when and where you add the breakpoint, and exactly what steps you take) so I can try here?

My apologies I can't reproduce this on a new project either.
So far, the place in my app I'm seeing this happening consistently (hence my first comment) is where I was spending a lot of time debugging recently: in code that is in a MethodCallHandler for a MethodChannel (for Android).
My current app where I am seeing this is quite large so bit hard to figure out exactly the cause in order to create a simplified reproducable case, but I'll have a go in next few days.

@maks if you manage to repro - please open a new issue and ping me. I don't know if it's related, but it reminded me of these issues:
https://github.com/dart-lang/sdk/issues/37312
https://github.com/Dart-Code/Dart-Code/issues/1714
The first is believed to be fixed in the dev channel (maybe beta channel by now, but not stable), though the second may still be happening. When it seems to stop responding, clicking Pause then Resume seems to get it going again. If that seems to happen here, then it might be related (in which case @bkonyi may be interested in your repro).

I was seeing what I thought was similar behaviour and a search got me here. Although in my case it was when the debugger was breaking on exceptions, then hitting hot-restart that gave me the behaviour maks described.
I was able to repro my problem in a new clean project but only in a specific situation - throwing before runApp and having the debugger set to break on "All Exceptions", then hitting hot-restart.  In hindsight that was where I was seeing the problem so it's pretty specific and probably not the same problem but posting in case it's helpful.

@nickmeinhold if you have a small repro, please do open a new issue with it for someone to take a look.

Sure thing, thanks Dan, would you suggest in DartCode or Flutter?

Here is probably best, as if it's like the issues above, it may be a VM fix - but CC me on it and I can try to repro and check the logs in case there's anything obvious going wrong in Dart-Code.

I have the same behaviour with an almost new project @DanTup .
See https://www.screencast.com/t/ovrKFMCKfJpD
I did the same again and captured this time an observatory log. Sorry I should have made both together.
I this doesn't help I can make another screencast
Dart-Code-Log-2019-08-05 15-57-58.txt

@escamoteur thanks for the video and log - that one looks like a VS Code bug. When you click the Restart button in VS Code, we restart the app but never tell VS Code that we've unpaused (I thought it would be implied, but apparently not). This means VS Code thinks we're still paused somewhere when we're not, and shows the wrong button state (eg. continue buttons and no pause button).
I've opened https://github.com/Dart-Code/Dart-Code/issues/1994 for this.

FWIW I don't think that's the same issue Hixie was seeing when he opened this - it may be the same issue @nickmeinhold was seeing though. I'll close this one, and I'll put a dev build on https://github.com/Dart-Code/Dart-Code/issues/1994 once I've checked the fix isn't breaking any existing tests so you can try it out.


Update penis/dick length regex to catch more units --autopull

The "penis/dick x inches" regex at line 814 failed to catch a wingding post which used cm instead of inches (https://metasmoke.erwaysoftware.com/post/98237). This commit changes the regex to handle metric units as well as abbreviations, as well as when the length value and unit are not separated by a space.

!!/approve

Coverage remained the same at 65.779% when pulling 622d6848e4572d1ecd2c3d73205bf313af27d497 on bwDraco:patch-1 into<PHONE_NUMBER>3d9350ab2cf935c5c4d68128e66280 on Charcoal-SE:master.


Imporve training stability for nerfacto & update pixsfm param

I found that when training nerfacto for a long time (eg. 100000 iter+), it can possibly run into nan, after looking for similar issues, I found https://github.com/nerfstudio-project/nerfstudio/issues/873, and I tried gradient clipping but it did not work, disabling camera optimization helped a little, the training can go to 200000 iter+, but ran nan sooner.
After several experiments, I found that add sigmoid to geo embedding help to prevent from nan, but will reduce the psnr a little.  Another better way is to add lr decay through the scheduler, and I do not observe psnr loss. Both ways can lead to 400000 iters training without nan.
Also, I tried logging the variables to determine who appeared nan in the first place, I found it is the mlp_head who output RGB, the vars before it were normal as usual.  I haven't looked detailed into this tcnn.Network, maybe it will help to determine potential bugs
rgb = self.mlp_head(h).view(*outputs_shape, -1).to(directions)

Also I update the pixsfm parameter, previous setting can easily run into oom.

Might be good to break the PixSFM change into a separate PR. I'm not familiar with PixSFM but the scheduler changes look good, another thing that I've found can help with long training is using the RAdam optimizer instead of Adam. If the sigmoid embedding decreases PSNR and scheduling fixes the nan issue on its own I'd advocate for leaving the sigmoid embeddings out, unless theres another reason to use them?

Might be good to break the PixSFM change into a separate PR. I'm not familiar with PixSFM but the scheduler changes look good, another thing that I've found can help with long training is using the RAdam optimizer instead of Adam. If the sigmoid embedding decreases PSNR and scheduling fixes the nan issue on its own I'd advocate for leaving the sigmoid embeddings out, unless theres another reason to use them?

ok I will open individual PR


chore!: remove unsafe std::env::set_var

api difference for build scripts - https://github.com/dj8yfo/factory-rust/commit/fd7bcb1481a040cfed8d5b5d68ef2c44d31971d8
this has been extensively tested on following cases:
sample-crate

https://github.com/dj8yfo/sample_no_workspace/tree/2ab467216fc07b5700efdcc02bd46b64bdb41dc2 => sample-crate-100.testnet

https://github.com/dj8yfo/sample_no_workspace/tree/482fbc77032a9bce6ae86f90d7e564fa45e26c9e => sample-crate-101.testnet

factory-rust

https://github.com/dj8yfo/factory-rust/tree/871d854e1e4003917dcc9fe71f6e8d970c0789ec => repro-fct-62.testnet , ...

https://github.com/dj8yfo/factory-rust/tree/cd5bc1d4e5fefe018cb1b0b0304fcb04f265b943 =>  repro-fct-63.testnet , ...

https://github.com/dj8yfo/factory-rust/tree/0ffab4d96db5eb61f74ce6d1265657165de7e685 =>  repro-fct-64.testnet , ...

neardevhub

https://github.com/dj8yfo/neardevhub-contract/tree/53438d97f3402cb3d841fe401397f648f0a1fb0e  => community.devhub-uns0.testnet

https://github.com/dj8yfo/neardevhub-contract/tree/53438d97f3402cb3d841fe401397f648f0a1fb0e => community.devhub-uns2.testnet.wasm

@race-of-sloths ping

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Current status: waiting for scoring
We're waiting for maintainer to score this pull request with @race-of-sloths score [0,1,2,3,5,8,13] command. Alternatively, autoscoring [1,2] will be applied for this pull request
What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow
For contributors:

Tag @race-of-sloths inside your pull requests
Wait for the maintainer to review and score your pull request
Check out your position in the Leaderboard
Keep weekly and monthly streaks to reach higher positions
Boast your contributions with a dynamic picture of your Profile

For maintainers:

Score pull requests that participate in the Race of Sloths
Engage contributors with fair scoring and fast responses so they keep their streaks
Promote the Race to the point where the Race starts promoting you
Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

For contributors

Include a PR: @race-of-sloths include to enter the Race with your PR

For maintainers:

Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called


Update ColumnReader readOffset_ in a unified way

Previously, the readOffset_ in the selective ColumnReaders is updated at
various places when the read is finished: 1) filterNulls();
2) readWithVisitor(); 3) StringColumnReader::readHelper(); 4) at the end
of read() itself for complex types. Among these functions, the first 3
were called by read() under different situations. There are also multiple
locations within a function that the readOffset_ is updated due to early
returns. All these made debugging harder because it's hard to find where
the readOffset_ is updated.
We shall notice that all ColumnReaders need to update the readOffset_ at
the end of read(), and this commit unifies the updating of readOffset_
this way at one location.
The other reason of this change is because the filterNulls() and
readWithVisitor() may be called multiple times for a batch in the Parquet
reader, one for each page. However we may not want to advance readOffset_
until the whole batch finishes.
There is also a slight refactoring in some readCommon() functions to
remove the early return to make the debugging experience easier.

@Yuhta @xiaoxmeng WIll you be able to review this PR? Thank you!

@Yuhta Hi Jimmy thanks for reviewing again. How can I help with the FB LInter error?


RR.prototype._domainToName

Hello, i maybe found a bug, or i just doing something wrong.
in RR.prototype._domainToName the size of the buffer name can't be valid.
I thought the buffer is build like folloing:
1 Byte: length of label1
x Byte: label1
1 Byte: length of labelX
x Byte: labelX
1 Byte: 0
so i think in RR.js on line 26 must look like that:
var name = new Buffer(domain.length + 1 + labels.length);

HI @Zadagu
The domain length is equal to each label + 1 byte so the buffer size is right.
example: google.com.
labels = ["google", "com", ""]
buffer = "6google3com0"
Because there are an empty element in the labels array, the 0 byte is written in the for statement, so I have to remove the line 34 to avoid a buffer overflow.


Extracting per-residue/per-protein embeddings on GPU

Hey,
Thank you for doing the research which is needed in order to many biotech issues.
Is there any plan to add support for extracting per-residue embeddings on GPU (multi-GPU)?
...

# Extract per-residue embeddings (on CPU)
with torch.no_grad():
    results = model(batch_tokens, repr_layers=[34])

...

I have another question: how can I apply ESM embedding to get per-protein vector?
Is it enough if I will apply mean(dim=0)?
Thanks,
Piotr

Hi Piotr, thanks for your interest and these great questions!
Yes, you can certainly extract per-residue embeddings on GPU. It's as easy as calling model.cuda() before extracting the representations. Here's a short tutorial explaining this in more detail.
To answer your second question, you can get per-protein vectors by averaging the representations. It's a little more complicated than applying mean(dim=0) because it's important to (a) drop the initial beginning of sentence token; and (b) remove all padding tokens. You can use the provided extract.py script with --include mean to do this automatically. Here's the relevant line of code that applies the mean pooling.
I'm closing out this issue, but feel free to reopen if you have any more questions.


Synset intersection

In the old DanNet data, some synsets interset, i.e. their senses overlap.
For example, De Forenede Stater§1 is used in two different synsets.
In some cases this is due to an error, while in others it is due to systematic polysemy. In any case, new senses will need to be generated and the synset-sense relations will need to be remapped accordingly.

Now that #46 has been fixed, some intersections should have been removed. #60 should be fixed next and hopefully this will remove much of the remaining synset intersection.


getCurrentChannel fails if there is no current channel

Bug Report
Steps to Reproduce:
Run conformance test getCurrentChannel (FDC31.2)
Expected Result:
Promise of null
Actual Result:
Exception thrown;
Additional Context:
 getCurrentChannel: async () => {
      const result: ChannelData = await sendMessage(
        FDC3_1_2_TOPICS.GET_CURRENT_CHANNEL,
        {},
      );

      return createChannelObject(
        result.id,
        result.type,
        result.displayMetadata || { name: result.id },
      );
    },

in the above code from api.ts, result is null but nevertheless it tries to create a channel object.

I might try and fix this later if I have time.


Pls help me with long text voice problem

when i ran long text voice test codes, there were some errors on the screen. Pls help me how to fix it. Thanks.

import os
os.environ["CUDA_VISIBLE_DEVICES"] = "0"
from IPython.display import Audio
import nltk  # we'll use this to split into sentences
import numpy as np
from bark.generation import (
...     generate_text_semantic,
...     preload_models,
... )
torch version does not support flash attention. You will get significantly faster inference speed by upgrade torch to newest version / nightly.
from bark.api import semantic_to_waveform
from bark import generate_audio, SAMPLE_RATE
preload_models()
speaker_lookup = {"Samantha": "v2/en_speaker_9", "John": "v2/en_speaker_2"}
Script generated by chat GPT
script = """
... Samantha: Hey, have you heard about this new text-to-audio model called "Bark"?
...
... John: No, I haven't. What's so special about it?
...
... Samantha: Well, apparently it's the most realistic and natural-sounding text-to-audio model out there right now. People are saying it sounds just like a real person speaking.
...
... John: Wow, that sounds amazing. How does it work?
...
... Samantha: I think it uses advanced machine learning algorithms to analyze and understand the nuances of human speech, and then replicates those nuances in its own speech output.
...
... John: That's pretty impressive. Do you think it could be used for things like audiobooks or podcasts?
...
... Samantha: Definitely! In fact, I heard that some publishers are already starting to use Bark to create audiobooks. And I bet it would be great for podcasts too.
...
... John: I can imagine. It would be like having your own personal voiceover artist.
...
... Samantha: Exactly! I think Bark is going to be a game-changer in the world of text-to-audio technology."""
script = script.strip().split("\n")
script = [s.strip() for s in script if s]
script
['Samantha: Hey, have you heard about this new text-to-audio model called "Bark"?', "John: No, I haven't. What's so special about it?", "Samantha: Well, apparently it's the most realistic and natural-sounding text-to-audio model out there right now. People are saying it sounds just like a real person speaking.", 'John: Wow, that sounds amazing. How does it work?', 'Samantha: I think it uses advanced machine learning algorithms to analyze and understand the nuances of human speech, and then replicates those nuances in its own speech output.', "John: That's pretty impressive. Do you think it could be used for things like audiobooks or podcasts?", 'Samantha: Definitely! In fact, I heard that some publishers are already starting to use Bark to create audiobooks. And I bet it would be great for podcasts too.', 'John: I can imagine. It would be like having your own personal voiceover artist.', 'Samantha: Exactly! I think Bark is going to be a game-changer in the world of text-to-audio technology.']
pieces = []
silence = np.zeros(int(0.5*SAMPLE_RATE))
for line in script:
...     speaker, text = line.split(": ")
...     audio_array = generate_audio(text, history_prompt=speaker_lookup[speaker], )
...     pieces += [audio_array, silence.copy()]
...
Traceback (most recent call last):
File "", line 3, in
File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bark\api.py", line 107, in generate_audio
semantic_tokens = text_to_semantic(
File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bark\api.py", line 25, in text_to_semantic
x_semantic = generate_text_semantic(
File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bark\generation.py", line 385, in generate_text_semantic
assert (history_prompt in ALLOWED_PROMPTS)
AssertionError
Audio(np.concatenate(pieces), rate=SAMPLE_RATE)
Traceback (most recent call last):
File "", line 1, in
File "<array_function internals>", line 200, in concatenate
ValueError: need at least one array to concatenate
save audio to disk
write_wav("C:\bark_generation.wav", SAMPLE_RATE,np.concatenate(pieces) )
Traceback (most recent call last):
File "", line 1, in
NameError: name 'write_wav' is not defined

hmm, are you on the newest version of bark? looks like it thinks the history prompt is not supported. do they work for you in a normal generation (not long form?)

settled, Thanks.
I forgot step “pip install .”


Stuck at 99.17%

On any number, if it stops, that repository has probably been deleted. You can delete that line using the corresponding line number and run the command again.
For example, in your image, the repository is line 120 of the file
https://github.com/AggressiveUser/AllForOne/blob/main/PleaseUpdateMe.txt
It is not available. Removing line 120 solves the problem


Idea: Use Kalman filter position variance to reduce search area

Something to investigate in the future. When attempting to reacquire tracking lock on a lost object, it might be possible to use the filter variance for position to estimate a bounding box for the search area. This could possibly help with reducing the search time, and with avoiding erroneous LED matches.

Over the past week or so I have implemented a bunch of matching rules that use the previous prior to identity more likely matches, and to reject unlikely ones.

I'm calling this done.


on running the train.py comes KeyError: 'vb'? how to solve this?

Setting up a new session...
Setting up a new session...
Setting up a new session...
Logging to ./results
creating model and diffusion...
creating data loader...
training...
Traceback (most recent call last):
File "scripts/segmentation_train.py", line 89, in
main()
File "scripts/segmentation_train.py", line 62, in main
lr_anneal_steps=args.lr_anneal_steps,
File "./guided_diffusion/train_util.py", line 189, in run_loop
self.run_step(batch, cond)
File "./guided_diffusion/train_util.py", line 214, in run_step
lossseg, losscls, lossrec, sample = self.forward_backward(batch, cond)
File "./guided_diffusion/train_util.py", line 260, in forward_backward
losscls = (losses["vb"] * weights).mean().detach()
KeyError: 'vb'

Hi
Have you set the flat --learn_sigma True ?
Then, losses["vb"] should not give any key error.

do you have a pretrained model on BRATS2020?

Can you give me your E-mail. I want to talk about this Net-Model with you.


wrong addon ID in JSON manifest

After the Addon has been re-published it's ID has changed. Because of that the connection from KeeWeb to the Addon fails. To fix it, you have to replace<EMAIL_ADDRESS>with<EMAIL_ADDRESS>in the %AppData%\KeeWeb\native-messaging-kwc.firefox.json

there is already a pull-request for resolving this, but it could be a while until it gets merged / a new release
https://github.com/keeweb/keeweb/pull/2174

You're talking about Firefox. It's merged :slightly_smiling_face:
Should be in the next release

You're talking about Firefox. It's merged 🙂
Should be in the next release

Great to hear! But the desktop versions hasn't seen an update in 3 years, so lets see when the next release is ready 😅

After the Addon has been re-published it's ID has changed. Because of that the connection from KeeWeb to the Addon fails. To fix it, you have to replace<EMAIL_ADDRESS>with<EMAIL_ADDRESS>in the %AppData%\KeeWeb\native-messaging-kwc.firefox.json

Thanks! This fix the issue on my side
Keeweb v1.18.7 and Keeweb Connect v<IP_ADDRESS> on Firefox


tests: get Invenio running in a different language

Test that we can run Invenio in a different language.
Likely we need better language and timezone selectors than the ones there now (possibly the need to be added in other modules).
E.g. timezone could be a preference set in a user profile as well as language.
Additionally, do we want to keep the Invenio legacy pattern of appending the language as a query string ?ln=da
Ping @tiborsimko @jirikuncar

E.g. timezone could be a preference set in a user profile as well as language.

:+1: / cc @SamiHiltunen


UI: Render bug?

I think there is a render bug in the UI.
I have this trace.
The root span and the first child span really ends at the same time, but still, the child span looks like it completes after the root span:

Here is the metrics of the root span

Completes at relative time 143 ms
Here are the metrics of the child span:

Completes at relative time 143 ms
When looking at the JSON, it looks strange, because they both have the same duration, but the child span has a later timestamp.
[
  {
    "traceId": "47e2e4369bcf4e7e",
    "id": "47e2e4369bcf4e7e",
    "name": "main",
    "timestamp":<PHONE_NUMBER>242426, //first timestamp
    "duration": 143061,  //<----- same duration
  ...snip
  },
  {
    "traceId": "47e2e4369bcf4e7e",
    "id": "4234a32f8ace0f08",
    "name": "get /customers",
    "parentId": "47e2e4369bcf4e7e",
    "timestamp":<PHONE_NUMBER>253406, //later timestamp
    "duration": 143061,  //<----- same duration

I have checked the code of the C# provider I'm using, and the timestamp and duration is never explicitly set. So I assume those values comes from the annotations when sending it to Zipkin?
Also, wouldnt it be good to show both the CS/CR and the SR/SS intervals in the UI?
so one can see when the call was issued from the client, and when the server started processing?
e.g. different colors of the bars or something..
To me it looks like the bar length is now calculated from the CS/CR interval, but the timestamp itself seems to be when the SR started.
Or am I misinterpreting this completely?

Hi, Roger.
Can you click the JSON button and add that to the issue? It will help us
figure out what's up.
-A

Sure
[
  {
    "traceId": "48c1b3160196c098",
    "id": "48c1b3160196c098",
    "name": "main",
    "timestamp":<PHONE_NUMBER>307624,
    "duration": 199117,
    "annotations": [
      {
        "timestamp":<PHONE_NUMBER>307624,
        "value": "sr",
        "endpoint": {
          "serviceName": "client",
          "ipv4": "<IP_ADDRESS>",
          "port": 80
        }
      },
      {
        "timestamp":<PHONE_NUMBER>506741,
        "value": "ss",
        "endpoint": {
          "serviceName": "client",
          "ipv4": "<IP_ADDRESS>",
          "port": 80
        }
      }
    ]
  },
  {
    "traceId": "48c1b3160196c098",
    "id": "48c898fd24ab75a4",
    "name": "get /customers",
    "parentId": "48c1b3160196c098",
    "timestamp":<PHONE_NUMBER>318643,
    "duration": 199117,
    "annotations": [
      {
        "timestamp":<PHONE_NUMBER>307624,
        "value": "cs",
        "endpoint": {
          "serviceName": "client",
          "ipv4": "<IP_ADDRESS>",
          "port": 80
        }
      },
      {
        "timestamp":<PHONE_NUMBER>318643,
        "value": "sr",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      },
      {
        "timestamp":<PHONE_NUMBER>493766,
        "value": "ss",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      },
      {
        "timestamp":<PHONE_NUMBER>506741,
        "value": "cr",
        "endpoint": {
          "serviceName": "client",
          "ipv4": "<IP_ADDRESS>",
          "port": 80
        }
      }
    ],
    "binaryAnnotations": [
      {
        "key": "Request",
        "value": "some payload",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      },
      {
        "key": "Result",
        "value": "some result",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      }
    ]
  },
  {
    "traceId": "48c1b3160196c098",
    "id": "406faffcd864013d",
    "name": "select orders",
    "parentId": "48c898fd24ab75a4",
    "timestamp":<PHONE_NUMBER>452666,
    "duration": 52099,
    "annotations": [
      {
        "timestamp":<PHONE_NUMBER>441667,
        "value": "cs",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      },
      {
        "timestamp":<PHONE_NUMBER>452666,
        "value": "sr",
        "endpoint": {
          "serviceName": "orderdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      },
      {
        "timestamp":<PHONE_NUMBER>483168,
        "value": "ss",
        "endpoint": {
          "serviceName": "orderdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      },
      {
        "timestamp":<PHONE_NUMBER>493766,
        "value": "cr",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      }
    ],
    "binaryAnnotations": [
      {
        "key": "sql.query",
        "value": "select * from Orders where OrderId = 123",
        "endpoint": {
          "serviceName": "orderdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      }
    ]
  },
  {
    "traceId": "48c1b3160196c098",
    "id": "46320d346edc5a84",
    "name": "select customers",
    "parentId": "48c898fd24ab75a4",
    "timestamp":<PHONE_NUMBER>329640,
    "duration": 123024,
    "annotations": [
      {
        "timestamp":<PHONE_NUMBER>318643,
        "value": "cs",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      },
      {
        "timestamp":<PHONE_NUMBER>329640,
        "value": "sr",
        "endpoint": {
          "serviceName": "customerdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      },
      {
        "timestamp":<PHONE_NUMBER>430668,
        "value": "ss",
        "endpoint": {
          "serviceName": "customerdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      },
      {
        "timestamp":<PHONE_NUMBER>441667,
        "value": "cr",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      }
    ],
    "binaryAnnotations": [
      {
        "key": "sql.query",
        "value": "select * from Customers where CustomerId = 123",
        "endpoint": {
          "serviceName": "customerdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      }
    ]
  }
]

nit: the service logging "sr", "ss" is called "client". That means "client" is a server that received a request, and sent a response. I think that's probably wrong.

the middle span 48c898fd24ab75a4 is very strange compared to its parent. It is unlikely a server can receive a request and send an outbound one with no overhead w/in the same microsecond. if it can.. I want one!

so far.. I think there is a bug here. the span looks valid to me (even if unrealistic for a few spots, looks ok). I'm going to dig deeper into why the parent is offset.

The lack of overhead is intentional just to see if there is any overhead to the C# provider, just to see that it doesnt introduce milliseconds latency on each request.

ahh I think I found it. The timestamp is wrong on the second span.

Span.timestamp is when the span began. This says that the first annotation ("cs") was written 11ms before the span began! You'll notice if you set the timestamp to the minimum, it renders properly
  {
    "traceId": "48c1b3160196c098",
    "id": "48c898fd24ab75a4",
    "name": "get /customers",
    "parentId": "48c1b3160196c098",
    "timestamp":<PHONE_NUMBER>318643,
    "duration": 199117,
    "annotations": [
      {
        "timestamp":<PHONE_NUMBER>307624,

in general, span.timestamp and span.duration should be added when the host is authoritative for that span, ie. they started it.
For example, if you start a root span, then setting timestamp, duration is a good idea. It is also a good idea when you start a client span. However, if you are a server receiving a span that was started by a client, setting Span.timestamp, duration is likely invalid.

added docs here, which should hopefully help others with the same problem https://github.com/openzipkin/openzipkin.github.io/pull/46

cc @Horusiath
Where does the timespan and duration come from?
From what I can see, its not set at all in the thrift payload:
        public static Span ToThrift(this Zipkin.Span span)
        {
            var s = new Span
            {
                TraceId = (long)span.TraceHeader.TraceId,
                Id = (long)span.TraceHeader.SpanId,
                Name = span.Name,
                Debug = span.TraceHeader.IsDebug,
               //No values provided for duration or timestamp
            };

            if (span.TraceHeader.ParentId.HasValue) s.ParentId = (long)span.TraceHeader.ParentId.Value;

            s.__isset.annotations = span.Annotations.Count != 0;
            foreach (var annotation in span.Annotations)
            {
                var thrifted = annotation.ToThrift();
                var ep = thrifted.__isset.host ? thrifted.Host : span.Endpoint.ToThrift();
                ep.ServiceName = span.ServiceName;
                thrifted.Host = ep;
                s.Annotations.Add(thrifted);
            }

            s.__isset.binary_annotations = span.BinaryAnnotations.Count != 0;
            foreach (var binaryAnnotation in span.BinaryAnnotations)
            {
                var thrifted = binaryAnnotation.ToThrift();
                var ep = thrifted.__isset.host ? thrifted.Host : span.Endpoint.ToThrift();
                ep.ServiceName = span.ServiceName;
                thrifted.Host = ep;
                s.BinaryAnnotations.Add(thrifted);
            }

            return s;
        }

So is it the Zipkin server that calculates and sets the timespan and duration or where does it come from?

@rogeralsing thanks for looking into this. I'll check the logic on the server-side to see if it could have caused this.

I believe it was a server problem in this case. https://github.com/openzipkin/zipkin/issues/1281

Can you try with zipkin 1.10? seems to calculate properly when instrumentation don't set timestamp/duration. Please re-open if it is a problem, still.
$ curl -vs <IP_ADDRESS>:9411/api/v1/spans -H'Content-type: application/json' -H 'Expect:' -d '[
  {
    "traceId": "48c1b3160196c098",
    "id": "48c1b3160196c098",
    "name": "main",
    "annotations": [
      {
        "timestamp":<PHONE_NUMBER>307624,
        "value": "sr",
        "endpoint": {
          "serviceName": "client",
          "ipv4": "<IP_ADDRESS>",
          "port": 80
        }
      },
      {
        "timestamp":<PHONE_NUMBER>506741,
        "value": "ss",
        "endpoint": {
          "serviceName": "client",
          "ipv4": "<IP_ADDRESS>",
          "port": 80
        }
      }
    ]
  },
  {
    "traceId": "48c1b3160196c098",
    "id": "48c898fd24ab75a4",
    "name": "get /customers",
    "parentId": "48c1b3160196c098",
    "annotations": [
      {
        "timestamp":<PHONE_NUMBER>307624,
        "value": "cs",
        "endpoint": {
          "serviceName": "client",
          "ipv4": "<IP_ADDRESS>",
          "port": 80
        }
      },
      {
        "timestamp":<PHONE_NUMBER>318643,
        "value": "sr",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      },
      {
        "timestamp":<PHONE_NUMBER>493766,
        "value": "ss",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      },
      {
        "timestamp":<PHONE_NUMBER>506741,
        "value": "cr",
        "endpoint": {
          "serviceName": "client",
          "ipv4": "<IP_ADDRESS>",
          "port": 80
        }
      }
    ],
    "binaryAnnotations": [
      {
        "key": "Request",
        "value": "some payload",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      },
      {
        "key": "Result",
        "value": "some result",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      }
    ]
  },
  {
    "traceId": "48c1b3160196c098",
    "id": "406faffcd864013d",
    "name": "select orders",
    "parentId": "48c898fd24ab75a4",
    "annotations": [
      {
        "timestamp":<PHONE_NUMBER>441667,
        "value": "cs",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      },
      {
        "timestamp":<PHONE_NUMBER>452666,
        "value": "sr",
        "endpoint": {
          "serviceName": "orderdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      },
      {
        "timestamp":<PHONE_NUMBER>483168,
        "value": "ss",
        "endpoint": {
          "serviceName": "orderdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      },
      {
        "timestamp":<PHONE_NUMBER>493766,
        "value": "cr",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      }
    ],
    "binaryAnnotations": [
      {
        "key": "sql.query",
        "value": "select * from Orders where OrderId = 123",
        "endpoint": {
          "serviceName": "orderdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      }
    ]
  },
  {
    "traceId": "48c1b3160196c098",
    "id": "46320d346edc5a84",
    "name": "select customers",
    "parentId": "48c898fd24ab75a4",
    "annotations": [
      {
        "timestamp":<PHONE_NUMBER>318643,
        "value": "cs",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      },
      {
        "timestamp":<PHONE_NUMBER>329640,
        "value": "sr",
        "endpoint": {
          "serviceName": "customerdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      },
      {
        "timestamp":<PHONE_NUMBER>430668,
        "value": "ss",
        "endpoint": {
          "serviceName": "customerdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      },
      {
        "timestamp":<PHONE_NUMBER>441667,
        "value": "cr",
        "endpoint": {
          "serviceName": "fakewebapi",
          "ipv4": "<IP_ADDRESS>",
          "port": 9000
        }
      }
    ],
    "binaryAnnotations": [
      {
        "key": "sql.query",
        "value": "select * from Customers where CustomerId = 123",
        "endpoint": {
          "serviceName": "customerdb",
          "ipv4": "<IP_ADDRESS>",
          "port": 1234
        }
      }
    ]
  }
]'

It looks correct now, thanks!

Whew.. thanks for checking back!
On 10 Sep 2016 23:56, "Roger Johansson"<EMAIL_ADDRESS>wrote:

It looks correct now, thanks!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/1280#issuecomment-246119439,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD6183FqN2Aay5GdzLEERqBf2cNwkf0ks5qotMPgaJpZM4J4hpJ
.


Update Certificate#verify to allow nullable params

Description
Updates Certificate#verify params:

certificateRequest with a default value of null
anchorCertificate with a default value of null
ancestorCertificateChain with a default value of an empty list

as a feature parity to iOS' implementation. This change will allow developers to verify a stored certificate.

This PR looks like it's doing more than allowing nullable params?


Link Fast/Slow actions in combat tracker with token statuses

Description
In YZE Actions module when you click on fast/slow action in the tracker, it also adds/removes a status icon on a token. In YZE Combat those are not synced and you have to manually add statuses.
Suggested solution
Implement the same behavior as in YZE Actions module.
Alternative
No response
Additional context
No response
Validations

[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Actually, this suggested behavior is conflicting with the duplicate combatant option.
E.g: Add the status icon to a token, and all combatants and duplicates linked to that token will get the status icon. Which is an issue if your duplicate representing another initiative card for that token has not acted yet.
A solution could be to add a setting option that allows the GM to choose this behavior anyway.

Are duplicate combatants particularly common? This feature is something I would use for every combatant in every combat.

Are duplicate combatants particularly common? This feature is something I would use for every combatant in every combat.

Yes. Duplicate combatant is mainly used for monsters with multiple speed/initiative/ferocity : It's used in Forbidden Lands, ALIEN RPG, Dragonbane, and some in Mutant Year Zero.


Help Embed added

I added an embedded help command to the KoalaBot.py file. I added it here (for now) because I am still working on making it a paginator. I ran into an issue when installing DiscordUtils from https://pypi.org/project/DiscordUtils/ as my machine failed to install PyNacl several times which delayed the process of importing the pagination.  Once it did manage to install PyNacl it started having issues installing DiscordUtils so this is an ongoing troubleshooting process.
As I am stuck for a while with the pagination I started working on an Info.py cog which will be its own pr.

Take a look at https://github.com/Rapptz/discord.py for PyNaCl instructions. Make sure that if you need to install any new packages you show it in readme.md, and if you change or import any new pip libs, update requirements.txt and production-requirements.txt.

Also please set the PR as a draft for now, once you believe you are done you can then set it to be open and we can start reviewing and so on

Also please set the PR as a draft for now, once you believe you are done you can then set it to be open and we can start reviewing and so on (did for you)

Hi thanks for doing that for me. I was a bit busy the past few days and I wasn't 100% sure how to do it bc I'm not very familiar with github.

No worries, If there are any questions about the design of a feature, discussions/questions need to be in the issue (#153). If the question/discussion is about the implementation, they can be asked in this pull request.
Thank you for your development, in the next couple weeks I'll make a more useful CONTRIBUTING.md to help with all this for the future.

I ran into an issue when installing DiscordUtils from https://pypi.org/project/DiscordUtils/ as my machine failed to install PyNacl several times which delayed the process of importing the pagination. Once it did manage to install PyNacl it started having issues installing DiscordUtils so this is an ongoing troubleshooting process.

If you add git+https://github.com/KoalaBotUK/DiscordUtils to requirements.txt and production-requirements.txt and then do
$ pip3 install -r requirements.txt

DiscordUtils should be installed without voice requirements or support (which should be ok)
I noticed you also had discord-ext-menus being used. Due to this not having a PyPi package, and being made for internal testing I'd advise against using it as it is essentially unsupported so alternate ways of doing the same stuff should be used instead.

It might take me a while to get this working as my system doesn't seem to be installing pip packages correctly. I had a few versions of python installed and was working using Python 3.9 but all my packages were installing to Python 3.8 and it wasn't letting me install them elsewhere and using python 3.8 broke all of the code so 🤷 I need to do a clean install anyway soon so I'm thinking of doing that in the next week or so and am hoping that will fix my issues.
I uninstalled my other python versions and kept only 3.9 but that claimed it didn't have pip so I reinstalled that as well as it still claimed it didn't have pip. I also still seem to have 3.8 installed despite it not showing in my installed programs

It might take me a while to get this working as my system doesn't seem to be installing pip packages correctly. I had a few versions of python installed and was working using Python 3.9 but all my packages were installing to Python 3.8 and it wasn't letting me install them elsewhere and using python 3.8 broke all of the code so 🤷 I need to do a clean install anyway soon so I'm thinking of doing that in the next week or so and am hoping that will fix my issues.
I uninstalled my other python versions and kept only 3.9 but that claimed it didn't have pip so I reinstalled that as well as it still claimed it didn't have pip. I also still seem to have 3.8 installed despite it not showing in my installed programs

Hmm that's strange, sorry to hear that, once you get pip working you may want to look into virtual environments (venv) for further development so this issue doesn't happen again.

Finally got my windows instill all fixed so i can get back to coding this cog

So Koalabots self-hosting guide says it needs Python 3.8? Is that any version of 3.8 including 3.8.10? Just want to make sure I am instaling a compatble version

Hi, I'm re-installing my coding environment after a code conflict. I am setting it up as a virtual environment for each bot, The code for the first bot I am doing is contained within C:\Users\Teaga\Documents\Discord-Bot\KoalaBot-master. Is this the correct way to create the virtual environment ``virtualenv C:\Users\Teaga\Documents\Discord-Bot\KoalaBot-master`? I asked in the discord.py server but didn't get a response, which is typical in my experince

Try the following:
$ cd C:\Users\Teaga\Documents\Discord-Bot\KoalaBot-master
$ virtualenv venv
$ . C:\Users\Teaga\Documents\Discord-Bot\KoalaBot-master\venv\Scripts\activate

Little Update

I got my machine all setup for coding again. Yay!
I have a working custom help command showing all of the commands (ColourRole, TextFilter and TwitchAlert are disabled in this screenshot to make it fit on the screen)
I have a working pagination command courtesy of DiscordUtils. Now I just need to get the help command to send to the paginator.
working roleinfo command
Working permissions command
Working serverinfo command
Working stats command
Slightly broken whois command
Broken channelinfo command

Little Update

I got my machine all setup for coding again. Yay!
I have a working custom help command showing all of the commands (ColourRole, TextFilter and TwitchAlert are disabled in this screenshot to make it fit on the screen)
I have a working pagination command courtesy of DiscordUtils. Now I just need to get the help command to send to the paginator.
working roleinfo command
Working permissions command
Working serverinfo command
Working stats command
Slightly broken whois command
Broken channelinfo command
I will be making the info commands a separate pr, when I have help command finished, unless your happy with it now?
I'm not sure why enableExt and disableExt don't show in the bot created help, it is very odd considering the commands work and the subcommands also work. The bit they show up in is a bit I added.

Update to this:
I got the paginated help command working. It's not 100% finished bc I am trying to add a greeting msg to the front of the pagination list but it's not working very well. But the help command list itself works


Problem installing latest commit

Setting up a new machine with this and it seems there are some issues with the latest installer. It crashes on copying over the information:
Installing collected packages: medleydb
  Running setup.py install for medleydb: started
    Running setup.py install for medleydb: finished with status 'error'
    Complete output from command /usr/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-1gmlwvfa-build/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-0tsnxo8i-record/install-record.txt --single-version-externally-managed --compile:
    running install
    running build
    running build_py
    creating build
    creating build/lib
    creating build/lib/medleydb
    copying medleydb/version.py -> build/lib/medleydb
    copying medleydb/mix.py -> build/lib/medleydb
    copying medleydb/download.py -> build/lib/medleydb
    copying medleydb/multitrack.py -> build/lib/medleydb
    copying medleydb/__init__.py -> build/lib/medleydb
    copying medleydb/utils.py -> build/lib/medleydb
    creating build/lib/medleydb/resources
    copying medleydb/resources/taxonomy.yaml -> build/lib/medleydb/resources
    copying medleydb/resources/tracklist_bach10.txt -> build/lib/medleydb/resources
    copying medleydb/resources/mixing_coefficients_version2.yaml -> build/lib/medleydb/resources
    copying medleydb/resources/tracklist_v1.txt -> build/lib/medleydb/resources
    copying medleydb/resources/instrument_f0_type.json -> build/lib/medleydb/resources
    copying medleydb/resources/pyin.n3 -> build/lib/medleydb/resources
    copying medleydb/resources/artist_index.json -> build/lib/medleydb/resources
    copying medleydb/resources/client_secrets.json -> build/lib/medleydb/resources
    copying medleydb/resources/mixing_coefficients.yaml -> build/lib/medleydb/resources
    copying medleydb/resources/tracklist_extra.txt -> build/lib/medleydb/resources
    copying medleydb/resources/tracklist_v2.txt -> build/lib/medleydb/resources
    creating build/lib/medleydb/data
    error: can't copy 'medleydb/data/Annotations': doesn't exist or not a regular file

My guess is it is trying to copy the Annotations directory as a file, rather than the contents.
The latest release version installed fine though.

Ignore!! Turned out the machine was using setuptools v20.7 which had this bug (https://github.com/pypa/setuptools/issues/483). All fixed.


Tilemap fix displaced textures and shapes and added center texture and compatibility mode

This commit fix #22989 #15249 #28206. Main problem is that tilemap displace textures in different tile origins in a strange way and doesn´t respect coincidence between texture and shapes in not uniform tiles. This issue is present in godot 3.0 and godot 3.1. To maintain compatibility are added a compatibility mode and a center texture option. Other related issues and pull request: #28896 #29487 #29519 #29961

Looks good overall, needs a rebase and I made some edit suggestions.

Corrections here: https://github.com/godotengine/godot/pull/30231


[sw/silicon_creator] Introduce the sec_mmio module

The sec_mmio module is responsible for tracking critical register values for an initialized sec_mmio_ctx_t context, and provides  a mechanism to check expected values and trigger shutdown escalation on fault detection.
Initialization

sec_mmio_init().

Register writes

Perform a number (N) of calls to sec_mmio_write32().
Increment the expected number of writes by N by calling sec_mmio_write_increment(). This is done using a separate function call to be able to detect skip instruciton faults on sec_mmio_write32() calls.

Register reads

sec_mmio_read32().

Expectation checks
See the documentation on the following functions:

sec_mmio_check_values()
sec_mmio_check_counters()

Testing
Test cases can use a mock sec mmio handle inside the test class. The test class must inherit from mask_rom_test::MaskRomTest, for example:
class CriticalDeviceTest : public mask_rom_test::MaskRomTest {
 protected:
  uint32_t base_ = TOP_EARLGREY_CRITICAL_DEVICE_BASE_ADDR;
  mask_rom_test::MockSecMmio mmio_;  // This handle is required.
};

Expectations are similar to the dif mock mmio version, with the difference that the mmio_ handle and the base_ address need to be explicitly set inside the macro:
 EXPECT_SEC_WRITE32(mmio_, base_ + CRITICAL_DEVICE_CFG_REG_OFFSET,
                      {
                          {CRITICAL_DEVICE_CFG_FOO_BIT, false},
                      });

Opens

sec_mmio_ctx is currently defined as an extern to simplify testing. For the actual target, we need to define a memory region to share the data with ROM_EXT.
Currently fault detection escalations are performed by calling a handler that is registered at sec_mmio_init() call time. Need to determine if we want to move to a mock_shutdown implementation, or if we want to refactor the code to return error codes.

Hi @mcy, @cfrantz. PTAL. Thanks!


deploy changes from tutorials-internal repo

Will push deployment directly to prepare-sdk-release-3.0 branch. Will keep record of which yaml files were used for these commits here: https://github.com/graphcore/Graphcore-Pytorch-fork/pull/3


Get a better crate name

I think the crate name defined in Cargo.toml should be libtock instead of tock as tock represents the name of the OS itself. I could do the renaming if people agree that this is something we want.

+1

Seems fine to me

I'm on the side of leaving it as it is. Initially I thought the name should change, but from a user's point of view, I think tock makes more sense. Given that this is really mostly a shim layer over the kernel, the "object" the user is interacting with basically is the kernel.
I would expect "libtock" to be a library that provides its own services.
I don't feel strongly about this.

+1

@torfmaster Are you voting for or against renaming?
If there is no clear agreement, we can drop the renaming idea. It's just when tock and libtock land on crates.io some day, there will be a naming conflict. Renaming the crate later on could create the left-pad incident of IoT. :wink:


Codable support

Initial commit! Pushing to show progress, potentially get insight from others.
It would be great to see if we could implement it such that the generic classes' types didn't require conforming to Codable and that it would only be necessary when wanted to the classes as Codable. However Swift's init methods as well as where clauses have limitations with extensions that I haven't figured out how to work the way I am hoping.
Also tests need cleaning and elaboration.

Hi @yoiang,
I think this is a great start! I think what would make sense stylistically, is to put everything related to Codable support into its own file(s) in the project with a name like Graph+Codable.swift or something along those lines and implement it as an extension. I just don't want the existing classes to get too messy and I think it makes some sense organizationally.
Best,
DK

This is the first limitation of Swift come in. The first obvious one is that the Decodable protocol requires an initializer, initializers that are implemented as a result of protocol conformance must be marked as required and thus can't put added as an extension.

Ah, that makes sense. Sorry, I didn't think of that issue when I suggested it. I guess we can just put it right into the classes then. I rather that than have to do something funky like a factory.

I guess the only other issue I have with it is that this is going to permanently require that all vertices and edges are Codable as well. So, that's an extra hoop that people will have to jump through to use their custom class as a vertex, right? Ensure it too has Codable support. I don't really like that idea on the surface of it. I guess I was envisioning that there would be some way with Swift conditional conformance to do this so that we could have our cake and eat it: allow Graph to be used with both Codable vertices and not Codable vertices.

Yea, that's what I called out above as well in the initial commit message. I agree about not putting that requirement on users. So far my attempts haven't been valid Swift, I'm going to spend a little more time, ask around and see if there is a way to do it.

I know this example might seem too trivial, but I was hoping we could do something like this:
https://twitter.com/stephencelis/status/979394451280982016

I have tried that route, I believe that is only possible in a struct which does allow for adopting required protocol initializers within extensions. The poster didn't clarify what Result originally is ;)

I wonder if this will change with the improvements to conditional conformance in Swift 4.2. I am waiting on the Mac App Store release of Xcode 10 to try (tomorrow? Maybe with Mojave next week?).

Unfortunately it looks like it doesn't. I understand punting on this support for now, I'm going to maintain it in my own fork as long as I'm using the library, hopefully a later version of Swift will add what we're looking for!

Hmm, it looks like an example in the Ray Wenderlich article of exactly what we're trying to do, but again it's on a struct, not a class. I will mess with this too later in the week after Xcode 10 launches and try to build on what you've started. The other long term option is to create subclasses of UnweightedGraph and WeightedGraph like SerializableUnweightedGraph and SerializableWeightedGraph. And then yes, we could also go down the factory route, check if the generic types are Codable at runtime and return the right type. If this would be API changing, we could just make it part of the 2.0 version of SwiftGraph.

Okay, I just found this in the release notes for Swift 4.2 in Xcode 10. Apparently it's a bug:
Finally, due to Decodable having an initializer requirement, it's not possible to conform to Decodable in an extension to a class that isn't final. Such a class needs to have any initializers from protocols be required, which means they need to be in the class definition. (SR-6803) (39199726)
https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes/swift_4_2_release_notes_for_xcode_10
https://bugs.swift.org/browse/SR-6803

Oh interesting, if I'm reading this correctly they're going to extend automatic synthesis to extensions as long as you're within the same file to allow this flexibility. Feels like a strange inconsistency in Swift but hey, our benefit ;)
Hopefully this will be enough, on first glance it doesn't sound like it does anything for cases where the automatic initializer synthesis is not enough and we still must create a custom initializer.

Okay, apparently that fix actually did go into Swift 4.2. I asked on Twitter about it:
https://twitter.com/dgregor79/status/1042064271411109889
I'll probably get a chance to try it out later today.

@yoiang I've individually added your CodableTests file with some modifications. I ended up creating two subclasses of WeightedGraph and UnweightedGraph. I think this will have to do for now for the main project until we have conditional conformance in the base Graph protocol. Thanks for all of your help with this. It's good to see it make it into master.

Hey @davecom !
Since my work isn't represented in the git history would you mind adding me to the list of contributors?
Cheers!

Sure, I added a note to Contributors. Thanks.

Cheers dude, I appreciate it!


Facebook/Meta login?

I need this for a game im making with a vr headset. Is this possible and if not is it ever going to come?

Thanks for asking, @TrevorBlythe! It should be doable, similar to how it's done for Unity: https://learn.microsoft.com/en-us/gaming/playfab/features/authentication/platform-specific-authentication/facebook-unity
Since I personally don't use Facebook and no one else has been asking about this yet, I will very likely not integrate it myself.
However, I would like to encourage you to implement it and contribute! I am happy to assist if you have further questions.


Update pypi package

The pypi package is still at version 0.0.13 (see https://pypi.org/project/assets2036py/) which does not reflect code changes since https://github.com/boschresearch/assets2036py/commit/8a697e535008a49bda39899d32b3f9bfa5af0de3 on March 14th, like resolved issue #4.

fixed in https://github.com/boschresearch/assets2036py/commit/5828680eeca85fab82f2132eb502c864327e7e8d.
Thanks!


"Mirror is dead" dialogue appearing despite mirror being online

When using the extension, the "___ mirror is dead" dialogue box appears regardless of the mirror status. The extension recognizes the mirror is up and running, but shows the box anyway. Issue occurs on Chrome Version 99.0.4844.82 for Windows.

I'm getting the same message on a new install in chrome

a same issue, hope the developer to fix it!

This is top on my priority list, but I've been a bit busy lately.  I'll get to it soon.
In the meantime, you can uncheck the option: "autocheck sci-hub mirror on each paper request".
Sorry all for the bug/inconvenience ☹

Same problem here and the list of back-up mirrors doesn't appear.

Same issue still, indeed the "likely working" ones did not have this issue.
As a temporary workaround, just disable the "Auto-check sci-hub mirror on each paper request" option.


[BUG] Provider RPC happens over the incorrect NATS connection

Describe the bug
This bug only applies when the capability provider NATS connection is separate from the lattice NATS connection. As you can see in the perform_rpc_invoke function here https://github.com/wasmCloud/wasmcloud-otp/blob/main/host_core/lib/host_core/web_assembly/imports.ex#L390-L398, the request goes over the :lattice_nats Gnat connection. We should be using a separate Gnat connection, perhaps called :provider_nats, in order to make this RPC.

So here's an interesting fun fact, the RPC connection is called :lattice_nats, as you can see where we initialize the RPC connection:
https://github.com/wasmCloud/wasmcloud-otp/blob/main/host_core/lib/host_core/nats.ex#L8

Just commenting after our discussion; that is correct, we also have a provider RPC connection which is separate from the lattice RPC connection. When these two connections are separate we will likely see some bugs with communicating with providers.
As discussed, it would be worth our time to do an audit of our three NATS connections (lattice RPC, control interface, provider RPC)
Here's where the provider NATS connection information is generated for the provider https://github.com/wasmCloud/wasmcloud-otp/blob/main/host_core/lib/host_core/host.ex#L230-L231


[enhancement]: Allow wildcard wordlist files with dynamic prompting

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
Add the ability to use wildcard files with dynamic prompting. It looks like the node could have had it, but it was not added because there was no way to handle the path to the wildcard directory. Could this option be added in now?

Wildcards via wordlist files
Implemented, but we don't have a simple way to handle the path to the wildcard directory yet, so I didn't include it. This is super straightforward to add back in later.

Alternatives
No response
Additional Content
No response

I think we'd want to provide the user a list of wildcards for this to be usable.
Here's what I'm thinking we'd need:

Endpoint to list all wildcards
UI component to show the list and perhaps allow for easy insertion, same as we do now w/ prompt triggers
Maybe a way to upload wildcard lists through the UI - though this would imply a small service or internal API to manage the folder... maybe we could kinda skip the complexity there and make this a wholly user-managed folder?

Any thoughts about the UX for this feature?

There are several wildcard collections provided by the original author of dynamic prompts that we could use. I think a wholly user-managed folder would be fine. We could just have a place in the UI (Dynamic Prompts dialog?) where you specify your wildcards folder. The syntax in Auto/Forge is __wildcardfile__ which I think works fine. The extension for Auto1111/Forge does have its own page for viewing and editing the wildcard lists (the Wildcards Manager), but this might not be necessary. It lets you search through your wildcard names, and see the wildcards in each file, adding or removing wildcards as needed. It's handy, but not strictly necessary. Maybe something like that could be integrated into the Dynamic Prompts dialog box currently used for organizing the queue, setting seed behavior, and max prompts.

Thanks.

Does the extension's editor UI present you with the wildcard lists as raw data (e.g. JSON, CSV, YAML) or is there a "proper" UI for editing the strings?
Does the extension editor feel good to use? Any pain points or missing features?
Can you please link to the extension's repo?

Note - these are just exploratory questions, not making any commitment to work on this any time soon

The extension's editor UI presents the list of wildcards as a simple list of every file in the folder, with subfolders in collapsible/expandable trees. I'm not sure how this data is listed. You can search for terms in the wildcard filenames, which narrows the list displayed. After clicking on one of these wildcard files, its contents are shown as a simple text area on the right of the list. You can change a wildcard there, add, or delete, each wildcard on its own line, and then there is a button to save the file. I think the extension editor works fine. Perhaps we could use the same implementation in the dynamic prompts dialog. Here is the repo: https://github.com/adieyal/sd-dynamic-prompts
These wildcard files can themselves contain wildcards in the standard {|} format, and even include other wildcard files as __wildcardfile__, which makes for some cool dynamic prompting possibilities.

Great, thanks for the detail.


BusyContacts

https://twitter.com/EKOisGPSy/status/682270778818211843

Ref: Conversation #4781 / David

Ref: Conversation #5062 / Richard

https://twitter.com/EKOisGPSy/status/807500009725890560


feat(firestore-translate-text) add shouldUpdate option to config

A nice feature to make subsequent translations optional.
This closes #194, where the issue is discussed in detail.

@googlebot I signed it!

Closing this for now. More details in: https://github.com/firebase/extensions/issues/194


Add Ability to Bypass Initial (Re)Configuration & Renewal When Using "Edit" in Menu Interface

Describe the solution you'd like
It would be convenient to be able to add/remove scripts via the "E: Edit renewals" menu.  This would allow for configuration of multiple scripts on a certificate that requires options only available via the CLI.  It could also allow a script to be removed or replaced without force renewing the certificate and potentially triggering rate-limit issues.
Describe alternatives you've considered
My use case doesn't require multiple scripts, so I can just re-run the CLI command with a new script to replace the old one, but under less-than-ideal circumstances, this could run the risk of triggering a rate-limit.
Additional context
See https://github.com/win-acme/win-acme/issues/1757#issuecomment-931652462
Also, regarding rate-limit discussion, I nearly hit rate limits recently due to needing to renew multiple times between root CA changes, version upgrades, and a certificate that was supposed to be exportable but wasn't.  Those things all at once are less-than-ideal by themselves, but if I had also typo-ed the script name or wanted to remove it temporarily and re-add it shortly thereafter, I would have hit the limit for sure.  That having been said, I was not using --force, so maybe the renewal triggered when I changed the script using the CLI was a bug.

Released in 2.1.20


clarification

Could you clarify "You can create reports in app workspaces that are based on datasets in a different workspace. However, you can't create an app for a workspace that contains those datasets."
The way this is phrased is not very clear to me.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f09aabd-9f0d-f94d-6e0a-7c9a9884dd71
Version Independent ID: b4528bd4-f503-3cc2-52ec-9257e485555e
Content: Use datasets across workspaces (Preview) - Power BI - Power BI
Content Source: powerbi-docs/service-datasets-across-workspaces.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comment, @sprengmi. I've assigned this issue to the doc author for review.

Hi, @sprengmi -- good question. It's not clear, and it's not true. It should read:
"You can create a report in an app workspace that is based on a dataset in a different workspace. However, when you create an app for that workspace, you can't include the report based on the shared dataset in the app."
Does that make sense?

I think so.
So basically the functionality allows us to create reports based on shared datasets across workspaces. But a shared dataset can NOT be used in reports across multiple apps?

At this time, yes. I'll update the article.
Always a good idea to let the product team know your thoughts on features! https://ideas.powerbi.com/forums/265200-power-bi

Thanks for the response!

Hi @maggiesMSFT. Just wanted to follow up. I tested this out and it seems it does actually work unless I'm missing something:

Created two new workspaces
Created a data source in Workspace A
Published the Workspace A App
Connected to the dataset from Workspace A in Workspace B and saved a new report in Workspace B
Published the Workspace B App, ensured 'included in app' was checked for the report
Both apps now have the Report based on the shared dataset available....

Thanks for your help, we just want to be sure we understand the limitation before moving forward.

@sprengmi , you are right. I tried it yesterday and it didn't work, don't know why. But I just tried it again, and it worked. Thanks for checking!
I'll update the article to reflect that.

@sprengmi -- Ah ha! I've discovered why I had 2 different experiences. Turns out if I’m a member of workspace B that contains a report, but not a member of workspace A that contains its dataset, I can publish an app from workspace B, but it can’t include that report.

OK, @sprengmi -- published the update today. Thanks for asking the original question!


Refactor get_desktop_environment()

The current version of get_desktop_environment() does a lot of unnecessary checks that really slow down execution. By having all those if statements without any else if the program must check all those conditions.
This PR optimizes all those checks.

Sometimes the create_delete_folder and create_remove_folder pass, and sometimes they don't. I don't fully understand why,  but my PR doesn't make any changes that could cause this.

Thank you for your interest in contributing. I was skeptical that this would improve performance, so I set up a little test with the Godbolt compiler explorer. It turns out that the two versions will very likely compile down to the same binary. https://rust.godbolt.org/z/hqGr9b
With that said it can be argued that using a match expresses the intent more clearly so I'm inclined to accept this PR. I will say thought that I'm not a fan of such PRs because this is a very small improvement relative to the amount of time it requires from the both of us.
But again, I'm willing to merge this but first you are going to need to get all checks to succeed. You can see above there a hollow red circle with the text "Some checks were not successful". If you click on details next to one of the checks with a cross sign, you'll see the terminal output of a failed test. There you might have to scroll up to see which command failed, and there you'll see that it was
/usr/share/rust/.cargo/bin/cargo fmt --all -- --check

This means that your formatting is not correct, so you'll need to run cargo fmt on this branch and then commit & push again.

Thank you for your interest in contributing. I was skeptical that this would improve performance, so I set up a little test with the Godbolt compiler explorer. It turns out that the two versions will very likely compile down to the same binary. https://rust.godbolt.org/z/hqGr9b
With that said it can be argued that using a match expresses the intent more clearly so I'm inclined to accept this PR. I will say thought that I'm not a fan of such PRs because this is a very small improvement relative to the amount of time it requires from the both of us.
But again, I'm willing to merge this but first you are going to need to get all checks to succeed. You can see below there a hollow red circle with the text "Some checks were not successful". If you click on details next to one of the checks with a cross sign, you'll see the terminal output of a failed test. There you might have to scroll up to see which command failed, and there you'll see that it was
/usr/share/rust/.cargo/bin/cargo fmt --all -- --check

This means that your formatting is not correct, so you'll need to run cargo fmt on this branch and then commit & push again.

Yeah, you're right. I was probably tired and I didn't think through, but it is more clear with a match.

I was using this library and noticed that it ran really slow

You probably know already but if you have multiple files you want to delete you can use delete_all to remove them a bit quicker than using delete on each of them separately. Although the performance improvement might be negligible. Also you can specify a path to a folder to remove an entire folder, that could help too.

Also I'm just starting to contribute to OSS, so I have to start somewhere haha

An exciting time indeed. Godspeed.

You probably know already but if you have multiple files you want to delete you can use delete_all to remove them a bit quicker than using delete on each of them separately. Although the performance improvement might be negligible. Also you can specify a path to a folder to remove an entire folder, that could help too.

Yeah, I know, but unfortunately my application processes files one by one. I've made it run in parallel so now it runs as you'd expect.

An exciting time indeed. Godspeed.

I actually had an idea about (actually) optimizing it, but I don't know how you'd feel about introducing a dependency. Using lazy_static (as a linux-only dependency) it could be ensured that the trash variable is only evaluated once, even if remove_all_canonicalized is called several times, as in my use case.

I actually had an idea about (actually) optimizing it, but I don't know how you'd feel about introducing a dependency. Using lazy_static (as a linux-only dependency) it could be ensured that the trash variable is only evaluated once, even if remove_all_canonicalized is called several times, as in my use case.

If it can be show that your suggested modification brings a significant performance improvement, I'd be happy to merge such a RP 😊


Version bump to 2.129.0

Auto-generated by fastlane 🤖
Changes since release '2.128.1':

[spaceship/cert] add Apple Development and Apple Distribution certificate type (#15130) via Yoshimasa Niwa
[action] add SonarQube pull request parameters to sonar (#15069) via Damien R
[action] update gradle docs with example for task "bundle" (Resolves #15053) (#15058) via Finn Gundlach
[spaceship] add option to upload and view merch_screenshot (#15080) via Max Ott
[fastlane] fix typos across fastlane repository (#15061) via Yoginth
[action] add environment variables for pod push (#15127) via bouldering-machine
Update PULL_REQUEST_TEMPLATE.md (#15169) via Josh Holtz
[action] fix for Xcode 11 when using $(MARKETING_VERSION) in get_version_number (#15139) via Florent Morin
[fastlane] Less hacks in command_executor_spec (#15131) via Artem Sheremet
[spaceship] add invited state for TestFlight beta testers. (#15126) via Hugo Sousa
[action] fix suppress_xcode_output parameter type (#15152) via Jean Mainguy
[Fastlane.swift] options of is_string: false should be Any and not String (#15165) via Josh Holtz
[match] fix match not making new profiles for force_for_new_devices (#15164) via Josh Holtz
[snapshot] replace Objective-C-style NSMakeRange with Swift-style NSRange.init (#15128) via Roman Podymov
[spaceship] Map additional build details (#15094) via Max Ott
[action] update_fastlane: Fix broken link (#15086) via Stefan Painhapp
Allow Crashlytics devtools.jar to be auto updated (#15095) via Jeremy Durham

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: Danger

For reference: Big PR warning was caused by the Fastlane.swift changes


Development Readme update

updated instructions on how to build and test locally the terraform provider for development purposes

Hi, thanks for you pr, we update the doc with little changes: #168


There is an extra scroll bar below the component at landing page

What happened?
There is an extra scroll bar below the component at landing page.
both Latest sales and Newest List have the same problems, which looks weird
Please reproduce in steps
goto https://kodadot.xyz/
scroll down the page
you can see the strange scroll bar
Expected Behavior
I've expected there is no scroll bar below the component
What browsers are you seeing the problem on?
Chrome
Are you logged in?
No
At which address did you encounter bug?
beta.kodadot.xyz, kodadot.xyz
Screenshots

Relevant log output
No response
Payment link for reward
https://kodadot.xyz/transfer/?target=Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I will fix it.


Create a Cloudflare Zero Trust Network with a Tunnel to Local Site

[ ] Create a Cloudflare Zero Trust Network (ZTN)
[ ] Connect to ZTN using Warp for Android and Mac
[ ] Explore DDoS protections
[ ] Register/Transfer existing domain
[ ] Explore/Enable Cloudflare Managed Rules for domain (WAF)
[ ] Explore Cloudflare API Shield Protections

[ ] Schema Validations

[ ] Create a ZTN tunnel
[ ] Simulate a local site and connect to ZTN tunnel using Connector

Connection to protected Zero Trust Network (ZTN) using Warp: