Helm chart version is not updated on release job

Description
Helm chart version is not updated on final release cut. For all our releases, we had outdated Helm version badge and image tag, see:
https://github.com/kubeshop/botkube-docs/pull/198/commits/f9ed8a1fffccf20f50091927cc29ee5b671849c3
Expected behavior
Released documentation has a valid version
Update Update versions in installation docs step:
https://github.com/kubeshop/botkube-docs/blob/ba0bbc63a48bcade78a5cba4017690ed8ee89ba1/.github/workflows/release.yml#L47-L52

The root cause of this issue is not correctly updating versions, it is all about creating docs release before finalizing Botkube core stable release. So, we concluded with adding a validation to docs release before creating actual version.


fix missing call to untoggle_optimizer when accumulating gradients

What does this PR do?
Fixes  #8281
The training loop toggles the optimizers in case there are mutliple, and untoggles after the optimizer step is completed.
However, the untoggle is missing during the accumulation phase, and it is certainly necessary.
Every toggle_optimizer() call needs a matching untoggle_optimizer() call.
Test fails on master
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
I made sure I had fun coding 🙃

I know this is closed, but I just pulled master, and tried testing w/3 optimizers instead of 2 (this problem is fixed when I only have 2) and the issue persists. How can I help?


Adds enable color setting and fixes sync between settings activity and ROS parameter server

Closes #266
Adds setting to enable or disable the color camera to save battery. Only works on API > 23
Closes #268
Fixes sync between settings activity and ROS parameter server.

When parameter node is started, all settings are downloaded from ROS parameter server and local settings are uploaded to parameter server.
Before starting the settings activity, parameters are downloaded from parameter server.
After quitting the settings activity, parameters are uploaded to parameter server.
Before quitting RunningActivity, parameter are downloaded from parameter server.
Settings are downloaded before restarting Tango.
When calling the /tango/connect service directly, the C++ ROS node takes care of getting parameters from the server. These settings will be synced with the local settings whenever the SettingsActivity is started next time (or when app quits).

Issues:

At the first run of Settings activity or when ROS connection failed, the local settings are overwritten by the parameter server when parameter node starts.
ROS parameters cannot be changed if settings activity is open. ROS parameters will be overwritten whenever a user returns to the RunningActivity.

Is this behavior correct? Are the issues acceptable?

@PerrineAguiar Thanks for your review. Addressed all comments.


[cloud_firestore] Snapshots() does not listen to updates from Firestore after the initial connection using a compound query with an equality and inequality simultaneously

Describe the bug
Query.snapshots() does not listen to updates from Firestore after the client initially connects when a compound query using both an equality and an inequality query. On the initial snapshots() call, the local client syncs with Firestore, however on all subsequent changes to the listened documents/collections, the local client does not receive those changes.
To Reproduce
Steps to reproduce the behavior:

Create a Stream by running the snapshots() function on a compound query with both an inequality and an equality query.

Firestore.instance.collection('match').where("user_id.$userId",
isGreaterThanOrEqualTo: 0)
        .where("status", isEqualTo: 0)
        .snapshots()

Expected behavior
A clear and concise description of what you expected to happen.
The client should be subscribed to Firestore and when a document meets the query criteria (in this case a compound query with an inequality and an equality query), it should be returned.
Additional context
Add any other context about the problem here.
[✓] Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.15.3 19D76, locale en-US)
    • Flutter version 1.12.13+hotfix.9 at /Users/bhsu/home/tools/flutter
    • Framework revision f139b11009 (8 days ago), 2020-03-30 13:57:30 -0700
    • Engine revision af51afceb8
    • Dart version 2.7.2

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/bhsu/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3, Build version 11C29
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 42.1.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] IntelliJ IDEA Community Edition (version 2018.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 31.3.2
    • Dart plugin version 182.4129.13

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.0

Hi @brianbhsu
can you please provide your `flutter run --verbose'?
Thank you

@TahaTesser Which part, the initial build, when the bug occurs, or everything?

I've been taking a quick look into this one, and I can't understand this section: https://github.com/FirebaseExtended/flutterfire/blob/master/packages/cloud_firestore/cloud_firestore_platform_interface/lib/src/method_channel/method_channel_query.dart#L64
It seems to be waiting for the Future twice - but in the second one it assigning the query observer handler ID. Looks like there could be a race condition & bug here.

I was facing the same issue until I run flutter run --verbose, there's a failure message regarding the query requires an index and its URL. After creating it, I am now able to listen for changes

Hey all, as part of our on-going work for #2582, this has been resolved in our Firebase Firestore rework (#2913) - which has now been merged into master. We'll look at publishing some prereleases in the next few days. Thank you


Randomizing Note Positions and Forced Middle-Scroll

Describe your problem here.
Hello again, and sorry for the inconvenience. I need help on two events: one that will help me randomize note positions (like the event in the Hypno Lullaby mod that will mess up the note positions) and another one that will force the player's notes to become middle scroll (like defeat from Impostor v3). Sorry again for the inconvenience and I will again appreciate the help. :)
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Hey! I am not sure if it's possible to force middlescroll with lua, but if it is then it would be this:
function onCreate()
 setPropertyClass('ClientPrefs', 'middleScroll', true)
end

Test to see if this works, and reply if it didn't!

Hey! I am not sure if it's possible to force middlescroll with lua, but if it is then it would be this:
function onCreate()
 setPropertyClass('ClientPrefs', 'middleScroll', true)
end

Test to see if this works, and reply if it didn't!

Didn't work, but thanks for trying :)

Hey! I am not sure if it's possible to force middlescroll with lua, but if it is then it would be this:
function onCreate()
 setPropertyClass('ClientPrefs', 'middleScroll', true)
end

Test to see if this works, and reply if it didn't!

Didn't work, but thanks for trying :)

Seems like the engine won't let you change client preferences with lua. Well, the only thing I can tell you is, edit the source code.

This should work for forcing middlescroll:
function onCreate()
    if not middleScroll then
        setPropertyFromGroup('opponentStrums', 0, 'x', -5000);
        setPropertyFromGroup('opponentStrums', 1, 'x', -5000);
        setPropertyFromGroup('opponentStrums', 2, 'x', -5000);
        setPropertyFromGroup('opponentStrums', 3, 'x', -5000);

        setPropertyFromGroup('playerStrums', 0, 'x', defaultPlayerStrumX0 - 320);
        setPropertyFromGroup('playerStrums', 1, 'x', defaultPlayerStrumX1 - 320);
        setPropertyFromGroup('playerStrums', 2, 'x', defaultPlayerStrumX2 - 320);
        setPropertyFromGroup('playerStrums', 3, 'x', defaultPlayerStrumX3 - 320);
    end
end

This should work for forcing middlescroll:
function onCreate()
    if not middleScroll then
        setPropertyFromGroup('opponentStrums', 0, 'x', -5000);
        setPropertyFromGroup('opponentStrums', 1, 'x', -5000);
        setPropertyFromGroup('opponentStrums', 2, 'x', -5000);
        setPropertyFromGroup('opponentStrums', 3, 'x', -5000);

        setPropertyFromGroup('playerStrums', 0, 'x', defaultPlayerStrumX0 - 320);
        setPropertyFromGroup('playerStrums', 1, 'x', defaultPlayerStrumX1 - 320);
        setPropertyFromGroup('playerStrums', 2, 'x', defaultPlayerStrumX2 - 320);
        setPropertyFromGroup('playerStrums', 3, 'x', defaultPlayerStrumX3 - 320);
    end
end

Doesn't seem to work :(

Put it on function onUpdate(elapsed) then

Put it on function onUpdate(elapsed) then

Worked, thanks!

Still need help on the randomizing tho...

Still need you to explain what do you mean with randomizing it, as you might not know i've explained in countless posts that i don't play mods that much so i didn't play Lullaby's yet and have no idea what do you mean.

Still need you to explain what do you mean with randomizing it, as you might not know i've explained in countless posts that i don't play mods that much so i didn't play Lullaby's yet and have no idea what do you mean.

I'm pretty sure they mean constantly moving the notes around to other places then on the top/bottom, anyways its something like this

the reason why they want middle scroll forced is so the enemy notes arent there, so its not confusing i guess

Still need you to explain what do you mean with randomizing it, as you might not know i've explained in countless posts that i don't play mods that much so i didn't play Lullaby's yet and have no idea what do you mean.

I'm pretty sure they mean constantly moving the notes around to other places then on the top/bottom, anyways its something like this   the reason why they want middle scroll forced is so the enemy notes arent there, so its not confusing i guess

then again its not technically middle scroll if its not on, because the enemy notes might still be scrambled

Still need you to explain what do you mean with randomizing it, as you might not know i've explained in countless posts that i don't play mods that much so i didn't play Lullaby's yet and have no idea what do you mean.

Ok, I'll specify. The script should randomize each note's X and Y positions, but follow the same order from left to right (Left Down Up Right).

Still need you to explain what do you mean with randomizing it, as you might not know i've explained in countless posts that i don't play mods that much so i didn't play Lullaby's yet and have no idea what do you mean.

I'm pretty sure they mean constantly moving the notes around to other places then on the top/bottom, anyways its something like this   the reason why they want middle scroll forced is so the enemy notes arent there, so its not confusing i guess

The first sentence is correct, but for the second one, I needed middle scroll for Defeat (from amogus) because I wanted to port multiple mods at once before the end of the year. Think of it as multiple mods in a mod.


Use nixpkgs as name of the channel for example how to install it

and mention nixos channel in case you are on NixOS
More from the twitter discussion https://twitter.com/zekjur/status/1311617711068377089

Specific replies that deserve attention (also because Twitter makes them hard to browse):
https://twitter.com/ioPhileas/status/1311581193062830080

True, I'd be happy if it would say: "channel nixos not found, available channels: nixpkgs"

https://twitter.com/domenkozar/status/1311567418033045505

We're running a campaign to improve such error messages https://opencollective.com/nix-errors-enhancement
In short, it's due to channels abstraction anti-pattern that is going away in Nix 3.

resolved by https://github.com/NixOS/nixos-search/pull/261

resolved by https://github.com/NixOS/nixos-search/pull/261


cmd/go: How can I prevent go CLI to check all dependencies before doing actions

What version of Go are you using (go version)?
go version go1.11beta2 windows/amd64
Does this issue reproduce with the latest release?
Yes
What did you do?
I'm trying to execute basic Go commands in a CI/CD environment. The idea is that I have 2 stages representing "BUILD stage" and "TEST stage", so they are totally running in different docker instances while the project directory (= workspace) is the same between both.
In the BUILD stage I first download all project dependencies written in my go.mod and then I run a "go mod -vendor" to copy them from the $GOPATH to a "vendor" subdirectory of my project. Like that in the next TEST stage there is potentially no need to download again all the dependencies.
To tell you more about the context I run some basic commands like:

Installing global dependecy:
go get -u github.com/jteeuwen/go-bindata/...

Make unit tests:
go test ./...

Make a coverage test:
go test -race -cover ./...

What did you expect to see?
I would require these commands to just do their job without trying to check dependencies.
What did you see instead?
Instead, for each of these commands I get something like:
finding PACKAGE_XXXXXX
finding PACKAGE_XXXXXX2
finding PACKAGE_XXXXXX3
finding PACKAGE_XXXXXX3
...

It means that the CLI makes a request to each repository to check the version... and it takes a lot of time while they are already in the vendor directory matching the go.mod requirements!
I guess since there is an empty directory at $GOPATH because this one is not passed from the BUILD stage to TEST stage, the CLI changes its behavior. But there is no reason to...
I succeeded to work around while installing global dependency (go get github.com/jteeuwen/go-bindata/...):

First I need to specify -u -f parameters according the docs to avoid these checks
But it triggers an error since my commands are ran inside a Go module. So my workaround is to run instead this:
GO111MODULE=off go get -u -f github.com/jteeuwen/go-bindata/...

That's not a cleanest way but it works...
At this time I didn't find a solution for either go test ./... and go test -race -cover ./....
One of the solution could be to mount a volume on $GOPATH to have downloaded dependencies from BUILD stage inside the TEST stage but that's not a clean way too. And if you think it is, what is the purpose of go mod -vendor if the CLI cannot manage correctly vendored dependencies?
I hope I was clear in my explanations, don't hesitate to ask more information. Maybe @rsc you have an idea about this since I'm using the latest features coming from vgo.
Thank you 😃 !

@sneko You can try go test -getmode=vendor ./...

Hi @sneko, slightly expanding on the answer from @oiooj , here are some related some snippets from the module docs on tip:

To allow interoperation with older versions of Go, or to ensure that all files used for a build are stored together in a single file tree, 'go mod -vendor' creates a directory named vendor in the root directory of the main module and stores there all the packages from dependency modules that are needed to support builds and tests of packages in the main module.
To build using the main module's top-level vendor directory to satisfy dependencies (disabling use of the usual network sources and local caches), use 'go build -getmode=vendor'. Note that only the main module's top-level vendor directory is used; vendor directories in other locations are still ignored.

And the doc section on build flags includes listing the commands you asked about (test, build and get) as supporting -getmode:

The build flags are shared by the build, clean, get, install, list, run, and test commands:
...
-getmode mode
module download mode to use. See 'go help modules' for more.

In addition, #26585 and change https://golang.org/cl/126656 describe a related recent enhancement that is targeted at multiple use cases, including specifying -getmode in CI via an environmental variable. Snippet from the CL:

People sometimes want to turn on a particular go command flag by default.
In Go 1.11 we have at least two different cases where users may need this.

Linking can be noticeably slower on underpowered systems
due to DWARF, and users may want to set -ldflags=-w by default.

For modules, some users or CI systems will want vendoring always,
so they want -getmode=vendor (soon to be -mod=vendor) by default.

This CL generalizes the problem to “set default flags for the go command.”
$GOFLAGS can be a space-separated list of flag settings, but each
space-separated entry in the list must be a standalone flag

Is your concern addressed at this point? If so, does it make sense to close this issue?

And just to be a bit more explicit, one more comment is that as of right now #26585 is still open and change https://golang.org/cl/126656 with $GOFLAGS is still in progress / not yet merged, so of course some chance it might not land and/or change in some way before it lands.

@oiooj @thepudds thank you very much for the help and these explanations! I missed this part in the documentation :s
I've still an issue with the go test -getmode=vendor -race -cover ./... since it tries to find imports in the vendor directory. Even if it's an import for a package inside the module.
To be more clear, my project (=module) imports X, Y, Z as external packages, and after running go mod -vendor all of them will be copied in the "vendor/" directory. But my project also includes internal packages (A, B, C), for example, they are imported from the "main" package of the project module. A, B, C won't be copied in the vendor directory but running the coverage test command will look for them in the same directory than external dependencies.
Do I missed something to do...?

My bad...! Since I was putting my final executable in an alpine image I had to build my project with the golang:1.11beta2-alpine to make it working because of well-known musl/glibc issue.
But the flip side is that some unit and coverage tests are not working at all with musl libs so I had to run them inside a "non-alpine" image. That what I did by putting golang:latest but I forgot that because of my vendoring I had to use golang:1.11beta2.
I'm for posting this stupid "issue" 😀
Thank you again for your help on the main issue!


Missing rbd API components: rbd namespaces

The rbd API implements function(s) below but go-ceph does not:

rbd_namespace_create
rbd_namespace_exists
rbd_namespace_list
rbd_namespace_remove

This issue has been filed to track implementing this missing
functionality in the appropriate package within go-ceph.
Please refer to the Ceph C API for details about the function(s)
in question.
NOTE: This issue was generated by a script.
If the content is innacurate or wording seems a bit odd
please excuse the script and blame the creator @phlogistonjohn

@agarwal-mudit this one would be useful to have too :wink:

Sure, will pick it up.

While wrapping rbd_namespace_list(), I am getting following error:
err = -18 ==>  Invalid cross-device link
Its pretty weird because there is only one place in rbd_namespace_list() from where this error can be returned:
rbd_namespace_list() {
  .....
       std::vector<std::string> cpp_names;
       int r = librbd::api::Namespace<>::list(io_ctx, &cpp_names);
       if (r < 0) {
               return r;
        }
.....
}

That seems pretty weird, at least the errno used. What's the call arguments in your code?

Let me put the PR as a draft, anyway other three functions are ready.


examples: FPS (not TPS) sometimes drops to 45-50

git-bisect says 8d2a4ac917b6fba7ca0b1edc5ae823f397957d81 is the culprit. So this issue has existed since Metal was introduced?
This can be reproduced with examples/sprites and examples/noise.

Ah, I remember this sometimes happens and rebooting the machine fixes this.


feat: update colors BankCard,CodeInput,Comment,ScrollBar,Skeleton,Sor…

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.005%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
8646

Relevant Lines:
9565

💛  - Coveralls


Update RGFW

Mostly fixes a lot of bugs RGFW had, including MacOS's drag and drop support.

@ColleagueRiley Nice! Thanks for the update! 👍😄


Make avatars hi-res again

Low-res, despite being faster, is uglier and i've changed my mind and want them to be hi-res

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #support.

Only do low-res if low memory mode is on

Done


Decide what parts of the Java embedder rendering APIs to deprecate

In Flutter 3.22, we've formally instructed users to stop using the {create|register}SurfaceTexture family of APIs and instead to use createSurfaceProducer, which, as an implementation detail, picks the right Surface-backed implementation. This is due to Impeller using Vulkan on newish Android APIs, and Vulkan not supporting OpenGL-based SurfaceTextures.
The next step in https://github.com/flutter/flutter/issues/139702 is deprecate APIs we don't expect users to need or use anymore (as of https://github.com/flutter/engine/pull/52892 we issue error messages on the C++ engine side). For sake of scope, let's focus on io.flutter.view.TextureRegistry and known implementing classes.
Here is my proposal of APIs to deprecate, but I'd like feedback:
P1: Will no longer work in Impeller
We should do this before Impeller becomes the default.

API
Action

.SurfaceTextureEntry
Deprecate, we want users using SurfaceProducer.

.createSurfaceTexture
Deprecate, we want users using SurfaceProducer.

.registerSurfaceTexture
Deprecate, we want users using SurfaceProducer.

P2: Unused or no longer useful as part of the public API
These are nice-to-have cleanups, we should do the ones that make sense.

API
Action

.GLTextureConsumer
Remove. AFAICT this is unused code.

.ImageConsumer
Make internal after registerImageTexture is no longer public.

.ImageTextureEntry
Make internal after registerImageTexture is no longer public.

.OnFrameConsumedListener
Remove or make @VisibleForTesting, 1 usage.

.OnTrimMemoryListener
Make internal, used in one place internally only.

.TextureEntry
Remove once there is only SurfaceProducer.

.createImageTexture
Make internal only, 1 usage internally.

.onTrimMemory
Make internal only.

Assigned @jonahwilliams and @johnmccutchan to review while I'm on vacation 😎

.createImageTexture should be moved into the P0 group (the only internal use is easily replaced with SurfaceProducer).
We might need to make onTrimMemory and OnTrimMemoryListener part of the public API- as a work around for the Android 14 bug, we now destroy the ImageReader (and its underlying Surface) when the trim memory callback fires. Any users will need to grab a fresh Surface pointer and reconfigure their uses.

@matanlurey can you make the engineering decision for what you want deprecated. The Android team is willing to take on the execution but we think you're in the best position to know what should get removed.

Sure, I can do that. Let me assign this to myself and come up with a list this/next week.


Move plugins to external repo

See original issue on GitLab
In GitLab by [Gitlab user @jjardon] on Nov 30, 2019, 15:38
This is already on going but let's open a issue to keep track
TODO

Element plugins:

autotools
pip https://gitlab.com/BuildStream/buildstream/-/merge_requests/1810

Source plugins:

tar https://gitlab.com/BuildStream/buildstream/-/merge_requests/1740
zip
git
bzr
patch
pip https://gitlab.com/BuildStream/buildstream/-/merge_requests/1810

In GitLab by [Gitlab user @jjardon] on Nov 30, 2019, 15:39
mentioned in merge request !1740

In GitLab by [Gitlab user @jjardon] on Nov 30, 2019, 15:39
mentioned in merge request !1740

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:13
marked this issue as related to #1258

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:13
marked this issue as related to #1258

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:18
mentioned in merge request !1729

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:18
mentioned in merge request !1729

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:21
mentioned in merge request !1545

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:21
mentioned in merge request !1545

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:22
mentioned in merge request !1539

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:22
mentioned in merge request !1539

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:22
mentioned in merge request !1538

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:22
mentioned in merge request !1538

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:23
mentioned in merge request !1535

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:23
mentioned in merge request !1535

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:24
mentioned in merge request !1520

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:24
mentioned in merge request !1520

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:25
mentioned in merge request !1532

In GitLab by [Gitlab user @jjardon] on Jan 21, 2020, 16:25
mentioned in merge request !1532

In GitLab by [Gitlab user @tpollard] on Jan 22, 2020, 13:37
mentioned in merge request bst-plugins-experimental!75

In GitLab by [Gitlab user @tpollard] on Jan 22, 2020, 13:37
mentioned in merge request bst-plugins-experimental!75

In GitLab by [Gitlab user @tpollard] on Jan 23, 2020, 13:52
mentioned in merge request !1810

In GitLab by [Gitlab user @tpollard] on Jan 23, 2020, 13:52
mentioned in merge request !1810

In GitLab by [Gitlab user @jjardon] on Apr 9, 2020, 18:55
changed the description

In GitLab by [Gitlab user @jjardon] on Apr 9, 2020, 18:55
changed the description

In GitLab by [Gitlab user @jjardon] on Aug 3, 2020, 11:03
mentioned in merge request !1999

In GitLab by [Gitlab user @jjardon] on Aug 3, 2020, 11:03
mentioned in merge request !1999


Bigtable: Make models serializable.

This along with query sharding, enables the creation of a Beam Source

@garrettjonesgoogle This is ready for review/merging


Add support for $map

Hi,
Would it be possible to add support for $map operation in aggregations ?
I just added this operation to a database query and it breaks around 30 tests in my codebase.
Yours,
Laurent

I took a look in the code and I saw that the main problem is the "function definition" in the $map.
However, I think an implementation would be possible if we consider that the function definition is just a "$project" with appropriate parameters. Is that really a potential way to go ?

For reference you're writing about $map. Yes I believe the implementation should be doable. PRs are welcomed.


[SPARK-49154][K8S][INFRA][DOCS] Upgrade Volcano to 1.9.0

What changes were proposed in this pull request?
This PR aims to upgrade Volcano in K8s integration test document and GitHub Action job.
Why are the changes needed?
To bring the latest bug fixes in addition to the test coverage for Volcano scheduler 1.9.0.

https://github.com/volcano-sh/volcano/releases/tag/v1.9.0

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

Thank you, @yaooqinn !

Merged to master.
Thank you @dongjoon-hyun


TypeError: string indices must be integers in BenchmarkStructs.py:62

I run into a typeerror with Python 3.7/3.8/3.9. I am trying to build and run Tensile with:
CC=/home/foo/rocm/aomp/bin/clang CXX=/home/foo/rocm/aomp/bin/clang++ ../Tensile/bin/Tensile ../Tensile/Configs/rocblas_sgemm_asm_only.yaml ./
....
[100%] Built target tensile_client
################################################################################
Converting Config to BenchmarkProcess Object
################################################################################
Filling in Parameters With Defaults
Convert Parameters to Steps
Benchmark Common Parameters
Fork Parameters
Benchmark Fork Parameters
Join Parameters
Benchmark Join Parameters
Benchmark Final
NumBenchmarkSteps: 2
################################################################################
Done Creating BenchmarkProcess Object
################################################################################
Empty winners - use fast initialization of hardcodedParameters
################################################################################
BenchmarkStep: Cijk_Ailk_Bljk_SB_00 - 00_BenchmarkFork 108.684s
NumProblems: 1
BenchmarkParameters:
BenchmarkFork = { 0 }
Traceback (most recent call last):
File "../Tensile/bin/Tensile", line 36, in
Tensile.main()
File "/home/foo/github/Tensile/Tensile/Tensile.py", line 285, in main
Tensile(sys.argv[1:])
File "/home/foo/github/Tensile/Tensile/Tensile.py", line 242, in Tensile
executeStepsInConfig(config)
File "/home/foo/github/Tensile/Tensile/Tensile.py", line 51, in executeStepsInConfig
BenchmarkProblems.main( config["BenchmarkProblems"] )
File "/home/foo/github/Tensile/Tensile/BenchmarkProblems.py", line 866, in main
problemSizeGroupConfig, problemSizeGroupIdx)
File "/home/foo/github/Tensile/Tensile/BenchmarkProblems.py", line 238, in benchmarkProblemType
benchmarkPermutations = constructForkPermutations(benchmarkStep.benchmarkParameters)
File "/home/foo/github/Tensile/Tensile/BenchmarkStructs.py", line 62, in constructForkPermutations
values = param[name]
TypeError: string indices must be integers
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/home/foo/lokal/lib/python3.7/subprocess.py", line 800, in init
restore_signals, start_new_session)
File "/home/foo/lokal/lib/python3.7/subprocess.py", line 1465, in _execute_child
executable = os.fsencode(executable)
File "/home/foo/lokal/lib/python3.7/os.py", line 812, in fsencode
filename = fspath(filename)  # Does type-checking of filename.
TypeError: expected str, bytes or os.PathLike object, not NoneType
(pyenv_3.7) 1 foo@5950x:~/github/Tensile/build$ CC=/home/foo/rocm/aomp/bin/clang CXX=/home/foo/rocm/aomp/bin/clang++ ../Tensile/bin/Tensile ../Tensile/Configs/rocblas_sgemm_asm_only.yaml ./

seems to be because of https://github.com/ROCmSoftwarePlatform/Tensile/commit/5791b7fc28c6c1264fc7941e14d6a4cbbedb8883
Reverting that change gets things moving further.

Hi,
I think there is something out of date with rocblas_sgemm_asm_only.yaml.  Try something like rocblas_sgemm_asm_single_kernel.yaml

Hi @sdquiring that doesn't help. It fails exactly the same way. Reverting https://github.com/ROCmSoftwarePlatform/Tensile/commit/5791b7fc28c6c1264fc7941e14d6a4cbbedb8883 makes it work for this kernel too.
After that I am still blocked on HIP on supported for gfx1030. What version of HIP do you use ? The open source version doesn't seem to detect gfx1030.  See: https://github.com/ROCm-Developer-Tools/HIP/issues/2238

I'm getting the same TypeError: string indices must be integers error from the same line (BenchmarkStructs.py:62) when using the same configuration file. I'm using a Vega 64 (gfx900) with rocm 4.1.2.
I've tried other configuration files (rocblas_sgemm_asm_single_kernel.yaml, rocblas_sgemm_hip_lite.yaml) and I'm seeing
Tensile::WARNING: ClientWriter Benchmark Process exited with code 2
Tensile::WARNING: BenchmarkProblems: Benchmark Process exited with code 2
# Get Results from CSV
Tensile::FATAL: Can't open "/home/alvin/Downloads/Tensile-rocm-4.1.0/build/1_BenchmarkProblems/Cijk_Ailk_Bljk_SB_00/Data/00_Final.csv" to get results

after kernels are generated and compiles, just before Writing Custom CMAKE. The .csv file does not exist.
Any clue as to why the results are unable to be written?
tensile-output.txt

#1419 officially removes support for these no longer supported steps


Unhandled error if destination is unreachable even with time out

I am using superagent to check s user session from a REST services based backend server. While testing the node for errors, I have come across a weird situation.
I am running node in a restricted network to simulate office like network (people usually don't have access to different ports). This ensures that my backend server can't be pinged because my network wont allow me. At this point, I should get a timeout error from my agent when it tries to contact the backend since it cannot reach the server. However, it throws an unhandled exception 'connect ETIMEDOUT'.
I traced back and found that lower level net api's throw this error (I might be wrong). The only way I am able to catch this error is to have a process.on('unhandledException', handler) event handler. Here is the sample code:

agent.get('path')
.set('token', session)
.set('Content-Type', 'application/json')
.set('Accepts', 'application/json')
.timeout(5000)
.end(function(err,response){
if(err){
console.log(err); //log the error ***
console.log("Log: error in check user session response from backend");
req.sessionExists = false;
callback(req, res);
}
else{//do something else}
}

Here is the output:

{ [Error: timeout of 5000ms exceeded] timeout: 5000 }

events.js:72
throw er; // Unhandled 'error' event
      ^
Error: socket hang up
    at createHangUpError (http.js:1445:15)
    at CleartextStream.socketCloseListener (http.js:1495:23)
    at CleartextStream.EventEmitter.emit (events.js:95:17)
    at tls.js:623:10
    at process._tickCallback (node.js:415:13)

Also, if I remove all the callbacks in if(err){ //} and remove timeout block and simply return, it throws a different error,

throw er; // Unhandled 'error' event
^
Error: connect ETIMEDOUT
at errnoException (net.js:884:11)
at Object.afterConnect [as oncomplete]

I am not sure why the err object not handling the code properly.

@suparngp is this still your go-to solution? I'm experiencing the same thing


Committing the updated API docs file of catalogue server

Can one of the admins verify this patch?

Closing this PR as it has included the commits which are not needed to this branch.


Documentation unclear ("Generate Component")

Section "Creating the component" mentions a Generate Component button that is nowhere to be found as far as I can see. Here's a screenshot of my workspace at that point of the tutorial.

Click on "New Component" to bring up the page with the "Generate" buttons


fairseq-interactive and fairseq-generate for language modeling task

which is the actual goal of the two commands fairseq-interactive and fairseq-generate in case of language modeling task?

fairseq-generate is for batched data and fairseq-interactive is for streaming data (and interactive use). Otherwise they are very similar.

@nicolabertoldi
This was clear.
What was less clear is the following: are these commands used to create new text from a given seed text?
Since I suppose the answer is yes, I have a follow up question: how is it possible to force the continue a sentence ending with a strong punctuation?
I tried to continue such a sentence Hello !, but the process does not generate any new word.
Should I set some parameter differently from the default?

fairseq-generate is for batched data and fairseq-interactive is for streaming data (and interactive use). Otherwise they are very similar.

Hi, Any suggestions are welcome @myleott
I've the same question of  @nicolabertoldi
1- I trained my model (wikitext-103) as illustrated here: .
2- Then, I evaluated my model:
( https://github.com/pytorch/fairseq/tree/master/examples/language_model#3-evaluate )
3- Now, I want to use this model to generate some sentences using fairseq-generate  (As the language modeling task is compatible with :mod:fairseq-train,  fairseq-generate , and :mod:`fairseq-eval-lm)
See : https://github.com/pytorch/fairseq/blob/810e61ab3ffba169a47d7e72538e082d2467f2b4/fairseq/models/fairseq_model.py#L150
So how is it possible to  continue a sentence  if I provide  the words "barack obama"   using fairseq-generate
PS:
I used this method but he didn't work
from fairseq.models.transformer_lm import TransformerLanguageModel
custom_lm = TransformerLanguageModel.from_pretrained('/path/to/model/dir', 'checkpoint100.pt', tokenizer='moses', bpe='fastbpe')
custom_lm.sample('Barack Obama', beam=5)
Thanks

@Nagoudi Did you try fairseq-interactive? You can do, for example:
fairseq-interactive /path/to/bin/dir \
  --task language_modeling \
  --path /path/to/checkpoint.pt \
  --sampling --beam 1```

And just type "Barack Obama". The command will generate the rest. You can even supply the prefixes from stdin.

@mhagiwara How to use fairseq generate new sentence give some words with raw txt input file instead of stdin

@lqniunjunlper try the --prefix-size option with fariseq generate


Tree: Flag to hide root from display

In certain situations it would be useful to hide the root of a tree, either to save on screen space or for clarity. A hide_root flag could allow this behavior.  For example:
>>> tree = Tree("Dir to print")
>>> tree.add("dir1").add("file1")
>>> tree.add("file2")
>>> print(tree)

Dir to print
├── dir1
│   └── file1
└── file2

could instead be display as
>>> tree = Tree("Dir to print", hide_root=True)
>>> tree.add("dir1").add("file1")
>>> tree.add("file2")
>>> print(tree)

dir1
└── file1
file2

Thanks!

@willmcgugan Can I work on this bug?

@noobyogi0010 be my guest!


Disallow use of players other than the Synclounge Player

Due to issues I've experienced trying to use the other players, I'd like the ability to have my self hosted server default to the Synclounge Player and not give users the ability to select other players that they may have issues using.
An acceptable solution would be either skipping the screen entirely (preferred) or making it the only option by not displaying other players

This is something we've discussed and will possibly show up in a future release

I can easily add a feature like this on my branch. I already have the web player chosen by default and can just get rid of the player selection with a config flag.

@ttshivers sounds like I could do this on my instance. Would you be able to point me to the files I would need to modify on my instance to configure this? I'm not super practiced in JavaScript, but I would like to learn.

I have a config option that forces the slplayer on my fork. I'd recommend checking that out if you want that feature immediately. Join the discord and I can help walk you through a few things.

I will take a look at that and definitely let you know if I have any questions.


Could not retrieve VM runtime logs

The code here is using Get-VMIntegrationService $Name -Name "Key-Value Pair Exchange").Enabled to check if KV pair exchange service is enabled.
However, when you are using a non-English locale of Windows, you will get other names like 键值对交换 (in chinese):

And it throws a error when getting by name:
# Get-VMIntegrationService WindowsOnlineImage-Sysprep354251398 -Name "Key-Value Pair Exchange"
Get-VMIntegrationService : 找不到具有给定名称的集成组件。
所在位置 行:1 字符: 1
+ Get-VMIntegrationService WindowsOnlineImage-Sysprep354251398 -Name "K ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Get-VMIntegrationService]，VirtualizationException
    + FullyQualifiedErrorId : InvalidParameter,Microsoft.HyperV.PowerShell.Commands.GetVMIntegrationService

which will cause "Could not retrieve VM runtime logs"
So I think we should remove the integration service enabled check in order to retrive the log correctly:
--- a/WinImageBuilder.psm1
+++ b/WinImageBuilder.psm1
@@ -1158,8 +1158,7 @@ function Wait-ForVMShutdown {
         $vmState = (Get-VM -Name $Name).State
         $isOff =  $vmState -eq "Off"
         try {
-            if ($vmState -ne "Running" -or `
-                !(Get-VMIntegrationService $Name -Name "Key-Value Pair Exchange").Enabled) {
+            if ($vmState -ne "Running") {
                 continue
             }
             $currentVMMessages = Get-KVPData -VMName $Name

can confirm the same issue when buildong on a German Win11.
Your change resolves it.

If it needs to keep the integration service check, it can be done like the following I think
--- a/WinImageBuilder.psm1
+++ b/WinImageBuilder.psm1
@@ -1195,7 +1197,7 @@ function Wait-ForVMShutdown {
         $isOff =  $vmState -eq "Off"
         try {
             if ($vmState -ne "Running" -or `
-                !(Get-VMIntegrationService $Name -Name "Key-Value Pair Exchange").Enabled) {
+                !(Get-VMIntegrationService $Name | Where-Object Id -Match "2A34B1C2-FD73-4043-8A5B-DD2159BC743F").Enabled) {
                 continue
             }
             $currentVMMessages = Get-KVPData -VMName $Name

The ID value is described at MicrosoftDocs/azure-docs#52634


IE8 support

I recently upgraded the react router from 1.0.0-rc1 to 1.0.0-rc3 which breaks compatibility with IE8 with the following error:
Invariant Violation: ReactCompositeComponent.getChildContext(): childContextTypes must be defined in order to use getChildContext()
I have had to roll back to 1.0.0-rc1 for the moment.
Any Thoughts?
Many Thanks
Adam

Do you have any more details on where this error is being thrown?

provide more details and we will reopen. Hard to help with that at the moment.

hey guys, I'm at a company that also has to support ie8 (government man...) and I'm 99% sure I know what's going on. Basically you can't do things like https://github.com/rackt/react-router/blob/master/modules/Router.js#L30. where you define static props right on the class, instead you have to do things like this: https://github.com/rackt/react-redux/pull/135/files where you just put the props at the bottom. It's really simple and I can open a PR to fix it. I'll letcha know how it goes! (the problem is that object.defineProperty it un-polyfillable and that particular interaction needs object.defineProperty.

That's not correct - the code above is actually not valid in any browser; it runs because we transpile it through Babel into legal code.

I'm well aware of the transpiler being used. When you use static properties, the transpiler (babel) uses defineProperty, when you don't have static props, it doesn't use defineProperty. Check my PR that I linked for a full discussion.

sorry this is the discussion: https://github.com/rackt/react-redux/issues/133

My bad! I wasn't aware it was a consequence of that specific Babel interaction.

To clarify - this is broken even when using es5-shim?

Yup, Completely broken and unfixable. Class properties are still
experimental (https://babeljs.io/docs/plugins/). I have a PR that I'm about
to setup that removes them completely. Not sure if there is a way to lint
against this though as I couldn't find a static properties type rule...
On Thu, Nov 12, 2015 at 2:54 PM, Jimmy Jia<EMAIL_ADDRESS>wrote:

To clarify - this is broken even when using es5-shim?
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/react-router/issues/2314#issuecomment-156216539
.

@mattydoincode
I'd drop up to Babel stage 1 from stage 0 if you want to enforce the non-use of class properties.
Although I think Babel 6 moved them up to the stage 1 preset, so worth tacking a note somewhere.

You can also blacklist the specific Babel transformation if you want to be more explicit.

I'm still researching locally to see exactly how ie8 is responding to
everything. Will keep you posted! Just want to make sure I can back
everything up with real world results.
On Thu, Nov 12, 2015 at 3:06 PM, Jimmy Jia<EMAIL_ADDRESS>wrote:

@mattydoincode https://github.com/mattydoincode
I'd drop up to Babel stage 1 from stage 0 if you want to enforce the
non-use of class properties.
Although I think Babel 6 moved them up to the stage 1 preset, so worth
tacking a note somewhere.
—
Reply to this email directly or view it on GitHub
https://github.com/rackt/react-router/issues/2314#issuecomment-156219537
.

in my project say "setter & getter is not support in this javascript engine" and i try to read your code. i find this is case by "export * from "./xx" some code like this.

https://phabricator.babeljs.io/T7322

hello you mean this can fix the issues? @SimenB

But we refer to the use of the compiled lib file, is that we want to compile the webpack which includes nodo_modules?@SimenB

If that issue is addressed, the router would be compiled in an IE8 compatible way. It's not something you can fix on your end, either the router has to export in some other way, or Babel need to change how it's compiled.
I haven't tried using the router with IE8, but you can probably import directly from lib/ (unsure how supported it is, so you might want to lock down you version of the router), to avoid the unsupported code in the entry point.

thank you very much for your help. i have try to babel compiled by IE8 way. but it still not work.
it may be other npm  class libraries made. i think this too many libraries not support Ie8.
i from china ,my english is poor, thanks agan.


bug: add more spaces between highlights

Type of feature
🍕 Feature
Current behavior

Suggested solution
Add more space between highlights.
@open-sauced/triage Thoughts?
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

@TAKANOME-DEV I would like to work on it.

Feel free to take it :+1:

hey, @parmishh are you still on it?

@shamimbinnur the issue is not visible on my device feel free to work on this if its visible on your device


Date time picker field is read only

how we can make the date picker field editable

This is by design actually, so there is no way to type.


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=364812151
https://github.com/Azure/azure-cli-extensions/commit/eb787963edb93db5c7083b37f67012456040fdea

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


cli version toggleMenu don't work

cli version toggleMenu doesn't work
need help. @GRoguelon

@Alex-0407 thanks for bug report. Try to check this bug in the latest version.


Ignore certain IAM policy ARNs

AWS has some stock (unremovable) IAM managed policies that can be easily ignored by ARN:
e.g. arn:aws:iam::aws:policy/AmazonGlacierReadOnlyAccess Where "aws" is the value where the account number normally goes. Can we get an easy way to ignore this policy?
Perhaps policies should be ignored by default if they are not attached to anything?

When you have multiple accounts, these are somewhat annoying to deal with in security_monkey.
I like your suggestion of ignoring them if they are not attached to anything.

Agreed, ignoring AWS managed policies that are not used would eliminate a vast amount of noise.

I just merged @llange's PR so you can now add an ARN prefix to the ignore list and have security_monkey ignore AWS managed policies.


False positive in crossing way validator

https://www.openstreetmap.org/way/866584105 vs https://www.openstreetmap.org/way/847006616

OK, tunnel is a better tag here.

OK, tunnel is a better tag here.


Keyword match for duplicated test examples in CreateOrUpdate api

For now, to distinguish create example and update example, the x-ms-examples name should be SomePrefix_create/SomePrefix_update.
Is it possible to add keyword match rule in codeGen to distinguish the example below?

close since PR merged


Questions about perturbed area ratio

@VDIGPKU
I read your paper, and I have some questions about the understanding of the perturbed area ratio in Figure 1 of the paper:

The calculation formula for perturbed area ratio is the area of the patch divided by the area of the image?
Or is the number of pixels in the patch divided by the total number of pixels in the image?

I think both two are right. Could you tell me the difference between the two?

@Huaxingweichen
From the calculation results, there is no difference between the two. A single pixel can be regarded as an area of 1×1.
But I have a question. As we all know, for all the pixels of the RGB image, the number of pixels is w×h×3. Assuming the number of disturbances is rn, then in your paper, calculate whether the disturbance ratio is rn/w·h·3 or rn/wh ?
In other words, does that 3 channel need to be considered?

You are welcome.


E1019 false positive on transfer family policy parameters

CloudFormation Lint Version
0.71.0
What operating system are you using?
windows
Describe the bug
E1019 falsely trips on the 3 transfer policy parameters.
https://docs.aws.amazon.com/transfer/latest/userguide/session-policy.html
Expected behavior
E1019 doesn't trip on these parameters
Reproduction template
AWSTemplateFormatVersion: 2010-09-09

Resources:

# Transfer User
  TransferUser:
    Type: AWS::Transfer::User
    Properties:
      HomeDirectoryMappings:
        - Entry: /
          Target: /bucket/
      HomeDirectoryType: LOGICAL
      Policy: !Sub |
        {
          "Version": "2012-10-17",
          "Statement": [
            {
              "Sid": "AllowListingOfUserFolder",
              "Action": [
                "s3:ListBucket"
              ],
              "Effect": "Allow",
              "Resource": [
                "arn:${AWS::Partition}:s3:::${transfer:HomeBucket}"
              ],
              "Condition": {
                "StringLike": {
                  "s3:prefix": [
                    "${transfer:HomeFolder}/*",
                    "${transfer:HomeFolder}"
                  ]
                }
              }
            },
            {
              "Sid": "HomeDirObjectAccess",
              "Effect": "Allow",
              "Action": [
                "s3:PutObject",
                "s3:GetObject",
                "s3:DeleteObject",
                "s3:GetObjectVersion"
              ],
              "Resource": "arn:${AWS::Partition}:s3:::${transfer:HomeDirectory}*"
            }
          ]
        }
      Role: replace-me
      ServerId: server-id
      UserName: username

Can you provide some more details. This is what I get when trying your template:
Template format error: Unresolved resource dependencies [transfer:HomeFolder, transfer:HomeBucket, transfer:HomeDirectory] in the Resources block of the template  You sure you aren't suppose to be escaping those values?

you're right. i missed that when adding the policy as described in the link into the sub. sorry about that.


Run tool plugins against all files at once when possible.

Significantly speeds up many of the tool plugin runtime durations.

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (9723547) compared to base (b3844e2).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #73   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          131       129    -2
=========================================
- Hits           131       129    -2

Impacted Files
Coverage Δ

src/statick_tex/plugins/tool/chktex_tool_plugin.py
100.00% <100.00%> (ø)

...rc/statick_tex/plugins/tool/lacheck_tool_plugin.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add validation control to column accessor init

Add validation control to column accessor init
Closes #737

This PR adds a validate parameter to the WoodworkColumnAccessor init method to allow users to optionally skip validation checks during initialization. Default behavior is for validation to happen.

We can probably set validate=False for a couple of the places where we initialize Woodwork on a series that we're grabbing from a table (pop, getitem, indexers, _make_series_call) if we want.

We can probably set validate=False for a couple of the places where we initialize Woodwork on a series that we're grabbing from a table (pop, getitem, indexers, _make_series_call) if we want.

Ah, yeah. Good point. I'll review and update.

We can probably set validate=False for a couple of the places where we initialize Woodwork on a series that we're grabbing from a table (pop, getitem, indexers, _make_series_call) if we want.

@tamargrey Added validate=False in a few locations that should be safe (I think).


failed to parse schema

error is attached below, and the schema is downloaded with command graphql-client introspect-schema https://api.mainnet.aptoslabs.com/v1/graphql  --output ./schema.graphql

#[derive(GraphQLQuery)]
|          ^^^^^^^^^^^^
|
= help: message: called Result::unwrap() on an Err value: GeneralError("Parser error: schema parse error: Parse error at 1:1\nUnexpected {[Punctuator]\nExpected schema, extend, scalar, type, interface, union, enum, input or directive\n")

Could it be that your schema is JSON, but with a .graphql extension?


Properties of components with multiple values get dropped when converting from Calendar<'_> to Calendar

When parsing a calendar with icalendar::Calendar::from_str (which I believe is the recommended method), properties with multiple values are flattened and only the last value for a given key is used.
This happens in the From<Component<'_>> impl for InnerComponent:
impl From<Component<'_>> for InnerComponent {
    fn from(component: Component) -> Self {
        Self {
            properties: component
                .properties
                .into_iter()
                .map(|p| (p.name.clone().into_owned().into(), p.into()))
                .collect(),
            components: component.components.into_iter().map(Other::from).collect(),
            multi_properties: Default::default(),
        }
    }
}

Since BTreeMap is used for InnerComponent properties only one value per key is stored. Multi_properties does not seem to be used in the case of parsing from string.

I'd be happy to help with this by submitting a pull request. I did see a comment in component.rs that multi_properties should be multi-map. I've found in my brief testing that simply changing the type of properties from BTreeMap to something like multimap achieves the desired results.
This may be undesired as the spec does not allow for multiple properties of the same type in all cases. However, this would at least allow for the consumer to verify if multiple properties were used and in violation of the spec.

Hi, thanks for the help, I'd be happy to get some input here!
The multimap would be a great approach, but exactly that spec compliance is the reason (IIRC) why I didn't make use of it yet. However, maybe it is not too difficult to handle the cases where multiple values are undesired different, by either rejecting subsequent values or overwriting them. I haven't thought this through entirely yet. Maybe we could also just put a check into the parser. Then only the multi-properties field would be a multimap and we decide (by knowing the spec) which values go where.
What do you think? AFAIK there are not too many props that qualify for the multi-map, maybe we can just handle those few special caes.

I think that is a good approach, having the parser filter properties that "MAY occur more than once" (as the spec says) and adding those to multi-properties field instead of the properties field. A quick count shows that there are only about 12 properties that can occur more than once and they seem to be the same for each component (event, todo, etc.).
I didn't look too closely at the sub components yet, but it may be safe to ignore those for now and just have them continue to use the properties field.
I'll work on putting something together as a PR and we can see what that looks like.

fixed by #82


Birt Report not found

Hi,
First of all, thanks for this birt docker images.
The birt report example [1] works fine, but when I try to get my own rptdesign [2], I get this error:

The report file : test_web.rptdesign does not exist or contains errors.
This test_web file is a very basic report that only contains a text area with "hello word".

My own reports are in folder located in /home/admin/birt_report. And the docker run is :
docker run --name birt_host -p 9002:8080 -v /home/admin/birt_report:/var/lib/tomcat7/webapps/birt/reports:ro -d lavadiablo/docker-birt-host
Please could you tell me what I'm doing wrong.
Thanks
Arnaud
[1] http://mywebserver:9002/birt/frameset?__report=test.rptdesign&sample=my+parameter
[2] http://mywebserver:9002/birt/frameset?__report=test_web.rptdesign

As all your reports are stored in the folder "reports", you need add it in the url.
In your case,
http://mywebserver:9002/birt/frameset?__report=reports/test_web.rptdesign

Oh yeah ! Thanks lavadiablo :)


Remove nolint from core/usig/sgx/usig-enclave.go.in

gometalinter should work fine after https://github.com/alecthomas/gometalinter/issues/450 was fixed.

@sergefdrv the mentioned issue was fixed for go-1.9 and 1.10. So can we close this issue?

@Naoya-Horiguchi Yes, it was fixed. The only thing left is to remove the // nolint hint from our source code https://github.com/nec-blockchain/minbft/blob/master/usig/sgx/usig-enclave.go.in#L68


Here are two misc patches I added while browsing your source.

Thanks for your project

Great, thank you! :)

yw! :)


OCI_GetString returns null on Empty_Clob

Hi,
I see this issue already reported (#112), and a fix seemed to be provided, but I still see the issue in 4.7.4. Here is my test case:
create table test_ociclob (col clob);
insert into test_ociclob values(null);
insert into test_ociclob values('');
insert into test_ociclob values(empty_clob());
commit;
select col, dbms_lob.getlength(col) from test_ociclob;

The first and the second rows return correct values (empty strings), and the last one return a null pointer. Has the behavior around handling empty clobs changed? Or maybe the fix didn't make it in this release?
Thanks!

Hi,
Can you provide a sample code to reproduce the issue?
I presume the C code is using OCI_GetString() ?
Insertion order is not necessary the same as default select order.
In your example, no way to correlate a given inserted row to a row in the resultset.
Add another column with an numeric id for example.
The first insert you made is a NULL value. In this case, OCI_GetString() behaviour is to return NULL, not an empty string.
While other ones ('"' and empty_clob()) insert a non NULL clob.
In this case, OCI_GetString() returns an empty string.
Regards,
Vincent

Just tried with following code:
create table test_ociclob (name varchar2(50), value clob);
insert into test_ociclob values('NULL CLOB', null);
insert into test_ociclob values('EMPTY STRING', '');
insert into test_ociclob values('EMPTY CLOB', empty_clob());
insert into test_ociclob values('CLOB WITH VALUE', 'ABC');

void err_handler(OCI_Error* err)
{
    printf(OCI_ErrorGetString(err));
}

int main(void)
{
    OCI_Initialize(err_handler, NULL, OCI_ENV_DEFAULT);

    OCI_Connection* cn = OCI_ConnectionCreate("localhost:1521/db19c", "usr", "pwd", OCI_SESSION_DEFAULT);
    OCI_Statement* st = OCI_StatementCreate(cn);

    OCI_ExecuteStmt(st, "select name, value, dbms_lob.getlength(value) from test_ociclob");
    OCI_Resultset* rs = OCI_GetResultset(st);
    while (OCI_FetchNext(rs))
    {
        printf("name=%s, value=%s, size=%d\n", OCI_GetString(rs, 1), OCI_GetString(rs, 2), OCI_GetInt(rs, 3));
    }

    OCI_Cleanup();
}

result is:
name=NULL CLOB, value=(null), size=0
name=EMPTY STRING, value=(null), size=0
name=EMPTY CLOB, value=(null), size=0
name=CLOB WITH VALUE, value=ABC, size=3

with NULL CLOB, oracle client reports a NULL value => OCI_GetString() returns NULL
with EMPTY STRING, oracle client reports a NULL value => OCI_GetString() returns NULL
with EMPTY CLOB, oracle client reports a NOT NULL value with a CLOB LENGTH = 0 => OCILIB allocates a empty string then  copy 0 bytes from the clob into the string and instead of returning this empty string, it returns NULL due to wrong internal call return value check.

Thus there is instead an issue but not the one you mentionned.
With the fix we get the following:
name=NULL CLOB, value=(null), size=0
name=EMPTY STRING, value=(null), size=0
name=EMPTY CLOB, value=, size=0
name=CLOB WITH VALUE, value=ABC, size=3

I commit this fix in the v4.7.5 branch

Hi Vincent,
Your example makes sense - thank you for correcting me and for fixing the issue as you identified it.
As I dug deeper into it today I realized that the root cause of my issue is different. Indeed, OCI_GetString returns null on both null clob and empty string. It wasn't a problem in my code because I checked OCI_IsNull before calling OCI_GetString. And in case of null value and empty string, OCI_IsNull returns True, so I didn't even call OCI_GetString in these cases.
With empty clob, OCI_IsNull returns False, and OCI_GetString used to return null (before your fix), which was inconsistent and led to a problem in my code. Now that both OCI_GetString and OCI_IsNull return consistent results, it should be fine.
Thanks for looking into it!

while (OCI_FetchNext(rs))
    {
        printf("name=%s, value=%s, size=%d, isNull=%d\n", OCI_GetString(rs, 1), OCI_GetString(rs, 2), OCI_GetInt(rs, 3), OCI_IsNull(rs, 2));
    }


DO NOT MERGE Towards 1.0.0.

Yup, the master branch is going to target 1.x, now :P
I have create a separate branch 0.6.x for bug fixes and other development that should go in 0.6.x releases (e.g., JDK parts). I have also set up new Jenkins jobs for a nightly and weekly for that branch (although the "nightly" only runs weekly as well).

Review by @gzm0 for fast-forward on master.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3787/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/5006/
Test PASSed.


Lakctl ingest stages more objects than source S3 bucket

When ingesting a dataset from an S3 bucket to LakeFS using lakectl ingest. The source bucket contains around 15k objects, however the command seems to be stuck staging objects recursively. I interrupted the command when more than 3M objects were staged.
I am reproducing below the command and the output. While I want to protect the name of the bucket, I am masking the real names below, while trying to preserve the structure of the paths, i.e. path parts with same letter have same name. I suspect this might be important while debugging since it looks like the staging gets stuck in a recursive call.
$ lakectl ingest --from s3://<A-B-C-D-E-F>/ --to lakefs://<A-B-C-D>/<D-E-F>/data/raw/
Staged 3021418 objects so far...

The storage namespace for the <A-B-C-D> LakeFS repository is s3://<our-lakefs-storage>/data/<A-B-C-D>.
See also the Slack #help channel thread.

Found the cause - a misuse of the s3 pagination causes infinte loop when more than 1000 (page size) objects exists in the ingested directory.
A fix is in place andf now I'm working on a test to prevent future such cases


Regenerate API docs

A few minor changes in the descriptions, such as "Open Telemetry" => "OpenTelemetry" (I guess this is a trademark or something ... it's refer to as that in all the ocp docs)
Remove any reference to otel traces (we don't support that and I'm doubting we will ever)
Added details on what NetworkEvents is used for [1]
Regenerate doc

[1] about NetworkEvents: in ocp 4.17.0 this isn't available... It will be in a z-stream release. I think we should remove that from docs manually for the time being.. and also we'll have to mention which ocp version is required
FYI @skrthomas

I have docs PRs open for FlowCollector and FlowMetrics regeneration
https://github.com/openshift/openshift-docs/pull/83175
https://github.com/openshift/openshift-docs/pull/83184
I'm still waiting on the Flows formats, per my question about whether or not OTEL formats will be added to this table? https://github.com/netobserv/network-observability-operator/pull/796#discussion_r1785099561

@skrthomas all comments addressed except for the two that I commented

@skrthomas I'm going to merge this one despite of havng 2 last comments on your merged PR
I'll open a new PR for documentation following some slack discussion wrt eBPF filters

oops I didn't push my changes before merging 🤦🏼♂
I'll fix that now worries


[3.0 regression] AreEqual/AreNotEqual with nullable structs and implicit casts don't compile any more

Describe the bug
After updating MSTest.TestFramework to 3.0.2 unit tests that use Assert.AreEqual/AreNotEqual with a nullable struct parameter that has an implicit cast operator to the other parameter type implemented don't compile any more.
Steps To Reproduce

Create a new test project. (It will be created with MSTest.TestFramework 2.2.10.)
Add the following code.

public struct MyValue
{
    public int Value;

    public static implicit operator int(MyValue v) => v.Value;
}

[TestClass]
public class UnitTest1
{
    [TestMethod]
    public void TestMethod1()
    {
        var v = new MyValue();
        MyValue? nullable = null;

        // Still compiles without errors.
        Assert.AreEqual(0, v);
        Assert.AreNotEqual(1, v);
        Assert.AreEqual(null, nullable);
        Assert.AreNotEqual(v, nullable);

        // Doesn't compile any more.
        Assert.AreNotEqual(1, nullable);
        Assert.AreEqual(0, nullable); // Note: This fails. I don't know if there is a useful use-case for this.
    }
}

Try to compile the project, see that it compiles just fine.
Update MSTest.TestFramework to 3.0.2
See compile errors

Expected behavior
Code should compile without errors.
Actual behavior
Code has compile errors:
CS0411	The type arguments for method 'Assert.AreNotEqual(T?, T?)' cannot be inferred from the usage. Try specifying the type arguments explicitly.
Additional context
The Assert.AreEqual case might not make sense. But at least the Assert.AreNotEqual case has valid use-cases and should work.
It seems like the reason for this is #254/#1429 because version 2.2.10 used this overload.
Cc @whoisj @Evangelink

Hi @cremor,
Thanks for raising this issue/regression with a proper analysis and reproducers!
We have had a lot of reports about "runtime" errors that could be caught at compilation because of object, object overload on Assert.AreEqual where having this T, T actually helps a lot. When I did the implementation I assumed that the opposite was interesting but didn't thought at all about implicit use cases. As you properly stated, the AreEqual and AreNotEqual might need to be different as they may want to capture different use cases.

I found a few additional things:

If you define the implicit operator the other way around (implicit operator MyValue(int v)) then the code still compiles with the new version. It then uses the Are(Not)Equal<MyValue?>() overload.
If you define both implicit operators then the first two Are(Not)Equal calls (right after the comment Still compiles without errors, which are not using a nullable variable) are the ones which don't compile any more.
Note: In the old version (where they do compile) this calls will fail now so the example might not make sense. But there might be relevant use-cases.
Based on the second point: If I then change those two not compiling lines to pass a long instead of an int as the first parameter it compiles again. It then uses Are(Not)Equal<long>(). So double implicit casts work but single ones not? 😕
Note: And now those two lines not only compile, but even pass again. Because the twice-converted long values are correctly compared.

I just did a quick investigation and before it was always boxing to object and then using object.Equals(expected, actual). If you rewrite
Assert.AreNotEqual(1, nullable);
Assert.AreEqual(0, nullable);

into
Assert.AreNotEqual<object>(1, nullable);
Assert.AreEqual<object>(0, nullable);

it will compile and provide expected behavior.
I am exploring the options because bringing back object, object overload makes it always favored over generic version.

Hi @cremor, I did more tests and discussed with the team the strategy we want to adopt here and we decided that we want to keep the current behavior as we want to allow strict comparison.
If you try to use the EqualityComparer with the 0 and nullable case (i.e. EqualityComparer<MyValue>.Equal(0, nullable)) you will see this is using the (object?, object?) orverload and not the (MyValue?, MyValue?) one because you defined the implicit operator only on a non-nullable MyValueType. If you start adding the following implicit operator:
public static implicit operator int(MyValue? v);

You will see that the assertions will start working. Lastly, you can use Assert.Are(Not)Equal<object> to force using the object equality.
Given what I wrote above and the fact we didn't receive other feedback on this change, I would move forward by closing this issue as won't fix. If we receive more feedback, we will of course revisit this decision.

@Evangelink Just to confirm - if we want the old functionality from 2.0 when upgrading to 3.0.x we can specify the type as object  and it'll provide the same result as the 2.0.x versions?

That's correct.


Spaces in keys break zabbix-sender

Here is an example. I'm simulating the parsing of the input from pm2-zabbix --monitor, which produces a key-value stream which is parsed by zabbix-sender and sent. I'm fetching just one row from this stream, and sending to zabbix:
echo "xxxxx-be-preprod01 pm2.processes[xxxxx Frontend-0,cpu] 90"  | zabbix_sender -vv --config /etc/zabbix/zabbix_agentd.conf -s hostname --input-file -
zabbix_sender [25699]: DEBUG: answer [{"response":"success","info":"processed: 0; failed: 1; total: 1; seconds spent: 0.000028"}]
info from server: "processed: 0; failed: 1; total: 1; seconds spent: 0.000028"
So, if there are spaces in pm2 process, the server fails to process the monitor part. The "discover" part is working, though, because if we enclose the key with double quotes, it goes through:
echo "xxxxxx-be-preprod01 "pm2.processes[xxxxx Frontend-0,cpu]" 90"  | zabbix_sender -vv --config /etc/zabbix/zabbix_agentd.conf -s hostname --input-file -
zabbix_sender [25131]: DEBUG: answer [{"response":"success","info":"processed: 1; failed: 0; total: 1; seconds spent: 0.000083"}]
info from server: "processed: 1; failed: 0; total: 1; seconds spent: 0.000083"

This is going to be addressed in PR #31.


[SPARK-25400][CORE] Increase test timeouts

We've seen some flakiness in jenkins which looks like it just needs a
longer timeout.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2990/
Test PASSed.

Test build #95903 has started for PR 22385 at commit daf76ed.

Hi, @squito . Could you add [TEST] to the title?

Test build #95903 has finished for PR 22385 at commit daf76ed.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95903/
Test FAILed.

Retest this please.

Test build #95914 has started for PR 22385 at commit daf76ed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2997/
Test PASSed.

Test build #95914 has finished for PR 22385 at commit daf76ed.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95914/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3006/
Test PASSed.

Test build #95928 has started for PR 22385 at commit daf76ed.

Test build #95928 has finished for PR 22385 at commit daf76ed.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95928/
Test PASSed.

@dongjoon-hyun sure thing, done

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3092/
Test PASSed.

Test build #96046 has started for PR 22385 at commit daf76ed.

Merged to master/2.4/2.3

Test build #96046 has finished for PR 22385 at commit daf76ed.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96046/
Test PASSed.


DFU: support mcuboot direct execute-in-place (XIP)

dual slot: execution in place
mcuboot direct execute-in-place (XIP) mode was recently
introduced. This mode allow to run either image form slot_0 and slot_1. Mcuboot doesn't perform any swap operation - just discovery which image may and should to be run and run it.

[ ] Update DFU submodules for make them able to operate either on slot_0 and slot_1
[ ] allow to build application either for slot_0 or slot_1
Best if both at the same time.
[ ] mcumgr/SMP support for recognizing which image need to be upload (to be defined)

cc @utzig

@de-nordic Is working on solution for that.

Hi @nvlsianpu @de-nordic
We're trying to perform dual slot: execution in place software upgrade on NXP i.MX RT 11xx MCU
Is this feature available yet? could you point us to the documentation?

CC @tkmozhi

We're trying to perform dual slot: execution in place software upgrade on NXP i.MX RT 11xx MCU
Is this feature available yet? could you point us to the documentation?

Half available: The Direct-XIP is supported by mcuboot, but DFU from Zephyr is not out-of-the-box solution as application needs to be built for specific slot it will be running from and there is no direct support for building pair of applications as candidates for both slots; the mcumgr supports rejecting application that was not built for DFU available slot with special TLV added to the header of binary and Kconfig options enabled at build.

@danie007
@de-nordic Describes situation very well. Right now you might use the direct-xip mode and run the zephyr application, but this requires modification of DTS fixed-partition for building the application for the alternative slot (slot-0 must swap the place with the slot-1). And as Dominik mentioned application can't reject the image for bad slot while it downloading the image.

I think this has a dependency on the Hardware to support address remapping, some controllers are able to remap some physical XIP address range to a CPU address range (this is not related to MMU).
I have used mcuboot before in a similar situation where the decision of mcuboot about which image to be booted is passed to the do_boot function which will check if a remapping is needed then jump to the image.
I think ST, NXP, ESP32 has such remapping feature to support dual image, but AFAIK mcuboot don't make use of such HW feature.


Add osbuild-ci images based on c8s and c9s

Add two new variants of the osbuild-ci image based on c8s and c9s.
The intention is to use these images to run osbuild unit tests in the upstream, to catch any RHEL incompatibilities early as possible.
CentOS Stream is lacking some packages. Install all of the unavailable python packages using pip and also pytest on cXs images. The reason is for not installing pytest from cXs repositories is to get the latest version of it to not have to deal with lack of features on older releases.
In addition, the cXs base images contain minimal variants of some packages, which we want to install into them. To resolve the conflicts, allow erasing of packages during package installation.
The intention is that these cXs images will be used mostly to run the unit tests. The Fedora image should be used for all the additional testing (such as pylint, mypy, isort, ...), including unit tests.
In additon:

extend the scr/scripts/dnf.sh to optionally allow package erasing on installation (needed for cXs images.
disable repo GPG check for Google Cloud SDK repo, since it is failing and Google has it disabled as well :man_facepalming:

Thanks. This all LGTM!

Thanks. Looks like I was naive to think that there won't be any additional new issue with the cloud-tools image... Marking as a draft until I resolve all the problems :facepalm:


New zarr requirement is not listed

zarr is newly imported and used in tests (without skips), but it is not listed in setup.py anywhere. So I don't know if it was supposed to be a dependency for arrays, or for anything at all.

        Parameters
        ----------
        arr: dask.array
            Data to store
        url: Zarr Array or str or MutableMapping
            Location of the data. A URL can include a protocol specifier like s3://
            for remote data. Can also be any MutableMapping instance, which should
            be serializable if used in multiple processes.
        component: str or None
            If the location is a zarr group rather than an array, this is the
            subcomponent that should be created/over-written.
        storage_options: dict
            Any additional parameters for the storage backend (ignored for local
            paths)
        overwrite: bool
            If given array already exists, overwrite=False will cause an error,
            where overwrite=True will replace the existing data.
        compute, return_stored: see ``store()``
        kwargs: passed to the ``zarr.create()`` function, e.g., compression options

        Raises
        ------
        ValueError
            If ``arr`` has unknown chunk sizes, which is not supported by Zarr.

        See Also
        --------
        dask.array.Array.compute_chunk_sizes

        """
>       import zarr
E       ModuleNotFoundError: No module named 'zarr'
dask/array/core.py:2859: ModuleNotFoundError

Thanks for catching this @QuLogic! We should make sure this test is skipped if zarr isn't installed by adding pytest.importorskip("zarr") to the top of the test. Any interest in submitting a PR with a fix?

Sure, that's easy; should this be listed in setup.py somewhere though?

I think we want to avoid adding zarr to setup.py. Since zarr is only necessary for to_zarr/from_zarr and isn't required more broadly for using dask.array like, e.g. toolz is, we don't want to make all dask.array users install zarr unnecessarily and instead treat it as an optional dependency for those who would like to use zarr I/O features. If you're curious, there was a recent conversation on this topic over in #5209.

I forgot I added a fix for this in #5400 while cleaning up the PY2 code. Tests now should pass without zarr installed. Closing.


variant to disease table does not contain the proper number of studies

The total number of studies is 14027 although the number of studies included in the v2d should round 9k but definitely not hundreds as I currently have.

The problem is occurring because gs://genetics-portal-data/v2d/ld.parquet contains old study IDs from V1 data.
I have updated this file to contain study IDs from V2 of the data.
However before we release, I will have to re-run the LD pipeline to produce LD data for all of our top loci (so that we have complete coverage).

Will be fixed when pipeline re-run, cause addressed.


ARROW-6908: [WIP][C++][Python]Bazel

Minimal example showing cross python/C++ still needs some cleanup and discussion on ML for next steps.

Going to close for now until I can update to bazel 2.0.

Going to close for now until I can update to bazel 2.0.
why ？？？

Hi @emkornfield , have you had any more progress on this? I think enabling bazel to use the cmake files would be the best solution, but if that's not currently possible, what do you think about bringing in the bazel support for Arrow from TensorFlow I/O for now so that others could benefit from it as well?


Navbar justify-content-end dropdown not staying in container-fluid

JSBin: http://jsbin.com/wijelawuso/edit?output
Click on "Matt" in the top right and notice the body horizontal overflow turns to scroll.
Fixed by adding the following css :
.container-fluid .navbar-nav.justify-content-end .dropdown-menu {
right: 0;
left: auto;
}
OS: Windows 7 Pro
Browser: Chrome 57 (latest stable)

This is easily addressed with .dropdown-menu-right. See http://v4-alpha.getbootstrap.com/components/dropdowns/#menu-alignment.


Ability to set custom port on machine

Currently there is no way to set a custom port for a machine. I also attempted to add it after the IP using the : notation but it also failed:
% viking machine add --name sh1-0151 --user ryan --key andromeda --port 3322 <IP_ADDRESS>
Incorrect Usage: flag provided but not defined: -port

% viking machine add --name sh1-0151 --user ryan --key andromeda <IP_ADDRESS>:3322
Error: host must be valid ip address

Now you can specify port via —port (-p) flag or put it in host like <IP_ADDRESS>:3322


Default 3D coordinate system is left-handed?

The following screenshot shows how a simple 3D coordinate system I made appears to be left-handed:

Code:
#import "@preview/cetz:0.2.0"  // Drawing diagrams directly in Document
#[
  #cetz.canvas(length: 2cm, {
  import cetz.draw: *
  rotate(y: 30deg)

  let grid_sidelength = 3
  grid(
    (-grid_sidelength/2, -grid_sidelength/2, -grid_sidelength/2),
    (grid_sidelength/2, grid_sidelength/2, -grid_sidelength/2),
    step: 0.5, stroke: gray + 0.2pt
  )

  line((-grid_sidelength/2, 0, 0), (grid_sidelength/2, 0, 0), name: "xaxis", mark: (end: "stealth"))
  content((name: "xaxis", anchor: 98%), [#v(1.5em)$ x $])
  line((0, -grid_sidelength/2, 0), (0, grid_sidelength/2, 0), name: "yaxis", mark: (end: "stealth"))
  content((name: "yaxis", anchor: 98%), [#h(-0.9em)$y$])
  line((0, 0, -grid_sidelength/2), (0, 0, grid_sidelength/2), name: "zaxis", mark: (end: "stealth"))
  content((name: "zaxis", anchor: 98%), [#h(-1em)$z$], anchor: "south-east")

  let ccol = red.darken(30%)
  line((0, 0, 0), (1, 0, 0), name: "ihat", mark:(end: "stealth", fill: ccol), stroke: ccol)
  content((name: "ihat", anchor: 65%, ), text(ccol)[#v(1.5em)$hat(i)$])

  let ccol = green.darken(30%)
  line((0, 0, 0), (0, 1, 0), name: "jhat", mark:(end: "stealth", fill: ccol), stroke: ccol)
  content((name: "jhat", anchor: 65%), text(ccol)[#h(-0.75em)$hat(j)$])

  let ccol = blue.darken(30%)
  line((0, 0, 0), (0, 0, 1), name: "khat", mark:(end: "stealth", fill: ccol), stroke: ccol)
  content((name: "khat", anchor: 65%), text(ccol)[#v(-1em)$hat(k)$])
})]

This seems like an odd choice to me. I tried changing `z-up` and `xy-up` in `set-style`, but I could not see any difference. Am I doing it wrong, or is the default coordinate system left-handed?
P.S: Awesome package. Easy to use, reaults look great.

Sorry, ment to raise this issue over at cetz itself. This is now done, so I will close this.

(Here's the cetz issue: https://github.com/johannes-wolf/cetz/issues/501)


Error 400

Description of the bug:
Today the api was working but since 2 hours I am getting ERROR 400.
Actual vs expected behavior:
This is the url.
https://generativelanguage.googleapis.com/v1beta/models/gemini-1.5-pro-latest:streamGenerateContent?alt=sse
Any other information you'd like to share?
No idea.

nevermind. the api changed.
HARM_CATEGORY_UNSPECIFIED  has been removed
and
HARM_CATEGORY_CIVIC_INTEGRITY has been added!


[Bug] Spells in compendium lost components/properties in migration to DnD 3

I had a lot of spells in compendiums that lost the components (V, S, M, Concentration) when they migrated to DnD 3. This didn't happen to spells that were on characters, which migrated without errors.
I noticed that the internal representation of these data was changed in DnD 3, to a collection of property strings rather than boolen flags, and the migration apparently didn't handle that conversion.
I searched the issue database and couldn't find any reports about this, so I'm not sure whether this has been fixed, or was just a glitch that only happened on my system.

There isn't any automated migration for personal compendiums if they are located in a module (such as a 'compendium module'). You would be required to run the migration scripts yourself for now.

Thanks for the response. How do I run the migration script myself?

Step 1: Run macro.
const id = "<idof your module goes here>";
const packs = game.modules.get(id).packs.map(p => game.packs.get(p.id));
for (const pack of packs) {
  await pack.configure({locked: false});
  await dnd5e.migrations.migrateCompendium(pack);
  await pack.configure({locked: true});
}
ui.notifications.info("Migration completed!");

Step 2: Wait for macro to finish.
Step 3: Run second macro.
const id = "<id of your module goes here>";
const packs = game.modules.get(id).packs.map(p => game.packs.get(p.id));
for (const pack of packs) await dnd5e.migrations.refreshCompendium(pack);
ui.notifications.info("All compendiums have been refreshed!");


Open hyper here is not working on Windows 10 1809 with PowerShell

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10  UPDATE 1809 x64 build 17763.316
Hyper.app version: 2.1.2
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/mrg0lden/83a75a7b43b4c60ff85868148680ad4b
Relevant information from devtools: N/A
The issue is reproducible in vanilla Hyper.app:  Is Vanilla (except changing to powershell)

Issue

I updated to Windows 10 1809 recently and also updated to hyper 2.1.2. I'm not sure which upgrade process causes this, but it used to work as expected with same attached .hyper.js file before both updates. Now it opens PowerShell in its directory C:\WINDOWS\System32\WindowsPowerShell\v1.0.

I updated to win 10 1809, and I cannot install Hyper by running 'hyper-Setup-2.1.2.exe'.

I think I have this issue too.

Hyper doesn't opens from folder context menu at all, it opens error window. Hyper opens if I remove "%V" from registry key \HKEY_CURRENT_USER\Software\Classes\Directory\Background\shell\Hyper\command, but in default foldel. Or it opens after typing hyper C:\ in run windows with the mentioned folder.

I have an issue kinda like this.
My Windows version is Windows 10 1809 and Hyper version is 2.1.2, but I'm using git-bash.exe instead of powershell. It does the same with empty shell parameter, using cmd.exe as a shell.
"Open Hyper here" works fine when I right click on the right pane (folder view) of Explorer or on the desktop. But it fails when I try to right click on a folder in the folder tree in the left pane of Explorer. Hyper doesn't open and the error window appearences on the screen.

I want to note that I got this issue has got resolved, but I don't know how.

@mrg0lden Can you do "Open Hyper here" with folders in the explorer's sidebar tree?

@Heegiiny I actually don't usually use it, but no it doesn't work. I suggest that you make a new issue for this as it's a very specific case.
I got the error"There's no associated program with this...".


toHaveSelector with .not.

The first case below does not work, whilst the second does. What is the implication of using expect(page).not.toHaveSelector? I would have thought it would be similar to the second example, but it is not.
// Does not work
await page.click('text=Delete');
await expect(page).not.toHaveSelector(selector);

// Works
await page.click('text=Delete');
await expect(page).toHaveSelector(selector, { state: 'detached' });

What do you mean with "does not work"? If you use the not selectors, it internally also tries to wait for the default timeout which is 30 seconds by default. So its recommended to pass there an option array and reduce the timeout to e.g. 5 seconds.

The selector exists at the time when await expect(page).not.toHaveSelector(selector) is called in our case. So that check fails.
But I would have expected the addition of the .not. to actually wait for 30 seconds for the selector to not exist.

@mxschmitt ?

@thernstig I believe this is because html element with defined selector is empty.
This is because the default state option value is visible, which requires an element to have a "non-empty bounding box and no visibility:hidden". Changing this value to attached requires only that an element is present in the DOM.

I suppose I misunderstood .not.. I expected it to wait till something like hidden since the default for a normal waitForSelector is visible. That is not how it works then, and I am required to do what I do in my second example? (Note I could have replaced the second example with state: 'hidden' equally well since it does not matter in my case if it is hidden or detached, I just don't care for it to be seen at all.)

@thernstig I got your point. And I suppose maybe we should redefine default properties of waitForSelector, cause it can be a bit confused. @mxschmitt what do you think?

@mxschmitt ?

I also got confused from docs to have the same expectations as @thernstig described
I'm not sure about redefining properties, but adding something like "use await expect(page).toHaveSelector(selector, { state: 'hidden' }); to wait for selector to disappear" to the readme seems like a good idea

I saw its possible to detect if its not or a normal selector. So we can simply have a timeout of e.g. 1000 by default when its not and otherwise no (playwright default: 30s) timeout: https://jestjs.io/docs/expect#thisisnot

I feel like having .not.toHaveSelector(selector) behave like .toHaveSelector(selector, { state: 'hidden' }) is a reasonable expectation, since hidden is an opposite to default visible state (docs)
In my experience, changing the timeout doesn't really help, since all the other selectors wait for the desired state, and current .not combination acts right away, no matter the timeout

I'd like to add that toHaveSelectorCount has a similar issue. It's quite natural to want to say:
await expect(page).toHaveSelectorCount(selector, 0);

For example, when you have a filter input, and simulate typing a filter that results in zero matches. Sadly it doesn't work as expected.
In this example, this works:
expect(await page.$$(selector)).toHaveLength(0);


ACCESS DENIED

cant install it due to this...

if the installer is running as admin, the issue is most likely with antivirus software.
check your av/security settings and turn off anything that could be limiting file/folder access.


Investigate windows support

Personally I don't use Windows, and wouldn't even begin to know how to approach this.
What we need for cue4s to work on windows is:

some implementation of Terminal (see ANSI-codes based one: https://github.com/neandertech/cue4s/blob/main/modules/core/src/main/scala/AnsiTerminal.scala#L19)
a cross-platform way to put terminal in char mode: https://github.com/neandertech/cue4s/blob/main/modules/core/src/main/scalanative/InputProviderImpl.scala#L29-L39. Perhaps on JS this is already abstracted away
a way to read a single character (e.g. getchar() on native)

Done in #36


Enum type for ActivityType

Description of bug
You must add .value text before any Activity Type
How to fix it?
Remove Enum inheritance
# activty.py
# old version
...
class ActivityType(Enum):
...
# new version
...
class ActivityType:
...

Done


Table: autoResize property doesn't work as expected

When the autoResize property is undefined or set to true, the table columns should use all width available and their size should be either set based on the column width property sent by the server (which is currently not supported) or the length of the longest data (checked in useLayoutEffect). When the table gets resized (eg. SplitPanel) the table and its columns adjusts its width to still use 100% of the width so that there is no scrollbar when getting smaller.
When autoResize is false, the columns always take their full width, they don't care if they overflow the table width, a scrollbar is available instead. When making the table smaller in a splitpanel, the columns are being "pushed out" if there is no more width available -> scrollbar. Also, when resizing columns smaller, the table shoudn't have 100% width = when the last column is resized smaller, there will be a gap between table container and table.

I think that in autoresize true/undefined works. But autoresize false currently only works in table which don't have virtualscrolling enabled. The table-columns will still only try to use 100% of the table's width and won't overflow. Also, when scrolling horizontally, the tablerow-tableheader alignment gets messed up.

This might be fixed but relies on the sizing of the initially loaded values. So if larger values are loaded when scrolling down, they will be clipped with an ellipsis.

I will check it out tomorrow. But I guess this will be fine because we can't look into every every single datarow when there are a lot. So eventually it's always possible that there a larger values further down. I think in my useLayoutEffect where we check for the widths for the headers, I think I only check for the first 20 values

Yup, I'll probably extend that check to use all currently loaded rows and that should give us a somewhat reliable estimate


Bug in IE upload

I've been unable to upload files using FlowJs from Internet Explorer (IE).
My investigation seems to suggest that the issue seems to be in how IE implements the blob.slice method, which is called in webAPIFileRead(), line 1065 of /dist/flow.js. The fileType parameter is often undefined. Most browser implementations of blob.slice convert an undefined fileType to an empty string, however IE seems to convert an undefined fileType to a string "undefined". This becomes a problem server side when using a framework that can't parse this value and causes the upload to fail.
I've fixed this by making a copy of FlowJs source and modifying webAPIFileRead() to convert falsy fileType values to an empty string prior to calling slice:
// Prevent IE from setting the blob mime type 'undefined' if fileType is undefined.
// Other browsers set the mime type to an empty string if fileType is falsy.
fileType = fileType || '';
chunk.readFinished(fileObj.file[function_name](startByte, endByte, fileType));

I'm interested if others have had this problem also, or if there is a better solution. If I've found a bug then I'm prepared to submit a PR with tests, however I ask first in case my efforts are not needed.

Nice patch @oh-wo
what was the issue causing? a failure of flowjs or what?
whould be greate if you could propose a pull request eventually including a test to cover this situation in order to prove that without your patch the failure happen and with your patch no.

I think you can create a pull request. Though I don't know if it is easy to create a failing test for this, because it is reproducible only in IE


How to save flutter camera stream file "CameraImage" save jpg ?

Hello i developed real time object detection app use this library. So i want save except stream image, but stream return "CameraImage" and this object inside
"planes" -> List
"plane" -> plane.bytes => Uint8List
i want this "img" stream save of image but i dont know planes convert one Uint8List  object . How to convert this type or how to save image ?

This might help you.
https://stackoverflow.com/questions/48638795/flutter-dartio-convert-uint8list-from-websocket-to-a-jpeg-file-i-can-draw