Mark Map's Cell Surfaces as Dirty More Accurately

Background
Currently, the map rendering code marks all surfaces that are rendering it as dirty each time a terrain cell has its appearance changed.  This is functional, but inefficient; it's only necessary to mark a cell surface as dirty if the cell that was changed is inside that surface's viewport.  Therefore, the current code is incorrectly causing a re-render for each map renderer, on each frame where the view did not move, but a piece of terrain outside that map renderer's viewport changed.
Ideally, when a terrain appearance is changed, surfaces would only be marked as needing a re-render if that terrain was inside their viewport.  Unfortunately, this is currently difficult to implement, because the ColoredGlyph.IsDirtySet event only gives you access to the colored glyph itself (via sender), and the ColoredGlyph on its own does not know its own position.
Proposal 1
SadConsole intentionally does not have a position field on ColoredGlyphs to conserve memory and overhead for general use cases, where most of the time it is unnecessary.  This is understandable, and in light of this I propose the following workaround to enable this optimization of the integration library:

create a class like so:

// This is a colored glyph class specifically designed for appearances of terrain.  It knows the terrain object
// that it is representing the appearance for, and via that, has access to its position.
public class TerrainAppearance : ColoredGlyph
{
public readonly RogueLikeCell Terrain;

// All ColoredGlyph constructors, but with added required parameter terrain which is set to the above field
}

REMOVE any and all constructors in RogueLikeCell that take a ColoredGlyph directly.

Modify remaining constructors to construct a TerrainAppearance object instead of ColoredGlyph, passing this in as the TerrainAppearance.parent parameter

Modify the IsDirtySet event handler to simply cast its sender to TerrainApperance, at which point it knows the position.

Note that this does not change the public interface in any breaking way; either the Appearance field can be left as type ColoredGlyph, or changed to TerrainApperance; in either case, both are ColoredGlyph subclasses so no functionality is lost from the user perspective.
Proposal 2
A simpler way to implement this is to simply bring back the AppearanceChanged event on RogueLikeCell, and automatically fire that event each time IsDirtySet is fired.  It may slow things down because it's adding another event into the chain that happens when appearances are changed, completely solves the issue, as AppearanceChanged is an event on the RogueLikeCell object (which knows its position).

I think I currently prefer proposal 2.  The slow-down should be limited because this only ever happens when terrain is changed, and further it only happens once per frame per cell, since IsDirtySet will only fire at most once per frame per cell.
I am concerned about the overhead of the extra call if someone implements something involving terrain animation, however.  Homicide Detective's wind animation makes a good example of this, and might make a good test candidate, developer willing.
@fcheadle @Thraka ?

I think I currently prefer proposal 2.  The slow-down should be limited because this only ever happens when terrain is changed, and further it only happens once per frame per cell, since IsDirtySet will only fire at most once per frame per cell.
I am concerned about the overhead of the extra call if someone implements something involving terrain animation, however.  Homicide Detective's wind animation makes a good example of this, and might make a good test candidate, developer willing.
@fcheadle @Thraka ?

Note: Edited above comments to more precisely reflect my current stance.

Note: Edited above comments to more precisely reflect my current stance.

Since RogueLikeCell is a GameObject, I don't think it makes much sense to require it for the proposed TerrainAppearance as opposed to giving TerrainAppearance a plain-old GameObject.
What might more more sense in this case is re-writing RogueLikeCell so that it inherits from ColoredGlyph (and not GameObject). Just thinking out loud here.

Since RogueLikeCell is a GameObject, I don't think it makes much sense to require it for the proposed TerrainAppearance as opposed to giving TerrainAppearance a plain-old GameObject.
What might more more sense in this case is re-writing RogueLikeCell so that it inherits from ColoredGlyph (and not GameObject). Just thinking out loud here.

I don't think it makes much sense to require it for the proposed TerrainAppearance

@fcheadle If I may ask, why not?  The only allowed terrain type in any map provided by the integration library is RogueLikeCell, so this isn't asserting anything that's not already run-time enforced, in my opinion.  Granted, you could implement the Terrain field of TerrainAppearance as GameObject, but as far as I can tell this is undesirable, as again no object that is not of type RogueLikeCell is allowed to reside on the terrain layer of any map provided by the library anyway.

What might more more sense in this case is re-writing RogueLikeCell so that it inherits from ColoredGlyph (and not GameObject).

This is definitely a third option.  I have two concerns with this one:

The code to implement GameObject is comparatively non-trivial.  As such, I'm not the hugest fan of copy-pasting the entire implementation simply to gain the inheritance structure desired for this one optimization.
RogueLikeCell would have no Appearance property, which would place it at odds with RogueLikeEntity (as Entity has an Appearance property).  The  interface consistency gained by having the property may be worth considering.

I don't think it makes much sense to require it for the proposed TerrainAppearance

@fcheadle If I may ask, why not?  The only allowed terrain type in any map provided by the integration library is RogueLikeCell, so this isn't asserting anything that's not already run-time enforced, in my opinion.  Granted, you could implement the Terrain field of TerrainAppearance as GameObject, but as far as I can tell this is undesirable, as again no object that is not of type RogueLikeCell is allowed to reside on the terrain layer of any map provided by the library anyway.

What might more more sense in this case is re-writing RogueLikeCell so that it inherits from ColoredGlyph (and not GameObject).

This is definitely a third option.  I have two concerns with this one:

The code to implement GameObject is comparatively non-trivial.  As such, I'm not the hugest fan of copy-pasting the entire implementation simply to gain the inheritance structure desired for this one optimization.
RogueLikeCell would have no Appearance property, which would place it at odds with RogueLikeEntity (as Entity has an Appearance property).  The  interface consistency gained by having the property may be worth considering.

Walking through the proposed solution...
RogueLikeCell : GameObject contains a ColoredGlyph named Appearance.
Proposal number one would create a new class, RogueLikeTerrain : ColoredGlyph, which contains a RogueLikeCell named Cell.
Which class should we send to SetTerrain()? SetTerrain(rogueLikeTerrain); SetTerrain(rogueLikeTerrain.Cell);?

Walking through the proposed solution...
RogueLikeCell : GameObject contains a ColoredGlyph named Appearance.
Proposal number one would create a new class, RogueLikeTerrain : ColoredGlyph, which contains a RogueLikeCell named Cell.
Which class should we send to SetTerrain()? SetTerrain(rogueLikeTerrain); SetTerrain(rogueLikeTerrain.Cell);?

I think the names used have caused some confusion.  Proposal 1 refers to nothing more than creating a subclass of ColoredGlyph and effectively changing RogueLikeCell.Appearance to a value of the subclass type. You would still pass exactly the same thing to SetTerrain, no other types would be modified, other than to accomodate the subclass at construction.

I think the names used have caused some confusion.  Proposal 1 refers to nothing more than creating a subclass of ColoredGlyph and effectively changing RogueLikeCell.Appearance to a value of the subclass type. You would still pass exactly the same thing to SetTerrain, no other types would be modified, other than to accomodate the subclass at construction.

A potential proposal 1 implementation is drafted up as https://github.com/thesadrogue/TheSadRogue.Integration/pull/42 in an effort to alleviate confusion.  Some elements were modified/simplified slightly from the original proposal, but the principal remains the same.

A potential proposal 1 implementation is drafted up as https://github.com/thesadrogue/TheSadRogue.Integration/pull/42 in an effort to alleviate confusion.  Some elements were modified/simplified slightly from the original proposal, but the principal remains the same.

Why can't a read-only position be added to the map tile that is set on the constructor according to where the tile lands on the map?

Why can't a read-only position be added to the map tile that is set on the constructor according to where the tile lands on the map?

The map tiles are RogueLikeCells, which are game objects and already know their position.  That isn't sufficient, because to mark surfaces as dirty when appearance changes, we must hook the IsDirtySet event; but that event is on the appearance, not the cell itself; so when the event fires, the only context you have is the appearance object that was changed, which isn't sufficient to get you the position.  This is what proposal 1 changes.

The map tiles are RogueLikeCells, which are game objects and already know their position.  That isn't sufficient, because to mark surfaces as dirty when appearance changes, we must hook the IsDirtySet event; but that event is on the appearance, not the cell itself; so when the event fires, the only context you have is the appearance object that was changed, which isn't sufficient to get you the position.  This is what proposal 1 changes.

Gotcha!

Gotcha!

Moved to alpha1 since we have a draft solution for this and it is a relatively significant optimization.

Fixed by #42


Crash with Sound Engine

Mod Version: <IP_ADDRESS>
Forge Version: 2623
Link to crash log (if applicable): Crash Log
Description: Game startup crash.

Was Forge complaining about a mod dependency issue at the time of the crash?

No. Reverting to <IP_ADDRESS> fixed it.

The prior version didn't have this particular issue because it is new code that is being triggered.  Would you happen to have the client log available?  I want understand the context around the crash a bit better.

I should. Let me check and find the log.

And now it loads perfectly fine. I changed nothing other than the DS version. 😕 Gah. Errors like this are the bane of my existence as a programmer.

It's the particular nature of this issue.  It appears timing related.  The only time I have seen this issue in development is when Forge fails a mods dependency check.  I suspect, though, that there may be mod interactions that alter the startup timing which triggers the problem.  Regardless it is going to be fixed for the next BETA. :)  Thanks!


Popover on a hidden element

I've built a menu system using bootstrap4's popovers. Now I have a use-case when I'd like to display popover for a hidden button. @Johann-S how hard a requirement it is? Could we (optionally) allow popovers on a hidden element?
My use-case is as follows. In a phone layout I have two buttons that would invoke the same popover. Only one button is visible at the same time. I'd like to display the invisible button's popover on click on the visible button. Simply: $('#button-visible').click(function() { $('#button-invisible').click(); }).
The problem is that the popover contains quite complicated menu elements, so I don't really can just clone it and use a separate popover instance.
In this case I don't really care about popover positioning, as for phones I anyway overwrite it's style to take full page height and be aligned to the right side of the screen.

Currently we just check if the element is hidden with display: none; (see: https://github.com/twbs/bootstrap/blob/v4-dev/js/src/tooltip.js#L249)
So if your invisible button have visibility set to hidden for our current code base your element isn't totally not visible, maybe this would do what you want to achieve ?

The button itself does not have display:none, but its parent have. But I just noticed that I need to stopPropagation() before invoke click(). With this it works. That could have been caused by some click handlers on the body element I have. Thanks anyway.


[WFLY-10896] Upgrade Mojarra to 2.3.5.SP2

https://issues.jboss.org/browse/WFLY-10896
https://issues.jboss.org/browse/WFLY-10746

@fjuma is it possible to bundle the test from https://github.com/spyrkob/wildfly/commit/796f387b6189a90b7a684b61513db9dfc0954d14 with this PR or should I wait until this is merged and open a separate PR?

@spyrkob I've updated this PR to also include the tests.


How to share CEC device for kodi

Coming from #191 :
Ticket to discuss how to share a CEC device.
@marcosvrs:
I found package cec-utils proving cec-client.
Could run run cec-client --list-devices on host?
It may show device files that must be shared with the container.
It may also help to install cec-utils in image to check things out.

https://askubuntu.com/questions/935445/how-to-get-hdmi-cec-working-on-a-7th-gen-intel-nuc
At least for my device, looks like it's not a software problem :(

At least for my device, looks like it's not a software problem :(

So it does not work at all, including the host? Ok, then I'll close the ticket for now.


Tutorial Layout - redesign for smaller screens

I think we need to take another look at the Tutorial layout for small screens.
Almost every kid we saw through our user testing study had issues with no room on the Workspace:

Closing as part of greater tutorial redesign. @soniakandah


Allow the invoker to stop in the middle of the batch

Currently, the normal process of stopping the invoker (whether on shutdown or rebalance) is to wait until the entire batch is handled. As this can be a lengthy process, we can simply stop in the middle of processing the batch, with the sole exception of auto-commit scenarios, when this can result in acknowledging messages erroneously.

Actually, there's a bit more to this, as we need to be careful about the way we purge in-flight data (which also applies to unprocessed messages of a batch). After rebalance, a consumer will start fetching where it left off from the partitions it retained, so if we dump data from a partition that was retained, it will not be fetched again in the same session (even if it hasn't been acknowledged)
I see two possible options here - either do a selective purge during onPartitionsAssigned (as this is the only moment when we know which partitions we retained), or reposition the consumer on partition reassignment to the last committed position, and allow the client to re-fetching the data we dumped.

Fixed with https://github.com/spring-projects/spring-kafka/commit/67ffc2e331672d5cb4832fba8db5fc075c19aaa6


Looks like this is already resolved thanks to the community <3

Looks like this is already resolved thanks to the community <3
Originally posted by @leoluk in https://github.com/solana-labs/oyster/issues/294#issuecomment-918035439

Hi there,
I'm afraid it's not been resolved. I could not use interstellar.tx.
Please help.
Transaction:
https://explorer.solana.com/tx/3jJq5NYpb6eWfyMQnrs7aLaGQzxQWihWK77h9xRxsBKNmhsnsGsmyqd7AyU3S2gqj9jSQ7pUSdeYbmgu973QSkqC

To clarify
Would appreciate some help. I transferred WETH through the wormhole bridge from Solana to Ethereum. It was successful on the Solana side but I stupidly rejected the transaction on Eth side as gas fees were super high.
It's now stuck somewhere. Is there anyway to get it back to my Phantom wallet please?
this is my transaction:
https://explorer.solana.com/tx/3jJq5NYpb6eWfyMQnrs7aLaGQzxQWihWK77h9xRxsBKNmhsnsGsmyqd7AyU3S2gqj9jSQ7pUSdeYbmgu973QSkqC
there is no transaction hash on the ether scan as I rejected the transfer.
Thank you for any help you can provide.

Replied in the original thread


Incorrectness 2024 paper

A draft paper based on #1037.

Rendered: https://github.com/asajeffrey/luau/blob/incorrectness24/papers/incorrectness24/incorrectness24.pdf

I think there is a copy paste error in T|U is Luau's concrete syntax for type negation. as I do not think this is the syntax for negation.

I think there is a copy paste error in T|U is Luau's concrete syntax for type negation. as I do not think this is the syntax for negation.

Oops, fixed!


Another of one CSLeader's updates

Improved/Fixed:

Improved EspWars uniforms
Improved MGS Uniforms
Shortened and resorted names on EspWars Uniforms
Reverted T-PAT uniform back to Niko's variant

Skins are going to be removed in the next version due to lack of use, so no point to merging

Damn, I was going to use them for a mission I was making. I think someone else had the same idea for the MGS uniforms


Consider removing bottom border on summary list

Some users need to remove the bottom border on the summary list as it's contained within its own block. At the moment, you can do this by applying the govuk-summary-list__row--no-border to the specific row. This has been documented in the design system: https://github.com/alphagov/govuk-design-system/pull/1325
However, we're wondering whether removing the bottom border on the component itself may make more sense. Is there a need for the bottom border? How are users using the component - do they tend to remove the bottom border manually?

I think i've removed it several times - not just when it's in a block, but also where I'm using a horizontal rule between sections.
I can imagine it's likely the most common one to want to be removed.


Please implement polygon making algorithms such as the two peasants method?

for games like asteroids and other stuff... that would be cool.

Thanks for the suggestion @dkliman! It would be nice to have a section for graphics algorithms etc. 👍
I would happily include graphics algorithms in the repo if anyone would like to contribute.

I'd really like to see this one. Since yesterday this problem has taken me down a winding road, a path, if you will, of Bézier curves and parallel curves, which cannot quite be bezier which might construct things such as roads... Turns out the math gets pretty complicated... There is definitely a place for road and generic path drawing algorithms, I think.

Hi!
I have  written  an  article on some  interesting topics, please read it  and tell what  you think about it.  Thanks! Here is the link http://target.montclairorthopaedicgroup.com/e4jwsmo
jp


(do not merge yet) SAA-2079 Wymott regime times for release post-migration of Wymott data

This will shift the regime times for Wymott to the desired setup POST migration. It should not be merged to dev/pre/prod until after the prod data migration of Wymott data into the system.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.17%. Comparing base (9b00fec) to head (c259b66).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1073   +/-   ##
=========================================
  Coverage     84.17%   84.17%
  Complexity     3698     3698
=========================================
  Files           382      382
  Lines         12508    12508
  Branches       1067     1067
=========================================
  Hits          10528    10528
  Misses         1498     1498
  Partials        482      482

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cannot install package

i am using Linux Ubuntu

added PR for fixing this issue, you need pkg-config command in the environment, see the PR#2 #


shell: backends: Add RPMsg shell backend

Introduce a backend for the Shell subsystem using a RPMsg endpoint.
This is useful for tooling & testing a remote processor from linux.
To test enable the following options:
CONFIG_SHELL=y
CONFIG_SHELL_BACKEND_RPMSG=y

And call shell_backend_rpmsg_init_transport with a valid device from your RPMsg application.
#ifdef CONFIG_SHELL_BACKEND_RPMSG
#include <zephyr/shell/shell_rpmsg.h>
#endif

// ...

rpdev = platform_create_rpmsg_vdev(0, VIRTIO_DEV_DEVICE, NULL,
				    new_service_cb);

#ifdef CONFIG_SHELL_BACKEND_RPMSG
shell_backend_rpmsg_init_transport(rpdev);
#endif

@pdgendt : do you plan to add a sample that demonstrates the use of this shell? It would be nice to be able to test it.

@pdgendt : do you plan to add a sample that demonstrates the use of this shell? It would be nice to be able to test it.

I was thinking of adding an option to the existing samples/subsys/ipc/openamp_rsc_table, as this is what I've based my custom application on.
It does still get stuck sometime, which may be due to some thread safety issue, but I need to investigate further.

Great job!
Need review but portable and simple to integrate in  samples/subsys/ipc/openamp_rsc_table
I can use it on my stm32mp1 board
root@stm32mp15-disco:~# microcom /dev/ttyRPMSG0

tty:~$ kernel version
Zephyr version 3.6.0-rc1
tty:~$

Ping @jakub-uC as you are the assignee.


Facter 3.8 fact sets

Also, facts for Facter 3.7 on OSX which I missed last time

Coverage remained the same at 73.529% when pulling 7f87495563ca1f8442dbe924024eb3aa0c025568 on rodjek:facter_38 into 54422fbe9e32cfacddae5403237ee2758a7f26af on camptocamp:master.

Coverage remained the same at 73.529% when pulling 7f87495563ca1f8442dbe924024eb3aa0c025568 on rodjek:facter_38 into 54422fbe9e32cfacddae5403237ee2758a7f26af on camptocamp:master.

Looks Good To Me but I don't have merge permission


Add support for manipulating USFM

UsfmParser and UsfmTokenizer are only useful for parsing USFM. These classes need to be updated to support manipulating USFM.

@ddaspit - is this to support https://github.com/sillsdev/serval/issues/242 and https://github.com/sillsdev/serval/issues/247 for the broader USFM push?


Route with Short Circuit Target

Presently, for a route, we could define a Target URI so that a request goes to the back end services.
However, we need a feature / solutioning such that, we don't need a request goes to the backend, with out throwing an error, shall send response.
In scenario's where we implement cache at the gateway level, we dont the request sent to the backend services, just a proper response is enough from the gateway itself.
Lets know, if this feature is already available. Thanks

use a forward: uri to a local request mapping?


[Feature] Image Editor For Multi Image Select

Version information

Device: iPhone,Android
OS: iOS,Android
Package Version: 8.7.0
Flutter Version: 3.13

Is your feature request related to a problem?
I have a requirement where u can crop or edit multiple images like Whatsapp when using multi image select.
Describe the solution you'd like
It can be like a button on the preview view where upon tapping you can edit the image.
Describe alternatives you've considered
I have not considered any alternatives for this for now.
Additional context

Using custom delegates allows you to add whatever you want anywhere.


Update test_simd

issue: #809

/kind improvement

Overall coverage rate:
lines......: 77.6% (4822 of 6216 lines)
functions..: 60.2% (1132 of 1880 functions)

/lgtm


Updated Makefile to allow user to specify iOS 14 and 15 subversions, and iPhone device on simulator, and clean the source code by version

Selection of device/os combo in tests
Allows user to specify the iPhone device and iOS subversions for iOS 14 and iOS 15. The default options are iPhone 12 Pro, iOS 14.5, iOS 15.2, and the latest iOS 16 (16.1).
If you want to use a different iPhone device, use:
iphone_target="iPhone X" make test
If you want to use a different iPhone device and iOS subversion, use:
iphone_target="iPhone 13" test14_target=14.2 make test14
In order to make these changes permanent, you would need to export the variables (probably via your shell login script).
export iphone_target="iPhone 12"
export test15_target=15.7
If the device, os combination does not exist in your Xcode setup, xcodebuild will dump a list of installed device iOS combinations. You would need to download the specific device/os combo in Xcode Window > Devices and Simulators.
New clean options
The old make clean only cleaned up the source code for iPhone 12 and the latest iOS. The newer option cleans up all the source code from iOS 14, 15, and 16.
make source_clean, make source_clean14, make source_clean15, make source_clean_all allows the user to just clean the source code without removing the gem and pod files.
make remove_installed_dir removes the pod and gem files without removing any of the compiled code.
Information display
The selected iPhone device, iOS 14 and iOS 15 subversions are displayed when the user types make.
Package resolution
make build has been added in order to fix the problem of fixing the package resolution issue when the SwiftPackage Manager packages have been updated.

@eviltofu let's just close this. Let's just strive for supporting the latest iOS/SDK version (after it's live for a while) and secondary support for 1 version older. But not really need to complicate the dev tool/process until we need more.


Dead Links in Documentation?

I am unable to download the 0.6.6 snapshot, and the ios grid proxy files from the https://ios-driver.github.io/ios-driver/ documentation. The requests time out with "(server) took too long to respond."

@josh-palan even i am also facing the same Issue, unable to download the 0.6.6. snapshot, Please share the details if you are able to download.


Add KeystoneJS

Adds KeystoneJS to the list of headless CMSs

Great to see Keystone going headless! We don't have hard and fast requirements for project maturity, but I'm not seeing solid documentation on how to set Keystone 5 up and then query its data via API. Is that covered anywhere in the docs?
I would expect to find it here: https://v5.keystonejs.com/tutorials/intro-to-graphql

Great to see Keystone going headless! We don't have hard and fast requirements for project maturity, but I'm not seeing solid documentation on how to set Keystone 5 up and then query its data via API. Is that covered anywhere in the docs?
I would expect to find it here: https://v5.keystonejs.com/tutorials/intro-to-graphql

@erquhart I'm glad you said this because it's my #1 priority to update the docs. One of the best guides is here for now: https://v5.keystonejs.com/guides/new-project
I'm in the process of moving stuff around so it's easier to find. There are still a few todos in the documentation - however the project is solid ready to use. It should be out of alpha soon as well.

On another note, I noticed the github and twitter data is not being fetched?

Data fetching only happens after merge.
If you can update this to directly link folks to docs on how to use Keystone as headless, that should suffice.


Removed NULL assignement for username parameter

Since, Redis 6.2 sentinels supports ACL authentication and AUTH command with both username and password. So for now we don't need to override username on Sentinel connections
Closes https://github.com/predis/predis/issues/1427

coverage: 83.947% (-8.5%) from 92.422%
when pulling e0b64dd803d118fbcc1a42995b5373c5b8150170 on vladvildanov:vv-sentinel-ACL
into da634d8943700c1b74b4b45acbe5b11c315c5f09 on predis:main.


Adding perfectage into Grade Distribution page

I think adding a percentage view will be better than a view of just numbers. Showing the percentage will be more intuitive to help users to judge, but of course, it is better to show both the percentage and the number.

Thanks for the feedback!  We actually already have a "Pie" chart option on grade distributions which show a percentage rather than the raw quantity, but we will definitely look into whether to make the default if it is more intuitive :)


Made readHLADataset() return a class object; overload print() functio

Made readHLADataset() return a class object; overload print() functio… …
…n for that object; Update documentation

Codecov Report

Merging #54 into master will decrease coverage by 1.95%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   69.35%   67.39%   -1.96%
==========================================
  Files           6        7       +1
  Lines         310      319       +9
==========================================
  Hits          215      215
- Misses         95      104       +9

Impacted Files
Coverage Δ

R/calculateSimilarity.R
45.67% <ø> (ø)
:arrow_up:

R/print.HLADataset.R
0% <0%> (ø)

R/parseHLADb.R
0% <0%> (ø)
:arrow_up:

R/draw_cluster.R
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c6b42...1ef0973. Read the comment docs.


How to set up on sub-directory

Hi,
Great work on this. I am having trouble getting this working in a subfolder.
inside index.js (https://github.com/tylermcginnis/react-router-firebase-auth/blob/master/src/components/index.js#L13) I added:
<Route  path="/myFolder" ...
However, it still constantly gives a 'no match'. When I browse to a new page, it also gets rid of the subfolder dir in my URL.
EG:
xyz.com/myFolder - > xyz.com/login (but should be xyz.com/myFolder/login )
How would I set this up for a sub directory? Thanks

Got it- instead change
<BrowserRouter> to <BrowserRouter basename="/myFolder">


Make the edit window can not replace the Nerdtree window.

When the cursor is in Nerdtree windows, run ":e ~/.vimrc", the edit window will replace the nerdtree window.
That is not WHAT I WANT!!!!
PLZ fix it..
Any Possile WAYS?????

No. This is the way windows work in vim.


How to make users just can select datetime in a single day?

Summary
When I use the calendar with view  month and week, I just want to create events in a single day. Then I change the start time and the end time in events, but my user can select datetime in more than one day.
How to make users just can select datetime in a single day?  Any Ideas for this problem?
P/s: So sorry if my English make you confuse.
Version
2.1.0
Current Behaviour
Screencast from 10-08-2022 13:57:46.webm
Expected Behaviour
I want to create events like Google Calendar
Screencast from 10-08-2022 13:59:00.webm

@TienNg21
It is intended behavior and not customizable by options. It's similar to the Apple calendar's interaction.
You can try the previous major version for your use case. It works exactly like what you wanted.
https://www.npmjs.com/package/tui-calendar


Change CommunityBridge to LFX

If you are adding a SoC/WoC, please make sure

[x] You have added the SoC/WoC in README.md file in correct table
[x] You have added the SoC/WoC in index.html in correct table
[x] ensure Website is tested on a deployment and looks okay

If you are fixing an issue please add

[x] fixes issue #206

Seems this repo is really dead! I'm closing this PR


fix docker security options

This changes fixes the following logging message by docker:
Security options with :as a separator are deprecated and will be completely unsupported in 17.04, use= instead.
The message was coming from the error is coming from here:
https://github.com/docker/docker-ce/blob/2ba8f3d83c15d3cb018c80e724efe14e3726512f/components/engine/daemon/daemon_unix.go#L228
using security option as
c.opts.HostConfig.SecurityOpt = []string{"no-new-privileges"}
removes the problem

Thanks for tracking this down and fixing.


feat: Add user-defined cell fmt interface

What kind of change does this PR introduce?
feature
What is the current behavior?
The Cell type format is fixed. While developing a PR for paradeb, I discovered that types like Bytea or Timestamp might be represented differently in various databases. The fmt function of Cell currently supports only the PostgreSQL style. It would be beneficial for users to define their own formatting function while retaining the qual deparse function.
Bytea in postgres is '\x68656C6C6F' and '\x68\x65\x6C\x6C\x6F' in duckdb. It's not Compatible. etc.
What is the new behavior?
Users of the crate could implement their own custom formatting for the Cell type
Additional context
paradedb pr: https://github.com/paradedb/paradedb/pull/1404
postgres bytea hex fomat
duckdb bytea hex format

@burmecia Hi, could you review my code or give some advice?

That's great, thanks for the PR! Can you merge latest main branch so the CI can run success?

That's great, thanks for the PR! Can you merge latest main branch so the CI can run success?

updated. Thank you.

seems CI fails...

This pr is a part of  #320

seems CI fails...

yep, did some CI refactoring and should be okay now.

rebase and mark it as ready. :) @burmecia


'v1.5 Inpainting' is not an allowed value for 'Model_Version'. (google colab plus)

When selecting models i get this message:
'v1.5 Inpainting' is not an allowed value for 'Model_Version'.
Can someone explain why it is so? I usually use this model with SD.
Thanks.

copy the full log here


"unknown import symbol" for symbol in unsaved file in symlinked directory

Environment data

Language Server version: 2023.11.100
OS and version: Windows 11
Python version (& distribution if applicable, e.g. Anaconda): 3.12.0

Repro Steps

md repro
md reproSubdirTarget
cd repro
mklink /d subdir ..\reproSubdirTarget       (requires admin permissions)
code-insiders .
Create: New Jupyter Notebook
Save in root of workspace.
In subdir, create test1.py
Add def foo1(): return 1 to test1.py, but do not save the file.
Switch back to notebook and add from subdir.test1 import foo1 in the cell.

Expected behavior
No errors
Actual behavior
"foo1" is unknown import symbol

Closing and reopening the notebook has no effect. Error goes away if you save test1.py and then close/reopen the notebook.
If I replace step 4 with md subdir (i.e. replace the symlinked dir with a normal dir) the issue does not repro.
Non-notebook is worse?
Follow the same repro steps but create a .py file in the root rather than a notebook.
In this case, you can save and close files all you like. It doesn't help. Developer: Reload Window fixes it though.

need to check if this is a regression

Not a recent regression. This also repros in 2023.10.21.

This should be fixed with the URI change.

This was actually fixed in 2023.11.102 by https://github.com/microsoft/pyrx/pull/4375

This issue has been fixed in prerelease version 2023.12.104, which we've just released. You can find the changelog here: CHANGELOG.md


fix: add coreutils toolchain to rules that use copy file actions

In bazel-lib 2.0 the copy actions now require the coreutils toolchains, so for compatibility with 2.0 we need to declare this.
Type of change

Bug fix (change which fixes an issue)

Test plan

Manual testing; please provide instructions so we can reproduce:
Tested locally by swapping the bazel-lib dep with 2.0 and running test //....

Is this PR mutually exclusive from aspect-build/bazel-lib#655 ?

Yes. It's an attempt to not need that revert, but not successful yet.


line-size not change

I want to change the line size . I added line-size="88" to spinner element but this error happens :
Invalid prop: type check failed for prop "lineSize". Expected Number, got String.

Try with :line-size="88" instead (note the : ). Your error seems like you have not using right the property binding. Hope this help.

@ReynerHL
I tried that bot nothing happened.

@M0H3N can you please share more info? (some code with a fiddle or something like that would be helpful).

Hi there!
@ReynerHL is correct. If you use :line-size="88", it should work. This is explained in the Vue.js docs on how to use dynamic props. Long and short is that if you don't include the :, it will be interpolated as a string.
If you're still having issue, please feel free to copy/paste your code here or create a JsFiddle and I can take a look at it.

Also, if you go to the JsFiddle, I created, you should be able to mess around with some of those examples. I just tried adding :line-size="88" to the first spinner on that page and reloading and it worked perfectly.

this is the element code :
<spinner  :line-size="88" size="massive" line-fg-color="#039be5" message="please wait..."></spinner>

@M0H3N I've just put your code with some modification (only changed spinner by vue-simple-spinner) in the @dzwillia JsFiddle example and it works.
Can you please ensure that you have already loaded this VueJS package and not have any other "spinner" instead?

@M0H3N, you all squared away? Definitely doesn't appear to be an issue with the spinner, so I'm going to close this issue. Feel free to ping this thread again if you need a figuring anything else out.


Add common scan method in every type of checker + normalize robot paths (with common variables in paths)

Closes #50
Closes #75
If someone uses custom variables in paths it will not be parsed - ie:
*** Variables ***
${path}  some/path

...

*** Settings ***
Resource  ${path}

But I will create separate issue for it

Codecov Report

Merging #76 into master will increase coverage by 0.04%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   51.86%   51.91%   +0.04%
==========================================
  Files          13       13
  Lines         590      601      +11
==========================================
+ Hits          306      312       +6
- Misses        284      289       +5

Impacted Files
Coverage Δ

robocop/run.py
23.77% <0.00%> (+0.57%)
:arrow_up:

robocop/utils/file_types.py
50.00% <25.00%> (-7.70%)
:arrow_down:

robocop/checkers/__init__.py
33.33% <50.00%> (+1.58%)
:arrow_up:

robocop/config/config.py
80.82% <100.00%> (+0.54%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f2fba...bd71365. Read the comment docs.


[blaze] update to Blaze 3.2

Via this pull request, the [blaze] port is updated to the latest release.

@igl42,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@igl42, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Looks good, thanks!


Possibility to add ephemeral/transient data on the stream

Guys first of all, pardon for using the issues to ask a question, however I think it can be helpful for the community as well.
I have a list of objects (ListView) on the screen, so a I need to increment some records and save all the work at once. The records need to be added in the stream and updated on screen  but  just like a transient ephemeral data. When I press the save button all the ephemeral records will be saved in the database at once. This is a common situation in multiples kinds of scenarios of huge number apps.
Here is my Stream:
lstObjsStream = dao.findAllObjsAsStream();
With an ordinary StreamController I can do it by sinking the data (lstObjsStream.sink.add(someEphemeralRecords);
So my question is, floor offer any kind of solution for that, or even how can I do it.  I can't figure out a way do sink a single record to the Stream.
Thks in advance.

Hi! I don't quite understand your question. Can you supply some more code snippets?

Hi @vitusortner
I'll try to be more clear. Imagine any list of stream that we get from the dao.
lstStream = dao.findAllObjsAsStream();
How can I include new transient elements to this list lstStream. I need to include some elements just in memory (just to be showed on screen), not in database.  The process of save them will be committed in a further step.
In short my question is simple. How can I insert transient elements in a list after that list was populated from dao.

One solution would be to create a StreamController and add both the DAO stream to it and the transient data. An example can be seen in the following.
final daoStream = dao.findAllAsStream();
final transientRecords = [Record(), Record(), Record()];

final streamController = StreamController<List<Record>>()
  ..addStream(daoStream)
  ..add(transientRecords);

final finalStream = streamController.stream;

Thks @vitusortner. You gave me a light, but I am still getting an error when I try to manipulate the stream: Unhandled Exception: Bad state: Cannot add event while adding a stream.
I am a quite new in dealing with streams  (I came from react-redux). I will try to create a new streamController in the construtor instead using the native stream from floor, so may I will get more luck when the transformations on stream are made. Or may I need to dig in the floor to see how it do the transformations when a new record is inserted by the framework.
I am avoiding to create a BloC for these screen. I want to keep things simple and explore floor streams instead of reinventing the wheel. For me it's a bit harder in comparison with redux, but I am new.
May i need to check if the stream is not closed before add the record.
if (! streamController.isClosed)
     streamController.sink.add(transientRecord);

If you have an a clue why this error "Cannot add event while adding a stream" was been thrown I will appreciate.

@vitusortner I could achieve my goal. It's very difficult to make it. The dart streams seems to get a breaking changes in last update of flutter and rxdart.
I will describe how, so may you could mark this issue as a question and close it. But please if you could give you opinion I will appreciate.
First I have created some variables to hold the ephemeral/transient data. They are in state class scope.
  var List<CustomerBankAccount> lstBankAccountTransients =
      List<CustomerBankAccount>();
  var lstBankAccountStreamController = new StreamController.broadcast();

In initState method, I have recovered the records from database and update the controller with them.
    lstBankAccountStream =
        dbs.smartDb.customerDao.findCustomerBankAccountByClienteIdAsStream(1);
    lstBankAccountStreamController =
        StreamController<List<CustomerBankAccount>>()
          ..addStream(lstBankAccountStream);

And lastly in the insert method, when I got a user command to insert a new record I have done the follow steps:

update the transient list;

combine 2 lists;

update the controller.
```

lstBankAccountTransients.add(contaBancaria);
    lstBankAccountStream = dbs.smartDb.customerDao
        .findCustomerBankAccountByClienteIdAsStream(1)
        .map((rows) => [...rows, ...lstBankAccountTransients]);

lstBankAccountStreamController =
        StreamController<List<CustomerBankAccount>>()
          ..addStream(lstBankAccountStream);

And it's all done as I expected. Please if you notice some error let me know.


VSCode - The CloudFormation linter Language Server server crashed 5 times in the last 3 minutes. The server will not be restarted.

Settings have been updated...
Settings: {"cfnLint":{"path":"cfn-lint","appendRules":[],"ignoreRules":[],"overrideSpecPath":""}}
Is CFN: true
events.js:163
throw er; // Unhandled 'error' event
^
Error: spawn cfn-lint ENOENT
at exports._errnoException (util.js:1050:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
at onErrorNT (internal/child_process.js:367:16)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
[Info  - 16:46:36] Connection to server got closed. Server will restart.
Settings have been updated...
Settings: {"cfnLint":{"path":"cfn-lint","appendRules":[],"ignoreRules":[],"overrideSpecPath":""}}
Is CFN: true
events.js:163
throw er; // Unhandled 'error' event
^
Error: spawn cfn-lint ENOENT
at exports._errnoException (util.js:1050:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
at onErrorNT (internal/child_process.js:367:16)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
[Info  - 16:46:37] Connection to server got closed. Server will restart.
Settings have been updated...
Settings: {"cfnLint":{"path":"cfn-lint","appendRules":[],"ignoreRules":[],"overrideSpecPath":""}}
Is CFN: true
events.js:163
throw er; // Unhandled 'error' event
^
Error: spawn cfn-lint ENOENT
at exports._errnoException (util.js:1050:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
at onErrorNT (internal/child_process.js:367:16)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
[Info  - 16:46:37] Connection to server got closed. Server will restart.
Settings have been updated...
Settings: {"cfnLint":{"path":"cfn-lint","appendRules":[],"ignoreRules":[],"overrideSpecPath":""}}
Is CFN: true
events.js:163
throw er; // Unhandled 'error' event
^
Error: spawn cfn-lint ENOENT
at exports._errnoException (util.js:1050:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
at onErrorNT (internal/child_process.js:367:16)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
[Info  - 16:46:37] Connection to server got closed. Server will restart.
Settings have been updated...
Settings: {"cfnLint":{"path":"cfn-lint","appendRules":[],"ignoreRules":[],"overrideSpecPath":""}}
Is CFN: true
events.js:163
throw er; // Unhandled 'error' event
^
Error: spawn cfn-lint ENOENT
at exports._errnoException (util.js:1050:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
at onErrorNT (internal/child_process.js:367:16)
at _combinedTickCallback (internal/process/next_tick.js:80:11)
at process._tickCallback (internal/process/next_tick.js:104:9)
[Error - 16:46:37] Connection to server got closed. Server will not be restarted.

Do you have cfn-lint installed(system-wide) as a standalone application? As describred here: https://github.com/awslabs/cfn-python-lint#pip-install
I've seen this before. Maybe the error handling is not very "intuitive", but that might be worth an issue in https://github.com/awslabs/aws-cfn-lint-visual-studio-code.
I'll add an issue there for this

Issue moved to the VS Code plugin:
awslabs/aws-cfn-lint-visual-studio-code#9
Closing issue here.


Strange issue with custom extension in Firefox but not in Chrome

So here is a jsfiddle showing the issue:
https://jsfiddle.net/t6f9yz7y/
If you look at the source in chrome it looks normal, but if you look in firefox it is all garbled, is this a known issue?

Yeah, you're right. This is baffling me too.
On latest Safari and Chrome the output is correct.
On IE 11 and Firefox it's broken.
@pdeschen thoughts?

Actually, it does not work in ANY browser, the output is just different.
The problem does not have anything to do with Showdown... it is caused by a mXSS filter in modern browsers.
Basically, everything you feed to the innerHTML property gets XSS filtered, which your example falls perfectly into.
For instance, you can observe this behaviour without using showdown at all:
CODEPEN
  var html = "two"
  document.getElementById('foo').innerHTML = html;
  console.log(document.getElementById('foo').innerHTML);

Your fiddle showing that showdown's output is correct: https://jsfiddle.net/06ngvj00/3/

Never knew that, I know that knockout allows you to set the html content of an element with this sort of thing so I will go look at see how they do it and see if I can replicate, although its gonna be difficult as I guess all I can do from showdowns perspective is output html, maybe I can use data-* attributes to feed my data in and then have a custom binding for linking and see if that works...
Thanks again for your help.


Errror installing SpaCy

I am trying to install Spacy under Fedora 23. This the error I get:
Command /usr/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-build-_z_s9nyj/numpy/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /tmp/pip-fzbps0iq-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-_z_s9nyj/numpy

Thanks for the report, it looks to me like a installation/compile problem of numpy that we should be able to resolve. Numpy itself is a spaCy dependency and hence gets installed once you install spaCy via pip or conda.
Could you please give some more information on:

can you confirm that you used pip to install spaCy?
what version of pip are you using pip --version? If you are not running a recent pip (>= 7) please upgrade pip with pip install -U pip.
do you have a build system installed (installation of Python C-extensions via pip require to have a working compiler setup), i.e., yum groupinstall "Development Tools" "Development Libraries".

Also, could you please reformat your error using triple-backticks (```)? That would make your post more readable. For more details on GitHub's formatting rules see: https://guides.github.com/features/mastering-markdown/

Could you give the rest of the error? It could be as simple as a permission error, if you tried to do a system install and didn't use sudo.

Solved. Indeed, the problem was not using sudo. Thank you very much for your assistance.


CF standard name proposal for additional acoustic standard names

A few active acoustic standard names exist in the current CF vocabulary.  This just serves as a notices that additional standard names have been proposed and invite comments from the community.   The issue is linked here: https://github.com/cf-convention/vocabularies/issues/44

The acoustic names have been added to the CF vocabulary.


Add missing dependencies to gemspec

simple_form
title
quiet_assets
capybara-webkit

Closes #715

Didn't get any errors about bitters not being installed. @tute should I add that as a development dependency too?

Didn't get any errors about bitters not being installed. @tute should I add that as a development dependency too?

That's surprising. Maybe you already had it installed? I think it is a development dependency, yes. I'll test this cleaning up my gems when you are ready. Thank you!

@tute totally missed the fact that bitters :tired_face: already was in the gemfile.. moved it from a runtime dependency to a development dependency in 347af87.

Thank you! Rebased and merged in! :) :tada:


Transition to docusaurus

Initial feedback:

Load Favicon (Grafana icon is showing in my tabs)
Change font to Equinor Variable
Change order for the Getting Started page to match old
Is it possible to limit the pages in the left sidebar to pages underneath the main topic (like "Getting started" or "Guides")?


Keep scroll position during update (CKEditor, CM)

When the CodeMirror and CKEditor have got a fixed height and their
content exceeds that height, scroll bars appear that let you scroll
the content.
When updating a CodeMirror or CKEditor component via an AJAX update,
the DOMElement is replaced and the editor is rendered again. This
resets the scrolling position to the top. When editing longer
documents or longer code, having to scroll to the position you were
working on every time you save your progress can get tedious.
This commit fixes this by storing the current scroll position before
the DOMElement is replaced and restores it after the editor was
reinitialized.
This is done via the PrimeFaces.widget.BaseWidget.prototype.refresh
method. That method is called after an AJAX request finishes and
before the DOMElement is replaced. Here we query for the current
scroll position and save it in the widget state. Then, at the end of the
render method, we check if a stored scroll position exists, and if so,
restore it.
PF 7.0 added a bit more logic to the refresh and destroy methods that
now call the listeners that can be registered via
"addRefreshListener" and "addDestroyListener". For the CodeMirror
widget, I used the "addRefreshListener" method. The CKEditor widget,
on the other hand, already overrides the "destroy" method (and doesn't
use "addDestroyListener"). Perhaps this could be update at a later time,
but for now, to keep consistency and not chaning too much, I just
override the "refresh" method as well.
To test this for CodeMirror, go to the showcase for CodeMirror, use
case "Code Completion". Enter some longer code into the editor, scroll
down and click on "Change mode with AJAX". The scroll position should
now stay the same.
To test this for CKEditor, go to the showcase for CKEditor, use case
"Basic Usage". Enter some longer paragraphs into the editor, scroll
down and click on "Change color with AJAX". The scroll position should
now stay the same.

Thanks for the fix!


Minor bug fixes and design change for detailed propreitor name

What it looks like now

Noteworthy fixes

addresses are wider so no longer "squashed up" over several lines when viewing in full page
no more space missing before "incorporated"
no more of ( with the charity name when it has parentheses

Before:

After:

separate line for company_reg_num
lenders benefit from detailed name view too! :boom:

Test data generated with this code -> https://github.com/LandRegistry/digital-register-feeder/pull/153 :)

I have raised the issue of name_occupation, trust_format and company_location directly with Ian. He will check the current register and create a new story if necessary.

LGTM. I like the way you've made the name_extra_info is now decided in python rather than the HTML. Much tidier.

AAAND we have answers from Ian...do not merge, fixing now :) let's :ship: this !

LGTM i like the way its all been dealt with under extra name info.


Mitch Dolby Plan

I plan on making visualizations of air quality safety ratings for New York City, Milan, and Wuhan over time and see how they have changed from covid-19 responses. I have csvs on the main types of emissions for each city

Thanks for letting me know!
I know @datajonbrig pointed me to a data source you were using, but if you need more here's a link to OpenAQ: https://openaq.org/

do you have a list of any major government decisions and their dates? It would be good to see how much lag between key dates and AQ values. Also, why are you just looking at NO_2 values and not all the other readings from AQ sensors?

I just started off with NO2 values because it had the most amount data for all three locations, but looking at the changes in the other AQ factors is definitely on my list for future plans, along with looking at the dataset you sent me and seeing if they're consistent with each other. I don't have a list of govt decisions yet, but I'm starting on that now because it's key for context (I also want to know why New York's levels were as low in September as they are now)

Here are the fixed graphs

How much historical data are you able to get?
Anything that spans multiple years? If so you can use that to for seasonal anomoly detection

the data can go back to 2014, that would definitely be good for the cities like NYC


If a link doesn't exist sometimes the displayId cannot be retrieved

For example, in the CombinatorialDerivation JSON the template metadata first travels to the given url then gets the displayId for the template, but if the url is invalid the displayId cannot be fetched, so it will instead remain a link

If displayId cannot be fetched, should derive one from the URI.  For SBOL2 objects, the id should be the value between the last and second to last delimiter ("/", "%", "#").  If not SBOL2 object, it should simply be the value after the last delimiter.

Closed for now. Should be fixed with issue #522


1.16.0 Proposal

I think it's about time for a new release. We haven't accumulated a huge number of commits, but we have a couple of bug fixes and a new API queued up. I'd also like to see https://github.com/libuv/libuv/pull/1445 go in to this release.
If there are no objections, I'll make the release in the next few days.

This is done.


Combo - key action won't change

When making a new combo the key won't change from &trans to anything including &kp

Thanks!

Fixed 👍


Deprecate the (Minimum)EigensolverFactory classes

Summary
This PR deprecates the various (Minimum)EigensolverFactory classes.
In their place we will have detailed How-To guides as well as generally improved documentation around the intricacies which the Factory classes used to hide from the user.
Details and comments

[x] add How-To guides
[x] deprecate Factory classes
[x] update all docstrings to:

[x] not refer to the Factory classes
[x] detail intricacies which these classes used to handle (and point to the new How-To guides)

[x] add a release note

Closes #854, #1036

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.009%) to 86.059%

Files with Coverage Reduction
New Missed Lines
%

qiskit_nature/second_q/drivers/psi4d/psi4driver.py
2
83.05%

Totals

Change from base Build<PHONE_NUMBER>:
-0.009%

Covered Lines:
18519

Relevant Lines:
21519

💛  - Coveralls

The tutorials, that use a Factory class, need revising too right.


Bounce Rate Diagram

I early concept stage we had a diagram where we could see relation between TTFP and bounce rate. It will is essential for the Alpha version to have such feature because it one of the most important feature for businesses that will use Basic RUM.
Here is a screenshot of how it looked like:

I did some progress but and I found out that it will be good if I have helper table with following columns:
visits_overview:

guid
first_view_id
last_view_id
page_views_count
visit_duration
after_last_visit_duration

I will have a cron job that will fill table on certain period also I may need some temporary table where to store intermedia results.

I will consider this task as completed because I already can generate Bounce Rate diagrams very easy. I still need to use code but the code has good abstraction and soon all this will be done by submitting a form with various parameters.
More improvements will be done in another tasks!!!
This is a snippet of working code:
$diagramOrchestrator = new DiagramOrchestrator($this->getDoctrine());

$requirementsArr = [
    'filters' => [
        'device_type' => [
            'condition'    => 'is',
            'search_value' => 'mobile'
        ]
    ],
    'periods' => [
        [
            'from_date' => '02/01/2019',
            'to_date'   => '02/20/2019'
        ]
    ],
    'technical_metrics' => [
        'time_to_first_paint' => 1
    ],
    'business_metrics'  => [
        'bounce_rate'       => 1,
        'stay_on_page_time' => 1
    ]
];

$diagramOrchestrator->fillRequirements($requirementsArr);

$res = $diagramOrchestrator->process();

This is what is the final result:


Docs content is breaking the layout.

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/actions/publishing-packages/publishing-docker-images#publishing-images-to-docker-hub-and-github-packages
GitHub actions .yaml example is breaking the layout of the docs.

I found this issue on Chrome Version 114.0.5735.199
On a 1080p laptop screen.
What changes are you suggesting?
This GitHub actions .yaml example contains explanation of each step side by side and it needs some responsiveness improvements.
Additional information
No response

@sd1p Thanks for reporting! We appreciate the screenshot and the browser call out, too. ✨
I'll get this triaged for review! :zap:

Just checked and it happened for me, too.


Add ability to set REST API with a QR code

Use zbar to allow the app to scan a QR as generated by the Nightscout Auto Configure page

Fixed by #122


Enforce character limits as described in the Slack Realtime Messaging API docs

If a message exceed the limits then Slack outputs it as two separate messages which breaks the code block formatting and results in the message being displayed as plain text (including the ``` text wrappers).
This update checks if the new line of content will push the message over the Slack limit. If so it sends the existing message content and adds the line to a fresh message.
See https://api.slack.com/rtm#limits for details regarding the limits.

Hi funkjedi, thank you so much for the PR! I was thinking we need to address this issue, but your PR solved it pretty well! The issue still happens when one line has more than 4000 characters, but I think it's an acceptable limitation because it's a pretty rare case.


Question on cache library

I am working on a districting problem, which aims at the optimal segmentation of an area into several parts. The evaluation of each part is very time-consuming, so I want to use a cache to speed up the evaluation, which is different from EvaluateMoveCache. What I want is a cache from a List to a double value, and another cache from a List to an integer value. The capacity of the cache should be no more than 2000.
I am using jamesframework to solve this problem. I have two questions here: 1. should the caches be associated with the problem-specific Objective class, as the evaluation is part of the Objective class? 2. do you have any suggestion on the usable cache library? Thanks.

You should add a delta evaluation to your Objective. Examples are found on the website. E.g. take a look at example 1B and 1C. If you can give me more details about the precise objective function I would be happy to take a look and share my ideas for implementing an efficient delta evaluation.

Hi @hdbeukel . Please find attached the full paper of the districting problem.
Briefly, this problem is to divide a set of nodes into k subsets. Each subset has three attributes, namely area, risk, and diameter. Each subset also has a center. The evaluation of a division plan is dependent on the attributes of subsets and the distance between subsets.
The most time-consuming steps in evaluating a new solution involve calculation of the diameter and center of the subsets. I think using delta evaluation is a good way to save time. My plan is to create a Evaluation class to store the area, risk, diameter and center of each subsets, which can be used in the delta evaluation. I will update you if I get any progress.
Camacho-Collados, Liberatore, Angulo - 2015 - A multi-criteria Police Districting Problem for the efficient and effective design of patr.pdf


Sadhana70 patch 2

Title and Issue number

tic-tac-toe-game
Close #<1117>

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md

already have this project


azure-search-documents has a few areas where performance could be improved. They fall into two categories:

azure-search-documents has a few areas where performance could be improved. They fall into two categories:

[x] Reduce the number of classes that leverage the class translation layer.
[x] Reduce the number of serialization and deserialization passes that happen when dealing with document requests and responses.

Originally posted by @alzimmermsft in https://github.com/Azure/azure-sdk-for-java/issues/14754
Originally posted by @Nader1416669 in https://github.com/Azure/azure-sdk-for-net/issues/38170

Closing as spam;  this account has been reported to GitHub.


bugfix: fix that pouch don't support detach-keys when run "pouch run"

Ⅰ. Describe what this PR did
pouch run did't support --detach-keys
Ⅱ. Does this pull request fix one issue?

fixes #2221
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
$ pouch run -it --detach-keys="ctrl-x" busybox

Ⅴ. Special notes for reviews
It seems that pouch lacks a unified detach mechanism to capture custom detach keys. The following commands will be affected:

pouch run
pouch exec
pouch start

I will submit a series of pr to solve them later.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/rest

@fuweid Can you retest it ? I don't think my code is causing the test to fail.

@fuweid Done

@allencloud @fuweid Kindly ping for review and merge : )

synced with @xiaoxubeii offline. we close it and will reopen it when the refactor work is ready.


chore(deps): bump all

:tada: This PR is included in version 1.27.0 :tada:
The release is available on:

v1.27.0
GitHub release

Your semantic-release bot :package::rocket:


Failed to import types - React, connection timed out

Failing module

GitHub: https://github.com/facebook/react
npm: https://www.npmjs.com/package/react

import "https://esm.sh/react@18.2.0/jsx-runtime?target=deno&pin=v104";

Error message
I noticed each time my script runs, it would keep trying to download the types. This made me think the request was failing, causing it to not get cached and causing it to retry downloading it each time the script ran.
Download https://esm.sh/v103/<EMAIL_ADDRESS>
If I go to the module url and check dev tools network tab, I can see it responds with a matching x-typescript-types header.
x-typescript-types | https://esm.sh/v104/<EMAIL_ADDRESS>
Here is the error I get if I go to that types url.

Additional info

esm.sh version: v104
Deno version: 1.29.4

now it works, this is cursed by loop redirects between the CDN and the esm server

thanks for reporting

Thanks for the quick fix.


NIFI-12918 Fix Stateless NullPointerException on versioned sub-process groups - 1.x support branch

Summary
NIFI-12918
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[X] Build completed using mvn clean install -P contrib-check

[X] JDK 21

Licensing

[X] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[X] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[X] Documentation formatting appears as expected in rendered files

Okay, I'm trying one more solution. What I've found is that the main branch has new code where a "registryId" is implemented, but it is always null right now because the registry-api does not currently supply a "registryId" property value. The 1.x support branch does not have this new class. I submitted the fix in the PR to the main branch, but for 1.x, I have something working in the temporary until the changes from 2.0 are pushed down to 1.x (if they are going to do that).

Okay, so after some back and forth here is my final conclusion to this bug:
I've submitted two PRs
https://github.com/apache/nifi/pull/8572/checks <-- for support/1.x branch
https://github.com/apache/nifi/pull/8536/checks <-- for main branch
Here is what's happening. If you run a versioned stateless flow that has sub-versioned progress group, there is a NullPointerException thrown on the build method of StandardVersionControlInformation where there is a non-null requirement on "registryId".
Code has changed in main versus support/1.x, but the bug exists on both. What I've found is the JerseyClient calls that are made to map the response from the registry-api back to the higher level VersionedProcessGroup -> VersionedFlowCoordinates both return JSON where the VersionedFlowCoordinates > registryId is always null. Now in the main branch, stateless uses some of these new "synchronizer" classes, so the best place to insert a solution is to add an else on the null check where the code runs the "determineRegistryId" method and set the value to "1" for versioned flows that do not have a registryId associated to them. Doing this passes all of the integration tests and code checks and fixes the bug. Since this class does not exist in the 1.x support branch, my best solution is to just comment out the null check (this breaks integration tests in main, but not in 1.x).
I continued to look further at this idea of a "registryId" within the registry api code. The GET method on buckets/flow/version returns the same class that the stateless code uses to map into on the JerseyClient call. I then looked at the api code to POST new versioned flows, and it also expect the json as a parameter to match the same class. Well, since there is no "non-null" requirement on the registryId, versioned flows are stored in the database (or whichever storage adapter used) with this property as null. I did not check to see if the latest NiFi Registry UI is now setting this property, but making it non-null would break any older version of registry and not be backwards compatible. Therefore, the only solution at this point to fix stateless NiFi in its current state is to just set registryId to "1" if it is null. I believe this code is still probably prototype being worked and evolving, so this will be a temporary fix until those mandates are in place on a concept of "registryId".

PR has been closed until the 2.0 fix is completed and merged (PR 8536)


Update size-transferred regex for progress in Jobs tab

Not sure which rclone version changed the output format, but this regex works for 1.58.1.

Thank you for the fix! I compiled it on Windows 10 with master branch (v 1.8) and it works fine, now it shows the stats. But with newest test2 branch (v 2.0) it fails to compile. Can you make a fix for that branch too? Thanks!

2.0 is still experimental - so problems with compilation are expected:)

On 15 Jul 2022, at 13:34, tissole @.***> wrote:
Thank you for the fix! I compiled it on Windows 10 with master branch (v 1.8) and it works fine, now it shows the stats. But with newest test2 branch (v 2.0) it fails to compile. Can you make a fix for that branch too? Thanks!
—
Reply to this email directly, view it on GitHub https://github.com/kapitainsky/RcloneBrowser/pull/212#issuecomment-1185501711, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXJHOVJ4WWOQCX7SCLRDALVUFLFBANCNFSM53SRAQKQ.
You are receiving this because you are subscribed to this thread.

Branch 2.0 compiles fine without this fix, but the stats does not appear when downloading and uploading files, same for the 1.8 stable. Release binaries for branch 2.0 so that people can run tests and report bugs. It will speed up development.

The current version of qt@5 on homebrew does not compile rclone-browser successfully.
We need to use<EMAIL_ADDRESS>or earlier
download qt-opensource-mac-x64-5.14.2.dmg from https://download.qt.io/archive/qt/5.14/5.14.2/
open qt-opensource-mac-x64-5.14.2.dmg and using default installation (You will need to wait a while for the 2.6G installation file to open)
The QT 5.14.2 path will be located at ~/Qt5.14.2
brew install git cmake rclone
git clone https://github.com/kapitainsky/RcloneBrowser.git
cd RcloneBrowser
git fetch origin pull/212/head
git checkout -b pullrequest FETCH_HEAD
mkdir build
cd build
cmake .. -DCMAKE_PREFIX_PATH:PATH=/Users/{YOU}/Qt5.14.2/5.14.2/clang_64
make
cd build
/Users/{YOU}/Qt5.14.2/5.14.2/clang_64/bin/macdeployqt rclone-browser.app -executable="rclone-browser.app/Contents/MacOS/rclone-browser" -qmldir=../src/

The rclone-browser.app that shows progress is located at ~/RcloneBrowser/build/build


Add DPM2 and DPM++(2s) a samplers

This adds two more samplers, built by reimplementing the python code from k_diffusion in C++.
I'm actually not sure why DPM++(2s) a works at all, as I think it does a negative timestep if the sigma goes to zero, but as k_diffusion does the same, I just left it as-is.

Hope that someday you will add DDIM sampler.

Hope that someday you will add DDIM sampler.

I looked at that already, but I have to admit I don't understand it's code. Its implementation looks very different from the k-diffusers ones (and uses different variable names for the same(?) things).

Good! Thank you for your contribution.


make_async_writeback_view() vs make_async_view()

Hi,
I've stumbled across this blogpost about buffers in hipsycl.
For me it is not yet clear what the difference between the usage of make_async_writeback_view() and make_async_view() is.
Both operate on the actual data and do not copy it to internal storage (only relevant for CPUs?).
What does that mean in the context of running it on a GPU?
From my testing/understanding when running on a GPU, it does copy the data to the GPU RAM as I would've assumed to have the best performance.
What about the "optional" writeback? Is this only relevant for GPUs also?
My use case is a big vector of data which needs to be operated on and also written back to.
Based on my current knowledge I assumed make_async_writeback_view() would make the most sense.
When running my program I noticed I get a SEGFAULT when using make_async_writeback_view(), but not make_async_view() or make_async_buffer() (tested out of curiosity).
Here is my sample program. Is there anything completely wrong/that could be improved?
#include <sycl/sycl.hpp>
#include <vector>
#include <iostream>
using namespace sycl;

int main()
{
    queue myQueue;
    size_t size = 3000;
    auto dims = sycl::range<3>{64, 64, 64};
    std::vector<sycl::buffer<sycl::float2, 3>> vectorOfBuffers;
    std::vector<sycl::float2> vecWithData;
    vecWithData.reserve(size * 64 * 64 * 64);

    for (int index = 0; index < size * 64 * 64 * 64; index++)
    {
        sycl::float2 temp{1.0f, 0.0f};
        vecWithData.push_back(temp);
    }

    std::cout << "vector size " << vecWithData.size() << std::endl;

    for (int index = 0; index < size; index++)
    {
        std::cout << "Accessing index " << index * 64 * 64 * 64 << " out of " << vecWithData.size() << std::endl;
        // Produces SEGFAULT
        sycl::buffer<sycl::float2, 3> complexIn = sycl::make_async_writeback_view(&vecWithData[index * 64 * 64 * 64], dims, myQueue);
        // Both don't produce a SEGFAULT
        // sycl::buffer<sycl::float2, 3> complexIn = sycl::make_async_view(&vecWithData[index * 64 * 64 * 64], dims);
        // sycl::buffer<sycl::float2, 3> complexIn = sycl::make_async_buffer(&vecWithData[index * 64 * 64 * 64], dims);
        myQueue.submit([&](sycl::handler &cgh)
                       {
                        sycl::accessor vec_acc{complexIn, cgh, sycl::read_write};
                        cgh.parallel_for(dims, [=](sycl::id<3> index) {
                        vec_acc[index] = vec_acc[index] * 3.0f;
                        }); });

        vectorOfBuffers.push_back(complexIn);
    }
    myQueue.wait();
    std::cout
        << "Finished" << std::endl;
    getchar();
}

Any help appreciated!
Cheers

The concept of a view is maybe a bit complicated: On a CPU, it operates directly on data. On a GPU, this is not possible, so as you point out, it still has to copy the data over. However, if you were to e.g. construct a host_accessor, that accessor would operate on the original data point that you have passed to the view.
So, using a view guarantees that whenever you are accessing the buffer on the host, it uses the same allocation that you have passed in.
A writeback view will submit a writeback in its destructor. The writeback ensure that the host-side allocation that you have passed in is in sync with with the most recent copy of the data, on whatever device that may reside. If you only use the view on CPU, this will always be a no-op as

It uses the same allocation on the host that you have passed in, since it is a view
The writeback therefore would be both from and to the same host allocation, which is pointless, so it gets optimized away.

If the most recent copy of the data lives on GPU, the writeback version is required if you are interested in updating the host memory in the end.
Note that an async object will not block in its destructor. An async writeback view will therefore just submit the writeback to the queue, and it is your responsibility to wait for it to complete using e.g. queue::wait().
The reason you are getting a segfault is most likely that with vectorOfBuffers.push_back(complexIn); you are extending the lifetime of the buffers to the same scope as the vector that you have passed in.
This means that buffer destructors are only triggered at the end of main(), and writebacks will only be issued at the end of main(). However, at the end of main() the vector is destroyed as well, which makes the host allocation that the views have been constructed with invalid.
So, at the end of main, the async writeback view will submit a copy back to an invalid host memory pointer that nobody is waiting for.


Faster incremental imports

"Only transfer units if they are newer" is an alternative implementation of https://github.com/lyft/index-import/pull/32.
"Allow specifying direct paths to files to import" allows directly specifying which paths have changed for even more granularity. It also strides on unit paths instead of indexstores, which in our case (a single indexstore) allowed near full parallelism (4x faster for 4 cores, stride of 64 with 4568 files).

Maybe we should remove the per-index store parallelism in favor of the unit path parallelism? Also, have you tested in making the stride boil down to N threads (e.g. if you have 20 files, 4 threads, stride = 20 / 4 =5)?
Also, I think the Only transfer units if they are newer feature should be optional (behind a setting), WDYT?

Maybe we should remove the per-index store parallelism in favor of the unit path parallelism?

For sure. It might make sense for that to be a subsequent PR, since the code around unit path parallelism depends on the fact that I'm passing in the direct paths.

Also, have you tested in making the stride boil down to N threads (e.g. if you have 20 files, 4 threads, stride = 20 / 4 =5)?

I did not test that yet.

Also, I think the Only transfer units if they are newer feature should be optional (behind a setting), WDYT?

Yeah, I could be behind that, as long as it was the default.

Maybe we should remove the per-index store parallelism in favor of the unit path parallelism?

For sure. It might make sense for that to be a subsequent PR, since the code around unit path parallelism depends on the fact that I'm passing in the direct paths.

Also, have you tested in making the stride boil down to N threads (e.g. if you have 20 files, 4 threads, stride = 20 / 4 =5)?

I did not test that yet.

Worth testing, have a feeling it might be the most optimal.

Also, I think the Only transfer units if they are newer feature should be optional (behind a setting), WDYT?

Yeah, I could be behind that, as long as it was the default.

How are you planning on using this? For our integration I was planning on having per-target/source zip files, which we re-import (after extra into a single index store dir) if they have changed. I guess this approach makes sense as long as you're having Bazel build this index locally (so the timestamps are set when it is built)?

How are you planning on using this? ...  I guess this approach makes sense as long as you're having Bazel build this index locally (so the timestamps are set when it is built)?

We ensure that all of our indexes are in a single store dir (via https://github.com/target/rules_swift/commit/dc0c9ef0db74e24895d06cf27ade0321371e3ecf for incremental builds and copying them from individual targets if downloading from a cache). So for us the timestamps are correct since they are the result of a fresh build.

How are you planning on using this? ...  I guess this approach makes sense as long as you're having Bazel build this index locally (so the timestamps are set when it is built)?

We ensure that all of our indexes are in a single store dir (via target/rules_swift@dc0c9ef for incremental builds and copying them from individual targets if downloading from a cache). So for us the timestamps are correct since they are the result of a fresh build.

Ah I see, so you produce the index store as a side-effect, completely external to Bazel, even on CI? When you initially download from the cache you preserve timestamps on all of the unit/record files?

Ah I see, so you produce the index store as a side-effect, completely external to Bazel, even on CI?

We produce the indexes via Bazel, but that patch allows normal remote-cache downloading of the indexes, and when that happens we move those indexes to the same location the patch would put them (the moving is done completely external to Bazel though). The way the patch works though might be described as "completely external to Bazel" since Bazel doesn't track those indexes when building locally.

When you initially download from the cache you preserve timestamps on all of the unit/record files?

Hopefully the above explains that Bazel still downloads the indexes. I'm not sure how it determines timestamps in that case, but even if it's the current time, from the PoV of the build, that is correct, since it had to rebuild and the timestamps would be the current time in that case as well.

Ah I see, so you produce the index store as a side-effect, completely external to Bazel, even on CI?

We produce the indexes via Bazel, but that patch allows normal remote-cache downloading of the indexes, and when that happens we move those indexes to the same location the patch would put them (the moving is done completely external to Bazel though). The way the patch works though might be described as "completely external to Bazel" since Bazel doesn't track those indexes when building locally.

When you initially download from the cache you preserve timestamps on all of the unit/record files?

Hopefully the above explains that Bazel still downloads the indexes. I'm not sure how it determines timestamps in that case, but even if it's the current time, from the PoV of the build, that is correct, since it had to rebuild and the timestamps would be the current time in that case as well.

I see, I was thinking of doing something similar, with the optimization instead being we don't reimport per-target index stores unless they have changed (e.g. different timestamp on the zip itself). Then we don't need the optimization you're adding here although it could be useful if you're remapping a locally made index store.

Ah I see, so you produce the index store as a side-effect, completely external to Bazel, even on CI?

We produce the indexes via Bazel, but that patch allows normal remote-cache downloading of the indexes, and when that happens we move those indexes to the same location the patch would put them (the moving is done completely external to Bazel though). The way the patch works though might be described as "completely external to Bazel" since Bazel doesn't track those indexes when building locally.

When you initially download from the cache you preserve timestamps on all of the unit/record files?

Hopefully the above explains that Bazel still downloads the indexes. I'm not sure how it determines timestamps in that case, but even if it's the current time, from the PoV of the build, that is correct, since it had to rebuild and the timestamps would be the current time in that case as well.

I see, I was thinking of doing something similar, with the optimization instead being we don't reimport per-target index stores unless they have changed (e.g. different timestamp on the zip itself). Then we don't need the optimization you're adding here although it could be useful if you're remapping a locally made index store.
It seems like your approach may be using folders though (tree artifacts) in which case the timestamps might be a bit different.

Does putting the up-to-date check behind a flag (enabled by default) seem reasonable then?

Does putting the up-to-date check behind a flag (enabled by default) seem reasonable then?

Yes. I can add a flag for it, unless @kastiglione thinks it shouldn't have one.

flag sounds fine

Now that I'm back from paternity leave I'll get around to this soon!

ping @keith @brentleyjones

I'll poke around with this next week. Sorry for the delay.

The first commit has landed with #52. I'll make a new PR soon (sooner than last time 😉) for the remaining commit.

The first commit has landed with #52. I'll make a new PR soon (sooner than last time 😉) for the remaining commit.

@brentleyjones I've added the ability to import indexes from a specific compilation, this is useful for managing a global index in Bazel with minimal overhead.
I also realized that we can use this approach to incrementally import units and records when they are compiled in the build system: as an aspect or reading in a BEP stream.
Since the unit contain a pointer to the record, it just pulls dep records for the unit.

https://github.com/lyft/index-import/pull/53 - this one should be able to use the other bits you've added for incremental too 👍

I think #53 covers the remaining part of this for now. If there is still desire for whatever was left here, let me know and I'll work on getting a new PR rolling.


Update Zola Tutorial

Docs Build status updates of commit 9b0361f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/active-directory/saas-apps/zola-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@jeevansd

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Creating a separate PR in our private repo, will merge within 2-3 business days.
#please-close


Feature Add: Scaffolding for arbitrary Match attributes, adding attributes for Type checks.

This PR adds support for arbitrary attributes in the Match objects, allowing for per-type data to be bubbled upwards. This also adds actual_type and expected_type attributes to the PrimitiveType rule (E3012). The scaffolding is a remediation starting point, while the extra attributes allow downstream consumers to perform any type conversions they wish in a programmatic matter.

 ~/development/qstools/amiupdater-sandbox     master    cfn-lint linux-bastion-old.template
E3012 Property Resources/SSHMetricFilter/Properties/MetricTransformations/0/MetricValue should be of type String
linux-bastion-old.template:402:25

E3012 Property Resources/BastionAutoScalingGroup/Properties/Tags/0/PropagateAtLaunch should be of type Boolean
linux-bastion-old.template:589:25

E3012 Property Resources/BastionSecurityGroup/Properties/SecurityGroupIngress/0/FromPort should be of type Integer
linux-bastion-old.template:781:25

E3012 Property Resources/BastionSecurityGroup/Properties/SecurityGroupIngress/0/ToPort should be of type Integer
linux-bastion-old.template:782:25

E3012 Property Resources/BastionSecurityGroup/Properties/SecurityGroupIngress/1/FromPort should be of type Integer
linux-bastion-old.template:789:25

E3012 Property Resources/BastionSecurityGroup/Properties/SecurityGroupIngress/1/ToPort should be of type Integer
linux-bastion-old.template:790:25

>>> import cfnlint.core
>>> rules = cfnlint.core.get_rules([], [], [])
>>> def _parse_template(template_path, quiet=False):
...     try:
...         return cfnlint.decode.cfn_yaml.load(template_path)
...     except ScannerError as e:
...         if not quiet:
...             print(PrintMsg.ERROR + 'Linter failed to load template %s "%s" line %s, column %s' % (
...                   template_path, e.problem, e.problem_mark.line, e.problem_mark.column))
...     except FileNotFoundError as e:
...         if not quiet:
...             print(PrintMsg.ERROR + 'Linter failed to load template %s "%s"' % (template_path, str(e)))
...
...
...
...
>>> t = 'example'
>>> template = _parse_template('linux-bastion-old.template')
>>> results = cfnlint.core.run_checks(t, template, rules, ['us-east-1'])
>>> results[0]
[E3012: Check resource properties values] (Property Resources/SSHMetricFilter/Properties/MetricTransformations/0/MetricValue should be of type String) matched
example:402

>>> vars(results[0])
{'linenumber': 402, 'columnnumber': 25, 'linenumberend': 402, 'columnnumberend': 38, 'filename': 'example', 'rule': E3012: Check resource properties values, 'message': 'Property Resources/SSHMetricFilter/Properties/MetricTransformations/0
/MetricValue should be of type String'}

>>> for r in results:
...     print(r.linenumber)
...
...
402
589
781
782
789
790
>>>

From there, the end-user could write a function that took the input path, expected type, actual type..
for r in results:
    convert_type(r.path, r.expected_type, r.actual_type)

I haven't flushed out the necessary logic yet, but having the attributes there is a huge step in the right direction.

Going to merge this.  Going to consider this beta for a little bit until we can build more around how it will be used.


[ytsearch] Not detecting playlists

An other question:

has yt-dlp a feature to use ytsearch: to search for youtube playlists only?
is it possible to list the content (video list) of a given youtube playlist id?

I always did patch the currently outdated youtube-dl myself and now Im looking if yt-dlp maybe already supports this.
Originally posted by @Crypto90 in https://github.com/yt-dlp/yt-dlp/issues/1211#issuecomment-939356201

@Crypto90 Please keep #1211 on topic

has yt-dlp a feature to use ytsearch: to search for youtube playlists only?

Not with ytsearch. But you can go to youtube, search, apply filters and pass the whole URL to yt-dlp. The filters that were applied in website will carry over. Make sure to use --playlist-end so that the search doesn't go on indefenitely

is it possible to list the content (video list) of a given youtube playlist id?

yt-dlp --flat-playlist --get-url "PLAYLIST URL"

yea I know this but it would be great to get it fully functional with console only handling, which is possible with a few lines of code changes.

You want just playlists, someone else will want some other filter. It is impractical to make a new extractor for each and every use case where there is already a general way to accomplish it.
You only need to manually apply the filter once. You can later use the same URL with just the search term changed. Eg: https://www.youtube.com/results?sp=EgIQAw%253D%253D&search_query=python. The sp=EgIQAw%253D%253D is the filter. You can just change the search query python for future searches with the same filter

I initially though this broke because of some youtube change. But now that I had a look, it seems playlists inside search results never used to work. A proper solution to this would need us to merge the YoutubeSearchIE code with YoutubeTabIE and so will take time to implement. In the meantime, if you can make a PR with your "hacky" solution, we can merge it
cc @coletdjnz

I have created a pull request:
https://github.com/yt-dlp/yt-dlp/pull/1214

@coletdjnz passing the url with those "sp=EgIQAw%253D%253D" filters do already work.
So searching is not an issue.
The only issue I run into were the missing search results of type playlist. It only results "videos" but no playlists with a longer playlist_id.
My pull request adds this check, to differ between a video result and a playlist result and changes the result response in the playlist case to get the correct resulting playlist_id instead of a wrong "video_id".


Remove css from lib

Fix https://github.com/firebase/firebaseui-web-react/issues/93
Removed the css required from the js file and ask the user to import them manually from the node_modules so that it works with next js.

@googlebot I signed it!

I have the same problem and would like for this pull request to be considered.

Can we get some attention on this PR?

Can we get some attention on this PR?

Yes pls!

Merging this is a no-brainer.
React libraries should not assume working with Create React App with its specific Webpack configuration, only React. It's so simple and blocks a large number of users...

Merge conflicts resolved

Sorry for the delay here. I just wanted to check - isn't this problem solved by StyledFirebaseAuth? It bundles the CSS directly, so there shouldn't be a require call.

Some extra context: https://github.com/firebase/firebaseui-web-react/issues/10#issuecomment-364757047

@jhuleatt if you think this PR is not useful you can close this 👍🏻

I'd like to make sure we understand the problem before closing - does StyledFirebaseAuth solve your use case?

Actually this is a very old PR and I no longer use this library so I cannot say anything about it.

@jhuleatt hey guys, why this is closed? It was useful. Import of styles should be optional.

@landsman this was closed because, as far as I can tell, StyledFirebaseAuth solves the same problem this PR was trying to solve (see my comments above). If you disagree, happy to discuss.


Add empty pg_catalog.pg_shdescription table

Summary of the changes / Why this improves CrateDB
Add empty pg_catalog.pg_shdescription table for improved compatibility with PostgreSQL.
Similiar to pg_catalog.pg_description
https://www.postgresql.org/docs/current/catalog-pg-shdescription.html

PostgreSQL 14:
postgres=# SELECT * FROM pg_shdescription
postgres-# ;
 objoid | classoid |                description
--------+----------+--------------------------------------------
      1 |     1262 | default template for new databases
  14020 |     1262 | unmodifiable empty database
  14021 |     1262 | default administrative connection database
(3 rows)

Might become relevant when implementing a COMMENT functionality in CrateDB.
https://www.postgresql.org/docs/current/sql-comment.html

e.g. used by Datagrip
select N.oid::bigint as id,
       datname as name,
       D.description,
       datistemplate as is_template,
       datallowconn as allow_connections,
       pg_catalog.pg_get_userbyid(N.datdba) as "owner"
from pg_catalog.pg_database N
  left join pg_catalog.pg_shdescription D on N.oid = D.objoid
order by case when datname = pg_catalog.current_database() then -1::bigint else N.oid::bigint end

Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

out of the scope, but related:

pg_catalog.pg_get_userbyid(N.datdba) as "owner"

pg_catalog.pg_get_userbyid always returns crate - I think it needs to be updated to return actual user name by oid.

For pg_catalog tables we also need an entry in interfaces/postgres, see
https://github.com/crate/crate/commit/5f184917504346aea9416c81634b3358b3f6a549#diff-914d5e25edd73f4ac2ed45cec9bc9b35c59328b83b15cdee5d934613665778b3R169

For pg_catalog tables we also need an entry in interfaces/postgres.rst, see 5f18491#diff-914d5e25edd73f4ac2ed45cec9bc9b35c59328b83b15cdee5d934613665778b3R169

added

For potential contributors:
It can be done similar to has_schema_privilege:
non-compiled version can get UserLookup from the NodeContext, see
https://github.com/crate/crate/blob/88113a477d313358af68e1bfed53e79940ecaa47/server/src/main/java/io/crate/expression/scalar/HasSchemaPrivilegeFunction.java#L285
compiled version is create in compile() which accepts UserLookup directly, see https://github.com/crate/crate/blob/88113a477d313358af68e1bfed53e79940ecaa47/server/src/main/java/io/crate/expression/scalar/HasSchemaPrivilegeFunction.java#L223

For pg_catalog tables we also need an entry in interfaces/postgres.rst, see 5f18491#diff-914d5e25edd73f4ac2ed45cec9bc9b35c59328b83b15cdee5d934613665778b3R169

added

Thanks for adding missing entries and sorting them alphabetically!
On vale failure: we can either add shdescription into vocabulary (accept.txt file) or turn it off before section and turn it on again on section end. see https://github.com/crate/crate/pull/12355/files#diff-6b4ff31a02425d333cc54423875ca7ab94432d3399bd0d6b45797763cbb5dcd7R64


Convert span attribute values to strings

As reported in opencensus-beam/opencensus_absinthe#10:

DD: Unable to send spans, DD reported an error: 400: 'json: cannot unmarshal number into Go struct field Span.meta of type string\n'

If DataDog can't cope with numbers, I think we'd better fix that in our DataDog adapters, because it doesn't make sense to change the rest of the OpenCensus ecosystem to cast attributes to strings just in case the spans might get sent to DataDog.
Nailing it down a little:

attribute_value() = any()
– opencensus Erlang typespec

AttributeValue … oneof … TruncatableString …int64 … bool_value … double_value
–  OpenCensus protocol definition

A span contains a SpanContext and allows users to record tracing events based on the data model defined here
– OpenCensus specification

@sneako, it occurs to me another good point to get this fixed is at DataDog's end. Their API reference says only:

a dictionary of key-value metadata. e.g. tags

… and doesn't express much about what types the values might be. Perhaps they're open to casting all the values they get to strings at receipt time?

I think it should be fixed in DD adapter.

@hauleth When you say 'DD adapter' are you referring to the Datadog agent, or this library?

This library.

@sneako DD probably should fix either their agent or documentation as well, but we do not have control over these. Fixing it there is better solution for now.

I have also opened a ticket with Datadog's support team to improve their documentation or the agent. Thanks everyone!

Datadog has updated their docs as well https://github.com/DataDog/documentation/pull/4609


card.io-iOS-source unable to run,

Running unknown error，There is no wrong reason

we are also facing the same issue....please let me know to move further..