Enable new Carbon features on Laravel 5.6

Laravel Version: ~5.6.17

Description:
Hi, just a kindly reminder about new features in Carbon. We're often asked from Laravel 5.6 users about why some plugins or new features doesn't work for them. And the only way we have to help them is to give a composer cheat: "nesbot/carbon": "1.29.0 as 1.25.0". I understand the stability argument, but be aware we're now working on Carbon 2 and Carbon 1 will be now just maintained for bug fixes.
Here is the complete list of features that  a "1.25.* || ^1.26.2" composer carbon version would allow in addition of third-party compatibility:

1.29

Added CarbonPeriod and related methods in Carbon and CarbonInterval

1.28

Added isStartOfDay, isEndOfDay, isMidnight, isMidday methods
Added locales bs_BA, hi, is, ne, oc, sh, sw
Added diff translations for ca, es, nl, no, pl, sl, sr*
Fixed ko, pl translations
Fixed createFromFormat with partial format and mock now instance
Added CarbonPeriod and related methods in Carbon and CarbonInterval
Added make methods to Carbon and CarbonInterval
Added getCascadeFactors, setCascadeFactors, getFactor, getDaysPerWeek, getHoursPerDay, getMinutesPerHours, getSecondsPerMinutes, cascade, total methods and total getters to CarbonInterval
Added $short argument to CarbonInterval::forHumans to display short formats

1.27

Added isSameQuarter, isCurrentQuarter, isNextQuarter and isLastQuarter methods
Added isSameHour, isSameMinute, isSameSecond, isCurrentHour, isCurrentMinute and isCurrentSecond methods
Added CarbonInterval::times method
Added italian translation for diff words

1.26

Added setDateFrom and setTimeFrom methods
Allowed DateTimeInterface in instance method
Added welsh language
Added CarbonInterval::getDateIntervalSpec (similar to CarbonInterval::spec but static and able to take any DateInterval instance as argument)
Added options for diffForHumans to support now/yesterday/tomorrow

The better solution is to create PR with requested changes...

The PR exists but was closed. So I prefer to expose first the new situation and discuss.

👍

I submitted a Carbon pull request today only to discover four package test cases are failing (unrelated to my change) because today is end of the month (and they don't consider https://github.com/briannesbitt/Carbon/pull/710 ). A date-handling package's test coverage is failing due to a change of date.
Carbon's recent release schedule:

1.24.0 Mar 9, 2018
1.24.1 Mar 9, 2018
1.24.2 Mar 12, 2018
1.25.0 Mar 20, 2018
1.26.0 Apr 16, 2018
1.26.1 Apr 16, 2018
1.26.2 Apr 16, 2018
1.26.3 Apr 16, 2018
1.26.4 Apr 17, 2018
1.27.0 Apr 23, 2018
1.28.0 May 22, 2018
1.29.0 May 24, 2018
1.29.1 May 29, 2018
1.29.2 May 29, 2018

Carbon was left dormant for awhile so it was seen as a stable product but since March the releases have been volatile, affecting projects in the Laravel ecoysystem. With trust in that dependency eroded, from my perspective it's more difficult to justify the maintenance burden when Laravel 5.6 is in a fairly good state now.

The test failure you mention is not related to new features. Carbon::now()->setMonth(9) (first test failing) does not always set the month to 3 (in case of overflow) and it's a native PHP DateTime behavior. This particular case happens when you go to a month when the current day does not exist. Those tests should be edited to cover this case but the Laravel 5.6 locked version 1.25.x is no different in this way from other versions. This behavior is not new, it's always been in Laravel.
Use ^1. is not mandatory, we could propose a range like >=1.26.2 <1.30 then time to time extend this range but just 1.25.* is very restrictive and make Laravel users open issues like "I cannot install this package (where a package require a earlier carbon version)", or "This method is in the documentation and I have the last Laravel 5.6 version but when I use it, it says the method is not found".

@derekmd I would argue that the actual cause of the failing tests is not overflow but weirdness of the create method - it defaults omitted units to the current date and time. This is however not a new behavior, but something that came with Carbon since the very first commit.
Recent releases did not introduce a break, but contrarily exposed an existing oddity. Furthermore whether implementation of Easter macro in the tests you fixed is correct or not didn't really matter, because these tests focus on testing the ability to register macros in general, not whether the macro itself is implemented correctly or not. I agree though that a simpler macro would be more appropriate.
If your point was that mistakes shouldn't be made during the early 1.2x releases I don't think you chose a right argument. Please note that for some time Carbon was in fact not a stable product, but an unmaintained repo with very many open issues and prs. Mistakes can happen when a new maintainer takes over at such time.

Maybe https://github.com/cakephp/chronos can serve as a replacement for Carbon? It was forked from it for the reasons other people already named here and should be compatible and it's maintained.

Chronos is cool and can easily be used instead by a simple settings change. But as the default library, it would be a bad idea. It is far from being compatible with current Carbon. And you say it's maintained but its last release is more than 1 year old while Carbon is now well maintained as its documentation. Carbon 2 will implement immutability and a better more would be to merge Chronos features into Carbon. If Chronos contributors want to join to the effort it would be with pleasure.

@kylekatarnls

its last release is more than 1 year

Chronos' last release was on 13. January 2018..
There is also a well enough maintained Chronos documentation, that could be extended, if necessary.

Chronos' last release was on 13. January 2018.

Sorry I looked "Latest release" as tagged by GitHub: https://github.com/cakephp/chronos/releases
But missed simple git tags.
And I did not said Chronos is not well maintained. But as @burzum said "and it's maintained", I would answer: as is Carbon, so it's not a reason enough to change the date library in Laravel and it's not at all the subject here. If you want to push Chronos in Laravel, you can open an other issue. Rather it would be done or not, as long as Carbon is a dependence of Laravel, if should be kept up to date. And that's the only point to debate here.
I have really nothing against Chronos. The point is that Laravel's users comes to Carbon issues and Carbon library repositories facing compatibility issues due to the gap between 1.29 documentation and 1.26+ plugins and the current Laravel 5.6 restriction.

It would be great get carbon 1.29.
In my case I need it, beacuse I want to use the carbonPeriod feature, its really important to my project.

Really would love to get carbon 1.29 for the CarbonInterval::cascade()

Please, I want to use CarbonPeriod.

@taylorotwell What about "nesbot/carbon": "1.25.* || >=1.26.2 <1.30" which would not auto-update on 1.30 release?

Laravel 5.6 is fixed to Carbon 1.26 due to various breaking and incompatible changes, Laravel 5.7 is due soon and have the latest version pulled.

@themsaid No, it's fixed to 1.25 and it's not incompatible, any version after 1.26.1 can be used as 1.25.09 with no incompatibilities. The 2 breaks that happened had been fixed in a couple of hours. In fact last time the fix came before Laravel released the 1.25.* freeze. So there is no particular reason to freeze Laravel 5.6 when you can either use a update-safe range or simply align Laravel 5.6 on 5.5 and 5.7 versioning.
I'm pretty sure we can do something more precise.

See https://github.com/laravel/framework/pull/24718

You can install the latest version of Carbon with Aliasing in composer.json
"nesbot/carbon" : "2.3 as 1.26.3"


issue #193, Create todo app using vue.js

Solve Todo app with vue js

Solve Todo app with vue js

Well done!

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Inspect request defaults

Is it possible to inspect the defaults set through request.defaults() after setting them and, if so, can someone share how? I haven't been able to figure it out.
Thank you,

AFAIK, there isn't a way to do so. It seems to be within the local scope of the wrapper returned with request.defaults({...}).

Hm.. That's what I thought. Unfortunate.
Thanks for the reply.


Added JS Validation on contact form to enhance UI issue#403 resolved

Related Issue
-Add JS Validation on contact form to enhance UI #403
Proposed Changes
-Validation add for empty fields , invalid email.

Add red border outside the fields for wrong inputs
Add green border for correct inputs

Additional Info

Checklist

[ x] ✅ My code follows the code style of this project.
[ ] 📝 My change requires a change to the documentation.
[ ] 🎀 I have updated the documentation accordingly.
[ ] 🌟 ed the repo

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

@agamjotsingh18  Please check it issue#403 resolved !!

Great work @Geeta259


feat: add output breaking_files

Adds the output breaking_files to the action. This allows
the user to utilize a list of files if they wanted to take
any action afterward.
Updated dependencies and adds ncc for building actions. Using
ncc is based on https://github.com/actions/typescript-action.
Adds npm scripts to help with consistent building and other
contributors to build the project.
Start using node16 since generally available now.

If you don't care for anything besides the actual functionality, I don't mind just keeping the TypeScript changes and leaving the rest up to your team.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Make Enterprise injection more reliable

I changed the way content scripts are injected. They are no longer injected manually with tabs.executeScript but they are declaratively registered via contentScript.register (which is polyfilled to declarativeContent.RequestContentScript).
2 polyfills and the glue for both (which registers the scripts on new origins) will be extracted into their own modules once verified that this all works.
The only minor bug right now is in Firefox: even if you remove the permission, the scripts will still be injected until the next restart. It's Firefox' bug, nothing asynchronous works after request/remove for some reason.
cc @busches
Test

Visit github.com, no "double injection" errors should ever appear, even if you try "Enable Refined GitHub on this domain"

Visit google.com, no injection happening, so no errors in the console or background.js
Visit google.com/images, "Enable Refined GitHub on this domain"
Reload the page and see the errors in the console (obviously, because it's not GitHub)
Search for images
Open a photo
You shouldn't see the same errors repeated, because it's an ajaxed page and it the content scripts shouldn't be injected multiple times.

In no case should there ever be any errors in the console. I dropped a try/catch so the previously-silenced errors should no longer ever happen.

Yes after this has been tested and works correctly. There are 3 modules to be extracted

FYI I changed jobs and don't currently have access to GHE to test currently. 😐


[Documentation] Any pointers on how to run this behind an Nginx reverse proxy?

I would guess 5000-5200/udp needs to be opened to WAN, are there any other public-facing ports?
From https://github.com/pion/ion-app-web/ I suppose I should npm install and then npm run build. Nginx should then point /ws to localhost:8443 with proxy_set_header Upgrade $http_upgrade; proxy_set_header Connection $connection_upgrade;. Am I missing anything?

https://github.com/pion/ion/wiki/DeployByNginx


Deserialization of Map<MyEnum, List> results in Map<MyEnum, List>

Whoopsie.

Apparently this happens only with @TargetType(TreeMap/LinkedHashMap) or even @TargetType(Map) annotation. Direct type TreeMap<MyEnum, List<MyOkaeriConfig>> is not affected.

Looks like TargetType was incorrectly applied to all types transformed in the context of the annotated field instead of parent field only. Fixed in https://github.com/OkaeriPoland/okaeri-configs/commit/f69d94f434dab060366a8fab144728530845c4ec and released in 4.0.0-beta19.


could OCMProtocolMock and OCMClassMock work at the same time

hi there, I just write a mock for the following code
code snippet 1
+ (BOOL)hasMicrophonePermission {
    __block BOOL permission = YES;

    if ([[AVAudioSession sharedInstance] respondsToSelector:@selector(requestRecordPermission:)]) {
        [[AVAudioSession sharedInstance] requestRecordPermission:^(BOOL granted) {
        permission = granted;
        }];
    }
    return permission;
}

and what i wrote is here
id audioSessionMock = OCMClassMock([AVAudioSession class]);
OCMStub([audioSessionMock sharedInstance]).andReturn(audioSessionMock);

// for iOS 7.0 below repondsToSelector to requestRecordPermission: always return NO so I write this
OCMStub([audioSessionMock respondsToSelector:@selector(requestRecordPermission:)]).andReturn(NO);

// [CTCallUtil hasMicrophonePermission] method contain the code snippet1
expect([CTCallUtil hasMicrophonePermission]).to.equal(YES);

when I run test, I found the method
    [[AVAudioSession sharedInstance] respondsToSelector:@selector(requestRecordPermission:)]

return YES (because I use iOS 7, that mean stub did not work)
then I search how to stub respondsToSelector: then I found should use OCMProtocolMock instead, the question is the OCMProtocol can not work like OCMClassMock. the protocol mock object can not stub to sharedInstance method, so it crash。
I want to know is there has any solution to handle this question, if I need to use to stub respondsToSelector: and other class method at the same time?

Duplicate of #161.


How to use this for multiple components?

Thank you for this project, I absolutely love the simplicity of hook-based knobs! I would like to be able to use this to debug different components simultaneously. I tried first by naively attaching a non-portal Inspector to each component I want to inspect but then found that hooks begin to mix between them.
Is this usage supported, in the roadmap or intended at all?

Hey,
Can you please create a codesandbox example with the issue and share it here?

Hi, sorry for the delayed response. Hopefully the following sandbox will help illustrate what I'm trying to achieve:
https://codesandbox.io/embed/condescending-wave-1knrl
Essentially I want to have two (read: any number of) independently running inspectors, so that I can look at different components at the same time, each in their isolated Retoggle context.
I did not expect the example above to work, because as far as I can see there's no discernable way that <Inspector /> could possibly know what environment it lives in.
I wonder if a simple syntactic extension of some nature like the following would work:
const retoggleContext = useRetoggle();

// then either something like this
// (but it may be a breaking change depending on the argument positioning)...
const booleanKnob = useBooleanKnob("My Boolean Knob", false, retoggleContext);

// ...or something like this
const booleanKnob = retoggleContext.use(useBooleanKnob, "My Boolean Knob", false);

// ... then later
<retoggleContext.Inspector />

You are right. With the current design, the Inspector doesn't really know much about the toggles.
We could agree on an API to support multi inspectors. But unfortunately, I don't have time to work on this soon!

@soul-codes FYI support for multiple inspectors is now supported with version 1.0.0. You can find documentation on it here. I know it's been a while since you were looking for this, but I the changes in 1.0.0 should support what you are describing.


ConnectionRefusedError: [WinError 10061]

I am new to PSI(private set intersection) and I have some troubles in running the codes.
I wonder why I get an error when I run the command : python psi_server.py
The error: ConnectionRefusedError: [WinError 10061]
I have tried to Change the native proxy Settings to auto-detect Settings, but it doesn't work.

I never test my code on windows system, and this error doesn't occur on Linux.
Can you show the stack trace of the error, or test the code on Linux?

I also encountered the same problem, in Win10 the problem is "ConnectionRefusedError: [WinError 10061]", in Ubuntu 20.04 the error is "ConnectionRefusedError : [Errno 111] Connection refused" . Have you solved this problem? How did you solve it?

I later tried to git clone this project again(win 10, python 3.7), and it turned out to be successful. So I guess there is something wrong with the network.

I also encountered the same problem, in Win10 the problem is "ConnectionRefusedError: [WinError 10061]", in Ubuntu 20.04 the error is "ConnectionRefusedError : [Errno 111] Connection refused" . Have you solved this problem? How did you solve it?

I later tried to git clone this project again(win 10, python 3.7), and it turned out to be successful. So I guess there is something wrong with the network.


PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.

See Jira. In the SELECT CF1.* WHERE CF2.C ... cannot use the EncodedQualifiersColumnProjectionFilter since the number of qualifiers is not know (so the trackcolumns Bitset cannot be build ahead of time).

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m 13s
the patch passed

+0
hbaserecompile
17m 40s
HBase recompiled.

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

-1 :x:
checkstyle
0m 50s
phoenix-core: The patch generated 15 new + 720 unchanged - 14 fixed = 735 total (was 734)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 50s
the patch passed

+1 :green_heart:
spotbugs
3m 15s
the patch passed

_ Other Tests _

-1 :x:
unit
106m 45s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 44s
The patch does not generate ASF License warnings.

163m 23s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1177

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux d2443e3856be 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / b5bea88

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/1/testReport/

Max. process+thread count
12917 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I'll also check the test failure.

Actually... When I add local indexes into the mix it still fails for another reason. I'll look into that as well. If it's an easy fix I'll add it here otherwise I'll file another jira.

Added more tests as @virajjasani suggested. Also added local indexes to the test, and included an additional fix for local indexes.

Expanded the test slightly to also do a CF.* from a column family with an indexed column.
This should be good now.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
19m 14s
master passed

+0
hbaserecompile
27m 18s
HBase recompiled.

+1 :green_heart:
compile
1m  2s
master passed

+1 :green_heart:
checkstyle
0m 53s
master passed

+1 :green_heart:
javadoc
0m 51s
master passed

+0 :ok:
spotbugs
3m  6s
phoenix-core in master has 956 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m  8s
the patch passed

+0
hbaserecompile
17m 35s
HBase recompiled.

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

-1 :x:
checkstyle
0m 53s
phoenix-core: The patch generated 16 new + 833 unchanged - 15 fixed = 849 total (was 848)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 52s
the patch passed

+1 :green_heart:
spotbugs
3m 12s
the patch passed

_ Other Tests _

-1 :x:
unit
107m 52s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 49s
The patch does not generate ASF License warnings.

171m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1177

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux baa7eaee37b1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 84d91ff

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/2/testReport/

Max. process+thread count
13878 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Last test run still looks good.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
15m 38s
master passed

+0
hbaserecompile
22m  4s
HBase recompiled.

+1 :green_heart:
compile
1m  3s
master passed

+1 :green_heart:
checkstyle
0m 53s
master passed

+1 :green_heart:
javadoc
0m 54s
master passed

+0 :ok:
spotbugs
3m  3s
phoenix-core in master has 956 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m 13s
the patch passed

+0
hbaserecompile
17m 31s
HBase recompiled.

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

-1 :x:
checkstyle
0m 53s
phoenix-core: The patch generated 16 new + 833 unchanged - 15 fixed = 849 total (was 848)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 51s
the patch passed

+1 :green_heart:
spotbugs
3m 14s
the patch passed

_ Other Tests _

-1 :x:
unit
105m 28s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 44s
The patch does not generate ASF License warnings.

158m 12s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionNSEnabledIT

phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1177

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 90e46aeea902 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 84d91ff

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/3/testReport/

Max. process+thread count
13966 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/3/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks @virajjasani


OSGi Bundle

Has anyone had success converting this library to run in an OSGi container?

@bsiver Do you have SpringFox bundle uploaded anywhere? I really need it right now

I will check what we have and try to get back to you over the next couple days.
Sent from my iPhone
On Aug 23, 2016, at 6:45 AM, shanmukhm <notifications<EMAIL_ADDRESS>wrote:
@bsiverhttps://github.com/bsiver Do you have SpringFox bundle uploaded anywhere? I really need it right now

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/springfox/springfox/issues/119#issuecomment-241694075, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABHCUQgVtXU5LiSDiARaI8cr_yPJUSEbks5qis85gaJpZM4A2BEG.


bsi v2

Add compliance doc for bsi - v2.0 for review.

@fvsamson  @surendrapathak  I have read & re-read the BSI v2.0 spec multiple times and i have come up with the compliance doc, before i start the implementations.  Wanted to call out a couple of things

CDX minimum version requirement from 1.4 to 1.5 was called out, but SPDX 2.3 -> 2.2.1 was not.
Added column for SPDX 3.0, will fill that out later once i complete the golang library for SPDX 3.0 parsing.
Need help with Executable/Archive and structured properties, not sure how these translate.
BSI has reserved namespace for CDX properties, can they be leveraged for custom data?
Associated Licenses: Seems like a new concept, but my interpretation is more on the lines of License Expression should be present, not list of licenses for concluded licenses.
Feels like "Additional SBOM & Component Fields" are almost mandatory now, in v1.1 it was optional ?
SBOM's should not contain vulns (Love it)

Yeah, the compliance doc looks good. https://github.com/interlynk-io/sbomqs/blob/feature/bsi-v2/Compliance.md .
Some of the fields as mentioned above like Archive/executable and structured looks in the sboms.

Wow, you are quick.  I am currently travelling, so my time is a bit limited and hence at BSI our weekly TR-03183-2 writers team teleconference was cancelled.  What I can provide the next days are some replies to @riteshnoronha's points above, hopefully a first proper review of your compliance document sometime this week (just glanced over it now), and I will discuss both (questions and document) with my colleagues at our teleconference next week.
Side note: We plan to publish our thinking of mapping TR-03183-2's requirements to CDX and SPDX tags in v2.1.0 of TR-03183-2.  We are aware, that for a few requirements there are no appropriate tags, but there are a couple of generic ones one can use as name:value fields.  Likely we will also require at least SPDX 3.0 (and presumably CDX 1.6), because some new tags make this mapping a lot easier.
This mapping task is primarily performed by a colleague who also has become the one most savvy of us in the CDX and SPDX specifications.  I will ask him to chime in here next week.

Notes:

3.1 Definition of SBOM - specifically points out An SBOM MUST NOT contain vulnerability information. Therefore, I recommend removing that row.
4 SBOM Formats—limits both specifications and specification versions BUT ALSO file formats to JSON/XML (removing RDF and TV). sbomqs should add a row for that.
Typo in 5.2.2 originatior
On associated license, I agree with @lpanni 's point above and also from the description itself : Associated licence(s) of the component from the perspective of the SBOM creator. For specifics, see sections 6.1 and 8.1.9.. Specifically, the phrase indicates a choice made by the SBOM creator (concluded) rather than just the listed (associated). However, if the choice has not been made (concluded license not present), then it seems safe to fall back to associated as per section 8.1.9 Associated licences are all licences under which a component can be used by the licensee.
5.2.2 hashes - Since the requirements limits to deployed/deployable component, we should limit this check to the specific component types (not applicable to say ARCHIVE , TEXT, VIDEO etc)

Rest looks good to me.

@fvsamson i am going to start development based on my initial take, we can refine it once you have bandwidth to review it.


Can not compile with Swift as a framework

I'm using cocoapods in a MacOSX command line app with this Podfile:
# Uncomment this line to define a global platform for your project
platform :osx, '10.8'

use_frameworks!

target 'EventwoCreateApp' do
	pod 'GBCli'
    pod 'XcodeEditor'
end

When i try to build the project, it fails building because of including of non-modular header inside framework module
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "/Users/pedro/Library/Developer/Xcode/DerivedData/EventwoCreateApp-hbqavnbhqvzppravjjsvpcdoxdwl/Build/Products/Debug/Pods-EventwoCreateApp/XcodeEditor.framework/Headers/Pods-EventwoCreateApp-XcodeEditor-umbrella.h"
        ^
/Users/pedro/Library/Developer/Xcode/DerivedData/EventwoCreateApp-hbqavnbhqvzppravjjsvpcdoxdwl/Build/Products/Debug/Pods-EventwoCreateApp/XcodeEditor.framework/Headers/Pods-EventwoCreateApp-XcodeEditor-umbrella.h:20:9: note: in file included from /Users/pedro/Library/Developer/Xcode/DerivedData/EventwoCreateApp-hbqavnbhqvzppravjjsvpcdoxdwl/Build/Products/Debug/Pods-EventwoCreateApp/XcodeEditor.framework/Headers/Pods-EventwoCreateApp-XcodeEditor-umbrella.h:20:
#import "XCKeyBuilder.h"
        ^
/Users/pedro/Library/Developer/Xcode/DerivedData/EventwoCreateApp-hbqavnbhqvzppravjjsvpcdoxdwl/Build/Products/Debug/Pods-EventwoCreateApp/XcodeEditor.framework/Headers/XCKeyBuilder.h:14:9: error: include of non-modular header inside framework module 'XcodeEditor.XCKeyBuilder'
#import <CommonCrypto/CommonDigest.h>
        ^
/Users/pedro/Downloads/EventwoCreateApp/EventwoCreateApp/AppCreator.swift:10:8: error: could not build Objective-C module 'XcodeEditor'
import XcodeEditor

I've tried different solutions, like customizing the modulemap file or adding the framework to the target, but the error is always the same.
¿is there some solution or is it simply a swift limitation?, thanks

:+1:

I had the same problem and issued a pull request to solve it (#53). This request was merged in commit 9f1a7e63461341ab456fa290f38bc53f24517845. So you should be able to compile as a framework now.
If you are using Swift 2.0 #54 adds lightweight generics which reduces the amount of casting you need to do.

https://github.com/appsquickly/XcodeEditor/pull/60 has make XcodeEditor to be able to nicely integrate with Carthage into Swift projects(the project did not set define modules to be Yes, so previously after linking the framework you still need to add necessary headers to the bridging headers).
I haven't tested Cocoapods yet, but it's totally fine with Carthage.

@iosdevzone @cezheng Shall we tag a new version and close this issue off?

@jasperblues Maybe better to make sure that Cocoapods is fine(not sure if podspec would need an update or not since Carthage reads the xcodeproj's header settings but Cocoapods does not), but currently I don't have a mac at hand to check this out.


Payload format indicator contains always "UNSPECIFIED" value after publishing

Hello guys :)
Here some reports regarding bugs found so far when publishing messages using c# client library.
🐛 Bug Report
A published message with PayloadFormatIndicator = UTF8Encoded is always sent with Unspecified. When a Validate() method is called, it is always being set to Unspecified when contains both values. This is wrong, it should only throw an exception if it contains a different value, Unspecified if it is nullalble or keep the current value.
🔬 How To Reproduce
Steps to reproduce the behavior:

Define a client of type HiveMQClient with a specific options for your configuration.
Create a event handler for client.OnPublishSent event and assign to it. The event handler should print a value from OnPublishSentEventArgs.PublishPacket.Message.PayloadFormatIndicator.
Create an instance of MQTT5PublishMessage and set a value as PayloadFormatIndicator = MQTT5PayloadFormatIndicator.UTF8Encoded.
Finally publish the message defined in step 3 as await client.PublishAync(message).ConfigureAwait(false)

Code Example
The code in discussion can be found here
Environment
The client is ran in Windows 10 OS with dotnet 6 sdk and HiveMQTT v0.5.0 C# nuget package.
📈 Expected behavior
The value of the PayloadFormatIndicator should be the one it is set before publishing.

Doh! Great find @dalbarracin - I'll fix that up soon.  Thanks for reporting!

The fix for this has been added in release 0.6.0 which is building now and should be on NuGet soon.  Thanks for pointing this out @dalbarracin!

Thank you @pglombardo for taking your time on this. NIcely done :)


fix default credential chain not respecting endpoint URL overrides

Motivation and Context

https://github.com/awslabs/aws-sdk-rust/issues/1193
Description
This PR fixes a customer reported bug where the default chain doesn't respect AWS_ENDPOINT_URL/AWS_ENDPOINT_URL_<SERVICE> environment variables or the equivalents in AWS shared config (~/.aws/config).
This fix is a little nuanced and frankly gross but there isn't a better option that I can see right now that isn't way more invasive. The crux of the issue is that when we implemented support for this feature (1, 2, 3) we really only made it work for clients created via ConfigLoader::load(). Internally the default chain credential provider constructs STS and SSO clients but it does so using ProviderConfig by mapping this to SdkConfig via ProviderConfig::client_config(). This conversion is used in several places and it doesn't take any of the required logic into account to setup EnvServiceConfig which is what generated SDK's ultimately use to figure out the endpoint URL from either environment/profile (example client which ultimately ends up in EnvServiceConfig here).
The fix applied here is nuanced in that we update the conversion to provide a EnvServiceConfig but it relies on the profile to have been parsed already or else you'll get an empty/default profile. This generally works for the profile provider since the first thing we do is load the profile but in isolation it may not work as expected. I've added tests for STS to cover all cases but SSO credentials and token providers do NOT currently respect shared config endpoint URL keys. Fixing this is possible but involved since we require an async context to ensure a profile is loaded already and in many places where we construct SdkConfig from ProviderConfig we are in non async function.
Testing
Tested repro + additional integration tests
Future
This does not fix https://github.com/awslabs/aws-sdk-rust/issues/1194 which was discovered as a bug/gap. Fixing it would be outside the scope of this PR.
SSO/token provider is instantiated sometimes before we have parsed a profile. This PR definitely fixes the STS provider for all configuration scenarios but the SSO related client usage may still have some edge cases when configured via profiles since we often instantiate them before parsing a profile. When we surveyed other SDKs there were several that failed to respect these variables and haven't received issues around this which leads me to believe this isn't likely a problem in practice (most likely due to SSO being used in local development most often where redirecting that endpoint doesn't make much sense anyway).
Checklist

[X] For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Did we ever get around to starting that list of things we would like to change in a V2 if we ever get around to it? If so the whole ProvderConfig thing should probably go near the top.
I think this is the best solution we could hope for given the current setup.

I don't see a list anywhere maybe we should start one and make it a dumping ground for future ideas.


Android - can't scroll on dashboard

Issue description
its been reported by multiple ppl: scrolling in dashboard seems to be broken for some devices. anyone who can add more info to this issue is very welcome, like Device, android version, etc

HTC M8 Phone - Android 6 Build 6.12 with HTC Sense ver7'00

Google Nexus 8" Tablet Android ver 6.01

Previous Streama apk did scroll on this hardware and Android ver 6.00 but had other issues which have been documented

seems like v1.4.1 RC3 fixes the issue of tv-shows, movies and generic Videos not loading. have a look.
If this is  not what is meant by "can't scroll", then please let me know!

Not fixed with RC3, still not showing TV Shows, Movies or Generic Videos only 'Continue Watching' also Search doesn't work., This is the same on both mobile and tablet with Android Ver 6.00 and 6.01

Hi, I just released a new version for the app. Please check if its fixed there!

Hi, the app is now displaying but only 30 in each section. The search is now working.
The worst problem I have is that the videos now load very slowly on the normal web browser and I cannot upload videos, they just race past on the uploading and never process because no file has been uploaded.
I have tried to go back to last version to correct this problem, now I have the same trouble with that version, so something has happened in the data base  which is H2 not SQL, or something else.
Not a very happy bunny at the moment as I have a lot of content uploaded which has been working flawlessly on the Windows platform.
I am not sure if you are aware that on the Windows platform a directory is create -C:/users/name of user/appdata/local/temp/2/ In this directory videos are duplicated with other settings. These videos need to be deleted after a while or the C: drive becomes full. I have attached the contents of the directory 2.
folder 2.txt

Hi
I think I may have something strange going on with regard to the uploading etc in the Chrome browser and the PC. I am digging deeper to find out

Hi, the app is now displaying but only 30 in each section.
this is kinda wanted behaviour. the only thing missing is the load-more. I can implement that fore mobile tho

Not a very happy bunny at the moment as I have a lot of content uploaded which has been working flawlessly on the Windows platform.

well damn. thats ofc not good. however, I actually didnt really mess around with the data in general. So i cant really see the connection, especially if you reverted back to an old version everything should be the same.
if you wanted you could give me access to a throwaway account on your system and I could check it out. if so, hit me up on gitter.

I am not sure if you are aware that on the Windows platform a directory is create -C:/users/name of user/appdata/local/temp/2/

Yea, my brother started coding on streama recently and then we noticed this too. tbh, these kinds of systems, like java applications with a web frontend etc, are usually not so well suited for windows. I mean, for development, sure. But as soon as you are talking about real hosting, then i would go with a virtual server somewhere like amazon servers or digital ocean or, for more control, an old tower PC with ubuntu installed. Windows tends to be kinda weird when it comes to a lot of hosting stuff, which is why it is commonly avoided for that task.
Lastly, if you are using the app so much as your message indicates, please consider migrating your data over to mysql. With mysql you can more easily backup, recover and adjust your data. H2 is more of a temporary "getting-started" type of thing.


Fix unexpected auto translation of editor Tree content

Fixes some regressions due to Tree now supports auto translation (#89032).
This PR almost touched every Tree used in the editor. The change of auto translation behavior affects compatibility. I think we could alternatively make Tree not auto translating by default.
CC @YeldhamDev

I'm surprised you didn't include the changes in #89546 to supersede it. It would unite everything into a single commit.
And about the compatibility, while you have a point, I think we should wait a little and see if it's affecting other people or if it's just a us problem.

Thanks!


Assertion failed: (bytes_transferred > 0)

I upgraded beast from old 61 to 89 and now it fails with this assertion regularly on our channel:
Assertion failed: (bytes_transferred > 0), function operator(), file /Users/mike/.conan/data/Beast/89/satorivideo/master/package/def3ba7be14694f242b67c577db3871951dd33cd/include/boost/beast/websocket/impl/read.ipp, line 507.

Investigating...

What type of DynamicBuffer are you passing in your call to stream::async_read?

Please try this branch, I have added additional asserts to help track down the issue
https://github.com/vinniefalco/beast/tree/issue686

We have studied the code generating the assert and determined that it contains a defect. Specifically, when an incoming final frame has length zero, the read algorithm does not terminate. This defect is fixed in version 90 please try it and confirm that it resolves your problem. Thank you for the bug report!
See: https://github.com/boostorg/beast/pull/687

@vinniefalco I don't think the #687 was merged.

@mikea It is part of https://github.com/boostorg/beast/pull/690 and I am waiting for you to try it to confirm that it fixes your issue before merging. Thanks!

Testing a change is problematic for lots of reasons (package management). I
can easily verify it once it gets to the main repo though.
On Fri, Jul 28, 2017 at 09:59 Vinnie Falco<EMAIL_ADDRESS>wrote:

@mikea https://github.com/mikea It is part of #690
https://github.com/boostorg/beast/pull/690 and I am waiting for you to
try it to confirm that it fixes your issue before merging. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/boostorg/beast/issues/686#issuecomment-318707839, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAMpDx8_GwmhJ3F6Wl3RUmkY6iibxYHks5sShOPgaJpZM4Ol_iT
.

--
Mike

I can easily verify it once it gets to the main repo though.

If I merge it to the develop branch will that be accessible for you?
Thanks

Yes
On Fri, Jul 28, 2017 at 13:01 Vinnie Falco<EMAIL_ADDRESS>wrote:

I can easily verify it once it gets to the main repo though.
If I merge it to the develop branch will that be accessible for you?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/boostorg/beast/issues/686#issuecomment-318748732, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAMpAdQAVhnqusA_8Ul4zodtF7GoFfjks5sSj4ogaJpZM4Ol_iT
.

--
Mike

Merged to develop

I have updated to version 95 and I don't see this assertion anymore. Thanks.


Quick and dirty fix for https://github.com/microsoft/FluidFramework/issues/3619

TL;DR: gifs can't loop - accessibility problem.
See https://github.com/microsoft/FluidFramework/issues/3619 for more details.

@SamBroner @DanWahlin Can one of you take a quick look at this? Is there a better approach? I'd like to merge this in before tomorrow so the autopay issue is resolved by the time we switch back to ASWA.


Support projects inside vercel teams

Here is one more thing:
Retrieving the deploy status does not work if the project is inside a vercel team. Basically the api request to /projects 404s. As per vercel docs one needs to add ?teamId= to the request.
I tried the hacky way and put the whole thing my-project?teamId=my-team-id-423423 into the project name field of this plugin, but that only made the first request working. ;)
For now maybe it would be enough to allow adding a teamId as a setting. Even though that is not user friendly at all since that id is not obvious and needs to be retrieved via api as well.

hey @djfarly, great idea!
Going to tag this as a feature request. I think adding another field to supply the team name slug would be a good solution here. If supplied it will fetch the team ID from the /v1/teams?slug endpoint and send it with the status checks.

@ndimatteo given the solution you outlined above, can I work on the implementation of this? I have a client in need of this feature and I could work on this next week 😄
(As always, great work with the plugin!)

@ndimatteo given the solution you outlined above, can I work on the implementation of this? I have a client in need of this feature and I could work on this next week 😄
(As always, great work with the plugin!)

hey @hdoro for sure, I would love the assist! Feel free to give this a stab and submit a PR 🤘

hey @hdoro for sure, I would love the assist! Feel free to give this a stab and submit a PR 🤘

@djfarly Team support is now live! ✨
Grab the latest version on NPM

Awesome! Thanks @hdoro + @ndimatteo 👍


[red-knot] support type[Any]

The Python type system supports the type[Any] type as a special case of the type[...] special form. This is a gradual type representing some unknown class and all of its subclasses.
Once we have fixed https://github.com/astral-sh/ruff/issues/14544, we should also support type[Any]. This will require updating our representation of SubclassOfType to an enum, so it can store either a Class or just represent type[Any]. This will also require checking each place we handle Type::SubclassOf and updating it to handle the gradual variant correctly.
We should also infer type[Any] from an annotation that just uses bare type, e.g. x: type = ....

I suspect the enum we want here will have the same variants as this one:
https://github.com/astral-sh/ruff/blob/07d13c6b4a9acdfac3fbce314ee50685d0e8df0d/crates/red_knot_python_semantic/src/types/mro.rs#L303
I don't know whether it's worth trying to reuse (and rename?) that one or create another one with the same variants

This seems simple enough. I'll have a PR ready by tomorrow.

Appreciate the interest in contributing! This issue (and a few others) are assigned to me because they are on the ramp up plan for a new Astral team member. If there isn't an unassigned issue that looks interesting to you, I can create some additional ones soon!

We should also infer type[Any] from an annotation that just uses bare type, e.g. x: type = ....

Surfacing from https://github.com/astral-sh/ruff/pull/14876#discussion_r1878322282 that we have decided to interpret bare type as type[object], not type[Any].


Feat: display deployed version

Display deployed version in upper right corner of the map.
Fixes Issue
Closes #44
Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers
My prettier settings are different.

Looks good, just a few small comments


Is it possible to embed an android view in a Godot screen

I have gone through your Gltf app where you are embedding Godot view in an android app. Is the reverse possible? I know this might sound a bit odd. But if you conside my background i don't have my knowledge in Godot but i have decent knowledge in native android development. Suppose for example there is no third part lib for integrating android camera in godot, do you have any idea or a sample repo or docs on how should i go about embedding a native android view in a godot game? I have gone through this but this feels more like intgrating business logic stuff of android in Godot and not embedding UI. Thanks.

@kyadalu1 It was possible in Godot 3 using the GAST plugin, but that functionality has yet to be forward ported in Godot 4.
There's a draft PR to start discussing how it can be brought back to Godot 4 with the goal of trying to have the feature available in the Godot 4.3 release.

Thank you


[Bug] Bumping addon version requires gradle clean to apply correct version

Addons generated during tasks such as :platforms:fabric:runClient do not use the bumped version if they were previously compiled with a different specified version. :common:addons:clean appears to fix this.

this is almost certainly an issue with the gradle configuration
most likely, because the version is not added as an input to whatever task uses it.


macos-12: Remnant symlinks in /usr/local pointing  to macOS frameworks

Description
brew update on macOS should succeed and should not find remnant symlinks in /usr/local pointing back to macOS frameworks.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[X] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Image: macos-12
Version: 20240218.1
Included Software: https://github.com/actions/runner-images/blob/macOS-12/20240218.1/images/macos/macos-12-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/macOS-12%2F20240218.1
Link to build: https://github.com/bscottm/open-simh/actions/runs/8251807984
Is it regression?
Yes. Image: macos-12 Version: 20240218.1 (weirdly, same version, different build date), link: https://github.com/bscottm/open-simh/actions/runs/8183410587
Expected behavior
brew update should succeed and special steps to clear remnant /usr/local symlinks should not be necessary in workflow steps.
Actual behavior
Workflow executes a brew update and installs additional packages (pcre, SDL2 and others.) During the brew update, Python upgrades to 3.12, but fails because there are remnant symlinks in /usr/local. There should be no remnant symlinks in /usr/local pointing to macOS frameworks. Extract from the log:
2024-03-12T15:50:53.4987360Z ==> Pouring<EMAIL_ADDRESS>2024-03-12T15:51:00.4937910Z Error: The `brew link` step did not complete successfully
2024-03-12T15:51:00.4938780Z The formula built, but is not symlinked into /usr/local
2024-03-12T15:51:00.4942560Z Could not symlink bin/2to3
2024-03-12T15:51:00.4943450Z Target /usr/local/bin/2to3
2024-03-12T15:51:00.4944180Z already exists. You may want to remove it:
2024-03-12T15:51:00.4945480Z   rm '/usr/local/bin/2to3'
2024-03-12T15:51:00.4946600Z
2024-03-12T15:51:00.4947680Z To force the link and overwrite all conflicting files:
2024-03-12T15:51:00.4950150Z   brew link --overwrite<EMAIL_ADDRESS>2024-03-12T15:51:00.4950790Z
2024-03-12T15:51:00.4951980Z To list all files that would be deleted:
2024-03-12T15:51:00.4952770Z   brew link --overwrite<EMAIL_ADDRESS>--dry-run
2024-03-12T15:51:00.4953180Z
2024-03-12T15:51:00.4953340Z Possible conflicting files are:
2024-03-12T15:51:00.4954720Z /usr/local/bin/2to3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/2to3
2024-03-12T15:51:00.4958660Z /usr/local/bin/2to3-3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/2to3-3.12
2024-03-12T15:51:00.4961130Z /usr/local/bin/idle3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/idle3
2024-03-12T15:51:00.4963900Z /usr/local/bin/idle3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/idle3.12
2024-03-12T15:51:00.4965790Z /usr/local/bin/pydoc3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/pydoc3
2024-03-12T15:51:00.4967150Z /usr/local/bin/pydoc3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/pydoc3.12
2024-03-12T15:51:00.4969700Z /usr/local/bin/python3 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3
2024-03-12T15:51:00.4972590Z /usr/local/bin/python3-config -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3-config
2024-03-12T15:51:00.4975440Z /usr/local/bin/python3.12 -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12
2024-03-12T15:51:00.4977070Z /usr/local/bin/python3.12-config -> /Library/Frameworks/Python.framework/Versions/3.12/bin/python3.12-config
2024-03-12T15:51:00.4980730Z /usr/local/share/man/man1/python3.1 -><EMAIL_ADDRESS>2024-03-12T15:51:00.4991910Z /usr/local/lib/pkgconfig/python3-embed.pc -><EMAIL_ADDRESS>2024-03-12T15:51:00.4995100Z /usr/local/lib/pkgconfig/python3.pc -><EMAIL_ADDRESS>2024-03-12T15:51:00.5001170Z /usr/local/Frameworks/Python.framework/Headers -><EMAIL_ADDRESS>2024-03-12T15:51:00.5004350Z /usr/local/Frameworks/Python.framework/Python -><EMAIL_ADDRESS>2024-03-12T15:51:00.5008290Z /usr/local/Frameworks/Python.framework/Resources -><EMAIL_ADDRESS>2024-03-12T15:51:00.5013180Z /usr/local/Frameworks/Python.framework/Versions/Current -><EMAIL_ADDRESS>2024-03-12T15:51:02.6557430Z<EMAIL_ADDRESS>-Im ensurepip
2024-03-12T15:51:07.7350290Z<EMAIL_ADDRESS>-Im pip install -v --n

Repro steps
Here is a simplified workflow file that can reproduce the issue:
name: Build

on:
  pull_request:

defaults:
  run:
    shell: bash

jobs:
  makefile:
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        os: [macos-12]
        simulators:
    steps:
      - uses: actions/checkout@v3
      - name: Install dependencies
        run: |
            brew update
            brew install pkg-config
            brew install pcre libpng libedit
            brew install sdl2 freetype2 sdl2_ttf
            brew install vde
            brew install cmake gnu-getopt coreutils

Marking as duplicate of https://github.com/actions/runner-images/issues/9471

Executing brew unlink followed by brew link --overwrite is a losing proposition. One actually has to remove the offending symlinks manually:
run: |
          for f in $(find /usr/local/bin -type l -print); do \
            (readlink $f | grep -q -s "/Library") && echo Removing "$f" && rm -f "$f"; \
          done || exit 0


fix: failing publish stage

use double-quotes instead of single-quotes to allow variable substitution
add backslashes to continue command instead of having multiple in the multiline sh block

@keturn beat me to it 😁 https://github.com/MovingBlocks/Terasology/pull/4791


Option to import tarbar Image

Hey,
I've been thinking about an option to import tarbar Image with archive://.
The rationale behind it is that you might not have access to Docker/Podman on the same node which runs enroot; or maybe there is no Container Registry available.
This way you could develop an Image, podman/docker save imagename > my-image.tar it, copy it to where enroot is and then enroot import archive://home/hans/my-image.tar.
Yes? No? Maybe?
I guess one could also pre-generate the SquashFS for enroot :thinking:

Hm yeah, you mean stitching all the layers back together right?


add quay-operator from OperatorHub to existing quay install

I noticed that there is a quay-operator on openshift operatorhub now.
Is it possible to add it to an existing quay install somehow which been installed with oc create?

Yes. You can follow documentation as described to install items from the OLM
https://docs.openshift.com/container-platform/4.4/operators/olm-adding-operators-to-cluster.html#olm-installing-operator-from-operatorhub-using-cli_olm-adding-operators-to-a-cluster


Adding missing UTF-8 Test

[ ] Cygwin\Cygwin.nuspec
[ ] cyg-get\cyg-get.nuspec
[ ] DotNet4.0\DotNet4.0.nuspec
[ ] rdcman\rdcman.nuspec
[ ] vcredist2015\vcredist2015.nuspec
[ ] wixtoolset\wixtoolset.nuspec

These were found using:
Get-ChildItem C:\github\Organisations\chocolatey\chocolatey-coreteampackages -Recurse -Include *.nuspec |
    ForEach-Object {
        if(-not(Select-String -InputObject $_ -Pattern "UTF-8")){
            Write-Host "Found $_";
        }
    }


Make Envoy::Grpc::AsyncClient mock friendly

After recent revamp of gRPC interfaces it became difficult to mock gRPC clients that use Envoy::Grpc::AsyncClient template. The problem is that interface is not virtual and now requires dependency injection to mock client objects.
Proposal is to make Envoy::Grpc::AsyncClint interface virtual, as there does not seem to be any downside to it.

@yanavlasov can you expand on the difficulty and what you are proposing? Here is an example of mocking:
https://github.com/envoyproxy/envoy/blob/2e03ef24060d479fb825d2d0257a1961f502f08d/test/extensions/filters/common/ratelimit/ratelimit_impl_test.cc#L67
I agree it used to be a bit simpler but it's not too bad now so trying to understand the proposal better. Thank you.

The Grpc::AsyncClient does not have sendRaw method. This has recently changed. Here is the new class.
https://github.com/envoyproxy/envoy/blob/3c42cf460a2710bbe4dc43e72afc456f72411f04/source/common/grpc/typed_async_client.h#L94


change webp sample to use cmake download webp repo

webp sample using gradle sript ( it is a hack ) to download the webp repo.  Gradle and Native side builds are NOT synced so it is source of risk.  Need to use CMake script to download the repo and have native code directly depends it: it will have no confusion between command line and IDE for different behavior anymore.

added PR of https://github.com/googlesamples/android-ndk/pull/378. @jomof please take a look, thanks


Upgrade to NextJS 12

New NextJS version available

Rust Compiler: ~3x faster Fast Refresh and ~5x faster builds
Middleware (beta): Enabling full flexibility in Next.js with code over configuration
React 18 Support: Native Next.js APIs are now supported, as well as Suspense
AVIF Support: Opt-in for 20% smaller images
Bot-aware ISR Fallback: Optimized SEO for web crawlers
Native ES Modules Support: Aligning with the standardized module system
URL Imports (alpha): Import packages from any URL, no installs required
React Server Components (alpha): Try it today, including SSR streaming

Read more https://nextjs.org/blog/next-12

:wave: @ntorsen
Ready for testing in QA again. :smile:


[SPARK-21148] [CORE] Set SparkUncaughtExceptionHandler to the Master

What changes were proposed in this pull request?
Adding the default UncaughtExceptionHandler to the Master as SparkUncaughtExceptionHandler.
How was this patch tested?
I verified it manually, when any of the Master thread gets uncaught exceptions then the default UncaughtExceptionHandler will handle those exceptions.

Can one of the admins verify this patch?

Why do you seprate this from #18357 ?

I thought, we can have discussion at the process level handling if needed.

Let's close this and merge the change with #18357


contour ClusterRoleBinding is duplicated

In https://github.com/knative/net-contour/releases/download/v0.13.0/contour.yaml, ClusterRoleBinding contour is duplicated. This doesn't break kubectl but will trip up tools like helm and kapp.
I believe these should be combined.
# line 1298
apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRoleBinding
metadata:
  name: contour
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: contour
---
# line 2983
apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRoleBinding
metadata:
  name: contour
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: contour
subjects:
- kind: ServiceAccount
  name: contour
  namespace: contour-internal

Fixed!


[BACKPORT #2221] Avoid messing the final binary nuttx.(bin,hex,...) compilation msg

Summary
Backports #2221
Impact
Less shell noise at the end of build.
Testing
CI

@acassis I figured you would probably like to see this on the 10.0.0 release.


Fixed issue with skipping first note, progress counter not starting until 2nd note played, and added end of song callback

Hey @silverhawk184 ! I was trying to use your fixed branch but it is not working. I tried running the gruntfile and it contains outdated paths (polyfill instead of shim). Even when changing the paths and adding missing files, the build doesn't play any sound. It would be nice to have a version that installs like npm install midi.js to just require the module. I've been waiting for this fix for a long time and I got exited for a minute. I wish I had the time to understand the library to make the updates myself. I hope you are able to find a fix. Thanks

Hi ,@silverhawk184 I replaced your player.js to the original one , there is still a looping bug when playing the midi file

@silverhawk184 sorry, I downloaded to worry version, but the bug skiping the first chord still exist, eventually,to all guys who met this bug: I copied the module in the author's personal project https://galactic.ink/piano/min/app.js  (search the keywords Player),it works well.


UAT(User Acceptance Testing): Selenium

http://www.seleniumhq.org/

wait until we have web portal

use autohotkey to be a semi-automatic user acceptance testing for chatbot.


Error linting official Arazzo examples

From version 1.20.0 the linter reports errors when linting the official Arazzo specification examples from their github

https://raw.githubusercontent.com/OAI/Arazzo-Specification/main/examples/1.0.0/LoginAndRetrievePets.arazzo.yaml
https://raw.githubusercontent.com/OAI/Arazzo-Specification/main/examples/1.0.0/bnpl-arazzo.yaml

Either the examples are wrong according to the specification or the linter is wrong, but I cannot determine which.
To Reproduce
Steps to reproduce the behavior:

redocly lint https://raw.githubusercontent.com/OAI/Arazzo-Specification/main/examples/1.0.0/bnpl-arazzo.yaml
redocly lint https://raw.githubusercontent.com/OAI/Arazzo-Specification/main/examples/1.0.0/LoginAndRetrievePets.arazzo.yaml

Gives 13 errors of the type
validating https://raw.githubusercontent.com/OAI/Arazzo-Specification/main/examples/1.0.0/bnpl-arazzo.yaml...
[1] https://raw.githubusercontent.com/OAI/Arazzo-Specification/main/examples/1.0.0/bnpl-arazzo.yaml:14:13 at #/workflows/0/inputs/type

Expected type `Schema` (object) but got `string`

12 | description: Describes the steps to secure a loan at checkout from a BNPL platform. It is a multistep process that require...<61 chars>
13 | inputs:
14 |     type: object
15 |     required:
16 |     - customer

Error was generated by the spec rule.

Expected behavior

If the official Arazzo examples are correct I would expect no errors.
Logs
OpenAPI description

The examples are Arazzo 1.0.0
Redocly Version(s)
1.21.0
Node.js Version(s)
v18.17.1

Thanks for letting us know @javaguruen! The fix is already in review and should be available in the next version (I anticipate it the next week).
FIY @DmitryAnansky

Released in v1.22.0.
@javaguruen FYI


git assignment #2

Looks like you made both commits on same branch instead of parallel. All good otherwise.


Rancher thinks container is still starting when using drbdmanage, however container is actually running already.

Rancher Versions:
Server: 1.3.4
healthcheck: 0.2.0
ipsec: 0.8.1
network-services: 0.4.0
scheduler: 0.5.1
kubernetes (if applicable): n/a
Docker Version: 1.12.6
OS and where are the hosts located? (cloud, bare metal, etc): Ubuntu 16.04, VM on local hardware
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB) single node rancher, internal db.
Environment Type: (Cattle/Kubernetes/Swarm/Mesos) Cattle
Steps to Reproduce:

Set up two DRBD9 nodes and set them up properly
Create a docker volume using the drbdmanage plugin
Start (in this case) a simple wordpress container on host A using the drbdmanage volume driver.
Shutdown host A, Rancher will reschedule to host B
Wordpress container on host B keeps in starting state, according to rancher. The container is actually already started and wordpress works.

The container does fully start in rancher when removing the drbdmanage volume driver, however, the container is actually started.
Results:
Rancher thinks the wordpress container is still starting (status in stack is: (Waiting: container starting [container:1i23977])
From docker logs:
root@bravo:~# docker logs 3462a918bcab
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using <IP_ADDRESS>. Set the 'ServerName' directive globally to suppress this message
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using <IP_ADDRESS>. Set the 'ServerName' directive globally to suppress this message
[Sun Feb 12 10:49:35.042728 2017] [mpm_prefork:notice] [pid 1] AH00163: Apache/2.4.10 (Debian) PHP/5.6.30 configured -- resuming normal operations
[Sun Feb 12 10:49:35.042772 2017] [core:notice] [pid 1] AH00094: Command line: 'apache2 -D FOREGROUND

Doing a simple cURL to the IP address above:
root@bravo:~# curl <IP_ADDRESS>
<!DOCTYPE html>
<html lang="en-US">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=0">
<title>admin | Just another WordPress site</title>

The rancher logs:
java.lang.IllegalStateException: More than one volume exists for volume URI [drbdmanage:///run/docker/drbdmanage/mnt/wordpress] or name/externalId [wordpress] and storage pool [57].
	at io.cattle.platform.docker.process.dao.impl.DockerComputeDaoImpl.getDockerVolumeInPool(DockerComputeDaoImpl.java:54)

Docker volumes
root@bravo:~# docker volume ls
DRIVER              VOLUME NAME
local               b597c5fe6e43aa2e27a4836876baad35e584a977992a2e2b24cdfa8c53a1cd3e
local               cc251135792de71426e350aa45af5644f7b27bcda4750e63c19e80911072b94e
drbdmanage         mariadb
drbdmanage         wordpress
local               rancher-agent-state
local               rancher-cni
local               rancher-cni-driver

drbdmanage list-volumes
root@bravo:~# drbdmanage list-volumes
+------------------------------------------------------------------------------------------------------------+
| Name                    | Vol ID |    Size | Minor |                                               | State |
|------------------------------------------------------------------------------------------------------------|
| mariadb   |      0 |   1 GiB |   101 |                                               |    ok |
| wordpress |      0 | 200 MiB |   100 |                                               |    ok |
+------------------------------------------------------------------------------------------------------------+

I'm experiencing the same thing with the Portworx catalog service.
version: '2'
volumes:
  testvol:
    external: true
    driver: pxd
services:
  busybox:
    image: busybox
    stdin_open: true
    volumes:
    - testvol:/testvol
    tty: true
    labels:
      io.rancher.container.pull_image: always

Looks like Rancher is automatically setting external: true in the volume configuration. When I created a stack from compose.yml v2, and set external: false, the container starts successfully, and Rancher shows it as healthy.

Please let us know in a comment if you can still reproduce the issue, and we'll reopen it


Why is there a dropout layer behind GraphConvolution layer?

Hi, I successfully ran the code and I find the function dropout() behind the function GraphConvolution(). However after checking the technical articles and blogs, I find that dropout() is usually used after fully connected layers, so is it really better than BatchNormalization  function in the model?

this is explored in detail in this paper: http://snap.stanford.edu/gnn-design/


Adding YX5300

Description

Adding YX5300, migration from nf-Community-Contriburtion
Motivation and Context

Fixes/Closes/Resolves nanoFramework/Home#NNNN

How Has This Been Tested?

Need to be tested on a real device.
Screenshots
Types of changes

[x] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[ ] Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@hbraasch for your visibility and review. We are moving code based drivers, sensors, and other bindings from nf-Community-Contribution to this new nanoFramework.IoT.Device repository with nuget creation as a bonus.


Temperature minimum value

Validations

[X] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[ ] I'm not able to find an open issue that requests the same enhancement

Problem
Hi,
I can not set a temperature of 0.001 for instance, as the step of the slider is 0.1 and I can set a temperature of 0 which is an invalid value
Solution
No response

@pechaut78 OpenAI allows 0 as a value. While it's possible they are converting this to a small number to avoid the $e^{-1/T}$ division by zero, I think it is fairly common for users to want to just set it to zero without thinking about this. Are you running into a problem with a provider that throws an error on a value of zero?
As far as the 0.001, we have to set the step limit somewhere and two decimal places seems like the most natural place. If you want to use a more fine-grained value, you can set this through the config file. (which, as of the latest pre-releases, will be in ~/.continue/config.json)


Kokoro builds are failing some new presubmit checks

E.g. for #259, see below. @nolanmar511 please talk to @JustinBeckwith on how to fix these.

Also cc/ @kinwa91.
I'm guessing these tests may have started running prematurely because we have a webhook setup for our e2e kokoro test.

@kinwa91 Did you have a chance to look at it? I am removing @nolanmar511 from assignees for now.

I had a CL to disable these. I'll try to get it in.

We've removed the internal Kokoro configs that caused these tests to be run before they were ready to be run.
Closing this, since these tests are no longer running.


raw editor no longer visible, plugin version 1.1.0

On a particular dashboard (not universally), I can no longer edit a raw query:

This happens on any instance of the BQ plugin on this particular dashboard. Clearing local cache does not help.
Grafana v8.3.3

Correction, this error is appearing on multiple dashboards.

A hard reload appears to have fixed it for now.

@jermudgeon Looking at your screenshot it seems like you are trying to use https://github.com/doitintl/bigquery-grafana/.


Change the style of Alert box.

-I have change the style of alert box making it more appealing then before. please look into it.-

My issue number was #175

Good Work @Nehayp21242929


intermittent errors with mo.mpl.interactive(plt.gcf())

Describe the bug
When reloading a large (50 cells, 30 second total execution time) notebook, I often find cells that have error output. When I re-run the cells, they work fine. An example of the error output is pasted below
A0>
Traceback (most recent call last):
  File "C:\Users\user\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\marimo\_plugins\stateless\mpl\_mpl.py", line 158, in send
    await websocket.close()
  File "C:\Users\user\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\starlette\websockets.py", line 203, in close
    await self.send(
  File "C:\Users\user\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\starlette\websockets.py", line 112, in send
    raise RuntimeError('Cannot call "send" once a close message has been sent.')
RuntimeError: Cannot call "send" once a close message has been sent.
Exception ignored in: <coroutine object create_application.<locals>.websocket_endpoint.<locals>.send at 0x000002058F1F46D0>
Traceback (most recent call last):
  File "C:\Users\user\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\marimo\_plugins\stateless\mpl\_mpl.py", line 158, in send
    await websocket.close()
  File "C:\Users\user\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\starlette\websockets.py", line 203, in close
    await self.send(
  File "C:\Users\user\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\starlette\websockets.py", line 112, in send
    raise RuntimeError('Cannot call "send" once a close message has been sent.')
RuntimeError: Cannot call "send" once a close message has been sent.

Environment
{
"marimo": "0.7.9",
"OS": "Windows",
"OS Version": "11",
"Processor": "Intel64 Family 6 Model 142 Stepping 10, GenuineIntel",
"Python Version": "3.12.4",
"Binaries": {
"Browser": "--",
"Node": "--"
},
"Requirements": {
"click": "8.1.7",
"importlib-resources": "missing",
"jedi": "0.19.1",
"markdown": "3.6",
"pymdown-extensions": "10.8.1",
"pygments": "2.18.0",
"tomlkit": "0.13.0",
"uvicorn": "0.30.3",
"starlette": "0.38.0",
"websockets": "12.0",
"typing-extensions": "4.12.2",
"ruff": "0.5.4"
}
}
also possibly relevant:
matplotlib         3.9.1
matplotlib-inline  0.1.7
Code to reproduce
I haven't been able to reduce this to a reproducible example. My best guess is that it can happen in any cell that ends with mo.mpl.interactive(plt.gcf()) and has something to do with timing and whether is on screen of off screen at certain times.

It may be that mo.mpl.interactive(plt.gcf()) is re-rendering and the connection is closed while the backend is sending something. This is often a race-condition that can actually be ignored/caught.

Most if not all of the time the plot has appeared and the ui on the plot for zooming is responsive, even when this error appears. Also this error does not increase the error counter in the lower left.
I'm pretty sure I saw it once on a cell without mo.mpl.interactive(plt.gcf()) but I haven't been able to reproduce it.

Yea - I think it is just noise in that case. We basically try to close and already closed websocket. I added a check here: https://github.com/marimo-team/marimo/pull/1861


Unable to get focus on Modal popup

while default or native focus is working in modal
Modal should be inside a screen
Please Help me

Hey, can you detail what kind of modal you're working with?
If you're working with a native modal, you can lock our custom spatial navigation while the modal is open by using useLockSpatialNavigation https://github.com/bamlab/react-tv-space-navigation/blob/main/docs/api.md#uselockspatialnavigation

I need to show the modal for Player setting button like subtitle, multi-audio, resolution, etc.
I also want to ask one thing, why after using this library touchable opacity onPress event is not working?

actually, i am developing app for all platforms like TV, web, and mobile

Well, having a gradient is not this lib's responsibility so I can help but this would be totally unrelated 😄
Feel free to share some code if you wan't some ideas.
I'm closing this issue and open a feature request in a different one for the sake of clarity.

I need to show the modal for Player setting button like subtitle, multi-audio, resolution, etc.

It's something in the backlog, we have no clear recommendation on how to do a modal for now. It's totally possible but we should show an example.
For now, you can probably use
<SpatialNavigationRoot isActive={isModalOpen ? false : true}>
  {/* ... your layout */}
  <View />

  {/* you can nest another spatial navigation root when your modal is open, it should work but I haven't tried */}
  {isModalOpen && (
    <SpatialNavigationRoot>
      {/* your modal layout... */}
    </SpatialNavigationRoot>
  )}
</SpatialNavigationRoot>

I also want to ask one thing, why after using this library touchable opacity onPress event is not working?
Maybe we should clarify this in the README.

This library totally bypasses the native focus. The whole point is to have our own focus system made purely in React (no React Native involved in the core of the lib) so that we don't rely on anything native. The whole point is to have the exact same behaviour on web, tvOS and AndroidTV.
So, we don't use TouchableOpacity, and using some will mess up with the lib as you will mix up native focus and custom focus 😉

I have used your suggestions but focus still present on parent screen

We have a complete modal example coming up 😉
It's still WIP but it's working.
You can check it out and compare with your code:
https://github.com/bamlab/react-tv-space-navigation/pull/59

@pierpo can you let me know how to use it (const { lock, unlock } = useLockSpatialNavigation();) in class base component in react native


[BACKLOG-20936] - stream source needs to be closed when stopped via a…

…bort step

Test will be committed to big-data-plugin

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStep.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.3% :small_red_triangle_down:
Line Change: -3.9% :small_red_triangle_down:

org.pentaho.di.trans.step.RunThread

Branch Change: -1.9% :small_red_triangle_down:
Complexity Change: -3.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -1.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -0.5% :small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStep.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.step.BaseStep

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.5% :small_red_triangle_down:
Line Change: -0.7% :small_red_triangle_down:
Method Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.step.StepStatus

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -1.6% :small_red_triangle_down:
Instruction Change: -1.4% :small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

@pentaho/ackbar please review


conmon: close extra files before exit

Podman will inject fd's into conmon so that open TCP/UDP ports will be
kept busy while the container is running.  This introduces a race
condition as conmon could notify the container exited but these fd's
are still kept busy.  Close them before notifying the container
exited.
Required by: https://github.com/projectatomic/libpod/pull/1100
Signed-off-by: Giuseppe Scrivano<EMAIL_ADDRESS>- What I did
close extra fd's before conmon terminates
- How I did it
cycle through the fds 3-... until we find an unused fd
- How to verify it
strace conmon and verify there are a bunch of close(..) before it exits
- Description for the changelog
conmon closes extra files before it exits

LGTM
Would this cause any issues with SocketActivation?

LGTM
/test all

Would this cause any issues with SocketActivation?

There should be no difference.  The Socket Activation fds were already propagated and used by the  OCI runtime that at this time is already terminated.

/test all

We should backport this to 1.11 and 1.10

@mrunalp this is useful only for podman, do we still need the backport?


Java fuzzer can't create any values for types with no public constructor (e.g. LocalDateTime)

Description
When creating instances of arbitrary classes Java fuzzer only considers their accessible constructors. However, some classes (e.g. LocalDateTime) only have private constructors while their instances are meant to be created using static methods.
Real world (concrete) example
Same as in #2428
To Reproduce
Run the following unit test.
@Test
fun `fuzzer can create instances of classes without public constructors but with static factory method in their class`() {
    var seenLocalDateTime = false
    runBlockingWithContext {
        try {
            runJavaFuzzing(
                TestIdentityPreservingIdGenerator,
                methodUnderTest = LocalDateTime::getMinute.javaMethod!!.executableId,
                constants = emptyList(),
                names = emptyList(),
            ) { thisInstance, _, _ ->
                val control = runCatching {
                    ValueConstructor()
                        .construct(listOfNotNull(thisInstance?.model))
                        .singleOrNull()?.value
                }.getOrNull()?.let { constructedThisInstance ->
                    assertInstanceOf(LocalDateTime::class.java, constructedThisInstance)
                    seenLocalDateTime = true
                    Control.STOP
                } ?: Control.PASS
                BaseFeedback(Trie.emptyNode(), control)
            }
        } catch (e: Throwable) {
            e.printStackTrace()
        }
    }
    assertTrue(seenLocalDateTime) { "No value was generated for type LocalDateTime" }
}

Expected behavior
Test passes.
Actual behavior
Test fails.
Visual proofs (screenshots, logs, images)
No value was generated for type LocalDateTime ==> expected: <true> but was: <false>

@IlyaMuravjov
Could you please explain expected and actual behavior more in detail?
Here it is expected to use LocalDateTime static methods to instantiate it.


Add worker and xo-helper

This has been working really well for me during testing.
The ava/no-import-test-files rule is working, and no longer creating errors about Node not supporting Workers. Fixes #108
The TypeScript performance is significantly better too! Less than a second vs the 10, 20, or 30 seconds I was seeing before 🎉 Fixes #104

Nice work! Let me know when I should do a new release.

Thanks, I appreciate the feedback. I have a local branch with some tests for worker.js.
I'll also take a look at using window.requestIdleCallback


How to present replacing navigation stack?

Is there any best practice to implement navigations like an onboarding flow, where the navigation stack optionally contains another root and is then later replaced without animations after completing the onboarding?

You can just switch the active Coordinators and initiate the one after the onboarding with the InitialPresenter. Something like following example shows:
 // NOTE: Make sure the other onboarding coordinator is stopped successfully before switching

    appState.loginState()
            .removeDuplicates()
            .sink { [weak self] isLoggedIn in
                if isLoggedIn {
                    self?.showMainCoordinator(on: window)
                } else {
                    self?.showOnboarding(on: window)
                }
            }
            .store(in: &cancellables)
    }

    private func showMainCoordinator(on window: UIWindow) {
        activeRootCoordinator = TabCoordinator(presenter: InitialPresenter(window: window))
        activeRootCoordinator?.start()
    }

    private func showOnboarding(on window: UIWindow) {
        activeRootCoordinator = OnboardingCoordinator(presenter: InitialPresenter(window: window))
        activeRootCoordinator?.start()
    }

An alternative could be to create an AppCoordinator which is handling the app flow. The Coordinator tree could then look like:
-> AppCoordinator - isLoggedIn -> MainCoordinator or OnboardingCoordinator
You can then stop the OnboardingCoordinator and then override:
    override func didStop(child: Coordinator) {
        <#code#>
    }

to check if your Onboarding has been stopped or use a callback to the AppCoordinator

But how do we actually replace / swap presenter content?


Accordian Component for Magic UI

Is your feature request related to a problem? Please describe.
This feature request is an addition to the MagicUI library of components
Describe the solution you'd like
I have a component at https://prompt-a-thon.vercel.app/ which takes various inputs and props as speed, opacity and other things. I am thinking of adding this component to magic ui after making it more better.
Describe alternatives you've considered
N/A
Additional context
Please visit https://prompt-a-thon.vercel.app/ to see the accordian component, it does not look very well in design and can be improved.

Hi!
Thanks for bringing this to our attention. I think this component is outside the scope of Magic UI for now since Magic UI is solely focused on making components for landing pages. Perhaps might be a better fit in the future if we update our scope!

Dillion


Unexpected token ','

Environment

Dev OS: [Mac OS monterey]

Steps to reproduce
Issue on IOS simulator.
Followed the installation guide from the docs. When I add an import statement (import MapboxGL from '@rnmapbox/maps';) I get this error and I can not figure out why.
$RNMapboxMapsImpl is set to  'mapbox' at the top of my podfile. I also added to my podfile folowing strings:
`pre_install do |installer|
$RNMapboxMaps.pre_install(installer)
end
post_install do |installer|
$RNMapboxMaps.post_install(installer)
end`
Pods are being installed and app builds successfully but this is all I get. I definitely did not put extra ',' somewhere

@qeorqe-codes sorry not enough info to reproduce closing. Most likely and old typescript/babel issue.

I just got the same thing. With less even less info. Using Expo 47.

@alfredvaa @qeorqe-codes Did you guys got the solution for this ?

@harishgupta01 no, i switched to react-native-maps instead.

@alfredvaa Actually just now i found the solution. My react native app is written in JS but rnmapbox in typescript. After adding preset-typescript as below fixes the issue.
Babel.config.js
module.exports = {
  presets: ['@babel/preset-typescript', 'module:metro-react-native-babel-preset']
};

package.json
"devDependencies": {
    "@babel/core": "^7.16.12",
    "@babel/preset-typescript": "^7.22.15",
....


Keep connection open

Hi,
I have question regarding the capability of this library. Does this library works for Http Streaming connections?
Currently, I'm using a solution with fockopen and while($feof($fp)) to wait until server closes the connection or timeout.

This library helps with establishing a TCP/IP connection and then returns a Stream which you can use to pipe any kind of data through. It's entirely up to you to "keep the connection open".
If you're looking for a HTTP client library, you may want to look into using the HttpClient component. It does support HTTP streaming, however it does not currently support HTTP connection reuse (Connection: keep-alive). PRs are welcome, I suppose? :+1:
I hope this helps! :+1:


Updating the mailto links on the careers page

I was applying for a job and the spaces in the mailto were adding %20 into the email address when copy/pasting from the link.

Good catch!


Using tor?

What would it take or how hard is it to add functionality to use this with TOR?

Never mind, I found an example for it: https://github.com/request/request/tree/master/examples


Some past student profiles are displaying twice

this is currently visible on the students page with Deborah and Phil's profiles, of which there are two.
dev notes
this appears directly related to the known bug around logic for queryset annotations with Greatest(). the notes already in the code for this method say:
        # show most recent first based on grant or position end date
        # NOTE the use of Case/When here is to avoid Greatest() returning NULL
        # if any of its arguments are NULL, which is mysql behavior:
        # https://docs.djangoproject.com/en/2.2/ref/models/database-functions/#django.db.models.functions.Greatest
        # see also the django docs on conditional aggregation:
        # https://docs.djangoproject.com/en/1.11/ref/models/conditional-expressions/#conditional-aggregation
        # NOTE also that this causes dates to be interpreted as strings in QA;
        # relevant ticket: https://code.djangoproject.com/ticket/30224

and indeed, removing the annotation causes the duplicate profiles to disappear. meanwhile, using .distinct() does not remove the duplicates as long as the annotation is present.

waiting to see if switching postgres magically resolves this one.

tested and fixed in 3.0 as part of #267.


Added ICMP support

I have made some changes to the mitmproxy_rs codebase that address an issue where ICMP pings were being swallowed, causing some applications to believe that there is no network connectivity. My changes add support for forwarding ICMP echo replies, which should cover the majority of use cases.
I have added comments throughout the code to explain my changes, and I have also added a new function forward_icmp_echo_reply that handles forwarding the ICMP echo replies. Additionally, I have modified the receive_packet function to handle ICMP packets and call the forward_icmp_echo_reply function when necessary.
I believe that these changes will improve the functionality of mitmproxy_rs and make it more reliable for users. Please review my changes and let me know if there are any concerns or suggestions for further improvements

Did you use ChatGPT to author this patch and the PR description?
The code has syntax errors and calls methods that do not exist.


macOS toolchains do not work with Xcode new build system

Various errors occur using Swift for TensorFlow macOS toolchains with Xcode's new build system:

The cause is that the Version string in Info.plist provided in toolchains cannot be parsed by Xcode:
$ /Applications/Xcode.app/Contents/MacOS/Xcode Foo.xcodeproj
2019-12-24 15:47:16.618 XCBBuildService[75398:12495542] /Library/Developer/Toolchains/swift-tensorflow-DEVELOPMENT-2019-12-12-a.xctoolchain: warning: failed to load toolchain: 'Version' parse error: Could not parse version component from: 'swift-tensorflow-DEVELOPMENT-2019-12-12-a

This is an issue in the open source utils/build-toolchain script. Someone discovered this issue on the forums but didn't submit a fix.

Fixed in https://github.com/apple/swift/pull/28945.
New macOS toolchain released: https://storage.googleapis.com/swift-tensorflow/mac/swift-tensorflow-DEVELOPMENT-2019-12-23-a-osx.pkg


HubViewController as protocol

@cerihughes and I discussed the fact that subclassing HubViewController in order to define a contract (i.e. act as a protocol) was a bit strange.
The argument against it was that Swift will look at UIViewController as just a UIViewController and there will be lots of casting in the Swift code.
That's true (for now).
However,  Swift looks at id as a HubViewController protocol.
Going with this approach, there's only one line of casting in the Swift code and that's only to make UIKit happy. I think that's acceptable.

... but if we do create a protocol for the VC (there are still other cases where it's easier if it's a concrete class), we'd want to expose this in the API as UIViewController<HUBViewController> *, not id<HUBViewController>.
I think we should get to a point where we're not experimenting so much with different VC implementations and then look at whether using a protocol in the API is feasible.
For now, let's keep it as it is.

@marmelroy @cerihughes With Swift 4 it’ll be possible to expose and use types as UIViewController<HUBViewController>. So “all” will be good in about 6 months time.

@rastersize, can't wait :)