ardana: Increase inactivity timeout even further

When init.yml is running site.yml there is not log activity for a very
long time, which cause the jenkins job to timeout for the larger models.
In the mid term we need to find a better solution here. This should be
considererd a temporary fix to address the immediate issue of all jobs
timeing out.

IIRC I asked the Ansible crowd (or maybe just you guys) if there was any way to get partial output from each task as it's executing rather than Ansible capturing it all and outputting in one go once the task completes, but apparently Ansible doesn't work that way :-/

in mkcloud's function wait_for we added regular printing of line breaks to help jenkins see progress and does not abort too early. Maybe we could create+use a wrapper to ansible doing something similar?

IIRC I asked the Ansible crowd (or maybe just you guys) if there was any way to get partial output from each task as it's executing rather than Ansible capturing it all and outputting in one go once the task completes, but apparently Ansible doesn't work that way :-/

Yeah, that's also what I found when digging a bit through the ansible issue tracker (e.g. request like: https://github.com/ansible/ansible/issues/3887 ).
Making the site.yml call an "async" task might help a bit with the timeout issue, though. I am currently experimenting with that.

in mkcloud's function wait_for we added regular printing of line breaks to help jenkins see progress and does not abort too early. Maybe we could create+use a wrapper to ansible doing something similar?

There is async and async_status in ansible but that will also only print something like "<job 312434234> polling on host123, 36001s remaining".  Which would allow us to decrease the timeout again, but still doesn't get us the in progress log of the site.yml task, in the end that is not much of an improvement I think.

here is async and async_status in ansible but that will also only print something like "<job 312434234> polling on host123, 36001s remaining"

Actually the ansible version (2.x) we have on the ci work doesn't event print that anymore for async task. That was an ansible 1.x thing which got reworked since then (https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/callback/init.py#L332  )


[WIP] Replace evm-watchdog with vmdb-up

The evm-watchdog process was responsible for starting evmserverd if it wasn't running once the database was ready.  This was critically important when using init.d since if the service crashed it wouldn't be automatically restarted.
The systemd Restart=on-failure mode fixes this issue, leaving the "wait for the database to be ready" stage.
This can be accomplished with a dedicated service that acts as a dependency for the evmserverd service and marks itself as ready once it is able to access vmdb.
# systemctl stop postgresql

Sep 03 12:09:15 manageiq.rb.nj.grare.com systemd[1]: Stopping PostgreSQL database server...
Sep 03 12:09:15 manageiq.rb.nj.grare.com systemd[1]: postgresql.service: Killing process 18967 (postmaster) with signal SIGKILL.
Sep 03 12:09:15 manageiq.rb.nj.grare.com systemd[1]: postgresql.service: Succeeded.
Sep 03 12:09:15 manageiq.rb.nj.grare.com systemd[1]: Stopped PostgreSQL database server.

# systemctl start evmserverd.
Sep 03 12:09:25 manageiq.rb.nj.grare.com systemd[1]: Starting VMDB Up Target...
Sep 03 12:09:25 manageiq.rb.nj.grare.com vmdb-up[19404]: localhost 5432 - not accepting connections
Sep 03 12:09:35 manageiq.rb.nj.grare.com vmdb-up[19404]: localhost 5432 - not accepting connections

# systemctl start postgresql

Sep 03 12:09:36 manageiq.rb.nj.grare.com systemd[1]: Starting PostgreSQL database server...
Sep 03 12:09:36 manageiq.rb.nj.grare.com postmaster[19414]: 2021-09-03 12:09:36 EDT::613248c0.4bd6:@:[19414]:LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
Sep 03 12:09:36 manageiq.rb.nj.grare.com postmaster[19414]: 2021-09-03 12:09:36 EDT::613248c0.4bd6:@:[19414]:LOG:  listening on IPv6 address "::", port 5432
Sep 03 12:09:36 manageiq.rb.nj.grare.com postmaster[19414]: 2021-09-03 12:09:36 EDT::613248c0.4bd6:@:[19414]:LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
Sep 03 12:09:36 manageiq.rb.nj.grare.com postmaster[19414]: 2021-09-03 12:09:36 EDT::613248c0.4bd6:@:[19414]:LOG:  listening on Unix socket "/tmp/.s.PGSQL.5432"
Sep 03 12:09:37 manageiq.rb.nj.grare.com postmaster[19414]: 2021-09-03 12:09:37 EDT::613248c0.4bd6:@:[19414]:LOG:  redirecting log output to logging collector process
Sep 03 12:09:37 manageiq.rb.nj.grare.com postmaster[19414]: 2021-09-03 12:09:37 EDT::613248c0.4bd6:@:[19414]:HINT:  Future log output will appear in directory "log".
Sep 03 12:09:37 manageiq.rb.nj.grare.com systemd[1]: Started PostgreSQL database server.

Sep 03 12:09:45 manageiq.rb.nj.grare.com vmdb-up[19404]: localhost 5432 - accepting connections
Sep 03 12:09:59 manageiq.rb.nj.grare.com vmdb-up[19404]: VMDB is up and running
Sep 03 12:09:59 manageiq.rb.nj.grare.com systemd[1]: vmdb-up.service: Succeeded.
Sep 03 12:09:59 manageiq.rb.nj.grare.com systemd[1]: Started VMDB Up Target.
Sep 03 12:09:59 manageiq.rb.nj.grare.com systemd[1]: Starting EVM server daemon...
Sep 03 12:10:15 manageiq.rb.nj.grare.com manageiq[19450]:  INFO -- evm: MIQ(EvmApplication.start) EVM Startup initiated
Sep 03 12:10:19 manageiq.rb.nj.grare.com sh[19440]: Starting EVM...
Sep 03 12:10:19 manageiq.rb.nj.grare.com sh[19440]: Running EVM in background...
Sep 03 12:10:19 manageiq.rb.nj.grare.com systemd[1]: Started EVM server daemon.

TODO

[x] Replace cd /var/www/miq/vmdb; bin/rails r "require './lib/tasks/evm_application'; puts EvmApplication.server_state" with a lighter weight option
[x] Update appliance-console to systemctl enable evmserverd when starting the application (This was already done, it did .start(true) which is why I missed it)
[x] Update rpm install systemctl restart evmserverd if it is running (https://github.com/ManageIQ/manageiq-rpm_build/pull/185)

@bdunne Please also review.

Forgot to take this out of WIP after dependent PR (https://github.com/ManageIQ/manageiq-rpm_build/pull/185) was merged


Not receiving verification emails from Test PyPI

I'm attempting to register on Test PyPi , but I'm not receiving the verification e-mails. I've tried different e-mail addresses, but still no luck.

Can you provide any of the emails you've tried?

I have the same problem with the following details:
username: essamwisam
primary email<EMAIL_ADDRESS>secondary email<EMAIL_ADDRESS>Note that when I signed up on PyPI I received the verification email immediately, this is a problem with test PyPI.

Thanks. I can confirm that I see no email activity for those addresses. We'll look into it.

Looks like our job queue is backed up due to a different task repeatedly failing, causing emails to be delayed. We disabled it and increased the # of workers, this should resolve shortly.

Received it indeed, thanks a lot.

This should be resolved now.


PIIX3 configuration error

Virtualbox error-
PIIX3 configuration error: "FirmwareRevision" is longer than 8 bytes (VERR_INVALID_PARAMETER).
sh file error -
VBoxManage setextradata "$1" VBoxInternal/Devices/piix3ide/0/Config/PrimaryMaster/ModelNumber	' HDIO_GET_IDENTITY failed: Invalid argument'
VBoxManage setextradata "$1" VBoxInternal/Devices/piix3ide/0/Config/PrimaryMaster/FirmwareRevision	' HDIO_GET_IDENTITY failed: Invalid argument'
else
VBoxManage setextradata "$1" VBoxInternal/Devices/ahci/0/Config/Port0/ModelNumber	' HDIO_GET_IDENTITY failed: Invalid argument'
VBoxManage setextradata "$1" VBoxInternal/Devices/ahci/0/Config/Port0/FirmwareRevision	' HDIO_GET_IDENTITY failed: Invalid argument'
fi

python-dmidecode 3.12.2-2
python 2.7.12
Virtualbox 5.1.22 r115126 (Qt5.5.1)
elementary OS 0.4.1 Loki
antivmdetection -from git

Hi @devwhatsapp Let's see if I can help you out.
What type of hardware are you using? (Server with RAID etc)
I did resolve a similar issue in the latest release:
https://github.com/nsmfoo/antivmdetection/issues/15

Home PC
Gigabyte motherboard
HDD Samsung
On Thu, Jun 22, 2017 at 1:16 PM, Mikael Keri<EMAIL_ADDRESS>wrote:

Hi @devwhatsapp https://github.com/devwhatsapp Let's see if I can help
you out.
What type of hardware are you using? (Server with RAID etc)
I did resolve a similar issue in the latest release:
#15 https://github.com/nsmfoo/antivmdetection/issues/15
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nsmfoo/antivmdetection/issues/18#issuecomment-310303054,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATJP4BPzRWZQMcJBpTz5ZhEbcj3DXODZks5sGhvngaJpZM4OA3Ud
.

Late reply, busy celebrating midsummer =)
So, do you have a device called /dev/sda ? If so what does the output of the following command give you: hdparm -i /dev/sda ?

No issues , we should always celebrate whats need to
Output of hdparm -i /dev/sda
/dev/sda:
HDIO_GET_IDENTITY failed: Invalid argument

Found the culprit.
It was an external HDD which was connected and taking the place of /dev/sda
Now removed it and the script works.
Thank you

Great that you were able to solve the issue!
I will look into it, if there is a nifty way to create such a check I will add it.
If you run into any other issues or have questions, just let me know!


17.2 In the package in which I am facing the problem 302 status, I send the request or delete the error value, this is a problem facing

For bug reporting only! If you're posting a feature request or discussion, please ignore.
Expected Behavior
Please describe the behavior you are expecting.
Current Behavior
Please describe the current behavior?
Failure Information
Please help provide information about the failure if this is a bug.
Steps to Reproduce
Please provide detailed steps for reproducing the issue.

Package Version: 17.2
Laravel Version: 8.0
PHP Version: 7.2.5
Using a toolset (Docker, Laradock, Vagrant, etc.):

Failure [Logs](### url)
Please include any relevant log snippets or files here.

Can you provide code of your routes etc, did you have the middleware on them?

@faisalaltaf can you provide more information please, code snippets etc as it is hard to debug with just that screenshot at the moment.

Closing as stale now.


Unable to Deregister Existing Locations in New Catalog Backend

After updating to the new Catalog Backend, any existing locations (registered in the legacy Catalog Backend) cannot be unregistered.  If registering a new component via the new Catalog Backend, the new location can be unregistered without any issues.
Expected Behavior

Should be able to unregister existing locations after upgrading to the new Catalog Backend.
Current Behavior

The below popup appears on the screen:

Possible Solution

Steps to Reproduce

Have a Component registered via legacy Catalog
Update the catalog.ts per https://github.com/backstage/backstage/releases/tag/release-2021-06-17
Attempt to unregister Component

I am able to reproduce by simply reverting the catalog.ts to use the legacy new CatalogBuilder(env) pattern and register a new component (no need to revert the library version).  When running in legacy mode, I am able to unregister components created in both legacy and "next" CatalogBuilder.
As soon as I update to the await CatalogBuilder.create(env) pattern, I receive the error when trying to unregister components created in Legacy, but have no problems unregistering components created in the "next" pattern.
Context

With our development environment, we are regularly unregistering components and re-adding as we validate various integrations and scenarios.  This slows down our process drastically as we must wait for a catalog refresh cycle to get the latest updates on our component definitions.

In the logs, we see:
{
  "type": "errorHandler",
  "length": 329,
  "name": "error",
  "severity": "ERROR",
  "code": "23503",
  "detail": "Key (id)=(7c68621a-7180-4955-8451-b94b3a6b8f26) is still referenced from table \"entities\".",
  "schema": "public",
  "table": "entities",
  "constraint": "entities_location_id_foreign",
  "file": "ri_triggers.c",
  "line": "3283",
  "routine": "ri_ReportViolation",
  "level": "error",
  "appName": "backstage",
  "environment": "dev",
  "version": "0.1.306",
  "stack": "error: delete from \"locations\" where \"id\" = $1 - update or delete on table \"locations\" violates foreign key constraint \"entities_location_id_foreign\" on table \"entities\"\n    at Parser.parseErrorMessage (/app/node_modules/pg-protocol/dist/parser.js:287:98)\n    at Parser.handlePacket (/app/node_modules/pg-protocol/dist/parser.js:126:29)\n    at Parser.parse (/app/node_modules/pg-protocol/dist/parser.js:39:38)\n    at Socket.<anonymous> (/app/node_modules/pg-protocol/dist/index.js:11:42)\n    at Socket.emit (events.js:315:20)\n    at Socket.EventEmitter.emit (domain.js:467:12)\n    at addChunk (internal/streams/readable.js:309:12)\n    at readableAddChunk (internal/streams/readable.js:284:9)\n    at Socket.Readable.push (internal/streams/readable.js:223:10)\n    at TCP.onStreamRead (internal/stream_base_commons.js:188:23)",
  "message": "delete from \"locations\" where \"id\" = $1 - update or delete on table \"locations\" violates foreign key constraint \"entities_location_id_foreign\" on table \"entities\"",
  "utc_date_time": "2021-07-01T12:41:38.875Z"
}

Your Environment

NodeJS Version (v12): v14
Operating System and Version (e.g. Ubuntu 14.04): Docker images mcr.microsoft.com/vscode/devcontainers/javascript-node:14 and node:14-alpine both
Browser Information: Brave and Chrome

Hi! Thanks for reporting.
What we did was to try to leave the old data around (the legacy entities table) so that there's a downgrade path in the first couple of weeks who may want some time to verify things. What you are seeing is old "ghost" data that references the thing you want to unregister.
We will be looking at adding some interim code to delete related entities in the old table as well, when locations are unregistered. However we just cut a release and the summer vacations are coming up, so I want to help get you unblocked quicker than that.
Your best bet would probably be to either manually drop the entities_location_id_foreign foreign key constraint, or to delete all rows out of the entities table. Both of those actions are completely safe to do in terms of the new database layout - its active set is in fact in completely different tables. But it does mean committing to the upgrade. Well the second alternative does, the first alternative is relatively easier to recreate, should you ever want to go back. We hope you won't want to, the new system is a lot more scalable and robust!

Thanks for the explanation and the workaround!
I will start off by deleting the rows from the entities table, since our intention is to continue with the latest and greatest changes.  I will update this issue with the results.

I was able to resolve the issue by deleting the rows in the entities table.  I solved this by adding a custom DB migration script, which was a bit hacky.  If it is not already on the backlog, supporting custom DB migrations may be something that is useful in the long run.
If anybody else wants to duplicate, here is how I solved this:
// packages/backend/migrations/catalog/20210701110800_delete_legacy_entities.js
// @ts-check

/**
 * @param {import('knex').Knex} knex
 */
exports.up = async function up(knex) {
  return knex.schema.raw('DELETE FROM entities;');
};

exports.down = async function down() {};

// packages/backend/src/plugins/catalog.ts

import {
  CatalogBuilder,
  createRouter,
} from '@backstage/plugin-catalog-backend';
import { Router } from 'express';
import { PluginEnvironment } from '../types';
import { AgeroOrgGithubProcessor } from '../processors';
import { resolvePackagePath } from '@backstage/backend-common';
import fs from 'fs';
import path from 'path';

export default async function createPlugin(
  env: PluginEnvironment,
): Promise<Router> {
  const builder = await CatalogBuilder.create(env);

  await setupCustomMigrations();

  const {
    entitiesCatalog,
    locationsCatalog,
    locationAnalyzer,
    locationService,
    processingEngine,
  } = await builder.build();

  // Uncomment the below when ready to remove the custom migration.
  // Once this has been deployed, the setupCustomMigrations can be safely removed
  // await removeCustomMigrations(env);

  await processingEngine.start();

  return await createRouter({
    entitiesCatalog,
    locationsCatalog,
    locationAnalyzer,
    locationService,
    logger: env.logger,
    config: env.config,
  });
}

// TODO: Delete this when custom migrations are no longer needed
/*
async function removeCustomMigrations(env: PluginEnvironment) {
  const customMigration = '20210701110800_delete_legacy_entities.js';
  const backstageCatalogMigrations = resolvePackagePath(
    '@backstage/plugin-catalog-backend',
    'migrations',
  );
  const knex = await env.database.getClient();
  await knex.migrate.down({
    name: customMigration,
    directory: backstageCatalogMigrations,
  });
  await fs.promises.unlink(
    path.join(backstageCatalogMigrations, customMigration),
  );
}
*/

async function setupCustomMigrations() {
  const backstageCatalogMigrations = resolvePackagePath(
    '@backstage/plugin-catalog-backend',
    'migrations',
  );
  const customCatalogMigrations = resolvePackagePath(
    'backend',
    'migrations',
    'catalog',
  );

  const migrations = await fs.promises.readdir(customCatalogMigrations);
  const copyPromises = migrations.map(async migration => {
    await fs.promises.copyFile(
      path.join(customCatalogMigrations, migration),
      path.join(backstageCatalogMigrations, migration),
    );
  });
  await Promise.all(copyPromises);
}

Finally, don't forget to add migrations to the files in packages/backend/package.json

@JP-Dhabolt is it ok to close this?
We will be adding migrations to remove the entities table hopefully in the short term future once the new catalog has settled

Yes, I am good with this. Thank you for the assistance!

👋 @benjdlambert I am seeing the similar issue. I'd like to clarify one more question - if I delete an entity with location, I should be able to re-register the same entity? I see the register action says entity exists and when I try to refresh the entity it refresh endpoint throws 404.


fix: compact objects in post-order

This changes the order of the .olean compactor to use post-order traversal, rather than reverse pre-order. (That is, given an object graph like a(b(c, d), e) it used to produce an olean file with the layout e d c b a and now it produces c d b e a.) While not strictly required, it is a relatively simple fix which makes it possible to get bit-for-bit identical olean files from https://github.com/digama0/leangz, which has many other applications.

Could you please rename the PR since it is not fixing but changing the .olean format?


incompatible shell

I try to run through the docs. when to run run_tests, I got the error:
./scripts/run_tests: [[: not found
As I found the in the script that this shell script just uses sh not bash. And [[ ... ]] is not good. I would advise to the syntax consistent.
My os is: ubuntu 18.04, bash and amd64. Is this anything which should be fixed?

Definitely should be bash. Will need to address this.

Yes, I think so. Let me make a pr for this.

FYI - here is the low down on single vs. double square braces in bash:
https://stackoverflow.com/questions/13542832/difference-between-single-and-double-square-brackets-in-bash
We should be using just a single [ in the scripts and definitely all should be running bash only.  If it works with other shells, that's good, but bash is the target.
I'm going to update the demo script (./run_demo in the demo folder), but the rest should be addressed as well.

@swcurran
I have composed a patch for this. If you did not do it, let me do this.

Sure - go for it.  Thanks!  @dongwangdw

https://github.com/hyperledger/aries-cloudagent-python/pull/72

Thank you @dongwangdw! The patch has been merged and is available in the latest release.


R XGBoost: No longer producing predictions on .RData or .model files when supplied a matrix

Just a couple of months back I was able to run the code below to predict test data outcomes after loading in .RData or .model XGBoost files. These models were able to predict outcomes on .csv data loaded in with read.csv() which was then transformed to a matrix with as.matrix(). After updating to the latest R version and the latest XGBoost version I was no longer able to predict my test data with this code:
predict(object=model1_proto, newdata=as.matrix(test_set[,model1_proto_inputs]))
I was instead greeted by a somewhat confusing error message:
Error in predict.xgb.Booster(object = model1_proto, newdata = as.matrix(test_set[,  :
  [12:58:12] amalgamation/../src/learner.cc:506: Check failed: mparam_.num_feature != 0 (0 vs. 0) : 0 feature is supplied.  Are you using raw Booster interface?

After double-checking my inputs and my model to make sure the integrity of each was intact it was hard to tell what could have been the issue. After scouring the web for any similar issues the closest thing I could find was #5599 though I'm not sure its exactly the same issue
Here is my sessionInfo():
R version 4.0.1 (2020-06-06)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows Server x64 (build 14393)

Matrix products: default

locale:
[1] LC_COLLATE=English_United States.1252
[2] LC_CTYPE=English_United States.1252
[3] LC_MONETARY=English_United States.1252
[4] LC_NUMERIC=C
[5] LC_TIME=English_United States.1252

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods
[7] base

other attached packages:
 [1] **xgboost_<IP_ADDRESS>** forcats_0.5.0   stringr_1.4.0
 [4] dplyr_1.0.0     purrr_0.3.4     readr_1.3.1
 [7] tidyr_1.1.0     tibble_3.0.1    ggplot2_3.3.1
[10] tidyverse_1.3.0 devtools_2.3.0  usethis_1.6.1

loaded via a namespace (and not attached):
 [1] Rcpp_<IP_ADDRESS>      lubridate_1.7.9   lattice_0.20-41
 [4] prettyunits_1.1.1 ps_1.3.3          assertthat_0.2.1
 [7] rprojroot_1.3-2   digest_0.6.25     R6_2.4.1
[10] cellranger_1.1.0  backports_1.1.7   reprex_0.3.0
[13] httr_1.4.1        pillar_1.4.4      rlang_0.4.6
[16] readxl_1.3.1      rstudioapi_0.11   data.table_1.12.8
[19] callr_3.4.3       blob_1.2.1        Matrix_1.2-18
[22] desc_1.2.0        munsell_0.5.0     tinytex_0.23
[25] broom_0.5.6       compiler_4.0.1    modelr_0.1.8
[28] xfun_0.14         pkgconfig_2.0.3   pkgbuild_1.0.8
[31] tidyselect_1.1.0  fansi_0.4.1       crayon_1.3.4
[34] dbplyr_1.4.4      withr_2.2.0       grid_4.0.1
[37] nlme_3.1-148      jsonlite_1.6.1    gtable_0.3.0
[40] lifecycle_0.2.0   DBI_1.1.0         magrittr_1.5
[43] scales_1.1.1      stringi_1.4.6     cli_2.0.2
[46] fs_1.4.1          remotes_2.1.1     testthat_2.3.2
[49] xml2_1.3.2        ellipsis_0.3.1    generics_0.0.2
[52] vctrs_0.3.1       tools_4.0.1       glue_1.4.1
[55] hms_0.5.3         processx_3.4.2    pkgload_1.1.0
[58] yaml_2.2.1        colorspace_1.4-1  sessioninfo_1.1.1
[61] rvest_0.3.5       memoise_1.1.0     knitr_1.28
[64] haven_2.3.1

I'm trying to discover if this is a bug or if the new version is requiring a different method of prediction. If so, it's not immediately obvious after reviewing the release notes

Did you use saveRDS() method to produce model1_proto? See the thread #5794. The short answer is that saveRDS() does not produce a file that can be read in newer versions of XGBoost. You should install an old version of XGBoost, load model1_proto, and save it using xgb.save().

I did not. I used base R's save() and xgboost's xgb.save(). These were saved under an older version of XGBoost that I do not remember. It wouldn't be an XGBoost version much older than a year ago. I'll try to install an older version and do that

Hmm, that's odd, since you say you used xgb.save(). Can you post the snippet you used to load the XGBoost model? Did you use xgb.load()?

As an example the file path looks like 'C:/Users/me/models/' as seen below.
The model was saved with this code when an older version of XGBoost was installed:
xgb.save(xgb_tiered_p1, 'C:/Users/me/models/xgb_tiered_phase1.model')
When I load this file in now like this..
model1_proto <- xgb.load('C:/Users/me/models/xgb_tiered_phase1.model'))
..it yields this error:
Error in xgb.Booster.handle(modelfile = modelfile) :
  [16:36:26] amalgamation/../src/objective/./regression_loss.h:89: Check failed: base_score > 0.0f && base_score < 1.0f: base_score must be in (0,1) for logistic loss, got: -0

@tmbluth The error is different from your original post? Wasn't it mparam_.num_feature != 0 (0 vs. 0) : 0 feature is supplied.  Are you using raw Booster interface?

The first error message appeared when I tried to load in the .RData file ( save() ). The second error message was when I tried to load in the .model file ( xgb.save() )
In the sessionInfo() above under "other attached packages" it shows "xgboost_<IP_ADDRESS>"
That's the version that has been throwing these errors

@tmbluth The first error is expected, since the .RData file may become unreadable when XGBoost is upgraded. The save() method has the same problem as saveRDS(). See the discussion in #5794.
As for the second error, it might be related to a past bug #5699. Can you share the .model file so that we can try to diagnose the issue?

I can't in this case since the model is company property and proprietary. Is there anything else I can do?

@tmbluth Do you have another model file that you can share and is experiencing the same issue? (Check failed: base_score > 0.0f && base_score < 1.0f)

I do not. It would have to be artificially simulated by training a model with the old XGBoost (I'm wanting to say v 0.9.0?) and loading it in with the latest version

Is there anything else I can do?

Please understand that it is quite difficult for us developers to diagnose the problem without an example at hand.
I’ll keep this issue open for now and will update if I happen to run into the same error.

#5794 has been addressed by #5940, and in the upcoming XGBoost version, you can read models from old RDS models again.

OH. Great. I just came across the same issue. Glad to know this news. But, when I checked the latest version of xgboost in the CRAN (https://cran.r-project.org/web/packages/xgboost/index.html), it's still v<IP_ADDRESS>. Can I use the install.package to install the v<IP_ADDRESS>? Or I have to compile by myself? Thanks :)


[Candidate 1v1 Proxy War ZH v1] Top center bunker can take damage when occupants shoot out of it

Observed behavior
Top center bunker can take damage when occupants shoot out of it.
Expected behavior
Houses never take damage from occupants.
Screenshots

fixed


added rudimentary support for TimesTen database. Based on Oracle support

This implementation works with the TimesTen database we're using. There are probably some differences with some of the implementation pieces, but since we're not using all those features, it's hard to tell if they're working or not.
In anycase, it's a good start, and hopefully people can improve on it.

Please update so it can be merged in Flyway 3.2 and provide a corresponding PR for flywaydb.org
Cheers
Axel

I added docs to here: https://github.com/flyway/flywaydb.org/pull/37

ugh .. i think i borked this branch or something... I'm going to close this and start over.


Light-reactive interaction outlines

About the PR
This PR makes the interaction outlines directly react to lighting. How much a given object reacts to lighting is configurable from the outline prototype. In laymen's terms, this means that using your mouse to scan for objects from a distance in a dark area will end up being much easier said than done, and if there's no light at all, then there simply won't be an interaction outline. Interactions outlines that are in-range are much easier to see in darker areas, meaning it's still entirely plausible to fumble around maintenance if you have a light source of any kind on-hand. While not pictured in the below video, colored lighting does not influence the outline's color at all, meaning green outlines are still visible in emergency lighting.
This PR also does a bit of minor cleanup for the outline shader (mostly just axing commented-out lines)
Additionally, this PR relies on space-wizards/RobustToolbox#4201 . Without it, shader compilation will simply error out.
Media
https://github.com/space-wizards/space-station-14/assets/6356337/5dd96882-a318-4940-aaf2-fb73195398b1

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl: Bhijn and Myr

add: Interaction outlines now directly react to lighting. You can no longer merely wave your mouse around in the dark to see objects in the distance in maint. Interaction outlines that're in-range are far brighter even in dim conditions, though out-of-range interaction outlines are hard to see in poor light conditions.

good

pro


cmake: allow passing extra options to compiler

Is there documentation on using cmake to build charm anywhere?

here: https://charm.readthedocs.io/en/latest/charm++/manual.html#installation-with-cmake


Upgrade org.apache.maven.plugins:maven-resources-plugin 3.3.0 -> 3.3.1

This PR contains the following updates:

Package
Type
Update
Change

org.apache.maven.plugins:maven-resources-plugin
build
patch
3.3.0 -> 3.3.1

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade maven-resources-plugin 3.3.0 -> 3.3.1

See https://github.com/apache/maven-resources-plugin/compare/maven-resources-plugin-3.3.0...maven-resources-plugin-3.3.1


Async data connect

Fixes #41
Arranged the webpack config choice (according to NODE_ENV)

gg wp @ufukomer 👍


Add support for case, whitespace & separator normalization

I understand this may fall outside the scope, but it would be very convenient if cleanco also had this kind of simple normalization built-in:

standardizing lettercase (e.g., all lowercase)
standardizing separators (e.g., commas must be followed by spaces)
standardizing whitespace (e.g., converting all runs of whitespace to single spaces)

standardizing lettercase (e.g., all lowercase)
I disagree.  Some companies have odd capitalization, so it is probably best to leave this as-is.  Anyone can choose to use the .lower() function later if they want to.

standardizing separators (e.g., commas must be followed by spaces)
This might be a good idea, but I want to think about it (why add something if it breaks other things in the future)

standardizing whitespace (e.g., converting all runs of whitespace to single spaces)
The code already does this:

business_name = " ".join(business_name.split())

To clarify, I meant these to be optional convenience features rather than changing existing behavior - and yes, I did not realize the extra whitespace removal was already there, that's nice.

Thinking a bit more about this, the only remaining part of the request (separator normalization) is not really that important, and having lowercase name is trivial so I feel we can close this.


Enhancement: Pass the caught exception to exception_logging_handler for more flexible logging decision

Summary
Pass Exception instance to LogConfig.exception_logging_handler callable, like for exception handlers.
This would allow to judge if / how to log exception based on exception type:

HTTPException (at least 4XX ones) - log as INFO, without stacktrace. These are client errors, and expected to happen every now and then. Absolutely no need to log them as ERROR and with stacktrace.
Some Timeout error - log as WARNING, as it's bound to happen every now and then, but it's not a bug, really
Any other Exception - log as ERROR with stacktrace, as yes it looks like a bug as it slipped in.

Currently, the exception_logging_handler is passed pre-formatted stacktrace, so it cannot judge what the exception actually was. But it would make a lot of sense to just pass the caught exception, instead of the stacktrace, and let the function decide when and how to represent the exception.
As a workaround, it's possible to grab the exception via sys.exc_info() (I believe). But it would be "cleaner" if the exception was passed in, and one wouldn't have to do that. It would also signal the developer that it's actually okay to determine logic based on exception type, now you have to kinda think outside the box.
Basic Example
No response
Drawbacks and Impact
No response
Unresolved questions
No response

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

Discovered https://docs.litestar.dev/2/usage/applications.html#after-exception and there, the callable is passed the Exception instance:
async def after_exception_handler(exc: Exception, scope: "Scope") -> None:

What's the use case for having separate after_exception_handler and exception_logging_handler?

If you want to customise your logging to such a degree, using the after_exception_handler is the right approach; Litestar's built-in exception logging config is meant to provide sensible default and a degree of customisation out of the box. I don't think this warrants a breaking change (introducing a new parameter), considering logging as a whole is going to change in 3.0, where we're looking to simplify the setup in general and remove a lot of the configuration in favour of a leaner interface and moving more towards just using stdlib logging config, which will be tracked in #2858. Feel free to comment your ideas on there as well.
@cofin maybe you have some thoughts on this as well, but I'm closing this for now.


#1866 - Remove props any from the vue application

Removed all props typed with any;
Parsed route params values for the ones that were required for this ticket;

Good work @andrepestana-aot . Added one comment which is applicable to many files.


Bugfix: intro tess exomast notebook

Updating for the new required sector argument in tess exomast queries.
PR addresses this issue: #93
EDIT: Fix #93

@mustaric  Can you take a look and see if you think my additions are well enough explained?

@mustaric Checking you are getting emails.


flake8 ignores exclude configuration when used through pre-commit hooks

Describe the bug
When sharpy-sc2's pre-commit hooks are installed, flake8 will ignore excludes configured in .flake8 file.
This is by design, and pre-commits exclude should be used instead.

Checked-in python files will be passed as positional arguments. flake8 will always lint explicitly passed arguments (flake8 --exclude has no effect). Instead use pre-commit’s exclude: ... regex to exclude files. pre-commit won’t ever pass untracked files to flake8 so excluding .git / .tox / etc. is unnecessary.

https://flake8.pycqa.org/en/latest/user/using-hooks.html
Expected behavior
Flake8 should work in similar way, whether launched with eg. py -m flake8 or by the pre-commit hooks (installed by pre-commit install).
Additional context
sharpy-sc2 repo already contains multiple config files with the same excludes.

.flake8
pyproject.toml for Black config
pytest.ini

Adding a fourth file with the same excluded directories would be... less than ideal.

Related question and potential solution.
https://github.com/psf/black/issues/395
In the .pre-commit-config.yaml file you can add
    -   id: flake8
        # everything but tests
        exclude: ^tests/

to exclude directories


Fix for extra zero width space in chrome/safari

Can you rebase these changes on inin-master so they can merge cleanly? Thanks.


Support connect mongo with username and password

currently, the username and password of mongo is not used. It means we can not connect mongo which needs username and password

closed by #64


Tests: npm run watch:all breaks map element

In the current setup, something is interfering with the map-Element when npm run watch:all. It works fine when watching only via npm run watch --workspace=@eox/map.
This issue can be recreated by running npm run watch:all and running the drawInteraction-test. The getLayerById-method for some reason expects 3 parameters, but that method only requires 2, as in the map-Element branch, leading to invalid inputs.

The watch:all didn't seem to work as intended, so it was removed from the scrips. The recommended way is to first build:all and then watch the elements that are being worked on individually (in separate terminals).


The article does not state clearly what language the code examples are in

File: docs/guides/crosswalk/aws/eks.md
It would make the article clearer if the language of the examples was called out more explicitly.

The language here is typescript but we do have support for it now in other languages. @davidwrede not sure if you are already tracking something to update docs/blogs for multilang support?

@viveklak Thanks for the reminder. Yeah, I'll include the update work for this topic as part of that other set of items.

@dekobon im not sure what the state of things was when you opened this issue, but would you mind taking another look? is the language still unclear to you?

Yes, this is much clearer now.


Remove value input on txns

This is easy. Even when agents are paying gas, they don't explicitly need to send any ether. This is really only useful if they are sending raw ether to another agent. We can just drop this for now.

This was closed with the big PR


Performance enhancement

Currently, depCheck looks for all files under directory to get dependency result.
Some strategies can be used to optimize the performance:

First, it get packages from a part of files, compare with declaring packages.
If all declaring packages are used, stop reading files. Return everything is good. :white_check_mark:
If not all declaring packages are used, continue the step 1.
If all files are searched, but there are some declaring packaged not fulfilled, show them as unused. :x:

Concretely, it need to convert the promise queue in checkDirectory to Array<Func<Promise>> queue. The promises are triggered only then function is invoked.

Use benchmarkjs to compare the performances of different strategies.

What about using regex instead of building an AST for each file? Should be much quicker right?
I just created a package to find the require statements (including ES6 and coffeescript) in a string (https://github.com/mathieudutour/deps-regex)

I tried to implement it (https://github.com/mathieudutour/depcheck-es6/commit/1174755c4f4df87b2ad6dd71be1fd243ef238c64) but tests are failing. I'm not sure where they come from as I'm not familiar with the test suit

Hi, @mathieudutour Thanks for working on this.
Actually, build an AST is not necessary to parse a file. As said in my pluggable design, the parser has a second option - find all package dependencies, and return them as a string list. The main program will handle this case as these packages are required.
So, you can adopt your regex pattern to parse the CoffeeScript file, it should be faster than my implementation in #82. Concretely, you just implement a new parser and map some file extensions on them, as what I do in #82.

Besides, this thread is not discussing the performance about parsing a file with which method (AST, or regex pattern).
It focuses on another problem - currently, we are looking on all files in your package to get the unused packages. However, in most of the case, the developer should have all packages in use. We should stop looking on files once we find out all declaring packages are in use.

make sense

@lijunle do you have solution how to fix it

Read the thread from top to bottom, some clues have mentioned.

This issue was moved to depcheck/depcheck#43


Unable to use GRPC service RPC call "New"

When attempting to compile Dart libraries for our existing platform, we came across a strange issue with one of the repositories where we have a definition similar to:
service Account {
  rpc Get(api.base.GetRequest) returns (api.account.Model);
  rpc Search(api.base.SearchRequest) returns (stream api.account.SearchResponse);
  rpc New(api.account.Model) returns (api.account.Model);
  rpc Update(api.account.Model) returns (api.account.Model);
  rpc Destroy(api.base.DestroyRequest) returns (google.protobuf.Empty);
}

We received an output similar to the below examples with the main error seeming to be "Constructors can't have type parameters.". Unfortunately Google didn't provide any suggestions.
Doing a bit of digging through commenting out lines, we discovered that the issue was being caused by this line:
  rpc New(api.account.Model) returns (api.account.Model);

Further reading into Dart suggests that with "new" being a reserved term in Dart, us using it as the rpc function name is causing a conflict.
This was verified by creating two files:
test_create.proto
syntax = "proto3";

message SimpleReq {
  string test = 1;
}

message SimpleResponse {
  string test = 1;
}

service TestService {
  rpc Create(SimpleReq) returns (SimpleResponse);
}

❯ protoc --dart_out=grpc:. test_create.proto
< successful return >

test_new.proto
syntax = "proto3";

message SimpleReq {
  string test = 1;
}

message SimpleResponse {
  string test = 1;
}

service TestService {
  rpc New(SimpleReq) returns (SimpleResponse);
}

❯ protoc --dart_out=grpc:. test_new.proto
Unhandled exception:
Could not format because the source could not be parsed:

line 50, column 36: A function body must be provided.
   ╷
50 │   $async.Future<$0.SimpleResponse> new($grpc.ServiceCall call, $0.SimpleReq request);
   │                                    ^^^
   ╵
line 28, column 24: Expected to find '>'.
   ╷
28 │   $grpc.ResponseFuture<$0.SimpleResponse> new($0.SimpleReq request, {$grpc.CallOptions options}) {
   │                        ^^
   ╵
line 28, column 23: Constructors can't have type parameters.
   ╷
28 │   $grpc.ResponseFuture<$0.SimpleResponse> new($0.SimpleReq request, {$grpc.CallOptions options}) {
   │                       ^^^^^^^^^^^^^^^^^^^
   ╵
line 50, column 17: Expected to find '>'.
   ╷
50 │   $async.Future<$0.SimpleResponse> new($grpc.ServiceCall call, $0.SimpleReq request);
   │                 ^^
   ╵
line 28, column 3: Methods must have an explicit list of parameters.
   ╷
28 │   $grpc.ResponseFuture<$0.SimpleResponse> new($0.SimpleReq request, {$grpc.CallOptions options}) {
   │   ^^^^^
   ╵
line 50, column 16: Constructors can't have type parameters.
   ╷
50 │   $async.Future<$0.SimpleResponse> new($grpc.ServiceCall call, $0.SimpleReq request);
   │                ^^^^^^^^^^^^^^^^^^^
   ╵
line 28, column 3: The name of a constructor must match the name of the enclosing class.
   ╷
28 │   $grpc.ResponseFuture<$0.SimpleResponse> new($0.SimpleReq request, {$grpc.CallOptions options}) {
   │   ^^^^^
   ╵
line 28, column 43: A function body must be provided.
   ╷
28 │   $grpc.ResponseFuture<$0.SimpleResponse> new($0.SimpleReq request, {$grpc.CallOptions options}) {
   │                                           ^^^
   ╵
line 50, column 36: Expected a class member.
   ╷
50 │   $async.Future<$0.SimpleResponse> new($grpc.ServiceCall call, $0.SimpleReq request);
   │                                    ^^^
   ╵
line 50, column 3: The name of a constructor must match the name of the enclosing class.
   ╷
50 │   $async.Future<$0.SimpleResponse> new($grpc.ServiceCall call, $0.SimpleReq request);
   │   ^^^^^^
   ╵
(5 more errors...)
#0      DartFormatter.formatSource (package:dart_style/src/dart_formatter.dart:141:7)
#1      DartFormatter.format (package:dart_style/src/dart_formatter.dart:75:12)
#2      FileGenerator.generateGrpcFile (package:protoc_plugin/file_generator.dart:518:23)
#3      FileGenerator.generateFiles (package:protoc_plugin/file_generator.dart:252:44)
#4      CodeGenerator.generate.<anonymous closure> (package:protoc_plugin/code_generator.dart:114:36)
#5      _RootZone.runUnary (dart:async/zone.dart:1450:54)
#6      _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#7      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#8      Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#9      Future._complete (dart:async/future_impl.dart:519:7)
#10     Stream.fold.<anonymous closure> (dart:async/stream.dart:847:14)
#11     _RootZone.runGuarded (dart:async/zone.dart:1372:10)
#12     _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:410:13)
#13     _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:420:15)
#14     _BufferingStreamSubscription._close (dart:async/stream_impl.dart:305:7)
#15     _SyncStreamControllerDispatch._sendDone (dart:async/stream_controller.dart:816:19)
#16     _StreamController._closeUnchecked (dart:async/stream_controller.dart:671:7)
#17     _StreamController.close (dart:async/stream_controller.dart:664:5)
#18     _Socket._onData (dart:io-patch/socket_patch.dart:2051:21)
#19     _RootZone.runUnaryGuarded (dart:async/zone.dart:1384:10)
#20     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:357:11)
#21     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:285:7)
#22     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:808:19)
#23     _StreamController._add (dart:async/stream_controller.dart:682:7)
#24     _StreamController.add (dart:async/stream_controller.dart:624:5)
#25     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1587:35)
#26     _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1069:18)
#27     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#28     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#29     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#30     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)
--dart_out: protoc-gen-dart: Plugin failed with status code 255.

Would anyone have any suggestions which don't involve renaming the functions in this module? (which are currently being used by several other systems). Unfortunately, we're just starting to get into Dart coding so don't have the skills required to investigate solutions in a time efficient manner.

Seems we don't do any disambiguation of method names when generating the service descriptors...

#487 fixes this but it was closed without an explanation. I added a comment in the PR to reopen it and merge it.

Duplicate of #159, except the conflicting identifier is New instead of Request.


Show Installed Games in Drop-Down

Currently old, but installed game versions are just cut off in the drop-down menu. I think they should be displayed at the end of the list, omitting older build numbers which are not installed.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/5389056-show-installed-games-in-drop-down?utm_campaign=plugin&utm_content=tracker%2F715506&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F715506&utm_medium=issues&utm_source=github).

Closing this issue as outdated. Installed games are actually recognized and the list is expanded up to the oldest installed version.
Pinging @mtjvankuik because he was investigating this issue.


add chasebolt as maintainer

-s

:+1:

@someara @tas50 what is the status with this cookbook? there are good PRs in a holding pattern atm that I would like to get merged in.

I'll get this added


Allow multiple required resources on job configuration

This PR allows to add multiple required resources on job configuration in order to be able to reserve multiple resource with different label and for having the possibility to use a distinct environment variable for each required resources.

An important refactoring has been done for allowing this feature so any feedback is welcomed.

This is conflicting with #26, although #26 is only Pipeline-related.
Maybe you can start from that PR and complete it for Freestyle projects also?

@jlrigau from my point of view #26 is complete and just awaits merging.
Build is successful locally and why the CI fails is out of my knowledge.
About which build failures do you talk? Do you have local failures?
I would second @amuniz approach to base your solution on #26 and merge everything together

Is this still needed or was included in #42 ?

We would like to see this functionality added to the lockable-resource plugin and it seems o be partially available in pipeline flow anyway,
I opened JENKINS-42209 for that issue.

Progress on this change seems to have stalled. As written in JENKINS-42209, this is already available for pipeline jobs. I would be willing to merge an up-to-date minimal pull request adding this feature, but I won't be able to spend any time implementing it myself. Therefore, I'm closing this for now. Feel free to reopen after resolving the conflicts.


#1712 Add total item quantity in donations#show page

resolves #1712
Type of change

New feature (non-breaking change which adds functionality)

Screenshots
old behavior

new behavior

Thanks!


Removes bind method to avoid React warnings

Using .bind() triggers console warnings in newer versions of React that suggest removing the method. The pagination component seems to continue to work perfectly even after removing this.

You are not right,
if you remove bind you will create Uncaught TypeError: this.setState is not a function
you do not have to use bind if you don't want in your app, but in current example it is necessary to keep proper context

Interesting. In the example provided, the latest version of React displays this warning in the console:
bind(): You are binding a component method to the component. React does this for you automatically in a high-performance way, so you can safely remove this call.

please, check http://vayser.github.io/react-js-pagination/
console output doesn't have any warnings

@dunkdunk probably i need upgrade React version in example. Let me check, please

My mistake, the warning is appearing in the console via React Dev Tools. So this wouldn't appear in the standard console.


DUPLO-12873: add example for viewing secret

Example for creating a secret and viewing the secret_value

Task linked: DUPLO-12873 TF: add example for retrieving secret

Put it in data-sources/tenant_secret.md

I believe thats where I currently have it, right?


Created togglable sidebar for tablet view and modified layout

Overview:

Created a sidebar for the tablet and mobile layout.
Altered the CSS Grid layout to show more of the documentation since aside isn't being used(yet).
Header bar is now sticky.
Header bar has $primary-background

Testing

Resize window to Tablet and mobile view
Click menu button on top-left of header bar.
Expected result: You should see the sidebar expand and collapse when clicking the sidebar button in tablet/mobile view

Additional information

@BboyAkers  Not much progress being made here. Going to clean up the PR screen and close this for now


Refactor users service from go to python

Issue #, if available:
#13
Description of changes:
Refactor users service from go to python

New users service created under users folder with old go based service moved to users-old for reference during PR
Changed from in-memory storage of users to using dynamodb
Updated cloudformation templates to deploy users dynamodb table with appropriate permissions for users service to access table
Added custom resource and lambda function to load users table with shoppers during deployment of retail demo store
append unique string to cloudfront request policies

Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):
Integration testing using testing scripts and tested by deploying into personal account
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gfaires nice thanks! I'll look into each one, 1 by 1 and respond


enhance: clean the local-persist after integration tests

Signed-off-by: Eric Li<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
After integration tests, we will clean the local-persist volume plugin
Ⅱ. Does this pull request fix one issue?

#1396
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1400 into master will increase coverage by 18.68%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1400       +/-   ##
===========================================
+ Coverage   16.28%   34.96%   +18.68%
===========================================
  Files         198      254       +56
  Lines       13470    17840     +4370
===========================================
+ Hits         2193     6238     +4045
+ Misses      11126    10784      -342
- Partials      151      818      +667

Impacted Files
Coverage Δ

cri/v1alpha1/cri_utils.go
0% <0%> (-29.32%)
:arrow_down:

cri/v1alpha2/cri_utils.go
0% <0%> (-28.42%)
:arrow_down:

pkg/utils/utils.go
71.21% <0%> (-1.84%)
:arrow_down:

daemon/logger/jsonfile/utils.go
70% <0%> (ø)
:arrow_up:

cri/stream/httpstream/spdy/upgrade.go
0% <0%> (ø)

storage/volume/error/errors.go
28.57% <0%> (ø)

registry/auth_challenge.go
62.5% <0%> (ø)

cri/criservice.go
12.5% <0%> (ø)

registry/auth.go
54.12% <0%> (ø)

storage/volume/modules/ceph/ceph.go
7.55% <0%> (ø)

... and 120 more

LGTM


Using for multi-language

Can we us this knowledge-based feature for multiple language?

Thanks for the issue, @amn41 will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

@Wickky Sorry for the late reply. How do you want to use multiple languages? Do you want to mix different languages in one assistant? Or do you want to build multiple assistants each of them in a different language?
As this feature is based on Rasa and Rasa supports multiple languages, you can for sure build an assistant in a different language than English. Take a look at our documentation.

Hi @tabergma,
I want to use this to the Sinhala language. But Spacy is still not supported to Sinhala. So how can I use this? Can you suggest any other option?

Hi @nimo21, you could take a look at https://github.com/RasaHQ/rasa-nlu-examples. We have some more NLU components in there that support more language. Might be that Sinhala language is supported there as well.


Changelog for next release

Description
Changelog for next release. Sticks to changelog format from https://keepachangelog.com/en/1.0.0/ which includes contributor name in changelog entry.
Type of change

[ ] :sunflower: Feature
[ ] :bug: Bugfix
[ ] :world_map: Documentation
[ ] :robot: Test
[ ] :computer: CI/Deployment
[ ] :hamster: Trivial/Minor

Issue(s)

#

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

Added PR or Issue references


Use serde for ffi

Do you think it would be possible to use serde to encode and decode structs for ffi? For example, convert between pointers and references, *const *const char to &[str]... That last example makes me think that it would not be possible, as you often have a field with the length and another with the pointer.

I think specialized functions would be more appropriate, especially due to the unsafe nature. Serde was not written with unsafe in its mind. So there might be different Serialize and Deserialize impls which break serde's rules, but that usually just causes an Err or a panic!, but no unsafety.

Ok


Remove version from local crates

Having both a path and a version causes Cargo to use a different package source when built locally versus from cargo.
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-locations

I'm not sure if this is the desired solution. My intent is to fix this build error when I try installing with Cargo:
$ cargo install --git=https://github.com/moonrepo/proto --root=~/.proto --target-dir=~/.proto/build --force --locked
...
   Compiling system_env v0.1.8 (/Users/dan/.cargo/git/checkouts/proto-2c037be0d9f54cdf/2e8260e/crates/system-env)
error[E0599]: no method named `as_encoded_bytes` found for reference `&OsStr` in the current scope
  --> crates/system-env/src/helpers.rs:85:10
   |
84 |       let bin_path = if bin
   |  _______________________-
85 | |         .as_encoded_bytes()
   | |         -^^^^^^^^^^^^^^^^ method not found in `&OsStr`
   | |_________|
   |

error[E0599]: no method named `as_encoded_bytes` found for reference `&OsStr` in the current scope
   --> crates/system-env/src/helpers.rs:104:61
    |
104 | ...a.as_ref().as_encoded_bytes()).to_string())
    |               ^^^^^^^^^^^^^^^^ method not found in `&OsStr`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `system_env` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile `proto_cli v0.25.3 (https://github.com/moonrepo/proto#2e8260ef)`, intermediate artifacts can be found at `/Users/dan/~/.proto/build`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Publishing to crates.io fails if there's no version field -_-

My intent is to fix this build error when I try installing with Cargo on macOS.

Totally misdiagnosed this issue. I think the cause is that as_encoded_bytes is new in 1.74.0 but I was building with cargo 1.73.0.

Publishing to crates.io fails if there's no version field -_-

Ah that makes sense. Closing.


aspnet50

Hi I´m kinda stuck, i need some help in the following issue please.
class GraphHelper expose static methods, this is possible because it relies on class ConfigHelper to get the azure ad configuration info in order to query users thorugh the graph api. This approach works fine in asp.net 4.5 but I´m having trouble using this structure in aspnet50, one of the limitations is that I can´t use the ConfigHelper static approach as ConfigurationManager is not available in aspnet50. I tried to use the IOptions approach, but it's architecture depends on DI and static methods makes no sense this way, I guess I could inject azure ad settings through the controller making the request, but it doesn't feel like a clean solution. I'd appreciate any help on this matter or any examples about authorization based in Azure AD Groups and Roles Claims in aspent50.

The sample has been completely updated, so closing this issue as these classes have changed.


Interpreter for behaviour checking

It will be useful to have an interpreter that can be set automatically generated code, checking that the code doesn't crash if it passes the semantic checker and does crash (or behaves badly) when the semantic checker raises issues should allow faster progress on the checker and language semantics.

Done: A very simple interpreter was merged in #127 further work will be in extending it.


Fix IAE: Not supported: sbt....inc.javac.WriteReportingJavaFileObject

Fixes #185, #684

To validate this pull request against other sbt modules, please visit this link.

This test failed, and failed again when I restarted the build:
[info] ! TextAnalysisFormat.Write and read simple Analysis: Exception raised on property evaluation.
[info] > Exception: java.lang.NullPointerException: null
...
[error] Error: Total 12, Failed 0, Errors 1, Passed 11
[error] Error during tests:
[error] 	sbt.inc.text.TextAnalysisFormatSpecification

No I can't. This test passes locally:
sbt:zinc Persist> testOnly sbt.inc.text.TextAnalysisFormatSpecification
[info] + TextAnalysisFormat.Write and read empty Analysis: OK, proved property.
[info] + TextAnalysisFormat.Write and read simple Analysis: OK, proved property.
[info] + TextAnalysisFormat.Write and read complex Analysis: OK, passed 100 tests.
[info] ScalaCheck
[info] Passed: Total 3, Failed 0, Errors 0, Passed 3
[info] ScalaTest
[info] Run completed in 2 seconds, 521 milliseconds.

What now? Can anybody look at this? Bloop needs this change to fix a similar problem there.


fix rocky

ping @mira-miracoli here was something wrong. I hope I corrected it and did not mess anything up.


Enhancement Request: Streamline use of custom end-markers

Hi @susielu! Thank you for creating d3-annotation, it's lovely.
I was curious about the arrowhead/circle options.  It looks like the builder runs for every connector that has a marker.
Was wondering if you'd considered SVG's native marker element which knows how to attach itself to the end of a line, and so by default scales itself to the stroke-width and rotates itself to match the line.
Thus, the arrow marker paths would go into a <marker> element in <defs>, and get called using the marker-end attribute.
Sorry if you've already looked and discarded this.

Oh wow, that looks great. I didn't know of that element in SVG. I will take a look thanks @seemantk


Enable TLS auth of Pulsar Function in standalone mode

Is your feature request related to a problem? Please describe.
When we want to enable TLS related encryption in the function worker. Some parameters use brokers, but some parameters are not covered by the broker.
For example, in PulsarStandalone.java, if we want to enable authentication using TLS, then we need to configure TLS related parameters in functions_worker.yml, but Auth related parameters inherit the configuration in broker.conf
workerConfig.setAuthenticationEnabled(config.isAuthenticationEnabled());
workerConfig.setAuthenticationProviders(config.getAuthenticationProviders());

workerConfig.setAuthorizationEnabled(config.isAuthorizationEnabled());
workerConfig.setAuthorizationProvider(config.getAuthorizationProvider());
workerConfig.setConfigurationStoreServers(config.getConfigurationStoreServers());
workerConfig.setZooKeeperSessionTimeoutMillis(config.getZooKeeperSessionTimeoutMillis());
workerConfig.setZooKeeperOperationTimeoutSeconds(config.getZooKeeperOperationTimeoutSeconds());

workerConfig.setTlsHostnameVerificationEnable(false);

workerConfig.setTlsAllowInsecureConnection(config.isTlsAllowInsecureConnection());
workerConfig.setTlsTrustCertsFilePath(config.getTlsTrustCertsFilePath());

// client in worker will use this config to authenticate with broker
 workerConfig.setClientAuthenticationPlugin(config.getBrokerClientAuthenticationPlugin());
workerConfig.setClientAuthenticationParameters(config.getBrokerClientAuthenticationParameters());

// inherit super users
workerConfig.setSuperUserRoles(config.getSuperUserRoles());

For encryption-related functions, if the function worker wants to inherit the broker-related configuration, then all the encryption-related options need to be inherited instead of a part of them.
Describe the solution you'd like
I think we can modify the current behavior. If the relevant functions are configured in functions_worker.yml, then we prefer to use the configuration in functions_worker.yml. If not, we can inherit the broker-related configuration.
Another thing is, if we want to turn on TLS related encryption, we need to configure useTls: true in functions_worker.yml. But unfortunately, I didn’t find any hint about this option in the existing documentation.
Version
OS: Mac
Pulsar: 2.6.0

@wolfstudy I think that is expected. If Function Worker is running as part of broker, Function Worker will use the security settings from the broker. We should probably update the security-related documentation for Function Worker.

@wolfstudy The behavior is correct but there are a few places that we can improve.
In function worker, we need to separate client TLS settings from server TLS settings. #6602 already did that.
But we need to rename the following settings to make those broker client TLS settings clearer.
# the authentication plugin to be used by the pulsar client used in worker service
# clientAuthenticationPlugin:
# the authentication parameter to be used by the pulsar client used in worker service
# clientAuthenticationParameters:
# Accept untrusted TLS certificate from client
tlsAllowInsecureConnection: false

Add a setting for tlsEnableHostnameVerification.
After that, we need to enhance the logic in the broker to set the TLS settings to inherit from broker.conf for both client and server components.


implement simple rolling update using depends_on

what
Implement a simple rolling update for the aws_rds_cluster_instance default instances.
why
To implement a zero downtime deploy for simple changes.
references
closes #190

@finchr thanks. Did you also test this with a fresh deployment? (no reds deployed yet)

/terratest

@finchr I need to do some further review, but can you have a look at https://github.com/cloudposse/terraform-aws-rds-cluster/actions/runs/8057796243/job/22011400365?pr=191. At the end it shows what needs to be done.

@finchr I need to do some further review, but can you have a look at https://github.com/cloudposse/terraform-aws-rds-cluster/actions/runs/8057796243/job/22011400365?pr=191. At the end it shows what needs to be done.

Hi @hans-d , it's done.

/terratest

/terratest


Add ddev config local command to configure a config.local.yaml file

Is your feature request related to a problem? Please describe.
ddev config with all it's options is great to automate the project setup but it's currently not possible to make changes for the config.local.yaml.
Describe the solution you'd like
A new sub command ddev config local which saves the options to config.local.yaml instead of the config.yaml would be great and makes the configuration of local options much easier.
Describe alternatives you've considered
Currently the config.local.yaml has to be changed in the editor.

Not a bad idea at all. Not sure the name would be right, and it might be quite a lot of work. The main config.go is quite a mess.

The config.go command does not look so bad on a first sight. I see things which could be optimized like
	if hostHTTPSPortArg != "" {
		app.HostHTTPSPort = hostHTTPSPortArg
	}

	if hostDBPortArg != "" {
		app.HostDBPort = hostDBPortArg
	}

	// If the mariaDBVersionArg is set, use it
	if cmd.Flag("mariadb-version").Changed {
		app.MariaDBVersion = mariaDBVersionArg
	}

Tons of the same lines which could be reduced each one to one line only by using a function.
I'm happy to provide you a cleaner and shorter solution here and add the suggested change if I find the time.

I'm fine with this if somebody wants to spend some time on it, but don't think it's ever going to get prioritized otherwise. Closing for now.


Decouple router

For usage in other tooling and more flexible behaviour, the router Sylph uses should be decoupled from the source and made available externally.

Work pretty much done over in sylph-router, just gotta get the branch with the new routing integrated up.

Now live on NPM @ https://www.npmjs.com/package/sylph-router

Fully working in https://github.com/jetdevuk/sylph/commit/a45121721ce2561e835ff1c0a3dc080afa9d75ef


fix link for "Deploy Frontity using now (Vercel)"

Changed link for "Deploy Frontity using now (Vercel)" from github to docs.

Thanks @kuzvac
Approved & merged!


Kong 2.3.1 healthcheck

In 2.2.1
1 instance， 8 worker， http health check interval 10， 4 target  the health check is 24 per min
In 2.3.1
1 instance， 8 worker， http health check interval 10， 4 target  the health check is 24 * 8 per min
I think it‘s a bug

Hi @RyouZhang, thanks for your report!
Can you share more details about your environment? How is Kong started? How are you measuring this health check interval?

@RyouZhang, what is the Y-coordinate? CPU, memory, something else?

Hi @RyouZhang, we found out that you already described your environment in another issue, no need to update here.
We confirmed this is an issue, we are going to release a fix soon, thanks again for the report.

@RyouZhang, what is the Y-coordinate? CPU, memory, something else?

request nums


BUGFIX: adding zip hack to @propelleraero/cesium

Adding ?w=1 to the diff url will ignore most of the whitespace it can

Yes I tried that but it was still messy. It's not a big deal as this file is unlikely to change often.

I am getting back at this.
Do we think this approach is working or were there more problems?

Closing this PR as it's very old and not holding us up.


fix: Resolve security issues

:tada: This PR is included in version 1.5.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


1st pr

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: indrajit8981 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Mark this as invalid when you close it, this person is just trying to get PR's for Hacktoberfest (imo)

Thanks for taking the time to contribute this pull request. However, we are not able to accept contributions to this historical reference repository at this time.


Python 3 compatibility etc

Please don't regard this pull request as a floccinaucinihilipilification of the existing packaging. However, I have:

Added /examples
Added /tests
Fixed import so package builds
Moved to Python 3
Added data example, though not the best one I admit

Let me know if you want me to push it to PyPI.

Added picture to README.md

Thanks for adding stuff in. Appreciated.

sure, I realize I may have broken python 2. East enough to keep that but do you care?

There wasn't anything serious in your changes to break python3, although its a good step to make it compliant on both 2.7 and 3.x platforms.

Oh yeah you are right. I forgot py2 has both xrange and range. It's been so long. So nothing should be broken. You should put this on PyPI! I can add the github action if you want or you could imitate:

https://github.com/microprediction/humpday/blob/main/.github/workflows/deploy.yml


Incorrect syntax highlighting in TS

TS and JS Grammar Extension version:  0.0.53 / latest
Code
The following code breaks the syntax highlighting in typescript
// Please include a code snippet that demonstrates the issue
@Component({
  selector: 'foobar',
  styles: [(require<any>('./foobar.component.scss')).default.toString()],
  template: require('./foobar.component.html') as string,
  changeDetection: ChangeDetectionStrategy.OnPush,
})

I have no exact clue what could be wrong but if I comment out the styles property and then the syntax highlighting starts to work again.
Original issue:

After commenting out the styles property

I found the issue. It's with a Angular Essentials extension that I am using. When I disable it the syntax highlighting works there.


upgrade python-memcached

Coverage remained the same at 86.098% when pulling e642f9265ab2c9c742f092403cec89b6dc0c7bcd on peterbe:upgrade-python-memcached into 43d811cb7349027a3fce61796e1f642496f13127 on mozilla:master.


⚠ Secret Website 3 has degraded performance

In b85487d, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2106 ms

Resolved: Secret Website 3 performance has improved in e5f8dd0.


Added support for showing messages. Now, the log-in requirement messa…

Added support for showing messages. Now, the log-in requirement message is displayed using the new functionality.

All merged!


Expired token does not throw appropriate error

Steps to reproduce
Simply set up a simple Feathers application with authentication using JWT and set the expiresIn option to something like 15s. Then login using your preferred strategy and call authenticate() on a simple Feathers client. Wait for the TokenExpiredError in the server log and call authenticate() again (depends on your client setup, I just reload the page when using Vue and it attempts to authenticate).
Expected behavior
The call to authenticate with an expired token should throw an error saying something about the token having expired.
Actual behavior
The call to authenticate throws a "normal" not-authenticated with no mention of the token having expired.
System configuration
Tell us about the applicable parts of your setup.
Module versions (especially the part that's not working):
Server
@feathersjs/socketio: 3.2.0
@feathersjs/feathers: 3.1.3
@feathersjs/authentication: 2.1.2
@feathersjs/authentication-jwt: 2.0.0
Client
@feathersjs/authentication-client: 1.0.2
@feathersjs/feathers: 3.1.4
NodeJS version:
9.10.1
Operating System:
Windows 10 Subsystem for Linux Ubuntu Bash

Client side JWT validation and parsing should no longer be necessary in Feathers v4 authentication. Please see the migration guide for more information. Closing this issue in order to archive this repository. Related issues can be opened at the new code location in the Feathers main repository.


simplified ordinalDate filter

Hi, thanks for this. Unfortunately your changes cause the unit tests to fail. Try running grunt karma:unit and you'll see what is failing. Feel free to submit further pull requests if you manage to simplify the code whilst also passing the unit tests.

Hi, I found why the tests were failing. Now they should all pass.

Excellent, very good work. :+1:
Gonna merge and then I'll just need to change your ES6 arrow function to a regular function, since we need to support ES5 environments.


Edit inherit list in showcase.gwt.xml

Added Resources and logging dependencies to Showcase.gwt.xml

Ship it!


Added multi t, and tidied up the types a little

@bicycle1885 This is untested. Please test a few cases for multiple processes and different timesteps per batch, then merge?

I added some tests so that we won't break it in the future.


Installer component of Managed Cloud SDK.

I think these install scripts come from the google-cloud-sdk (part of the downloaded archive)?  Do we actually need to execute them?  The README notes that it's optional.

Optional. Run the install script to add Cloud SDK tools to your path, enable command-completion in your bash shell (Linux and Mac OS only) and enable usage reporting.

On Linux or Mac OS X:
./google-cloud-sdk/install.sh
On Windows:
.\google-cloud-sdk\install.bat
Run install.sh --help or install.bat --help for a list of flags you can pass to this script.

@elharo, you make a valid point on internal, I'll rearrange all this with the glue CL for the installer.


globalThis.localStorage is invoked resulting in exception

Bug report
Describe the bug
The reference to globalThis.localStorage results in an exception which breaks supabase due to specifics of the environment, which is internal browser page (in this case, about:preferences). There is no concept of localStorage.
It isn't clear what the purpose is of localStorage, but the presence of persistSession and the code seems to indicate it is simply to store and recover the session.
If persistSession is set to false, I wouldn't expect localStorage to be required (either on globalThis, or an alternative provide), but that isn't the case due to the following line:
https://github.com/supabase/gotrue-js/blob/master/src/GoTrueClient.ts#L99
"    this.localStorage = settings.localStorage || globalThis.localStorage"
This line requires one of them to be implemented. That would be fine except that attempting to access globalThis.localStorage generates an exception in my environment.
To Reproduce
Not exactly the same but you can see the exception that is causing the issue:

In Firefox open about:preferences
Open '...' -> More Tools -> Web Developer Tools
In the console, type globalThis.localStorage and hit enter
See error:

>> globalThis.localStorage
Uncaught
Exception { name: "NS_ERROR_NOT_AVAILABLE", message: "", result:<PHONE_NUMBER>, filename: "debugger eval code", lineNumber: 1, columnNumber: 0, data: null, stack: "@debugger eval code:1:1\ngetEvalResult@resource://devtools/server/actors/webconsole/eval-with-debugger.js:243:24\nexports.evalWithDebugger@resource://devtools/server/actors/webconsole/eval-with-debugger.js:167:14\nevaluateJS@resource://devtools/server/actors/webconsole.js:1118:38\nevaluateJSAsync/<@resource://devtools/server/actors/webconsole.js:1010:35\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22\n", location: XPCWrappedNative_NoHelper }

Expected behavior
I expect it to not access globalThis.localStorage if persistSession is false.
Alternative, the exception should be caught.
System information

OS: macos
Browser (if applies) Firefox 104.0.2 (64-bit)
Version of supabase-js:  1.35.6
Version of Node.js: v16.15.0

The following diff should do the trick but I've not been able to test due to difficulties build:
diff --git a/src/GoTrueClient.ts b/src/GoTrueClient.ts
index 900bc55..021798c 100644
--- a/src/GoTrueClient.ts
+++ b/src/GoTrueClient.ts
@@ -61,11 +61,11 @@ export default class GoTrueClient {

   protected autoRefreshToken: boolean
   protected persistSession: boolean
-  protected localStorage: SupportedStorage
+  protected localStorage: SupportedStorage | null
   protected multiTab: boolean
   protected stateChangeEmitters: Map<string, Subscription> = new Map()
   protected refreshTokenTimer?: ReturnType<typeof setTimeout>
-  protected networkRetries: number = 0
+  protected networkRetries = 0

   /**
    * Create a new client for use in the browser.
@@ -96,7 +96,11 @@ export default class GoTrueClient {
     this.autoRefreshToken = settings.autoRefreshToken
     this.persistSession = settings.persistSession
     this.multiTab = settings.multiTab
-    this.localStorage = settings.localStorage || globalThis.localStorage
+    if (settings.persistSession) {
+      this.localStorage = settings.localStorage || globalThis.localStorage
+    } else {
+      this.localStorage = null
+    }
     this.api = new GoTrueApi({
       url: settings.url,
       headers: settings.headers,
diff --git a/src/lib/types.ts b/src/lib/types.ts
index fd2d7d2..c0d2829 100644
--- a/src/lib/types.ts
+++ b/src/lib/types.ts
@@ -221,4 +221,6 @@ type PromisifyMethods<T> = {
     : T[K]
 }

-export type SupportedStorage = PromisifyMethods<Pick<Storage, 'getItem' | 'setItem' | 'removeItem'>>
+export type SupportedStorage = PromisifyMethods<
+  Pick<Storage, 'getItem' | 'setItem' | 'removeItem'>
+> | null

FWIW, I tried to implement the diff above, but I gave up due to the multiple packages that needed building. I hope someone with a currently working dev environment could give it a quick test.

@davidmaxwaterman localstorage indeed is used to store and recover the session.
Unfortunately the required change to fix your issue in v1 isn't as easy as your above diff. There are plenty of calls on this.localStorage.(set|get|remove)Item() so setting this.localStorage to null would throw errors all over the place. As an example check _recoverSession() that gets called a couple lines below your intended changes. It passes localStorage to getItemSynchronously that then calls localStorage.getItem().
https://github.com/supabase/gotrue-js/blob/5609423858cb86cb8eebdaeee662e7598b4e20ab/src/GoTrueClient.ts#L630-L633
I created a draft PR #436, that tries to fix your issue in the release candidate of v2. Unfortunately i can't really test it as i don't have a browser without localStorage. Could you try it in your project? You would have to install supabase-js@rc, clone and checkout the PR and run npm install && npm run build. Then you could link it into your project.
For v1 the best workaround is probably to either pass an in memory storage or a noop storage. Both should be fine. An in memory storage is more likely to behave like a usual browser client.
class InMemoryStorage {
  constructor() {
    this._storage = new Map();
  }

  setItem(key, value) {
    this._storage.set(key, value);
  }

  getItem(key) {
    return this._storage.has(key) ? this._storage.get(key) : null;
  }

  removeItem(key) {
    this._storage.delete(key);
  }
}

const supabase = createClient(URL, ANON_KEY, {localStorage: new InMemoryStorage()})

class NoopStorage {
  setItem(key, value) {}

  getItem(key) {
    return null;
  }

  removeItem(key) {}
}

const supabase = createClient(URL, ANON_KEY, {localStorage: new NoopStorage()})

Unfortunately the required change to fix your issue in v1 isn't as easy as your above diff.
I guess I didn't check them all, but the ones I saw were all protected with optional chaining eg:
  const value = isBrowser() && storage?.getItem(key)

https://github.com/supabase/gotrue-js/blob/5609423858cb86cb8eebdaeee662e7598b4e20ab/src/lib/helpers.ts#L63
TBH, I found that odd since the TS definitions supposedly prevented it from being null/undefined.

For v1 the best workaround is probably to either pass an in memory storage or a noop storage.

This is what I've done, so I'm good since you've stated that this is the purpose of the use of localStorage. I'm still prototyping to decide if I can/want to use Supabase, so it is quite possible I will end up putting in some kind of alternative implementation to serve the same purpose.

If you are using Supabase Auth on a non-browser environment where there's no localStorage you need to provide an alternative storage provider using the storage option.
Unfortunately, to keep compatibility with many environments we'd rather have this code crash and make it apparent that you need to specify a storage provider instead of failing silently or using RAM-based storage.
Do continue the discussion or re-open the issue if you feel I've not considered all points.

Well, I gave up trying Supabase in the end, so this is ok by me. Still, I am little surprised by your decision since it seems to be the objective of the persistSession variable to avoid the use of (and therefore need of) localStorage. Anyway, your call.


Minor fix for the init_customers command

Catch the InvalidRequestError during an init_customers call.
For an existing userbase, it was raising the following exception:
File "VENV/pinax/stripe/actions/customers.py", line 58, in create
  invoices.create_and_pay(cus)
File "VENV/pinax/stripe/actions/invoices.py", line 40, in create_and_pay
  invoice = create(customer)
File "VENV/pinax/stripe/actions/invoices.py", line 27, in create
  return stripe.Invoice.create(customer=customer.stripe_id)
File "VENV/stripe/resource.py", line 466, in create
  response, api_key = requestor.request('post', url, params, headers)
File "VENV/stripe/api_requestor.py", line 140, in request
  resp = self.interpret_response(rbody, rcode, rheaders)
File "VENV/stripe/api_requestor.py", line 288, in interpret_response
  self.handle_api_error(rbody, rcode, resp, rheaders)
File "VENV/stripe/api_requestor.py", line 159, in handle_api_error
  rbody, rcode, resp, rheaders)
stripe.error.InvalidRequestError: Request req_ABCDEFGH: Nothing to invoice for customer

I made this naive fix, which seems to have no side effect.
Cheers

This is a duplicate of #324

Indeed, plus you've set up a test to ensure no regression 👍


[FEATURE] Implement a rate-limiter for API calls

Not sure if this should be a feature inside this library, or if a rate-limit is more a task for the custom API-client implementation. We've implemented the rate-limit using symfony/rate-limiter with token-bucket limiter which works amazing. Little downside is, that our API-service needs to implement the logic right before each API request (e.g. $this->api->voucher()->create($data);). So it's a bit of repeating-code always adding the check before each API request.
Because the LexOffice API introduces the rate-limit for everyone, maybe it makes sense to have it implemented inside this library (including configuration options in case there will be different limits for different plans in the future, or to disable it entirely). We think a good place would be in Api::getResponse(), right before $this->client->send($this->request)?!
Any feedback appreciated.

Hello @Moongazer,
that is a great Idea to implement it, But we are trying to not bloat the library too much.
In the 1.0-dev branch the caching is already removed.
The reason behind is, that guzzlehttp/guzzle has already middlewares which support each use case.
You can pass a \GuzzleHttp\Client as the second Parameter of your \Clicksports\LexOffice\Api Instance.
There you have choices of the guzzle community like following packages:

guzzle-cache-middleware
guzzle-rate-limiter-middleware

And other great middlewares from other contributors :)

Hey @Sysix
thanks for your fast response, and I fully agree to keep it slim as possible without any dependencies (didn't thought of that).
Also I didn't know that such features are available as Guzzle middleware, how awesome! Are there any plans when to release v1.0?

Are there any plans when to release v1.0?

Not yet. I can't provide at the moment more information


Replication plan always changes after 'deletion' option is edited once

When creating a replication with this code :
resource "harbor_replication" "proxycache-cn-north-1" {
  name        = "proxycache-cn-north-1"
  action      = "push"
  override    = false
  registry_id = harbor_registry.cn-north-1.registry_id
  schedule    = "0 */10 * * * *"
  filters {
    name = "cdsf/**"
  }
  filters {
    resource = "image"
  }
}

the creation is ok.
But then, if we update the replication in Harbor UI to set to even_based with deletion enabled we have this result at the next terraform launch (which is normal):
# harbor_replication.proxycache-cn-north-1 will be updated in-place

  ~ resource "harbor_replication" "proxycache-cn-north-1" {
      ~ deletion              = true -> false
        id                    = "/replication/policies/10"
        name                  = "proxycache-cn-north-1"
      ~ schedule              = "manual" -> "0 */10 * * * *"
        # (5 unchanged attributes hidden)
        # (2 unchanged blocks hidden)
    }

but after applying :

the schedule part is modified as planned
the deletion is not modified (because the schedule mode is event_based which does not have the delete option)

And from there, the deletion change will always appears in all the next terraform plans without changing any code :
 ~ deletion              = true -> false
Harbor Version v2.4.0-d4affc2e
Provider version : 3.4.4
Additionnal point : when we look at the documentation, the even_based is missing (only  manual and schedule are).

hi,
with latest terraform provider, I don't have the issue


Latency report file from perf analyzer is not found

While profiling, the checkpoints are stored appropriately, but there seems to be intermediate latency report files generated by perf analyzer which are not found and causing the below error.
This is my Job.yaml file
apiVersion: batch/v1
kind: Job
metadata:
  name: {{ .Release.Name }}-model-analyzer
  labels:
    app: {{ .Release.Name }}-model-analyzer
    chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
    release: {{ .Release.Name }}
spec:
  backoffLimit: 5
  activeDeadlineSeconds: {{ .Values.jobTimeout }}
  template:
    spec:
      shareProcessNamespace: true
      restartPolicy: OnFailure
      volumes:
        - hostPath:
            path: /s/k3/
            type: Directory
          name: scratch
        - configMap:
            name: analyzer-config
          name: config
      terminationGracePeriodSeconds: 1800
      containers:
      - name: analyzer
        image: {{ .Values.images.analyzer.image }}
        imagePullPolicy: IfNotPresent
        securityContext:
            privileged: true
        command: ["/bin/bash", "-c"]
        args: [
          "model-analyzer profile
          --model-repository /models
          --output-model-repository /output_models/output
          --checkpoint-directory /checkpoints/
          --triton-launch-mode local -f /config/config.yaml
          && model-analyzer analyze -e /results/
          --checkpoint-directory /checkpoints/
          -f /config/config.yaml
          && model-analyzer report -e /results/
          --checkpoint-directory /checkpoints/
          -f /config/config.yaml"]
        volumeMounts:
            - name: scratch
              mountPath: /results
              subPath: results
            - name: scratch
              mountPath: /models
              subPath: models
            - name: scratch
              mountPath: /output_models
              subPath: output-models
            - name: scratch
              mountPath: /checkpoints
              subPath: checkpoints
            - name: config
              mountPath: /config

The error log is attached below
Details

Matplotlib created a temporary cache directory at /tmp/matplotlib-2qa7cu2g because the default path (/.config/matplotlib) is not a writable directory; it is highly recommended to set the MPLCONFIGDIR environment variable to a writable directory, in particular to speed up the import of Matplotlib and to better support multiprocessing.
[Model Analyzer] Initializing GPUDevice handles
[Model Analyzer] Using GPU 0 Tesla T4 with UUID GPU-d3e4feb1-072a-c3ab-86b7-fb577104ef77
[Model Analyzer] WARNING: Overriding the output model repo path "/output_models/output"
[Model Analyzer] Starting a local Triton Server
[Model Analyzer] Loaded checkpoint from file /checkpoints/2.ckpt
[Model Analyzer] GPU devices match checkpoint - skipping server metric acquisition
[Model Analyzer]
[Model Analyzer] Starting Optuna mode search to find optimal configs
[Model Analyzer]
[I 2024-10-08 14:29:18,355] A new study created in memory with name: bge-small-en-v1.5-onnx
[Model Analyzer] Measuring default configuration to establish a baseline measurement
[Model Analyzer] Creating model config: bge-small-en-v1.5-onnx_config_default
[Model Analyzer]
[Model Analyzer] Profiling bge-small-en-v1.5-onnx_config_default: concurrency=16
[Model Analyzer] Saved checkpoint to /checkpoints/3.ckpt
Traceback (most recent call last):
File "/usr/local/bin/model-analyzer", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.10/dist-packages/model_analyzer/entrypoint.py", line 278, in main
analyzer.profile(
File "/usr/local/lib/python3.10/dist-packages/model_analyzer/analyzer.py", line 131, in profile
self._profile_models()
File "/usr/local/lib/python3.10/dist-packages/model_analyzer/analyzer.py", line 251, in _profile_models
self._model_manager.run_models(models=[model])
File "/usr/local/lib/python3.10/dist-packages/model_analyzer/model_manager.py", line 154, in run_models
measurement = self._metrics_manager.execute_run_config(run_config)
File "/usr/local/lib/python3.10/dist-packages/model_analyzer/record/metrics_manager.py", line 245, in execute_run_config
measurement = self.profile_models(run_config)
File "/usr/local/lib/python3.10/dist-packages/model_analyzer/record/metrics_manager.py", line 278, in profile_models
perf_analyzer_metrics, model_gpu_metrics = self._run_perf_analyzer(
File "/usr/local/lib/python3.10/dist-packages/model_analyzer/record/metrics_manager.py", line 618, in _run_perf_analyzer
status = perf_analyzer.run(metrics_to_gather, env=perf_analyzer_env)
File "/usr/local/lib/python3.10/dist-packages/model_analyzer/perf_analyzer/perf_analyzer.py", line 235, in run
self._parse_outputs(metrics)
File "/usr/local/lib/python3.10/dist-packages/model_analyzer/perf_analyzer/perf_analyzer.py", line 535, in _parse_outputs
self._parse_generic_outputs(metrics)
File "/usr/local/lib/python3.10/dist-packages/model_analyzer/perf_analyzer/perf_analyzer.py", line 551, in _parse_generic_outputs
with open(perf_config["latency-report-file"], mode="r") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'bge-small-en-v1.5-onnx-results.csv'

These files are written when PA terminates the profile, read and then deleted by MA. If it doesn't exist that indicates that PA had some sort of issue/failure. Can you please include the log from the PA run? Thank you.

I enabled below flags from perf analyzer but no logs are written in this file
    perf_output: true
    perf_output_path: /results/output.txt


Should we track which archive rows came from?

We may want to keep track of what data came from which archive. For example, if a user wants to delete one of their archive uploads, or to reason about changes in time over separate uploads from the same user.
Archives are defined by the user they belong to + the date at which they were requested (proxied in the archive_at column in the account and profile tables, which is the date of the most recent tweet in the archive)
It's easy to know which archive upload accounts and profiles are from, they come from the account_id at archive_at time.
Following, Follower, and Tweet track the user_id although not the specific archive upload time. Which is fine because right now we're just deleting tweets and follower/following and reuploading them whenever a user uploads a new archive.
In the future we may want to keep snapshots of follower/following at different times, which would need us to keep track of what archive they came from.
We wouldn't necessarily want to keep snapshots of tweet collections at different times. If users delete tweets and they're not present in a subsequent archive upload, there's not much reason for us to keep the tweets that were uploaded before but are deleted now.
The only reason I can think of to track what archive tweets belong to is if we start scraping tweets in other ways (since I think archives only include all tweets from the user, none from others), and if we store them in the same table. I think if we started scraping we might want to keep them in a different table and make a view that joins scraped and archive tweets anyway.

my current answer is "don't bother, but good to document this thought process"

Changed my mind I think it's worth it for the convenience of tracking which archive uploads things came from. We already have an archive-upload table that just tracks what time it was uploaded and is referenced by account and profile, just need to add a column in tweets and followed/following relationships


Convert to using leaderboards over hardcoded ratings

Fixes #1791
Converts to using leaderboards over hardcoded ratings everywhere. Keeps ratingMode for current compatibility until rating type is included in game launch message.
Full functionality requires migration of rating changes to the leaderboard journal table.
Rating changes per game takes the first leaderboard change in the list until a main leaderboard is specified by the server.

Still need to fix tests

tests fixed

Hoping to merge this soon

Hoping to merge this soon


Release of version <IP_ADDRESS> of xWebAdministration

Releasing version <IP_ADDRESS>

This change is

@tysonjhayes @regedit32 @gaelcolas Release of this module is blocked by failing tests. Looks like PSSA errors. Let me know when it's fixed and then release can move forward.

@kwirkykat There is a reported bug in PSScriptAnalyzer for that https://github.com/PowerShell/PSScriptAnalyzer/issues/1192. Once that is merged and a new release of PSScriptAnalyzer is made we can move forward with this. If we want to release this prior we should change the test framework to use an older version of PSScriptAnalyzer.
/cc @gaelcolas @PlagueHO @ykuijs

There is a workaround : move the super class to the top of the schema file. PSSA is only checking the first class in the schema.

I'll take this for action and apply the PSSA rule suppression until the fix to PSScriptAnalyzer is released

Codecov Report

Merging #421 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   90.77%   90.77%
=======================================
  Files          17       17
  Lines        2438     2438
=======================================
  Hits         2213     2213
  Misses        225      225

Impacted Files
Coverage Δ

DSCResources/Helper.psm1
90% <100%> (ø)
:arrow_up:

DSCResources/MSFT_xWebsite/MSFT_xWebsite.psm1
97.11% <100%> (ø)
:arrow_up:

...SCResources/MSFT_xIisLogging/MSFT_xIisLogging.psm1
97.74% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9795b3a...fe3781e. Read the comment docs.

fix merged to dev branch


table/builder: remove unsafe operation to support more platform

The code with unsafe type conversion depends on 64bit little-endian architecture.
And all modern CPU architecture supports little-endian, we can safely depend on it.


Prevent extra CmdlineChanged event when using {reg} on cmdline.

Fix #8219

Fixed via https://github.com/vim/vim/commit/796139ae3ac89e27ee96dce3c7fdb87d8c839f53

Oh, I didn't understand the code correctly...
Thank you for adding clear comments, and for fixing the issue:)


Avoid evicting cache entry if settled

If the cacheEntry is aborted and settled, it still evicts it here, which I think is undesired behavior. It should avoid evicting here if it was already settled

Codecov Report

Merging #12 (506a1ff) into master (737d953) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   86.32%   86.32%
=======================================
  Files           4        4
  Lines         117      117
  Branches       30       30
=======================================
  Hits          101      101
  Misses         16       16

Impacted Files
Coverage Δ

src/AbortablePromiseCache.ts
83.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 737d953...506a1ff. Read the comment docs.

Xref https://github.com/GMOD/jbrowse-components/pull/1783 should fix the bai getting redownloaded

ooooh nice catch

released in 1.4.1


Update Fmod.gdnlib

Due to fatigue or just not paying attention I actually didn't fully fix the issue with the linux binaries' path being incorrect.
An additional .64 should be added to make it have the exact same name as the one in the release 👌
Apologies!

Due to fatigue or just not paying attention I actually didn't fully fix the issue with the linux binaries' path being incorrect.
An additional .64 should be added to make it have the exact same name as the one in the release 👌
Apologies!

Did not see it when reviewing too ! Sorry !

Due to fatigue or just not paying attention I actually didn't fully fix the issue with the linux binaries' path being incorrect.
An additional .64 should be added to make it have the exact same name as the one in the release 👌
Apologies!

Did not see it when reviewing too ! Sorry !