[firebase_messaging] Android: Memory Leak

Currently, the background handling in FlutterFirebaseMessagingService is leaking the backgroundChannel property. This get's evident by activating LeakCanary and moving the App from FG to BG:
D  ┬
D  ├─ android.net.ConnectivityThread
D  │    Leaking: NO (PathClassLoader↓ is not leaking)
D  │    Thread name: 'ConnectivityThread'
D  │    GC Root: Thread object
D  │    ↓ thread ConnectivityThread.contextClassLoader
D  ├─ dalvik.system.PathClassLoader
D  │    Leaking: NO (Object[]↓ is not leaking and A ClassLoader is never leaking)
D  │    ↓ PathClassLoader.runtimeInternalObjects
D  ├─ java.lang.Object[]
D  │    Leaking: NO (FlutterFirebaseMessagingService↓ is not leaking)
D  │    ↓ array Object[].[1679]
D  ├─ io.flutter.plugins.firebasemessaging.FlutterFirebaseMessagingService
D  │    Leaking: NO (a class is never leaking)
D  │    ↓ static FlutterFirebaseMessagingService.backgroundChannel
D  │                                             ~~~~~~~~~~~~~~~~~
D  ├─ io.flutter.plugin.common.MethodChannel
D  │    Leaking: UNKNOWN
D  │    ↓ MethodChannel.messenger
D  │                    ~~~~~~~~~
D  ├─ io.flutter.view.FlutterNativeView
D  │    Leaking: UNKNOWN
D  │    ↓ FlutterNativeView.mPluginRegistry
D  │                        ~~~~~~~~~~~~~~~
D  ├─ io.flutter.app.FlutterPluginRegistry
D  │    Leaking: UNKNOWN
D  │    ↓ FlutterPluginRegistry.mActivity
D  │                            ~~~~~~~~~
D  ╰→ com.company.app.MainActivity
D       Leaking: YES (Activity#mDestroyed is true and ObjectWatcher was watching this)
D       key = 1fd3d04b-7f8d-4bbf-99ae-440d0fb8146c
D       watchDurationMillis = 5307
D       retainedDurationMillis = 306
D  , retainedHeapByteSize=160758)], libraryLeaks=[])

Expected behavior
No memory leaks.
Additional context
As @kroikie put it in the comments within service class, the isolate/instance stuff must not be static.

I got regular memory leaks from Flutter on Android since I added Firebase Messaging. Is there any way to work around?

@ghivert the plugin is currently being reworked and the memory issues will be addressed. I'm sure @Ehesp and @Salakar will come back to this issue.

Hey would you be able to try out the reworked version and see if this is now sorted for you - currently a dev release (8.0.0-dev.5) - PR #4012 for reference, migration guide has also been updated: https://firebase.flutter.dev/docs/migration/
For discussion please see https://github.com/FirebaseExtended/flutterfire/discussions/4023


name change & brew

name change -> all to cb$name
e.g. cbwebserver (this would be the new name for the tf_web)
CB stands for CrystalBot
see if we can create a brew formula for it, does it install without security issues?
This would hugely improve the way how we deploy progs.
https://docs.brew.sh/Formula-Cookbook
If it works would use it to package 3sdk as well
test on Linux also
https://github.com/Homebrew/linuxbrew-core
requirements

[ ] only need default brew env (no need for Xcode on osx)
[ ] brew install cbweb installs cbwebserver, cb...
[ ] no security issues, runs right away without having to force OSX security permissions
[ ] put in core repo's of brew for Linux & OSX (pull request)
[ ] have our own casq as well using also the github actions to build ourselves, so we can test without having to resort to the core of brew

questions

[ ] can we do this for js_ng as well, but not sandboxed in virtualenv !
[ ] if we have a new build how do we force the core brew guide to build a new version?

remarks

will only use this for the desktop apps

The current version of crystal for brew is broken during building, There is a recent issue opened on their repo https://github.com/crystal-lang/crystal/issues/9148
Error  messages

blocked on https://github.com/crystal-lang/crystal/issues/9148


Test: Integration of vscode-tslint with a gulp

Microsoft/vscode-tslint#89

[ ] Any platform @sandy081

Complexity - 2
Setup

install the vscode-tslint extension and its prereqs tslint and typescript
Follow the documentation in the README to setup a task runner and a vscode task.

Test

Run the task runner to lint the entire project and then fix the warnings.

Verify that you see no duplicate warnings in the problems view

Ref : https://github.com/Microsoft/vscode-tslint/issues/100


Update pkg dependency for genref

@tengqm Thanks a lot for your super quick reviews on all these PRs, it's really appreciated :-) Is there anything else I need to do to complete this? The markup on https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/ is still the old one, but the new CSS/JS is already live.


Add "Try Lighthouse" page

POC for now to see how things can work on staging. Purposefully not creating any pointer links.
This also updates our template files to set a correct meta viewport.

PTAL


sim/rptun: support multi(>2) core interactive by share memory

Summary
Support multi >2 core interactive by share memory in simulation.
Example of relationships between the three processes:
AP->BP
AP->CP
BP->CP
Impact
Support multi-core heterogeneous simulation.
Testing
daily test.

This patch depends on #3726 3726 and #3720, please review and merge them firsty .Thank you!

This patch depends on #3726 3726 and #3720, please review and merge them firsty .Thank you!

Hi @Donny9 I think you repeated #3726, it should be other PR.

This patch depends on #3726 3726 and #3720, please review and merge them firsty .Thank you!

Hi @Donny9 I think you repeated #3726, it should be other PR.

I modify this patch base #3726,  #3726 is a modification of the original code.


Null check operator used on a null value

please what's this error

@NevilleAdrian
can you provide your flutter doctor -v, your flutter run -v and a minimal reproducible code sample

@NevilleAdrian
That seems to be coming due to null safety. Please google for the error and you'll get some idea around as why you are getting it. Also, please provide the requested details above to properly address your issue.


com.android.library cannot be found

I installed tdlib for android kotlin from here.
I get an error when building:
A problem occurred evaluating root project 'libtd'.
> Plugin with id 'com.android.library' not found.

* Exception is:
org.gradle.api.GradleScriptException: A problem occurred evaluating root project 'libtd'.
//141 internal lines
Caused by: org.gradle.api.plugins.UnknownPluginException: Plugin with id 'com.android.library' not found.
//8 internal lines
	at build_bwkdvend59taqr6eiohm5mbrp.run(C:\Users\Daniel\AndroidStudioProjects\libtd\build.gradle:7)
//1 internal line
... 140 more

I'm using:
Android Studio Chipmunk | 2021.2.1 Beta 3
Build #AI-212.5712.43.2112.8184640, built on February 15, 2022
Runtime version: 11.0.12+7-b1504.28-7817840 amd64
VM: OpenJDK 64-Bit Server VM by Oracle Corporation
Windows 10 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 1280M
Cores: 8
Registry: external.system.auto.import.disabled=true

You need to update build.gradle of your app. See https://stackoverflow.com/questions/30932278/plugin-with-id-com-android-library-not-found.


ModuleNotFoundError: No module named 'datasets'

UPD-main/scripts/convert_mmbench_for_submission.py", line 5, in
from datasets import load_dataset
ModuleNotFoundError: No module named 'datasets'
Could you tell me the datasets folder download link?

@alice-cool
Thanks for your interest!
Could you please run pip install datasets==2.18.0 following project.toml?
Thank you!

Hello ，can you give me some suggestions about this error? Hope for your reply.
---Original---
From: "Atsuyuki @.>
Date: Tue, Jul 2, 2024 10:33 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [AtsuMiyai/UPD] ModuleNotFoundError: No module named 'datasets'(Issue #2)
@alice-cool
Thanks for your interest!
Could you please run pip install datasets==2.18.0 following pyproject.toml?
Thank you!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@alice-cool
Hello!
I think you do not install datasets module.
Could you try pip install datasets==2.18.0?

I want to ask about the following picture. I may fail to send it in the previous dialogue. Could you give me some suggestions? Thanks for your quick reply. Hope for your suggestions.

@alice-cool
Oh, thanks for your point!
After merging the pull request and updating transformers version, an error occurred due to a change in the transformers' specifications.
Could you add inputs.pop("cache_position") following https://github.com/AtsuMiyai/UPD/commit/8fac80d1399fbb6bb566e95d8d195f64aaf30928

@alice-cool Oh, thanks for your point!
After merging the pull request and updating transformers version, an error occurred due to a change in the transformers' specifications.
Could you add inputs.pop("cache_position") following 8fac80d

Thank you four your reply. It works well.

Hello I use lava13b to get the  prediction results. So I use Evaluation section to evaluate my prediction accuracy rate. But I got the error to input the Openai key. But I don't have Openai key, and I use the llava (which doesn't need API key.) So how can I evaluate my lava13b prediction results? Hope for your reply.

Yes, you need to register openai_api_key for the evaluation!
Please refer to the requirements section!


Renamed to System.Activities

For backward compatibility. Everything still works as far as I can tell.

What did you do with the CoreWf.Transactions code? System.Transactions is part of .NET Core 2.0 but not part of .NET Standard. I copied the code to CoreWf.Transactions to get unblocked but I'm curious if you rename it back to System.Transactions then using System.Activities in a .NET Core project may have a conflict.

I didn't give it much thought :) But it's called System.Activities.Transactions, so there shouldn't be any conflicts. But it does seem to be a part of .Net Standard 2.0 now, so maybe we can do better here.

@dmetzgar Check #53.


change NODE_BIN detection

change
NODE_BIN = getattr(os.environ, "NODE_BIN") if hasattr(os.environ, "NODE_BIN") else "node"

to
NODE_BIN = os.environ.get("NODE_BIN", "node")

at
https://github.com/extremeheat/JSPyBridge/blob/master/src/javascript/connection.py#L9
currently to change the node path we have to do this setattr(os.environ, 'NODE_BIN', NODE_PATH) then npm path like this os.environ['NODE_PM'] = NPM_PATH this is not interchangeable, but doing the recommend changes both could be change with the same (later) method
additionally allows the better use of python nodejs-bin  package to setup in remote python environments the current working method is
import nodejs
import os
from pathlib import Path

setattr(os.environ, 'NODE_BIN', str(Path(nodejs.__file__).parent.joinpath("node.exe")))
os.environ['NODE_PM'] = str(Path(nodejs.__file__).parent.joinpath("npm.cmd"))

import javascript

sass = javascript.require("sass")

pip install nodejs-bin javascript

You're right, this should be using .get(). Feel free to open a PR to fix. For compatibility in case anyone is depending on the attribute behavior instead of assigning to the dictionary, it would probably make sense to keep the current check as a fallback.


Select the release with the matching GTIN if iTunes API returns multiple

https://harmony.pulsewidth.org.uk/release?gtin=197875266348&itunes=&region=GB&ts=1717477988

iTunes: The API also returned 1 other result, which was skipped: https://music.apple.com/gb/album/1702051779

The other result would have been the correct one with GTIN<PHONE_NUMBER>48.

iTunes: Extracted GTIN<PHONE_NUMBER>95 (from artwork URL) does not match the looked up value<PHONE_NUMBER>48

In this case, both image URLs contain the corresponding barcode, but this is not always the case unfortunately:
https://harmony.pulsewidth.org.uk/release?gtin=882951718827&itunes=&region=GB&ts=1717495471

iTunes: The API also returned 1 other result, which was skipped: https://music.apple.com/gb/album/600624295

That would've been the correct result 🫤
Another example where GTIN would help: https://harmony.pulsewidth.org.uk/release?gtin=822603266801&itunes=&region=GB&ts=1717435544

Fixed (as far as possible) in https://github.com/kellnerd/harmony/commit/ab6408cb8e2f7c7920dffb75c04b09b2d62a5f08


Rename the repo and turn "laravel5" branch into "master"

As Laravel 5 is now official and stable, it's probably the perfect time to make these tiny but important updates. Imho, a slightly different but simpler name such as "laralang", "laralangs" or "laravel-lang" would be even better. What's your thought?

Hello,
this repository will be updated this week-end

Nice, thanks :+1:

done, sorry for the delay


issue #3741: attempt to fix terminal color output in Windows (#3753)

Pushed fix for the fix https://github.com/arangodb/arangodb/pull/3753#issuecomment-349942747


Removed invalid await from grpc async call

All Submissions:

[x] Contributions should target the dev branch. Did you create your branch from dev?
[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:
This PR only removes invalid await clause from initialising grpc request. The existing await was causing folowing exception (on version 1.11.2):
   2597     if isinstance(shard_key, get_args_subscribed(models.ShardKey)):
   2598         shard_key = RestToGrpc.convert_shard_key(shard_key)
-> 2599     request = await grpc.CreateShardKey(
   2600         shard_key=shard_key,
   2601         shards_number=shards_number,
   2602         replication_factor=replication_factor,
   2603         placement=placement or [],
   2604     )
   2605     return (
   2606         await self.grpc_collections.CreateShardKey(
   2607             grpc.CreateShardKeyRequest(
   (...)
   2611         )
   2612     ).result
   2613 else:

TypeError: object CreateShardKey can't be used in 'await' expression

I've tested the local behaviour with a positive result.

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

Hi @VanaMartin
Thank you for your contribution
However, we can't accept it right now, because async client is auto-generated from sync client and changes to async files can't be done without altering either sync client or generator code
We'll investigate the issue

I have found and fixed the issue and extended tests coverage


Xauthority error

Hello,
Running, docker exec selenium-chrome ilovemepaws, I go this error:
  File "/home/seluser/.local/lib/python3.6/site-packages/Xlib/xauth.py", line 43, in __init__
    raw = open(filename, 'rb').read()
IsADirectoryError: [Errno 21] Is a directory: '/home/seluser/.Xauthority'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/ilovemepaws/ilovemepaws", line 7, in <module>
    import pyautogui
  File "/home/seluser/.local/lib/python3.6/site-packages/pyautogui/__init__.py", line 241, in <module>
    import mouseinfo
  File "/home/seluser/.local/lib/python3.6/site-packages/mouseinfo/__init__.py", line 223, in <module>
    _display = Display(os.environ['DISPLAY'])
  File "/home/seluser/.local/lib/python3.6/site-packages/Xlib/display.py", line 80, in __init__
    self.display = _BaseDisplay(display)
  File "/home/seluser/.local/lib/python3.6/site-packages/Xlib/display.py", line 62, in __init__
    display.Display.__init__(*(self, ) + args, **keys)
  File "/home/seluser/.local/lib/python3.6/site-packages/Xlib/protocol/display.py", line 61, in __init__
    name, host, displayno)
  File "/home/seluser/.local/lib/python3.6/site-packages/Xlib/support/connect.py", line 91, in get_auth
    return mod.get_auth(sock, dname, host, dno)
  File "/home/seluser/.local/lib/python3.6/site-packages/Xlib/support/unix_connect.py", line 103, in new_get_auth
    au = xauth.Xauthority()
  File "/home/seluser/.local/lib/python3.6/site-packages/Xlib/xauth.py", line 45, in __init__
    raise error.XauthError('~/.Xauthority: %s' % err)
Xlib.error.XauthError: ~/.Xauthority: [Errno 21] Is a directory: '/home/seluser/.Xauthority'

Same error

Same error also for me.
When I run docker-compose up -d everything is fine.
My host operating system is Windows 10

Docker and Docker Compose will work on Windows, but how they work is fundamentally different than how they do natively (on Linux). For example, there's no native X windowing system on Windows, and because I rely on that for the dockerized tests in this repository, it's natural that Windows users will see these errors. That being said, you can still use this repository, but without Docker.
In short: Windows users should stick with plain Python.


Remove env PYTHONOPTIMIZE in docker image

Description
Remove env PYTHONOPTIMIZE=1 in docker image since it will skip assert 0 in python.
When env PYTHONOPTIMIZE=1,
Python 3.8.10 (default, Nov 14 2022, 12:59:47)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> assert 0

No exception raises.

I got this error when training gpt3 using Megatron-LM. After export PYTHONOPTIMIZE=0, this error disappeared.

actually the goal of this env was to skip all assert statements in real runs..

Users may not know assert statements are skipped, and some codes depend on assert.
For example,
class Dataset:
    ...
    def __getitem__(self, idx):
        try:
            data = self.get_data()
            assert data is not None
        except:
            return self.__getitem__(idx - 1)
        return data


Create RepositoryExtension interface

Description
Describe what this change achieves.
Issues Resolved
Fixes #329
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #581 (892afdb) into main (4dc426a) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main     #581      +/-   ##
============================================
- Coverage     69.85%   69.80%   -0.05%
- Complexity      216      217       +1
============================================
  Files            40       41       +1
  Lines           889      891       +2
  Branches         26       26
============================================
+ Hits            621      622       +1
- Misses          257      258       +1
  Partials         11       11

Impacted Files
Coverage Δ

...n/java/org/opensearch/sdk/RepositoryExtension.java
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


CondVar with RwLock

Hi!
I'd like to have multiple readers wait until the right value is written.
One solution would be to have a CondVar based on a RwLock rather than a Mutex.
This seems to be what another crate is doing: https://docs.rs/shared-mutex/0.3.1/shared_mutex/struct.SharedMutex.html
Could something similar be added to parking_lot?
Thanks!

You can easily implement a Condvar that accepts any type of guard like this:
struct CondvarAny {
    c: Condvar,
    m: Mutex<()>,
}
impl CondvarAny {
    fn wait<T>(&self, g: &mut RwLockReadGuard<'_, T>) {
        let guard = self.m.lock();
        RwLockReadGuard::unlocked(g, || {
            // Move the guard in so it gets unlocked before we re-lock g
            let mut guard = guard;
            self.c.wait(&mut guard);
        });
    }
}

The current Condvar implementation in parking_lot is deeply tied to the internals of Mutex, so a completely new Condvar implementation would be required to support RwLock.

Oh sweet, thanks! Hadn't used RwLockReadGuard::unlocked yet, this looks perfect.
I guess the main difference with a new CondVar designed specifically for RwLock would be slightly higher performance, but I'll run some benchmarks - this CondVarAny is probably fine as-is.
Thanks again!


Redundant whitespaces created by autocompletion

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: Debian Trixie
- Continue: v0.9.155
- IDE: VSCode

Description
I configured autocompletions for my continue addon, backend is ollama with codeqwen (tested multiple).
It seems to create redundant whitespaces consistently on code completion which have to be deleted manually.
To reproduce

Code
Preview autocompletion shows a reduntant whitespace at the curser position

Log output
no errors here

@overcuriousity Is this happening only with CodeQwen? Different models tend to have different quirks, and it would be useful to know either that CodeQwen is the best model of its size or that this is also happening with other models, before I start looking into making a bunch of model-specific filters

No, also happened last Werk with codellama.
Didn't test properly with starcoder:3b.


fix fix some load stream stub logic cannot be reached

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


noticeOnStatusBar doesn't work for iphone X

noticeOnStatusBar doesn't work for iphone X

Done! https://github.com/johnlui/SwiftNotice/releases/tag/v5.1


Queries cannot run in parallel?

I extracted code from PostGraphQL and create express middleware.
I observed that when two queries are run in parallel, postgraphql freezes.
When I run postgraphql from commandline, it looks like execution of second query is blocked until first finishes. What is wrong?
My middleware code:
import Promise from 'bluebird';
import pg, { Client } from 'pg';
import onFinished from 'on-finished';
import expressGraphql from 'express-graphql';
import { createGraphqlSchema } from 'postgraphql';
import { pgConnectionString } from '../config.js';

Promise.promisifyAll(pg);
Promise.promisifyAll(Client);

let graphqlSchema = null;
const createSchemaPromise = async () => {
  graphqlSchema = await createGraphqlSchema(pgConnectionString, 'public');
  return graphqlSchema;
};

export default function register(app) {
  app.all('/admin/graphql', expressGraphql(async req => {
    // TODO: SECURITY - Protect this route

    // Acquire a new client for every request.
    const client = await pg.connectAsync(pgConnectionString);

    // Start a transaction for our client and set it up.
    await client.queryAsync('begin');

    // Make sure we release our client back to the pool once the response has
    // finished.
    onFinished(req.res, async () => {
      // Try to end our session with a commit. If it succeeds, release the
      // client back into the pool. If it fails, release the client back into
      // the pool, but also report that it failed. We cannot report an error in
      // the request at this point because it has finished.
      try {
        await client.queryAsync('commit');
        client.end();
      } catch (err) {
        console.error(err.message); // eslint-disable-line no-console
        client.end(err);
      }
    });

    return {
      // Await the `graphqlSchema` because it may be a promise.
      schema: graphqlSchema || await createSchemaPromise(),
      context: { client },
      pretty: true,
      graphiql: true,
    };
  }));
}

Hi @langpavel, have you read Using PostGraphQL as a Library? Currently you are able to configure and use PostGraphQL as Express or Connect middleware. If there are features you’d like to remove (as I see you’ve removed authentication) let me know and we’ll see if we can incorporate it up stream.
I’m not sure why exactly you’re getting blocked, but I do see something that looks wrong.
Here:
return {
  // Await the `graphqlSchema` because it may be a promise.
  schema: graphqlSchema || await createSchemaPromise(),
  context: { client },
  pretty: true,
  graphiql: true,
};

You’re calling a function that you define above, here:
let graphqlSchema = null;
const createSchemaPromise = async () => {
  graphqlSchema = await createGraphqlSchema(pgConnectionString, 'public');
  return graphqlSchema;
};

If you call PostGraphQL twice in quick succession, you may call createSchemaPromise twice creating a race condition and likely the odd behavior you’re experiencing.
I’d recommend using the postgraphql middleware. If it’s missing some things, let’s talk about them and add those features in.

Hi, thanks for response!

Have you read Using PostGraphQL as a Library?

No, can you please add a link to README.md? :-) I totally overlooked this...

If you call PostGraphQL twice in quick succession, you may call createSchemaPromise twice creating a race condition and likely the odd behavior you’re experiencing.

Ahh you are right! But this race condition can occur only after very first runs and I'm getting blocked after some time after that...

Hi @calebmer
I followed Using PostGraphQL as a Library and succesfully setup it as express middleware, but freezing still occurs when I run single query more times with little delay (hitting Ctrl+Enter multiple times)
After multiple requests sent, middleware stuck and even GraphiQL does not loads. all subsequent queries reaching PostGraphQL endpoint ends with timeout (even GET for GraphiQL)

Hi @langpavel, did you end up solving the issue? And out of curiosity how? 😊

@calebmer Just as you say :-)
import postgraphql from 'postgraphql';
import { pgConnectionString } from '../config.js';

export default function register(app) {
  // TODO: SECURE
  app.use('/admin/graphql', postgraphql(pgConnectionString, 'public', {
    development: true,
    log: true,
  }));
}


Authentication failure! invalid_credentials: OAuth2::Error, : {"error":{"message":"Can't load URL: The domain of this URL isn't included in the app's domains. To be able to load this URL, add all domains and sub-domains of your app to the App Domains field in your app settings."

Provider Gem: omniauth-1.6.1
Ruby Version: 3.1.0 with Rails: <IP_ADDRESS>
Platform: Docker linux

Hello, I have been trying to integrate social login to my app, But stucked in nowhere....
my gem file:
gem 'omniauth-facebook', '4.0.0'
gem "omniauth", "1.6.1"

devise.rb
config.omniauth :facebook, "APP_ID", "APP_SECRET", token_params: { parse: :json }
user model:
devise :omniauthable, omniauth_providers: %i[facebook]
and then adding link to view
link_to "Register with Facebook", user_facebook_omniauth_authorize_path, method: :post
but whenever clicking on the link, taking me to facebook, asking to login via FB, and when fb user login is done, it takes back me to  failure callback stating below msgs in the log..
| I, [2022-01-24 07:25:18 #1]  INFO -- : Started GET "/api/v1/users/auth/facebook" for <IP_ADDRESS> at 2022-01-24 07:25:18 +0000
| I, [2022-01-24T07:25:18.819844 #1]  INFO -- omniauth: (facebook) Request phase initiated.
| I, [2022-01-24 07:25:19 #1]  INFO -- : Started GET "/api/v1/users/auth/facebook/callback?code=AQAdlPKadQWhYftuherICQIXGHuIhLVzPdJbkWpkbIZZg8RiE3rBY_D-fj6kYApPP35HzfGrnQJRWTEs3i_ahz2ko9MhwqkM1QfMF6IeWCmqTJEQWwAekzAuOsJf6dpu11MUrC3gIgQ9AL6qEHIY5Vvkrh1B2QzoXMeaKw9LuSsRzrJQAxbQosh3rcBVQ1NEp2gRk623GRGQKsMe0w7_8jsskdfsdfsfsfdRC4BzcsP1eGOzbjy8AA1j7wcOuTph78u220fxqnTkRiINGGQxHsjpgzOoe398I8UTiTS8U1pr1HO_5F44kaURwShZXnks6ZCUU8jIaIlfLh46mBIw_QR89XO2U16mIpGNoeZef1D_0Q-Ye3sI-wodQCMHH3kBVKspgG2K0oISniOQ&state=9812578bbd720814fd856fd874f3fd23383a284ea1d7b1ba" for <IP_ADDRESS> at 2022-01-24 07:25:19 +0000
| I, [2022-01-24T07:25:19.817653 #1]  INFO -- omniauth: (facebook) Callback phase initiated.
| E, [2022-01-24T07:25:20.207281 #1] ERROR -- omniauth: (facebook) Authentication failure! invalid_credentials: OAuth2::Error, {"message"=>"URL لوڈ نہیں کیا جا سکتا: اس URL کی ڈومین ایپ کی ڈومینز میں شامل نہیں ہے۔ یہ URL لوڈ کرنے کا اہل ہونے کیلئے، اپنی ایپ کی تمام ڈومینز اور ذیلی ڈومینز کو اپنی ایپ کی سیٹنگز کی ایپ ڈومینز فیلڈ میں شامل کریں۔", "type"=>"OAuthException", "code"=>191, "fbtrace_id"=>"AAGSW2l-gRCDYQE6p0qS6fI"}:
| {"error":{"message":"URL \u0644\u0648\u0688 \u0646\u06c1\u06cc\u06ba \u06a9\u06cc\u0627 \u062c\u0627 \u0633\u06a9\u062a\u0627: \u0627\u0633 URL \u06a9\u06cc \u0688\u0648\u0645\u06cc\u0646 \u0627\u06cc\u067e \u06a9\u06cc \u0688\u0648\u0645\u06cc\u0646\u0632 \u0645\u06cc\u06ba \u0634\u0627\u0645\u0644 \u0646\u06c1\u06cc\u06ba \u06c1\u06d2\u06d4 \u06cc\u06c1 URL \u0644\u0648\u0688 \u06a9\u0631\u0646\u06d2 \u06a9\u0627 \u0627\u06c1\u0644 \u06c1\u0648\u0646\u06d2 \u06a9\u06cc\u0644\u0626\u06d2\u060c \u0627\u067e\u0646\u06cc \u0627\u06cc\u067e \u06a9\u06cc \u062a\u0645\u0627\u0645 \u0688\u0648\u0645\u06cc\u0646\u0632 \u0627\u0648\u0631 \u0630\u06cc\u0644\u06cc \u0688\u0648\u0645\u06cc\u0646\u0632 \u06a9\u0648 \u0627\u067e\u0646\u06cc \u0627\u06cc\u067e \u06a9\u06cc \u0633\u06cc\u0679\u0646\u06af\u0632 \u06a9\u06cc \u0627\u06cc\u067e \u0688\u0648\u0645\u06cc\u0646\u0632 \u0641\u06cc\u0644\u0688 \u0645\u06cc\u06ba \u0634\u0627\u0645\u0644 \u06a9\u0631\u06cc\u06ba\u06d4","type":"OAuthException","code":191,"fbtrace_id":"AAGSW2l-gRCDYQE6p0qS6fI"}}
| I, [2022-01-24 07:25:20 #1]  INFO -- : FAILURE CALLBACK
| I, [2022-01-24 07:25:20 #1]  INFO -- : Redirecting to /

Though I have verified my APPID n SECRET are fine, and correct... still giving me invalid credentials error...
My FB APP is in development mode, so it's saying the localhost will automatically be redirected, so it's not necessary to add the localhost urls in the whitelist url callbacks ... and app domain is set to localhost too. Still I don't understand what's wrong and where I have done wrong...
Please do suggest what should be done to get a proper resolution for this... I have been looking for this for a week, have tried many solutions posted in github issues or stackoverflow, have downgraded/upgraded gems for omniauth n fb... but still got no luck..

I now updated the omniauth gems to their latest versions... now the current versions are:
  * oauth2 (1.4.7)
  * omniauth (2.0.4)
  * omniauth-facebook (9.0.0)
  * omniauth-oauth2 (1.7.2)

and now it's not showing in errors in the console log, but on the web page, saying Not found. Authentication passthru.
and check in the code it's entering in this block
def passthru
    Rails.logger.info "PASSTHRO METHOD"
    super
  end

I don't know what's happening here... what it does mean!

I can't provide 1:1 implementation guidance, I do believe this is an implementation error and not an underlying issue with Omniauth.
Please read through these and see if they are any help:
https://developers.facebook.com/community/threads/2324374700917110/
https://github.com/simi/omniauth-facebook/issues/317

I have tried googling first, and found many solutions regarding this, but none worked for me..
and also update the gems to their latest versions just to make sure that every gem will be on stable version and working fine.. but still no luck...
but the error msg is changed after updating gems.. all the code is same except the gems version... why is this so?

When gem versions change, the code in the gems change. OmniAuth 2 introduced some different error handling.


[Bug]: ruff failing on Mac x86

What happened?
try to load ruff binary, it failed with the following error
% bazel run //:ruff
bazel::login succeed
Starting local Bazel server and connecting to it...
INFO: Invocation ID: a203b7e2-c67c-459c-a6f0-a6ea586fcba8
INFO: Analyzed target //:ruff (6 packages loaded, 15 targets configured).
INFO: Found 1 target...
Target @ruff_x86_64-apple-darwin//:ruff up-to-date (nothing to build)
INFO: Elapsed time: 11.382s, Critical Path: 0.05s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Running command line: /private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff
/private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff: line 1: 3: command not found
/private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff: line 2: 0: command not found
/private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff: line 3: 4096: command not found
/private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff: line 4: 16384: command not found
/private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff: line 5: 14503936: command not found
/private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff: line 6: 14532608: command not found
/private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff: line 7: 83144: command not found
/private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff: line 8: ????X: command not found
/private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff: line 9: syntax error near unexpected token `)'
/private/var/tmp/_bazel_nlou/b43af9baf9d056244183c6c3d6dd8487/external/ruff_x86_64-apple-darwin/ruff: line 9: `???H__PAGEZERO?__TEXT???__text__TEXT?F?*??F?__stubs__TEXT?q?q?__stub_helper__TEXT?u???u??__const__TEXT?|??%?|?__gcc_except_tab__TEXTX??}X??__cstring__TEXTp??)(p??__unwind_info__TEXT?%?\??%?__eh_frame__TEXT??????__DATA???(??
                                                                                __program_vars__DATA??(??__nl_symbol_ptr__DATA(?(???__got__DATA0??`0???__la_symbol_ptr__DATA???`????__mod_init_func__DATA?????	__const__DATA??????__thread_vars__DATA?w???w?__data__DATA {? {?__thread_data__DATA ??@ ??__thread_bss__DATA`??h__common__DATA??(? __bss__DATA0.??H__LINKEDIT@?????D"?0??x(x???@H???8???'0????>
                                                                                P???p??e
                                                                                /usr/lib/dyld??k&?<?̓"WD1g$'
Error: bazel exited with exit code: 2

Version
Development (host) and target OS/architectures: macOS x86
Output of bazel --version: Build label: 6.4.0
Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:
http_archive(
    name = "aspect_rules_lint",
    sha256 = "ddc21b1399c03708f82e5a46d6c747bf23d55484bad1efdaa92a22d5fee20ea1",
    strip_prefix = "rules_lint-0.5.0",
    url = "https://github.com/aspect-build/rules_lint/releases/download/v0.5.0/rules_lint-v0.5.0.tar.gz",
)
load("@aspect_rules_lint//lint:ruff.bzl", "fetch_ruff")
fetch_ruff()

Language(s) and/or frameworks involved:
python
How to reproduce
Configure the WORKSPACE file as above.

In BUILD.bazel:
alias(
    name = "ruff",
    actual = select({
        "@bazel_tools//src/conditions:linux_x86_64": "@ruff_x86_64-unknown-linux-gnu//:ruff",
        "@bazel_tools//src/conditions:linux_aarch64": "@ruff_aarch64-unknown-linux-gnu//:ruff",
        "@bazel_tools//src/conditions:darwin_arm64": "@ruff_aarch64-apple-darwin//:ruff",
        "@bazel_tools//src/conditions:darwin_x86_64": "@ruff_x86_64-apple-darwin//:ruff",
    }),
)

bazel run //:ruff

Any other information?
No response

Dupe of #42


Please add "Important" or "Note" Tag to paragraph regarding multiple policies assigned to a user

Could you please add the blue "Important" or purple "Note" tag to the following paragraph on this page:
"If a user is defined in multiple policies of the same type, only the policy with the highest priority is applied to them. Any remaining policies of that type are not evaluated for the user (including the default policy)."
There are SEVERAL blogs out in the world with the wrong information on this. Specifically, folks are saying to use multiple polcies to get around the 60 (now 350) limit for Impersonated User Protection.
As written, this paragraph is perfect, but easy to miss. Please consider calling it out as a note (like the blue one at the top of the page) or important tag (purple).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ac02c636-ad3c-0689-22c9-dddf8dac98c6
Version Independent ID: 5ea6404c-998e-4002-25f5-46701a2d819f
Content: Start a flow in a canvas app - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/using-logic-flows.md
Service: powerapps
GitHub Login: @stepsic-microsoft-com
Microsoft Alias: stepsic

Thank you for reaching out. Looks like this is for a different topic. Please submit the feedback on the topic that the feedback is for. For now, I've submitted this update to the said topic.


add shewit communication-plan

/planning/communication-plan.md

[ ] Add availability.
[ ] Add how many hours has per day.

Well done @alihaidermalik20
Please add it to To do column.


Upgrade jboss-classfilewriter to 1.1.2.Final

Linux Build 1965 is now running using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d

Core - Full Integration Build 1105 is now running using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d

Windows Build 1515 is now running using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d

Windows Build 1515 outcome was SUCCESS using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d
Summary: Tests passed: 3207, ignored: 71 Build time: 0:22:21

Linux Build 1965 outcome was SUCCESS using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d
Summary: Tests passed: 3207, ignored: 71 Build time: 0:25:16

Core - Full Integration Build 1105 outcome was FAILURE using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d
Summary: Tests failed: 2 (2 new), passed: 2876, ignored: 377 Build time: 0:48:24
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.clustering.cluster.ejb.xpc.StatefulWithXPCFailoverTestCase(SYNC-tcp).testBasicXPC: <no details avaliable>

org.jboss.as.test.clustering.cluster.ejb.xpc.StatefulWithXPCFailoverTestCase(SYNC-tcp).testSecondLevelCache: <no details avaliable>

retest this please

Core - Full Integration Build 1117 is now running using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d

Windows Build 1527 is now running using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d

Linux Build 1977 is now running using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d

Windows Build 1527 outcome was SUCCESS using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d
Summary: Tests passed: 3207, ignored: 71 Build time: 0:22:41

Linux Build 1977 outcome was SUCCESS using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d
Summary: Tests passed: 3207, ignored: 71 Build time: 0:25:41

Core - Full Integration Build 1117 outcome was SUCCESS using a merge of 386bc6a53f6623c19b812da9e2768451f95b463d
Summary: Tests passed: 2877, ignored: 377, muted: 1 Build time: 0:47:23


Unset Python Endpoint close callback upon destruction

In some cases, particularly with distributed-ucxx, the C++ Endpoint outlives the Python object that owns a close callback registered with set_close_callback(), making it an invalid reference and causing segfaults. To prevent that it is necessary to remove the close callback, preventing it from being called after it's not valid anymore.

I just reverted the commit increasing timeout for test_transpose as that doesn't have any effect. If there are no objections I'll merge it shortly after CI passes.

Thanks for taking the time for reviewing @wence- !


Console on CDC USB  crashes when CONFIG_USB_COMPOSITE_DEVICE=y

Describe the bug
target: nrf52840
Our application uses a USB CDC serial port for proprietary communications and
we also need our console port to appear on the same physical port.
When  CONFIG_USB_COMPOSITE_DEVICE=y and CONFIG_USB_UART_CONSOLE=y
and CONFIG_UART_CONSOLE_ON_DEV_NAME="CDC_ACM_2" or "CDC_ACM_1", the project builds but execution crashes before reaching main.
To Reproduce
Steps to reproduce the behavior:
CMake with:
CONFIG_USB_CDC_ACM=y
##Multiple USB CDC devices
CONFIG_USB_COMPOSITE_DEVICE=y
CONFIG_USB_CDC_ACM_DEVICE_COUNT=2
CONFIG_USB_CDC_ACM_RINGBUF_SIZE=512
CONFIG_USB_UART_CONSOLE=y
CONFIG_UART_CONSOLE_ON_DEV_NAME="CDC_ACM_2"
CONFIG_UART_CONSOLE=y
make and run.
Expected behavior
I would expect that LOG messages appear appear on virtual com port (usb cdc port 2)
Impact
Our HW has only 1 USB port externally.  We will not be able to view console output.
Screenshots or console output
No console output :(
Environment (please complete the following information):

Linux
Zephyr SDC
1.14.99

okay, I do not know what 1.14.99 is referring to, but it works with the current master and the patch for configuration overlay below.
diff --git a/samples/subsys/usb/cdc_acm/overlay-composite-cdc-console.conf b/samples/subsys/usb/cdc_acm/overlay-composite-cdc-console.conf
new file mode 100644
index<PHONE_NUMBER>..3d6cea51b9
--- /dev/null
+++ b/samples/subsys/usb/cdc_acm/overlay-composite-cdc-console.conf
@@ -0,0 +1,12 @@
+CONFIG_SERIAL=y
+
+CONFIG_USB_COMPOSITE_DEVICE=y
+CONFIG_USB_CDC_ACM_DEVICE_COUNT=2
+CONFIG_USB_CDC_ACM_RINGBUF_SIZE=512
+
+CONFIG_UART_INTERRUPT_DRIVEN=y
+CONFIG_UART_LINE_CTRL=y
+CONFIG_UART_CONSOLE_ON_DEV_NAME="CDC_ACM_1"
+
+CONFIG_USB_UART_CONSOLE=y
+CONFIG_USB_UART_DTR_WAIT=y

I did not see an overlay file for console in the master (samples/subsys/usb/cdc_acm) head or the 2.0.0 tag so I tried both using your overlay (provided above).  The sample/subsys/usb/2.0.0/cdc_acm does not build and fails to find nrfx.h.
This is with -DBOARD=nrf52840_pca10056
/home/lanvis/zeph20/zephyr-zephyr-v2.0.0/soc/arm/nordic_nrf/nrf52/soc.h:17:10: fatal error: nrf.h: No such file or directory
#include <nrf.h>
^~~~~~~
compilation terminated.
So not sure what you used but please tell.

@lanvis Please try west update

CONFIG_UART_CONSOLE_ON_DEV_NAME

For this config option uart device should be selected. Please refer to ./drivers/console/Kconfig l:15

@lanvis is it working now?

@lanvis could you close the issue if this is now resolved?

Did not have a chance to try yet ... but will soon.

I pulled the master but the overlay-composite-cdc-console.conf is not in the samples/subsys/usb/cdc_acm directory so I made it from the contents you show above.  I changed no source so the example only opens the first port.  I would expect the console to open the 2nd port but I see no 2nd port being opened.
prj.conf
CONFIG_STDOUT_CONSOLE=y
CONFIG_GPIO=y
CONFIG_USB=y
CONFIG_USB_DEVICE_STACK=y
CONFIG_USB_DEVICE_PRODUCT="Zephyr CDC ACM sample"
CONFIG_LOG=y
CONFIG_USB_DRIVER_LOG_LEVEL_ERR=y
CONFIG_USB_CDC_ACM=y
CONFIG_USB_DEVICE_LOG_LEVEL_ERR=y
CONFIG_SERIAL=y
CONFIG_UART_INTERRUPT_DRIVEN=y
CONFIG_UART_LINE_CTRL=y
CONFIG_SERIAL=y
CONFIG_USB_COMPOSITE_DEVICE=y
CONFIG_USB_CDC_ACM_DEVICE_COUNT=2
CONFIG_USB_CDC_ACM_RINGBUF_SIZE=512
CONFIG_UART_INTERRUPT_DRIVEN=y
CONFIG_UART_LINE_CTRL=y
CONFIG_UART_CONSOLE_ON_DEV_NAME="CDC_ACM_1"
CONFIG_USB_UART_CONSOLE=y
#CONFIG_USB_UART_DTR_WAIT=y

OK .. found that it waits for DTR so need to comment out  the DTR_WAIT config and all is good.
If you don't do this, you need to have the serial port connection (e.g. term emulator) on the assigned port before execution continues.  All is good.
Thanks ... am closing.


Issue where carbon-list comes back empty

Hi,
I have added the conf file as suggested with a user that has keys to the servers on the cluster, however when running the commands (IE carbon-list) it just comes back blank.
Any ideas why this might be. The only command I can see to run is if I run it on the local graphite server and tell it to look at the directory specifically.
Any ideas why when trying to run it again the cluster it just seems to bring back nothing not even an error.

@wingZero21 - I hope you got things working! I'm going to close this issue, but feel free to make a comment to the contrary and I'll reopen it.


result name clash

result is also a function

I'm not sure why travis fails maybe because gcc 4.6 is to old

the error "redisparser.cpp:364:47: error: ‘ParseParse’ was not declared in this scope" is strange.
The work ParseParse does not appear once in the source file
p.s. the test pass with current gcc and current clang

-std::pair<size_t, ParseResult> result
+std::pair<size_t, ParseParse> resultParse

ParseResult vs ParseParse.
Please rename "resultParse" to "parseResult"

fixed

thank you

thank you


fix issue with timeouts in mesos

Fix https://github.com/docker/swarm/issues/1183
This PR fixes a race, unfortunately I cannot reproduce it with our current CI (docker in docker means it's localhost, so super fast)
But I was able to confirm this fixes some issues, I believe it's going to fix https://github.com/docker/swarm/issues/1183

ping @ahmetalpbalkan @jimenez @tnachen

LGTM for now, we should merge this to have a quick fix but start thinking on a more maintainable refactor


ThreadLocalActiveSpan.deactivate()

ThreadLocalActiveSpan.deactivate() does not deactivate/finish span when it is not currently active span:
https://github.com/opentracing/opentracing-java/blob/master/opentracing-util/src/main/java/io/opentracing/util/ThreadLocalActiveSpan.java#L50
Problems:

response interceptors sometimes run in a different thread, therefore it makes it impossible to deactivate the span
if a user accidentally does not deactivate local span, span created by instrumentation is not finished

I would like to see what others think and what issues they faced.

Hello,
I am currently facing this issue.
I have an Observer with 3 methods which are called asynchronously in different threads:
Observer observer = new IObserver<T>() {

            @Override
            public void onNext(T result) {
                currentSpan.log("onNext");
                //...some work
            }

            @Override
            public void onComplete() {
                //... some work
                currentSpan.deactivate();
            }

            @Override
            public void onError(Throwable t) {
                //... some work
               currentSpan.deactivate();
            }
};

Problem is: it actually does not deactivate/finish span when it is not currently active span.
The process is given to a new thread, storage is obviously empty and therefor, the span not considered as the active one.
Workaround
I have looked for a workaround to this issue and, as the wrapped span is not reachable from the ActiveSpan instance, the only solution I came though was to call it as follow:
    Span childSpan = performanceTracer.buildSpan(flowInstanceName).startManual();

    ActiveSpan activeSpan = performanceTracer.makeActive(new Span() {
        @Override
        public void finish() {
            //do nothing
        }

        @Override
        public void finish(long l) {
            //do nothing
        }

        @Override
        public SpanContext context() {
            return childSpan.context();
        }

       ...
    });

    performInvocation(..., childSpan);
    activeSpan.deactivate();

Instead of using startActive(), I explicitly call startManual() and then makeActive(). The trick here is I don't want the childSpan to be finished when calling activeSpan.deactivate() (since the span is still used asynchronously) but I do want the span parent to be made active again (I don't have any ref on the parent since it comes from the instrumentation of servlets) to be able to finish the one coming from the instrumentation.
And the observer called asynchronously in different threads:
new IObserver<T>() {

            @Override
            public void onNext(T result) {
                currentSpan.log("onNext");
                //... some work
            }

            @Override
            public void onComplete() {
                //... some work
                disableSpan(currentSpan);
            }

            @Override
            public void onError(Throwable t) {
                //... some work
                disableSpan(currentSpan);
            }

            private void disableSpan(Span currentSpan) {
                ActiveSpan activeSpan = performanceTracer.makeActive(currentSpan);
                activeSpan.deactivate();
            }
};

Continuation mechanism
The 'capture()' mechanism was useless in my case since it is potentially called in the asynchronous thread after the activeSpan.deactivate(); is called (and therefor, the wrapped span will already be finished).
current thread a
-> async thread b: new Observer
-> async thread c: methods of the Observer are called
(We work with Ignite on a distributed compute grid, so that's why some time is needed between the Observer instantiation and the first call of any of its methods)
Summary
To summarize, my workaround is pretty ugly: create an "on-the-fly" Span implementation without the finish part.
Maybe there is a cleaner way to deal with this issue that I have missed ?
I am thinking about 2 solutions here:
In Opentracing-util implementation for example, a not-null condition in the deactivate() method would be enough to solve this:
ThreadLocalActiveSpan currentSpan = source.tlsSnapshot.get();
if (currentSpan != null && currentSpan != this) {
        // This shouldn't happen if users call methods in the expected order. Bail out.
        return;
}

A better solution would be to offer SPIs (and a way to register the new implementations) to bring our own customized implementation of some components.

Any reason you don't want to activate the span on the new thread and then close it?

Hi @tylerbenson
Unfortunately, as I precised in the Continuation mechanism section above, 3 threads are implied in this process and I don't handle their lifecycle (akka is used in the lower layer of the application).
current thread a
-> async thread b: new Observer
-> async thread c: methods of the Observer are called

And I can not put the span activation in the Observer methods since the calls to these methods (work in the thread c) can be performed after the span of the thread a has been closed.

@hloos I think the right solution here will indeed involve a change to the default TLS span source impl... Did you try patching in the null check you suggested? If so, were there any ill (side) effects?
@pavolloffay sorry I missed this the first time around :-/

@bhs I am just confuse about the role of the code I am mentionning. Why does a span can not be deactivated if it is not the active one ?
@Override
public void deactivate() {
    if (source.tlsSnapshot.get() != this) {
        // This shouldn't happen if users call methods in the expected order. Bail out.
        return;
    }
    source.tlsSnapshot.set(toRestore);

    if (0 == refCount.decrementAndGet()) {
        wrapped.finish();
    }
}

I came here tracking a span leak in test code - using MockTracer w/ThreadLocalActiveSpanSource - even without threads the current code has some fragility.
What I have going on is clearly a misuse of the API - and I'm going to be tracking that down now - but the silent leak was much less helpful than we could be.
I'd like to see an exception raised, or a diagnostic stacktrace logged or some such thing: leaking is pretty much the most difficult thing to deal with: its silent, it will cause traces to have bad parents and possibly even join distinct traces together.

Even though Continuation is not part of the main API, this check still exists for 0.31 using Scope: https://github.com/opentracing/opentracing-java/blob/master/opentracing-util/src/main/java/io/opentracing/util/ThreadLocalScope.java#L42
Wondering if this is still a problem with the way activation works now @pavolloffay @rbtcollins

Trying to prevent this Issue to become stale, a pair of things:

Once we implement some kind of Observer API, this kind of things could at least be reported to the user.
With the old 0.30 API it seemed to be much more of a problem - as we haven't been getting reports about this behavior with the new 0.31 one.

Unless somebody thinks this is still an issue, I will close it by the end of the next week. Let us know ;)
@pavolloffay @rbtcollins


libsecret: add vala dependency

Motivation for this change
https://github.com/NixOS/nixpkgs/pull/17844#issuecomment-241198806
I tested compilation against vala 32 and vala 28. The /share/vala bindings are produced correctly.
Note the current vala package is 0.28 which isn't current or stable so there will be some run time hiccups until the default is updated to 32. But it's separate from this PR (https://github.com/NixOS/nixpkgs/issues/17869).
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

curl: (56) Recv failure: Connection reset by peer
error: cannot download eclipse-SDK-4.2.1-linux-gtk-x86_64.tar.gz from any mirror

Travis failed over unrelated issue.

Staged, as webkits take time to rebuild and Hydra is overloaded ATM.

Thanks :)

I pushed a specific vala version to follow up on https://github.com/NixOS/nixpkgs/issues/17869 .

Merged to staging, again.

Thanks :) Again :D

Thanks!


Android: ensure that onError and onCompletion can't both be invoked

See #106

@benvium I think your way is probably a lot better, although you should remove both handlers in both callbacks. Although.. I'm not sure if there's still a potential race condition in here. I think that this would solve the problem, and should replace the boolean variable I added.

This is covered by #168, so closing


go get install fails

$ go get -u github.com/golang/lint/golint
package github.com/golang/lint/golint
	imports github.com/golang/lint
	imports golang.org/x/tools/go/exact: golang.org/x/tools is a custom import path for https://go.googlesource.com/tools, but /Users/bk/Development/go/src/golang.org/x/tools is checked out from https://code.google.com/p/go.tools
package github.com/golang/lint/golint
	imports github.com/golang/lint
	imports golang.org/x/tools/go/gcimporter: golang.org/x/tools is a custom import path for https://go.googlesource.com/tools, but /Users/bk/Development/go/src/golang.org/x/tools is checked out from https://code.google.com/p/go.tools
package github.com/golang/lint/golint
	imports github.com/golang/lint
	imports golang.org/x/tools/go/types: golang.org/x/tools is a custom import path for https://go.googlesource.com/tools, but /Users/bk/Development/go/src/golang.org/x/tools is checked out from https://code.google.com/p/go.tools

or:
 go get -u -f github.com/golang/lint/golint
# github.com/golang/lint
../../../github.com/golang/lint/lint.go:1432: assignment count mismatch: 2 = 3

This is with go 1.4.2 installed via Homebrew on OS X 10.10.
Any ideas?

Could you remove "/Users/bk/Development/go/src/golang.org/x/tools" and then try go get -u github.com/golang/lint/golint again?

Yes, you have golang.org/x/tools from its old path. You need to delete your copy of it, and re-fetch it.


10.15.1 Beta (19B68f)

The touch keyboard is not working. 10.15.1 Beta (19B68f)

Have you tried this?

Duplicate of 61


[Feature] Script to add SSL policy to all or multiple S3 buckets

Prerequisites

[X] I have checked to make sure that this issue has not already been filed

Is your feature request related to a problem? Please describe the problem
No response
Describe the solution you'd like
A script that will read existing policy of S3 bucket and if SSL policy does not exist then append it to the existing policy to attach one to the bucket
Describe any alternatives you've considered
No response
Additional context
No response

script added: https://raw.githubusercontent.com/skildops/aws-utilities/main/s3_ssl_bucket_policy.py


When dragging Email into Web Upload form the Email is moved intro trash

Hello!
I tried to use the plugin with some sample Code from codepen to see if it works. (https://codepen.io/Ushinro/pen/NPQzOx) Whenever i drag an email to the script the email is moved into trash in outlook. Can you reproduce the error?
best regards, alexander

Yes, I was able to reproduce this issue.  However, I do not see this issue happen on other sites such as OneDrive.
This issue appears to happen because no dropEffect value is set, so Outlook thought you were trying to move files instead of copy them.  Adding this line to your fileDragHover event in JavaScript fixed the issue for me.
e.dataTransfer.dropEffect = 'copy';
Please try adding this line and see if this works for you.
This page has more information about the dropEffect property: https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/dropEffect

Hello!
Thanks for the fast answer. So it was only a bad script i was trying it with. I will keep that in mind when i start implementing it in my script. Thank you!
best regards, alexander


Create Google Login

Try to use https://www.npmjs.com/package/react-google-login to speed the process

Issues with enviromental variables + secretes in Google Cloud CD/CI -


CHEBI:65107 synonym

Dear ChEBI Curators,
Can you please check the LipidMaps synonym in CHEBI:65107 is correct? Should it be changed to ...4R-hydroxysphinganine maybe?
Tia for your help.

Thanks for spotting this and letting us know! - Now sorted.
Best regards,
Gareth


Replication Change Listeners callback for errors 401 is called only for push replication

Hi all,
I use couchbase-lite-android 1.1.0 via gradle and Sync Gateway/1.1.0(28;86f028c). Solution flom #540 works only for push replucation.
For example, I create user "foo" with password "bar" and login with this in ToDoLite sample app. I create new task in list. After sync I change user password via REST API and change task in Sync Gateway /_admin. I see many ChangeTracker: com.couchbase.lite.replicator.ChangeTracker@42b1659: Change tracker got error 401 in logcat but unautorized callback is not called. It's called only if I make some changes in app.

related? https://github.com/couchbase/couchbase-lite-java-core/issues/723

@hideki yes

I will close this. Issue will be tracked with couchbase/couchbase-lite-java-core#723 .


Add no-op dependency for release build type

Hello,
It's a usual practice for libraries like this (that only exist for debug builds) to release a no-op version of the library that is completely empty, so that users of the library can use it in their app without worrying that the library is going to increase their release APK size, or cause any side effects in production. For an example see here: https://github.com/square/leakcanary
This can be fixed on the developers side by using an interface (for example see https://github.com/athkalia/Just-Another-Android-App/blob/8a5c677b2b0d0f2dcc123d40b770307a13786b64/app/src/main/java/com/example/tools/stetho/StethoTool.java in my project for introducing stetho only for debug builds), but it's much more convenient when fixed by the library

Hi @athkalia
Thanks again for the suggestion. I like the idea of having no-op implementation.


feat: the 'hint' tactic

example (h : 1 < 0) : False := by hint
example {P Q : Prop} (p : P) (f : P → Q) : Q := by hint
example {P Q R: Prop} (x : P ∧ Q ∧ R ∧ R) : Q ∧ P ∧ R := by hint
example {a b : ℚ} (h : a < b) : ¬ b < a := by hint
example : 37^2 - 35^2 = 72 * 2 := by hint
example : Nat.Prime 37 := by hint

Tries out any tactics registered using register_hint tac, and reports which ones succeed using the new "Try these: " multiple suggestion widgets. Tactics that close the goal are highlighted in green. Tactics that succeed but don't close the goal display the new subgoals in the widget. If tac produces a "Try this: " message, use that instead of tac.
I haven't hooked up aesop yet, because of https://github.com/leanprover-community/aesop/issues/85. Similarly for norm_num.
I would like to parallelize this, but I don't think that needs to happen right away.

How does this compare with #5363?

How does this compare with #5363?

Oh! I had completely failed to notice that. Apologies in particular to @Komyyy.
I'm impressed how parallel parts of the implementation are. :-) My version uses the new "Try these:" widget for providing multiple suggestions, and also does some additional post-processing to stop if it finds a tactic that closes the goal, and also shows the remaining subgoals for each suggestion in the widget.
@Komyyy, how should we proceed? Can we combine these into something better than either?

I will immediately steal the let tac : Syntax.Tactic := ⟨tac.raw.copyHeadTailInfoFrom .missing⟩ trick, which I presume solves the unreachable tactic warning.

I integrated my changes:

Remove some placeholders for mathport
Remove some comments for add_hint_tactic
Align import
Add an new process for register_hint to remove following comments
Register the register_hint syntax as an exception of UnreachableTactic linter

Thank you, @Komyyy, and apologies again for missing your earlier PR.

Okay, I have a modification to this that runs all the hint tactics in parallel, and it's lovely. I still need to move some lemmas around to get the imports to work out, so we should merge this in the meantime.

bors merge


read names

Hi,
thank you for this tool. It is working very nicely. One question though, what would happen if it is used on a polyploid specie where you can get more than 2 haplotypes? Is it able to estimate likelihood for more than two haplotypes? If not, would it be possible to write the names of the reads that support each SNV?
Cheers,
Juan D. Montenegro

Longshot is designed for diploid genomes, its behavior on genomes with ploidy > 2 has not been evaluated.


CFE-3611: Refactored cfengine.py to be compatible with Python3.5

Testing was done by running the example.cf provided
by the promise types using the python3.5 interpreter.
Ticket: CFE-3611

Looks good, please consider running black on the Python file to make the formatting/indenting consistent.

@KotzaBoss you should have added that in a separate commit, now it's harder to review.


Is this renaming correct?

helius\src\types\types.rs 353
#[serde(rename = "tokenSupply")]
pub token_info: Option,
"Use solana_client::rpc_client::RpcClient;" can be replaced by
"Use solana_client::nonblocking::rpc_client::RpcClient;" Use asynchronous RpcClient?

Sorry, are these two separate questions? Yes, we could use the async RpcClient instead to keep everything async. I've been meaning to look into Solana's async client more, but I've been swamped with other work. I initially used the synchronous client to get everything up and running as fast as possible, but it would make sense to switch it over

I'm going to open a PR so the embedded Solana client defaults to the async client and then introduce a new function that'll allow users to create with a synchronous Solana client if they'd like. Thanks for pointing this out!


Mobile UI

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 3

Complexity increasing per file
==============================
- src/test/java/eu/yals/test/ui/appinfo/PublicInfoTestIT.java  1
- src/main/java/eu/yals/ui/dev/AppInfoView.java  7
- src/test/java/eu/yals/test/ui/pageobjects/AppInfoPageObject.java  1
- src/test/java/eu/yals/test/ui/AppInfoPageTest.java  1

Complexity decreasing per file
==============================
+ src/main/java/eu/yals/ui/AppView.java  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/main/java/eu/yals/ui/dev/AppInfoView.java  7
- src/test/java/eu/yals/test/ui/appinfo/PublicInfoTestIT.java  1
- src/test/java/eu/yals/test/ui/pageobjects/AppInfoPageObject.java  1
- src/test/java/eu/yals/test/ui/AppInfoPageTest.java  1

Complexity decreasing per file
==============================
+ src/main/java/eu/yals/ui/AppView.java  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/test/java/eu/yals/test/ui/appinfo/PublicInfoTestIT.java  1
- src/test/java/eu/yals/test/ui/AppInfoPageTest.java  1
- src/test/java/eu/yals/test/ui/pageobjects/AppInfoPageObject.java  1
- src/main/java/eu/yals/ui/dev/AppInfoView.java  7

Complexity decreasing per file
==============================
+ src/main/java/eu/yals/ui/AppView.java  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/main/java/eu/yals/ui/dev/AppInfoView.java  7
- src/test/java/eu/yals/test/ui/pageobjects/AppInfoPageObject.java  1
- src/test/java/eu/yals/test/ui/AppInfoPageTest.java  1
- src/test/java/eu/yals/test/ui/appinfo/PublicInfoTestIT.java  1

Complexity decreasing per file
==============================
+ src/main/java/eu/yals/ui/AppView.java  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- src/test/java/eu/yals/test/ui/pageobjects/AppInfoPageObject.java  1
- src/main/java/eu/yals/ui/dev/AppInfoView.java  7
- src/test/java/eu/yals/test/ui/appinfo/PublicInfoTestIT.java  1
- src/test/java/eu/yals/test/ui/AppInfoPageTest.java  1

Complexity decreasing per file
==============================
+ src/main/java/eu/yals/ui/AppView.java  -1

See the complete overview on Codacy


Infracost GKE cost calculation discrepancy with GCP Pricing Calculator

Hi.
I am using this basic example for testing infracode out.
It creates the following infrastructure.

1 network and 1 subnetwork.

Infracost generates the following cost breakdown:
infracost breakdown --path . --show-skipped
Evaluating Terraform directory at .
  ✔ Downloading Terraform modules
  ✔ Evaluating Terraform directory
  ✔ Retrieving cloud prices to calculate costs

Project: hashicorp/learn-terraform-provision-gke-cluster

 Name                                                      Monthly Qty  Unit   Monthly Cost

 google_container_cluster.primary
 └─ Cluster management fee                                         730  hours        $73.00

 google_container_node_pool.primary_nodes
 ├─ Instance usage (Linux/UNIX, on-demand, n1-standard-1)        4,380  hours       $145.63
 └─ Standard provisioned storage (pd-standard)                     600  GB           $24.00

 OVERALL TOTAL                                                                      $242.63
──────────────────────────────────
4 cloud resources were detected:
∙ 2 were estimated, all of which include usage-based costs, see https://infracost.io/usage-file
∙ 2 were free:
  ∙ 1 x google_compute_network
  ∙ 1 x google_compute_subnetwork

GCP pricing calculator generates the following cost break-down

The management cost for a GKE cluster and the cost of the standard PDs are estimated to cost the same using google's own tool and infracost. But the cost of the actual VMs is significantly different, at 242.63USD vs 305.05USD
Am I missing some configuration?
thanks

@FelipeLujan Hello! 👋 Thank you for creating the issue!
The difference you see between Infracost output and the calculator is in the applied "Sustained Use Discount", for N1 instance types it would be 30%: if you check this checkbox the calculator will show the same number as Infracost:

Per Google this discount is automatically applied when the instance is used more than 25% of the month (more info). As Infracost CLI shows usage per full month it automatically applies such discount. This is an expected behavior.
Here's the source code that decides on the discount value for reference: https://github.com/infracost/infracost/blob/master/internal/resources/google/compute_cost_component_helpers.go#L37
Does this solve this issue for you?

Going to close this issue but feel free to re-open if you think we need to make changes.


Addd follow us on LinkedIn button

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@rajlaxmi03 This part of domain will work later !
Thank you !


Batch running failing with null DescribeJobsResponse

Expected Behavior
Task runner should be able to get DescribeJobsResponse.
Actual Behaviour
Flow fails but aws Batch Job is still running.
Steps To Reproduce
No response
Environment Information

Kestra Version: 0.17.15
Plugin version:
Operating System (OS / Docker / Kubernetes):
Java Version (If not docker):

Example flow
  - id: batchtest
    type: io.kestra.plugin.scripts.shell.Commands
    taskRunner:
      type: io.kestra.plugin.aws.runner.Batch
      accessKeyId: "xxx"
      secretKeyId: "yyy"
      region: us-west-1
      computeEnvironmentArn: "{{ vars.batch_compute_environment_arn }}"
      jobQueueArn: "{{ vars.batch_job_queue_arn }}"
      executionRoleArn: "{{ vars.ecs_task_execution_role_arn }}"
      taskRoleArn: "{{ vars.ecs_task_role_arn }}"
      bucket: "{{ vars.bucket }}"
    commands:
      - "ls"

Hi @mroverton - thanks for the issue! Just a heads up that after the v0.18.0 release, task runners are no longer Beta and this plugin is now only available on EE and Cloud. Reach out here or via Slack if you're interested in using this in production, we'll then troubleshoot this together


use project_hdf5 in pacemaker instead of job directly

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 9.825%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
465

Relevant Lines:
4733

💛  - Coveralls


Incomplete "Player is no longer stunned" message

While fighting in the "One to be Feared" HTBF with 5x trusts -> incomplete message

Caused by a typo in;
https://github.com/Spike2D/SimpleLog/blob/065e40535605629778e317e8ef263466eb4d0c26/lib/packethandlers.lua#L182
Bug fixed, Thanks Zach


Services class loader cleanup

https://hibernate.atlassian.net/browse/HSEARCH-1724

Hey, looks functionally alright, though I dislike the irregularity of this approach.
As an alternative, couldn't clients of ClassLoaderService keep an instance in a field so to avoid the repeated look-ups? That'd resemble a bit more how you'd do it with classic DI. It seemed nicer to me than the ugly special treatment of one of the service out of many.

Yes it's slightly irregular, but a step for a larger refactoring (explained on the mailing list).
Ultimately the ClassLoaderService will always be special: you can find other "special treatment code" in the StandardServiceManager around it, as the injection rules are different and because it's actually an essential component to load the other services...
It's not the "repeated lookups" which concern me solely. It's simply a core component and I don't see why we should have a more explicit helper for this; ultimately integrator.getClassLoaderService() seems more suited than having to handle the ServiceManager around to components which just need to load resources.
It's actually making things complex that we expose the ServiceManager to all these components as it is allowing circular dependencies among service(s) implementors: that's what I want to ban.

pushed an improved version on your suggestions

Minor nitpicking but maybe you should remove the useless javadoc?

Ok, then I'll merge it since we're getting close to nitpicking :)


[New game]: Add "Tenzin Game" to the Repository

🎮 Game Request
I would like to propose the addition of a new game called "Tenzin Game" to the repository. Tenzin Game, also known as "Tenzies," is a simple yet addictive game where the objective is to make all the numbers on the board the same.
Point down the features
Game Rules:
The game board consists of a square grid with various numbers.
The player's goal is to make all the numbers on the board the same.
The player can choose a number and apply it to any other number on the board.
When a number is chosen, it replaces the original number and spreads to adjacent cells, changing them to the chosen number as well.
The process continues until all the numbers on the board are the same.
The player wins the game when all numbers on the board become the same.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Nishitbaria !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @Nishitbaria ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Database of online texts according to vocabulary frequency

Is your feature request related to a problem? Please describe.
It is hard to know which online text is the most suitable for the user of the current vocabulary level..
Describe the solution you'd like
Build an unofficial database: evaluate the difficulty level of texts according to a frequency list. The user can find the most suitable ones according to the user's vocabulary.
Additional context
Maybe the program can load a frequency list and evaluate added books itself, and then sort the books by vocabulary level.
Frequency lists: https://en.wiktionary.org/wiki/Wiktionary:Frequency_lists

I'll move this issue to a different location at some point, as it doesn't fall within Lute's scope as a reading tool.  This would be a different site and tool.

Specifying wont fix for Lute, but as mentioned this could go somewhere else.


Gradle plugin doesn't work with Compose Multiplatform 1.5.0-beta02

I tried to apply it to Compose Multiplatform 1.5.0-beta02 and got this:
An exception occurred applying plugin request [id: 'org.jetbrains.compose', version: '1.5.0-beta02']
> Failed to apply plugin 'org.jetbrains.compose'.
   > Shared build service 'org.jetbrains.compose.ComposeMultiplatformBuildService' has unexpected type: org.jetbrains.compose.ComposeMultiplatformBuildService$Inject

Okay, downgrading to 1.4.3 it doesn't work with Multiplatform at all. If I specify it in my android module, this does not help, too.
Please make it compatible with Multiplatform

Thanks for reporting. Will definitely add a support will update here

Actually currently it's android specific only

For now You can use the CLI version. To make compose compiler metrics work with compose multiplatform you need to add something like this to your root build.gradle.kts file:
allprojects {
    tasks.withType(org.jetbrains.kotlin.gradle.dsl.KotlinCompile::class.java).configureEach {
        kotlinOptions {
            // Trigger this with:
            // ./gradlew assembleRelease -PenableMultiModuleComposeReports=true --rerun-tasks
            if (project.findProperty("enableMultiModuleComposeReports") == "true") {
                freeCompilerArgs += listOf("-P", "plugin:androidx.compose.compiler.plugins.kotlin:reportsDestination=" + rootProject.buildDir.absolutePath + "/compose_metrics/")
                freeCompilerArgs += listOf("-P", "plugin:androidx.compose.compiler.plugins.kotlin:metricsDestination=" + rootProject.buildDir.absolutePath + "/compose_metrics/")
            }
        }
    }
}

Then you can use CLI version  pointing input path to "<YOUR_PROJECT_PATH>\build\compose_metrics

Thank you! That worked, I got my report. Awesome!
So it looks like Compose Multiplatform support out of the box shouldn't be too far away. :)

@mikolajefento thanks for the quick remedy.
@StefanOltmann yep, it's just that we'll need to create a plugin variant for multiplatform and I guess we'll be able to do it.

Hi @PatilShreyas I've initial implementation here #110 that addresses this issue and can make the plugin work with compose multiplatform, I need to do some more testing. but take a look at the PR and spot any potential issues or something that can be improved, I'm waiting for your review

Fixed and released in v1.4.0. Thanks @mr3y-the-programmer for the contribution


Configurable font fallback

It is said that fontconfig should be used for font fallback, but it seems that terminal emulators are not always using this recommended API for font fallback.

kitty uses fontconfig only for retrieving the set of all fonts, then filters and prioritizes manually)
wezterm seems to only support font fallback based on what the user has provided in the configs.
What is konsole, gnome-terminal and alacritty doing?
Not all fontconfig system configurations seem to be reliable (if any at all).

On top of using fontconfig for getting the list of fallback fonts maybe we could provide a manually provided list of font fallbacks too.

Evaluate the usefulness of selecting font files based on codepoints / codepoint sequences (such as kitty does provide)
Evaluate embedding Powerline glyphs (should be configurable, too)
Evaluate embedding box drawing glyphs (should be configurable, too)

@eproxus  Thanks for the interest
I will add this into milestone for 2024 since I wanted to disable font fallback and if memory is correct  @Utkarsh-khambra as well

I will add this into milestone for 2023 since I wanted to disable font fallback

You mean rely on fontconfig only? Will this work on macOS?

Yes, only fontconfig, this will be naturally configurable, so if this does not work for macOS this option will not be available then. And for sure we will add other options for fallback. something like :
auto <- current behavior
priority <- list of fonts that we need to check first and if not found proceed with the rest
list <- user specified list of fonts that are used for fallback and not others
none <- do not try to find another font

Closing this one, now configuration allows some flexibility for font fallback and builtint fonts will be implemented in https://github.com/contour-terminal/contour/issues/170


[DDW-1017] Fix margin for dialogs content and token table header

This PR fixes margins for dialogs content and token table header. Added two storybook flags to show buttons on receive screen dialog.
Story: Receive - sequential with address verification
Flags: isAddressDerived and isAddressChecked
Todos

[ ] TODO

Screenshots

Testing Checklist

Slack QA thread
[ ] Test

Review Checklist
Basics

[x] PR assigned to the PR author(s)
[ ] input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
[ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer
[ ] All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
[x] PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
[ ] PR link is added to a Jira ticket, ticket moved to In Review
[x] PR is updated to the most recent version of the target branch (and there are no conflicts)
[x] PR has a good description that summarizes all changes
[ ] PR contains screenshots (in case of UI changes)
[x] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[x] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with typescript types
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Update Slack QA thread by marking it with a green checkmark

now bottom fixed area is 20px more than before https://zpl.io/VkABvQg

now bottom fixed area is 20px more than before https://zpl.io/VkABvQg

now bottom fixed area is 20px more than before https://zpl.io/VkABvQg

Updated.

em... but now it's too small.
How it was:

before buttons you have 30px distance
it was 20px part of top scrollable content
10px part of bottom fixed area
That's why it was not so trivial.

em... but now it's too small.
Here how it was:

before buttons you have 30px distance
it was 20px part of top scrollable content
10px part of bottom fixed area

That's why it was not so trivial.

Ok, lets try again, I updated.

3rd case scroll starting position is a bit off (but this one is not sooo critical, if we won't find more, we can probably ignore this bit)

3rd case scroll starting position is a bit off (but this one is not sooo critical, if we won't find more, we can probably ignore this bit) https://zpl.io/VkABvQg
UPD: on the next step position is OK

UPD2: on the third it's off again

Ok, fixed.


Unicode ℓ SCRIPT SMALL L 0x2113 is converted to ℳ

My source contains small script ℓ.
But temml is converting this to ℳ
<mi class="mathcal">ℳ</mi>

I don't think this was always the case (I think I would have spotted it), so suspect this is relatively new.

Sorry about that. It's fixed by release 0.10.9.


Patch 1

Key should always pass a unique value and not the index to have better performance when a component is re-rendered.

<div className={styles.card} key={key-${index}}>
Isn't key-${index} unique enough? ... This is the most elegant solution if our data doesnt have a dedicated id property.

We should always pass a unique ID as the key to tell react that which item has updated. Basically, react used to update the value using Index. It is same that if we are not passing Index also by default React use to check the diff using key index. And if the key is not unique React will think that all the nodes have got updated and it will re-render all the nodes which is a costlier operation. Either we need to get the value from JSON or we can have a helper func that will generate the unique key.

@Harishs84 Isnt  key0,key1,key2,key3,key4 ... or lets say  radio0,radio1,radio2,radio3 not unique enough to be used as keys for the Array.map(()=>{}) in question . Or is it mandatory requirement we should pass keys in the form of  xcv1231,zda1314,14321dsd,1241dasd  ?

Hi All,
Tried to create a small sample for the same.
https://www.webpackbin.com/bins/-KhwZ9ozimgy6YA-eNoX
Change the line #4 from key={item.id} to key={index} and inspect the same to experience what @Harishs84 was talking about.

Ah. Thanks for pointing this @whitehorse5353. The initial commit I have pushed with the card.id, but not sure why the second commit with style.id. Anyway, i have pushed the code with card.id. Thanks once again.


Script readability is a bit lacking

First of all I want to dearly thank you about the project. It's exactly what I'm looking for.
I haven't set it up yet and I'm just trying to figure out the exact mechanics it uses by reading the source.
However the mixed nix/bash scripts.nix makes it a bit harder than what it could be - hence this issue.
Would it be possible to split the scripts in their own .sh files each and include them in the scripts.nix? If so, I'd be happy to do it and submit a PR, it's more of a question if you're open to it (or have even better ideas!)
password manager integration is a sensitive subject and easily auditable code can aid a lot

Sure, that sounds good. The project was originally based on agenix, which does it this way, and I threw this project together for a hackathon so it was pretty hacked together.
But having separate .sh files will also let us run shellcheck and shfmt on them which is a great bonus.
Happy to look at a PR.


[DOC] update juicefs worker docs

Provide a link to that doc page:
What is the defect and your suggestions on improvement:

fixed by #2740


Do not remove the tearDownChannel onDetachedFromActivity.

Description
We should not tear down the method channel onDetachedFromActivity. That will cause MissingPluginException for the following method calls.
Related Issues
flutter/flutter#12264
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

This is the same fix as the share plugin: https://github.com/flutter/plugins/pull/3942.

@mhadaily Hi Majid, could you take a look at this PR?

Thank you @zhenqiu1101 !

publised under share_plus 2.1.2


deepMerge not merging arrays with existing arrays

I was trying to merge an array w/ a existing array on the source but it doesn't seem to merge :(
code
deepMerge({
  extract: {
    include: [
      'test/**/*.{js,ts,jsx,tsx,css}',
    ]
  }
}, {
  extract: {
    include: [
      'src/**/*.{js,ts,jsx,tsx,css}',
    ]
  }
});

output

fixed with 1.5.2


[WinAuth] Lack of Detail: [Authorize] attribute requires additional configuration in Startup.cs

In ASP.NET Core 2.x, the [Authorize] attribute requires additional configuration in Startup.cs to challenge anonymous requests for Windows Authentication. The recommended configuration varies slightly based on the web server being used.
Describe this

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 401ad9a0-9e51-80a2-5846-82e9790d7257
Version Independent ID: fbc36c26-9992-1f4c-66d3-02f898ee7ec4
Content: Configure Windows Authentication in ASP.NET Core
Content Source: aspnetcore/security/authentication/windowsauth.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @scottaddie
Microsoft Alias: riande

Hello @rbonomo ... AFAIK, that line refers directly to the following two sub-sections: IIS and HTTP.sys. AFAIK, it doesn't mean that there's more to say than what you see next.
@Tratcher is there anything else to say there? Here's the section under discussion ...
https://docs.microsoft.com/aspnet/core/security/authentication/windowsauth?view=aspnetcore-2.2&tabs=visual-studio#allow-anonymous-access

The key addition people usually overlook is services.AddAuthentication(IISDefaults.AuthenticationScheme);

The language is a little 😵 scatter brained 😵 leading into the server code examples that follow ... it sounds exactly like @rbonomo described it ... like there's something else ... something not explained. I'll address it. Thanks @rbonomo. :rocket:

The key addition people usually overlook is services.AddAuthentication(IISDefaults.AuthenticationScheme);

It would be helpful if it also outlined what this line does/why it is necessary for Windows auth. If windows auth is enabled/disabled in IIS directly, what does this do? Also whether this line limits the app strictly to an IIS deployment. I couldn't find a description of this extension method.

Comments on closed issues are not tracked, please open a new issue with the details for your scenario.


Static User GUID paired with Dynamic Session ID

I have a scenario where I want to call my service from Dynamics 365, but they don’t want the user to authenticate again (the user is in Azure AD and will be a user in both Dynamics and my service). In order for that call to be valid, I would send an identifier (user id/ email/ Azure AD object id) that is static and a token or sessionid that is dynamic but can be validated against.
How would you all approach developing a mechanism like this? Any reference architecture/ best practice to use here as I run into this scenario a lot?

How are you making the call from Dynamics, ie how is your service invoke?  I don't think you can just use an user ID and sessionID to authenticate.  You need to use your service 'secret' to identify that the call is coming from the Dynamics instance.  Please review this for plugin  https://community.dynamics.com/crm/b/crmchap/posts/what-is-unsecure-secure-configuration-on-a-dynamics-crm-365-for-enterprise-plugin
You can make this secure by having a setup process (from your service) where the admin goes through a consent flow and in the process you download your secret in the org's configuration where your plugins can read from in Dynamics and pass it to your service.


x86 version of Windows

This is compatible with only x64 bit Windows. Is it possible to have a 32 bit version? Please

A workflow for x86 builds has been added. Let me know if it works.

Hi LemonPi344,                            Thank you for taking my request into consideration by creating a x86 version of the screensaver. Unfortunately, I have copied it to the System32 folder where default screensavers are found but it gives me an error message when trying to launch it. Please find attached a snip of the error message. Thanks,BhasitLFrom: LemonPi314Sent: Sunday, 13 March 2022 23:06To: LemonPi314/dvd-screensaverCc: BhasitL; AuthorSubject: Re: [LemonPi314/dvd-screensaver] x86 version of Windows (Issue #1) A workflow for x86 builds has been added. Let me know if it works.—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>	Virus-free. www.avast.com

I cannot see your attachment, try sending it using the GitHub web interface instead of email.

Hi, Sorry for the late reply. Actually I had forgotten to attach the snip. I will attach it in this mail. The error message says that “Cannot open PyInstaller archive from executable (C:\Windows\System32\dvd-screensaver-x86.scr) or external archive (C:\Windows\System32\dvd-screensaver-x86.pkg)”Thanks From: LemonPi314Sent: Monday, 14 March 2022 00:59To: LemonPi314/dvd-screensaverCc: BhasitL; AuthorSubject: Re: [LemonPi314/dvd-screensaver] x86 version of Windows (Issue #1) I cannot see your attachment, try sending it using the GitHub web interface instead of email.—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>	Virus-free. www.avast.com

I saw that the attachment still does not appear in GitHub web interface and so I am attaching it here

.

It seems that x86 Pyinstaller packages have issues running from the System32 folder. Try moving the screensaver file to a user folder like %APPDATA%/LemonPi314/dvd-screensaver (same folder as the screensaver's config.json). Then right click on it and select "Install".

Ok. Thank you for your time ☺