BREAKING: Build packages with tsup

Explanation
This changes the build system to build all packages with tsup, instead of tsc. tsc is still used for generating the declaration files and type checking, and tsup is used for building the .js and (new) .mjs files. The benefit of this is that we now have a ESM build as well as a CJS build.
References
See MetaMask/utils#144.
Changelog

@metamask/accounts-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/address-book-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/announcement-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/approval-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/assets-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/base-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/build-utils

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/composable-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/controller-utils

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/ens-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/eth-json-rpc-provider

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/gas-fee-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/json-rpc-engine

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/json-rpc-middleware-stream

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/keyring-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/logging-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/message-manager

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/name-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/network-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/notification-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/permission-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/permission-log-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/phishing-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/polling-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/preferences-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/queued-request-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/rate-limit-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/selected-network-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/signature-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/transaction-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

@metamask/user-operation-controller

BREAKING: Add ESM build.

It's no longer possible to import files from ./dist directly.

Checklist

[ ] I've updated the test suite for new or updated code as appropriate
[ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

@SocketSecurity ignore<EMAIL_ADDRESS>@SocketSecurity ignore<EMAIL_ADDRESS>@SocketSecurity ignore<EMAIL_ADDRESS>These are expected to have shell / network access.
@SocketSecurity ignore<EMAIL_ADDRESS>New author is ok.

@metamaskbot publish-preview

I am not sure why the check failed, but once this branch is updated against main, it should re-run that check.


Use workspace/tests and document/tests requests to list tests inside a project

https://github.com/apple/sourcekit-lsp/issues/611 introduced the workspace/tests and document/tests methods to lists all tests within a workspace or document. The VS Code extension should be using them to list the available tests.

Awesome I missed that went in.

Does this request need a built project?

Yes, it does. It reads the index to find the tests

@ahoppen Do these return SymbolInformation always, or can it return DocumentSymbols?

It currently always returns SymbolInformation and I don’t see any reason for us to change that in the foreseeable future.

Ok that's cool. The client always has the option of both.
By the way I have something up and running. I'll be posting a PR in the next day or so.

I'm in the process of looking at these and integrating them in to the Test Explorer.

@plemarquand Please review #761 and #762 for more details about both requests. It was easier to break them out into separate issues. I going to close this in favour of the two new issues.


Output debuging/informative messages to STDERR

I run into problem when trying tu use robo. Problem is that Robo outputs tons of information to STDOUT. But I need to process output of task I'm running (pipe it to another program).
Common approach is to output all debuging/informative messages to STDERR not to STDOUT so content of STDOUT is clean and can be processed. Is there any way how can do this with Robo?

I understand the point.
But also the other way could be required: only print anything to stderr, if it is a real error.
This is e.g. a problem in Drush on remote nodes.
If this is implemented in Robo, IMHO it has to be an option to be turned on: redirectInternalRoboOutputToStderr() or something like that ;)

Maybe it should be configurable by Config. Something like Config::setInternalOutput()

Quick fix I used is:
Config::setOutput(new StreamOutput(fopen('php://stderr', 'w')));

This redirects all output to stderr excepts what I explicitly send to stdout. It is not ideal but can be used for now.

Ah, ok. At first I thought you wanted to display the output of commands executed via ExecTask and all other output should go to stderr.
So you simply use echo in you tasks then?

Yes. I used this to redirec all output of tasks to stderr. If I want something explicitly redirected to stdout I echo it.

Robo now uses a PSR-3 logger that sends all diagnostic output to stderr, so this has been done.


SAA-1061 Risley specific migration of split regime activities

Recognise Risley split regime activities.
Create two activities for each one received
Generate the PM times on the 2 week schedule
Tests and integration tests.

Codecov Report
Patch coverage is 68.68% of modified lines.

Files Changed
Coverage

...iesmanagementapi/service/MigrateActivityService.kt
68.68%

:loudspeaker: Thoughts on this report? Let us know!.


Registry does not work after node restart

When running ValidatorCleanRestart with LocalRest this can be seen clearly. Node does not discover any Validators and fails to catch up.
2021-01-15 12:12:33,236 Error [agora.utils.Utility] - Exception happened while trying to get validator addressesRequest timed-out

2021-01-15 12:12:29,192 Info [agora.node.FullNode] - Shutting down..
2021-01-15 12:12:29,192 Info [agora.common.Task] - Tasks started: 427
2021-01-15 12:12:29,197 Info [agora.node.Ledger] - Last known block: #0 (0xd56c64a29cabc48a3517d8bf3d6d7e7324c3d5b2b2807045f16487c931b4178ba4f713a50eb43d7eb5e9a889cb13fcf3aac17ce22de07aa10fd9b4c2cecc8a5f)
2021-01-15 12:12:29,217 Trace [agora.consensus.EnrollmentManager] - Update validator lookup maps at height 1 for index 0 pubkey GDNODE2IMTDH7SZHXWDS24EZCMYCEJMRZWB3S4HLRIUP6UNGKVVFLVHQ
2021-01-15 12:12:29,218 Trace [agora.consensus.EnrollmentManager] - Update validator lookup maps at height 1 for index 1 pubkey GDNODE3EWQKF33TPK35DAQ3KXAYSOT4E4ACDOVJMDZQDVKP66IMJEACM
2021-01-15 12:12:29,218 Trace [agora.consensus.EnrollmentManager] - Update validator lookup maps at height 1 for index 2 pubkey GDNODE4KTE7VQUHVBLXIGD7VEFY57X4XV547P72D37SDG7UEO7MWOSNY
2021-01-15 12:12:29,218 Trace [agora.consensus.EnrollmentManager] - Update validator lookup maps at height 1 for index 3 pubkey GDNODE5T7TWJ2S4UQSTM7KDHU2HQHCJUXFYLPZDDYGXIBUAH3U3PJQC2
2021-01-15 12:12:29,218 Trace [agora.consensus.EnrollmentManager] - Update validator lookup maps at height 1 for index 4 pubkey GDNODE6ZXW2NNOOQIGN24MBEZRO5226LSMHGQA3MUAMYQSTJVR7XT6GH
2021-01-15 12:12:29,218 Trace [agora.consensus.EnrollmentManager] - Update validator lookup maps at height 1 for index 5 pubkey GDNODE7J5EUK7T6HLEO2FDUBWZEXVXHJO7C4AF5VZAKZENGQ4WR3IX2U
2021-01-15 12:12:29,218 Info [SCP] - LocalNode::LocalNode@GDNOD qSet: 204980
2021-01-15 12:12:29,221 Info [agora.network.NetworkManager] - Doing network discovery..
2021-01-15 12:12:29,221 Info [agora.consensus.protocol.Nominator] - Starting nominating timer..
2021-01-15 12:12:29,326 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:29,432 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:29,534 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:29,636 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:29,740 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:29,843 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:29,946 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:30,50 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:30,159 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:30,271 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:30,374 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:30,478 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:30,582 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:30,686 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:30,790 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:30,894 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:30,997 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:31,99 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:31,208 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
**2021-01-15 12:12:31,230 Error [agora.utils.Utility] - Exception happened while trying to get validator addressesRequest timed-out
2021-01-15 12:12:31,230 Error [agora.utils.Utility] - Exception happened while trying to get validator addressesRequest timed-out
2021-01-15 12:12:31,230 Error [agora.utils.Utility] - Exception happened while trying to get validator addressesRequest timed-out**
2021-01-15 12:12:31,312 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:31,416 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:31,518 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:31,622 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:31,727 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:31,830 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:31,933 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:32,37 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:32,147 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:32,251 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:32,354 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:32,458 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:32,561 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:32,665 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:32,769 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:32,872 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:32,975 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:33,78 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:33,182 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:33,236 Error [agora.utils.Utility] - Exception happened while trying to get validator addressesRequest timed-out
2021-01-15 12:12:33,236 Error [agora.utils.Utility] - Exception happened while trying to get validator addressesRequest timed-out
2021-01-15 12:12:33,236 Error [agora.utils.Utility] - Exception happened while trying to get validator addressesRequest timed-out
2021-01-15 12:12:33,288 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:33,391 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer
2021-01-15 12:12:33,494 Trace [agora.node.Ledger] - Going to nominate current timestamp [1610701943] or newer

I don't see how it is related to Name Registry... 	configure_network property is true right? That means this test doesn't have to rely on Name Registry.

I don't see how it is related to Name Registry... 	configure_network property is true right? That means this test doesn't have to rely on Name Registry.

The unittests currently do not use the name registry, do they ? They use https://github.com/Geod24/localrest/blob/v0.x.x/source/geod24/Registry.d . This should probably be changed.

The unittests currently do not use the name registry, do they ? They use https://github.com/Geod24/localrest/blob/v0.x.x/source/geod24/Registry.d . This should probably be changed.

The unittests currently do not use the name registry, do they ? They use https://github.com/Geod24/localrest/blob/v0.x.x/source/geod24/Registry.d . This should probably be changed.

We do have the name registry enabled in every unit tests, and we even have a test where we don't hardwire the network and just rely on the name registry. The log message from this ticket references the Name Registry. https://github.com/bpfkorea/agora/issues/1499#issue-786736763
This cannot be the reason why the ValidatorCleanRestart fails as for that test we don't rely solely on the Name Registry.

The unittests currently do not use the name registry, do they ? They use https://github.com/Geod24/localrest/blob/v0.x.x/source/geod24/Registry.d . This should probably be changed.

We do have the name registry enabled in every unit tests, and we even have a test where we don't hardwire the network and just rely on the name registry. The log message from this ticket references the Name Registry. https://github.com/bpfkorea/agora/issues/1499#issue-786736763
This cannot be the reason why the ValidatorCleanRestart fails as for that test we don't rely solely on the Name Registry.

@omerfirmak : Can you still reproduce ? HEAD seems to work fine (maybe because of https://github.com/bpfkorea/agora/pull/1629 ?).

No, it seems to be, at least, not erroring.


Provide more granular levels of disabling features

it should be possible to individually disable the current range of kube tech preview features
the community have previously request the following be configurable

app ssh
app deploy

issue covers both frontend AND jetstream

users may not want some plugin's endpoints exposed

covers both specific features and endpoint types

[QUESTION] Should the disable be applied at build, deploy and/or run time?

First pass

disable endpoints, frontend and back at build time

should be achievable by removing the frontend package or jetstream plugin
need an easy way to disable the jetstream plugins

framework to disable features, frontend and back at build time

apply to tech preview features, cf app deploy and cf instance ssh
should also consider #4482 (disable features due to environment)

fixed via #4596 and #4627


Add instruct

Implement raw model output support and direct Pydantic conversion
Update TypedDict handling with tests, including Required and NotRequired
Improve image conversion and serialization
Add prompt creation and pandas UDF with caching
Implement factory architecture for client fetching based on model or provider
Upgrade model serving using Pydantic objects
Enhance Databricks compatibility
Improve test coverage and project layout
Update documentation, including README and docstrings
Enhance serialization and Anthropic interactions
Update dependencies and fix deprecation warnings
Miscellaneous improvements:

Change to blue logo
Improve pandas configuration
Fix Spark-related bugs
Clean up legacy code

👍 👍


urllib3.exceptions.LocationParseError when proxy setting has un-safe characters

Describe the bug
If proxy username/password has un-safe characters (like ""), az login is failed due to URL parsing error by urllib3.
UnexpectedError: The command failed with an unexpected error. Here is the traceback:
Failed to parse: http://testdomain\user01:12345@proxy.co.jp:8080
Traceback (most recent call last):
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-nzvsnu6j\requests\adapters.py", line 412, in send
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-nzvsnu6j\requests\adapters.py", line 305, in get_connection
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-yitcvwac\urllib3\util\url.py", line 234, in parse_url
urllib3.exceptions.LocationParseError: Failed to parse: http://testdomain\user01:12345@proxy.co.jp:8080

To Reproduce
In Windows OS and using PowerShell.

set the following variables (with un-safe character.)
e.g.)

$env:HTTPS_PROXY = "testdomain\user01:12345@proxy.co.jp:8080"
$env:HTTP_PROXY = "testdomain\user01:12345@proxy.co.jp:8080"

run az login and sign-in operation

Expected behavior
Doesn't happen this error. Users can use un-safe characters.
(If we use 2.0.77 MSI build from official here, this issue is not happened.)
Environment summary
MSI install / At least after CLI 2.10.1 / Windows 10 / PowerShell
Additional context
Probably, this is related to urllib3 version using by azure-cli. In Non-issued version (2.0.77 MSI official build package) uses urllib3 1.24.2.

On the other hands, recently issued version uses urllib3 1.25.3. This version is same issue (https://github.com/psf/requests/issues/5097) is reported other environment.
Moreover, in urllib3, it looks fixed from next version 1.25.4.
https://pypi.org/project/urllib3/

Remove dependency on rfc3986 for URL parsing.

Approach

modifying "urllib3==1.25.4" in src/azure-cli/requirements.py3.windows.txt
then, building the MSI according here.
install azure-cli using this MSI.

I tried this approach was successes, the issue has resolved.
Question
Could you fix it?
Kind Regards.

add to S176

https://github.com/Azure/azure-cli/pull/16663 already fixed this issue:
https://github.com/Azure/azure-cli/blob/c9d47420c4c644099d18c4879bf203be23fd579b/src/azure-cli/requirements.py3.windows.txt#L131
Please upgrade to the latest version of Azure CLI: https://docs.microsoft.com/en-us/cli/azure/install-azure-cli


Something happened to the website and the processing speed

My actions before raising this issue

[ ] Read/searched the docs
[ ] Searched past issues

Expected Behaviour
About 2 weeks ago, at the same time of day, I downloaded a dataset with 1k images. Auto-rotation didn't take very long, which was good.

Current Behaviour
But now I have uploaded a dataset of 200 images and the auto-annotation has not advanced by 1 percent. I also began to see hash requests in the network packet log, the answer to which is the statuses of not my tasks, that is, I see which tasks are currently being processed. I'm not sure if this was not the case before, but now it definitely is.

Operating System and version (e.g. Linux, Windows, MacOS):
Code example or link to GitHub repo or gist to reproduce problem:
Other diagnostic information / logs:
Logs from `cvat` container

Next steps
You may join our Gitter channel for community support.

@decadance-dance , I will close the issue. It looks like Andrey answered the question.


[build] Update to latest revisions of upstream layers

Merged to the other branch as well:
310de57ff..140b1768e  build -> build-next


Update readme.md

Get e'm up and running with a node, fast.

see #20 #19 - as this is related to a testnet, I think it belongs in the testnets repo https://github.com/CosmosContracts/testnets/tree/main/lucina and all three PRs can be combined into one 👍

Its more easy share rpc endpoint.

For ease of use, share the rpc endpoint.

Closing as related to other PRs that are now closed.


openai.AsyncOpenAI not safe when shared across async tests

Confirm this is an issue with the Python library and not an underlying OpenAI API

[X] This is an issue with the Python library

Describe the bug
When sharing AsyncOpenAI across async tests, it's possible to hit openai.APIConnectionError: Connection error.
To Reproduce
https://colab.research.google.com/drive/1icWDkN2iYPl3mxCEwA0-kE7GSSOeM9E8?usp=sharing
Code snippets
import pytest
from openai import AsyncOpenAI

client = AsyncOpenAI()

@pytest.mark.asyncio
async def test_completion1() -> None:
    await client.chat.completions.create(
        model="gpt-4o-mini",
        messages=[{
            "content": (
                "Here is a question, the correct answer to the question, and a proposed"
                " answer to the question. Please tell me if the proposed answer is"
                " correct, given the correct answer. ONLY SAY 'YES' OR 'NO'. No other"
                " output is permitted.\n\nQuestion: What is 25 * 10? \n\nCorrect"
                " answer: 250 \n\nProposed answer: 250"
            ),
            "role": "user",
        }],
    )

@pytest.mark.asyncio
async def test_completion2() -> None:
    await client.chat.completions.create(
        model="gpt-4o-mini",
        messages=[{
            "content": (
                "Here is a question, the correct answer to the question, and a proposed"
                " answer to the question. Please tell me if the proposed answer is"
                " correct, given the correct answer. ONLY SAY 'YES' OR 'NO'. No other"
                " output is permitted.\n\nQuestion: What is 25 * 10? \n\nCorrect"
                " answer: 250 \n\nProposed answer: 250"
            ),
            "role": "user",
        }],
    )

OS
linux
Python version
3.10.12
Library version
1.51.0

Thanks for the report, what version of httpx / httpcore are you using? (I can't open the colab link right now)

Hello @RobertCraigie thanks for the quick response, it's httpx=0.27.2 and httpcore==1.0.6

I see the same issue.
httpx==0.27.2
httpcore==1.0.6
In my case I use pytest with async and ainvoke on ChatOpenAI
BUT, if I use ChatBedrock, everything is working.
Since I was breaking my head against this, one hint is that I've tried to trace it
and I printed the "real" error which is not a connection error, but "Event loop is closed"
This is the line it fails, if you print the err object, you would see it.
https://github.com/openai/openai-python/blob/main/src/openai/_base_client.py#L1584
raise APIConnectionError(request=request,message=str(err)) from err
Hope that will give us some more insights..

update your OpenAI to the latest.

Thanks for reaching out. An update has been sent to fix the issue. We will
let you know once the issue is resolved.
God bless you. Grace be unto you and Peace be multiplied.
Anointing J. Mayami
+2348140070908
@.***
On Tue, Oct 8, 2024 at 12:53 PM Rotem @.***> wrote:

I see the same issue.
httpx==0.27.2
httpcore==1.0.6
In my case I use pytest with async and ainvoke on ChatOpenAI
BUT, if I use ChatBedrock, everything is working.
Since I was breaking my head against this, one hint is that I've tried to
trace it
and I printed the "real" error which is not a connection error, but "Event
loop is closed"
This is the line it fails, if you print the err object, you would see it.
https://github.com/openai/openai-python/blob/main/src/openai/_base_client.py#L1584
raise APIConnectionError(request=request,message=str(err)) from err
Hope that will give us some more insights..
—
Reply to this email directly, view it on GitHub
https://github.com/openai/openai-python/issues/1777#issuecomment-2399633471,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BK7UCY3CEGU5JCVXCI5YMLLZ2PBSRAVCNFSM6AAAAABPN3LTC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGYZTGNBXGE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It happens because by default pytest-asyncio creates a new event loop for each test. But your tests are using the same client. And when you try to use the same client concurrently from different event loops, this error occurs.
Change your test decorators to pytest.mark.asyncio(loop_scope="session")

Thanks @bhumkong, I'm going to close this as it doesn't appear to be an SDK bug. Please re-open if you're still running into issues!

Thank you @bhumkong, nice work and appreciate your breakdown

@bhumkong Thank you! I can confirm this worked.


Fix LB invocation

In the LB refactor, LBManager started to call InvokeLB directly, but this doesn't work for all existing LBs, so switch back to using barrier receivers to invoke LBs. Also, correct LB creation order and enabling/disabling LBs.

Eventually all of the LB invocation stuff should be handled directly in LBManager. I plan to extricate LocalBarrier from LBManager (they are currently intertwined), and then LBManager itself will have a barrier receiver, which, when called, will call into the appropriate LB. This change is merely an intermediate step to get the LBs working in the meantime.

I may have renamed AtSync -> InvokeLB incorrectly in DistBaseLB.C. Instead renaming ProcessAtSync -> InvokeLB might fix the issue with invoking DistributedLB. If this is a simpler fix, we may not need to switch back to local barrier receivers.

I may have renamed AtSync -> InvokeLB incorrectly in DistBaseLB.C. Instead renaming ProcessAtSync -> InvokeLB might fix the issue with invoking DistributedLB. If this is a simpler fix, we may not need to switch back to local barrier receivers.

I've done this in 9dc6e4d.


feat(playground): add new router view

Great work!
A couple of suggestions:

[ ] Delete default select from the editor. (Will do it in the main branch).
[ ] Captcha seems to be slowing down the main page loading. Perhaps we could move it into the playground only.
[ ] Use line(smooth) as default in Chart option. (Will do it in the main branch).


Create a guideline for Architectural Decision Record (ADR)

Architectural Decision Record (ADR) Guide
An Architectural Decision Record (ADR) is a document that captures an important architectural decision made along with its context and consequences. An ADR is a short document that is written collaboratively by the development team, ideally at the time of the decision. The ADR is a record of a decision that has been made, not a record of the options that were considered.

1. Category

1.1. Procedure
1.2. Rules
1.3. Code Owner
1.4. Template

2. References

1. Category
1.1. Procedure
Adopting ADRs is a process that can be done incrementally. The following steps are recommended:
stateDiagram-v2
    [*] --> s1
    s1 : Architecture Decision (AD)
    s1 --> s2
    s2 : Identify Owner of ADR
    s2 --> s3
    s3 : Create an ADR in Proposed state
    s3 --> s4
    s4 : Create a Merge Request
    s4 --> s5
    s5: ADR in Rejected state
    s5 --> [*]

    s4 --> s6
    s6 : Modify the ADR
    s6 --> s4
    s6 --> s7
    s7 : ADR in Accepted state
    s7 --> [*]

1.2. Rules

Naming Convention
The name of the ADR file should be kebab-case and end with the extension .md.

Identifier

The unique identifier is a sequential number, which ensures that each ADR has a unique filename.

adr-[unique-identifier]-[title].md

Data Format

The date is written in the ISO 8601 format, which ensures that the files are sorted in chronological order.

adr-[YYYYMMDD]-[title].md

Project Layout
The ADRs should be stored in the docs/adr directory.
.
├── /docs
│   └── /adr
│       ├── adr-001-build-system.md
│       ├── adr-002-dependency-manager.md
│       └── adr-003-test-framework.md

1.3. Code Owner
The Code Owners file defines the owners of a file in a repository. The Code Owners file lives in the repository's root directory. The file must be named CODEOWNERS. The Code Owners file uses the same syntax as .gitignore files. Specify individual users and teams as owners, or add a wildcard * to indicate that all members of the organization are owners.
# All group members as Code Owners
[Project] @group-x
*

[Documentation]
  # All subgroup members as Code Owners
  /docs/adr/ @group-x/subgroup-y

1.4. Template
The template is a guide and should be adapted to the needs of the project.
# ADR [Identifier]: [Title]

[TL;DR: Brief description of the Architectural Decision (AD).]

- Autor(s): [The author(s) name(s) involved in the architecture decision.]
- Date: [YYYY-0M-0D]
- Status: [Proposed | Accepted | Rejected | Deprecated | Superseded
    - Proposed
      > The decision is under consideration but has not been accepted or implemented yet.
    - Accepted
      > The decision has been agreed upon and is expected to be implemented.
    - Rejected
      > The decision was not accepted, usually due to it being impractical or inappropriate for the current context.
    - Deprecated
      > The decision was once accepted but is no longer recommended for use, typically because the context has changed or better options have emerged.
    - Superseded
      > The decision has been replaced by a newer, superior alternative. This status is usually accompanied by a reference to the ADR that supersedes it.
  ]

## 1. Context

[Provide context for the decision, including any relevant background information, system architecture, business requirements, etc.]

## 2. Decision

[State the decision that was made, using clear and concise language. Explain the reasons behind the decision, including the problem or opportunity that the decision addresses, the constraints that were considered, and the options that were evaluated.]

## 3. Implementation

[Optional: Explain how the decision will be implemented, including any technical details, changes to the system's architecture or code, organizational or process-related changes, etc.]

## 4. Consequences

[Describe the potential impact of the decision on the system and its stakeholders, including any technical, operational, or business-related consequences.]

## 5. Alternatives

[List the alternative options that were considered before the decision was made, and explain why they were rejected or chosen.]

## 6. References

[Optional: List any related ADRs that are relevant to the decision being documented. List any sources that were consulted or referenced in making the decision.]

2. References

GitHub ADR page.
GitLab Code Owners page.
Amazon ADR page.

ADR-[Identifier]: [Title]
Architecture Decision Record (ADR) on [Description].
1. State

Author(s): [Author(s) Name(s)]
Date: [Date]
Status: [Status]

2. Context
[Provide the context for the decision, including any relevant background information.]
3. Decision

[Option Chosen]

[Provide the reasoning for the chosen option.]

4. Considered
[List the options that were considered along with their pros and cons.]
5. Consequences
[List the consequences of choosing each option.]
6. Implementation

[Provide any relevant links or resources related to the implementation.]

7. References

[List any relevant references or sources.]


Fix CI Test

Overview

Un comment iOS test from CI to run ios build on PR
Test Plan

Closing this for now


The clicked radio is not selected

When i click through the RadioForm it has a strange behaviour. Only every second click gets active.

When clicking the same radio twice, it works.
Looks like the created radios are not connected correctly?
<EMAIL_ADDRESS>version "2.6.0"

<RadioForm
  radio_props={radioAnswers}
  initial={10}
  buttonColor={'#444'}
  onPress={(value) => this.setState({ answer: value })}
  style={BasicStyles.radios}
/>

Found out, that the user interface works correctly, if changing the onPress method to onPress={(value) => console.log(value)}. So something with setting the state is confusing?

I have the same problem and it is true that the value actually got updated the first time it is clicked. Anyone have solution for this?

After looking at the SimpleRadioButton.js file and tried several changes, I found that the error will be gone after I disabled the code from line 36 to 40.
// componentWillReceiveProps (newProps) {   //   if (newProps.initial !== this.state.is_active_index) {   //     this.setState({ is_active_index: newProps.initial })   //   }   // },

Can you open a Pull Request for this?
Maybe @moschan will have a look then?

Done creating PR

Hi, thank you for your report and PR.
I updated new version, please check the latest one.


Cargo install failed

Hi, I wanted to try the formatter but cargo install typst-fmt (cargo 1.70.0) return the following error which seems weird since the Cargo.toml file in the repo contains a bin section. So I'm a confused. Does anyone else encounter this issue ?
❯ cargo install typst-fmt
    Updating crates.io index
error: there is nothing to install in `typst-fmt v0.1.0`, because it has no binaries
`cargo install` is only for installing programs, and can't be used with libraries.
To use a library crate, add it as a dependency to a Cargo project with `cargo add`.

that's weird, I think it was in a working state two weeks ago, now it's not gonna work for a while, I want it to be a satisfying experience before it can be installed again!

I was confused, because I remember that I was able to get the binary, but now I can't. I wanted to check on the new little improvements.
If your program is not in release stage (under v1.0.0), then I assume that it is not production ready. Hence, could be not a satisfying experience. But I think you should give the option to be able to get the binary. On GitHub, if you are creating a release, you can flag it as "pre-release" or something (I don't remember), to let everyone know that it can have some bugs or unpolished things.

I worked in it today, it's pretty rough (files won't open for some reason) but it's on the bin branch if you want to take a look! Also cargo install wouldn't work because this is not really published to crates.io (since typst isn't either and I depend on it)

I'll close this when I or someone else add a little install guide to the readme

You mean like this:
git clone -b bin https://github.com/astrale-sharp/typst-fmt.git
cd typst-fmt
cargo build
mkdir -p ~/.local/bin
cp -f target/debug/typst-fmt ~/.local/bin/

With a note that ~/.local/bin must be in PATH variable (echo 'export PATH="$HOME/.local/bin:$PATH"' >> ~/.profile).

Or more simply like this :
git clone https://github.com/astrale-sharp/typst-fmt.git
cd typst-fmt
cargo install --path .

;)
if you're interested in writing yours up go ahead, I'll merge no problems! (otherwise I'll do it tomorrow!)

Yay, binary is back on master branch! But why it suddenly called typstfmt instead of typst-fmt?

if you're interested in writing yours up go ahead, I'll merge no problems! (otherwise I'll do it tomorrow!)

@astrale-sharp, check https://github.com/astrale-sharp/typst-fmt/pull/50.


Only David Start can approve_update to include video and desktop for novnc

WMS ID:11432
General requirements

Information in the workshop is adequate and updated
Code is correct and working
Links are correct
Make sure you enter the help email link in your manifest.json
Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list
Please confirm that the following is completed before submitting your PR

[ ] All filenames are lower case (including folders, images, files, etc.)
[ ] Filenames are descriptive
[ ] Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
[ ] Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
[ ] Image references in markdown contain an alternate text

tag @davidastart


add a coveralls badge?

it would be good to know
i realize that setting things up to actually work with coveralls takes time
it is not critical path
just documenting here.

fixed :)


Not enough words for a paper key.

I'm trying to add a new system to Keybase and I do not have access to the old system to use that as a verification process. I'm using the sponsor share that I generated and have used successfully in the past with 11 key words. When I use this again I get the above listed error. `Bad passphrase: Not enough words entered for a paper key. Please try again.
keybase version 1.0.37-20171208170249+025062c3a
"Linux Mint 18.3"

@patrickxb  it's 13 words, right?

Yes, 13.

Ah, I was using just the key words, didn't prefix it with the first two words that describe the paper key type. Thanks for the enlightenment.

👍 Maybe the app should give better errors

Might be a good enhancement, respond back that the proper number of words is 13 and that it begins with the key type.


Sort set of licenses in HTML report

Addresses issue #408.
This PR fixes a bug where license keys were not sorted correctly for merging projects with the same license set into one group.
In addition, the order of licenses displayed in the HTML report for merged groups is also sorted in the same way.
This change may cause output to be different than before.
A real-word example I found is here:
https://mvnrepository.com/artifact/com.facebook.android/audience-network-sdk/6.16.0
Before:
[https://github.com/facebook/facebook-android-sdk/blob/main/LICENSE.txt, apache-2.0.txt, https://www.facebook.com/legal/audience_network_beta_sdk_terms]

After:
[apache-2.0.txt, https://github.com/facebook/facebook-android-sdk/blob/main/LICENSE.txt, https://www.facebook.com/legal/audience_network_beta_sdk_terms]

./gradlew ktlintCheck -s runs successfully on my machine so I couldn't fix the build error.

@monae I just updated the branch. Run gradlew ktlintformat and add any changes.

Thanks!


why are we still using an ancient version of imgui

The current version of ImGui (WIP 1.79) is quite outdated. I attempted to upgrade to the latest version, but encountered problems due to significant changes in the docking API. Initially, I tried upgrading to version 1.83, but even that proved unsuccessful in my attempt to reach the latest version.

Yeah, it was not updated for quite a while. Thanks for noting, I will update it soon


[FEATURE] CLI option for queries

Describe the solution you'd like
I would like to have the option of providing a query value in the CLI to make sure all the tests I perform use this specific value. This query option should function similarly to the --header option that Schemathesis currently has.
Describe alternatives you've considered
I have the option of enforcing the values by using an enum instead of an example, and by setting the query to REQUIRED. This however would tell readers of the schema that this value is always used, which is not how the API actually works. I do not want a schema that is just for testing, I want to be able to provide the schema to consumers of the API with the correct context.

I think it is a great idea! I'll try to think about the API for it

Going to close this one in favor of #1676


Rider designer?

Rider now has a free community version.
Can we get a designer plugin for AlterNET UI?
Steps to do so might be.

Creation of uixml files in editor as well as thier backing classes
Visual ui display for uixml
Event connecting and disconnecting from editor
Drag and drop ui elements
Data Binding

You should take notes from the winforms designer.

I believe we will make a decision about the Rider https://www.jetbrains.com/rider/
support after Alternet.UI Version 1.0 is released. There are plenty of more important things to do.


Feature/create master correlation matrix

This algorithm retrieves the full data from all colaborating nodes and computes a correlation matrix over all the data.

Not sure how thorough I should do this. Given that the project is still very prototypical. Feel free to ignore comments if you think they are too much for this stage 🤗


[Feature] Intergrate with Alibaba/GraphAr

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Feature Description (功能描述)
The graph data migration between HugeGraph and GraphAr could be important. This can be implemented based on the HugeGraph Spark connector and the GraphAr Spark library, including reading graph data from HugeGraph to generate GAR files, and reading from GraphAr to create/update instances in HugeGraph.
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

CC: @acezen and @imbajin

Thanks to @liuxiaocs7, we also has a discussion  about integrate GraphAr through Loader,  we can discuss more details in the future.

Thanks to @liuxiaocs7, we also has a discussion about integrate GraphAr through Loader, we can discuss more details in the future.

I see, thanks for starting this discussion!

Thanks to @liuxiaocs7, we also has a discussion about integrate GraphAr through Loader, we can discuss more details in the future.

Hi, you mean this => https://github.com/alibaba/GraphAr/discussions/343?

Thanks to @liuxiaocs7, we also has a discussion about integrate GraphAr through Loader, we can discuss more details in the future.

Hi, you mean this => alibaba/GraphAr#343?

Yes, sorry for the wrong link...


No backend available on Win7 with latest versions

C:\Users\marnj>python -m visa info
Machine Details:
   Platform ID:    Windows-7-6.1.7601-SP1
   Processor:      Intel64 Family 6 Model 58 Stepping 9, GenuineIntel

Python:
   Implementation: CPython
   Executable:     C:\Anaconda\python.exe
   Version:        2.7.7
   Compiler:       MSC v.1500 32 bit (Intel)
   Bits:           32bit
   Build:          Jun 11 2014 10:41:43 (#default)
   Unicode:        UCS2

PyVISA Version: 1.6.4.dev0

Backends:
   ni:
      Version: 1.6.4.dev0 (bundled with PyVISA)
      #1: C:\windows\system32\visa32.dll:
         found by: auto
         bitness: 32
         Vendor: Keysight Technologies
         Impl. Version:<PHONE_NUMBER>
         Spec. Version: 5243136
      #2: C:\windows\system32\visa32.dll:
         found by: auto
         bitness: 32
         Vendor: Keysight Technologies
         Impl. Version:<PHONE_NUMBER>
         Spec. Version: 5243136
   py:
      Version: 0.2.dev0
      ASRL INSTR: Available via PySerial (N/A)
      TCPIP INSTR: Available
      USB INSTR: Available via PyUSB (1.0.0b2). Backend: N/A
      USB RAW: Available via PyUSB (1.0.0b2). Backend: N/A

Python 2.7.7 |Anaconda 2.1.0 (32-bit)| (default, Jun 11 2014, 10:41:43) [MSC v.1
500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
Anaconda is brought to you by Continuum Analytics.
Please check out: http://continuum.io/thanks and https://binstar.org
>>> import visa
>>> rm = visa.ResourceManager('@py')
>>> rm.list_resources()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Anaconda\lib\site-packages\pyvisa\highlevel.py", line 1554, in list_r
esources
    find_list, return_counter, instrument_description, err = lib.find_resources(
self.session, query)
  File "C:\Anaconda\lib\site-packages\pyvisa-py\highlevel.py", line 240, in find
_resources
    for key, st in sessions.Session.iter_valid_session_classes()], [])
  File "C:\Anaconda\lib\site-packages\pyvisa-py\usb.py", line 148, in list_resou
rces
    for dev in usbtmc.find_tmc_devices():
  File "C:\Anaconda\lib\site-packages\pyvisa-py\protocols\usbtmc.py", line 69, i
n find_tmc_devices
    return find_devices(vendor, product, serial_number, is_usbtmc, **kwargs)
  File "C:\Anaconda\lib\site-packages\pyvisa-py\protocols\usbutil.py", line 200,
 in find_devices
    return usb.core.find(find_all=True, custom_match=cm, **kwargs)
  File "C:\Anaconda\lib\site-packages\usb\core.py", line 1199, in find
    raise ValueError('No backend available')
ValueError: No backend available

Thanks for testing this. It would be great if you help me to debug this. A few questions

Have you tried in other version of Windows? Which?
It seems that pyserial and pyusb are installed.
Can you actually try to import them in Python and do something with them. The "N/A" is weird: it should look like:

      Version: 0.1.dev0
      ASRL INSTR: Available via PySerial (14.1.0)
      TCPIP INSTR: Available
      USB INSTR: Available via PyUSB (1.0.0rc1). Backend: libusb0

I only have the one Win7 machine right now. I did test in both 32 & 64 bit python installs with the same results.
I get no errors importing serial or usb.
In [4]: usb.version_info
Out[4]: (1, 0, 0, 'b2')

Not sure what else to try with serial or usb.

can you also post the output of:
import serial
ver = serial.version

I think that there are three issues here:
1.- The PySerial version is not reported (this is PyVISA-py responsibility)
2.- PyUSB does not have a backend. (this is PyUSB responsability and might be related to a lack of libusb or similar in your system. See https://github.com/walac/pyusb/issues/26)
3.- PyVISA-py still tries to use USB even if PyUSB has no backend (this is PyVISA-py responsibility)
I will fix 3, it would be great if you can look at 2.
And if you can help to understand 1.

In [5]: serial.version
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-5-bc4648fda10c> in <module>()
----> 1 serial.version

AttributeError: 'module' object has no attribute 'version'

I have libusb1 installed, version 1.3.0

Just realized this:
In [9]: serial.VERSION
Out[9]: '2.7'

In my computer
>>> import serial
>>> serial.version
['14', '1', '0']
>>> serial.VERSION
'2.7'

Looking at the PySerial code, I think it is quite messy how the version is handled due to 2to3 usage.
Regarding PyUSB (point 2), I am convinced that the problem is not in PyVISA but in your PyUSB installation or in PyUSB. I would suggest that you try to make the find command work as described here: https://github.com/walac/pyusb/blob/master/docs/tutorial.rst

I think my usb problem is the install (or lack of) libusb1.0. I had installed libusb1 using pip but hadn't realized it's just a wrapper for libusb1 and doesn't get me the dll. It looks like installing libusb1 itself is a royal pain on Windows that I don't have time to mess with right now.

Then I will close this issue and open others por the pending stuff.


Propose a new feature: the agent management portal provide a button to fetch the agent application.yml config

Propose a new feature: the agent management portal provide a button to fetch the agent application.yml config, so the user don't have to edit it by themselves.

Can I work on this feature?

Can I work on this feature?

Sure thing, are you clear about the detail work and expectation for it? I'm not sure whether this description is clear enough.

If I understand well you want a button for fetching the agent config (name, id and secret) in application.yml.

I want to know if you want also to automate the copy operation (cp agent/application-sample.yml application.yml) when click the button!

Or If you want to generate the application.yml file directly in root folder with fetched data when the button is clicked, the copy operation will no longer be needed!

What text do you want to put on the button?

Thanks so much, your understanding is quite right! When clicking the button, user will get a triggered download action, and get a downloaded application.yml file containing the agent configurations. @zhou9584 and @lifesaver0129 can help you review the PR.
As for the button text, I assume it should be a material design icon with the same style as the 2 on the right and the alt text can be "Download agent config file: application.yml".

@MarianConstantinMarica I've assigned this issue to you. @zhou9584 please help answer Marian's question during the development, thanks.

I made the PR!

PR has been merged. Thank you for your contribution.


VPN’s causing extreme slow internet

I had this issue for about 1-2 months now, but I never found the root cause of it, I tried to contact uncover devs but they said it wasn’t an uncover problem. It is a uncover problem, I had no tweaks installed and same problem. I’m jailbroken with an iPhone XR 13.3, the VPN that caused the problem was an adblocker.
Edit: I forgot to mention but my data worked fine after I disabled the adblocker, but still, it’s a really annoying problem

@SupremoSG does it happen in non-jailbroken mode(stock). Does it happen with the tweaks switch turned off? Does it happen after userspace reboot? Please post unc0ver diagnostics.

@SupremoSG bump.

No response.


PackageName changed to Name

Sorry, creted 2 pull requests instead of 1, was doing this from Github UI... both need to be applied


Feature Request: parsing just name and issue number

I really do not know anything about how this software works, only that it is wonderful and I really appreciate all the hard work.
That said, I do sometimes find files that do not conform to any sort of "standard" naming format, so they will have the wrong year (series start instead of  issue release year) or free text in the filename not enclosed in parentheses.  Both of those things throw off the search function.  Was wondering if it would be possible to add an option that would tell the search function to only search using the series name and issue number, i.e. throw out everything following those two items.  Yes, it could possibly make for a broader search, but it would also avoid more than a few "Not match found; save aborted" errors and allow comictagger to continue on its way nicely.
If not possible or too complicated, understand completely.  Just a thought.
Edit:  Had a thought.  I normally use the CLI version, but decided to see what the GUI parses when a "bad" filename is put in (no parentheses).  Turns out that it thought that the entire thing was the series name.  Didn't even figure out what the issue number was.  Don't know if that helps, but...

The only information that ComicTagger uses to search is year, series name, and issue number when in the GUI you can either remove the year or when using the Auto-Tag feature there is an option to ignore it
On the CLI you can specify metadata via the -m option for example -m year= will unset the year

Thank you for that.  In that case, I think it is the part in my edit that is pertinent, then.  When text is not in parentheses, it throws off the parsing and comictagger thinks that all of the free text is the series name, sometimes including the issue number.
These two images should illustrate what I mean.  The only difference between the two files loaded into the GUI is the filename (I copied the file and then renamed the new one, taking out the parentheses, which is the way that I got it).  If it is just a single file or even a dozen, okay, I can deal with that, but it does get tedious.  The problem really gets annoying when there are lots of files of varying lengths to rename properly, which is really not fun.
So, maybe this isn't really a "feature request" as much as a bug, since CT isn't parsing the series name correctly when the filename is malformed?
And as I said before, if there is nothing to be done in the program, that is fine, I will continue as before.  But I really do appreciate you taking a look at this.

So for this reason there are two filename parsers. If you go into settings under Filename Parser there is an option to enable the 'Complicated Parser'. It should parse out the filename as you want it to

Also for parsing any file if the number has a hashtag in front of it it will do several times better than if it does not

That did it!!  Woohoo!  I had no idea that setting was there.  Thank you so much!!!


Require Hash & Eq implementations for all Register and Flag implementations

Already present in all the core implementations (1, 2, 3), however when being generic over Architecture you won't get them. I.e.
// A: Architecture
let registers: HashMap<A::Register, u128> = HashMap::new();

Requiring both Hash & Eq for Register and Flag implementations means we can use them as HashMap keys, which I have ran into on multiple occasions.
This is a very small PR and probably should be expanded on further later to more traits.

I went ahead and implemented Hash, PartialEq & Eq for the riscv register type.

Looks great, thank you!


ios build on macbook m1 is breaking

[ ] when trying to run on macbook pro m1 the build of ios breaks

The following build commands failed:
	CompileC /Users/daniloassis/Library/Developer/Xcode/DerivedData/sample-dejkzylgxrmagjchurjlbdcfibad/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FlipperKit.build/Objects-normal/arm64/FlipperClient.o /Users/daniloassis/Documents/projects/oidc/asgardeo-react-native-oidc-sdk/sample/ios/Pods/FlipperKit/iOS/FlipperKit/FlipperClient.mm normal arm64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'FlipperKit' from project 'Pods')
(1 failure)

looks like the problem it was with flipper. So, I just turn off it commenting the following lines inside the Podfile
  #   use_flipper
#   post_install do |installer|
#     flipper_post_install(installer)
#   end

Closing the issue as this repo is no longer maintained.


Enhancement: add possibility to specify path/filename for saving

Please consider adding the option to select/specify a path/filename for saving data (maybe as a default option in exension's settings).
Lots of people/projects have .vscode ignored (in .gitignore).
I would like to keep the saved kanban file in the root of the project, maybe in something like KANBAN.json, and be able to push changes to git (if .vscode directory is .gitignored) - this would be a neat feature.
Thank you!

One more thing.
I really don't want to overcomplicate this extension. I never want to get to the point where new users need a tutorial prompt or anything close to that. The reason I made this extension in the first place was because I wanted something quick and easy to use that had little to no learning curve.
I also don't want to deprive people of the ability to use this program how they want to. Especially in this case, where it seems many people want some way to change the file name. I'm just asking that you keep in mind the balance between killer features and overall ease of use.
Also, if anyone else has suggestions regarding this issue, feel free to chime in.

I think setting the name of the default file to KANBAN.json (and storing it in the root of the project along with other files like README.md & co.) would be a great addition. Most projects I've seen / used don't commit the .vscode folder (it is .gitignore'd), so, storing the file in the workspace is not very feasible for versioning.
I'm all for simplicity and self-explanatory UIs, but having the possibility to version this file would be of great benefit, so if you could find a simple way to add this, it'd be a win!
Keep up the good work!

In the 1.7 branch there's a new extension setting that let's you set valid filenames in descending priority. I couldn't find a simple-to-use solution that I was perfectly happy with, so I'm settling for a more complicated (but powerful) option hidden in the settings :/

I want this feature too...
i think this will be good idea:

make the extension a handler for kanban files. so if one just clicks on the kanban file in the explorer, this extension will open and preview it
a way to make a kanban file "active", so it will be opened when we press the button in the bottom status bar in vscode (or simple open it in any way)

so if someone wants to open another kanban file just to check it for once, he can do it.
this can be just a button on top, beside the "settings" button. click to set the current file as active.

If for some reason "active" kanban file is not found (moved/deleted) then opening the extension will show 1-time notification of something like:

<active_kanban_filename> was not found. opening another kanban from default directory

if everything looks complicated, then, these features will be set "disabled" by default, but users can go to settings and enable "multiple kanban handling, active kanbans" etc options... to get these features.

I'm requesting it because i tried many kanban extensions for vscode but yours is the most beautiful and responsive. the drag and drop feeling is so nice, and interface is simple and beautiful. <3


defaultOutput in kafka not using configured topic name

We have configured our sinks as below still all events going into default topic called buz_events. do we need to configure it elsewhere. why its using buz_events as defaultOutput . is it hardcoded?
    sinks:
      - name: primary
        type: redpanda
        deliveryRequired: true
        brokers:
          - redpanda-0.redpanda.redpanda-prod.svc.cluster.local:9093
          - redpanda-1.redpanda.redpanda-prod.svc.cluster.local:9093
          - redpanda-2.redpanda.redpanda-prod.svc.cluster.local:9093
        defaultOutput: tw-valid
        deadletterOutput: tw-invalid
      - name: secondary
        type: stdout
        deliveryRequired: true

@jakthom  we are using   tag: "v0.14.0"

@sachingade20 that makes sense - highly recommend updating

@jakthom it works now


v 2.0.2 NT_STATUS_INVALID_PARAMETER

When I try to connect to my PC in the usual way I now get the following error and no connection.

See Frame 13 in particular.
No.     Time           Source                Destination           Protocol Length Info
1 0.000000000    <IP_ADDRESS>         <IP_ADDRESS>        NBSS     60     Session keep-alive
Frame 1: 60 bytes on wire (480 bits), 60 bytes captured (480 bits) on interface 0
Ethernet II, Src: Avm_3c:ae:eb (9c:c7:a6:3c:ae:eb), Dst: IntelCor_f7:53:65 (00:1c:c0:f7:53:65)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 445 (445), Dst Port: 52503 (52503), Seq: 1, Ack: 1, Len: 4
NetBIOS Session Service
No.     Time           Source                Destination           Protocol Length Info
2 0.210401000    <IP_ADDRESS>        <IP_ADDRESS>         TCP      54     52503→445 [ACK] Seq=1 Ack=5 Win=16211 Len=0
Frame 2: 54 bytes on wire (432 bits), 54 bytes captured (432 bits) on interface 0
Ethernet II, Src: IntelCor_f7:53:65 (00:1c:c0:f7:53:65), Dst: Avm_3c:ae:eb (9c:c7:a6:3c:ae:eb)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 52503 (52503), Dst Port: 445 (445), Seq: 1, Ack: 5, Len: 0
No.     Time           Source                Destination           Protocol Length Info
3 44.098888000   <IP_ADDRESS>        <IP_ADDRESS>        TCP      74     34671→445 [SYN] Seq=0 Win=14600 Len=0 MSS=1460 SACK_PERM=1 TSval=704903 TSecr=0 WS=128
Frame 3: 74 bytes on wire (592 bits), 74 bytes captured (592 bits) on interface 0
Ethernet II, Src: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3), Dst: IntelCor_f7:53:65 (00:1c:c0:f7:53:65)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 34671 (34671), Dst Port: 445 (445), Seq: 0, Len: 0
No.     Time           Source                Destination           Protocol Length Info
4 44.101362000   <IP_ADDRESS>        <IP_ADDRESS>        TCP      74     445→34671 [SYN, ACK] Seq=0 Ack=1 Win=8192 Len=0 MSS=1460 WS=256 SACK_PERM=1 TSval=4539585 TSecr=704903
Frame 4: 74 bytes on wire (592 bits), 74 bytes captured (592 bits) on interface 0
Ethernet II, Src: IntelCor_f7:53:65 (00:1c:c0:f7:53:65), Dst: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 445 (445), Dst Port: 34671 (34671), Seq: 0, Ack: 1, Len: 0
No.     Time           Source                Destination           Protocol Length Info
5 44.103565000   <IP_ADDRESS>        <IP_ADDRESS>        TCP      66     34671→445 [ACK] Seq=1 Ack=1 Win=14720 Len=0 TSval=704909 TSecr=4539585
Frame 5: 66 bytes on wire (528 bits), 66 bytes captured (528 bits) on interface 0
Ethernet II, Src: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3), Dst: IntelCor_f7:53:65 (00:1c:c0:f7:53:65)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 34671 (34671), Dst Port: 445 (445), Seq: 1, Ack: 1, Len: 0
No.     Time           Source                Destination           Protocol Length Info
6 44.116810000   <IP_ADDRESS>        <IP_ADDRESS>        SMB      128    Negotiate Protocol Request
Frame 6: 128 bytes on wire (1024 bits), 128 bytes captured (1024 bits) on interface 0
Ethernet II, Src: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3), Dst: IntelCor_f7:53:65 (00:1c:c0:f7:53:65)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 34671 (34671), Dst Port: 445 (445), Seq: 1, Ack: 1, Len: 62
NetBIOS Session Service
SMB (Server Message Block Protocol)
No.     Time           Source                Destination           Protocol Length Info
7 44.117519000   <IP_ADDRESS>        <IP_ADDRESS>        SMB2     240    Negotiate Protocol Response
Frame 7: 240 bytes on wire (1920 bits), 240 bytes captured (1920 bits) on interface 0
Ethernet II, Src: IntelCor_f7:53:65 (00:1c:c0:f7:53:65), Dst: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 445 (445), Dst Port: 34671 (34671), Seq: 1, Ack: 63, Len: 174
NetBIOS Session Service
SMB2 (Server Message Block Protocol version 2)
No.     Time           Source                Destination           Protocol Length Info
8 44.119664000   <IP_ADDRESS>        <IP_ADDRESS>        TCP      66     34671→445 [ACK] Seq=63 Ack=175 Win=15744 Len=0 TSval=704926 TSecr=4539587
Frame 8: 66 bytes on wire (528 bits), 66 bytes captured (528 bits) on interface 0
Ethernet II, Src: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3), Dst: IntelCor_f7:53:65 (00:1c:c0:f7:53:65)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 34671 (34671), Dst Port: 445 (445), Seq: 63, Ack: 175, Len: 0
No.     Time           Source                Destination           Protocol Length Info
9 44.152430000   <IP_ADDRESS>        <IP_ADDRESS>        SMB2     199    Session Setup Request, NTLMSSP_NEGOTIATE
Frame 9: 199 bytes on wire (1592 bits), 199 bytes captured (1592 bits) on interface 0
Ethernet II, Src: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3), Dst: IntelCor_f7:53:65 (00:1c:c0:f7:53:65)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 34671 (34671), Dst Port: 445 (445), Seq: 63, Ack: 175, Len: 133
NetBIOS Session Service
SMB2 (Server Message Block Protocol version 2)
No.     Time           Source                Destination           Protocol Length Info
10 44.152709000   <IP_ADDRESS>        <IP_ADDRESS>        SMB2     300    Session Setup Response, Error: STATUS_MORE_PROCESSING_REQUIRED, NTLMSSP_CHALLENGE
Frame 10: 300 bytes on wire (2400 bits), 300 bytes captured (2400 bits) on interface 0
Ethernet II, Src: IntelCor_f7:53:65 (00:1c:c0:f7:53:65), Dst: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 445 (445), Dst Port: 34671 (34671), Seq: 175, Ack: 196, Len: 234
NetBIOS Session Service
SMB2 (Server Message Block Protocol version 2)
No.     Time           Source                Destination           Protocol Length Info
11 44.194407000   <IP_ADDRESS>        <IP_ADDRESS>        TCP      66     34671→445 [ACK] Seq=196 Ack=409 Win=16768 Len=0 TSval=705001 TSecr=4539590
Frame 11: 66 bytes on wire (528 bits), 66 bytes captured (528 bits) on interface 0
Ethernet II, Src: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3), Dst: IntelCor_f7:53:65 (00:1c:c0:f7:53:65)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 34671 (34671), Dst Port: 445 (445), Seq: 196, Ack: 409, Len: 0
No.     Time           Source                Destination           Protocol Length Info
12 44.228508000   <IP_ADDRESS>        <IP_ADDRESS>        SMB2     400    Session Setup Request, NTLMSSP_AUTH, User: ?\mark
Frame 12: 400 bytes on wire (3200 bits), 400 bytes captured (3200 bits) on interface 0
Ethernet II, Src: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3), Dst: IntelCor_f7:53:65 (00:1c:c0:f7:53:65)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 34671 (34671), Dst Port: 445 (445), Seq: 196, Ack: 409, Len: 334
NetBIOS Session Service
SMB2 (Server Message Block Protocol version 2)
No.     Time           Source                Destination           Protocol Length Info
13 44.228887000   <IP_ADDRESS>        <IP_ADDRESS>        SMB2     143    Session Setup Response, Error: STATUS_INVALID_PARAMETER
Frame 13: 143 bytes on wire (1144 bits), 143 bytes captured (1144 bits) on interface 0
Ethernet II, Src: IntelCor_f7:53:65 (00:1c:c0:f7:53:65), Dst: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 445 (445), Dst Port: 34671 (34671), Seq: 409, Ack: 530, Len: 77
NetBIOS Session Service
SMB2 (Server Message Block Protocol version 2)
No.     Time           Source                Destination           Protocol Length Info
14 44.230843000   <IP_ADDRESS>        <IP_ADDRESS>        TCP      66     34671→445 [ACK] Seq=530 Ack=486 Win=16768 Len=0 TSval=705037 TSecr=4539598
Frame 14: 66 bytes on wire (528 bits), 66 bytes captured (528 bits) on interface 0
Ethernet II, Src: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3), Dst: IntelCor_f7:53:65 (00:1c:c0:f7:53:65)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 34671 (34671), Dst Port: 445 (445), Seq: 530, Ack: 486, Len: 0
No.     Time           Source                Destination           Protocol Length Info
15 89.269838000   <IP_ADDRESS>        <IP_ADDRESS>        TCP      66     [TCP Keep-Alive] 34671→445 [ACK] Seq=529 Ack=486 Win=16768 Len=0 TSval=750080 TSecr=4539598
Frame 15: 66 bytes on wire (528 bits), 66 bytes captured (528 bits) on interface 0
Ethernet II, Src: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3), Dst: IntelCor_f7:53:65 (00:1c:c0:f7:53:65)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 34671 (34671), Dst Port: 445 (445), Seq: 529, Ack: 486, Len: 0
No.     Time           Source                Destination           Protocol Length Info
16 89.269898000   <IP_ADDRESS>        <IP_ADDRESS>        TCP      66     [TCP Keep-Alive ACK] 445→34671 [ACK] Seq=486 Ack=530 Win=66048 Len=0 TSval=4544102 TSecr=705037
Frame 16: 66 bytes on wire (528 bits), 66 bytes captured (528 bits) on interface 0
Ethernet II, Src: IntelCor_f7:53:65 (00:1c:c0:f7:53:65), Dst: HonHaiPr_a1:9e:e3 (14:2d:27:a1:9e:e3)
Internet Protocol Version 4, Src: <IP_ADDRESS> (<IP_ADDRESS>), Dst: <IP_ADDRESS> (<IP_ADDRESS>)
Transmission Control Protocol, Src Port: 445 (445), Dst Port: 34671 (34671), Seq: 486, Ack: 530, Len: 0

@cottonwool You can change the debug log level by clicking the gear icon. I would like you to collect the detail error log and put them here.

I can't find where to set the debug log level.
I've looked under the gear icon of the app.
I've looked under the gear icon of the debug console.
I am not running chromeos in developer mode, does that make a difference?
I've googled for how to do this but nothing useful came up.
Help?

@cottonwool I have just released a new version 2.0.3 including the settings I mentioned at the previous comment. You should be able to find the gear icon. Could you confirm the debug log once again?

I've got the new version with the settings options but it will be a day or so before I can try them out.

@yoichiro I'm getting the same error (c000000d) using v2.0.3 connecting to a share on a Windows 7 desktop that is part of my active directory domain.  If I change the max protocol version to SMB1, then I can connect but SMB2 always fails with NT_STATUS_INVALID_PARAMETER.
If you can tell me how to collect the log output, I can send them to you.

I could reproduce this issue with my Win7. Well, I intend to fix this issue as a high priority. A new pull request was created #108.

@cottonwool @pmontelo I just released a new version 2.1.1. This version includes a new logic to support connecting to Win7. It would be great if you could do a connection test with the latest version.

@yoichiro I've started by using max protocol version = SMB1/CIFS with Log Level = Trace but no console window open. I tried my usual usage of playing audio files with Audio Player and browsing around the folders of my share at the same time.
This works OK. I've been playing audio for >20 minutes without a hangup. This was a >14 minute track followed by a >6 minute track. Before this version the audio would have stopped playing after around 5 minutes with no console / background window open. Browsing the folders worked OK to with a small delay at one point.
I'll try next with SMB2.

@yoichiro Trying now with SMB2 and Log Level = Trace and no background / console window. The result was that it seemed to be successful then I got a pop-up warning about a task taking longer than expected and the shared folder did NOT appear in the Files window.
I tried again with the same share but with Info log level / no background window and got a message to say it was already mounted.
I tried again with another share and Info log level / no background window and it appeared to succeed but the shared folder did NOT appear in the Files window.
I'm accessing the app both by using the app icon which I have stuck to my shelf, and through the Add New Services option of the Files app.
I've tried mounting both shares again through the app and I'm being told they are already mounted but getting pop-up "An operation is taking longer than expected. Do you want to abort it"

@yoichiro I've rebooted my chromebook and went to try again with SMB2 and the same shares. I did not check the files app but went straight to the SMB app to mount one of the shares. When I clicked MOUNT I got an "Already mounted" message.
I went to the files app and both shares were visible to use. (This is the issue with there being no control over shares reconnecting automatically at startup)
I'm now playing audio across one of the shares and I will let you know how it goes.
I'll have to stop testing after that but I will hopefully try more things later: e.g. does switching between SMB1 and SMB2 cause the problem seen.

In my opinion the original issue (c000000d: NT_STATUS_INVALID_PARAMETER) is fixed.
I closed the shares. Rebooted. Checked the settings were SMB2 and Log Level = Info and no background / console window. I mounted a share and played and audio file. I have got two pop-ups "An operation is taking longer than expected. Do you want to abort it" One from the Audio Player app and one from the general notification area. Then after 3'16" the audio stopped playing. Restarting the audio by selecting another track and I get the same "An operation is taking longer ..." pop-up appearing repeatedly. This should be a new issue.

@yoichiro the SMB2 connection problem seems to be fixed.  It's working fine for me with your new version. Thanks.

OK, I close this issue. Thank you for the reporting.


extensions link does not work

The links to the extensions mentioned in the text does not work.
Now it is https://marketplace.visualstudio.com/items?itemName=MS-vsliveshare.vsliveshare-pack. Is https://marketplace.visualstudio.com/items?itemName=MS-vsliveshare.vsls-vs the correct URL?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6a671ef3-7321-b9b6-2ca5-9378c613a31b
Version Independent ID: 26462292-c010-d177-6ebb-6d63ae82e5f7
Content: Install and sign in to Live Share in Visual Studio Code - Live Share
Content Source: docs/use/install-live-share-visual-studio-code.md
Product: visual-studio-family
Technology: live-share
GitHub Login: @fubaduba
Microsoft Alias: fishah

Thanks for the feedback. We'll get this updated.

@SawaTszm - thanks! We've updated the docs.


Failed to install browsers - Jenkins | PW-Java | Linux

we are observing below issue when executing on a jenkins machine (Linux)
java.lang.RuntimeException: Failed to create driver
Caused by: java.lang.RuntimeException: Failed to install browsers, exit code: 1

Can you run with DEBUG=pw:install and see if the logs give you any hints? It might be that the CI machine doesn't have access to the CDN.

We need more information to act on this report. Please file a new one and link to this issue when you get back to it!


Yatin: Watch situshomebet88

Yatin requests the watch of the watch_keyword situshomebet88. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

situshomebet88 has been seen in 0 true positives, 0 false positives, and 0 NAAs.

situshomebet88 has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ

Approved by cigien in Charcoal HQ


Edit and preview fixes

This fixes these issues:

Bullets (eg "Main facts and figures") are not rendered when the page first loads - only after edit box has been clicked in and out of.
Data source URL boxes - can only edit text, but element closes again when you try to edit the URL.
Data source Publication Frequency radios - once "Other" is selected and focus moves to the "Other" text box then you can't ever click back to any of the radio button values without the elemet closing.
Quality and Methodology URL box doesn't close once opened for editing
Editable URL fields seem to lose the "pretend-link" styling after editing
Some values are displayed in grey and some (eg type of data) are black - why? Need to fix styling.

This PR does seem to address all the issues it claims to.
I think a few of us need to sit down after this goes in and nail down all the remaining bugs with the page, as well as styling inconsistencies (such as the drag/drop rearrange for measures vs the arrow rearrange for dimensions). It feels nice to have the in-page edit and see it as it looks, but I'm concerned that the editable nature of most of the elements isn't very discoverable and I'd love to understand more about how this sort of interactivity tests with users.

@samuelhwilliams agreed.
With the dimensions, the intention was to move towards having these editable within the page (rather than on a separate form), and then for some mechanism to re-order them (as yet undesigned but possibly drag and drop but with a minimise function to make this easier).
We could definitely improve the 'affordance' of being able to edit the fields. It's tested well, but we tested the 'blank slate' version where you get a 'Click to add [field name]' prompt.

@TheDoubleK could you have a quick look at this too?

Changes here look good.  We should probably turn the bulleted list into a checklist on the Trello ticket and tick these ones off.
100% agree with Sam about going through this all together when we can.  And also would be good to confirm this is a reasonable direction of travel.

@TheDoubleK ok, I'll merge these for now, and then we can look at the remaining issues later.

@TheDoubleK already have turned the list into check items and ticked off the ones that @frankieroberto has done here. On the original ticket at least 👍


Height graph tooltip not working on Firefox

When hovering the mouse over the height graph, the detail box is stuck at the start position on Firefox.
I've debugged a little bit and the problem is that Firefox does not have the same implementation than Chrome of the getScreenCTM() function [1].
[1] https://github.com/d3/d3/issues/2810

I can reproduce on Firefox 95, linux.

Somehow it now works, maybe because the graph has a larger height than before.

I can confirm it does! That's really nice because it was really a pity that id didn't work.


Linkify URLs and issues in code comments

Closes #380
This linkifies numbered issues (i.e. #123) and URLs found in code comments. You can take a look at this page to see it in action: https://github.com/contao/core/blob/549738f9a41974d963bd09a3a83ae0f46f887f01/system/modules/core/pages/PageForward.php#L51
In that page there is a URL and there are a few issues linked.
Should work on any page with code, so a PR with inline comments works: https://github.com/sindresorhus/refined-github/pull/346
The files on a PR: https://github.com/sindresorhus/refined-github/pull/346/files
And the code for individual files/commits: https://github.com/sindresorhus/refined-github/commit/2d0c354b66556cd15ac9f1fc5f775a313f026f96#diff-0730bb7c2e8f9ea2438b52e419dd86c9
// @Loilo

This is awesome!!
Another example: https://github.com/avajs/ava/blob/2b9f29133fc8306786615cae90ff0ebea0e3de28/test/runner.js#L191

Seems like it doesn't just linkify in comments, but anywhere. For example: https://github.com/sindresorhus/refined-github/commit/2d0c354b66556cd15ac9f1fc5f775a313f026f96#diff-0730bb7c2e8f9ea2438b52e419dd86c9 I think it makes sense to linkify URLs anywhere, but issues should only be linkified in comments as they can have many false positives.

@paulmolluzzo Can you add it to the feature highlight in the readme?

Could you also support the issue reference format sindresorhus/refined-github#381. It's useful for referencing other repos. See: https://guides.github.com/features/mastering-markdown/

Should the link maybe open in a new window/tab (_blank)?

Could you also support the issue reference format sindresorhus/refined-github#381. It's useful for referencing other repos. See: https://guides.github.com/features/mastering-markdown/

@sindresorhus Do you have an example link with this in it?

I'd vote against the _blank option. I think folks using the extension are advanced enough to have a quick&easy way to open links in new tabs anyway while _blank would just take the option for the same tab away.

Do you have an example link with this in it?

https://github.com/sindresorhus/playground/commit/faf058ff8af7283d29ecb8f3314ac4b3f5c8c2b2

I think I addressed everything. Please take a look. (I used all the URLs in this issue.)
I added the _blank request, but can remove if it's annoying.

Just pushed another small fix

@paulmolluzzo Can you add it to the feature highlight in the readme?

@sindresorhus do you like any of these images for the feature in the README? If not and you have a better one in mind, please share and I'll update the README. For now it links to issue #380

The tests make a good screenshot.

How about this:

Fixed an issue with links getting duplicated.

Awesome work @paulmolluzzo. I've been using it for a day now and already found it useful many times! 🙌🎉

This is a great idea! Thanks @Loilo!


cant add Mapbox to the list in Google sheet

Hi,
very interesting project !
i was wondering how to get all the providers in the list on the options section in the google sheet !
Can you help or there is a bug somewhere ?
Thanks
uriel

Uriel - if you want help, insert the GitHub to your repo and explain exactly what you wish to do. I will ask one of my students to look at it.

Hi Jack,
i was using the demo page and try to look at the way to get Mapbox from the list of providers... without success... i see that Mapbox exist in leaflet.provider plugin, so there is no reason to not get it in the list of the sheet... Thanks if you can explain to me where i am wrong


Download Link Dysfunctional on Readme Page

The download link in readme still points to bitbucket, which give 404 when clicked.

+1 @tzm41  comment

This worked for me: http://bitbucket.org/xerial/sqlite-jdbc/downloads/sqlite-jdbc-<IP_ADDRESS>.jar

thanks @mirrish im about to try this now

Download link on the readme and mentioned in this thread are both broken.  Anybody know of another valid jdbc download?

Yes, please use: https://oss.sonatype.org/content/repositories/releases/org/xerial/sqlite-jdbc/3.16.1/sqlite-jdbc-3.16.1.jar

Download page at bitbucket is back. https://bitbucket.org/xerial/sqlite-jdbc/downloads/
Let me close this ticket.


Add kernel-based matrix cumsum

I added a kernel implementation of cumsum(A::Matrix, dims=2). Since Metal and oneAPI don't yet support cumsum and findall, we are working around the issue for now by copying to the CPU, doing the operations there and then copying back. It looks like the 2D cumsum in the cumtrapz function of KomaMRIBase is the main place where this could be significantly slower than an actual GPU implementation (the other cumsum and findall operations are on 1D arrays), so I wrote a simple kernel equivalent to avoid having to copy to the CPU.

I added some more tests to increase code coverage. Although it is still not reaching the target, a lot of the remaining uncovered lines are for custom GPU logic for the MotionModel structs which is being eliminated in #408 . Once this is done, I think it should reach the goal.


Test CENTRIFUGE with classification filterings and compare centrifuge to Krakne2

Centrifuge uses an indexing scheme based on the Burrows-Wheeler transform (BWT) and the Ferragina-Manzini (FM) index.
Run Centrifuge and Kraken2 for the samples within the clinical case #374764. In the DNA sample, we have confirmed that 9 reads were assigned to HHV7, and these reads were identified as true positives
TO ANSWER:
1: Can we also detect HHV7 using Centrifuge, and how many reads were assigned to it?
2: Which classifier identifies more organisms?
3: Which classifier has more false positives in the assigned reads when validated through blasting?"

Conclusion:
1: Kraken2 and Centrifuge assigned the same 9 reads to HHV7 and one read of HHV4.
2: Centrifuge assigned 98 reads to the Viruses category, while Kraken2 assigned 33 reads to the same category.
3: Centrifuge predicted more Virus species (56) compared to Kraken2 (24). However, Centrifuge showed significantly higher false positives, as indicated by blast.
4: The false positives of Centrifuge can be reduced by considering hitLength and numMatches in the classification. For instance, Alcelaphine herpesvirus 1 was falsely reported by Centrifuge, but the hitLength was only 23 bp, which is far from the reliable standard. I would suggest setting the hitLength between 50 bp to 100 bp to reduce false positives. As for numMatches, we could skip it for now since I am not sure about species sharing the same genomic regions.
5: Centrifuge assigned 9 reads to Human endogenous retrovirus K113, which were not reported by Kraken2. These 9 reads were confirmed by BLAST.
I suggest that we combine the results from both Centrifuge and Kraken2 for future clinical cases.

During ENNGS workshop, it was mentioned that one lab is using 5000 as quality filter.

Since we have not tested this metric, I would suggest to wait to the next version.

Yes, it makes sense. We need to do this validation based on simulated data to improve the performance of the taxprofiler and to meet the requirements of IVDR, perhaps sometime in late autumn or winter, after the major release of taxprofiler for long reads.


ObservableList : sorting 2 Element lists in  ReactionFn = infinite loop

Calling list.sort() within a change listener generally works ok (there are no doubt better solutions than sorting on change, but that's not the point) -- the ObservableList notices that the list hasn't changed after sorting and doesn't emit another change.
But when the list is exactly 2 elements, ObservableList emits the same changeRecord infinitely.
I suspect this might be fixed in  []= (copied below) by checking that oldValue != value as well as _hasListObservers, but that might have further reaching effects in the list_diff code.  The bug might also stem from an optimization within list_diff, but I haven't looked there yet.
@reflectable void operator []=(int index, E value) {
    var oldValue = _list[index];
    if (_hasListObservers) {  // && oldValue != value?
      _recordChange(new ListChangeRecord(this, index, addedCount: 1,
          removed: [oldValue]));
    }
    _list[index] = value;
  }

Here's an example test :
int MAX_LOOPS = 100;
int loopCounter = 0;

Function reSort(list) => (changes) {
      // Uncomment the following line to ensure the test can exit.
      // if (loopCounter > MAX_LOOPS) throw 'MAX LOOPS EXCEEDED';
      print('changes $changes');
      list.sort();
    };

void main() {
  // This one works fine.
  test('Sorting three items', () {
    ObservableList list = toObservable([3, 2, 1]);
    list.listChanges.listen(reSort(list));
    list.sort();
    expect(list, [1, 2, 3]);
  });

  // This one will loop infinitely unless you un-comment the throws line in [resort].
  test('Sorting two items', () {
    ObservableList list = toObservable([3, 1]);
    list.listChanges.listen(reSort(list));
    list.sort();
    expect(list, [1, 3]);
  });
}

Sorry - this should be attached to the Observe package. Am closing and moving


[cfe] Excessive error if enum and another declaration have the same names

enum E {e1;} // CFE: Error: Couldn't find constructor 'E'. Analyzer: Ok

int E = 1; // CFE: Error: 'E' is already declared in this scope. Analyzer: The name 'E' is already defined

Why CFE reports an error on the enum declaration? There is nothing wrong with it. No this issue if to replace an enum by some class declaration (CFE reports an error for the second declaration only if the first declaration is a class).
Dart SDK version: 3.7.0-183.0.dev (dev) (Fri Nov 22 20:03:46 2024 -0800) on "windows_x64"

The actual error reported for the enum here does look spurious, as if the enum declaration can't find itself. That's not useful.
I would want an error at both declarations - they're both declarations with conflicted names and one being declared before the other doesn't change that. We don't know which one is wrong (or if it's both), but we do know that neither is valid because there is another declaration with the same name.
(That said, all the spec requires is "a compile-time error", meaning that we refuse to let the program run. Anything else is usability, not speciification.)


Add support for cloaks

Branched off of #4

Legato on Discord says:

Also one thing that the wiki on cloaks doesnt tell you, but in the ratings page does, is that cloaks could have given 0, +1, +2, +3 Damage or Damage Resistance as well. But it is no where said on the actual cloaks page


add climpred to climate list

Project name: climpred
Project website/repository: https://climpred.readthedocs.io
License: MIT

Checklist for new projects:

[X] The project is open-source and accessible.
[X] Searched the existing entries to make sure this is not a duplicate.
[X] Contains only a single addition (make separate PRs if adding more than one).
[X] Added the link to the bottom of the relevant category.
[X] Add icon from the media/icon/ folder if applicable (like ![Python](media/icon/python.png) ).
[X] Created a new category only if necessary.
[X] Checked spelling and grammar.
[X] Removed trailing whitespace and periods.
[X] Confirm the dash – is not a minus -.
[X] Used title-casing (AP style) for project name.

Thanks @bradyrx!


About how to preprocess Vaihingen dataset labels！

Since the url of Vaihingen dataset  has expired, and the labels of the dataset found on the Internet do not satisfy the current project, I would like to share with you how I deal with the labels.
Here is my code.  Welcome star and follow me!
At present, I only uploaded how to preprocess labels and other places that need to be modified in the project, and I will update it later.

Whether the point-level label images are single-channel or three-channel？