Case sensitivity in documentation files

While setting up the repository locally in order to contribute a fix, I ran across the following issue:
sven@linux-etoq:~/projects/expressjs.com> make
./node_modules/.bin/jade --path 3x/api.jade < 3x/api.jade > 3x/api.html
./node_modules/.bin/jade --path 4x/api.jade < 4x/api.jade > 4x/api.html

/home/sven/projects/expressjs.com/node_modules/jade/lib/runtime.js:202
  throw err;
        ^
Error: 4x/en/api/app.jade:43
    41| section
    42|   h3(id='app.METHOD') app.METHOD(path, [callback...], callback)
  > 43|   include:md ./app-method.md
    44|
    45| section
    46|   h3(id='app.all') app.all(path, [callback...], callback)

ENOENT, no such file or directory '4x/en/api/app-method.md'
    at Object.fs.openSync (fs.js:438:18)
    at Object.fs.readFileSync (fs.js:289:15)
    at Parser.parseInclude (/home/sven/projects/expressjs.com/node_modules/jade/lib/parser.js:567:20)
    at Parser.parseExpr (/home/sven/projects/expressjs.com/node_modules/jade/lib/parser.js:223:21)
    at Parser.block (/home/sven/projects/expressjs.com/node_modules/jade/lib/parser.js:707:25)
    at Parser.tag (/home/sven/projects/expressjs.com/node_modules/jade/lib/parser.js:816:24)
    at Parser.parseTag (/home/sven/projects/expressjs.com/node_modules/jade/lib/parser.js:737:17)
    at Parser.parseExpr (/home/sven/projects/expressjs.com/node_modules/jade/lib/parser.js:211:21)
    at Parser.parse (/home/sven/projects/expressjs.com/node_modules/jade/lib/parser.js:122:25)
    at Parser.parseInclude (/home/sven/projects/expressjs.com/node_modules/jade/lib/parser.js:594:22)
make: *** [4x/api.html] Error 8

While 4x/en/api/app-method.md does not exist, 4x/en/api/app-METHOD.md does. It would seem that case sensitivity is not taken into account by the maintainer of the website - using a Windows system, perhaps?
To make the build system function correctly on all systems, either case sensitivity should be taken into account throughout the build files, or all filenames should be left as lowercase.

Hmm, I was just looking at 2804f0b859c6aa1c0e4ab2ab2fab9e258688cb33 - is this the only commit dealing with this issue, or am I missing something? If I recall correctly, the were a few other potential case-sensitivity issues through the documentation files as well.

Hmm, I was just looking at 2804f0b859c6aa1c0e4ab2ab2fab9e258688cb33 - is this the only commit dealing with this issue, or am I missing something? If I recall correctly, the were a few other potential case-sensitivity issues through the documentation files as well.


Ensure Packer files are validated

Ensure that packer validate is executed on a directory
Ensure that packer validate is restricted to modern HCL2
Packer templates and corresponding file suffixes

Resolves #60

https://github.com/gruntwork-io/pre-commit/releases/tag/v0.1.16


BUG: stats: Fixed the issue #14777

Reference issue

To solve #14777
What does this implement/fix?

Fixed the incorrect result caused by df = np.inf in the issue #14777
Additional information

Hi @zhaog6. Sorry, I wasn't aware you were working on this! If you still wish to contribute, please feel free to review gh-14777.
A comment on your approach here: I am not sure if just returning a result with huge values of df is ideal and will work for every method (e.g. t.stats). Instead, best would be to branch to norm like multivariate_t does. This does introduce a bit of overhead (due to broadcasting and masking) but we already have lots of that in the pdf method of the base class and almost every other distribution. Let's see what others say about this.

Hi @zhaog6. Sorry, I wasn't aware you were working on this! If you still wish to contribute, please feel free to review gh-14781.
A comment on your approach here: I am not sure if just returning a result with huge values of df is ideal and will work for every method (e.g. t.stats). Instead, best would be to branch to norm like multivariate_t does. This does introduce a bit of overhead (due to broadcasting and masking) but we already have lots of that in the pdf method of the base class and almost every other distribution. Let's see what others say about this.

Don't worry, Tirth. I noticed that you has submitted it after I submitted the PR. I glanced briefly your PR and feel that taking normal distribution is direct and correct because t distribution limits to the normal distribution when df approaches
infinity. So I closed this PR.


How to integrate into React app?

From the Readme:

A complete, more complex install, that gives you more flexibility but requires that you use a static site builder with a build system that supports npm packages.

Where can I find more documentation about this installation method?

It's open ended because the CMS can be use with any static site generator, and there are quite a few. If you reach out on Gitter, you can get help for your specific case.


[Feature] Using bitmap index to accelerate the query

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Currently we have introduced bitmap indexes. There are some optimisations that we can do when the user queries only against the bitmap indexed columns.
Suppose we have a table usershop_behavior with a bitmap index on the gender column and a bsi index on the gmv column.
CREATE TABLE usershop_behavior (
    uid BIGINT
    gender STRING,
    gmv BIGINT
) WITH (
    'file-index.bitmap.columns' = 'gender',
    'file-index.bsi.columns' = 'gmv'
);

The bitmap index and bsi index can be used not only for filtering, but also for some simple aggregation like:
SELECT
    gender,
    COUNT(*) AS total,
    SUM(gmv) AS total_gmv,
    AVG(gmv) AS avg_gmv
FROM usershop_behavior
GROUP BY gender

SELECT
    gender,
    COUNT(*) AS total,
    SUM(gmv) AS total_gmv,
    AVG(gmv) AS avg_gmv
FROM usershop_behavior
WHERE gender='M'
GROUP BY gender

BSI index can be useful in topk scenarios
SELECT *
FROM usershop_behavior
ORDER BY gmv DESC
LIMIT 10;

SELECT *
FROM usershop_behavior
WHERE gender='M'
ORDER BY gmv DESC
LIMIT 10;

Solution
Apache Flink and Apache Spark are already provides some interfaces. e.g.
Apache Flink:
org.apache.flink.table.connector.source.abilities.SupportsAggregatePushDown
Apache Spark:
org.apache.spark.sql.connector.read.SupportsPushDownTopN
org.apache.spark.sql.connector.read.SupportsPushDownAggregates
When queries hit the bitmap index rules, we can rewrite TableScan to BitmapIndexScan.
Anything else?
Currently our index is designed to be used only for Data Skipping and it is not as reliable as filtering using partitioned keys. (We can't tell the flink&spark engine that filtering with indexes is reliable.)
This is because creating the index is split into several steps.

stop the ingesting task
using alter table to add index options
call rewrite index procedure
restart the ingesting task

We need to find a way to make indexes reliable, like partition keys. (e.g. throw exception when index is empty?)
Otherwise it's hard for our index to do its job.
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

This is a good idea, about make indexes reliable, maybe we can do it by fallback. For example, if the file does not contain index, we can fallback it to do computation, I mean, do the computation by Paimon.

Sounds a little bit more complicated to implement, but it is a very good idea.
If file-index.read.enabled is true and the index satisfies the predicate, push it down directly. If the index is empty on execution,  codegen the filter and aggregate operators and use them in the paimon source.


Add source code locations to AST to improve error reporting

To fix issue https://github.com/anton-trunov/modal-type-theory/issues/1.

This change is

Is there anything that blocks you from finishing this PR? We are quite close, imho.

There is a merge conflict in PrettyPrinter.ml that needs to be resolved.


React's strict mode causes the canvas to be created twice

Related to https://github.com/P5-wrapper/react/issues/162.
I know that I can turn the strict mode off, but I'd rather fix the problem in p5-wrapper itself.
For reference: https://react.dev/reference/react/StrictMode. It causes all render methods to be called twice when dev mode is enabled.
It would seem that p5-wrapper doesn't use React's cleanup functionality properly -- it's supposed to remove the canvas when the component is unmounted.
Note that I can only reproduce this behavior in Chrome. I can provide a repro if this would help.

Interesting...
We added cleanup effect handlers a while ago as you can see in the ReactP5WrapperWithSketch component.
I'm not sure why this is happening with the strict mode implementation. My only idea at the moment is that there's some effect race issue where the cleanup is done before the ref update. If that's the case then that's a React bug actually. I'm not entirely convinced that is the issue though.
Feel free to create a PR if you already have an idea of what it could be or if you want to take on a challenge? I'm always happy with support from the community. If you aren't able to contribute a PR then I'll take a look myself in the next few days 😁.

I am currently in the process of rewriting my code and honestly I might just be using refs/handles very wrongly. I’ll close this issue unless I have a clear repro.

Actually no, I gave up on refs entirely and the issue persists. I'll provide a repro.

Turns out that extensions are to blame.. although it's still unclear why it might be happening. And it can't be reproduced reliably.
When I enable a bunch of extensions at once, and especially if I also open devtools, I get two canvases perhaps 5 out of 10 times. If I enable a few extensions and don't open devtools — 1/10 times. I couldn't isolate a single extension that would be the culprit, though.


spaghetti api docs rendering incorrectly

The spaghetti api docs rendering incorrectly. Unlike giddy api docs that render left-justified, the spaghetti api docs are centered. After reviewing the files in the doc directory, I could not find any obvious differences with giddy's.

@weikang9009, when you have a chance can you take a look at this?

@sjsrey

I thought this might have sth to do with different python versions we were relying on to build the docs (giddy was using python 3.7 and spaghetti was using python 3.6). So I tried on changing python 3.6 to 3.6 for readthedocs building. But the tables of spaghetti docs were still center-aligned.
Then I realized that spaghetti installed dependencies from conda-forge while giddy is relying on pip. There could be a version difference in sphinx-bootstrap-theme. It turns out that the most updated version on pypi is 0.7.1 while it is 0.6.4 on conda-forge. The 0.7.1 version on conda-forge has a pr but never got merged.

In PR https://github.com/pysal/spaghetti/pull/286 I changed the style of the css file for a temporary fix. It renders fine on my fork https://spaghetti-wei.readthedocs.io/en/latest/api.html

resolved by #286

When building the meta docs I'm getting some incomplete links now:

@renanxcortes  and @weikang9009  added here as we have the same issue in building the segregation docs.
It would be great to figure out the solution one time and then post it in the submodule template, or somewhere central, where other maintainers can look.

I think it is because those functions are not properly specified. For instance, there is no spaghetti.NetworkF, but we should use spaghetti.Network.NetworkF instead.
I wonder why the spaghetti api for the meta package is different from the one on the  spaghetti docs website?

Did spaghetti change since the last meta release, because the meta api docs used to work:
https://pysal.readthedocs.io/en/latest/api.html

Fixed now.

@sjsrey What was the actual issue? Was it because the meta included spaghetti v1.1.0 but the current spaghetti version is 1.3?

Yes, that is essentially it.
Meta 2.0 was using v1.1.0 https://pysal.readthedocs.io/en/latest/api.html
while the planned 2.1 will use v1.3 https://pysal-spaghetti.readthedocs.io/en/latest/api.html
Will have to develop a method to catch these kinds of changes in the api.rst files from each subpackage between versions when doing  a new meta release.

Shall I add this point to the July meeting agenda?

Sure, that'd be helpful.


Fix path handling

Herringbone currently doesn't handle paths with schemes other than fs.defaultFS - in particular, s3 urls. This patch changes the code to use Path.getFileSystem(conf), which is scheme-aware.
r? @DanielleSucher

Looks good! Have you tested it?

Yup! With super-secret internal things.


ForEach support multiple types

func(T)
func(*T)
func(index int, T)
func(index int, *T)

can't implement in go, no generic methods.

Add ForEachMutable


DHT sensor occasionally returns wrong values

Temperatures under 0ºC and Humidity above 100%

This issue is fixed with this Pull Request https://github.com/bicconess-swteam/dht22-logger/pull/2


Some Puppeteer commands not available in existing installations despite being documented

Note: This issue is being raised through Claude Desktop at the request of a user who encountered this situation.
There appears to be a version mismatch issue between existing and new installations of the Puppeteer server when used with Claude Desktop.
Setup

Claude Desktop with the following configuration:

{
  "mcpServers": {
    "puppeteer": {
      "command": "npx",
      "args": ["-y", "@modelcontextprotocol/server-puppeteer"]
    }
  }
}

Node.js v23.3.0
The server installs and runs without errors (minor CommonJS/ES Module warning only)

Issue
In an existing installation with the above configuration, only the following commands are available:

puppeteer_navigate (✓)
puppeteer_screenshot (✓)
puppeteer_click (✓)
puppeteer_fill (✓)
puppeteer_evaluate (✓)

However, the README documents additional commands that should be available:

puppeteer_hover (✗)
puppeteer_select (✗)

Important context: These commands are reportedly available in fresh installations of the server, suggesting this might be related to caching or version management of existing installations.
Questions

Is there a way for existing users to upgrade their installation to access the new commands?
Should there be documentation about clearing npx cache or forcing a fresh install?
Would it be helpful to add version information to the README to help users understand when features were added?

Suggested Solution
Could we add upgrade instructions to the README for users who set up the server before these commands were added? This might include steps like:

Clearing npx cache
Forcing a fresh install
Specific version requirements

Additional Context

The server appears to install correctly when run manually via npx -y @modelcontextprotocol/server-puppeteer
New installations reportedly have access to all documented commands
This suggests the issue might be related to caching or version management rather than a limitation of Claude Desktop itself

How did you notice these tools were missing? Do they show up when you connect to the Puppeteer server in the inspector?

These commands are not available in the Claude Desktop interface. Also Claude Desktop shows older version of all servers, as compared to github versions. Aren't the installed servers updating automatically? Any guidance on how to update?

It seems likely you have an old version of the Puppeteer server. They do not update automatically—you'll probably need to run npx --force -y @modelcontextprotocol/server-puppeteer to make sure you always pick up the latest.
The UI is a bit confusing, sorry; it shows the server version as reported in code, which may be different than the npm package.


Draggable MessageBox

This is not a bug, this is a feature request.
OpenUI5 version: 1.93
Steps to reproduce the problem:

Open any MessageBox.

What is the expected result?
Being able to drag the MessageBox on the screen to see the content behind it.
What happens instead?
The MessageBox cannot be moved.
Any other information? (attach screenshot if possible)
Using the UI5 Inspector Chrome extension, to change the draggable property, the MessageBox can be moved around the screen without any problems.

Hi @MauroLuque,
sap.m.MessageBox and sap.m.Dialog are different in this case. sap.m.MessageBox internally creates the sap.m.Dialog which is not configurable. The idea of the class is to provide easier way for usage of sap.m.Dialog with some specific sap.m.DialogType.Message.
To use the full API of sap.m.Dialog you can use it instead of sap.m.MessageBox.
Regards,
Nayden


CHORE: add fluff to help new user get context on docs

What I did

Used my own experience with rocket to extrapolate where new users would be missing context
Added fluff to help user gain that context, and avoid confusion

thaaankkk you 🙇♂


Scripting: access to command line arguments

the docs say that a hello world script is desugared to:
object hello {
  val message = "Hello from Scala script"
  println(message)

  def main(args: Array[String]): Unit = ()
}

this leaves me unable to reference args
I don't see any information about this on the doc page I linked above
(context: I was hoping I could replace the combination of https://github.com/scala/community-build/blob/2.13.x/advance and https://github.com/scala/community-build/blob/2.13.x/scripts/Advance.scala with a single .sc file, but this is blocking me)

Not sure about .sc files, but it works with main methods like:
➜ cat A.scala
@main def f(s: String) = println(s"Hello $s")
➜ scala-cli A.scala -- World
Hello World

and I'm not able to use .scala + @main, because then dependencies don't work
I have:
#!/usr/bin/env scala-cli --scala-version 3.1.0-RC2

import $dep.`org.scala-lang.modules:scala-parallel-collections_3:1.0.3`
import scala.collection.parallel.CollectionConverters._  // for .par

but I get:
[error] ./advance.scala:9:8: value parallel is not a member of collection
[error]        ^^^^^^^^^^^^^^^^^^^^^^^^^^
[error] ./advance.scala:30:12: Stable identifier required, but <error value parallel is not a member of collection>#CollectionConverters.scala.
[error]   sys
[error] .process.None found
[error]            ^^^^^
Error compiling project (Scala 3.1.0-RC2, JVM)
Compilation failed

@tpasternak I'm having trouble combining this with also passing flags to scala-cli
for example, suppose I want to pass --scala-version 3.1.0
I tried:
#!/usr/bin/env scala-cli --scala-version 3.1.0

println(args.size)
println(args.headOption)

and it aaaaaaalmost works right. I can do:
% ./foo.sc
0
None

and I can do:
% ./foo.sc -- a b c
3
Some(a)

but note that I had to supply the extra -- to make it work. If don't supply that, the result is:
% ./foo.sc a b c
a: not found
b: not found
c: not found

happy to open a new ticket on this if you'd prefer.

Thank you @SethTisue , you're right, I'm reopening the issue

I haven't thought about this deeply, but I'll throw a couple of questions out there anyway:
would it resolve the ambiguity if we required script authors to include -- in their shebang lines, like this?
#!/usr/bin/env scala-cli --scala-version 3.1.0 --

to make it unambiguous that any arguments passed to the script itself would be interpreted as arguments to the script rather than as arguments to scala-cli itself.

because it is quite hard to detect reliably if the application is running from she-bang or using scala-cli directly

would it help to add a top-level command, called shebang or script or something?
#!/usr/bin/env scala-cli script

would it resolve the ambiguity if we required script authors to include -- in their shebang lines, like this?
#!/usr/bin/env scala-cli --scala-version 3.1.0 --

This is not so easy. If you execute ./script.sc arg1 arg2, the result command will be /usr/bin/env scala-cli --scala-version 3.1.0 -- ./script.sc arg1 arg2. This means the ./script.sc will be passed down to the program. Of course we could treat the first argument after the -- specially, but then it would break non-shebang executions. Basically bash and python have it for free, because they accept interpreter arguments before the inputs and program arguments after the inputs. In scala-cli we support multiple inputs (should we?), so we cannot drop -- and take whatever comes after the input file.

would it help to add a top-level command, called shebang or script or something?
#!/usr/bin/env scala-cli script

I did something like this here https://github.com/VirtusLab/scala-cli/pull/410. It's quite dirty, as cheats the caseapp library, but it works

I did something like this here #410

offhand, looks fine to me. it's still fairly early days for this project, so I'll be content with anything that gets me unstuck, and that PR looks like it will.

scala-cli shebang command added in #410
It will be available in the upcoming release

Ok, scala-cli 0.0.9 is out. Your case will work if you use scala-cli shebang. Closing this now, please reopen again if there are any problems still

tried it out but was blocked by #451

yay, this is now working for me for the community build scripts: https://github.com/scala/community-build/pull/1518
👏

Thank you @SethTisue !


Questions on Swin backbone with FPN

Hi! Thank you for releasing such a wonderful work. When you mentioned that the Swin backbone can be easily integrated with FPN (feature pyramid network), did you simply process the multi-level features with normal upsampling, convolution, and skip connection add? Are COCO object detection and ADE20k semantic segmentation experiments done with FPN?

Thanks for your interest in our work!

did you simply process the multi-level features with normal upsampling, convolution, and skip connection add?

Yes, we adopt a standard FPN network.

Are COCO object detection and ADE20k semantic segmentation experiments done with FPN?

Yes. For ADE20K, we use the UPerNet framework and it has a FPN-like component. For COCO object detection, we conduct experiments with different detectors and follow the original architecture designs of these frameworks. Most of them use FPN.
In addition, you can check Swin-Transformer-Object-Detection and Swin-Transoformer-Semantic-Segmentation for our implementation of FPN in downstream tasks.

I see. Thanks for the reply!


heartbeat.system_status not set correctly when calibrating

Bug Report
During calibration, the system_status in the heartbeat mavlink message is not set correctly.
It should be set to MAV_STATE_CALIBRATING (2) according to the MAV_STATE enum, but it's set to 0.

I can help address this after https://github.com/PX4/Firmware/pull/9193 is merged.

We could either add a CALIBRATING arming state, or check for ARMING_STATE_INIT + vehicle_status_flags.condition_calibration_enabled.


Push file to device， limit the file size

I need to prevent users from uploading large files frequently

Scrcpy just execute adb push. Adding constraints (why just the file size?) is not the responsibility of scrcpy.


Add SecureCookies config option for MSAL.js 1.x.x

Library

[x]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>
Description
Just want to check if there's any plan to add "SecureCookies" option as well in MSAL.js 1.x.x (implicit flow)? Look like currently it's only available now for MSAL-browser (MSAL 2.x.x) library.

Source

[x] Customer request

delete


Icon in NavItem

I am fairly new to svelte-us, so I hope I'm not missing something obvious.
I was trying to get NavItem to show an icon from Lucide, but I couldn't. I started looking at the source code of the components, and it seems that the way icons are handled in Buttons is very different from NavItem. This is the Icon part of NavItem:
{#if icon}
	<Icon path={icon} class={cls('mr-3 flex-shrink-0', settingsClasses.icon, classes.icon)} />
{/if}

and this is what I saw in Button:
{:else if icon}
    <span in:slide={{ axis: 'x', duration: 200 }}>
      {#if typeof icon === 'string' || 'icon' in icon}
        <!-- font path/url/etc or font-awesome IconDefinition -->
        <Icon
          data={asIconData(icon)}
          class={cls('pointer-events-none', settingsClasses.icon, classes.icon)}
        />
      {:else}
        <Icon class={cls('pointer-events-none', settingsClasses.icon, classes.icon)} {...icon} />
      {/if}
    </span>
  {/if}

One seem to be using path, and the other one checks for several options, except path.
My question is why we have two different ways to handle something that seems to have the same logic and are very similar? Also, is there a way to simply pass a component as Icon (there are many libraries doing that already, such as Licide, and there's no way to reimplement everything)?
I apologize in advance if I get this totally wrong. As I said, I'm just getting familiar with svelte-ux.

Hey @akiarostami 👋, thanks for checking out Svelte UX.

Icon supports a lot of use cases based on the prop passed

Icon path data: <Icon path="M12,4A4,..." />, typically loaded from an NPM package like @mdi/js and used <Icon path={mdiAccount} />.  This is what I typically recommended (although see data below)
SVG strings: <Icon svg="<svg ... />" />
SVG url: <Icon svgUrl="https://api.iconify.design/mdi:account.svg" /> for hosted SVG icons.  This is useful when you want the user to be able to select a front at runtime (or set in a database) but not load the full icon set (since you won't know what is used and thus can not rely on tree shaking)
slot: <Icon><svg ...></Icon>, useful for <svg> elemnts or web fonts such as Material Symbols

Lastly, there is <Icon data={...} /> which applies some heuristics to determine which of the above to use (except slot).  This is nice because you can support most of the use cases mentioned (path, svg, and svgUrl) with a single prop, and is especially useful when Icon is nested in another component, like Button.
Along with all the above, when using Button you can also support passing all the props to icon as an object, not just the path/data/svg (which is what the {:else} is support...
<Button
  icon={{ data: mdiTrashCan, size: "2rem", style: "color: crimson" }}
  color="danger"
>
  Delete
</Button>

additionally, while we don't at the moment, we could support passing the icon as a slot...
<Button>
  <Icon slot="icon" data={mdiTrashCan} />
  Delete
</Button>

With probably way more context than you were looking for... regarding NavItem, the short answer is

It should be using <Icon data={...} /> instead of <Icon path={...} > internally to support the additional svg and svgUrl, but should also be setup to support
It should support passing all Icon props as an object
It should support passing an icon slot

Button should also be updated to support passing an icon slot... and generally review other <Icon> usage in other components to make sure it has the same support (where applicable)

A few more things :)
You should be able to use icon component libraries via slots, but like mentioned in <Button>, we need to add one.  One reason it wasn't added is just putting the icon before the main content in the default slot is 98% the same as if we did it via a slot prop (ignoring the slide transition when toggling the loading state of a button).
I'm typically not a big fan of using individual icon components per icon (ex. <UserIcon>) but instead prefer using paths (ex. <Icon data={userIcon} /> as the paths can be passed as props to other components and I find them flexible to style (and even combine multiple paths into the same icon).  I have an example of this on the Icon docs.
Another thing worth mentioning with Button is while icon props as an object can be useful...
<Button
  icon={{ data: mdiTrashCan, size: "2rem", style: "color: crimson" }}
  color="danger"
>
  Delete
</Button>

mostly the same can be accomplished with classes props
<Button
  icon={mdiTrashCan}
  classes={{ icon: "text-danger-300 text-lg" }}
  color="danger"
>
  Delete
</Button>

Thank you for the detailed answer, @techniq. Very helpful.


Mesh Gradient

Introduce new shader MeshGradient

Is there any video about the new MeshGradient?

You can watch it in the browser here: https://mikepenz.github.io/HypnoticCanvas/
This one can be easily modified to use different colors

Ahh, sorry. I was checking that web from mobile but it does not load (at least on Safari).

I believe wasm on Safari isn't yet fully functional.


Issue with having oauth server on same domain that runs frontend too

My setup looks like this:

Meanjs server

Oauth Backend Mechanizm

Oauth config Backend
Oauth config frontent

On frontend I use satellizer and it gives me folowing issue:
When I call $auth.authenticate it closes window immediately after loading content. My guess and after testing discovery was that if oauth server is on the same domain as app using satellizer it produces an abnormal behavior. I'm positive of that, because I used the same config to thest and changed just authorization point from domain to ip and it worked perfectly.
The error that is thrown into console after premature dialog closing:
angular.js:13550 TypeError: Cannot read property 'token' of undefined
    at Object.a.setToken (ng-oauthsmartis.min.js:93) // I have sattelizer in minified and concatenated file
    at ng-oauthsmartis.min.js:93
    at processQueue (angular.js:15961)
    at angular.js:15977
    at Scope.$eval (angular.js:17229)
    at Scope.$digest (angular.js:17045)
    at Scope.$apply (angular.js:17337)
    at tick (angular.js:12357)

Thanks for your time looking into it, and before you ask why the hell do I have to do it this way, let's just say it's a lot more easier to use existing permission mechanizm than writing new one just for one project.

Bump.

Bump 2.

This issue is fixed in the latest version. Can we get this issue closed.

Hey thanks for fix, it works perfectly. I really appreciate your work.


Bug if invintory is full and you craft somthing it crashes.

If your invintory is full and you go to craft something it crashes, and goes back to the latest auto save. with your invintory at the last auto save. everything you build in that time still there.

#218


Missing Azure Diagnostics configurations

Identified in steps 4, 6, and 7 of the deployment

@ibersanoMS added aks diag setting.


Visual Studio: Please provide a SonarQube plugin for TypeScript

The Visual Studio tools team have developed a  SonarQube plugin for C#.
This is a request to integrate TypeScript as a supported language.
There has been an attempt on this already, but in the authors own words the plugin is 'not even alpha-level yet '.
This would be a way to integrate TSLint into Visual Studio, so that warnings are available on build.
Furthermore, SonarQube offers additional features, such as incremental technical debt analysis (i.e. "only warn when the code I write has errors - not for the whole solution"). This kind of analysis is useful for incrementally converting a solution.

This would out of the scope for the TypeScript project. We would love to help as much as possible. for instance, if there are specific API's needed in the services layer we would be open to adding them. but i do not think the core team can take on such plugin.

Okay, understood. I've created a user voice item for this. Hopefully it will get picked up by the VS tools team.

Is there any update on this. Any plugin for type script which works with SonarQube?
Atul


Update versions and cleanup

k8s 1.9
using go 1.10 (rc1 - will be moved once the final release is out)
checked in the certs ( istio-ca does the same )
small cleanups and optimizations.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
fbfe8468c3dc17f15b7b89f00a9679c0052fa5f4
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a37dc9f7ed19d4c4e0fb8b7f899e3eb442fcaa38
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
a37dc9f7ed19d4c4e0fb8b7f899e3eb442fcaa38
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
2690bf43a8f14afc2a38e1e5b26f0f7d629847c4
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
2690bf43a8f14afc2a38e1e5b26f0f7d629847c4
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
2690bf43a8f14afc2a38e1e5b26f0f7d629847c4
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
2690bf43a8f14afc2a38e1e5b26f0f7d629847c4
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
2690bf43a8f14afc2a38e1e5b26f0f7d629847c4
link
/test istio-pilot-e2e

prow/istio-presubmit.sh
3b62d6a3a8d09d1265a8551e49f85d886ea1e16f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
2690bf43a8f14afc2a38e1e5b26f0f7d629847c4
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
2690bf43a8f14afc2a38e1e5b26f0f7d629847c4
link
/test istio-pilot-e2e

prow/istio-presubmit.sh
60ae0cee10059ba70340639c346fc369884baab5
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

For reference: after the change the e2e-simple runs in 4:20 min (down from 14), and e2e-pilot in 12 (from 21).

Does helm 2.7.2 support 'helm template' ? That's what we need to get rid of
the 'sed' and updateVersions and get the helm in sync with
the 'official' (tested) yaml.
On Mon, Feb 5, 2018 at 11:43 AM, Steven Dake<EMAIL_ADDRESS>wrote:

@sdake commented on this pull request.
In .circleci/Dockerfile
https://github.com/istio/istio/pull/3151#discussion_r166090140:

@@ -14,6 +14,7 @@ FROM    circleci/golang:1.10rc1
ARG     K8S_VER=v1.9.2
ARG     ETCD_VER=v3.2.15
ARG     MINIKUBE_VER=v0.25.0
+ARG     HELM_VER=v2.8.0

Not sure if it matters, however, we specify Helm 2.7.2 throughout the
documentation as a minimum pin. I personally think until 1.0 latest stable
releases are the easiest path, but have read on the ML that 3 y-stream
releases are under support until 1.y.z.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/3151#pullrequestreview-94117220, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6o88YwOQTiuDPp5XNfJfZYNS2_CMks5tR1nJgaJpZM4R4Wum
.

linters not happy:
pilot/test/integration/infra.go:1::error: file is not gofmted with -s (gofmt)
pilot/test/integration/infra.go:190::error: declaration of "err" shadows declaration at pilot/test/integration/infra.go:153 (vetshadow)
pilot/test/integration/infra.go:186::error: declaration of "err" shadows declaration at pilot/test/integration/infra.go:153 (vetshadow)
pilot/test/integration/infra.go:178::error: declaration of "err" shadows declaration at pilot/test/integration/infra.go:153 (vetshadow)
pilot/test/integration/infra.go:172::error: declaration of "err" shadows declaration at pilot/test/integration/infra.go:153 (vetshadow)
pilot/test/integration/infra.go:161::error: declaration of "err" shadows declaration at pilot/test/integration/infra.go:153 (vetshadow)
pilot/test/integration/infra.go:1::error: file is not goimported (goimports)

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2690bf43a8f14afc2a38e1e5b26f0f7d629847c4
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
6e9236e5225efa21edfdc1d9cd16e3ac9dd67b22
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
6e9236e5225efa21edfdc1d9cd16e3ac9dd67b22
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
6e9236e5225efa21edfdc1d9cd16e3ac9dd67b22
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
6e9236e5225efa21edfdc1d9cd16e3ac9dd67b22
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-smoke
/test istio-pilot-e2e

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Failure in tests caused by #3221 that is fixed now, please retest.

/retest

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

the first prow error is https://github.com/istio/istio/issues/3243 is a new compile/vendor issue

/retest

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
4dca3d5c309ceb7c96d28452169c205fa55aee17
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
16eb779194ff40d0b075d0f818999ab36b469c0e
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
16eb779194ff40d0b075d0f818999ab36b469c0e
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
16eb779194ff40d0b075d0f818999ab36b469c0e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Update: falling back to Go 1.9, until this Opa adapter error is resolved (cc @istio/reviewers-istio-mixer folks).

@costinm yes helm 2.7.2 supports helm template.  I am pretty sure its a plugin however.  I am hopeful we can converge on one implementation via helm template in the short term and istioctl updates medium term.
I'll find out the details for sure and add to the relevant issues.

I'm ok with 2.7.2 for now - need to test how templates work with it.
IMHO it is best to use the latest released version of any dependency as default, but add
tests ( nightly maybe) with oldest supported version as well.
Istioctl is in fact using helm code, and AFAIK it is linking v2.8.0 (based on the lock file).
The main problem with using istioctl is that it lacks values.xml merging (and/or --set).
If someone had the time to cut&paste/reuse it from helm - istioctl should be identical
with 'helm template'.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
16eb779194ff40d0b075d0f818999ab36b469c0e
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
008cf3758c32fc341de574bc90e8babc909d8258
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Merging since prow errors are not related to makefile (one is missing deps, while other is failing just like other tests). WE need this PR to cut down the cirlceci testing time from 23m to 15m.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
008cf3758c32fc341de574bc90e8babc909d8258
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
008cf3758c32fc341de574bc90e8babc909d8258
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Prow shows clearly that the tests started failing consistently after #3151.
https://prow.istio.io/?type=postsubmit&job=e2e-suite-rbac-auth
Do we know of any other reason that caused the failures? If not, I will revert this PR.

This PR needs to be reverted, istio-ca fails to work starting from this PR, i did some binary search and it's confirmed.


miniscript: init at unstable-2020-11-04

Closes #102808 (I've updated this PR and fixed SS2K's comments)
Co-authored-by: William Casarin<EMAIL_ADDRESS>

Result of nixpkgs-review pr 121451 run on x86_64-linux 1

1 package built:

miniscript


Traffic fatalities and injuries

This pull request has logic to get average total injuries, pedestrian injuries, motorist injuries, cyclist injuries, and total fatalities over two 5-year periods.
The ingestion of the datasets will ultimately be done through data library, that is a separate pull request.
Some code from the transit access to clean the source data was re-used and put in utils/assign_PUMA.py. That pull request has some issues with it's output that I need to address. One is whether PUMAs are supposed to have leading zero's. This output does include the leading zero. I plan to wait until this is merged in and then use the code in this utils/assign_PUMA.py to clean the transit datasets.
Output makes sense, denser PUMAs have more injuries and fatalities. This data excludes highways and parkways which explains low numbers in outer boroughs where I assume a larger % of miles traveled by car are on highways and parkways

Yea we can talk about it, it was changed to keep leading zero

Here is my feedback so far, but open to input:

[ ] Given that the goal is to have all QOL indicators in one file (unless you came across a reason why this is not feasible) the 2 files per geography will need to be merged together, and the year (i.e. 1014 or 1620) will need to be added to the field name (I'll update the wiki to include this guideline)
[ ] _total is not necessary in the field name and can be removed.

I'll finish my review after the noon meeting.

Awesome, thanks for these comments Amanda. That makes sense on the years, didn't think about how it would work combining with the other indicators. I'll make those changes and write to one file with years in the column names.
I'll also take out the "total" in the column names

Hey Amanda thanks for that feedback, I made those changes. Realizing now that year should go between "safety_" and "traffic_injuries", will implement this now

Ok tried to go from bigger category to smaller. Column labels now are safety -> year range -> indicator -> indicator sub-group (if applicable).
So for example pedestrian injuries 2010-2014 are safety_1014_trafficinjuries_ped. Fatalities have no sub-group so the 2010-2014 column is just safety_1014_trafficfatalities

My instinct is to keep per100stmi in the data dictionary. Another QOL indicator I was working on today was pedestrian hospitalizations which is per 100k residents which is also wordy to put in the column headers?


Rename check-abi.sh to check-api.sh

That is actually what we use it for, and with the changes in #2901 checking the ABI will no be happening.

@devjgm I was going to close this bug, but then noticed that the GCB build has abi in the name.

I used abi because that's what the tools were called.... I thought about this when writing the new script, but I don't know why I landed on the b. Thinking back now, I'm back to thinking p makes more sense.

I remember now my thinking.
This build all starts with a tool named abi-dumper. It outputs the abi of some library into a dump file that we unsurprisingly name with "abi" in the name. Basically we're we're using an abi tool(s) as a way to roughly detect api changes. All this is to say, that a straight s/abi/api/g felt a little misleading. And so calling the build check-api may still include some abi references, and so may be slightly confusing.
Overall, I'd be happy to keep the abi naming we have now. Alternatively, renaming to api is also easy (and indeed, I already did it: https://github.com/googleapis/google-cloud-cpp/compare/master...devjgm:gcb-rename-check-api?expand=1), so if someone prefers that I'm happy to send the PR to change the name.
Preference?

I can live with ABI or API for these.  If we decide to go with ABI let's close this bug.
I would note that our intent is to check for API compatibility, not ABI.  We use a tool that checks both, but we use the -src option:
https://github.com/googleapis/google-cloud-cpp/blob/master/ci/cloudbuild/builds/check-abi.sh#L81
Which means "show source compatibility problems only" (emphasis mine):
https://manpages.debian.org/unstable/abi-compliance-checker/abi-compliance-checker.1.en.html
So effectively we are checking something closer to API compat than ABI compat.
:shrug: your call.

ok. Let's rename it. Little reason not to. Sent https://github.com/googleapis/google-cloud-cpp/pull/6422


[WIP] Magnetic space group support

This includes a lot of breaking changes

Codecov Report
Attention: Patch coverage is 93.46405% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.29%. Comparing base (dea96f4) to head (26e45cf).

Files with missing lines
Patch %
Lines

moyo/src/base/operation.rs
77.27%
5 Missing :warning:

moyopy/src/base.rs
0.00%
4 Missing :warning:

moyo/src/lib.rs
83.33%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   89.42%   89.29%   -0.13%
==========================================
  Files          32       32
  Lines        4510     4494      -16
==========================================
- Hits         4033     4013      -20
- Misses        477      481       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add Sunaba lang

Sunaba language is a introductory language to beginners.
https://github.com/hirasho/Sunaba is the repo of the language.
This language has no special file suffix as it ends with ".txt". As suggested in https://github.com/github/linguist/issues/4502#issuecomment-485061383, adding heuristics is a good option.
Some ruby-compatible regex tests:

https://rubular.com/r/TQA0MGPnAnxZk0
https://rubular.com/r/WRnCLQSn3LEeMt

Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?p=1&q=extension%3Atxt+memory+def+->+NOT+nothack&type=Code

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

Sunaba lang  at Github
A book using Sunaba throughout the book
Tetris game written in Sunaba

Sample license(s):

[ ] I have included a syntax highlighting grammar: https://github-lightshow.herokuapp.com/
[x] I have updated the heuristics to distinguish my language from others using the same extension.

Will do soon. Thanks


SleepIQ component with sensor and binary sensor platforms

Description:
Import from  #2949 with smal typo fixes, cleanups and fix unit tests.
I think we can merge that :dolphin:  review by @Teagan42 @pvizeli @robbiet480

Confirmed this still working with the changes, thanks!


Added reference to v2 sample

@jmprieur added reference to v2 sample...please review PR and merge. TFS 659905

LGTM @kjyam98
merged


Add Environment Variables Library

Before this PR

There was no Environment Variables library, which allows for a safe and testable way of using environment variables in Gradle.
After this PR

The EnvironmentVariables library is migrated.
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?

Getting the following errorprone:
error: [JavaxInjectOnAbstractMethod] Abstract and default methods are not injectable with javax.inject.Inject
    @Inject
    ^
    (see https://errorprone.info/bugpattern/JavaxInjectOnAbstractMethod)
  Did you mean to remove this line?

Weird since this does work and also is not flagged internally. Should I add a @Suppress? Or is this accurate since this is a library?

Suppress it, it's not correct for gradle plugins. I need to globally suppress it in baseline at some stage.

:+1:

Released 0.2.0


fixed extraneous URL_SPLIT message in GraphViz views

An extraneous error message was displayed in GraphViz views in case the result from executing a command was an empty string.
I suspect the extraneous error message was used before the implementation of the current error display system and wasn't updated.
So my solution was that, in case a command execution returns an empty string (which means an error occured), check whether there is no associated error message (which means that the error is not known and there is no error file for it), if so, display the extraneous error message that asks the user to send the code to the Umple team, else, display the predefined error message related to the error.
The difference between Windows and other OS seems to be what executeCommand($command) returns. If there is an error, it returns an empty string, but not in Windows, and thus another message is displayed.

This PR does not work properly as it introduces a different problem. With this PR, if one is in 'E' (editable class diagram) mode and has no text, and then generates java, one gets a different wrong message.
I have looked into it and it turns out that you should scrap this PR.  The solution instead is to replace line 1058 of umple_page.js with
    output = code.replace(/<p>[\s\S]*/, "");

The regular expression was incorrect. I have solved this with #1477 so this PR will be deleted

Closing as superceded by #1477


Can't find the discord server : "Guild undefined"

Hi ! I tried your code on my bot but when I launch it, it gives me that :

I don't really know how to solve this problem, maybe you could help.

I found out !


GLB's crashing Godot 4.0 beta 7 if from previous version

Godot version
4.0.beta.7.mono
System information
Endeavour OS Zen Kernel 6.1 Ryzen 5900x Nvidia GTX 1060 6GB (proprietary drivers)
Issue description
Curtain models in my game which were exported as GLTF2's and imported in Godot 3.5 crash the engine. Moving the location of the file so the engine auto-reimports it fixes the issue. This is the error given when the crash happens
ERROR: FATAL: Condition "!exists" is true.
   at: operator[] (./core/templates/hash_map.h:504)

================================================================
handle_crash: Program crashed with signal 4
Engine version: Godot Engine v4.0.beta7.mono.official (0bb1e89fb7046209f64d46ccedc6b42645c96573)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /usr/share/dotnet/shared/Microsoft.NETCore.App/6.0.11/libcoreclr.so(+0x4b37de) [0x7f55734b37de] (??:0)
[2] /usr/lib/libc.so.6(+0x38a00) [0x7f55ad8faa00] (??:0)
[3] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x13d40d6] (??:0)
[4] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x207bc8a] (??:0)
[5] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x1d89d70] (??:0)
[6] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x1d8a489] (??:0)
[7] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x43d19ba] (??:0)
[8] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x14e0f50] (??:0)
[9] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x2d0bfc4] (??:0)
[10] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x2a5be65] (??:0)
[11] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x2aaac3e] (??:0)
[12] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x2aacd51] (??:0)
[13] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x2aad323] (??:0)
[14] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x2acd4d7] (??:0)
[15] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0xe28444] (??:0)
[16] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x4145937] (??:0)
[17] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0x41467b5] (??:0)
[18] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0xe2a3e8] (??:0)
[19] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0xda8302] (??:0)
[20] /usr/lib/libc.so.6(+0x23290) [0x7f55ad8e5290] (??:0)
[21] /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x7f55ad8e534a] (??:0)
[22] /home/zach/Godot Projects/Godot 4/Godot builds/Godot_v4.0-beta7_mono_linux_x86_64/Godot_v4.0-beta7_mono_linux.x86_64() [0xdc9e5e] (??:0)
-- END OF BACKTRACE --

Steps to reproduce
Transfer a project from Godot 3 to 4 containing GLTF 2 models and attempt to open them
Minimal reproduction project
N/A as is subjective and likely wouldn't happen without the conversion and non-re importation bug which happens locally

Please edit the title to clarify that you mean Godot 3. I thought you meant a previous beta version which is a reasonable assumption.

While he meant godot 3, i have a similar problem upgrading from 4.0beta6 to 4.0beta7
The following worked fine in beta6:
		var gltfDocument = new GLTFDocument();
		var gltfState = new GLTFState();
		gltfDocument.AppendFromFile($"Assets/Models/{id}.glb", gltfState);
		model = gltfDocument.GenerateScene(gltfState);

Beta7 however crashes at project runtime. It says the methods "AppendFromFile" and "GenerateScene" do not exist, while my rider tells me they do, and the exact same code works flawless in beta6.

CC @fire @aaronfranke

I am not sure how c# binding work.

It would help debug if we can get a recreation project.

I encountered the same problem, but reimport seems to solve it.

Please edit the title to clarify that you mean Godot 3. I thought you meant a previous beta version which is a reasonable assumption.

My bad, I edited it to make it clearer.

Fixed by #69706.

While he meant godot 3, i have a similar problem upgrading from 4.0beta6 to 4.0beta7 The following worked fine in beta6:
var gltfDocument = new GLTFDocument();
var gltfState = new GLTFState();
gltfDocument.AppendFromFile($"Assets/Models/{id}.glb", gltfState);
model = gltfDocument.GenerateScene(gltfState);

Beta7 however crashes at project runtime. It says the methods "AppendFromFile" and "GenerateScene" do not exist, while my rider tells me they do, and the exact same code works flawless in beta6.
Note: Not using the Editor at all. Its pure runtime Code. Project is an empty Scene with a root Objekt having a single root Script. This initializes all the stuff in code

Is that also fixed by now? Or should i open up a new issue?

Well I can't reproduce your issue in either 4.0 beta 7 or latest master. This script compiles fine:
using Godot;
using System;

public partial class node_3d : Node3D
{
	// Called when the node enters the scene tree for the first time.
	public override void _Ready()
	{
		var gltfDocument = new GLTFDocument();
		var gltfState = new GLTFState();
		gltfDocument.AppendFromFile($"Donut.glb", gltfState);
		gltfDocument.GenerateScene(gltfState);
	}

	// Called every frame. 'delta' is the elapsed time since the previous frame.
	public override void _Process(double delta)
	{
	}
}


Use preferred attr_encrypted mode :per_attribute_iv

Mode :per_attribute_iv_and_salt is deprecated and will be removed in the next major attr_encrypted release.
See https://github.com/attr-encrypted/attr_encrypted/issues/205

Sorry for the long delay on this! I'm not a fan of removing per attribute iv and salt -- removing security in favor of speed seems like the wrong trade-off to me. If needed we can look into the unique key derivations as they suggest in the linked attr-encrypted issue in another PR. Thank you for reporting this deprecation though!


Local mirroring of Composite S2

This PR brings code to mirror locally the GHS-composite-S2 R2020A. In the process, it adds a new utils module with utilities available for all of data_processing. Do not merge yet.

@martinfleis this does not seem to have been built into the website?


The 'ecmaFeatures' config file property is deprecated

The docs suggest
  "ecmaFeatures": {
    "jsx": true
  },

But for me, using eslint 4.19.0, I get the following warning:

[eslint] The 'ecmaFeatures' config file property is deprecated, and has no effect.

I think the solution is to use this instead
  "parserOptions": {
      "ecmaFeatures": {
          "jsx": true,
          "modules": true
      }
  },

Hi @GitTom, thanks for reporting, feel free to make a PR with an update!

The solution by @GitTom fixed this for me too!

I will go ahead and submit a pull request for this in the docs since I don't see one open, and the issue is still present.


MOSS not working?

I've set up everything according to the documentation by getting the user id from the automated email and and it's showing no results when I use moss_usage.py as is with the user id replaced with my own

is anyone else experiencing this issue?

I'm getting the same issue. Did you find a solution?

same here


linear-gradient with variables

@import 'nib'

a
  background-image: linear-gradient(bottom, hsl(0, 0%, 35%), hsl(0, 0%, 45%))

works, but
@import 'nib'

dark-gradient = linear-gradient(bottom, hsl(0, 0%, 35%), hsl(0, 0%, 45%))

doesn't, it fails with
/usr/lib64/node_modules/stylus/bin/stylus:511
              throw err;
                    ^
Error: nib/gradients.styl:108
   104|  */
   105|
   106| linear-gradient(start, stops...)
   107|   error('color stops required') unless length(stops)
 > 108|   prop = current-property[0]
   109|   val = current-property[1]
   110|   stops = normalize-stops(stops)
   111|

cannot perform null[(0)]

    at Null.operate (/usr/lib64/node_modules/stylus/lib/nodes/node.js:189:13)
    at Evaluator.visitBinOp (/usr/lib64/node_modules/stylus/lib/visitor/evaluator.js:388:28)
    at Evaluator.<anonymous> (/usr/lib64/node_modules/stylus/lib/visitor/index.js:28:39)
    at Evaluator.visit (/usr/lib64/node_modules/stylus/lib/visitor/evaluator.js:74:18)
    at Evaluator.<anonymous> (/usr/lib64/node_modules/stylus/lib/visitor/evaluator.js:451:26)
    at Evaluator.<anonymous> (/usr/lib64/node_modules/stylus/lib/visitor/index.js:28:39)
    at Evaluator.visit (/usr/lib64/node_modules/stylus/lib/visitor/evaluator.js:74:18)
    at Evaluator.<anonymous> (/usr/lib64/node_modules/stylus/lib/visitor/evaluator.js:451:26)
    at Evaluator.<anonymous> (/usr/lib64/node_modules/stylus/lib/visitor/index.js:28:39)
    at Evaluator.visit (/usr/lib64/node_modules/stylus/lib/visitor/evaluator.js:74:18)

Why does nib need to use current-property? Can it be avoided?

This is because linear-gradient add properties to the current selector, and thus cannot be referenced by a variable.
Best approach is to define your own function that in turn run linear-gradient with your pre-defined args.
dark-gradient()
  linear-gradient(bottom, hsl(0, 0%, 35%), hsl(0, 0%, 45%))

.foo
  dark-gradient()


Filter by developer

Thank you for creating this archive, brought back many fond memories!
Summary
You can now click on a developer's name to view all games by that same developer.
Changes

[x] From game page, click developer's name to navigate to /search?by=<developer name>
[x] Filter games by this developer

Caveat
Locally I had to change app name and two dependencies in pyproject.toml to run the server on a codespace instance running python 3.10.4:
# pyproject.toml
[tool.poetry]
name = "app"

[tool.poetry.dependencies]
Flask = "^2.1.0"
jinja2 = "^3.0"

Screenshot
Notice the blue "2Dcube" name on top, clicking it leads to the page on the bottom.

Pleasant surprise to see a PR here, and it's a really neat feature—thanks! LGTM and runs fine locally, so in it goes. Will have a stab at updating the site with this later... kinda forgot how to do all that lol.


feat: allow urls with authentication

This should fix https://github.com/ipfs-shipyard/ipfs-webui/issues/836 by allowing to pass custom URLs.
I was not able to try it due to some CORS configuration with Basic Auth I couldn't manage to get working right now. Will try later. @lidel could you take a look at this to see if it looks OK or even try it if you've got time?
License: MIT
Signed-off-by: Henrique Dias<EMAIL_ADDRESS>

Thanks @lidel!

@lidel I moved the checks and conversion of the api address to the js-ipfs-api directory in order to keep the apiAddress as a string all the times which might be easier for editing and submitting through the web ui. In addition, I added two tests.
Thanks for that proxy!!!!!!


feature-wip Update cache when analysis job finished

Proposed changes
Issue Number: noissue
Problem summary

Update cache when analysis job finished
Rename StatisticsStorageInitializer to InernalSchemaInitializer

Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.16 seconds
load time: 442 seconds
storage size:<PHONE_NUMBER>2 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221117125724_clickbench_pr_48004.html


fixing typo in _customize_scene description

_customize_scene is called when _begin_customize_scenes returns true, not when _begin_customize_resources returns true.

LGTM!

Btw: I am probably going to work on a bit more documentation for this class today, as it was a huge pain to wrap my head around ...

I included this fix together with other typo fixes in faaf27f. Thanks for the contribution!


I have the same issue with my iPad running iOS 12.5.7.

          > I have the same issue with my iPad running iOS 12.5.7.

Version 3.2.0 (with "Application" visible in the Settings menu) worked fine, but after installing 3.2.1 the queue and the "now playing" bar disappeared. "Now playing" is visible only in the Expanded Now Playing view.

I read on slimdevices forum that u can fix this issue on iPads simply deleting cache and deleting icon LMS on home board .
Originally posted by @Jerry87878787 in https://github.com/CDrummond/lms-material/issues/661#issuecomment-1472710402

Please do not open new issues for an existing issue!


Not support AOC U3277FWQ

Not support AOC U3277FWQ.
Writes that no supported monitors were found. Although this model supports DDC.

macOS version: 11.1
MonitorControl version: 2.1.0 (721)
Monitor(s): AOC U3277FWQ
Mac model: MacBook Air (M1, 2020)
Monitor Cable(s)/Connection(s): Type-c to DisplayPort

The error is saved to macOS 11.2.

#323


docs(readme): add example of advanced usuage

Codecov Report
Patch and project coverage have no change.

Comparison is base (143d939) 85.01% compared to head (91294a7) 85.01%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   85.01%   85.01%
=======================================
  Files           5        5
  Lines         287      287
=======================================
  Hits          244      244
  Misses         43       43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


More Detail from DragEndEvent?

Is it possible to get more than just the id of the active and over components from the DragEndEvent?
For context I'm trying to use @dnd-kit/sortable to implement drag/drop columns in a table that supports multiple levels of headers (basically grouped headers).
In order to find and update the the proper item in the column I need some way to know the hierarchy/parents of the active item. I can easily pass that to the component, but I cannot easily get it to my event handler.

Not yet, but coming soon, refer to this issue https://github.com/clauderic/dnd-kit/issues/139#issuecomment-814178995


Make sure initTracer passes options to the tracer

Coverage remained the same at 98.563% when pulling b9aaaeb88d657cd5ab4b7a2fcb9ea53806b6942a on fix-init into 2ed55d86dd9a1aa67c10c1725f57d5a4cd79b141 on master.


Add 104 Addresses to existing DOI/DAI (Support Inverted Boolean)

Is your feature request related to a problem? Please describe.
As a 104 Engineer I want to add Address Elements to a existing DOI/DAI which don't have Address Element yet.
Depending on the logic to determine if inverted is needed, 2 Address Elements need to be added one without inverted and one with inverted 'true'.
Describe the solution you'd like
???
Additional information
???

@Sander3003, we need to define when inverted is needed?


[TACHYON-1697] Mark tachyon.underfs.LocalFileSystemCluster a final class

Can one of the admins verify this patch?

okay to test

Jenkins, test this please

ok to test

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8497/
Test PASSed.

LGTM.  Thanks for the improvement!


Restore on another server possible?

Because I'm having issues importing the mbox file generated by this tool into Apple Mail, due to it not understanding a properly formatted mbox it seems, I am wondering if I can create a backup with this tool, then change the server name and have it 'restore' the backup to the server?

Hi @robdejonge
Yes, you certainly can restore to a different server or service.
First, run imap setup and add authentication to the new service.
Next, if the email address you are restoring to is different from the one that was backed up, rename the directory containing the existing backup to match the email address for the new service.
Then run imap restore -a NEW_SERVICE_EMAIL_ACCOUNT

Thanks


Icon for library and beautify-web org?

Here is my quick and easy design based off the JS logo:

Any other designs, 👍 or even an organisation icon would probs be useful

I have wondered about an icon for the site and the org.  This looks nice, but I don't have any bandwidth to do a search to ensure trademark compliance or anything like this.

It is indeed - it's literally just the JS logo combined with a MD wand icon

MD wand icon? Do you have a link to that?

https://fonts.google.com/icons?selected=Material+Icons:auto_fix_high

@ianstormtaylor after your Prettier logo, how would you like to design the logo for Prettier's bigger competitor? 😄

A more Prettier style icon, can experiment with color highlights:


docs(guide/Components): describe your change...

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Document update.
What is the current behavior? (You can also link to an open issue here)
The line in question appears to be missing some context.
What is the new behavior (if this is a feature change)?
Add minor clarification.
Does this PR introduce a breaking change?
N/A
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

The branding guidelines mandate that Angular 2.x+ is called Angular only: http://angularjs.blogspot.de/2017/01/branding-guidelines-for-angular-and.html?m=1
Angular 1.x is AngularJS

Ah, great. Thanks for the context. I'll go ahead and close this out.


Update state-fold use on eth-input-reader

#41

@GCdePaula, if you have some spare time, could you look at this PR?


[WIP] add time component to datepicker

The timepicker will be a toggle to show a list of selectable times for the user to quickly scroll and choose.
I'm just trying to get the timepicker functionality down first, then the UI can be cleaned up. Having an issue passing a selected time onClick currently

cc @jaredsohn

Nice. Once this is in better shape, we should send it upstream! Then someone else will maintain it for us 👍


Input attributes + Typescript

I have an interface:
interface Input {
  type: "input" | "input-email" | "textarea";
  name: KeyTextField;
  label: KeyTextField;
  placeholder: KeyTextField;
  required: boolean
}

I get the following Typescript error for the following attributes

label -> htmlFor
input/textarea -> name
input/textarea -> id
input/textarea -> placeholder

Type 'string | null' is not assignable to type 'string | undefined'.ts(2322)
[index.d.ts(2216, 9): ]()The expected type comes from property 'placeholder' which is declared here on type 'DetailedHTMLProps<InputHTMLAttributes<HTMLInputElement>, HTMLInputElement>'

In order to fix the error, I had to update my Props
interface Input {
  type: "input" | "input-email" | "text-area";
  name: string | undefined;
  label: string | undefined;
  placeholder: string | undefined;
  required: boolean;
}

Is it possible to update the KeyTextField?

Hey there, I had a look at your issue, here's my understanding:
The placeholder attribute expected by DetailedHTMLProps<InputHTMLAttributes<HTMLInputElement>, HTMLInputElement> has to be of type string | undefined.
Meanwhile, Prismic API returns null | "" for an empty Key Text field, string for a filled Key Text field, therefore the KeyTextField type is typed representing that: https://github.com/prismicio/prismic-types/blob/master/src/fields.ts#L725-L732
Typing the placeholder property of the Input interface as string | undefined feels wrong as the API would never yield undefined for a KeyTextField (which is by design, because undefined is not part of the JSON spec (see ECMA-404, Section 5). The API would also yield null in certain cases which wouldn't be handled by your code.
My suggestion is to conditionally apply the placeholder prop, something along those lines:
/* ... */

return (<>
	<Foo placeholder={input.placeholder ?? undefined} />
	// or, if you wan the HTML to append an empty placeholder instead:
	<Foo placeholder={input.placeholder ?? ""} />
</>);

Hey @kb1995, just wanted to reiterate that @lihbr's explanation is accurate.
KeyTextField should remain as string | null because the API result will be one of those values, and never undefined.
React expects undefined rather than null to represent an empty placeholder, which is why you see the error. The only adjustment I would make to @lihbr suggestion is to use || rather than ?? to handle the case of an empty string ("").
<Foo placeholder={input.placeholder || undefined} />

Thanks for the explanation - makes sense now!


How can load gltf model asynchronously and add the loader progress in c++?

Hi
I have a quite big glb model and it took some seconds to load it using gltfio::ResourceLoader::loadResources.
Anybody knows how to load it asynchronously in a thread and add the load callback to get progress of loading in c++?
Please share your experience with it.
Thanks in advance for you help.

ResourceLoader is a bit under-engineered right now, we should add callbacks and threading.  We have this note in its comment block:
 \todo The GPU upload is asynchronous but the load-from-disk and image decode is not.

If loading from disk is what's slow (as opposed to the STB decode), you can do the following:

Call getResourceUris on the asset.
Create the ResourceLoader but do not call loadResources yet.
Do the loading yourself in other threads and call addResourceData along the way.
After the threads join, call loadResources to finalize the resources.

However this won't help with vertex buffer data or with STB decoding, which will still be synchronized.

Sorry I missed that this is a GLB model.  It's likely that the STB image decoder is what's slow.  :-\

After thinking about this -- since the image decoding is likely the slow part, we might be able to add threading for this without any API changes.
If you're able to attach the GLB file to the issue that would help with our optimization efforts.

I tried to add callback of loading progress and tested for glb files.
I could get loading progress percent and had rendered it by calling
renderer->beginFrame(swapChain);  renderer->render(view);  renderer->endFrame();
in the callback.
if it can be helpful, I am happy.

Thanks!  We'll add this in soon.

I'd like a solution that also helps web applications that wish to amortize the decode across frames. Since they are single-threaded, callbacks would not help.  I'm working out a plan right now.


pkg_resources is deprecated

Need to move away from pkg_resources and to importlib
See:
https://setuptools.pypa.io/en/latest/pkg_resources.html
There are a couple places where this is used. I believe:

sky_model.py when loading the 1934 model
test_aocalibrate.py when getting a calibration file
flagging.py when getting the aoflagger lua askap flagging stratedgy.

Fixed in #65


fix horsey on IE 9+

this is a fix for issue #23

Originally I was trying to listen to the onpointerdown event in IE, however it turned out that the actual issue was that we were listening to the focus event on the document element and in IE the target of that event is the document rather than the element which received the focus (like it is in chrome/firefox). The focus event was being used to hide the list if the target was not an item in the list. Obviously in IE the target was never an item in the list so this would not work and you could never select an item with the mouse.
This change listens to the keydown event and if the tab key is pressed then it hides the list. It relies on autoHideOnClick being true to hide the list in the case that some other element is clicked.


net 5 3.0.15-rc1 MQTTnet.Exceptions.MqttCommunicationException: Authentication failed

Describe the bug
when use 3.0.15 MQTTnet.Extensions.ManagedClient in net 5 trigger exception about SSL Handshake failed with OpenSSL error
Which project is your bug related to?

ManagedClient net5 3.0.15-rc1 version

[2021-02-19T06:47:41.0926064Z] [16] [MqttClient] [Error]: Error while connecting with server.
MQTTnet.Exceptions.MqttCommunicationException: Authentication failed, see inner exception.
---> System.Security.Authentication.AuthenticationException: Authentication failed, see inner exception.
---> Interop+OpenSsl+SslException: SSL Handshake failed with OpenSSL error - SSL_ERROR_SSL.
---> Interop+Crypto+OpenSslCryptographicException: error:1409442E:SSL routines:ssl3_read_bytes:tlsv1 alert protocol version
--- End of inner exception stack trace ---
at Interop.OpenSsl.DoSslHandshake(SafeSslHandle context, ReadOnlySpan1 input, Byte[]& sendBuf, Int32& sendCount)    at System.Net.Security.SslStreamPal.HandshakeInternal(SafeFreeCredentials credential, SafeDeleteSslContext& context, ReadOnlySpan1 inputBuffer, Byte[]& outputBuffer, SslAuthenticationOptions sslAuthenticationOptions)
--- End of inner exception stack trace ---
at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
at MQTTnet.Implementations.MqttTcpChannel.ConnectAsync(CancellationToken cancellationToken)
at MQTTnet.Internal.MqttTaskTimeout.WaitAsync(Func`2 action, TimeSpan timeout, CancellationToken cancellationToken)
at MQTTnet.Adapter.MqttChannelAdapter.ConnectAsync(TimeSpan timeout, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at MQTTnet.Adapter.MqttChannelAdapter.WrapAndThrowException(Exception exception)
at MQTTnet.Adapter.MqttChannelAdapter.ConnectAsync(TimeSpan timeout, CancellationToken cancellationToken)
at MQTTnet.Client.MqttClient.ConnectAsync(IMqttClientOptions options, CancellationToken cancellationToken)
[2021-02-19T06:47:41.0953930Z] [16] [MqttClient] [Verbose]: Disconnecting [Timeout=00:00:10]
[2021-02-19T06:47:41.0954807Z] [16] [MqttClient] [Verbose]: Disconnected from adapter.
[2021-02-19T06:47:41.0955233Z] [16] [MqttClient] [Info]: Disconnected.

This problem is not related to this library. The StackTrace shows that this is coming from .net 5.0.

@chkr1011 thank you

@chkr1011 Should we close this issue?

I will close this since the root cause is coming from .net 5.0.


Deirdre/eng 1050 add new encrypted string format to node

Why
We need to handle the new encrypted string format as discussed in the Duplicate Data doc
How
Added new version prefix to the string to match the following format:
ev:[version]:[datatype]:Base64(KeyIV):Base64(ECDHPublicKey):Base64(AESEncryptedData):$
Also introduced tests to cover encrypted string format

This will be deployed if merged, do you know if it is ready to be deployed? Have our other systems started using the new version format yet?

This should be ready to merge now

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Good First Issues]: Add Connection Information to Featbit Eval Server logs

Description
Currently, the logging functions defined in ConnectionHandler.Log.cs class only log the connectionId, and error message if there was one, and in some cases an event.
connectionId is not very helpful in tracking down which client interaction caused the log message.
The logs should include the project id, the environment id, client IP address, and client hostname if availabe.
With this information system admins will be able to find the project, environment, and client associated with a log message
The client IP address can be obtained in 'StreamingMiddleware.cs' by capturing one of the following (see references)
context.Connection.RemoteIpAddress
HttpContext.GetServerVariable("HTTP_X_FORWARDED_FOR");
Request.Headers["CF-CONNECTING-IP"];
The hostname can be retrieved with
Dns.GetHostEntry(<ip address variable>).HostName;
These should be passed to RequestHandler and added to the Connection Object, Connections should not fail or throw exceptions if the client IP, or hostname are not retrieveable, they should instead be empty strings.
The projectId can be obtained using the MongoDbClient with a query similar to the following
var collection = database.GetCollection<BsonDocument>("Environments");

var document = await collection.Find(x => x["_id"].AsGuid == envId).FirstOrDefaultAsync();
BsonValue projectId = null;
if (document != null)
{
    projectId = document["projectId"];
}

The projectId retrieval ideally will be feature gated using an environment variable such as EVAL_LOG_PROJECT_ID with a default of false. this is to avoid adding potential latency to the initial websocket connection while this feature matures.
LoggerMessage Attriubutes and associated Funcitons in ConnectionHandler.Log.cs should be updated to include envId, projectId, clientId, and clientHostname
Refactor function callers to include this information.
#References
https://juldhais.net/how-to-get-client-ip-address-and-location-information-in-asp-net-core-c2bb50e689c3
Scope
Evaluation Server
Screenshot
Setup dev environment
Please read the doc to set up your development environment.
Deadline
We usually give 2 weeks for a feature request, which means you have 2 weeks to implement the feature starting from the
day it is assigned to you. If you have any difficulties, please contact us in Slack.
How to implement

Fork the FeatBit repository.
Create a branch issues-{issues number}
Implement the task based on Description and Scope mentioned above.
Submit your PR

If the feature is UI related, make sure you complete the following tasks before submit your PR:

merge featbit main branch into your working branch
run npm run i18n
commit messages.xlf & messages.zh.xlf file changes (if any)

Contribution points
Each contribution counts a certain number of points, depending on its difficulty. Contributors earn the appropriate
points when the work is merged. Contribution points are used to describe the contributions that contributors have made.
They can also be used to receive rewards for community events. You can view the current community submissions on a
public google sheet.
Points: 4
How to claim to solve the issue
If you want to implement this function, please leave a comment in this issue like:

I'd like to implement this function, please assign this issue to me.

Regarding the retrieval of the projectId, I'm working on another PR related to this. In that PR, I'll store the environment secret in Redis, with the key being featbit:secret:{the-secret-string}, and the value being a list of hash entries.
The code looks like this:
public async Task UpsertSecretAsync(Guid envId, Secret secret)
{
    var key = RedisKeys.Secret(secret.Value);
    var fields = new HashEntry[]
    {
        new("envId", envId.ToString()),
        new("envKey", "the-env-key"),
        new("projectId", "the-projectId"),
        new("projectKey", "the-project-key"),
        new("type", secret.Type)
    };

    await _redis.HashSetAsync(key, fields);
}

Then, on the evaluation server side, I can retrieve all this secret information from Redis for request validation.

If the secret is not found in Redis, the request will be rejected.
If the secret type is inconsistent (for the server-side SDK, the secret type should be "server", and for the client-side SDK, the secret type should be "client"), the request will be rejected.

Since I have all this information, I'll store it in the Connection class. Then we can use connection.Secret.ProjectId to get the project ID. also, maybe it would be better to use envKey and projectKey in the logs as it is easier to read.

+1 to using the keys over the IDs.  It'd be easier to follow when triaging issues using the logs.

I removed the projectId requirements from this issue so we don't duplicate the work that @deleteLater is doing to retrieve project information. It can can bee added as a different issue when the data is available in redis.


Borderless window can be restored if it was maximized when windowed

Only happens on Windows, because of the borderless hack.
Discovered when I was testing https://github.com/ppy/osu/issues/13638
To repro:

Set to windowed
Maximize window
Press F11 to enter borderless
Press Win+↓

Example of restored borderless window:

This is a problem with SDL (or maybe with Windows) as a non-resizable maximized SDL window can be restored by dragging on the title bar, or with Win+↓.
One can test this with visual-tests → Platform → ResizableWindow
We may want to force restore the window before entering borderless mode.

Not sure if this is something we need to be fixing. I don't think this is specific to osu! / osu!framework and can be repro'd in any application which supports borderless display.
If you need another way to test this kind of thing, I have a little utility app which can move/resize/break any application (https://github.com/peppy/pWindowJax) it's useful for testing these kinds of things.


Dynamic follow updates

-Added traffic level detection, now should keep your car further away from lead if you're in a low traffic situation, and vice versa.
-Tuned dynamic follow, fixed broken acceleration calculation. Now brakes a lot sooner and more naturally.
-Increased length of lead velocity tracking to 3 seconds so that we can keep a safe distance with slow lead decelerations
-Changed welcome alert to 5 seconds.
-Moved gas profiles to longcontrol.py to get ready for a dynamic/smooth accel profile.
-Fix gas button
-Increased low-speed accel limits

5 sec welcome alert is life saver lol

It was so annoying I just had to decrease it haha


Scope Requesting Feature

In context of my application I need to access additional APIs of Google.
I add possibility to configure additional scope on platforms.

Hi @rdelrosario and @Pujolsluis,
in this pull request I have problem with retrieving of IdToken on android.
can you give hint.
as i can login and add additional scopes but still IdToken not returned

Hey @RomaRudyak ,
Great contribution!! Yes this feature overlaps with the one requested on issue #2 , @rdelrosario and me will be working this weekend on adding the AuthToken for Android since we have to look into it more, this is because it seems like it's not that straightforward as their iOS SDK.
After we add your PR for the scopes and the AuthToken we will be releasing the first stable version of the plugin to the public, we will keep you posted 💪 .

@Pujolsluis cool, I already reserched things, and few threads point to use web app token one to configure to .RequestIdToken. but It all failed for me :(

Hey @RomaRudyak we just released a version that allows you to get the user token, we added a new optional parameter, for supporting the .requestTokenId method on the builder, send your Google Developer Console Android Client Id to that parameter and it should work.
Test it out and give us your feedback 💪

@Pujolsluis thank you fast release. But still no luck for me to receive AccessToken on Android.
Here is my repo

Hey @RomaRudyak ,
The problem is that you have to send it as the 3rd parameter, since that's the one for the requestTokenId method. it should be like this GoogleClientManager.Initialize(this, null, );

I am using MvvmCross and there is some problem with MvxAppCompatActivity. I will dig in more and try find out what the problem is.
For standart AppCompatActivity all works

@Pujolsluis Found out the problem in my project. Created #12 issue

Goodjob! @RomaRudyak ,
We will review your changes and issues over the weekend 💪


feat(tls): added tls config

Codecov Report

Merging #429 (6d08c2d) into master (389496c) will decrease coverage by 1.06%.
 Consider uploading reports for the commit 7d7f7d3 to get more accurate results

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   60.08%   59.01%   -1.07%
==========================================
  Files          39       41       +2
  Lines        1170     1203      +33
  Branches      133      135       +2
==========================================
+ Hits          703      710       +7
- Misses        404      427      +23
- Partials       63       66       +3

Impacted Files
Coverage Δ

src/app/tls/tls.service.ts
13.63% <13.63%> (ø)

...rofiles/profile-detail/profile-detail.component.ts
77.12% <63.63%> (-1.20%)
:arrow_down:

src/app/tls/tls.component.ts
100.00% <100.00%> (ø)

src/app/shared/add-device/add-device.component.ts
86.36% <0.00%> (-6.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fde5cc...7d7f7d3. Read the comment docs.


Update AppBar MediaQuery documentation

Description
Explain why you should consider wrapping AppBar in a MediaQuery
Related Issues
https://github.com/flutter/flutter/issues/27848
Tests
I added the following tests:
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.

@feinstein I made this section less elaborated (than promised), fearing it could be information overload for most readers. Please let me know if find it ambiguous or not helpful!

Reading it the first thing that crosses my mind is "why would the ambient MediaQuery change?
Maybe the details should be added (and pointed to) at the MediaQuery docs as it will be mostly related to it and you could go deeply there.

So I guess it's alright as the message conveys it's intent.

@googlebot I fixed it.


Support Code Suggestion

This is an umbrella issue to support code suggestion features.
Related: #624, #660
Depends on: #628

Reporters support

[x] -reporter=github-pr-review #675 #698
[ ] -reporter=gitlab-mr-discussion
[ ] -reporter=gerrit-change-review
[ ] -reporter=local?

[x] Unified DIff based suggestion support #660 (Diff -> Reviewdog Diagnostic Format Convertion) #699

[x] Create diff based suggestion github action　https://github.com/reviewdog/action-suggester

Still in beta until next reviewdog release, but here it is! https://github.com/reviewdog/action-suggester
Suggests any code changes based on diff through GitHub Multi-line code suggestions by using reviewdog!

I have been looking for a solution to get lint fix suggestions on Github PR reviews automated(when automatically applying them is not appropriate), finding a Github Action that supports Github Suggested Changes has taken longer than an expected so I'm really happy to find this action-suggester for ReviewDog :)
From the action-suggester README:

You can use any formatters or linters with auto-fix feature for any languages and the reviewdog suggester support any changes including inline change, multi-line changes, insertion, and deletion.

As a new user to ReviewDog, that sounds great but I wasn't able to what that range of support is. It doesn't seem like there are user docs for ReviewDog available, just the project README? Was the supported formatters/linters referring to what is listed here? (that then mentions there is more on the marketplace)
I'm not familiar with Github Actions yet, but I get the impression that they're composable templates/snippets/blocks for CI vs more manual configuration/setup that some other CI services have. It looks like they are ReviewDog specific though, is integration/support of formatters/linters for other Github Actions not filtered for ReviewDog still compatible and just require a bit of boilerplate like the other CI services are shown?

@mattmoor was interested in this for Knative automated reviews

Hi, is there any plan to support checkstyle format?


Floating-Labels only works with "for" and "Input-ID" :-(

https://getbootstrap.com/docs/4.0/examples/floating-labels/
First of all... providing "floating-labels" -> nice done!!!!
But i have a question:
Why is it implemented in that way, that it does only work correctly, if the "ID-attribute" for the input-field is the same as the "FOR-attribute" of the label?
Is there a way to make it work without the need for setting an ID?
I think it would be much simpler to make it work indirectly, having a <input> nested inside of an  like so:

    Email address
        <input class="form-control" placeholder="Email address">

I am currently working on an project where i have many input-fields, multiple forms and i have to do some cloning and so on and it gets really stressful, because i have to think about setting unique IDs for all the fields :..(

please provide a "working" example of it it not working  (jsbin or codepen, etc)

https://codepen.io/anon/pen/KQYppq
Thanks, but that all sounds a bit like a "dirty-hack-solution" - which is what i do not want to do ;)
All i want is a nice and easy solution that i do not have to set any IDs.
Would it be a big problem, if the "floating-labels"-feature gets implemented that it works "automagically" without setting any IDs? So it could check if "input" and "label" is inside of "form-label-group", then "floating-labels"-feature works :-) ?

        <input class="form-control" placeholder="aaa">
        does currently not work, but should work automagically

not sure if you saw my last edit, but
label:not([for]) {
  pointer-events:none;

does the trick

yes, wow, that works!
my first tests are working with your solution!
nice :-)
thanks, an have a nice friday night!


lock consumer for windows

This is not issue of lfqueue.
it often crash on windows because writing stdout is not thread-safe.

Thank you for the commit. Merged.


HAML comment line leaves subsequent line italic

In HAML with Rails, if I comment out a line with -# or / or // the subsequent line in italics and some text greyed out as well.

Atom doesn't ship with HAML support - are you using https://atom.io/packages/language-haml?

Moving over there, thanks :bow:


[Acccess Request] report 5753 "Get Source Documents" - SkipWarehouseRequest

Describe the request
Could you change procedure SkipWarehouseRequest in report 5753 "Get Source Documents" to global?
Additional context
I need to check whether other lines will be included running this report, so I need to check all criterias.Internal work item: AB#493220

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 14454.