Refactor cluster registry to use Secret to store kubeconf

This PR refactors cluster registry to use k8s Secret object to store kubeconf files of member clusters.
apiVersion: v1
kind: ConfigMap
metadata:
  name: clusterregistry
  namespace: istio-system
data:
  kube-3.yaml: |-
    apiVersion: clusterregistry.k8s.io/v1alpha1
    kind: Cluster
    metadata:
      name: "kube-3"
      annotations:
        config.istio.io/pilotEndpoint: "<IP_ADDRESS>:9080"
        config.istio.io/platform: "Kubernetes"
        config.istio.io/pilotCfgStore: True
        config.istio.io/accessConfigSecret: "kube-3.conf"                           !   Name of Secret which stores kube-3 kubeconf config
        config.istio.io/accessConfigSecretNamespace: "istio-system"       !  Namespace where secrets will be stored.

@sbezverk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fe00b97d70ef5b1c7895cceb5aa0cad32d652177
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fe00b97d70ef5b1c7895cceb5aa0cad32d652177
link
/test istio-unit-tests

prow/istio-presubmit.sh
fe00b97d70ef5b1c7895cceb5aa0cad32d652177
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/hold

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
fe00b97d70ef5b1c7895cceb5aa0cad32d652177
link
/test istio-presubmit

prow/istio-unit-tests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

How about: for a cluster kube-3 we expect a secret with the same name ? And don't even bother with the extra annotation. Simpler is better.
Or maybe you can prefix it: istio-kube-3 - if you're worried about conflicts. I don't think the flexibility to use arbitrary names and use annotations is worth the effort.

Oh, and all secrets will be in the same namespace as pilot, not need to bother with cluster roles and other complexities.

@costinm your last comment worries my a lot from secuity perspective, if we keep all secrets with members' kubeconf in the same namespace, then if any process manages to compromise let's say istio-system namespace, will have admin level access to all cluster members, just read secrets and here you go. My thought was, placing them in a different namespace would require cluster wide RBAC permissions to access them, which I think makes a bit more secure, since not every process has list/get secret in a cluster wide manner.

@sbezverk missing changes to https://github.com/istio/istio/blob/master/pilot/pkg/config/clusterregistry/conversion_test.go (likely the reason for the imploding gate).
Cheers
-steve

Istio-CA certificates are in istio-system. We can discuss storing all certs in a different, isolated namespace - but I think istio-CA cert is as critical and should be consistent.
Also: https://kubernetes.io/docs/reference/generated/federation/federation/v1beta1/definitions/ seems to use 'secretRef' - maybe we can use the same thing ?

Also interesting reading:
https://github.com/kelseyhightower/kubernetes-cluster-federation/blob/master/labs/06-adding-clusters.md

@costinm A bit off-topic from this review, however:
During R&D of the multicluster work, the first take from @john-a-joyce and @baodongli was based upon the Kubernetes federated control plane.  That approach was ultimately abandoned because a sufficient number of object types were not replicated.  Especially painful were the CRDs.
There are things to learn from the Kubernetes federated control plane work and as you point out, they have a reasonable security model.
Current multicluster does require some replication:

services - so that dependent services may be discovered by the non-master kubernetes control plane
secrets - so that istio.default may be replicated as it is mandated by envoy (iirc)

Currently this replication is done manually (via scp, or other manual methods).
Documentation and samples are shortly coming as a PR so the design's usability can be improved upon.  This documentation will enable the community to perform a legitimate evaluation.
Suggestions welcome.
Cheers
-steve

Yes, some manual replication is fine. For secrets - things are trickier,
for now having a CA with same
key pair in each cluster seems the only option, once the switch to agent is
complete things will get
better.
I'm not suggesting adopting the entire federation now - just staying
consistent, AFAIK we have our own
local copy. Would be good to get rid of some custom annotations and keep it
simpler.
Note that CoreDNS has similar support for loading from multiple k8s (
https://github.com/coredns/kubernetai),
this is likely to become one of the options for deployment to handle DNS
problems ( besides replicating
the services in each cluster )
On Tue, Mar 20, 2018 at 2:12 PM, Steven Dake<EMAIL_ADDRESS>wrote:

@costinm https://github.com/costinm A bit off-topic from this review,
however:
During R&D of the multicluster work, the first take from @john-a-joyce
https://github.com/john-a-joyce and @baodongli
https://github.com/baodongli was based upon the Kubernetes federated
control plane. That approach was ultimately abandoned because a sufficient
number of object types were not replicated. Especially painful were the
CRDs.
There are things to learn from the Kubernetes federated control plane work
and as you point out, they have a reasonable security model.
Current multicluster does require some replication:

services - so that dependent services may be discovered by the
non-master kubernetes control plane
secrets - so that istio.default may be replicated as it is mandated
by envoy (iirc)

Currently this replication is done manually (via scp, or other manual
methods).
Documentation and samples are shortly coming as a PR so the design's
usability can be improved upon. This documentation will enable the
community to perform a legitimate evaluation.
Suggestions welcome.
Cheers
-steve
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/4370#issuecomment-374758578, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6rwJe5-Y9Hv4-bLo5OOLS18SpbkJks5tgXDXgaJpZM4Sw1eT
.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
Assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test e2e-simple

prow/istio-pilot-e2e.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
9d329efbfc41e44fdd45c2f47ae7421e3a8cc44a
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake I refactored coversions unit tests in order to test new approach with secrets, so I ma not sure how current are the changes you were referring to. I will need to get logs from pilot to understand why it is failing in e2e tests. If you have a setup with istio running, getting those logs for me would be extremely useful.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
2e9b1aa36118705cc0b2ce57ace24d85267fec5a
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
9da2fdcb4006ebc49b77eaffb71c16d389e9a20c
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
2e9b1aa36118705cc0b2ce57ace24d85267fec5a
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
2e9b1aa36118705cc0b2ce57ace24d85267fec5a
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2e9b1aa36118705cc0b2ce57ace24d85267fec5a
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
2e9b1aa36118705cc0b2ce57ace24d85267fec5a
link
/test istio-pilot-e2e-v1alpha3

prow/e2e-simpleTests.sh
cfbcf19ec95cc2687f43995859e8b89bb6196890
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
2e9b1aa36118705cc0b2ce57ace24d85267fec5a
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
cfbcf19ec95cc2687f43995859e8b89bb6196890
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
cfbcf19ec95cc2687f43995859e8b89bb6196890
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
cfbcf19ec95cc2687f43995859e8b89bb6196890
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
cfbcf19ec95cc2687f43995859e8b89bb6196890
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
cfbcf19ec95cc2687f43995859e8b89bb6196890
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
9ce26291f6d7df0b81aab4211d56f6e833470146
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
9ce26291f6d7df0b81aab4211d56f6e833470146
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
9ce26291f6d7df0b81aab4211d56f6e833470146
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
fcac7f40fc9d1d97dcd1d5bbc1ed7448a56477e4
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
fcac7f40fc9d1d97dcd1d5bbc1ed7448a56477e4
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
fcac7f40fc9d1d97dcd1d5bbc1ed7448a56477e4
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS
pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm  I refactored it to not use any persistent storage for kubeconf. PTAL, thanks a lot.

/test e2e-pilot

/test istio-pilot-e2e

/test ci/circleci: e2e-pilot

@sbezverk when submitting changes to your PR, can you do them as separate commits?  This makes understanding what changed between each PR simpler (rather than a force push).  In the end, the PRs are squashed automatically by the infrastructure.  For a complex example examine:
https://github.com/istio/istio/pull/4001

@tiswanso if we take this specific scenario, how do you plan to mount kubeconfigs to pilot?

I think the main idea here is that this PR improves things. I have few concerns as well, but we can address them in separate PRs - including adding back a way to not depend on k8s.
Long term - dynamically reading secrets is a problem we need to handle for SNI, and watching for
config changes to get dynamic updates is needed as well, and probably higher priority.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai
Assign the PR to them by writing /assign @hklai in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbezverk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9d6e128820535a141c443fa06f14f8c094ef97bb
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9d6e128820535a141c443fa06f14f8c094ef97bb
link
/test istio-unit-tests

prow/istio-presubmit.sh
9d6e128820535a141c443fa06f14f8c094ef97bb
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS
pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
9d6e128820535a141c443fa06f14f8c094ef97bb
link
/test istio-presubmit

prow/istio-unit-tests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
Assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @costinm

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
eea4fbec6aed22c5a64a30a9b3f05a11bee8b7ae
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e

prow/istio-presubmit.sh
098474b977391a315841bbaa144331466a528d9b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e

prow/istio-presubmit.sh
098474b977391a315841bbaa144331466a528d9b
link
/test istio-presubmit

prow/istio-unit-tests.sh
098474b977391a315841bbaa144331466a528d9b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Please check the build/lint/etc - and work with tiswanso to address his concerns, I see he has a hold.

@costinm I tried multiple things to resolve circle ci failure, nothing worked.
diff Gopkg.toml vendor/
diff Gopkg.lock vendor/
1207c1207
<     "authentication/v1alpha1",
---
>     "authentication/v1alpha2",
1218c1218
<   revision = "64e9770daf900edc2a50fc4c57793f370cfdaf75"
---
>   revision = "7e10af28c89ef66637dbad64fdd324c652263667"
1516c1516
<   inputs-digest = "0998474db4d29e59a52fff3e808f5aeff315b986099e8738dfe38173c2340d4e"
---
>   inputs-digest = "dbf605074c65c98292cc7931c0fa9a866bc820ffc365a101b824cc93286a0481"
Makefile:283: recipe for target 'vendor.check' failed

These are the errors are they are not my code related. Something is not right with building system.
I tried to rebase on the latest master, remove vendor from my branch, then run make init still get the same error.
Any help here would be awesome.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e

prow/istio-presubmit.sh
098474b977391a315841bbaa144331466a528d9b
link
/test istio-presubmit

prow/istio-unit-tests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
b259cebc14aefd67d303b6fa232f3cc2571534e0
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-unit-tests

prow/e2e-bookInfoTests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test e2e-bookInfo

prow/e2e-simpleTests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test e2e-simple

prow/istio-pilot-e2e-v1alpha3.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
309e05bcb78abf28bf9a66f2e5f2176957e3db9f
link
/test istio-pilot-e2e

prow/istio-unit-tests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test e2e-bookInfo

prow/istio-pilot-e2e-v1alpha3.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
e474d8ad5d106a3bf338c2550a9da5200ad1b0f0
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Closing due to some issues with commit ids and branch. New PR #4652


bug(cdk/testing): ComponentHarness doesn't wait for tasks outside NgZone

Issue is demonstrated here: https://github.com/angular/components/compare/master...mmalerba:repro-zone-issue

PR for this: #17408


Support for KVM dynamic scaling

Support the ability to dynamically scale or change multiple config components in a libvirt configuration.
Initial support for vCPU, Memory, bandwidth limits, IOP min,max and burt limits.
@rhtyd @skattoju4 @ustcweizhou @PaulAngus @rafaelweingartner  @nathanejohnson

@kiwiflyer is that call for a feature request?

@kiwiflyer is that call for a feature request?

@svenvogel we talked about at CCC and did a quick test using virsh to see whats possible. wondering if anyone else in the community has looked at this.. looking for contributions.

Hi @skattoju4, the PR I submitted is work in progress, doing it incrementally while testing possible approaches. Feel free to propose/refactor the approach in the PR

ping @nvazquez @kiwiflyer can you confirm whether this issue is fixed with #4878 or not.


How to export metadata as json?

Hi!
Great project, I would like to check how is it possible to export only metadata to be saved as a .json file next to the data described.
Thank you!

Hi @SterArcher! Thanks for your interest on the ODE. Do you need it as a text file? Can you explain more?


Fix command line message color not to go along with theme.

For example C-g command.

Thank you for your quick merge.
<EMAIL_ADDRESS>
Merged #861 https://github.com/XVimProject/XVim/pull/861.
—
Reply to this email directly or view it on GitHub
https://github.com/XVimProject/XVim/pull/861#event-444732973.


if you have a job name in the needs that does not exist. you get a confusing message and the unspecified jobname is unknown

Will be fixed in 4.9.3, closing


Update link in README.md

Fixes #352
By submitting this pull request I confirm I've read and complied with the below declarations.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the coding guidelines for this project.
[ ] My code follows the skeleton code structure.
[x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[ ] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

You have checked "I have read the Contribution guidelines and I am confident that my PR reflects them." but you haven't followed it.

Make sure you are assigned for the issue.

Since you were not assigned to the issue #352, I can't take this PR.
Sorry about that but we need to do this in order to maintain discipline and quality in the project.

@aviaryan Sorry for that, I shall not make that mistake again

@S2606 Thanks for understanding.


Fix Linptech Submersion Sensor (RS1BB)

have tested it on my device.

This is a ble device, not mesh.
should use water_leak,
moisture was previously used as sensor, representing humidity in percentage.

https://github.com/AlexxIT/XiaomiGateway3/releases/tag/v3.3.4

Hello, i’m already added this sensor to Home Assistant, but status is unknow. could you help me check it ?

Hello, i’m already added this sensor to Home Assistant, but status is unknow. could you help me check it ?

Wait a moment for its heartbeat? or try manually trigger it (change its state)?

Hello, i’m already added this sensor to Home Assistant, but status is unknow. could you help me check it ?

Wait a moment for its heartbeat? or try manually trigger it (change its state)?

I just added and wait its for heartbeat. I will try manually trigger when I come home. thank you

Hello, i’m already added this sensor to Home Assistant, but status is unknow. could you help me check it ?

Wait a moment for its heartbeat? or try manually trigger it (change its state)?

I just added and wait its for heartbeat. I will try manually trigger when I come home. thank you
But when I using Xiaomi Miot Auto as Cloud, its said Dry

Oh, I just remembered, this device's heartbeat does not contain this data, it only periodically reports battery.
When state changed, it will report.
Xiaomi Miot Auto query data from cloud, and the server maintains its status, so.

Oh, I just remembered, this device's heartbeat does not contain this data, it only periodically reports battery.
When state changed, it will report.
Xiaomi Miot Auto query data from cloud, and the server maintains its status, so.

yes, thank for your information, i will manually trigger when i come home and let u know

I'm having issues with this device. It's been paired for about 3-4 days now and is triggered by the shower everyday. Please can you advise

I'm having issues with this device. It's been paired for about 3-4 days now and is triggered by the shower everyday. Please can you advise

It's showing as status "unknown"


WSS Server keep alive issue (IDFGH-6925)

Environment

Development Kit:      [ESP32-DevKitC]
Kit version DevKitC: [v4]
Module or chip used:  ESP32-WROOM-32E
IDF version: v4.4
Build System:  [idf.py]
Compiler version: 8.4.0
Operating System:     [Windows]
(Windows only) environment type: [ESP Command Prompt].
Using an IDE?: [No|Yes (please give details)]
Power Supply:         [USB and external 5V]

Problem Description
I have frankensteined several of the example codes together to get my esp to read a html file from a sd card, be a wifi acces point, start a webserver that provieds the website from the sd card. the website has a button to open a websocket. when using that websocket to constantly send printouts to the website to be displayed everything is happy. when for a certain time nothing is to be send and the keep alive routine kicks in and sends a PING towards the client and the clients sends back the PONG everything starts to fall apart. On the clientside I was able to see via WireShark that PING and PONG where received and send as intended. On the ESP(serverside) I see from the log that keep_alives kicks in after 5 seconds as intended one PING gets send out (4 more try to) but before the received PONG gets handeled the keep alive times out and closes the connection. Only after that the the received PONG seems to be handled with errors that I'm not able to understand. Once the client gets disconnected the remaning 4 PINGs get send out but obviously don't reach the client anymore.
Expected Behavior
I expect a PING to result in a PONG making its way into the aplication so it resetst the timeout for that connection.
Actual Behavior
client sees PING and sends PONG but it does not reach the aplication layer on the server
Debug Logs
I (101116) wss_echo_server: New client connected 59
I (101124) WebSocket: Handshake done, the new connection was opened
I (106117) wss_echo_server: Checking if client (fd=59) is alive
I (106119) Sending WS: PING
I (107119) wss_echo_server: Checking if client (fd=59) is alive
I (108121) wss_echo_server: Checking if client (fd=59) is alive
I (109122) wss_echo_server: Checking if client (fd=59) is alive
I (110123) wss_echo_server: Checking if client (fd=59) is alive
E (111124) wss_keep_alive: Client (fd=59) not alive!
E (111124) wss_echo_server: Client not alive, closing fd 59
W (111128) httpd_txrx: httpd_sock_err: error in recv : 11
W (111131) httpd_ws: httpd_ws_recv_frame: Failed to receive the second byte
E (111139) WebSocket: httpd_ws_recv_frame failed with -1
I (111145) wss_echo_server: Client disconnected 59
I (111152) Sending WS: PING
I (111155) Sending WS: PING
I (111158) Sending WS: PING
I (111161) Sending WS: PING

Other items if possible
sdkconfig.txt

Now that I managed to get Debug Log level running without constantly stackoverflowing. I have this log with a little more insight but I still cant wrap my head around where any wy everything is going south at some point
I (21514) WebSocket: Handshake done, the new connection was opened
D (21518) httpd_sess: httpd_sess_process: httpd_req_delete
I (21519) upm_send_bytes: start frame length bytes are: 8, 8 from 5
D (21525) httpd_sess: httpd_sess_process: success
D (21536) httpd: httpd_server: doing select maxfd+1 = 58
D (26024) wss_keep_alive: Haven't seen the client (fd=57) for a while
I (26024) wss_echo_server: Checking if client (fd=57) is alive
D (26028) httpd: httpd_server: processing ctrl message
D (26032) httpd: httpd_process_ctrl_msg: work
I (26036) Sending WS: PING
D (26041) httpd: httpd_server: doing select maxfd+1 = 58
I (26058) httpd: httpd_process_session: processing socket 57
D (26059) httpd_sess: httpd_sess_process: httpd_req_new
D (26059) httpd_parse: httpd_req_new: New request, has WS? Yes, sd->ws_handler valid? Yes, sd->ws_close? No
D (26069) httpd_txrx: httpd_recv_with_opt: requested length = 1
D (26076) httpd_txrx: httpd_recv_with_opt: received length = 1
D (26081) httpd_ws: httpd_ws_get_frame_type: First byte received: 0x8A
D (26088) httpd_parse: httpd_req_new: New WS request from existing socket, ws_type=10
D (26096) httpd_parse: httpd_req_new: Received PONG frame
D (26101) httpd_txrx: httpd_recv_with_opt: requested length = 1
D (26107) httpd_txrx: httpd_recv_with_opt: received length = 1
D (26113) httpd_txrx: httpd_recv_with_opt: requested length = 4
D (26119) httpd_txrx: httpd_recv_with_opt: received length = 4
D (26125) httpd_txrx: httpd_recv_with_opt: requested length = 1
D (27028) wss_keep_alive: Haven't seen the client (fd=57) for a while
I (27028) wss_echo_server: Checking if client (fd=57) is alive
D (28031) wss_keep_alive: Haven't seen the client (fd=57) for a while
I (28031) wss_echo_server: Checking if client (fd=57) is alive
D (29034) wss_keep_alive: Haven't seen the client (fd=57) for a while
I (29034) wss_echo_server: Checking if client (fd=57) is alive
D (30037) wss_keep_alive: Haven't seen the client (fd=57) for a while
I (30037) wss_echo_server: Checking if client (fd=57) is alive
D (31039) wss_keep_alive: Haven't seen the client (fd=57) for a while
E (31039) wss_keep_alive: Client (fd=57) not alive!
W (31131) httpd_txrx: httpd_sock_err: error in recv : 11
D (31131) httpd_txrx: httpd_recv_with_opt: error in recv_fn
W (31132) httpd_ws: httpd_ws_recv_frame: Failed to receive the second byte
E (31139) WebSocket: httpd_ws_recv_frame failed with -1
I (31145) httpd_sess: httpd_sess_process: failed httpd_req_new
D (31152) httpd_sess: httpd_sess_delete: fd = 57
I (31156) wss_echo_server: Client disconnected 57
D (31162) httpd_sess: httpd_sess_delete: active sockets: 0
D (31167) httpd: httpd_server: doing select maxfd+1 = 56
D (31174) httpd: httpd_server: processing ctrl message
D (31178) httpd: httpd_process_ctrl_msg: work
I (31182) Sending WS: PING
D (31186) httpd: httpd_server: doing select maxfd+1 = 56
D (31192) httpd: httpd_server: processing ctrl message
D (31196) httpd: httpd_process_ctrl_msg: work
I (31201) Sending WS: PING
D (31204) httpd: httpd_server: doing select maxfd+1 = 56
D (31210) httpd: httpd_server: processing ctrl message
D (31215) httpd: httpd_process_ctrl_msg: work
I (31219) Sending WS: PING
D (31222) httpd: httpd_server: doing select maxfd+1 = 56
D (31228) httpd: httpd_server: processing ctrl message
D (31233) httpd: httpd_process_ctrl_msg: work
I (31237) Sending WS: PING
D (31241) httpd: httpd_server: doing select maxfd+1 = 56

Did you ever find a fix for this?

I honestly can't remember and unfortunately can not test this because I don't work for the same company anymore. But the fact that I closed the issue without writing anything makes me believe it solved itself by an idf upgrade. You could double check if around the same time the issue was closed a new idf was released.


POS-Tagging in other languages

While checking the documentation, I noticed that the .NET port of the POS tagger only supports a couple of languages. I need it for a non-supported language (spanish, specifically). What I have been trying for some weeks now is to use a dll version of the jar file of the language supplied by Stanford CoreNLP, however it does not seem to work.
When using
var tagger = new MaxentTagger(@"C:/Users/myUser/Desktop/UnityProyect/Assets/Plugins/spanish-ud.tagger");
It throws
IOException: Unable to open "C:/Users/myUser/Desktop/UnityProyect/Assets/Plugins/spanish-ud.tagger" as class path, filename or URL
edu.stanford.nlp.io.IOUtils.getInputStreamFromURLOrClasspathOrFileSystem (System.String textFileOrUrl) (at <3882360035dc4dd4a6bff58e8ebe2d3f>:0)
edu.stanford.nlp.tagger.maxent.MaxentTagger.readModelAndInit (java.util.Properties config, System.String modelFileOrUrl, System.Boolean printLoading) (at <3882360035dc4dd4a6bff58e8ebe2d3f>:0)
Rethrow as RuntimeIOException: Error while loading a tagger model (probably missing model file)
edu.stanford.nlp.tagger.maxent.MaxentTagger.readModelAndInit (java.util.Properties config, System.String modelFileOrUrl, System.Boolean printLoading) (at <3882360035dc4dd4a6bff58e8ebe2d3f>:0)
edu.stanford.nlp.tagger.maxent.MaxentTagger..ctor (System.String modelFile, java.util.Properties config, System.Boolean printLoading) (at <3882360035dc4dd4a6bff58e8ebe2d3f>:0)
edu.stanford.nlp.tagger.maxent.MaxentTagger..ctor (System.String modelFile) (at <3882360035dc4dd4a6bff58e8ebe2d3f>:0)
Test.POS (System.String text) (at Assets/Scripts/Test.cs:69)
Test.Start () (at Assets/Scripts/Test.cs:34)

As a way of trying to experiment, also tried routing it to the original jar file, only for it to throw the same IOException. Also tried using "props.setProperty(...)" but, same error was thrown.
How should I use a Stanford CoreNLP language model with the .NET version?

What NuGet Package do you use? Stanford.NLP.CoreNLP or Stanford.NLP.POSTagger? (What version)
Do you have file C:/Users/myUser/Desktop/UnityProyect/Assets/Plugins/spanish-ud.tagger?
Where you downloaded this file from?
Plz share you code snippet

1.- I'm using Stanford.NLP.CoreNLP (3.9.2) downloaded from NuGet, which means in the Unity Assets Folder I'm referencing these Stanford dll's:

And these IKVM dll's:

2.- Technically speaking... no. (Lemme explain lol) that was the reference used when I used the original Stanford CoreNLP in Java. What I have is the Spanish model provided by Stanford. I tried referencing it directly (maybe I did it in a wrong way), and I also have it converted to a dll via IKVM
3.- NuGet
4.- Sure:
using System.Collections;
using System.Collections.Generic;
using edu.stanford.nlp.ling;
using edu.stanford.nlp.pipeline;
using edu.stanford.nlp.tagger.maxent;
using java.io;
using java.util;
using UnityEngine;
using System;
using System.IO;

public class Test : MonoBehaviour
{

    StanfordCoreNLP scnlp;
    Properties props;
    string propname = "tokenize, ssplit, pos, lemma, ner";

    void Start()
    {
        props = new Properties();
        props.setProperty("annotators", propname);

        scnlp = new StanfordCoreNLP(props);

        string text = "Hola, esto es un texto en español.";    //Spanish text
        POS(text);
    }

    void Update()
    {

    }

    public void POS(string text) {
        var tagger = new MaxentTagger(@"C:/Users/myUser/Desktop/UnityProyect/Assets/Plugins/spanish-ud.tagger");
        var sentences = MaxentTagger.tokenizeText(new java.io.StringReader(text)).toArray();
        foreach (java.util.ArrayList sentence in sentences)
        {
            var taggedSentence = tagger.tagSentence(sentence);
            Debug.Log(SentenceUtils.listToString(taggedSentence, false));
        }
    }
}

Option 1
If you want to use var tagger = new MaxentTagger(@"C:/Users/myUser/Desktop/UnityProyect/Assets/Plugins/spanish-ud.tagger"); then you need file C:/Users/myUser/Desktop/UnityProyect/Assets/Plugins/spanish-ud.tagger physically available at this path.
Just unzip Java *.jar with Spanish model and provide full path to spanish-ud.tagger file. Also in this flow you do not need lines
        props = new Properties();
        props.setProperty("annotators", propname);

        scnlp = new StanfordCoreNLP(props);

because you do not use scnlp.
Option 2
You can go with StanfordCoreNLP and build annotators pipeline.
https://github.com/sergey-tihon/Stanford.NLP.NET/blob/v4/tests/Stanford.NLP.CoreNLP.Tests/CoreNlpTests.cs#L73-L93
then process your text and receive Annonation with all metadata extracted by annotators from your pipeline
https://github.com/sergey-tihon/Stanford.NLP.NET/blob/v4/tests/Stanford.NLP.CoreNLP.Tests/CoreNlpTests.cs#L95-L97
here is an example of how you can manually extract data from different kinds of annotations
https://github.com/sergey-tihon/Stanford.NLP.NET/blob/v4/tests/Stanford.NLP.CoreNLP.Tests/CoreNlpTests.cs#L106-L151

You are honestly the best. Thank you so so much!


Timber::get_pagination() always returns next link when 0 posts found

The get_pagination function calculates the total number of pages using this code:
$args['total'] = ceil( $wp_query->found_posts / $wp_query->query_vars['posts_per_page'] );

If $wp_query->found_posts is 0, this will result in $args['total'] being 0 as well.
Later in the function, $args['total'] is passed to get_next_posts_page_link to get the next link. Looking at the get_next_posts_page_link function, it looks like passing in 0 will result in a next link always being generated because this block of code will always run ($max_page is $args['total'] in this case):
if ( !$max_page || $max_page >= $nextpage )
			return get_pagenum_link($nextpage);

I'm assuming you'd want a check in get_pagination to set $args['total'] to 1 if the above calculation results in 0, but I wanted to check in with an issue first since I'm not sure if this would have an unintended consequences elsewhere.

Just checking in about this. I can submit a pull request if that would be more useful.

Hi @sdunham, a long delayed update from us. @connorjburton submitted a PR to resolve this that I just merged. Thanks for your bug report and please checkout master to confirm that it solves your issue


Pause, Start API methods

Implement Pause and Start methods into the API together events that can be used by the user to control the system through the provided API.

Removing from issues as this work is going to be described and planned through different approach.


new: Write a Get Involved/File & Verify Issues doc

https://athensresearch.gitbook.io/handbook/community/get-involved/learning-at-athens-academy-education/file-and-verify-issues

https://github.com/athensresearch/handbook/blob/main/community/get-involved/learning-at-athens-academy-education/file-and-verify-issues.md

Fixed by 022143f


"broken" link in readme

just to mention that the link of the bridgeproject at the very end of your readme file is... inapropriate ;)

Indeed! I removed the link. Thanks for notifying us.


fix: transfer hitting undefined

Description
Adds an empty string else if insight is undefined when passing name to TransferInsightModal

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
Closes #2920

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Closing, opened branch with wrong upstream


Examine PUT and PATCH in existing container

@michielbdejong reports the following observations:
The 6 failures are:
● Create › Using PUT in existing container › is disallowed without accessTo Write or Append
● Create › Using PATCH in existing container › is disallowed without default Write
● Create › Using PATCH in existing container › is disallowed without accessTo Write or Append
● Create › Using PUT in non-existing container › is disallowed without accessTo Write or Append
● Create › Using PATCH in non-existing container › is disallowed without default Write
● Create › Using PATCH in non-existing container › is disallowed without accessTo Write or Append

Can we verify:

whether CSS allows or disallows the above operations?
whether this behavior is correct?

Let's add the tests in any case, and if not correct, let's adjust behavior.

@michielbdejong I have manually tested and I get
% curl -H "Content-Type: application/json" -T package.json http://localhost:3000/src/package.json -i
HTTP/1.1 100 Continue

HTTP/1.1 403 Forbidden
Vary: Accept,Authorization,Origin
X-Powered-By: Community Solid Server
Updates-Via: ws://localhost:3000/
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true
Access-Control-Expose-Headers: Accept-Patch,Link,Location,MS-Author-Via,Updates-Via,WAC-Allow
Accept-Patch: application/sparql-update
Allow: OPTIONS, HEAD, GET, PATCH, POST, PUT, DELETE
MS-Author-Via: SPARQL
Content-Type: text/markdown
Date: Thu, 12 Aug 2021 10:30:11 GMT
Connection: keep-alive
Keep-Alive: timeout=5
Transfer-Encoding: chunked

# Access not allowed
You are logged in, but not allowed to access this resource.

Try requesting access or logging in with a different identity.

## Technical details
_No further details available._

So I am assuming a test suite bug. Maybe it gets confused by the 100, unsure. Will file a bug report.


Graph API Support?

Are there any graph api endpoints available for workspaces?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 97b489b7-9f8c-d46a-8699-c2b791b0a3be
Version Independent ID: b75539dc-8803-cc28-af48-539799858daf
Content: Create workspaces for My Apps portals in Azure Active Directory
Content Source: articles/active-directory/manage-apps/access-panel-workspaces.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @msmimart
Microsoft Alias: mimart

@StarkCaptain Thanks for your feedback! We will investigate and update as appropriate.

Hey @StarkCaptain you can find all supported calls in the reference doc here : https://docs.microsoft.com/en-us/graph/api/overview?view=graph-rest-beta
It looks like this currently isn't supported. If you're interested in this feature please submit it as feedback against the uservoice here : https://feedback.azure.com/forums/169401-azure-active-directory
@StarkCaptain Please let us know if there are anymore questions within the scope of this git issue. If not, I will be closing out this git issue by end of day tomorrow. Please file a new git issue with a reference to this one if you have anymore concerns. Thanks


Add quotes to the kitops site

Relates to #312
We need to add the customer quotes testimonies to the KitOps site.

@javisperez for those quotes, Brad has requested removing the last name of the individuals we are quoting.


Python: Introduce Pydantic settings

Motivation and Context
SK Python is tightly coupled to the use of a .env file to read all secrets, keys, endpoints, and more. This doesn't scale well for users who wish to be able to use environment variables with their SK Applications. By introducing Pydantic Settings, it is possible to use both environment variables as well as have a fall-back to a .env file (via a env_file_path parameter), if desired.
By introducing Pydantic Settings, we are removing the requirement to have to create Text/Embedding/Chat completion objects with an api_key or other previously required information (in the case of AzureChatCompletion that means an endpoint, an api_key, a deployment_name, and an api_version). When the AI connector is created, the Pydantic settings are loaded either via env vars or the fall-back .env file, and that means the user can create a chat completion object like:
chat_completion = OpenAIChatCompletion(service_id="test")

or, to optionally override the ai_model_id env var:
chat_completion = OpenAIChatCompletion(service_id="test", ai_model_id="gpt-4-1106")

Note: we have left the ability to specific an api_key/org_id for OpenAIChatCompletion or a deployment_name, endpoint, base_url, and api_version for AzureChatCompletion as before, but if your settings are configured to use env vars/.env file then there is no need to pass this information.

Description
The PR introduces the use of Pydantic settings and removes the use of the python-dotenv library.

Closes #1779
Updates notebooks, samples, code and tests to remove the explicit config of api_key or other previous .env files values.
Adds new unit test config using monkeypatch to simulate env variables for testing
All unit and integration tests passing

Some decisions need to be made like:

Do we want default values on some of the AzureOpenAI/OpenAI settings like for deployment names. For example, do we default to something like "gpt-35-turbo" for AZURE_OPENAI_CHAT_DEPLOYMENT_NAME.

Contribution Checklist

[X] The code builds clean without any errors or warnings
[X] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[X] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

Python 3.10 Test Coverage Report • FileStmtsMissCoverMissingsemantic_kernel/connectors/ai/google_palm/services   gp_chat_completion.py661676%10, 135–140, 151–152, 201, 204, 207–208, 216, 220–221, 229   gp_text_completion.py38684%10, 57–58, 64–65, 94   gp_text_embedding.py27581%10, 47–48, 57–58semantic_kernel/connectors/ai/open_ai/services   azure_chat_completion.py763455%248, 254–255, 264–265, 270–287, 291–298, 310–321   open_ai_text_completion.py16194%128   open_ai_text_embedding.py13192%83semantic_kernel/connectors/search_engine   bing_connector.py35350%3–71semantic_kernel/core_plugins/sessions_python_tool   sessions_python_plugin.py95991%76–82, 122, 168, 172TOTAL567089284%
Python 3.10 Unit Test Overview

Tests
Skipped
Failures
Errors
Time

1287
1 :zzz:
0 :x:
0 :fire:
14.619s :stopwatch:


Support paths with spaces

Fixes #62
Use ansible.module_utils.splitter.split_args to parse the include instruction as it's done in ansible.
https://github.com/ansible/ansible/blob/5ce3988d8693357f671f3fbec43b2d3b862db5f6/v1/ansible/playbook/__init__.py#L210
Take all the tokens without an = to build the path.

This wasn't applied on the most recent master, but I rebased the commit and pushed, so PR accepted, thank you.

Oups, sorry. Thanks!


cannot run on ios with sqlite3_flutter_libs: ^0.5.13

Describe the bug
after adding the sqlite3_flutter_libs , cannot run on ios

run in Xcode

run pod install

Have you tried running on a Physical device?

Have you tried running on a Physical device?

not yet, but it works fine while removing the two pkgs

Does flutter clean help at all? I've not seen this error before, and I don't see how adding this dependency could cause that linker error. This StackOverflow question seems similar too, do the suggested answers help?

I noticed that 0.5.13 raises the min iOS version to 15 - maybe that is related.

I noticed that 0.5.13 raises the min iOS version to 15 - maybe that is related.

not for the reason , my ios version is 16.4

Does flutter clean help at all? I've not seen this error before, and I don't see how adding this dependency could cause that linker error. This StackOverflow question seems similar too, do the suggested answers help?

thank u, it helps a lot , and here is my solution

post_install do |installer|
  installer.generated_projects.each do |project|
        project.targets.each do |target|
            target.build_configurations.each do |config|
                config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '13.0'
             end
        end
 end
    installer.pods_project.targets.each do |target|
    flutter_additional_ios_build_settings(target)
  end
end

I noticed that 0.5.13 raises the min iOS version to 15 - maybe that is related.

That wasn't intentional, and I don't really understand how that could have happened. In the pod, we still have the original platform constraint and the spec for sqlite3, our only external dependency, doesn't specify a min version either.

No activity in over a year & seems to be resolved, closing


Listing tests with empty LinuxMain.swift outputs error message (Swift 5.8)

Description
Running swift test list outputs an error for SwiftPM packages that have an empty LinuxMain.swift
Expected behavior
swift test list to output a list of all the tests in a package
Actual behavior
It outputs
error: malformed

Steps to reproduce

swift package init
touch Tests/LinuxMain.swift
swift test list

Swift Package Manager version/commit hash
No response
Swift & OS version (output of swift --version && uname -a)
Swift version 5.8-dev (LLVM f6b60d5b8f4b443, Swift ecccce61139bbc4)
Target: x86_64-unknown-linux-gnu
Linux af-starbook 5.15.0-46-generic #49~20.04.1-Ubuntu SMP Thu Aug 4 19:15:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

@adam-fowler is this still an issue?

Going to close this just now as I cannot replicate it.

Re-opening, just managed to replicate this. It looks like it might be related to packages that have been built with a previous version of Swift.

It looks like it is related to packages that have a LinuxMain.swift

Assuming we don't support LinuxMain.swift anymore IIRC, do we need a separate issue to track that the error message itself should be fixed?

A 5.8 release of swift should not have breaking changes in it though. Projects that built and test fine with swift 5.7 should do so with 5.8 as well.

Right, so reopening this one seems more suitable then?

I closed this issue then within 5 minutes realised it was still an issue so reopened it and managed to narrow down what the problem was.

Ah, ok. I was a bit confused since the status for me is still showing up as closed.

Ah, ok. I was a bit confused since the status for me is still showing up as closed.

 See https://forums.swift.org/t/test-discovery-on-linux/26203/10 for reasons why you might have an empty LinuxMain.swift

@adam-fowler, some diagnostics for this error were just merged in trunk, #6860, try it with the next trunk snapshot build- the current Aug. 25 snapshot doesn't have that commit- and see if it helps.

I now get
error: invalid list test JSON structure, produced by /home/adamfowler/Developer/server/mqtt-nio/.build/x86_64-unknown-linux-gnu/debug/mqtt-nioPackageTests.xctest --dump-tests-json, underlying error: malformed(json: "", underlyingError: Error Domain=NSCocoaErrorDomain Code=3840 "The data is not in the correct format.")

Thanks for the update, sounds like an empty JSON is produced?

@adam-fowler any luck working around this?

@mapedd I haven't seen this in a long time. Although I've removed LinuxMain.swift from pretty much all of my projects.

Closing per Adam's latest comment; if somebody's still running into this issue, please do reopen!


v4: i18n + proxy

i18n together with the proxy command does not work in v4.
For example:
["ug"].each do |shortname|
  proxy "/localizable/#{shortname}/publications.html", "/localizable/publications.html", locals: { person_short_name: shortname }, ignore: true
end

gives

You can't proxy ug/publications.html to localizable/ug/publications.html which is itself a proxy. (RuntimeError)

Not sure why this is necessary. The i18n extension will already do this for you.

I want to have one (localized) file, which receives the short_name as parameter, instead of having to put 5 files into the sources. (The "ug" one-element-list is just an example.)
I do not see how this can be achieved otherwise. Basically I just want the first example from here localized: https://middlemanapp.com/advanced/dynamic_pages/

Not sure I'm understanding. The language will already be available inside each template as I18n.locale

I have a file .html.erb file containing:

<%= t('publications') %>

<%= show_publications_of short_name %>

This file should be accessible via the following paths
/DE/person1/publications.html -> short_name = person1, locale = de
/EN/person1/publications.html -> short_name = person1, locale = en
/DE/person2/publications.html -> short_name = person2, locale = de
/EN/person2/publications.html -> short_name = person2, locale = en

which in my understanding should be achievable by combining proxy and i18n?

Ah, gotcha. That's a reasonable assumption, but i18n can't be in that way currently.
You can do it outside of i18n like so:
[:de, :en].each do |locale|
  ["ug"].each do |shortname|
    proxy "/#{locale}/#{shortname}/publications.html", "/publications.html", locals: { person_short_name: shortname }, ignore: true, lang: locale
  end
end

Where you don't place the publications file in the localizable folder.

Your code works. Maybe something to be added to the documentation?
While the pages work, the solution breaks the resource hierarchy used by Middleman-breadcrumbs. In detail the localized and the non-localized resource subtrees seem to be separated. (Most likely not only in this case, but whenever one wants to mix localized and non-localized pages.)
The traversal method of Middleman uses path, whereas for breadcrumbs I guess destination_path is more suitable. Is this something which should be added to Middleman or monkey patched in Middleman-breadcrumbs?

@GhostGambler Yeah, they should definitely be using path, or the built-in traversal methods: https://github.com/middleman/middleman/blob/master/middleman-core/lib/middleman-core/sitemap/extensions/traversal.rb

Well, they use the traversal methods of Middleman, so if this should work, then it is a bug in Middleman.

Hmm, that does seem like a bug.

I've the same problem: (middleman 4.1.10). I followed the suggestion of tdreyno from the 10 Dec 2015 without success:

While running the code with middleman server, I got a "page not found" when I follow the link to the dynamic pages.
When I build the website, the 4 pages are rendered, but all with the default locale inside...
/DE/person1/details.html -> short_name = person1, locale = de /EN/person1/details.html -> short_name = person1, locale = en /DE/person2/details.html -> short_name = person2, locale = de /EN/person2/details.html -> short_name = person2, locale = en

Any suggestions to work with i18n and dynamic pages?


[docs] Add the last diamond sponsor

[x] I have followed (at least) the PR section of the contributing guide.

Preview: https://deploy-preview-28737--material-ui.netlify.app/getting-started/usage/
TODO:

[x] Update https://deploy-preview-28737--material-ui.netlify.app/discover-more/backers/#diamond too
[x] Remove +1 there are only 3 spots

[x] Add a link on "Diamond Sponsors" to "/discover-more/backers/#diamond" so developers can learn more about it?

[x] Wait for the subscription to start

@oliviertassinari is three the max num of diamond sponsors we should have? I am asking because we may want to remove the +1 buttons on the sidebar and the landing page.

We probably should have removed this one too from the landing page:

We probably should have removed this one too from the landing page:

@mnajdova I will create a separate PR for this!


How can I set the log level to show more details for portainer itself?

We deploy portainer ce 2.11.0 with docker on ubuntu. And found the logs for portainer itself are confusing sometimes so that we couldn't debug some issues. We are wondering is there any way to change the default log level for portainer container? For example, to change the log level to debug mode. Thanks！

Hello LcyXI,
     We do not have a way to set log level at this time. There is a plan to address that in the future. However right now there is no way to do that.

Thanks,
Michael

Any update on this?

@Pwuts
Example command here:
sudo docker run -d -p 9443:9443 --name portainer --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer-ee:2.16.2 --log-level=DEBUG

Example log snippet:
2023/01/19 11:59PM INF main.go:582 > encryption key file not present | filename=portainer
2023/01/19 11:59PM INF main.go:601 > proceeding without encryption key |
2023/01/19 11:59PM INF github.com/portainer/portainer-ee/api/database/boltdb/db.go:125 > loading PortainerDB | filename=portainer.db
2023/01/19 11:59PM DBG github.com/portainer/portainer-ee/api/datastore/datastore.go:81 > opened existing store | version=72
2023/01/19 11:59PM INF github.com/portainer/portainer-ee/api/datastore/backup.go:151 > creating DB backup |
2023/01/19 11:59PM INF github.com/portainer/portainer-ee/api/datastore/backup.go:74 > copying DB file | from=/data/portainer.db to=/data/backups/EE/portainer.db.072.20230119235925
2023/01/19 11:59PM INF github.com/portainer/portainer-ee/api/database/boltdb/db.go:125 > loading PortainerDB | filename=portainer.db
2023/01/19 11:59PM DBG github.com/portainer/portainer-ee/api/datastore/datastore.go:81 > opened existing store | version=72
2023/01/19 11:59PM INF github.com/portainer/portainer-ee/api/datastore/migrate_data.go:121 > migrating database | migrator_version=72 portaineree_db_version=72
2023/01/19 11:59PM INF github.com/portainer/portainer-ee/api/datastore/migrate_data.go:139 > migrator_edition=EE portainer_edition=EE store_edition=EE
2023/01/19 11:59PM INF github.com/portainer/portainer-ee/api/cloud/cluster_setup.go:77 > starting cloud cluster setup service |
2023/01/19 11:59PM DBG github.com/portainer/portainer-ee/api/useractivity/cleanup.go:16 > starting logs cleanup process | check_interval_seconds=86400
2023/01/19 11:59PM DBG github.com/portainer/portainer-ee/api/useractivity/cleanup.go:61 > removed old auth logs | count=0
2023/01/19 11:59PM DBG github.com/portainer/portainer-ee/api/useractivity/cleanup.go:68 > removed old user activity logs | count=0

Please let me know if that works for you.
Thanks!

I just found this in another issue, too, and it's a great tip that should make it into the Portainer docs :)

sudo docker run -d -p 9443:9443 --name portainer --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer-ee:2.16.2 --log-level=DEBUG

Please let me know if that works for you.
It does! This should be in the docs :)

I already added a PR in the portainer-docs repo for this:
https://github.com/portainer/portainer-docs/pull/259


static/djcelery/style.css not found 404

pip install django-celery==3.0.23
There is no static dir in site-packages/djcelery

I am getting this 404 on django-celery==3.1.17


x/tools/cmd/godoc: first return value with an unqualified imported type not showing up in documentation output

What version of Go are you using (go version)?
go version go1.5.3 linux/amd64
What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/mikeatlas/gopath"
GORACE=""
GOROOT="/home/mikeatlas/golang/go"
GOTOOLDIR="/home/mikeatlas/golang/go/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT=""
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"

What did you do?

Using godoc -http=:6060 to generate live documentation, I seem to have an edge case that does not appear to make any sense. Function return values with an imported type without a qualifier as the first value do not appear in documentation, with return order being the only difference and the imported type without a qualifier as the first return value will cause the function to not show up in documentation output HTML. An example is as follows:
package xyz

import . "qpackage/q"

// TestFn is a test function
func TestFn(input string) (Q, error) {}

// TestFnX is a test function
func TestFnX(input string) (error, Q) {}

In this example, only TestFnX appears in the documentation output. However, if I qualify the imported package type, both work:
package xyz

import q "qpackage/q"

// TestFn is a test function
func TestFn(input string) (q.Q, error) {}

// TestFnX is a test function
func TestFnX(input string) (error, q.Q) {}

In this example, both TestFn and TestFnX appear in the documentation output.

What did you expect to see?

Both examples in the code sample above should have worked - the return order of the imported type seems to be the only difference; I'm able to generate documentation for the function if the first return value type is not from the unqualified imported package.

What did you see instead?

Only if a native type is returned first, or if the imported type has a qualifier, will the function appear correctly in the godoc output.

Would a test project here on GitHub demonstrating the bug be useful?

Maybe this is just punishment for using import .?  :-)

/cc @adg @griesemer

@bradfitz You know someone's eventually going to shoot themselves in the foot if you give out guns :) Thanks for triaging this.

@mikeatlas - Yes, it would be great if you can setup a test repo on github.

I am unable to repro this. Can you try with latest go 1.10.1 and godoc tip ?

If you can't repro it from the steps above, and no other reports, it is likely resolved!


TwoBucket - possible error in test suite

Hi,
I think there could be an issue with the tests in two buckets ruby exercise.
In the test test_measure_using_bucket_one_of_size_2_and_bucket_two_of_size_3_start_with_bucket_one_and_end_with_bucket_two (starting line 45) the expected number of moves is set to 2, but I'm wondering if it shouldn't be 4. All my other tests pass and that's the solution I get when solving the exercise on paper.
Out of curiosity I've checked the same exercise in the Elixir track and the same test also sets the expected number of moves to 2, so, it's maybe just me missing a nice shortcut to get it in 2 moves :-).
Thanks for your time.

Please request a mentor for the Ruby exercise, so that it can be determined there.  This is a great way to take away the "it's maybe just me missing…" since it will have been hopefully discussed and verified by a mentor.
If you are using the command line tool, you can submit it, even if it is failing.  If you are using the web editor, you can hard-code the solution in order to get that failing test to pass (but comment it as such, since, if you then say "there is a failing test", that would not be true.

Ok, thanks for your answser, I will request mentorship.

No problem.  Glad you found it!


Fixed building on Windows

Minor rendering improvement

TrueCraftGame.cs(342,9): error CS1922: A field or property `Microsoft.Xna.Framework.Graphics.BlendState' cannot be initialized with a collection object initializer because type `Microsoft.Xna.Framework.Graphics.BlendState' does not implement `System.Collections.IEnumerable' interface

Does this compile for you?

Nope, I'll push a fix. :zzz:

Danke

You should probably come hang out in IRC, by the way. #truecraft on irc.esper.net.

Sure, why not.


Adds json schema validator to fix issue #14

Adds json schema validator to fix issue #14
Adds moment.js to dependencies
And changes the test-service to use local module for development

Only problem is that I couldn't figure out how to add a custom error message. So, currently it prints out all the valid timezone names if the provided timezone doesn't match the schema.

Rather than add a dependency on moment-timezone it might be simpler just to set the type of timezone as string

@pgrzesik Can this be merged? I've got another PR if you don't like this, can move it here directly

Close in favor of: https://github.com/serverless/serverless-local-schedule/pull/25


Calendar Block: View Types Checkboxes Not Updating View Types Order

When adding or editing a Calendar block selecting options under View Types does not update the View Type Order.  Consequently the calendar always shows the default View Types.  The problem appears to be missing underscore characters on lines 58-59 of the block's form.php.  On both lines, the id attribute must have an underscore between viewTypes and the view type name.  Making this change fixed the bug on my site.

Thanks for the pointing toward lines 58-59!

This has been fixed in GitHub and will be released in 9.0.2


Future of findOrCreateEach and dynamic finders

According to PR #843 findOrCreateEach is deprecated:
@tjwebb

Personally I'd like to deprecate (and remove) all dynamic finders, since it's just senseless proliferation of API surface area.

@particlebanana:

I would love to remove the dynamic finders. Whenever we feel like an 0.11 release is ready we can take a pass and remove all that stuff.

The questions are:

Should we strip the findOrCreateEach from waterline on 0.11?
Should we strip all dynamic finders code from waterline on 0.11?
Any other thoughts regarding dynamic finders?

cc @devinivy, @randallmeeker, @Globegitter, @RWOverdijk

The way I see it is that findOrCreateEach indeed should be deprecated and findOrCreate should support both use-cases. Which it is pretty close to supporting right now anyway.

I don't care if we strip findOrCreateEach or dynamic finders out of the API.  But I'm curious how widely the dynamic finders are used.  It is a pretty typical feature of ORMs, I think.
If we do remove findOrCreateEach, we should stop using it internally to waterline core.  This was brought-up with @Globegitter here.

Also, familiarize yourself with what findOrCreateEach actually does if you don't already know!  It may not be as obvious as one would expect: https://github.com/balderdashy/waterline-adapter-tests/blob/master/interfaces/semantic/findOrCreateEach.test.js#L29
TLDR: 1st argument is an array of attributes to findOne using array of objects in 2nd argument.

Also on that note, I am halfway-through implementing a findAndModify function with upsert support. See: http://docs.mongodb.org/manual/reference/command/findAndModify/
For that I also followed the current way and implemented a findAndModifyEach, but purely intended as a helper function. I don't want to drift off the main topic of this discussion but I think it fits here and would be a good questions if we want this functionality (I think we should have these slightly more advanced functions. You don't need them very often, but once you do need them they are tedious enough to implement) and how to implement all use-cases without findAndModifyEach.
Also does someone have a list of what all the dynamic finders are?

helper methods:

createEach
findOrCreateEach (DEPRECATED)
findOrCreate
findOneLike
findLike
startsWith
endsWith
contains

Based on your Collection attributes you also have dynamic finders. So given a name attribute the following queries will be available:

findOneByName
findOneByNameIn
findOneByNameLike
findByName
findByNameIn
findByNameLike
countByName
countByNameIn
countByNameLike
nameStartsWith
nameEndsWith
nameContains

Taken from https://github.com/balderdashy/waterline#query-methods

You don't need them very often, but once you do need them they are tedious enough to implement) and how to implement all use-cases without findAndModifyEach.

How about moving dynamic finders to a separate (and optional) module/project? That way people who wanted to use them could use them and waterline core would have a tighter API.

I actually just had the same thought - having it as a simple npm i waterline-extended --save without any other setup would be a good solution as well. But how should adapters be handling that then?

That's a great idea.  I do like the simple findBy{attr} and findOneBy{attr}.  The rest are unnecessary, but a module that adds them would be a reasonable middle-ground.  Especially if a community member who cares about that functionality wanted to lead the project.

Perform a survey by scanning github projects that have waterline as a
dependency and check to see if the dynamic methods or the findAndxx methods
are used - then publish the results.
It's pointless to make a change if those features are used by a majority of
projects.
On 6 Apr 2015 4:45 pm, "Dário"<EMAIL_ADDRESS>wrote:

You don't need them very often, but once you do need them they are tedious
enough to implement) and how to implement all use-cases without
findAndModifyEach.
How about moving dynamic finders to a separate (and optional)
module/project? That way people who wanted to use them could use them and
waterline core would have a tighter API.
—
Reply to this email directly or view it on GitHub
https://github.com/balderdashy/waterline/issues/931#issuecomment-90084574
.

This should then also be used to simplify things.
There are for example two findOrCreate and two findOrCreateEach functions which makes it a bit complicated to understand what function gets called when and also has more duplicate code. Doing some tests in my app it seems that findOrCreate in lib/waterline/query/composite.js is the 'main' function and gets called all the time, where-as the findOrCreate in lib/waterline/adapter/compoundQueries.js only seems to be called in conjunction with findOrCreateEach (that is when you pass it an array of objects). Then it seems that both findOrCreateEach (in lib/waterline/query/aggregate.js as well as lib/waterline/adapter/aggregateQueries.js) get called all the time.
Anyone here knows more about this behaviour and the reasoning for both functions?

I don't know if there are any peculiarities around these particular methods.  But generally speaking, here's how it works:
Methods in lib/waterline/query live on the Collection object.  The Collection object eventually needs to ask an adapter to do its dirty work.  The methods in lib/waterline/adapter do the dirty work of delegating specific queries to the relevant connection/adapter.

The main reason I am mentioning it is because to begin with it was quite hard to get into what is actually happening since the functions themselves look very similar and well - they look very similar. So there is a lot of almost duplicate code. Similar checks being done, both have call find/findOne and create under circumstances. So I just wonder if there (and possibly also in other functions) is potential to dry up and simplify the code.
I am not sure if one of the two functions could be removed somehow but from the sounds of it you need both. And then I just wonder if they could use both call the same private functions for the overlapping stuff, or maybe only one of the functions actually needs to do the checks, etc.
This is where I am going with it. What are your thoughts?

I added a feature that lets you set dynamicFinders: false. Initially, we could just change the default value of this to false for the next minor release, and see how that goes. That'd be less destructive than ripping out a bunch of code.

@tjwebb From what I can see this would not disable findOrCreate/findOrCreateEach (nor findAndModify) though.

I like findAndModify with option flags, its so extendable and battle tested... also the mongo db guys did a good job in documenting many use-cases of it.
I for one:

don't use dynamic attributes finders, I prefer the using consistent code style that always separate Model/action/criteria
would never use findOrCreateEach, I think its counter intuitive... just like devinivy said in his second comment: its not obvious!! Maybe it has its niche use-cases, not for me though
My two cents :)

Regarding .createEach, @brandonsimpson has commented the following in https://github.com/balderdashy/waterline/pull/980#issuecomment-97597314:

@dmarcelino I think if .create() already accepts arrays and can do multiple inserts then .createEach() is redundant if it's not doing something more such as create each record sequentially. I think adding an options param to .create() would ultimately allow you to drop .createEach() completely.

@dmarcelino I agree with the comment - I have also been thinking a bit more about the whole find/findOrCreate as well as update/updateOrCreate (findAndModify as I called it).
Maybe it would make sense to minimize the public API by adding options to the update or find command.
In my opinion both options have pros and cons - less functions means the public API is less cluttered but on the other hand having more options makes each command slightly more complicated.
But either way the code would definitely benefit from cleaning up/refactoring.


fix(docs): Updated link to example iam-policy that was moved per #701.

Was following the walkthrough guide for configuration of kube2iam and found this link to be stale per #701.

Coverage remained the same at 44.083% when pulling 6f6c5eceab996b901bc8223b698ff9d5ea58fa26 on cj-taylor:update-urls-to-resources into 438c7501b59fc18e11350db4a35e16180e998ae3 on kubernetes-sigs:master.

I signed it

/ok-to-test

@cj-taylor hi, did you sign the CLA using your email<EMAIL_ADDRESS>=.=seems the CLA check still fails..

@M00nF1sh, yeah, just went through the signing process again, it's via<EMAIL_ADDRESS>/check-cla

/lgtm
/approve
Thanks for fixing this 👍


Update media content doesn't work in tonkeeper and explores

The collection cover was updated correctly: https://testnet.ton.cx/address/EQBNeD9A3xxRFAqVP1gEAiZxiH-l51rRw-aXwK_2gVoYVmf1
Updated NFT doesn't show updated content: https://testnet.ton.cx/address/EQDBTM_jGUjy2f3oigJsrurdKd9YO-sGZ3-p6GvMF_mPUaeU

In case we are unable to fix it quickly let's disable update media.


[Improvement] Authenticate again if refresh token has expired

Insomnia Version: 5.15.0
Operating System: Arch Linux

Details
Hi there!
When the access token expires, Insomnia tries to use the refresh token to get a fresh access token. But, if the refresh token has expired as well, the backend will throw an exception and will not send a fresh access token. In order to solve this issue, I have to clear the expired refresh/access token to allow Insomnia to authenticate again and fetch new refresh and access tokens.
If I have lots of requests with expired refresh tokens, I have to expend some time clearing and authenticating all over again.
Would be possible to add a checkbox near the refresh token, or in the advanced options, to indicate that if the refresh token is expired, Insomnia shall send a fresh authentication request to fetch new tokens? This should be optional, since the developer may want to test expired refresh token.
Best regards,
Rafael Pacheco.

I think this feature request would improve Insomnia usability a lot. We have our backend microservices all using OAuth2, and usually our team have to clear the token to get a new fresh authentication, because the refresh token was already expired. This happens a lot because the refresh token has a 2 week lifetime, and since we have lots os microservices, it's very frequent to test some API that has an expired refresh token.

Agreed. This should be done 😄

Any news on this one? Would love to see this feature

I would love to see this feature. Clearing the tokens became a natural action for us, because everyday we face lots of expired refresh tokens.
PS: Since OAuth2 doesn't impose expiration time on refresh tokens, the Insomnia behavior could be something like If access token has expired and the refresh token didn't work for 'some' reason, I'll reauthenticate from the beginning just once, so you can test your API happily.

This is not working for me.
I have two OAuth2 Requests. When I send one after the other it is working fine, token and refresh token are set. Now when I'm clicking on "refresh token" (or wait until token expired) and try to use the other request, the refresh token and access token are of course expired.
So when I send the request, authentication is invalid.
Maybe it would make sense to sync the refresh token and access token between OAuth2 Requests with the same Access Token URL and Grant Type.