Can't reproduce results for YouCookII

I took this model
wget https://www.rocq.inria.fr/cluster-willow/amiech/howto100m/s3d_howto100m.pth
wget https://www.rocq.inria.fr/cluster-willow/amiech/howto100m/s3d_dict.npy

and code from this repository, I take validation part of youcookII and try to achieve numbers
mentioned in the article End-to-End Learning of Visual Representations from Uncurated Instructional Videos

It is unclear which protocol did you use for testing. In the following table I show several experiments and none of them could  achieve your results. Could you clarify which test protocol did you use for testing? It will be good if you publish script for testing.
What I try.

T is time in seconds. I split each clip to subclips each has length T seconds. For each subclip embedding will be compute.
pooling If clip  was split to >1 subclips embeddings will be averaged to pooling
imgsz Short side of each source video will be rescaled to imgsz with h:w preserving. Then
center crop will be taken for each frame.
normalize Whether or not sentence embedding and each video embedding was L2-normalized before dot-product.
num frames From each T-seconds clip num frames was taken in uniform style.
num resample  For each clip sample different num resample sets of frames. For each resample compute embedding. With pooling all embedding will be polled to single one. LCR means sample from each clip 3 times: num frames left crops, num_frames right crops, num frames center crops.

T
imgsize
pooling
normalize
num frames
num resample
R@1
R@5
R@10
MedR

250
200
max
False
32
1
11.478
27.610
37.453
21

250
224
max
False
32
1
8.774
22.044
30.975
32

250
256
max
False
32
1
5.912
15.503
21.038
104

1.5
200
max
False
32
1
8.333
23.208
31.981
31

3.2
200
max
False
32
1
9.497
24.969
34.654
24

8
200
max
False
32
1
10.094
25.818
35.849
23

16
200
max
False
32
1
10.755
26.478
36.541
21

32
200
max
False
32
1
11.164
27.484
37.296
21

64
200
max
False
32
1
11.415
27.704
37.547
21

128
200
max
False
32
1
11.447
27.610
37.453
21

250
200
max
True
32
1
9.906
25.031
34.748
25

250
200
max
False
32
2
11.604
28.270
37.987
20

250
200
max
False
32
3
11.918
28.396
38.333
21

250
200
max
False
32
4
11.509
28.082
38.365
21

250
200
max
False
32
LCR
11.384
27.138
37.704
22

250
200
mean
False
32
4
12.075
28.805
38.459
20

Hi,
Thank you for your comment here is how we have done it:
Each testing video is sampled at 10 fps and rescaled so that min(height,width) = 224.
For each YouCook2 video clip, we sampled 4x 32-frame clips linearly spaced (so each clip is of 3.2 seconds), center crop it to 224x224, and compute the video embedding for each of them of size 512. And then we average pool the embeddings.
Finally there was no normalization.
I guess the main difference with what you are doing is that you are uniformly sampling the 32 frames over the whole video right ? Or are the 32 frames sampled, always subsequent frames ?
Also please make sure to put the model in eval mode, otherwise you will recompute batch norm statistics over running batches.
One thing to note is that this pytorch model is a port of the official tensorflow release model from: https://tfhub.dev/deepmind/mil-nce/s3d/1
I did convert the weights to pytorch and did run a benchmark on CrossTask to check if the numbers were similar but I did not check on YouCook2. If you still happen to have any problem, please let me know and I will check myself on YouCook2.

Do you L2-normalize text embeddings and video embeddings before avg-pooling?
If not, is it ok that text embedding has L2-norm ~175 and video embedding ~0.25 ?

No normalization is needed, I managed to rerun the YouCook2 evaluation using this pytorch model on a new code (different from my codebase at Deepmind) and with a validation set sligtly larger than the one I had at deepmind and got 49,5 in R@10.
I assume there is a problem in how you sample the video clips of 32 frames. Are they always 32 contiguous frames ? if not then you might have some issues if you randomly sampled 32 frames within a large clip of 250 seconds.

Thank you for explanation. I succeed to get numbers from article. The main reason was in JPG compression. By default ffmpeg uses JPG compression when it doing unpacking video to images. I disabled compression and could manage to get required number.

I am also trying to replicate the results mentioned in the paper on YouCook2 dataset using the pretrained model provided but there seems to be some error that I am not able to locate since I am getting pretty bad results on a random 256 video clip sample of the validation set of YouCook2 validation set. I did the following steps -

Downloaded the YouCook2 dataset and then divided the untrimmed videos into clips according to the annotated segments durations.
Randomly sampled a 256 clip validation set for testing the model.
Loaded the clips as tensors using framerate as 10 and minimum size as 224 and center cropped them.
Preprocessed the tensors by normalizing them.
Uniformly selected 5 x 32 frames subclips if there are greater than 5 subclips otherwise took all the subclips and computed the 512 size embeddings and then mean pooled them.
Computed the text embeddings beforehand and then filled a similiarity matrix for to calculate metrics.

This is the main evaluation code.
def collate_fn(batch):
    vids = [item['video'] for item in batch]
    sents = [item['text'] for item in batch]
    video_id = [item['input'] for item in batch]
    return {'video': vids, 'text': sents, 'input': video_id}

df = pd.read_csv('./YouCook2/YC2_validation_clips_256.csv')
dataset = YouCookClipLoader(
            csv='./YouCook2/YC2_validation_clips_256.csv',
            framerate=10,
            size=224,
            centercrop=1
          )

n_dataset = len(dataset)
loader = DataLoader(
    dataset,
    batch_size=1,
    shuffle=False,
    num_workers=0,
    sampler=None,
    collate_fn=collate_fn
)
preprocess = Preprocessing('3d')

video_net = S3D('s3d_dict.npy', 512)
video_net.load_state_dict(th.load('s3d_howto100m.pth'))
video_net.eval()

loss_op = MaxMarginRankingLoss(
    margin=1,
    negative_weighting=False,
    batch_size=256,
    n_pair=1,
    hard_negative_rate=0.5,
)
loss_op.cuda()

sim_matrix = np.zeros((n_dataset, n_dataset))

video_net.cpu()
text_common_embed = []
with th.no_grad():
    for i, row in df.iterrows():
        video_path = row['video_id']
        name = video_path.split('.')
        name = name[-2]
        name = name.split('/')
        name = name[-1]
        num = name.split('_')
        num = num[-1]
        name = name[:len(name)-len(num)-1]
        video_id = name

        sent = youcook_json[video_id]['annotations'][int(num)-1]['sentence']
        sent = [sent]
        text_embed = video_net.text_module(sent)
        # text_embed = F.normalize(text_embed['text_embedding'], p=2, dim=1)
        text_common_embed.append({'embed':text_embed.detach(), 'sent':sent})

video_net.cuda()
with th.no_grad():
    for i_batch, sample_batch in enumerate(loader):
        torch.cuda.empty_cache()
        video = sample_batch['video']
        sent = sample_batch['text']
        print("Load: ",len(sent))
        print('Video Embedding Start')

        batch_size = len(video)
        video_embed = []
        for i in range(0, batch_size):
            clip = video[i]
            clip = preprocess(clip, 32, 224)

            p = clip
            seq_len = list(p.size())[0]
            if seq_len > 5:
                skip = seq_len // 5
                arr = []
                for j in range(0, seq_len, skip):
                    arr.append(clip[j].unsqueeze(0))
                p = torch.cat(arr, 0)
            vid_len = list(p.size())[0]
            p = p.cuda()
            print(p.shape)
            out = video_net(p)

#             temp,_ = torch.max(out['video_embedding'] , dim=0)

            temp = torch.mean(out['video_embedding'] , dim=0)
            temp = temp.unsqueeze(0)
            video_embed.append(temp.detach().cpu())

        video_embed = torch.cat(video_embed, dim=0)
        video_embed = F.normalize(video_embed, p=2, dim=1)
        sentences = sent

        for j, text_dict in enumerate(text_common_embed):
            sim_matrix[j,i_batch] = th.matmul(text_embed, video_embed.t()).cpu().numpy()

loss = loss_op(th.from_numpy(sim_matrix))
print("Validation Loss: ", loss.item())

metrics = compute_metrics(sim_matrix)
print_computed_metrics(metrics)

Can you please point out any obvious errors that are leading to very low retrieval scores.
@dzabraev It would very helpful if you can provide your testing script to replicate the results.

I disabled compression and could manage to get required number

Hi bro, sorry to bother you. Could you please share how to disable the JPG compression in ffmpeg-python? I try to search for the arguments but didn't find how to disable it.

Add -q:v 1 to ffmpeg arguments.
You can unpack video to bmp. BMP is lossless format. It will give you the best possible quality, but each image will have big size.


Fix windows system-probe pprof flare tests

What does this PR do?
Fix failures of TestCommandTestSuite on Windows. We now use shared test servers for all the tests in the suite instead of each test creating its own servers. This is because the RemoteSystemProbeUtil instance used by the tested code is a global and configured only once; creating a server in every test means that the new server config (e.g., the listening port) is not propagated to the ReomteSystemProbeUtil global instance, causing the failure.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Easily switch from survey viewing to edit mode

#4478

Review this after #5008 has been merged as it is built upon the changes in that PR.


@collegiumwitelona

As The Witelon State University of Applied Sciences in Legnica legally changed its name to Collegium Witelona Uczelnia Państwowa (:gb: Witelon Collegium State University, @collegiumwitelona), I'm requesting for adding new email domains to your list.
The new address: https://collegiumwitelona.pl/
Page about CS studies: http://www.wzi.pwsz.legnica.edu.pl/artykul-166-ki
Contact page with the domain in question included: http://www.pwsz.legnica.edu.pl/strona-684-teleadresowe-1
Domain @collegiumwitelona.pl is for teachers and @studenci.collegiumwitelona.pl for students.

@krzysztofrewak Pull request merged. Thank you!


$translate service returns promise

Hello,
I use  $translateProvider.useUrlLoader(...)
Works fine in html with filter and directive.
But $translate service returns a promise when used in controller.
Bug ?
Thank you !!!!!!!
Philippe

No, this is correct. Please look here in the guide:
http://angular-translate.github.io/docs/#/guide/03_using-translate-service


Renamed items not removed properly when deducting money

Via Bukkitdev ticket

What steps will reproduce the problem?

edit the config file to look like this: http://pastebin.com/7uRTs717
restart server.
 What do you see instead?
it decreases your balance if you do /money or /balance.
But it does NOT take away any of your items.

What version of the product are you using?
Gringotts v2.3

Do you have an error log of what happened?
There's not errors

The actual problem appears only when the items are renamed with a third party plugin.

with displayname support in 2.6 this is probably obsolete


Add owner property to Extensions

$this->owner should be recognized. Requires fetching from the config which DO it's extending, to add the @property tag.

Fixed in https://github.com/axyr/silverstripe-ideannotator/commit/c9f099767e0ab38bf0ee5ed8f7c3074a8f52612e


npm run build error Module not found: Error: Can't resolve '../../../config/server' in

Hi,
I appreciate your help!
I'm getting error when i run npm run build
ERROR in ./node_modules/theme/dist/lib/apiClient.js
Module not found: Error: Can't resolve '../../../config/server' in '/Users/seunghunlee/Clients/Seunghun/cand
le-shop-v0.1/node_modules/theme/dist/lib'
 @ ./node_modules/theme/dist/lib/apiClient.js 3:0-52 60:11-25
 @ ./node_modules/theme/dist/components/signIn/index.js
 @ ./node_modules/theme/dist/containers/shared.js
 @ ./node_modules/theme/dist/index.js
 @ multi theme

have the same issue, hope somebody can help, thanks


Adding missing descriptions

Closes https://github.com/MicrosoftDocs/office-docs-powershell/issues/5935

Docs Build status updates of commit bca62e0:
:clock10: Full build: the average full build time is 17 min(s) 37 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit bca62e0:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Get-ForeignConnector.md
:x:Error

Details

:x:Error

Details

exchange/exchange-ps/exchange/Get-ForeignConnector.md

[Error-PublishToDHSFailed] Publishing of document 'exchange/exchange-ps/exchange/Get-ForeignConnector.md' to document hosting service failed with asset id: module/exchange/get-foreignconnector locale: en-us, depot name: MSDN.exchange-ps, branch name: pr-en-us-6315. Error: A task was canceled.

[Error-BackendEngineExceptionError] An exception occurred during the build process. Please check the raw log and retry building your content again. If the issue persists, please open a ticket in https://SiteHelp and include the URL of publishing report as well as below information: Object reference not set to an instance of an object..

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d066caf:
:clock10: Full build: the average full build time is 17 min(s) 37 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit d066caf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOSiteUserInvitations.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ab62349:
:clock10: Full build: the average full build time is 17 min(s) 37 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit ab62349:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOSiteUserInvitations.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@Kateyanne Please merge this PR. Thanks.

Docs Build status updates of commit 3b1aa3d:
:clock10: Full build: the average full build time is 17 min(s) 37 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 3b1aa3d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOSiteUserInvitations.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 10e5827:
:clock10: Full build: the average full build time is 17 min(s) 37 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 10e5827:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOSiteUserInvitations.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a7a081c:
:clock10: Full build: the average full build time is 17 min(s) 37 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit a7a081c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOSiteUserInvitations.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


uORB: update msgs fields from camelCase to snake_case

Describe problem solved by the proposed pull request
In the process of developing a ROS2 package that will be interfacing PX4 with ROS2 through fast-RTPS, I found out that while trying to building the package with the respective ROS msg generation, rosidl_generate_interfaces() does not process msg fields which have uppercase letters.
Describe your preferred solution
This is an harmless PR which changes some message fields that have uppercase letters (or present a camelCase naming convention) so rosidl_generate_interfaces() is able to generate code for ROS IDL files. It basically replaces the uppercase with lowercase, and where required, change the naming convention to snake_case.
Describe possible alternatives
Not really much more we can do about it, unless one changes the copied file online during the build process, which is not really efficient.

Also, after this gets merged, I think it will make sense to actually have something like a schema validator for uORB msgs, so that we can make sure every new fields that is added follows the same convention (does make much sense to have fields following different naming conventions). This validator would run on CI as a new job, parallel to the style check job for example.
@dagar any thoughts?

Anything from the ROS world that already solves this problem?

Anything from the ROS world that already solves this problem?

No. This is actually a requirement for the message generation through ROS IDL generator python scripts.

Will be issuing a PR against Flight Review so to address these changes as well.

Changes on Flight Review addressed in https://github.com/PX4/flight_review/pull/123.

@TSC21 Can you add a change that breaks the build if someone re-introduces this? Like a check in the Python generator for PX4 uORB messages?

@TSC21 Can you add a change that breaks the build if someone re-introduces this? Like a check in the Python generator for PX4 uORB messages?

@LorenzMeier that's what I actually was referencing here https://github.com/PX4/Firmware/pull/10077#issuecomment-408704710. @dagar believes that clang-tidy could possibly handle this if we actually generate the headers and then do the check against those. Would that be a better option to a check in the Python generator?

@LorenzMeier done

@LorenzMeier thanks for merging. This does unblock the package development.


Simple RPC based service for PyZMQ

This adds an rpc subpackage to zmq and implements a "simple" RPC service.  This version is focused only on the request/reply pattern, but handles load balancing using ROUTER/DEALER sockets.  While we definitely want to explore richer RPC APIs that allow for arbitrary socket types and message patterns, this version is very useful because of its extreme simplicity and good performance..
Still working on:

Making the serialization approach pluggable.  I use pickle now, but will allow json and other approaches.
Adding an async client example.

Needs review:

Python3 compliance.
General API choices.

nice!
pluggable serialization will be a lot simpler if you just put serialize/deserialize in isolated methods, rather than bundling them in with dispatch.

Yes good idea, I will try to get that done tonight.
On Thu, Feb 16, 2012 at 5:05 PM, Min RK
<EMAIL_ADDRESS>wrote:

nice!
pluggable serialization will be a lot simpler if you just put serialize/deserialize in isolated methods, rather than bundling them in with dispatch.

Reply to this email directly or view it on GitHub:
https://github.com/zeromq/pyzmq/pull/174#issuecomment-4013232

--
Brian E. Granger
Cal Poly State University, San Luis Obispo
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

OK, I have made the serialization pluggable and added the async client example.  I have one design question about the async proxy object's api.  The current API looks like this:
echo.echo(callback, *args, **kwargs)

Where the callback is passed the result of the RPC call upon success and a RemoteRPCError instance upon failure.  Getting an exception instance is a bit odd, do you think it would be better to pass a pair of callback, errback functions instead?

There are two choices for serialization:

(what you chose) serialize directly to bytes.  This is obviously the easiest and most pluggable for serializing simple small data.
serialize to lists of bytes.  This is less pluggable, because it ~always requires subclasses to define their own function, rather than trivially providing a library function.

The first is easiest to write, and easiest to drop in new serialization, but only the second can give you zero-copy, because a zero-copy message invariably turns an object into two or more parts (metadata + buffer).
As for callback/errback, I don't think passing an Exception to the callback makes sense, so you should probably specify an errback.  Unfortunately, the signature you provided makes optionally specifying the errback impossible.  You could define a single errback at the class level.  I'm not sure how best to deal with that.
Something to consider: What happens when a worker never responds to a request?

I actually think we could get both 1+2 in the following manner.  If the serializer returns a list/tuple, send all element as message frames.  Otherwise just send the result.  On the deserialization side, if there is one message frame, pass that to the deserializer as is, otherwise pass a list of frames.  Do you think that will work?
On the errback:  what should the errback get passed?  Also, how do you think we should pass the original exception to the RemoteRPCException so the user to figure out what went wrong?
Not sure how to handle failures.  Would you integrate heartbeating?  What would that API look like on the client side of things?

I actually think we could get both 1+2 in the following manner. If the serializer returns a list/tuple, send all element as message frames. Otherwise just send the result. On the deserialization side, if there is one message frame, pass that to the deserializer as is, otherwise pass a list of frames. Do you think that will work?

Hm, not really.  It would only work if you require that a list-returning serializer never returns a list of length 1.  Also, the more black-box approach should probably be passed both args and kwargs, rather than getting them separately, because how are you going to determine how many frames should be passed to the args deserializer, and how many should be passed for kwargs?

On the errback: what should the errback get passed? Also, how do you think we should pass the original exception to the RemoteRPCException so the user to figure out what went wrong?

Probably the same thing we do in IPython - ename, evalue, traceback as strs.

Not sure how to handle failures. Would you integrate heartbeating? What would that API look like on the client side of things?

I would skip heartbeats, and just use timeouts.  This would mean requests would need to discard replies with the wrong msg_id, as they would be stale replies from timed out requests.

OK I think I have fixed everything.  For the serialization I created a Serializer object that supports both full blown customization as well as the simpler approach.  I like how that part of it turned out.
I have implemented errback and timeout and added relevant examples.
Only one more question: is there anything I need to do to target Python 3.0 that you can see?

Not sure if there's room for more serializers, especially ones which add more dependencies, but I threw together a symmetric cipher serializer here in an example https://gist.github.com/1911540.

@minrk: what do you think about including this serializer?  If we include this, it might be nice to improve the API of the base class to handle loads/dumps separately from the encrypt/decrypt.  The reason for this is that it would be useful to change the serialization without changing the encryption and vice versa.

I think it's a useful example, showing how to do subclassing for your own serialization/encryption, so it should go in examples.  I don't think encrypt/decrypt should be separate from serialize/deserialize.
I wouldn't want to give anyone the illusion that this code is secure, since it makes no protection against fuzz attacks, or any such thing.

I think the encryption itself is sound save for the trivial key. You're right about the security issues since there's no effort to sanitize user inputs. It would not be a lot more work to use a library like Flatland to ensure user input is sane. I could improve the example to do that if you think its worth it.

I think the example is good as it is, and helpful for users who want to write derivatives with their own serialization and/or encryption.  Simple error handling when unpacking messages should be done in the RPC code itself.

OK, can you create a new pull request that puts the serializer example
in examples/web?
On Sun, Feb 26, 2012 at 8:16 PM, Min RK
<EMAIL_ADDRESS>wrote:

I think the example is good as it is, and helpful for users who want to write derivatives with their own serialization and/or encryption.  Simple error handling when unpacking messages should be done in the RPC code itself.

Reply to this email directly or view it on GitHub:
https://github.com/zeromq/pyzmq/pull/174#issuecomment-4187779

--
Brian E. Granger
Cal Poly State University, San Luis Obispo
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

@minrk: this one is ready to go as well.  I can do the merge if you want.

I still don't like the fact that you have to specify callback, errback, and timeout every time.  That seems pretty annoying and un-pythonic.  Can you think of a way to make errback and timeout optional args?

If we want to pass *args and **kwargs, we can't really use keywords
arguments.  We could switch to the form:
call(func, callback=None, errback=None, timeout=-1, args=None, kwargs=None)
And force people to pass tuple and dicts for args, kwargs.  Which do you prefer?
On Mon, Feb 27, 2012 at 12:00 PM, Min RK
<EMAIL_ADDRESS>wrote:

I still don't like the fact that you have to specify callback, errback, and timeout every time.  That seems pretty annoying and un-pythonic.  Can you think of a way to make errback and timeout optional args?

Reply to this email directly or view it on GitHub:
https://github.com/zeromq/pyzmq/pull/174#issuecomment-4201679

--
Brian E. Granger
Cal Poly State University, San Luis Obispo
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

mmh, this is always a decision we have to make - is passing *args, **kwargs nice enough that it is worth requiring multiple extra arguments that are rarely used be specified every time.  We sidestep this in IPython.parallel by setting defaults via attributes.  This sort of approach might make sense, at least where errback/timeout are concerned, for which the values will likely be the same for every single call for a given RPC instance.

As one who really wants to use this rpc library, I would not want the apparent interface to expose any inability to just call functions via the proxy. Forcing the users to use args=, kwargs= is pretty rough.
I like the idea of setting these values on a class if you can allow users to pass their own class to use for method wrapping. Its unlikely a user would want these values to change for specific functions.

But I don't think the class default solves the issue in this case
because callback and errback will likely change from call to call.  I
guess I am probably leaning towards keeping it the same as it is.
On Mon, Feb 27, 2012 at 8:16 PM, Dan Colish
<EMAIL_ADDRESS>wrote:

As one who really wants to use this rpc library, I would not want the apparent interface to expose any inability to just call functions via the proxy. Forcing the users to use args=, kwargs= is pretty rough.
I like the idea of setting these values on a class if you can allow users to pass their own class to use for method wrapping. Its unlikely a user would want these values to change for specific functions.

Reply to this email directly or view it on GitHub:
https://github.com/zeromq/pyzmq/pull/174#issuecomment-4209359

--
Brian E. Granger
Cal Poly State University, San Luis Obispo
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Compromise: just pull timeout off to an attribute?  It seems extremely unlikely that this would ever change within a given application.  I still think errback is likely to be None the majority of the time, and it seems like a poor Python interface that forces you to specify None as the second arg every time you call it.  But forcing you to specify it encourages people to think about error handling, which I suppose is a good thing.
We have already discovered that there's no such thing as a really good interface that accepts **kwargs and supports optional behavior.

OK license is updated.


chore(release): 1.7.0

1.7.0 (2020-07-15)
Features

Link Component (#309) (2879bec)

Bug Fixes

address all lint warnings (#319) (95a12a3)
refactor menu, megamanu; removes deprecation warnings from tests (#313) (42e2481)

Warnings

:warning:

Changes were made to package.json, but not to yarn.lock - Perhaps you need to run yarn install?

  Generated by :no_entry_sign: dangerJS against 0c746a5bf681680583df1800001c04e060169f9c


bug: fixed prompt to generate recipe

Note:

All tests pass
Prompt is the same

closes #83

Looks good to me. This prompt change should help fix recipe generation issues. This merge closes #83


Splitting the workbook tabs to separate workbooks

PR Checklist

Log Analytics Workspace Insights workbook will be referencing separate workbooks, which are committed in the PR.
Agents:

Overview:

Usage:

Health:

Change log:

Query audit:

@noakup should there be a github team that owns this in CODEOWNERS?  right now it just has the default ownership of the workbooks team, should this PR also update that?

Anytime where you have a blank row, you can do fill out the Rows labelled by and hide the for you're labelling by

@Yves where is this image from? it looks old, I can't find it.

@noa, this is on the AtResource template, under Health tab

I will update that workbook once the individual templates are in, to link to them instead of showing the current content. So it won't show that anymore.

@yves-chan can you merge this please?


Revert 4605802

Revert 4605802. Fixes #2411. Ref #1171
/review @Duhemm, @dwijnand

Sad days. LGTM.

After applying https://github.com/sbt/sbt/pull/2414, the test case in  https://github.com/eed3si9n/sbt/commit/1f25cdf0cdc5f0e47464a1f8b4541da87aca0889 compiles and run successfully, however I was able to reproduce the problem by changing the testcase to involve a derived value class:
package example

class VC(val self: Int) extends AnyVal

class A {
  case class B(x: VC)
  def c = B
}
object A {
  def main(args: Array[String]): Unit = {
    (new A).c
  }
}

I suggest using this as a testcase instead. I can't help with the actual bug but my guess is that it has something to do with exitingPostErasure and https://github.com/scala/scala/commit/6dd149505d6782d35655cfd76e573e7fbeaecb77 might help, cc @adriaanm

It looks like using the changes in https://github.com/scala/scala/commit/6dd149505d6782d35655cfd76e573e7fbeaecb77 fixes the issue for both test cases in this ticket. Do we want to revert #2261 altogether or apply the fix by @adriaanm?
I created a branch with the test cases and the fix by @adriaanm:  https://github.com/sbt/sbt/compare/0.13...Duhemm:fix-2411

@Duhemm  If you can fix this, I am ok with keeping this feature. Could you test with the projects mentioned by the original tickets:
https://travis-ci.org/xuwei-k/Play20/jobs/104261656#L497
https://travis-ci.org/xuwei-k/scalikejdbc/jobs/104293183#L1193
https://travis-ci.org/seratch/skinny-framework/jobs/104275385#L2107
https://travis-ci.org/xuwei-k/cats/jobs/104294044#L2702

@eed3si9n Of course.

If possible please forward fix. Reverts are more work in this forward-porting, multi-repo world.

Closing this in favor of #2418


[feature]: FormView toggle / checkbox fields

Is your feature request related to a problem? Please describe.
Currently FormView only has Text, Date, Dropdown.
Is there any planned support for other types like Toggle / Checkbox, Dropdown with search, Radio, Multiselect
Instead of reinventing the wheel, can Stacked work with other components from ecosystem like

flutter_form_builder
dropdown_search
multi_select_flutter

These are just recommendations.
Describe the solution you would like
FormView to have other required form fields ether developed internally or work with other popular packages
Additional Context
No response

Hi, no.
At the moment there is no plans to support text editing.
We're not trying to reivent the wheel, instead we want to do the exact opposite. We built it so that it's usable with every single form building out there.
We ONLY sync values between the textController and the ViewModel, we don't do anything else.
So you can use that text controller with literally any package that you like, we just make sure the text data is available in the ViewModel when needed. No UI functionality will be added to Stacked's form functionality.


All Groups empty after recreating them

hi there,
ive got a strange issue with current dev/master. All groups are gone after i did recreate them. I do assume it's a caching problem, since they are still present in DataBase.

Table content:

ADD: altho, i did try to restart jmm-server, but the groups where still gone. After i restored a backup, the groups are back again.

This is something we'd like to know.... Run it again and post the log for it.

allright, i did recreate them: in log there was indeed an exception during group recreation:
Server-Log:
2016-10-27.txt

@pmcleish tagging so you'll see it
I'll look at it and see if it's simple
[2016-10-27 18:32:44:220] Error|JMMServiceImplementation.RecreateAllGroups
=> AnimeGroupCreator.RecreateAllGroups =>
AnimeGroupCreator.RecreateAllGroups An error occurred while re-creating all
groups
[2016-10-27 18:32:44:236] Error|SyncMethodInvoker.Invoke => <no
type>.SyncInvokeRecreateAllGroups =>
JMMServiceImplementation.RecreateAllGroups System.AggregateException: One
or more errors occurred. ---> System.ArgumentNullException: Value cannot be
null.
Parameter name: parentImage
   at
JMMServer.Repositories.DefaultAnimeImage..ctor(AniDB_Anime_DefaultImage
aniDbImage, IImageEntity parentImage) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
303
   at
JMMServer.Repositories.AniDB_AnimeRepository.GetDefaultImagesByAnime(ISessionWrapper
session, Int32[] animeIds) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
217
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at JMMServer.Entities.AnimeSeries.BatchUpdateContracts(ISessionWrapper
session, IReadOnlyCollection`1 seriesBatch, Boolean onlyStats) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Entities\AnimeSeries.cs:line 677
   at
JMMServer.Tasks.AnimeGroupCreator.<>c.<UpdateAnimeSeriesContractsAndSave>b__15_1(AnimeSeries[]
seriesBatch, ParallelLoopState state, IStatelessSession localSession) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
112
   at
System.Threading.Tasks.Parallel.<>c__DisplayClass42_0`2.<PartitionerForEachWorker>b__1()
   at System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
   at
System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object
)
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean
includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout,
CancellationToken cancellationToken)
   at
System.Threading.Tasks.Parallel.PartitionerForEachWorker[TSource,TLocal](Partitioner`1
source, ParallelOptions parallelOptions, Action`1 simpleBody, Action`2
bodyWithState, Action`3 bodyWithStateAndIndex, Func`4
bodyWithStateAndLocal, Func`5 bodyWithEverything, Func`1 localInit,
Action`1 localFinally)
   at
System.Threading.Tasks.Parallel.ForEachWorker[TSource,TLocal](IEnumerable`1
source, ParallelOptions parallelOptions, Action`1 body, Action`2
bodyWithState, Action`3 bodyWithStateAndIndex, Func`4
bodyWithStateAndLocal, Func`5 bodyWithEverything, Func`1 localInit,
Action`1 localFinally)
   at System.Threading.Tasks.Parallel.ForEach[TSource,TLocal](IEnumerable`1
source, ParallelOptions parallelOptions, Func`1 localInit, Func`4 body,
Action`1 localFinally)
   at
JMMServer.Tasks.AnimeGroupCreator.UpdateAnimeSeriesContractsAndSave(ISessionWrapper
session, IReadOnlyCollection`1 series) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
116
   at JMMServer.Tasks.AnimeGroupCreator.RecreateAllGroups(ISessionWrapper
session) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
460
   at JMMServer.Tasks.AnimeGroupCreator.RecreateAllGroups() in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
475
   at JMMServer.JMMServiceImplementation.RecreateAllGroups(Boolean resume)
in
F:\Projects\ThirdParty\jmmserver\JMMServer\JMMServiceImplementation.cs:line
7995
---> (Inner Exception #0) System.ArgumentNullException: Value cannot be
null.
Parameter name: parentImage
   at
JMMServer.Repositories.DefaultAnimeImage..ctor(AniDB_Anime_DefaultImage
aniDbImage, IImageEntity parentImage) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
303
   at
JMMServer.Repositories.AniDB_AnimeRepository.GetDefaultImagesByAnime(ISessionWrapper
session, Int32[] animeIds) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
217
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at JMMServer.Entities.AnimeSeries.BatchUpdateContracts(ISessionWrapper
session, IReadOnlyCollection`1 seriesBatch, Boolean onlyStats) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Entities\AnimeSeries.cs:line 677
   at
JMMServer.Tasks.AnimeGroupCreator.<>c.<UpdateAnimeSeriesContractsAndSave>b__15_1(AnimeSeries[]
seriesBatch, ParallelLoopState state, IStatelessSession localSession) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
112
   at
System.Threading.Tasks.Parallel.<>c__DisplayClass42_0`2.<PartitionerForEachWorker>b__1()
   at System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
   at
System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object
)<---

---> (Inner Exception #1) System.ArgumentNullException: Value cannot be
null.
Parameter name: parentImage
   at
JMMServer.Repositories.DefaultAnimeImage..ctor(AniDB_Anime_DefaultImage
aniDbImage, IImageEntity parentImage) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
303
   at
JMMServer.Repositories.AniDB_AnimeRepository.GetDefaultImagesByAnime(ISessionWrapper
session, Int32[] animeIds) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
217
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at JMMServer.Entities.AnimeSeries.BatchUpdateContracts(ISessionWrapper
session, IReadOnlyCollection`1 seriesBatch, Boolean onlyStats) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Entities\AnimeSeries.cs:line 677
   at
JMMServer.Tasks.AnimeGroupCreator.<>c.<UpdateAnimeSeriesContractsAndSave>b__15_1(AnimeSeries[]
seriesBatch, ParallelLoopState state, IStatelessSession localSession) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
112
   at
System.Threading.Tasks.Parallel.<>c__DisplayClass42_0`2.<PartitionerForEachWorker>b__1()
   at System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
   at
System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object
)<---

@pmcleish tagging so you'll see it
I'll look at it and see if it's simple
[2016-10-27 18:32:44:220] Error|JMMServiceImplementation.RecreateAllGroups
=> AnimeGroupCreator.RecreateAllGroups =>
AnimeGroupCreator.RecreateAllGroups An error occurred while re-creating all
groups
[2016-10-27 18:32:44:236] Error|SyncMethodInvoker.Invoke => <no
type>.SyncInvokeRecreateAllGroups =>
JMMServiceImplementation.RecreateAllGroups System.AggregateException: One
or more errors occurred. ---> System.ArgumentNullException: Value cannot be
null.
Parameter name: parentImage
   at
JMMServer.Repositories.DefaultAnimeImage..ctor(AniDB_Anime_DefaultImage
aniDbImage, IImageEntity parentImage) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
303
   at
JMMServer.Repositories.AniDB_AnimeRepository.GetDefaultImagesByAnime(ISessionWrapper
session, Int32[] animeIds) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
217
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at JMMServer.Entities.AnimeSeries.BatchUpdateContracts(ISessionWrapper
session, IReadOnlyCollection`1 seriesBatch, Boolean onlyStats) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Entities\AnimeSeries.cs:line 677
   at
JMMServer.Tasks.AnimeGroupCreator.<>c.<UpdateAnimeSeriesContractsAndSave>b__15_1(AnimeSeries[]
seriesBatch, ParallelLoopState state, IStatelessSession localSession) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
112
   at
System.Threading.Tasks.Parallel.<>c__DisplayClass42_0`2.<PartitionerForEachWorker>b__1()
   at System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
   at
System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object
)
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean
includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout,
CancellationToken cancellationToken)
   at
System.Threading.Tasks.Parallel.PartitionerForEachWorker[TSource,TLocal](Partitioner`1
source, ParallelOptions parallelOptions, Action`1 simpleBody, Action`2
bodyWithState, Action`3 bodyWithStateAndIndex, Func`4
bodyWithStateAndLocal, Func`5 bodyWithEverything, Func`1 localInit,
Action`1 localFinally)
   at
System.Threading.Tasks.Parallel.ForEachWorker[TSource,TLocal](IEnumerable`1
source, ParallelOptions parallelOptions, Action`1 body, Action`2
bodyWithState, Action`3 bodyWithStateAndIndex, Func`4
bodyWithStateAndLocal, Func`5 bodyWithEverything, Func`1 localInit,
Action`1 localFinally)
   at System.Threading.Tasks.Parallel.ForEach[TSource,TLocal](IEnumerable`1
source, ParallelOptions parallelOptions, Func`1 localInit, Func`4 body,
Action`1 localFinally)
   at
JMMServer.Tasks.AnimeGroupCreator.UpdateAnimeSeriesContractsAndSave(ISessionWrapper
session, IReadOnlyCollection`1 series) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
116
   at JMMServer.Tasks.AnimeGroupCreator.RecreateAllGroups(ISessionWrapper
session) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
460
   at JMMServer.Tasks.AnimeGroupCreator.RecreateAllGroups() in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
475
   at JMMServer.JMMServiceImplementation.RecreateAllGroups(Boolean resume)
in
F:\Projects\ThirdParty\jmmserver\JMMServer\JMMServiceImplementation.cs:line
7995
---> (Inner Exception #0) System.ArgumentNullException: Value cannot be
null.
Parameter name: parentImage
   at
JMMServer.Repositories.DefaultAnimeImage..ctor(AniDB_Anime_DefaultImage
aniDbImage, IImageEntity parentImage) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
303
   at
JMMServer.Repositories.AniDB_AnimeRepository.GetDefaultImagesByAnime(ISessionWrapper
session, Int32[] animeIds) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
217
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at JMMServer.Entities.AnimeSeries.BatchUpdateContracts(ISessionWrapper
session, IReadOnlyCollection`1 seriesBatch, Boolean onlyStats) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Entities\AnimeSeries.cs:line 677
   at
JMMServer.Tasks.AnimeGroupCreator.<>c.<UpdateAnimeSeriesContractsAndSave>b__15_1(AnimeSeries[]
seriesBatch, ParallelLoopState state, IStatelessSession localSession) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
112
   at
System.Threading.Tasks.Parallel.<>c__DisplayClass42_0`2.<PartitionerForEachWorker>b__1()
   at System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
   at
System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object
)<---
---> (Inner Exception #1) System.ArgumentNullException: Value cannot be
null.
Parameter name: parentImage
   at
JMMServer.Repositories.DefaultAnimeImage..ctor(AniDB_Anime_DefaultImage
aniDbImage, IImageEntity parentImage) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
303
   at
JMMServer.Repositories.AniDB_AnimeRepository.GetDefaultImagesByAnime(ISessionWrapper
session, Int32[] animeIds) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Repositories\Cached\AniDB_AnimeRepository.cs:line
217
   at System.Lazy`1.CreateValue()
   at System.Lazy`1.LazyInitValue()
   at JMMServer.Entities.AnimeSeries.BatchUpdateContracts(ISessionWrapper
session, IReadOnlyCollection`1 seriesBatch, Boolean onlyStats) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Entities\AnimeSeries.cs:line 677
   at
JMMServer.Tasks.AnimeGroupCreator.<>c.<UpdateAnimeSeriesContractsAndSave>b__15_1(AnimeSeries[]
seriesBatch, ParallelLoopState state, IStatelessSession localSession) in
F:\Projects\ThirdParty\jmmserver\JMMServer\Tasks\AnimeGroupCreator.cs:line
112
   at
System.Threading.Tasks.Parallel.<>c__DisplayClass42_0`2.<PartitionerForEachWorker>b__1()
   at System.Threading.Tasks.Task.InnerInvokeWithArg(Task childTask)
   at
System.Threading.Tasks.Task.<>c__DisplayClass176_0.<ExecuteSelfReplicating>b__0(Object
)<---

EDIT: apparently email replies don't support code blocks

As a quick look, either I've messed up the query in AniDB_AnimeRepository.GetDefaultImagesByAnime (e.g. I'm joining on the wrong column, or I got the image type wrong), or the ImageParentType is set to a value that isn't correct.
I'll try and replicate it shortly. There are a couple of possible "fixes" if the data is causing the issue which are pretty easy. Or, if the query is incorrect, then that should be pretty simple to fix as well.

I know I can't reproduce it, but that prolly just means my db doesn't hit the edge case, or through my excessive regeneration of contracts, a value that may not always filled, I have filled all of them.

Should be fixed in #498

tested. But still fails. This time due to an SQL error:

[2016-10-28 15:50:00:647] Info|JMMServiceImplementation.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups Beginning re-creation of all groups
[2016-10-28 15:50:00:653] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.ClearGroupsAndDependencies Removing existing AnimeGroups and resetting GroupFilters
[2016-10-28 15:50:00:732] Warn|BackgroundWorker.OnDoWork => CommandProcessorImages.workerCommands_DoWork => CommandRequest_DownloadImage.ProcessCommand Error processing CommandRequest_DownloadImage: https://walter.trakt.us/images/shows/000/102/282/fanarts/original/17ed474469.jpg (618) - The remote server returned an error: (403) Forbidden.
[2016-10-28 15:50:01:097] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.ClearGroupsAndDependencies AnimeGroups have been removed and GroupFilters have been reset
[2016-10-28 15:50:01:113] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.CreateGroupPerSeries Generating AnimeGroups for 1836 AnimeSeries
[2016-10-28 15:50:01:964] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.CreateGroupPerSeries Generated 1836 AnimeGroups
[2016-10-28 15:50:01:964] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.UpdateAnimeSeriesContractsAndSave Updating contracts for AnimeSeries
[2016-10-28 15:50:06:089] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.UpdateAnimeSeriesContractsAndSave AnimeSeries contracts have been updated
[2016-10-28 15:50:06:724] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.UpdateAnimeGroupsAndTheirContracts Updating statistics and contracts for AnimeGroups
[2016-10-28 15:50:19:181] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.UpdateAnimeGroupsAndTheirContracts AnimeGroup statistics and contracts have been updated
[2016-10-28 15:50:19:182] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.UpdateAnimeGroupsAndTheirContracts Creating AnimeGroup_Users and updating plex/kodi contracts
[2016-10-28 15:50:37:154] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.UpdateAnimeGroupsAndTheirContracts AnimeGroup_Users have been created
[2016-10-28 15:50:38:012] Info|AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.UpdateGroupFilters Updating Group Filters
[2016-10-28 15:51:23:012] Error|JMMServiceImplementation.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups => AnimeGroupCreator.RecreateAllGroups An error occurred while re-creating all groups
[2016-10-28 15:51:24:531] Error|SyncMethodInvoker.Invoke => .SyncInvokeRecreateAllGroups => JMMServiceImplementation.RecreateAllGroups NHibernate.Exceptions.GenericADOException: could not execute query
[ SELECT DISTINCT grpFilter.GroupFilterID, grp.AnimeGroupID
FROM AnimeGroup grp
INNER JOIN AnimeSeries series
ON series.AnimeGroupID = grp.AnimeGroupID
INNER JOIN AniDB_Anime_Tag anidbTag
ON anidbTag.AnimeID = series.AniDB_ID
INNER JOIN AniDB_Tag tag
ON tag.TagID = anidbTag.TagID
INNER JOIN GroupFilter grpFilter
ON grpFilter.GroupFilterName = tag.TagName
AND grpFilter.FilterType = ?p0
ORDER BY grpFilter.GroupFilterID, grp.AnimeGroupID ]
Name:tagType - Value:16
[SQL: SELECT DISTINCT grpFilter.GroupFilterID, grp.AnimeGroupID
FROM AnimeGroup grp
INNER JOIN AnimeSeries series
ON series.AnimeGroupID = grp.AnimeGroupID
INNER JOIN AniDB_Anime_Tag anidbTag
ON anidbTag.AnimeID = series.AniDB_ID
INNER JOIN AniDB_Tag tag
ON tag.TagID = anidbTag.TagID
INNER JOIN GroupFilter grpFilter
ON grpFilter.GroupFilterName = tag.TagName
AND grpFilter.FilterType = ?p0
ORDER BY grpFilter.GroupFilterID, grp.AnimeGroupID] ---> MySql.Data.MySqlClient.MySqlException: Timeout expired.  The timeout period elapsed prior to completion of the operation or the server is not responding. ---> System.TimeoutException: Timeout in IO operation
at MySql.Data.MySqlClient.TimedStream.StopTimer()
at MySql.Data.MySqlClient.TimedStream.Read(Byte[] buffer, Int32 offset, Int32 count)
at System.IO.BufferedStream.Read(Byte[] array, Int32 offset, Int32 count)
at MySql.Data.MySqlClient.MySqlStream.ReadFully(Stream stream, Byte[] buffer, Int32 offset, Int32 count)
at MySql.Data.MySqlClient.MySqlStream.LoadPacket()
at MySql.Data.MySqlClient.MySqlStream.ReadPacket()
at MySql.Data.MySqlClient.NativeDriver.GetResult(Int32& affectedRow, Int64& insertedId)
at MySql.Data.MySqlClient.Driver.NextResult(Int32 statementId, Boolean force)
at MySql.Data.MySqlClient.MySqlDataReader.NextResult()
at MySql.Data.MySqlClient.MySqlCommand.ExecuteReader(CommandBehavior behavior)
--- End of inner exception stack trace ---
at MySql.Data.MySqlClient.ExceptionInterceptor.Throw(Exception exception)
at MySql.Data.MySqlClient.MySqlConnection.HandleTimeoutOrThreadAbort(Exception ex)
at MySql.Data.MySqlClient.MySqlCommand.ExecuteReader(CommandBehavior behavior)
at NHibernate.AdoNet.AbstractBatcher.ExecuteReader(IDbCommand cmd)
at NHibernate.Loader.Loader.GetResultSet(IDbCommand st, Boolean autoDiscoverTypes, Boolean callable, RowSelection selection, ISessionImplementor session)
at NHibernate.Loader.Loader.DoQuery(ISessionImplementor session, QueryParameters queryParameters, Boolean returnProxies, IResultTransformer forcedResultTransformer)
at NHibernate.Loader.Loader.DoQueryAndInitializeNonLazyCollections(ISessionImplementor session, QueryParameters queryParameters, Boolean returnProxies, IResultTransformer forcedResultTransformer)
at NHibernate.Loader.Loader.DoList(ISessionImplementor session, QueryParameters queryParameters, IResultTransformer forcedResultTransformer)
--- End of inner exception stack trace ---
at NHibernate.Loader.Loader.DoList(ISessionImplementor session, QueryParameters queryParameters, IResultTransformer forcedResultTransformer)
at NHibernate.Loader.Loader.ListIgnoreQueryCache(ISessionImplementor session, QueryParameters queryParameters)
at NHibernate.Impl.StatelessSessionImpl.ListCustomQuery(ICustomQuery customQuery, QueryParameters queryParameters, IList results)
at NHibernate.Impl.AbstractSessionImpl.List(NativeSQLQuerySpecification spec, QueryParameters queryParameters, IList results)
at NHibernate.Impl.AbstractSessionImpl.List[T](NativeSQLQuerySpecification spec, QueryParameters queryParameters)
at NHibernate.Impl.SqlQueryImpl.ListT
at JMMServer.Repositories.Cached.GroupFilterRepository.CalculateAnimeGroupsPerTagGroupFilter(ISessionWrapper session)
at JMMServer.Tasks.AnimeGroupCreator.UpdateGroupFilters(ISessionWrapper session)
at JMMServer.Tasks.AnimeGroupCreator.RecreateAllGroups(ISessionWrapper session)
at JMMServer.Tasks.AnimeGroupCreator.RecreateAllGroups()
at JMMServer.JMMServiceImplementation.RecreateAllGroups(Boolean resume)
<

Can you add
3 ` and a return before and after that log block

I will test this again now, just to be sure. I have to say, i got quite a large DB too ~2k Series. So maybe the time the SQL takes to too long, because the amount of rows to fetch and process.

by chance, i got a heavy query already: with filtertype 16, it took 35 sec to execute that query. I will try some more

We might need to increase the wait time for it up to about 2 minutes

ON grpFilter.GroupFilterName = tag.TagName There is a join on Text data, which is not very fast - but i found there is an index missing on Table Anidb_tag.TagName. Maybe with an index there, it might be a bit faster. I will add one, and test again.

Ah OK it was a good idea, but steering ordinal equality isn't really slow

Yea. Only if there had been a LIKE search or something.  :)

I just tested that query in MySQL (It works fine in SQL Server and SQLite when I tested) and it is indeed a lot slower. I added the following index:
CREATE INDEX IX_groupfilter_GroupFilterName ON groupfilter (GroupFilterName);
And the query executes pretty much instantaneous for me (My test database has 1123 series).
Can someone else verify?
I've also just ran the Recreate All Groups operation and it executed successfully in about 20 second (with the above index), so assuming linear timings, 2000+ series might take about 40s or so for MySQL. From my testing, I've found that both SQL Server and SQLite seem to get the job done in about half the time compared to MySQL (not sure why).

Hm, that is strange. I'm running MariaDB 10.1.17 and the query takes roughly 30s. I will try mySQL Server now.

Keep in mind we don't officially support MariaDB so it's possible your error is related to it.

@t0815 Is that 30s with or without the index I mentioned?

@pmcleish even with index. I did uninstall MariaDB and installed mySQL, setting everything up again. Then retest this. I'll report back when finished.

oh my. with latest mySQL 5.6 the query takes even longer lol. Whooping 50s.
GroupFilterName already had an index (Fulltext).

ok, i did re-add the index on  Anidb_tag.TagName, and i got it down to 17s now.

Ah, I've found out why the index worked fine for me with the 500 char length. It seems I have the innodb_large_prefix option enabled which allows up to 3072 bytes for index prefixes (I rarely use mySQL, so wasn't aware of the limits).
@ElementalCrisis Can you see any potential issues with changing the GroupFilter.GroupFilterName column to be say 300 chars? (The longest anime title in my DB is 139 chars).
Another possible option is that mySQL supports index prefixes which allows you to index just the first N chars of a string. This would allow retaining the current column size and have an index that has a shorter length than the limit.
If we go with the column resize, we'd have to apply schema updates to all 3 supported databases to keep them in sync. If we go with the prefix limited index, we'd only need a schema update for mySQL.
Let me know which option you'd prefer and I can go ahead and add the schema update.

@pmcleish : only quick heads up, even 300 chars would be too much, since its UTF-8, so each char is 3 bytes long (300 x 3 > 767) therefore won't fit either, :) .

Thanks for that. I'm used to MS SQL Server which has 2 bytes per NCHAR. I'll have to figure out how to turn off the innodb_large_prefix option to make sure I get it right. In which case 250 is a nice round number and should be more than large enough.

@pmcleish Whatever option you think is best I'd say go for it. We just need to make sure that our solution won't cause any issues in the future.
I also looked in my DB and the longest title I have (in Romaji) is a Dragon Ball Z movie
Any input @maxpiva?

I'll going to reopen this until it is verified 'fixed' by @t0815

Tested, issue resolved.


Login from different device

a login from another device functionality would be cool. maybe with a qr code scan oder just like a plain od 2fa or sth.

Duplicate of #553


Fix tests & and issue working with invalid ecto changeset

Fixes tests

graphql supports booleans, so they should not be stringified
Modified test looking up evaluate_graphql method in module

Fixed support for invalid change sets

opened too soon


update README

Add explication how the setup works and how it can be used.
Signed-off-by: Alice Frosi<EMAIL_ADDRESS>

/lgtm


transitionDelay missing from NavOptions

Short description of the problem:
While pushing a Nav, the options parameter used to have a transitionDelay property, which is now missing. I need that for transition animation.
What behavior are you expecting?
nav.push(component, params, {transitionDelay: 800}) should be a valid code
Steps to reproduce:

Create a navigation between two components
Add code referred above
Navigate in app, no delay is performed

export interface NavOptions {
    animate?: boolean;
    animation?: string;
    direction?: string;
    duration?: number;
    easing?: string;
    id?: string;
    keyboardClose?: boolean;
    progressAnimation?: boolean;
    ev?: any;
    updateUrl?: boolean;
    isNavRoot?: boolean;
}

Which Ionic Version? 2.x

This was removed because navigation was refactored. The navigation are no longer async, so we do not need that delay anymore.

Just use setTimeout to add a delay in case you need it

@mhartington I did that. Also added duration: 0 and reduced the Timeout delay.
I didn't find it in documentation or changelogs


Conflict: Multiple assets emit different content to the same filename

System Info
System:
OS: macOS 13.4
CPU: (10) arm64 Apple M1 Pro
Memory: 39.06 MB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.16.0 - ~/Library/Caches/fnm_multishells/80406_1688879568209/bin/node
Yarn: 1.22.19 - ~/Library/Caches/fnm_multishells/80406_1688879568209/bin/yarn
npm: 9.5.1 - ~/Library/Caches/fnm_multishells/80406_1688879568209/bin/npm
pnpm: 8.6.6 - ~/Library/Caches/fnm_multishells/80406_1688879568209/bin/pnpm
Browsers:
Safari: 16.5
Details
remove and undo a image (asset/resource) will cause this issue in dev server

Reproduce link
https://github.com/Shad02w/rspack-asset-resource-hmr-repo
Reproduce Steps

run pnpm dev
go to src/App.tsx
comment img tag at line 12 and save it
uncomment img tag
devServer throw error

Tracking at https://github.com/web-infra-dev/rspack/issues/3554

Tracking at #3554

Please track here.


Avoid hard-coding Timezone names

This also updates the database files to the latest version, 2024a

Hi,
I noticed that your implementation uses the natsort library. This library is not a standard library and requires the installation of an additional dependency. It would be better to either avoid using non-standard libraries or ensure to include the dependency installation instructions in the documentation.
Best regards.


Can't run spacy efficiently with sectionizer turned on

Adding the sectionizer to a pipeline makes it non-picklable, which prevents us from using multiprocessing / n_process argument.
`import spacy
from medspacy.section_detection import Sectionizer
nlp = spacy.load("en")
sect = Sectionizer(nlp, patterns="path_to_patterns")
nlp.add_pipe(sect)
for x in nlp.pipe(["this is text 1", "this is text 2"], n_process=2):
print(x)
PicklingError: Can't pickle <function  at 0x7f9337addb80>: attribute lookup  on medspacy.section_detection.sectionizer failed`

Hi, thanks for reporting this. I had also run into pickling errors when deploying this for our own projects. As a temporary workaround if your deployment is crucial, I have deployed multiple instances of the pipeline where n_process=1.
Otherwise, we are making a new release of medspacy in the next few days that we hope resolves this for future deployments.

After looking at this a little more closely, we think this will be a little more effort to implement, and will also apply to other components. I think it has to do with spaCy's serialization methods, which we haven't implemented yet for our pipeline components.
I'm going to close this ticket and move over to #36 so that this applies to all components, not just the Sectionizer. Thank you for reporting this! This is an important improvement to make.


[BOUNTY] MetaMask Snaps Bounty - extend the functionality of MetaMask

MetaMask Snaps Bounty - prize $800
Extend the functionality of MetaMask. The most popular wallet is now an extensible platform for permissionless innovation. Bring your features and APIs to MetaMask with Snaps.
A Snap is a program run in an isolated environment that customizes and extends the wallet experience. We are looking for new and interesting use cases to modify MetaMask using Snaps.
Prompt ideas
Anything Snaps 🤘

Open-ended call for the development of Snaps to customize/extend the MetaMask wallet experience

Transaction insights ⚠

Develop a Snap using the transaction insights API

If you can dream it, you can build it with the guide!
Additional Resources 🌐

Snaps How To Guide
Developer Docs
Getting Started

How to qualify? ☑
If you want to qualify and compete for prize:

Fulfill the requirements below
Post a comment with a link to your hackathon project submission on the devfolio below this issue
Do it before submission deadline - Sun, Nov 13, 11AM Prague time

Requirements ⚖

Novel - We are looking for new and interesting use cases made possible only via the Snaps platform. Snaps must extend wallet functionality in a meaningful way. Simple use cases where the dapp could have existed without a Snap will not be awarded.
Derp - Repos must contain a text file named “history.txt” with the phrase “The Brno Dragon was a crocodile!” This attention to detail helps us reward genuine effort and identify quality projects.
Monorepo - Use a monorepo structure (scaffold projects with the guide or the CLI to get started). Feel free to construct a more complex front-end React.
README - README should detail what the project is, what it aims to accomplish, steps for running locally etc.
Run It - Submissions must hosted or runnable locally

Prize 🏆
Bounty total $800 (Split across winners)

Get technical support from the core MetaMask Snaps team on Discord

Hello!
We were using the MetaMask Snaps Transaction Insights as the main feature for our Hackaton Project MetaRate.
All the work was done at the Hackaton, only the Readme files were changed today for the better readablity.
Here is the links for the repo and Devfolio:
https://github.com/bobetbat/reporter-snap
https://devfolio.co/projects/metarate-7c20


Avatar sync on registration step

As discussed here #55 the support for sync avatar should be added (if the gateway supports it):

[x] Wordpress
[ ] Discord
[ ] Facebook
[ ] Google
[ ] Spotify
[ ] GitHub
[ ] LinkedIn
[ ] Yahoo
[ ] Yandex
[ ] Vkontakte - not support by Isango (check PR #66 )
[ ] Microsoft

We will keep the list updated according to the actual support and added gateways in Isango.
Notes:

sync avatar only in registration step, not in other login (to avoid overwrite of current set avatar)
if more providers are linked to the account, we should sync only the first one, others will be skipped

As the avatar is synced in registration only, linking other connections to existing account simply ignores the user avatar received from gateway.

As the avatar is synced in registration only, linking other connections to existing account simply ignores the user avatar received from gateway.


Fix tests

The tests were failing.
I turned of automocking, as it does not make sense in this case as we want the dependencies (linkify-it, tlds) to work.
And in the parseString() method there was an invalid comparison. Should obvious if you look at the change in Linkify.jsx. We were comparing the string to the lastIndex instead of the string.length.
I also added a config file for travis, so would be nice if you could turn it on.

:+1:


Access to model google/timesfm-1.0-200m is restricted

Hi, I am trying to utilize the package, but got the error for
Cannot access gated repo for url https://huggingface.co/api/models/google/timesfm-1.0-200m/revision/main.
Access to model google/timesfm-1.0-200m is restricted. You must be authenticated to access it.

@lanqiuyao You need a hugging face account and you need to register your public key with hugging face then you need to agree to google's terms of service on the HF repo page. Once you do that you can git clone the model using ssh.
I recommend you clone it directly and make a backup copy to your own HF account. This will allow you to use the repo="" command but pointed at your own repo.

@lanqiuyao  need to generate the access token in your profile setting then run the below cmd in terminal
huggingface-cli login
it will ask to paste the access token. rerun it will work


mini.bufremove: use the native :confirm interface when closing buffers

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.bufremove
Description
Vim provides a native :confirm command for operations that require confirmation, such as when closing unsaved buffers. It would be nice if mini.bufremove can use this to allow the user to confirm unsaved changes.

That is an interesting idea! Thanks for creating this!
I'll think about it.


On windows 10, pyocd eats the first character of my CLI

The CLI might "eat" what I typed, especially for the first character I typed,
For example, if I typed the CLI show cores, the session will be,
pyocd> how cores
Error: unrecognized command 'how'

I tried both the old "command.exe" and Powershell.
I don't find this issue in Linux (Ubuntu 20.4.3, Centos 8,4)

Oh, that's really strange! I test on Windows pretty regularly, and I haven't seen this. I'll try again this weekend. Thanks for the bug report.

Sorry for the offtopic but you inspired me to set how alias to man :sunglasses:

I know I have experienced this behaviour. But now my installation of pyocd does not show this behaviour. Why is it?
The answer is here #1129. After applying the treatment I mentioned in that comment, this behaviour has been gone.
To try it with ease, I made a branch.
First do: pip uninstall pyocd pyocd-pemicro
Then do: pip install git+https://github.com/elfmimi/pyOCD.git@remove-pemicro-dependency

Thanks @elfmimi , I tried your fix, it works well on my machine.
@flit

Thanks! Fyi, there's another issue #1319 to make pyocd-pemicro optional for a different reason.


Notifying Sentry about release might fail

When the same release is deployed a second time (either to the same environment or the first time to the other environment, e.g. production after staging), the [Notify sentry about deployment] step in the playbook might fail.
fatal: [stag01]: FAILED! =>
{
  "changed": false,
  "connection": "close",
  "content_language": "en",
  "content_length": "752",
  "content_type": "application/json",
  "cookies": {},
  "cookies_string": "",
  "date": "Mon, 29 Nov 2021 09:28:09 GMT",
  "elapsed": 0,
  "json": {
    "authors": [],
    "commitCount": 0,
    "currentProjectMeta": {},
    "data": {},
    "dateCreated": "2021-11-26T22:31:13.001565Z",
    "dateReleased": null,
    "deployCount": 0,
    "firstEvent": "2021-11-26T22:31:15.000000Z",
    "lastCommit": null,
    "lastDeploy": null,
    "lastEvent": "2021-11-29T09:01:18.000000Z",
    "newGroups": 2,
    "owner": null,
    "projects": [
      {
        "hasHealthData": false,
        "id": 6077585,
        "name": "poseidon",
        "newGroups": 2,
        "platform": "go",
        "platforms": [
          "go"
        ],
        "slug": "poseidon"
      }
    ],
    "ref": null,
    "shortVersion": "77a308e8fdef4cc22fa23a832a08636c7163e7f7",
    "status": "open",
    "url": null,
    "version": "77a308e8fdef4cc22fa23a832a08636c7163e7f7",
    "versionInfo": {
      "buildHash": "77a308e8fdef4cc22fa23a832a08636c7163e7f7",
      "description": "77a308e8fdef",
      "package": null,
      "version": {
        "raw": "77a308e8fdef4cc22fa23a832a08636c7163e7f7"
      }
    }
  },
  "msg": "Status code was 208 and not [201]: OK (752 bytes)",
  "redirected": false,
  "server": "nginx",
  "status": 208,
  "strict_transport_security": "max-age=31536000; includeSubDomains; preload",
  "url": "https://sentry.io/api/hooks/release/builtin/xxx/yyy/",
  "vary": "Accept-Language, Cookie",
  "x_content_type_options": "nosniff",
  "x_envoy_attempt_count": "1",
  "x_envoy_upstream_service_time": "124",
  "x_frame_options": "deny",
  "x_served_by": "getsentry-web-default-production-bcb54d5bf-8jh5t, lb-10",
  "x_xss_protection": "1; mode=block"
}

This might be resolved after #53 has been tackled.


Add support for lambda layers

Supporting passing list of lambda layers ARN to be added to lambda functions

https://github.com/1debit/alternat/releases/tag/v0.4.4


The mvc event listener invalid for namespace if it's multi segment namespaces

There is a question for me.
On a module, Like the path: module/Application, module/Admin, etc...
Most of time. the module namespace is use: Application\, Admin\, and now I want make a module is common module for other project.  So I rename the namespace to: Brand\Admin\ replace the old Admin\ like this.
And then. the question is happened. I tracking all the script flow. The event manager just register the auto namespace first segment for the event identifier.  Like the Brand\Admin\ registered in the identifiers is Brand
So I register listener on a module's onBootstrap() can not been called.
Code to reproduce the issue
namespace Brand\Admin
class Module {
//.... other code
public function onBootstrap(MvcEvent $event) {

        $sharedEventManager = $event->getApplication()->getEventManager()->getSharedManager();
        $sharedEventManager->attach(__NAMESPACE__, MvcEvent::EVENT_DISPATCH, function ($e) {
            echo '
Hello, Baby!
';
        }, 9999);
        // The will be ok. the eventmanager auto register identifier AbstractActionController
        //$sharedEventManager->attach(Zend\Mvc\Controller\AbstractActionController::class, MvcEvent::EVENT_DISPATCH, function ($e) {
            //echo '
Hello, Baby!
';
        //}, 9999);
        // Or not use shared event manager, use eventManger is OK.
    }
}

Expected results
the never output hello, baby.
Actual results
The listener never been called.

I debug the EventManager->triggerListeners() method.
The class identifiers attribute include the followed ids.
Array (
  [0] => Zend\Mvc\Controller\AbstractController
  [1] => Application\Controller\IndexController
  [2] => Application // Notice there, if visit admin module. There will been: Brand, not expected: Brand\Admin
  [3] => Zend\Mvc\InjectApplicationEventInterface
  [4] => Zend\EventManager\EventsCapableInterface
  [5] => Zend\EventManager\EventManagerAwareInterface
  [6] => Zend\Stdlib\DispatchableInterface
  [7] => Zend\Mvc\Controller\AbstractActionController
)
Who can tell me the module namespace where, when added to the event manager identifiers?
Thanks so much.

#282 Should fix this

This repository has been closed and moved to laminas/laminas-mvc; a new issue has been opened at https://github.com/laminas/laminas-mvc/issues/14.


Embedding based matching

Hi, thank you for this library. Perhaps I'm missing something, but I've tried the following:
import holmes_extractor as holmes

holmes_manager = holmes.Manager(model='en_core_web_trf', number_of_workers=1, overall_similarity_threshold=0.2, perform_coreference_resolution=True, embedding_based_matching_on_root_words=True)
holmes_manager.register_search_phrase("someone likes brooklyn")

holmes_manager.start_chatbot_mode_console()

and I expected the sentence I love brooklyn to match, however it didn't.

At some point in the past I noted that the accuracy of embedding similarities between pairs of verbs wasn't very good, so I restricted embedding-based matching to certain parts of speech. Sorry about this — this is something that should be at least better documented and that the public API should probably allow you to change, and I'll rectify the problem in the next version.
In the meantime, you can get around the problem with the following workaround (before your code):
from holmes_extractor.lang.en.language_specific_rules import LanguageSpecificSemanticMatchingHelper
LanguageSpecificSemanticMatchingHelper.permissible_embedding_pos.append("VERB")

Thank you! Will try.


add support for Runtime{Args,Opts} in CreateContainer

What type of PR is this?

/kind feature
What this PR does / why we need it:
This should shore up most of the remaining pieces podman needs for container creation
Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?

Add support for RuntimeArgs and RuntimeOpts in CreateContainer RPC

cc @mheon

This should do everything we're looking for - thanks!


Metadata changed on server is not updated reliably in Les Pas

Describe the bug
I have a bunch of photos that initially had no exif metadata.
I uploaded them to my Nextcloud with Les Pas and manually set the date taken in the Exif data correctly on the nextcloud server (using the memories extension).
Now Les Pas sorts them wrong and says they were all taken a few days ago (the day i uploaded them) in the overview.
But if i show the details of a photo it shows the correct Exif-date.
Re-Syncing does not change a thing.
If i download the photos and upload them again with Les Pas the dates are correct.
To Reproduce
Steps to reproduce the behavior:

Upload a photo without Meta-Data
Edit Metadata on the server (eg using "Memories")
-> Change date eg to last year
Look at sorting in the album and little yellow date in the corner, it shows the date today

Expected behavior
Dates in overview and in details match, edited metadata on the server is recognized with next sync.
Smartphone (please complete the following information):

Device: Galaxy Tab S7 and Redmi Note 7
OS: Android 13  (and 12)
Version 2.8.0 (and 2.8.1)

I have difficulty recreate this bug on my side, here is what I have done:

Update a photo's creation date tag in EXIF on server. I use exiftool rather than Memories though
Make sure the updated photo synced back to Les Pas by re-launching the app
Les Pas sort it correctly in the list

I even installed Les Pas on a whole new device and got the wrong dates there, so i dont think the syncing is the problem.
I might have some weird edge case there, but i have no idea how to find out why it happened for me.

Send me one of those file, attach here or to my email<EMAIL_ADDRESS>


Skill Chaining breaks dialog stack

Describe the bug
The dialog stack completely breaks down if a skill has wiring to call another skill.
Version
Version:  2.0.0-nightly.239895.e3e1b3e
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Create and deploy (as a skill) a skill bot [I'll call this chain bot from here out] that has 1 intent that has some unique message
Create an echo skill bot with an echo intent.
Add the chain bot as a remote skill
Publish echo bot as a skill
Create a local parent bot
Add the echo skill bot as a remote skill
Start the parent bot
Spin up ngrok using the port of the parent
replace the parent bot's skill host endpoint with the ngrok url
talk to the parent over emulator
Send a message that will route to the echo skill bot's multi-step dialog
Send the 2nd message for the echo bot

Expected behavior
The current multi-turn dialog should be active still, but the 2nd message falls into the unknown intent bucket.

Screenshots
Parent:

Echo:

Chain:

Emulator
The image on the left is what should happen. I republished the echo skill bot without the chain bot as a remote skill. The image on the right is what does happen.

Additional context

I should add, the echo skill's echo dialog does not call the chain bot.


[BUG]cannot install mov-cli

Describe the bug
pip install mov-cli not working
Expected behavior
I was expecting the installer to run to completion
Error
Collecting mov-cli
Using cached mov-cli-1.2.5.tar.gz (43 kB)
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [12 lines of output]
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "/tmp/pip-install-jgc385wz/mov-cli_b5861115128440feaf883534944c21ef/setup.py", line 3, in
from mov_cli.version import core as ver
File "/tmp/pip-install-jgc385wz/mov-cli_b5861115128440feaf883534944c21ef/mov_cli/init.py", line 1, in
from . import main
File "/tmp/pip-install-jgc385wz/mov-cli_b5861115128440feaf883534944c21ef/mov_cli/main.py", line 10, in
from .websites.actvid import Actvid
File "/tmp/pip-install-jgc385wz/mov-cli_b5861115128440feaf883534944c21ef/mov_cli/websites/actvid.py", line 6, in
from Crypto.Cipher import AES
ModuleNotFoundError: No module named 'Crypto'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
Desktop (please complete the following information):

OS: Pop!_Os
Version: 22.04
pip version: 22.2.2

Possible cause
the error message says no module named Crypto, but I already installed this module and re-ran pip install mov-cli and it still didn't work

Try pip install pycryptodomex

I installed pycryptodomex successfully, how does this help me?  I am still getting the same error when I try to install mov-cli.


Implement header + footer offsets

It would nice to be able to start/stop fixing at specific elements or in a offset range. So, that we can add for example a footer and header to use as breakpoints.

@yckart any description?

@godban Sorry, I just forgot it...


How to replace JHU data with country-wise data (India)

Dear @lisphilar ,
while running the following code,i am getting mentioned error:-
ind_data = cs.CountryData("/kaggle/input/covid19-in-india/covid_19_india.csv",Country="India")
ind_data.set_variables(
date="Date", confirmed="Positive", fatal="Fatal", recovered="Discharged", province=None
)
ind_data.cleaned().tail()
TypeError: init() got an unexpected keyword argument 'Country'
I just replace the country by India in place of japan and change the file path too...,but in spite of that I am getting above error..,will you please help..
With regards,
Rakesh

Dear Rakesh,
Please use small characters as the arguments of methods like this.
ind_data = cs.CountryData("/kaggle/input/covid19-in-india/covid_19_india.csv",country="India")

Before: Country="India"
After: country="India"
Thank you.

Dear Rakesh,
Please read documentation of CountryData.set_variables()
https://lisphilar.github.io/covid19-sir/covsirphy.cleaning.html#covsirphy.cleaning.country_data.CountryData.set_variables
(If you find errors or something to know, please let me know as always.)
Did you used the following dataset?
https://www.kaggle.com/sudalairajkumar/covid19-in-india?select=covid_19_india.csv
I think the following codes will be necessary.
ind_data.set_variables(
date="Date", confirmed="Confirmed", fatal="Deaths", recovered="Cured", province="State/UnionTerritory"
)

Dear @lisphilar/covid19-sir
<EMAIL_ADDRESS>,
Yes..,you are right..,the given code is necessary as column name were not
matching..,thanks for the help..
With regards,
Rakesh
On Sat, Jul 18, 2020 at 10:18 PM Lisphilar<EMAIL_ADDRESS>wrote:

Dear Rakesh,
Please read documentation of CountryData.set_variables()
https://lisphilar.github.io/covid19-sir/covsirphy.cleaning.html#covsirphy.cleaning.country_data.CountryData.set_variables
(If you find errors or something to know, please let me know as always.)
Did you used the following dataset?
https://www.kaggle.com/sudalairajkumar/covid19-in-india?select=covid_19_india.csv
I think the following codes will be necessary.
ind_data.set_variables(date="Date", confirmed="Confirmed", fatal="Deaths", recovered="Cured", province="State/UnionTerritory"
)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lisphilar/covid19-sir/issues/120#issuecomment-660509535,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP6Y4PGNNOM25Y77WKYFPJDR4HG6BANCNFSM4O77E7SA
.

Thank you!
I will close this issue.

Dear Lisphilar,
i am agin encountering error in in running the above code:-
ind_data = cs.CountryData("/kaggle/input/covid19-in-india/covid_19_india.csv",country="India")
ind_data.set_variables(
date="Date", confirmed="Confirmed", fatal="Deaths", recovered="Cured", province="State/UnionTerritory"
)
ind_data.cleaned().tail()
ValueError: Cannot convert non-finite values (NA or inf) to integer
Please look into it....
With regards,
Rakesh

Dear Rakesh,
It seems that NA values were added to the raw dataset.
I will add .fillna(0) in cleaning method ofcs.CountryData class.

Dear Lisphilar,
Thanks for the response...,okey..kindly let me know after adding it..

Dear Rakesh,
I fixed this in version 2.6.0-alpha.fix.120
Please confirm it.


std::filesystem::path is not supported in macOS<10.15

Use of std::filesystem::path is preventing support for macOS versions before 10.15.

Did some research on this and based on https://en.cppreference.com/w/cpp/filesystem std::filesystem originally was a feature of boost library so https://www.boost.org/doc/libs/1_81_0/libs/filesystem/doc/index.htm ... Maybe include that in the project instead for backwards compatibility? Or then go with some native route. :)

Might be able to solve this using WDL_Strings from iPlug2.

Drawback would be that the dsp module would be locked into iPlug2, which would be bad.

Looking forward to a fix to be able to use in Mojave thank you

Just found this which might be helpful! https://github.com/gulrak/filesystem
"An implementation of C++17 std::filesystem for C++11 /C++14/C++17/C++20 on Windows, macOS, Linux and FreeBSD."

Mojave 10.14 user—Curious if this is still in progress? Thanks

Just found this which might be helpful! https://github.com/gulrak/filesystem
"An implementation of C++17 std::filesystem for C++11 /C++14/C++17/C++20 on Windows, macOS, Linux and FreeBSD."

According to my tests gulrak's library is a single-header with handy macro helpers and I managed to build nam plugin with it and C++14. Unfortunately it seems that iPlug2 still requires C++17 but there was just a couple of lines to fix so that built with C++14 too.

https://github.com/masqutti/NeuralAmpModelerPlugin/commit/e3fa057f1f110b8d92dabd70d00f04a3415eed1c
Here's info how I did it, it's not a big change but I unfortunately too occupied at the moment to do pull requests myself. It requires the https://github.com/gulrak/filesystem to exist and subfolder "Include" added as to header search paths to allow building. Also iPlug2 needs two small changes in couple of places (you will notice when you try to build) which are about Structured bindings (not possible with C++14) and very easy to fix, probably ideal to have iPlug2 issue / pull request about them since compiler only complained about 2 lines.

I think it would be better to just pass paths as strings, rather than add another dependency with https://github.com/gulrak/filesystem.
From looking at the code, it isn't doing much specific to std::filesystem::path beyond some file existence checks.

Oh yes definitely, if strings are enough. I guess I'll investigate it a bit further when I got the time 🤔

期待能够在 Mojave 中使用的修复程序，谢谢
me 2, really want try NAM on MAC 10.14 Mojave ! if that works someday, please tell me . thank u !

me 2, really want try NAM on MAC 10.14 Mojave ! if that works someday, please tell me . thank u !

sorry i dont know anything about coding.... im not a geek but really apreaciate ur work , hope u cant work it out ! really want try NAM on MAC 10.14 Mojave ! if that works someday, please tell me . thank u !

Oh, what a pity that the plugin does not work in MOJAVE 10.13.6 Millions of users still work in this operating system. Especially in such difficult times.

Hey @masqutti, any chance this could be revisited? Now that the iPlug2 fix is merged, perhaps this has become more straightforward.
I tried to make a PR including the changes from your commit linked above, but there's a lot of merge conflicts and it's a bit hard to follow the history and separate what is still needed since I am unfamiliar with the codebase.
I'm willing to help where I can, and I'm happy to test on my 10.13 Mac :)

Hey @masqutti, any chance this could be revisited? Now that the iPlug2 fix is merged, perhaps this has become more straightforward.
I tried to make a PR including the changes from your commit linked above, but there's a lot of merge conflicts and it's a bit hard to follow the history and separate what is still needed since I am unfamiliar with the codebase.
I'm willing to help where I can, and I'm happy to test on my 10.13 Mac :)

Yes iPlug removed the tiny C++17 feature and it should work, I haven't checked in for a while tho. But NAM still includes those C++17 filesystem and clamp features that prevent using NAM on older Mac OS version. clamp is an easy one, it's a simple limiting of a value inside a range, but std::filesystem features at least exists() method which checks if a file exists or not, which is required for NAM to work and thus not simple std::strings can work alone to fix this. I have forks which solved these issues and I've built NAM for down to Mac OS 10.9, but they're not up to date atm:
https://github.com/masqutti/NeuralAmpModelerPlugin/tree/dspStruct
https://github.com/masqutti/NeuralAmpModelerCore/tree/dspStruct
It seems gulrak's filesystem which I've used to replace std::filesystem has been updated 2 weeks ago so it's still an active repo, to me it's still worth considering.

@sdatkinson I can definitely still do a pull request which includes gulrak's filesystem, either as a submodule or just plain ol copy/paste ;) But I won't attempt if it's not your intention to include more repos into NAM.

Based on how many submodules are already in this repo, I think it's fair to assume that it's an acceptable method :)
I think, if it's not too inconvenient for you, getting a PR opened with an up-to-date solution to this problem will at least allow a review and give us a starting point. If changes need to be made before the PR is accepted, anyone can help out since we can all easily check the diff to see exactly what is needed to remove this dependency and allow the software to work on older systems.
Thanks for the quick response and for your hard work on this project!

Thanks all for your patience on this.
I'm open to either of the two paths forward:

using gulrak's filesystem
Implementing the needed methods first-party using std:strings.

I think slightly prefer gulrak on account of (1) it having tests, (2) this feels like a potentially-better solution for the long run if other file manipulation comes into view that would benefit from already having a more fleshed-out implementation, and (3) the license is fine and dandy, and (4) besides, if this isn't much work, I'm sure it can be rethought in the future if need be (and keeping the std interfaces sounds nice).
So if anyone wants to PR me this I'll give it to whomever raises their hand first :)

Hey everyone,
Is NAM able to load in Mojave, or will this ever be possible?
I am clueless as to coding etc, but I really wanted to try out the NAM plug-in.
Would really appreciate any help with this!
Thanks

Thanks all for your patience on this.
I'm open to either of the two paths forward:

using gulrak's filesystem
Implementing the needed methods first-party using std:strings.

I think slightly prefer gulrak on account of (1) it having tests, (2) this feels like a potentially-better solution for the long run if other file manipulation comes into view that would benefit from already having a more fleshed-out implementation, and (3) the license is fine and dandy, and (4) besides, if this isn't much work, I'm sure it can be rethought in the future if need be (and keeping the std interfaces sounds nice).
So if anyone wants to PR me this I'll give it to whomever raises their hand first :)

I could work on this one a bit, as I already have implemented gulrak's on my repository. I wonder where should I put the submodule, in NeuralAmpModelerCore's dependencies -folder or in this repository? I noticed there's eigen in both. :o

As a producer still working on an older system, is there a download/fork that will allow NAM to run on 10.13? Have been trying to figure out a way to use NAM.
Appreciate all the hard work that has gone into this :-)

@masqutti I think I'd prefer putting it here and not NeuralAmpModelerCore. It'd be easier to move it to core later than the opposite I think.

@masqutti I've assigned you to this since it sounds like you shouldn't have a problem getting it done; lmk if that's ok

@masqutti I've assigned you to this since it sounds like you shouldn't have a problem getting it done; lmk if that's ok

It's ok! :)

Hi All - I hit this as well and here are my diffs to address it:
<.../NeuralAmpModeler/NeuralAmpModelerCore>
diff --git a/NAM/dsp.h b/NAM/dsp.h
index 2f88cbd..ad31999 100644
--- a/NAM/dsp.h
+++ b/NAM/dsp.h
@@ -6,6 +6,7 @@
 #include <string>
 #include <unordered_map>
 #include <vector>
+#include <filesystem>

 #include <Eigen/Dense>


Does Clay support animated SVG?

Does Clay support animated SVG? If not, what is an alternative?

Clay is a layout library. Rendering of animated SVGs is related to rendering. If you use a rendering backend that supports animated SVGs you can easily integrate it to clay with custom element.


dark mode of about page is changed

Description
Dark mode of about page changed, same like contributors page. This is regarding the issue
Fixes #(issue)
Type of change

[ x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist:

[x ] My code follows the style guidelines of this project
[ x] I have performed a self-review of my own code
[ x] I have commented my code, particularly in hard-to-understand areas
[x ] My changes generate no new warnings
[x ] I have added tests that prove my fix is effective or that my feature works
[ x] New and existing unit tests pass locally with my changes
[x ] Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable):

Thank you so much sir!!


Video fails to stop

Summary
My video file saves and is persisted.  When I try to open it, it cannot be played.
RSpec.configure do |config|
  config.prepend_before :each do |config|
    full_description = config.metadata[:full_description]
    @browser = Watir::Browser.new

    recording_name = full_description.gsub(/\s/, '-').downcase + '.mp4'
    ScreenRecorder.logger.level = Logger::DEBUG
    @recorder = ScreenRecorder::Desktop.new(output: "spec/artifacts/recordings/#{recording_name}")
    @recorder.start
  end

  config.after :each do |config|
    @recorder.stop
    @recorder.delete unless config.exception
    @browser.close if @browser
  end
end

Debug Info
Please provide the following information for bug reports:

Operating system - macOS.
Ruby version - 2.4.3
Recorder parameters - output: filename.mp4
Recorder log (ffmpeg.log)- https://gist.github.com/aaron-humerickhouse/bc62215dd70a7e70a21bc8fb5d674388
Set ScreenRecorder.logger.level = Logger::DEBUG - https://gist.github.com/aaron-humerickhouse/79899bc3f63ae3e25f89e355dc3979e2

Expected Behavior
Recording to stop appropriately.  Able to watch the video
Actual Behavior
Recording fails to stop. Unable to watch the video

Hey @aaron-humerickhouse, thanks for the detailed bug report. The logs are showing that ffmpeg is failing to stop normally for some reason. As a result, the gem is force killing it to avoid having a zombie process. This ultimately is causing the unplayable video.
2019-10-30 18:04:14 ScreenRecorder - ERROR - FFmpeg failed to stop. Force killing it...
2019-10-30 18:04:17 ScreenRecorder - ERROR - Check 'ffmpeg.log' for more information.

Now we need to figure out why ffmpeg is not stopping normally, and for that I looked at the ffmpeg.log and found out that the input stream is being captured at 1000k fps for some reason. Let's initialize the recorder with an input FPS and see if that fixes the problem:
advanced = { input: { framerate: 15 } }
out_file = "spec/artifacts/recordings/#{recording_name}"
@recorder = ScreenRecorder::Desktop.new(output: out_file, advanced: advanced)

Also, are you using the latest version of this gem?

@aaron-humerickhouse I was able to reproduce and actually fix the issue by passing vsync 0 for the input on macOS:
advanced = { input: { vsync: 0 } }
out_file = "spec/artifacts/recordings/#{recording_name}"
@recorder = ScreenRecorder::Desktop.new(output: out_file, advanced: advanced)

Feel free to reopen this issue if that doesn't work for you.