Add support for batched decoding api

llama.cpp recently moved to a new api which supports batching (both for single sequences with multiple outputs and multiple seperate streams) and streaming support. This new api based on llama_decode supercedes the now deprecated llama_eval api. This means that the current api should be migrated anyways regardless of the new features but we'll see how easy it is to implement along the way.
The current roadmap is

[x] Get a basic low-level demo working with llama_decode based on the examples/batched in llama.cpp
[ ] Migrate single sequence inference over to using llama_decode
[ ] Implement multiple completions for a single input
[ ] Implement multiple inputs completions to be processed at once
[ ] Implement completion streaming by shifting kv cache

is there a way to help with this one?

Is this feature live yet？Why can't I support batch tasks locally？


[libc] Refractor stdio

Refractor stdio.c and stdio.h
Make file structs opaque so the user cannot change them
Add __use_instead function attribute
Add STDIN, STDOUT and STDERR macros

👍


Added typescript declaration file

Added index.d.ts
Updated version to 2.1.0

Fixed some code I forgot about

Excellent! Merged and published to npm. Thanks.


Failed to set up resources

Describe the bug
I use curl to set the file resource, but it doesn't seem to take effect.

Steps to reproduce
curl --location --request PATCH 'http://<IP_ADDRESS>:5230/api/v1/memos/54/resources' \
--header 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsImtpZCI6InYxIiwidHlwIjoiSldUIn0.eyJuYW1lIjoiIiwiaXNzIjoibWVtb3MiLCJzdWIiOiIxIiwiYXVkIjpbInVzZXIuYWNjZXNzLXRva2VuIl0sImV4cCI6NDg3MDgxOTk1MSwiaWF0IjoxNzE3MjE5OTUxfQ.Wa5Cz5DA1Yj9WO3iOP6aI_KcD1l3yoDOKrbn0QjW1qI' \
--header 'Content-Type: application/json' \
--data '{
    "resources": [
    {
    "name": "resources/33",
    "uid": "kRYrPznrSK64SBfJpMXpq9",
    "createTime": "2024-06-01T08:32:37Z",
    "filename": "16pic_8925252_b.jpg",
    "content": "",
    "externalLink": "",
    "type": "image/jpeg",
    "size": "204070"
}
]
}'

The version of Memos you're using
0.22.0
Screenshots or additional context
No response

@boojack When will it be released?


Update syntax highlighting

This PR adds the support for directive, e.g.,

and also fixes a missing coloring on result of <scope> constructs.

Accidentally merged in #50


Semantic versioning issue - 0.1.7 has breaking changes, consider releasing as 0.2.0 instead

Hey! I just wanted to start by saying that this library is great and I have pointed a lot of folks in your direction who are looking for a better approach to navigation in SwiftUI.
We currently pinned to "upToNextMinor" and had some code that was still using the deprecated NStack/PStack, which looks to be removed in the 0.1.6->0.1.7 release: https://github.com/johnpatrickmorgan/FlowStacks/compare/0.1.6...0.1.7
It looks like some CI system of ours automatically bumped the patch version assuming it was "safe" to do so, and it broke the build.
I know that the 0.1.x implies that there will be some API instability, but I'd suggest at least bumping the minor version when making breaking changes that might require folks to undertake a bigger refactor. Normally I'd suggest pulling the 0.1.7 release and re-tagging it as 0.2.0 - but it's been out for 2 days now and that might cause even further issues if people's Package.resolved are pointing to that version now.
Just wanted to flag this here for other folks who might be encountering this as well.
Cheers!

Thanks @chrisballinger, and glad you're getting good use out of the library. You're totally right - a minor version change would have made much more sense for that breaking change.
As you say, it might cause problems to amend the tag now, but I suppose I could revert the change in a version 0.1.8 and remove them again in a version 0.2.0. That should minimise the impact on anyone else in the same situation.
Sorry for the inconvenience!

No worries! Was able to get a workaround in place, which revealed some other problems about why the Package.resolved file wasn't in source control. If it wasn't this breaking change, it was gonna be some other library down the road causing issues.
That 0.1.8/0.2.0 approach sounds like a good idea!

Resolved via 0c2a791 / 5a1d58a and 0.1.8 / 0.2.0. Thank you!


Missing function/file/line information in trace

I tried Exercise 2 of the Bounds checking and pointers section of the tutorial. I ran
cargo kani --harness bound_check --visualize --enable-unstable

with Kani version: 0.53.0-dev
I expected to see information about the function, file, and line, e.g.:
Step XXX: Function bound_check, File src/bounds_check.rs, Line 37

Instead, I saw this:
Step XXX: Function MISSING, File MISSING, Line 0

for every line of the trace.

This appears to be a bug in what input we produce to CBMC Viewer as CBMC does report all the details correctly and Kani, in its default output, also knows about those source locations. In light of https://github.com/model-checking/kani/pull/3302 I am, however, wondering whether it is worth trying to fix this.

This appears to be a bug in what input we produce to CBMC Viewer as CBMC does report all the details correctly and Kani, in its default output, also knows about those source locations. In light of #3302 I am, however, wondering whether it is worth trying to fix this.

Probably not--if we're already deprecating it, doesn't seem worth it. Will close for now.


cannot use the Azure Open AI API Key instead of the openai key

How do you configure pentest-gpt to use an azure openapi endpoint and api key?

Hi @zadigus , previously I did not setup support for Azure api key. I'm implementing the support now and will update it to the project soon.
Meanwhile, you may take a look at pentestgpt/utils/APIs and implement an Azure API wrapper to use it properly.

Hi, @GreyDGL could you please tell when the Azure API key configuration will be ready?

Hello @GreyDGL, is there any news about the Azure setup?

Hi @GreyDGL, has there been any work done so far or can we help on implementing this Azure API wrapper?

Hey guys, I created a wrapper for azure GPT3.5-turbo. I don't have an azure API key so cannot try it out.
May someone try pentestgpt --reasoning_model=azure-gpt-3.5 --parsing_model=azure-gpt-3.5?

Seems to be working with this command now using Azure Open AI Key! Thank you

Perfect! Will close this issue for now then:)

@busraoguzoglu could you explain how did you configure the endpoint, it's not working on my side

Seems to be working with this command now using Azure Open AI Key! Thank you

can you drop steps how u run this project with azure open ai


Repeatedly calling scipy.signal.resample uses more memory than expected

I have code that resamples many audio files using scipy.signal.resample. The code uses much more memory than I would expect to the point of freezing the OS. I've managed to simplify my code to a simple test case. This uses ~8Gb RAM after about 6 iterations but I would expect it should use much less memory than this.
I am using inputs of varying sizes, which seems to be significant. If I use an audio input of constant size there doesn't seem to be a problem.
from scipy.signal import resample
import numpy as np

def Test():

	shps = range(11473744, 1000, -2)

	for i, shp in enumerate(shps):
		signal = np.random.normal(size=(shp, 1))

		print (i, signal.shape)
		targetSamples = signal.shape[0]*44100//48000
		signal2 = resample(signal, targetSamples, axis=0)
		print (signal2.shape)
		del signal, signal2

if __name__=="__main__":
	Test()

I might have missed something obvious, so this might not even be a bug!

Scipy 1.4.1
Numpy 1.18.4
Python sys.version_info(major=3, minor=6, micro=9, releaselevel='final', serial=0)

I'm not absolutely sure, but if the resampling process somehow calls scipy.fft internally, it might be caused by the module's internal plan caching. Currently scipy.fft caches plans for the last 16 different transforms it did, and for 1D transforms they are comparable in size to the transformed arrays (for "difficult" transform sizes even larger).
One way to test this hypothesis is to start your test with a smaller size and check whether the memory consumption still increases after 16 iterations.

OK, inspecting the test with perf top shows that the FFT really is called internally. What I don't understand is why resample does the resampling in such a brute force fashion. I would have expected that this can be done chunk-wise using power-of-two chunk sizes ...
@peterbell10 do you happen to know more details?

Dropping the start size 11473744 to a value 10 times smaller allows it to get to iteration 16. From then, it does seem to use a roughly constant amount of memory.
Looking further, my bug is probably a dup of #5986

Perhaps limit the cache memory usage?

Perfectly reasonable suggestion. But coming up with a reasonable cache size is more difficult than it seems ... of course, we can make it flexible, but that requires an interface extension which users need to know about.
Personally I'd just drop the cache. It doesn't help that much, especially with the really expensive multi-D transforms.
For your concrete application I'm sure that there are ways to implement this within scipy.signal which are much more CPU- and memory-efficient than what's currently in there.

One workaround for your situation (admittedly not pretty, but rather efficient, I'd expect) is to break the input into  chunks of 48.000 samples and resample them individually (the last one may be shorter of course).

Something like this (completely untested, so take with a grain of salt):
from scipy.signal import resample
import numpy as np

def resample_chunks(signal):
    nchunks = (signal.shape[0] + 47999) // 48000
    res=[]
    for i in range(nchunks):
        beg = i*48000
        end = min((i+1)*48000, signal.shape[0])
        targetSamples = (end-beg)*44100 // 48000
        res.append(resample(signal[beg:end], targetSamples, axis=0))
    return np.concatenate(res, axis=0)

def Test():

	shps = range(11473744, 1000, -2)

	for i, shp in enumerate(shps):
		signal = np.random.normal(size=(shp, 1))

		print (i, signal.shape)
		#targetSamples = signal.shape[0]*44100//48000
		#signal2 = resample(signal, targetSamples, axis=0)
		signal2 = resample_chunks(signal)
		print (signal2.shape)
		del signal, signal2

if __name__=="__main__":
	Test()

Naah, sorry, that's most likely not correct. Please ignore ...

The resampling function (by using FFT) implicitly assumes periodicity, so resampling in chunks will not give the same result as resampling in one go, unfortunately. You might try using resample_poly, which uses a different algorithm (polyphase).
@peterbell10 any ideas about how to manage the cache? Maybe we do need to expose it or some functions publicly so that people can clear it.

Even if we give the users the choice to manage the cache, we should assume by default that they don't know and/or don't care ... and the only safe default is "cache off" ... or perhaps "cache is limited to 1 MB". When I thought "well, 16 cached plans shouldn't hurt anyone", I clearly wasn't careful enough :-)

Yet for all the extra memory they take up, they actually don't contribute as much of a speedup. Only ~1-2% for 1D transforms in my testing.

Do you have an example script for this? This would be actually amazing :)
The convolution factors themselves are the result of a "long" FFT themselves, so if we do not cache them, we have to recalculate them, and this should account for (roughly) 33% of the whole transform. (A full Bluestein transform consists of 3 FFTs: one to compute the convolution factors, and two for the actual convolution of the data. The first one is independent of the data and can therefore be cached.)
The "chirp" twiddle factors may be another story, that's correct.

I agree that it would be nice to directly cache cfftp and rfftp plans, because the Bluestein plans currently may hold redundant copies. Maybe there is a way of synthesizeing a pocketfft_c or pocketfft_r object from individually cached cfftp objects and convolution factors... but unless we are willing to give up the caching of the convolution factors, the memory consumption will not change fundamentally.

Actually, wait I was doing something really silly. I was generating input data with np.arange(n*2).view(complex) but since arange produces integers, I was getting entirely denormal numbers when viewed as floats so the FP math was way slower, but not for the chirp factors.

Indeed, it is about 1/3 speedup now that I test it again. In that case, caching the factors seperately is probably not a good idea since it means the bluestein plans won't be evicted from cache by regular sized plans, so will stick around for longer.


Template flask application MVP

Create MVP for the example application to showcase standards
This ticket will develop focus as it progresses; incorporating learning and onboarding
Includes

[x] helm
[x] docker
[x] flask
[x] dev & prod workflows and deployment process (dev on push to main, prod on tag to main)
[x] GOV.UK Jinja frontend
[x] makefile
[x] readme with instructions on how to use as template
[x] modularise app folder layout

What next?

[ ] docker compose
[ ] make the flask app do something more than just quote Gudetama (though a fount of wisdom he undoubtedly is): It was going to be the record of the standards I think?
[ ] tests: helm tests, docker tests, pytests
[ ] dotenv
[ ] process for running locally, so dev testing can be done locally rather than wait for merge to main to be test deployed
[ ] linting, formatting
[ ] makefile?
[ ] auth0

Parking this now


Can't upload from phone

iPhone 6+ here. Both taking a photo and choosing a photo won't let me upload anything, I get "Upload Failed An error occured while uploading the file. Please try again."
What's the deal here?

Free accounts are limited to 100MB of file uploads.  Try deleting some of your old uploads to make room for new photos.  You can manage your uploaded files by tapping the upload button and then tapping "File Uploads" from the menu.  In the future, please use the "Send Feedback" menu option or visit our IRC channel instead of GitHub Issues for technical support questions.

Right, that makes a lot of sense. However, there should definitely be a more user friendly message for this (especially on mobile) as a I genuinely thought I was encountering a technical issue (which is why I posted here), so I still see this as an issue, just a different one.

        what happend?I don't upload my photo ,but this Email told me I can't upload this And 100MB What？  Are you wrong ?
        在2016年05月14日 20:04，Luke 写道:Right, that makes a lot of sense. However, there should definitely be a more user friendly message for this (especially on mobile) as a I genuinely thought I was encountering a technical issue (which is why I posted here), so I still see this as an issue, just a different one.

—You are receiving this because you are subscribed to this thread.Reply to this email directly or view it on GitHub

        Google Chat?
        在2016年05月14日 20:02，Sam Steele 写道:Free accounts are limited to 100MB of file uploads.  Try deleting some of your old uploads to make room for new photos.  You can manage your uploaded files by tapping the upload button and then tapping "File Uploads" from the menu.  In the future, please use the "Send Feedback" menu option or visit our IRC channel instead of GitHub Issues for technical support questions.

—You are receiving this because you are subscribed to this thread.Reply to this email directly or view it on GitHub

致:GaoJunxiao 先生
对不起，我真不明白你在说什么。
此致
敬礼
orbbfrgg敬上。

Yep, the quota exceeded error message will be implemented in the next update.


google cloud pubsub - with_auth() method is gone between 0.13.0 and 0.14.0

I am trying to figure how to upgrade from 0.13.0 to 0.14.0 and having issues with the client config of the pubsub crate.
The method .with_auth() cannot be resolved anymore after the upgrade, and i cannot find any example on how to deal with the authentication with the newer version.

I have seen tickets making the authentication part optional and others to provide your own implementation, but why is this one gone ?
Could you please:

explain the changes
document it
update the given example with updated code

Another question i had as well: why this method is gone for the pubsub client configuration, but not on the storage client configuration.
Should not we have consistent authentication API across all crates ?

Oups, my bad, one of the dep was not correctly updated, therefore leading to this issue. Closing the ticket.


feat(tauri.js) add tauri info command

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] New Binding Issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes. Issue #___
[x] No

The PR fulfills these requirements:

[x] It's submitted to the dev branch and not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Should we add a spot for this to the bug report template?


message: Fix code checking group mention permission to handle anonymous user groups.

First commit is to fix code to check whether UserGroup object is linked to a NamedUserGroup object.
Second commit is a small optimization to check if can_mention_group is everyone group.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, with one comment about test setup patterns that might be best addressed in a follow-up PR anyway; I'm not sure whether you'll find it makes sense to add a new test_classes.py helper or something else.


doc: replace f-string by basic string

There are no variable in the string so f-string is uneeded.

Terrific!


Disable PhEDExInjector; Enable all tiers to be injected in Rucio

No issue created
Status
ready
Description
This changes the default Data Management system for output data, allowing all the datatiers to be injected into Rucio; at same time completely disabling PhEDExInjector (component still running, but not taking any actions).
Note that this configuration remains:
config.RucioInjector.skipRulesForTiers = ["NANOAOD", "NANOAODSIM"]

meaning, the agent is not allowed to create container-level rules - if specified in the workflow - for those 2 datatiers.
Is it backward compatible (if not, which system it affects?)
yes
Related PRs
none
External dependencies / deployment changes
none

Noo! I forgot to backport this patch...


Add connection name

Having a connection name when redis-commander connects to Redis is nice so you know which connection is from which application.
The Redis command is here: https://redis.io/commands/client-setname
And the ioredis API option is here: https://github.com/luin/ioredis/blob/master/API.md#Redis ([options.connectionName]).
I think that would be a great addition, I can PR it if wanted.

please create a PR, this is a good idea.

@joeferner This can be closed now ;)


package libmbim-utils needed on ubuntu

For install instructions, please add that you need to run sudo apt install libmbim-utils to get mbimcli installed on ubuntu.

I've approved comments on README.md, I close for the moment this issue


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc we don't use Prow
/assign we don't use Prow
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/serving 7184235...f6cb424:
  > f6cb424 Add support for `dnsConfig` and `dnsPolicy` in pod spec (# 12897)
  > 89be0fd modify checksum so its not a float64 (# 12900)
  > 078e0b9 upgrade to latest dependencies (# 12899)
  > 0d76bb7 Update net-certmanager nightly (# 12879)
  > 95cfa70 ServerlessService's initial operation mode is now Proxy (# 12842)
  > 5128270 upgrade to latest dependencies (# 12890)
bumping knative.dev/client bcd18d3...e734ca6:
  > e734ca6 upgrade to latest dependencies (# 1668)
  > 06b4b9e Bump Tekton pipeline version to latest by default (# 1667)
bumping knative.dev/networking 700c576...591d2bb:
  > 591d2bb upgrade to latest dependencies (# 664)

Codecov Report

Merging #438 (2f579e1) into main (a60a45d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   81.83%   81.83%
=======================================
  Files          27       27
  Lines        1382     1382
=======================================
  Hits         1131     1131
  Misses        223      223
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60a45d...2f579e1. Read the comment docs.


Backend Setup

[x] Setup Server components [Next.js]
[x] MongoDB connection and reading / writing from objects template
[x] Minio storage. [file embedding in db, uploading files, proper delete method]

Need to look at authentication when sensitive information is stored. which related to task #16
Still need to implement post media


Staging

Scope for this PR:
Add Dynamo
Adds tests for DynamoDB
Adds support for DynamoDB Local for testing and local development
Updates travis for dynamodb testing
Add context manager
Add delete archive, archive teardown
Add caching support
Add support for s3
Add support for versioning
Add hashing of files
Extend documentation and examples for remote and ondisk
Fixes for Issues:
#31, #12, #8, #6

Coverage increased (+2.3%) to 84.451% when pulling 0c6ffaf305fdef61c76c5034b70f61ee9a8ec3c4 on staging into 79495bf45015a274e0e120f0f202055604149b87 on master.


Git panel shows changes that git status doesn't

Issue Type: Bug
git clone https://github.com/96boards/ai.git
git status
Expected output (since I've just cloned it):
On branch develop
Your branch is up to date with 'origin/develop'.
nothing to commit, working tree clean
However, the git panel shows 33 modified files.
Worse is https://github.com/devicetree-org/devicetree-website.git which VSCode believes has 605 modified files!
VS Code version: Code - Insiders 1.36.0-insider (41691474e5fa22a279d49fc4b58af66bc11ce41b, 2019-06-26T05:20:29.762Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.93GB (7.02GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

vscode-docker
ms-
0.6.4

remote-containers
ms-
0.64.0

remote-ssh
ms-
0.42.2

remote-ssh-edit
ms-
0.42.2

remote-ssh-explorer
ms-
0.42.2

remote-wsl
ms-
0.38.2

vscode-remote-extensionpack
ms-
0.15.0

I can't repro this on mac or Windows. Can you repro on another machine?

I've asked a colleague to test this and he doesn't see what I'm seeing.
What can I do/test in order to progress this? What other information can I provide?

Just in case, I was using 2.20.1.windows.1. I've upgraded to 2.22.0.windows.1 but I'm still seeing the same problem.

Not really sure. Do you only have one git installed?

I've got "Git for Windows" installed and, from the git output that VS Code displays, that is the git executable that is being used, in that the version number displayed by VS Code matches the version of GfW that I upgraded to yesterday.
Are there any git commands I can run to try and help with this? I tried manually running the commands that VS Code is using (from the output window) but I think I'm not seeing everything that VS Code sends to git.

I think I'm not seeing everything that VS Code sends to git.

Code does nothing other than what's on the git output.
Not sure... never really seem this before. Which 33 files are modified?

It looks like it may be something odd either with my copy of the repository or with Git for Windows.
I was previously running "git status" under WSL and getting no errors. Now, if I run "git status" under Windows, I see the same 33 modified files that VS Code is seeing but I cannot clear those "changes". I can't remember whether I cloned the repo via Windows or WSL but I'll start again and see what happens.
Apologies for the noise.

Confirmed - if I clone the repo using WSL onto a Windows filing system, it messes things up somehow. I have to clone the repo using Windows.


Configuration service doesn't report parseErrors anymore

VSCode Version: master

Following tasks.json. It clearly has a parse error since the array for the first args is not closed.
{
    "version": "2.0.0",
    "echoCommand": true,
    "tasks": [
        {
            "taskName": "tsc",
            "command": ".\\node_modules\\.bin\\tsc.cmd",
            "args": [
                "-w"
            ,
            "isShellCommand": true,
            "isBackground": true,
            "problemMatcher": "$tsc-watch",
            "isBuildCommand": true
        },
        {
            "taskName": "dir",
            "command": "dir",
            "options": {
                "cwd": "p:\\tmp"
            },
            "isShellCommand": true,
            "showOutput": "always",
            "dependsOn": ["dir2"]
        },
        {
            "taskName": "dir2",
            "command": "dir",
            "options": {
                "cwd": "C:\\Users\\dirkb"
            },
            "isShellCommand": true,
            "showOutput": "always"
        },
        {
            "taskName": "super",
            "dependsOn": ["dir"]
        },
        {
            "taskName": "Expand Issue",
            "command": "echo %HOMEDRIVE%%HOMEPATH%",
            "isShellCommand": true,
            "isBackground": false
        },
        {
            "taskName": "Path",
            "command": "echo",
            "args": [
                "%PATH%"
            ],
            "isShellCommand": true
        },
        {
            "taskName": "Client Build",
            "command": "dir",
            "isShellCommand": true,
            "options": {
                "cwd": "${workspaceRoot}/client"
            }

        },
        {
            "taskName": "Server Build",
            "command": "dir",
            "isShellCommand": true,
            "options": {
                "cwd": "${workspaceRoot}/server"
            }
        },
        {
            "taskName": "Build",
            "dependsOn": ["Client Build", "Server Build"]
        }
    ]
}

this.configurationService.getConfiguration<TaskConfig.ExternalTaskRunnerConfiguration>('tasks');

doesn't report any parse errors (e.g $parseErrors not set on the returned object)

Not sure if @sandy081 or @aeschli. Can you please have a look. The task framework can't detect invalid json anymore.

@dbaeumer
ConfigurationService always used to skip the invalid json. It is designed to parse and resolve the valid content from the configuration files. It never reports errors.
If you let me know the use case then I can enhance the Service as per the requirement.

@sandy081 hmm, why did @aeschli teach me then to check for $parseErrors property on the return config literal. I am pretty sure that this used to work.

@dbaeumer I looked back at the previous configuration service code (before I refactored) and it was not holding any parse errors from configuration files. ConfigurationService APIs simple enough to return a value given a key. I think we would need a new API to get parse errors.

@sandy081 talked to @aeschli again and he starts to remember the $parseError property.

@dbaeumer Let me know if you still has the requirement for it? Otherwise I would like to close it as you are the only requestor of this.

@sandy081 if a file has parse errors what will I get back then. I would like to show a message to the user that the file content can't be read.

The parser (@aeschli 's json parser) I use tries to recover from errors and read the configuration without bailing out. Worst case you get an empty object.

From a user perspective I would expect a different error message whether there was a parse error or an empty tasks.json file. But if this is hard to achieve I am OK to close since there has not been an outside report of this yet.

I would opt to close it and open it when there is an outside request for it.


Any update on iOS Safari, Chrome and Firefox?

SpeechRecognition API works seamlessly on desktop platforms ( haven't tested on Android ) but not currently working on iOS browsers. Any update regarding this issue?

It works for me in Android but I can not find a way to make it work on iOS (13).
I also have a stackoverflow question open about it.


Failed to consume XCFramework built for distribution

Goals
I am trying to build Realm as an XCFramework with ABI stability and use it in our app. For that, I am setting REALM_BUILD_LIBRARY_FOR_DISTRIBUTION = YES; in RealmSwift.xcconfig file and then building an xcframework with Xcode 12.5. After successfully generating the frameworks (Realm and RealmSwift), I am then importing them into my project and building the app with Xcode 13 beta.
Expected Results
My application successfully builds with a different version of the swift compiler.
Actual Results
We get errors:
Failed to build module 'RealmSwift'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.4 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)', while this compiler is 'Apple Swift version 5.5 (swiftlang-13<IP_ADDRESS> clang-13<IP_ADDRESS>)'). Please select a toolchain which matches the SDK.
Steps for others to Reproduce

Make sure Xcode 12.5 toolchain is selected for the command line build.
Set REALM_BUILD_LIBRARY_FOR_DISTRIBUTION to YES in RealmSwift.xcconfig file
Run script: ./build.sh xcframework ios
From the build/ folder, grab both Realm and RealmSwift xcframework files and drag them into the sample project
Build the app with Xcode 13

Code Sample
Sample project can be found at
https://github.com/dcacenabes/ABIDemo
Version of Realm and Tooling

Realm framework version: 10.8.0
Xcode version: 12.5 and 13.0 beta
iOS/OSX version: ios 14 and 15
Dependency manager + version: Tried both with Cocoapods and manually adding the framework to the project. Same result.

If you're building the xcframeowrk with Xcode 12.5, which is using Swift 5.4 tools, is your xcframework building in an app using Xcode 12.5?
Are you able to build the xcframework with 13.0 beta so that it's built with Swift 5.5?
Sorry if I'm misunderstanding something.

If you're building the xcframeowrk with Xcode 12.5, which is using Swift 5.4 tools, is your xcframework building in an app using Xcode 12.5?
Are you able to build the xcframework with 13.0 beta so that it's built with Swift 5.5?
Sorry if I'm misunderstanding something.

That is exactly what happens, I build XCFramework with Xcode 12.5 with Swift 5.4.
I can use the framework in an app building with Xcode 12.5 and Swift 5.4
If I try to build the same App using Xcode 13 beta (Swift 5.5) I get the error mentioned above:
Failed to build module 'RealmSwift'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.4 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)', while this compiler is 'Apple Swift version 5.5 (swiftlang-13<IP_ADDRESS> clang-13<IP_ADDRESS>)'). Please select a toolchain which matches the SDK.
I am setting REALM_BUILD_LIBRARY_FOR_DISTRIBUTION to YES, so the XCFramework should be compatible with other versions of the swift compiler.
As stated in this comment, Realm supports library evolution:
https://github.com/realm/realm-cocoa/issues/7258#issuecomment-843925170

I am facing the same issue. Did you find any solution for this problem?

I am facing the same issue. Did you find any solution for this problem?

Unfortunately not

@dcacenabes Does this issue happen for you with the latest Xcode beta?

@dcacenabes Does this issue happen for you with the latest Xcode beta?

Do you mean building the Realm SDK with BUILD_LIBRARY_FOR_DISTRIBUTION enabled or build the app that uses the library built in an older Xcode version ?

@dcacenabes I think what @leemaguire is trying to ask is if you have tried to built the XCFramework with the REALM_BUILD_LIBRARY_FOR_DISTRIBUTION flag with the latest Xcode release (Xcode 13 as today).

I think I've found the root cause of the issue. In my investigation I found myself getting these errors (in the below image) along with 'Failed to build module 'RealmSwift'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.4.2'

I then removed all occurrences of Realm. before the obj-c types present in the swiftinterface file. After a clean and build it succeeded and ran on Xcode 13.3.1 with an XCFramework built on Xcode 12.5.1.
The next step is to figure out a way to avoid the name collision when building with older versions of Xcode. Ideally we could use -Xfrontend -module-interface-preserve-types-as-written but that will strip out all module names before types and we don't want that.

Hey @leemaguire
Thank you so much for all your contributions.
I'm just trying to use the library evolution on my local setup.
So I'm downloading the xcframework from the assets here v10.28.0, but getting the same error
Module compiled with Swift x.x.x cannot be imported by Swift x.x.x
Am I missing something. Can you point me in right way if possible?


What OS are people successfully building on?

With a number of users being unable to build due to #353 can I ask what OS people are successfully building on, also, which version of OpenSSL they have installed.
Thanks!
@butor - I think that your assistance would be greatly appreciated.

@emcxh35 I currently use:

Ubuntu 16.04.3 LTS
OpenSSL 1.0.2g  1 Mar 2016

I build on

Ubuntu 16.04.3 LTS + OpenSSL 1.0.2g
macOS High Sierra 10.13.3 + OpenSSL 1.0.2n

macOS Sierra 10.12.6

@emcxh35 I successfully setup on:
OS X El Capitan Version 10.11.1

Ubuntu 17.10
OpenSSL 1.0.2g

Failing to build -

Ubuntu 16.04 LTS
OpenSSL 1.0.2g

Docker on Centos7 works fine


"parsing failed,[object Object]" in Debug Console

I regularly get a parsing failed,[object Object] in the Debug Console of VS Code, which I find kind of irritating: I had a problem to get the Debugger started, and thought this might be related. Turned out that this error message had nothing to do with it.
I'd propose:
a) either do not log this message (maybe vs code has some kind of log level?). In its current form its not helpful.
b) or make the message text a bit more meaningful (what's inside the object? what was tried to be parsed?).

Hmm, I don't know where this message comes from or how it ends up in the debug console. I only send messages to the console that come from Firefox or my adapter (and in the latest version of the adapter the latter never show up unless they're explicitly configured using the log configuration property).
Do you have a test case for this? I'd like to track this down because it may point to something going wrong that could cause more trouble down the line.

hey, here's a test case to reproduce:
parsingfailed.zip
I could not get the warning with the minimal test case as given in https://github.com/hbenl/vscode-firefox-debug/issues/14#issuecomment-250726690 so it probably includes some unneeded stuff as well.
Anyway, just unzip, cd into the project folder and start a webserver, e.g. with  python -m SimpleHTTPServer 8082. Then open the project folder in VS and launch Fx: Launch localhost. You do not acually need to set any breakpoint to get the warning:

Edit: I'm just getting this warning using the Fx Developer Edition (which is Aurora 51.0a2 (2016-09-29)), but not the current release version 49. I just noticed now. Anyway, it would still worthwhile to:

Make the 'parsing failed' warning a bit more verbose (which Message was not parsed successfully)
Still fix the error as Version 51 while hit Release in 12 weeks.

The message apparently comes from the file src/js/components/map/heatmapLayer.js in your project:
...
      }).catch(function(ex) {
        console.log('parsing failed', ex);
      });

The second argument to the console.log call is an object and since I can only send strings to the debug console, it shows up as [object Object].

hui, that's, well, embarrassing  :running: Sorry for the hassle

No problem :smile:


#257 get rid of start page; assert error messages of browser.conditions

Resolves #257

Codecov Report

Merging #259 (ed0afb9) into master (5361938) will decrease coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   61.89%   61.51%   -0.38%
==========================================
  Files          32       32
  Lines        1850     1850
  Branches      118      118
==========================================
- Hits         1145     1138       -7
- Misses        674      682       +8
+ Partials       31       30       -1

Flag
Coverage Δ

unittests
61.51% <ø> (-0.38%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

selene/core/entity.py
58.25% <0.00%> (-1.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5361938...ed0afb9. Read the comment docs.

Codecov Report

Merging #259 (ed0afb9) into master (5361938) will decrease coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   61.89%   61.51%   -0.38%
==========================================
  Files          32       32
  Lines        1850     1850
  Branches      118      118
==========================================
- Hits         1145     1138       -7
- Misses        674      682       +8
+ Partials       31       30       -1

Flag
Coverage Δ

unittests
61.51% <ø> (-0.38%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

selene/core/entity.py
58.25% <0.00%> (-1.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5361938...ed0afb9. Read the comment docs.

Code coverage has fallen down because of method open() of custom Browser().
It will be fixed in acceptance tests.

Code coverage has fallen down because of method open() of custom Browser().
It will be fixed in acceptance tests.

Code coverage has fallen down because of method open() of custom Browser().
It will be fixed in acceptance tests.

Raised code coverage back up and little more in two acceptance tests in this PR: https://github.com/yashaka/selene/blob/c36399a67b854eca2c366343612343e34d31616b/tests/acceptance/custom_browser/test_ecosia.py
and
https://github.com/yashaka/selene/blob/c36399a67b854eca2c366343612343e34d31616b/tests/acceptance/shared_browser/test_ecosia.py

Code coverage has fallen down because of method open() of custom Browser().
It will be fixed in acceptance tests.

Raised code coverage back up and little more in two acceptance tests in this PR: https://github.com/yashaka/selene/blob/c36399a67b854eca2c366343612343e34d31616b/tests/acceptance/custom_browser/test_ecosia.py
and
https://github.com/yashaka/selene/blob/c36399a67b854eca2c366343612343e34d31616b/tests/acceptance/shared_browser/test_ecosia.py


HDDS-1780. TestFailureHandlingByClient tests are flaky.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
11
https://github.com/apache/hadoop/pull/1073 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/1073

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1073/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
134
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
75
Maven dependency ordering for branch

+1
mvninstall
648
trunk passed

+1
compile
308
trunk passed

+1
checkstyle
78
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
951
branch has no errors when building and testing our client artifacts.

+1
javadoc
167
trunk passed

0
spotbugs
335
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
546
trunk passed

-0
patch
377
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

0
mvndep
31
Maven dependency ordering for patch

+1
mvninstall
455
the patch passed

+1
compile
266
the patch passed

+1
javac
266
the patch passed

+1
checkstyle
75
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
745
patch has no errors when building and testing our client artifacts.

+1
javadoc
174
the patch passed

+1
findbugs
547
the patch passed

_ Other Tests _

+1
unit
343
hadoop-hdds in the patch passed.

-1
unit
2421
hadoop-ozone in the patch failed.

+1
asflicense
43
The patch does not generate ASF License warnings.

8182

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.hdds.scm.pipeline.TestNodeFailure

hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.hdds.scm.pipeline.TestSCMRestart

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.hdds.scm.pipeline.TestNode2PipelineMap

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1073/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1073

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8cbace0aa0a3 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d21eccf

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1073/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1073/2/testReport/

Max. process+thread count
5408 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1073/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@adoroszlai , the test failure pointed is tracked by HDDS-1804 separately as the root cause for intermittent failure is same.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
69
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
20
Maven dependency ordering for branch

+1
mvninstall
462
trunk passed

+1
compile
249
trunk passed

+1
checkstyle
69
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
894
branch has no errors when building and testing our client artifacts.

+1
javadoc
155
trunk passed

0
spotbugs
306
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
495
trunk passed

-0
patch
348
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

0
mvndep
31
Maven dependency ordering for patch

+1
mvninstall
424
the patch passed

+1
compile
256
the patch passed

+1
javac
256
the patch passed

+1
checkstyle
74
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
730
patch has no errors when building and testing our client artifacts.

+1
javadoc
169
the patch passed

+1
findbugs
574
the patch passed

_ Other Tests _

-1
unit
336
hadoop-hdds in the patch failed.

-1
unit
2014
hadoop-ozone in the patch failed.

+1
asflicense
43
The patch does not generate ASF License warnings.

7226

Reason
Tests

Failed junit tests
hadoop.hdds.scm.container.placement.algorithms.TestContainerPlacementFactory

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestBCSID

hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer

hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.container.server.TestSecureContainerServer

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1073/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1073

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4fe98145f0c4 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3dc256e

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1073/3/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1073/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1073/3/testReport/

Max. process+thread count
5297 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1073/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thanks @mukul1987 @adoroszlai and @supratimdeka for the review. I have committed this change to trunk.


Helix diameter incorrect in tutorial documentation

see: https://github.com/terrapower/armi/blob/master/armi/tests/tutorials/anl-afci-177-blueprints.yaml#L12-L23
The helix diameter for the ANL-AFCI-177 inputs should be 0.8888 cm based on the Table 4.4 of https://publications.anl.gov/anlpubs/2008/05/61507.pdf, but currently is set to 0.84825 cm in the blueprints file. The helix diameter should be equivalent to the pin pitch, which is also defined as the Wire OD + Clad OD. Currently, the 0.84825 cm is calculated incorrectly as Wire OD / 2.0 + Clad OD.

Yeah I dunno if it'd be more clear in the helix component as helixdiameter = 2* helixradius = 2*(clad radius + wire radius) = 2*(cladOD/2 + wireOD/2) = cladOD + wireOD. Nice catch.

@ntouran, is there even a reason to have helixDiameter as a parameter since it seems over specified? What is it physically mean to have a helixDiameter smaller or larger than the Wire OD + Clad OD? Does larger imply "slop" in the pin lattice?


misc: document differences with sprig

Please exprime yourself
sprout changed behavior of some functions. It would be great to have a place with the list of behavior changes.
At least:

https://github.com/go-sprout/sprout/pull/35
https://github.com/go-sprout/sprout/pull/34
removed functions

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello @sathieu,
Thank you for bringing this to our attention. I agree with you that this point requires a clear migration process, particularly when considering the differences between implementations aimed at resolving bugs versus adding unit tests. Our goal is also to remove all panics from the templating system.
Best regards,
Atom


APPS-1225-add-file-object-metadata

This PR is to add metadata field in the CWL File Object. It is not explicitly supported by CWL v1.2.0 standard, however, cwltool could parse it as a valid map, so users could couple some metadata along with the supplied File object, and propagate them to the Javascript expressions.
Full support of File metadata is expected later this year in CWL v1.2.1. This PR is a quick implementation of metadata that is used only on DNAnexus platform.
The metadata field is stringified during compilation and then deserialized back to the JSON map in the execution env on the DNAnexus platform.
The purpose of stringifying the metadata field is that:

when translating each field its data type is fixed. For example, the File location field is expected to be a URI and the size is required to be an integer. But the metadata field will have no such limit, in other words, any JSON type might appear.

Therefore, stringifying the whole metadata field can help safely pack all the metadata values in their original format, so later cwltool can properly process it when executing the source code.

RELEASE_NOTES pending

RELEASE_NOTES pending

Shall we make this metadata visible to the users at this stage? @commandlinegirl @emiloslavsky

@YuxinShi0423 the introductory comment needs to be updated; it currently says "The metadata field is stringified during compilation and then deserialized back to the JSON map in the execution env on the DNAnexus platform...."
Please document metadata support as "under development, pending inclusion in CWL standard".


[REVIEWS] HELP NEEDED WITH ISSUES!

As you may have noticed, we have a long list of issues here.
We need a brave soul to check whether we have any issues that have been dealt with - and please report to me whether there are any issues that may be closed (if the corresponding code has already been implemented, for example).
Since we are still looking for more reviewers for NeoAlgo, if you are interested in becoming a reviewer and help us manage this repo, this is a great test for you.
Please reply to this topic if you are interested in helping!
-Ricardo

I'm interested.

Do you want to get started with this #306 then?

Yes.

@ricardoprins Can I help you with reviewing codes too? There are people who have been assigned issues a month back but we haven't heard anything from them yet.

Hey, can somebody merge my pull request for issue #392

I am really interested in reviewing it.


Missing equal sign in ENV

See https://github.com/Senzing/template-go/issues/30

Pull requests:

https://github.com/Senzing/serve-grpc/pull/66


Embedding The Icon

There is a use case to embed an icon in the chart.
The case is for charts that could be used offline (e.g., airgapped environments).
I can see two ways to accomplish this.

Use a DataURL and embed it on the icon property in the Chart.yaml file.
Add the ability to have an icon file to the packaged chart.

Thoughts? Implications?

duplicate of https://github.com/helm/helm/issues/2943?

Given the discussion in https://github.com/helm/helm/issues/2943#issuecomment-331515888, I'm wondering if the chart icon should be part of the chart repository index instead of the chart itself, and if so, perhaps the proposal of a localized icon reference should be part of that discussion.
Then again, that would be a breaking change and would likely warrant a change in Helm 4. Hopefully that gives some extra food for thought.

@bacongobbler I can head over there and comment. It shouldn't be part of the repository because that will not work for OCI registries.
I'll close this as a duplicate.


Fail to build app with custom source dir

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

CLI: next
Cross-platform modules: next
Android Runtime: next
iOS Runtime: next
Plugin(s): No

Describe the bug
Apps created with custom src and prefix can not be build.
To Reproduce
Steps:
ng new --collection=@nativescript/schematics TestApp --prefix=myapp --sourceDir=mysrc --style=css
TestApp/node_modules/.bin/update-app-ng-deps
TestApp/node_modules/.bin/update-ns-webpack --deps --configs
tns run android --path TestApp --bundle

Result:
Skipping node_modules folder! Use the syncAllFiles option to sync files from this folder.
Searching for devices...
Executing before-liveSync hook from /Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/hooks/before-liveSync/nativescript-angular-sync.js
Executing before-watchPatterns hook from /Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/hooks/before-watchPatterns/nativescript-dev-typescript.js
Executing before-watchPatterns hook from /Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/hooks/before-watchPatterns/nativescript-dev-webpack.js
Executing before-watch hook from /Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/hooks/before-watch/nativescript-dev-typescript.js
Hook skipped because bundling is in progress.
Executing before-watch hook from /Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/hooks/before-watch/nativescript-dev-webpack.js
Running webpack for Android...
/Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/node_modules/webpack-cli/bin/cli.js:244
				throw err;
				^

Error: The specified path to app directory /Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/app does not exist. Unable to find entry module.
    at verifyEntryModuleDirectory (/Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/node_modules/nativescript-dev-webpack/index.js:79:9)
    at Object.exports.getEntryModule (/Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/node_modules/nativescript-dev-webpack/index.js:30:2)
    at module.exports.env (/Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/webpack.config.js:54:38)
    at handleFunction (/Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/node_modules/webpack-cli/bin/prepareOptions.js:23:13)
    at prepareOptions (/Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/node_modules/webpack-cli/bin/prepareOptions.js:9:5)
    at requireConfig (/Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/node_modules/webpack-cli/bin/convert-argv.js:136:14)
    at /Users/nsbuilduser/workspace/master-schematics-smoke-osx/TestApp/node_modules/webpack-cli/bin/convert-argv.js:142:17

Expected behavior
No errors when building an app.

Looks to be not a valid issue.
I pass --sourceDir=mysrc and did not pass --shared.
Docs do not say I can pass --sourceDir on not shared project, so it looks not supported scenario.


No Symbol Outline & Document Not Found In Newer Versions Of Marksman (KDE Kate Text Editor)

Hi, I use Marksman in the Kate text editor primarily for the symbols outline on singular markdown files (no git repo or marksman.toml). and the symbol outline (list of headings) has been working fine until a recent update.
Under the Symbol Outline section, it displays nothing. instead of the typical headings, and also instead of "No LSP server for this document".
I now get a Document not found warning when I try to edit the file.
marksman version: 20230605-1  (latest arch package)
I've tried using 2023-06-23 from releases as well, but same issue.
Kate LSP config:
~/.config/kate/lspclient/settings.json
{
    "servers": {
        "markdown":
        {
            "command": ["marksman", "server"],
            "rootIndicatorFileNames": [".git", ".marksman.toml"],
            "url": "https://github.com/artempyanykh/marksman",
            "highlightingModeRegex": "^Markdown$"
        }
    }
}

Kate LSP log in output widget:
[11:06:08 ￼ LSP Client Log] Started server markdown@/home/ethan: /usr/bin/marksman server
[11:06:08 ￼ LSP Server Log] markdown@/home/ethan
[11:06:08 INF]  Starting Marksman LSP server: {}
[11:06:14 ￼ LSP Server Log] markdown@/home/ethan
[11:06:13 WRN]  Document not found: {"uri": "{ uri = \"file:///home/ethan/work/work.md\"\n  data = AbsPath \"/home/ethan/work/work.md\" }", "method": "textDocumentDidChange"}

@Megaguy32 thanks for reporting. What was the last version that worked for you?

@artempyanykh last version to work is 2023-04-12.    2023-06-01 has the issue

Ok, good to know! @Megaguy32 could you please change the command to "command": ["marksman", "server", "-v=5"], and paste LSP log from Kate? I have a feeling that something might be off with path resolution but need to see verbose output from Marksman to debug further.
Would be extra great if you could do it both work 2023-04-12 (working) and 2023-06-01 (buggy)!

2023-04-12
[12:55:21 ￼ LSP Client Log] Started server markdown@/home/ethan: /home/ethan/.local/bin/marksman server -v=5
[12:55:21 ￼ LSP Server Log] markdown@/home/ethan
[12:55:21 INF]  Starting Marksman LSP server: {}
[12:55:21 ￼ LSP Server Log] markdown@/home/ethan
[12:55:21 VRB]  Preparing to start background agent: {}
[12:55:21 ￼ LSP Server Log] markdown@/home/ethan
[12:55:21 VRB]  StatusAgent starting: {}
[12:55:21 ￼ LSP Server Log] markdown@/home/ethan
[12:55:21 DBG]  Obtained workspace folders: {"workspace": []}
[12:55:21 ￼ LSP Server Log] markdown@/home/ethan
[12:55:21 VRB]  No user config found: {"path": "/home/ethan/.config/marksman/config.toml"}
[12:55:21 ￼ LSP Server Log] markdown@/home/ethan
[12:55:21 DBG]  Completed reading workspace folders: {"numNotes": 0, "numFolders": 0}
[12:55:21 ￼ LSP Server Log] markdown@/home/ethan
[12:55:21 DBG]  Configured text sync: {"kind": "Full", "source": "default"}
[12:55:21 ￼ LSP Server Log] markdown@/home/ethan
[12:55:21 DBG]  Finished workspace initialization. Waiting for the `initialized` notification from the client.: {}
[12:55:22 ￼ LSP Server Log] markdown@/home/ethan
[12:55:22 VRB]  Received a message: {"type": "MutateState"}
[12:55:22 ￼ LSP Server Log] markdown@/home/ethan
[12:55:22 DBG]  Received `initialized` notification from the client. Setting up background services.: {}
[12:55:22 DBG]  Client doesn't support status notifications. Agent won't be initialized.: {}
[12:55:22 DBG]  Initialization complete.: {}
[12:55:22 ￼ LSP Server Log] markdown@/home/ethan
[12:55:22 VRB]  Processing a hook: {"curRev": 0, "prevRev": null, "name": "diag"}
[12:55:22 ￼ LSP Server Log] markdown@/home/ethan
[12:55:22 VRB]  Adding a hook: {"name": "diag"}
[12:55:22 ￼ LSP Server Log] markdown@/home/ethan
[12:55:22 VRB]  Received a message: {"type": "MutateState"}
[12:55:22 ￼ LSP Server Log] markdown@/home/ethan
[12:55:22 VRB]  Updating state: {"nextRev": 1, "curRev": 0}
[12:55:22 ￼ LSP Server Log] markdown@/home/ethan
[12:55:22 VRB]  Processing a hook: {"curRev": 1, "prevRev": "Some(0)", "name": "diag"}
[12:55:22 VRB]  Received a message: {"type": "ReadState"}
[12:55:22 VRB]  Received a message: {"type": "ReadState"}
[12:55:22 ￼ LSP Server Log] markdown@/home/ethan
[12:55:22 VRB]  Updating folder diag: {"num_docs": 1, "folder": "FolderId { uri = \"file:///home/ethan/work/work.md\"\n           localPath = \"/home/ethan/work/work.md\" }"}
[12:55:22 ￼ LSP Server Log] markdown@/home/ethan
[12:55:22 VRB]  Received a message: {"type": "ReadState"}
[12:55:28 ￼ LSP Server Log] markdown@/home/ethan
[12:55:28 VRB]  Received a message: {"type": "MutateState"}
[12:55:28 ￼ LSP Server Log] markdown@/home/ethan
[12:55:28 VRB]  Processing text change: {"newVersion": "Some(1)", "currentVersion": "Some(0)", "uri": "{ uri = \"file:///home/ethan/work/work.md\"\n  localPath = \"/home/ethan/work/work.md\" }"}
[12:55:28 ￼ LSP Server Log] markdown@/home/ethan
[12:55:28 VRB]  Updating state: {"nextRev": 2, "curRev": 1}
[12:55:28 VRB]  Processing a hook: {"curRev": 2, "prevRev": "Some(1)", "name": "diag"}
[12:55:28 VRB]  Received a message: {"type": "ReadState"}
[12:55:28 ￼ LSP Server Log] markdown@/home/ethan
[12:55:28 VRB]  Updating folder diag: {"num_docs": 1, "folder": "FolderId { uri = \"file:///home/ethan/work/work.md\"\n           localPath = \"/home/ethan/work/work.md\" }"}
[12:55:28 ￼ LSP Server Log] markdown@/home/ethan
[12:55:28 VRB]  Received a message: {"type": "ReadState"}

2023-06-21
[12:59:20 ￼ LSP Client Log] Started server markdown@/home/ethan: /home/ethan/.local/bin/marksman server -v=5
[12:59:20 ￼ LSP Server Log] markdown@/home/ethan
[12:59:20 INF]  Starting Marksman LSP server: {}
[12:59:20 ￼ LSP Server Log] markdown@/home/ethan
[12:59:20 VRB]  Preparing to start background agent: {}
[12:59:20 ￼ LSP Server Log] markdown@/home/ethan
[12:59:20 VRB]  StatusAgent starting: {}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 DBG]  Obtained workspace folders: {"workspace": []}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 VRB]  No user config found: {"path": "/home/ethan/.config/marksman/config.toml"}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 DBG]  Completed reading workspace folders: {"numNotes": 0, "numFolders": 0}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 DBG]  Configured text sync: {"kind": "Full", "source": "default"}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 DBG]  Finished workspace initialization. Waiting for the `initialized` notification from the client.: {}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 VRB]  Received a message: {"type": "MutateState"}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 DBG]  Received `initialized` notification from the client. Setting up background services.: {}
[12:59:21 DBG]  Client doesn't support status notifications. Agent won't be initialized.: {}
[12:59:21 DBG]  Initialization complete.: {}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 VRB]  Processing a hook: {"curRev": 0, "prevRev": null, "name": "diag"}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 VRB]  Adding a hook: {"name": "diag"}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 VRB]  Received a message: {"type": "MutateState"}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 VRB]  Updating state: {"nextRev": 1, "curRev": 0}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 VRB]  Processing a hook: {"curRev": 1, "prevRev": "Some(0)", "name": "diag"}
[12:59:21 VRB]  Received a message: {"type": "ReadState"}
[12:59:21 VRB]  Received a message: {"type": "ReadState"}
[12:59:21 ￼ LSP Server Log] markdown@/home/ethan
[12:59:21 VRB]  Updating folder diag: {"num_docs": 1, "folder": "{ uri = \"file:///home/ethan/work/work.md/.\"\n  data = RootPath (AbsPath \"/home/ethan/work/work.md/.\") }"}
[12:59:26 ￼ LSP Server Log] markdown@/home/ethan
[12:59:26 VRB]  Received a message: {"type": "MutateState"}
[12:59:26 ￼ LSP Server Log] markdown@/home/ethan
[12:59:26 WRN]  Document not found: {"uri": "{ uri = \"file:///home/ethan/work/work.md\"\n  data = AbsPath \"/home/ethan/work/work.md\" }", "method": "textDocumentDidChange"}
[12:59:26 VRB]  Received a message: {"type": "ReadState"}
[12:59:26 ￼ LSP Server Log] markdown@/home/ethan
[12:59:26 VRB]  Received a message: {"type": "ReadState"}

This is super-helpful @Megaguy32, thanks!
It seems the problem is in single-file mode. As a work-around you may want to create .marksman.toml inside /home/ethan/work -- I think this should fix path resolution problem.

(v2023-06-01)
cd ~/work
touch .marksman.toml

despite creating the file the issue persists
[15:45:45 ￼ LSP Client Log] Started server markdown@/home/ethan: /home/ethan/.local/bin/marksman server -v=5
[15:45:46 ￼ LSP Server Log] markdown@/home/ethan
[15:45:46 INF]  Starting Marksman LSP server: {}
[15:45:46 ￼ LSP Server Log] markdown@/home/ethan
[15:45:46 VRB]  Preparing to start background agent: {}
[15:45:46 ￼ LSP Server Log] markdown@/home/ethan
[15:45:46 VRB]  StatusAgent starting: {}
[15:45:46 ￼ LSP Server Log] markdown@/home/ethan
[15:45:46 DBG]  Obtained workspace folders: {"workspace": []}
[15:45:46 ￼ LSP Server Log] markdown@/home/ethan
[15:45:46 VRB]  No user config found: {"path": "/home/ethan/.config/marksman/config.toml"}
[15:45:46 ￼ LSP Server Log] markdown@/home/ethan
[15:45:46 DBG]  Completed reading workspace folders: {"numNotes": 0, "numFolders": 0}
[15:45:46 ￼ LSP Server Log] markdown@/home/ethan
[15:45:46 DBG]  Configured text sync: {"kind": "Full", "source": "default"}
[15:45:46 ￼ LSP Server Log] markdown@/home/ethan
[15:45:46 DBG]  Finished workspace initialization. Waiting for the `initialized` notification from the client.: {}
[15:45:47 ￼ LSP Server Log] markdown@/home/ethan
[15:45:47 VRB]  Received a message: {"type": "MutateState"}
[15:45:47 ￼ LSP Server Log] markdown@/home/ethan
[15:45:47 DBG]  Received `initialized` notification from the client. Setting up background services.: {}
[15:45:47 DBG]  Client doesn't support status notifications. Agent won't be initialized.: {}
[15:45:47 DBG]  Initialization complete.: {}
[15:45:47 ￼ LSP Server Log] markdown@/home/ethan
[15:45:47 VRB]  Processing a hook: {"curRev": 0, "prevRev": null, "name": "diag"}
[15:45:47 ￼ LSP Server Log] markdown@/home/ethan
[15:45:47 VRB]  Adding a hook: {"name": "diag"}
[15:45:47 ￼ LSP Server Log] markdown@/home/ethan
[15:45:47 VRB]  Received a message: {"type": "MutateState"}
[15:45:47 ￼ LSP Server Log] markdown@/home/ethan
[15:45:47 VRB]  Updating state: {"nextRev": 1, "curRev": 0}
[15:45:47 ￼ LSP Server Log] markdown@/home/ethan
[15:45:47 VRB]  Processing a hook: {"curRev": 1, "prevRev": "Some(0)", "name": "diag"}
[15:45:47 VRB]  Received a message: {"type": "ReadState"}
[15:45:47 VRB]  Received a message: {"type": "ReadState"}
[15:45:47 ￼ LSP Server Log] markdown@/home/ethan
[15:45:47 VRB]  Updating folder diag: {"num_docs": 1, "folder": "{ uri = \"file:///home/ethan/work/work.md/.\"\n  data = RootPath (AbsPath \"/home/ethan/work/work.md/.\") }"}
[15:45:49 ￼ LSP Server Log] markdown@/home/ethan
[15:45:49 VRB]  Received a message: {"type": "MutateState"}
[15:45:49 ￼ LSP Server Log] markdown@/home/ethan
[15:45:49 WRN]  Document not found: {"uri": "{ uri = \"file:///home/ethan/work/work.md\"\n  data = AbsPath \"/home/ethan/work/work.md\" }", "method": "textDocumentDidChange"}
[15:45:49 VRB]  Received a message: {"type": "ReadState"}
[15:45:50 ￼ LSP Server Log] markdown@/home/ethan
[15:45:50 VRB]  Received a message: {"type": "ReadState"}

but initiating a git repo solves the problem
rm .marksman.toml
git init

[15:48:37 ￼ LSP Client Log] Started server markdown@/home/ethan: /home/ethan/.local/bin/marksman server -v=5
[15:48:38 ￼ LSP Server Log] markdown@/home/ethan
[15:48:38 INF]  Starting Marksman LSP server: {}
[15:48:38 ￼ LSP Server Log] markdown@/home/ethan
[15:48:38 VRB]  Preparing to start background agent: {}
[15:48:38 ￼ LSP Server Log] markdown@/home/ethan
[15:48:38 VRB]  StatusAgent starting: {}
[15:48:38 ￼ LSP Server Log] markdown@/home/ethan
[15:48:38 DBG]  Obtained workspace folders: {"workspace": []}
[15:48:38 ￼ LSP Server Log] markdown@/home/ethan
[15:48:38 VRB]  No user config found: {"path": "/home/ethan/.config/marksman/config.toml"}
[15:48:38 ￼ LSP Server Log] markdown@/home/ethan
[15:48:38 DBG]  Completed reading workspace folders: {"numNotes": 0, "numFolders": 0}
[15:48:38 ￼ LSP Server Log] markdown@/home/ethan
[15:48:38 DBG]  Configured text sync: {"kind": "Full", "source": "default"}
[15:48:38 ￼ LSP Server Log] markdown@/home/ethan
[15:48:38 DBG]  Finished workspace initialization. Waiting for the `initialized` notification from the client.: {}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Received a message: {"type": "MutateState"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 DBG]  Received `initialized` notification from the client. Setting up background services.: {}
[15:48:39 DBG]  Client doesn't support status notifications. Agent won't be initialized.: {}
[15:48:39 DBG]  Initialization complete.: {}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Processing a hook: {"curRev": 0, "prevRev": null, "name": "diag"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Adding a hook: {"name": "diag"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Received a message: {"type": "MutateState"}
[15:48:39 VRB]  Updating workspace folders: {"numRemoved": 0, "numAdded": 1}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Loading folder documents: {"uri": "file:///home/ethan/work"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  No folder config found: {"path": "/home/ethan/work/.marksman.toml"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/(GDrive) LSD Solutions - Master Solution Templates.desktop"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/Tailscale_OpenYourWorld.pdf"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/Virtual Backgrounds/Virtual Backgrounds-20230626T112756Z-001.zip"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/Virtual Backgrounds/Virtual Backgrounds/Option 5.png"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/Virtual Backgrounds/Virtual Backgrounds/Option 3.png"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/Virtual Backgrounds/Virtual Backgrounds/Option 2.png"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/Virtual Backgrounds/Virtual Backgrounds/Option 4.png"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/Virtual Backgrounds/Virtual Backgrounds/Option 1.png"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/Study - VTSP/.marksman.toml"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/Study - VTSP/markdown-assets/vmware-digital-foundation.jpg"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/.directory"}
[15:48:39 VRB]  Reading ignore globs: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/.gitignore"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/.kateproject.notes"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/.coverage"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/Makefile"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/pylintrc"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/requirements.txt"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/setup.py"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/ticket_id_list.txt"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/ticket_id_list"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/.gitignore"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/Mockup.Ethan.md"}
[15:48:39 VRB]  Skipping ignored directory: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/.git"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/.github/workflows/freshdesk-auto-CI.yml"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/cli.py"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/app/__init__.py"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/app/merge_tickets.py"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/app/update_tickets.py"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/app/utils.py"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/app/constants.py"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/app/api_requests.py"}
[15:48:39 VRB]  Skipping ignored directory: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/app/__pycache__"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/app/db/email_headers_to_close.txt"}
[15:48:39 VRB]  Skipping ignored directory: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/__pycache__"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/logs/logger.py"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/logs/log.py"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/src/logs/log_decorator.py"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/tests/test_cli.py"}
[15:48:39 VRB]  Skipping ignored directory: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/tests/__pycache__"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/tests/unit/logging/logging_test.py"}
[15:48:39 VRB]  Skipping ignored directory: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/.venv"}
[15:48:39 VRB]  Skipping ignored directory: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/freshdesk.egg-info"}
[15:48:39 VRB]  Skipping ignored directory: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/.pytest_cache"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/.devcontainer/Dockerfile"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/.devcontainer/devcontainer.json"}
[15:48:39 VRB]  Skipping ignored file: {"file": "/home/ethan/work/repo---freshdesk-automation/freshdesk_automation/log/freshdesk_automation.log"}
[15:48:39 VRB]  Skipping ignored directory: {"file": "/home/ethan/work/.git"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Updating state: {"nextRev": 1, "curRev": 0}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Processing a hook: {"curRev": 1, "prevRev": "Some(0)", "name": "diag"}
[15:48:39 VRB]  Received a message: {"type": "MutateState"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Updating state: {"nextRev": 2, "curRev": 1}
[15:48:39 VRB]  Processing a hook: {"curRev": 2, "prevRev": "Some(1)", "name": "diag"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Received a message: {"type": "ReadState"}
[15:48:39 VRB]  Received a message: {"type": "ReadState"}
[15:48:39 ￼ LSP Server Log] markdown@/home/ethan
[15:48:39 VRB]  Updating folder diag: {"num_docs": 5, "folder": "{ uri = \"file:///home/ethan/work\"\n  data = RootPath (AbsPath \"/home/ethan/work\") }"}
[15:48:42 ￼ LSP Server Log] markdown@/home/ethan
[15:48:42 VRB]  Received a message: {"type": "MutateState"}
[15:48:42 ￼ LSP Server Log] markdown@/home/ethan
[15:48:42 VRB]  Processing text change: {"newVersion": "Some(1)", "currentVersion": "Some(0)", "uri": "file:///home/ethan/work/work.md"}
[15:48:42 ￼ LSP Server Log] markdown@/home/ethan
[15:48:42 VRB]  Updating state: {"nextRev": 3, "curRev": 2}
[15:48:42 VRB]  Processing a hook: {"curRev": 3, "prevRev": "Some(2)", "name": "diag"}
[15:48:42 VRB]  Received a message: {"type": "ReadState"}
[15:48:42 ￼ LSP Server Log] markdown@/home/ethan
[15:48:42 VRB]  Updating folder diag: {"num_docs": 5, "folder": "{ uri = \"file:///home/ethan/work\"\n  data = RootPath (AbsPath \"/home/ethan/work\") }"}
[15:48:43 ￼ LSP Server Log] markdown@/home/ethan
[15:48:43 VRB]  Received a message: {"type": "ReadState"}

@artempyanykh
using v2023-06-01
working in a test folder now
despite making the file, the issue persists
touch .marksman.toml

[15:57:24 ￼ LSP Client Log] Started server markdown@/home/ethan: /home/ethan/.local/bin/marksman server -v=5
[15:57:24 ￼ LSP Server Log] markdown@/home/ethan
[15:57:24 INF]  Starting Marksman LSP server: {}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 VRB]  StatusAgent starting: {}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 VRB]  Preparing to start background agent: {}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 DBG]  Obtained workspace folders: {"workspace": []}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 VRB]  No user config found: {"path": "/home/ethan/.config/marksman/config.toml"}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 DBG]  Completed reading workspace folders: {"numNotes": 0, "numFolders": 0}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 DBG]  Configured text sync: {"kind": "Full", "source": "default"}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 DBG]  Finished workspace initialization. Waiting for the `initialized` notification from the client.: {}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 VRB]  Received a message: {"type": "MutateState"}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 DBG]  Received `initialized` notification from the client. Setting up background services.: {}
[15:57:25 DBG]  Client doesn't support status notifications. Agent won't be initialized.: {}
[15:57:25 DBG]  Initialization complete.: {}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 VRB]  Processing a hook: {"curRev": 0, "prevRev": null, "name": "diag"}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 VRB]  Adding a hook: {"name": "diag"}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 VRB]  Received a message: {"type": "MutateState"}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 VRB]  Updating state: {"nextRev": 1, "curRev": 0}
[15:57:25 ￼ LSP Server Log] markdown@/home/ethan
[15:57:25 VRB]  Processing a hook: {"curRev": 1, "prevRev": "Some(0)", "name": "diag"}
[15:57:25 VRB]  Received a message: {"type": "ReadState"}
[15:57:25 VRB]  Received a message: {"type": "ReadState"}
[15:57:26 ￼ LSP Server Log] markdown@/home/ethan
[15:57:26 VRB]  Updating folder diag: {"num_docs": 1, "folder": "{ uri = \"file:///home/ethan/test/test.md/.\"\n  data = RootPath (AbsPath \"/home/ethan/test/test.md/.\") }"}
[15:57:29 ￼ LSP Server Log] markdown@/home/ethan
[15:57:29 VRB]  Received a message: {"type": "MutateState"}
[15:57:29 ￼ LSP Server Log] markdown@/home/ethan
[15:57:29 WRN]  Document not found: {"uri": "{ uri = \"file:///home/ethan/test/test.md\"\n  data = AbsPath \"/home/ethan/test/test.md\" }", "method": "textDocumentDidChange"}
[15:57:29 VRB]  Received a message: {"type": "ReadState"}
[15:57:29 ￼ LSP Server Log] markdown@/home/ethan
[15:57:29 VRB]  Received a message: {"type": "ReadState"}

but making a git repo solves the problem
rm .marksman.toml
git int

[15:58:06 ￼ LSP Client Log] Started server markdown@/home/ethan: /home/ethan/.local/bin/marksman server -v=5
[15:58:06 ￼ LSP Server Log] markdown@/home/ethan
[15:58:06 INF]  Starting Marksman LSP server: {}
[15:58:06 ￼ LSP Server Log] markdown@/home/ethan
[15:58:06 VRB]  StatusAgent starting: {}
[15:58:06 ￼ LSP Server Log] markdown@/home/ethan
[15:58:06 VRB]  Preparing to start background agent: {}
[15:58:06 ￼ LSP Server Log] markdown@/home/ethan
[15:58:06 DBG]  Obtained workspace folders: {"workspace": []}
[15:58:06 ￼ LSP Server Log] markdown@/home/ethan
[15:58:06 VRB]  No user config found: {"path": "/home/ethan/.config/marksman/config.toml"}
[15:58:06 ￼ LSP Server Log] markdown@/home/ethan
[15:58:06 DBG]  Completed reading workspace folders: {"numNotes": 0, "numFolders": 0}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 DBG]  Configured text sync: {"kind": "Full", "source": "default"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 DBG]  Finished workspace initialization. Waiting for the `initialized` notification from the client.: {}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Received a message: {"type": "MutateState"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 DBG]  Received `initialized` notification from the client. Setting up background services.: {}
[15:58:07 DBG]  Client doesn't support status notifications. Agent won't be initialized.: {}
[15:58:07 DBG]  Initialization complete.: {}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Processing a hook: {"curRev": 0, "prevRev": null, "name": "diag"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Adding a hook: {"name": "diag"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Received a message: {"type": "MutateState"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Updating workspace folders: {"numRemoved": 0, "numAdded": 1}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Loading folder documents: {"uri": "file:///home/ethan/test"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  No folder config found: {"path": "/home/ethan/test/.marksman.toml"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Skipping ignored directory: {"file": "/home/ethan/test/.git"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Updating state: {"nextRev": 1, "curRev": 0}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Processing a hook: {"curRev": 1, "prevRev": "Some(0)", "name": "diag"}
[15:58:07 VRB]  Received a message: {"type": "MutateState"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Updating state: {"nextRev": 2, "curRev": 1}
[15:58:07 VRB]  Processing a hook: {"curRev": 2, "prevRev": "Some(1)", "name": "diag"}
[15:58:07 VRB]  Received a message: {"type": "ReadState"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Received a message: {"type": "ReadState"}
[15:58:07 ￼ LSP Server Log] markdown@/home/ethan
[15:58:07 VRB]  Updating folder diag: {"num_docs": 1, "folder": "{ uri = \"file:///home/ethan/test\"\n  data = RootPath (AbsPath \"/home/ethan/test\") }"}
[15:58:09 ￼ LSP Server Log] markdown@/home/ethan
[15:58:09 VRB]  Received a message: {"type": "MutateState"}
[15:58:09 ￼ LSP Server Log] markdown@/home/ethan
[15:58:09 VRB]  Processing text change: {"newVersion": "Some(1)", "currentVersion": "Some(0)", "uri": "file:///home/ethan/test/test.md"}
[15:58:09 ￼ LSP Server Log] markdown@/home/ethan
[15:58:09 VRB]  Updating state: {"nextRev": 3, "curRev": 2}
[15:58:09 VRB]  Processing a hook: {"curRev": 3, "prevRev": "Some(2)", "name": "diag"}
[15:58:09 VRB]  Received a message: {"type": "ReadState"}
[15:58:09 ￼ LSP Server Log] markdown@/home/ethan
[15:58:09 VRB]  Updating folder diag: {"num_docs": 1, "folder": "{ uri = \"file:///home/ethan/test\"\n  data = RootPath (AbsPath \"/home/ethan/test\") }"}
[15:58:10 ￼ LSP Server Log] markdown@/home/ethan
[15:58:10 VRB]  Received a message: {"type": "ReadState"}

Thanks @Megaguy32!
I reproduced the issue. Shouldn't take long to prepare a fix.

@Megaguy32 I've cut a new release that should fix the problem: https://github.com/artempyanykh/marksman/releases/tag/2023-07-01
Feel free to reopen the issue if something's still not working.


ListUniqueValuesRaster

The documentation on this tool seems confused between whether it accepts a raster or a vector:

Similarly, the QGIS algorithm does not accept raster inputs. I have not tested anything else.

Good catch! I'm not sure how no one hasn't spotted that previously.

Thanks for the quick fix. Will this also fix the QGIS plugin? (input requirements on the drop down need to be changed to rasters)

It should also fix that, but sadly won't be available until the next release.


Fix multiple requests for same image and then canceling one

SDWebImage helpfully downloads only once if a request for the same image comes in more than once while the image is still being downloaded. However, it doesn't handle canceling correctly. Only the first operation gets a handle to the download operation, and therefore is the only one which can cancel it. Moreover, if it does cancel it, then the other operations waiting on that download never complete either.
This patch changes things slightly so that the downloader gives out a "token" that can be used to cancel the request to download. It then removes callbacks for that one token, leaving the actual download operation running.

I rebased this and added a quick, required, fix.

Thanks @mattjgalloway  Question for you, are you using any particular fork?  The current state of SDWebImage is really frustrating and I see a lot of great PRs that are sitting idle.  We desperately need an edge, or prerelease version of SDWebImage so we can at least start testing.

@rromanchuk I have my own fork, which is where this PR comes from. I just have this and another PR (which was closed here) on master there.
Not sure I fully understand what you're asking, sorry :-/.

@mattjgalloway i'm looking for a public fork that is actually being maintained

We are doing our best to maintaining this one, but time was not our best friend lately. I will personally dedicate more time for this.
@rromanchuk are you interested in becoming a maintainer?

I can definitely, at the very least, get edge/pre releases well tested before before we cut a release. That way we can feel confident in releasing important pull requests that come in. This is one project that really needs real world device deployment because of the complexities and subtleties of concurrency.

Welcome!

@mattjgalloway I have taken a deeper look at this PR and there are a lot of scaring changes here. Not sure who could properly review this and make sure it's working as expected.
More than that, I think the case you are talking about is an edge case, as most people would download unique urls or even if they encounter the same url again, I don't expect a lot of cancels.
How did you come to the conclusion that the app will avoid downloading the same url twice? I can't find anything against that in our master branch code.
From where I look at this, given that the fix is huge, changes a lot of stuff plus it addresses an edge case, I would go towards not including it.
@mattjgalloway could you bring more details about the scenario that needs fixing and how did your app end up handling that? Maybe we can come up with an easier fix.

@bpoplauschi I hear you. It is scary indeed.

More than that, I think the case you are talking about is an edge case, as most people would download unique urls or even if they encounter the same url again, I don't expect a lot of cancels.

It's not that uncommon to hit this case - it is an "edge case" of sorts - but it's also something people will hit. Cancels can easily happen. Consider a cell that's loading an image. Then the cell goes off screen and the request is cancelled.

How did you come to the conclusion that the app will avoid downloading the same url twice? I can't find anything against that in our master branch code.

I'm unsure quite what you mean here. Can you elaborate please?

From where I look at this, given that the fix is huge, changes a lot of stuff plus it addresses an edge case, I would go towards not including it.

I wouldn't have shipped the app I shipped without the fix. It was causing images to not load sometimes.

@mattjgalloway could you bring more details about the scenario that needs fixing and how did your app end up handling that? Maybe we can come up with an easier fix.

I added failing tests...

On the tests front - sure, it's using my updated architecture. But you can easily see how that translates to the old architecture. Do you want me to add a failing test on top of master for this maybe?

On the tests front - sure, it's using my updated architecture. But you can easily see how that translates to the old architecture. Do you want me to add a failing test on top of master for this maybe?

Yes, that would be great.

Cancels can easily happen. Consider a cell that's loading an image. Then the cell goes off screen and the request is cancelled.

Agree, but our issue, from what I understand, is cancelling when there are multiple requests for the same url. And that is why I think this is an isolated scenario.

I'm unsure quite what you mean here. Can you elaborate please?

This is because you stated

SDWebImage helpfully downloads only once if a request for the same image comes in more than once while the image is still being downloaded.

and I was asking which code assures that we only try to download from a unique url once.
Any chance you can think of another fix that has less changes? I'm also looking at #1031 #1044 #1069 and they seem to address some cancel issues. Maybe you can take a look as well.
PS: Thanks for working with me on this.

@bpoplauschi - https://github.com/rs/SDWebImage/pull/1222 added for the failing test cases. As you'll see - pretty simple cases. The point is, the second time you call downloadImageWithURL:options:progress:completed: with the same URL, you get back nil. Moreover, if you cancel the first one, then the second never gets any completion called on it. This is bad.
Hopefully that should explain the problem entirely?
#1069 looks very very similar. I prefer my approach though :-P.

@mattjgalloway I've finally come to a conclusion regarding this PR vs #1069 and I decided this is the way to go for now. Since the changes in this PR are breaking compatibility with the 3.x versions, I will only merge it into 4.0. It would help me if you could rebase/merge with master so there are no conflicts and change the target branch to 4.0. I will very soon release 3.7.4. Thanks

@bpoplauschi Apologies for the delay in replying here!
Sure thing, I'll rebase with master shortly.

@bpoplauschi Rebase done, and tests run (they pass). Would be great if you give it a full review though since it's been a while since I wrote this.

Hi, I just came across this and really like the approach. Any updates on when it will be merged to the 4.0 branch?

Finally, I have merged this into the 4.x branch via commit 13cfc5b. It looks ok, even though the changes are a bit scary, but we will see as we move along. @mattjgalloway I have updated your solution a bit in 8a78586 by just exposing SDWebImageDownloadToken.

@bpoplauschi - yay! So happy this is getting in :-D. It is scary but I believe it to be well tested.


Publish roadmap

See https://docs.google.com/document/d/1lyfexpucSz6pyE5cajqC9BOFXAMjpLpVwjXsT0pBUDw/edit#bookmark=kix.6xjs00d03t8i

Roadmap will remain the google doc
Version-specific features will be added to the readme when a new release goes out


⚠ Bofrost.at has degraded performance

In 3ccc817, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1004 ms

Resolved: Bofrost.at performance has improved in cab741f.


Fix clearing fetch FIFO twice when CJALR fails

When CJALR fails, for example on a permit execute violation, the fetch FIFO is cleared twice, first because branch_req_spec_raw is asserted in the cheri_ex module and second because cheri_wb_err_o is asserted the next cycle. This causes the first instruction of the trap handler to be cleared and causes the PC and instruction data to get out of sync.
The solution in this commit is to not assert branch_req_spec_raw when there is an instruction fault.

First, I don't mind removing branch_req_spec_o now, that's actually the purpose of he ISA definition change (delayed address bound checking). However I'd like to understand why a speculative fetch followed by an exception in WB stage would cause PC & instruction to get out of sync? I have a little trouble seeing that from your waveform and my expectation was that the exception would flush the fetch fifo and essentially realign things.

First, I don't mind removing branch_req_spec_o now, that's actually the purpose of he ISA definition change (delayed address bound checking). However I'd like to understand why a speculative fetch followed by an exception in WB stage would cause PC & instruction to get out of sync? I have a little trouble seeing that from your waveform and my expectation was that the exception would flush the fetch fifo and essentially realign things.

My initial attempt at removing branch_req_spec_o did not work, so this may need further investigation. I agree that the waveform I've posted is not very clear. Hopefully, I have clarified this by opening the following issue: https://github.com/microsoft/cheriot-ibex/issues/28

Converting this PR to draft. The commit message is no longer correct although removing the speculative branch request may still be a good thing to do. See this issue for more details: https://github.com/microsoft/cheriot-ibex/issues/28

Closing this PR because the proposed solution causes timing issues and with the recent ISA change, bounds and permissions checking will happen before PC is written so this solution won't apply anyways.


Because github speed is too slow I can only upload photos here, a video screenshot, a renderings. But in fact do not too stable.


Release into melodic/noetic

          @facontidavide The releases did not go well. Could you please have a look at it?

Originally posted by @peci1 in https://github.com/facontidavide/ros_msg_parser/issues/15#issuecomment-1137472824
The releases still haven't been fixed. Melodic is close to being EOL. Could you please try to fix the releases?

https://github.com/ros/rosdistro/pull/31636#pullrequestreview-845807378


Building a 2024 Game using CSS,HTML,JS

this is the project. i used CSS,HTML,JS

Assigned @MonishRaman


Tree-sitter parses certain blocks as a body type

For example, in the code
PROCEDURE testCase:
    DEFINE VARIABLE i AS INTEGER NO-UNDO.
    i = 2.

    CASE i:
        WHEN 1
        THEN DO:
            MESSAGE "Case 1".
        END.
        OTHERWISE
        MESSAGE "No match found".
    END CASE.
END PROCEDURE.

The block
DO:
    MESSAGE "Case 1".
END.

is additionally parsed as a body:

oops


Control max bins in histogram

Probably easiest with a drop down and just three values, default and one over and under. They could be different layers.

I think this is not needed now that the bins are fixed to include the entire positive grade range 50-100 by default and expand to smaller as needed.