🚀 Feature: Scaffold action for Azure to create a pull request on an existing repository

🔖 Feature description
There is a lot of support for GitHub actions with the scaffolder. In the scaffold template object, you can create steps. I noticed one of these actions in the steps is the publish:github:pull-request that will make a pull request to an existing repository. I am wondering if we can develop an action to create a pull request with an ado repository.
🎤 Context
In my case, I am writing a template to create a new repository. I want to create the new repository and at the same time make a pull request to different repository in my organization in the same template creation. This would allow me to create a new repository of an application and make a pull request to a deployment repository that will create infrastructure for my software. The pull request will prevent infrastructure sprawl and make this process streamlined. Is this possible?
✌ Possible Implementation
This is what I envision the steps in the template spec would look like:
steps:
    - id: fetch
      name: Template Repo
      action: fetch:template
      input:
        url: ./skeleton
        values:
          name: ${{ parameters.name }}
          description: ${{ parameters.description }}
          owner: ${{ parameters.user }}
          destination: ${{ parameters.repoUrl | parseRepoUrl }}

    - id: publish
      name: Publish
      action: publish:azure
      input:
        allowedHosts: ['azure.com']
        description: This is ${{ parameters.name }}
        repoUrl: ${{ parameters.repoUrl }}

# New Functionality
    - id: pull-request
      name: Pull Request
      action: pull-request:azure
      input:
        repoUrl: ${{ parameters.adminRepo }}
        branchName: ${{ parameters.user }}-infra
        title: ${{ parameters.name }}
        description: ${{ parameters.description }}

    - id: register
      name: Register
      action: catalog:register
      input:
        repoContentsUrl: ${{ steps.publish.output.repoContentsUrl }}
        catalogInfoPath: '/catalog-info.yaml'

I am looking to this piece of documentation to write a custom action https://backstage.io/docs/features/software-templates/writing-custom-actions. Wanting to post this here if someone with better typescript skills or if this feature already exists.
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Hi @fosterm-mw, I know that this is for sure something that others would like. It seems this would get you half way there as it would do the code push: https://github.com/Parfuemerie-Douglas/scaffolder-backend-module-azure-repositories but it's missing creating the actual pull request. You'll need to work with the Azure DevOps REST API to accomplish that. You can probably use this to help make that a bit easier: https://github.com/microsoft/azure-devops-node-api. The Azure DevOps backend plugin uses it so you can look at that to see how it works a bit: https://github.com/backstage/backstage/tree/master/plugins/azure-devops-backend
We are moving away from Azure DevOps so that's why I'm not offering to run with this myself but I can help out here and there with feedback or code reviews.

So interestingly we've spoken about simplifying the pull-request actions in general because of performance reasons with the github one already. I wonder if it would be possible to create two actions here if it's needed, git:push to a target branch, and then that would simplify the call to Azure to be able to create a pull request from that branch. If we can get this working I'm feeling that we could also simplify the github:pull-request:create action over time to accept a target branch that has already been pushed.

Thank you @awanlin, looks like the azure-repositories plugin is a great place to start and would appreciate the help along the way. @benjdlambert My plan is to have an action of ado:repo:clone with a new branch then create a ado:repo:push (with a branch input to create a new branch) followed by an ado:repo:pull-request. This way it is decoupled. In this specific use case the main branch will be protected; therefor, a pull-request is required. Does this seem similar to what you are suggesting?

Hello @fosterm-mw , can you share your implementation? this is something I really need and it would be great if I dont need to implement by myself hahaha. Thank you !

Sure! I haven't made the PR to the original repository yet because I have modified the code so that you cannot checkout the main branch to make a PR from. Here's the current package: https://www.npmjs.com/package/@fostemi/scaffolder-backend-module-azure-repositories

Once this PR is merged we can close this issue: https://github.com/Parfuemerie-Douglas/scaffolder-backend-module-azure-repositories/pull/6

@fosterm-mw question about this feature, Is the cloning step nessesary?

@fosterm-mw question about this feature, Is the cloning step necessary, if so why? Can you just push it to the repo??

@dejanbelusic The cloning step is to make changes to fetch the repository that needs changing. I don't want to just push to the repo. If I were to push to main, I'm allowing backstage template to modify a remote repo with no oversight. If the repo I want to push to has the main branch protected proposes a problem as well. I want a PR step to protect a main branch of the repository and have an admin approve the pull request of the changes backstage has made.

In my forked version of the repo, I have a step that will prevent any pushes to main and return an error in creating the push back to the main repository.
There is no naming convention that has to be followed as that should be up to the individual organization that is implementing the action. I do have a default value of creating the branch as scaffolder to be verbose if the value is not passed.

@fosterm-mw Thanks for the info, looking forward to seeing your pr merged, until then I will use your package.

This has been merged and can now use this package: https://github.com/Parfuemerie-Douglas/scaffolder-backend-module-azure-repositories

@fosterm-mw , I am new to backstage and did try to implement the package. I am trying to clone, push and create a PR. I have given input variables to the template and implemented actions. I see the template ran successfully but dont see the branch in GIT repo where its supposed to be cloned. Upon checking logs, its happening within backstage workspace, where it's creating a tmp folder and executing the actions. I am not able to view the target folder once template is run. Not sure why the branch is not visible in the git repo as well.
Template: apiVersion: scaffolder.backstage.io/v1beta3
kind: Template
metadata:
name: azure-repo-clone-push-pr
title: Clone, Push, and Create PR in Azure Repo
description: Clones an Azure Repo, pushes changes to a new branch, and creates a pull request to merge the branch into the main branch.
spec:
owner: backstage
type: service
parameters:
- title: Repository Information
required:
- repoUrl
properties:
repoUrl:
title: Azure Repo URL
type: string
description: The URL of the Azure repository
ui:field: RepoUrlPicker
ui:options:
requestUserCredentials:
secretsKey: USER_OAUTH_TOKEN
allowedHosts:
- dev.xyz.com
allowedOrganizations:
- abc
- xyz
server:
title: Azure DevOps Server
type: string
description: The URL of the Azure DevOps server
ui:field: EntityNamePicker
ui:autofocus: true
ui:options:
rows: 5
token:
title: Personal Access Token
type: string
description: Personal access token for Azure DevOps
ui:autofocus: true
ui:options:
rows: 5
sourceProjectName:
title: Source Project Name
type: string
description: The name of the project that contains the source repository to clone from
ui:autofocus: true
ui:options:
rows: 5
sourceRepoName:
title: Source Repository Name
type: string
description: The name of the source repository to clone from
ui:autofocus: true
ui:options:
rows: 5
targetProjectName:
title: Target Project Name
type: string
description: The name of the project that contains the target repository to push to
ui:autofocus: true
ui:options:
rows: 5
targetRepoName:
title: Target Repository Name
type: string
description: The name of the target repository to push to
ui:autofocus: true
ui:options:
rows: 5
inputbranchName:
title: Current Branch Name
type: string
description: The name of the current branch to clone
ui:autofocus: true
ui:options:
rows: 5
branchName:
title: New Branch Name
type: string
description: The name of the new branch to create
ui:autofocus: true
ui:options:
rows: 5
prTitle:
title: Pull Request Title
type: string
description: The title of the pull request
ui:autofocus: true
ui:options:
rows: 5
prBody:
title: Pull Request Body
type: string
description: The body content of the pull request
ui:autofocus: true
ui:options:
rows: 5
supportsIterations:
title: Supports Iterations
type: boolean
description: Whether the pull request supports iterations
default: true
ui:widget: CheckboxWidget
steps:
- id: debug-info
name: Print Debug Information
action: debug:log
input:
message: |
server: ${{ parameters.server }}
sourceProjectName: ${{ parameters.sourceProjectName }}
sourceRepoName: ${{ parameters.sourceRepoName }}
inputbranchName: ${{ parameters.inputbranchName }}
- id: clone-repo
  name: Clone Azure Repo
  action: azure:repo:clone
  input:
    server: ${{ parameters.server }}
    token: ${{ secrets.USER_OAUTH_TOKEN }}
    remoteUrl: https://dev.azure.com/xyz/${{ parameters.sourceProjectName }}/_git/${{ parameters.sourceRepoName }}
    branch: ${{ parameters.inputbranchName }}
    targetPath: ./cloned-repo

- id: push-changes
  name: Push Changes to Azure Repo
  action: azure:repo:push
  input:
    remoteUrl: https://dev.azure.com/xyz/${{ parameters.targetProjectName }}/_git/${{ parameters.targetRepoName }}
    branch: ${{ parameters.branchName }}
    sourcePath: ./cloned-repo
    gitCommitMessage: 'Initial commit for new branch'
    server: ${{ parameters.server }}
    token: ${{ secrets.USER_OAUTH_TOKEN }}

- id: check-repo
  name: Check New Repository Existence
  action: check:azure-repo
  input:
    repoUrl: https://dev.azure.com/xyz/${{ parameters.targetProjectName }}/_git/${{ parameters.targetRepoName }}
    token: ${{ secrets.USER_OAUTH_TOKEN }}

- id: debug-branch
  name: Debug Branch Information
  action: debug:log
  input:
    message: |
      Remote URL: https://dev.azure.com/xyz/${{ parameters.targetProjectName }}/_git/${{ parameters.targetRepoName }}
      Branch Name: ${{ parameters.branchName }}
      Token: ${{ secrets.USER_OAUTH_TOKEN }}

- id: publish
  name: Publish
  if: ${{ steps.check-repo.output.repoExists == false }}
  action: publish:azure
  input:
    allowedHosts:
      - dev.azure.com
    description: This is ${{ parameters.name }}
    repoUrl: ${{ parameters.repoUrl }}
    token: ${{ secrets.USER_OAUTH_TOKEN }}

output:
links:
- title: Repository
url: ${{ steps.publish.output.remoteUrl }}
- title: Open in Catalog
icon: catalog
entityRef: ${{ steps.register.output.entityRef }}
Any help is appreciated. Thank you.

It looks like you are including unnecessary steps. Try following this documentation: https://github.com/Parfuemerie-Douglas/scaffolder-backend-module-azure-repositories/blob/main/README.md
For your goal, I don't know why you are using the publish action or the check action. You are missing a PR action as well.

My requirement for template is to create a catalog-info.yaml file and push it to either an existing or new repo branch and generate a PR so that other teams can directly make use of that PR. Publish action is working fine only for new repos but not existing once.


Fix the bug on the footer

It's my first time to register a pull request on not my own project and I'm not good at English. I hope for your understanding.
When I added your project Jekyll-swiss into my GitHub page(https://nulledge.github.io/), I found that the link and the display of the GitHub repository stargazer did not work.
I guessed that this problems was because of the missing or additional variable notations.
After I forked your project and changed only one line, it works well, I think.

@duttaditya18 Maybe it was just my fault.


Microsoft Dev Home extension

Feature Description
It might be a little niche idea, but I think it would be nice, if one could use Gitea in Microsoft Dev Home, just like Azure or GitHub extensions.
Imo Gitea extension wouldn't have to be much more than GitHub one, some basic info about PR status, Assigned tasks - that would be a good start.
Dev Home is still in preview, but I believe it could be really nice addition for people using it. Maybe the app will gain many useful features and it might come to broader audience, so it might be worth a try.
I didn't find any issue including this idea, I don't expect such feature for myself, just wanted to start the conversation and bring it to Your attention.
Cheers!
Screenshots

The idea sounds good, but Dev Home and the GitHub extension are all developed in C#.
In GitHub extension, it is using Octokit as the API client.
So if we want to implement Gitea extension, we need to maintain a C# SDK and the extension?
Although you can find a .Net SDK from https://gitea.com/gitea/awesome-gitea#sdk, but it is no longer maintained for a long time.
Or we need to do some magic approaches like calling Go functions in C#?
Or simply implementing an Gitea API client inside the extension?
Maybe it is also similar to the VSCode extension, the SDKs for Gitea in the other languages are too weak.
If we already have a strong support for the  SDKs in these languages, I think the development of these extensions should not be very hard.


[Apple Notes] Search doesn't work on macos 12.7

Extension
https://raycast.com/raycast/apple-notes
Raycast Version
1.74.1
macOS Version
12.7.5 (21H1222)
Description
Steps:

Run Notes search command (screenshot 1)

Current Behaviour
Got error (screenshot 2)
Expected Behaviour
Search works
Error:
Error: Error: in prepare, no such table: zicinvitation (1)

    at /Users/mike/.config/raycast/extensions/8c7187e0-f64c-4dba-ba77-b1cb543256d6/index.js:12:24505
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Steps To Reproduce
Listed in description
Current Behaviour
No response
Expected Behaviour
No response

I shipped a fix to hide the error. Could you try again in a few hours and let me know if you still see the error?


[choose-yarn-node] 🙀 Pull node and yarn versions from package.json

Our bash scripts have no testing infrastructure, so I hand-tested this.

Once we like this, we can backport it into https://github.com/SFDO-Tooling/sfdo-template/pull/10


Feature request: Add Option to copy file to clipboard

Not sure if this is possible but I think it would be really useful to have an option to copy and paste/drag the file(just like ctrl+c ctrl+v/drag n drop) from a file explorer

Hi, I'd like to try to implement this feature as this would be helpful for me.
@winiciuscota what exact functionality do you have in mind? I thought about reserving ctrl + Return to copy the path.
@marvinkreis do you have any pointers where you would implement this? I just started digging through the code and my C is a littly rusty ;)

Hi @pianoslum. First of all, thanks for contributing. I appreciate it :)
Since I haven't responded to this issue yet: Unfortunately, drag and drop isn't possible with rofi's custom mode API.
The way to implement this would be to assign one of rofi's available keys to a copy (or paste) action.
From what I've gathered, kb-custom-* and kb-accept-alt are keys that can be used for custom modes.
(Maybe others are available now, I haven't checked this in a while.)
Anyways, the key bindings are defined here: https://github.com/marvinkreis/rofi-file-browser-extended/blob/256487470ef7e5006bacdf29a7b8593e3148e7ff/include/types.h#L83-L102
(rofi -show keys will show your current bindings, which is very helpful for troubleshooting.)
To implement the actual copying part, you'd check for the key press somewhere here:
https://github.com/marvinkreis/rofi-file-browser-extended/blob/256487470ef7e5006bacdf29a7b8593e3148e7ff/src/filebrowser.c#L206-L211
Pretty much just create another else case and check if the configured key is pressed.
Then copy (or paste) the file there.
Finally, to make it configurable, add it as an option here:
https://github.com/marvinkreis/rofi-file-browser-extended/blob/256487470ef7e5006bacdf29a7b8593e3148e7ff/src/options.c#L158-L165
And extend the key binding validation here (shouldn't be much more that adding it to the arrays and changing the 3s to the new number of key bindings, I think):
https://github.com/marvinkreis/rofi-file-browser-extended/blob/256487470ef7e5006bacdf29a7b8593e3148e7ff/src/keys.c#L59-L104

Thanks a lot.
After digging around a bit, I think that integrating copying to clipboard in the C-code is much too cumbersome.
I found a little workaround to achieve the same basic functionality:
Create a small bash script copyFilePath basically consisting of echo "$1" | xclip -r and put it somewhere in the path.
The you can either override the standard command (if you only want to copy) or use this command in the open-custom-list.
A little bit more elegant solution would be to offer a 2nd open-command that can be freely configured like the primary one (and set to aforementioned script for the path-copy-functionality).
I could update the Readme about my workaround and/or provide the patch for a second open-command.
What do you think?

Hmm, yeah. I googled a bit, and clipboard manipulation in C indeed seems very cumbersome.
I like the open-custom workaround though. If you already have an idea about what to write in the README, I'd be happy to use it. Otherwise, I'll just write 1 or 2 sentences about it.
As for the 2nd open-command: I already have plans to change the key bindings to map commands to keys instead of the other way around. This would make it possible, to map different open-commands to keys, e.g.:

kb-custom-1 -> toggle hidden files
kb-accept-entry -> open with xdg-open
kb-accept-alt -> open with copyFilePath

But I don't know when I'll get around to implementing this, so might as well change the README for now.

wow, I forgot I had created this issue. Really sorry about that.
I was able to create exactly the solution I wanted shortly after by integrating rofi-file-browser-extended to Dragon-drag-and-drop
The gist with the scripts created: https://gist.github.com/winiciuscota/5790f7b6134518555d7d6b1426298abe


'Property filterFns is missing' using useReactTable

Describe the bug
This is probably not a bug, but I cannot figure out why my useReactTable call is saying that the filterFns property is required.  This is the code where all the red squigglies are:
const table = useReactTable({
	data: users,
	columns,
	getCoreRowModel: getCoreRowModel()
});

Full error:

And here is my full component:
import React, { useState } from 'react';
import {
	ColumnDef,
	createColumnHelper,
	flexRender,
	getCoreRowModel,
	useReactTable
} from '@tanstack/react-table';
import { Scrollbars } from 'rc-scrollbars';

type User = {
	name: string;
	email: string;
	role: string;
};

const columnHelper = createColumnHelper<User>();

const columns: ColumnDef<User, string>[] = [
	columnHelper.accessor((row) => row.name, {
		id: 'name',
		cell: (info) => {info.getValue()},
		header: () => Name
	}),
	columnHelper.accessor((row) => row.email, {
		id: 'email',
		cell: (info) => {info.getValue()},
		header: () => Email
	}),
	columnHelper.accessor((row) => row.role, {
		id: 'role',
		cell: (info) => {info.getValue()},
		header: () => Role
	})
];

type UserTableProps = {
	users: Array<User>;
	selectedUser: User;
	showUserManagement: Function;
};

const UsersTable = (props: UserTableProps) => {
	const { users, selectedUser, showUserManagement } = props;

	console.log({ users });

	const table = useReactTable({
		data: users,
		columns,
		getCoreRowModel: getCoreRowModel()
	});

	const [showUserCheckID, setShowUserCheckID] = useState(-1);

	const setTheSelectedUser = (
		e: React.MouseEvent<HTMLTableRowElement>,
		email: string
	) => {
		e.preventDefault();
		console.log({ email });
		const selectedUser = users.find((u) => u.email === email);
		showUserManagement(selectedUser);
	};

	// const thumbVertical = ({ style, ...props }) => {
	// 	console.log(typeof style);
	// 	const finalStyle = {
	// 		...style,
	// 		visibility: 'hidden'
	// 	};
	//
	// 	return
;
	// };

	return (

			<Scrollbars
				autoHeight
				autoHeightMin={0}
				autoHeightMax={'calc(100vh - 40px)'}
				// renderThumbVertical={thumbVertical}
			>

						{table.getHeaderGroups().map((headerGroup) => (

								{headerGroup.headers.map((header) => (

										{header.isPlaceholder
											? null
											: flexRender(
													header.column.columnDef.header,
													header.getContext()
											  )}

								))}

						))}

						{table.getRowModel().rows.map((row) => (

									setTheSelectedUser(e, row.getValue('email'))
								}
							>
								{row.getVisibleCells().map((cell) => (

										{flexRender(
											cell.column.columnDef.cell,
											cell.getContext()
										)}

								))}

						))}

			</Scrollbars>

	);
};

export default UsersTable;

Your minimal, reproducible example
https://codesandbox.io/s/keen-aj-lxqrw8?file=/src/UsersTable.tsx
Steps to reproduce
Create the table with the following code:
const table = useReactTable({
	data: users,
	columns,
	getCoreRowModel: getCoreRowModel()
});

Expected behavior
It should create the table and not throw any typescript errors about requiring 'filterFns'.
How often does this bug happen?
Every time
Screenshots or Videos

Platform
OS: Windows 11 Pro
Browser: Firefox 115.0.3 64 bit
react-table version
8.9.3
TypeScript version
5.1.6
Additional context
I noticed in my sandbox example, there are no Typescript errors.  So I'm not sure if it is something related to my IDE?  I am using Webstorm 2023.2.
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Facing the same issue here. I'm using Next.js with pnpm. If that has something to do with this issue. 🤔

Had the same problem. I looked in the code and found this in Filters.ts:
type ResolvedFilterFns = keyof FilterFns extends never
  ? {
      filterFns?: Record<string, FilterFn<any>>
    }
  : {
      filterFns: Record<keyof FilterFns, FilterFn<any>>
    }

So I've checked if somewhere exists FilterFns implementations in the code, cleaned them out - and these exceptions disappeared.

Not sure if this helps, but we had the same error appear when we merged two branches, where each had a different table. One without filterFns defined worked fine before merge. After merge, it started complaining.
Turned out one of our devs added this piece of code to make the table filterable:
declare module '@tanstack/table-core' {
  interface FilterFns { fuzzy: FilterFn<unknown> }
  interface FilterMeta { itemRank: RankingInfo }
}

Not sure why, probably it was copied from some docs, although I cannot find it. When i figure this out, I'll comment / edit this post.

@kubacichorski I must say that I think that you are incorrect and it is required, because I have this declaration in my code too and without it where you configure your columns and relate to a custom filter that you define, it shows a typescript error: Type '"fuzzy"' is not assignable to type FilterFnOptions<RowType>
Yes it might not be required for the tables filters to work but it does required by TS for dealing with these errors.
@Relaximus  didn't you break any existing logic that was originally implemented by deleting these implementations for filterFns?
Related to this thread, I noticed this error shows to me when I tried to create a second table that shouldn't have custom filterFn, does anyone here know if it's possible to override a declared module?

I had the same issue, even when putting the declare in the file with the table I wanted to filter on (not in any shared code), which I guess makes sense. Defining the filters inline works, you just don't get the brevity of a named filter.

@AdirTrichter i have the same issue when deifing a custom filter how do i solve it i'm getting this error
Type '"myCustomFilterFn"' is not assignable to type 'FilterFnOption | undefined'.ts

I am facing the same problem.

@djshubs i ended up writing the function on all columns that i need it until i find out how to solve it

Have you tried this? Makes sure filterFns stays optional.
declare module "@tanstack/table-core" {
  interface TableOptions<TData extends RowData>
    extends PartialKeys<TableOptionsResolved<TData>, "state" | "onStateChange" | "renderFallbackValue"> {
    filterFns?: FilterFns;
  }

  interface FilterFns {
    "=": FilterFn<unknown>;
    contains: FilterFn<unknown>;
    yourCustomFunction: FilterFn<unknown>
  }
}

@djshubs i ended up writing the function on all columns that i need it until i find out how to solve it

Have you tried this? Makes sure filterFns stays optional.
declare module "@tanstack/table-core" {
  interface TableOptions<TData extends RowData>
    extends PartialKeys<TableOptionsResolved<TData>, "state" | "onStateChange" | "renderFallbackValue"> {
    filterFns?: FilterFns;
  }

  interface FilterFns {
    "=": FilterFn<unknown>;
    contains: FilterFn<unknown>;
    yourCustomFunction: FilterFn<unknown>
  }
}

Can confirm this resolves the issue.

Should the resolution be changing/getting rid of ResolvedFilterFns so it doesn't force you to add filterFns to every table in your whole app?
You should be able to extend the FilterFns interface without it making it required across all of your tables in your project right?

Search if any of your files have this code :
This error occurs if you have used fuzzyFilter in any other modules in your project.

declare module "@tanstack/table-core" {
  interface FilterFns {
    fuzzy: FilterFn<unknown>;
  }
}

Had the same issue, solved after removing this type declaration  🚀


Feature request: correlation ID's propagation

Description of the feature request
Problem statement
The use of correlation ID's can be extremely helpful for debugging purposes and help developers understanding the lifecycle of user transactions as they are being handled by different microservices within a platform.
It would be good to help developers understand how they can use correlation ID's effectively and following the best practices, potentially allowing them to bring their own custom correlation ID's, and most importantly propagate correlation ID's through the different utilities to external dependencies of a service. This can be achieved through the implementation of a new dedicated utilities, new features within all utilities, adding examples and/or documentation.
For the scope of this Issue, we can identify 2 types of correlation ID's:

Unique transaction ID that are set by AWS (for example X-Ray Trace Id, AWS Request Id)
User-defined correlation ID's that can be stored and passed along between microservices:

SNS - Message attributes https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/tests/resources/events/aws/sns-notification.json#L18
CloudFront - Request headers https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/tests/resources/events/aws/cloudfront-modify-querystring.json#L13
API Gateway - Headers https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/tests/resources/events/aws/apigateway-aws-proxy.json#L21
Others...

Summary of the feature
All utilities would be able to fetch out of the box correlation ID's coming from each different AWS service (Lambda Trigger), and propagate them to logs, metrics, traces, ....
Note that this feature and functionality should not necessarily be enabled by default, but it should be possible to enable it and turn it on if developers need it.
It should be also possible to define your own custom correlation ID's and be able to propagate them and use them in different utilities accordingly.

Implement this logic in all utilities. Research is needed to understand the best implementation strategy, how to not do code repetition.
Code examples

TBC. Happy to receive suggestions on this one.
Benefits for you and the wider AWS community
As discussed in a past meeting with @gsingh1 @loujaybee and @simontabor, the functionality of fetching and propagating correlation ID's, including custom user-defined ones, can be useful and especially relevant for developers who operate at scale and within big organisations, where you have a high number of teams responsible for microservices communicating to each other.
Describe alternatives you've considered

None that comes into mind apart from writing the code by yourself.
Additional context
See here a brief definition of a correlation ID.
Related issues, RFCs
Not at the moment.

@saragerion can we implement something like this for typescript too? This is similar to how python allows for logging the event with the correlationId based a json path
import { Logger, CorrelationPaths } from "@aws-lambda-powertools/logger";
import { LambdaInterface } from '@aws-lambda-powertools/commons';

const logger = new Logger();

class Lambda implements LambdaInterface {
    @logger.injectLambdaContext(correlationIdPath=CorrelationPaths.API_GATEWAY_REST, logEvent=true)
    public async handler(_event: any, _context: any): Promise<void> {
        logger.info("This is an INFO log with some context");
    }
}

export const func = new Lambda();
export const handler = func.handler;

Hi everyone, if you arrive on this issue because you are interested in this feature or because you are looking to migrate from dazn-lambda-powertools we would like to hear from you!
We are still considering this feature but we need more examples and to gather requirements to build a RFC.
If you are interested, please leave a comment describing briefly your use case and how the correlation ID feature would work in terms of experience. It's fine also to point towards existing resources.
If uncomfortable with sharing your use case publicly, you can also reach out to us privately at<EMAIL_ADDRESS>

@dreamorosi my use case is function are that work under AWS EventBridge scheduler would be great if I can set custom or user define in correlation id and pass by dynamodb.
However, If you have any idea to tracking transaction across functions that were trigger by EventBridge I welcome.  thanks  :)

Have you considered using the Baggage standard (or something close to it) for this implementation? https://www.w3.org/TR/baggage/

Just wanted to give an update on this.
This issue is currently our oldest issue that is still have open.
While we acknowledge that over time it has garnered some demand, because of its scope being fairly broad it's a bit challenging for us to get a sense of which features within the many proposed above we should focus on.
While this is not an area that we are actively prioritizing for the remainder of this year, we would like to better understand which parts of the correlation ID piece from DAZN people are particularly missing in Powertools for AWS. This will help us to create our backlog for next year.
In the meantime, one feature that we can consider already today is allowing customers to set correlation IDs in Logger. This is a feature that Powertools for AWS Lambda (Python) already supports, so from a feature parity standpoint it still makes sense for us to add it sooner rather than later - you can track the progress around that effort in #2863.
I'll revisit this in a few months and see if anything has changed in terms of engagement with the issue.


docs: clean up some spacing issues in website

/azp run

Codecov Report

Merging #1256 (eec5e99) into master (b2751eb) will decrease coverage by 81.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #1256       +/-   ##
==========================================
- Coverage   83.12%   1.61%   -81.51%
==========================================
  Files         300     248       -52
  Lines       13699   11984     -1715
  Branches      660     660
==========================================
- Hits        11387     194    -11193
- Misses       2312   11790     +9478

Impacted Files
Coverage Δ

...m/src/main/scala/com/microsoft/lightgbm/SWIG.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ain/scala/org/apache/spark/ml/param/MapParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/scala/org/apache/spark/ml/param/UDPyFParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...cala/org/apache/spark/ml/NamespaceInjections.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...cala/org/apache/spark/ml/param/DataTypeParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ala/org/apache/spark/ml/param/ByteArrayParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ala/org/apache/spark/ml/param/EvaluatorParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...la/org/apache/spark/ml/param/ParamSpaceParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...la/org/apache/spark/ml/param/TypedArrayParam.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/com/microsoft/azure/synapse/ml/stages/udfs.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 283 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2751eb...eec5e99. Read the comment docs.


OSPP: Cloud-edge collaborative inference for LLM based on KubeEdge-Ianvs

What type of PR is this?
/kind feature

What this PR does / why we need it:
Cloud-edge collaborative inference for LLM based on KubeEdge-Ianvs
Which issue(s) this PR fixes:

Fixes #96

Detailed introduction information is coming soon (will be be added here).

Reminder: there are CI issues that remain to be resolved, see https://github.com/kubeedge/ianvs/actions/runs/11201880744?pr=149

As discussed in #152 , this has been temporarily fixed by introducing sedna-<IP_ADDRESS>-py3-none-any.whl. This package is constructed from my sedna fork FuryMartin/sedna.

The sedna installation originally used by the community should have a backup in third_party-bk.

I have move the sedna-0.4.1-py3-none-any.whl to third_party-bk
I have completed all the comment completion and document organization work.
Please review the code. @hsj576 @MooreZheng

/lgtm

This branch has conflicts that must be resolved. Use the web editor or the to resolve conflicts.

squash the commits into one using rebase techniques.

Thanks for the review. I'll fix them tomorrow.

Current conflicts:
This branch has conflicts that must be resolved Use the web editor or the to resolve conflicts. Conflicting files core/common/constant.py core/storymanager/rank/rank.py core/testcasecontroller/algorithm/algorithm.py core/testcasecontroller/algorithm/module/module.py core/testcasecontroller/algorithm/paradigm/init.py core/testcasecontroller/algorithm/paradigm/base.py core/testcasecontroller/metrics/metrics.py core/testenvmanager/dataset/dataset.py

Thanks for the review.
These conflicts are caused by the revert #160.
I believe they will be fixed automatically by merging #161 at first.

Thanks for the review. These conflicts are caused by the revert #160.I believe they will be fixed automatically by merging #161 at first.
Update at 2024-10-30 21:18
#161 has been closed. @Yoda-wu is trying to create a new PR #162 contains the commits of #143 and #161.
I advise @MooreZheng to first merge #162 , and then proceed with merging #144 . (Because I might have some conflicts with #144 as well)
I will be on call any time tomorrow.
Thanks!

Sure. Will try following that path.

/lgtm

After merging PR 162 and PR 144, the following new conflicts do come to fix

Fixed.

Hi @MooreZheng , if possible, please merge #159 first, too.

Hi @MooreZheng , if possible, please merge #159 first, too.

FYI I will on my flight tomorrow morning... Have talked to the #159 owner @safe-b on WeChat and left comments on his PR.  @FuryMartin might want to lend him a hand to speed up the overall process.

Other OSPP projects have been merged, so this shall be the last conflict

Solved.

/lgtm

/approve


Multisig proposals should not be limited to 12 chars

ERROR: invalid name format for "proposal name": "updateparams2" too long, 12 characters allowed maximum

Fixed in 17ab1ab .. release pending.


Media with

Hello dear brother
Thank you for your great job.
In the OnlyM the playback of the media file is bumpy. Can you fix it?
Best regards.

Please see #30

Please see #3


[FLINK-3928] [gelly] Potential overflow due to 32-bit int arithmetic

+1, good catch!

Merging ...


AC Powered CC2530  + CC2591 router

hi Guys,
Just built my how AC Powered CC2530  + CC2591 following the tutorial below:
https://www.zigbee2mqtt.io/how_tos/how_to_create_a_cc2530_router.html
But when is very quiet i can hear a very light buzz coming from the box. Is this normal?
To be honest I'm not very confident connecting the HLK-PM03 to main power socket? is that safe? what can go wrong like catch fire or short circuit?
I've seen some guys building a breakout board around it with fuses and so, would this not be a more reliable/safe solution?
Thanks in advance!
Leandro

I'm definitely no electrician, but I consider the HLK-PM03 to be safe, already running my CC2530 router 1.5 years with this.

okay, good to know because in fact the reliability so far is much better


LDIndex step fails silently

Describe the bug
The job that generates a LDIndex fails due to the executors silently dying.
A list of the failing jobs (marked as cancelled) and their logs is available here.
The code for:

The step of the ETL
The main method that generates the LDIndex object

Observed behaviour
In all my runs, my experience was that the job was not completing because the executors at some point were dead, so the process would go on idle showing a log similar to this:
[Stage 4:>                                                       (0 + 88) / 200]
[Stage 4:>                                                       (0 + 88) / 200]

I've seen 2 types of errors when accessing the executor logs:
1. Executor disk usage
1/1 local-dirs usable space is below configured utilization percentage/no more usable space [ /mnt/1/hadoop/yarn/nm-local-dir : used space above threshold of 90.0% ] ;
My understanding is that this is basically telling that the disk used to store intermediate files has been filled. I think I've fixed this (more below).
2. Another one - I actually don't know what is going on now
Some screenshots of the nodes health status while the cluster was alive:

And the latest logging error on the executor:

What my script is intended to do

The pipeline involves processing and aggregating a large dataset with around 30 billion rows. There are 2 primary tasks:

Convert the raw inputs into our desired shape and combine them into a single dataframe, which represents a set of genetic variants correlated by Linkage Disequilibrium across populations. The DataFrame schema contains columns: r, variantId, chromosome, tagVariantId, and population.
Aggregate this huge dataframe to produce a nested structure (more here). This nested structure aggregates r values for each tagVariantId and population under each variantId

One thing that is important to note is that this step is supposed to be run just once per release of data (every few years). We want to have something that runs in a considerate amount of time, but I am not aiming for the most optimal approach.

What I've done so far

The whole step used to take ~8 hours. To make the process of debugging faster, I split the script in 2 steps based on the tasks described above:

Part that processes the inputs and write the unaggregated dataframe. This took ~4h. I was worried about the piece of logic that unioned all the dataframes together, but after optimising the logic, this was not the bottleneck (job).
From them on, I've only tried to run the logic that aggregates the data, and this is where I saw the nodes failing.

I set 2 important parameters following Hail's documentation recommendations. This showed an improved performance (https://github.com/opentargets/genetics_etl_python/pull/110/commits/cf22242759fdff7bbdda24141d15a104b0bce15d)

openCostInBytes (warns the optimiser that the cost of opening a file is high) and maxPartitionBytes (defines the maximum size of a partition when reading data) set to 50gb.

Given the large size of the data, attempted to repartition the data before aggregation to optimise performance. I partitioned by variantId, tagVariantId, and chromosome. I am pretty sure the executors are failing in this stage. When I set to redistribute the data in ~4000 partitions, the log said something like [Stage 136:>                                                       (0 + 88) / 4000]. My latest test repartitions the data based on those columns to a number of 10_000 partitions.

When I was seeing errors in the disk usage of the node I tried optimising the cluster and the Spark session based on my needs:

To account for the local-dirs usable space error, I've changed this memory threshold to 98%. The script was going further but still failing. (https://github.com/opentargets/genetics_etl_python/pull/110/commits/34694342dd40630a589620b8bea84fbc968e22ac)
To account for the disk space, I assigned a boot disk of 1TB (https://github.com/opentargets/genetics_etl_python/pull/110/commits/0eb317f7f92c133b9644f024667119b934786f95)
I increased driver and executor memory, not to use the default parameters and allocate them based on the resources of the machine (9c8bc12)
Even though there was a local SSD assigned, I saw that the disk type was still pd-standard. I explicitly told the cluster to use the SSD. (https://github.com/opentargets/genetics_etl_python/pull/110/commits/df70a0d295846b6da3158d3cb70e4ed19b81d050)
The machine looked healthier. Same problems but setting non default parameters seemed to be doing something. I saw that the CPU usage was 30%. YARN assigns 2 executors per node by default. This seemed like a waste of resources, so I set parameters to assign a dynamic number of executors based on the available resources. I went from 2 to 11 executors + driver. The script was much much quicker, but executors kept dying at some point. (https://github.com/opentargets/genetics_etl_python/pull/110/commits/7c21ee530bfe715290e5fe816d378c89c170e30f)

This is a summary of the things I've tried and saw a benefit, despite not working.
I would highly appreciate:

Optimisations in the business logic of the script. Should I partition the data in a specific way? Can I aggregate differently? Should I write intermediary files in a specific format to optimise the aggregation?
Feedback about my changes in how I've allocated resources. I know that fine tuning the best parameters is tricky, but I want to make sure things make more or less sense.
Should I use a bigger cluster?. The operation is intrinsically demanding. Would I benefit from having a cluster with multiple nodes? A cluster with more memory? With more disk?

The latest change I've done, and what I am testing at the moment is to repartition the data in 10,000 parts and persist the dataframe between the 2 groupings.
This time I've sent the whole script, to make sure that the suboptimal way that I've written the unaggregated dataset is not interfering with latest improvements.
After 4 hours, logs show that it has recently died (job). I'll leave the cluster on for 30' in case you want to look at it @mbdebian
[Stage 48:=====================================>             (2337 + 88) / 3200]

[Stage 48:=====================================>              (2337 + 0) / 3200]

[Stage 48:=====================================>              (2337 + 0) / 3200]

Success!! @d0choa suggested to throw more disk to the job and it ran in 5h (job) with a 5TB hard drive.
@mbdebian Could you still have a look at the changes I've made to make sure nothing is blatantly stinky? Changes are summarised in the PR and in the comment above.


Build issue - Eigenpy

On pal development computer, to use the library pinocchio, a second eigenpy librairy has been installed:
//the base eigenpy to work with pal's robot environment, cannot remove
ros-melodic-eigenpy/bionic,now 2.5.0-1bionic.20200827.013457 amd64 [installed]

//the eigenpy wanted by pinocchio
robotpkg-py27-eigenpy/bionic,now 2.7.6 amd64 [installed]

When trying to build the package that uses pinocchio, it returns an error relating to the version of eigenpy as it tries to use the wrong eigenpy:
CMake Error at /usr/share/cmake-3.19/Modules/CMakeFindDependencyMacro.cmake:47 (find_package):
  Could not find a configuration file for package "eigenpy" that is
  compatible with requested version "2.6.2".

  The following configuration files were considered but not accepted:

    /opt/ros/melodic/share/eigenpy/cmake/eigenpyConfig.cmake, version: 2.5.0

Call Stack (most recent call first):
  /opt/ros/melodic/share/cmake/pinocchio/pinocchioConfig.cmake:155 (find_dependency)
  CMakeLists.txt:19 (find_package)

In the CMakeLists, the directory of the good eigenpy has already been included.

Add these lines at the end of the $HOME/.bashrc:
export PATH=/opt/openrobots/bin:$PATH
export PKG_CONFIG_PATH=/opt/openrobots/lib/pkgconfig:$PKG_CONFIG_PATH
export LD_LIBRARY_PATH=/opt/openrobots/lib:$LD_LIBRARY_PATH


Update index.md

Added password spraying from Skoudis / Strand webcast

A number of spelling issues need to be fixed before this can be merged. Specifically:
On line 32, "Pilliage the villlage" you should capitalize the "v" in village as this is the way it has been presented in advertisements and on the website. Furthermore, there is an extra "l" in village that should be removed. Lastly, "Pillage" not "Pilliage": you have an extra "i" there.
Rest of the file looks good. Still need someone to test it out but it looks like it should work fine.

Fixed the spelling issues on line 32, apparently my brain was on vacation this mornint--good catch @tekwizz123

Great, thanks for updating that :) WIll merge this pull request so long.


diesel_cli does nothing when run windows 10

Setup
Versions

Rust: 1.33.0
Diesel: 1.4.0
Database: PostgreSQL 11
Operating System: Windows 10 Build 1809

Feature Flags

diesel:

Problem Description
Whenever I try to run diesel.exe with any subcommand or flag, it returns with no output.
PS C:\Users\alex> diesel.exe
PS C:\Users\alex>

I have already looked at #487 and #843, but to no avail.
What are you trying to accomplish?
I am trying to get the diesel cli installed and running for a project.
What is the expected output?
I expect there to be any output at all.
What is the actual output?
Nothing
PS C:\Users\alex> diesel.exe
PS C:\Users\alex>

Are you seeing any additional errors?
No
Steps to reproduce

$env:PQ_LIB_DIR = "C:\Program Files\PostgreSQL\11\lib"
$env:SQLITE3_LIB_DIR = "C:\Program Files\SQLite3"
Add C:\Program Files\PostgreSQL\11\lib and C:\Program Files\SQLite3 to PATH
cargo install diesel_cli --no-default-features --features postgres,sqlite
diesel.exe --help

Checklist

[x] I have already looked over the issue tracker for similar issues.
[x] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)

What's the exit code you're getting?

I'm not sure, how do I check?

That would depend on what shell you're using. Google "{your shell} get exit code"

I got -107374151. It doesn't seem right, but it stayed consistent through multiple runs from echo $LASTEXITCODE

That is 0xC0000135 in hex, which is a missing DLL. You should have received a popup window telling you what's missing.

I didn't get it from PowerShell, but when I ran it in command prompt, I got the error message:

The code execution cannot proceed because SSLEAY32.dll was not found. Reinstalling the program may fix this problem.

Fixed it. I found that SSLEAY32.dll is from OpenSSL and did not have it installed. For those looking, you can down load the dlls from https://indy.fulgan.com/SSL/

Fixed it. I found that SSLEAY32.dll is from OpenSSL and did not have it installed. For those looking, you can down load the dlls from https://indy.fulgan.com/SSL/

unluckily the Diesel setup has the same issue and it do not run anymore. I tried to use cmd and that is so bad.

That is 0xC0000135 in hex, which is a missing DLL. You should have received a popup window telling you what's missing.

How did you know this code means a missing DLL? Is there a reference for these codes?

@fclinux @rikkigouda The reason you got here, might be because of the crappy Windows Terminal, which loses the executable loader error. I used the Git Bash (comes with git, I think) to see the DLL missing errors.


Kubernetes Policy-Based Governance, Risk, and Compliance paper

The Policy WG has drafted a paper on Kubernetes GRC:
https://docs.google.com/document/d/1pWFBfMloSgupjJBcyq45qg9UHkaPjfAyUQHgmBdTqgQ/edit
This issues is to track the migration to markdown. This is WIP at:
https://github.com/JimBugwadia/sig-security/blob/policy_grc_paper/sig-security-docs/papers/policy_grc/kubernetes-grc.md
Pending Tasks:

[ ] add links
[ ] add diagrams
[ ] add reviewer affiliations

is there a format for diagrams we need to use? (or prefer to use)

is there a format for diagrams we need to use? (or prefer to use)

Typically PNG.


close producer

@h1alexbel take a look, please
found some bug

@l3r8yJ By the way we need remove this disabled test

Codecov Report
Patch and project coverage have no change.

Comparison is base (b88ff2d) 63.79% compared to head (acd2140) 63.79%.

:exclamation: Current head acd2140 differs from pull request most recent head 77b17c9. Consider uploading reports for the commit 77b17c9 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #110   +/-   ##
=========================================
  Coverage     63.79%   63.79%
  Complexity       16       16
=========================================
  Files             9        9
  Lines            58       58
=========================================
  Hits             37       37
  Misses           21       21

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@h1alexbel take a look, please

@l3r8yJ can you please create todo for pdd on ITCase for Producer <-> Consumer communication?

@h1alexbel check the puzzle, please

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 1min)

@l3r8yJ thanks


vimPluginsUpdater: allow development with nix develop

Description of changes
nix develop .#vimPluginsUpdater now lets you enter a shell where you can run pkgs/applications/editors/vim/plugins/update.py and iteratively develop !

removed warn warning from python by using warning instead
plugin2nix was calling the same bit of code over and over thus slowing down the generator by a lot. I now run only it once so the initial part takes 60sec (from I dunno but seemed like it was 200s before)

I noticed that the slow part now is the "redirect" thing because it's not parallelized, in case you wanna have a look @GaetanLepage

Things done
When trying to run this, I got the seemingly unrelated:
pkgs/applications/editors/vim/plugins/generated.nix
committing to nixpkgs "vimPlugins: update on 2024-07-14"
path is '/nix/store/x0z1frzrzm44zly6b3dzw7mpckbgzsd6-d36f722f114dfdafc8098496e9b5dcbd9f8fc3e8.tar.gz'
1464 plugins were checked
updated pkgs/applications/editors/vim/plugins/generated.nix
committing to nixpkgs "vimPlugins: resolve github repository redirects"
updating nvim-treesitter grammars
note: keeping build directory '/tmp/nix-build-source.drv-0/build'
error: hash mismatch in fixed-output derivation '/nix/store/wz4h3p9wwvirm3i2rf2dq5kbh025qba5-source.drv':
         specified: sha256-m7iG9evG/zYeqv9pKEMCBLBSWGCP4FGAHudGXIiu594=
            got:    sha256-l2niYYNNlGoqHioXOQd0vPmGWDSRHwFckSeAJZjOxS0=

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I am still annoyed that the updater works directly on the repo files instead of a temporary copy like for the luarocks updater. This means that when I interrupt the updater, I end up with a changed generated.nix :(


instead of including flag icons, add flags gem dependency

Hey, @mrbrdo I was testing this PR and unforutnately when I configure spree to allow selection of store (where the flags are used), those chagnes seem to break something and dropdown menu looks like normal:

while it should be displaying available stores like this:

Have you tested those changes or maybe also changed something that is not commited here?

@wjwitek hm I don't remember it showing like that in the dropdown, was it always like that since 4.3 (it's when I started using Spree)?
My dropdown indeed looks like your first screenshot, but I think it had always looked like that. I have the current flag displayed as the icon instead of the globe (next to cart icon), which I probably changed myself, and the flag works there.

I tried reverting my commit and even using the spree main branch of the frontend, but I still do not see the icons as in your second screenshot. I don't remember it ever showing up like that for me. Perhaps that functionality is broken in different ways as well?

@wjwitek so just to be sure I cloned the latest spree_starter, added spree_frontend (4.5), and still, I do not see the icons in the globe dropdown. I just went into admin and added a few languages to the default store. But I am not sure if you are talking about a multi-store configuration or something like that?

@mrbrdo Yes, I'm talking about multi-store configuration, becouse that was the only place that I found to use flags. It's possible that to make flags gem work for it some changes to function retrieving flag for it would have to be made.

@wjwitek can you give a little instruction on this configuration? I tried to create a few stores, but I don't get any switch menu after I create the second store. There is no world icon next to the cart icon anymore.
I'm trying to see the issue you are describing.

@mrbrdo Yes, of course. As far as I know it's not something you can change via admin panel, but in general it's part of frontend's configuration, a preference called :show_store_selector which has to be set to true, for example using rails console: Spree::Config.show_store_selector = true

@wjwitek the correct option is now Spree::Frontend::Config.show_store_selector.
I tried it, but it works fine even with my changes to flags:
gem 'spree_frontend', github: 'mrbrdo/spree_legacy_frontend', branch: 'flags_gem'
Here is my spree_starter I used to test this (flags_gem branch):
https://github.com/mrbrdo/spree_starter/tree/flags_gem
Are you sure you didn't make some changes which could be affecting this? Do you have the same issue with a fresh spree_starter?

@mrbrdo I've tried it again and it works alright. I have no idea what I have done wrong before, sorry for the trouble.

@wjwitek no problem, glad that we sorted it out :)

@nciemniak since it seems the above issue was not related, would you like to merge this?

@mrbrdo yep, definitely! thanks for confirming that everything works :tada:


Create Series-movies suggester.md

📝 Description
Asks the user for the genre and suggests movie/series along with streaming service based on what mood the user is in
💣 Is this a breaking change (Yes/No):

[ ] Yes
[x] No

🚧 How to migrate?
Don't need.
📝 Additional Information
Hacktoberfest2023

Same as #2643 , so I will close the expired ones


hex

It would be good to add hex conversion support.

pr welcome :)

What exactly do you mean by this? Like #FFFFFF to [255, 255, 255] and so on? Why not use hex-rgb? Not sure if the functionality here is really useful since it's a simple string/bit shift operation.

:+1:
@Qix- For convenience. Also since we plan on using this in Chalk and I would like to be able to use hex colors with Chalk.

Alright, I can add it in.

Landed in 7234a9a7fbef3a4382a920eec19d6402675cac32. Thanks! :dancer:

@Qix- Maybe also let to detect short notation like #fff ?


ABS tests

update to latest recommended team label syntax
Re-enable ABS tests this one still failing :(

Why is the validate step failing?

Why is the validate step failing?

Complaining that helm repo is not installed.
But it's configured in .circleci/ct-config.yaml, so it should find it.
2022-11-25 15:24:34,517 step_exec_lib.utils.processes INFO: Running command:
2022-11-25 15:24:34,517 step_exec_lib.utils.processes INFO: helm dependencies update ./helm/loki
2022-11-25 15:24:51,693 step_exec_lib.utils.processes INFO: Command executed, exit code: 0.
2022-11-25 15:24:51,694 step_exec_lib.steps INFO: Running build step for HelmChartToolLinter
2022-11-25 15:24:51,694 app_build_suite.build_steps.helm INFO: Running chart tool linting
2022-11-25 15:24:51,694 step_exec_lib.utils.processes INFO: Running command:
2022-11-25 15:24:51,694 step_exec_lib.utils.processes INFO: ct lint --validate-maintainers=false --charts=./helm/loki --chart-yaml-schema=/abs/app_build_suite/build_steps/../../resources/ct_schemas/gs_metadata_chart_schema.yaml
2022-11-25 15:24:51,775 step_exec_lib.utils.processes INFO: Command executed, exit code: 1.
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO: Linting charts...
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO:
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO: ------------------------------------------------------------------------------------------------------------------------
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO:  Charts to be processed:
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO: ------------------------------------------------------------------------------------------------------------------------
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO:  loki => (version: "0.5.1-3a5acf6d1e620ff9ced956cc4b9f6fa435bfc3da", path: "./helm/loki")
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO: ------------------------------------------------------------------------------------------------------------------------
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO:
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO: Error: no repository definition for https://grafana.github.io/helm-charts. Please add the missing repos via 'helm repo add'
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO: ------------------------------------------------------------------------------------------------------------------------
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO: No chart changes detected.
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO: ------------------------------------------------------------------------------------------------------------------------
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm INFO: failed linting charts: failed building dependencies for chart "loki => (version: \"0.5.1-3a5acf6d1e620ff9ced956cc4b9f6fa435bfc3da\", path: \"./helm/loki\")": failed waiting for process: exit status 1
2022-11-25 15:24:51,775 app_build_suite.build_steps.helm ERROR: ct run failed with exit code 1
2022-11-25 15:24:51,776 step_exec_lib.steps ERROR: Error when running build step for HelmChartToolLinter: Linting failed
2022-11-25 15:24:51,776 step_exec_lib.steps ERROR: Error when running build: Source: 'HelmChartToolLinter', message: Linting failed.. No further build steps will be performed, moving to cleanup.

Maybe @giantswarm/team-honeybadger would know?

Could it be you are missing https://github.com/giantswarm/prometheus-operator-app/blob/514d9809f6ef6c9a624b1294dc6fe2050f8a392c/.abs/main.yaml#L5 ?

Could it be you are missing https://github.com/giantswarm/prometheus-operator-app/blob/514d9809f6ef6c9a624b1294dc6fe2050f8a392c/.abs/main.yaml#L5 ?

Holy cow! :astonished: I thought that line was to be set in circleci config only.
You're right, that solves the build! :facepalm:
Thanks!

It's a bit confusing we have to set it in multiple places though


[improve][mysql-cdc] Optimize the default value range of mysql server-id to reduce conflicts.

Purpose of this pull request
server_id conflicts occur in the mysql-cdc job

Does this PR introduce any user-facing change?
none

How was this patch tested?

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

Hi, Please fill in these details in detail.

@hailin0 PTAL


Update de_de.json

structure adjusted
added new entries
fixed a few lines
removed old lines that no longer exist

If this PR isn't updated by 2025-02-08, it will be closed to let others feel free to open a PR to update German translations. If it is updated after then, it will be reopened.


feat(selector): draggable bottomsheet country selector

PR Type
New Feature
Breaking changes
None
Description:
Add a new CountrySelectorNavigator : DraggableModalBottomSheetNavigator
Available parameters:

countries (optional, default: all countries)
initialChildSize (optional, default: .5)
minChildSize (optional, default: .25)
maxChildSize (optional, default: .85)
borderRadius (optional, default: topLeft/topRight with circular border of 16)

Side Note changes

remove the constructor and countries property in abstract CountrySelectorNavigator as it's confusing to have the same property in extended and abstract class (abstract one is useless when implementation don't call super) and it breaks interface/implementation separation concerns, so I just keep the mandatory method navigate.
update the example pubspec.yaml to use current local dev version using relative path.
update the example layout to use dropdown instead of radio as previous layout was failing to fit in mobile screens

Example screen record:
https://user-images.githubusercontent.com/6652177/131473911-b74b2068-325b-4ee7-bbda-2043f218352c.mp4

Awesome, thank you. I'll check it out this evening or tomorrow by the latest.
By the way, you submitted an issue with a fix in the comment (about dispose). Do you have the branch on hand ?

remove the constructor and countries property in abstract CountrySelectorNavigator as it's confusing to have the same it's confusing to have the same property in extended and abstract class

It implements rather than extends the CountrySelectorNavigator, so I'm not sure what you mean by that. The interface CountrySelectorNavigator country property was there to make sure any implementation defined that property.

I understand the goal expected, however, as abstract is never instantiated (kind of normal thing) and act as an interface (use implements as you say), have a countries property is IMHO a non sense, you can though have a getter on interface for a countries property so that it ensures that implementations classes define it, but I think it's superfluous too as the inner implementation of each country selector navigator should stay in its class, and the countries property is in this case, it's not used anywhere and all implementations pre-defined did not use it, just redefine it inside implementation. As I understand, the only needed thing is the navigate method.
The only usage I can think of, is when you just want to define the navigate method.
My update for this does not change anything for others implementations, and I (tried to) follow the same logic for the new one, and thus add a countries property on the constructor of DraggableModalBottomSheetNavigator.
But I realise that it creates a BC breaks for custom user implementation without constructor using extends instead of implements.
This can be achieved quite simply by separating implementations and abstract class (this is quite obscur in dart, as abstract & implementations uses the same abstract keyword for both. I'll will make a proposal here this afternoon.
That said, I can restore it if you think this is necessary ;)

Here is a patch to apply (using git apply patch-for-no-BC.txt) that will remove BC breaks introduced here.
Not sure it's the way though ;)
patch-for-no-BC.txt

One way to resolve the country thing is would be to have an inherited widget for the countries, that would be for another PR though


[JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

See JEP-222. Alternative to #129. Works with https://github.com/jenkinsci/remoting/pull/357. Requires #147.

We will need to update the Windows side as well (https://github.com/jenkinsci/docker-jnlp-slave/blob/master/jenkins-agent.ps1)

Yes, I did not try that yet but I could.

the upstream pull request in Remoting needs to be released first

Yes, this is on hold until the core changes are released.

So can you merge & release this @jeffret-b, or whoever is maintaining this repo?

I don't have permission in this repository. Maybe @slide or @oleg-nenashev

@MarkEWaite thanks! Now can you can a release please? https://github.com/jenkinsci/docker-jnlp-slave/compare/3.40-1...master

I would like to leave this for @oleg-nenashev to release, since he's released the most recent several versions of it and I've never released a version.  If @oleg-nenashev has not been able to release it by tomorrow, I'll attempt the release.

ping @MarkEWaite @oleg-nenashev

Sorry that I missed this one @jglick.  As I look at the repository, the release process is not immediately clear to me.  I'll talk with @oleg-nenashev tomorrow and learn how to release from this repository.

I am not sure either. It may suffice to just create a tag and wait for Docker Hub automated builds to kick in.

IIUC from the Jenkinsfile, Linux publishing is passive, whereas a Jenkins project publishes the Windows version.

The linux publishing should be done on dockerhub builds, though I am not sure how the tagging for specific versions takes place. For the Windows versions, we are publishing them via trusted.ci, we do not currently do a version specific release, I would need to look into that.

on it

The 4.0.1-1 release is now available and ready to use.  A CONTRIBUTING document has also been added which includes a video link to a session that describes the release process.

$ docker run --rm jenkinsci/jnlp-slave:4.0.1-1 2>&1 | fgrep -i websocket
 -webSocket                            : Make a WebSocket connection to Jenkins

:tada:


[iOS] Can`t find variable:global

weex SDk 从<IP_ADDRESS>升级到。0.20.1 运行报错。升级前是没有问题的。谢谢。

errorCode:-9700 functionName:func: createInstance arg:start exception:[WX_KEY_EXCEPTION_WXBRIDGE]

As it said, it is a JavaScript Exception. Check your JS code first.
BTW: We just enabled the error prompt in 0.20.xx, it doesn't mean everything of your JS code is fine in 1.18.xx

I tracked the code and found that if import {Buffer} from'buffer' was added to the interface, the error would be reported. This file is a file under node_modules.


Epoll::IN prevents epoll_wait an interrupt from GPIO

https://github.com/smol-rs/polling/blob/e2129ea87933609da994e354f68cc4256726c15f/src/epoll.rs#L277
I'm trying to use this crate to poll GPIO interrupt in Linux (Raspberry Pi 4) via /sys/class/gpio/.  But as read_flags above always include Epoll::IN, it always return a readable event for the exported gpio file (i.e. /sys/class/gpio/gpioN/value) , and hence cannot detect the interrupt.
In my testing, removing Epoll::IN (or only use Epoll::PRI) fixes this case and enables the poller detects the GPIO interrupt. However, the current poller .add() API does not accept custom read flags. I'm wondering if such issue has been considered before, and is there any plans to support custom read flags for epoll?

There is other precedent for making Event an opaque structure that has other platform specific info, see #112. In addition to fact that we need to make a breaking change soon (#38), I would be partial to exposing other epoll flags on the Event type.
However, we should also consider if such an abstraction should be exposed on other platforms. kqueue and poll, for instance. If so, would there be a cross-platform way of doing it?

However, we should also consider if such an abstraction should be exposed on other platforms. kqueue and poll, for instance. If so, would there be a cross-platform way of doing it?

In poll, there is POLLPRI that is equivalent to EPOLLPRI in epoll. I'm not sure about kqueue.  I was wondering, maybe Priority data is general enough to be a cross-platform thing?  If yes, then maybe Event can provide an API to poll / filter priority data only?

kqueue's priority mechanism seems to be platform-specific. DragonBSD and OpenBSD seem to have the EVFILT_EXCEPT filter which is combined with the NOTE_OOB filter flag, but FreeBSD does not appear to support this. macOS may support it, but I'm not certain, and it has its own mechanism via the EV_OOBAND flag on the read filter. (Note that all of this is gleaned from searches and I haven't tested any of it, so it should be taken with a grain of salt.)

However, we should also consider if such an abstraction should be exposed on other platforms. kqueue and poll, for instance. If so, would there be a cross-platform way of doing it?

Extension traits is what you can do, it's common in winit, so you should be familiar.

Extension traits is what you can do, it's common in winit, so you should be familiar.

When possible, I generally prefer exposing a cross-platform abstraction. Something like this would definitely be possible for event ports and Windows; unfortunately it looks like kqueue is the odd one out here.

As of #133 it is now possible to wait on HUP and PRI specifically.

well, it still isn't possible to remove IN from the flags, even with that PR merged...

You can do this to only select PRI events:
Event::none(key).with_pri()


Make sure only one line of debug info

Hi, this is a great module, thank you.
I use swagger-mock-api to load several swagger file, so there would be several swagger-mock-api instance, while I request one url, all instance will log the request even it is miss-matched.
one request will log serveral times, looks bad
Request: GET /users
Request: GET /users
Request: GET /users
Request: GET /users

I had not considered that use case, thank you!
I'll be able to merge this tonight (roughly 10 hours or so).

Actually, I'm going to revert this and move the change over into the source code, rather than the dist code. I'll issue another release shortly with the change.


cmake: sysbuild PRE_CMAKE, POST_CMAKE, PRE_DOMAINS, POST_DOMAINS hooks

Provide a uniform way for sysbuild modules to create hooks that are
called at specific time during sysbuild CMake configure time.
A module can create functions following the scheme:

<module-name>_pre_cmake
<module-name>_post_cmake
<module-name>_pre_domains
<module-name>_post_domains

those functions, if defined, will be called by sysbuild CMake at the
location indicated by the function name.
A new global variable SYSBUILD_CURRENT_MODULE_NAME is created, which
a module can use to know it's own name when defining those functions
during sysbuild module CMake inclusion.

This PR depends upon #54979
First commit is to be ignored, as it is a squash of refered PR.

DNM as docs are missing


Tighten ES lint checks

This will pick up many more useful lint issues.

Closing PR until it's actionable. Still want to continue this work, but will open a new PR when it's ready.


If document is multi-language, then lang codes delimit by -

From @Intelligent2013:
UPDATE: if document is multi-language, then lang codes delimit by -.

Originally posted by @ronaldtse in https://github.com/metanorma/metanorma-iec/issues/154#issuecomment-1293574126

@ronaldtse I didn't find exactly identifier mentioned on screenshot, but updated version https://webstore.iec.ch/publication/68247
They don't mention language in identifier's part, only in "Additional information" section.
Does it mean we shouldn't output language by default?
Also, I found we don't parse languages for IEC's identifiers yet.
I tried to find some identifiers with language, but didn't find any. Only some "IECQ" identifiers:
IECQ 080000-FR:2022
IECQ 080000-EN:2022

But we already parse them and treat language as "part". Like "5" in IECQ 001002-5:2005.

This sample is given in the PDF footer, so it is not exposed on the Internet (i.e. it cannot be found on the Internet).
Nonetheless this is a use case we need to implement it because we need to generate the footer in PDF:

'IEC 60794-1-23:2019-10(en-fr)'

This sample is given in the PDF footer, so it is not exposed on the Internet (i.e. it cannot be found on the Internet).
Nonetheless this is a use case we need to implement it because we need to generate the footer in PDF:

'IEC 60794-1-23:2019-10(en-fr)'

@ronaldtse so we don't need to parse them?

We need to parse and generate it.


Enhancement request: provide support for sys/uio.h

I have Linux code relying on the above header.
Thanks!

I haven't implemented readv/writev support because I have no application code that uses these calls. I implement POSIX calls for Windows as I encounter them in the wild in Linux code that I'm porting. If you ported these functions, feel free to send me a pull request.


added proper EOLs fix #7

added options.suffix

Much appreciated! I hope to get this in tomorrow.


The removal of Orchard.FileSystem

This was built through my lack of understanding of IFIleInfo and IFileProvider.
I have changes some things.

Removed Orchard.FileSystem
Made use of IHostingEnvironment
Added app_data to ShellOptions... if you need app_data access, you can go through there.

Good point, I'm going to remove the ShellOptions one
Sent from my iPhone

On 28 Sep 2016, at 01:27, Sébastien Ros<EMAIL_ADDRESS>wrote:
@sebastienros commented on this pull request.
In src/Orchard.Environment.Extensions/ExtensionLibraryService.cs:

         ILogger<ExtensionLibraryService> logger)

     {
         _metadataReferences = new Lazy<List<MetadataReference>>(GetMetadataReferences);
         _applicationPartManager = applicationPartManager;

       _fileSystem = fileSystem;

       _probingFolderPath = appDataFolder.MapPath(ProbingDirectoryName);

       _shellOptions = shellOptionsAccessor.Value;

       _probingFolderPath = Path.Combine(_shellOptions.ShellHostContainer.PhysicalPath, ProbingDirectoryName);

what's the difference between _shellOptions.ShellHostContainer.PhysicalPath and IHostEnvironment.ContentPath ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Are you also removing IHostEnvrionment? Please do if not.

Merged it in.


Simple CSS3 calc(100% - 10px) fails

I guess the following error ...

Incompatible units. Change the units or use the unit function. Bad units: '%' and 'px'.iless: Incompatible units. Change the units or use the unit function. Bad units: '%' and 'px'.

... every time I used the following:
height: calc(100% - 146px);

I think you need to replace it by
height: ~"calc(100% - 146px)";

Hi @joffreydemetz
Thanks for replying. The code that you have suggested is not a valid CSS. You can check it using the official W3C validator at https://jigsaw.w3.org/css-validator/#validate_by_input+with_options
Use something like the following code in the direct input field and click on the check button. The test will fail.
.content {
  height: ~"calc(100% - 146px)";
}

And if you redo the same test using the following, the following code, the test will pass.
.content {
  height: calc(100% - 146px);
}

My opinion about this issue is that LESS should not be in charge of evaluating the calc)_ expression. It's not a mix-in. It's intended for the browsers. And any browser that complies with the CSS3 standard should be able to handle this properly.
According the the W3C's recommendation, as long as the units are valid, they can be mixed and matched with no issue and the browser will figure out a way to compute a result. See their own example at https://www.w3.org/TR/css-values-3/#calc-notation
I propose that the whole notion of strict-units should be entirely removed from the iLess library. The task of evaluating the calc() expression should be left for the browser to decide. It's a client-side thing and and units like vh, vw, %, em, etc. are relative to the current running context. For example, vh and vw will depend on the size of the viewport at the time of rendering the page, they cannot be evaluated during a preprocessing phase in less.
When I was fiddling around with the flags, I have found myself with calc(100% - 25px) being converted to calc(75%) which is wrong in two ways:

First: the expression should not have been modified.
Second: calc(75%) doesn't serve any purpose.

height: ~"calc(100% - 146px)";

This above is not css but less syntax.
Less has an internal calc() function so height: calc(100% - 146px) is logically not valid since the parser tries to do the math with different units.
height: calc(300px - 150px) or height: calc(100% - 25%) would both work but the result is not what you need .. it would result respectively be height: 150px and height: 75%.
If you want your css to be :

.content { height: calc(100% - 146px); }

to let the browser do the math .. you need to tell to the less parser not to use the internal calc() function and for that you need to wrap your expression in a string literal ~"anything you want left unparsed".
So in your .less file it should be :
.content {
  height: ~"calc(100% - 146px)";
}

which will result in your css file to be :
.content {
  height: calc(100% - 146px);
}

Another post anwsers the calc() issue on the less.js repo : https://github.com/less/less.js/issues/974#issuecomment-9229470

My opinion about this issue is that LESS should not be in charge of evaluating the calc

Sometimes you need to calculate some stuff so the method can be useful.
But it's true the internal calc() function could have been called something else to avoid this issue.
Since Mishal's parser is based on Less.js (with an internal calc() function !) you better start using the string literal wrapper !!
I also use it in some of my mixins like for example :
.box-shadow(~"0px 3px 4px 4px rgba(255,255,255,.1), 0px -2px 3px 0px rgba(0,0,0,.2)");
.animation(~"Blink 1s linear infinite");
.transition(~"background-color .4s, color .3s");
Hope this helps

It does help a lot. Thank you so much.
I went and did some research on my own after reading your answer and I have discovered that LESS "does not" have a calc() function. But it does have an interesting behaviour that makes it evaluate anything between parenthesis. So I went on  and created the following:
.content {
  height: fubar(100% - 146px);

  a {
      color: green;
  }
}

which produces the following code after being compiled ...
.content {
	height: fubar(-46%);
}

.content a {
	color: green;
}

It literally assumed that fubar() was a function and evaluated whatever it found in the parenthesis.
So the ~"anything" comes in handing for leaving anything as-is in the resulting CSS as you said.
I think that this thread can now be closed. The answer you have provided will help me fix the issues in my LESS file. I will however create another issue for a possible minor bug I may have discovered.


MitoFish DB fails to download

$ crabs db_download --source mitofish --output mitofish.fasta --keep_original yes
downloading sequences from the MitoFish database
Traceback (most recent call last):
File "/home/andor/miniconda3/envs/CRABS/bin/crabs", line 1372, in
main()
File "/home/andor/miniconda3/envs/CRABS/bin/crabs", line 1369, in main
args.func(args)
File "/home/andor/miniconda3/envs/CRABS/bin/crabs", line 96, in db_download
dl_file = mitofish_download(url)
File "/home/andor/miniconda3/envs/CRABS/lib/python3.6/site-packages/function/module_db_download.py", line 139, in mitofish_download
os.remove('complete_partial_mitogenomes.zip')
FileNotFoundError: [Errno 2] No such file or directory: 'complete_partial_mitogenomes.zip'

Hello @cement-head,
Can you please let me know what version you're working on? Please make sure to use the most up-to-date version crabs --version 0.1.8, which is available on GitHub. The Docker version should be fine as well, while the conda version is too out of date.
Best regards,
Gert-Jan

I'm also having an issue downloading the MitoFish DB. I tried using the docker container 'quay.io/swordfish/crabs:0.1.4'. Is there a more up to data docker container?
The error with the docker container is:
downloading sequences from the MitoFish database
Traceback (most recent call last):
File "/usr/local/bin/crabs", line 1428, in
main()
File "/usr/local/bin/crabs", line 1425, in main
args.func(args)
File "/usr/local/bin/crabs", line 114, in db_download
dl_file = mitofish_download(url)
File "/usr/local/bin/function/module_db_download.py", line 140, in mitofish_download
results = sp.run(['unzip', 'complete_partial_mitogenomes.zip'], stdout = sp.DEVNULL, stderr = sp.DEVNULL)
File "/usr/lib/python3.8/subprocess.py", line 493, in run
with Popen(*popenargs, **kwargs) as process:
File "/usr/lib/python3.8/subprocess.py", line 858, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "/usr/lib/python3.8/subprocess.py", line 1704, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'unzip'

Hello @a4000,
Unfortunately, there would not be a more up-to-date Docker container at this stage. My apologies, I do not have personal experience with Docker. @hughcross, could you please have a look at the conda and Docker versions? They will likely need to be updated.
Best,
Gert-Jan

I found the line causing the error "No such file or directory: 'unzip'". I sent a pull request that should fix the issue. I have experience with Docker, so I can help updating the docker container if needed.

@gjeunen Opps - just saw that CONDA has not been updated.  My bad - I'll try the git hub version.

@gjeunen I figured out why the docker container causes "FileNotFoundError: [Errno 2] No such file or directory: 'unzip'" when downloading the MitoFish database, it's because unzip isn't installed in the container. That's something to keep in mind for future versions of the container.

@a4000,
Thank you very much for the update! @hughcross, could you please add unzip to the Docker container?
Best,
Gert-Jan

Hello everyone. I am maintaining the MitoFish DB. It should be noticed that only the newest GitHub version of CRABS works.

Hi @cement-head, we now have a workable conda version that uses pip to install crabs. I am still testing it but if you want to check it out see the instructions on issue 32. Once we get it tested we will change the instructions on the main page. If you do try it, please let us know how it goes.
And thanks for the heads up, @a4000, I will add unzip to the next Docker version, which I will try to get out next week.

Hi all!
I was wondering whether there have been any updates to the docker image since the aforementioned issues with downloading the MitoFish database due to the absence of unzip?
I downloaded the docker image using singularity today, I am still getting the issue reported above:
Traceback (most recent call last):
  File "/usr/local/bin/crabs", line 1428, in <module>
    main()
  File "/usr/local/bin/crabs", line 1425, in main
    args.func(args)
  File "/usr/local/bin/crabs", line 114, in db_download
    dl_file = mitofish_download(url)
  File "/usr/local/bin/function/module_db_download.py", line 140, in mitofish_download
    results = sp.run(['unzip', 'complete_partial_mitogenomes.zip'], stdout = sp.DEVNULL, stderr = sp.DEVNULL)
  File "/usr/lib/python3.8/subprocess.py", line 493, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'unzip'

Other than that, the docker image is working great, thanks for this cool package!

Hello @ThomasLuypaert,
Thank you very much for your message. We'll try to sort this out asap.
@hughcross, could you please check if the Docker image is running the latest version of CRABS?
Thanks,
Gert-Jan

Hi,
You are right @ThomasLuypaert, the docker image is behind. I should be able to get it updated this weekend. Once I do, I will post back here. Thanks, Hugh

Thanks, I appreciate the quick response. Looking forward to trying out the package.

Hi @ThomasLuypaert and @gjeunen,
Sorry for the delay. The updated Crabs docker image is ready. It is now quay.io/swordfish/crabs:0.1.7. I will change the documentation on the site soon, but just replace the 0.1.7 with the current instructions for now.

Great, thank you! I will give it a try next week.

Hi @gjeunen and @hughcross,
Just tried the updated docker images (version 0.1.7) as you suggested, however I am still getting the same error message as before when downloading the MitoFish data:
singularity exec /MYPATH/crabs_0.1.7.sif crabs db_download -s mitofish -o mitofish_download.fasta -e<EMAIL_ADDRESS>
downloading sequences from the MitoFish database
complete_partial_mitogenomes.zip        100%[============================================================================>]  85.56M  1.05MB/s    in 84s
Traceback (most recent call last):
  File "/usr/local/bin/crabs", line 1462, in <module>
    main()
  File "/usr/local/bin/crabs", line 1459, in main
    args.func(args)
  File "/usr/local/bin/crabs", line 116, in db_download
    dl_file = mitofish_download(url)
  File "/usr/local/bin/function/module_db_download.py", line 140, in mitofish_download
    results = sp.run(['unzip', 'complete_partial_mitogenomes.zip'], stdout = sp.DEVNULL, stderr = sp.DEVNULL)
  File "/usr/lib/python3.8/subprocess.py", line 493, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'unzip'

Is unzip installed in the new docker image?
Any help is appreciated.
Cheers,
Thomas

Sorry, @ThomasLuypaert, I did not see this before. I did not test the Mitofish download with the updated crabs docker image. I will have to fix that. I will try to get that done soon.
Thanks,
Hugh

Hello @cement-head and @ThomasLuypaert,
This issue should now be resolved with the latest version of CRABS (version 1.0.0). It is currently only available via cloning the GitHub repo, but we hope to update the conda package and Docker container shortly.
Best wishes,
Gert-Jan


Reverse String

add a program which reverses the input string and returns it.

Please assign this to me under hactoberfest2022

Hello @Zohaib-Sathio can you assign me this

Please assign this to me under hactoberfest2022

@Ishantgarg-web I am assigning you the other issue in this repo

Hello @Zohaib-Sathio can you assign me this

@rahul-n18 assigned.

Hello @Zohaib-Sathio I just wanted to confirm that I need to add reverse a string prg in all the language right?

Hello @Zohaib-Sathio I just wanted to confirm that I need to add reverse a string prg in all the language right?

@rahul-n18 it's upto you, I would suggest to add your program in any one language.

I hope you can close this issue.
Its my first time here now do I get Hactoberfest accepted badge for this

I hope you can close this issue. Its my first time here now do I get Hactoberfest accepted badge for this

Yes @rahul-n18 I have added label to your accepted PR.

please assign me this @Zohaib-Sathio


Add RPN function LTReal LEReal GTReal GEReal NEReal EQReal

What have you changed? (mandatory)
Extracted from https://github.com/tikv/tikv/pull/3898, this PR adds binary compare RPN functions for Real data type.

[ ] Merge https://github.com/tikv/tikv/pull/4601 first

What are the type of the changes? (mandatory)

Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)
Unit test & Integration test

/run-integration-tests

A note for reviewers: This PR intentionally does not have comments. The comments will be added by @mapleFU later, as his task of understanding our code base. If you have any questions when understanding the PR, you can contact me privately :)

/rebuild

/run-integration-tests

LGTM


⚠ Bofrost.lu has degraded performance

In fc5df27, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1570 ms

Resolved: Bofrost.lu performance has improved in ee767cb after 6 minutes.


System.Configuration.ConfigurationErrorsException when usin AppSettings

The following code for accessing AppSettings via ConfigurationManager:
var appSettings = ConfigurationManager.AppSettings;

throws a System.Configuration.ConfigurationErrorsException:
[11/30/2017 6:18:52 PM] A ScriptHost error has occurred
[11/30/2017 6:18:52 PM] Exception while executing function: Status. System.Configuration.ConfigurationManager: Configuration system failed to initialize. System.Configuration.ConfigurationManager: Unrecognized configuration section system.serviceModel. (C:\Users\jakza\AppData\Local\Azure.Functions.V2.Cli\2.0.1-beta\Azure.Functions.Cli.dll.config line 204).
[11/30/2017 6:18:52 PM] Exception while executing function: Status
[11/30/2017 6:18:52 PM] Exception while executing function: Status. System.Configuration.ConfigurationManager: Configuration system failed to initialize. System.Configuration.ConfigurationManager: Unrecognized configuration section system.serviceModel. (C:\Users\jakza\AppData\Local\Azure.Functions.V2.Cli\2.0.1-beta\Azure.Functions.Cli.dll.config line 204).
[11/30/2017 6:18:52 PM] Function completed (Failure, Id=a559541d-3f8d-4176-b0df-8bb35588e74d, Duration=657579ms)
[11/30/2017 6:18:52 PM]
[11/30/2017 6:18:52 PM] Executed 'Status' (Failed, Id=a559541d-3f8d-4176-b0df-8bb35588e74d)
[11/30/2017 6:18:52 PM] System.Private.CoreLib: Exception while executing function: Status. System.Configuration.ConfigurationManager: Configuration system failed to initialize. System.Configuration.ConfigurationManager: Unrecognized configuration section system.serviceModel. (C:\Users\jakza\AppData\Local\Azure.Functions.V2.Cli\2.0.1-beta\Azure.Functions.Cli.dll.config line 204).
[11/30/2017 6:18:52 PM]   Function had errors. See Azure WebJobs SDK dashboard for details. Instance ID is 'a559541d-3f8d-4176-b0df-8bb35588e74d'
[11/30/2017 6:18:52 PM] System.Private.CoreLib: Exception while executing function: Status. System.Configuration.ConfigurationManager: Configuration system failed to initialize. System.Configuration.ConfigurationManager: Unrecognized configuration section system.serviceModel. (C:\Users\jakza\AppData\Local\Azure.Functions.V2.Cli\2.0.1-beta\Azure.Functions.Cli.dll.config line 204).

It seems that Azure.Functions.Cli.dll.config refers to  System.ServiceModel, which appears to be depracated/removed from .Net Core.
Info
Azure Functions Core Tools (2.0.1-beta.21)
Function Runtime Version: 2.0.11370.0
dotnet --version: 2.1.1

Also coming up against this problem.

Same, run into this issue when adding a connectionStrings section to the local.settings.json file.

I also ran into this issue, and System.Configuration.ConfigurationManager appears to be unusable because of this.
Removing the system.serviceModel section from Azure.Functions.Cli.dll.config stops the error from happening, but the configuration manager doesn't appear load up any of the app settings or connection strings. I wasn't able to find a work around to get the configuration manager working, so instead had to resort to retrieving app settings from the environment variables.

So is this related?
I'm using a third party product (NHiberate) that uses System.Configuration internally. What's the suggestion to work around this?
Exception during runtime resolution of assembly 'System.Configuration.ConfigurationManager.resources, Version=<IP_ADDRESS>, Culture=en-GB, PublicKeyToken=cc7b13ffcd2ddd51': 'System.InvalidCastException: [A]System.AppDomain cannot be cast to [B]System.AppDomain. Type A originates from 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' in the context 'Default' at location 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\2.0.7\System.Private.CoreLib.dll'. Type B originates from 'System.Runtime.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' in the context 'Default' at location 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\2.0.7\System.Runtime.Extensions.dll'. [10/05/2018 21:06:10]    at Microsoft.Azure.WebJobs.Script.Description.FunctionAssemblyLoader.ResolveAssembly(Object sender, ResolveEventArgs args) in C:\azure-webjobs-sdk-script\src\WebJobs.Script\Description\DotNet\FunctionAssemblyLoader.cs:line 66' [10/05/2018 21:06:10] Unable to find assembly 'System.Configuration.ConfigurationManager.resources, Version=<IP_ADDRESS>, Culture=en-GB, PublicKeyToken=cc7b13ffcd2ddd51'. Are you missing a private assembly file? [10/05/2018 21:06:10] Exception during runtime resolution of assembly 'System.Configuration.ConfigurationManager.resources, Version=<IP_ADDRESS>, Culture=en, PublicKeyToken=cc7b13ffcd2ddd51': 'System.InvalidCastException: [A]System.AppDomain cannot be cast to [B]System.AppDomain. Type A originates from 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' in the context 'Default' at location 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\2.0.7\System.Private.CoreLib.dll'. Type B originates from 'System.Runtime.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' in the context 'Default' at location 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\2.0.7\System.Runtime.Extensions.dll'. [10/05/2018 21:06:10]    at Microsoft.Azure.WebJobs.Script.Description.FunctionAssemblyLoader.ResolveAssembly(Object sender, ResolveEventArgs args) in C:\azure-webjobs-sdk-script\src\WebJobs.Script\Description\DotNet\FunctionAssemblyLoader.cs:line 66' [10/05/2018 21:06:10] Unable to find assembly 'System.Configuration.ConfigurationManager.resources, Version=<IP_ADDRESS>, Culture=en, PublicKeyToken=cc7b13ffcd2ddd51'. Are you missing a private assembly file?

Closing as stale

@jimmyca15 - Does AppConfig work with functions and is this a new recommended workaround for this?


Adding installation support for Nancy SAST scanner for GoLang v1.0.0 …

…release; dropping darwin-386 os/arch combination for release since artifact is unavailable in github releases

thanks for the contribution! published as v1.0.6 to the galaxy


Added Chronic Network chain info.

Please let us know if we missed any dependencies needed to make this package compatible with Chronic Network!

we'll be using the chain-registry in the new refactor — thanks @discoverdefiteam

please add here and will be taken care of https://github.com/cosmos/chain-registry