Invalid react-native configuration

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
This is related to when using react-native > 0.68. Metro complains about the react configuration not being valid.
warn Package react-native-appsflyer contains invalid configuration: "dependency.platforms.ios.podspecPath" is not allowed. Please verify it's properly linked using "react-native config" command and contact the package maintainers about this.
Here is the diff that solved my problem:
diff --git a/node_modules/react-native-appsflyer/react-native.config.js b/node_modules/react-native-appsflyer/react-native.config.js
index dfbe81b..20187c2 100644
--- a/node_modules/react-native-appsflyer/react-native.config.js
+++ b/node_modules/react-native-appsflyer/react-native.config.js
@@ -3,7 +3,7 @@ const path = require('path');
 module.exports = {
   dependency: {
     platforms: {
-      ios: { podspecPath: path.join(__dirname, 'react-native-appsflyer.podspec') },
+      ios: {},
       android: {
         packageImportPath: 'import com.appsflyer.reactnative.RNAppsFlyerPackage;',
         packageInstance: 'new RNAppsFlyerPackage()',

This issue body was partially generated by patch-package.

Hi @onelittlebird and thank you for opening this issue. There is another issue related to what you mentioned here and we are working on it. So i'm closing this one and we will keep you updated there.


Consider using the minimal-mistakes theme for Jekyll

Right now the Jupyter website is a combination of two different websites - one that's on most of the pages you land on from jupyter.org, and another that can be arrived from some of the links within pages on jupyter.org (e.g.: https://jupyter.readthedocs.io/en/latest/contributor/content-contributor.html).
There's a theme in Jekyll that is well-supported, has nice features, and is very similar to our current main theme. It's called minimal mistakes.
I don't think that migrating our Jekyll template to MM would be a ton of work since we already use Jekyll. Would folks be +1 on me giving a shot at making this migration? It could potentially allow us to standardize the design of the website using a tool that we all know is relatively well battle-tested.
(note that there have also been conversations around changing the website build setup entirely, see #234 ...I don't want this issue to suggest I think that's a bad idea, but I'm hoping this could be a relatively quick win with our current setup)

I know we've been thinking about moving Gatsby in the medium/long term. How much work do you think it would be to migrate the entire website, and what would the main benefits of this theme be over what we have now?

As a rough measure, I tend not to contribute to jekyll based sites (unless it's just a content change) and will contribute to gatsby based ones. I love that I can use React components within Gatsby.

@rgbkrk that is a good reason to use one over the other :-)
Do you find gatsby sites to be more maintainable, better community, etc?

Since this ticket has been inactive for three years old, I'm going to close as stale. If you'd like to continue the discussion, feel free to chime in.


Write '1' won't clear sha512_acc_csr.LOCK

Hi,
We are writing to sha512_acc_csr.LOCK and found that it didn't clear the LOCK. I did a bit of tracing and found the following code:
// Read & write latencies are balanced. Stalls not required
assign cpuif_req_stall_rd = '0;
assign cpuif_req_stall_wr = '0;
assign cpuif_req_masked = cpuif_req
& !(!cpuif_req_is_wr & cpuif_req_stall_rd)
& !(cpuif_req_is_wr & cpuif_req_stall_wr);
As you can see when cpuif_req is asserted, cpuif_req_masked is always asserted because cpuif_req_stall_rd and cpuif_req_stall_wr is '0'. In turn, the decoded_reg_strb.LOCK is alwasy return '1'.
Can you please take a look?
Thanks,
Linda D

If I recall off the top of my head, there is a FIPS requirement that the accelerator has to start locked by Caliptra. Only after Caliptra has performed necessary KATs can the lock be released.
I assume you are trying to release the lock from the SOC side?

Thanks for the info. Yes, I was trying to release the lock from SOC side.
Regards,
Linda


panic on nested map

I got a panic error if my struct has an nested map. Not sure but, i think it starts appear after go compiler updated. Now it 1.6.
reflect: Elem of invalid type
/usr/lib/go/src/runtime/panic.go:426 (0x42d659)
        gopanic: reflectcall(nil, unsafe.Pointer(d.fn), deferArgs(d), uint32(d.siz), uint32(d.siz))
/usr/lib/go/src/reflect/type.go:599 (0x5b3283)
        (*rtype).Elem: panic("reflect: Elem of invalid type")
/opt/project/src/github.com/fatih/structs/structs.go:535 (0x6cccd5)
        (*Struct).nested: v := val.Type().Elem()
/opt/project/src/github.com/fatih/structs/structs.go:120 (0x6c9c2e)
        (*Struct).FillMap: finalVal = s.nested(val)
/opt/project/src/github.com/fatih/structs/structs.go:84 (0x6c97db)
        (*Struct).Map: s.FillMap(out)
...

Can you please provide a reproducible struct and case that I can test. Thanks.

Thanks for quick reply. I used a next structure:
type WebhookModel struct {
	Id bson.ObjectId `json:"id" bson:"_id,omitempty"`
	Name string `json:"name" bson:"name" validate:"required,max=256"`
	Ip string `json:"ip" bson:"ip" validate:"required,ip"`
	Query string `json:"query" bson:"query" validate:"max=256"`
	Payload interface{} `json:"payload" bson:"payload"`
	CreatedAt time.Time `json:"createdAt" bson:"createdAt" validate:"required"`
}

Payload field could contain string or structured map. In case, when it's a simple map (ex. map[string]string {"test_param": "test_value"}) I got an error, described above

Could you also fill the value that makes it panicing ? Just want to get as much information as it makes debugging easier. Thanks

Ok. There are simpler example:
import (
	"github.com/fatih/structs"
	"log"
)

type WebhookModel struct {
	Name string `json:"name" bson:"name" validate:"required,max=256"`
	Ip string `json:"ip" bson:"ip" validate:"required,ip"`
	Query string `json:"query" bson:"query" validate:"max=256"`
	Payload interface{} `json:"payload" bson:"payload"`
}

model := WebhookModel{
	Name: "test",
	Ip: "<IP_ADDRESS>",
	Query: "",
	Payload: map[string]string {"test_param": "test_param"},
}

structToMap := structs.New(model)
structToMap.TagName = "bson"

//panic raised here
params := structToMap.Map()

log.Println(params)

hi. i found a solution. don't know what other bugs it could born, but package's tests completed successfully. just remove the line, where the panic raised v := val.Type().Elem(). Looks like v already contains suitable value

Thanks @russ666
I have a fix on my local branch. I just need to add some tests to be sure it doesn't break old tests. I'll push it when it's ready, you'll get notified when this get closed.

This is now fixed in master. Thanks for the feedback again 👍


Update parallel tasks for CI to 4

Describe your changes
Update parallel tasks for CI from (default) 3 to 4, because GitHub hosted runners have 4 'Process or CPU'
https://nx.dev/nx-api/nx/documents/run-many#parallel
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[ ] I have commented my code in hard-to understand areas.
[ ] I have made corresponding changes to README or wiki.
[ ] For front-end changes, I have updated the corresponding English translations.
[ ] I have run yarn run mini-ci locally to validate format and lint.
[ ] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Not any faster


Request for more a-priori documentation for progressive web apps.

Is your proposal related to a problem?
It's difficult to gauge the benefit of how and what enabling a service worker will do to an application. For example, my react app that I'm building is looking to be a mobile progressive web app to get the impression of a regular browser app. The app is powered by a backend that is served via a reverse proxy. One feature of the app, a contact list, ideally will front-load all contacts ahead of time, and periodically sync them, allowing the app to be used offline to a certain capacity.
What's particularly difficult here is trying to figure out exactly what happens when a service worker is registered. Are my reverse proxy http requests captured in the traffic? Should I concern myself with building a solution that uses local storage or indexedDB as part of the overall design, or will it be covered by the service worker? How will a scrolling component that lazily loads elements behave if the user hasn't scrolled all the way 'to the bottom' and their app is offline?
It is difficult to answer these questions without having a good understanding of what create-react-app is doing here. After a bit of digging, I found that workbox is used. I've done quite a bit of research on progressive web apps in general; some of the issues that come up; the tooling that is provided by chrome's developer tools.
Describe the solution you'd like
What I would like to see is a more comprehensive look at what is happening underneath the hood without having to dig around in every nook and cranny in the ecosystem. Particularly, it is difficult because many of the search results involve outdated examples or ejecting the app, which has long-term ramifications on the direction that a create-web-app project goes.
Describe alternatives you've considered
As I'm in an evaluation period, I'm looking more for information. Ejecting the application and trying to sew technology together manually is currently the only viable-looking alternative. Which is fine, but not preferable. Having the information available to help make an educated and informed decision on whether or not the this is right to me is what's at question here.
Thanks for your time!

Struggled a bit with this yesterday as well. Workbox is really cool but abstracts some of the technology. What really helped me was to read the MDN docs: https://developer.mozilla.org/en-US/docs/Web/API/Service_Worker_API
Specifically this example: https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/onfetch#Example
One good thing to realize is that onFetch is used for all GET calls, not just fetch calls!


DOC: Fix examples in randint description

Reference issue
Closes #18643
What does this implement/fix?
Fixes x-axis range of example illustrating randint distribution

Thanks @Kyle0; I'll push a commit to fix the CI failure and the issue I mentioned, then I'll merge.
Note that in the future, you can include [skip actions] [skip cirrus] to ensure that only the documentation CI jobs are run, since this has no changes to the code.

Thanks mdhaber


build_dev fails with RUNTIME ERROR: Field does not exist: service

With commit 5c400432ad2fadd0e7e3f0f4f5ba2503a5c3316d when running ./build_dev.sh, we get the following error:
$ ./build_dev.sh
+ set -o pipefail
+ rm -rf environments/dev/manifests
+ mkdir environments/dev/manifests
+ jsonnet -J vendor -m environments/dev/manifests environments/dev/main.jsonnet
+ xargs '-I{}' sh -c 'cat {} | gojsontoyaml > {}.yaml' -- '{}'
RUNTIME ERROR: Field does not exist: service
	components/observatorium.libsonnet:207:45-62	thunk from <object <anonymous>>
	components/observatorium.libsonnet:206:58-65
	<std>:688:15-22	thunk <val> from <function <format_codes_arr>>
	<std>:695:27-30	thunk from <thunk <s> from <function <format_codes_arr>>>
	<std>:565:22-25	thunk from <function <format_code>>
	<std>:565:9-26	function <format_code>
	<std>:695:15-60	thunk <s> from <function <format_codes_arr>>
	<std>:700:24-25	thunk from <thunk <s_padded> from <function <format_codes_arr>>>
	<std>:475:30-33	thunk from <thunk from <function <pad_left>>>
	<std>:475:19-34	thunk from <function <pad_left>>
	...
	<std>:750:7-46	function <anonymous>
	<std>:227:7-23	function <anonymous>

	vendor/kube-thanos/kube-thanos-query.libsonnet:61:24-29	thunk from <thunk from <thunk <c> from <object <anonymous>>>>
	<std>:227:21-22	thunk from <function <anonymous>>
	<std>:749:17-21	thunk from <function <anonymous>>
	<std>:749:8-22	function <anonymous>
	<std>:227:7-23	function <anonymous>

	During manifestation

Can reproduce this locally, looking into it right now.


Pet physics fix

Describe your changes
Fixes this issue : https://github.com/webaverse/app/issues/1949 by keeping the physics enabled on the app objects
Note : also I changed the _initPhysics function name to match its functionality, same with _deinitPhysics
@avaer lmk if I need to revert that change

Issues:
Everything else seems fine. We are able to attack the fox after equipping. But just these 2 issues(maybe these can be separate issues?0
1-The fox, if equipped, gets damaged, but it wont disappear like other objects.
https://user-images.githubusercontent.com/35926530/183659699-854bb030-540a-4c80-9993-9d9055581dbd.mp4
2-Fox can be tilde grabbed when equipped
https://user-images.githubusercontent.com/35926530/183659900-922ce185-62c8-4181-89e6-38993ac36fd2.mp4


Does not focus on other component when "TAB" key is pressed on IE

Taking from "as a part of a form(DateRangePicker)" example, when we focus on the first datepicker and press tab to focus on the next datepicker component, it takes 2 tabs to achieve that. When try to tab out of the end date datepicker, it does not focus on the inputs below (which is the expected behavior and works well in chrome).

Can you include a gif of the behavior?

https://streamable.com/xo5z3

@majapw any updates on this issue?

I've been doing some testing with tab behavior using the storybook in various browsers.  I'm not sure using the storybook is a very accurate "environment" for testing tab order behavior as the code under test is within an iframe of a page with other elements that have varying tabIndex and other tab order precedence.
The "Show Info" button in the top right corner actually has a tabIndex attribute with a value of 0 thus giving it priority in the tab order which is why, in at least Chrome and Firefox, that is what the focus goes to next after hitting tab from the DateInput.  This behavior has nothing to do with the DatePicker code.
I would suggest if you are still having this problem you provide a code example where you've implemented react-dates and not using the storybook.

Storybook was just a rough example of the issue. I have tried that in my application as well and facing the same problem. The behavior is seen on IE and not other browsers. For me it jumps to the chrome page link.
For now I have provided manual tab control using jquery(temporary fix).

I'm also facing the same issue with IE. Please help me if you have the fix for this.


IX-Async implementation of ForEachAsync possibly failing to dipose enumerator

We got an EF Core 1.0.0 RC2 bug report at https://github.com/aspnet/EntityFramework/issues/5440 that could be explained by ForEachAsync() not timely calling Dispose() on the IAsyncEnumerator<T>.
We didn't get a full repro but the customers confirmed that the issue went away when we replaced IX-Async's implementation of ForEachAsync() with our own.
cc @anpete

Is there any chance you can submit your version as a PR?

This should be fixed in #170. Can you please verify with 3.0.1-build00046 or later?


atexit is also unusable on AIX

The atexit option added for #23135 is apparently also needed on AIX. This was reported to us in OpenLDAP https://bugs.openldap.org/show_bug.cgi?id=10176
Really, using atexit() in a shared library is simply wrong, and every non-glibc system and every glibc system older than 2.2.3 will do the wrong thing with it. You should instead be telling the linker to invoke your cleanup function as a destructor. You should not be relying on such a nonstandard behavior of atexit in the first place. https://pubs.opengroup.org/onlinepubs/9699919799/functions/atexit.html

A destructor would be a good solution, but openssl conforms to C89, and so their use is not realy feasible.  Instead we are planning on eliminating the use of atexit in a future release, and mandating applications call OPENSSL_cleanup on their own prior to exit.  Currently this fix:
https://github.com/openssl/openssl/pull/23394
In the master branch allows you to suppress the use of atexit() at build time, which should give you what you want.  Enabling it will require your application call OPENSSL_cleanup manually prior to exit,

Looking at this again, the original problem that was reported to us was https://bugs.openldap.org/show_bug.cgi?id=9952
We called SSL_CTX_free() in libldap's destructor, which crashed because OpenSSL's atexit() handler had already run. We "fixed" this by changing libldap to also use atexit(), so that our SSL_CTX_free would happen before OpenSSL's atexit handler. And that change caused our ITS#10176. It seems there's nothing we can safely change in libldap to address this. At this point we are going to revert our own use of atexit. The bug in 9952 will still exist; either we remove our call to SSL_CTX_free(), and accept the memory leak, or libssl is changed to not dereference the NULL pointers that are left behind by its cleanup, to avoid the crash (see the stack trace in ITS#9952).

mandating applications call OPENSSL_cleanup on their own prior to exit

What exactly does OpenSSL do in atexit that requires this? There is no need to free things like memory allocations or even file descriptors immediately before exit because the process is imminently shutting down anyway. I could imagine an application wanting to flush some buffered I/O before exit, but a cryptography library needing this is bizarre.

As far as I know, the only reason to do this is to avoid tools like valgrind complaining about a memory leak. Having openssl clean up its things helps avoid false positives in other applications.

Does that mean if we drop the atexit call, we could argue it isn't a breaking change?
We should be calling OPENSSL_cleanup in our own unit tests for valgrind etc.

Does that mean if we drop the atexit call, we could argue it isn't a breaking change?

I don't think we can argue that its not a breaking change. As soon as we drop this we will get a flood of reports about "memory leaks".

A correct leak detector should incorporate reachability into how it reports things. We primarily use LSan, which gets this right, and this says valgrind does too:
https://developers.redhat.com/blog/2021/04/23/valgrind-memcheck-different-ways-to-lose-your-memory
It sounds then like the reports will be limited to people misunderstanding valgrind's output, and they can be pointed to this document. And you can always tell them to call OPENSSL_cleanup, if they are really truly insistent.
It'll be tedious to deal with that confusion, but the status quo is crashes (or perhaps even exploitable memory errors!) in real world applications because OpenSSL's use of atexit doesn't match your callers use of threads.
It also sounds like OPENSSL_cleanup's documentation should be fixed. It's not a mandate on applications, but an optional call for applications that really want to waste cycles on program shutdown. It probably needs to come with some warnings too. In my experience with OpenSSL callers, it's quite common for library code to call such cleanup functions, not realizing the implications for other libraries in the same address space that use OpenSSL. For BoringSSL, we intentionally make all the global cleanup functions into no-ops because they don't actually do anything useful, and it's so common for folks to get this wrong.

As a consumer distributing a python extension module linked with OpenSSL, the use of atexit is a big footgun for us, as it implicitly ties the lifetimes of the Python process, our extension module, and the OpenSSL library together in a way that makes it very easy to produce UAFs and such (for example, when any thread lives longer than the main thread).

I think one of the motivations to change to use atexit is that libraries got this wrong all the time, calling it and causing problems for other users.

That doesn't really solve the problem, just makes it worse. The right thing for the libraries wasn't atexit. As we've seen throughout all this, atexit is a problem for libraries. The libraries cannot guarantee anything about how the top-level application above uses threads, and the top-level application may not even know OpenSSL is involved because it's abstracted away. The right thing for the libraries is to just let process shutdown free things.
Libraries called OPENSSL_cleanup because they saw a function named "cleanup" and assumed they needed to call it. It's better now, but OpenSSL is old, with a long history of very unclear, complicated, and poorly documented initialization requirements. This led to projects just copy-paste a random initialization-looking functions from other code. Then they see a cleanup function and naturally assume they need to call it.
Even OpenSSL's current documentation is still misleading here:

OPENSSL_INIT_NO_ATEXIT
By default OpenSSL will attempt to clean itself up when the process exits via an "atexit" handler. Using this option suppresses that behaviour. This means that the application will have to clean up OpenSSL explicitly using OPENSSL_cleanup().

https://www.openssl.org/docs/man3.2/man3/OPENSSL_cleanup.html
As discussed on this bug, this is false. The application does not need to clean OpenSSL up explicitly, and indeed doing so risks security vulnerabilities in multi-threaded programs.
The right behavior is to use OPENSSL_INIT_NO_ATEXIT and then not call OPENSSL_cleanup. But this is a footgun, so OpenSSL should just never register atexit and then fix the documentation to discourage OPENSSL_cleanup. (I would go even further. Make OPENSSL_cleanup a no-op, because we have to assume applications were written against OpenSSL's old documentation, which incorrect recommended OPENSSL_cleanup. The only way to safely meet that documented API contract is to make OPENSSL_cleanup do nothing. This is what BoringSSL does.)

I think the cleanup function was introduced at the same time as the atexit, and there were 1 or more other cleanup functions before that that now do nothing.

Ah interesting. Okay, so anyone calling OPENSSL_cleanup is probably doing so less out of confusion and more out of the bad documentation. I think the bad documentation is still sufficient to warrant turning this into a no-op, but either way the important point is that libraries can't safely call atexit. In order to call atexit, you need to know something about how the whole program uses threads (namely whether threads outlive main) and only the top-level application can know that.
Which is fine because there is no reason to free reachable globals on process shutdown.

There is such a reason. It is an easy metrics to have 0 leaks at shutdown. If you have some, you have to deal with them - whether they are one-time or not, for example.

In the meantime, (again looking at the stack trace in our ITS#9952) would it be acceptable to patch around these crashes? e.g.
diff --git a/crypto/threads_pthread.c b/crypto/threads_pthread.c
index ad6c259d92..b6cd0cad23 100644
--- a/crypto/threads_pthread.c
+++ b/crypto/threads_pthread.c
@@ -657,6 +657,8 @@ CRYPTO_RWLOCK *CRYPTO_THREAD_lock_new(void)

 __owur int CRYPTO_THREAD_read_lock(CRYPTO_RWLOCK *lock)
 {
+    if (lock == NULL)
+        return 0;
 # ifdef USE_RWLOCK
     if (pthread_rwlock_rdlock(lock) != 0)
         return 0;
@@ -672,6 +674,8 @@ __owur int CRYPTO_THREAD_read_lock(CRYPTO_RWLOCK *lock)

 __owur int CRYPTO_THREAD_write_lock(CRYPTO_RWLOCK *lock)
 {
+    if (lock == NULL)
+        return 0;
 # ifdef USE_RWLOCK
     if (pthread_rwlock_wrlock(lock) != 0)
         return 0;
@@ -687,6 +691,8 @@ __owur int CRYPTO_THREAD_write_lock(CRYPTO_RWLOCK *lock)

 int CRYPTO_THREAD_unlock(CRYPTO_RWLOCK *lock)
 {
+    if (lock == NULL)
+        return 0;
 # ifdef USE_RWLOCK
     if (pthread_rwlock_unlock(lock) != 0)
         return 0;

Kurt Roeckx wrote:

I think the cleanup function was introduced at the same time as the atexit, and there were 1 or more other cleanup functions before that that now do nothing.

Functionality to initialize and clean library is existing since beginning. Macro or set of functions or single function is just different implementation.
In general clean exit could ensure that resources are freed. It is not about cases related to cryptography library.
It could be free of resources like file descriptors or sockets. Note cryptography library may use such resources indirectly.
Regards,
Roumen

My suggestion for applications affected by this is to call OPENSSL_init_crypto with OPENSSL_INIT_NO_ATEXIT, and not call the cleanup function.
If it's always a problem on the OS, use the build time option.
In some future version we might change the default not to use atexit.

There is such a reason. It is an easy metrics to have 0 leaks at shutdown. If you have some, you have to deal with them - whether they are one-time or not, for example.

That is easy, but given the number of projects that atexit is broken, it's a bit too simplistic. There are much better leak detectors that don't have this problem. Both LeakSanitizer and valgrind do a reachability check. That's the better way to check for leaks.
atexit is also worse for performance! Messing with your allocator's bookkeeping for a ton of individual allocations is slower than just letting the kernel tear the whole thing down.

It could be free of resources like file descriptors or sockets. Note cryptography library may use such resources indirectly

Sockets and file descriptors, like memory, are already destroyed for you on process shutdown.

My suggestion for applications affected by this is to call OPENSSL_init_crypto with OPENSSL_INIT_NO_ATEXIT, and not call the cleanup function.

While this is the right behavior, it's not what the documentation suggests. Given the problems, it sounds like you all at least should update that.
But also keep in mind (this perhaps should be documented) that this is not a reliable solution for a library. Only the first call gets to determine whether atexit happens. If some random other library in your program initializes OpenSSL first and doesn't pass the flag (perhaps the library author never ran into this problem and followed OpenSSL's documentation), you still get atexit.
So while it's the right behavior, and the best way for applications to fix it right now, OpenSSL still has something to do here.

Just to note - we faced a similar dilemma in OpenLDAP's libldap, and we fixed this 22 years ago.
https://git.openldap.org/openldap/openldap/-/commit/ffa4b2634389ecc129f59a1de05d44f62b6bb871
Use a destructor when the compiler supports it; only use atexit when there's no support for destructors and you're building a static library. It's silly not to use a feature that everybody's compiler supports today, and choosing to rely on a nonstandard glibc behavior instead.

Kurt Roeckx wrote:
I think the cleanup function was introduced at the same time as the atexit, and there were 1 or more other cleanup functions before that that now do nothing.
Functionality to initialize and clean library is existing since beginning. Macro or set of functions or single function is just different implementation. In general clean exit could ensure that resources are freed. It is not about cases related to cryptography library. It could be free of resources like file descriptors or sockets. Note cryptography library may use such resources indirectly. Regards, Roumen

The use of atexit changed at 3.3 with new test introductions and changed existing behaviour of OpenSSL regardless of what was there "in the beginning". This broke some platforms as evidence from the number of atexit cases here. A potentially reasonable solution would have been to undo the change, but that was not deemed acceptable for some reason. As a result, the no-exit build option was introduced to save various platforms that did not behave exactly like gcc/glibc. While atexit is generally acceptable in a standalone project, OpenSSL is embedded in too many other projects and changes to atexit usage has negative impacts.
My opinion is that atexit has no business in OpenSSL given the behavioural variances in the atexit semantics when DLLs are involved. 3.3 or 4.0 should remove atexit completely and leave it up to the using projects instead, as an formal API change instead of what happened. This is just my opinion based on fighting this particular C capability for decades on various platform.

So while it's the right behavior, and the best way for applications to fix it right now, OpenSSL still has something to do here.

I agree, but it seems unlikely that we change the behavior in a stable branch. I have no problem changing it for the next minor release (3.3).

The use of atexit changed at 3.3 with new test introductions and changed existing behaviour of OpenSSL regardless of what was there "in the beginning". This broke some platforms as evidence from the number of atexit cases here. A potentially reasonable solution would have been to undo the change, but that was not deemed acceptable for some reason.

3.3 wasn't released yet. I assume you mean 3.2? 3.3 does have a new option to disable it at build time, that still seems to cause issues in some tests that seem to require atexit to be able to run the test.
As far as I know, nothing was changed regarding to the default use of atexit, it's been like this 1.1.0. Which change are you talking about?
But I think since the providers in 3.0 people run into more problems because of it.

But I think since the providers in 3.0 people run into more problems because of it.

Sounds right. The crash that was reported to us only happens when the legacy provider is enabled.

OTC: Would it be OK to make no-atexit default in 3.3 version?

The use of atexit changed at 3.3 with new test introductions and changed existing behaviour of OpenSSL regardless of what was there "in the beginning". This broke some platforms as evidence from the number of atexit cases here. A potentially reasonable solution would have been to undo the change, but that was not deemed acceptable for some reason.

3.3 wasn't released yet. I assume you mean 3.2? 3.3 does have a new option to disable it at build time, that still seems to cause issues in some tests that seem to require atexit to be able to run the test.
As far as I know, nothing was changed regarding to the default use of atexit, it's been like this 1.1.0. Which change are you talking about?
But I think since the providers in 3.0 people run into more problems because of it.

Actually I do mean 3.3. 3.2 worked broadly as far as I could tell. New tests in 3.3 caused SIGSEGV.

Use a destructor when the compiler supports it; only use atexit when there's no support for destructors and you're building a static library. It's silly not to use a feature that everybody's compiler supports today, and choosing to rely on a nonstandard glibc behavior instead.

Unfortunately it's not a one-line fix since somewhere along the way your build process dropped the distinction in CFLAGS for static libs vs shared libs. Might have happened in 2016 or so, e.g. bbd9a50fa8e371927c290170ab6b8ac2597e5ff9
You go to the trouble of compiling separate object files for shared vs static libraries, but you use the shared_cflags for all of them so there's actually no difference in the objects. This also means you've lost any performance advantage that you would usually get with non-PIC static libraries. Very confusing.

OTC: We will investigate making no-atexit default in 3.4 and use library destructors to call the OPENSSL_cleanup().


TextrudeInteractive can shut down if wrong text entered

Sometimes when typing, TextrudeInteractive can shut down without warning.
This is caused by the user accidentally creating a circular reference in the object graph.  This causes a StackOverflowException in Scriban if the object is then converted to a string.
Fix is pending: see this pull request

New version of Scriban now integrated fixes this in vNext


try to fix #3. Works for commonJS now, EJS not tested and try

Signed-off-by: ROUDET Franck INNOV/IT-S<EMAIL_ADDRESS>

ummm no I won't add CJS support to tinyws. it's a step back to past.
see this: https://blog.sindresorhus.com/get-ready-for-esm-aa53530b3f77?gi=1cf23e9f6390

I think I loose index.d.js

I understand @talentlessguy , but it helps to start adoption to tinyWS, and seems not to hard to do.

You don't want to have a look ?

@franckOL meh, this lib is intended to be used in ESM environments, I don't see a reason to add CJS fallback
it's the same reason I wouldn't want to support IE11 if I was developing a website


Android app bundle crashes of soloader

All of ours Android apps provided with app bundle (.aab) experiencing with much amount of soloader crashes.
Different devices, different OS versions. Can not reproduce it on our testing devices
Switching to separate apps is not an options since starting from August 2021 app bundle is required.
react versions:
"react": "17.0.1", "react-native": "0.64.0",
Environment Info:
System:
    OS: macOS 10.15.5
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
    Memory: 923.96 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.15.1 - /usr/local/bin/node
    Yarn: 1.9.4 - /usr/local/bin/yarn
    npm: 6.14.9 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.3, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
    Android SDK:
      Android NDK: 22.1.7171670
  IDEs:
    Android Studio
    Xcode: 12.3/12C33
  Languages:
    Java: <IP_ADDRESS> - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1
    react-native: 0.64.0 => 0.64.0
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Stacktrace 1:
java.io.IOException at (Unknown Source)
com.facebook.soloader.g.<init> (or com.facebook.soloader.FileLocker.<init>)
java.lang.RuntimeException: Unable to create application chat.roulette.MainApplication: java.lang.RuntimeException: java.io.IOException: Resource deadlock would occur
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6853)
	at android.app.ActivityThread.access$1400(ActivityThread.java:246)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1955)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:236)
	at android.app.ActivityThread.main(ActivityThread.java:7876)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:967)
Caused by: java.lang.RuntimeException: java.io.IOException: Resource deadlock would occur
	at com.facebook.soloader.SoLoader.g(Unknown Source)
	at chat.roulette.MainApplication.onCreate(Unknown Source)
	at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1193)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6848)
	... 8 more
Caused by: java.io.IOException: Resource deadlock would occur
	at sun.nio.ch.FileDispatcherImpl.lock0(Native Method)
	at sun.nio.ch.FileDispatcherImpl.lock(FileDispatcherImpl.java:115)
	at sun.nio.ch.FileChannelImpl.lock(FileChannelImpl.java:1139)
	at java.nio.channels.FileChannel.lock(FileChannel.java:1053)
	at com.facebook.soloader.g.<init>(Unknown Source)
	at com.facebook.soloader.g.c(Unknown Source)
	at com.facebook.soloader.n.b(Unknown Source)
	at com.facebook.soloader.SoLoader.i(Unknown Source)
	at com.facebook.soloader.SoLoader.f(Unknown Source)
	at com.facebook.soloader.SoLoader.e(Unknown Source)
	at com.facebook.soloader.SoLoader.g(Unknown Source)
	... 11 more

Stacktrace 2: (little bit different)
java.lang.RuntimeException: Unable to create application chat.roulette.MainApplication: java.lang.RuntimeException: java.io.IOException: Resource deadlock would occur
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5506)
	at android.app.ActivityThread.-wrap2(ActivityThread.java)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1595)
	at android.os.Handler.dispatchMessage(Handler.java:110)
	at android.os.Looper.loop(Looper.java:203)
	at android.app.ActivityThread.main(ActivityThread.java:6251)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1073)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:934)
Caused by: java.lang.RuntimeException: java.io.IOException: Resource deadlock would occur
	at com.facebook.soloader.SoLoader.g(Unknown Source)
	at chat.roulette.MainApplication.onCreate(Unknown Source)
	at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1024)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5503)
	... 8 more
Caused by: java.io.IOException: Resource deadlock would occur
	at sun.nio.ch.FileDispatcherImpl.lock0(Native Method)
	at sun.nio.ch.FileDispatcherImpl.lock(FileDispatcherImpl.java:99)
	at sun.nio.ch.FileChannelImpl.lock(FileChannelImpl.java:1026)
	at java.nio.channels.FileChannel.lock(FileChannel.java:875)
	at com.facebook.soloader.g.<init>(Unknown Source)
	at com.facebook.soloader.g.c(Unknown Source)
	at com.facebook.soloader.n.b(Unknown Source)
	at com.facebook.soloader.SoLoader.i(Unknown Source)
	at com.facebook.soloader.SoLoader.f(Unknown Source)
	at com.facebook.soloader.SoLoader.e(Unknown Source)
	... 12 more

⚠	Missing Environment Information
ℹ	Your issue may be missing information about your development environment. You can obtain the missing information by running react-native info in a console.

fixed

Hey,
We're cleaning up the React Native issue tracker to make sure we focus on the most important issues first.
I'm closing this one because it's stale and related to a version of React Native we no longer support. If the issue persists on the latest version, please re-open a new issue and reference this one.
Moreover, we generally can't fix issues just by looking at a stacktrace reported from your crash reporting platform. Please provide a reproducer in your future reports.
Thank you.


dev mode command returns: no such file or directory

noise

please share more details, this is not helpful


Create or update geocoder client extension

@ethervoid please review
I made some tests with extensions in local, to figure out how this should work (also thinking on upgrades):
-- get it into starting situation
contrib_regression=# drop extension cdb_geocoder_server ;
DROP EXTENSION
contrib_regression=# create extension cdb_geocoder_server version '0.0.1';
CREATE EXTENSION

-- regular update
contrib_regression=# alter extension cdb_geocoder_server update to '0.0.2';
ALTER EXTENSION
contrib_regression=# alter extension cdb_geocoder_server update to '0.0.2';

--- check it is indeed idempotent
NOTICE:  version "0.0.2" of extension "cdb_geocoder_server" is already installed
ALTER EXTENSION

-- start over again. Check create followed by update does what we want
contrib_regression=# drop extension cdb_geocoder_server ;
DROP EXTENSION
contrib_regression=# create extension cdb_geocoder_server version '0.0.1';
CREATE EXTENSION
contrib_regression=# create extension if not exists cdb_geocoder_server version '0.0.2';
NOTICE:  extension "cdb_geocoder_server" already exists, skipping
CREATE EXTENSION
contrib_regression=# alter extension cdb_geocoder_server update to '0.0.2';
ALTER EXTENSION

-- okay! we're good

but something tricky to take into account for the future:
contrib_regression=# drop extension cdb_geocoder_server;
DROP EXTENSION
contrib_regression=# create extension if not exists cdb_geocoder_server version '0.0.2';
ERROR:  could not stat file "/usr/share/postgresql/9.3/extension/cdb_geocoder_server--0.0.2.sql": No such file or directory

ping

:+1:
El 9/12/2015 15:28, "Rafa de la Torre"<EMAIL_ADDRESS>escribió:

ping
—
Reply to this email directly or view it on GitHub
https://github.com/CartoDB/cartodb/pull/6222#issuecomment-163258095.


File paths not canonicalized so you can open the same file twice

code-server version: 1.868-vsc1.33.1
OS Version: Ubuntu 18.04

Description
It is possible to open the same file twice if one is via /home/me/file.txt and the other is via ~/file.txt (for example).
Steps to Reproduce

Create a file ~/file.txt
Open it from the file explorer.
Open the terminal and type echo /home/you/file.txt
Ctrl-click the path.

You now have the same file open twice.

I was trying to send E-mail to Sparkchain and tab in Firefx crashed .

Also discovered email was not syncing properly , was all turned off so no new mail would load .

No report since 26 days so we'll go over this as fixed.

Ah sorry, I didn't see your first message. I switched to using bind mounts instead, which is a nicer solution to my problem.


Fix create object value getting null strand passing

Purpose

This PR will fix the null strand passing when creating new object values.

Fixes #21018
Approach

N/A

Samples

N/A

Remarks

N/A

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #22913 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22913   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 793ee2e...2d5a37d. Read the comment docs.

@HindujaB , can you also update the section "Approach" on how you fixed this issue?

Codecov Report

Merging #22913 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22913   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b4fcf...38b651d. Read the comment docs.


VS 2017: Loading solution results in crippling object reference error

In VS 2017 Enterprise (26228.0), I see the following error as the dev branch's solution is loading:

All projects seemed to have loaded successfully in Solution Explorer.
The text file referenced in the error message contains the following:
=====================
3/2/2017 9:05:11 PM
Crippling
System.AggregateException: One or more errors occurred. ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.Automation.OAVSReference.get_Version()
   at Microsoft.VisualStudio.ProjectSystem.VS.References.DesignTimeAssemblyResolution.GetAllResolvedReferences()
   at Microsoft.VisualStudio.ProjectSystem.VS.References.DesignTimeAssemblyResolution.ResolveReferences(String[] originalNames, AssemblyName[] assemblyName, VsResolvedAssemblyPath[] assemblyPaths)
   at Microsoft.VisualStudio.ProjectSystem.VS.References.DesignTimeAssemblyResolution.ResolveAssemblyPathInTargetFx(String[] prgAssemblySpecs, UInt32 cAssembliesToResolve, VsResolvedAssemblyPath[] prgResolvedAssemblyPaths, UInt32& pcResolvedAssemblyPaths)
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkUniverse.ResolveAssemblyPath(String assemblySpec)
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkUniverse.ResolveAssembly(AssemblyName assemblyName)
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkUniverse.GetSystemAssembly()
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkUniverse..ctor(IDesignTimeAssemblyLoader assemblyLoader, IVsDesignTimeAssemblyResolution projectAssemblyResolution, IVsSmartOpenScope dispenser)
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkUniverse.GetUniverse(IDesignTimeAssemblyLoader assemblyLoader, IVsDesignTimeAssemblyResolution projectAssemblyResolution, IVsSmartOpenScope dispenser)
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkProvider..ctor(IVsDesignTimeAssemblyResolution assemblyResolution, IDesignTimeAssemblyLoader assemblyLoader, TypeDescriptionProvider parentProvider, IVsSmartOpenScope openScope)
   at Microsoft.VisualStudio.ProjectUtilities.GetTargetFrameworkProvider(IServiceProvider provider, IDesignTimeAssemblyLoader assemblyLoader, IVsHierarchy hierarchy, Object instance)
   at Microsoft.VisualStudio.Design.VSTypeResolutionService.get_TypeProvider()
   at Microsoft.VisualStudio.Design.VSTypeResolutionService.VSLangProj._dispReferencesEvents.ReferenceAdded(Reference r)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.Automation.OAVSReferences.OnReferenceAdded(Reference reference)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.ReferencesHostBridge.ApplyAsync(ReferencesDelta value)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.ProjectHostBridge`3.<>c__DisplayClass36_1.<<InitializeCoreAsync>b__3>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Threading.JoinableTask.<JoinAsync>d__76.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Threading.JoinableTask`1.<JoinAsync>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.ProjectHostBridge`3.<>c__DisplayClass36_0.<<InitializeCoreAsync>b__2>d.MoveNext()
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.Automation.OAVSReference.get_Version()
   at Microsoft.VisualStudio.ProjectSystem.VS.References.DesignTimeAssemblyResolution.GetAllResolvedReferences()
   at Microsoft.VisualStudio.ProjectSystem.VS.References.DesignTimeAssemblyResolution.ResolveReferences(String[] originalNames, AssemblyName[] assemblyName, VsResolvedAssemblyPath[] assemblyPaths)
   at Microsoft.VisualStudio.ProjectSystem.VS.References.DesignTimeAssemblyResolution.ResolveAssemblyPathInTargetFx(String[] prgAssemblySpecs, UInt32 cAssembliesToResolve, VsResolvedAssemblyPath[] prgResolvedAssemblyPaths, UInt32& pcResolvedAssemblyPaths)
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkUniverse.ResolveAssemblyPath(String assemblySpec)
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkUniverse.ResolveAssembly(AssemblyName assemblyName)
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkUniverse.GetSystemAssembly()
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkUniverse..ctor(IDesignTimeAssemblyLoader assemblyLoader, IVsDesignTimeAssemblyResolution projectAssemblyResolution, IVsSmartOpenScope dispenser)
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkUniverse.GetUniverse(IDesignTimeAssemblyLoader assemblyLoader, IVsDesignTimeAssemblyResolution projectAssemblyResolution, IVsSmartOpenScope dispenser)
   at Microsoft.VisualStudio.Shell.Design.VsTargetFrameworkProvider..ctor(IVsDesignTimeAssemblyResolution assemblyResolution, IDesignTimeAssemblyLoader assemblyLoader, TypeDescriptionProvider parentProvider, IVsSmartOpenScope openScope)
   at Microsoft.VisualStudio.ProjectUtilities.GetTargetFrameworkProvider(IServiceProvider provider, IDesignTimeAssemblyLoader assemblyLoader, IVsHierarchy hierarchy, Object instance)
   at Microsoft.VisualStudio.Design.VSTypeResolutionService.get_TypeProvider()
   at Microsoft.VisualStudio.Design.VSTypeResolutionService.VSLangProj._dispReferencesEvents.ReferenceAdded(Reference r)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.Automation.OAVSReferences.OnReferenceAdded(Reference reference)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.ReferencesHostBridge.ApplyAsync(ReferencesDelta value)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.ProjectHostBridge`3.<>c__DisplayClass36_1.<<InitializeCoreAsync>b__3>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Threading.JoinableTask.<JoinAsync>d__76.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Threading.JoinableTask`1.<JoinAsync>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.ProjectHostBridge`3.<>c__DisplayClass36_0.<<InitializeCoreAsync>b__2>d.MoveNext()<---

===================

/cc: @morrisjoe

@srivatsn any ideas on this one?

Yes this is https://github.com/dotnet/roslyn-project-system/issues/1499 that's been fixed post RTM.


Incluindo classe UfType

Testando processo de pull request

Codecov Report

Merging #2 (eb1bf88) into main (d970edf) will decrease coverage by 26.08%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main       #2       +/-   ##
===========================================
- Coverage   97.66%   71.58%   -26.09%
===========================================
  Files           3        4        +1
  Lines         343      468      +125
===========================================
  Hits          335      335
- Misses          8      133      +125

Flag
Coverage Δ

unittests
71.58% <0.00%> (-26.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/UfType.cs
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d970edf...eb1bf88. Read the comment docs.

Ao reduzir a cobertura de teste, o codecov só atualizou seu relatório na mesma caixa de diálogo.

Mesmo passando todos os testes o codecov não recomenda o merge sem passar na covertura de teste


Resolve "Figure Out eth Length"

Closes #151

Right now this doesn't properly handle the case where ethernet ii packets may have ther FCS automatically verified and removed. It also doesn't perform the checksum on the packets. Neither of these cases were handled correctly previously either so this isn't behavior breaking.

Tested locally, working, merged. Thanks!


Modify regex for checking py2 compatibility

Closes #476 and #591
Add support for compatible release version specifier '~=' and version matching clause '=='.
I was happy to see that someone picked up this issue in #586 , but it seems like the conversation stalled a bit, so here I am. It's something that was bothering me for a while now and it would be nice to see it fixed 😄

Thanks, this looks good. :slightly_smiling_face:


add / kill nodes, check atxs's active set and subsequently #eligible blocks

Overview / Motivation
add / kill nodes, check atxs's active set and subsequently #eligible blocks
The Task
interesting test scenarios:

[ ] boot 300 nodes in epoch 1, make sure they create an ATX, at start of epoch 2 kill 100 nodes. make sure less blocks than needed created
[ ] boot 200 nodes in epoch 1, boot extra 100 nodes in epoch 2, make sure each node of the 300 has created block in epoch 3, and that number of blocks hasn't exceeded the required number of blocks per layer  / epoch
[ ] other scenarios?

Implementation Notes
TODO: Add links to relevant resources, specs, related issues, etc...
Contribution Guidelines
Important: Issue assignment to developers will be by the order of their application and proficiency level according to the tasks complexity. We will not assign tasks to developers who haven't introduced themselves on our Gitter dev channel

Introduce yourself on go-spacemesh dev chat channel - ask our team any question you may have about this task
Fork branch develop to your own repo and work in your repo
You must document all methods, enums and types with godoc comments
You must write go unit tests for all types and methods when submitting a component, and integration tests if you submit a feature
When ready for code review, submit a PR from your repo back to branch develop
Attach relevant issue to PR

this issue is addressed here https://github.com/spacemeshos/go-spacemesh/issues/1754


Introduce sandbox browsing and OAuth2

MesosTerm frontend has been rewritten in React in order to simplify the introduction of sandbox browsing.

It will be hard to review 180 files :)

I rewrote the entire frontend, updated the scripts to smooth the development workflow with hot reload, modified integration tests and added new ones and only changed a few things in the backend which is the most critical part so I'm confident that the behavior of the backend has not changed.

I think we should push that PR (once test pass) directly then


ci: vmtest workflow fails at post-test job

What happened?
From time to time the vmtest ci workflow fails at the post-test job https://github.com/cilium/tetragon/blob/main/.github/workflows/vmtests.yml#L151
Logs:
Run actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392
  with:
    name: tetragon-build
    path: /tmp/tetragon.tar
    retention-days: 1
    if-no-files-found: warn
    compression-level: 6
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

Tetragon Version
upstream
Kernel Version
none
Kubernetes Version
No response
Bugtool
No response
Relevant log output
No response
Anything else?
No response

Resolved by https://github.com/cilium/tetragon/pull/1925


无法安装azure-storage

(base) he_muling@MacBook-Pro EX-chatGPT % pip install -r requirements.txt
Collecting azure_storage==0.37.0
  Using cached azure-storage-0.37.0.zip (4.3 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [20 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/private/var/folders/4z/kspnn2f503550_nfygz4qbr00000gn/T/pip-install-c52stlm7/azure-storage_b80c1df728eb408b8e92646cdd6a0b69/setup.py", line 55, in <module>
          raise RuntimeError(message)
      RuntimeError:

      Starting with v0.37.0, the 'azure-storage' meta-package is deprecated and cannot be installed anymore.
      Please install the service specific packages prefixed by `azure` needed for your application.

      The complete list of available packages can be found at:
      https://aka.ms/azsdk/python/all

      Here's a non-exhaustive list of common packages:

      - [azure-storage-blob](https://pypi.org/project/azure-storage-blob) : Blob storage client
      - [azure-storage-file-share](https://pypi.org/project/azure-storage-file-share) : Storage file share client
      - [azure-storage-file-datalake](https://pypi.org/project/azure-storage-file-datalake) : ADLS Gen2 client
      - [azure-storage-queue](https://pypi.org/project/azure-storage-queue): Queue storage client

      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

好像是azure-storage被拆分成了很多个模块azure-storage-file-share，azure-storage-blob，azure-storage-file-datalake，azure-storage-queue，azure-storage被移除了。


ability to remove favorites from favorites page

Go to Favorites.tsx
add a button to remove favorited pets in the favorites page and updates the state. Check out FavoriteSection.tsx as an example

Hi! Can I be assigned to this! This would be my first open source contribution and I love that it’s helping people find pets! :)

Sure :)
if you need help u can go on discord also updated the issue to help u out

just joined discord! pumped to be able to help here :D

Thanks! Just joined the discord. Pumped to be able to help :D

Thanks! Just joined the discord. Pumped to be able to help :D

just wondering if ur still working on this?

hi! yes, I am. I was out last week and then on a work trip the week before that but I am definitely going to do it. I think I will be able to get it done this weekend! Sorry for the delay and for not keeping you updated. I will get this done.

hi! yes, I am. I was out last week and then on a work trip the week before that but I am definitely going to do it. I think I will be able to get it done this weekend! Sorry for the delay and for not keeping you updated. I will get this done.

hi! yes, I am. I was out last week and then on a work trip the week before that but I am definitely going to do it. I think I will be able to get it done this weekend! Sorry for the delay and for not keeping you updated. I will get this done.

Alright thanks for the update. No rush

no prob. thank you for the opportunity to help. Looking forward to helping more and more with this!


[Dark] Block Reference style

Block references background color doesn't blend well with the theme

@Bad3r

it looks fine to me on Mac 🤔. I think the block ref background may not need to be that outstanding though, but I am not an expert on coloring & theming. Do you have a suggestion about how to make it blend in a better way?

I think it's very outstanding. I find it somewhat distracting when it's in the middle of a text block, specially when compared to a page link, e.g. [[logseq]]

Also, there seems to be an extra space at the end of a block ref.
A possible solution is to remove the background color completely and change the text color similar to how page links are handled, or use the default logseq style and modify the underline color to #313942 (left sidebar color) or #92b8d7 (page link color).
I am also not sure about the # symbol in the start. I think the logseq default theme handles this better with just adding an underline with a different color.

@Bad3r oh, I get what you mean. The block reference style was made like this was because this theme was originally forked from https://github.com/PiotrSss/logseq-clean-themes, including the # sign and background. I have not thought about the issue back then, but now I believe you are right: having the two may disrupt the reading experience.
IMO the way you suggested that using different colors may not apply well to distinguish between block/page references. Alternatively, I propose to use dotted underlines for block references, and leave what it is for block ref, like this:

What do you think?

That's a great solution! I like the look of the dotted line more.
I am not sure about using this color for the dotted line. Maybe consider using the same color used for page links but for the dotted line or a different shade of blue (example: #a3cef1)

I am releasing a new version based on our discussion here.

Awesome! Thank you! 🚀


Try this:
rm -rf node_modules package-lock.json
npm install

If the issues still persist, re-check your NodeJS version nor re-install it with the compatible one.

I have followed your instructions to reinstall, but it still has a similar error. I'm curious which version of NodeJs is compatible with this script. because currently on my computer my node v20.9.0 is installed

I have followed your instructions to reinstall, but it still has a similar error. I'm curious which version of NodeJs is compatible with this script. because currently on my computer my node v20.9.0 is installed

Hmmm.. interesting, since it works on other users. Anyway, I use v20.7.0.

ok, I'll try to downgrade it later, but I can already run it on gitlab. If I have downgraded it later, can I give feedback again?

ok, I'll try to downgrade it later, but I can already run it on gitlab. If I have downgraded it later, can I give feedback again?

Sure, let me know! :)


servePureLocally is not documented

By default the site uses Pure from http://yui.yahooapis.com/pure, and the only way to force it to use local Pure is to turn on the servePureLocally setting. However, this setting is not documented anywhere.

I understand why you might have missed this, but it is documented:
https://github.com/yahoo/pure-site#running-with-pure-served-locally


Pulsar Functions documentation

Talked with @merlimat offline, let's merge this one. so the docs will go out, then we start have changes interating and improve it.


[CI] Runs build in macos to generate a cache for androidTest runs

Experiments to fix #1011 and #1018
Relying on gradle-build-action for cache sharing. Followed some guidance in:
https://github.com/gradle/gradle-build-action#deduplication-of-gradle-user-home-cache-entries

So far it seems like the linux job takes 9-11 minutes (with cache hits), and will fails screenshot tests first, then jvm tests, spotless. Then it builds and uploads APKs. We probably want to fail spotless first.
If the build is broken, it can be caught by either the linux job or the androidTest-build job, whichever finds it first because they run in parallel.

Looking at the low-hanging fruit for the androidTest-run job:

Runners wait for the emulator to boot for 100 seconds.

After that, the connectedCheck task is run and then gradle takes a while to assemble everything.
This seems like it could be done in parallel? Not sure how much CPU the emulator boot takes.

Caching the emulator image
https://github.com/ReactiveCircus/android-emulator-runner/issues/229

This looks good but wouldn't it take most of the 10Gb cache?

Configuration cache is disabled. See #1022

The reactivecircus action seems to be downloading and installing a lot of stuff that should already be present in macos-latest. https://github.com/ReactiveCircus/android-emulator-runner/issues/265

For example, the command [command]/bin/sh	-c	\sdkmanager	--install	system-images;android-26;default;x86_64'	--channel=0	>	/dev/null
takes 53 seconds to run.

On 2: I'm running a test in https://github.com/JoseAlcerreca/nowinandroid/actions/runs/6788492716/job/18453744948 to see how much cache it takes. After this run, I'll try with an ATD image.

On 2: I'm running a test in https://github.com/JoseAlcerreca/nowinandroid/actions/runs/6788492716/job/18453744948 to see how much cache it takes. After this run, I'll try with an ATD image.

avd-26 Cache Size: ~4551 MB<PHONE_NUMBER> B)
avd-30 Cache Size: ~3835 MB<PHONE_NUMBER> B)
We'd probably run out of cache for other things that might impact CI times more.

This looks good but wouldn't it take most of the 10Gb cache?

Should we consider a separate job that runs, produces the AVD snapshot, then upload as build artifacts?
It might be worthwhile having another form of cache for this?

Should we consider a separate job that runs, produces the AVD snapshot, then upload as build artifacts instead of cache?

I don't think there's an API to download the build artifacts from another workflow, is there?
From a quick search:
"Downloading files: You can only download artifacts that were uploaded during the same workflow run. When you download a file, you can reference it by name."

I think we can start reviewing this PR:
(1) Moved some of the build to a previous step so that gradle has a bit more resources to run. Probably irrelevant.
(2) Can't do this because of the size of the AVD images
(3) Pinged the authors of the plugin and will look into it separately. We'll probably skip the problematic tasks on CI.
(4) Filed https://github.com/android/nowinandroid/issues/1026 for tracking

"Configuration cache entry stored."
Now the next run should be faster.

Took 21 minutes in API 26 and 30 in API 30 without configuration cache. Triggering another build now.


ignore undefined path params

Optional path params can be omitted or passed as undefined. In the former case the param segment is dropped from the output but in the latter it is not, resulting in an empty path segment (//) which remix does not accept.
This behaviour is unexpected IMO and requires funky handling to avoid defining the param key when you want to use a possibly-undefined variable for the value, eg:
$path('/:lang?/about'), { ...(language ? { lang: language } : undefined) })

Demo
Example input
$path('/:lang?/about', {})
$path('/:lang?/about', { lang: undefined })

Output before this change
/about
//about

Output after this change
/about
/about

Thank you!


Feature/profile tooltips

Overview
Adds tooltips when hovering over the various profiles in the Editor Inspector for the MixedRealityToolkit prefab.
Changes
Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.
If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.
As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

/azp run

/azp run


Use DIR to resolve path of file

Hopefully solving #18

Thanks @hstruebe, the GitHub actions is still under debugging, so it shows API test failed, it's nothing to do with your code change, will merge it :)


Provide Helper Functions for Encoding/Decoding Input/Output

Currently it's very verbose to convert raw binary to JSON. It must be decoded to a string first (unless there is a way to go directly to JSON)
example code:
JSON.parse((new TextDecoder).decode(vowelsCounted))

Addressed in #21!

Fixed by #21!


Printable version of Default Keyboard Shortcut shows 2019

Minor detail: the printable version of the Default Keyboard Shortcut has "Visual Studio 2019" in its header instead of just Visual Studio as shown in the preview.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 23332067-130b-a343-b902-7d09680d3519
Version Independent ID: 09bb5d36-f067-5422-2ab2-e4c7a8f1d6ed
Content: Keyboard shortcuts - Visual Studio (Windows)
Content Source: docs/ide/default-keyboard-shortcuts-in-visual-studio.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@TheEnjiBenji A fix is in process. We'll close this now, as it's been previously reported (see https://github.com/MicrosoftDocs/visualstudio-docs/issues/9116) but we thank you for taking the time to let us know.


Let 889 fe implement the open call public page

This PR adds the open call public page
Description
As a project developer visiting HeCo, I need to see the details of open calls, so that I can decide if they match my interests, improving my chances to find funding
Acceptance criteria
Open calls will be visible to visitors if they are:

Launched
Closed

Open calls are hidden to visitors if they are:
Drafts (the account’s users can still preview them, see LET-667: Investors can preview the public open call page before publishing (Draft)IN PROGRESS)
Applying to open calls is part of LET-447: Signed-in Project developers can apply to open callsTO DO therefore not to be tackled in this user story
Figma: HeCo - Work in progress
Testing instructions
Go to any open call page
/open-call/investor-test-4-eat-from-dog-s-food-i-can-haz-chase-red-laser-dot
Important!
the 'favorite' and 'apply for open call' actions are not implemented, so the buttons and correspondent sections are hidden  (commented)
Tracking
LET-889

The ability to favourite the open call is part of the user story. You can either implement it in another PR or this one but it will be blocking the user story nonetheless.

The endpoints to favorite/unfavourite  the open calls are not available, so I think it will be better to create a new task for that


Use 'dotnet workload restore' to restore workloads in the PR CI builds

refs #380 and the build failure in #381

If it's not one thing it's another :-(
ILLINK : error MT0180: This version of Microsoft.iOS requires the iOS 17.0 SDK (shipped with Xcode 15.0).

Is there a reason why the PR builds do xcode-select -s /Applications/Xcode_14.3.app/Contents/Developer/ and the 'publish' builds don't?

Is there a reason why the PR builds do xcode-select -s /Applications/Xcode_14.3.app/Contents/Developer/ and the 'publish' builds don't?

Hah, good question. I can't recall.


initial stub for PR on creating new adapters

[ ] Finish Documentation
[ ] Link to Bunny Adapter (hubot-bunny) when completed

@technicalpickles
I created a first draft of the documentation for creating new adapters.  Would :heart: a second set of :eyes:

One thing I would suggest is, in the intro, talk about an example adapter (ie bunny), and then use that consistently throughout the doc. You use bunny in one place, and xxxx in another, specifically.

One other thing: I'm wondering if the creating-a-new-adapter can go in the adapters directory.

@technicalpickles are we good to merge?

@leefaus I think the only other feedback I had was changing the example from hubot-bunny, like to hubot-example-adapter. Two reasons I can think of: so people don't have to ask what hubot-bunny is, and to avoid someone copying and pasting as is, and trying to release it when you already have a hubot-bunny adapter.

Thanks for putting this together :sparkles:


Rename labels mixin's label method

Was causing conflicts with Bootstrap.

I changed it on hybrid app, but I moved and renamed it to here, because I didn't like the name anymore either.


[Basics/React]: Is note on Aleph using Preact correct?

Note: Fresh and Aleph.js provide a framework for developing React-like websites, but use an alternative foundational technology, Preact to provide a better, more performant experience.

<EMAIL_ADDRESS>I don't believe this is correct, given that the very first issue in Aleph's tracker is requesting Preact support?

Yeah, looks like they don't support preact for now
https://alephjs.org/docs/framework/react


Update info in README about out-of-the box support in Vim

The README currently says:

Vim:

via ale - will support Marksman out-of-the-box once PR is merged; in the meantime...
Example config (add the following to your ~/.vim/after/ftplugin/markdown.vim):
if exists('g:loaded_ale')
  call ale#linter#Define('markdown', { 'name': 'marksman', 'lsp': 'stdio', 'executable': 'marksman', 'command': '%e server', 'initialization_options': {} })
end

Since the mentioned PR https://github.com/dense-analysis/ale/pull/4565 has been merged, shouldn't this section of the README be updated?

Thanks for raising this @waldyrious! I'd be happy to accept README fixes in a PR :)

I'd be happy to submit a PR, but as I'm not a Vim user, I'm not really sure what it should say instead :sweat_smile: — any hints?

@waldyrious ack! Perhaps this is for the future then. I'll close the issue for now.

Meybe the README could still be changed from "once PR 4565 is merged" to "once the changes from PR 4565 are released", or something like that. Otherwise, it seems confusing since the PR is already merged. WDYT? I can submit a PR with that change if you agree.


Validate main branch working

Creating PR to validate #200 is the same as this one.
Validates issue #198

UPDATE: Looks same to me

Yes, it's working. Bye-bye master 👋


[stable-4.4][Hub-4.4.0dev] Modal header 'Permanently delete container', need to be marked as translatable string

Issue: AAH-1198
Backport of #1653 was done from scratch, because there was refactoring and it was easier to change several lines manualy. No
cherrypick was used.

@MilanPospisil you missed a step in the instructions .. the last thing in the PR title for backports should be the original PR#
Without that, #1653 won't be marked as backported by this. Adding manually.


testkube-operator: Removed ns from tokenSecret and usernameSecret

Pull request description
Pods can't use secrets from a different namespace as env vars as explained in issue #4308. This PR removes the namespace key from the CRD.
I am in doubt whether or not this is all that is required to remove it, so thoughts are welcomed about this.
Checklist (choose whats happened)

[ ] breaking change! (describe)
[x] tested locally
[x] tested on cluster
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

Breaking changes

Changes
Removed namespace from tokenSecret and usernameSecret from tests.testkube.io_tests.yaml CRD
Fixes

@vsukhin I'm not sure how the CRD docs get regenerated, but could you please do so?  It's been a confusing few hours wondering why we are now failing schema validation on all Test deployments :-/
https://docs.testkube.io/articles/crds-reference/#secretref
Thank you!

yes, sounds like it's not automated, we need to fix it with @ypoplavs


Added script for etcd migration.

What this PR does / why we need it:
The script added in this PR helps to migrate etcd in hibernated clusters.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

From the PR I cannot find the answer of the following questions:

Who needs this script?
How is it supposed to be used?
Why there is no documentation/motivation about it?


Build Promotion fails on JFrog Platform

Describe the bug
The Azure Integration Task "Artifactory Publish Build Info" seem to use wrong pathes for the JFrog Platform.

The task  uploads successfully but JFrog Platform does not find the file location in repositiory afterwards - even though the artifacts can be manually found in the target repo location.

As a result the artifacts cannot be promoted to the next stage. The files are not found.
The same pipeline and its tasks worked fine with Artifactory 6.x but fails on JFrog platform.
To Reproduce

use generic upload task and check "collect build info"
use publish build info task
use JFrog PLatform cloud instance
check build info in Jfrog platform as shown by screenshots above

Expected behavior
The file path is given in build info of jfrog platform and the build promotion works.

Versions

Artifactory Generic Upload task version 2.10.2
Artifactory Publish Build Info 1.10.2
JFrog CLI version: 1.38.4
[AGENT_OS] --> [Windows_NT]
[AGENT_OSARCHITECTURE] --> [X64]

Probably not a bug, but incorrect usage on our part ... I'm currently reviewing this and will report here

Suddenly the issue disappeared. But we also disabled the "Discard Build Tasks" in Azure a few days ago. This could be a cause. We are investigating this further.

@HgDorn,
Was this issue resolved for you?

The issue did not appear again. So i will close it.


[Removal]: Request Removal from Denylist

Hotspot Name
Early Banana Pigeon
Hotspot b58 Address
11frqsgjajQQkgcaGn9BQmwB725wzxNocQGT1ZvRwjQYT33mxgZ
Discord Handle
No response
Hotspot Manufacturer
Heltec Automation
Removal Reason
My hot spot is on the denylist. Now they have been adjusted, corrected previous mistakes, and redeployed on the spot. Hope to be removed from the denylist. Thank you very much!
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


layers/meta-balena: Update to v2.107.45

Update meta-balena from 2.107.43 to 2.107.45
Changelog-entry: Update meta-balena from v2.107.43 to v2.107.45

@resin-jenkins retest this please

@resin-jenkins retest this please

@resin-jenkins retest this please

@resin-jenkins test this please

@resin-jenkins test this please

@resin-jenkins test this please

@resin-jenkins retest this please

@resin-jenkins test this please

must include fixes from https://github.com/balena-os/meta-balena/pull/3056 to pass

Deprecated by https://github.com/balena-os/balena-raspberrypi/pull/1006


Context Specific Error when publishing examples in docker registry

As refered in this PR #2018
https://github.com/kubeflow/training-operator/pull/2018#issuecomment-1986545785

/assign


Standardized output for F*

The F* compiler should have a standardized output for helping IDE parsing its result.

Do you have a particular standard in mind, or just that all errors should look the same?
This is also related to #78. There I devised a couple of regexps for parsing the current format, see:
https://github.com/FStarLang/FStar/blob/master/README.md#emacs

I don't have any specific standard in mind, any standard will fit my needs. I can try to hack one - I know a couple of them.

Thanks for mentioning to the regexps that you've written. I'm working on a vim plugin and those will be really helpful.

All errors are now formatted in a uniform style


ISV CRS, CRD and on prem apps 4907

This PR contains the CRDS and CRs for odh dashboard.  Applications that are only needed for on prem are located in the app-on-prem folder.  Final step to be added is the to only deploy the on prem apps for on prem clusters.
ODH Dashboard PR related to this can be found here: https://github.com/opendatahub-io/odh-dashboard/pull/243
Other needed PRs to fix issues found during testing:
https://github.com/red-hat-data-services/odh-manifests/pull/243/
https://github.com/opendatahub-io/odh-dashboard/pull/615/

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
[x] JIRA link(s):  1797, 4907, 4032
[x] The Jira story is acked.
[x] Live build image:  quay.io/modh/rhods-operator-live-catalog:1.18.0-rhods-5329
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work.
[ ] QE contact acknowledges that this has been tested and is approved for merge.

Is there a specific reason we have these manifests going into deployer instead of into odh-manifests?

There are some fields in the ODHApplication CRs that will be modified by odh-dashboard that we need to ignore when reconciled

This change also requires updating roles fo rhods-operator Service Account, since we are accessing new apis like console.openshift.io, dashboard.opendatahub.io etc.
Deployer Log - log.pdf
We would also need to update uninstall logic in operator to make sure new CRDs get cleaned up.  @LaVLaS  I wonder if that can be avoided if the CRDs are deployed through odh-manifests ?

Is there a specific reason we have these manifests going into deployer instead of into odh-manifests?

There are some fields in the ODHApplication CRs that will be modified by odh-dashboard that we need to ignore when reconciled

@LaVLaS  Following up on this, as discussed removing fields from the CR allows modifying them, given that they are not required fields. I tested with spec.internalRoute field
apiVersion: dashboard.opendatahub.io/v1
kind: OdhApplication
metadata:
  annotations:
    kfctl.kubeflow.io/kfdef-instance: rhods-dashboard.redhat-ods-applications
    kubectl.kubernetes.io/last-applied-configuration: >
  name: jupyter
  namespace: redhat-ods-applications
  labels:
    app: rhods-dashboard
    app.kubernetes.io/part-of: rhods-dashboard
spec:
  img: >- <>
  getStartedLink: 'https://jupyterlab.readthedocs.io/en/stable/getting_started/overview.html'
  internalRoute: testValue
  displayName: Jupyter
  kfdefApplications:
    - odh-notebook-controller
    - notebook-images
  support: red hat
  provider: Jupyter
  docsLink: 'https://jupyter.org'
  quickStart: create-jupyter-notebook

The kfdef annotation is added, and the field retains the user specified value.

@dlabaj should RHODS/ODH operator reconcile the CRs which are installed with it, if any of them get deleted?

@dlabaj there could be an issue with yaml formatting for some items like OpenVINO:
from live build:

expected:

@dlabaj should RHODS/ODH operator reconcile the CRs which are installed with it, if any of them get deleted?

The operator won't reconcile them if they get deleted.

@dlabaj there could be an issue with yaml formatting for some items like OpenVINO: from live build:
expected:

I'll look into the formatting issue.

@dlabaj If percept-labs is being removed, you'll need to delete that folder and the reference to it in the apps-on-prem kustomization.yaml file

@dlabaj should RHODS/ODH operator reconcile the CRs which are installed with it, if any of them get deleted?

The operator won't reconcile them if they get deleted.

should the operator being self-healing? if yes, IMO these resources should be restored too.

tested the new live build: http://quay.io/llasmith/rhods-operator-live-catalog:1.18.0-1

RHOSAK and Jupyter are missing the Official blue mark in Explore page

code to check if RHODS is self-managed or Managed may not work on OSD/ROSA. I've run the piece of code on local and it looks like not recognizing the Managed installation. Works fine on self-managed installations

@bdattoma I updated this PR and updated this code to fix the issues you found
https://github.com/opendatahub-io/odh-dashboard/pull/615

text style is changed here wrt to v1.17.0-9 @dlabaj :
On the left you see the text for Resources item in v1.17.0-9, while on the right you see v1.18.0-3 (titles and other text labels look bold)

text style is changed here wrt to v1.17.0-9 @dlabaj :
On the left you see the text for Resources item in v1.17.0-9, while on the right you see v1.18.0-3 (titles and other text labels look bold)

We upgraded patternfly this is the new look.

Follow up issues for 1.19:
Refactor code to have CRDs in the manifest repo - https://github.com/red-hat-data-services/odh-deployer/issues/267
Dashboard update to not use embedded issues - https://github.com/opendatahub-io/odh-dashboard/issues/646

/approve


pytest (Why test.py file?)

You can run pytest directly instead of running test.py.
Why did you choose this solution?

@danieldaeschle

Backward compatibility
This way I can swap testing libraries/strategies without the need to update CI builds and keep everyone on the same page.


Outdated version of Gradle

I have installed Android Studio, and installed everything it asked me to install, and the project has done its "Gradle sync", and now Android Studio says:

To take advantage of the latest features, improvements, and security fixes, we strongly recommend that you upgrade the Android Gradle Plugin in this project (rosettadrone_mini2) from the current version 3.6.4 to version 7.0.4.

Should Gradle Plugin be updated or not?

Whatever really.

Will consider it when i update stuff


Add nominee: Safe YOU

Automatic addition of a new nominee submitted through the online form available at https://digitalpublicgoods.net/submission

@nathanbaleeta: This looks good to me on the nomination front. Bear in mind that the nomination-only part of this PR cannot be merged by itself without merging the full submission. This begs the question whether we want to modify the submission form to open two different pull requests, to better match our workflows.

@nathanbaleeta: This looks good to me on the nomination front. Bear in mind that the nomination-only part of this PR cannot be merged by itself without merging the full submission. This begs the question whether we want to modify the submission form to open two different pull requests, to better match our workflows.

@lacabra I guess everything is pointing to that, in order to streamline our workflow, we may update our codebase to open two pull requests accordingly.

@nathanbaleeta Split this PR in two. Leaving the nomination here so that this can be merged, and moving the full submission to #560


At home testing request

FDA allowed at home sample collection and testing in usa and now it have also started in india, can be an important feature to have?
https://www.fda.gov/news-events/press-announcements/coronavirus-covid-19-update-fda-authorizes-first-standalone-home-sample-collection-kit-can-be-used
https://www.fda.gov/news-events/press-announcements/coronavirus-covid-19-update-fda-takes-steps-streamline-development-tests-home-sample-collection
"COVID-19 Test Home Sample Collection Booking Form (Bangalore city limits only)
RT-PCR Tests home sample collection service of nasal/throat swab offered by Shree Polyclinic & Lab (Dr Chitra) in collaboration with Apollo Hospitals, Bannerghatta Road. Available in Bangalore City limits only." ref-
https://docs.google.com/forms/d/e/1FAIpQLSeC3YRilv6BUKb-9kjjhkaVNZRh5aZ0pWtVAwCV67U-tSyKfg/viewform?vc=0&c=0&w=1

Home testing is part of our use case as can be seen in the diagram on covn.org. The quarantine officer can order testing at home (if available) or at a lab based on evolving symptoms that are submitted by the patient once or twice a day.

Thanks, that's great!


Binary encoding tests

This is a very helpful repository! It would be great to have a similar test suite for the binary format.

There should be a few binary ".10n" test files included here and there, but you're correct, we definitely don't have complete test data parity between the two formats (not that that always makes sense, for example, there's no notion of underscore separators in numeric literals in the binary format, obviously)


GSE128531 - Single-Cell Lymphocyte Heterogeneity in Advanced Cutaneous T-cell Lymphoma Skin Tumors

Project short name:
TCellLymphomaHeterogeneity ?
Primary Wrangler:
Ami
Secondary Wrangler:
Ida

Associated files

Google Drive:

https://docs.google.com/spreadsheets/d/1P4KTCaJg-YtF7GY-rRaPqKR658AnTerW7a1yAuF0xmk/edit#gid=1636914881
Published study links

Paper: Single-Cell Lymphocyte Heterogeneity in Advanced Cutaneous T-cell Lymphoma Skin Tumors

Accessioned data: GSE128531

ingest: project

Key Events

[x] Convert published metadata to HCA spreadsheet
[x] Manually curate dataset to meet HCA metadata standard
[x] Collect any matrix and cell-type annotation files
[x] Upload sheet to validate metadata
[x] Check linking using ingest graph validator
[x] Transfer raw files to ingest to validate data files
[ ] Ask the Secondary Wrangler for an end-to-end review of the project. Ask the Expertise Wrangler to review specific tabs if needed
[ ] Submit dataset to Production
[ ] Complete the Export SOP
[ ] Convert project data to SCEA format following the SCEA conversion SOP if appropriate

Hi ami, I'm done with the review! It looks great I only have a few comments.
Project

the project label is missing
you should add yourself as a curator!

Library

you can add PCR in the cDNA amplification

Analysis protocol

please remove the | from computational methods, it's not allowed

Analysis file

add file source
the content description should be count matrix

Submitted import form as it successfully exported.

Looks good.


[Map Pack] Ctfmaps

For some reason, CTF map packs appears twice for Unreal - with the same one mappack.

URL: https://unrealarchive.org/mappacks/unreal/capture-the-flag/C/ctfmaps_08535464.html
Hash: 08535464cd707e08bd3099f45d052b5da9d8933b
Current name: Ctfmaps

There's one Ctfmaps for Unreal, and it seems to be an Unreal version of the DE Bonus Pack. Nevertheless I've fixed it.


Set up Jest test runner

Jest is FB's JS testing library which we're using for testing our React app. We might need to add Enzyme or something like that later too, but I'll figure that out later.
This PR also includes tests for Utils.js, because running jest with 0 tests makes it sad.

Assigning the review to Cyrus.


Extracted common fix logic into functions

I noticed that many fix functions share a lot of code, so I extracted the shared logic into two functions: fixReplaceNode and fixReplaceQuant.
The new functions could also be used in match-any but I haven't used them there yet to avoid conflicts with #103. I will add this after #103.

It's good, thank you!


[2.0] _cleanUpTempFiles() changes.

Simplify _cleanUpTempFiles() and suppress any errors. Call _cleanUpTempFiles
in all places a promise rejection can happen. A few comment corrections.

Thanks @bsdkurt. Good call on suppressing the temp file errors - people don't need to see those. I appreciate all of your help.


Add option to scripts/server to run in debug mode

Overview
Adds a --debug flag to scripts/server to run the backend in debug mode, with the standard 9229 Node.js debugging port exposed through Docker to the host.
Notes
I used VS Code's built-in debugger with the following configuration, but I believe other tools compatible w/ the Node inspector like the Chrome dev tools should also work:
{
  // Use IntelliSense to learn about possible attributes.
  // Hover to view descriptions of existing attributes.
  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
  "version": "0.2.0",
  "configurations": [
    {
      "type": "node",
      "request": "attach",
      "name": "Attach to Node",
      "localRoot": "${workspaceFolder}/src",
      "remoteRoot": "/home/node/app",
      "port": 9229
    }
  ]
}

Testing Instructions

scripts/server --debug
Attach a debugger to the backend
Ensure you can set a breakpoint in backend code

@pcaisse Kevin ran into some issues w/ setting this up, do you think you could give it a go?


Getting value of type 'String' has no member 'components'

Try to build with Swiftwasm in wasm-DEVELOPMENT-SNAPSHOT-2020-04-07-a.
Getting following error
.build/checkouts/Runtime/Sources/Runtime/Metadata/TupleMetadata.swift:33:68: error: value of type 'String' has no member 'components'         var labels = String(cString: pointer.pointee.labelsString).components(separatedBy: " ")

Hey @noontideox, thank you for trying it out! Tokamak support for WASI is still work in progress, I'm mainly testing it in Xcode, compiling it directly for macOS and running ReconcilerTests.
The compilation error you've stumbled upon is a remnant of wickwirew/Runtime#67. It should be easily fixed upstream in Runtime by something like this:
#if !canImport(Foundation)
extension String {
  func components(separatedBy: String) -> [String] {
    // actual implementation here
  }
}
#endif

I just haven't got to it yet, as I'm also worried that this Runtime module doesn't have good support for absolute pointers described in swiftwasm/swift#20. To verify that, I'd like to run the test suite from Runtime on WASI first, which is currently blocked by swiftwasm/swift#597. I'm getting there slowly, I hope to get Foundation and XCTest more or less working in the next few days if all goes well. With working XCTest we could check that Runtime works well on WASI, or what exactly is broken otherwise.

This is now resolved in the main branch.


[BUG] currency symbol not displayed when run from docker container

related to https://github.com/hargata/lubelog/issues/1#issuecomment-1879772509 and #3
I guess it is intended to show the $ Dollar sign.

The issue is browser independent. (tested FF, Chrome, Chromium)
My guess is that code files are saved in another encoding compared to the runtime inside the container. So maybe we have to set a locale or character set as environment or runtime configuration, or maybe convert file from windows default encoding to utf8 or whatever before checking into git?!
System:
$ lsb_release -a
No LSB modules are available.
Distributor ID: Linuxmint
Description:    Linux Mint 21
Release:        21
Codename:       vanessa

$ docker version
Client: Docker Engine - Community
 Version:           24.0.7
 API version:       1.43
 Go version:        go1.20.10
 Git commit:        afdd53b
 Built:             Thu Oct 26 09:07:41 2023
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          24.0.7
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.10
  Git commit:       311b9ff
  Built:            Thu Oct 26 09:07:41 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.26
  GitCommit:        3dd1e886e55dd695541fdcd67420c2888645a495
 runc:
  Version:          1.1.10
  GitCommit:        v1.1.10-0-g18a0cb0
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
``

I think it's due to env variable for culture, I updated the Dockerfile and it seemed to work, can you try again?

confirmed. $ sign is displayed now.
commit 05f8907 fixed it.

issue fixed.

issue fixed.

I've just installed Lubelogger using Docker on my Synology NAS and I'm having this issue as well. I pulled the latest image from the Docker registry but still showing up like the original author's picture.

@Battmain read the troubleshooting guide:
https://docs.lubelogger.com/Installation/Troubleshooting

@Battmain read the troubleshooting guide:
https://docs.lubelogger.com/Installation/Troubleshooting

Thanks. Got it figured out. I'm fairly new to all this so I'm still learning. I appreciate the help.


Alpine repo

Please consider to add a repo for the Alpine packages as well. Like for all the other supported Linux distributions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0fc3da20-7ab2-d20f-4d29-4664d3183b57
Version Independent ID: 986d25d9-5d2e-5154-39ea-3b683faf2264
Content: Install the Microsoft ODBC driver for SQL Server (Linux) - SQL Server
Content Source: docs/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server.md
Product: sql
Technology: connectivity
GitHub Login: @David-Engel
Microsoft Alias: v-daenge

@tuxpeople -- Thomas, thank you for your suggestion.  Please add it here:

SQL Server Feedback

cc @David-Engel for awareness
I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


documentation: where to find list of all cli commands?

Hi team,
I wanted to start to play around with the client and realiszed that there is no documentation for it. Using -h just shows me:
cli 0.1.0

USAGE:
    tezedge-client <SUBCOMMAND>

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

SUBCOMMANDS:
    address
    delegate                 Delegate balance to baker
    help                     Prints this message or the help of the given subcommand(s)
    transfer                 Create a transaction
    unsafe-delegate-local    Delegate balance to baker using local wallet
    unsafe-transfer-local    Create a transaction using local wallet

The readme e.g. alread mentions the --endpoint command which is not part of the section above. I am missing commands known from the tezos-client like e.g. "bootstrapped". My expectation would be a section like here corresponding to the information of the --help section.
Best regards
Carlo

Hi Carlo,
Main help just shows general flags and commands. In order to view more details for a specific command, do: tezedge-client transfer --help.
Only supported commands are listed there, so the bootstrapped command is not implemented.
Also note that tezedge-client-s goal is not to be compatible with tezos-client and --endpoint flag is there for commands that need to interact with the api, like transfer and delegate.

Hi,
Thanks for the answer. If you want a normal validator you need to implement the following features that I basically use:

Register as delegate
Delegation itself
List connected ledgers (you check in general if the USB device is still connected)
set block level of hardware device
Bootstrapped command
How many connections to other nodes
Transfer

That is the basic set were I say: alright I drop tezos-client


[Das_Schwarze_Auge_4-1] Contributed Fixes

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description
My relatively recent changes seem to really have made the sheet more approachable to people other than me and so there is quite the influx of changes to my clone of the character sheets repo :tada:
These are the first small changes, more is on the horizon :)

Bug Fixes

Checks of talents with a negative value can now be successful (74d5ea445c)
Dark Mode: Enhance readability of labels in the character sheet (98bf07d78f)

Preparation of New Version

Add new author/developer "Pascal Stein" (9d475366f8)
Add info on latest version (5af56e317f)
Bump version number (75c5a895c6)
Regenerate sheet files (f8487f09cd)

Character Sheet Info Roll20 Internal Use only.