Integer overflow in some case

SQL:
select A.tp_bigint,B.id_dt from full_data_type_table A join full_data_type_table B on A.id_dt > B.id_dt * 16 where A.tp_bigint = B.id_dt order by A.id_dt

Throws:
Caused by: com.pingcap.tikv.exception.TiClientInternalException: Error reading region
  at com.pingcap.tikv.operation.SelectIterator.readNextRegion(SelectIterator.java:148)
  at com.pingcap.tikv.operation.SelectIterator.hasNext(SelectIterator.java:161)
  at org.apache.spark.sql.tispark.TiRDD$$anon$2.hasNext(TiRDD.scala:75)
  at scala.collection.Iterator$$anon$11.hasNext(Iterator.scala:408)
  at scala.collection.Iterator$$anon$11.hasNext(Iterator.scala:408)
  at scala.collection.Iterator$$anon$11.hasNext(Iterator.scala:408)
  at org.apache.spark.shuffle.sort.BypassMergeSortShuffleWriter.write(BypassMergeSortShuffleWriter.java:126)
  at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:96)
  at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:53)
  at org.apache.spark.scheduler.Task.run(Task.scala:99)
  at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:322)
  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
  at java.lang.Thread.run(Thread.java:748)
Caused by: java.util.concurrent.ExecutionException: com.pingcap.tikv.exception.SelectException: unknown error Codec(Other(StringError("I64(4355836469450447576) * I64(16) overflow")))
  at java.util.concurrent.FutureTask.report(FutureTask.java:122)
  at java.util.concurrent.FutureTask.get(FutureTask.java:192)
  at com.pingcap.tikv.operation.SelectIterator.readNextRegion(SelectIterator.java:145)
  ... 13 more
Caused by: com.pingcap.tikv.exception.SelectException: unknown error Codec(Other(StringError("I64(4355836469450447576) * I64(16) overflow")))
  at com.pingcap.tikv.region.RegionStoreClient.coprocessorHelper(RegionStoreClient.java:192)
  at com.pingcap.tikv.region.RegionStoreClient.coprocess(RegionStoreClient.java:185)
  at com.pingcap.tikv.operation.SelectIterator.createClientAndSendReq(SelectIterator.java:130)
  at com.pingcap.tikv.operation.SelectIterator.lambda$submitTasks$2(SelectIterator.java:113)
  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
  at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
  ... 3 more

Seems there's an overflow issue here.
Note that if we remove * 16 in the sql, the above exception won't be thrown.

Spark plan:
   :- Project [id_dt#0L, tp_bigint#8L]
   :  +- Filter ((isnotnull(id_dt#0L) && (id_dt#0L > (tp_bigint#8L * 16))) && isnotnull(tp_bigint#8L))

tp_bigint#8L * 16 may definitely cause an overflow issue, but we did't validate this filter, pushed it down to TiKV and caused the above problem.

I think spark plan generated here may not be appropriate, a CheckOverflow might have been added to the above filter like the following plan:
   :- Project [id_dt#0L, tp_bigint#8L]
   :  +- Filter (((cast(id_dt#0L as decimal(24,2)) > CheckOverflow((cast(cast(tp_bigint#8L as decimal(20,0)) as decimal(22,2)) * 2.22), DecimalType(24,2))) && isnotnull(id_dt#0L)) && isnotnull(tp_bigint#8L))

Related SQL:
select A.tp_bigint,B.id_dt from full_data_type_table A join full_data_type_table B on (A.id_dt > B.id_dt * 12.6) where A.tp_bigint = B.id_dt order by A.id_dt

tispark:
scala> testsql.explain
== Physical Plan ==
*Project [id_bigint#1L, id_int#26L]
+- *Sort [id_int#0L ASC NULLS FIRST], true, 0
   +- Exchange rangepartitioning(id_int#0L ASC NULLS FIRST, 200)
      +- *Project [id_bigint#1L, id_int#26L, id_int#0L]
         +- *SortMergeJoin [id_bigint#1L], [id_int#26L], Inner, (id_int#0L > (id_int#26L * 2))
            :- *Sort [id_bigint#1L ASC NULLS FIRST], false, 0
            :  +- Exchange hashpartitioning(id_bigint#1L, 200)
            :     +- TiDB CoprocessorRDD{
 Table: a
 Ranges: Start:[-9223372036854775808], End: [9223372036854775807]
 Columns: [id_int], [id_bigint]
 Filter: Not(IsNull([id_int])), Not(IsNull([id_bigint])), ([id_int] > ([id_bigint] Multiply 2))
}
            +- *Sort [id_int#26L ASC NULLS FIRST], false, 0
               +- Exchange hashpartitioning(id_int#26L, 200)
                  +- TiDB CoprocessorRDD{
 Table: a
 Ranges: Start:[-9223372036854775808], End: [9223372036854775807]
 Columns: [id_int]
 Filter: Not(IsNull([id_int]))
}

spark:
scala> testsql.explain
== Physical Plan ==
*Project [id_bigint#1L, id_int#50]
+- *Sort [id_int#0 ASC NULLS FIRST], true, 0
   +- Exchange rangepartitioning(id_int#0 ASC NULLS FIRST, 200)
      +- *Project [id_bigint#1L, id_int#50, id_int#0]
         +- *SortMergeJoin [id_bigint#1L], [cast(id_int#50 as bigint)], Inner, (id_int#0 > (id_int#50 * 2))
            :- *Sort [id_bigint#1L ASC NULLS FIRST], false, 0
            :  +- Exchange hashpartitioning(id_bigint#1L, 200)
            :     +- *Scan JDBCRelation(a) [numPartitions=1] [id_int#0,id_bigint#1L] PushedFilters: [*IsNotNull(id_int), *IsNotNull(id_bigint)], ReadSchema: struct<id_int:int,id_bigint:bigint>
            +- *Sort [cast(id_int#50 as bigint) ASC NULLS FIRST], false, 0
               +- Exchange hashpartitioning(cast(id_int#50 as bigint), 200)
                  +- *Scan JDBCRelation(a) [numPartitions=1] [id_int#50] PushedFilters: [*IsNotNull(id_int)], ReadSchema: struct<id_int:int>

Push it back to spark might solve the problem. Or promote it to larger type and push. But likely this implicit conversion is not supported in TiKV old interface. Anyway, we need a check before push, and fallback if not valid predicates. We have talked through it this afternoon. @birdstorm

Need to fix after DAG interface.

Another case:
select A.id_dt,A.tp_bigint,B.id_dt from full_data_type_table A join full_data_type_table B on A.id_dt > B.id_dt * 16 where A.tp_bigint = B.id_dt order by A.id_dt, B.id_dt

Exception:
Caused by: com.pingcap.tikv.exception.SelectException: unknown error Overflow
	at com.pingcap.tikv.region.RegionStoreClient.coprocessorHelper(RegionStoreClient.java:266)

This issue is caused by bigint overflow from TiKV computation stage. To prevent this from happening, we could let bigint calculation remains in Spark and don't push it down to TiKV.
However, same issue occurs in TiDB and MySQL:
SQL:
select tp_int from full_data_type_table where tp_bigint * 20 > 0

TiDB:
ERROR 1105 (HY000): other error: unknown error Overflow

MySQL:
ERROR 1690 (22003): BIGINT value is out of range in '(`tispark_test`.`full_data_type_table`.`tp_bigint` * 20)'

It seems that both of them don't have a fallback path to handle this scenario.
But in Spark with JDBC, operation on potential overflow calculation cases will not be pushed down.
Like this:
== Physical Plan ==
*Project [tp_int#84]
+- *Filter ((tp_bigint#80L * 20) > 0)
   +- *Scan JDBCRelation(tispark_test.full_data_type_table) [numPartitions=1] [tp_int#84,tp_bigint#80L] PushedFilters: [*IsNotNull(tp_bigint)], ReadSchema: struct<tp_int:int>

So here's the question, should we make our behavior in consistence with TiDB/MySQL or Spark with JDBC? :lying_face:


setSelectedYear method

Could You implement method for setting selected year ?

@pglebocki  yes, I will update as soon as possible.

Thanks,
I am waiting for update :)
2017-12-20 8:05 GMT+01:00 Kristiawan Adi L<EMAIL_ADDRESS>
@pglebocki https://github.com/pglebocki yes, I will update as soon as
possible.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lutvie72/RackMonthPicker/issues/8#issuecomment-352982653,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHauKNGoE4JTKc0vavgRdRNv6mQOx0F7ks5tCLG2gaJpZM4RHRiQ
.


invalid operation: str1[0] (type *[]rune does not support indexing

my Code:
package main
import(
"fmt"
)
func main(){
str1 := []rune("google")
fmt.Print(temp(&str1))
}
func temp(str1 *[]rune) (sum int){
fmt.Print(str1[0]);
return

}
error:  temp.go:12: invalid operation: str1[0] (type *[]rune does not support indexing
This is what problem?

Use (*str1)[0].
Please use the golang-nuts mailing list to ask questions like this. The issue tracker is only for reporting bugs.

The golang-nuts mailing list is the place to ask such questions.


Fix empty stack trace when use bazel on aarch64

Fix issue https://github.com/google/glog/issues/904: Stack trace is empty when use bazel on aarch64
Add -DHAVE_EXECINFO_H to linux copts.

Codecov Report

Merging #905 (03c9249) into master (9c3d6d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #905   +/-   ##
=======================================
  Coverage   73.94%   73.94%
=======================================
  Files          17       17
  Lines        3282     3282
=======================================
  Hits         2427     2427
  Misses        855      855

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I guess we can ignore the failed checks, they seem like flakes.

Thank you!


CC-19: Added switch control on multiselect with tags component

https://github.com/Components-care/backlog/issues/19

Added knob(Enable Switch) on story to enable/disable switch on multi select with tags component

@TQjona , Changes updated. Please Review.

@TQjona , Changes updated. Please Review.


change guessTheNumber file to

change from
const djsGames = require('djs-games') const guessTheNumber = new djsGames.guessTheNumber()  guessTheNumber.startGame(message)
to
const djsGames = require('djs-games') const GuessTheNumber = new djsGames.GuessTheNumber()  GuessTheNumber.startGame(message)
because djsGames.guessTheNumber is not a constructor.

Fixed it!
Its now
const djsGames = require('djs-games') const guessTheNumber = new djsGames.GuessTheNumber() guessTheNumber.startGame(message)

Fixed it!
Its now
const djsGames = require('djs-games') const guessTheNumber = new djsGames.GuessTheNumber() guessTheNumber.startGame(message)


⚠ Exoticaz has degraded performance

In 57c708c, Exoticaz ($EZ) experienced degraded performance:

HTTP code: 200
Response time: 9438 ms

Resolved: Exoticaz performance has improved in c9181fc.


Restore scripts menu to standard layout

Fixes issue #955
Brief summary of changes
PR #981 had a side effect of changing the Scripts menu. This PR undoes this change and also sets the ScriptsPath preference when user forces installResources()
Testing I've completed
Tested on Mac (where Preferences are not persistent) and all worked as expected
CHANGELOG.md (choose one)

no need to update because bugfix

@chrisdembia this PR undoes the unintentional change to Scripts menu. Feel free to test the Artifact from the build as needed.


Glob Paths From tsconfig Paths Should Not be Suggested as Module Names

From https://github.com/Microsoft/vscode/issues/21026
TypeScript Version:  2.2.1 / nightly (2.2.0-dev.201xxxxx)
Code
For a tsconfig.json
{
    "compilerOptions": {
        "module": "es2015",
        "moduleResolution": "node",
        "baseUrl": ".",
        "paths": {
            "app":  [
                "./src/app"
            ],
            "app/*": [
                "./src/app/*"
            ]
        }
    }
}

In src/app/actions/a.ts
import * as Comment from '|'

Request completions from the TSServer at the |
Bug
A suggestion for a module named app/* is returned:
[Trace - 7:32:53 PM] Sending request: completions (412). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "/Users/matb/projects/sand/src/app/actions/a.ts",
    "line": 3,
    "offset": 34
}
[Trace - 7:32:53 PM] Response received: completions (412). Request took 13 ms. Success: true
Result: [
    {
        "name": "app",
        "kind": "external module name",
        "kindModifiers": "",
        "sortText": "app",
        "replacementSpan": {
            "start": {
                "line": 3,
                "offset": 34
            },
            "end": {
                "line": 3,
                "offset": 34
            }
        }
    },
    {
        "name": "app/*",
        "kind": "external module name",
        "kindModifiers": "",
        "sortText": "app/*",
        "replacementSpan": {
            "start": {
                "line": 3,
                "offset": 34
            },
            "end": {
                "line": 3,
                "offset": 34
            }
        }
    },

Just looking at old issues; this was fixed by #21072 (which removed the app/* completion), then refined in #21689 (adding back a app/ completion).


Unable to remove expired Keeper from F&F list.

-An old Keeper shows up in F&F list as expired even if it was replaced by a new.
-Cant remove it even.

@cakesoft-swati Can you please let me know the steps to replicate the above scenario? I've already tried the standard contact change flow and it didn't cause this issue, is there any specific action that leads to this?

-Unable to replicate this issue on latest app.


Update Currency.js

Fix for https://github.com/wemersonjanuario/Ext.ux.form.field.Currency/issues/2
Two way binding will format the input while user is still typing

Thanks!


Updates Gnosis Form

Overview
Small Update to the UI/UX of the Gnosis Config Form. Instead of click an 'add' button, the user enters a number in the field
Screenshot

closes #426

@adamgall merged w/ develop to fix conflict, will need a re-approval


Add support for .terraform-version file format for dev command

Fixes #831

Thank you @kishaningithub for your excellent feedback and now your contribution also.

Will publish 1.0.5 by EoW

By creating this PR i also learnt that deno can publish a self contained binary and can also cross compile. Previously i was of the opinion that only languages like golang can do something like that.

run deno task install if you want /usr/local/bin/pkgx with this change in the meantime.


Investigate deduplication of txes for non-DA nodes

Currently, nodes that are not in the DA will gossip about transactions that the DA has already seen. This ticket is to propose a solution where transactions already submitted to the DA will not be gossiped about.

Closing as #1801 solved this. Transactions only get sent to the committee, so we no longer get a ballooning # of transactions


Fix transaction data decoding

What do these changes do?
Fix incorrect transaction data decoding.
Transaction data always decoded two times if connection encoding was defined and impossible to override connection encoding per transaction command:
Test case:
@pytest.mark.run_loop
async def test_global_encoding(redis, create_redis, server, loop):
    redis = await create_redis(
        server.tcp_address,
        loop=loop, encoding='utf-8')
    res = await redis.set('key', 'value')
    assert res is True
    res = await redis.hmset(
        'hash-key', 'foo', 'val1', 'bar', 'val2')
    assert res is True

    tr = redis.multi_exec()
    fut1 = tr.get('key')
    fut2 = tr.get('key', encoding='utf-8')
    fut3 = tr.get('key', encoding=None)
    fut4 = tr.hgetall('hash-key', encoding='utf-8')
    await tr.execute()
    res = await fut1
    assert res == 'value'
    res = await fut2
    assert res == 'value'
    res = await fut3
    assert res == b'value'
    res = await fut4
    assert res == {'foo': 'val1', 'bar': 'val2'}

Tracing for util.decode
Before
decode(b'PONG', utf-8)
decode(b'OK', utf-8)
decode(b'OK', utf-8)
decode(b'OK', utf-8)
decode(b'QUEUED', utf-8)
decode(b'QUEUED', utf-8)
decode(b'QUEUED', utf-8)
decode([b'value', b'value', b'value', [b'foo', b'val1', b'bar', b'val2']], utf-8)
decode(b'value', utf-8)
decode(b'value', utf-8)
decode(b'value', utf-8)
decode([b'foo', b'val1', b'bar', b'val2'], utf-8)
decode(b'foo', utf-8)
decode(b'val1', utf-8)
decode(b'bar', utf-8)
decode(b'val2', utf-8)
decode(value, utf-8)
decode(value, utf-8)
decode(['foo', 'val1', 'bar', 'val2'], utf-8)
decode(foo, utf-8)
decode(val1, utf-8)
decode(bar, utf-8)
decode(val2, utf-8)

After
decode(b'PONG', utf-8)
decode(b'OK', utf-8)
decode(b'OK', utf-8)
decode(b'OK', utf-8)
decode(b'QUEUED', utf-8)
decode(b'QUEUED', utf-8)
decode(b'QUEUED', utf-8)
decode(b'value', utf-8)
decode(b'value', utf-8)
decode([b'foo', b'val1', b'bar', b'val2'], utf-8)
decode(b'foo', utf-8)
decode(b'val1', utf-8)
decode(b'bar', utf-8)
decode(b'val2', utf-8)

Are there changes in behavior for the user?
This changes should not impact on the end user.
Related issue number
closes #657
Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[x] Documentation reflects the changes
[x] If you provide code modification, please add yourself to CONTRIBUTORS.txt

The format is <Name> <Surname>.
Please keep alphabetical order, the file is sorted by names.

[x] Add a new news fragment into the CHANGES/ folder

name it <issue_id>.<type> (e.g. 588.bugfix)
if you don't have an issue_id change it to the pr id after creating the PR
ensure type is one of the following:

.feature: Signifying a new feature.
.bugfix: Signifying a bug fix.
.doc: Signifying a documentation improvement.
.removal: Signifying a deprecation or removal of public API.
.misc: A ticket has been closed, but it is not of interest to users.

Make sure to use full sentences with correct case and punctuation, for example:
Fix issue with non-ascii contents in doctest text files.

Please see that failed tests is looks like not related to my PR. Also they were successful on my fork.


Add section describing Kargo vs Kops

I'm a total newbie to Kubernetes and hopped onto the #kargo channel on the Slack to find out more about Kargo. This is a first crack at what I've learned, but it's certainly erroneous in places. Please propose changes! Perhaps people from the Kops repo would like to contribute too?

I'm fine with that - seems very fair (speaking from the kops perspective).

@swizzlr Please sign the CLA if you want to contribute to any kubernetes* repository

I'll second @mattymo's suggestion. Let's maybe create a docs/comparisions.md file and link that in the README. That will also allow us to compare/contrast any other deployment tools as needed in one place.

@mattymo @rsmitty Updated!


Package prefixes from prop file are in the wrong order

Hi
To translate code, I was using ‘—prefix’ options to specify multiple package prefixes. And recently the definition of the prefix mapping was moved to a prop file to translate with ‘—prefixes’ option.
But I found that prefixes of the translated code are different from before.
I guess java.util.Properties#load() causes this issue.
https://github.com/google/j2objc/blob/master/translator/src/main/java/com/google/devtools/j2objc/util/PackagePrefixes.java#L131
I’m using wildcard to specify packages.

Do you have an example demonstrating this? I agree it may be java.util.Properties, but that's just a guess now.

Hi
Thanks for your comment !
Here is  a demo.
$ find .
.
./prefixes.properties
./foo
./foo/bar
./foo/bar/b
./foo/bar/b/Cat.java

$ cat foo/bar/b/Cat.java
package foo.bar.b;

class Cat {}

$ j2objc --prefix 'foo.bar.b.*=FBB' --prefix 'foo.bar.*=FBX' foo/bar/b/Cat.java && cat foo/bar/b/Cat.h
//
//  Generated by the J2ObjC translator.  DO NOT EDIT!
//  source: foo/bar/b/Cat.java
//

#include "J2ObjC_header.h"

#pragma push_macro("INCLUDE_ALL_FooBarBCat")
#ifdef RESTRICT_FooBarBCat
#define INCLUDE_ALL_FooBarBCat 0
#else
#define INCLUDE_ALL_FooBarBCat 1
#endif
#undef RESTRICT_FooBarBCat

#if !defined (FBBCat_) && (INCLUDE_ALL_FooBarBCat || defined(INCLUDE_FBBCat))
#define FBBCat_

@interface FBBCat : NSObject

#pragma mark Package-Private

- (instancetype)init;

@end

J2OBJC_EMPTY_STATIC_INIT(FBBCat)

FOUNDATION_EXPORT void FBBCat_init(FBBCat *self);

FOUNDATION_EXPORT FBBCat *new_FBBCat_init() NS_RETURNS_RETAINED;

FOUNDATION_EXPORT FBBCat *create_FBBCat_init();

J2OBJC_TYPE_LITERAL_HEADER(FBBCat)

@compatibility_alias FooBarBCat FBBCat;

#endif

#pragma pop_macro("INCLUDE_ALL_FooBarBCat")

$ cat prefixes.properties
foo.bar.b.*=FBB
foo.bar.*=FBX

$ j2objc --prefixes prefixes.properties foo/bar/b/Cat.java && cat foo/bar/b/Cat.h
//
//  Generated by the J2ObjC translator.  DO NOT EDIT!
//  source: foo/bar/b/Cat.java
//

#include "J2ObjC_header.h"

#pragma push_macro("INCLUDE_ALL_FooBarBCat")
#ifdef RESTRICT_FooBarBCat
#define INCLUDE_ALL_FooBarBCat 0
#else
#define INCLUDE_ALL_FooBarBCat 1
#endif
#undef RESTRICT_FooBarBCat

#if !defined (FBXCat_) && (INCLUDE_ALL_FooBarBCat || defined(INCLUDE_FBXCat))
#define FBXCat_

@interface FBXCat : NSObject

#pragma mark Package-Private

- (instancetype)init;

@end

J2OBJC_EMPTY_STATIC_INIT(FBXCat)

FOUNDATION_EXPORT void FBXCat_init(FBXCat *self);

FOUNDATION_EXPORT FBXCat *new_FBXCat_init() NS_RETURNS_RETAINED;

FOUNDATION_EXPORT FBXCat *create_FBXCat_init();

J2OBJC_TYPE_LITERAL_HEADER(FBXCat)

@compatibility_alias FooBarBCat FBXCat;

#endif

#pragma pop_macro("INCLUDE_ALL_FooBarBCat")

Is this correct use ?
I'm using wildcard with over wrapped packages.
My expectation is as below
Settings
foo.bar.b.*=FBB
foo.bar.*=FBX

Expected results
foo.bar.b.Cat => FBBCat
foo.bar.Dog => FBXDog

Interesting scenario, the intention is to process the wildcards in the
declared order. That's the behavior that you are seeing with --prefix.
In the case of --prefixes, the order is not preserved because we are using
java.util.Properties (which inherits from Hashtable)
https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html
Here is a relevant link to this discussion:
https://stackoverflow.com/questions/17011108/how-can-i-write-java-properties-in-a-defined-order
On Thu, Aug 2, 2018 at 4:13 AM sfuku7<EMAIL_ADDRESS>wrote:

Hi
Thanks for your comment !
Here is a demo.
$ find .
.
./prefixes.properties
./foo
./foo/bar
./foo/bar/b
./foo/bar/b/Cat.java
$ cat foo/bar/b/Cat.java
package foo.bar.b;
class Cat {}
$ j2objc --prefix 'foo.bar.b.=FBB' --prefix 'foo.bar.=FBX' foo/bar/b/Cat.java && cat foo/bar/b/Cat.h
//
//  Generated by the J2ObjC translator.  DO NOT EDIT!
//  source: foo/bar/b/Cat.java
//
#include "J2ObjC_header.h"
#pragma push_macro("INCLUDE_ALL_FooBarBCat")
#ifdef RESTRICT_FooBarBCat
#define INCLUDE_ALL_FooBarBCat 0
#else
#define INCLUDE_ALL_FooBarBCat 1
#endif
#undef RESTRICT_FooBarBCat
#if !defined (FBBCat_) && (INCLUDE_ALL_FooBarBCat || defined(INCLUDE_FBBCat))
#define FBBCat_
@interface FBBCat : NSObject
#pragma mark Package-Private

(instancetype)init;

@end
J2OBJC_EMPTY_STATIC_INIT(FBBCat)
FOUNDATION_EXPORT void FBBCat_init(FBBCat *self);
FOUNDATION_EXPORT FBBCat *new_FBBCat_init() NS_RETURNS_RETAINED;
FOUNDATION_EXPORT FBBCat *create_FBBCat_init();
J2OBJC_TYPE_LITERAL_HEADER(FBBCat)
@compatibility_alias FooBarBCat FBBCat;
#endif
#pragma pop_macro("INCLUDE_ALL_FooBarBCat")
$ cat prefixes.properties
foo.bar.b.=FBB
foo.bar.=FBX
$ j2objc --prefixes prefixes.properties foo/bar/b/Cat.java && cat foo/bar/b/Cat.h
//
//  Generated by the J2ObjC translator.  DO NOT EDIT!
//  source: foo/bar/b/Cat.java
//
#include "J2ObjC_header.h"
#pragma push_macro("INCLUDE_ALL_FooBarBCat")
#ifdef RESTRICT_FooBarBCat
#define INCLUDE_ALL_FooBarBCat 0
#else
#define INCLUDE_ALL_FooBarBCat 1
#endif
#undef RESTRICT_FooBarBCat
#if !defined (FBXCat_) && (INCLUDE_ALL_FooBarBCat || defined(INCLUDE_FBXCat))
#define FBXCat_
@interface FBXCat : NSObject
#pragma mark Package-Private

(instancetype)init;

@end
J2OBJC_EMPTY_STATIC_INIT(FBXCat)
FOUNDATION_EXPORT void FBXCat_init(FBXCat *self);
FOUNDATION_EXPORT FBXCat *new_FBXCat_init() NS_RETURNS_RETAINED;
FOUNDATION_EXPORT FBXCat *create_FBXCat_init();
J2OBJC_TYPE_LITERAL_HEADER(FBXCat)
@compatibility_alias FooBarBCat FBXCat;
#endif
#pragma pop_macro("INCLUDE_ALL_FooBarBCat")
Is this correct use ?
I'm using wildcard with over wrapped packages.
My expectation is as below
Settings
foo.bar.b.=FBB
foo.bar.=FBX
Expected results
foo.bar.b.Cat => FBBCat
foo.bar.Dog => FBXDog
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/j2objc/issues/995#issuecomment-409891730, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AbFr1XHrHibqxaft3tY87iq3sSJ_i2Zgks5uMt7hgaJpZM4VrbPK
.

I think it will be safe to drop Properties' support for representing \uxxxx as Unicode characters, since we can instead require prefixes.properties files be encoded in UTF-8 instead of ISO 8859-1 as Properties does. Does that seem reasonable?

SGTM
On Thu, Aug 2, 2018 at 10:27 AM Tom Ball<EMAIL_ADDRESS>wrote:

I think it will be safe to drop Properties' support for representing
\uxxxx as Unicode characters, since we can instead require
prefixes.properties files be encoded in UTF-8 instead of ISO 8859-1 as
Properties does
https://docs.oracle.com/javase/7/docs/api/java/util/Properties.html.
Does that seem reasonable?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/j2objc/issues/995#issuecomment-410005551, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AbFr1YJcyNu6f6GSxktTSh6yiXIiQpU3ks5uMzaUgaJpZM4VrbPK
.

Thanks !
I’ll use prefix packages not relying on declared order at this moment.

Fixed in version 2.2


default to local weights directory and fall back to HF

See https://github.com/replicate/cog-stable-diffusion/issues/59 and https://github.com/replicate/dreambooth-api/issues/4

From @anotherjesse

It crashed without setting the weights to FP 16

Replaced by https://github.com/replicate/cog-stable-diffusion/pull/62


Control panel titel

I think the name in/on the control panel is written wrong: WP(И)-XM

If you are referring to the "reversed" N (Cyrillic I), than that is intentional. Let me refer you to the project's website and the logo of the application that you'll find there:

...as well as here on github (project description and readme file):

Thank you for using WPN-XM.
The "reversed" N is cyrillic and the initial letter for Nginx.


Open Graph Tag Data

Since we are using server rendered react in some parts, we can set in the call or use a query selector to give specific OG data
for example okcandidate.code4hr.org?mayor=sessoms
and it would show a picture of the candidate.

Here is the graph tags we have.
unless we want to use a flag like suggested above we would have to populate the state.

i put some default copy that can be found in Default.jsx and is rendered by the server.

Besides also that the router navigation needs to be resolved, this involves also the OG specified data to be updated
OG Data is implemented However when we link to the URL, we are linking to the base instead of the current suggested.


get non-surgical procedures performed by LAS into procedures

These include retro-orbital injections, perfusion, tamoxifen dosing, post-surgical monitoring (?)
Need to find the right contact in LAS about how these requests are stored.

start with retro-orbital injections and perfusion. See if you can find ICV and ICM injections. Play around with SQL queries to find procedures in labtracks


MoveAnything

The addon MoveAnything seems to conflict with spell alerts which do not appear. Spell alerts are correctly displayed when MA is disabled.

Closing this issue as there haven’t been any news about this bug for months. Considering the popularity of MoveAnything, if the problem was really due to SpellActivationOverlay, there should have been more reports about this issue.
Feel free to comment about it if the issue still persists - and if someone is willing to give more information about it.


Set tool center point (TCP) cleared when external control enabled

We are developing a mobile co-bot using a ur10e running along side a ros2 stack with moveit2. The majority of the time the arm controlled through moveit2 with the robot running the external control cap. However there are some situations when we need to send movel and set_tcp programs via the ur_script interface node.
Running with the docker simulation we are facing an issue when trying to alternate between external control with moveit2 and sending script commands the tcp is set back to zero. Steps to reproduce

Publish set_scp(p[0, 0, 0.2, 0, 0, 0])
Publish textmsg("TCP = , get_tcp_offset()) - Confirms tcp has been set
Publish movel(...) - Movel respects tcp settings
Play external control program
Publish textmsg("TCP = , get_tcp_offset) - TCP set back to zero

We have also found that after sending any ur_script programs via the external control program goes from "running" -> "normal" and requires the ur_dashboard/play service to be called to re-enable external control. We suspect this is causing the default installation to be loaded even though the dashboard manual only indicates this should happen via the load service.
Additional information
We are sending each set_tcp and movel cmd as a defined program followed the program call.
Docker simulation showing firmware version 5.13.0
Building the ur_robot_driver from source using the humble branch.

Thank you for your report.
urscript_interface stopping the program on the robot is expected behavior and documented here. For me, calling /dashboard_client/play does however not load a new installation - If i have my program "external control" running in some "test_installation", going through these steps does not change it. Can you describe what exactly you do that triggers the loading of your default installation?
I can reproduce your issue of the resetting tcp, but cannot quite figure out why that happens. @urmahp do you know what's happening here?

Thanks for the quick reply. Sorry for the confusion, the resetting installation was only a theory.
Also on a related but separate issue, it would be very handy to see the changes to the tcp via the script interface reflected in the GUI.

This is intended behaviour, because when you play the program the robot will read the tcp configuration from the installation file, which in your case is zero. Whenever you play a robot program it will read all definitions set in the loaded installation. When you set the tcp using the script command it will be active until you overwrite it with a new set_tcp command or playing a program with a different tcp configuration in the loaded installation file.

Can you suggest an alternative way to achieve what we are after?

An alternative aproach would be to
a) Modify the installation on-line (which to my knowledge isn't possible (at least straight forward), but I might be wrong)
b) Implement setting the tcp through the custom script interface in the client library and then wrapping this into a ROS call similar with how we handle the setPayload() call.
Option b) would require adding it to the urscript here and here, adding it to the ScriptCommandInterface, adding it to the ros2_control xacro similar to this and finally wrapping it into a ROS controller similar to this repo's gpio controller (Note that this is currently a dump for multiple funcionalities that will get broken up into individual controllers, see #579 for a standalone controller). Any help on implementing this would be very much appreciated, I think this would be a great enhancement.


[data-client] Add Diem Data Client Config to State Sync Config

Motivation
Existing Diem data client uses hardcoded values for request timeout and data summary polling. This PR removes these hardcoded values and makes these constants configurable as part of StateSyncConfig
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Manually test by:

Changing the default values of DiemDataClientConfig in state_sync_config and verifying that DiemNetDataClient uses these default values if no config file is given.

Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/diem/diem/tree/main/developers.diem.com, and link to your PR here.)
If targeting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Why we must have it for V1 launch.
What workarounds and alternative we have if we do not push the PR.

Thanks @JoshLind for the feedback! I have addressed all of them. Please let me know if there are further changes I should make. Thank you!

/land


Default to infinite  max_history_tokens  to be backward compatible.

We should default to infinite  max_history_tokens  to be backward compatible.
Originally posted by @NirantK in https://github.com/NirantK/agentai/pull/8#discussion_r1281711998

Backward compatible as in have a list of all the messages in one list and that is trimmed based on the tokens given?

Do not trim the Conversation by default at all. That is the existing behavior — we don't trim.


[WIP] Push down rf

Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.16 out of 17 committers have signed the CLA.:white_check_mark: silverbullet233:white_check_mark: fzhedu:white_check_mark: meegoo:white_check_mark: sevev:white_check_mark: amber-create:white_check_mark: Astralidea:white_check_mark: Smith-Cruise:white_check_mark: leoyy0316:white_check_mark: zaorangyang:white_check_mark: LiShuMing:white_check_mark: luohaha:white_check_mark: sduzh:white_check_mark: gengjun-git:white_check_mark: evelynzhaojie:white_check_mark: ZiheLiu:white_check_mark: zombee0:x: mergify[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


Upper bound score by skilled human?

Have you made any attempt to characterize a "skilled human upper bound" score?
I randomly sampled a dozen swe-bench tasks myself, and found that many were basically impossible for a skilled human to “solve”. Mainly because the tasks were under specified wrt to the hidden test cases that determine passing. The tests were checking implementation specific details from the repo’s PR that weren't actually stated requirements of the task.
I asked this question in the current HN discussion about SWE agent, but it doesn't look like you are participating there.
https://news.ycombinator.com/item?id=39910452

Hi @paul-gauthier we did not have the resources to determine this number when putting forth the original SWE-bench.
Given that SWE-bench issues are collected from real pull requests that have been reviewed and accepted by human collaborators, to some degree we believe that these task instances are difficult, but not impossible as they were completed by human task workers.
However, we understand your angle, particularly how some issue descriptions could be under-specified on face value. We have ongoing work that aims to better understand how a software engineer without context or prior knowledge would perform on SWE-bench.
Thanks for the comment, it's a good point that we don't have the data for at the moment, but hope to have it soon!

I would suggest randomly sampling N of the tasks. Manually inspect the hidden test cases as compared to the issue description. Flag the issue if the tests require things not specified in the issue.
You should be able to estimate a reasonable bound after only N=~20 or so such inspections.
I did this myself informally, and found a large ratio of "unsolvable" tasks.

i see this as a foundational issue in the dataset. i sincerely hope the authors will take the responsibility to "do the right thing".
clearly there is a judgement call about how to define "unsolvable" and "under-specified".
the princeton nlp team has catalyzed a true movement! my fear is that in a post-devin world, we now have thousands of devs and hundreds of millions of dollars chasing 100% on a broken benchmark. it is a "mission impossible".
i have tremendous empathy for the resource limitations. clearly it doesn't make sense to redact the existing benchmark. i'm sure the next one will be better.
to be clear: my criticism is not about the unsolvable tasks themselves, but about the transparency and visibility of the limitations of this benchmark. it needs to come from the source.
a specific request: could we leave this issue marked open for visibility? the vast majority of the "open devin" community is unaware of this flaw in swe-bench, and it doesn't feel right to watch thousands of eager and smart people bang their heads against a wall.
(go tigers)

Hi @rawwerks, we're aware of this issue.
We'll be updating this repository and future evaluations shortly with a solution that I think will be satisfying for everyone.
In the mean time, I believe that SWE-bench Lite is currently where most evaluations are being done and should not suffer from as many issues related to human solvability.
In our experiments, the best models can achieve rather high scores when given multiple tries, and I believe that the practical upper bound is much higher than the current SOTA for Lite.
I'll reopen this issue for transparency but we expect to resolve it very shortly.

multiple tries,

Range?

multiple tries,

Range?

They get 32% pass@6. (from the paper)

In our experiments, the best models can achieve rather high scores when given multiple tries, and I believe that the practical upper bound is much higher than the current SOTA for Lite.

(from the paper) "we find that 93.0% of resolved instances are submitted before exhausting their cost budget. For these reasons, we suspect that increasing the maximum budget or token limit are unlikely to lead to substantial increases in performance."
@carlosejimenez Could you please clarify if there is an update on this? Thanks

@moresearch what clarification are you requesting? I think the sentence is quite clear, but can you provide more context of what's unclear? Of the 12.47% instances that were resolved, 93% were submitted, while 7% were auto-submitted due to exceeding cost limit.
Also, just commenting here to indicate that we still have this issue in mind and we're actively working on this. Human validation takes some time, so we anticipate a full report should be out some time late June - early July.

I would suggest randomly sampling N of the tasks. Manually inspect the hidden test cases as compared to the issue description. Flag the issue if the tests require things not specified in the issue.
You should be able to estimate a reasonable bound after only N=~20 or so such inspections.
I did this myself informally, and found a large ratio of "unsolvable" tasks.

Agreed. After inspec the datasets and the repos, I found a lot of patches in swe-bench-lite is not achievable without additonal input.

The problem here seems to be with the dataset's inclusion criteria.
Existing Inclusion Criteria
The paper itself states very lax criteria. In Appendix A.1, it says:

Task instance construction. We construct candidate task instances from PRs that satisfy three conditions.

First, the PR’s status must be Merged. A Merged status indicates that the PR’s associated code changes were accepted and incorporated into its parent repository.

Second, the PR resolves one or more issues in its repository. An issue is defined according to its canonical usage in GitHub as a digital ticket for tracking bugs, enhancements, or any general development goals for a software project. We scan a PR’s title, body, and commit messages for linked issues (i.e. “fixes #24”).

Third, the PR must introduce one or more new tests. A new test is counted when a PR’s code changes edits a file path containing a testing-related keyword (e.g. “test”, “testing”).

A Suggestion
An issue should only be deemed "suitable" if an expert outside contributor who fully understands (i) the codebase, (ii) the docs and (iii) the issue can solve the issue.
Some supplementary inclusion/exclusion criteria:

Does the solution depend on any not directly referenced communiqué, or other not publicly and directly available information?
Does the solution implement an unspecified design?

Of course such a dataset is much harder to build and curate, but it certainly feels worth striving for.
I'd be interested if (and where, if publicly available) you are currently working on this?
But I can also understand if this approach is deemed too costly for you to take on at this point in time.

This issue can be closed now.
SWE-bench verified is the answer.

As a follow up, if you have questions concerning SWE-bench Verified, please feel free to open a new issue, and we can address it there as this thread has grown somewhat long.


VS Code Razor syntax highlighting and intellisense not working

Screenshot

Versions

Visual Studio Code:

Version: 1.39.2 (user setup)
Commit: 6ab598523be7a800d7f3eb4d92d7ab9a66069390
Date: 2019-10-15T15:35:18.241Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

ms-vscode.csharp extension - 1.21.5
ASP.NET Core using Blazor Server - 3.0.0

Additional Context
Same ASP.NET Core Blazor Server app works fine with proper Razor syntax highlighting and intellisense in Visual Studio 2019 v16.3.7

Hey @pheuter thanks for the report! Honestly shocked coloring was the only issue you encountered with remote development 😄 . We've yet to add full support for remote development and are tracking that work here: https://github.com/aspnet/AspNetCore/issues/14331
That being said, your issue would have reprod even outside of remote development and is due to our language grammar not being complete yet. We're tracking that work here: https://github.com/aspnet/AspNetCore/issues/14287
Closing this for now as a duplicate.


check for jupyter-book versions and install 6.4

jupyter-book released new version 7.1 which is not yet supported by us. Made changes on the create book to install the older version 0.6.4 that's currently supported by us.
I tested the below two scenarios with my changes:

Install the latest version of jupyter-book and tried running the book, it uninstalls the 7.1 and installs 6.4.
Uninstalled jupyter-book and tried running the book, it installs 6.4 and continues.

My only current concern is, if the users have the latest version installed for their personal use and us uninstalling it. Should I add a prompt to user, that asks users permission to continue to uninstall the version they have?
This PR fixes #11158

We should make this explicit in the actual notebook (i.e. a markdown cell should make this clear that we will install the version that we support). Can you work with @yualan on the wording?

Why do we not support the latest version? If anything, we should try to support that instead of adding extra version checks. We definitely shouldn't uninstall a python package without prompting for it. The packages could be used by other applications that require a minimum version higher than what we support.

Why do we not support the latest version? If anything, we should try to support that instead of adding extra version checks. We definitely shouldn't uninstall a python package without prompting for it. The jupyter-book package could be used by other applications that require a minimum version higher than what we support.

I agree. We'll definitely work on this for next release. Given the code freeze time for this release, I don't want to have a broken experience for create-book for new users.

@corivera In jupyter-book 0.7.0+ the folder structure is different; it was recently released within the past month or two, and we haven't added support for that... Yet.
Given that we ship Jupyter Books all using the older version, there's work to ensure that we support both the old + new versions of the format.

Coverage decreased (-0.06%) to 35.923% when pulling 160a87925c5c540e5264ed11b0b0eb982c655c9a on fix/installCorrectJupyterBook into 4c27001de5235bfc000d3116e620a2947d3f1de3 on main.

Makes sense.

Jupyters Books in Azure Data Studio only support jupyter-book versions <= 0.6.4 To create a Jupyter Book, we will be uninstalling versions newer than 0.6.4 and replacing with 0.6.4


Multi-Cluster apps disappear after server restart

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Restart Rancher server after installing a multi-cluster app
Result:
After restart the following error may appear:
2019/02/19 15:55:52 [ERROR] MultiClusterAppController cattle-global-data/mca-hr7w9 [multi-cluster-app-controller] failed with : error App.project.cattle.io "" is invalid: metadata.name: Required value: name or generateName is required in creating multiclusterapp: &{{} {MultiClusterApp management.cattle.io/v3} {mca-hr7w9  cattle-global-data /apis/management.cattle.io/v3/namespaces/cattle-global-data/multiclusterapps/mca-hr7w9 64014b69-3499-11e9-a1ab-025000000001 3541 1 2019-02-19 15:55:02 -0700 MST <nil> <nil> map[cattle.io/creator:norman] map[field.cattle.io/creatorId:user-gskw4] [] nil [] } {cattle-global-data:library-redis-3.0.2 [{  map[image.repository:bitnami/redis cluster.enabled:true image.tag:4.0.9 master.persistence.enabled:false slave.service.nodePort: cluster.slaveCount:3 metrics.image.repository:oliver006/redis_exporter password: slave.service.type:ClusterIP usePassword:true master.service.type:ClusterIP master.persistence.storageClass: defaultImage:true master.service.nodePort: metrics.image.tag:v0.11 master.persistence.size:8Gi]}] [{local:p-8s57j   }] [] [cluster-owner project-owner] 10 {<nil>}} {[{Installed True 2019-02-19T15:55:04-07:00   } {Deployed True 2019-02-19T15:55:21-07:00   }] mcapprevision-95k4m}}
.
.
.
[tiller] 2019/02/19 16:08:11 uninstall: Deleting mca-hr7w9-p-8s57j

The app disappears from from the Project Catalog Apps page and attempt to access the project deployment from the Multi-Cluster apps page will result in a 404, even though the app shows as 'Active' in MC Apps.
Another restart of the server will re-deploy the app on the project level, but may result in errors like:
[kube] 2019/02/19 16:02:56 Using reaper for deleting "mca-hr7w9-p-8s57j-redis-master"
2019/02/19 16:02:56 [ERROR] StatefulSetController mca-hr7w9-p-8s57j/mca-hr7w9-p-8s57j-redis-master [workloadServiceGenerationController] failed with : cannot find app namespace in labels of mca-hr7w9-p-8s57j

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
Rancher master (d1d307c0ed18cb13c743e7b5d41986f985d918c9)
Installation option (single install/HA):
Single

rancher/rancher:master 2/22

Single node install

Created cluster

Deployed multicluster app to multiple targets

Stopped Rancher server

Started Rancher server

Multicluster app is still present and functional

HA install

Created cluster

Deployed multicluster app to multiple targets

Redeployed Rancher daemonset

Multicluster app is still present and functional


=== vs ==

  104:24  warning  Expected '===' and instead saw '=='

I'll reopen this issue since it seems like I forgot one instance of this warning.


[NOMERGE][Breaking Change][lexical] Feature: New update tag: skip-dom-selection, $onUpdate now always called

Description

Adds documentation about focus to the selection documentation.
Adds a 'skip-dom-selection' update tag. Both of these are relevant to a very common FAQ which is about how to avoid the editor taking over the selection with a programmatic update.
Changes the type of updateDOM to be more correct, the prevNode argument should always be this (the same class, but a different instance). This fixes some subclassing issues.
Changes the behavior of onUpdate and $onUpdate to always be called. Previously they would be skipped if the update containing them did not make any nodes dirty. It's often useful to use $onUpdate to attach some logic in a dispatchCommand that does not need to update nodes or the selection but needs to do something with the reconciled DOM or editor afterwards.

Closes #6514
Clsoes #4474
Upgrade Notes
If you have code that expects onUpdate or $onUpdate to not be called if the update did not make any nodes or the selection dirty, then you will have to change your code accordingly.
Test plan
Unit tests were added for the new behavior of onUpdate / $onUpdate and  the 'skip-dom-selection' tag.

It looks like there's one failing flaky collab+firefox e2e test that now reliably fails in this PR. I'll investigate further before merge.
1 failed
[1]     [firefox] › packages/lexical-playground/__tests__/e2e/Autocomplete.spec.mjs:76:3 › Autocomplete › Can autocomplete in the same format as the original text

So what's currently happening here is:

Left editor changes the font size
Left editor types a character or two
Right editor sees the new text node with font size change, considers it a conflict for whatever reason, and creates a new paragraph
Right editor's new paragraph ends up moving the browser's focus to the right editor, so the rest of the characters end up being typed into the Right editor's new paragraph

Autocomplete is a necessary condition for this, so it seems that interaction between autocomplete and collab is the real problem here


How to remove empty lines?

Hi,
is there way to remove continuous empty lines more than one?

no_extra_consecutive_blank_lines

I have the same issue 4 empty lines in the header.php. Please explain what I have to do with your suggested code? thanks for your help

Hi @peterpaul02 ,
To help you maybe it is best to provide an example of what you want changed. You can ask us here;
https://gitter.im/PHP-CS-Fixer/Lobby


Service worker skipWaiting not activating workbox service worker

Library Affected:
workbox-sw.
Browser & Platform:
All
Issue or Feature Request Description:
*I have migrated from SW-Precache to workbox service worker, and during the process, I've updated service worker filename from 'service-worker.js' to 'service-worker-mobile.js' and also added workbox.skipWaiting() in the new service worker file, implying that as soon as new service worker file is downloaded, and installed, it should get activated, but, I can still see my old service worker file running. Any help here? *

What does the service worker registration object report? E.g. the result of await navigator.serviceWorker.getRegistration().
It's possible for skipWaiting() to not cause your existing service worker to be replaced if it's still waiting for an event promise to settle. This can happen if you pass event.waitUntil() a promise that never resolves.

I see the same thing. Service worker doesn't update even though skipWaiting is called, no other tabs open, no waitUntil.

Renaming your service-worker.js to something else, like service-worker-mobile.js is likely the cause of the problem. Your previously cached index.html, which includes a call to register service-worker.js, is likely be executed, and will be indefinitely.
The recommended approach is to keep a consistent service worker name. This is described in more detail at https://developers.google.com/web/fundamentals/primers/service-workers/lifecycle#avoid-url-change

I have quite similar problem.
According to https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/skipWaiting skipWaiting should return a promise which should be immediately resolved but for some reason the promise never resolves.
In order to showcase that I need to:

Switch context to installed service worker from devtools console dropdown
Call skipWaiting and expect the promise to be resolved

self.skipWaiting().then(args => console.log('installed', args))

Nothing is printed in the console meaning that the promise is never resolved
If in devtools Application -> Service Worker send a skipWaiting message by clicking Push the promise will be resolved printing out installed, undefined

My service worker file is called service-worker.js and it never been renamed. Also I'm not using any custom waitUntil and it seems imported workbox version does not either https://storage.googleapis.com/workbox-cdn/releases/4.3.1/workbox-sw.js

It turned out that introducing in-flight requests after calling skipWaiting causes them on Chrome to not to be properly resolved making waiting sw to not to be able to activate before the timeout is triggered.

@valgussev I've been experiencing essentially the same problem you outlined.
Did you come up with a solution to consistently not have skipWaiting interfere with in-flight requests?
I wanted to allow users to initiate the skipWaiting process on the waiting service worker, but I got inconsistencies where sometimes skipWaiting would work and other times it would never leave the waiting stage. I tried adding an exponential backoff on calling skipWaiting to try and avoid interfering with in-flight requests, but that didn't work.
I ended up having to go the skipWaiting-on-install route and reload the clients when a new controller is detected. Less ideal but it was the most consistent in my testing.

Unfortunately we were not able to dig fully enough into the issue in order to understand the root causes, what we ended up doing is moving all the network related logic before posting skipWaiting trigger message to service worker.

Gotcha, thanks for the info!

@valgussev I've been experiencing essentially the same problem you outlined.
Did you come up with a solution to consistently not have skipWaiting interfere with in-flight requests?
I wanted to allow users to initiate the skipWaiting process on the waiting service worker, but I got inconsistencies where sometimes skipWaiting would work and other times it would never leave the waiting stage. I tried adding an exponential backoff on calling skipWaiting to try and avoid interfering with in-flight requests, but that didn't work.
I ended up having to go the skipWaiting-on-install route and reload the clients when a new controller is detected. Less ideal but it was the most consistent in my testing.

I'm currently doing the same but it refreshes the page out of the blue after a while sometimes.
@valgussev any clues if using Workbox v5 could help here? I'm currently using v4 and I don't know if v5 would somehow help (I don't see how to be honest but it doesn't hurt to ask 😅)

sorry, I don't have experiences with the latest workbox version. The refresh you are referencing can also be due to a timeout mentioned above.

sorry, I don't have experiences with the latest workbox version. The refresh you are referencing can also be due to a timeout mentioned above.

Yep, that is what I'm thinking =[

I see the same thing. Service worker doesn't update even though skipWaiting is called, no other tabs open, no waitUntil.

If anyone googles this issue 👆 and gets here, this happens when you call self.skipWaiting on the already activated (i.e. old) service worker instead of the installed and waiting (i.e. new) service worker.
AFAIK it is not possible to activate the newly installed service worker from within the old one, but you can send the new service worker a message from the old one like so:
self.registration.waiting.postMessage({type:'SKIP_WAITING'})

However, you probably want to send this message from a client (i.e. a web page) instead. In this case make sure you are sending the correct registartion the message.

By the way, workbox-window v6 has a new helper method, messageSkipWaiting(), that can be used from a web page client and will always use postMessage({type: 'SKIP_WAITING'}) to the correct service, waiting service worker instance.

I see the same thing. Service worker doesn't update even though skipWaiting is called, no other tabs open, no waitUntil.

If anyone googles this issue 👆 and gets here, this happens when you call self.skipWaiting on the already activated (i.e. old) service worker instead of the installed and waiting (i.e. new) service worker.
AFAIK it is not possible to activate the newly installed service worker from within the old one, but you can send the new service worker a message from the old one like so:
self.registration.waiting.postMessage({type:'SKIP_WAITING'})

However, you probably want to send this message from a client (i.e. a web page) instead. In this case make sure you are sending the correct registartion the message.

This did the trick for me!


AttributeError: module 'openai' has no attribute 'error'

Traceback (most recent call last):
  File "/llmvm_testing/test.py", line 2, in <module>
    from llm_vm.client import Client
  File "/LLM-VM/src/llm_vm/client.py", line 6, in <module>
    from llm_vm.completion.optimize import LocalOptimizer
  File "/LLM-VM/src/llm_vm/completion/optimize.py", line 16, in <module>
    from llm_vm.completion.data_synthesis import DataSynthesis
  File "/LLM-VM/src/llm_vm/completion/data_synthesis.py", line 13, in <module>
    class DataSynthesis:
  File "/LLM-VM/src/llm_vm/completion/data_synthesis.py", line 57, in DataSynthesis
    @backoff.on_exception(backoff.expo, openai.error.RateLimitError)

It appears a recent (last few days) change to OpenAI's api is causing an error in the code after first downloading a model configs:
src/llm_vm/completion/data_synthesis.py: line 57
 @backoff.on_exception(backoff.expo, openai.error.RateLimitError)
    def generate_examples(self, final_prompt, openai_key, example_delim="<END>", model="gpt-4", max_tokens=1000, temperature=1, completion=None, call_big_kwargs={}):

The latest openai api removes the "error" intermediary, and references openai.RateLimitError like so.

Hey @bpanahij thanks for highlighting this error. Seems to be an issue with the backoff lib. Will look into it asap.

@bpanahij were you running data_synthesis.py

Got it you are running test.py

It's a relatively small fix to correct the reference to RateLimitError. It of course doesn't address the underlying backoff issue.

Closed by #392


sync downstream main with upstream main branch

sync downstream main with upstream main branch

/assign @nixpanic @Rakshith-R

/lgtm


refactor(lib): allow tree-shaking the prototype input setter

https://github.com/ROpdebee/mb-userscripts/pull/473#issuecomment-1153312621
Probably not worth a new version, but skip cd will cause useless updates to be made to 2 of the 3 TS scripts on the next PR anway, and it'll bother me otherwise.
+ A small fix for split links and refactoring to use logFailure, not worth separate PRs and deployments IMO.

/deploy-preview

I don't know if you could also use that as I'm not 100% sure whether you have any (userscript) modules with side-effects.

The update notifications module (which we inject while building) is one with side effects. I'm also not sure about the 3d party dependencies that get bundled into the scripts, they might have side effects. While we could mark individual modules as having side effects in the rollup config, I'm a bit afraid that this could cause issues in the future (e.g. we add a new dependency which has side effects, like core-js polyfills, and rollup just eliminates the import).
In an ideal world, there'd be some TypeScript syntax to mark stuff as pure (like C++ const methods), which the TS compiler would verify. That information could be used in a bundler for tree-shaking, but alas, as far as I know, such syntax does not exist.


index.js doesn't export the  method  'Controllers.load' in './lib/controllers'

I use ts-express-decorators like a  npm package , but it doesn't export the initialise method 'Controllers.load'  in './lib/controllers', I can't initialise express  routes on the outside of this package.

Hello myfjdthink,
Ts-express-decorators is flagged as beta actually and the readme.md isn't updated to use this package correctly. But you have an example of use in example folder. You can try this example :
Your server.ts
import * as Express from "express";
import * as Logger from "log-debug";
import {ServerLoader} from "ts-express-decorators/server-loader";
import Path = require("path");

export class ExampleServer extends ServerLoader {
    /// In your constructor set the global endpoint and configure the folder to scan the controllers.
    /// You can start the http and https server.
    constructor() {
        super();

        let appPath = Path.resolve(__dirname);

        this.setEndpoint('/rest')
            .scan(appPath + "/controllers/**/**.js") // Component scan like Spring MVC. Specify you controllers directory
            .createHttpServer(8000)
            .createHttpsServer({
                port: 8080
            });

    }

    /// This method let you configure the middleware required by your application to works.
    public importMiddlewares(): ExampleServer {
        let morgan = require('morgan'),
            cookieParser = require('cookie-parser'),
            bodyParser = require('body-parser'),
            compress = require('compression'),
            methodOverride = require('method-override'),
            session = require('express-session');

        this
            .use(morgan('dev'))
            .use(ServerLoader.AcceptMime("application/json"))
            .use(bodyParser.json())
            .use(bodyParser.urlencoded({
                extended: true
            }))
            .use(cookieParser())
            .use(compress({}))
            .use(methodOverride());

        return this;
    }

    /// Customize this method to manage all errors emitted by the server and controllers.
    public onError(error: any, request: Express.Request, response: Express.Response, next: Function): void {

        Logger.error(error);

        response
            .status(500)
            .send('Internal Server error');

        next();
    }

   /// Set here your check authentification strategy.
    public isAuthenticated(request: Express.Request, response: Express.Response, next: Function): boolean {

        return true;
    }

    // Start your server. Enjoy it !
    static Initialize(): Promise<any> {

        Logger.info('Initialize server');

        return new ExampleServer()
            .start()
            .then(() => {
                Logger.info('Server started...');
            });
    }
}

And create a calendarCtrl.ts in your controllers directory :
import {Controller, Get, PathParams, Request, Response} from "ts-express-decorators";
import * as Promise from "bluebird";
import * as Express from "express";

interface ICalendar{
    id: string;
    name: string;
}
/**
 * Add @Controller annotation to declare your class as Router controller. The first param is the global path for your controller.
 * The others params is the controller depedencies.
 *
 * In this case, EventCtrl is a depedency of CalendarCtrl. All routes of EventCtrl will be mounted on the `/calendars` path.
 */
@Controller("/calendars", "EventCtrl")
export class CalendarCtrl {

    /**
     * Example of classic call. Use `@Get` for routing a request to your method.
     * In this case, this route "/calendar/classic/:id" are mounted on the "rest/" path (call /rest/calendar/classic/:id
     * to test your service).
     *
     * By default, the response is sent with status 200 and is serialized in JSON.
     *
     * @param request
     * @param response
     * @returns {{id: any, name: string}}
     */
    @Get('/classic/:id')
    public findClassic(request: any, response: any): ICalendar {

        return {id: request.params.id, name: "test"};
    }

    /**
     * Example of customised call. You can use decorators to inject express object like `response` as `@Response`,
     * `request` as `@Request` and `next` as `@Next`.
     *
     * Another decorator are available to access quickly to the pathParams request. `@PathParams` take an expression in
     * first parameter.
     *
     * @param request
     * @param id
     * @returns {{id: any, name: string}}
     */
    @Get('/annotation/test/:id')
    public findWithAnnotation(
        @Request() request,
        @PathParams('id') id
    ): ICalendar {

        Logger.debug('ID =>', id, request.params.id);

        return {id: id, name: "test"};
    }

    /**
     * Your method can return a Promise to respond to a request.
     *
     * By default, the response is sent with status 200 and is serialized in JSON.
     *
     * @param request
     * @param id
     * @returns {Promise<ICalendar>}
     */
    @Get('/annotation/promised/:id')
    public findWithPromise(
        @Request() request,
        @PathParams('id') id
    ): IPromise<ICalendar> {

        Logger.debug('ID =>', id, request.params.id);

        //
        return new Promise<ICalendar>((resolve, reject) => {

            resolve({
                id: id,
                name: "test"
            });
        });
    }

    /**
     * Your method can return a Promise to respond to a request.
     *
     * By default, the response is sent with status 200 and is serialized in JSON.
     *
     * @param request Express request
     * @param response Express response
     * @param id
     * @returns {Promise<ICalendar>}
     */
    @Get('/annotation/status/:id')
    public findAndChangeStatusCode(
        @Request() request: Express.Request,
        @Response() response: Express.Response,
        @PathParams('id') id: string
    ): IPromise<ICalendar> {

        Logger.debug('ID =>', id, request.params.id);
        //
        return new Promise<ICalendar>((resolve, reject) => {

            response.status(202);

            resolve({
                id: id,
                name: "test"
            });
        });
    }
}

I hope it'll be work for you :)
@++

It worked! thanks lots.

nice :)


Wait for a valid endpoint value in svc describe output

When oc describe svc/heketi is performed, we can have output as shown below
Name:                   heketi
Namespace:              storage-project
Labels:                 glusterfs=heketi-service
                        template=heketi
Selector:               glusterfs=heketi-pod
Type:                   ClusterIP
IP:                     <IP_ADDRESS>
Port:                   heketi  8080/TCP
Endpoints:
Session Affinity:       None
No events.

Here value for Endpoints: is "" and not "", we need to wait until a valid string appears here before proceeding to confirm deployment of heketi.

@raghavendra-talur @MohamedAshiqrh Regarding this, I'd like to have a brief discussion: Can we get rid of using the route for the oc deployment? The Endpoint from the Service seems to be just as valid in OpenShift as it is in Kubernetes, and would cleanup the code significantly.


win8 pyspider HTTP 599: Resolving timed out after 20000 milliseconds

Hi binux:
the same code.
我在我本机win8上跑，就报这个错
[E 161009 16:20:38 base_handler:195] HTTP 599: Resolving timed out after 20000 milliseconds
Traceback (most recent call last):
File "c:\users\lyu\anaconda2\lib\site-packages\pyspider\libs\base_handler.py", line 188, in run_task
result = self._run_task(task, response)
File "c:\users\lyu\anaconda2\lib\site-packages\pyspider\libs\base_handler.py", line 167, in _run_task
response.raise_for_status()
File "c:\users\lyu\anaconda2\lib\site-packages\pyspider\libs\response.py", line 190, in raise_for_status
raise http_error
HTTPError: HTTP 599: Resolving timed out after 20000 milliseconds
但是在ubuntu上就没有任何问题。请问是什么原因呢？是不是win8上的配置要改什么？
谢谢！

It's DNS error, does it happen on every websites?

yes, I have tried some websites, such as baidu, scrapy.org. But the error is the same mistake.

Do you have proxy globally set on windows? Can you crawl websites with IP like http://<IP_ADDRESS>/ (it should return 404)

我没有设置代理。
我试了您说的这个IP  确实返回了404
我又试了一个我们公司的ip，返回的是没有权限。我用的google chrome

In my office, one colleague use win7. He don't meet this error.

You can access website via IP?
There is something wrong with DNS -> libcurl -> pyspider on your system, but I don't know the exact issue. You could investigate deeper through this path.

OK, thank you ! I will have a try.

I have the same issue.


University of Scranton - scranton.edu

University of Scranton - Scranton, PA

Link to Computing Sciences program (4 year B.S.)
Link to Software Engineering M.S. (2 year M.S.)
Link with Email info

@JVasky Pull request merged. Thank you!


Fix README.md Image Display and Update Data Availability Reference

This PR addresses an issue with the display of the NEAR Protocol logo in the README.md. The image link was not properly formatted, which caused the logo not to appear as intended. The correction involved fixing the quotation mark at the end of the image source URL, ensuring it uses the standard straight quotation mark.
Additionally, this PR updates the data availability information, replacing Celestia with NEAR to reflect the correct version. These changes improve the documentation's accuracy and the overall presentation of the repository. Feel free to go through the README.md file to ensure that everything is correct @dndll and @firatNEAR.

LGTM


Possible bug: can't interact with pdbpp prompt

Hi, I'm attempting to use pdbpp to debug a dockerized python-flask application.  I was able to access the pdbpp prompt by setting a breakpoint with pdbpp.set_trace() and running this command in terminal:
docker-compose run --rm -p 3000:3000 myApp flask run --host=<IP_ADDRESS> --port=3000
When I attempt to type a command in the pdbb prompt, it fails to process the command.  See below for an example:
[34] > MyApp/app/main/forms.py(35)FindUserForm()
-> name = StringField(
(Pdb++) list
*** NameError: name 'lt' is not defined
(Pdb++) l
*** NameError: name 'lt' is not defined
(Pdb++) list

I'm using a virtualenv with Python 3.7.1, pdbpp 0.9.15 and Docker version 18.09.03.  My OS is Ubuntu 18.0.4.
I had a similar error when using ipdb and had switched to pdbpp after reading this stackoverflow thread.
I tried adding the below lines to the myApp service in my docker-compose.yml file
     stdin_open: true
        tty: true

Unfortunately, it didn't resolve the issue.  Have other users seen this error when debugging with pdbpp?

by setting a breakpoint with pdbpp.set_trace()

That would be pdb.set_trace(), right?
Try using -it with docker-run to pass stdin.
From the example above it looks like only some of it is arriving/handled, e.g. "list" becomes "lt".

Ah, this is docker-compose.  Try directly with docker maybe.
I've not tried to reproduce it myself yet, but should be easy I guess.

Correct, it was pdb.set_trace().  Thanks for the correction.
I removed the below lines from the docker-compose.yml
stdin_open: true
tty: true

Then I switched to pdb instead of pdbpp and I can now successfully debug the app.  However, I switched back to pdbpp and saw the same issue on my second interaction with the debugger prompt.
[34] > /usr/src/app/MyApp/app/main/forms.py(35)FindUserForm()
-> name = StringField(
(Pdb++) list
[34] > /usr/src/app/MyApp/app/main/forms.py(36)FindUserForm()
-> 'name', default='', validators=[Regexp('\w*'), Length(max=50),
(Pdb++) continue
*** NameError: name 'litcnnecniu' is not defined

Thanks for the help, @blueyed.  I am going to stop debugging this and switch to using pdb instead of pdbpp.  I'll leave the issue open in case anyone wants to investigate this behavior, but I also understand if the repo owner closes the issue.

Does it also happen with pdb++ installed and using pdb.pdb.set_trace() (this goes through to the original pdb then)?
It really looks like two processes are fighting over stdin there.. "litcnnecniu" is just parts of the words from your commands (and the other used the Enter probably).

Yes, I get the same error when I have pdb++ installed and use pdb.pdb.set_trace().
You are correct that two processes were fighting over stdin.  After debugging with some other folks, I learned that the bug occurs when the breakpoint is placed in a class, such as FindUserForm() in forms.py, but not when the breakpoint is in a view, like the view for the /find route in views.py.  (Context: When I was able to successfully debug with pdb, I happened to be placing a breakpoint in a view.)
Unlike views, the class is loaded at import time, which starts a pdb process.  Then, a second pdb process is triggered by the werkzeug reloader.  Since these two processes are competing over the stdin, neither can properly process the input.
You can get around the bug by setting FLASK_DEBUG: 0, as that disables the werkzeug reloading.

Closing, feel free to followup still of course.

Are both pdb processes pdb++ then, or does werkzeug reloader use the real pdb (or its own maybe even)?

When I had pdb++ installed and interacted with the debugger prompt, it appeared to be pdb++, as seen below.
[34] > /usr/src/app/MyApp/app/main/forms.py(35)FindUserForm()
-> name = StringField(
(Pdb++)

This makes me think that both processes were pdb++.  If you want me do further investigation to confirm this, please let me know what steps you consider necessary.

I could imagine the second instance might not be displaying its/any output, i.e. stdout is connected to a single instance only.
Anyway, I am glad you got it figured out.  Thanks for the report and details you've provided!

I've noticed a similar issue with django-extensions / django-pdb: you basically should disable threading in the server when using pdb (https://github.com/django-extensions/django-extensions/pull/1360).

Coming back to this once more: the GLOBAL_PDB is the issue after all.. it should not be shared across threads in the first place.
https://github.com/antocuni/pdb/pull/202 should fix this.


(PUP-6427) Prevent AppVeyor password length fails

When temp users are created for the sake of tests, they are not
assigned a password, and this causes the ADSI types to create a blank
password for the given user.  At certain times within AppVeyor,
machines are being used to run tests that have a minimum password
policy in place.  This causes test failures for not satisfying the
systems password complexity policy.
Generate random passwords in these instances, ensuring that the
string contains 3 of 5 character classes - upper case, numeric and
additional non-alphanumeric character.

Paired-with: Glenn Sarti<EMAIL_ADDRESS>Daniel Lu<EMAIL_ADDRESS>

CLA signed by all contributors.

👍  for merge

👍


Dask implementation of discrete sine transformation

Although the discrete sine transformation is implemented in Scipy, currently there is no dask implementation.
Could this be something to be added to the dask API?

As with FFT, every output point depends on every input point in the axis of interest. This is not a nice case for parallel/out-of-core execution, and hard to implement. The naive one-shot transform can be implemented in chunks along axes that are not chunked, and anything else would take some development.

I've contributed to developing a package that takes the axes aware FFT using the dask.array.fft so it would be nice to even have the one-shot transformation of DST so that I can incorporate it into our xrft package.

@martindurant: often we want to do many FFT / DST in parallel, and we don't care about taking the transforms over chunked dimensions. Dask and its array FFT module is extremely useful for this.

@roxyboy you might want to take a look at https://github.com/dask/dask/blob/master/dask/array/fft.py to see what a solution here might look like.
It's not clear whether scipy functions like this are in-scope for dask.array.  I can't think of a better place for them at the moment though.
cc @jakirkham

In that case, I would think that the current fft code should port very nicely to other similar transforms.

Personally would be happy to have dct, dst, idct, and idst in dask.array.fft. We would likely need to make them optional as I don't think we want to make scipy a requirement of dask.array. Though think it should be straightforward to add this functionality to Dask if someone would like to try. Would be happy to review such a PR. :)

Actually we already have a soft scipy dependency in dask.array.fft. So this is easy to build on.
Were you planning on submitting a PR, @roxyboy?

@jakirkham I currently don't have much bandwidth to expand to other projects so it'd be great if another person could do the PR but if not, I can try working on it slowly.


Include support for changing the schema name

It would be great if we can change the schema name for all ASP.Net Identity tables.
I'm currently facing this problem where I want to have all the Identity tables in the auth schema and the rest of my application tables will go in the app schema.

This is now supported in Entity Framework 7


Recent Dependabot updates for Docker containers offer 1.x RC1 as an update for stable containers

These PRs were submitted properly:

#535
#539

These were not:

#536
#537
#538
#540

Attempt to set version constraints to exclude non-stable update, then submit upstream bug report if that doesn't work out.

This worked for limiting the oldstable container update:
https://github.com/atc0005/go-ci/blob/a688560df95e27f72583fe1a19e29fb7374ea67e/.github/dependabot.yml#L70-L79

Unfortunately Dependabot doesn't care for the syntax I used in #543:
The property '#/updates/3/ignore/0/versions' includes invalid version requirements for a docker ignore condition
The property '#/updates/4/ignore/0/versions' includes invalid version requirements for a docker ignore condition
The property '#/updates/5/ignore/0/versions' includes invalid version requirements for a docker ignore condition
The property '#/updates/6/ignore/0/versions' includes invalid version requirements for a docker ignore condition
The property '#/updates/7/ignore/0/versions' includes invalid version requirements for a docker ignore condition
The property '#/updates/8/ignore/0/versions' includes invalid version requirements for a docker ignore condition

Upstream bug report:
https://github.com/dependabot/dependabot-core/issues/4798

Upstream feature request to help make the intended behavior clearer in the Dependabot config file:
https://github.com/dependabot/dependabot-core/issues/4800

These PRs were submitted properly:

docker: bump golang from 1.16.14 to 1.16.15 in /oldstable #535
docker: bump i386/golang from 1.17.7-alpine3.14 to 1.17.8-alpine3.14 in /stable/build/alpine-x86 #539

These were not:

docker: bump golang from 1.17.7-alpine3.14 to 1.18rc1-alpine3.14 in /stable/build/alpine-x64 #536
docker: bump golang from 1.17.7 to 1.18rc1 in /stable/build/debian #537
docker: bump golang from 1.17.7 to 1.18rc1 in /stable/combined #538
docker: bump golang from 1.17.7 to 1.18rc1 in /stable/build/mirror #540

The invalid PRs were auto-closed when valid replacements were generated. I've since reverted the changes to the Dependabot configuration while attempting to resolve this. Evidently the problem lay solely with Dependabot and not the associated config settings.


bugfix:OSIS-15 Create S3 Credentials not returning cd_tenant_id

Hello saitharunthodupunuru,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.
Status report is not available.

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

2 peers

Codecov Report

Merging #62 (7debd7e) into development/1.0 (07424d9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##             development/1.0      #62      +/-   ##
=====================================================
+ Coverage              86.56%   86.59%   +0.02%
  Complexity               234      234
=====================================================
  Files                     16       16
  Lines                   1057     1059       +2
  Branches                  77       77
=====================================================
+ Hits                     915      917       +2
  Misses                    85       85
  Partials                  57       57

Impacted Files
Coverage Δ

.../com/scality/osis/utils/ScalityModelConverter.java
95.21% <ø> (ø)

...lity/osis/service/impl/ScalityOsisServiceImpl.java
88.86% <100.00%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07424d9...7debd7e. Read the comment docs.

/approve

In the queue
The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.
The changeset will be merged in:

:heavy_check_mark: development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.
IMPORTANT
Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.
The following options are set: approve

I have successfully merged the changeset of this pull request
into targetted development branches:

:heavy_check_mark: development/1.0

Please check the status of the associated issue OSIS-15.
Goodbye saitharunthodupunuru.


There should be a direct way to get shadowRoot of an element

The problem
Selenide includes strangely named shadowCss() selector, but it cannot be used to access element's shadowRoot itself, only search for elements from within of the shadowRoot.
I propose to rename shadowCss() to e.g. inShadowOf("sub-selector", "shadow parent selector"), but also to introduce SelenideElement.shadowRoot() for consistency with DOM API, so it would be possible to select an element, resolve it's shadowRoot and then continue searching using find() with any possible means, e.g. $("web-component").shadowRoot().find(withText("Hello"))
Tell us about your environment

Selenide Version: 5.23.0

@angryziber We can add method shadowRoot(), but it will not help because search by XPath doesn't work inside of a shadow root. See bug https://github.com/SeleniumHQ/selenium/issues/5869.
For example,

$("web-component").shadowRoot().find("div.active")  --  works
$("web-component").shadowRoot().find(withText("Hello"))  --  fails with InvalidSelectorException: invalid selector: Unable to locate an element with the xpath expression ... NotSupportedError: Failed to execute 'evaluate' on 'Document': The node provided is '#document-fragment', which is not a valid context node type.

UPD Method $.shadowRoot() was removed in Selenide 6.1.0,
See PR https://github.com/selenide/selenide/pull/1641 and https://github.com/selenide/selenide/issues/1640.


Two instances of vscode are opened, when opening multi root folders from the command line

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:32:36.023Z)
OS Version: Windows_NT x64 6.1.7601
Extensions: Extensions are disabled

Steps to Reproduce:
Run code with "code c:\ c:\windows"
Sometimes it opens just one instance of code, sometimes it opens two instances

@MofX if you open multiple folders from the command line like that we will automatically turn the window into an "Untitled Workspace" that will only go away if you close the window (then you get prompted to either save the workspace or not). It looks like in your case you always have the previous untitled workspace restoring, could that be true?

Actually yes, this could be true. But what if I don't want to save the workspace? I just want to start code with a bunch of root folders (source folders that are combined by an installer when the product is shipped). I pass the folders to code on the command line, because the selected folders depend on the configuration.
Is there a switch to create a "throwaway workspace" or something like that?

Currently not. Duplicate of https://github.com/Microsoft/vscode/issues/30972