Firebase Error: auth/invalid-api-key, Your API key is invalid, please check you have copied it correctly.

Ionic version:
v1.3.1
AngularFire:
2.0.2
Firebase js:
v3.3.0
Build: 3.3.0-rc.7
Issue:
I am using the correct config keys from Firebase console > Web Setup, all of a sudden my app started throwing error from Firebase as below:
R {code: "auth/invalid-api-key", message: "Your API key is invalid, please check you have copied it correctly."}
Ionic code to login user with firebase email password enabled firebase.auth().signInWithEmailAndPassword()
Expected:
What should be the fix I have checked the API key its same? My app was working fine with same source code and API key and now it is just looping the above error in console.

@appplumbr can you point us to your app online if possible? (so we experience the issue)
If you prefer to get private support feel free to use our support channel instead: https://firebase.google.com/support/contact/troubleshooting/

@nicolasgarnier - resolved this myself please go ahead and close this issue

Replaced the API key and it worked

I'm glad things worked out for you!

@nicolasgarnier
Hi Nicolas,
I'm quite new to firebase and would like to use authentication service for Google in a simple Angular2 test app.
But get the error: message: "Your API key is invalid, please check you have copied it correctly."}
I would appreciate if you help me with it. :)
Regards,
Rozita

@nicolasgarnier I am getting these errors and i have checked and checked the API Key (even though i just copied and pasted it). Would could be causing this?
Regards,
Terry

I am also getting the error @terrysmyth is getting.
{code: "auth/invalid-api-key", message: "Your API key is invalid, please check you have copied it correctly."}

Im getting the same error.... im using react-native... @terrysmyth @eddyekofo94 @nicolasgarnier @ghost

@paloman fixed it by re-copying and pasting my API key, so try that

@eddyekofo94  I did :/ but it didn't work... if you don't mind me asking, are you using the google-services.json file to import the key? or directly through initialize app? also is this a native android app? thanks for all your help

@paloman
Yes I am the google-services.json to import the key, I am using ASP.Net Core. But sorry I don’t know how it is implemented in Android.
I don’t know how it works on Android, if you’re still stuck I can go look it up later.

I am getting this error in core javascript.

Replaced the API key and it worked

Yes, but where?

Hi team,
I am getting this issue when i deploy... but its working fine with localhost..
Uncaught (in promise): Error: Your API key is invalid, please check you have copied it correctly.
please help me to deploy this app successfully.
i am in Angular 6 + firebase, My package.json is below
{
"name": "ceybit-p2p",
"version": "0.0.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e"
},
"private": true,
"dependencies": {
"@agm/core": "^1.0.0-beta.2",
"@amcharts/amcharts4": "^4.0.7",
"@angular/animations": "^6.0.3",
"@angular/common": "^6.0.3",
"@angular/compiler": "^6.0.3",
"@angular/core": "^6.0.3",
"@angular/forms": "^6.0.3",
"@angular/http": "^6.0.3",
"@angular/platform-browser": "^6.0.3",
"@angular/platform-browser-dynamic": "^6.0.3",
"@angular/router": "^6.0.3",
"@ng-bootstrap/ng-bootstrap": "^1.0.0-beta.5",
"@ngrx/core": "^1.2.0",
"@ngrx/store": "^6.1.2",
"@ngrx/store-devtools": "^6.1.2",
"@nicky-lenaers/ngx-scroll-to": "^0.6.0",
"@swimlane/ngx-datatable": "^11.0.4",
"angular-calendar": "^0.23.7",
"angular-tree-component": "^7.1.0",
"angular2-chartjs": "^0.4.1",
"angular2-datatable": "^0.6.0",
"angular2-lightbox": "^1.3.0",
"angularfire2": "^5.0.0-rc.12",
"bootstrap": "^4.1.3",
"c3": "^0.4.18",
"core-js": "^2.5.4",
"css-animator": "^2.1.1",
"d3": "^4.12.0",
"famfamfam-flags": "^1.0.0",
"feather-icons-sass": "^1.0.0",
"firebase": "^5.4.2",
"font-awesome-scss": "^1.0.0",
"hammerjs": "^2.0.8",
"jquery": "^3.3.1",
"ng-click-outside": "^3.0.0",
"ng-select": "^1.0.0-rc.3",
"ng2-archwizard": "^2.1.0",
"ng2-dragula": "^1.5.0",
"ng2-file-upload": "^1.2.1",
"ng2-google-charts": "^3.3.0",
"ng2-nouislider": "^1.7.7",
"ng2-toasty": "^4.0.3",
"ng2-ui-switch": "^1.0.2",
"ng2-validation": "^4.2.0",
"ngx-bar-rating": "^1.1.0",
"ngx-carousel": "^1.3.5",
"ngx-chips": "^1.5.10",
"ngx-color-picker": "^5.0.4",
"ngx-perfect-scrollbar": "^5.0.1",
"node-sass": "^4.9.4",
"nouislider": "^11.1.0",
"rxjs": "^6.0.0",
"rxjs-compat": "^6.2.1",
"screenfull": "^3.3.2",
"socket.io": "~2.0.3",
"sweetalert2": "^7.31.1",
"zone.js": "^0.8.26"
},
"devDependencies": {
"@angular-devkit/build-angular": "^0.8.3",
"@angular/cli": "~6.0.7",
"@angular/compiler-cli": "^6.0.3",
"@angular/language-service": "^6.0.3",
"@types/jasmine": "~2.8.6",
"@types/jasminewd2": "~2.0.3",
"@types/node": "~8.9.4",
<EMAIL_ADDRESS>"^1.4.32",
"codelyzer": "~4.2.1",
"jasmine-core": "~2.99.1",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~1.7.1",
"karma-chrome-launcher": "~2.2.0",
"karma-coverage-istanbul-reporter": "~2.0.0",
"karma-jasmine": "~1.1.1",
"karma-jasmine-html-reporter": "^0.2.2",
"protractor": "^5.4.0",
"ts-node": "~5.0.1",
"tslint": "~5.9.1",
"typescript": "~2.7.2"
}
}
Thanks.

I have the solution finally, just check how you have imported your firebaseConfig.js where you have initilize your firebase.
most of the case we export default firebaseConfig and import it as a object
import  {firebaseConfig}  from './src/config/FirebaseConfig'; ===== Wrong Order
import  FirebaseConfig  from './src/config/FirebaseConfig'; ===== Correct Order

I already resolved.. thanks for the reply, it was not the case..configuration was not initiated properly in app component.
thanks.

Hello, this is my current config file
`const config = {
apiKey: process.env.API_KEY,
authDomain: process.env.AUTH_DOMAIN,
databaseURL: process.env.DBURL,
projectId: process.env.PID,
storageBucket: process.env.BUCKET,
messagingSenderId: process.env.MSGID
};
export default config;
`
and I am using it like so-
`import firebase from "firebase/app";
import config from "./config";
firebase.initializeApp(config);`
When I use the key string directly in the config file it works but not when it is used as my env variables..

This may or may not be of any use to you, but are the env variables set in a .env file in the root dir?
@bhaskar-nair2
My firebase.js
const config = {
  apiKey: process.env.REACT_APP_API_KEY,
  authDomain: process.env.REACT_APP_AUTH_DOMAIN,
  databaseURL: process.env.REACT_APP_DATABASE_URL,
  projectId: process.env.REACT_APP_PROJECT_ID,
  storageBucket: process.env.REACT_APP_STORAGE_BUCKET,
  messagingSenderId: process.env.REACT_APP_MESSAGING_SENDER_ID,
};

.env file
REACT_APP_API_KEY="key"
REACT_APP_AUTH_DOMAIN="domain"
REACT_APP_DATABASE_URL="url"
REACT_APP_PROJECT_ID="id"
REACT_APP_STORAGE_BUCKET="bucket"
REACT_APP_MESSAGING_SENDER_ID="id"

Had the same problem while building a react-native app:
Before:
export **const** firebaseConfig = {     apiKey: "",     etc etc   };
After:
export **default** firebaseConfig = {     apiKey: "",     etc etc   };

Replaced the API key and it worked

Where shuld I reset the API? I never assigned any authentication API anywhere in Firebase Console.
I'm using Flutter and received this error after migrate to AndroidX and switch to another notebook (the notebook where I did migration was working perfectly fine).

@bhaskar-nair2 what was your solution?  It seems that it's not seeing my .env file

What I did
const firebaseConfig = {apiKey: '', etc, etc}
then I exported it
export deafault firebaseConfig
import
import firebaseConfig from './firebase'
This was in Angular 8

for my case I needed to restart my dev server since I entered them while it was already running

I have the solution finally, just check how you have imported your firebaseConfig.js where you have initilize your firebase.
most of the case we export default firebaseConfig and import it as a object
import {firebaseConfig} from './src/config/FirebaseConfig'; ===== Wrong Order
import FirebaseConfig from './src/config/FirebaseConfig'; ===== Correct Order

This is the main problem. I was also trying to load my firebaseConfig object at runtime, using the import() function, at the time of initializing my FirebaseApp. Now I don't have this issue any more after importing the firebaseConfig object at the top of the file, as described by @akashrauniyar35

I solved it moving env variables from
now.json -> env: {}
to .env file

This may or may not be of any use to you, but are the env variables set in a .env file in the root dir?
@bhaskar-nair2
My firebase.js
const config = {
  apiKey: process.env.REACT_APP_API_KEY,
  authDomain: process.env.REACT_APP_AUTH_DOMAIN,
  databaseURL: process.env.REACT_APP_DATABASE_URL,
  projectId: process.env.REACT_APP_PROJECT_ID,
  storageBucket: process.env.REACT_APP_STORAGE_BUCKET,
  messagingSenderId: process.env.REACT_APP_MESSAGING_SENDER_ID,
};

.env file
REACT_APP_API_KEY="key"
REACT_APP_AUTH_DOMAIN="domain"
REACT_APP_DATABASE_URL="url"
REACT_APP_PROJECT_ID="id"
REACT_APP_STORAGE_BUCKET="bucket"
REACT_APP_MESSAGING_SENDER_ID="id"

Thanks, this is exactly my problem. I mistakenly put the .env file under src folder.

If anyone having problem with the .env file in react project
2 things to keep in mind

Make extra sure that .env with key=value pairs is located at the root of the react project

After creating the .env RESTART dev server so that webpack picks up the new project changes. It will rebuild the project taking into accouunt the newly created .env  file. Otherwise webpack has no information that you created this file.

Replaced Api key in the json file and It worked, thnaks everyone

Another gotcha which got me:
My .env file is APPENDED in the pipeline. I forgot to add a newline (\n) to the end of the .env files that are already in my repo when I added something to it.
So, if you're appending your .env files in your pipelines which are already slightly populated in the repo itself, end in a newline.
In fact, end every file always with a newline. It's a convention, and ignoring it apparently leads to bugs like this.

Anyone facing this error:
Notice one thing before importing any module you have to export a module.
ex - const config = require('../util/config');
to run successfully your config details should be exported properly
module.exports  = {
  apiKey: "YOUR_KEY",
  authDomain: ".........",
  databaseURL: ".......",
  projectId: "....",
  storageBucket: "........",
  messagingSenderId: "........",
  appId: "APP_ID",
  measurementId: "..........."
};

Anyone facing this error:
SOLUTION
Notice one thing before importing any module you have to export a module.
ex - const config = require('../util/config');
to run successfully your config details should be exported properly
module.exports  = {
  apiKey: "YOUR_KEY",
  authDomain: ".........",
  databaseURL: ".......",
  projectId: "....",
  storageBucket: "........",
  messagingSenderId: "........",
  appId: "APP_ID",
  measurementId: "..........."
};

Thanks. It works (Firebase + NodeJs)

I have the solution finally, just check how you have imported your firebaseConfig.js where you have initilize your firebase.
most of the case we export default firebaseConfig and import it as a object
import {firebaseConfig} from './src/config/FirebaseConfig'; ===== Wrong Order
import FirebaseConfig from './src/config/FirebaseConfig'; ===== Correct Order

saved me !!!! phew !!

Hello everyone
I am actually having this problem for some reason
firebase works locally but once deployed I get this error {code: "auth/invalid-api-key", message: "Your API key is invalid, please check you have copied it correctly."}
no really sure what to do?
here is my config file
import app from 'firebase/app'
import 'firebase/storage'

const config = {
    apiKey: process.env.REACT_APP_API_KEY,
    authDomain: process.env.REACT_APP_AUTH_DOMAIN,
    databaseURL: process.env.REACT_APP_DATABASE_URL,
    projectId: process.env.REACT_APP_PROJECT_ID,
    storageBucket: process.env.REACT_APP_STORAGE_BUCKET,
    messagingSenderId: process.env.REACT_APP_MESSAGING_SENDER_ID,
};

const firebase = app.initializeApp(config)

export default firebase

and here is my .env.development
REACT_APP_API_KEY=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_AUTH_DOMAIN=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_DATABASE_URL=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_PROJECT_ID=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_STORAGE_BUCKET=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_MESSAGING_SENDER_ID=xxxxxxxxxxxxxxxxxxxxxx

and I am importing the config file correctly
import firebase from './index'

My .env was in my /src directory and not the root 🤦🏾♂

I had the same issue. I solved it by doing:

Make sure that your filename is .env.local instead of env.local (that dot is a lot imp :P).
Your env file should be stored in root directory of your project instead of src or any other folder.

@pulkit2001
i moved .env file to root directory but still facing an error..
auth/invalid-api-key, Your API key is invalid, please check you have copied it correctly.

Hello everyone,
I had the same problem and had made mistakes.
First of all, in my .env.development file I had written the api key in quotes, in addition, at the end of each line I had placed a comma.
Of course you have to restart the server for the environment variables to change.
I hope I have helped something.

Check out this article, it might help: https://gabrielwadi.medium.com/how-to-fix-firebase-api-key-not-valid-error-56896c7ba87a

3 SOLUTIONS

Make sure .env file is located at root of project (not in src or public folder)
after moving the file restart the development server

When calling and referencing the firebase file in different modules, beware of calling objects inside of objects when referencing the database or authentication files.

use " import firebase from 'firebase/app' " instead of " import firebase from 'firebase' "

The solution below fixed my issue: If you are using React Native
import {API_URL, API_TOKEN} from "@env"

If anyone is still having trouble, what I found to work is initializing an app with a name i.e. not using the "[DEFAULT]" app and passing that app in whenever you require another firebase function. This helps prevent confusion of where which app with which key should be used.
Source of Firebase Javascript Documentation
import firebase from 'firebase';
import firebaseConfig from './firebaseConfig.js'

var app = undefined;
try {  // Check if the app already exists
	app = firebase.app("NewName");
}
catch(e) {
	app = firebase.initializeApp( firebaseConfig , "NewName");
}

console.log( firebase.auth( app ).currentUser  );

Thank you so much @abe157. You just saved me days.

.env.local

For some reason, it worked for me when I changed file's name from .env.local to .env

If you are using React, my problem was that I didn't write .env variables with REACT_APP_(name of the variable)
Pretty funny but at the same time frustrating.

Make sure you are not using quotes or commas in your .env file. I had the same issue, but fixed it after removing quotes

Solution: change the version of google services at project level gradle and sync your project and reinstall.
classpath 'com.google.gms:google-services:4.3.0'

I solved !
1º - I went to 'Project Settings' and there I created an application.
2º - As I was using Docker, my NuxtJS shared the application using my ip, so I put my ip in Firebase's authorized domains.
Even if Dokcer puts my application in the localhost url.

for my case I needed to restart my dev server since I entered them while it was already running

thank you, it was working on my live server but not on localhost but restarting the server resolved my issue, twas this easy

If people are still experiencing this issue, I had the same problem when using a .env.local file for all of the info for firebase what I had to do was stop the test site and restart it again so it realises there's a new .env file I don't know why but it worked so :)

@LeeAndrew14 Suggestion worked for me. Thank you

Hello everyone I am actually having this problem for some reason firebase works locally but once deployed I get this error {code: "auth/invalid-api-key", message: "Your API key is invalid, please check you have copied it correctly."} no really sure what to do?
here is my config file
import app from 'firebase/app'
import 'firebase/storage'

const config = {
    apiKey: process.env.REACT_APP_API_KEY,
    authDomain: process.env.REACT_APP_AUTH_DOMAIN,
    databaseURL: process.env.REACT_APP_DATABASE_URL,
    projectId: process.env.REACT_APP_PROJECT_ID,
    storageBucket: process.env.REACT_APP_STORAGE_BUCKET,
    messagingSenderId: process.env.REACT_APP_MESSAGING_SENDER_ID,
};

const firebase = app.initializeApp(config)

export default firebase

and here is my .env.development
REACT_APP_API_KEY=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_AUTH_DOMAIN=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_DATABASE_URL=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_PROJECT_ID=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_STORAGE_BUCKET=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_MESSAGING_SENDER_ID=xxxxxxxxxxxxxxxxxxxxxx
//everything is correct ! what is going on

and I am importing the config file correctly
import firebase from './index'

I'm having this exact same issue. @HassenH1, were you ever able to fix this?

In case anybody is using Github's action to deploy to Firebase:
You most probably (.git)ignoring the .env file so Github builds your solution without those credentials. My solution was to add SpicyPizza/create-envfile to my workflow, while the ENV config was saved securely in my repo's Actions secrets

In case you are using NextJS be aware that you need to add the NEXT_PUBLIC_ prefix to the .env vars so they are exposed to the browser, your .env.local would look something like this
NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN=something.firebaseapp.com
NEXT_PUBLIC_FIREBASE_PUBLIC_API_KEY=yourapikey
NEXT_PUBLIC_FIREBASE_PROJECT_ID=yourprojectname

when i pulled my repo, there was only a .venv.deploy, adding a .env.local with the correct config fixed my issue

@code-vagabond doesn't seems a good idea to make public your api keys
After spending hours here nothing worked for me except direct adding the string into the firebaseConfig, even checking with console the data as string was there but the sdk continues to complaining and I didn't want to expose my keys on the file.
But actually find a simple way just apiKey: String(process.env.NEXT_PRIVATE_APIKEY),  for some reason even that key being a string before String() now it works.

@octavioamu  hi, yes in my case I only needed my public API key for Firebase initialisation which is obviously ok to share. In your case you are trying to initialise firebase-admin I imagine

@code-vagabond true, Im not using the admin just firestore + auth but yes I guess you are controlling the access via domain allowed, but I prefer to not direct expose it on the code + manage the keys by .env file for dev vs prod scenarios.

In case you are using NextJS be aware that you need to add the NEXT_PUBLIC_ prefix to the .env vars so they are exposed to the browser, your .env.local would look something like this
NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN=something.firebaseapp.com
NEXT_PUBLIC_FIREBASE_PUBLIC_API_KEY=yourapikey
NEXT_PUBLIC_FIREBASE_PROJECT_ID=yourprojectname

thanks!

Hello everyone I am actually having this problem for some reason firebase works locally but once deployed I get this error {code: "auth/invalid-api-key", message: "Your API key is invalid, please check you have copied it correctly."} no really sure what to do?
here is my config file
import app from 'firebase/app'
import 'firebase/storage'

const config = {
    apiKey: process.env.REACT_APP_API_KEY,
    authDomain: process.env.REACT_APP_AUTH_DOMAIN,
    databaseURL: process.env.REACT_APP_DATABASE_URL,
    projectId: process.env.REACT_APP_PROJECT_ID,
    storageBucket: process.env.REACT_APP_STORAGE_BUCKET,
    messagingSenderId: process.env.REACT_APP_MESSAGING_SENDER_ID,
};

const firebase = app.initializeApp(config)

export default firebase

and here is my .env.development
REACT_APP_API_KEY=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_AUTH_DOMAIN=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_DATABASE_URL=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_PROJECT_ID=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_STORAGE_BUCKET=xxxxxxxxxxxxxxxxxxxxxx
REACT_APP_MESSAGING_SENDER_ID=xxxxxxxxxxxxxxxxxxxxxx
//everything is correct ! what is going on

and I am importing the config file correctly
import firebase from './index'

I'm having this exact same issue. @HassenH1, were you ever able to fix this?

same here, any updates on this problem?? @PurplePineapple123

saintaze

Yes thanks saintaze, that worked for me.

Using NextJS with Firebase v9. Here is my solution..
So, I have the same problem with the .env variables not working, but it does work when hard coding the string. I noticed in the .env they are single quoted when evaluated. This is dumb, but I just concatenated an empty string to the end of each process.env.VAR like so:
apiKey: process.env.API_KEY + "";
for me it appears the difference was the api key as a single quote string 'my-key' and a double quote string "my-key". I think appending an empty string to the end is dumb and would love a recommendation.

Thanks @RobLMartin. your hacky solution worked for me...

Thanks @RobLMartin. your hacky solution worked for me...

Wish it wasn’t a thing.

Hello, this is my current config file
const config = {
  apiKey: process.env.API_KEY,
  authDomain: process.env.AUTH_DOMAIN,
  databaseURL: process.env.DBURL,
  projectId: process.env.PID,
  storageBucket: process.env.BUCKET,
  messagingSenderId: process.env.MSGID
};

export default config;

and I am using it like so-
import firebase from "firebase/app";
import config from "./config";

firebase.initializeApp(config);

When I use the key string directly in the config file it works but not when it is used as my env variables..

Hello, this is my current config file
const config = {
  apiKey: process.env.API_KEY,
  authDomain: process.env.AUTH_DOMAIN,
  databaseURL: process.env.DBURL,
  projectId: process.env.PID,
  storageBucket: process.env.BUCKET,
  messagingSenderId: process.env.MSGID
};

export default config;

and I am using it like so-
import firebase from "firebase/app";
import config from "./config";

firebase.initializeApp(config);

When I use the key string directly in the config file it works but not when it is used as my env variables..

I also faced the same problem. When I used the key string directly it works but it didn't work on environment variables.
It shows Uncaught FirebaseError: Firebase: Error (auth/invalid-api-key) error.
But, this error I solved after relocating my .env.local file in the root folder from the src folder.
You could try this way to solve this error.

oooh!!! I restart my project, and it works!

If you're like me, I had this issue when deploying an app to Heroku. There were no issues with my code, it's that Heroku expects you to have your config vars set on the Heroku side, so go into the panel and set your config vars in the Settings section. No need to change code or restart app, just redeploy to Heroku once the config vars are set.

In case you are using NextJS be aware that you need to add the NEXT_PUBLIC_ prefix to the .env vars so they are exposed to the browser, your .env.local would look something like this
NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN=something.firebaseapp.com
NEXT_PUBLIC_FIREBASE_PUBLIC_API_KEY=yourapikey
NEXT_PUBLIC_FIREBASE_PROJECT_ID=yourprojectname

This fixed my Problem!
Thank you @code-vagabond

@code-vagabond doesn't seems a good idea to make public your api keys
After spending hours here nothing worked for me except direct adding the string into the firebaseConfig, even checking with console the data as string was there but the sdk continues to complaining and I didn't want to expose my keys on the file.
But actually find a simple way just apiKey: String(process.env.NEXT_PRIVATE_APIKEY), for some reason even that key being a string before String() now it works.
Another information is this was a problem only with auth sdk, firestore sdk alone works fine without any "hack"

Spent Hours trying all the solutions but surprisingly this worked !!!!

to anyone having issues and the firebaseConfig shows undefined when console logged. ensure you place the .env or .env.local file to the root directory and not the src folder. it should be in the same directory as the package.json

@code-vagabond doesn't seems a good idea to make public your api keys
After spending hours here nothing worked for me except direct adding the string into the firebaseConfig, even checking with console the data as string was there but the sdk continues to complaining and I didn't want to expose my keys on the file.
But actually find a simple way just apiKey: String(process.env.NEXT_PRIVATE_APIKEY), for some reason even that key being a string before String() now it works.
Another information is this was a problem only with auth sdk, firestore sdk alone works fine without any "hack"

Spent Hours trying all the solutions but surprisingly this worked !!!!

Yeah this works perfectly.

I have had this issue with NuxtJS and Vuefire and fixed it by assigning default values in the Vuefire object like so:
  vuefire: {
    config: {
      apiKey: process.env.NUXT_PUBLIC_FIREBASE_API_KEY || "mock_key",
      authDomain: process.env.NUXT_PUBLIC_FIREBASE_AUTH_DOMAIN || "mock_key",
      projectId: process.env.NUXT_PUBLIC_FIREBASE_PROJECT_ID || "mock_key",
      storageBucket:
        process.env.NUXT_PUBLIC_FIREBASE_STORAGE_BUCKET || "mock_key",
      appId: process.env.NUXT_PUBLIC_FIREBASE_APP_ID || "mock_key",
    },
    auth: {
      enabled: true,
    },
  },

Seems that a lot of these errors happen in containerised environments (mine was with Docker/Cloud Run) but I still don't get why when all my variables were properly defined and assigned (either in my .env when testing locally) or in Cloud Run, firebase would still complain if a value didn't exist at build time. The patches described here all coerce what firebase sees as a null value to an empty string. Just strange and slightly beyond me. Anyhoo, hope this can help.

@code-vagabond doesn't seems a good idea to make public your api keys
After spending hours here nothing worked for me except direct adding the string into the firebaseConfig, even checking with console the data as string was there but the sdk continues to complaining and I didn't want to expose my keys on the file.
But actually find a simple way just apiKey: String(process.env.NEXT_PRIVATE_APIKEY), for some reason even that key being a string before String() now it works.
Another information is this was a problem only with auth sdk, firestore sdk alone works fine without any "hack"

Can't believe I ran into this recently too, it was just working fine in react js. This fixed it. Thanks.


Remove unused test directory

No changes needing a change description found.

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Error messages do not wrap

It seems that Superset errors do not wrap (the example is from SQL Lab and thus I'm uncertain how broad of an issue this is) meaning one needs to scroll horizontally in order to parse the message.
Expected results
The error message should wrap to aid with readability.
Actual results
The errors do not wrap.
Screenshots

How to reproduce the bug

Go to SQL Lab
Run an invalid query, i.e., SELECT `1`  if using Presto.
Reduce the width of the browser to ensure that the error overflows.

Environment
master.
Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
N/A.

Mmmh, this one is my bad as I brought the monospace /  wrapping here. Let me see if I can fix this real quick.

here: https://github.com/apache/incubator-superset/pull/11354

@junlincc the action of merging the associated PR will auto-close this issue, reopening until it gets merged


Fix "invalid-name" issue in lessons/lesson_1/main.py

Constant name t doesn't conform to UPPER_CASE naming style
https://codeclimate.com/github/ikostan/pico/lessons/lesson_1/main.py#issue_667aee90a37b760001000048

fixed


Reorganize repository

Hi guys,
After our discussion Monday, I thought that I might be able to help out a little bit with cleaning up/simplifying the repository.
Then it should be easier for you to continue development. I did test locally but it is probably a good idea if one of you also run some tests :-)
You are of course free to accept or decline these updates.
Updates

Renamed CLI command from react-bratus to bratus. Personally, I think this gives a better experience in the terminal. Can easily be undone
Parser classes and the Server class are now part of the packages/cli and are compiled together
Updated the yarn run buildscript. It will now compile the CLI and the React app, then move build files to the cli/bin, and finally link the cli locally for testing.
Remove .DS_Store and lerna-debug.log files + added them to .gitignore.
/binand /build folders are also added to .gitignore. Note: Publishing a new version to npmjs would require the bin folder. Branching out to include the binfolder is required in the process.
Updated README.md to include a section about the development environment + reflect the command change from react-bratus to bratus

Let me know if you have any questions :-)

Hey Stephan.
The changes sound good.
Thanks!

@Evgenios95, If you want to merge then it should be approved :-)

Hey Stephan! We know, I think we will merge it tomorrow. We just needed to
decide how we will approach it ☺
On Tue, 1 Mar 2022 at 21.59, Stephan Boersma @.***>
wrote:

@Evgenios95 https://github.com/Evgenios95, If you want to merge then it
should be approved :-)
—
Reply to this email directly, view it on GitHub
https://github.com/react-bratus/react-bratus/pull/39#issuecomment-1055851297,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN674J243OFCAZSRQ4UVTZTU52AKPANCNFSM5PIKMZ3Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Guys,
There are some issues with this branch. I will close it and open a new one for review.


Add tests for the integration with OpenAI API

We should add tests for the OpenAI API, for instance using the responses framework to mock the response from the OpenAI API.
We can also consider running the examples as integration tests in nightly CI.

I think we could just mock the calls to openai library, right? We shouldn't be needing responses here.


gb_sets not included in benchmarks

Interesting project!
What do you think about making gb_sets part of the benchmarks? I suspect it might yield interesting results on intersection.

@g-andrade I created a branch adding ordsets and gb_sets (unsurprising spoiler: ordsets rock for set operations, map_sets for lookups/inserts). You can check benchmark/otp20 directory for the result.
However it was my first experience with benchee and unfortunately I found a lot of problems with this framework (memory leaks, hanging up, ...); most likely I won't merge this particular PR and will experiment with different benchmarking tools.

Indeed, the results were more or less what I expected :-)
(As for benchee: I didn't run the benchmarks, but I did check the results you committed and some of the comparison pages were huge and very slow to load.)


Math.Sqrt and unsigned integers don't work.

Expected
3

Actual
The call is ambiguous between the following methods or properties: Math.Sqrt(double) and Math.Sqrt(decimal)
Steps To Reproduce
http://deck.net/0d560f85537c64e5fa0f0c2a527dc045
https://dotnetfiddle.net/z8PUpW
using System;

public class Program
{
	public static void Main()
	{
		Console.WriteLine(Math.Sqrt(9u));
	}
}

Hi @michaelcheers,
Thanks for bringing this defect to our attention. We have fixed the issue and submitted pull request #2402 with the changes. Once reviewed and tested, the pull request will be merged into the master branch.

The fix is:

Math.Sqrt(decimal d) is removed because it is not presented in .NET API
Math.Sqrt(int d) is removed because it is not presented in .NET API


Config option to only show errors

Love the extension, I've been using it more and more!
It would be nice if there was a config option to only show errors so the build log doesn't get too busy when there are lots of redirects.

Thank you very much for kind words ❤
But to your question. It is already possible. The extension respects Sphinx logging level during the build.
If you want to mute all the Overwriting 'index.html' with redirect to 'https:/documatt.com/sphinx-themes/index.html'. messages, just add -q (as quiet) to sphinx-build:
sphinx-build -b html -q docs/ build/html

Or, to SPHINXOPTS in Makefile:
SPHINXOPTS    ?= -q

Hey, you are the author of sphinx-sitemap :-) In turn, the extension which I love and use everyday too!

Ah good call, I didn't think about that. I was already using -q in CI to reduce log size and make it easier to spot warnings/errors.
Glad to hear! The work you put into Documatt is inspirational, keep it up!


Deprecated resource: azurerm_app_service_plan

Hi there, I am getting this while running terraform init:
Plan: 1 to add, 0 to change, 0 to destroy.
╷
│ Warning: Deprecated Resource
│
│   with azurerm_app_service_plan.app_service_plan,
│   on main.tf line 152, in resource "azurerm_app_service_plan" "app_service_plan":
│  152: resource "azurerm_app_service_plan" "app_service_plan" {
│
│ The `azurerm_app_service_plan` resource has been superseded by the `azurerm_service_plan` resource. Whilst this resource will continue to be available in the 2.x and 3.x releases it is feature-frozen
│ for compatibility purposes, will no longer receive any updates and will be removed in a future major release of the Azure Provider.
│
│ (and 2 more similar warnings elsewhere)

I  encountered exact same issue running from on local environment, however when I clone the repo in azure cloud cli and ran terraform script, everything worked like charm.

I encountered this issue on azure CLI... after running terraform apply --auto-approve
Warning: Deprecated Resource
│
│   with azurerm_app_service_plan.app_service_plan,
│   on main.tf line 152, in resource "azurerm_app_service_plan" "app_service_plan":
│  152: resource "azurerm_app_service_plan" "app_service_plan" {
│
│ The `azurerm_app_service_plan` resource has been superseded by the `azurerm_service_plan` resource. Whilst this resource will continue to be available in the 2.x and 3.x releases it is
│ feature-frozen for compatibility purposes, will no longer receive any updates and will be removed in a future major release of the Azure Provider.
│
│ (and 7 more similar warnings elsewhere)

I'm also getting this issue
│ Warning: Deprecated Resource
│
│   with azurerm_app_service_plan.app_service_plan,
│   on main.tf line 152, in resource "azurerm_app_service_plan" "app_service_plan":
│  152: resource "azurerm_app_service_plan" "app_service_plan" {
│
│ The `azurerm_app_service_plan` resource has been superseded by the `azurerm_service_plan` resource. Whilst this resource will continue to be available in the 2.x and 3.x
│ releases it is feature-frozen for compatibility purposes, will no longer receive any updates and will be removed in a future major release of the Azure Provider.
│
│ (and 6 more similar warnings elsewhere)
╵
╷
│ Error: creating/updating App Service Plan: (Serverfarm Name "appazgoat12088765-app-service-plan" / Resource Group "azuregoat_app"): web.AppServicePlansClient#CreateOrUpdate: Failure sending request: StatusCode=401 -- Original Error: Code="Unauthorized" Message="This region has quota of 0 instances for your subscription. Try selecting different region or SKU." Details=[{"Message":"This region has quota of 0 instances for your subscription. Try selecting different region or SKU."},{"Code":"Unauthorized"},{"ErrorEntity":{"Code":"Unauthorized","ExtendedCode":"52039","Message":"This region has quota of 0 instances for your subscription. Try selecting different region or SKU.","MessageTemplate":"{0}. Try selecting different region or SKU.","Parameters":["This region has quota of 0 instances for your subscription"]}}]
│
│   with azurerm_app_service_plan.app_service_plan,
│   on main.tf line 152, in resource "azurerm_app_service_plan" "app_service_plan":
│  152: resource "azurerm_app_service_plan" "app_service_plan" {

Hi @MissingLink89 ,
For the warning about the deprecated resource, it’s safe to ignore as it doesn’t affect functionality, the resources are deploying correctly despite this.
Regarding the error, it’s due to a quota issue with your subscription. You can:

Try an alternate region: Change eastus to another region, for example, eastus2, in the main.tf file at this line, or

Pass the region during the command:  terraform apply -var="location=eastus2" --auto-approve.

Alternatively, you can contact Azure support for a quota increase in the East US region.

Hey @s0ulix ,
Changing me region worked.  So for me because im in Australia, deploying to my region had no errors.
Thanks for responding.


Fix method not found issue

Changed call from GetMethod to GetUnambiguousMethod() in IpcServiceEndpoint
Added GetUnambiguousMethod() in IpcServiceEndpoint
Added ParameterTypes to IpcRequest to support GetUnambiguousMethod()
Ran stylecop on IpcRequest, added comments, removed underscores as appropriate

Thanks!

Hi Jacques, as I said, I am new to this so just a question, when you closed the pull request, does that cancel it and I need to open another one or is it just merged at some future point in the process?
Thanks in advance.

I accepted and merged the PR so your changes are now in develop branch.
It will be included in the next release (v2.3.0)

Euh wait a minute let me double check...

@hoochharp Sorry it was my bad. I clicked on Close instead of Merge...
It's merged now in develop branch

OK thank you very much.

thanks @hoochharp !


Added missing images.

I notices that some of the webjar paths are ../webjars (double dot for parent dir) while others are ./webjars (single dot for current dir). There are also other double dot references that should be confirmed.


add a Server Applications: Ran

Ran is a static web server and it's github url is: https://github.com/m3ng9i/ran
Thanks.

@m3ng9i 我觉得可以，而且中文就可以。：）

@hyper-carrot 我已经更新了 pull request

Nice! I will merge!


Add an option to prevent reformatting the whole Dotbot configuration file

When I use autobot hook, the whole install.conf.yaml is reformatted:
$ cat install.conf.yaml
- defaults:
    link:
      create: true

- clean:
    - '~'

- link:
    ~/.vimrc: vim/vimrc
    # An awesome comment
    ~/.dotfiles: ''

- shell:
    - [echo hello world, A shell command]
$ yamllint install.conf.yaml
install.conf.yaml
  1:1       warning  missing document start "---"  (document-start)

$ # this is a valid install.conf.yaml
$ echo "test" > test.txt
$ git add .
$ git commit -m "Test the awesome autobot hook ;-)"
$ # autobot ran successfully
$ cat install.conf.yaml
- defaults:
    link:
      create: true
- clean:
  - '~'
- link:
    ~/.dotfiles: ''
    ~/.vimrc: vim/vimrc
- shell:
  - - echo hello world
    - A shell command
- link:
    ~/.test.txt: .test.txt

I have several remarks about the reformatting:

the comment # An awesome comment disappeared
entries in the first link section have been sorted
the shell entries have been exploded on two lines
the initial indentation has been replaced

Sorry @nagromc I totally forgot about this -- still getting used to working on open-source projects like this.
Yes, that was a deliberate design decision in order to get the MVP working. This works by parsing the YAML into a Python object, appending to that object, and re-dumping the new YAML back out. I should have made this clear in the documentation.
A better idea might be to just ignore the existing YAML, create new objects, and just append those objects to the existing config file. What do you think?

No problem @gwerbin, we all have a couple of project to work on ;-)
Yes it would be a good idea to make it clear in the documentation. Regarding your suggestion, I don't know that much Python so I cannot answer. From my point of view, maybe it seems a bit complicated, but if you manage to do it without much effort, yes why not!
Another solution may be to let the user configure -- if it is allowed by pyaml -- how he wants to format his install.conf.yaml:

keeping the original sorting of the entries. Maybe pyaml parses the install.conf.yaml entries as sorted lists
closing the list style (the [-,-] style or splitted lists style). Of course, this will be consistent throughout the file
setting the indentation style

I understand comments will be ignored by the parser, thus not dumped back in the file.

@nagromc I don't think I'm going to end up having the time to do this. I still use Dotbot but this was never a tool that fit into my workflow. Feel free to fork, you can have it :)


Feature request: allow keybinding to use click

Other editor uses click+key to perform some action.
For instance in IntelliJ you can go to declaration using Ctrl+Click or place multiple cursor with Alt+Shift+click.
I think VScode does the same. Could this be added to the keymap settings ?

We already support ctrl+click to go to declaration, but you're right that this is not configurable.

@bugadani So, no way to enable/use ctrl+click other than to modify the code?

@bugadani So, no way to enable/use ctrl+click other than to modify the code?

Yes


Approach to disable input bus

Description
AUAudioUnitBus has isEnabled property. If this property is disabled, pullBlock will not be called on an input bus and will save processing time.
This is working very well in Apple's Audio Units (e.g. AVAudioMixerNode) and depending where this bus in the chain is, you might experience significant performance improvements as none of the upstream nodes will be called.
Unfortunately this is not implemented in AudioKit units (e.g. DryWetMixer).
Proposed Solution
This check would need to happen here and here I believe.
I am not sure how to approach this since this property is in AUAudioUnitBusArray->AUAudioUnitBus which is not available within DSP.
Describe Alternatives You've Considered
I guess one approach would be to duplicate these properties on DSP, but that seems not very elegant.
Additional Context
Please note that this is different to bypass effect, which just bypasses processing in one node, but doesn't prevent further signal propagation.

@jcavar This issue is pretty old, I was wondering, since you have made pull requests before if you want to try to close this issue or if you find its not something you need, maybe it can be closed without code.

Hi @aure, we got around this in a different way, but I think the problem is still relevant.
I am ok if you would like to close it as we don't have capacity to work on it.


Chris phillips solution

Base - Comfort: 5
Base Completness: 5
Bonus: TBD
This is the code block I had working before attempting the bonus. I'm going to tackle implementing that again after I do some doc reads on jQuery.
I wanted to add a couple features with the bonus as well:

Dynamic User Selected Div Population in a flex box:
Dynamic User created div population with a mouse over event that is triggered by a button (The user clicks the button which allows the mouse to draw div elements vs just generating them automatically)

This looks great!
The onkeydown event doesn't seem to work. You'd need to use the jQuery keydown(). I think you also need to specify the key code for the enter key to do that otherwise the function would be triggered with any key press.


Revise md section not formatting properly in html

Summary
Fixes this (below) on the public web-page :upside_down_face:

I'm assuming this does not count for the "Do not submit PRs with only formatting"; that boiler-plate may want to specify code, if so.

Related issues

Changes these areas

[ ] Bugfixes
[ ] Feature behavior
[ ] Command line interface
[ ] Configuration options
[ ] Internal architecture
[ ] Snapshot data layout on disk

thanks!


bump year in license

The license in master got updated, I think when things were in dev.
Thank you for the fix though!


conceal highlight issue for latex

Environment:

Windows
Neovim  latest

If you have a trouble with coloration and are using Vim/Neovim with terminal:

[x] Does your Vim support full colors? (:set termguicolors)
[x] Does your terminal support full colors? (e.g. Terminal.app doesn't support it)

I'd like use the settings:
hi Conceal ctermfg=NONE
hi Conceal ctermbg=NONE
hi Conceal guifg=NONE
hi Conceal guibg=NONE
to make concealed chars and words similar to the background.
And it seems there's a bug for this fantastic iceberg theme:
iceberg:

OceanicNext:
image

And I found some post here:
kaicataldo/material.vim#12
for the 'material` theme, as they add some defined colour to the scheme.
Could we also do similar things for Iceberg?

Could you share the example code about the problem? I'll check it in my environment later.

Could you share the example code about the problem? I'll check it in my environment later.

You can simply try this:
\begin{equation} \nonumber
\min_{s(\bx)} \, \, \,  \int_\Omega \| \nabla s(\mathbf{x}) - \mathbf{g}(\mathbf{x}) \|^2 d\bx \quad \text{s.t.} \quad s(\mathbf{x}) = \begin{cases}
0 \, \, \,  \text{for} \, \, \, \bx \in \partial \Omega_0\\
1 \, \, \, \text{for} \, \, \, \bx \in \partial \Omega_1.\\
\end{cases}
\end{equation}

BTW, I found a solution that adding this:
au Colorscheme * hi! link Conceal Number

to my $VIMRC will resolve the issue.
But there for sure is some difference between your theme and the oceanic one if you'd like to explore.

Thank you for your help! Fixed in #72.


Use build items instead of generated files for kubernetes resources

Resolves: #394

Many thanks @iocanel !


installtion broken for linux debian (Kali)

Hi trying to have a look into fano but unfortunately not able to install fano-cli due to some missing units on the src installation code, not sure where the error is located, as i already have FPC +3 installed + lazarus-IDE
Compiling ./src/Tasks/Implementations/Minifier/DirFileMinifierTaskImpl.pas
Writing Resource String Table file: DirFileMinifierTaskImpl.rsj
Compiling ./src/Libs/Minifier/Implementations/JsMinifierImpl.pas
Compiling ./src/Libs/Minifier/Contracts/MinifierIntf.pas
JsMinifierImpl.pas(18,5) Fatal: Can't find unit jsminifier used by JsMinifierImpl
Fatal: Compilation aborted
Error: /usr/bin/ppcx64 returned an error exitcode

@lawrenceamer  jsminifier unit is in Free Pascal built-in package fcl-js. Make sure you have FPC source correctly in your PATH  environment variable https://gitlab.com/freepascal.org/fpc/source/-/blob/811c68377596fdebf8bfcee8e8ce773df42593f7/packages/fcl-js/src/jsminifier.pp

To be able to identified what directories that Free Pascal is trying to look for that file you can edit file build.dev.cfg remove last lines from
#----------------------------------------------
# Verbose unit searching info,
# Remove comment, in case unit file is not found
# so Free Pascal will output verbose message where
# it tries to look for unit file
#----------------------------------------------
#-vut

to
#----------------------------------------------
# Verbose unit searching info,
# Remove comment, in case unit file is not found
# so Free Pascal will output verbose message where
# it tries to look for unit file
#----------------------------------------------
-vut

and then run build.sh with BUILD_TYPE=dev
$ BUILD_TYPE=dev ./build.sh

i don't think my fpc is broken, rather than i still believe due to something missing in the compilation command, after doing build_type=dev i got all of no found search in unit something like
/usr/lib/x86_64-linux-gnu/fpc/3.2.2/units .. etc

Do you have jsminifier.pp unit somewhere in your machine?

it is found on the following path /home/kali/fpcupdeluxe/fpcsrc/packages/fcl-js/src/jsminifier.pp, since I am using fpcupdeluxe for my lazarus-ide, but I tried to direct my build through FPC_BIN=/home/kali/fpcupdeluxe/fpc/bin/x86_64-linux/fpc ./build.sh, but still same error!

also can you share the output where Free Pascal compiler looks for jsminifier unit
for example, mine,
Searching file bin/unit/jsminifier.o... not found
Searching file bin/unit/JSMINIFIER.O... not found
Searching file /home/zamroni/fpcupdeluxe/fpc/units/x86_64-linux/fcl-js/jsminifier.o... found

it displays the following error
hom/kali/fpcupdeluxe/fpc/bin/x86_64-linux/jsminifi.pp... not found
Searching file /home/kali/fpcupdeluxe/fpc/bin/x86_64-linux/JSMINIFI.PP... not found

it should be looking into fpcupdeluxe/fpcsrc/packages/fcl-js/ folder while it doesn't

sorry i mean it should look for inside
/home/kali/fpcupdeluxe/fpc/units/x86_64-linux but it is not doing that

you may want to inspect content of /etc/fpc.cfg as I believe Free Pascal will also looks for directories to search.

my /etc/fpc.cfg also contains
# searchpath for units and other system dependent things
-Fu/home/zamroni/fpcupdeluxe/fpc/units/$fpctarget
-Fu/home/zamroni/fpcupdeluxe/fpc/units/$fpctarget/*
-Fu/home/zamroni/fpcupdeluxe/fpc/units/$fpctarget/rtl

which i believe was set when I installed fpcupdeluxe.

can symlink fpcdeluxe fpc.cfg into /etc/fpc.cfg?

https://fanoframework.github.io/known-issues/#missing-etc-fpc-cfg

cool now it is working, it was referring to /etc/fpc.cfg, while that not symlinked to fpcupdelux dir.

nice. close this issue now


fix: ensure consistent ids across hooks and bundlers

This PR fixes a behavior where the passed id args aren't the same across bundlers and hook calls. It also adds tests to ensure this behavior.
In detail:

Don't run the resolveId hook in esbuild when the module is marked as external. (mirrors rollup's behavior)
Run load for all loaded modules in webpack. I don't actually know if this change is problematic. I would love some insight into why the check for virtual modules was introduced in the first place.
Have consistent ids in vite.
Introduce a build-time flag, since webpack loaders and unit tests are a bit tricky with path resolution.
Replace the slash/backslash utilities with a more sustainable solution that always normalizes absolute paths/ids to OS conform paths
URL encode the module id in webpack before passing it to loader (avoids path shenanigans)

@antfu This PR is ready for review now. It would be awesome if you could take a look!

I have added the test for Webpack 4, it seems to make some tests fail. Can you check if there is something we could do, or we could consider the misalignment is acceptable?

@antfu Thanks for taking another look. I like the changes you made to the PR and also love that we're testing webpack 4 now. 👍
Looked at the test failures. Webpack 4 seems to "browserify" any node externals when no target: 'node' option is provided and this caused extra imports/extra hook calls, messing with the tests. I added the option to the relevant tests and now they seem to pass. I believe this is intended behaviour for us so I didn't make any changes for this in the actual library code.

This is a nice one. Thanks a lot!


tommynsong

What were you trying to accomplish in this PR? It looks like you added an SSH segment, but perhaps accidentally submitted the PR with a bunch of other changes?


Yarn installations

Hi
When we install browser-perf via Yarn, the "cleanup modules" tasks cleans up docs folder which is required that the code works as expected. Maybe you can rename the folder to ensure correct behaviour also for Yarn users?
Thanks a lot for this great tool!
Cheers

@zanettin Thanks for reporting the issue.
Are you using yarn clean and running into the issue ? Could you please help with repro steps ?

Hi @axemclion
Yes exactly. yarn clean does that.
Love this task and works quite great except for browser-perf on our react app 😄
What do you think?
Seams like this directories are removed:
docs
doc
website
images
assets

@zanettin  Do you suggest I rename docs to something else ? I could look to see if there is a way to not delete those folders.

yes,  if this is an option for you. listed folders from above are deleted by yarn clean. if you find another workaround/option it would also be great :-) thx


Frends.SFTP.DownloadFiles has bug with RenameDestinationFileDuringTransfer

The task uses the work directory given by user when renaming the destination file. This will make the file move to a different directory. This should be changed to use the directory where the destination file is currently. Otherwise this could throw exception when destination action is set to overwrite or append.

This and other minor bugs was fixed in the PR #48


The difference between the use of configurable and metadata in RunnableConfig?

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangGraph/LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangGraph/LangChain rather than my code.
[X] I am sure this is better as an issue rather than a GitHub discussion, since this is a LangGraph bug and not a design question.

Example Code
from langchain_core.messages import AIMessage
from langchain_core.runnables import RunnableConfig
from langgraph.graph import StateGraph, MessagesState

def print_config(state: MessagesState, config: RunnableConfig) -> MessagesState:
    print(config["metadata"])  # The value of container type does not appear here
    # These values must be use configurable to get
    print(config["configurable"]["cherries"])
    print(config["configurable"]["dates"])
    print(config["configurable"]["egg"])
    return {"messages": [AIMessage(content="foo")]}

graph_builder = StateGraph(MessagesState)
graph_builder.set_entry_point("foo")
graph_builder.add_node("foo", print_config)
graph_builder.set_finish_point("foo")

config = {
    "configurable": {
        "apple": 1,
        "banana": "two",
        "cherries": [3, "four", 5.0],
        "dates": {"Alice": 6, "Bob": "seven"},
        "egg": (1, 2),
    },
}

app = graph_builder.compile()
app.invoke({"messages": [("human", "Hello World!")]}, config)

Error Message and Stack Trace (if applicable)
`config["metadata"]` cannot retrieve some of the data entered from `configurable`

Description
When I use
{
    "configurable": {
        "apple": 1,
        "banana": "two",
        "cherries": [3, "four", 5.0],
        "dates": {"Alice": 6, "Bob": "seven"},
        "egg": (1, 2),
    },
}

config["metadata"] seems to only save basic types of content?
Is this normal output? What is the principle of saving metadata? When should I use metadata or configurable?
configurable contains a lot of information, while metadata is much cleaner. I encountered this problem when trying to use metadata to get some of my own data.

When I use metadata to input, all values can be obtained normally.
{
    "metadata": {
        "apple": 1,
        "banana": "two",
        "cherries": [3, "four", 5.0],
        "dates": {"Alice": 6, "Bob": "seven"},
        "egg": (1, 2),
    },
}

System Info
langgraph == 0.1.5
langchain == 0.2.6
python version == 3.10.12

Metadata was designed for tracing (instrumentation) rather than control flow.
Configurable parameters are meant for actual configuration of the graph / runnable execution.
We log primitive values as metadata since that's useful for observability.
But I do see how that's non-obvious just by looking at the config

Because I observed before that the metadata has the Configurable I entered, and its contents are very clean.
It was easy for me to find all the values I passed in, until I discovered that it seemed to only save the contents of the basic type.
In short, metadata should be an attribute used for langchain internal program tracking.
If the user passes some data to Node and gets it back in Node, should it always be through Configurable?

The input would either be in the configuration or the state. Typically configuration is things like IDs, selecting the model type, etc., whereas state is things like messages, documents, database connection, etc.

Thank you for your answer, I will close this issue.


Odd has_css? behaviour?

We have a test which checks HTML5 form validations. We have a text area which uses setCustomValidity which adds the class 'user-error'.
When we write a test like so:
			# < character limit
			within("form.basic") do
				fill_in 'details', :with => 'a' * 49
			end
			expect(page).to have_css 'textarea[name=details].user-error'

It fails incorrectly.
If immediately before the expect line, I add binding.pry and print page.has_css? 'textarea[name=details].user-error', I get the correct result. I thought this might be a synchronisation issue, but no amount of reload or sleep seems to make the test pass. Any idea what is going wrong?

Sorry for the delay -- depends on your app and what you can do -- as I said previously - clicking on some other element on the page could do it, or any other action on the page that would cause the textarea to lose focus - there is no one correct way


Added Email Collector Database Template

@Ayan-thecodeking Hey please look into this, if you find the template g2g then merge it. Thank you!
Here's how the template looks!

Hey @Ayan-thecodeking kindly look into the PR if you feel it's g2g then kindly merge it. If you feel something can be improved then let me know.
Thank you.

@Chirantanbanik can you please share the deploy link or some more details

Deployed link: https://heroic-seahorse-98b05d.netlify.app/

@Chirantanbanik Thnx for Contributing !! Hope you learned something new , Don't forget to star repo and follow me for further such amazing repos 👍


netlify build does not import all included_files

Describe the bug
According to the CLI docs and this article the included_files directive should tell the build command to include "any type of file in your serverless functions".
Even the docs have such example of importing .md files.
However, it seems only JSON files seem to be imported in the bundle and even more only if the code includes such files.
Is this expected?
In a project I need to use .txt files as list of words for different languages; the project was working locally when running netlify dev, however in production I got an ENOENT: no such file or directory error. Digging deeper I looked into the netlify build resulting .zip file and realized the files were in fact not included anywhere.
Steps to reproduce
Please see example repo.
This is the content of my .netlify/functions/test.zip file; as you can see only the data.json file, required in Node, was included, all other files inside files were ignored:
.
└── functions
    └── test
        ├── src
        │   ├── files
        │   │   └── data.json
        │   └── functions
        │       └── test.js
        └── test.js

Configuration
[build]
  functions = "functions"

[functions]
  included_files = [
    "files/*.json",
    "files/*.md",
    "files/*.txt"
  ]

Environment
System:
    OS: macOS 12.4
    CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz
    Memory: 557.52 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.11.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  npmPackages:
    netlify-cli: 10.5.1 => 10.5.1
  npmGlobalPackages:
    netlify-cli: 2.32.0

@stebogit I wasn't able to reproduce this.
I cloned https://github.com/stebogit/netlify_included_files_issue. Ran npm install. Then tried build command after linking. The extracted zip had the following files:
.
├── files
│   ├── data.json
│   ├── data.txt
│   ├── data2.json
│   └── test.md
├── functions
│   └── test.js
└── test.js

System Configuration
  System:
    OS: macOS 12.4
    CPU: (8) arm64 Apple M1
    Memory: 334.94 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman

Closing as stale. Please re-open if needed


Version 6.0 : Breaking Changes

Currently, IRepository command methods are calling await _dbContext.SaveChangesAsync() internally, which arguably breaks the single responsibility pattern. So we have decided to bring the await _dbContext.SaveChangesAsync() out of the following methods:
1. InsertAsync();
2. UpdateAsync();
3. DeleteAsync();

The above methods will be replaced with the following methods:
1. Add();
2. Update();
3. Remove();

And to persist the changes to the database, the user has to call the await _repository.SaveChangesAsync() explicitly.
Currently:
_repository.InsertAsync(employee);

In from version 6.0:
_repository.Add(employee);
await _repository.SaveChangesAsync();

However, what should be the next method names:
1. Add();
2. Update();
3. Remove();

or
1. Insert();
2. Update();
3. Delete();

Please share your thoughts.

The Add(), Update(), Remove() approach seems fine. But i think that the SaveChanges() method should have a different name. EfCore SaveChanges() method works globally and is finalizing the transaction for all tracked entities. To make the ,,save'' method look more repository (which is representing a single entity) related, we can choose a different name, mayby Commit()?

Thank you for your opinion:

EfCore SaveChanges() method works globally and is finalizing the transaction for all tracked entities. To make the ,,save'' method look more repository (which is representing a single entity) related, we can choose a different name, mayby Commit()?

However, Our IRepository methods are generic, so you can add multiple command operations for multiple entities one by one and SaveCahnges all at once. That's why we are naming it SaveChangesAsync().

While sole responsibility is important, it is not a requirement.
Names

Add();
Update();
Delete();
instead of changing
InsertAsync(); with save
Add(); without saving
UpdateAsync(); with save
Update(); without saving
DeleteAsync(); with save
Delete(); without saving

Wouldn't it be much more reasonable to continue as ?
Or could this be an option?
services.AddGenericRepository<YourDbContext>().AutoSave(true);
I understand that principles are important.
but this is not a client project, is it really that important?
Just asking :)

@serdarozkan41 Thank you so much for your opinion. If we keep all the methods, it will create a lot of confusion for the end users. I would like to keep things simple.

I don't see any disadvantage on the new approach, as long as multiple operations can still work in case of using transactions. Don't like the .Commit() since EF Core uses this to commit transactions and it would be confusing. I think the closest it ressembles to EF Core the better, so Add(), Remove() and Update() are my choices.


Feature Request: Built-in NuGet Package Manager

A feature that is important but is missing is the NuGet Package Manager, this will make the application better.

Dup of https://github.com/Microsoft/vscode/issues/9211


[Feature Request] Choose sides to insert

Hi,
Similar to StyleSelectorXL can you update to choose position in prompt to add.

Since this is using the same built-in logics as LoRAs or Textual Inversions, I don't think that would be possible unfortunately...

Never mind! i just found out normal style can actually work with {prompt} as syntax. Never thought it could work before until try! closing now.


[fix] Remove last remaining CircleCI Job and ensure storybook artifacts are saved in github actions

Truss discourages the use of CircleCI for our projects as noted in our Engineering Playbook. This project has one job using CircleCI and the rest using GitHub Actions, which is also an anti-pattern.
So this issue is to remove the one remaining cirlce ci job and ensure that the storybook artifacts are saved by the deploy-storybook.yml GitHub workflow. Our decision to move from CircleCI to Github actions should also be documented in an ADR.
AC:

Removal of .circleci/config.yml
Delete our data on circleci for the project, if any is needed
Add support to save static storybook output in github workflow action .github/workflows/deploy-storybook.yml
Add an ADR describing our choice to use GitHub actions
Update any links in our Readme or project pointing to circleci

References:

This would replace / close #2077 in my opinion.

I believe the AC are completed except we still need the ADR and documentation updates.

Made a new issue for docs only. Marking this as done


Write a Perl program to convert days to hours

Description
Write a Perl program to convert days to hours
1 day = 24 hours
Input  : 5
Output : 120

How to contribute

Save the solution in program/convert_days_to_hours.pl file
Add convert_days_to_hours.pl file in convert-days-to-hours folder

!assign


requests.exceptions.ConnectionError: ('Connection Aborted', Error(32, 'Broken Pipe')

Hi Guys,
I have downloaded the quickstart version of jasper and have run populate.py but when i run jasper.py it comes up with the above error. Please help?

Thanks for taking the time to report a bug. Unfortunately, we can't help you, because you didn't post enough output (you even skipped the Traceback). Please read this and then report the bug again. Closing this one.


Use a WeakMap to stash listeners.

Fixes #186. /cc @TGRBos

That looks like an elegant solution, will give it try.

Per your followup comment this isn’t the source of the leak, so closing.


Doesn't work with nondefault langmap

Hey,
trying to use this with a nondefault langmap leads to unexpected behaviour.
e.g. I'm using
set langmap = kf,KF,ö0,Ö0,ok,OH,ih,IK,ej,EL,al,AJ,hw,HW,ub,UB,xe,XE,üm,ÜM,ya,YA,ä$,Ä$,gg,GG,pu,PU,do,DO,si,SI,lt,LT,rs,RS,mc,MC,td,TD,cy,CY,fn,FN,np,NP,br,BR,wx,WX
and whatever I bind the commands to on the user-level (the way it's suggested in the readme), the behaviour stays the same.
I'm thinking maybe somewhere in the definition of the commands the default langmap is assumed? Maybe some sort of mapping is happening somewhere there?
Would be nice if this could be factored out into the user-level mappings maybe. I'd like getting into this. :)
Cheers

It doesn't work in my config file with langmap neither.

@booglewoogle @roket1428 , I haven't had much time lately, but feel free to create a PR and I will review it :smiley:
Cheers,
Antoine

@booglewoogle @roket1428 , I haven't had much time lately, but feel free to create a PR and I will review it smiley
Cheers,
Antoine

I don't know vim scripting well to create (or edit in my case) a plugin but I would try to find normal keywords which does not include ! at the end. Would it be enough?


fix(sidebar): Preserve sidebar scroll across page navigations

Description (required)
fix Sidebar scroll from jumping during page navigations by preserving scroll position in session storage

Related issues & labels (optional)

Closes #5678
Suggested label: bug

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.

Hi @yasnbouz , thank you for making a contribution to Astro Docs!  🙌
I can see that you tackled an open issue, but I should warn you that there was no discussion around that issue, so we haven't had a chance to decide whether this is in fact an issue that we want or intend to fix.  😄  That just means this contribution will have to wait as we figure out what we in fact want to do about that opened issues, so you'll have to hang on a little longer!
It's always safe to stick to the "help wanted" labels when working on issues. Sometimes people open what they feel are issues, but for various reasons are not something we decide or intend to change. We have also just recently migrated our docs to Starlight, so we have a lot of review planned as we work out some of the new internals, and it's possible that this contribution may not end up fitting into our larger planned work. That doesn't mean it was a bad solution to the problem, just that this is not something we have yet requested assistance with, and it may not end up being compatible with other site maintenance we are implementing.
So, please hold on for a while longer as this is not something we had planned to look at, and are trying to incorporate reviewing this along with our other maintenance!

Thank you, @sarah11918, for your feedback. 🙏 I apologize for the misunderstanding on my part. The changes proposed in my PR are actually related to the open issue #5771.

Hi @yasnbouz ! We've discussed this with the team, and I think they are going to try to tackle this internally in a different way. Thank you for the contribution, but we have something else in mind for this. So I'll close this PR, but I hope to see more contributions from you in the future!  🙌 🚀

Hi @sarah11918 ! Thank you for considering my contribution and for the update 🙏, I'm eager to see the solution that the team comes up with 🧐. I appreciate the opportunity to contribute and I'm looking forward to making more contributions in the future 🚀.


Add ability to include logs from etcd-snapshot-once container to Rancher container logs

What kind of request is this (question/bug/enhancement/feature request):
Enhancement
Steps to reproduce (least amount of steps as possible):
Having the logs of etcd-snapshot-once container included into Rancher container logs would be very beneficial especially in cases where etcd-snapshot-once container reports failures which aren't visible anywhere. The container exits immediately after execution so this increases the complexity to inspect its logs due to the short lifetime.
A common failure scenario would be when proxy-body-size needs to be configured to avoid errors due to body payload been larger than allowed, upon snapshot to s3.
e.g.
# docker logs -f etcd-snapshot-once
time="2020-01-14T11:54:04Z" level=info msg="invoking set s3 service client"
time="2020-01-14T11:54:04Z" level=info msg="Initializing Onetime Backup" name="xxxxxxxxxxxx"
time="2020-01-14T11:54:04Z" level=info msg="Created backup" name="xxxxxxxxxxxx" runtime=xxxxxxxxxxxxms
time="2020-01-14T11:54:04Z" level=info msg="invoking uploading backup file cluster-backup/xxxxxxxxxxxx.zip to s3"
time="2020-01-14T11:54:04Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 0 times"
time="2020-01-14T11:54:04Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 1 times"
time="2020-01-14T11:54:04Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 2 times"
time="2020-01-14T11:54:04Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 3 times"

Similar issue was reported in https://github.com/rancher/rancher/issues/21675
What makes this even harder to troubleshoot is that Rancher container will report that snapshot was successfully completed, which is not true and logic will have to be modified.
e..g
[..]
2020/01/14 10:13:02 [INFO] [etcd] Snapshot will be uploaded to S3 compatible backend at [xxxxxxxx] in region [] to bucket [xxxxxxxx] using accesskey [xxxxxxxx]
[..]
2020/01/14 10:13:03 [INFO] [etcd] Successfully started [etcd-snapshot-once] container on host [xxxxxxxx]
[..]
2020/01/14 10:13:04 [INFO] Finished saving/uploading snapshot [xxxxxxxx] on all etcd hosts
[..]

There is another open issue that reports similar behavior, upon s3 access denied failure-- https://github.com/rancher/rancher/issues/19703
gzrancher/rancher#11037

I think it would be also great to add additional logging to this container. In order to found out what was happening i even tried to run it with --debug flag. But in vain, still had only:

We encountered an internal error, please try again

docker run --rm  -v /opt/rke/etcd-snapshots/:/backup:z -v /opt/rke/etc/kubernetes:/etc/kubernetes:z  621c55bdbd48 /opt/rke-tools/rke-etcd-backup etcd-backup save --cacert /etc/kubernetes/ssl/kube-ca.pem --cert /etc/kubernetes/ssl/kube-node.pem --key /etc/kubernetes/ssl/kube-node-key.pem --name c-vpn8c-ms-jcgmt_2020-02-13T21:06:01Z --endpoints=<IP_ADDRESS>:2379 --once --creation=12h --retention=72h --s3-backup=true --s3-endpoint=backup-srv02.domain.local --s3-accessKey=Backup --s3-secretKey=SECRET--s3-bucketName=simple --s3-region --s3-folder=highload --debug=true etcd-snapshot-once

It's very important when troubleshooting issues to have these sorts of processes log persistently or at least have the option to enable it when we need.

I'm unsure if it should be another issue, but this also applies to the rke -d etcd snapshot-save command.

For the logging part, the logging of the created etcd-snapshot-once container is now printed with every iteration of the check if the container is still running (https://github.com/rancher/rke/pull/2152/files#diff-b715a530d535012e418a564a3eafedb9R491):
2020/08/05 12:23:43 [INFO] Container [etcd-snapshot-once] is still running on host [x]: stderr: [time="2020-08-05T12:23:28Z" level=info msg="Initializing Onetime Backup" name="c-v59cd-ms-pmbjc_2020-08-05T12:22:04Z"
2020/08/05 12:23:44 [INFO] Waiting for [etcd-snapshot-once] container to exit on host [x]
2020/08/05 12:23:44 [INFO] Container [etcd-snapshot-once] is still running on host [x]: stderr: [time="2020-08-05T12:23:44Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 1 times"
2020/08/05 12:23:45 [INFO] Waiting for [etcd-snapshot-once] container to exit on host [x]
2020/08/05 12:23:45 [DEBUG] Exit code for [etcd-snapshot-once] container on host [x] is [1]

The mentioned case of the snapshot failing while its being reported as successful is covered in https://github.com/rancher/rke-tools/pull/105:
2020/08/05 12:24:16 [WARNING] [etcd] Failed to take one-time snapshot on host [x], exit code [1]: time="2020-08-05T12:24:16Z" level=fatal msg="failed to upload etcd snapshot file: 413 Request Entity Too Large"
2020/08/05 12:24:16 [TRACE] REST UPDATE apis/management.cattle.io/v3/c-v59cd/etcdbackups/c-v59cd-ms-pmbjc
2020/08/05 12:24:16 [TRACE] REST UPDATE apis/management.cattle.io/v3/c-v59cd/etcdbackups/c-v59cd-ms-pmbjc
2020/08/05 12:24:16 [ERROR] EtcdBackupController c-v59cd/c-v59cd-ms-pmbjc [etcdbackup-controller] failed with : [etcd-backup] failed to perform etcd backup: [etcd] Failed to take one-time snapshot on host [x], exit code [1]: time="2020-08-05T12:24:16Z" level=fatal msg="failed to upload etcd snapshot file
: 413 Request Entity Too Large"

To trigger the 413 Request Entity Too Large error, you first have to setup a Minio instance. You can do this using https://gist.github.com/superseb/32c439aac5097723f395acc77c47e829 which auto detects the external IP and uses minio.$EXTERNALIP.xip.io address or uses the FQDN provided as the first argument to the script. This will get you a working Minio that can be configured in Rancher (to test a successful backup).
After a successful backup, you can open $PWD/nginx.conf in your editor and change client_max_body_size 0; to client_max_body_size 100k;, so that the max body size is hit when the next snapshot is being uploaded. After that, make sure to restart the nginx container: docker restart nginx. Now create another backup and it should fail with the 413 Request Entity Too Large error.

Reproduced the issue with v2.4.5

Steps

Create a DO cluster with minio configured as described in https://github.com/rancher/rancher/issues/24955#issuecomment-669203711
With client_max_body_size 100k, the S3 snapshots fail and the below error is displayed in the logs of etcd-snapshot-once container

time="2020-08-12T16:30:50Z" level=info msg="Initializing Onetime Backup" name="c-6f42f-ms-76wg2_2020-08-12T16:30:44Z"
time="2020-08-12T16:30:51Z" level=info msg="Created local backup" name="c-6f42f-ms-76wg2_2020-08-12T16:30:44Z" runtime=153.57336ms
time="2020-08-12T16:30:51Z" level=info msg="invoking uploading backup file [c-6f42f-ms-76wg2_2020-08-12T16:30:44Z.zip] to s3"
time="2020-08-12T16:30:51Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 0 times"
time="2020-08-12T16:30:51Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 1 times"
time="2020-08-12T16:30:51Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 2 times"
time="2020-08-12T16:30:52Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 3 times"

Rancher logs display that the snapshot uploading was successful though it failed as below:
2020/08/12 17:41:06 [INFO] Waiting for [etcd-snapshot-once] container to exit on host [abcd]
2020/08/12 17:41:06 [INFO] Container [etcd-snapshot-once] is still running on host [abcd]
2020/08/12 17:41:07 [INFO] Waiting for [etcd-snapshot-once] container to exit on host [abcd]
2020/08/12 17:41:07 [INFO] Removing container [etcd-snapshot-once] on host [abcd], try #1
2020/08/12 17:41:07 [INFO] Finished saving/uploading snapshot [c-6f42f-ms-cq9c7_2020-08-12T17:40:58Z] on all etcd hosts
2020/08/12 17:41:07 [INFO] kontainerdriver rancherkubernetesengine stopped

Snapshot list in Rancher shows the snapshot is active while it should show as failed

Validated with v2.4-head(d243587b7)

Steps

Create a DO cluster with minio configured as described in https://github.com/rancher/rancher/issues/24955#issuecomment-669203711
With client_max_body_size 100k, the S3 snapshots fail and the below error is displayed in the logs of etcd-snapshot-once container

time="2020-08-12T17:37:59Z" level=info msg="Initializing Onetime Backup" name="c-khhsn-ms-26kbd_2020-08-12T17:37:31Z"
time="2020-08-12T17:37:59Z" level=info msg="Created local backup" name="c-khhsn-ms-26kbd_2020-08-12T17:37:31Z" runtime=123.527657ms
time="2020-08-12T17:37:59Z" level=info msg="invoking uploading backup file [c-khhsn-ms-26kbd_2020-08-12T17:37:31Z.zip] to s3"
time="2020-08-12T17:37:59Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 0 times"
time="2020-08-12T17:37:59Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 1 times"
time="2020-08-12T17:38:00Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 2 times"
time="2020-08-12T17:38:00Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 3 times"
time="2020-08-12T17:38:00Z" level=fatal msg="failed to upload etcd snapshot file: 413 Request Entity Too Large"

Rancher logs displays the updated logs with std err and also reports  that the snapshot failed as below:
2020/08/12 17:38:29 [INFO] Waiting for [etcd-snapshot-once] container to exit on host [abcd]
2020/08/12 17:38:29 [INFO] Container [etcd-snapshot-once] is still running on host [abcd]: stderr: [time="2020-08-12T17:38:29Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 1 times"
], stdout: []
2020/08/12 17:38:30 [INFO] Waiting for [etcd-snapshot-once] container to exit on host [abcd]
2020/08/12 17:38:30 [INFO] Removing container [etcd-snapshot-once] on host [abcd], try #1
2020/08/12 17:38:30 [INFO] kontainerdriver rancherkubernetesengine stopped
2020/08/12 17:38:30 [WARNING] [etcd] Failed to take one-time snapshot on host [abcd], exit code [1]: time="2020-08-12T17:38:29Z" level=fatal msg="failed to upload etcd snapshot file: 413 Request Entity Too Large"

2020/08/12 17:38:30 [ERROR] EtcdBackupController c-khhsn/c-khhsn-ms-26kbd [etcdbackup-controller] failed with : [etcd-backup] failed to perform etcd backup: [etcd] Failed to take one-time snapshot on host [abcd], exit code [1]:
time="2020-08-12T17:38:29Z" level=fatal msg="failed to upload etcd snapshot file: 413 Request Entity Too Large"

Snapshots list in Rancher dispays the failed snapshots as below:

Validated with master-head(d19f179c4ff15bb782)
Steps

Create a DO cluster with minio configured as described in #24955 (comment)
With client_max_body_size 100k, the S3 snapshots fail and the below error is displayed in the logs of etcd-snapshot-once container

time="2020-08-12T19:17:01Z" level=info msg="invoking set s3 service client" s3-accessKey=hz7AMDvwYRpccKjWzMDQXpOlHNPF7cGj s3-bucketName=rancherbackups s3-endpoint=minio.xyz s3-endpoint-ca=LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURHakNDQWdLZ0F3SUJBZ0lKQUlCcG00aGNEeFF5TUEwR0NTcUdTSWIzRFFFQkN3VUFNQkl4RURBT0JnTlYKQkFNTUIzUmxjM1F0WTJFd0hoY05NakF3T0RFeU1EQTFNRE16V2hjTk1qQXhNREV4TURBMU1ETXpXakFTTVJBdwpEZ1lEVlFRRERBZDBaWE4wTFdOaE1JSUJJakFOQmdrcWhraUc5dzBCQVFFRkFBT0NBUThBTUlJQkNnS0NBUUVBCnJ3bHJUeGd1QmpHTzBIalY0dlF3NStXNCtPd1M2bTZxeXlobENydkpTQzQ3TFhjcUVzOFVtaXFt s3-folder= s3-region=
time="2020-08-12T19:17:01Z" level=info msg="Initializing Onetime Backup" name="c-4npml-ms-st2fs_2020-08-12T19:16:53Z"
time="2020-08-12T19:17:02Z" level=info msg="Created local backup" name="c-4npml-ms-st2fs_2020-08-12T19:16:53Z" runtime=274.126316ms
time="2020-08-12T19:17:02Z" level=info msg="invoking uploading backup file [c-4npml-ms-st2fs_2020-08-12T19:16:53Z.zip] to s3"
time="2020-08-12T19:17:02Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 0 times"
time="2020-08-12T19:17:02Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 1 times"
time="2020-08-12T19:17:03Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 2 times"
time="2020-08-12T19:17:03Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 3 times"
time="2020-08-12T19:17:03Z" level=fatal msg="failed to upload etcd snapshot file: 413 Request Entity Too Large"

Rancher logs displays the updated logs with std err and also reports that the snapshot failed as below:
2020/08/12 19:17:13 [INFO] Container [etcd-snapshot-once] is still running on host [abcd]: stderr: [time="2020-08-12T19:17:13Z" level=info msg="invoking set s3 service client" s3-accessKey=hz7AMDvwYRpccKjWzMDQXpOlHNPF7cGj s3-bucketName=rancherbackups s3-endpoint=minioabcd s3-endpoint-ca=LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURHakNDQWdLZ0F3SUJBZ0lKQUlCcG00aGNEeFF5TUEwR0NTcUdTSWIzRFFFQkN3VUFNQkl4RURBT0JnTlYKQkFNTUIzUmxjM1F0WTJFd0hoY05NakF3T0RFeU1EQTFNRE16V2hjTk1qQXhNREV4TURBMU1ETXpXakFTTVJBdwpEZ1lEVlFRRERBZDBaWE4wTFdOaE1JSUJJakFOQmdrcWhraUc5dzBCQVFFRkFBT0NBVTQzRW5NdU1uYjIycmxDQnhzClkxSVVBY1hDVVF5cUdRUmNDMzhOVXVBTzY1YTlkS01VR1YydXZWQUJiZUlxeGFyY2p4a3cvc0xiNXlCUmdESC8KOG9wRzlpWmhleFZYQXdzbXdxSllCd2UwYmFCaUZZZW5yV1dSOCtWNgotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0t s3-folder= s3-region=
], stdout: []
2020/08/12 19:17:14 [INFO] Waiting for [etcd-snapshot-once] container to exit on host [abcd]
2020/08/12 19:17:14 [INFO] Container [etcd-snapshot-once] is still running on host [abcd]: stderr: [time="2020-08-12T19:17:14Z" level=info msg="failed to upload etcd snapshot file: 413 Request Entity Too Large, retried 1 times"
], stdout: []
2020/08/12 19:17:15 [INFO] Waiting for [etcd-snapshot-once] container to exit on host [abcd]
2020/08/12 19:17:15 [INFO] Removing container [etcd-snapshot-once] on host [abcd], try #1
2020/08/12 19:17:16 [INFO] kontainerdriver rancherkubernetesengine stopped
2020/08/12 19:17:16 [WARNING] [etcd] Failed to take one-time snapshot on host [abcd], exit code [1]: time="2020-08-12T19:17:15Z" level=fatal msg="failed to upload etcd snapshot file: 413 Request Entity Too Large"


Meta audio and video search (WIP)

Fixes

Related to #923 by @annatuma
Description

Frontend is almost ready please review.
This adds the Images, Audio, Video tabs under the search and shows less filter options on selection of Audio or Video tabs.
It does not currently show active filter bolding on new page load.
Needs some cross browser work as well.
Needs to link to backend, backend needs to be added.
Notes
v-if changes of Filters/FiltersListVideo.vue and src/components/Filters/SearchGridFilterVideo.vue could be refactored to a single file maybe.
Screenshots

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Hello @Jujhar, we're going to move forward with a different branch for these changes. Implementing some of the back-end work required a different approach to the front-end (the 'images', 'audio', and 'video' tabs are now sub-routes in vue router). Thank you for your contribution and please feel free to work on other issues in the future!


Feature request: import/export to CSV

I have an existing table of stuff in CSV format. Moving it to resources, while fragmenting the data into multiple .tres files, would make parsing the data much easier...

Sound good! Converting to/from resources should be no problem.
The plugin was originally made to help projects that already use resources - If what you have is already a table, perhaps it should be worth expanding the plugin to access them directly? I'm already thinking of ways to refactor for that.

Parsing CSV in Godot 3.5 is a PITA currently (I have to do data[0] instead of data["name"], which becomes really nasty the more columns I have). If the extension could handle that transparently, akin to how Resources do that, then yes, expanding to access CSV directly is also an option.

Hmm. Sounds like your problem is easier to be solved by just creating an enum with all column names - column inserted, enum entry added.
Though I'm still working on csv -> resource import. Will notify here either way once I finish.

Alright, should be up on master! Import button is on the top bar.
Worth testing if the Color (from hex like #ff01c5), Bool (from some commonly used binary-classification words) and Resource (from "res://" paths) types get imported properly. Enums already work, but worth testing on other datasets.

Hope you didn't get too deep into that pile o' resources, because a way to ACTUALLY EDIT CSV FILES should now be up as well.
Known issues:

can't import a file more than once, property list won't change - to fix, delete the generated script and .tres in the .csv's folder
there can be a 5 sec delay before the CSV actually gets saved, so please don't go wild with refreshing the table after editing values. This was added to improve performance (csv can be huge, don't save 10x a second), but in retrospect the delay is too high. Delay can be tweaked in import_export/formats_edit/edit_csv.gd:36.

Doesn't seem to work in 3.5 - lots of errors in the output, mostly that replace() is called on nil.
This is regardless of me setting the column types to something or leaving them as String

Missing values? Rows don't have the same number of values? Enum properties named like built-in types? Space after commas breaks reading?
Should be fixed now. Let's see if I missed something else.

I think it was missing values/rows not having same number of values, I'll take a look later :)

Seems to work, but I'll double check with that earlier CSV with unequal rows ;)


Colab 'Namespace' object has no attribute 'clip_models'` error

    41 args = Namespace(**training_args)      42  ---> 43 net = ZSSGAN(args)      44       45 g_reg_ratio = 4 / 5     /content/stylegan_nada/ZSSGAN/model/ZSSGAN.py in __init__(self, args)           172                                                       lambda_texture=args.lambda_texture,           173                                                       clip_model=model_name)        --> 174                                 for model_name in args.clip_models}           175            176         self.clip_model_weights = {model_name: weight for model_name, weight in zip(args.clip_models, args.clip_model_weights)}       AttributeError: 'Namespace' object has no attribute 'clip_models'
While running sample colab notebook Step 3, this error happens. Is there any fix for this?

I am facing this error too; using colab.

Can you verify that you're using our own colab, with the link from the repo?
We had a pre-paper release version available for a few weeks which used a different set of arguments, and many of the derivative notebooks out there might still be based on that old version.
If the options in Step 3 don't look like the image below, you're not using an up-to-date notebook and that's probably the cause of the problem.

Yes, I am using the notebook provided in the repo. Step3 is exactly same as you've shown in the image.

Could you please copy-paste the code block from step 3? Or better yet, save a copy of the notebook with the error and upload it here?
I'm having no luck reproducing this error in Colab, and I want to make sure it's not some notebook sync issue before I dive deeper.

I cannot reproduce the error any more by using the latest Colab notebook.

Its working fine now. Thank you for your help, you may close the issue.


docs(typo): for better understanding

Looks good but travis has a problem with your second commit.
Did you do the second change on github directly?

@LKuechler  yes - good test if travis works ;)