[cherry-pick] Fix image pull after a failure

When resuming from a failed pull writer.Truncate() was not
seeking to the proper position in the file. This caused writes to
happen after the previously written content, instead of at the start
of the file.
Signed-off-by: Daniel Nephin<EMAIL_ADDRESS>

Codecov Report

Merging #1918 into release/1.0 will increase coverage by 0.04%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##           release/1.0   #1918      +/-   ##
==============================================
+ Coverage        50.66%   50.7%   +0.04%
==============================================
  Files               81      81
  Lines             7159    7161       +2
==============================================
+ Hits              3627    3631       +4
+ Misses            2849    2845       -4
- Partials           683     685       +2

Flag
Coverage Δ

#linux
50.7% <0%> (+0.04%)
:arrow_up:

Impacted Files
Coverage Δ

content/helpers.go
37.93% <0%> (ø)
:arrow_up:

content/local/writer.go
60% <0%> (+3.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba5fa0...63e1963. Read the comment docs.

Merge?


Usersessions

moving to https://github.com/nance-eth/nance-ts/tree/nextauth instead
(cookies were too hard to properly implement 😢 )


Action failed because brew link step did not complete successfully.

I'm not sure whether it is this action's issue or upstream's one, but brew install postgresql@14 fails on macos-13 runner.
One of logs:
https://github.com/YOCKOW/SwiftPQ/actions/runs/8219886490/job/22478357746#step:2:137

Also experiencing this.

So the root cause is how GHA installs Python and then injects it into the homebrew install paths, see Homebrew/homebrew-core#165793.
A quick and easy fix was simply removing any links into the Python install path.
- name: Remove GHA installed python symlinks that conflict with homebrew
  run: |
    find /usr/local/bin -lname '*/Library/Frameworks/Python.framework/*' -print -delete
- name: Launch PostgreSQL
  uses: ikalnytskyi/action-setup-postgres@74e396491e76c84f8ad92a4f5a69ab0deb75bbc2

Thank you for reporting. It seems I managed to fix this in master, and I plan to release a new version somewhere next week, once I take care of other opened issues.


What is Aggregate Trade Streams?

I've read official doc(https://github.com/binance-exchange/binance-official-api-docs/blob/master/web-socket-streams.md) but cannot understand completely.
Want to know when to use Aggregate Trade Streams and Trade Streams.
Could you give me some examples?

Aggregate means that it groups by something (price, for example), in this case the trade streams give info as "1 taker, 1 maker", the aggTrades as: "1 taker, N makers, at price X".

Thanks for the explanation. Btw, the "trade history" window in Binance site looks like "aggregate trade stream". Is that stream is normal? I mean "more commonly used" in any market(stock, cryptocurrency etc)?

@rightx2  I don't know I am not familiar with other markets, but for data visualization and analysis it would make sense to aggregate the trades as there are many individual trades happening at every moment

@tamycova sorry I still did not get it, are you saying that at the price of 5000 if 2 orders existed to buy say 1.5 BTC and 1.8 BTC  the aggregate trade stream would relay 1 order of 3.3 BTC at 5000 whereas the trade stream will forward both the orders separately?


Can't install on php 8.1

Pulse Version
1.0 beta5
Laravel Version
9.52.7
PHP Version
8.1.25
Livewire Version

Database Driver & Version
No response
Description
laravel/pulse dev-card-customisation requires php ^8.2 -> your php version (8.1.25) does not satisfy that requirement.
Steps To Reproduce
composer require laravel/pulse

What's "dev-card-customisation"?

@m-ostadi this is an old branch. You should use one of the tagged releases.


catch cannot be used with constructors

As discussed in #710. Example:
#[wasm_bindgen(constructor, js_namespace = WebAssembly, catch)]
pub fn new(table_descriptor: &Object) -> Result<Table, JsValue>;

error: paths with type parameters are not supported yet
    --> crates/js-sys/src/lib.rs:2998:50
     |
2998 |         pub fn new(table_descriptor: &Object) -> Result<Table, JsValue>;
     |                                                  ^^^^^^^^^^^^^^^^^^^^^^

@alexcrichton -- With your latest fix, I tried to write this code:
#[wasm_bindgen]
pub struct MyClass {
    inner: u32
}

#[wasm_bindgen]
impl MyClass {
    #[wasm_bindgen(constructor, catch)]
    pub fn new(inner: u32) -> Result<MyClass, JsValue> {

        Ok(MyClass{ inner })
    }

}

And I get this error:
error[E0277]: the trait bound `std::result::Result<MyClass, wasm_bindgen::JsValue>: wasm_bindgen::convert::IntoWasmAbi` is not satisfied
  --> lib.rs:6:1
   |
15 | #[wasm_bindgen]
   | ^^^^^^^^^^^^^^^ the trait `wasm_bindgen::convert::IntoWasmAbi` is not implemented for `std::result::Result<MyClass, wasm_bindgen::JsValue>`

Should this be supported?  Am I missing some wasm_bindgen annotation?

@eminence oh the error message there is pretty bad but the gist of it is that catch is only supported on imported functions, not exported functions.

ahh, ok.  got it!  (Could they eventually be supported on exported functions?)

Perhaps! One day we'll have panic::catch_unwind working (and panic=unwind mode working) though which I think will suffice

Does panic::catch_unwind work today?


VS code extension link

Hello,
I have recently updated the extension with some more features and uploaded the code to github.
Inside this pull request I added a link to the extension if that's ok with you.

Seems like VSC really likes to format code even with options turned off... I have updated the file, it should be correct now.

I made a mess with commits now.. if you can squash commits do that, else I will just reset the branch and do another pull request.


lazy loaded state, refresh page, localhost

Hi,
great job on lazy loading modules, really very useful.
I have on question, I think i followed the examples on ocLazyLoad and ui-router, everything wirks fine,
however I notice one issue, happening only on local, node.js app, on herokuaoo all works fine.
If I go to state that is resolved with ocLazyLoad for the first time all is well, if i refresh page, the controller for the state is not instantiated, this is console error:
Error: [ng:areq] http://errors.angularjs.org/1.2.14/ng/areq?p0=NotesController&p1=not aNaNunction%2C got undefined
at Error (native)
at https://code.angularjs.org/1.2.14/angular.min.js:6:450
at xb (https://code.angularjs.org/1.2.14/angular.min.js:18:360)
at Pa (https://code.angularjs.org/1.2.14/angular.min.js:18:447)
at https://code.angularjs.org/1.2.14/angular.min.js:63:94
at http://angular-ui.github.io/ui-router/release/angular-ui-router.js:2797:28
at A (https://code.angularjs.org/1.2.14/angular.min.js:50:23)
at h (https://code.angularjs.org/1.2.14/angular.min.js:43:83)
at https://code.angularjs.org/1.2.14/angular.min.js:42:255
at updateView (http://angular-ui.github.io/ui-router/release/angular-ui-router.js:2733:23)
Just curious, it might be something with either order of exectution, or cache ?
the app is deployed here, http://ngproject.herokuapp.com/#/main, all sources are unminified, could you please take a look ?
the lazyloaded state is /notes, NotesModule.js.....
Thank you in dvance
Martin

Hi, it seems not to work properly on my localhost when refresh the page many times. I have  already return promise in resolve, below  is my router config (I also attach a full sample here):
$.each(appConfig.usingModules, function(index, module) {                 if (typeof appConfig.moduleConfig != "undefined" && typeof appConfig.moduleConfig[module] != "undefined" && appConfig.moduleConfig[module]) {                     $stateProvider.state(module, {                         url: '/' + module,                         templateUrl: 'modules/' + module + '/index.html',                         resolve: {                             load: function($ocLazyLoad) {                                 return $ocLazyLoad.load({                                     name: module,                                     files: appConfig.moduleConfig[module].dependencies                                 }).then(function() {});                             }                         }                     });                 }             });
fw.zip
Could you please help me to check this? Thank you very much.


More examples

Provide a few more examples in the examples folder.
Checklist before submitting:

[x] No need for CHANGELOG.md entry
[ ] Not sure about testing needs here
[x] No need for documentation changes

Coverage remained the same at 90.449% when pulling bbd2a2784fdde98fa56e47cc302a66fdd7bd15e0 on ZoteTheMighty:more-examples into 4f06d948ea0312d2a941de80fa2b0a077d8f1f60 on Roblox:master.

Looks pretty good!


Unknown custom element:

How to fix this error ,thank
Unknown custom element:  - did you register the component correctly? For recursive components, make sure to provide the "name" option.

How did you fix it?


Boostrap for styling

Describe the solution you'd like
Currently, when we want to use Bootstrap for styling, everything breaks as we have some styles that are overwritten by Bootstrap stylesheets. This is causing extra work as we have to create custom styles for elements for which styles are readily available in Bootstrap
As part of this issue, we need to make sure that our application uses Bootstrap styles and remains stylistically the same.

Hi,
I'm interested in working on this issue. Could you please provide the branch where this work is being done? I wasn't able to find it in the current branch list, so any guidance on locating the relevant branch would be appreciated.


Bonus Phase Ideas

[ ] Convert to an FPS

[ ] Convert to VR

[ ] Publish game in itch.io
[ ] Multiplayer
[ ] Cutscenes (https://www.youtube.com/watch?v=WjThx-Bdn5g&lc=UgxWVgonCPa1TFVeMHZ4AaABAg)

[ ] AI Friend for the player (powerup or pick-up item?)

[ ] How about making the level move and letting the player at the center??? Kind of like Minecraft Dungeons.  And, making bigger levels! https://www.youtube.com/watch?v=CZiEKOGogYM  (https://www.youtube.com/watch?v=uMvAgn-LGTc&lc=Ugz0MnziqP_M82WmEGN4AaABAg)


Make a 1.3 release with 1.12 support

Let's make a 1.3 release that officially supports 1.12

https://github.com/bitnami/kube-prod-runtime/releases/tag/v1.3.0 :tada:


GAHM parameter convergence issue

@WPringle when trying the persistent fill with uniform error and GAHM I noticed a convergence error again! I didn't see this issue with Laura 2020 and Florence 2018. Please see the added test in the dev branch at:
https://github.com/noaa-ocs-modeling/EnsemblePerturbation/blob/3de55adf5e8e7fe83af851cbfda6d868614e1dbe/tests/test_perturb.py#L57-L90

@SorooshMani-NOAA Interesting, OK will take a look

@SorooshMani-NOAA It looks like this is happening in the persistent because the Rmax value becomes unreasonably small compared to the 64-kt isotach, which forces the B/Bg parameters to be extremely large to compensate. When this occurs it is really tricky to converge as it is so sensitive to small changes in the radial distance.
Previously I had set the limit of Rrat = Rmax/isotach_rad to be 0.999 which can cause Bg/B to be O(1e3). If we set this limit lower to 0.99 then Bg/B is O(1e2) and can converge.
This value of Bg/B is still rather high, if I further limit to say 0.95 it seems to always be below 100, and maximum of ~40. I think it's practically reasonable to limit Bg\B to O(10), so will go with 0.95..


1.17.1 Fabric Branch

Hi I have forked and created a 1.17.1 branch I'd like to PR which also involves a formatting clean up to match your forge layout, would you be able to create a fabric_1.17 branch for the PR so it doesn't overwrite any existing branches?

Hi I'm sorry I didn't see this!
yes I will create the branch.

Okay the branch is created.   I was sick for the last week and lupicus was sick before that so I got distracted.
I get messages on the discord more reliably, FYI.

Alright, thanks! PR sent. I did try to find your discord but had no luck.

/There should be an invite link to discord in all our mods.  if there isn't one in FixExperienceBug then I will add one

Here is the invite link pending me updating the page.
https://discord.gg/fmdRFmmvBj

I'm testing this in a production environment now- should be up within the hour.


do not check input/output balance if tx has inputs of unknown value

If transaction is not created with BWS, some of the inputs may have unknown value. In this case we cannot reliably check that tx is not spending more then specified by inputs, so these checks (both by Bitcore and BWS) will be disabled for such transactions.

Coverage increased (+0.009%) to 81.211% when pulling e476c7bab2a514582663916981a60f8bd10358d4 on troggy:relax-inputs-checks into 7f928b0afe92297e3da6559deb4b0da85f6382ab on bitpay:master.

guys, any chance this PR can get your attention?

Hi @troggy. I'm afraid I don't know enough about colored coins to thoroughly review this PR. Could you please explain how is it possible that the value of an input is unknown? Also, why skip validation for the full transaction (I mean, surely sum(inputs) >= sum(outputs) regardless of the value of some individual input)? Thanks!

@isocolsky there are two APIs: ColoredCoins API and Colu API. When you create transaction with CC API, you provide the funding for the token utxo and fees, so all the inputs are know and there is no problem to use such a tx with BWS.
Colu API is a something like high level wrapper for CC API, which allow user to issue and transfer assets without owning any bitcoins. When you create transaction with Colu API, Colu takes care of funding — it adds it's own input to the tx to pay for colored outputs and network fee. This input is connected to some unknown transaction (it is not on the blockchain at the moment tx is created) and we don't know the value of connected utxo.

Thank you for the explanation @troggy. How is bitcoind handling these transactions? Are they not broadcasted before their "parent" txs?

I broadcast such transactions with Colu API. I think internally it broadcasts both transactions in order. BWS then sees them as broadcasted by 3rd party.

I have a BWS fork with a very little changes (I created PRs for both) which is already working for awhile in production for Colu wallet as well as some other colored Copay-based wallets (like http://www.urv2.com.br/)
https://github.com/troggy/bitcore-wallet-service/tree/colu-2.7.0
These changes appear to be quite generic (though unusual), so my idea is to merge them to upstream so that others can benefit

Sorry the delay.
could you explain the rationale of this change and why it would be needed to include it on BWS master?
Other than that I add some minor comment and tests should be added. Thanks.

@troggy sorry the delay, is this still relevant?
Could you please add a extra config key to enable this behavior (in config.js) which should be disabled by default.


Remove useless VTK modules

nice but how did that happen though ?

nice but how did that happen though ?

No idea. I just noticed duplicates while working on something else

please make sure public is cleaned up too

it is


update BaseFileHelper Completed

Signed-off-by: jackSpanrrows<EMAIL_ADDRESS>BaseFileHelper 翻译完成

Q
A

Is bugfix?
yes/no

New feature?
yes/no

Breaks BC?
yes/no

Tests pass?
yes/no

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

已提交一版修改后的


Setup done

Related Tickets

#Ticket_ID

WHAT this PR does?

ex: Change number items completed/total in admin page.

Notes Impacted Areas

N/A.

Attachments

N/A.

mererd


key for hit_summary_files should be NT or NR

This completed validation on the small sample, see charles https://alpha.idseq.net/samples/508 vs boris https://alpha.idseq.net/samples/509;  identical.
Also produced excellent results on the RR008 tests where previously we were getting bogus spirometra hits;  now it's all filtered out;  just one bacterial species remains with too few reads to be a concern.


[Release 1.24] Fix spelling test

Backport: https://github.com/k3s-io/k3s/issues/7739

Closing as this is tested/validated in CI itself


Display message date

Resolves #24

If you wish: now there is a public beta also including your PR!
https://testflight.apple.com/join/066lEjQN


Update template for 0.6.0

This is a continuation of #26, based on @jeddenlea's PR. He's OOO for a few days, so this builds on that commit and adds an update to our CI script and uses the final 0.6.0 release version rather than the -beta3 pre-release.

Do we want to disallow POST requests?

Do we want to disallow POST requests?

Do we want to disallow POST requests?

That's a great question @fgsch! I'll quote @jeddenlea's original description here, which provided the rationale behind that change:

[..] While one
section of the code suggested that HEAD and POST requests were accepted,
they would later all be issued 404 responses. The vast majority of
Fastly services have no real need to support POST requests, so we
shouldn't imply they should in our blessed example templates.

What do you think?

Do we want to disallow POST requests?

That's a great question @fgsch! I'll quote @jeddenlea's original description here, which provided the rationale behind that change:

[..] While one
section of the code suggested that HEAD and POST requests were accepted,
they would later all be issued 404 responses. The vast majority of
Fastly services have no real need to support POST requests, so we
shouldn't imply they should in our blessed example templates.

What do you think?

@katie-martin-fastly sorry, I missed that.
That's interesting. The default VCL will handle this as a pass, but so it does for other methods.
I have no details for what % of customers use POST so I suppose it's ok.
@triblondon do you have any thoughts on this?

@katie-martin-fastly sorry, I missed that.
That's interesting. The default VCL will handle this as a pass, but so it does for other methods.
I have no details for what % of customers use POST so I suppose it's ok.
@triblondon do you have any thoughts on this?

No apology needed! I ought to have copied that over when I opened this, it's hard to transfer context across PR's.

No apology needed! I ought to have copied that over when I opened this, it's hard to transfer context across PR's.

The prior version of the template did not actually allow POSTs at all, it only maybe looked like it did.  And, this hasn't been a problem.
I don't believe it is ideal that the default VCL passes POSTs by default, let alone OPTIONS, PUT, PATCH, DELETE, and literally everything else.  The default VCL is pretty wide open, without much judgement about exactly what someone means to built atop Fastly; it just aims to cache what may be cacheable and send everything else to the origin.  But, most services simply deliver content, which implies just GET (and maybe HEAD).  And those which do need POSTs almost certainly do not want to handle POSTs on any arbitrary URL.
Inevitably, folks will end up using the platform by copy/pasting stuff together.  For instance, it has already proved difficult to get folks to write things like S3 authentication code that isn't wide open to signing any method, including DELETE.  So, I think it makes sense to provide a simple locked down example.  If someone wants to add support for POSTs to their service, it should be obvious how to do it.  And, if they want to allow POST but not PUT, DELETE, PATCH, etc., that will be easier to do.
We should create some examples of handling POSTs entirely at the edge; that is something much more difficult to handle in VCL so there probably aren't many good examples to port from VCL to Rust.

The prior version of the template did not actually allow POSTs at all, it only maybe looked like it did.  And, this hasn't been a problem.
I don't believe it is ideal that the default VCL passes POSTs by default, let alone OPTIONS, PUT, PATCH, DELETE, and literally everything else.  The default VCL is pretty wide open, without much judgement about exactly what someone means to built atop Fastly; it just aims to cache what may be cacheable and send everything else to the origin.  But, most services simply deliver content, which implies just GET (and maybe HEAD).  And those which do need POSTs almost certainly do not want to handle POSTs on any arbitrary URL.
Inevitably, folks will end up using the platform by copy/pasting stuff together.  For instance, it has already proved difficult to get folks to write things like S3 authentication code that isn't wide open to signing any method, including DELETE.  So, I think it makes sense to provide a simple locked down example.  If someone wants to add support for POSTs to their service, it should be obvious how to do it.  And, if they want to allow POST but not PUT, DELETE, PATCH, etc., that will be easier to do.
We should create some examples of handling POSTs entirely at the edge; that is something much more difficult to handle in VCL so there probably aren't many good examples to port from VCL to Rust.

I rolled the rest of the changes that @doramatadora thoughtfully added in #29 into this branch, including copy edits, rust-toolchain modifcations, and the addition of code owners. With that, I'll close #29 and hopefully this should be ready to merge!
Thank you to both @jeddenlea and @doramatadora for your work updating this template, and apologies about the confusion. I think together, we made a much more thorough diff :slightly_smiling_face:

I rolled the rest of the changes that @doramatadora thoughtfully added in #29 into this branch, including copy edits, rust-toolchain modifcations, and the addition of code owners. With that, I'll close #29 and hopefully this should be ready to merge!
Thank you to both @jeddenlea and @doramatadora for your work updating this template, and apologies about the confusion. I think together, we made a much more thorough diff :slightly_smiling_face:

I noticed I had accidentally updated the manifest_version in fastly.toml in my changes, sorry about that!

I noticed I had accidentally updated the manifest_version in fastly.toml in my changes, sorry about that!


IPROTO-265 Remove additional byte[] allocations for nested writers

Add new subWriter method to implement to allow reusing encoder instances
Add some common default methods to the TagWriter/TagReader interfaces
Add common way to write a fixed varint of 5 bytes

https://issues.redhat.com/browse/IPROTO-265
https://issues.redhat.com/browse/IPROTO-266
Also added changes to allow for custom Decoder/Encoder instances to be used instead of the supplied ones.

Performance for writers, where I was able to completely remove all additional byte[] instances
NEW
Benchmark                                      (byteArrayOrStream)  (userByteArraySize)  Mode  Cnt     Score    Error  Units
ProtostreamBenchmark.testMarshallAddress                      true                  N/A  avgt    6   444.554 ±  2.691  ns/op
ProtostreamBenchmark.testMarshallAddress                     false                  N/A  avgt    6   424.578 ±  6.260  ns/op
ProtostreamBenchmark.testMarshallIracMetadata                 true                  N/A  avgt    6   567.723 ±  7.429  ns/op
ProtostreamBenchmark.testMarshallIracMetadata                false                  N/A  avgt    6   540.126 ±  5.248  ns/op
ProtostreamBenchmark.testMarshallUser                         true                   10  avgt    6  1886.560 ± 15.246  ns/op
ProtostreamBenchmark.testMarshallUser                         true                 8096  avgt    6  3659.781 ±  8.508  ns/op
ProtostreamBenchmark.testMarshallUser                        false                   10  avgt    6  1851.959 ± 33.655  ns/op
ProtostreamBenchmark.testMarshallUser                        false                 8096  avgt    6  2799.700 ±  7.628  ns/op

6.4.3-SNAPSHOT
Benchmark                                      (byteArrayOrStream)  (userByteArraySize)  Mode  Cnt     Score    Error  Units
ProtostreamBenchmark.testMarshallAddress                      true                  N/A  avgt    6   483.135 ±  2.088  ns/op
ProtostreamBenchmark.testMarshallAddress                     false                  N/A  avgt    6   736.977 ±  2.959  ns/op
ProtostreamBenchmark.testMarshallIracMetadata                 true                  N/A  avgt    6  1112.077 ± 20.424  ns/op
ProtostreamBenchmark.testMarshallIracMetadata                false                  N/A  avgt    6  1342.824 ±  4.419  ns/op
ProtostreamBenchmark.testMarshallUser                         true                   10  avgt    6  2600.131 ± 42.651  ns/op
ProtostreamBenchmark.testMarshallUser                         true                 8096  avgt    6  5377.703 ± 15.728  ns/op
ProtostreamBenchmark.testMarshallUser                        false                   10  avgt    6  2869.619 ± 27.668  ns/op
ProtostreamBenchmark.testMarshallUser                        false                 8096  avgt    6  4899.339 ± 23.065  ns/op

6.4.2.Final
Benchmark                                      (byteArrayOrStream)  (userByteArraySize)  Mode  Cnt     Score    Error  Units
ProtostreamBenchmark.testMarshallAddress                      true                  N/A  avgt    6   488.974 ±  2.547  ns/op
ProtostreamBenchmark.testMarshallAddress                     false                  N/A  avgt    6   736.031 ±  6.277  ns/op
ProtostreamBenchmark.testMarshallIracMetadata                 true                  N/A  avgt    6  1102.625 ±  5.741  ns/op
ProtostreamBenchmark.testMarshallIracMetadata                false                  N/A  avgt    6  1343.379 ±  4.145  ns/op
ProtostreamBenchmark.testMarshallUser                         true                   10  avgt    6  2607.106 ± 34.377  ns/op
ProtostreamBenchmark.testMarshallUser                         true                 8096  avgt    6  5378.692 ± 22.828  ns/op
ProtostreamBenchmark.testMarshallUser                        false                   10  avgt    6  2856.660 ± 20.676  ns/op
ProtostreamBenchmark.testMarshallUser                        false                 8096  avgt    6  4904.252 ± 13.979  ns/op

Unfortunately, reading a stream is not as beneficial as there is no easy way to skip ahead with marks that doesn't conflict with the isAtEnd method. I will post the perf numbers for reads later today, but I expect byte array based TagReaderImpl to have faster performance.

Read perf isn't quite as good as I would hope yet, going to look at it some more tomorrow.
NEW
Benchmark                                    (byteArrayOrStream)  (userByteArraySize)  Mode  Cnt     Score    Error  Units
ProtostreamBenchmark.testUnmarshallAddress                  true                  N/A  avgt    6   138.618 ±  2.057  ns/op
ProtostreamBenchmark.testUnmarshallAddress                 false                  N/A  avgt    6   406.437 ±  2.792  ns/op
ProtostreamBenchmark.testUnmarshallMetadata                 true                  N/A  avgt    6   301.055 ±  2.816  ns/op
ProtostreamBenchmark.testUnmarshallMetadata                false                  N/A  avgt    6   582.103 ± 12.788  ns/op
ProtostreamBenchmark.testUnmarshallUser                     true                   10  avgt    6   704.985 ±  7.099  ns/op
ProtostreamBenchmark.testUnmarshallUser                     true                 8096  avgt    6  1429.527 ±  9.361  ns/op
ProtostreamBenchmark.testUnmarshallUser                    false                   10  avgt    6  1057.003 ± 34.231  ns/op
ProtostreamBenchmark.testUnmarshallUser                    false                 8096  avgt    6  2674.062 ±  4.725  ns/op

4.6.3-SNAPSHOT
Benchmark                                    (byteArrayOrStream)  (userByteArraySize)  Mode  Cnt     Score    Error  Units
ProtostreamBenchmark.testUnmarshallAddress                  true                  N/A  avgt    6   137.458 ±  1.184  ns/op
ProtostreamBenchmark.testUnmarshallAddress                 false                  N/A  avgt    6   331.708 ±  2.669  ns/op
ProtostreamBenchmark.testUnmarshallMetadata                 true                  N/A  avgt    6   304.312 ±  2.491  ns/op
ProtostreamBenchmark.testUnmarshallMetadata                false                  N/A  avgt    6   514.835 ±  2.664  ns/op
ProtostreamBenchmark.testUnmarshallUser                     true                   10  avgt    6   712.873 ±  7.157  ns/op
ProtostreamBenchmark.testUnmarshallUser                     true                 8096  avgt    6  2282.761 ±  8.351  ns/op
ProtostreamBenchmark.testUnmarshallUser                    false                   10  avgt    6  1040.317 ±  9.922  ns/op
ProtostreamBenchmark.testUnmarshallUser                    false                 8096  avgt    6  2683.187 ± 21.002  ns/op

Not finding any way to speed up the InputStream version more than it is. Our final usage though will be using ByteBuf which can more easily take advantage of the read changes similar to the ByteBuffer since it can use a slice instead.

I have some more changes after this is integrated that will test ByteBuf perf.
A preview of what state they are currently is the following:
Benchmark                                      (serializationType)  (userByteArraySize)  Mode  Cnt     Score   Error  Units

ProtostreamBenchmark.testMarshallAddress                  BYTE_BUF                  N/A  avgt    6   272.715 ± 4.272  ns/op
ProtostreamBenchmark.testMarshallIracMetadata             BYTE_BUF                  N/A  avgt    6   497.901 ± 3.265  ns/op
ProtostreamBenchmark.testMarshallUser                     BYTE_BUF                   10  avgt    6  1020.351 ± 9.291  ns/op
ProtostreamBenchmark.testMarshallUser                     BYTE_BUF                 8096  avgt    6  1109.903 ± 9.272  ns/op
ProtostreamBenchmark.testUnmarshallAddress                BYTE_BUF                  N/A  avgt    6   180.323 ± 1.314  ns/op
ProtostreamBenchmark.testUnmarshallMetadata               BYTE_BUF                  N/A  avgt    6   366.013 ± 2.660  ns/op
ProtostreamBenchmark.testUnmarshallUser                   BYTE_BUF                   10  avgt    6  1152.420 ± 8.283  ns/op
ProtostreamBenchmark.testUnmarshallUser                   BYTE_BUF                 8096  avgt    6  2040.321 ± 6.300  ns/op

So the write perf is amazing as it uses a pooled ByteBuf instance, reads for User is a bit odd though, going to be looking closer.

I have added a new commit that allows for custom Encoder/Decoder instances to be used which is how I was able to do the test for ByteBuf based encoder and decoders.

https://github.com/infinispan/infinispan-benchmarks/pull/18 is the benchmark PR testing that requires these changes and found those results.

I pushed review comments. Let me know if it is okay and I can squash the commit.

Updated

merged! thanks @wburns !


Dutch localisation

Hi @kjac ,
The Dutch translation is ready to be merged.
Thanks,
Arjan

Awesome @Vrijdagonline, much appreciated! 👍
I'll push a new release tomorrow, or maybe even tonight if I can make it.


proposal: generic pointer

this introduces a new type to the language, denoted "*".
this proposal shall consist of:

Motivation: a documented set of real world problems targeted
Suite of test cases: smoke tests, demonstrate usage, stress the implementations
Implementations: a maintained patch series for various go compilers, kept up to date with upstream
Design doc? needs help due to new process
appengine Playground: closed due to bugs
changes to go/doc/go_spec.html : not yet written

Motivation:
Static typed reusable collection. Due to type safety and boxing, EFACE (interface{}) cannot be used. Due to bloat and maintenance issues in a context of open source, code generation shall be avoided at any cost. Upstream ticket: https://github.com/Workiva/go-datastructures/issues/65
Test suite
Link list - a smoke test. expected to evolve as this proposal matures.
https://github.com/anlhord/gpt.git
Implementations:
gccgo gofrontend
git: https://github.com/anlhord/gpt.git
thread: https://groups.google.com/forum/#!topic/gofrontend-dev/VOtbIKclOPo
Compatibility impact:
Fully backward compatible. (Programs written for Go version 1.x will continue to compile and work with this proposal)

How is this different from unsafe.Pointer?

Ian wrote on gofrontend-dev:
In your past messages about this, I have not been able to understand
what you are proposing.  I still don't understand.  You are presenting
patches when you need to present documentation.

I agree. Starting with implementation is usually not a great idea for something as subtle as this. Especially if you want others to understand what you are doing, you need to write documentation. And explaining things while writing the documentation is often a way to find problems.
As far as I can tell from looking at your test suite (really one program) and the "Activate the wildcard checking" patch, what you are calling "" is basically "void" in C. It is an untyped pointer that can read or written as any other pointer type. As you seem to admit the motivation section, this violates the type safety of Go. We're not going to make changes to Go that give up type safety. That's very important to the design of Go.
In Workiva/go-datastructures#65, though, you describe this as "1-parametric polymorphic functions", so maybe I am misunderstanding. Let's say the proposal is instead some kind of notation for polymorphic functions over a single type parameter where the type parameter must be a pointer. That's at least type safe, but it is a stop-gap. If we later figured out how to do general polymorphic functions well in Go, we'd be stuck supporting both that and this one-off. Taking the long view, that doesn't seem wise.
For both these reasons I suggest we decline this proposal.

So is there a plan for N - parametric polymorphism?

type safety is guaranteed, because in a body of function the generic pointer cannot be cast, copied to concrete pointer. all generic pointer typed variables originate from a concrete function call site (function arguments), where *foo becomes *. the function then manipulates the *foo pointers without knowing actual types.
it's true that this proposal is too weak compared to multi parametric polymorphism like templates in c++:
    template<class T1, class T2> struct Can_copy {
        static void constraints(T1 a, T2 b) { T2 c = a; b = a; }
        Can_copy() { void(*p)(T1,T2) = constraints; }
    };

however Rusell please consider. a reason why 1 parametric might be enough is that often in practice it's possible to reduce a problem that at first glance requires multi parametric polymorhpism to former.
lets say
func DoWithTwoTypes<t1 , t2> (foo *t1, bar *t1, baz *t2) {
   ...
}

can be split to
 func DoWith(foo *, bar *) chain {
     ...
  }
  func (c chain) AndWith(baz *) {
    }

then used:
   DoWith(a,b).AndWith(c)

@anlhord you are proposing a significant language change, yet this proposal is very light on detail, particularly in terms of motivation and rationale.
The Go project's development process is primarily design-driven. Right now, a lot of your proposal exists only inside your head. To have your proposal considered seriously, you must thoroughly explain its goals, rationale, spec, implementation plan, and tradeoffs.
Here are some resources that might help you better understand our development process:

https://github.com/golang/go/wiki/DesignDocuments
https://github.com/golang/proposal/blob/master/design/TEMPLATE.md
http://talks.golang.org/2015/how-go-was-made.slide

However,  I think it unlikely that this proposal would be accepted, as it seems (to me) at odds to Go's general design philosophy.

Closing due to timeout. We can reopen if there's a concrete proposal.


Linux & Windows Builds

Linux:

[x] treewatch support
[x] libgit build
[x] go build

Windows:

[x] treewatch support
[x] libgit build
[x] go build

Removed all cgo :)


Author pkaijun collation

Pull Request Test Coverage Report for Build 269

0 of 12 (0.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 80.778%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/investigapptor/logic/commands/CloseCaseCommand.java
0
12
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/investigapptor/logic/commands/CloseCaseCommand.java
1
0.0%

Totals

Change from base Build 260:
0.0%

Covered Lines:
2513

Relevant Lines:
3111

💛  - Coveralls


It shows that first token is always for free

This is because of integer rounding in the bonding curve contract. I don't think this would be much of an issue though.


Fix type annotations incorrectly highlighted as modules.

Previously, we were always treating :: as a module, but Rust
allows type annotations using :: e.g.
parse::<i32>();

r? @huonw
(rust_highfive has picked a reviewer for you, use r? to override)

My solution doesn't quite work with foo::bar::baz, will reopen once I've fixed it.


Using host templates to store provider keys, adding hosts with them

We are going to use hostTemplates for storing/using sensitive parts of hosts’ configs (like access key).
While it is possible to store more than just credentials in the host template, the user experience in caas will be to just put the sensitive fields in the host template.
We need to make sure the API to manage (CRUD) host templates works and hosts can be created with host templates (then used, then deleted).
Additionally, it would be nice if the API validated that the selected hostTemplate had a driver field that matches the config that was set on the host:

hostTemplate has driver string field that will have a value like "digitalocean"
host has fields like digitaloceanConfig

Impl note: the validation can be done in the class MachineValidationFilter
Deliverables: test plan, validation tests, (possibly) bug fixes

Note: We need to ensure that host template names are unique

https://github.com/rancher/rancher/issues/8807

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Documentation

Can we get the documentation viewable somewhere? The flight website links to the readme.
The GH Wiki allows the community to contribute easily... And you can have menus and such to make navigation easy...

I like this idea.

Hey! I'd love to see an updated, modern Flight website with full documentation and examples. It's just a case of when we'll have time to work on it!

@phuu I would like to learn flight.js but there's no real doco, which is why I suggested using the Wiki, atleast then its easy for the community to contribute to the doco so it takes the burden off you.
Maybe 60% of the doco for Nancy framework isn't written by us, its written by the community. Any errors always corrected by the community.
Working examples can be linked to jsfiddle or similar.

Have to agree with @phillip-haydon and @phuu, when I first read about flight it sounds like a delight. The README and the API Documentation are great resources. But a web page with more literature and examples would be awesome!

I'd love to help on adding documentation / building out a modern website. Should we have a different repo for this?

Cool! My approach would be to keep the docs in the same repo as the code and use a build task to commit them in website form to a gh-pages branch.
The build-step approach might be wrong but I think it's important to keep the docs beside the code, so commits can contain both and be checked for consistency.

@phuu I'd say lets improve the current docs first, maybe starting by adding more examples. We can turn them into a Jekyll site in no time later.
Good examples could be:

managing the lifecycle of a group of components in a page
PJAX-ing with flight
integration with Boostrap
In general FAQ kind of articles.

All this needs is for @phuu to open the Wiki so we can contribute to it.
But this has taken too long I've lost interest in helping now. Will move on to another framework. I'll leave this open for you but I'm unsubscribing.

@phillip-haydon I am ok with that although I think that keeping the docs in the same repo is better for a simple reason: when you tag a new release the docs reflect that version state.
Also people can contribute with pull requests already, although that's not as straightforward as editing a wiki :)

The documentation is OK for what we have now — there's unlikely to be any more core Flight development, so going to close this for now.


Update audit-streaming.md

Removed the content based on https://harness.atlassian.net/browse/PL-38717
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Can't define a minimum number of itens before clustering

is there a way to define a minimum number of itens before clustering?

@fernandocani Did you find any solution?

FYI, I solved it overriding:

And exploding the items if below mi desired threshold.


Option to merge the meshes of map props

Map props, when imported, are separated by material. This is just a thing Monolith does, so I'm not exactly surprised by this. However I know for a fact that one "prop" (referred to here as ModelGroupIndex) just consists of a number of meshes. An option to combine these meshes based on the that index would help streamline a lot of extra work.
Alternatively, grouping by identical positions also seems to work well. Here is an incredibly slow Python script that demonstrates what I mean:
import bpy
from mathutils import *;
from math import *;

collection = bpy.context.collection

objdict = dict(location = (0.0, 0.0, 0.0), object = None)

for obj in collection.objects:
    if obj.type != 'MESH':
        continue
    if obj.location.length <= 0:
        continue

    vec = obj.location[:]
    if vec in objdict:
        parent = objdict[vec]

        bpy.context.view_layer.objects.active = parent
        parent.select_set(True)
        obj.select_set(True)

        bpy.ops.object.join()

        parent.select_set(False)
    else:
        objdict[vec] = obj

A combination of the two is likely the best option. It sounds like it would break everything nice about using the same mesh in multiple nodes, but amazingly this method preserves all of that. I'm not really quite sure how.

Map props, when imported, are separated by material.

Switching materials requires changing GPU state and needs another draw call. Each mesh in Blender corresponds to the data structure for a draw call in the binary file without any additional splitting.

An option to combine these meshes based on the that index would help streamline a lot of extra work.

I'll try and look into using collection instances instead of linked duplicates (alt+d) for meshes. The map format technically instances groups of meshes instead of individual meshes like you mentioned. This should also cover your use case in #29 if the base collection is at the origin and hidden. Characters don't use instancing, so this shouldn't interfere with anyone doing model edits.
https://docs.blender.org/manual/en/latest/scene_layout/object/properties/instancing/collection.html

Collection instances would be perfect, actually! It should still be able to make use of GPU instancing but also be easy to throw into an asset library, best of both worlds.
There is one concern though: I'm unsure what Blender's behavior for exporting collection instances is. If it treats everything all the same as if its nodes were separate instances, there may not be an issue. But if it exports them as empties, that might not be ideal for the people that export the whole map in one go. I wouldn't envy having to fix thousands of props by hand...

There is one concern though: I'm unsure what Blender's behavior for exporting collection instances is.

What export format and program are you planning on using? I can't guarantee a seamless experience outside of Blender, but it would be helpful for my testing to see how people are actually using the models.

For exporting out to Unity or other game engines, I'd personally just use fbx.

Just tested with https://github.com/BlockBuilder57/xenoblade_blender/commit/e8330f4998e95406c185000f25fc516b43be356d and a normal fbx output does in fact retain the meshes properly. No concern needed!


Adding new incoming call event for call automation. Related work item…

…: 3954169
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.CallAutomation


SESv2 Variables Mismatch

I am trying to use AWS SESV2 and using moto stand alone server to mock sendEmail when I came across a bug I believe!
Comparing this file moto/sesv2/models.py to what AWS sendEmail inputs should be on SESV2, it doesn’t seem like variable names are matching up!
I don’t use python much, but can give it a try at fixing! I also wanted to bring it up in case I am just completely off base!
Here is the AWS document -> https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_SendEmail.html#API_SendEmail_RequestSyntax

Hi @sbeninga! The inputs are read in responses.py, and those variables line up as far as I can see. We even have a few tests that verify that everything works as expected here.
https://github.com/getmoto/moto/blob/2e9b903ab6a4d1e2309543519249b85fd81e319b/moto/sesv2/responses.py#L28
Are you running into any specific issues, where Moto isn't behaving exactly the same as AWS? If so, can you share a reproducible test case?


Add support for  "Reopen pull request" button

Just noticed we'er also currently missing support for "Reopen issue" buttons as well.


updated website view tests

I updated the website views test cases with the changed post endpoint name, different phone numbers, and updated success message.

Run tests with 'python manage.py test'

I can, or I can implement some mocking so we don't have to rely on actual case data, which changes.

Actually, I'm not sure how to mock a request made within another request. I can just change the case number for now.

Actually, I'm not sure how to mock a request made within another request. I can just change the case number for now.

The trick to mocking calls from inside another request is to mock it with the full context from where it is being called:
e.g.

some_module.py
from some_library import some_function

def another_function():
    return some_function()

test.py
import some_module

@mock.patch('some_library.some_function')
def test_one(self):
    result = some_library.another_function()

hope this helps.

Awesome, thanks jdungan. I'll get to work on that and commit again


Add layer on renewal script to check if running

Is your feature request related to a problem? Please describe.
Sometimes Secondary renewal script takes more than 24 hours to complete and cron starts another thread of the script due to the multiple retries for the same certs.
Describe the solution you'd like
Add layer to script to check if renewal script is running then don't start and send the alert

@cpswan - Please review the below PR and let me know if you see any enhancements.
https://github.com/atsign-company/secondaries-scripts/pull/47


Add entries to support PIV for RSAA

🗣 Description
Add a staging and development CNAME entry to support PIV authentication for RSAA.

💭 Motivation and context
In order to support PIV passthrough, a new domain and function are required.
These entries are for RSAA to be able to pass PIV information to the Okta backend.

🧪 Testing
Name resolution will be tested using dig or similar tools.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] All new and existing tests pass.

@jmorrowomni - I applied these changes to production, so you can go ahead and verify functionality while we review.

Please update the terraform-docs output in README.md.

@jsf9k Please see 6d94b252a38d171a28683a805976675c67571f14

@jmorrowomni - I applied these changes to production, so you can go ahead and verify functionality while we review.

@dav3r Testing looks good, thanks!

@jmorrowomni - I applied these changes to production, so you can go ahead and verify functionality while we review.

@dav3r Testing looks good, thanks!

It was me who applied the changes so you could test, not @dav3r. :cry:

@jmorrowomni - I applied these changes to production, so you can go ahead and verify functionality while we review.

@dav3r Testing looks good, thanks!

It was me who applied the changes so you could test, not @dav3r. 😢

I saw that Dave liked your comment so he was the last name in my mind!  You know I <3 you @jsf9k


Small fix in HL Composer NOTES.txt

Signed-off-by: Alejandro Vicente Grabovetsky<EMAIL_ADDRESS>What this PR does / why we need it:
Small fix in HL-Composer notes to correctly obtain API key
Special notes for your reviewer:
N/A
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/lgtm


Month view (demo): color example not working

There is no longer a color prop as of v3.0.0, so closing this.


Need rcpt command

Q
A

Bug report?
Yes

Feature request?
No

RFC?
No

How used?
Symfony

Swiftmailer version
3.2.5

PHP version
7.2.8

Observed behaviour
Trying to send mail, getting the following error:
Uncaught PHP Exception Swift_TransportException: "Expected response code 354 but got code "503", with message "503 5.5.2 Need rcpt command [mail.server.com]
It would appear that the RCPT command never gets sent to the server.
Expected behaviour
The mail should send successfully.
Example
In my trouble shooting, I sidestepped Symfony and I lifted the code directly from the docs and I was still getting the error:

// Create the Transport
$transport = (new Swift_SmtpTransport('smtp.example.org', 25))
->setUsername('your username')
->setPassword('your password')
;
/*
You could alternatively use a different transport such as Sendmail:
// Sendmail
$transport = new Swift_SendmailTransport('/usr/sbin/sendmail -bs');
*/
// Create the Mailer using your created Transport
$mailer = new Swift_Mailer($transport);
// Create a message
$message = (new Swift_Message('Wonderful Subject'))
<EMAIL_ADDRESS>=> 'John Doe'])
<EMAIL_ADDRESS><EMAIL_ADDRESS>=> 'A name'])
->setBody('Here is the message itself')
;
// Send the message
$result = $mailer->send($message);

@jknigga Did you find a solution for this?

@bhulsman Nope, I never did.

I've had the same error message here. Turned out it actually was a relaying issue - unfortunately the exception is thrown on "503 5.5.2 Need rcpt command", while the previous answer "550 5.7.1 Unable to relay" has been ignored. This lead me on a wrong path for quite a while. Here's a tcp dump:

Hope this helps anyone...

Is this related to #1240 ? I am experiencing the same issue:
Expected response code 354 but got code "503", with message "503 5.5.2 Need rcpt command "


wordpress: add {pre,post}Install hooks

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 210880 run on x86_64-linux 1

1 package built:

wordpress (wordpress6_1)

Result of nixpkgs-review pr 210880 run on x86_64-linux 1

1 test built:

nixosTests.wordpress


Reduce Ledger dependencies and move stats to FullNode

See each commit for explanation. The first two commit is not strictly related but was found while working on this, and CI isn't cheap those days.

🟢

This apparently broke the stats, PR incoming.


ERR_DLOPEN_FAILED bluetooth error

Anyone experiencing this error please message me on discord and I can explain a solution
https://discord.gg/cMGhNtZ3tW

Hi, the link expired, I'm experiencing this issue, can you post the workaround?

You need to uninstall and reinstall the plugin.
If you do this without restarting homebridge after uninstalling, then this won’t affect your accessories.
you can restart after installing the plugin again


modal里的单选按钮偏移

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info

Package Name And Version<EMAIL_ADDRESS>Browser: chrome98.0.4758.109
Reproduction Link: https://codesandbox.io/s/purple-waterfall-p4n9j4?file=/index.js

What is expected?
不要偏移

不好意思我这里没有复现诶


Can it support configuring multiple collections on the source side in a task?

Can it support configuring multiple collections on the source side in a task?

yeah, sure. You can migrate a whole db if the collection param is not set. For multiple collection, currently you can only define multiple source config instead. As the transformer connector not support multiple collection. We will make collection param a list in the future to better support this.
For example:
curl --location --request POST 'http://<IP_ADDRESS>:5801/hazelcast/rest/maps/submit-job'
--header 'Content-Type: application/json'
--data-raw '
{
"env": {
"execution.parallelism": 2,
"job.mode": "BATCH"
},
"source": [
{
"plugin_name": "Milvus",
"url": "https://in01-.aws-us-west-2.vectordb.zillizcloud.com:19530",
"token": "",
"database": "default",
"collection": "book",
"result_table_name": "book"
},
{
"plugin_name": "Milvus",
"url": "https://in01-.aws-us-west-2.vectordb.zillizcloud.com:19530",
"token": "",
"database": "default",
"collection": "book2",
"result_table_name": "book2"
}
],
"sink": [
{
"plugin_name": "Milvus",
"source_table_name": "book",
"url": "https://in01-.aws-us-west-2.vectordb.zillizcloud.com:19542",
"token": "",
"database": "default",
"batch_size": 10
},
{
"plugin_name": "Milvus",
"source_table_name": "book2",
"url": "https://in01-.aws-us-west-2.vectordb.zillizcloud.com:19542",
"token": "",
"database": "default",
"batch_size": 10
}
]
}
'

got it，thanks~


[Bug] [Master] Worker failover cause task repeat run

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
We have a long run mapreduce task, which will duration a few hours, like 12hours. After we doing worker and master rolling restart, this mr task keep submit to yarn every 10 mins, and the old one failed to kill as we found the error log.
Finally, this task repeat submit many mr instance cause out yarn cluster run out of resources.
Our version is 2.0.7
After, we diging into the code, we found something about the worker failover within MasterRegistryClient
private boolean checkTaskAfterWorkerStart(List<Server> workerServers, TaskInstance taskInstance) {
        if (StringUtils.isEmpty(taskInstance.getHost())) {
            return false;
        }

        Date taskTime = taskInstance.getStartTime() == null ? taskInstance.getSubmitTime() : taskInstance.getStartTime();

        Date workerServerStartDate = getServerStartupTime(workerServers, taskInstance.getHost());
        if (workerServerStartDate != null) {
            return taskTime.after(workerServerStartDate);
        }
        return false;
    }

The failover code use the start_time  of task intance,  instead of submit_time. And start_time will not update every NEED_FAULT_TOLERANCE, the submit_time is the updated one. Which cause task submit again and again, because this mr task will not finsih within the failover check interval, which is 10min
And here is the code in version 3.x
// The worker is active, may already send some new task to it
        if (taskInstance.getSubmitTime() != null && taskInstance.getSubmitTime()
            .after(needFailoverWorkerStartTime.get())) {
            LOGGER.info(
                "The taskInstance's submitTime: {} is after the need failover worker's start time: {}, the taskInstance is newly submit, it doesn't need to failover",
                taskInstance.getSubmitTime(),
                needFailoverWorkerStartTime.get());
            return false;
        }

What you expected to happen
Worker failover should use submit_time to judge
And also, we wanna to know that, if there is a hive sql task or shell task, and when worker failover happen, will this sql task repeat run, because we can not found the code about kill the hive sql. If not, may it be a problem?
How to reproduce

create process with a mr task, which run longer than the failover check interval
submit a process instance
restart worker
check how many mr task submit on yarn

Anything else
No response
Version
2.0.x
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

How about the progress of this issue

This seems to be this issue https://github.com/apache/dolphinscheduler/issues/12482, it has been fixed, can you use the 2.0.8 branch to test it. @KEN-LJQ

@wcmolin Hi, I'm afraid that not the same question, and I tested branch 2.0.8-prepare still has problem. Cause the root problem is using start_time to judge whether process should failover, although it had just failover

Can you teach me to build a shell task to test, I don't have the operating environment of mr task here

@wcmolin here is the reproduce step with shell task

set master config master.failover.interval of master.properties to 1
create shell task with cmd sleep 2m
run shell task
while shell task running, restart worker server
this moment shell task should be failover, and check what happend while every master failover check

In this test , shell task should re-run every minute.
The key step is, make sure the task run longer than master failover interval, that why I set master failover every minute and let shell sleep 2 minute
Maybe you can try with this.


Error opening .pbit file

On opening the pbit and doing the initial refresh, this error appears
TVM_DeviceConfigurationAssesmentKB
The column 'RelatedMitreTechniques' of the table wasn't found.

You can open "Transform Data", Select TVM_DeviceConfigurationAssesmentKB, Advanced Editor, and remove the following rows (including the trailing comma):
,
#"Expanded RelatedMitreTechniques" = Table.ExpandListColumn(#"Expanded ConfigurationBenchmarks", "RelatedMitreTechniques"),
#"Expanded RelatedMitreTactics" = Table.ExpandListColumn(#"Expanded RelatedMitreTechniques", "RelatedMitreTactics")
and replace #"Expanded RelatedMitreTactics" at the bottom with Table"


Add workers support

Currently CDR uses libsodium directly in the event loop. This is completely fine for things like hashing, generating random strings and encrypting messages but when larger binary data is being encrypted, you will notice it.
The obvious next step is to add workers support. Few open questions with this.

Should it use workers for everything? Is there a point where it's slower to create a worker than use the main loop?
How should CDR deal with concurrency? Should it do some basic rudimentary thread scheduling to avoid creating 4+n workers at the same time on 4 core CPU?

Deliverables

[ ] automated worker support
[ ] ability to disable worker usage
[ ] ability to set worker concurrency

Initial tests show that workers do increase total computing time a lot with smaller tasks like computing password hashes. On average it takes ~500ms to compute a secure password hash. If you do it in the worker, total time bounces up to ~900ms. I haven't done any deeper benchmarking but I'm willing to bet that ~400ms goes to setting up the worker and initializing sodium.
I need to think a bit how to go forward. Worker support might make sense only with the data encryption and decryption at first. Even with that CDR needs to check whether the incoming data is large enough that it makes sense to create a worker for it.


Bump scalacheck version to 1.14.0

Not using new features, just version bump due to the binary incompatibility.

That'd be very useful for downstream dependencies (e.g. https://github.com/typelevel/discipline/issues/52).

Bumped to scala 2.13.0-M3 to pass CI. M4 is blocked by https://github.com/rickynils/scalacheck/pull/411.

Regarding the check failures: this happens because Travis switches JDK alternatives before actually installing the package. The fastest solution would probably be adding
jdk_switcher use $TRAVIS_JDK_VERSION

to the beginning of the build script.
Just my two cents to keep this rolling.

scalacheck 1.14.0 for M4 is now on maven central

Rebased onto #1378, but probably still need to deal with missing PagedSeq. (#1379)

Superseded by #1383.


cmd/go: go:embed errors attributed to the wrong file

What version of Go are you using (go version)?

$ go version
go version go1.16beta1 linux/amd64

Does this issue reproduce with the latest release?
Haven't tried on tip.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/light/.cache/go-build"
GOENV="/home/light/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/light/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/light"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/light/sdk/go1.16beta1"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/light/sdk/go1.16beta1/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16beta1"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/light/src/foo/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build4010338713=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Run go build on:
https://play.golang.org/p/HR-SdE2vE8c
What did you expect to see?
bar/bar.go:5:1: pattern xxx.txt: no matching files found

What did you see instead?
The line number is for the import of the package with the go:embed directive:
foo.go:5:2: pattern xxx.txt: no matching files found

Further, running go build ./bar outputs no line numbers:
pattern xxx.txt: no matching files found

I would expect to see the same output as what I expected above.

Further, running go build ./bar outputs no line numbers:
pattern xxx.txt: no matching files found

I would expect to see the same output as what I expected above.

/cc @rsc @bcmills @jayconrod @matloob

/cc @rsc @bcmills @jayconrod @matloob

Looks like there are no cmd/go tests for the no matching files found and invalid pattern syntax error messages, and the existing tests for the adjacent pattern …: cannot embed … errors lack anchors — so they aren't testing for the correct file or line numbers. 😞

Looks like there are no cmd/go tests for the no matching files found and invalid pattern syntax error messages, and the existing tests for the adjacent pattern …: cannot embed … errors lack anchors — so they aren't testing for the correct file or line numbers. 😞

This is a release blocker for 1.16: go:embed is new in 1.16, and misattributing the file may mean that we're also misattributing the module, which could get very confusing for transitive errors in modules deep in the module cache.

This is a release blocker for 1.16: go:embed is new in 1.16, and misattributing the file may mean that we're also misattributing the module, which could get very confusing for transitive errors in modules deep in the module cache.

The fix for this looks pretty small. We just need to resolve embeds a little lower in Package.load, after we push the path onto the import stack. That distinguishes errors in the importing and imported packages.
I'll wait a bit to send a fix until we decide how to resolve #43632, since that will affect tests.

The fix for this looks pretty small. We just need to resolve embeds a little lower in Package.load, after we push the path onto the import stack. That distinguishes errors in the importing and imported packages.
I'll wait a bit to send a fix until we decide how to resolve #43632, since that will affect tests.


Remove unneeded selfs in Byebug::History and fix typos

Minor improvements to consistency of instance variables in Byebug::History to better match Ruby conventions.
I also searched for typos using cspell. I manually fixed the obvious typos that were reported (and ignored tons of false positive matches).

@ddzz Sorry for the delay getting to this. Can you rebase this PR? I'm mostly neutral on the instance variable changes, but I guess it does simplify things a bit so let's do it. I believe you could also remove the attr_accessor for :size if we use the instance variable directly?


feat(container): default readOnlyRootFilesystem to true

Setting readOnlyRootFilesystem property to true in a container denies access to any malicious actor to tamper with the local disk.
Signed-off-by: Vinayak Kukreja<EMAIL_ADDRESS>Resolves https://github.com/cdk8s-team/cdk8s-plus/issues/815

💚 All backports created successfully

Status
Branch
Result

✅
k8s-22/main

✅
k8s-23/main

Questions ?
Please refer to the Backport tool documentation


MINOR: call the serialize method including headers from the MockProducer

Currently when using serializers like the Cloud Event Serializer, we need to do a work around so it doesn't throw an error. Using the method taking the headers would prevent this. Since the default implementation just calls the method without the headers, it's expected to be fully backwards compatible.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Can someone please provide some feedback?


feat: support media variants parameter at GET /2/tweets/search/stream

Example response from id<PHONE_NUMBER>786623488
{
  "data": {
    "attachments": {
      "media_keys": [
        "13_1582838602551148545"
      ]
    },
    "author_id": "532779460",
    "conversation_id": "1582843050786623488",
    "created_at": "2022-10-19T21:16:05.000Z",
    "edit_history_tweet_ids": [
      "1582843050786623488"
    ],
    "entities": {
      "urls": [
        {
          "start": 257,
          "end": 280,
          "url": "https://t.co/K1BqvDKX6C",
          "expanded_url": "https://twitter.com/snyyankees/status/1582838645240668160/video/1",
          "display_url": "pic.twitter.com/K1BqvDKX6C",
          "media_key": "13_1582838602551148545"
        }
      ]
    },
    "id": "1582843050786623488",
    "text": "Luis Severino, absolute legend.\n\nQ: Is it hard playing in Houston, where the fans hate the Yankees?\n\nA: \"I mean, everywhere we go we're not liked... The only place that they really like us a little bit is Tampa because they don't have a lot of fans there.\"\nhttps://t.co/K1BqvDKX6C"
  },
  "includes": {
    "media": [
      {
        "height": 1080,
        "media_key": "13_1582838602551148545",
        "preview_image_url": "https://pbs.twimg.com/media/FfdfW8GWYBAC3_0.jpg",
        "type": "video",
        "variants": [
          {
            "content_type": "application/x-mpegURL",
            "url": "https://video.twimg.com/amplify_video/1582838602551148545/pl/boQ5Zw3JHyqnd3rD.m3u8?tag=14&container=fmp4"
          },
          {
            "bit_rate": 832000,
            "content_type": "video/mp4",
            "url": "https://video.twimg.com/amplify_video/1582838602551148545/vid/540x540/w5rrF5a3cGJK3pO6.mp4?tag=14"
          },
          {
            "bit_rate": 432000,
            "content_type": "video/mp4",
            "url": "https://video.twimg.com/amplify_video/1582838602551148545/vid/320x320/vbnY71IaiEDtxOJl.mp4?tag=14"
          },
          {
            "bit_rate": 1280000,
            "content_type": "video/mp4",
            "url": "https://video.twimg.com/amplify_video/1582838602551148545/vid/720x720/jJayJVpiTaI2rtw8.mp4?tag=14"
          }
        ],
        "width": 1080
      }
    ],
    "users": [
      {
        "id": "532779460",
        "name": "Yair Rosenberg",
        "profile_image_url": "https://pbs.twimg.com/profile_images/1245175387577073664/pkpiIqTq_normal.jpg",
        "username": "Yair_Rosenberg"
      }
    ],
    "tweets": [
      {
        "attachments": {
          "media_keys": [
            "13_1582838602551148545"
          ]
        },
        "author_id": "532779460",
        "conversation_id": "1582843050786623488",
        "created_at": "2022-10-19T21:16:05.000Z",
        "edit_history_tweet_ids": [
          "1582843050786623488"
        ],
        "entities": {
          "urls": [
            {
              "start": 257,
              "end": 280,
              "url": "https://t.co/K1BqvDKX6C",
              "expanded_url": "https://twitter.com/snyyankees/status/1582838645240668160/video/1",
              "display_url": "pic.twitter.com/K1BqvDKX6C",
              "media_key": "13_1582838602551148545"
            }
          ]
        },
        "id": "1582843050786623488",
        "text": "Luis Severino, absolute legend.\n\nQ: Is it hard playing in Houston, where the fans hate the Yankees?\n\nA: \"I mean, everywhere we go we're not liked... The only place that they really like us a little bit is Tampa because they don't have a lot of fans there.\"\nhttps://t.co/K1BqvDKX6C"
      }
    ]
  },
  "matching_rules": [
    {
      "id": "1582841965435097088",
      "tag": "followers-1"
    }
  ]
}

@cgrinds
Looks good! Thank you for contributing!


Centered layout for widescreen displays

This is quite convenient and amazingly enough, it's (almost) working!
The only thing I feel should be changed is to use the same terminology for cluster types as in CloudMan?
Setting a custom volume size does not work (a default-size volume gets created instead) - this is probably an issue in CloudMan not reading the pss value over the one defined in a flavor template.
(I'd work on some of this as well but am at a conference today and tomorrow so am likely to have only minutes at a time)

I just realised that the I've been committing to the same branch and the pull request has been updated :-) Yes, I've just been making the necessary changes to cloudman and have been doing some refactoring as well. I'll push in the changes soon - just doing some final testing.

About the terminology - I was wondering about that - it's just that "Test" cluster seems to suggest that it's just for Testing purposes? I was just wondering whether it would make sense to a first time user, hence the slight change in labelling - but I don't really mind either way.

Going back to the terminology - this is probably a good opportunity to revise the terminology in CloudMan itself because, as you say, there's probably a text that makes the intent more clear.
In the mean time, I'm merging this because it's a feature I'm very glad to finally see implemented.


Add support for model(s): DR-HCF521S   (aka CLF521S ceiling fan/light)

Include all of the following:

Model - DR-HCF521S
https://www.dreo.com/products/dreo-clf521s-smart-ceiling-fan
Number of speeds the fan supports (not including "off"): 12
Does the fan support oscillating? no
What preset modes are supported? Normal, Natural, Sleep
Is temperature supported? no

Make sure you've installed this integration, then from the integration settings page, select Download Diagnostics and attach that file. diagnostics attached!  Please note, i have two identical ceiling fans connected if that matters. I can remove one if that helps.
config_entry-dreo-01JCRTVFYSD8FTHQTDS1MV96CV.json
Thanks for this great integration! Please let me know if I can provide further helpful info!

Sorry if this is a dupe request for an existing device. I'm new to HA and how these integrations work.  I can't tell if my diagnostic info is showing DR-HCF001S because that's detected and correct, or if I assigned it as the closest match.
The ceiling fan light has adjustable color temperature, and dimming functionality that isn't currently obviously accessible in the existing integration.


✨ Component: Avatar

[ ] Implementation
[ ] Example
[ ] Animation
[ ] Storybook/Histoire
[ ] Tests
[ ] Docs

Working on this


docs: fixed link to Jacob Hands repo + small formatting consistencies

fixed link to Jacob Hands repo
small formatting consistencies

trailing space
line wrapping
double new lines

Thanks a lot for contributing @mountainash :)


[STILL DONT MERGE] Rework several IOCTLs to not depend on hv_ definitions

Summary of the PR
The kernel interfaces are being update to not depend on hv_ definitions directly.
Update the relevant IOCTLs to work with the new interfaces.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:

[x] All commits in this PR have Signed-Off-By trailers (with
git commit -s), and the commit message has max 60 characters for the
summary and max 75 characters for each description line.
[x] All added/changed functionality has a corresponding unit/integration
test.
[x] All added/changed public-facing functionality has entries in the "Upcoming
Release" section of CHANGELOG.md (if no such section exists, please create one).
[x] Any newly added unsafe code is properly documented.

I can see you remove all the Synic Features and related codes, Where are those now?

LGTM

@liuw @russell-islam The cloud hypervisor build/clippy should still be failing, but it's now passing because it's ignoring the [patch] section??
It is showing this message now:
warning: Patch `mshv-bindings v0.3.0 (/home/runner/work/mshv/mshv/mshv/mshv-bindings)` was not used in the crate graph.

Also, I can't repro this locally. It just fails to build (as it should) when patch the mshv crates.

@liuw @russell-islam The cloud hypervisor build/clippy should still be failing, but it's now passing because it's ignoring the [patch] section and continuing to use v0.2.0! It shows this message:
warning: Patch `mshv-bindings v0.3.0 (/home/runner/work/mshv/mshv/mshv/mshv-bindings)` was not used in the crate graph.
Patch `mshv-ioctls v0.3.0 (/home/runner/work/mshv/mshv/mshv/mshv-ioctls)` was not used in the crate graph.
Check that the patched package version and available features are compatible
with the dependency requirements. If the patch has a different version from
what is locked in the Cargo.lock file, run `cargo update` to use the new
version. This may also occur with an optional dependency that is not enabled.

Also, I can't repro this locally. It just fails to build (as it should) when patch the mshv crates.

We can merge this PR and use it in CLH. Will that fix the issue?

We can merge this PR and use it in CLH. Will that fix the issue?

The issue is: the Cloud Hypervisor Build workflow is passing. But, that's wrong, it should be failing because upstream CLH is not up to date with this PR. So something is wrong with the workflow.

Patching in CLH is not working then.

We can merge this PR and use it in CLH. Will that fix the issue?

No. That would just hide the issue.
The issue is: the Cloud Hypervisor Build workflow is passing. But, that's wrong, it should be failing. It should fail because upstream CLH is not up to date with this PR (that will be fixed in cloud-hypervisor/cloud-hypervisor#6428). So, something is wrong with the workflow.

Can you compare the command you use for local builds and the command in the workflow.
I see that workflow builds don't use --locked.

@NunoDasNeves  is it ready to merge now?

@NunoDasNeves is it ready to merge now?

Nuno told me it is.


Field of type "annotated_text" is not searchable

I'm using locally built dejavu cloned from github repo with local elasticsearch.
I'm experimenting with new elasticsearch feature that allows to store and query annotated text https://www.elastic.co/guide/en/elasticsearch/plugins/6.6/mapper-annotated-text-usage.html
However fields of type "annotated_text" are not searchable in dejavu data browser and displayed with ellipsis (...)
How can I make "annotated_text" fields visible and searchable?
Many thanks!

@mindis thank you for bringing this up,
Will add this in the upcoming release 👍

@mindis I checked this, it is not part of default types, it available after installing a plugin, for any such special cases you can define your mappings, using Add mapping button.


XMLHttpRequest cannot load....

Thanks for your work on this adapter.
I am receiving the following error on a GET request
XMLHttpRequest cannot load https://api.quarqrace.com/api/v1/races/. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:4200' is therefore not allowed access.
I found your answer to this situation on stackoverflow: http://stackoverflow.com/questions/33587349/not-able-to-make-request-to-backend-server-in-ember-error-no-access-control-a/33613549#33613549
The solution you proposed required modification on the server, is this the only way?  I can access the JSON from my browser at https://api.quarqrace.com/api/v1/races/?format=json
Here is the Response Header:
HTTP/1.1 200 OK Content-Type: application/json Content-Length: 2790 Connection: keep-alive Allow: GET, POST, HEAD, OPTIONS Cache-Control: max-age=0 Cache-Control: public,max-age=10 Content-Encoding: gzip Date: Thu, 24 Mar 2016 23:11:16 GMT Expires: Thu, 24 Mar 2016 23:11:16 GMT Last-Modified: Thu, 24 Mar 2016 23:11:16 GMT Server: nginx/1.8.0 Vary: Accept X-Frame-Options: SAMEORIGIN X-Cache: Miss from cloudfront Via: 1.1 1de8c600b9b99e57b61a04b0965781b9.cloudfront.net (CloudFront) X-Amz-Cf-Id: PAHLLR-PfTw_EuLRYCLU7u0cSAnZ8mpXrjSBdzDLgtMKNq3hhpAR5w== Request Headers view source
Thanks for your help!

Using curl I was able to get a JSON response using -u and -H flags; without those flags I receive the same response headers.  Is there a way I can add these attributes to the headers to the request generated by ember-django-adapter?
Both curl requests are show below in case that helps.
Thanks again,
Wayne
Without the flags:
~ 🍔  curl -I https://api.quarqrace.com/api/v1/races/
HTTP/1.1 200 OK
Content-Type: text/html; charset=utf-8
Connection: keep-alive
Allow: GET, POST, HEAD, OPTIONS
Cache-Control: public,max-age=10
Date: Fri, 25 Mar 2016 00:42:46 GMT
Server: nginx/1.8.0
Set-Cookie: csrftoken=ZrjNDFRdEslNAxwwpo3dvbN2PC0rMvzp; expires=Fri, 24-Mar-2017 00:42:46 GMT; Max-Age=31449600; Path=/
Vary: Accept, Cookie
X-Frame-Options: SAMEORIGIN
X-Cache: Miss from cloudfront
Via: 1.1 1f5200ace72953cff28f9982c5f15365.cloudfront.net (CloudFront)
With the flags:
~ 🍔  curl -u wayne@iofusion.com:passwordEditedOut -H "Accept: application/json" https://api.quarqrace.com/api/v1/races/
[{"id":447,…..}]

Your requests are going across origins, so they are subject to the cross origin resource sharing standard. There is no way to make your browser connect to 'api.quarqrace.com' without them setting the access-control-allow-origin heading.
One way around this is to make your API act as a proxy to the API in request, i.e "api.yoursite.com/api/v1/races" makes your backend make a request to "api.quarqrace.com".

Thanks for the response.  I was able to get the server team to update CORS headers and now things are running smoothly.


net: ipv6: Drop RA with MTU out of valid range

This commit fixes incorrect Ethernet frame check sequence and ICMPv6
checksum caused by MTU set to zero in RA
Fixes #6342
Signed-off-by: Ruslan Mstoi<EMAIL_ADDRESS>

Codecov Report

Merging #6536 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6536      +/-   ##
==========================================
- Coverage   53.36%   53.36%   -0.01%
==========================================
  Files         435      435
  Lines       41308    41309       +1
  Branches     7922     7922
==========================================
  Hits        22046    22046
- Misses      16044    16045       +1
  Partials     3218     3218

Impacted Files
Coverage Δ

subsys/net/ip/ipv6.c
23.7% <0%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069fce7...83533e9. Read the comment docs.


Adds function and tests to make skipping for specific engines easier

Thanks @julianhille!


Improve collect_unicast_peers

Pull Request (PR) description
As described in #304, collect_unicast_peers will add the local source IP to the list of unicast_peers. Currently this is a rather cosmetic problem, but it may confuse someone unfamiliar with the module who's looking at the configuration file.
Also, the ideal contents for unicast_src_ip which will match the rest of the configuration is determined by the module, but it is never explicitly added to it. Instead we're relying on Keepalived to come to the same result. I added it to the template (still overridable by setting unicast_source_ip explicitly) and moved it's fragment below "if $collect_unicast_peers" for this to work.
This Pull Request (PR) fixes the following issues
Fixes #304

@frank-f can you please rebase?

this looks a bit odd. The PR contains commits that are already in master. Can you take a look again and rebase please? If you've questions about it you can always join our IRC channel #voxpupuli on Libera.Chat.


Help to build the examples

Hello,
I'm trying to run these examples on my ubuntu 18.x VM.
I managed to install pybullet and numpy.But when i run the test, i get this
Traceback (most recent call last):
File "", line 1, in
ImportError: No module named ss
Thanks for your help.
When i try to run to run the kuka test, i also get some errors
pybullet build time: Mar  5 2019 09:25:16
Traceback (most recent call last):
File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/thermo/Documents/dev/ss-pybullet/examples/test_kuka_pick.py", line 5, in
from pybullet_tools.kuka_primitives import BodyPose, BodyConf, Command, get_grasp_gen,
File "/home/thermo/Documents/dev/ss-pybullet/pybullet_tools/kuka_primitives.py", line 4, in
from .pr2_utils import get_top_grasps
File "/home/thermo/Documents/dev/ss-pybullet/pybullet_tools/pr2_utils.py", line 11, in
from .utils import multiply, get_link_pose, joint_from_name, set_joint_position, joints_from_names,
File "/home/thermo/Documents/dev/ss-pybullet/pybullet_tools/utils.py", line 20, in
from motion_planners.rrt_connect import birrt, direct_path
ModuleNotFoundError: No module named 'motion_planners'
Thanks for your help,
Michael

Hi Michael,
Run the following commands to update a submodule that ss-pybullet depends on. I've updated the installation instructions to include these directions.
$ cd ss-pybullet
$ git submodule update --init --recursive
Caelan

Hello Caelan,
I'm able to run the example now but getting this. I ran the PR2 example and
it ran fine. Do you know what might be going on?
Thanks
/Documents/dev/ss-pybullet$ python3 -m examples.test_kuka_pick
pybullet build time: Mar  5 2019 09:25:16
ven = VMware, Inc.
b3Printf: b3Warning[examples/Importers/ImportURDFDemo/BulletUrdfImporter.cpp,126]:
b3Printf: No inertial data for link, using mass=1,
localinertiadiagonal = 1,1,1, identity local inertial frame
b3Printf: b3Warning[examples/Importers/ImportURDFDemo/BulletUrdfImporter.cpp,126]:
b3Printf: base_link
Body id: 0 | Name: simple_cuboid | Rigid: True | Fixed: True
Link id: -1 | Name: base_link | Mass: 0.0 | Collision: 9 | Visual: -1
Body id: 1 | Name: flat_terrain | Rigid: True | Fixed: True
Link id: -1 | Name: base_link | Mass: 0.0 | Collision: 1 | Visual: -1
Body id: 2 | Name: simple_cuboid | Rigid: True | Fixed: False
Link id: -1 | Name: base_link | Mass: 0.1 | Collision: 9 | Visual: -1
Traceback (most recent call last):
File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/thermo/Documents/dev/ss-pybullet/examples/test_kuka_pick.py",
line 76, in
main()
File "/home/thermo/Documents/dev/ss-pybullet/examples/test_kuka_pick.py",
line 53, in main
command = plan(robot, block, fixed=[floor], teleport=False)
File "/home/thermo/Documents/dev/ss-pybullet/examples/test_kuka_pick.py",
line 13, in plan
grasp_gen = get_grasp_gen(robot, 'top')
File "/home/thermo/Documents/dev/ss-pybullet/pybullet_tools/kuka_primitives.py",
line 180, in get_grasp_gen
end_effector_link = link_from_name(robot, TOOL_FRAMES[robot_name])
File "/home/thermo/Documents/dev/ss-pybullet/pybullet_tools/utils.py",
line 1221, in link_from_name
raise ValueError(body, name)
ValueError: (0, 'iiwa_link_ee_kuka')
numActiveThreads = 0
stopping threads
Thread with taskId 0 exiting
Thread TERMINATED
destroy semaphore
semaphore destroyed
destroy main semaphore
main semaphore destroyed
finished
numActiveThreads = 0
btShutDownExampleBrowser stopping threads
Thread with taskId 0 exiting
Thread TERMINATED
destroy semaphore
semaphore destroyed
destroy main semaphore
main semaphore destroyed
On Tue, Mar 5, 2019 at 10:02 AM Caelan Garrett<EMAIL_ADDRESS>wrote:

Closed #2 https://github.com/caelan/ss-pybullet/issues/2.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/caelan/ss-pybullet/issues/2#event-2181233173, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADU7Y3IDefnaKomWKyX5u52x6HGsnyzuks5vTocUgaJpZM4beytF
.

I fixed an issue with the kuka's URDF path. It should work again now.

still getting this after the update.
python3 -m examples.test_kuka_pick
pybullet build time: Mar  5 2019 09:25:16
ven = VMware, Inc.
b3Printf: b3Warning[examples/Importers/ImportURDFDemo/BulletUrdfImporter.cpp,126]:
b3Printf: No inertial data for link, using mass=1,
localinertiadiagonal = 1,1,1, identity local inertial frame
b3Printf: b3Warning[examples/Importers/ImportURDFDemo/BulletUrdfImporter.cpp,126]:
b3Printf: base_link
Body id: 0 | Name: simple_cuboid | Rigid: True | Fixed: True
Link id: -1 | Name: base_link | Mass: 0.0 | Collision: 9 | Visual: -1
Body id: 1 | Name: flat_terrain | Rigid: True | Fixed: True
Link id: -1 | Name: base_link | Mass: 0.0 | Collision: 1 | Visual: -1
Body id: 2 | Name: simple_cuboid | Rigid: True | Fixed: False
Link id: -1 | Name: base_link | Mass: 0.1 | Collision: 9 | Visual: -1
Traceback (most recent call last):
File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/thermo/Documents/dev/ss-pybullet/examples/test_kuka_pick.py",
line 76, in
main()
File "/home/thermo/Documents/dev/ss-pybullet/examples/test_kuka_pick.py",
line 53, in main
command = plan(robot, block, fixed=[floor], teleport=False)
File "/home/thermo/Documents/dev/ss-pybullet/examples/test_kuka_pick.py",
line 13, in plan
grasp_gen = get_grasp_gen(robot, 'top')
File "/home/thermo/Documents/dev/ss-pybullet/pybullet_tools/kuka_primitives.py",
line 182, in get_grasp_gen
end_effector_link = link_from_name(robot, TOOL_FRAMES[get_body_name(robot)])
KeyError: 'simple_cuboid'
numActiveThreads = 0
stopping threads
Thread with taskId 0 exiting
Thread TERMINATED
destroy semaphore
semaphore destroyed
destroy main semaphore
main semaphore destroyed
finished
numActiveThreads = 0
btShutDownExampleBrowser stopping threads
Thread with taskId 0 exiting
Thread TERMINATED
destroy semaphore
semaphore destroyed
destroy main semaphore
main semaphore destroyed
On Tue, Mar 5, 2019 at 12:57 PM Caelan Garrett<EMAIL_ADDRESS>wrote:

I fixed an issue with the kuka's URDF path. It should work again now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/caelan/ss-pybullet/issues/2#issuecomment-469785043,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADU7YzL9hx5xbpgIqoqRZMcorDwxeVudks5vTrABgaJpZM4beytF
.

Hmm, what's in master is currently working for me. Can you check that that following URDF paths are correct?
https://github.com/caelan/ss-pybullet/blob/1d5f0b76422ca140a84c6098eb6497b73e21f9cd/pybullet_tools/utils.py#L40


Update the C# word count program

The C# word count program does not count word occurrences. Instead it counts words. This is not in sync with the description and the script earlier in the article that states that the program counts word count occurrences. My fix will make the job definition script pass and also will make the behavior and output match what is described in the article.

@dsajanice,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@dsajanice, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

@dsajanice : Thanks for your contribution to the Azure documentation! The author, @mumian, has been notified to review your proposed change.

#sign-off

@dsajanice,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


False Positive

I came across a pretty strange error using this validator.  The following code:
p {
    line-height:24px;
}

(note the blank line before the start of the CSS) generates this result:
{ validity: false,
  errors:
   [ { line: '0',
       errortype: 'parse-error',
       context: '\n                            ',
       errorsubtype:
        '\n                                skippedString\n                            ',
       skippedstring:
        '\n                                Lexical error at line 1, column 1.  Encountered: "" (0), after : ""\n                            ',
       type: 'generator.unrecognize',
       message:
        '\n        \n                                Parse Error\n                            ',
       error: '\n                        ' } ],
  warnings: [] }

However, running that exact code through the official W3C web validator (https://jigsaw.w3.org/css-validator/validator) returns no errors.  And removing the empty line before the code removes the error.
I shouldn't have to say this but ... it's allowed in CSS to have blank lines before your styles start!

Hmm, that is strange and I'm seeing the same issue on the website. I'm really curious what it could be since we're more/less an HTTP request wrapper. Digging into this further

I'm unable to reproduce the issue locally. Here's me forcing an error:
$ cat tmp.css

p {{
    line-height:24px;
}

$ node bin/css-validator tmp.css
tmp.css:4:
    Parse Error
$

and here's me with the submitted error case:
$ cat tmp.css

p {
    line-height:24px;
}

$ node bin/css-validator tmp.css
$

I even tried a bunch of space/empty line combinations as well as an empty file but have been unable to get it to trigger
Can you provide me the following info:

What version of Node.js are you running?
What OS are you running?
How are you running css-validator? Is it in another project? On the CLI? Programatically?

What version of Node.js are you running?

v11.7.0

What OS are you running?

Linux (doubt this matters)

How are you running css-validator? Is it in another project? On the
CLI? Programatically?

Programatically.  I read in a file and then fed the contents to the
validator.  I couldn't figure out why the file was getting errors, so I
deleted down to the simplest working part, and then undid the last change
(the blank line before the selector) and saw it give me the error again.
I can sympathize if you aren't able to repro from that, but unfortunately
that's all I can offer.
On Wed, Feb 20, 2019 at 1:54 PM Todd Wolfson<EMAIL_ADDRESS>wrote:

I'm unable to reproduce the issue locally. Here's me forcing an error:
$ cat tmp.css
p {{
line-height:24px;
}
$ node bin/css-validator tmp.css
tmp.css:4:
Parse Error
$
and here's me with the submitted error case:
$ cat tmp.css
p {
line-height:24px;
}
$ node bin/css-validator tmp.css
$
I even tried a bunch of space/empty line combinations as well as an empty
file but have been unable to get it to trigger
Can you provide me the following info:

What version of Node.js are you running?
What OS are you running?
How are you running css-validator? Is it in another project? On the
CLI? Programatically?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/twolfson/css-validator/issues/11#issuecomment-465770272,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbZjNSGgA_7TP5jxih5_DMat5vGPxygks5vPcQmgaJpZM4bFyaQ
.

OS matters in case there's different line endings (e.g. \r\n for Windows)
Cool, I'm running<EMAIL_ADDRESS>I'll poke around some more with this new info. Thanks!

If it helps this also generates an error:
body, html {
    margin:0;
    height:100%;
    background-color:#E8E8E4;
    font-size:14px;
}
p {
    line-height:24px;
}

With the same error:
[ { line: '0',
    errortype: 'parse-error',
    context: '\n                            ',
    errorsubtype:
     '\n                                skippedString\n                            ',
    skippedstring:
     '\n                                Lexical error at line 1, column 1.  Encountered: "" (0), after : ""\n                            ',
    type: 'generator.unrecognize',
    message:
     '\n        \n                                Parse Error\n                            ',
    error: '\n                        ' } ]

Yep, tried CLI and programmatic usage in 11.7.0. No issues still:
$ cat tmp.js
var validateCss = require('./');

validateCss({
  text: `

body, html {
    margin:0;
    height:100%;
    background-color:#E8E8E4;
    font-size:14px;
}
p {
    line-height:24px;
}`
}, function (err, data) {
  console.log(err, data);
});
$ n use 11.7.0 tmp.js
null { validity: true, errors: [], warnings: [] }

How are you running it programmatically?

My code is literally just:
const validateCss = require('css-validator');
const allCss = await getCombinedCss(cssFileNames);
const cssValidationErrors = await getCssValidationErrors(allCss);
(followed by a console.log of the errors) where "getCombinedCss" is just a
function that combines all of a student's CSS files into a single string.
On Wed, Feb 20, 2019 at 2:26 PM Todd Wolfson<EMAIL_ADDRESS>wrote:

Yep, tried CLI and programmatic usage in 11.7.0. No issues still:
$ cat tmp.js var validateCss = require('./');
validateCss({
text: body, html {    margin:0;    height:100%;    background-color:#E8E8E4;    font-size:14px;}p {    line-height:24px;}
}, function (err, data) {
console.log(err, data);
});
$ n use 11.7.0 tmp.js null { validity: true, errors: [], warnings: [] }
How are you running it programmatically?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/twolfson/css-validator/issues/11#issuecomment-465780254,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAbZjKZcS-LKj3gNL4raAclPkkWAVj7Vks5vPcuMgaJpZM4bFyaQ
.

Sorry, I can't do much else without seeing the rest of the code or finding out that the issue is something else (e.g. generators are misbehaving, file contents are loading async, file contents are a buffer instead of a string)
I'd recommend copy/pasting the code snippets I've provided and verifying there are no issues with those. If there isn't, then it's likely something besides the newline (maybe GitHub is removing hidden characters on paste)
Going to close the issue for now =/


Update googletest or increase C++ standard?

The current googletest submodule refers to gtest-1.8.1 back from 2019. Newer versions (current 1.13.0) need C++14, while the library uses C++11 for GNU compilers and on Darwin, which leads to build failures for some of the unit tests[1]
Are there any objections on either updating the googletest submodule and the unit tests or dropping the C++11 requirement? A local test shows[2], that it seems to build at least on linux systems if C++11 is dropped from the CMakeLists.txt file.
[1] https://bugs.gentoo.org/895180
[2] https://github.com/gentoo/gentoo/pull/29644

Hi Bernd,
Thank you so much for reaching out. We do not have reservations and will upgrade the submodule accordingly.
Best,
Alex

Hi @waebbl ,
please give the develop branch a try now. Since #311 , you should be fine now.
Cheers!

Hi @martinweismann,
thank you very much for updating. On my test, the build and tests now work with the current googletest.
Best,
Bernd


Tasks and Timeline

[ ] Clone this repo, go to greact branch and start understanding the code.
[ ] Checkout storybook

@deep-guy and @devilizer, please have a look on these above and keep the deadline in mind.