Peer listening port reports closed, but router shows port opened by UPNP and Canyouseeme.org can see serviec

What is the issue?
The Peer listening port is reported as closed in Transmission settings on MacOS 13.2.1.

However, my router shows the port as being opened by Transmission.

MacOS firewall is allowing incoming connections for Transmission.
### Which application of Transmission?
Canyouseeme.org shows that the port is visible

Files are transferring ok, so it may be the test in the settings panel that is not working correctly.
Which version of Transmission?
4.0.1

In case this is an IPv4 vs IPv6 problem, these two commands in a Terminal would test them separately:
curl -4 https://portcheck.transmissionbt.com/{port-number}; echo
curl -6 https://portcheck.transmissionbt.com/{port-number}; echo

IPv4 version returns 1
IPv6 version returns 0

@titer @ckerr After our efforts to get that problem with IPv6 fixed, I finally wanted to test with my own Transmission-GTK 3.00 (bb6b5a062e) Ubuntu client and was pretty surprised and disappointed that actually it was still failing for me!
But thank you @dunxd, you have pretty much nailed it and I believe to be exactly in the same situation: 2 public IPs, one in IPv4 and one in IPv6 and portcheck.transmissionbt.com seems to work only with IPv4:
$ curl -4 https://portcheck.transmissionbt.com/9008; echo
1
$ curl -6 https://portcheck.transmissionbt.com/9008; echo
0

If I manually set the port in my routers IPv6 to forward to my device, then curl -6 https://portcheck.transmissionbt.com/9008; echo does return 1.  So the issue is that some (at least mine) routers don't support UPnP or NAT-PMP for IPv6.
My suggestion would be that the Settings screen listening port check can handle a third outcome:

All checks pass - green
All checks fail - red
One of the checks fails, the other passes - amber - ideally the text tells you if IPv4 or IPv6 failed.

@dunxd this Transmission UI suggestion is still off-topic in the portcheck repo, same as it was when you suggested it a few hours ago here :smile_cat: This is a web service that has no concept of Transmission's UI.

AFAICT there is no ticket open about this in the transmission repo, so maybe move this one there?
If useful, the server-side component could be exposed with v4-only and v6-only hostnames to make it a little easier to test one or the other. But ultimately, I believe the problem reported here could only be addressed with changes on the application side, making it run two separate checks instead of just one

@ckerr I guess your expertise will be needed to:

Better qualify the problem: it's not clear to me how exactly the Transmission client (should) behave in such a situation
Make a software proposal to fix the Transmission client (at least the UI level)
Transfer to repository transmission/transmission (if you agree) OR rewrite from scratch the ticket (probably better)

See also https://github.com/transmission/transmission/issues/5607#issuecomment-1604410611

This is still broken in 4.0.4, even if you use static port mapping without uPNP.
Transmission will run for a while and report the port as open, but after a few days I start to see a warning from the tracker that my port is blocked.  So this is not just a UI bug, and it's more than a port check failing.  Does Transmission self-report closed ports to trackers?  Or does the tracker find out due to multiple unsuccessful attempts?
The only workaround is to quit & relaunch the app.

Port forwarding is setup and curl -4 https://portcheck.transmissionbt.com/33335; echo shows "1"
transmission 4.0.4 just doesnt connect and downloads are extremely slow, app shows port is closed
transmission 3.0 downloads are fast and app shows "port open"

Hey guys,
I have an even weirder issue here with Transmission (even with older versions like 2.9.2).
So, first of all, the port shows always as "Closed". But here's the thing...it doesn't show as client connected in the router interface, like in the initial post. It doesn't show anywhere.
UPnP is enabled, port is the default one. And if I don't use UPnP and try to set Port Forward manually, I get this error.

However, with another bittorrent app (qBittorrent in this case), I do get the clients showing up in the router's interface.

Point is, with qBittorrent, and the ports showing as open in my router, I get faaar, far better speeds, downloading the exact same thing.
So, right now, looks like an app issue to me. Looks like the app is listening to the port (I ran lsof -i :[portNumber] and they the port shows up as "LISTEN", but there is no "ESTABLISHED" connetion), so, I think it might not be connecting through it).
I also want to mention that I tested:
curl -4 https://portcheck.transmissionbt.com/PortNumber; echo
and
curl -6 https://portcheck.transmissionbt.com/PortNumber; echo
and they both return 0.
CanYouSeeMe.org shows: Error: I could not see your service on [IP] on port (51413) Reason: Connection timed out
But again, since it works fine with other apps, I think the problem is likely somewhere else.
I feel like this might be a combination of app issue and network setup.
For reference, my setup looks like this: ISP > ONT > My Router (tp-link C80 in case it makes a difference) > PC/laptop etc.
I tested multiple versions, and this also occurs with previous OSes as well. So, I think it's probably just an unusual setup that hasn't been taken into account yet.
I also tested the exact same app on another WiFi network, with a different setup (only ONT, which also doubles as wifi router) and the issue did NOT occur. Port showed up as Open, and everything ok.
I also read about other people's experiences and tested the theory of the IPv6 being the cause of this. However, I have IPv6 already disabled in my router. And even with it enabled, it doesn't make any difference to the issue.
So yeah....I know probably most people won't have this issue, if they're just using the default ONT, and it could also be ISP dependent. Mine is using PPPoE, just as a reference, the other one was not (not sure what exactly is it using, but it's not PPPoE).
Anyway, I wrote a lot, and I apologise for this. But I've had this issue for a looong time and never had the time to test different scenarios until recently. So I hope that helps.
If you have any questions or things you want me to try, please, let me know. I'd be glad to help, however I can.

The problem as far as I can see it is that the UI shows a problem if IPv6 is enabled on the client, but for some reason cannot connect (i.e. the router blocks it) even if IPv4 is working perfectly. This makes troubleshooting really hard.
In my opinion the UI should show seperate indicators for IPv4 and IPv6 connections, so it is possible for users to see what is not working and take appropriate action. Many users won't care of IPv6 is working or not, if IPv4 is, so this false indication of a global problem is wasting people's time.

Except it's not a false indicator.  Ports appear open for about 24 hours after restarting Transmission.  If a torrent is added after 24 hours or so, the tracker reports that it cannot reach my client and to try unblocking ports.  They're already open from the firewall.  I have to assume that Transmission sends its open ports in the announce.

I'm not saying it will fix your problem, but if you don't need it turn IPv6 off on your computer. That's one less thing to worry about and it's only when you do this that the port indicator in Transmission is helpful for troubleshooting.
Have you tried the other methods mentioned above to manually troubleshoot?

Disabling IPv6 across a LAN isn't practical in homes with Apple HomeKit, Google Home, and other popular IoT platforms that use IPv6 for broadcast and control.

You seem to be mistaking me for the developer of Transmission.
I suggested a step you could take to troubleshoot the problem you added to the Issue I created last year.
I'm not suggesting that every user of Transmission should turn off IPv6 on their client.  You can of course suit yourself, but in that case I suggest you create your own issue instead of hijacking this one.


Fix NPE in Find.java

Hello,
Our static analyzer found a following potential NPE. We have checked the feasibility of this execution trace. It is necessary to defend this vulnerability to improve the code quality. We have provided the patch for you. Please check and confirm it.
Here is the bug trace.

Select the false branch at this point (expressionClass==null is true), and null assigned to instance
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/find/ExpressionFactory.java#L129-L133

Return instance to caller, which can be null (The return value can be null)
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/find/ExpressionFactory.java#L133

Function createExpression executes and stores the return value to expr (expr can be null)
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/find/Find.java#L113

Function add executes and primaries contains null value
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/find/Find.java#L117

Function next executes and stores the return value to expr (expr can be null)
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/find/Find.java#L139

expr is passed as the this pointer to function getUsage (expr can be null), which will leak to null pointer dereference
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/find/Find.java#L140

Commit: 986d0a4f1d5543fa0b4f5916729728f78b4acec9
ContainerAnalyzer

Hello,
There is another NPE in DancingLinks.java. The patch is also provided in the pr. Here is the bug trace.

Return null to caller
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DancingLinks.java#L393

Function advance executes and returns
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DancingLinks.java#L419

Function add executes and choices contains null value
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DancingLinks.java#L419

Function get executes and returns
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DancingLinks.java#L423

The return value of function get is used as the 1st parameter in function rollback (the return value of function get can be null)
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DancingLinks.java#L423

Get the value of row.left, which will leak to null pointer dereference
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DancingLinks.java#L401

Commit: 986d0a4f1d5543fa0b4f5916729728f78b4acec9
ContainerAnalyzer

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 56s

trunk passed

+1 :green_heart:
compile
23m 55s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
18m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 36s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
2m 25s

trunk passed

+1 :green_heart:
shadedclient
15m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
21m 12s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
21m 12s

the patch passed

+1 :green_heart:
compile
19m  2s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  3s

the patch passed

+1 :green_heart:
mvnsite
1m 33s

the patch passed

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 38s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
spotbugs
2m 35s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
16m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 10s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

181m 14s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Nullcheck of expr at line 114 of value previously dereferenced in org.apache.hadoop.fs.shell.find.Find.buildDescription(ExpressionFactory)  At Find.java:114 of value previously dereferenced in org.apache.hadoop.fs.shell.find.Find.buildDescription(ExpressionFactory)  At Find.java:[line 114]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3164

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux d0cda20ee375 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c905fabc5ca69f89cc69f555b69dacdc1c4cbb39

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/1/testReport/

Max. process+thread count
1310 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 54s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m  8s

trunk passed

+1 :green_heart:
compile
21m 16s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
18m 20s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 53s

trunk passed

+1 :green_heart:
mvnsite
2m 27s

trunk passed

+1 :green_heart:
javadoc
1m 56s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 23s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 28s

trunk passed

+1 :green_heart:
shadedclient
14m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 18s

the patch passed

+1 :green_heart:
compile
20m 26s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
20m 26s

the patch passed

+1 :green_heart:
compile
18m 18s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
18m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 40s

the patch passed

+1 :green_heart:
mvnsite
2m 25s

the patch passed

+1 :green_heart:
javadoc
1m 54s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 27s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
spotbugs
2m 36s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
14m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m  2s

hadoop-common in the patch passed.

+1 :green_heart:
unit
1m  2s

hadoop-mapreduce-examples in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

194m 12s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Nullcheck of expr at line 114 of value previously dereferenced in org.apache.hadoop.fs.shell.find.Find.buildDescription(ExpressionFactory)  At Find.java:114 of value previously dereferenced in org.apache.hadoop.fs.shell.find.Find.buildDescription(ExpressionFactory)  At Find.java:[line 114]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3164

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 6d045ac9e9e0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / dc98af81ce922f62ac0c8dc29c81e75bef636f70

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/2/testReport/

Max. process+thread count
1500 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-examples U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

This is another NPE occurring in DumpS3GuardDynamoTable.java. The patch has been submitted.

Return null to caller
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java#L863

Return the return value of function getDirListingMetadataFromDirMetaAndList to caller
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java#L844-L845

Function listChildren executes and returns the null value, which is added to the list childMD.
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DumpS3GuardDynamoTable.java#L419-L420

The value childMD is passed as the 2nd parameter of pushAll, and it contains null value.
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DumpS3GuardDynamoTable.java#L422

The list reversed contains the null value after being assigned by the return value of the function reverse.
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DumpS3GuardDynamoTable.java#L268

The return value of function iterator is passed as the this pointer to function hasNext (the return value of function iterator can be null), which will leak to null pointer dereference
https://github.com/apache/hadoop/blob/986d0a4f1d5543fa0b4f5916729728f78b4acec9/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DumpS3GuardDynamoTable.java#L269

Commit: 986d0a4f1d5543fa0b4f5916729728f78b4acec9 #
ContainerAnalyzer

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 42s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 31s

trunk passed

+1 :green_heart:
compile
21m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
18m 26s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 40s

trunk passed

+1 :green_heart:
mvnsite
3m 11s

trunk passed

+1 :green_heart:
javadoc
2m 20s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 57s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 42s

trunk passed

+1 :green_heart:
shadedclient
14m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 54s

the patch passed

+1 :green_heart:
compile
20m 41s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
20m 41s

the patch passed

+1 :green_heart:
compile
18m 33s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
18m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 39s
/results-checkstyle-root.txt
root: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

+1 :green_heart:
mvnsite
3m 10s

the patch passed

+1 :green_heart:
javadoc
2m 16s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 59s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
spotbugs
2m 37s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
14m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
16m 56s

hadoop-common in the patch passed.

+1 :green_heart:
unit
0m 57s

hadoop-mapreduce-examples in the patch passed.

+1 :green_heart:
unit
2m 18s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

215m 32s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Nullcheck of expr at line 114 of value previously dereferenced in org.apache.hadoop.fs.shell.find.Find.buildDescription(ExpressionFactory)  At Find.java:114 of value previously dereferenced in org.apache.hadoop.fs.shell.find.Find.buildDescription(ExpressionFactory)  At Find.java:[line 114]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3164

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 99f4d797adb0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c470ce6f1c1c7e37825b71cc2ea280f904bc12ad

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/3/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m  1s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 52s

trunk passed

+1 :green_heart:
compile
22m 17s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 27s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 58s

trunk passed

+1 :green_heart:
mvnsite
3m  9s

trunk passed

+1 :green_heart:
javadoc
2m 25s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m  7s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 53s

trunk passed

+1 :green_heart:
shadedclient
20m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s

the patch passed

+1 :green_heart:
compile
22m  0s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m  0s

the patch passed

+1 :green_heart:
compile
19m 12s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 12s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 41s
/results-checkstyle-root.txt
root: The patch generated 1 new + 20 unchanged - 0 fixed = 21 total (was 20)

+1 :green_heart:
mvnsite
3m 22s

the patch passed

+1 :green_heart:
javadoc
2m 34s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 10s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
spotbugs
2m 36s
/new-spotbugs-hadoop-common-project_hadoop-common.html
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
20m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 18s

hadoop-common in the patch passed.

+1 :green_heart:
unit
1m  1s

hadoop-mapreduce-examples in the patch passed.

+1 :green_heart:
unit
2m 28s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

223m 35s

Reason
Tests

SpotBugs
module:hadoop-common-project/hadoop-common

Nullcheck of expr at line 114 of value previously dereferenced in org.apache.hadoop.fs.shell.find.Find.buildDescription(ExpressionFactory)  At Find.java:114 of value previously dereferenced in org.apache.hadoop.fs.shell.find.Find.buildDescription(ExpressionFactory)  At Find.java:[line 114]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3164

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 6778402f7cc1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c470ce6f1c1c7e37825b71cc2ea280f904bc12ad

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/1/testReport/

Max. process+thread count
1362 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3164/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


a problem about collision，too tough to work out myself

ive been making a world with cannonjs&threejs.i run to test the work,when booming a error.
here are one sphere and tow box,boxs' masses are zero.sphere is droped.
Cannot read property 'x' of undefined
    at Quaternion.vmult (cannon.js:4458)
    at Narrowphase.(anonymous function).Narrowphase.sphereConvex
    at Narrowphase.getContacts (cannon.js:11256)
    at World.internalStep (cannon.js:13359)
    at World.step (cannon.js:13197)

its the consolelog.what confusjing most is that next:
when the error was throwed,then i change the number of boxes to one.and the error disappear.
whats the matter with my code?and does cannonjs's follower have a BBS to discuss problem?i wanna know.thank U!

Hi. Can you post some code so we can reproduce the problem?


PhpdocScalarFixer - fix for comment with Windows line endings

Thank you @kubawerlos.

@kubawerlos can you check the current 2.15 and 2.16 Annotation class and check if the merge conflict was resolved correctly, secondly the fix in the PR should it also go to 2.15?

@SpacePossum that's weird, now when I remove \v on 2.16 the tests are still passing 🤔


Adding Terminal Window to Jupyter Cells so all Colab users (free and pro) can train with Nerfstudio

Background and Issues:

All colab users (free and pro) were not be able to run ns-train in a jupyter cell, and this has been made apparent in several issues below. (Pro users can get around this, but it's still problematic and explained below)
https://github.com/nerfstudio-project/nerfstudio/issues/2283
https://github.com/nerfstudio-project/nerfstudio/issues/1836
https://github.com/nerfstudio-project/nerfstudio/issues/1832
https://github.com/nerfstudio-project/nerfstudio/issues/1113
https://github.com/nerfstudio-project/nerfstudio/issues/2166

The culprit of this bug is that as of Feb 2024, Google Colab runs python 3.10, which has an issue with nerfstudio's rich console outputs. In particular, a python module called shutil will set the terminal size to 0 when dealing with rich console outputs. As a result, nothing gets printed, and Colab will shutdown the cell and terminate early before training can begin.
This is mentioned in other python modules which use the rich console output, and a complete breakdown on the issue is detailed here.
Overview of Changes

By using the colab-xterm module, we are able to create a terminal window in a jupyter cell output.
After installing it, we clear the cell output to make it very user-friendly to follow the instructions.
The command is printed and instructions are given to help the user run ns-train and they will be able to generate the viser/viewer link to see the training progress
Removed the "Connecting to Viewer Cell" as users can simply use ns-train's sharable URL link
Final change was to add the torchaudio dependency which was mentioned here so that users can train.

Impact and Other Notes

While Pro Colab users can get around this by running ns-train in their terminal window, Colab only allows for 1 terminal window. Therefore, to run the render command, pro users need to Ctrl+C the training process hosting the viser/viewer link, which can be quite irritating - especially if they want to make more than just 1 render path.

Therefore, even once Colab upgrades to python 3.11 in April 2024, there is still a need to have at least 2 terminal windows, which is possible with this change.

To run ns-train, users (free and pro) simply need to follow the instructions to copy and paste the command into the terminal window. This is pretty clear to follow, and looks like the following:

Below is what the cell terminal window looks like after copy+pasting the command on a free colab account:

Thank you Anthony!!! Going to test this soon and see if anything is needed, but it looks like everything is good!


Various code coverage.   Fix infinite loop in "out of graph" case in InsertAndRetriangulateContext"

The primary content of this is unit tests to increase coverage.
The coverage tests exposed an infinite loop in InsertAndRetriangulationContext.

The infinite loop occurs when searching for an exterior point into an evolving triangulation graph

all works fine in the customary case where the point is known to be interior to the existing planar subdivision.
but if the new point is external the logic failed.
the triangulation code which uses this context always begins by constructing a convex hull over the points, so all insertions are interior and the bug does not appear.

The correction gets out of the loop and marks the search point with a flag indicating it is the exterior case.

@Mergifyio update


feat: add blueprints folder and prow wi for int tests

This adds a folder for running KRM blueprint tests and creates an SA+WI for Prow to use in integration tests. prow_int_sa will be added to cft-ci robots group alongside cloudbuild.

This has been applied


[Question][Feature] How to get the default tooltip formatter function?

What problem does this feature solve?
This was asked at #13778 and a file was pointed. However, I couldn't find it available in the published API.
I like the 5.0 tooltip formatter and I want to make use of it as is. However, I do want to augment it with some additional content around. So, I was hoping to first get the default tooltip and then add it into an existing DOM.
What does the proposed API look like?
One way I can think of is add the default formatter to the params argument. Then one could write
formatter: (params) => {
const tooltip = params.defaultFormatter(params);
// do som stuff and return the final tooltip
}

You can find it here, if it's the same thing as in the issue you are referring to.


[WIP] Feature / dataset merger

Changes proposed in this pull request:

Add a function to merge (very similar) datasets. The idea is that a measurement may have been broken into smaller pieces by instrumental necessity and there should be a way to glue the different pieces together.

Pending:

[ ] Tests, tests, tests
[ ] Metadata? How should we capture the fact that this is somehow non-measured experimental data?

@QCoDeS/core

This looks very nice! questions:

Is merge really a good name? Shall we use something more mathematical like union?
What happens if the two datasets that are to be merged, have measured values at the same values of setpoints? For example, if dataset1 has {x: 1, y: 2, z: 10} while dataset2 has {x: 1, y: 2, z: 65}? I guess, this is not a big deal for the dataset itself, right? It's just the worry of the tools which work with data like plot_by_id, right?

The name:  You are right that set theoretical names are more concise in terms of how they combine/unite the datasets. But currently merge will only work if the datasets are very similar, so whereas you might expect union to really just combine everything (and thus works for any two datasets), merge (potentially, if you git'ed a lot) offers the user the intuition that not everything can be merged. And the merge is a verb, which I like. I suppose unite would correspond to union? But perhaps it'd be good to already now think about all the combining functions we'd like to have and then name appropriately.

Setpoints: exactly. If you play around with the notebook, you can see plot_by_id going mental if there are overlapping regions and a grid is detected. We should look into that.

Concerning metadata. I think that for now you can combine the metadata into a dictionary by run_id and/or run_name within a dedicated field, smth like:
{
    merged_runs: {
        25: {'snapshot': {...}},
        37: {'snapshot': {...}},
    },
    < other meta data of THIS dataset >
}

I think the metadata is going to be a "place for dumping stuff" anyway, hence it is just not easy to say how to perform "operations" on it. So, a simple solution like this is probably fine as long as minimal "separation"/"organization" measures are taken.

I like that metadata solution. Let me see if I can fix the three items today.

This PR should wait for #965 to be merged. That way it will be captured where the data came from.


Fix NRE when deploying from a folder

Currently when you try to use a folder as SourcePath, it will crash with a NullReferenceException since GetExtension returns null.

Good catch :+1: I'll merge it over the weekend and release a new nuget package


Generate AppImage on Travis CI, closes #56

This PR, when merged, will compile the ippsample tools on Travis CI upon each git push, and upload an AppImage to a temporary download URL on transfer.sh (available for 14 days). The download URL is toward the end of each Travis CI build log of each build (see below for how to set up automatic uploading to your GitHub Releases page).
For this to work, you need to enable Travis CI for your repository as described here prior to merging this, if you haven't already done so.
Providing an AppImage would have, among others, these advantages:

Applications packaged as an AppImage can run on many distributions (including Ubuntu, Fedora, openSUSE, CentOS, elementaryOS, Linux Mint, and others)
One app = one file = super simple for users: just download one AppImage file, make it executable, and run
No unpacking or installation necessary
No root needed
No system libraries changed
Works out of the box, no installation of runtimes needed
Optional desktop integration with appimaged
Optional binary delta updates, e.g., for continuous builds (only download the binary diff) using AppImageUpdate
Can optionally GPG2-sign your AppImages (inside the file)
Works on Live ISOs
Can use the same AppImages when dual-booting multiple distributions
Can be listed in the AppImageHub central directory of available AppImages

Here is an overview of projects that are already distributing upstream-provided, official AppImages.
Please note: Instead of storing AppImage builds temporarily for 14 days each on transfer.sh, you could use GitHub Releases to store the binaries permanently. This way, they would be visible on the Releases page of your project. This is what I recommend. See https://docs.travis-ci.com/user/deployment/releases/. If you want to do this for continuous builds, also see https://github.com/probonopd/uploadtool.
If you have questions, AppImage developers are on #AppImage on irc.freenode.net.
Closes https://github.com/istopwg/ippsample/issues/56

You can see the build log for this at https://travis-ci.org/probonopd/ippsample/builds/295273697
Specifically, a download URL is given toward the end at https://travis-ci.org/probonopd/ippsample/builds/295273697#L1074
Using this, you can do the following:
wget "https://transfer.sh/kG2QQ/ippsample-git.75ecdb4-x86_64.AppImage"
chmod +x ippsample-git.75ecdb4-x86_64.AppImage
ln -s ippsample-*-x86_64.AppImage ippfind
ln -s ippsample-*-x86_64.AppImage ippproxy
ln -s ippsample-*-x86_64.AppImage ippserver
ln -s ippsample-*-x86_64.AppImage ipptool

 ./ipptool -tv ipp://NPI5F036D.local:631/ipp/print get-printer-attributes.test

Considering

Stuck on the naming on the binaries.
Even with --with-name-prefix=ipp https://travis-ci.org/probonopd/ippsample/builds/296984810#L422 it names the binaries wrongly: PPproxy PPfind PPtool https://travis-ci.org/probonopd/ippsample/builds/296984810#L645-L649

I tried to build on a local Mac. The --with-name-prefix=... seems to be b0rken here, too. But funnily in a different way:

The default build results are indeed named ipp....
But after ./configure --with-name-prefix=PP the outcome is STILL ipp...

@KurtPfeifle @probonopd The binaries in the build directory will still be named ippfind, ippserver, ipptool, etc. - the renaming doesn't happen until installation.
That said, it looks like the tools makefile didn't put parens around the $IPP, causing the PP nonsense in the installed tools. And I forgot to rename the man pages. Fixed in:
[master d24cf0c] Fix renaming of files on install.

Works as intended now:
https://transfer.sh/10o3Dj/ippsample-git.97c1bbf-x86_64.AppImage

OK, so Travis CI is no longer available for open source usage, will reconsider for Github CI, and we already have snap builds working.


Create PR view has blank dropdowns when making PRs across forks with differently named default branches

Fixes #2711

Going to go ahead and merge this to unblock a demo


Reliability of BatchOptions.sync(int slaves, Duration timeout)

Hello, I'd like to know how does the BatchOptions.sync() works if I use them with retryAttempts=2 and sync(2, 1000, ExecutionMode.REDIS_WRITE_ATOMIC)
Let's say are setting 10 keys
Scenario 1
Consider that after writing 5 commands and a connection reset happens. I assume that Redis will just discard the transaction and WAIT won't be executed?
Having retryAttempts=2 -> will redission retry the entire batch again?
Scenario 2
10 writes are sent, EXEC is called and a connection reset happens right after EXEC.
Will redisson stop on sending WAIT command?
Will redisson retry the entire batch?
Scenario 3
10 writes are sent, EXEC is called but Redis had an error and ended up partially executing the writes (say 5/10).
Will redisson stop on sending the WAIT command?
Will redisson retry the entire batch?
In order words,
A. Does Redisson knows a connection reset/change has happened and there is not point of sending WAIT command?
B. If not, does Redisson sends atleast [EXEC, WAIT] at once to avoid the risk of getting false acknowledgements of WAIT?
Example
1731701996.058195 [0 <IP_ADDRESS>:59015] "PING"
1731701996.083125 [0 <IP_ADDRESS>:58947] "MULTI"
1731701996.086024 [0 <IP_ADDRESS>:58947] "SET" "key0" "\x03value\xb0"
1731701996.086033 [0 <IP_ADDRESS>:58947] "SET" "key1" "\x03value\xb1"
1731701996.086034 [0 <IP_ADDRESS>:58947] "SET" "key2" "\x03value\xb2"
1731701996.086035 [0 <IP_ADDRESS>:58947] "SET" "key3" "\x03value\xb3"
1731701996.086036 [0 <IP_ADDRESS>:58947] "SET" "key4" "\x03value\xb4"
1731701996.086037 [0 <IP_ADDRESS>:58947] "SET" "key5" "\x03value\xb5"
1731701996.086038 [0 <IP_ADDRESS>:58947] "SET" "key6" "\x03value\xb6"
1731701996.086039 [0 <IP_ADDRESS>:58947] "SET" "key7" "\x03value\xb7"
1731701996.086040 [0 <IP_ADDRESS>:58947] "SET" "key8" "\x03value\xb8"
1731701996.086041 [0 <IP_ADDRESS>:58947] "SET" "key9" "\x03value\xb9"
1731701996.086042 [0 <IP_ADDRESS>:58947] "EXEC"
xxxxxxxxxxxxxxxxxxxxxxxxx failure happens; connection dropped xxxxxxxxxxxxxxxxxxxxxxxxx
1731701996.086056 [0 <IP_ADDRESS>:58947] "WAIT" "2" "1000"

@mrniko any thoughts on this?


Patch additional sysconfig values such as AR at install time

Summary
Minor follow up to https://github.com/astral-sh/uv/pull/9857 to patch AR and friends.
Implements the replacements used in sysconfigpatcher, namely
DEFAULT_VARIABLE_UPDATES = {
    "CC": WordReplace("clang", "cc"),
    "CXX": WordReplace("clang++", "c++"),
    "BLDSHARED": WordReplace("clang", "cc"),
    "LDSHARED": WordReplace("clang", "cc"),
    "LDCXXSHARED": WordReplace("clang++", "c++"),
    "LINKCC": WordReplace("clang", "cc"),
    "AR": "ar",
}

Test Plan
Added an additional test. Tested local python installs.
Related traces
TRACE Updated `AR` from `/tools/clang-linux64/bin/llvm-ar` to `ar`
TRACE Updated `CC` from `clang -pthread` to `cc -pthread`
TRACE Updated `CXX` from `clang++ -pthread` to `c++ -pthread`
TRACE Updated `BLDSHARED` from `clang -pthread -shared -L/tools/deps/lib` to `cc -pthread -shared -L/tools/deps/lib`
TRACE Updated `LDSHARED` from `clang -pthread -shared -L/tools/deps/lib` to `cc -pthread -shared -L/tools/deps/lib`
TRACE Updated `LDCXXSHARED` from `clang++ -pthread -shared` to `c++ -pthread -shared`
TRACE Updated `LINKCC` from `clang -pthread` to `cc -pthread`

Awesome, thank you! I think I want to hold off on rewriting clang just yet... I'd rather make that opt-in or perhaps opt-out. Can we pare this down to just AR for now?

If you're up for it, you could also open the clang to cc change in a separate PR and we can discuss it there? But the AR change can merge immediately :)

If you're up for it, you could also open the clang to cc change in a separate PR and we can discuss it there? But the AR change can merge immediately :)

Yup, I was thinking the same thing 👍


[EdgeTool: vertices] Cannot insert new points between existing vertices

Describe the bug
When using the provided vertices edge tool, it is impossible to insert a new point between existing vertices, or between the starting point and the first vertex (if any). One can only add new points at the end of the line, between the target point and the vertex closest to the target point.
使用 vertices 工具时没有办法在现有路径点之间插入新的点，只能在终点和“最后一个”节点（即最接近终点的节点）之间插入。
Let's say we have a segment
U-----A-----B-----C-----V
where A, B, and C are points added by this tool. One cannot insert another point D on A-----B, or B-----C, etc, but only C-----V.
Your Example Website or App
https://codesandbox.io/s/x6-vertices-insertion-knwze?file=/src/App.tsx
Steps to Reproduce the Bug or Issue

Create a new Graph with minimally an edge e;
Add the vertices tool to the edge with the default settings: e.addTools([{name: 'vertices'}])
Click in the middle of the edge to create a point on the edge;
Click in the middle between the starting node of the edge and the point created in step 3;
Observe that a new point was not added:

https://user-images.githubusercontent.com/93302820/147087374-022350e6-7d9b-4e1f-a944-5fc9b977d0d7.mov
Expected behavior
As a user I expect the tool to create a point for me no matter where I click along the edge.
https://user-images.githubusercontent.com/93302820/147087803-d42d2c8c-e979-4360-86bf-f94038308f31.mov
Screenshots or Videos
No response
Platform

OS: macOS 11.4
Browser: Chrome 96.0.4664.110
Version: 1.29.0

Additional context
No response

See #1680


Fix spelling mistake

Receive was spelt wrong

I did a major refactoring of NBitcoin this morning, this broke your PR. So I fixed it myself.
Published in nuget : <IP_ADDRESS>


Ensure http clients can nest under SQL for Go

Snowflake SQL commands delegate to HTTP under the covers and it may not be the only database that does this. This PR adds a check to ensure we can also nest HTTP client calls under a SQL statement.
I can't make a test for this because the only DB driver I know does this at the moment is Snowflake and it requires a Snowflake account. An alternative would be running localstack, but snowflake seems to be available only in their non OSS version.

CC @esara, I think this will allow you to see the SQL nested correctly over the actual HTTP client connection which does the communication.

CC @esara, I think this will allow you to see the SQL nested correctly over the actual HTTP client connection which does the communication.

I tested this code with snowflake and I see that the sql span has no server address (same as before), but there is a wrapped http post with a server address and path.

CC @esara, I think this will allow you to see the SQL nested correctly over the actual HTTP client connection which does the communication.

I tested this code with snowflake and I see that the sql span has no server address (same as before), but there is a wrapped http post with a server address and path.

Yes, this is the best we can do, since there's no external SQL connection, it gets delegated to an internal HTTP client.


Can't compile models for vulkan backend with some flags

We can't compile the model for benchmarking with --iree-flow-dispatch-formation-enable-operand-fusion. We had the flag in iree_mlir_benchmark_suite, but it is not working now.
To repro:
Run iree-translate --iree-mlir-to-vm-bytecode-module --iree-hal-target-backends=vulkan-spirv ~/mobilenet-v2/iree_input.mlir -o a.vmfb --iree-input-type=mhlo --iree-vulkan-target-triple=valhall-unknown-android11 --iree-flow-inline-constants-max-byte-length=2048 --iree-flow-dispatch-formation-enable-operand-fusion --iree-enable-fusion-with-reduction-ops
Will see some errors like unhandled allocation type, which was generated from AllocOpPattern in StandardToSPIRV pass.

Yeah, it's broken. Although the convolution and element-wise consumer op are still put in the same dispatch region, TileAndVectorizeInOneWorkgroupPass does not kick in: no vectorization at all. Looking into this..


Remove path.join(__dirname,) in server.js

To match the vars above where this has been removed.

Path.join is normally used to make sure everything works on windows, which uses / not \ however it's weird if the other line is working

I think this needs testing. I'll take a look.

This SO answer suggests that you only need to make sure that path.join() exists in cases where you’re passing the path through to a Windows command. As require seems to exist purely in Node land (judging by the fact that the other calls are working) then this should be fine.

@robinwhittleton thanks for the extra info! :)


chore(sdk): add (auto)hook for Settings.project

Description
Move the logic from wandb.util.auto_project_name to wandb.Settings.project (auto) hook so that there is no need to port the custom project update logic from sender.py to sender.go when it's not set by the user. FYI: in that case, if we're inside a git repo, we'd use a meaningful name for the project as opposed to just "uncategorized".
Testing
Added a unit test.

Let's also remove this function from all the call sites in the run:

wandb/sdk/internal/sender.py <- it is the default when resuming
wandb/wandb/sdk/internal/internal_api.py <- when upserting a run
There are 2 other places:
wandb/cli/cli.py <- for sweeps that would be harder to cleanly remove currently
wandb/jupyter.py <- that i think also will be harder to remove cleanly


RNN can not display correctly

Here is a simple example of LSTM neural network.

We need hl.transforms.Rename() to rename the RNN node.
tsfm = [hl.transforms.Rename(op='prim::PythonOp', to = 'LSTM')]

Thanks for the report. Admittedly, I haven't tested with RNNs. Would you mind sharing the sample code used to generate this?

RNN(LSTM) code:

import torch
import hiddenlayer as hl
from torch import nn

class RNN_Net(nn.Module):
    def __init__(self, input_dim, hidden_dim, output_dim, num_layers=1):
        super().__init__()
        self.hidden_dim = hidden_dim
        self.num_layers = num_layers
        self.rnn = nn.LSTM(input_dim, hidden_dim, num_layers=num_layers, batch_first=True)
        self.fc = nn.Linear(hidden_dim, output_dim)

    def forward(self, x):
        hidden = self.initHidden(x.size(0))
        y, _ = self.rnn(x, hidden)
        return self.fc(y[:, -1, :])

    def initHidden(self, batchsize):
        weight = next(self.parameters())
        h0 = weight.new_zeros(self.num_layers, batchsize, self.hidden_dim)
        return (h0, h0)

model = RNN_Net(5, 15, 5)
hl.build_graph(model, torch.zeros([32, 20, 5]))

The graph of neural network with RNN(LSTM).

@AutuanLiu I want to give an update on this. Thank you for raising the issue and providing details. And sorry it took a long time.
I ran experiments with LSTMs and tried to find a simple pattern that makes it easy to render them. Unfortunately, I couldn't find a simple solution. And the method you used works in a subset of the cases only. Also, PythonOp can represent other operations.
So I think your solution is useful for your case, but shouldn't be built into the library as it might cause unintended problems for other network types. At this point, I'm afraid I don't have a good solution for LSTMs. I hope I manage to find some free time in the near feature to dive deeper into how PyTorch represents LSTMs and find a general solution that works in all (or most) cases.


Make the Gradle build idiomatic

This commit refactors the build to make it Gradle idiomatic. This greatly simplifies the setup, and removes a bunch of errors in configuration.
There is now a task called publishAllPublicationsToBuildRepository which creates a Maven repository under build/repo to check what is going to be published.
The version of the project is managed under gradle/libs.versions.toml

It'd probably be helpful to split out the mv src/test/java src/test/kotlin part in a separate commit that can be put in an blame ignore file and won't make git blame effectively useless for that entire directory.

done


auth-tokens-refresh (and possibly other functions) failing on current Docker image

Upon further testing of the new alpine:3.3-based iplantc/cyverse-cli image, I see that the auth functions of the CLI aren't working. Specifically, it appears the mechanism used to read values from the ~/.agave/current cache don't work.
To Reproduce
Inside the container, auth-tokens-refresh -S  will fail with a stack trace, while it works outside the container. The curl command being sent inside the container is curl -sku ":XXXXXX" -X POST -d "grant_type=refresh_token&refresh_token=&scope=PRODUCTION" -H "Content-Type:application/x-www-form-urlencoded" https://agave.iplantc.org/token
Notice that the client is missing from the HTTP Basic Auth parameter. Repeating with auth-tokens-create -S reveals that NONE of the variables are being pulled into the CLI runtime.
Calling curl -sku ":XXXXX" -X POST --data-urlencode "username=" --data-urlencode "password=XXXXX" --data-urlencode "grant_type=password" --data-urlencode "scope=PRODUCTION" -H "Content-Type:application/x-www-form-urlencoded" https://agave.iplantc.org/token

I didn’t build the cyverse cli image, but my guess would be that you don’t have python installed in that container and that it’s not using the json-mirror api for json formatting. I suggest installing jq in the container and specifying that as the json parsing engine.
—
Rion

On Feb 7, 2016, at 9:08 AM, Matthew Vaughn<EMAIL_ADDRESS>wrote:
Upon further testing of the new alpine:3.3-based iplantc/cyverse-cli image, I see that the auth functions of the CLI aren't working. Specifically, it appears the mechanism used to read values from the ~/.agave/current cache don't work.
To Reproduce
Inside the container, auth-tokens-refresh -S will fail with a stack trace, while it works outside the container. The curl command being sent inside the container is curl -sku ":XXXXXX" -X POST -d "grant_type=refresh_token&refresh_token=&scope=PRODUCTION" -H "Content-Type:application/x-www-form-urlencoded" https://agave.iplantc.org/token
Notice that the client is missing from the HTTP Basic Auth parameter. Repeating with auth-tokens-create -S reveals that NONE of the variables are being pulled into the CLI runtime.
Calling curl -sku ":XXXXX" -X POST --data-urlencode "username=" --data-urlencode "password=XXXXX" --data-urlencode "grant_type=password" --data-urlencode "scope=PRODUCTION" -H "Content-Type:application/x-www-form-urlencoded" https://agave.iplantc.org/token
—
Reply to this email directly or view it on GitHub https://github.com/iPlantCollaborativeOpenSource/cyverse-sdk/issues/1.

Fixed. I had some subtle pathing issues to resolve.


chore: add cargo publish to just file

Referencing release docs

Backport failed for releases/v0.5, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin releases/v0.5
git worktree add -d .worktree/backport-6593-to-releases/v0.5 origin/releases/v0.5
cd .worktree/backport-6593-to-releases/v0.5
git switch --create backport-6593-to-releases/v0.5
git cherry-pick -x cca294f371e66d6c905543e00933e08c17aaefc8 9322d1e97747c04b0f7dca91cb4164308bca5e75


Could not build Objective-C module 'Venmo-iOS-SDK'

I'm using Swift for my project, and I get the above error on the import statement in AppDelegate. Xcode recognizes the module name

but gives the error once it's actually there.

I have the correct line in my Podfile and the use_frameworks! flag. I've linked the CMDQueryStringSerialization, SSKeychain, VENCore, and Venmo-iOS-SDK frameworks as well. I am not using any sort of prefix header.
Any ideas?

I also had the error Could not find file "VENUser.h" at the import statement in VENUser+VenmoSDK.h. I changed it to #import "VENCore/VENUser.h" and both errors were resolved. Maybe this is something that should be changed in the source?

Could you post your Podfile and perhaps Bridging header if you have any(Yeah I did try without the bridging header but it didnt work )?
How are you importing the SSKeychain, I have it only downloaded with pods but didnt do anything with them
I have same issue but your solution doesnt help unfortunately :(

Same issue here.

me too. boo!

Thanks for reporting this issue. This was indeed a case of bad header importing on our end that worked when the SDK was compiled as a static library via Cocoapods. Unfortunately this falls down when a dynamic library is created. This will be fixed in an upcoming release.

has this been fixed?

Any traction on this or a possible work around to get this pod working?

@hyperspacemark Any update on this issue? Still getting it and @lukenewman's fix via #import "VENCore/VENUser.h" works.


Specify a document library?

Is there a way to specify the Document Library similar to SetAuditReportStorageLocation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce3e7e39-d315-4843-4af4-57c5040d509f
Version Independent ID: 7e61202d-4b8c-3018-b161-f99890cc7724
Content: Set-PnPAuditing (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Set-PnPAuditing.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

@officedocsbot assign @yogkumgit

Hello @hvandesa
Thanks for your feedback.
This issue system is specifically to report issues in documentation.
Said that, PnP cmdlets are community-driven, if you have an idea that could be a feature request, you can start looking here https://docs.microsoft.com/en-us/sharepoint/dev/community/community
I looked into this cmdlet's source code and it is not possible. https://github.com/SharePoint/PnP-PowerShell/blob/master/Commands/Site/SetAuditing.cs
Thanks

@get-itips  Thank you very much for the contribution and sharing this explanation. @hvandesa
Hope this comment is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close


Mege upstream cryptolib

This is just intended to get Travis-CI reports. Don't merge, because it is not correct.

CLA is valid!

CLA is valid!

Closing this because #43; feel free to leave comments there.


Make tracer initialization configurable

The initialization of the tracer isn't really customizable at the moment.
The function init_tracer as shown in the sample application only takes a CollectorKind parameter to specify the tracer type. This though isn't really satisfying as the tracer parameters cannot be customized:
fn init_tracer(kind: CollectorKind)

I've seen that there's the more specific function
fn init_tracer_jaeger(resource: Resource)

which is called inside the init_tracer function, but the Resource type isn't sufficient to configure things like the Sampler or the collector endpoint (has to be set on the pipeline).
My solution so far is to copy the content of the init_tracer_jaeger function into my own code and configure the tracer there.
It would be better though, if relevant parameters could be configured / overwritten by the user without copying the code.

Agree with you, but the purpose of those function was to propose a simple ready to use setup with less configuration as possible (maybe auto detection from environment variable). and to not try duplicate all the possiblity of the opentelemetry api (this lib is not a wrapper).
Anyway I made some refactor to allow to provide a transform function that can modify or fully rewrite a new pipeline. (not documented yet and not published yet).
Can you take a look to the current source code and give me your opinion ?

Sorry for late reply I didn't see the notification about the issue.
Thank you for your feedback.

the code is part of 0.3.0 (but not documented and no example yet)

I think the API design is good now. It is easy to set the correct service name.
I guess with "not published yet" you mean that the modules tools in lib.rs and jaeger/otlp in tools/mod.rs are still private (and you will change that)? If the module visibility of tools/jaeger/otlp will be changed to public a customized jaeger initialization will look really nice:
    let tracer = jaeger::init_tracer(
        make_resource(env!("CARGO_PKG_NAME"), env!("CARGO_PKG_VERSION")),
        |p| p.with_agent_endpoint("..."),
    )
    .expect("setup of Tracer")

This will provide flexibility as users can either stick to the simple solution as shown in the example or they can customize the specific tracers as needed.
I hope I understood it right. I'm happy to see all the other improvements as well. Thanks for the adjustments.

Is this init even necessary when there is already a tracer in place (as described here https://www.dynatrace.com/support/help/extend-dynatrace/opentelemetry/opentelemetry-traces/opentelemetry-ingest/opent-rust)?

Can confirm this works, see https://github.com/davidB/axum-tracing-opentelemetry/issues/44?notification_referrer_id=NT_kwDOBdi0VbM1NTI2ODE3OTM3Ojk4MDg4MDIx#issuecomment-1421353802 for details why it did not work initially in my case.


update vendoring for scripts, templates and incomplete code

ah, remove the vendor dir from /scripts/files, that script's for easy bulk updating of the glide.yaml files and is not in itself a go project

Also template-SMI needs its vendor directory updating, if you look at the glide.lock file that includes the hash of the version currently in the vendor directory. For the recently updated examples that hash starts 12b, for this it starts with something else.


Add Arm64 on Darwin

I've only done step 1 of Release Process: GoReleaser:
https://github.com/grafana/cortex-tools/blame/main/RELEASE.md#L6
For a couple of reasons:

I didn't want to create and push a new tag until this is approved & merged
I'm on an Arm64 Darwin machine myself, and so far I've found that when I try to build a Linux Amd64 Docker image, it never runs successfully on our linux machines on GCP - so I'm hoping someone on a linux machine (or an Amd64 Mac) can do step 3 for me (running goreleaser release).

I haven't tested the code change in this PR yet - I'm not sure how to exactly. I was looking in the Makefile for something I could run, but didn't spot anything yet. Cheers!

Well the "build binaries: build all" step of the Github checks worked fine, and I was also able to run make all locally without any issues:
>$ file cortextool
cortextool: Mach-O 64-bit executable arm64
>$ ./cortextool version
version main

If I try make cross I get gox command not found. I thought go would natively compile for other platforms without any additional tooling 🤔

Running:
goreleaser build --rm-dist --skip-validate

Produced:
   • building binaries
      • building                  binary=/home/goutham/go/src/github.com/grafana/cortex-tools/dist/cortextool-darwin_darwin_amd64/cortextool
      • building                  binary=/home/goutham/go/src/github.com/grafana/cortex-tools/dist/cortextool-darwin_darwin_arm64/cortextool
      • building                  binary=/home/goutham/go/src/github.com/grafana/cortex-tools/dist/cortextool-linux_linux_amd64/cortextool
      • building                  binary=/home/goutham/go/src/github.com/grafana/cortex-tools/dist/cortextool-windows_windows_386/cortextool.exe
      • building                  binary=/home/goutham/go/src/github.com/grafana/cortex-tools/dist/cortextool-windows_windows_amd64/cortextool.exe

I think this is good enough, and I've asked Sam to verify if he can run the binary on an M1 Mac. Once I have confirmation, I'll merge this and cut the release.


Handle GLPK library naming on windows

libglpk.a on linux, GLPK.lib on windows.

AFAIK this file is for windows only but:
0. I didn't bump it since we use dynamic library (protobuf abseil-cpp) -> May need some extra changes

Why talking about Linux, this file is only a post process for windows
In that case why using *glpk.lib instead of glpk.lib i.e. do you have some use case where the "*" is necessary ?

BTW thx for this PR we definitively need to take a look at this file before next release

I missed that this was windows only, but that is obviously true with the
.lib extension.
When compiling on windows (so I can use glpk) I get a can't find file
error, libglpk.lib doesn't exist but GLPK.lib does.

Jamie
http://jamiecook.wordpress.com

On Sat, 23 Nov 2024 at 1:07 AM, Mizux @.***> wrote:

AFAIK this file is for windows only but:
0. I didn't bump it since we use dynamic library (protobuf abseil-cpp) ->
May need some extra changes

Why talking about Linux, this file is only a post process for
windows
In that case why using glpk.lib instead of glpk.lib i.e. do you
have some use case where the "" is necessary ?

BTW thx for this PR we definitively need to take a look at this file
before next release
—
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/pull/4447#issuecomment-2493971321,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABE4VASAUQ75C5AKGVPTCT2B5CD5AVCNFSM6AAAAABSGKX7AWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJTHE3TCMZSGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


accessibilityLabel and testID props in 3rd party modules

I have come across a couple of react-native third party modules that don't pass on the props accessibilityLabel and testID to the underlying components e.g. <Text /> and <View />. While it is completely up to the module author to implement this it makes it much harder to test apps using these components as test frameworks like Appium for example rely on these IDs to be set in order to be able to uniquely identify a component. (Okay there's XPath but that is not a great option)
How should this be addressed? I can think of the following options

Let react-native handle it automatically
Include a note in the docs to remind authors that this is important
Have react-native display a warning if the props are not being passed on

Let react-native handle it automatically

How do you think it'd work?

Include a note in the docs to remind authors that this is important

We should probably do this

Have react-native display a warning if the props are not being passed on

It'll generate a lot of warnings which are not possible to fix everywhere. In many places these are used just for styling and layout, so accessibility props don't make sense there.

Good points. Be no means I know the react-native code by heart so I am not sure if the APIs for the first option exist. I guess raising awareness through documentation is the best way then.

@timjacobi - if you come up with a proposal for how we can solve this we can open an issue with your suggested approach.
I think this will need to be driven by library authors. If you create issues or pull requests on the libraries that you're using to fix this, that is probably the best way forward right now and I'm sure others would appreciate your efforts!

@brentvatne Agreed. I'm already doing that.


Checkboxes in legend

Suggestion: Option to include checkboxes in the legend to turn on&off the visibility of plottables.
Someone else had asked me if this would be possible, and I quite liked the idea, so I wanted to pass it on.
Example plot made in paint:

Hi @Graat, thanks for this question! I assume you're using Windows Forms. I think the best strategy is to place a CheckedListBox outside your plot and use it to control visibility of the plotted items. I think you'll need to use System.Drawing calls to draw the colored lines on top of each listbox item. You can search for code examples online that use the OnDrawItem event to achieve custom functionality. https://www.codeproject.com/Articles/1062442/A-Multi-Color-Multi-Font-CheckedListBox has some advice about this.
I'm going to close this issue since I think the solution is a WindowsForms solution and not a ScottPlot solution, but hopefully this points you in the right direction and if you are able to achieve this effect I'd love it if you could follow-up and share some screenshots and the code you used to achieve it!
Best,
Scott


tpm2-abrmd: 2.3.3 -> 2.4.1 & fix build

Description of changes
Follow-up to #167940
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

The commit breaking this reached nixpkgs master already.

Oh no. So should we also go to master with this? It's >5k rebuilds...


TfsAuthenticator hangs the IDE

With the version 1.111.0 of the plugin, I do see a strange behavior of the plugin. In case I do use VSTS Git source control in which I do authenticate on TFS, and then later I attempt to use TFVC, in case the authentication was already provided, IDEA IDE gets unresponsive and I do find following in my log:
2016-12-27 12:36:54,227 [  26081]   WARN - fsTelemetryInstrumentationInfo - Unable to locate property resource /telemetry/com.microsoft.alm.plugin-telemetry.properties
2016-12-27 12:36:54,305 [  26159]   WARN - n.settings.TeamServicesSecrets - getServerContextSecrets: info was null for key:
2016-12-27 12:36:54,414 [  26268]   WARN - n.settings.TeamServicesSecrets - getServerContextSecrets: info was null for key:
2016-12-27 12:36:54,492 [  26346]   INFO - .checkout.VsoCheckoutPageModel - Skipping loading contexts in constructor
2016-12-27 12:36:54,492 [  26346]   INFO - n.context.ServerContextManager - Prompting for credentials
2016-12-27 12:36:54,492 [  26346]   INFO - ugin.authentication.AuthHelper - getAuthenticationInfoSynchronously calling authenticateAsync on https://tfs.mytfs.com/tfs
2016-12-27 12:36:54,492 [  26346]   INFO - tion.TfsAuthenticationProvider - starting TfsAuthenticator

In order to get it working I need remove the ServerContextState node from vsts_settings.xml file so that the plugin can request the auth again. Then it works. Same is valid for the vice versa approach, if you initially choose TFVC then try to open VSTS Git source control; TfsAuthenticator Async authentication refuses to start and hangs IDEA.
Regards,
Mario

Hi @mmajcica,
Thanks for reporting the issue. There must be a problem where we reuse the login info from the Git repo for the TFVC repo since they share the same account. I'm taking a look at it and will see if I can reproduce the issue on my side.  At what point does it hang? Do you see the Checkout dialog again or do you not even get that far?
Thanks again,
-Leah

Hi @leantk,
indeed. If I do first use Git and login, clone a repo and such. Next time I do try to select the TFVC from the main screen:

Then the app gets stuck, I do NOT get to even see any other window.
The same goes vice versa in case I use the TFVC then try git.

@volnoboy
I already mentioned a fix above in my first post:
In order to get it working I need remove the ServerContextState node from vsts_settings.xml file.
Once you remove all ServerContextState nodes from vsts_settings.xml file and restart IDEA, you will get prompted to authenticate again and it will work. Not an elegant way but it works.
Cheers,
Mario

@volnoboy
I already mentioned a fix above in my first post:
In order to get it working I need remove the ServerContextState node from vsts_settings.xml file.
Once you remove all ServerContextState nodes from vsts_settings.xml file and restart IDEA, you will get prompted to authenticate again and it will work. Not an elegant way but it works.
Cheers,
Mario

I cannot locate anywhere this file vsts_settings.xml?

I cannot locate anywhere this file vsts_settings.xml?

I have no pc access right now, however it should be in your user folder
under .idea folder somewhere (name of the folder may be different however
I'm sure it starts with a dot). Search for it.
Mario
On 01 Jan 2017 16:15, "volnoboy"<EMAIL_ADDRESS>wrote:

I cannot locate anywhere this file vsts_settings.xml?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vso-intellij/issues/49#issuecomment-269906680,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC4ud1vk8ZWlGOU1Mu8al01KtX-0wkZEks5rN8MNgaJpZM4LWOmh
.

I have no pc access right now, however it should be in your user folder
under .idea folder somewhere (name of the folder may be different however
I'm sure it starts with a dot). Search for it.
Mario
On 01 Jan 2017 16:15, "volnoboy"<EMAIL_ADDRESS>wrote:

I cannot locate anywhere this file vsts_settings.xml?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vso-intellij/issues/49#issuecomment-269906680,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC4ud1vk8ZWlGOU1Mu8al01KtX-0wkZEks5rN8MNgaJpZM4LWOmh
.

@volnoboy
If you still haven't found it (which I doubt :) ) here is the path in my case:
C:\Users\majcicam.IdeaIC2016.3\config\options
where majcicam is my user profile folder and .IdeaIC2016.3 is specific to edition and version of IDEA I'm using. Adapt it for your case.
Mario

Thank you. Now, I found it. I was looking into .idea in my project folder.

@volnoboy- we are still looking at fixing this bug permanently so you don't have this pain. We apologize. I will keep this issue updated on the progress. Thanks for your patience.
@mmajcica- thanks for pointing him to the workaround and the right path for the settings file. I'm still debugging the issue at the moment.

@mmajcica or @volnoboy,
I made a code change that fixes the issue for me but I couldn't get a true repro of the freeze so I was hoping maybe one of you could test it out for me if you are still having issues. I've attached the updated plugin build here. Please let me know if you see any change or the same thing.
plugin.idea-1.111.1-freezeFix.zip
Thanks for the help,
-Leah

@leantk
I just tried it on two machines, different test cases and it now works as expected.
In which version of the plugin will this fix end up?
Thanks

@mmajcica it will be version 1.111.1 and I'm looking to release it next week. I'll update this issue once it's out there to download.

I just released the fix under the version 1.111.1. Please reopen this issue if you see this behavior again but for now I'm going to close it since I've had 2 people verify it fixed the issue.


Handling layering/clipping/overflow

We'll need to discuss if and how to handle these issues.
This is especially obvious when moving items between two scrollable lists.
TODO: @Aierie add video

Closing as unfnished in anticipation of alpha release.


Question: Any sample pages other than "Obsidian Digital Garden"?

Hi, I was wondering what the end result looks like for this plugin but can't find any other sample pages. If you know of anyone who uses this plugin to publish their notes could you please share their pages here? Thanks a lot!

I know of one, https://notes.thatother.dev, from other issues posted here.
Sadly I'm not aware of many others, as I have no way of getting that information. It would be nice to have a list though, that can be added to the README as examples. If people are comfortable with it, it would be great if they could post a link to their digital garden in this thread/issue.

Hi, I also created a page, check notes.hxhc.xyz. I made some customization on the theme cause I like light themes.

i'll chip in with my site here: erosaezhe.netlify.app/
(i'm currently submitting another issue to do with links generated from dataview tables)

This should be added to the documentation. Heck, you could make a button to submit to the directory!

here's mine! https://ajy.co - it's a work in progress (but I guess that's the point). I'm using the default theme with some customizations. Thanks for packaging this together in a way that made it easy to get up and running. Dataview support in particular is awesome.

Here is mine: https://edav-garden.netlify.app 🎉 It is on the topic of exploratory data analysis and visualization (EDAV).

Awesome plugin, very easy to set up and really doesn't get in your way!
Here's mine: https://overthinking.netlify.app/ still a work in progress though.

This is my site: https://booksbeansboots.co.uk/ Random jottings and some writing!

My knowledge tree: https://pawelel.netlify.app/

This is mine: https://topobon.utsob.me
Hacked the template quite a bit, primarily to support title from the frontmatter.

This is mine: https://topobon.utsob.me
Hacked the template quite a bit, primarily to support title from the frontmatter.

This is still accessible, but as an alias. I've moved the site to https://hermitage.utsob.me

Hi, thank you for the plugin!
I just posted mine here https://www.emhabayu.com

This is the digital garden I created     https://wangc.tech/

Hi, this is my garden: https://glj0.eu.org, mainly daily notes, in Chinese

Adding my own: https://garden.alexrinehart.net/
Still building it out 🙂

Adding my own: https://garden.alexrinehart.net/
Still building it out 🙂

Nice! Very attractive.
The one thing I would wish for is the ability to add a commenting feature!

Adding my own: https://garden.alexrinehart.net/
Still building it out 🙂

Nice! Very attractive.
The one thing I would wish for is the ability to add a commenting feature!

Good idea! I've used Utterance for my blog, I could probably connect the same thing here with a little bit of work.

Good idea! I've used Utterance for my blog, I could probably connect the same thing here with a little bit of work.

If you get it working, let me know how!

Good idea! I've used Utterance for my blog, I could probably connect the same thing here with a little bit of work.

If you get it working, let me know how!

This is actually very easy following this method: https://dg-docs.ole.dev/advanced/adding-custom-components/

Good idea! I've used Utterance for my blog, I could probably connect the same thing here with a little bit of work.

If you get it working, let me know how!

This is actually very easy following this method: https://dg-docs.ole.dev/advanced/adding-custom-components/

Good callout! This was actually super easy. All I did was add one file and then enable the Utterances app for my repo. Works like a charm! Might need to pretty up the CSS to match the rest of my site, but that's straightforward too. Thanks for the tip.
Also notifying @Calorion

Hi, this is my garden: https://zytomorrow.top/, in Chinese. And I add a comment function，it replace my blog with hugo perfectly.

Hi, I recently published my dungeons and dragons campain notes with your template:
pheelwell-garden.vercel.app

Hi, I recently published my dungeons and dragons campain notes with your template:
pheelwell-garden.vercel.app

That looks amazing! However, your "Last Updated Articles:” and "Largest Articles” functions aren’t working. Pretty cool if they did though!

I know, they did work when I first exported the Site. But something went wrong after republishing it 😢

here's mine! https://ajy.co - it's a work in progress (but I guess that's the point). I'm using the default theme with some customizations. Thanks for packaging this together in a way that made it easy to get up and running. Dataview support in particular is awesome.

This is amazing! How did you get all those neat Javascript tricks working?

Currently I'm building two Digital Gardens:

https://aiuanyu.vercel.app (namely "Love for all languages in Taiwan", posts and notes for promoting knowledge about languages and writing)
https://imazingrace.vercel.app (namely "Imazing Grace of information technology and internet", sharing posts and notes about softwares)

Both in various languages in Taiwan, not only in Mandarin (Chinese), but also in Hakka, Taigi.

Add www.spiritual-garden.com please?

Add https://dudethatserin.com please?

At this point, we can create a categorized directory of digital gardens.

thankyou for this awesome plugin
bit-garden.vercel.app

https://bit-garden.vercel.app/

Currently I'm building two Digital Gardens:

aiuanyu.vercel.app (namely "Love for all languages in Taiwan", posts and notes for promoting knowledge about languages and writing)
imazingrace.vercel.app (namely "Imazing Grace of information technology and internet", sharing posts and notes about softwares)

Both in various languages in Taiwan, not only in Mandarin (Chinese), but also in Hakka, Taigi.

Can I ask how you used the template for two different vaults? I tried to add a second one and it errors with loading publication status.

Currently I'm building two Digital Gardens:

aiuanyu.vercel.app (namely "Love for all languages in Taiwan", posts and notes for promoting knowledge about languages and writing)
imazingrace.vercel.app (namely "Imazing Grace of information technology and internet", sharing posts and notes about softwares)

Both in various languages in Taiwan, not only in Mandarin (Chinese), but also in Hakka, Taigi.

Can I ask how you used the template for two different vaults? I tried to add a second one and it errors with loading publication status.

Hi @twhite96 I am actually using only 1 vault but publishing to two digital gardens. Is this what you are looking for? If so, I will write about some simple steps to make it work.

@twhite96, here you go: https://imazingrace.vercel.app/Obsidian/DG/multiple/
Feel free to tell if any questions. Hope gets well with yours.

Here is my garden which written in Japanese: AstroSlips.
I love this plugin 💟

@GJRobert got it done! THANK YOU!!!

I have two sites thanks to @GJRobert:
Cyber Notes
Tiff Notes

Mine: 探索计算机与生活的艺术, still a work in progress though.

Currently I'm building two Digital Gardens:

https://aiuanyu.vercel.app (namely "Love for all languages in Taiwan", posts and notes for promoting knowledge about languages and writing)
https://imazingrace.vercel.app (namely "Imazing Grace of information technology and internet", sharing posts and notes about softwares)

Both in various languages in Taiwan, not only in Mandarin (Chinese), but also in Hakka, Taigi.

想请教一下，关于你的博客网站aiuanyu.vercel.app，右下角那个日夜切换按钮是怎么实现的啊？

想请教一下，关于你的博客网站aiuanyu.vercel.app，右下角那个日夜切换按钮是怎么实现的啊？

Hello, it's a great example introduced by @oleeskild on the official doc site: https://dg-docs.ole.dev/advanced/adding-custom-components/#examples-in-the-wild
→ https://github.com/uroybd/topobon/blob/main/src/site/_includes/components/user/common/footer/001-floatingControls.njk
How he did it.

I create my garden and will play in it with my friends! thanks very much!
https://perch.parasoltree.top/
I used Minimal theme and created a card view of all the articals, blogs that I will write in. If someone likes it then you can copy this tempelate

I create my garden and will play in it with my friends! thanks very much! https://perch.parasoltree.top/ I used Minimal theme and created a card view of all the articles, blogs that I will write in. If someone likes it then you can copy this tempelate

Hi, in your template there does not seem to contain the CSS files for the card view. Are they in your digitalgarden .njk and .css files? Can you show them?

My Notes Garden

I use this project to host the website for the local bitcoin meetup in Honolulu: www.hnlbtc.group

I create my garden and will play in it with my friends! thanks very much! https://perch.parasoltree.top/ I used Minimal theme and created a card view of all the articles, blogs that I will write in. If someone likes it then you can copy this tempelate我创造了我的花园，并将和我的朋友一起在里面玩耍！非常感谢！https://perch.parasoltree.top/ 我使用了最小主题并创建了我将在其中撰写的所有文章和博客的卡片视图。如果有人喜欢它，那么你可以复制这个诱惑

Hi, in your template there does not seem to contain the CSS files for the card view. Are they in your digitalgarden .njk and .css files? Can you show them?嗨，在您的模板中似乎不包含卡片视图的 CSS 文件。它们是否在您的数字花园 .njk 和.css文件中？你能给他们看吗？

I just used Minimal theme default. and added this in yaml, then the table created by dataview became cards.

cssclasses:

cards
cards-cover
cards-1-1
cards-cols-4

though there are some css and njks i used in my settings ,it's just trying to fix some bugs of the theme.

Hello. I have been building my digital garden for a while. You can find it here: www.mathnuscripts.com/

Making my knowledgebase for sharing here;
https://1AR.NO

Here is my website of my notes: https://brain.mingzailao.live

I'm so grateful for this Obsidian Digital Garden plugin! Here's my website. I'm a Mandarin and English conference and legal interpreter:
https://ericliaointerpreting.com/

please add my as well: https://www.craftengineer.com/, thanks 🙏

Thanks for the plugin, it's brilliant.
My garden: https://garden.pivic.com

https://notes.dipta007.com/

This is my website https://blog.j-zh.top
Thanks for the great plugin! Also wrote an article comparing differnt Obsidian blog solutions, and how I ended up with Obsidian Digital Garden

I'm again tinkering with Vercel given the possibility of customization (and possibility of comments, which I'm trying to figure out―thanks to the people earlier in the thread that pointed me toward Utterances!). My site focuses/will focus on professional counseling and contemplative/meditative practices. You can find it here: The Radical Rogerian: Counseling and Contemplation.

Built a PKMS for manim :

https://manim-personal.vercel.app/

emrahkelep.com
Thank you for this addon. My digital gardenis  in Turkish language.

https://www.isaacwyatt.com/til-today-i-learned/
^ as of the date of this post, I am using the Obsidian Digital Garden Plug-in and Obsidian as the whole CMS for my personal website.
This is NOT representative of what a user would get out-of-the-box with the Digital Garden Plugin however, as I have heavily customized the CSS, nunjucks templates, etc. In order to get the look and behavior of the site how I want it to be.
There are always a hand full of more tweaks I want to make as well but I'd say that as of today, it is ~90-95% of what I envisioned.

Thanks for this plugin! I'm using it for: https://macmartine.com/

非常感谢作者创作的插件，这是我的网站，内容是以中文写就的。欢迎诸君来访。
平淡出真味，心灵知巧拙。
Many thanks to the author for creating the plugin, this is my web site and the content is written in Chinese. You are welcome to visit.
Plainness brings out the true flavor, and the mind knows how to be clever.
https://dg.muxiao.org/

This is great. I just moved my digital garden from Notion to Obsidian using this plugin and Netifly.
https://garden.oxus.net/

This is great. I just moved my digital garden from Notion to Obsidian using this plugin and Netifly.
https://garden.oxus.net/

Dear Professor Kerim,
this is a greeting from Taichung. I was surprised and glad to see a main section about Taiwan on your digital garden. And after further searches I realized of your current work in Taiwan. Thanks for your care and informative introduction.
Here is my digital garden talking about Taiwan's languages and ethnic groups (mainly in Chinese):
https://aiuanyu.net/
Any suggestions are welcomed. Great honor to see you and thanks!
Robert Ciang

Dear Robert,
Nga'ay ho. What a wonderful connection to make here on Github!
Cheers,
Kerim / 傅可恩

The plugin is amazing! This is my site: https://dg.objs.net, and I will keep updating.

I've just made the decision to migrate my webiste from Wordpress to a lightweight, easy to update, customisable and best of all FREE platform. DigitalGarden fit the bill perfectly. My digital garden is more a portfolio, but it works, and it works incredibly well.
Check it out: https://niallbell.com

Big fan of this plugin! Great job! Thank you for providing it for free!

I made this one with this plugin
https://obsidian-devops-notes.vercel.app/
and this one with quartz
https://neovoid.is-cool.dev/quartz

I am very happy with the plugin and maintain this wiki with it: https://wiki.sascha-kasper.com/

Hi, I was checking analytics for my site https://notes.johnmavrick.com and realized that some traffic was coming from here because I had previously used your amazing plugin. I just wanted to let you know so someone else can take the home page spotlight as I am now using publish and soon Quartz :)

Thanks to the plugin author and others who provided design ideas. I joined this community just a couple of weeks ago, and it's been fantastic!
Here’s my garden: OuOb Space!. I hope to interact more with everyone and exchange ideas!

Hi! I am so happy because of your plugin!!
Thank you for giving me this coooooooool plugin!
Have a nice day

Wonderful project! It's exactly what I was looking for after trying all the other options, I'm glad I landed on yours! Here is my garden (sparse for now, but will be adding more as I migrate notes): https://garden.graysonarts.com/

We are using the plugin to maintain the local page for an upcoming conference. We have integrated Hyvor for comments on the helpdesk page. There was some custom CSS for the callouts. This has been an amazing solution!

hello, it seems this thread is no longer used to update the gallery of sites running on digital garden plugin :(( cc @oleeskild
I also created https://github.com/oleeskild/digitalgardendocs/pull/56.
Maybe could find a dedicated maintainer for this? if the author no longer has time for it? or any other ideas?

I've been toying around with an idea of creating an index of digital gardens for people to browse. No hardship having a section dedicated to those which are using this Digital Garden Plugin for Obsidian. Would just need to support of the devs to make it work.

hello, it seems this thread is no longer used to update the gallery of sites running on digital garden plugin :(( cc @oleeskild
I also created https://github.com/oleeskild/digitalgardendocs/pull/56.
Maybe could find a dedicated maintainer for this? if the author no longer has time for it? or any other ideas?

I would be up for that, let's make a showcase site?
If I get good response here, I will add a repo and possibly a discord server.

hello, it seems this thread is no longer used to update the gallery of sites running on digital garden plugin :(( cc @oleeskild
I also created oleeskild/digitalgardendocs#56.
Maybe could find a dedicated maintainer for this? if the author no longer has time for it? or any other ideas?

I would be up for that, let's make a showcase site? If I get good response here, I will add a repo and possibly a discord server.

Here is my work on this project so far. It's only very early days as been busy over Christmas. Happy to take input if anyone has any:
Not on an official domain yet: https://allotmentzone.vercel.app/


[SPARK-34922][SQL][3.0] Use a relative cost comparison function in the CBO

What changes were proposed in this pull request?

Changed the cost comparison function of the CBO to use the ratios of row counts and sizes in bytes.
Why are the changes needed?

In #30965 we changed to CBO cost comparison function so it would be "symetric": A.betterThan(B) now implies, that !B.betterThan(A).
With that we caused a performance regressions in some queries - TPCDS q19 for example.
The original cost comparison function used the ratios relativeRows = A.rowCount / B.rowCount and relativeSize = A.size / B.size. The changed function compared "absolute" cost values costA = w*A.rowCount + (1-w)*A.size and costB = w*B.rowCount + (1-w)*B.size.
Given the input from @wzhfy we decided to go back to the relative values, because otherwise one (size) may overwhelm the other (rowCount). But this time we avoid adding up the ratios.
Originally A.betterThan(B) => w*relativeRows + (1-w)*relativeSize < 1 was used. Besides being "non-symteric", this also can exhibit one overwhelming other.
For w=0.5 If A size (bytes) is at least 2x larger than B, then no matter how many times more rows does the B plan have, B will allways be considered to be better - 0.5*2 + 0.5*0.00000000000001 > 1.
When working with ratios, then it would be better to multiply them.
The proposed cost comparison function is: A.betterThan(B) => relativeRows^w  * relativeSize^(1-w) < 1.
Does this PR introduce any user-facing change?

Comparison of the changed TPCDS v1.4 query execution times at sf=10:
| absolute | multiplicative |   | additive |
-- | -- | -- | -- | -- | --
q12 | 145 | 137 | -5.52% | 141 | -2.76%
q13 | 264 | 271 | 2.65% | 271 | 2.65%
q17 | 4521 | 4243 | -6.15% | 4348 | -3.83%
q18 | 758 | 466 | -38.52% | 480 | -36.68%
q19 | 38503 | 2167 | -94.37% | 2176 | -94.35%
q20 | 119 | 120 | 0.84% | 126 | 5.88%
q24a | 16429 | 16838 | 2.49% | 17103 | 4.10%
q24b | 16592 | 16999 | 2.45% | 17268 | 4.07%
q25 | 3558 | 3556 | -0.06% | 3675 | 3.29%
q33 | 362 | 361 | -0.28% | 380 | 4.97%
q52 | 1020 | 1032 | 1.18% | 1052 | 3.14%
q55 | 927 | 938 | 1.19% | 961 | 3.67%
q72 | 24169 | 13377 | -44.65% | 24306 | 0.57%
q81 | 1285 | 1185 | -7.78% | 1168 | -9.11%
q91 | 324 | 336 | 3.70% | 337 | 4.01%
q98 | 126 | 129 | 2.38% | 131 | 3.97%
All times are in ms, the change is compared to the situation in the master branch (absolute).
The proposed cost function (multiplicative) significantlly improves the performance on q18, q19 and q72. The original cost function (additive) has similar improvements at q18 and q19. All other chagnes are within the error bars and I would ignore them - perhaps q81 has also improved.
How was this patch tested?

PlanStabilitySuite

Test build #137007 has started for PR 32076 at commit a5b33bd.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41585/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41585/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41585/

Test build #137007 has finished for PR 32076 at commit a5b33bd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137007/

@maropu

Thanks! Merged to branch-3.0.