Validation for named (name) is responding with validation error (The 1 field is required.) even the input has value.

Laravel Version: 5.6.*
PHP Version: 7.2
Database Driver & Version: MySQL

Description:
Validation for named (name) is responding with validation error (The 1 field is required.) even the input has value.
Steps To Reproduce:
// request & validation
class CategoryRequest extends FormRequest
{
    public function authorize()
    {
        return true;
    }

    public function rules()
    {
        return [
            // if I try to remove this or renamed it with different key name the validation works,
            // but if the name is name the validation is responding with (The 1 field is required.)
            'name' => 'required|max:100'
        ];
    }
}

// controller
class PageCategoryController extends Controller {
    public function store(CategoryRequest $request) {
        Category::insert($request->all());
        return redirect()->back();
    }
}

// view
<form action="/admin/category/store" method="post">
{{ csrf_field() }}
<input name="name" type="text" value="Sample Value">
<button type="submit">Save</button>
</form>

Thanks

Please post more context (controller, name values you tried).

I already managed to fixed the problem I put (,) instead of (=>) in between of
'name' => 'required|max:100'
Thanks anyway.


update dependencies to latest

mongo java driver
netty
log4j
scala to latest patch releases

@scullxbones I would propose to update dependencies to latest and then afterwards do a release - including the Scala 3 artifacts from PR #15
Is that ok for you? Would you choose version 1.1.0 or 1.0.3?

@thjaeckle sounds great!  Should I set up Scala steward on this repo?  That would at least automate dependency management.
I think a minor is appropriate in general so 1.1.0

Should I set up Scala steward on this repo? That would at least automate dependency management.

@scullxbones cannot hurt, I would say

FYI https://github.com/VirtusLab/scala-steward-repos/pull/351


Update FEATURE_MATRIX.md

Just fixing a typo in the Chat-GPT model name
Motivation and Context

Description

Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

thank you @lucas-a-meyer


Fails with UTC offset without colon

Fails to parse this valid date 2001-11-11T11:11:11+0000 because the UTC offset does not have a colon.
SSCCE: https://ellie-app.com/3p4fLfFWwD4a1
According to Wikipedia (and our php server :P) UTC offsets may or may not have the colon.

As far as I can tell time zone offset can be given without colon or with just the hours. +01, +0100 and +01:00 are all valid time zone notations.
Just to add a source other than wikipedia, see under "Time Zone": https://www.cl.cam.ac.uk/~mgk25/iso-time.html

Fixed by https://github.com/rtfeldman/elm-iso8601-date-strings/pull/20


quotes: updating avoidEscape to allow template literals to avoid escape sequences

Clear and concise description of the problem
basing this off: https://github.com/eslint/eslint/issues/7660
Basically, with config: ["error", {avoidEscape: true}], template literals should be allowed when the other option is for the literal to have added escape sequences.
Suggested solution
Instead of fixing:
x.startsWith(`"`) ? `"`  : null

into:
x.startsWith("\"") ? "\"" : null

it should be:
x.startsWith(`"`) ? `"` :  null

This would change the language from:

"avoidEscape": true allows strings to use single-quotes or double-quotes so long as the string contains a quote that would have to be escaped otherwise

to:

"avoidEscape": true allows strings to use single-quotes, double-quotes, or template literals so long as the string contains a quote that would have to be escaped otherwise

Further examples:
Instead of:
     const metaTags = document.querySelectorAll<HTMLMetaElement>(
-      `meta[property^="og:"]`,
+      "meta[property^=\"og:\"]",
     )

we'd leave it unchanged:
   const metaTags = document.querySelectorAll<HTMLMetaElement>(
     `meta[property^="og:"]`,
   )

Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Contributes

[X] If this feature request is accepted, I am willing to submit a PR to fix this issue

Making sense to me, PR welcome! Just to note that we might need to respect emcaVersion and avoid using it on versions that are not support template literals, otherwise I think it also make sense to enable it by default in modern JS.


Not able to figure out how to get the offsets and partitions for produced records in a transaction

Hello, excellent library, was able to implement it very quickly, docs and examples were very easy to understand.
I'm trying to figure out how to get the partition and offset for records produced in a transaction, was excited to see ComittedOffsets() but it's always nil.

Is there something obvious I'm missing?

EOS transactions are meant to use GroupTransactSession, and the records that are committed are not exposed -- internally it's managed (committed and new transaction began all at once). This client doesn't really expose a way to manually manage transactions without using the GroupTransactSession, because transactions have so many odd edge cases that all the complexity is hidden internally.
For producing, there is no committed offset. Committed offsets are more for non-transactional group consumers.
What are you trying to do?

I see, reading through the code now.
I'm trying to get the partition and offset a record was committed to - I guess I can use a non transactional sync to get this in the return (assumptions, sketchy of me, I know, lol)?
I want to get to something like:
https://github.com/twmb/franz-go/blob/master/examples/manual_committing/main.go#L70
For each record.

What's the code look like?
You can use Produce as well. The record's Offset and Partition fields (and a few others, which are documented) are updated before the records are passed to the callback.

Would have to pseudocode the implementation to share it :(  It's simply an abstraction to handle configs and whatnot and expose pub/sub for a few event broker configurations.
I noticed the record sent to the callback has the partition and offset populated from Produce().  We're doing both sync and async.
So that's fantastic, we're almost done with the eventing lib/helper in this reference architecture project and this is one of the last requirements, we should see it in dev env next week.
Very much looking forward to the first production service implementation using it - thanks!
P.S.
The admin stuff is rad :)


Bug with PKCS12_newpass

Hello
I try to use PKCS12_newpass in my code, and as I have an error, I replicate the same error with a small program based of the sample of OpenSSL
#include <stdio.h>
#include <stdlib.h>
// #include <openssl/pem.h>
#include <openssl/err.h>
#include <openssl/pkcs12.h>

#include <applink.c>

#pragma comment(lib, "ws2_32.lib")

int main(int argc, char **argv)
{
	FILE *fp;
	PKCS12 *p12;

	if (argc != 5) {
		fprintf(stderr, "Usage: pkread p12file password newpass opfile\n");
		return 1;
	}
	if ((fp = fopen(argv[1], "rb")) == NULL) {
		fprintf(stderr, "Error opening file %s\n", argv[1]);
		return 1;
	}
	p12 = d2i_PKCS12_fp(fp, NULL);
	fclose(fp);
	if (p12 == NULL) {
		fprintf(stderr, "Error reading PKCS#12 file\n");
		//ERR_print_errors_fp(stderr);
		return 1;
	}
	if (PKCS12_newpass(p12, argv[2], argv[3]) == 0) {
		fprintf(stderr, "Error changing password\n");
		//ERR_print_errors_fp(stderr);
		PKCS12_free(p12);
		return 1;
	}
	if ((fp = fopen(argv[4], "wb")) == NULL) {
		fprintf(stderr, "Error opening file %s\n", argv[4]);
		PKCS12_free(p12);
		return 1;
	}
	i2d_PKCS12_fp(fp, p12);
	PKCS12_free(p12);
	fclose(fp);
	return 0;
}

I always have an error with PKCS12_newpass, even if I have no error with PKCS12_parse (in my code).
Can you confirm that this function has no error ?
I am using OpenSSL 3.0.4 on Windows
Regards
Gilles

Hello
I thought that there was more reactivity on this project
Nobody has problem with this function ?
Regards
Gilles

Hello
Your response is very curious. I just take the sample in manpage of openssl 3.0 (https://www.openssl.org/docs/man3.0/man3/PKCS12_newpass.html) (and also 3.1)
So it isn't an old API, but a supported API.
I just use the sample in manpage, not more.
Otherwise, how can we change password of .p12 file in C ?
Regards
Gilles

Hello
I tested again the fix, and the modification of password is not possible.
Do you have another fix ?
Regards
Gilles

If the file contains only one private key and corresponding certificate chain, you can extract them using PKCS12_parse() and then recreate with PKCS12_create() passing the new password.
With OpenSSL 3.0 it would be necessary to load the legacy provider if the input file is encrypted by outdated algorithms.


Emit DynamicDependency for CompiledAvaloniaXaml types to prevent compiled xaml from trimming

Emit DynamicDependency for CompiledAvaloniaXaml.* on program entry point to prevent from trimming when compile against net5.0+.
For example,
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(CompiledAvaloniaXaml.!AvaloniaResources))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(CompiledAvaloniaXaml.!EmbeddedResource))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(CompiledAvaloniaXaml.!IndexerAccessorFactoryClosure))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(CompiledAvaloniaXaml.!XamlLoader))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(CompiledAvaloniaXaml.XamlIlContext))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(CompiledAvaloniaXaml.XamlIlHelpers))]
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(CompiledAvaloniaXaml.XamlIlTrampolines))]
static void Main() // or other method which is directly referenced in code path
{
    // ...
}

This can ensure compiled avalonia xaml types and members won't be trimmed by ILLinker even with /p:TrimmerDefaultAction=true.

We should just fix StyleInclude/ResourceInclude so they would directly reference the code instead of using reflection. It was left as "something to fix later" and it's been 3 years already -_-

I think before the reflection-free approach got implemented, putting abose trimming attributes on an empty module initializer is a helpful workaround.

StyleInclude/ResourceInclude were fixed to work without reflection (with some remaining bugs, but I am working on it).
So, this can be closed now.

Ah, that's a XamlX repository. Either way, CompiledAvaloniaXaml type was emitted by the Avalonia XAML extensions, and not by the XamlX itself. So same problem isn't actually related to the XamlX by itself.


[HOLD for payment 2024-09-26] [$250] [Dev] Console Warning: Possible unhandled promise rejection

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.30-9
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @c3024
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726072317575939?thread_ts=1726072125.690969&cid=C049HHMV9SM
Action Performed:
Logon to ND on iOS App
Expected Result:
No console warning
Actual Result:
Console Warning
Warning: Possible unhandled promise rejection
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021834518653490433368
Upwork Job ID:<PHONE_NUMBER>490433368
Last Price Increase: 2024-09-13

Issue OwnerCurrent Issue Owner: @aimane-chnaif

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Proposal
Please re-state the problem that we are trying to solve in this issue.
Console warning when open native app.
What is the root cause of that problem?
When we open the app, the first route is the bottom tab navigator which has an empty path.
https://github.com/Expensify/App/blob/7748eff72fc43ecaf3db6159928d8d581a63ab99/src/libs/Navigation/linkingConfig/config.ts#L65-L67
https://github.com/Expensify/App/blob/7748eff72fc43ecaf3db6159928d8d581a63ab99/src/ROUTES.ts#L21
The warning is shown when we pass the empty string to the URL constructor.
https://github.com/Expensify/App/blob/7748eff72fc43ecaf3db6159928d8d581a63ab99/src/libs/actions/Report.ts#L2683-L2685
What changes do you think we should make in order to solve the problem?

Make sure the url is not empty before passing it to the URL constructor.
if (url && new URL(url).searchParams.get('exitTo') === ROUTES.WORKSPACE_NEW) {
    return;
}

Sounds perfect. Assigning!

PR was deployed to prod on 9/19 but it looks like the automation didn't work. Updating manually to add payment date

Requested in ND.

@stephanieelliott mind confirming this payment summary when you're back online? Thank you!

@aimane-chnaif are you able to request via NewDot? It looks like are eligible for ND payments, and we would prefer to pay in ND rather than Upwork if it's ok with you. Otherwise, please let me know so that I can extend the offer to you in Upwork.
Summarizing payment on this issue:

Contributor: @bernhardoj $250 - please request via NewDot
Contributor+: @aimane-chnaif $250 - please request via NewDot

$250 approved for @bernhardoj

Hey @aimane-chnaif I extended the offer to you in Upwork, please accept when you get a chance! https://www.upwork.com/nx/wm/offer/104253282

All paid


[website] Broken links to some download packages

Describe the bug
When I check the Pulsar website with link check tool, I've found some broken links to download packages. I've fixed the ones i could. Could someone give some help on the ones with red boxes? The following is part of the report from https://www.drlinkcheck.com/

@tuteng could you give some help? Thank you.

I think this css file https://github.com/cckellogg/incubator-pulsar/blob/26d7dfbc651353f91eea4ecf0400685c331eaf5c/site2/website/static/css/code-blocks-buttons.css  can be added, but some download links I tested are normal.
https://archive.apache.org/dist/incubator/pulsar/pulsar-1.20.0-incubating/apache-pulsar-1.20.0-incubating-src.tar.gz
https://archive.apache.org/dist/incubator/pulsar/pulsar-1.19.0-incubating/apache-pulsar-1.19.0-incubating-src.tar.gz
But some file names are wrong, I think you can try to fix it.

Yes, when you click https://archive.apache.org/dist/incubator/pulsar/pulsar-1.19.0-incubating/apache-pulsar-1.19.0-incubating-src.tar.gz, it works; however, when you click sha512 under that package, it does not work. The asc links work well.


buildStatic doesn´t need System.import?

Hi, so this is probably a noob question, but anyway, I created my first bundle for the quickstart tutorial for Angular 2, and I can´t really understand what is happening with my index.html.
So, my bundle is created like this in gulpfile.js
gulp.task('bundle:app', () => {
  builder.buildStatic('app/*.js', 'web/app/bundle.app.js')
  .then(function() {
    console.log('Build complete');
  })
  .catch(function(err) {
    console.log('error ' + err);
  })
})

Really basic; now when I use this index.html
<html>
  <head>
    <title>Angular 2 QuickStart Deploy</title>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <link rel="icon" type="image/x-icon" href="favicon.ico">
    <link rel="stylesheet" href="css/styles.css">
    <!-- 1. Load libraries -->
    <!-- Polyfill(s) for older browsers -->
    <script src="lib/shim.min.js"></script>
    <script src="lib/zone.js"></script>
    <script src="lib/Reflect.js"></script>
    <script src="lib/system.src.js"></script>
    <script>
      System.import('app').catch(function(err) { console.error(err); });
    </script>
  </head>
  <!-- 2. Display the application -->
  <body>
    <my-app>Loading...</my-app>
    <!-- application bundle -->
    <script src="app/bundle.app.js"></script>
  </body>
</html>

I get an error Unexpected token <, somehow my app is trying to load http://localhost/ois/web/app and can´t find it.
But, if I remove the System.import completely, then it works. So the thing is, I thought that line was really necesary. In stackoverflow someone suggested that this line is not needed when using a bundle. Is that correct? I did not specify any "initial" module to load and bootstrap the application.
Can anyone give me a hint on what is going on?
Thanks!

@davidanaya you are right, when you build static you don't need the import. That's because you are already giving the starting module when you call
buildStatic("initialFile.js", "out.js")

But in my case I'm not using a single file, actually I could be using something like this 'app/**/*.js', right? so in that case what would be the starting module?

It doesn't matter that you're not using a single file, what the SystemJS builder does is to automatically figure out all files that will be required (i.e. all dependencies, both direct and transitive) starting from your "main" file.

ok, I get it, thanks!


Documentation and getting started guides

For the release of M1 we should have all the documentation and getting started guides for Spacenet as well as all the repository and components of IPC for developers that want to dig deep into our tech.

[ ] Add READMEs and tutorials for the IPC Agent.
[ ] Update Spacenet documentation
[ ] Update actor READMEs and tutorial.

(This is used as the top-level issue to track the documentation task, additional issues will be correspondingly opened in the relevant repos)

Staging site is now live at https://interplanetary-consensus.netlify.app/interplanetary-consensus/overview/
GDocs staging document is here - https://interplanetary-consensus.netlify.app/interplanetary-consensus/overview/
Further edits are upcoming and top priority!! 🙏


Visible property for most controls

Feature request type
Enhance component
Component name
No response
Is your feature request related to a problem?
No response
Describe the solution you'd like
Can I suggest a "Visible" property for all controls/components? I believe this would produce cleaner razor markup than wrapping controls in a conditional statement (such as an if) when we simply want to control whether or not the item renders.
[MudField Visible="@obj is not<EMAIL_ADDRESS>instead of
@ (if obj is not null)
{
<EMAIL_ADDRESS>}
Have you seen this feature anywhere else?
This would mimic classic ASP.NET WebForm controls.
Describe alternatives you've considered
An alternative is to wrap a control in a conditional statement which creates more lines in the markup and an additional indentation.
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This would work nicely with an additional, optional HidingMode parameter defaulting to Collapse. For example:
Enum:
/// <summary>
/// Defines how the element should be hidden when IsVisible is set to false.
/// </summary>
public enum HidingMode
{
    /// <summary>
    /// Do not reserve space for the invisible element in the layout.
    /// </summary>
    Collapse = 0,

    /// <summary>
    /// Reserve space for the invisible element in the layout.
    /// </summary>
    Hide = 1,
}

Component (or component base):
.AddClass("class-collapsed", when: !IsVisible && HidingMode == HidingMode.Collapse)
.AddClass("class-hidden", when: !IsVisible && HidingMode == HidingMode.Hide)

Style:
.class-collapsed { display: none; }
.class-hidden { visibility: hidden; }

In WPF this functionality was (is) provided by Visibility(Visible|Hidden|Collapsed) enum, but using enum all the time can be a pain the backside if you simply want to hide something with true/false values.
The solution proposed above could give users the best of both worlds.

Thanks, BieleckiLtd. To be clear, I believe if the visible property is false, it should not render the item in Blazor (vs setting the display to hidden in CSS).  I believe this would increase performance as the code and render pipeline would not have to execute for the items. This, of course, would not be able to mimic the visibility:hidden behavior where the item still takes up space.

Very cool. I believe this should be added to ASP.NET core for the reasons stated in that thread. Fingers are crossed. Thanks!


Make the Home page banner responsive

Make the home page banner with explore button responsive for all the devices.
anyone who can do it

ok


Only showing information, not doing anything

Hi there, first of all, thanks a lot for the converter packages.
I tried to use it but miserably failed. When running any command, for example pip2spack create scipy (or download), it just tells me
INFO :: Package status
Available:
	scipy

INFO :: Download latest package for the scipy
     :: pip2spack ::
     :: quick tool for pip -> spack package conversion

     :: Choose operation:
		 - create -- for creation a new package
		 - update -- for update a existing package.py
     ::
INFO :: All information are base on the pypi.org

but doesn't do anything.
What am I missing here?

Hi @jonas-eschle
Can you tell me which operation system and Python version you try to use?
I try to replicate the issue, probably some incompatibility with Py.

Hey, thanks! Sure, Ubuntu 22.04 with Python 3.10 (and pip2spack V 1.0)

I removed a lot of the code with the pull-request #25
Additional changes will introduce the next day.
@jonas-eschle check version 2.0.0a0 from pypi.org
pip install pip2spack==2.0.0a0 --force

Thanks a lot! I tried it but it seems to add the whl url, which fails for spack. Shouldn't we add, instead of "url" just "pypi"?

I work with the Spack, 3 years ago. I don't remember everything ;)
Check the https://pypi.org/project/pip2spack/2.0.0a1/ if this does not work I need to find some time for preparations of some kind of environment.


Scan and remove prepended www/https/http for input domains.

Addresses #33.
Scans for http/www/https and removes them from the domain name.

@ultiferrago It looks like you brought in some other branches relating to HSTS parsing, and now have a merge conflict. Are you working to fix this? If not, or if you're stuck, don't worry -- I'm happy to resolve the conflict myself and merge in the commits we both :+1:'d in a new PR.

@konklone  Yeah haha. I noticed that I jacked it up as I was leaving work. I will be fixing the issue.

Fixed the mess I caused with a bad pull. Everything should be good to go now if you approve.

Tested this locally, and the code works great. Thank you!


Mention VulkanMemoryAllocator-Hpp in README

Could be interesting for C++ programmers already using Vulkan-Hpp.

Thank you for creating this project!


Created pages

Created main and checkout page
https://user-images.githubusercontent.com/99771592/171087655-aae270de-7539-44c5-bc67-5aef1aa1c3fa.mp4

Faço o Merge e mando novamente o pull request?


Presentation over current context

Opening that PR over #421
This PR add a new feature to present a viewController: presenting over current context, in other words, presenting with a custom frame. It will also close #198!
What's in:

A new property for PresentationDesignable : contextFrameForPresentation: CGRect?:

If nil: nothing happened, the presentation will be made in fullscreen
If not nil: the dimmingView frame will be equal to that one and the modal origin / size will be calculated in function of that new frame. That allow the user to present a viewController in a specific context: for example, if you have a split view controller, you may want to present a controller over the first one but let the second without presentedVC.

A new segue PresentOverCurrentContextSegue: using that segue allow the user to present a controller over the current context directly in storyboards. Before presenting the destination, the segue will simply set the source.view.frame as contextFrameForPresentation. If presenting programatically, the user can directly set contextFrameForPresentation to the value he wants.
Introducing PresentationBackgroundView: in reality, the presentation is still in fullscreen. We are just hacking around the frames to give the impression that isn't in fullscreen. That new clear background allow us to forward the hit to the others subviews, which make the interface not presented clickable.
A few code improvements in the presentation classes
Docs update: CHANGELOG and Presentations.md
Demo update

This PR is ready for review, and ready to go!
Note: In the example app, the back button won't catch the events while presenting a viewController. After a deeper search, I concluded that's due to the navigation: we are trying to pop while presenting, so the pop is just ignored. The back button catch the event as expected, but doesn't treat it. We can probably make a workaround for this by handling this state programatically, but since I didn't want to introduce code for that feature, I let it buggy.

          1 Warning

:warning:
Big PR

SwiftLint found issues
Warnings

File
Line
Reason

PresentationModalPosition.swift
84
Lines should not have trailing whitespace.

  Generated by :no_entry_sign: Danger

@tbaranes please allow me to spend some time on this PR. As Danger said it is a "Big PR" 😉

@tbaranes For some network issue, I can't change the text in the review. I was thinking do we need to check definesPresentationContext before we present the overCurrentContext? I am not good at this API.  Can you make a decision which one is better?

@JakeLin About your last point, if we want to use custom presentaiton, the modalPresentationStyle must be set to custom, otherwise it won't work. Since definesPresentationContext works only with currentContext and overCurrentContext, whatever its value is, it won't change the behaviour of the custom presentation. So checking its value in our context is useless.

@tbaranes got it. Because we need to use .custom . Please merge it when you think its ready👍👍👍


Fix shorthand properties named get or set with defaults in object destructuring

const {get = …} = {}

Not sure if the normal parser should use this.type != tt.eq to match the loose one, or if you’d prefer a different approach entirely.

This looks good. Merging!


Add timeouts for Async computation

Add timeouts to async computations similar FSharp.Async

@devboy: is this ticket still valid?

Cancellation and timeouts is still something that needs to be added, yes.


Port range incorrect.

Port range is supposed to be "1024-65535", but it's actually "1025-65535", to fix this, change <= in OpenToLanScreen.java#L84 to < or change 1024 to 1023. I suggest using <.

I will Fix it in new files.


Backport PR #122 on branch v0.4.x (fix CDIPS parsing support (column filled with strings))

Backport PR #122: fix CDIPS parsing support (column filled with strings)

Test failures are likely because the temporary numpy<2 pin from #120 was not backported.


Post purchase  component border not working anymore

Please list the package(s) involved in the issue, and include the version you are using

Describe the bug
<View border="base" padding="base"> as per your example at https://github.com/Shopify/ui-extensions/blob/main/packages/post-purchase-ui-extensions-react/src/components/View/examples/basic-view.example.tsx#L7 padding and a border should be added around the <View/> element.

The <View/> component displayed a border and padding when the border and padding attributes were present.
Steps to reproduce the behavior:

Add the following component to a post-purchase checkout extension: <View border="base" padding="base"></View>

Expected behavior
A border and padding around the  element.

Screenshots

Additional context

@mirceapiturca,  it's the right same bug for me.

@mirceapiturca Any updates? Are they updating anything for the post purchase components?

@mirceapiturca . Yes, It would be great if they could update it just like the checkout extension componenets.

I think post purchase is currently in maintenance mode (no updates / fixes) but they mentioned on a Discord AMA that they would get post purchase aligned with checkout extension in the future. Maybe next year (2024)?


Add # links for headings in generated Roc documentation

This issue proposes that we add support for markdown # links. In a URL, a hash # points a browser to a specific spot in a page or website.
The headings generated from doc comments in https://www.roc-lang.org/builtins/Str are not able to be linked to as they are just simple <h2> tags.
For example the following doc comments would generate a link for the Syntax heading.
## ## [Syntax](#syntax) {#stynax}
##
## The most common way to represent strings is using quotation marks:
##
## ```
## "Hello, World!"
## ```

Hi, I'd like to work on this one please

Thanks @kencruz! I've assigned you to the issue :)


Prepare 0.2.1 release

This release is only fixing issues with bad OEmbed responses which previously caused the entire exporting of the article to fail. Now it will render a message instead of the embedded element telling the viewer that the embedded element could not be loaded.

+1

+1


calfw grid does not extend to the whole buffer

I tried the =Calendar App. This is what it looks like for me:

Unfortunately the grid does not dynamically extend to the whole buffer, as would be expected from the vanilla version.
This also occurs if one does not use the calendar app, but instead only installs the calfw package.
It seems like some other package is messing with the layout here, any idea how to fix this?

Are you able to reproduce this in vanilla Emacs? Here's how you can easily test it (from GUI Emacs):

Open the vanilla sandbox (SPC h E or M-x doom/open-vanilla-sandbox)

Type in:
(require 'calfw)

Press C-c C-c to open the vanilla instance of Emacs

Open calfw

I have the opposite problem where the calendar is so big that part of the month is hidden. I tried with vanilla emacs and didn't have an issue there.

This is really confusing. If I follow the above steps, and the problem with the static grid persists.
I tried it yesterday without any doom, just a fresh new .emacs.d and getting calfw from melpa.
There the grid will adept to buffer size..

As of #1294, this has been resolved. Let me know if that isn't the case!
Thanks to @jscott22 for looking into this.


unsafe: add Add function

@mdempsky has a proposal from 2014  to add unsafe.Add, analogous to the existing (unexported) runtime function
func add(p unsafe.Pointer, x uintptr) unsafe.Pointer {
       return unsafe.Pointer(uintptr(p) + x)
}

#19367 is about adding unsafe.Slice, and #395 is about slice to array conversion. Doing unsafe.Add at the same time would be a good bundle so that people who want to clean up uses of unsafe can do it all at one time.
This issue is to propose unsafe.Add, probably as a function, but maybe as a method on Pointer? Matthew's doc discusses the tradeoffs there.

func (p Pointer) Add(offset uintptr) Pointer { ... }
?

@seebs The proposal mentions Sub at the bottom too.

In addition to unsafe.Add (or unsafe.Pointer.Add), I think it would also be worth considering adding some methods to package reflect like:
func (h *SliceHeader) DataPointer() unsafe.Pointer { return unsafe.Pointer(h.Data) }
func (h *SliceHeader) SetDataPointer(p unsafe.Pointer) { h.Data = uintptr(p) }

func (h *StringHeader) DataPointer() unsafe.Pointer { return unsafe.Pointer(h.Data) }
func (h *StringHeader) SetDataPointer(p unsafe.Pointer) { h.Data = uintptr(p) }

func (v Value) UnsafePointer() unsafe.Pointer { return unsafe.Pointer(v.Pointer()) }

If these methods were in place, we could issue vet warnings against using accessing Data directly or calling Value.Pointer or Value.Addr. unsafe.Pointer(v.UnsafeAddr()) can be rewritten to v.Addr().UnsafePointer(), but we could also add variant of UnsafeAddr that returns unsafe.Pointer directly too.
Together with unsafe.Add, I think this would eliminate any need for uintptr -> unsafe.Pointer conversions. For backwards compatibility, we'd still need to support them; but we'd at least be able to guide users towards less-error-prone solutions.
Historically, package reflect couldn't return unsafe.Pointer values directly, because of safe mode, which restricted use of unsafe.Pointer. But we removed safe mode in 2018, as we have better ways to sandbox untrusted Go programs nowadays and restricting use of unsafe.Pointer is intrusive upon the Go ecosystem.

Hmm. I sort of like that, but a concern would be that it's potentially wrong to set the data pointer without first setting len/cap appropriately, so if you have a SetDataPointer, but not the other parts, I feel like this will be a temptation to do unsafe things.
(And just a wild loose-end idea: Distinguish between runtime.Pointer and unsafe.Pointer, with runtime.Pointer only permitting/admitting known-safe operations, while unsafe.Pointer admits risky ones? Probably not useful, though.)

it's potentially wrong to set the data pointer without first setting len/cap appropriately

The order that you set data/len/cap don't matter as long as you set all of them before using the underlying string/slice again.
However, it's a fair point that maybe:
func (h *SliceHeader) Get() (data unsafe.Pointer, len, cap int)
func (h *SliceHeader) Set(data unsafe.Pointer, len, cap int)

func (h *StringHeader) Get() (data unsafe.Pointer, len int)
func (h *StringHeader) Set(data unsafe.Pointer, len int)

would be a useful abstraction instead or as well. In fact, I think abstracting away the fields into methods like this would address the long-term compatibility issues that "It cannot be used safely or portably and its representation may change in a later release." are meant to caveat. No matter the underlying representation, these methods could still work.
Though this also starts trending towards overlap with the earlier suggestions of #19367.

And just a wild loose-end idea: Distinguish between runtime.Pointer and unsafe.Pointer, with runtime.Pointer only permitting/admitting known-safe operations, while unsafe.Pointer admits risky ones?

Do you have any known-safe operations in mind that aren't already supported by interface{} or reflect.Value?

I saw a thing, somewhere, which said in passing that it was important to set len/cap to either 0 or the smaller of the values before setting data, or else you'd have an inconsistent state, but on consideration I can't see why it would matter unless something else was accessing the slice concurrently, which it presumably shouldn't be. I'm now trying to remember where I saw this, and what the rationale was.
As to known-safe: My vague idea was roughly that a runtime.Pointer might be a richer datatype, which also had information about known bounds, so it could reject or fail an Add() or a Sub() with invalid parameters, while unsafe.Pointer would assume you know what you're doing. This is probably a large and separate idea, and probably not a great idea, but I am a bit stream-of-consciousness some days. So, runtime.Pointer wouldn't imply genuine and complete knowledge of a pointer's real bounds, it would just be working from provenance; if you have a var a [7]int, and you get a runtime.Pointer to a[0], it's the address plus the knowledge that the bounds are [0,7*sizeof(int)], so it can detect/diagnose modifications.
I'm admittedly also coming up light on circumstances where you have enough information that this would be useful, but you also have any reason to use pointers and pointer arithmetic.

it was important to set len/cap to either 0 or the smaller of the values before setting data, or else you'd have an inconsistent state

Yeah, this at least isn't an issue under any existing Go implementation (to my knowledge). The Go runtime's GC only pays attention to the Data field; it doesn't care about the Len or Cap fields. And when it comes to concurrent access, you'll need to synchronize access to the entire slice/string value anyway, so the order you update individual fields doesn't matter. (Unless you're doing sequenced atomic stores of each field, but then you need matched atomic loads at access sites; at which point you're talking about an application-specific synchronization protocol, not a general Go coding pattern.)

My vague idea was roughly that a runtime.Pointer might be a richer datatype, which also had information about known bounds, so it could reject or fail an Add() or a Sub() with invalid parameters

I think you're describing reflect.Value. :)

I like the original proposal, so I'd also like to get the  func unsafe.Sub(p, q Pointer) uintptr, func unsafe.Less(p, q Pointer) uintptr, and func unsafe.IsSameVariable(p, q Pointer) bool as well, please :) . With all of them in place, pointer arithmetic will become a lot easier to do right in Go.

@beoran, while you might use unsafe.Add with the offsets you find in reflect information (particularly in StructField), I can't think of a corresponding time when you should ever use unsafe.Sub. Pointer arithmetic like in C is not safe, because you may construct an invalid pointer (C doesn't care, but Go does), nor is it a goal. Am I missing some typical use of subtracting pointers in Go? I've written plenty of unsafe code and can't remember ever doing that.
@mdempsky, we should probably start a separate discussion for the SliceHeader/StringHeader changes. It's unclear to me how much is left after unsafe.Slice is added. It's also unclear to me whether we should do new methods or just define better new types (with an unsafe.Pointer-typed field).

Other topics aside, the reception to adding unsafe.Add seems overwhelmingly positive on the reactions, with no objections in the text here.
This seems like a likely accept.
(Not trying to cut off the discussion of other changes - we can certainly discuss them separately.)

I can think of a case where I would want a thing that I would call subtraction. I don't think it's quite applicable, but I'll post it in case it reminds someone of a thing that would be relevant:
The one case I've seen for pointer subtraction in C is not actually probably defined behavior there, but "everyone knows it has to work", and that is that if you know that an object is in fact a field of a struct, you can take a pointer to the object and go back to a pointer to the containing structure, using its offset. (And in C, the pointer to the inner object is allowed to "know" that it is a pointer to that specific object, rather than a pointer to the containing object, and thus have narrower bounds. I think. If you got three or four committee members together and gave them drinks they could probably give you at least two credible answers.)
The use case for this is, for instance, to have one or more linked-list data structures threaded through structures, and you can iterate over the lists using code that only knows about the list structure, and then go back to the containing parent structure, so you can have generic list-management code working on lists that are actually part of larger objects, and this is sometimes convenient.
But... while that's "subtracting" in arithmetic terms, it's not subtracting in type terms, it's adding a negative offset.
I can't actually think of a use case for pointer.Sub(pointer) -> offset that I can't do better some other way. I thought of it for the same reason that Time.Add(Duration) -> Time sort of implies Time.Sub(Time) -> Duration, but while subtracting times is common, I can't actually think of much of a use for subtracting pointers, in general. I guess as a way to compute OffsetOf, except that I think any time I'd want that, I would be able to do it with Reflect or with OffsetOf or ... basically, yeah, I can't think of anything.

Considering it more, with what @seebs is saying, I think that it's true that substracting pointers as such is useless. However, a func unsafe.Containing(p Pointer, offset uintptr) Pointer for use in conjunction with unsafe.Offsetof to go from a pointer to a struct member to the containing struct would be quite useful, for C interoperability, and  low level internal linked lists. Shall we split this off in a separate issue or keep it here?

@beoran You can use unsafe.Add(p, -n) to subtract an offset from a pointer.
Caveat: If n is a constant, you'll hit issues with not allowing negative values of type uintptr. This can be circumvented either by first assigning it to a local variable, or using unsafe.Add(p, ^n + 1).

@beoran I think unsafe.Contains is more controversial than unsafe.Add, so, yes, I think that that should be a separate proposal.  (I'll note that I don't understand how it could be implemented, so I must misunderstand what it means.)

I think @beoran's proposed unsafe.Containing(p, x) is essentially just unsafe.Add(p, -x). I understand the name as "return a pointer to the containing structure where p is at offset x". But I'll defer to them if I've misunderstood.

Yes, it is as @mdempsky says. If the implementation of unsafe.Add will allow unsafe.Add(p, -x) with a negative offset, then that is sufficient for my purposes, and no unsafe.Containing will be needed.

Still a likely accept. Waiting on #395.

Arguably in the same family of operations is the ability to obtain a memory offset for indexed items in a slice or array (#12445). Could this be considered in package of additions (or nearby)?

@kortschak I created #41049 for that suggestion. Thanks.

We started looking at this because of the unsafe conversion issues, but this is not a conversion and is mostly unrelated to those. The outcome for those seems unclear still, but this one can probably be separated from them.
This was already a likely accept, and there's been no change in consensus. Accepted.

@rsc; May I volunteer to send a CL? I would like to gain some more experience in committing to the Go project in my spare time.
To check if I understand correctly:

This issue (and subsequent CL) is only about the Add method on the unsafe.Pointer type. Will other changes that where discussed here be done separately?
The method will return a new intsance of unsafe.Pointer, the instance of pointer on which the method Add is called remains unchanged.

@muhlemmer Package unsafe is not a normal Go package written in Go source files - it is a special concept implemented entirely in the compiler. While contributions are welcome, if you don't have any experience in the compiler, it is likely to take a while to get up to speed, and you might not want to spend that time unless you expect to work more in the compiler in the future.
I've also clarified above that the accepted proposal is for a top-level function unsafe.Add, not a method on Pointer.

Thanks for the warning. I've been looking around, but I'm afraid this is yet out my reach. Or at least, it might take quite some time until I get my head around this. It is probably best if someone with experience does this.

@muhlemmer
Mathew worked on this recently and livestreamed as he did so.
https://www.twitch.tv/videos/758956772?t=0h41m26s (Starts at around the 41st minute mark).
apologies for spamming the thread; but I thought you might be interested having expressed interest in working on this. I found the session quite helpful for someone who has never contributed to the compiler.

@mdempsky, I didn't watch that whole video, but are you targeting Go 1.16 for this?

@bradfitz I had 1.16 in mind, but Russ milestoned #19367 for Go 1.17, so I assumed this was too and haven't prioritized working on either of them further for 1.16. I think they're both still feasible to get in for 1.16 though.

I hadn't remembered this but yeah they probably should all go out together as part of a coherent update to unsafe. Thanks for implementing, and let's save for Go 1.17.

This is done.

Was there a reason why Add is defined as to take in a regular unsafe.Pointer and not *unsafe.ArbitraryType, like so?
func Add(ptr *ArbitraryType, len IntegerType) *ArbitraryType

I think Add being type-aware would make writing Cgo code a lot easier, since there wouldn't be a need for C.sizeof_ anymore.

Maybe func Add(ptr *ArbitraryType, len IntegerType) *Pointer is better trade-off, for the input and return pointer types often not same.

Was there a reason why Add is defined as to take in a regular unsafe.Pointer and not *unsafe.ArbitraryType, like so?

I wasn't convinced it's needed, and we can extend it to support this later.
Are you sure unsafe.Slice wouldn't be a better fit for your needs? E.g., &unsafe.Slice(p, n+1)[n] has the same semantics as you're asking for (assuming n >= 0).

@go101, an Add on *ArbitraryType seems somewhat ambiguous to me. In C, pointer addition depends on the alignment of the pointed-to type, but we don't currently have an alignment-dependent addition operator in Go.
Would unsafe.Add[T ArbitraryType, Int IntegerType](ptr *T, n Int) *T add n * unsafe.Alignof(*ptr) to the address, or just n? Restricting Add to unsafe.Pointer sidesteps that question, since unsafe.Pointer does not connote any particular alignment.


Add a few more sample action handlers

Add action handlers for:

cortex-firmware
PNG image splash screen

@lucas-tdx ping


Add bucket name validation to S3 calls

Fixes boto/boto3#181
Based on:
http://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html#non-dns-compliant-bucketname-challenges
cc @kyleknap @mtdowling @rayluo

I just had a question about how your checking the string, but other than that, looks good.

@mtdowling Feedback incorporated.  I think the error message is still pretty reasonable:
session.create_client('s3').list_objects(Bucket='nota/valid/bucket')
Invalid bucket name "nota/valid/bucket": Bucket name must match the regex "^[a-zA-Z0-9.\-_]{1,255}$"

:ship:


Smooth Scroll

What feature or improvement do you think would benefit Files?
Hi guys, please make the built-in SmoothScroll support like Chrome.
Why is that? So that my eyes don't hurt/get tired, I have a 144 Hz monitor, and I use "Files" almost every day to view pictures, but even 144Hz doesn't help when I flip through pictures.
Scrolling happens based on their WIndows settings, but it would be great if someone integrated smooth scrolling.
I must admit, the Files application made it much easier for me to view and filter images thanks to tags, thanks to all the development participants.
The "NOT" filter is still missing, when I want to see all the pictures that are not marked with the "Work" tag, I did not find such a function.
Thank you!
Requirements

This proposal will accomplish X
This proposal will accomplish Y
This proposal will accomplish Z

Files Version
<IP_ADDRESS>
Windows Version

2H24

Comments
No response

I know that there is a "smooth scrolling" in WIndows itself, but this is not enough when the images are zoomed to the maximum and there are jerks when scrolling.
I would like to get the same smoothness as Chrome with the enabled feature - chrome://flags/#smooth-scrolling

Thank you for your feedback, Files already has smooth scroll so it's likely this is a framerate issue with WinUI. I recommend adding your feedback on the WinUI repo so Microsoft can take it into account and hopefully fix it in a future version.
https://github.com/microsoft/microsoft-ui-xaml/issues/7373

Just to add on, you're not alone with this issue. Other users with high refresh rates have made similar comments but the improvements need to come from Microsoft.


Adding Kwai as hard.

Adding Kwai and putting Netflix and TikTok as a popular sites.

Those sites certainly are popular. Thank you for noticing!


Better support for multiple wallets

Describe the request
Machinaris supports adding multiple mnemonic files into the config but doesn't have any capability for selecting which wallet to work with when running commands such as joining pools.
This results in having to temporarily remove the mnemonic you don't want to work with when making changes. Additionally it results in the tool not being able to sync the secondary wallet.
You are able to copy in sync files from another client for your secondary wallet but even after doing so it will not show you both wallets in the wallets tab despite both fingerprints showing in the keys tab.
Images

Additional comments

So my system will not even show my pool wallets at all. Haven't been able to figure out why. Pool wallets show up fine on my windows machines with the same Key.

All my pools are telling me I've reported nothing since switching to machinaris.  Which logs in particular would be helpful?  Both my MacBooks are setup as full nodes, but both report issues communicating with the harvester?  Shouldn't that be reallly unlikely using machinaris as a full node?

All my pools are telling me I've reported nothing since switching to machinaris. Which logs in particular would be helpful? Both my MacBooks are setup as full nodes, but both report issues communicating with the harvester? Shouldn't that be reallly unlikely using machinaris as a full node?

Hi!  I would recommend only a single Machinaris controller/fullnode on your LAN.  Not sure how well two will work if they are both port-forwarded to your router.  The benefit of a single controller is a single WebUI to control your entire farm.
Once you have a single Machinaris fullnode/controller, visit the Workers page, click the New button to generate a Docker run/compose for your harvesters and/or plotters.  For harvesters, don't forget to manually copy the SSL certs over from your fullnode.
To troubleshoot issues, check the Workers page on the fullnode.  Also check the logs on the harvester, particularly at ~/.machinaris/mainet/log/debug.log.  Finally, ensure that port tcp/8447 is reachable on your controller as that is required for the harvester to connect.

Closing as this has been improved with latest version v0.5.2.  Thanks for the feedback!


#17: Remove docker stuff.

Fixes #17

Codecov Report

Merging #18 (87920c9) into main (5a0456d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           97        97
=========================================
  Hits            97        97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0456d...87920c9. Read the comment docs.


Update to 5.4

Updated project to 5.4

Did this require any blueprint changes to compile in 5.4? I think when I tested it in 5.1 it worked without any issues, so I'm inclined to keep the main branch at 4.25 to keep the broadest compatability.
I think an update to 5.4 would need to switch to enhanced input and use some of the new features, but at that point I'd probably rewrite the whole thing because there's a few janky things in this project that I'm no longer happy with.

No blueprint changes at all the engine just upgraded it when I ran it, It does make sense to keep it at 4.25 so people can just upgrade to their own version.


Desktop - Assign task - Infinite loading in the contact list when force reloading the app

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/22982
Action Performed:

Open the testing app
Click on FAB > Assign task
Enter the title, description and go to the next step
Click on Assignee
Force reload the app

Expected Result:
Contact list to load correctly without issues
Actual Result:
Contact list infinitely load after a force reload of the app
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.45-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/dc7ca854-0ed9-4691-ba47-40014d8acbfd
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

@dukenv0307 I am not sure I follow here it seems Applause was able to repro in staging

@mountiny Unable to reproduce it on build <IP_ADDRESS>
https://github.com/Expensify/App/assets/93399543/fb407da2-9b56-4c98-a1f4-41fabff489e1

@dukenv0307 @mountiny  It is reproducible, we have to force reload the webpage (Ctrl + Shift + R). Force reloading (also called Hard reloading) clears the cache before reloading the page.

@thienlnam gonna let you handle this one and decide if to solve this, feels quite edge casey

Yeah I don't really think we need to address this, let's keep it closed


Introduce glslangValidator

Consider changing shaders naming convention to be compliant with reference khronos compiler.
https://www.khronos.org/opengles/sdk/tools/Reference-Compiler/

To my knowledge, there is nothing about shader naming convention in specification, thus changing issue title. It could be good enhancement introducing more tools to validate source code


Custom accent color

The readme says:

You can choose any color as your "accent" color.

I think what the author meant to say was that you can choose any color from the Catppuccin palette as your accent color. Instead, it says that you can simply choose 'any color'. This is definitely not the case; it's clear from trying it that this doesn't work, and it's clear from the code that this doesn't work.
But I think I would like it to work. I want to use an accent color that isn't one of the options from the palette, and I would be happy to override the accent color in the same way that I'm overriding named colors such as base and mantle. From the code, it's clear that accent is not a named color, but a variable that holds a named color. This strikes me less as an intentional design choice and more as an inadvertent limitation of the current implementation. Given that the theme explicitly allows colors to be overridden, it seems odd and contradictory that the scope for customizing the accent color is so limited. At the very least, I think the documentation should be clarified.
See also #410

Can you not set the accent color to say pink and then use colorOverrides to change it to a custom hex?

I already thought of that. The problem is that I don't know which of the palette colors are being used for syntax highlighting. My uninformed guess would be that they probably all are, and I have no desire to mess with the syntax highlighting. If there is a named color in the palette that is definitely not being used, then I guess would work, but even so it certainly seems less than ideal.

Hey @mattlucock 👋,

This strikes me less as an intentional design choice and more as an inadvertent limitation of the current implementation. Given that the theme explicitly allows colors to be overridden, it seems odd and contradictory that the scope for customizing the accent color is so limited.

We're all for customisation but I'd argue that it was an intentional or even implicit design choice as we don't expose that type of customisation API by defualt for any of our other 300+ repositories in the organisation.
I'm willing to explore the idea of allowing the accent colour to be anything but I'm also wary at the same time of the extra complexity that it would add to the surface API. In the short term, I think it would be fine/trivial to add support for a custom hex code or the full palette as mentioned in #410 since that wouldn't be a breaking change.
However, I can forsee that the introduction of a custom accent hex code will most likely bring about a future feature request where people want to have different accents per flavour, probably leading to a more complex API as shown below:
"catppuccin.accentColor": {
  "all": "red", // Named accent colour
  "latte": "#000000", // Custom hex code
  "mocha": "crust" // Named monochromatic colour
  // Frappe & Macchiato would default to "red" as specified in "all"
},

Changing it to something like the above would be a breaking change and, at the moment, it's something that I wouldn't want to introduce into the plugin. Of course, that may change but just speaking from my current state of mind. Especially in a codebase that unfortunately doesn't have any unit or integration tests (yet 🤞)
With all that being said, I think it would be fine to allow a custom hex code to be the accent colour since it should be trivial. There might also be a larger discussion on whether or not we should in the first place.

At the very least, I think the documentation should be clarified.

Agreed, I'll make a PR clarifying this since it's technically true with the colorOverrides, but as you said, it would impact syntax highlighting as well.

i'm concerned that the effort required to implement this properly isn't justified by its utility. we would certainly need to support different accents per flavour as a single colour for all four is not going to look good, and if we didn't implement it at first i can guarantee an issue will be raised for it in future.
i am not personally willing to make a breaking change for the catppuccin.accentColor setting, if we were to make a change here it would have to be backwards compatible. breaking everyone's configs for this feature is not acceptable to me.
i will put some thoughts here for a potential design that i would consider accepting a PR for:
"catppuccin.accentColor": "custom",
"catppuccin.customAccentColors": {
    "all": "#FFFFFF",
    "latte": "#000000"
}

i'm currently leaning towards not wanting this, but if someone were to implement it and request a review from me, i would give it a second thought.


gb build missing dependencies's vendor dir

I work on a project named ProjectA with gb. It dependent on example.com/ProjectB. ProjectB also has some dependencies (exp.: example.com/ProjectC and example.com/ProjectD) stored in <ProjectB dir>/vendor. I fetch ProjectB:
gb vendor fetch -no-recurse example.com/ProjectB

then, the tree is:
ProjectA
|- src
|- vendor
   |- src
      |- example.com
         |- ProjectB
            |- vendor
               |- example.com
                  |- ProjectC
                  |- ProjectD

I build ProjectA use gb build, and get:
FATAL: command "build" failed: failed to resolve import path "abc": import "example.com/ProjectC": not found

So, I guess gb build missing dependencies's vendor dir. btw: GO15VENDOREXPERIMENT=1 in my environment.

It looks like project B is using the go tools vendor support.
You have a few choices,

Don't use the -no-recurse flag, and let gb vendor fetch projectB's dependencies from upstream
Use gb vendor fetch to fetch each of projectBs dependencies explicitly.
Move the contents of projectBs vendor directory to $PROJECT/vendor/src

On 3 Feb 2016, at 14:40, Robert Hao<EMAIL_ADDRESS>wrote:
I work on a project named ProjectA with gb. It dependent on example.com/ProjectB. ProjectB also has some dependencies (exp.: example.com/ProjectC and example.com/ProjectD) stored in /vendor. I fetch ProjectB:
gb vendor fetch -no-recurse example.com/ProjectB
then, the tree is:
ProjectA
|- src
|- vendor
|- src
|- example.com
|- ProjectB
|- vendor
|- example.com
|- ProjectC
|- ProjectD
I build ProjectA use gb build, and get:
FATAL: command "build" failed: failed to resolve import path "abc": import "example.com/ProjectC": not found
So, I guess gb build missing dependencies's vendor dir.
—
Reply to this email directly or view it on GitHub.

@davecheney Could you make gb build recognize ProjectB/vendor ?

No, I have no plans to implement that feature.
https://getgb.io/faq/#govendorexperiment
On Wed, Feb 3, 2016 at 2:58 PM, Robert Hao<EMAIL_ADDRESS>wrote:

@davecheney https://github.com/davecheney Could you make gb build
recognize ProjectB/vendor ?
—
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/561#issuecomment-178989220.

@davecheney OK, but it's really make a obstacle.

Just want to add a comment that not only does this make things a bit more difficult, but in a few cases I have seen:

not vendoring the latest upstream version (eg. pinned to older version) of a dependency
modifications to a vendored library not present in the upstream versions.

In both cases, the end result is subtle brokenness/bugginess.
At the very least the below recommendation to fetch a fresh copy of a library, made on the linked page, may end up proving problematic for people.

To resolve these ignored dependencies, you can either copy them from each dependency’s vendor/ folder..., or vendor a fresh copy with gb vendor fetch.The latter is the recommended process so the dependencies’ location is recorded in the gb vendor manifest file.

SGTM. Patches welcome, https://github.com/constabulary/getgb.io
On Fri, Mar 25, 2016 at 8:17 AM, eli<EMAIL_ADDRESS>wrote:

Just want to add a comment that not only does this make things a bit more
difficult, but in a few cases I have seen:

not vendoring the latest upstream version (eg. pinned to older
version) of a dependency
modifications to a vendored library not present in the upstream
versions.

In both cases, the end result is subtle brokenness/bugginess.
At the very least the below recommendation to fetch a fresh copy of a
library, made on the linked page, may end up proving problematic for people.
To resolve these ignored dependencies, you can either copy them from each
dependency’s vendor/ folder..., or vendor a fresh copy with gb vendor
fetch.The latter is the recommended process so the dependencies’ location
is recorded in the gb vendor manifest file.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/constabulary/gb/issues/561#issuecomment-201023816


 I'd like to turn all led's off since the antenna is in a cupboard anyway so it just wastes power. I couldn't really find it in the documentation and I already killed one board by mistake.

did you try the configuration disable_led: true under serial in the configuration?
https://www.zigbee2mqtt.io/information/configuration.html
otherwise, who cares. an LED will draw maybe  a couple mA of power on a powered device.


Emergency Form Modification and added CSS to it

Hey Coder @Tejas-Dalvi-99 , kindly review my PR. I have made the following changes :-

Modified Emergency Form to add some more fields.
Added lots of CSS to make the page beautiful.

We have decided to keep it simple and Classic, Could you please make a Simple UI ( CSS ) for the form . and we don't need the dark theme

Okay I will do the same and PR again.
Thanks & Regards.
On Wed, 5 Oct 2022, 22:52 Tejas Dalvi, @.***> wrote:

We have decided to keep it simple and Classic, Could you please make a
Simple UI ( CSS ) for the form . and we don't need the dark theme
—
Reply to this email directly, view it on GitHub
https://github.com/Tejas-Dalvi-99/Help-Me/pull/21#issuecomment-1268717924,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXTP43DG3MKAQ6MNSQR4W5LWBW2NZANCNFSM6AAAAAAQ5TJ7AI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hey @nik-agarwal12 The Contributers Codes Folder have been Removed, So just Change the path of Emergency form.html by removing the Contributers Codes in the path in file Name and make The PR . The path should look like this :-  Help-Me / Emergency Form.html .

Still it is having conflicts with Main Branch please check


[backport] Avoid cuDNN handle around DropoutStates

Backport of #5563

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit af3fc1599d91df0b660d0f692355c57bc512bb3f, target branch v5) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Needs https://github.com/cupy/cupy/pull/1734 backported.

Jenkins, test this please.

Jenkins CI test (for commit af3fc1599d91df0b660d0f692355c57bc512bb3f, target branch v5) succeeded!

LGTM!


Module 'App::Daemon' is not installed

hi.
root@AR:/usr/local# git clone https://github.com/jmacdotorg/plerd plerd-site
root@AR:/usr/local#  cd plerd-site
root@AR:/usr/local/plerd-site# curl -fsSL https://cpanmin.us | perl - --installdeps .
it shows:
...
Successfully installed Moose-2.2004
! Installing the dependencies failed: Module 'App::Daemon' is not installed
! Bailing out the installation for ..
89 distributions installed
root@AR:/usr/local/plerd-site#
how to fix it?

Is there any error or logging information behind that "..." which might have clues as to why App::Daemon did not install?
What happens if you try to install App::Daemon manually? (e.g. via "cpanm App::Daemon", or interactively via the "cpan" program)?

App::Daemon installs cleanly on a new latest-version Perl for me, and no further comment from the OP, so I'm closing this as unactionable.


Question: vSphere Cloud Provider storage

Hi,
The documentation mentions Google Cloud Storage, Amazon S3, and Microsoft Azure Blob Storage.
Am I correct in assuming VCP storage would work as well?

@dkirrane I'm not too familiar with it. Is VCP block level storage or file level storage? Assuming it is file level, you can use the ChartMuseum --storage="local" option.

Thanks I'll try local.
What would the command be for the Docker image?
docker run --rm -it \
  -p 8080:8080 \
  -e PORT=8080 \
  -e DEBUG=1 \
  -e STORAGE="local" \
  -e STORAGE_LOCAL_ROOTDIR="C:/HelmCharts" \
  -v C:/HelmCharts:/root/???? \
  chartmuseum/chartmuseum:latest

@dkirrane, yes very close, the container dir for the volume must match
STORAGE_LOCAL_ROOTDIR, and should be a Linux path.
So something like
docker run --rm -it
-p 8080:8080
-e PORT=8080
-e DEBUG=1
-e STORAGE="local"
-e STORAGE_LOCAL_ROOTDIR="/charts"
-v C:/HelmCharts:/charts
chartmuseum/chartmuseum:latest
On Thu, Feb 22, 2018 at 11:16 AM dkirrane<EMAIL_ADDRESS>wrote:

Thanks I'll try local.
What would the command be for the Docker image?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-helm/chartmuseum/issues/52#issuecomment-367789282,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYBFrqD3_gAvyQZISDkBlcF4xlA6rUJks5tXbzqgaJpZM4SPLz7
.


CLI processes do not terminate on exit on MacOS Darwin

I checked out issues #18385 #24962 #62040 with #62040 mentioning that the issue is gone after October update. I am still able to reproduce this issue with other processes. (The node process is the only process that gets terminated)

VS Code version: Code 1.36.1 (2213894, 2019-07-08T22:56:38.504Z)
OS version: Darwin x64 18.6.0

Steps to Reproduce:

open integrated terminal
run any process like redis-server or mongod
close vscode
try running redis-server or mongod or same process in terminal, it'll say port already in use. check running processes, process is running

Does this issue occur when all extensions are disabled?: Yes

@Tyriar if no one is working on this, I'd like to, if you can point me in the right direction.

@aaayushsingh I'm pretty stumped as to why this would only happen. It needs verification that it's not actually a problem with redis-server/mongod first.
This is where terminal processes/ptys are teared down: https://github.com/microsoft/vscode/blob/e0762af258c0b20320ed03f3871a41967acc4421/src/vs/workbench/contrib/terminal/node/terminalProcess.ts#L168-L197
And this is the lib that manages the ptys https://github.com/microsoft/node-pty

@Tyriar They do not terminate with regular terminal either. Just checked


Dont pool IovArray but just allocate on the fly

Motivation:
Pooling and re-using IovArray works for now but is not safe in its
current form once SQPOLL is used as we can not assume we can re-use the
IovArray once we called submit.
Modifications:
Just allocate the IovArray on the fly when needed by using the
ByteBufAllocator
Result:
Code is safe even with SQPOLL

@1Jo1 for now I don't see any perf drop with it... lets keep it simple for now

@njhill thats right ...addressed your comments as well


Change systick priority so it's not preemptable

Need to check if it fixes the problem with the clock running late.


⚠ Adacta-fintech.com has degraded performance

In 961dfa0, Adacta-fintech.com (https://www.adacta-fintech.com) experienced degraded performance:

HTTP code: 502
Response time: 550 ms

Resolved: Adacta-fintech.com performance has improved in db31924 after 10 minutes.


Automated cherry pick of #9202: Bugfix/tb bugfix 1204

Cherry pick of #9202 on release/3.6.
#9202: Bugfix/tb bugfix 1204

Codecov Report

Merging #9203 (133ba01) into release/3.6 (b9d30c0) will increase coverage by 10.98%.
The diff coverage is 8.77%.

@@               Coverage Diff                @@
##           release/3.6    #9203       +/-   ##
================================================
+ Coverage         5.86%   16.85%   +10.98%
================================================
  Files              828       85      -743
  Lines           129133     8900   -120233
================================================
- Hits              7577     1500     -6077
+ Misses          120876     7268   -113608
+ Partials           680      132      -548

Flag
Coverage Δ

aFlag
16.85% <8.77%> (+10.98%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/monitor/alerting/conditions/nodataquery.go
0.99% <0.00%> (ø)

pkg/monitor/alerting/conditions/suggestquery.go
2.00% <2.00%> (ø)

pkg/mcclient/modules/monitor/suggestsysrule.go
100.00% <100.00%> (ø)

pkg/util/ansible/playbook.go

pkg/monitor/models/alertnotification.go

pkg/mcclient/options/dbinstances.go

pkg/compute/models/managedresource.go

pkg/compute/models/dns_trafficpolicy.go

pkg/multicloud/esxi/utils.go

... and 678 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43522bb...133ba01. Read the comment docs.


Write generated AssemblyAttributes file to intermediate output path

Fixes https://github.com/microsoft/msbuild/issues/1479 as suggested in the issue description.

@rainersigwald PTAL

Can you explain why the old file location is a problem after dotnet/roslyn#39136?
The test is failing on Mac and Linux with
/home/vsts/work/1/s/artifacts/bin/Microsoft.Build.Tasks.UnitTests/Debug/netcoreapp2.1/Microsoft.Common.CurrentVersion.targets(1177,5):  error MSB3644: The reference assemblies for .NETFramework,Version=v4.0 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

I'm ok with conditionalizing the test to run only on Windows with a comment that it depends on .NET 4 targeting.

Can you explain why the old file location is a problem after dotnet/roslyn#39136?

The file does not contain source for any method bodies it used to be not included in the document table in the PDB. With dotnet/roslyn#39136 the file is included in the PDB, which leads to more issues. For example, a deterministic build won't normalize random paths outside of the repo root, path to %temp% directory leaks the user name, etc.

@rainersigwald The test now runs on Windows only.


model weights without pretraining

Hi @linjieli222,
Nice work! I has a question about model weights without pretraining. In the paper it says model parameters (w/o pretraining) are initialized with RoBERTa weights. As RoBERTa has 12 layers and HERO as 6/3 layers, I wonder the weights of which layers are loaded in cross-modal Transformer and Temporal Transformer?
Thanks.

We only load the RoBERTa weights to the 6-layer Cross Modal Transformer. The 3-layer Temporal Transformer are randomly initialized. Please refer to https://github.com/linjieli222/HERO/blob/1534356a7e3edc5258ff63850952929fbb2b1569/model/modeling_utils.py#L46 for more details.

We only load the RoBERTa weights to the 6-layer Cross Modal Transformer. The 3-layer Temporal Transformer are randomly initialized. Please refer to https://github.com/linjieli222/HERO/blob/1534356a7e3edc5258ff63850952929fbb2b1569/model/modeling_utils.py#L46 for more details.


Issue: Can't select steps properly

https://github.com/user-attachments/assets/4115a107-7165-40f0-8ab0-c85aed2e315a

Fixed with 9f4c2ef


bump version and update changelog for 1.1.7

What
bump version and update changelog for 1.1.7
Why
releasing 1.1.7 for https://stellarorg.atlassian.net/browse/SDP-1161
Checklist
PR Structure

[x] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR title and description are clear enough for anyone to review it.
[x] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

[x] This PR adds tests for the new functionality or fixes.
[x] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[x] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[x] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[x] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[x] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[x] This is not a breaking change.
[x] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[ ] Does the deployment work after merging?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr273.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr273.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr273.previews.kube001.services.stellar-ops.com


Add support for dynamic clients

BAML functions now support passing in which model / configuration they use at runtime.

Enables dynamically picking which options they want to run.
Tracing captures dynamic properties
Retry policies must be defined in BAML

Do you have any idea of when this will be merged? We are eagerly awaiting for this release to for some use cases regarding custom headers and params for openai API calls.

Do you have any idea of when this will be merged? We are eagerly awaiting for this release for some use cases regarding custom headers and params for openai API calls.

Sorry about the delay! we had some tests i was running on this! I'll aim to merge this in today.
For headers and custom paramters, you can also do it via .baml files directly if you want see: https://docs.boundaryml.com/docs/snippets/clients/providers/openai#non-forwarded-options
The custom headers field. Would that work?

@accupham we've finally merged this! you can expect this to land in our release tmrw or thursday!


FIX: change c includes to account for upstream changes

https://github.com/python/cpython/pull/28968 / 8e5de40f90476249e9a2e5ef135143b5c6a0b512 which is part of implementing https://bugs.python.org/issue35134 moved the header "longintrepr.h" into a sub-folder.  The notes on this change suggested to include "Python.h" instead.

Thanks.

0.29.x: https://github.com/cython/cython/commit/0f7bd0d1b159d085f321cc32a3f6ade24844e545

What is the workaround?

What is the workaround?

The best "work-around" is probably to use the latest Cython releases.

@l1x This due to a change to CPython to no longer include that header.  If you are feeling particularly bloody minded I guess you could put an empty file with the right name someplace that the compiler will see but that seems like a Bad Idea™ .
The best fix is to update the version of cython you are using and re-cythonize your source.

I am still getting this issue
/anaconda3/envs/tts/include -arch arm64 -fPIC -O2 -isystem /Users/dnabanita7/anaconda3/envs/tts/include -arch arm64 -I /opt/homebrew/opt/protobuf/include -I/usr/local/include/ -I/private/var/folders/_m/4y30kv853fg5mxzh8574czq80000gn/T/pip-install-n4rd5tst/pycld3_2ddc0107d9c54442a6fb7aa615689cd3/src/ -I/private/var/folders/_m/4y30kv853fg5mxzh8574czq80000gn/T/pip-install-n4rd5tst/pycld3_2ddc0107d9c54442a6fb7aa615689cd3/src/cld_3/protos/ -I/Users/dnabanita7/anaconda3/envs/tts/include/python3.11 -c cld3/pycld3.cpp -o build/temp.macosx-11.0-arm64-cpython-311/cld3/pycld3.o -std=c++11 -stdlib=libc++
      cld3/pycld3.cpp:250:12: fatal error: 'longintrepr.h' file not found
        #include "longintrepr.h"
                 ^~~~~~~~~~~~~~~
      1 error generated.
      error: command '/opt/homebrew/opt/llvm/bin/clang' failed with exit code 1

I can't update cython version as its not compatible with coqui-tts. Also upgrading cython version to 3.0.0 doesn't woek either. I am using ventura osx m2 chip.

I can't update cython version as its not compatible with coqui-tts

Then you're stuck and there is no possible solution that lets you use Python 3.11.
I suggest you use Python 3.10 or earlier.

yea, changed back it to 3.10. It's working fine. Thanks!
On Thu, Aug 17, 2023 at 12:24 PM da-woods @.***> wrote:

I can't update cython version as its not compatible with coqui-tts
Then you're stuck and there is no possible solution that lets you use
Python 3.11.
I suggest you use Python 3.10 or earlier.
—
Reply to this email directly, view it on GitHub
https://github.com/cython/cython/pull/4428#issuecomment-1682593857, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHQZX5ZYED5SWSQFBXZ7DRDXVZASFANCNFSM5GY3SCJQ
.
You are receiving this because you commented.Message ID:
@.***>

--
nabanita

still have this issue


C-SPC causes hang

Using origin/master, latest commit is 4fb7801ba3515922e3dbb8b27c1c28ec2efaf22b.
In an emacs buffer, setting a mark (C-@ or C-SPC) causes alacritty to hang. The emacs child process is healthy but doesn't receive any other signals and the screen doesn't update.
Subsequent to the hang, alacritty begins using all of one core.  MacOS "samples" attached of both emacs and alacritty.
Sample of alacritty.txt
Sample of emacs-25.1.txt

I had filed an issue about the cocoa event loop in glutin going to 100% CPU and blocking Alacritty. Need to reopen that on winit.
Does your description reliably reproduce the problem?

Yes, I made sure it was repeatable before I filed the bug.

Can confirm. In nvim, I have a binding on Ctrl+Space to clear hlsearch which also causes Alacritty to hang:
if maparg('<C-Space>', 'n') ==# ''
  nnoremap <silent> <C-Space> :nohlsearch<CR><C-L>
endif

In a new terminal running just bash, invoking C-SPC causes the hang.  No emacs or nvim required. Thanks for the confirmation!

I think this may be related to https://github.com/jwilm/alacritty/issues/264

Duplicate of #99.


feat: Implement the UI of the Quiz App

This commit includes the implementation of the user interface (UI) for the Quiz App. It encompasses the design, layout, and visual components necessary to provide a seamless and engaging user experience when using the application.

@SAGARSINGH-1 can i work on this issue


Access control

Now that market participants have to identify themselves upon logging into the trading system, an authentication and authorization mechanism can be implemented.

Any ideas how you willing to implement this?
Maybe I can help you if you are interested.

I think I can help you to implement this, you can tell me how to do it .


improve focus example

Part of #130459. Adds a test to the second focus example and makes the function of the example more clear.
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is test-exempt.
[X] I followed the breaking change policy and added Data Driven Fixes where supported.
[X] All existing and new tests are passing.

Welcome
On Wed, 1 May 2024, 3:27 am Justin McCandless, @.***>
wrote:

@.**** approved this pull request.
LGTM with nits 👍
Thanks for helping to test these examples!
In examples/api/test/widgets/focus_scope/focus.1_test.dart
https://github.com/flutter/flutter/pull/147464#discussion_r1585609112:

+import 'package:flutter_api_samples/widgets/focus_scope/focus.1.dart'

as example;
+import 'package:flutter_test/flutter_test.dart';

+void main() {

testWidgets('FocusableText shows content and color depending on focus',

     (WidgetTester tester) async {

await tester.pumpWidget(const MaterialApp(

 home: Scaffold(

   body: example.FocusableText(

     'Item 0',

     autofocus: false,

   ),

 ),

));
// Autofocus needs to check no other node in the [FocusScope] is focused and

Super nit for readability: "needs to check no" => "needs to check that no"
In examples/api/test/widgets/focus_scope/focus.1_test.dart
https://github.com/flutter/flutter/pull/147464#discussion_r1585609479:

});

testWidgets('builds list showcasing focus traversal',

Needs a newline here between the tests.
—
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/pull/147464#pullrequestreview-2032682577,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BH7GFSCGO5HQ3KUHJYER533ZAALFLAVCNFSM6AAAAABG4DJH6KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZSGY4DENJXG4
.
You are receiving this because you commented.Message ID:
@.***>

Can someone rerun Google testing?

Can someone rerun Google testing?

Done, but it looks like there are merge conflicts anyhow.


Support annotations

Put annotations in properties named annotation.<timestamp>, so that individual annotations can be added and removed in single operations.
Add annotate and deannotate commands,

Is this still planned? I can see this in task.rs, but the purpose of it is still a little unclear:
#[derive(Debug, PartialEq)]
pub struct Annotation {
    pub entry: Timestamp,
    pub description: String,
}

It's still planned, but not completed.
The use-case is
ta add make dentist appointment
...
ta 13 annotate -- "called and left message with answering service"
...
ta 13 annotate -- "answering service says to call M-W before 3pm"

etc. to build up a list of timestamped notes on a particular task.

The use case is fabulous! Would you like to target it as a part of a certain milestone?

What about ta note 123 Thing instead of annotate? Less typing!


Make balanced memory able to work with non continguous GPUs ids

This small PR allow one to use both DP and PP for fast inference of large models on larger nodes.
Here is how this can be done on a 8 GPUs with a model which requires 2 GPUs to be loaded:

run accelerate with 4 processes => GPU 0, 1, 2, 3 will have a process with DP
setup max_memory on each process to use the first GPU + a second GPU in the remaining four GPUs (4, 5, 6, 7)

To be able to do that with the current transformers/accelerate we only need to make sure get_balanced_memory can handle non contiguous list of GPUs which this PR does.
Here is a working examples of doing DP=4 + PP=2 for Falcon 40B on a node with 8 A100 for instance:
[Not shown: start accelerate on the node with 4 processes - could also with done with 2 process and we'd get DP=2 + PP=4]
from accelerate import Accelerator
from accelerate.utils import get_max_memory
from transformers import AutoModelForCausalLM

accelerator = Accelerator()

max_memory_all_gpus = get_max_memory()  # A dict of the max memory for all the gpus
if "cpu" in max_memory_all_gpus:
    del max_memory_all_gpus["cpu"]  # Keep only the GPUs (can tweak this to use also CPU)

# Keep only the subset of GPUs we want for this process
max_mem_this_process = {
    k: v
    for k, v in max_memory_all_gpus.items()
    if k % accelerator.num_processes == accelerator.process_index
}

model = AutoModelForCausalLM.from_pretrained("tiiuae/falcon-40b",
    trust_remote_code=True,
    max_memory=max_mem_this_process,
    device_map="auto")

Added a test for this as well
(Note that while this is working and rather easy to do in the end, importing a method from accelerate.utils is maybe a non trivial step for the user so possibly you can do a simpler and larger change in API at some point - up to you for now this doesn't touch any functionality)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

API-wise, may we could support an API like max_memory={0: "max", 2: "max"} to select only a couple of GPUs (and avoid the import from accelerate.utils).