Fixes staff pick label on homepage.

Fixes #4944.
field_staff_pick is not translatable.
cc @mikefantini

:+1:


OK, you're not signed up. Hope you reconsider!

I get the same error message whenever I try to enable publishing (WordPress to Facebook).

OK, you're not signed up. Hope you reconsider!

And it appears that Bridgy is publishing to my Facebook page instead of my timeline.
e.g.
https://islandinthenet.com/little-creature/ attempted syndication to https://www.facebook.com/469804493057745/posts/1631998853504964

thanks for reporting! looks like a real bug. i'll take a look soon.

Thank you for the fix. I appreciate  what you do.


Don't see the plugin

Hi...
Just installed this plugin and restarted Sketch, but I don't see it?

Hey There!
Just open Sketch Preferences via Cmd+, or Sketch -> Preferences... menu. ;)
Cheers!

Thanks!


"Array and string offset access syntax with curly braces is deprecated" with PHP version 7.4.2

I am getting this error after submit the contactform:
Array and string offset access syntax with curly braces is deprecated
PHP version 7.4.2
I found this on stackoverflow:
https://stackoverflow.com/a/59158549/3608678
Maybe you will have to update phpmailer in future releases

New Version of PHPMailer in new release Contact3 v2.1.0


Disabled/optionals not working properly

Disabled mods become optionals in .mrpacks.
But if you have .disabled override, mmc-export remove the .disabled fiel extension. It would be great to keep it.

Unfortunately removal of .disabled extension happens quite early in the conversion process so everything would work correctly. It would be troublesome to keep this extension at any stage of the process. It can be re-added with a condition somewhere here, but I don't think this is a good solution.

If you think that this is critical bug then I'll fix it, otherwise I'll just leave it as wontfix.

Yeah, a togle "isDisabled" in the resource and something to add the extension back in the add_override method if true.
I don't think it is critical but if it's not implemented in there, I will have to make my own quick script to put the extension back in the .mrpack.
It's as you wish.

Hmm. It does sounds reasonable to keep the original filenames in overrides.

Should be fixed now.


Remove many-level nested entities

Hi,
I have the next store normalized structure:
{
  sports: {
    1: {
       id: 1,
       name: 'Soccer',
       leagues: [2,3,4]
     },
     ...
  },
  leagues: {
    2: {
       sportId: 1,
       id: 2,
       name: 'Some league',
       matches: [5,6,7]
     },
     ...
  },
  matches: {
    5: {
       leagueId: 1,
       id: 5,
       name: 'Some match'
     },
    ...
  }
}

I have the next reducers composition:
rootReducer(state, action) {
  return {
    sports: sportsReducer(state.sports, action),
    leagues: leaguesReducer(state.leagues, action),
    matches: matchesReducer(state.matches, action)
  }
}

For example I need to remove sport and all dependent entities (leagues and matches). I can remove leagues because a league entity has a sport's id, but match doesn't. So in this way I have to write a single reducer because sportsReducer actually have to change all three maps (sports, leagues and matches).
Is there a more elegant way to deal with such situations?

Why do you need to remove cached data? Keep all the state fields, but add a new field called visibleSportIds: [1, 2, 3]. Instead of deleting a sport from sports, just remove its ID from this array. Make sure the app only displays sports that exist in visibleSportIds.

Because this is a cut of model what I have, the full mode is much bigger than it. Keeping all data in the store (without removing) will lead to the memory leaks and probably performance problems too, because there will be too much data soon. But the main requirement of our app is performance, so I can't afford it.
Actually, I've already found the solution. I'm going to expand low level entities with "high-level" keys. Hence, I'll be able to remove matches, scores, etc.
Something like this:
scores: {
   sportId: 1,
   leagueId: 2,
   matchId: 3,
   id: 4,
   ...
}

scoreReducer(state, action) {
  switch(action.type) {
    case REMOVE_SPORT:
      //get score IDs by leagueId
      //remove from the state IDs I got
      ...
}

It seems the most adequate solution in my case. The thing I most don't like in this case is iterating over map, but I think I'll reconcile with it.
Anyway thanks for your reply, I'll keep in mind your solution.

Keeping all data in the store (without removing) will lead to the memory leaks and probably performance problems too, because there will be too much data soon. But the main requirement of our app is performance, so I can't afford it.

Please profile it first (you can generate thousands of items to make sure). You might think keeping data in memory will be an issue, but if you use something like ImmutableJS to make sure mutations aren't that expensive, it may not be.

I have a batch of diffs (actions) every ~1 second, so it's likely will be a problem. The Immutable JS as I understood is only for elegant dealing with collections and  there are native objects and arrays under the hood. So there is no difference what I'm using Immutable JS or native objects regarding performance.
But I'll keep your solution in mind, thanks.

So there is no difference what I'm using Immutable JS or native objects regarding performance.

There is: Immutable uses structural sharing. This means any time you're putting something in the entity cache or changing it, you're not creating giant object under the hood.

I stick with @omeshechkov . What if he needed to delete leagues from a sportReducer because they were leagues were modified and their modification was persisted to a db. Then you want to start with fresh leagues aka [].


Don't rethrow on caught error in async wrapper

Fixes #19

Coverage remained the same at 100.0% when pulling 9824238e7ca627e6fe49b32fb4d8b84e016f5a0a on fix/issue-19 into d9deb5a11e21974fecad9c8e058cd2acf2668bdd on master.


UTF-8 Regex

This PR closes #1684
Instead of making byte_to_char_index public, it has been removed as it had no real reason to live.
Names are corrected and should correctly reflect their use.
Some examples of regular expressions with UTF-8 have been included.
Note however that the C-library underneath does not have UTF-8 semantics, as such, when using repetition operators on UTF-8 strings, capture the problematic characters with parentheses as in the example, or else the result will be erroneous.
Additionally, performances should be a bit better since less allocations and copy_to should be done.

Reroll: turns out fast_cstring was completely broken in interpreter when working on non-ASCII strings, who would've thought that !

API is changed, Match::subs and Match::[] now return a nullable Match, tests have been updated to highlight this change

Ok reroll, tests should not break

+1

:shipit:

Neo4j test has failed, since it might be a concurrency issue I'll launch it once more to check

jenkins: ok to test


Release download counter does not show

Please ensure:

[X] The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.
[X] The bug happens after clearing extension cache. The "Clear cache" button below can also be found at the bottom of the options page.

Example URLs
https://github.com/andry81-builds/amule/releases
Extension version
22.2.1
Browser(s) used
Firefox
Description
It does not work for me. The screens is the same as from here:
https://github.com/refined-github/refined-github/issues/5162
I've just installed the extension from here: https://addons.mozilla.org/firefox/addon/refined-github-
Include in this issue:

[ ] Screenshots/video/gif demonstrating the bug, if it’s visual
[ ] Console errors, if any

The feature is working fine, it's just that the download count is 0, so nothing is shown :smiley:
If you look at the artifacts of the previous release on the page that you linked to, you'll see that the feature is indeed working:

The feature is working fine, it's just that the download count is 0, so nothing is shown smiley

It is not, REST API shows not zero counters:
https://api.github.com/repos/andry81-builds/amule/releases

It is not, REST API shows not zero counters

You didn't parse entire response.
        "state": "uploaded",
        "size": 58326086,
        "download_count": 3,
        "created_at": "2022-02-07T08:52:36Z",
        "updated_at": "2022-02-07T08:52:43Z",
        "browser_download_url": "https://github.com/andry81-builds/amule/releases/download/v2.3.3--2021-12-05/amule-dev--2-3-3--2021-12-05--e26d06a.7z"

        "state": "uploaded",
        "size": 14636936,
        "download_count": 10,
        "created_at": "2022-02-07T08:52:49Z",
        "updated_at": "2022-02-07T08:52:51Z",
        "browser_download_url": "https://github.com/andry81-builds/amule/releases/download/v2.3.3--2021-12-05/vcredist_x86.exe"

I've used another extension and it works as expected:
https://addons.mozilla.org/firefox/addon/github-downloads

Your rest response shows zero downloads for all the assets on v2.3.3--2021-12-05--wx28-xp and the extension shows nothing, as we don't show a zero.
Your rest response shows downloads for the assets on v2.3.3--2021-12-05 and so does the extension, as seen in Florent's screenshot.
What are you expecting that's not happening? You said other extensions worked, can you share some screenshots?
We don't call the REST api, but the GraphQL one and we can see it matches the REST call you linked.
{
  "data": {
    "repository": {
      "_v2_3_3__2021_12_05__wx28_xp": {
        "releaseAssets": {
          "nodes": [
            {
              "name": "amule-wx28-xp--2-3-3--2021-12-05--e26d06a.7z",
              "downloadCount": 0
            },
            {
              "name": "amule-dev-wx28-xp--2-3-3--2021-12-05--e26d06a.7z",
              "downloadCount": 0
            },
            {
              "name": "vcredist_x86.exe",
              "downloadCount": 0
            }
          ]
        }
      },
      "_v2_3_3__2021_12_05": {
        "releaseAssets": {
          "nodes": [
            {
              "name": "amule--2-3-3--2021-12-05--e26d06a.7z",
              "downloadCount": 2
            },
            {
              "name": "amule-dev--2-3-3--2021-12-05--e26d06a.7z",
              "downloadCount": 5
            },
            {
              "name": "vcredist_x86.exe",
              "downloadCount": 12
            }
          ]
        }
      }
    }
  }
}

Your rest response shows downloads for the assets on v2.3.3--2021-12-05 and so does the extension, as seen in Florent's screenshot.

It does not show. I don't know what to say anymore here.

This is why I asked for a screenshot. Here's one more showing nothing for the first release, as it has no downloads, and counts for the second release as it does:

And what happens if you clear the extension's cache and refresh?

your PAT is bad.

Ok, this is it. But you didn't ask for any PAT tokens. Other extensions basically asks on first use, your extension didn't ask of any. How the user suppose to know that?

When you install the extension, we open a window to this issue: https://github.com/refined-github/refined-github/issues/3543
The first thing it mentions is the PAT.

You better to ask it programmatically on first use instead of force user to read spam letters.

@andry81 Contributions welcome.
This issue also asked if there were any console errors at the start. Additionally, you opened the options menu to add custom CSS with #5406 and would have had to scroll past the PAT section in the options, so there's been quite a few chances to catch this.

You better to ask it programmatically on first use

That's exactly what the extension will do.

instead of force user to read spam letters.

We do not force you to read the issue and the "spam letters" as you described is a pretty common pattern among browser extensions.

You may check other extension how it does use the permissions:

First, they work differently. If they don't ask for a PAT you may meet quota issues.
Second, it does not make sense to follow the "best patterns" of extensions used by only a few people.
Third, there's no such "best patterns" in reality. PAT is something you need to create manually and we can't just prompt aggressively as other people will hate it.

there said it's optional

It is optional for the whole extension, but required for some (or let's say, many) features.
@refined-github/maintainers I think we do need to reword a bit (either in the welcome issue or the options page) and make it
Extremely Clear
PAT is required.


Add the management section

Is your feature request related to a problem? Please describe.
create the component for the management section
Describe the solution you'd like
Ensure the section is the same as the svg provided in the website-assets folder. Make the section responsive across the different devices, eg desktop, laptop and mobile devices.
Use svg for the images instead of jpeg or png format.
Desktop view

mobile view

Describe alternatives you've considered
n/a
Additional context
Make the section responsive.

Hi, can I take this one !

Yeah, sure.

Any updates to the current assign,
I would like to work on this, could you assign it to me?


weird bugs after trying out pgcli

I just installed pgcli.  Sometimes, \d works.  Other times it doesn't.
giftgram_dev> \d sent_giftgrams
local variable 'indexdef' referenced before assignment

Also, \h doesn't work for me:
giftgram_dev> \h alter TABLE alter COLUMN
ERROR:  syntax error at or near "\"
LINE 1: \h alter TABLE alter COLUMN
        ^

Thanks for starting this project!

Hrm. I thought I had tested all the code paths for \d but I'll start adding some tests to make sure things work ok. \d is a bit of a beast since it can be called on a table or an index or a view or sequence etc. So there is probably some branch in the code path I missed. I'll take a look.
\h is not yet implemented. Unfortunately the back-slash commands can't be passed on directly to the database. They are implemented by psql, so I have to implement them one at a time to duplicate it.
Can you tell me what is the type of sent_giftgrams in your example? Is it a table/view/seq/index or something else?
Also what is the version of Postgres?

Hey, thanks for writing back!
Here is the \d output for sent_giftgrams:

\d sent_giftgrams
Table "public.sent_giftgrams"
+-------------------------+--------------------------+------------------------+
|         Column          |           Type           |       Modifiers
|
+-------------------------+--------------------------+------------------------+
| gg_uuid                 | uuid                     | not null
|
| recipient_email_address | email_address_type       |
|
| sent                    | timestamp with time zone |
|
| delivery_datetime       | timestamp with time zone |
|
| when_to_deliver         | citext                   | not null
|
| shipper                 | citext                   |
|
| tracking_number         | text                     |
|
| inserted                | timestamp with time zone | not null default
now() |
| updated                 | timestamp with time zone |
|
| easypost_id             | text                     |
|
| bad_tracking_data       | boolean                  |
|
| recipient_text_number   | usa_phone_number_type    |
|
+-------------------------+--------------------------+------------------------+
Check constraints:
"email_giftgrams_check" CHECK (shipper IS NULL OR shipper IS NOT NULL
AND tracking_number IS NOT NULL)
"email_giftgrams_check1" CHECK (when_to_deliver <> 'after
delivery'::citext OR shipper IS NOT NULL AND tracking_number IS NOT NULL)
"email_or_sms_not_null" CHECK (recipient_email_address IS NOT NULL OR
recipient_text_number IS NOT NULL)
Foreign-key constraints:
"email_giftgrams_shipper_fkey" FOREIGN KEY (shipper) REFERENCES
shippers(title) ON UPDATE CASCADE ON DELETE CASCADE
"email_giftgrams_when_to_deliver_fkey" FOREIGN KEY (when_to_deliver)
REFERENCES when_to_deliver_allowed_values(title) ON UPDATE CASCADE ON
DELETE CASCADE
"giftgrams_email_giftgrams_fkey" FOREIGN KEY (gg_uuid) REFERENCES
giftgrams(gg_uuid) ON UPDATE CASCADE ON DELETE CASCADE
Triggers:
email_giftgrams_set_updated_column BEFORE UPDATE ON sent_giftgrams FOR
EACH ROW EXECUTE PROCEDURE set_updated_column()

On Wed, Jan 7, 2015 at 11:11 AM, Amjith Ramanujam<EMAIL_ADDRESS>wrote:

Hrm. I thought I had tested all the code paths for \d but I'll start
adding some tests to make sure things work ok. \d is a bit of a beast since
it can be called on a table or an index or a view or sequence etc. So there
is probably some branch in the code path I missed. I'll take a look.
\h is not yet implemented. Unfortunately the back-slash commands can't be
passed on directly to the database. They are implemented by psql, so I
have to implement them one at a time to duplicate it.
Can you tell me what is the type of sent_giftgrams in your example? Is it
a table/view/seq/index or something else?
Also what is the version of Postgres?
—
Reply to this email directly or view it on GitHub
https://github.com/amjith/pgcli/issues/66#issuecomment-69044533.

--
W. Matthew Wilson
partner
216 Software, LLC
<EMAIL_ADDRESS>http://216software.com

I found the code path that was referencing the wrong arg. It is now fixed.
Thanks for reporting it. :green_apple:


Add release stage with semantic versioning, and deploys to server.

Is your feature request related to a problem? Please describe.
Every time new resolved issues get merged into master via pull-request, a new version should be released and a deployment to Heroku should be performed.
Describe the solution you'd like
Use semantic-versioning package, and GitHub release action as well as Heroku to run the docker-compose.
Describe alternatives you've considered
Deploy to DKE server.
Additional context
Links:

https://devcenter.heroku.com/articles/build-docker-images-heroku-yml
https://www.npmjs.com/package/semantic-release

New Git and GitHub deploys, releases, as well as changelogs are automatically created and deployed when a pull request is merged from the dev into the main branch.
Every time you want to develop a new feature, create an issue and assign yourself to that issue. This will trigger a GitHub action that creates a new issue from the dev branch.
When you are done developing, create a commit with a message that includes "#patch", "#minor", or "#major" according to the semantic versioning specification.
Next, create a pull request to the dev branch. Assign the pull request one of the labels "fix", "feature", or "test" so they appear correctly later in the changelogs.


Zoom support / multires tiling

It would be great if this viewer also supports zooming and multiresolution tiling/srcset,
similar to what panorama viewers (that view from the opposite direction, inside-out) use for efficient zooming.

Thanks for the suggestion!
I looked at this and I agree zooming / multiple srcsets would be nice to have. However I'm currently unable to to implement this within a reasonable timeframe. It introduces additional complexity I may struggle to reliably maintain long-term within my current time resources.


[SPARK-26024][SQL]: Update documentation for repartitionByRange

Following SPARK-26024, I noticed the number of elements in each partition after repartitioning using df.repartitionByRange can vary for the same setup:
// Shuffle numbers from 0 to 1000, and make a DataFrame
val df = Random.shuffle(0.to(1000)).toDF("val")

// Repartition it using 3 partitions
// Sum up number of elements in each partition, and collect it.
// And do it several times
for (i <- 0 to 9) {
  var counts = df.repartitionByRange(3, col("val"))
    .mapPartitions{part => Iterator(part.size)}
    .collect()
  println(counts.toList)
}
// -> the number of elements in each partition varies

This is expected as for performance reasons this method uses sampling to estimate the ranges (with default size of 100). Hence, the output may not be consistent, since sampling can return different values. But documentation was not mentioning it at all, leading to misunderstanding.
What changes were proposed in this pull request?
Update the documentation (Spark & PySpark) to mention the impact of spark.sql.execution.rangeExchange.sampleSizePerPartition on the resulting partitioned DataFrame.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @cloud-fan

@viirya OK all references to SPARK-26024 removed from the doc.

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5128/
Test PASSed.

Test build #98987 has started for PR 23025 at commit 654fed9.

Test build #98987 has finished for PR 23025 at commit 654fed9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98987/
Test PASSed.

Test build #98991 has started for PR 23025 at commit f829dfe.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5131/
Test PASSed.

Test build #98992 has started for PR 23025 at commit 7ca4821.

Test build #98991 has finished for PR 23025 at commit f829dfe.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #98992 has finished for PR 23025 at commit 7ca4821.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98992/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98991/
Test FAILed.

Test build #98995 has finished for PR 23025 at commit 7ca4821.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98995/
Test PASSed.

Thanks all for the reviews!


Add "Enable flash/torch" button

Proposed changes
Change const constraints to var.
Then proceed with something like this:
 var imageCaptureConfig = {
        fillLightMode: "torch", /* or "flash" */
        focusMode: "continuous"
    };

(Source: https://stackoverflow.com/questions/37848494/is-it-possible-to-control-the-camera-light-on-a-phone-via-a-website)
Note: This only works on some Android phones.
Tasks

[x] Basic implementation with icon
[x] Make sure this only is shown on supported mobile devices (exclude iOS!)

Let's not prioritize this to v2.x, as it works only on some devices.

Icon !


How to get ram price in eos contract

Used in eosiocpp
asset zion_contract::buyrambytes(uint32_t bytes) {
  eosiosystem::rammarket market(N(eosio), N(eosio));
  auto itr = market.find(S(4, RAMCORE));
  eosio_assert(itr != market.end(), "RAMCORE market not found");
  auto tmp = *itr;
  return tmp.convert(asset(bytes, S(0, RAM)), CORE_SYMBOL);
}

How to get it in eosio-cpp? I want to calculate in the contract how much ram can be purchased by the current eos.

You may gain access to the rammarket using the same typedef used by the system contract, found here: typedef eosio::multi_index< "rammarket"_n, exchange_state > rammarket;.
If you wish to continue using #include <eosio.system/exchange_state.hpp>, you'll need to provide eosio-cpp with a -I eosio.contracts/eosio.system/include argument to your copy of the eosio.contracts repository, prefixing my sample path with whatever is appropriate for your environment.


What compatibility are we testing?

I am not sure if compatibilityReportDependencyIssues or compatibilityCheck  completely describes what this plugin aims to do. To me compatibility sounds like if a transitive library X is still compatible with the rest of my dependency graph.
If we are mostly enforcing some version scheme compliance like SemVer, maybe naming it as versionPolicyCheck + versionPolicyDependencyCheck might reflect what's going on?

Another idea for prefix might be versioning, like versioningCheck, versioningDependencyRules, etc.

@julienrf so is it ok to rename to sbt-version-policy all around?

Yes.


Keep original movie title

When adding movie files, can we have the option to keep the original file name (without the file extension). This way the movies will sort correctly. It's miserable keeping track of the Marvel movies or what order the Harry Potter, Fast n Furious, and Hobbit movies should go in. If I can keep the original file name in Mizuu then I can control the order the movie icon is displayed on the screen.

It's coming.


flutter run output switches from reporting seconds to milliseconds for no apparent reason

flutter build clean && flutter run

14:51:14.416: Launching lib/main.dart on Pixel C in debug mode...
14:51:20.751: Building APK in debug mode (android-arm)...           5.8s
14:51:34.577: Installing build/app.apk...                          13,370ms
14:51:40.588: Syncing files to device...                           3,601ms

lol.  FYI @devoncarew

We originally made everything ms to push us towards being fast.  Last night? @devoncarew made it possible to mark some of these as "expected slow" and instead print in seconds.  I guess we need to mark a few more.

https://github.com/flutter/flutter/commit/d89f438699590eaae2cdac7f8e64610f17d5ab03

Yeah, these output type for similar things (or things printed next to each other) should be consistent - I can update.


Some auto-generated API documentation is broken

http://sharpdx.org/wiki/class-library-api/direct2d1/#api-Interfaces

Looks like Jekyll broke some stuffs in the meantime

Wow, it's still broken, just check http://sharpdx.org/wiki/class-library-api/direct3d11/
Such pity, I thought of using SharpDX, but looks like it's not really worth it.

@dr3adl0rd SharpDX is no longer maintained.


Think about getting rid of include

Whatever's not to be consumed can simply be moved to src, thus reducing the interface/scope of the project.

After discussion, we agree macros are required from those files. Think about renaming the file as arizona.hrl, for consistency.


Potential deadlocks in bigtable::MutationBatcher

Does this issue affect the google-cloud-cpp project?
Yes.
What component of google-cloud-cpp is this related to?
Bigtable
Describe the bug
This code is suspect:
https://github.com/googleapis/google-cloud-cpp/blob/a68f42a33dca00c35818ccbfbbe3bec96bc7dd0e/google/cloud/bigtable/mutation_batcher.cc#L185-L189
It calls TryAdmin() which performs a lot of work, potentially making RPCs:
https://github.com/googleapis/google-cloud-cpp/blob/a68f42a33dca00c35818ccbfbbe3bec96bc7dd0e/google/cloud/bigtable/mutation_batcher.cc#L192-L207
This can deadlock and/or make no progress.
To Reproduce
This is a report from a customer, in their application they need to run about a thousand processes for the deadlock to happen.
Expected behavior
The MutationBatcher should guarantee progress.
Operating system:
Linux, no further details available.

There is a bug in CompletionQueue::RunAsync() which still causes problems with this.


Filter OpenShift VMs by features

Supported features:

NUMA
GPUs/Host Devices
Persistent TPM/EFI
Dedicated CPU

@rszwajko looks nice, but it looks too detailed to me, a user need to do lots of clicks and decisions to select all vms with some feature.
@ahadas can we group some features that have things in common together (efi+tpm, cpu+gpu ... )?
should we do "vm has special features" selection option, and remove all granularity ?

@ahadas can we group some features that have things in common together (efi+tpm, cpu+gpu ... )? should we do "vm has special features" selection option, and remove all granularity ?

yeah, grouping features sounds like a good idea
the question is how - let's say that we have 'efi+tpm' group, does it mean we'll filter VMs that have either nvram or tpm?
thinking out aloud:
as I see it, this view is useful to assessing the ability to migrate the virtual machine before creating plans - get to this view and see which VMs have warnings / errors, that's more important than showing the features themselves since when we think about the features we can divide them to two groups:

features that will be 'lost' during the migration, e.g., host devices. I don't see much value in filtering them here since users are unlikely to go back, e.g., to RHV and detach the host devices when they can just select those VMs in MTV and continue with their migration, knowing the host devices will not be attached to the migrated VMs.
features that block the migration. there aren't many features like that, and we need to think about those that exist today (e.g., sr-iov is blocking migrations from vsphere but it doesn't block migrations from rhv.. same case for host/passthrough devices). it can be useful to filter by such features so users could make changes in the source environment in order to be able to migrate them, but the question is whether it makes sense at all to require users to do it or treat all features like those in the first group that are dropped if they're not supported by kubevirt (with a warning)

so maybe that's actually a question to ask - what value should filtering by features bring to users?

@ahadas thanks,
@rszwajko can we do finer filtering using the warnings / errors, IARC we only filter by existing of warning or error, we don't differentiate between specific errors or warnings, @ahadas does it makes sense to allow filtering by different error / warning types ?
@ahadas doe the scenario of making different plans for different VM gropups makes sense ?
"as an admin I want to create a different plan to migrate all the vms that require GPU and a different migration plan for the VMs that require special vnics"

@ahadas

this view is useful to assessing the ability to migrate the virtual machine before creating plans

The future plan is to replace Plan Wizard with this screen i.e. you filter the VMs and click "Migrate" button.

features that will be 'lost' during the migration, e.g., host devices.

For OpenShift providers we have the same capabilities on source and on the target so no feature need to be lost.
The target needs only to have the correct configuration in place.
For other providers this is more complex - that's why it's not supported yet (this PR is only about OpenShift)

what value should filtering by features bring to users?

The primary use case is a successful migration of VMs with features that are not covered by our mappings. Such features require manual config on the target(i.e. in a dedicated namespace). Most likely other VMs will need a different setup so it's better to keep both groups separated.
The flow could look the following:

filter VMs that use some special feature (i.e. GPU)
select the VMs and start the migration
pick a namespace on the target that have the given special feature pre-configured
customize other migration option
trigger the migration

@yaacov

can we do finer filtering using the warnings / errors, IARC we only filter by existing of warning or error, we don't differentiate between specific errors or warnings,

It's possible to do free-text filtering based on labels. The structure looks the following:
{
      category: 'Warning',
      label: 'Shareable disk detected',
      assessment:
        'Shared disks are only supported by certain OpenShift Virtualization storage configurations. Ensure that the correct storage is selected for the disk.',
    },

@rszwajko can we do finer filtering using the warnings / errors, IARC we only filter by existing of warning or error, we don't differentiate between specific errors or warnings, @ahadas does it makes sense to allow filtering by different error / warning types ?

yeah, that makes sense to me
if you do this by the label of a validation, like this, then we'll avoid making changes to the labels (we already rephrased/changed few assessments)

@ahadas doe the scenario of making different plans for different VM gropups makes sense ? "as an admin I want to create a different plan to migrate all the vms that require GPU and a different migration plan for the VMs that require special vnics"

it certainly makes sense to make different plans for different VM groups since we need a plan per target namespace, however, I don't think it would be based on the VM features/capabilities but rather based on their ownership/permissions

@ahadas

this view is useful to assessing the ability to migrate the virtual machine before creating plans

The future plan is to replace Plan Wizard with this screen i.e. you filter the VMs and click "Migrate" button.

ah ok, I didn't realize that's the context, thanks

features that will be 'lost' during the migration, e.g., host devices.

For OpenShift providers we have the same capabilities on source and on the target so no feature need to be lost. The target needs only to have the correct configuration in place. For other providers this is more complex - that's why it's not supported yet (this PR is only about OpenShift)

currently you're right as we assume we migrate between OCP clusters that have the same OCP version
I thought "OpenShift" VMs was a mistake and you meant RHV/vSphere/OpenStack VMs, ok

what value should filtering by features bring to users?

The primary use case is a successful migration of VMs with features that are not covered by our mappings. Such features require manual config on the target(i.e. in a dedicated namespace). Most likely other VMs will need a different setup so it's better to keep both groups separated.
The flow could look the following:

filter VMs that use some special feature (i.e. GPU)
select the VMs and start the migration wizard
pick a namespace on the target that have the given special feature pre-configured
customize other migration option
trigger the migration

I see, but then looking at the features above:

Dedicated CPU - not namespace-scoped
GPUs - I'm not sure if that's namespace-scoped
Host devices - unsupported in kubevirt
NUMA - not namespace-scoped
Persistent EFI - not namespace-scoped
Persistent TPM - not namespace-scoped

there is SR-IOV that is namespace-scoped but that's supposed to be covered by the network mapping (i.e., if we get a VM from the source that is mapped to a network-attachment-definition with SR-IOV, then we need to make sure that network is mapped to a network-attachment-definition with SR-IOV on the target)

@ahadas
I've browsed the official Kubevirt user guide and picked features that looked promising. The list requires more attention for sure.
As for your comments - note that most of those features require configuration at node level. Nodes in turn can be assigned to namespaces (see below).  However even if we assume that this is a cluster wide setting it only means that decision is made at different level i.e.

select the VMs
pick a target cluster with given capability
trigger the migration

Dedicated CPU - not namespace-scoped

The feature requires nodes with a running CPU manager.

GPUs - I'm not sure if that's namespace-scoped
Host devices - unsupported in kubevirt

See https://kubevirt.io/user-guide/virtual_machines/host-devices/
Note the user guide lists NVMe passthrough  as one of the use cases and recommends nodeSelector to mitigate issues with assignment.

NUMA - not namespace-scoped

Requires dedicated CPU resources and hugepages which are node-level.

Persistent EFI - not namespace-scoped
Persistent TPM - not namespace-scoped

I've over-interpreted the docs. The setting  seems per cluster.

Note:
when filtering VMs it is not just for namespace, it can also be for other reasons,  for example migrating some VMs in phase 1 and doing other VMs in phase 2 and 3, IMHO filters that can help users to select different VMs for different migration phase based on resource can be helpful

@rszwajko ack

... Nodes in turn can be assigned to namespaces (see below). However even if we assume that this is a cluster wide setting it only means that decision is made at different level i.e.

select the VMs
pick a target cluster with given capability
trigger the migration

can you point to me to where we see nodes can be assigned to namespaces? I'm not familiar with that configuration
about the steps above, in our case it's not like oVirt that we have a data center that contains multiple clusters and then we pick VMs in the first step and follow with picking a target cluster, but rather we pick the target cluster (cluster == OCP instance) and then pick the VMs to migrate to a namespace in that cluster
I doubt users would pick different OCP instances based on features, even though it's possible, but I think it's more likely that people would want to test things, e.g., test migration of a VM with vGPU, before initiating the full migration as @yaacov wrote above, so ok, I see the value in this now - it is worth mentioning it somewhere though

Dedicated CPU - not namespace-scoped

The feature requires nodes with a running CPU manager.

right, and CPU manager is enabled per-cluster

GPUs - I'm not sure if that's namespace-scoped
Host devices - unsupported in kubevirt

See https://kubevirt.io/user-guide/virtual_machines/host-devices/ Note the user guide lists NVMe passthrough as one of the use cases and recommends nodeSelector to mitigate issues with assignment.

ack, it didn't exist back then so we also need to adjust our validations - we currently warn users that host devices won't be mapped

NUMA - not namespace-scoped

Requires dedicated CPU resources and hugepages which are node-level.

ok, but the problem with node-level is that we don't know, in MTV, the node-level specification in kubevirt

Persistent EFI - not namespace-scoped
Persistent TPM - not namespace-scoped

I've over-interpreted the docs. The setting seems per cluster.

here we have a bigger issue - we cannot get the persistent data from RHV and that from vSphere won't help us even if we could have got it, so regardless of the support for these features in kubevirt, we should warn about VMs with these features.
we thought at some point, and I proposed it in kubevirt user's mailing list, to try to identify which features are supported or enabled in kubevirt - this could allow us to produce different message, e.g., when TPM is not supported in kubvirt vs. when it's supported, but it didn't get much attention from the kubevirt side so it means we'll have to store, e.g., TPM is supported as from version X, however this is not that easy and we'll need to have that mapping also for k8s..

@ahadas

can you point to me to where we see nodes can be assigned to namespaces? I'm not familiar with that configuration

check out PodNodeSelector

Dedicated CPU - not namespace-scoped
The feature requires nodes with a running CPU manager.
right, and CPU manager is enabled per-cluster

My understanding is that a cluster can have multiple nodes and not all nodes may have a CPU manager. Generally running the CPU manager and labeling seems a manual process.

NUMA - not namespace-scoped
Requires dedicated CPU resources and hugepages which are node-level.
ok, but the problem with node-level is that we don't know, in MTV, the node-level specification in kubevirt

Yes and it's unlikely that we will cover such advanced features with mappings. Preparing such configuration will rather stay a manual process. We can however try to support the users in the process i.e. with filtering the right VMs and choosing the pre-configured target provider/namespace.

@ahadas

can you point to me to where we see nodes can be assigned to namespaces? I'm not familiar with that configuration

check out PodNodeSelector

ah ok, so they're not really "assigned" but rather "selected", like we can affect pod scheduling with taints and tolerations but here it's done on at the namespace-level, nice

Dedicated CPU - not namespace-scoped
The feature requires nodes with a running CPU manager.
right, and CPU manager is enabled per-cluster

My understanding is that a cluster can have multiple nodes and not all nodes may have a CPU manager. Generally running the CPU manager and labeling seems a manual process.

yes, the CPU manager runs on kubelet, i.e., on the nodes
I meant that the feature can be enabled at the cluster-level in kubevirt

NUMA - not namespace-scoped
Requires dedicated CPU resources and hugepages which are node-level.
ok, but the problem with node-level is that we don't know, in MTV, the node-level specification in kubevirt

Yes and it's unlikely that we will cover such advanced features with mappings. Preparing such configuration will rather stay a manual process. We can however try to support the users in the process i.e. with filtering the right VMs and choosing the pre-configured target provider/namespace.

we are definitely not going to prepare such configuration. btw, we also don't prepare network configuration but count on users to define the network attachment definitions and only map to them, so that makes sense
about choosing pre-configured target provider/namespace - that's very complicated.
even taking a simpler case: an OCP instance, that has OpenShift Virtualization deployed on it, and have a namespace that selects hosts that non of them have virtualization enabled - we (in MTV) can't tell that this namespace cannot be used for VMs, let alone more complicated scenarios of nodes with host devices..
also take into account that in k8s it all works with "desired state" - you may want to migrate the vm to a new namespace or an existing namespace that don't yet have the resources the VMs need, but the VMs should still ask for them as you're going to add it later on
I think it comes down to: in which situation we need a feature without a concern because if we have concerns (warnings / errors) for each feature, we better let users filter concerns rather than features

I think it comes down to: in which situation we need a feature without a concern because if we have concerns (warnings / errors) for each feature, we better let users filter concerns rather than features

examples:
a. migrating in batches by features, first batch are small vms with one distk, and in the next batch vms that require GPU, and lastly if all is ok migrate vms with special nics
b. migrating only a subset of the vms
c. creating a re-migration of vms that failed the last migration because the had some issue with efi so we need to re-select only this ones

I think it comes down to: in which situation we need a feature without a concern because if we have concerns (warnings / errors) for each feature, we better let users filter concerns rather than features

ok, let's check this concretely for the features above:
dedicated CPUs: not all the features in ovirt exist in kubevirt (see those validation), so for those that don't exist we need a concern and for those that exist we can have a feature (?)
GPUs: we currently don't handle vGPUs in forklift so it would be better to have a concern that warn about this
Host devices: forklift doesn't handle that as well (I just saw that USB passthrough was added in kubevirt 1.1.0 that was released today)
NUMA: same as GPUs and host devices
and for persistent EFI/TPM we need concerns

I think it comes down to: in which situation we need a feature without a concern because if we have concerns (warnings / errors) for each feature, we better let users filter concerns rather than features

examples: a. migrating in batches by features, first batch are small vms with one distk, and in the next batch vms that require GPU, and lastly if all is ok migrate vms with special nics b. migrating only a subset of the vms c. creating a re-migration of vms that failed the last migration because the had some issue with efi so we need to re-select only this ones

@yaacov ok, that's something different - here you say when filtering of either concerns or features may be useful
for the first case, do we agree that it's more likely that such filtering would happen with features that we have concerns? the way you put it is too broad since for that we can add features of, e.g., 'two disks', 'nic with special properties', etc
for the second case, think about our internal migration from RHV to OpenShift - this would mean to divide the plans that we created to each target namespace to multiple plans that are per-target namespace and per-feature. we have in the backlog a task about prioritization of the migrations - not to create plans with less VMs but to say "here is my plan, I want to start with certain VMs, then other group of VMs, and so on"
for the third case, if users need to create new plans for failed migrations, we did something incorrect. user are supposed to be able to restart a plan and then only the failed migrations would be retriggered

for the first case, do we agree that it's more likely that such filtering would happen with features that we have concerns for? the way you put it is too broad since for that we can add features of, e.g., 'two disks', 'nic with special properties', etc

hmm, from my side this is a discussion about how to choose vms for migration plan, not about this specific feature list.
the question I want answer to, is how to best choose vms for migration,
IMHO using only warnings, e.g. "migrate all vms without warnnigs" is less helpful then "migrate all vms that match this criteria"
for me, this discussion is about what are the best criteria , i less care about the list in this specific PR
this discussion is about how we can make the plan creation more useful,
the question we ask is not if this specific list of features is useful, the question is what list of features will be useful,
should we filter by number if disks ?
should we filter by labels ? what provider support something that resemble labels ?
also note that this feature list is provider specific,  this discussion is not specific to overt or openshift, the question is how do we best help users to choose vms when creating a migration plan when they need to choose 100s of vms out of the 1000s a provider include

@ahadas , I think I understand the problem ... this is a PR that is a sub task of an issue:
https://github.com/kubev2v/forklift-console-plugin/issues/764
@rszwajko @ahadas let's continue in the issue as it is a better place for discussions

Change summary in the force push above:

merge similar features to limit the number of options in the filter
in the feature column display labels
rebase on top of the current main branch

@yaacov  please re-review.
note that the screenshots (far) above have been updated


Plotting data with datetimes

The plotting library doesn't seem to work when I try and plot a datetime object. It can handle just dates but when there is an associated time the plot builds without error but no line is plotted.
Code here that doesn't work:
import pandas as pd
import matplotlib.pyplot as plt
import pdvega
rng = pd.date_range('1/1/2011', periods=72, freq='H')
rng = [pd.Timestamp(r) for r in rng]
ts = pd.Series(np.random.randn(len(rng)), index=rng)
ts.vgplot.line() #this doesn't throw any errors but no data is shown
ts.plot() #this works on the other hand
plt.show()

Thanks – I think this has to do with the way temporal data is serialized to JSON.


fix: Add call level meta

Pull Request Test Coverage Report for Build 39

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 38:
0.0%

Covered Lines:
37

Relevant Lines:
37

💛  - Coveralls

:tada: This PR is included in version 1.6.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


npm install<EMAIL_ADDRESS>is worked?

in my case npm ERR! code E404 is apper
i want use did so i considering trustid and indy
especially want use trustid,, i watching youtube and googling but not so much information
plz,, make video for setup,, your readme is not friendly so can't make trustid,,
sorry for my foor english

I also found that the readme steps are very confusing. I can’t succeed in following the instructions in the home directory and trustid-sdk

@ryjones  so can you please take a moment to update the readme so that everyone can follow it to use the SDK

@youngseoka @ryjones Hi, I came across this thread while trying to use trustid-sdk. Have you had any success trying to use this library?

yeah i am using this 'TRUSTID'

Is this project still active? This issue is not solved yet.

Hi, @jayzhan211, @ryjones. Sadly, since a few years ago I don't have time to actively contribute to this project and I may lack the right context to help you with this (the curse of OSS). Probably @mtnieto can help you with this. Cheers.


Console 4.0

[x] Remove ServiceKit / Container
[x] Use EventLoop scheduled tasks instead of thread / blocking
[x] Consider renaming to ConsoleKit / CommandKit
[x] Fix warnings
[x] Consider removing "ephemeral" functionality
[x] Consider combining Console + Command into single module

Hey @tanner0101, you just merged a pull request, have a coin!
You now have 1028 coins.


get node runs details using pychef

We are trying to fetch details from chef "reports API" call using pychef, i am using the below code for API call.
import chef
with chef.ChefAPI('https://chef-server/organizations/devopsorg', 'devopsuser.pem', 'devopsuser', ssl_verify=False):
api= chef.ChefAPI.get_global()
print api
print api["/reports/nodes/chefnode1/runs"]
I could able to fetch other chef server API form organization end but not "/organizations/ORG_NAME/reports/nodes/NODE/runs".
Please suggest us any way for handling this

By default Chef Server does not save that information. It is part of the older Chef Reporting commercial addon and the newer Chef Automate system. As I've never used either, there is no direct API support for those in PyChef but you can always use the raw API object to make simple requests yourself. For example, looking at https://docs.chef.io/api_reporting.html#reports-nodes-node-runs you could use api['/reports/nodes/foo.example.com/runs'] to get a list of the run IDs for that node.

Sorry, I realize I didn't read this carefully enough and you might not be the same person as in the SO question. About the URIs, the thing in the api[] gets appended to the base URL you give in the ChefAPI constructor so if you want to access multiple orgs you can either give a base URL like https://chef-server/ (though most PyChef objects won't work with this API object since they expect the base URL to point at the org) or make multiple API objects.


Add unit tests

Most types and they methods have doc tests and they are vital tests to make sure the crate is working, but they don't cover all scenarios so the addition of unit tests is desirable.

The crate is iterating, so unit test are likely to break as it regularly happens with the doc tests, so they haven't been prioritized


Improve number of colors for layers

Yes it's a thing I have in a corner of my head since the beggining of the project... I will add a color selector, without constraint (you can pick whatever color you want) but with a quick color selector (the actual colors).


Caused by: java.lang.Exception: node:internal/modules/cjs/loader:1078  throw err;Cannot find module 'react-native/cli'Require stack:

Description
My project structure looks like this :
Desktop/
├── Android project/
├── iOS project/
├── RN project/
Now my iOS project has successfully integrated RN,But my Android project is having problems with integration,This is an error message:
Caused by: java.lang.Exception: node:internal/modules/cjs/loader:1078  throw err;  ^Error: Cannot find module 'react-native/cli'Require stack:- /Users/macbookpro/Desktop/epark-android/[eval]    at Module._resolveFilename (node:internal/modules/cjs/loader:1075:15)    at Module._load (node:internal/modules/cjs/loader:920:27)    at Module.require (node:internal/modules/cjs/loader:1141:19)    at require (node:internal/modules/cjs/helpers:110:18)    at [eval]:1:87    at Script.runInThisContext (node:vm:129:12)    at Object.runInThisContext (node:vm:307:38)    at node:internal/process/execution:79:19    at [eval]-wrapper:6:22    at evalScript (node:internal/process/execution:78:60) {  code: 'MODULE_NOT_FOUND',  requireStack: [ '/Users/macbookpro/Desktop/epark-android/[eval]' ]}Node.js v18.16.0
I hope you can help me, I have been troubled for a week, the mood is very bad,Thank you very much!!!
React Native Version
0.72.3
Output of npx react-native info
macbookpro@MacBook-Pro-2 ~ % cd /Users/macbookpro/Desktop/EparkReactNative
RVM used your Gemfile for selecting Ruby, it is all fine - Heroku does that too,
you can ignore these warnings with 'rvm rvmrc warning ignore /Users/macbookpro/Desktop/EparkReactNative/Gemfile'.
To ignore the warning for all files run 'rvm rvmrc warning ignore allGemfiles'.
Unknown ruby interpreter version (do not know how to handle): >=2.6.10.
macbookpro@MacBook-Pro-2 EparkReactNative % npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 13.5
CPU: (12) x64 Apple M2 Pro
Memory: 29.42 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 18.16.0
path: /usr/local/bin/node
Yarn:
version: 1.22.19
path: /usr/local/bin/yarn
npm:
version: 7.24.0
path: /usr/local/bin/npm
Watchman: Not Found
Managers:
CocoaPods:
version: 1.12.1
path: /Users/macbookpro/.rvm/gems/ruby-2.7.6/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.1
- iOS 16.1
- macOS 13.0
- tvOS 16.1
- watchOS 9.1
Android SDK:
API Levels:
- "23"
- "25"
- "26"
- "28"
- "29"
- "30"
- "31"
- "33"
Build Tools:
- 28.0.3
- 29.0.2
- 30.0.3
- 33.0.0
Android NDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9477386
Xcode:
version: 14.1/14B47b
path: /usr/bin/xcodebuild
Languages:
Java:
version: <IP_ADDRESS>
path: /Library/Java/JavaVirtualMachines/jdk-<IP_ADDRESS>.jdk/Contents/Home/bin/javac
Ruby:
version: 2.7.6
path: /Users/macbookpro/.rvm/rubies/ruby-2.7.6/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.3
wanted: 0.72.3
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Steps to reproduce
My seeting.gradle configuration looks like this:
apply from: file("../EparkReactNative/node_modules/@react-native-community/cli-platform-android/native_modules.gradle");  applyNativeModulesSettingsGradle(settings)
include ':app', ':calendarview', ':zxinglib', ':matisse', ':calendarlibrary', ':picker-view'
My bulid.gradle(:app) looks like this:
apply plugin: "com.facebook.react"
dependencies {
implementation "com.facebook.react:react-android"
implementation "com.facebook.react:hermes-android"
}
apply from: file("../../EparkReactNative/node_modules/@react-native-community/cli-platform-android/native_modules.gradle");  applyNativeModulesAppBuildGradle(project)
Snack, screenshot, or link to a repository

@helloMrTom have you found a solution to this problem? I'm running into the same error message with my setup.


Added to docs for windows PhpStorm links

I was having issues relating PhpStorm links from Ray to my PhpStorm instance and found a work-around solution for it. I am updating docs because I was asked. Let me know if I did something incorrect.

This was created in reference to discussion #65

This was created in reference to discussion #65

Thanks for posting this. I don't want to maintain that run_editor.js file. Where did you find it? Could you replace it with a link?

Thanks for posting this. I don't want to maintain that run_editor.js file. Where did you find it? Could you replace it with a link?

Absolutely, will do in a bit.

Absolutely, will do in a bit.

@freekmurze I have linked it in the previous paragraph. However, the code shown is just an explanation of a potential bug/issue people may run into using that package. The package is here created by aik099. The issue is pending at the moment and may potentially get resolved. However, I can go ahead and remove the code explanation as it will probably soon be resolved. Is that what you would like me to do?

@freekmurze I have linked it in the previous paragraph. However, the code shown is just an explanation of a potential bug/issue people may run into using that package. The package is here created by aik099. The issue is pending at the moment and may potentially get resolved. However, I can go ahead and remove the code explanation as it will probably soon be resolved. Is that what you would like me to do?

I can go ahead and remove the code explanation as it will probably soon be resolved. Is that what you would like me to do

👍

I can go ahead and remove the code explanation as it will probably soon be resolved. Is that what you would like me to do

👍

I removed the code and cleaned up the links. Let me know if there is anything else. If not thanks soo much @freekmurze for the amazing tool and glad to be of assistance!

I removed the code and cleaned up the links. Let me know if there is anything else. If not thanks soo much @freekmurze for the amazing tool and glad to be of assistance!

Thank you!

Thank you!


Feature request discontiguous check

discontiguous directive is in the ISO core standard?
Sometimes it helps spot programming errors, like here:
union([X|L], R, S) :-
   contains(R, X), !,
   union(L, R, S).
union([X|L], T) :- !,
   T = [X|S],
   union(L, S).
union([], R, T) :- !,
   T = R.

But TauProlog accepts it without any warning:
?- consult
parsing program: ok!

For example SWI-Prolog gives me this warning:
Warning: user://1:14:
Warning:    Clauses of union/3 are not together in the source-file
Warning:    Earlier definition at user://1:8
Warning:    Current predicate: union/2
Warning:    Use :- discontiguous union/3. to suppress this message

GNU Prolog is even more strict, it drops some clause, possibly not recommended:
user:7-8: warning: discontiguous predicate union/3 - clause ignored


BugFix: possibly issue with unexpected server response

previous bugfix unit test

It seems Static analysis and coe style checker has been failed.
Could you please check this issue?
https://github.com/Samsung/CredSweeper/runs/7065022158?check_suite_focus=true

@csh519 static analysis issues were fixed


How to use @module (with sub-modules)?

Question
I'm currently documenting an older project, which features a quite nested structure.
My idea is to declare nested modules, i.e. '/classes', '/classes/users', '/classes/users/resolvers', ...
To achieve this, I tried to use the '@module' tag and reproduce the example given in the documentation.
Here is a small excerpt of the code:
/**
 * This is the doc comment for thing1/functions.ts
 *
 * Specify this is a module comment and rename it to thing1:
 * @module thing1
 */
export * from "./thing1/functions";

From my understanding, this should create a module 'thing1', which holds everything, which is exported from the './thing/functions' TS file.
However, all the exported functions are simply added to the 'root' module, when looking at the generated ui.
I also created a reproduction here: https://github.com/Tobjoern/typedoc-module-repro
Since I'm new to the project, I most likely made some mistake in the setup.
My question is, how do I get the @module tag to work, and how can I most effectively display a deeply nested folder structure with typedoc?
Your help is highly appreciated.

This is not what @module is for, it is only for renaming an entry point which TypeDoc gets wrong.
You probably want
/**
 * Doc
 */
export * as thing1 from "./thing1/functions"

This is not what @module is for, it is only for renaming an entry point which TypeDoc gets wrong.
You probably want
/**
 * Doc
 */
export * as thing1 from "./thing1/functions"

Thanks for your help.
I adjusted the code in the way you described, but I still don't get the module 'thing1' to show up.

Going to need more info than that then.. seems to create a namespace for me.
diff --git a/src/index.ts b/src/index.ts
index 4595237..0207a39 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -9,8 +9,5 @@ export * from "./internals";

 /**
  * This is the doc comment for thing1/functions.ts
- *
- * Specify this is a module comment and rename it to thing1:
- * @module thing1
  */
-export * from "./thing1/functions";
\ No newline at end of file
+export * as thing1 from "./thing1/functions";

Alternatively, specifying multiple entry points:

diff --git a/src/index.ts b/src/index.ts
index 4595237..e4b7f59 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -7,10 +7,3 @@ export * from "./showcase";
 export * from "./reactComponents";
 export * from "./internals";

-/**
- * This is the doc comment for thing1/functions.ts
- *
- * Specify this is a module comment and rename it to thing1:
- * @module thing1
- */
-export * from "./thing1/functions";
\ No newline at end of file
diff --git a/src/thing1/functions.ts b/src/thing1/functions.ts
index 8296110..1d41dca 100644
--- a/src/thing1/functions.ts
+++ b/src/thing1/functions.ts
@@ -1,3 +1,5 @@
+/** @module thing1 */
+
 /**
  * Calculates the square root of a number.
  *
diff --git a/typedoc.json b/typedoc.json
index 184f569..16b38ec 100644
--- a/typedoc.json
+++ b/typedoc.json
@@ -2,7 +2,8 @@
     "$schema": "https://typedoc.org/schema.json",
     "name": "TypeDoc Example",
     "entryPoints": [
-        "./src"
+        "./src",
+	"./src/thing1/functions.ts"
     ],
     "sort": [
         "source-order"
@@ -23,4 +24,4 @@
     "sidebarLinks": {
         "API": "https://typedoc.org/api"
     },
-}
\ No newline at end of file
+}

Thanks, using named exports like
export * as thing1 from "./thing1/functions";
or
export * as subModule from './submodule/index'
Fixed the issue for me.


Chatterino plugin blocks new twitch menus

In the new twitch layout the chatterino plugin for chrome blocks the different menus. (Insead of disapearing when you click items on the top menu like it used to)
https://streamable.com/9wa11
Chatterino Nightly 2.1.5 (commit 367b1970f, 22.09.2019)

Fixed in extension 1.2.


Implement local server feature

Description
This PR will add the option to use Ferdi without an account by running a local, internal server.
This will implement the feature request #5.

@bittner relevant lines for the server start are https://github.com/getferdi/ferdi/blob/6bc3768dee8aa8cdc3794baf8227562d550b16d8/src/stores/SettingsStore.js#L59 and https://github.com/getferdi/ferdi/blob/6bc3768dee8aa8cdc3794baf8227562d550b16d8/src/electron/ipc-api/localServer.js#L29

The actual local server is located in https://github.com/getferdi/internal-server. The function to start the server is located inside start.js

I've successfully managed to log out and "Use Ferdi without an account" and import my services from the franzinfra server as mentioned above. :+1:
But it doesn't seem to be possible to switch back, i.e. enter the credentials of my Franz account to connect with the Franz server again. The settings keep saying, "You are using Ferdi without a server". Should I open an issue for that?


style: issues flagged by codefactor

fixing some stylistic issues flagged by https://www.codefactor.io/

@alexander-held I'd just ignore this as cabinetry is still small. I'd suggest that you add in a codecov.yml file to set a tolerance. pyhf set a tolerance of 0.2% total in pyhf PR 693.

@matthewfeickert thanks, that looks like a good solution.


FR - Backup to network shared folders

Hi,
Nice tool. Would be great to be able to backup to network shared folders.
I wanna backup my Databases from system 1 to my Synology NAS.
Greets
Peter

@poudenes There is a feature pending implementation that allows local backups, so you can mount the docker volume wherever you want, does this work for your requirement?
https://github.com/eduardolat/pgbackweb/issues/1

Duplicated of #1


Add new pose estimation test images.

Add license details for images to LICENSE.

Can you include the licensing info somewhere?

Thanks for the suggestions @leezu, added the licenses of the images that have one.

Thank you @josephevans. I'm not sure if we can use images without license, as we may first need to seek permission from the author. WDYT?

When this is merged, the onnx tests will start failing. I will open a PR with updated URLs as soon as this is merged.

Why did we not first fix the tests


Add aspire component template

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
Currently there's distinction between external components and internal projects, in a microservice setting you most likely don't have all the services inside the same solution. A "component template" or "external project" would fill this gap where a service is being developed that others can connect and interact with.
Describe the solution you'd like
The template would be set up in such a way that it can be packaged for other services to depend on. Just like components, these services could be hosted locally or connect to a live instance.
Additional context
Note this is a rough idea perhaps there's a way to do this today but I think it's worth considering it as a first-class building block.

Let me know if I am interpreting this correctly: You want to be able to package up a project as an aspire resource and have other services on the team use it?


examples/mesh/ip_internal_network: Use of 'if_desc' to distinguish between esp_netif configurations (IDFGH-13312)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
In mesh_netif.c, the logic within several functions distinguishes between different configurations of netif_sta through comparison of its if_desc property.  This property can only be set, however, through the esp_netif_config_t structure at the time of calling esp_netif_new(), and is immutable afterwards.
If one is to create a valid driver control block for the Mesh netif, though, one does not have access to if_desc through public APIs until after esp_netif_new() has already been called within the ESP-WIFI-MESH library routines.
Either the logic within mesh_netif.c must be updated to not distinguish netif_sta via if_desc, or the corresponding Mesh library routines must be publicly-accessible, as they are today with WiFi.

@vjgriswold Thanks for report, we will check it ASAP.

@vjgriswold I don't think there is an issue with the netif operation in the example.

The use of if_desc in this example is valid only if a correct device control block can be created at the same time.  Given that the layout of the Mesh device control block is opaque, that is not possible.  Thus, there is insufficient visibility into the prerequisite data structures to use if_desc for this purpose.

@vjgriswold
The mesh_netif.c is only used in the ip_internal_network, the underlying logic is still based on the WiFi netif, the example only modifies some driver functions.


ENH: Implement Gaussian Process

Implement Gaussian Process.

I made a draft PR on @jhlegarreta 's fork here https://github.com/jhlegarreta/eddymotion/pull/1
I updated calculate_angle_matrix in src/eddymotion/model/utils.py
but I realize that my PR has some conflicts that need to be merged due to the latest updates in nippers/eddymotion. It's probably too much work to merge such huge conflicts just for one function.
I explained to Jon why I updated the function so Jon can decide whether you want to adopt the changes (by copying it from the link above)
Regarding compute_multi_shell_covariance_matrix, I tried to work on it but had some problems

the input parameters in the current version of the function is not complete, for example nvals and bvecs needs to be defined
also, the current calculate_angle_matrix only works for single-shell data, so we need to update this function first and then call it in compute_multi_shell_covariance_matrix
also, make sure we are consistent on whether to use k as input in those covariance matrices or initiate k within the function.
Some parameter names are not consistent. For example, theta should be angle_mat, but we use different names across functions.

Thank you, @jhlegarreta, for explaining everything to me and getting me started on this work (which is different from what I've done before). I'm happy to contribute more in the future if needed.

Re https://github.com/nipreps/eddymotion/pull/188#pullrequestreview-2104702667 agreed.
Have done a local copy of the old file to add a documentation file as time permits. For now,

This reduces the whole thing to making the prediction.
Have removed all duplicates that this had after having split the contents across multiple PRs (some already merged, others being reviewed, etc.)

Will improve things in subsequent commits: actually use the DWI data, use bvec indexing, etc.

Have gone through the comments but I am hesitant about them:

Now I do see that we should not provide the diffusion signal to the __init__ method. At least not at this stage of the development.
Re https://github.com/nipreps/eddymotion/pull/188#discussion_r1638260136 https://github.com/nipreps/eddymotion/pull/188#discussion_r1640215088 I think here we are back to the discussion about our data: reconstructing the 3D volume in here means that the fit/predict method get the entire data, which is unfeasible given the size. As I see things, reconstructing the 3D volume should be done in the caller. Best would be to discuss this over a call.

Now I do see that we should not provide the diffusion signal to the __init__ method. At least not at this stage of the development.

👍

Re https://github.com/nipreps/eddymotion/pull/188#discussion_r1638260136 https://github.com/nipreps/eddymotion/pull/188#discussion_r1640215088 I think here we are back to the discussion about our data: reconstructing the 3D volume in here means that the fit/predict method get the entire data, which is unfeasible given the size. As I see things, reconstructing the 3D volume should be done in the caller. Best would be to discuss this over a call.

Happy to have a call, but IMHO, this is an 'eddymotion' model -- meaning, we define the interface. All other models generate volumes as the output of their predict(), so this needs to be another one. Perhaps what's missing here is an 'intermediate' model (which could eventually go into DIPY, cc/ @arokem) where the output would be consistent with the standard GP output (i.e., a mean and std functions).

Happy to have a call, but IMHO, this is an 'eddymotion' model -- meaning, we define the interface. All other models generate volumes as the output of their predict(), so this needs to be another one. Perhaps what's missing here is an 'intermediate' model (which could eventually go into DIPY, cc/ @arokem) where the output would be consistent with the standard GP output (i.e., a mean and std functions).

OK. I see that. So the input will need to be the entire DWI image then. We'll then need to figure out how this can be dealt with within the model. DIPY may give us clues, yes. For now, I do not see how/have not digged into it.
It can still be tested in its current form (without additional strategies, running into memory issues, etc.) with https://github.com/nipreps/eddymotion/blob/a8742d955d9a43676d54ef194737a42db6f74015/docs/notebooks/dwi_simulated_gp.ipynb

On Mon, Jun 17, 2024 at 5:23 AM Jon Haitz Legarreta Gorroño <
@.***> wrote:

Happy to have a call, but IMHO, this is an 'eddymotion' model -- meaning,
we define the interface. All other models generate volumes as the output of
their predict(), so this needs to be another one. Perhaps what's missing
here is an 'intermediate' model (which could eventually go into DIPY, cc/
@arokem https://github.com/arokem) where the output would be consistent
with the standard GP output (i.e., a mean and std functions).
OK. I see that. So the input will need to be the entire DWI image then.
We'll then need to figure out how this can be dealt with within the model.
DIPY may give us clues, yes. For now, I do not see how/have not digged into
it.

If you are implementing a new DIPY-style model here it would be best to
inherit from ‘ReconstModel’ and ‘ReconstFit’, which can take care of some
of the dispatch and will take care of parallelization once
https://github.com/dipy/dipy/pull/2593 is merged.

It can still be tested in its current form (without additional strategies,
running into memory issues, etc.) with
https://github.com/nipreps/eddymotion/blob/a8742d955d9a43676d54ef194737a42db6f74015/docs/notebooks/dwi_simulated_gp.ipynb
—
Reply to this email directly, view it on GitHub
https://github.com/nipreps/eddymotion/pull/188#issuecomment-2173256998,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA46NQVYLDA4AEG6FG5FJLZH3INDAVCNFSM6AAAAABHHZJANSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGI2TMOJZHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@oesteban Please check the following in commit 5bdff10:

https://github.com/nipreps/eddymotion/pull/188/commits/5bdff10782e123a34927b41329d3a23c2d4691ab#diff-fba3c6e90b496595a3cd3cdcbd5d562082cde0b4f21629d667d1a2260a91bd37L67
https://github.com/nipreps/eddymotion/pull/188/commits/5bdff10782e123a34927b41329d3a23c2d4691ab#diff-fba3c6e90b496595a3cd3cdcbd5d562082cde0b4f21629d667d1a2260a91bd37R191

I just made it such that the test passes, but it may not fit into what you had envisioned (especially the latter, which will probably fail when giving it real data/using a mask).


Readme badges pointing at wrong repository.

This is a schoolboy Copy and Paste error!!!

Badge references updated and now working as expected!


feat(params): simplify GHA workflow inputs to require only PIPELINE_NAME and SERIALIZED_VARIABLES

simplify GHA workflow inputs to require only PIPELINE_NAME and SERIALIZED_VARIABLES
all other params will be stored inside SERIALIZED_VARIABLES and can be used as ${{ env.PARAM }}

:tada: This PR is included in version 1.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


FE: Create a register page with the register form

https://github.com/sopra-fs24-group-22/Let-Them-Cook/commit/333efb17ae284627a8e2e2483734765e2df3cb94


Clee/update colors

Description
MA-2455
Addressing feedback from QA.
The Discussions post to add a post/response/comment changed color. This PR addresses the change.
@lizcohen I'm trying to follow the discussions UI patterns in https://openedx.atlassian.net/wiki/display/MA/Mobile+Discussions+UI+fixes and I noticed that the original (below) text and button color are not a11y friendly for contrast ratio.
Original:

Reviewers
If you've been tagged for review, please check your corresponding box once you've given the :+1:.

[ ] Code review:
[ ] Code review:
[ ] UX review: @lizcohen

Had an offline conversation with @lizcohen. Turns out that the button in the new design is not supposed to be light blue at all.

Current coverage is 19.08% (diff: 100%)

Merging #840 into master will decrease coverage by 0.01%

@@             master       #840   diff @@
==========================================
  Files           465        465
  Lines         19756      19756
  Methods           0          0
  Messages          0          0
  Branches       2868       2868
==========================================
- Hits           3773       3771     -2
- Misses        15540      15542     +2
  Partials        443        443

Powered by Codecov. Last update aebc3f5...8731899


build: remove unused lib/libc/minimal/source/CMakeLists.txt

lib/libc/minimal/source/CMakeLists.txt was introduced in 12f8f7616 but
it is not used by the build system.  CMakeLists.txt in the parent dir
lib/libc/minimal/CMakeLists.txt adds C files to the target with the
lines like:
${CMAKE_CURRENT_SOURCE_DIR}/source/stdlib/atoi.c
${CMAKE_CURRENT_SOURCE_DIR}/source/stdlib/strtol.c

Codecov Report

Merging #8195 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8195      +/-   ##
==========================================
- Coverage   64.53%   64.53%   -0.01%
==========================================
  Files         420      420
  Lines       40101    40101
  Branches     6762     6762
==========================================
- Hits        25881    25880       -1
- Misses      11103    11104       +1
  Partials     3117     3117

Impacted Files
Coverage Δ

samples/philosophers/src/main.c
96.87% <0%> (-1.57%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265f502...210cfc0. Read the comment docs.

Thank you for pointing it out.  There is a few other empty CMakeLists.txt in the repository.  Would you want me to remove those, too?  Or is there any reason to keep them around?
$ find * -empty -type f -name 'CMakeLists.txt'
arch/nios2/soc/nios2-qemu/CMakeLists.txt
arch/nios2/soc/nios2f-zephyr/CMakeLists.txt
arch/xtensa/soc/sample_controller/CMakeLists.txt
lib/libc/minimal/source/stdout/CMakeLists.txt

The build system requires certain CMakeLists.txt files to be present, which is why for instance this file
arch/nios2/soc/nios2-qemu/CMakeLists.txt
needs to be present, but empty.
Perhaps it should have had a comment,
intentionally left empty
If you can find any empty CMakeLists.txt files that are not required by the build system then they are safe to remove.

@SebastianBoe That's good to know.  Do you want me to add the comment to the empty files?

@SebastianBoe That's good to know. Do you want me to add the comment to the empty files?

Sure.

Updated the patch to add the comment in the files.

LGTM

@nashif : Your review feedback has been addressed.


Is there a plan for a new release?

The last release (19.0.8) is from over a year ago. It would be useful for us to have a release in bower with the fix in commit #2011

A new version for Christmas ? :santa:

This would be useful for me also.


Workaround for no Automatic Migrations [Question]

How to run migration without restart application?
I'm creating migration with this code:
var history = this.GetInfrastructure().GetService();
            var options = this.GetInfrastructure().GetService();
            var migrate = this.GetInfrastructure().GetService();
            var modelDiffer = this.GetInfrastructure().GetService();
            var providerServices = this.GetInfrastructure().GetService();

            var idGenerator = new MigrationsIdGenerator();
            var code = new CSharpHelper();
            var c = new MigrationsScaffolder(
                 this,
                 this.Model,
                 new MigrationsAssembly(
                     this,
                     options,
                     idGenerator),
                 modelDiffer,
                 idGenerator,
                 new CSharpMigrationsGenerator(code, new CSharpMigrationOperationGenerator(code), new CSharpSnapshotGenerator(code)),
                 history,
                 new LoggerFactory(),
                 providerServices);
            var migratename = Guid.NewGuid().ToString();
            var m = c.ScaffoldMigration(migratename, this.GetType().Namespace);
but i need to execute this Migration at runtime.
@bricelam @mikary @rowanmiller

repro is there: http://www.megafileupload.com/5uoo/ContentStore.rar

Could you describe more about the scenario you're trying to enable? How does the model change at runtime? Could you simply drop and recreate the database schema? Would EF6's automatic migrations be more appropriate for your application?

@bricelam I want automatic migration on Model Changing. If i add some property of model i want to change also Db table.

Hmm... I believe this goes against our current design of the Migrations feature in EF7. If you really want to, you could write some code to compile the generated *.cs files into a dynamic assembly, create a custom implementation of IMigrationsAssembly that also looks at the types in that assembly, then use Migrator to apply the migration at runtime...
However, my recommendation would be to either...

Use EF6
Change your development workflow to ensure there aren't any pending model changes. This could be done in a variety of ways:

A unit test
A build task
An exception during app start

The ASP.NET 5 EntityFramework error page includes code to check for pending model changes.

@bricelam I'm generation migration (*.cs) with MigrationsScaffolder.Save() but this cs is not loaded in Assembly. Can you give me some example how to do?

I did but problem is also migration. First i create News Table after that i removed one property (Column) from this model and migration can't do operation.
Repro: https://www.mediafire.com/?digit4g5xr1a6x8

An exception of type 'System.Data.SqlClient.SqlException' occurred in EntityFramework.Relational.dll but was not handled in user code

Additional information: There is already an object named 'News' in the database.

Discussed in team triage and we concluded that we do not want to support automatic migration scenarios in EF7. We saw them cause lots of headaches for folks in EF4.1-6 where they handled the first few scenarios ok but then just break down as things get more complex.
As noted in this issue, it should be possible to plug all the migrations components together to do something similar if you really want to (though we would advise against it unless your scenarios are limited to adding new properties).
While attempting to do this, if you hit cases where APIs need to be reworked to facilitate the scenario, then we'd be happy to take specific issue where we can change things (or feel free to submit a pull request for them).


Update Unbound Documentation URL

The old URL gets redirected to the start page of Unbounds documentation, this one directly links to the local-zone part of the "new" unbound.conf documentation.

@xorbital thanks!

@xorbital thanks!


Implement: /datasets/{dataset_id}/versions

What is the rationale for returning a dictionary rather than an array?
{'datasets': [{'assay': [{'label': "10x 3' v2",
An array would be similar to how we already return responses for similar patterns like GET collections.


Add better clientside defaults

On the client, we need to check if cheats are enabled and if so set the permission default for the server owner to true -- this way we match vanilla MC behavior and make it simpler for people setting up a LAN server to work with permissions without having to manually edit config files (since there isn't an interactive server console or anything).
This would be set in transient data in (probably) ServerStartingEvent if the game is on the client.

Perhaps the default configuration can have a srcip=<IP_ADDRESS> context that sets all permissions to true? (once that gets implemented in Sponge)

Ok, I think this should be resolved by 83d3a4a497f55bc0b934ed03f32cb6eb4eb158b3


[ISSUE #5631]optimize ReplicasInfoManager#registerBroker logic

Make sure set the target branch to develop
What is the purpose of the change
Fix #5631
Brief changelog

Fix ReplicasInfoManager#registerBroker not check master is alive

Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #5633 (99bba01) into develop (e5fadc7) will decrease coverage by 0.00%.
The diff coverage is 57.89%.

@@              Coverage Diff              @@
##             develop    #5633      +/-   ##
=============================================
- Coverage      42.39%   42.38%   -0.01%
- Complexity      7967     7971       +4
=============================================
  Files           1023     1023
  Lines          71479    71493      +14
  Branches        9444     9449       +5
=============================================
- Hits           30305    30304       -1
- Misses         37332    37344      +12
- Partials        3842     3845       +3

Impacted Files
Coverage Δ

...q/controller/impl/manager/ReplicasInfoManager.java
61.23% <55.55%> (-0.99%)
:arrow_down:

...he/rocketmq/controller/impl/DLedgerController.java
66.49% <100.00%> (ø)

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
80.35% <0.00%> (-5.36%)
:arrow_down:

...mq/broker/topic/TopicQueueMappingCleanService.java
12.43% <0.00%> (-3.63%)
:arrow_down:

...rocketmq/common/message/MessageClientIDSetter.java
71.42% <0.00%> (-2.39%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
60.43% <0.00%> (-2.20%)
:arrow_down:

...he/rocketmq/client/impl/consumer/ProcessQueue.java
61.50% <0.00%> (-0.89%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
34.53% <0.00%> (-0.56%)
:arrow_down:

...che/rocketmq/test/lmq/benchmark/BenchLmqStore.java
50.24% <0.00%> (-0.50%)
:arrow_down:

...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java
76.29% <0.00%> (-0.38%)
:arrow_down:

... and 11 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin PTAL~


Bug in CopyPasswordbox

After login and during the first click on an service item, the CopyPasswordbox doesn't load the PasswordSafetyChart correctly.

Currently no idea how to fix it.


Dynamically added edges can't be connected to the existing nodes

Describe the Bug
When adding nodes and edges dynamically to an existing graph, if new edges are connected to an existing node, they can't be displayed in the graph.
Please see details in the example provided below.
NOTE: This issue only occurs for custom nodes. If nodes are default nodes, edges will be added properly.
Your Example Website or App
https://stackblitz.com/edit/react-ts-f1vjjq?file=App.tsx
Steps to Reproduce the Bug or Issue

Go to the example page.
Click on the plus button next to Node 3.
New nodes (Node 3a and Node 3ab) and edges will show up. However, the edge btw node 3 and 3a is not displayed. There's a warning in the console log that says couldn't create edge for source handle id: undefined; edge id: e33a

Expected behavior
As a user, I expected all dynamically added edges to be successfully rendered in the existing graph. However, due to this issue, some edges are not displaying.
Screenshots or Videos
https://user-images.githubusercontent.com/2274728/155402302-f268cecb-16d6-47ee-9658-36e3d0e2b3c9.mov
Platform

OS: [macOS]
Browser: [Chrome]
Version: [98.0.4758.102]

Additional context
No response

I figured this out. In my example, I conditionally render component Handle in the custom component and this causes the issue.
To resolve the issue, I updated the custom component's definition to always render left and right handles and hide them visually by css visibility:hidden. Now the code works as expected.

Closing this one as it's not an issue anymore.


Connection to MySQL 8 failed - jdbc driver requires upgrade

In OCP 4 the mysql-persistent template provisions a MySQL 8.
However, the jdbc driver in the current released image is failing with:
Caused by: java.lang.NullPointerException
        at com.mysql.jdbc.ConnectionImpl.getServerCharset(ConnectionImpl.java:2997)
        at com.mysql.jdbc.MysqlIO.sendConnectionAttributes(MysqlIO.java:1934)

See https://bugs.mysql.com/bug.php?id=86221 for background
Downgrading MySQL to the lower version (5.7) fixes the issue.
But to support the default MySQL Version deployed throught he template, the jdbc connector should be upgraded.

I think we should create a OCP 4 Branch and update the driver in this version, what do you think @chrira ?

I think we should create a OCP 4 Branch and update the driver in this version, what do you think @chrira ?

Yes, that is a good idea.
Hibernate 5.3.1 should support MySQL 8.
Eventually updating SpringBoot can help.

should work now, can you verify @duritong ?

It does now work with ocp4 and MySql 8
Thanks!


CASMCMS-8087: Add BOSv2 support to cmsdev test tool

main backport of https://github.com/Cray-HPE/csm/pull/1201

Bringing in via another assets PR.


Refactor compatibility generation

Offshoot of #1163
After spending some time investigating #1162, I believe that some of the failing tests are correctly signaling new holes in our compatibility matrices. So while we could update the data files and get tests passing again (https://github.com/replicate/cog/pull/1169), I think we'll need to filter out those missing CUDA images.
This PR attempts to do this. It takes on a bigger refactoring than was necessary, based on a mistaken assumption about how I'd need to update the TF and Torch generator scripts to take CUDA image tags as arguments. It looks like we can filter in init instead, but we may want to stick with the refactoring anyway.

Fantastic. This is a big mess.
This reminded me of something rattling around in my brain: https://github.com/replicate/cog/issues/1171


[Event Request] CodeUnit 241 - Item Jnl.-Post - Code() - OnBeforeItemJnlPostBatch

Hello, would it be possible to have an event "OnBeforeItemJnlPostBatch" in Codeunit 241 "Item Jnl.-Post" , procedure Code(), with "ItemJnlLine" parameter Like this :

Cordially.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


updating Zowe CLI installation topics for Zowe V3

Describe your pull request here:
Updating the following topics for Zowe V3:

Installing Zowe client-side components (currently a sidebar header with no target content)
Zowe CLI

List the file(s) included in this PR: user-roadmap-zowe-cli.md, others
After creating the PR, follow the instructions in the comments.

Content LGTM, thanks @anaxceron - I noticed a couple of things regarding the admonition and link structure, so I've added comments where necessary.
I noticed that the "Zowe CLI installation" link under "Installing Zowe client-side components" points to user-guide/user-roadmap-zowe-cli.md, but the "Zowe Explorer" link points to getting-started/user-roadmap-zowe-explorer.md - is this intended?

Another great catch. Yep, our file architecture in the Zowe Docs repo, at times, follows really different rules. I wasn't around for all of this, or most of this, but I gotta assume it's got something to do w/ the different tools used before Docusaurus. I don't know what those tools were, but I do know that when we first started using Docusaurus, it required a major repository re-org. So I think you're seeing the remnants of that.
I've been loathe to organize our directories and file names b/c I was concerned about broken links, but now that @t1m0thyj has helped us figure out how to use redirects in Docusaurus, I'd like to take advantage of that redirect functionality to better organize our files. Something on the back burner for the future!


ERROR: "adb push" returned with value 1 in Linux Debian 12

I have read the [FAQ(https://github.com/Genymobile/scrcpy/blob/master/FAQ.md).
I have searched in existing issues but dont found my problema

Environment

OS: Debian 12 KDE
scrcpy version: 2.4
installation method: manual
device model: SAMSUNG A14
Android version: 14

scrcpy
scrcpy 2.4 https://github.com/Genymobile/scrcpy
INFO: ADB device found:
INFO:     -->   (usb)  R58W90HYG9K                     device  SM_A145M
adb: error: failed to copy '/usr/local/share/scrcpy/scrcpy-server' to '/data/local/tmp/scrcpy-server.jar': couldn't read from device
/usr/local/share/scrcpy/scrcpy-server: 0 files pushed, 0 skipped. 0.0 MB/s (69007 bytes in 5.002s)
ERROR: "adb push" returned with value 1
ERROR: Server connection failed
Thanks

https://github.com/Genymobile/scrcpy/issues/665


Fix dockerfile

This PR fixes the current Docerfile, and also adds a Dockerfile in apidocs/ to help rebuild the docs on a windows environment, where compiling bytewax is complicated

@konradsienkowski it should be the same dockerfile we tried on slack, but try this and let me know if it works.
You should only have to run ./pdocs.sh from the bytewax repository.


Check Ornament kits are included

Things like bounty hunter kits on items

robes of the eye are not

robes of the eye are not are now, still needs a full audit


[Question]How does Joern know if a function can call to another function?

why the result is empty?

why the result is empty?

because the sink is the method, not the call. Try to swap them

the result is as the same

why the result is empty?

because the sink is the method, not the call. Try to swap them

the result is as the same
image

the result is as the same

@yzn12345  Do you know why?

@duhang1996, I don't see any code snippet but in general the granularity of reachability detection is at the method parameter or call argument level.
So you can do
def source=cpg.method.parameter
def sink=cpg.call.argument

sink.reachableByFlows(source).p

reachableByFlows only for data flow analysis, in your case, you should use caller or callee to find your call path.


v2.3.0 always selects vibe-d:core instead of vibe-core

I had to comment out this line: https://github.com/mysql-d/mysql-native/commit/ec851956e579bab8d00b1ae89a5344a2babce2e3
Can we leave that commented out now, or is it absolutely needed?

Deprecation: the vibe-d:core package is deprecated and will be removed in January 2020. Please update your code to depend on vibe-core instead.

Yeah, that's the message that clued me in that it's not selecting the right core. But I didn't think to look at the date! Certainly, this needs to be fixed soon. Maybe a version 3 of mysql-native requires vibe-core and doesn't support vibe-d:core? @Abscissa any thoughts?

Been out-of-the-loop awhile as my day job got absurdly busy over the summer, so I haven't had a chance to refresh my memory on this stuff yet (plus I just got a new computer I'm still setting up) Things have mostly calmed back down now, so I should be able to dive back in again soon...
What I can say right now is this: My only concerns with this change are:

making sure not to break OSX in the process (I think this is the issue that caused the offending line to be added in the first place: https://github.com/vibe-d/vibe.d/issues/2155 ). And:

not breaking TOO much backwards compatibility. (I'm fine with a v3 that deprecates some older versions of dmd/vibe if necessary, depending how much).

What we need first is a simple PR that removes the offending line so travis-ci can tell us exactly what the breakages are (if any). Then we can go from there and either fix/deprecate those broken configurations as appropriate.

I'll make a simple removal PR and see what happens. I actually wanted to add a mechanism to clean up unused mysql connections, but I ran into this first (was developing using 2.2.1 which didn't have this issue).

I would say this is duplicate of #199

Now fixed. Mysqln master is now fully switched from "vibe-d:core" to "vibe-core".


[fix bug 1341584] Do not display groups with pending terms.

@johngian pretty please?

Coverage remained the same at 93.003% when pulling b277cafd66230df5c67effe01dfed67d231186af on akatsoulas:1341584-visible-pending-groups into c4595713a4973b645c482d967bb662e74c715be2 on mozilla:master.

Coverage remained the same at 93.003% when pulling 2315fdfd8a3e0724b46fddf4c3d8f227c99cbcf1 on akatsoulas:1341584-visible-pending-groups into c4595713a4973b645c482d967bb662e74c715be2 on mozilla:master.


Rename apps/portal/src/app/account/api-keys/use/page.mdx to apps/port…

…al/src/app/account/api-keys/use/git mv apps/portal/src/app/account/api-keys/use/page.mdx apps/portal/src/app/account/api-keys/use/lionsuncoin.mdx
Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR focuses on updating the page.mdx file in the use folder of the account API keys section.
Detailed summary

Updated content in the page.mdx file for account API keys usage instructions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}