calculatePostsToLoadCount() implementation

the function calculatePostsToLoadCount() have some problems because not calculate if a feed is reach the max posts.
Due to this limit if for example an RSS feed that have only 4 posts, and the limit is put to 20 the callback() function is never called even if there are no more feed to display.
the SocialFeedPost.prototype must be implented to execute fireCallback() function even if is not satisfied this:
if (loaded_post_count == posts_to_load_count) {
fireCallback();
}
this is due to the fact that posts_to_load_count, calculated by calculatePostsToLoadCount() rapresent the MAX feed to display and not the minimum.
if someone have implemented already such a modification please post the fix..
thank you so much

@HartLarsson I was wondering if it would make sense to count the number of requests to different services rather than the number of posts returned? That way you could still increment if the request failed and just skip over it, but you would have a reliable number of expected requests.

i'e tried the same fix applied to RSS feed suggested by https://github.com/DrJest here https://github.com/pavelk2/social-feed/pull/171/files/e20ede2011dcb24f1781c1c41f9a59112967403a#r59769682
                getPosts: function(json) {
                    if (json.query.count > 0 ){
						// fix rendering if posts_to_load_count is not reached
						if (json.query.count < options.rss.limit) posts_to_load_count -= options.rss.limit - json.query.count;

                        $.each(json.query.results.feed, function(index, element) {
                            var post = new SocialFeedPost('rss', Feed.rss.utility.unifyPostData(index, element));
                            post.render();
                        });
                    }
                },

and works as expected.
This could fix every problem or we can redesign as you told the whole rendering engine using your suggested method truncating if the limit is surpassed for every feed source.

Is there a way to do the fix for facebook, twitter etc.?

yes, there is already a pull request. https://github.com/pavelk2/social-feed/pull/173
You can check my repository version too, i've added many advanced features to the RSS part.

@HartLarsson thank you for your help ? :)
am I getting this right, that your pull request fixes only rss feed and #173 fixes the social feeds?
Im having the problem that the Callback isn't fired if there are not enough posts on Facebook - for example i want to pull 10 post but there are only 5..

Please check my repository where i forked the pavel version: https://github.com/HartLarsson/social-feed

Thank you so much! It works!

@HartLarsson That doesn't work for me with the "-render" version (blank screen) and with your updated socialfeed.js I always get
TypeError: json.query.results is null $.each(json.query.results.feed, function(index, element) {
See http://peleke.diphda.uberspace.de/bower_components/social-feed/
(Currently that page looks bad because I tried to use Swiper for horizontal swiping without success)

there is an error on acces_token of facebook, normally must be "APP_ID|APP_SECRET" while yours seems is composed by the APP_SECRET only
RSS 2 feed need to have a limit value > 0
i've tested your TWITTER, RSS & Instagram and all works using my jquery.socialfeed-render.js version:
http://grabilla.com/06709-119fc57d-b0a6-4272-8dbf-0ffbfe4ee3ad.png

facebook "@fniedernolte" MUST BE A FACEBOOK PAGE not a PROFILE PAGE


Add to video

Great work!
I see that it takes audio as input for generating the subtitles.
I'm hoping if there is possibility of using this for full video subtitle.
The workload would be to convert the video to audio, generate the subtitles and then add it to the original video

Might not be clear from the documentation but it should be able to consume a video file.

Here is a working example where video (HLS stream) is the input: https://eyevinntechnology.medium.com/transcribe-with-open-ai-whisper-and-open-source-cloud-b2e6a3e7a607

@birme how can this be run in app not as a cli command?


Paginators should respect the page size limits of operations, and should clamp the user's request for page sizes outside of the limits.

Describe the bug
When setting a PageSize for a PaginatorConfig, botocore should respect the min/max limits if they exist in the metadata of the limit key.
If a user requests a PageSize outside the bounds, it should be constrained to be in bounds.
Expected Behavior
I expected a request for 10,000 items per page to be clamped to the limit of the operation's limit_key.
Current Behavior
No clamping is done of the page value and the API request fails because the requested number of items is greater than what the API can provide.
Reproduction Steps
See PR
Possible Solution
See PR https://github.com/boto/botocore/pull/3259
Additional Information/Context
No response
SDK version used
1.35.5
Environment details (OS name and version, etc.)
Mac OS X

Thanks for reaching out and creating that PR. Unfortunately we cannot accept the PR, because we do not do client-side validation on the pagination parameters — those are validated by service APIs. For example:

botocore.exceptions.ClientError: An error occurred (ValidationException) when calling the ListTables operation: 1 validation error detected: Value '200' at 'limit' failed to satisfy constraint: Member must have value less than or equal to 100

Also as noted in the other issue you opened, there are some inconsistencies among service API models. There are no plans to change the existing behavior here.


[Bug]: Error When Adding a User to an Organizaion Using Firefox Browser

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When trying to add a user to the organization, an error is received on Firefox. The "Oops! Something went wrong" page is displayed.

Environment:
Firefox 98.0.2, on Ubuntu Linux 20.04
Steps To Reproduce

In the 'dashboard'/home page, click the Share button.
Enter an email address.
Try to 'choose a role'.

Result: able to choose a role, but getting an "Oops! Something went wrong" page.
Public Sample App
No response
Version
Self Hosted

@ame-appsmith this seems to be working for me. Please share a video on how to reproduce this

@ame-appsmith this seems to be working for me. Please share a video on how to reproduce this

@ame-appsmith Same here.

@ame-appsmith This is still happening for me with Appsmith Community v1.9.10 and Firefox v111 on Pop!_OS 22.04 LTS. Screen shots and video provided below:

Screencast from 03-27-2023 09:59:17 AM.webm

After a little debugging, I found the issue was caused by a Firefox extension (specifically firefox relay) adding extra elements in the email box. Once I disabled the extension if works in Firefox now.


Fixing the imports failures happening due to changes in OpenSearch Core.

Description
Fixing the imports failures happening due to changes in OpenSearch Core and removed some forbidden apis.
Issues Resolved
NA
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The BWC tests rolling upgrade is only failing for Java 17. Will do more deep-dive to see what is happening.
Error Log:
WARN ][r.suppressed             ] [knnBwcCluster-rolling-0] path: /_cluster/health, params: {wait_for_status=yellow, wait_for_nodes=>=3}
»  org.opensearch.discovery.ClusterManagerNotDiscoveredException: null
»  	at org.opensearch.action.support.clustermanager.TransportClusterManagerNodeAction$AsyncSingleAction$2.onTimeout(TransportClusterManagerNodeAction.java:348) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:394) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.cluster.ClusterStateObserver$ObserverClusterStateListener.onTimeout(ClusterStateObserver.java:294) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.cluster.service.ClusterApplierService$NotifyTimeout.run(ClusterApplierService.java:707) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:747) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
»  	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
»  	at java.lang.Thread.run(Thread.java:833) [?:?]
»   ↑ repeated 2 times ↑

The BWC tests rolling upgrade is only failing for Java 17. Will do more deep-dive to see what is happening.
Error Log:
WARN ][r.suppressed             ] [knnBwcCluster-rolling-0] path: /_cluster/health, params: {wait_for_status=yellow, wait_for_nodes=>=3}
»  org.opensearch.discovery.ClusterManagerNotDiscoveredException: null
»  	at org.opensearch.action.support.clustermanager.TransportClusterManagerNodeAction$AsyncSingleAction$2.onTimeout(TransportClusterManagerNodeAction.java:348) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:394) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.cluster.ClusterStateObserver$ObserverClusterStateListener.onTimeout(ClusterStateObserver.java:294) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.cluster.service.ClusterApplierService$NotifyTimeout.run(ClusterApplierService.java:707) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:747) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
»  	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
»  	at java.lang.Thread.run(Thread.java:833) [?:?]
»   ↑ repeated 2 times ↑

It is not just for Java 17. The Rolling Upgrade BWC Tests are failing for both Java 11 and Java 17. I think the OpenSearch cluster is looking for upgrade from 2.7.0 to 3.0.0. But, we are doing it from 2.6.0.

I have already created a PR to fix these changes https://github.com/opensearch-project/k-NN/pull/777

I have already created a PR to fix these changes #777

I didn't see it. Actually the problem is because of k-NN issue Neural Search plugin build is also failing.

I have already created a PR to fix these changes #777

I didn't see it. Actually the problem is because of k-NN issue Neural Search plugin build is also failing.

Agree. I think we can skip these failing Rolling Upgrade Tests and merge the PR to fix the failing build and unblocking neural search plugin because anyways the error is not related to these changes.

The BWC tests rolling upgrade is only failing for Java 17. Will do more deep-dive to see what is happening.
Error Log:
WARN ][r.suppressed             ] [knnBwcCluster-rolling-0] path: /_cluster/health, params: {wait_for_status=yellow, wait_for_nodes=>=3}
»  org.opensearch.discovery.ClusterManagerNotDiscoveredException: null
»  	at org.opensearch.action.support.clustermanager.TransportClusterManagerNodeAction$AsyncSingleAction$2.onTimeout(TransportClusterManagerNodeAction.java:348) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:394) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.cluster.ClusterStateObserver$ObserverClusterStateListener.onTimeout(ClusterStateObserver.java:294) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.cluster.service.ClusterApplierService$NotifyTimeout.run(ClusterApplierService.java:707) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:747) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
»  	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
»  	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
»  	at java.lang.Thread.run(Thread.java:833) [?:?]
»   ↑ repeated 2 times ↑

This will be fixed when we will have a 2.7 artifact available for k-NN and we update the Rolling upgrade tests to 2.7 version. Reason why we need 2.7 : https://github.com/opensearch-project/OpenSearch/issues/3615#issuecomment-1247544266


add more data type tests for batch write

fix #830 , #841

add data type tests for batch write
fix bug that batch write can not write into a table which use enum as its pk or unique key

rebase https://github.com/pingcap/tispark/pull/843 to let ci success

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests


Parsing and docs error for command: <%QUERYBUILDER%>

According to the docs, the second argument for the <%QUERYBUILDER%> command is for the output format, which is not always the case.
Overview of issue
If the second argument is one of the predefined output formats (i.e., {text} or {uid}), the command will return the first selection (i.e., column) of the Query in that format.
However, if you pass the name of any other selection as the second argument - or the first selection if it's been renamed - the command will return the {text} of that selection.
Secondary issue
When purposefully passing a selection - and not an output format - as the second argument, the command does not parse the <%GET%> command.
Returns the uid of the first selection, regardless of it's name
<%QUERYBUILDER:queryId,{uid}%>

Returns undefined even when columnName is set to a selection found on the query
<%QUERYBUILDER:queryId,{<%GET:columnName%>}%>

Returns the text of the "Client" selection, regardless of it's position
<%QUERYBUILDER:queryId,{Client}%>

Proposed solution
Update the command to take 4 arguments:

Block ref or alias
Format of output
Selection (default to Text)
Number of results

Ensure the arguments are parsed before the command is run so <%GET%> can be used for any of the arguments

Thank you for the report @MarketHubb!
First Issue
In terms of the first issue, I believe the output format is intended to support a wide range of use cases and not limited to just the predefined output formats.
For example, the following would be valid (where {description} is the title of the second column (selection)):
<%QUERYBUILDER:myQuery,The Result is {text} - {description}%>
Secondary Issue
Similarly, regarding the Secondary Issue, it seems that SmartBlock commands are intended to be accepted in the output format so that they may be applied to the output itself.  Which is why the SmartBlock commands in the arguments are explicitly delayed.  For example:
<%QUERYBUILDER:myQueryBlock,Random Block from {text}: <%RANDOMBLOCKFROM:{uid}%>%>
<%GET%>
There is, however, an undocumented feature that could solve the <%GET%> issue for you.  The second argument actually accepts a block reference.  If the second argument is just a block reference, it will use that block as the output format.  And in that block you may use SmartBlock Commands.
eg:
<%QUERYBUILDER:myQuery,((ITe51brrn))%>
- Title:: <%GET:text%>
  - Description:: <%GET:description%>

To handle your use case you would wrap the variable set to the column name in another <%GET%>, eg:
- <%GET:<%GET:columnNameVar%>%>
More info here:
https://www.loom.com/share/d0492dfdbe5f4e89a4b996fe85c7317b
Selection uid
While not explicitly mentioned, in case you would like to return a selection uid instead of text, you can actually append -uid to the column name, eg: {columnName-uid} or <%GET:columName-uid%> if the second argument is a block reference. (and <%GET:<%GET:columnNameVar%>-uid%> if you are passing the column name as a variable.
Additional Remarks
I know there is a lot going on here and it can be quite convoluted.  😅  If anything isn't clear or if you have any additional questions, don't hesitate to let me know.  Otherwise feel free to close this issue.
I'll see to it that the Query Builder docs get updated to reflect some of the more standard and undocumented features that I've laid out here.


JavaDoc code snippets update for all builders and sync Clients

This is the first part to update code snippets

/check-enforcer evaluate


Changing to not update timestamps when scaning or querying with filter

Summary:

Code sample:
General
'use strict';

const dynamoose = require('dynamoose');
const uuidv4 = require('uuid/v4');

const sample = dynamoose.model(process.env.SAMPLE_TABLE, {
  id: {
    type: String,
    hashKey: true,
    trim: true,
  },
}, {
  timestamps: {
    createdAt: 'created_at',
    updatedAt: 'updated_at',
  },
});

dynamoose.AWS.config.update({
  accessKeyId: process.env.AKID,
  secretAccessKey: process.env.SECRET,
});

const main = async () => {
  // create records
  for (let i = 0; i < 10; i++) {
    const record = {
      id: uuidv4(),
    };

    await new sample(record).save();
  }

  // scan all records
  const allRecords = await sample.scan().all(0).exec();
  console.log('Count(all): ' + allRecords.length);

  // filter by created_at
  const tenMinAgo = new Date().getTime() - 10 * 60 * 1000;
  const createdFilter = {
    created_at: { gt: tenMinAgo },
  }
  const createdFilterRecords = await sample.scan(createdFilter).all(0).exec();
  console.log('Count(createdFilter): ' + createdFilterRecords.length);

  // filter by updated_at
  const updatedFilter = {
    updated_at: { gt: tenMinAgo },
  }
  const updatedFilterRecords = await sample.scan(updatedFilter).all(0).exec();
  console.log('Count(updatedFilter): ' + updatedFilterRecords.length);
};

main();

GitHub linked issue:
Closes #508
Type (select 1):

[x] Bug fix
[ ] Feature implementation
[ ] Documentation improvement
[ ] Testing improvement
[ ] Test added to report bug (GitHub issue #--- @---)
[ ] Something not listed here

Is this a breaking change? (select 1):

[ ] 🚨 YES 🚨
[x] No
[ ] I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

[x] Yes
[ ] No

Are all the tests currently passing on this PR? (select 1):

[x] Yes
[ ] No

Other:

[x] I have searched through the GitHub pull requests to ensure this PR has not already been submitted
[x] I have updated the Dynamoose documentation (if required) given the changes I made
[x] I have added/updated the Dynamoose test cases (if required) given the changes I made
[x] I have run npm test from the root of the project directory to ensure all tests continue to pass
[x] I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
[x] All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
[x] I have confirmed that all my code changes are indented properly using 2 spaces
[x] I have filled out all fields above

Pull Request Test Coverage Report for Build 812

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 85.634%

Totals

Change from base Build 810:
0.1%

Covered Lines:
2185

Relevant Lines:
2477

💛  - Coveralls

@tomofumi0003 Did you get around to testing this PR?

@fishcharlie I have confirmed your code. It seems to be fine. Is there something I should do?

@tomofumi0003 Nope. Just since you reported the issue I wanted you to verify it. It'll get released in the next version 😃

@fishcharlie :thumbsup:

@devotox Umm, yeah I think that makes sense at first thought. Wanna create a PR for that?


How to make some convolution weights same in a network

shared_weight = mx.sym.Variable("shared_weight", shape=(3, 64, 3, 3))
conv1 = mx.sym.Convolution(data=data, weight=shared_weight, name="conv1", ...)
conv2 = mx.sym.Convolution(data=conv1, weight=shared_weight, name="conv2",...)

@zhreshold Thank you

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!


'dotnet msbuild /pp' fails to display errors  in dotnet sdk 2.1.5

Steps to reproduce
Project file (DotNetCoreTestApp.csproj)
INVALID XML FILE
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp2.1</TargetFramework>
  </PropertyGroup>

</Project>

Directory contents:
/
- DotNetCoreTestApp.csproj

Command line
dotnet msbuild /pp:msbuild.xml DotNetCoreTestApp.csproj

Expected  behavior
The command should print an error message to stderror or stdout.
Actual behavior
No output is printed at all. The output file is created but empty. Exit code is 1.
For comparison, this is the output from an older version of msbuild.exe:
DotNetCoreTestApp.csproj(1,1): error MSB4025: The project file could not be loaded. Data at the root level is invalid. Line 1, position 1.

Environment data
dotnet msbuild /version output:
Microsoft (R) Build Engine version 15.9.20+g88f5fadfbe for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.
<IP_ADDRESS>856

Looks like full-framework MSBuild does the same thing:
s:\msbuild>msbuild build.cmd /pp:out

s:\msbuild>echo %ERRORLEVEL%
1

and it's regressed since 4.5:
s:\msbuild>C:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe build.cmd /pp:out
s:\msbuild\build.cmd(1,1): error MSB4025: The project file could not be loaded. Data at the root level is invalid. Line
 1, position 1.


D3

Hey,
I was wondering why this package has "d3" in its name. Is it somehow related to d3.js?

Hi Moritz,
Yes, that was the original intent! I wanted to follow Mike Bostock's "Let's make a D3 plugin" article while building this library.
So although it doesn't have any d3 dependencies atm, I think it can be thought of similarly to the d3-array module. I tried to follow a similar pattern of coding.
Here is an example of using it with d3js.

that was fast ;) I am maintaining a list with d3 plugins. That's why I am asking. I will put it under "utils". Even if it is not directly related to d3 there are a lot of use cases to use it with d3.

Thanks! I'll close the issue now if that's okay :)

sure. Thanks :+1:


workerLib's spawn should preserve the environment

Hello,
Working on NixOS, it is extremely bad that atom-typescript overwrites the environment of the process when calling spawn.
In particular, the child process fails to spawn as it cannot find libgtk-x11.
This patch attempts to solve this issue by only overriding the existing environment.
What is the policy with regards to pull requests? I notice the dist/ repository is tracked, which is weird, but I guess it's useful for bootstrapping?
Best regards,

What is the policy with regards to pull requests? I notice the dist/ repository is tracked, which is weird, but I guess it's useful for bootstrapping?

Its because atom packages are git tags ... and if the .js resources aren't there in github package will not work :-/ :rose:

Released as a minor update : https://github.com/TypeStrong/atom-typescript/releases/tag/v7.5.0 :rose:


Slice fields not showing correct language

Plugin Version: 1.0.0-alpha.5
Thanks for making this plugin! I've been testing it out on a site that involves localization and am noticing that slice fields aren't showing the correct translations.
Here's an example query:
{
  allPrismicHomepage(filter: {lang: {eq: "es-es"}}) {
    edges {
      node {
        id
        lang
        data {
          page_title {
            text
          }
          body {
            ... on PrismicHomepageBodyText {
              primary {
                text {
                  text
                }
              }
            }
          }
        }
      }
    }
  }
}

What I'm observing is that lang is showing es-es and page_title.text is showing the Spanish translation, but body[0].primary.text.text is showing the English translation.
I believe this is an artifact of the new type system for slice fields. It wasn't an issue with the previous version of this plugin.

Thanks for bringing this up! I plan to work on the plugin this weekend, so I’ll take a look. 👍

You're definitely right that it's an artifact with the slice fields type system.
The plugin iterates through each slice and creates a new node with a namespaced type. Since nodes require an ID, and slices do not have an ID, I set the ID as the index of the slice. This works fine for the first document node that is created, but causes issues for the next one since they share an ID.
See the line here: https://github.com/angeloashmore/gatsby-source-prismic/blob/8120bf5c48ecfec97c6114e9b639d205713c34b0/src/normalize.js#L74
The solution, I think, is to use the parent node's ID as a namespace for the ID. I'll push an update in a sec.

Fix confirmed! Thanks for the quick response. 🥇

Awesome! Glad to hear it's working.


reconciling Snippet type that comes from Props and Component Type

probably not the best title, so I'll explain with an example.
I'm currently working on a port of drei's CubeCamera. They allow for a function to be used as a child and that child will get passed the render target texture. We don't have this in svelte but we do have children snippets so you'd do something like
<!-- this is a simplified version -->
<CubeCamera>
  {#snippet children({ renderTarget })}
    <T.Mesh>
      <T.MeshStandardMaterial envMap={renderTarget.texture} />
    </T.Mesh>
  {/snippet}
</CubeCamera>

this works fine but the types are incorrect if you try to type the $props() inside <CubeCamera>
The new way to do types in svelte 5 for library authors is to add a declaration file next to the component. https://svelte.dev/docs/svelte/svelte#Component
so in this case CubeCamera.d.ts would look like this (a truncated version)
import type { Component, Snippet } from 'svelte'
import type { Group, WebGLCubeRenderTarget } from 'three'
import type { Props } from '@threlte/core'

export type CubeCameraProps = Props<Group> & {
  /**
   * the children snippet has access to the underlying render target
   */
  children?: Snippet<[{ renderTarget: WebGLCubeRenderTarget }]>
}

export declare const CubeCamera: Component<CubeCameraProps>

[!NOTE]
This is actually different than how we're doing things at the moment which uses the deprecated SvelteComponent type but I think updating all the .d.ts files should be its own ticket.

The problem is that Props also defines children so if you look at CubeCameraProps['children'] the type looks something like this:

Which makes sense because the component always passes the ref down but when you go to use any addition "snippet props", you get an error. In this case it says renderTarget has an any type.

inspecting the error looks like this:

Essentially it can't combine the two Snippet types, at least I think that's what is happening.
Possible Solutions
I can think of two solutions:
Option 1
Provide a second type parameter to Props that says what the children snippet is supposed to have and pass that along to where it picks up its children snippet type
(these types come from here)
- export type BaseProps<Type> = {
+ export type BaseProps<Type, Snippet> = {
    attach?:
      | string
      | Object3D
      | ((args: { ref: Type; parent: unknown; parentObject3D: Object3D }) => void | (() => void))
      | false
-   children?: Snippet<[{ ref: MaybeInstance<Type> }]>
+   children?: Snippet<[Snippet & { ref: MaybeInstance<Type> }]>

  oncreate?: CreateEvent<Type>
}

// ...

- export type Props<Type> = AnyProps &
+ export type Props<Type, Snippet>> = AnyProps &
    DisposableProps &
    RefProps<Type> &
-   BaseProps<Type> &
+   BaseProps<Type, Snippet> &
    ClassProps<Type> &
    CameraProps<Type> &
    InstanceProps<Type>

then using Props would look like this:
type CubeCameraProps = Props<Group, { renderTarget: WebGLCubeRenderTarget }> & {
// ...
}

The Snippet type parameter to Props could be more strongly typed, at least to be an object type. maybe something like
type Props<Type, Snippet extends Record<PropertyKey, any>> = {
// ...
}

Option 2
Remove the children from BaseProps and have each Component define its children.
export type BaseProps<Type> = {
  attach?:
    | string
    | Object3D
    | ((args: { ref: Type; parent: unknown; parentObject3D: Object3D }) => void | (() => void))
    | false
-   children?: Snippet<[{ ref: MaybeInstance<Type> }]>

  oncreate?: CreateEvent<Type>
}

Props stays the same.
and in the .d.ts you'd have to type the ref property.
// CubeCamera.d.ts
type CubeCameraProps = {
children?: Snippet<[{ ref: Group, renderTarget: WebGLCubeRenderTarget }]>
}

I'm not sure which I prefer. Option 1, although it would work, seems like a fundamental adjustment for such a small thing. Option 2 looks nice but only if there's some way to enforce that you must at least define the ref type.
There may be alternative options that I'm not considering. I'd like to know what you all think.

I'll work on getting a minimal reproduction and link to it here when ready.

closing this in favor of the suggestion here


Play Button Now Pauses

This CL:
https://github.com/NineWorlds/serenity-android/commit/a9c48f36768192075e472a5de915b52a417ffa01
Reverts a change I did long ago - the one that makes Play button not function exactly as Pause but rather, as a real Play button.
Was this on purpose? The CL description suggests it was just adding tests. Did this accidentally get reverted?

It was probably accidently lost when I was doing some coding refactoring I had done.  I'll try and get this back in with a test.

@alonalbert I'm sorry for the long delay.  The develop branch should have the functionality restored for the play button.  Please let me know if it is still not working.

Should be working again target to be included in 1.9.5


Add configuration hooks

Goal: provide a way for client projects to override some parts of the configuration

e.g., should hot reloading be enabled for images, ...
e.g., enable/disable TS support
...

Make it possible to enable/disable failing the build for specific checks (e.g., code style, code quality) in specific environments (cfr #17)

The options object should be clearly defined and easily instantiable by client projects.

The options object is available and documented. Other issues will take care of adding more options :)


feat: add nvme ssd cache layer

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

hi @linzs148, interesting work! However, the development of pelikan and Segcache are no longer at Twitter, are you interested in some open-source work to support flash in Segcache?


Broken Pipe Error (SquareToCircle)

Issue
I've been working with setting up the library and testing the SquareToCircle, and up until this point I've been able to use already submitted issues to resolve my errors. I'm getting some strange behavior when I call ffmpeg to write the video, as shown in the screenshot underneath. It seems like ffmpeg is not being called with the correct call in scene.py, although I'm not certain. The completion sound does play when this error happens.

Steps I've Taken
I've reinstalled ffmpeg and I am currently using the shell=true remedy that was suggested for line 601/602 of scene.py. I'm sure there is a problem with the interaction between ffmpeg and the library, but I'm unsure if this is due to the library or my user error. I double-checked that FFMPEG_BIN is defined correctly in constants.py, and the ffmpeg command is indeed correct.
When I run the animation with the command -ps I get a black frame (which is fine, because I haven't checked to see if my aggdraw is reverted or not), so the error only happens with rendering multiple frames.

Try figuring out how ffmpeg is called (ie replace the exec with a print), then try to figure out how it should be called to work appropiately, then apply necessary changes to your codebase. Also post your changes here so that other people don't have to deal with this.

@JoJoDeveloping I decided to do a fresh pull of the library's latest commits and try running things again.
This time I received an error stating something like from .big_ol_pile_of_manim_imports import * ValueError: Attempted relative import in non-package, but I fixed that by copying the import list directly into the example_scenes.py. Everything runs just fine now.
Since the latest version of the library seems to not have any issues, I'm going to close this for now unless there are further problems with the ffmpeg functionality.

If you remove the period from in front of .big_ol_pile_of_manim_imports import * everything works fine in example_scenes.py.  I currently havepull request #259 in to fix this issue.


Check for emptyness of writable string before parsing

Fixes https://github.com/brandur/redis-cell/issues/11
The rationale for this check is already explained in existing code: https://github.com/brandur/redis-cell/blob/master/src/redis/mod.rs#L299-L304
As I'm not familiar to the code, I decided to modify it at the user side, but maybe a better solution might be to modify RedisKeyWritable.read() to return None for empty strings. What do you think @brandur?

Great fix. Thanks for taking a crack at this @javitonino!

As I'm not familiar to the code, I decided to modify it at the user side, but maybe a better solution might be to modify RedisKeyWritable.read() to return None for empty strings. What do you think @brandur?

Okay, I reserve the right to change my mind on this one, but I think that the way it's written now is pretty good. The redis module is supposed to be pretty close to the metal, and it's doing that right — despite being somewhat bug prone as we see here, it doesn't do anything surprising when it comes to giving us a low level Rust wrapper for the Redis API. Let's put your current solution in for now, and if a similar problem appears again we can change it.
Going to merge this and add a comment based on is_empty's to elaborate a little bit.


Unit test workflow failed setting up conda environment: "Warning: Pip subprocess error"

The code passed unit tests locally but the GitHub actions workflow failed while setting up the conda/pip environment using mamba.  (Pip could not find the named conda environment for py36 & py38).

  The failure happened before the repo's code was installed, while constructing the conda environment when adding the pip requirements.  Pip could not find the environment directory.

Reported previously in the setup-miniconda repo we're using in our workflow.  Suggested remedies are:

don't use python-version (hint: use sed to rewrite environment.yml and specify python version)
continue with python-version but separate the pip install into a separate workflow command

We're using python-version in our workflow now.

We're already using sed to specify the python version: https://github.com/bluesky/hklpy/blob/c77c3cdf24ed72cea449ab79f281775a055ece6f/.github/workflows/conda_unit_test.yml#L20-L23 but also specifying python-version in the config: https://github.com/bluesky/hklpy/blob/c77c3cdf24ed72cea449ab79f281775a055ece6f/.github/workflows/conda_unit_test.yml#L35
Comment-out line 35 and give it a try.

Commit 96f672c did not solve the problem.  Plan B is to separate the pip install to a separate command.
Need to rewrite environment.yml and remove the pip requirements, writing them to a requirements.txt file, then add the pip install step (after activating the new conda environment).
If the sed can be replaced with a python script, this will be easy.  It requires that some python version be available at that part of the script.  Test that next.  Since this is a test, comment all the later steps for now.

Result (python 3.8.5 is available as python or python3):
  which python
  which python3
  python --version
  python3 --version
  shell: /usr/bin/bash -l {0}
  env:
    ENV_NAME: hklpy-test-3.8
    PACKAGE: hklpy
/usr/bin/python
/usr/bin/python3
Python 3.8.5
Python 3.8.5

The root problem was in the workflow with activate-environment: ${ENV_NAME}.
Replacing that with activate-environment: test-hklpy has a successful outcome for all Python versions tested 3.6, 3.7, 3.8).  For now, all will use the conda environment name test-hklpy


Fixed food eating delays

Removed the equal check due to causing issue's with food delays since when you eat one food it should be on the same tick

I think this is okay, but unfamiliar with this behaviour.

@Major- i can show a video of how it use to be if you want?

That would be good (and ideally the new behaviour too), thanks

Before - http://recordit.co/DYPHeiMxfj
After - http://recordit.co/4Lzm8dsEaT
@Major-

Ah yeah, you're right, this new behaviour is correct. LGTM cc @garyttierney


Quaternion.lookRotation instability?

It's always possible that I have not understood the intention of this method, but I am seeing some odd behaviour!

Here's the log output for TOUCH_EVENT:
elevation = -0.0632377 sin = 0.06319555732131173 q = w -0.9995022 x 0.031550206 y 0.0 z 0.0
elevation = -0.0510032 sin = 0.05098108928597383 q = w -0.99967575 x 0.025464354 y 0.0 z 0.0
elevation = -0.03836636 sin = 0.03835694701724931 q = w 6.122109E-17 x -1.1736956E-18 y 0.99981624 z -0.019167902
elevation = -0.025491359 sin = 0.02548859804805906 q = w 6.122737E-17 x -7.801733E-19 y 0.9999188 z -0.012741196
elevation = -0.012491358 sin = 0.012491033600450603 q = w 6.123115E-17 x -3.8240529E-19 y 0.9999805 z -0.006245152
elevation = 7.586414E-4 sin = -7.586413266721479E-4 q = w 6.1232336E-17 x 2.3226692E-20 y 0.99999994 z 3.7932064E-4
elevation = 0.014777074 sin = -0.014776535850863751 q = w 6.123067E-17 x 4.523639E-19 y 0.9999727 z 0.007387663
elevation = 0.029266331 sin = -0.02926215366642778 q = w 6.122579E-17 x 8.956075E-19 y 0.999893 z 0.01462638
elevation = 0.043891333 sin = -0.04387724199763511 q = w 6.1217625E-17 x 1.3423843E-18 y 0.9997597 z 0.021922797
elevation = 0.058641333 sin = -0.0586077295504146 q = w 0.9995716 x 0.029266477 y 0.0 z 0.0
elevation = 0.07364133 sin = -0.07357478800228877 q = w 0.9993259 x 0.0367129 y 0.0 z 0.0
So we have a look vector (0, y, 1) which should always work with an up vector of (0, 1, 0).  There shouldn't be any instability or gimbal lock for these values.
Have I misunderstood how lookRotation should work or is this a defect?

There shouldn't be any instability with those values, that is true. However lookRotation is always going to give you the shortest rotation from Vector3.forward() to the specified forward direction, which may be why you're seeing the quaternion flip. Can you share a screenshot or  video showing what the issue looks like?

I looked into this a bit more closely, this actually does create an unstable rotation.
lookRotation creates a rotation from the specified forward direction to Vector3.forward by calling Quaternion.rotationBetweenVectors, while trying to align the y-axis with up in world. This means that when elevation is at or near zero, the specified forward is (0, ~0, 1), and Vectror.forward is (0, 0, -1).
Try calling Quaternion.rotationBetweenVectors(new Vector3(
0, (float) Math.sin(-elevation), 1).normalized(), Vector3.forward()); and you will see essentially the same behavior that you are seeing now, and it will be more obvious why the rotation is unstable.

No problem, I'm glad that was helpful!


Request for a new Tapis job macro (e.g., "JOB_FOLDER_NAME_AUTOINCREMENT")

Tapis allows us to use macro variables to define what the job's execution folder should be, etc. Some of these macro variables include the  job's uuid (the default) and the job's name.
Tapis's default job working directory currently uses Job UUID to create job folders, while is safe and effective from machine point of view. However, we plan to implement job folder names based on user supplied string. This way a user can browse their job outputs intutively on a filesystem instead of having to map Job UUID with corresponding folder.
This is already feasible to implement to certain extent using the files API (checking if the folder with the same name already exists before making the submitJob API call, etc.), however the number of API round trips needed for this can be numerous in edge cases.
So, we would like to propose adding a new macro JOB_FOLDER_NAME_AUTOINCREMENT (the name can be different) that has following behaviors
Create's a job folder with a given name say "myjob", and if this folder already exists it will create a new job folder with name as "myjob_1". Similarity when "myjob_1" exist, it will create a new folder as "myjob_2" and so on.
Would love to hear your thoughts on this, thanks

Discussed with submitter.  The incrementor macro will only be used on the last path element.  Possible race conditions have to be taken into account.


feat(plan-of-care): update reference text for plan of care

Jira: XDS-125
#24

:tada: This PR is included in version 2.8.0 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SparkLines

Describe the feature request
Little bar graphs/ pie's or linegraph that are able to be easily read in the lineheight of a table.
Which charts does this feature request apply to?

Pie Charst
Line graph
Bar graph

Describe the solution you'd like
Readly available sparkline type graph.
JavaScript equivalent
https://github.com/Volorf/SparklinerJS
Describe alternatives you've considered
I have used this repository before (https://github.com/joadan/Blazor-ApexCharts) but implementation is difficult.
Additional context
Example:

Hey @ClumsyPenguin, thanks for the issue.
Chart.js doesn't have a built-in sparklines type AFAIK but since it's very customizable you can achieve the result you want with pure Chart.js configuration.
Here are some issues you should check out: https://github.com/chartjs/Chart.js/issues/14, https://github.com/chartjs/Chart.js/issues/668, https://github.com/chartjs/Chart.js/issues/7720
They contain links to codepens which show the config you need. As always, you can translate the JavaScript code to C# by just transforming the names to CamelCase and adding some new statements (works surprisingly well). However, you might stumble upon an option that's not supported yet. If that's the case, please open a new issue with all the information about that specific option so we can take a look at it and figure out a workaround for as long as it's not fixed.
Play around with the options and refer to the links I posted above. Once you got something, let us know - I'm sure you'll get it working!

Got ya! Thanks for the info. This can be closed, i am sure i will figure it out somehow. Thanks again!

Best of luck 😄
Feel free to post a sample here once you've figured it out. I'm sure some people would appreciate it ❤


add support for authenticated registry pulls for BR (#1747)

Issue #, if available:
Description of changes:
Manual cherry-pick of #1747
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Upgrade to macOS 11 runner image for CI

Depends on:

#111

Related to:

https://github.com/cashapp/AccessibilitySnapshot/issues/98

Closes #98
This requires migrating

from Xcode 11.3.1 to Xcode 11.7
from iOS 13.3 to iOS 13.7
from Xcode 12.2 to Xcode 12.5.1
from iOS 14.2 to iOS 14.4

This looks great Eli, thanks for taking care of this migration!


feat: Handle JWT tokens

This change allows users to pass JWT secret and algorithm values when creating an API with JWT authentication middleware, like this:

api_options = ApiOptions(jwt_secret="your_secret_key", jwt_algorithm="HS256")
my_api = api("my-api", ApiOptions(
    middleware=[
        JWTAuthMiddleware(api_options)
    ]
))

This addition suggests a potential future enhancement to allow users to define the JWT secret and algorithm values in the nitric.yaml configuration file.

Consider this a first pass, as I'm sure you all have some more business requirements pertaining to the issue.

@derekschultz apologies for the late reply on this one.
For JWT middleware I was thinking we might maintain this as part of a separate package that can be optionally installed as part of projects. This could be very granular (this middleware could be its own lib) or part of a larger package of helper middleware.
I can see this middleware being very useful, and keen to discuss where we put/publish this.
For core python SDK development I'm planning to write up some help-wanted issues for this repository in the near future.

Hey Derek, closing for now.  Please let us know!


Feature request: Reuse connector WITH parameters

(requested by a user)
e.g., for PostgreSQL CDC, users need to repeatedly enter hostname, port, username, password, ... for all tables. It might be better if there are some ways to reuse the common parameters.
At the same time, are there any existing workarounds?

For CDC sources, @StrikeW is working on RFC: Share a change log stream for multiple CDC tables (@StrikeW Please help migrate this doc to RFC repo), which introduces a new syntax to define multiple tables from one upstream DB.
For other things, we don't have a solution yet. Welcome for any discussions & proposals.

e.g., for PostgreSQL CDC, users need to repeatedly enter hostname, port, username, password, ... for all tables. It might be better if there are some ways to reuse the common parameters.

actually, I have proposed the connection syntax for this case, https://github.com/risingwavelabs/rfcs/pull/35 but we only adopt the private link part. Maybe it is time to review the design.

BTW, I also feel that this request is somewhat similar to https://github.com/risingwavelabs/risingwave/issues/10151, where code reusability is wanted, instead of a new "capability".
One typical argument is that we can simply use global string substitution, or dbt macros.

I'm also interested in this feature, repeatedly enter hostname, port, username, password is not just verbose and it may cause sensitive information leaks. crdb provides the create external connection syntax that allows you to encapsulate network and authentication settings into a connection object. a user with higher privileges (such as root) can manage these connections by defining the necessary connection parameters. Once the connection object is created, normal users can reference it to create sources and sinks without needing to specify the network and authentication settings each time, also normal users cannot extract any sensitive information from the connection object without grants.

We will introduce Connection to support this feature. close as stale.


[General][Frontend] Initialize atomic design architecture

AS BO
I want to see frontend architecture implemented
Frontend architecture should have atomic design

I began dividing prototypes into atoms, molecules and organisms.
https://www.figma.com/file/0RSJe9OBLyDNAlZAIrnU4o/Untitled?node-id=3%3A84


Fix raw backticks

Opera Mini seems to have 2 data saving modes:

Extreme
High

https://blogs.opera.com/news/2015/09/new-high-saving-data-opera-mini/
"High" seems to be compatible with Chrome.
caniuse.com says "To test on iOS/Android this mode can be enabled using "Extreme data savings"".
In short, what we call op_mini is not the entire of Opera Mini but just one of its modes.

This section is taking about the queries, not about the browsers.
We already have mention of Extreme mode on Opera Mini link from the browsers list. Is it OK?

I have wanted to add there instead if found but I could not in this website.
Is there in the README of browserslist/browserist?

Is there in the README of https://github.com/browserslist/browserslist?

No. It doesn’t describe browsers.

I'll send a new PR to that repo.
This will be just to fix backticks.

For this website, a tooltip on not op_mini all will be great.
"You shouldn't use this query unless you think it takes too much cost to support Opera Mini's Extreme data saving mode. It also has another data saving mode High, which has much better compatibility with other browsers."

This will be just to fix backticks.

Sure! Send commit.

"You shouldn't use this query unless you think it takes too much cost to support Opera Mini's Extreme data saving mode. It also has another data saving mode High, which has much better compatibility with Chrome."

We can add it to Advanced section there (and move all op_mini note).


Error during combat

Description
I was in combat doing a world quest and this error popped up.
Version Number

commit d9e3f781ea8ab94cf0b9b924ed34d609410e8b01
Steps to Reproduce

Everything was fine and then a burst of combat this popped up.
Expected Behavior

Actual Behavior

1x [ADDON_ACTION_BLOCKED] AddOn 'KkthnxUI' tried to call the protected function '<unnamed>:Hide()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function `Hide'
FrameXML\WorldMapActionButton.lua:58: in function `Clear'
FrameXML\WorldMapActionButton.lua:67: in function `Refresh'
FrameXML\WorldMapActionButton.lua:19: in function `SetMapAreaID'
FrameXML\WorldMapFrame.lua:1338: in function <FrameXML\WorldMapFrame.lua:1263>
[C]: ?
[C]: in function `WorldMapFrame_Update'
FrameXML\WorldMapFrame.lua:2883: in function <FrameXML\WorldMapFrame.lua:2882>
[C]: ?
[C]: in function `WorldMapFrame_UpdateMap'
FrameXML\WorldMapFrame.lua:450: in function <FrameXML\WorldMapFrame.lua:434>
...
FrameXML\UIParent.lua:2222: in function `ShowUIPanel'
FrameXML\UIParent.lua:2132: in function <FrameXML\UIParent.lua:2128>
[C]: in function `SetAttribute'
FrameXML\UIParent.lua:2914: in function <FrameXML\UIParent.lua:2902>
[C]: ?
[C]: in function `ShowUIPanel'
FrameXML\UIParent.lua:2898: in function `ToggleFrame'
FrameXML\WorldMapFrame.lua:263: in function <FrameXML\WorldMapFrame.lua:235>
[C]: in function `ToggleWorldMap'
[string "TOGGLEWORLDMAP"]:1: in function <[string "TOGGLEWORLDMAP"]:1>

Locals:

Only KkthnxUI Enabled

I had Buggragger and Bugsack installed - if this is not appropriate - apologies.
Additional Information

Error Log

Did you happen to have World Quest Group Finder or any world quest AddOn active at this time of this happening?

I did have Angry World Quests. I know I should try to eliminate all addons besides yours, but since it popped up anyway and seemed to have your code listed, I thought it would be helpful. I will run around today with only your mod installed and see if I can duplicate - although it seemed strange - it just popped up.

Try without that AddOn and let me know if you can still reproduce it.


[add][cms] pull type of weather xml

Coverage decreased (-11.4%) to 57.578% when pulling 51cddf95512f44dbe467ef638497a2fde00d1127 on sunny4381:features/cms-weather-xml-pull into 4ab4e35cedd139b877a6031cd037374494c7c33d on shirasagi:master.

Coverage decreased (-11.4%) to 57.578% when pulling 51cddf95512f44dbe467ef638497a2fde00d1127 on sunny4381:features/cms-weather-xml-pull into 4ab4e35cedd139b877a6031cd037374494c7c33d on shirasagi:master.


add install info for typescript

@types/javascript-state-machine (tagged "2.4.0") seems incompatible with javascript-state-machine ("3.1.0").
For instance, result of new StateMachine(...) should provide property/method like state (see: https://www.npmjs.com/package/javascript-state-machine#usage).

See https://github.com/jakesgordon/javascript-state-machine/issues/91#issuecomment-341615009 if you need typings.

Bump. Can we get this feature please?


Adds another font color index to arch icon

Now the Arch icon has 2 font color indexes.  1 is the top, 2 is the bottom which will allow for customization so old neofetch themes like ozozfetch are possible.  By default both font colors are the same so the user has to specify if he/she wants to change them for a theme.

Thank you!


remove Cpat from match-info; add match-info extractor fns

closes #111
(dont merge yet) Ready to (squash) and merge.

I will squash and merge this tonight unless there are objections

Looks good to me.


Amharic language support

Amharic language support. I can do the translation myself.

If you want to do it, then follow these steps..

Fork this repo.
Copy "translation.json" from "kofta/public/locales/en".
Create a folder called "am" in "kofta/public/locales".
Paste the "translation.json" in the newly created folder.
Do the translations in the Amharic language(in "kofta/public/locales/am/translation.json").
Then go to "kofta/src/app/components/LanguageSelector.tsx".
Alphabetically add { value: "am", label: "Amharic" } in options array.
Commit in your repo and make a pull request.

If this sounds hard, comment here. I can do it.

I have made a PR but it keeps failing.
PR #900


Update RPM repo for current Calico with Liberty or later

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Addresses #1083


DRAFT: Add human readable description to txData response

What it solves
Includes a human readable description with the Transaction data if it exists for a given function call.
ToDos

Write tests for parseMessages
Write tests for readable-descriptions.mapper
Fix type casting

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

42 of 77 (54.55%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 91.71%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main.ts
0
1
0.0%

src/routes/transactions/mappers/common/readable-descriptions.mapper.ts
20
33
60.61%

src/routes/transactions/entities/readable-descriptions/parsed-messages.ts
10
31
32.26%

Totals

Change from base Build<PHONE_NUMBER>:
-0.8%

Covered Lines:
4394

Relevant Lines:
4682

💛  - Coveralls

Please try to wrap up the review process, we need to release this by the end of the month.

Please try to wrap up the review process, we need to release this by the end of the month.

The stakeholders are aware of the current state of this change. Wrapping up happens when it's ready to be merged.


print "hello"  # should be flagged as a Syntax Error

Hound CI does not flag:
print "hello"  # as a Syntax Error but it is in Python 3.

@cclauss have you fix this? Do you find a way to configure runtime python version in:
https://github.com/houndci/python/blob/master/runtime.txt


upgrades to run ES 2

2.0.0

Upgrades to Elasticsearch 2.0.0
Upgrades to Kubernetes Plugin 2.0.2
Runs under elasticsearch user
Set ulimit to support memlock
Disables Security Manager to enable Kubernetes plugin

access to networking
access to filesystem for secrets and configuration paths

Added a binding to all network interfaces.

hi @dermidgen I don't know why but Github seems to be borked regarding PRs. I never got a notification regarding your PR - and another one in another project. I went ahead and fixed it. I'm so, so sorry :(

@dermidgen would you do this work and update the official Kubernetes example for Elasticsearch? :)

@pires - No worries at all - we're all busy people and systems ain't perfect :)
I would be happy to I would be happy to help. What "work" are you referring to specifically - updating the readme and examples? If so I definitely plan to. My next step was to work this in with https://github.com/pires/kubernetes-elasticsearch-cluster for 2.0.
Just point me at whatever work you would like me to help with; hopefully between tonight and tomorrow I should have things mostly buttoned up and ready to fully update the official Kubernetes examples with some 2.0 notes.
BTW - there's still an outstanding PR on https://github.com/pires/docker-elasticsearch for binding on all interfaces - as was pointed out in the thread on the kubernetes plugin. I also applied that in this PR since we overwrite run.sh from docker-elasticsearch:2.0.0

So I merged from your master - I guess we were doing some things in parallel.  I merged in favor of your network.host settings since I'm guessing you actually looked things up.  I was setting to <IP_ADDRESS>;

@dermidgen made some comments. After that is taken care of, I can merge.
Regarding kubernetes-elasticsearch-cluster, I already provided a PR last night. Going to merge as soon as someone else besides me tests it. Now, I was wondering if you could update kubernetes/examples/elasticsearch` documentation to match the aforementioned PR?

Okay made some updates there - just wondering on the zen discovery comment and I think we're good.  Will start working on the docs for kubernetes-elasticsearch-cluster

Also - yes, I'm working on kubernetes/examples/elasticsearch docs as well.  I will bring over the .yaml config files and examples from kubernetes-elasticsearch-cluster.
I think this is where the current examples are confusing, because the current example provides a simple Kubernetes config that has our instance running mixed services - which barfs when you run the kubectl scale. I'll get it all sorted out today :)

@dermidgen the official examples has both a simple version and a production version. The documentation explicitly states that.

@pires So - I'm currently working on updates to the simple version. Everything goes fine until the instructions say - great now you've got 1 node up; let's scale. Then the instructions call to run kubectl scale --replicas=3 rc es. This is where we break down, because the simple example uses a mixed service node.
The simple example shows that you should see something like
[2015-08-30 10:08:02,517][INFO ][cluster.service          ] [Hammerhead] added {[Tenpin][2gv5MiwhRiOSsrTOF3DhuA][es-78e0s][inet[/<IP_ADDRESS>:9300]]{master=true},}, reason: zen-disco-receive(join from node[[Tenpin][2gv5MiwhRiOSsrTOF3DhuA][es-78e0s][inet[/<IP_ADDRESS>:9300]]{master=true}])

But instead we get the unicast errors. I understand this is because our example svc and rc run mixed services.
Should we remove the scaling part of the simple example and refer folks to the production example - or is there a way to fix the simple example svc & rc so that scaling our single node works properly as a mixed service node?

@pires I think it might make better sense for me to start a PR on Kubernetes - and then continue this discussion on there where you can give line-by-line feedback?  Agree?

I went ahead a did one: https://github.com/kubernetes/kubernetes/pull/17570

@pires - I've made the required updates in the official examples.  The production example was pretty smooth. Nothing really wrong there. I was able to make the updates and follow the guide and everything went swimmingly.
A couple things:

The simple example instructions have stuff about scaling - I think we should remove that
The warnings about emptyDir - I'm not sure what to do with that. We have to remove that for Kubernetes 1.1+ but does that change the spirit of the warning?

Oh N00z!

Most of this PR was merged with cherry-pick. Thank you @dermidgen


Fix documentation for TLS in 4.7 Framework

(Replacement for PR #13817)
There are multiple false statements regarding .NET 4.7 and TLS protocol settings.
This update fixes to documentation to make the behavior clear.
Fixes #13787

@Thraka - please review and merge.

Thanks, @davidsh. I've left a couple of suggestions.

@rpetrusha I've added the suggested changes.

Thanks, @davidsh. I'll merge your PR now.


The SPA default page middleware could not return the default page '/index.html' because it was not found

I have published the app to Azure app service from visual studio. I am getting the following error when trying to browse to the application:
2018-01-23 16:27:24.118 +00:00 [Error] Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware: An unhandled exception has occurred: The SPA default page middleware could not return the default page '/index.html' because it was not found, and no other middleware handled the request.
Your application is running in Production mode, so make sure it has been published, or that you have built your SPA manually. Alternatively you may wish to switch to the Development environment.
I copied the file index.htm to the folder "ClientApp/dist/index.htm". Now I am not getting the exception. But the page just renders the following:

Would appreciate if you could help me with what the issue might be.
Thanks

It's an IIS Default Document issue. Just add the following to your web.config:
<system.webServer>
   ...
      <defaultDocument enabled="false" />
</system.webServer>


Spelling error in config not caught

spelling error, missing 'i' for 'incremental_strategy' not caught and results in wrong incremental strategy.
{{
config (
materialized='incremental',
ncremental_strategy = 'insert_overwrite',
partition_by = {"field": "timestamp","data_type": "timestamp"},
)
}}
Result is that _dbt_max_partition is not defined since it doesn't use 'insert_overwrite' strategy.

Hey @steve0629, where did you find the code that you linked above?


Module file names don't allow hyphens

I would like to be able to name modules in standard xquery "train-case" format.
e.g. my-xquery-module.xqy
This is pretty normal in XQuery but is not supported by the plugin which tries to sanitize the filename into camel case for some reason.
It should either allow hyphenated names or explain in the error message why it is refusing to create the file. I had to look in the source code to find out what caused the warning message.
(Really great plugin by the way!)

Hi,
Thanks for raising the issue.
The reason for not using hyphenated names was that IDEA in many places (internal IDEA engine code) does rely on names not containing any characters that are not alphanumeric.
I'll review if this is still the case and if not then the rules might get relaxed!
Thanks for using the plugin and letting me know how to improve it!

Hi
The new rules for function names are as below:

has to start with either _ (underscore) or letter
can contain letters, numbers, hyphens, underscores
Hope these rules make sense now


Is it possible to finetune on higher image resolutions?

Is it possible to fine tune on higher image resolutions? What changes might be necessary if its not possible?

I think that is so hard as the computational complexity

I agree, that's one hinderance.


Upgrading c3p0 to <IP_ADDRESS>

Clearing GitHub warning...

Codecov Report

Merging #607 into master will decrease coverage by 0.7%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #607      +/-   ##
============================================
- Coverage     63.13%   62.42%   -0.71%
  Complexity       68       68
============================================
  Files           188      188
  Lines          7278     7074     -204
  Branches        845      816      -29
============================================
- Hits           4595     4416     -179
+ Misses         2413     2389      -24
+ Partials        270      269       -1

Impacted Files
Coverage Δ
Complexity Δ

...apm/agent/impl/transaction/TraceContextHolder.java
50% <0%> (-6.87%)
0% <0%> (ø)

...bci/methodmatching/TraceMethodInstrumentation.java
59.57% <0%> (-5.37%)
0% <0%> (ø)

...ent/jaxrs/JaxRsTransactionNameInstrumentation.java
82.75% <0%> (-2.54%)
0% <0%> (ø)

...astic/apm/agent/impl/transaction/TraceContext.java
89.72% <0%> (-1.23%)
0% <0%> (ø)

...tic/apm/agent/configuration/CoreConfiguration.java
99.3% <0%> (-0.7%)
0% <0%> (ø)

...va/co/elastic/apm/agent/impl/ElasticApmTracer.java
82.81% <0%> (-0.12%)
0% <0%> (ø)

.../apm/agent/concurrent/ExecutorInstrumentation.java
52.63% <0%> (+7.34%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5940bea...74b78d2. Read the comment docs.


Clamped polyline flickers when updating property

This Sandcastle continually processes the same CZML packet. Since the polyline already exists, it shouldn't be flickering.
In fact, this is fixed by setting clampToGround to false in the CZML. It seems like just supplying this property forces the ground polyline to be recreated?
This came up on the forum.

This is working as expected.  A new polyline is being created each time czml.process is being called.  It's just not noticable without clampToGround because non-clamped polyllines are so much faster to draw.

Congratulations on closing the issue! I found these Cesium forum links in the comments above:
https://groups.google.com/forum/#!topic/cesium-dev/Y0YHGBWMgds
If this issue affects any of these threads, please post a comment like the following:

The issue at https://github.com/AnalyticalGraphicsInc/cesium/issues/7119 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


install fails (package not found) for linux mint 19 -- fix

Users of linux mint 19 will need to alter the repo url after the fact as AZ_REPO=$(lsb_release -cs) produces "tara main"  which doesn't exist in ms repo -- change / alter via software sources tool to trusty main. Then update apt cache and rerun install.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fe1526a9-7f22-504e-484c-0f3edc11b178
Version Independent ID: c5dec108-efcd-aa77-04b5-803b6b894dba
Content: Install the Azure CLI 2.0 on Linux with apt
Content Source: docs-ref-conceptual/install-azure-cli-apt.md
Product: azure
GitHub Login: @sptramer
Microsoft Alias: sttramer

Our instructions do not list Linux Mint as a supported platform, and provide details that users need to manually set AZ_REPO for Debian/Ubuntu-derived distributions due to this exact reported issue.


rust test: Enable all integration test cases

Move the nm folder and plugin_test.py to integration_bak as they holds
python specific code which is not intend to be supported by rust code.
Will move the test cases back after reviewed.
All integration test cases are passing for rust code now.

The CI failure on NM-main is caused by NM bug: https://bugzilla.redhat.com/show_bug.cgi?id=2073926

Move on. Will fix issue if found.


Reset score

Any chance it'd be possible to add a command to reset your own score?

Absolutely! I will implement this when I have some time over the next couple days.
Thank you for the suggestion @vivianig !

Resolved by this commit !


Switch C# to contextual serializer and deserializer internally

contextual (de)serializers have been introduced in https://github.com/grpc/grpc/pull/16367.
Serialization performance stays the same, but the switch is a foundation for introduction of more efficient serialization is in progress in https://github.com/grpc/grpc/pull/16371/

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,040      Total (=)      2,019,040

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,179,730      Total (<)     11,179,733

 No significant differences in binary sizes

@apolcyn  responded to concerns, PTAL.

Known failures: https://github.com/grpc/grpc/issues/17170


Create credentials in jenkins

All,
I want to automate the creation of a git credential in Jenkins. The idea is to have a Jenkins server setup with some private ssh keys (menu Jenkins > Credentials), so I don't have to add them manually.
Do you have any piece of advice for that?

It used to be easy... you just make sure a key exists somewhere, then you can store credentials config in JENKINS_HOME and just deploy that config pointing at the key file on the server.
But now you can't refer to keys stored on disk elsewhere, they have to be part of the credentials XML that's stored in JENKINS_HOME.
I would ask around elsewhere (maybe stack overflow?) for the best techniques for storing credentials (e.g. private keys) in an automatable way with Jenkins. Right now we have the JENKINS_HOME mounted into our containers that run Jenkins and we just set up the keys by hand when we build a new instance.
Other people do other things.


Add input form for adding mappings

This PR adds a very minimal input form to allow adding new mappings on the web interface. These can then be automatically committed along with any other curations.

Great, thanks! I thought about validation but then realized that the entries will be validated during standard testing anyway so it's not critical that the UI does it upon entry (though it's convenient since it catches errors early).


Feedback from user study: Users need more context about the content of the overview page

Participants were not sure about what the repo is trying to accomplish. One participant requested a high-level summary at the start of the page to give more context about what the user should expect to do and what the output will be. One user thought a short video describing the project would be a good idea for an overview.
Recommendation:
•	Provide users with a high-level summary of the process and a table of contents to organize information
•	Provide a clearer picture of what the end state looks like and step by step instructions to get there.

Closing this issue because it is closely related to #29


 Allowing provider name as input argument for signInWithPopup & signInWithRedirect

Description
_attemptProviderSignIn(provider, method) provider argument has to be a new firebase.auth.providerNameAuthProvider() provider instead of the name of the provider.
Expected outcome
signInWithPopup(providerName) would automatically create a new firebase.auth.providerNameAuthProvider() using _providerFromName method.
Actual outcome
Error: First argument "authProvider" must be a valid Auth provider. (listening to error of firebase-auth)
Steps to reproduce
this.$.auth.signInWithPopup("google")

https://monosnap.com/file/NSJyms9xT76SZrbCjS5KOPYDqa0hPN

Hey, i`m not sure which is the solution here, i have the same error treating the 'microsoft.com' provider, just following the instruction of Firebase.

var provider = new firebase.auth.OAuthProvider('microsoft.com');

I'm just getting the next error:

was looking others ways to use the provider but.. this is the only available that i found involving microsoft as a provider.
will be great if you guys have some idea what can i do, or if i'm doing something wrong 😅

I just create new instance:
From: const fbProvider = firebase.auth.FacebookAuthProvider()
To" const fbProvider = new firebase.auth.FacebookAuthProvider()
use react & "firebase": "^8.6.8"


fix(docs): fix websocket annotation value

While the actual code uses 0 and 1 as scalars for internal implementation of enabled or disabled flags for WebSockets, these values are only used internally, and the documentation is misleading in directing the user to use these values as the value of the annotation, when they must be the actual strings enabled or disabled that are mapped by the actual code at runtime.
Exposing this internal implementation detail not only is vulnerable to internal implementation changes by a developer assuming no user will see this, but also is very misleading to users. We struggled for hours to enable Websockets because the documentation noted '0' as the value for disabled (if entered as strings [as is standard in k8s annotations] the function would silently fail), only until we went to the actual source code to see the code path taken did we see the enable|disable strings.
Signed-off-by: Basit Mustafa<EMAIL_ADDRESS>Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Thanks for contributing!

This change updates the documentation to expose the external string values required for the annotation for enabling/disabling websockets on the Ingress object, rather than the internal scalar/int values used in the code that were being exposed and were not valid but if entered as strings (as is standard in k8s annotations) the function would silently fail.
Fixes: #issue-number
Clarify annotation value in documentation for disable/enable websockets (io.cilium/websocket)

Just running the docs CI target, if that passes I'll merge this. Self-assigned to follow up.


Fix wrong request time in access log when the connection is dropped

I wonder if we don't have a larger issue here. Not calling finalize() not only means that the request time isn't properly recorded, but also that we potentially leak resources. Do you have an exact reproduction recipe for this?

I believe it's happening mostly when refreshing while loading.
If you have a route that takes slightly longer to serve, press refresh a few times, not letting it finish and it should reproduce.

Okay, I reproduced it and now finalize() is simply always called. I've added some checks to avoid additional log noise/exceptions.

Good stuff! Thanks! :)


Failed in Pacific centered map in Robinson projection

Hello, Mr. Hackl,
I tried to use your code to draw a pacific-centered map in R.
However, I failed to get the same plot as you did. The plot I got is attached.
It seems the problem with polygons.
Could you please tell me what's wrong with it and how I can fix it?
Thank you very much.

Hi, I have an idea of what's going on there but no solution. Similar problems were the reason why I wrote this package a while back and at the time it did solve it. Apparently, that is no longer true. Not sure what has changed, but unfortunately, I don't have the time right now to look in this further...


[CARBONDATA-3282] set hadoop conf to thread local for file factory usage in presto carbon

[HOTFIX] set hadoop conf to thread local for file factory usage in presto carbon.
and Added bloom dependency in presto.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed? NA

[ ] Any backward compatibility impacted? NA

[ ] Document update required? NA

[ ] Testing done. yes. tested in cluster

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.  NA

There is no version of carbondata bloomfilter that can take effect on presto now.


Separate highlighter to represent the actual changes in the diff

Thank you for this awesome plugin. I was wondering if it is possible to have some addition highlight to show the actual changes with bright color and hence have separate highlighter if possible. ( I have no clue whether its even possible). Below is the example shows the change I am requesting for
From Neogit:

From Magit (doomemacs)

It is most certainly possible. https://github.com/sindrets/diffview.nvim does it, and the neogit d diffview integration also works with the exact highlighting.

Yes correct, with diffview it is visible, not in the same color palette but yes its there. It would be great to see the similar highlights with neogit native diff shown per file via  key.


Allow puppetlabs-stdlib v5.x

@bastelfreak I think this PR depends on #439, otherwise tests will fail


operator smilecdr-operator (0.0.1)

New operator bundle
Name: smilecdr-operator
Version: 0.0.1
Certification project: 61b0d1f1b5936597314c909c
Test result URL: https://catalog.redhat.com/api/containers/v1/projects/certification/test-results/id/61f312d2366a13ab128126ca
Test logs URL: https://catalog.redhat.com/api/containers/v1/projects/certification/artifacts/id/61f312d1366a13ab128126c9

Closing for new PR.


Change mom coord

This PR switches the default momentum coordinates in the Track object from global cartesian to quasi-polar (1/pT,phi,theta). In this way we do not need to convert back and forth from the two coordinate systems in the KalmanUtils.
The old behaviour can still be recovered disabling #define POLCOORD in Config.h.
What still needs to be ported to the new coordinates are the SMatrix version of Propagation and of KalmanUtils. Also, the cuda version is not changed for the moment.
Also, a few deprecated functions are removed in this PR.
The timing performance is improved and goes back to the version before PR39, see plots at:
http://uaf-6.t2.ucsd.edu/~cerati/mictest/2016-05-11-PR46/

@cerati,
For some time now we have been stumbling over what to call your new coordinates. Now that we are about to adopt them for tracking, I propose calling them "curvature coordinates".

Reasons against the old label: the coords are scarcely "polar", or even quasi-polar. First, they apply to the momentum rather than the position; second, the "distance" is actually 1/magnitude; third, they are neither spherical-polar nor cylindrical-polar, but somewhere in between.

Reasons in favor of the new label: "curvature" is a much better description of what these coords actually correspond to, I believe. 1/pT is directly related to track curvature. And the angles are (I think) a way of describing the spatial direction of curvature associated with the given position parameters. (Please correct me if this interpretation is lacking somehow!)

If you agree, then it may be a good idea to change the #define POLCOORD to, say, CURVCOORD, so we don't get stuck in the current terminology (as I don't think anyone is totally satisified with it).
I will be interested to get your reaction...

My two cents...
Position vs. momentum is a red herring--a coordinate system is a coordinate system, whether it's applied to position space or momentum space or some completely abstract space.  Polar is definitely wrong, since polar is a 2-d coordinate system.  Spherical is closer, except curvature doesn't add like a distance.  In physics there's the "wave vector", with length proportional to the inverse of the wavelength, and there are spherical wave transforms that correspond to the conformal (angle preserving) group of transformations by the reciprocal of the radius, which suggests "spherical wave coordinates" (or maybe "wave spherical").

@dan131riley ,
Thanks for your input (worth more than 2 cents surely). Technically your terminology is reasonable, but "curvature coordinates" may convey a better intuitive sense of what these coordinates are trying to achieve. I am interested in Giuseppe's reaction.
In defense of my previous point #1 about polar... probably what I should have said was, "they apply to the momentum BUT NOT the position." They are kind of semi-polar, in other words. Nothing wrong with that. But "polar" without qualifiers brings to mind primarily a spatial coordinate system, with other vectors being defined in reference to that system (at least to my mind).

what about CCS coordinates, from cartesian-curvature-spherical?
One could add also G6 (from global, dimension 6) but then it would become
difficult to pronounce...
On Thu, May 12, 2016 at 8:36 PM, srlantz<EMAIL_ADDRESS>wrote:

@dan131riley https://github.com/dan131riley ,
Thanks for your input (worth more than 2 cents surely). Technically your
terminology is reasonable, but "curvature coordinates" may convey a better
intuitive sense of what these coordinates are trying to achieve. I am
interested in Giuseppe's reaction.
In defense of my previous point #1
https://github.com/cerati/mictest/pull/1 about polar... probably what I
should have said was, "they apply to the momentum BUT NOT the position."
They are kind of semi-polar, in other words. Nothing wrong with that. But
"polar" without qualifiers brings to mind primarily a spatial coordinate
system, with other vectors being defined in reference to that system (at
least to my mind).
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/cerati/mictest/pull/46#issuecomment-218846956

We can talk about it tomorrow if people want. My point is simply that the goal of these "coordinates" is to describe a geometrical object, namely a helix. We are saying that the current best estimate of the track is a z-oriented helix with pitch angle theta and lateral "curvature" 1/pT, and that point x,y,z is a position at azimuth phi (+/- pi/2) on this helix. (OK, to make 1/pT into a real curvature, the charge and B should be included to make it 1/gyroradius; not sure if I have omitted a relativistic gamma in some of the definitions.) The new coordinates just make it a bit clearer that we have been talking about such a geometrical object all along. So call them "helix/helical parameters"?

I do not think we should devote part of the meeting to the naming
convention, our 1h slot is too short already.
Just to say that "helix parameters" is a too generic definition that
applies to any parametrization (cartesian, "polar", curvilinear, perigee,
etc.).
Our parametrization has two components:

a global cartesian position
a spherical momentum, modified so that the magnitude of the 3D radius
vector is replaced with 1./pT, where 1./pT is the magnitude of the 2D
radius vector and is proportional to the curvature (the fact that pT is 2D
while R is 3D is why I initially suggested polar rather than spherical)

Any name capturing these features is fine with me.
On Fri, May 13, 2016 at 12:23 AM, srlantz<EMAIL_ADDRESS>wrote:

We can talk about it tomorrow if people want. My point is simply that the
goal of these "coordinates" is to describe a geometrical object, namely a
helix. We are saying that the current best estimate of the track is a
z-oriented helix with pitch angle theta and lateral "curvature" 1/pT, and
that point x,y,z is a position at azimuth phi (+/- pi/2) on this helix.
(OK, to make 1/pT into a real curvature, the charge and B should be
included to make it 1/gyroradius; not sure if I have omitted a relativistic
gamma in some of the definitions.) The new coordinates just make it a bit
clearer that we have been talking about such a geometrical object all
along. So call them "helix/helical parameters"?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/cerati/mictest/pull/46#issuecomment-218903131

merging, we can update the name later...

CCS (cartesian-curvature-spherical) is fine by me, and I agree about
not using meeting time for this, too close to bikeshedding.
-dan

On May 13, 2016, at 04:00, cerati<EMAIL_ADDRESS>wrote:
I do not think we should devote part of the meeting to the naming
convention, our 1h slot is too short already.
Just to say that "helix parameters" is a too generic definition that
applies to any parametrization (cartesian, "polar", curvilinear, perigee,
etc.).
Our parametrization has two components:

a global cartesian position
a spherical momentum, modified so that the magnitude of the 3D radius
vector is replaced with 1./pT, where 1./pT is the magnitude of the 2D
radius vector and is proportional to the curvature (the fact that pT is 2D
while R is 3D is why I initially suggested polar rather than spherical)

Any name capturing these features is fine with me.
On Fri, May 13, 2016 at 12:23 AM, srlantz<EMAIL_ADDRESS>wrote:

We can talk about it tomorrow if people want. My point is simply that the
goal of these "coordinates" is to describe a geometrical object, namely a
helix. We are saying that the current best estimate of the track is a
z-oriented helix with pitch angle theta and lateral "curvature" 1/pT, and
that point x,y,z is a position at azimuth phi (+/- pi/2) on this helix.
(OK, to make 1/pT into a real curvature, the charge and B should be
included to make it 1/gyroradius; not sure if I have omitted a relativistic
gamma in some of the definitions.) The new coordinates just make it a bit
clearer that we have been talking about such a geometrical object all
along. So call them "helix/helical parameters"?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/cerati/mictest/pull/46#issuecomment-218903131

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Agreed, today's meeting will be full enough. But I disagree with the "bikeshedding" characterization. To me, names are important, and they should correctly reflect the concepts behind them.
Steve
From: Dan Riley<EMAIL_ADDRESS>Sent: Friday, May 13, 2016 10:09 AM
To: cerati/mictest
Cc: Steve Lantz; Comment
Subject: Re: [cerati/mictest] Change mom coord (#46)
CCS (cartesian-curvature-spherical) is fine by me, and I agree about
not using meeting time for this, too close to bikeshedding.
-dan

On May 13, 2016, at 04:00, cerati<EMAIL_ADDRESS>wrote:
I do not think we should devote part of the meeting to the naming
convention, our 1h slot is too short already.
Just to say that "helix parameters" is a too generic definition that
applies to any parametrization (cartesian, "polar", curvilinear, perigee,
etc.).
Our parametrization has two components:

a global cartesian position
a spherical momentum, modified so that the magnitude of the 3D radius
vector is replaced with 1./pT, where 1./pT is the magnitude of the 2D
radius vector and is proportional to the curvature (the fact that pT is 2D
while R is 3D is why I initially suggested polar rather than spherical)

Any name capturing these features is fine with me.
On Fri, May 13, 2016 at 12:23 AM, srlantz<EMAIL_ADDRESS>wrote:

We can talk about it tomorrow if people want. My point is simply that the
goal of these "coordinates" is to describe a geometrical object, namely a
helix. We are saying that the current best estimate of the track is a
z-oriented helix with pitch angle theta and lateral "curvature" 1/pT, and
that point x,y,z is a position at azimuth phi (+/- pi/2) on this helix.
(OK, to make 1/pT into a real curvature, the charge and B should be
included to make it 1/gyroradius; not sure if I have omitted a relativistic
gamma in some of the definitions.) The new coordinates just make it a bit
clearer that we have been talking about such a geometrical object all
along. So call them "helix/helical parameters"?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/cerati/mictest/pull/46#issuecomment-218903131

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHubhttps://github.com/cerati/mictest/pull/46#issuecomment-219053491

This is coming too late for PR #46, but I too am fine with the label CCSCOORD for "Cartesian-Curvature-Spherical".
Or maybe... CCDCOORD, with D=direction? The angles indicate the instantaneous direction of motion of the charged particle following the helix, right?  I maintain that the "spherical" angles also have a clear interpretation as two directional parameters of the helix itself: theta = arctan(pT/pz) = pitch angle, or helix angle; phi = arctan(py/px) = azimuth on the helix, rotated by pi/2. (But maybe "CCD" confuses the experimentalists.)
Steve
PS. Thanks to Dan for reminding me that I hadn't yet responded to Giuseppe's "CCS" proposal. Thanks also to him for chipping in one more argument as to why "helical parameters" is not the best match.
From: cerati<EMAIL_ADDRESS>Sent: Friday, May 13, 2016 6:35 AM
To: cerati/mictest
Cc: Steve Lantz; Comment
Subject: Re: [cerati/mictest] Change mom coord (#46)
Merged #46https://github.com/cerati/mictest/pull/46.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHubhttps://github.com/cerati/mictest/pull/46#event-659746618


Better data transfer between activities, fragments.. more code to other classes

Moved it here @xdk78

#22


docs: Correct code examples in the Apify's notebooks

Description: Correct code examples in the Apify document load notebook and Apify Dataset notebook
Issue: None
Dependencies: None
Twitter handle: None

Import from langchain_core.document_loaders.base import Document should be from from langchain_core.documents import Document

Would you be able to update the import and we can merge then?

@eyurtsev I'm sorry, my bad. Thank you for pointing that out!


Add Privacy Manifest

According to https://developer.apple.com/support/third-party-SDK-requirements/
We need to have a Privacy manifest in this Lib (pretty strange to ask this from an Apple Repo :D )

This isn't a third-party SDK.

Indeed, this package is not third-party SDK, and it isn't subject to these requirements.
(To be very clear, this package does not collect any information whatsoever, neither from end users nor developers. Nor does it use any required reason APIs.)

(If you get feedback otherwise, let us know and we'll look into it!)

It certainly is, you can see from the list that they require manifests even for simple utilities like OrderedSet. So even though they used the term "third-party SDK", they clearly mean any type of code here. But if swift-collections doesn't use required reason APIs then it indeed doesn't need to do anything.

The name OrderedSet in that list refers to a third-party code base ("SDK") of that name.
It does not refer to the type OrderedSet in this package. This package is called "Swift Collections", or "swift-collections", and if it was a third-party SDK (which it most certainly isn't), then it would be listed under that name.
Again, please reach out to me if you get official App Store feedback that indicates otherwise.

@lorentey Hmm… given the potential for confusion and ambiguity here on the part of developers… could we arrange to have that Apple Developer Support page updated with an explicit "allowlist" to make it clear that some Apple GitHub repos are safe to include without a privacy manifest? There's some signal here IMO that it would be helpful to document that and help make things more clear for developers.

@lorentey Yes, I am aware OrderedSet is a different package and that swift-collections doesn't need a manifest as of writing. I was just pointing that many of the "SDKs" in Apple's list are packages just like this one.


Report elapsed time for each spec

It's useful to see elapsed time for each spec.
Dummy Specs
  describe dummy
    should run (22ms)
    takes longer (1s)

2 Examples, 0 Failed, 0 Pending

pushed in 1.0.6 🎉


operators: Fix location of enriched fields

Before this commit operators were creating the enriched field in the root of the data source. This commit fixes that by creating the enriched fields in the same node of the "raw" one.
Testing
I used the following gadget to test it:
#include <vmlinux.h>
#include <bpf/bpf_helpers.h>
#include <gadget/buffer.h>
#include <gadget/macros.h>
#include <gadget/types.h>

enum myenum {
	ONE = 1,
	TWO = 2,
	THREE = 3,
};

// Just to show inner fields
struct inner {
	gadget_uid inner_user_raw;
	gadget_gid inner_group_raw;
	gadget_syscall inner_syscall_raw;
	gadget_errno inner_errno_raw;
	enum myenum inner_enum_raw;
};

struct event {
	__u32 pid;

	gadget_uid user_raw;
	gadget_gid group_raw;
	gadget_syscall syscall_raw;
	gadget_errno errno_raw;
	enum myenum enum_raw;

	struct inner inner;
};

GADGET_TRACER_MAP(open_events, 1024 * 256);
GADGET_TRACER(open, open_events, event);

SEC("tracepoint/syscalls/sys_enter_openat")
int enter_openat(struct trace_event_raw_sys_enter *ctx)
{
	struct event *event;

	event = gadget_reserve_buf(&open_events, sizeof(*event));
	if (!event)
		return 0;

	u64 uid_gid = bpf_get_current_uid_gid();

	event->pid = bpf_get_current_pid_tgid() >> 32;

	event->user_raw = (u32)uid_gid;
	event->group_raw = (u32)(uid_gid >> 32);
	event->syscall_raw = 50; // any number just for testing
	event->errno_raw = 15;
	event->enum_raw = TWO;

	event->inner.inner_user_raw = event->user_raw;
	event->inner.inner_group_raw = event->group_raw;
	event->inner.inner_syscall_raw = event->syscall_raw;
	event->inner.inner_errno_raw = event->errno_raw;
	event->inner.inner_enum_raw = event->enum_raw;

	gadget_submit_buf(ctx, &open_events, event, sizeof(*event));

	return 0;
}

char LICENSE[] SEC("license") = "GPL";

Before
Note: It's possible that you need to avoid running the command multiple types until it works because of the race condition fixed by the first commit of this PR
{
  "enum": "TWO",
  "enum_raw": 2,
  "errno": "ENOTBLK",
  "errno_raw": 15,
  "group": "systemd-oom",
  "group_raw": 117,
  "inner": {
    "inner_enum_raw": 2,
    "inner_errno_raw": 15,
    "inner_group_raw": 117,
    "inner_syscall_raw": 50,
    "inner_user_raw": 108
  },
  "inner_errno": "ENOTBLK",
  "inner_group": "systemd-oom",
  "inner_syscall": "SYS_LISTEN",
  "inner_user": "systemd-oom",
  "pid": 1182,
  "syscall": "SYS_LISTEN",
  "syscall_raw": 50,
  "user": "systemd-oom",
  "user_raw": 108
}

Notice hwo the enriched inner... fields are wrongly added to the root node .
after
{
  "enum": "TWO",
  "enum_raw": 2,
  "errno": "ENOTBLK",
  "errno_raw": 15,
  "group": "systemd-oom",
  "group_raw": 117,
  "inner": {
    "inner_enum": "TWO",
    "inner_enum_raw": 2,
    "inner_errno": "ENOTBLK",
    "inner_errno_raw": 15,
    "inner_group": "systemd-oom",
    "inner_group_raw": 117,
    "inner_syscall": "SYS_LISTEN",
    "inner_syscall_raw": 50,
    "inner_user": "systemd-oom",
    "inner_user_raw": 108
  },
  "pid": 1182,
  "syscall": "SYS_LISTEN",
  "syscall_raw": 50,
  "user": "systemd-oom",
  "user_raw": 108
}

Fields are now added to the correct node
Fixes #3459
TODO
Issues to discuss later on

[ ] We need a Close() method on the operator interface to clean up resources allocated in PreStart()
[ ] We need to test the formatters (or extend them for this case). Perhaps the gadget I provided here can be the base for a new integration test?
[ ] Perhaps it makes sense to define a root node for all objects and make Parent() return it instead of nil.

I think this looks good already!

Perhaps it makes sense to define a root node for all objects and make Parent() return it instead of nil.

Yeah, I think that'd be good. It feels a bit weird that there's a difference in handling.
I thought this had made it already into main, appears it didn't 😄  (it's an alternative to a new dedicated function to add fields). I'm fine either way, however.

I thought this had made it already into main, appears it didn't 😄 (it's an alternative to a new dedicated function to add fields). I'm fine either way, however.

That helps a lot. I used it, thanks!

I'm merging this now. I'll probably explore implementing a unit test once we have merged #3502.


Testing the examples with a UNO

I tried running the example code(sawtooth) wired the setup as below:
5620  - UNO
CLK   - SCK (ICSP HEADER PIN)
DIN   - MOSI (ICSP HEADER PIN)
SYNC - PIN 8 OF THE UNO (As per the line in the example AD5620 AD16_HW(8, &SPI);)
Vdd - 3v3 pin
GND - GND
Tried measuring with an oscilloscope at Vout and GND - only get an erratic waveform that does not correlate with the frequency specified in code. Am I doing something wrong?
Should I be editing the AD5620 AD16_SW(5, 6, 7); line?

Do you know the difference between software SPI and hardware SPI?
If you have a scope you should be able to determine the SPI pins used.

Disconnect the device
Start the sawtooth example
check all pins to see where the clock signal is (train of 8 pulses)
check all pins to see where the data pins is  (variable set of pulses)

Stripped version that uses the software SPI pins (5 = CS, 6 = DATA, 7 = CLOCK).
You should see the pulses of the three lines on the scope.
If not there is a problem with your board.
//
//    FILE: AD5620_sawtooth.ino
//  AUTHOR: Rob Tillaart
// PURPOSE: test basic behaviour and performance
//     URL: https://github.com/RobTillaart/AD5620

#include "AD5620.h"

AD5620 AD16_SW(5, 6, 7);

float frequency = 50;
float amplitude = 4095;  //  12 bits

void setup()
{
  Serial.begin(115200);
  Serial.println();
  Serial.println(__FILE__);
  Serial.print("AD5620_LIB_VERSION: ");
  Serial.println(AD5620_LIB_VERSION);

  AD16_SW.begin();

  Serial.print("HWSPI: ");
  Serial.println(AD16_SW.usesHWSPI());
}

void loop()
{
  float period = 1000000.0 / frequency;
  float value = fmod(millis(), period);   //  0..period
  //  value = period - value;  //  reverse

  value = amplitude * value / period;
  AD16_SW.setValue(value);
  Serial.println(value);
  delay(1);
}

//  -- END OF FILE --

With this sketch you should be able to see signals on

HW SPI pins 8 (SYNC) ,11 (MISO) ,13 (CLOCK)
SW SPI pins 5 (SYNC), 6 (MISO), 7 (CLOCK)

something like

data something like

Between the two data bytes there is a very small moment HIGH (in the middle).

Think I found a bug in the library
from datasheet
In a normal write sequence for the AD5660, the SYNC line is kept low for at least 24 falling edges of SCLK, and the DAC is updated on the 24th falling edge. However, if SYNC is brought high before the 24th falling edge, this acts as an interrupt to the write sequence.
As there are only 2 data bytes to send I bring the sync high after the 16th bit so the device is reset.
So I will create a develop branch which sends three bytes asap.

24 bits clocks out perfectly (no pull ups cause jitter)

@thechordmaster
Please give the develop branch a try.

Root cause is building code on the picture, which shows 16 bit for the AD5620 and AD5640.

@thechordmaster
I have merged the develop branch, and if it doesn't work just open a new issue.
Thanks,


Create release tags for training notebooks

Need to create

release tags for the training notebooks
simple test script to validate that training still works for each platform release
workflow for updating contents to reflect latest release features

Hello Alexander,
I am having issues installing GridAppsD on my  Windows, can you provide any guidance ?
Thank you

Hello Alexander,
I am having issues installing GridAppsD on my  Windows, can you provide any guidance ?
Thank you


Automated API documentation update

Merged in https://github.com/ticketmaster-api-staging/ticketmaster-api-staging.github.io/pull/1756