stringifyQuery does not encode correct

Version
4.1.4
Reproduction link
codesandbox.io
Steps to reproduce

Open https://codesandbox.io/s/kind-ramanujan-rtvq2t
Click on About Link
Check URL path ends with "/about?x=[{()}]" (which is incorrect / no encoding happened)

What is expected?
Expected behaviour would be that the query value of x ([{()}]) is encoded (%5B%7B%28%29%7D%5D).
What is actually happening?
The query value of x is not encoded.

Workaround / Solution
Using qs instead of stringifyQuery, everything works like expected.
Please see this codesandbox.io.
(Possible) Fix
For me, it looks like that the replace attributes of encodeQueryValue are in a wrong order:
It should NOT be .replace(ENC_CURLY_OPEN_RE, '{'), it should be .replace('{', ENC_CURLY_OPEN_RE).
Right now, encodeQueryValue is decoding, not encoding.

Note js cannot control what the browser displays on the URL. The only thing that matters from the router perspective is that the decoding of the query is consistent:

https://rtvq2t.csb.app/about?x=[{()}] -> $route.query is decoded
https://rtvq2t.csb.app/about?x=[{()}] -> same

You can check more about the encoding strategy in the source code: https://github.com/vuejs/router/blob/main/packages/router/src/encoding.ts


wt.exe new-tab [profile] still shows default title bar, whilst selecting another profile.

Environment
Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.11.1121.0

Steps to reproduce

Launch Windows Terminal, edit settings.
Create a profile with an icon, make it default.
Save and close Windows Terminal.
Launch cmd/powershell or use search bar.
Insert command wt new-tab [profile], for example wt new-tab cmd
Review your title bar of your launched profile.

Expected behavior
Profile title and logo should be set as the launched profile.
Actual behavior
Profile image and title bar as it launches is set as the default profile.
Using ubuntu to change to, initializes with default title text, but changes to username@computer later. Icon still on default profile.

Settings.json
Another issues:
Unable to launch profiles with guid's.
-p argument does not launch any selected profile.

You definitely need to provide the -p to make wt.exe select another profile. If you just run wt new-tab cmd, we're going to create a new tab with your default profile, running cmd. Similarly, wt new-tab wsl will create a new tab with your default profile running wsl. The Ubuntu distro also ships a helper ubuntu.exe, so wt new-tab ubuntu just so happens to work to create a new instance running ubuntu.
There are more details in this doc.
Other notes:

 "source": "Windows.Terminal.cmd" - cmd isn't a dynamic profile, it's defined in defaults.json. So this "source" property isn't really doing anything here.
Your cmd profile is marked hidden, so you won't be able to launch it even with wt new-tab -p cmd
You can get rid of experimental_showTabsInTitlebar, that's not being used anymore :)

If so, wt new-tab -p powershell for example, is not launching powershell for me, and is just launching the default profile.
Im not sure why, but the cmd profile with hidden as true, does not hide itself from the dropdown.
Though azure cloud does.
And the last part, i just took this configuration from a random template.

That's because "powershell" isn't the "name" of your powershell profile. "Windows PowerShell" is.
The source property might actually be tripping up our "is this profile the same as another" logic actually. WT thinks that your "cmd" profile is different than the default one. You might be able to remove that and have the "Command Prompt" profile disappear.

And the last part, i just took this configuration from a random template.

Well however you took this template from has got some bugs in their template now don't they 😉

wt.exe new-tab -p "Your WSL profile name" -d "Your WSL home directory path"
run command like this.


update react-native to 0.4.0

This PR updates react-native version to ^0.4
I tested it with an existing app and did not see any issues.

Thanks :+1:

:smile:


updated readme and RequestLogger haddocks

I used wai-extra's readme as an example; it points to an example that uses the middleware so I did the same.
Appreciate feedback on the haddocks.

we have strange error

The command "eval git clone --depth=50 --branch=hs-abci-extra-docs https://github.com/f-o-a-m/hs-abci.git f-o-a-m/hs-abci " failed 3 times.

I think its just a network error on the machine.


Improvement (v2): Allow authors to define a canonical URL to help with SEO

🚀 Feature
Allow users to define an optional canonical URL per doc item.
Have you read the Contributing Guidelines on issues?
Yes
Motivation
Allowing users to define a canonical URL will greatly help with pointing search engines into the right direction, especially when multiple versions of the same doc item exist.
Pitch
As mentioned in the motivation, allowing users to define a canonical URL will greatly help with efforts regarding SEO. Not only will this ensure that search engines know what version of a particular doc item is most relevant, it will also ensure that other versions of the same doc item are known and are pointing to the most relevant / newest version. Also see https://yoast.com/rel-canonical/ for more information.
How this feature could work, is by adding an additional (optional) Markdown property that can defined in the header of the particular doc item. This property can then be used and outputted in the HTML as a <link rel="canonical" href="https://example.com/mydocitem/" />.
If this property is omitted from the header, it should still be outputted in the resulting HTML, but must point to itself.

Hey,
It is possible to use custom SEO components directly inside a markdown file, thanks to MDX. It is not the best DX but is quite flexible in what it can do

# title

Some text

import Head from '@docusaurus/Head';

<Head>
    <title>My custom doc title</title>
    <link rel="canonical" href="http://mysite.com/example" />
</Head>

@slorber In my case, i'd like to add custom  tags to some pages (excluding robots, for example).
I adopted the snippet you've posted, but I cannot get it working.
The MDX syntax is ok, the page is rendering, but the custom header tags don't appear at all.
Here is my markdown page:
---
title: About us
hide_table_of_contents: true
---

# About us

import Head from '@docusaurus/Head';

<Head>
    <meta name="robots" content="noindex,nofollow,noarchive" />
</Head>

Further text is going here

I'm using the latest beta 70, versions 68/69 showed the same behavior.
Is there anything I might have missed?

@slorber In my case, i'd like to add custom  tags to some pages (excluding robots, for example).
I adopted the snippet you've posted, but I cannot get it working.
The MDX syntax is ok, the page is rendering, but the custom header tags don't appear at all.
Here is my markdown page:
---
title: About us
hide_table_of_contents: true
---

# About us

import Head from '@docusaurus/Head';

<Head>
    <meta name="robots" content="noindex,nofollow,noarchive" />
</Head>

Further text is going here

I'm using the latest beta 70, versions 68/69 showed the same behavior.
Is there anything I might have missed?

Hey,
It is possible to use custom SEO components directly inside a markdown file, thanks to MDX. It is not the best DX but is quite flexible in what it can do to override any meta we set by default.
# Markdown title

Some markdown text

import Head from '@docusaurus/Head';

<Head>
    <title>My custom doc title</title>
    <link rel="canonical" href="http://mysite.com/example" />
</Head>

The drawback is that you have to do this for all the docs you want to modify metadata (but that would be similar if we provided a frontmatter option anyway)
Do you think we can close this issue?

Hi @slorber, for some reason I'm only just not getting a notification that you responded.
Sadly, this would mean the doc maintainer (whom might not be the handiest when it comes to writing HTML/MDX), would need to be very aware of the proper syntax, would could easily lead to mistakes IMHO. Having a single property would indeed still mean the author needs to define it for every page that needs it customized, but only having to manipulate an option seems far less cumbersome, from a UX standpoint

Hey,
It is possible to use custom SEO components directly inside a markdown file, thanks to MDX. It is not the best DX but is quite flexible in what it can do to override any meta we set by default.
# Markdown title

Some markdown text

import Head from '@docusaurus/Head';

<Head>
    <title>My custom doc title</title>
    <link rel="canonical" href="http://mysite.com/example" />
</Head>

The drawback is that you have to do this for all the docs you want to modify metadata (but that would be similar if we provided a frontmatter option anyway)
Do you think we can close this issue?

Hi @slorber, for some reason I'm only just not getting a notification that you responded.
Sadly, this would mean the doc maintainer (whom might not be the handiest when it comes to writing HTML/MDX), would need to be very aware of the proper syntax, would could easily lead to mistakes IMHO. Having a single property would indeed still mean the author needs to define it for every page that needs it customized, but only having to manipulate an option seems far less cumbersome, from a UX standpoint

@maxee you are right, it does not seem to work. Will add support for this.
@jcomack , I agree that first-class frontmatter support is simpler, but at the same time you have your usecase for canonical urls and other users have theirs for other metadata. First-class support means we'd end up with an infinite amount of frontmatter metadata we'd have to maintain in every single docusaurus plugin, cluttering the frontmatter API.
Each person can already implement its own doc renderer by swizzling the DocItem component, and adding the required metadata.
What if I made it so it was possible to write meta tags directly in the doc?
---
title: About us
hide_table_of_contents: true
---

<meta name="robots" content="noindex,nofollow,noarchive" />

<link rel="canonical" href="http://mysite.com/example" />

# About us

Further text is going here

What would be the ideal API that would solve all the head meta usecases?
For the canonical URL, I think it's common enough and we can make it an exception and add Yaml support, but still think it's a good idea to provide a generic solution to this problem.
Maybe just supporting link and meta arrays in frontmatter would be enough for a large quantity of usecases? Do you think of other head meta that would be interested to support?
What do you think of using Yaml arrays?
---
title: About us
hide_table_of_contents: true
link:
  - rel: canonical
    href: http://mysite.com/example
meta:
  - name: robots
    content: noindex,nofollow,noarchive
---

# About us

Further text is going here

@maxee you are right, it does not seem to work. Will add support for this.
@jcomack , I agree that first-class frontmatter support is simpler, but at the same time you have your usecase for canonical urls and other users have theirs for other metadata. First-class support means we'd end up with an infinite amount of frontmatter metadata we'd have to maintain in every single docusaurus plugin, cluttering the frontmatter API.
Each person can already implement its own doc renderer by swizzling the DocItem component, and adding the required metadata.
What if I made it so it was possible to write meta tags directly in the doc?
---
title: About us
hide_table_of_contents: true
---

<meta name="robots" content="noindex,nofollow,noarchive" />

<link rel="canonical" href="http://mysite.com/example" />

# About us

Further text is going here

What would be the ideal API that would solve all the head meta usecases?
For the canonical URL, I think it's common enough and we can make it an exception and add Yaml support, but still think it's a good idea to provide a generic solution to this problem.
Maybe just supporting link and meta arrays in frontmatter would be enough for a large quantity of usecases? Do you think of other head meta that would be interested to support?
What do you think of using Yaml arrays?
---
title: About us
hide_table_of_contents: true
link:
  - rel: canonical
    href: http://mysite.com/example
meta:
  - name: robots
    content: noindex,nofollow,noarchive
---

# About us

Further text is going here

@slorber
For the head meta-usecases, i like the idea with the YAML arrays. Fits perfect for meta-tags.
For all other use cases I think a generic solution like the one you described in your first answer (MDX) would be good.
If the MDX-solution would work, all further use cases would be covered.
However if realization of the MDX-solution is too complex I'd go for the YAML arrays for link-tags as well.

@slorber
For the head meta-usecases, i like the idea with the YAML arrays. Fits perfect for meta-tags.
For all other use cases I think a generic solution like the one you described in your first answer (MDX) would be good.
If the MDX-solution would work, all further use cases would be covered.
However if realization of the MDX-solution is too complex I'd go for the YAML arrays for link-tags as well.

Any updates on this issue? It's documented here: https://docusaurus.io/docs/docusaurus-core#head but totally doesn't work

Hey
I'm adding support for using <head> in md files as a shortcut to the Docusaurus <Head> component in PR https://github.com/facebook/docusaurus/pull/5330
I prefer this solution based on <Head> because it is more flexible than yaml and cover various use-cases at once, including adding html/body attributes, and can even support evaluating the metadata at runtime thanks to MDX.
This will now work:
---
id: my-doc-id
---

<head>
    <link rel="canonical" href="http://mysite.com/example" />
</head>

# Markdown title

Some markdown text


Remove list item class

This is a work in progress, but wanted to get it up here to get feedback. This (again) has to use css selectors to reach into the structure to assert various things:

[x] Remove all references to ember-list-view-item
[x] Create helpers to reduce amount of :spaghetti:
[ ] Replace all selector usages with helpers

@mmun before I go too far on this, what are your thoughts?

The helper functions are a lot nicer. Keep goingggg :D

@mmun this is done (I think), flattened and ready to merge.

:+1:

very nice :)


Improve usage on indexes on document listing

Currently, the document listing for each collection expects the meta().id to be indexed (via primary or secondary indexes). However, if the document has an index on another attribute like "name" or "email", we won't be able to use that and we will fallback to KV

released on 1.0.10


Fix group overload; run Pyright in strict mode

Additional fixes for #2558 building on @tinche's PR :)

Checklist:

[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[ ] Add or update relevant docs, in the docs folder and in code.
[ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[ ] Run pre-commit hooks and fix any issues.
[x] Run pytest and tox, no tests failed.

Out of curiosity, what does strict mode do for pyright?

It turns on these additional checks.  In my experience Pyright won't error for type vars it's not able to solve in the default type checking mode.  The group overload error would've been caught by the assert, but there might be auxiliary errors we are not explicitly testing against that strict mode might be able to detect.

Cool, thanks. What's the default type checking mode?  Might want to add a changelog entry.

Will this resolve the typing of:
@click.group()
def cli():
    pass

@cli.command()
@click.argument("version")
def release(version: str) -> None:
    # ...

or is this a distinct issue?

That doesn't produce an error for me. Have you tried with click 8.1.5?

@layday
λ pip freeze | egrep 'click|mypy'
click==8.1.5
mypy==1.4.1
mypy-extensions==1.0.0

λ cat xx.py
import click

@click.group()
def cli() -> None:
    pass

@cli.command()
@click.argument("version")
def release(version: str) -> None:
    pass

λ mypy --strict xx.py
xx.py:8: error: <nothing> has no attribute "command"  [attr-defined]
xx.py:8: error: Untyped decorator makes function "release" untyped  [misc]
Found 2 errors in 1 file (checked 1 source file)

Click 8.1.6 released.


ENH: sparse.linalg.eigsh: performance issue

Is your feature request related to a problem? Please describe.
when calculate the eigenvalue of big dimension sparse matrix used scipy.sparse.linalg.eigsh on super computer with AMD Threadripper, we will find that the python progress can only occupy at most 64 cores while a large part of RAM is idle.
Describe the solution you'd like.
it can use more cores when possible.
Describe alternatives you've considered.
not yet now
Additional context (e.g. screenshots, GIFs)
No response

What is the platform you are using? AFAIK the windows platform has a processor group issue. And what exact threadripper you are using? If it's not 7995WX you could try to simply disable SMT to resolve the case since SMT usually does not bring more performance under compute-intensive workloads.


First contribution

I've created a file Read_me.md for contributing to this open source project under the Good first issue. Review my edits.
Thank you

Hello @khush31! A README.md already exists in the project.


Allow FTDI devices

This patch detects FTDI based COM ports in addition to pure Teensy devices. It doesn't yet detect physical COM ports.

Sorry, something went wrong here. I'll resubmit another Pull request

OK, I simply forgot to commit to master before syncing with remote. Git newbie here...  Thanks for the fix!

Note from other combo issue - the FTDI needs means to init USB 'Serial' speed to actually work end to end.
I always wondered what that seemingly pointless baud dropdown was in the IDE for - it works with FTDI.


Support tracing recursive find content history network requests

What was wrong?
It's tricky to see the path a recursive find network request follows as it hops from enr to enr in the network looking up the target content. Also, it's useful to know which enr actually returns the target content.
How was it fixed?
Add support for a portal_traceHistoryRecursiveFindContent request.
Fixes #469
To-Do

[ ] Add entry to the release notes (may forgo for trivial changes)
[ ] Clean up commit history

@jacobkaufmann Thanks for the review, I wasn't too familiar with the inner workings of the query pool, and leveraging closest_nodes seems like a better, less complex mechanism than the "route" attribute I introduced in the first commit.
A couple thoughts on using the closest_nodes approach...

closest_nodes will only contain a max of config.num_results nodes. So, the returned trace will be incomplete if it took more than 20 (the default) "hops" to find the target content.

One approach I tried to mitigate this was returning the full list from the query and truncating the result at the overlay_service level, but this broke the test here and I'm unsure if that's acceptable.

Iiuc, closest_nodes will return all nodes that responded successfully during query execution. eg. we could receive a redundant ClosestNodes response right before receiving a Content response from a different node, resulting in returning closest_nodes that were never actually part of the "path" traversed towards the content.

tbf... my "route" approach had this same issue.

imo, returning a precise trace will require additional, possibly complex, logic. also imo, I'm not sure that additional logic is very useful at this point, especially when we're dealing with a relatively small testnet. But, it's probably something we might want to consider as the network grows.

closest_peers will only contain a max of config.num_results nodes. So, the returned trace will be incomplete if it took more than 20 (the default) "hops" to find the target content.

If you look at the query polling logic, once we have config.num_results successful responses, then the query is marked as finished, so there cannot be more than config.num_results successful "hops". If you try to advance the query after it is marked as finished, then it will be a no-op. Maybe there is an edge case, but at first glance the problem you describe does not seem to exist.

Iiuc, closest_peers will return all nodes that responded successfully during query execution. eg. we could receive a redundant ClosestNodes response right before receiving a Content response from a different node, resulting in returning closest_peers that were never actually part of the "path" traversed towards the content.

I'm having a hard time understanding the scenario you are describing here. Specifically, I don't understand how we would return peers that were never contacted as part of the query. Can you clarify?

imo, returning a precise trace will require additional, possibly complex, logic.

I agree. I think a more precise trace would yield a nested structure, which provides not just a list of nodes contacted but which nodes returned which other nodes, and allow you to follow the path traversed toward the content. This would require more complex changes.

Maybe there is an edge case, but at first glance the problem you describe does not seem to exist.

:+1:

Can you clarify?

It seems to me like it's possible that a ClosestNodes response from peer "A" updates closest_peers with a set of peers, and immediately after we receive a Content response from peer "B", before we're able to contact the peers from peer "A"'s response. In this case, closest_peers would contain node info for some peers who were never actually contacted during query execution.
It's also possible that I'm misunderstanding this?

I agree. ... . This would require more complex changes.

Cool. Imo, introducing this complex logic isn't necessary at this point. It will surely have to manage many edge cases, which really isn't a huge priority. Imo, improving the accuracy of the trace can be tracked in an issue for the time being. What do you think? Is a "general approximation of the trace" sufficient for now?

It seems to me like it's possible that a ClosestNodes response from peer "A" updates closest_peers with a set of peers, and immediately after we receive a Content response from peer "B", before we're able to contact the peers from peer "A"'s response. In this case, closest_peers would contain node info for some peers who were never actually contacted during query execution.

The result of a FindContentQuery will never contain peers who were not successfully contacted. A peer is only marked "successful" when the query is advanced with a response from that peer.
If that is not clear, then I can go into more detail.

@mrferris Nice! yeah, continue was exactly what I was looking for. I added a test scenario with invalid find content params to ensure that the channels stay alive if the endpoint execution exits early.


tiled support

We are observing an issue while running pdfstream in the 2022-2.3-py38-tiled conda environment with tiled and databroker>=2.0 at NSLS-II XPD:
$ start_analysis_server
Traceback (most recent call last):
  File "/nsls2/conda/envs/2022-2.3-py38-tiled/bin/run_server", line 10, in <module>
    sys.exit(run_server())
  File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/pdfstream/main.py", line 71, in run_server
    fire.Fire(_run_server)
  File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/fire/core.py", line 466, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/fire/core.py", line 681, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/pdfstream/main.py", line 56, in _run_server
    import pdfstream.servers.xpd_server as xpd_server
  File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/pdfstream/servers/xpd_server.py", line 4, in <module>
    import databroker.core
ModuleNotFoundError: No module named 'databroker.core'

Is there a plan to implement the support of tiled in this package?

I am doing that. I will make sure it is compatible with the tiled in the
version 0.6.1.
On Thu, Sep 1, 2022 at 10:49 AM Maksim Rakitin @.***>
wrote:

We are observing an issue while running pdfstream in the
2022-2.3-py38-tiled conda environment
https://urldefense.proofpoint.com/v2/url?u=https-3A__zenodo.org_record_6503107&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=iQAr_emySpPT6JUutZSgOiuHUAhXW2EDDtvsWMwHgLs&m=5PDl097PocxSbnuq3M-GfakPUcJndXDivGc7BlQGGjuRIs3cWykFPAg40WSJnPi8&s=HMz6qiYa0njlpOz0zksXJPFuHmFKY1oD6njuAeYt5OY&e=
with tiled and databroker>=2.0 at NSLS-II XPD:
$ start_analysis_serverTraceback (most recent call last):
File "/nsls2/conda/envs/2022-2.3-py38-tiled/bin/run_server", line 10, in
sys.exit(run_server())
File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/pdfstream/main.py", line 71, in run_server
fire.Fire(_run_server)
File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/fire/core.py", line 141, in Fire
component_trace = _Fire(component, args, parsed_flag_args, context, name)
File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/fire/core.py", line 466, in _Fire
component, remaining_args = _CallAndUpdateTrace(
File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/fire/core.py", line 681, in _CallAndUpdateTrace
component = fn(*varargs, **kwargs)
File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/pdfstream/main.py", line 56, in _run_server
import pdfstream.servers.xpd_server as xpd_server
File "/nsls2/conda/envs/2022-2.3-py38-tiled/lib/python3.8/site-packages/pdfstream/servers/xpd_server.py", line 4, in
import databroker.coreModuleNotFoundError: No module named 'databroker.core'
Is there a plan to implement the support of tiled in this package?
—
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_xpdAcq_PDFstream_issues_53&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=iQAr_emySpPT6JUutZSgOiuHUAhXW2EDDtvsWMwHgLs&m=5PDl097PocxSbnuq3M-GfakPUcJndXDivGc7BlQGGjuRIs3cWykFPAg40WSJnPi8&s=yseaSaBAy5xtQgdBcW29Ix2YgQlaJCef2Jcl1oa7lA4&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AI27ND2IHKLBBDOCSTDPHRDV4C65ZANCNFSM6AAAAAAQCN4SYE&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=iQAr_emySpPT6JUutZSgOiuHUAhXW2EDDtvsWMwHgLs&m=5PDl097PocxSbnuq3M-GfakPUcJndXDivGc7BlQGGjuRIs3cWykFPAg40WSJnPi8&s=fxNGuB9OfEqfCO7BstuA7qQKInXLbo7dCzM6-Q3wMfo&e=
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks for the quick feedback, @st3107! Any idea when can we expect it?

I will do it this week. If this should be quick.
On Thu, Sep 1, 2022 at 10:56 AM Maksim Rakitin @.***>
wrote:

Thanks for the quick feedback, @st3107
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_st3107&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=iQAr_emySpPT6JUutZSgOiuHUAhXW2EDDtvsWMwHgLs&m=KyXTEO8dw5QAoip4ZKHzS2q0WyybgHu5bD4YtEY6YFbeg3PEMJHKMEJBHENgamYb&s=TSsM-D6LGCEC1enbOjVNxky4pLJgRDQeqLhIjZ33VCI&e=!
Any idea when can we expect it?
—
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_xpdAcq_PDFstream_issues_53-23issuecomment-2D1234397382&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=iQAr_emySpPT6JUutZSgOiuHUAhXW2EDDtvsWMwHgLs&m=KyXTEO8dw5QAoip4ZKHzS2q0WyybgHu5bD4YtEY6YFbeg3PEMJHKMEJBHENgamYb&s=_FCjzOYCkuh3z9basRJ1ZSn6QxOdvKex0lkCcF45GYY&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AI27ND4S33S5I2MIH24454DV4C7ZNANCNFSM6AAAAAAQCN4SYE&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=iQAr_emySpPT6JUutZSgOiuHUAhXW2EDDtvsWMwHgLs&m=KyXTEO8dw5QAoip4ZKHzS2q0WyybgHu5bD4YtEY6YFbeg3PEMJHKMEJBHENgamYb&s=Dwz1XfOwzmEoJfsMYHlC78PT8XeN3TEn4f6rlLQ0Cw8&e=
.
You are receiving this because you were mentioned.Message ID:
@.***>

@mrakitin There is a bug about the temp in databroker. There is a PR to fix it but it hasn't been merged yet.
https://github.com/bluesky/databroker/pull/726
I need the temp db to test my software. Otherwise, I don't know if it works for the databroker or not. I will wait for the fix of the temp db and then do a test.

@st3107, the new version of databroker with the requested fix is ready (see https://github.com/conda-forge/databroker-feedstock/pull/44 for more details). Thanks!

bump

Thank you. I will check my software and make the update.
On Thu, Sep 15, 2022 at 3:08 AM Maksim Rakitin @.***>
wrote:

@st3107
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_st3107&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=iQAr_emySpPT6JUutZSgOiuHUAhXW2EDDtvsWMwHgLs&m=-yGLm9nOOLj4iXsvxPhmrpE1h5fQXpMPpQ8B6S0twa7mkIHiEVKbZoMehLxMEkuT&s=R--DG5YcRzIwlzpxrFd776gs43ZjJrKmktSNiLbJUAk&e=,
the new version of databroker with the requested fix is ready (see
conda-forge/databroker-feedstock#44
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_conda-2Dforge_databroker-2Dfeedstock_pull_44&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=iQAr_emySpPT6JUutZSgOiuHUAhXW2EDDtvsWMwHgLs&m=-yGLm9nOOLj4iXsvxPhmrpE1h5fQXpMPpQ8B6S0twa7mkIHiEVKbZoMehLxMEkuT&s=USf9Btt8ECFcsfFsv0GDmjd3X5AfDhkEuOdbb5tNHDw&e=
for more details). Thanks!
—
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_xpdAcq_PDFstream_issues_53-23issuecomment-2D1247673167&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=iQAr_emySpPT6JUutZSgOiuHUAhXW2EDDtvsWMwHgLs&m=-yGLm9nOOLj4iXsvxPhmrpE1h5fQXpMPpQ8B6S0twa7mkIHiEVKbZoMehLxMEkuT&s=tfJJWk70c1IhncoPM9JXY6YJ1Nh5Rk0MeLvsbtkVmI4&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AI27ND4XFD2K7XTLWNMDJFTV6LDPFANCNFSM6AAAAAAQCN4SYE&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=iQAr_emySpPT6JUutZSgOiuHUAhXW2EDDtvsWMwHgLs&m=-yGLm9nOOLj4iXsvxPhmrpE1h5fQXpMPpQ8B6S0twa7mkIHiEVKbZoMehLxMEkuT&s=-AxBK4T4stY87wOOhwfEl4Elsu0RZCZvSgCsI5dcI-w&e=
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thank you! @sghose asked about it yesterday.


Change TypeScript return type to HTMLElement

Element is the correct return type, but also pretty useless because each and every select still has to include casting:

select(".something").style.color = "red";
// TS2339: Property 'style' does not exist on type 'Element'.

select<HTMLElement>(".something").style.color = "red";
// ok

This PR would fix the most common usage of select and leave only SVGElements to be casted, which is much more rare.

I agree. Let's be pragmatic.


WIP Add Tests for "PSCredential"

Create acceptance tests for DSC resources that use a "PSCredential" parameter
data type. This PR needs #93 merged first. DO NOT MERGE.

@cowofevil feel free to rebase


Crontab to push rosters out quarterly

There is a cron job under user 'to...' to run this quarterly.  to view it  $ crontab -l
0 7 1 */3 *     wget https://web.site/clubs/badge-rosters?club&email=1
if it doesn't run by itself again in Apr 1, we will need to adjust it.

There is a cron job under user 'to...' to run this quarterly.  to view it  $ crontab -l
0 7 1 */3 *     wget https://web.site/clubs/badge-rosters?club&email=1
if it doesn't run by itself again in Apr 1, we will need to adjust it.

Crontab command was not 'Quoted', should run properly next quarter.

This Worked...


Fix bad LOD selection when Camera in Mesh AABB

Fixed an issue where a bad LOD would be selected although the Camera being inside the Meshes AABB.

Related to https://github.com/godotengine/godot/pull/79191

Yeah it fixes the MRP in #67890 but i don't really know if its a better solution than #79191. I primarily tried to fix an issue when the Camera is inside a really big MultiMeshInstance.

CC @fire Does this PR fix your use-case?

I'll try to review later today. @lyuma too. I'll run my test case.

Please use AABB::has_point().
It doesn't solve my use case of giving a heuristic guess for decimation of avatars given they're inside the aabb.
The consensus is that picking distance 0 (which we've discussion is not the original mesh) for when the camera is inside the AABB.
We don't have consensus for the heuristic guess.

Looks great! The final step before merging is to squash all the commits together so that the whole PR only contains 1 big commit with all your changes. We like to merge one commit at a time to keep the git history clean and navigable.
If you don't know how to do that, we have a helpful tutorial in the official documentation https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase

Thanks! And congrats on your first merged Godot pull request!


bazel run works but bazel test does not

Hello,
I tried defining a simple test like:
load("@rules_cuda//cuda:defs.bzl", "cuda_library")

package(default_visibility = ["//visibility:public"])

cuda_library(
    name = "kernel",
    srcs = ["kernel.cu"],
    hdrs = ["kernel.h"],
)

cc_test(
    name = "hello_world_test",
    srcs = ["hello_world_test.cc"],
    deps = [
        ":kernel",
        "@gtest",
    ],
)

When I use run it works, but not test.
run:
bazelisk run //tests/hello_world_cuda:hello_world_test

INFO: Analyzed target //tests/hello_world_cuda:hello_world_test (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //tests/hello_world_cuda:hello_world_test up-to-date:
  bazel-bin/tests/hello_world_cuda/hello_world_test
INFO: Elapsed time: 0.165s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Running command line: external/bazel_tools/tools/test/test-setup.sh tests/hello_world_cuda/hello_world_test
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //tests/hello_world_cuda:hello_world_test
-----------------------------------------------------------------------------
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from HelloTest
[ RUN      ] HelloTest.LaunchKernel
kernel launched![       OK ] HelloTest.LaunchKernel (65 ms)
[----------] 1 test from HelloTest (65 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (65 ms total)
[  PASSED  ] 1 test.

test:
==================== Test output for //tests/hello_world_cuda:hello_world_test:
/home/francesco/.cache/bazel/_bazel_francesco/0d938cee14819e1a300aa4caa3adcb3b/sandbox/linux-sandbox/1762/execroot/test_repo/bazel-out/k8-opt/bin/tests/hello_world_cuda/hello_world_test.runfiles/test_repo/tests/hello_world_cuda/hello_world_test: error while loading shared libraries: libcudart.so.11.0: cannot open shared object file: No such file or directory

Are there particular flags I need to add for test?
Right now my .bazelrc looks like
# CUDA setup
build --flag_alias=enable_cuda=@rules_cuda//cuda:enable
build --flag_alias=cuda_archs=@rules_cuda//cuda:archs
build --flag_alias=cuda_compiler=@rules_cuda//cuda:compiler
build --flag_alias=cuda_copts=@rules_cuda//cuda:copts
build --flag_alias=cuda_runtime=@rules_cuda//cuda:runtime
build --enable_cuda=True
build --cuda_archs=sm_80

Thanks!

What is your bazel version? And what is the output of ldd hello_world_cuda?
I acctually cannot repro the issue locally. Currectly it does not work if the host toolchain is not properly configured. The imported runtime library is specially handled so it will not link by the path in sandbox, instead, it will refer to your host system.

Hi, sorry for the delay.
Bazel version is 6.0.0, however I realized that my .bazelrc also has the following build --incompatible_strict_action_env
If I remove that, it works.
Alternatively, I can add test --action_env=LD_LIBRARY_PATH=/usr/local/cuda/lib64 and keep the above flag.
I suppose it would be nice to add the ability to download the cuda library explicitly such that one doesn't need to fiddle with environment variables.

PR #72 will make the rule hermatic, but it will take some time tho.


Recommend top-rated similar genre books, when recommendations are short

Description

Fixed get_rated_bookids function
When combining the two recommendation lists, if that list<recommendations(9) then my code snippet is executed which fills in remaining books to be recommended, half from cv_bookids and the other half with top rated books of the most common genre among already_rated_books and the books yet recommended.
To recommend most rated genre book, A pickle file was created to store the value of the dictionary storing the same, files used can be accessed here
Issue #38

Affected Dependencies
Changes are made only into mainapp/views.py and helper.py affecting the personalized-recommendations section of the project
How has this been tested?
Tested on python shell manually as well as on the main project webpage. Rated 5 different books, when the best_bookids was calculated manually, only 5 books were recommended even after summing up bookids from cv_bookids and embedding_bookids and thus my code snippet executed and added 2 bookids from cv_bookids and 2 similar genre books
Checklist

[x] I have followed the Contribution Guidelines.
[x] My changes do not edit/add any unrequired files.
[x] My changes are covered by tests.

@saaalik Re-request a review when the comments are resolved, Thanks

Added some comments, also you would need to write unit tests for the most_common_genre_recommendations function, +1 if you change the count_vectorizer_recommendations function name to tfidf_recommendations

I don't know how what books will be genreated by genre_wise function for any test cases, because genre_wise function returns different books every time, What I can do is check for the most_common_genre among books i.e.(set(best_bookids + list(already_rated) + best_bookids_tfidf)) and cross check the genre of n2 recommended books by the function most_common_genre_recommendations like this...
In this test case the most common genre is fiction

Added some comments, also you would need to write unit tests for the most_common_genre_recommendations function, +1 if you change the count_vectorizer_recommendations function name to tfidf_recommendations

I don't know how what books will be genreated by genre_wise function for any test cases, because genre_wise function returns different books every time, What I can do is check for the most_common_genre among books i.e.(set(best_bookids + list(already_rated) + best_bookids_tfidf)) and cross check the genre of n2 recommended books by the function most_common_genre_recommendations like this...
In this test case the most common genre is fiction
Yes exactly you can do that and vary the test cases with edge ones

These are the test cases for the function, please have a look

A general guideline for creating TC for your changes

Assume already  has atleast >= 5 books
bestbookids - embeddings can have 0-6 books
All other variables will change according to the above variables, you already know what values will they be if you fix some values above, so you just have to assert that, similarly make multiple test cases for different scenarios

TESTCASES for most_common_genre_recommendations

TESTCASES for the Counter bit edited to return most common genre based on priority list
Link to the py file for testing

Is testfiles a folder in the repo? I don't understand

@saaalik This one

Hi @saaalik could you check the tests I had added some comments

Hi @saaalik could you check the tests I had added some comments

I have removed the hard coded priority list as well as the bookids instead randomised their selection and also changed the code such that it finds the book count of the highest frequency books most_common_dict, and make a dictionary with key as genre and value as book count, after that the genre with highest book count is selected

I've left the percentile input to default, I can't understand its functionality, what should be the ideal value for percentile in genre_wise function?

Some checks are failing, you can run the checks on local, see the contributing.md file.
The percentile is just a cutoff, you can think of it as top books that are liked by 85% people, you can leave it at the default value

Added the changes, please review

Hi @saaalik could you update the fork, we'll make the changes and merge it

I have updated the fork, I am sorry I wasn't able to fix the issue properly, this was my first time contributing to a project of this scale. But I couldn't find what I was doing wrong to get an error in some test cases

No probs


Bug: individual plots log scale

Issue
Closes #118
Description
Log scale of individual plots not working
Definition of Done

[x] Should correctly transform to log
[x] Values =0 filtered out (only for log scale)
[ ] Plot follows same steps as the mean plot counterpart

How to test
Outputs -> Individual Plots -> Log scale
Contributor checklist

[ ] Code passes lintr checks
[ ] Code passes all unit tests
[ ] New logic covered by unit tests
[ ] New logic is documented

Notes to reviewer
Values = 0 filtered out for log scale as 0s cannot be plotted on a log scale.

@js3110 Noticed DOSEA = 50 is not considered in Individual plots but it appears in mean plots! Could you guess why? Might be something involving the pre-filterings I guess...

it is showing up for me.... PT 11201 for example


Experiencing a lot of delay when running the bevy demo

I have not changed anything in the demo, but i have what feels like almost 2 seconds of lag/delay. Running on Windows with a 5700x, low CPU usage
There's a chance I'm misunderstanding what exactly the demo is trying to convey, in that case please enlighten me :)
https://user-images.githubusercontent.com/7693663/220180269-3b536b2d-a7a9-4472-abd2-a5f9407a4cdc.mp4

Yep no worries, that does look a little slower than I'd predict, but it is in the ballpark of what I'd expect.
The Bevy demo currently runs default with the average-case LinkConditioner enabled:
https://github.com/naia-lib/naia/blob/8bb3c9179cd141aa52a2681ac564b3835181fc5d/demos/bevy/shared/src/protocol.rs#L12
That includes 200 ms of latency, 20 ms of jitter, and a 5.5% chance of packet loss. The client will run 3x the standard deviation of jitter so that 99.7% of packets arrive on time, so that's probably around the full 20ms.  Also it runs 1 full tick ahead of the server so in this case it's 25 ms more. So yeah, I'd expect 245 milliseconds of delay here.

Yep so there will be stutters/resyncs on the Bevy demo in main right now, as jitter/packet loss should occasionally cause input messages to be dropped, causing a client mis-predict, which is then reconciled by the client teleporting slightly to the authoritative position.
On top of that, you'll notice that even when removing the simulated packet loss / jitter, there may be some stutters. That's because, unlike client-side state which can "interpolate-on-the-fly" via things like delta time (i.e. https://bevy-cheatbook.github.io/features/time.html#delta-time), time in a Naia client is "quantized" not to the tick rate, but to the average tick duration of the Server. This allows the Client to adjust time on the fly if, say, the Server starts to run slower than the tick rate. However, at the millisecond-to-nanosecond level the tick rate should be constantly fluctuating.
I believe that all real-time networking models require some level of frame-interpolation on the client to reduce stutter of irregular incoming state updates. Naia is no exception. The Bevy demo currently doesn't include this interpolation, as there's many different possible strategies for this depending on your game and priorities. However, I plan to modify the demos soon to show off a working frame interpolation solution in the near future.

Now, if you're seeing some delay between keypress and white square movement in the demo ... that would be a problem. Interested to know if that's your experience :)

Thanks again for the explanation, judging by the amount of stutter i saw even on the average LinkConditioner I believe that they would be almost invisible with interpolation. Would be nice at some point to make a first-person demo to see how the packet loss feels there, event with interpolation.
In the Overwatch talk you linked he went over how they always send the last 15 frames or so of input, such that missed packages can be picked-up as long as they're within the buffer frame. Are you doing anything like this yet,  if not then i'd assume this would remove some of the jitter in movement ?
I fortunately did not experience any delay from keypress to initial movement :)

Yep Naia originally automatically implemented frame-interpolation way back but I removed it when realizing there were many use-cases where you'd want finer control of what and how everything interpolates. But my experience was that it looks super smooth.
And yeah, Naia's Tick Buffered Message Channels send all previous input that can possibly still be received by and processed by the server, every Tick. In average conditions the redundancy will be somewhat small however, as the number of times a command would be sent would be equal to ((jitter * 2) / tick rate) + 1.
I still need to implement some way for the Client to measure packet loss % in order to adjust it's own delay length to compensate for this (as explained in the Overwatch video)

I am going to close this issue as I believe NotHolst's questions have been answered (please re-open if not!) Thank you!


negated_normal crashes when input contains a boolexpr compared with an numexpr.

Bug found with fuzztesting, running on flatten_constraint
example: iv = intvar(-8,8, shape=3)
cons = [(iv[0] == iv[1]) == (iv[2] + 3)]
negated_normal(cons[0])
example of how flatten leads to this bug:
cons = [(iv[0] == iv[2]).implies((iv[0] == iv[1]) == (iv[2] + 3)) == 0]
flatten_constraint(cons)

runnable code:
from cpmpy import *

import numpy

iv = intvar(-8,8, shape=3)

cons = [(iv[0] == iv[1]) == (iv[2] + 3)]
transformations.flatten_model.negated_normal(cons[0])

# example of how flatten leads to this bug:

cons = [(iv[0] == iv[2]).implies((iv[0] == iv[1]) == (iv[2] + 3)) == 0]
transformations.flatten_model.flatten_constraint(cons)

This is another argument for a is_numexpr helper function, the is_num check fails here because it is a numerical expression not a variable or number


Mark remote files as not live if not written to within some period

I have chosen a cutoff of 1 day for now. Would also be good to have a manual resync button in the UI.

Need to check that files are not just currently being over-synced and adjust this PR accordingly.


[C++][Parquet] Arrow thirdparty build fails on multiarch systems

See build failure: https://circleci.com/gh/wesm/parquet-cpp-feedstock/15. Must set CMAKE_INSTALL_LIBDIR now
Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=wesm) / @wesm
Note: This issue was originally created as PARQUET-959. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Issue resolved by pull request 303
https://github.com/apache/parquet-cpp/pull/303

Wes McKinney / @wesm:
PR: https://github.com/apache/parquet-cpp/pull/303


Is "EMKmeans" typo?

Is this typo? Dose EMKmeans mean E"S"Kmeans?
If this is typo, I will fix it.
https://github.com/tttslab/spolacq/blob/6fb6088162ab9d9a683e5cca39a2db60ada749c8/egs/run.bash#L39

I think so.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_4d61d988-4f36-49d8-86e0-66d2c51973d2/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_4d61d988-4f36-49d8-86e0-66d2c51973d2.git

Docs Build status updates of commit 50c7352:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/opstest2/docs-archive-test-source. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Use of unresolved identifier 'failureHandler'

Beginner coder here, not sure what I've done wrong but Xcode is shouting at me from this line:
oauthswift.authorizeWithCallbackURL( NSURL(string: "http://google.com"), scope: "basic", state:"INSTAGRAM", success: {
credential, response, parameters in
println(credential.oauth_token)
}, failure: failureHandler)
Error is as title states, "unresolved identifier". Obviously because failureHandler was never declared but declaring shoots out even more errors. Thanks for any advice in advance.

"unresolved identifier" means not defined...
I see, you copy readme code
Go to demo to have real code
https://github.com/dongri/OAuthSwift/blob/master/OAuthSwiftDemo/ViewController.swift
oauthswift.authorizeWithCallbackURL( NSURL(string: "http://google.com"), scope: "basic", state:"INSTAGRAM", success: {
credential, response, parameters in
println(credential.oauth_token)
},  failure: {(error:NSError!) -> Void in
            print(error.localizedDescription)
})

state:"INSTAGRAM" is for instagram
you can generate string like that
        let state: String = generateStateWithLength(20) as String

Then http://google.com is not a valid callback url, it must be an url that you must handle by url scheme (see readme  and the scheme must be yourapplicationname://) or by implementing a webview and its delegate  - in final OAuth2Swift.handleOpenURL(url) must be call

You got it man. Thank you very much for your support. Much appreciated.


bff list certificates stub

Scope of changes
This adds stubs for a list certificates endpoint on the bff. When we get the admin API endpoint up and running and have the ability to authenticate with it from the bff, then we can fully implement this endpoint.
Type of change

[ ] bug fix
[x] new feature
[ ] documentation
[ ] other (describe)

Acceptance criteria
The certificate reply structure should make sense.
Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #596 (a14a428) into main (e535df6) will decrease coverage by 8.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   46.33%   37.98%   -8.36%
==========================================
  Files         510      154     -356
  Lines       14903     2427   -12476
  Branches     1171      614     -557
==========================================
- Hits         6906      922    -5984
+ Misses       6949     1329    -5620
+ Partials     1048      176     -872

Impacted Files
Coverage Δ

...b/gds-user-ui/src/modules/auth/login/user.slice.ts

web/gds-user-ui/src/theme/index.ts

...ds-user-ui/src/components/Header/LandingHeader.tsx

...ser-ui/src/components/TechnicalResources/index.tsx

web/gds-user-ui/src/reportWebVitals.ts

web/gds-user-ui/src/application/routes/index.tsx

web/gds-user-ui/src/components/ui/Button.tsx

...ser-ui/src/components/NameIdentification/index.tsx

...hub.com/trisacrypto/directory/pkg/sectigo/creds.go

...b.com/trisacrypto/directory/pkg/gds/tokens/mock.go

... and 346 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e535df6...a14a428. Read the comment docs.


Failed to build shared libs because libzueci is static

_deps/zueci-build/libzueci-static.a(zueci.c.o): relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with -fPIC

It seems zueci is not compiled with position-independent code enabled, which then caused the ZXing-cpp shared lib to fail. Any suggestions on how to solve this?

On commit 50f53ef73f610788feaebd4159f8e4b32e6d38d8

https://github.com/nu-book/zxing-cpp/blob/master/core/CMakeLists.txt
Here in line 444, target_link_libraries is set to zueci-static. Can we solve the issue by linking with the dynamic lib here?

Could you please try to add the line
set(CMAKE_POSITION_INDEPENDENT_CODE ON)

next to the set(ZUECI_STATIC ON CACHE INTERNAL "") in core/CMakeLists.txt?


Do not ignore error on ingress reconciliation

I got no ingress reconciled without a reason, now I have a reason, even if no clue about that ;)
Any hint? this is the error I'm getting now:
{"level":"info","ts":1572955547.78623,"logger":"fallback","caller":"common/reconciler.go:31","msg":"Reconciling ingress :&{{Ingress networking.internal.knative.dev/v1alpha1} {sample  camel-k /apis/networking.internal.knative.dev/v1alpha1/namespaces/camel-k/ingresses/sample 7b742bca-ffc0-11e9-8bef-0694e72ccc58 1453843 1 2019-11-05 12:36:18 +0100 CET <nil> <nil> map[serving.knative.dev/route:sample serving.knative.dev/routeNamespace:camel-k] map[networking.knative.dev/ingress.class:istio.ingress.networking.knative.dev serving.knative.dev/creator:kube:admin serving.knative.dev/lastModifier:kube:admin] [{serving.knative.dev/v1alpha1 Route sample 72bfe2eb-ffc0-11e9-8bef-0694e72ccc58 0xc000fa2400 0xc000fa2401}] nil [] } {0 [] [{[sample.camel-k.svc.cluster.local sample.camel-k.apps.camel-k.rhmw-integrations.net] ExternalIP 0xc000855bc0}] ExternalIP} {{1 [{LoadBalancerReady Unknown  {2019-11-05 12:36:18 +0100 CET} Uninitialized Waiting for VirtualService to be ready} {NetworkConfigured True  {2019-11-05 12:36:18 +0100 CET}  } {Ready Unknown  {2019-11-05 12:36:18 +0100 CET} Uninitialized Waiting for VirtualService to be ready}]} <nil> <nil> <nil>}}"}
{"level":"error","ts":1572955547.7864275,"logger":"kubebuilder.controller","msg":"Reconciler error","controller":"ingress-controller","request":"camel-k/sample","error":"unable to find Ingress LoadBalancer with DomainInternal set","stacktrace":"github.com/openshift-knative/knative-openshift-ingress/vendor/github.com/go-logr/zapr.(*zapLogger).Error\n\t/home/nferraro/gopaths/knative/src/github.com/openshift-knative/knative-openshift-ingress/vendor/github.com/go-logr/zapr/zapr.go:128\ngithub.com/openshift-knative/knative-openshift-ingress/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/home/nferraro/gopaths/knative/src/github.com/openshift-knative/knative-openshift-ingress/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:217\ngithub.com/openshift-knative/knative-openshift-ingress/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1\n\t/home/nferraro/gopaths/knative/src/github.com/openshift-knative/knative-openshift-ingress/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:158\ngithub.com/openshift-knative/knative-openshift-ingress/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1\n\t/home/nferraro/gopaths/knative/src/github.com/openshift-knative/knative-openshift-ingress/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133\ngithub.com/openshift-knative/knative-openshift-ingress/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/home/nferraro/gopaths/knative/src/github.com/openshift-knative/knative-openshift-ingress/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134\ngithub.com/openshift-knative/knative-openshift-ingress/vendor/k8s.io/apimachinery/pkg/util/wait.Until\n\t/home/nferraro/gopaths/knative/src/github.com/openshift-knative/knative-openshift-ingress/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88"}

Are you using master's code anywhere? All released version should be using the 0.0.x branch currently.
The issue you're seeing is likely the Ingress not being Ready itself. I'd bet it's because it's still probing the VirtualService. Is the namespace your service runs in in the ServiceMeshMemberRoll of the Service Mesh instance you're using?

No, I started master to debug but I see now that the 0.0.x has already this patch.
Thanks for the hint, it works. I was used to the previous full-automated community operator and didn't know these details.

This is outdated, we'll eventually update master. Fixes are all on 0.0.x.


Implement search button

Resolve in pull request: https://github.com/EstefaniaGuardado/gitAppSwift/pull/10


release: v0.18

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.95%. Comparing base (f79a62a) to head (7de001b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #94   +/-   ##
=========================================
  Coverage     81.95%   81.95%
  Complexity      686      686
=========================================
  Files           124      124
  Lines          1768     1768
  Branches        105      105
=========================================
  Hits           1449     1449
  Misses          252      252
  Partials         67       67

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Set statusCode in Error object on reject

Provides a way for callers to detect specific errors, since the response was removed from the error object.

Thank you for your PR! Please send it here instead, as this is the next major version: https://github.com/DaniGuardiola/node-vault/tree/refactor

@DaniGuardiola I actually think we need to put more of the response back in the error. I'd open an issue to discuss this on your fork, but you don't appear to have issue tracking enabled. Should I open one here?
Vault is generally pretty cagey with its responses, so I doubt it divulges anything there. node-vault currently uses the first error from the response body (if any) as the error message, so it doesn't seem like there would be any harm in including the full response body.
The issue that resulted in removing the response claimed that request headers were included. This is obviously undesirable, and appears to be an undocumented "feature" of request. Perhaps we just need to return a scrubbed copy of the response object with a whitelisted set of properties, such as statusCode, statusMessage, and body?


Fetch issues for new projects and display them all nice like (WIP)

TODO: tidy things up a bit, fetch labels for #25 and fix the dodgy markdown rendering.
Take a peek and let me know what you think so far, don't merge yet though!

Very nice, I left you lots of inline comments!
We could use https://github.com/github/markup for rendering the github flavoured markdown so we get a similar whitelist, this project also has all the styles for a github readme: https://github.com/sindresorhus/github-markdown-css

I just had a go at the github/markup method and I didn't get anywhere useful. I'll have another go.

got it, it was a bit finicky about being required.

:shipit:


More exciting menu buttons, splash graphics for text

Currently, the players are greeted with a super fun, colorful, animated loading screen -- and then bland title text with some grey default-theme Godot buttons
The buttons should have a round, colorful, fun look to them.
The drab menu text should have some kind of an artsy splash shape behind them to give it a fun silhouette. We've already done similar work for the 'Ready? Go!' type messages, so we can possibly even borrow those shapes here.

The menu buttons have been redesigned to be colorful and fun.


Modularize code and add library target

Some users wish to reuse some of the code from this project in their own executables so this adds a lib target. I do not consider the API stable. It may change in incompatible ways between minor releases.
This PR should leave the behavior of uefi-run unchanged.
Fixes issue #13

bors r+


NIFI-10010: ListenTCP adds client certificate's Subject and Issuer DN…

…s to flowfiles as attributes

Summary
https://issues.apache.org/jira/browse/NIFI-10010
Implements NIFI-10010. ListenTCP adds the client certificate's Subject DN and Issuer DN values to the outgoing flowfiles as attributes in case of secure connections.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[x] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[x] Documentation formatting appears as expected in rendered files

Thank you again, @exceptionfactory .
I extended the test case in TestListenTCP as you recommended and also added a check for the new attributes not being present when the connection is not secure.
I added a test class for SocketByteArrayMessageDecoder with test cases.
Applied your recommendations almost exactly as you requested. Please check my modifications. Thanks!

I understand your concerns about the test for SocketByteArrayMessageDecoder. I'm OK with omitting that commit. Thanks for the quick feedback!


How to set climate temp with new switch in v3.0.0beta7

How do i set the temperature when using the new "switch.mycar_climate_engine"
I previously used the "Jaguar Landrover InControl: start_vehicle" but i believe this is being depreciated.
Thanks in advanced for any help!

You can set the default target climate temperature in the Integration Configuration, which be used when using the Climate Switch UI component.

I think you should still be able to use the start_vehicle service, but it is deprecated and you are encouraged to use the switch.turn_on service in stead. But latter service does not allow sending target temperature as argument.
We will do more work on services and documentation of those, before finalising the beta release


Dump Google credentials to file

It looks like Google's SDK looks for credentials as a file location only, and not as a JSON string. We need to write it to the filesystem temporarily to use it.
Signed-off-by: Major Hayden<EMAIL_ADDRESS>

So we probably need to work through the google image listing functions to get more data back from them. I think I just grabbed the name as a quick prototype and forgot to go back and get the rest. 🤦🏻♂

Oh no, yeah it completely slipped my mind that Google expects the service credentials to be located on disk.
Regarding your fix: I feel that service accounts are a bad idea in general and using the application key like this opens a completely new can of worms of security issues (and key management issues, replacing the key regularly, making sure nothing gets dumped ...).
I've created a PR with a counter proposal that uses Open ID Credentials instead: PR
The PR works using the same service account we already have in place but can easily be modified to use a true "credential less" authentication process using workload identity federations as described here: Google Blog

I am not sure if I fully understand both solutions. In this PR we write our non-expiring secret into a file that is used by rhelocator and afterwards removed.
In #56 we relay on a github action that uses github sso to request a new token, that is valid for 1h and used instead? Please corret me if I am wrong :see_no_evil:
Would both of those solutions fix #53 ?

@miyunari Yes that is completely correct! The big difference is, as you've already pointed out, the non expiring token that is written to the file system. In this particular case the credentials can't really be misused for anything else than querying image data but it can still authenticate and pretend to be "one of us" so writing it plain text to even an ephemeral container (in which the Github action runs) is still a bit risky.
The other solution uses our non expiring application key, authenticates on its own with the Google Cloud authentication back end (data is encrypted in transit) and returns that short term token that is written to the file system of the Github action container instead.
While it looks to be the exact same solution it avoids exposure of our own application key, creates a different user context for the action we execute (it's not the service user that executes the Google API calls, its an instance that uses a token generated by the service user to make the API call) and it self destructs after a certain time frame so we don't have to worry (as much) about leaking it.
Now the interesting part about Open ID Connect (what is used under the hood) is that we can completely avoid using a never expiring service account key and setup an authentication context for our github action instead (now this is probably we can go through in a 1:1. If you want to know more about OpenID I'd recommend the official page for starters).
Finally to your second question: Yes both solutions solve #53 :D

Thanks @FKolwa ! :smile: Without further knowledge the second solution sounds reasonable.

Closing this as #56 is the better solution.


An info box on every lenoxbot's team member page

Proposal:
Proposal written by Monkeyyy11
What is the title of your proposal?: An info box on every lenoxbot's team member page
Is it a suggestion for the website or for the bot?: website
Explain your proposal more accurately (It's best to give as much information as possible, so that we can implement the proposal better): Here is a screenshot what i mean. https://i.imgur.com/8mtJeFQ.png
Why should we add this feature?: It would be better to know if a discord user is really staff of LenoxBot
ReportID: 139

➤ LenoxBot commented:
Approve:
good idea
Wandi#9576

➤ LenoxBot commented:
Approve:
helpful
Nickkel#6515

➤ LenoxBot commented:
Approve:
agree with nickkel & wandi
🎃CrEePeR28 || Furkan361🎃#3532


If a symbolic link exists already - recreate

Fixes #136
When react-native-interactable is a dependency, first upgrade (of any yarn upgrade x dependency) commands:
error /Users/tom/src/company/ferocia/native/node_modules/react-native-interactable: Command failed.
Exit code: 1
Command: sh
Arguments: -c ln -s lib/{ios,android} .
Directory: /Users/tom/src/company/ferocia/native/node_modules/react-native-interactable
Output:
ln: ./ios: File exists
ln: ./android: File exists
info Visit https://yarnpkg.com/en/docs/cli/upgrade for documentation about this command.

Second command succeeds but first always fails (alternates) due to state.
As per ln manpages:
-f    If the target file already exists, then unlink it so that the link may occur.
This will ensure if the link already exists during an upgrade command, remove the old link and recreate.

Thank you @tommeier !


Avoid using deprecated operators

When I built swiftCoreFoundation-macos-x86_64, warnings are raised.
I fixed them to cast numbers expressly.

Looks like @xwu has already got these.


Uninstall-WGPackage : Allow Multiple choices

Add a --Multiple switch to the command.
This will allow the selection of several packaqges to uninstall at once.

Done in 0.5.2


in dashboard impoving glitch between feedback and contact from

in the the dashboard when we are clicking on feedback and contact us the same form appears so making changes in that and in feedback adding option of given stars out of 5 and writing a good review
please assign this issue to me under gssoc ext and hacktoberfest

#255


First of all, thank you for your work. Can you provide a Baidu Cloud download method for the Kitti 360 dataset? I am unable to download on the official website.

First of all, thank you for your work. Can you provide a Baidu Cloud download method for the Kitti 360 dataset? I am unable to download on the official website.

Hi, thanks for your interest. Sorry we cannot provide other download method.
To download the KITTI360 dataset, please check their official website.

请问您找到kitti 360的数据集吗，我也遇到了同样的问题


User Identification: Protocol Designer User Identification

As a product manager / ux researcher, I would like to know who is using the Protocol Designer, so that I can follow up with them for feedback.
Acceptance Criteria

[ ] Persist identity of users who access Protocol Designer via 'magic link' (#2934)

Part of #2934


Issue with my tag & category

Hi Cotes,
Thanks again for this wonderful template.
I have recently tweaked my blog to include your latest template changes.
Post that, my individual category and tags pages are showing 404.
home page - https://techslam.net/
example tag page - https://techslam.net/tags/autosys/ >> showing 404
example category page - https://techslam.net/categories/scheduler/   >> showing 404
Seems , I must have missed something while pushing to github repo as locally these pages are working fine.
Appreciate any guidance to fix this.
Thanks,
Aslam

Hi Cotes,
Well, so I was able to get this sorted out by executing bash/tools/init.sh , which then created all the respective categories and tag pages for me.
Does this mean , I will have to run this init.sh everytime there is a new post/category/tag created ?
Thanks a lot.
Aslam

Does this mean , I will have to run this init.sh everytime there is a new post/category/tag created ?

That's right. For more details,  see: Deploying to GitHub Pages.

Thanks cotes. Highly appreciate your quick response.
Also, if you see in my website, there is no view count after the post date. Did I miss some configuration to enable it?
Thanks
Aslam

there is no view count after the post date. Did I miss some configuration to enable it?

It's a repetitive question, same as #33.

Thanks for your help.


Upgrade script sometimes failed

What version of V2Ray are you using (If you deploy different version on server and client, please explicitly point out)?
v4.22.1

What's your scenario of using V2Ray? E.g., Watching YouTube videos in Chrome via Socks/VMess proxy.
General day-to-day use

What did you see? (Please describe in detail, such as timeout, fake TLS certificate etc)
The upgrade script failed sometimes. I have pinpoint the issue to this command to obtain the new version. (https://github.com/v2ray/v2ray-core/blob/2227557b86b233c10e5e92f59f45ba76fcd0ac2c/release/install-release.sh#L258)

curl -s "https://api.github.com/repos/v2ray/v2ray-core/releases/latest" --connect-timeout 10| grep 'tag_name' | cut -d\" -f4

Sometimes it prints out the correct version, i.e. v4.23.1. But sometimes it prints out this https://api.github.com/repos/v2ray/v2ray-core/releases/24822244, which leads to the download failure.

What's your expectation?
It always gets the correct latest version.

Please attach your configuration file (Mask IP addresses before submit this issue).
N/A

Please attach error logs, especially the bottom lines if the file is large. Error log file is usually at /var/log/v2ray/error.log on Linux.
N/A

Please attach access log. Access log is usually at '/var/log/v2ray/access.log' on Linux.
N/A

Other configurations (such as Nginx) and logs.
N/A

If V2Ray doesn't run, please attach output from --test.
N/A

If V2Ray service doesn't run, please attach journal log.
N/A

fix #2374

That works like magic! Thank you for the quick fix.


STM32G0: USB Clock select enum USBSEL is wrong

I am trying to configure the USB peripheral to use the PLL_Q clock as USB Clock (for use as Host).
The expectation is that this can be done with
 config.rcc.mux.usbsel = mux::Usbsel::PLL1_Q;

With PLL1_Q = 0x01 which matches the value in the manual RM0444.
However this value appears to be wrong. 0x01 configures USB to use HSE instead.
PLLQCLK and HSE are swapped both in the manual as in the embassy pac.
Correct values:
pub enum Usbsel {
  HSI48 = 0x0 ,
  HSE = 0x01 ,
  PLL1_Q = 0x02 ,
  _RESERVED_3 = 0x03
}

See also this person on this forum who found the same issue https://klipper.discourse.group/t/stm32g0-usb-clock-config/4487

fixed in https://github.com/embassy-rs/stm32-data/pull/512


add badge to show platform support

What Changed
Added related badge for platform support
Why
To make it easily discernible that this package works on all platforms
Todo:

[ ] Add tests
[ ] Add docs
[ ] Add release notes

:rocket: PR was released in 0.1.0 :rocket:


ARROW-4689: [Go] Add support for wasm

Codecov Report

Merging #3707 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3707   +/-   ##
=======================================
  Coverage   68.15%   68.15%
=======================================
  Files          58       58
  Lines        4032     4032
=======================================
  Hits         2748     2748
  Misses       1175     1175
  Partials      109      109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef28f20...baec1e6. Read the comment docs.

Can you create a JIRA for this? Do you want to document how to compile under wasm?

done: https://issues.apache.org/jira/browse/ARROW-4689

Do you want to document how to compile under wasm?

I could... even though I am not completely sure where putting it would make the most sense...
putting it in the API documentation (ie: godoc.org) sounds funny to me.
any idea? @stuartcarnie ?

@sbinet we have just set up a project-level documentation project. At some point you should start to write some Go documentation
https://github.com/apache/arrow/tree/master/docs/source

I don't see any documentation that might have come out of this, but I was guessing that something like this might work:
GOOS=js GOARCH=wasm go build -o test.wasm ./main.go

This fails for me with the following:
# github.com/apache/arrow/go/v9/internal/utils
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:76:4: undefined: TransposeInt8Int8
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:78:4: undefined: TransposeInt8Int16
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:80:4: undefined: TransposeInt8Int32
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:82:4: undefined: TransposeInt8Int64
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:84:4: undefined: TransposeInt8Uint8
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:86:4: undefined: TransposeInt8Uint16
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:88:4: undefined: TransposeInt8Uint32
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:90:4: undefined: TransposeInt8Uint64
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:95:4: undefined: TransposeInt16Int8
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:97:4: undefined: TransposeInt16Int16
../../go/pkg/mod/github.com/apache/arrow/go/v9@v9.0.0/internal/utils/transpose_ints_def.go:97:4: too many errors
# github.com/apache/thrift/lib/go/thrift
../../go/pkg/mod/github.com/apache/thrift@v0.15.0/lib/go/thrift/socket_unix_conn.go:60:63: undefined: syscall.MSG_PEEK
../../go/pkg/mod/github.com/apache/thrift@v0.15.0/lib/go/thrift/socket_unix_conn.go:60:80: undefined: syscall.MSG_DONTWAIT

I opened https://issues.apache.org/jira/browse/ARROW-17557 with this information, but thought I'd drop a comment here since it might help others that are struggling to do the same.
I'm curious if building with GOOS=js GOARCH=wasm supposed to be supported.

try GOOS=js GOARCH=wasm go build -tags noasm -o test.wasm ./main.go

Thanks for the suggestion.  I'm still seeing the syscall issues with -tags noasm.
GOOS=js GOARCH=wasm go build -tags noasm -o test.wasm ./main.go
# github.com/apache/thrift/lib/go/thrift
../../go/pkg/mod/github.com/apache/thrift@v0.15.0/lib/go/thrift/socket_unix_conn.go:60:63: undefined: syscall.MSG_PEEK
../../go/pkg/mod/github.com/apache/thrift@v0.15.0/lib/go/thrift/socket_unix_conn.go:60:80: undefined: syscall.MSG_DONTWAIT

I'll dig more later.

@tschaub Thanks, when you have the minimal example I'll take a look. It appears to be an issue specific with Thrift so I'll see if i can dig in there and see if there's a way to fix that syscall or otherwise.

@tschaub
Aha, it looks like latest version of thrift (v0.16.0) fixed this issue and added a !wasm build tag to that file. The current development version of the parquet lib (v10) has already upgraded to that version of thrift. If you upgrade your local version of thrift (go get -u<EMAIL_ADDRESS>or if you upgrade your version of parquet and arrow to v10, you should be able to build with WASM without issue. Let me know if this works for you please.

Thank you, @zeroshade.  The build works after updating to v10.  I'll update https://issues.apache.org/jira/browse/ARROW-17557.  I appreciate your help.


WCAG/ATAG compliance, or at least better accessibility than today.

Documentation Issue
WCAG stands for "Web Content Accessibility Guidelines", ATAG stands for "Authoring Tool Accessibility Guidelines". These guidelines make ICT-solutions more accessible.
In my company we have a blind employee, he is very good as his job and is as excited as me to find a new CMS-system. But upon a quick inspection of we found several issues that make PayloadCMS very hard for him to use.
Some parts of WCAG are difficult to understand and require allot of work to get right, others are easy to fix. The first WCAG breach we found was 4.1.2 Name, Role Value.
The buttons in the rich text field editor lacks alternative text, all the buttons are simply announced as "button"

The fix for this is relatively simple, assign an accessible label for each button using aria-label and allow users to assign aria-label attributed on custom buttons.
Additional Details
We are in the early phases of choosing a new CMS, PayloadCMS ticks allot of the boxes but falls short when it comes to accessibility.
As this is an open source project we could probably fix allot of the issues ourselves and use them in our solution, but this won't help other Payload users. We could create PRs to fix things, but we are accessibility experts; not developers. We do not feel the quality of our code meets the quality found elsewhere in PayloadCMS.
Why should we care about WCAG?
WCAG compliance makes for better solutions for everyone, not just those with a disability. Things like proper focus highlight with sufficient contrast is necessary for keyboard users, but nice for everyone else too.
How can the freeloading author of this issue help?
I am an accessibility auditor, I can help audit PayloadCMS using screen readers and auditing tools. But before I spend god knows how many hours on that I need to know that accessibility is something you care about and want to maintain.
Will this make PayloadCMS money?
Part of my job as an accessibility consultant is to evaluate external ICT solutions. See if the work for employees (current or future) with disabilities. In my country (Norway) all public facing ICT-solutions are required by law to be WCAG compliant, in the EU this only applies for the public sector. If I did this for PayloadCMS the answer would simply be "you cannot use this, it is not accessible enough". Which is sad - the front end code quality is better than allot of others things I've tried.
How can we tell if we follow WCAG?
Automated tools such as Axe Devtools can find around 30-50% of the WCAG-issues. The rest requires manual testing. Writing WCAG compliant code is really just writing "good" proper HTML. In my experience work towards WCAG compliance usually leads to higher quality and more robust HTML/JS code in projects.

This seems like a really important thing that the Payload developers can add!
I am in the middle of doing another Pull Request and adding my own contributions to the project.
After my pull request gets reviewed and merged this will be my next task as a volunteer. Will you be willing to help out and guide me to make things more accessible for everyone? @AndreasJacobsen

Hey @AndreasJacobsen thanks for bringing this up. The Payload team agrees that this is high priority for us to tackle. We're going to sink some time into bringing the admin UI up to a better spot re: accessibility immediately, and make it a goal of ours to ensure all future development is done so with a mind toward ensuring a high degree of accessibility moving forward.
As this is a moving target, and will need to be addressed on an ongoing basis, I am going to convert this to a discussion. But the team and I will report back on the discussion once we have made progress, and we would welcome progress from the community here as well! @TomDo1234 it would be absolutely amazing if you could contribute here as well. We would GREATLY appreciate it!


Version via Git tags only

Using setuptools_scm. Makes our versioning workflow use git tags, which we can control through GitHub releases.
The workflow is:

PR(s) get merged
Make a github release with a new tag (+ auto-generate release notes)
Version will be implicitly updated once you run git pull after the tag creation!

you can check this with python -c "import cloudcasting; print(cloudcasting.__version__)" :)

Also important: this needs you to always include a patch version, e.g. v3.0.0, or the wrong digit will get updated (see here)


motifs.py output order right investigation

Initial review I did not see where the dictionary error was possibly occurring.
Debugging the motifs.py code based on output shows the flagged RFX5 only occurs in 5 lines with the suggested value.

grep 'RFX5' output.motif.20170114.vcf | grep '5.4636' | wc -l
grep 'RFX5' output.motif.20170114.vcf | grep '5.4636' > temp_investigate.txt

Searching temp_investigate.txt for RFX5 shows only 3 lines with duplicate entries:

chr1 145039922
chr22 25005718
chr5 46363751

Suggest Debug Procedure Against Small Data Subset

Create a motif file with only RFX5 and maybe 1 or two other Motifs
Create an input file with only the three lines referenced above and the header lines

actually I'd start with 1 offending line then expand to include the other 2

Process and Review the small subset

See debugging_motifs.ipynb, I think it is doing what it is supposed to. The multiple RXF5 are due to plus and minus (reverse complement) matches and in at least one case they happen to be computational symmetric (positive and minus match). Debugging code options below for motifs.py but you'll need to reindent after comment window removes all spacing.
This can also be proven by adding the following logging code to motifs.py:

Add code before match_peaks() at line 952:
       print('## printing plusmatch set ##')
        for match in plusmatch:
            print( match.name + " vs=" + str(round(match.var_score, 4)) +
                  " rs = " + str(round(match.ref_score, 4)) )
        print('## printing minusmatch set ##')
        for match in minusmatch:
            print( match.name + " vs=" + str(round(match.var_score, 4)) +
                  " rs = " + str(round(match.ref_score, 4)) )
        print('## printing matches set ##')
        for match in matches:
            print( match.name + " vs=" + str(round(match.var_score, 4)) +
                  " rs = " + str(round(match.ref_score, 4)) )

And the following after match_peaks() at line 957:
       print('## printing matches set post match_peaks ##')
        for match in matches:
            print( match.name + " vs=" + str(round(match.var_score, 4)) +
                  " rs = " + str(round(match.ref_score, 4)) )

Thanks for following up. Since the behavior is intended, it should be more clear in the output. Considering adding strand info (+/-) for each motif output, as variants are always reported on the + strand in VCF format.
I'm going to leave this open until we clarify the output.

We should also go ahead and make it a requirement that motifs have unique names.

(+/-) for each motif output completed but tests not run to verify no issues. Sorry, thought I checked this in awhile ago. Still need to verify whether unique names are an issue and force if not.

motifArray() does not currently have a dictionary element to check for unique keys. Because we 'allow' any of the scripts to technically run in any order when and how do you believe uniqueness checking should occur?
Is thresholds.py the only place that flagging uniqueness should occur? It would be easy there because output is expected. Flagging during others could have issues.
How to handle preferred:

Should it bail after partial processing?
Should it rename with a timestamp to be truly unique
Or ???

I worry about only having thresholds.py check it, as people could bypass that step if their list already had pre-defined thresholds from elsewhere or if they used a different program/method to define them. motifs.py is likely not going to be skipped and a check there would be appropriate.
I like your edit solution, it's basically the same as what I did in the new thresholds.py.
We need to remember to ignore the index for tf_expression.py. and checking if the motif lies in a ChIP peak. I don't think I addressed it.

This has been tested and confirmed to be working in tf_expression.py.

Rewrote motif.py::element_overlap*() functions, they are now functional and appear to work properly. The main issue is that the motif file itself is never modified, so matching the motif + index with a motif in the motif file isn't possible for later modules of the program.
Also not a huge fan of how it just increments the index, so you end up with entries like 'EGF1_288, EGF1_289'. I think I'd rather just see 'EGF1_1, EGF1_2', etc and just reset the index for each motif.
I am thinking that a check is built into motif::get_put_motifs so that an index is added if necessary during thresholds.py. We will have to simply make it explicit that the motif names have to be unique so that if users have a file with already defined thresholds, they can ensure they take care of it themselves.


Prepare an Amazon Web Services account for setting up ABAP on-premise system

Tutorial URL: https://developers.sap.com/tutorials/hcp-prepare-aws-account.html
Please specify the step you are referring to 1-3.
There are no "Done"Buttons to quit the Mission

@marcobuescher
We decided to remove tutorial group Use JCo through the Cloud Connector instead.

I would not recommend to do these tutorials -  they are quite old and may no longer work - we're looking into this.
Sorry for any inconvenience caused. Could you close this issue?

Hello,
that are no good news, because I liked the Badge so mutch. :)
They are old, I think so too and I think they are form other older Tutorials because I saw I made the User and User Groups in AWS long Time ago.
Regards
Marco


Doesn't work with parameterized jobs

Nomad pipeline fails at the "init" stage when used in a parameterized job. The following error is returned by Nomad: cannot update non-parameterized job to being parameterized.
This is an issue with Nomad in which it currently doesn't support updating dispatched jobs. Nomad pipeline relies on updating the job in order to control the count parameter of each task group.
See the following issue already raised in Nomad: https://github.com/hashicorp/nomad/issues/10941.

Hi @waquidvp
We are evaluating nomad-pipeline and it seems the issue you opened has already been closed. Does this mean that updating parameterized jobs works? Or is this something that needs to be fixed in this very plugin?
Thanks for you work on this :heart:

Hey @muuki88,
Thanks for taking at look the project. Like you said, the upstream Nomad ticket was closed and unfortunately the conclusion was that the fix wouldn't go in. However, there are two possible workarounds:
1. Use a patched version of Nomad
This is my current method, I have been maintaining a patch file which I have been applying when new versions are released (currently 1.4.3). The patch is derived from the pull request that was closed. This option isn't sustainable but it's what I have been using in our org. It adds some overhead when new versions of Nomad comes out as it requires you to maintain your own Nomad binaries. If you are interested in this option, I have attached the patch I use and I can provide more complete instructions in this thread - if needed.
update-payload-on-dispatched-job.patch
2. Using the nomad-pipeline API to dispatch jobs
This functionality is still work in progress but will be ready to use soon. As part of this feature, there will be a server component to nomad-pipeline which exposes an API. The way it works is by copying the job definition from a parameterised job and creating a new standard job using the same definition. This does however have some limitations which I am still working on fixing, the main one being the lack of support for the dispatch payload. Here is the WIP branch: https://github.com/hyperbadger/nomad-pipeline/tree/f-dispatch-pipelines.


update faq,test=develop

Update faq 12.26

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.adaxi123 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Is there a way to set the grid with number of Rows&Cols

I've been using the component for some time now, and its really cool.
It would be nice if you could configure the Grid Layout with the number of rows in conjunction with the colNum so that the grid will be displayed as defined.
I'm using the component to drag widgets in, and i've got it working, however my Grid Layout is empty when the page loads and then I append to it.
The problem I have got is that the when the page 1st loads the grid layout is very small, and its quite difficult to drop the 1st widget, once the 1st widget is inserted, the proceeding widgets are fine.
So my thoughts are if the rowNum can be set to the grid layout then on 1st load the grid will be drawn for example 3 rows x 3 cols would initialise the grid like this:-

If outline of the grid was initialized at load then I would be able to drag the widgets in what ever cell I need to.
If there is a way around this please let me know.
Thanks

Sorry, don't understand what the problem is. Please provide a sample.

Basically I load the page with an empty grid and I dnd widgets on the component, at first load the grid doesn't contain any items, so when I try and dnd on to the grid with the 1st widget the grid is that small its very hard to drop the widget on to the  grid as it has no items on it. So need to set the number of rows on initialisation of the grid view, so I can easily drop the 1st widget anywhere in the grid.
Hope this makes sense?

Hi, the layout style could be set to adjust the height property, but I am not sure wether this is a solution for you.
.vue-grid-layout {
background: #eee;
min-height:200px;
}


[WIP] Add libdef for hoist-non-react-statics_v2.x

Converted the TypeScript definitions to flow
Could use some help for the tests tbh (I'm new to creating libdefs so...) 😕😢
@GAntoine Maybe you can point me in the right direction?

@GAntoine Maybe you can point me in the right direction for some tests?
Or if you're willing to provide them yourself, I wouldn't mind ofcourse 🙂

I actually took a crack at creating some tests over the weekend but didn't get far. This isn't my field of expertise, but I'll take another look this week.

@GAntoine No problem 🙂
I don't use the lib myself, but I came across it, so wanted to contribute it for people who want to use the libdef. 🙂

I have tried adding Flow types to this library, but have not found a way to have it validate the union of the statics of the two components. I'd really appreciate help on this if anyone knows a way to do this.

Looks like this already exist at this point -> I'm gonna close this PR. Thanks for the PR @MichaelDeBoey !


missing jewelcrafting specialization info

The Glassware node affects the reagents that take fractured glass in crafting: empty soul cage, draconic vial, and frameless lens. but this is missing in the experimental specialization data.

fixed with 6.3+


require JWT keys to be exactly 32 bytes

Many lines had trailing whitespace and inconsistent capitalization of acronyms.

Seems to be unhappy that "CLs" isn't a word. Do you mind adding it to the word list?

Hi @tersec and @mkalinin just want to bring up this issue from @prestonvanloon here https://github.com/ethereum/execution-apis/issues/208. We don't understand why we need JWT secrets as strictly-formatted hex strings in the spec, when plaintext passwords could be used for a cleaner UX

Hi @tersec and @mkalinin just want to bring up this issue from @prestonvanloon here #208. We don't understand why we need JWT secrets as strictly-formatted hex strings in the spec, when plaintext passwords could be used for a cleaner UX

I don't think that issue is relevant to this PR. This PR is about making the length requirement consistent across the spec, it doesn't attempt to change requirements on the length of the secret.
Let's take this discussion into the issue (I have commented on it).


models: Replace __id syntax with _id where possible.

Original motivation: https://github.com/zulip/zulip/pull/18204#discussion_r615276929
model__id syntax implies needing a JOIN on the model table to fetch the
id. That's usually redundant, because the first table in the query
simply has a 'model_id' column, so the id can be fetched directly.
Django is actually smart enough to not do those redundant joins, but we
should still avoid this misguided syntax.
The exceptions are ManytoMany fields and queries doing a backward
relationship lookup. If "streams" is a many-to-many relationship, then
streams_id is invalid - streams__id syntax is needed. If "y" is a
foreign fields from X to Y:
class X:
y = models.ForeignKey(Y)
then object x of class X has the field x.y_id, but y of class Y doesn't
have y.x_id. Thus Y queries need to be done like
Y.objects.filter(x__id__in=some_list)

Merged, thanks for the cleanup @mateuszmandera!


selectOperation instead of selectStatus

https://github.com/StuckiSimon/rejuice/blob/f85c1f602f6871ecbc5139f9a107b1b2de52fb5d/src/selector/index.js#L22-L23
Shouldn't those lines call selectOperation instead of selectStatus?
In my understanding create and delete are operations and status includes failure, success etc.
I could  create a PR if you like.

Agree, it's not intuitive.
But operation is a property of status and the isDelete / isCreate check for the operation property of the given object. https://github.com/StuckiSimon/rejuice/blob/f85c1f602f6871ecbc5139f9a107b1b2de52fb5d/src/base/index.js#L46
So it's working as expected.
Please note that this is a wip and especially selectors will change drastically.
Check out reselect, this will be the way to go with selectors (and therefore changing how selectors work)
If you still want to improve the code quality I'd appreciate a PR with the corresponding tests

Feel free to reopen the issue if you plan to provide a PR.


GitHub Desktop 217

Thank you for the contribution. It was merged directly as 34f634b40aa96a27f38ae13d3a88984f7fd2402c to keep commit history cleaner. Your contribution is still credited to you.


Disable diagnostic modes during final rendering

We are using the diagnostic modes in appleseed.maya and gafferseed both for final and progressive renders.
I think they are useful for turntables and to debug problems in scenes. I'd prefer to keep them.

Sorry, my description isn't very clear. I simply meant that it shouldn't be possible to enable or change diagnostic modes during final rendering in appleseed.studio.

Done in #2353.


Revert "synchronize_with_navigation_wait: add xhr_semaphore support"

Reverts alphagov/digitalmarketplace-functional-tests#670
I think we should pull this out for now until I've an idea why jquery is so overzealous on thinking it has ajax loading.

omg i hate rubocop