fix(app): only fetch historic run commands if downloading

Overview
Instead of eagerly fetching run commands from historic runs, only fetch the total command count.
After a few tests, this consistently leads to a decrease by a factor of 10 in load time for the items in the historic run list.
Closes RAUT-315
Test Plan

confirm that downloading the run data from the overflow menu on the historic runs list still functions as expected.

If this feels at all nontrivial/dicey/more-nuanced-than-we-thought, let's drop it from hotfix_6.2.1.

Good catches @brenthagen  and @SyntaxColoring, I've updated the PR to bite off a little less. Now the only change from the existing approach is that the page length of the commands fetch is 0 instead of 60.  We only need the totalLength from this response anyway, and this leads to a performance improvement short of the larger refactor we'd like to do here soon.


msg: 'Error: '

hi
I got below error. Could you please help me to solve issue?
The full traceback is:
  File "/var/folders/24/w6k0_g_s1vq5c4xvprz1_ck80000gp/T/ansible_powerdns_record_payload_fg0t06jz/ansible_powerdns_record_payload.zip/ansible/modules/powerdns_record.py", line 429, in main
  File "/var/folders/24/w6k0_g_s1vq5c4xvprz1_ck80000gp/T/ansible_powerdns_record_payload_fg0t06jz/ansible_powerdns_record_payload.zip/ansible/modules/powerdns_record.py", line 309, in ensure
  File "/var/folders/24/w6k0_g_s1vq5c4xvprz1_ck80000gp/T/ansible_powerdns_record_payload_fg0t06jz/ansible_powerdns_record_payload.zip/ansible/modules/powerdns_record.py", line 187, in get_record
  File "/var/folders/24/w6k0_g_s1vq5c4xvprz1_ck80000gp/T/ansible_powerdns_record_payload_fg0t06jz/ansible_powerdns_record_payload.zip/ansible/modules/powerdns_record.py", line 142, in _handle_request
[WARNING]: Module did not set no_log for pdns_api_password
fatal: [SWITCH1]: FAILED! => changed=false
  invocation:
    module_args:
      content: <IP_ADDRESS>
      disabled: false
      exclusive: true
      name: fsdfsdf.local
      pdns_api_key: null
      pdns_api_password: <password>
      pdns_api_username: <user_name>
      pdns_host: ns-master.local
      pdns_port: 80
      pdns_prot: http
      server: localhost
      set_ptr: false
      state: present
      strict_ssl_checking: true
      ttl: 600
      type: A
      zone: local
  msg: 'Error: '

@Nosmoht

Hi @inetman28,
i'm not working with PowerDNS anymore since years. Therefore i can't support you, sorry.
But maybe others could help you if you would post the code you are using. The repo still gets updates from the community ;)

Almost 3 years later... but just for the record you might want to check the privileges. This endpoint is called and needs 'admin' '{url}/servers/{server}/search-data'


Create Rohit-pr.md

Hii Gssoc would you please review my PR and merge it
I had mentioned the level of each PR below
(Level 2)
https://github.com/swaraj-das/Collect-your-GamingTools/pull/752
(level 2)
https://github.com/swaraj-das/Collect-your-GamingTools/pull/761
(level 3)
https://github.com/vishanurag/Canvas-Editor/pull/796

Thank you 👍😊


Lithops service not installed on VM instance

I'm trying to run the following command
lithops test -b aws_ec2 -s aws_s3
And I get the following error:
2023-02-07 08:18:23,305 [INFO] config.py:132 -- Lithops v2.7.1
C:\Users\Allen.lithops\config
2023-02-07 08:18:24,308 [INFO] aws_s3.py:59 -- S3 client created - Region: sa-east-1
2023-02-07 08:18:24,393 [INFO] aws_ec2.py:76 -- AWS EC2 client created - Region: us-east-1
2023-02-07 08:18:26,167 [INFO] invokers.py:108 -- ExecutorID 3824ff-0 | JobID A000 - Selected Runtime: python.exe
2023-02-07 08:18:26,867 [INFO] invokers.py:116 -- Runtime python.exe is not yet deployed
2023-02-07 08:18:29,525 [INFO] standalone.py:425 -- Installing Lithops in VM instance lithops-master-cf8a (<IP_ADDRESS>)
Traceback (most recent call last):
File "C:\Program Files\Python310\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Program Files\Python310\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\Scripts\lithops.exe_main.py", line 7, in
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\click\core.py", line 1130, in call
return self.main(*args, **kwargs)
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\click\core.py", line 1055, in main
rv = self.invoke(ctx)
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\click\core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\click\core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\click\core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\lithops\scripts\cli.py", line 173, in test_function
fexec.call_async(hello, username)
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\lithops\executors.py", line 209, in call_async
runtime_meta = self.invoker.select_runtime(job_id, runtime_memory)
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\lithops\invokers.py", line 117, in select_runtime
runtime_meta = self.compute_handler.deploy_runtime(self.runtime_name, runtime_memory, runtime_timeout)
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\lithops\standalone\standalone.py", line 340, in deploy_runtime
self._wait_master_service_ready()
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\lithops\standalone\standalone.py", line 136, in _wait_master_service_ready
self._validate_master_service_setup()
File "Z:\Personal_Projects\pruebas_master\pre_proc_open_cv\env\lib\site-packages\lithops\standalone\standalone.py", line 107, in _validate_master_service_setup
raise LithopsValidationError(
lithops.standalone.standalone.LithopsValidationError: Lithops service not installed on VM instance lithops-master-cf8a (<IP_ADDRESS>), consider using 'lithops clean' to delete runtime metadata or 'lithops clean --all' to delete master instance as well

@AaronSoria I guess you are using an Ubuntu image, right? Could you try using python as a runtime name instead of python.exe ?

Yes! now I have another exception
2023-02-07 13:50:30,845 [INFO] config.py:134 -- Lithops v2.8.0
2023-02-07 13:50:31,085 [INFO] aws_s3.py:60 -- S3 client created - Region: sa-east-1
2023-02-07 13:50:31,151 [INFO] aws_ec2.py:77 -- AWS EC2 client created - Region: us-east-1
2023-02-07 13:50:32,833 [INFO] invokers.py:108 -- ExecutorID e89452-0 | JobID A000 - Selected Runtime: python
2023-02-07 13:50:33,502 [INFO] invokers.py:116 -- Runtime python is not yet deployed
2023-02-07 13:50:35,680 [INFO] standalone.py:425 -- Installing Lithops in VM instance lithops-master-cf8a (<IP_ADDRESS>)
2023-02-07 13:50:43,805 [INFO] standalone.py:138 -- Waiting Lithops service to become ready on VM instance lithops-master-cf8a (<IP_ADDRESS>)
2023-02-07 13:50:46,232 [INFO] invokers.py:172 -- ExecutorID e89452-0 | JobID A000 - Starting function invocation: hello() - Total: 1 activations
Traceback (most recent call last):
File "/usr/local/bin/lithops", line 8, in
sys.exit(lithops_cli())
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/lithops/scripts/cli.py", line 176, in test_function
fexec.call_async(hello, username)
File "/usr/local/lib/python3.10/site-packages/lithops/executors.py", line 224, in call_async
futures = self.invoker.run_job(job)
File "/usr/local/lib/python3.10/site-packages/lithops/invokers.py", line 266, in run_job
futures = self._run_job(job)
File "/usr/local/lib/python3.10/site-packages/lithops/invokers.py", line 205, in _run_job
raise e
File "/usr/local/lib/python3.10/site-packages/lithops/invokers.py", line 202, in _run_job
self._invoke_job(job)
File "/usr/local/lib/python3.10/site-packages/lithops/invokers.py", line 249, in _invoke_job
activation_id = self.compute_handler.invoke(payload)
File "/usr/local/lib/python3.10/site-packages/lithops/standalone/standalone.py", line 288, in invoke
raise Exception('It was not possible to create any worker')
Exception: It was not possible to create any worker

Can you access the VM with lithops attach -b aws_ec2 --start and send the log from here /tmp/lithops/service.log?

There is no log in /tmp/lithops/service.log
but I got this from lithops test -b aws_ec2 -s aws_s3 -d
2023-02-07 14:17:50,129 [INFO] config.py:134 -- Lithops v2.8.0
2023-02-07 14:17:50,129 [DEBUG] config.py:93 -- Loading configuration from /home/parallel/.lithops_config
2023-02-07 14:17:50,151 [DEBUG] config.py:211 -- Loading Standalone backend module: aws_ec2
2023-02-07 14:17:50,298 [DEBUG] config.py:251 -- Loading Storage backend module: aws_s3
2023-02-07 14:17:50,312 [DEBUG] aws_s3.py:33 -- Creating S3 client
2023-02-07 14:17:50,479 [INFO] aws_s3.py:60 -- S3 client created - Region: sa-east-1
2023-02-07 14:17:50,479 [DEBUG] aws_ec2.py:51 -- Creating AWS EC2 client
2023-02-07 14:17:50,599 [INFO] aws_ec2.py:77 -- AWS EC2 client created - Region: us-east-1
2023-02-07 14:17:50,599 [DEBUG] standalone.py:58 -- Standalone handler created successfully
2023-02-07 14:17:50,600 [DEBUG] invokers.py:94 -- ExecutorID bd83bb-0 - Invoker initialized. Max workers: 100
2023-02-07 14:17:50,601 [DEBUG] aws_ec2.py:89 -- Initializing AWS EC2 backend (reuse mode)
2023-02-07 14:17:51,943 [DEBUG] aws_ec2.py:149 -- Requesting current spot price for worker VMs of type t2.medium
2023-02-07 14:17:52,242 [DEBUG] aws_ec2.py:158 -- Current spot instance price for t2.medium is $0.015800
2023-02-07 14:17:52,242 [DEBUG] executors.py:164 -- Function executor for aws_ec2 created with ID: bd83bb-0
2023-02-07 14:17:52,242 [INFO] invokers.py:108 -- ExecutorID bd83bb-0 | JobID A000 - Selected Runtime: python
2023-02-07 14:17:52,242 [DEBUG] storage.py:415 -- Runtime metadata found in local disk cache
2023-02-07 14:17:52,243 [DEBUG] job.py:234 -- ExecutorID bd83bb-0 | JobID A000 - Serializing function and data
2023-02-07 14:17:52,244 [DEBUG] module_dependency.py:66 -- Queuing module 'lithops.scripts.cli'
2023-02-07 14:17:52,244 [DEBUG] module_dependency.py:110 -- Module 'lithops' is to be ignored, skipping
2023-02-07 14:17:52,245 [DEBUG] serialize.py:81 -- Referenced modules: /usr/local/lib/python3.10/site-packages/lithops/scripts/cli.py
2023-02-07 14:17:52,245 [DEBUG] serialize.py:98 -- Modules to transmit: None
2023-02-07 14:17:52,245 [DEBUG] job.py:268 -- ExecutorID bd83bb-0 | JobID A000 - Uploading function and modules to the storage backend
2023-02-07 14:17:52,977 [DEBUG] aws_s3.py:81 -- PUT Object lithops.jobs/bd83bb-0/377c69cfe3dd94f5f04be3a9551f7a35.func.pickle - Size: 693.0B - OK
2023-02-07 14:17:52,977 [DEBUG] job.py:294 -- ExecutorID bd83bb-0 | JobID A000 - Uploading data to the storage backend
2023-02-07 14:17:53,124 [DEBUG] aws_s3.py:81 -- PUT Object lithops.jobs/bd83bb-0-A000/aggdata.pickle - Size: 29.0B - OK
2023-02-07 14:17:53,125 [INFO] invokers.py:172 -- ExecutorID bd83bb-0 | JobID A000 - Starting function invocation: hello() - Total: 1 activations
2023-02-07 14:17:53,125 [DEBUG] invokers.py:177 -- ExecutorID bd83bb-0 | JobID A000 - Worker processes: 2 - Chunksize: 22023-02-07 14:17:54,348 [DEBUG] ssh_client.py:40 -- <IP_ADDRESS> ssh client created
2023-02-07 14:17:55,363 [DEBUG] standalone.py:278 -- Found 0 free workers connected to master VM instance lithops-master-cf8a (<IP_ADDRESS>)
2023-02-07 14:17:55,363 [DEBUG] standalone.py:283 -- Going to create 1 new workers
2023-02-07 14:17:55,982 [INFO] aws_ec2.py:559 -- Starting VM instance lithops-master-cf8a
2023-02-07 14:17:55,993 [DEBUG] aws_ec2.py:410 -- Creating new VM instance lithops-worker-bd83bb-0-a000-0000 (Spot)
2023-02-07 14:17:56,509 [DEBUG] aws_ec2.py:570 -- VM instance lithops-master-cf8a started successfully
2023-02-07 14:17:57,577 [DEBUG] standalone.py:261 -- Total worker VM instances created: 0/1
Traceback (most recent call last):
File "/usr/local/bin/lithops", line 8, in
sys.exit(lithops_cli())
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/lithops/scripts/cli.py", line 176, in test_function
fexec.call_async(hello, username)
File "/usr/local/lib/python3.10/site-packages/lithops/executors.py", line 224, in call_async
futures = self.invoker.run_job(job)
File "/usr/local/lib/python3.10/site-packages/lithops/invokers.py", line 266, in run_job
futures = self._run_job(job)
File "/usr/local/lib/python3.10/site-packages/lithops/invokers.py", line 205, in _run_job
raise e
File "/usr/local/lib/python3.10/site-packages/lithops/invokers.py", line 202, in _run_job
self._invoke_job(job)
File "/usr/local/lib/python3.10/site-packages/lithops/invokers.py", line 249, in _invoke_job
activation_id = self.compute_handler.invoke(payload)
File "/usr/local/lib/python3.10/site-packages/lithops/standalone/standalone.py", line 288, in invoke
raise Exception('It was not possible to create any worker')
Exception: It was not possible to create any worker

Run lithops clean -b aws_ec2 -s aws_s3, then lithops test -b aws_ec2 -s aws_s3 -d, and then check for the logs in the VM (/tmp/lithops/service.log) before it stops

this is the log
service.log

Everything is installed successfully in the master VM. The problem is the worker.
I think that currently AWS does not have SPOT instance capacity (Which is the default for Lithops).
Can you set in your config file:
aws_ec2:
    request_spot_instances: false

Great!! this is the solution


Removed overflow for long character names

Character name overflow has been changed to ellipsis.
This will close #145.

I didn't ever think of zooming it in to test lol. I tested it by making the screen width smaller. It goes really small (<320px wide) and still works well. I was testing the same long character name on the live site where I could actually use my phone to test and the name wasn't too long in that case so I think we should be fine. I just wanted to add this as a just in case.


Vectra AI SaaS - Initial Analytic templates

Required items, please complete
Change(s):

Added 2 analytic templates for this solution.

Reason for Change(s):

New content to integrate Vectra's signal into Sentinel workflows.

Version Updated:

Yes. Initial version 1.0.0

Testing Completed:

Partially using a script to parse YAML file and push it to Sentinel with New-AzSentinelAlertRule function (does not support all parameters).

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @danymello,
Please work on below points:

To resolve validation issue , please add a custom scehma table at below path.
Path : https://github.com/Azure/Azure-Sentinel/tree/master/.script/tests/KqlvalidationsTests/CustomTables.
For reference you can check any table from CustomTables Folder.

If the rules are data connector dependent, need to add requiredDataConnectors property, please refer below Analytic rule.
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Network Session Essentials/Analytic Rules/AnomalyFoundInNetworkSessionTraffic.yaml

Status,tactics,relevantTechniques are missing, please add it.

Thanks

Hi @danymello, Please work on below points:

To resolve validation issue , please add a custom scehma table at below path.
Path : https://github.com/Azure/Azure-Sentinel/tree/master/.script/tests/KqlvalidationsTests/CustomTables.
For reference you can check any table from CustomTables Folder.
If the rules are data connector dependent, need to add requiredDataConnectors property, please refer below Analytic rule.
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Network Session Essentials/Analytic Rules/AnomalyFoundInNetworkSessionTraffic.yaml
Status,tactics,relevantTechniques are missing, please add it.

Thanks

Custom table schemas are already there:

Entity_Scoring_Data_CL: https://github.com/Azure/Azure-Sentinel/blob/master/.script/tests/KqlvalidationsTests/CustomTables/Entity_Scoring_Data_CL.json
Detections_Data_CL: https://github.com/Azure/Azure-Sentinel/blob/master/.script/tests/KqlvalidationsTests/CustomTables/Detections_Data_CL.json

Analytic rules are using Parsers/Functions available in the Vectra XDR Solution. I added the connector requirements in both.
I added status only. I cannot map to any MITRE technics/techniques with the data available.
let me know if you see any other issue?

Hi @danymello,

To resolve validation error, we need to add table schemas for below

VectraDetections
VectraEntityScoring

Please add it in below path :
Path : https://github.com/Azure/Azure-Sentinel/tree/master/.script/tests/KqlvalidationsTests/CustomTables.

Please remove plus symbol from query

Thanks

Hi @danymello,

To resolve validation error, we need to add table schemas for below

VectraDetections
VectraEntityScoring

Please add it in below path : Path : https://github.com/Azure/Azure-Sentinel/tree/master/.script/tests/KqlvalidationsTests/CustomTables.

Please remove plus symbol from query

Thanks

All implemented.

Hi @danymello,

To resolve validation error, we need to add table schemas for below

VectraDetections
VectraEntityScoring

Please add it in below path : Path : https://github.com/Azure/Azure-Sentinel/tree/master/.script/tests/KqlvalidationsTests/CustomTables.

Please remove plus symbol from query

Thanks

@v-rusraut, can we check if we are all good now?


feat: add museum to networth calculation

Description
Adds Museum to Networth Calculation
Preview

Before

{
  noInventory: false,
  networth:<PHONE_NUMBER>88.5304,
  unsoulboundNetworth:<PHONE_NUMBER>09.74619,
  purse:<PHONE_NUMBER>.4171467,
  bank:<PHONE_NUMBER>3.477383,
  types: {
    [...],
  }
}

After

{
  noInventory: false,
  networth:<PHONE_NUMBER>28.549,
  unsoulboundNetworth:<PHONE_NUMBER>26.44618,
  purse:<PHONE_NUMBER>.4171467,
  bank:<PHONE_NUMBER>3.477383,
  types: {
    [...],
    museum: {
      total:<PHONE_NUMBER>.018611,
      unsoulboundTotal: 68799516.7,
      items: [Array]
    }
  }
}

networth.types.museum.items: https://hastebin.com/share/gelonigaza.json

Thanks ducky!


'The section type "annotator" is not valid' on remote server

Are there any undocumented server requirements for Annotator to work? The plugin works perfect locally, but gives a The section type "annotator" is not valid error in the panel on the remote server.

Sorry for the delay.
Well, not at all, no. Do you still have the issue?
Have you, by any chance, updated an existing remote server install by adding of the annotator plugin afterwards? If so, I would try to delete what's in the media/plugins folder to make sure you're not dealing with an old index.js.

Thanks for the reply, that fixed it! Had no clue that file could get outdated.


Login redirect

From the landing page, click on annotate and get taken to login. When logged in, you are redirected to basicviz and not the annotations...

Logout also looks broken. Needs to click twice to log out.


Key value blog

This is a first draft of a blog post for the new key/value feature. This is still a bit of a work in progress because the CLI interface for key/value is still in review. The rest of the content is ready for some quick proofreading though, and feedback is welcome!

Could we add the changes for record to this PR for the front page for the node consumer and the rust consumer?


issue with ionic cordova build android --prod

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
Please do not submit support requests or "How to" questions here. Instead, please use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Ionic Info:
package.json:
{
"name": "MFile",
"author": "MRA",
"homepage": "http://www.mra.mu/",
"private": true,
"scripts": {
"clean": "ionic-app-scripts clean",
"build": "ionic-app-scripts build",
"ionic:build": "ionic-app-scripts build",
"ionic:serve": "ionic-app-scripts serve"
},
"dependencies": {
"@angular/animations": "5.0.0",
"@angular/common": "5.0.0",
"@angular/compiler": "5.0.0",
"@angular/compiler-cli": "5.0.0",
"@angular/core": "5.0.0",
"@angular/forms": "5.0.0",
"@angular/http": "5.0.0",
"@angular/platform-browser": "5.0.0",
"@angular/platform-browser-dynamic": "5.0.0",
"@ionic-native/app-rate": "^4.2.1",
"@ionic-native/core": "4.3.3",
"@ionic-native/device": "3.4.4",
"@ionic-native/globalization": "^4.0.1",
"@ionic-native/native-storage": "3.4.4",
"@ionic-native/network": "3.12.1",
"@ionic-native/splash-screen": "3.12.1",
"@ionic-native/sqlite": "3.4.4",
"@ionic-native/status-bar": "3.12.1",
"@ionic/app-scripts": "2.0.2",
"@ionic/storage": "2.1.3",
"@ngx-translate/core": "^8.0.0",
"@ngx-translate/http-loader": "^0.1.0",
"angular2-jwt": "^0.2.3",
"cordova-plugin-apprate": "~1.3.0",
"cordova-plugin-console": "1.0.5",
"cordova-plugin-device": "1.1.4",
"cordova-plugin-globalization": "^1.0.7",
"cordova-plugin-splashscreen": "~4.0.1",
"cordova-plugin-statusbar": "2.2.2",
"cordova-plugin-whitelist": "1.3.1",
"css-animator": "^2.1.1",
"ionic-angular": "3.9.2",
"ionic-plugin-keyboard": "~2.2.1",
"ionic2-super-tabs": "^4.1.4",
"ionicons": "3.0.0",
"json-object-mapper": "^1.5.1",
"lodash": "^4.17.4",
"moment": "^2.18.1",
"moment-range": "^3.0.3",
"ng2-currency-mask": "^4.4.1",
"reflect-metadata": "^0.1.10",
"rxjs": "5.5.2",
"sw-toolbox": "3.6.0",
"web-animations-js": "^2.2.5",
"zone.js": "0.8.18",
"cordova-android": "~6.3.0"
},
"devDependencies": {
"@angular/tsc-wrapped": "^4.4.6",
"@ionic/app-scripts": "^3.1.0",
"ionic": "3.18.0",
"typescript": "2.4.2"
},
"cordovaPlugins": [
"cordova-plugin-whitelist",
"cordova-plugin-console",
"cordova-plugin-statusbar",
"cordova-plugin-device",
"cordova-plugin-splashscreen",
"ionic-plugin-keyboard"
],
"cordovaPlatforms": [],
"description": "mraMfile: An Ionic project",
"cordova": {
"plugins": {
"cordova-plugin-globalization": {},
"cordova-plugin-console": {},
"cordova-plugin-device": {},
"cordova-plugin-splashscreen": {},
"cordova-plugin-statusbar": {},
"cordova-plugin-whitelist": {},
"ionic-plugin-keyboard": {},
"cordova-plugin-apprate": {}
},
"platforms": [
"android"
]
}
}
Current behavior:
When running ionic cordova build android --prod, the following error occurs
E:\Mobile Source\mraMfile2>ionic cordova build android --prod
Running app-scripts build: --prod --platform android --target cordova
[09:42:46]  build prod started ...
[09:42:46]  clean started ...
[09:42:46]  clean finished in 12 ms
[09:42:46]  copy started ...
[09:42:46]  ngc started ...
Error: Please update @angular/cli. Angular 5+ requires at least Angular CLI 1.5+
at throwNotSupportedError (E:\Mobile Source\mraMfile2\node_modules@angular\compiler-cli\src\ngtools_api.js:78:11)
at Function.NgTools_InternalApi_NG_2.codeGen (E:\Mobile Source\mraMfile2\node_modules@angular\compiler-cli\src\ngtools_api.js:31:15)
at Object.doCodegen (E:\Mobile Source\mraMfile2\node_modules@ionic\app-scripts\dist\aot\codegen.js:6:51)
at E:\Mobile Source\mraMfile2\node_modules@ionic\app-scripts\dist\aot\aot-compiler.js:42:30
[09:42:47]  copy finished in 1.17 s
Expected behavior:

Steps to reproduce:

Related code:

insert short code snippets here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
cli packages: (E:\Mobile Source\mraMfile2\node_modules)

    @ionic/cli-utils  : 1.18.0
    ionic (Ionic CLI) : 3.18.0

global packages:

    cordova (Cordova CLI) : 7.1.0

local packages:

    @ionic/app-scripts : 2.0.2
    Cordova Platforms  : android 6.3.0
    Ionic Framework    : ionic-angular 3.9.2

System:

    Android SDK Tools : 25.2.5
    Node              : v6.9.2
    npm               : 3.10.9
    OS                : Windows 8.1

Environment Variables:

    ANDROID_HOME : C:\Program Files (x86)\Android\android-sdk

Misc:

    backend : legacy

some of the dependencies is blank, attache content of package.json again

I have the same issue building the app with --prod. Here is my package.json
"dependencies": {
    "@amcharts/amcharts3-angular": "^1.5.0",
    "@angular/common": "^5.0.0",
    "@angular/compiler": "5.0.0",
    "@angular/compiler-cli": "5.0.0",
    "@angular/core": "^5.0.0",
    "@angular/forms": "5.0.0",
    "@angular/http": "5.0.0",
    "@angular/platform-browser": "5.0.0",
    "@angular/platform-browser-dynamic": "5.0.0",
    "@ionic-native/app-version": "^4.1.0",
    "@ionic-native/badge": "^3.14.0",
    "@ionic-native/call-number": "^4.3.1",
    "@ionic-native/camera": "^3.8.1",
    "@ionic-native/core": "^4.3.3",
    "@ionic-native/email-composer": "^3.8.1",
    "@ionic-native/in-app-browser": "^3.12.1",
    "@ionic-native/network": "^3.8.1",
    "@ionic-native/push": "^3.8.1",
    "@ionic-native/screen-orientation": "^4.3.1",
    "@ionic-native/splash-screen": "^4.3.3",
    "@ionic-native/status-bar": "^4.3.3",
    "@ionic/storage": "2.1.3",
    "angular2-jwt": "^0.2.3",
    "angular2-moment": "^1.3.3",
    "call-number": "^1.0.1",
    "cordova-android": "~6.1.2",
    "cordova-ios": "4.3.1",
    "cordova-plugin-app-version": "~0.1.9",
    "cordova-plugin-badge": "~0.7.4",
    "cordova-plugin-camera": "~2.3.1",
    "cordova-plugin-console": "1.0.5",
    "cordova-plugin-device": "1.1.4",
    "cordova-plugin-email": "~1.2.6",
    "cordova-plugin-file": "~4.3.1",
    "cordova-plugin-file-transfer": "~1.6.1",
    "cordova-plugin-filepath": "~1.0.2",
    "cordova-plugin-inappbrowser": "~1.7.1",
    "cordova-plugin-ionic-webview": "^1.1.16",
    "cordova-plugin-network-information": "~1.3.1",
    "cordova-plugin-screen-orientation": "^2.0.1",
    "cordova-plugin-splashscreen": "~4.0.1",
    "cordova-plugin-statusbar": "git+https://github.com/apache/cordova-plugin-statusbar.git",
    "cordova-plugin-whitelist": "1.3.1",
    "date-fns": "^1.28.5",
    "es6-promise-plugin": "git+https://github.com/vstirbu/PromisesPlugin.git",
    "intl": "^1.2.5",
    "ionic-angular": "^3.9.2",
    "ionic-plugin-deeplinks": "~1.0.14",
    "ionic-plugin-keyboard": "~2.2.1",
    "ionic2-calendar": "^0.3.11",
    "ionicons": "3.0.0",
    "moment": "^2.18.1",
    "phonegap-plugin-push": "~1.8.4",
    "rxjs": "5.5.2",
    "sw-toolbox": "3.6.0",
    "zone.js": "0.8.18"
  },
  "devDependencies": {
    "@ionic/app-scripts": "^3.1.0",
    "typescript": "2.4.2"
  },
  "cordovaPlugins": [
    "cordova-plugin-whitelist",
    "cordova-plugin-statusbar",
    "cordova-plugin-console",
    "cordova-plugin-device",
    "cordova-plugin-splashscreen",
    "ionic-plugin-keyboard"
  ],

Thanks!

try
 rm -rf node_modules && rm package-lock.json && npm install

@yemenifree I tried that and I also removed www still doesn't work.

@aces-tm check #13310

@yemenifree Unfortunately I don't see solution for my problem in that tread. They are talking about it, but it doesn't seem as they solved it...

I have similar problem , when run with normal build the app runs fine , but when ran with --prod, it errors out :
vendor.js:1 Uncaught TypeError: P.a.defineLocale is not a function
vendor.js:1 Ionic Native: deviceready event fired after 441 ms

not sure what is this all about , I can't track the issue , nor sure where defineLocale being called from!

I opened it at ionic-cli repo.


Flake test  TestAddRemovePodWaypoint

https://github.com/kmesh-net/kmesh/actions/runs/11285321459/job/31387912728?pr=900
=== RUN   TestAddRemovePodWaypoint/after
2024-10-11T02:45:41.358878Z	info	tf	=== BEGIN: Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after]' ===
=== RUN   TestAddRemovePodWaypoint/after/from_service-with-waypoint-at-service-granularity
2024-10-11T02:45:41.359113Z	info	tf	=== BEGIN: Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after/from_service-with-waypoint-at-service-granularity]' ===
    baseline_test.go:512: 2 errors occurred:
        	* failed calling service-with-waypoint-at-service-granularity (cluster=cluster-0)->'http://<IP_ADDRESS>:18080/': call failed from service-with-waypoint-at-service-granularity (cluster=cluster-0) to http://<IP_ADDRESS>:18080/ (using http): 10 errors occurred:
        	* response[0]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[1]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[2]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[3]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[4]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[5]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[6]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[7]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[8]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[9]: X-Request-Id set, is L7 processing enabled unexpectedly?

        	* failed calling service-with-waypoint-at-service-granularity (cluster=cluster-0)->'http://<IP_ADDRESS>:18080/': call failed from service-with-waypoint-at-service-granularity (cluster=cluster-0) to http://<IP_ADDRESS>:18080/ (using http): 10 errors occurred:
        	* response[0]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[1]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[2]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[3]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[4]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[5]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[6]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[7]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[8]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[9]: X-Request-Id set, is L7 processing enabled unexpectedly?

2024-10-11T02:46:41.360333Z	info	tf	=== DONE (failed):  Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after/from_service-with-waypoint-at-service-granularity] (1m0.001215283s)' ===
=== RUN   TestAddRemovePodWaypoint/after/from_service-with-waypoint-at-service-granularity#01
2024-10-11T02:46:41.360668Z	info	tf	=== BEGIN: Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after/from_service-with-waypoint-at-service-granularity#01]' ===
    baseline_test.go:512: 2 errors occurred:
        	* failed calling service-with-waypoint-at-service-granularity (cluster=cluster-0)->'http://<IP_ADDRESS>:18080/': call failed from service-with-waypoint-at-service-granularity (cluster=cluster-0) to http://<IP_ADDRESS>:18080/ (using http): 10 errors occurred:
        	* response[0]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[1]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[2]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[3]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[4]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[5]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[6]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[7]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[8]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[9]: X-Request-Id set, is L7 processing enabled unexpectedly?

        	* failed calling service-with-waypoint-at-service-granularity (cluster=cluster-0)->'http://<IP_ADDRESS>:18080/': call failed from service-with-waypoint-at-service-granularity (cluster=cluster-0) to http://<IP_ADDRESS>:18080/ (using http): 10 errors occurred:
        	* response[0]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[1]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[2]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[3]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[4]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[5]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[6]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[7]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[8]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[9]: X-Request-Id set, is L7 processing enabled unexpectedly?

2024-10-11T02:47:41.36[1983](https://github.com/kmesh-net/kmesh/actions/runs/11285321459/job/31387912728?pr=900#step:4:1984)Z	info	tf	=== DONE (failed):  Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after/from_service-with-waypoint-at-service-granularity#01] (1m0.001310965s)' ===
=== RUN   TestAddRemovePodWaypoint/after/from_enrolled-to-kmesh
2024-10-11T02:47:41.362311Z	info	tf	=== BEGIN: Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after/from_enrolled-to-kmesh]' ===
    baseline_test.go:512: 2 errors occurred:
        	* failed calling enrolled-to-kmesh (cluster=cluster-0)->'http://<IP_ADDRESS>:18080': call failed from enrolled-to-kmesh (cluster=cluster-0) to http://<IP_ADDRESS>:18080 (using http): 10 errors occurred:
        	* response[0]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[1]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[2]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[3]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[4]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[5]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[6]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[7]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[8]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[9]: X-Request-Id set, is L7 processing enabled unexpectedly?

        	* failed calling enrolled-to-kmesh (cluster=cluster-0)->'http://<IP_ADDRESS>:18080/': call failed from enrolled-to-kmesh (cluster=cluster-0) to http://<IP_ADDRESS>:18080/ (using http): 10 errors occurred:
        	* response[0]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[1]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[2]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[3]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[4]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[5]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[6]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[7]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[8]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[9]: X-Request-Id set, is L7 processing enabled unexpectedly?

2024-10-11T02:48:41.363989Z	info	tf	=== DONE (failed):  Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after/from_enrolled-to-kmesh] (1m0.00167427s)' ===
=== RUN   TestAddRemovePodWaypoint/after/from_enrolled-to-kmesh#01
2024-10-11T02:48:41.364342Z	info	tf	=== BEGIN: Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after/from_enrolled-to-kmesh#01]' ===
    baseline_test.go:512: 2 errors occurred:
        	* failed calling enrolled-to-kmesh (cluster=cluster-0)->'http://<IP_ADDRESS>:18080': call failed from enrolled-to-kmesh (cluster=cluster-0) to http://<IP_ADDRESS>:18080 (using http): 10 errors occurred:
        	* response[0]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[1]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[2]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[3]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[4]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[5]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[6]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[7]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[8]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[9]: X-Request-Id set, is L7 processing enabled unexpectedly?

        	* failed calling enrolled-to-kmesh (cluster=cluster-0)->'http://<IP_ADDRESS>:18080': call failed from enrolled-to-kmesh (cluster=cluster-0) to http://<IP_ADDRESS>:18080 (using http): 10 errors occurred:
        	* response[0]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[1]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[2]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[3]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[4]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[5]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[6]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[7]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[8]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[9]: X-Request-Id set, is L7 processing enabled unexpectedly?

[2024](https://github.com/kmesh-net/kmesh/actions/runs/11285321459/job/31387912728?pr=900#step:4:2025)-10-11T02:49:41.365715Z	info	tf	=== DONE (failed):  Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after/from_enrolled-to-kmesh#01] (1m0.001369123s)' ===
2024-10-11T02:49:41.365776Z	info	tf	=== DONE (failed):  Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after] (4m0.006895877s)' ===
2024-10-11T02:49:41.365810Z	info	tf	=== DONE (failed):  Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint] (4m5.259670571s)' ===
--- FAIL: TestAddRemovePodWaypoint (248.29s)
    --- PASS: TestAddRemovePodWaypoint/before (0.05s)
        --- PASS: TestAddRemovePodWaypoint/before/from_service-with-waypoint-at-service-granularity (0.01s)
        --- PASS: TestAddRemovePodWaypoint/before/from_service-with-waypoint-at-service-granularity#01 (0.01s)
        --- PASS: TestAddRemovePodWaypoint/before/from_enrolled-to-kmesh (0.01s)
        --- PASS: TestAddRemovePodWaypoint/before/from_enrolled-to-kmesh#01 (0.01s)
    --- FAIL: TestAddRemovePodWaypoint/after (240.01s)
        --- FAIL: TestAddRemovePodWaypoint/after/from_service-with-waypoint-at-service-granularity (60.00s)
        --- FAIL: TestAddRemovePodWaypoint/after/from_service-with-waypoint-at-service-granularity#01 (60.00s)
        --- FAIL: TestAddRemovePodWaypoint/after/from_enrolled-to-kmesh (60.00s)
        --- FAIL: TestAddRemovePodWaypoint/after/from_enrolled-to-kmesh#01 (60.00s)
=== RUN   TestRemoveAddNsOrServiceWaypoint

/assign

https://github.com/kmesh-net/kmesh/actions/runs/11548726872/job/32140588372?pr=900

Frequently failed in ipv6 test
=== RUN   TestAddRemovePodWaypoint/after/from_enrolled-to-kmesh#01
2024-11-21T16:05:15.661096Z	info	tf	=== BEGIN: Test: '_home_runner_work_kmesh_kmesh_test_e2e[TestAddRemovePodWaypoint/after/from_enrolled-to-kmesh#01]' ===
    baseline_test.go:519: failed calling enrolled-to-kmesh (cluster=cluster-0)->'http://[fd00:10:244:1::9]:18080': call failed from enrolled-to-kmesh (cluster=cluster-0) to http://[fd00:10:244:1::9]:18080 (using http): 10 errors occurred:
        	* response[0]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[1]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[2]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[3]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[4]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[5]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[6]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[7]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[8]: X-Request-Id set, is L7 processing enabled unexpectedly?
        	* response[9]: X-Request-Id set, is L7 processing enabled unexpectedly?


use argon thing

for passwords, see. https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html

yup, done


⚠ Bofrost.be has degraded performance

In 37992b2, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1362 ms

Resolved: Bofrost.be performance has improved in 52bd749.


[WIP] Restructure

This is still very much a work in progress without a lot of progress. I spent some time in the last few days rethinking the basic db (and app) structure. Not sure how far I'll get in the next few days, so I'm dumping this here for now.
Basic ideas:

The old database schema is based on my laziness and uses PostgreSQL like a nosql database, which is super weird and has lots of issues, this amends that.
The old scraper and server are much too intertwined and could use some splitting apart, maybe even throwing away the entire server in the process and replacing it with something more sensible.
The API responses are weirdly structured and should be optimized, the old format will obviously still have to be supported indefinitely for the apps.
The city data and modules should leave this repository (@jklmnn already did that) and data should be updated regularly. The geojson files are already out-of-date and contain wildly inconsistent data.
Deployment should be optimized, ideally through the use of a Docker image/compose file, see #103.

This PR will likely stay open for a while, please unsubscribe if you don't want to get GitHub notifications for every update 🙈 I apologize in advance! 😅 I'm opening it instead of just leaving a branch so that changes can be discussed here.

The biggest change for now is the proposed db structure. It can be found here:
https://github.com/offenesdresden/ParkAPI/blob/ad3a86a7db021bdc3d58eedf71612f4e80187d56/db/parkapi_schema.sql#L1-L84
There's (at least) two todos there still open. Updating the created_at and updated_at fields with a trigger on the respective tables and automatically creating pools (see #130) for every source.

I just want to state that I did not yet remove the modules from the main repo completely. There are still unresolved dependencies. You can use the modules from https://github.com/offenesdresden/ParkApi_Modules with my ParkAPI fork https://github.com/offenesdresden/ParkAPI/tree/external_modules but you cannot use the modules alone as they still require dependencies only available in the ParkAPI repo. This is surely something that needs to be fixed.

Dumping this here so that I don't lose it. Forecast data is still missing.

Closing in favor of a new approach.


VSDX data and link import

I created links to another page and to a shape (container) on a third page, as indicated below. I also removed all shape data fields and added a new one ("Comment"), which I modified for the two sub processes on the first page.
Loading the vsdx file to draw.io looks good, but does not contain shape data, nor the links.

It will be added in the next release

It will be added in the next release


New command: cli config set

Usage
m365 cli config set [options]
Description
Update specific CLI setting with a new value
Options

Option
Description

-k, --key <key>
The setting to be updated

-v, --value <value>
The new value

Additional Information
We currently don't provide a way to easily update CLI settings, for example, if a someone wants to use their own identity, we ask them to update two environment variables CLIMICROSOFT365_AADAPPID and CLIMICROSOFT365_TENANT, however it maybe beneficial to provide a command that makes this easier for users to set these settings to their own preference using the CLI and persisting these settings to disk, in a file stored in the users root directory e.g .cli-microsoft365, for convenience.
This command would also provide a future extensibility as we grow personalisation options.
m365 cli config set --key aadappid --value 506af689-32aa-46c8-afb5-972ebf9d218a
m365 cli config set --key tenantid --value e8954f17-a373-4b61-b54d-45c038fe3188

GitHub CLI implements a similar command, gh config set <key> <value>, for updating default settings to user preferences. Source: https://cli.github.com/manual/gh_config_set

I love the idea! Shall we rename the command to m365 cli config set to make it clear what we're setting/getting?

Happy to include config 👍🏻
In regards to persisting settings, should we create a new file in the home directory to store these values, something like .climicrosoft365?

I think we already have the logic in place for the tokens file so we could reuse it for this config file as well.

Sounds like a great plan!

I think we already have the logic in place for the tokens file so we could reuse it for this config file as well.

Ok great, so lets reuse the .cli-m365-tokens.json file 👍

@garrytrinder just to clarify: what I meant was that we have the logic to work with a custom file stored in the user's root folder, not that we should store settings in the same file. That said, we could do it, but then we should consider renaming the file since it no longer would be containing just the tokens.

Apologies, I think I misread your comment and thank you for clearing this up.
It makes sense to have separate files, I'll update the spec.

I've updated code samples in the issue with the new command name. 🚀

I can try to implement this command if it's ok for you 🙂

I can try to implement this command if it's ok for you 🙂

Before we start, @garrytrinder with the recent introduction of the --appId and --tenant options for the login command, is this command still necessary?

Before we start, @garrytrinder with the recent introduction of the --appId and --tenant options for the login command, is this command still necessary?

Ok, I'll try with that updated approach...! 😅
I've got a couple of questions:

When / where should the config be loaded? In the cli\Cli.ts file or somewhere else?
What is the best between

loading the configstore on a higher level of the CLI
loading it on the fly, when executing the cli config set command

Should the configstore be initialized at first start with pre-configured properties?
Which settings will we add (other than "always-show-help-on-error")?

Ok, I'll try with that updated approach...! 😅
I've got a couple of questions:

When / where should the config be loaded? In the cli\Cli.ts file or somewhere else?
What is the best between

loading the configstore on a higher level of the CLI
loading it on the fly, when executing the cli config set command

Should the configstore be initialized at first start with pre-configured properties?
Which settings will we add (other than "always-show-help-on-error")?

I think it's twofold: setting config and loading config. For the purpose of this command, loading config is out of scope. We could decide if we implement validation for checking config names, which allows for more flexibility, or if we validate the specified name and each time introduce a new setting, we'll also need to update the whitelist.
How does git handle it for example? My preference would be the first (no validation) but I'm curious how others see it @pnp/cli-for-microsoft-365-maintainers

I think it's twofold: setting config and loading config. For the purpose of this command, loading config is out of scope. We could decide if we implement validation for checking config names, which allows for more flexibility, or if we validate the specified name and each time introduce a new setting, we'll also need to update the whitelist.
How does git handle it for example? My preference would be the first (no validation) but I'm curious how others see it @pnp/cli-for-microsoft-365-maintainers

AFAIK on the gh config set command, it only allows to set already defined properties : git_protocol, editor, prompt and pager.
So even if we let it free to configure for users, the CLI should own some keys to configure its usage, right?

AFAIK on the gh config set command, it only allows to set already defined properties : git_protocol, editor, prompt and pager.
So even if we let it free to configure for users, the CLI should own some keys to configure its usage, right?

I see configuring the settings and actually using them in the CLI as two separate things. This command is meant to allow users to configure CLI settings, whatever these settings are. Making specific pieces of the CLI configurable based on users' preferences should be specced and implemented separately. If we want to introduce a validation of keys, then we'd need to know at least one or we won't be able to complete the implementation of this method.

I see configuring the settings and actually using them in the CLI as two separate things. This command is meant to allow users to configure CLI settings, whatever these settings are. Making specific pieces of the CLI configurable based on users' preferences should be specced and implemented separately. If we want to introduce a validation of keys, then we'd need to know at least one or we won't be able to complete the implementation of this method.

We're agree on that point 😊
But I don't have any idea about key settings to start with...
Le mar. 12 janv. 2021 à 19:30, Waldek Mastykarz<EMAIL_ADDRESS>a écrit :

I see configuring the settings and actually using them in the CLI as two
separate things. This command is meant to allow users to configure CLI
settings, whatever these settings are. Making specific pieces of the CLI
configurable based on users' preferences should be specced and implemented
separately. If we want to introduce a validation of keys, then we'd need to
know at least one or we won't be able to complete the implementation of
this method.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pnp/cli-microsoft365/issues/1945#issuecomment-758852176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRYOYS7DG3QTVBBPQHQI4TSZSILFANCNFSM4TTG5G5Q
.

We're agree on that point 😊
But I don't have any idea about key settings to start with...
Le mar. 12 janv. 2021 à 19:30, Waldek Mastykarz<EMAIL_ADDRESS>a écrit :

I see configuring the settings and actually using them in the CLI as two
separate things. This command is meant to allow users to configure CLI
settings, whatever these settings are. Making specific pieces of the CLI
configurable based on users' preferences should be specced and implemented
separately. If we want to introduce a validation of keys, then we'd need to
know at least one or we won't be able to complete the implementation of
this method.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pnp/cli-microsoft365/issues/1945#issuecomment-758852176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRYOYS7DG3QTVBBPQHQI4TSZSILFANCNFSM4TTG5G5Q
.

showHelpOnFailure which controls if we automatically show help when command fails or not

showHelpOnFailure which controls if we automatically show help when command fails or not

We had the spec approved, so you can definitely start working on it. Appreciate your help! 👍

We had the spec approved, so you can definitely start working on it. Appreciate your help! 👍


Include PR desc in merge commit

First of, thanks for the great work! We are using homu at beavy and it works just great. It is especially great as our setup encourages people to have PRs on their own forks, but when reviewing happens in bulk we often weren't able to merge, because people had to update their branches. Homu fixes that and reminds people when there is an merge conflict to fix when there is. Our process now requires that things can only be merged once travis and homu confirmed them. That is awesome, thanks for that work!
This issue is more an improvement rather than a bug: We use the PR to not only discuss the feature but also include a longer description of what is happening and why a change was made in the description. Unfortunately this information is lost at the moment homu merges the PR. It'd be awesome if we could inform homu that it should include the issue desc in the body of the merge-commit, so you have a big explanatory changelog when going through the master history.
Keep up the great work!

@ligthyear do you mean the original description or the entire conversation?

@sigmavirus24 for what we need: the original description.
We keep that up to date (and whoever reviews, can usually also update that right before) throughout the conversation. I think adding the entire conversation makes it more confusing than helpful.

Wait a second. Am I seeing this already? How did I miss this before? Sorry for bothering you, it appears you already have that feature in there. Closing the issue.


Read document as stream

New Feature Proposal
Description
Right now we can take a document (or node) and write it somewhere using .ToHtml(). What I'd like to do is avoid copying the document to something altogether and pull from the document structure instead. I.e. something like .ReadAsStream(). Then I'll be able to pass around my IHtmlDocument once I've gone to the trouble of parsing it and avoid the allocations and extra work of serializing it back to a string.
Maybe I'm missing how this can be done out of the box? Or perhaps you've got some pointers if I take this on?

You can pass the ToHtml a TextWriter instance. A TextWriter may hold an underlying stream. Is that what you've been looking for?

You can pass the ToHtml a TextWriter instance. A TextWriter may hold an underlying stream. Is that what you've been looking for?

Not quite - that will crawl the node tree, writing to the TextWriter (and underlying Stream) all at once. What I'm thinking about is reading as a stream on the fly.
The way I think it might work is a special stream that uses a buffer and descends the nodes, filling the buffer and reading from that as it goes. If you only want to read the first n bytes for example, the entire tree doesn't have to be descended and serialized.
Does that make any sense? It's entirely possible I'm talking myself in circles :)

Not quite - that will crawl the node tree, writing to the TextWriter (and underlying Stream) all at once. What I'm thinking about is reading as a stream on the fly.
The way I think it might work is a special stream that uses a buffer and descends the nodes, filling the buffer and reading from that as it goes. If you only want to read the first n bytes for example, the entire tree doesn't have to be descended and serialized.
Does that make any sense? It's entirely possible I'm talking myself in circles :)

Hm I am not sure. If you want to consume HTML you can just pass in a Stream. The HtmlParser and all related code (e.g., BrowsingContext's OpenAsync) all support reading from a Stream.
Maybe I don't see what you want / where you are after. But you'd always need to descend the tree. If you want to stop at a specific point in time then I'd suggest having your own IMarkupFormatter for this. Here you can stop any time.

Hm I am not sure. If you want to consume HTML you can just pass in a Stream. The HtmlParser and all related code (e.g., BrowsingContext's OpenAsync) all support reading from a Stream.
Maybe I don't see what you want / where you are after. But you'd always need to descend the tree. If you want to stop at a specific point in time then I'd suggest having your own IMarkupFormatter for this. Here you can stop any time.

Maybe it would help if I explained the specific use case. In Statiq each document has a "content provider" that can be used to read the content of that document by anything that needs to process it. For example, a document based on a file from disk will have a content provider that reads the file as a stream. A document created from a string will have a StringReader-based content provider and so on.
In the course of processing documents, some operations result in constructing an AngleSharp IHtmlDocument instance and then mutating it. Right now I serialize that document back out to either disk or a MemoryStream so that the content can be provided later. I’ve noticed some memory pressure due to this cycle - I have some content (file, string, etc.), create an AngleSharp node tree and do some stuff, serialize to a string, then do something later by reading that HTML content that I serialized as a stream later on. I’d like to cut out the middle part where I have to serialize the HTML to an intermediate object (string, MemoryStream, file, etc.) - I’ve already allocated everything I need to read it within the node tree and the extra holding object for the fully serialized content seems unnecessary. Instead I want to wrap the IHtmlDocument as a content provider itself and provide a readable stream that descends the nodes directly whenever something else needs to “read” it.
Did that make any more sense? I’m planning on looking at this myself, so more wondering if you’ve got any tips rather than an actual feature request.

Maybe it would help if I explained the specific use case. In Statiq each document has a "content provider" that can be used to read the content of that document by anything that needs to process it. For example, a document based on a file from disk will have a content provider that reads the file as a stream. A document created from a string will have a StringReader-based content provider and so on.
In the course of processing documents, some operations result in constructing an AngleSharp IHtmlDocument instance and then mutating it. Right now I serialize that document back out to either disk or a MemoryStream so that the content can be provided later. I’ve noticed some memory pressure due to this cycle - I have some content (file, string, etc.), create an AngleSharp node tree and do some stuff, serialize to a string, then do something later by reading that HTML content that I serialized as a stream later on. I’d like to cut out the middle part where I have to serialize the HTML to an intermediate object (string, MemoryStream, file, etc.) - I’ve already allocated everything I need to read it within the node tree and the extra holding object for the fully serialized content seems unnecessary. Instead I want to wrap the IHtmlDocument as a content provider itself and provide a readable stream that descends the nodes directly whenever something else needs to “read” it.
Did that make any more sense? I’m planning on looking at this myself, so more wondering if you’ve got any tips rather than an actual feature request.


Store filter settings in userinfo records

Initially reported by: @skippy as #TRAC211
When an administrative user sets filters on any listing that supports filtering, those filter selections are lost when they navigate away from the page.  For example, if a user filters /admin/content to only show drafts, the next time they visit /admin/content they will be shown published entries, forcing them to re-filter the listing.
I propose that the values used to filter the display be saved in a userinfo record, so that subsequent visits to those pages preserve the filter settings.  Using a userinfo record ensures that the settings remain across user sessions.

Related #272.

Rather than saving the filter in a userinfo record, which would prevent the user from having different filters at the same time (in different windows, for whatever reason), I would suggest allowing the user to define a default filter. We use presets for displaying posts in admin in 0.10, allowing the user to create a preset and use that would be a nice solution.

Also, whatever solution we come up with, I think this might be better in a plugin.


electron: mark insecure versions (3,4,5) and require explicit version of electron in packages

Motivation for this change

require explicit version of electron in packages
point electron alias to the latest stable version

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I like this approach, for whatever reason electron packages indeed aren't sufficiently tested (sometimes not at all, other times the issue is not immediately obvious).
Conflict is hopefully minor :).
Out of curiosity--if packaged applications find using specific versions of electron useful/necessary,
what uses (out-of-tree?) might there be for a generic electron alias that points to latest?
Makes sense to have it regardless, I think, for backwards-compat reasons but curious if there's more than that :).
(see also fun situation with LLVM versions ^_^)

Conflict is hopefully minor :).

It was. :-) Resolved the conflict in de5799f3e75d2368c441a88364dc42cb2ca4335c

what uses (out-of-tree?) might there be for a generic electron alias that points to latest?

pkgs/applications/misc/nix-tour/default.nix uses electron without version, but I think that's the only in-tree package that does that

Marked electron versions 3, 4, 5 insecure (in 1499874) as per https://github.com/NixOS/nixpkgs/issues/93264, https://github.com/NixOS/nixpkgs/issues/93254, https://github.com/NixOS/nixpkgs/issues/93257

@prusnak Thank you soo much :sparkles:  :sparkling_heart:


White Atom window when I open a file from terminal

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

I did everything except the "Safe Mode" because I can't reproduce the problem constantly and I'm not able to run Atom in safe mode all the day.
Description
When I open a file doing atom /path/of/the/file.js or cmd + clicking on a file path in iTerm 2, some times (once a day?) a white window of Atom opens, the "custom titlebar" gets disabled, and I see a new Atom icon in the Dock.
As you can see, the Atom icon in the Dock is different from the custom one I have assigned to my Atom.app.

Open Files and Ports of the process:
cwd
/
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/MacOS/Atom
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Squirrel.framework/Versions/A/Squirrel
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/A/ReactiveCocoa
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Mantle.framework/Versions/A/Mantle
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libffmpeg.dylib
txt
/System/Library/Frameworks/CoreMIDI.framework/Versions/A/CoreMIDI
txt
/usr/lib/libexpat.1.dylib
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Resources/app.asar.unpacked/node_modules/nslog/build/Release/nslog.node
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/en_GB.lproj/locale.pak
txt
/usr/share/icu/icudt57l.dat
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/icudtl.dat
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/snapshot_blob.bin
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/natives_blob.bin
txt
/usr/lib/libstdc++.6.0.9.dylib
txt
/System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/SystemAppearance.car
txt
/Users/federicozivolo/Library/Application Support/Atom/GPUCache/data_0
txt
/Users/federicozivolo/Library/Application Support/Atom/GPUCache/data_1
txt
/Users/federicozivolo/Library/Application Support/Atom/GPUCache/data_2
txt
/Users/federicozivolo/Library/Application Support/Atom/GPUCache/data_3
txt
/System/Library/Frameworks/OpenGL.framework/Versions/A/Resources/GLEngine.bundle/GLEngine
txt
/System/Library/Extensions/AMDRadeonX4000GLDriver.bundle/Contents/MacOS/AMDRadeonX4000GLDriver
txt
/System/Library/Extensions/AMDRadeonX4000GLDriver.bundle/Contents/MacOS/ATIRadeonX4000SCLib.dylib
txt
/System/Library/Frameworks/OpenGL.framework/Versions/A/Resources/GLRendererFloat.bundle/GLRendererFloat
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/content_shell.pak
txt
/System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/Assets.car
txt
/System/Library/Keyboard Layouts/AppleKeyboardLayouts.bundle/Contents/Resources/AppleKeyboardLayouts-L.dat
txt
/System/Library/Caches/com.apple.IntlDataCache.le.kbdx
txt
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Resources/app.asar.unpacked/node_modules/pathwatcher/build/Release/pathwatcher.node
txt
/System/Library/Fonts/SFNSText.ttf
txt
/System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/VibrantLightAppearance.car
txt
/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/Libraries/libCGInterfaces.dylib
txt
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Resources/Extras2.rsrc
txt
/private/var/folders/78/glbtflts3sl9tsm2jq7btvqw0000gn/C/com.github.atom/com.apple.metal/libraries1.data
txt
/private/var/folders/78/glbtflts3sl9tsm2jq7btvqw0000gn/C/com.github.atom/com.apple.metal/AMD Radeon R9 M295X/functions1.data
txt
/Users/federicozivolo/Library/Caches/com.github.atom/Cache.db-shm
txt
/private/var/db/mds/messages/501/se_SecurityMessages
txt
/Users/federicozivolo/Library/Application Support/Atom/GPUCache/index
txt
/System/Library/CoreServices/SystemAppearance.bundle/Contents/Resources/FunctionRowAppearance.car
txt
/System/Library/Fonts/Helvetica.dfont
txt
/usr/lib/dyld
txt
/private/var/db/dyld/dyld_shared_cache_x86_64h
0
/dev/null
1
/dev/null
2
/dev/null
3
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/icudtl.dat
4
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/snapshot_blob.bin
5
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/natives_blob.bin
6
->0x521884d11ae23d67
7
->0x521884d11ae24367
8
count=0, state=0x9
9
->0x521884d11ae21727
10
->0x521884d11ae22aa7
11
->0x521884d11ae217e7
12
->0x521884d11ae238e7
13
/dev/urandom
14
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Resources/electron.asar
15
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Resources/app.asar
16
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/en_GB.lproj/locale.pak
17
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/content_shell.pak
18
19
->0x521884d13c2c5fbf
20
->0x521884d11ae24127
21
->0x521884d13c2c808f
22
->0x521884d11ae239a7
23
->0x521884d11ae22867
24
->0x521884d11ae22927
25
->0x521884d11ae24427
26
count=0, state=0x8
27
/
28
/private/etc
29
/private/etc/hosts
30
->0x521884d11ae220e7
31
->0x521884d13c2c8607
32
->0x521884d13c2c6dcf
33
->0x521884d11ae21f67
34
->0x521884d11ae23467
35
->0x521884d13c2c7987
36
->0x521884d13c2c6e97
37
->0x521884d11ae22567
38
->0x521884d11ae229e7
39
->0x521884d13c2c70ef
40
->0x521884d13c2c6857
41
->0x521884d13c2c853f
42
count=0, state=0xa
43
/Users/federicozivolo/.atom/config.cson
44
/dev/null
45
/var/folders/78/glbtflts3sl9tsm2jq7btvqw0000gn/T/atom-1.16.0-federicozivolo.sock
46
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Resources/Extras2.rsrc
47
->0x521884d13c2c8477
48
/System/Library/Frameworks/CoreImage.framework/ci_kernels.metallib
49
/private/var/folders/78/glbtflts3sl9tsm2jq7btvqw0000gn/C/com.github.atom/com.apple.metal/libraries1.maps
50
/private/var/folders/78/glbtflts3sl9tsm2jq7btvqw0000gn/C/com.github.atom/com.apple.metal/libraries1.data
51
/private/var/folders/78/glbtflts3sl9tsm2jq7btvqw0000gn/C/com.github.atom/com.apple.metal/AMD Radeon R9 M295X/functions1.maps
52
/private/var/folders/78/glbtflts3sl9tsm2jq7btvqw0000gn/C/com.github.atom/com.apple.metal/AMD Radeon R9 M295X/functions1.data
53
/Users/federicozivolo/Library/Caches/com.github.atom.ShipIt/update.r6icPEi/Atom.app/Contents/Resources/app.asar
54
/Users/federicozivolo/Library/Application Support/Atom/GPUCache/index
55
/Users/federicozivolo/Library/Application Support/Atom/GPUCache/data_0
56
/Users/federicozivolo/Library/Caches/com.github.atom/Cache.db
57
/Users/federicozivolo/Library/Application Support/Atom/GPUCache/data_1
58
/Users/federicozivolo/Library/Application Support/Atom/GPUCache/data_2
59
/Users/federicozivolo/Library/Application Support/Atom/GPUCache/data_3
60
/Users/federicozivolo/Library/Caches/com.github.atom/Cache.db-wal
61
/Users/federicozivolo/Library/Caches/com.github.atom/Cache.db-shm
62
FNetwork.defaultStorageSession
64
65
/Users/federicozivolo/Library/Saved Application State/com.github.atom.savedState/data.data
66
/Users/federicozivolo/Library/Saved Application State/com.github.atom.savedState/windows.plist
67
/Users/federicozivolo/Library/Saved Application State/com.github.atom.savedState/window_1.data

Steps to Reproduce

touch /tmp/test.js
atom /tmp/test.js
sometimes, a white window will open

Expected behavior: A normal Atom instance should be open.
Actual behavior: a white Atom window appears and the custom titlebar is disabled
Reproduces how often: few times a day
Versions
$ atom --version
Atom    : 1.15.0
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0

$ apm --version
apm  1.15.3
npm  3.10.5
node 4.4.5 x64
python 2.7.12
git 2.11.0

macOS 10.12.4 (16E195)

Additional informations
I reproduce the same behavior if I use the atom CLI provided by "Atom Shell Commands" and also if I use the open -a /Applications/Atom.app command

In the blank editor, can you open dev tools (Alt-Cmd-I) and see if there are any console error messages?

I'll try when I get the white window again.

Nope, I can't open the dev tools. I have the window open right now, I'll keep it open for a while in case you reply and ask me to do any additional test.

Thanks for giving that a try, you can go ahead and close it if we can't get to devtools.
When you open a file from the command line, can you add -f e.g. atom -f /path/to/file and share any output you see when you get the white screen again?
Also just came across this issue which sounds very similar though it was closed as fixed, cross-referencing here /cc https://github.com/atom/atom/issues/4351.

I usually open them with CMD + click, I'll use the -f argument when I open them from CLI tho, I'll keep you posted.
Isn't there anything helpful in the system monitor you may need?

Isn't there anything helpful in the system monitor you may need?

Possibly but I personally wouldn't be able to use the information to debug the issue - the information could be useful to one of the other maintainers or others following the thread though.

So, I have to correct myself.
This seems to happen only when I open a file using CMD + Click inside the terminal.

When I CMD + Click on one of the blue lines of the above screenshot the error happens almost always.

When I CMD + Click on one of the blue lines of the above screenshot the error happens almost always.

Interesting, I'll try and reproduce after installing iTerm2.  Can you update your steps to reproduce?

I had a chance to install iTerm2 but I couldn't reproduce - I just ran a ls -l in a directory with a Ruby file,cmd-clicked the filename to open in Atom, and the file opened with no problem.
I tried again on the same file a few more times and then another file associated with Atom (a Markdown file) and didn't run into a white window.
Can you reproduce with any type of file that you cmd-click in iTerm2?

I tested this only with JS files because that's what I usually work with.

by this guide http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
I deleted a package that symlinks to another location.
Fixed. just FYI. :)

I have a similar problem. I made a screencapture of what the white window looks like, to me. @FezVrasta does this match your experience?

Video showing interactions with the white square

This happens 100% of the time on current Atom release (and previous one, at least) after closing a project window: another blank white window opens with the title set to the previously closed window. Dev Tools cannot be started in this window.
I've tried to run atom --reset but this didn't fix it.
It happens both when atom si started from terminal (iTerm2) or from Spotlight launcher.

This has been an ongoing problem for me as well, intermittently occurring when typing atom . in a terminal window. I typically force quit and relaunch a second time with atom .

I have the very same problem,  a blank white screen but on Windows 10.  It was working fine untill I ran a Windows Update on my machine last week.   Since then, it won't work.    I even removed and reinstalled Atom to no avail.

hi, I have the same issue in windows :-(, is there some news about how can I fix this?

Sorry, we've been unable to reproduce so no news  @Mariainesdk - if you (or anyone else) has any more repro steps we can try, please let me know.

for the record, I have not seen this repro on my mac for a few months now...


build feedstock for release 3.2.1

update conda-forge feedstock for asammdf release 3.2.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Go tests broken in a mysterious way for mantine-ui branch, blocking new UI merge

The CI Go tests for the mantine-ui branch always fail in weird random ways, although the Go-related changes in the branch are minimal: with the branch kept as is, the "Go tests" CI check always fails without discernable error (in the step go test -race --tags=stringlabels ./... under the Run make GOOPTS=--tags=stringlabels GO_ONLY=1 SKIP_GOLANGCI_LINT=1 step of the job). It terminates and fails without showing an error, and then when reloading the GH Actions job page link, it doesn't even show the logs for that step anymore. I assume especially since it's running tests with the race detector and that uses a lot of memory, it might be an OOM kill. I don't know why it would happen on that branch though.
So then I tried removing more and more of my changes as compared to main in a mantine-ui-build-test branch, and now it always explicitly fails in different tests for that branch. I even filed issues about three of those test failures already (https://github.com/prometheus/prometheus/issues/14857, https://github.com/prometheus/prometheus/issues/14856, and https://github.com/prometheus/prometheus/issues/14855), but now I'm not sure anymore whether it's actually really the individual tests that are at fault, or if something larger is at play.
The weird thing is that in the mantine-ui-build-test branch, I don't even include the new UI anymore and removed all Go-related changes completely from the branch, so it's unexplainable to me what's happening. Any assistance in unblocking this would be appreciated.
Here's the git diff main --stats for that branch, showing no Go-related changes (the Makefile one is a slight change in how the old React app is built):
 .gitignore                                                                   |     1 +
 Makefile                                                                     |     8 +
 docs/feature_flags.md                                                        |     8 +-
 scripts/ui_release.sh                                                        |     4 +-
 web/ui/build_ui.sh                                                           |    14 +-
 web/ui/mantine-ui/.gitignore                                                 |    24 +
 web/ui/mantine-ui/README.md                                                  |    30 +
 web/ui/mantine-ui/eslint.config.mjs                                          |    71 ++
 web/ui/mantine-ui/index.html                                                 |    35 +
 web/ui/mantine-ui/package.json                                               |    72 ++
 web/ui/mantine-ui/postcss.config.cjs                                         |    14 +
 web/ui/mantine-ui/public/favicon.svg                                         |    50 +
 web/ui/mantine-ui/src/App.module.css                                         |    40 +
 web/ui/mantine-ui/src/App.tsx                                                |   459 +++++++++
 web/ui/mantine-ui/src/Badge.module.css                                       |    58 ++
 web/ui/mantine-ui/src/Panel.module.css                                       |    19 +
 web/ui/mantine-ui/src/api/api.ts                                             |   128 +++
 web/ui/mantine-ui/src/api/responseTypes/alertmanagers.ts                     |    10 +
 web/ui/mantine-ui/src/api/responseTypes/config.ts                            |     5 +
 web/ui/mantine-ui/src/api/responseTypes/labelValues.ts                       |     3 +
 web/ui/mantine-ui/src/api/responseTypes/metadata.ts                          |     6 +
 web/ui/mantine-ui/src/api/responseTypes/query.ts                             |    51 +
 web/ui/mantine-ui/src/api/responseTypes/rules.ts                             |    63 ++
 web/ui/mantine-ui/src/api/responseTypes/scrapePools.ts                       |     2 +
 web/ui/mantine-ui/src/api/responseTypes/series.ts                            |     6 +
 web/ui/mantine-ui/src/api/responseTypes/targets.ts                           |    29 +
 web/ui/mantine-ui/src/api/responseTypes/tsdbStatus.ts                        |    22 +
 web/ui/mantine-ui/src/api/responseTypes/walreplay.ts                         |     7 +
 web/ui/mantine-ui/src/codemirror/theme.ts                                    |   323 +++++++
 web/ui/mantine-ui/src/components/CustomInfiniteScroll.tsx                    |    54 ++
 web/ui/mantine-ui/src/components/EndpointLink.tsx                            |    58 ++
 web/ui/mantine-ui/src/components/ErrorBoundary.tsx                           |    58 ++
 web/ui/mantine-ui/src/components/LabelBadges.tsx                             |    38 +
 web/ui/mantine-ui/src/components/ReadinessWrapper.tsx                        |    93 ++
 web/ui/mantine-ui/src/components/RuleDefinition.module.css                   |    15 +
 web/ui/mantine-ui/src/components/RuleDefinition.tsx                          |   115 +++
 web/ui/mantine-ui/src/components/SettingsMenu.tsx                            |   107 +++
 web/ui/mantine-ui/src/components/StateMultiSelect.tsx                        |   142 +++
 web/ui/mantine-ui/src/components/ThemeSelector.tsx                           |    64 ++
 web/ui/mantine-ui/src/fonts/codicon.ttf                                      |   Bin 0 -> 61024 bytes
 web/ui/mantine-ui/src/images/prometheus-logo.svg                             |    19 +
 web/ui/mantine-ui/src/lib/escapeString.ts                                    |     4 +
 web/ui/mantine-ui/src/lib/formatFloatValue.ts                                |    21 +
 web/ui/mantine-ui/src/lib/formatSeries.ts                                    |    12 +
 web/ui/mantine-ui/src/lib/formatTime.ts                                      |   136 +++
 web/ui/mantine-ui/src/main.tsx                                               |    15 +
 web/ui/mantine-ui/src/pages/AgentPage.tsx                                    |    27 +
 web/ui/mantine-ui/src/pages/AlertmanagerDiscoveryPage.tsx                    |    80 ++
 web/ui/mantine-ui/src/pages/AlertsPage.tsx                                   |   417 ++++++++
 web/ui/mantine-ui/src/pages/ConfigPage.tsx                                   |    23 +
 web/ui/mantine-ui/src/pages/FlagsPage.module.css                             |    21 +
 web/ui/mantine-ui/src/pages/FlagsPage.tsx                                    |   182 ++++
 web/ui/mantine-ui/src/pages/RulesPage.tsx                                    |   210 ++++
 web/ui/mantine-ui/src/pages/StatusPage.tsx                                   |    86 ++
 web/ui/mantine-ui/src/pages/TSDBStatusPage.tsx                               |   105 ++
 web/ui/mantine-ui/src/pages/query/DataTable.module.css                       |    10 +
 web/ui/mantine-ui/src/pages/query/DataTable.tsx                              |   214 +++++
 web/ui/mantine-ui/src/pages/query/ExplainViews/Aggregation.tsx               |   109 +++
 web/ui/mantine-ui/src/pages/query/ExplainViews/BinaryExpr/BinaryExpr.tsx     |   106 +++
 web/ui/mantine-ui/src/pages/query/ExplainViews/BinaryExpr/ScalarScalar.tsx   |    54 ++
 web/ui/mantine-ui/src/pages/query/ExplainViews/BinaryExpr/VectorScalar.tsx   |   104 ++
 web/ui/mantine-ui/src/pages/query/ExplainViews/BinaryExpr/VectorVector.tsx   |   686 +++++++++++++
 web/ui/mantine-ui/src/pages/query/ExplainViews/ExplainView.module.css        |     8 +
 web/ui/mantine-ui/src/pages/query/ExplainViews/ExplainView.tsx               |   198 ++++
 web/ui/mantine-ui/src/pages/query/ExplainViews/Selector.tsx                  |   230 +++++
 web/ui/mantine-ui/src/pages/query/ExpressionInput.module.css                 |    13 +
 web/ui/mantine-ui/src/pages/query/ExpressionInput.tsx                        |   384 ++++++++
 web/ui/mantine-ui/src/pages/query/ExpressionInput.tsx.old                    |   367 +++++++
 web/ui/mantine-ui/src/pages/query/Graph.module.css                           |    11 +
 web/ui/mantine-ui/src/pages/query/Graph.tsx                                  |   160 ++++
 web/ui/mantine-ui/src/pages/query/HistogramChart.module.css                  |   106 +++
 web/ui/mantine-ui/src/pages/query/HistogramChart.tsx                         |   309 ++++++
 web/ui/mantine-ui/src/pages/query/HistogramHelpers.ts                        |   144 +++
 web/ui/mantine-ui/src/pages/query/MetricsExplorer/LabelsExplorer.module.css  |    18 +
 web/ui/mantine-ui/src/pages/query/MetricsExplorer/LabelsExplorer.tsx         |   415 ++++++++
 web/ui/mantine-ui/src/pages/query/MetricsExplorer/MetricsExplorer.module.css |     7 +
 web/ui/mantine-ui/src/pages/query/MetricsExplorer/MetricsExplorer.tsx        |   185 ++++
 web/ui/mantine-ui/src/pages/query/QueryPage.tsx                              |   141 +++
 web/ui/mantine-ui/src/pages/query/QueryPanel.module.css                      |    14 +
 web/ui/mantine-ui/src/pages/query/QueryPanel.tsx                             |   340 +++++++
 web/ui/mantine-ui/src/pages/query/RangeInput.tsx                             |   120 +++
 web/ui/mantine-ui/src/pages/query/ResolutionInput.tsx                        |   142 +++
 web/ui/mantine-ui/src/pages/query/SeriesName.module.css                      |    19 +
 web/ui/mantine-ui/src/pages/query/SeriesName.tsx                             |    77 ++
 web/ui/mantine-ui/src/pages/query/TableTab.tsx                               |   132 +++
 web/ui/mantine-ui/src/pages/query/TimeInput.tsx                              |    88 ++
 web/ui/mantine-ui/src/pages/query/TreeNode.module.css                        |    36 +
 web/ui/mantine-ui/src/pages/query/TreeNode.tsx                               |   425 +++++++++
 web/ui/mantine-ui/src/pages/query/TreeView.tsx                               |    45 +
 web/ui/mantine-ui/src/pages/query/UPlotChart.tsx                             |    99 ++
 web/ui/mantine-ui/src/pages/query/colorPool.ts                               |   942 ++++++++++++++++++
 web/ui/mantine-ui/src/pages/query/uPlotChartHelpers.ts                       |   443 +++++++++
 web/ui/mantine-ui/src/pages/query/uPlotStackHelpers.ts                       |    96 ++
 web/ui/mantine-ui/src/pages/query/uplot.css                                  |   105 ++
 web/ui/mantine-ui/src/pages/query/urlStateEncoding.ts                        |   178 ++++
 web/ui/mantine-ui/src/pages/service-discovery/ServiceDiscoveryPage.tsx       |   148 +++
 web/ui/mantine-ui/src/pages/service-discovery/ServiceDiscoveryPoolsList.tsx  |   359 +++++++
 web/ui/mantine-ui/src/pages/targets/ScrapePoolsList.tsx                      |   429 +++++++++
 web/ui/mantine-ui/src/pages/targets/TargetLabels.tsx                         |    49 +
 web/ui/mantine-ui/src/pages/targets/TargetsPage.tsx                          |   153 +++
 web/ui/mantine-ui/src/pages/targets/TargetsPage.tsx.copy                     |   355 +++++++
 web/ui/mantine-ui/src/promql.css                                             |    35 +
 web/ui/mantine-ui/src/promql/ast.ts                                          |   210 ++++
 web/ui/mantine-ui/src/promql/binOp.test.ts                                   |  2219 +++++++++++++++++++++++++++++++++++++++++++
 web/ui/mantine-ui/src/promql/binOp.ts                                        |   419 ++++++++
 web/ui/mantine-ui/src/promql/format.tsx                                      |   322 +++++++
 web/ui/mantine-ui/src/promql/functionDocs.tsx                                |  2736 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 web/ui/mantine-ui/src/promql/functionMeta.ts                                 |   103 ++
 web/ui/mantine-ui/src/promql/functionSignatures.ts                           |   140 +++
 web/ui/mantine-ui/src/promql/serialize.ts                                    |   160 ++++
 web/ui/mantine-ui/src/promql/serializeAndFormat.test.ts                      |   657 +++++++++++++
 web/ui/mantine-ui/src/promql/utils.test.ts                                   |   155 +++
 web/ui/mantine-ui/src/promql/utils.ts                                        |   272 ++++++
 web/ui/mantine-ui/src/setupTests.ts                                          |     1 +
 web/ui/mantine-ui/src/state/hooks.ts                                         |     6 +
 web/ui/mantine-ui/src/state/initializeFromLocalStorage.ts                    |    14 +
 web/ui/mantine-ui/src/state/localStorageMiddleware.ts                        |    70 ++
 web/ui/mantine-ui/src/state/queryPageSlice.ts                                |   160 ++++
 web/ui/mantine-ui/src/state/serviceDiscoveryPageSlice.ts                     |    37 +
 web/ui/mantine-ui/src/state/settingsSlice.ts                                 |    83 ++
 web/ui/mantine-ui/src/state/store.ts                                         |    24 +
 web/ui/mantine-ui/src/state/targetsPageSlice.ts                              |    36 +
 web/ui/mantine-ui/src/types/types.ts                                         |     5 +
 web/ui/mantine-ui/src/vite-env.d.ts                                          |     1 +
 web/ui/mantine-ui/tsconfig.json                                              |    25 +
 web/ui/mantine-ui/tsconfig.node.json                                         |    11 +
 web/ui/mantine-ui/vite.config.ts                                             |    25 +
 web/ui/mantine-ui/vitest.config.ts                                           |    11 +
 web/ui/module/codemirror-promql/package.json                                 |     1 +
 web/ui/module/codemirror-promql/src/client/prometheus.ts                     |     2 +-
 web/ui/module/lezer-promql/package.json                                      |     3 +-
 web/ui/package-lock.json                                                     | 22823 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 web/ui/package.json                                                          |    27 +-
 web/ui/react-app/package-lock.json                                           | 24080 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 web/ui/react-app/package.json                                                |    12 +-
 135 files changed, 51100 insertions(+), 16222 deletions(-)

I've been trying to remove even more from the branch, and at some (nonsensical) point checks started passing, then I added stuff back again and it still worked, then failed again... most importantly, of course, everything works locally.
@SuperQ @roidelapluie any chance you have an idea here? Should we just try disabling at least the race detector for the tests or something?

Seems like maybe the build/test output is too big for the temp storage of the action:
--- FAIL: TestDelayedCompactionDoesNotBlockUnrelatedOps (0.00s)
    --- FAIL: TestDelayedCompactionDoesNotBlockUnrelatedOps/Head_is_compactable (0.73s)
        block_test.go:597:
            	Error Trace:	/__w/prometheus/prometheus/tsdb/block_test.go:597
            	            				/__w/prometheus/prometheus/tsdb/compact_test.go:2118
            	Error:      	Received unexpected error:
            	            	compactor write: preallocate: no space left on device
            	Test:       	TestDelayedCompactionDoesNotBlockUnrelatedOps/Head_is_compactable

@SuperQ Yeah, maybe... a bit surprising given that the new UI files are just a few MBs at most and according to https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories, runners have 14GB of storage. But who knows, maybe this was a last little MB that pushes things over the edge?

Is it perhaps writing to a tmpfs, so actually using RAM?

Is it perhaps writing to a tmpfs, so actually using RAM?

Could be! I'd assume that the git checkout + building actually happens on the SSD normally, but maybe some of the tests do tmpfs stuff? Not sure why there'd be a noticeable memory usage difference with my branch though, and that still seemed to happen even when not building the new UI assets at all anymore.

In any case, this is quite urgent, as I was hoping to merge the new UI branch either today or tomorrow at the latest, so that everything is ready for cutting the 3.0 release at PromCon on Wednesday.
What's the smallest possible temporary workaround we can do here? Maybe first try disabling the race detector to see if that helps (if it's really a memory usage problem, it should really help at least)?

I was under the erroneous impression that I would have to modify CI files in main to have them be used, but @SuperQ corrected me, and by changing my test branch (https://github.com/prometheus/prometheus/commits/mantine-ui-build-test-2/) I've now run df -h ; free -h as a CI step to get more info about the env and got:
Run df -h ; free -h
Filesystem      Size  Used Avail Use% Mounted on
overlay          73G   65G  7.9G  90% /
tmpfs            64M     0   64M   0% /dev
shm              64M     0   64M   0% /dev/shm
/dev/root        73G   65G  7.9G  90% /__e
tmpfs           3.2G  1.2M  3.2G   1% /run/docker.sock
tmpfs           7.9G     0  7.9G   0% /proc/acpi
tmpfs           7.9G     0  7.9G   0% /proc/scsi
tmpfs           7.9G     0  7.9G   0% /sys/firmware

               total        used        free      shared  buff/cache   available
Mem:            15Gi       1.1Gi       503Mi        23Mi        14Gi        14Gi
Swap:          4.0Gi       268Ki       4.0Gi

I then tried disabling the race detector in the failing job step, and that actually made the tests pass.

Ben suggested setting GOMEMLIMIT=10GiB for the CI test step, and that worked without even disabling the race detector! 🥳

PR with a preliminary fix: https://github.com/prometheus/prometheus/pull/14862

Often, when I drill into a specific test using a lot of memory, it turns out a simple change can fix it.
E.g. calling Commit more often on an appender.
My impression is we don't currently know which test(s) are causing high memory usage.

The test failures kept happening after my and @SuperQ's efforts to limit the Go memory usage in the tests, so as a temporary solution to get the Prometheus 3 branch merged, we ended up disabling the race detector in the tests (commit by @fionaliao: https://github.com/prometheus/prometheus/commit/24b256b7ae90b06fb119f0602ab1f13b56f94ed6), which made all the problems go away (since the race detector uses a lot of memory).
However, we do want to have the race detector enabled again soon, so I'm leaving this issue open, but downgrading to P1 and going to change the title.


[Enhancement]error message for unsupported file format

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes:

Fixes #
Problem Summary(Required):

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:disappointed: fail : 3 / 4 (75.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/connector/hive/HiveMetastoreApiConverter.java
3
4
75.00%
[173]

[FE PR Coverage Check]
:disappointed: fail : 3 / 4 (75.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/connector/hive/RemoteFileInputFormat.java
3
4
75.00%
[45]