Uncaught FetchError exception on timeout from the API

If the call to e.g. https://api.short.io/links times out in createLink, the following is thrown:
Uncaught exception {
 err: FetchError: request to https://api.short.io/links failed, reason:
     at ClientRequest.<anonymous> (/var/app/current/node_modules/node-fetch/lib/index.js:1501:11)
     [...]
     at emitErrorNT (node:internal/streams/destroy:169:8)
     at emitErrorCloseNT (node:internal/streams/destroy:128:3)
     at processTicksAndRejections (node:internal/process/task_queues:82:21) {
   type: 'system',
   errno: 'ETIMEDOUT',
   code: 'ETIMEDOUT'
 },
 origin: 'unhandledRejection'
}

This error cannot be caught, since the promise from the relevant fetch call is not returned to the caller, nor does it have a catch of its own.
Consequently, it crashes whatever process uses this package.
I wonder whether there was any reason the promise from fetch can't just be returned, and has to be wrapped in a new promise in the first place?

Good question, as you can see this package is a few years old and I didn't take the time to correctly update it. I'll look into the issue, and maybe update the package when I have the time for it.
In the mean time I would recommend using fetch directly as at this point, this simple short.io wrapper is nothing but an encapsulation of fetch calls 😅
Have a nice day, I'll keep you posted if I can work on a rewrite in the next few days.

Thanks for the speedy response, @IchiiDev!
And sure, if you don't get around to it we can definitely just make the calls directly. Either way this package is helpful as a reference for how to use the API, so thank you. 😄


crash: cannot read property 'cache' of undefined

After months of working flawlessly, my discord puppet bridge instance crashed with the following error:
Mar-18 05:06:48.061 [bot-sdk-Appservice] info: Processing ephemeral event of type m.receipt
<IP_ADDRESS> - - [18/Mar/2022:04:06:48 +0000] "PUT /transactions/12351261?access_token=<redacted> HTTP/1.1" 200 2 "-" "Synapse/1.51.0"
/home/discordpuppet/mx-puppet-discord/node_modules/better-discord.js/src/client/actions/MessageCreate.js:11
      const existing = channel.messages.cache.get(data.id);
                                        ^

TypeError: Cannot read property 'cache' of undefined
    at MessageCreateAction.handle (/home/discordpuppet/mx-puppet-discord/node_modules/better-discord.js/src/client/actions/MessageCreate.js:11:41)
    at Object.module.exports [as MESSAGE_CREATE] (/home/discordpuppet/mx-puppet-discord/node_modules/better-discord.js/src/client/websocket/handlers/MESSAGE_CREATE.js:4:32)
    at WebSocketManager.handlePacket (/home/discordpuppet/mx-puppet-discord/node_modules/better-discord.js/src/client/websocket/WebSocketManager.js:391:31)
    at WebSocketShard.onPacket (/home/discordpuppet/mx-puppet-discord/node_modules/better-discord.js/src/client/websocket/WebSocketShard.js:451:22)
    at WebSocketShard.onMessage (/home/discordpuppet/mx-puppet-discord/node_modules/better-discord.js/src/client/websocket/WebSocketShard.js:308:10)
    at WebSocket.onMessage (/home/discordpuppet/mx-puppet-discord/node_modules/ws/lib/event-target.js:132:16)
    at WebSocket.emit (events.js:400:28)
    at Receiver.receiverOnMessage (/home/discordpuppet/mx-puppet-discord/node_modules/ws/lib/websocket.js:970:20)
    at Receiver.emit (events.js:400:28)
    at Receiver.dataMessage (/home/discordpuppet/mx-puppet-discord/node_modules/ws/lib/receiver.js:517:14)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `npm run-script build && node ./build/index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/discordpuppet/.npm/_logs/2022-03-18T04_06_48_717Z-debug.log

same thing happened again

Tracked by https://gitlab.com/mx-puppet/discord/mx-puppet-discord/-/issues/207. That said, sounds like a betterdiscord issue, probably need to look into some mistake during the last upgrade of the discord api library


paired-end reads

Is there any way to keep the separation distance of paired-end reads or is that information lost in graph format?

There is no standard method to do so encoded in the existing schema or command line interface, but I think it would be trivial to encode this as all that is needed is the coordinates (node id and position) of the mapped mate.
An alternative approach that I think is more conceptually simple would be to encode the read pair as a single read with a big gap in the middle. Which is what it effectively is... The problem would be when read pairs map to very distant regions. This is already an issue for BAM/SAM.
Perhaps the solution of recording the coordinates of the other alignment is the simplest one.


Redirect on 401

I'm having a HttpClient Interceptor in place for my normal ajax requests which redirects me to my login page on receiving a 401 status.
But the requests to /userinfo are handled by angular-oauth2-oidc which ignores my interceptor, could we have this as an function of this lib or maybe could it care for interceptors ?
Cheers,
Marvin

We are currently switching to Angular 5 and HttpClient. The next release which lands in a few days will support this.


fix javadoc about lnglevel

drools.dialect.java.compiler.lnglevel is the correct system property name.
https://github.com/tkobayas/drools/blob/master/drools-core/src/main/java/org/drools/core/rule/builder/dialect/asm/ClassLevel.java#L26

Merged into master and 6.3.x. Thanks for the PR!


Make celery log its output

This should actually go to STDOUT, I think.
I plan on cleaning up the docker-compose file at a later stage and sort that all out.

Isn't having the logs going to stderr more useful? If the logs are put in a file, docker logs won't work anymore.

Oh, I wasn't getting logs, so I bumped it up to debug and made it log to a file. I guess I should have just bumped the logging. Let me change the PR quickly.

[Current coverage][cc-pull] is 92.58%

Merging [#104][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #104   diff @@
==========================================
  Files            50         50
  Lines          2764       2764
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2559       2559
  Misses          205        205
  Partials          0          0

Powered by Codecov. Last updated by [a29d06d...a92bc63][cc-compare]
[cc-base-branch]: https://codecov.io/gh/markstory/lint-review/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/markstory/lint-review/compare/a29d06dd47ee8287d8694b17050c1356e5f5510f...a92bc63a790d77d936fe8a142894b5d5537a30f7
[cc-pull]: https://codecov.io/gh/markstory/lint-review/pull/104?src=pr


Add clientRequestId\rTESTING=unit

I couldn't think of a way to really make the uuid generator fixes better, unless I changed it to return the same id every single time (like the current Ruby SDK tests), so I just left it. Hopefully won't come up too often.


token-group: create example program

This PR adds an example program for the SPL Token Group interface.
It demonstrates using the interface to create a program that can manage token collections - such as NFT Collections!
However, this example does not make use of token metadata, to keep the demonstration simple.

Alright, addressed!


add proxify init & fix alert rendering inconsistency

Coverage decreased (-0.02%) to 39.549% when pulling 569df6b83541c4e4564b309b807b7eed5a4d842c on ele828:fix-meeting-module into 2b4bde0b792750ff8a102fb35a9b2e9afb1b1f9d on ringcentral:master.


Modify docs

Coverage remained the same at 85.819% when pulling ad656394f967770a0d6adbc6bfa397b444bc543c on JYL123:modify_user_guide into d4e975979d41f1cb72d0de6a5897de6e4da5d807 on CS2103AUG2017-W11-B1:master.


ContextMenu is displayed in the wrong position

Which package has an issue?
@yamada-ui/react
Package Version
1.5.1
Description
ContextMenu is displayed in the wrong position.
Link to Reproduction
https://yamada-ui.com/components/overlay/context-menu
Steps to Reproduce

Go to ContextMenu document page.
Click on 'Right click here'.

Browser
None
Operating System

[ ] macOS
[ ] Windows
[ ] Linux
[ ] iPadOS
[ ] iOS
[ ] Android

Do you know how to fix the issue?
None
Are you willing to participate in fixing this issue and create a pull request with the fix?
None
Additional Information
No response

@hirotomoyamada hey i can work on this issue if you can assign me

@KekmaTime
Hi, thanks for the comment!
Do you know how to solve this problem?

@KekmaTime
Hi, thanks for the comment!
Do you know how to solve this problem?

yes i think we change the styling property to see exactly what the problem is . I can only confirm it by actually trying it out

@hirotomoyamada

is this how its supposed to be like ?

@KekmaTime
Hi, in the image, the pointer is not shown, so I am not sure if it is the correct behavior.
Perhaps the following code change worked correctly.
export const ContextMenuTrigger = forwardRef<ContextMenuTriggerProps, "div">(
  ({ children, className, ...rest }, ref) => {
    const { styles } = useContextMenu()
    const [position, setPosition] = useState<Position>({ top: 0, left: 0 })

    const css: CSSUIObject = { ...styles.container }

    const onContextMenu = (ev: MouseEvent) => {
-     setPosition({ top: ev.clientY, left: ev.clientX })
+    setPosition({ top: ev.pageY, left: pageX })
    }

    return (
      <>
        <PopoverAnchor>
          <ui.div
            className="ui-context-menu__anchor"
            style={{ position: "absolute", ...position }}
          />
        </PopoverAnchor>

        <PopoverTrigger>
          <ui.div
            ref={ref}
            className={cx("ui-context-menu", className)}
            __css={css}
            {...rest}
            onContextMenu={handlerAll(rest.onContextMenu, onContextMenu)}
          >
            {children}
          </ui.div>
        </PopoverTrigger>
      </>
    )
  },
)

@KekmaTime
I would like to resolve this problem as soon as possible. Can you work on it as soon as possible?

@KekmaTime
Hi, I would like to see a PR issued with that code!

@hirotomoyamada


fix: refactor the codebase for readability and maintainability

Description

The codebase was too complicated to improve upon or add new optimizations.
Using functional logic for report generators.
keeping the old input/output formats since it is not yet time to release a new major version but putting the foundation for changes that are going to be applied.

@KhudaDad414 sonar complains at code smells

@derberg can you take another look please 🙇

/rtm


google analytics plugin missing?

Hi,
I am using angulartics version 1.0.2 and i do not see the angulartics-ga.js plugin inside. There are two cordova plugins - angulartics-ga-cordova.js and angulartics-ga-cordova-google-analytics-plugin.js - is that intentional?
Thanks,

Sorry, I still need to go through all the plugins and make sure they are referring to Angulartics ^1.0.0


test-bot: stop unlinking non-dependencies.

This ends up breaking more than it fixes because then reverse dependencies are missing stuff they need.

I think this is missing some of the original conflict unlinking bits that were removed in https://github.com/Homebrew/homebrew-test-bot/pull/68.

Pretty sure it's there: https://github.com/Homebrew/homebrew-test-bot/pull/68/files#diff-8214fa507ee396ae17e4b9c27cb881a2R591

@MikeMcQuaid you've linked to #68 not this PR.
iMac-TMP:homebrew-test-bot joe$ git diff 3193abf55eb8ffdee5ce158645726c3bf15971fc no-unlink-non-dependencies
diff --git a/cmd/brew-test-bot.rb b/cmd/brew-test-bot.rb
index 2b218c6..9b52930 100755
--- a/cmd/brew-test-bot.rb
+++ b/cmd/brew-test-bot.rb
@@ -523,6 +523,7 @@ module Homebrew
       test "brew", "config"
     end

+
     def formula(formula_name)
       @category = "#{__method__}.#{formula_name}"

@@ -602,8 +603,6 @@ module Homebrew
       installed_non_dependencies = installed - dependencies
       installed_dependencies = installed & dependencies

-      unlink_formulae += installed_non_dependencies if ARGV.include?("--cleanup")
-
       unlink_formulae.uniq.each do |name|
         unlink_formula = Formulary.factory(name)
         next unless unlink_formula.installed?
@@ -724,19 +723,15 @@ module Homebrew
           unless dependent.installed?
             test "brew", "fetch", "--retry", dependent.name
             next if steps.last.failed?
-            conflicts = dependent.conflicts.map { |c| Formulary.factory(c.name) }.select(&:installed?)
-            dependent.recursive_dependencies.each do |dependency|
-              conflicts += dependency.to_formula.conflicts.map { |c| Formulary.factory(c.name) }.select(&:installed?)
-            end
-            conflicts.each do |conflict|
-              test "brew", "unlink", conflict.name
-            end
             unless ARGV.include?("--fast")
               run_as_not_developer { test "brew", "install", dependent.name }
               next if steps.last.failed?
             end
           end
           next unless dependent.installed?
+          if !dependent.keg_only? && !dependent.linked_keg.exist?
+            test "brew", "link", dependent.name
+          end
           test "brew", "linkage", "--test", dependent.name
           if testable_dependents.include? dependent
             test "brew", "test", "--verbose", dependent.name

If I cherry-pick the unrelated commits since 0e697903637c07d9267e0f8d84f74dce90d5b3df the diff is
diff --git a/cmd/brew-test-bot.rb b/cmd/brew-test-bot.rb
index 17882c0..9b52930 100755
--- a/cmd/brew-test-bot.rb
+++ b/cmd/brew-test-bot.rb
@@ -523,6 +523,7 @@ module Homebrew
       test "brew", "config"
     end

+
     def formula(formula_name)
       @category = "#{__method__}.#{formula_name}"

@@ -595,17 +596,26 @@ module Homebrew
       formula.recursive_dependencies.each do |dependency|
         conflicts += dependency.to_formula.conflicts
       end
-
-      conflicts.each do |conflict|
-        confict_formula = Formulary.factory(conflict.name)
-
-        if confict_formula.installed? && confict_formula.linked_keg.exist?
-          test "brew", "unlink", "--force", conflict.name
-        end
-      end
+      unlink_formulae = conflicts.map(&:name)

       installed = Utils.popen_read("brew", "list").split("\n")
       dependencies = Utils.popen_read("brew", "deps", "--include-build", formula_name).split("\n")
+      installed_non_dependencies = installed - dependencies
+      installed_dependencies = installed & dependencies
+
+      unlink_formulae.uniq.each do |name|
+        unlink_formula = Formulary.factory(name)
+        next unless unlink_formula.installed?
+        next unless unlink_formula.linked_keg.exist?
+        test "brew", "unlink", "--force", name
+      end
+
+      installed_dependencies.each do |name|
+        link_formula = Formulary.factory(name)
+        next if link_formula.keg_only?
+        next if link_formula.linked_keg.exist?
+        test "brew", "link", name
+      end

       dependencies -= installed
       unchanged_dependencies = dependencies - @formulae
@@ -713,13 +723,6 @@ module Homebrew
           unless dependent.installed?
             test "brew", "fetch", "--retry", dependent.name
             next if steps.last.failed?
-            conflicts = dependent.conflicts.map { |c| Formulary.factory(c.name) }.select(&:installed?)
-            dependent.recursive_dependencies.each do |dependency|
-              conflicts += dependency.to_formula.conflicts.map { |c| Formulary.factory(c.name) }.select(&:installed?)
-            end
-            conflicts.each do |conflict|
-              test "brew", "unlink", conflict.name
-            end
             unless ARGV.include?("--fast")
               run_as_not_developer { test "brew", "install", dependent.name }
               next if steps.last.failed?

So I guess those are equivalent?

Still looks to me like it's missing the bits at @@ -713,13 +723,6 @@ that unlink conflicts of the reverse dependencies. Also, installed_non_dependencies appears to be unused.
The new part that makes sure installed dependencies are linked looks like it's good to keep as you did.


improves mac gnu variant detection

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


fix(plugin-vue): hmr got error by transformSFC to inject code (fix #301)

Description
FIXED: #301
Some vite plugins like unocss:vue-scoped needs to rewrite hmrContext.read to inject their special code into SFC when hmr.
vite-plugin-vue uses fs.readFileSync to get the raw code, but the raw code doesn't have injected code by other plugins.
This PR allows vite-plugin-vue to get transformCode api from other plugins, and then replace fs.readFileSync with readCode function.

Additional context

hmr error reproduction: https://stackblitz.com/edit/vitejs-vite-28qyca?file=src%2FApp.vue

Wait to start and change class text-blue to text-red

playground for this PR: https://stackblitz.com/edit/vitejs-vite-6tuitn?file=src%2FApp.vue

u can run it locally

What is the purpose of this pull request?

[X] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

@sxzz If there is no problem with PR at the moment, how long will it take for it to be merged?


almost passes by default

Not sure if it's a bug but by default without changing a single piece of code it automatically passed 6 of the 7 checkpoints on this exercise as soon as the page loaded.
Seemed really strange when I got to this challenge (Introducing Else If Statements), 6 of the 7 checkmarks/circles were already green.
Here's an imgur link to a screenshot:
http://imgur.com/TfkpVLF
Hope I'm not looking at this the wrong way and wasting anyone's time. I know you guys are really busy.
I'm loving FCC and just want to help if I can.
Challenge Introducing Else If Statements has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

function testElseIf(val) {
  if (val > 10) {
    return "Greater than 10";
  }

  if (val < 5) {
    return "Smaller than 5";
  }

  return "Between 5 and 10";
}

// Change this value to test
testElseIf(7);

well Mr. Bot I guess it isn't really an issue or a big deal because you still have to do the exercise so I guess I'll close this.
A lot of the exercise/challenges have a couple checks marked green but this was the first time I saw almost all of them green by default so I thought something was wrong.

@WRyan78 don't mind the bot. I think it's a valid question that is ultimately brought about by the function running on page load. I think many are checked because multiple if statements work almost like else if, but it's mostly just the ease of the challenge and the autorun that results in this outcome.

More to the point, the function works correctly right away because it is written correctly, and the point of the challenge is to write it correctly in a different way. So it's only natural that the tests of function correctness should pass with the original code, and users can tell that they have done something wrong if these tests no longer pass after they have made some changes 😄

that's a good point, hahaha. "Now I broke it!"


How to export to an OpenTelemetry Collector?

I have several Go microservices that are using uptrace-go for sending metrics and traces to uptrace.
Following https://uptrace.dev/opentelemetry/collector.html I would like to configure these services to send to a local OpenTelemetry Collector acting as a middle-man that will forward to uptrace as explained in https://uptrace.dev/opentelemetry/collector.html#exporting-data-to-uptrace
How should I set up my UPTRACE_DSN environment variable to do so?
Thanks for your support.

Hello @matthyx,
Assuming you have Otel collector listening on localhost:4317, you can try UPTRACE_DSN=http://localhost:14317 (replace http with https if you have TLS).
Let me know if that works and I will update the docs.

Hi @vmihailenco thanks for the idea... I did try and got this error message:
uptrace: 2023/01/20 13:01:24 uptrace.go:38: invalid Uptrace DSN: DSN="http://localhost:4317" does not have a project id (Uptrace is disabled)

I see. Please try UPTRACE_DSN=http://token@localhost:4317/1 with the dummy project id.

Yes, it definitely works for the spans, however not the metrics and I get such error messages:
2023/01/20 13:13:13 rpc error: code = Unimplemented desc = unknown service opentelemetry.proto.collector.metrics.v1.MetricsService

I tried the metrics in this repo:
cd example/metrics
UPTRACE_DSN=http://localhost:4317 make

Seems to be working fine. How can I reproduce the issue?

As a guess, you probably did not enable metrics pipeline in the Otel collector:
service:
  pipelines:
    metrics:
      receivers: [otlp]
      processors: [batch, resourcedetection]
      exporters: [otlp]

Indeed it works, thanks a lot.
I did copy and paste the config from here: https://uptrace.dev/opentelemetry/collector.html#configuration
Maybe you could add the metrics part there?

I think with good docs this issue can be closed.
Regards.

That's an overlook, thanks! I will update the docs.


Un-deprecate Sealed classes for enums

It looks like sealed classes may not be ideal to use in Swift (exactly how needs to be researched more! See this user feedback from the Slack channel).
If that's confirmed, it would makes sense to at least continue supporting generating enums as a "legit" option (not deprecated), and maybe even go back to set it by default (and make sealed classes opt-in).
Bonus: it may be nice to add a simple boolean flag in addition to the current list of regex (as probably most users would want to activate this globally on their project) - related to #3453.

I have 0 experience with Swift, and to shed some light into this I tried to import a toy MPP library into a Swift project and see operop in action.
Kotlin library:
// Enum
enum class ColorEnum {
    RED,
    GREEN,
    BLUE,
}

// Sealed interface
sealed interface DrinkSealedInterface {
    val name: String
}
object Coffee : DrinkSealedInterface {
    override val name: String = "Coffee"
}
object Tea : DrinkSealedInterface {
    override val name: String = "Tea"
}
object Soda : DrinkSealedInterface {
    override val name: String = "Soda"
}

data class OtherDrink(override val name: String) : DrinkSealedInterface

// Sealed class
sealed class BrandSealedClass(
    val name: String
)
object Sony : BrandSealedClass("Sony")
object Samsung : BrandSealedClass("Samsung")
object Apple : BrandSealedClass("Apple")
class OtherBrand(name: String) : BrandSealedClass(name)

// Expose an object with each
object SomeObject {
    val color: ColorEnum = ColorEnum.RED
    val drink: Coffee = Coffee
    val brand: BrandSealedClass = Sony
}

Usage in Swift:
// Enum
switch (SomeObject.shared.color) {
case .red:
    print("Red")
case .green:
    print("Green")
case .blue:
    print("Blue")
default:
    print("other")
}

// Sealed interface
switch (SomeObject.shared.drink) {
case is Coffee:
    print("Coffee")
case is Tea:
    print("Tea")
case is Soda:
    print("Soda")
case is OtherDrink:
    print(SomeObject.shared.drink.name)
}

// Sealed class
switch (SomeObject.shared.brand) {
case is Sony:
    print("Sony")
case is Samsung:
    print("Samsung")
case is Apple:
    print("Apple")
case is OtherBrand:
    print(SomeObject.shared.brand.name)
default:
    print(SomeObject.shared.brand.name)
}

Remarks:

I do not know why the default case is needed on the enum, even when having a case for all possible values
Switch on a sealed interface seems nice to use: no default case is necessary
However default is needed on the sealed class switch (not sure why - the difference I can see is that DrinkSealedInterface is exposed as a @protocol whereas BrandSealedClass is exposed as @interface

As a reminder, Apollo Android generates sealed classes (not sealed interfaces) for enums.
Some interesting read here even though enums or sealed are not mentioned.

The generated header file, for reference.

As most users would probably expect generating enums, and not often need the rawValue provided by sealed classes, let's go back to default to enum generation.
Also let's dig a bit more about usage in Swift with a sample project framework using Apollo.

Playing around a bit more with using an MPP lib + Apollo.
schema.graphqls:
enum Episode {
    NEW_HOPE
    EMPIRE
}

# ...

Exposing this function in the library:
suspend fun queryHero(episode: Episode): ApolloResponse<HeroForEpisodeQuery.Data> {
    return ApolloClient.Builder()
        .serverUrl("https://example.com")
        .build()
        .query(HeroForEpisodeQuery(episode))
        .execute()
}

can be used this way from Swift:
-- generating sealed classes:
    SomeObjectKt.queryHero(episode: Episode.NEW_HOPE.shared) { result, error in
        print(result?.data?.hero.firstName)
    }

// OR

    SomeObjectKt.queryHero(episode: Episode.NEW_HOPE()) { result, error in
        print(result?.data?.hero.firstName)
    }

-- generting enums:
    SomeObjectKt.queryHero(episode: Episode.theNewHope) { result, error in
        print(result?.data?.hero.firstName)
    }

Notes:

Sealed classes: a bit awkward to have to use .shared or instantiate the class
Enums: the values are converted to lower case, which it looks like is the convention in Objc/Swift. Funny about the "the" which is a special case for values starting with "new".


Update lists.ts with link for Cryptoodles Loot Bag

Cryptoodles Loot Bag
Etherscan link: https://etherscan.io/address/0x2a16107ea0d28ae822168c8bb3ef5460b1924a78#code
Website: https://cryptoodles.com
Twitter: https://twitter.com/cryptoodles
Discord: https://discord.gg/Cn6czVtnmf
OpenSea: https://opensea.io/collection/toodle-loot-bag

Apologies for the back to back PR's. I think it is a better website experience if the link went to the derivative project website instead of the contract. Let me know if any issues here

Looks good! Thanks for your contribution.


SpringPrototypeAggregateFactory not using for first creation command

Basic information

Axon Framework version: 4.6.7
JDK version:  17
Complete executable reproducer if available (e.g. GitHub Repo):

Steps to reproduce
Using Spring Boot configuaration.
Fire command like this
commandGateway.sendAndWait(
                    createCommand,
                    MetaData.with(TRACE_ID, String.valueOf(billingEvent.getEventId())));

Than if i set brakepoint in Aggregate constructor i will have stack trace, like this
With no invocation any methods of SpringPrototypeAggregateFactory.
And because it is no Spring managed bean i can't to use Spring AOP.
	at com.microsoft.billing.cp.feature.quality.aggregate.QualityEvaluationAggregate.<init>(QualityEvaluationAggregate.java:88) 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) 	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) 	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) 	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480) 	at org.axonframework.messaging.annotation.AnnotatedMessageHandlingMember.handle(AnnotatedMessageHandlingMember.java:155) 	at org.axonframework.messaging.annotation.WrappedMessageHandlingMember.handle(WrappedMessageHandlingMember.java:64) 	at org.axonframework.messaging.annotation.WrappedMessageHandlingMember.handle(WrappedMessageHandlingMember.java:64) 	at org.axonframework.tracing.TracingHandlerEnhancerDefinition$1.lambda$handle$1(TracingHandlerEnhancerDefinition.java:84) 	at org.axonframework.tracing.Span.runCallable(Span.java:132) 	at org.axonframework.tracing.TracingHandlerEnhancerDefinition$1.handle(TracingHandlerEnhancerDefinition.java:84) 	at org.axonframework.modelling.command.AggregateAnnotationCommandHandler$AggregateConstructorCommandHandler.lambda$handle$0(AggregateAnnotationCommandHandler.java:437) 	at org.axonframework.messaging.Scope.executeWithResult(Scope.java:111) 	at org.axonframework.modelling.command.inspection.AnnotatedAggregate.registerRoot(AnnotatedAggregate.java:283) 	at org.axonframework.eventsourcing.EventSourcedAggregate.initialize(EventSourcedAggregate.java:120) 	at org.axonframework.eventsourcing.EventSourcingRepository.doCreateNewForLock(EventSourcingRepository.java:193) 	at org.axonframework.eventsourcing.EventSourcingRepository.doCreateNewForLock(EventSourcingRepository.java:55) 	at org.axonframework.modelling.command.LockingRepository.doCreateNew(LockingRepository.java:91) 	at org.axonframework.modelling.command.LockingRepository.doCreateNew(LockingRepository.java:60) 	at org.axonframework.modelling.command.AbstractRepository.newInstance(AbstractRepository.java:105) 	at org.axonframework.modelling.command.AbstractRepository.newInstance(AbstractRepository.java:86) 	at org.axonframework.modelling.command.AggregateAnnotationCommandHandler$AggregateConstructorCommandHandler.handle(AggregateAnnotationCommandHandler.java:437) 	at org.axonframework.modelling.command.AggregateAnnotationCommandHandler$AggregateConstructorCommandHandler.handle(AggregateAnnotationCommandHandler.java:426) 	at org.axonframework.messaging.DefaultInterceptorChain.proceed(DefaultInterceptorChain.java:57) 	at org.axonframework.messaging.interceptors.CorrelationDataInterceptor.handle(CorrelationDataInterceptor.java:67) 	at org.axonframework.messaging.DefaultInterceptorChain.proceed(DefaultInterceptorChain.java:55) 	at org.axonframework.messaging.unitofwork.DefaultUnitOfWork.executeWithResult(DefaultUnitOfWork.java:77) 	at org.axonframework.commandhandling.SimpleCommandBus.lambda$handle$4(SimpleCommandBus.java:201) 	at org.axonframework.tracing.Span.runSupplier(Span.java:163) 	at org.axonframework.commandhandling.SimpleCommandBus.handle(SimpleCommandBus.java:192) 	at org.axonframework.commandhandling.SimpleCommandBus.doDispatch(SimpleCommandBus.java:165) 	at org.axonframework.commandhandling.SimpleCommandBus.lambda$dispatch$2(SimpleCommandBus.java:131) 	at org.axonframework.tracing.Span.run(Span.java:101) 	at org.axonframework.commandhandling.SimpleCommandBus.dispatch(SimpleCommandBus.java:125) 	at org.axonframework.commandhandling.gateway.AbstractCommandGateway.send(AbstractCommandGateway.java:76) 	at org.axonframework.commandhandling.gateway.DefaultCommandGateway.send(DefaultCommandGateway.java:83) 	at org.axonframework.commandhandling.gateway.DefaultCommandGateway.sendAndWait(DefaultCommandGateway.java:100) 	at org.axonframework.commandhandling.gateway.CommandGateway.sendAndWait(CommandGateway.java:104) 	at com.microsoft.billing.QualityFormProcess.fireCreateQualityEvaluationCommand(QualityFormProcess.java:109)
Expected behaviour

Method
org.axonframework.spring.eventsourcing.SpringPrototypeAggregateFactory#createAggregateRoot
should be invoked.
Actual behaviour
But not invoked.

Thanks for filing your concern with us, @pe4enko.
However, I am afraid I need a little more information.
I assume the stack trace contains some form of an error message at the beginning too.
Just the trace may lead us there, but it would be helpful if you could provide everything you have on the subject.
Secondly, the predicament strikes me as odd. If the SpringPrototypeAggregateFactory fails for Axon Framework 4.6.7 users, I would expect more issues like this to have popped up on GitHub or the forum, because the large majority uses Spring in combination with Axon Framework.
As such, it would be extremely helpful if you could provide us with a minimal reproducible, as described in the bug issue template too.
Through such a sample project, it becomes easier to pinpoint the issue ASAP.
Due to the above two points, I've assigned you to this issue and added the information required label.

Hi. You can use Gift Card Demo without any modification to reproduce problem.
There is no any exception in SpringPrototypeAggregateFactory because it is not invoked.
I got stacktrace simple add line like this new Throwable().printStackTrace();
    @CommandHandler
    public GiftCard(IssueCardCommand command) {
        new Throwable().printStackTrace();

        if (command.amount() <= 0) {
            throw new IllegalArgumentException("amount <= 0");
        }
        apply(new CardIssuedEvent(command.id(), command.amount()));
    }

As you can see there is no any invocation of SpringPrototypeAggregateFactory. But constructor of Aggregate is invoked.
java.lang.Throwable 	at io.axoniq.demo.giftcard.command.GiftCard.<init>(GiftCard.java:29) 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) 	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) 	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) 	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) 	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480) 	at org.axonframework.messaging.annotation.AnnotatedMessageHandlingMember.handle(AnnotatedMessageHandlingMember.java:155) 	at org.axonframework.messaging.annotation.WrappedMessageHandlingMember.handle(WrappedMessageHandlingMember.java:64) 	at org.axonframework.messaging.annotation.WrappedMessageHandlingMember.handle(WrappedMessageHandlingMember.java:64) 	at org.axonframework.tracing.TracingHandlerEnhancerDefinition$1.lambda$handle$1(TracingHandlerEnhancerDefinition.java:84) 	at org.axonframework.tracing.Span.runCallable(Span.java:132) 	at org.axonframework.tracing.TracingHandlerEnhancerDefinition$1.handle(TracingHandlerEnhancerDefinition.java:84) 	at org.axonframework.modelling.command.AggregateAnnotationCommandHandler$AggregateConstructorCommandHandler.lambda$handle$0(AggregateAnnotationCommandHandler.java:437) 	at org.axonframework.messaging.Scope.executeWithResult(Scope.java:111) 	at org.axonframework.modelling.command.inspection.AnnotatedAggregate.registerRoot(AnnotatedAggregate.java:283) 	at org.axonframework.eventsourcing.EventSourcedAggregate.initialize(EventSourcedAggregate.java:120) 	at org.axonframework.eventsourcing.EventSourcingRepository.doCreateNewForLock(EventSourcingRepository.java:193) 	at org.axonframework.eventsourcing.EventSourcingRepository.doCreateNewForLock(EventSourcingRepository.java:55) 	at org.axonframework.modelling.command.LockingRepository.doCreateNew(LockingRepository.java:91) 	at org.axonframework.modelling.command.LockingRepository.doCreateNew(LockingRepository.java:60) 	at org.axonframework.modelling.command.AbstractRepository.newInstance(AbstractRepository.java:109) 	at org.axonframework.modelling.command.AbstractRepository.newInstance(AbstractRepository.java:90) 	at org.axonframework.modelling.command.AggregateAnnotationCommandHandler$AggregateConstructorCommandHandler.handle(AggregateAnnotationCommandHandler.java:437) 	at org.axonframework.modelling.command.AggregateAnnotationCommandHandler$AggregateConstructorCommandHandler.handle(AggregateAnnotationCommandHandler.java:426) 	at org.axonframework.messaging.DefaultInterceptorChain.proceed(DefaultInterceptorChain.java:57) 	at org.axonframework.messaging.interceptors.LoggingInterceptor.handle(LoggingInterceptor.java:85) 	at org.axonframework.messaging.DefaultInterceptorChain.proceed(DefaultInterceptorChain.java:55) 	at org.axonframework.messaging.interceptors.CorrelationDataInterceptor.handle(CorrelationDataInterceptor.java:67) 	at org.axonframework.messaging.DefaultInterceptorChain.proceed(DefaultInterceptorChain.java:55) 	at org.axonframework.messaging.unitofwork.DefaultUnitOfWork.executeWithResult(DefaultUnitOfWork.java:77) 	at org.axonframework.commandhandling.SimpleCommandBus.lambda$handle$4(SimpleCommandBus.java:201) 	at org.axonframework.tracing.Span.runSupplier(Span.java:163) 	at org.axonframework.commandhandling.SimpleCommandBus.handle(SimpleCommandBus.java:192) 	at org.axonframework.commandhandling.SimpleCommandBus.doDispatch(SimpleCommandBus.java:165) 	at org.axonframework.commandhandling.SimpleCommandBus.lambda$dispatch$2(SimpleCommandBus.java:131) 	at org.axonframework.tracing.Span.run(Span.java:101) 	at org.axonframework.commandhandling.SimpleCommandBus.dispatch(SimpleCommandBus.java:125) 	at org.axonframework.axonserver.connector.command.AxonServerCommandBus$CommandProcessingTask.lambda$run$2(AxonServerCommandBus.java:308) 	at org.axonframework.tracing.Span.run(Span.java:101) 	at org.axonframework.axonserver.connector.command.AxonServerCommandBus$CommandProcessingTask.run(AxonServerCommandBus.java:306) 	at org.axonframework.axonserver.connector.PriorityRunnable.run(PriorityRunnable.java:58) 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) 	at java.base/java.lang.Thread.run(Thread.java:833)
Log of application startup and create GiftCard aggregate by sending IssueCardCommand
`Connected to the target VM, address: '<IP_ADDRESS>:53760', transport: 'socket'
.   ____          _            __ _ _
/\ / ' __ _ () __  __ _ \ \ \
( ( )__ | '_ | '| | ' / ` | \ \ \
\/  )| |)| | | | | || (| |  ) ) ) )
'  || .__|| ||| |_, | / / / /
=========||==============|/=////
:: Spring Boot ::                (v3.0.4)
2023-05-08T17:11:07.064+03:00  INFO 51964 --- [           main] io.axoniq.demo.giftcard.GiftCardApp      : Starting GiftCardApp using Java 17.0.5 with PID 51964 (/Users/ma.martynov/work/git/axon/giftcard-demo/target/classes started by ma.martynov in /Users/ma.martynov/work/git/axon/giftcard-demo)
2023-05-08T17:11:07.065+03:00 DEBUG 51964 --- [           main] io.axoniq.demo.giftcard.GiftCardApp      : Running with Spring Boot v3.0.4, Spring v6.0.6
2023-05-08T17:11:07.066+03:00  INFO 51964 --- [           main] io.axoniq.demo.giftcard.GiftCardApp      : The following 3 profiles are active: "command", "query", "gui"
2023-05-08T17:11:07.148+03:00  WARN 51964 --- [           main] o.s.c.annotation.AnnotationTypeMapping   : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the following attributes in @org.axonframework.spring.stereotype.Aggregate with appropriate @AliasFor declarations: [type]
2023-05-08T17:11:07.150+03:00  WARN 51964 --- [           main] o.s.c.annotation.AnnotationTypeMapping   : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the following attributes in @org.axonframework.commandhandling.CommandHandler with appropriate @AliasFor declarations: [payloadType]
2023-05-08T17:11:07.151+03:00  WARN 51964 --- [           main] o.s.c.annotation.AnnotationTypeMapping   : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the following attributes in @org.axonframework.eventsourcing.EventSourcingHandler with appropriate @AliasFor declarations: [payloadType]
2023-05-08T17:11:07.151+03:00  WARN 51964 --- [           main] o.s.c.annotation.AnnotationTypeMapping   : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the following attributes in @org.axonframework.eventsourcing.EventSourcingHandler with appropriate @AliasFor declarations: [payloadType]
2023-05-08T17:11:07.166+03:00  WARN 51964 --- [           main] o.s.c.annotation.AnnotationTypeMapping   : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the following attributes in @org.axonframework.eventhandling.EventHandler with appropriate @AliasFor declarations: [payloadType]
2023-05-08T17:11:07.738+03:00  WARN 51964 --- [           main] ocalVariableTableParameterNameDiscoverer : Using deprecated '-debug' fallback for parameter name resolution. Compile the affected code with '-parameters' instead or avoid its introspection: org.axonframework.spring.eventsourcing.SpringPrototypeAggregateFactory
2023-05-08T17:11:08.134+03:00  INFO 51964 --- [           main] o.s.b.a.e.web.EndpointLinksResolver      : Exposing 13 endpoint(s) beneath base path '/actuator'
2023-05-08T17:11:11.379+03:00  INFO 51964 --- [           main] o.s.b.web.embedded.netty.NettyWebServer  : Netty started on port 8080
2023-05-08T17:11:11.474+03:00  INFO 51964 --- [           main] i.a.a.c.impl.AxonServerManagedChannel    : Requesting connection details from localhost:8124
2023-05-08T17:11:11.588+03:00  INFO 51964 --- [           main] i.a.a.c.impl.AxonServerManagedChannel    : Successfully connected to localhost:8124
2023-05-08T17:11:11.592+03:00  INFO 51964 --- [           main] i.a.a.connector.impl.ControlChannelImpl  : Connected instruction stream for context 'default'. Sending client identification
2023-05-08T17:11:11.597+03:00  INFO 51964 --- [           main] i.a.a.c.command.impl.CommandChannelImpl  : CommandChannel for context 'default' connected, 0 command handlers registered
2023-05-08T17:11:11.598+03:00  INFO 51964 --- [           main] i.a.a.c.command.impl.CommandChannelImpl  : Registered handler for command 'io.axoniq.demo.giftcard.api.RedeemCardCommand' in context 'default'
2023-05-08T17:11:11.600+03:00  INFO 51964 --- [           main] i.a.a.c.command.impl.CommandChannelImpl  : Registered handler for command 'io.axoniq.demo.giftcard.api.IssueCardCommand' in context 'default'
2023-05-08T17:11:11.600+03:00  INFO 51964 --- [           main] i.a.a.c.command.impl.CommandChannelImpl  : Registered handler for command 'io.axoniq.demo.giftcard.api.CancelCardCommand' in context 'default'
2023-05-08T17:11:11.613+03:00  INFO 51964 --- [           main] i.a.a.c.query.impl.QueryChannelImpl      : QueryChannel for context 'default' connected, 0 registrations resubscribed
2023-05-08T17:11:11.617+03:00  INFO 51964 --- [           main] i.a.a.c.query.impl.QueryChannelImpl      : Registered handler for query 'io.axoniq.demo.giftcard.api.CountCardSummariesQuery : io.axoniq.demo.giftcard.api.CountCardSummariesResponse' in context 'default'
2023-05-08T17:11:11.618+03:00  INFO 51964 --- [           main] i.a.a.c.query.impl.QueryChannelImpl      : Registered handler for query 'io.axoniq.demo.giftcard.api.FetchCardSummariesQuery : java.util.List<io.axoniq.demo.giftcard.api.CardSummary>' in context 'default'
2023-05-08T17:11:11.636+03:00  INFO 51964 --- [           main] io.axoniq.demo.giftcard.GiftCardApp      : Started GiftCardApp in 4.749 seconds (process running for 5.132)
2023-05-08T17:11:11.647+03:00  INFO 51964 --- [card-summary]-0] o.a.e.TrackingEventProcessor             : Worker assigned to segment Segment[0/1] for processing
2023-05-08T17:11:11.650+03:00  INFO 51964 --- [card-summary]-0] o.a.e.TrackingEventProcessor             : Dispatching new tracking segment worker: TrackingSegmentWorker{processor=card-summary, segment=Segment[0/1]}
2023-05-08T17:11:11.650+03:00  INFO 51964 --- [card-summary]-0] o.a.e.TrackingEventProcessor             : Worker assigned to segment Segment[1/1] for processing
2023-05-08T17:11:11.650+03:00  INFO 51964 --- [card-summary]-0] o.a.e.TrackingEventProcessor             : Using current Thread for last segment worker: TrackingSegmentWorker{processor=card-summary, segment=Segment[1/1]}
2023-05-08T17:11:11.650+03:00  INFO 51964 --- [card-summary]-1] o.a.e.TrackingEventProcessor             : Fetched token: null for segment: Segment[0/1]
2023-05-08T17:11:11.650+03:00  INFO 51964 --- [card-summary]-0] o.a.e.TrackingEventProcessor             : Fetched token: null for segment: Segment[1/1]
2023-05-08T17:11:28.631+03:00  INFO 51964 --- [ctor-http-nio-2] o.a.m.interceptors.LoggingInterceptor    : Dispatched messages: [IssueCardCommand]
2023-05-08T17:11:28.672+03:00  INFO 51964 --- [mandProcessor-0] o.a.m.interceptors.LoggingInterceptor    : Incoming message: [IssueCardCommand]`

What is it you're actually expecting from the Framework, @pe4enko?
There may just be some misconception, either from my end given your issue description or from you, based on what you expect.
Perhaps explaining what the AggregateFactory is for will help.
If we look at the interface, you can read that the AggregateFactory is used to initialize aggregates with an event stream.
Thus, the framework uses the AggregateFactory for initialization of an Aggregate if there already is an event stream present.
If we take a look at your title, you point out that the SpringPrototypeAggregateFactory isn't used for the creational command.
Knowing the definition of the AggregateFactory, it is actually straightforward that it is not invoked for the first command.
As for the first command, you're faced with a non-existent event stream.
Hence, there is no event stream present to initialize an aggregate through the AggregateFactory.
Now, after that, I am curious whether it clarifies the situation a little, @pe4enko.
But regardless, I am still curious about what you are expecting from the Framework to occur.
So, if you could fill us in on that, that would be great!

Thank you for your explanation.
Perhaps I misunderstood what is written in the reference guid.

I have a fairly simple task.
I need to do common logic when creating the aggregate for the first time. I want to do common logging when first creating all types of aggregates. To do this, I can make a marker interface in which there will be one method for getting the name of the human-readable name of the aggregate, not just the name of the class. This interface will be implemented by all aggregates in the application. (I did not find any way to specify a name in the @Aggregate annotation, so I use an interface). Next, I wanted to use Spring AOP to track the call to the aggregate constructor. And when making such a call, do something like
log.info("Aggregate name {}, invoked!!!, aggregateInterface.getAggregateName()). As you may know, in order for me to use Spring AOP to track constructor calls, the class instance I create must be a Spring-managed bean. But this is not the case in the current implementation, and the aggregate is not a Spring prototype bean.
As I understand from your explanation, in some cases the aggregate will still be created using Spring. And it seems to me that it's a little strange that in one case the aggregate being created is a Spring managed bean, and in the other it is not. It seems to me that if Spring is used, then all aggregates should always be created through Spring.
Once again, thanks for the clarification.

Ah, that's indeed a misser in the Reference Guide...
I'll see to it so that it does not put people on the wrong track anymore.
So, thanks for sharing this!

As I understand from your explanation, in some cases the aggregate will still be created using Spring.
And it seems to me that it's a little strange that in one case the aggregate being created is a Spring managed bean, and in the other it is not.
It seems to me that if Spring is used, then all aggregates should always be created through Spring.

Although you may find it odd or not, it is what it is, sadly enough.
The AggregateFactory is an interface I simply cannot adjust or remove at this stage, as it would constitute a breaking change to grand to think about.
Please note that Axon Framework is a Java framework first, with Spring support as an add-on.
It integrates very deeply with Spring, but regardless does a lot of things its own way.
The SpringPrototypeAggregateFactory was constructed in Axon Framework version 1.2, when bean wiring directly into the class was the only way.
However, right now you can wire any bean directly into your Message Handling methods (internally resolved by a ParameterResolver).

However, all that may explain where the Framework is at right now, it does not help with the logging problem you're trying to solve.
If I would be honest with you, I think Axon Framework does not fully support Spring AOP as you would expect it.
However, you can achieve something similar for message handling methods with Axon Framework's (with or with Spring, actually) HandlerEnhancerDefinition.
A HandlerEnhancerDefinition can attach logic to your message handling methods, like the creational command handler, to perform additional logging.
Just for ease of explanation, here's the interface:
public interface HandlerEnhancerDefinition {

    <T> MessageHandlingMember<T> wrapHandler(@Nonnull MessageHandlingMember<T> original);
}

The intent of an enhancer is to wrap the given MessageHandlingMember if you want to attach behavior.
So, you are able to return a custom MessageHandlingMember that logs if it is of a certain format.
An approach for this that comes to mind would be a three-fold of classes:

Your own annotation class. Something like LoggingCommandHandler,
A HandlerEnhancerDefinition, that checks whether the MessageHandlingMember contains the custom annotation, and
A WrappedMessageHandlingMember instance that logs on the MessageHandlingMember#handle method.

As we've come to the conclusion we have not hit an issue with the Framework but more a misser in the Reference Guide, I will close this issue.
Feel free to keep commenting here, though.


Spring MVC integration example

Hi,
I was wondering if you could provide an integration example without Spring Boot. It would be very useful for new users. Until now I could not get it to work.
Karens

Hi,
how do you do End2End-Tests in your project?
Robert

I am using PowerMock 1.5.4.
Until now I only added @RunWith(PowerMockRunner.class)

Swagger2Markup requires a running application, which means you must deploy your Spring application in a servlet container like Tomcat or Jetty.
Using Spring Boot it's easy to test your application. See my demo https://github.com/RobWin/spring-swagger2markup-demo.
If you use only the Spring Framework and Gradle, you could use https://github.com/akhikhl/gretty.
If you use maven, you could use http://arquillian.org/ and https://github.com/arquillian/arquillian-showcase/tree/master/spring

I am using org.springframework.web.servlet.DispatcherServlet as server class in my web.xml  deployed on jboss server. This is already a running application, right?
I also use Maven.

No. It's not a running application, if you only use @RunWith(PowerMockRunner.class).
As far as I know PowerMockRunner does not start the JBoss server.
If you use Spring JavaConfig, then have a look at https://github.com/arquillian/arquillian-showcase/tree/master/spring/spring-javaconfig/src/test/java/com/acme/spring/javaconfig
The Deployments class is important and in your test classs you must use:
@RunWith(Arquillian.class)
@SpringAnnotationConfiguration(classes = StockConfig.class)

Did it help you?

I experimented yesterday with the setup, however I did not get it to work, due to old spring dependencies such com.acme.*. I think I will let it rest for a while because I do not feel comfortable to include arquillian in to my application.
Thanks a lot for your help though

If you have a demo on Github I can have a look at it.

No need to do so, it is not on github. Thanks for the offered help.
I might consider trying the swagger codegen library in the future.


chore: move null handling to CovSource constructor

This implements 2-ii in https://github.com/istanbuljs/v8-to-istanbul/pull/168#issuecomment-968693185 to fix the coverage failure, that probably @bcoe worries about. -)

@PaperStrike this looks good to me, @bvanjoi if you go ahead and land this, I can land the parent PR.


Update to ASP.Net Core 2.1 based.

Update the Project to be based on ASP.Net Core 2.1.X Templates

As in re-evaluate all the samples? Is there something specific you noticed that needs to be addressed?

I had seen a number of issues in the Program.cs and Startup.cs looks as if they have been cleaned up.
The only issue can find now is https://github.com/SteeltoeOSS/Samples/blob/dev/Configuration/src/AspDotNetCore/SimpleCloudFoundry/Startup.cs#L45
based on asp.net 2.1 this is a duplicate logging setup.


New package: MullerPlot v1.0.0-DEV

Registering package: MullerPlot
Repository: https://github.com/natevmp/MullerPlot.jl
Created by: @natevmp
Version: v1.0.0-DEV
Commit: eda5764e0c10dff9aaf277253f754b736f8bd459
Git reference: HEAD

Closing in favor of https://github.com/JuliaRegistries/General/pull/111602


4.0.0

Codecov Report

Merging #25 into master will increase coverage by 0.19%.
The diff coverage is 72.36%.

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   77.73%   77.93%   +0.19%
==========================================
  Files          13       13
  Lines        1168     1160       -8
==========================================
- Hits          908      904       -4
+ Misses        260      256       -4

Impacted Files
Coverage Δ

ASPVideoPlayer/Classes/Math.swift
100% <ø> (ø)
:arrow_up:

ASPVideoPlayer/Classes/AnimationForwarder.swift
100% <ø> (ø)
:arrow_up:

ASPVideoPlayer/Classes/Loader.swift
92% <ø> (-0.11%)
:arrow_down:

ASPVideoPlayer/Classes/ResizeButton.swift
71.21% <0%> (+7.57%)
:arrow_up:

ASPVideoPlayer/Classes/ASPVideoPlayerView.swift
84.04% <100%> (-2.92%)
:arrow_down:

ASPVideoPlayer/Classes/Scrubber.swift
56.88% <100%> (-0.4%)
:arrow_down:

Example/ASPVideoPlayer/PlayerViewController.swift
19.35% <50%> (-2.19%)
:arrow_down:

ASPVideoPlayer/Classes/ASPVideoPlayer.swift
57.14% <61.87%> (-0.27%)
:arrow_down:

ASPVideoPlayer/Classes/ControlButtons.swift
89.33% <66.66%> (-2.45%)
:arrow_down:

ASPVideoPlayer/Classes/PlayPauseLayer.swift
96.55% <88.23%> (+10.34%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8957440...032a513. Read the comment docs.


Sizing: increase height of the lyrics box

The lyrics box is kinda small, so when using a big screen, it just floats in there, where it could use the extra space, and also it's better to read when it's bigger.
Example Screenshots (used resolution 1920x1200):

Before

After

Hi @mbaraa, Can I work on this?

Hi @mbaraa, Can I work on this?

feel free to open a pr !

@mbaraa @asrvd please review PR #10


[Bug] @ts-ignore in cloudinary-loader.ts

Bug Report
Describe the bug
A @ts-ignore is currently in place in the cloudinaryLoader function which is what organizes and ultimately helps to build a Cloudinary URL based on Next.js props.
https://github.com/cloudinary-community/next-cloudinary/blob/main/next-cloudinary/src/loaders/cloudinary-loader.ts#L58-L59
Goal wouild be to address whatever type issues are preventing this line from being removed.

we'll start with the other issue and can work on other issues 1 by 1 unless someone else takes it first. thanks

sure thing!

@colbyfayock I have sent in a PR for this.

@colbyfayock I think we can close this.


python310Packages.sphinxext-opengraph: 0.9.0 -> 0.9.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.sphinxext-opengraph is: Sphinx extension to generate unique OpenGraph metadata
meta.homepage for python310Packages.sphinxext-opengraph is: https://github.com/wpilibsuite/sphinxext-opengraph
meta.changelog for python310Packages.sphinxext-opengraph is: https://github.com/wpilibsuite/sphinxext-opengraph/releases/tag/v0.9.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.9.1 with grep in /nix/store/ndydvij529yjzmswz0ksmbagkwll2l5k-python3.10-sphinxext-opengraph-0.9.1
found 0.9.1 in filename of file in /nix/store/ndydvij529yjzmswz0ksmbagkwll2l5k-python3.10-sphinxext-opengraph-0.9.1

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
kitty
python310Packages.sphinxext-opengraph
python311Packages.sphinxext-opengraph

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ndydvij529yjzmswz0ksmbagkwll2l5k-python3.10-sphinxext-opengraph-0.9.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.sphinxext-opengraph https://github.com/r-ryantm/nixpkgs/archive/79cf68d6f0c4081926c938cbcd73283ad8607f27.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/79cf68d6f0c4081926c938cbcd73283ad8607f27#python310Packages.sphinxext-opengraph

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ndydvij529yjzmswz0ksmbagkwll2l5k-python3.10-sphinxext-opengraph-0.9.1
ls -la /nix/store/ndydvij529yjzmswz0ksmbagkwll2l5k-python3.10-sphinxext-opengraph-0.9.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

Maintainer pings
cc @Luflosi for testing.

Duplicate of #275872.


AttributeError: module 'serial' has no attribute 'VERSION'

Just did. fresh install on Debian, but cannot get it to run, any ideas ??
Connecting to /dev/ttyUSB0 (buffer-size 32)...
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/rshell/main.py", line 1282, in connect
    ip_address = socket.gethostbyname(port)
socket.gaierror: [Errno -2] Name or service not known

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/rshell", line 10, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.7/dist-packages/rshell/command_line.py", line 4, in main
    rshell.main.main()
  File "/usr/local/lib/python3.7/dist-packages/rshell/main.py", line 2913, in main
    real_main()
  File "/usr/local/lib/python3.7/dist-packages/rshell/main.py", line 2875, in real_main
    connect(args.port, baud=args.baud, wait=args.wait, user=args.user, password=args.password)
  File "/usr/local/lib/python3.7/dist-packages/rshell/main.py", line 1288, in connect
    connect_serial(port, baud=baud, wait=wait)
  File "/usr/local/lib/python3.7/dist-packages/rshell/main.py", line 1312, in connect_serial
    dev = DeviceSerial(port, baud, wait)
  File "/usr/local/lib/python3.7/dist-packages/rshell/main.py", line 1554, in __init__
    pyb = Pyboard(port, baudrate=baud, wait=wait, rts=RTS, dtr=DTR)
  File "/usr/local/lib/python3.7/dist-packages/rshell/pyboard.py", line 130, in __init__
    if serial.VERSION == '3.0':
AttributeError: module 'serial' has no attribute 'VERSION'

python
Python 3.7.3 (default, Apr  3 2019, 05:39:12)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import serial
>>> dir(serial)
['__builtins__', '__cached__', '__doc__', '__file__', '__loader__', '__name__', '__package__', '__path__', '__spec__', 'abc', 'absolute_import', 'division', 'errors', 'generators', 'hooks', 'marshal', 'meta', 'model', 'nested_scopes', 'print_function', 'properties', 'request', 'test', 'unicode_literals', 'utilities', 'with_statement']
>>>

It sounds like you have an old version of pyserial.
I would start by trying:
python3 -m pip install --upgrade pyserial

You'll probably also need to add sudo

I am getting this exact same error, with all the newest versions of everything. After running pip install --upgrade rshell:
Requirement already satisfied: rshell in ./Library/Python/3.8/lib/python/site-packages (0.0.31)
Requirement already satisfied: pyudev>=0.16 in ./Library/Python/3.8/lib/python/site-packages (from rshell) (0.23.2)
Requirement already satisfied: pyserial in ./Library/Python/3.8/lib/python/site-packages (from rshell) (3.5)
Requirement already satisfied: six in /Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/site-packages (from pyudev>=0.16->rshell) (1.15.0)

sudo pip3 install --ignore-installed -U pyserial
Run this command to get it resolved


[gh-actions] make linux package installation tests resilient to container image failures

Component(s)
No response
Describe the issue you're reporting
Problem
In issue open-telemetry/opentelemetry-collector-contrib#16450 it has been discovered that the Linux Package installation tests can fail for non-obvious reasons due to the complexity of the test bed setup.
The critical part of the Linux Package testing that was failing in the referenced issue was:

Run up a container image with a standard Linux distro (1 x Debian and 1 x Rocky Linux) which has SystemD as the container's ENTRYPOINT
Copy the .deb / .rpm package to be tested onto the running container
Perform the installation and start-up checks of the package inside the container

In the issue, the execution was silently failing at step 1 without raising an error.
The cause of the silent failure is because the container image used for the installation testing has no health check configured when the image is run. Therefore, the only failure conditions that can be captured are the ones that podman run / docker run are reporting, which are limited to:

125 The error is with Podman itself

$ podman run --foo busybox; echo $?
Error: unknown flag: --foo
125

126 The contained command cannot be invoked

$ podman run busybox /etc; echo $?
Error: container_linux.go:346: starting container process caused "exec: \"/etc\": permission denied": OCI runtime error
126

127 The contained command cannot be found

$ podman run busybox foo; echo $?
Error: container_linux.go:346: starting container process caused "exec: \"foo\": executable file not found in $PATH": OCI runtime error
127

Exit code contained command exit code

$ podman run busybox /bin/sh -c 'exit 3'; echo $?
3

source: https://docs.podman.io/en/latest/markdown/podman-run.1.html#exit-status
Since docker run / podman run is used with the --detach switch in the Linux Packaging tests, a non-zero exit code from the contained command itself will never be returned by podman run / docker run
Solution
In order to make the transition from step 1. to step 2. and beyond more resilient, it is sufficient to simply make the Linux Packaging script execution wait until the SystemD manager inside of the container is confirmed to be up and running.
This can be achieved with the following:

Execute systemctl is-system-running --wait inside of the container in order to wait for the system inside of the container to be fully operational
Integrate the check from step 1 into the Linux Packaging execution by either:

Use systemctl --machine=<nameofcontainer> is-system-running --wait directly in the Linux Packaging test script
Or adjust the podman run command line to run the systemctl is-system-running --wait command as a Startup Health Check script and therefore make the execution of podman run wait until the container is fully operational.

I am working on a fix for this


nixos/sway: Extend the default configuration for NixOS

The default config.in template contains
"include<EMAIL_ADDRESS>but we've dropped it to better
support non-NixOS (which seems like a mistake in retrospect).
This restores that behaviour and extends the default configuration via
nixos.conf to fix #119445.
Note: The security configurations (security.d) where dropped entirely
(but maybe they'll return).

Motivation for this change
Note: This is currently just an idea/draft and I haven't tested it yet. Unfortunately it's somewhat hacky so an alternative would be to drop our support to easily use our Sway package outside of NixOS (we could ask around if anyone uses that and if it even works as expected).
TODOs: Extend the NixOS VM test for Sway to test pinentry (maybe an optional test/extension if this causes too many rebuilds when testing changes to core packages).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Let's merge this for NixOS 21.05. Having /etc/sway/config.d/* in the default configuration seems like an important "fix" and the current nixos.conf for Sway should make it much easier to use GPG and screen sharing (both still require additional configuration but that isn't Sway specific / affects all other compositors). The implementation can still be changed in the future.

i'm not clear on how adding stuff to the default config is "restoring behaviour"
shouldn't that involve removing the part where "we dropped that"?

@evils that part's a bit complicated due to NixOS vs. Nix outside of NixOS, Nix store paths (that get garbage collected), and copying Sway's default configuration file (which should not contain any Nix store paths that will get GCed). Together with the Git history that hopefully explains the reasoning at the time.
https://github.com/NixOS/nixpkgs/pull/122995/files#diff-635aedb425667b0a9cd9ecab374760ed0c32a1853a15e95d5fb86cdfc047da1f might also help explaining it.

Idk if this is linked but now when I run pass (which runs gpg behind) from an ssh session, I don't get the pinentry prompt in the shell but on my desktop. This is problematic as I am unable to then enter my passphrase without being physically at my computer.

@NilsIrl huh, that sounds very strange (unless you're SSHing to your own machine and the same user). Shouldn't be related though (and it's easy to test). I quickly tested running gpg --quick-gen-key via SSH on a remote server and that works as expected. Anyway, this should get a dedicated issue if it's really Nixpkgs related.

unless you're SSHing to your own machine and the same user

It seems to me that this is what I'm doing?
I'm SSHing into the machine that is running sway as the user that is running sway (the user account I use for everything)


feat: add is_default to SchedulerCluster table

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Add is_default to SchedulerCluster table

Related Issue

Motivation and Context
Fixes #456

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #458 (4719bc0) into main (b7b4558) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   36.31%   36.18%   -0.14%
==========================================
  Files          85       85
  Lines        6727     6727
==========================================
- Hits         2443     2434       -9
- Misses       3933     3943      +10
+ Partials      351      350       -1

Flag
Coverage Δ

e2etests
?

unittests
36.18% <ø> (-0.14%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/daemon/peer/peertask_stream.go
54.77% <0.00%> (-2.21%)
:arrow_down:

client/daemon/peer/peertask_base.go
32.21% <0.00%> (-0.72%)
:arrow_down:


CmsFieldType: Document Extension to allow Lists

CmsField constructor amendment to allow "isArray" parameter:
this.People = new CmsField("People", CmsFieldTypes.DOCUMENT, window.cmsDataCache[window.cmsDataCache.cmsAssetId].PeopleGroup.People, true);
Example JSON output used in Freshworks list components:
{   "HeroCTA": {     "Title": "Freshworks Partner Directory",     "Sub_Text": "By delivering the best solutions for customers, our growing community of resellers and technology partners is transforming the ways businesses function. Our partners are specialists with experience in choosing right solutions and efficiently deploying them, based on customer requirements.",     "Pricing_Clause": "",     "Button_Text": "Find a Partner"   },   "PeopleGroup": {     "Title": "Founders",     "People": [       {         "Person": {           "Profile_Link": "https://www.linkedin.com/in/girish1/",           "Image": "https://website-assets-fw.freshworks.com/attachments/ckaqm11nb09b1p0fzim0xg87e-girish.one-half.jpg",           "Name": "Girish Mathrubootham",           "Title": "Founder and CEO"         }       },       {         "Person": {           "Profile_Link": "https://www.linkedin.com/in/shankrishna/",           "Image": "https://website-assets-fw.freshworks.com/attachments/ckaqm2ktu09dtp0fzd791y5j8-shan.one-half.jpg",           "Name": "Shan Krishnasamy",           "Title": "Co-founder and CTO"         }       }     ]   },   "Footer": {},   "FunctionalityFooter": {},   "TopNav": {} }


Change instance check to class name check since returned instance fro…

…m cache is not guaranteed to match.

@chavdar please review.


failed at dev script 'scripts/dev'

0 info it worked if it ends with ok
1 verbose cli [ 'C:\Program Files\nodejs\node.exe',
1 verbose cli   'C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'dev' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'predev', 'dev', 'postdev' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 silly lifecycle<EMAIL_ADDRESS>no script for predev, continuing
7 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>8 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
9 verbose lifecycle<EMAIL_ADDRESS>PATH: C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin;C:\Users\Skylar\documents\web\marzipano\node_modules.bin;C:\Users\Skylar\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\local\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Users\Skylar\bin;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\ProgramData\Oracle\Java\javapath;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Program Files (x86)\GtkSharp\2.12\bin;C:\Program Files\Common Files\Autodesk Shared;C:\Program Files (x86)\Autodesk\Backburner;C:\Program Files\nodejs;C:\Users\Skylar\AppData\Local\atom\bin;C:\Users\Skylar\AppData\Roaming\npm;C:\Program Files\Git\usr\bin\vendor_perl;C:\Program Files\Git\usr\bin\core_perl
10 verbose lifecycle<EMAIL_ADDRESS>CWD: C:\Users\Skylar\documents\web\marzipano
11 silly lifecycle<EMAIL_ADDRESS>Args: [ '/d /s /c', 'scripts/dev' ]
12 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
13 info lifecycle<EMAIL_ADDRESS>Failed to exec dev script
14 verbose stack Error<EMAIL_ADDRESS>dev: scripts/dev
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter. (C:\Program Files\nodejs\node_modules\npm\lib\utils\lifecycle.js:232:16)
14 verbose stack     at emitTwo (events.js:100:13)
14 verbose stack     at EventEmitter.emit (events.js:185:7)
14 verbose stack     at ChildProcess. (C:\Program Files\nodejs\node_modules\npm\lib\utils\spawn.js:24:14)
14 verbose stack     at emitTwo (events.js:100:13)
14 verbose stack     at ChildProcess.emit (events.js:185:7)
14 verbose stack     at maybeClose (internal/child_process.js:827:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
15 verbose pkgid<EMAIL_ADDRESS>16 verbose cwd C:\Users\Skylar\documents\web\marzipano
17 error Windows_NT 10.0.10586
18 error argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "run" "dev"
19 error node v5.6.0
20 error npm  v3.6.0
21 error code ELIFECYCLE
22 error<EMAIL_ADDRESS>dev: scripts/dev
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>dev script 'scripts/dev'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the marzipano package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     scripts/dev
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs marzipano
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls marzipano
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

Are you able to run ./scripts/dev directly from the shell? The dev script is written in Bash, so on Windows you need to have Cygwin (or some equivalent) installed.

Tiago,
I am able to run ./scripts/dev but I am not able to run "npm run dev"
Thank you for your help!
On Tue, Mar 29, 2016 at 1:04 PM, Tiago Quelhas<EMAIL_ADDRESS>wrote:

Are you able to run ./scripts/dev directly from the shell? The dev script
is written in Bash, so on Windows you need to have Cygwin (or some
equivalent) installed.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/google/marzipano/issues/3#issuecomment-202999948

Unfortunately, it seems you're a victim of this npm issue: https://github.com/npm/npm/issues/9420. Running the script directly may be the only option on Windows at the moment.
If you happen to find a workaround, be sure to let us know.

Will do, thanks again for your help.
 Running the script directly may
be the only option on Windows at the moment.
If you happen to find a workaround, be sure to let us know.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/google/marzipano/issues/3#issuecomment-203213334

I have same problem as below :
$ npm run dev

<EMAIL_ADDRESS>dev D:\marzipano
scripts/dev

'scripts' is not recognized as an internal or external command,
operable program or batch file.

@ansarikhurshid786 and anyone else having this issue in Windows. Prepend sh  to scripts/dev in your packages.json ("dev": "sh scripts/dev",) . Also,  as mentioned above, you need to be able to execute bash scripts.


Add foldable comment code blocks

In order to make the generated code easier to read, code blocks could be defined in comments. IntelliJ users could collapse these blocks - Eclipse does not support it (yet)

currently not possible with javapoet


Catalog description doesn't not change when switching from entry page

Rancher Versions:

Rancher	v1.4.1
Cattle	v0.176.9
User Interface	v1.4.6
Rancher CLI	v0.4.1
Rancher Compose	v0.12.2

Docker Version:
1.13.0
OS and where are the hosts located? (cloud, bare metal, etc):
CoreOS 1313.0.0 on AWS EC2
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
HA Rancher and AWS RDS
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Going from "non-trivial" (HTML, bullet lists, links, etc.) descriptions to any other:

Go to Catalog
View Details of any entry with non-trivial description, such as "Kubernetes"
In the "Catalog:" dropdown, top left, choose any other entry
Description does not change

Going from "trivial" (one line, plain text) descriptions to "non-trivial":

Go to Catalog
View Details of any entry with a trivial description, such as "Rancher Network Policy Manager"
In the "Catalog:" dropdown, top left, choose any entry with a non-trivial description, such as "Kubernetes"
Description is blank

Results:
Entry description always continues to display the same text until you back out to the catalog.
If an entry with a trivial one line description is chosen, such as "Rancher Network Policy Manager," then the description will change as expected when switching to any other entry with a trivial description. If you switch to an entry with a non-trivial description, its description will be blank.

This is a duplicate of #6470.  Closing in favor of previous bug.


he following assertion was thrown while handling a gesture: flutter: type '_BroadcastSubscription' is not a subtype of type 'StreamSubscription'

Log error:
https://gist.github.com/HieuTranTrung1204/18783bd6c75e3a9edd30cd9dbfa242fc

Syncing files to device iPhone X...
flutter: ══╡ EXCEPTION CAUGHT BY GESTURE ╞═══════════════════════════════════════════════════════════════════
flutter: The following assertion was thrown while handling a gesture:
flutter: type '_BroadcastSubscription' is not a subtype of type 'StreamSubscription'
flutter:
flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
flutter: more information in this error message to help you determine and fix the underlying cause.
flutter: In either case, please report this assertion by filing a bug on GitHub:
flutter:   https://github.com/flutter/flutter/issues/new
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #0      _MyAppState.showMap (file:///Volumes/DATA/Projects/Training/TrainingFlutter/lib/main.dart:132:10)
flutter: #1      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:494:14)
flutter: #2      _InkResponseState.build. (package:flutter/src/material/ink_well.dart:549:30)
flutter: #3      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:102:24)
flutter: #4      TapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:161:9)
flutter: #5      TapGestureRecognizer.handlePrimaryPointer (package:flutter/src/gestures/tap.dart:94:7)
flutter: #6      PrimaryPointerGestureRecognizer.handleEvent (package:flutter/src/gestures/recognizer.dart:315:9)
flutter: #7      PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:73:12)
flutter: #8      PointerRouter.route (package:flutter/src/gestures/pointer_router.dart:101:11)
flutter: #9      _WidgetsFlutterBinding&BindingBase&GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:143:19)
flutter: #10     _WidgetsFlutterBinding&BindingBase&GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:121:22)
flutter: #11     _WidgetsFlutterBinding&BindingBase&GestureBinding._handlePointerEvent (package:flutter/src/gestures/binding.dart:101:7)
flutter: #12     _WidgetsFlutterBinding&BindingBase&GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:64:7)
flutter: #13     _WidgetsFlutterBinding&BindingBase&GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:48:7)
flutter: #14     _invoke1 (dart:ui/hooks.dart:134:13)
flutter: #15     _dispatchPointerDataPacket (dart:ui/hooks.dart:91:5)
flutter:
flutter: Handler: onTap
flutter: Recognizer:
flutter:   TapGestureRecognizer#a2399(debugOwner: GestureDetector, state: possible, won arena, finalPosition:
flutter:   Offset(198.0, 286.3), sent tap down)
flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════
flutter: Location updated Location{latitude: 37.785834, longitude: -122.406417}
Google Maps SDK for iOS version: 2.6.30421.0
New version of Google Maps SDK for iOS available: 2.7.30514.0
[1.1 31784E60-48F9-470F-BEA1-8DD6E2A60DAC 2405:4800:5287:37f:3c8f:3e8d:9d9f:3cc7.61253<->2404:6800:4005:80c::200e.443]
Connected Path: satisfied (Path is satisfied), interface: en0
Duration: 1.088s, DNS @0.015s took 0.002s, TCP @0.021s took 0.086s, TLS took 0.476s
bytes in/out: 4083/720, packets in/out: 9/9, rtt: 0.088s, retransmitted packets: 0, out-of-order packets: 0

Please add the output of flutter doctor
How can this be reproduced?

Thanks your reply 👍
Output flutter doctor:
Trans-MacBook-Pro-2:Flutter trunghieutran$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v0.5.2-pre.72, on Mac OS X 10.13.4 17E202, locale en-VN)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.0)
[✓] iOS toolchain - develop for iOS devices (Xcode 9.3)
[✓] Android Studio (version 3.1)
[!] VS Code (version 1.24.0)
[✓] Connected devices (1 available)
! Doctor found issues in 1 category.
Trans-MacBook-Pro-2:Flutter trunghieutran$
I use map view
log error when showmap
Code here: https://gist.github.com/HieuTranTrung1204/7f46825778a34b87aaa0998fa3f07fac

@HieuTranTrung1204  The following is not valid:
https://gist.github.com/HieuTranTrung1204/7f46825778a34b87aaa0998fa3f07fac#file-demo-map-L115-L152
Your first assignment infers a StreamSubscription<Location>:
https://gist.github.com/HieuTranTrung1204/7f46825778a34b87aaa0998fa3f07fac#file-demo-map-L115
While subsequent ones may be of another type.
My recommendation is to either avoid the sub = allocation entirely (it doesn't do anything):
compositeSubscription.add(
  mapView.onLocationUpdated
        .listen((location) => print("Location updated $location"))
);

Or, explicitly type sub as something like StreamSubscription<void>:
StreamSubscription<void> sub =

...

sub =

... since void can effectively be anything.

(Sort of unrelated, I don't think CompositeSubscription helps much more than a List here)


Include Rails 4.2 in note about versions tested

@mceachen is there anything specific you need for documentation changes?

Nope, sorry for the delay.

No problem! Thank you!


modified a few tooltips in standard-library-items.json

Pull request to merge changes to a few tooltips.

Might remove "decision" from the tooltip for the tree as it'll work for many types of tree


iOS Wallet and State Management Epic

As a mobile wallet developer I would like an SDK that provides me with all of the tools necessary to observe blockchain state and my wallet reliably so that I can easily integrate zcash shielded support into my wallet.
Criteria:

[x] The SDK can download and decrypt blocks in order to find transactions that pertain to the wallet
[x] The SDK must be able to recognize, acknowledge, and rectify the effects of a blockchain reorganization
[x] Able to query for all transactions related to the wallet
[x] Able to query for the current wallet balance
[x] Able to query for the current block height
[x] Able to generate Sapling keys from a ZIP32 seed
[ ] Able to generate transparent keys from seed
[x] Able to generate ZIP32 seed from BIP39 style mnemonic
[x] Able to generate addresses from their associated keys
[x] Able to initialize accounts (#15)

Not quite done, being rephrased as a deliverable epic for Q2


Bye bye WhoWas

Sigh. Username History API Removal
https://help.minecraft.net/hc/en-us/articles/8969841895693

That's a shame. Thanks for letting me know.

It's pretty crazy for me to come back to this after seven years - I had no idea anyone was using this!

Why did Mojang kill this plugin, as well as NameMC?


"undefined" flooding browser log

There's a log call in grapher.js that is spamming the browser console.

Fixed in v0.18.1


fix up grep checking

@j0tunn, @sipayRT, @eGavr, @tormozz48, @DudaGod

Coverage increased (+0.008%) to 81.662% when pulling f496abd8cf1289de19b09009b9514d65760923b7 on grep-fix into ec211b818658d28c31fdedd51cd22d9e240e4881 on master.

Coverage remained the same at 81.653% when pulling 7a4c70bf9fd9ad31d2d4ca6a4e9d7f7b9276a10d on grep-fix into ec211b818658d28c31fdedd51cd22d9e240e4881 on master.

В остально вроде 🆗

Coverage remained the same at 81.653% when pulling 8bc69d8affcfff611700aede1ae6f32ff6907aa3 on grep-fix into ec211b818658d28c31fdedd51cd22d9e240e4881 on master.

ok

Coverage remained the same at 81.653% when pulling 8bc69d8affcfff611700aede1ae6f32ff6907aa3 on grep-fix into ec211b818658d28c31fdedd51cd22d9e240e4881 on master.

Coverage remained the same at 81.653% when pulling 629942b48b30f2754bb296e991b398423bb06f3f on grep-fix into ec211b818658d28c31fdedd51cd22d9e240e4881 on master.


Local network access enabled, cannot connect to VPN

Steps to reproduce
After establishing a connection to VPN (Global Protect client) on my Windows machine.  If I have Local network access toggled ON, my app is not able to connect to a server on VPN.  If i toggle OFF Local network access my app can connect okay.  I see from the 2306 update there were some updates:

Local networking (under Advanced settings - Experimental features) now replacing "Advanced networking". Android apps can connect to devices on the same network, on all versions of Windows, respect Windows firewall rules, and work with VPNs

✔ Expected Behavior
When Local network access is toggled ON and hosting Windows machine has an active VPN connection - WSA apps can access resources using the VPN connection
❌ Actual Behavior
When Local network access is toggled ON and hosting Windows machine has an active VPN connection - WSA apps CANNOT access resources using the VPN connection
Other Software
No response
Please specify the version of Windows Subsystem for Android
2306

Not only this same as you, but also the ipv6 connection is not well supported.
https://github.com/microsoft/WSA/issues/389

@yk00365, can you please file feedback via Windows Feedback Hub (Windows key + F) under category Apps > Windows Subsystem for Android and include a recording of your issue. The additional logs will help us understand what's going on.

@philnach I see the comment is closed, do you have any recommendation on how I should proceed with this issue?
cc @timkur


dict_keys and dict_values types do not work with filter_by #2221

This PR resolves #2221
dict_keys and dict_values types do not work with filter_by

This looks great, but it would be fantastic to add a unit test for this.   Please just add a "this works" test in test/test_sframe.py.  Thanks @dhivyaaxim for the great work!!

The error that caused the above CI failures has been fixed elsewhere.  Could you merge in master and push again?

@hoytak Thanks!  Can you merge this changes to master?

@dhivyaaxim - Thanks for another great bug fix. For future reference: once your changes have been approved and passed Travis CI, feel free to merge.


fix(setting): put settings' ReadOnly into effect

Add an annotation to mark that the updating is from Longhorn and it should be able to update successfully even if setting definition is set to be read-only.
Ref: longhorn/longhorn#5989

Why not just use GetSettingDefinition and SettingDefinition::ReadOnly to determine whether the being updated setting is ready only or not?

There is an check statement here for SettingDefinition::ReadOnly
I tried to temporarily change SettingDefinition::ReadOnly if it is updated by controllers or somewhere by Longhorn,
but when the object is updating and going through the validator,
it seems that SettingDefinition will be read again from types/settings.go by GetSettingDefinition

Let me recheck this PR later.

@mergify backport v1.5.x

@mergify backport v1.4.x


Command does not exist

IN the file: windowsserverdocs/WindowsServerDocs/administration/windows-commands/active.md, (https://github.com/MicrosoftDocs/windowsserverdocs/blob/master/WindowsServerDocs/administration/windows-commands/active.md) the article talks about a command that does not exist.
I think the Active command is a sub-command within DiskPart.
This document needs updating to reflect what this command is.

This needs a TOC change as well as the page itself. Looking at the other TOC entries listed underneath their respective main commands, the subcommand filenames begin with the name of the main command, so in this case, the files should be renamed to diskpart-*.md and the links should be moved to a H4 entry underneath the main Diskpart entry in the command list.

Visual example:

diskpart

diskpart (existing file diskpart.md)
diskpart active (new name diskpart-active.md)
diskpart add (new name diskpart-add.md)
diskpart assign (new name diskpart-assign.md)
diskpart attach vdisk (new name diskpart-attach.md)
diskpart attributes (new name diskpart-attributes.md)
diskpart automount (new name diskpart-automount.md)
diskpart break (new name diskpart-break.md)
diskpart clean (new name diskpart-clean.md)
diskpart compact vdisk (new name diskpart-compact-vdisk.md)
diskpart convert (new name diskpart-convert.md)
diskpart create (new name diskpart-create.md)
diskpart delete (new name diskpart-delete.md)
diskpart detach vdisk (new name diskpart-vdisk.md)
diskpart detail (new name diskpart-detail.md)
diskpart exit (new name diskpart-exit.md)
diskpart expand vdisk (new name diskpart-expand-vdisk.md)
diskpart extend (new name diskpart-extend.md)
diskpart filesystems (new name diskpart-filesystems.md)
diskpart format (new name diskpart-format.md)
diskpart gpt (new name diskpart-gpt.md)
diskpart help (new name diskpart-help.md)
diskpart import (new name diskpart-import.md)
diskpart inactive (new name diskpart-inactive.md)
diskpart list (new name diskpart-list.md)
diskpart merge vdisk (new name diskpart-merge-vdisk.md)
diskpart offline (new name diskpart-offline.md)
diskpart online (new name diskpart-online.md)
diskpart recover (new name diskpart-recover.md)
diskpart rem (new name diskpart-rem.md)
diskpart remove (new name diskpart-remove.md)
diskpart repair (new name diskpart-repair.md)
diskpart rescan (new name diskpart-rescan.md)
diskpart retain (new name diskpart-retain.md)
diskpart san (new name diskpart-san.md)
diskpart select (new name diskpart-select.md)
diskpart set id (new name diskpart-set-id.md)
diskpart shrink (new name diskpart-shrink.md)
diskpart uniqueid (new name diskpart-uniqueid.md)

in addition to the changes illustrated above, we also need to change the URLs in the diskpart.md file content:

https://github.com/MicrosoftDocs/windowsserverdocs/blob/master/WindowsServerDocs/administration/windows-commands/diskpart.md

TOC file URL: https://github.com/MicrosoftDocs/windowsserverdocs/blob/master/WindowsServerDocs/administration/windows-commands/TOC.md

that all sounds good to me in terms of resolving this issue, although the command list is a bit of inconsistencies.

Who would do this change??

Sorry, I have been too busy with other material. This change should either be made in stages, or all in one big PR with several pages. I have not landed on a decision on how to do it or how much time I would need to gather the PR content.

I've been wanting to get the commands pages updated for a while. There a few things I'd like to see added, including the full executable name including path.  There is a lot of work there so having a plan and encouraging some more community effort seems a good idea.

Easter bank holidays will be here in about 24 days time. I am looking to create a PR during those days off from work.

#please-close


Fixes 2048,Fixes 2613,Fixes 1700: React 18 preview

Summary
This is the ongoing react 18 upgraded "main" branch, created to hold acked changes until IQE-core/QE have Patternfly 5/React 18 compatibility for their test suites.
This can be merged to main once all tests are passing and QE is confident of test compatibility.
Testing steps

None at the moment.

/retest

https://issues.redhat.com/browse/HMS-2048

https://issues.redhat.com/browse/HMS-Fixes

Hi
Custom Repositories
why that says data-ouia-component-type="PF4/Title"

Hi
this Kebab section is quite different to the old version:
 <button class="pf-v5-c-menu-toggle pf-m-plain" type="button" aria-label="Kebab toggle" aria-expanded="false">
Try add `data-ouia-component-id='custom_repositories_kebab_toggle'
Thank you

https://issues.redhat.com/browse/HMS-1700

/retest

/retest

/retest

/retest

/retest

Hi, the updated-for-Patternfly 5 tests pass. Lets merge this.

/retest

OK, lgtm, merge when test status permits please.


Request access to the code for the paper 'Mask as Supervision: Leveraging Unified Mask Information for Unsupervised 3D Pose Estimation'

Dear Dr. Yang
I am writing to thank you for your outstanding work in the paper titled 'Mask as Supervision: Leveraging Unified Mask Information for Unsupervised 3D Pose Estimation'. The insights and findings detailed in your research are very insightful.
When reviewing your paper, we attempted to find the corresponding code repository on GitHub, but were unable to find accessible code.
Can you provide the code related to your paper? Accessing the code will greatly facilitate our further understanding of your contributions in the research.
Thank you very much for your attention to this matter. We eagerly look forward to any guidance or assistance you may provide when accessing the code.
We look forward to your reply.
Warm greetings.

Sorry for the delay in the release.
It just got accepted at the recent conference but due to the changes in my computing sources, I have not re-arranged the code. Meanwhile, we are working on the V2, which is expected to be released before the end of this year.
I'll try my best to release the V1 as soon as possible. And I'll @you once the work is done.
Thank you for your attention.

Hello @WangRors! We have released the code for V2, which includes the main code from V1 with minor modifications. Please refer to this [repo].(https://github.com/Charrrrrlie/X-as-Supervision)
Feel free to ask any questions if there is something wrong or confusing.


Multiple target labels

Hi, it's a bit unclear in the documentation but can I use multiple categorical features as a target for supervised/semi-supervised learning?

In the current implementation, no. There are changes coming in v0.4 that will remedy this (as well as hopefully allowing hierarchical categorical targets), but in the meantime see issues #145 and #58 for some examples of ways one might go about this within the current codebase. It is do-able, but definitely requires a little work.


🆕 Software Suggestion | Vivaldi Browser

Basic Information
Name: Vivaldi Browser
Category: Browsers
URL: https://vivaldi.com/
Description
Chromium-based web browser with many unique features.
Why I am making the suggestion
I have made an article on PrivacyTools Writefreely about Vivaldi. Inside the article are the sources.
Link to the article: https://write.privacytools.io/kolivro/vivaldi-and-privacy
My connection with the software
I like the browser. Sometimes, user. I am not connected in any way with the creators of Vivaldi.

[x] I will keep the issue up-to-date if something I have said changes or I remember a connection with the software.

I don' t think it should be listed, it probably phones to Google and Vivaldi servers, and it's not exactly a "libre" project since every browser except FF uses Chromium's code (and their CSS is proprietary). Yeah, it may have a lot of features but this is Tools for Power Users, it is Privacy Tools.
Besides all that, I don't think it is a good idea to not recommend the last existing non Chromium based broswer; FF stops existing and Google will decide what ammount of privacy you can achieve.

Duplicate of #717

Please reopen https://github.com/privacytools/privacytools.io/issues/2206 (more recent) or https://github.com/privacytools/privacytools.io/pull/717 , since no one has said a why not to include it. I have researched Vivaldi, and have written up my findings in this article and I don't see a why not to include it.
The only thing that has been said is that it is closed source, and this issue is explained by Vivaldi here.
Translated with www.DeepL.com/Translator


OSFUSE-109 Allow issuing jolokia requests from CLI commands in the same container.

This builds on PR #20

Thanks ! I will integrate it (along with #20) later this afternoon.

Added changes with https://github.com/fabric8io-images/s2i/commit/c6d9e21e8c33708d820e99c97f88be9557af870b


Climbing Claws

Type
Shaped
Ingredients for the recipe
O: Orb Piercer Spikes
D: Diamonds
S: Stick
Result
Climbing Claws; When you hold them in your hand/off-hand you lose stamina (25%?) slower while climbing walls.
Crafting table recipe shape
| O |
|O O|
|DSD|

Additional info
No response
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] I have ensured the recipe I'm requesting isn't already in the server.

I was also thinking that if you had two of them and you had one in both of your hands the effect would stack to 50%. This would increase your climbing capabilities in return for taking up both hands

Idea might work but the feature isnt available. When it is a thing there will be a recipe


Honeywell fixes and improvements

Description:
Update Honeywell ClimateDevice to have a meaningful state and to raise state_changed events when the state has changed.
Related issue (if applicable): fixes #8688
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

Hi @dansarginson,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!