Pixel fitting method

I am adding images which contain text to a canvas and then applying a transformation to them with the composition TransformMatrix property. The resultant transformed image seems to lack clarity. I have done the same thing with Win2D using the same transform and it seems to fit the image to the pixels better resulting in much crisper text. Is there any way to adjust the pixel rounding/fitting when using composition transforms?

Can you share more details about the transformation you're applying through SpriteVisual.TransformMatrix?

It includes a scale and translate. When I scale the XAML canvas I insert a new higher dpi images to compensate. This keeps it crisp if I apply the transform with Win2D. but fuzzy if I apply the transform using TransformMatrix
For example... start with an image rendered at the screen dpi. Do pinch to zoom and translate. Take the new  zoom level and multiply it to determine the new dpi and update the image. (I'm using a Win2D CanvasControl to host the image inside my canvas)
I should note I am using a surface pro 3 with higher than 96 dpi screen

I've noticed I can make the images sharp if I render them at 2x the size and downsize them. But this is less than Ideal as it requires allot of extra computer power

I think this is expected at the moment, Composition transforms literally just stretch whatever rendered texture the XAML engines spits out. to over simplify things. So if you scale up in Composition compared to scaling up in XAML itself or on the Win2D Canvas, it's not going to take advantage of the fact your image is higher resolution.
Basically if you apply the transform in Win2D, it will render the image at the scaled up size as the transform is applied during / before rendering. If you apply the transform with composition, it will render the image at it's original non transformed size, then stretch it without rerendering, as the transform is applied after the original rendering.
Good for performance, not good for your specific use case?
(I could be way off base here but that's what I'm taking out from what your issue sounds like)

I don't believe that is the problem as the bluing would be much more severe. When I zoom in using the transform. I also insert a higher quality asset by a corresponding amount. (which is scaled down buy a local transform, then up by the main one to make it the correct size). The blur is subtle and not as though the image has just been scaled up. But the "crispness" of the text is noticeably lower than when I did the same on Win2D. I should note that this observation is on a higher dpi screen (216 dpi surface pro 3). When on a desktop screen (117 dpi) It actually appears crisper than the win2D implementation did. This leads me to think it has something to do with the pixel fitting logic (Like UseLayoutRounding)

Yep, this intuition is probably correct. As @JohnnyWestlake mentioned, XAML is not aware of composition transforms so it won't apply the usual logic like pixel snapping that enables high fidelity text. I would recommend using a RenderTransform or Transform3D in this case.

Yep, this intuition is probably correct. As @JohnnyWestlake mentioned, XAML is not aware of composition transforms so it won't apply the usual logic like pixel snapping that enables high fidelity text. I would recommend using a RenderTransform or Transform3D in this case.

@Pierce913, to make sure we're on the same page and able to address your problem, would it be possible for you to attach a small project that demonstrates the issue you're running into?
Thanks,
Jake

@JasterAtMicrosoft  Here you are. In this example I found that the issue is not just with my complicated image scenario. If I simply take a textblock and translate it with the TransformMatrix it becomes blury. The example shows the issue.
BluryTransforms.zip

Sorry for the delay. As I mentioned earlier this is an expected artifact for text when using Composition transforms. As a workaround I would use RenderTransform or Transform3D.

Hi @Pierce913
We're continually working to improve the interoperability between XAML and Composition, but did this workaround solve your issue for now?
Thanks!

Hi @likuba
Unfortunately the RenderTransform suffered similar clarity issues when I had several matrix transforms multiplied together to create a resultant 2D transform with fractional translations.
The way I solved the issue was to apply a final 'adjustment' matrix to all my transforms to make sure the resultant matrix's translation aligns with an integer number of logical display pixels.
This results in crystal clear rendering.
Cheers!

Awesome--thanks for sharing your workaround to this issue!  I'm going to go ahead and close this one out, but feel free to reactivate or open a new one if you have additional problems.


duplicate entries in the docs

While reading the docs, I noticed duplicate entries in the menu. "Configuring" and "Usage" appear twice in the menu.

This is a bug due to how we render the man page on the site. Not entirely sure how to fix it; probably deleting the non-man Usage section is the best approach.


Support Enterprise vault namespaces

Description

I'm looking to integrate Cosgin with my enterprise vault as its kms however I noticed it seems to be configured to only work with the root namespace. In my environment variable I set up the standard VAULT_NAMESPACE and cosgin does not seem to be picking it up. I double checked this as it is returning the following paths with error from the root namespace.
https://vault-hostname.com/v1/transit/keys/keyname
when it should be:
https://vault-hostname.com/v1/namespace_name/transit/keys/keyname
It should be a simple change to check for that envirment variable and if it is not there then use the default path.
https://developer.hashicorp.com/vault/docs/enterprise/namespaces

After doing more digging it seems the change needs to be done in the sigstore repo. Closing this and opening a new issue in that repo.

Hello, i have the same problem. I think it is a internal feature that should be added inside the cosign cli, no ?


Fixing bit IdentifierNode to be boolean instead of Buffer

With the tedious package, MSSQL's bit data type is parsed out as a boolean JavaScript value. This change reflects that within the resulting codegen.

Nice! Seems correct according to this. Merging.

Would it be possible to have a minor release that fixes this please? :)

I missed that this hadn't been released. 0.15.0 published!


Private repository cloudrepo.io 401 Unauthorized

Hey folks! I am running to a problem installing dependencies with private registry hosted on cloudrepo.
The command I execute is:
uv pip install -r requirements.txt --extra-index-url<EMAIL_ADDRESS>
That causes:
Failed to download `[redacted-package-name]==0.0.13`
  Caused by: HTTP status client error (401 Unauthorized) for url (https://[redacted].mycloudrepo.io/repositories/[redacted]/[redacted-package-name]/[redacted-package-name]-0.0.13-py2.py3-none-any.whl)

Executing pip command:
pip install -r requirements.txt

With ENV variable PIP_EXTRA_INDEX_URL= set to the same value I pass via --extra-index-url to UV works, and the dependency is found and installed.
Note: I pass password & username directly as a string, not trying to interpolate (I am aware of #5734 discussion). I also tried setting an environment variable UV_PIP_EXTRA_INDEX_URL but it doesn't work.
I know there was an issue reported (#1709) that seems to be closed already, but I wonder if it was supposed to be fixed for all platforms (azure/aws, etc) or if it's needed to be added separately for mycloudrepo.io?
Some more details:
Platform:
MacOS, Sonoma 14.4
M1 Apple Silicon
uv --version
> uv 0.4.22 (Homebrew 2024-10-15)

The environment variable you're looking for is UV_EXTRA_INDEX_URL (no _PIP_), though passing on the command-line should be working too. It's hard to say more without being able to debug the index response itself...

Can you share redacted logs with RUST_LOG=uv=trace? That'll give us more information about the authentication flow.

@zanieb thanks for the info about RUST_LOG=trace. It helped me solved the issue.
TLDR in my requirements.txt I had specified:
# Add our private package repo, with read only credentials.
--extra-index-url<EMAIL_ADDRESS>
package1==version
package2==version

And seems like index specified in requirements.txt has higher priority over the one passed explicitly via --extra-index-url when calling uv pip install, which caused an issue for me as I didn't have these env variables specified.
It works now, sorry for the inconvenience @zanieb @charliermarsh


Add motivation and example to delayed docs

This starts off the dask.delayed docs with a user-facing motivation and
example.

cc @davclark , mostly in an attempt to sucker him in to reviewing dask documentation.  A task at which I think he would be quite valuable.


Faster Travis Builds

Make the make check invocation run linearly (-j1) but with a common target dir to prevent rebuilding of deps.

Nice, looks like an easy win.


outEdges() and inEdges() no longer works on 7.x

It appears that outEdges() and inEdges() are incorrectly validating the collection against the passed in IDs on 7.x driver.
This Jest unit test fails:
  it('Gets in edges and out edges from Arango', async () => {
    const db = new Database({
      url: config.arangoDb.url,
      databaseName: config.arangoDb.database
    })
    const edgeCollection = await db.createEdgeCollection('links')
    const edgeCollectionData = await edgeCollection.get()
    expect(edgeCollectionData.type).toBe(CollectionType.EDGE_COLLECTION)

    await expect(edgeCollection.outEdges('notLinks/test1')).resolves.toBeEmptyArray()
    await expect(edgeCollection.inEdges('notLinks/test1')).resolves.toBeEmptyArray()
  })

The error message is:
Document ID "notLinks/test1" does not match collection name "links"

How are these functions, which are available only on EdgeCollection types, supposed to work now?  The entire semantics of the functions rely on the document IDs not matching the edge collection name.
I suspect this is a regression caused by http://arangodb.github.io/arangojs/MIGRATING#cross-collection-operations.

Oops, you're right. documentHandle should take a flag to decide whether it should allow foreign collections to support this use case. This also affects edges.

Oops, you're right. documentHandle should take a flag to decide whether it should allow foreign collections to support this use case. This also affects edges.

Having this same issue trying to retrieve in/out edges on a particular document. @robross0606 thank you for the clear issue report! I think I can manage a workaround in my app, but was feeling like I was crazy for expecting the edge collection to be able to reference a document's id. Always good to be able to point to a clear bug rather than a mystery.

@pluma, why was this closed?  Has it been addressed with a PR?


Version 0.3.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.75%. Comparing base (cea50f9) to head (3856231).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   49.75%   49.75%
=======================================
  Files          16       16
  Lines         416      416
=======================================
  Hits          207      207
  Misses        209      209

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Meraki Rest API information is out of date and failing to connect

Describe the bug
The Meraki Rest API is using an out of date authorization behavior
https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Cisco Meraki Events via REST API/Data Connectors
https://developer.cisco.com/meraki/api-v1/authorization/#obtaining-your-meraki-api-key
"Next, check that your API call has the correct header with the following (and not v0's X-Cisco-Meraki-API-Key):"
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Cisco Meraki Events via REST API/Data Connectors/CiscoMerakiMultiRule_ccp/dataConnectorPoller.json
Line 17
"ApiKeyName": "X-Cisco-Meraki-API-Key"

Hi @giveen, Could you please share the screenshot of the error message when you're getting after clicking on connect. Thanks!

Hi @giveen, After analysis of existing code, we made changes into the REST API authorization and making it to get updated as per Cisco Doc. The PR has been raised with changes and currently it is in review state.
Meantime, if possible, could you please deploy the below file in which the Auth method has been updated into your environment and let us know the connector has been configured correctly and it pull the data for -
Network Session
Web Session
Audit Event

The custom deployment steps are mentioned into below file :
Custom Deployment - CustomDeploymentSteps.docx
Template File - mainTemplate.json
Many Thanks!

Wow you guys are faster than me. I'll test the deployment you sent me and get back to you guys, but here is the rest of the details requested.

Here was my test script
# Define variables for your organization ID and API key
$orgId = "ORGID"
$apiKey = "APIKEY"

# Define the API endpoint for the organization
$apiUrl = "https://api.meraki.com/api/v1/organizations/$orgId"

# Set up the headers, including the API key
$headers = @{
    "X-Cisco-Meraki-API-Key" = $apiKey
    "Content-Type" = "application/json"
}

# Send a GET request to check the organization's connectivity
try {
    $response = Invoke-RestMethod -Uri $apiUrl -Method Get -Headers $headers

    if ($response) {
        Write-Host "Connectivity to Meraki cloud organization is successful."
        Write-Host "Organization Name: $($response.name)"
        Write-Host "Organization ID: $($response.id)"
    } else {
        Write-Host "No response from the Meraki cloud."
    }
}
catch {
    Write-Host "Failed to connect to the Meraki cloud."
    Write-Host "Error: $($_.Exception.Message)"
}

Returned:
Failed to connect to the Meraki cloud.
Error: The remote server returned an error: (404) Not Found.

Considering the new API, this was my script

# Define variables for your API key
$apiKey = "APIKEY"

# Define the API endpoint for listing organizations
$apiUrl = "https://api.meraki.com/api/v1/organizations"

# Set up the headers, including the API key using Bearer token
$headers = @{
    "Authorization" = "Bearer $apiKey"
    "Content-Type" = "application/json"
}

# Send a GET request to list the organizations
try {
    $response = Invoke-RestMethod -Uri $apiUrl -Method Get -Headers $headers

    if ($response) {
        Write-Host "Connectivity to Meraki cloud organizations is successful."
        foreach ($org in $response) {
            Write-Host "Organization Name: $($org.name)"
            Write-Host "Organization ID: $($org.id)"
        }
    } else {
        Write-Host "No response from the Meraki cloud."
    }
}
catch {
    Write-Host "Failed to connect to the Meraki cloud."
    Write-Host "Error: $($_.Exception.Message)"
}

Result:
Connectivity to Meraki cloud organizations is successful.
Organization Name: Sxxxxxxxxxxxxx
Organization ID: 6xxxxxxxxxxxxxxxxxx

Hey @giveen, Today I have check with above scripts Old and New one to check the response for the Org Name and Org Id, and received the successfully response for both of them, there no issue currently having with the old API.
And from our end we can be able to connect the existing connector without any fail:

Let's check with your credentials to our updated connector, I see your getting the deployment error is may due to while deployment of template you did not enter the correct values, so please add below values and re-deploy the template -

I was able to deploy the template with no issues after adding in my Workspace-location, and Workspace name.
However, after putting in my Org ID and API key from the Data Connectors page, same result of 404.

@v-sudkharat
If you look at my test script, you will see that Org-ID is no longer needed. When just inputting my API key, Cisco new which Org I belonged too.

Hi @giveen, Thanks for your response. Did you check the same for cisco end for 404 error? if any permissions or settings required and it should be disable currently?
And its possible can you share the credentials with us, so we can check it in our environment and understand the error :
Below is the mail ID where you can mail us -<EMAIL_ADDRESS>

Hi @giveen, Thanks for your response. Did you check the same for cisco end for 404 error? if any permissions or settings required and it should be disable currently? And its possible can you share the credentials with us, so we can check it in our environment and understand the error : Below is the mail ID where you can mail us -<EMAIL_ADDRESS>
Good morning, I will email you from my work email and will reference this .

Hi @giveen, I see your mail, in that the Workspace ID and sub key has been shared, actually to access it from backend we don't have required permission.
So, can we have a quick call on 22 Oct? In a call we will check the template which we have shared are correctly deployed and will check connection.
Meantime, could you please confirm once the ORG ID is correct? because with API key in second script you can see the results.
Thanks!

Hi @giveen, I see your mail, in that the Workspace ID and sub key has been shared, actually to access it from backend we don't have required permission. So, can we have a quick call on 22 Oct? In a call we will check the template which we have shared are correctly deployed and will check connection. Meantime, could you please confirm once the ORG ID is correct? because with API key in second script you can see the results.
Thanks!

I have confirmed the org id matches my records and go ahead and send me a teams invite.

Hi @giveen, Due to conflict in Time, let us check and match the meeting availability which suits for both the Time zones:
Meantime, I'm sharing some steps which I was thought to do in call itself. So, could you please follow below steps and let me know if it resolves the issue :

Please go to Content Hub and Uninstall / delete the existing solution:

Go to the Data Connector blade page and delete that Cisco Meraki connector manually, refer below screenshot to delete it :

Now do the custom deployment of the Main template file which has been already mentioned in previous comment -

https://github.com/Azure/Azure-Sentinel/issues/11248#issuecomment-2405010322
https://github.com/Azure/Azure-Sentinel/issues/11248#issuecomment-2406670978

Custom Deployment - CustomDeploymentSteps.docx
Template File - mainTemplate.json
The previous deployment may have not overwrite the data connector and maybe due to that reason the 404 same issue occurred.
Please follow the above steps and let us know your response, so if required we will forward this issue to our concern team to address the issue.
Thanks!

I removed the connectors

I deployed the template

Verified successful deployment

Made sure my API from Meraki matched

Made sure the API key worked and it returned my org ID

Set up the org ID and API in the data connector

Failed. Same Error

@v-sudkharat I'm curious if the reason why maybe its failing is because CiscoMerakiIDS logs dont exist on my end? I'm reaching out to my network engineers to ask if we have IDS on our Meraki XR

@giveen, Sure please.
And could you please confirm did you follow this step as well?

Note: If not, then the new deployed template will not work as it does not overwrite the existing connector, So if not done then please check with following that one and test.
OR you can also deploy the shared template in a new workspace where there is not already cisco Meraki solution has been deployed.
Thanks!

@v-sudkharat yes, I made sure that it was gone from Data Connectors before adding it. I had to go into the resource group and delete it manually since doing it from within Sentinel itself gave an delete error.

@v-sudkharat I've confirmed with our Network team that our Meraki XRs do have NIDS

Running into the same problem as you are facing here. Just wondering, would this have anything to do with permissions on the account that has generated the API key? Interested to know if this is down to permissions to why data can't be pulled back. Could you confirm what you have set on yours please @v-sudkharat

Hi @giveen / @sh4d0wl0ck, Could you please open an azure support case, so this issue can be check by our concern data collection team and if required take a call with you.
Please do share the case Id. Thanks!

@giveen, Could you please share the ticket id with us to follow up on it. Thanks!

Hi @giveen, Gentle Reminder: We are waiting for your response on this issue. If you still need to keep this issue active, please respond to it in the next 2 days. If we don't receive a response by 13-11-2024 date, we will be closing this issue.
Thanks!

Hi, so I dont think I have the ability to put in support tickets for Azure,
per my talk with our system operations guy. Seems like we havent paid for
that support.
On Mon, Nov 11, 2024 at 4:46 AM v-sudkharat @.***>
wrote:

Hi @giveen https://github.com/giveen, Gentle Reminder: We are waiting
for your response on this issue. If you still need to keep this issue
active, please respond to it in the next 2 days. If we don't receive a
response by 13-11-2024 date, we will be closing this issue.
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/Azure-Sentinel/issues/11248#issuecomment-2467979281,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJAKC5KUASYEML5UVQSJD32ACKJTAVCNFSM6AAAAABPVF7OF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRXHE3TSMRYGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@giveen, Noted. let us check with our team if have any alternates. Thanks!

@giveen,
We have initial check in Cisco Meraki end, the 404 is due to the incorrect ORG ID has been entered while configuration of Data connector.
So, could you please find out the correct ORG ID and its API key from below shared steps and add it into the connector-
A. For ORG ID-

Login to Cisco Meraki Dashboard - https://account.meraki.com/login/
Go to the setting -

In Setting scroll down to page -

You will get the ORG ID here -

B. For API Key -

Go to My profile -

Check for the API KEY -

NOTE: The ORG ID are correctly mapped to API KEY, and also please check for the If multiple ORG have into the cisco side.
Thanks!

@giveen / @sh4d0wl0ck , Did you get a change to check on above comment. Thanks!

Yes I did. I'm 100% certain I have the correct org ID
On Thu, Nov 21, 2024, 2:43 AM v-sudkharat @.***> wrote:

@giveen https://github.com/giveen / @sh4d0wl0ck
https://github.com/sh4d0wl0ck , Did you get a change to check on above
comment. Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/Azure-Sentinel/issues/11248#issuecomment-2490588877,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJAKC4BNMH57AN3QMPPPL32BWTKVAVCNFSM6AAAAABPVF7OF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJQGU4DQOBXG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Running into the same problem as you are facing here. Just wondering, would this have anything to do with permissions on the account that has generated the API key? Interested to know if this is down to permissions to why data can't be pulled back. Could you confirm what you have set on yours please @v-sudkharat

@giveen, Noted
@sh4d0wl0ck, After following the steps mentioned here - https://github.com/Azure/Azure-Sentinel/issues/11248#issuecomment-2482953550 , still facing issue?

@sh4d0wl0ck
@v-sudkharat  and I were able to determine that it was a permissions on the Meraki side. He isnt sure what permissions are needed, I'm going to work with my network engineer and see if I can either determine what permissions are needed or if they can generate an API key for me that will work from their higher level.

@giveen, Ok. Please let us know once it gets done. Thanks!

@giveen, Any update for us?

I spoke to my network engineer and he needs to research what permissions are needed for the API key and that not going to happen till after the new year, so I have a service request ticket in with him. So now I'm at the mercy of their schedule.

@giveen, Thanks for response.
Could you please let us know can we close this ticket as the issue with account and its permissions and not with connector? your confirmation required for ticket closer. Thanks!


[Xamarin.Android.Build.Tasks] close XAAssemblyResolvers

Context: https://discord.com/channels/732297728826277939/732297916680765551/1308554103206580244
Fixes: https://github.com/dotnet/android/issues/9133
Context: 86260ed3
Various customers have been reporting UnauthorizedAccessExceptions in incremental builds, which seems to be a new problem in .NET 9. We were not able to reproduce the issue locally, but with the number of reports it seems to be a real issue.
One customer shared a MSBuild.dmp file (while the file was locked), where I could observe the objects in memory:
MemoryMappedViewStream	132
    Mono.Cecil.PE.Image	100
        Mono.Cecil.ModuleDefinition	100
            Mono.Cecil.TypeDefinition	100
                Mono.Cecil.TypeDefinition[]	100
                    List<Mono.Cecil.TypeDefinition>	1
                        Xamarin.Android.Tasks.NativeCodeGenState [Static variable Xamarin.Android.Tasks.NativeCodeGenState.<Template>k__BackingField]	1

Then realized the problem was:

We opened some .dll files with Mono.Cecil.

They were never closed.

Future incremental build attempts would fail on various operations of the same .dll files.

We were also storing some static state (NativeCodeGenState) to be shared across multiple MSBuild tasks:
public static NativeCodeGenState? Template { get; set; }

NativeCodeGenState also holds a XAAssemblyResolver in a Resolver property. This means this XAAssemblyResolver instance would also be kept alive.
It appears we only use the static Template property for a bool flag, so I changed the property to a bool instead.
After this change, we can safely dispose Resolver instances. I looped over the NativeCodeGenState instances disposing of each Resolver at the end of the <GenerateJavaStubs/> MSBuild task.

Actually, there might be a test failure:
Mono.Android.NET_Tests, Java.InteropTests.InvokeVirtualFromConstructorTests.ActivationConstructor
Java.Lang.UnsatisfiedLinkError : No implementation found for void net.dot.jni.test.CallVirtualFromConstructorDerived.calledFromConstructor(int) (tried Java_net_dot_jni_test_CallVirtualFromConstructorDerived_calledFromConstructor and Java_net_dot_jni_test_CallVirtualFromConstructorDerived_calledFromConstructor__I)


How to select the best model?

Hi, thanks for your good research. Is it determined by observing the val_recon_loss to select the best model?

Since we found out that it was difficult to choose a model based on loss curves, we manually listened to the audio samples.

@LEEYOONHYUNG Hi, I have another question. Why does align_loss rise and duration_loss fall in training?


Latest Node.js version incomaptible?

now node version 10.4
what is node version?

The latest version of Node.js, which is currently 10.7.0, seems to be incompatible with the dependencies used by the Barefoot monitor. The error is as follows:
error: no member named 'ForceSet' in 'v8::Object'   return obj->ForceSet(GetCurrentContext(), key, value, attribs);

The LTS version of Node.js is 8.11.3 and the current version is 10.7.0. The latter has some incompatibility with the ZeroMQ binding, the former (LTS) works fine.

@wangziyuruc Does it solve the issue for you?

yeah ! its ok


Add SkipFields option

Adds a SkipFields option which omits the given fields from standard output. This is useful if you have a CloudWatch hook and want certain fields to be included in the CloudWatch logs, but not in the standard output.
For my circumstance, I omitted correlation ID equivalent fields, which are useful in logs, but is excessive detail in the standard output.

Pull Request Test Coverage Report for Build 50

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 48:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls

By the way, I have recently stumbled upon a similar issue. But, I found the approach of deleting message fields at the message formatting stage incorrect by design for a generic message formatter.
A specialized formatter in Hook with a limited and tailored functionality will do things faster and cleaner than the generic one with many options to consider.
Also, sometimes it's possible to use a more suitable logging context, without fields to skip.
@antonfisher IMO, we can close this PR without merging.


Graphics improperly extends DisplayObject

Hi there,
Looks like the signature for Graphics.generateTexture doesn't match that of DisplayObject.generateTexture. This is an issue for typescript compilation (see pixi.d.ts).
Thanks for the awesomeness y'all.

Experienced the same problem when I tried to update to the latest version of Phaser.

Suggested fix? Because PIXI.DisplayObject.generateTexture returns a RenderTexture, where-as PIXI.Graphics.generateTexture_does_ return Texture`. So they are actually different.

Then is it possible to rename Graphics.generateTexture? The current implementation prevents typescript compilation  from succeeding.

I wish I was back on game work :(
Reminds me of my old stack question. http://stackoverflow.com/questions/29593905/typescript-declaration-extending-class-with-static-method/29595798#29595798
declare class DisplayObject {
    static generateTexture(): RenderTexture;
}

Include the same signature from the primary above to the other class and overload it.
declare class Graphics extends DisplayObject {
    static generateTexture(): RenderTexture;
    static generateTexture(): Texture;
}

Does it work?

Overloading the function sounds like a reasonable solution to me.

"Include the same signature from the primary above to the other class and overload it."

Except that both signatures would be visible and the 1st signature (from base class) wouldn't ever actually work as described. Renaming the PIXI.Graphics.generateTexture() might be best.

Yeah totally but that is a different issue.  What you see today in JS is valid and correct JS. If TypeScript cannot define it, then you must work around it.
If you want to change the implementation, you have the much bigger job of making a PR which is going to be bug free, and not break 1000 peoples existing games for the sake of a function overload.

Hmm. Valid javascript or not, it's a flawed design. Either Graphics derives from DisplayObject or it does not. If it does, it must provide a working definition of DisplayObject.generateTexture. Typescript is simply enforcing proper design.
I'm not sure what precipitated the original change to the signature of DisplayObject.generateTexture, but you might want to reconsider...

Yeah I am having this issue even when rolling back to 2.4.6. I tried that function overloading recommendation and didn't seem to work. I am also wondering if this has anything to do with the misbehaving of the cursor when changing to a hand when over a graphic.

@smks - i modified the Graphics signature to match that of DisplayObject and I'm working ok...though I'm exercising very little of the engine.

This is kinda a blocker for me right now. @shinygruv3 How did you get it working exactly?

@JimmyBoh - I modified ../phaser/typescript/pixi.d.ts locally and changed the signature of Graphics.generateTexture to match that of DisplayObject.generateTexture:
generateTexture(resolution?: number, scaleMode?: number, renderer?: PixiRenderer): RenderTexture;

Awesome, thanks @shinygruv3. I'm just starting a new project with Phaser. It's small, but I will share any issues or oddities I encounter.

This is now fixed in the dev branch. Well, I say 'fixed', the defs are basically reverted back to how they were before. So the TS compilation errors are done, but the return type is technically incorrect. Then again, it has been for several years now and no-one complained, so such is life.

@shinygruv3 Your turnaround is not working for me :(


unresolved import

I am trying to import the Module windows::Security::Credentials with the following statement into my Tauri application:
use windows::{
    Win32::Security::Credentials::*,
};

The following code is my full main.rs file:
#![cfg_attr(
    all(not(debug_assertions), target_os = "windows"),
    windows_subsystem = "windows"
)]

use windows::{
    Win32::Security::Credentials::*,
};

#[tauri::command]
fn greet(name: &str) -> String {
    format!("Hello, {}! You've been greeted from Rust!", name)
}

#[tauri::command]
fn checkWindowsHello() -> String {
    let result = KeyCredentialManager::IsSupportedAsync();
    if (result) {
        let authenticationResult = KeyCredentialManager::RequestCreateAsync("login", KeyCredentialCreationOption::ReplaceExisting);
        if (authenticationResult.Status == KeyCredentialStatus::Success) {
            format!("User is logged in");
        } else {
            format!("Login error: {}", authenticationResult.Status);
        }
    }
}

fn main() {
    tauri::Builder::default()
        .invoke_handler(tauri::generate_handler![greet])
        .run(tauri::generate_context!())
        .expect("error while running tauri application");
}

My error:
--> src\main.rs:7:22
  |
7 |     Win32::Security::Credentials::*,
  |                      ^^^^^^^^^^^ could not find "Credentials" in "Security"`

I am new to rust, can anyone help me on my issue?

Hi @LukasKarer, can you post your Cargo.toml? Sounds like you forgot to add the Security_Credentials feature as listed in the docs.

This is my Cargo.toml: `[package]
name = "pdfViewer"
version = "0.0.0"
description = "A Tauri App"
authors = ["you"]
license = ""
repository = ""
edition = "2021"
rust-version = "1.57"
See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
[build-dependencies]
tauri-build = { version = "1.0.0", features = [] }
[dependencies]
serde_json = "1.0"
serde = { version = "1.0", features = ["derive"] }
tauri = { version = "1.0.0", features = ["api-all"] }
[dependencies.windows]
version = "0.39.0"
features = [
"Win32_Security"
]
[features]
by default Tauri runs in production mode
when tauri dev runs it is executed with cargo run --no-default-features if devPath is an URL
default = [ "custom-protocol" ]
this feature is used used for production builds where devPath points to the filesystem
DO NOT remove this
custom-protocol = [ "tauri/custom-protocol" ]
`
Do I need to add Security_Credentials to the features list of dependencies.windows?

Three backticks (```) are needed for code blocks. And yep, you can cut/paste what's needed in the docs you linked.

Thank you for your quick help. It is working now.
Also thanks for giving the tip with the Three backticks (```).


Improvements to API, discord, example, varints, deps, and bug fixes

Looks great :)
As far as fleshing out the Chat object deserialization, there are Rust implementations here and here if we'd rather depend on someone else for that.
I've never seen usage of the chat component in the ping reply, though, so it's definitely not urgent.


soc: atmel: sam0: Add bossac boot mode support.

Support loading the boot mode from retained memory and triggering a jump to the bossac bootloader when requested.
This implemented the bare minimum to support bootloader boot mode on SAM0 devices using the BOSSAC bootloader. In particular, this was tested on a small samd21e18 based device of mine with the following added to the devicetree:
/ {
        sram@20007FFB {
                compatible = "zephyr,memory-region", "mmio-sram";
                reg = <0x20007FFB 0x5>;
                zephyr,memory-region = "RetainedMem";
                status = "okay";

                retainedmem {
                        compatible = "zephyr,retained-ram";
                        status = "okay";
                        #address-cells = <1>;
                        #size-cells = <1>;

                        retention0: retention@0 {
                                compatible = "zephyr,retention";
                                status = "okay";
                                reg = <0x0 0x1>;
                        };
                        retention1: retention@1 {
                                compatible = "zephyr,retention";
                                status = "okay";
                                reg = <0x1 0x4>;
                        };
                };
        };

        chosen {
                zephyr,boot-mode = &retention0;
		zephyr,bossac-double-tap-magic = &retention1;
        };
};

/* Reduce SRAM0 usage by 1 byte to account for non-init area */
&sram0 {
        reg = <0x20000000 0x7FFB>;
};

Note: The reserved 4-bytes at the end of the SRAM is used by the bootloader, and in particular, is cleared by the bootloader on start (see https://github.com/adafruit/uf2-samdx1/blob/master/src/main.c#L138) so we need to place our boot mode just before this so it's not wiped away by the bootloader.
Since we're doing this on top of the retained API anyways, I updated the code that needs to assign the "magic value" to use the retained API to do so and leverages the second entry. I picked a chosen value of zephyr,bossac-double-tap-magic but I'm definitely open to better naming ideas. If folks would rather I note do that here, I will need some sort of logic to determine the right memory address for where to place this. My initial version was hardcoding a + 5 to the SRAM calculation that exists already, but this felt like a hack.
I'm also not sure the "correct" way to document this, so please do let me know.
Thanks as always, looking forward to feedback.

Hi @petejohanson ,
All the changes on BOSSAC will be carefully checked and this takes times due to complexity around.

Hi @petejohanson ,
In the meantime, you can check and update documentation here. https://github.com/zephyrproject-rtos/zephyr/blob/7271000fe56c75536831741d46ef225d08a34f3a/doc/develop/flash_debug/host-tools.rst?plain=1#L17


filterTwoArguments not working

it looks like filterTwoArguments doesn't work.
db.search([
    {
        subject: user,
        predicate: 'like',
        object: db.v('liked')
    },
    {
        subject: db.v('someone'),
        predicate: 'like',
        object: db.v('liked'),
        filter: function (triple, cb) {
            cb(null, triple);
        }
    }
])

what i'm trying to do is to filter out all the things already liked by user.  i realize that i can do this with a filter on the results but i was thinking that maybe it's better for performance to filter on the query rather than the results but i'm open to hearing that it's not.

Hello! I am here because I replicated the problem originally posted. Interestingly, this works for me:
db.search([
{
subject: db.v('someone'),
predicate: 'like',
object: db.v('liked'),
filter: function (triple, cb) {
cb(null, triple);
}
},
{
subject: user,
predicate: 'like',
object: db.v('liked')
}
])
I was able to replicate this with many examples. As long as there were no filters after the first triple, I got results. If there was a filter in any triple other than the first, the search never resolves. I also tested filtering full solutions and there were no problems there. Also interesting: the filters at the triple scope are always executed, and the full solution filter is also executed. Despite this, the search still does not resolve if there was a filter in any but the first triple in the search.
Working Example:
db.search([
{
subject: db.v('someone'),
predicate: 'like',
object: db.v('liked'),
filter: function (triple, cb) {
cb(null, triple);
}
},
{
subject: user,
predicate: 'like',
object: db.v('liked')
}
], {
filter: function(solution, callback) {
callback(null, solution);
}
})
Broken Example:
db.search([
{
subject: user,
predicate: 'like',
object: db.v('liked')
},
{
subject: db.v('someone'),
predicate: 'like',
object: db.v('liked'),
filter: function (triple, cb) {
cb(null, triple);
}
}
], {
filter: function(solution, callback) {
callback(null, solution);
}
})


[Feature] 64-bit?

Is it planned to get 64-bit support added?

"Its not currently on our radar, but it shouldn't be too much of a problem. Most (all?) of the instruction translation is parametrized by bit width. The big changes that would be needed is finding and removing some 32-bit-isms, adding new registers, and probably 64-bit calling convention/stack layout for some of the callback/external call stuff."

How hard would it be to add ARM support? Comparable to adding 64bit support or some deeper changes in the framework are required?

64-bit support is now merged.


Cherry-pick #301 to master: Fix Actor.cc copy operators and restructure tests

Cherry-pick of #301 to master. Use rebase and merge.
Fix Actor.cc copy operators and restructure tests (#301)

Simplify and fix copy constructors, restructure tests and increase coverage
Add joint and link tests
Add changelog

Signed-off-by: Luca Della Vedova<EMAIL_ADDRESS>Co-authored-by: Ian Chen<EMAIL_ADDRESS>Co-authored-by: Steve Peters<EMAIL_ADDRESS>

Codecov Report

Merging #346 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   87.38%   87.41%   +0.03%
==========================================
  Files          60       60
  Lines        9319     9315       -4
==========================================
  Hits         8143     8143
+ Misses       1176     1172       -4

Impacted Files
Coverage Δ

src/Actor.cc
85.79% <100.00%> (+1.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706f867...b3dfe1e. Read the comment docs.


'Authorization' header needs to have initcap

Some servers won't authenticate with 'authorization' header, it needs to be 'Authorization'...

-1 on forcing the header to init-caps, servers that require this are in clear violation of the spec.  Also the Node.js convention for HTTP headers is lower-case.
We've had similar issues with the Host header (see #1211).  The approach we took there is to allow users to specify a Host header manually, and if they do, remember the case they used across redirects.  I like this better because it calls attention to the broken servers and encourages them to be fixed.
Try specifying { headers : { 'Authorization' : 'dummy' } } in your request options along with your auth credentials.  The module we use to manage HTTP headers, caseless, will preserve header case if a header already exists.  This should work for now (perhaps not across redirects).
+1 to documenting and testing a similar approach going forward, can you create a separate issue on this for further discussion?

@nylen tnx.
Note that this trick does not work for redirects as the auth header is cleared after the first request.
Also there are a couple of other places in request.js where Authorization is with init-cap ;)

Interesting find.  I try to follow precedent set before I was involved with this project, for example https://github.com/request/request/issues/411#issuecomment-53656998.


Flutter Fire CLI output and input broken

I have tried to initialize my current project and a new clean project but the output and input in the terminal is broken for me.
When I run flutterfire configure it starts fetching the available projects but it behaves strangely, this is the output.
?[A?[2K⠦ Fetching available Firebase projects...
?[A?[2K⠧ Fetching available Firebase projects...
?[A?[2K⠇ Fetching available Firebase projects...
?[A?[2K⠏ Fetching available Firebase projects...
?[A?[2K⠋ Fetching available Firebase projects...
?[A?[2K⠙ Fetching available Firebase projects...
?[A?[2K⠹ Fetching available Firebase projects...
?[A?[2Ki Found 2 Firebase projects.
?[?25h
?[?25l
example-staging (example-staging)
<create a new project>
I’m not able to input anything when it is done fetching and I have to terminate the CLI. Running the firebase CLI is working fine. It also finds two projects but it only shows one of them.
I'm on Windows 10, version 21H2

Closing as duplicate of #34

This issue as not been solve.


Site Standard missing on 2nd root folder

When adding a second root Folder with a SiteStandard to a Workflow, then the SiteStandard is missing from JSON dump.

Hi, i can't reproduce the issue, can you provide a small sample of code to reproduce it?


feat: use pnpm dlx instead of pnpx

close:  #24
see: https://pnpm.io/cli/dlx

Please disable prettier and revert the format changes. Thanks.


feat(protocol): trigger minor bump for commit 4dac072

no changed file in this PR

no changed file in this PR

I thought this empty commit would trigger release-please for Yue's change but I realized it won't work, because the tool won't detect a diff in packages/protocol. Will close it


rust-analyzer.serverPath affects both local and remote instances

If you set rust-analyzer.serverPath, it takes effect for both local and remote instances.
This is highly unlikely to be correct.  serverPath could conceivably be different for every single remote host.
For starters, a new variable called remoteServerPath probably needs to come into existence.
However, rather than a simple filepath, it probably eventually needs to become a list which keeps (hostname, serverPath) pairs.
Thanks.

For starters, a new variable called remoteServerPath probably needs to come into existence.

I don't think so. In Code extensions can run locally or on the remote. If you want a remote extension, you'll have to install it there and it will run in a headless Code instance without caring whether you're connecting remotely or not.
If you want different LSP server paths on different computers, you can use a workspace settings file. But I don't see why that's necessary -- you should put the binary somewhere in PATH instead.

But I don't see why that's necessary -- you should put the binary somewhere in PATH instead.

That's fine, but rust-analyzer needs to not be incorrectly clever when it doesn't recognize the architecture.  Quoting from issue #4699

The bug seems to be in the local plugin in rust-analyzer/editors/code/out/main.js in getServer
For some reason, the code drops through the
if (config.package.releaseTag === null)
    return "rust-analyzer";

serverPath was the workaround to this problem.

You can use "rust-analyzer.serverPath": "rust-analyzer" and make sure the server is in PATH, at the cost of losing auto-updates on the local side.

I have manually installed the analyzer using cargo:
niid@DESKTOP-9OF9U33:~/projects/rust-book/minigrep$ which rust-analyzer-linux
/home/niid/.local/bin/rust-analyzer-linux
And I have set "rust-analyzer.serverPath" to "rust-analyzer-linux", but the extension tries to download it anyway and ignores the binary in PATH?

same problem here, now that I have set serverPath I can't use rust-analyzer locally anymore :(
not sure I understand your solution @lnicola

The overeager arch detection was fixed in https://github.com/rust-analyzer/rust-analyzer/pull/7194. I'm going to close this, but please reopen or file another issue if required.

The overeager arch detection was fixed in https://github.com/rust-analyzer/rust-analyzer/pull/7194. I'm going to close this, but please reopen or file another issue if required.


Change usage of IReadOnlyList to IEnumerable in C# API

This will allow compilation to target .NET 4.0

IReadOnlyList is used in the database template.

.NET 4.5 is a reasonable target at this point so closing issue.


Develop

@ryandbair This bad boy is ready now.

Compiler error here:
[error] /home/rbair/src/trafficland/elblogparser/src/main/scala/com/trafficland/elblogparser/AppInfo.scala:3: object typesafe is not a member of package com [error] import com.typesafe.config.ConfigFactory

I must have run that task manually at some point when I was testing. That generator does not and should not run automatically.
This is all set.


fix: restore ability to catch broken scanner

Prior to the configmap changes, there was an e2e test, collector_ensure_scan designed to catch when the scanner is broken. The reason this is needed is that when the scanner isn't functioning properly, and deleteFailedImages is set to true, then scanning of all images will fail.
Because in most tests we delete those images for which scanning failed, this will create a false positive: all images will be removed, instead of just the vulnerable ones. That makes it impossible to tell whether or not the tests should be passing, because deleting all images will remove the vulnerable images along with the safe ones.
This PR restores the test to a working state, and is critical to catch when we break the scanner.
I have manually tested and confirmed that the modified test fails when the scanner is broken.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #
Special notes for your reviewer:

Codecov Report

Merging #706 (b37b2a1) into main (84fe191) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   14.58%   14.58%
=======================================
  Files          13       13
  Lines        1694     1694
=======================================
  Hits          247      247
  Misses       1419     1419
  Partials       28       28

Flag
Coverage Δ

unittests
14.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

test/e2e/util/utils.go
6.44% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


goreleaser options need updating

--rm-dist has been deprecated in favour or --clean, see https://github.com/open-telemetry/opentelemetry-collector-releases/actions/runs/5062625852/jobs/9088345803#step:12:21

Fixed by #342 :)

thanks for pre-fixing my issue @mx-psi  :D


Adding basic Document-Detail Page

This adds a basic document detail page for us to build on. Missing molecules and organisms are in the To Do notes.
Additions

Adds Document Detail Page

Review

@anselmbradford
@jimmynotjim
@sebworks

:+1:

:+1:


<EMAIL_ADDRESS>not supported

Title pretty much sums it up

Hi @oliversalzburg,
Thank you for reporting the problem. Currently the plan is that I will archive the project, because typedoc has added this functionality with document tag.
Please check out the functionality and if there are no issues with it please use that. If for some reason it is not satisfactory please reopen the ticket and I will add the support.
See the description:
The @document tag can be placed in the comments for most types to add a child to that reflection in the generated documentation. The content of the @document tag should simply be a path to a markdown document to be included in the site.

/**
 * @document documents/external-markdown.md
 */
The document path is relative to the file in which the comment appears in.


[#115858399] Document steps to set up a ci, staging or prod environment

What
There are a few differences when deploying to non-dev accounts. This
pulls these details out into a separate document.
How to review
Check that the new docs are clear, and cover the necessary details.
Who can review
Anyone but myself.

LGTM... but not merging just yet to give others time to review.

LGTM, I would merge.


Crash when opening save

When i try to open my savegame of Re-Reckoning with the v.3.0.251 it automatically crashes the editor and closes it.
What's strange about it is that it affects every one of my saves, except the very first one i made just after speaking to Agarth upon exiting the tower at the start of the game.
At first i thought that it was because of the gamesave compression problem, but apparently it was fixed in the last update, so i'm opening this issue.
Here is the stacktrace that i get in Windows event manager after each crash :
Application: KoAR.SaveEditor.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: System.ArgumentOutOfRangeException    at System.ThrowHelper.ThrowArgumentOutOfRangeException(System.ExceptionArgument)    at KoAR.Core.ItemBuffMemory..ctor(KoAR.Core.GameSave, KoAR.Core.Item, Int32, Int32)    at KoAR.Core.Item..ctor(KoAR.Core.GameSave, Int32, Int32, Int32, Int32, Int32, Int32, Int32)    at KoAR.Core.GameSave..ctor(System.String)    at KoAR.SaveEditor.Views.Main.MainWindowViewModel.OpenFile()    at System.Windows.Input.CommandBinding.OnExecuted(System.Object, System.Windows.Input.ExecutedRoutedEventArgs)    at System.Windows.Input.CommandManager.ExecuteCommandBinding(System.Object, System.Windows.Input.ExecutedRoutedEventArgs, System.Windows.Input.CommandBinding)    at System.Windows.Input.CommandManager.FindCommandBinding(System.Windows.Input.CommandBindingCollection, System.Object, System.Windows.RoutedEventArgs, System.Windows.Input.ICommand, Boolean)    at System.Windows.Input.CommandManager.FindCommandBinding(System.Object, System.Windows.RoutedEventArgs, System.Windows.Input.ICommand, Boolean)    at System.Windows.Input.CommandManager.OnExecuted(System.Object, System.Windows.Input.ExecutedRoutedEventArgs)    at System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate, System.Object)    at System.Windows.RoutedEventHandlerInfo.InvokeHandler(System.Object, System.Windows.RoutedEventArgs)    at System.Windows.EventRoute.InvokeHandlersImpl(System.Object, System.Windows.RoutedEventArgs, Boolean)    at System.Windows.UIElement.RaiseEventImpl(System.Windows.DependencyObject, System.Windows.RoutedEventArgs)    at System.Windows.Input.RoutedCommand.ExecuteImpl(System.Object, System.Windows.IInputElement, Boolean)    at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(System.Windows.Input.ICommandSource, Boolean)    at System.Windows.Controls.Primitives.ButtonBase.OnClick()    at System.Windows.Controls.Button.OnClick()    at System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(System.Windows.Input.MouseButtonEventArgs)    at System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate, System.Object)    at System.Windows.RoutedEventHandlerInfo.InvokeHandler(System.Object, System.Windows.RoutedEventArgs)    at System.Windows.EventRoute.InvokeHandlersImpl(System.Object, System.Windows.RoutedEventArgs, Boolean)    at System.Windows.UIElement.ReRaiseEventAs(System.Windows.DependencyObject, System.Windows.RoutedEventArgs, System.Windows.RoutedEvent)    at System.Windows.UIElement.OnMouseUpThunk(System.Object, System.Windows.Input.MouseButtonEventArgs)    at System.Windows.RoutedEventArgs.InvokeHandler(System.Delegate, System.Object)    at System.Windows.RoutedEventHandlerInfo.InvokeHandler(System.Object, System.Windows.RoutedEventArgs)    at System.Windows.EventRoute.InvokeHandlersImpl(System.Object, System.Windows.RoutedEventArgs, Boolean)    at System.Windows.UIElement.RaiseEventImpl(System.Windows.DependencyObject, System.Windows.RoutedEventArgs)    at System.Windows.UIElement.RaiseTrustedEvent(System.Windows.RoutedEventArgs)    at System.Windows.Input.InputManager.ProcessStagingArea()    at System.Windows.Input.InputManager.ProcessInput(System.Windows.Input.InputEventArgs)    at System.Windows.Input.InputProviderSite.ReportInput(System.Windows.Input.InputReport)    at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr, System.Windows.Input.InputMode, Int32, System.Windows.Input.RawMouseActions, Int32, Int32, Int32)    at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr, MS.Internal.Interop.WindowMessage, IntPtr, IntPtr, Boolean ByRef)    at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)    at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)    at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object)    at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)    at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)    at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)    at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)    at MS.Win32.UnsafeNativeMethods.DispatchMessage(System.Windows.Interop.MSG ByRef)    at System.Windows.Threading.Dispatcher.PushFrameImpl(System.Windows.Threading.DispatcherFrame)    at System.Windows.Application.RunDispatcher(System.Object)    at System.Windows.Application.RunInternal(System.Windows.Window)    at KoAR.SaveEditor.App.Main()

Could you send a faulting save file?

Sure, here is the most recent one that crashes (had to zip it since github doesn't allow the .sav format)
svd_fmt_5_6.zip

Hello there! I've got quite the same problem. The editor crash when I try to load a save but not the first ones (before 1/2 hour of gameplay).
save.zip
(I think I crash after the 5th save)

@RedKitsune I think I see the issue. Your version of the Song is the first item I've ever seen using the inactive buff section of the item buff area. Meaning that the mana stealing it offers is a straight lie. I'll have to add some support for this, older versions of the editor would only read the active buff list, but I recently added support for affix modification which likely is when the crash started happening.
@PoroSnax , are you using a 3.x release? I'm guessing the issue you're running 2.x release which is erroring as soon as it encounters the stash in the remaster. Also, in the future only include one save file.

@RedKitsune I think I see the issue. Your version of the Song is the first item I've ever seen using the inactive buff section of the item buff area. Meaning that the mana stealing it offers is a straight lie. I'll have to add some support for this, older versions of the editor would only read the active buff list, but I recently added support for affix modification which likely is when the crash started happening.
@PoroSnax , are you using a 3.x release? I'm guessing the issue you're running 2.x release which is erroring as soon as it encounters the stash in the remaster. Also, in the future only include one save file.

I'm using the latest 3.x release


Create translation of 01-the-shell.md lesson in french

@Funsaiki would you kindly ask a colleague to review the translation and leave a comment or code review here?
Je ne parle pas français :|

@Funsaiki would you kindly ask a colleague to review the translation and leave a comment or code review here? Je ne parle pas français :|

done by deepyjr


my first revup bar

Topic: bar

Reviews in this chain:
└https://github.com/dukeofcool199/revup/pull/2 my first revup bar


connect mobiles sensor to simulator/browser in plyer

add a facade to plyer when running on desktop simulator ( cpu!=wasm and platform==emscripten), use websocket to transfer sensors

WIP https://github.com/pygame-web/pkg-porting-wasm/issues/33


Container image building and publishing

Description

This enables building and publishing container images to quay.io/tinkerbell. GitHub actions and Goreleaser are set up to create and publish container images based on Git tags.
This could potentially be an example repo for how we could handle versioning. See proposal 0002.
CC: @displague
Why is this needed

Fixes: #22
How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

This is super old. Is it still relevant?

This is super old. Is it still relevant?

It is definitely old. It needs a revisit code wise (merge main, possibly update versions, etc) and i'd still like to see it incorporated.

no cycles for this. will re-open if/when i do.


dart2js: incomplete test for Iterable

This program does not throw a TypeError when compiled with --strong:
foo(Iterable<int> a) {
  print(a);
}

main() {
  dynamic f = foo;
  f(<String>['hi']);
}

The generated code calls listSuperNativeTypeCheck:
    function(a) {
      H.printString(H.S(H.listSuperNativeTypeCheck(a, "$isIterable")));
    },

It is probably best to simply always avoid listSuperNativeTypeCheck, since it can't handle type arguments, and contains two getInterceptor calls. The logic for picking the 'optimized' xxxTypeCheck is based on the Dart 1 libraries many years ago.

Fixing this is blocked on https://github.com/dart-lang/sdk/issues/32829.
If we fix the 'is Iterator' test, then the sync* Iterables will fail.

@rakudrama I wonder if we can close this now (is https://github.com/dart-lang/sdk/commit/bcc5e6ed42dba676dad66c0182bea58e3b2ad7cb the entire fix, or is there more to follow up here?)


Remove horde

Remove Horde since this product has been deprecated by Bitnami.

@mdhont : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mdhont Thank you for your contribution and for catching that, we really appreciate it. #sign-off


How to create your own maps?

Hello. Please, help me to understand, how can I create new maps? There are Town 01 and 02 in RoadMaps by default, but if I want to try a track, for example?
Is there some way to do that?
Or maybe I can find somewhere already created maps?

@TheNihilisticRobot
Hi! Thanks for you work and your answer!
I meant with track something about motorway, like that.
For example, I found video (https://www.youtube.com/watch?v=fQ-2ds-aInU) which states that Carla was used. How did they create their map? Can Unreal Engine Level Editor helps me with that?
Also there are two .png files with map structure in projects, can't I edit that structure?
Also there is only one file in Content folder (CarlaUE4-LinuxNoEditor.pak) in pre-built package. Do I need to built from sources?

whether the road of your map is follow opendrive xml format? Or there is a way that extract the road information from your map and convert to opendrive format?


Setting Height and Width for Figure Shortcode not working porperly

I was trying to set the Height and Width for the Figure-shortcode but it doesn't work properly.
the Style is taking precedence over the Attribute and as you can see in the code, height and width are both set to auto.
I added two screenshots from DevTools.

Ok, never mind, turned out this is in the learn theme, there is javascript adding auto width and height to images.


Show limit

Does not show all assets (
Performance warning: There are more than 100 preview scenes. There might be code not releasing the preview scene after creating it.
UnityEditor.GameObjectInspector:RenderStaticPreview (string,UnityEngine.Object[],int,int)
RoyTheunissen.AssetPalette.PaletteAsset:get_PreviewTexture () (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/Entries/PaletteAsset.cs:74)
RoyTheunissen.AssetPalette.CustomEditors.PaletteAssetDrawer:DrawContents (UnityEngine.Rect,UnityEditor.SerializedProperty,RoyTheunissen.AssetPalette.PaletteAsset) (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/CustomEditors/PaletteAssetDrawer.cs:18)
RoyTheunissen.AssetPalette.CustomEditors.PaletteEntryDrawer`1<RoyTheunissen.AssetPalette.PaletteAsset>:OnGUI (UnityEngine.Rect,UnityEditor.SerializedProperty,RoyTheunissen.AssetPalette.PaletteEntry) (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/CustomEditors/PaletteEntryDrawer.cs:98)
RoyTheunissen.AssetPalette.CustomEditors.PaletteDrawing:DrawGridEntry (UnityEngine.Rect,UnityEditor.SerializedProperty,RoyTheunissen.AssetPalette.PaletteEntry) (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/CustomEditors/PaletteDrawing.cs:52)
RoyTheunissen.AssetPalette.Windows.EntryPanel:DrawGridEntry (int,int,bool&) (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/Windows/EntryPanel.cs:406)
RoyTheunissen.AssetPalette.Windows.EntryPanel:DrawGridEntries (single,bool&) (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/Windows/EntryPanel.cs:367)
RoyTheunissen.AssetPalette.Windows.EntryPanel:DrawEntriesPanel () (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/Windows/EntryPanel.cs:287)
RoyTheunissen.AssetPalette.Windows.AssetPaletteWindow:OnGUI () (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/Windows/AssetPaletteWindow.cs:169)
UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&)
Unable to allocate new scene culling mask
UnityEditor.GameObjectInspector:RenderStaticPreview (string,UnityEngine.Object[],int,int)
RoyTheunissen.AssetPalette.PaletteAsset:get_PreviewTexture () (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/Entries/PaletteAsset.cs:74)
RoyTheunissen.AssetPalette.CustomEditors.PaletteAssetDrawer:DrawContents (UnityEngine.Rect,UnityEditor.SerializedProperty,RoyTheunissen.AssetPalette.PaletteAsset) (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/CustomEditors/PaletteAssetDrawer.cs:18)
RoyTheunissen.AssetPalette.CustomEditors.PaletteEntryDrawer`1<RoyTheunissen.AssetPalette.PaletteAsset>:OnGUI (UnityEngine.Rect,UnityEditor.SerializedProperty,RoyTheunissen.AssetPalette.PaletteEntry) (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/CustomEditors/PaletteEntryDrawer.cs:98)
RoyTheunissen.AssetPalette.CustomEditors.PaletteDrawing:DrawGridEntry (UnityEngine.Rect,UnityEditor.SerializedProperty,RoyTheunissen.AssetPalette.PaletteEntry) (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/CustomEditors/PaletteDrawing.cs:52)
RoyTheunissen.AssetPalette.Windows.EntryPanel:DrawGridEntry (int,int,bool&) (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/Windows/EntryPanel.cs:406)
RoyTheunissen.AssetPalette.Windows.EntryPanel:DrawGridEntries (single,bool&) (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/Windows/EntryPanel.cs:367)
RoyTheunissen.AssetPalette.Windows.EntryPanel:DrawEntriesPanel () (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/Windows/EntryPanel.cs:287)
RoyTheunissen.AssetPalette.Windows.AssetPaletteWindow:OnGUI () (at Library/PackageCache/com.roytheunissen.assetpalette@d67006628a/Editor/Windows/AssetPaletteWindow.cs:169)
UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&)

I found a fast-fix

Interesting! I've not seen this one yet myself.
Can you give me some information on how to reproduce it? Happy to have a look at it later.
Thanks for exploring possible fixes by the way👍

To replicate this, I create an empty project in version 2021.3.21f1, create a prefab cube, copy it 100 times, and then add all the prefabs to the palette. This is how this error occurs.

I had time to take a look at it, it seems to be a regression of a bug caused by an optimization.
Reverting that optimization (which is arguably not necessary) seems to fix the issue, I am checking with the original author that he agrees with the change
I also had a look at your suggestion @Mad1San but it seems like that does not always correctly show the contents of the prefab. I seem to get the blue prefab icon as a result instead.
The fix will be merged soon 👍

Using the steps you described I was able to reproduce the issue, and after my fix I was no longer able to reproduce it.
I'm considering it fixed now. Thanks for reporting it!
You can try out the fix in the latest version.

thank u <3


Hearts updates

Some assorted updates including an important bug fix in InformationStateTensor().

Hey John can you update requirements.txt as in this commit: https://github.com/deepmind/open_spiel/commit/63ede7dee69c79510ff99dac99c68b8e368f6a9a  , it should fix the travis test, then I will import


No implementation found for Method share on channel

When i try to use
FlutterSocialContentShare.share(                   type: ShareType.more,                   url: "https://url.com",                   quote: widget.txt);
I get
Unhandled Exception: MissingPluginException(No implementation found for method share on channel flutter_social_content_share)

ShareType.more is not yet implememted.


ScrollToTop event

Hello.
Thank you for this chat, very very helpful.
Just asking if is there an event fired when user scrolls to top, so that we can load other messages.
I read #14 but did not understand the document.querySelector('.sc-message-list') trick.

Nope. No event is emitted when the user scrolls to top. It would be nice to have it so that the library user could paginate messages easily

From the outside, I got this working with the following code:
    mounted () {
        this.divObj = document.querySelector('.sc-message-list')
        this.divObj.addEventListener('scroll', this.handleScroll);
    },
    unmounted () {
        this.divObj.removeEventListener('scroll', this.handleScroll);
    },
    methods: {
        handleScroll (e) {
            if (e.target.scrollTop == 0) {
                console.log('scrollToTop')
            }
        },

But inside the component I woul listen to the scroll event and emit when necessary.
If you like, I can arrange a pull request.

Bonus:
    handleScroll(e) {
        if (e.target.scrollTop === 0) {
            this.alwaysScrollToBottom = false
            // load top messages here with autoscrolling disabled, then restore autoscroll
            this.alwaysScrollToBottom = true
        }
    },

Hey @andreav that’s awesome!
Could you arrange a Pull Request so that I can merge this and ship it in a new release?
I think it adds value a lot.
We should just document it well so that users can start using it right away


Added create functions for Window and Input

Describe the issue (if no issue has been made)
Add create functions for Window and Input.
PR impact (Make sure to add closing keywords)
List of related issues/PRs this will solve:

Impact
Issue/PR

Issues this solves
None

Other PRs this solves
Suggestion for TheCherno/Hazel#165

Proposed fix (Make sure you've read on how to contribute to Hazel)
Create functions depending on platform.

These functions will be called only once each time the application is launched. I think it would be better to keep it as it is with the platform specific compilation units setting the s_Instance (for Input) or providing the platform-specific implementation (for Window::Create). I don't think you would ever want to use multiple window/input libraries on a platform, so deciding which window to use at build time (as we currently do) seems fine to me.
The only use I could possibly see it to reduce code duplication in the case of Window::Create since then we have one implementation instead of one in each platform-specific window.
My other problem is that now we have platform-specific includes in platform-agnostic classes and these includes need include guards which means everything is decided at build-time anyway. And include guards are annoying to read (to me at least).

I also am not a fan of include guards. The reason to make the create functions is that this way, we can have all the include guards in one file, and one file only, as there is no reason to have include the platform specific files in any other place than the parent class, which implements the create function.


Cannot set facetFilters

Hello Algolia,
We need to have this information in the request: the relationship between all these catalogLinks* should be OR.
{
  "facetFilters": [
    [
      "catalogLinks.fr:/sacs-femme/sacs-a-main/hermes/",
      "catalogLinks.en:/sacs-femme/sacs-a-main/hermes/",
      "catalogLinks.us:/sacs-femme/sacs-a-main/hermes/",
      "catalogLinks.de:/sacs-femme/sacs-a-main/hermes/",
      "catalogLinks.it:/sacs-femme/sacs-a-main/hermes/",
      "catalogLinks.es:/sacs-femme/sacs-a-main/hermes/"
    ]
  ]
}

By searcher.addFacetRefinement it is impossible to do this.
So we should set searcher.searchParams.facetFilters = [....].
But when we proceed searcher.search(), we found facetFilters=[] sent in the request. After entering the code in your SDK, we found this line. It is this line which cancels what we did by searcher.searchParams.facetFilters = [....].
https://github.com/algolia/instantsearch-core-swift/blob/86ee28588934e51e0c609162275e39c6e69932cd/Sources/Searcher.swift#L384
So we would like to ask the reason why you are doing this. Or maybe it is a bug?
Thank you in advance for your reply.

Hey @XiaowenVC,
In order to do disjunctive faceting (OR) instead of conjunctive faceting (AND), you can use setFacet(withName:disjunctive:).
From our community website for InstantSearch Core in the filtering section:

A given facet can be treated as either conjunctive (the default—refinements combined with an AND operator) or disjunctive (refinements combined with an OR). You can modify the conjunctive/disjunctive status of a facet by calling setFacet(withName:disjunctive:).

Hi @spinach,
Thank you for the rapid response, but marking the facet as disjunctive does NOT resolve the problem.
I will take a short example to explain how disjunctive do the relation OR, in Swift, I do:
let catalogLangs = ["fr", "en", "de"]
catalogLangs.forEach {
	searcher.params.setFacet(withName: "link.\($0)", disjunctive: true)
	searcher.params.addFacetRefinement(name: "link.\($0)", value: "A")
	searcher.params.addFacetRefinement(name: "link.\($0)", value: "B")
}

Then the SDK translates:
.....
&facetFilters=[
  [
    "link.en:A",
    "link.en:B"
  ],
  [
    "link.de:A",
    "link.de:B"
  ],
  [
    "link.fr:A",
    "link.fr:B"
  ]
]&.......

which means
(link.en:A OR link.en:B) AND (link.de:A, link.de:B) AND (link.fr:A, link.fr:B)

c.f. syntax of facetFilters https://www.algolia.com/doc/api-reference/api-parameters/facetFilters/
and conclusion: setFacet(withName:disjunctive:) only do the disjunction between different values under the SAME key.
But for my case, I need the disjunction of DIFFERENT keys, example:
link.fr:A OR link.en:A OR link.de:A

which translates in facetFilters like:
[
    [
      "link.en:A",
      "link.fr:A",
      "link.de:A"
    ]
]

There's nothing in InstantSearchCore I can find which does this work. So I have to write it manually and directly in facetFilters key.
So I will reformulate my question, without entering in details of your code:
I use Searcher class from InstantSearchCore to do my searches via Algolia, with this class, how can I do what I mentioned above?

Ohh I see @XiaowenVC thanks a lot for describing in detail all of this. Will look into it to see what's the best way to get this done

Hey @XiaowenVC,
After further investigation, you are right that we're actually lacking this feature in our library. It is not possible to achieve it with the InstantSearch Core library by itself and it is a limitation that we should fix.
A couple of points:
1- The facetFilters parameters is actually not nil. The way disjunctive faceting works is that if we have N disjunctive facets with X conjunctive facets, then we usually do N requests to our servers in order to get the results (the request consisting of each disjunctive facet with the X conjunctive facets). If you put a breakpoint at this level then you will be able to see how the facetFilters get filled for each iteration.
2- Your case is a bit different since you only want OR operations and have no AND operations, so you can do it with 1 request by just using facetFilters exactly as you mentioned. However you will have to use our API client in order to do it, specifically the index.search method. You will have to take care of filling in the Query parameter with facetFilters and other fields. For a quick tutorial on how to use the API client, check this here
Thanks for detecting this and I'll let you know as soon as we add this functionality to InstantSearch Core.

yep sure https://github.com/algolia/instantsearch-android/issues/81

Hey @XiaowenVC,
It seems Instantsearch.js has the same functionality: only doing disjunctive faceting over a single facet. I am curious what kind of UI would it look like? I think it's the first time we get this feature request, that's why we didn't have it. If you can share more about the use case it would be great! cc @bobylito

The UI is nothing special, it is just a list of product.
Before describing the use case, I will explain the context:
We have all our products in an index Algolia, each product is associated with multiple links, and these links are translated in multiple languages (for the need of our web, to show a translated readable url in address bar).
So when we query Algolia with a link, we can get all products containing this link, it's by this way that we get a product list of certain category/brand/....
For example, this product has these links:
"catalogLinks": {
        "fr": [
	  ......
          "/sacs-femme/sacs-a-main/hermes/",
	  ......
        ],
        "en": [
	  ......
          "/women-bags/handbags/hermes/",
	  ......
        ],
        "de": [
	  ......
          "/damen-taschen/handtaschen/hermes/",
	  ......
        ],
	......
}

Which means we can see this product by in urls of these 3 languages:
http://www.vestiairecollective.com/sacs-femme/sacs-a-main/hermes/
http://www.vestiairecollective.com/women-bags/handbags/hermes/
http://www.vestiairecollective.com/damen-taschen/handtaschen/hermes/
For our mobile app, in order to show a product list, we also query Algolia with a link.
In many cases, for example by a deeplink com.vestiairecollective.vestiaire://action?type=catalogue&link=/sacs-femme/sacs-a-main/hermes/, we cannot know in which language the link is, so we should query Algolia with a query which means:
I want all products with catalogLinks.fr:/sacs-femme/sacs-a-main/hermes/ OR catalogLinks.en:/sacs-femme/sacs-a-main/hermes/ OR ......
For instant search, I think it is difficult to cover all use cases by creating different xxxRefinement methods. But all clients can have different needs. I have a suggestion:
In instant search, give clients the possibility to write manually their queries for filters, numericFilters, facetFilters, etc. Then the SDK should merge these manual queries with its auto-built queries.

Okay makes sense, I see the use case! I will discuss with the team to see what's the best way to surface this. Thanks for the suggestions!

@spinach It's been 4 months; Any update on this from the team? I have a related issue #33.

The new version of InstantSearch solves this with FilterState which is flexible and should cover all use cases.


add by-person itemization of hours on on invoice page

We received a request to itemize hours by person for one project . You can sort of get that from the project timesheet, but that doesn't show billable vs. non-billable (in sum). In the interim I am copy/pasting hour detail out of the invoice page and into a spreadsheet to sum them by person, which works okay for now but is not great long-term.

To clarify, how detailed would the per-person hours be? On the invoice page, we break down billable/non-billable hours into further detail. But for this feature request, it sounds like this level of detail would be sufficient:

Sam Blue
Ryan Green

Billable
9.5
10.1

Non-billable
2.7
3.4

Total
12.2
13.5

That looks good. As an alternative you could also list out people and hours under the Billable and Non-billable headers, side-by-side with the existing listings by activity. Either one will work fine for our purposes, so I'd say whatever you think would look best on the page.
It would be nice to have the people list(s) sorted alphabetically by last name rather than by total hours (the way they are on the project time sheet), to help avoid copy/paste errors on invoices when the order changes between months.
Thanks @rebecca-caktus for your help with this!


Incorrect documentation

Following https://github.com/Kotlin/kotlinx-kover#plugin-configuration
leads to an error:

Could not find method test() for arguments [build_xxx$_run_closure4@70489108] on task set of type org.gradle.api.internal.tasks.DefaultTaskContainer.

@pvegh I managed to make it work with this:
tasks.withType(Test) {
    kover {
        generateXml = false
        generateHtml = true
        coverageEngine = 'INTELLIJ'
        xmlReportFile.set(file("$buildDir/custom/report.xml"))
        htmlReportDir.set(file("$buildDir/custom/html"))
        binaryReportFile.set(file("$buildDir/custom/result.bin"))
    }
}

Right, it has a typo for Groovy, it has to be tasks.withType(Test) .
It will be reworked and fixed by #33


Change size of snake to use scale-independent pixels

Now the size of snake (and the food, and the grid) is defined as one 10th of the smaller screen size (width or height). Now using metrics this could be changed using scale-independent pixels.
I'm not sure this makes sense, need to try it.
An alternative is to set the size of grid via menu: instead of one 10th, it could be one nth, where n can be chosen by the menu button to be several pre-defined values (such as 10, 15, 20, etc.)

Implemented a menu of change size, cylcing to a set of pre-defined sizes: 5, 10, 15, 20, 25, 30. This size is the number of grid positions that GameBoard has in the shortest side of the window. This will define the size of the snake: the higher the number, the smaller the size.


Follow the latest bundler platform usecase on Fluentd v1.12.0 images

The latest bundler 2.2.x uses platform information on Gemfile.lock.
We should specify ruby as platform instead of x86_64-linux-musl.
Follows up #526.
Signed-off-by: Hiroshi Hatake<EMAIL_ADDRESS>

@cosmo0920 This patch should be merged before merging #526 ?

@cosmo0920 This patch should be merged before merging #526 ?

This patch should be merged after #526 is merged.

This patch should be merged after #526 is merged.

Thanks!

Thanks!

I'd kicked Fluentd v1.12.0 image builds. They will be published later.

I'd kicked Fluentd v1.12.0 image builds. They will be published later.


Fix scroll bar issues

Fixes

When you use the scroll bar in main app screen it also moves the view in download folder and vice versa #729

Hey @btzr-io, sorry I forgot to message you, but I decided to go a different route and do some refactoring for this fix. Still a work in progress but my changes are here: https://github.com/lbryio/lbry-app/pull/750
This way we will be able to get rid of the setTimeout for handling the scroll restore


AlgorithmID is overwritten

Expected Behavior
The AlgorithmId set in Initialize() using SetAlgorithmId() is kept constant throughout the life of the algorithm.
Actual Behavior
AlgorithmId is overwritten at https://github.com/QuantConnect/Lean/blob/642437d030b161e11bf979ea2889bd9bc9b5499c/Engine/Engine.cs#L271.
Potential Solution
Perhaps the job.AlgorithmId should try to pull its value from the algorithm first?
Reproducing the Problem
In Initialize() execute SetAlgorithmId( "test" );. Somewhere outside of this function, debug and inspect the value of AlgorithmId.
System Information
Windows x64.
Related Issue
#2472
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

Hey @Doggie52!
Believe SetAlgorithmId() isn't intended to be called by the algorithm itself. Recently we merged PR https://github.com/QuantConnect/Lean/pull/4156 where we added a couple of configuration options and cmdline arguments "algorithm-id" & "results-destination-folder", which I think should help solve the underlying issue and avoid calling SetAlgorithmId(). Let us know if this solves the issue and we can close it

Hey!
Looks great - I won't be able to test this anytime soon but it does look like #4156 would have solved it.

Hey!
Looks great - I won't be able to test this anytime soon but it does look like #4156 would have solved it.

Thanks! Closing this issue for now then


Pin subdependencies to versions using sane@2

sane@3 and sane@4 need Node 6+ and some dependencies bumped the sane version without bumping their major version themselves :(
This should hopefully make our CI run properly again
/cc @stefanpenner @rwjblue

@rwjblue yep, good call. I've added another commit that updates the outdated lockfile


replace isFunction with isDefined to check attr

isFunction returns always true for a '&' function, even if the function is not defined. (see http://stackoverflow.com/questions/21935099/how-to-check-if-a-method-argument-of-a-directive-is-specified-in-angularjs )
It was especially annoying for the modelToItemMethod.

Hi Paul,
thanks a lot for the contribution! Could you maybe squash the commits and do a new merge from my master such that the PR can be merged properly? And wouldn't it also work if you use the following pattern to check if it is a function:
angular.isDefined(ionAutocompleteController.***)

This would be nicer as then we would use the controller properties instead of the attributes. Could you maybe also use this way instead?
Thanks and regards,
Guy

Hi Guy,
I just tested with angular.isDefined(ionAutocompleteController.) and it doesn't work : ionAutocompleteController. is defaulted to a function so isFunction and isDefined will both return true, even if *** is not a used attr..

Hi Paul,
ok thanks for investigating it and your contribution!
Thanks a lot and regards,
Guy


Support direct messages

Currently, searches only groups, not direct messages.

closed in https://github.com/jyn514/GrepMe/commit/f858dfc28fd1db3dd87a53acc09430a25423127c


Update the kubeadm documentation to reflect the new release

@kubernetes/sig-cluster-lifecycle PTAL as soon as possible

This change is

Second pass. PTAL

Oops, I failed to push the latest changes last time.
Ok, now I've addressed all comments I think. PTAL

@jbeda Updated. PTAL

OK, let's merge this now, the release is out!
@jbeda agree?

LGTM from a tech PoV.  Adding @devin-donnelly for docs LGTM.

It also looks like this may need a rebase.

Thanks. Rebased now.
I'm merging this now, would be good to have everything in for KubeCon (this is the last part) and to not have to rebase a fifth time
If @devin-donnelly has some comments/concerns I'll make a follow-up PR


Risk Lookup Table is wrong

The risk lookup table encoded in the RiskLookupTable.csv file does not match the number of levels actually used in the domain model. The lookup table used in the Java system-modeller code does.
This is less serious than it might be because the Java code has the lookup table encoded in its source code (it should be loading the lookup table from the domain model but it doesn't). However, the Python risk-report project does load such information from the domain model CSV files and failed as a result of the information being inconsistent with a system model being analysed.

Reviewed the pull request, and actioned the merge into branch 6a. Left the branch open as there are several open development branches and we may want to merge this change into some of those before they get merged with 6a.


Installation error following the documentation.

Error installing the application via go:
go install -v github.com/alpkeskin/mosint/v3/cmd/mosint@latest
also error installing the application via docker:
docker build -t mosint .
docker run mosint --help
imcomplement doc

I followed the doc and it works like a charm for me.
Did you install Go before that? Your command line:
go install -v github.com/alpkeskin/mosint/v3/cmd/mosint@latest

Seems not to work because the installation is verbose. Then you're trying to ls the app, but it couldn't be found because when you use go install, the installation is done in ~/go/bin. So if you would like to ls and see if the installation was successful, you can try:
ls ~/go/bin

Next, you are trying to build a Docker image with a local Dockerfile without having downloaded the repository that contains this Dockerfile. So it's completely normal that it is not working. In conclusion, you are stating that the documentation is incomplete without trying to explain your situation and context to those who are developing this app with dedication. It seems you are not asking for help, but rather asserting that they are wrong and you are right. Feel free to ask if you need further assistance!


Bump to 2.40.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Revert to Docker 1.5

Reverts the changes in #4438 and #4590.

This is necessary because of continual issues with the Docker daemon. See #4610.

Without additional changes to reinstall etcd2 and flanneld as before, this won't work. Instead let's try to drop Docker 1.5.0 onto current CoreOS: see #4614.


mising script start

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Version
Please give these versions:
NodeJs:
Green-bot;
Additional context
Add any other context about the problem here.

Please give more informations.

@zakonja Please fill out the form on your first comment


Firefox support

When testing I could not find my cookie from Firefox. It might be due to the Multi-account container plugin. However I was testing without a container tab. It did work on Chrome for me.
Running Firefox version 92.0 (64-bits)
Maybe this has to do with the anti tracking features of Firefox.

What OS is this? I have a Mac OS computer, and some Raspberry Pis running Linux, but don't have any Windows machines to test.

Windows 10 Pro 21H1, Build 19043.1237

Support for the Firefox-Addon "Firefox Multi-Account Containers" has been added in #52. In case there are still issues with it please open a new issue.


Report + Negotiation Card: Implement Mapping (Frontend)

#229 proposes a mapping between the fields of a negotiation card and the fields of a report. Once this mapping is implemented in the backend, we need to replicate it on the frontend such that we can populate a report from a selected negotiation card.
Proposed elements for this UI include:

Select existing report artifact or "create new" option
On report edit page, option is available to "populate from negotiation card"
On selection, this option displays a dropdown list of all negotiation cards within the current context (namespace, model, version)
When a particular card is selected, the content from this card is mapped into the current report fields
These fields can then be edited further by the user

This is currently somehow achieved by the report by default including everything from the negotiation card.


Feature/discord icon hat layers

Changed icon server url

Wrong 'into' branch. Meant to go back into skerit's fork, my bad


[ci skip] adding user @kvoronin

Hi! This is the friendly automated conda-forge-webservice.
I've added user @kvoronin as instructed in #40.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #40

@kvoronin could you please confirm you would like to be a maintainer here?
@mtjrider in the future let's hold off on merging until the maintainer added confirms they want to be added. Unless of course they take the action to add themselves. Does that sound reasonable?

@kvoronin could you please confirm you would like to be a maintainer here?
@mtjrider in the future let's hold off on merging until the maintainer added confirms they want to be added. Unless of course they take the action to add themselves. Does that sound reasonable?

Very reasonable to have public confirmation. Will ensure this happens in the future.
FYI his maintainer status was confirmed over email + Slack.


ActiveSupport::Cache::MemCacheStore unsupported

Hi.
We recently upgraded from the dalli gem to mem_cache_store. This silently broke the rack-throttle gem since it expects the cache to support :has_key?, :get, and :set.
To fix it, we applied this monkey patch...
  class RackThrottleMemCacheStore < ActiveSupport::Cache::MemCacheStore
    alias_method :has_key?, :exist?
    alias_method :get, :read
    alias_method :set, :write
  end

  # Limits :max requests per minute by session id
  cache_servers   = Rails.application.config.cache_store[1...-1]
  cache_options   = Rails.application.config.cache_store.last
  memcache_store  = RackThrottleMemCacheStore.new(cache_servers, cache_options)

  Rails.application.config.middleware.use Rack::Throttle::Minute,
                                          max:        60,
                                          key_prefix: :throttle,
                                          cache:      memcache_store

I'm not sure if there's a better way but sharing this tidbit for others who may be running this with dalli and then switched to mem_cache_store.
Thanks for this gem!
Owen

Hi Owen! Most people are using rack-throttle for legacy versions of ruby, but if you are able to: https://github.com/kickstarter/rack-attack is much more feature full & maintained!

Thanks FreekingDean. I'll work on migrating with our next sprint and add any gotchas/comments to this issue.

Would love to know if there are large sweeping differences, but I believe it was originally based on this repo.

The switch took about an hour.

safelist took care of the IP whitelisting
Created a Rack::Attack::Request like the example config to whitelist localhost IP and a few paths
Able to create three different throttles based on different paths
Plugs right into Rails.cache.store without any issues

The hardest part was understanding how to log if something was throttled. Here was my solution...
ActiveSupport::Notifications.subscribe("throttle.rack_attack") do |_name, _start, _finish, _request_id, payload|
  request = payload[:request]
  Rails.logger.error("[rack-attack] throttle=#{request.env["rack.attack.matched"]}, path=#{request.path}, ip=#{request.ip}")
end

Will throw it into production in two weeks and see how it performs.

Works great. Only issue was that the IP method needs to be overwritten if you deal with HTTP_X_FORWARDED_FOR otherwise you'll block all traffic from your load balancers.
  def ip
    if addr = env['HTTP_X_FORWARDED_FOR']
      (addr.split(',').first || env['REMOTE_ADDR']).to_s.strip
    else
      env['REMOTE_ADDR']
    end
  end


Feature: remember amount of HQ/NQ material used, or disable auto HQ mat selection

For example, a recipe necessitates two ingredients, but my macro only requires one HQ ingredient to craft the recipe in HQ quality. However, the current endurance mode automatically utilizes the maximum amount of HQ material, which is 2.
Could you kindly add a checkbox to disable the auto HQ material quantity adjustment, or implement a mechanism to remember the amount of HQ/NQ material used, or introduce an option for "Minimum starting quality" in the macro settings? This would significantly save time when crafting the HQ ingredient.

This would be amazing. Currently, this is one of the 2 things holding me back from swapping over to Artisan from SND completely. If this were added in tandem with the ability to also pull the necessary amount of HQ ingredients from retainers, it would be a smooth transition for those using SND to do master crafts.


[go-rancher]I hope to use Rancher API to create a namesapce in default project,but it return me an error"Unknown schema type [namespace]"

What kind of request is this (question/bug/enhancement/feature request):
I am trying to use Rancher API to create a namespace, but i failed ,and return to me an error "Unknown schema type [namespace]"
Steps to reproduce (least amount of steps as possible):
1.I created a new Namespace Client by using generated client functions
2. I input "Name" and "ProjectID" into Namespace Struct, then i use create method to create a namepace
Result:
Return "Unknown schema type [namespace]"
Other details that may be helpful:
//Get projectID from Default project

func (rancher *Rancher) GetProjectID() (id string, error error) {
listopts := &types.ListOpts{Filters: map[string]interface{}{}}
projectcollection, error := rancher.globalClient.Project.List(listopts)
for _, value := range projectcollection.Data {
if value.Name == "Default" {
id = value.ID
}
}
return
}

//Create namespace in Deafault project

func (rancher *Rancher) CreateNamespace(id string) (namespace *cluster.Namespace, error error) {
namespace = &cluster.Namespace{
Resource: types.Resource{
ID:      "",
Type:    "",
Links:   nil,
Actions: nil,
},
Annotations:                   nil,
ContainerDefaultResourceLimit: nil,
Created:                       "",
CreatorID:                     "",
Description:                   "",
Labels:                        nil,
Name:                          rancher.rancherOpts.Namespace,
OwnerReferences:               nil,
ProjectID:                     id,
Removed:                       "",
ResourceQuota:                 nil,
State:                         "",
Transitioning:                 "",
TransitioningMessage:          "",
UUID:                          "",
}
namespace, error = rancher.namespaceClient.Namespace.Create(namespace)
return
}

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
Installation option (single install/HA):
Rancher version is v2.4.6
Before i trying to create namespace , i have successfully realize some functions such like "create cluster"、"delete cluster"、"get ProjectID".Now i want to create namespace, but i failed ,and i am very confused,can someone point out my mistake?Or give me some advices ? Thanks a lot!!!

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Machine type (cloud/VM/metal) and specifications (CPU/memory):
Kubernetes version (use kubectl version):

(paste the output here)

Docker version (use docker version):

(paste the output here)

@rawmind0 Hello ,sir, sorry to bother.One week ago i read your reply in this issue,and i follow your idea to create a cluster successfully , but now i can't create a namespace. It return to me an error "Unknown schema type [namespace]", and i use debug tool , find there is no [namespace] in schema. The error occur at  line 180 "schema, ok := a.Types[schemaType]". I will be very appreciate if you can show me how to get onto the right path,thanks.

I find the problem.Close the issue.