Support for custom ETag?

We are using EF Core with MS SqlServer and an own ETag field (GUID).  I guess that I could add a RowVersion field (and opt out of the concurrency check), but we already have mid-air conflicts logic based on our ETag in our API clients, and I am afraid this will interfere with Delta's concepts.
Would it be possible to use that ETag instead of the calculated one?

we already have mid-air conflicts logic based on our ETag in our API clients

if you already have code to handle this, why r u considering Delta?

We just populate the ETag and use it only for mid-air collision detection during save. I am tempted by Delta's offering on caching.

I second this. We have a "LastModified"- Column in place which is basically a DATETIME2 based timestamp. Would be nice to be able to configure this column as the "ETAG" to be used.

Sorry for my the misunderstanding. But isn't the RowVersion a db table column either? Sorry for bothering, I have to do a little more reading on that topic.

I am considering also "the other way around" in our case. Ditching our ETag (a shadow prop of type GUID, that we don't use for concurrency anyway), and using your default ETag. Then we would get the best of "both worlds" (our mid-air collision logic is not depending on a GUID as ETag, it can be anything).

RowVersion  is per table. but because it is a special type of column, sql has a feature that allows you to query the newest RowVersion across all tables. and it a very efficient query, since it is actually implement as a db level counter. so the query is just "what the current counter value"
if you dont already use a row version for concurrency, i highly recommend it. here is an example ef usage https://learn.microsoft.com/en-us/aspnet/core/data/ef-mvc/concurrency?view=aspnetcore-9.0


Move scanner to https://github.com/google/osv-scanner

To make releasing/tagging clearer and easier.

@G-Rath FYI!

I was just thinking about this - I quite like the setup I have going in osv-detector (goreleaser + a few other things for linting) so am happy if you want to just lift that (I expect it'll work straight out of the box).
Let me know if you'd like me to help with any part of that too.

@oliverchang having thought about it more, if you're planning to move the scanner into its own repo I wonder if it might actually be better to start from osv-detector as a base instead (either with its existing remote and renaming, or hard-forking) because its already setup with linting, release publishing, CI workflows, extensive tests, etc, has the features we've already talked about pulling into the scanner (config with the ability to ignore stuff, custom databases, using the api and/or downloading the dbs, improved output, etc) - the only things I think are missing that the scanner has is .git and sbom support, and recursing into directories.
I'm happy to give you the codebase unlicensed or however you need it if you want so that you can chop it up as much as you like - up to you :)

Hey @G-Rath, we'd still very much prefer our own osv-scanner and moving our own CI processes tools etc there, given that's what our team of 4 is most familiar with.
I agree there's still the missing pieces that you mentioned, but this is a work in progress so let's continue to iterate to make it the best scanner possible :)

This is done by @another-rex !


Update zio-sbt-ci, zio-sbt-ecosystem, ... to 0.4.0-alpha.27

About this PR
📦 Updates

dev.zio:zio-sbt-ci
dev.zio:zio-sbt-ecosystem
dev.zio:zio-sbt-website

from 0.4.0-alpha.22 to 0.4.0-alpha.27
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: sbt-plugin-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #460.


Resolve tagtype issue

Resolve tagtype issue of service Data.
File update after deleted resolved.
Error description UI issue fixed.

r? @ustulation
(maidsafe_highfive has picked a reviewer for you, use r? to override)


Homarr + authentik

Description
Hello, I'm using authentik as an SSO with homarr and OIDC, everything is working as expected, but i'm wondering if there is a way to make homarr display directly the authentik login page instead of homarr login page ?
Please tick the boxes

[X] You've read the docs
[X] You've checked for duplicate issues

@whailing That is not currently supported. I am not sure how we'd go about this, you would want to display it inside of an iFrame and allow login that way ? I believe it might be a solution but to be honest I am not familiar with OIDC nor am I familiar with Authentik, some more experienced people might be able to answer this issue

No, I think when OIDC is enabled, instead of showing this "Login" page and having the user click on Sign In - Authentik just auto-redirect to whatever URL they would go to without needing to click.

Then, if you are already logged into Authentik (or whatever OIDC you are using), it will confirm your account and redirect you back to the Homarr board, no user interaction needed.

Hi, sorry I didn't see this issue earlier. I think I asked that functionality from the one that made SSO and he did make it, although not documented it seems:
AUTH_OIDC_AUTO_LOGIN="true"


Error in monkey patching (no _qt import)

I get an exception when using napari-tools-menu 0.1.4 in napari 0.4.11.
After adding print_exc() at the end of the except block (which is maybe good practice), I get more insight:
…/miniconda3/envs/spacem/lib/python3.8/site-packages/napari_tools_menu/__init__.py:124: UserWarning: Error in monkey patching napari. Please let @haesleinleinhuepf know at
https://github.com/haesleinhuepf/napari-tools-menu/issues
  warnings.warn("Error in monkey patching napari. Please let @haesleinleinhuepf know at\nhttps://github.com/haesleinhuepf/napari-tools-menu/issues")
Traceback (most recent call last):
  File "…/miniconda3/envs/spacem/lib/python3.8/site-packages/napari_tools_menu/__init__.py", line 107, in <module>
    if not hasattr(napari._qt.qt_main_window._QtMainWindow.__class__, "_add_menus_bkp"):
  File "…/miniconda3/envs/spacem/lib/python3.8/site-packages/napari/_lazy.py", line 50, in __getattr__
    raise AttributeError(f'No {module_name} attribute {name}')
AttributeError: No napari attribute _qt

I don't see that _qt is exported in my napari/__init__.py
Adding import napari._qt in the top of napari_tools_menu/__init__.py solves it.

Thanks @aeisenbarth  for reporting!

Adding import napari._qt in the top of napari_tools_menu/init.py solves it.

I couldn't reproduce the issue on my system (neither on napari 0.4.11 nor on 0.4.12), but adding this line also doesn't hurt. Thus, I just released napari-tools-menu 0.1.5 with your suggestion. Would you mind installing it on your machine and reporting back if that solves the problem?
Thanks!
Best,
Robert


Enhances truncate() method & modifies built-in name "vars" through out the repo

@Chipe1 the main purpose of those conditions is to check if we got a matrix or a list or just a float. If we get a list, it is expected to get a list of floats. If we get a list of lists, it is expected to get floats in the lists. I don't think it's worth it to complicate things.
So, we can keep it as is or we can complicate it by checking for every value in the list if it is a float or not. And btw, if we want to do that, we need to modify most of the functions in utils.py as most of them expect some particular pattern, for example scalar_vector_product(x, y) which expects x to be a scalar and y to be a vector and not the other way around.

I don't think a recursive code would complicate the code, instead it would simplify it. If it is a float we truncate and return. Else if it is iterable, we return the list of truncated form each element in the list. The code would be smaller, easier to understand and work for both list and matrix

I'm going to accept this because it is a step in the right direction; thanks, @SnShine!
It would be better to break up pull requests into two parts when they address two separate things. I forgot that vars was a builtin, and you are right that it is good to eliminate that conflict.
As for the truncate, I mostly agree with @Chipe1. But a couole things. First, I think "round" is a better name than "truncate", because the .f format directive rounds, not truncates. Second, would it be ok to return rounded numbers, not strings? Or is it really important that numbers be padded with trailing zeros? If not, then I propose this, which, as @Chipe1 says, can work to any nested depth:
def rounder(numbers, d):
    "Round a single number, or sequence of numbers, to d decimal places."
    if isinstance(numbers, (int, float)):
        return round(numbers, d)
    else:
        constructor = type(numbers) # Can be list, set, tuple, etc.
        return constructor(rounder(n, d) for n in numbers)

Yeah, it is okay to return rounded numbers. I don't think that the numbers need to be padded with zeros. Yeah, it's better if we implement recursive method which deals with any nested depth.
@Chipe1 when I said it complicates things, I mean if we are checking for every element in the list if it is a float. I haven't read the recursion idea you proposed.


Workspace won't start

Error provisioning rbac: roles.rbac.authorization.k8s.io "devworkspace-use-container-build" is forbidden: user "system:serviceaccount:openshift-operators:devworkspace-controller-serviceaccount" (groups=["system:serviceaccounts" "system:serviceaccounts:openshift-operators" "system:authenticated"]) is attempting to grant RBAC permissions not currently held: {APIGroups:["security.openshift.io"], Resources:["securitycontextconstraints"], ResourceNames:["container-build"], Verbs:["use"]}

Work-a-round:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: system:openshift:scc:container-build
rules:
- apiGroups:
  - security.openshift.io
  resourceNames:
  - container-build
  resources:
  - securitycontextconstraints
  verbs:
  - use
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: system:openshift:scc:container-build
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: system:openshift:scc:container-build
subjects:
- kind: ServiceAccount
  name: devworkspace-controller-serviceaccount
  namespace: openshift-operators

Fixed - please create a issue at issues.redhat.com

Issue created: https://issues.redhat.com/browse/JBDS-5087


added ClearScroll action

see https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-scroll.html#_clear_scroll_api
I'm working on jest support for spring-data-elasticsearch. The jest API misses this elasticsearch action, see https://github.com/spring-projects/spring-data-elasticsearch/blob/master/src/main/java/org/springframework/data/elasticsearch/core/ElasticsearchOperations.java#L562

Coverage decreased (-0.3%) to 49.422% when pulling 87935a822d25b15f3c6e19d0c875fc31a01ad83e on pulse00:patch/clear-scroll into 8fe6975cd341d286bc8f7064bc65d71f407afaeb on searchbox-io:master.

Hi @pulse00,
A few things that, I believe, would improve this new (to jest) ClearScroll action:

Builder takes only a single scroll ID whereas the original API can take multiple IDs.
I would favor ditching the MAX_SCROLL_ID_LENGTH logic, which complicates things, and always using request body to send scroll id data.
The API docs does not specify but does ES support specifying indices for this request type? If not then using AbstractMultiIndexActionBuilder as the builder base would be misleading.

What do you think?

Hey @kramer,

Builder takes only a single scroll ID whereas the original API can take multiple IDs.

makes sense. Do you have any existing api calls that serialize the body to an array? From what i can tell in the elasticsearch source code they use Base64.encode/decode API.

I would favor ditching the MAX_SCROLL_ID_LENGTH logic, which complicates things, and always using request body to send scroll id data

will do.

The API docs does not specify but does ES support specifying indices for this request type? If not then using AbstractMultiIndexActionBuilder as the builder base would be misleading.

What's the recommended base class for such a call?

Do you have any existing api calls that serialize the body to an array? From what i can tell in the elasticsearch source code they use Base64.encode/decode API.

It's just the HTTP body, you don't need to encode anything, simply set the payload variable and AbstractActon will take care of it. For example:
    protected ClearScroll(Builder builder) {
        super(builder);
        this.payload = ImmutableMap.of("scroll_id", builder.getScrollIds()); // where builder.getScrollIds() returns a list of strings
        setURI(buildURI());
    }

What's the recommended base class for such a call?

I'd say: public static class Builder extends GenericResultAbstractAction.Builder<ClearScroll, Builder>

Oh and for the multiple scroll ids in the builder please try to keep the collection behaviour AbstractMultiIndexActionBuilder has, i.e.: internal set of strings, has no param constructor, has methods to add single or multiple scroll ids. Another part of that behaviour is when no ids are given it should call with _allappended to uri and without any payload, to do that you'll need to modify the constructor example I gave earlier (with the ImmutableMap.of... line).

Coverage decreased (-0.2%) to 49.47% when pulling 5683735d003b6066470866668a6569e555a112c7 on pulse00:patch/clear-scroll into 8fe6975cd341d286bc8f7064bc65d71f407afaeb on searchbox-io:master.

@kramer i've implemented the changes. thanks for your feedback.

Coverage decreased (-0.3%) to 49.406% when pulling 26cf82a0f6e355f92e653765a05dbee92faf86c6 on pulse00:patch/clear-scroll into 8fe6975cd341d286bc8f7064bc65d71f407afaeb on searchbox-io:master.

Coverage decreased (-0.3%) to 49.406% when pulling f20c138e8f058cabebc3f5dc85b15cde62c7bb4d on pulse00:patch/clear-scroll into 8fe6975cd341d286bc8f7064bc65d71f407afaeb on searchbox-io:master.


Adding support for retval

Adding support for @retval by enabling a similar section in the markdown output for "Return Values"

Hi, thanks for contributing. But wouldn't it be easier to add the [\\@]retval to the config into the return_statement? That would do the same thing as you are proposing here. The only difference is that the already present implementation does not have a line separator but an empty line. If you want the line as a separator, adding the separator there would make it less messier. It does look better with the line separator.

My understanding of the use of retval is that it looks more like a "param" where it is a pair: the retval and the description of the retval. Then you can have a list of those.
Example:

Background: https://www.doxygen.nl/manual/commands.html#cmdretval

Sure thanks for the explanation. Did you test it with other things so that I can merge it?

I've got it working in a few varied instances of doxygen comment blocks. Considering its similarity to "@param" I'm feeling pretty good about its reliability.
Did you have any particular edge cases in mind that you want me to take a look at?

Nothing special. I have just realized that I will need to rewrite the implementation of all the block but that I will do later this week. Thanks for the contribution.

Thanks!
Were you thinking about writing those block lines to separate tables so params, retvals, tparams, and sees can't be interleaved? I was thinking about making that change as well, but then I thought "is the interleaving of those lists really a thing that's encountered in the wild? Would you have to be some sort of crazy person to interleave those in a comment block, or is there an actual reason to do so..."

I have already pushed the change. Now it is actually editable


Implement alphasquared trading

Added in https://github.com/rhettre/coinbase-advancedtrade-python/pull/95


chore: release 0.8.1

:robot: I have created a release *beep* *boop*
0.8.1 (2021-06-17)
Bug Fixes

Allow responses section in components to be omitted (#39) (30398af)
use interface for oneOf (#36) (6bda6b3)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/contiamo/openapi-generator-go/releases/tag/v0.8.1 :sunflower:


Idefics support in BetterTransformer

Feature request
add idefics to supported models for BetterTransformer
Motivation
It is not possible currently to use idefics model efficiently (as its too big for most GPUs)
Your contribution
i can contribute as best as i can to the implementation

Hi @Patrykkrawczak, thank you! IDEFICS already uses SDPA in transformers. BetterTransformer integration for IDEFICS would basically replacing https://github.com/huggingface/transformers/blob/bfb1895e3346cb8a2bf2560c75d45e70edf46a47/src/transformers/models/idefics/modeling_idefics.py#L692 by a call to SDPA that uses the attention_mask only for batch size > 1 during training, as SDPA can not dispatch to memory-efficient attention / flash attention when an attention mask is passed (as of torch 2.0.1).
This would look for example roughly like this: https://github.com/huggingface/optimum/blob/659cf0267706e48c711e7c503d3057b7538efe0e/optimum/bettertransformer/models/attention.py#L640-L660

Hi @Patrykkrawczak for reference: https://huggingface.co/docs/transformers/perf_infer_gpu_one#flashattention-and-memory-efficient-attention-through-pytorchs-scaleddotproductattention


docs: align ClusterStorageContainer example to latest Kubeflow

Since on Kubeflow side we're now publishing the kubeflow/model-registry-storage-initializer:latest image, we can use it as a pragmatic value in the example instead of placeholder abc.
Also, links CSI code which is now maintained directly as a module in KF/model-registry repo.
wdyt @lampajr @Al-Pragliola ?

/lgtm !


Rerender w/ 2.0.1, tweak template

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Re-render to get a build for py36.


Start and end dates for experience section can have only month and year as mandatory

Duration of a particular job are usually quantified with month and year, as such having a exact day as mandatory is not required and it's tough to remember the dates . Moreover, the final output on the resume is only in terms of month and year, so that should only be asked. - Not sure if there's a react's restriction for that. If you do not provide the day - term duration is not displayed

You could easily specify a relative date to when your employment was on. That would show the month itself. It sure has some complications and it's better to stay this way, rather than randomly choosing a date in the month.

Closing this in favor of Reactive Resume v3 release.
If you continue to face this issue, please raise a new one and I'll have a look at it as soon as I can.
In the meantime, if you are able to, please consider donating to keep supporting the project: https://www.buymeacoffee.com/AmruthPillai :)
Thank you!


2 minutes delay...

Hello,
I have to wait about 2 minutes before to see the console populated ? This is a normal duration ? by looking the video, i can see that the result is almost immediat. However my network connection is fast.... any explanation?
Regards,
Johnny

I can't make it work... I open one chrome tab to jsconsole.com  and enter listen
then I open another tab to an internal host http://10.x.x.x/index.html (which contains the javascript generated from the first tab)
In the second tab I read:
Failed to load resource: the server responded with a status of 404 (Not Found)  remote.js

Dead issue. Sorry.


My config causes a crash, what am I doing wrong?

Config:
# MQTT Connection, if empty will query and use hassio provided mqtt
mqtt:
  host: homeassistant.local
  port: 1883
  ssl: false
  username: my_username
  password: my_password

# This gets added to the x,y,z to derive a gps location
gps:
  latitude: 38.897957
  longitude: -77.036560
  elevation: 146

# How long before device considered stale
timeout: 30
# How long before device is considered away
away_timeout: 120

optimization:
  enabled: true
  interval_secs: 60
  limits:
    absorption_min: 2.5
    absorption_max: 3.5
    tx_ref_rssi_min: -70
    tx_ref_rssi_max: -50
    rx_adj_rssi_min: -15
    rx_adj_rssi_max: 20

weighting:
  algorithm: gaussian
  props:
    sigma: 0.10

# Floors w/ the points to draw it in meters
floors:
  - id: first
    name: First Floor
    # Bounds (x,y,z) of map in meters
    bounds: [[0, 0, 0], [18.5, 19.2, 1.5]]
    rooms:
      - name: Garage
        points:
          - [0, 0]
          - [5.5, 0]
          - [5.5, 6]
          - [0, 6]
      - name: Kitchen
        points:
          - [0, 6]
          - [0, 13.2]
          - [0.5, 13.2]
          - [1, 13.5]
          - [2.75, 13.5]
          - [3.25, 13.2]
          - [3.75, 13.2]
          - [3.75, 6]
      - name: Living Room
        points:
          - [3.75, 6]
          - [3.75, 11.5]
          - [9.5, 11.5]
          - [9.5, 5]
          - [5.5, 5]
          - [5.5, 6]
      - name: Suite Living Room
        points:
          - [3.75, 11.5]
          - [6.75, 11.5]
          - [6.75, 17.25]
          - [3.75, 17.25]
      - name: Suite Bedroom
        points:
          - [6.75, 14.5]
          - [9.5, 14.5]
          - [9.5, 17.25]
          - [6.75, 17.25]
      - name: Suite Bathroom
        points:
          - [6.75, 14.5]
          - [9.5, 14.5]
          - [9.5, 11.5]
          - [6.75, 11.5]
      - name: Foyer
        points:
          - [5.5, 5]
          - [9, 5]
          - [9, 2.1]
          - [5.5, 2.1]
      - name: Hallway
        points:
          - [9, 5]
          - [11.2, 5]
          - [11.2, 6.25]
          - [12.2, 6.25]
          - [12.2, 4]
          - [9, 4]
      - name: Guest Bathroom
        points:
          - [9.5, 5]
          - [9.5, 8.75]
          - [11.2, 8.75]
          - [11.2, 5]
      - name: Master Bathroom
        points:
          - [9.5, 8.75]
          - [9.5, 12.2]
          - [11.2, 12.2]
          - [11.2, 8.75]
      - name: Master Bedroom
        points:
          - [11.2, 12.2]
          - [15.7, 12.2]
          - [15.7, 5.5]
          - [12.2, 5.5]
          - [12.2, 6.25]
          - [11.2, 6.25]
      - name: Guest Bedroom
        points:
          - [12.2, 5.5]
          - [15.7, 5.5]
          - [15.7, 0]
          - [12.2, 0]
      - name: Office
        points:
          - [9, 4]
          - [12.2, 4]
          - [12.2, 0]
          - [9, 0]

# Locations of espresense nodes in meters
nodes:
  - name: Living Room
    point: [9.2, 9.5]
    floors: ["first"]
  - name: Office
    point: [10.2, 0.1]
    floors: ["first"]
  - name: Kitchen
    point: [0.1, 7.75]
    floors: ["first"]
  - name: Suite Living Room
    point: [3.85, 16]
    floors: ["first"]
  - name: Master Bedroom
    point: [13.1, 12]
    floors: ["first"]
# Devices to track
devices:
  - id: myname_s_iphone_15_pro_ble
    name: MyName's iPhone 15 Pro BLE
  - id: wifename_s_iphone
    name: WifeName's iPhone BLE

Error Log:
[17:37:38 INF] Loading /config/espresense/config.yaml
Unhandled exception. System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at ESPresense.Models.Node.Update(Config c, ConfigNode cn, IEnumerable`1 floors) in /App/Models/Node.cs:line 48
   at ESPresense.Models.State.<.ctor>g__LoadConfig|0_1(Config c) in /App/Models/State.cs:line 26
   at ESPresense.Models.State..ctor(ConfigLoader cl) in /App/Models/State.cs:line 68
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.ConstructorInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
   at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitIEnumerable(IEnumerableCallSite enumerableCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(Type serviceType)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
   at Microsoft.Extensions.Hosting.Internal.Host.StartAsync(CancellationToken cancellationToken)
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.Run(IHost host)
   at Program.<Main>$(String[] args) in /App/Program.cs:line 95

Seems you are missing the 'height' of your nodes (e.g. third locator) - you only reference two points instead of three.
i.e.
nodes:
  - name: Living Room
    point: [9.2, 9.5]
    floors: ["first"]

Should be like
nodes:
  - name: Living Room
    point: [9.2, 9.5, 0.5]
    floors: ["first"]

This is fixed in 0.4.3!


Anti features

This removes all features from the host besides testutils

The "serde" feature was unused
The "hostfn_log_fmt_values" feature was an over-conservative setting that didn't need to be static; we already have a dynamic flag is_debug() that uses the dynamic diagnostic level to enable expensive logging, we should just use that
The "vm" feature was there to theoretically support building a native testing config of the host without any VM -- for testing purely native contracts -- but in practice testing always builds with "vm" enabled and users test a mix of native and wasm contracts, so there's just no use for it.

There's no functional change here, just simplification of the codebase (and speeding-up of test cycles).

The "hostfn_log_fmt_values" feature was an over-conservative setting that didn't need to be static; we already have a dynamic flag is_debug() that uses the dynamic diagnostic level to enable expensive logging, we should just use that

What do users of the Host, such as the CLI, or the soroban-sdk, need to do to enable this new debug mode? They currently enable that feature when importing the soroban-env-host.

The "hostfn_log_fmt_values" feature was an over-conservative setting that didn't need to be static; we already have a dynamic flag is_debug() that uses the dynamic diagnostic level to enable expensive logging, we should just use that

What do users of the Host, such as the CLI, or the soroban-sdk, need to do to enable this new debug mode? They currently enable that feature when importing the soroban-env-host.

Oh, you just call host.set_diagnostic_level(crate::DiagnosticLevel::Debug). You'll want to be doing this anyways as it's how you're going to get all the diagnostic events in the debug log (which will shortly be "all the debug events" since we're merging debug and diagnostic evens).


ZFIN-8740: Upgrade Jenkins WAR file and external-monitor-job plugin

Upgrade jenkins to latest in LTS line: 2.414.3

You'll also need update docker/jenkins/Dockerfile to use the new war.

@zfinryanm Thanks, fixed it


Cannot feed value of shape (1, 1000, 1500, 3)

Hi,
when I try examples of inception_v1 the dog picture prediction gave me the this error
Cannot feed value of shape (1, 1000, 1500, 3) for Tensor 'input:0', which has shape '(1, 224, 224, 3)'
any Idea?
thanks

As the error message implies, it seems you are feeding in an image of incorrect shape.


chore: Mergeback release to development

What it solves
Merge back release versioning back to development

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.476%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
789

Relevant Lines:
974

💛  - Coveralls


switch fn names to lowerCamelCase

since jshint apparently thinks upper-case function names are constructors

Merged as 5fd77daeea6792582877a70eacb4cb7633723793


fix: 🔧 fix country typo

"Surilabel" => "Suriname"

"Surilabel" => "Suriname"

Oops, looks like I replaced all name to label and Suriname was been modified.
Thanks @andrewsantarin.


Set HSTS header on all responses

Updates DS to have a HSTS header for all responses.
Closes #140
References ausaccessfed/infrastructure#340

$ rake
/Users/bradleybeddoes/.rbenv/versions/2.7.1/bin/ruby -I/Users/bradleybeddoes/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/rspec-core-3.9.2/lib:/Users/bradleybeddoes/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/rspec-support-3.9.3/lib /Users/bradleybeddoes/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/rspec-core-3.9.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb

selecting an idp
  when the group does not exist
    returns http status code 404
  when the group exists
    shows the content

DiscoveryService::Application
  GET /
    responds with status code 302
    redirects to /discovery
  GET /health
    responds with status code 200
  GET /embedded_wayf
    responds with a javascript document
    sets HSTS header
  GET /discovery
    sets HSTS header
    with no idps previously selected
      shows that there are no organisations selected
      shows the environment name
      shows the status url
      sets HSTS header
    with idps previously selected
      and the idp's group is gone
        shows that there are no organisations selected
      and the idp does not exist anymore
        shows that there are no organisations selected
      and the idp and group do exist
        shows the idp name
        contains a form to reset idps
        shows the help text header (singular)
        shows the help text body (singular)
        shows the reset button
        with a name that requires escaping
          gets escaped
          sets HSTS header
      and multiple idp selections exist
        shows the idp names
        shows the help text header (plural)
        shows the help text body (plural)
        sets HSTS header
      and the idp and group do exist but non 'en' language
        shows the organisation (entity id)
        does not show the idp logo
  POST /discovery
    when no idp selections are set
      returns a status 200
      resets the idp selection cookies
      shows that there are no organisations selected
      shows the environment name
      shows the status url
    when one idp selection is already set
      returns a status 200
      resets the idp selection cookies
      shows that there are no organisations selected
    when multiple idp selections are already set
      returns a status 200
      resets the idp selection cookies
      shows that there are no organisations selected
  GET /discovery/:group
    with an non url-safe base64 alphabet group name
      returns http status code 400
    with a non-configured group
      returns http status code 404
    with a configured group
      redirects to a unique url with the query string
      stores the id in redis
      writes an audit log entry
    without an entityID
      returns http status code 400
  GET /discovery/:group/:unique_id
    with an non url-safe base64 alphabet group name
      returns http status code 400
    with a url-safe base64 alphabet group name
      when group exists in redis and config
        returns http status code 200
        shows content
      when group exists in redis but not config
        returns http status code 404
      when group exists in config but not redis
        returns http status code 404
      when group does not exist in redis or config
        returns http status code 404
      with the idp selection set but idp no longer exists
        with cookie set for one group only
          returns http status code 200
          shows content
          resets the idp selection
        with cookie set for multiple groups
          returns http status code 200
          shows content
          resets the idp selection for the current group only
      with the idp selection set
        handles the response
        records an audit entry
      with passive and return parameters
        without cookies
          returns http status code 302
          redirects back to sp using return url and no entity id
        with cookies
          returns http status code 302
          redirects back to sp with entity id because idp is resolved from cookies
      with passive parameter but no return
        without cookies
          returns http status code 404 as no return found
        with cookies
          returns http status code 404 as no return found
        with cookies and discovery response stored
          returns http status code 302 as discovery response is used
          redirects back to sp using discovery response value
  GET /api/discovery/:group
    with group name invalid
      returns http status code 400 (bad request)
    with group not existing
      returns http status code 400 (bad request)
    with no entities existing for group
      returns http status code 200
      returns an empty list
    with one idp existing for group
      returns http status code 200
      sets the content type to application/json
      returns the entity as expected
    with idp containing only mandatory fields
      returns the idp with no keys for empty fields
    with idp and sp existing for group
      returns the idp as expected
    with many idps and sps existing for group
      returns the idps as expected
  POST /discovery/:group/:unique_id
    when group is not configured
      returns http status code 404
    when group is configured
      without mandatory entity id parameter
        returns http status code 400
      without mandatory user idp form field
        returns http status code 400
      with an invalid (non url) idp selection (form field)
        returns http status code 400
      with invalid (non url) entity id
        returns http status code 400
      with an non url-safe base64 alphabet group name
        returns http status code 400
      with unknown entity_id
        returns http status code 302
        shows error page for unknown entity
      with an entity id parameter, no return parameter and no discovery response stored
        returns http status code 404
      with an entity id parameter, no return parameter but discovery response stored
        returns http status code 302
        redirects back to sp using discovery response value
      with entity id and return parameter
        without enforcing return url configured
          returns http status code 302
          redirects back to sp using return url value
        ensure return url param is enforced per spec
          with valid return url provided
            returns http status code 302
            redirects back to sp using return url value
          with invalid return url provided
            shows error page for invalid return_url
      with the option to remember organisation on
        no idp selection previously
          returns http status code 302
          redirects back to sp using return url value
          sets a cookie for the selected idp
        with a idp selection already saved
          overwrites the cookie for the selected idp
        with a idp selection already saved for another group
          maintains the idp for the other group
      with entity id and return parameter containing a query
        returns http status code 302
        redirects back to sp using return url value
        records an audit entry
      with entity id, return and return id parameter
        returns http status code 302
        redirects back to sp using return url value and custom entity id
      with entity id, return and policy parameter
        with unsupported policy
          returns http status code 400
        with supported policy
          returns http status code 302
          redirects back to sp using return url value
      with entity id parameter, return parameter and also a discovery response
        returns http status code 302
        ignores stored discovery response value and uses return param
      with a missing idp
        returns http status code 302 as idp is not found
        redirects to /error/missing_idp as idp is not found
  GET /error/missing_idp
    responds with status code 200
    display missing idp message

DiscoveryService::Auditing
  #record_request
    returns a unique identifier
    records the request
  #record_manual_selection
    records the response
  #record_cookie_selection
    records the response

DiscoveryService::EmbeddedWAYF
  #embedded_wayf_javascript
    begins with a preamble
    renders a javascript IIFE
    includes the entities
    with a missing name
      uses the entity id as the name
    with an SP
      excludes the SP entity

DiscoveryService::EventConsignment
  #perform
    when using a stand-in SQS
NEWER VERSION AVAILABLE: Please upgrade to AWS SDK For Ruby V3
      creates the queue
    with no waiting items
      sends no events
    when the run is aborted prematurely
      leaves the in-progress events in a queue
    with a waiting item
      sends the item to SQS
      removes the item from the queue
      when SQS fails
        leaves the queue intact
        removes the identifier from the in progress list
    with many waiting items
      pushes the events in batches of 10
      removes the items from the queue
      when SQS fails
        leaves the queue intact
        removes the identifier from the in progress list
      when the second batch fails
        leaves the rest of the queue intact
        removes the identifier from the in progress list

DiscoveryService::Metadata::EntityDataFilter
  #filter(entity_data, tag_config)
    with empty arguments
      returns empty hash
    with an empty tag config
      filters everything out
    with one tag configured
      and one matching entity
        returns the matching entity
      and one matching entity amongst many
        returns the matching entity only
      and no matching entities amongst many
        returns a hash with empty entities
      and multiple matching entities
        returns all matching entities
    with multiple tags configured
      and one matching entity
        returns the matching entity
      and one matching entity amongst many
        returns the matching entity only
      and no matching entities amongst many
        returns a hash with empty entities
      and multiple matching entities
        returns all matching entities

DiscoveryService::Metadata::SAMLServiceClient
  #retrieve_entity_data(url)
    with a valid response
      disables https
      unmarshalls the payload to json as expected
      with an https url
        uses https
        unmarshalls the payload to json as expected
    with an invalid (400) response
      propagates the exception

DiscoveryService::Metadata::Updater
  #update
    with valid saml service response
      that is empty
        stores entity and page key value pairs
        stores each entity as an empty hash
        stores an empty page for each configured tag
      that contains no identity or service providers
        stores entity and page key value pairs
        stores each entity as an empty hash
        stores an empty page for each configured tag
      that contains identity and service providers
        nothing stored in redis
          stores all entities and page content
          sets an expiry for all entities
          stores each matching entity as a key value pair
          stores page content containing aaf idp
        entities already stored in redis
          only stores matching entities from the latest response
          only stores matching page content from the latest response
          generates new page content even if the entities are unchanged
          only updates the ttl for entities contained in the response
    with invalid (400) saml service response
      propagates the exception

DiscoveryService::Persistence::EntityCache
  #entities(group)
    when entities do not exist for group
      is expected to be nil
    when entities exist for group
      returns the entities as json string
  #entities_as_hash(group)
    when entities do not exist for group
      is expected to be nil
    when entities exist for group
      returns the entities as hash with key as entity id
  #entities_exist?(group)
    when entities do not exist for group
      is expected to be falsey
    when entities exist for group
      is expected to be truthy
  #save_entities(entities, group)
    is expected to eq "OK"
    the stored entity
      is a json string
  #group_page(group)
    when group page does not exist for group
      is expected to be nil
    when group page exists for group
      returns the raw content
  #group_page_exists?(group)
    when group page does not exist for group
      is expected to be falsey
    when group page exists for group
      is expected to be truthy
  #save_group_page(group, page)
    is expected to eq "OK"
    the stored page
      is expected to eq "group page content"
  #update_expiry(group)
    updates expiry
  #entities_diff(group, entities)
    returns a diff of the updated and new entity
  #default_discovery_response(group, entity_id)
    when entity does not exist
      is expected to be nil
    when entity without discovery response exists
      is expected to be nil
    when entity with discovery response exists
      should eq discovery response
  #all_discovery_response(group, entity_id)
    when entity does not exist
      is expected to be nil
    when entity without discovery response exists
      is expected to be nil
    when entity with discovery response exists
      should eq discovery response

DiscoveryService::Persistence::Keys
  #group_page_key(group)
    builds the page key
  #entities_key(group)
    builds the entities key

DiscoveryService::Renderer::Controller::Group
  #generate_group_model(entities, lang)
    with nil entities
      is expected not to be nil
      generated idps
        is expected to eq []
      generated sps
        is expected to eq []
      the tag groups
        is expected to eq []
    with no entities belonging in tag group
      the tag groups
        is expected to eq []
    with entities belonging in a tag group
      the tag groups
        get filtered
    with entity acting in multiple roles tag group
      the tag groups
        get filtered
    with multiple entities belonging in multiple tag groups
      the tag groups
        get filtered
    with empty entities
      is expected not to be nil
      generated idps
        is expected to eq []
      generated sps
        is expected to eq []
    with entities containing only mandatory fields
      is expected not to be nil
      generated idps
        builds idp as expected
      generated sps
        builds sp as expected
    with entities without names
      is expected not to be nil
      generated idps
        builds idp with entity id as name
      generated sps
        builds sp with entity id as name
    with one idp and one sp
      is expected not to be nil
      generated idps
        builds idp as expected
      generated sps
        builds sp as expected
    multiple idps and sps
      is expected not to be nil
      generated idps
        builds and sorts idps as expected
      generated sps
        builds sps as expected
    with multiple idps of different languages
      is expected not to be nil
      generated idps
        builds and sorts idps as expected
      generated sps
        is expected to eq []
    with fields requiring escaping
      is expected not to be nil
      generated idps
        builds idp with all fields escaped
      generated sps
        builds sp with all fields escaped

DiscoveryService::Renderer::Helpers::Group
  #can_hide?
    the first tag group
      can not be hidden
    the all group
      can never be hidden
    the last tag group
      can not be hidden
    the other tag groups
      can be hidden

DiscoveryService::Renderer::PageRenderer
  #render(page, model, environment)
    includes the layout
    includes the title
    shows that there are no idps
    includes the link to status
    includes the environment name
    with idps
      includes the selection string
      includes a form to submit idp selection
      includes the organisations to select
      includes a submit button for each idp
      includes the main (javascript enabled) idp selection button
      includes the organisations to select
      includes the first tab
      includes the middle tabs (allowed to be hidden)
      includes the last tab (configured as "*")
      containing a name that has already been escaped
        does not get escaped again

Finished in 3.57 seconds (files took 2 seconds to load)
235 examples, 0 failures

Coverage report generated for RSpec to /Users/bradleybeddoes/Development/aaf/discovery-service/coverage. 604 / 610 LOC (99.02%) covered.
Running RuboCop...
Inspecting 52 files
....................................................

52 files inspected, no offenses detected


Change the type for parameter values for New-AzNetworkSecurityRuleConfig

The -Priority parameter expects the integer and -DestinationPortRange expects an array of strings.
PowerShell is forgiving about converting "100" into 100, and 80 into "80", but it's better to be precise. :)

@alexandair : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"


feat(Icon): [SPC-1436] add new arrow subdirectory icon

SPC-1436
Description
Describe the changes and motivations for the pull request.
How to test

Open Storybook, navigate to Icons section and check both new icons:

ArrowSubdirectory16
ArrowSubdirectory24

Review

[x] Read CONTRIBUTING.md and Component API principles
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[ ] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit:  to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-bot run visual


SupportAnimator

where is supportanimator class? that class is not found

Which class? You mean NineOldAndroids?

no, the SupportAnimator class

I can't get you. Can you write the exact class with package? So we can solve the problem together.

io.codetail.animation.SupportAnimator;

I checked the library 2 times not found the any relationship with that class in project. Maybe, you need to re-download the library again. I can't remember that i created the SupportAnimator class.

please check ur sample at TransitionLoopFragment.java
that class using io.codetail.animation.SupportAnimator;

if you created your own demo class, you need to add dependency compile 'com.github.ozodrukh:CircularReveal:1.0.4@aar' in your build.gradle. If you want to run the demo class provided here you must sync your gradle in project to download and link the dependencies to demo.

i tried but, that dependecy is nor resolve / not found

I found the answer.  CircularReveal have been updated. I will update the demo soon. Now SupportAnimator changed to Animator


update cni to 1.2.0

update cni to 1.2.0

/test-all
/test-ipv6-only-all
/test-ipv6-all
/test-windows-all
LGTM, let's see if the tests pass.
CNI 1.2.0 introduces two new verbs: GC and STATUS. We could see if they can be helpful for better integration with runtimes after it's merged.

/test-kind-ipv6-all
/test-kind-ipv6-only-all
/test-conformance


[Android] Q4 2024 - Misc Bugs / Cleanup Tasks

### Tasks
- [ ] https://github.com/openedx/openedx-app-android/issues/109
- [ ] https://github.com/openedx/openedx-app-android/issues/365
- [ ] https://github.com/openedx/openedx-app-android/issues/123
- [ ] https://github.com/openedx/openedx-app-android/issues/224
- [ ] https://github.com/openedx/openedx-app-android/issues/369
- [ ] https://github.com/openedx/openedx-app-android/issues/165
- [ ] https://github.com/openedx/openedx-app-android/issues/153
- [ ] https://github.com/openedx/openedx-app-android/issues/206
- [ ] https://github.com/openedx/openedx-app-android/issues/207
- [ ] https://github.com/openedx/openedx-app-android/issues/209
- [ ] https://github.com/openedx/openedx-app-android/issues/210
- [ ] https://github.com/openedx/openedx-app-android/issues/231
- [ ] https://github.com/openedx/openedx-app-android/issues/232
- [ ] https://github.com/openedx/openedx-app-android/issues/131
- [ ] https://github.com/openedx/openedx-app-android/issues/193
- [ ] https://github.com/openedx/openedx-app-android/issues/141
- [ ] https://github.com/openedx/openedx-app-android/issues/329

Marking this closed as Q4 has started. Migrated all open tickets to the next epic -https://github.com/openedx/openedx-app-android/issues/411


Question about label

I wanna show this effect：

but in my codes , the effect like this：

is there some thing wrong ? how can I get that .
and can I make the "日期" from center to the left position .

Hi,
columns are indexed from 0 to numberOfColumns-1. To add label under column 'n' use AxisValue with value 'n' and set custom label using method AxisValue.setLabel("some_label"), for example:
for(int n = 0; n < numOfColumns; ++n){
    AxisValue axisValue = new AxisValue(n);
    axisValue.setLabel("you_label_for_column_n");
}

thanks for your answer !
but I still trouble in that .

this is my code . but the effect just like

is there any problem ?

Hi, try to use following code to generate labels for X axis.
List<AxisValue> list = new ArrayList<AxisValue>();

float xValue = 3.1f;
for(int columnIndex = 0; columnIndex < numColumns; ++columnIndex){
    AxisValue value = new AxisValue(columnIndex);
    value.setLabel(String.valueOf(xValue));
    list.add(value);
    xValue += 0.1f;
}

Axis axisX = new Axis(list);

thx! ,  base on your codes , now the effect like this.

but the  generate labels  may not at the right position .
besides , about

and can I make the "日期" from center to the left position .
I try to modify source code ,  make centerX to left in AxesRenderer.java(line 620) , then there are many thing have gone . so , I wanna that you can give me some tips about this problem .

Hi, I don't know why labels on your last picture are moved to the right, check if you didn't left any alignment in code after your modifications, look at column chart from LineColumnDependency Sample.
To move axis name to the left try to use following piece of code:
    //AxesRenderer line 610.
    // Drawing axis name
    final Rect contentRectMargins = computator.getContentRectMinusAxesMargins();
    if (!TextUtils.isEmpty(axis.getName())) {
        if (isAxisVertical) {
            canvas.save();
            canvas.rotate(-90, contentRectMargins.centerY(), contentRectMargins.centerY());
            canvas.drawText(axis.getName(), contentRectMargins.centerY(), nameBaselineTab[position], namePaintTab[position]);
            canvas.restore();
        } else {
            namePaintTab[position].setTextAlign(Align.LEFT);//change paint align to LEFT
            canvas.drawText(axis.getName(), contentRectMargins.left, nameBaselineTab[position],
                    namePaintTab[position]);//change text start position to contentRectMargins.left
        }
    }

thank you ! question is resolved base on you answer .

Great, thanks:)


Fix TSN errors in SCTP

Pull Request Test Coverage Report for Build 1475

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 48.511%

Totals

Change from base Build 1470:
0.01%

Covered Lines:
3795

Relevant Lines:
7823

💛  - Coveralls


[Feature Idea] release command to draft/submit a new release

Command:
hub release [flags] [SHA|COMMIT_REFERENCE|BRANCH_NAME]
Options:

--draft
-m, --message = "commit message" -- if not supplied, opens your EDITOR like git commit.
--tag=v0.2.0 uses git to tag the resolved-SHA -- potentially attaches the release details to the git tag as annotations?
--existing=draft_name References an existing draft

Open questions:

File / Tar Attachments?

This has already existed for a while in prereleases (see Releases section of this project):
$ hub help release

NAME
       hub-release - Manage GitHub releases.

SYNOPSIS
       hub release [--include-drafts] [--exclude-prereleases]
       hub release show TAG
       hub release create [-dpoc] [-a FILE] [-m MESSAGE|-F FILE] [-t TARGET] TAG
       hub release edit [options] TAG
       hub release delete TAG

@mislav I looked at: https://hub.github.com/hub.1.html -- and that doesn't have anything about this?

Oh! You said  in prereleases gotcha. Huh, 2.3.0 pre-release 10 is 6 months old. -- Is there any hope for getting that to stable in the future?

You can follow the roadmap to hub v2.3 at https://github.com/github/hub/projects/1?fullscreen=true.
If you want to install the pre-release, Try homebrew install hub --devel. If you want the bleeding edge from repo try homebrew install hub --head.


Updating SWXMLHash to 4.2.0

Allows the library to compile on Xcode 9 beta.

Thank you for your work! We already fixed this issue, so I'm closing this request.


fix: catalog short desc

Description
Fix for catalog json short description
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This issue has been resolved in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: upgrade edge-runtime to 1.18.1

What kind of change does this PR introduce?
Updates edge-runtime to 1.18.1:

Adds support to Deno.version
[perf improvement] creating user workers are non-blocking now.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.07%) to 56.651%

Files with Coverage Reduction
New Missed Lines
%

internal/debug/postgres.go
3
64.86%

internal/gen/keys/keys.go
5
12.31%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
4987

Relevant Lines:
8803

💛  - Coveralls


Refactored Email into Mixin

Refactored email into a mixin so it can easily be overridden. Currently a lot of methods in views need to be overridden just to replace the email template and such. This abstracts out the email functionality to be easily modifiable.
Subclass the view and override get_email(self): with your own email.py

Resolved in #243


Update README.md

according to:
https://stackoverflow.com/questions/13924825/safe-cast-to-hash-map
It's not implicit to cast HashMap from a Map without a potential Exception. since auth.getAttributes() returns a "Map", updating to reflect this change.

Coverage remained the same at 95.267% when pulling 305ad9fa8347f3d58976c9e051eb2cbe1a2417c2 on GaryPWhite:patch-1 into 06fff7acf19d013dcf8c598388499f07a4166905 on onelogin:master.


Nerdcommenter does not add space after comment character in init.vim by default

It seems that nerdcommenter does not add space after the " commenter character in Neovim init.vim config file. But for Python, the default settings  will add a space after #. So if we then set:
let g:NERDSpaceDelims = 1

There will be 2 spaces after the comment character # .
Minimal init.vim file to reproduce
Assume vim-plug in the plugin manager:
call plug#begin('~/.local/share/nvim/plugged')

Plug 'scrooloose/nerdcommenter'

call plug#end()

Then open a Python file using the above config and comment a statement. You will find a space after #. But if you open init.vim and comment a statement, you will find that no space is added behind ".

Thanks, this setting resolve the issue.


Support for shell variables? and for a set -xv mode?

Hi,
first i have to say, your tool is fantastic. i really love writing stuff with sh instead of bash. i have a few  proposals for enhancements:

support for a set -xv mode so i can see which actual shell commands are run? that would be helpful
is there a possibility to support shell variables? for example in bash "a=b c=d command" will have a and c as variables available (and modify commands behaviour), this is not the same as environment variables apparently (was new to me, too).

at least for the last one, i will try to make a patch, but my python is very hacky...
Yours,
Dennis

Hi Dennis, thanks for your thoughts.

This is accomplished through Python's logging:

import logging
import sh
logging.basicConfig(level=logging.INFO)
sh.ls()

Output:
INFO:sh.command:<Command '/bin/ls'>: starting process
INFO:sh.command:<Command '/bin/ls', pid 32394>: process started
INFO:sh.command:<Command '/bin/ls', pid 32394>: process completed

It won't be supported.

Okay, cool, thanks. Could you reference the first one in the documentation? it was not clear to me and i would bet i could forget it. And i suppose other people would appreciate it as well

Good idea 25862f8c454c4e1b9caf52fa861735ca3e874e3e

<3


Docs for notifications

Add docs for new notifications https://github.com/inventree/InvenTree/pull/2372

@matmair could you please have a look at updating the notifications docs for the imminent release?

@SchrodingersGat what else would you like to be documented additional to https://inventree--292.org.readthedocs.build/en/292/part/notification/

That link shows information on what notifications can be sent, but I don't think we have any overall documentation of the notification system itself.
I'd like to see a (brief) introduction to notifications:

Enabling the CoreNotifcation plugin
Activating email notifications
adding other notification methods via plugins

It only needs to be a few short paragraphs to match the refactor work you did recently

I'm happy to bump this to the next candidate


feat(table): Add a Table::segment_size method

It works just like Layout::segment_size, but for Tables.  Previously, it was impossible to distribute extra space anywhere in a Table.
Fixes #370

Does your CI process merge PRs with the main branch before running tests?  Because the test that's failing is one that isn't in my branch.  Neat, if true.

Does your CI process merge PRs with the main branch before running tests? Because the test that's failing is one that isn't in my branch. Neat, if true.

Yep :)
If it was the tabs - I just fixed that issue, so if you rebase it should be fine

Rebased.  And I squashed my commits to satisfy the commit style checker.


Level 2/3 edit

@rotycenh

OPS Build status updates of commit b045dc8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

bread/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

docs/cloud-adoption/infrastructure/subscriptions/overview.md
:white_check_mark:Succeeded
View

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\uokv\building-blocks\extending-templates\toc.json'.

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\uokv\bread\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\uokv\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 512468b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

bread/toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

docs/cloud-adoption/infrastructure/subscriptions/overview.md
:white_check_mark:Succeeded
View

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\20e3\bread\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\20e3\building-blocks\extending-templates\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\20e3\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 2d260b7:
:warning: Validation status: warnings

File
Status
Preview URL
Details

bread/toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

docs/cloud-adoption/infrastructure/subscriptions/overview.md
:white_check_mark:Succeeded
View

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\gbl4\bread\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\gbl4\building-blocks\extending-templates\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\gbl4\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 72aa181:
:warning: Validation status: warnings

File
Status
Preview URL
Details

toc.json
:warning:Warning

Details

bread/toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

docs/cloud-adoption/infrastructure/subscriptions/overview.md
:white_check_mark:Succeeded
View

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\bcx3\toc.json'.

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\bcx3\bread\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\bcx3\building-blocks\extending-templates\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


bug for sending e-mails

Hello!
There is a bug for sending e-mails in the events page. A friend of mine tried to send several e-mails through her event, but it failed ->>
www.opencollective.com/paris
URL: https://opencollective.com/mae-trips-/events/wei-2018-18757ev
capture d ecran 2018-09-01 a 16 47 49
Thank you!

The functionality is used on a daily basis by collectives and it's working.
Without more details, we can't take care of this issue. Please reopen if this happen again or if you have more information.


door detection.

Choose one of the templates below:
Feature
This pull requests adds door detection so that, as fun as it might theoretically be, the driver cannot leave the vehicle with openpilot engaged.
Description
It checks in the carstate update loop that the following values are not 1
CGW1 => CF_Gway_DrvDrSw
CGW1 => CF_Gway_AstDrSw
 CGW2 => CF_Gway_RRDrSw
CGW2 => CF_Gway_RLDrSw
Testing
brb lemme test lol

hmm this is borked. not quite sure why

tested, working

thank you very much Alice


Update Item Images

Update Item Images
some item images are missing from Amimal Corssing: New Horizons v1.2.0  e.g. Heart Crystal.
If you could update the item images, it would be great!
EDIT: I made an IMAGEZIP repository, it's completed with all v1.2.0 items!
https://github.com/MirayXS/ACNH-IMAGEZIP/releases

Wow thanks. Been waiting for this

Wow thanks. Been waiting for this

No problem :)


Prepare for release 1.1.403

ETA: ~4/9

[ ] Update changelog
[ ] Update docs based on changelog
[ ] Manual testing by @willydouhard

Hey! Do you think you guys will have time to add relaxed requirements for dataclasses_json in this release?
Using LangChain with unstructured currently gives the following error:
The conflict is caused by: chainlit 1.1.304 depends on dataclasses_json<0.6.0 and >=0.5.7 unstructured-client 0.24.1 depends on dataclasses-json>=0.6.4

Addressed in #1267

Hey! Do you think you guys will have time to add relaxed requirements for dataclasses_json in this release?
Using LangChain with unstructured currently gives the following error:
The conflict is caused by: chainlit 1.1.304 depends on dataclasses_json<0.6.0 and >=0.5.7 unstructured-client 0.24.1 depends on dataclasses-json>=0.6.4

Addressed in #1267

We'd be open to have some explicit removal of dep versions, particularly if this comes with unit tests for the interaction surface with those specific deps (so we can be sure that chainlit doesn't break if we remove < versions, now or in the future).

We're probably gonna bump the minor version due to added features.
Release PR/changelog is here: https://github.com/Chainlit/chainlit/pull/1289
Release ETA: later today.


Fix bug with assignmentrule in rate-rule inlining

Closes #43

Codecov Report
Attention: Patch coverage is 58.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 95.17%. Comparing base (a72f1dd) to head (89e0477).
Report is 11 commits behind head on main.

Files
Patch %
Lines

src/Common.jl
58.33%
10 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   95.39%   95.17%   -0.22%
==========================================
  Files          16       16
  Lines        1780     1804      +24
==========================================
+ Hits         1698     1717      +19
- Misses         82       87       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Kotlin] Fix shallow repo fetch not getting tags

3rd times a charm. When I ran the command locally it worked fine but in the github action it failed with
Run TAG=`echo $(git describe --tags --abbrev=0)`
fatal: No names found, cannot describe anything.

From this stackoverflow I discovered that the github action was making a shallow clone of the repo that did not include the tag information. This should fix that. 🤞

I feel like I'm shooting in the dark here a bit but from this updated document. It looks like this is the new way of getting all of the branches and tags https://github.com/actions/checkout 🤞 So changing to this since it's a bit cleaner.


Update asset endpoint not working /admin/api/2023-04/themes/828155753/assets.json

Not sure if this should be the repository to write.
I'm migrating an embedded shopify app to shopify cli 3.0.
Everything is working except when I try to use PUT assets endpoint to update a css asset.
Following the documentation in https://shopify.dev/docs/api/admin-rest/2023-07/resources/asset#put-themes-theme-id-assets, was always throwing me a 404 - not found error
After investigating could not find the error, and trying in postman the request:
PUT<EMAIL_ADDRESS>const body = JSON.stringify({
      asset: {
        key: themeFile,
        value: template
      }
    });

Did not work as well (also tried 2023-04).
The only way is working is using API_VERSION = 2022-10, documentation is the same for both versions, so I would think is a bug because it is not finding the asset (event when the GET request is returning it)
Could you please let me know if there is something missing in the body for these new versions? or is definitely a bug?
Thank you, I would really appreciate the help to be up to date with the latest api version.

Hi, I'm having the same issue. the version is 2023-07.


Update Office-Mac.md

Add missing "I" in "Installing"

Docs Build status updates of commit deaebd7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/overview/Office-Mac.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Access AWS Services from KServe

Is your feature request related to a problem? Please describe.
Customers want to access AWS services for inference services like pull images for private ECR and download models from S3 bucket.
Describe the solution you'd like
Do the above using IRSA

Thành Trần
16 hours ago
But I have another question: How can I add permission for my model server to pull image from my private registry ?
I am trying to test transformer: https://github.com/kserve/kserve/tree/release-0.7/docs/samples/v1beta1/transformer/torchserve_image_transformer
I build a docker image and push it into my private ECR registry. Then I create a secret (secret-registry) for my private ECR:

kubectl create secret docker-registry secret-registry \
--docker-server=80*******03.dkr.ecr.us-east-1.amazonaws.com \
--docker-username=AWS \
--docker-password=$(aws ecr get-login-password --region us-east-1) \
-n staging

Then, I create a torch_transformer.yaml file like:
apiVersion: serving.kserve.io/v1beta1
kind: InferenceService
metadata:
  name: torchserve-transformer
spec:
  transformer:
    imagePullSecrets:
    - name: secret-registry
    containers:
    - image: 80*********03.dkr.ecr.us-east-1.amazonaws.com/cnndha:image-transformer-v2
      name: kfserving-container
      env:
        - name: STORAGE_URI
          value: gs://kfserving-examples/models/torchserve/image_classifier
  predictor:
    pytorch:
      storageUri: gs://kfserving-examples/models/torchserve/image_classifier

Then:
kubectl apply -n staing -f torch_transformer.yaml
Is that correct?
Thành Trần
16 hours ago
seem like still can not pull image from private registry
Can you give me instruction please? I do not find any document about this in kubeflow aws
image.png
image.png
Suraj Kota
16 minutes ago
I would recommend using IAM Role for ServiceAccount (IRSA) approach to pull images from private ECR.
They token you are trying put in the secret will expire and if the isvc scales on a different node, it will fail to pull the image again (edited)
Suraj Kota
8 minutes ago
Create a policy with following permissions:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "ecr:BatchCheckLayerAvailability",
                "ecr:BatchGetImage",
                "ecr:GetDownloadUrlForLayer",
                "ecr:GetAuthorizationToken"
            ],
            "Resource": "*"
        }
    ]
}

Create a IAM role and attach it to a service account using IRSA
eksctl create iamserviceaccount --name image-pull-sa --namespace ${YOUR_PROFILE_NAMESPACE} --cluster ${CLUSTER_NAME} --region ${CLUSTER_REGION} --attach-policy-arn ${IAM_POLICY_ARN} --override-existing-serviceaccounts --approve
Specify this service account in the transformer spec

spec:
  transformer:
    serviceAccountName: image-pull-sa

docs.aws.amazon.comdocs.aws.amazon.com
IAM roles for service accounts - Amazon EKS
Learn how applications in your pods can access AWS services.

@surajkota @jsitu777  What is the status on this ?

@AlexandreBrown https://awslabs.github.io/kubeflow-manifests/docs/component-guides/kserve/access-aws-services-from-kserve/
Missed closing the issue


SafariDriver doesn't accept the MINUS key

As of Safari 10, SafariDriver is now shipped by Apple with Safari (see the post at https://webkit.org/blog/6900/webdriver-support-in-safari-10/). I'm closing old external safari issues because they are now obsolete.


config.audit_with :history not tracking changes to nested resources

Here are the files I'm using in this setup: https://gist.github.com/stephendavis89/6062958
When I edit through the Image form (the child resource) history is recorded as I expect. But when I edit the Image information through the Term form (the parent resource), a history entry is created with an empty message.
Rails v4.0.0
RailsAdmin v0.5.0

The legacy :history adapter was removed.


Window is not resizable with the borderless property enabled

Godot version
v4.1.stable.official
System information
Windows 10
Issue description
A window is not resizable with the borderless property enabled even though it should be.
I was trying to recreate a UI similar to the one in discord or steam, where there is no native windows window border and title bar. Those are however resizable normally.
Steps to reproduce

Enable Borderless
Enable Resizable

Minimal reproduction project
n/a

This behavior is expected.
If you want to easily simulate the behavior, anchor Controls at the Window's borders and corners and simulate the resizing yourself, with "click pressed", "mouse moved" and "click released".

Indeed, borderless removes decoration which means you will have to provide resizing yourself, AFAICT

How do apps like steam do it then?

I guess I could do it like that as well, thanks!

Reopening, as this should be documented in the class reference.

Hey,
I added it myself for Windows.
As a template of how it can work, I looked at the code from https://github.com/melak47/BorderlessWindow.
Attached is the zip with the display_server_windows .h / .cpp
and a readme for the path.
You have to compile it yourself with the source code I used the stable 4.2.1
I have also rounded the corners of the window as otherwise it somehow always rounds the corners at the top and not at the bottom as soon as you resize the window.
display_server_windows.zip


Add load-shedding package to Mixer to enable telemetry robustness.

This is an exploratory PR meant to begin to address the requirement for istio-telemetry workloads to (more) gracefully shed load. This PR was motivated by previous exploratory exchanges about the type of statistics that we wanted to use for load-shedding.
In particular, the code in this PR provides a (somewhat) flexible throttling mechanism for use in protecting the grpcServer::Report call. A loadshedding.Throttler is built based on commandline parameters and then used to determine whether or not a call should proceed. The Throttler may be run in three modes: disabled, logonly, and enforce. This (along with the monitoring provided) should hopefully enable operators to experiment with appropriate limits before turning them on completely. In subsequent PRs, I envision adding support for Throttler configuration to CtrlZ.
Two example LoadEvaluators are provided in this PR:

GRPCLatencyEvaluator which implements the gRPC stats.Handler interface and samples response latencies to track the average response time of Mixer in order to evaluate load.
RateLimitEvaluator which wraps a rate.Limiter to enforce overall rate limits on the process.

Manual testing has been conducted along these lines:
$ KUBECONFIG=~/.kube/config mixs server --configStoreURL=fs://$(pwd)/mixer/testdata/config --averageLatencyThreshold=2ms --maxRequestsPerSecond=4 --burstSize=1 --loadsheddingMode=enforce --log_output_level=loadshedding:debug

$ mixc report -c 4 -r 1000 -s context.protocol="http",destination.service="test",request.path="/doug-test",destination.uid="kubernetes://productpage-v1-79b8db5f94-dg4pw.crazy" -t request.time="2018-01-29T12:12:14Z",response.time="2018-01-29T12:12:15Z" --bytes_attributes destination.ip="a:3c:00:1a" --stringmap_attributes request.headers=x-b3-traceid:2141234123412344abfe

Reviewers:
In developing this PR, I found myself a bit torn between trying to create a general purpose throttling mechanism and a Mixer-tailored mechanism. As a result, I'm not totally in love with the current shape of the API surface, but I don't want to keep tinkering in isolation.
I'm interested in feedback on the overall utility of the package. If it looks somewhat reasonable, I'm also interested in suggestions for improvements of the functionality, etc.
Tests added. For the loadshedding package: coverage: 93.6% of statements.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
If they are not already assigned, you can assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
250b8cb9dbd89693633fd5837a45f41298418e76
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

We really need this in 1.1.

@douglas-reid: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d386a893d6e79f90b8ea0238877f888fdabdad99
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d386a893d6e79f90b8ea0238877f888fdabdad99
link
/test istio-unit-tests

prow/istio-presubmit.sh
d386a893d6e79f90b8ea0238877f888fdabdad99
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
d386a893d6e79f90b8ea0238877f888fdabdad99
link
/test istio-presubmit

prow/istio-unit-tests.sh
322bdee9018e58a64c00f0d0f65d00074a6c3569
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
322bdee9018e58a64c00f0d0f65d00074a6c3569
link
/test istio-unit-tests

prow/istio-presubmit.sh
322bdee9018e58a64c00f0d0f65d00074a6c3569
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d2ad0eb5489a398b11ad4002cb3f03b70e539c52
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d2ad0eb5489a398b11ad4002cb3f03b70e539c52
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d77dbfebcba76e12dc114cf91ce749f0089002bb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I'm curious, have you thought about client-side load shedding strategy? I assume the client should retry within a budget after load rebalancing? If so, we might need to tweak the client setting to do that, as well as propagate the load signal to k8s to allocate more jobs for the service.

/test istio-pilot-e2e-envoyv2-v1alpha3

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a3fa0663d84a71b436db98d72c32912f4f24efca
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov we have discussed client-side load shedding, but have not yet addressed. I believe that we will want to introduce some retry config in the destination rules, etc., for istio-policy and istio-telemetry. As for sending the signal to k8s, I'm not sure of the proper way to do that, but I believe we can begin to investigate HPA with custom metrics.

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
b90b622b9ee31009adaf217dacb87eca6821946c
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
b90b622b9ee31009adaf217dacb87eca6821946c
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
b90b622b9ee31009adaf217dacb87eca6821946c
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ping.

Reviewers: PTAL. This PR is already in 1.0.X. It should be merged here and then added to master too.

Ping again.


Add method to get just the text from the gemini response

Pull Request
Description
When building a project recently that employed this SDK, I found the process of retrieving the actual text from the Gemini response a bit tedious. It's great that there is a lot of info sent in the API response, however for my use case (and I suspect a lot of other people's), really just the text is needed. This method does the heavy lifting, and just returns a list of strings (in case there was more than 1 text response).
Type of Change
Please delete options that are not relevant.

[ ] Bug Fix (non-breaking change which fixes an issue)
[X] New Feature (non-breaking change which adds functionality)
[ ] Breaking Change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (correction or addition to documentation)

Checklist
Please review the checklist before submitting the pull request:

[X] My code follows the code style of this project.
[X] My changes generate no new warnings or errors.
[X] I have added tests to cover my changes, if applicable.
[X] All new and existing tests passed.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.

Screenshots (if applicable)
Add screenshots to help explain your changes if they are relevant.
Additional Context
Add any other context about the pull request here.

Thanks for contribution!
I'll test once and include it for the next release


Add blocPresentationTest function

This PR adds blocPresentationTest function which can be used for presentation events verification.
I decided not to use testBloc function from bloc_test package because of below reasons:

in some cases, we will need to throw TestFailure and then, catch it and throw new TestFailure with updated description which is not optimal
we will not be able to wrap test callback in one runZoneGuarded function
it will not be working in a similar way how testBloc
we will have less control over the blocPresentationTest function

Let's release this as 1.0.0-pre.1


High variability when running simple code using dart2native and AOT

Hi! I'm using Dart SDK version 2.9.1 (stable) on a LXC container in Ubuntu 20 and I've observed some variations in runtime using Dart. For instance, this simple code that reads two numbers and print the sum has runtimes of 0.0s up to 0.9s. I noticed the same runtime variability with and without AOT. Is this normal, or there is something that can be done to make the runtime more consistent between consecutive runs?
import 'dart:io';

void main()
{
    int a = int.parse(stdin.readLineSync());
    int b = int.parse(stdin.readLineSync());

    int soma = a + b;

    print("X = $soma");
}

Time: 0.008
Time: 0.973
Time: 0.000
Time: 0.000
Time: 0.000
This is using a couple of repetitions only, but the same behavior is observed when repeating 100 times or more, with the random high runtime randomly being observed.

This high a variability is unlikely to come from the execution of the code shown here. It's more likely that it's I/O based, so maybe something is holding up the input lines that you read from stdin.

There is some natural variability in execution. I don't think there is anything we can do here.


Create table separation in event details page.

Show some distinction between the event details and the metadata.

Is this too much separation for you @vphill?


GitHub Enterprise collector does not support SAML authentication

SAML authentication isn't really the correct term but the collector really doesn't support authentication. If a GHE instance is behind a firewall and is access controlled then the collector is unable to authenticate itself to grab the repo information. There is not way through the UI or through an environment variable to authenticate itself.

@camillone Need a little more on the auth. Is it GHE token based auth? Or userid/password based basic auth? In either case, is there an "admin" type of access that can read all repo? This will be easy to implement. The collector as of now can actually read a repo with user id/password based auth. We just need to change the UI and some API to accept the user id/password from the UI.

Please reopen if this is still a valid issue.


removeViewBox breaks scaling SVGs with CSS

#139 deals with a similar topic, but this is true for inline SVGs across browsers. I'd argue removeViewBox should be off by default.
Example:
<html><head>
  <style>
    svg {
      width: 50px;
      height: 50px;
    }
  </style>
</head><body>
  <svg width="100" height="100" viewBox="0 0 100 100">
    <circle fill="green" cx="50" cy="50" r="50"></circle>
  </svg>
  <svg width="100" height="100">
    <circle fill="red" cx="50" cy="50" r="50"></circle>
  </svg>
</body></html>

Rendered:

That's incorrect styling in a page and has nothing to do with SVGO. SVGO doesn't know anything about context in which image is used, so responsobility for its usage lies on whoever runs it.

@GreLI What about that is incorrect?

<style>
    svg {
      width: 50px;
      height: 50px;
    }
  </style>

overrides inline attributes styles, so they aren't source of truth anymore.