src/Make_mvc.mak fails for quoted values of SDK_INCLUDE_DIR

using msvs 2012 express for desktop
nmake version 11.00.51106.1

while following the instructions on lines 18-19 of src/Make_mvc.mak causes
nmake to complain and result in a fatal error. i eventually found putting
quotes in the var SDK_INCLUDE_DIR to be the culprit.

e:\projects\vim\src>set SDK_INCLUDE_DIR="C:\Program Files (x86)\Microsoft
SDKs\Windows\v7.1\Include"

removing the quotes enables everything to work fine but feels a little scary.
an alternative is to make use of nmake's INCLUDE macro:

INCLUDE=$(SDK_INCLUDE_DIR);$(INCLUDE)

then use angle brackets as usual:

!include <Win32.mak>

this works great but the INCLUDE macro will also need to be updated in GvimExt
Makefile as well if it is desired to build GvimExt on its own and that could
result in some weirdness since you'll be duplicating the SDK_INCLUDE_DIR in
nmakes INCLUDE paths.

attached is a diff with these changes to the makefiles and including an
additional .bat for setting the msvs 2012 environment.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 16 Feb 2013 at 10:30
Attachments:

msvs_2012_makefile_updates.diff

while following the instructions on lines 18-19 of src/Make_mvc.mak causes nmake to complain and result in a fatal error.

Actually, the instructions intended to use it as a parameter of nmake:
nmake -f Make_mvc.mak SDK_INCLUDE_DIR="C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1\Include"

No need to quote when set is used:
set SDK_INCLUDE_DIR=C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1\Include
nmake -f Make_mvc.mak

And the following should also work:
set "SDK_INCLUDE_DIR=C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1\Include"
nmake -f Make_mvc.mak

Moreover, we don't need to set SDK_INCLUDE_DIR anymore if we use Vim 8.0.0881 or later and targeting Windows Vista or later.
So closing.


Build produces warning Script 'build.gradle.kts' is not supposed to be used along with regular Kotlin sources, and will be ignored in the future versions by default."

Expected Behavior
No warning in INFO logs for Kotlin DSL scripts when running build with Gradle 8.0-rc-1+ version.
Current Behavior
Warning is printed in INFO level logs for any *.gradle.kts file.
Steps to Reproduce
Check repro project from this Kotlin issue

The reproducer shows that what is displayed by the Kotlin Gradle Plugin is not a warning anymore since the addition of isStandalone(false) in the Gradle script templates. It is not emited to the info logger.
Waiting for confirmation from the Kotlin team that this is expected.

Fixed in https://github.com/gradle/gradle/pull/23558

This will ship in Gradle 8.0


Add option to create more snapshot create & recall actions in the S&M.ini file.

Hi!
I know we can expand the number of slots available for the SWS resource window (up to 255 if I'm correct) by moding the S&M.ini file but I can't find a line related to snapshot actions.
I find 12 snapshots actions a little bit short for more demanding workflow.
It would be awesome!

From the SWS change log (old entry from 2014, admittedly I missed this too till now):

Snapshots: the default number of recall actions is now configurable in REAPER.ini
Edit the key "DefaultNbSnapsRecall" in the section [SWS] (quit REAPER before editing this file!)

Number of 'Save as snapshot n' actions can't be set dynamically currently though.

Awesome!
I didn't know there were some SWS options in the Reaper.ini file

New recall actions are automatically added as additional snapshots are created.
I think it makes sense for both of these actions to have their quantity configurable via S&M.ini like all the other SWS dynamic actions. Working on a patch (with DefaultNbSnapsRecall automatically moved into S&M.ini)...
I don't know whether new "Save as snapshot" actions should also be added as new snapshots are created. Any opinions?
Also DefaultNbSnapsRecall is currently unbounded, so big values can break REAPER as it can attempt to register more actions than is possible within the 16-bit command ID limit. Migrating to S&M.ini will also fix that by limiting it to 255.

I'm not sure whether new "Save snapshot n" actions should also be added as new snapshots are created. Any opinions?

If you make the default quantity configurable I'd think it should be fine as is.


MODINREACH 69

Purpose
Add open-api description for Local Server REST API
Approach

Update open-api yml file
Update the code to use auto-generated API, DTO classes

Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added, or removed?
[ ] Are there new interface dependencies?
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

INFO: api-schema-lint: Using api-schema-lint version: 1.0.4
INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/)
INFO: api-schema-lint: Found 10 JSON schema files under directory 'src/main/resources/swagger.api'
ERROR: api-schema-lint: src/main/resources/swagger.api/schemas/centralServersDTO.json: Missing "description" for: centralServers
ERROR: api-schema-lint: There were processing errors. See list above.

Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport.


Compiler doesn't understand arrow functions?

Hi, I am declaring a component in a .jsx file in the following manner:
class SearchBox extends React.Component {

    constructor(props){
        super(props);
    }

     onChange = (e) => {
         console.log('CHANGED');
     }

    render (){
        return <input type="text" className="form-control" placeholder={this.props.placeholder} onChange= {this.onChange} />
    }
}

I get the attached compiler error with this code. Is there something I am doing wrong/need to change, or is it not possible to use arrow functions in jsx files with React.NET?
Thanks!

These are not regular arrow functions, they're an experimental proposal for class instance fields by @jeffmo. Experimental features like this are not enabled by default. You'll need to set Babel to stage 0 in your config:
config.BabelConfig.Stage = 0;

(this config syntax will be changing a bit with Babel 6, but it'll be configured similarly)


Mock | Json Server - Categories

My Wallets Tab
Wallet Details
Create mock for given endpoint - "/api/categories"
Example data
[{"id":1,"name":"shopping","type":"EXPENSE","userId":2},{"id":2,"name":"clothes","type":"EXPENSE","userId":2},{"id":3,"name":"fuel","type":"EXPENSE","userId":1},{"id":4,"name":"entertainment","type":"EXPENSE","userId":2},{"id":5,"name":"eating","type":"EXPENSE","userId":3},{"id":6,"name":"others","type":"EXPENSE","userId":3},{"id":7,"name":"salary","type":"INCOME","userId":1},{"id":8,"name":"my own business","type":"INCOME","userId":1},{"id":9,"name":"others","type":"INCOME","userId":2}]

Prosiłbym o przypisanie.


Android O StrictMode: Untagged socket detected

If we use StrictMode with VmPolicy detectAll() in Android O (Preview 6) we get errors in logcat like this:
08-23 14:41:03.439 E/StrictMode: null
                                 java.lang.Throwable: Untagged socket detected; use TrafficStats.setThreadSocketTag() to track all network usage
                                     at android.os.StrictMode.onUntaggedSocket(StrictMode.java:2010)
                                     at com.android.server.NetworkManagementSocketTagger.tag(NetworkManagementSocketTagger.java:78)
                                     at libcore.io.BlockGuardOs.tagSocket(BlockGuardOs.java:47)
                                     at libcore.io.BlockGuardOs.socket(BlockGuardOs.java:310)
                                     at libcore.io.IoBridge.socket(IoBridge.java:667)
                                     at java.net.PlainSocketImpl.socketCreate(PlainSocketImpl.java:116)
                                     at java.net.AbstractPlainSocketImpl.create(AbstractPlainSocketImpl.java:98)
                                     at java.net.Socket.createImpl(Socket.java:484)
                                     at java.net.Socket.getImpl(Socket.java:547)
                                     at java.net.Socket.setSoTimeout(Socket.java:1175)
                                     at okhttp3.internal.connection.RealConnection.connectSocket(RealConnection.java:221)
                                     at okhttp3.internal.connection.RealConnection.connect(RealConnection.java:149)
                                     at okhttp3.internal.connection.StreamAllocation.findConnection(StreamAllocation.java:195)
                                     at okhttp3.internal.connection.StreamAllocation.findHealthyConnection(StreamAllocation.java:121)
                                     at okhttp3.internal.connection.StreamAllocation.newStream(StreamAllocation.java:100)
                                     at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.java:42)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
                                     at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:93)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
                                     at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
                                     at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:120)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
                                     at <internal>
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
                                     at okhttp3.logging.HttpLoggingInterceptor.intercept(HttpLoggingInterceptor.java:211)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
                                     at <internal>
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
                                     at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
                                     at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:185)
                                     at okhttp3.RealCall.execute(RealCall.java:69)
                                     at retrofit2.OkHttpCall.execute(OkHttpCall.java:180)
                                     at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall.execute(ExecutorCallAdapterFactory.java:91)
                                    at <internal>
                                     at <internal>
                                     at io.reactivex.internal.operators.observable.ObservableCreate.subscribeActual(ObservableCreate.java:40)
                                     at io.reactivex.Observable.subscribe(Observable.java:10903)
                                     at io.reactivex.internal.operators.observable.ObservableObserveOn.subscribeActual(ObservableObserveOn.java:45)
                                     at io.reactivex.Observable.subscribe(Observable.java:10903)
                                     at io.reactivex.internal.operators.observable.ObservableDoOnEach.subscribeActual(ObservableDoOnEach.java:42)
                                     at io.reactivex.Observable.subscribe(Observable.java:10903)
08-23 14:41:03.440 E/StrictMode:     at io.reactivex.internal.operators.observable.ObservableDefer.subscribeActual(ObservableDefer.java:39)
                                     at io.reactivex.Observable.subscribe(Observable.java:10903)
                                     at io.reactivex.internal.operators.observable.ObservableSubscribeOn$SubscribeTask.run(ObservableSubscribeOn.java:96)
                                     at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:452)
                                     at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:61)
                                     at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:52)
                                     at java.util.concurrent.FutureTask.run(FutureTask.java:266)
                                     at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
                                     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
                                     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
                                     at java.lang.Thread.run(Thread.java:764)

From what I can tell, this happens because the sockets are untagged - is that something okhttp might want to support?

It used to be supported and was removed. I looked at adding it back a few months ago, but it's weird because of HTTP/2. The easiest thing to do is probably tag them with a random int that we declare as being OkHttp and not bothering to differentiate per-request.

I’m looking deeper into this. There’s a bunch of things that makes fixing this unsatisfying.
The way socket tagging works on Android is as follows:

Every thread gets a tag. Application code is supposed to set this with getAndSetThreadStatsTag().
When a socket is created, it inherits the tag of its creating thread.

This doesn’t map neatly to the HTTP protocol, or to OkHttp’s design. In particular:

OkHttp creates its own threads for async requests, and for HTTP/2. Who is responsible for assigning the tags for these threads?
HTTP/2 connections are be multiplexed across calls. Because multiple OkHttpClient instances can share a ConnectionPool, it’s even possible for an HTTP/2 connection to be shared by multiple OkHttpClients.

We could just blast a tag like 2007230 across all threads we touch, and the warning would disappear. But there would be negligible value to having such a tag.
I’m going to icebox this because all of the fixes I can imagine add considerable code and don’t provide additional value to the TrafficStats aggregate.

there would be negligible value to having such a tag

Suppose a dev team sets penaltyDeath() for all strict mode violations in their internal app builds, so as to make it really obvious when a strict mode violation is introduced. OkHttp currently causes such builds to die. I think "fixing" this has value in itself, even if the tag is arbitrary and adds no further value. So it seems worthwhile to add an arbitrary tag just to make the strict mode violation go away?

If you don't need a proxy configured, is this a suitable workaround for now?
public class XxX {
  public static void main(String[] args) throws IOException {
    SocketFactory socketFactory = new DelegatingSocketFactory(SocketFactory.getDefault()) {
      @Override protected Socket configureSocket(Socket socket) throws IOException {
        // set android
        TrafficStats.tagSocket(socket);

        System.out.println("configured");

        return socket;
      }
    };
    OkHttpClient client = new OkHttpClient.Builder().socketFactory(socketFactory).build();

    Request req = new Request.Builder().url("https://google.com/robots.txt").build();
    try (Response response = client.newCall(req).execute()) {
      System.out.println(response.body.string().length());
    }
  }
}

Is there any update or workaround on this?

See above
On Mon, Sep 25, 2017, 10:34 PM Wooram<EMAIL_ADDRESS>wrote:

Is there any update or workaround on this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/issues/3537#issuecomment-332068832, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEEEawQBXQCdXRYEDiCcKlHt7BLV8RHks5smGLSgaJpZM4O_9Zh
.

i am facing same issue please help

Hi @swankjesse ,
so have you decided which fix strategy to pursue ? BR

The current policy which I don't think you will like is if you want to enable strict mode, you should also apply the workaround I posted above.  There isn't a clean way to do this for library code like OkHttp given HTTP/2, and no current plans to implement tagging with an arbitrary number.
Worth keeping this open as 13 +1 suggests it's a popular topic.

The proposed workaround does not work for me. StrictMode now complains from the TrafficStats#tagSocket call:
java.lang.Throwable: Untagged socket detected; use TrafficStats.setThreadSocketTag() to track all network usage
    at android.os.StrictMode.onUntaggedSocket(StrictMode.java:2010)
    at com.android.server.NetworkManagementSocketTagger.tag(NetworkManagementSocketTagger.java:78)
    at dalvik.system.SocketTagger.tag(SocketTagger.java:55)
    at android.net.TrafficStats.tagSocket(TrafficStats.java:274)
    at com.foo.ApiService$1.configureSocket(ApiService.java:164)
    at com.foo.util.okhttp3.DelegatingSocketFactory.createSocket(DelegatingSocketFactory.java:36)
    ...

Setting an arbitrary tag through the DelegatingSocketFactory instead of calling TrafficStats#tagSocket, though, seems to work. How much worse is that workaround?

I have tried @yschimke solution but it still gives me same error

As suggested in the warning message, I've applied TrafficStats.setThreadStatsTag(1) instead of TrafficStats.tagSocket(socket), the rest is the same as provided in the comment of yschimke.

Whether the latest version has fixed this problem?

@zhangchaojiong No, you should use a workaround see comment by @azizbekian.  See @swankjesse comment above for why we don't have a clean automatic solution for OkHttp.

Any news on this issue? We use several dependencies which also have the problem. Waiting until every dependency implements this workaround isn't suitable. A solution in okhttp itself would definitely be the preferred way.
Since PR #1101 is already merged, are there any plans for the next release? @yschimke @JakeWharton

I just add and execute this code prior to open any socket connection, recommended in
https://stackoverflow.com/questions/47723973/strictmode-java-lang-throwable-untagged-socket-detected it fixes the problem:
private static final int THREAD_ID = 10000;
TrafficStats.setThreadStatsTag(THREAD_ID);
....
socket.connect(socketAddress, socketConnectTimeout);

How I can set it up for picasso?

For some reason, I couldn't import DelegatingSocketFactory.

I took a look at this again, even looking at Android specific code and a SocketFactory that sets the thread tag.  But that implementation isn't called if we hit a proxy.  Then the connect call might happen without that invocation.
So best workaround is problem implementing this in an EventListener.connectStart, if you are really keen this happens.
Closing for now as won't fix in OkHttp.

I am also facing same issuse so should I just add a tag and it will be resolved?

This issue can be closed. To be clear, OKHttp doesn't spontaneously issue HTTP requests and cannot know what is the content it transports. The tagging should be done by the caller with TrafficStats.setThreadStatsTag() as indicated in https://stackoverflow.com/a/57963770/94363

If I use a 3rd party sdk that doesn't add the tag themself, is there a way to provide a "default tag strategy" to OkHttp so I don't need to wait on all 3rd party sdk to fix their tag themself ?

@damienmabin not as far as I know.

Firebase Crashlytics is affected by this issue... Is the only way removing detectUntaggedSockets() or is there some other workaround for 3rd party sdks like Crashlytics?

If you can't change their socket factory, then removing detectUntaggedSockets() is the only option.  Assuming no proxies involved, they could add this into the SDK, but I'm not sure they have the motivation.


reduce bundle size by adding standalone icons

:tada: This PR is included in version 1.2.0-rc.19 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Edge chromium doesn't run in app mode

Eel version
0.14
Describe the bug
hi, i'm trying to open an empty window in eel using edge chromium and it does work but it opens a new tab instead of a window in app mode. does anyone know how to fix this?
To Reproduce
run the following code:
import eel

eel.init("web")

eel.start("main.html", mode="edge", app_mode=True)

Expected behavior
an edge window should open in app mode instead of a new tab.
Screenshots
n/a
Desktop (please complete the following information):

OS: windows 10
Browser: edge chromium
Version: 104.0.1293.54

Additional context
n/a

hey so i think i found the problem. apparently in edge.py to launch edge eel runs a method called run() and there it does sps.Popen() with the argument "start microsoft-edge:http://localhost:8000/main.html" and that just opens a new tab in edge.
i found this question on stackoverflow where it shows the right command to run in order to open edge as an app to a certain website:
https://stackoverflow.com/questions/66748958/how-to-open-website-as-app-in-microsoft-edge-from-cli
can you change the cmd argument at line 9 to take "start msedge --new-window --app=http://localhost:8000/main.html" ?

thank you

also, apparently run() doesn't want to pass any arguments to the cmd variable:

does anyone know how to fix this?

As you pointed out, it looks like a code update is required.
A related design question... is there any reason to preserve the ability to open up content in a new tab (which might suggest a flag or similar is needed)? I can't think of one... does anyone else have a valid use case?

Hey @properchopsticks can you review pull request #612 and confirm that it meets your needs?

So! A few things to cover off here.

@properchopsticks - you shouldn't need to wait on a fix from Eel authors to get around this. You can set the mode to 'custom' and then pass the full launch command under cmdline_args, eg something like cmdline_args="start msedge --new-window --app=https://localhost:8000"

We should probably still fix the app_mode option to work correctly for Edge. init.py:49 suggests this is a Chrome only option so we probably need to update the comment there as well if it can be generally supported for other browsers.

A related design question... is there any reason to preserve the ability to open up content in a new tab (which might suggest a flag or similar is needed)? I can't think of one... does anyone else have a valid use case?

I think if there is current behaviour in Eel to support opening pages as tabs (including when multiple start_urls are provided, we shouldn't remove that without a bit more consideration. I'm not sure off the top of my head honestly if this is possible - so we probably need to investigate it first. But if it is, let's not remove or change that functionality without thinking it through. If we do it's a breaking change and should be announced clearly (normally this would mean a major version bump but while we're <1.0.0 we have a bit more leeway).


Get modelID for non living agents

Currently you can change colors on all living agents on the minimap as the info tab pulls their model ID which is needed to make said change.
But if you want to change ID on things like chests, there's no model ID pulled and thus not change of color is possible.
Is it possible to pull the model ID of all agents, living or not?

https://github.com/gwdevhub/GWToolboxpp/commit/4fdaf8ea057b407d702e2f0d2e3799b926342eac
uses gadget id. gadgets do not have a model id.


[BUG] FRR Routing over Wireguard

Describe the bug
With the update to Version 20.7 the routing over wireguard links  don't func.
I have testet BGP, OSPF, OSPF3.
BGP Debug Output
IPv4 Unicast Summary:
BGP router identifier <IP_ADDRESS>, local AS number<PHONE_NUMBER> vrf-id 0
BGP table version 3
RIB entries 5, using 960 bytes of memory
Peers 2, using 29 KiB of memory

Neighbor        V         AS   MsgRcvd   MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd   PfxSnt
<IP_ADDRESS>      4      64701     12817     12561        0    0    0 5d07h10m     (Policy) (Policy)
<IP_ADDRESS>      4      64800         0         0        0    0    0    never      Connect        0

Total number of neighbors 2

Relevant log files

02.08.2020 | 22:01:09 | ZEBRA | [EC<PHONE_NUMBER>] warning: interface wg0 has same local and peer address <IP_ADDRESS>, routing protocols may malfunction
-- | -- | -- | --
02.08.2020 | 22:01:10 | BGP | [EC 100663301] INTERFACE_STATE: Cannot find IF tun1 in VRF 0
02.08.2020 | 22:01:10 | BGP | [EC 100663301] INTERFACE_STATE: Cannot find IF tun1 in VRF 0
02.08.2020 | 22:01:10 | OSPF | [EC 100663301] INTERFACE_STATE: Cannot find IF tun1 in VRF 0
02.08.2020 | 22:01:10 | BGP | [EC 100663301] INTERFACE_STATE: Cannot find IF tun1 in VRF 0
02.08.2020 | 22:01:10 | ZEBRA | [EC<PHONE_NUMBER>] warning: interface wg1 has same local and peer address <IP_ADDRESS>, routing protocols may malfunction
02.08.2020 | 22:01:10 | ZEBRA | [EC 100663303] vrf_if_ioctl(SIOCGIFFLAGS) failed: Device not configured
02.08.2020 | 22:01:10 | BGP | [EC 100663301] INTERFACE_STATE: Cannot find IF tun2 in VRF 0
02.08.2020 | 22:01:10 | ZEBRA | [EC<PHONE_NUMBER>] warning: interface wg2 has same local and peer address <IP_ADDRESS>, routing protocols may malfunction
02.08.2020 | 23:49:53 | ZEBRA | Terminating on signal
-- | -- | -- | --
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 20: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 21: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 22: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 25: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663299] buffer_flush_available: write error on fd 2: Bad file descriptor
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 20: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 21: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 22: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 25: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663299] buffer_flush_available: write error on fd 2: Bad file descriptor
02.08.2020 | 23:49:53 | ZEBRA | client 11 says hello and bids fair to announce only ospf routes vrf=0
02.08.2020 | 23:49:53 | BGP | [EC 33554499] sendmsg_nexthop: zclient_send_message() failed
02.08.2020 | 23:49:53 | BGP | [EC 33554499] sendmsg_nexthop: zclient_send_message() failed
02.08.2020 | 23:49:53 | BGP | [EC 33554499] sendmsg_nexthop: zclient_send_message() failed
02.08.2020 | 23:49:53 | ZEBRA | client 25 says hello and bids fair to announce only bgp routes vrf=0
02.08.2020 | 23:49:53 | ZEBRA | client 28 says hello and bids fair to announce only vnc routes vrf=0
04.08.2020 | 17:48:24 | BGP | [EC 33554454] <IP_ADDRESS> [Error] bgp_read_packet error: Operation timed out
04.08.2020 | 18:06:45 | BGP | [EC 33554454] <IP_ADDRESS> [Error] bgp_read_packet error: Operation timed out
05.08.2020 | 08:36:31 | BGP | [EC 33554454] <IP_ADDRESS> [Error] bgp_read_packet error: Operation timed out
06.08.2020 | 09:48:42 | BGP | [EC 33554454] <IP_ADDRESS> [Error] bgp_read_packet error: Operation timed out
06.08.2020 | 09:51:02 | BGP | [EC 33554454] <IP_ADDRESS> [Error] bgp_read_packet error: Operation timed out
11.08.2020 | 12:30:06 | ZEBRA | [EC 100663299] can't accept vty socket : Software caused connection abort

Environment
OPNsense 20.7-amd64
FreeBSD 12.1-RELEASE-p7-HBSD
OpenSSL 1.1.1g 21 Apr 2020
Libvirt - Qemu: Intel Core Processor (Skylake, IBRS) (2 cores)

Can you revert frr to 20.7r1 version and check again?

how can i install a specified version? Then i can install a test net system.

how can i install a specified version? Then i can install a test net system.

From CLI use following command to rollback FRR:
opnsense-revert -r 20.1.r1 frr7

BGP is fixed with https://github.com/opnsense/plugins/pull/1953
the ospf network errors already exists

But the error you posted is not related to ebgp policy?
So, the same error for all with 7.3?

BGP is ok with #1953.
OSPF: don't send there own networks.
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 20: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 21: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 22: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 25: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663299] buffer_flush_available: write error on fd 2: Bad file descriptor
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 20: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 21: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 22: network <IP_ADDRESS>/24 area <IP_ADDRESS>
02.08.2020 | 23:49:53 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 25: network <IP_ADDRESS>/24 area <IP_ADDRESS>

Only when i set ospf redistributing routes to connected routes, but then all public ips send allso.

And again the third time, is this error gone with 7.3?

no , this is all tested with
opnsense-revert -r 20.7.r1 frr7

The Log after config set and reboot:

12.08.2020 | 14:44:43 | BGP | Terminating on signal
-- | -- | -- | --
12.08.2020 | 14:44:43 | ZEBRA | Terminating on signal
12.08.2020 | 14:44:43 | OSPF6 | Terminating on signal SIGTERM
12.08.2020 | 14:44:43 | OSPF | Terminating on signal
12.08.2020 | 14:44:43 | ZEBRA | [EC<PHONE_NUMBER>] Client 'ospf6' encountered an error and is shutting down.
12.08.2020 | 14:44:43 | ZEBRA | client 11 disconnected 12 ospf routes removed from the rib
12.08.2020 | 14:44:43 | ZEBRA | zebra/zebra_ptm.c:1351 failed to find process pid registration
12.08.2020 | 14:44:43 | ZEBRA | client 25 disconnected 10 bgp routes removed from the rib
12.08.2020 | 14:44:43 | ZEBRA | client 28 disconnected 0 vnc routes removed from the rib
12.08.2020 | 14:44:43 | ZEBRA | client 35 disconnected 2 ospf6 routes removed from the rib
12.08.2020 | 14:44:43 | BGP | [EC 100663299] buffer_write: write error on fd 12: Broken pipe
12.08.2020 | 14:44:43 | BGP | [EC 100663302] zclient_send_message: buffer_write failed to zclient fd 12, closing
12.08.2020 | 14:44:43 | BGP | [EC 33554499] sendmsg_nexthop: zclient_send_message() failed
12.08.2020 | 14:44:43 | BGP | [EC 33554499] sendmsg_nexthop: zclient_send_message() failed
12.08.2020 | 14:45:38 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 25: network <IP_ADDRESS>/24 area <IP_ADDRESS>
12.08.2020 | 14:45:38 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 26: network <IP_ADDRESS>/24 area <IP_ADDRESS>
12.08.2020 | 14:45:38 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 27: network <IP_ADDRESS>/24 area <IP_ADDRESS>
12.08.2020 | 14:45:38 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 30: network <IP_ADDRESS>/24 area <IP_ADDRESS>
12.08.2020 | 14:45:38 | ZEBRA | client 9 says hello and bids fair to announce only ospf routes vrf=0
12.08.2020 | 14:45:38 | OSPF | [EC 100663299] buffer_flush_available: write error on fd 2: Bad file descriptor
12.08.2020 | 14:45:38 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 25: network <IP_ADDRESS>/24 area <IP_ADDRESS>
12.08.2020 | 14:45:38 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 26: network <IP_ADDRESS>/24 area <IP_ADDRESS>
12.08.2020 | 14:45:38 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 27: network <IP_ADDRESS>/24 area <IP_ADDRESS>
12.08.2020 | 14:45:38 | OSPF | [EC 100663304] ERROR: Command returned Warning Config Failed on config line 30: network <IP_ADDRESS>/24 area <IP_ADDRESS>
12.08.2020 | 14:45:38 | OSPF | [EC 100663299] buffer_flush_available: write error on fd 2: Bad file descriptor
12.08.2020 | 14:45:38 | ZEBRA | client 23 says hello and bids fair to announce only bgp routes vrf=0
12.08.2020 | 14:45:38 | ZEBRA | client 26 says hello and bids fair to announce only vnc routes vrf=0
12.08.2020 | 14:45:38 | OSPF6 | [EC 100663304] ERROR: No such command on config line 18: router-id <IP_ADDRESS>
12.08.2020 | 14:45:39 | OSPF6 | [EC 100663304] ERROR: No such command on config line 18: router-id <IP_ADDRESS>
12.08.2020 | 14:45:39 | ZEBRA | client 33 says hello and bids fair to announce only ospf6 routes vrf=0

/usr/local/etc/frr/ospfd.conf
!
!

 I cant test it myself but the Initial error regarding WireGuard Interface is gone.

It must be your configuration. OSPF/OSPFv3 via wireguard works fine. Try it with point-to-point network.
interface wg0  ip ospf area <IP_ADDRESS>  ipv6 ospf6 network point-to-point

@QDaniel can you verify please?


[coq] Bump Proof General to latest version

New support for vos compilation in Coq 8.11+.

I've bumped the module in e7993cc. I've done it myself because bump commit messages need to follow a particular format (which I haven't documented anywhere yet), for the sake of future CI. In any case, thanks for bringing it to my attention!

Sounds good, thanks!


Refactoring constants for skip validations

Issue #5865:
Description of changes:
Refactoring constants and adding vsphere-user-privilege for upgrade.
Testing:
Tested creating a cluster by skipping the check
./eksctl-anywhere create cluster -f ./config.yaml

Documentation added/planned :
Plan to document the new flag and user experience.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/test eks-anywhere-presubmit

/approve


[spdlog] update to 1.61

Library name: spdlog
New version number: 1.61
URL: https://github.com/gabime/spdlog
There are many improvements from 1.4.2-1 to 1.6.1.

Related issue #10931


REST API tests refactoring (Part 4)

Description
Moved test:

SecurityConfigApiActionTest into ConfigRestApiIntegrationTest

Test with the Legacy prefix removed since new tests use randomization for paths
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@willyborankin Can you rebase this PR?
The changes look good to me.

@willyborankin Can you rebase this PR?
The changes look good to me.

done

@willyborankin would you mind creating a manual backport to 2.x for this?


Support start tracking and load save tracking infos

This is based on the pull-request originally contributed by @NicerNewerCar:

https://github.com/BrownBiomechanics/SlicerAutoscoperM/pull/4

Before
After

Closing, since we are leveraging the Autoscoper UI for most interactions, it doesn't make sense to split up functionality between Autoscoper and Slicer. This may be revised when the hard integration takes place.


flutter firebase database not working in release mode for android but for ios is working

I am using Firebase database as a back-end server for flutter app, the app is working in debug mode for android and IOS. but it is not working in release mode for android only. IOS is working not only in release or debug mode. Although the code base is same for UI and widget are correct, the android release is not reading the data from Firebase database.

Hi @usaikoo
From what I can see, the issue is related to a FlutterFire plugin rather than to Flutter itself. Please open the issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself.
If you disagree, please write in the comments,  providing your flutter doctor -v, your pubspec.yaml, a minimal reproducible code sample that does not use 3rd party plugins, your complete flutter run -v logs running the minimal code sample
and I will reopen it.
Thank you


Fix heartbeat inventory add crash

Short Description:
Since heartbeat threaded, inventory refresh may occur asynchronously and may cause crash (ie. trying to add pokemon that's already there). Moved heartbeat to tick instead so should only occur when the bot isn't doing other things.
Fixes/Resolves/Closes (please use correct syntax):

#5299

OK, after feedback in chat, I've added a threshold to prevent inventory_refresh occurring under 10 seconds.

:+1:


.NET SDK not Listing .NET 5 and 6

Hi, thank you for the effort on the IDE.

As the title said, SDKs are detected in settings but when creating new projects, there's no option to create .NET (5 and 6). Did I miss any configurations? Thanks in advance.

Hey, I'm encountering the same problem

Hello. Looks like your problem was fixed in this PR https://github.com/consulo/incubating-consulo-dotnet-core/pull/10, but this PR will affect only new builds of Consulo, current stable builds - not update for now (since current nightly builds not stable)
Can you say what .NET you using?
Problem in file dotnet\sdk\7.0.102\.version which was changed:
4bbdd14480a177e60fba52abf34829020449e46e
7.0.102
win-x64
7.0.102-servicing.22607.3

For now plugin allow extracting version only with 3 line file (not four). And test it.

6.0.113

I fixed the issue by adding the sdk manualy


Bug deserialization of object returns null

Source/destination types
    public class DivideToSomeNum : ViewValueInterface
    {
        public int division { get; set; }
        string ViewValueInterface.PrettifyView(int? rawValue)
        {
            if(rawValue == null)
            {
                return "No Connection";
            }
            else if (division != 0)
            {
                return (rawValue / division).ToString();
            }
            return rawValue.ToString();
        }
    }
"instance of DivideToSomeNum class stored as "object" type in another class"
    public class Sample
    {
        public object itemV2 { get; set; }
        public string getText()
        {
            return JsonConvert.SerializeObject(itemV2);
        }
        public static Sample GetSample(string jsonText)
        {
            return JsonConvert.DeserializeObject<Sample>(jsonText);
        }
    }

Source/destination JSON
{"division":100}

Expected behavior
Instance of a class casted into object
Actual behavior
No cast at all,deserialized object is null
Steps to reproduce
Sample test = new Sample {itemV2 = new DivideToSomeNum { division = 100 } };
string Text= test.getText();
Sample sample = Sample.GetSample(Text);

Hello.
Before my actuall comment i want to clarify that i'm not affiliated with Newtonsoft.Json. I'm just random guy from internet trying to help.
First something which is not clear to me. Why do you have itemV2 as object (data type).
public object itemV2 { get; set; }

I think it is not good practice to store objects in object data type (boxing, unboxing) unless there is some really strong reason to do so. I think much better would be to use interface/base class/generics but i don't know what is your code used for so if you know that you need boxing then ignore this comment.
One more problem to this is that Newtonsoft.Json can't tell how to deserialize the value to original object, because it can't know which object it was.
Because of that it will make it as JObject. (you can see it in file Newtonsoft.Json.Serialization.JsonSerializerInternalReader on line 457)
if (HasNoDefinedType(contract))
{
    return CreateJObject(reader);
}

Now to your problem.
In your class sample you are first serializing property itemV2 which is of type DivideToSomeNum (boxed to object).
public object itemV2 { get; set; }
public string getText()
{
    return JsonConvert.SerializeObject(itemV2);
}

But then you are deserializing it to type Sample.
return JsonConvert.DeserializeObject<Sample>(jsonText);

This is the reason that the property itemV2 is null.
So this is just bug in your code.
I hope that this answer helps you or anyone whou would read this.


fix(v2): make more accessible skip link

Motivation
Should fix #3917
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview https://deploy-preview-4162--docusaurus-2.netlify.app/classic/
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Thanks @lex111 !
@Mythra can you please tell us if the "skip to main content" link works better for you now?
Testing on this URL: https://deploy-preview-4162--docusaurus-2.netlify.app/classic/

As a side note this button currently only activates if "enter" is pressed. This is problematic as Enter can most often be taken elsewhere. The space bar natively works for button's normally, or synthetically inject clicks. So have onClick/space not work can create a very frustrating experience, and may make it impossible to click.

Not sure to understand 100% what you mean here, should we make that link (replaces the button) lead to the main content when space is pressed?

I think this PR improves the issue you had, as we now use a link, and it actually gives the focus ring to the main content, so I'm going to merge, but feel free to re-open/comment if this does not work for you

Hey,
Thanks for doing the work here, was looking forward to doing it myself/reviewing it, but hey as long as it gets done.
As for the tabindex trick it is useful for Safari, but is there a particular reason removing tabindex is set to a delay of 1 second, Rather than just using a setTimeout of 0 so it happens on the next visual tick? It might be weird for a user who is tabbing in that second to be on an element, and all of a sudden have that element just not be a core focus anymore. I hit it once accidentally before looking at the code, but I was more testing everything was working. Hard to say how many people would hit it in practice.

Not sure to understand 100% what you mean here, should we make that link (replaces the button) lead to the main content when space is pressed?

@slorber as long as it's a link you don't need to have the space key function. The problem I was outlining there was having a "button" element specifically, not reacting to space. As long as it's a link (which is more correct) we don't need the space key to work. It's just when me, and other screen-reader users here "button" we expect space to work as by default it does.
And FWIW I'm happy to provide reviews on a11y issues, so we don't merge in broken examples like we did with this. Where it was done in good faith, just no one was sure how to test it. Always better to ask and wait a bit than ship a broken experience I think 😉
But thank you both, tons! Glad to see it get fixed!

@Mythra thank you too for letting us know! We will be glad if you find any more issues related with a11y, we will try to fix them!

As for the tabindex trick it is useful for Safari, but is there a particular reason removing tabindex is set to a delay of 1 second,...

Indeed, this is not a very good experience, maybe it is worth turning off the outline on the main element (by adding outline: none)? After all, this element are not accessible from the keyboard, so it will be safe action, what do you think? Or is it enough to just remove any delay (setTimeout)?

I'd say let's not override the outline behavior that the browser , if the browser wants to outline it let's let it do that (even though I don't think it should with 0). I think setting to 0 would help people tabbing through fast, so definitely I'd be for that change.


Adding parser

Purpose
This language needs basic tools to text analysing, that is, parser.
Approach
This is basic implementation of ANTLR 4 parser with simple facade that generates AST tree
using composite pattern. AST tree could be analysed using visitor pattern.
Learning
ANTLR 4 Tutorial
Composite Pattern
Visitor Pattern

There is missing unit tests for parser grammar.


vscode ignores xkb remapping

VSCode Version: 1.11.1 onwards
OS Version: Ubuntu 16.04

Steps to Reproduce:

Remap keys using xkb (https://askubuntu.com/questions/325272/permanent-xmodmap-in-ubuntu-13-04/347382#347382?newreg=4eb097870a15490ebbe39d78412f9797)
Test your remapping, they should work everywhere system-wide.
Since updating to vscode 1.11.1, it has been ignoring these remaps.

Happens on both of my computers (Lenovo X250 running Elementary OS and desktop pc with Ubuntu 16.04)
Also, after remapping everything inside VSCode, updating to 1.11.2 removed them again.

Updating to 1.11.2 and reseting all keybindings seemed to fix this. I can still reproduce it on an older 1.11.1 installation.


Removed instruction to accept privacy policy

Removed line:
Click Accept to accept the privacy and cookie policy. This app doesn't keep personal information.

Fixes #10479


MSFT_xVhdFileDirectory.schema.mof contains schema for xFileDirectory

Looking at the schema for MSFT_xVhdFileDirectory, there seems to be a schema that doesn't belong there
[ClassVersion("<IP_ADDRESS>")]
Class MSFT_xFileDirectory
{
  [Required] string DestinationPath;
  [Write] string SourcePath;
  [Write,ValueMap{"Present", "Absent"},Values{"Present", "Absent"}] string Ensure;
  [Write,ValueMap{"File", "Directory"},Values{"File", "Directory"}] string Type;
  [Write] boolean Recurse;
  [Write] boolean Force ;
  [write] string Content;
  [Write,ValueMap{"ReadOnly", "Hidden", "System", "Archive"},Values{"ReadOnly", "Hidden", "System", "Archive"}] string Attributes[];
};

[ClassVersion("<IP_ADDRESS>"), FriendlyName("xVhdFile")]
class MSFT_xVhdFileDirectory : OMI_BaseResource
{
    [Key, Description("Path to the VHD")] String VhdPath;
    [Required, EmbeddedInstance("MSFT_xFileDirectory"), Description("The FileDirectory objects to copy to the VHD")] String FileDirectory[];
        [Write,ValueMap{"ModifiedDate","SHA-1","SHA-256","SHA-512"},Values{"ModifiedDate","SHA-1","SHA-256","SHA-512"}] string CheckSum;
};

The schema for MSFT_xFileDirectory can be removed I think.
Opinions?

Looks like MSFT_xVhdFileDirectory property FileDirectory[] references MSFT_xFileDirectory as an embedded instance type?

doh.. yes. So it seems. I've seen that being used before but not that often. Let's leave it in!


NetFramework - Unsafe.SkipInit(out T value) unavailable

Actual behavior
Windows.Wdk.byte.InlineArrays.g.cs and Windows.Wdk.char.InlineArrays.g.cs  both cause project to not build due to

Relevant section of CSWin32 :
https://github.com/microsoft/CsWin32/blob/66fe74557fb1412085f01be9cd27c20e7af97de8/src/Microsoft.Windows.CsWin32/Generator.InlineArrays.cs#L608
Note : This ONLY occurs if using the System.Memory Nuget package!
Generated Code: (with System.Memory)
public static unsafe implicit operator __byte_1(ReadOnlySpan<byte> value)
{
	Unsafe.SkipInit(out __byte_1 result);
	Span<byte> target = new Span<byte>(result.Value, SpanLength);
	value.CopyTo(target);
	int initLength = value.Length;
	target.Slice(initLength, SpanLength - initLength).Clear();
	return result;
}

Generated code without System.Memory ( Note how the error occurs, even though the line doesn't exist! )

Expected behavior
Generate code compatible with the target ( in this case Net462 and Net48 )
Repro steps

NativeMethods.txt content:   REPARSE_DATA_BUFFER

Multitarget Net462 or Net48 along with your .Net of choice

NativeMethods.json content (if present): not applicable

Any of your own code that should be shared?

Context

CsWin32 version: 0.3.49 - Nuget
Win32Metadata version (if explicitly set by project):
Target Framework: Net462, Net48, NetStandard2.0
LangVersion (if explicitly set by project): 9

Just for reference here, here is the generated code:
Net462
	internal struct VariableLengthInlineArray<T>
where T : unmanaged
	{
		internal T e0;

		[UnscopedRef]
		[MethodImpl(MethodImplOptions.AggressiveInlining)]
		internal Span<T> AsSpan(int length)

		{
unsafe

			{
				fixed (void* p = &this.e0)
				{
					return new Span<T>(p, length);
				}
			}
		}
	}

Net8.0
	internal struct VariableLengthInlineArray<T>
where T : unmanaged
	{
		internal T e0;

		internal ref T this[int index]
		{
						[UnscopedRef]
			[MethodImpl(MethodImplOptions.AggressiveInlining)]
get => ref Unsafe.Add(ref this.e0, index);
		}

		[UnscopedRef]
		[MethodImpl(MethodImplOptions.AggressiveInlining)]
		internal Span<T> AsSpan(int length)

		{
			return MemoryMarshal.CreateSpan(ref this.e0, length);
		}
	}


Allow find in gather-logs to follow symlinks.

This is needed to fix an issue when users symlink another directory
to /var/log/opscode and allows find to follow the symlink when
searching for the log files to include.
Signed-off-by: Will Fisher<EMAIL_ADDRESS>

@teknofire You're good to merge, but please rebase onto master beforehand to keep the history clean.


Fixed case of Started, notStarted, Running

Status responses changed from lowercase; could be an issue if checking for a specific string in body.status.

@hxlnt,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@hxlnt : Thanks for your contribution to the Azure documentation! The author, @onewth, has been notified to review your proposed change.

#sign-off


Buzz 0.7.1 does not run on Windows 8.1 (ImportError QtGui)

I installed "Buzz-0.7.1-windows.exe" on Windows 8.1. When I then try to run Buzz, I get this error message:
Traceback (most recent call last):
File "main.py", line 42, in
File "PyInstaller\loader\pyimod02_importers.py", line 499, in exec_module
File "buzz\gui.py", line 14, in
ImportError: DLL load failed while importing QtGui: The specified procedure could not be found.

yes i tried windows 7 and 8.1 same errors,i think it works windows 10 only.

yes i tried windows 7 and 8.1 same errors,i think it works windows 10 only.

Yes, unfortunately, that may be the case.


fix(actions): fix merge lint

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.436%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
190

Relevant Lines:
195

💛  - Coveralls


FIX: fix BEC LiveGrid plot for a motor with one step

This PR should fix the issue with a BestEffortCallback LiveGrid plot failing for the grid_scan plan for a motor with one step.
Description

Steps to reproduce:
import matplotlib.pyplot as plt
from bluesky.utils import install_qt_kicker
from bluesky.run_engine import RunEngine
from bluesky.callbacks.best_effort import BestEffortCallback
import bluesky.plans as bp
from ophyd.sim import det4, motor1, motor2

plt.ion()
install_qt_kicker()
RE = RunEngine({})
bec = BestEffortCallback()
RE.subscribe(bec)
RE(bp.grid_scan([det4], motor1, 0, 1, 1, motor2, 0, 1, 2, True))

This will fail with an error like:
In [26]: RE(bp.grid_scan([det4], motor1, 0, 1, 1, motor2, 0, 1, 2, True))
Transient Scan ID: 6     Time: 2018/04/07 00:48:56
Persistent Unique Scan ID: '23353b56-06cd-4827-abb6-79a472c29736'
New stream: 'primary'
+-----------+------------+------------+------------+------------+
|   seq_num |       time |     motor1 |     motor2 |       det4 |
+-----------+------------+------------+------------+------------+
/Users/mrakitin/src/mrakitin/DAMA/bluesky/bluesky/callbacks/best_effort.py:302: RuntimeWarning: divide by zero encountered in true_divide
  y_step, x_step = data_range / [s - 1 for s in shape]
+-----------+------------+------------+------------+------------+
generator grid_scan ['23353b56'] (scan num: 6)

The fix helps to eliminate the error and produce a plot with one "row" of data:

Motivation and Context

First this issue was observed at the NSLS-II SMI beamline, where the number of motors passed as arguments to the grid_scan plan varies from 1 to 3.
How Has This Been Tested?

Existing tests passed locally.

Codecov Report

Merging #1015 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   90.26%   90.26%   +<.01%
==========================================
  Files          50       50
  Lines        8060     8061       +1
==========================================
+ Hits         7275     7276       +1
  Misses        785      785

Impacted Files
Coverage Δ

bluesky/callbacks/best_effort.py
87.74% <100%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e99dc...28211e6. Read the comment docs.

looks good, merging!


No pxe boot #35

Details
No pxe boot is to be supported if there are no active workflow for a worker/hardware.
Changes
Added endpoint to fetch active workflow for a hardware
Added logic to translate hardware id to active worker id
Added logic to stop pxe boot if not active workflow is present.
Testing
Tested with client added via https://github.com/tinkerbell/tink/pull/200.
happy path testing completed.
{"level":"info","ts":1593695857.2480636,"caller":"job/job.go:55","msg":"found active workflow for hardware 0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94 with workflow id d0f730bc-894d-42de-8c37-9e423f5c761d","service":"github.com/tinkerbell/boots","pkg":"http","dhcp":"0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94"}
Need to do testing with new tink after the merge of above mentioned PR.
Negative testing pending.

I tend to write a single Test that use Table Testing https://github.com/golang/go/wiki/TableDrivenTests when I can because it avoids the retention of the logic that we are testing. For example in this case we can have a map of 3 tests:
1. Hardware not found because it does not exists
2. no active workflow for an existing hardwareID should return false
3. active workflow for an existing hardwareID should return true

Let me know what you think about this

@gianarb , This strategy does looks good, but IMO i think at first we should refactor our code to support mocking of methods which are called inside our TestMethod. I am not sure, how TableDrivenTests will mock methods called inside test method. Also we may have to consider cases, as in this PR, where input is same but test result differs on the basis of output obtained from mocked method.

Test results and boot logs after changes with review comments
with active workflow
{"level":"info","ts":1594301567.8052936,"caller":"job/job.go:62","msg":"fetching workflows for hardware 0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94","service":"github.com/tinkerbell/boots","pkg":"http","hardwareID":"0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94"} {"level":"info","ts":1594301567.81777,"caller":"job/job.go:71","msg":"found active workflow for hardware","service":"github.com/tinkerbell/boots","pkg":"http","hardwareID":"0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94","workflowID":"6d360928-2b7b-4ec3-b5ea-530de2c8e7cf"}
No active workflow
"fetching workflows for hardware 0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94","service":"github.com/tinkerbell/boots","pkg":"http","hardwareID":"0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94"} {"level":"info","ts":1594301723.3819473,"caller":"boots/dhcp.go:76","msg":"retrieved job is empty","service":"github.com/tinkerbell/boots","pkg":"main","type":"DHCPDISCOVER","mac":"08:00:27:00:00:01","err":"no active workflow found for hardware 0eba0bf8-3772-4b4a-ab9f-6ebe93b90a94"

Will do cherry pick once review is completed.

have to sqash commit. waiting for review to complete.

@Cbkhare aaaaaaaaaalmost there! Thanks for working through all the progress!

Scouts honor, that would be the last changes :D

@mmlb @gianarb
I have addressed all the review comments.

@kdeng3849 @gianarb we're now waiting on your final acks.


Re-direction of Garima Girls Project Page (Gitbook link changed)

Old URL: https://open.janastu.org/our-work/projects/garmi-girls-project
New URL: https://open.janastu.org/our-work/projects/mxpr-girls
Fix broken links to the page if any....

wrong repo.
The issue is fixed, broken links are auto fixed in open.janastu.org


Support variable-length integer encoding

In some protocols the length field is encoded using a variable-length encoding scheme. In MQTT such an encoding is used for the Remaining Length field. There are multiple variants of variable-length encoding of integers, thus other protocols could use a different variant as MQTT. The DSL has to support the correct encoding in order to be able to specify the protocol.
@senier Do we want a general approach, where it is possible to define encoding and decoding functions in the protocol specification, or do we rather want to support only a pre-defined set of encodings?

It seems not to be possible to specify MQTT with ASN.1 in combination with ACN. ACN only supports the following encodings for integers: pos-int, twos-complement, BCD, ASCII.


Sobol experimental design

Hello,
Since I think the sobol experimental design was not implemented in emukit but was in GPyOpt, I developed it for emukit following the LatinDesign model. Even if it is not a crucial contribution, I am sending it to you in .txt format if you would like to include it in the official version of emukit:
sobol_design.txt
Kind regards,
Anthony Larroque

This has been merged . Thanks @AnthonyLarroque and @apaleyes. I am closing the issue.


!Im trying to install Crouton but it it fails opening

I put the code:=>   Chronos@localhost / $ sudo sh /Downloads/crouton -e -t unity
And then it says:=> [ ](sh: 0: Can't open /Downloads/crouton)
I'm new at this, don't know what I'm doing wrong, I copied the files of crouton in Downloads.

You need to read the installation instructions, it's changed from what you're using.
-DennisLfromGA

Ok, thanks, finally it worked.


[service-bus] Split createSessionReceiver into acceptSession and acceptNextSession

As part of the discussion with the service team we've decided to break apart the creation of session receivers into two methods (along with a rename).
So createSessionReceiver() is now two methods:

acceptSession (for when you know the ID of the session you're trying to open)
acceptNextSession (for when you want to let Service Bus find the next random session to open)

We've also switched over to 'accept' as the verb rather than 'createSessionReceiver' to better indicate that work is being done (specifically, we're actually opening the link at this point).

/azp run js - servicebus - tests

Merged and will take any suggestions you might have for acceptSession/acceptNextSession doc changes (next PR!)


Nano S not recognized

Trying to install Electron Cash 2.9.3 under Windows 7 using a Ledger Nano . I select "Standard wallet" -> "Use a hardware device". Nano S is plugged in and the BCC app is open. I get the following error message:
No hardware wallet support found on your system.
Please install the relevant libraries (eg python-trezor for Trezor)

I found my hw.1 device, but can't get it to work ("no hardware wallet support found", neither in electrum nor in electron-cash. Installed packages "btchip-udev" and "python2-btchip" on my system to no avail.
Does your Nano S work with electrum at all?

I dug in and found my hw.1 is likely not supported by python2-btchip any more ;-(
I say this because in the code starting here: https://github.com/LedgerHQ/btchip-python/blob/5fdf6fae1b33be2d9248af8ee0eda14da0a1a0c3/btchip/btchipComm.py#L173 the usb id my hw.1 device has (2581:1b7c) isn't listed.
I'm afraid I can't help without a device.

Trying to get the firmware of my hw.1 updated since it's not supported any more by python-btchip

Ok, I have a working btchip device (thanks to ledger for giving me some)!
I setup a wallet using their web-based wallet and was able to create the same one using electron-cash.
@JPUnix do you have btchip-python installed and if so, what version?
to see if btchip is installed in your python system, you can put the folling into a file test_btchip.py
from btchip.btchipComm import HIDDongleHIDAPI, DongleWait
from btchip.btchip import btchip
from btchip.btchipUtils import compress_public_key,format_transaction, get_regular_input_script, get_p2sh_input_script
from btchip.bitcoinTransaction import bitcoinTransaction
from btchip.btchipFirmwareWizard import checkFirmware, updateFirmware
from btchip.btchipException import BTChipException
print "btchip seems to be installed"

and then run it:
#> python2.7 test_btchip.py

@JPUnix on second thought: maybe you can just run electron cash from the terminal and look at the output? If btchip is not installed, it should look like:
  ~/bitcoin/Electron Cash-2.9.3\> ./electron-cash
No systemtrayicon available
Traceback (most recent call last):
  File "./electron-cash", line 377, in <module>
    d.init_gui(config, plugins)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/daemon.py", line 283, in init_gui
    self.gui.main()
  File "/home/nick/bitcoin/Electron Cash-2.9.3/gui/qt/__init__.py", line 215, in main
    if not self.start_new_window(path, self.config.get('url')):
  File "/home/nick/bitcoin/Electron Cash-2.9.3/gui/qt/__init__.py", line 171, in start_new_window
    wallet = self.daemon.load_wallet(path, None)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/daemon.py", line 220, in load_wallet
    wallet = Wallet(storage)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/wallet.py", line 1747, in __new__
    wallet = WalletClass(storage)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/wallet.py", line 1551, in __init__
    Deterministic_Wallet.__init__(self, storage)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/wallet.py", line 1395, in __init__
    Abstract_Wallet.__init__(self, storage)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/wallet.py", line 105, in __init__
    self.load_keystore()
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/wallet.py", line 1518, in load_keystore
    self.keystore = load_keystore(self.storage, 'keystore')
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/keystore.py", line 646, in load_keystore
    k = hardware_keystore(d)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/keystore.py", line 630, in hardware_keystore
    return constructor(d)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/plugins.py", line 170, in dynamic_constructor
    return self.get_plugin(name).keystore_class(d)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/plugins.py", line 178, in get_plugin
    self.load_plugin(name)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/lib/plugins.py", line 102, in load_plugin
    p = loader.load_module(full_name)
  File "/usr/lib/python2.7/pkgutil.py", line 246, in load_module
    mod = imp.load_module(fullname, self.file, self.filename, self.etc)
  File "/home/nick/bitcoin/Electron Cash-2.9.3/plugins/ledger/qt.py", line 12, in <module>
    from btchip.btchipPersoWizard import StartBTChipPersoDialog
ImportError: No module named btchip.btchipPersoWizard

I can reproduce this on a windows machine at work.
I managed to capture the following output by running electron-cash-2.9.3.exe from a terminal:
$ /cygdrive/c/Users/slf/Downloads/electron-cash-2.9.3.exe
Traceback (most recent call last):
  File "C:\cygwin64\tmp\_MEI62122\lib\plugins.py", line 150, in get_hardware_support
    p = self.get_plugin(name)
  File "C:\cygwin64\tmp\_MEI62122\lib\plugins.py", line 178, in get_plugin
    self.load_plugin(name)
  File "C:\cygwin64\tmp\_MEI62122\lib\plugins.py", line 102, in load_plugin
    p = loader.load_module(full_name)
  File "Z:\home\ubuntu\gitwork\electrum\contrib\build-wine\build\deterministic\out00-PYZ.pyz\pkgutil", line 246, in load_module
  File "C:\cygwin64\tmp\_MEI62122\plugins\ledger\qt.py", line 12, in <module>
    from btchip.btchipPersoWizard import StartBTChipPersoDialog
ImportError: No module named btchip.btchipPersoWizard

I compared to electrum and the btchip device works there.
Seems we're missing btchip python dependency.
When running the .exe files, temporary folders are created and the python program is run from there (I assume). I checked those folders, neither in the electron-cash nor in the electrum case do they contain any files with "btchip" in their name. I'm confused.

you need to include the packages when you build the exe...before you run it.

I didn't build the exe myself. Used the one downloaded from your page.

so we need to include this btchip python library in packages in the next build we release.  Will do.

@fyookball @molecular Thanks for looking into this issue. Looks like we've pin-pointed the cause of the issue to a missing btchip .exe? Would it be possible to cut a new release soon with the btchip lib included? Looks like there are 2 other outstanding issues #153, #126 which might be patched as well.

@fyookball Thanks for the 2.9.4 release, looks like we're making progress on this issue. However, on macOS 10.13.1 I am unable to restore a multi-sig wallet from my hardware devices. When I go File -> New/Restore -> Multi-Signature -> Hardware Wallet Electron Cash seems to hang on this screen:

Is there a log file I can copy/paste output from to help diagnose this?

@fyookball Thanks for the 2.9.4 release, looks like we're making progress on this issue. However, on macOS 10.13.1 I am now unable to restore a multisig wallet from a Ledger S Nano hardware device in Bitcoin Cash mode.
Repro steps: File -> New/Restore -> Next -> Multi-signature wallet -> 2of3 -> Hardware device hangs the program at this screen:

Is there a log file I can copy/paste output from to help diagnose the issue?

Traceback (most recent call last):
  File "/home/user/Projects/electroncash/lib/plugins.py", line 150, in get_hardware_support
    p = self.get_plugin(name)
  File "/home/user/Projects/electroncash/lib/plugins.py", line 178, in get_plugin
    self.load_plugin(name)
  File "/home/user/Projects/electroncash/lib/plugins.py", line 102, in load_plugin
    p = loader.load_module(full_name)
  File "/usr/lib64/python2.7/pkgutil.py", line 246, in load_module
    mod = imp.load_module(fullname, self.file, self.filename, self.etc)
  File "/home/user/Projects/electroncash/plugins/ledger/qt.py", line 12, in <module>
    from btchip.btchipPersoWizard import StartBTChipPersoDialog
  File "/usr/lib/python2.7/site-packages/btchip/btchipPersoWizard.py", line 23, in <module>
    from PyQt4.QtGui import QDialog, QMessageBox
ImportError: cannot import name QDialog

Looks like the python2 btchip depends on QT4, we've moved to QT5.

Thanks for the stacktrace @Danconnolly. What command are you issuing to give that error?
What’s the best path forward to fix this? We could fork btchip to use QT5, but I’m hesitant to lock us into a fork of brchip that might miss future updates. Seems a little obnoxious to make our dependencies update in response to a regression of our own.
What was the rational for updating to QT5 in this repo? Would it be possible or easy to rollback to QT4?
Seems like this feature might warrant an integration test given the frequency we’ve been bitten by it.

I was creating a new wallet, as you were. Unfortunately, I dont have an existing wallet linked to my nano, existing wallets may still work ok.
I was looking into the python3 version of btchip, hoping for Qt5, but it also seems to be dependent on QT4 (there's a plan for Electron Cash to move to python3 eventually).
I dont think its a good idea to move back to QT4.
At the moment, it may be the initialization dialog code from btchip that use Qt, I'm thinking of just importing that code from btchip and updating to QT5. That way, we can still use the rest of the btchip library and remove our update when they update.

Is there a vulnerability or deficiency in QT4 that’s preventing us from reverting those changes? Or are there features in QT5 that we really want/need? Given that this is a breaking change, it seems reasonable to discuss a downgrade to QT4 so long as it’s safe.
Otherwise we could make the change to btchip, but there’s no guarantees if/when those changes get accepted.
I’m no python expert, but would it also be possible to include QT4 in the electron cash build? Seems hacky and might get us into more trouble down the line, but just throwing that out as an option.

Created issue #269 for the QT4 vs QT5 problem because this has a different root cause from the origin of this issue.

I still see a missing module in 2.9.4 on OS X
ImportError: No module named btchip.btchipPersoWizard

Also, looks like trezorlib.* (aka python-trezor) is missing from the Mac build, too.  (You don't see the import error unless you edit trezor.py to print it, since trezor.py silently catches the error by default.)

Has anyone been able to verify this is fixed on v3.0? I'm using the Linux build of 3.0 and it doesn't seem to be picking up my Ledger S Nano over USB:

Props for the additional copy on the dialog though, will hopefully save folks some time.

Hi, I have the same problem as @willyloman , Electorn Cash 3.3.1, Ledger Live recognises the Nano S, but not Electron Cash. Any ideas?


Adding better TypeScript errors

This should make it easier to debug the TypeScript code when there is a
compilation error.

Coverage remained the same at 100.0% when pulling eea1eea59165c79b470a8d5e52649c82b8e75d26 on better-errors into 7327f8f6eca322478a239de90fbaa4938b606fb6 on master.


How can i add double click event on data grid ?

Currently there is not any method available to handle double click event in data grid.
Is there any way to add double click event on data grid.

https://github.com/mleibman/SlickGrid/wiki/Grid-Events

@brunobola ,
sorry, but your information does not help too much in this particular case (how to implement this in Serenity) :-).
What @chintansoni54 probably means is, to extend the serenity.datagrid class to also support double click events within the grid as the Standard "onClick" Event is defined there (if I understand correctly).
...and then define the onDblClick method probably like this:
protected onDblClick(e: JQueryEventObject, row: number, cell: number): void;

@volkanceylan : Would it be possible for you to consider also to support the doubleclick Event within the Serenity grid by Default? (Slickgrid provides this out of the box).
With Kind regards,
John

in constructor:
            this.slickGrid.onDblClick.subscribe((e, p) => {
                // p.row, p.col
            });

i wouldn't recommend double click from a usability / mobile perspective though

@volkanceylan  @JohnRanger @brunobola
I fixed this issue with this
https://rakeshkanani.gitbooks.io/detail-development/content/enabled-double-click-event-in-data-grid.html


add update/patch permission of namespace to klusterlet for 2.1

The related issue: https://issues.redhat.com/browse/ACM-4712

/hold Hold until the branch is open for business.

/lgtm
/approve


Request: on startup, when keyspace isn't inited, either exit or retry connections

We're seeing a minor bug when running cyanite in a testing setup, where the testing setup resets and re-inits everything.
Specifically, if the metric keyspace doesn't exist right at startup of cyanite (because our init scripts are running it at the same time -- so we can fix this by delaying the startup of cyanite), then the below stack trace occurs and the process hangs. I'd suggest either having cyanite exit, or retry on some interval, and on success, continue. As it is now, the process spins up, but fails to reach a point where it's listening on any ports for traffic.
-J
DEBUG [2014-09-19 10:15:58,545] main - org.spootnik.cyanite.config - building  :store  with  org.spootnik.cyanite.store/cassandra-metric-store
INFO [2014-09-19 10:15:58,558] main - org.spootnik.cyanite.store - creating cassandra metric store
at org.spootnik.cyanite.config$init.invoke(config.clj:124)
at org.spootnik.cyanite$_main.doInvoke(cyanite.clj:31)
at clojure.lang.RestFn.applyTo(RestFn.java:137)
at org.spootnik.cyanite.main(Unknown Source)
Caused by: com.datastax.driver.core.exceptions.InvalidQueryException: Keyspace 'metric' does not exist
INFO [2014-09-19 10:15:58,558] main - org.spootnik.cyanite.store - creating cassandra metric store

fixed in #80 by b2587435fd57712949a441870ef2132864d55587


Create tiered storage e2e test in Microsoft Azure

The cluster is unmanged Kubernetes cluster with additional storage account and storage container. Credentials to Azure storage account are passed to Redpanda configuration to enable tiered storage capability. The verification relay on the fact that helm chart test consist on produce-consume test. After 1 second segments, that belong to test topic will be closed and send to Azure storage container.
Fixes https://github.com/redpanda-data/helm-charts/issues/490

https://buildkite.com/redpanda/helm-charts/builds/467 Buildkite passed


Fix gpr_log compiler warning about string literals, breaking the build

@sheenaqotj

The MacOS artifact build failure is not related to this work, and it's being investigated separately. I'm merging this PR given that all other tests pass.


Show oracle details and proofs in market proposals

Story
As a voter on new markets
I want evidence of the market oracle's reputation
So I can decide if it is trustworthy
Acceptance Criteria

[ ] I can find oracle details and proofs for each new market proposal and update market proposal
[ ] I can independently verify those proofs (e.g. look at the specification, links)

Tasks

[ ] Implement
[ ] QA

Sketch

Additional details / background info

Dependent on https://github.com/vegaprotocol/ux-and-visual-design/issues/79, see that ticket for background and design specs
The oracle profile will also be shown in console, so ideally the same components should be used for consistency – see https://github.com/vegaprotocol/frontend-monorepo/issues/2086

Questions about how this works in different environments - do we have a different set of trusted oracles on different environments

Also on hold pending #3985 being merged


[TASK] Remove the feature that skip taking backup/snapshot when the volume head is empty in recurring backup jobs

What's the task? Please describe.
Currently, inside recurring job, we have a feature that can skip taking backup/snapshot for volume if the volume head is empty:

https://github.com/longhorn/longhorn-manager/blob/a38318e502e83452e0b6dc68ea5c4c26095b25f0/app/recurring_job.go#L700
https://github.com/longhorn/longhorn-manager/blob/a38318e502e83452e0b6dc68ea5c4c26095b25f0/app/recurring_job.go#L465

This leads to confusion for users that sometimes they don't see backups/snapshots aren't taken at the scheduling time.
We should remove this feature.

PR: https://github.com/longhorn/longhorn-manager/pull/1115

@derekbit Please create a backport issue then backport to 1.2.x. Thanks.

Validated with the master - 11/09/2021
Validation - Fail
The recurring backup is creating backup/snapshot with no change in the head now but found an issue in retain count of the backup.
For recurring backup job retain count -3, the backups in the backups in backupstore is (retain count + 1) i.e. 4
Details of the recurring job in screenshot:

longhorn-support-bundle_301b7c0f-5a63-4eee-9837-740e72f9f4ad_2021-11-09T23-39-04Z.zip
Volume name - pvc-3963d063-765d-460f-8de1-40010e3836e2

With further investigation, looks like the deletion happens really slow. It takes time and if the recurring job is frequent like (3 mins and 5 mins), the backups in the backupstore appear more than the retain count.
Initially I had recurring backup scheduled in every 5 mins and I was not writing any data in between the two backups. In this case I saw 4 backups.
However, when I increased the time interval to 10 mins. I observed that the retain count got right in the backup store.
Can we improve this?

@khushboo-rancher
Seems the delay of the deletion. Do you know how long is the delay?
Why does the retain count go to normal after increasing the interval?

@khushboo-rancher
After testing again, the deletion times are both 4 seconds averagely in my environment with in-cluster nfs and minio.
I guess the long deletion time in your test might be due to the network, underlying storage performance and so on. Could you please help to check it?
I also think it is not in the scope of this feature.

Agree with @derekbit . @khushboo-rancher let's create another issue to track inconsistent count? Thanks.

Created an issue for the inconsistency in backup count https://github.com/longhorn/longhorn/issues/3231.
Validation - Pass
Validated the below scenarios:

The RWO and RWX volume with some data in between the snapshot/backup recurring job.
Jobs scheduled fine.
The RWO and RWX volume with no data in between the snapshot/backup recurring job.
Jobs scheduled fine.
Crashing the replica IM while the backup jobs was in progress.
If the backup is triggered from the replica crashed, the backup process failed and in next schedule, it triggered the backup again.
If the another replica was crashed on impact on the backup.
Crashing the engine IM while the jobs was in progress.
Job failed and triggered again in the next schedule.
Validated the Allow Recurring Job While Volume Is Detached setting.
Repeated the tests 3, 4 while volume was detached and Allow Recurring Job While Volume Is Detached was enabled.

Note: No change is required in automation test.


Fixed some error message grammar

Made slight fixes

LGTM
I plan on making a signed build this weekend, it'll be included there


Feature/fix issue 574

Fixes issue #574

Codecov Report

Merging #1087 into develop will decrease coverage by 0.05%.
The diff coverage is 44.44%.

@@             Coverage Diff             @@
##           develop    #1087      +/-   ##
===========================================
- Coverage    84.85%   84.79%   -0.06%
===========================================
  Files           41       41
  Lines         3612     3618       +6
  Branches       654      655       +1
===========================================
+ Hits          3065     3068       +3
- Misses         412      414       +2
- Partials       135      136       +1

Impacted Files
Coverage Δ

isort/main.py
63.96% <44.44%> (-0.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee43b6...c528c36. Read the comment docs.


Feature/add release version to app

Added a hint in the UI displaying the current version of both, the app and the api.

Error on branch selected.


Update NextJS to v12

Update, this link gives an issue because v12 supports only import and it seems like dynamic requires are broken.
When we move the require to the top of the file and change it to import, it causes an error because client side apolloClient cannot run graphql schema files. Therefore, some refactoring would need to be done so the pages that use server side static generation (like curriculum page )uses a separate file that imports the server side schema files.


Custom S3 Server

Is there a possibility instead of using the Amazon S3 Server-Service using a self-hosted S3 Server (like MinIO)?
This would a nice feature :)

It's not possible at the moment, but it would be rather easy to implement.
We have some S3 config here https://github.com/asciinema/asciinema-server/blob/32c30f6785e23d89223fd2cf915da9d6f268b414/config/releases.exs#L28-L36
We'd need to implement support for host/port vars there.

It's not possible at the moment, but it would be rather easy to implement.
We have some S3 config here https://github.com/asciinema/asciinema-server/blob/32c30f6785e23d89223fd2cf915da9d6f268b414/config/releases.exs#L28-L36
We'd need to implement support for host/port vars there.

Waiting for this too


Extend move api to drafts

Closes #23.
This PR extends the movePost() API to move posts between collections, and also out of any collection.

Once merged, I'll tag and release this as 0.3.0 to match the requirements for writeas/writefreely-swiftui-multiplatform#96.

Once merged, I'll tag and release this as 0.3.0 to match the requirements for writeas/writefreely-swiftui-multiplatform#96.


Add support for compressed blob uploads

Currently we only support compression on the transport, add support for compressed uploads:
main/uploads/94448848-5c26-4e27-9448-50f9fea1947e/compressed-blobs/zstd/33cc97ba1cbeb6c3c542d594f3d96cf0a80f562a287c50f61783763be42586bd/79

First update remote_execution.proto to v2.3 in #268
Then we can add support for the different compression types

#281 adds support for reading the compressed blob resource names.  Now we just need to handle the compressed blob.

Might be nice if these were passed through GrpcStore and then if the CompressionStore were in use it could simply used the pre-compressed content?

Might be nice if these were passed through GrpcStore and then if the CompressionStore were in use it could simply used the pre-compressed content?

We can read the capabilities API in the GrpcStore, and if it supports compressed uploads/downloads use it?

I'd like to work on this issue. cc: @allada


Basic support for snapping to multiple zones

Summary of the Pull Request
This PR implements basic support for allowing to snap to multiple zones at once, while minimizing impact on other features. More functionality will be added in separate upcoming PRs.

References
Related to #335

PR Checklist

[x] Applies to #335
[x] CLA signed. If not, go over here and sign the CLA
[x] Tests added/passed
[x] Requires documentation to be updated
[x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed
Added a few unit tests, also, tested manually. All tests pass and the feature works as expected.

How to snap to multiple zones?

How to snap to multiple zones?
If the zones are adjacent, move the cursor over the common edge.

Since this PR states "basic support for snapping to multiple zones" I assume not all scenarios were covered. I've did basic general tests and it works as expected. One behavior that I've notice that is causing issues is following:

If You hold shift and drag, on the intersection both zones will show as available to snap, which is not possible. I know that this scenario is also something we handle in FZ Editor when it comes to merging zones (these kind of zones can't really be merged together).

@vldmr11080

If You hold shift and drag, on the intersection both zones will show as available to snap, which is not possible.

It may not be intuitive, but it is supported and we should support it.

@vldmr11080

If You hold shift and drag, on the intersection both zones will show as available to snap, which is not possible.

It may not be intuitive, but it is supported and we should support it.

I'm not against having both zones show as available (turn blue), but not in this scenario, we have to detect it.

Maybe I'm not understanding, the two zones are adjacent and the union of the two is the red rect:

It would be nice to show it when both are activated, but that can be an improvement that we do later.

If we’re looking at the union of two zones, and not exact coordinates than this works as expected, and no follow-up work is needed.

Works nice! Nice feature!

@PrzemyslawTusinski please take a look to make sure that I merged your recent code into mine properly

Merge looks good

LGTM after mutex/assert stuff is resolved.

LGTM after mutex/assert stuff is resolved.

Perhaps we can do this in another PR?

sure, though since the lack of mutex creates a crash possibility, that should be pretty high priority.

I'll start work on that immediately after merging this


What is the Path for NPM-installed Semantic-UI-React?

I am trying to add webpack entry points for your js, but apparently I'm using the wrong "dist module path/name" ... please the 'entry' property/key below...
Steps to Recreate:

npm install semantic-ui-react --save
npm install semantic-ui-css --save
in webpack.config.js, I'm doing this:
module.exports = {
entry: [
'script!semantic-ui-css/semantic.min.js',
'script!semantic-ui-react/dist/semantic-ui-react.min.js',
'./app/app.jsx'
]
in my app.jsx file, I added:
require('style!css!semantic-ui-css/semantic.min.css');

Can someone please let me know what the correct module paths are? The error I get is "Module not found: Error: Cannot resolve module"

Take a look in your node_modules directory to find the full path.  Once you find our package, you can use the package.json main field to see the full path to the main module.

Thank you @levithomason , but now that I have it all wired up properly with the correct module name/path, it throws an error saying:
Cannot read property 'Component' of undefined
When I debug, it's actually M.Component ... so it's the 'M' that's undefined.
Here's my package.json
"dependencies": {
"axios": "^0.15.3",
"express": "^4.14.0",
"react": "^15.4.1",
"react-dom": "^15.4.1",
"react-router": "^3.0.0",
"semantic-ui-css": "^2.2.4",
"semantic-ui-react": "^0.62.1"
}
Here's my webpack.config.js:
module.exports = {
entry: [
'script!semantic-ui-css/semantic.min.js',
'script!semantic-ui-react/dist/umd/semantic-ui-react.min.js',
'./app/app.jsx'
],
Here's it's require statement in my app.jsx:
require('style!css!semantic-ui-css/semantic.min.css');
Building this using webpack yields a successful build and does not throw the error mentioned above, however Chrome & Firefox browsers do throw the error in the console, and it breaks the app  :-(


Build script doesn't include seash modules

SeattleTestbed/dist's build.py (aka "the new build script") currently lacks the functionality to copy over file trees to the target dir, see SeattleTestbed/dist#140. This consequently excludes SeattleTestbed/seash's modules dir from the build.
Fix config_build.txt once build.py is fixed!

This is really a seash issue. Closing here, reopening (with updated references etc.) as SeattleTestbed/seash#93.


Add support for placeholder dependency indicating empty dependency group

Sample usage:
<Dependency Include="_._">
  <TargetFramework>net46</TargetFramework>
</Dependency>

An empty dependency group is needed when you support a platform but don't need any dependencies but another group (for example an earlier framework) required dependencies.

Thanks for the contribution.
Can you add a test for this as well? We've got a testing infrastructure that should make it fairly straightforward.

I added a test, can you take a look?

Thanks. I built and tested locally since the CI doesn't seem to be working.


Add needs_association

This makes it easy to save an association. For example, let's say we want to save a Comment that is associated with a Post.
You could use needs_association to set it:
class CommentForm < Comment::BaseForm
  allow body
  # Will accept a Post and set the foreign_key automatically (in this case `post_id`)
  needs_association post
end

# Will create a comment that is associated with the post
CommentForm.create!(params, post: PostQuery.new.first)

Instead, you can do CommentForm.create!(params, post_id: post.id). No need to do needs_association


Hugging Face API

Would it be possible to add the Hugging Face API to access many different models?

Yes sure! We are gonna add it to the next release, you can check the development in the pre/beta branch and give suggestions in our Discord :)

Once the above gets merged: you can use hugging face models using this snippet at examples/huggingfacehub/smart_scraper_huggingfacehub.py

hi, can u try it pls?

Thanks a lot, it works like a charm! I've built a Gradio interface to showcase it: https://huggingface.co/spaces/JournalistsonHF/ai-scraper

@fdaudens really cool! Will share it on social media ;)


Bulk updates/upserts ignore empty/blank fields

This seems to be a function of how the Bulk API handles CSV input. For example, if I have two Product2 records, each with a value in the “Description” field, and submit an upsert job with a blank value in that field:
Id,Name,ProductCode,Description
000000000000000000,Product A,1000,
000000000000000000,Product B,1001,

...the “Name” and “ProductCode” fields get updated, but the “Description” fields retain their previous values. However, if I hack together some XML-formatted batch input and add that to a job, it works as expected (clears the fields). So this definitely seems to be a CSV thing, not a Bulk API thing. (The SOAP API uses the fieldsToNull array to indicate sObject fields to be set to null, but there doesn't seem to be an equivalent of that field within the scope of the Bulk API.)
I'd like to featurize this with a command line flag for bulk jobs – depending on how the flag is set, Force CLI either sends the CSV data as-is (to ignore blank fields) or parses the CSV and sends it as XML (to handle blanks as blanks). If I were to implement this, do you have a preference for which behaviour would be the default with no flag set? I.e., should the default comply with (what is IMHO) the reasonable expectation of having blank values be treated as such, or should it be consistent with the way the utility has worked to date and ignore blanks?
Alternatively, I could avoid disguising a platform deficiency as a feature and instead let users specify whether their job input is CSV or XML. This would make the implementation more straightforward and perhaps less deceptive, but the benefit of CSV vs. XML would not be as obvious to the user (“XML input? Why would I want to use that?”).

...orrr I could read the documentation and notice that I can set CSV fields to “#N/A” to force them to be set to a blank value. Whoops! If there's any interest in submission of XML bulk jobs I'm still happy to do the work; otherwise, this issue can probably be closed.

Thanks for the post @MrDOS! I'm not sure xml is very popular these days so I think I would let that go until it is really needed.

Sounds good to me. Thanks for the speedy reply.


If I want to use the base version of VMamba, how should I modify the code and which version of the pre-training file should I use?

If I want to use the base version of VMamba, how should I modify the code and which version of the pre-training file should I use?

Hello. This question is beyond the scope of what I'm doing. But do have a look at official page of VMamba 'https://github.com/MzeroMiko/VMamba'.


'spit' out results below query block in markdown

Amazing plugin, but you've been told that already :)
I am a keyboard heavy user, and rarely use the preview mode. I would like to be able to run a command with a hotkey that could spit out the results of dataview query block below the query block in markdown using wikilinks or markdown link format (maybe just using the global setting).
That way I could navigate to the notes in the results, or copy the result data for further refining of the queries - all without leaving the mouse.
There's an idea for generating static html in issue 40. I guess there'll be a lot of shared code between my FR and that.

I am also a big keyboard proponent; as you say, this is similar to the static HTML generation, though in your case the optimal output is probably just a list or markdown table of data. Will see what I can do.

I'm curious why pressing a hotkey to run the command in preview mode is any different from pressing a hotkey to switch to preview mode and see the output, then switch back. That seems to be adding complexity to the plugin for something that can be rather trivially worked around. But maybe I'm missing something.

You can't use keyboard to easily navigate through preview mode to click links / copy+paste, primarily.

Duplicate of #42

Grouping all of the related "export static data" issues together into one for better tracking.

Is there an update on this? Would love to be able to publish dataview results with Obsidian Publish, Quartz or the like.


Wheeled robots

The README specifies there's wheeled robots but the hyperlink does not show any. Why is this?

Thank you for pointing this out :smiley: This error happened when importing the list of awesome robot descriptions. That list has wheeled robots, but all of them are distributed in the Xacro format that Python libraries don't parse directly.


Add wait_for_tracy() export

This gives user code that is running on a non-instrumented build a way to replicate the logic from JULIA_WAIT_FOR_TRACY=1, e.g. waiting until the tracy profiler connects.  This allows for easier synchronization of relevant workload, e.g. starting a task that will run the workload which immediately blocks on waiting for tracy, then starting up the capture agent.

I've added another commit that adds capture() which makes it easy to launch the capture utility.

Imo the wait for tracy thing should be split out from the extension since AFAIU they are orthogonal changes.
Also, should we do the same as Julia built with tracy does in that we check for the env variable  JULIA_WAIT_FOR_TRACY in __init__ and wait there if it is set?
Edit: I don't think the __init__ check will work right now because Julia itself deletes that environment variable unconditionally on startup but it could be changed to only delete it if Julia is built with tracy enabled.

I've removed the capture() function, I'll reintroduce that in a future PR.


ValueError: invalid literal for int() with base 10: '1.840

I updated the app.py after the last commit, here's the traceback:
File "/home/cristianc/Scrivania/ads-scraper/app.py", line 118, in <module>
counter = counter()
^^^^^^^^^
File "/home/cristianc/Scrivania/ads-scraper/app.py", line 71, in counter
return int(int(result[0])/10)+1, dataStructreType
^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: '1.840'

Can you send your URL  in the env.py file? @TheCastes

Here @MajideND  "https://www.google.com/maps/place/Google+UK/@51.5332608,-0.1304879,17z/data=!4m7!3m6!1s0x48761b3c54efa6e1:0xc7053ab04745950d!8m2!3d51.5332609!4d-0.1260032!9m1!1b1"

@TheCastes There was a problem with the new release thanks for your report. Please let me know if there is any other problem after this update.
Furthermore, the URL you are using has more than 1800 reviews and crawling this number of reviews may take some minutes.


Feat: Biconomy Paymaster

Description
WIP
includes
BiconomyPaymaster (hybrid) with rpc calls pm_sponsorUserOperation and pm_getFeeQuotesOrData
Check calculations, error handling, types handling
Added method buildTokenPaymasterUserOp in the account package
hybrid paymaster class has method to checkTokenApproval and build transaction
for Biconomy account API above method modifies userOp with approval for asked token
BiconomySmartAccount -> buildPaymasterUserOp -> getTokenApprovalRequest
/////
need to review types
///
Testing scripts are updated here
yarn run smartAccount mintWithBtpm
yarn run smartAccount mint
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

/prbot review