Typing failure when type-check is in closure variable

I have been working around the limitation of type and isinstance not working in overload implementations by putting the type checks in the overload body. While a bit cumbersome, that works mostly fine.
The following however is a problem for the typer:
import numpy as np
from numba import njit
from numba.core import types
from numba.extending import overload

def foo(a, b=None):
    pass

@overload(foo)
def foo_ovl(a, b=None):
    b_is_tuple = isinstance(b, (types.Tuple, types.UniTuple))

    def foo_impl(a, b=None):
        if b_is_tuple is True:
            b = b[0]
        return b
    return foo_impl

@njit
def test_tuple(a, b):
    foo(a, b)

test_tuple(1, (2, ))

This gives the output:
TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Invalid use of Function() with argument(s) of type(s): (int64, UniTuple(int64 x 1))
 * parameterized
In definition 0:
    TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Cannot unify UniTuple(int64 x 1) and int64 for 'b', defined at  (14)

File "", line 14:
    def foo_impl(a, b=None):
        if b_is_tuple is True:
        ^

[1] During: typing of assignment at  (15)

File "", line 15:
    def foo_impl(a, b=None):

        if b_is_tuple is True:
            b = b[0]
            ^

    raised from C:\Users\My User\Documents\My Project\libraries\numba\numba\core\typeinfer.py:985
In definition 1:
    TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Cannot unify UniTuple(int64 x 1) and int64 for 'b', defined at  (14)

File "", line 14:
    def foo_impl(a, b=None):
        if b_is_tuple is True:
        ^

[1] During: typing of assignment at  (15)

File "", line 15:
    def foo_impl(a, b=None):

        if b_is_tuple is True:
            b = b[0]
            ^

    raised from C:\Users\My User\Documents\My Project\libraries\numba\numba\core\typeinfer.py:985
This error is usually caused by passing an argument of a type that is unsupported by the named function.
[1] During: resolving callee type: Function()
[2] During: typing of call at  (21)

File "", line 21:
def test_tuple(a, b):
    foo(a, b)
    ^

Renaming the variables works as a workaround:
import numpy as np
from numba import njit
from numba.core import types
from numba.extending import overload

def foo(a, b=None):
    pass

@overload(foo)
def foo_ovl(a, b=None):
    b_is_tuple = isinstance(b, (types.Tuple, types.UniTuple))

    def foo_impl(a, b=None):
        if b_is_tuple is True:
            c = b[0]
        else:
            c = b
        return c
    return foo_impl

@njit
def test_tuple(a, b):
    foo(a, b)

test_tuple(1, (2, ))

I am not sure if this is a bug or not. Please close if it is expected behaviour.

Thanks for the report. This is due to lack of SSA form, it's essentially a known-bug/issue.


CircleCI fails during composer self-update

Composer self-update

[ErrorException]
rename(/home/circleci/.composer/cache/composer-temp.phar,/usr/local/bin/composer): Permission denied

https://circleci.com/gh/dimsav/laravel-translatable/155

successful again https://circleci.com/gh/dimsav/laravel-translatable/158


deprecate action

on closer inspection, it turns out that the ubuntu-vms on the new yaml-based GitHub Actions already ship with rsync, so there really is no need for a separate, container-based action.
I can just deprecate this action, and post in it's place the proper yaml to get it to work.

mmh but then again, it is a pretty long script that should be factored out somewhere.
Also, if people use container: for the entire job, then they can't use the underlying ubuntu. What a mess.

I think I got it now; to factor out the code, this needs to be a node.js action.


Cannot configure LotusLamp strip (worked before)

In September I bought a LED strip [https://www.amazon.de/gp/product/B0CBBLQ8WH/ref=ppx_yo_dt_b_search_asin_title?ie=UTF8&psc=1] and was happy when I found out, that it was controllable by Home Assistant through this HACS integration,
After an update it stopped working and I had to delete the integration, but downgrading did not help.
With latest version, configuring after installation of HACS integration and  restart leads to:
2024-02-04 08:51:08.173 ERROR (MainThread) [root] A message handler raised an exception: Cannot convert home_assistant_bluetooth.models.BluetoothServiceInfoBleak to habluetooth.models.BluetoothServiceInfoBleak Traceback (most recent call last):   File "src/dbus_fast/message_bus.py", line 798, in dbus_fast.message_bus.BaseMessageBus._process_message   File "/home/homeassistant/.homeassistant/deps/lib/python3.11/site-packages/bleak/backends/bluezdbus/manager.py", line 979, in _parse_msg     self._run_advertisement_callbacks(   File "/home/homeassistant/.homeassistant/deps/lib/python3.11/site-packages/bleak/backends/bluezdbus/manager.py", line 1028, in _run_advertisement_callbacks     callback(device_path, device.copy())   File "/home/homeassistant/.homeassistant/deps/lib/python3.11/site-packages/bleak/backends/bluezdbus/scanner.py", line 270, in _handle_advertising_data     self.call_detection_callbacks(device, advertisement_data)   File "/home/homeassistant/.homeassistant/deps/lib/python3.11/site-packages/bleak/backends/scanner.py", line 210, in call_detection_callbacks     callback(device, advertisement_data)   File "src/habluetooth/scanner.py", line 179, in habluetooth.scanner.HaScanner._async_detection_callback   File "src/habluetooth/scanner.py", line 204, in habluetooth.scanner.HaScanner._async_detection_callback   File "src/habluetooth/manager.py", line 398, in habluetooth.manager.BluetoothManager.scanner_adv_received   File "src/habluetooth/manager.py", line 398, in habluetooth.manager.BluetoothManager.scanner_adv_received   File "src/habluetooth/manager.py", line 437, in habluetooth.manager.BluetoothManager.scanner_adv_received TypeError: Cannot convert home_assistant_bluetooth.models.BluetoothServiceInfoBleak to habluetooth.models.BluetoothServiceInfoBleak
I guess I cannot work around any more :-(

Ok, i think you have a problem between home_assistant_bluetooth library and HA versions.
Maybe it is something similar that: https://github.com/home-assistant/core/issues/84584
Maybe you need to add bluetooth integration in Settings - Integrations - add integration - search Bluetooth
Maybe you need to update HA and my integration to lastest version
Try all i saw you, and post with your versions of HA , and libraries bleak and home_assistant_bluetooth

Maybe it is something similar that: https://github.com/home-assistant/core/issues/84584

Yeah, that was it: the home_assistant_bluetooth*-directories showed version 10, but the python dependencies already 12.
Deleting both directories, downgrade and upgrade again did the trick.
Thanks!

Hint from Dave was successful.


HC12 Batching only executes first operation

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
I noticed that in HC12, when i make a batch of requests i am only getting the result to the first operation. This issue was already reported in slack by Chris Harris.
According to Chris, this issue seems to be localized in the MultiPartResponseStreamSerializer and his proposal worked for me, which is using:
services.AddHttpResultSerializer(
   batchSerialization: HttpResultSerialization.JsonArray
);

Steps to reproduce
Make a request with a batch of operations:
[
	{
		"query": "query DummyQuery1 { buildVersion }",
		"operationName": "DummyQuery1"
	},
    {
		"query": "query DummyQuery2 { buildVersion }",
		"operationName": "DummyQuery2"
	}
]

Response:
---
Content-Type: application/json; charset=utf-8

{"data":{"buildVersion":"1.0.22011.112"}}
-----

Relevant log output
No response
Additional Context?
No response
Product
Hot Chocolate
Version
12.4.1

We have started work on batching.

This bug is still present in 12.7.0.
Im unsure how to give further detail of the bug. I created a fresh project following the getting started section of the docs and here the bug is present aswell.

@michaelstaib this issue is reproducible in v12.12.1, for now the workaround is to use HttpResultSerialization.JsonArray but by using it we lose the incremental delivery over HTTP. Any suggestions there?

I think @michaelstaib fixed this in v13

@nelsonprsousa @michaelstaib by any chance there will be a release including a fix for this issue against v12 or do we need to wait v13 release?

I think @michaelstaib fixed this in v13

I have tried the same thing v13.0.0-preview.28, this issue is reproducible there as well

Not sure yet where we put this. We will fix it. But have no clue when yet. I will reevaluate this at the end of this month. At the moment everyone in the team busy on other topics.

This is now fixed and will be integrated into 12.14.0-preview.1


Display warning and critical treshholds

Hi
Currently the warning and critical treshholds are not displayed on the graphs.
Would it be possible to add this functionality as well?
The format url string to add is something like this:
&target=alias(color(constantLine($warning_value),'yellow'),'warning')&target=alias(color(constantLine($critical_value),'red'),'critical').
My PHP knowledge is very limited so I can't do it myself.
Thanks

@Bigluu I have added graphite argument templating.  Thanks a lot for this feature. It works perfectly.

No problem @Bigluu, i wanted to allow users to configure the graphite args, your request spurred it on.


Expandable in stack doesn't work (Nova v4.34.3)

Hey !
The expandable doesn't work if in Stack field :
Stack::make('Test', [     HasMany::make('User Post', 'posts', Post::class)->expandable() ]),
I got an error in the console:

TypeError: r.resource is undefined

Thank you very much !

From Nova's documentation, Stack fields are only intended for stacking text lines.
For this reason, expandable fields cannot be used within Stack fields and I do not plan to implement support for them.


Add syntax for compute shader workgroup size

For example: https://github.com/Microsoft/DirectX-Graphics-Samples/blob/8f68bf07dfd134df3b90e83a63535d053bae9a8a/Libraries/D3D12RaytracingFallback/src/FallbackLayerUnitTests/DynamicIndexTest.hlsl
[numthreads( 8, 8, 1 )]
https://docs.microsoft.com/en-us/windows/desktop/direct3dhlsl/d3d11-graphics-reference-sm5-attributes

Robin says this is approved.


Missing shared libraries from Docker

We used to use the test file
./modules/perception/camera/test/camera_app_traffic_light_camera_perception_test.cc
which works perfectly about 2 months ago. But this week it reports missing shared libraries error and I cannot find the mkldnn.so on the Internet.
Is the docker file changed?
System information

OS Platform and Distribution  Linux Ubuntu 18.04:
Apollo installed from source:
Apollo version 5.5:

Steps to reproduce the issue:

Pull Apollo5.5.0 from github

run 'dev_start' and 'dev_into'

We want to run the test file in the following path
./modules/perception/camera/test/camera_app_traffic_light_camera_perception_test.cc
so we uncomment the BUILD lines for this file, it look like this
cc_test(   name = "camera_app_traffic_light_camera_perception_test",   srcs = ["camera_app_traffic_light_camera_perception_test.cc"],   linkopts = [       "-lnvinfer_plugin",   ],   deps = [       "//modules/perception/camera/app:traffic_light_camera_perception",       "//modules/perception/inference:inference_factory_lib",       "//modules/perception/inference/operators:perception_inference_operators",       "@caffe",       "@com_google_protobuf//:protobuf",       "@opencv",       "@tensorrt",       "@gtest//:main",       "@yaml_cpp//:yaml",   ], )
The file is uploaded below.

run 'bash ./apollo.sh build_opt_gpu' in docker, and this can compile successfully

run
./bazel-bin/modules/perception/camera/test/camera_app_traffic_light_camera_perception_test
and report
./bazel-bin/modules/perception/camera/test/camera_app_traffic_light_camera_perception_test: error while loading shared libraries: libboost_system.so.1.54.0: cannot open shared object file: No such file or directory

following the instruction in issue #10873, https://github.com/ApolloAuto/apollo/issues/10873, run
sudo apt-get install libboost-system1.54.0 libboost-filesystem1.54.0 libboost-program-options1.54.0 libboost-thread1.54.0 libboost-signals1.54.0
in the docker

try again
./bazel-bin/modules/perception/camera/test/camera_app_traffic_light_camera_perception_test

report error:
./bazel-bin/modules/perception/camera/test/camera_app_traffic_light_camera_perception_test: error while loading shared libraries: libmkldnn.so.0: cannot open shared object file: No such file or directory

Supporting materials (screenshots, command lines, code/script snippets):

Place these files under
./modules/perception/camera/test/camera_app_traffic_light_camera_perception_test.cc
modified files.zip

Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


Make organization field in volunteer sign up optional

Are you sure this isn't already optional? it is marked as optional in the code and I remember creating a volunteer without it in production (don't want to create another one to avoid creating more false accounts)

I tried to create a volunteer without an organization in development, and it seems to work just fine.

It's optional right now, closing.


Fix issue where selection set flattening uses the wrong parent type

Description
So let me just start out by saying that I've tried pretty much everything to replicate this problem in a small example. I even took our huge GQL schema into a sandbox and tried writing various queries to replicate the problem, without luck.
The gist of this is basically that after upgrading to the newer versions of the generator, we get this error:
TypeError: Cannot read property 'type' of undefined
        at D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-codegen\visitor-plugin-common\index.js:3027:65
        at Array.map (<anonymous>)
        at PreResolveTypesProcessor.transformPrimitiveFields (D:\source\roadmap-gh\src\Nordic\UI\node_modules\@grap
hql-codegen\visitor-plugin-common\index.js:3024:23)
        at SelectionSetToObject.buildSelectionSetString (D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-c
odegen\visitor-plugin-common\index.js:2868:32)
        at D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-codegen\visitor-plugin-common\index.js:2759:41
        at Array.reduce (<anonymous>)
        at SelectionSetToObject._buildGroupedSelections (D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-c
odegen\visitor-plugin-common\index.js:2749:80)
        at SelectionSetToObject.transformSelectionSet (D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-cod
egen\visitor-plugin-common\index.js:2913:54)
        at SelectionSetToObject.buildSelectionSetString (D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-c
odegen\visitor-plugin-common\index.js:2862:89)
        at D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-codegen\visitor-plugin-common\index.js:2759:41
    TypeError: Cannot read property 'type' of undefined
        at D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-codegen\visitor-plugin-common\index.js:3027:65
        at Array.map (<anonymous>)
        at PreResolveTypesProcessor.transformPrimitiveFields (D:\source\roadmap-gh\src\Nordic\UI\node_modules\@grap
hql-codegen\visitor-plugin-common\index.js:3024:23)
        at SelectionSetToObject.buildSelectionSetString (D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-c
odegen\visitor-plugin-common\index.js:2868:32)
        at D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-codegen\visitor-plugin-common\index.js:2759:41
        at Array.reduce (<anonymous>)
        at SelectionSetToObject._buildGroupedSelections (D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-c
odegen\visitor-plugin-common\index.js:2749:80)
        at SelectionSetToObject.transformSelectionSet (D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-cod
egen\visitor-plugin-common\index.js:2913:54)
        at SelectionSetToObject.buildSelectionSetString (D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-c
odegen\visitor-plugin-common\index.js:2862:89)
        at D:\source\roadmap-gh\src\Nordic\UI\node_modules\@graphql-codegen\visitor-plugin-common\index.js:2759:41

After a ton of debugging, I arrived at this suggested solution. Here are some screenshots to try and explain what is going wrong:
At this point where flattenSelectionSet is called, the block scoped parentSchemaType is ClientPerson, but the class scoped _parentSchemaType is GetClientResult
GetClientResult is a union type consisting of either ClientPerson or ClientCompany or one of a few error types.

The problem with this is that it ends up with a flattened list of fields, that contain fields specific to ClientCompany, which it then tries to apply to ClientPerson.

Pretty sure this is the same issue reported in #5061
I've also found that setting preResolveTypes to false, and/or inlineFragmentTypes to combine will prevent the issue as well. I think that basically reverts to older behavior, but I assume you changed the defaults for a reason.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
It has been tested on our very large schema and code base. As mentioned, I have not found a way to create a small replication of the issue. I have therefore not been able to write a test for it either.

Hey @mvestergaard, thank you for debugging this and finding a fix that works for your code-base! Did you manage to track down which operation caused this issue? If we have the schema and operation combination it shouldn't be impossible to solve this 🤔
I wanna merge this, but we really need a test for it!

I get that, and unfortunately no.
With this fix, I managed to at least the types for our code base built. However the types that were built were full of errors, so there are other things blocking us from upgrading as well.
We use some kinda niche features like near-operations-file, and a custom wrapper for the apollo tooling, which seems to be things that break every other release of this project 😢

Of course... I can look at it again and try to find the root cause when time permits. I'll change this to a draft in the meantime.

#8664 Adds this fix, along with a test, closing this one.

https://github.com/dotansimha/graphql-code-generator/releases/tag/release-1669935201062


fix(chat): fix 'duplicate the conversation to be able to edit' button (Issue #1166)

Description:
Fix 'duplicate the conversation to be able to edit' button
Issues:

https://github.com/epam/ai-dial-chat/issues/1166

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review


Private key usage counter and auditing

Migrated from sf.net, feature request 97
For each private key used by OpenXPKI maintain a usage counter that is increased on each explicit use of this key. (Consider digitally signing this counter.)
If an independent system could keep track of actual private key usage count, OpenXPKI could compare the expected usage count with the one reported by the independent system.
Should the reported numbers differ, this would mean the private key was (ab)used outside of OpenXPKI. The application could notice this and raise an audit monitoring event.
While mostly useless for keys stored in software, this would be a great feature when used with an HSM that supports a tamper-proof private key usage counter.
Note to self: consider nCipher Secure Execution Engine for implementation of this feature.

no demand - dropping


Added HttpClientException

Added

Moved HttpClientException from Library

Delivers https://www.pivotaltracker.com/story/show/144788233

@wnowicki styleci is complaining about something I haven't touched


Removed not from is_locked

Removed the not status from is_locked to correct inversion of status.
Tested by changing kia_uvo lock.py with:
    @property
    def is_locked(self):
        not_locked = not getattr(self.vehicle, "is_locked")
        return not_locked
        # return getattr(self.vehicle, "is_locked")

Found the upstream status and changed the toggle. This was also present in v1.X, which I corrected there as well.

Thank you for this!

Cheers, and thanks for all your work on this!


@types/jest v28 introduces circularly reference

Describe the bug
When using dependency "@types/jest": "28.1.3" a circular reference error is thrown:
:space_invader: build » compile | jsii --silence-warnings=reserved-word [2022-06-26T08:37:09.762] [ERROR] jsii/compiler - Compilation errors prevented the JSII assembly from being created node_modules/@sinclair/typebox/typebox.d.ts:237:21 - error TS2456: Type alias 'StaticIntersectReduce' circularly references itself. 237 export declare type StaticIntersectReduce<I extends unknown, T extends readonly any[]> = T extends [infer A, ...infer B] ? StaticIntersectReduce<I & A, B> : I;
using yarn why @sinclair/typebox revealed that @sinclair/typebox is used by @types/jest .
Expected Behavior
no circular reference error thrown
Current Behavior
circular reference error thrown
Reproduction Steps

Create new / update  CDK construct library with projen (that should update the mentioned package to > 28
run yarn build

Possible Solution
Fix version to 27.4.1 fixed the issue for me
Additional Information/Context
No response
SDK version used
1.61.0
Environment details (OS name and version, etc.)
MacOS

Yeah - we are in this situation largely because we're still on TypeScript 3.9, and most of the ecosystem around us is gradually adopting TypeScript 4.3 to 4.5 minimum targets (for obvious reasons).
There is also https://github.com/aws/aws-cdk-rfcs/pull/373 where I propose to have jsii and jsii-rosetta follow TypeScript compiler versions, so we can easily follow the "current" TypeScript release train in the future...

In the meantime - the next release of jsii will include #3623, which also introduces the ability to specify types in the jsii.tsc stanza in package.json so you can manually pick what @types/* packages are loaded in the global namespace, so you do not hit this problem when running jsii (you would need to exclude tests from the jsii compilation scope, and either use ts-jest or compile them separately with a "recent" typescript compiler -- that is definitely more work than pinning jest to an older release 😭).

Would setting skipLibCheck to true prevent jsii from looking in node_modules to begin with?

Would setting skipLibCheck to true prevent jsii from looking in node_modules to begin with?

I'm not sure... it could have other consequences on the TypeChecker AST we obtain during parsing, so I'm reluctant to resort to this...

Fixed by supporting modern TS versions.


Expr.Match

Can't believe we haven done that!

It's the refactoring. The refactoring has gotten us too far behind!


Journal not enabled error for git-remote-keybase

Hi there,
Keybase had been working flawlessly for me until I tried to update one of our Keybase git repos today:
$ git pull origin master
Initializing Keybase... done.
Syncing with Keybase... done.
git-remote-keybase error: (1) Journal not enabled for eee714808a2c935b80da9b40a0ebb926

I'm not sure what prompted this error, but I am now unable to clone, pull, push, or perform any operations to any of our Keybase git repos! I've tried restarting the Keybase app, restarting my laptop, and re-logging in via the keybase command line tool - the error message persists. According to both the application and the keybase command line tool, I have access to all of our repos.
Was wondering if anyone here had any helpful pointers as to what might be going on - thanks!
OS: macOS Sierra 10.12.6
git version: 2.15.0
Keybase version: 1.0.36-20171121022443+587efe057

Thanks we're looking at it now, sorry.


README fix about multiset rules

https://github.com/markrogoyski/itertools-php/blob/e13f5be9ae94ce042af5c122d70429d0027ff38e/README.md?plain=1#L961
Do we realy need this clarification?
Look at all the points:

If input iterables produce duplicate items, then multiset intersection rules apply.
If $minIntersectionCount is 1, then multiset union rules apply.

So if we have multisets on input then we have the case (1).
When we have $minIntersectionCount = 1 and multisets on input, then we still have case (1).
And when we have $minIntersectionCount = 1 and common sets on input, then no multisets rules needed.

So i think the case (2) is redundant.

Hi @markrogoyski,
Have you already seen this issue? I think this needs to be fixed before the next release.

Hi @Smoren,
Sure, if you think it is unnecessary. I went ahead and removed it.

Thank you Mark!

Thank you @markrogoyski,
I saw your commit, but this line is repeated several times for defferent methods in README. I think we need to remove them all.

Hi @Smoren,
Thanks for the heads up. I removed another one. Let me know if I missed any other comments.
Thanks.

Hi @markrogoyski,
Thank you, I think everything is OK now!


Add missing spaces in error messages.

Note: new features are to be opened against next, hotfixes against master.
Summary
SUMMARY_GOES_HERE
Full changelog

[Implement ...]
[Add related tests]
...

Issues resolved
Fix #XXX

Thank you, however this has already been taken care of in next and will be resolved in the upcoming 0.9 release.


Codecov

Apparently, test coverage was not working because I had only one test file named UserDefaultsStoreTests.swift
As soon as I renamed it, it worked, ¯_(ツ)_/¯
Thank you very much for your help @pawurb


Add some line breaks

Was browsing the pdf documentation when I noticed some bullets looked like this

So I clicked edit at the top and I believe this is what it was meant to be 😄

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: JingYenLoh sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

PR passed checklist review. List formatting change only, so will merge without further review.


Remote Event Receiver Guidance

Add more details on timeouts and best practices for long running operations

long running remote event receivers are a no-go...what do you think of having the event receiver post a message to a queue and background task which picks it up. Working on timerjob framework that will make this possible (one needs to be able to 'transfer' the calling user's context to the asynchronously running background process).

I was  thinking along the lines just needed a place to track this.

Was also on my blog todo list with details what we have gathered from the feature PMs related on the exact timings and practices. We should have simple story with storage queue and web jobs... and then introduction story to more advance model with the remote timerjob framework. I'd actually write 2 articles... first for the intro, second for the remote timer job framework approach with multithreading support when that's done.
Would suggest following:
Write the generic story - Vesa
Write introduction to framework based code - Bert
Frank can concentrate on the site provisioning framework. Deal?

:+1:
I like the idea Bert is talking about. For what its worth I implemented something similar just the other week where a "job-request" list is populated with "tasks" and then a simple web job is listening to that list every  minutes (configurable) and takes care of business.
It works well, but at the same time I think it needs to be robust enough to handle heavy load multiple simultaneous executions without any hiccups (mine doesn't), so for it to be multi-threaded and designed for heavy action is probably a must.
Just a few thoughts from my end of the pond.

Thanks Tobias. Process for this one will be exactly the same task feeding approach as with the https://github.com/OfficeDev/PnP/tree/master/Solutions/OD4B.Configuration.Async solution. That was however pretty complex and we need to explain the simplified process, so that field will understand how to truly take advantage of the async queuing process with storage queues and web jobs.
Code exists already, just to write down the story by end of next week should be now the approach.
We or Bert are pretty far with the multi-threaded approach as well, which was also demonstrated in TechReady this week. Looks really good. Now we just need to concentrate on proper documentation on this model.

:+1: Looking forward to seeing the outcome, you guys are doing an awesome job.

@VesaJuvonen  concur and agree

Closing some backlog items - this is nicely explained in following PnP Guidance article - https://github.com/OfficeDev/PnP-Guidance/blob/master/articles/SharePoint-Add-In-Recipe-event-receiver-and-list-event-receiver.md


Tracer.activeSpan() returning null if Spring Cloud Gateway is present

Description
After updating from Release Train 2020.0.0-M4 to 2020.0.0-M6, Tracer.activeSpan() is returning null if Spring Cloud Gateway is present.  Issue is still present in RC1.  It's as if OpenTracing isn't configured properly with the latest 2020.0.0 release and Spring Cloud Gateway.  My guess is it has to do with #1757 breaking SCG integration?
If I revert to M4 or a Hoxton release, it works.  If I remove Spring Cloud Gateway, it works (but of course, my routes no longer work).
Sample
I've created a sample project which demonstrates the problem here:  https://github.com/blake-bauman/test-spring-cloud-sleuth-gateway
With SCG dependency included, the result is null, but remove the dependency and you get an active Span.
For reference, the application is:
@SpringBootApplication
public class DemoApplication {

    public static void main(final String[] args) {
        SpringApplication.run(DemoApplication.class, args);
    }

@Bean
    public RouterFunction<ServerResponse> helloWorld(final WebClient.Builder builder, final Tracer tracer) {
        return route(GET("/hello"), request -> Mono.fromCallable(() -> "Active Span is " + tracer.activeSpan())
                                                   .flatMap(result -> ServerResponse.ok().contentType(TEXT_PLAIN).body(fromValue(result))));
    }
}

In our real project, we've also hooked up the trace data to the logging, and the trace data is also missing from the logs with SCG included.  Without SCG, it shows up.

Please check the documentation https://docs.spring.io/spring-cloud-sleuth/docs/3.0.0-RC1/reference/html/integrations.html#sleuth-http-server-webflux-integration
With the latest releases we turn on manual reactor instrumentation. It's reliable (it actually works!) and you'll see an immense performance improvement. You can check the following part of our tests to see how to make this work https://github.com/spring-cloud/spring-cloud-sleuth/blob/76ad931b4298b18389d0a4ea739316c14682888b/tests/common/src/main/java/org/springframework/cloud/sleuth/instrument/reactor/sample/FlatMapTests.java#L234-L271
In order to make your code work
@SpringBootApplication
public class DemoApplication {

    public static void main(final String[] args) {
        SpringApplication.run(DemoApplication.class, args);
    }

@Bean
    public RouterFunction<ServerResponse> helloWorld(final WebClient.Builder builder, org.springframework.cloud.sleuth.Tracer tracing, CurrentTraceContext currentTraceContext)) {
        return route(GET("/hello"), request -> Mono.fromCallable(() ->  WebFluxSleuthOperators.withSpanInScope(tracing, currentTraceContext, request.exchange(), () -> "Active Span is " + tracer.activeSpan())
                                                   .flatMap(result -> ServerResponse.ok().contentType(TEXT_PLAIN).body(fromValue(result))));
    }
}

The most important part is
WebFluxSleuthOperators.withSpanInScope(tracing, currentTraceContext, request.exchange(), () -> "Active Span is " + tracer.activeSpan())

When making such a call, this lambda () -> "Active Span is " + tracer.activeSpan()) will contain the current span in context.

Another option (discouraged) is to set explicitly spring.sleuth.reactor.instrumentation-type=decorate-on-each but eventually I think we'll move away from that approach at all.

But the weird thing is, my code works perfectly fine until I add Spring Cloud Gateway as a dependency.  Merely adding that dependency causes the code to break.  If I'm on RC1 and no SCG, my code works just fine.  Why is that?

That's because of this fellow https://github.com/spring-cloud/spring-cloud-sleuth/blob/master/spring-cloud-sleuth-autoconfigure/src/main/java/org/springframework/cloud/sleuth/autoconfig/instrument/web/client/TraceGatewayEnvironmentPostProcessor.java

Thanks for this.  I have a couple of questions for clarification.

We've got a bunch of code that gets shared among apps, some which have SCG and some which don't.  Does the WebFluxSleuthOperators solution work whether instrumentation-type is set to manual or not?
Does SCG still propagate the OpenTracing headers to the downstream service when instrumentation-type is set to manual?
If instrumentation-type is set to manual and you're making a call with WebClient, do you have to use WebFluxSleuthOperators to get the headers sent?
The SLF4J MDC no longer seems to have the tracing data when instrumentation-type is set to manual.  How can we enable logging to include the tracing data?

Finally:  what's the reason that including SCG forces this property to "manual" by default?  Wouldn't it be best to keep the default the same between SCG apps and non-SCG apps for compatibility?

We've got a bunch of code that gets shared among apps, some which have SCG and some which don't. Does the WebFluxSleuthOperators solution work whether instrumentation-type is set to manual or not?

What WebFluxSleuthOperators is it retrieves the tracing context that was set either in the ReactorContext or ServerWebExchange. The lamda that you pass to it will contain the tracing context put in scope. That means that your e.g. logging framework will contain proper MDC entries.

Does SCG still propagate the OpenTracing headers to the downstream service when instrumentation-type is set to manual?

SCG's instrumentation works regardless of the chosen instrumentation type. It reuses the ServerWebExchange to retrieve this information.

If instrumentation-type is set to manual and you're making a call with WebClient, do you have to use WebFluxSleuthOperators to get the headers sent?

WebClient should retrieve the current span from the ReactorContext so that should work out of the box. RestTemplate however, or anything else that operates on a ThreadLocal (like MDC and logging) requires the usage of WebFluxSleuthOperators.

The SLF4J MDC no longer seems to have the tracing data when instrumentation-type is set to manual. How can we enable logging to include the tracing data?

If you wrap logging in WebFluxSleuthOperators you will see MDC entries.

Finally: what's the reason that including SCG forces this property to "manual" by default? Wouldn't it be best to keep the default the same between SCG apps and non-SCG apps for compatibility?

Cause other instrumentation is broken and SCG works regardless of the chosen instrumentation type. The instrumentation type changes the way your custom code behaves.


The first variable passed by -ArgumentList gets "lost"

I believe I found an issue related to issue https://github.com/proxb/PoshRSJob/issues/132. I'm trying to pass 2 variables to a script block. The first variable passed by -ArgumentList gets "lost". Here is a sample replicable code. I went around it by adding an empty variable as my first variable.
$Test = {
param ($p1,$p2);
write-output "Argument $p1 and $p2 was passed"
}
$p1 = "Par1"
$p2 = "Par2"
Start-RSJob -Name TEST -ScriptBlock $Test -ArgumentList $p1, $p2
Start-RSJob -Name TEST -ScriptBlock $Test -ArgumentList '', $p1, $p2
Receive-RSJob -Name TEST
=============
Here is the result:
PS C:\Tools\PoshRSJob> $Test = {

param ($p1,$p2);
write-output "Argument $p1 and $p2 was passed"
}

PS C:\Tools\PoshRSJob> $p1 = "Par1"
PS C:\Tools\PoshRSJob> $p2 = "Par2"
PS C:\Tools\PoshRSJob>
PS C:\Tools\PoshRSJob> Start-RSJob -Name TEST -ScriptBlock $Test -ArgumentList $p1, $p2
Id       Name                 State           HasMoreData  HasErrors    Command

16       TEST                 Completed                    False        ...
PS C:\Tools\PoshRSJob>
PS C:\Tools\PoshRSJob> Start-RSJob -Name TEST -ScriptBlock $Test -ArgumentList '', $p1, $p2
Id       Name                 State           HasMoreData  HasErrors    Command

17       TEST                 Completed                    False        ...
PS C:\Tools\PoshRSJob>
PS C:\Tools\PoshRSJob> Receive-RSJob -Name TEST
Argument Par2 and  was passed
Argument Par1 and Par2 was passed
PS C:\Tools\PoshRSJob>
Hope it helps.

No, it's not lost, its go to $_ variable
$Test = {
 param ($p1,$p2);
 write-output "Argument psitem:$_ and p1:$p1 and p2:$p2 was passed"
}

I have long wanted to clarify this here #134

Oh wow! I just spent a bunch of time trying to figure this out :(
For now, I've removed the named parameters and resorted to using $args[0], $args[1] ...


export * from './localstorage, ./routes'

Instead of:
export * from './localstorage'
export * from './routes'

Do:
export * from './localstorage, ./routes'

If you want changes to the semantics of JavaScript you should advocate for such a change with TC39 and/or ESDiscuss. The TypeScript issue tracker is not the right place.
That being said, having to have a string "magically" delimitated and resolved is likely to never be accepted by TC39.

This is out of scope and also not going to happen - module specifiers are effectively opaque, so , is syntactically legal and could be being used already.


Add bandwidth check to qualification

Check if the device of participant supports SWB and FB as a part of qualification.

Done in #66


Add seed to script that generates background points

Probably won't make a difference given the number of points we're generating, but good practice to ensure that everyone's working off the same set.

Added seeds to scripts that generate filtered and pres-abs datasets and recreated those datasets. See 87d04e8


Reconsider Jasper's dependencies

We should reconsider Jasper's dependencies:

Check if all dependencies are still needed. Do wie really need m2m-aligner and mitlm? Can't See that we use them.
While we're at it, we should separate Jaspers core dependencies and Pocketsphinx'/plugin dependencies, so that users only need to install what they need.

I'll consider this as fixed.


TLS session resumption does not seem to happening with TLSv 1.2

Title: TLS session resumption does not seem to happening with TLSv 1.2
Description:
Envoy was deployed as apt package on Linux ubuntu based system.
Was trying to disable the TLS session reuse for HTTPS listener and even when the disable_stateless_session_resumption of tls_context is set to True and the TLS version used is TLSv1.2, the TLS session ID is being reused for the connections made after initial connection establishment.
I have confirmed this behaviour both by seeing the traffic capture at envoy proxy machine and also by verifying the same by using openssl command(link: https://serverfault.com/a/566361/557378)
Repro steps:

Send multiple requests by using wrk tool(1req per connection) from client machine to envoy proxy.
wrk -t 1 -c 5 -d 2s -H 'Connection: Close' https://<IP_ADDRESS>:444

Config:
Have the below envoy yaml config which was used which is pretty basic.
static_resources:
  listeners:
  - name: listener_https
    address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 444
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        typed_config:
          "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
          codec_type: http1
          stat_prefix: envoy_https
          route_config:
            name: local_route
            virtual_hosts:
            - name: backend
              domains: ["*"]
              routes:
              - match: { prefix: "/" }
                route: { cluster: backend_cluster }
          http_filters:
          - name: envoy.filters.http.router
            typed_config: {}
      tls_context:
        disable_stateless_session_resumption: True
        common_tls_context:
          tls_params:
            tls_minimum_protocol_version: TLSv1_2
            tls_maximum_protocol_version: TLSv1_2
            cipher_suites: "[ECDHE-RSA-AES128-GCM-SHA256]"
          tls_certificates:
            - certificate_chain:
                filename: #path to cert
              private_key:
                filename: # path to private key
  clusters:
  - name: backend_cluster
    type: STATIC
    max_requests_per_connection: 100000
    connect_timeout: 1.00s
    lb_policy: round_robin
    load_assignment:
      cluster_name: backend_cluster
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: <IP_ADDRESS>
                port_value: 1024 # HTTP port
           # Similarly 9 more HTTP endpoints are present
admin:
  access_log_path: "/var/log/envoy.access.log"
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 8001

By reading the API doc, I don't think it is a config issue.
Stats output:
From the stats output, ssl reuse counter seems to be incrementing.
root@envoy-proxy:~/envoy_configs# curl -X GET localhost:8001/stats|grep ssl
http.admin.downstream_cx_ssl_active: 0
http.admin.downstream_cx_ssl_total: 0
http.perf_envoy_https.downstream_cx_ssl_active: 0
http.perf_envoy_https.downstream_cx_ssl_total: 6229
listener.<IP_ADDRESS>_444.server_ssl_socket_factory.downstream_context_secrets_not_ready: 0
listener.<IP_ADDRESS>_444.server_ssl_socket_factory.ssl_context_update_by_sds: 0
listener.<IP_ADDRESS>_444.server_ssl_socket_factory.upstream_context_secrets_not_ready: 0
listener.<IP_ADDRESS>_444.ssl.ciphers.ECDHE-RSA-AES128-GCM-SHA256: 6225
listener.<IP_ADDRESS>_444.ssl.connection_error: 0
listener.<IP_ADDRESS>_444.ssl.curves.P-256: 6225
listener.<IP_ADDRESS>_444.ssl.fail_verify_cert_hash: 0
listener.<IP_ADDRESS>_444.ssl.fail_verify_error: 0
listener.<IP_ADDRESS>_444.ssl.fail_verify_no_cert: 0
listener.<IP_ADDRESS>_444.ssl.fail_verify_san: 0
listener.<IP_ADDRESS>_444.ssl.handshake: 6225
listener.<IP_ADDRESS>_444.ssl.no_certificate: 6225
listener.<IP_ADDRESS>_444.ssl.ocsp_staple_failed: 0
listener.<IP_ADDRESS>_444.ssl.ocsp_staple_omitted: 0
listener.<IP_ADDRESS>_444.ssl.ocsp_staple_requests: 0
listener.<IP_ADDRESS>_444.ssl.ocsp_staple_responses: 0
listener.<IP_ADDRESS>_444.ssl.session_reused: 6211
listener.<IP_ADDRESS>_444.ssl.versions.TLSv1.2: 6225

disable_stateless_session_resumption disables stateless session resumption (via TLS Session Tickets), but not stateful session resumption (cache on the server-side).

Thanks @PiotrSikora
Also is there a way to disable stateful session resumption as well in envoy currently? I was not able to find this in the api docs.

No, currently there is no way to control the built-in session cache.

Thanks once again @PiotrSikora .
Would be closing this issue.

Following up on this thread, is there any work done recently to support disabling stateful session resumption?

PR https://github.com/envoyproxy/envoy/pull/29639 introduced disable_stateful_session_resumption that should address this issue.


enhancement: add native Facebook Auth Component

**Is your feature request related to a problem?
Facebook Auth

Closing as done


AqourAreA

add DeepFM model

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.:white_check_mark: ZhangHandi:white_check_mark: tngt:white_check_mark: lvjian0706:x: AqourAreAYou have signed the CLA already but the status is still pending? Let us recheck it.

1.把文件夹Deep FM换一下，换成DeepFM for CTR Prediction


SCRD-3808 Integrate barbican tests

This commit includes changes to run some of the
upstream service tests, more specifically, the barbican
client functional tests and the barbican functional API tests.
The tests run in a venv where the required packages are installed,
creates user/project resources, role assignment and the
configuration file needed  to run these tests.

What's the purpose of run_filter, seems like it has the same value as test_name?
I suggest setting the default value of test_branch to stable/pike if cloud8 and stable/rocky if cloud9 and removing the run_filter parameter (or at least set a default value for it). The idea is that anyone should be able to run the tests, at least with default values, without requiring previous knowledge about it (such as which test_filter/test_branch I should use for an specific test).

I will remove having test_name for the run_filter. I would like to keep this parameter since run_filters can give extra filtering of tests if needed. For example: if I want to run only the smoke tests for barbican-functional, then I can define the smoke run_filter for it. The run_filter parameter exists earlier in the framework.
Regarding test_branch value, I can temporarily patch the barbican template scripts to use the right branch based on the release version of the cloud. But however, this should be part of the ansible playbook support from framework point of view.

@flaviodsr I have squashed all my commits into one single commit as requested. Please review.


Ais

This PR contains an implementation of Annealed Importance Sampling Neal, 1998.

the AIS struct has two attributes:

proposal_kernels: an array of instances of AdvancedMH.RandomWalkProposal, currently instances of AdvancedMH.RandomWalkProposal
schedule: an array of floats defining the intermediate tempered distributions

each transition corresponds to a single particle, and contains the particle's AIS logweight as well as its final position
works with the old AbstractMCMC interface, eg uses sample_init!

To do:

add proposals other than RWM, eg Hamiltonian Dynamics
test on targets with multiple modes
add default constructors for schedule and proposals
allow intermediate distributions that are not tempered distributions
add particle history to AISTransition attributes

Thanks, @denainjs. I’ll take a closer look soon. A glance at the PR seems to suggest that it depends on AdvancedPS. If so, can you also create a PR for your work on AdvancedPS? We need to get AdvancedPS registered before merging this PR.

Thanks, @denainjs. I’ll take a closer look soon. A glance at the PR seems to suggest that it depends on AdvancedPS. If so, can you also create a PR for your work on AdvancedPS? We need to get AdvancedPS registered before merging this PR.

OK, I've just created 2 PRs for my work on AdvancedPS:

one for the AdvancedPS.jl repo proper
one for the new_smc branch of Turing.jl (ie the files in src/inference/ corresponding to particle samplers)

Thanks for the comments @torfjelde!
AIS and the refactoring of particle samplers are indeed independent. I forgot to remove PS-related changes from here when I created the other PRs, so I'll do that now.

No worries :+1:
It looks like you're trying to remove all the stuff in this PR related to the particle-samplers? I'd instead suggest starting from #master and add only the AIS-code, as this is going to be much simpler + ensure that you're compatible with #master.
If you want, I can force-push my branch (see: https://github.com/torfjelde/Turing.jl/tree/tor/ais-only) and you can work from this. I'm

Related Julia package: https://github.com/treigerm/AnnealedIS.jl

Closed in favour of https://github.com/treigerm/AnnealedIS.jl


Empty page prepended to pdf output

I have a test.md with this content: https://jaspervdj.be/lorem-markdownum/markdown.txt
the pdf export prepends one empty site to the actual page.
I'm using the material theme and downloaded mkdocs today. is this a known issue? can someone please check if it appears for him as well?

I have the same problem.  I don't have a solution at the moment.  If you find one, please post.

Checkout mkdocs-print-site-plugin as an alternative. Full disclosure: I'm the author.

Issue seems to be that you don't have an index.md file. Adding one will populate the first page.

@m09 I can reproduce this bug, even with one single markdown file called index.md.
Here's the longest markdown file which gets converted to a single page pdf on my computer:
# Just a title

1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A # Just one page

Here's the shortest markdown file which gets converted to 2-pages pdf, with a blank first page:
# Just a title

1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A # Just one page
1. A # 2 pages, with first page empty.

Here are the resulting pdfs : index_just_one_page.pdf & index_two_pages.pdf.
If it helps, the corresponding mkdocs.yml is:
site_name: PDF Test
theme:
  name: material

plugins:
  - pdf-export:
      media_type: print

And requirements.txt is:
Babel==2.9.0
beautifulsoup4==4.9.3
cairocffi==1.2.0
CairoSVG==2.5.0
cffi==1.14.4
click==7.1.2
cssselect2==0.4.1
defusedxml==0.6.0
future==0.18.2
gitdb==4.0.5
GitPython==3.1.11
html5lib==1.1
htmlmin==0.1.12
importlib-metadata==3.3.0
Jinja2==2.11.2
joblib
jsmin==2.2.2
livereload==2.6.3
lunr==0.5.8
Markdown==3.3.3
markdown-inline-graphviz-extension==1.1
MarkupSafe==1.1.1
mkdocs==1.1.2
mkdocs-awesome-pages-plugin==2.5.0
mkdocs-git-revision-date-localized-plugin==0.8
mkdocs-localsearch==0.7.0
mkdocs-markdownextradata-plugin==0.2.0
mkdocs-material==6.2.3
mkdocs-material-extensions==1.0.1
mkdocs-minify-plugin==0.3.0
mkdocs-pdf-export-plugin==0.5.8
nltk==3.5
Pillow==8.0.1
pycparser==2.20
Pygments==2.7.3
pymdown-extensions==8.1
Pyphen==0.10.0
pytz==2020.5
PyYAML==5.3.1
regex==2020.11.13
six==1.15.0
smmap==3.0.4
soupsieve==2.1
tinycss2==1.1.0
tornado==6.1
tqdm==4.55.0
WeasyPrint==52.2
webencodings==0.5.1
zipp

On Linux Mint 19.3.

@m09 I can reproduce this bug, even with one single markdown file called index.md.
Here's the longest markdown file which gets converted to a single page pdf on my computer:
# Just a title

1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A # Just one page

Here's the shortest markdown file which gets converted to 2-pages pdf, with a blank first page:
# Just a title

1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A
1. A # Just one page
1. A # 2 pages, with first page empty.

Here are the resulting pdfs : index_just_one_page.pdf & index_two_pages.pdf.
If it helps, the corresponding mkdocs.yml is:
site_name: PDF Test
theme:
  name: material

plugins:
  - pdf-export:
      media_type: print

And requirements.txt is:
Babel==2.9.0
beautifulsoup4==4.9.3
cairocffi==1.2.0
CairoSVG==2.5.0
cffi==1.14.4
click==7.1.2
cssselect2==0.4.1
defusedxml==0.6.0
future==0.18.2
gitdb==4.0.5
GitPython==3.1.11
html5lib==1.1
htmlmin==0.1.12
importlib-metadata==3.3.0
Jinja2==2.11.2
joblib
jsmin==2.2.2
livereload==2.6.3
lunr==0.5.8
Markdown==3.3.3
markdown-inline-graphviz-extension==1.1
MarkupSafe==1.1.1
mkdocs==1.1.2
mkdocs-awesome-pages-plugin==2.5.0
mkdocs-git-revision-date-localized-plugin==0.8
mkdocs-localsearch==0.7.0
mkdocs-markdownextradata-plugin==0.2.0
mkdocs-material==6.2.3
mkdocs-material-extensions==1.0.1
mkdocs-minify-plugin==0.3.0
mkdocs-pdf-export-plugin==0.5.8
nltk==3.5
Pillow==8.0.1
pycparser==2.20
Pygments==2.7.3
pymdown-extensions==8.1
Pyphen==0.10.0
pytz==2020.5
PyYAML==5.3.1
regex==2020.11.13
six==1.15.0
smmap==3.0.4
soupsieve==2.1
tinycss2==1.1.0
tornado==6.1
tqdm==4.55.0
WeasyPrint==52.2
webencodings==0.5.1
zipp

On Linux Mint 19.3.

I have the same problem. I don't have a solution at the moment.Anybody know? Please share your solutions

I have the same problem. I don't have a solution at the moment.Anybody know? Please share your solutions

If I select all the text in one of those seemingly empty pages, I actually find a link saying Skip to content.

If you are using mkdocs-material I've fork and made my own plugin without using weasyprint but pyppeteer. I have got better results and more control over the exported files. However I do not support combined for now.

Checkout mkdocs-print-site-plugin as an alternative. Full disclosure: I'm the author.

Four years later, mkdocs-print-site-plugin made my day. Thanks @timvink


Empty column doesn't work even with explicit dtypes assignment

For following csv
1,2,
2,2,
3,2,
4,2,
5,2,

the test that looks like
import os
os.environ["MODIN_EXPERIMENTAL"] = "True"
os.environ["MODIN_ENGINE"] = "ray"
os.environ["MODIN_BACKEND"] = "omnisci"

import modin.pandas as pd

df = pd.read_csv("null_column.csv", dtype=["int", "int", "int"])
print(df)

gives now
terminate called after throwing an instance of 'std::runtime_error'
what():  null is not yet supported
We need to understand a root cause - either dtype argument is bad (doesn't work in omnisci-modin or specified incorrectly) or problem is in import

Seems like this form of dtype argument is not supported even by pandas itself:
>>> rp = pd.read_csv(csv_file, dtype=['int', 'int', 'int', 'int', 'int'])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/users/amalakho/local/miniconda3/envs/o-modin/lib/python3.8/site-packages/pandas/io/parsers.py", line 676, in parser_f
    return _read(filepath_or_buffer, kwds)
  File "/users/amalakho/local/miniconda3/envs/o-modin/lib/python3.8/site-packages/pandas/io/parsers.py", line 448, in _read
    parser = TextFileReader(fp_or_buf, **kwds)
  File "/users/amalakho/local/miniconda3/envs/o-modin/lib/python3.8/site-packages/pandas/io/parsers.py", line 880, in __init__
    self._make_engine(self.engine)
  File "/users/amalakho/local/miniconda3/envs/o-modin/lib/python3.8/site-packages/pandas/io/parsers.py", line 1114, in _make_engine
    self._engine = CParserWrapper(self.f, **self.options)
  File "/users/amalakho/local/miniconda3/envs/o-modin/lib/python3.8/site-packages/pandas/io/parsers.py", line 1891, in __init__
    self._reader = parsers.TextReader(src, **kwds)
  File "pandas/_libs/parsers.pyx", line 480, in pandas._libs.parsers.TextReader.__cinit__
  File "/users/amalakho/local/miniconda3/envs/o-modin/lib/python3.8/site-packages/pandas/core/dtypes/common.py", line 1874, in pandas_dtype
    npdtype = np.dtype(dtype)
TypeError: data type not understood
>>>

That’s fine, feel free to rewrite the test

generally, pandas says:

dtypeType name or dict of column -> type, optional
Data type for data or columns. E.g. {‘a’: np.float64, ‘b’: np.int32, ‘c’: ‘Int64’} Use str or object together with suitable na_values settings to preserve and not interpret dtype. If converters are specified, they will be applied INSTEAD of dtype conversion.

So, either dict or one type for all

working pandas:
>>> rp = pd.read_csv(csv_file, names=['a1','b2','c3'], dtype='float64')
>>> rp
    a1   b2  c3
0  1.0  2.0 NaN
1  2.0  2.0 NaN
2  3.0  2.0 NaN
3  4.0  2.0 NaN
4  5.0  2.0 NaN
>>>


[Question] Update package in marketplace?

Hi, I just realized that extension in marketplace was updated last time almost two years ago.
Last updated | 10/24/2016, 10:57:44 PM
What do you think about updating package?

I dont like this kind of comment, but.... +1 😬
There are two PRs merged on master...
#14 - Case insensitive jumping
#16 - Decorations font and color customization

@wmaurer adding more noise here

@eugeneradionov @joeyfigaro Seems this extension is no longer being maintained, I suggest existing users switch to Jump instead.


Nested arrays break when using custom layout

I'm trying to create a form with a custom layout, but when adding layout options on top of using default data, the nested arrays all become the same length as the final item in the array. For example, if you take the flexbox layout example on the playground using the schema below, you will see that "Jane Doe" gets an extra phone number entry added with a value of "undefined" ("John has three phone numbers"). If you switch the order of the two data entries, "John Smith" will be missing a phone number entry ("Jane" has two phone numbers). However, if you take out the custom layout field, the data populates as you would expect.
Is this a bug, or is there a field or something I am missing?
{   "schema": {     "type": "object",     "properties": {       "people": {           "type": "array",           "items": {               "type": "object",               "properties": {                   "first_name": { "type": "string" },                   "last_name": { "type": "string" },                   "address": {                     "type": "object",                     "properties": {                       "street_1": { "type": "string" },                       "street_2": { "type": "string" }                     }                   },                   "phone_numbers": {                     "type": "array",                     "items": {                       "type": "object",                       "properties": {                         "number": { "type": "string" },                         "type": {                           "type": "string",                           "enum": ["cell", "home", "work"]                         }                       },                       "required": [ "number", "type" ]                     }                   }               }           }       }     }   },   "layout": [     {         "key": "people",         "type": "array",         "items": [             "people[].first_name",              "people[].last_name",             { "key": "people[].address.street_1", "title": "Address", "placeholder": "Street" },             { "key": "people[].address.street_2", "notitle": true },             { "key": "people[].phone_numbers",               "type": "array",               "items": [ {                 "type": "div",                 "displayFlex": true,                 "flex-direction": "row",                 "fxLayoutGap": "12px",                 "items": [                   { "key": "people[].phone_numbers[].type", "flex": "1 1 50px", "notitle": true, "required": true },                   { "key": "people[].phone_numbers[].number", "flex": "4 4 200px", "notitle": true }                 ]               } ]             }                ]     }   ],   "data": {     "people": [         {             "first_name": "Jane",             "last_name": "Doe",             "address": {               "street_1": "123 Main St.",               "street_2": null             },             "phone_numbers": [               { "number": "702-123-4567", "type": "cell" },               { "number": "702-987-6543", "type": "work" }             ]         },         {             "first_name": "John",             "last_name": "Smith",             "address": {               "street_1": "456 South St.",               "street_2": "Apt 3a"             },             "phone_numbers": [               { "number": "703-222-2222", "type": "cell" },               { "number": "703-111-1111", "type": "work" },               { "number": "703-333-3333", "type": "home" }             ]         }       ]   } }

There's definitely a bug in the library.
I thought I'd fixed all the problems with arrays, but when I tried your schema, which looks pretty straightforward, it didn't work right for me either.
I'll look at it more tomorrow, and hopefully upload another fix soon.
Thanks for posting the example—it was very helpful.

Wow, that was a pain to fix—but worth it.
Nested arrays with custom layouts now work as of version 0.5.0-alpha.15.


Svelte example

I've setup a basic working Svelte app based heavily from the html example.

Hey @craigliesinger, we're changing the location of framework-specific examples to https://github.com/IFCjs/examples. Could you make a PR over there with this? :)

Will do Harry; will be next week though as I’m away from a computer till
then.
On Fri, Jul 2, 2021 at 7:21 PM Harry Collin @.***>
wrote:

Hey @craigliesinger https://github.com/craigliesinger, we're changing
the location of framework-specific examples to
https://github.com/IFCjs/examples. Could you make a PR over there with
this? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/IFCjs/web-ifc-viewer/pull/79#issuecomment-873147819,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACT4J4TRN5T6IXH2GHOOBA3TVXYPZANCNFSM47VOIDZA
.

Hey @craigliesinger, we're changing the location of framework-specific examples to https://github.com/IFCjs/examples. Could you make a PR over there with this? :)

I've made a PR at IFCjs/examples.  (my first PR, so please let me know if I screwed something up or need to do anything additional 😄


Don't connect to kext when invoked with CLI args

We try to connect to the kext when the app starts (code). This also happens when the app is launched from the command line (Eg. for deleting/listing registrations). If the app is already running in the background we'll get an error because the kext only allows one connection. This error is surfaced to the user, which is confusing. We should not connect to the kext unless we need to.

A workaround is posted at https://github.com/github/SoftU2F/pull/29#issuecomment-349768392.


[TextField] Shouldn't OutlinedInput have its plain border styling set by theme?

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
The OutlinedInput hardcodes the plain (not selected, not hovered) border to one of two values, depending on if it is light or dark theme.
    theme.palette.mode === 'light' ? 'rgba(0, 0, 0, 0.23)' : 'rgba(255, 255, 255, 0.23)';

Code link.
Shouldn't this be based on standard palette values?
Examples 🌈
No response
Motivation 🔦
Ease of use when using custom themes.

@siriwatknp
What do you think? I think we do this a couple of times in a few components?

I think we do this a couple of times in a few components?

Which components?


feat: Prepare iOS translations mechanism

To translate Info.plist files, we can't use the same mechanism as the Flutter app.
This PR is an example of the french translation, but I don't know how to link it to Crowdin.

Codecov Report

Merging #1557 (2e65240) into develop (6488e44) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1557   +/-   ##
=======================================
  Coverage     8.89%   8.89%
=======================================
  Files          161     161
  Lines         6601    6601
=======================================
  Hits           587     587
  Misses        6014    6014

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6488e44...2e65240. Read the comment docs.

ok to merge @g123k ?

If Crowdin is integrated, then yes!


Footer wraps over front page blog

Hi, great work on the Jekyll theme!  It looks great!
However, I am currently working on a Jekyll site and for some reason when I put the blog preview at the foot of the page the footer wraps itself over the preview, rendering it dysfunctional unless I place an embedded element below it.  You see I would like the embedded Google calendar to be above the blog section; however for some reason this happens when I do just that.  This is an odd issue to explain, so I will send some of the code that I used on the homepage later if you would like to replicate the issue locally.

Thanks,
Leo

Fixed it
To those of you who have this same issue, an easy fix for it is by putting a contained element underneath the blog, such as a <h> or <p> tag or maybe something else such as an embedded element.


ablog deploy fails on windows

Please let me know how to resolve the issue.
Python complains that needs overwrite existing files.

Can you copy screen output here?

I made the following change to make it work. The other option is check for file existence and delete before renaming. Hope this helps.
    for tm in tomove:
        for root, dirnames, filenames in os.walk(website):
            for filename in filenames:
                fn = os.path.join(root, filename)
                fnnew = fn.replace(website, gitdir)
                try:
                    os.renames(fn, fnnew)
                except WindowsError:
                    os.remove(fn)
                    os.renames(fn, fnnew)
                git_add.append(fnnew)
    print('Moved {} files to {}.github.io'
        .format(len(git_add), github_pages))

Yes, that helped.


Resource id for item

Under the heading "Properties of item" there is a mention of "system defined property" called _id
I believe there is no "_id" property. There is a property "_rid" though.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7941d92-a0ea-0f78-12af-7dc8ccb2b1ea
Version Independent ID: d6cc05c7-b724-df22-116f-b8f464293a35
Content: Working with Azure Cosmos DB databases, containers and items
Content Source: articles/cosmos-db/databases-containers-items.md
Service: cosmos-db
GitHub Login: @dharmas-cosmos
Microsoft Alias: dharmas

What's the expected time for the page to update?  It's been almost 5 months since this was closed, but the containers (https://docs.microsoft.com/en-us/azure/cosmos-db/databases-containers-items#azure-cosmos-containers) and items (https://docs.microsoft.com/en-us/azure/cosmos-db/databases-containers-items#azure-cosmos-items) tables both still have _id but not _rid:

I was going to submit _id -> _rid as a suggestion but found this thread.


Set Custom Marker size

Issue description
Hi, Is it possible to set the size of a custom marker? like setIcon(size: {...} ) in regular js...
Steps to reproduce and a minimal demo of the problem
_Use https://plnkr.co or similar -- try this template as a starting point: http://plnkr.co/edit/YX7W20?p=preview
Thanks
What steps should we try in your demo to see the problem?
Current behavior
Expected/desired behavior
angular2 & angular2-google-maps version
Other information

It is same with what I am looking for :(

Dup of #517


docs: Convert README files from AsciiDoc to Markdown

Convert all readme files in the repository from AsciiDoc to Markdown to use the same lanugage for all of them. Markdown was chosen over AsciiDoc because it is the more commonly used format in open source projects and most developers are familiar with it.
While at it, format all of those files to use the one sentence per line approach to minimize the diffs when the files are edited.
The conversion was done by converting the files using asciidoctor and pandoc:
asciidoctor -b docbook5 README.adoc
pandoc -f docbook -t gfm README.xml -o README.md
--base-header-level=2 --wrap=preserve
Afterwards any problems were corrected manually.
Relates to #256.

Relates to #256.

Why only "Relates" and not "Resolves"?

Relates to #256.

Why only "Relates" and not "Resolves"?

The docs folder still contains adoc files. Those files I do not want to just convert but largely rewrite as they are pretty outdated.

While at it, format all of those files to use the one sentence per line approach to minimize the diffs when the files are edited.

One option (that I personally prefer, but opinions of course vary :)) would be to use Prettier for markdown files with a set line width like 80 or 100. That would make all Markdown files consistent, althogh the diffs may not be that good, even though IMO readable enough. It could also be nice to enable Markdownlint.

Since I have contributed a significant part of the documentation, I would have been nice if I had been asked for my opinion as well.

Since I have contributed a significant part of the documentation, it would have been nice if I had been asked for my opinion as well.

@oheger-bosch Sorry if that was against your preference, please add your perspective to #256, I have just added a comment explaining why I prefer Markdown.


allow-scripts fails when installing from tarball

Description
If you use yarn|npm pack to create a tarball of a package then install that file using the file: syntax in package.json, allow-scripts fails with failed to parse canonical name for URL: "file://..."
Steps to reproduce:

run yarn pack in a package repository
move the file into another repository (optional, but easier to get the path)
run yarn add file:./<filename>
run yarn allow-scripts
see the error

Closing in favor of #261, which is a duplicate but contains more discussion


Regex to get coverage results

Hello. I'm  having trouble trying to get a regex to get coverage results from the terminal output. Can you help me with some example?.
Thanks for the wonderful project.

Hi @ithepunisher ,
I am using Gitlab.com CI. The regex is not working for me.

Have you tried removing the forward slashes in the regex in gitlab ? Try ProjectName.*?(\d+(?:\.\d+)?)%. It should work!

Guys are you sure? Im also using gitlab. I use these command for my (xUnit) unit tests:
dotnet test /p:CollectCoverage=true /p:Exclude='[xunit*]*'
This is my full output of the command above:
Microsoft (R) Test Execution Command Line Tool Version 16.0.1
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
Total tests: 7. Passed: 7. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 2.4534 Seconds
Calculating coverage result...
Generating report '/builds/private-projects/prolearnplatform/onlincecps/Applications/server/compilerendpoint/Tests/coverage.json'
+----------------------+-------+--------+--------+
| Module               | Line  | Branch | Method |
+----------------------+-------+--------+--------+
| CompilerEndpoint     | 6.3%  | 18%    | 11.6%  |
+----------------------+-------+--------+--------+
| CompilerEndpointTest | 97.8% | 100%   | 87.5%  |
+----------------------+-------+--------+--------+
+---------+-------+--------+--------+
|         | Line  | Branch | Method |
+---------+-------+--------+--------+
| Total   | 7.9%  | 18%    | 13.9%  |
+---------+-------+--------+--------+
| Average | 3.95% | 9%     | 6.95%  |
+---------+-------+--------+--------+
Job succeeded

can you try with the tips here https://github.com/tonerdo/coverlet/issues/284?
I've open a issue for this problem if you want say something https://github.com/tonerdo/coverlet/issues/542
Feel free to close if solved.

Close for stale.
Feel free to re-open if needed.


Further optimization for mobile

@yura-pakhuchiy what do you think?

@rnevet I like all changes, except Month -> M. It affects all resolutions smaller than 768x..., but not really necessary even on 320x.. screen (it can be displayed without scrolling). However M/W/D/H is harder to understand than Month/Week/etc.
The only resolution it makes sense is 240x... (really small screens), but if you want to support them, then all other fields should be fixed (because they generate vertical scrolling now). If you will do it, I suggest to add separate media query for <320x... devices for this changes.

@rnevet In the first message, I missed that it also makes sense for non-BTC estimated earnings. I propose to apply new format only to non-BTC fields, but leave BTC fields with full form.

BTW, it is easier to review if commit message lists changes in the commit. Especially if there are several in one commit.

@Evanito @Mikadily

@yura-pakhuchiy Please take a look into the last update.
I removed the Month->M change - the resolution change is defined by the bootstrap framework, I don't want to define all the CSS myself.

@rnever I tested it already, looks good to me. Especially I like "add to home screen" feature and new icon. Great work!

@rnevet I tested it already, looks good to me. Especially I like "add to home screen" feature and new icon. Great work!

@rnevet BTW, what do you think about dropping table completely and using bootstrap's "col-xx-y" for formatting?

@yura-pakhuchiy it's a good idea (I also thought about it), just don't have time to do it. If you can go for it.

@rnevet minor glitch with new title bar: in local file mode it displays button over the status line


refactor(blockifier,starknet_api): gas amount is now a u64, not a u128

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1175  👈
#1174
#1173
#1172
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on  Graphite


remove deprecated service graph off demo profile

This is something we discussed for a long time but was not implemented.

cc @duderino @utka if there is another 1.1 build, would like to get this in.  If not, 1.1.1 is fine.

some discussion on slack:
folks, our demo profile still has service graph enabled, should i change that to disabled in favor of kiali?  @costin @Joshua Blatt @sdake and others

Steve Dake [2:32 PM]
i’m going to bed
i’ll be back tomorrow
i’m in no shape to make any decisions
(too tired)
although from my understanding wervice graph is depreciated- try @dougreid

Douglas Reid [3:10 PM]
@linsun yes. servicegraph was deprecated. i don't believe anyone has even tried it with 1.1 (to my knowledge)

/lgtm

I am pretty sure there will be rc4 next week. I jsut created rc3 this morning


"Move to workflow task" bulk op is buggy

It can be implemented in a way that won't leave an inconsistent state:

Reset workflow
Mark all parent nodes as Incomplete
Mark previous nodes in parent serial nodes as completed
Start the selected step as normal

A better name for this would be "Reset to task" instead.

fixed: verified with manual testing


fix tests + fontawesome support

Hi, i added the cdn but maybe you want to host the file yourself ?

Thank you for the PR. I manually did the change in a slightly different way.


Feature Request: loading...

Hi Guys
Vue 2.0 is working well with me. only I have small featrue request, maybe you can think about it.
I use Vue-resoure to pull data from other server, so I offten saw it need to wait the http response, so this led our client misunderstand us that our website is die.  so I think if before we get the response, there have a notice message to show "loading" will better. I know ,I can do this by myself, but I think if this feature in core will better.
Thanks for all your hard work.

This is a completely userland problem - different APIs, different loading requirements... I don't see how we can do this in core.


TypeError: this[#visitors][node.kind] is not a function

Hi Folks 👋
I'm trying to run through the guide on your website, and I'm getting this error when I run npx sst start:
==========================
 Starting Live Lambda Dev
==========================

SST Console: https://console.sst.dev/my-sst-app/colin/local
Debug session started. Listening for requests...

TypeError: this[#visitors][node.kind] is not a function
    at PostgresDataApiQueryCompiler.visitNode (file:///Users/colin/code/my-sst-app/node_modules/kysely/dist/esm/operation-node/operation-node-visitor.js:81:34)
    at PostgresDataApiQueryCompiler.visitTable (file:///Users/colin/code/my-sst-app/node_modules/kysely/dist/esm/query-compiler/default-query-compiler.js:308:14)
    at PostgresDataApiQueryCompiler.visitNode (file:///Users/colin/code/my-sst-app/node_modules/kysely/dist/esm/operation-node/operation-node-visitor.js:81:34)
    at PostgresDataApiQueryCompiler.visitReference (file:///Users/colin/code/my-sst-app/node_modules/kysely/dist/esm/query-compiler/default-query-compiler.js:215:14)

Here's the section of the guide I'm working on:
https://docs.sst.dev/learn/initialize-the-database
As instructed, I'm using Node 14, but I've also tried it at v16 and v18.

Hey :wave:
This issue is due to conflicting versions of kysely existing in the project's node_modules.

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


Option to show only top N number of tags

I have been using pinboard since 2011, so I have 3000+ tags! (4000+ bookmarks)
So, it would be great if I could hide most of these as I do not use them to navigate but rather to search.
On pinboard website it gives the option of viewing:

All
5
10
20
manage

this is mostly managed by the tags sidebar but i think it could have it's own view like the pinboard website, see #393

I think it would also be useful to view tags that have only been used once so I can delete those.
Thanks for this useful app!

Putting into v1. Feels like this is an important mechanism for getting users started with common tags.

Bookmarks on macOS and iOS now supports showing the top 5, 10, 15, and 20 tags in the sidebar.


Captstone-project

Capstone-PR-Website
-I used HTML to build the index.html and about.html page structure.

I used CSS to style and layout all the web pages contained in this capstone.
Using CSS, I styled the required font, color, size, and spacing of the capstone webpage.
I used Flexbox to properly align items on the webpage.
As required by this project, I used javascript to create a dynamic webpage that will display pages directly from javascript files.

Hello Sir,
Thank you for the review. I would be glad if possible to have a Zoom with
you and further explain a few things.
Kindly find attached file my response to your review.
capstone.mp4
https://drive.google.com/file/d/1ex9ZUpN6wNfwWQoFwvJ-znYeNcuPhezp/view?usp=drive_web
thank you
On Fri, May 26, 2023, 7:53 PM Aamir khan @.***> wrote:

@.**** requested changes on this pull request.
Hi @evansnyamekye https://github.com/evansnyamekye ,
https://camo.githubusercontent.com/9394efa3662ade294180d682ebade56334efde7f9b0ffaf2da4786d70e86ee0c/68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f74385950663341434b656f754c7a454976722f67697068792e6769663f6369643d65636630356534376b357561706470746730306e69646277337161787838697167737573676173776369326333756831267269643d67697068792e6769662663743d67
Good job so far!
There are some issues that you still need to work on to go to the next
project but you are almost there!
Highlights
✔ Good Effort
✔ Your design is good.
Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you take them into
account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
On README.md
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207190051
:
https://github.com/evansnyamekye/Capstone-PR/blob/e236ee835fcdf82a4329de58f75e0ab012fd9e4e/README.md?plain=1#L174-L180

The README contains an "Acknowledgements" section or similar that
gives appropriate credit to Cindy Shin
https://www.behance.net/adagio07 the author of the original design
https://www.behance.net/gallery/29845175/CC-Global-Summit-2015, as
required by the Creative Commons License
https://creativecommons.org/licenses/.

On README.md
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207193034
:

Please deploy your website and give the live demo link in the README
file for now you didn't deploy your project kindly deploy your project and
give the live demo link in the README file 🙂

On style.css
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207224861
:

Please stick to the Behance design as much as possible but your
color scheme is not matching with the Behance design 👍

Behance Color Swatch
[image: Screenshot from 2023-05-27 00-11-01]
https://user-images.githubusercontent.com/45226848/241304123-0517e14a-3322-47d2-b125-733829485175.png
In style.css
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207227664
:

+/* .navbar .nav-links  {

color: var(--color-hash);

font-family: 'Lato', sans-serif;

font-size: 17px;

font-weight: 200;
+} */

Please remove all unwanted commented code from your codebase because
its make your codebase messy if you want to check your previous code then
check GitHub commit history 🙂

In js/script.js
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207239676
:

+const navOpen = document.querySelector('.open');
+const mobileNav = document.querySelector('.mobile-nav');
+const closeMenu = document.querySelector('.close');

+navOpen.addEventListener('click', () => {

mobileNav.style.display = 'flex';
document.body.style.overflow = 'hidden';
+});

+closeMenu.addEventListener('click', () => {

mobileNav.style.display = 'none';
document.body.style.overflow = 'auto';
+});

+window.addEventListener('scroll', () => {

const navbar = document.querySelector('.navbar');

if (window.scrollY > 50) {

navbar.style.backgroundcolor = '#fff';

navbar.style.boxShadow = '0 0px 10px 0 #00000033';

} else {

navbar.style.backgroundcolor = 'transparent';

navbar.style.boxShadow = 'none';

}
+});

Please use DRY principles in your project your project is not DRY.
The DRY (don't repeat yourself) principle is a best practice in
software development that recommends software engineers to do something
once, and only once. Check below 👇 my suggestions 🙂

⬇ Suggested change
-const navOpen = document.querySelector('.open');
-const mobileNav = document.querySelector('.mobile-nav');
-const closeMenu = document.querySelector('.close');
-navOpen.addEventListener('click', () => {

mobileNav.style.display = 'flex';
document.body.style.overflow = 'hidden';
-});

-closeMenu.addEventListener('click', () => {

mobileNav.style.display = 'none';
document.body.style.overflow = 'auto';
-});

-window.addEventListener('scroll', () => {

const navbar = document.querySelector('.navbar');
if (window.scrollY > 50) {
navbar.style.backgroundcolor = '#fff';
navbar.style.boxShadow = '0 0px 10px 0 #00000033';
} else {
navbar.style.backgroundcolor = 'transparent';
navbar.style.boxShadow = 'none';
}
-});
+const getElement = (selector) => document.querySelector(selector);

+const mobileNav = getElement('.mobile-nav');
+const navbar = getElement('.navbar');
+const navOpen = getElement('.open');
+const closeMenu = getElement('.close');
+
+const toggleMobileNav = (display, overflow) => {

mobileNav.style.display = display;
document.body.style.overflow = overflow;
+};

+const setNavbarStyles = (backgroundColor, boxShadow) => {

navbar.style.backgroundColor = backgroundColor;
navbar.style.boxShadow = boxShadow;
+};

+navOpen.addEventListener('click', () => {

toggleMobileNav('flex', 'hidden');
+});

+closeMenu.addEventListener('click', () => {

toggleMobileNav('none', 'auto');
+});

+window.addEventListener('scroll', () => {

if (window.scrollY > 50) {
setNavbarStyles('#fff', '0 0px 10px 0 #00000033');
} else {
setNavbarStyles('transparent', 'none');
}
+});

In the modified code:

The getElement function is introduced to simplify the process of
selecting DOM elements by their class names.
The toggleMobileNav function is created to handle the common
behaviour of setting the display and overflow properties of mobileNav
and document.body.
The setNavbarStyles function is introduced to handle setting the
backgroundColor and boxShadow properties of the navbar.
By using these functions, repetitive code is eliminated, and the
code becomes more modular and easier to maintain.
Overall, this refactoring makes the code DRYer by reducing redundancy
and promoting code reuse.

On js/lecturers.js
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207244397
:

As I mentioned above 👆 please use DRY principles your code is not
DRY right now. Check my suggestions below 👇

const lecturersData = [
// lecturer objects...
];
const renderLecturerCard = (lecturer) => {
return

${lecturer.name}

${lecturer.area}

${lecturer.profession}

  ;
};
const showLect = document.querySelector('#tuitornll');
let output = '';
lecturersData.forEach((lecturer) => {
output += renderLecturerCard(lecturer);
});
showLect.innerHTML = output;
const showLecturer = document.querySelector('#tuitornli');
const lecturer = document.querySelector('#tuitornl');
const showMoreBtn = document.createElement('button');
showMoreBtn.className = 'show-more';
showMoreBtn.textContent = 'More';
showMoreBtn.addEventListener('click', () => {
const moreLecturers = lecturersData.slice(2);
showLecturer.innerHTML += moreLecturers.map((lecturer) => renderLecturerCard(lecturer)).join('');
});
showMoreBtn.innerHTML = 'More </>';
lecturer.appendChild(showMoreBtn);
const firstTwoLecturers = lecturersData.slice(0, 2);
firstTwoLecturers.forEach((lecturer) => {
showLecturer.innerHTML += renderLecturerCard(lecturer);
});
In the refactored code, the renderLecturerCard function is introduced to
generate the HTML markup for a lecturer card. The function takes a lecturer
object as an argument and returns the corresponding HTML markup. By using
this function, the code is made DRY, as the rendering logic is encapsulated
in a single place and reused wherever needed.
This refactoring improves code readability, and maintainability, and
reduces redundancy by adhering to the DRY principle.
In js/lecturers.js
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207249760
:

${lecturer.name}

${lecturer.area}

${lecturer.profession}

Please stick to the Behance design as much as possible if you see
your text it's not the same as the Behance design you use text-align:
center but in Behance design the text alignment is not center so
kindly fix this issue as well 👍 check below 👇 the comparison between
your design and Behance design 🙂

Your Design
[image: Screenshot from 2023-05-27 00-01-34]
https://user-images.githubusercontent.com/45226848/241308178-ec1b5367-8799-42e1-9e6b-88c22a86cedc.png
Behance Design
[image: Screenshot from 2023-05-27 00-01-11]
https://user-images.githubusercontent.com/45226848/241308130-6e1cd150-1d96-45d7-8887-f6ddccd1fe41.png
In index.html
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207257050
:

software D.

Get the opportunities to network with CC affiliates around the world, also after

                   the

                   summit.

Machine L

Get the opportunities to network with CC affiliates around the world, also after

                   the

                   summit.

As I mentioned above 👆 please stick to the Behance design as much
as possible but in the mobile version your Course Category is not the
same as Behance design 👍 check below 👇 comparison between your
design and Behance Design 🙂

Your Design
[image: Screenshot from 2023-05-27 00-03-29]
https://user-images.githubusercontent.com/45226848/241309310-f9b040a0-3242-47a4-840c-0236868f767d.png
Behance Design
[image: Screenshot from 2023-05-27 00-03-49]
https://user-images.githubusercontent.com/45226848/241309400-f7290f4d-49cf-48f3-b813-164e08969592.png

If you check your design there are some spacing and margins problems
kindly fix these issues as well 👍

In about.html
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207260473
:

2015 Creative Commons Korea. Some Rights Reserved.

달리 정하지 않은 웹사이트의 모든 내용은 크리에이티브 커먼즈 저작자표시 2.0 대한민국 라이선스에 따라 이용할 수 있습니다.

As I mentioned above ☝ please stick to the Behance design your
footer in the mobile version is not the same as the Behance design 👍
check below 👇 the comparison between your design and Behance design 🙂

Your Design
[image: Screenshot from 2023-05-27 00-05-31]
https://user-images.githubusercontent.com/45226848/241311335-1e51556f-9860-401b-90ef-8e41f8fe5b8b.png
Behance Design
[image: Screenshot from 2023-05-27 00-05-43]
https://user-images.githubusercontent.com/45226848/241311441-b2c609e3-ea9f-4851-8675-7f9889dc70f6.png
In index.html
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207264714
:

Welcome! to Evans code online school

GROW YOUR CODING SKILLS TO ADVANCE YOUR CAREER PATH

Our aim to help you a establish a good fundation in software development. The journey

                   of becoming a developer can not just be achieved by feeling good behind a complter. We make sure

                   you gain much understanding of every basic lesson in coding.

Starting 05.06.23(Mon) ~ (Fri)

@ 8am Opo-louker street, West Hills-Weija. Ghana

Please remove unwanted comments from your codebase because it's your
codebase make messy if you want to check your previous code then check your
commit GitHub History 👍
As I mentioned above ☝ please stick to the Behance design your hero
section in the mobile version is not the same as the Behance design 👍
check below 👇 the comparison between your design and Behance design 🙂

Your Design
[image: Screenshot from 2023-05-27 00-06-26]
https://user-images.githubusercontent.com/45226848/241312966-fa874f02-d0f7-4603-8b7d-792deb7345ba.png
Behance Design
[image: Screenshot from 2023-05-27 00-06-11]
https://user-images.githubusercontent.com/45226848/241313023-67d1d2cb-643a-41ed-9267-2267b8366807.png
In about.html
https://github.com/evansnyamekye/Capstone-PR/pull/1#discussion_r1207266981
:

Welcome! to Evans code online school

GROW YOUR CODING SKILLS TO
ADVANCE YOUR CAREER PATH

Our aim to help you a establish a good fundation in software development. The journey

                   of becoming a developer can not just be achieved by feeling good behind a complter. We make sure

                   you gain much understanding of every basic lesson in coding.

                   Our aim to help you a establish a good fundation in software development. The journey

                   of becoming a developer can not just be achieved by feeling good behind a complter. We make sure

                   you gain much understanding of every basic lesson in coding.

Starting 05.06.23(MON) ~ (FRI)

@ 8am Opo-louker street, West Hills-Weija. Ghana
PGS Address-GS-83E4-XXX

Please contact us per Email for nay further questions about CC Global Summit

                   2015!

                   Explore BootCamp Now!

Please remove unwanted comments from your codebase because it's your
codebase make messy if you want to check your previous code then check your
commit GitHub History
As I mentioned above ☝ please stick to the Behance design your hero
section in the mobile version is not the same as the Behance design 👍
check below 👇 the comparison between your design and Behance design 🙂

Your Design
[image: Screenshot from 2023-05-27 00-07-00]
https://user-images.githubusercontent.com/45226848/241313649-f4e7a9d0-98db-4014-81b8-7bcbb8890043.png
Behance Design
[image: Screenshot from 2023-05-27 00-06-46]
https://user-images.githubusercontent.com/45226848/241313712-952fc257-f835-4edc-a202-a641c2fd711a.png
—
Reply to this email directly, view it on GitHub
https://github.com/evansnyamekye/Capstone-PR/pull/1#pullrequestreview-1446767920,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AORFTGK7EHL5JHRAMBDAR7DXIEC2XANCNFSM6AAAAAAYO6BFMA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@aamirkhan2478
Hello Sir,
Thank you for the review. I would be glad if possible to have a Zoom with
you and further explain a few things.
Kindly find attached file my response to your review.
capstone.mp4
https://drive.google.com/file/d/1ex9ZUpN6wNfwWQoFwvJ-znYeNcuPhezp/view?usp=drive_web
thank you
…


LiveShare: Entering a new cell clears the other users input box

Guest: Type some code into the input box, don't submit it yet
Host: Submit a new cell
Guest: New cell appears and the code that was being types in the input box is totally cleared.

I think we can punt this one unless customers actually complain about it.


Build an SAP Fiori UX app with SAP Gateway data

https://www.sap.com/developer/tutorials/gateway-demo-signup.html
Step 17: Launch your app:
Get timeout popup:
Sorry, a technical error occurred! Please try again later.
{
"message": "HTTP request failed",
"headers": [],
"statusCode": 504,
"statusText": "Gateway Timeout",
"responseText": "HTTP Status 504 - Socket connection timed out for host https://sapes5.sapdevcenter.com. Reason: Read timed out (local port 42209 to address <IP_ADDRESS> (vsa4345868.nwtrial.od.sap.biz), remote port 8080 to address <IP_ADDRESS> (sgw-a1s-03-int.od.sap.biz))"
}
fiori app.docx

It's all good, I just had to enter a text in the search criteria to start a search, otherwise it time outs.


Failed to load external entity

Hi i hope you are doing good
i am trying to implement mpd to to but every time i run this command
xsltproc --stringparam run_id "segment" /var/www/html/file_conversion/out_heli/mpd_hls/mpd-to-m3u8.xsl /var/www/html/file_conversion/out_heli/output_heli_dash.mpd > /var/www/html/file_conversion/out_heli/hls_playlist/playlist.m3u8
command line says
failed to load external entity
any solution to this i'd be very great-full for your help regarding this
Thanks have a good day

i am using ubuntu 16.10

i am done with executing file but it says document is not a style sheet

I'm sorry, never got any notifications for this issue. Are you still having this problem? Do you have an example mpd file you could provide?


About rancher cli login

What kind of request is this (question/bug/enhancement/feature request):
bug?
Steps to reproduce (least amount of steps as possible):

I run in node by following the commands:

rancher login https://myip:v3 -t token:secret
return

FATA[0002] Bad response statusCode [401]. Status [401 Unauthorized]. Body: [message=clusterID does not match] from [https://my_ip/v3]

But if I set this (look at pic)

It was successful
Do you want to continue connecting (yes/no)? yes
NUMBER    CLUSTER NAME   PROJECT ID        PROJECT NAME   PROJECT DESCRIPTION
1         test2          c-7xqz2:p-2c279   System         System project created for the cluster
2         test2          c-7xqz2:p-vgb5t   Default        Default project created for the cluster
3         test1          c-cplvw:p-gjx7h   Default        Default project created for the cluster
4         test1          c-cplvw:p-rvhnl   System         System project created for the cluster
5         mycluster      c-lmvsp:p-49h7g   Default        Default project created for the cluster
6         mycluster      c-lmvsp:p-gc7hp   System         System project created for the cluster
Select a Project:4
INFO[0009] Saving config to /home/xieyt/.rancher/cli2.json
root@debian106:~$ rancher nodes
ID                       NAME        STATE     POOL      DESCRIPTION
c-cplvw:m-414529b01416   debian106   active

I dont know how to fix it.
Does anyone has the same problem when use rancher cli?
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):

v2.3.2

Installation option (single install/HA):

single install

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):

Custom

Machine type (cloud/VM/metal) and specifications (CPU/memory):

VM

Kubernetes version (use kubectl version):

v1.16.2

Docker version (use docker version):

19.03.5

Sounds the same as https://github.com/rancher/rancher/issues/18639


Vet clinic database: create animals table

Hello, In this branch I: Use a relational database to create the initial data structure for a vet clinic. create a table to store animals' information, insert and query some data.

[x] Create a database named vet_clinic.

[x] Create a table named animals with the following columns:

[x] id: integer
[x] name: string
[x] date_of_birth: date
[x] escape_attempts: integer
[x] neutered: boolean
[x] weight_kg: decimal

[x] Copy the SQL you used in the previous point into the schema.sql file in the generated repository.

[x] Insert the following data:

[x] Animal: His name is Agumon. He was born on Feb 3rd, 2020, and currently weighs 10.23kg. He was neutered and he has never tried to escape.

[x] Animal: Her name is Gabumon. She was born on Nov 15th, 2018, and weighs 8kg. She is neutered and she has tried to escape 2 times.

[x] Animal: His name is Pikachu. He was born on Jan 7th, 2021, and currently weighs 15.04kg. He was not neutered and he has tried to escape once.

[x] Animal: Her name is Devimon. She was born on May 12th, 2017, and weighs 11kg. She is neutered and she has tried to escape 5 times.

[x] Copy the SQL you used in the previous point into the data.sql file in the generated repository.

[x] Write queries for the following quests:

[x] Find all animals whose name ends in "mon".
[x] List the name of all animals born between 2016 and 2019.
[x] List the name of all animals that are neutered and have less than 3 escape attempts.
[x] List the date of birth of all animals named either "Agumon" or "Pikachu".
[x] List name and escape attempts of animals that weigh more than 10.5kg
[x] Find all animals that are neutered.
[x] Find all animals not named Gabumon.
[x] Find all animals with a weight between 10.4kg and 17.3kg (including the animals with weights that equals precisely 10.4kg or 17.3kg)

These are the query results:

Thanks for your professional review 👍🏼