Custom InputFn to HumanService and ServiceAsTool

Add ability to pass in a custom callable instead of default input function to HumanService
This should help with multi-turns with the Agent (I think). The dev is responsible for routing the HumanService to the correct UI/UX via a custom input function
Also, changed to ConfigDict instead of class Config for BaseModel as class Config is deprecated in v2 and will be removed in v3 pydantic
Refactors AgentServiceTool to more generic ServiceAsTool that can be used for any Service
Add ability to handle NEW_TOOL_CALL action types in HumanService
Add example script for using HumanService as a Tool

llama-agents-1JOcReMO-py3.10 ❯ python examples/pipeline_human_service_as_tool_local_single.py
INFO:llama_agents.message_queues.simple - Consumer HumanService-1b033f80-1d2d-4c9d-8799-11dc1e12f62f: default_human_service has been registered.
INFO:llama_agents.message_queues.simple - Consumer AgentService-d4a1391c-4e45-4e23-9bbc-5e5683a1293f: funny_agent has been registered.
INFO:llama_agents.message_queues.simple - Consumer 8844d3c5-3808-4c1c-aed4-8974dd232cd7: human has been registered.
INFO:llama_agents.message_queues.simple - Consumer ControlPlaneServer-0c1b45e9-f36c-4e4e-9657-9021ccc7ed11: control_plane has been registered.
INFO:llama_agents.services.human - default_human_service launch_local
INFO:llama_agents.services.agent - funny_agent launch_local
INFO:llama_agents.message_queues.base - Publishing message to 'control_plane' with action 'new_task'
INFO:llama_agents.message_queues.simple - Launching message queue locally
INFO:llama_agents.message_queues.base - Publishing message to 'funny_agent' with action 'new_task'
INFO:llama_agents.message_queues.simple - Successfully published message 'control_plane' to consumer.
INFO:llama_agents.services.agent - Created new task: 495bc2f0-f4e1-49f9-b42a-720360e84f7c
INFO:llama_agents.message_queues.simple - Successfully published message 'funny_agent' to consumer.
INFO:llama_agents.message_queues.simple - Consumer ServiceAsTool-45f83cd9-77b2-4dc4-a8e1-73c144d63a1c: ServiceAsTool-45f83cd9-77b2-4dc4-a8e1-73c144d63a1c has been registered.
INFO:llama_agents.message_queues.base - Publishing message to 'default_human_service' with action 'new_tool_call'
INFO:llama_agents.services.human - Created new tool call as task: 36772bad-58a1-4a20-8aba-3bed32161a5b
INFO:llama_agents.message_queues.simple - Successfully published message 'default_human_service' to consumer.
INFO:llama_agents.services.human - Processing request for human help for task: 36772bad-58a1-4a20-8aba-3bed32161a5b
Your assistance is needed. Please respond to the request provided below:
===

1+1+2+3+5+8

===
20
INFO:llama_agents.message_queues.base - Publishing message to 'ServiceAsTool-45f83cd9-77b2-4dc4-a8e1-73c144d63a1c' with action 'completed_tool_call'
INFO:llama_agents.message_queues.simple - Successfully published message 'ServiceAsTool-45f83cd9-77b2-4dc4-a8e1-73c144d63a1c' to consumer.
INFO:llama_agents.message_queues.base - Publishing message to 'control_plane' with action 'completed_task'
INFO:llama_agents.message_queues.base - Publishing message to 'human' with action 'completed_task'
INFO:llama_agents.message_queues.simple - Successfully published message 'control_plane' to consumer.
INFO:llama_agents.message_queues.simple - Successfully published message 'human' to consumer.
Result: The sum of 1+1+2+3+5+8 is 20.

And here's a joke for you:

Why don't scientists trust atoms?

Because they make up everything!

This honestly looks pretty good, great work!

Thank you sir 🫡🙏


libgit2-glib: 0.27.8 -> <IP_ADDRESS>

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libgit2-glib/versions.
meta.description for libgit2-glib is: '"A glib wrapper library around the libgit2 git access library"'.

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found <IP_ADDRESS> with grep in /nix/store/1i5vrbr0z69p7h4sgq1w16glg3j5k0sa-libgit2-glib-<IP_ADDRESS>
directory tree listing: https://gist.github.com/7f2f03b9b4f5e169dde3d0de93065731
du listing: https://gist.github.com/dc4ffae0dac3d6100c54d7e3539c57a6

Rebuild report (if merged into master) (click to expand)

22 total rebuild path(s)
7 package rebuild(s)
7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
gitg
gnome-builder
gnome3.gitg
gnome3.libgit2-glib
haskellPackages.gi-ggit
libgit2-glib
pantheon.elementary-code

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1i5vrbr0z69p7h4sgq1w16glg3j5k0sa-libgit2-glib-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A libgit2-glib https://github.com/r-ryantm/nixpkgs/archive/fffeb5239c64c7d0891dd84c3698574c42a7b077.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1i5vrbr0z69p7h4sgq1w16glg3j5k0sa-libgit2-glib-<IP_ADDRESS>
ls -la /nix/store/1i5vrbr0z69p7h4sgq1w16glg3j5k0sa-libgit2-glib-<IP_ADDRESS>/bin

cc @lethalman @jtojnar @hedning @worldofpeace for testing.

Changes: https://gitlab.gnome.org/GNOME/libgit2-glib/blob/60c461a7be3f63693dd1126303a0175c4af2ad1b/NEWS#L1-9

@GrahamcOfBorg build gitg


Remove malformed jar/class deprecation

Whether malformed files are valid for a task
is not Gradle's business. Gradle can always
fall back to a more primitive hashing strategy.
The warning is now put into the debug log to
help with the unlikely case of an investigation
into broken JARs causing performance issues.

An alternative would be to warn a bit louder (at warn level), but only show the stacktrace if --stacktrace is enabled. What do you think @melix?


Fix list enumeration

PR Summary
Fixes list enumeration and removal.
PR Context
A collection shall not be modified during enumeration.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.
Breaking changes

[x] None

User-facing changes

[x] Not Applicable

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.

If there's a scenario you know was previously broken, it might be a good idea to add a test to ensure that scenario is completely fixed with this change and does not regress later on.

It makes sense to cover these code paths. The tests will require a custom service, which refuses to accept the stop command during testing but accepts it when uninstalled...
I don't want to tackle that at this moment. :(

That does sound rather complicated, indeed.
The fix seems logically sound, though, so unless there's a more straightforward route to testing it, that might have to come later. 🙂

@NextTurn Please recover PR template to original and add a reference to an issue with a discussion.

Please recover PR template to original and add a reference to an issue with a discussion.

Opened #11858

@TravisEz13 @daxian-dbw The PR is ready to merge.

@NextTurn Thank you for your contribution!


[FEATURE REQUEST] Volume button to adjust volume

After "All Of The Above" there can be a cursor which says Volume and if the user moves the line the volume adjusts. I think this is possible with basic JS but idk how to implement this so would need some help from yall @aliraza944 @TechStudent11

Not sure if this is possible using the YouTube API. I'll look into it.

Yeah, I think this would be a good touch if its possible.

@TechStudent11 Did you find anything useful?

Yep it's possible. I'll get working on it later today.

Ok cool. Thanks a lot!
On Mon, 17 Jan 2022 at 17:47, TechStudent10 @.***>
wrote:

Yep it's possible. I'll get working on it later today.
[image: image]
https://user-images.githubusercontent.com/76978184/149768088-622a9bd3-e693-4b6e-a852-57d33212b0be.png
—
Reply to this email directly, view it on GitHub
https://github.com/KendallDoesCoding/mogul-christmas/issues/105#issuecomment-1014459746,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGJUTIJVI6WCQZNIPMHAD3UWQCEPANCNFSM5LZIUDCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

I just need to make a slider.. the problem is that I don't know how

I just need to make a slider.. the problem is that I don't know how

You can use the template from this codepen: https://codepen.io/emilcarlsson/pen/PPNLPy

I'm planning to add a section in the README.md or on the website to give credits to all the people that helped make things in this project, so if you use this please let me know though @TechStudent11 .

I just need to make a slider.. the problem is that I don't know how

You can use the template from this codepen: https://codepen.io/emilcarlsson/pen/PPNLPy

I'm planning to add a section in the README.md or on the website to give credits to all the people that helped make things in this project, or tools/code taken from the internet and used in the project creators, etc. So if you use this please let me know though @TechStudent11 .

Thanks. I'll probably use it.

I just need to make a slider.. the problem is that I don't know how

You can use the template from this codepen: https://codepen.io/emilcarlsson/pen/PPNLPy

I'm planning to add a section in the README.md or on the website to give credits to all the people that helped make things in this project, or tools/code taken from the internet and used in the project creators, etc. So if you use this please let me know though @TechStudent11 .

Thanks. I'll probably use it.

Welcome :)

@aliraza944 You know how to do this?

You can take references from this article https://www.w3schools.com/tags/av_prop_volume.asp. Just get the DOM node of the video tag and assign value to its volume property.

You can take references from this article https://www.w3schools.com/tags/av_prop_volume.asp. Just get the DOM node of the video tag and assign value to its volume property.

Thanks, will have a look at this shortly. If, I'm not understanding how to do it, I may need your help or @TechStudent11 's help when yall are free coz I wanted to add in the project from a long time coz rn you cant mute/stop the song, with this I can also try to add a stop button, that if tapped, the volume automatically goes onto mute, or something like that.

Alright no problem

Can I work on this?

Can I work on this?

Assigning you as per our discussion on DISCORD

Can I work on this?

Okay I guess. I'm not good at creating video players.
If you want a custom video player, I'm right here.

Yeah... You can help Krish if needed while he works on this. :)

There is kinda a way to pause the song, is your using Chrome. Will inculde that in README.md, shortly.

There is kinda a way to pause the song, is your using Chrome. Will inculde that in README.md, shortly.

But, I still prefer it built in to the site.

Can I work on this?

Okay I guess. I'm not good at creating video players.
If you want a custom video player, I'm right here.

@TechStudent11 If you want to work on this I have no issues, I will work on some other issue :)

I can only do volume buttons 😈

I mean, you can start will the buttons, and then Krish works on the slider?
Make a PR if you get free @TechStudent10
On Sat, 19 Feb 2022 at 02:32, TechStudent10 @.***>
wrote:

I can only do volume buttons 😈
—
Reply to this email directly, view it on GitHub
https://github.com/KendallDoesCoding/mogul-christmas/issues/105#issuecomment-1045185117,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGJUTKT4SYVHEQ6EOBM67LU32XUTANCNFSM5LZIUDCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were assigned.Message ID:
@.***>

I was trying to work on the volume slider and look what copilot gave me LOL. For the rest, idrk if we should add that xD, but for the volume slider that works just maybe make it a little small @krshdev ?

please make it smaller, make the buttons not look like their from 1997 and yeah you've got good volume control

please make it smaller, make the buttons not look like they're from 1997 and yeah you've got good volume control

Well, that's just what copilot gave, I don't plan on working on this issue, has I don't know the JS part of things and copilot doesn't help me with that for some reason. With the slider, the songs were unplayable, but just shared the design here for @krshdev to work on a similar design.

Unassigned based on discussion in Discord

I mean, you can start will the buttons, and then Krish works on the slider? Make a PR if you get free @TechStudent10
…
On Sat, 19 Feb 2022 at 02:32, TechStudent10 @.> wrote: I can only do volume buttons 😈 — Reply to this email directly, view it on GitHub <#105 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUGJUTKT4SYVHEQ6EOBM67LU32XUTANCNFSM5LZIUDCQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were assigned.Message ID: @.>

@TechStudent11 Please work on this when your done with the other PR if you got time :).
Thanks,
Kendall Does Coding

Unassigned based on discussion in Discord

so @krshdev based on your discussion (of which I didn't read), are you working on something in this repo?

No... He isn't, @sc0rp10n.py, is!
On Sun, 20 Feb 2022 at 19:58, TechStudent10 @.***>
wrote:

Unassigned based on discussion in Discord
so @krshdev https://github.com/krshdev based on your discussion (of
which I didn't read), are you working on something in this repo?
—
Reply to this email directly, view it on GitHub
https://github.com/KendallDoesCoding/mogul-christmas/issues/105#issuecomment-1046249755,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGJUTIYGZP35CCLTF5LCYTU4D27JANCNFSM5LZIUDCQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were assigned.Message ID:
@.***>

@aliraza944 Can you please work on this complete issue, when you get time?
@TechStudent11 As requested, can you work on the 2 icons, mute/unmute when your done with the other PR/when you get time?

@TechStudent11 As requested, can you work on the 2 icons, mute/unmute when your done with the other PR/when you get time?

@TechStudent11 Any progress on this?

@TechStudent10 Please let me know at the earliest.

@TechStudent11 As requested, can you work on the 2 icons, mute/unmute when your done with the other PR/when you get time?

@TechStudent11 Any progress on this?

@TechStudent10 Please let me know at the earliest.

Kinda forgot about this project tbh lol. I can't rn because most of my projects are on a faulty drive :/

@TechStudent11 As requested, can you work on the 2 icons, mute/unmute when your done with the other PR/when you get time?

@TechStudent11 Any progress on this?

@TechStudent10 Please let me know at the earliest.

Kinda forgot about this project tbh lol. I can't rn because most of my projects are on a faulty drive :/

Lol, yeah it's been a while since I myself have worked on this... Oof, No worries, please let me know when you can work on it!!

@CipherKill any idea how this can be done?

hey @KendallDoesCoding I wanna participate in the hacktoberfest, can you make changes to PRs and add tags to whitelist this repo for contributions?

For reference

YOUR PR/MRS MUST BE IN A REPO TAGGED WITH THE “HACKTOBERFEST” TOPIC, OR HAVE THE “HACKTOBERFEST-ACCEPTED” LABEL.
https://hacktoberfest.com/participation/

hey @KendallDoesCoding I wanna participate in the hacktoberfest, can you make changes to PRs and add tags to whitelist this repo for contributions?

Hi, I'm sorry, I can't do that.. Please create a issue and if I accept it, can work on a PR for it. I don't want spam contributions/things I do not want in the website.
I can make the repo topic hacktoberfest though.
Will this work?

its one and the same thing i guess.

its one and the same thing i guess.

Ok, so I should just add a topic "hacktoberfest" right?

yes

@sharmavivek223 Done, in future, please do not merge a query with a issue, you should create a discussion :)

ok, will do in a bit.
Thanks,
Kendall Does Coding
Portfolio
https://sgnldrp.live/click?redirect=https%3A%2F%2Fkendalldoescoding.gq&dID=1665221803282&linkName=Portfolio
Github
https://sgnldrp.live/click?redirect=https%3A%2F%2Fgithub.com%2FKendallDoesCoding&dID=1665221803282&linkName=Github
Youtube
https://sgnldrp.live/click?redirect=https%3A%2F%2Fkendalldoescoding.gq%2FcodingYT&dID=1665221803282&linkName=Youtube
On Sat, 8 Oct 2022 at 14:48, Vivek Sharma @.***> wrote:

yes
—
Reply to this email directly, view it on GitHub
https://github.com/KendallDoesCoding/mogul-christmas/issues/105#issuecomment-1272274875,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUGJUTMPWZEYW2CLQ76DUCLWCE347ANCNFSM5LZIUDCQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@sharmavivek223 Can you work on this?

I guess this is unnecessary.. If the user wants to make the volume softer, they can just use their device.

thanks i'll start working once #340 is merged since it is dependent @KendallDoesCoding

thanks i'll start working once #340 is merged since it is dependent @KendallDoesCoding

Ok

@sharmavivek223 Hi. I just merged #340. Please let me know when you can get to work on this.

Hey @KendallDoesCoding, I will try my best to do this over the weekend, running busy recently.

Hi @sharmavivek223 . Thanks.. No worries.


fix(server): object Runtime not available before function run

It is possible to define a function that uses the Runtime prior to handler execution:
const hello = require(Runtime.getFunctions()['hello'].path);

exports.handler = function(context, event, callback) {
    hello.handler(context, event, () => {
        console.log('ran');
        callback(null, {});
    });
};

The above code will work when deployed to Twilio, but not when hosted via twilio-run.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

Thanks for the contribution! Great job


Allow for slashes in soundboard url argument

It didn't quite work with <base href="/" />, so we're having our future selves deal with it.

As per https://xkcd.com/1421/

Cheesed it in 22cb2adb0d7f19b6eb7e486e927497ef465ed289.

This could be easily solved if the config files were not in version control. We can have client.default.yml & server.default.yml in git, and client.yml & server.yml out of it. Then we can just add a baseUrl option to server.yml and set the <base> tag from that.

Current solution as of https://github.com/team-thyme/soundboard-front-end/commit/6b1523800cbc7274bddfcf7a843504a524bc9687#diff-528c3923d718a8860f5d8c05c3931c55R7 is to have a base tag that needs to be manually changed if a subdirectory is used. I know no better way of doing this at this time.

@villermen I think this is solved with the BASE_URL env variable these days, right?

Right you are! This was already fixed in #138.


Fix SQLite dep warning test failures

Fix SQLite dep warning test failures
http://edgeguides.rubyonrails.org/configuring.html#configuring-active-record
Fixes https://github.com/rails/sass-rails/issues/409

@schneems I pushed a new commit here but it has not been added to this PR as usually happens. Is this a repo setting?

It looks like it was a GitHub issue. https://status.github.com/messages

October 17, 2017
12:54 EDT
We continue to monitor recovery of the queue backlog.
12:12 EDT
The queue backlog is now recovering. Notifications will be slow until the queues are fully recovered.
12:00 EDT
We continue to investigate queue backlogs. Webhook deliveries are delayed and commits may take longer than usual to appear in pull requests.
11:27 EDT
We continue to investigate a large queue backlog. Commits will take longer than usual to appear in pull requests.


PrimaryKey field name change bug

Bug Report
🔎 Search Terms
sqb id fieldName change error, primary key
🕗 Version & Regression Information
"@sqb/builder": "^4.0.1-alpha.18",
"@sqb/connect": "^4.0.1-alpha.18",
"@sqb/nestjs": "^4.0.1-alpha.18",
"@sqb/oracle": "^4.0.1-alpha.18",
"@sqb/oracle-dialect": "^4.0.1-alpha.18",
"@sqb/postgres": "^4.0.1-alpha.18",
"@sqb/postgres-dialect": "^4.0.1-alpha.18",
💻 Code
    @PrimaryKey()
    @Column({fieldName:'pk', update: false, insert: false})
    @AutoGenerated('increment')
    id: number = 0;

🙁 Actual behavior
Doesn't change the id field
update patients set given_name = $1, family_name = $2 where id = $3

🙂 Expected behavior
update patients set given_name = $1, family_name = $2 where pk = $3

Resolved in Alpha.19


Added new util class AlignedBuffer

use class AlignedBuffer from cereal/messaging.hpp : https://github.com/commaai/cereal/pull/125

Merged cereal PR and bumped submodule

Done


Fast question!!! videobrain desktop app and lcdw files

Hi guys, after read all issues some times, I have not clear how can use correctly decryptor in win 10.  The batch exit but it does not decrypt any files. Anyone can help to me, pls

use the win7 viewer (saves .lynda) instead of the win8 viewer(saves .lcdw)

Should be working on Win10 once PR merged: #42


If you ask the service to send too many notifications in a quick succession it sends infinite notifications

Pretty sure this is not my code doing this.
If you ask the service to send like 50 notifications in quick succession it repeatedly sends the same batch of notifications forever.
I have seen this happen twice now.

This is deployed to AWS on a fairly constrained server.
My send is within a router callback for PerfectHTTPServer, there is no loop in my code and I am logging when the callback happens, it only happens once. So unless Apple are doing this it does seem to be within PerfectNotifications or one of its dependencies.

However notably the callback is called like 50 times in rapid succession. separate instantiations on different threads. Possibly a concurrency violation?

Thank you for opening the issue. I just wanted to let you know that I'm digging into this one today and will report back ASAP.

The recent commit fixes this, though an awful lot of notifications seem to get dropped instead, with a lot of internalServerError errors and ~HTTP2Client.startReadThread messages.
So thanks, I'll look into whether or not I can help fix that.

Actually maybe not 100% fixed, looking at my notifications log some were doubled up. But it does stop now at least rather than sending them until I kill the server.

Yeah ok, this seems to possibly the issue, I put a print counter into the code when HTTP2 streams are created and when I use my test case I get up to 66 open connections to APNs.
A google suggests 15 is the undocumented limit per IP that Apple allow before they start closing the connections.
Also my reading suggests that we are preemptively creating new streams, Apple say you should be able to do 9000 payload writes per second to one connection, I'm just trying to write 66 here within a few seconds.
Anyway, if there's any feedback I can take it into account as I attempt to fix this. Thanks.


Fix compilation issues

I tried to fix a few compilation issues but I make several wild guess about appropriate fixes. So feel free to reject it if not useful.

Fixed in 2d26994


ISPN-10631 infinispan-feature-pack is using wrong parent path

https://issues.jboss.org/browse/ISPN-10631

integrated! Thanks @diegolovison !


Unable to enter parameters

Unable to enter parameters
Unable to enter parameters

I have added it but I need a little change to show validation errors in UI. If there are error no build is triggerd but shows as succesful

Can you please check Following EAP: https://plugins.jetbrains.com/plugin/6110-jenkins-control/versions/eap/261695

It is available, thank you very much for your support!

released with 0.13.16


Need a setting for preferred theme as per time of day

As of right now, there seems to be only one global theme in the previewer preferences. But it would be greatly appreciated if there would be two theme options - one for dark and another for light- so it changes with time of the day for users who have set their macOS theme to be automatic, which switches from light to dark with reference to time.
Without it, the system looks inconsistent with certain files opening in light theme (how macOS handles the previews) and others (code) always opening with a dark theme.
Other than this, I'd just like to thank for the wonderful app that's open-source and on the app-store. Takes the pain away of inability of installing un-notarized apps or dealing with privacy policy of similar proprietary apps.

I’m actively researching how to implement this. I’m hoping to add it in a future release.


Bitswap tests flaking on develop

https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/297#0189916d-165a-4abd-a03c-99dec53322f5
Disabling the tests for now as these are flaking on develop and not on berkeley

Stub issue with dead link. Closing.


Add global_property_object extension

Change Description
This PR

adds extension to snapshot_global_property_object
adds pending_security_group to global_property_object
provides custom unpack_object_visitor<snapshot_global_property_object> for snapshot_global_property_object deserialization.
adds tests to verify the unpacking of snapshot_global_property_object works from older snapshot version

Change Type
Select ONE:

[ ] Documentation

[ ] Stability bug fix

[ ] Other

[ ] Other - special case

Testing Changes
Select ANY that apply:

[ ] New Tests

[ ] Existing Tests

[ ] Test Framework

[ ] CI System

[ ] Other

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

superseded  by PR #10116.


Set kIsList to true if CLAP_PARAM_IS_STEPPED

Closes #89

@defiantnerd wanted to go a different route here it seems so let me close this. It will still link to the above issue in case this is the path we take.


chore(changelog): fix empty entry issue

fix https://github.com/otto-ec/ottoapi_orga/issues/81

@HeikoKampe You might want to take a look at the failing tests 👀?

@HeikoKampe You might want to take a look at the failing tests eyes?

Of course! Tests are updated due to the fix.


Out-of-Bound Memory Read inside "block_type_get_arity" Function

Subject of the issue
Running the CLI iwasm with the given testcase results in segmentation fault, which is caused by out-of-bound memory read.
Test case
iwasm-poc-02.zip
Your environment
OS               : Linux <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Thu Jan 11 04:09:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Commit           : 7bdea3c2ae1f23683299c008bd5093ccaeb5f7b1
Version          : 2.0.0
Clang Verison    : 13.0.0
Affected Tool    : iwasm
Enabled Features : None

Steps to reproduce
Build            : cd product-mini/platforms/linux/ && mkdir -p build && cd build && export CC="clang" CXX="clang++" CFLAGS="-fsanitize=address -g" CXXFLAGS="-fsanitize=address -g" && cmake .. && make -j
Command          : iwasm -f main iwasm-poc-02

Expected behavior
The program should exit gracefully with possibly some error information.
Actual behavior
Here is the stack trace provided by AddressSanitizer:
AddressSanitizer:DEADLYSIGNAL
=================================================================
==13987==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000002 (pc 0x56315c449fbc bp 0x7ffcf1e77630 sp 0x7ffcf1e77100 T0)
==13987==The signal is caused by a READ memory access.
==13987==Hint: address points to the zero page.
    #0 0x56315c449fbc in block_type_get_arity /home/lain/wasm-micro-runtime/core/iwasm/common/../interpreter/wasm.h
    #1 0x56315c449fbc in wasm_loader_prepare_bytecode /home/lain/wasm-micro-runtime/core/iwasm/interpreter/wasm_loader.c:11552:33
    #2 0x56315c4373a3 in load_from_sections /home/lain/wasm-micro-runtime/core/iwasm/interpreter/wasm_loader.c:6001:14
    #3 0x56315c43aeea in load /home/lain/wasm-micro-runtime/core/iwasm/interpreter/wasm_loader.c:6405:13
    #4 0x56315c43aeea in wasm_loader_load /home/lain/wasm-micro-runtime/core/iwasm/interpreter/wasm_loader.c:6582:10
    #5 0x56315c3d3bda in wasm_runtime_load /home/lain/wasm-micro-runtime/core/iwasm/common/wasm_runtime_common.c:1386:12
    #6 0x56315c3cf2d6 in main /home/lain/wasm-micro-runtime/product-mini/platforms/linux/../posix/main.c:913:25
    #7 0x7f8fd4e1a082 in __libc_start_main /build/glibc-SzIz7B/glibc-2.31/csu/../csu/libc-start.c:308:16
    #8 0x56315c30467d in _start (/home/lain/wasm-micro-runtime/product-mini/platforms/linux/build/iwasm+0x4367d)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /home/lain/wasm-micro-runtime/core/iwasm/common/../interpreter/wasm.h in block_type_get_arity
==13987==ABORTING

@mobsceneZ Thanks for reporting the issue! I submitted PR https://github.com/bytecodealliance/wasm-micro-runtime/pull/3352 to fix it, please try again.

@wenyongh Hi, I manually checked the PoC again and the crash disappeared, thanks for your effort!

@mobsceneZ welcome. So let's close the issue as https://github.com/bytecodealliance/wasm-micro-runtime/pull/3352 was merged.


what's the Sharding strategy of GraphEngine? Can I use other db backends ?

what's the Sharding strategy of GraphEngine? Can I use other db backends ?

@BenDerPan the default sharding function is simple: (long id) => (int)(id / 8 % Global.CloudStorage.PartitionCount
You can override this with Global.CloudStorage.SetPartitionMethod(.) and align with the other backend.

@yatli thanks, and how many replicas of each shard ? can we config it in trinity.xml ? :)

use "AvailabilityGroup" to specify the availability group id.
see:
https://github.com/Microsoft/GraphEngine/wiki/config-v2#server

thanks, great!  close this now.


Dependabot doesn't update to latest pre-release version

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
Yarn (npm)
Package manager version
Yarn 1.22.19 (npm 8.19.3)
Language version
Node.js 18.12.1
Manifest location and content before the Dependabot update

/package.json
/yarn.lock

dependabot.yml content
No response
Updated dependency
Dependency: @myorg/react-scripts (the actual organization has been replaced in this example)
Version from: 5.0.0-fork.1.0.3
Version to: 5.0.1-fork.1.0.3
What you expected to see, versus what you actually saw
Background:
We've forked the create-react-app repository and have built a custom version of the react-scripts library. Thus, we've versioned the fork using the following pre-release version format: <upstream-version>-fork.<fork-version>. The version format adheres to the Semantic Versioning 2.0.0 specification and based on the precedence rules 5.0.0-fork.1.0.3 < 5.0.1-fork.1.0.3.
Dependabot has previously updated successfully, e.g., from version 5.0.0-fork.1.0.2 to version 5.0.0-fork.1.0.3.
Here's a comment that seems to describe a similar problem: https://github.com/dependabot/dependabot-core/issues/2250#issuecomment-1225855482
Expected behavior:
Dependabot updates @myorg/react-scripts from version 5.0.0-fork.1.0.3 to version 5.0.1-fork.1.0.3.
Actual behavior:
Dependabot reports No update needed for @myorg/react-scripts 5.0.0-fork.1.0.3
Native package manager behavior
Running yarn upgrade-interactive --latest suggests to update @myorg/react-scripts from version 5.0.0-fork.1.0.3 to version 5.0.1-fork.1.0.3.
Images of the diff or a link to the PR, issue, or logs
Dependabot logs related to the dependency:
updater | INFO <job_613873872> Checking if @myorg/react-scripts 5.0.0-fork.1.0.3 needs updating
  proxy | 2023/02/26 04:21:47 [202] GET https://my-private-registry.org:443/repository/npm-hosted/@myorg%2Freact-scripts
  proxy | 2023/02/26 04:21:47 [202] * authenticating npm registry request (host: my-private-registry.org, basic auth)
  proxy | 2023/02/26 04:21:48 [202] 200 https://my-private-registry.org:443/repository/npm-hosted/@myorg%2Freact-scripts
  proxy | 2023/02/26 04:21:48 [204] GET<EMAIL_ADDRESS>  proxy | 2023/02/26 04:21:48 [204] * authenticating npm registry request (host: my-private-registry.org, basic auth)
  proxy | 2023/02/26 04:21:48 [204] 400<EMAIL_ADDRESS>updater | INFO <job_613873872> Latest version is 5.0.0-fork.1.0.3
updater | INFO <job_613873872> No update needed for @myorg/react-scripts 5.0.0-fork.1.0.3

Smallest manifest that reproduces the issue
No response

Thanks for letting us know about this! Can you create a public repository that illustrates the problem?

Sure, I'll try to set up an example that reproduces the problem in a public repository.

  proxy | 2023/02/26 04:21:48 [204] GET<EMAIL_ADDRESS>  proxy | 2023/02/26 04:21:48 [204] * authenticating npm registry request (host: my-private-registry.org, basic auth)
  proxy | 2023/02/26 04:21:48 [204] 400<EMAIL_ADDRESS>
If I'm reading this right, that is returning a 400, which seems a bit surprising... it didn't seem to affect realizing the updated version string, so not the 🚬 🔫 , but still surprising...

I set up an example package jpaakko/create-react-app-dependabot-test and a public repository jpaakko/dummy-dependabot-project that reproduce the problem.
The example package uses a similar versioning scheme as what we use in the private project where we originally stumbled upon the problem. To illustrate the problem, I published a couple of different versions of the example package to GitHub's package registry: https://github.com/jpaakko/create-react-app-dependabot-test/pkgs/npm/react-scripts.
As can be seen from this open Dependabot PR, Dependabot successfully managed to update from version 5.0.0-fork.1.0.0 to version 5.0.0-fork.1.0.1. I then published version 5.0.1-fork.1.0.1 which according to the semantic versioning specification is greater than 5.0.0-fork.1.0.1. Now, when I manually trigger Dependabot to check for updates, Dependabot logs the following:
updater | INFO <job_620229543> Checking if @jpaakko/react-scripts 5.0.0-fork.1.0.0 needs updating
  proxy | 2023/03/06 13:55:26 [028] GET https://npm.pkg.github.com:443/@jpaakko%2Freact-scripts
  proxy | 2023/03/06 13:55:26 [028] * authenticating npm registry request (host: npm.pkg.github.com, token auth)
  proxy | 2023/03/06 13:55:26 [028] 200 https://npm.pkg.github.com:443/@jpaakko%2Freact-scripts
  proxy | 2023/03/06 13:55:26 [030] GET<EMAIL_ADDRESS>  proxy | 2023/03/06 13:55:26 [030] * authenticating npm registry request (host: npm.pkg.github.com, token auth)
  proxy | 2023/03/06 13:55:26 [030] 405<EMAIL_ADDRESS>updater | INFO <job_620229543> Latest version is 5.0.0-fork.1.0.1
updater | INFO <job_620229543> Pull request already exists for @jpaakko/react-scripts with latest version 5.0.0-fork.1.0.1

So, for some reason Dependabot concludes that the latest version is 5.0.0-fork.1.0.1. As a comparison, when I run yarn upgrade-interactive --latest @jpaakko/react-scripts on the command line for the dummy-dependabot-project repository, Yarn is correctly showing that @jpaakko/react-scripts can be updated and outputs:
yarn upgrade-interactive v1.22.19
info Color legend :
 "<red>"    : Major Update backward-incompatible updates
 "<yellow>" : Minor Update backward-compatible features
 "<green>"  : Patch Update backward-compatible bug fixes
? Choose which packages to update. (Press <space> to select, <a> to toggle all, <i> to invert selection)
 devDependencies
   name                    range   from                 to                url
❯◯ @jpaakko/react-scripts  latest  5.0.0-fork.1.0.0  ❯  5.0.1-fork.1.0.1  https://github.com/jpaakko/create-react-app-dependabot-test.git

  proxy | 2023/02/26 04:21:48 [204] GET<EMAIL_ADDRESS>  proxy | 2023/02/26 04:21:48 [204] * authenticating npm registry request (host: my-private-registry.org, basic auth)
  proxy | 2023/02/26 04:21:48 [204] 400<EMAIL_ADDRESS>
If I'm reading this right, that is returning a 400, which seems a bit surprising... it didn't seem to affect realizing the updated version string, so not the smoking gun , but still surprising...

Good observation! As you said, this isn't related to this problem but is odd indeed. We use Nexus as our private npm package registry. I wonder whether the response could be a cause of some kind of a misconfiguration on our instance. We'll have to look into this.

We are seeing the same behavior with a different dependency, which is also a pre-release.
This is our Dependabot config:
version: 2
updates:
  - package-ecosystem: npm
    directories:
      - "/"
    labels: [ ]
    schedule:
      interval: daily
    versioning-strategy: increase
    ignore:
      - dependency-name: "@middy/core"
        update-types: [ "version-update:semver-major" ]
    groups:
      aws-sdk-v3:
        patterns:
        - "@aws-sdk/*"
        - "@smithy/*"
        - "aws-sdk-client-mock"
        - "aws-sdk-client-mock-jest"
      aws-cdk:
        patterns:
        - "@aws-cdk/cli-lib-alpha"
        - "aws-cdk-lib"
        - "aws-cdk"
      typedoc:
        patterns:
        - "typedoc"
        - "typedoc-plugin-*"

Which doesn't pick up the pre-release packages. Here are the Dependabot logs

In all cases the @aws-cdk/cli-lib-alpha package is always left behind.
I am not familiar with the codebase at all, but looking at the tests, there seems to be one that says that this should not be happening and that tests pre-release updates explicitly: https://github.com/dependabot/dependabot-core/blob/ddb9722dd9ed00daf54b5115ccfe033c6bb910b7/npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/requirements_updater_spec.rb#L320-L342
Also, this seems to be related to #10458


Update active-directory-reporting-activity-sign-ins.md

@dhanyahk,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@dhanyahk : Thanks for your contribution to the Azure documentation! The author, @MarkusVi, has been notified to review your proposed change.

#sign-off


Improve SHARED_PORT defaults

The default shared port configuration makes the firewall configuration unnecessarily complex.

The collector should be moved behind the shared port (as has been default since 8.4).
Change the shared port TCP port to 9618, the IANA-reserved port for HTCondor.

This drops the firewall requirements from both 9618 and 9615 to the developer-suggested 9618-only.  The shared_port has been battle tested at quite large scales -- better to have things simpler out-of-the-box.

created branch 65_improve_shared_port_defaults and requested review from marco

branch merged, closing issue


ENH: stats: bootstrap: add batch parameter to control batch size

Reference issue
gh-13371
What does this implement/fix?
This adds one of the enhancements planned for the new bootstrap function:
The new parameter batch controls the batch size in which resamples are processed in vectorized calls to statistic.

Merged.  This is the last change that was discussed in the original bootstrap PR that we wanted to get into the release.


"Torrent" approach for PR reviews (reviewing other PRs helps your own PRs)

@andralex proposed a "torrent" approach for reviewing PRs a while ago:

In the BitTorrent protocol,
you only get bits if you offer bits. In the envisioned "review torrent"
protocol, the more PRs you review, the more likely your PR is to get
reviewed. Do you think this could be supported by tooling?

I am not sure yet how tooling could help, but I am putting this here so that it's not forgotten and has a better visibility. Maybe someone else has a good idea?

Is this still relevant today, now that we have staff reviewing PRs?


Update Set-SPProfileServiceApplicationSecurity.md

Fill in placeholder text, add example.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Set-SPProfileServiceApplicationSecurity.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


JUnit-style reporter for Serenity/JS

Please tell
Have we hook for convert serenity report to some xUnit reports for import to Azure?

Hey @igTkachov - I'm not that familiar with Azure, but do I understand correctly that you'd like Serenity/JS to produce a test report in an xUnit format so that it can be imported into another tool? Is that right?

Hey @jan-molak
Yes, you are right.
Now I try to parse serenity reports and convert to necessary xml format.

I see; A better approach would be to implement a custom JUnit reporter (or a StageCrewMember in Serenity-speak). I've been planning on doing it at some point, but if you'd be willing to contribute one that would be absolutely amazing. Let me know if that's the case and I could guide you through it.
But to address your immediate challenge. What you'd need to do is to implement a JUnitReporter that receives DomainEvents and converts them into an appropriate report you then store in a file.
If you're using 1.x have a look at the ConsoleReporter or the SerenityBDDReporter.
If you're on version 2, have a look at the crew package in @serenity-js/core and some of the StageCrewMember implementations there.
The main difference between the v1 and v2 implementations of StageCrewMembers is that in v1 the StageCrewMember used to be responsible for writing the report to a file, in v2 the ArtifactArchiver has the responsibility of performing side effects so instead of making your JUnitReporter write a report to a file you simply broadcast a domain event with the report and the ArtifactArchiver will store it in a file for you. Here's an example.

I'm not expert in js, but I want to try it.

Yup! Got the same issue :) I need it for circleci.com .
I will look into doing it as well, but not sure that it will be easy.
Alternatively, I would be happy with a cucumber compatible JSON file.

@igTkachov Can I provide a workaround?

@abhinaba1080 I've created my local convertor for Azure report. But your convertor should work, because Azure can parse cucumber report in xml format.

@abhinaba1080 what is in your /transform/ folder?
And my cucumber_report.json file is just empty? i.e. 0 bytes.

Hi @andreasmarkussen ,
The transform folder is where I keep all of the JS files.
I have tested the logic with both Serenity V1 and V2. It just worked fine.
Can you share your protractor.conf file?

protractor.conf.js

// @ts-check
const
    { ConsoleReporter } = require('@serenity-js/console-reporter'),
    { ArtifactArchiver } = require('@serenity-js/core'),
    { Photographer, TakePhotosOfFailures, TakePhotosOfInteractions, TakePhotosBeforeAndAfterInteractions } = require('@serenity-js/protractor'),
    { SerenityBDDReporter } = require('@serenity-js/serenity-bdd'),
    isCI = require('is-ci');

const { lambdaTestConf } = require("./.circleci/lambdaTest.conf.js")
const { sauceLabsConf } = require("./.circleci/sauceLabs.conf.js")
const { Authenticator } = require('authenticator-browser-extension');

/** Browser Location - CI or local machine
 * Direct
 * SauceLabs (Only Cloud)
 * LambdaTest (Only Cloud)
 */
/** We use sauceLab in the cloud and direct connection locally */
const targetEnvironment = isCI ? 'sauceLab' : '';
// targetEnvironment = 'lambdaTest';

/**
 * Local url : http://localhost:10007/
 * Some url :
 */

const determineHeadlessMode = () => {
    if (process.env.DRIVER === 'HEADLESS')
        return true;
    return false;
}

const shouldBeHeadlessMode = determineHeadlessMode();

/**
 * @type { import("protractor").Config }
 * @see https://www.protractortest.org/#/browser-setup
*/
const protractorConfig = {
    baseUrl: 'http://test.dk',

    chromeDriver: require(`chromedriver/lib/chromedriver`).path,

    SELENIUM_PROMISE_MANAGER: false,

   directConnect: true,

    // https://github.com/angular/protractor/blob/master/docs/timeouts.md
    allScriptsTimeout: 300000,

    framework: 'custom',
    frameworkPath: require.resolve('@serenity-js/protractor/adapter'),

    specs: ['features/**/*.feature'],

    serenity: {
        runner: 'cucumber',
        crew: [
            ArtifactArchiver.storingArtifactsAt('./target/site/serenity'),
            ConsoleReporter.forDarkTerminals(),
            //Photographer.whoWill(TakePhotosOfInteractions),
            Photographer.whoWill(TakePhotosOfFailures),
            //Photographer.whoWill(TakePhotosBeforeAndAfterInteractions),
            new SerenityBDDReporter(),
        ]
    },
    plugins: [
        {
            // The module name
            package: "protractor-react-selector"
        },
    ],

    /**
     * If you're interacting with a non-Angular application,
     * uncomment the below onPrepare section,
     * which disables Angular-specific test synchronisation.
     */

    onPrepare: function () {
        /** @type { import("protractor").ProtractorBrowser } */
        let browser = global['browser'];
        browser.waitForAngularEnabled(false); // This can be removed if the 'protractor-testability-plugin' is enabled
    },

    cucumberOpts: {
        require: ['features/**/*.ts',],
        'require-module': ['ts-node/register'],
        tags: ['~@wip'],
        strict: false,
    },

    capabilities: {
        browserName: 'chrome',

        // see https://github.com/SeleniumHQ/selenium/wiki/DesiredCapabilities#loggingpreferences-json-object
        loggingPrefs: {
            browser: 'ALL' // "OFF", "SEVERE", "WARNING", "INFO", "CONFIG", "FINE", "FINER", "FINEST", "ALL".
        },

        chromeOptions: {
            args: [
                '--no-sandbox',
                '--disable-infobars',
                '--log-level=3',
                '--disable-gpu',
                '--window-size=1024,800',
            ].concat(shouldBeHeadlessMode ? ['--headless'] : []),    // run in headless mode on the CI server
            /**
             * Note: We do not use headless in the sauceLabs cloud,
             * since then we will not be able to use the authenticator extension,
             * since Chrome Headless does not support extensions.
            */ extensions: [
                // The authenticator only has an effect locally and on sauceLab.
                // Not on lambdaTest where the Url authentication is needed.
            ].concat(shouldBeHeadlessMode ? [] : [ Authenticator.for('xxx', 'yyy').asBase64() ] )
        }
    }
};

function decideConfig(browserLocation) {
    console.log(`Browser Location set to ${browserLocation}`)
    switch (browserLocation) {
        case 'sauceLab':
            return { ...protractorConfig, ...sauceLabsConf }
        case 'lambdaTest':
            return { ...protractorConfig, ...lambdaTestConf }
    }
    return protractorConfig;
}

const finalConfig = decideConfig(targetEnvironment);

exports.config = finalConfig;

console.log("Protractor config  ", finalConfig)

@jan-molak : Hello,
Based on you previous guidelines, I wrote a custom JUnitReporter, but facing 2 issues:

There is no XML or Generic Text file Artifact available.
Report file is not created, I believe because ArtifactArchiver only handles Photo or TestReport Artifact. Unable to pass a generic artifact to write to file.

I create another artifact like:
export class XMLData extends Artifact {
  map<T>(fn: (decodedValue: string) => T): T {
    return fn(Buffer.from(this.base64EncodedValue, 'base64').toString());
  }

  static fromString (value: string): XMLData {
    return new XMLData(Buffer.from(value).toString('base64'));
  }
}

Then I do a broadcast like this:
private broadcast() {
    this.stage.announce(new ArtifactGenerated(
      new Name('junit-result.xml'), XMLData.fromString(this.testSuites.end({pretty: true} as XMLToStringOptions))
    ));
  }

Report is not created, I believe because ArtifactArchiver has a check for:
if (event.artifact instanceof TestReport) {...}```

Any help on how to proceed is appreciated.
Thanks.

@aksbenz - If you'd like to raise a PR we could work on it together?

@jan-molak : Not experienced with open source projects. I am not sure how to go about creating another junit reporter package in serenity.
My Junit reporter looks like this:
https://github.com/aksbenz/serenityjs-playwright-jasmine-junit/blob/master/src/JUnitReporter.ts
Created a copy of ArtifactArchiver with XMLData:
https://github.com/aksbenz/serenityjs-playwright-jasmine-junit/blob/master/src/JUnitArchiver.ts

Please check pr for initial steps towards junit reporter. Thanks.
https://github.com/serenity-js/serenity-js/pull/571

Note to self: Looks like Gitlab supports attaching screenshots to JUnit reports. Is it a standard, or a Gitlab-specific thing?

Hey folks! Looks like quite a few people have asked for this functionality.
I did have a closer look at what is required to make it happen and it feels like it would be a good opportunity to improve how Serenity/JS artifacts work in general. I'm planning to make the mechanism more flexible to support not just JUnit, but also other custom report and artifact types in the future.
If you think that it's a worthwhile effort, and you too would like to see this feature added, please consider sponsoring this goal at https://github.com/sponsors/serenity-js


add magic frozen_string_literal comment; avoid String#<< mutation of frozen strings

add magic frozen_string_literal comment at the top of each file
avoid String#<< mutation of frozen strings by using + to make the string mutable, or += to copy instead

@dasch Here's a quick follow-on PR to add the magic frozen_string_literal comment throughout.

Thanks!


Tests failing

When running npm run test from master I get 50 errors that look like this:
45) no-unresolved syntax verification valid import json from "./data.json":

      AssertionError: Should have no errors but had 1: [ { ruleId: 'no-unresolved syntax verification',
    severity: 1,
    message: 'Casing of ./data.json does not match the underlying filesystem.',
    line: 1,
    column: 18,
    nodeType: 'Literal',
    source: 'import json from "./data.json"' } ]
      + expected - actual

      -1
      +0

      at testValidTemplate (node_modules\eslint\lib\testers\rule-tester.js:423:20)
      at Context.RuleTester.it (node_modules\eslint\lib\testers\rule-tester.js:548:25)

I am running:

Windows 10 (v1607 build 14393.447)
NPM v4.1.2
Node v7.7.4
GNU bash, version 4.3.46(2)-release (x86_64-pc-msys)

can you confirm that data.json case does actually match?

Is it supposed to be all lower-case?
$ find . -iname data.json
./resolvers/node/test/data.json
./tests/files/data.json

yep. super weird. I wonder if it's a Node 7 issue? I have not tested past Node v6

oh actually: does your shell pwd path match the filesystem? there was an old Windows issue where if you navigated case-insensitive to your code folder it would fail because the absolute bath (based on pwd) didn't match FS.

If #846 passes I will close, assuming it's that.

does your shell pwd path match the filesystem?

That was it!  All tests are passing now - thank you so much!


[BUG]

setuptools version
setuptools >57
Python version
python 3.9, 3.10 probably others
OS
Linux, Win
Additional environment information
No response
Description
I mean....seriously...
error in googleads setup command: use_2to3 is invalid.
For anybody doing anything besides maybe coming up with LaTex equations this is a dealbreaker. setuptools - you know you're better than that. Bring back 2to3 already. Sheesh
Expected behavior
it to work
How to Reproduce
just try installing anything that wants the super-dumb googleads package
Output
<fart> error in googleads setup command: use_2to3 is invalid. <fart> <fart> <pffffft>

To implement such a feature, setuptools depends on the standard library, but Python itself has deprecated the functionality (https://bugs.python.org/issue40360 - it was supposed to go away in Python 3.10 when it was removed from setuptools - #2086 - but got postponed).
The removal of the feature in setuptools went through a deprecation cycle (#2096), with deprecation warnings being issued so the developers could take action before the removal (#2731).
I suggest contacting the package in question and informing them they should migrate the code base to Python 3.
Alternatively, you can try to find a setuptools plugin that backfills the functionality or create one yourself.


It's not work when CENTER_CROP in VerticalViewPager.

It's not work when CENTER_CROP in VerticalViewPager.
I guess the reason is:
	PhotoViewAttacher.onDrag(float dx, float dy) {
		...
		if (mScrollEdge == EDGE_BOTH
                    || (mScrollEdge == EDGE_LEFT && dx >= 1f)
                    || (mScrollEdge == EDGE_RIGHT && dx <= -1f)) {
                if (null != parent)
                    parent.requestDisallowInterceptTouchEvent(false);
            }
		...
	}

It should be:
            boolean hori = parentIsHori && ((mScrollEdge == EDGE_LEFT && dx >= 1f)
                    || (mScrollEdge == EDGE_RIGHT && dx <= -1f));
            boolean vertival = !parentIsHori && ((mScrollEdge == EDGE_TOP && dy >= 1f)
                    || (mScrollEdge == EDGE_BOTTOM && dy <= -1f));
            if (mScrollEdge == EDGE_BOTH
                    || hori || vertival) {
                if (null != parent)
                    parent.requestDisallowInterceptTouchEvent(false);
            }

Fixed it!!
show https://github.com/dyguests/PhotoViewEx.
LOL....


MCL1 perturbation 23~66

Per our conversation during the meeting, I think we should also use MCL1 as a test system for 'validation' because it almost 3x smaller than CDK2. The perturbation I am working with is simple and is located at indices 19 > 13 in MCL1_ligands.sdf.zip.
MCL1_protein_fixed.pdb.zip
is the protein that I prepared using pdbfixer.
However after preparing the topology proposal with NonequilibriumFEPSetup, I get an error when trying to build the HybridTopologyFactory:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-17-9565cf892879> in <module>()
      1 snefep = NonequilibriumSwitchingFEP(sfesetup[0], sfesetup[1], sfesetup[2], ncmc_nsteps=1000000,
      2                                     nsteps_per_iteration=1000, trajectory_directory='mcl1_solvated_011118',
----> 3                                     trajectory_prefix='traj')

~/PycharmProjects/perses/perses/dispersed/relative_setup.py in __init__(self, topology_proposal, pos_old, new_positions, use_dispersion_correction, forward_functions, n_equil_steps, ncmc_nsteps, nsteps_per_iteration, temperature, trajectory_directory, trajectory_prefix, atom_selection, scheduler_address)
    362
    363         #construct the hybrid topology factory object
--> 364         self._factory = HybridTopologyFactory(topology_proposal, pos_old, new_positions, use_dispersion_correction=use_dispersion_correction)
    365
    366         #use default functions if none specified

~/PycharmProjects/perses/perses/annihilation/new_relative.py in __init__(self, topology_proposal, current_positions, new_positions, use_dispersion_correction, functions)
    146
    147         #verify that no constraints are changing over the course of the switching.
--> 148         self._constraint_check_fast()
    149
    150         #construct dictionary of exceptions in old and new systems

~/PycharmProjects/perses/perses/annihilation/new_relative.py in _constraint_check_fast(self)
    455         for constraint_pair in overlapping_constraints:
    456             if old_system_constraints[constraint_pair] != new_system_constraints[constraint_pair]:
--> 457                 raise ValueError("There is a changing constraint length in this system.")
    458
    459     def _determine_interaction_group(self, atoms_in_interaction):

ValueError: There is a changing constraint length in this system.

I am currently trying to debug this. @pgrinaway can you give it a try on your system and see if you get the same error?

Sounds good


Add PR_TITLE env for pr builds

It's an attempt to add DRONE_PULL_REQUEST_TITLE env support.
Ideas was described here.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

👋 hey there, thanks for the pull request.  This code is no longer used and was moved to a separate library.  Therefore, if you want to add a new environment variable, it would need to be added to the library, in this file https://github.com/drone/runner-go/blob/master/environ/environ.go

Oh, cool then!


Pretrain and Finetune template versions

Hi,
I noticed that the --version arg in both the pretrain and finetune scripts is passed with v1, which is different from the original LLaVA&LLaVA-1.5 and other LLaVA style projects. Do you have any ideas on why you chose to do this?
Best,

Hi, v1 is more like a default setting in the finetune stage of MLLM if you use LLaMA2, as less has trained a more powerful version of llama called vicuna. I am not the authors, hope this can still help you.


[Feature suggestion] Add order collection in random location

As it stands, the project greatly eases the burden on someone searching for a bite. After a wholesome meal, however, it can be burdensome to engage in subsequent workout. So why not do it before the meal?
A potentially helpful addition might thus be adding a collection of a Deliveroo order in a random location. Delivery already supports ordering for collection. Collection could be within a user-specific diameter. The technical complexity of realising this suggestion could therefore be very much within scope.
Happy Easter! 🐤

Once we raise a 10M series A this will be top priority ;)
(though I do plan to allow people to select a location at some point!)


Swap out Jerkson dependency for Spray-Json

Hey folks, just updating the public repo as mentioned in the email. The larger conversion to Spray-Json is blocked on upgrading our dependencies (like Conjecture) so any possible haste on the review will be much appreciated. It's a very small patch.
Also - did I miss anything? ;)

Great! I'm suprised we were only using jerkson in that one spot.

Thanks for the fast review!


Adds documentation for DevTools experiments

The following PR adds documentation for DevTools experiments. It currently includes:

CSS grid
webhint integration
Moveable tabs

Docs Build status updates of commit 3e15538:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:warning:Warning

Details

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/experimental-features.md

Line 14, Column 159: [Warning-bookmark-not-found] Cannot find bookmark '#Providing-feedback-on-experimental-features' in 'devtools-guide-chromium/experimental-features.md', did you mean '#providing-feedback-on-experimental-features'?
Line 52, Column 296: [Warning-file-not-found] Invalid file link: './Issues'.
Line 62, Column 4: [Warning-file-not-found] Invalid file link: '3D-view'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit fa5fa00:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:warning:Warning

Details

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/experimental-features.md

Line 14, Column 159: [Warning-bookmark-not-found] Cannot find bookmark '#Providing-feedback-on-experimental-features' in 'devtools-guide-chromium/experimental-features.md', did you mean '#providing-feedback-on-experimental-features'?
Line 52, Column 296: [Warning-file-not-found] Invalid file link: './Issues'.
Line 62, Column 4: [Warning-file-not-found] Invalid file link: '3D-view'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 965ba99:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a713cdc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ea42fc0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 912f298:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 125d92e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 274c194:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d4926c6:
:clock10: Pending: waiting for processors (137 builds ahead of you)
:warning: Docs Build is busy, currently there are 137 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit d4926c6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 2d9ce5f:
:clock10: Pending: waiting for processors (116 builds ahead of you)
:warning: Docs Build is busy, currently there are 116 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 2d9ce5f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d5884fe:
:clock10: Pending: waiting for processors (8 builds ahead of you)
:warning: Docs Build is busy, currently there are 8 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit d5884fe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 675ea5b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit bee446c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

#sign-off

Docs Build status updates of commit 2285510:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 2285510:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a9b283b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ab25fb7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit da777ee:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d8aa0c0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 66c3d2b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e2a20ac:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/experimental-features.md
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-devtools.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-grid.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-move-panels.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/experiments-webhint.png
:white_check_mark:Succeeded

microsoft-edge/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

#signed-off and merged.


[BUG][Face] OperationStatus does not deserialize correctly due to JSON property name mismatches

Describe the bug
When I call SnapshotOperations.GetOperationStatusAsync, the server response is not deserialized into an OperationStatus object correctly. Opening the OperationStatus object in Quick View shows:
-		operationStatus	{Microsoft.Azure.CognitiveServices.Vision.Face.Models.OperationStatus}	Microsoft.Azure.CognitiveServices.Vision.Face.Models.OperationStatus
+		CreatedTime	{1/1/0001 12:00:00 AM}	System.DateTime
		LastActionTime	null	System.DateTime?
		Message	null	string
		ResourceLocation	null	string
		Status	Succeeded	Microsoft.Azure.CognitiveServices.Vision.Face.Models.OperationStatusType

Note the ResourceLocation property value is null, which means I can't get the ID of the snapshot I just took.
Expected behavior
The OperationStatus.ResourceLocation property should have a non-null value, for example:
-		operationStatus	{Microsoft.Azure.CognitiveServices.Vision.Face.Models.OperationStatus}	Microsoft.Azure.CognitiveServices.Vision.Face.Models.OperationStatus
+		CreatedTime	{1/1/0001 12:00:00 AM}	System.DateTime
		LastActionTime	null	System.DateTime?
		Message	null	string
		ResourceLocation	"/snapshots/4dea7d1e-4519-4b03-9a23-b7114a5ca060"	string
		Status	Succeeded	Microsoft.Azure.CognitiveServices.Vision.Face.Models.OperationStatusType

Actual behavior (include Exception or Stack Trace)
There is no exception.
This bug happens because the JsonProperty names for the OperationStatus properties do not match the names of the corresponding fields in the serialized JSON object in the body of the HTTP server response.
For example, the OperationStatus.ResourceLocation has a JsonProperty name of "ResourceLocation". See:
https://github.com/Azure/azure-sdk-for-net/blob/ad80cd5c1732de3700fffd501dfedfc911ea69b1/sdk/cognitiveservices/Vision.Face/src/Generated/Models/OperationStatus.cs#L117
However, in the response returned by the server, the corresponding field is "location", not "resourceLocation":
{
  "status": "succeeded",
  "createdDateTime": "2020-09-11T19:41:07.2046017+00:00",
  "location": "/snapshots/e7bde61d-63ef-4c40-9e4f-08ec38bd576e"
}

You can verify this by using API testing consoles, e.g.:
https://westcentralus.dev.cognitive.microsoft.com/docs/services/563879b61984550e40cbbe8d/operations/snapshot-take/console
https://westcentralus.dev.cognitive.microsoft.com/docs/services/563879b61984550e40cbbe8d/operations/operationstatus-get/console
An example operation ID is 5f0ddbe6-82fd-4ae9-a04c-6805c433cf28, though I don't know if that will work for you.
The OperationStatus.ResourceLocation property should have a property name of "location":
[JsonProperty(PropertyName = "location")]
public string ResourceLocation { get; set; }

I verified this as follows.

Clone the Azure SDK for .NET.
Edit OperationStatus.cs as described just previously.
Recompile Microsoft.Azure.CognitiveServices.Vision.Face.dll.
Insert the recompiled Microsoft.Azure.CognitiveServices.Vision.Face.dll into my project in place of the version provided by NuGet.
Run my project. The relevant code snippet follows.
The OperationStatus.ResourceLocation property has a non-null value.

string ENDPOINT = "YOUR FACE ENDPOINT HERE";
string SUBSCRIPTION_KEY = "YOUR FACE SUBSCRIPTION KEY HERE";
string personGroupId = "A VALID PERSON GROUP ID HERE";

IFaceClient client = Authenticate(ENDPOINT, SUBSCRIPTION_KEY);
var takeSnapshotResult = await clientSource.Snapshot.TakeAsync(SnapshotObjectType.PersonGroup, personGroupId, new Guid?[] { SUBSCRIPTION_KEY });
var operationId = Guid.Parse(takeSnapshotResult.OperationLocation.Split('/')[2]);
OperationStatus operationStatus = null;
do
{
	Thread.Sleep(TimeSpan.FromMilliseconds(1000));
	operationStatus = await clientSource.Snapshot.GetOperationStatusAsync(operationId);
}
while (operationStatus.Status != OperationStatusType.Succeeded && operationStatus.Status != OperationStatusType.Failed);
var snapshotId = Guid.Parse(operationStatus.ResourceLocation.Split('/')[2]);

NOTES:

Other OperationStatus properties have mismatched JsonProperty names as well.
For instance, the CreatedTime property has JsonProperty name "createdTime", but the corresponding field in the HTTP server response is "createdDateTime". As a result, the OperationStatus.CreatedTime property ends up with a value of {1/1/0001 12:00:00 AM}.

According to Github, OperationStatus.cs has not changed since at least May 2019:
https://github.com/Azure/azure-sdk-for-net/commits/master/sdk/cognitiveservices/Vision.Face/src/Generated/Models/OperationStatus.cs
Therefore, this issue presumably results from changes made to the Face service rather than to the SDK.

To Reproduce
See previous item.
Environment:

Name and version of the Library package used: [e.g. Azure.Storage.Blobs 12.2.0]
Microsoft.Azure.CognitiveServices.Vision.Face v2.6.0-preview.1

Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): [e.g. Azure AppService or Windows 10 .NET Framework 4.8]
Windows 10 Enterprise 1909

Output of dotnet --info:
.NET Core SDK (reflecting any global.json):
 Version:   3.1.402
 Commit:    9b5de826fd

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18363
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.1.402\

Host (useful for support):
  Version: 3.1.8
  Commit:  9c1330dedd

.NET Core SDKs installed:
  2.1.700 [C:\Program Files\dotnet\sdk]
  3.1.402 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.22 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.22 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.22 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 3.1.8 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

IDE and version : [e.g. Visual Studio 16.3]
Microsoft Visual Studio Community 2019
Version 16.7.3

Thank you for your feedback.  Tagging and routing to the team best able to assist.

Per sbowles, this is going to be fixed on the server side and not the SDK side. Therefore I am closing.


Disable OOC during round on Salamander

About the PR
Disabled the OOC being on by default on Salamader config.
Why / Balance
After a discussion in Admin/PM thread a decision was made to disable OOC on salamander due to excessive misuse.
Technical details
Just a flag in the salamander config.
Media
N/A

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
N/A
Changelog
OOC disabled on salamander.

instead of removing the honor of using OOC just remove the people misusing it FROM salamander, there was big no issue before the massive exodus that bump salamander above 45 players

instead of removing the honor of using OOC just remove the people misusing it FROM salamander, there was big no issue before the massive exodus that bump salamander above 45 players

As far as Ive seen sala has ooc chat disabled consistently because peplo cant behave.
Almost as if they see salamander as an extension of lizard with rules on how do you interact with other players verbally and thats the bare minimum they follow :trollface:

instead of removing the honor of using OOC just remove the people misusing it FROM salamander, there was big no issue before the massive exodus that bump salamander above 45 players

Admin consensus is to disable it. I have my personal opinions on this as well. However the change is not up for debate, it's an admin issue, and was handled by admins.


fix step 2 github onboarding

https://github.com/cutestrap/cutestrap couldn't be onboarded.
Owner is @tylerchilds and nothing happened in step 2: "2/4 Pick a repository" and "Select a project you wish to create an open collective for." with nothing listed there, no errors in the console either.

From @carlosascari: A scope is missing in the url when fetching the repos
https://github.com/OpenCollective/opencollective-website/blob/master/frontend/src/actions/github/fetch_repos.js#L13

@piamancini Its actually in the api repo, PR sent

what's the PR #?

https://github.com/OpenCollective/opencollective-api/pull/362

Thanks!

Documenting for posterity: That PR isn't going to fix this issue that @tylerchilds hit. That issue is because we look for a repos owner, which @tylerchilds isn't according to Github - he's listed as a contributor. @piamancini is following up with @tylerchilds.


Plugin system in character.plugins is not working

Describe the bug
Plugin system in characters.plugins is not working.

Loading the plugin

When a character is loaded from a JSON, the code expects to find a list of path to plugins it can import.

However, the validateCharacterConfig expects the content of plugin to be an object. This can not work.
To Reproduce
Add the path to a plugin in the character.plugins array
Expected behavior
Plugin is loaded rightly, actions are added to runtime, services are launched etc...

Has been fixed in latest code commited