need help in reproducing the results in your paper

Hi dingjingtao,
Thank you for sharing your implementation for your paper which is very inspiring.
However, I failed to reproduce the recommendation accuracies presented in the paper and even after tuning the parameters based on the paper.
Taking the dataset Tmall given in this project as an example, when using the default settings in main_MF for VALS, the HR and NDCG are only 0.0083 and 0.0020, respectively, by Iteration 20, and after tuning the parameters, HR and NDCG can still hardly exceed 0.035 by Iteration 20. These results are far lower than those presented in Figure 3 in the paper, where HR and NDCG exceed 0.06 and 0.015, respectively, in the first several iterations.
Could you please share more details about the parameters for achieving the highest recommendation accuracies? or give me some hints to achieve the results presented in the paper?
I list the default and my tunned parameters in the file main_MF below,
the default:
String dataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_purchase";
String sidedataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_view";
String method = "vieweALS";
double w0 = 0.5; // c0 in the paper, given
double w1 = 1; //s0 in the paper, not sure
double w2 = 1;  //seems not used by any algorithm
double r1 = 1;
boolean showProgress = false;
boolean showLoss = true;
int factors = 64;
int maxIter = 500;
double reg = 0.01;
double alpha = 0.75;
double beta = 0.2;
double ratio = 0;
double gamma1 = 0;
double gamma2 = 0;
my tunned :
String dataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_purchase";
String sidedataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_view";
String method = "vieweALS";
double w0 = 0.5; // c0 in the paper, given
double w1 = 800; //s0 in the paper, not sure
double w2 = 1;  //seems not used by any algorithm
double r1 = 1;
boolean showProgress = false;
boolean showLoss = true;
int factors = 32; // all baselines are set to 32
int maxIter = 500; // is set by default and does not matter
double reg = 0.001;
double alpha = 0.5; //not sure
double beta = 0.5; //not sure, seems that when alpha = 2 and beta = 0.5, the results is good
double ratio = 0;
double gamma1 = 3.5; // given explicitly
double gamma2 = 3.5; // given explicitly
Thank you for your consideration and time!

Please follow the Table3+last para of Sec.5.2  in the paper
run jar as
"java -jar <name_of_jar>.jar main_MF <path_of_purchase_file> vieweALS 800 False True 32 200 0.01 0 <path_of_view_file> 0.5 0 3.5 3.5"

Hi dingjingtao,
Thank you for sharing your implementation for your paper which is very inspiring.
However, I failed to reproduce the recommendation accuracies presented in the paper and even after tuning the parameters based on the paper.
Taking the dataset Tmall given in this project as an example, when using the default settings in main_MF for VALS, the HR and NDCG are only 0.0083 and 0.0020, respectively, by Iteration 20, and after tuning the parameters, HR and NDCG can still hardly exceed 0.035 by Iteration 20. These results are far lower than those presented in Figure 3 in the paper, where HR and NDCG exceed 0.06 and 0.015, respectively, in the first several iterations.
Could you please share more details about the parameters for achieving the highest recommendation accuracies? or give me some hints to achieve the results presented in the paper?
I list the default and my tunned parameters in the file main_MF below,
the default:
String dataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_purchase";
String sidedataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_view";
String method = "vieweALS";
double w0 = 0.5; // c0 in the paper, given
double w1 = 1; //s0 in the paper, not sure
double w2 = 1; //seems not used by any algorithm
double r1 = 1;
boolean showProgress = false;
boolean showLoss = true;
int factors = 64;
int maxIter = 500;
double reg = 0.01;
double alpha = 0.75;
double beta = 0.2;
double ratio = 0;
double gamma1 = 0;
double gamma2 = 0;
my tunned :
String dataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_purchase";
String sidedataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_view";
String method = "vieweALS";
double w0 = 0.5; // c0 in the paper, given
double w1 = 800; //s0 in the paper, not sure
double w2 = 1; //seems not used by any algorithm
double r1 = 1;
boolean showProgress = false;
boolean showLoss = true;
int factors = 32; // all baselines are set to 32
int maxIter = 500; // is set by default and does not matter
double reg = 0.001;
double alpha = 0.5; //not sure
double beta = 0.5; //not sure, seems that when alpha = 2 and beta = 0.5, the results is good
double ratio = 0;
double gamma1 = 3.5; // given explicitly
double gamma2 = 3.5; // given explicitly
Thank you for your consideration and time!

Please follow the Table3+last para of Sec.5.2 in the paper
run jar as
"java -jar <name_of_jar>.jar main_MF <path_of_purchase_file> vieweALS 800 False True 32 200 0.01 0 <path_of_view_file> 0.5 0 3.5 3.5"

Hi dingjingtao,
Thank you for sharing your implementation for your paper which is very inspiring.
However, I failed to reproduce the recommendation accuracies presented in the paper and even after tuning the parameters based on the paper.
Taking the dataset Tmall given in this project as an example, when using the default settings in main_MF for VALS, the HR and NDCG are only 0.0083 and 0.0020, respectively, by Iteration 20, and after tuning the parameters, HR and NDCG can still hardly exceed 0.035 by Iteration 20. These results are far lower than those presented in Figure 3 in the paper, where HR and NDCG exceed 0.06 and 0.015, respectively, in the first several iterations.
Could you please share more details about the parameters for achieving the highest recommendation accuracies? or give me some hints to achieve the results presented in the paper?
I list the default and my tunned parameters in the file main_MF below,
the default:
String dataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_purchase";
String sidedataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_view";
String method = "vieweALS";
double w0 = 0.5; // c0 in the paper, given
double w1 = 1; //s0 in the paper, not sure
double w2 = 1; //seems not used by any algorithm
double r1 = 1;
boolean showProgress = false;
boolean showLoss = true;
int factors = 64;
int maxIter = 500;
double reg = 0.01;
double alpha = 0.75;
double beta = 0.2;
double ratio = 0;
double gamma1 = 0;
double gamma2 = 0;
my tunned :
String dataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_purchase";
String sidedataset_name = "ijcai18-vals-master\data\tmall_all\Tmall_view";
String method = "vieweALS";
double w0 = 0.5; // c0 in the paper, given
double w1 = 800; //s0 in the paper, not sure
double w2 = 1; //seems not used by any algorithm
double r1 = 1;
boolean showProgress = false;
boolean showLoss = true;
int factors = 32; // all baselines are set to 32
int maxIter = 500; // is set by default and does not matter
double reg = 0.001;
double alpha = 0.5; //not sure
double beta = 0.5; //not sure, seems that when alpha = 2 and beta = 0.5, the results is good
double ratio = 0;
double gamma1 = 3.5; // given explicitly
double gamma2 = 3.5; // given explicitly
Thank you for your consideration and time!

Please follow the Table3+last para of Sec.5.2 in the paper
run jar as
"java -jar <name_of_jar>.jar main_MF <path_of_purchase_file> vieweALS 800 False True 32 200 0.01 0 <path_of_view_file> 0.5 0 3.5 3.5"

Thank you very much for your prompt reply. It works. It seems that I confused w0 and w1 previously.


Number of tags for s3 bucket object

Description
The number of tags that can be attached to an s3 bucket object is 10 AWS Documentation
For other AWS resources, this limit is 50.
So, in the case when we use more than 10 tags for the whole module we have an error

[ x ] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
It doesn't depend on terraform. It's AWS  limit.
Versions

Module version [Required]:
"terraform-aws-modules/datadog-forwarders/aws//modules/log_forwarder"
version = "4.1.1"

Terraform version:
Terraform v0.14.11

Provider version(s):
├── provider[registry.terraform.io/hashicorp/aws] ~> 4.0
├── provider[registry.terraform.io/opsgenie/opsgenie] ~> 0.6
├── provider[terraform.io/builtin/terraform]
├── module.tags
│   └── provider[registry.terraform.io/hashicorp/aws] >= 3.38.0
├── module.datadog_log_forwarder
│   ├── provider[registry.terraform.io/hashicorp/aws] >= 4.0.0
│   ├── provider[registry.terraform.io/hashicorp/null] >= 3.0.0
│   └── module.this_s3_bucket
│       └── provider[registry.terraform.io/hashicorp/aws] >= 3.75.0
├── module.labels
└── module.opsgenie_service
├── provider[registry.terraform.io/opsgenie/opsgenie] ~> 0.6
└── provider[registry.terraform.io/hashicorp/null]

Providers required by state:
provider[registry.terraform.io/hashicorp/aws]
provider[registry.terraform.io/hashicorp/null]
provider[terraform.io/builtin/terraform]
Reproduction Code [Required]
Steps to reproduce the behavior:
You need also to add more than 10 tags to the variable tags ;
variable "tags" {
  description = "A map of tags to use on all resources"
  type        = map(string)
  default     = {
  "Name.1"="a"
  "Name.2"="a"
  "Name.3"="a"
  "Name.4"="a"
  "Name.5"="a"
  "Name.6"="a"
  "Name.7"="a"
  "Name.8"="a"
  "Name.9"="a"
  "Name.10"="a"
  "Name.11"="a"
}
}

module "datadog_log_forwarder" {
  source  = "terraform-aws-modules/datadog-forwarders/aws//modules/log_forwarder"
  version = "4.1.1"

  dd_api_key = var.dd_api_key
  dd_site = "datadoghq.eu"
  forwarder_version = "3.41.0"

  bucket_name  = "s-dd-forwarder-${var.env}"
  kms_key_arn = var.cmk_arn

  role_tags = var.role_tags
  tags  = var.tags

  environment_variables = { DD_TAGS = "env:cloud-${var.env}" }
}

Expected behavior
The bucket zip object created without any tags
Actual behavior
Now the bucket zip object tags as other AWS resources, but terraform isn't applied if the tags count more than 10
Terminal Output Screenshot(s)
Error: error updating tags: error setting resource tags (s-dd-forwarder-dev/aws-dd-forwarder-3.41.0.zip): BadRequest: Object tags cannot be greater than 10
	status code: 400, request id: TE64412FP9X2M6RM, host id: QshfEqkYz3YB1fcBPsmuqZ1jfFP3a3JegL4W5b+YPqD7Vck3FwZ8nvIewvdg4hrb+HTUdZS3q1I1bjEiZ/ZQBA==
  on .terraform/modules/datadog_log_forwarder/modules/log_forwarder/main.tf line 131, in resource "aws_s3_bucket_object" "this":
 131: resource "aws_s3_bucket_object" "this" {
Cleaning up project directory and file based variables
00:00
ERROR: Job failed: command terminated with exit code 1

Additional context

I believe the solution here is to avoid prescribing more than 10 tags. How would you propose we resolve this issue for users?

Hi!
Would you happen to have any updates/solutions about the issue?
Unfortunately, we can't reduce the number of our tags, because other objects use them for filtering data.

I think the type of solution that Anton linked to would satisfy this issue - PRs are welcomed


[Feature Request] Inline preview & jump to definition for Helm Chart values

Jetbrains has great support for Helm Chart development in their IDEs. Two features are related and really great - and I would really recommend to consider implementing them:

There is no need to run an additional preview command, as the (default) values can just be seen inline in the template
It is possible to jump to a value's definition by clicking on a reference in a template

This is how it looks in a Jetbrains IDE:

YES, please do this, this is a big discrepancy relative to the Intellij plugin.

+1

Additionally auto-uncompressing the .tgz charts is something the IntelliJ version does which is very useful.


Task for pulling image

Is your enhancement related to a problem? Please describe
Related to #9536, but I found out the hard way that we don't actually have a pull image task. If you start to pull a 1.5Gb image and leave the page like I did, there's no way to see status, failure, or cancel it. You just wait and see if the image appears in the list after some period of time... or doesn't.
Describe the solution you'd like
Pulling an image should create a task, with a goto link so that you can return to the page to see updates or cancel it.
Any sort of progress would be nice for bigger images.
Describe alternatives you've considered
No response
Additional context
No response

It looks like duplicate or at least sub-issue of https://github.com/podman-desktop/podman-desktop/issues/8482.

#8482 is for push image, this is pull. It's the same problem so could maybe go under an epic together, but since they'd be delivered independently I don't think this is a dup nor should either one be a child of the other.

To me it's a dup of https://github.com/podman-desktop/podman-desktop/issues/9989

They are a bit separate but agree they overlap heavily, so I've added a comment in #9989 and closing this.


loading fine-tuned weight

Hello, I have a problem. After fine-tuning the generator and saving the model, I obtained a .pth file. When importing the model using generator = AudioSeal.load_generator('./checkpoints/generator_model_best_val_loss_20240727141622.pth').to(device), I encountered the following issues. How can I correctly load the weights?

@DanMerry Sorry for the delayed response. Could you tell me how you saved the model ?
Did you save it with the scripts checkpoints.py as shown in this PR ?

Closing since no activity, feel free to reopen


chore(main): release 0.40.0

:robot: I have created a release beep boop
0.40.0 (2024-10-16)
Features

update ext-opentelemetry to ^1.1 to support attributes (#872) (2874739)

Bug Fixes

bump cedricziel/faro-shop-php from 8.4.5 to 8.4.6 (#877) (c37e158)
bump doctrine/orm from 3.2.2 to 3.3.0 (#869) (d2b8d5c)
bump laravel/framework from 11.27.2 to 11.28.0 (#873) (0404537)
bump laravel/prompts from 0.3.0 to 0.3.1 (#874) (9bb507d)
bump phpstan/phpdoc-parser from 1.32.0 to 1.33.0 (#870) (5336baa)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

0.40.0
:sunflower:


New aka.ms link

Aka.ms link name
SharedResponsibility
Category (Optional. Select None to auto-select)
None

Thank you for submitting aka.ms/SharedResponsibility. Your link already exists at akaSearch.net. 🙏✅


Support the ON syntax in SHOW TAG VALUES

The parser was updated previously in #7295 and the functionality was
supposed to be there, but the wiring in the query engine for that to
happen was never written.
Fixes #7552.

We're going to target master and cherry pick to 1.1.


Add SetTargetFPS

Can you move the SetTargetFPS in the example as well? I think you were right when you said it should be done after InitWindow.
Thanks for fixing these!


[RFR] Spanish version

Ping @soniar4i. Does everything look fine to you here?

Yep. It looks good :+1:

Thanks so much. :)

Thank you! I was a silent contributor but I had a lot of fun :)


Support .Net Core

Hi Christian,
Any possibility that that there is Nuget package with .Net Core?
Doe is support configuring to multiple table to watch instead of Type T . One at a time.

Hi. If you need to Monitor multiple tables, you must use SqlDependency from Microsoft.

Hi, Thanks a lot for quick response.
How about support for .Net core ?
Appreciate your help.
Many thanks,

Nuget for .net core is not available. HOWEVER, sqltabledependency code should be compatible for Core. one year ago an italian develorer made changes in order to work with core and those changes are already implemented in version 6.
Current nuget does not work for core applicazions?

It does works , absolutely fine.
It just I want to make docker image and host it on Linux.
So want to make sure will it work that way ?
Thanks,

"So want to make sure will it work that way ?"...what do you mean?

So, I would say "yes, it should works".

It would be very helpful to build this against dotnet core 2.1 and package it suitably for NuGet.


Error importing cards: 'ModelManager' object has no attribute 'all_names'

Hi,
I could install the add-on fine, but got the following error message when I tried to import a course, after the course reached 100%. The deck is created but no cards are in it.
Error message:
Debug info:
Anki 2.1.35 (84dcaa86) Python 3.8.0 Qt 5.14.2 PyQt 5.14.2
Platform: Windows 10
Flags: frz=True ao=True sv=2
Add-ons, last update check: 2022-01-02 21:08:02
Caught exception:
Traceback (most recent call last):
File "C:\Users[USER]\AppData\Roaming\Anki2\addons21\memrise2anki\importer.py", line 884, in importCourse
model = self.modelMapper.getModel(thing, deck)
File "C:\Users[USER]\AppData\Roaming\Anki2\addons21\memrise2anki\importer.py", line 384, in getModel
self.__fillModelSelection()
File "C:\Users[USER]\AppData\Roaming\Anki2\addons21\memrise2anki\importer.py", line 263, in __fillModelSelection
for name in sorted(self.col.models.all_names()):
AttributeError: 'ModelManager' object has no attribute 'all_names'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users[USER]\AppData\Roaming\Anki2\addons21\memrise2anki\importer.py", line 950, in importCourse
raise exc_info0.with_traceback(exc_info[2])
File "C:\Users[USER]\AppData\Roaming\Anki2\addons21\memrise2anki\importer.py", line 884, in importCourse
model = self.modelMapper.getModel(thing, deck)
File "C:\Users[USER]\AppData\Roaming\Anki2\addons21\memrise2anki\importer.py", line 384, in getModel
self.__fillModelSelection()
File "C:\Users[USER]\AppData\Roaming\Anki2\addons21\memrise2anki\importer.py", line 263, in __fillModelSelection
for name in sorted(self.col.models.all_names()):
AttributeError: 'ModelManager' object has no attribute 'all_names'

You should update Anki, the current version is 2.1.49


Encountered error when cloning repo or downloading the release

RPC failed when trying to cloning repo.
git version 2.17.1

Encountered a decompressing error when trying the release version. You can saw that the size of the compressed file is quite small.
Ubuntu 18.04.5 LTS
Archive Manager 3.28.0 (An archive manager for GNOME.)

Now I try to download the release version from SourceForge, hope this will solve the problem

Odd about git clone failing. I wonder if GitHub that day was having issues? Does it still happen?
I can understand why zip fails to open, as that is a incomplete download. Again, possible network issues?
As far as Im aware, there isn't anything hosted on SourceForge?

Okay, I tried clone this repo again, this time it can be completed normally. Maybe something rare problem really appeared on GitHub that day :thinking:
In short, on the same day I determined that GitHub Status is all operational, but I did not further check what the problem was. This was my negligence.
As for SourceForge, I downloaded it from here:
https://sourceforge.net/projects/seclists.mirror/
It looks like it is a mirror maintained by SourceForge itself and is not part of SecLists.


cache reset problem

Reset currently does not clear the cache, so counter isn't getting assigned, as that is a cached function.  Solutions: see if you have to cache it.  Include a paramter from the session_state dict so when that resets it reruns the set_counter function.

Resolved by replacing @st.cache() with @experimental_memo.  Hopefully the only change this will require in the future is removing the 'experimental_' part.


Torsions around non-single C~S bonds

Here are some example cases:

Aromatic bonds, given a weird case.

This molecule appears in the tripos mol2 files, but not in the parm@frosst typed drugbank molecules (which includes drugbank molecules assigned the generic atom type 'gg'). This is odd, but outside the point. Other than I don't know which parm@Frosst atomtypes it gets.
Here's the section for hypervalent sulfur torsions as it is now in smirffishFrcmod
# hypervalent S-C
[*:1]~[#16X4,#16X3+0:2]-[#6X4:3]-[*:4]  1  0.000    0.0     3  Frosst X_-SO-CT-X  guess
[#6X4:1]-[#16X4,#16X3+0:2]-[#6X4:3]-[#1:4]  1  0.250    0.0     1  Frosst CT-SO-CT-H1  RHF/6-41G(d,p) Dec 12 1997
[#6X4:1]-[#16X4,#16X3+0:2]-[#6X4:3]~[#6X4:4]  1  0.800    0.0     3  Frosst CT-SO-CT-CT  RHF/6-41G(d,p) Dec 12 1997
[*:1]~[#16X4,#16X3+0:2]-[#6X3:3]~[*:4]  1  1.750  180.0     2  Frosst X_-SO-CA-X  generic guess
[#6:1]-[#16X4,#16X3+0:2]-[#6X3:3]~[*:4]  1  0.750    0.0     1   Frosst generic

Note all of these have single bonds
These are the generic C-S bonds in GAFF2 that are labeled as double bonds:
X -c2-s4-X    4   26.600       180.000           2.000      c2=s4 double bond  !!!
X -ce-s4-X    4   26.600       180.000           2.000      c2=s4 double bond  !!!
X -cf-s4-X    4   26.600       180.000           2.000      c2=s4 double bond  !!!
X -c2-s6-X    6   39.900       180.000           2.000      c2=s6 double bond  !!!
X -ce-s6-X    6   39.900       180.000           2.000      c2=s6 double bond  !!!
X -cf-s6-X    6   39.900       180.000           2.000      c2=s6 double bond  !!!

The aromatic molecule doesn't make it to the GAFF2 stage of our project so I assume GAFF2 doesn't handle the aromatic sulfur? Or something else went wrong with the molecule.
I suggest we just put a generic double or aromatic bond in the top of the C-S torsion section. It will at least be better than the aromatic bond getting the generic.
I recommend we add this line:
[*:1]~[#16:2]=,:[#6:3]~[*:4]  1   6.5    180.0    2.0  c=s double bond from GAFF2 (CCB 4/4/2017)

We could make it even more generic with an any bond in the middle, but that doesn't seem good to me as any single bond not covered by the other section would be assigned this parameter.

Added in pull request #43


Fixed issue #5095

This PR fixes issue #5095.
The following command was causing a segfault:
$ vim --clean -c 'au BufNew x center' -c 'next x'
Vim: Caught deadly signal SEGV
Vim: Finished.
Segmentation fault (core dumped)

Codecov Report

Merging #5099 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5099      +/-   ##
==========================================
+ Coverage   82.06%   82.06%   +<.01%
==========================================
  Files         134      134
  Lines      146841   146843       +2
==========================================
+ Hits       120504   120512       +8
+ Misses      26337    26331       -6

Impacted Files
Coverage Δ

src/ex_cmds.c
83.06% <100%> (+0.04%)
:arrow_up:

src/profiler.c
94.11% <0%> (-0.57%)
:arrow_down:

src/window.c
88.26% <0%> (+0.03%)
:arrow_up:

src/gui.c
63.75% <0%> (+0.05%)
:arrow_up:

src/gui_gtk_x11.c
58.35% <0%> (+0.24%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ba06b...b422f17. Read the comment docs.

Included with patch 8.1.2198


Feedback for "Set Up an HTTP Destination"

https://help.sap.com/products/BTP/65de2977205c403bbc107264b8eccf4b/3884bc38209843ac900d92adb9c2a863.html?locale=en-US&version=Cloud

Instead of creating a destination from your own Destination service instance, you can configure destinations directly on subaccount level, in the subaccount in which the ABAP instance resides (recommended).

We should change this to

Instead of creating a destination from your own Destination service instance, you can configure destinations directly on subaccount level, in the subaccount in which the ABAP instance resides or for a SaaS solution in the consumer subaccount (recommended).

Forwarded to Felix Draeger.

The site has gone through some changes. You can find the updated version here:
https://help.sap.com/products/BTP/65de2977205c403bbc107264b8eccf4b/43a5ebed034547ad8aa85250f85098a2.html?state=DRAFT&version=Dev
It now says:

Optional: i_service_instance_name: Typically, you use the destinations of the subaccount in which the ABAP instance resides. However, you can add more destinations using your own destination service instance and communication scenario SAP_COM_0276, for example, to achieve separation of concerns (see also Create a Destination). In this case, specify the value of the service instance name property of the communication arrangement for SAP_COM_0276.

Let me know if I can do any correction.

Yes, please change the sentence "Typically, you use the destinations of the subaccount in which the ABAP instance resides" to "Typically, you use the destinations of the subaccount in which the ABAP instance resides or, in case of a SaaS solution based on ABAP Environment, the destinations of the consumer subaccount." This is necessary because in case of a SaaS solution the destinations have to be in a different subaccount from where the ABAP instance resides in.


[Designer] Update container styling to fix overflow and sizing

Related Issue
Fixes #7883
Description
Updated the berlin styling to use margins instead of padding because overflow was not working properly.
Also adjusted the height and width because the border is not included in the given sizes.
How Verified
Verified manually on the Adaptive Cards site.
Microsoft Reviewers: Open in CodeFlow

@JeanRoca When is a good time to make this update?

@JeanRoca When is a good time to make this update?

I spoke with Amanda and she suggested we can take the change as long as it does not impact our partners. I was doing some testing and noticed a couple of things with the new margin.

Background images are not bleeding outside the margins.
PR

Current designer

Carousel controls should also bleed into the margins so they don't disappear.

The only 3 things that should be allowed to extend past the margin are carousel pagination dots, carousel next/prev arrows, and background images (either set at the AC level or set in something like the carousel which supports bleed for background images). Let me know if you think of any others that should be able to extend past the margins.
Once these changes are made we can test to make sure it does not impact partners and go from there. Thanks Anna :)


amarok: add last.fm support, bump version

Motivation for this change
This PR bumps amarok to the most recent commit in master and adds liblastfm as a dependency to make use of the last.fm integration that has been re-enabled in upstream master (it was disabled for a while due to breakage on Qt5).
I also had to tweak the build of liblastfm itself, since the expression in nixpkgs was Qt4-only. Now it builds on Qt5 by default (as libsForQt5.liblastfm), but I've retained a liblastfm_qt4 so that clementine doesn't break. This addresses one of the checkboxes in #33248.
I also reverted #58353 for reasons explained in this comment (not sure whether this is the right thing to do, but let me know what you think).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Anyone know why @ofborg removed the qt/kde label that @prusnak added to this PR?

Anyone know why @ofborg removed the qt/kde label that @prusnak added to this PR?

Because @ofborg is the boss here :satisfied:.

Let's drop Qt 4 version of liblastfm #89821

Do you want me to rebase on your branch? It looks like your branch subsumes most of what I did in this PR. All that's left is the bumping of Amarok and the addition of liblastfm to its buildInputs.
Your approach to porting liblastfm to Qt5 is different from mine, which just pulls some unreleased commits from the liblastfm repo. I'm not sure which is the better strategy. Your fix certainly seems simpler than mine, at least. The patches I'm using seem to be what a few other Linux distros use, though, e.g. Gentoo and Arch.

@kini With the patch would be also fine, but preferably need to fetch from the upstream commit. I'm just doing the minimal change to fix things. Interested parties could look into bumping liblastfm to the latest unstable version.

@veprbl One of the patches is from a PR on the upstream repo that has been open for a couple of months (the maintainer doesn't seem to be responding to it). Is it OK to fetch from this PR?

@kini Fetching from an unstable url like https://patch-diff.githubusercontent.com/raw/lastfm/liblastfm/pull/36.patch may be irreproducible, it will cause a hash mismatch if the PR is updated. Fetching with a specific commit hash like https://github.com/lastfm/liblastfm/pull/37/commits/9c5d072b55f2863310e40291677e6397e9cbc3c2.diff might work better.

@veprbl Thanks. I pushed a commit that updates liblastfm to liblastfm-unstable-2019-08-23 (the latest master) and then applies that open PR's patch.
One more question -- should the liblastfm attribute in all-packages.nix be moved inside the Qt5 library list, in the mkLibsForQt5 attribute? Not sure what the conventions are here.

One more question -- should the liblastfm attribute in all-packages.nix be moved inside the Qt5 library list, in the mkLibsForQt5 attribute? Not sure what the conventions are here.

That seems reasonable to me.
cc @ttuegel

OK, thanks -- made that change too.

Thanks you!


OPC Publisher API - BrowserNext request returns BadContinuationPointInvalid error and does not allow to browse all child nodes.

Describe the bug
We are right moving from the old OPC Twin (2.8.6) to the new Publisher (2.9.4) module. We used direct methods - Browse_V2 and BrowseNext_V2 to find all child nodes. And in old OPC Twin (2.8.6) everything worked correctly. But in the new Publisher (2.9.4) we are faced with the issue that requesting BrowseNext via HTTP or via MQTT returns only one successful response, and with the second request returns an error:
{   "references": [],   "errorInfo": {     "statusCode":<PHONE_NUMBER>,     "symbolicId": "BadContinuationPointInvalid"   } }
To Reproduce
Steps to reproduce the behavior:

Start OPC Publisher with mqtt transport and configuration api enabled.
Start Kepserver with sufficiently many nodes in a single folder. So that you can request BrowseNext more than 2 times. For example you need at least 41 if the page size is 20. Or you can reduce the maxReferencesToReturn.
Make the first request to BrowseFirst (/v2/browse/first). In the response we see the first 20 nodes and ContinuationToken = `"AA==".

request "/v2/browse/first":
{     "connection":     {         "endpoint":         {             "url": "opc.tcp://<IP_ADDRESS>:50000",             "securityMode": 3,             "securityPolicy": "http://opcfoundation.org/UA/SecurityPolicy#None"         }     },     "request":     {         "nodeId": "nsu=KEPServerEX;s=SQL.Device1",         "direction": 0,         "maxReferencesToReturn": 20,         "readVariableValues": false     } }

Make the first request to BrowseNext (/v2/browse/next) with ContinuationToken. In the response we see the second 20 nodes and ContinuationToken  = `"AA==".

request  "/v2/browse/next":
{     "connection":     {         "endpoint":         {             "url": "opc.tcp://<IP_ADDRESS>:50000",             "securityMode": 3,             "securityPolicy": "http://opcfoundation.org/UA/SecurityPolicy#None"         }     },     "request":     {         "continuationToken": "AA=="     } }

Second request to BrowserNext (/v2/browse/next) with ContinuationToken returns error - statusCode =<PHONE_NUMBER>,  symbolicId = BadContinuationPointInvalid.
The same steps to reproduce using MQTT request/response.

Expected behavior
BrowseNext (/v2/browse/next) should return all child nodes by ContinuationToken.
Behavior should be the same as with OPC Twin. Using ContinuationToken we can get all child nodes.
Additional context

Publisher version: 2.9.4.
Kepserver version: 6.9.

Publisher settings:
                    "publisher1": {                         "settings": {                             "image": "mcr.microsoft.com/iotedge/opc-publisher:2.9.6",                             "createOptions": "{\"Hostname\":\"publisher\",\"Cmd\":[\"-c\",\"--pf=/appdata/publisher1.json\",\"--aa\",\"--fullfeaturedmessage=true\",\"--batchsize=10\",\"--batchtriggerinterval=1000\",\"--messagingmode=Samples\",\"--opcpublishinginterval=1000\",\"--opcsamplinginterval=1000\",\"--trustmyself=true\",\"--di=10\",\"--loglevel=___LOG_LEVEL___\",\"--defaultmessagetransport=Mqtt\",\"--mqttclientconnectionstring=HostName=___BROKER_HOST___;Port=___BROKER_PORT___;Username=___BROKER_USERNAME___;Password=___BROKER_PASSWORD___;UseTls=false;Protocol=v5\",\"--api-key=___PUBLISHER_CONFIGURATION_APIKEY___\",\"--immediatepublishing=true\",\"--roottopictemplate=root\",\"--telemetrytopictemplate=root/opc-publisher\",\"--methodtopictemplate=root/opc-publisher/methods\",\"--mdt=root/opc-publisher/metadata\", \"--qs=1000\", \"--removedupsinbatch=true\"],\"HostConfig\":{\"PortBindings\":{\"62222/tcp\":[{\"HostPort\":\"62222\"}]},\"Binds\":[\"/appdata:/appdata\"],\"LogConfig\":{\"Type\":\"json-file\",\"Config\":{\"max-size\":\"___LOG_MAX_SIZE___\",\"max-file\":\"___LOG_MAX_FILE___\"}}}}"                         },                         "type": "docker",                         "version": "1.0",                         "status": "running",                         "restartPolicy": "always",                         "startupOrder": 100                     },

I was able to replicate this as well. Using the very same kepserver, using opctwin and opcpublisher and direct method calls, I am able to browse multiple pages of signals using the twin, but with the publisher I'm only able to do the first request.

I added a test (https://github.com/Azure/Industrial-IoT/blob/45d88c14b077c78e17bee46e1813b795db56898c/src/Azure.IIoT.OpcUa.Publisher.Module/tests/Mqtt/TestData/BrowseTests.cs#L164) and that works fine.  I see the issue if the continuation token is passed again, maybe that is what happens somehow.

Could you try with 2.9.7?

@marcschier Are you running these tests aginst a real OPCUA server, and if yes, against which implementation? We were not able to replicate this behaviour using the opcplc simulator - they seem to behave differently when it comes to continuation tokens (specifically, they return a new continuation token for each new BrowseNext request). However, with a default Kepserver installation (you can get the trial license which works for 2 hours for free) it doesnt work.
That beeing said, Ill try against 2.9.7 next week.

Correct, all our tests run against opc-plc as well as the official opc foundation reference servers.  Kepserver returns the same token every time?  Is that how it behaves?

@mregen FYI

Yes, thats true. Specifically, I'm always recieving the token AA== for Kepserver. Using the OPC Twin, I can pass this very same token again and again (in fact, the request is exactly the same in that case every time) to the twin, and are able to browse multiple pages of data.
I can provide you with a publicly accessible Kepserver instance to test this against, if needed.

I think in between calls to next the session was garbage collected.  Can you set a large longer timeout using '--cl' option to ensure the session stays live between browsenext calls?  If you see the issue, can you check in the log if the client went to state disconnected?

I can confirm setting this value enables me to browse our kepserver again, thanks!

The publisher has a feature that tracks continuation tokens on an active connection so that the connection is not collected.  The issue happens if a new tracked token and the previous token are the same, in which case the new tracked token is added to the ref count list (where it already is) and the same token then later is removed, closing the session.  This also has been fixed.  --cl is recommended though when using any higher volume service calls to keep the session lingering for fast reuse on other calls.


remove console.log when defining mousedown effect

While implementing the Listbox interface, I noticed the browser console kept outputting 'mousedown'.
https://github.com/baleada/vue-features/blob/fcdc8e0bbfbf2d526c382d468125fcfcc598c25e/src/extracted/useFocusedAndSelected.ts#L318

Thanks @lebrauncom! Will do a new patch release sometime this week with the change

@lebrauncom finally got this released by the way! Along with some other minor bugfixes I found while working on the React implementation of this library for the last few weeks.


Switching camera ends stream

Hi @AndrewShapovalov
Thanks for the update earlier! I don’t know if it’s necessarily a new issue, but when I switch camera the screen almost reloads and the Live broadcast ends. The app does not crash and from the streamers point of view it looks like you are still broadcasting live. There were no error messages in app.

Hi @chrisedington!
I've never encountered such problem. Have you tried running the sample app and reproduce the same behaviour?

Hi @chrisedington! Any updates?

Hi @AndrewShapovalov, sorry I didn't close this.
Issue was application side, all good thank you.


Check for "cloudCurrent" field when comparing local vs cloud

Our sync algorithm wasn't pushing local changes in all cases.
Also improves our ticks during conflict resolution.
Fixes: https://github.com/microsoft/pxt-arcade/issues/3254
might fix this too: https://github.com/microsoft/pxt-arcade/issues/3228
but since I don't have a consistent repro it's hard to say. Certainly the window for conflicts is larger without this PR since changes are synced less often.

@eanders-MS , mind approving or offering critique?


trailing newlines break messages

Try pasting
This
is a message.

into the syncplay chat on one line. The entire message will display in mpv, but not in the syncplay window: anything past the first newline will get truncated.

Thanks for reporting this. It should be resolved by PR #301.


Adding tests & a few optimizations

Tests
For reproducibility, a seed is given as input into SuStaIn, and used throughout so that results are consistent for a given seed (and parameters).
This enables a full functional test of SuStaIn. I've added two scripts to check the output from SuStaIn (in the "tests" subfolder): create_validation.py is for creating new validation benchmarks, and validation.py is for checking results are consistent with these benchmarks.
A full test (-f command line flag for validation.py) uses every class that inherits from AbstractSustain. The relevant test functions are @abstractmethods, so this should scale with future additions/subclasses. This also means that the simulator functions are now a part of the class they pertain to (though I haven't removed the "sim" subfolder for now).
Note that the test for ZscoreSustainMissingData is currently a copy of the ZscoreSustain one, and in the near future will be modified to better test the missing data handling.
Optimizations
Part of the motivation for the tests was to make a couple of optimizations, namely vectorizing a couple of the main loops.
In a test experiment, the running time was reduced in the z-score version from ~15.5 hours to ~10 hours. The speed up is less significant for the mixture model version (~2.1 hours to ~1.68 hours).
Feel free to ask if you want details, but it's a lot to add here and ultimately not interesting.
Other Changes

Replaced the print statements for iterations with tqdm, as it's more informative and compact.
Adding a plot argument to AbstractSustain.run_sustain_algorithm to avoid always plotting.

High-level, this all looks great. Anyone wanna check the details?


Implement dataview.remove()

Use-case is that we'll need to support removing widgets, which should have the side-effect of removing the underlying dataview (and internally filter, and whatever else might be necessary). See https://github.com/CartoDB/deep-insights.js/issues/90 for more details.
Final scope TBD
cc @alonsogarciapablo

done in #1025


[HOLD for payment 2024-08-19] [Fullstory] Initializing the Onyx object to identify the user when they have an infinite session on New Dot

Problem:
Initializing the Onyx object on SignInWithShortLivedAuthToken will make it so a user on Classic with an infinite session, on redirect to New Dot will now be identified in FS. But if they were already on New Dot, and had an infinite session, we will not identify them till they explicitly login next.
Solution:
Initialize this object on OpenApp/Reopen App as well.
Note: While we do this, can we also make it so the Onyx object includes the tryNewDot.classicRedirect.dismissed
If that is true - send true, if false then send false
If that NVP does not exist, send empty

This is done, there's no payment to be made


refresh dmm ipython notebook

this constitutes (hopefully most but probably not all) the changes needed to refresh the dmm notebook.
i suggest we merge these sorts of things without excessively detailed reviewing. then when a number of these changes have been merged, we can do a round robin review of some sort that ensures each tutorial was carefully read by at least one person other than the author.

did you test that the html renders correctly when built locally?
no i've never been able to get that to work locally (tried again; failed)
are these code changes reflected in the examples source code?
i'm still working in the PR to sync things. there's no need to do that right away since no one will be pushing the html anyway


Repeated onboarding process

After a new user is registered, sign out, sign in again, have to do the onboarding procedure again.

This is due to error "WALLET_NOT_EXIST" not being cleared, causing setNewUserTag to be invoked


Inline component view affects component styling

When using inline component view, the styling of the info pane affects the styling of the component

Fixed with #34


Unable to reach app. Please try again.

Hi,
I followed the deployment document, the issue what I am getting now is when user tries to send a question to Expert is gives below error to the user "Unable to reach app. Please try again.". See attached screenshot for the same.

We could not repro the issue.
Can you please validate the configuration values especially the team link and let us know still if issue persists.


🐞 -  Ionic Input does not follow masking regex.

Which package(s) are the source of the bug?
@maskito/core, @maskito/angular
Playground Link
not have one
Description
In a Capacitor 6 / ionic 8 project I used the maskito directive with this regex:
 readonly cardMask: MaskitoOptions = {
    mask: /^\d{1,4}(,\d*)?$/,
  };

The input was receiving the first 4 numbers then it would stop and shuffle the new number in.
I even tried a more elaborate regex:
/^\d{1,4}|\d{1,4},|\d{1,4}(,\d*)?$/
still the input would not let me insert a comma. The regexs work in a stackblitz, so i suppose there is a problem with field manipulation in angular.
Here is my input:
<ion-input
          type="number"
          formControlName="price"
          placeholder="Inserisci il prezzo"
          [maskito]="cardMask"
          label="Prezzo"
          labelPlacement="stacked"
></ion-input>```

### Maskito version

3.0.0

### Which browsers have you used?

- [X] Chrome
- [ ] Firefox
- [ ] Safari
- [ ] Edge

### Which operating systems have you used?

- [ ] macOS
- [ ] Windows
- [ ] Linux
- [X] iOS
- [X] Android

@filipelle Hello!
Provide reproduction (for example, github repository), please.
It's difficult to help you without it.
Also, attach video with you problem.

I've created stackblitz with you described case (angular 17 + Ionic 8 + your mask):
https://stackblitz.com/edit/maskito-ionic-angular-1434
I can't reproduce you problem in it(

Closing this issue due to the lack of reproduction.
Feel free to open a new issue again with the full reproduction of the problem.


[QUESTION] What URL should I use for OpenIdConnect?

I am using an external OAuth2 service for SSO which is basically a Keycloak  server.
So far I have been able to use the implicit flow:
base_url = "https://some.keycloak.server.com/auth/realms/main/protocol/openid-connect/"

oauth2_scheme = OAuth2(
    flows=OAuthFlows(
        implicit=OAuthFlowImplicit(
            authorizationUrl=base_url + "auth" + "?client_id=my-app-id"
        )
    )
)

With this code I get the following prompt when I press authorize:

What is strange here is that I cannot prefill the client_id prompt, so I have to give it an hard coded query header in the authorizationUrl. If I do this, swaggerUI ignores what I write in the client_id prompt, but I am redirected into the SSO website and everything works fine.
But in reality, I should just be able to use the OpenIdConnect security scheme:
oauth2_scheme = OpenIdConnect(openIdConnectUrl=base_url)

So far, I've tried many combinations of URLs, but none of them work, including the automatic discovery URL that is said in the documentation:
https://some.keycloak.server.com/auth/realms/main/.well-known/openid-configuration
So my question is what is the expected URL from the API?
I checked the endpoints in https://connect2id.com/products/server/docs/api, but none of them worked.
Thanks! 😄

When you go to:
https://some.keycloak.server.com/auth/realms/main/.well-known/openid-configuration
You will retrieve an json output with keys and values.
One of the keys is 'authorization_endpoint', the value should be used as authorizationUrl.

I tried that but I get an empty window when I press the authorize button:

Is this problem on the keycloak's server end then?

You might need to set a scope, my code:
OAUTH2_SCHEME = OAuth2(
    flows=OAuthFlows(
        implicit=OAuthFlowImplicit(
            authorizationUrl="some_authorization_endpoint_url",
            scopes={"scopekey": "scopevalue"},
        )
    )
)

Could you also take a look at the generated openapi.json?
Based the code above, the generated openapi.json, should have the securitySchemes value:
"securitySchemes": {
    "OAuth2": {
        "type": "oauth2",
        "flows": {
            "implicit": {
                "scopes": {
                    "scopekey": "scopevalue"
                },
                "authorizationUrl": "some_authorization_endpoint_url"
            }
        }
    }
}

But the implicit flow that you linked works for me, the problem is when I try to use the class OpenIdConnect. This class only takes one argument openIdConnectUrl that is not documented - in my opinion it should use https://some.keycloak.server.com/auth/realms/main/.well-known/openid-configuration but it doesn't seem to work.

Swagger UI doesn't support OIDC:

OpenID Connect Discovery | Swagger UI
OIDC is currently not supported in Swagger Editor and Swagger UI. Please follow this issue for updates.

Reference Swagger UI | OpenID Connect Discovery

What is strange here is that I cannot prefill the client_id prompt

See #499

Thanks for the help here @zamiramir ! :bow: :clap:
Thanks @littlebrat for coming back to close the issue. :+1:


Running Dependabot@2 causing 500 internal sql exception via pipeline in ADO

Describe the bug
I've added the dependabot extension to our ADO.  When I try to go and run the pipeline to run dependabot, it gives me the following error:
🌎 🠊 [POST] https://dev.azure.com/EnvisionTechnologyPartners/WebIZ/_apis/git/repositories/WebIZ.Graph/pullrequests
🌎 🠈 [500] Internal Server Error
{"$id":"1","innerException":null,"message":"TF400898: An Internal Error Occurred. Activity Id: b7ecf655-43d8-42bc-bf5b-e093cf56dce6.","typeName":"Microsoft.Data.SqlClient.SqlException, Microsoft.Data.SqlClient","typeKey":"SqlException","errorCode":0,"eventId":0}
##[error]Failed to create pull request: Error: Request to 'https://dev.azure.com/EnvisionTechnologyPartners/WebIZ/_apis/git/repositories/WebIZ.Graph/pullrequests' failed: 500 Internal Server Error
Error: Request to 'https://dev.azure.com/EnvisionTechnologyPartners/WebIZ/_apis/git/repositories/WebIZ.Graph/pullrequests' failed: 500 Internal Server Error
at AzureDevOpsWebApiClient.restApiRequest (/home/vsts/work/_tasks/dependabot_d98b873d-cf18-41eb-8ff5-234f14697896/2.36.1003/utils/azure-devops/AzureDevOpsWebApiClient.js:521:23)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async AzureDevOpsWebApiClient.restApiPost (/home/vsts/work/_tasks/dependabot_d98b873d-cf18-41eb-8ff5-234f14697896/2.36.1003/utils/azure-devops/AzureDevOpsWebApiClient.js:498:16)
at async AzureDevOpsWebApiClient.createPullRequest (/home/vsts/work/_tasks/dependabot_d98b873d-cf18-41eb-8ff5-234f14697896/2.36.1003/utils/azure-devops/AzureDevOpsWebApiClient.js:188:33)
at async DependabotOutputProcessor.process (/home/vsts/work/_tasks/dependabot_d98b873d-cf18-41eb-8ff5-234f14697896/2.36.1003/utils/dependabot-cli/DependabotOutputProcessor.js:67:42)
at async DependabotCli.update (/home/vsts/work/_tasks/dependabot_d98b873d-cf18-41eb-8ff5-234f14697896/2.36.1003/utils/dependabot-cli/DependabotCli.js:113:51)
at async run (/home/vsts/work/_tasks/dependabot_d98b873d-cf18-41eb-8ff5-234f14697896/2.36.1003/index.js:75:57)
I am able to see that the branches get created successfully however the PRs fail to get created.  I've reached out to MSFT and they've asked me to contact Tingle instead since they believe the error is happening when the request is coming from Dependabot.
Categorization

[ ] This is not a permissions issue (Seek help at https://github.com/tinglesoftware/dependabot-azure-devops/discussions/1245)

Repository
URL: e.g. https://dev.azure.com/tingle/dependabot/_git/repro-684

I'm more than happy to do a screen share upon request.
To Reproduce
Steps to reproduce the behavior:

Run the pipeline

Expected behavior
I expect dependabot to successfully run and create the PRs for review.  At the moment, it is only creating the branches and then failing on a 500 error as described above.
Logs and screenshots
[If applicable, include relevant logs or screenshots to help explain your problem.
See extension troubleshooting for more on how to collect additional diagnostic logs.
]
https://app.screencast.com/H9yNtrJEknYSh
https://app.screencast.com/acJoiTt6DtxRi
Extension (please complete the following information):

Dependabot@2

Server (please complete the following information):
N/A
Additional context
Add any other context about the problem here.

Hi,
Is there any updates on this?
Moua Xiong

From: Rhys Koedijk @.>
Sent: Monday, October 28, 2024 7:03 PM
To: tinglesoftware/dependabot-azure-devops @.>
Cc: mouaxiong1980 @.>; Mention @.>
Subject: Re: [tinglesoftware/dependabot-azure-devops] Running @.*** causing 500 internal sql exception via pipeline in ADO (Issue #1438)
@mouaxiong1980https://github.com/mouaxiong1980 thanks for the report.
Are you able to share the relevant parts of your dependabot.yml file for this update?
Unfortunately the error returned by DevOps is not very useful and doesn't help identify what is wrong with the request.
We might be able to narrow it down by understanding your configuration better. The values sent to DevOps during this API call are:

sourceRefName: this can be found in your repo branches as you mentioned it was already created.
targetRefName: this is set from "target-branch" config in your dependabot.yml, or it is the name of the default branch if not set in dependabot.yml
title: this can be found your task output log if you scroll up a bit from the "[500] Internal Server Error" message
description: this can be found your task output log if you scroll up a bit from the "[500] Internal Server Error" message
reviewers: this is set from "reviewers" and "assignees" config in your dependabot.yml
workItemRef: this is set from "milestone" config in your dependabot.yml
labels: this is set from "labels" config in your dependabot.yml

Are you able to determine what these values would have been be so we can eliminate them as being an issue?
—
Reply to this email directly, view it on GitHubhttps://github.com/tinglesoftware/dependabot-azure-devops/issues/1438#issuecomment-2442897605, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT4XTE3V5JELFTUAASUUGF3Z53GFNAVCNFSM6AAAAABQXVR6G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBSHA4TONRQGU.
You are receiving this because you were mentioned.Message ID: @.***>

Is there any updates on this?

I haven't had a chance to look in to it further yet, but hope to sometime over this weekend.
I do see that you are using assignees/reviewers. If you haven't already, it might be worth like commenting out these in your dependabot.yml file and seeing if that allows the PR to be created; If so, that would certainly narrow down the problem area.

@mouaxiong1980 my best guess is that there is a duplicated identity in your assignee/reviewers list. I can for example see that "Team 3" is listed as both an assignee and reviewer, this might also be true for the masked email address.
I have submitted a change in https://github.com/tinglesoftware/dependabot-azure-devops/pull/1457 that will filter out duplicated identities. Until this is merged, you can probably work around this issue by manually removing duplicates in your dependabot.yml config.

Thanks for the update.  Simply commenting out the assignee and reviewee seemed to have fixed the issue for now.  From your comment, are you also saying that we shouldn't have the same entity/person assigned as a reviewee and assignee?  I just want to understand this setting.  Thanks.
Moua Xiong

From: Rhys Koedijk @.>
Sent: Sunday, November 10, 2024 10:14 PM
To: tinglesoftware/dependabot-azure-devops @.>
Cc: mouaxiong1980 @.>; Mention @.>
Subject: Re: [tinglesoftware/dependabot-azure-devops] Running @.*** causing 500 internal sql exception via pipeline in ADO (Issue #1438)
@mouaxiong1980https://github.com/mouaxiong1980 my best guess is that there is a duplicated identity in your assignee/reviewers list. I can for example see that "Team 3" is listed as both an assignee and reviewer, this might also be true for the masked email address.
I have submitted a change in #1457https://github.com/tinglesoftware/dependabot-azure-devops/pull/1457 that will filter out duplicated identities. Until this is merged, you can probably work around this issue by manually removing duplicates in your dependabot.yml config.
—
Reply to this email directly, view it on GitHubhttps://github.com/tinglesoftware/dependabot-azure-devops/issues/1438#issuecomment-2467196460, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT4XTE5PLZDB3WOP4YRRL5D2AAVJJAVCNFSM6AAAAABQXVR6G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRXGE4TMNBWGA.
You are receiving this because you were mentioned.Message ID: @.***>


SAK-29025 add date to meeting timeslot dropdown

Hi Brooke,
Note that your pull request is coming from your master. The recommended path is to create a distinct branch for every pull request.  Because it's coming from your master branch, there are multiple, distinct commits as part of this pull request.
https://help.github.com/articles/using-pull-requests/

Thanks Sam,
I realized I did that after the fact.  I create them from distinct branches.
Brooke


Emailfake.com

Please add: azwev.site

What is the provider of this domain please? We add with the providers.

Emailfake.com

Emailfake.com is already being watched, they do have tons of domains but we slowly add them automatically. Thanks. Just added nolog.email & tempo-email.com


make the quote symbol configurable for import codefix

currently the import codefix uses double quotes for module path strings literals which makes our linter unhappy, i wish the choice of a quotes was configurable

Yes please, this is very frustrating.

the temporary fix is rather trivial if you go ./node_modules/typescript/lib/*.js and look for "\""

It'd be great if this was just inferred in cases where the option isn't explicit.

yeah, just look around and do it as in 90% cases

another thing to consider is that since codefixes emit "typescript" (not javascript, i beg you) code, the emitter should comply to some standards
namely the quote mark should be configured at the top level of the codefix emitter configuration, so that any codefix out there used it for emitting a propert quote symbol

A related thing to consider are quick fixes of missing interface implementations. The array type declarations should also be configurable.
For example SomeType[] versus Array<SomeType>.

do you have any idea when it is going to be fixed?

@mhegazy Marking as high-property for VSCode since we've seen a fair number of reports of this. We could add a workaround on our side to replace the quotes but other consumers of TypeScript would also benefit from this. Can we please target 2.3 with a fix?

Where should the configuration for this be stored?
I like the idea of inferring from the current file, though. It seems fine to make the user fix the first one themselves then the remainder are "correct"

Inferring from the current file would be great. If there is nothing to infer from yet, it would be awesome if the tool could try to find a configuration for the tslint quotemark rule. Currently in VS Code I use auto import code fix, followed by the tslint code fix to change from double to single quote.

Making it configurable is overkill. Just find the first quote character used the file and use that.

I agree with pgrm. The tslint.json quotemark rule is the perfect place to infer from.

Is there any precedent for TypeScript reading directly from tslint configuration?

It would seem crazy to couple tsc to tslint.json for the corner case when there are zero quotes in the file. Just use either default value and let the user fix it for the first one.

For other folks looking for a workaround: if you use vscode, "tslint.autoFixOnSave": true in your settings.json will automatically fix these import quotations when you save the file. If you're importing something, you're going to save it anyway, right?

Agree with @RyanCavanaugh it should either be inferred from existing imports or perhaps controlled by tsconfig?

Would be more consistent, as tslint is a optional tool for TypeScript, that there is a new option in tsconfig.json for quotes (which would also be the easiest thing to implement in TypeScript than scanning the files), and then that tslint can recover it in the future.

This is not just about quotes imo. Similarly, the spacing in imports should be configurable as well (import { blah } from 'module' vs import {blah} from 'module').

Also, using relative vs absolute paths on the import statements is an issue.  IMHO, giving the user setting, by language, whether to use some type of linting or whether to use user settings would be ideal for me.

@billfranklin the path will be absolute if you add baseUrl to compilerOptions in `tsconfig.json'

Yeah, semicolon is an issue too.

As @adyavanapalli very well mentioned, you can edit the typescript.json file to get around this issue on /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript/snippets/ for MacOS and C:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\typescript\snippets\ for Windows.
Thx buddy.

As @adyavanapalli very well mentioned, you can edit the typescript.json file to get around this issue on /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript/snippets/ for MacOS and C:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\typescript\snippets\ for Windows.
Thx buddy.

We have a similar issue in Angular CLI, and the approach we took was to allow our code generation to automatically run TS Lint on generated files with --fix. A bit of a overhead but it's really the only way to allow for the myriad of stylistic preferences.

@lukeautry For other folks looking for a workaround: if you use vscode, "tslint.autoFixOnSave": true in your settings.json will automatically fix these import quotations when you save the file. If you're importing something, you're going to save it anyway, right?

Note that this only works if you have the TSLint extension installed from here: https://marketplace.visualstudio.com/items?itemName=eg2.tslint

@lukeautry For other folks looking for a workaround: if you use vscode, "tslint.autoFixOnSave": true in your settings.json will automatically fix these import quotations when you save the file. If you're importing something, you're going to save it anyway, right?
Note that this only works if you have the TSLint extension installed from here: https://marketplace.visualstudio.com/items?itemName=eg2.tslint

Besides, what if I don't want tslint to fix other possible errors in my code?

@Maximaximum good point. I would still like auto-import feature to have an option to import with single or double quotes as configuration option.

This may be out of scope of this issue, but I would also like to see us have the ability to change from a root based path to a relative path.
Using a root based path breaks our current build process, as we have multiple root entry points depending on the configuration.

@mhegazy maybe include this simple fix/feature in the nearest release?

adding  "prettier.singleQuote":true, did the trick for me

It may be obvious, but I still think it is worth mentioning: you do not have to update your full project to the latest TypeScript if you are using Visual Studio Code. Just switch the editor to built-in version:
Click TypeScript version number (for example 2.3.4) between "TypeScript" and a little smiley face in the lower right corner. Then switch to Visual Studio Code built-in version (2.5.3 at this moment).

Now, the quotestyle is not correctly inferred. Single quotes are always used, independent of previous usage of double quotes in import statements. Can't we simply make it configurable?

 However, it's important to maintain consistent style, at least within a signle project

no doubt consistent style is very important
single-quoted strings are more preferable in JavaScript that deals with HTML and XML (97% of all applications) because it saves your from conflicts with double quoted strings used by said standards

@aleksey-bykov there is no "better" - just personal preference.  If you're using HTML/XML it's probably best to use the backticks `.

i am just looking for any evidence (besides personal taste) that double quoted strings are worth being the default choice

Here's some evidence: Prettier is using double quotes. With everybody gradually adopting prettier, we'll be back to double quote world soon.
Can't believe this bikeshedding is still going on - is it because the inference logic had a bug?

@vivainio prettier has a --single-quote option.

@vivainio

Can't believe this bikeshedding is still going on - is it because the inference logic had a bug?

This was never a bug. This is a feature request. Also, it works correctly in the nightly builds. It's been fixed for a while.
@mickdekkers @vivainio

Here's some evidence: Prettier is using double quotes. With everybody gradually adopting prettier, we'll be back to double quote world soon.

Why would I want another formatter operating on my *.tsx? files? I already have TypeScript and TSLint. Maybe if you are using a linter that does not format it would make sense. Everyone should use a linter.

Today I've found out that the bug came back.
While using VS Code, when I use Typescript v2.6.1 (the VSCode's version), the codefix uses single quotes, which is what I need.
However, when I switch to my project's version (Typescript v2.4.2), the codefix always uses double quotes.
Is there a way to force VSCode to use single quotes while runing Typescript v2.4.2? Do we need to apply a bugfix to Typescript v2.4.2 and release a new, patched version 2.4.3?
Note: I can't upgrade to use Typescript v2.6.x in my project right now.

@Maximaximum This is only fixed in TS 2.5+. There is no way to fix this with older TS versions

@mjbvz Ok, thanks for letting me know

How do I disabled semicolons in auto imports?

tracked by https://github.com/Microsoft/TypeScript/issues/19882

@mhegazy Hey thanks, I did that, but still the same, do I need to specify to use ts importer somehow? I still get a ; with auto imports

the suggestion of having semicolons being configurable is tracked by #19882. I did not say it was implemented.

@mhegazy Oh, still, any idea? xd
And do you know if the line numbers can be disable or at least made shorter? they occupy a lot of space :(

@filipef101 line numbers are a general text editor feature. How are they related to TypeScript?

Comented in https://github.com/Microsoft/vscode/issues/23559#issuecomment-302378477:
As @adyavanapalli very well mentioned, you can edit the typescript.json file to get around this issue on /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript/snippets/ for MacOS and C:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\typescript\snippets\ for Windows.
Thx buddy.

On VS Code 1.21.1 you can correct this editing /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/typescript-basics/snippets/typescript.json

On Ubuntu Linux (VS Code 1.21.1), you need to edit /usr/share/code/resources/app/extensions/typescript-basics/snippets/typescript.json.
In the 'Import external module' section of that file make the body array property to be the value "import { $0 } from '${1:module}';" The whose section will then look like this:
	"Import external module.": {
		"prefix": "import statement",
		"body": [
			"import { $0 } from '${1:module}';"
		],
		"description": "Import external module."
	},

Since VSCode 1.24 (June 2018) there is an option for configuring this.
https://code.visualstudio.com/updates/v1_24#_preferences-for-auto-imports-and-generated-code

Since VSCode 1.24 (June 2018) there is an option for configuring this.
https://code.visualstudio.com/updates/v1_24#_preferences-for-auto-imports-and-generated-code

Since VSCode 1.24 (June 2018) there is an option for configuring this.

But the import statement completion still gives you double quote :disappointed:

@imcotton only works with TypeScript 2.9 and higher from what I can find

Where is the fix? I have been going for an issue to an issue .. related to duplicated ... where is the fix? I have the latest version of vscode and still getting the double quote

@MurhafSousli https://code.visualstudio.com/updates/v1_24#_preferences-for-auto-imports-and-generated-code
If you are still getting the double quote then your preferences.quoteStyle are probably either set to "double" or "auto". If it is set to "auto" (the default) then it infers the import style from existing imports. If there are no existing imports, then I believe it defaults to double quote. You can change preferences.quoteStyle (see above link) to "single" if you always want single quotes.

Recent update, the auto generated import is working as expected with single quotes. As for auto generated snipets these are still double quoted.

VSCode settings.json
{
  "typescript.preferences.quoteStyle": "single"
}

No semis if you're cool:
{
  "typescript.preferences.quoteStyle": "single",
  "typescript.format.semicolons": "remove"
}

Example:
import Hello from 'components/Hello'

export default () => (
  <>
    <Hello />

app

  </>
)

This issue can be locked.


Mephisto down?

Hi, is Mephisto broken? Can't use it since today on chess.com (both chess.com and beta)

Hey, it's still working on my end on chess.com. Can you send the link that's broken for you and attach screenshots?

as u can see here he shows me everytime the same chess board that it is not correct

it seems working only for puzzles...
btw I got this:
popup.html:1 Uncaught (in promise) Error: Could not establish connection. Receiving end does not exist.


RSDK-6694 cross-compile x264

What changed

added x264 library as submodule, on its stable branch

we may want to make this manual rather than submodule -- non android users won't need this

build command working on linux, :crossed_fingers: on :apple: too but pls test

LGTM!
Since we would be building x264 for mediadevices/RDK, are we planning to prototype the RDK build from this repo?

are we planning to prototype the RDK build from this repo

nope, I misunderstood where we needed this -- will close this PR and port these changes to somewhere better


Formula Cookbook: Enrich the Service block methods section

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Expand the explanation of why run is required for most fields in service do, and expand the description of name and require_root. Following https://github.com/Homebrew/brew/issues/16908 and the doc change in https://github.com/Homebrew/brew/pull/16914

Thanks so much for your first contribution!  You rock, @Jerry1144!


Improve clarity of Azure Fluid Relay docs

This aims to improve the basic "get started" Azure Fluid Relay docs with some things I noticed while working on FHL.

Fixes a link in the getting started page to point toward the main-azure branch rather than the main branch. This makes it consistent with other links and instructions on the page.
Moves TokenProvider discussion and the mention that it's already implemented to the later section that actually discusses client-side code (rather than the server-side sample code)

oops, hit enter before filling out a description. fixing :)

Learn Build status updates of commit f822f28:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/azure-fluid-relay/how-tos/azure-function-token-provider.md
:white_check_mark:Succeeded

articles/azure-fluid-relay/quickstarts/quickstart-dice-roll.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@hickeys,
Can you review the proposed changes? Note: It looks like a line break should be added to the "Warning."
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Learn Build status updates of commit 20f5eb6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/azure-fluid-relay/how-tos/azure-function-token-provider.md
:white_check_mark:Succeeded

articles/azure-fluid-relay/quickstarts/quickstart-dice-roll.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@hickeys I was browsing through the Azure Fluid Relay docs today and realized this never got merged. It would still be great to have. I believe all feedback should be addressed.

#sign-off


Location field: cut Canadian and UK postcodes to 3 first chars

m.786260
It's needed for free nominatim service only, since full 6 chars postcodes aren't supported.
Now when 6 chars zipcode is entered then location can't be determined.

After the following fix - https://github.com/unaio/una/commit/86e268665fc2b9d61e6c61bd6bb67f503e25626d - UK addresses work fine, however Canada postcodes aren't reliable at all not matter if part of the address is searched, so if precise geocoding in Canada is required then it's better to use Google or integrate some other service.


Event 'on_user_attributes_saved' in past tense?

The on_user_attributes_saved event seems to be the only one that is in past tense. Is there a reason for this? Would a PR be accepted if it were changed?

We also have workflow_triggered and workflow_progressed. I've seen that we have some events that follow this pattern on_before... and on_after.... I think that works fine if one wants to avoid past tenses, but I believe we should have an event naming schema that makes it clear whether an event is raised before or after an action.
I find it a bit risky to change an event name, it will break all existing add-ons using the event. Maybe add a log record when on_user_attributes_saved is used and add a new one called on_user_attributes_save?

It's past tense because it's already happened.

It probably would be better if it were on_after_user_attributes_save – but honestly I don't think this is that big of a deal

We can also call it foo_bar, and it would still work. My concern is that there is not a consistent naming convention and that it's currently confusing for developers.


Could we set  from manifest.mobile.json?

As asked in http://stackoverflow.com/questions/21673797/set-status-bar-color-using-chrome-mobile-apps/21707393?noredirect=1#comment41831896_21707393
Personally I don't think thats the right way to go, but we should find the right way to direct users towards customizations.

Any updates on this issue?

No one working on it, I don't think.


Remove reactstrap and bootstrap?

@quitequinn the README says,
# To Do
Remove reactstrap and bootstrap

Is that done, so readme can be updated, or still to do? :)

Can definitely be removed, but there is a lot of house cleaning of components still to do aswell.

Can definitely be removed, but there is a lot of house cleaning of components still to do aswell.

oops that's in the readme!

oops that's in the readme!

Maybe better to track TODOs here as issues?

Maybe better to track TODOs here as issues?


Updated to #957

A small refactor, removing the caching of domains in favour of making it simple to obtain the domain for a specific cell

See #957


feat(gravsearch): improve gravsearch performance by using unions in prequery (DEV-492)

Resolves DEV-492
PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other: Performance improvements.

What is the current behavior?

Issue Number: DEV-492
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Open Questions at this point:

[ ] How should execution context actually be handled
[ ] What is a sensible duration for a Gravsearch query? (I randomly picked 3s) When a query takes longer than this, a warning will be logged


Collisions with README/LICENSE when creating venv

On MacOS and linux ubuntu 18.04 for pex release v2.1.63 there is a false collision error created when creating venv for README.md and LICENSE files of certain dependencies.  This can be worked around with the --collisions-ok argument currently
pex pex awswrangler==2.13.0 requests-aws4auth==1.1.1 rsa==4.8 pyclustering==<IP_ADDRESS> -c pex -o ~/test.pex
pex-tools ~/test.pex venv testenv --collisions-ok
Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pex/tools/commands/venv.py:137: PEXWarning: Encountered collisions building venv at /Users/logan/Documents/ml_3t/testenv from /Users/logan/test.pex:

/Users/logan/Documents/ml_3t/testenv/lib/python3.8/site-packages/README.md was provided by:
/Users/logan/.pex/installed_wheels/3c1dbbc0882cb6280ff0f73f7ccccd2c3e744a42/awswrangler-2.13.0-py3-none-any.whl/README.md
/Users/logan/.pex/installed_wheels/3eaa4a3fc57327cab84de285c4557a35408c476d/requests_aws4auth-1.1.1-py2.py3-none-any.whl/README.md
/Users/logan/.pex/installed_wheels/e7b932d182bccf08c91a10a166624329a5e92bc1/rsa-4.8-py3-none-any.whl/README.md
/Users/logan/Documents/ml_3t/testenv/lib/python3.8/site-packages/LICENSE was provided by:
/Users/logan/.pex/installed_wheels/3eaa4a3fc57327cab84de285c4557a35408c476d/requests_aws4auth-1.1.1-py2.py3-none-any.whl/LICENSE
/Users/logan/.pex/installed_wheels/43a5f8c9c4453dc0eee792c8383af998491fc7df/pyclustering-<IP_ADDRESS>-py3-none-any.whl/LICENSE
/Users/logan/.pex/installed_wheels/e7b932d182bccf08c91a10a166624329a5e92bc1/rsa-4.8-py3-none-any.whl/LICENSE

false collision

It is not false. It looks like you don't actually have v2.1.63 which changed the collision detection to check contents and improved the output to show the contents were in fact different:
$ pex -V
2.1.65
$ pex-tools -V
2.1.65
$ pex pex awswrangler==2.13.0 requests-aws4auth==1.1.1 rsa==4.8 pyclustering==<IP_ADDRESS> -c pex -o ~/test.pex
$ pex-tools ~/test.pex venv testenv --collisions-ok
/home/jsirois/.venv/pex/lib/python3.10/site-packages/pex/tools/commands/venv.py:230: PEXWarning: Encountered collisions building venv at /home/jsirois/dev/pantsbuild/pants/testenv from /home/jsirois/test.pex:
1. /home/jsirois/dev/pantsbuild/pants/testenv/lib/python3.10/site-packages/README.md was provided by:
	sha1:6fae6b688ab1c4d82342f044685b15e4aed12068 -> /home/jsirois/.pex/installed_wheels/3c1dbbc0882cb6280ff0f73f7ccccd2c3e744a42/awswrangler-2.13.0-py3-none-any.whl/README.md
	sha1:d3b2e6c8edaf5ec69e4a10340ace30c9d9b8de6e -> /home/jsirois/.pex/installed_wheels/50017212094a9dd36d1919f0ac52bc9de0e1769d/requests_aws4auth-1.1.1-py2.py3-none-any.whl/README.md
	sha1:72aad144e976ac1623c8f45f2cf6ca42134ad4b2 -> /home/jsirois/.pex/installed_wheels/2f763a76650991e33049ad828e99b80d41384631/rsa-4.8-py3-none-any.whl/README.md
2. /home/jsirois/dev/pantsbuild/pants/testenv/lib/python3.10/site-packages/LICENSE was provided by:
	sha1:de05ddf9341b56b9c0eee2110eb8ef048d13f96b -> /home/jsirois/.pex/installed_wheels/50017212094a9dd36d1919f0ac52bc9de0e1769d/requests_aws4auth-1.1.1-py2.py3-none-any.whl/LICENSE
	sha1:c524aa1f633ec4f2710ec9d6cc0797f21c3ab668 -> /home/jsirois/.pex/installed_wheels/1f659cea1d46715d54dfd95ff6726859e3486897/pyclustering-<IP_ADDRESS>-py3-none-any.whl/LICENSE
	sha1:a4466bfd6f8b645aebdf508c1b7ede0bc018f694 -> /home/jsirois/.pex/installed_wheels/2f763a76650991e33049ad828e99b80d41384631/rsa-4.8-py3-none-any.whl/LICENSE
  pex_warnings.warn(message)

In this sort of case there is not much I can see that Pex can do except to offer --collisions-ok. Do you have any ideas?

Ah you are correct the wrong pex version was being used and its a warning now in the 2.1.65 instead of an error.  One idea might be to have a black list of filenames to ignore/exclude in the collision detection starting with README.md and LICENSE.  Another alternative would be to whitelist .py , pyx and other python-related files in the collision detection.  I think the blacklist approach might be easier to do.

Well, for LICENSE that actually sounds license violating - in spirit anyway. Certain licenses require you provide the license when distributing and by silently stomping we'll just present the MIT license (for example) and not the GPLv2 license it trampled.
README.md seems much more likely fine to trample, but things get pretty hairy. There is much more than just .py*s that are important for dists to function. There could be resource files or .sos, etc. I'm pretty loathe to auto-break an application or library in a silent over-write way; so I'm very hesitant here. It's really a few very strange, badly behaved distributions at play here. No one should be including files like those in their binary wheels.

@lcerkovnik I'm going to close this since silently trampling is so troubling for LICENSE and those other cases that might crop up that I'm not anticipating. It truly is the wild west out there in the real packaging ecosystem.

@jsirois  Ok, I think that's a reasonable way to proceed as I originally didn't consider trampling the wild west packaging during collision detection to be so significant.  At least now there is a record of this type of behavior for the future.  Thanks!


Changes Get-Childitem invocation to (hopefully) log errors.

More work on https://github.com/CERTCC/CVE-2021-44228_scanner/issues/5


pcl_msgs: 0.2.0-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository pcl_msgs to 0.2.0-1:

upstream repository: https://github.com/ros-perception/pcl_msgs.git
release repository: https://github.com/ros-gbp/pcl_msgs-release.git
distro file: noetic/distribution.yaml
bloom version: 0.9.0
previous version for package: null

pcl_msgs
* clean up package.xml
* update maintainer info
* remove eigen dependency
* Merge pull request #1 <https://github.com/ros-perception/pcl_msgs/issues/1> from bulwahn/patch-1
* Contributors: Lukas Bulwahn, Paul Bovbel

New one coming


CIF and CompetingEventTimes

This improves upon #4. I slopped this down pretty quickly but let me say first that I did test it against stcompet from Stata and it gave identical results, so I've got that going for me.
I started with the CompetingEventTime as an extension of EventTime. I made it very general, which could probably also be done to EventTime in the same spirit. There is probably a way to mesh them together much better. I do think it is better to herd users toward these types (as opposed to always allowing them to supply lots of vectors) because it allows for easier handling within the estimators if you do this bit of "pre-organization".
The estimator computes only the CIF for the event of interest, not for all events. It is certainly possible to do all of them in a single pass, but I didn't see a quick easy way to do so and keep it flexible like it is now. The downside is that if you need the CIF for all 5 of your competing events, you need to run this estimator 5 times. The upside is that I made it pretty easy to do so by providing a swapeventofinterest function, so that you can quickly convert your event times and rerun the estimator. I think making it compute all of them at once could be done at a later time.
I initially tried to not add a new _estimator method for CumulativeIncidence, but it requires tracking some additional variables over time so I didn't see a way to do that in the existing framework. So, it sort of looks like the existing method but functionally it is not integrated.
I have not implemented any CI tests and some docstring cleanup is needed. Would appreciate some help polishing this up a bit.

I did some additional testing to verify correctness. In the absence of competing risks, the overall survival curve and the complement of the CIF should both equal the standard Kaplan-Meier curve, and they do. The standard errors should match as well, and they do. Additionally, the sum of the CIFs for all event types should equal the complement of the overall Kaplan-Meier survival curve, and it does.
As mentioned in the other thread, we need to examine what happens in other software with tied times to verify the approach here. I believe it will be the same.
Note for next commit: the number at risk in the variance calc needs to be wrapped in float or else you will hit overflow with large values.

Ok I tested in the case of tied data, the results are identical to stcompet for Stata.
This just needs unit tests and docs.

I've started adding some docs.
I did find one design decision that is perhaps questionable. Right now I have it so that CompetingEventTime stores the time, the status, the status that corresponds to the event of interest, and the status the corresponds to censoring. These last 2 are not observation-level things though, they apply equally to all elements, so that there is a significant amount of duplication among the data. For small N, probably not much of an issue, but if you have millions of events I think it is perhaps wasteful with memory. Would it be smarter to extend EventTime to allow more general status types instead and then have a competing event times wrapper like
struct CompetingEventTimes{T,S}
    evt::Vector{EventTime{T,S}}
    eventofinterest::S
    cenoringevent::S
end

What do you think?


[DPE-5987] Add expose-external configuration option

TODO

[x] Re-enable random nodeport allocation, now that everything is wired up properly in an initial working version
[x] Add "loadbalancer" configuration value
[x] Put the "finishes touches": go into Maintenance while we wait for K8s service and disconnect existing clients
[x] Make sure that all of this works with TLS enabled

Changelog

Configuration: the charm configuration is now validated using pydantic, similar to what we have on Kafka.
Charm lib: the ZooKeeper charm lib was looking for the ZK leader unit upon instantiating ZooKeeperManager. This behaviour is incompatible with an application-wide nodeport service that can route queries to any unit. The default behaviour is to look for the leader on a "best-effort" basis, and pick any unit if we cannot identify it. We will need to publish this change before any client Charm can relate to ZK with expose-external set to something else than "false"
Relation interface: the endpoints relation field now properly concats the port to each ZK host
K8s service: Added the expose-external configuration option, triggering the creation of a K8s service to expose the application

This PR does not yet include the loadbalancer-extra-annotations configuration option mentioned in DA122 because I currently lack the context to know how to implement it. This PR's scope being massive already, I believe that this additional could be done in a future PR.
What about dependent charms?
They will need to update their zookeeper charm-lib to be able to connect to an externally exposed ZooKeeper Charm
Demo
screen_record.webm

We have a Kafka (local build slightly modified) deployment with ZooKeeper. Traffic is encrypted thanks to the self-signed-certificates charm
We see in the relation databag that the endpoints field has two addresses for the 2 ZK units
We set the expose-external configuration option to nodeport, a k8s Service is created
Once everything settles down, the deployment is back to active-idle. We see in the relation databag that we have a single address, the nodeport.
We reset the configuration option back to the default false value. The k8s Service is removed, and after everything is back to active-idle again, the relation databag is back to its initial state

BTW...there is some synergies with the Kyuubi PR being raised on the loadbalancer part. In particular:

we are having a conversation about deferring events to resolve this maintenance status ASAP, see here
Failing the get-endpoint action when the endpoints are being updated, see here

Can we have a standard UX on this among the two charms? Maybe also worth feeding back to the wider DP team

@deusebio - I would be careful trying to align too much here. The charms were made in fundamentally different ways, and are essentially different products due to one being stateful and the other stateless.
I don't think we should be worrying too much about whether the service is 'active' or not. Just block while you create it with a good status (like the comment earlier), and send it to clients. If it's not yet active, let the client retry.
ZooKeeper does that already. It sends endpoints before it's actually 'ready', it's why we have zookeeper_connected on Kafka side. IMO it's better to mess with defers client-side, rather than complicated server-side init.

I would much rather DP charms were 'eventually' stable, rather than 'event' stable, if that makes sense? It's much more reliable to operate and develop on.

I don't want to blow up the scope either and propose big refactoring, but cross-reviewing the code is very very sane to me, given we work on the same feature and this will also provide insights/inputs to each team. If there is not much of a change we can also try to nudge towards similar patterns whenever possible/sensible.
What I'm saying is that we need to (according to the spec)

During a later hook, the charm will verify that the service endpoints are reachable and only then will it update the endpoints in the relation databag and reset the charm app status to ActiveStatus.

This can be done via deferral or in a piece of code that runs kinda* all the time. I don't have any strong preference one over the other, but I don't see why not following similar pattern in both cases to be consistent

This PR must walk a thin line between two implementations. Right now it's quite close to Kafka's since (1) I reviewed the expose external stuff when it was first added to Kafka and (2) the two charms were already quite similar in their approach.
At the same time, I understand why it's not a good look to have two ongoing PRs implementing the same feature having substantial differences in the implementation.
My two cents: this PR's implementation must remain close to Kafka's because the maintenance will be Marc's. If we can marginally improve on the original design by cross reviews with Kyuubi then it's fine, but I would rather have (Kafka == ZooKeeper) != Kyuubi than Kafka != ( ZooKeeper == Kyuubi) if there is no reasonable way to attain the triple equality

I agree to prioritize similarity with Kafka. But the load balancer specific parts (maintenance status handling and actios) are not implemented in Kafka (since we don't support LB yet), but in Kyuubi. Hence the comment.
Please have a thought, it is up to Marc and Paolo to decide if it is worth having common patterns. I would nudge to that, but not being prescriptive if it creates more burden than benefits.


ci: update the bee-update workflow

Improves the variable naming
Cleans up some variables from the old way of upgrading the Bee Factory images
Fixes the fact that the update created two PRs. One for the RC's versions and then one for the final Bee version.
Blocked by https://github.com/ethersphere/bee-factory/pull/175

Release v5.0.0 addresses this.


Fix size

refs #4 @unindented I've just noticed, actually it uses relative path. So the only thing I've fixed is the size ouput

@vyorkin Awesome!
If you remove the extra-semicolons (I'm linting using standard) I'll merge this right away.

done

It looks like there's a unit test now failing: https://travis-ci.org/unindented/stats-webpack-plugin/jobs/94395990
Could you look into it?

oops, sorry, sure, give me a minute

oh, that looks so weird:
             ]
             "chunks": [
               0
             ]
      +      "emitted": true
             "name": "bundle.js"
             "size": 1622
           }
      +    {
      +      "chunkNames": []
      +      "chunks": []
      +      "name": "stats.json"
      +      "size": 0
      +    }

but all I did is just moved JSON.stringify... out of the function scope..

Yes, I think now it behaves correctly, I just need to fix the failing test

I don't know whats wrong, seriously, I'll take a look at it later, it isn't worth it right now

Fixed with https://github.com/unindented/stats-webpack-plugin/commit/2643278d62fbb7f5edb6371b245b17ce1680c335.

cool! sorry, I didn't have time to do it myself :(


Responsive issue  img-layer class overflow solve

Drifty website in IPad Air or IPad Mini, the design collapses or website is non-responsive for that width and height. fixed

Deploy preview - https://deploy-preview-206--drifty.netlify.app/


ColorColumn being rendered over by highlight match.

The simple .vimrc file below highlights trailing tabs or spaces within a line.
This .vimrc will cause a space/tab to be match'd to a highlight and appear as a red under line.
When a alpha-numeric is pressed the spaces/tabs will no longer trail and subsequently they will revert back to the default color.
The error shows when trailing spaces/tabs are being rendered after a match and go over a ColorColumn.
The rendering does not appear to honour the guibg=NONE and the ColorColumn gets rendered over.
When they are not matched the ColorColumn is rendered.
cat ~/.vimrc

set termguicolors
set cursorline
hi clear

" terminal column
set cc=10
hi ColorColumn guibg=#1E1E1E

hi GroupTrailingSpace guifg=red guibg=NONE
match GroupTrailingSpace /\s\+$/
2match GroupTrailingSpace /\t\+$/

The image below hopefully highlights the issue.

The spaces are being match'd prior reaching the ColorColumn.
The spaces are being match'd and bypassing the ColorColumn.  The ColorColumn is being hidden.
The spaces are not being matched as 'ABC' are now the trailing characters.  The ColorColumn has rendered again !

I found something similiar for ColorColumn and foldtext.
http://vim.1045645.n5.nabble.com/colorcolumn-and-foldtext-tt5724274.html
Debian GNU/Linux 10 (buster)
VIM - Vi IMproved 8.2.2661 (2019 Dec 12, compiled Mar 27 2021 07:58:34)

The idea of the color column is that it's an indication of some column, which has low priority.
Other things highlighted in the text usually have higher priority.
That the match for trailing spaces overrules it is to be expected.
If we would change this I'm sure someone else has an example where that is not wanted.

I thought a highlight match specifying guibg=#SOMECOLOR would overrule the ColorColumn background but  guibg=NONE would allow the lower priority ColorColumn background through into the foreground.


Audio device not detected when unplugging and plugging in again

On my laptop I have a setup consisting of builtin speakers and an audio output via my external HDMI monitor. When I unplug the monitor whilst that device is selected for audio playback the device properly returns to the built-in mode and switches the icon (a setting I've enabled).
After plugging the HDMI cable back in, the application doesn't detect the new device. Also swapping output device using Windows' control panel (Win 8.1) doesn't bring the icon of the HDMI device back.

Hmm, this seems like a very specific scenario when using Audio over HDMI.
It's very strange that the application isn't picking up the new device.
I'm assuming, because you were able to switch it via Control Panel, that the device is showing up in Windows?
I may be able to recreate this, using my audio setup.
Does the laptop have a graphics card? NVidia/AMD? Or is in using onboard Intel/AMD?

Hey Xeno,

Yes, I can switch via the control panel as it shows up there. I.e. Windows detecting it is all functioning normally.
No, is is an Asus UX31A which has an onboard Intel HD Graphics 4000 chip

Thanks.
I'll investigate it and provisionally mark it for release in the next release <IP_ADDRESS>

Confirmed that there is a scenario where devices are "Invalid" when added to the system.
Devices are considered 'added', when they are plugged in. This could occur for almost any removable audio device.
Issue added to Api project to track the fix.
https://github.com/xenolightning/AudioSwitcher/issues/15

I just experienced this with a Bluetooth device. Whenever connecting a device, it shows up in Windows' playback devices window, but AudioSwitcher has to be closed out and restarted for it to show up.

This seems like the issue I was having and already reported over here
I often change my presentation mode (from extended to monitor only) which basically unplugs the TV as an audio device. Once it's enabled, right clicking the audioswitcher bugs out the menu (flickers in and out for a minute), and the TV is sometimes seen as a device sometimes not.

@CntZer0 Yeah, it's definitely a known issue in <IP_ADDRESS>, there's about 4 issues related to it atm.
Have another issue in the Audio Api to fix, there should be a client release today or tomorrow.


"retweet" class causes Adblock to hide elements which use Entypo reshare icon

In diaspora* the issue came up with reshare icon being hidden by AdblockPlus because it uses "retweet" class as per https://github.com/lwe/entypo-rails/blob/master/app/assets/stylesheets/entypo.scss.erb#L143
See details on that issue here.
Can it be renamed in entypo-rails to "reshare"? It's a more proper generic name for the class. "retweet" is too Twitter specific.

Hi @shmerl - yes, of course, can you provide a PR maybe?

Nevermind, added an alias named reshare - I don't think the whole CSS is blocked because it contains retweet somewhere correct? Can you test the current 3.0.0.pre.rc2, thanks.

Thanks. It's blocked as soon as some element has a retweet in the list of its classes. Probably diaspora can avoid using that, and use the "reshare" alias instead to work around it. I'll let you know how that works out.

Cool, thanks, let me know how it works out.

It's working fine now in Diaspora.

👌 thanks for the update and glad it's now fixed somehow.