[SPARK-27110][SQL] Moves some functions from AnalyzeColumnCommand to command/CommandUtils

What changes were proposed in this pull request?
To reuse some common logics for improving Analyze commands (See the description of SPARK-25196 for details), this pr moved some functions from AnalyzeColumnCommand to command/CommandUtils.  A follow-up pr will add code to extend Analyze commands for cached tables.
How was this patch tested?
Existing tests.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2489/
Test PASSed.

Test build #95160 has started for PR 22204 at commit fcc5300.

@gatorsmile ping

cc @wzhfy as well

cc @dongjoon-hyun Try to review this PR?

ping

ping

@maropu . Is this PR suggesting that the user need to use CacheManager.analyzeColumnCacheQuery? In general CacheManager is internal to Spark SQL, isn't it?

ah, how about adding a new method in SparkSession e.g., SparkSession.analyzeColumnCacheQuery?

Also, we might be able to extend the ANALYZE command for this purpose.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2733/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2734/
Test PASSed.

Test build #95536 has started for PR 22204 at commit 4c77b24.

Test build #95535 has finished for PR 22204 at commit 7f2e10a.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class PlanLater(plan: LogicalPlan) extends LeafExecNode with PlaceHolder

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95535/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2736/
Test PASSed.

Merged build finished. Test PASSed.

Test build #95538 has started for PR 22204 at commit c200016.

Test build #95536 has finished for PR 22204 at commit 4c77b24.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95536/
Test FAILed.

Test build #95538 has finished for PR 22204 at commit c200016.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95538/
Test FAILed.

Test build #95545 has started for PR 22204 at commit d366d9c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2740/
Test PASSed.

Test build #95545 has finished for PR 22204 at commit d366d9c.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95545/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2752/
Test PASSed.

Test build #95566 has started for PR 22204 at commit 929bc2d.

Test build #95566 has finished for PR 22204 at commit 929bc2d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95566/
Test PASSed.

Merged build finished. Test PASSed.

@dongjoon-hyun could you check again? thanks! (btw, congrats, committer!)

Thank you, @maropu . BTW, if this PR aims to provide ANALYZE command interface to users, could you update the PR content and test cases for that?

ok, I'll do that.

retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3104/
Test PASSed.

Merged build finished. Test PASSed.

Test build #96062 has started for PR 22204 at commit 929bc2d.

Test build #96062 has finished for PR 22204 at commit 929bc2d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96062/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3111/
Test PASSed.

Test build #96070 has started for PR 22204 at commit 929bc2d.

Test build #96070 has finished for PR 22204 at commit 929bc2d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96070/
Test PASSed.

ping

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4014/
Test PASSed.

Build finished. Test PASSed.

Test build #97424 has started for PR 22204 at commit 8d6f599.

Test build #97424 has finished for PR 22204 at commit 8d6f599.

This patch fails due to an unknown error code, -9.
This patch does not merge cleanly.
This patch adds no public classes.

Test build #97425 has finished for PR 22204 at commit 638b650.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97424/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97425/
Test FAILed.

retest this please

Test build #97444 has started for PR 22204 at commit 638b650.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4028/
Test PASSed.

Test build #97444 has finished for PR 22204 at commit 638b650.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97444/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4194/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4203/
Test PASSed.

Test build #97717 has started for PR 22204 at commit 638b650.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4208/
Test PASSed.

Test build #97717 has finished for PR 22204 at commit 638b650.

This patch fails to generate documentation.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97717/
Test FAILed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4229/
Test PASSed.

Test build #97729 has finished for PR 22204 at commit 638b650.

This patch fails due to an unknown error code, -9.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97729/
Test FAILed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4246/
Test PASSed.

Test build #97743 has started for PR 22204 at commit 638b650.

Test build #97743 has finished for PR 22204 at commit 638b650.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97743/
Test FAILed.

Test build #97784 has started for PR 22204 at commit 638b650.

Build finished. Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4387/
Test PASSed.

Merged build finished. Test PASSed.

Test build #97894 has started for PR 22204 at commit d5bff88.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4403/
Test PASSed.

Test build #97924 has started for PR 22204 at commit c18beff.

Test build #97924 has finished for PR 22204 at commit c18beff.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97924/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4426/
Test PASSed.

Test build #97954 has started for PR 22204 at commit b72a7fc.

Test build #97954 has finished for PR 22204 at commit b72a7fc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97954/
Test PASSed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5652/
Test PASSed.

Test build #99596 has started for PR 22204 at commit b72a7fc.

Test build #99596 has finished for PR 22204 at commit b72a7fc.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99596/
Test FAILed.

retest this please

Test build #99606 has started for PR 22204 at commit b72a7fc.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5662/
Test FAILed.

Test build #99606 has finished for PR 22204 at commit b72a7fc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99606/
Test PASSed.

@maropu Sorry for the late review. The actual code changes are not huge. Could we split it to two PRs? One PR is just refactoring the code; another PR is to add the new support? It will simplify the reviews.

ok, I will. Thanks, @gatorsmile!

Test build #100683 has finished for PR 22204 at commit 572b458.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100683/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6587/
Test PASSed.

Test build #100685 has started for PR 22204 at commit 4c964ba.

Test build #100685 has finished for PR 22204 at commit 4c964ba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100685/
Test PASSed.

ping @gatorsmile

ping @gatorsmile @cloud-fan

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8658/
Test PASSed.

Test build #103213 has started for PR 22204 at commit 1650d5a.

Test build #103213 has finished for PR 22204 at commit 1650d5a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103213/
Test PASSed.

@dongjoon-hyun Yea, thanks! I'll address you comments soon.

Test build #103233 has started for PR 22204 at commit a238c03.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8679/
Test PASSed.

Test build #103233 has finished for PR 22204 at commit a238c03.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103233/
Test PASSed.

@dongjoon-hyun can you do your final check and merge? thanks.

Thanks, all


[Feature] Multiple users

Also quite interested in having different users to talk with, so a new section would have to be rendered before the actual "send message" panel to choose the user you want to talk to.
Will try to implement on my own and do a PR, but this would involve changing also the blaze package

how is this now?


Clean up the PuppetDB API

I will soon write a full puppetmaster replacement. I want to use servant for that.
To cut down on dependencies, I plan to migrate the current PuppetDB backend to servant. It does now live in the servant branch.
It would be nice if someone with access to a real puppetDB could check if there are regressions when connecting to a PuppetDB ...

I have access to a real puppetDB so I will be able to help (but not before the end of next week).

So I have moved it to a GHC 7.10 branch, as the servant move drops the requirement for the iconv package that doesn't build for 7.10.
I think I fixed the build for 7.10, and tried to reduce the warnings as much as I could (that's why there are extra import Prelude lines now).
I also removed all references to Control.Monad.Error, which is deprecated.

I'll test that it still works as expected with GHC 7.8 tomorrow.

This seems OK, so I merged all my changes with master. I'll test it properly in the next days.


Advanced Demo link is broken

Thanks for the nice lib. It's incredibly useful, but the advanced demo link seems to be broken.

Hi @elgs
here is the updated link http://demo.flatlogic.com/sing-wrapbootstrap-2/ajax/grid.html
We'll update the readme too.
Thanks for pointing this out

Thank you so much.


Fix TOC menu item expanding

Re: https://github.com/apache/incubator-datasketches-website/issues/91
With this change, the path to the currently selected menu item will be expanded on page load.

@mkaszas
Máté,  Yea!  THANK YOU!  Wow!  Super! AT LAST!  :) :)


fix script execution in non-PATH directories

If the user used a virtualenv and did not have the virtualenv in their PATH. Or they used another shell like zsh and the install location of this plugin was not in bash's PATH (since it forces execution with bash) then it would just silently fail.

@cardoe - thanks for contributing! Could you re-lock and push a commit so we can run tests? I'll take a look at the PR soon.

@cardoe - thanks for contributing! Could you re-lock and push a commit so we can run tests? I'll take a look at the PR soon.

Done!

Thanks. Lemme know what I need to do to get it in a release.

@jdoiro3 https://github.com/jdoiro3/mkdocs-multirepo-plugin/actions/runs/10361895254/job/28683098702 looks like the release failed. I think it should be a quick fix and just re-run CI.


Orders, fills and positions sections of market page UI aren't highlighting in trading tutorial

The components should become highlighted (lighter), same as all the other steps

fixed


Create <IP_ADDRESS>.yaml

Microsoft Reviewers: Open in CodeFlow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: AgentK7 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


add the documentation for GPU support for Packer

Add some documentation for GPU support on the Packer side.

LGTM


Re-arranged project folder

The Project folder has been arranged according to the specified instructions.

@siddhi-244 please review and merge it !!
Thanks


RTX 4080 support

I have NVIDIA RTX 4080 GPU. I followed the instructions but whatever the cuda versions I tried (cuda toolkit 11.8, 12.2, 12.3), it all gives No supported Nvidia GPU found, I am wondering are there any instructions about 40xx card instruction to run it correctly. Also tried the python to print the torch cuda version, seems no cuda device found.

Never mind, just the RVC1006Nvidia.7z one, it works.

Have you figured out why torch does not see your GPU? I am running into the same problem.

Have you figured out why torch does not see your GPU? I am running into the same problem.

Yep, I add two CUDA paths (I installed two CUDA versions), just keep one PATH, the torch finds the GPU.


suggestion: Retag images instead of creating new images

I don't know if creating new image by just adding FROM sourceorg/repo to Dockerfile.tmp may affect the image checksums when pushed. Is it possible to pull all manifests of specific image or does it need to go through painful curl/wget spaghetti of hell?

will be possible with #2

👀


[1pt] Choose assets - group task

Choose images, text, icons, fonts.

Images: Chosen Along the Process
Icons: Font Awesome
Fonts: https://fonts.google.com/specimen/Roboto+Condensed?category=Serif,Sans+Serif&preview.size=32#styles
Colors:

Light: https://colorhunt.co/palette/51eaeafffde1ff9d76fb3569
Dark: https://colorhunt.co/palette/04879c0c3c78090030f30a49


SpatialHashMap not updated when assigning Group's entities to an EntityList

In entities.setter of Group, the _entity_hashmap is not updated when the argument is an EntityList object.  This causes anything that would use it to return data, i.e. find_entities_filtered, to return nothing.  I'm not sure what your intention with this was, but maybe you want to initialize a new EntityList instead of just assigning _entities to the new list?  Basically just make the first elif look for both list and EntityList.  This method works.  Alternatively, it can be handled the same way that Blueprint does by adding each entity into the hashmap.

This is related to #16 and #20. This is fixed in 0.9.6, for both Group and Blueprint. The new setter code is now:
# entities.setter():
self._entity_hashmap.clear()

if value is None:
    self._entities.clear()
elif isinstance(value, list):
    self._entities = EntityList(self, value)
elif isinstance(value, EntityList):
    # Just don't ask
    self._entities = copy.deepcopy(value, memo={"new_parent": self})
else:
    raise TypeError("'entities' must be an EntityList, list, or None")

self.recalculate_area()

Similarly, EntityLike, Group, and Blueprint now all have working __deepcopy__ methods, so they can all be properly copied as well. EntityList can be deepcopied, though as shown in the code above there's a bunch of extra baggage that comes with this so in practice it's recommended you simply deepcopy the parent object and it should just work™.
These deepcopy methods follow the following logic:

EntityLikes can be copied, but Associations to other entities are not preserved (they will still point to the original Entities). I haven't decided whether or not this should throw an InvalidAssociationError or if all associations should be cleared on copy, but for now they still point to the original entities unchanged. If an Entity that exists inside some EntityCollection is copied, the parent of the copied Entity will be set to None, as it does not get added to the EntityCollection. That must be done manually:blueprint = Blueprint()
blueprint.entities.append("wooden-chest")
assert blueprint.entities[0].parent is blueprint
# Create the copy
entity_copy = copy.deepcopy(blueprint.entities[0])
assert entity_copy.parent is None
assert entity_copy not in blueprint.entities
# Add the copy to the blueprint explicitly
blueprint.entities.append(entity_copy)

Groups can be copied, and Associations local to that group (fully contained) will be properly copied as well. Attempting to copy a Group that has associations that point outside of the Group will raise InvalidAssociationError on copy. The parent attribute of any contained Entities will be modified to point to the correct, copied value. If the Group object being copied has a parent of it's own, similar to EntityLike it is set to None:blueprint = Blueprint()
group = Group("group") # also I changed group so that you don't *need* an associated ID
group.entities.append("wooden-chest", id="chest")
blueprint.entities.append(group)
# Assert that the blueprint contains the group
assert blueprint.entities["group"].parent is blueprint
# Assert that the group contains the entity
assert blueprint.entities[("group", "chest")].parent is blueprint.entities["group"]

# Create a copy of that group in blueprint
group_copy = copy.deepcopy(blueprint.entities["group"])
# group_copy is identical to group
assert group_copy.id == "group"
assert len(group.entities) == 1
assert isinstance(group.entities[0], Container)
# Copied subentities correctly point to copied parent
assert group_copy.entities["chest"].parent is group_copy
# But group_copy does not point to the original blueprint
assert group_copy.parent is not blueprint
assert group_copy.parent is None
# Nor is it contained within it
assert group_copy not in blueprint.entities
# Again, it must be manually added if such a thing is desired

Blueprints behave nearly identically to Groups, save for the fact that you don't have to worry about non-local Associations as connections in Blueprints can only be inside that particular blueprint.

Both of the entities setters for Blueprint and Group create a use deepcopy to create a new set of data, as due to the nature of EntityList having two or more that point to the same data is undesirable. This makes
blueprint_or_group.entities = other_blueprint_or_group.entities
# conceptually equivalent to
blueprint_or_group.entity_hashmap.clear()
blueprint_or_group.entities = copy.deepcopy(other_blueprint_or_group.entities)
blueprint_or_group.recalculate_area()

As a reminder, EntityList.append also copies anything passed into it by default unless explicitly set with copy = False:
group = Group()
test_entity = Container("wooden-chest")
group.entities.append(test_entity, copy=False)
assert test_entity is group.entities[0]

Impressive, I appreciate the work and am excited to try and break it in new and exciting ways.
I developed my own workaround with a class based on Group that simply replaced all Associations with one pointing to an entity in the current group.  This did require me to give IDs to an entity in the parent blueprint that was either power or circuit connectable prior to copying so I could retrieve the ID from the old entity and create a new association pointing to the same ID within the group.  I created the following functions to perform this update which are called at the end of the entities setter:
@Group.entities.setter
def entities(self, value):
    # Copy entities
    # ...

    updateNeighbours()
    updateConnections()

def updateNeighbours(self):
    for entity in self.entities:
        if(entity.power_connectable):
            for idx in range(len(entity.neighbours)):
                neighbour = entity.neighbours[idx]
                na = Association(self.entities[neighbour().id])
                entity.neighbours[idx] = na

def updateConnections(self):
    for entity in self.entities:
        if(entity.circuit_connectable):
            for side in entity.connections:
                for color in entity.connections[side]:
                    for idx in range(len(entity.connections[side][color])):
                        point = entity.connections[side][color][idx]
                        connection = point["entity_id"]
                        na = Association(self.entities[connection().id])
                        entity.connections[side][color][idx]["entity_id"] = na

Getting this to work required you to add the group the blueprint first, and then set entities for the group to the entities of the blueprint:
bp_old = Blueprint(bp_string)
id = 0
for entity in bp_old.entities:
    entity.id = str(id)
    id += 1
g = Group('g1')
bp_new = Blueprint()
bp_new.append(g)
bp.entities['g1'].entities = bp_old.entities

This is all a bit hacky, but it worked.  Take what you will from this, but just wanted to share this.

I developed my own workaround with a class based on Group that simply replaced all Associations with one pointing to an entity in the current group

This is almost exactly what the current algorithm does, except it uses the id() of each object (so you don't have to manually set it yourself) using the deepcopy metamethod. I'm glad that you managed to find a working solution; this patch should be out either later today or tomorrow assuming I can squash some warnings being issued incorrectly.

Alright, all of your issues should be resolved if you update to version 0.9.6. For the sake of brevity I'm going to close these issues, but if you still have troubles feel free to make a new issue so we have a "clean-slate", so to speak.


Skip call a second host test on CI

Regretfully. Is causing problems, for example on https://github.com/http4s/http4s/pull/3338/.

this is unfortunate

I just rambled about these a bit on https://github.com/http4s/http4s/pull/3331. I'm wondering about looking at MUnit and seeing if its superior async support avoids the deadlocks that plague blaze tests, but even if we ported all the blaze tests, the specs2 tests could still be deadlocking things.  Maybe we need an munit executor service as well, and could gradually port tests and see if it makes a difference?


Context not carried over in chat

I am not sure if this is how it is supposed to work, but no context is carried over to subsequent messages. For example, when running ./scripts/chat-pythia-12B.sh.
You can do the context yourself by inserting the <|endoftext|><|assistant|> tokens. I don't think they are true tokens in fact if you do this, so the results from the assistant can sometimes reproduce the literal <|endoftext|> and <|assistant|>. But I think the goal is to have a coherent dialogue automatically?
For example:

> Remember this phrase: Cindy is a farmer.
This phrase means that the person named Cindy is a farmer who is skilled at farming and can grow various types of plants and fruits.
> What is Cindy's profession?
I'm sorry, I don't know who Cindy is. Could you please provide more context or details about the person or the work you're referring to? It would be helpful for me to understand what you mean by "Cindy's profession".
> Remember this phrase: Cindy is a farmer.<|endoftext|><|assistant|>Cindy is a farmer.<|endoftext|><|prompter|>What is Cindy's profession?
He is a farmer.

I am currently working on a context-based short term memory to be used with llama/gptneox based models. Its pretty much done so I should have a test version pushed in less than 12 hours. Testing it with the Open Assistant models seems to be a little tricky as they went out of their way to train the models to think that they specifically do not have any sort of short term memory, only the information that is available to them during training. So the model will tell me it does not have a memory and then proceed to use the context memory properly if I ask it to take a guess about something I said previously.
The way that I have it implemented is it will keep adding queries and responses to the context up to the context length (2048 or 4096 usually depending on which model is used). Once the context is full, it will purge the oldest query or response to make room for new next tokens as needed, but I have found that it takes a pretty decent amount of normal conversation before the context actually gets full and needs to be purged.


Still lots of no score results from ImProving

Handy form of pk: 3e78d9f2-0140-4089-88eb-181db913b008


SPIKE: Use GitHub Actions instead of CircleCI

We are currently using CircleCI (https://circleci.com) as our task runner for continuous integration / deployment.
We should consider the merits of using Github Actions (https://help.github.com/en/actions) instead of CircleCI.

This spike was completed so closing this ticket


[Bug]: Failing Page 31169 "Report Selection Cash Desk CZP"

Describe the issue
Page 31169 "Report Selection Cash Desk CZP" content field
                field("Report ID"; Rec."Report ID")
                {
                    ApplicationArea = Basic, Suite;
                    LookupPageID = Objects;
                    ToolTip = 'Specifies the ID of the report that the program will print.';
                }

This field i defined in table 11748 "Cash Desk Rep. Selections CZP"
        field(3; "Report ID"; Integer)
        {
            Caption = 'Report ID';
            TableRelation = AllObj."Object ID" where("Object Type" = const(Report));
            DataClassification = CustomerContent;

            trigger OnValidate()
            begin
                CalcFields("Report Caption");
            end;
        }

Problem is that defined LookupPageID on page use Page where is source table AllObjectsWithCaption, but table relation use AllObj table. It rasie unhandled error.
Expected behavior
It should work without error.
Steps to reproduce

Go to page Report Selection Cash Desk  in web client
Click to lookup in Report ID
It sows you small dropdown table (it works)
If you use Choose from full list it opens lookup page
Choose some record and confirm
Raise error with unhandled error.

Additional context
No response
I will provide a fix for a bug

[ ] I will provide a fix for a bug

That might just be a product defect! Unfortunately, this repository is only for extensibility requests for Dynamics 365 Business Central or pull requests towards the 1st party Business Central apps. We suggest that you open a support case or file a bug to ensure that all Business Central users benefit from your catch as soon as possible:
On premises - https://support.microsoft.com/en-us/supportforbusiness/productselection?sapId=93d37907-ad94-d591-22e9-593cfa09dd3f
Cloud – contact your partner, or if you are a partner open a support incident through Partner Center - https://partner.microsoft.com/en-us/pcv/dashboard/overview

Hello @JesperSchulz,
problem is not in platform, but in app. This table Apps/CZ/CashDeskLocalization/app/Src/Tables/CashDeskRepSelectionsCZP.Table.al use TableRelation with different table than LookupPageID in Apps/CZ/CashDeskLocalization/app/Src/Pages/ReportSelectionCashDeskCZP.Page.al.
You can only change in Apps/CZ/CashDeskLocalization/app/Src/Tables/CashDeskRepSelectionsCZP.Table.al
"TableRelation = AllObj."Object ID" where("Object Type" = const(Report));"
to
TableRelation = AllObjWithCaption."Object ID" where("Object Type" = const(Report));
and it will work.

Sorry, I thought this was a BaseApp problem! My bad 😊 In that case, I'm of course reopening this issue and am allowing you to create a PR which introduces the change. I just did a quick search in the code base and found another place where AllObj was used as table relation. It's in table CompensReportSelectionsCZC.Table.al. Should that get changed as well, while at it?
Anyway, I'm of course approving this issue and am expecting a pull request 🙌🏻


Blog post about website monitoring

https://issues.opennms.org/browse/ORG-58
I've tested the setup today and it is working as aspected.
Feel free to change/improve the blog and wiki article.

Some changes required? :-P


fix: resolve audit warnings

:tada: This PR is included in version 0.105.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add components to support skeleton loading states

Relates to https://github.com/github/primer/issues/2682
https://github.com/primer/react/assets/2313998/854b82e1-8c52-48e1-a2ab-a95911df12cf

Changelog

New
Adds the following components:

SkeletonBone - general-use skeleton loading component
SkeletonAvatar - used to replace avatars with a skeleton loading state
SkeletonText - used to replace text with a skeleton loading state

Changed
DataTable and TreeView use the new skeleton loading components instead of their ad-hoc skeleton loaders
Removed

Rollout strategy

[ ] Patch release
[x] Minor release
[ ] Major release; if selected, include a written rollout or migration plan
[ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

[x] Added/updated tests
[x] Added/updated documentation
[x] Added/updated previews (Storybook)
[x] Changes are SSR compatible
[x] Tested in Chrome
[x] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge
[ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

@mperrotti just a heads up, started the API PR over in: https://github.com/github/primer/pull/2958 based on our conversation before break! Let me know if I missed anything in the API block and feel free to add to it. My hope is to add some usage examples before marking it as ready for review 👍

@joshblack - I was able to address almost all of your feedback.
The only thing I struggled with was replacing sx with className on SkeletonBox.


Fix hostdb deadlock and update constants

This PR fixes a deadlock while scanning a large number of hosts and changes some constants to make scanning faster. On my machine the download bandwidth hardly reached 20 kib/s with 250 threads so I guess those settings are sane.
This should also fix this issue.

Tried to use maxScanningThreads ~100 for SiaHub, got crash every time.
Maybe coz of deadlock that you fixed...

If i not mistaken - got wallet crash, tested it long time ago.
So I have kept default threads value and changed timings to make scan 'faster'

@S-anasol did siad crash right away? Maybe something else caused the problem and is fixed by now? I tested it with batches of 10,000 scans and 1000 threads and it still didn't crash on Ubuntu.

Maybe something else caused the problem and is fixed by now?
maybe, tested it in August 2017 on Debian.

Changed mine from 40 to 100 now, will check it later.
Looks like it work now.
Wallet sources from end of december.

@S-anasol Great! Let me know on Discord if you run into any errors.

@ChrisSchinnerl
Seems like crash gone. Few scans passed since yesterday.
siad                             RUNNING    pid 9307, uptime 14:24:13

So probably some updates between august and december fixed it 🚀
Then my warning about threads is out of date :)


Use class when impl is not callable

Fixes aminalaee/sqladmin#176.

@okapies it's ok. I think it might be missing the testsl coverage now.

We cannot test it at the moment because there is no way to configure a custom converter directly (https://github.com/aminalaee/sqladmin/issues/93#issuecomment-1156103788) from outside of ModelConverterBase.

@okapies I have to close this PR and use the other one which also includes the test, I hope you understand this and thank you for the PR.

Thanks for the quick fix!


fix ErrorBoundary fallbackUI prop type definition

Description of the change
This updates the type definition for the ErrorBoundary's fallbackUI prop
Type of change

[x] Bug fix (non-breaking change that fixes an issue)

Related issues
Fixes https://github.com/rollbar/rollbar-react/issues/87
Checklists
Development

[x] Lint rules pass locally
[x] The code changed/added as part of this pull request has been covered with tests
[x] All tests related to the changed code pass in development

Code review

[x] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[x] "Ready for review" label attached to the PR and reviewers assigned
[x] Issue from task tracker has a link to this pull request
[ ] Changes have been reviewed by at least one other engineer

Please, can we get this PR merged? 🙏

Hey @gazpachu, thank you for your PR. Let me find someone internally to look into it.

@rollbar-bborsits it's not my PR, but thanks for the prompt response 🙇


Fix exception raised when getTomls is passed a non-directory

WHY are these changes introduced?
Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes

#5083  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Google Analytics User ID

Are there any plans to add support for the User ID feature found in Android SDK v4 and iOS SDK v3?
https://developers.google.com/analytics/devguides/collection/android/v4/user-id
https://developers.google.com/analytics/devguides/collection/ios/v3/user-id
This would be really helpful to track users across multiple sessions/devices.

+1

+1

+1


feat(logging): add timestamp to console logs

:tada: This PR is included in version 2.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Makefile: fix swagger definition for automatic renovate updates

The swagger version and image SHA isn't being detected by renovate which is preventing renovate from automatically update it.

/test


buttons

upload and choose file button looks tacky, i would like to style it.

I have added css to the button. Kindly suggest changes if u want me to change it

I have added css to the button .

I would like to work on this.


Conservation of dimensionality when using Neighbourhooding.

As a user of Improver I want cubes to which I apply neighbourhooding to return from the plugin with the same dimensionality as they had when they entered.
Single value dimension coordinates are currently being demoted to scalar coordinates, thus the cube data has a different shape upon return.
Acceptance criteria:

Ensure dimension coordinates in returned cubes match the input cube.

Lovely stuff.

Closed by pr #227


[Feat]: Support IntelliJ Idea 2023.3.2

Is your feature request related to a problem?
No response
Describe the solution that you'd like
No response
Describe alternatives that you have considered
No response
Additional Information
No response
Acceptance Criteria
No response

@tbm98 Appreciate your feature suggestion! Good news – we've got IntelliJ support in the works and are hammering out the initial setup behind the scenes. If you're keen to jump in and contribute, we'd love to have your expertise onboard. Feel free to reach out if you're interested or have any more awesome ideas! 🚀

@doitwithdk  i'would  like to contribute on this feature,What stage are we at?

Hi @IldySilva, thanks for your interest in contributing. We should be rolling out a ticket for this by end of upcoming week.

@samyakkkk @IldySilva  I'm looking forward to this, is there a way i can use it tomorrow even if in alpha or beta?

@neiljaywarner we really appreciate your interest, but unfortunately, the IntelliJ version still has sometime before it becomes ready to be used in beta.
We'll keep everyone posted in thread and are working hard to bring it at the soonest. Thanks.

thanks
i tried the vscode version and it didn't seem that easy to me,but again,
i'm not used to vscode palette etc.
Not sure if you want to make a separate ticket, but are you working on more
documentation? in particular I'd like to know if you support riverpod and
more about create from blueprint; i didn't even see create from blueprint
in vscode last time i looked :(
On Wed, Apr 17, 2024 at 2:16 AM Samyak Jain @.***>
wrote:

@neiljaywarner https://github.com/neiljaywarner we really appreciate
your interest, but unfortunately, the IntelliJ version still has sometime
before it becomes ready to be used in beta.
We'll keep everyone posted in thread and are working hard to bring it at
the soonest. Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/Welltested-AI/dash-ai/issues/174#issuecomment-2060546257,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXBGYK5ILBHBBLQPRG3OGLY5YOVVAVCNFSM6AAAAABBVDV5YGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGU2DMMRVG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@samyakkkk  is there a way we could receive notice through email when intellij/android studio one works?
So far commanddash/fluttergpt has been the only big reason for me to switch, but there's still so many things to like about jetbrains/intellij ;) (retrofit tool, easy file new project, double shift, git compare.. of course maybe it is all jsut what you're used to..)

@neiljaywarner I'll definitely update you in this thread as soon as the IntelliJ extension comes out. You can also join our community slack - https://join.slack.com/t/welltested-ai/shared_invite/zt-25u09fty8-gaggH9HbmopB~4tialTrlA
Meanwhile I'd love to understand what is your most used feature in CommandDash. In your last thread you mentioned an issue about code from blueprint, which we deprecated and instead is something that could be done with our chat.
Please let me know if I can assist with anything here. thanks.

I didn't realize it was deprecated I apologize.
From my perspective it is extremely difficult to tell if AI in Dev is worth
"messing with".. the value proposition of saving time vs friction and
learning curve.
I get excited but I'm having a hard time seeing where it fits.  I know a
lot of it is me and you guys are doing awesome work. I'm especially
interested in trying to figure out automated testing. I would be thrilled
if AI could generate integration and widget tests with shared code based on
the UI elements. I get the impression a good bit of it you've already done
and I need to explore
Thanks again for your good work and I look forward to seeing how it goes
Does it support riverpod?
Are there any docs or examples how blueprint works please?
Also. How about http or dio or retrofit plus repository better yet from URL?
....sent from my phone
On Mon, May 6, 2024, 11:08 PM Samyak Jain @.***> wrote:

@neiljaywarner https://github.com/neiljaywarner I'll definitely update
you in this thread as soon as the IntelliJ extension comes out. You can
also join our community slack -
https://join.slack.com/t/welltested-ai/shared_invite/zt-25u09fty8-gaggH9HbmopB~4tialTrlA
Meanwhile I'd love to understand what is your most used feature in
CommandDash. In your last thread you mentioned an issue about code from
blueprint, which we deprecated and instead is something that could be done
with our chat.
Please let me know if I can assist with anything here. thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/CommandDash/commanddash/issues/174#issuecomment-2097406855,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXBGYJHOBCDQXXDIQZPRJ3ZBBHULAVCNFSM6AAAAABBVDV5YGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXGQYDMOBVGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@neiljaywarner yes, the AI tools are evolving pretty fast and it is definitely hard when something you use gets deprecated.
That said, we have kind of become stable now and will maintain our current features.
For your testing needs, we have a specific @test agent with /unit /widget and /integration commands to help you generate all kinds of tests. Here is a doc on how you can use it - https://www.commanddash.io/blog/exploring-the-test-agent
We also have an agent for riverpod, that you can install from the marketplace.

Awesome, thanks for the info!
....sent from my phone
On Wed, May 8, 2024, 7:39 AM Samyak Jain @.***> wrote:

@neiljaywarner https://github.com/neiljaywarner yes, the AI tools are
evolving pretty fast and it is definitely hard when something you use gets
deprecated.
That said, we have kind of become stable now and will maintain our current
features.
For your testing needs, we have a specific @test https://github.com/test
agent with /unit /widget and /integration commands to help you generate
all kinds of tests. Here is a doc on how you can use it -
https://www.commanddash.io/blog/exploring-the-test-agent
We also have an agent for riverpod, that you can install from the
marketplace.
https://github.com/CommandDash/packages/raw/main/dash_agent/assets/marketplace-icon.png
—
Reply to this email directly, view it on GitHub
https://github.com/CommandDash/commanddash/issues/174#issuecomment-2100485803,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXBGYNIKWUVQ7P462AR6UDZBIMGLAVCNFSM6AAAAABBVDV5YGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBQGQ4DKOBQGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


selections stomp over npm intellisense extension

It becomes quite difficult to use require() in node projects, as npm intellisense is getting completely stomped on by tabnine.

Would you be happy with an option to globally reduce TabNine priority in all files matching a certain glob, or is your issue limited to certain contexts such as require()?

I don't really know how the whole system works, and it might be possible that they just aren't compatible with each other, but specifically when I do require('../../someFile'), sometimes in the middle of typing it out, the results from TabNine are mixed in with the npm-intellisense, sometimes they are the only thing in the list, and there are no results from npm-intellisense.   I'd prefer that the npm modules are on top of the list, versus apparently randomly ordered, or not even there. :-D

so, i noticed it when i went to change a require('../constants') into a require('../../constants') .. after the first '..', i got mixed input, i hit the first /, and i got only suggestions from TabNine, which would be a great list, except it was a list of other requires, and not requires that are actually in the '../' directory. after the second '../', it gave me again a list mixed with TabNine and npm-intellisense results.  So, in the middle, I couldn't see anything from intellisense.

I don't really understand Intellisense's rules either. But I added some settings that will hopefully help. Specifically the "disable_line_regex" setting might be useful:

Disable TabNine when the current line contains a match of any of the provided regexes. For example, add "require" to disable TabNine when the current line contains the word 'require'.


Upgrade to angular 17

References

Fixes #2890
Fixes #2924

Description
This PR provides upgrade to angular 17. It also includes a bug-fixing for #2924
Instructions for Reviewers
The major changes introduced by Angular in the 17 version is on server-side rendering. Universal SSR and build-time prerendering are now directly supported in Angular CLI and do not require a separate integration with Universal.
List of main changes in this PR:

Removed Universal dependency in order to migrate to new @angular/ssr
Changed Universal app config in order to reflect new nomenclature

Include guidance for how to test or review your PR.
Review this PR by running the application (against sandbox rest server) to verify everything works properly as the current sandbox environment.
Please verify also #2924 is fixed
Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

NOTE: It appears Angular 17 now requires Node 18.3.0 or 20.9.0 or later.  Just hit this error when I tried a yarn build:prod on Node v18.12.1:
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^18.13.0 || >=20.9.0". Got "18.12.1"
error Found incompatible module.

This is just something we'll need to update in our Installation Documentation once this is merged.


Attribute creator in polls

Context: https://www.smogon.com/forums/threads/let-users-see-who-made-a-poll-or-hangman.3652444/

But why? What's the point?

I think a "Foo created a poll" public message would be nice at the start of a poll, but as-is this feels like a waste of screen real-estate. Polls are already too spammy as-is.

There are rooms give attribution to the user who submits the question for staff to publish. That already uses up some space. Implementing support for that might be more useful? Still, staff already handle that with the currently available tools...
So, I don't think this is needed. +1 for a single notification when the poll starts.

From the suggestion it seemed the main support for the use case was not having a bunch of users asking "who created the poll?". I'm not sure a public message accomplishes that for users the join the room after the fact (because polls can persist much longer than default scrollback, no?). Anyway, whatever, idc. Someone else can try this.


delete clusters

There some complete example for delete markers and clusters?
I can't use the delete() method correctly.
The response is delete is not a function
Thank you

Checkout examples/updates.ts, live at https://googlemaps.github.io/js-markerclusterer/public/updates/.
Reference docs for the MarkerClusterer class: https://googlemaps.github.io/js-markerclusterer/classes/MarkerClusterer.html


mvn: bump version ahead of next major release

Bumps version of specific dependency to latest ahead of the next major release 4.18.

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4285

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4288

@blueorangutan test matrix

@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-5022)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40136 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6767-t5022-xenserver-71.zip
Smoke tests completed. 103 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-5023)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40202 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6767-t5023-kvm-centos7.zip
Smoke tests completed. 97 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_DeployVmAntiAffinityGroup
Error
35.53
test_affinity_groups.py

test_DeployVmAntiAffinityGroup_in_project
Error
77.61
test_affinity_groups_projects.py

test_01_deploy_vm_from_direct_download_template_nfs_storage
Error
1.25
test_direct_download.py

ContextSuite context=TestDirectDownloadTemplates>:teardown
Error
1.09
test_direct_download.py

test_01_primary_storage_nfs
Error
0.11
test_primary_storage.py

ContextSuite context=TestStorageTags>:setup
Error
0.20
test_primary_storage.py

test_03_deploy_and_scale_kubernetes_cluster
Failure
28.07
test_kubernetes_clusters.py

test_07_deploy_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

test_hostha_enable_ha_when_host_in_maintenance
Error
304.21
test_hostha_kvm.py

@blueorangutan test

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-5024)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47924 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6767-t5024-vmware-65u2.zip
Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
714.56
test_kubernetes_clusters.py

Trillian test result (tid-5025)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40123 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6767-t5025-kvm-centos7.zip
Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
570.81
test_kubernetes_clusters.py


Blank image/video files

I've been having a problem with backups being downloaded with blank image and video files. The files are the sizes they should be but there's nothing on them if that makes sense. It's only with some downloads though, I don't know if it's an issue with the backup or the program but help would be appreciated.
Thank you!

Hi.  You can confirm this using any hex editor.
If they are corrupted as opposed to being blank. Then you can try downloading with --mode CBC and if that fails with --mode XTS.
If you're still having issues, then let me know which application/ domain the files belong to.

No response. Closing. Possible duplicate of https://github.com/horrorho/InflatableDonkey/issues/18.


Deployment diagrams

@k-wall have you given any thought as to how we leverage these in the repo or the website?
Partly I ask as previews would make reviewing this PR a lot easier

@k-wall are you still interested in this and how to get it rendered?

I think we want deployment patterns to be documented on the kroxylicious.io website.  I'll open an issue in that repo to track that requirement.


Adding Send-by-convention support for Sagas

Sagas have no extensions to do Send without getting the endpoint although we have send-by-convention feature. This PR fixes it.

Merged.

 May be it makes sense to update the dotSettings file then.

I did cleanup codeIn Rider and it fixed it. So it must be there.

@alexeyzimarev Was there a reason that this functionality wasn't provided in earlier releases?  I'm not complaining--I was thinking that there was an underlying rule, convention or guideline that I was missing.  For instance, are publishing events more common from a Saga?

Conventions is a new feature and before it was impossible to do without overloads that would also take the endpoint address. Although it might have been useful, ThenAsync worked fine too.
Conceptually, I more or less agree with what is written here (although not 100%) and this is what we also do - send commands and listen to events. I know that some people publish commands but we avoid this.
For comprehension, completing the collection of Send extensions that will also accept the address, would be useful and I might consider this. However, we are currently prefer sending by convention anyway.

Thanks @alexeyzimarev   I currently send commands from the ThenAsync but having this as an extension would be great.


Visual refresh and performance improvements to AMP Readiness Tool

This PR packs a lot, in terms of visual and performance improvements.
The UI has been completely redone with improved typography and layout. The extension also shows icons of the vendors detected on the page.
For the performance side, app has been rewired to run in the background. This is different from the previous iteration where actions were done on-demand. The results are also cached to improve snappiness, where as previously work was redone every-time the extension was invoked.

Fair points, @choumx. Let me take another pass at the code to tidy up things.

Just went through and made ESLint (using google-style) everywhere. Please let me know if something looks odd to your eyes.


Accessibility violation: The ARIA attributes “aria-hidden” are not valid for the element

Reopening issue #728.
Accessibility violation is detected on the

Hi @joyful-these, thanks for reporting the problem!
It's an already know problem, this one will not exist on V5, but V5 will probably take some time to be released, you can follow the progress here: https://github.com/ReactTooltip/react-tooltip/pull/820
Also, if you want and can, please do a PR to fix this problem in V4 and I'll review it as soon as possible.
Thanks!

Closing all v4 issues due to V5 released.
If necessary, please open a new issue using V5, thanks!


[Usage] Inference issue with LLaMA-2-13B-Chat

When did you clone our code?
I cloned the code base after 5/1/23
Describe the issue
Issue:
Unable to perform inference using run_llava. Trying to run inference for llava-llama-2-13b-chat.
Model Weights taken from hugging face.
Projector weights taken from hugging face (newer link)
Command:
python -m llava.eval.run_llava --model-path /fullpathto/llava-llama-2-13b-chat-lightning-preview --image-file /fullpathto/tmp.png --query "Describe this file in detail"

System Details:
OS: 20.04.6 LTS (Focal Fossa)
GPU: A6000 Nvidia
CPU: AMD x86_64
Log:
Screenshot of logs attached

Screenshots:

Hi @rohan598
I forgot to update the prompt template in run_llava.py, and just fix that in https://github.com/haotian-liu/LLaVA/commit/4f801cd99fe2006e95d9946a36710ce125075484. Although strangely, it works for me even without this fix (despite a slight degradation of the quality of the response).
Can you try exactly the same image/prompt that I used to see if the problem still persists?
python -m llava.eval.run_llava --model-path ./checkpoints/llava-llama-2-13b-chat-lightning-preview --image-file https://llava-vl.github.io/static/images/view.jpg --query "What are the things I should be cautious about when I visit here"

Also, we've recently updated our interactive cli chat here, in case you are interested in this as well.

Thank you this change worked!


WIP: Expose :ssl_method param to change default from remote_syslog_sender

With this PR ssl_method param can be set to something other than TLS1.2 (which is the default)
Probably fixes #54

After further reading TLS1.3 is not available through this variable...


Update registry.access.redhat.com/ubi8/go-toolset:1.21 Docker digest to 4ec05fd

This PR contains the following updates:

Package
Type
Update
Change

registry.access.redhat.com/ubi8/go-toolset
stage
digest
bd20572 -> 4ec05fd

[!WARNING]
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Configuration
📅 Schedule: Branch creation - "before 1pm on saturday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the registry.access.redhat.com/ubi8/go-toolset 4ec05fd update again.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Branch 133020769

Pushing internal changes.

@tensorflow-jenkins Test this please.

@tensorflow-jenkins Test this please.


NLP sandbox: Perplexity should be averaged differently and/or documented

Right now the perplexity is calculated per example, and then averaged. This is not very standard; normally you would average the NLL over examples and then calculate the perplexity based on that.
I guess the current situation is a bit dangerous, because the numbers reported seem plausible, but are off by a few points.

Hi, has this problem been solved? I would like to solve it.

Can I solve this? How can I get started(I am a beginner)
?

Pylearn2 don't have a maintainer anymore.
I would recommand that you look for other project to contribute too, like
Theano, Lasagne, Keras or Blocks.
On Sun, Feb 5, 2017 at 3:48 PM, P R G Swamy<EMAIL_ADDRESS>wrote:

Can I solve this? How can I get started(I am a beginner)
?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lisa-lab/pylearn2/issues/1383#issuecomment-277548037,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALC-3PtG29BY7uGhfkkFd4JP6kE8t5kks5rZjW0gaJpZM4DcUYp
.


Percent encoding of content-disposition parameter values

There seems to be a problem with how reqwest encodes values of  Content-Disposition parameters.
RFC 6266 and RFC 8187 defines the characters that can be included without percent encoding in an encoded value of a Content-Disposition parameter as
 attr-char  = ALPHA / DIGIT
              / "!" / "#" / "$" / "&" / "+" / "-" / "."
              / "^" / "_" / "`" / "|" / "~"

which is to say
 a-zA-Z0-9!#$&+-.^_`|~

Reqwest uses PATH_SEGMENT_ENCODE_SET from the url crate to encode parameter values, which in addition allows the following characters
 '(),=@[\]

This causes problems when files having any of these characters in their names are uploaded to servers that rely on the RFC

Sorry for polluting the history :( I had some issues with my network and keyboard...


[ListItem] Added Dynamic Text functionality with tertiaryText prop

Deleted the previous pull request, only one commit now. Sorry for the confusion!

Codecov Report

Merging #89 into master will not impact coverage.

@@          Coverage Diff           @@
##           master     #89   +/-   ##
======================================
  Coverage    85.3%   85.3%
======================================
  Files          13      13
  Lines         592     592
  Branches       78      78
======================================
  Hits          505     505
  Misses         87      87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e353959...39b83bf. Read the comment docs.

No problem @mbenjamin618 :) It's much more better :)
Now, we could talk about this. Could you try to explain how should this work? I mean:
props.numberOfLines === 0 || null -> first, second and third === 1 line
props.numberOfLines === 1 -> first, second and third === 1 line
props.numberOfLines === 2 -> first === 1, second === 1, third?
etc.
Just want to say It's not clear now :) Is there a way how to make it better?

I see what you're saying. I think that changing type of tertiaryText to !tertiaryText might work better too, let me experiment.
Line 272 is basically saying: if there isn't a tertiaryText prop then the numberOfLines prop for the Text will be the numberOfLines const on 255, but if there is a tertiaryText prop then the second line should only ever be 1 line.
Similarly, line 273 does that same thing. I attached a picture with 4 different examples of cards I made with both two and three lines of text/. This is the code for it:
          <Card flex={1}>
            <ListItem
              leftElement={<InitialsAvatar name={'Matthew Benjamin'} color={'red'} />}
              centerElement={{primaryText: 'Primary Text', secondaryText: 'Secondary Text'}}
              numberOfLines={2}
            />
          </Card>

          <Card flex={1}>
            <ListItem
              leftElement={<InitialsAvatar name={'Matthew Benjamin'} color={'red'} />}
              centerElement={{primaryText: 'Primary Text', secondaryText: 'This is long text to show off how the dynamic text field works with only two lines!'}}
              numberOfLines='dynamic'
            />
          </Card>

          <Card flex={1}>
            <ListItem
              leftElement={<InitialsAvatar name={'Matthew Benjamin'} color={'red'} />}
              centerElement={{primaryText: 'Primary Text', secondaryText: 'Secondary Text', tertiaryText: 'Tertiary Text'}}
              numberOfLines={3}
            />
          </Card>

        <Card flex={1}>
            <ListItem
              leftElement={<InitialsAvatar name={'Matthew Benjamin'} color={'red'} />}
              centerElement={{primaryText: 'Primary Text', secondaryText: 'Secondary Text', tertiaryText: 'This is long text to show off how the dynamic text field works with only three lines!'}}
              numberOfLines='dynamic'
            />
          </Card>

I see, sounds good .. but still if we need to think about it so much, what about people who no nothing about this library? :)
I have this idea:
<ListItem
    centerElement={{
        primaryText: 'Always one line',
        secondaryText: { text: 'more than one line', numberOfLines: 'dynamic' },
        tertiaryText: { text: 'one line', numberOfLines: 1 },
    }}
/>

I think it's so clear. But, I have to say it looks like we almost provide the same api as RN does but in another form :)
Maybe your solution is better. What do you think?

I like the idea you wrote, but that wasn't the intention of my update. With mine, even though it looks similar to what is already implemented, it gives the user the capability to start a new line of text on a third line instead of it automatically wrapping. My code doesn't support taking in the props the way you wrote it, but it might be something to look into further when I have more time.


ci: add github workflow

@sarahdayan this one needs more work too, but it's not really a pressing issue. I am implementing a bunch of different action workflows in other projects and learning a lot. I can come back to this later.


chore(website): UpgradingToJest29 admonitions

Summary

Test plan

Thanks! All seems good for my eye. I will look through the rest of your admonition PRs soon too.


Take care about sylius_core.prepend_doctrine_migrations parameters

Hello,
It seems that the sylius core boolean parameter "sylius_core.prepend_doctrine_migrations" is not used at all in the prepend function and this cause error into environment which used "sqlite" db, for example, and doesn't want to be aborted with Migrations which deals with a DB connector.
Thanks.

Thanks, Florian! :1st_place_medal:

Thanks to you for your work


[FR] Stock locations optionally not counted in the available stock

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find a similar feature request

Problem statement
I have some parts that are allocated to RnD team in my company and that I cannot use them for production. It would be nice to have a way to not count them in the current available stock. Thus I can create PO for production according to the correct quantity.
Suggested solution
Stock location object should have a boolean field to discard them from the stock count. Then all RnD parts can be placed in this specific stock locaiton.
Describe alternatives you've considered
The current alternative consiste of putting our RnD parts with the status "Quarantined". An alternative way could come from https://github.com/inventree/InvenTree/issues/4289 by creating a custom "RnD" status.
Examples of other systems
No response
Do you want to develop this?

[ ] I want to develop this.

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

@nuffer that's a pretty reasonable suggestion and should not be too difficult to implement really. Would you be willing to implement this, or perhaps fund the development if you are not able?

As on my  reply in  #4289  -  I also discovered the need for "special" locations that would not count towards the overall store . Now we solve this by marking the item as "LOST" but this means 2 steps when moving between locations : 1st step move, 2nd step mark as LOST ....:-) I'll try to "throw" funds into polar.sh ( unfortunately it's not only up to me:-) )


Help in avoiding widget overlap

Taking into account that I'm fully aware of the issues you covered in your responses to issue #325 ,
I wonder if there is a way to resolve a problem I'm currently experiencing (using rpivotTable).

I display the pivottable correctly on a page, together with  another widget just below.
When I change renderer, say from Table to Treemap (increasign the size of the pivot table), I get the pivottable overlapping the widget below, as the pivot table has increased in size but the widget below hasn't been pushed down as a result.

The desired outcome of course would be to see the widget below dynamically pushed down the page so that there is no overlap.
So far I've played with different css settings but failed to achieve this result.
Could you kindly suggest a css setting that would eliminate the overlap?
Many thanks in advance
(if needed I can paste an example in R using rpivotTable)

I would need an example of this to see what the problem is, as by default this is the behaviour: the pivot table itself is not using absolute positioning, so it should just flow with the page. For example, see http://nicolas.kruchten.com/mtl311/ where there is a pivot table with a footer below it, and no matter what you do to the pivot table, the footer is never overlapped.

my answer in #325  might help


Sentinel All-In-One fails deployment

Link to solution: https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Sentinel-All-In-One
Author: @javiersoriano
While deploying this solution, we find that the main ARM will fails at times. It looks like dependent sub-deployment tasks do not complete there run before other sub-deployment tasks start leading to a "Bad Request" error where the dependent task resource are not yet available.
MAIN Deployment Failure:

Status Message:
{
    "status": "Failed",
    "error": {
        "code": "DeploymentFailed",
        "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
        "details": [
            {
                "code": "BadRequest",
                "message": "{\r\n  \"error\": {\r\n    \"code\": \"BadRequest\",\r\n    \"message\": \"{\\\"error\\\":{\\\"code\\\":\\\"Forbidden\\\",\\\"message\\\":\\\"Subscription: 'REDACTED' under the tenant: 'REDACTED' is not registered to 'Microsoft.SecurityInsights' RP.\\\"}}\"\r\n  }\r\n}"
            },
            {
                "code": "BadRequest",
                "message": "{\r\n  \"error\": {\r\n    \"code\": \"BadRequest\",\r\n    \"message\": \"{\\\"error\\\":{\\\"code\\\":\\\"Forbidden\\\",\\\"message\\\":\\\"Subscription: 'REDACTED' under the tenant: 'REDACTED' is not registered to 'Microsoft.SecurityInsights' RP.\\\"}}\"\r\n  }\r\n}"
            },
            {
                "code": "BadRequest",
                "message": "{\r\n  \"error\": {\r\n    \"code\": \"BadRequest\",\r\n    \"message\": \"{\\\"error\\\":{\\\"code\\\":\\\"Forbidden\\\",\\\"message\\\":\\\"Subscription: 'REDACTED' under the tenant: 'REDACTED' is not registered to 'Microsoft.SecurityInsights' RP.\\\"}}\"\r\n  }\r\n}"
            },
            {
                "code": "BadRequest",
                "message": "{\r\n  \"error\": {\r\n    \"code\": \"BadRequest\",\r\n    \"message\": \"{\\\"error\\\":{\\\"code\\\":\\\"Forbidden\\\",\\\"message\\\":\\\"Subscription: 'REDACTED' under the tenant: 'REDACTED' is not registered to 'Microsoft.SecurityInsights' RP.\\\"}}\"\r\n  }\r\n}"
            },
            {
                "code": "BadRequest",
                "message": "{\r\n  \"error\": {\r\n    \"code\": \"BadRequest\",\r\n    \"message\": \"{\\\"error\\\":{\\\"code\\\":\\\"Forbidden\\\",\\\"message\\\":\\\"Subscription: 'REDACTED' under the tenant: 'REDACTED' is not registered to 'Microsoft.SecurityInsights' RP.\\\"}}\"\r\n  }\r\n}"
            },
            {
                "code": "BadRequest",
                "message": "{\r\n  \"error\": {\r\n    \"code\": \"BadRequest\",\r\n    \"message\": \"{\\\"error\\\":{\\\"code\\\":\\\"Forbidden\\\",\\\"message\\\":\\\"Subscription: 'REDACTED' under the tenant: 'REDACTED' is not registered to 'Microsoft.SecurityInsights' RP.\\\"}}\"\r\n  }\r\n}"
            }
        ]
    }
}

One of the Sub-Deployment Failures:

Status Message for the O365 Connector):
{
    "status": "Failed",
    "error": {
        "code": "BadRequest",
        "message": "{\"error\":{\"code\":\"Forbidden\",\"message\":\"Subscription: 'REDACTED' under the tenant: 'REDACTED' is not registered to 'Microsoft.SecurityInsights' RP.\"}}"
    }
}

Hope this helps. Cheers

Also, If I goes to the sub deployment after they fail, I'm able to redeploy them with success.

It might have been a fluke. the deployment has executed correctly a few time after submitting this.


[17.03] Revert "gnome-session: enable debug"

Dont merge
This PR is only a reminder for 17.03.
Motivation for this change
Debugging should not make it into the next release.
Things done

[x] Fits CONTRIBUTING.md.

Why is this enabled at all in the nixpkgs tree, shouldn't people enable this ?

It's probably alright to merge this.
I enabled it to make debugging easier if bigger problems had come up.
Enabling it for unreleased, unstable (development) versions seemed alright to me.


Demo project does not compile in Delphi 7

Here are the errors below:
Aloso project would not even open till I removed the DSK file
Build
[Error] uFrm_PersonList.pas(54): There is no overloaded version of 'Post' that can be called with these arguments
[Error] uFrm_PersonList.pas(105): There is no overloaded version of 'Put' that can be called with these arguments
[Error] uFrm_PersonList.pas(143): ';' expected but '<' found
[Error] uFrm_PersonList.pas(144): Constant or type identifier expected
[Error] uFrm_PersonList.pas(150): Incompatible types: 'String' and 'Class reference'
[Error] uFrm_PersonList.pas(150): Expression expected but ')' found
[Error] uFrm_PersonList.pas(152): Operator not applicable to this operand type
[Error] uFrm_PersonList.pas(153): Expression expected but 'BEGIN' found
[Error] uFrm_PersonList.pas(156): ')' expected but identifier 'id' found
[Error] uFrm_PersonList.pas(162): EXCEPT or FINALLY expected
[Error] uFrm_PersonList.pas(163): 'END' expected but 'FINALLY' found
[Error] uFrm_PersonList.pas(166): '.' expected but ';' found
[Fatal Error] DelphiRestDemo.dpr(8): Could not compile used unit 'uFrm_PersonList.pas'
I changed:
uFrm_PersonList.pas ( Line 148 from )
vResponse := Dm.RestClient.Resource(CONTEXT_PATH + 'persons')
.Accept(RestUtils.MediaType_Json)
.Get<TList>();
to:
vResource := Dm.RestClient.Resource(CONTEXT_PATH + 'persons').Accept(RestUtils.MediaType_Json);
vResponse := TList(vResource.Get(TList,TPerson));
And The system crashed with Access Violation

This DEMO uses 'generics' so it will only compile with XE(2) and up!
PS: to make things working for XE(2) the reference to the datamodule is nog correct.

Gave up on using this, because the demo did not work.
The demo really should be tested under delphi 7 environments,

I think it would be best to create a second DEMO which does NOT use generics as this demo is valid when generics are available!

@LoganTennis sorry about that.
Probably no one is using this library on Delphi 7. That's why it isen't well tested.
We'll be grateful if you could help us with that.

We don;t work with older Delphi versions anymore - maybe @LoganTennis can try to make one based on the current code?

I would love to update the demo project to be Delphi 7 compatible, unfortunately, I could not get it working. So I ditched the use of this component. In favour of "SimpleRestClient" by Jamie Ingilby.


Add more tests

For ImageModel:

Check for actual image updating and that previous image was deleted
Make test with changing every field
Make test to didn't change any field

For User:

Make test with avatar uploading
Make test with avatar updating
Make test to change every field
Make test to didn't change any field

Addition:

Add tests for wrong request methods


update contributor

What problem does this PR solve?
update @yujunz to contributor file
What is changed and how does it work?
update contributor
Check List
Tests

No code

Code changes

No code

Side effects

Nocode

Related changes

None

@AngleNet Could you provide your email address or create a pr by yourself?

Codecov Report

Merging #226 into master will increase coverage by 2.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage   40.78%   43.64%   +2.86%
==========================================
  Files          20       18       -2
  Lines         738      685      -53
==========================================
- Hits          301      299       -2
+ Misses        404      353      -51
  Partials       33       33

Impacted Files
Coverage Δ

controllers/timechaos_controller.go

api/v1alpha1/timechaos_types.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cadc4fb...2d41f02. Read the comment docs.

My email address is<EMAIL_ADDRESS>. Thank your adding this.

@AngleNet Could you provide your email address or create a pr by yourself?

OK. Will create a PR by myself. @zhouqiang-cl


Add table_exists method to the Catalog

Feature Request / Improvement
Prolonging the discussion in https://github.com/apache/iceberg-python/issues/406
I think having this method on the Catalog would be a great addition. On top of this, we can also leverage the table-exists implementation of the REST catalog by overriding this method in the REST catalog.

could be similar to the mkdirs api? With exists_ok or some param?

@jayceslesar I would keep it simple by just returning a bool.

@kevinjqliu  is this supported ?
AttributeError: 'SqlCatalog' object has no attribute 'table_exists'

If it's open to work, I can take a shot at it!

@MehulBatra That would be great 👍

PR: https://github.com/apache/iceberg-python/pull/678

Hi everyone, I think we've had the implementation. The only "issue" is that this feature hasn't been released yet. I'll add this one to 0.7.0 milestone.
@MehulBatra Thanks for the PR btw. It is good to have more tests for this feature

Thanks @HonahX Let me close it for now 👍


Bugs

Description:
A clear and concise description of what the bug is.
Action version:
Specify the action version
Platform:

[ ] Ubuntu
[ ] macOS
[x] Windows

Runner type:

[x] Hosted
[ ] Self-hosted

Tools version:

Repro steps:
A description with steps to reproduce the issue. If you have a public example or repo to share, please provide the link.
Expected behavior:
A description of what you expected to happen.
Actual behavior:
A description of what is actually happening.

Closed, as a spammy issue.


[tests-only] Bump core commit id on reva master

Part of : https://github.com/owncloud/QA/issues/726

https://drone.cernbox.cern.ch/cs3org/reva/5884/4/5
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

This is a problem these days. It was "fixed" in edge by  the change to .drone.star in PR #2576 and the Makefile change in  PR #2583
I have created PR #2590 to fix it in master.

I rebased and force-pushed. Let's see if we can get green CI.

blocked by PR #2590 - I need a code-owner review of that, to increase the linter timeout!

blocked by PR #2590 - I need a code-owner review of that, to increase the linter timeout!

that was merged. I rebased here. Let's see what CI  thinks now.


Mechanically add 'open' to all public classes.

This applies open to all public classes and all of their non-final public methods, properties, and subscripts, preserving the existing behavior when SE-0117 is implemented. This transformation was performed mechanically using the following sed script (run with sed -E):
/(init|mutating|struct|enum|typealias|final|let|static)/ {
  p
  d
}
/public class/,/^}/ s/public/open/

This should probably be refined soon, but for now this allows us to implement SE-0117 without immediately requiring updates in all clients. Specifically, there are two areas where this change may not be correct to match Foundation on Apple platforms:

Members in extensions cannot yet be overridden, so none of them have been marked open.
Some classes are not intended to be overridden, even in Objective-C. Specifying this requires input from the Foundation team.

Groundwork for SE-0117 "Allow distinguishing between public access and public overridability"

cc @parkera, @rjmccall
@swift-ci Please test

@swift-ci Please test

Ah, this may not work without apple/swift-corelibs-xctest#150.

I've pulled the xctest change, so we'll just merge this as well.  Thanks!


Dendrogram

Hi,
I can't find an example of how to make a dendrogram. Could you direct me to the specific tutorial?
Thanks,
jofrony

Hi! In the light of upcoming breaking changes, I would suggest this:
from neurom.view.view import plot_dendrogram
from neurom.view.common import get_figure, plot_style

nrn = load_neuron('path/to/morphology')
fig, ax = get_figure()
plot_dendrogram(ax, nrn)
plot_style(fig=fig, ax=ax)


Shortcut seems to be working without the shortcut

Steps to replicate:

Download the latest fastDeploy.py cli from repo.
Execute fastDeploy.py --l

This shouldn't work as the shortcut is supposed to be fastDeploy.py -l (which also works) and the long form trigger is fastDeploy.py --list_recipes.

Added a new label for CLI bugs, since they are not as important as fastDeploy core bugs.


[REFACTORING] Refactor backup and enigne monitors

Is your improvement request related to a feature? Please describe (👍 if you like this request)
We've already implemented the gerenalized monitor interface, so the backup and engine monitors can be refactored using the same interface as well as remove the redundant codes.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
https://github.com/longhorn/longhorn-manager/pull/1519

Related to #2441


Fix ActiveRecord::Base.find_all_by_device_type calls

Addresses 2 issues in https://github.com/ManageIQ/manageiq/issues/6754

@matthewd @Fryguy please review


Allow setting CRT's ABI when compiling with MSVC

Based on: https://cmake.org/cmake/help/git-stage/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html

I'm not using Qaterial as shared library but what does it fix?
Isn't something the user should choose when doing cmake configure command?
Is it still possible to overwrite CMAKE_MSVC_RUNTIME_LIBRARY with MultiThreadedDLL if needed?

I'm not using Qaterial as shared library but what does it fix? Isn't something the user should choose when doing cmake configure command? Is it still possible to overwrite CMAKE_MSVC_RUNTIME_LIBRARY with MultiThreadedDLL if needed?

I have an application that uses Qaterial along with other vcpkg libraries compiled using the triplet x64-windows-release. In that triplet a static CRT is used, which cannot be mixed with Qaterial's shared CRT. Setting CMAKE_MSVC_RUNTIME_LIBRARY is an option but for that we would still need to increase the minimum CMake version. Do you want me to just increase the CMake version without adding this logic?

Why do you need to increase the mnimum version? It doesn't work if you just use cmake v3.15?

For example Qaterial use precompiled headers, that are cmake 3.17 feature. It is only enabled if target_precompile_headers command is available.
But if in your case it is not taken into account, then yes increase minimum version. Ubuntu 20 is shipped with cmake 3.16. So that's ok

Done

For example Qaterial use precompiled headers, that are cmake 3.17 feature. It is only enabled if target_precompile_headers command is available.
In this case using a minimum version lower than 3.15 sets a policy that ignores default runtime flags.


Create BANGLADESH DISTRICT GAZETTEER KUSHTIA

This PR fixes #

BANGLADESH DISTRICT GAZETTEER KUSHTIAhttps://books.google.com.bd/books?q=editions:LCCN73169289&id=DjBGAQAAIAAJ


Loading of images that don't have the proper permission [🐛]

Description
The permission of "selected images" is ignored. All the images from the image gallery are able to load in the app even if they don't have permission. Tested on iOS.
How to repeat issue and example
I used the example app provided in this repo.

Press button "Select Image" -> Result: Permission modal pops up
Press "Select Photos..." -> Result: Image picker pops up
Select one photo and then press done  -> Result: Image picker pops up
Pick a different photo that the one you selected -> Result: The photo is loaded to the app. This shouldn't happen.

Solution
Only the images with the appropriate permission should be able to load into the app.
Additional Information

Image Picker version: 4.7.3
React Native version: 0.66.4
Platform: iOS
Development Operating System: MacOS
Dev tools: intelliJ

Have the same issue

I have the same issue.

Looks like this isn't actually a bug. react-native-image-picker is using Apple's PHPicker under the hood and as explained here, the picker runs out of process, so your app will only receive the content that the user selects. That means that even though it's displaying images that the user didn't grant access to your app only has access to the image that's selected (which confusingly could be an image that they didn't previously grant access to).
This is pretty confusing from the users' perspective but it looks like an issue with Apple's PHPicker and not react-native-image-picker.


chore: general repo cleanup

Changes this PR makes:
Well, lots of things!
Changes are listed for every file.
Feel free to revert/comment any change ofc.
If CI don't pass... well I'll try to fix them!

.eslintrc.json: added ignorePatterns to ignore compiled code, added some node rules;
.github/workflows/test.yml: added a workflow to test eslint and typescript on push/pr to main;
.husky/pre-commit: added a pre-commit command that is run automatically by git before a commit, to prevent committing changes without running eslint and prettier;
.prettierrc.json: ordered keys;
CODE_OF_CONDUCT.md: added code of conduct, as every repo has it and it's recommended;
LICENSE: same as above, using MIT as it's the best for the current project;
README.md: it's recommended to add a readme and so I did, not sure what to put other than the current description tho;
package.json: removed any check to the build script as it's not necessary and it just slows down the build, especially on replit, removed the prettier check from tests as it's not useful for the compiled code and it's really slow especially on replit where you may get errors just because it uses different line ending than your local project. Enabled source maps in the node command to see stack traces pointing to TS files.
tsconfig.json: use recommended node config and add source maps, remove all rules that are in the recommended configuration;
Use node: protocol for importing from node built-in packages;
All other changed files were done to reflect the previously listed changes.

i love you

LGTM.


Functions missing in sound API

 Issue by vlidholt
Thursday Aug 13, 2015 at 23:45 GMT
Originally opened as https://github.com/flutter/engine/issues/611

In order of priority:

SoundTrack:s cannot be looped (needed for background music)
There are no callbacks when SoundTrack:s complete
SoundTrack:s cannot control the volume (would be required for fading/mixing different music tracks)
SoundEffect:s should use Android's SoundPool classes instead of MediaPlayer (required for the following bullets)
SoundEffect:s are missing looping, volume, pitch, and pan controls (required for positional audio)
SoundEffectStream:s are not being properly deleted when finished playing and thus leaking memory
SoundTrack:s are not being properly deleted when finished playing and thus leaking memory
All other missing callbacks for SoundTrack and SoundEffect.

 Comment by eseidelGoogle
Thursday Aug 13, 2015 at 23:48 GMT

Thank you! This is very helpful.

 Comment by vlidholt
Tuesday Nov 03, 2015 at 23:52 GMT

API here: https://github.com/vlidholt/sky_engine/blob/master/skysprites/lib/src/sound.dart

Split this issue up in a number of smaller issues, closing.

Related: https://github.com/flutter/flutter/issues/729


navigator.userAgent checking for locale

Quick thoughts to myself on an additional way to check. After taking a quick glance here after researching something completely different, I noticed the user agent string had a locale in it. Preliminary check:
'Mozilla/5.0 (iPad; U; CPU OS 3_2 like Mac OS X; en-us) AppleWebKit/531.21.10 (KHTML, like Gecko) Version/4.0.4 Mobile/7B334b Safari/531.21.10'.match(/;.(\w+\-\w+)/i)
> ["; en-us", "en-us"]

regex obviously will need to improve and i'll need to add some tests.

added in latest release d7a20e08144be8793f96affbfc24e4b3d9bd0e7b


"Backup" via replication

Question in Gitter:

We plan to have separate "datacenter" type locations, so mini local clusters, as in, separate locations
So a local location collecting data and then a cloud location to back it up
However we don't know all the time that we'll have connectivity between the cloud and the local location
Does cockroach support something like LOCAL_QUORUM where the writes only initially go to the local cluster
I've read about the replication stuff

@RaduBerinde 's answer in Gitter:

Not really, we have to wait for writes to finish to a quorum of replicas. If more than half are local that should work fine. Unfortunately we don't yet have very good support for spread-out clusters (performance-wise).

More insight from @bdarnell:

the remote copy is not actually going to be useful as a backup, because it can’t have a quorum
it’s a common ask for people who are confused about the relationship between replication and backups
people asking this question want backups, and they’re hoping they can get it for “free” with replication
it makes sense to have three datacenters so that they can all be backups of each other. it doesn’t make sense to have one primary datacenter and one second-class one (for similar reasons that replication configs should always be odd numbers)

This hasn't come up again, so closing.


Unable to open most rules

See attached recording. This is true for most rules, but not all.

Any errors in console?

Turns out I had to update everything, and now it works. I have a follow up question I'll DM you about.


Cluster provisioning fails on unknown flag: --config-override-file

Hive cluster provisioning fails. Logging in to the bootsrap node, found this error on journalctl:
bootkube.sh[27891]: unknown flag: --config-override-file
...
systemd[1]: bootkube.service: main process exited, code=exited, status=1/FAILURE

Is this fixed with the environment update?

Yes, looks like it.


Connection issues against Opensearch

Describe the bug
We are migrating from Elasticsearch to Opensearch and when I try to configure a connection to the Opensearch url with username/password, I get an Authentication finally failed response.
I've confirmed my credentials by querying through cURL and Postman, so this seems to be something specific to the plugin.
It is of course possible that this is not a bug, that the plugin ONLY works with Elasticsearch and not Opensearch; however, I've seen some mentions of the latter in other Issues as I searched for my problem.
...
To Reproduce
Steps to reproduce the behavior:

Go to create a connection
Set the Host to a valid Opensearch URL
Select the Username & Password auth option
Enter valid credentials
Press either Test or Apply

Expected behavior
A working connection.
Screenshots
If applicable, add screenshots to help explain your problem.
Could you consider donate to me: https://chengpohi.github.io/

Got it, Thanks your feedback, I will try to reproduce this issue, and fix it in next version

Hi @coyotesqrl , Could you try version 1.0.18, download from Jetbrains market v1.10.18 or manual install by Github release v1.10.18.
and use the opensearch dashboad proxy(select Kibana Host Proxy option) to connect your opensearch:

I have tested in newst opensearch version it works, if you still meet issue, please paste opensearch version and security info.
Thanks your feedback

I'm not exactly clear what I'm supposed to be using for my connection. Is there some local proxy I'm supposed to be running to connect to my AWS opensearch instances? That was not the case previously.

@coyotesqrl can you let me know your opensearch version?

Kibana host proxy means that if you can't directly connect Elasticsearch/Opensearch, but you can visit Kibana/Opensearch dashboard, you can use Kibana/Opensearch dashboard url(ex: http://localhost:5601), and selected Kibana host proxy, this method will visit Elasticsearch/Opensearch by throught Dashboard proxy

Thanks. Using the AWS proxy resolved it. The issue is complete as far as I'm concerned.


Fix local_tank_cache handling in shark_downloader.

On import of the shark downloader, the shark_tank local cache (WORKDIR in shark_downloader.py) should be determined by the following method.

If shark_args.local_tank_cache is set, WORKDIR is set to that path.
If shark_args.local_tank_cache is not specified and there exists a locally generated shark_tank (at SHARK/gen_shark_tank), use that directory as WORKDIR. This is mostly for the nightly CI.
If conditions for 1 and 2 are not met, use <HOME>/.local/shark_tank/ as WORKDIR.

Option #2's condition was written as an if statement instead of elif which caused option #3 to overwrite WORKDIR.
Ideally we don't use shark_args at all, but that is a larger undertaking.

Ideally we don't use shark_args at all, but that is a larger undertaking.

👏


Groups in groups

It would be great if this library supported "groups in groups".

This issues was fixed by PR https://github.com/jamesscottbrown/pyyed/pull/21.