Define tests to include in ArcGIS app vs GitHub CI

We need to come up with lists of tests that are/can be included in the ArcGIS app vs those that should be programmed in GitHub CI system.

I've started a tentative list in this doc.

Note: There are presumably some checks that could be done in either the ArcGIS app or GitHub CI. It's preferable to have as many as feasible in the field, but the CI system would be useful for ones that are hard to code. This is something we'll want to discuss with Stuart, Sean, and others.

@jess-shue, if you need help with this, I'd be happy to look at the ArcGIS app with you and help you figure out how to code the tests. (Full disclosure: I have never seen the interface you are working with, and I don't even know the coding language needed, but I am confident I can provide some help if you don't get it elsewhere)

@ValentineHerr Thank you! Right now, my main issue is that I can build the app, but not with the relate that Milton has created for BCI between trees and stems - I'm missing a detail on how he did it. I will definitely reach out once I cross a few other hurdles; thanks again!

Here are Suzy Sine's comments about errors found using the app on BCI:
Since we were the first ones to test the app, our experience with BCI does not mean you will encounter the same problems. Following are some observations.

Make sure that you include ALL the stems that you want recensused, and make sure that all of them get uploaded into the app. I am not really sure why some plants were not uploaded (Milton and David can better explain this to you).  It may have to do with the coordinates not coinciding with the quadrat they were supposed to be in, or that some dbhs did not fall within the dbh range set up in the app. I believe that this "bug" may have been fixed, but I still check.
The main stem appears in the main form, while the multiple stems of multiple-stemmed trees appear in a secondary form. I find that some secondary stems do not get measured. The app lets you know which trees have not been recensused yet by the color, but it does not let you know if a multiple stem was not measured.
Your R script should check for diameters that increase too much (growth rate too high) or decrease too much without an explanation. The app does not check for this.
At BCI, we do not include all the trees in the database in the census form. We only include trees that are alive and those that died the previous census. So we check that the tags used by new recruits have not already been used in the database by a tree that had died.
Check for duplicate stem tags. The app does not check for this.
I check for dbhs that are 0 (not measured), they should have a code explaining why it was not measured (dead, stem broke off, stem does not reach 1.3 m in case of multiple-stemmed trees, etc.).

@ValentineHerr , we'll want to be sure to include all of these in our GitHub CI.

@jess-shue , are you at the point where you could provide some dummy output data so that @ValentineHerr can start preparing the GitHub CI system?

@teixeirak Yes, but I think this would be a good time to touch base and go over a few things for our workflow. Would you have time next week for a demonstration? I could use your opion/thoughts on things - and really David's as well since he'll be leading things. There is still a lot I don't know/understand regarding the back-end of the data and how they're dealing with field corrections.
I wasn't able to meet with Milton this week because he is under the weather.

Hi Jess, Valentine, and David,
I’m moving this conversation to email since David’s not on GitHub yet. If we want to do this demo before David arrives (March 9?), next week is probably the best time, as I’ll be traveling the following Wed-Sun (March 1-5). Tuesday, Wed, and Friday are pretty open for me.
K
From: jess-shue @.>
Date: Friday, February 17, 2023 at 2:12 PM
To: SCBI-ForestGEO/2023census @.>
Cc: Teixeira, Kristina A. @.>, Mention @.>
Subject: Re: [SCBI-ForestGEO/2023census] Define tests to include in ArcGIS app vs GitHub CI (Issue #3)
External Email - Exercise Caution
@teixeirakhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fteixeirak&data=05|01|teixeirak%40si.edu|db6f53b6b34d479e5fc408db111aedd8|989b5e2a14e44efe93b78cdd5fc5d11c|0|0|638122579584573769|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Q2pEx0QmjQvtznliBRlcfI9nd9Tiua%2Bm4i0Fv4Rt2ME%3D&reserved=0 Yes, but I think this would be a good time to touch base and go over a few things for our workflow. Would you have time next week for a demonstration? I could use your opion/thoughts on things - and really David's as well since he'll be leading things. There is still a lot I don't know/understand regarding the back-end of the data and how they're dealing with field corrections.
I wasn't able to meet with Milton this week because he is under the weather.
—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSCBI-ForestGEO%2F2023census%2Fissues%2F3%23issuecomment-1435118915&data=05|01|teixeirak%40si.edu|db6f53b6b34d479e5fc408db111aedd8|989b5e2a14e44efe93b78cdd5fc5d11c|0|0|638122579584573769|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qhUe1Oz9gS8xUUAR14%2FguF4rUprOu0LnaKm9dpqYiO8%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABQPXDWVX3BWECNNAD7RQL3WX7ESHANCNFSM6AAAAAAQH4FSK4&data=05|01|teixeirak%40si.edu|db6f53b6b34d479e5fc408db111aedd8|989b5e2a14e44efe93b78cdd5fc5d11c|0|0|638122579584730012|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=PISWJ2EpeTz%2Bxi%2FoWHvbFViW7GQG6EzDOvrss%2FbP4zg%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Thanks Krista,
Yes, I think it would be great to meet now, and go over what I have so far. Having input from you and especially David will be important to finalizing things - and will help me put a list together of things to ask Milton about.
I have Tuesday before 1 pm open, Wednesday before 10 am, or Friday any time.
Thanks,
Jess

From: Kristina Anderson-Teixeira @.>
Sent: Friday, February 17, 2023 2:25 PM
To: SCBI-ForestGEO/2023census @.>
Cc: Shue, Jessica @.>; Mention @.>
Subject: Re: [SCBI-ForestGEO/2023census] Define tests to include in ArcGIS app vs GitHub CI (Issue #3)
External Email - Exercise Caution
Hi Jess, Valentine, and David,
I’m moving this conversation to email since David’s not on GitHub yet. If we want to do this demo before David arrives (March 9?), next week is probably the best time, as I’ll be traveling the following Wed-Sun (March 1-5). Tuesday, Wed, and Friday are pretty open for me.
K
From: jess-shue @.>
Date: Friday, February 17, 2023 at 2:12 PM
To: SCBI-ForestGEO/2023census @.>
Cc: Teixeira, Kristina A. @.>, Mention @.>
Subject: Re: [SCBI-ForestGEO/2023census] Define tests to include in ArcGIS app vs GitHub CI (Issue #3)
External Email - Exercise Caution
@teixeirakhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fteixeirak&data=05|01|teixeirak%40si.edu|db6f53b6b34d479e5fc408db111aedd8|989b5e2a14e44efe93b78cdd5fc5d11c|0|0|638122579584573769|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Q2pEx0QmjQvtznliBRlcfI9nd9Tiua%2Bm4i0Fv4Rt2ME%3D&reserved=0 Yes, but I think this would be a good time to touch base and go over a few things for our workflow. Would you have time next week for a demonstration? I could use your opion/thoughts on things - and really David's as well since he'll be leading things. There is still a lot I don't know/understand regarding the back-end of the data and how they're dealing with field corrections.
I wasn't able to meet with Milton this week because he is under the weather.
—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSCBI-ForestGEO%2F2023census%2Fissues%2F3%23issuecomment-1435118915&data=05|01|teixeirak%40si.edu|db6f53b6b34d479e5fc408db111aedd8|989b5e2a14e44efe93b78cdd5fc5d11c|0|0|638122579584573769|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qhUe1Oz9gS8xUUAR14%2FguF4rUprOu0LnaKm9dpqYiO8%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABQPXDWVX3BWECNNAD7RQL3WX7ESHANCNFSM6AAAAAAQH4FSK4&data=05|01|teixeirak%40si.edu|db6f53b6b34d479e5fc408db111aedd8|989b5e2a14e44efe93b78cdd5fc5d11c|0|0|638122579584730012|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=PISWJ2EpeTz%2Bxi%2FoWHvbFViW7GQG6EzDOvrss%2FbP4zg%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>
—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSCBI-ForestGEO%2F2023census%2Fissues%2F3%23issuecomment-1435133349&data=05|01|shuej%40si.edu|64d707ac5a3a4413e34208db111cc0a7|989b5e2a14e44efe93b78cdd5fc5d11c|0|0|638122587422765825|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=ksaZrzY37SZCJYZ1RrWb%2FWloWWk4Uce7qdvxln170Yg%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAI5MYOOKOP6ALKNSNIPUKXLWX7GDFANCNFSM6AAAAAAQH4FSK4&data=05|01|shuej%40si.edu|64d707ac5a3a4413e34208db111cc0a7|989b5e2a14e44efe93b78cdd5fc5d11c|0|0|638122587422765825|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=OkDSt1FvRXdJFpIkzXUrnpst4viZnBahjipYxZylWYg%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @ValentineHerr:

The only 'filtering' I applied was to create the mortality category for each stem. Otherwise, all stems should be included. I didn't remove DN stems either in case of resprouting, and to avoid something not being in the app.
I've arranged things slight differently for SCBI so that there is a 'tree' or main stem form, but all measurements will be recorded using the 'stem' form (even the main stem) so that all mortality data are also collected in one place. I hope the workflow will allow folks to see the list of stems for a multi-stemmed tree along with it's census_status (finished, not started, etc.). Then, on the main page they will select the 'tree' census_status (finished, not started, etc.). Not sure this is the best way to do this, but my thoughts on it for now.
I have included an error message when the DBH decreases by 0.5 cm or increases by 4 cm - the 4 cm was a standard used for excess growth at Lilly Dickey Woods last summer and I believe it will be a good benchmark at SCBI. My main concern with this is that I'd like the error to distinguish between dead standing and living trees, but right now that status isn't taken into account. It is only an error message, so it won't hinder folks from collecting data. Since dead standing DBH will be collected I think this is our best option, but will still need to be double checked on the back-end.

That was intended to point here: https://github.com/SCBI-ForestGEO/2023census/blob/main/doc/methods.md. Apparently I never actually started the list!
It would be great if you could update that doc (or some other) to list the tests you code.

@jess-shue what units will the dbh be measured with?
If not mm, can they be in mm in the back end, to be consistent with previous censuses? (I can code it if necessary, but I need to know what they are recorded in.)
@teixeirak, I am going to flag the following cases:

previous_dbh * 0.972 > current_dbh (so allowing a 3% decrease)
previous_dbh * 1.125< current_dbh (so flaging when growth is greated than12.5%).

I got the numbers by looking at median of all positive (resp. negative) "naive" growths from census 1 to census 2, and census 2 to census 3:
x = (current - previous)/previous
> 1 + median(x[x>0])
[1] 1.125
> 1 + median(x[x<0])
[1] 0.9722222

let me know if that sounds good to you.

6. I check for dbhs that are 0 (not measured), they should have a code explaining why it was not measured (dead, stem broke off, stem does not reach 1.3 m in case of multiple-stemmed trees, etc.).

@teixeirak and @jess-shue, can you double check me here?
I understand I need to flag cases where current dbh is 0 but the following codes are not listed in the codes column:

C: dead above 1.3m
X: stem broken below 1.3 m.

The complete list of code is:

code
def

CL
clear list

A
alternate HOM

B
broken above 1.3 m

C
dead above 1.3 m

F
within deer exclosure

G
ID to Genus uncertain

I
stem irregular where measured

J
stem bent

L
stem leaning

main
main stem

M
multiple stems

S
secondary stem

P
stem prostrate

RT
replace tag

NN
new nail or wire

R
resprout

X
stem broken below 1.3m

TR
tag removed

WR
wire removed

@jess-shue what units will the dbh be measured with? If not mm, can they be in mm in the back end, to be consistent with previous censuses? (I can code it if necessary, but I need to know what they are recorded in.)
@teixeirak, I am going to flag the following cases:

previous_dbh * 0.972 > current_dbh (so allowing a 3% decrease)
previous_dbh * 1.125< current_dbh (so flaging when growth is greated than12.5%).

I got the numbers by looking at median of all positive (resp. negative) "naive" growths from census 1 to census 2, and census 2 to census 3:
x = (current - previous)/previous
> 1 + median(x[x>0])
[1] 1.125
> 1 + median(x[x<0])
[1] 0.9722222

let me know if that sounds good to you.

I can do mm - I had originally used mm because of the data. However, the 2018 protocol said to collect in cm. @teixeirak What would you prefer?

I check for dbhs that are 0 (not measured), they should have a code explaining why it was not measured (dead, stem broke off, stem does not reach 1.3 m in case of multiple-stemmed trees, etc.).

@teixeirak and @jess-shue, can you double check me here?
I understand I need to flag cases where current dbh is 0 but the following codes are not listed in the codes column:
* C: dead above 1.3m

* X: stem broken below 1.3 m.

The complete list of code is:
code 	def
CL 	clear list
A 	alternate HOM
B 	broken above 1.3 m
C 	dead above 1.3 m
F 	within deer exclosure
G 	ID to Genus uncertain
I 	stem irregular where measured
J 	stem bent
L 	stem leaning
main 	main stem
M 	multiple stems
S 	secondary stem
P 	stem prostrate
RT 	replace tag
NN 	new nail or wire
R 	resprout
X 	stem broken below 1.3m
TR 	tag removed
WR 	wire removed

Sorry, I'm not sure what you're asking here. (Maybe it's just too early in the AM and my brain is fried from conference!)

Sorry for the slow response. You're saying we'd flag as an error anything above/below the median % growth/shrinkage? Wouldn't that be flagging about 1/2 the measurements? I think there's something I'm not understanding.

Oh, right sorry, I had meant to change median to an extreme quantile.....
Thinking of using this...

1 + quantile(x[x>0], 0.97)
97%
1.92
1 + quantile(x[x<0], 0.03)
3%
0.757355

We can adjust the numbers when we get a sense of how many measurements if will flag.

I can do mm - I had originally used mm because of the data. However, the 2018 protocol said to collect in cm. @teixeirak What would you prefer?

I don't have a strong preference. (As you say, conversion is easy.) @jess-shue , do you find that one or the other works better for the census crew?

Maybe David can decide. But it would be great if the data was in mm in the backend regardless.

ok perfect!

We can adjust the numbers when we get a sense of how many measurements if will flag.

That's still flagging ~6% of measurements as potentially erroneous, which would be a lot of records to revisit!
@jess-shue , is there a control in the ArcGIS app?

I have included an error message when the DBH decreases by 0.5 cm or increases by 4 cm - the 4 cm was a standard used for excess growth at Lilly Dickey Woods last summer in FFFs, using that as a reference. My main concern with this is that I'd like the error to distinguish between dead standing and living trees, but right now that status isn't taken into account. It is only an error message, so it won't hinder folks from collecting data. Since dead standing DBH will be collected I think this is our best option, but will still need to be double checked on the back-end.


No data after waking up from hibernation/sleep/standby

First scenario:

connect to a serialport
write some data    --> data event is emitted
let system go to sleep
let system wake up
write some data    --> data event is not (never) emitted

to work again with the device I have to unplug it and retry...
Second scenario:

connect to a serialport
write some data    --> and directly go to sleep
let system go to sleep
let system wake up
--> data event is not (never) emitted

@voodootikigod any ideas?

I'm having the same issue with arduino.


Update specifying version does not pin version in paket.dependencies

This PR fixes #973.

LGTM thx.


Issue with the 'Picks' tab once Survivor created

The 'Picks' is only showing 'Initialize Sheet' even though I already create the Survivor. I don't see the other options.

Thanks for checking it out. There have been a few instances of people not getting the script to set a variable properly to cause it to load the initialize menu instead of the in-season one.
To correct it, using a web browser, go to "Extensions" > "Apps Script" and go to the Project Settings (gear icon) on the left pane. Then scroll down to "Script Properties" where you'll need to edit the variables to add one called "initialized" that has a value "true". Then try to refresh the sheet and see if the menu loads correctly.

Thank you!


[Service Bus] Function extensions release prep

Summary
The focus of these changes is to prepare the Service Bus Functions extension package for release.

    public EnvironmentCredential(EnvironmentCredentialOptions options)
        : this(CredentialPipeline.GetInstance(options), options)


MS Edge supported?

Using the latest version (10.3.0) I can't get lazyload to work in MS Edge 15 (latest version). Is it supported and/or are there any special steps to make it work?
var loadImages = new LazyLoad({
  elements_selector: "[data-src]"
});

and

URL: http://www.via-electra.eu/2017/
Thanks!

It's supposed to work, but I can't tell tell you for sure now, since I'm away from my Windows machine until the 26th. Is it working in other browsers?

Could you report any error you receive in the browser console (F12 to open it on Edge)?
Is version 8 working on Edge? You could stick to that until I fix version 10 :)

Hello Andrea,
yes, it is working OK in Chrome and Safari. The funny thing is I don't seem to be getting any errors with 10.3.0:

I'll try version 8 again, but I didn't have any luck with that before either.

Thanks for the report.
If neither 10 nor 8 work on Edge, maybe the problem is related to the HTML errors that I see in your browser console?
It says that you're using a self closing tag and it can't be, that you should close it. Which tags is it referring to?
Please report your HTML and JS code here, that could help me to help you. :)

I can confirm, that 10.3.0 did not work in Edge for me as well. No errors in console shown.
Now using 8.2.0, after setting {data_src: 'src'} it works.
Thank you!

Happy to confirm reverting to 8.2.0 and setting data_src: 'src' does the trick! I tried 8.2.0 before, but the data_src is apparently the critical part.
Thanks @liepumartins for the tip!

@chrisjansky, what @liepumartin wrote is correct because the default options object changed between version 8 and 10. Find the docs in the README file of release 8 downloading the zip file here

I replace
var onIntersection = function onIntersection(entries) {
    entries.forEach(function (entry) {
        if (!entry.isIntersecting) {
            return;
        }
        var element = entry.target;
        revealElement(element, settings);
        _this._observer.unobserve(element);
    });
    _this._elements = purgeElements(_this._elements);
};

by
var onIntersection = function onIntersection(entries) {
    entries.forEach(function (entry) {
        if (entry.isIntersecting !== null && entry.isIntersecting === false) {
            return;
        }
        var element = entry.target;
        revealElement(element, settings);
        _this._observer.unobserve(element);
    });
    _this._elements = purgeElements(_this._elements);
};

because when i debug on MS Edge "entry.isIntersecting" is null not boolean

Coincidentially I had the same issue, but on Chrome 56 and lower and was searching for a solution right now. I tried the fix of npdung and this works! This is the correct answer on this issue.

I cannot debug on Edge 15 because my network administrator doesn't allow the update yet, and on at home a use a Mac. I think it's time to install a VM :D
Could you explain better why the condition in the if statement, meaning (!entry.isIntersecting) is not working on Edge? If the problem is that entry.isIntersecting is null as you explained, shouldn't it work anyway, since !null evaluates as true?
Thanks
/cc @aliasltb @npdung

I found the bug documentation: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12156111/

Released 10.3.1

@aliasltb @npdung let me know if version 10.3.1 works on MS Edge 15 please. Thanks

@verlok thank for your update and bug documentation, it working.

@verlok  I updated your plugin to 10.3.1, but for me the loading behaviour is strange. I used this on Chrome 57 and all images do load as expected. But when I use lazyload in an owl carousel, the upcoming slides don't load the images - at least not immediately. With the solution of @npdung I works perfectly everywhere.

The solution that @npdung provided is working only because it immediately loads all the images on some browsers… but that's not lazy loading.

@aliasltb  version 10.3.1 is work with owl carousel, on Chrome 61, MS Edge 15.
my product: https://tacavet.familala.com/

Still not working on latest version of MS Edge.

@adriandmitroca which version of LazyLoad are you using? The recommended (8.2.1) or the latest (10.3.3)? And what problem are you experiencing?

I have tried basically all available versions - latest builds for 8, 9 and 10. None worked.
On 30 Oct 2017, 22:53 +0100, Andrea Verlicchi<EMAIL_ADDRESS>wrote:

@adriandmitroca which version of LazyLoad are you using? The recommended (8.2.1) or the latest (10.3.3)? And what problem are you experiencing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks. With "none worked" you are not helping me to help you. What kind of problem were you experiencing? Did you get any javascript errors? Could you post the HTML and JS code you used? Thanks

Sorry @verlok, I didn't mean it. I was referring to previous comments.
What I did was pretty much basic setup with just data-src attributes on img and initialization new LazyLoad().
It worked great on all browsers, including IE9 except Edge, where images do not load at all.

Hi @adriandmitroca,
you should definitely stick with version 8.x and use data-original instead of data-src.
In fact, the API was different in 8.2.x as stated in the m documentation provided in the README.md for that version (download the zip for version 8.x then read README.md).
Let me know if this solves.
Thanks!

Sorry, the option name is still data_src but the default option value is original so the HTML attribute it’s looking for is data-original.
Here the documentation: https://github.com/verlok/lazyload/blob/master/README_v8.md#api
Long story short, if you want to keep data-src in your HTML you just need to do:
new LazyLoad({data_src: "src"});


Add Cardknox Gateway

I got all the tests passing for all of the builds (the one where it's failing seems to be for an unrelated reason?)
I didn't get rid of the monkey patch, and in light of the discussion above am not sure if it's worth working on it.


Question: What do i do to return a subtree

Hello colleagues, lets say i had a graph and i want to return a subtree of a node.
For example query may look like this.
"MAG
            .StartFrom($($g.CellId))
            .FollowEdge(`"OutEdge`")
            .VisitNode(_ => Action.Continue & Action.Return)
            .FollowEdge(`"OutEdge`")
            .VisitNode(_ => Action.Continue & Action.Return)"

The example above, as i understand, returns only two child nodes. However i don't know the depth of a subtree. It could be a single node or no children at all, or it could be tens of sub-nodes with their sub-nodes. Is there any sample query to extract a sub-tree?
Thanks

Thanks @yatli, maybe i misunderstood something in your answer. Let me clarify the ask. Actually i was talking about a way of representing Depth-first search(DFS) algorithm trough LIKQ query, so to speak. The idea is to traverse the graph to the full depth starting from some node. Is it possible with LIKQ?


Proof of Concept documents

This is the batch of documents for testing out ReadTheDocs (RTD) infrastructure.
It is a bit of a hefty PR, so a list of things that are in there:

The stubbed out Table of Contents
Each of the document linked in the TOC in its place (folder)
Stub notices for unfinished pages
DNX documents from the ASP.NET documentation
.NET Primer and CLR overview from the CoreCLR repo (converted to reST)
Config file for RTD

/cc @richlander

LGTM


Fixes css of task requests listing page filter and sort modal

Date: 4 December 2023
Developer Name: @Ajeyakrishna-k

Description
Fixes css of task requests listing page filter and sort modal
Breaking Changes

[ ] Yes
[x] No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.
Development Tested?

[x] Yes
[ ] No

Confirm whether the changes have been tested locally during development.
Tested in Staging?

[x] Yes
[ ] No

Indicate whether the changes have been tested in the staging environment.
Under Feature Flag

[x] Yes
[ ] No

Database Changes

[ ] Yes
[x] No

before:

after:

I think the drop-down model should start from the end of the button, instead of being at the center, Do you any thoughts?


Don't exclude raw expression columns

WHY
BEFORE - What was wrong? What was happening before this PR?
Apart from where constrains there is also having constrains. The later can be applied on the result of expressions like aliases, sum, avg etc while where can't.
static::addGlobalScope('withPrice', function($query) {
    return $query->selectRaw('price as my_price')->having('my_price', '>', 20); //you can't replace having with where on the alias column.
});

AFTER - What is happening after this PR?
We still exclude all columns except the ones that are raw expressions. Sometimes it could be an expression that we could remove, others like in the example I gave can't be excluded otherwise the having wouldn't have the column available. Given the complexity involved in parsing expressions to see if it's one that we could remove we are better just letting all raw expressions go through. Majority of time that's what needs to be done anyway.
HOW
How did you achieve that, in technical terms?
We store the expression columns before cloning the query without columns. We then manually re-add the expression columns along with the column we select for the count.
Is it a breaking change?
No
How can we test the before & after?
Go to Product.php model on demo, add:
protected static function boot() {
        parent::boot();
        static::addGlobalScope('withPrice', function($query) {
            return $query->selectRaw('price as my_price')->having('my_price', '>', 20);
        });
    }

Try to load the list view.

A new inspection was created.

I can confirm this works as intended! Good work @pxpm!

Damn. Thanks guys, I just hit merge but I see it was pointing to fix-alias-name-for-msslq-rdbm, not main 🤦♂
What do you want me to do? Do you want me to revert?

Never mind. Looks like that was a super simple PR so I'll just merge that one too.


Add auto fetching cache

This is an alternative implementation of a cache with an auto fetching feature

Lets create this as a new module called mules-reload because of the extra dependency. I think its a good fit, but the extra dependency has had me on the ropes.
Would you like me to do this work? It was my fault for delaying so long so I can do that translation.

Can't say I've been very active also. I can do it. I'll try to do it before tuesday.


Add --local-repo and --offline flags to revert operation

The RevertCommand already seems to use these attributes.


Enable full set of unicode characters

Enable the full set of unicode characters by setting fullUnicode: true in the properties for the Blessed Screen.
I've verified this enables the display of 测试 (test) in the console log. Prior to change this displayed as "??".
Screen options

fullUnicode - Allow for rendering of East Asian double-width characters, utf-16 surrogate pairs, and unicode combining characters. This allows you to display text above the basic multilingual plane. This is behind an option because it may affect performance slightly negatively. Without this option enabled, all double-width, surrogate pair, and combining characters will be replaced by '??', '?', '' respectively. (NOTE: iTerm2 cannot display combining characters properly. Blessed simply removes them from an element's content if iTerm2 is detected).

Fixes #18

Hey @pyrodogg, thanks for tackling this!


strconv: ParseFloat not working correctly for negative exponent

What version of Go are you using (go version)?

$ go version
go version go1.13.1 darwin/amd64

Does this issue reproduce with the latest release?

Converting string to float32 with
strconv.ParseFloat
https://play.golang.org/p/8bexC3OjUKs
What did you expect to see?
For a given value less than SmallestNonzeroFloat32 I expect an "value out of range" Error.
What did you see instead?
a result equals to 0 ! And no Error !

/cc @griesemer

This is working as intended.
SmallestNonzeroFloat32 = 1.401298464324817070923729583289916131280e-45. The value 4.940656458412465441765687928682213723651e-123 in your example is much smaller than SmallestNonzeroFloat32/2, in other words, it is correctly rounded down to the next smaller float32 which happens to be 0.0.
Generally, strconv.ParseFloat will return the float32/float64 value closest to the decimal representation - this invariably involves rounding. It looks to me that the rounding here is correct.
There is a big difference with the first example (huge positive exponent): "rounding" fails because the next "larger" float32 after MaxFloat32 is +Inf, and the input clearly is not Inf. Hence it makes sense to report an error.


Update hdinsight-hadoop-introduction.md

Changed "Zookeeper" to "ZooKeeper."
Also note that the "MapReduce" and "Management Portal for SQL Database" links don't work, and the "Learn more about SQL Server Analysis Services" link seems to go the wrong place.

Hi @ShawnJackson, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-shawja). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Importing zip into offline-repo: Multiple transport pop-ups

when importing into a zip-file a new system, the package selection popup is being displayed for each object.

yea, I think it depends on the object type how the transport is handled, but this is definitely something we should look into

Might also depend on included packages. Just imported the abapgit-plugins and didn't experience the behaviour

How can I reproduce this bug?

Try this zip: https://github.com/mrsimpson/p2p-help-abap-client/archive/master.zip

I'm getting an Object type AVAS not supported, because of the .avas files. I guess I should just delete them?

Deleting them might make a difference, but I don't know. Give it a try and see whether it occurs. If not, install the abapGit plugins

The package selection popups are object type dependent, so the same issue should occur with online repositories.
Perhaps calling TR_TADIR_INTERFACE before the object type API call will help

@mrsimpson try this https://github.com/larshp/abapGit/pull/632

try again, implemented in https://github.com/larshp/abapGit/issues/1042
closing, please open new issue in case of bugs/questions


disable codeql

Codecov Report

Merging #51 (53a91bd) into main (7a7df8a) will increase coverage by 1.12%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main       #51      +/-   ##
===========================================
+ Coverage   98.87%   100.00%   +1.12%
===========================================
  Files          30        41      +11
  Lines         266       539     +273
===========================================
+ Hits          263       539     +276
+ Misses          3         0       -3

Impacted Files
Coverage Δ

...ntler.Commons.CodeGen.Core/Base/CompilationBase.cs
100.00% <ø> (ø)

...vantler.Commons.CodeGen.Core/FileTemplateLoader.cs
100.00% <ø> (ø)

...er.Commons.StringHelpers/CasingStringExtensions.cs
100.00% <ø> (ø)

...ure.DataAttributes/AutoNSubstituteDataAttribute.cs
100.00% <100.00%> (ø)

...tler.Commons.CodeGen.CSharp/CSharpCodeGenerator.cs
100.00% <100.00%> (ø)

...ler.Commons.CodeGen.CSharp/CSharpTemplateLoader.cs
100.00% <100.00%> (ø)

...ntler.Commons.CodeGen.CSharp/Models/CSharpClass.cs
100.00% <100.00%> (ø)

...Commons.CodeGen.CSharp/Models/CSharpCompilation.cs
100.00% <100.00%> (ø)

...Commons.CodeGen.CSharp/Models/CSharpConstructor.cs
100.00% <100.00%> (ø)

...er.Commons.CodeGen.CSharp/Models/CSharpDocBlock.cs
100.00% <100.00%> (ø)

... and 23 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


IPA processing failed in Xcode 11

Assertion failed: Expected 4 archs in otool output:
/var/folders/y8/x7dbsn8d23vcyzyknl7ljjl00000gn/T/IDEDistributionOptionThinning.~~~95y04K/Payload/MAA DEV.app/Frameworks/HaloMem.framework/HaloMem:
Mach header

Hey there!
I'm assuming this is a bug you're getting. If that's the case, I recommend using the blue button the bottom right of our portal, which will start a thread with our support team!

Hi @abhilashkgowda, I'm assuming you got help from our support team because we haven't back from you. If you don't respond the ticket will be closed, and everything is dandy.

https://www.darrenblog.cn/#/detail/5dbf9a8a7bb725236692b6d4


[Bug] 2.0 Rankings, Hover score cannot view configuration items.

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] The bug has not been fixed in the latest version.

Type
I'm evaluating with the officially supported tasks/models/datasets.


@4.4.1 -<EMAIL_ADDRESS>

coverage: 99.245%. remained the same
when pulling 1c405c0a1c27cc9f1056718e9bd9c8c93f38778b on rc-4.4.1
into 43aea6730a770957878d71e81a67e672d6706abf on master.


Added formatting tooling and improved code consistancy

(there's more detail in the individual commits)
This adds clang-tidy and clang-format configs to make the code more consistent, that way it's easier for new people to contribute whilst keeping everyone's code readable and similar-looking.
Because some of the existing code was inconsistent, I guessed some of the settings, feel free to change them, or add more!
Note that this does require having clang tools installed on your system, but those are commonly used by c/c++ projects, so I don't think it's that big of a deal, and it's worth it to keep the code quality high

It seems like my branch got really messed up… I'll fix this tomorrow, don't merge this yet

This looks okay to me, feel free to merge :D !

Hey. Yes, it makes sense to reformat code, but I prefer to wait until I have a more definitive version. Thank you


Wrong separator from import in app.module.ts when generate component

Please provide us with the following information:

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
Windows 10

Versions. Please run ng --version. If there's nothing outputted, please run
in a Terminal: node --version and paste the result here:
angular-cli: 1.0.0-beta.11-webpack.8
node: 6.5.0
os: win32 x64

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.

ng generate component shared/toolbar

The log given by the failure. Normally this include a stack trace and some
more information.
Not work when  running, and see  in app.module.ts :
import { ToolbarComponent } from './shared\toolbar/toolbar.component';

Mention any other details that might be useful.
Minor bug

Thanks! We'll be in touch soon.

They are already aware of this bug: https://github.com/angular/angular-cli/issues/1719

Ok ! I made a search but not with the good word.
Thank you !


Calling Tag.tags results in invalid SQL statement

(Euwe) Calling Tag.tags results in the following error in operations.log:
[----] F, [2016-12-15T17:30:27.789851 #6007:c6ca8c] FATAL -- : Error caught: [ActiveRecord::StatementInvalid] PG::UndefinedTable: ERROR:  missing FROM-clause entry for table "taggings"
LINE 1: SELECT "tags".* FROM "tags" WHERE "taggings"."taggable_type"...
                                          ^
: SELECT "tags".* FROM "tags" WHERE "taggings"."taggable_type" IS NULL
/opt/rubies/ruby-2.2.5/lib/ruby/gems/2.2.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/postgresql_adapter.rb:598:in `async_exec'

The following code change solves the issue:
/var/www/miq/vmdb/app/models/tag.rb
16c16
<     query = Tag.includes(:taggings)
---
>     query = Tag.includes(:taggings).references(:taggings)

 1 class Tag < ApplicationRecord

15   def self.tags(options = {})
16     query = Tag.includes(:taggings)
17     query = query.where(Tagging.arel_table[:taggable_type].eq options[:taggable_type])
18     query = query.where(Tag.arel_table[:name].matches "#{options[:ns]}%") if options[:ns]
19     Tag.filter_ns(query, options[:ns])
20   end

This should be fixed by #13766, please re-open if it's still not fixed after that PR is merged.  Thanks!


Possible issue - SourceNode circular dependencies

I like the SourceNode approach to import handling, but won't this result in an infinite loop in the event of a circular import?
https://github.com/gql-dart/gql/blob/e8ec7e341099e9916b14c72c5f39d41d7747c699/gql_build/lib/src/utils/reader.dart#L63-L70

@micimize, you are right! I just assumed that in practice it shouldn't happen. It would be better if I handled it, though.
At the time I wanted to get this working as a PoC, so I dropped the code you already wrote. I just realized at the time that there's a second dimension to the problem — all imports must be resolved to a cannonical path so that an import appearing more than once is read only once, but still has multiple nodes in the SourceNode tree.
If you are up to it, feel free to PR the fix.


Fix Wordle score regex to include commas

On March 15th, Wordle showed its 1,000th puzzle. This changed the formatting of shareable scores a bit, to:
Wordle 1,001 3/6

⬛⬛⬛🟨⬛
⬛🟩⬛⬛🟨
🟩🟩🟩🟩🟩

The cause of failure is that Wordle Bot does not account for commas in the puzzle number.
This PR improves the regex so that messages can be properly detected in chat again

Hi @spalmurray, any chance you can review this PR and consider incorporating it into wordle-bot?


Provide support for existing implementations

These commits are required for the EAR Production Suite

Codecov Report

Merging #139 (6385408) into master (146670a) will increase coverage by 0.43%.
The diff coverage is 90.48%.

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   89.51%   89.94%   +0.43%
==========================================
  Files         115      125      +10
  Lines        5534     5751     +217
==========================================
+ Hits         4954     5173     +219
+ Misses        580      578       -2

Impacted Files
Coverage Δ

include/adm/detail/named_type.hpp
100.00% <ø> (+7.89%)
:arrow_up:

...clude/adm/elements/audio_block_format_binaural.hpp
93.75% <ø> (+6.25%)
:arrow_up:

include/adm/elements/audio_block_format_id.hpp
100.00% <ø> (ø)

include/adm/elements/audio_block_format_matrix.hpp
93.33% <ø> (+5.83%)
:arrow_up:

...nclude/adm/elements/audio_block_format_objects.hpp
100.00% <ø> (ø)

include/adm/elements/audio_channel_format.hpp
94.64% <ø> (-0.10%)
:arrow_down:

include/adm/elements/audio_channel_format_id.hpp
100.00% <ø> (ø)

include/adm/elements/audio_content_id.hpp
100.00% <ø> (ø)

include/adm/elements/audio_object.hpp
100.00% <ø> (ø)

include/adm/elements/audio_object_id.hpp
100.00% <ø> (ø)

... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4cf675...6385408. Read the comment docs.

Looks like this is all we need from the libadm side. EPS side needs a few tweaks with adm::SphericalPosition, but no other libadm changes needed.

Closing - changed my mind. Realised this is actually only called from one place in EPS and seems overkill to involve libadm changes to do so.

Reopening after discussion

Merged, sorry for the delay...

No worries, there was no rush 👍


GitHub setuppy check could use raw

Spawned from https://github.com/jayvdb/pypidb/issues/9:
Probably using raw bypasses restrictions on API use without tokens, however it might only buy a bit more access, so should be a failover.

Done in e2cc8ee0
It seems that raw works reliably


Support vendoring git repositories

Currently the vendoring support in Cargo primarily only allows replacing
registry sources, e.g. crates.io. Other networked sources of code, such as git
repositories, cannot currently be replaced. The purpose of this commit is to
support vendoring of git dependencies to eventually have support implemented in
the cargo-vendor subcommand.
Support for vendoring git repositories required a few subtle changes:

First and foremost, configuration for source replacement of a git repository
was added. This looks similar to the Cargo.toml configuration of a git
source.

The restriction around checksum providing sources was relaxed. If a
replacement source provides checksums but the replaced source doesn't then
that's now considered ok unlike it being an error before.

Lock files can be generated for crates.io crates against vendored sources, but
lock files cannot be generated against git sources. A lock file must
previously exist to make use of a vendored git source.

The package field of .cargo-checksum.json is now optional, and it is
intended to be omitted for git sources that are vendored.

r? @matklad
cc @wycats

r? @brson
(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton could you explain how cheksums work (they are created in cargo-vendor as I understand, but I don't see where they are checked on the Cargo side) and why we need more relaxed rules for them for git dependencies? Am I correct that it would still be not possible to accidentally modify vendored git dependency, because we still checksum all the files?

The package field of .cargo-checksum.json is now optional, and it is intended to be omitted for git sources that are vendored.

So the package is sha256 of .crate file? Perhaps we can remove this field altogether and just put it into the files map?

Sure yeah, so right now every source in Cargo can report whether it supports checksums or not. This basically means that the Summary instances it generates may have the checksum field filled out. Checksums are then verified when managing lock files.
There were two pieces that needed to be changed to allow this implementation:

First Cargo previously disallowed source replacement if the two sources differed in how they provided checksums. This mean you could replace the registry with a directory source (they both support checksums) but you couldn't replace the registry with a git repo (git repos don't have checksums). The intention here was that you shouldn't modify the source code if you're using source replacement, and checksums are a verifiable way to do that. The checksum listed in the manifest allows verification that you're always working with the same source.
So even though directory sources support checksums we want the ability to override with a directory source. This basically means that it's ok to override a git source with a directory source. The implementation of the vendoring of a git source ends up meaning that we won't list a checksum for the git package to ensure it matches the original git crate.

Even if sources without checksums can be replaced by sources with checksums we still have a check when merging lock files to prevent this. That means that we need the directory source to be able to produce crates without checksums so git can be the same. The purpose here is that when you generate a lock file against vendored sources it should be the same as a lock file against the actual sources.

You're correct in that it's still intended that vendored sources are not allowed to have modifications. The .cargo-checksum.json file must still be present and list checksums for the relevant files in the crate, it just omits the package top-level hash field.

So the package is sha256 of .crate file? Perhaps we can remove this field altogether and just put it into the files map?

Oh but the .crate file isn't actually in the directory, (that's why we can't calculate it at runtime).

Looks good to me! (modulo the fact that I have not yet fully wrapped my mind around Registry, Source, RegistrySource and all other awesome traits and structs :) )

FWIW I'd like to hold off on merging this just yet, I'd ideally prefer to implement support in cargo-vendor first and make sure that works out well.

:umbrella: The latest upstream changes (presumably #4026) made this pull request unmergeable. Please resolve the merge conflicts.

Ok this is rebased now and cargo-vendor is ready to go, so I'm going to r+..
@bors: r=matklad

:pushpin: Commit 5b08b8f has been approved by matklad

:hourglass: Testing commit 5b08b8fe1019147fe489db17a9a8ae7ebe97f9e9 with merge b9e75000e357085590fc0061ce7f1ac56d3528f3...

:sunny: Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing b9e75000e357085590fc0061ce7f1ac56d3528f3 to master...


[package_info_plus][web] can not load version.json when URI path contains index.html

Our Flutter web app is embedded in iframe of an external web platform using some URI pattern like https://external-domain.com/index.html. Because the path contains index.html package_info_plus_web fails to load version information from version.json.
System info
Platform the Issue occurs on: web
Plugin name: package_info_plus_web
Plugin version: 1.0.5
Steps to Reproduce
Create a local Flutter app with a sample page which is available as
http://<IP_ADDRESS>:8081/#/my-sample-page
The same page should be available when we modify the path like
http://<IP_ADDRESS>:8081/index.html#/my-sample-page
Using the second URI the path in versionJsonUrl is wrong so the method fails to load version.json
In our case it would be sufficient to just remove the special case of index.html from the path in versionJsonUrl, e.g.:
  /// Get version.json full url.
  Uri versionJsonUrl(String baseUrl, int cacheBuster) {
    final baseUri = Uri.parse(baseUrl);
    final originPath =
        '${baseUri.origin}${baseUri.path.replaceAll('index.html', '')}';
    final versionJson = 'version.json?cachebuster=$cacheBuster';
    return Uri.parse(originPath.endsWith('/')
        ? '$originPath$versionJson'
        : '$originPath/$versionJson');
  }

But maybe this issue needs a more general solution?

I have similar problem. Package is working on local host but return empty in release. (event without any index.html). I had to load version.json manually.

Same issue, version.json does not load.
Not in debug localhost, or on release server.

I have similar problem. Package is working on local host but return empty in release. (event without any index.html). I had to load version.json manually.

What do you mean by "load version.json manually"? How did you do that?

When you build your web app, there will be a file named version.json and you can call it as an API directly.
the URL will be something like
you.domain.com/version.json
it will return a JSON file that contains version name and version number.
but as I tested this on two servers, the first one returns an HTML page so you cant use it as a JSON response and encoded it.
on the other hand, the second servers return a JSON response.
by the way, this package on the web is also called this URL to get the info, and when it tries to decode the response an exception will throw, so it returns an empty response.
for the final solution, I have a static version number and version name and have a TODO on it so every time I am going to update the version I update this static too. and where I want to get this info at first try to load the JSON file and if it throws an exception I return this static as the response.


Ollie: Watch freelancetopic.com

Ollie requests the watch of the watch_keyword freelancetopic\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

freelancetopic\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


Negotiator Recon Laser Missing Model

The Recon laser Sight modification for the Negotiator is missing a model. This means that it doesn't actually have a working laser with this modification attached.

Details
Just need to add a model file name of Weapons\Rocketlauncher\Lazersight.nif to mod_Rocketlauncher_Laser_ReconSight "Recon Laser Sight" [OMOD:00132A36]
Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
Yes
Reproduction Steps
Get a Negotiator rocket launcher, attach a Recon Laser Sight to it. There is no laser attachment model, and no laser as a result.

Fix attached:
SFCP_1174.zip


[Better Collectors] Collectors dont update correctly

Describe the bug
The Collectors dont update correctly like they should do. When i empty a collector and leave the area and return after some while the collector "says" "Empty Dew Collector". After opening it, it shows no progress at all. When i close it the text changes to "(E) Search Dew Collector" and when i open it again, it shows the correct progress and i can take out my water.
To Reproduce
Place a dew collector
Leave the area
Come back after some time
Look and open dew collector
Expected behavior
The dew collector should update correctly and shouldnt need to be opened twice
Screenshots

Btw, would like to look into the source code, but couldnt find it? Maybe i could find the issue there (i have some experience in c#)

Just FYI, thought I was not able to reproduce the issue myself, I believe it had to do with chunk observers being lost when exiting the game. I have a new version of Rain Collectors that I hope will mitigate the issue. Please give it a shot and let me know if things are better.
https://gitlab.com/karlgiesing/7d2d-a21-modlets/-/tree/main/khzmusik_Rain_Collector

Just FYI, though I was not able to reproduce the issue myself, I believe it had to do with chunk observers being lost when exiting the game. I have a new version of Rain Collectors that I hope will mitigate the issue. Please give it a shot and let me know if things are better. https://gitlab.com/karlgiesing/7d2d-a21-modlets/-/tree/main/khzmusik_Rain_Collector

Awesome, I'll get the new DLL installed, thanks!

Updated in https://github.com/DonovanMods/donovan-7d2d-modlets/releases/tag/A21.0.5

I'm still experiencing this issue on A21.0.5.


feat(storage): support file cache recover mode

.. and do not recover by default
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support different recover mode. Disable data recovery by default to speed up compute node recovery.
FYI #18035

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

CI passed. Let me release a new foyer version and upgrade to it.


No default selection on adg

requireSelection=true not functioning

I've seen this on spark DropDownList, but it's probably true to all implementers of that API.
Sounds to me like a bead should be listening to data provider changes on the strand model. It should probably be added at the end of the strand to allow other beads to select the index, if no index has been selected, it selects the first item (provided it  exists).

Test Case : https://paste.apache.org/21x16
OnCreationComplete  System should auto set selectedIndex to 0 instead of -1

I'm confused.  AdvancedDataGrid doesn't have a requireSelection property and requireSelection is not used in the test case.

I ported the test case back to Flex and the results were also -1 and null.
There may be other aspects of your real app that call some API that set selectedIndex to 0 in Flex that isn't working in Royale but you will need to identify that API and add it to the test case.


How to load loggedIn user credentials in each page Header

Hi there,
I am trying to use your package, however I am bit struggling to find out a way to load the logged in user's credentials on each page's header.
Also, could you please guide me to declare the custom JavaScript global function at the very first before begin to load anything, so that I should be able to call it anywhere within the project JavaScript code.
Many thanks
RC

Hi,
Are you using UI-router's nested routing just like in this starter?
.state('app', {
			abstract: true,
			views: {
				header: {
					templateUrl: getView('header')
				},
				footer: {
					templateUrl: getView('footer')
				},
				main: {}
			}
		})

if so, then you don't need to set the header for every page which means as soon as you fetch the user data.. they remain there
Now what you need to solve is, how to get the user data when the user refreshes.
I'd recommend that you store them in localstorage using $localStorage if you want
And then create a service that reads them.. Something like: UserService where you have methods for .set(user) and .get().. they save and read from localStorage using $localStorage (this is how I do it).
I am not sure what you mean by that.. Normally you could have code run in the app.run phase of the angular app..
http://stackoverflow.com/questions/20663076/angularjs-app-run-documentation


Add pathfinder_getProof

Add pathfinder_getProof to pathfinder so we can then create storage proofs for starknet :)
See: https://github.com/eqlabs/pathfinder/issues/714

Done, see linked issue in OP


Use with react-native and Android compile (window.screen.width error)

When building pro-gallery inside an expo created react-native Android app, compilation completes but running the app causes things to crash.

Note, this happens as soon as this is added to the app:
import { ProGallery } from 'pro-gallery';

Nevermind, I went through and reinstalled all dependencies and pro-gallery, and I am now hitting another error to debug instead.

I'm guessing the issue originates here: https://github.com/wix/pro-gallery/blob/d86201843c6f1cd9e3dca8cfdcc89519f0c2ca96/packages/lib/src/common/window/windowWrapper.js#L17
This element from windowIsAvailable ...
        try {
            return typeof window !== 'undefined';
        }
        catch (e) {
            return false;
        }

... likely returns a window object when compiled that does not contain the screen element required when running in native mode. A solution might be to include at the top:
import { Dimensions } from 'react-native';

and then use a Mock or create some other window object with the screen sizes set using Dimensions.get('screen').width

I would try to do a PR, but https://github.com/wix/pro-gallery/issues/900 is blocking me and I'm not sure where to go to get a clean build (or why it's trying to download the lib vs compile to begin with, for that matter). Just my inexperience with this library setup unfortunately.

I've confirmed this is the case by editing the JS in the APK. If I add window.screen={width:200,height:200} the app no longer crashes, but of course the sizing is off.

To resolve this issue, you'll need to use React Native's built-in methods for obtaining screen dimensions. You can use the Dimensions module from the React Native library to get the width of the screen. Here's how you can do it:
import { Dimensions } from 'react-native';
// Get the dimensions of the screen
const screenWidth = Dimensions.get('window').width;

You'll need to use React Native's built-in screen dimensioning APIs to overcome this problem. To get the width of the screen, use the Dimensions module from the React Native library, as explained in the essay on atomic energy. Here's how to accomplish it:
'react-native' imports { Dimensions};
Regard: Panther

The window.screen.width error in React Native typically occurs because window is a web-specific object and not available in React Native. For cross-platform development, use React Native's Dimensions API to get the screen width on Android and iOS. You can access it with const screenWidth = Dimensions.get('window').width;. This will give you the screen dimensions in a React Native environment without causing errors during Android compilation.

the mock window object should be returned in screenless environments (like SSR). it should not be the case in the client. The gallery was made for web browsers.


iPhone X Simulator layout bug

The cells oscillate wildly left/right/up/down on the XCode 9 (GM) iPhone X simulator with the example project (just whip the collection view up and down a couple of times).
I created a new project and it does the same thing for mine.
I would imagine this is a simulator bug, but wanted to make sure it was on your radar.
Great library, btw!

Hi,
Thanks for reaching us. We can confirm it or deny only when we have iPhone X on our hands to test.
BR,
Applikey team

Same on this lib https://github.com/roberthein/BouncyLayout

Anyone else that wants a simple fix for this issue... I added this
 - collectionView.frame.width.truncatingRemainder(dividingBy: 2)
to my width and it worked. Thanks guys!


support providing access token with an existing secret

closes #18

Hey @voldemortensen, thanks for the contribution! I'm currently on PTO and will look at this early next week. Hope you have a great New Year!

Adding a ➕ to this request, this will be great for our use case as well.

Hi @jhyelton, thanks for the feedback!
To be transparent, I think this is a good change and I'm still working with Lacework legal to make sure we have the right process for accepting community contributions. Thanks, in advance, for your patience!

Hey @voldemortensen, we added the CLA Assistant to our repo as a requirement before we can merge this PR. This PR also needs to be updated, as there is a merge conflict. I can handle updating the PR and I will need your help by asking you to sign the CLA. Thanks!

Thanks @cirego. I don't sign CLAs, personally. I'll see if I can make a company account and sign one on the companies behalf, not me personally.
In the meantime though, I release the changes I've made here into the public domain, so if anyone else willing to sign a CLA wants to open a pull request with them they are free to do so.

Hi @voldemortensen, I totally understand. Thanks for bringing this to my attention. I've filed an internal ticket to implement this functionality in the next release of our agent helm charts. Thanks again!


woff2 should be first

Tiny update
ready for review @jeffkamo @ry5n

[x] +1 @ry5n
[ ] +1

Is there a reason that woff2 must be first?

I suppose that will ensure woff2 is used over woff if both font assets are present?

yes exactly @jeffkamo

Yup, +1.

+1


LOG: Create POJOs - Priority 1

EPIC:
#361 Log CRUD Implementation
Sizing:
S (Small - 2-8 hours)
Priority:
1 - All further work depends upon the generation of the POJOs
Description:

Use http://www.jsonschema2pojo.org/ to generate Plain Old Java Objects (POJOs) from JSON or JSON-Schema (use defaults; JSON-Schema to POJO option; make sure to generate getters/setters; set package & class name upfront so the tool does all the work; this will be a special LOG object inside Drillflow). There may be some clean-up of the generated POJO.
Request Model: POST/PUT/PATCH
and
View Model: GET
Java Object is the union of both of these objects
NOTES:
Channel & Channel Set POJOs will go into dot.model.
Child of #361

@cherrera2001  are you able to close this request or is there a block?  Please advise the ETA for your review.


How to reproduce the SoTA result of Cityscapes?

Hello, thanks for your impressive work! However, I am not able to reproduce the results of Cityscapes using this repo. In the paper, the mIOU of HRNetv2 increased to 81.4, and the mIOU of HRNetv2+OCR increased to 83.2 on the Cityscapes dataset. When I ran the script "run_h_48_d_4_contrast_mem.sh", the mIOU is hard to converge. Also I notice that the script of HRNet+OCR+Contrastive based on memory bank is not given, could you suggest me how to achieve the experimental results in the paper?

Hi @JasiRose Thanks for your interests. I would suggest you to provide more details about your results. If you'd like to reproduce the results in the paper, please change the number of training iterations as mentioned in Sec.4.1 in our paper. In addition, I'd like to clarify that we release our algorithm on openseg.pytorch with pytorch-1.7.1 for easier use, but the experiments in the paper are ran on openseg.pytorch with pytorch-0.4.1. There are some performance difference between the two codebases, especially for deeplabv3. For the script for OCR, I assume that it will be easy to write based on the provided scripts, but if you still have difficulties, please come back to me I will guide.


minor editing pass to clarify ID uniqueness

Per the discussion here:
https://forums.eveonline.com/default.aspx?g=posts&t=459727
Also, GrayLensman contacted me directly about correcting some of the docs.

Thanks!

Thanks for the edits to the item id.  I'll submit a PR on the blueprints document page as well to submit changes on the Location ID attribute.


readme quickstart

no need of this, since we are segregating API: Producer and Consumer. See #62  #36


[BUG] rust actor template does not work

Affected project(s)

[X] documentation
[X] examples
[ ] wasmCloud host
[X] wasmCloud CLI (wash)
[ ] wasmCloud dashboard UI (washboard)
[ ] capability providers
[ ] provider bindgen
[ ] control interface client
[ ] other / not sure

Describe the bug
Using the quickstart, I cannot create a rust actor.
The output I get is

🔧   Cloning template from repo wasmCloud/wasmCloud subfolder examples/rust/actors/http-hello-world...

Failed to generate project

Caused by:
    ⛔   Invalid subfolder path: No such file or directory (os error 2)

Seems like the directory should point to examples/rust/components/http-hello-world instead of examples/rust/actors/http-hello-world
Steps to reproduce

run wash new actor hello --template-name hello-world-rust

Expected behavior
I expected a project directory to be created.
Environment

OS: Linux
Shell zsh

Screenshots / Logs / Additional context
No response

Hey @fliepeltje would you mind confirming that wash works for you now? The fix has been merged to main so it should be usable now

Hey @fliepeltje would you mind confirming that wash works for you now? The fix has been merged to main so it should be usable now

Hey @fliepeltje would you mind confirming that wash works for you now? The fix has been merged to main so it should be usable now

I have veriefied it and it indeed works as intended! :+1:


koreader: 2024.03.1 -> 2024.04

Description of changes
Changelog: https://github.com/koreader/koreader/releases/tag/v2024.04

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 322078 run on aarch64-linux 1

1 package failed to build:

koreader

Looks like the hash for the deb doesn't match on arm linux.

┃          specified: sha256-9Bu+mWfJuPaH5nV71JMrcGipiZWfcf19KfVauCW92+I=
┃             got:    sha256-FwwB9slKOiYQ3eud2tiqov6yGNxmIicIe6nFpsH28Vk=

^^ :)

Now it builds, but crashes on start
/nix/store/b5hixj0qi5jrnx16g4kyzh5qc2dfkivv-luajit-2.1.1713773202/bin/luajit: error loading module 'libs/libkoreader-xtext' from file './libs/libkoreader-xtext.so':
        libstdc++.so.6: cannot open shared object file: No such file or directory

Looks like it can be fixed by adding stdenv.cc.cc.lib to the wrapper, runs here with that change.
lib.makeLibraryPath [ gtk3-x11 SDL2 glib stdenv.cc.cc.lib ]


Curious (possibly inaccurate?) claim about module as an identifier

Probably this will be an easy bug to catch in practice, as accessing the variable module will usually be a ReferenceError.

This sentence caught my eye while reading just now. module is definitely a known identifier in Node (as part of module.exports in CJS land).

Right, that sentence should probably be something like

Probably this will be an easy bug to catch in practice, since using import and export in blocks is a syntax error.

Right, that sentence should probably be something like

Probably this will be an easy bug to catch in practice, since using import and export in blocks is a syntax error.

I think the current syntax is clear to avoid the problem "module" [No LineTerminator here] Block

I think the current syntax is clear to avoid the problem "module" [No LineTerminator here] Block

Not that that's a particularly big problem, since allman style often results in ASI bugs, which is why OTBS is the dominant style for JS, by a wide margin.

Not that that's a particularly big problem, since allman style often results in ASI bugs, which is why OTBS is the dominant style for JS, by a wide margin.

Thanks for pointing out this weird statement, @getify . I like @nicolo-ribaudo 's proposed wording. PRs welcome to clarify things here.

Thanks for pointing out this weird statement, @getify . I like @nicolo-ribaudo 's proposed wording. PRs welcome to clarify things here.

The sentence immediately preceding the one I quoted in the OP is:

As module is not a keyword in JavaScript, no newline is permitted between module and {.

So I think the context of the sentence in question here is that the "no newline" syntax rule will be OK because people won't likely do:
module
{
   // ..
}

I'm not sure whether they will or not, but that claim seemed suspicious to me based on the fact that module does in fact appear in lots of CJS code.
@nicolo-ribaudo's wording seems more accurate but it's sorta an indirect way of justifying the fact that the newline issue won't happen much.
IMO, I think the claim that the newline issue won't happen much is a weak/spurious claim, and rather than trying to re-word something here that may just be more confusing, the weak claim should just be removed. I think it's enough to flatly assert that the new-line isn't allowed since module isn't a reserved keyword (yay ASI) and not justify it any further.

The sentence immediately preceding the one I quoted in the OP is:

As module is not a keyword in JavaScript, no newline is permitted between module and {.

So I think the context of the sentence in question here is that the "no newline" syntax rule will be OK because people won't likely do:
module
{
   // ..
}

I'm not sure whether they will or not, but that claim seemed suspicious to me based on the fact that module does in fact appear in lots of CJS code.
@nicolo-ribaudo's wording seems more accurate but it's sorta an indirect way of justifying the fact that the newline issue won't happen much.
IMO, I think the claim that the newline issue won't happen much is a weak/spurious claim, and rather than trying to re-word something here that may just be more confusing, the weak claim should just be removed. I think it's enough to flatly assert that the new-line isn't allowed since module isn't a reserved keyword (yay ASI) and not justify it any further.

I think this issue is fixed well by @jakearchibald 's https://github.com/tc39/proposal-js-module-blocks/pull/35 , which has landed.


add a swipe refresh layout on notifications page

Steps to reproduce

Click on bell icon on any activity
Notification page opens up

Expected behaviour

Add a swipe refresh layout on notifications page
On swiping, the notifications should refresh. (Make the API call again & refresh the list)

would like to work on this!

Sure 👍

Fixed by https://github.com/project-travel-mate/Travel-Mate/pull/260


http://framework.zend.com/issues/browse/ZF2-71

fix/ZF2-71 check if md2 digest is enabled on openssl just for backwards compatibility

Please, read the ZF2 Git Guide on the Wiki http://framework.zend.com/wiki/display/ZFDEV2/Zend+Framework+Git+Guide especially the "Working on Zend Framework" part.
Thanks! :)

Reviewed, merged, and pushed to master (on git.zendframework.com).
Daniel -- in the future, create a separate hotfix and/or feature branch for each discrete task you work on; this makes merging easier, and ensures we don't get unintentional commits merged.

ok, i'll do my pull requests on separate branches , thanks.


add required SECURITY.md file for OSSF Scorecard compliance

add required SECURITY.md file for OSSF Scorecard compliance

Hi @rdower
This PR is failing pre-commit. Can you install pre-commit on your system so the yaml file can be updated.
Thanks


Gif visualization

Hi,
thanks for the reimplementation! Your Gif visualization using iceberg is super nice! Could you maybe also share the code of it?
Thanks a lot!

Sure thing, here it is: https://gist.github.com/kvablack/3e2d3cf849107f76b13d1e3cd31c0bf6
It takes as input MP4 videos, which I created by just loading each LoRA checkpoint in sequence and generating an image with the same seed across checkpoints.


ghc 8.2.1

Hello! This PR supports ghc 8.2.1, achieved by loosening a few constraints (whew, that wasn’t so bad!).

Thanks, sorry for the slow reply!

@edsko: No worries, thank you for the merge! ❤


Dark discussion font color

Browser: Opera 63
Operating System:
Windows 10
Link to page with the issue:
https://github.com/MichalLytek/type-graphql/pull/415
Screenshot:

The color comes from this:

And overwrite the !important 😞

@MichalLytek This has been fixed in GitHub Dark already, so update your local copy.
See https://github.com/StylishThemes/GitHub-Dark/issues/993 and fix https://github.com/StylishThemes/GitHub-Dark/commit/e67cb73b4500993b8b4ae9a9a9ef6f7ae0f9ba58

I've tried to update the script first but without luck:

I used this url:
https://greasyfork.org/scripts/15562-github-dark-script/code/GitHub%20Dark%20Script.user.js
Changed to github:
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark-Script/master/github-dark-script.user.js
Thanks! 😉

I havent used the GHD script version but

That force update style button is what you should press to update, I dont think its necessary to change URL's See the wiki entry https://github.com/StylishThemes/GitHub-Dark-Script/wiki#force-update

You can also not use the script version and instead install Stylus and the GHD theme, same update interval but also more possibilities because you can add more themes from other sites.


GradleWrapper can call bundleRelease

Introduces a GradleWrapper method to call gradle bundleRelease
to produce app bundles as output.

This moves forward work for #119

This looks good, how are we going to expose it to the user?

We'll need to add a flat to build that outputs bundles. We also need to sign the bundle with jarsigner instead of apksigner. I'll create a PR on that bit soon.


Roll engine f001ea29f1b9..46adf73d5128 (5 commits)

https://github.com/flutter/engine/compare/f001ea29f1b9...46adf73d5128
git log f001ea29f1b9..46adf73d5128 --first-parent --oneline
2020-01-08<EMAIL_ADDRESS>Made it so you can specify the old gen heap size. (flutter/engine#15259)
2020-01-08<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from gL-XG... to rTJJV... (flutter/engine#15308)
2020-01-08<EMAIL_ADDRESS>Add a deprecation javadoc note to the old FlutterActivity (flutter/engine#15156)
2020-01-08<EMAIL_ADDRESS>Bump simulator version in IosUnitTests & scenario app in preparation for luci xcode 11 migration (flutter/engine#15154)
2020-01-08<EMAIL_ADDRESS>Roll src/third_party/skia 91e0d7526944..f811fc331a14 (32 commits) (flutter/engine#15306)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.

run_machine_concurrent_hot_reload and run_release_test devicelab tests are failing consistently after this roll, so I will revert. @GaryQian


Removing VS items

Docs Build status updates of commit 988038f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.vs/CortanaSkillsKit/v15/.suo
:white_check_mark:Succeeded

.vs/slnx.sqlite
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[EVAM API] Updated based on grammar, style and trademarks

Hi @srihari-humbarwadi-intel, @adreanneb, I have edited the API doc based on grammar, style and trademarks. Please review.

Will create this pull request in the TechComm repo instead, per @srihari-humbarwadi-intel's advice through email. Closing this pull request.


Check Help Card against actual declaration

The contents of the Help Card need to be checked against the url and url_view declarations to ensure that the members are accurate.

I went through the help card and:

set_scheme_id should be removed (when did that happen? is that on purpose?)
ipv_future should become ipvfuture or vice-versa. Which one do we want?

Is that correct?

I guessed set_scheme_id but I was wrong, it is set_scheme with 2 overloads. But I wonder if we should rename it... the docs kind of suffer a little bit because of it. set_scheme_id is more discoverable.
ipvfuture is correct.

We should remove set_scheme_id, but we should open an issue to start a discussion on if we should rename it to set_scheme_id in the API. This would have to wait until after the review of course.

I guessed set_scheme_id but I was wrong, it is set_scheme with 2 overloads.

Yes. I agree. I like set_scheme with two overloads more.

We should remove set_scheme_id, but we should open an issue to start a discussion on if we should rename it to set_scheme_id in the API. This would have to wait until after the review of course.

Sure.

so you prefer
set_scheme( string_view )
set_scheme( scheme )

instead of
set_scheme( string_view )
set_scheme_id( scheme )

?

Yes

Needs another quick look just to be sure

Yes. I've been purposefully ignoring this for now because we're changing a lot lately.

This has been done many times since this original issue was opened.


Be/pos 26 nikhil kumar

Pizza CRUD Functionality and Image Upload Feature Implemented

Added models and controllers for Pizza CRUD


Putting my code in a Microsoft namespace

Related Closed Issue: dotnet/AspNetCore.Docs#11435
Can we have an update regarding the suggestion to "Place extension methods in the Microsoft.Extensions.DependencyInjection namespace to encapsulate groups of service registrations." [REF].
The last comment was on Jun 27, 2019 from @guardrex : "Engineering has looked this topic over multiple times since then and never said to change it. We'll be reviewing updates again when we get to 3.0 updates. I'll ask explicitly in a few months when I work it."

They ask that devs don't publish NuGet packages with "Microsoft" in the name of the package. They sharpen their 🔪😨 when they see that happen! :smile:
@davidfowl ... This guidance was attributed to you by @ardalis when the DI topic was written ...

Place extension methods in the Microsoft.Extensions.DependencyInjection namespace to encapsulate groups of service registrations.

... is that the guidance that you want?

cc: @mkArtakMSFT ... probably can answer this definitively, too.
TL;DR; — The DI topic states ...

Place extension methods in the Microsoft.Extensions.DependencyInjection namespace to encapsulate groups of service registrations.

... Is the product unit OK :+1: with devs using that "Microsoft"-based namespace for their own apps and libs?
It's just that MS doesn't want devs to use "Microsoft" in NuGet package names. That's been stated several times over the years.

@JamesNK Can I remove the following suggestion from the doc?

Place extension methods in the Microsoft.Extensions.DependencyInjection namespace to encapsulate groups of service registrations.

As far as I know that advice is still recommended. Putting DI extension methods in Microsoft.Extensions.DependencyInjection means they show up with intellisense.


Assists stat counting flash assists as well

During frezzetime: Kill, Assist, Death and ADR stats are displayed.
It looks like the assists is counting flash assists as well, otherwise the 500 ADR wouldn't be possible in this case after the first round.
I thinks it's a little bit confusing.

Its taken from the game statistics, flash assists count as assists there

The native scoreboard displays them desperately.
I expected the same data here as well.

enemy flashed ≠ flash assist, this is not a bug.

enemy flashed ≠ flash assist, this is not a bug.

Because they are not the same as you say, it is a bug that it counts the 2 assists in the screenshot for 'vincso', since there is no room for kill assists if noLen got the total of 500 dmg based on the ADR stat for the first round.

enemy flashed ≠ flash assist, this is not a bug.

Because they are not the same as you say, it is a bug that it counts the 2 assists in the screenshot for 'vincso', since there is no room for kill assists if noLen got the total of 500 dmg based on the ADR stat for the first round.

Flash Assist counts as an assist, it comes from GSI, it cannot be fixed. because this is not a bug, this is how it should be

enemy flashed ≠ flash assist, this is not a bug.

Because they are not the same as you say, it is a bug that it counts the 2 assists in the screenshot for 'vincso', since there is no room for kill assists if noLen got the total of 500 dmg based on the ADR stat for the first round.

Flash Assist counts as an assist, it comes from GSI, it cannot be fixed. because this is not a bug, this is how it should be

Ah, I get you now.

The game does indeed count flash assists in the Assists column of the scoreboard. Bit weird if you ask me (especially since I don't think they ever mentioned it in the changelogs?), but if the game does it this way, the HUD probably should do the same.


Add support for ImageMagick version 7

libvips uses specific loaders for ImageMagick 7.

Coverage remained the same at 100.0% when pulling 0f5054f6931fa9b4dada7dce06b5127895cf7d70 on besport:imagemagick-7 into 0f58f956a7892ff480549fa99d76627892bd9fc1 on lovell:master.

La magie, merci/thanks!

This is not very important, but checking for the exact class names feels a little ugly, and could break.
How about checking the nickname instead? The libvips base object has a nickname class member:
https://github.com/libvips/libvips/blob/master/libvips/include/vips/object.h#L525
It's also exposed as an object member and glib property on vips objects. The nickname is the thing that's used to look up operations by name, eg.:

In this case you could use:
char const *load = file ? vips_foreign_find_load(file) : NULL;
GType gtype = load ? g_type_from_name(load) : 0;
const char *nickname = gtype ? vips_nickname_find(gtype) : NULL;

And nickname will be something like magickload or NULL. libvips guarantees that nicknames are unique and unvarying, ie. they are a supported part of the API (unlike class names, which are not). You could perhaps use a hash to map nicknames to file types and save the switch.

... I could try a PR, if that would help.

@jcupitt Great idea, thank you, I've added this via commit 8da30f0

Ah, much prettier! Nice!


split creates folds of different sizes

I noticed that it creates folds , where the last pair has a different sizes then the rest.
is this expected ?

(def splits
  (-> (tc/dataset {:x (range 37)})
      (tc/split->seq  :kfold {:k 5})))

{:train-sizes (map #(tc/row-count (:train %)) splits)
 :test-sizes  (map #(tc/row-count (:test %)) splits)}

     ;; => {:train-sizes (29 29 29 29 32), :test-sizes (8 8 8 8 5)}

Yes, it's expected. k-fold doesn't make any shuffle or resampling, just simply cuts ds into chunks (using partition-all).

Yes, but why have the chunks a different size...
So the last fold has 32 rows in train and 5 in test,
while al other folds have 29 train + 8 test.
(teh sum is 37, so indded constant as it should be)
Looking at this:

seem to say that all folds are allways of same size

There is no way to have all folds always of the same size. 37 is not divisible by 5. So it depends how rounding is done.
In our case partitioning produces such fold sizes:
(map count (partition-all (/ 37 5) (range 37)))
;; => (8 8 8 8 5)

So this is the main reason of what you observe.
I think this is most visible with very, very small datasets. For bigger ones the difference is minor.
(map count (partition-all (/ 1037 5) (range 1037)))
;; => (208 208 208 208 205)

What we can fight for is a better balance, so instead of (8 8 8 8 5) we may want (7 8 7 8 7). Any idea how to produce such balanced split?

I would expect "same size" .
(so different splits, but same size)
{:train-sizes (29 29 29 29 29), :test-sizes (8 8 8 8 8)}

Is this not even the default (and simplest way) to do this.
But know I see, this is not really possible....
If the number of rows does not divide by k, then we cannot have this...

I need to re-think this,  maybe there is no issue at all.

I understand know your explanation and you are right. We can close it.

I found a function which does the partition-all in a balanced way:
(defn piles [m xs]
  (let [cnt (count xs)
        l   (quot cnt m)
        r   (rem cnt m)
        k   (* (inc l) r)]
    (concat
      (partition-all (inc l) (take k xs))
      (partition-all l (drop k xs)))))

Maybe nice to use it to make more balanced folds

Thanks! Included above code in 7.000-beta-27.


Question: ContainsKey is not a standard LINQ operator

The list of LINQ standard operators supported by Dynamic LINQ includes .ContainsKey.
This list of LINQ operators doesn't include ContainsKey.
Since ContainsKey is (for all the cases I've seen) an instance method, it should not even require any special handling, because instance methods don't need to be on accessible types. Moreover, the signature for ContainsKey that I've seen always expects a single value, unlike other extension methods such as Select or SelectMany which expect a function delegate or an expression tree.

Hello @zspitz ,
I'm currently failing to see what you really want or what you want us to change.
The ContainsKey can contain an expression such as "Orders.ContainsKey(it.City + \"TEST\")".
If you wish, feel free to make a pull request in the documentation here: https://github.com/zzzprojects/docs/tree/master/dynamic-linq.net
Best Regards,
Jon

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

All instance methods are resolved, so the reason why ContainsKey works is not because it is a LINQ operator, but rather because it is an instance method. As such, ContainsKey doesn't belong in this list.
I will write a PR shortly.

@JonathanMagnan Let me clarify.
All instance methods are handled by Dynamic LINQ, as are their arguments. You can put an arbitrary expression as an argument to any instance method and it will be translated to the corresponding expression and query. Like so:
public class Person {
    public string Name { get; set; }
    public string TestMethod(string s) => "";
}

var selector = "TestMethod(FirstName + \"ABCD\")";
var prm = Parameter(typeof(Person));
var parser = new ExpressionParser(new[] { prm }, selector, new object[] { }, ParsingConfig.Default);

The LINQ methods (e.g. Select, Where, Any etc.) are different, because they are extension methods, and thus static and not instance methods. Since their types are not accessible by default, they cannot be used within Dynamic LINQ expressions. However, Dynamic LINQ special cases theses static extension methods, because they are commonly used within querying expressions.
But ContainsKey is an instance method, and supported just like all other instance methods. It therefore doesn't belong in the list of "static extension methods which Dynamic LINQ has to handle specially".


Is WyzeHacks expected to work with v1 cameras?

It's unclear from the README.md whether WyzeHacks is expected to work for v1 cameras; "v1" is mentioned only for the uninstall instructions.
I tried using the SD card install approach, and I heard the "Upgrade is in progress" message, but I never heard the "Installation finished" message.  There also was no install.log file left on the SD card.

The answer is "it might", reason is simple: I don't have one to test. Also, te SD card install method no longer works due to recent firmware changes, you should instead use the remote_install.sh. and again, I have no way of testing I'd it works on v1.

Ah, ok.  I thought that the SD card install method would work since the v1 firmware hasn't been updated in a while.
I've now tried remote_install.sh, and it appears to skip over my v1 cameras. =(
(I'd be happy to donate a v1 camera if you're interested.)

I see. I can take a look if you can mail me one of the v1 device, but no
promise how soon I can get it work.
On Mon, Mar 15, 2021, 01:21 James D. Lin @.***> wrote:

Ah, ok. I thought that the SD card install method would work since the v1
firmware hasn't been updated in a while.
I've now tried remote_install.sh, and it appears to skip over my v1
cameras. =(
(I'd be happy to donate a v1 camera if you're interested.)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/HclX/WyzeHacks/issues/99#issuecomment-799216421, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZNWDZQP3A3FTNBTSNPYDLTDW7SHANCNFSM4ZFX4SNQ
.

got the v1 camera, and noticed this is on a totally different architecture: v2 and v3 are all using Ingenic's SoC, which is MIPS based, while v1 seems to be ARM based. While most of the hack is just shell scripts, there is a critical component built with C, which means I need to get the toolchains and SDK for that. I will definitely look into it, but I highly suggest you migrate your system to v2/v3 if you want to use this hack.


Fixed "ubunut" typo

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@jaredhaight : Thanks for your contribution to the Azure documentation! The author, @julienstroheker, has been notified to review your proposed change.

#sign-off


hotkeys not working in JAVA sapgui

Not much to say, they just do nothing.
I guess either the event handler doesn't get registered or doesn't work.
Looking into it

Working now


Sentry records catched exception

I'm running into a very annoying issue where Sentry is somehow capturing caught exceptions.
Running Laravel 5.7 with sentry-laravel 1.0.0
How to replicate:
I've created a command to run on the prod server
$test = [1];
try {
    echo $test[2];
} catch(\Exception $e) {
}

I run this, and it runs through just fine, as expected. The laravel.log is empty, as expected.
Yet a new issue pops up on Sentry

I'm kinda lost as to where this happens too. I've had a look at the Exceptions\Handler@report method, and it's never triggered either.
Maybe I've missed something new with v1?
Any help would be GREATLY appreciated. I'm currently drowning in issues!

Hey @JorgenSolli, I can explain, it's not a Sentry bug or issue actually.
A notice is not an exception, and can't be caught by a try/catch block.
A notice is an Error in PHP and captured by the error handler (which Sentry listens on).
There are a few things you can do to fix your code:

On PHP 7+: echo $test[2] ?? ''; (Null Coalescing Operator)
Before PHP 7: echo isset($test[2]) ? $test[2] : '';

The other option is to disable reporting notices in Sentry, but I would not recommend it since it's easier to guard against the notice being there in the first place.
Does this explain it enough?

Hi, @stayallive
Thanks for taking the time to explain. Much appreciated! :)
The notices origins from a library I use, phpseclib/phpseclib, which sort of put things out of my control.
Guess I'll disable reporting notices for now.
Thanks again for your time
Regards

Ah yes, phpseclib is a bit of a pain in the arse with their trigger_error calls too which can't be caught in userland... bit of a pain of the legacy.
You can disable the notices by adding the following to your config/sentry.php:
   'error_types' => E_ALL ^ E_NOTICE,

But keep in mind that disables the reporting of EVERY notice in you application.
You could look to implement some more advanced filtering to filter out notices emitted from phpseclib to prevent having to disable notice reporting: https://docs.sentry.io/error-reporting/configuration/filtering/?platform=php.


CEO-253 Warn users flagging a plot will clear answers

Purpose

Adds a confirmation when flagging plots that have existing answers.
Related Issues
Closes CEO-253
Submission Checklist

[x] Commits include the JIRA issue and the #review hashtag (e.g. CEO-### #review <comment>)
[x] Code passes linter rules (npm run eslint/clj-kondo --lint src)

Testing

Given I am a user, When I am collecting, And I have answered some questions, And I flag a plot, Then I am presented with a warning that my answers will be cleared.

Screenshots

src/js/collection.js
601, You should be able to use .find instead of reduce.  Its similar to the clojure (some ).
There is a lodash _.isEmpty() if you want.

Thanks for that recommendation.
Wanted to note that in testing those changes, I found a bug where if you had answered some q's but not saved, then flagged the plot and hit "cancel" on the confirm alert, it would save the plot with your answers. Separated out the logic now so that doesn't happen.


Breaking style sheet links?

This seems like it shouldn't happen... and if it were happening, that it should have caused a riot already... but in my app, it appears that my stylesheet links are breaking because the urls are being intercepted by react-router. When I attempt to navigate to the css via view page source, it shows me the NotFoundRoute handler, and if I look in the resources panel of Chrome, it shows me the html...

This doesn't look like router's problem—you're probably serving index.html even for CSS paths.
What server do you use?

It's definitely the router's problem. Using react-router on a completely different app, it tried to hijack the script src attribute, redirecting "/build/client.js" to the NotFoundRoute handler. It looks like if you use a href or src attribute on any native tags, the router redirects them. :(

A client-side router can't possibly “hijack” other requests.
This is a problem with your server setup.
Which is why I'm asking: what server do you use for serving static files in development environment?

Well then the issue is that the router is running server-side. I'm making an isomorphic app, Express4 server, using webpack to bundle. I was under the impression that react-router was suitable for server-side rendering?

Do you use webpack-dev-server for serving static files in development?

Yup.

So dev-server and Express app run on different ports?
See example setup: https://github.com/gpbl/isomorphic-react-template
It seems that you're requesting JS/CSS on Express' port instead of Webpack's.

See also: https://github.com/gaearon/react-hot-loader/issues/46#issuecomment-66960643

For dev, the assets are called from the absolute webpack port, for live, they are called relatively from the app. It's the live assets that are giving me grief, when webpack isn't even running.

How do you configure Express to serve static assets?

'use strict';

require('node-jsx').install({ harmony: true });
var express = require('express');
var expressState = require('express-state');
var navigateAction = require('./actions/navigate');
var favicon = require('serve-favicon');
var cors = require('cors');
var compression = require('compression');
var debug = require('debug')('CharityProfileApp');

var React = require('react');
var app = require('./application');
var HtmlComponent = React.createFactory(require('./app/frames/Html'));
var Router = require('react-router');

var server = express();
expressState.extend(server);
server.set('state namespace', 'App');
server.use(favicon(__dirname + '/favicon.ico'));
server.use('/public', express.static(__dirname + '/build'));
server.use(cors());
server.use(compression());

server.use(function (req, res, next) {
  var context = app.createContext();
  var scriptSrc = process.env.NODE_ENV === 'development'
                  ? 'http://localhost:9001/build/client.js'
                  : '/build/client.js';

  debug('Executing navigate action');
  Router.run(app.getAppComponent(), req.path, function (Handler, state) {
    context.executeAction(navigateAction, state, function () {
      debug('Exposing context state');
      res.expose(app.dehydrate(context), 'App');

      debug('Rendering Application component into html');
      var html = React.renderToStaticMarkup(HtmlComponent({
        scriptSrc: scriptSrc,
        state: res.locals.state,
        markup: React.renderToString(
          React.createElement(Handler, {
            context: context.getComponentContext()
          }), null)
      }));

      debug('Sending markup');
      res.write(html);
      res.end();
    });
  });
});

var port = process.env.PORT || 9000;
server.listen(port);
console.log('Listening on port ' + port);

I think you're configuring Express to serve statics by /public path:
server.use('/public', express.static(__dirname + '/build'));

but scriptSrc starts with /build:
  var scriptSrc = process.env.NODE_ENV === 'development'
                  ? 'http://localhost:9001/build/client.js'
                  : '/build/client.js';

happy to keep providing help here, but its simply not possible for the router to do this to you, there's a problem in your server's config.

So just to clarify, having resolved this, that the router is capable of hijacking all file requests (such as stylesheets and javascript and other assets), unless those requests are instead handled outside the router. My issue was that I was serving assets from paths which weren't blocked from the router, so the router was trying to handle them and resulting in NotFoundRoute intercepting the request. In the end, it was the server config, because I wasn't blocking all asset routes from the router.

the router is capable of hijacking all file requests

I guess the word "hijacking" is what I'm trying to clarify. Your server was configured to have React Router handle routes that it shouldn't have, but its not hijacking anything :)

@benoneal would you happen to know how you ended up fixing this?  I am seeing the same behavior.  With a properly configured express app, after adding React Router on the server, instead of loading the static assets, my Not Found Route is being rendered and sent instead.  Thanks so much!

@ryanccollins any route that you don't explicitly handle via express, will be handled by react router. In my case, I fixed my issue with these changes:
server.use('/fonts', express.static(__dirname + '/build/fonts', { redirect: false }))
server.use('/images', express.static(__dirname + '/build/images', { redirect: false }))
server.use('/build', express.static(__dirname + '/build', { redirect: false }))
(sorry I don't have backtick on my phone's keyboard)