Pip Package

Hey, nice work on this project, are there any plans to release this as a pip package so its a bit easier to install from other repositories ?

Hey and sorry about the somewhat late reply.
Yeah that was the plan ultimately, but I haven’t worked on this for a while.
I don’t seem to have made a pip package yet, but there’s a docker image in my container registry: https://git.sudo.is/ben/-/packages/container/glados-tts
Since the project uses poetry it’s easy to create and upload a pip package, but i generally don’t want to upload to PyPI unless i’m actively maintaining a project.
Hopefully i’ll get around to it soon, but then plan is to convert to hatch (instead of poetry) and then i’ll upload to PyPI — would also need to decide on a name for the package before uploading to PyPI as i believe that glados-tts is already taken (and i don’t think that my slight modifications to the project are “deserving” of occupying that name).


Displaying commit hash at build results

Is your feature request related to a problem?
Nope.
Describe the solution you'd like
It would be helpful to see commit hashes at the build results component.
Describe alternatives you've considered
parsing through git log, git diff HEAD~n, should be easy to implement.
Additional context

attaching screenshot for git log for the relevant exercise

Why would this be helpful?

It would enable users to easily see commit hashes of their builds, easily accessible through Artemis instead of bitbucket.
Sent from Outlook Mobilehttps://aka.ms/blhgte

From: Stephan Krusche<EMAIL_ADDRESS>Sent: Monday, June 8, 2020 7:34:40 AM
To: ls1intum/Artemis<EMAIL_ADDRESS>Cc: Dan Bachar<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [ls1intum/Artemis] Displaying commit hash at build results (#1594)
Why would this be helpful?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/ls1intum/Artemis/issues/1594#issuecomment-640379489, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AECHNJHG5JGAK43FPBCQUUTRVRZ7BANCNFSM4NXWZF4Q.


Merge style instead of override

If I provide a styles object, the default styles will be overriden.
Sometimes I just want to change some style such as background color but keep other styles.

I was surprised this isn't considered. I'd love to just use bottom: 0; top: auto; everything else is fine as is.


Should workflow templates pre-exist prior to running kubectl create -f workflow.yaml?

@terrytangyuan .. I've been working my way through your book. Thanks for putting together such an informative book. The latest version available on Manning is v7 from May. Perhaps there is something more up to date ... that might explain why I'm hitting the issue described below?

From chapter 8, various CRDs are created with kubectl kustomize manifests | k apply -f -. It might be worth using the long-form kubectl kustomize manifests | kubectl apply -f -, for those that may not have an alias k set up for kubectl.
I notice that this calls the distributed-ml-patterns/code/project/manifests/kustomization.yaml file, which in turn activates various manifests in the argo-workflows and kubeflow-training folders.
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kubeflow

resources:
- argo-workflows/
- kubeflow-training/

It seems when I try to run kubectl create -f workflow.yaml in Chapter 9, it fails (see below). I think it might be due to the absence of the correct workflow-templates pre-populated in argo. Could it be that manifests from the e2e-demo folder should have been included in the kustomization.yaml above, or is something else missing?
Appreciate your input. Thanks.
~ % kubectl get workflows -n kubeflow
NAME             STATUS   AGE   MESSAGE
tfjob-wf-lzwv9   Failed   60m   invalid spec: templates.tfjob-wf.steps[0].data-ingestion-step template name 'data-ingestion-step' undefined
~ % kubectl describe workflows tfjob-wf-lzwv9 -n kubeflow
Name:         tfjob-wf-lzwv9
Namespace:    kubeflow
Labels:       workflows.argoproj.io/completed=true
              workflows.argoproj.io/phase=Failed
Annotations:  <none>
API Version:  argoproj.io/v1alpha1
Kind:         Workflow
Metadata:
  Creation Timestamp:  2023-08-21T14:56:06Z
  Generate Name:       tfjob-wf-
  Generation:          2
  Resource Version:    8141
  UID:                 3a573b29-ef27-4940-9c99-5f2c541850ea
Spec:
  Arguments:
  Entrypoint:  tfjob-wf
  Pod GC:
    Strategy:  OnPodSuccess
  Templates:
    Inputs:
    Metadata:
    Name:  tfjob-wf
    Outputs:
    Steps:
      [map[arguments:map[] name:data-ingestion-step template:data-ingestion-step]]
      [map[arguments:map[] name:distributed-tf-training-steps template:distributed-tf-training-steps]]
      [map[arguments:map[] name:model-selection-step template:model-selection-step]]
      [map[arguments:map[] name:create-model-serving-service template:create-model-serving-service]]
  Volumes:
    Name:  model
    Persistent Volume Claim:
      Claim Name:  strategy-volume
    Name:          data-ingestion-step
    Name:          distributed-tf-training-steps
    Name:          cnn-model
    Name:          cnn-model-with-dropout
    Name:          cnn-model-with-batch-norm
    Name:          model-selection-step
    Name:          create-model-serving-service
Status:
  Conditions:
    Status:     True
    Type:       Completed
  Finished At:  2023-08-21T14:56:06Z
  Message:      invalid spec: templates.tfjob-wf.steps[0].data-ingestion-step template name 'data-ingestion-step' undefined
  Phase:        Failed
  Progress:     0/0
  Started At:   2023-08-21T14:56:06Z
Events:
  Type     Reason          Age   From                 Message
  ----     ------          ----  ----                 -------
  Warning  WorkflowFailed  60m   workflow-controller  invalid spec: templates.tfjob-wf.steps[0].data-ingestion-step template name 'data-ingestion-step' undefined

It might be worth using the long-form kubectl kustomize manifests | kubectl apply -f -, for those that may not have an alias k set up for kubectl.

Thanks! That is fixed in the book and I just fixed them in the README file in the repo as well.

invalid spec: templates.tfjob-wf.steps[0].data-ingestion-step template name 'data-ingestion-step' undefined

It seems like the template does not exist, could you run a kubectl apply -f of this file https://github.com/terrytangyuan/distributed-ml-patterns/blob/main/code/project/manifests/e2e-demo/workflows-templates-tfjob.yaml?

See https://github.com/terrytangyuan/distributed-ml-patterns/tree/main/code/project#run-workflow

Actually can you try the lastest version in main branch? That data ingestion template should already exist in https://github.com/terrytangyuan/distributed-ml-patterns/blob/main/code/project/code/workflow.yaml#L26

Getting things working in Chapter 9 requires you to have run certain steps in Chapter 8 of the book. If it's not too late, it might be worth recapping those required steps at the beginning of Chapter 9, since some readers might wish to plunge directly into the end-to-end in Chapter 9.

That's great feedback. Thank you! If you have specific recommendation on what prerequisites are missing to follow the code snippets in the last chapter, please let me know.

Yes, those e2e_demo steps didn't appear anywhere in the book ... and I had overlooked those commands in that README in the project folder. Let me try to get it working.

They should not be part of the book. Please follow the workflow.yaml in the repo for now.

So I ran these, per the README, and they appeared to run OK (see middle job in screenshot below).
kubectl create -f manifests/e2e-demo/workflows-templates-tfjob.yaml
kubectl create -f manifests/e2e-demo/e2e-workflow.yaml

However, each time I try to run kubectl create -f workflow.yaml using this file workflow.yaml, it is failing, per the error at the top of this thread.
It seems I am missing the various templates referenced here. It somehow expects these workflow-templates to pre-exist, but I can't find them anywhere in the code. Am I missing something?

Thank you! I just fixed it. Could you try again?

That change permitted the workflow to begin running. It seemed like a small tweak. Do you mind explaining what the fix was?

However, I'm seeing that the multi-worker-training-* pods get stuck in pending.

If I look into one of them I see the following 'event' -  Warning  FailedScheduling  5m31s  default-scheduler  0/1 nodes are available: 1 persistentvolumeclaim "strategy-volume" not found. preemption: 0/1 nodes are avail ││ able: 1 Preemption is not helpful for scheduling.
Maybe this is a namespace issue. My persistentvolume 'strategy-volume' does exist ... but in the default namespace. I think it was generated from here. Perhaps it needs to be in the kubeflow namespace for this to work?

Did you run the following to change to current namespace?
kns kubeflow
Once it's ran, all your manifests without specifying the namespace will use the current namespace.

Is kns an alias for something else?

I see it at blendle/kns.
I suppose the kubectl-native way would be kubectl config set-context --current --namespace=kubeflow. I'm not often doing that.

Ran this:
% kubectl config set-context --current --namespace=kubeflow
Context "k3d-distml" modified.
% kubectl create -f workflow.yaml
workflow.argoproj.io/tfjob-wf-k45fh created

Same issue with Warning  FailedScheduling  5m31s  default-scheduler  0/1 nodes are available: 1 persistentvolumeclaim "strategy-volume" not found. preemption: 0/1 nodes are avail ││ able: 1 Preemption is not helpful for scheduling.
Will have to try to re-create strategy-volume in kubeflow namespace tomorrow ... and see if that fixes.

It should be covered in previous chapter. Instead of switching current namespace, you can also add -n Kubeflow in your kubectl commands to specify namespace explicitly.

@terrytangyuan ... got things working by recreating the strategy-volume in kubeflow namespace.
I noticed here, that it should be "--model_type", "batch_norm" ... rather than dropout that is repeated for models 2 and 3.
I'll close out this for now and maybe raise a separate issue ref. other feedback on Chap 9.

Great thanks!


Add instructions to skip initialization on aragon dao install

If install command doesn't find initialization method, it won't
initialize the newly installed app, but this is not obvious from the
help instructions.
Although it's "dangerous", sometimes it's useful to install an app
without initializing. For instance, Token Manager: to initialize it
the token must be provided, and this token must have this new Token
Manager app as controller. Therefore token controller must be changed
in between creation and initialization of Token Manager app.

See https://github.com/aragon/aragon-cli/pull/312

I personally think it's fine for such a small PR like these one (and the one in aragon-cli) which doesn't even touch code. When I add 3 reviewers I'm not necessarily meaning "all of them" ("AND"), in this case it was more like "any of them" ("OR"). But not sure what the correct procedure is.


[WIP] Fix legendClickable option

Updates
Fixes #71
Disables both the hover effect and "click" pointer for unclickable legends.
Review checklist (for reviewers only)

[ ] Demos all features
[ ] Documented/annotated
[x] Matches UI/UX specs
[x] Meets the code style guide
[ ] Accessible
[x] Mobile first (responsive)
[ ] RTL support (bidirectional text)
[x] Performant (limited bloat)

Adding to my comment above:

Alright the legend tooltip also respects the option now.


test: add unit test for known measure values

Add a unit tests that verifies all measures against some known values as published in the "From WER and RIL to MER and WIL" paper.

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.


Use GitHub action from Kolya to check PRs

See  https://github.com/marketplace/actions/modelix-url

This feature is not supported anymore.


Bump ruby version

Discourse minimum version of ruby now is 2.3 , bumped ruby version accordingly

@rodrigoesborges you are a true life saver🥇! wasted a whole week trying all kinds of different linux distros to make this work!! glad i finally read your pull request and worked immediately. @jamielinux pls merge this super valuable contribution so others dont suffer the way i did.


Unstable whitespace normalization around comments

I encountered an issue where normalizing (Jsoup.parse(doc).toString()) an already-normalized document produces a different output.
Normalizing this document:
<!doctype html>
<html lang="en">
 <head>
  <meta charset="UTF-8">
  <title>Test</title>
 </head>
 <body>
  <!-- Comment -->
 </body>
</html>

Produces this output:
<!doctype html>
<html lang="en">
 <head>
  <meta charset="UTF-8">
  <title>Test</title>
 </head>
 <body><!-- Comment -->
 </body>
</html>

I.e. the whitespace between the opening body tag and the comment gets removed.
However, normalizing that output then produces the original document with the space between the opening body tag and the comment.
At first I thought this was related to the pretty-printing improvements in version 1.15.4, but it also appears in version 1.15.3.

Thanks, fixed!

Thank you! :)


Implement TapGestureRecognizer

I wanted to use TapGestureRecognizer and I try to implement it myself.
I had two challenges:

A way to pass TapGestureRecognizer to GestureElement, which I used CascadingValue for that.
a way to pass GestureRecognizers to AttributesBuilder, which has a issue as stated here and I (ab)used MulticastDelegate to pass it, which works for now!

@Elion I want to know your thoughts and see if this can be merged to repo.

Wow thank you @Kahbazi ! I see a lot of great concepts in here! I will take a close look at this because I think there's a lot of stuff in here that could add great value to Mobile Blazor Bindings!

Hi @Kahbazi I apologize for this taking sooooo long! I was reminded of this issue when I saw #164 was recently filed.
I was inspired by the very clever code in this PR and have opened https://github.com/xamarin/MobileBlazorBindings/pull/166 with a variation of this.
If you'd like, please have a look at that PR and let me know your thoughts!


canAddLanes doesn't default to false as readme claims

Describe the bug
According to the readme file the "canAddLanes" should default to "false" if not provided. It doesn't.
To Reproduce

Add a board using this syntax (NOT adding "canAddLanes")
<Board        data={toTrelloData(board)}        style={{          backgroundColor: '#276877',          height: '700px',          borderRadius: '0.5rem',          boxShadow: '0px 0px 10px 0px #888888'        }}        draggable        editable        collapsibleLanes        laneDraggable={false}        cardDraggable        hideCardDeleteIcon      />
view result
"Add another lane" button appears to the right of existing lanes and is usable.

Expected behavior
No "Add another lane" button should appear.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 18.04
Browser: Chrome
Version: Version 70.0.3538.77 (Official Build) (64-bit)

@mandudeboy - that's interesting, as the default most definitely is false (line 229):
https://github.com/rcdexta/react-trello/blob/6e752f49f8ac21c0fbd4b27a99ce4334393b6979/src/components/BoardContainer.js#L222-L239
I'll have a look tomorrow, and see if I can figure out why it's not working.
In the meantime, can you confirm the package version you've got installed?

I have tried passing canAddLanes={false} and also canAddLanes="false" but it always shows the "add another lane" button

<EMAIL_ADDRESS>

Updated now, so now it says "version": "2.0.4" in package.json

Seems like it's working now... I have no idea why... sorry if this caused any problems, I don't know if the upgrade fixed it or if something else did.


Errors with Angular v6 and RxJS v6

Issue
When upgrading to Angular v6 (which uses RxJS v6) the following errors appear because of breaking changes introduced with RxJS v6.
ERROR in ./node_modules/ng-drag-drop/src/directives/droppable.directive.js
Module not found: Error: Can't resolve 'rxjs/Observable' in './node_modules/ng-drag-drop/src/directives'
ERROR in ./node_modules/ng-drag-drop/src/services/ng-drag-drop.service.js
Module not found: Error: Can't resolve 'rxjs/Subject' in './node_modules/ng-drag-drop/src/services'
ERROR in ./node_modules/ng-drag-drop/src/directives/droppable.directive.js
Module not found: Error: Can't resolve 'rxjs/add/observable/of' in './node_modules/ng-drag-drop/src/directives'
ERROR in ./node_modules/ng-drag-drop/src/directives/droppable.directive.js
Module not found: Error: Can't resolve 'rxjs/add/operator/map' in './node_modules/ng-drag-drop/src/directives'

Workaround
Install a temporary compatibility library:
npm install rxjs@6 rxjs-compat@6 --save

Solution
Use rxjs-tslint to refactor TypeScript code so that it doesn't depend on rxjs-compat:
npm i -g rxjs-tslint
rxjs-5-to-6-migrate -p [path/to/tsconfig.json]

Here is the complete migration guide from rxjs v5.x to v6:
https://github.com/ReactiveX/rxjs/blob/master/MIGRATION.md#rxjs-v5x-to-v6-update-guide
Contribution
Let me know if you need help doing the necessary changes.

Angular version: 6.0.0
Angular CLI Version: 6.0.0
RxJS version: 6.1.0
Typescript version: 2.7.2

Since the PR is merged. Is there anything left for a release of the Angular 6 support without rxjs-compat?

what @scic said, I would like to help move this alon. Also, thank you to @aleclerctekaris

Anybody know when this will be merged to master / released?

Sorry for the delay on this. I will build by end of the week. In the meantime, if anyone wants to take a stab at it I'll be happy to add him as a collaborator.

@ObaidUrRehman oof

@ObaidUrRehman Come on man, it's been 8 days since you said you'd get to merging to master. I would really like to use your library in my project!

Sorry for the delay on this one Guys. Just published v5.0.0


Update API to handle individual work history breaks

Context
On the candidate interface, we've added a new feature (which is currently under a feature flag called work_breaks) in which we show breaks that occur in their work history so that a candidate can enter a reason for each individual one. See screenshot below (FYI it shouldn't show the "Tell us about any breaks in your history", this is a bug).
Currently, we have a single text attribute called work_history_breaks on an ApplicationForm and so the API simply spits this out when presenting an application. But with the new feature we added a new table called ApplicationWorkHistoryBreaks which means that an ApplicationForm can have many ApplicationWorkHistoryBreaks.

Changes proposed in this pull request
This PR updates the API to return a candidate's work history breaks based on the work_breaks feature flag. So, if the feature flag is on, then munge all application_work_history_breaks. Else, use the work_history_breaks text attribute.
E.g. a response with the feature flag on will look like this:
February 2019 to April 2019: I was watching TV.

September 2019 to December 2019: I was playing games.

Guidance to review
Are we happy with this response? Am I missing anything else?
Link to Trello card
https://trello.com/c/jIWipybM/732-calculate-work-gaps
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

Realised that this is a lil more complicated than initially thought, currently this PR doesn't consider if a candidate has a value in work_history_breaks while the work_breaks feature flag is on.
Talked this through with Duncan and drew up a table: https://trello-attachments.s3.amazonaws.com/5cb88ec4be601441218204a0/5e149b5f6ab09630e5d6f2c9/174eb5e5d0b5a17d9cd7c270d0024b2e/IMG_20200218_122509.jpg.
Will update this PR now.

@duncanjbrown I've updated the PR now as well as the PR description! Please could you have a look for me. Thanks!


Gauss elimination code (Julia) is wrong

Basically

Don't check for singularity as Gauss Elimination can be done on singular matrices
Pivots are not neccessarily on the diagonal
Cover the general case and don't assume triangular matrices

This issue affects PR #200 (contains more details on the bugs) and PR #195

#183 (which is already merged) is also wrong

The best is 4. In general, almost nothing you state in the chapter is wrong so it doesn't need that much rewrite. Back substitution DOES make sense in the case of singular matrices, you just need to travel through the pivots, not the diagonal. Again, very little rewrite, I believe. And yes, putting a couple more examples of non-physical examples will help with intuition.
I'm very happy to try and add something to my PR tonight, I've already modified the chapter anyway.

Yup, sounds good. Please feel free to do what you can when you have the time.

I've modified the chapter over in #193


Added change event to jquery part

I use the formatter for invoices. When the value changes I want to recalculate the totals.
When value changes should trigger change event

It's already there!
It's "pricechange", and will be triggered when value changed on keyup.
$("#example").on("pricechange", function ()
{
//Do Stuff
});

Hi Carlos,
Why is the change event not normally used?
I havent seen this new behavior. Anyway thx for pointing me for that.

Hi @eL-Prova and @CarlosHBP !
This Pull Request is too old, We will close it so we can update a new version of the plugin.
Thanks for the contribution.


Typo in help message

Steps to reproduce

Run nusex --help

Expected behaviour
It will be a grammatically correct help message ;)
Current behaviour
-i, --info            show detailed information for nusex exit
System information
nusex 1.2.4.post1
CPython 3.10.0 GCC 11.1.0
Linux 5.10.83-1-lts
└──Arch Linux
Additional information
No response
Checklist

[X] I have searched the issue tracker for duplicate issues and couldn't find any. If this is a follow-up issue, I have specified as such.

This is a big oof lmao. I'll make sure that gets patched for the next release.

I tried to look for for where that line comes from and literally couldn't find it, otherwise I would have just fixed it lol.

It's in the main CLI file where all the subcommands are created.


Blocking and Riot Shields

About the PR
There is still a pesky bug where if you anchor something with a temperature component, they get infinite temperature. Confirmed to be related to anchoring an entity and not static.
requires: #8661
requires: https://github.com/space-wizards/RobustToolbox/pull/3004
closes: #7778
Introduces Blocking and Riot Shields!

If you're actively blocking, it lowers damage even further, you become immobile, and stop people from passing you!
Right now to use this you use Riot Shields. They will break after a certain amount of damage!
There will be more things that will let you block in the future!
Screenshots

Changelog

:cl:

add: Blocking has now been added! Use shields to lower incoming damage.
add: Riot Shields have been added!

Bug fix is in https://github.com/space-wizards/space-station-14/pull/8661

The only issue is the infinite temperature bug when an entity is anchored. I'm not sure how to go about fixing it.

My rider is bugging out on this pr so I'll look at it later.


chmod on activate.sh

Marks script as executable

nvm this was intentionally not executable

ah you're supposed to dot include it

source activate.sh on unix


Regression in host

APIM-CLI version
1.14.0
API-Management version
7.7.20211130
Bug description
hi,
we found a regression in our system while testing the latest version 1.14.0.
consider the following situation
json api config file
{ ....
"backendBasePath": "http://myhost:597"
...
}
swagger file:
{
"host": "http://fakehost"
}
with 1.13.0 and replaceHostInSwagger=true the backendBasePath wins over swagger host (our desired behaviour).
with 1.14.0 where (replaceHostInSwagger is no longer considered) the swagger host replace backendBasePath e we don't want that because the swagger file is the same for each environment but the real host must change (according to backendbasepath in json config file) and in some case, we cannot force the developer to remove the field from swagger.
so basically we would like to have replaceHostInSwagger parameter back.
this parameter in combination with ovverrideSpecBasePath must support all the scenarios in order to let the user decide the source of each field (host and base path)
host -> from swagger or from json config file?
basepath -> from swagger or from json config file?
what do you think @rathnapandi ?
Steps to reproduce
No response
Relevant log output
No response

in the pull request you can find that it's not necessary the replaceHostInSwagger parameter but just to uniform the behavior of overrideSpecBasePath parameter.

@gcornacchia
We are using overridebasepath flag if we want to change the basepath in swagger specification. other changes like host:protocol, shceme can be overridden via frontend api.
I have merged your changes; can you please review it.

yes, thanks, I'll check it now

@rathnapandi can you provide me a zip with compiled libraries from develop branch?

hi @rathnapandi , I have the same regression discussed on top of this issue.
consider always the same configuration:
json api config file
{ ....
"backendBasePath": "http://myhost:597/"
...
}
swagger file:
{
....
"host": "http://localhost/"
....
}
My backend API on API Manager is created with host "localhost" which is incorrect because I want to point to http://myhost:597 (as described in json api config file) and I cannot force the swagger to remove "host" field.
In this case, How should I manage this situation?
What do you mean with this "other changes like host:protocol, shceme can be overridden via frontend api."?
thanks

please @rathnapandi, with Axway customer we are introducing the automation for quotas but we need a stable and updated version of apim-cli in order to proceed.

Hi @gcornacchia,
We will override the host/port/protocol via backend service url specified in the image.  The backend URL updated with the value of backendBasepath.  The value will be updated based on the environments ( dev, qa, prod).

Thanks
Rathna

so @rathnapandi you're telling me that the backend base path will override host/port/protocol of the swagger file as it was in my pull request or something similar?
We look forward to your changes, let us know asap

@gcornacchia,
We do not override anything in swagger file by default, it will update  basePath (see the below sample json) element in frontend API (it is represented as Backend Service url in API manager UI).  During runtime (when the request hits gateway), the basePath value from frontend api will be used instead of protocol, host, port defined in swagger.
"serviceProfiles": {
            "_default": {
                "apiId": "c3cc77e7-28a0-42b6-b533-9178ecd89857",
                "basePath": "https://petstore.swagger.io"
            }
        },

But in some cases, we will update the swagger if swagger does not contain host, port, or scheme.  The values will be updated from the element defined in backendBasepath defined in apiconfig.json.  If basePath is empty in swagger, it will be hardcoded as / according to swagger2 specification.
If you want to change the basePath on backend / swagger.  Front API won't provide an option to change backend basePath, there are two options.

Change the basePath to a swagger file.
use Overridebasepath flag in apimcli, it will take the basepath from backendBasepath defined in apiconfig.json and replace basePath in swagger.

I think we don't required any code changes.
Thanks
Rathna

Hi @rathnapandi I dont understand why the parameter replaceHostInSwagger has been removed in some version after 1.13.0, it's the logic we need in order to proceed with the update of all apim-cli. The reason is that we want to have full control of what is deployed in api manager in json config file without having to deal with what is defined in swaggers (I'm always referring about host field)

Hello @rathnapandi , I'm dealing with the same problem of @gcornacchia  in this topic, so please help me to understand:
--> Take as example this piece of api description json file input for apim-cli:
{
...
"apiDefinition": "interface.json",
"backendBasepath": "http://<IP_ADDRESS>:8080",
...
--> and take this swagger interface json piece:
{
"swagger": "2.0",
...
"host": "some.invalid.IP.address",
"basePath": "/v2",
...
"schemes": [
"https",
"http"
],
"paths": {
"/pet/{petId}/uploadImage": {
There are 3 fields object of discussion:
-- api description json file -> field "backendBasepath": the actual protocol+host+port we want to use, as you said on Jul 20, overwriting the eventual host/port/protocol defined in swagger interface and called in outbound.
-- swagger interface file-> field "basePath": this is the path to use after the backendBasepath from api description json file to call the api, we never need to overwrite this path.
-- swagger interface file-> field "host": undesired and for us always to be overwritten, varying for the different environments.
Until 1.13.0, as in your doc https://github.com/Axway-API-Management-Plus/apim-cli/wiki/2.1.2-API-Configuration-file#parameter-backendbasepath , we were using backendBasepath in the api description json file together with the replaceHostInSwagger=true parameter, and it was woking to use "backendBasepath" field instead of "host" field.
Starting from 1.14.0 it's no longer working and we end up with (see examples above) some.invalid.IP.address/v2 released on Manager instead of http://<IP_ADDRESS>:8080/v2.
Don't you have the same problem using examples as above? How can it be solved? Is there some different parameter I should use to say apim-cli to ignore the host field and overwrite it with backendBasepath?
Thanks in advance for your patience

Hi @gcornacchia,
I would like to understand what you are trying to solve to replace the host in swagger file.
From my perspective the flag replaceHostInSwagger does not add any value as we are overriding host name via front end api.
Thanks
Rathna

Hi @lturricchia,
Sorry, I am not clear with the statement "Starting from 1.14.0 it's no longer working and we end up with (see examples above) some.invalid.IP.address/v2 released on Manager instead of http://<IP_ADDRESS>:8080/v2."
Can you please share some screenshots with an issue?
Thanks
Rathna

Hi @rathnapandi,
I must specify: in our problem with host filed, we are referring to the Backend API: here some screen to better explain:
these are the swagger interface and the api description json as example:

here is what happens with previous versions of apim-cli (up to 1.13.0), which is our desired behaviour:

here is what happens with current version (using last build from develop - commit Aug 1 1:13AM GMT+2):

as you can see, using the same files, using the last version the deployed Backend API gets the undesired swagger host field localhost:1234 instead of the BackendBasePath url in api description json file.

Hi @lturricchia,
There is no use with Base URL defined in Backend API.  The front-end API's outbound section Backend Service URL will be used for API calls which will be changed based on deployed environment like test, stage, preprod and production.

Please do let me know your thoughts.
Thanks
Rathna

Hi @rathna, to better understand, could you kindly link me the Axway documentation you are using as reference? Is it explained to avoid use of Base URL of Backend API? That's the logic we use to route to backend, we haven't got the Backend service URL filed in outbound of our Frontend APIs.
Do I read correctly form your screenshot that you are in a APIGateway -> SomeCloudService scenario? We use routing policy, so we are in a APIGateway -> RouteToPolicy scenario (as in screen), could you explain me if/how the Backend service URL is managed respectively?

Thanks in advance for your patience

Hi @rathnapandi ,
hope I'm not disturbing you on holiday, in case have a nice time, waiting for your reply later asap.
Any news about our topic?
To further explain, what we are doing in our Custom Routing Policy is to use a Connect to URL filter to call the Backend API at Base URL (the field now compromised by Apim-cli, as above).
I think this use we make of routing policy is in line with what PolicyStudio supports and suggests for use with API Manager, here some references describing the same we did (put aside the "Amplify" header):
-- here is how we configured our SSL Custom Routing Policy https://axway-open-docs.netlify.app/docs/apim_administration/apimgr_admin/api_mgmt_custom_policies/#create-the-custom-ssl-routing-policy-in-policy-studio
-- here is reported the respective use of the Base URL field from Backend API https://axway-open-docs.netlify.app/docs/apim_administration/apimgr_admin/api_mgmt_custom_policies/#configure-the-custom-sslrouting-policy-in-api-manager
-- here it's specified that when a routing policy is used, the Frontend API field Backend service URL can be ignored using the URL configured in the routing policy (field destinationURL, then using the Backend API field Base URL) https://axway-open-docs.netlify.app/docs/apim_administration/apimgr_admin/api_mgmt_custom_policies/#routing-policy
That's why we need the Backend API field Base URL to be set by Apim-cli with the one in api description json, ignoring the swagger field (see above).
What do you think? Did you find any documentation specifying that the Backend API field Base URL is no longer supported for routing?
waiting for your reply,
thanks for your attention

Hey,
We had the same issues that's completely breaking our usage of the tool.
For a quick fix I did a local change to uniform how the flag overridebasepath is working on the OAS3 with the Swagger 2
In the Swagger2xSpecification.java, method configureBasePath, i added

With this I'm getting back the expected result

hi @rathnapandi , I'm back from a brief period off work.
I cite your sentence:
"There is no use with Base URL defined in Backend API. The front-end API's outbound section Backend Service URL will be used for API calls which will be changed based on deployed environment like test, stage, preprod and production."
I ask myself if we've ever thought about changes in API Manager logic itself.
We are encountering the problem in 7.7 nov 2021. @JuIngong what is your reference API Manager version?
Maybe something has changed in the following releases and field host in the backend API is completely ignored in latest versions? in this scenario apim-cli must deal with these differences in order to not break compatibility.

Indeed, we are using an older core version as well (if I'm not mistaking, depending on the env we have both 7.7.20210830 and 7.7.20211130)

Hi @JuIngong,
Can you share the issue you are facing? We can override the host and scheme / protocol via frontend api.
Hi @gcornacchia,
I am sure that nothing changed in terms of handling host filed on backend and frontend API.
Thanks
Rathna

Same issue described in this issue, when using a swagger (2.0) which has a host specified, even if in my apm-import the backend basepath is specified, it is neither overrode in the outbound backend field of the Frontend API and neither in the Backend API (which, as you said is not important).
But if i'm using an Open API (3.x.x) file the host is overrode as expected

hi  @rathnapandi,
Consider the following attachment
PetStore.zip
it contains a simple API apim-cli config file and dependencies (swagger file and trusted certificate).
in this case, the frontend API points to the backend defined in the host field in swagger and not the backendBasePath field in json.
Can you reproduce this issue? just enable the Community organization to API development.
I also tested with latest version (may 2023) and the behavior is the same.

hi @rathnapandi, I forgot to mention all of the variables:
apim-cli version: 1.14.1
apim-cli configuration file:
force=true
quotaMode=replace
clientAppsMode=replace
clientsOrgsMode=ignore
replaceHostInSwagger=true
zeroDowntimeUpdate=true
overrideSpecBasePath=true
api.defaults.state=published

//the following variabiles are defined in each stage properties file
username=<>
password=<>
host=<>
port=<>

import script:
 ./apim.sh api import -c PetStore.json -s <staging environment>
and that's the result:

this is the log (info level):
2023-08-24 11:04:26,580 [APIManagerCLI] INFO : API-Manager CLI: 1.14.1
2023-08-24 11:04:26,582 [APIManagerCLI] INFO : Module: API - I M P O R T (1.14.1)
2023-08-24 11:04:28,844 [APIManagerAdapter] INFO : Successfully connected to API-Manager (7.7.20211130) on: https://<IP_ADDRESS>:8076
2023-08-24 11:04:29,439 [APISpecificationFactory] INFO : Reading API-Definition (Swagger/WSDL) from file: \petstore.json (absolute path)
2023-08-24 11:04:29,446 [APISpecificationFactory] INFO : Detected: Swagger 2.0 specification.
2023-08-24 11:04:30,643 [APIImportConfigAdapter] INFO : Handling configured client-applications.
2023-08-24 11:04:30,644 [APIImportApp] INFO : Lookup actual API based on Path: /petstore
2023-08-24 11:04:31,670 [APIImportManager] INFO : No existing API found, creating new!
2023-08-24 11:04:32,514 [CreateNewAPI] INFO : Create published API: Petstore_v1 1.0  based on Swagger 2.0 specification.
2023-08-24 11:04:36,454 [ManageClientApps] INFO : All desired applications: [] have already a subscription. Nothing to do.
2023-08-24 11:04:36,454 [CreateNewAPI] INFO :  Successfully created published API: Petstore_v1 1.0 (ID: 1ac7c0e9-a0ca-4de3-9b50-a9bff98af3c6)

Hi @gcornacchia,
Thanks for sharing the test data, I could reproduce the issue.   Below line is blocking the basepath update on front end api.
https://github.com/Axway-API-Management-Plus/apim-cli/blob/64b634a9f92343f05d1ca2aafac3d4809727c007/modules/apis/src/main/java/com/axway/apim/apiimport/actions/CreateNewAPI.java#L69
I am fixing the issue as suggested by you and @JuIngong.

I will try the code in develop branch and I will give you a feedback

hi @rathnapandi, I've tested the code in develop branch and it seems all ok regarding the handling of backend base url where host is defined in interface file.
But... I've found another regression in handling base path in OAS3 interface, consider the following attachment:
PetStoreOAS3.zip
in json config file there is a backendBasePath with no relative path.
  "apiDefinition": "./oas/petstore.json",
  "backendBasepath": "https://petstore.swagger.io",
  "applications": [],
  "clientOrganizations":

in oas3 file there a url field with only relative path:
  "servers": [
    {
      "url": "/v2"
    }
  ],

After import with latest version the "/v2" path disappears from the backend api and the API call to backend is not pointing to correct url.

I remember the same problem were solved in another issue https://github.com/Axway-API-Management-Plus/apim-cli/issues/397 for swagger 2.0.
Maybe it's missing the check on final slash in backendbasepath before deciding to override spec base path for OAS3?

@rathnapandi consider my pull request #428

Thanks @gcornacchia for reporting, I will review and get back to you if needed.

Hi @gcornacchia,
For your case  the value should be "backendBasepath": "https://petstore.swagger.io/v2".
We are using flag overrideSpecBasePath to change basepath.
if you want to just change hostname,  change the value of overrideSpecBasePath=false or remove it.  That will update  frontend api outbound section Backend service url with value from backendBasepath .
Also, if host is not defined in openapi specification,  apim cli will take hostname from backendBasepath and change the openapi specfication.

HI @rathnapandi,
I add some considerations:

In our deploy pipelines, we cannot change the value of overrideSpecBasePath parameter at runtime as we must handle both swagger 2.0 or OAS3 APIS without prior knowledge.

The intention of my pull request was to reach the direction defined in a table that I've uploaded in a past PR (do you remember?)

the idea was to handle both swagger 2.0 and oas3 interfaces in the same coherent way.
Tell me what do you think about it?
in case you don't want to merge the PR please, tell us when you want to release 1.14.2 version (with the "host" bug fixed)

Hi @gcornacchia,
We are following the openapi specification for updating host .

Reference the section https://swagger.io/docs/specification/api-host-and-base-path/
The next release is planned on 1st September, will update documentation as well.

yes ok but in my mind oas3 and swagger 2 are not handled in the same way.
If I'm using swagger 2.0 I can use the base path from swagger field and specify only host/port in backendbasepath (in json config file).
If I'm using oas3 I cannot use base path (from servers.url field) and I have to specify host/port/basepath in backendBasePath (in json config file).
Anyway, I will try to use a workaround before calling apim-cli.
If you prepare a 1.14.2 pre-release package I can do more tests before Friday. Let me know

Thanks @gcornacchia for your support.  Released 1.14.2 with the fix. please do let me know if you see any other issues.

Hi @rathnapandi,
I've done further tests.
Everything is ok regarding the handling of "host" field, but I've found an issue about quota handling, I've opened issue #434.


Outbound survey to spreadsheet

Okay so a few things about this. The goal was to create an outbound health survey that would record session data after each answer and then push that to a google sheet. You can view the google sheet here:
https://docs.google.com/spreadsheets/d/1MHDDdOzX-KizYVVd0OCU-Nmnymo44kkyJ0CRCyGkurs/edit?usp=sharing
I did export SECRET_KEY="Secret String Shhh" for the secret key, but not sure if that matters.
The code technically works, in that it does record data to session['answers'] and push it to the google sheet, however it's the wrong data and I can't seem to figure out why. I can press 2 (or 'No') for the answer to every single question and still get an output like this where the length of ['answers'] doesn't match and neither do the values appended.
<IP_ADDRESS> - - [13/Apr/2021 12:42:09] "POST /survey/description HTTP/1.1" 200 -
<IP_ADDRESS> - - [13/Apr/2021 12:42:14] "POST /survey/question_one HTTP/1.1" 200 -
Digits pressed are: 2
Session is:
<FileSystemSession {'_permanent': True, 'answers': ['No']}>
Answers are:
['No']
<IP_ADDRESS> - - [13/Apr/2021 12:42:18] "POST /survey/question_two HTTP/1.1" 200 -
Digits pressed are: 2
Session is:
<FileSystemSession {'_permanent': True, 'answers': ['Yes', 'No', 'Yes', 'Yes', 'No']}>
Answers are:
['Yes', 'No', 'Yes', 'Yes', 'No']
<IP_ADDRESS> - - [13/Apr/2021 12:42:21] "POST /survey/question_three HTTP/1.1" 200 -
Digits pressed are: 2
Session is:
<FileSystemSession {'_permanent': True, 'answers': ['Yes', 'Yes', 'Yes', 'No']}>
Answers are:
['Yes', 'Yes', 'Yes', 'No']
<IP_ADDRESS> - - [13/Apr/2021 12:42:26] "POST /survey/question_four HTTP/1.1" 200 -
Digits pressed are: 2
Session is:
<FileSystemSession {'_permanent': True, 'answers': ['Yes', '21', 'No']}>
Answers are:
['Yes', '21', 'No']
<IP_ADDRESS> - - [13/Apr/2021 12:42:30] "POST /survey/question_five HTTP/1.1" 200 -
Digits pressed are: 22
Session is:
<FileSystemSession {'_permanent': True, 'answers': ['No', 'Yes', '11', 'Yes', '22']}>
Answers are:
['No', 'Yes', '11', 'Yes', '22']
<IP_ADDRESS> - - [13/Apr/2021 12:42:34] "POST /survey/end_survey HTTP/1.1" 200 -

Shashi tested this on Twilio and found that the same code works correctly. From his tests, it seems like we are not creating a session cookie for a call session and they do. Not sure if we can change this, or if there's a different problem taking place?

Sessions are the wrong mechanism here. A session is a data store backed by a cookie, which is a browser mechanism, not a server side one. You can store the answers in memory in a hash, it’s simpler and will work with anything.

@lpradovera I'll work on rewriting it. Bryan also confirmed we don't support sessions at this time, which explains why it worked for Twilio. How do I delete this whole branch? I keep getting alerts from google cloud platform because of the shared cred.json file

Closing as requested


Update on Contact-Us

Contact us functionality has been implemented and messages can be view by the admin

Implementing contact-us functionality


fix: not close tooltip on click

Closes #603
Description

Fix bug . Tooltip should be not closed when click on trigger element.

Current behavior (updates)

Currently, when click on trigger element the tooltip will be hidden

New behavior

Tooltip not being hidden when click trigger element.

Is this a breaking change (Yes/No):

no

Additional Information
https://github.com/hirotomoyamada/yamada-ui/assets/78476413/1704638a-18f1-4543-91ea-1807967f4c7a

@quangnmwork
Hey! thanks for the PR.
Please also change JSDocs.
  /**
   * If `true`, the tooltip will hide on click.
   *
   * @default false
   */
  closeOnClick?: boolean

@quangnmwork
Hey! thanks for the PR.
Please also change JSDocs.
  /**
   * If `true`, the tooltip will hide on click.
   *
   * @default false
   */
  closeOnClick?: boolean

Thanks . I have changed the JSDoc !


Azure AD permissions needed

Hi There, I am running a pipeline under a service principal and I try to add new owners to the Azure AD applications that I create through this SP. The latter as the following permissions granted:

However I am not able to add new owners when I create a new application here is the steps that I follow:
#login using the service principal
$ az login --service-principal --user $app_id --password $app_secret --tenant $tenant_id

#creating new application
$ export created_app_id=$(az ad app create --display-name "sp-created-app2" --query appid -o tsv)

#Add new owner to my subscription
$ az ad app owner add --id $created_app_id --owner-object-id $my_azuread_user
Insufficient privileges to complete the operation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7af83ae6-8be6-c2a3-e994-d09b60ddc167
Version Independent ID: 70f8a6b9-5cba-2e41-1046-423405782c4c
Content: az ad app owner
Content Source: src/azure-cli/azure/cli/command_modules/role/_help.py
Service: active-directory
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

add to S172

Any update on this ? It should not be too difficult that someone from Microsoft answer this question ?

If you are using az ad, the only permission needed to manage an application is Azure Active Directory Graph > Application.ReadWrite.OwnedBy:

I refined your script a little bit and it works fine:
app_id=93dde3da-9fca-47dd-aee2-409b402ffed3
app_secret="IB0..."
tenant_id=54826b22-38d6-4fb2-bad9-b7b93a3e9c5a
my_azuread_user=7a938a30-4226-420e-996f-4d48bca6d537

# Login using the service principal
az login --service-principal --username $app_id --password $app_secret --tenant $tenant_id --allow-no-subscriptions

# Creating new application
created_app_id=$(az ad app create --display-name "sp-created-app2" --query appId -o tsv)

# Add new owner to my application
az ad app owner add --id $created_app_id --owner-object-id $my_azuread_user

Please note that

The query should be appId instead of appid, because JMESPath is case-sensitive.
(Optional) You don't need export since these commands are in the same Bash script. 😉

If it still doesn't work, please run the command with --debug and share the output.
You may also be interested in the new az rest and Microsoft Graph way: https://github.com/Azure/azure-cli/issues/12946#issuecomment-611922734.

If you are using az ad, the only permission needed to manage an application is Azure Active Directory Graph > Application.ReadWrite.OwnedBy:

I refined your script a little bit and it works fine:
app_id=93dde3da-9fca-47dd-aee2-409b402ffed3
app_secret="IB0..."
tenant_id=54826b22-38d6-4fb2-bad9-b7b93a3e9c5a
my_azuread_user=7a938a30-4226-420e-996f-4d48bca6d537

# Login using the service principal
az login --service-principal --username $app_id --password $app_secret --tenant $tenant_id --allow-no-subscriptions

# Creating new application
created_app_id=$(az ad app create --display-name "sp-created-app2" --query appId -o tsv)

# Add new owner to my application
az ad app owner add --id $created_app_id --owner-object-id $my_azuread_user

Please note that

The query should be appId instead of appid, because JMESPath is case-sensitive.
(Optional) You don't need export since these commands are in the same Bash script. 😉

If it still doesn't work, please run the command with --debug and share the output.
You may also be interested in the new az rest and Microsoft Graph way: #12946 (comment).

Did you run it on Azure dev-ops?

Hi @jiasli
Part of the log.
2020-06-30T20:33:20.1579640Z msrest.http_logger : Request method: 'POST'
2020-06-30T20:33:20.1580139Z msrest.http_logger : Request headers:
2020-06-30T20:33:20.1580569Z msrest.http_logger :     'Content-Type': 'application/json; charset=utf-8'
2020-06-30T20:33:20.1581012Z msrest.http_logger :     'accept-language': 'en-US'
2020-06-30T20:33:20.1581406Z msrest.http_logger :     'Accept': 'application/json'
2020-06-30T20:33:20.1581805Z msrest.http_logger :     'Content-Length': '127'
2020-06-30T20:33:20.1582627Z msrest.http_logger :     'User-Agent': 'python/3.6.6 (Windows-10-10.0.14393-SP0) msrest/0.6.9 VSTS_df52c552-bfb2-4247-bf60-fd1abee0a25b_Release__1070_2816_1 msrest_azure/0.6.3 azure-graphrbac/0.60.0 Azure-SDK-For-Python AZURECLI/2.7.0 (MSI)'
2020-06-30T20:33:20.1583323Z msrest.http_logger : Request body:
2020-06-30T20:33:20.1583888Z msrest.http_logger : {"url": "https://graph.windows.net//directoryObjects/xxxxxxx"}
2020-06-30T20:33:20.1584450Z msrest.universal_http : Configuring redirects: allow=True, max=30
2020-06-30T20:33:20.1584946Z msrest.universal_http : Configuring request: timeout=100, verify=True, cert=None
2020-06-30T20:33:20.1585531Z msrest.universal_http : Configuring proxies: ''
2020-06-30T20:33:20.1585987Z msrest.universal_http : Evaluate proxies against ENV settings: True
2020-06-30T20:33:20.1611847Z urllib3.connectionpool : Starting new HTTPS connection (1): graph.windows.net:443
2020-06-30T20:33:20.2679503Z urllib3.connectionpool : https://graph.windows.net:443 "POST //applications/xxxxxxxxxxxxxxxxxxxxx/$links/owners?api-version=1.6 HTTP/1.1" 403 219
2020-06-30T20:33:20.2680968Z msrest.http_logger : Response status: 403
2020-06-30T20:33:20.2681391Z msrest.http_logger : Response headers:
2020-06-30T20:33:20.2682608Z msrest.http_logger :     'Cache-Control': 'no-cache'
Thanks

Hi @nishanperera, I ran that script on a local machine, but I don't think there is any difference between running on DevOps or a local machine.
From the debug log, the failed request is
POST  https://graph.windows.net:443/***/applications/xxxxxxxxxxxxxxxxxxxxx/$links/owners?api-version=1.6

Does the service principal has Azure Active Directory Graph > Application.ReadWrite.OwnedBy permission?

Hi @jiasli,
Yes, it does have access. It can create the AAD application but can not add owners. I am using Azure CLI task.

The screenshot doesn't contain the admin consent status. Please make sure it shows a green check mark (similar to ✅) as shown in https://github.com/Azure/azure-cli/issues/14074#issuecomment-651480005.
If so and adding owner still doesn't work, could you open a support ticket to AAD in Azure Portal and provide the --debug log? A support engineer will gladly help you troubleshoot it from backend. Thanks for your understanding.

@jiasli Yes, it has admin consent.

This is really weird. 🤔 Could you reach out to AAD team? As I don't have access to the AAD logs.

Hi Guys I managed to solve the issue, this is the permission that was missing:

You do only need the following permissions to do the use-case presented:
Azure active directory graphs:

Application.readWrite.OwnedBy -- Application
Directory.Read.All -- Application

Hi @markthebault, Directory.Read.All -- Application is not a trivial permission, and may grant the application the permission to read sensitive data in the directory. I would still recommend contacting AAD support team to report this issue or asking for clarification.

Hi, @markthebault I am in the process of adding the permission. Found this article
https://docs.microsoft.com/en-us/graph/api/application-post-owners?view=graph-rest-1.0&tabs=http seems like it is necessary @jiasli

Thanks @nishanperera for the link.
Indeed, https://docs.microsoft.com/en-us/graph/api/application-post-owners?view=graph-rest-1.0&tabs=http indicates that for Application, Application.ReadWrite.OwnedBy and Directory.Read.All are the minimum required permissions.


Mouse arrow for Desktop Sharing

Last version 2.10.5550
All users using windows 7 and no one cant see mouse arrow. All another things working well. Thanks for that. Checked by a lot of devices and accounts. What is wrong?

Same issue to see mouse in screen sharing mode.
I also have a problem with key map in remote control mode. Back space and Enter Key send a char.
Is it link ?

https://github.com/jitsi/jitsi/issues/104

I think it should be fixed in libjitsi. Not here.
I remember about StringUtils but right now I'm busy with MR to gstreamer: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/382
If you remember I suggested to implement one backcend for all platforms in libjitsi and decided to fix issues in gstreamer which blocked that suggestion. But seems it requires more time ...
@damencho @ibauersachs I wanted to ask you:
do you use libjitsi outside of Jitsi Desktop?
What components are used in another projetcs now?

Jitsi-videobridge and jigasi. Soon it will no longer be dependency to jvb, so only jigasi ...

@damencho @ibauersachs
Please let me know does it make a sense to work on Jitsi Deskop and libjitsi?
Once gstreamer review is done and my commits are in master I going to back to jitsi stuff

@damencho @ibauersachs
is there any users statistic? do you know how much users are there?

Not really any stats ...


Add validation for main class and api version

This PR adds additional validation for the main class and the api version for bukkit based plugin yamls.
One of the most common pitfalls for beginners is the api version, which they thinks is equal to the servers version. This PR aims to assert those mistakes already on build time.
The second common pitfall is (Beside entering a completely invalid path) using the paper, spigot or bukkit namespace for the main, which is not allowed by at least paper based servers (Didnt bother to check spigots code). Since this is in general a best practice I see no issue in enforcing this already on build time.
Ideally we could also check that the entered path to the main class is in fact existing in the sources, but I lack the knowledge in gradle plugins to do this, so I didnt do this..

@stephan-gh This PR still exists c: I would also volunteer to step is as a maintainer for that plugin if you just lack the overall time to maintain it. There are still upcoming changes to paper and spigot and this plugin will most probably never reach a feature complete status, so it really needs an active maintainer.

@rainbowdashlabs Sorry for the delay and not being very active here. Unfortunately, I don't have much time for maintaining Minecraft-related projects anymore. Would you still be interested in stepping in as maintainer?

@stephan-gh Yes absolutely!

@rainbowdashlabs Thanks, that would be much appreciated! Did you already have a specific setup in mind?
If I remember correctly, the Gradle plugin portal does not allow multiple accounts to publish a plugin, so you would still be dependent on me to publish it. Ownership transfer is possible, but requires contacting them. And in that situation, I'm not sure if it even makes sense to continue using my personal net.minecrell namespace. Perhaps it would be easiest if I direct everyone to your fork? I'm not sure what's the best/easiest way in this case...

@stephan-gh Iirc moving a repo to some other namespace causes github to redirect. at least thats the case when renaming inside a organization. So I kinda would move it to my own namespace in gradle if they let me.
Another option would be to set me as a maintainer here and publish wia a workflow that is using a repository secret. That was I could publish via a workflow.
But the more future proof would probably either forking and redirecting or moving the repo and hoping that github also redirects cross organization.

Yes it works cross organization. https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository

All links to the previous repository location are automatically redirected to the new location. When you use git clone, git fetch, or git push on a transferred repository, these commands will redirect to the new repository location or URL. However, to avoid confusion, we strongly recommend updating any existing local clones to point to the new repository URL. You can do this by using git remote on the command line:

@rainbowdashlabs I think publishing the plugin under a new namespace on the Gradle plugin portal should work fine.
Thinking about it some more, I'm slightly concerned transferring the entire GitHub repository to a different owner right away. I'm sure you can maintain it much better than I was able to in the last year(s), but we also did not have many interactions yet. I just want to make sure that the current state/history remains available forever and some future owner (not necessarily you!) does not delete it for some reason. I hope that is understandable. :)
There are not many existing open issues and pull requests here that would be important to continue in a new repository. If it's fine for you, perhaps it would be easiest if you fork (or push to a new repository) and I just archive this one and point everyone to your repository in the README?
Alternatively, I can add you as collaborator here and we check transferring the ownership sometime later.
What would you prefer?
I'm sorry for the extra trouble. I very much appreciate you volunteering to step in as a maintainer!

I just want to make sure that the current state/history remains available forever and some future owner (not necessarily you!) does not delete it for some reason.

I understand your concern. I would recommend to transfer it and fork it to your organisation again under a slightly different name, to not brek the redirect, since my biggest concern ist probably discoverability of the new active fork aka repository.
But if you don't want this I would more lean towards forking and archiving the original one with a note.

I think I would prefer to archive this repository and add clear notes that the project is now maintained somewhere else (and by someone else). We will need to do this anyway for the Gradle plugin portal, since a redirect isn't possible there. I'll make sure that the notes are prominently visible so that there is no confusion.
I'm quite busy the next week, if you send me the link to the new repository location I'll update the descriptions on GitHub and the Gradle plugin portal after that.
Thanks for all your help! Let me know if you have any questions about the set

The new repository is here https://github.com/eldoriarpg/plugin-yml. Gonna try to apply for the gradle plugin portal next week probably once the notes on that repository are up.

@rainbowdashlabs Sorry for the delay, I've been really busy with other projects. I have now added a note to the README that points to your repository. Once you have published a release on the new repository, I'll check if I can add a note to the Gradle plugin portal as well, and will probably archive this repository.
Thanks a lot for taking over the maintenance of this plugin!

After a lot of back and forth its finally done and published on gradle plugin portal.
https://plugins.gradle.org/plugin/de.eldoria.plugin-yml.bukkit
https://plugins.gradle.org/plugin/de.eldoria.plugin-yml.paper
https://plugins.gradle.org/plugin/de.eldoria.plugin-yml.nukkit
https://plugins.gradle.org/plugin/de.eldoria.plugin-yml.bungee


new button for going to initial location

hi, @spiridonov-oa  :)
great project !
I saw that we can scroll down/up forever and after long work it becomes difficult to find the original starting position, I have added the button to go back to the initial location where we have started, if you like the changes we call pull them, looking forward to working and learning more with you.

Thank You for contributing to this project and making it better!
I will try to find time and improve in the near future.


[Feature] Setup bot to automerge Dependabot PRs after approval

Problem

Dependabot PRs should automatically be merged when both:

all checks pass
they have the required number of approvals

Description

This can be set up as a workflow in .github/workflows that is synced to all sub-repositories.
An open-source bot named Kodiak can be setup for this purpose. It's very versatile.
Alternatives

The second person to approve Dependabot PRs should merge them as well. It's just a choice between cultivating a habit vs. letting a bot handle it.
Implementation

[ ] 🙋 I would be interested in implementing this feature.

hey @saurabhan, you are working on this issue?

Completed as part of #3312 here:
https://github.com/WordPress/openverse/blob/19f5c5b41f1c294f349193b3b000642931b7c3b4/.github/renovate.json#L11-L12


Improvements

Thanks for the pull request. Noticed you've removed X-Frame-Options from the nginx config. You'd added this in #27, was just wondering if you could clarify why it has been removed. Was it causing issues with the latest version?

Actually, I did provide the clarification in 5e52b30 commit message. Clients were receiving the header twice and with conflicting values.

Thanks, had only read the top line commit.


Can we get memory dump and CPU trace automatically stores to S3 buckets when certain value of memory and CPU crossed

Hi,
How can I get memory dump and cpu trace for a pod when the memory and cpu usage crosses some x value and stores directly in S3 buckets so that I can have access to the dump and trace when the pod gets terminated due to high memory and cpu usage. can we achieve this? if so how?
summary: needs dotnet monitor to trigger /dump and /trace endpoints when the cpu and memory usage is above x%  and sends the data to S3 buckets or send data through mail
                                   OR

store dump and trace data in S3 at regular intervals
Environment: Kubernetes environment and dotnet monitor is integrated as side car for a pod

The recent work to refactor egress configuration should make it possible for you to implement your own egress provider and read in configuration. Extensibility of dotnet-monitor is one of our core design tenets, even if we aren't the ones building the extensibility. To that end, we'd be happy to make additional changes to dotnet-monitor to make this possible if you run into any road blocks in attempting this.
Unfortunately, we do not have the resources to work on this at this moment in time. We may reconsider this at a later date, but it is not planned in the near future.

If it helps I have done this by chaining gcdump action to Execute action which passes the egress path to a shell script that uploads the dump to s3

This should now be possible "natively" using a combination of collection rules and the S3 egress provider starting with .NET Monitor 8.0 Preview 1.


Add render mode to ensure correct normals when using non-uniform scaling

Added a new render_mode and material flag that uses the correct normal transformation matrix. This render mode should only be used if the scaling of the mesh is non-uniform, since it makes no difference if the scaling is uniform.

Why not fix the default render instead?

I discussed this issue with reduz and that's the way he prefers it.
Most of the time you don't scale models in a non-uniform way, so it doesn't make sense to always force a costly operation. It could be activated automatically when a non-uniform scaling is detected, but this has some complications too.

Would fix #19256

I would say this should be the default behavior, also the inverse-transpose matrix could be passed as a uniform, taking some work off the GPU. With the matrix being computed once on the CPU this shouldn't bring any further performance implications.

@karroffel That's what I proposed to @reduz, but he didn't like the idea.

So basically I will still need to compute that matrix myself in my terrain plugin, as this "slower" implementation doesn't provide a builtin uniform :p


[bug] I watching this repository release event, but every release new version, github send me some emails

Describe the bug
about github
Reproduction
no
Expected behavior
no
Platform and versions
unwanted

Stack trace
unwanted

Additional context
I watching this repository release event, but every release new version, github send me some emails, Can it send me only one email ?

Please modify that in your settings, we don't control that.


Document SQL support

I didn't make any massive changes here to what @aljazerzen gave me to work with, but please look over it carefully and make sure I didn't change the meaning of anything.

Make sure to require SSL encryption when using SQL support

Could we very briefly explain why this is particularly important in this context?
Last note: I linked to all the tested SQL tools. Could you click through on them just to confirm I found the correct links for all of them?

To be honest, I don't know much about why this is so. I've just noticed that it does not work if I don't tick that box when entering database details. 🤷 @fantix ?

Oh, I see. I thought you were saying this is something that needs to be enabled on the EdgeDB side, but this is actually on the tool side. Let me rework it to note that, and we may not really need an explanation unless @fantix has something that would make sense to add here.

Added some more explicit instructions for connecting, including implementing @tailhook's suggestion of recommending the user create a role for the SQL client.
@aljazerzen Would you take one more pass on this with the connection instructions and make sure everything looks good before I merge?


Create Own VMobject

A small example of how to create an own VMobject in an own class

Thanks for your contribution! To make your example work, you need to place it inside src/examples/CATEGORY/FILENAME.py. Make sure it is ending in .py.
You can check if the style of your file is correct by running flake8 src, otherwise the build will fail.

Alright, I will do that!


nodeTemplate with the Addon..?

Is it possible to put nodeTemplate using this Addon...?

Support for node template was added in version 2.0.3. There is an example in the demo.


[Bug][Config-UI] Jenkins Create/Modify Data Scope + Jobs Failed

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
In the event that the Jenkins API Proxy Service is unable to retrieve Jobs, the UI should degrade gracefully and Not allow malformed entries in the Jobs Selector Component. If No Jobs are available, the Selector should display a message stating that "No Jobs Available" (Follow existing pattern for Selector components no-data scenario)

[ ] Handle Jobs Failed when Jenkins Data Scope is being Created or Modified

What you expected to happen
If No Jobs are available the Jenkins Jobs Selector should render in a no-data scenario with no entries in the list.
How to reproduce

Test Jenkins Data Scope when no Jobs are returned from API Proxy service.

Anything else
No response
Version
main
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@likyh This is a Jenkins issue you may like to troubleshoot as well after JIRA.


updated web3.js v4 import and link

What changed? Why?
web3.js links pointing to v4
this PR closes the issue #185

@SantiagoDevRel Thank U for fixing this!


Kotel

This PR attempts to add open telemetry tracing to franz-go as a plugin.

Hi
Currently we are looking at instrumenting some of our clients with OpenTelemetry traces and metrics and we would like to write this as a plugin utilising hooks. In the realm of OpenTelemetry the tracing information is carried with the context and you access the span via the context. Thus, if we need to be able to create, lets say, a span named in-produce-buffer we need to be able to get the producing context in the hooks OnProduceRecordBuffered (starting the span) and OnProduceRecordUnbuffered (ending the span), currently it does not seems like the interface offers any mechanism to access the producing context in the hooks.
On the producing side we need some way of letting the producer continue the trace. For http handlers it looks something like this
func httpHandler(w http.ResponseWriter, r *http.Request) {
	ctx, span := tracer.Start(r.Context(), "hello-span") // Notice the r.Context()
	defer span.End()

         // do some work to track with hello-span
}

where the context can be extracted from the request and a middleware plugin is responsible for injecting the appropriate information from the HTTP headers into the context before the request is being called by the handler.
We have been thinking about solutions to these obstacles and we would like to get your take on possible solutions too.
As of now, we work around this by adding a Context field to the Record type and let produce set the context on the Record.Context. On the consumer side we would set a context.Background() that could the be "enriched"/replaced in a hook that injects the OpenTelemetry data from the Record.Headers.
It is important to us that we can "hide" as much logic as possible in the plugin as we will ask our consumer and producer teams to enable OpenTelemetry in their kafka clients and we need to make the onboarding to OpenTelemetry as easy as possible. What are your thought here and how do you propose we proceed?


Use multi stage docker builds for building Avalon components

Multi stage docker build (https://docs.docker.com/develop/develop-images/multistage-build/) will help creating and reusing intermediate docker images and copy only required artifacts in final docker image build stage of each Avalon component (shared kv, listener, enclave manager). This will reduce docker image size of each component and also reduce the overall build time.

Issue addressed


Declarative Pipeline: cannot lock via label due to mandatory 'resource' field.

Version report
Jenkins and plugins versions report:

Jenkins: 2.289.3.2
OS: Linux - 5.4.156-83.273.amzn2.x86_64
---
ace-editor:1.1
active-directory:2.24
analysis-model-api:10.2.5
ant:1.11
antisamy-markup-formatter:2.1
apache-httpcomponents-client-4-api:4.5.13-1.0
artifactory:3.13.2
async-http-client:<IP_ADDRESS>
authentication-tokens:1.4
aws-credentials:1.29
aws-java-sdk:1.11.995
blueocean-commons:1.24.7
bootstrap4-api:4.6.0-3
bouncycastle-api:2.20
branch-api:2.6.3
build-environment:1.7
build-name-setter:2.2.0
caffeine-api:2.9.1-23.v51c4e2c879c8
checks-api:1.7.0
cloudbees-administrative-monitors:1.0.1
cloudbees-analytics:1.30
cloudbees-assurance:2.276.0.6
cloudbees-blueocean-default-theme:0.8
cloudbees-folder:6.16
cloudbees-folders-plus:3.15
cloudbees-github-reporting:1.22
cloudbees-groovy-view:1.13
cloudbees-jenkins-advisor:3.3.1
cloudbees-jsync-archiver:5.18
cloudbees-license:9.57
cloudbees-monitoring:2.11
cloudbees-nodes-plus:1.22
cloudbees-platform-common:1.11
cloudbees-platform-data:1.21
cloudbees-plugin-usage:2.10
cloudbees-ssh-slaves:2.9
cloudbees-support:3.28
cloudbees-template:4.49
cloudbees-uc-data-api:4.44
cloudbees-unified-ui:1.10
cloudbees-view-creation-filter:1.6
cloudbees-workflow-template:3.12
cloudbees-workflow-ui:2.6
command-launcher:1.6
config-file-provider:3.8.1
credentials:2.5
credentials-binding:1.26
data-tables-api:1.10.23-3
display-url-api:2.3.5
durable-task:1.35
echarts-api:5.0.2-1
email-ext:2.83
envinject:2.4.0
envinject-api:1.8
file-operations:1.11
font-awesome-api:5.15.3-3
forensics-api:1.0.0
gerrit-code-review:0.4.7
git:4.7.2
git-client:3.7.2
git-server:1.9
github:1.33.1
github-api:1.123
github-branch-source:2.11.2
gradle:1.36
handlebars:3.0.8
handy-uri-templates-2-api:2.1.8-1.0
infradna-backup:3.38.35
ivy:2.1
jackson2-api:2.12.3
javadoc:1.6
jaxb:<IP_ADDRESS>
jdk-tool:1.5
jira:3.3
jira-steps:1.6.0
jjwt-api:0.11.2-5.143e44951c52
jobConfigHistory:2.28.1
jquery3-api:3.6.0-1
jsch:<IP_ADDRESS>
junit:1.50
kube-agent-management:1.1.50
kubernetes:1.30.0
kubernetes-client-api:5.4.1
kubernetes-credentials:0.9.0
ldap:2.7
lockable-resources:2.11
mailer:1.34
mapdb-api:<IP_ADDRESS>
matrix-project:1.19
maven-plugin:3.12
metrics:<IP_ADDRESS>
momentjs:1.1.1
nectar-license:8.31
nectar-rbac:5.58
node-iterator-api:1.5.0
oauth-credentials:0.4
okhttp-api:3.14.9
operations-center-agent:2.289.0.3
operations-center-client:2.289.0.10
operations-center-cloud:2.289.0.2
operations-center-context:2.289.0.6
pipeline-build-step:2.13
pipeline-graph-analysis:1.11
pipeline-input-step:2.12
pipeline-milestone-step:1.3.2
pipeline-model-api:1.8.5
pipeline-model-definition:1.8.5
pipeline-model-extensions:1.8.5
pipeline-rest-api:2.19
pipeline-stage-step:2.5
pipeline-stage-tags-metadata:1.8.5
pipeline-stage-view:2.19
plain-credentials:1.7
plasticscm-plugin:3.6
plugin-util-api:2.3.0
popper-api:1.16.1-2
scm-api:2.6.4
script-security:1.77
sloccount:1.25
snakeyaml-api:1.27.0
ssh-credentials:1.19
sshd:3.0.3
structs:1.23
support-core:2.74
tics:2<IP_ADDRESS>705
timestamper:1.13
token-macro:2.15
trilead-api:1.0.13
unique-id:2.2.0
variant:1.4
warnings-ng:9.0.1
workflow-aggregator:2.5
workflow-api:2.46
workflow-basic-steps:2.23
workflow-cps:2.92
workflow-cps-checkpoint:2.10
workflow-cps-global-lib:2.19
workflow-durable-task-step:2.39
workflow-job:2.41
workflow-multibranch:2.24
workflow-scm-step:2.13
workflow-step-api:2.23
workflow-support:3.8

What Operating System are you using (both controller, and any agents involved in the problem)?

Linux controller, problem exists without agent.

Reproduction steps

Create 2 lockable resources with a shared label between them.
Create a Declarative pipeline script which attempts to lock a resource via label:
lock(label: 'shared_label', variable: 'LABEL_LOCKED') {
echo "locked: ${LABEL_LOCKED}
}

Results
Expected result:
One resource should become locked .
Actual result:
[Pipeline] End of Pipeline
org.jenkinsci.plugins.workflow.cps.CpsCompilationErrorsException: startup failed:
test_script.groovy: 27: Missing required parameter: "resource" @ line 27, column 15.
lock(label: 'shared_label', variable: 'LABEL_LOCKED') {
^

An update to this issue, a workaround is to put the lock() step inside a script {} block.
This will work:
stage("Functional lock by label") {
  steps {
    script {
      lock(label: 'shared_label', variable: 'LABEL_LOCKED', quantity: 1) {
        echo "Lock acquired: ${LABEL_LOCKED}"
      }
    }
  }
}

This will not:
stage("Bugged lock") {
  steps {
    lock(label: 'shared_label', variable: 'LABEL_LOCKED', quantity: 1) {
      echo "Lock acquired: ${LABEL_LOCKED}"
    }
  }
}

Thanks, solutions (PRs) are also welcome ;)
One more known workaround is to specify a resource: null parameter to lock()

@mark-reiche can you open the PR please.  I am interested for your solution.  We have currently documented the workaround proposed by @jimklimov .
When there are no solutions I will propose to close this issue,  because a applicable workaround is documented.
Thx for contributing

See also #441


Governance. Timeline for ongoing referenda is empty if only on-chain data is available.

Description
Timeline for ongoing referenda is empty:

When its should shown at least submitted and deciding data, which is available on-chain in referenda.referendumInfoFor(id: u32):
{
  Ongoing: {
    track: 10
    origin: {
      Origins: StakingAdmin
    }
    proposal: {
      Lookup: {
        hash_: 0x002c390837cb103126cccd213f61c1a5fa16061336e59bf36b326da58d690235
        len: 36
      }
    }
    enactment: {
      After: 10
    }
    submitted: 422,453
    submissionDeposit: {
      who: 5EpsavEfPSZC8X2E4zHdJdepzpzfSccqNP5RUVyAU9Hyi3z4
      amount: 30,000,000,000
    }
    decisionDeposit: {
      who: 5EpsavEfPSZC8X2E4zHdJdepzpzfSccqNP5RUVyAU9Hyi3z4
      amount: 5,000,000,000,000,000
    }
    deciding: {
      since: 422,533
      confirming: null
    }
    tally: {
      ayes: 101,000,000,000,000
      nays: 0
      support: 101,000,000,000,000
    }
    inQueue: false
    alarm: [
      422,733
      [
        422,733
        0
      ]
    ]
  }
}

Steps to Reproduce

Create referenda
Go to referenda details in Spektr

Expected Behavior
Timeline is shown from on-chain
Actual Behavior
Empty timeline
Environment
https://github.com/novasamatech/nova-spektr/commit/64f12ff7746cb19024e2df0b6009cec5e6e2cf17

Status verification: ✅


When I open :lua require('vgit').buffer_history_preview() it only shows the top of the change, and there is no way to see or navigate in the buffer with changes.

Hey the example (requires you to be on the v0.2.0) below shows you how to set the keys C-k and C-j to enable hunk navigation on any VGit previews.
require('vgit').setup({
  keymaps = {
    ['n <C-k>'] = 'hunk_up',
    ['n <C-j>'] = 'hunk_down',
  },
})

This should hopefully allow you to navigate through the diffs easily. The exact commands can also be used on regular buffers that contain hunk signs.


Mailarchive::threads() implementation

Message https://mailarchive.ietf.org/arch/msg/ietf-announce/96y6OVChtga3jzPs9YdEsS5g6Yc/ was sent to ietf-announce, but has many replies on admin-discuss. If we search for threads on admin-discuss and limit the search to that list, we'll find two threads each starting from a direct reply to this. If we don't limit the search to the list, we'll find one thread starting from the original message on ietf-announce.
Which do we want?

I think I'd lean towards giving results limited to threads that don't have parents within the same list (so in this example, returning the two threads separately).
There should perhaps be another threads() method further up (maybe on MailArchive?) that finds threads across multiple lists?

Commit 3e602bb addresses this in a different way. Does it make sense?
@lumisota @mladenk42


feat: add links to pdfs

Forestry DMP can reference to other DMPs that way:
"DMPReferences": [
  {
    "Id": "550e8400-e29b-41d4-a716-446655440000",
    "UserDefinedId": "DMP-2024-001",
  }

These changes enable adding optional links to JSON and PDF documents:
"DMPReferences": [
  {
     "Id": "550e8400-e29b-41d4-a716-446655440000",
     "UserDefinedId": "DMP-2024-001",
     "jsonURL": "https://example.com/files/source_DMP.json",
     "pdfURL": "https://example.com/files/source_DMP.pdf"
  },

In the PDF rendering, links from UserDefinedId point to PDF, from Id to JSON.

In the PDF rendering, links from UserDefinedId point to PDF, from Id to JSON.

@stiebitzhofer can you please elaborate on what this means and the implications for rendering?


Patch upgrade-go-version prow job

Description of changes:
Fixing source file path issues in github.go
Subsequently also testing build-prow-images
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/hold

/unhold


fix: set --force default value as true for helm rollback

One solution for issue #8465: make the default behaviour to replace
the resouces rather than make a patch, keep the backend compatibility.
Another solution, see PR: #8473, #8474
fix: #8465
Signed-off-by: Liu Ming<EMAIL_ADDRESS>
What this PR does / why we need it:
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

As described in https://github.com/helm/helm/issues/8465#issuecomment-660161463, --force should be set to default as false. Therefore, we are not going to consider PRs that change the default behaviour.


[Bug]:  The params does not get populated into the fields when added via API field

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When the API is been added to the API pane and then we add "?" to the API and add respective add to the same it is observed that the Params details are not inserted
Steps To Reproduce

Add a API into API field
Add an "?" to the api
Insert an Key and value to the API
and observe

It is observed that the params are not added into the fields when data is added into from the API field
Environment
Release
Version
Self-Hosted

Issue is resolved hence closing the issue


stop string from parsing any further options

This PR added -- to stop string from parsing any option-like flag in the target.
I encountered the following error:
string join0: Unknown option “-sL”

~/.config/fish/functions/mm.fish (line 139):
                string join0 $targets | eval (__mm_fzf_command $filename 0 $make_command $initial_query) | read -lz result  # print targets as a list, pipe them to fzf, put the chosen command in $result
                ^
in function 'mm'

which was because in $targets, there are some option-like string (i.e. in the MakeFile, there are the -sL flag that mm.fish is complaining about)
The -- will stops string from parsing any possible options within the string.

Nice catch! Thank you @soraxas!


DMRG outputlevel

Enhancement to the dmrg functions which replaces the quiet::Bool keyword with outputlevel::Int. Setting the output level to 0 means no output; 1 means only per-sweep output; 2 shows every step. The DMRGObserver type also makes limited use of the outputlevel, which gets passed through the keyword args. Addresses issue #267
This PR includes a few other small tweaks and fixes:

fix output in README doctest regarding showing noise level in sweeps
change energy tolerance arg of DMRGObserver constructor to be a keyword arg

Looks good to me! You can merge when you are ready.


Manage access to users

As a system administrator, I want to grant and remove access to users, so I can manage user accounts and their permissions.
[Story Points: 4]
[Priority: Medium]
[Risk: High]
Tasks:
Demo steps:
Given I'm a system administrator, and I'm on the User's page
When I select select a user and click on Add User or Remove User
Then a confirmation message is displayed, and the system will add or remove the user

This issue is a duplicate of #119


Bug: svgIcon with button toggle is not aligning middle horizontally with text in Material 7

Bug:
  <mat-button-toggle-group #group="matButtonToggleGroup">
              <mat-button-toggle routerLink="/cl-appointments" value="appointments">
                    <mat-icon>event</mat-icon>
                    Appointments
                </mat-button-toggle>
                <mat-button-toggle routerLink="/tasks" value="tasks">
                    <mat-icon svgIcon="c_tasks"></mat-icon>
                    Tasks
                </mat-button-toggle>

svgIcon with button toggle is not aligning middle horizontally with text in Material 7
What is the expected behavior?
Both material icon and custom svg icon should be aligning middle horizontally with text in the button
What is the current behavior?
In NG MD 5 and 6, both material icon and custom svg icon are aligning middle horizontally with text in the button.
In NG MD 7 (amethyst ammonite), the svgIcon is aligning to the bottom of the button, thus appearing lower than material icon of the other buttons in same row.
What are the steps to reproduce?
Use svgIcon in a button toggle.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular Material 7 (amethyst ammonite), with predefined theme deeppurple-amber.css.
Is there anything else we should know?
Apparently this is due to that in NG MD 7 the default height of button is taller, thus a defect in the styling of svgIcon has become a bug in NG MD 7, while in narrower button, the svgIcon is squeezed into middle.
Currently the workaround is to introduce class material-icons in my app codes, like:
  <mat-icon class="material-icons" svgIcon="c_tasks"></mat-icon>

While this is looking good now, so to enjoy other improvements of NG MD 7, however, I am not sure if using this class is semantically correct. So it is better the NG MD team provides a fix in next release.

md team had fixed the problem months ago. However, I got no notification, probably because the Github was having problem when I had submitted the case. Now when searching search by my name zijianhuang, the issues listed does not include this issue. But when searching keywords svgicon buttion, this issue is listed. Apparently the Github indexing is having some problem caused by the incident a few months ago.

And after I updated this issue, searching zijianhuang can locate this issue. Apparently an update just caused an indexing.


Components with post form support

I've just started using mvc6 beta3 and don't see a way to post form data to a component? Tried searching on internet but didn't find anything at all. Any help will be appreciated.
Cheers,

From where are you trying to post data? And posting it to where?

lets assume it is a login ViewComponent. So I can display it using ViewComponent but when the user click submit button, I should submit it to the ViewComponent so that if ModelState is invalid then I display those errors. I don't see any way I can do it using ViewComponent. I think I've to create a proper controller for this functionality.
My initial understanding about ViewComponent is, it is a reusable component which can be displayed on different pages but is it just for HTTP GET type of things ?

A ViewComponent is not a public endpoint - it's exactly what you said "a reusable component which can be displayed on different pages". It's not reachable from via any URL or route, it's only part of the pages where you include
If you used a ViewComponent for a login form, then have it post to your login controller and redirect to a logic page that can display errors. You might want a bespoke action anyway for a failed login to include things like a password reset.

and if validation fails, redirect to a login page that can display errors.

This is my issue. If I redirect then I will lost the ModelState information which I needed on my ViewComponent (or any other page) to display ValidationMessage(s).
Secondly I am not creating a login view component, I used it as an example because it is a common control which also post forms data to server.

Some ideas on how you can preserve the validation messages:

Preserve the data in the query string
Preserve the data using TempData (coming soon)

Or just post directly to the target controller that can do the validation.


Doesn't build

Come on people.  I open the solution file, and a hundred or more files in the "gen" folder aren't found.
I try to build anyways, only to discover that that the projects are are deselected in the Configuration Manager.

Can we please release code that actually compiles?
Restoring NuGet packages...
To prevent NuGet from restoring packages during build, open the Visual Studio Options dialog, click on the Package Manager node and uncheck 'Allow NuGet to download missing packages during build.'
Unable to resolve Microsoft.WSMan.Management (>= 1.0.0) for .NETFramework,Version=v4.5.1.
NuGet Package restore failed for project Microsoft.PowerShell.Commands.Management for 'Microsoft.WSMan.Management (>= 1.0.0)'.
1>------ Build started: Project: System.Management.Automation, Configuration: CORECLR Any CPU ------
2>------ Build started: Project: PSReadLine, Configuration: CORECLR Any CPU ------
2>C:\Program Files (x86)\MSBuild\Microsoft\NuGet\Microsoft.NuGet.targets(140,5): error : Your project is not referencing the ".NETFramework,Version=v4.0,Profile=Client" framework. Add a reference to ".NETFramework,Version=v4.0,Profile=Client" in the "frameworks" section of your project.json, and then re-run NuGet restore.
1>C:\Program Files (x86)\MSBuild\Microsoft\NuGet\Microsoft.NuGet.targets(140,5): error : Your project is not referencing the ".NETFramework,Version=v4.5" framework. Add a reference to ".NETFramework,Version=v4.5" in the "frameworks" section of your project.json, and then re-run NuGet restore.
3>------ Build started: Project: Microsoft.PowerShell.ConsoleHost, Configuration: CORECLR Any CPU ------
4>------ Build started: Project: Microsoft.PowerShell.Commands.Management, Configuration: CORECLR Any CPU ------
5>------ Build started: Project: Microsoft.PowerShell.Commands.Utility, Configuration: CORECLR Any CPU ------
4>C:\Program Files (x86)\MSBuild\Microsoft\NuGet\Microsoft.NuGet.targets(140,5): error : Your project is not referencing the ".NETFramework,Version=v4.0" framework. Add a reference to ".NETFramework,Version=v4.0" in the "frameworks" section of your project.json, and then re-run NuGet restore.
3>C:\Program Files (x86)\MSBuild\Microsoft\NuGet\Microsoft.NuGet.targets(140,5): error : Your project is not referencing the ".NETFramework,Version=v4.5" framework. Add a reference to ".NETFramework,Version=v4.5" in the "frameworks" section of your project.json, and then re-run NuGet restore.
6>------ Build started: Project: powershell, Configuration: CORECLR x86 ------
5>C:\Program Files (x86)\MSBuild\Microsoft\NuGet\Microsoft.NuGet.targets(140,5): error : Your project is not referencing the ".NETFramework,Version=v4.0" framework. Add a reference to ".NETFramework,Version=v4.0" in the "frameworks" section of your project.json, and then re-run NuGet restore.
6>CSC : error CS0006: Metadata file 'D:\PowerShell\src\System.Management.Automation\bin\CORECLR\ClassLibrary.dll' could not be found
6>CSC : error CS0006: Metadata file 'D:\PowerShell\src\Microsoft.PowerShell.ConsoleHost\bin\CORECLR\Microsoft.PowerShell.ConsoleHost.dll' could not be found
========== Build: 0 succeeded, 6 failed, 0 up-to-date, 0 skipped ==========

The solution exists to make editing code in the project easier - it is not set up to build anything.
The instructions for building are found here - right on our front page:
https://github.com/powershell/powershell#building-the-repository

Also going to throw in that while I prefer Emacs when I work on Linux, VSCode works fairly well on Windows with this project.

Indeed, I did the git clone with the --recurse option, opened the powershell.sln file with VS2015, and got the above errors.  Did I miss some important step?

I would recommend going over step by step with these instructions: https://github.com/PowerShell/PowerShell/blob/master/docs/building/windows-core.md.
Maybe one of the more Windows oriented programmers can chime in, but the sln file is not setup to properly build in VS2015; it only exists for intellisense I believe. I recommend VSCode as an IDE on Windows.

We do not recommend building the Poweshell solution from Visual Studio.
Ah ha.  OK, well, I'm not much of command line person, I'll poke at the SLN file and see if I can get at working.

The recommendation you're referring to is more about opening the project.json file as a solution, which also does not work correctly, but is a different issue than the provided sln not building.
If you want to modify the solution so that it builds (and I'm sure some folks would appreciate it), you'll effectively reproduce our command line build instructions in the solution as a custom build step.

OK, well, I'm not much of command line person

That sounds a little funny considering PowerShell is a command line / shell.  ;-)

I encountered a similar problem, I download the source code from an opensource called Quatz to run some official examples.
I can't build it successfully with VS2015, but it was successful in VS2013.
The error information is: "Your project is not referencing the ".NETFramework,Version=v4.0" framework. Add a reference to ".NETFramework,Version=v4.0" in the "frameworks" section of your project.json, and then re-run NuGet restore.	Quartz.2010"
I didn't find the solution from the internet.


syslogd integration?

Nobody is asking about this, so I'll close.
If anyone wants to implement or share their implementation, I'll be happy to look and merge if possible.


Why users can't directly use C++ in the IDE?

Why do users have to use an External IDE in order to use C++
If Godot's IDE supports C#, why can't it support C++ as well?

Seriously, you could gather a bit more information before asking these things. Godot's built-in editor is only for GDScript. C# is meant to be used with an external editor, just like C++.
There are great IDEs around for editing C++ or C# , which are complex languages and require large teams to develop tools for.

Yeah and I am trying to suggest to allow Godot's built in IDE to support
C++ and C#
On Fri, Dec 22, 2017 at 12:04 AM, Juan Linietsky<EMAIL_ADDRESS>wrote:

Seriously, you could gather a bit more information before asking these
things. Godot's built-in editor is only for GDScript. C# is meant to be
used with an external editor, just like C++.
There are great IDEs around for editing C++ or C# , which are complex
languages and require large teams to develop tools for.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14898#issuecomment-353345510,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BqHap6bDmUw2sfq0jZxSbi3hJvfWks5tCldFgaJpZM4RJyaW
.

Why? It's a huge and enormous amount of work to make a C++ IDE, you need a large team for this and it would never be better than existing IDEs. There is no chance for this to ever happen..

Well, it should be enough to make a c++ PluginScript to enable c++ editing in the script editor.

And would there be such a plugin that users can install as this would make
it more convenient?
On Fri, Dec 22, 2017 at 2:31 AM, Andreas Haas<EMAIL_ADDRESS>wrote:

Well, it should be enough to make a c++ PluginScript to enable c++
editing in the script editor.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14898#issuecomment-353379789,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Br_P9EzrrcT_61fVaKPlkPndz3p1ks5tCnm5gaJpZM4RJyaW
.

And would there be such a plugin that users can install as this would make it more convenient?

It would only provide syntax highlighting and not much else, so you would still be better off using a C++ IDE.

Sure for code editing, using a dedicated c++ ide would still be prefered.
But a pluginscript would provide a bit more than just highlighting, for example handling compilation, adding cpp files, not needing to fiddle around with GDNativeLibrary's/NativeScripts, etc...
So if someone were to make such a plugin, I'd be super grateful :)

Why not make a pluginscript that makes the Godot's IDE very well supported
for C++, as Andreas has suggested?
On Fri, Dec 22, 2017 at 6:52 PM, Andreas Haas<EMAIL_ADDRESS>wrote:

Sure for code editing, using a dedicated c++ ide would still be prefered.
But a pluginscript would provide a bit more than just highlighting, for
example handling compilation, adding cpp files, not needing to fiddle
around with GDNativeLibrary's/NativeScripts, etc...
So if someone were to make such a plugin, I'd be super grateful :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14898#issuecomment-353542953,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Brr7ZkN9xs7nHgeKOGJ23cLlmH_Tks5tC1_XgaJpZM4RJyaW
.

Why not...

It takes time to do stuff, it's not a matter of flipping a switch. Sure, some contributor can take this and decide to make something, but we can't force people to do that. And it's not a priority, so even if it goes to the official roadmap, it might take a while to be available.
As @reduz usually says (quoting Gandhi): "Be the change you want to see in the world."


Immutable Mixin

Codecov Report

Merging #13 (d504b8f) into master (ee4936f) will increase coverage by 1.17%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   89.92%   91.09%   +1.17%
==========================================
  Files           6        6
  Lines         645      719      +74
==========================================
+ Hits          580      655      +75
+ Misses         65       64       -1

Impacted Files
Coverage Δ

treeo/api.py
90.99% <88.46%> (+0.58%)
:arrow_up:

treeo/tree.py
94.84% <98.48%> (+1.12%)
:arrow_up:

treeo/__init__.py
100.00% <100.00%> (ø)

treeo/mixins.py
85.36% <100.00%> (+5.36%)
:arrow_up:

treeo/utils.py
91.66% <100.00%> (+0.36%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Optimize away distinct aggregate operations - eliminate_agg_distinct

rerun tests

This is superseded by https://github.com/dask-contrib/dask-sql/pull/748