HDDS-1224. Restructure code to validate the response from server in the Read path

.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
33
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
30
Maven dependency ordering for branch

+1
mvninstall
475
trunk passed

+1
compile
259
trunk passed

+1
checkstyle
59
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
917
branch has no errors when building and testing our client artifacts.

+1
javadoc
143
trunk passed

0
spotbugs
307
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
555
trunk passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

+1
mvninstall
472
the patch passed

+1
compile
252
the patch passed

+1
javac
252
the patch passed

-0
checkstyle
34
hadoop-hdds: The patch generated 41 new + 0 unchanged - 0 fixed = 41 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
753
patch has no errors when building and testing our client artifacts.

+1
javadoc
153
the patch passed

-1
findbugs
250
hadoop-hdds generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1
unit
172
hadoop-hdds in the patch failed.

-1
unit
2339
hadoop-ozone in the patch failed.

+1
asflicense
51
The patch does not generate ASF License warnings.

8345

Reason
Tests

FindBugs
module:hadoop-hdds

Inconsistent synchronization of org.apache.hadoop.hdds.scm.storage.BlockInputStream.chunkIndex; locked 96% of time  Unsynchronized access at BlockInputStream.java:96% of time  Unsynchronized access at BlockInputStream.java:[line 303]

Failed junit tests
hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey

hadoop.ozone.client.rpc.TestReadRetries

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestBlockOutputStream

hadoop.ozone.container.TestContainerReplication

hadoop.ozone.TestContainerOperations

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestCommitWatcher

hadoop.ozone.scm.TestXceiverClientManager

hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.TestStorageContainerManager

hadoop.ozone.scm.TestContainerSmallFile

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/806

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 58cc9b06f2c2 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 90add05

Default Java
1.8.0_191

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/artifact/out/diff-checkstyle-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/artifact/out/new-findbugs-hadoop-hdds.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/testReport/

Max. process+thread count
4561 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-hdds/client U: hadoop-hdds

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
68
Maven dependency ordering for branch

+1
mvninstall
428
trunk passed

+1
compile
202
trunk passed

+1
checkstyle
53
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
831
branch has no errors when building and testing our client artifacts.

+1
javadoc
129
trunk passed

0
spotbugs
234
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
413
trunk passed

_ Patch Compile Tests _

0
mvndep
26
Maven dependency ordering for patch

+1
mvninstall
396
the patch passed

+1
compile
212
the patch passed

+1
javac
212
the patch passed

-0
checkstyle
30
hadoop-hdds: The patch generated 39 new + 0 unchanged - 0 fixed = 39 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
643
patch has no errors when building and testing our client artifacts.

+1
javadoc
113
the patch passed

-1
findbugs
195
hadoop-hdds generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1
unit
153
hadoop-hdds in the patch failed.

-1
unit
1266
hadoop-ozone in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

7203

Reason
Tests

FindBugs
module:hadoop-hdds

Inconsistent synchronization of org.apache.hadoop.hdds.scm.storage.BlockInputStream.chunkIndex; locked 91% of time  Unsynchronized access at BlockInputStream.java:91% of time  Unsynchronized access at BlockInputStream.java:[line 366]

Failed junit tests
hadoop.ozone.TestContainerOperations

hadoop.ozone.client.rpc.TestReadRetries

hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey

hadoop.ozone.scm.TestContainerSmallFile

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/806

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 9641a001c81b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c15b3bc

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/artifact/out/diff-checkstyle-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/artifact/out/new-findbugs-hadoop-hdds.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/testReport/

Max. process+thread count
5402 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
32
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
70
Maven dependency ordering for branch

+1
mvninstall
535
trunk passed

+1
compile
273
trunk passed

+1
checkstyle
87
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
886
branch has no errors when building and testing our client artifacts.

+1
javadoc
164
trunk passed

0
spotbugs
290
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
483
trunk passed

-0
patch
335
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

0
mvndep
27
Maven dependency ordering for patch

+1
mvninstall
470
the patch passed

+1
compile
296
the patch passed

+1
javac
296
the patch passed

-0
checkstyle
40
hadoop-hdds: The patch generated 21 new + 0 unchanged - 0 fixed = 21 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
647
patch has no errors when building and testing our client artifacts.

-1
javadoc
75
hadoop-hdds generated 5 new + 14 unchanged - 0 fixed = 19 total (was 14)

+1
findbugs
481
the patch passed

_ Other Tests _

+1
unit
237
hadoop-hdds in the patch passed.

-1
unit
1582
hadoop-ozone in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

6690

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.ozShell.TestOzoneShell

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.TestMiniOzoneCluster

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/806

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux d554bfa28f11 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / abf76ac

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/artifact/out/diff-checkstyle-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/artifact/out/diff-javadoc-javadoc-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/testReport/

Max. process+thread count
5355 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thank you @bshashikant.
LGTM. There are some checkstyle errors. Added the ozone label so that CI can run. +1 pending CI and checkstyle fixes.

Thaks @hanishakoneru . The updated patch addresses checkstyle and unit test failures.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
25
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
61
Maven dependency ordering for branch

+1
mvninstall
524
trunk passed

+1
compile
267
trunk passed

+1
checkstyle
75
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
940
branch has no errors when building and testing our client artifacts.

+1
javadoc
150
trunk passed

0
spotbugs
297
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
485
trunk passed

-0
patch
351
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

0
mvndep
29
Maven dependency ordering for patch

+1
mvninstall
470
the patch passed

+1
compile
269
the patch passed

+1
javac
269
the patch passed

-0
checkstyle
41
hadoop-hdds: The patch generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
736
patch has no errors when building and testing our client artifacts.

+1
javadoc
149
the patch passed

+1
findbugs
520
the patch passed

_ Other Tests _

-1
unit
175
hadoop-hdds in the patch failed.

-1
unit
1231
hadoop-ozone in the patch failed.

+1
asflicense
49
The patch does not generate ASF License warnings.

6429

Reason
Tests

Failed junit tests
hadoop.ozone.container.ozoneimpl.TestOzoneContainer

hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.hdds.scm.pipeline.TestSCMPipelineManager

hadoop.ozone.client.rpc.TestReadRetries

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/806

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 8ca5cf2a0c4e 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 52128e3

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/artifact/out/diff-checkstyle-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/testReport/

Max. process+thread count
5256 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
34
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
66
Maven dependency ordering for branch

+1
mvninstall
585
trunk passed

+1
compile
271
trunk passed

+1
checkstyle
69
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
843
branch has no errors when building and testing our client artifacts.

+1
javadoc
168
trunk passed

0
spotbugs
358
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
569
trunk passed

-0
patch
399
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

0
mvndep
28
Maven dependency ordering for patch

+1
mvninstall
512
the patch passed

+1
compile
282
the patch passed

+1
javac
282
the patch passed

-0
checkstyle
36
hadoop-hdds: The patch generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
645
patch has no errors when building and testing our client artifacts.

+1
javadoc
174
the patch passed

+1
findbugs
590
the patch passed

_ Other Tests _

+1
unit
230
hadoop-hdds in the patch passed.

-1
unit
1156
hadoop-ozone in the patch failed.

+1
asflicense
46
The patch does not generate ASF License warnings.

6521

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestReadRetries

hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestBlockOutputStream

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/806

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 827c0cfcb6d8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / bd2590d

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/5/artifact/out/diff-checkstyle-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/5/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/5/testReport/

Max. process+thread count
4204 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/5/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@bshashikant the test failure in TestReadRetries is related to this PR. And there are some checkstyle issues also.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

0
mvndep
24
Maven dependency ordering for branch

+1
mvninstall
524
trunk passed

+1
compile
304
trunk passed

+1
checkstyle
92
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
896
branch has no errors when building and testing our client artifacts.

+1
javadoc
181
trunk passed

0
spotbugs
325
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
516
trunk passed

-0
patch
395
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

0
mvndep
36
Maven dependency ordering for patch

+1
mvninstall
484
the patch passed

+1
compile
287
the patch passed

+1
javac
287
the patch passed

-0
checkstyle
48
hadoop-hdds: The patch generated 14 new + 0 unchanged - 0 fixed = 14 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
702
patch has no errors when building and testing our client artifacts.

-1
javadoc
71
hadoop-hdds generated 5 new + 14 unchanged - 0 fixed = 19 total (was 14)

+1
findbugs
537
the patch passed

_ Other Tests _

+1
unit
230
hadoop-hdds in the patch passed.

-1
unit
1032
hadoop-ozone in the patch failed.

+1
asflicense
69
The patch does not generate ASF License warnings.

6377

Reason
Tests

Failed junit tests
hadoop.ozone.scm.node.TestQueryNode

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/806

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 598d581e8274 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 7991159

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/artifact/out/diff-checkstyle-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/artifact/out/diff-javadoc-javadoc-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/testReport/

Max. process+thread count
4504 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
68
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

0
mvndep
187
Maven dependency ordering for branch

+1
mvninstall
499
trunk passed

+1
compile
273
trunk passed

+1
checkstyle
79
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
907
branch has no errors when building and testing our client artifacts.

+1
javadoc
168
trunk passed

0
spotbugs
351
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
539
trunk passed

-0
patch
418
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

0
mvndep
34
Maven dependency ordering for patch

+1
mvninstall
572
the patch passed

+1
compile
302
the patch passed

+1
javac
302
the patch passed

+1
checkstyle
89
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
746
patch has no errors when building and testing our client artifacts.

+1
javadoc
195
the patch passed

+1
findbugs
588
the patch passed

_ Other Tests _

-1
unit
202
hadoop-hdds in the patch failed.

-1
unit
1544
hadoop-ozone in the patch failed.

+1
asflicense
47
The patch does not generate ASF License warnings.

7248

Reason
Tests

Failed junit tests
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerCommandHandler

hadoop.ozone.client.rpc.TestBCSID

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem
Report/Notes

Docker
Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/806

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 400617ecbd07 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 827a847

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/7/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/7/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/7/testReport/

Max. process+thread count
4363 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-806/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thank you @bshashikant. +1. I will merge this PR.


Make configurable warp size compatible with PyTorch's inductor

Remove warp size argument from python function.
The additional warp_size argument breaks the compatibility with TOT, but after examination this argument is not necessary, because this value can be retrieved from hipStream_t.
Fixes #255

UT pytest python/test/unit/language/test_core_amd.py --verbose passed on Navi 32:
4580 passed, 63 skipped, 143 warnings in 3733.95s (1:02:13)

and MI200
4532 passed, 58 skipped, 143 warnings in 1222.34s (0:20:22)

Hey @xinyazhang cc: @zhanglx13 thank for taking a look at this
I tried to fix but run into some issues
  File "/opt/conda/envs/py_3.9/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result
    raise self._exception
torch._dynamo.exc.BackendCompilerFailed: backend='compile_fx_wrapper' raised:
ImportError: /tmp/torchinductor_root/triton/0/a2d6dc021d54927d03e6ebe938b4c17a/triton_.so: undefined symbol: hipStreamGetDevice

I saw that you mentioned this issue on https://github.com/ROCmSoftwarePlatform/triton/issues/255
Please be aware this solution won't work with ROCM < 5.6, due to requirement of hipStreamGetDevice
At the minute upstream pytorch is still 5.4 and moving onto 5.5 and may take awhile before getting to 5.6, is there a potential workaround here?

So far we've not needed anything on the python side that is conditional on a specific ROCM version. This fix is clean and good so it's unfortunate it won't help Pytorch at the moment. We may have to create a ROCM configuration state, which includes the active version, so we can switch against it.
Then we can:
if rocm56
do the hipStreamGetDevice
else
hard-code the value

@jataylo The updated PR should have fixed the problem. hipGetStreamDeviceId is relatively old (> 2 yrs) and should have been well supported in deployed systems.

test_cuda_broadcast1_broadcast1 verified locally
(py_3.9) root@6b9547c02da9:/var/lib/jenkins/pytorch# pytest test/inductor/test_torchinductor.py -k "test_cuda_broadcast1_broadcast1" --verbose
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0 -- /opt/conda/envs/py_3.9/bin/python
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/var/lib/jenkins/pytorch/.hypothesis/examples')
rootdir: /var/lib/jenkins/pytorch
configfile: pytest.ini
plugins: shard-0.1.2, xdoctest-1.1.0, cpp-2.3.0, flakefinder-1.1.0, hypothesis-5.35.1, rerunfailures-11.1.2, xdist-3.2.1
collected 917 items / 916 deselected / 1 selected
Running 1 items in this shard: test/inductor/test_torchinductor.py::SweepInputsCudaTest::test_cuda_broadcast1_broadcast1

test/inductor/test_torchinductor.py::SweepInputsCudaTest::test_cuda_broadcast1_broadcast1 PASSED [2.9655s]                                                                                [100%]

===================================================================================================== 1 passed, 916 deselected in 8.88s ======================================================================================================

So I think technically what hipGetStreamDeviceId() returns is different than what hipStreamGetDevice() returns.
I think the difference is that the deviceId may not be consistent across processes, which perhaps is ok in this case because we are just using it to query the warpsize of the device in question.

@xinyazhang I see this has passed the unit tests and LIT tests at least - have you done any other testing with this PR?

@jayfurmanek

have you done any other testing with this PR?
Not yet. I only verified it really fixed the UT in pytorch test/inductor

I realize this is already merged. But do we foresee any issue with _launch making a hipGetDeviceProperties call every time?  Feels like we're being a bit redundant when a warp size should be something we figure out ahead of time?
https://github.com/ROCmSoftwarePlatform/triton/blob/triton-mlir/python/triton/runtime/backends/hip.c#L29
For instance is already in place and called to get our device information.
I doubt we'd want to care about the exact current device we're compiling against, as I doubt PyTorch even has the capability of keeping kernels unique when scheduling them (i.e. we lower and build a single compiled kernel, and schedule across multiple gpus.)
I'm not sure if this is something we can use and tie it into the CompiledKernel class?

Feels like we're being a bit redundant when a warp size should be something we figure out ahead of time?

I'm afraid we can't make such assumptions, because it is possible for users to install MI200 and Navi 31 on the same system at the same time. This situation can be rare but is possible (Navi for video output and MI for compute, I have seen similar NVIDIA configurations in the lab next to me). In this case we can only determine the warp size according to the stream.
Sure we haven't verified if the Navi + MI combination works on current triton, but at least we can make the feature easier to implement by not assuming there is a unique, predetermined warp size in the system.

I'm not sure if this is something we can use and tie it into the CompiledKernel class?

It's already there: https://github.com/ROCmSoftwarePlatform/triton/blob/6ee06a129529332d31fba39ff373251bd8f6b2a0/python/triton/compiler/compiler.py#L541
The problem is how can we pass this Python property to the C code. I added an warp size argument in the previous PR but it breaks the compatibility with pytorch inductor.

Okay, my larger issue is still performance.  I would like to see how this affects even our current benchmark runs.
@jataylo  Lets test this out, and then try it out hard coding the warp size.  If it's negligible then I'm okay leaving it.  If we notice a measurable drop in perf, I'd push for an alternative solution.


do it support user group??

Hi there! The roles are analogous to groups. If you mean, does this support something like unix groups on the host system, then no, you'll have to use something more sophisticated like LDAP.

ok  thank u  ^_^


Save best checkpoints

Hi there,
I have started finetuning pre-trained mockingjay on downstream mosei. However I only see "states-somenumber.ckpt" in my results folder. Wanted to know if run_downstream.py supports saving best models with checkpoints.
Currently I run:
python run_downstream.py -m train -u mockingjay --upstream_trainable --downstream mosei --expname first
Thank You

Hi,
Yes, you can pass a list of filenames in log_records, and the runner will save those filenames into the expdir for you.
Whether to pass those filenames is decided by you. if nothing is returned, then only those states-somenumber.ckpt are saved.
Sincerely,
Leo

Hi Andi,
Thank you for your response. Could you give me a lead to log_records where I need to add this?
Thank You

Hi,
You can refer to the implementation of emotion recognition

Hi,
You can refer to the implementation of phoneme classification


Change of Pricing Section on Frontpage

Please undo this pull-request and apply the same changes to this repository instead:
https://github.com/OO-developers/eBogholderen-website/commits/master since we are talking about the eBogholderen website in this pull-request.


Thread pooling without queuing?

I notice that Pool#process seems to queue up each task as its run for execution later. We have a script that has to process around 3 million records which operate at around 100 - 500/s. If we just use pooling it seems like it will create a task object for every one of these jobs that we pass in, a long with a copy of the method attributes.
Is there some way to just block on Pool#process hitting it's pool size limit, rather than queuing them up internally for execution later?
Anyway, just thought I would check if this is already possible with the current library before I go off and implement something (buggy) myself.
Thanks for the great library!

I'd just like to mention that I've added a $100 bounty to this project on BountySouce.
https://www.bountysource.com/issues/5831191-tasks-to-finish-4-2-support

Would it be acceptable to add an optional parameter in order to make todo aSizedQueue? It automatically blocks when it is filled.

This works now on 0.2.0.
Calling #wait on the pool will return self when there are idle workers, so you can just pool.wait.process ....
#wait can be called with :idle or :done, :idle is the default. :done will wait for all the tasks to end.

Thanks for this. So just to confirm.
#wait(:idle) will wait for any idle worker to become available in the pool?
So basically to prevent queueing up jobs you could just run something like:
big_list_of_jobs.each do |job|
  pool.wait.process { job.long_running_method }
end

Sorry, by the way, I posted the wrong bounty. The actual bounty for this issue is https://www.bountysource.com/issues/5461843-thread-pooling-without-queuing

@waynerobinson yes, that's exactly how it should work, if it doesn't work do reopen this issue.


Bounding Box and Solvers don't work well together

Describe the bug
In a scene with two objects, one with the BoundingBox and the other with a Solver (HandConstraint type), only one behaviour works at an instant. When rotating or scaling, solver stops. And the cursors are not reset as well. After rotating, then scaling, the cursor is messed up.

To reproduce
Steps to reproduce the behavior:

In an empty scene, add a gameObject (obj1) with BoundingBox component
Add another gameObject (obj2) with a solver script (preferably a HandConstraint type)
Now, start the scene and you should see obj2 following your hand. As soon as you try to scale or rotate the obj1 using the bounding box handles, the tag along solver of obj2 stops

Expected behavior
All behaviours work while rotating or scaling the bounding box
Your setup

Unity Version 2019.3.7
MRTK v2.4 and v2.3

Target platform

All

Hi there! Thanks for reporting this issue. Is this issue also reproducible with the BoundsControl component? We are intending on phasing out BoundingBox in favor of BoundsControl, so it would be valuable to know if the issue persists on both components.

@Zee2 I could reproduce the same with BoundsControl as well. Same exact issue.

Thank you. I've brought this up with one of our team members who has been working on BoundsControl, we will investigate this.

@Zee2 @thalbern I was looking into the issue and find the IsValidController function is the reason why they don't work together. However, based on the comments here it seems that it was a deliberate choice rather than a bug. Please let me know what are your thoughts on this.

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Is it available for on prem tfs 2017?

documentation state its applicable for "VSTS | TFS 2018 | TFS 2017 | TFS 2015 | TFS 2013" I have TFS 2017  with Update 3. when I hit my TFS base URL post fixed with _admin/_users or _users is gives 404/Not found. Is it only available for VSTS?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 361c08ef-48be-de59-d223-595cadc65a7b
Version Independent ID: 4bab93d0-8ee5-5e18-a217-c5f6a3eea441
Content: Export access level audit log - VSTS & TFS
Content Source: docs/organizations/security/export-users-audit-log.md
Product: devops
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@syedhassanabbas - Thank you for your inquiry. Please use the version selector in the upper left corner of the page to see the content that addresses your TFS version. The Users tab isn't a supported feature for TFS.

Thanks got it, it’s probebly not that intuitive.


Option to import json postman exported collections

Tell us about the task you want to perform and are unable to do so because the feature is not available
As title says that option is REALLLLY NEEDED
Any other feedback you would like to provide regarding the site
good ui and nice ram usage; my beloved flutter.

Thank you for raising the issue @ahmedtohamy1 and for your feedback.
Closing it as it is a duplicate of an already open issue that we are working on.
https://github.com/foss42/apidash/issues/52


[Bug]: pdf parse ： memory leak ！

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

RAGFlow workspace code commit ID
26d3480e
RAGFlow image version
26d3480e
Other environment information
ubuntu 22.04

Actual behavior
the matter of memory leak occurs when  pdf parseing.
Expected behavior
No response
Steps to reproduce
using memory_profiler may find the bug ....
at the /deepdoc/parser/pdf_parser.py , the line 960..
![image](https://github.com/user-attachments/assets/ef09b370-2b78-4f18-a12e-644330f9b2b5)
finding the page_imagesv2 takes up a lot of memory,but it will not be released.

Additional information
No response

/deepdoc/parser/pdf_parser.py , the line 960..


bazel 0.6 deprecated set in favor of depset.

That breaks the project that depends on a older version of rules_scala.

Okay. Will upgrade the rules_scala version.


Feat: add PacketAddr support to Trojan

Reopen #1919

Codecov Report
Base: 39.37% // Head: 39.21% // Decreases project coverage by -0.15% :warning:

Coverage data is based on head (9e34555) compared to base (f8ac919).
Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head 9e34555 differs from pull request most recent head 4a1d466. Consider uploading reports for the commit 4a1d466 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2225      +/-   ##
==========================================
- Coverage   39.37%   39.21%   -0.16%
==========================================
  Files         616      609       -7
  Lines       36738    36706      -32
==========================================
- Hits        14465    14396      -69
- Misses      20688    20727      +39
+ Partials     1585     1583       -2

Impacted Files
Coverage Δ

proxy/trojan/client.go
1.00% <0.00%> (-0.37%)
:arrow_down:

proxy/trojan/config.pb.go
12.50% <0.00%> (-0.28%)
:arrow_down:

proxy/trojan/protocol.go
44.82% <0.00%> (-5.18%)
:arrow_down:

proxy/trojan/server.go
0.37% <0.00%> (-0.02%)
:arrow_down:

proxy/trojan/simplified/config.go
3.84% <ø> (ø)

proxy/trojan/simplified/config.pb.go
18.86% <0.00%> (-0.74%)
:arrow_down:

app/router/command/errors.generated.go
0.00% <0.00%> (-100.00%)
:arrow_down:

testing/servers/tcp/tcp.go
81.81% <0.00%> (-5.46%)
:arrow_down:

testing/scenarios/common.go
75.00% <0.00%> (-4.29%)
:arrow_down:

transport/internet/websocket/connection.go
16.51% <0.00%> (-3.67%)
:arrow_down:

... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: update to eye v10.19.6

fix: update to eye v10.19.6

:tada: This issue has been resolved in version 16.19.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v16.19.2

Your semantic-release bot :package::rocket:


7.6.0

I've updated the cluster script to fetch from STRATZ API
fixes https://github.com/odota/web/issues/2828

Looks good, but I probably can't publish until next week


Is hide_end_of_buffer a good name?

Discussed in https://github.com/projekt0n/github-nvim-theme/discussions/206

Originally posted by bryanboateng September 13, 2022
Hi,
I set up the theme and was wondering why I could not see certain listchars (eol, precedes, extends). After searching for a long time I found hide_end_of_buffer. I find the name and description a bit unintuitive because the setting also controls the afformentioned listchars. Would it make sense to improve the naming and/or the description?

Actually, I'm not sure if this group is used for anything else? So we might be good.
							*hl-EndOfBuffer*
EndOfBuffer	Filler lines (~) after the end of the buffer.
		By default, this is highlighted like |hl-NonText|.


perf: Ionic Slide box Carousel Issue

Type: perf
Ionic Version: 1.x
Platform: mobile webview

<ion-slide-box auto-play="true" show-pager="true" does-continue="true" on-slide-changed="slideHasChanged($index)">
	   	   	 <ion-slide>

		     </ion-slide>

		   	<ion-slide>

		    </ion-slide>

	    	<ion-slide>

		    </ion-slide>

	    	<ion-slide>

		    </ion-slide>

	    	<ion-slide>
		        <img class="slide-img"<EMAIL_ADDRESS>		    </ion-slide>

   </ion-slide-box>

i m creating image slide carousel with help of this code.
Code is working fine but not support all mobile devices and if mobile device size is change the image carousel is not fit according to mobile device, another issue is if we change the portrait to landscape mode image carousel slide is not working and supporting according the size.

Hello! Thanks for opening an issue with us! As slidebox has been deprecated i will be closing this issue for now. Thanks for using ionic!


draw normal rect smtpads when rotation is 90 degrees

@ShiboSoftwareDev this could be improved/stabilized by doimg a repro test or adding a case, but good to have the proper fix

@ShiboSoftwareDev this could be improved/stabilized by doimg a repro test or adding a case, but good to have the proper fix

Yeah I can create a test for it


Package request: logiops

Project description
Logiops is a replacement for Logitech Options that allows users to configure the extra buttons/gestures functionality on certain Logitech mice (i.e. MX Master series).
Metadata

homepage URL: https://github.com/PixlOne/logiops
source URL: https://github.com/PixlOne/logiops
license: GPL v3
platforms: Linux

For those that are also new to Nix, here's how I set it up for myself:

{ pkgs, ... }:

{
  # Install logiops package
  environment.systemPackages = [ pkgs.logiops ];

  # Create systemd service
  systemd.services.logiops = {
    description = "An unofficial userspace driver for HID++ Logitech devices";
    serviceConfig = {
      Type = "simple";
      ExecStart = "${pkgs.logiops}/bin/logid";
    };
  };

  # Configuration for logiops
  environment.etc."logid.cfg".text = ''
    devices: ({
      name: "Wireless Mouse MX Master 3";
      smartshift: {
        on: true;
        threshold: 12;
      };
      hiresscroll: {
        hires: true;
        target: false;
      };
      dpi: 1200;
      buttons: ({
        cid: 0xc3;
        action = {
          type: "Gestures";
          gestures: ({
            direction: "Left";
            mode: "OnRelease";
            action = {
              type = "Keypress";
              keys: ["KEY_F15"];
            };
          }, {
            direction: "Right";
            mode: "OnRelease";
            action = {
              type = "Keypress";
              keys: ["KEY_F16"];
            };
          }, {
            direction: "Down";
            mode: "OnRelease";
            action = {
              type: "Keypress";
              keys: ["KEY_F17"];
            };
          }, {
            direction: "Up";
            mode: "OnRelease";
            action = {
              type: "Keypress";
              keys: ["KEY_F18"];
            };
          }, {
            direction: "None";
            mode: "OnRelease";
            action = {
              type = "Keypress";
              keys: ["KEY_PLAYPAUSE"];
            };
          });
        };
      }, {
        cid: 0xc4;
        action = {
          type: "Keypress";
          keys: ["KEY_F19"];
        };
      });
    });
  '';
}


Plugins documentation / getting started guide

I collected documentation for all the plugins and added documentation, where it was still required. I will be adding these to the wiki as well.

I am currently working on an actual website for impress.js

I still need to work on the table of contents, I forgot about that.

added that

Hey @simplePCBuilding. Thank you for the effort you put into this. I'm skeptical about the structure it introduces regarding plugins. As of now, each plugin is treated separately in its own subdirectory within src/plugins. Some directories contain only the plain JavaScript file, others also include their own README.md. I would suggest to stick to this structures as it makes it easy to separate concerns. In the long term, plugins can be easily added as new directories without any additional maintenance burden to keep the global README.md or GettingStarted.md consistent. In addition, some might even be pulled out into their own repository. So I would be in favor to just create new README.md files in the subdirectories of src/plugins where they are currently missing.
@henrikingo, what's your opinion on this?

Only did this because it was requested in an issue.

You are probably referring to #831. What is the difference between the two pull requests #831 and #835?

#831 is a general Getting Started guide for people creating an impress.js presentation for the first time. #835 is for Plugins getting Started (so just collection of all README.md of the Plugins)

@fnogatz thanks for helping out with reviews!
Yes so I have feedback on 2 levels here:

I don't think a Getting Started guide should just dump all the plugin documentation at the end. What you have in #831 is the right approach. Show the basics, and a few of the most useful plugins, and that's it.
As @fnogatz said, there's a reason why the docs for each plugin are in the plugin's own folder. They are best maintained that way. From here, there are 2 things that could improve:

Add a README.md file for each plugin. Many only have source code comments currently.
Create some automated build script, that is called from build.js, that collects all of these into a single easily readable documentation. This could be as simple as generating a file /src/plugins/TableOfContents.md automatically. (Just like /examples/index.html is generated.)

Sure, I'll do that. I'll probably also clean this branch here with that. I'll just add a simple getting started here.

I have a way better solution for this with the website. I'll add README's to all plugins that don't have any yet

I have solved both your ideas with two different approaches.

I have created the README's in this PR
I have created a build script that automatically builds DOCS (on website) from the MD sources and converts it to HTML. I will soon open a PR for that


Add line information to the annotation output of the translator.

Per the following issue logged at the CQL Issues Tracker, we will add line information to the annotation output of the translator:
https://oncprojectracking.healthit.gov/support/browse/CQLIT-8
The approach involves adding an "li" element to the annotation that contains a string with the line information ":".
Because it's part of the annotations, it will not be part of the core ELM output.
We could also consider adding the li element to the base expression, and controlling output with a "debug" flag.

Deferring the implementation of this to CQL 1.2...

Couldn't this also be a potential replacement for spans?  In other words, instead of including spans in the annotation text, the text remains as raw CQL and then separate elements(xml)/object(json) relate expressions/sub-expressions to line#/char# in the text.
In this way, it would even be possible to simply include the full CQL text as a single source annotation at the top of the document, and then all expression/sub-expression annotations just refer to ranges in the master CQL text.  I think this may be how I originally implemented it way back in v<IP_ADDRESS>.0.1 (fictional version number indicating how immature the translator was when I did it).

Yes, that would be a potential solution for sure. The reason we opted for spans with pointers to the nodes, rather than line numbers in the nodes was that line numbers and positions can often get mangled as the text goes through different encodings, so it was felt that it would be more error-proof to use an HTML-style span to link the text back to the nodes.
That being said, I'd be happy to offer this solution as an interim for the link-spanning (which turns out to be quite complicated, and I wonder that it may even involve an after-the-fact visit to produce it, rather than being able to build it up during the translation as we try to do now).

Could you post an example of what this might look like?

See the _Debug example here. The "locator" element provides line information, based on the original source file (not the annotation source).

The 1.2 translator now includes an option for outputting original source locator information.


Plugin guidelines

Plugins should only do one thing
Functions are preferred to classes
Always need to be well-documented and thoroughly tested
Make sure no other plugin already does that
Try to get it added to main org
Should generally be small
Not modify app configuration
Stay away from io
Explain app.isProduction, app.environment

Common options should be easily available, like gzip in compress


Is there a way to modify the raw data

I want to change the content of the raw data that is read from the raw file.
The error I got was an AttributeError: attribute 'raw_image_visible' of 'rawpy._rawpy.RawPy' objects is not writable.
Could you please tell me is there a way to modify the raw data?

If you want to save it back as a raw file, then no. If you just want to change the raw pixels for the postprocessing, then yes, just change pixels in the arrays, e.g. raw.raw_image_visible[:] = new_data

Thanks Maik! I am not saving the raw file; the only process that I need is the postprocessing. I am trying to modify the raw.raw_image_visible to see what corresponding postprocessing results it would lead to.
I have a couple of more questions here. Does the postprocessing process only depend on the raw_image_visible matrix, or is it that it depends on other options in the raw file as well? I tried to fill a new_data (which is 100x100) into  raw.raw_image_visible (which is 200x200). It led to a ValueError though: could not broadcast input array from shape (100,100) into shape (200,200). I modified the new_data as the upper left block contains the actual matrix values, while other parts are all set to zeros; then fed it into raw.raw_image_visible and it worked.
However, the results aren't what I was originally expecting for. My goal is trying to figure out what operations I could do on the raw data so that it leads to a simulated corresponding low-resolution counterpart of the original image. What I did earlier - by selecting a subset of the raw data doesn't lead to an image that is slightly blurry, but some points that have a color difference (I also tried bicubic interpolation of the raw data, seems it doesn't work either). Do you have any clue about it, if the above-mentioned makes sense to you. Thank you so much. :)

I you just want to reduce the output resolution, maybe the half_size=True option is a solution. But this is probably not what you have in mind when talking about "simulating".
Before I continue, do you understand the concept of Bayer matrices?

Thanks for your reply. Yeah that is not what I had in mind by setting "half_size=True".
I am actually trying to investigate the SR(super-resolution) problem by using raw data. As the raw data technically contains more information (hasn't been through all the processings) and offers higher controllability, my thought is that maybe it is more suitable for the SR problem of being able to restore more details. The traditional SR problem achieves the low-resolution images using bicubic interpolation.
img_2 = imresize(imresize(img, 1/2, 'bicubic'), [size(img, 1), size(img, 2)], 'bicubic');

For raw data though, I don't really have a clue of how to achieve similar "simulated" low-resolution images.
My basic understanding of Bayer matrices is that in raw data, each pixel value retains the intensity pixel value of only one color channel of the three RGB channels. The whole raw data is organized in Bayer pattern (RGBG) as blocks. I am all new into this so the understanding can be not very accurate.

I actually want to enable the "half_size=True" option, but in the opposite direction. I am not sure this option is achieved from a down-sampling the RGB image of original image size, or from the raw data.
Given both raw data and RGB data of the original image size, instead of achieving a half-sized RGB image, I am wondering what the corresponding raw data would be like that could generate the half-sized RGB image.

Okay, I see. Thanks a lot for your help! :)

Could you still tell me your answer to this question, does the postprocessing process only depend on the raw_image_visible matrix, or is it that it depends on other options in the raw file as well?

Postprocessing mostly depends on the image matrix, the chosen postprocessing parameters, and, if the parameters don't override it, then things like camera whitebalance can be used directly from the file metadata.

@Melody-doudou Hi, have you solved this? Can you share your solution on how to perform postprocessing on downsampled images?
Since the numpy array is downsampled, it cant overwrite the original array


Serious errors showing up with log level "INFO" instead of "ERROR"

Serious errors showing up with log level "INFO" instead of "ERROR". So they will be invisible if loglevel is set to ERROR or WARNING.
To Reproduce
examples: https://github.com/permitio/opal/issues/584
https://github.com/permitio/opal/issues/516
https://github.com/permitio/opal/issues/588#issuecomment-2325749315
Expected behavior
any unexpected be ERROR or WARNING

Noted. We'll open a internal ticket.
PRs are more than welcome


_on_date_ask strange exception on empty DateEntry

Desktop (please complete the following information):
ttkbootstrap: 1.9.0
OS: Linux 64 bits
python: 3.10.7
Describe the bug
When DateEntry is empty, if I try to click on calendar button, I get the following error:
Date entry text does not match %x
Exception in Tkinter callback
Traceback (most recent call last):
  File "/home/user/.pyenv/versions/3.10.7/lib/python3.10/tkinter/__init__.py", line 1921, in __call__
    return self.func(*args)
  File "/home/user/.pyenv/versions/3.10.7/envs/financeiro_3.10.7/lib/python3.10/site-packages/ttkbootstrap/widgets.py", line 239, in _on_date_ask
    old_date = datetime.strptime(_val or self._startdate, self._dateformat)
TypeError: strptime() argument 1 must be str, not datetime.datetime

To Reproduce
No response
Expected behavior
If DateEntry is empty, it should ask for date silently.
Screenshots
No response
Additional context
The error is on line 239 (widgets.py)
old_date = datetime.strptime(_val or self._startdate, self._dateformat)

If DateEntry is empty an exception occurs and the following line executes:
self._startdate = datetime.today()

my guess is that it should be converted to string.
My use case is simple. When my user selects a combobox I have to erase DateEntry content. So if the user clicks on calendar it gets the described error. Could the empty string case do not generate an exception? Or could be a way to catch this exception?

Possible fix. Not tested yet. Just two line.
def _on_date_ask(self):
        """Callback for pushing the date button"""
        # FIX: clean white space (always a good idea).
        _val = self.entry.get().strip()
        #_val = self.entry.get()
        try:
            self._startdate = datetime.strptime(_val, self._dateformat)
        except Exception as e:
            print("Date entry text does not match", self._dateformat)
            self._startdate = datetime.today()
            self.entry.delete(first=0, last=tk.END)
            self.entry.insert(
                tk.END, self._startdate.strftime(self._dateformat)
            )
        # FIX: datetime.strptime needs str as first arg
        old_date = datetime.strptime(_val or self._startdate.strftime(self._dateformat), self._dateformat)
        #old_date = datetime.strptime(_val or self._startdate, self._dateformat)

        # get the new date and insert into the entry
        new_date = Querybox.get_date(
            parent=self.entry,
            startdate=old_date,
            firstweekday=self._firstweekday,
            bootstyle=self._bootstyle,
        )
        self.entry.delete(first=0, last=tk.END)
        self.entry.insert(tk.END, new_date.strftime(self._dateformat))
        self.entry.focus_force()

For those experiencing this problem, on version 1.9.0, here is a quick workaround while there is not a version upgrade:
def _fix_ttkbootstrap_dentry(dentry: ttk.DateEntry):
    """
    Quick workaround for ttkbootstrap bug:
        * https://github.com/israel-dryer/ttkbootstrap/issues/372
    """

    def _empty_entry():

        _val = dentry.entry.get().strip()
        if not _val:
            # entry is string, fix it by inserting today's date
            dentry._startdate = datetime.today()
            dentry.entry.delete(first=0, last=tk.END)
            dentry.entry.insert(tk.END, dentry._startdate.strftime(dentry._dateformat))

            # call original button callback
            dentry._on_date_ask()

    # change button callback
    dentry.button.configure(
        command=_empty_entry,
    )

Just pass a DateEntry to  _fix_ttkbootstrap_dentry function  like this:
mydentry = ttk.DateEntry(master=self)
mydentry.pack()

# applying workaround
 _fix_ttkbootstrap_dentry(mydentry)


Update Azure PowerShell landing pages to new style

Docs Build status updates of commit 72e6433:
:clock10: Full build: the average full build time is 22 min(s) 26 sec(s), this is based on the last 204 build(s) for this repository.

Docs Build status updates of commit 72e6433:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

docs-conceptual/azps-2.6.0/index.yml
:x:Error

Details

.openpublishing.redirection.json
:warning:Warning

Details

docs-conceptual/azps-2.6.0/index.yml

[Error]

Unable to load file 'docs-conceptual/azps-2.6.0/index.yml' via processor 'Landing': Schema validation failed. Please validate the file and make sure it conforms to schema 'Landing' (https://static.docs.com/ui/latest/schemas/Landing.schema.json):
Value "how-to" is not defined in enum. Path 'landingContent[0].linkLists[2].linkListType'.
Value "conceptual" is not defined in enum. Path 'landingContent[1].linkLists[0].linkListType'.
Value "conceptual" is not defined in enum. Path 'landingContent[2].linkLists[1].linkListType'.

.openpublishing.redirection.json

[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docs-conceptual/azps-1.8.0/overview.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docs-conceptual/azps-2.6.0/index.md'. However, file with different extension W:\m3cf-s\docs-conceptual/azps-2.6.0/index.yml already exists in the Git repo in conflict with the redirection rule.  Docs will ignore the file W:\m3cf-s\docs-conceptual/azps-2.6.0/index.yml and populate with the redirection rule instead. To resolve this warning, please remove the file W:\m3cf-s\docs-conceptual/azps-2.6.0/index.yml from git repository

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 677bba4:
:clock10: Full build: the average full build time is 22 min(s) 26 sec(s), this is based on the last 204 build(s) for this repository.

Docs Build status updates of commit 677bba4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

.openpublishing.redirection.json
:warning:Warning

Details

[Error] Multiple input files would generate to the same output path overwriting each other. Please rename at least 1 of following input files to ensure that there will be only one file to generate to the output path: "docs-conceptual/azps-2.6.0/index.md, docs-conceptual/azps-2.6.0/index.yml".
[Error] Multiple input files would generate to the same output path overwriting each other. Please rename at least 1 of following input files to ensure that there will be only one file to generate to the output path: "docs-conceptual/azps-2.6.0/index.md, docs-conceptual/azps-2.6.0/index.yml".

.openpublishing.redirection.json

[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docs-conceptual/azps-1.8.0/overview.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.
[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docs-conceptual/azps-2.6.0/index.md'. However, file with different extension W:\x5zl-s\docs-conceptual/azps-2.6.0/index.yml already exists in the Git repo in conflict with the redirection rule.  Docs will ignore the file W:\x5zl-s\docs-conceptual/azps-2.6.0/index.yml and populate with the redirection rule instead. To resolve this warning, please remove the file W:\x5zl-s\docs-conceptual/azps-2.6.0/index.yml from git repository

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ae3422d:
:clock10: Full build: the average full build time is 22 min(s) 26 sec(s), this is based on the last 204 build(s) for this repository.

Docs Build status updates of commit 951a298:
:clock10: Full build: the average full build time is 22 min(s) 26 sec(s), this is based on the last 204 build(s) for this repository.

Docs Build status updates of commit 951a298:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docfx.json
:white_check_mark:Succeeded

docs-conceptual/azps-2.6.0/index.yml
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azps-2.6.0/overview.md
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azps-2.6.0/toc.yml
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azuredmps-0.9.0/index.md
:white_check_mark:Succeeded
View (azuredmps-0.9.0-preview)

docs-conceptual/azuresmps-4.0.0/index.md
:white_check_mark:Succeeded
View (azuresmps-4.0.0)

docs-conceptual/azurestackps-1.5.0/index.md
:white_check_mark:Succeeded
View (azurestackps-1.5.0)

docs-conceptual/azurestackps-1.6.0/index.md
:white_check_mark:Succeeded
View (azurestackps-1.6.0)

docs-conceptual/azurestackps-1.7.2/index.md
:white_check_mark:Succeeded
View (azurestackps-1.7.2)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit a11e117:
:clock10: Full build: the average full build time is 22 min(s) 27 sec(s), this is based on the last 205 build(s) for this repository.

Docs Build status updates of commit a11e117:
:warning: Validation status: warnings

File
Status
Preview URL
Details

.openpublishing.redirection.json
:warning:Warning

Details

docs-conceptual/azps-1.8.0/index.yml
:warning:Warning
View (azps-1.8.0)
Details

docfx.json
:white_check_mark:Succeeded

docs-conceptual/azps-2.6.0/index.yml
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azps-2.6.0/overview.md
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azps-2.6.0/toc.yml
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azuredmps-0.9.0/index.md
:white_check_mark:Succeeded
View (azuredmps-0.9.0-preview)

docs-conceptual/azuresmps-4.0.0/index.md
:white_check_mark:Succeeded
View (azuresmps-4.0.0)

docs-conceptual/azurestackps-1.5.0/index.md
:white_check_mark:Succeeded
View (azurestackps-1.5.0)

docs-conceptual/azurestackps-1.6.0/index.md
:white_check_mark:Succeeded
View (azurestackps-1.6.0)

docs-conceptual/azurestackps-1.7.2/index.md
:white_check_mark:Succeeded
View (azurestackps-1.7.2)

.openpublishing.redirection.json

[Warning] Master redirection file .openpublishing.redirection.json has a redirection rule on file 'docs-conceptual/azps-1.8.0/overview.md'. However, the file already exists in the Git repo in conflict with the redirection rule. Docs will ignore the file and populate with the redirection rule instead. To resolve this warning, please remove the original file in Git repo.

docs-conceptual/azps-1.8.0/index.yml

Line 0: [Warning] Invalid file link:(~/docs-conceptual/azps-1.8.0/migrate-az-2.0.0.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 5ed728d:
:clock10: Full build: the average full build time is 22 min(s) 26 sec(s), this is based on the last 206 build(s) for this repository.

Docs Build status updates of commit 5ed728d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docfx.json
:white_check_mark:Succeeded

docs-conceptual/azps-1.8.0/index.yml
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/overview.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-2.6.0/index.yml
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azps-2.6.0/overview.md
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azps-2.6.0/toc.yml
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azuredmps-0.9.0/index.md
:white_check_mark:Succeeded
View (azuredmps-0.9.0-preview)

docs-conceptual/azuresmps-4.0.0/index.md
:white_check_mark:Succeeded
View (azuresmps-4.0.0)

docs-conceptual/azurestackps-1.5.0/index.md
:white_check_mark:Succeeded
View (azurestackps-1.5.0)

docs-conceptual/azurestackps-1.6.0/index.md
:white_check_mark:Succeeded
View (azurestackps-1.6.0)

docs-conceptual/azurestackps-1.7.2/index.md
:white_check_mark:Succeeded
View (azurestackps-1.7.2)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit b54d629:
:clock10: Full build: the average full build time is 22 min(s) 25 sec(s), this is based on the last 207 build(s) for this repository.

Docs Build status updates of commit b54d629:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docfx.json
:white_check_mark:Succeeded

docs-conceptual/azps-1.8.0/index.yml
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/overview.md
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-1.8.0/toc.yml
:white_check_mark:Succeeded
View (azps-1.8.0)

docs-conceptual/azps-2.6.0/index.yml
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azps-2.6.0/overview.md
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azps-2.6.0/toc.yml
:white_check_mark:Succeeded
View (azps-2.6.0)

docs-conceptual/azuredmps-0.9.0/index.md
:white_check_mark:Succeeded
View (azuredmps-0.9.0-preview)

docs-conceptual/azuresmps-4.0.0/index.md
:white_check_mark:Succeeded
View (azuresmps-4.0.0)

docs-conceptual/azurestackps-1.5.0/index.md
:white_check_mark:Succeeded
View (azurestackps-1.5.0)

docs-conceptual/azurestackps-1.6.0/index.md
:white_check_mark:Succeeded
View (azurestackps-1.6.0)

docs-conceptual/azurestackps-1.7.2/index.md
:white_check_mark:Succeeded
View (azurestackps-1.7.2)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Rake task to permanently delete asset

The app uses the mongoid_paranoia gem which means that assets deleted via the API are only marked as deleted. This is so they can be restored via the API.
Sometimes it's desirable to permanently remove an asset, e.g. if an asset containing sensitive information is accidentally uploaded. This Rake task allows us to permanently delete an asset which has already been marked as deleted.
I've tested this on my dev VM as follows:
vagrant@development:/var/apps/asset-manager$ govuk_setenv asset-manager bundle exec rake govuk_assets:permanently_delete_asset
rake aborted!
*** Error: Please supply asset_id

vagrant@development:/var/apps/asset-manager$ govuk_setenv asset-manager bundle exec rake govuk_assets:permanently_delete_asset[x]
rake aborted!
*** Error: Asset not found: x

vagrant@development:/var/apps/asset-manager$ govuk_setenv asset-manager bundle exec rake govuk_assets:permanently_delete_asset[513a0efbed915d425e000002]
rake aborted!
*** Error: Asset not marked as deleted: 513a0efbed915d425e000002

vagrant@development:/var/apps/asset-manager$ govuk_setenv asset-manager bundle exec rake govuk_assets:permanently_delete_asset[5a0ae429ed915d0adcdf4731]
Permanently deleting asset ID: 5a0ae429ed915d0adcdf4731...[OK]

I'm hoping to use this to resolve #310.

I've manually deleted the asset identified in issue #310 so it's not obvious that we'll want to merge this branch. I suggest that we wait to see whether this is a problem that continues to happen before adding code to handle it. Alternatively, if we do want to add this code sooner then I suggest we add some tests before merging it.
What do you think, @floehopper?

@chrisroos Since we no longer need it and in any case it doesn't work properly in the (more likely) case where an asset has a corresponding S3 object, I'm going to close this.


Need a way to stop a running simulation

abercrom
https://jira.jpl.nasa.gov/browse/AERIEQS-451
Moderate
During thread test 2 we accidentally started a simulation with an incorrect configuration which caused the sim to to a very long time to run. We had to restart the worker container to get the sim to stop. Aerie needs a way for either the user or an administrator to stop a running simulation. (Restarting the container is a brute force solution, but application admins may not have permission to do that on production venues.)

@Mythicaeda has implemented a way to stop simulation & has done some manual testing, is currently working on figuring out how to implement an automated test for this feature.


Missing Release notes for 2.1.0

It looks like we are using https://github.com/sunscrapers/djoser/blob/master/CHANGELOG.rst for keeping release notes/change log
but It looks like that it's missing changelog for 2.1.0 is there reason why that's the case? Have we moved the changelog to somewhere else?
PS: Thank you for the awesome work that you guys are doing.

Release notes for 2.1.0 have been added at some point
https://github.com/sunscrapers/djoser/blob/master/CHANGELOG.rst#210-2020-10-30


feat: add computer science question

Summary of changes

Added new computer science question

Checklist

[x] I have read and followed the contribution guidelines.
[x] I have read through the Code of Conduct and agree to abide by the rules.
[x] This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
[x] My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
[x] I have provided a summary of my changes.

closes #29

How does it look?

Thank you for the review


bk-check-disk-space.sh Error: return: can only `return' from a function or sourced script

When bk-dhcek-disk-space.sh is ran as part of the environment hook. See https://github.com/buildkite/elastic-ci-stack-for-aws/blob/684ca4115ad4b15e38693aeaff42a296e80f6f96/packer/conf/buildkite-agent/hooks/environment#L20 it errors with the following message:

Yup, you are totally correct, it should be exit. I'll either fix it when I get a chance, or would welcome PR's!

@lox I opened a PR to fix this issue: #440


Support Grails 3

given Grails 3.0.0 GA was just released, it would be nice to see this plugin work with Grails 3 :)
thanks, zyro

+1

Bumping it up. Maybe we should have consider Grails 3 version

it already supports Grails 3


Compiler extension to check connection is closed

Description:

When using the DB connectors (eg: mysql), the connection should be closed after the usage otherwise the connection will be exhausted. But currently there's no way to identify if user code has the connection close statement:

 check mysqlEndpoint.close();

Hence it would be better if a compiler extension would support this requirement to do a static analysis on the code and check and throw a warning if user's code is missing the close statement.
Related similar issue:  https://github.com/ballerina-platform/ballerina-standard-library/issues/2400

As discussed in the demo. Currently we cannot do code flow analysis to identify this specific use case.
For this compiler plugin extension must support code flow analysis.


Omnisharp fails to open all Unity projects. No export was found for the contract 'ILoggerFactory'

Issue Description
For no apparent reason, OmniSharp has started crashing on VS Code startup.
Steps to Reproduce
Open VSCode
Expected Behavior
OmniSharp starts up.
Actual Behavior
OmniSharp crashes.
Logs
OmniSharp log

Starting OmniSharp server at 12/22/2022, 9:59:53 PM
    Target: /home/ben/bwbots-beer-caddy/unity/BWBots ROS1 Simulator/BWBots ROS1 Simulator.sln

OmniSharp server started with Mono 6.12.0 (/usr/bin/mono).
    Path: /home/ben/.vscode/extensions/ms-dotnettools.csharp-1.25.2-linux-x64/.omnisharp/1.39.3-beta.24/omnisharp/OmniSharp.exe
    PID: 7422

[dbug]: OmniSharp.CompositionHostBuilder
        Loaded OmniSharp.Cake, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e5bf7b3b470b509
[dbug]: OmniSharp.CompositionHostBuilder
        Loaded OmniSharp.DotNetTest, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e5bf7b3b470b509
[dbug]: OmniSharp.CompositionHostBuilder
        Loaded OmniSharp.Host, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e5bf7b3b470b509
[dbug]: OmniSharp.CompositionHostBuilder
        Loaded OmniSharp.MSBuild, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e5bf7b3b470b509
[dbug]: OmniSharp.CompositionHostBuilder
        Loaded OmniSharp.Roslyn, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e5bf7b3b470b509
[dbug]: OmniSharp.CompositionHostBuilder
        Loaded OmniSharp.Roslyn.CSharp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e5bf7b3b470b509
[dbug]: OmniSharp.CompositionHostBuilder
        Loaded OmniSharp.Script, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e5bf7b3b470b509
[dbug]: OmniSharp.CompositionHostBuilder
        Loaded OmniSharp.Shared, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e5bf7b3b470b509
[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on ubuntu 20.4 (x64)
[info]: OmniSharp.Services.DotNetCliService
        Checking the 'DOTNET_ROOT' environment variable to find a .NET SDK
[info]: OmniSharp.Services.DotNetCliService
        Using the 'dotnet' on the PATH.
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[dbug]: OmniSharp.CompositionHostBuilder
        .NET SDK requires MSBuild instances version 16.8.0 or higher
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 1 MSBuild instance(s)
            1: Mono 16.10.1 - "/usr/lib/mono/msbuild/Current/bin"
[dbug]: OmniSharp.CompositionHostBuilder
        MSBuild instance Mono 16.10.1 scored at 2
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Mono 16.10.1 - "/usr/lib/mono/msbuild/Current/bin"
[STDERR] System.Composition.Hosting.CompositionFailedException: No export was found for the contract 'ILoggerFactory'
 -> required by import 'loggerFactory' of part 'DefaultProjectChangePublisher'
 -> required by import 'projectConfigurationPublisher' of part 'MSBuildProjectManager'
 -> required by import 'item' of part 'IMSBuildEventSink[]'
 -> required by import 'eventSinks' of part 'ProjectSystem'
 -> required by import 'item' of part 'IProjectSystem[]'
 -> required by initial request for contract 'IProjectSystem[] { IsImportMany = True }'
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckTarget (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x00037] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckDependency (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x000cb] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckTarget (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x00076] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckDependency (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x000cb] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckTarget (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x00076] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckDependency (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x000cb] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckTarget (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x00076] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckDependency (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x000cb] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckTarget (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x00076] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckDependency (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x000cb] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.CheckTarget (System.Composition.Hosting.Core.CompositionDependency dependency, System.Collections.Generic.HashSet`1[T] checked, System.Collections.Generic.Stack`1[T] checking) [0x00076] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistryUpdate.Execute (System.Composition.Hosting.Core.CompositionContract contract) [0x00030] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.ExportDescriptorRegistry.TryGetSingleForExport (System.Composition.Hosting.Core.CompositionContract exportKey, System.Composition.Hosting.Core.ExportDescriptor& defaultForExport) [0x0004f] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.Core.LifetimeContext.TryGetExport (System.Composition.Hosting.Core.CompositionContract contract, System.Object& export) [0x00000] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.Hosting.CompositionHost.TryGetExport (System.Composition.Hosting.Core.CompositionContract contract, System.Object& export) [0x00000] in <db7a9e9ce8f2483abd2dba005db8e856>:0
  at System.Composition.CompositionContext.GetExport (System.Composition.Hosting.Core.CompositionContract contract) [0x00000] in <9222e906419e4f47bc57ced5ad91678c>:0
  at System.Composition.CompositionContext.GetExports (System.Type exportType, System.String contractName) [0x00023] in <9222e906419e4f47bc57ced5ad91678c>:0
  at System.Composition.CompositionContext.GetExports[TExport] (System.String contractName) [0x00000] in <9222e906419e4f47bc57ced5ad91678c>:0
  at System.Composition.CompositionContext.GetExports[TExport] () [0x00000] in <9222e906419e4f47bc57ced5ad91678c>:0
  at OmniSharp.Stdio.Host.Initialize () [0x0001e] in <e97ae9c8a1e74a549d799b7a017daa19>:0
  at OmniSharp.Stdio.Host..ctor (System.IO.TextReader input, OmniSharp.Services.ISharedTextWriter writer, OmniSharp.IOmniSharpEnvironment environment, System.IServiceProvider serviceProvider, OmniSharp.CompositionHostBuilder compositionHostBuilder, Microsoft.Extensions.Logging.ILoggerFactory loggerFactory, System.Threading.CancellationTokenSource cancellationTokenSource) [0x0007b] in <e97ae9c8a1e74a549d799b7a017daa19>:0
  at OmniSharp.Stdio.Driver.Program+<>c__DisplayClass0_1.<Main>b__1 () [0x0017d] in <96f323e5175244baa24aa0c2054fcfb9>:0
  at OmniSharp.CommandLineApplication+<>c__DisplayClass12_0.<OnExecute>b__0 () [0x0000b] in <98a6c62bc85e480eaeba8e1cc4347cca>:0
  at McMaster.Extensions.CommandLineUtils.CommandLineApplication+<>c__DisplayClass146_0.<OnExecute>b__0 (System.Threading.CancellationToken _) [0x00000] in <abe0fc6797a94a73931eea5cecaffd78>:0
  at McMaster.Extensions.CommandLineUtils.CommandLineApplication.ExecuteAsync (System.String[] args, System.Threading.CancellationToken cancellationToken) [0x000bf] in <abe0fc6797a94a73931eea5cecaffd78>:0
  at McMaster.Extensions.CommandLineUtils.CommandLineApplication.Execute (System.String[] args) [0x00016] in <abe0fc6797a94a73931eea5cecaffd78>:0
  at OmniSharp.CommandLineApplication.Execute (System.String[] args) [0x00081] in <98a6c62bc85e480eaeba8e1cc4347cca>:0
  at OmniSharp.Stdio.Driver.Program+<>c__DisplayClass0_0.<Main>b__0 () [0x00028] in <96f323e5175244baa24aa0c2054fcfb9>:0
  at OmniSharp.HostHelpers.Start (System.Func`1[TResult] action) [0x0001c] in <98a6c62bc85e480eaeba8e1cc4347cca>:0

[ERROR] Error: OmniSharp server load timed out. Use the 'omnisharp.projectLoadTimeout' setting to override the default delay (one minute).

Environment information
VSCode version: 1.74.2
C# Extension: 1.25.2
Mono Information
        OmniSharp using mono: 6.12.0
Dotnet Information
Found dotnet version 5.0.408. Minimum required version is 6.0.100.
 Thanks.

Or just remove it altogether
Should this issue be kept open? Because setting that to latest should not cause any problem

setting omnisharp.path to empty string fixed this issue for me too.

Why was this issue closed?  Changing omnisharp.path is only a workaround.  The issue actually needs to be fixed.

This issue should not be closed. Temporary fix doesn't work for me, and root cause it still unidentified.

@nateonline I had the same issue - The solution here https://github.com/microsoft/vscode/issues/170031 worked for me.

This issue should not be closed. Temporary fix doesn't work for me, and root cause it still unidentified.

@nateonline
Note that you should be setting "Omnisharp: Path", not "Omnisharp: Dotnet Path".


Random failure: Capybara::Webkit::InvalidResponseError: 'undefined' is not an object

Hello,
Running 1.0.0 with ruby 2.0.0-p247 & qt-4.8.5 I am getting random Capybara::Webkit::InvalidResponseError every once in a while. Let's say I run my tests 10 times in a row it might happen twice on 2 different tests.
I tried on various machines and it seems to happen more frequently on the less powerful setups, but even very recent macbook pros run into the issue.
I've spent some time trying to figure out what could be wrong in my code, but there isn't anything out of the ordinary, so I am not sure anymore how to go about this so I figured I'd bring this up here.
This issue seemed to be linked to our recent upgrade to Ruby 2.0, but I could be wrong since - like I said - it's very random.
Thanks

If it is the same problem I was having, then it's an issue with the Webkit implementation that Qt 4 uses on OSX. The solution is to upgrade to Qt 5 which uses a newer version that doesn't throw these kinds of errors when trying to play MP4 videos, for instance. See this blog post for details about the problem and solution: magnemg.tumblr.com/post/113251336220/how-to-solve-a-capybara-webkit-and-video-js

Thanks @redbar0n. I'll close this issue due to the long time of inactivity. Feel free to re-open it if you're still experiencing these issues.


Broken link from Timeout to WaitTime

https://dyalog.github.io/HttpCommand/operational-settings/#timeout links to https://dyalog.github.io/HttpCommand/operational-settings/conga-settings.md#waittime but it should be to https://dyalog.github.io/HttpCommand/conga-settings/#waittime

Fixed in 86dbb82a097babac5cf8aaf0fb211296e36b5415.
I also added some clarification about the use of WaitTime and Timeout settings.


chore(project): update according aurelia plugins

use babel6,
prepare jspm0.17,
add ts support
build into single file
add build html
add build css/less

not quite finished
pending https://github.com/aurelia/tools/pull/30


feat: add --md-only flag

Signed-off-by: Giacomo Guiulfo<EMAIL_ADDRESS>
What is the purpose of this change?
Add support for a global flag, "md-only". If enabled, only metadata of the files will be uploaded to the cloud backends. Also, a metadata header "Mdonly" will be included so that a cloud backend is aware that metadata-only put(s) were intended.
Was the change discussed in an issue or in the forum before?
Partially. This PR represent a subset of the changes discussed in https://forum.rclone.org/t/min-age-and-max-age-support-for-atime-and-ctime/2122/2.
Checklist

[ ] I have read the contribution guidelines.
[ ] I have added tests for all changes in this PR if appropriate.
[ ] I have added documentation for the changes if appropriate.
[ ] All commit messages are in house style.
[ ] I'm done, this Pull Request is ready for review :-)

What is the purpose of this change?  It seems to upload 0 size objects only?  Why would you want to do that?  Or have I mis-understood - thanks!

@ncm Hello Nick. Yes, the purpose of this change is to be able to upload 0 byte objects with their proper metadata attributes (system attributes, xattr, etc.) similarly to how cp --attributes-only works. There is a thread which discusses this topic further https://askubuntu.com/questions/56792/how-to-copy-only-file-attributes-metadata-without-actual-content-of-the-file.
I have to admit that clouds don't really leverage anything similar to this as a feature. So far, its purpose is to help us build one of the components we are developing here at Scality for Zenko.
In short, this component will rclone copy metadata from a filesystem, and then a s3-like backend will "read" the filesystem using this metadata as reference. This allows you to manage data from the cloud, without having to copy or move it there. You can find more detailed information about this here.
Let me know your thoughts about it, thanks!

Closing this since it's not a general use case.


Adding the DeleteNetworkView to README

missed this, why are some functionality deleted?

missed this, why are some functionality deleted?

Nothing is deleted, it is sorted.


Update the remaining docs that haven't been updated for RTM

[x] Fundamentals/Application startup tdykstra #2270
[x] Fundamentals/Error Handling tdykstra
[x] Fundamentals/Managing application state #858 Rick-Anderson
[x] fundamentals/localization Rick-Anderson
[x] View components Rick-Anderson
[x] MVC/Views/Working with forms   #1366 Rick-Anderson
[x] Testing/Integration Testing tdykstra
[ ] Client-side/Using Angular for Single Page Applications spboyer
[ ] Client-side/Bundling and Minification spboyer #1786
[x] Security/Authentication/Account Confirmation and Password Recovery Rick-Anderson
[x] Security/Authentication/Two-factor authentication with SMS Rick-Anderson
[x] Performance/In Memory Caching Rick-Anderson PR #2324
[x] Migration/Migrating HTTP Modules to Middleware tdykstra #2331

@spboyer you've been assigned

[ ] Client-side/Using Angular for Single Page Applications spboyer

@SteveSandersonMS - do you think that we should be documenting JavaScriptServices on Client-side/Using Angular for Single Page Applications or do we wait for the new templates?

Closing master issue.


Use Aws::ClientStubs

aws-sdk has mocking capability built in.
http://docs.aws.amazon.com/sdkforruby/api/Aws/ClientStubs.html
Would this be better to use than OpenStruct in some of the spec tests?

One thing you can't do with the AWS stubbing functionality is set expectations, for example:
expect(cloudformation_api).to receive(:delete_stack).with(stack_name: "my-stack").and_return(my_mock_response)

As I recall that is why I originally didn't go down that path. Worth revisiting though.

You can do this:
expect_any_instance_of(Aws::S3::Client).to receive(:put_object)
.with({bucket: 'mybucket', body: 'file/path', key: 'myfilename'})
But if you need to deal with responses and the response is complicated it gets messy. Kind of using the AWS stubs at times but they're not awesome.

I've cleaned up the specs a bit and replaced the OpenStructs with Hashie::Mash which is easier to use.
I think the main advantage of using the AWS client stubs over this setup is that the client stubs validate your responses against the AWS schema, which could catch some errors. On the downside, there doesn't seem to be an easy way to set expectations on the stubs, as per my example above in a previous comment.
So neither solution seems completely ideal, however all other things being equal I'd prefer to be able to easily use rspec expectations on the AWS APIs. I'll close this issue for now, however I could be swayed if it turns out there's a way to get request expectations as well as response schema validation using AWS stubs.


Unify HttpClient configuration

we read and validate timeouts and maybe other non-code configuration properties in every HTTP client implementation.
We could probably centralize common parts in the HttpClientOptions

Closing as these were standardized across HTTP stacks


Fix colorpicker

#4090
The demo crashes when clicking clear button without selecting any image.
Fixed by adding a check on the current_image.
Also fixed the display image name that may happen on different computers.

@xg-wang thanks


Please support template inheritance

I found golang's default template system do not support template inheritance like django/jinja2 , but i after some search, I found a solution to support inheritance:
http://stackoverflow.com/questions/11467731/is-it-possible-to-have-nested-templates-in-go-using-the-standard-library-googl
But the problem is : we maybe need to add a "base-template" field to config, and default set all of other templates inherit from the base template.
Any tips on where I should look to make changes? Thanks.

Template Dream is still open and tagged

@pedromorgan should give github.com/robfig/soy a shot :)

@robfig :+1:

Hi, @flosch. Is there any reason why pongo2's template.Execute method expects pongo2.Context rather than interface{}? We have already had our own Context in revel.
And there are plans to make template engine configurable.
Meanwhile, other template engines receive data interface{} rather than variable of their own type:
template:
func (t *Template) Execute(wr io.Writer, data interface{}) error

github.com/hoisie/mustache:
func Render(data string, context ...interface{}) string

or return standard template.Template that has Execute(wr io.Writer, data interface{}):
github.com/eknkc/amber
func Compile(input string, options Options) (*template.Template, error)

github.com/yosssi/ace
func Load(basePath, innerPath string, opts *Options) (*template.Template, error)

@anonx pongo2.Context is a simple map[string]interface{} since pongo2 provides all objects by their name in the template. For example, passing a pongo2.Context{"person": personObject, "makeSomethingUseful": func(...) {}} makes these two symbols (obj and func) available and they can be used, e. g. by printing out {{ person.Name }} or using the function in {% if makeSomethingUseful(person.Foo) %}...{% endif %}. Currently, I have no plans to drop this support, but you're free to pass any map[string]interface{} as a context (and typecasting it to pongo2.Context). If you making sure that your interface{} is a of type map[string]interface{}, then you can pass it easily to pongo2. If it's not a map, you could create a correct context like this: pongo2.Context{"obj": givenInterface}.

Adding https://github.com/revel/revel/pull/1003 , closing this


Subject keywords are disappearing when included in initial item deposit

Describe the bug
The standard deposit form includes a field for Subject Keywords. As of around January 18th, when you include keywords in the appropriate field, DSpace shows that they have been saved with the rest of the metadata, but when you complete the deposit, the keywords disappear, and cannot be seen, either in the default or full item view. I can reproduce this error in my local instance of DSpace, and at the Lyrasis Demo repository
If you go back and edit the item, then you can make the keywords appear.
To Reproduce
Steps to reproduce the behavior:

Deposit an item following the normal process. Include subject keywords. Complete the deposit.
Look at the item view (both default and full view). The keywords will not show up.
Edit the item in order to add the keywords. They will not show up in the existing metadata, but you can re-add them.

Expected behavior
Keywords should be accepted and included in the initial deposit.
Related work
Example of this bug in the demo repository

@paigecm : I'm not able to reproduce this in the demo site, or locally.  The demo site is extremely slow today (likely a lot of people on it), but I was able to create a new Item with multiple subjects.
Here's the item I created (it's in the same collection as the item you created): https://demo7.dspace.org/items/4148a524-9486-4628-afd7-aab4febe91c8
So, I'm not sure what could be going on.  Maybe the demo site was acting very slow when you tried this, and the "save" of these fields took longer?  I'm not exactly sure.  But, I also spun up pre-7.5 locally, and everything is working well there as well.
If you have more details on how to reproduce this reliably, or if you are able to find a way to reproduce this on another site (which is not the demo site), then please let me know.  I suspect right now that the slowness of the demo site caused things to not behave as expected.  (And we are working on migrating the demo site to a better environment, but it's unlikely to occur until Feb unfortunately.)

Thanks, @tdonohue -- but that's weird, because I just reproduced it again, this time taking extra time to make sure that the system said it had saved the keywords. Here's the latest example, which should have the keyword "wombat": https://demo7.dspace.org/handle/10673/245283.
I've also seen it in my local instance, and tracked it back for several weeks for non-templated items.
I'll keep trying to figure out what's going on, but this is weird.

@paigecm : Oh, I think I understand what you may be doing now.  It sounds like there may be a usability issue here in the form field.
By default, the "Subject Keywords" field is configured to use a controlled vocabulary. Notice the "vocabulary" tag in this default config: https://github.com/DSpace/DSpace/blob/main/dspace/config/submission-forms.xml#L190-L201
This means you can only add keywords from this vocabulary, and as you type terms it will search that vocabulary. For instance, if you start typing "computer" you should see suggestions show up for "Computer Science" and similar.
If you remove that setting (comment out the "vocabulary" tag), then that allows the "Subject Keywords" field to accept any values.  In that scenario, you could add "wombat" or similar, and you'd comma-separate each keyword... that'd make them appear in the submission UI like this (I did this locally by commenting out the "vocabulary" tag on the backend config and restarting the backend):

So, I think on the demo site, your keywords are not being accepted because they are not in the configured controlled vocabulary.  However, that looks like a usability issue to me because you likely should receive a notice or error message that the "keyword isn't found" in the vocabulary or similar.
Long story short, there is a small bug here where the UI isn't giving you an useful error when you attempt to add a term not in the controlled vocabulary.  But it also sounds like you may want to turn off this "vocabulary" configuration locally if you want the freedom to add any keyword that you want.

I think that's it! Thanks so much, @tdonohue -- I'll work on getting that fixed locally. I can confirm I'm not seeing an error when I put in any old keyword, either in my local instance or the demo -- but getting that vocab tag commented out will fix my problem.

I've found a similar issue wile trying to use tag input type without a controlled vocabulary on 7.4. Doing that, shows an error message (submission.sections.general.save_error_notice) and don't allow saving.

Closing as answered, since the originally reported issue was resolved.  Other related issues should be opened as separate tickets as needed.