Missing update documentation

There is build_hcc_and_hip.sh and good installation notes, but for updating there is a lack of documentation. Just read https://github.com/ROCm-Developer-Tools/HIP/releases/tag/preview_1.0.17241 and you see all is oriented towards new users for installation.
We don't want to get to a situation where we should had done something different. And while you're on it, please also explain how to test a new version - switching between multiple versions is really required.

Thanks. We'll add some documentation that makes is clearer how to upgrade to a newer version of HIP.

Thanks!

@VincentSC I am closing this issue. developer preview support was stopped long back and HIP releases are better streamlined now. Please reopen it in case you feel we may still need to address it.


AttributeError: 'Response' object has no attribute 'from_cache' after upgrading from 0.5.2 to 0.6.0

The problem
Hey, several days ago requests-cache was updated from 0.5.2 version to 0.6.0 version and my python unittests started failing. Was running unittests where mocked requests are included and getting this error:
*** AttributeError: 'Response' object has no attribute 'from_cache'
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/requests/api.py", line 76, in get
    return request('get', url, params=params, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/requests/api.py", line 61, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/requests_cache/session.py", line 101, in request
    if not response.from_cache and not self.filter_fn(response):

Expected behavior
A description of what you expected to happen
requests.get() should return mocked value as it was returning before.
Steps to reproduce the behavior
With a complete code example, if possible
import requests
import requests_mock

url = X

with requests_mock.mock() as mock:
    mock.get(url, text={'response': 'very good'})
    run_function(mock)
    requests.get(X).json()

Workarounds
Is there an existing workaround for this issue?
No, just switching back to 0.5.2 version works.
Environment

requests-cache version: 0.6.2
Python version: 3.8.2
requests-mock: 1.8.0
requests: 2.24.

Looks like there are a couple different things going on here. I could update CachedSession.request to suppress that error if you just need a short-term fix, but I think that error is actually useful in this case because it indicates that the cache isn't being used as expected.
The main issue is that there's a bit more setup required to get requests-mock and requests-cache to work together. In your code example, you're correct that requests-cache 0.5.x won't raise an error there, but it also won't be working as intended. Basically that requests_mock.mock() contextmanager is going to patch Session.send(), which partially overrides the patching done by requests_cache.install_cache(). So CachedSession.send() will never get called, which is why response.from_cache isn't set, and why the response won't actually get cached.
There are more details in #87 and #158, and there's an example of using both caching and mocking together in the docs here: https://requests-cache.readthedocs.io/en/latest/advanced_usage.html#requests-mock
Give that a try, and let me know if that works for you.

@skinderis Did this answer your question, or are you still having issues getting requests-cache and requests-mock to work together?

I'm going to close this issue for now, but let me know if you have more questions and I can reopen it.


Backward compatibility from Redis 4 to Redis 6

Could you add a FAQ section and a question and answer about compatibility?
Q: Is there any non-compatible features from Azure Cache Redis 4 to Azure Cache Redis 6?
A: No, there is no non-compatible features, except geo-replication between 4 and 6 is not supported.
https://redis.io/docs/management/security/acl/
In the default configuration, Redis 6 (the first version to have ACLs) works exactly like older versions of Redis.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 533790b4-ff9b-3181-4e3a-2c61eebe6413
Version Independent ID: 2877c9ca-62f9-2deb-0655-4518f6e5c78e
Content: How to upgrade the Redis version of Azure Cache for Redis
Content Source: articles/azure-cache-for-redis/cache-how-to-upgrade.md
Service: cache
GitHub Login: @flang-msft
Microsoft Alias: franlanglois

@himachida  Thank you for reaching out. We will look into it and update you as appropriate.


deepcopy does not work on used archivist instance

Describe the bug
The deepcopy of an Archivist() instance must be done before the original is used . Otherwise one gets this error:
File "/usr/local/lib/python3.6/copy.py", line 220, in
y = [deepcopy(a, memo) for a in x]
File "/usr/local/lib/python3.6/copy.py", line 169, in deepcopy
rv = reductor(4)
TypeError: cannot serialize '_io.BufferedReader' object
To Reproduce
arch = Archivist(...)
arch.assets.create(...)
drum = deepcopy(arch) # exception raised..
Expected behavior
deepcopy succedds and the new Archivist instance can be used

Add a copy method that copies explicitly....


AST-190 AST-197 AST-203: more UI tweaks

Description

Improved map load experience (so it doesn't zoom in on the ocean)
Adjusted layout of Register Entry page
Fixed bug with datetime picker

More to do, but this integrates all the UI tweaks to date.
Related Issues
_Closes #217, #197, #215.
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: johnx25bd.eth

Went ahead and merged so I could move forward with the current setup. Still worth a double check if you have a second Ron.


[mxnet 2.0][item 4.8][RFC] Gluon Data API Extension and Fixes(Part 1)

Description
This is the part 1 of Gluon Data API extension and fixes, which mainly focus on cleaning up diverging usage of mxnet module/gluon.
Through long time evolution, there's currently two streams of data loading conventions implemented in mxnet

Iterator: mxnet.io.DataIter(https://github.com/apache/incubator-mxnet/blob/ac88f1e87aa7da2c33f0cb89524d444ddc3a2ae8/python/mxnet/io/io.py#L180)
Dataset + DataLoader: gluon.data.Dataset + gluon.data.DataLoader

In order to eliminate the confusion here and to reduce the maintenance efforts, the plan is to drop all old iterators and provide similar Dataset + Dataloader experience in gluon data API.
Things to be removed
iterators

Base mxnet.io.DataIter(https://github.com/apache/incubator-mxnet/blob/ac88f1e87aa7da2c33f0cb89524d444ddc3a2ae8/python/mxnet/io/io.py#L180)
mxnet.io.ResizeIter(https://github.com/apache/incubator-mxnet/blob/ac88f1e87aa7da2c33f0cb89524d444ddc3a2ae8/python/mxnet/io/io.py#L282)
mxnet.io.PrefetchIter(https://github.com/apache/incubator-mxnet/blob/ac88f1e87aa7da2c33f0cb89524d444ddc3a2ae8/python/mxnet/io/io.py#L347)
mxnet.io.NDArrayIter(https://github.com/apache/incubator-mxnet/blob/ac88f1e87aa7da2c33f0cb89524d444ddc3a2ae8/python/mxnet/io/io.py#L491)
mxnet.io.MXDataIter(https://github.com/apache/incubator-mxnet/blob/ac88f1e87aa7da2c33f0cb89524d444ddc3a2ae8/python/mxnet/io/io.py#L800)
mxnet.image.ImageIter(https://github.com/apache/incubator-mxnet/blob/ac88f1e87aa7da2c33f0cb89524d444ddc3a2ae8/python/mxnet/image/detection.py#L626)
mxnet.image.ImageDetIter(https://github.com/apache/incubator-mxnet/blob/ac88f1e87aa7da2c33f0cb89524d444ddc3a2ae8/python/mxnet/image/detection.py#L626)

Augmenters from mxnet.image and mxnet.image.detection module
Random augmenters, e.g. (https://github.com/apache/incubator-mxnet/blob/ac88f1e87aa7da2c33f0cb89524d444ddc3a2ae8/python/mxnet/image/image.py#L615) will be removed.
Transform = args in gluon.data.Datasets
transform = is no longer supported, and can be replaced with dataset.transform or dataset.transform_first
Things to be added
Gluon Data Datasets
Dataset + Transfrom combo that simulate the removed Iterators
For example, NDArrayIter can be reimplemented as NDArrayDataset + empty transform function.
Gluon Data Augmentaters/Transforms
Data augmenters as mxnet.gluon.Block
Candidates TBD, useful candidates from GluonCV(https://github.com/dmlc/gluon-cv/tree/master/gluoncv/data/transforms) and GluonNLP(https://github.com/dmlc/gluon-nlp/blob/v0.8.x/src/gluonnlp/data/transforms.py)
mxnet.image
image processing functions will be absorbed from GluonCV(https://github.com/dmlc/gluon-cv/blob/master/gluoncv/data/transforms/image.py)

What about mx.io.ImageRecordIter? Also, what about the return type of those iterator - mx.io iterators return mx.io.DataBatch, will that be changed too?
@JanuszL FYI since DALI MXNet plugin produces mx.io.DataBatch and may be affected.

The old iterators will get a special gluon dataset wrapper which has no length and forbids random accessing or sampling from dataloader, they keep their original arguments during iteration


Use SVG File for Code Validation Ladybug

Hopefully this will look less scary on mac.
The image comes from https://github.com/microsoft/fluentui-emoji/blob/main/assets/Lady beetle/Flat/lady_beetle_flat.svg and I ran it through svgo.
With the changes:

For reference, here's what it looked like on iOS before:

Not totally sure if I put the svg file in the right place. Feel free to suggest alternatives.

That is certainly much less horrifying!
Actually since it's an svg you might consider just inlining it into a component (e.g. like this: https://github.com/microsoft/pxt/blob/master/multiplayer/src/components/icons/UserIcon.tsx#L17) but should be fine either way

Thanks for the heads up. I'm going to check it in as-is for now so this can make it to the hotfix. If we find this is causing trouble later on, we can inline it then.


There is no built-in way to use the detekt Gradle plugin on common sources in Kotlin multi-platform projects

Expected Behavior

Any of the following:

Running a platform specific Detekt task (e.g. detektJvmMain, detektJsMain...) also checks the common sources (or other project source code the platform code requires)
There is a detektCommonMain task
The detekt task checks the commonMain sources

Observed Behavior

None of the above.

Platform specific tasks only run checks on their source code (e.g. this run and this run, both only report 1 error in their own code but they do not report this empty-bodied function in the common sources)
There is no detektCommonMain task
The detekt task does not do anything (see also #3663)

Steps to Reproduce

Create a Kotlin MPP project
Try to run detekt only on common source code

Context

This makes using Detekt with no user-configuration useless in multi-platform projects as most code will be in the commonMain source set. This forces users to manually create a task that also checks for those, which is not fantastic.
A repro repo (that also highlights other issues) is available. I encountered this while trying to set up Detekt for one of my projects.
A possible workaround is to manually configure the detekt task or a custom task and give it the inputs we want (e.g. JVM + common or JS + common).
Your Environment

Version of detekt used: 1.16.0
Version of Gradle used (if applicable): 6.8.3
Gradle scan link (add --scan option when running the gradle task): See the CI links mentioned above.
Operating System and version: Windows 10, 1903
Link to your project (if it's a public repository): https://github.com/utybo/detekt-kotlin-mpp

Thanks for the reproducer.

* There is a `detektCommonMain` task

There is actually a detektMetadataMain task that will run the analysis only on the common module.
The name is unfortunate, but it turns out that the KMP plugin exposes a target called metadata with a compilation called main, therefore the task name gets composed from those.
I see that in your project the task works correctly and finds an issue:
gw detektMetadataMain

> Configure project :
Kotlin Multiplatform Projects are an Alpha feature. See: https://kotlinlang.org/docs/reference/evolution/components-stability.html. To hide this message, add 'kotlin.mpp.stability.nowarn=true' to the Gradle properties.

> Task :detektMetadataMain FAILED
empty-blocks - 5min debt
        EmptyFunctionBlock - [shouldDetectOnCommon] at /<redacted>/detekt-kotlin-mpp/src/commonMain/kotlin/CommonCode.kt:11:28

Overall debt: 5min

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':detektMetadataMain'.
> Build failed with 1 weighted issues.

Can I ask you to verify and let us know if this solved your issue?

I can confirm that this task works! Thanks for the reply. Would it be possible to add this to the documentation? I think this is pretty hard to find out for other MPP users. To be honest, I did not even notice this task in the Gradle panel of IntelliJ, and even if I did, I would have probably assumed it was an internal Detekt task that wouldn't do anything.

Closing as this was solved

Would it be possible to add this to the documentation?

Absolutely :) A PR about this would be more than welcome. Maybe we can add a paragraph similar to this one here:
https://github.com/detekt/detekt/blob/64b2fa66ce62fa538eb20f5e9ff6eb7317d3f2fb/docs/pages/gettingstarted/type-resolution.md#L69

This thread was very helpful. I'm also curious if there's a way to run Detekt for commonTest. I have tried detektMetadataTest but was not successful.


Bump React to 15.0.0

This bumps React to the latest.

Wonder if I should just remove peerDeps.

nvm, forgot it's pretty needed

thanks so much -- can you release to NPM?

Done thanks

👍


feat: Hl 1485 create instalments for larger payments

Description :sparkles:
Creates a payment instalment when thecalculator.calculate() is called.
When calculating the benefit amount, if the total amount is greater than the threshold value (by default 9600€) defined in settings, the overlapping amount is saved to a second payment instalment, which has a due date 181 days in the future.
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3479.dev.hel.ninja :rocket::rocket::rocket:

API branch is deployed to platta: https://helsinkilisa-pr3479.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3479.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr3479.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://helsinkilisa-ui-handler-pr3479.dev.hel.ninja :laughing::tada::tada::tada:


mysqlsh script broken in MySQL Shell 8.0.0 dmr

morgo@ryzen:~/sandboxes/msb_5_7_18$ ./mysqlsh
Conflicting options: port and socket can not be used together.

I worked around this by removing the socket option.  Not sure what you would like to do as a proper fix:
            --port=8003 "$@"
#            --socket=/tmp/mysql_sandbox8003.sock "$@"

This issue is due to fact that mysqlsh is not distributed with the server. You are probably using a version of mysqlsh later than 1.0.9, which has a check for the conflicting option.
The proper fix would be for the script to point to the version of mysqlsh that is appropriate for the current server version. Using a globally installed mysqlsh will always lead to this kind of errors.
It does not help that mysqlsh can't read options from a file.

I am using the version mentioned in the title (8.0.0 dmr) - available for download under"development releases".
This is an improvement over the previous version, as it is ambiguous which setting to make use of when they conflict.

I could remove the socket option, although I really dislike this kind of shot-in-the-dark development. The main principle of MySQL Sandbox is that it uses the tools that are appropriate for each version. With the global-only mysqlsh, there is no guarantee that the options coded in the script will be right.
I will change the script during the week-end.

Changed in version 3.2.11


Set lowest bound on logx test

The logx unit tests were flaky, disrupting regular builds of the m-lab/go repo.
The unit tests are flaky because the logic under test and the test logic both rely on timestamps and sub-millisecond resolutions, making them vulnerable to scheduler and context switching delays. Over ~7000 local runs of the unit test, len(lines) equal every value from 2 to 11 at least once.

This change is

Pull Request Test Coverage Report for Build 595

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.434%

Totals

Change from base Build 590:
0.0%

Covered Lines:
840

Relevant Lines:
1019

💛  - Coveralls

Also fixed https://github.com/m-lab/go/issues/65


Changed the code location of IkaEngine's initialization.

This change reduces the connectivity of IkaLogGUI and IkaEngine.

Thanks!


Try Eip1559

Opening this a Draft (for now).
These are the changes I needed to make to get a 1559 transaction completed on ropsten.
TODO: add logic similar to https://github.com/MetaMask/metamask-extension/pull/11385 so we can fallback to legacy when needed.

closing this as it's quite dated now and most of the same changes are in https://github.com/MetaMask/controllers/pull/521


Update _missing_translations_pl.json

Thank you. Feel free to add your name to https://github.com/localsend/localsend/blob/main/app/lib/pages/about/translators.dart


[TS Migration] Style fixes in Text.tsx

Details

After migrating a few components to TS it turns out that styles for Text component were typed incorrectly. This PR fixes these problems.
Fixed Issues

N/A
Tests

Send a few messages, use decorations like *text* to check if different types of styles are working
Send money request
Add a task
[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Check if text is styled correctly i.e.:

Send a few messages, use text decorations like *text* or ~text~
Send money requests (IOU)
Add a task
Overall check main functionalities, and if anything looks different than it used to

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/41169160/e3adfe6b-2200-494a-afbb-e9e4df63a991

Mobile Web - Chrome

https://github.com/Expensify/App/assets/41169160/75d0af44-cd70-4965-ae61-eec3ba04dc6e

Mobile Web - Safari

https://github.com/Expensify/App/assets/41169160/7b847de3-b28a-4066-9e8f-5a330dee521a

Desktop

https://github.com/Expensify/App/assets/41169160/9dcd2c78-92cb-4f7d-99b3-7f1ab2ce67d6

iOS

https://github.com/Expensify/App/assets/41169160/9b539f2a-3f4e-42b5-90e4-7ff2f38868bf

Android

https://github.com/Expensify/App/assets/41169160/e81ca2bd-f07b-4d11-979b-918f5fd0f1f8

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.3.93-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.3.94-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.3.94-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[[FIX]] Remove dead code for parameter parsing

Relevant coverage reports:

https://coveralls.io/files/423822073#L2488
https://coveralls.io/files/423822073#L2513

Commit message:

The removed code was made superfluous by a recent commit that unified
logic for function parameter parsing [1]. Since then, it has been
unreachable so it is safe to remove.
[1] Title: Re-use code to parse "fat arrow" function params
Commit: 7430ee539ca2fe1a443b71908b5c36d1689581f5

Coverage increased (+0.15%) when pulling a1d581757b7a70429e8daf0f80bd0ed1832d2043 on jugglinmike:remove-dead-code-3 into 8e680e6accfac7c52933b4bc20a8b25c8382171a on jshint:master.


Added "CLR vis C#" and "Clean code" books in russian

What does this PR do?
Add and update resources

The URL for the book in ukrainian was fixed
"Clean code" and "C# via CLR" in russian have been added.

Why is this valuable (or not)?
"Clean code" contains the main principles of creating excellent and professional code.
"CLR via C#" - is an excellent book for C# developers to understand how the .NET Framework platform actually works.
How do we know it's really free?
I have used them for my self-learning for free.
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

In general, we do not link to file sharing sites, or file hosting sites such as google docs. or dropbox.


Full Logitech setup - wierd issue

What are you experiencing an issue with?

[ ] Aurora
[ ] Aurora supported game, (Fill in the game)
[x] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[x] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[x] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
Overwatch Integration
Actual behavior:
Mouse and headset change just fine from hero to hero. Keyboard stays locked on desktop profile. Changes do register on Aurora, i see the hero colors on the virtual keyboard light up properly, but it doesn't relay to the keyboard.
How often does this problem occur?
Every time
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

installed
logitech patched
overwatch patched

What is the version of Aurora you are experiencing this issue with?
I've tried a full uninstall of LGS and reinstall of LGS and all three current versions, by that I mean i uninstall LGS and reinstall it every time i change versions of Aurora.
Does the previous version of Aurora have this issue?
Do not know, recently acquired this gear and started using your software
Please include any logs, screenshots, or files that are related to this issue:
Anything I can provide, Just let me know what and how to acquire it.

Also seems to ignore the EQ lol, Headset and mouse are rocking out but the keyboard is just sitting there in plain desktop mode, virtual keyboard in the Aurora app shows the EQ motions. Also just like to say that the sheer effort and time that must have gone into this work is astounding. I'm sure it's probably something misconfigured on my end. I've reviewed all of what I could relating to the logitech issues and this seems to be new. I've notice that the keyboard and headset are registered under atmoOrb, if I disable it, they go dark. Not too sure how to proceed troubleshooting.

If you disconnect the headset from your computer so you only have the mouse and keyboard does it change anything? Also, could you throw in your log file from when this is occurring (%appdata%/Aurora/Logs or click "Show logs folder" (or whatever it's called) in Settings -> Debug)


Likely memory leak

Fedi discovered a likely memory leak after upgrading an internal testing federation from 0.3 to 0.4. It looks very logarithmic, so it might not be a memory leak, but just a data structure with this behavior (some rocksdb in-memory index?).

In general this shouldn't be a huge problem for setups with automatic restart: the OOM killer will kill the process and systemd will restart it. Might still lead to wonky behavior.
Some starting points for debugging:

Valgrind:

Although Valgrind is primarily a tool for C/C++ programs, it can still be used with Rust programs to detect memory leaks. Compile your program with debuginfo and run it with Valgrind:cargo build --release
valgrind --leak-check=full ./target/release/your_program

Heaptrack:

Heaptrack tracks all memory allocations and can give detailed insights into which parts of your code are causing memory issues.
To use it, install heaptrack and run it with your Rust executable:heaptrack ./target/debug/your_program
heaptrack_gui heaptrack.your_program.<timestamp>.gz  # Use GUI to analyze

AddressSanitizer:

You can compile your Rust program with AddressSanitizer to detect memory errors. Set the RUSTFLAGS environment variable:
export RUSTFLAGS="-Zsanitizer=address"
export RUSTDOCFLAGS="-Zsanitizer=address"
cargo +nightly build
./target/debug/your_program

Note that AddressSanitizer support might require a nightly compiler and additional setup.

Heaptrack

Looks like a typical case of C++ developer deluding themselves that they can keep track of allocations manually.

Looking more into it ... it might just be a block cache.

Ehh, without the same workload, this is all kind of pointless.

Lots of progress in #6347


ctrl+c are doing exit from arango shell

ctrl+c is need to stop executing of operation, but at current release it's close terminal window.
--
Window 7

Duplicate of #1036


Missing information

The instructions make it easy to install the gateway app, and give no clue whatsoever how to use it in Power BI.  Somewhere between steps 3 and 4 about, you should say HOW to use the app.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e1f5955-e5b8-9cff-873e-4a195a462e62
Version Independent ID: 12a87ce1-0e1b-f21c-bad3-09963e628d99
Content: On-premises data gateway - Power BI
Content Source: powerbi-docs/service-gateway-onprem.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @mgblythe
Microsoft Alias: mblythe

Thanks for your comment, @martynickel-at-gaffey . This issue has been assigned to the doc author for review.

I have the same questions.

@mkjohnson see: https://docs.microsoft.com/en-us/data-integration/gateway/service-gateway-app

Thanks @martynickel-at-gaffey - I'll make some updates to the links. In the meantime, in addition to the gateway app article that @mikemorrison111 suggests, I recommend this article to see an end-to-end gateway scenari: https://docs.microsoft.com/en-us/power-bi/service-gateway-sql-tutorial.

The second link to Configure goes to the article about the gateway app. I added the link to the end-to-end gateway scenario: https://docs.microsoft.com/en-us/power-bi/service-gateway-sql-tutorial as step 4. This will go live shortly.


fix(linter): false positive in jsx-a11y/iframe-has-title

closes #7243

Merge activity

Nov 12, 8:06 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Invite log tracker

Please check @Jejebecarte

Heya, a few notes:

Please only edit files if it is necessary to do so. Most files touched by your commits haven't been altered. This makes tracking changes and the source of potential errors much easier. Maybe your IDE is changing line endings?
Install pnpm globally on your machine, not as a dependency of this specific codebase  - that sort of defeats the purpose of it.
You shouldn't need to add workspace configurations. If you really must, add them to the root directory, not src/commands/
The new contents of src/events/mineflayer/chat/memberJoinLeave.ts and src/commands/guildLog.ts look like they can be extracted into a separate file. Looks very repetitive.
In the guildlog command, it is best practice to reply directly to a user's command in the channel it was initiated in, not in a separate logChannel. Otherwise it's confusing that the user receives an ephemeral confirmation message, but no actual content.

Heya, a few notes:

Please only edit files if it is necessary to do so. Most files touched by your commits haven't been altered. This makes tracking changes and the source of potential errors much easier. Maybe your IDE is changing line endings?
Install pnpm globally on your machine, not as a dependency of this specific codebase  - that sort of defeats the purpose of it.
You shouldn't need to add workspace configurations. If you really must, add them to the root directory, not src/commands/
The new contents of src/events/mineflayer/chat/memberJoinLeave.ts and src/commands/guildLog.ts look like they can be extracted into a separate file. Looks very repetitive.
In the guildlog command, it is best practice to reply directly to a user's command in the channel it was initiated in, not in a separate logChannel. Otherwise it's confusing that the user receives an ephemeral confirmation message, but no actual content.

@Vliegenier04 Please integrate feedback before merging - you still haven't any of the above issues.
Additionally, you merged branches incorrectly and removed the /g online in setTimeout. Thus, the bot is unable to update its status and join/leave counter automatically.

Further:

Please ensure your editor is configured to use LF endings, not CRLF.
Squash this specific branch when merging to master.
Please check with me before merging.

Upon further consideration, it would be best in fact to leave these changes on this branch and pull from it directly. This is not a feature set that should be pushed to master, really.
If more practical, it might be good to create a temporary new repo with this code, given DedicatedMC's current lack of branch switching.


Fix failing unit tests by mocking middleware

Add minimal mocks for middlewares:

authentication
session

CI: No security warnings found


Support for liquibaseSchemaName

We have our liquibase changelog in a custom schema and specify this schema in a liquibase.properties file.
Is it possible to either use the config in the properties file or to set the schema in the action to make it accessible for the action?
Thanks

Hi @KirioXX , thanks for using Liquibase! We're about to publicly announce our brand new github actions that support all Liquibase commands, command parameters, and global parameters. Take a look!
https://github.com/liquibase-github-actions


Add a Rebus: MoneyBall

Associated Issue: #14
Please get familiar with the contributing guide before submitting a PR.
Summary of Changes

Added a Rebus : Money Ball

Pull Request Test Coverage Report for Build 49

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.231%

Totals

Change from base Build 47:
0.0%

Covered Lines:
87

Relevant Lines:
99

💛  - Coveralls

@HrushikeshBodas When you resolved the conflicts, you also removed your own addition. Add it back and I will merge this 🙂


update eslint-config version to most recent (2.2.0)

Using the previous version of eslint-config (1.0.5) the precommit tests were failing because of deprecated rules. This update fixes that.

:shipit:


Add an snrWasUsed field

Will be set to true only if the SNR system actually did some rescoring (we need this for experiment analysis).

Why wouldn't you like to use 'snrResponseCode == 200' check?

'snrResponseCode == 200' check

This is not exactly what I need. SNR has a "no-op" mode that doesn't rescore anything and is activated when a disrepancy is detected between the SpeechKit version SNR was trained on and the metainfo.version field value. SNR still returns 200 OK when this happens, which means a simple == 200 check won't do.
Perhaps we could come up with a better field name. snrNoOpMode? snrWasActive?

Maybe you could use something like 304 NOT MODIFIED in SNR response code for such a case?

Sounds like a fine idea, but we still have to calculate candidate features and store them in metainfo.snrInfos.features. Even for the no-op mode.
There are other HTTP codes we could use, but this seriously seems like abusing HTTP. :/


Remove Equals and friends

This PR is related to the issue and deprecates:

If (replaced with std::conditional)
Equals (replaced with std::is_same)
IsPointer (replaced with std::is_pointer)
IsVolatile (replaced with std::is_volatile)
RemoveQualifiers (replaced with std::remove_cv)
EnableIf (replaced with std::enable_if)

Some tests seem to take about 6% less time to compile with these changes.

gpuCI: NVIDIA/thrust/pull/1579
DVS: 30775726


broken in some situations in chrome

When used on my page in the most recent build of chrome document.documentElement.clientHeight returns the full height of the page, not just the viewport, which causes getViewportHeight to return the wrong number and breaks the whole tool.
I imagine it must be something specific to my page. But I checked the list of known issues and I dont fit under any of them. If you cannot replicate, I am happy to share my exact code to help with debugging.

Can you provide me with a demo link?

Hey, can you toss me a demo link?

Closing due to inactivity.


#35968 DT settings page - bit of redesign

Now Enter will force Next button.
Also icon was fixed and section rendering was improved

verified


[SPARK-37868][PYTHON] Add eager_check for LocIndexer._select_cols_by_iterable

What changes were proposed in this pull request?
Skip equal check in LocIndexer._select_cols_by_iterable if eager_check disable
Why are the changes needed?
To improve the performance if eager_check disable.
Does this PR introduce any user-facing change?
Yes, with eager_check disable, didn't raise exception in nan case.
How was this patch tested?
UT

Anyway, let's close this PR first.


Logs of Concrete Executor should contain Exception with stack trace

Description
Logs of Concrete Executor do not contain Exceptions any more.
To Reproduce

Enable logs using ~/.utbot/settings.properties: logConcreteExecutionErrors=true
Run any test generation which leads to concrete execution failure. For example, #739.
Or add the following code and generated tests for it:

    /**
     * Should find a branch that returns true and size of array is greater than 1 (non-trivial).
     */
    public static boolean isDiagonal(Collection<Collection<Double>> matrix) {
        int cols = matrix.size();
        if (cols <= 1) {
            return false;
        }
        int i = 0;
        for (Collection<Double> col : matrix) {
            if (col.size() != cols) {
                return false;
            }
            int j = 0;
            for (Double value : col) {
                if (i == j && value == 0.0) return false;
                if (i != j && value != 0.0) return false;
                j++;
            }
            i++;
        }
        return true;
    }

Generated test contains:

///region Errors report for isDiagonal

    public void testIsDiagonal_errors() {
        // Couldn't generate some tests. List of errors:
        //
        // 4 occurrences of:
        // Concrete execution failed

    }
    ///endregion

Find logs in temp folder: ~\AppData\Local\Temp\UTBot\utbot-childprocess-errors
Open it.

Expected behavior
Log should contain some system information and an exception that is translated into broken test in main process.
Actual behavior
Log contains some child process problem (#848), many lines like this one:
Visual proofs (screenshots, logs, images)
Log is the following:
WARNING: package jdk.internal.jtrfs not in java.base
11:50:04.568 | Info  | RdCoroutineScope          | 1:main @coroutine#1 | RdCoroutineHost overridden
11:50:04.586 | Info  | ClientProtocolBuilder     | 1:main @coroutine#1 | pid - 14364, port - 50934
11:50:04.587 | Info  | ClientProtocolBuilder     | 1:main @coroutine#1 | isJvm8 - false, isJvm9Plus - true, isWindows - true
WARNING: Illegal reflective access by com.esotericsoftware.kryo.kryo5.unsafe.UnsafeUtil (file:/C:/Users/lWX1182794/AppData/Roaming/JetBrains/IntelliJIdea2022.2/plugins/utbot-intellij/lib/utbot-instrumentation-2022.11.495..jar) to constructor java.nio.DirectByteBuffer(long,int)
WARNING: Illegal reflective access by com.esotericsoftware.kryo.kryo5.unsafe.UnsafeUtil (file:/C:/Users/lWX1182794/AppData/Roaming/JetBrains/IntelliJIdea2022.2/plugins/utbot-intellij/lib/utbot-instrumentation-2022.11.495..jar) to method sun.nio.ch.DirectBuffer.cleaner()
11:50:04.685 | Info  | ChildProcess              | 16:Scheduler for Client50934 | setup started
11:50:04.692 | Info  | ChildProcess              | 16:Scheduler for Client50934 | setup ended
11:50:04.694 | Info  | ClientProtocolBuilder     | 1:main @coroutine#1 | signalled
11:50:05.097 | Info  | DynamicClassTransformer   | 16:Scheduler for Client50934 | Transforming: org/utbot/examples/collections/CollectionExample
11:50:05.162 | Info  | DynamicClassTransformer   | 16:Scheduler for Client50934 | Transforming: org/utbot/examples/collections/CollectionExample$ConcreteList
11:50:05.163 | Info  | DynamicClassTransformer   | 16:Scheduler for Client50934 | Transforming: org/utbot/examples/collections/CollectionExample$ConcreteMap
11:51:03.003 | Info  | ChildProcess              | 1:main @coroutine#1 | runBlocking ending
11:51:03.003 | Info  | ChildProcess              | 1:main          | runBlocking ended
11:51:03.004 | Info  | Client                    | 16:Scheduler for Client50934 | ClientSocket: start terminating lifetime
11:51:03.004 | Info  | Client                    | 16:Scheduler for Client50934 | ClientSocket: termination finished

Environment
Windows 10 Pro
IntelliJ IDEA 2022.2.3
Gradle (UTBotJava) project
JDK 11
Additional context
This was already fixed somehow in #870

Please note that some exceptions are logged:

#1292


fix(markdown): emit event on outside-click if no data changed

Fixes: https://github.com/openshiftio/openshift.io/issues/4049
This PR is a part of this PR https://github.com/fabric8-ui/fabric8-planner/pull/2781 in fabric8-ui

Can one of the admins verify this patch?

@sahil143 ^^

@sahil143 can you take a look at this PR?

Once this is merged, it can only be applied to the planner upgrade PR/branch as it has already been upgraded.

Please update the tests.
[test]

:tada: This PR is included in version 3.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Projection on volume of interest

Hi! I have the following problem: In my application I want to map a 2D heatmap (numpy array) onto the surface of a mesh.

As in the figure shown above I know the y / z position of that heatmap. Now what I am doing is just creating a "dummy" heatmap volume (the pink cylinder in the figure) by replicating the array in x. What I want is just the projection of my heatmap (the intersection area) on my mesh of interest (the car in the figure above). Is there a way to do this? How would go about it?

Hi @horsto I'm not exactly sure, if I understand what your aiming for, you might consider mapping your heatmap values onto a mesh by using interpolateDataFrom(), check out new examples:
pip install -U git+https://github.com/marcomusy/vedo.git
vedo -r interpolateMeshArray
vedo -r interpolateScalar1


Support for private git repositories

Is your feature request related to a problem? Please describe.
When wanting to parse and query data stored in config files in git repositories, this data is found in private repositories on GitLab or GitHub. Accessing those is currently not possible, in difference to accessing private S3 buckets.
Describe the solution you'd like
Both and other git hosting services provide token or SSH authentication possibilities. These were to leverage for implementing a "standard-compliant" way to allow git authentication.
Describe alternatives you've considered
This is a one-way street. There's no alternative to that, when wanting to support private git repositories.
Additional context
ArgoCD offers nice abstractions for managing git repository access & credentials.

https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#repository-credentials

Hey @almereyda, We are closing this issue because we have not heard from you. Please feel free to reopen the issue if you want to share or discuss anything.


Documentation for unsupported, runtime-dependent features.

Is there any documentation here (or elsewhere) on which C# language features depend on runtime support, and therefore can never be polyfilled?
I know the readme mentions static abstract members, and I'm pretty sure default interface methods are out too.
It would be helpful to have some list of the features that we should not expect this project to ever be able to polyfill, (if only to preempt people opening feature requests for them 😆).

Default interface implementations are definitely out. I'm working on a git repo now that tests each C# language feature from 8.0 forward to tests which polyfills are available. (The project targets .NET 4.7.2 with C# 11).
It looks like ranges are also not supported. When I attempt to use them, I am presented with the following error:

CS0656: Missing compiler required member 'System.Runtime.CompilerServices.RuntimeHelpers.GetSubArray.'

I am unable to add a direct reference to System.Runtime to the project, and there's already a reference to System.Runtime.CompilerServices.Unsafe.
The code I'm using comes directly from Microsoft's documentation and is as follows:
int[] numbers = new[] { 0, 10, 20, 30, 40, 50 };
int start = 1;
int amountToTake = 3;
int[] subset = numbers[start..(start + amountToTake)];

Ranges are only not supported when slicing arrays. If you try to slice eg. a Span<T>, they'll work just fine. In general, they'll work any time you're trying to slice a type that exposes a count (Length or Count) and a Slice(int, int) method.

Sergio - I got slicing to work by editing the project file and manually adding the following to it:
<reference

I will also say, from the point of view of users, it's actually pretty straightforward. If something can be used, it'll just work. If something requires runtime support and that's not available, Roslyn will just emit an error with a nice explanation about it 🙂

Sergio: Hmm, I see that that actually does work. Thansk!
Still, would be good to have a list, even if only a partial list that can be updated over time.

[CS8701] Target runtime doesn't support default interface implementation.
Actually, I wonder how that functions for class libraries targeting .NET Standard 2.0 (which obviously isn't, itself, a runtime).
Is Roslyn just smart enough to know that no runtime that targets  .NET Standard 2.0 also supports default interface implementations?

Actually, I wonder how that functions for class libraries targeting .NET Standard 2.0 (which obviously isn't, itself, a runtime).
Is Roslyn just smart enough to know that no runtime that implements .NET Standard 2.0 also supports default interface implementations?

.Net Standard is a "contract" for runtimes. All runtimes that support default inheritance also support the .Net Standard 2.0 API-s, but not all runtimes that support .Net Standard 2.0 have default interface implementations. Hence Roslyn is careful enough to not allow using default interface implementations if the target is .Net Standard 2.0.
Great library btw, makes one wonder why Microsoft didn't bother with something like this.

I couldnt get expression-bodied property to work on a legacy project using .Net Framework 4.0
I assume it is not doable?

Those will work just fine, but you need to set the C# language version to at least C# 7 🙂

But I did

This simple refactor broke in runtime.

    public bool IsReusable => false;

    // public bool IsReusable
    // {
    //     get { return false; }
    // }

@GetCurious That should still work, I think, if you're have the latest Microsoft.CodeDom.Providers.DotNetCompilerPlatform package installed and configured in your web.config's <system.codedom>.
(You might possibly need to explicitly set /langversion:7 in the compilerOptions attribute.)

It looks like ranges are also not supported. When I attempt to use them, I am presented with the following error:

@DreadLordMikey Try creating the following class in your project: https://gist.github.com/bgrainger/fb2c18659c2cdfce494c82a8c4803360

Feel free to use my notes as a base for this.


From a guy of the Psych Engine Discord:

Me when only helps with psych builds only on unsupported mobile builds and breaks compatibility with some luas therefore misconveniencing builds that are actually supported

so no

bro this is a good pr

if this is a "fix" for android, it will most likely break other things.

it is not gonna break other things

this is fix the dialogue for the Lua script for other platforms

trust me I have tried it out

💀

I have tho

None of the supported platforms need this

also this is not a shit pr this actually fixes the lua dialoge

Sorry but this pr sucks. It may fix mobile, but it should be considered that mobile isn't an officially supported platform. This commit would be way more fit for a custom fork, because at the end of the day this is code that worsens the supported platforms' code just to fix android, which is not supported.

bro I have  tried this on my Mac it works on Mac

IT WORKS

IT WORKS

don't care + didn't ask + ratio + kys

IT WORKS

don't care + didn't ask + ratio + kys

wtf is kys

IT WORKS

don't care + didn't ask + ratio + kys

wtf is kys

Keep yourself safe.

IT WORKS

don't care + didn't ask + ratio + kys

wtf is kys

Keep yourself safe.

i don't understand these new slang words anymore

I lied.
It's an abbreviation, not a "slang word".
https://google.com/

bro why you guys gotta hate on other platforms?

1- Lua already works on Mac without your "fix"
2- Android is not officially supported
3- this is unnecessary
period.

1- Lua already works on Mac without your "fix" 2- Android is not officially supported 3- this is unnecessary
period.

An extra thing to add is that it might break compatibility with a lot of mods, which isn't very, good at all

1- Lua already works on Mac without your "fix" 2- Android is not officially supported 3- this is unnecessary
period.

No it doesn't.

1- Lua already works on Mac without your "fix" 2- Android is not officially supported 3- this is unnecessary
period.

Android is supported just needs a little fixing.

This is necessary since Psych Engine is a "modding" engine

1- Lua already works on Mac without your "fix" 2- Android is not officially supported 3- this is unnecessary
period.

An extra thing to add is that it might break compatibility with a lot of mods, which isn't very good at all

No, it doesn't I have tried on the latest version and everything works on Windows, macOS, Linux, HTML5 with no building errors at all 🤡

2. Android is supported just needs a little fixing.

 Android is supported just needs a little fixing.

 Android is supported just needs a little fixing.

 Android is supported just needs a little fixing.

The idea with this commit is to fix text stuff from lua, correct? If I recall correctly, Mac (a supported platform) did have a bug with dialogue (I think it was about the game just not pausing during the dialogue??). Does this fix this? Was it already fixed? Sorry if I sound out of the loop, I can't test the mac build myself.

The idea with this commit is to fix text stuff from lua, correct? If I recall correctly, Mac (a supported platform) did have a bug with dialogue (I think it was about the game just not pausing during the dialogue??). Does this fix this? Was it already fixed? Sorry if I sound out of the loop, I can't test the mac build myself.

was it broken in the first place? it works fine on mine without the fix

why are you all fighting this is a github pull request not twitter dot com

I just wanna see how mad will this person get if I say actual facts

what facts that u can't agree that ur wrong?

period.
stop trying to be a superhero on the internet

The idea with this commit is to fix text stuff from lua, correct? If I recall correctly, Mac (a supported platform) did have a bug with dialogue (I think it was about the game just not pausing during the dialogue??). Does this fix this? Was it already fixed? Sorry if I sound out of the loop, I can't test the mac build myself.

Well dialogue in general, Yes this fixes it, No it wasn't fixed

why are you all fighting this is a github pull request not twitter dot com

I just wanna see how mad will this person get if I say actual facts

what facts that u can't agree that ur wrong?

 period. stop trying to be a superhero on the internet

I'm not trying to be the hero, I'm trying to be the one with braincells

The idea with this commit is to fix text stuff from lua, correct? If I recall correctly, Mac (a supported platform) did have a bug with dialogue (I think it was about the game just not pausing during the dialogue??). Does this fix this? Was it already fixed? Sorry if I sound out of the loop, I can't test the mac build myself.

I recalled correctly https://github.com/ShadowMario/FNF-PsychEngine/issues/4453

I'm not trying to be the hero, I'm trying to be the one with braincells
so just fork the engine and implement the changes yourself, there's no reason whatsoever for this to be merged, specially because ShadowMario at the current time is fixing bugs, he's not merging PRs and he probably already fixed issues with MacOS Lua

The idea with this commit is to fix text stuff from lua, correct? If I recall correctly, Mac (a supported platform) did have a bug with dialogue (I think it was about the game just not pausing during the dialogue??). Does this fix this? Was it already fixed? Sorry if I sound out of the loop, I can't test the mac build myself.

was it broken in the first place? it works fine on mine without the fix

So ur telling me your dialogue plays without the song starting?

The idea with this commit is to fix text stuff from lua, correct? If I recall correctly, Mac (a supported platform) did have a bug with dialogue (I think it was about the game just not pausing during the dialogue??). Does this fix this? Was it already fixed? Sorry if I sound out of the loop, I can't test the mac build myself.

I recalled correctly #4453
If this commit fixes this issue then this should absolutely pass.

then ig it's passing

The idea with this commit is to fix text stuff from lua, correct? If I recall correctly, Mac (a supported platform) did have a bug with dialogue (I think it was about the game just not pausing during the dialogue??). Does this fix this? Was it already fixed? Sorry if I sound out of the loop, I can't test the mac build myself.

was it broken in the first place? it works fine on mine without the fix

So ur telling me your dialogue plays without the song starting?

it plays at the exact moment it starts, blocks my inputs until the dialogue box is closed, starts the countdown and then the song
basically works as expected

💀

I'm not trying to be the hero, I'm trying to be the one with braincells

so just fork the engine and implement the changes yourself, there's no reason whatsoever for this to be merged, specially because ShadowMario at the current time is fixing bugs, he's not merging PRs and he probably already fixed issues with MacOS Lua

so this bug fix doesn't deserve to be merged?

I'm not trying to be the hero, I'm trying to be the one with braincells

so just fork the engine and implement the changes yourself, there's no reason whatsoever for this to be merged, specially because ShadowMario at the current time is fixing bugs, he's not merging PRs and he probably already fixed issues with MacOS Lua

so this bug fix doesn't deserve to be merged?

it's basically pointless if he already fixed it

I'm not trying to be the hero, I'm trying to be the one with braincells

so just fork the engine and implement the changes yourself, there's no reason whatsoever for this to be merged, specially because ShadowMario at the current time is fixing bugs, he's not merging PRs and he probably already fixed issues with MacOS Lua

so this bug fix doesn't deserve to be merged?

it's basically pointless if he already fixed it

So dialogue works perfectly on mac?

I'm not trying to be the hero, I'm trying to be the one with braincells

so just fork the engine and implement the changes yourself, there's no reason whatsoever for this to be merged, specially because ShadowMario at the current time is fixing bugs, he's not merging PRs and he probably already fixed issues with MacOS Lua

so this bug fix doesn't deserve to be merged?

it's basically pointless if he already fixed it

So dialogue works perfectly on mac?

on private builds, yes, on the current github build, probably no
I've never got into this problem

I'm not trying to be the hero, I'm trying to be the one with braincells

so just fork the engine and implement the changes yourself, there's no reason whatsoever for this to be merged, specially because ShadowMario at the current time is fixing bugs, he's not merging PRs and he probably already fixed issues with MacOS Lua

so this bug fix doesn't deserve to be merged?

it's basically pointless if he already fixed it

So dialogue works perfectly on mac?

on private builds, yes, on the current github build, probably no I've never got into this problem

that's the point

action builds are kinda poopy, its better to build it from the source code

action builds are kinda poopy, its better to build it from the source code

ikr then most of the time they give u errors

that's the point

then why merge it if at this time it's probably already fixed and ShadowMario is probably gonna merge it soon along with other changes?

that's the point

then why merge it if at this time it's probably already fixed and ShadowMario is probably gonna merge it soon along with other changes?

it's not fixed, I'm on mac this is a current bug as of rn

that's the point

then why merge it if at this time it's probably already fixed and ShadowMario is probably gonna merge it soon along with other changes?

we can wait then.

we can wait then.

my point still stands, forking the engine and implementing the PR changes is still a viable solution for fixing it temporarily at least

we can wait then.

my point still stands, forking the engine and implementing the PR changes is still a viable solution for fixing it temporarily at least

never said it wasn't I've just been sayin' this is for other platforms and not FUCKING WINDOWS

yeah I don't use windows, I actually use linux instead, dialogue works here
I tested on several windows machines, they also work there
and on my MacOS Virtual Machine (and a real macbook i tested psych), it also works perfectly fine
the thing is, I compiled those builds myself, don't know if the builds from the actions tab are even doing anything major to the compiling process

never said it wasn't I've just been sayin' this is for other platforms and not FUCKING WINDOWS

yeah I don't use windows, I actually use linux instead, dialogue works here I tested on several windows machines, they also work there and on my MacOS Virtual Machine (and a real macbook i tested psych), it also works perfectly fine
the thing is, I compiled those builds myself, don't know if the builds from the actions tab are even doing anything major to the compiling process

OH SHIT I JUST REALIZED UHHHHH what version is ur macbook running

never said it wasn't I've just been sayin' this is for other platforms and not FUCKING WINDOWS

yeah I don't use windows, I actually use linux instead, dialogue works here I tested on several windows machines, they also work there and on my MacOS Virtual Machine (and a real macbook i tested psych), it also works perfectly fine
the thing is, I compiled those builds myself, don't know if the builds from the actions tab are even doing anything major to the compiling process

OH SHIT I JUST REALIZED UHHHHH what version is ur macbook running

MacOS Big Sur (both the macbook and the Virtual Machine)

never said it wasn't I've just been sayin' this is for other platforms and not FUCKING WINDOWS

yeah I don't use windows, I actually use linux instead, dialogue works here I tested on several windows machines, they also work there and on my MacOS Virtual Machine (and a real macbook i tested psych), it also works perfectly fine
the thing is, I compiled those builds myself, don't know if the builds from the actions tab are even doing anything major to the compiling process

OH SHIT I JUST REALIZED UHHHHH what version is ur macbook running

MacOS Big Sur (both the macbook and the Virtual Machine)

okkkkkkk I get it so new software updates and new macs have FUCKED dialogue since new code and software I'm so sorry i never knew this was like this

Twitter be like:

I won't break Lua for adding compatibility to a build i don't support.
If you want to fix dialogues so much on other builds, set "inCutscene" to true.

1- Lua already works on Mac without your "fix" 2- Android is not officially supported 3- this is unnecessary
period.

1.

2. Android is supported just needs a little fixing.

3.


Quarry How to

so i running the bevo mod pack and saw that nuclearcraft had a quarry that did not require super expensive things tho i dont see how to use it after i made it. and looking all over there is not even a hint to it so any chance you can tell me how to use it. ill keep looking for info but doubt ill find any

I have also seen others use that pack, and for some reason I can't understand at all, that block is being called the quarry, when it should be called a 'machine block'. It's not actually a quarry - it's just a base block used to make some machines. In the language files, the block is definitely named 'machine block' - in every other pack I've played, it works normally, but for some reason, in that pack there's a strange incompatibility somewhere playing silly tricks :P
Sorry for the confusion!

Ahh that's my fault because people were looking for the Buildcraft quarry and that was in the pack as machine block lol so I renamed it :D


refactor: use float div&ceil to avoid unstable features

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
When using our code base with those repos requires stable toolchains, like vector, unstable features block its compilation. This patch removes replaceable unstable feature in time module.
Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Just ported rust stdlib's impl of div_ceil and add reproducible test case from @v0y4g3r


feat(jsii-dotnet-runtime): Improve .NET Performance

The .NET runtime performace has been enhanced by adding an Assembly Load cache to JsiiTypeAttributeBase to avoid expensive repeated
use of reflection and file system access.
Compliance tests now share a client to speed up execution and avoid problems with cache usage.
.NET integration tests now hard-reference the .NET runtime project, and has been added to the runtime solution. There is no disadvantage to doing this,
and it makes development easier.
Resolves #304
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Rough metrics, a CI/CD pipeline (CodeCommit/CodeBuild/CodePipeline):
Before: 10.535 seconds
After: 0.932 seconds


Feature/roko/profile and config

WIP
Adds Profile Commands:
    ProfileCommand,
    ProfileListCommand,
    ProfileShowCommand,
    ProfileDeleteCommand,
    ProfileSetValueCommand,
    ProfileDeleteValueCommand,
    ProfileSetCommand

Usage:
$ btcli profile create
$ btcli p create

WIP

Input Needed on Handling value precedence. Args Parser vs. Profile Config.
Status Quo:
Implemented: Profile Commands
(Ticket #7 ROKOxBittensor Project Board)
Implemented: Parameter Overlay via Merging Strategy as Outined in Ticket
(Ticket #3 ROKOxBittensor Project Board)
https://github.com/opentensor/bittensor/pull/2105/files#diff-373be912eb8f8235ff39a9568ef098023b56c305a2e0b5d4c92b8d2d314e8109R252
issue Description: What is the preferred way we should implement this? Input needed from Bittensor:
Currently default values are written into the config using a check via the __is_set function if they are default values.
https://github.com/opentensor/bittensor/pull/2105/files#diff-373be912eb8f8235ff39a9568ef098023b56c305a2e0b5d4c92b8d2d314e8109R432
We are adding more configs now (generic, profile, command line args)
Because of the way the Argument Parser works and since Arguments should always have precedence over Profile simply merging the profile config does not work as intended.
We can either change the commands like create, delete etc. to always prompt the user which to us (Bad UX)
vs.
Complete Refactoring of the Parameter handling
Solution #1 (hacky and not clean, worse user experience)
Go through the Commands and always ask which wallet etc. should be used.
This is bad for UX since the reason we use Profile should make it less work and "just work"
e.g.:
btcli wallet balance should just print the balance of the set wallet in profile or manually set wallet via args.
Solution #2 (clean but deeper codebase changes, better UX)
Refactor Argument Parser.
Cleaner Solution but changes the behavior of the Argument Parser which makes changes in almost all CLI related files necessary.
Doing this could also Refactor other things like Config Initialisation which is done x4 times right now.


SendInput for mouse movement on Windows

Short overview
The current implementation uses SetCursorPos for mouse movment.
We might consider using SendInput like we do for scrolling and keyboard input.
Use case
Automating multimedia applications like e.g. games
Detailed description
As reported in https://github.com/nut-tree/nut.js/issues/168 it is currently not possible to cause in-game mouse movement with nut.js, although desktop mouse movement works fine.
A possible reason for this could be the usage of SetCursorPos instead of SendInput.
Following the above mentioned docs it seems like SetCursorPos is more desktop centered, whereas SendInput actually inserts events into the keyboard and mouse inputstream.

I have done a crude test to see if I could get SendInput working
This works for relative movements only
void moveMouseRelative(MMPoint point)
{
	// SetCursorPos ((int)point.x, (int)point.y);

        INPUT mouseInput;

	mouseInput.type = INPUT_MOUSE;
	mouseInput.mi.dx = (int)point.x;
	mouseInput.mi.dy = (int)point.y;
	mouseInput.mi.mouseData = 0;
	mouseInput.mi.time = 0;
        mouseInput.mi.dwFlags = MOUSEEVENTF_MOVE;
        mouseInput.mi.dwExtraInfo = 0;
	SendInput(1, &mouseInput, sizeof(mouseInput));
}

I explored how that snippet could be adapted to work for absolute positioning on the display

int CalculateAbsoluteCoordinateX(int x)
{
	MMSize displaySize = getMainDisplaySize();
        return (x * 65536) / displaySize.width;
}

int CalculateAbsoluteCoordinateY(int y)
{
	MMSize displaySize = getMainDisplaySize();
        return (y * 65536) / displaySize.height;
}

void moveMouseAbsolute(MMPoint point)
{
	// SetCursorPos ((int)point.x, (int)point.y);

        INPUT mouseInput;

	mouseInput.type = INPUT_MOUSE;
	mouseInput.mi.dx = (int) CalculateAbsoluteCoordinateX(point.x);
	mouseInput.mi.dy = (int) CalculateAbsoluteCoordinateY(point.y);
	mouseInput.mi.mouseData = 0;
	mouseInput.mi.time = 0;
        mouseInput.mi.dwFlags = MouseEventFlags.MOUSEEVENTF_MOVE | MouseEventFlags.MOUSEEVENTF_ABSOLUTE;
        mouseInput.mi.dwExtraInfo = 0;
	SendInput(1, &mouseInput, sizeof(mouseInput));
}

I don't know if you would want to create some more methods within mouse.c or modify the existing moveMouse method and maybe add some flags on the params.
I have not thoroughly tested platform support but it works well on Windows 10 for me locally.
This script has some great examples in it
https://github.com/npocmaka/batch.scripts/blob/master/hybrids/.net/c/mouse.bat
I don't mind raising a PR but this is only prototype code and not very production friendly. I can work on it more if you want

Hi @Reiss-Cashmore 👋
Just modify the moveMouse implementation using SendInput and dwFlags set to MOUSEEVENTF_ABSOLUTE
Thanks for your support!


Added SelectableTextView to TextField & TextView

Project URL
https://github.com/jhurray/SelectableTextView
Description
Added SelectableTextView to TextField & TextView
Why it should be included to awesome-ios (optional)
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

Thank you for contributing to awesome-ios 😄


Unify validate_output logic in CompletenessCheckingStore and CacheLookupScheduler

Description
We have duplicated work in CacheLookupScheduler and CompletenessCheckingStore.
To resolve this, I removed the validation logic in CacheLookupScheduler and instead make it have CompletenessCheckingStore always.
Fixes #677
Type of change
Please delete options that aren't relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] This change requires a documentation update

Checklist

[x] Updated documentation if needed
[x] Tests added/amended
[x] bazel test //...  passes locally
[x] PR is contained in a single commit, using git amend see some docs

This change is

I hope you to review this. cc: @allada.


[FR] Add one sentence to get temperature by entity name and optional …

…area
response also added to the related test

Closed because of issue in test file


Make ComponentDescriptor const

What problem does this solve or what need does it fill?
The ComponentDescriptor is always the same for each component type.
What solution would you like?
Create an associated constant on the Component and Resource trait, which stores the existing information.
Constify all of the methods on ComponentDescriptor, then use those to initialize this information at compile-time.
We can also do this for NonSend resources by creating a simple trait for them.
What alternative(s) have you considered?
Enable the feature flags and do it now!
Additional context
This is blocked by several (!) unstable rustc features.

trait bounds other than Sized on const fn parameters are unstable
std::any::type_name is not yet stable as a const fn
TypeId::of is not yet stable as a const fn
function pointer casts are not allowed in constant functions

https://github.com/rust-lang/rust/issues/57563 is the relevant tracking issue

Additional context
This is blocked by several (!) unstable rustc features.

trait bounds other than Sized on const fn parameters are unstable

std::any::type_name is not yet stable as a const fn

TypeId::of is not yet stable as a const fn

function pointer casts are not allowed in constant functions

As of writing, 2. and 3. have been const-ified. 1. is allowed for declaration, but not for usage in the function (until const traits). Unsure of 4..

const std::any::type_name is still unstable and so is const TypeId::of.  Marking this as blocked again.


Compatibility improvements and new onFinish event

Hi John,
I added some compatibility improvements regarding to:

IE 9 CORS request
Compatibility with new Google Chrome 46+ (See details in https://code.google.com/p/chromium/issues/detail?id=549103)

I added the "onFinish" event, that allow to know when the VAST requests was finished and also I improved the CORS request in order to accept cookies (VAST providers usually inject cookies for metrics purposes).

Hi @juanparati,
Thanks for the PR. A couple of comments;

First, please split this into multiple PRs, one for each change you want to merge. For example, 326154f72e5438a29f97199dc363f7c3e98e7197 contains at least three independent changes.
Please rebase your changes on master to avoid merge conflicts.
I will not merge the XDomainRequest stuff, as this feature has been dropped by IE (>=10), and is not on any standards track. Instead, XMLHttpRequest should be used, which already checks for CORS headers.
I don't see why you feel the need for onFinish? Why is onFetched not sufficient?
The Chrome compatibility I'm happy to merge. @Fire-Brand is also working on this in #20, but I'm still waiting for him to clean up the PR, so if you do it first, I'll merge yours.

Hi @jonhoo,
I believe my PR resolved that issue with namespaceURI  on #20, didn't it?

@Fire-Brand: yes, it resolves the issue, but you haven't cleaned up the PR yet (it is still two changes in one).

Haven't you merged both my pr1 and pr2 ?

You haven't submitted them as PRs as far as I can tell?

I think that adding the request.withCredentials = true; by default is not a good idea.
It's enough that a one VAST provider will return the Access-Control-Allow-Origin header wild-carded, and the request will fail. You can read about a request with credentials here
It will be better to set it as with some flag, maybe by adding an options object in the queryVAST() function.

For some Ads providers is quite important to inject cookies to users. They use the cookies for metrics and retargeting purposes. The only issue using "withCredentials" is that XMLHttpRequest will not work with IE9, this is the reason why I submitted a workaround for IE9.
I also observed that big Ad providers Live Rail, Almedia and Tremor Video uses "Access-Control-Allow-Origin". The Ad providers and Ad propagators usually require to specify the domains where the Advertisement is published, and this is reflected in the "Access-Controll-Allow-Origin".
I think that we should keep "withCredentials" with value equal to "true" by default and as you proposed we can also add a parameter in order to change the "withCredentials" value.
NOTE: If we use "withCredentials" the XMLHttpRequest will miserably fail in IE9, however we can use XDomainRequest for this old web browser.

@jonhoo : Regarding to the "onFinish" event, I think that is quite important, The reason is that sometimes the Ad provider send empty VAST documents (without linear and non-linear ads), so the "onFetched" and "onError" event is never raise. If you implement VAST in a video player that should start to play when the Ad is returned, the video player can wait until the infinity waiting for "onFetched" call.
In order to avoid the "infinity waiting" problem I had two solutions:

Implement a timer mechanism, that wait 3 or 4 second for the onFetched event
Just to wait by "onError", "onFetched" or "onFinished"

The first solution is quite dirty and it will not work on mobile devices, because mobile devices require human intervention in order to play videos (You cannot autoplay videos in mobile devices, it is an intentional limitation), in the moment that you attach a timer to the "Play" button click event, the video play will become broken. This is the reason why is so quite important to have an "onFinished" event.

@juanparati I agree that cookies are important and should be added to this library. Nevertheless, I think that this breaks the default behavior currently used, and could lead to dangerous behavior if you already use providers that do not support it.

Re CORS: I'm happy to add withCredentials: true as the default, and add an option to not include cookies. However, I will not also merge the IE9 workaround. It is estimated that IE<10 has an estimated market share of ~2%, and it's dropping quickly. People who absolutely rely on supporting older versions should maintain this workaround themselves.
Re onFinish: Is there a good reason not to simply replace onFetched with onFinish, and have it also fire in the case where there are no ads?

I think that to use onFetched also as onFinish is also a fair solution, so for example if Ad is not retrieved it the onFetched callback can return "null".

Yeah, something like that. This will break the promise in the existing documentation for onAdsAvailable though, so that will have to change too.

#34 should help with parts of this.


[6.x] Update CHANGELOG-6.x.md

This is actually a bugfix and not a new feature. It should have worked like this before.
Ping @TBlindaruk

@driesvints ,
hm ok


subscribe on change, action always undefined

Hi
I'm using subscribe on change and trigger a ajax call when a range is selected (meaning when two dates is selected)
However I need to set the initial range when the page is loaded, I figured that I could use action to no trigger an ajax call when using setSelected but the "action" argument is always undefined.
So the change is triggered and the ajax call is called. Why are the action always undefined?

Honestly, I don't know why the example in the readme shows an action argument, there's nothing in the source that could ever populate that argument and nothing in the docs to indicate what that value could hold.  Perhaps that was an idea that I had explored and then changed my mind about.
I'll update the readme to remove that.


Clean up AWS credentials

The credential has been revoked to be replaced by OIDC https://github.com/pytorch/test-infra/pull/4865

Hi @huydhn - thank you for the PR. Are cases such as the following also affected? These workflows seem to be failing as well on recent runs:
Failure for below GHA
https://github.com/pytorch/TensorRT/blob/7578fa8b1498e1bfd6fef2bb82dd14476b0f2ecb/.github/workflows/assigner.yml#L27
Failure for below GHA
https://github.com/pytorch/TensorRT/blob/7578fa8b1498e1bfd6fef2bb82dd14476b0f2ecb/.github/workflows/label.yml#L19

Hi @huydhn - thank you for the PR. Are cases such as the following also affected? These workflows seem to be failing as well on recent runs: Failure for below GHA
https://github.com/pytorch/TensorRT/blob/7578fa8b1498e1bfd6fef2bb82dd14476b0f2ecb/.github/workflows/assigner.yml#L27
Failure for below GHA
https://github.com/pytorch/TensorRT/blob/7578fa8b1498e1bfd6fef2bb82dd14476b0f2ecb/.github/workflows/label.yml#L19

Oh, they need to be fixes, but in a different ways by granting write access to the token.  The context here is that the token default write access has been revoked, so they will need to be grant explicitly.  Let me submit a PR real quick.

@gs-olive This should help fix the issue https://github.com/pytorch/TensorRT/pull/2591

Great - thank you for adding that PR! Will take a look

Opps, I think I accidentally closed this when merging https://github.com/pytorch/TensorRT/pull/2591, will create another PR to replace this one then


Icons are missing hover text for screen readers

There should be default hover text for each button/icon for screen readers. There should be a way to set custom hover text for each icon (to support multiple languages).

Yes, it is missing the hover text on the toolbar buttons. For this, I simply created a custom toolbar and added title attribute.
`const CustomToolbar = () => (

 e.persist()}>

);
const EditorModule = {
toolbar: {
container: '#toolbar',
},
clipboard: {
matchVisual: false,
},
};
<>

<ReactQuill
value={this.state.value}
onChange={this._onChange}
modules={EditorModule}
theme={'snow'} // pass false to use minimal theme
/>
</>
`

Yes, it is missing the hover text on the toolbar buttons. For this, I simply created a custom toolbar and added title attribute.
`const CustomToolbar = () => (

 e.persist()}>

);
const EditorModule = {
toolbar: {
container: '#toolbar',
},
clipboard: {
matchVisual: false,
},
};
<>

<ReactQuill
value={this.state.value}
onChange={this._onChange}
modules={EditorModule}
theme={'snow'} // pass false to use minimal theme
/>
</>
`

This should be raised upstream in Quill, since the DOM is created by Quill, not the wrapper

This should be raised upstream in Quill, since the DOM is created by Quill, not the wrapper


Simplify NavigationData to remove ArrayObject feature

I just remembered, we need ArrayObject so it can be accessed using front matter like this: ->get('navigation.priority')


add ability to be backed by redis

Why not by some standard caching API?  Sounds like WL might need to write a spec for cache plugins :)

Hey @tjwebb, are you using sails with Redis? Are you willing to contribute to sails-redis? The other day I found out that the sails-redis integration tests are not running at all and still return 0. This is going on for some time... I've issued PR balderdashy/sails-redis#64 but nobody replied... :disappointed:

Oh, yikes. I'm only using it for session store, but I will have more time after May 4 to work more directly on development


Make IntegrationTesting not depend on M.A.Hosting.Abstractions

Fixes https://github.com/aspnet/AspNetCore/issues/14085
The Microsoft.AspNetCore.Server.IntegrationTesting package depends on Microsoft.AspNetCore.Hosting.Abstractions. If someone were referencing the integration testing package outside of AspNetCore, it would be broken as there is a missing dependency. This is exactly what the benchmarks repo was doing to pull in ANCM. It takes a dependency on this package to pull in ANCM into the right location, sxs with the app: https://github.com/aspnet/Benchmarks/blob/master/src/Benchmarks/Benchmarks.csproj#L70. So if we can remove the dependency on M.A.Hosting.Abstractions, we can now use this package outside of the repo.
This package only used M.A.Hosting.Abstractions for a single, one-line extension method. I decided to remove it and create a helper class instead.
Few things:

I'd rather not create a separate internal package to carry ANCM at this point. We have custom logic in the csprojs to copy ANCM to the right locations on publish and on pack: https://github.com/aspnet/AspNetCore/blob/master/src/Servers/IIS/IntegrationTesting.IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj#L45.

@sebastienros I'll need some help verifying this change on Benchmarks.
Also, this change should be backported to 3.x

Not that easy to test, as the issue occurs during build, and ideally you would put this patched assembly in the output folder once the app is published. We'll have to wait for a build to be available on a feed and use this specific aspnet version to test.

We'll have to wait for a build to be available on a feed and use this specific aspnet version to test.

I came up with the same conclusion, unfortunately. One thing I tried to do was remove the package reference in benchmarks.csproj and use --output-file on the ANCM folder, but that failed, reporting an empty failure.

One thing however, would be to create a refrence to a local .dll file, and use --build-file [path_to_local_file] such that your local file would be pushed on the same folder as the csproj on the server, before the build, so your project can reference it. Or add it to your branch yourself and reference it locally.

I'm surprised that was the only reference.

I verified that there are no dependencies in AspNetCore for the integration testing package, meaning the error we were seeing should be gone. I wasn't able to verify that benchmarks works by referencing this package as the package isn't published yet. So I'd prefer to actually publish this package via merging with master first and then verifying benchmarks. Afterwards, I can make a PR to 3.0/3.1 to fix it there as well. Everything else has been solved (see https://github.com/aspnet/Benchmarks/pull/1415).


remove optional usage from protobuf messages, remove unused RenameDatabaseObjectRequest and RenameDatabaseObjectResponse

Please re-generate the frontend bindings (npm run generate:runtime-client -w web-common) and wait for CI to pass, then we can merge this

Actually, I just did it. Will merge when CI passes


cmake: Support specifying Kconfig options on the CLI

NB: This replaces the original #8458 PR (was not able to re-open it).
This resolves #5723 by adding support for assigning to Kconfig options
from the CMake CLI.
CMake CLI Kconfig options can be specified like so:
'cmake -DCONFIG_ASSERT=y'
The lifetime of such an option is the same as the lifetime of a CMake
cache variable, and in principle any method of populating the
CMakeCache could be used, such as cmake-gui.
This has been implemented by scanning the CMakeCache variables before
Kconfig is executed and writing any that are prefixed with 'CONFIG_'
to a new Kconfig fragment in the build directory that is merged in
with a high precedence.
Signed-off-by: Sebastian Bøe<EMAIL_ADDRESS>

Codecov Report

Merging #8487 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8487   +/-   ##
=======================================
  Coverage   64.61%   64.61%
=======================================
  Files         421      421
  Lines       40296    40296
  Branches     6803     6803
=======================================
  Hits        26037    26037
  Misses      11126    11126
  Partials     3133     3133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f61f09...604a796. Read the comment docs.


set MANTL_API_MARATHON_PASSWORD to use an encrypted password

Is there a way to have MANTL_API_MARATHON_PASSWORD https://github.com/CiscoCloud/microservices-infrastructure/blob/master/roles/marathon/templates/mantl-api.json.j2 use an encrypted password or use another form of authentication?
The clear text password shows up in the Marathon UI, which could be a potential (minor) security issue.

I can think of a few options off the top of my head:

Currently, the iptables rules block access to the non-proxied Marathon api at :18080 on worker nodes within the cluster. If mantl-api was able to reach that, we wouldn't need a password. Perhaps the consul-template can be adjusted to discover mantl-api and allow access.

Move mantl-api out of marathon and onto a control node.

Use Vault. Perhaps this would be a good opportunity to start using Vault internally in the cluster?

yes +1 on Vault

I'd like to see Vault as well, seems like a good opportunity.

Right now, effective Vault integration is somewhat tricky.
Problem
With sudo access, anyone can run docker inspect, and get the Mesos secret and Marathon password
Solution: Wrapped Token
Really, what we ought to do is use Vault's cubbyhole backend, and pass a wrapped token into the container with an environment variable. That way, mantl-api can read the real token from vault, and use that token to read the secrets.
Issue: Ephemeral container
Unfortunately, if Marathon restarted mantl-api after it had read from the cubbyhole, the new instance couldn't read the real token (which is good, otherwise this wouldn't really add security).
Now, what if we could somehow make a new wrapped token when mantl-api were restarted? If the control nodes could authenticate with marathon (via #1578 or similar), they could lease a new wrapped token. Unforunately, this brings us right back to the above problem: if someone could log in as root (or really, as anyone) on a control node, they could easily write themselves a token and retrieve the secrets.
Root of the problem
The real issue is that some (probably persistent) system needs to (automatically) authenticate with Vault and provide a new wrapped secret to each mantl-api container as they are created. This reduces the surface of attack to that system. Optimally, this would be Mesos or Marathon, which should never themselves be restarted. Unfortunately, I'm not aware of any Mesos/Marathon/K8s/Vault integrations.
Temporary workaround
At the very least, we can store the Mesos and Marathon secrets in Vault, passing a persistent token into the mantl-api container via an environment variable. That way, we can revoke that token's access if we are aware that someone has unauthorized access to a node, and they don't immediately gain access to Marathon and Mesos as well.
This adds a little security by obscurity, prepares us for a future with better Vault integration, and allows us to take action if we've detected an intrusion.

Alternate conclusion
As @ChrisAubuchon pointed out, we would have to renew the token regularly (which is somewhat infeasible). We really need scheduler integration, period. Looks like vault-gatekeeper-mesos might be the best candidate, I'll look into integrating it tomorrow.

Update: We're waiting on https://github.com/ChannelMeter/vault-gatekeeper-mesos/pull/5, which will update vault-gatekeeper-mesos to be able to use Vault's new response wrapping API.


Misleading legal disclosures, and missing jurisdictions in multiple places

Which Cloudflare product does this pertain to?
<IP_ADDRESS>
Existing documentation URL(s)
https://developers.cloudflare.com/<IP_ADDRESS>/privacy/public-dns-resolver/
https://www.cloudflare.com/transparency/
Section that requires update
Wording around disclosures and government
What needs to change?
This URL: https://developers.cloudflare.com/<IP_ADDRESS>/privacy/public-dns-resolver/
fails to disclose the jurisdiction that apply to statements it makes, particularly those relating to the term "legal".
e.g. "We also commit to documenting any government request to block access in our semi-annual transparency report, unless legally prohibited from doing so."
If, for example, you're based in the USA, and you get an access demand from Australia along with a gag order, Australian law does NOT APPLY in the USA, so such a request would NOT "legally prevent" you from disclosing it.
Thus, it is important that your policy informs users what jurisdiction you are in, so we can understand the global extent of any gag orders you get.
Also - see below about your "Things we have never done" misleading statements (if they're not yet misleading, as soon as you're gagged and unhallowed to remove them, they then become so)
How should it change?
"Canaries" are illegal in many countries - you can go to Jail for a VERY long time if you take any action that reveals a gag order (e.g. saying you got one is illegal obviously, and equally-so nowadays is stopping the saying of a statement that you did not get one).
You need to CLEARLY declare what exact STATE and FEDERAL jurisdiction applies to you, so everyone can understand the truth of your statements, and if you're in a place (e.g. Australia) with serious criminal consequences for gag-order/canary violations, you need to spell those out along with your statements, so we know whether or not it's even possible for them to be true, and you need to do this BEFORE you get a gag order, because afterwards is criminal.
I'm referring to these, which (if you got a gar order) would never be allowed to change or remove, even when they're no longer true:-
SOME THINGS WE HAVE NEVER DONE
Cloudflare has never turned over our encryption or authentication keys or our customers' encryption or authentication keys to anyone.
Cloudflare has never installed any law enforcement software or equipment anywhere on our network.
Cloudflare has never provided any law enforcement organization a feed of our customers' content transiting our network.
Cloudflare has never modified customer content at the request of law enforcement or another third party.
Cloudflare has never modified the intended destination of DNS responses at the request of law enforcement or another third party.
Cloudflare has never weakened, compromised, or subverted any of its encryption at the request of law enforcement or another third party.
Additional information
Someone fraudulently closed my earlier similar report: https://github.com/cloudflare/cloudflare-docs/issues/4350
This is a SERIOUS legal request.  Please fix it properly using lawyers, instead of just closing it and spitting in the face of everyone you're pretending to be transparent with.

Our public position on this is detailed in our transparency report: https://cf-assets.www.cloudflare.com/slt3lc6tev37/7JOzEbaUD1HVuYjqm1Ymc7/a3d7c3b1a5217a008b3d24a45d55f661/Transparency-Report-2H_2021.pdf — I am linking this again with intent, through discussion with our Legal & Policy teams.

Cloudflare has also received a small number of legal
requests related to blocking or filtering content
through the <IP_ADDRESS> Public DNS Resolver. Because
such a block would apply globally to all users of
the resolver, regardless of where they are located,
it would affect end users outside of the blocking
government’s jurisdiction. We therefore evaluate
any government requests or court orders to block
content through a globally available public
recursive resolver as requests or orders to block
content globally.
Given the broad extraterritorial effect, as well as the
different global approaches to DNS-based blocking,
Cloudflare has pursued legal remedies before
complying with requests to block access to
domains or content through the <IP_ADDRESS> Public
DNS Resolver or identified alternate mechanisms
to comply with relevant court orders. To date,
Cloudflare has not blocked content through the <IP_ADDRESS>
Public DNS Resolver.


Improve Workflow for Stabilization Plane

Does this affect the legacy HoloToolkit (master) or the Mixed Reality Toolkit (mrtk_release)?
Mixed Reality Toolkit
Is your feature request related to a problem? Please describe.
As stated in the documentation here:

On a HoloLens running the Windows 10 April 2018 Update or later, (turning on "Enable Depth Buffer Sharing") will analyze the depth buffer to pick an optimal stabilization plane automatically.

That article incorrectly states that it's turned on by default now, but I see #1939 proposed to address this issue. (And I support that change.)
Regardless of whether or not #1939 gets implemented, we need to provide better guidance about what to do when Depth Buffer Sharing is turned on. In fact, what should be done to the MRTK when this is enabled? Should StabilizationPlaneModifier be disabled entirely? Should it's SetStabilizationPlane field be set to false? And what changes, if any, should be made to the InputManager prefab?
At the very least, I feel something should be added to the Apply Mixed Reality Project Settings screen that describes this option. Ideally there would be something that prompts the user to see if all of their devices will be running RS4 or later and changes the settings accordingly.

@jbienzms We don't have the same settings configuration screen in vNEXT, but we can add it to the prompt when importing the first time.
It's a bit strange to grab the SDK and set this property on it, but it is possible to set.

Also FYI #5319