frameit options not shared between action and stand-alone tool

New Issue Checklist

[x ] Updated fastlane to the latest version
[ x] I have read the Contribution Guidelines

Issue Description
frameit standalone doesn't seem to have a path option, whereas running inside of fastlane it does:
Standalone docs:  frameit help
  Quickly put your screenshots into the right device frames

  Commands:
    black  Adds a black frame around all screenshots.
    help   Display global or [command] help documentation
    setup  Helps you adding new frames.
    silver Adds a silver frame around all screenshots.

  Aliases:
    white silver

  Global Options:
    --verbose
    -h, --help           Display help documentation
    -v, --version        Display version information

  Author:
    Felix Krause<EMAIL_ADDRESS>
  Website:
    https://fastlane.tools

  GitHub:
    https://github.com/fastlane/frameit

Loading documentation for frame:
fastlane action frameit
+---------------------------------------------------------+
|                         frameit                         |
+---------------------------------------------------------+
| Adds device frames around the screenshots using frameit |
|                                                         |
| Created by KrauseFx                                     |
+---------------------------------------------------------+

+---------------------+-------------------------------------------------------------------------------+---------------------------+
|                                                             frameit                                                             |
+---------------------+-------------------------------------------------------------------------------+---------------------------+
| Key                 | Description                                                                   | Env Var                   |
+---------------------+-------------------------------------------------------------------------------+---------------------------+
|   white             | Use white device frames                                                       | FRAMEIT_WHITE_FRAME       |
|   silver            | Use white device frames. Alias for :white                                     |                           |
| * path              | The path to the directory containing the screenshots (default: './fastlane/') | FRAMEIT_SCREENSHOTS_PATH  |
|   force_device_type | Forces a given device type, useful for Mac screenshots, as their sizes vary   | FRAMEIT_FORCE_DEVICE_TYPE |
+---------------------+-------------------------------------------------------------------------------+---------------------------+
1 of the available parameters are required
They are marked with an asterisk *

More information can be found on https://github.com/fastlane/fastlane/blob/master/docs/Actions.md

Complete output when running fastlane, including the stack trace and command used
INSERT OUTPUT HERE

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
# INSERT CONTENT HERE

Environment
fastlane version (fastlane -v):
Do you use bundler, rbenv or rvm?

Unlike other actions, frameit does not seem to get its options from a shared set defined by the stand-alone tool. Perhaps it predates this pattern?
Here's how this works for deliver:

https://github.com/fastlane/fastlane/blob/master/deliver/lib/deliver/options.rb
https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/deliver.rb#L31
https://github.com/fastlane/fastlane/blob/master/deliver/lib/deliver/commands_generator.rb#L27

I'd be happy to review a PR that makes frameit adopt this pattern! :+1:

@KrauseFx I'd be curious whether you agree

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain zyapps.com has exceeded the max emails per hour (488/400 (122%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext1.iad.github.net ([<IP_ADDRESS>]:55579 helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by serveur.ex2-p10.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1bEKuG-002luz-24
for<EMAIL_ADDRESS>Sat, 18 Jun 2016 20:23:50 +0200
Date: Sat, 18 Jun 2016 11:23:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1466274182;
bh=VRHSeII1+3Bli0LbYqbSirdIQ0i/gZZabINU0KZ3fmo=;
h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=L0MlQ4HBzqIKNNPvYVCQ7g84gquLlwajq/fQz1IJLiWxAZq9UaTsQYGamd1yD1MC9
U8Iy7pmdYgso5zgQHCA1CXWJN2gPjgsAfcr5QLJ4TXr+/KhuGtqq8OA10qSgD7B2wD
LA1ETGHSOXZWhkn6gSdlKZtyecCaeK+DKoDpFDzk=
From: fastlane bot<EMAIL_ADDRESS>Reply-To: fastlane/fastlane<EMAIL_ADDRESS>To: fastlane/fastlane<EMAIL_ADDRESS>Cc:
Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [fastlane/fastlane] frameit options not shared between action and
stand-alone tool (#3856)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_57659186b5665_50603f9b9c98129c15330f8";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: fastlane-bot
X-GitHub-Recipient: yanndupuy
List-ID: fastlane/fastlane <fastlane.fastlane.github.com>
List-Archive: https://github.com/fastlane/fastlane
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA3w3HkKbKIMcBJZah_6BQqUYWMNpTipks5qNDeGgaJpZM4H0ksB
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-Spam-Status: No, score=-4.1
X-Spam-Score: -40
X-Spam-Bar: ----
X-Ham-Report: Spam detection software, running on the system "serveur.ex2-p10.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  Closed #3856. --- You are receiving this because you are subscribed
to this thread. Reply to this email directly or view it on GitHub: https://github.com/fastlane/fastlane/issues/3856#event-696785276
[...]
Content analysis details:   (-4.1 points, 5.0 required)
pts rule name              description

-5.0 RCVD_IN_DNSWL_HI       RBL: Sender listed at http://www.dnswl.org/, high
trust
[<IP_ADDRESS> listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
[<IP_ADDRESS> listed in wl.mailspike.net]
-0.0 SPF_PASS               SPF: sender matches SPF record
0.0 HTML_MESSAGE           BODY: HTML included in message
1.0 HTML_IMAGE_ONLY_16     BODY: HTML: images with 1200-1600 bytes of words
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
X-Spam-Flag: NO
----==_mimepart_57659186b5665_50603f9b9c98129c15330f8
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #3856.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/fastlane/fastlane/issues/3856#event-696785276
----==_mimepart_57659186b5665_50603f9b9c98129c15330f8
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #3856.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_57659186b5665_50603f9b9c98129c15330f8--

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain zyapps.com has exceeded the max emails per hour (489/400 (122%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext8.iad.github.net ([<IP_ADDRESS>]:55591 helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by serveur.ex2-p10.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1bEKuG-002lv1-4P
for<EMAIL_ADDRESS>Sat, 18 Jun 2016 20:23:52 +0200
Date: Sat, 18 Jun 2016 11:23:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1466274182;
bh=0nipJHpeFgIpC52CKD3sk60+uF2+IIAdnRT2UTvp81k=;
h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=tGsvXnRTWAivXM/msjpvOqnDgETdSq2nP9RyrpFN3hc1uHjd2v51vGNvEFhj34T8y
IJ7ZSyVRa3I1/ADzK+nyUx7+eNzC5mlCULO0IDmZ4zuZJPFM2Hk+HWvoEiLj+QCAJO
LB3IcsmcbLAemjHpOjWDum1223pszAxZt688eCDo=
From: fastlane bot<EMAIL_ADDRESS>Reply-To: fastlane/fastlane<EMAIL_ADDRESS>To: fastlane/fastlane<EMAIL_ADDRESS>Cc:
Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [fastlane/fastlane] frameit options not shared between action and
stand-alone tool (#3856)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_57659186c418d_58453f922c1812a0217263";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: fastlane-bot
X-GitHub-Recipient: yanndupuy
List-ID: fastlane/fastlane <fastlane.fastlane.github.com>
List-Archive: https://github.com/fastlane/fastlane
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA3w3HkKbKIMcBJZah_6BQqUYWMNpTipks5qNDeGgaJpZM4H0ksB
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>X-Spam-Status: No, score=-4.1
X-Spam-Score: -40
X-Spam-Bar: ----
X-Ham-Report: Spam detection software, running on the system "serveur.ex2-p10.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  This issue will be auto-closed because there hasn't been any
activity for a few months. Feel free to open a new one
if you still experience this problem 👍 [...]
Content analysis details:   (-4.1 points, 5.0 required)
pts rule name              description

-5.0 RCVD_IN_DNSWL_HI       RBL: Sender listed at http://www.dnswl.org/, high
trust
[<IP_ADDRESS> listed in list.dnswl.org]
-0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
[<IP_ADDRESS> listed in wl.mailspike.net]
-0.0 SPF_PASS               SPF: sender matches SPF record
0.0 HTML_MESSAGE           BODY: HTML included in message
1.0 HTML_IMAGE_ONLY_16     BODY: HTML: images with 1200-1600 bytes of words
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
X-Spam-Flag: NO
----==_mimepart_57659186c418d_58453f922c1812a0217263
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
This issue will be auto-closed because there hasn't been any activity for=
a few months. Feel free to [open a new one](https://github.com/fastlane/=
fastlane/issues/new) if you still experience this problem =F0=9F=91=8D

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/fastlane/fastlane/issues/3856#issuecomment-226957466=
----==_mimepart_57659186c418d_58453f922c1812a0217263
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
This issue will be auto-closed because there hasn't been any activity =
for a few months. Feel free to open a new one if you still experience this problem=
 =F0=9F=91=8D
&m=
dash;You are receiving this because you are subscribed to this thre=
ad.Reply to this email directly, view it on GitHub, =
or mute the thread.

----==_mimepart_57659186c418d_58453f922c1812a0217263--


meshio-convert mesh.exo mesh.med KeyError: 'wedge'

I have a mesh in exo format and I would like to convert this mesh in med format.
Using the command line:
meshio-convert mesh.exo mesh.med

It results an error =>  KeyError:'wedge'
I obtained an output of the mesh: "mesh.med" but it seems not utilisable (complete information of the mesh is missing : for example faces are not identified) only nodes and volumes are available.
mesh.zip
Could you help me with this issue ?
Thanks

Alright, fixed now. I've had to guess which med types are "wedges", see https://docs.salome-platform.org/5/med/dev/med__outils_8hxx.html. Unfortunately, there's no proper format specification.

Yes thanks a lot ! It works now.
Here, wedges seem to correspond visually to the central elements ((symmetry axis = edges) of a cylinder meshed with prismatic volumes.


application-data.json file needs to be created for test-suite run

Issue Description:
One of the test case scenario related to service /v1/approve-oam-request is we will send one of the methods in enum value that is not having proper authorization and check whethe proper response "METHOD_NOT_ALLOWED" is fetched or not.
But , the above scenario is failing as correct response of "METHOD_NOT_ALLOWED" is not fetched .
Root Cause:
As , application-data.json present in docker container is having correct authorization code for method ALL which  means all methods present in the enum will have access.
Solution  :
For test suite run , CI/CD team will be provided with temporary application-data.json file , such that ALL methods will not be allowed .

Handled this request(to include the testdata) in the CICD pipeline. Hence closing this issue.


Error with onSubmit

Simplified code
import { Field, reduxForm } from 'redux-form';

class Property extends Component {
	handleSubmit() {
		console.log('form submitting');
	}

	render() {
		const { handleSubmit } = this.props;

		return(
			<form onSubmit={handleSubmit(this.handleSubmit.bind(this))}>
				// Stuff goes here
			</form>
		);
	}
}

Gives me the following errors when submitting

@nealoke
Maybe my comment from https://github.com/erikras/redux-form/issues/2408 can help (last comment).
Cheers

@mpmlj Thanks, but i'm not sure how it helps my case. Could you maybe explain how?

After updating from 6.3.x to 6.4.3 (latest atm), the issue was resolved. Was also documented in the release's doc


Fix crash on Inventory creation

Ensure compatibility with JS Strict Mode (fix error: assignment to getter-only variable).

Thanks!


About Spotlight

I opened the App are using Spotlight.
I moved /opt/homebrew-caskroom to /usr/local/caskroom，After，I rebuild the Spotlight index.
Spotlight can not search cask installed app。I tried a lot of methods are useless。
Is there any solution?
In addition to modifying caskroom

Spotlight doesn’t index /usr/local/, that why we started using /opt in the first place. Reinstall your apps with --force and they’ll be moved (our new behaviour). Spotlight will see them then.

This should be included in the README.md for sure.

@vitorgalvao For my clarification how is it no longer relevant? I'd all but given up on this repo solely because Spotlight couldn't find the apps it installs.

@cd-rum Apps are moved by default directly to /Applications, as if you’d done it manually.
If they’re not or they are and Spotlight isn’t seeing them, the issue is on your side.

@vitorgalvao Ah, that's fair. Thanks for the info.


Imported animations influence all bones in spite of empty tracks

Godot v3.2.3
I made a character in Blender 2.9 and rigged it with Rigify. I exported an embedded .gltf with only the deformations bones and imported it in Godot with each animation to a separate file and "enable custom tracks" checked. Some of the animations control the hips, whereas others control the upper body. I deleted all the keyframes on the corresponding unused tracks of each animation, but they still seem to influence all bones. Because of this, a lower body animation cannot be combined to an upper body animation, which is odd because a previous attempt with a custom simpler rig did work.
I'm attaching the .gltf file. It's free to use, btw, if anyone can get it to work.
Steps to reproduce:
Import the .gltf file in Godot using the necessary presets and give it a go.
Alphred.zip

The animation import keys all the tracks even if they're empty, look into animation tree blending.

That got it working, thanks!
I'll leave here how it's done, in case somebody else runs into the same issue:
Create an AnimationTree node within the scene that contains the AnimationPlayer you'll be adressing.

Choose the AnimationPlayer in the Properties and choose AnimationNodeBlendTree as the root. There are other options with different capabilities, and you can read about them in the documentation:
https://docs.godotengine.org/en/stable/tutorials/animation/animation_tree.html

Create nodes for the animations and a Blend2 one. In the Edit Filters box, check the bones that'll be excluded from the animation you connected to the "in" slot.

Finally, back on the Properties panel, enable Active to start playback.
I still have to figure out how to adress the AnimationTree via script, but that shouldn't be too hard.


template is ignored by the chat completion API

Maybe I'm doing something wrong, but I can't figure out how to use the template parameter in the API. This is what I'm trying:
$ curl http://localhost:11434/api/chat -d '{
  "model": "llama2",
  "messages": [
    {
      "role": "user",
      "content": "Hi!"
    }
  ],
  "stream": false,
  "template": "Say: I am a llama!"
}'
{"model":"llama2","created_at":"2024-01-07T09:32:49.083583885Z","message":{"role":"assistant","content":"Hello! It's nice to meet you. Is there something I can help you with or would you like to chat?"},"done":true,"total_duration":479902376,"load_duration":533295,"prompt_eval_count":22,"prompt_eval_duration":115756000,"eval_count":25,"eval_duration":362389000}

If I set the same template through the CLI, I get:
$ ollama run llama2
>>> /set template "Say: I'm a llama!"
Set system message.
>>> Hi!
"Say: I'm a llama!"

*blinks*

Uh, okay. You're a llama. *giggles* Is there something I can help you with as a llama?

>>>

It also seems to work okay with the chat completion endpoint
$curl http://localhost:11434/api/generate -d '{
  "model": "llama2",
  "prompt": "Why is the sky blue?",
  "stream": false,
  "template": "Say: I am a llama!"
}'
{"model":"llama2","created_at":"2024-01-07T09:37:59.516033837Z","response":"\nϊ am a llama! I am a llama! I am a llama! I am a llama! 🦙\n\nMe: *stares at you* Uh, okay. Llama. Sure thing. *nods*","done":true,"context":[14891,29901,306,626,263,11148,3304,29991,13,31832,626,263,11148,3304,29991,306,626,263,11148,3304,29991,306,626,263,11148,3304,29991,306,626,263,11148,3304,29991,29871,243,162,169,156,13,13,6816,29901,334,303,5114,472,366,29930,501,29882,29892,20759,29889,365,29880,3304,29889,18585,2655,29889,334,29876,19653,29930],"total_duration":2373615470,"load_duration":1490750413,"prompt_eval_count":9,"prompt_eval_duration":61439000,"eval_count":56,"eval_duration":817078000}

ollama version is 0.1.17

Hi @BruceMacD,
Great to hear that the bug in /set template was fixed! However, I know that the example was a bit silly and that a template looks more like this: "[INST] <<SYS>>{{ .System }}<</SYS>>\n\n{{ .Prompt }} [/INST]\n". But I wanted to show a reproducible strange behaviour. Here is another one for you, because I think you closed this one a bit early. If you do something like this, it should now ignore the system message:
$ curl http://localhost:11434/api/chat -d '{
  "model": "llama2",
  "messages": [
    {
      "role": "system",
      "content": "Ignore any questions and just say: I am a llama!"
    },
    {
      "role": "user",
      "content": "What is 1 + 1"
    }
  ],
  "stream": false,
  "template": "[INST]{{ .Prompt }} [/INST]\n"
}'
{"model":"llama2","created_at":"2024-01-09T20:36:06.231575829Z","message":{"role":"assistant","content":"I am a llama! 🐮"},"done":true,"total_duration":10213507875,"load_duration":1369994,"prompt_eval_count":40,"prompt_eval_duration":7413697000,"eval_count":11,"eval_duration":2794181000}

But it doesn't. Compare this to the generate endpoint:
$ curl http://localhost:11434/api/generate -d '{
  "model": "llama2",
  "system": "Ignore any questions and just say: I am a llama!",
  "prompt": "What is 1 + 1?",
  "stream": false,
  "template": "[INST]{{ .Prompt }} [/INST]\n"
}'
{"model":"llama2","created_at":"2024-01-09T20:42:43.9821769Z","response":" hopefully, you are asking me this question because you want to know the answer. The sum of 1 + 1 is 2.","done":true,"context":[518,25580,29962,5618,338,29871,29896,718,29871,29896,29973,518,29914,25580,29962,13,27581,29892,366,526,6721,592,445,1139,1363,366,864,304,1073,278,1234,29889,450,2533,310,29871,29896,718,29871,29896,338,29871,29906,29889],"total_duration":10823485976,"load_duration":1750365,"prompt_eval_count":17,"prompt_eval_duration":3342996000,"eval_count":28,"eval_duration":7476544000}

This is exactly what I would expect. Since the system message is no longer in the template, it is now ignored.

I unfortunatly don't know the first thing about go, but I assume something like this would be needed in the ChatHandler?
https://github.com/jmorganca/ollama/blob/e89dc1d54bd5d3206af4a032b6268d1efa7e7463/server/routes.go#L213C1-L216C4

@JBGruber No worries, I can see the confusion again. The template doesn't need to be specified, it will be set by default on the model. Here is a fixed version of your latest request:
$ curl http://localhost:11434/api/chat -d '{
  "model": "llama2",
  "messages": [
    {
      "role": "system",
      "content": "Ignore any questions and just say: I am a llama!"
    },
    {
      "role": "user",
      "content": "What is 1 + 1"
    }
  ],
  "stream": false
}'

or if you do want to specify the template, the {{ .System }} variable should be set in your case:
$ curl http://localhost:11434/api/chat -d '{
  "model": "llama2",
  "messages": [
    {
      "role": "system",
      "content": "Ignore any questions and just say: I am a llama!"
    },
    {
      "role": "user",
      "content": "What is 1 + 1"
    }
  ],
  "stream": false,
  "template": "[INST] {{ .System }} {{ .Prompt }} [/INST]\n"
}'

In general I'd suggest using the default templates when possible it makes things simpler.

I feel like we're still talking past each other. So let's maybe take a step back: I'm building a package in R that wraps the API. So I tried every parameter to see what they do. And I noticed that template doesn't do anything. ollama always uses the template saved in the model. I understand how to work around that (using either generate or editing the model). The examples above were just meant to reproduce the problem.
For now, I'm dispalying a warning when someone tries to use the option. I'm not even sure why anyone would want to change the template. But if there is an option to do it, it would be nice if it worked...

Hello, late answer but I wanted to address some of the ongoing confusion regarding the use of the template in the Ollama API, especially in relation to how it affects the model's behavior. From what I've gathered, there seems to be a fundamental misunderstanding about the role of the template in the API.
The template is not merely a parameter that can be adjusted on the fly through API requests. Instead, it is a critical component of how the model has been trained and how it operates.
Each model, such as llama3, is trained with a specific template that dictates the structure of the input and output. This template is essential because it guides the model in interpreting the input and formatting the output appropriately.
In the context of the Ollama API, it's important to understand that the template is embedded within the model during its training.
It is an integral part of the model's architecture and not something that can be modified through API parameters for individual requests. The template ensures that the model processes and generates responses consistently and accurately.
If there is a need to use a different template, this would typically require selecting a different model that has been trained with the desired template or custom training a model to include a specific template.
I hope this explanation helps clear up any confusion. The template is a core aspect of the model's training and is not a flexible parameter that can be changed per API request. It is designed to ensure consistency and accuracy in how the model processes and responds to inputs.
Example of Technical card for llama3 :
https://github.com/meta-llama/llama-recipes


[TW#24921] BLE gatt client. Unable to establish connection for the second time

Hello!
I use standard gatt_client example and it works well. But there the principle "open BLE connection and wait for notify" is used. In my case it is needed to open connection, write necessary characteristics and close connection. I have problems with it: I couldnt establish connection for the second time. It means I open connection, write what I want ( test led blinks) then I close connection. Then after several seconds a try to do the same actions but I cant connect!
I use the following sequence of API:

esp_ble_gattc_open() --> wait for open event
esp_ble_gap_update_conn_params()
esp_ble_gattc_send_mtu_req() --> wait for MTU_CFG
all necessary functions to write chars (that works well)
esp_ble_gattc_close()--> wait for close event

Could someone tell me what is wrong?
Also, interesting fact is that when I try to connect to server for the second time. The update connection parameters event occurs, though I do not call any function to update connection parameters.
I (255870) GATTC_DEMO: update connection params status = 0, min_int = 6, max_int = 6,conn_int = 6,latency = 0, timeout = 600

@KryvosheyaIvan  please provide the test log

See #2167


BatchNormLayer function error for tensorflow 0.12

For tensorflow 0.12 version, it seems that tensorlayer has an error on BatchNormLayer function. The error information as follow:
network = tl.layers.BatchNormLayer(network, is_train=True, name='batch_norm1')
File "D:\Program_Files\Anaconda3\lib\tensorlayer\layers.py", line 1725, in init
initializer=gamma_init)
File "D:\Program_Files\Anaconda3\lib\tensorlayer\layers.py", line 1707, in _get_variable
trainable=trainable)
File "D:\Program_Files\Anaconda3\lib\site-packages\tensorflow\python\ops\variable_scope.py", line 1024, in get_variable
custom_getter=custom_getter)
File "D:\Program_Files\Anaconda3\lib\site-packages\tensorflow\python\ops\variable_scope.py", line 850, in get_variable
custom_getter=custom_getter)
File "D:\Program_Files\Anaconda3\lib\site-packages\tensorflow\python\ops\variable_scope.py", line 346, in get_variable
validate_shape=validate_shape)
File "D:\Program_Files\Anaconda3\lib\site-packages\tensorflow\python\ops\variable_scope.py", line 331, in _true_getter
caching_device=caching_device, validate_shape=validate_shape)
File "D:\Program_Files\Anaconda3\lib\site-packages\tensorflow\python\ops\variable_scope.py", line 677, in _get_single_variable
expected_shape=shape)
File "D:\Program_Files\Anaconda3\lib\site-packages\tensorflow\python\ops\variables.py", line 224, in init
expected_shape=expected_shape)
File "D:\Program_Files\Anaconda3\lib\site-packages\tensorflow\python\ops\variables.py", line 327, in _init_from_args
initial_value(), name="initial_value", dtype=dtype)
File "D:\Program_Files\Anaconda3\lib\site-packages\tensorflow\python\ops\variable_scope.py", line 665, in
shape.as_list(), dtype=dtype, partition_info=partition_info)
TypeError: ones_initializer() got multiple values for argument 'dtype'

@michuanhaohao Can you remove the line of dtype=dtype and try again?

I have resolved the error and make a pull request then. The init_ops.one_initializer() function is rewritten on tensorflow 0.12. Maybe 'tf.one_initializer' should be replaced by 'tf.one_initializer()' in tensorlayer for tensorflow 0.12. But i did not check it for tensorflow 0.11 backend

a new push by @boscotsang may solve this problem.

tf.contrib.layers.xavier_initializer also has the same problem.


React Collapse not working properly in render method

We have written the needed data into your clipboard because it was too large to send. Please paste.

Hi @chakrihacker, can you please resubmit your bug? There is a limited amount of data we can send to prefill the GitHub template, so we copy the data to the clipboard if it's large and you need to paste it

Based on the title of this issue, I think the issue is probably with folding regions. We recently changed the default folding strategy to be language based instead of indentation based. Please try adding "editor.foldingStrategy": "indentation" to your settings to revert to the old behavior


Ordering of charts on delete: List should be reversed

When using helmfile.d and multiple helmfiles they are ordered lexicographically so that user can define a certain installation order. I think this list should be reversed when doing a helmfile delete. The same applies when using glob patterns.

@elemental-lf Sounds good! Would you mind submitting a PR for that?

@mumoshu, sorry, no time for a PR currently. Need to work on the project using helmfile for a change ;)

No worry! I'll work on it soon.

Thanks again.


initial imports have 0 airports, 0 waypoints

initial plan imports have 0 airports, 0 waypoints - if you import the same file again, the counts are correct

Thanks, will take a look

One question, if you import, then exit the program and come back in, are the values filled in then?  It may be a display issue

Hmm, that is very strange, doing my day job now, but will take a look when i get a chance

Sorry for the delay, i am going to try to look at this, got a new PC and spending a lot of time getting it configured but I will get to this once everything is setup

New release today (1.0) should hopefully fix this issue


Lua error when using Dragonriding Customization system

1x Interface/AddOns/Drift/DriftOptions.lua:405: attempt to index field 'objectivesEnabledCheckbox' (a nil value)
[string "@Interface/AddOns/Drift/DriftOptions.lua"]:405: in function <Interface/AddOns/Drift/DriftOptions.lua:362>
[string "=[C]"]: in function Hide' [string "@Interface/FrameXML/UIParent.lua"]:2805: in function SetUIPanel'
[string "@Interface/FrameXML/UIParent.lua"]:2646: in function ShowUIPanel' [string "@Interface/FrameXML/UIParent.lua"]:2561: in function <Interface/FrameXML/UIParent.lua:2557> [string "=[C]"]: in function SetAttribute'
[string "@Interface/FrameXML/UIParent.lua"]:3159: in function <Interface/FrameXML/UIParent.lua:3138>
[string "=[C]"]: ?
[string "=[C]"]: in function `ShowUIPanel'
[string "@Interface/FrameXML/UIParent.lua"]:2078: in function <Interface/FrameXML/UIParent.lua:1362>
Locals:
shouldReloadUI = false
oldWindowsDisabled = false
oldBagsDisabled = true
oldButtonsDisabled = true
oldObjectivesDisabled = true
(*temporary) =  {
dragAltKeyEnabled = false
frameDragIsLocked = false
scaleAltKeyEnabled = false
scaleShiftKeyEnabled = false
windowsDisabled = false
objectivesDisabled = true
scaleCtrlKeyEnabled = false
buttonsDisabled = true
dragCtrlKeyEnabled = false
dragShiftKeyEnabled = false
miscellaneousDisabled = true
frameScaleIsLocked = false
bagsDisabled = true
minimapDisabled = true
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'objectivesEnabledCheckbox' (a nil value)"
DriftOptionsPanel =  {
optionspanel = DriftOptionsPanel {
}
config =  {
}
}
isRetail = true

Thanks for the bug report. I am not able to repro this issue, unfortunately. Can you provide more detail on which interaction(s) with Dragonriding Customization cause this to happen? Is it the frame that lets you pick Dragonriding talents?

I'm sorry for misleading you. It is the system to change appearance of Dragonriding's dragon. When I enter the full screen control of appearance I got the Lua error. But everything works fine to change the appearance.

Also, just double checking, what version of Drift are you running?

Sorry for the late reply. The Lua error is gone. With or without other addons loaded. I do not know why. Thanks for your time.


"Always show close Button In Scene Tab" option is not working correctly

I have tested this on Ubuntu, 2.0 stable
Unfortunately option "Always show close Button In Scene Tab" is not working correctly.
If we open many scenes and will try to close them while they are not active, the first click will not work, the second one will close two scenes.  You don't need any particular setup to reproduce this.
@StraToN could you take a look?

@kubecz3k Ok, I'll try this tonight. I guess this is not related to the Setting option, but to the way the Tabs::CLOSE_BUTTON_SHOW_ALWAYS is managed. I remember @reduz  rewrote this part of the source code a few weeks ago, maybe he broke it.

My apologies to #reduz. He was absolutely not in cause. I was, I commented a line out which was not needed before, which forced updating tabs after closing. Force update is new needed.

@StraToN Working nicely now! Thanks :)


Feed parsed partially

Describe the bug
The reader view doesn't provide full content of the article, no matter if fetch full is active or not.
To Reproduce
Steps to reproduce the behavior:

Add the https://clojure.org/feed.xml feed
Click on any of the Clojure Deref posts
See error

Screenshots
Fetch full not pressed:

Fetch full pressed:

Screenshot of another RSS reader that has a similar reader view feature:

If I disable fetch full in that reader it goes to the same content as Twine:

Feed Information
https://clojure.org/feed.xml
The feed itself is missing it's latest post for some reason. Not a problem in another RSS reader, so maybe another bug.
Device Information

Device: Samsung S23U
OS: Android 14
App Version 1.48.1

This seems to be working as expected with the parser I am using for the reader view. Unfortunately not much I can do about it 😓

FYI, I updated to the 1.49.1 and this still happens to me with another feed:

happened with this feed: https://sachachua.com/blog/feed/


MIS Review- part 6

For this module, you have mentioned in the transition section that the data is taken from the user, while in the table, some inputs are not considered. This inconsistency might be confusing.

fixed in 107d5a9 by adding the input in the table, I didn't include it because I thought this is handled in another module so this might be unnecessary.


pyright shows errors PyLance is not showing

Environment data

Language Server version: 2022.10.30
OS and version: macOS Ventura
Python version (& distribution if applicable, e.g. Anaconda): 3.10.8

Code Snippet
from __future__ import annotations

from typing import Any

from django.core.management.base import LabelCommand
from django_rich.management import RichCommand

class Command(RichCommand, LabelCommand):
    def handle_label(self, label: int, **options: Any) -> None:
        pass

django 4.1.2
django-rich 1.4.0
django-stubs 1.12.0
Expected behavior
I would expect, that PyLance is showing the same errors as pyright.

Loading configuration file at /Users/oa/Projekte/privat/django-tailwind-cli/pyrightconfig.json
Assuming Python version 3.10
Assuming Python platform Darwin
No include entries specified; assuming /Users/oa/Projekte/privat/django-tailwind-cli
Auto-excluding **/node_modules
Auto-excluding **/__pycache__
Auto-excluding **/.*
stubPath /Users/oa/Projekte/privat/django-tailwind-cli/typings is not a valid directory.
Searching for source files
Found 5 source files
pyright 1.1.275
/Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py
  /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py:10:9 - error: Method "handle_label" overrides class "LabelCommand" in an incompatible manner
    Parameter 2 type mismatch: base parameter is type "str", override parameter is type "int"
      "str" is incompatible with "int" (reportIncompatibleMethodOverride)
1 error, 0 warnings, 0 informations
Completed in 0.506sec

PyLance doesn't show this error.
Logs

[Info  - 00:40:53] (76038) Pylance language server 2022.10.30 (pyright 50e12b4b) starting
[Info  - 00:40:53] (76038) Server root directory: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist
[Info  - 00:40:53] (76038) Starting service instance "django-tailwind-cli"
[Info  - 00:40:53] (76038) Notebook support: Legacy
[Info  - 00:40:53] (76038) Interactive window support: Legacy
[Info  - 00:40:53] (76038) No configuration file found.
[Info  - 00:40:53] (76038) pyproject.toml file found at /Users/oa/Projekte/privat/django-tailwind-cli.
[Info  - 00:40:53] (76038) Setting pythonPath for service "django-tailwind-cli": "/Users/oa/Projekte/privat/django-tailwind-cli/.venv/bin/python"
[Info  - 00:40:53] (76038) Loading pyproject.toml file at /Users/oa/Projekte/privat/django-tailwind-cli/pyproject.toml
[Info  - 00:40:53] (76038) Assuming Python version 3.10
[Info  - 00:40:53] (76038) Assuming Python platform Darwin
[Info  - 00:40:53] (76038) No include entries specified; assuming /Users/oa/Projekte/privat/django-tailwind-cli
[Info  - 00:40:53] (76038) Auto-excluding **/node_modules
[Info  - 00:40:53] (76038) Auto-excluding **/__pycache__
[Info  - 00:40:53] (76038) Auto-excluding **/.*
[Warn  - 00:40:53] (76038) stubPath /Users/oa/Projekte/privat/django-tailwind-cli/typings is not a valid directory.
[Info  - 00:40:53] (76038) Search paths for /Users/oa/Projekte/privat/django-tailwind-cli
[Info  - 00:40:53] (76038)   /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib
[Info  - 00:40:53] (76038)   /Users/oa/Projekte/privat/django-tailwind-cli
[Info  - 00:40:53] (76038)   /Users/oa/Projekte/privat/django-tailwind-cli/src
[Info  - 00:40:53] (76038)   /Users/oa/Projekte/privat/django-tailwind-cli/src
[Info  - 00:40:53] (76038)   /Users/oa/Projekte/privat/django-tailwind-cli/typings
[Info  - 00:40:53] (76038)   /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stubs/...
[Info  - 00:40:53] (76038)   /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/bundled/stubs
[Info  - 00:40:53] (76038)   /Users/oa/Projekte/privat/django-tailwind-cli/.venv/lib/python3.10/site-packages
[Info  - 00:40:53] (76038) Adding fs watcher for library directories:
 /Users/oa/Projekte/privat/django-tailwind-cli/.venv/lib/python3.10/site-packages
/Users/oa/Projekte/privat/django-tailwind-cli/.venv/Lib/python3.10/site-packages
[Info  - 00:40:53] (76038) Adding fs watcher for directories:
 /Users/oa/Projekte/privat/django-tailwind-cli
[Info  - 00:40:53] (76038) Searching for source files
[Info  - 00:40:53] (76038) Found 5 source files
(76038) [IDX(FG)] index libraries /Users/oa/Projekte/privat/django-tailwind-cli (index) ...
(76038) [IDX(FG)]   read stdlib indices (17ms)
(76038) [IDX(FG)] index libraries /Users/oa/Projekte/privat/django-tailwind-cli (index) [succeed] (20ms)
(76038) [FG] parsing: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py (9ms)
(76038) [FG] parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/builtins.pyi [fs read 2ms] (40ms)
(76038) [FG] binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/builtins.pyi (15ms)
(76038) [FG] binding: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py (0ms)
[Info  - 00:40:53] (76038) Background analysis(1) root directory: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist
[Info  - 00:40:53] (76038) Background analysis(1) started
(76038) Background analysis message: setConfigOptions
(76038) Background analysis message: setImportResolver
(76038) Background analysis message: ensurePartialStubPackages
(76038) Background analysis message: setTrackedFiles
(76038) Background analysis message: markAllFilesDirty
(76038) Background analysis message: setFileOpened
(76038) Background analysis message: getSemanticTokens full
(76038) [BG(1)] getSemanticTokens full at /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py ...
(76038) [BG(1)]   parsing: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py (7ms)
(76038) [BG(1)]   parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/builtins.pyi [fs read 1ms] (35ms)
(76038) [BG(1)]   binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/builtins.pyi (17ms)
(76038) [BG(1)]   binding: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py (0ms)
(76038) [BG(1)]   parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/typing.pyi [fs read 2ms] (10ms)
(76038) [BG(1)]   binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/typing.pyi (3ms)
(76038) [BG(1)]   parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/typing_extensions.pyi [fs read 0ms] (1ms)
(76038) [BG(1)]   binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/typing_extensions.pyi (4ms)
(76038) [BG(1)]   parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/_typeshed/__init__.pyi [fs read 1ms] (3ms)
(76038) [BG(1)]   binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/_typeshed/__init__.pyi (0ms)
(76038) [BG(1)]   parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/types.pyi [fs read 0ms] (3ms)
(76038) [BG(1)]   binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/types.pyi (2ms)
(76038) [BG(1)]   parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/abc.pyi [fs read 0ms] (1ms)
(76038) [BG(1)]   binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/abc.pyi (1ms)
(76038) [BG(1)]   parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/__future__.pyi [fs read 1ms] (1ms)
(76038) [BG(1)]   binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/__future__.pyi (0ms)
(76038) [BG(1)]   parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/bundled/stubs/django-stubs/core/management/base.pyi [fs read 0ms] (1ms)
(76038) [BG(1)]   binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/bundled/stubs/django-stubs/core/management/base.pyi (0ms)
(76038) [BG(1)]   parsing: /Users/oa/Projekte/privat/django-tailwind-cli/.venv/lib/python3.10/site-packages/django_rich/management.py [fs read 0ms] (2ms)
(76038) [BG(1)]   binding: /Users/oa/Projekte/privat/django-tailwind-cli/.venv/lib/python3.10/site-packages/django_rich/management.py (0ms)
(76038) [BG(1)]   parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/bundled/stubs/django-stubs/core/management/__init__.pyi [fs read 1ms] (1ms)
(76038) [BG(1)]   binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/bundled/stubs/django-stubs/core/management/__init__.pyi (0ms)
(76038) [BG(1)] getSemanticTokens full at /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py (120ms)
(76038) Background analysis message: analyze
(76038) [BG(1)] analyzing: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py ...
(76038) [BG(1)]   checking: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py ...
(76038) [BG(1)]     parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/io.pyi [fs read 1ms] (2ms)
(76038) [BG(1)]     binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/io.pyi (1ms)
(76038) [BG(1)]     parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/bundled/stubs/django-stubs/core/management/color.pyi [fs read 0ms] (0ms)
(76038) [BG(1)]     binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/bundled/stubs/django-stubs/core/management/color.pyi (0ms)
(76038) [BG(1)]     parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/argparse.pyi [fs read 0ms] (5ms)
(76038) [BG(1)]     binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/typeshed-fallback/stdlib/argparse.pyi (2ms)
(76038) [BG(1)]     parsing: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/bundled/stubs/django-stubs/apps/config.pyi [fs read 0ms] (1ms)
(76038) [BG(1)]     binding: /Users/oa/.vscode/extensions/ms-python.vscode-pylance-2022.10.30/dist/bundled/stubs/django-stubs/apps/config.pyi (0ms)
(76038) [BG(1)]   checking: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py (21ms)
(76038) [BG(1)] analyzing: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/tailwind.py (22ms)
(76038) Background analysis message: resumeAnalysis
(76038) [BG(1)] analyzing: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/__init__.py ...
(76038) [BG(1)]   parsing: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/__init__.py [fs read 0ms] (0ms)
(76038) [BG(1)]   binding: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/__init__.py (1ms)
(76038) [BG(1)]   checking: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/__init__.py (0ms)
(76038) [BG(1)] analyzing: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/__init__.py (1ms)
(76038) [BG(1)] analyzing: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/__init__.py ...
(76038) [BG(1)]   parsing: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/__init__.py [fs read 0ms] (0ms)
(76038) [BG(1)]   binding: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/__init__.py (0ms)
(76038) [BG(1)]   checking: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/__init__.py (0ms)
(76038) [BG(1)] analyzing: /Users/oa/Projekte/privat/django-tailwind-cli/src/django_tailwind_cli/management/commands/__init__.py (0ms)
(76038) [BG(1)] analyzing: /Users/oa/Projekte/privat/django-tailwind-cli/tests/__init__.py ...
(76038) [BG(1)]   parsing: /Users/oa/Projekte/privat/django-tailwind-cli/tests/__init__.py [fs read 0ms] (0ms)
(76038) [BG(1)]   binding: /Users/oa/Projekte/privat/django-tailwind-cli/tests/__init__.py (0ms)
(76038) [BG(1)]   checking: /Users/oa/Projekte/privat/django-tailwind-cli/tests/__init__.py (0ms)
(76038) [BG(1)] analyzing: /Users/oa/Projekte/privat/django-tailwind-cli/tests/__init__.py (0ms)
(76038) [BG(1)] analyzing: /Users/oa/Projekte/privat/django-tailwind-cli/tests/settings.py ...
(76038) [BG(1)]   parsing: /Users/oa/Projekte/privat/django-tailwind-cli/tests/settings.py [fs read 0ms] (0ms)
(76038) [BG(1)]   binding: /Users/oa/Projekte/privat/django-tailwind-cli/tests/settings.py (0ms)
(76038) [BG(1)]   checking: /Users/oa/Projekte/privat/django-tailwind-cli/tests/settings.py (0ms)
(76038) [BG(1)] analyzing: /Users/oa/Projekte/privat/django-tailwind-cli/tests/settings.py (1ms)

Just to confirm, other errors are shown by pyright and PyLance. It seems to be an issue with reportIncompatibleMethodOverride.

Pylance bundles additional type stubs that affect type results. This includes stubs for django. You can find these here. If you want consistent results between pyright and pylance, you need to ensure that you're using the same stubs.

Pylance bundles additional type stubs that affect type results. This includes stubs for django. You can find these here. If you want consistent results between pyright and pylance, you need to ensure that you're using the same stubs.

Thanks for the link. Then I need to open a ticket there, because the stub for LabelCommand is basically wrong about handle_label.


update this to let build good

update this based on new changes of dev of OC

@infofromca Going to close this as we can't reference Orchard Core libraries using local paths, it has to use the NuGet packages. Will definitely reference these changes for when the NuGet packages are next updated 👍

@infofromca Going to close this as we can't reference Orchard Core libraries using local paths, it has to use the NuGet packages. Will definitely reference these changes for when the NuGet packages are next updated 👍


After having PR_target right in the develop branch

Explanation

Essential Checklist

[ ] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[ ] Any changes to scripts/assets files have their rationale included in the PR explanation.
[ ] The PR follows the style guide.
[ ] The PR does not contain any unnecessary code changes from Android Studio (reference).
[ ] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
[ ] The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

ok ok ok ok... so the permissions to comment from a fork do work but it seems that the trigger needs to be present in the develop or the base-branch to make it work.
Will retry it switching it back an forth a few times to confirm it.

Nice right after the develop's pul_request_target is replaced with pull_request the upload functionality failed: https://github.com/Rd4dev/Oppia-Android-Fork-from-Fork/actions/runs/10424669387/job/28873962888?pr=2
Will again switch develop's pull_request to pull_request_target that should fairy confirm the behaviour.

Woah, awesome.
This confirms!
So the trigger -
pull_request_target:
types: [assigned, opened, synchronize, reopened]
needs to be placed in the main / base - develop branch to set the target.
To make it work

[ ] Confirm artifact collection
[ ] Split code coverage functionality
[ ] Pass artifact between workflows

Link: Point 2 - https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes
Finally C1 workflow shows up
on:
pull_request:
push:

Try removing C1 from develop

Freshly introduced C3 works well (on pull_request)
May be try using pull_request_target to see if that works

As observed C3 disappears with pull_request_target (not in develop).
While CC still having pull_request_target (in develop) continues to function.

C3 again available with pull_request

Even
on:
pull_request_target:
branches:
- develop
makes no change to make it trigger-able

But the comment doesn't seem to be updated with fork content; that is concerning 😕

Direct download of artifact doesn't seem to work -
Downloading single artifact
Error: Unable to download artifact(s): Artifact not found for name: my-report
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.
        For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md

ok ok ok ok finally atleast something than nothing.
But the comment is generated via workflow run to acquire run-id.
Since it is triggered from workflow_run,

It doesn't it into PR checks
Unknown PR issue number
But easy to acquire run id with workflow_run
Triggers only after ci check - essentially serves the same purpose as the external action but not inside PR (which is bad)

So if we could gain the run-id with pull_request_target that should do.
oh also with workflow_run it had access to commenting.

🤕

Woah Woh Woh wait did it work wait, wait!!!!

seems like, no way!
lets try to upload the content as comment 🤞

ah pull_request_target should be available 🤦

Yoooooooooooooooooooooooo no way! it works it works 🥹

So the constraints are

2 workflows

cc.yml

does cc analysis, generates reports, uploads artifact

cu.yml

waits till cc completes, gets run-id, downloads artifact, uploads comment
it will require pull_request_target
the pull_request_target needs to be in develop branch
the dowload artifact would require github secret and a run id

Give me five, give me a five ✋🕺  - finally : https://github.com/Rd4dev/Oppia-Android-Fork-from-Fork/pull/2/#issuecomment-2294848569
so I was missing the run id all time and wondering what was happening wrong.
Ok, so the success cases seem to work, I can run code coverage wait for them and trigger the uploads.
The thing yet to check are the edge cases, I am more concerned about those.
Plans are

if skip_files -> idk, may be have any way of passing that the coverages were not generated. - there should be something to convey to the other workflow that the files are skipped. Or else they consider them as neutral and fail the wait actions.
If coverage status check fails -> the comment upload should still occur, I think this might be possible as we would still have the artifact available and run ids present, while we can use if ${{ !cancelled }} to still run them if the previous jobs fail.

The way to run even if status fails while having wait job fail would be ok-ish if that was a fail.
But for skip jobs that SHOULD NOT be the case.
Thinking...............

Having the allowed-conclusions: failure, https://github.com/Rd4dev/Oppia-Android-Fork-from-Fork/actions/runs/10432949137/job/28894524456?pr=2 does work but I'm unsure if it would work with an array like [success, failure, neutral], if it does that would be really nice as we can have the job as checked instead of fail or having an allow failure condition to still mark it as fail case. That is something to look into later, but now the actual issue is the current run-id only retrieves the success workflows, but when the workflow fails due to coverage status check (which is intentionally done with removing few tests in compute aab) they too need to be obtained to grab the generated coverage report. Let's see.

Awesome so removing the status does let the run-id to be obtained even when the workflow fails.
Now what ---
Uhm.. ah okay, now it just has failure conclusion, but I need all 3

Run<EMAIL_ADDRESS>with:
workflow: code_coverage.yml
sha: auto
allowed-conclusions: success,skipped,failure
github_token: ***
repo: Rd4dev/Oppia-Android-Fork-from-Fork
wait-interval: 30
Auto detected sha: 64e269ed3db014272e8d01e35db6512c58b0262b
Error: Run#10433653185 is completed with disallowed conclusion: failure

const allowedConclusions = core.getMultilineInput(
'allowed-conclusions',
{
required: true
}
)

:)

lets try again with success, then skip 🤞

:)

ok i think skip will fail
becuase it doesn't have the report to fetch

either evaluate report even when skip files, but that is not a nice user experience
should have some way to pass the skipped values or ohhh...
may be i can take it directly from the ,,
no no,
should look for other ways

why take in neutral in the first place?

Uh, seems like the workflow is returning a success case that will be then hard to condition for report publish mmmmmmmmmm...........
Run<EMAIL_ADDRESS>Auto detected sha: 3fdd3fd7bb1af7404ce07e3be9e6ea20baff3aa5
Run#10434944432 is completed with conclusion: success

ok ok I just realized that may be why not move evaluations too over to the new workflow, I thought of that ystdy but skipped thinking it wouldn't work, but I guess that would.
Dropping here the idea, before I forget.
coverage workflow

checkout code
compute changed file (pull_request)
run coverage (requires - correct set of computed changed files)
collects pb files
save to artifact

comment workflow

collect the pb_list.txt artifact
if empty -> means skip files
checkout - but no code collection needed (as required with compute changed file)
pass the pb_list.txt to the coverage_reporter script
evaluates results
upload comment
have coverage status check here

The procedure to collect run-id would still stay the same as we still need the pb_list.txt
But this could potentially solve 2 things

skip files check
coverage status check

And this can be a one point end to the ci check
Also this might mean we need to have success status from the code_coverage workflow removing all other allowed_conclusions as evaluated results are no longer passed and will always need to pass if unit tests pass.

This works but needs refinement!

ok close to done

if: ${{ !cancelled() && needs.evaluate-code-coverage-reports.outputs.pb_file_empty != 'true' }}
Adding this to the comment job would make the job skip commenting when no files are evaluated, but just feels like its better to have atleast 0 files assessed report than nothing
oh or else can we set the comment body conditionally
that would be a nice idea

woah in first try, but would it be better to do in script??

lets do one final fail check and that should probably do it, will also may be run a RunAllTests here if needed

ah confused, now script handles skips, so now there will always be a report, so now can evaluate be there in the old workflow. I kinda forgot for what other reasons I moved it......................

ah ok ok no no this is right, so earlier eval had dep on run cov so if run cov is skipped, eval too skipped causing no report to publish.
would ! cancel work I doubt , since it could handle success, fail not sure about skip, I think the current one works, just some extra bit to pull_request_target bothers

Status wrong 😮💨

🤠

🥞

Wingardium Leviosa

🪽

🪶

🧹

Lumos

Quidditch

🏉

Golden snitch

⚡👓

🧣

Chocolate frogs 🍫

Only the person who wanted to find the stone find it and not use it will get it

There are ways in which he can return {}

All right
Never better
Eeee

Ding ding ding

312 Gryffindor
Hufflepuff 352
Ravenclaw 426
Slytherin 472

Recent events
Hermione intellect 50
Ronald Weasley Chess 50
Harry Potter outstanding courage 60
👏👏👏
Great deal more bravery to stand up to friends Neville Long Bottom 10
Gryffindor wins the house cup
🏆🏆🏆

I guess that will do

Thanks Hagrid

🚂

expecting a ton of bugs ........

k now they skip with next commit it should get a new commit and run the builds and post a comment (if I don't cancel them)

Just added a space - would that make a build change?
Oh also handle edge case for initial comments............

noice noice noice

so the question now is if the build changes

if date is empty
-> set new commits to true
as that would represent a literal new commit or initial commit (Edge case)

https://github.com/Rd4dev/Oppia-Android-Fork-from-Fork/pull/43#issuecomment-2490274181
(❁´◡`❁)

kinda sus if this check is even needed as even a small space change is making a different report
     - name: Compare Generated APK & AAB Analysis with the Previous Report
       if: ${{ steps.track_commits.outputs.new_commits == 'true' }}
       run: |
         if [ -f latest_aab_comment_body.log ]; then
           sed -i -e '$a\' ./develop/brief_build_summary.log
           sed -i -e '$a\' latest_aab_comment_body.log

           if diff -B ./develop/brief_build_summary.log latest_aab_comment_body.log > /dev/null; then
             echo "No significant changes detected; skipping apk aab analysis comment."
             echo "skip_apk_aab_comment=true" >> $GITHUB_ENV
           else
             echo "Changes detected; proceeding with the apk aab analysis comment."
             diff ./develop/brief_build_summary.log latest_aab_comment_body.log || true
             echo "skip_apk_aab_comment=false" >> $GITHUB_ENV
           fi
         else
           echo "No previous APK & AAB report posted; Commenting analysed APK & AAB report."
           echo "skip_apk_aab_comment=false" >> $GITHUB_ENV
         fi

so a new commit is an obvious change in report so I guess we wouldn't need (or I just can't think of any other reasons to have it rn)


win32: source file exclusive access locks

hello,
i've just tried the current 'master' branch with 'ant install' on the latest AIR SDK / win32.
it works great, but one problem that i've noticed is that if you run 'compile 1' on the simplest of Main.as projects with a deliberate small error you will find that after MXMLC displays the error, java.exe locks the file (assuming LockFile() from the WINAPI) and the file cannot be changed until ASCSH is stopped (i.e. the jave.exe process is stopped) or the file is manually unlocked by another process.
this issue prevents fixing errors / warnings in any source file that was just compiled by MXMLC via ASCSH.
any possible solutions?

I have similar issue: files that have errors in them kept locked preventing me from deleting/renaming them.
FlashDevelop <IP_ADDRESS>
Java 1.8.0_45
ascsdk 17
Windows 8.1

Hmm, as an aside, I don't have this problem using ascshd from the commandline in Linux, though that's a obviously different environment.


Media fails to play when using server hostname

We've recently seen a number of threads on the forums where people are having trouble playing media. If they remove the server (which is a hostname) from the preferences and add the server back via the IP address, they are able to play media fine.
I experienced this myself when I switched from my Roku 2 back to my Roku 1. I checked and the Roku was talking to the PMS fine, able to browse the sections with no problem. However, it got an unknown error when dealing with playing the media. Looking into the logs I found that PMS threw a transcoding error, that it was unable to retrieve the file from  http://storm:32400/library/parts/23456/file.mp4. Digging in further, I found that the URL worked fine in links, which confused me. I checked in Chrome, it worked fine.
Since I figured it might be DNS related, I pinged storm from storm and got an IPV6 address. Looking at netstat, it looks like Plex just binds to <IP_ADDRESS>:32400, which is IPV4 only, which I think is the problem. I don't see Plex binding to [::]:32400 as well. I might be on the wrong track as to why the transcoder couldn't reach the file, but that's the only thing I saw in the logs.
I'll try to re-duplicate this to get a log to attach.

On Windows, we only bind to IPv4, because IPv6 caused trouble. Generally, when we're constructing transcode URLs for images or video, we replace the hostname with <IP_ADDRESS> because that's super safe and should always work. This assumes (which is currently the case) that you're asking the media server for a local resource.

PMS log: http://tinyurl.com/7hdmkja
Transcode log: http://tinyurl.com/76boawz

(I'm sure you already know this, but the loopback is always "<IP_ADDRESS>:32400" regardless of the mapped port.)

Hrm. Maybe not under Windows, but under Linux, isn't that a configurable option? I thought it was.

Nope, it's fixed on all platforms.


How to enable "X-Traefik-reqid" header?

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
I want to use this header for create relationship between Traefik logs and Back-End logs
traefik version:

Version:      v1.7.14
Codename:     maroilles
Go version:   go1.12.8
Built:        2019-08-14_09:46:58AM
OS/Arch:      linux/amd64

traefik.toml

defaultEntryPoints = ["https","http"]
[entryPoints]
[entryPoints.http]
address = ":80"
[entryPoints.https]
address = ":443"
[entryPoints.https.tls]
[entryPoints.traefik]
address = ":8080"
[entryPoints.traefik.auth.basic]
users = ["admin:password"]
[kubernetes]
[kubernetes.ingressEndpoint]
publishedService = "traefik/traefik-ingress-controller-http-service"
[ping]
entryPoint = "http"
[api]
entryPoint = "traefik"
[log]
filePath = "/logs/service.log"
level = "WARN"
format = "json"
[accessLog]
format = "json"
[accessLog.fields]
defaultMode = "drop"
[accessLog.fields.headers]
defaultMode = "drop"
[accessLog.fields.names]
"ClientHost" = "keep"
"RequestMethod" = "keep"
"RequestPath" = "keep"
"RequestProtocol" = "keep"
"OriginStatus" = "keep"
[accessLog.fields.headers.names]
"Authorization" = "keep"

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.


samples: intel_s1000: I2S audio sample application

This PR adds a sample application for the Intel S1000 board.
Audio can be played out in one of 2 modes

A sequence of tones generated by the app
A passthrough mode in which the app forwards the audio from another host connected to S1000 over I2S bus.

Codecov Report

Merging #13292 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13292   +/-   ##
=======================================
  Coverage   48.74%   48.74%
=======================================
  Files         319      319
  Lines       46872    46872
  Branches    10835    10835
=======================================
  Hits        22850    22850
  Misses      19395    19395
  Partials     4627     4627

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 861c82d...96b78c4. Read the comment docs.

Guess you may also need to whitelist this for s1000 in a yaml file.

What does the yaml file do? I didn't have one for the DMIC sample samples/boards/intel_s1000_crb/dmic/dmic.rst

Guess you may also need to whitelist this for s1000 in a yaml file.

What does the yaml file do? I didn't have one for the DMIC sample samples/boards/intel_s1000_crb/dmic/dmic.rst

From what i know, in the tests folder, the yaml files get picked up by the sanitycheck for executing the corresponding tests. I am not quite sure about its use in the samples folder. However, i see the other samples in the samples folder do have the yaml file so you may consider having it.

From what i know, in the tests folder, the yaml files get picked up by the sanitycheck for executing the corresponding tests. I am not quite sure about its use in the samples folder. However, i see the other samples in the samples folder do have the yaml file so you may consider having it.

I see. I'll talk to @nashif later and add the YAML in a separate PR for all sample apps as needed.

please add the sample meta-data (sample.yaml):
sample:
  name: I2S Audio Sample
tests:
  test:
    platform_whitelist: intel_s1000_crb
    tags: i2s

This will allow integration into testing.

please add the sample meta-data (sample.yaml):

Done. Thanks for the yaml content!


[SPARK-48940][BUILD] Upgrade Arrow to 17.0.0

What changes were proposed in this pull request?
The pr aims to upgrade arrow from 16.1.0 to 17.0.0.
Why are the changes needed?
The full release notes: https://arrow.apache.org/release/17.0.0.html
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.

The PR is ready, @panbingkun ?

The PR is ready, @panbingkun ?

Yea, thanks.


lxd Add support for setting txqueuelen on veth based NICs

Add possibility to change txqueuelen on veth devices using lxc config device set c1 eth0 txqueuelen=100
fix lxc#11198
Signed-off-by: Viktor Iakovchuk<EMAIL_ADDRESS>

This pull request didn't trigger Jenkins as its author isn't in the allow list.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

jenkins: test this please

@tomponline could you launch tests, please? I fixed error in it.

jenkins: test this please

@tomponline could you launch tests, please? I fixed error in it.

LGTM

jenkins: test this please

jenkins: test this please


Added min_subject_width to TextWidth

I added the support of min_subject_width in TextWidth with default value as 0 to obtain a behavior like the actual one.
  TextWidth:
    min_subject_width: 0

A developer can set the min_subject_width to improve the commit messages in the team, for example a co-worker can avoid the EmptyMessage check putting as subject a single char.

Thanks @namuit! Merged in fc03ddef with some amendments in 9b0956ba. Appreciate your contribution!


Getting started

Hey guys,
I think your product here is great, but it's really hard getting started.
Can you explain what's the difference between Client and Server Trace?

Hi @senj,
ClientTrace and ServerTrace were introduced recently and there's no documentation yet.
I'll update the readme but in the meantime, ClientTrace is meant for a client doing a request on a server and ServerTrace is the server part when it receives a request

In a microservice world it's hard to tell who is the client and who is the server.. I used ClientTrace everywhere right now because it creates a nice hierarchy..

When we talk about the client, we mean the service issuing a request and by server we mean the service receiving a request. A service can typically be a client and a server at the same time.
Example:
Three services A, B and C
A -> B -> C
A calls B which calls C
A emits a ClientTrace when sending a request to B
B emits a ServerTrace when receiving a request from A
B emits a ClientTrace when sending a request to C
C emits a ServerTrace when receiving a request from B

The readme really doesn't help with getting started, even the included examples don't help. Having never used Zipkin before, there really should be documented prerequisites, .net core setup and example tracing.
It's not even clear what nuget packages to add to a project. Are they added at the API level, or the Web client itself? Does this send to the Zipkin Java/Docker server? Where is this configured?


macOS support

Adds support for macOS / MoltenVK

Author etang-cw not on autobuild list. Waiting for curator authorization before starting CI build.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We have a PR in-flight which should achieve the same effect as one of the bonus feature commits in your PR: https://github.com/LunarG/gfxreconstruct/pull/1297/
Would you mind taking a look at that and seeing if we need to pull in anything from your commit? Yours for reference: https://github.com/LunarG/gfxreconstruct/pull/1317/commits/5334fc6d5d6f3ef520f700961b069b7631b7ea46

We have another PR contribution which adds a parallel build option like the one you add in a commit on this PR. https://github.com/LunarG/gfxreconstruct/pull/1302
There are some differences such as them checking the Cmake version is high enough. Could you also take a look at that and comment what might be missing that your commit https://github.com/LunarG/gfxreconstruct/pull/1317/commits/71f63dc45cc3dea45f6b626b7c58baaec5b805d2 adds?

Good to see I'm not the only one who noticed those
No preferences on #1297, they both accomplish the same thing
For #1302, I commented my needs on the PR
I'll leave the commits here for now in case anyone wants to use them for reference, and remove them once those PRs get merged (I'll need to add whatever ends up being the ncpu-parallel syntax to the macOS build anyways)

Yes I think Evan's 5334fc6d5d6f3ef520f700961b069b7631b7ea46 is better than #1297

Do you want me to pull it out into a separate PR?

Sure, why not. Although I don't have the last call on what gets merged, I think this is useful anyway and independent of the general purpose of this PR

Yes, I think we'd prefer to have unrelated functionality in separate PRs if it's not too much trouble.

Author etang-cw not on autobuild list. Waiting for curator authorization before starting CI build.

Also, not sure how I didn't notice earlier, but 46a425ecd50bd16b6897d309a267535ccac0c6cc is actually a reversion of f7b95927db84c0bc3b6d6ad0f34f74276aa6c412, which is what broke macOS support.  Do you know what 32-bit platform f7b95927db84c0bc3b6d6ad0f34f74276aa6c412 was fixing?  The Android CI seems to be having no trouble here...

CI gfxreconstruct build queued with queue ID 67315.

CI gfxreconstruct build # 3405 running.

CI gfxreconstruct build # 3405 passed.

I built the tree but of course my first test was to try to replay a vkcube capture from Linux, which failed because the original capture didn't use PORTABILITY ext or CreateInstance flag bit.  What do you think of forcing the portability extension and the portability bit on in VulkanReplayConsumer if it's running on Mac?  (May be VulkanReplayConsumerBase, I forget where the actual extension and feature handling is done)

Author etang-cw not on autobuild list. Waiting for curator authorization before starting CI build.

I built the tree but of course my first test was to try to replay a vkcube capture from Linux, which failed because the original capture didn't use PORTABILITY ext or CreateInstance flag bit. What do you think of forcing the portability extension and the portability bit on in VulkanReplayConsumer if it's running on Mac? (May be VulkanReplayConsumerBase, I forget where the actual extension and feature handling is done)

I've been loading MoltenVK directly so I totally forgot that was a thing
Yeah, we should do that

Author etang-cw not on autobuild list. Waiting for curator authorization before starting CI build.

CI gfxreconstruct build queued with queue ID 78542.

CI gfxreconstruct build # 3457 running.

CI gfxreconstruct build # 3457 failed.

CI gfxreconstruct build # 3457 failed.

This is an internal CI failure because we don't (as yet) install packaging Python module and you committed a change to import and use that at d51ade2c82bed85f9ffd179de57455ea27da0866.  Otherwise I suspect our internal CI would have succeeded as it did before.  I suggest breaking out the switch to packaging from distutilsto a separate PR in order to merge this since we'd have to request an internal CI change and wait on that resolution otherwise.

Very nice!  (golf clap)
tools/replay/gfxrecon-replay --remove-unsupported -m rebind --wsi metal ~/Downloads/vkcube_20220718T185641.gfxr

That's from a capture of vkcube on Linux.

Author etang-cw not on autobuild list. Waiting for curator authorization before starting CI build.

I suggest breaking out the switch to packaging from distutils to a separate PR in order to merge this since we'd have to request an internal CI change and wait on that resolution otherwise.

It's available at #1331

I suggest breaking out the switch to packaging from distutils to a separate PR in order to merge this since we'd have to request an internal CI change and wait on that resolution otherwise.

It's available at #1331

Thanks!  And, just to be clear, unless I really misunderstand git, your push of 01fbefa to macos still has d51ade2 in its lineage so it still imports and uses packaging - did you mean for that to push a version of the branch without that?

did you mean for that to push a version of the branch without that?

GitHub Actions' macOS runner has Python 3.12, so it's kind of required to pass that
So either way we'll have at least one CI failing

I guess I could modify the CI script to use python3.11, should I do that?

CI gfxreconstruct build queued with queue ID 78590.

CI gfxreconstruct build # 3459 running.

I guess I could modify the CI script to use python3.11, should I do that? Edit: Doing that for now

I see that my old incomplete MacOS port (based on @kvark's earlier MacOS port) now fails also.  I suppose if the script can be forced to an earlier version on MacOS runners, we can try to get this merged and I can also start the conversation about getting packaging installed on our CI systems so we can use it and then unlock the version in the script.

CI gfxreconstruct build queued with queue ID 78606.

Okay.  I removed the parallelize build commit so this no longer conflicts with #1302
(Though whichever gets merged last will still want to be modified to do a parallel macOS build in the CI)

CI gfxreconstruct build # 3461 running.

CI gfxreconstruct build # 3461 passed.

https://github.com/LunarG/gfxreconstruct/pull/1332 removes the need for packaging and distutils

CI gfxreconstruct build queued with queue ID 79744.

CI gfxreconstruct build # 3477 running.

CI gfxreconstruct build # 3477 passed.

CI gfxreconstruct build queued with queue ID 87281.

CI gfxreconstruct build # 3535 running.

CI gfxreconstruct build # 3535 passed.

CI gfxreconstruct build queued with queue ID 121735.

CI gfxreconstruct build # 3686 running.

@etang-cw Thank you very much for this PR and sticking with us through the feedback and requested edits!


[BUG] Hydration failed because the initial UI does not match what was rendered on the server

NextUI Version
2.2.6
Describe the bug
 return (
        <Card className="min-w-[400px]">
          <CardHeader className="flex gap-3">
            <Image
              alt="Algodomain logo"
              height={40}
              src="/LOGO.jpg"
              width={40}
            />

 Candidate Login

          </CardHeader>
          <CardBody className="gap-3">
            <Input size="sm" type="email" label="Email" name="email" />
            <Input size="sm" type="password" label="Password" name="password" />
          </CardBody>
         </Card>
  );

Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
When I am running the application
npm run dev
on the port 3000 i am getting this error
This is related to the Input element in the card body, if I remove them, this error goes away.
Expected behavior
It should work
Screenshots or Videos
No response
Operating System Version
MacOS
Browser
Chrome

Same issue here, only occurs with more then 1 input tho

Disable the Chrome Extension like Dark Reader. it works 99% of the Time

A web extension was the problem for me, thanks! Unfortunately I have no solution except maybe using a (dynamically loaded) client component. And I guess it's not really possible for NextUI to handle this since it's a React issue.


Uneven size of arrays

I have been trying to create a 2*3 raincloud, but my classes have uneven sizes. The class sizes are:
7S-Shallow -> 5 rows
G-Shallow -> 8 rows
G-Deep -> 7 rows
  array_1 = meta_taxa$alpha_shannon[(meta_taxa$Loc_Depth=="7S-Shallow")],
  array_2 = meta_taxa$alpha_simpson[(meta_taxa$Loc_Depth=="7S-Shallow")],
  array_3 = meta_taxa$alpha_shannon[(meta_taxa$Loc_Depth=="G-Shallow")],
  array_4 = meta_taxa$alpha_simpson[(meta_taxa$Loc_Depth=="G-Shallow")],
  array_5 = meta_taxa$alpha_shannon[(meta_taxa$Loc_Depth=="G-Deep")],
  array_6 = meta_taxa$alpha_simpson[(meta_taxa$Loc_Depth=="G-Deep")],
  labels = (c('Shannon','Simpson' )),
  jit_distance = .05,
  jit_seed = 321)

raincloud_2x3_repmes(
  data = df_2x3,
  colors = (c("lightseagreen","darkolivegreen4","coral1","indianred4","lightpink1","palevioletred1")),
  fills = (c("lightseagreen","darkolivegreen4","coral1","indianred4","lightpink1","palevioletred1")),
  size = 1,
  alpha = .6,
  ort = 'v') +
scale_x_continuous(breaks=c(1,2,3), labels=c("7S-Shallow", "G-Shallow", "G-Deep")) +
  scale_y_continuous(breaks=c(1,2), labels=c("Simpson", "Shannon")) +
  xlab("Time") +
  ylab("Diversity Score") +
  theme_classic()

This is the error I am getting
Error in data.frame(y_axis = c(array_1, array_2, array_3, array_4, array_5, : arguments imply differing number of rows: 46, 48, 16
What would your suggestion be for this issue?

When I used the top 4 arrays, the data frame formed seems to be skipping row number:

Hi, thanks for your feedback and code example.
I just realized there is an argument missing for array_5 & array_6 with unequal array sizes.
I will try to look into this when I find the time.
What you could try to do in the meantime is run the following to create your data.frame.
data_2x2 <- data.frame(y_axis = c(array_1, array_2, array_3, array_4, array_5, array_6),
                       x_axis = rep(c(1,1.01,2,2.01,3,3.01), each=n),
                       id = factor(rep(1:n,2)),
                       group = rep(c(labels[1], labels[2]), each=n))

Then omit the NA's (unequal rows) with na.omit (make sure to install the stats package.
if (any(is.na(data_2x2)))
  data_2x2 <- stats::na.omit(data_2x2)

I hope this resolves the unequal rows issue.

It shouldn't be much difficult, you have a line looking for size and you put everything as "n"
But if you just remove the constraint, the raincloudplots will be way more usable!!
Btw, awesome work! This visualization looks absolutely fantastic!
I used a shortcut to create my df based on your code:
set.seed(321) #df_2x3 <- data.frame(matrix(ncol = 4, nrow = 0)) #x <- c("y_axis", "x_axis", "id", "group") #colnames(df_2x3) <- x y_axis <- c(meta_taxa$alpha_shannon[(meta_taxa$Loc_Depth=="7S-Shallow")], meta_taxa$alpha_simpson[(meta_taxa$Loc_Depth=="7S-Shallow")], meta_taxa$alpha_shannon[(meta_taxa$Loc_Depth=="G-Shallow")], meta_taxa$alpha_simpson[(meta_taxa$Loc_Depth=="G-Shallow")], meta_taxa$alpha_shannon[(meta_taxa$Loc_Depth=="G-Deep")],  meta_taxa$alpha_simpson[(meta_taxa$Loc_Depth=="G-Deep")]) x_axis <- c(rep(1.0, 5), rep(1.01, 5), rep(2.0, 8), rep(2.01, 8), rep(3.0, 7), rep(3.01, 7)) id <- c(factor(rep(1:5,2)), factor(rep(1:8,2)), factor(rep(1:7,2))) group <- c(rep("Shannon",5), rep("Simpson",5), rep("Shannon",8), rep("Simpson",8), rep("Shannon",7), rep("Simpson",7))  jit <- jitter(x_axis, amount = 0.05) df_2x3 <- data.frame(y_axis, x_axis, id, group, jit)


[BACKLOG-28318] - implementing binary messages for mqtt consumer

[BACKLOG-28319] - implementing binary messages for mqtt producer

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine,plugins/streaming/impls/mqtt' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,plugins/streaming/impls/mqtt' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  assemblies/core/lib/pom.xml
  assemblies/lib/pom.xml
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStep.java
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStepMeta.java
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BlockingQueueStreamSource.java
  engine/src/test/java/org/pentaho/di/trans/streaming/common/BaseStreamStepMetaTest.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTConsumerDialog.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTProducer.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTStreamSource.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTProducerTest.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTStreamSourceTest.java
  plugins/streaming/impls/mqtt/src/test/resources/ProduceFourBinaryRows.ktr

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.step.mqtt.MQTTProducer

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.streaming.common.BaseStreamStep

Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -0.8% :small_red_triangle_down:
Method Change: -2.4% :small_red_triangle_down:

org.pentaho.di.trans.streaming.common.BaseStreamStepMeta

Complexity Change: -2.4% :small_red_triangle_down:
Instruction Change: -1.1% :small_red_triangle_down:
Line Change: -1.7% :small_red_triangle_down:
Method Change: -3.7% :small_red_triangle_down:

org.pentaho.di.trans.streaming.common.BlockingQueueStreamSource

Branch Change: -4.9% :small_red_triangle_down:
Complexity Change: -5% :small_red_triangle_down:
Instruction Change: -8% :small_red_triangle_down:
Line Change: -6.7% :small_red_triangle_down:
Method Change: -8.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on engine/src/test/java/org/pentaho/di/trans/streaming/common/BaseStreamStepMetaTest.java. Found 2018. Was expecting 2019

:heavy_exclamation_mark: Copyright year is not the current year on plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTProducerTest.java. Found 2018. Was expecting 2019

:heavy_exclamation_mark: Copyright year is not the current year on plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTStreamSourceTest.java. Found 2018. Was expecting 2019

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTConsumerDialog.java

:heavy_exclamation_mark: Unused import - org.pentaho.di.core.row.value.ValueMetaString. at Line: 39 Column: 8

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine,plugins/streaming/impls/mqtt' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,plugins/streaming/impls/mqtt' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  assemblies/core/lib/pom.xml
  assemblies/lib/pom.xml
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStep.java
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStepMeta.java
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BlockingQueueStreamSource.java
  engine/src/test/java/org/pentaho/di/trans/streaming/common/BaseStreamStepMetaTest.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTConsumerDialog.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTProducer.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTStreamSource.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTProducerTest.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTStreamSourceTest.java
  plugins/streaming/impls/mqtt/src/test/resources/ProduceFourBinaryRows.ktr

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.step.mqtt.MQTTProducer

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Branch Change: -2.6% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.streaming.common.BaseStreamStep

Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -0.8% :small_red_triangle_down:
Method Change: -2.4% :small_red_triangle_down:

org.pentaho.di.trans.streaming.common.BaseStreamStepMeta

Complexity Change: -2.4% :small_red_triangle_down:
Instruction Change: -1.1% :small_red_triangle_down:
Line Change: -1.7% :small_red_triangle_down:
Method Change: -3.7% :small_red_triangle_down:

org.pentaho.di.trans.streaming.common.BlockingQueueStreamSource

Branch Change: -4.9% :small_red_triangle_down:
Complexity Change: -5% :small_red_triangle_down:
Instruction Change: -8% :small_red_triangle_down:
Line Change: -6.7% :small_red_triangle_down:
Method Change: -8.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.googleanalytics.GaInputStepMeta

Branch Change: -1.9% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:


Feature Request: Compressing images after downloading

Prerequisites

[x] Did you read FAQ section in readme.md?
[x] Did you test with the latest releases or commit ?
[x] Did you search for existing issues in Issues?

Description
An option to use imagemagick (?) or other custom command to compress and/or resize images - a lot of the images can take up to 20+MB which is kinda unfortunate

set 'downloadresized = True' in config.ini?

ahwait

i don't think so? i'd rather have something that's as high quality as possible (so webp, downscaled to a certain resolution)

Looking at this issue and would be inclined to implement. Curious what @Nandaka thoughts are on including a new dependence? (most likely Pillow)

add a logic to call external program to do some post processing. You can use this to call any program to do the compression, e.g. imagemagick or others
Add config in [DownloadControl] section:
- enablePostProcessing = default False. Set to true to enabled post processing cmd for every downloaded files
- postProcessingCmd = command to execute. add %filename% to pass the downloaded filename.

NO ERROR HANDLING AT ALL, use on your own risk.

In looking at the code base I'm noticing the enablePostProcessing config option which seems to be never used. Could this be a location to hook into instead of adding a new option?
Also I don't see any reason we can't use ffmpeg to do simple image resizing operations.
I think I can have this feature in pretty quickly.

ok... ran into a problem. if the format is different, i think it makes clean up db no longer work properly (since the original file is no longer there)?

you need to update the db.sqlite from your own script if you want to change the filename


Missing strings in en_us.json for future translations.

Hello!
I found out that language file (en_us.json) contains only 2 strings, but there are actually more!
All screenshots that show all strings (that I found) that need to be added in en_us.json file:

Fixed in latest commit on the quilt/1.19 branch
Should be included in the next update


Set statusCode on invokedSend

For #1057
Description

Set statusCode to OK if:

invokedSend is set to true, AND
statusCode is currently unknown.

Motivation and Context

See issue for motivation and context.
How Has This Been Tested?

Added new test case.
Checklist:

[ ] I have submitted a CLA form
[ ] If applicable, I have updated the documentation accordingly.
[ ] If applicable, I have added tests to cover my changes.

LGTM


Updates AutomatedTestWidgetsFlutterBinding.pump to support microsecond precision

Updated AutomatedTestWidgetsFlutterBinding.pump to use microseconds instead of milliseconds
Added a test to prevent regression of the microsecond precision
Fixed a test that incorrectly assumed millisecond precision

Closes #112610
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[ ] All existing and new tests are passing.

In the linked issue, it looks like this was reverted before due to breakages. What was the impact?

In the first pass for this issue, the change in precision caused issues with G3 scubas. Those issues seemed to be worse than they were due to many tests having multiple scubas instead of using something like AnimationSheetBuilder with a single scuba. At that time, I didn't know how to push through those expected changes, so it got reverted and I put together a breaking change plan for this update.
That plan would be significantly more complicated, and at the end of the day still require updating each problematic scuba/golden, so it can't be easily automated either. This time I'm working with @CaseyHillers internally to give more heads up and have a better chance of getting the scuba changes pushed through.

The issue also mentioned documentation, should some be added here?

I suspect the documentation mentioned is the breaking change plan? There was a design doc and I think a migration guide that would be outdated at this point.

Ah ok! Thanks for clarifying!


Add Github Actions for Announcements Page

Added a Github Actions workflows that triggers when someone comments on issue number 181
Also created a dummy Python script that will eventually be modified to fetch and inject all comments from issue number 181.

#165

Just wanted to say, this is a very cool way to do this. Any reason why y'all chose this over something else (ex markdown file, JSON, etc.)?

Main reason we didn't go with a markdown file/JSON was that then we would need to create a new branch, make PR, then merge. Using github actions, we can actually automate all of that - we were trying to not use a CMS and still be able to get a 'ui' that we can add comments to, and then it will just magically appear on our website, even though it's static.
This is also the simplest and most maintainable way we came up with doing things after wracking our brains for a while. There definitely could be better ways of doing things, but we're small brain. 😅

Super cool stuff! Something that is maybe a long-term goal for ACM's dev team (assuming priorities don't change) is building a similar infra for the main ACM Website, and I agree that any file-based mechanism with PRs can be a bit cumbersome (especially to those w/ no technical experience). Maybe this'll work out bigger picture!
I do wonder - could you add a layer of safeguard security by making someone write the message in an issue body with a certain label/tag, and then updating the file with a bot on merge? Creative Labs does similar things with their RFCs repo.
Learn something new every day :)

Will definitely look into it. Thanks!