To be merged on Oct 7 - Release v2.2.4 - new endowed positions data

READY FOR REVIEW
Summary

#277
#279

Review By (Date)

This goes live on Oct 7 Friday so please review before that.

Criticality - 6

This is a new data set of endowed positions, so it does not impact any pages beyond the listing of positions.

Review Tasks
Setup tasks and/or behavior to test

Check out this branch
Navigate to...
Verify...

Front End Validation

[ ] Is the markup using the appropriate semantic tags and passes HTML validation?
[ ] Cross-browser testing has been performed?
[ ] Automated accessibility scans performed?
[ ] Manual accessibility tests performed?
[ ] Design is approved by @ user?

Backend / Functional Validation
Code

[ ] Are the naming conventions following our standards?
[ ] Does the code have sufficient inline comments?
[ ] Is there anything in this code that would be hidden or hard to discover through the UI?
[ ] Are there any code smells?
[ ] Are tests provided? eg (unit, behat, or codeception)

Code security

[ ] Are all forms properly sanitized?
[ ] Any obvious security flaws or new areas for attack?

General

[ ] Is there anything included in this PR that is not related to the problem it is trying to solve?
[ ] Is the approach to the problem appropriate?

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

JIRA ticket(s)
Other PRs
Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
Anyone who should be notified? (@mention them here)

Resources

AMP Tool
Accessibility Manual Test Script
HTML Validator
Browserstack and link to Browserstack Credentials

@wmui51 I've merged your latest fixup PR into this release cc @forrestglick

This looks good. Thanks for the quick last-minute update. Please merge into Prod @yvonnetangsu

GTG. Thanks!

@forrestglick merging now 😄


Add commit ids and timestamps to jar manifests

Need to add the buildnumber-maven-plugin and the add the buildNumber and timestamp to the manifest in the maven-jar-plugin configuration.

commit cf12295ac89978a1ec84fcf959f35477ed8454d5
Author: Ivan Bella<EMAIL_ADDRESS>Date:   Wed Jan 18 14:37:28 2017 -0500
fixes 133 - added the buildnumber-maven-plugin, and put the buildNumber and timestamp into each of the jar's MANIFEST


fixup markdown linter

Description
Fix markdownlinter errors
How can this be tested?
n/a
Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report

Merging #2175 (1640b99) into main (df05600) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main    #2175   +/-   ##
=======================================
  Coverage   64.19%   64.19%
=======================================
  Files         242      242
  Lines       15320    15320
=======================================
  Hits         9834     9834
  Misses       4756     4756
  Partials      730      730


ZITADEL Quotas and Log Stores: Integration tests are complete

As a developer, I want my changes to be tested, so I’m confident I won't break anything.
Acceptance Criteria

[ ] Integration tests have reasonable coverage.

Coverage is reasonable


Issue: the button showed in video page

#1

I tried fix by judge the window.location before, maybe it will fix.

Close as seems finished. Can reopen if still exists.


Actions SDK: application doesn't respond in gactions simulator if TEXT intent is not defined in actions.json

I tried simulating when action.json had TEXT defined -- worked, and when TEXT was not defined -- "Sorry Action: number facts isn’t responding right now. Try again soon."

Must have been a transient error. Today: removed TEXT from action.json and app worked. Issue closed.


Emit warning to Sentry when multi-base agreement created

Tested with BE running locally, logged here (I had to manually add the DSN when initializing the SDK).
This will not be effective during local testing.

 2.0 BE: notify when multi-base agreement created


Add support for entering roles in the page

After a feedback iteration, I believe it's no longer necessary at the moment.


Add an Option to Hide Elevation.

Due to this Package potentially being a Drag Ruler Replacement, I would suggest adding an Option to hide the Elevation on the Ruler Label, for People who never use Elevation anyway.

Thanks! Good idea.


Implement a ReportButton in each Contact field

Description
Currently, we're hiding the ReportButton component in #128 because it has no functionality yet.
This issue is similar to #83, but it's for the ContactPage instead of FaqPage.
Current Tasks

[ ] Research the Google Form URL
[ ] Implement a dynamic URL for the ReportButton
[ ] Re-enable the ReportButton in the ContactPage

Mas @zainfathoni, which Google Form I can use? Let me handle this.

Please correspond in Slack with Mas @baraeb92 and Mas Awe (Ardiwilda) for this matter. Thanks! 🙏


Use Java 11 (latest LTS)

You should really use the latest Java LTS release if you want to do a fair benchmark.

@brunoborges Thank you for noticing, you're absolutely right! Could you please also update the Dockerfile in kotlin_grpc and the clean.sh script?

@LesnyRumcajs a few things added here:

Use Java 11
Set Java benchs to use up to 70% available RAM for the JVM Heap size
Increase duration to 10min. This is because the JVM will improve performance over time. 30s is not enough for a realistic runtime/language comparison benchmark.
Limit memory to 512m by default

There is another thing to consider: the JVM has multiple Garbage Collectors. With a single CPU, the JVM will default to the SerialGC [1]. For realistic comparisons, you should consider using two CPUs for the JVM-based workloads.
And for runtimes that are single threaded by nature (e.g. Node) maybe consider a slightly different approach to compare: run two containers for Node at the same time and a third for LB, in a way that this set up equals to the JVM workload in terms of CPU and memory.
[1] https://www.baeldung.com/jvm-garbage-collectors

1. Use Java 11

Sounds good!

2. Set Java benchs to use up to 70% available RAM for the JVM Heap size

Sounds good!

3. Increase duration to 10min. This is because the JVM will improve performance over time. 30s is not enough for a realistic runtime/language comparison benchmark.

Those 30s were anyway used only for CI, to not abuse Github Actions. For actual benchmarks we we used at least 2 minutes. But I agree, increasing it brings it closer to real-world scenario.

4. Limit memory to 512m by default

A valid constraint, though it would (on our hardware) probably impact only Micronaut benchmark.

5. Default to 2 cores

There is another thing to consider: the JVM has multiple Garbage Collectors. With a single CPU, the JVM will default to the SerialGC [1]. For realistic comparisons, you should consider using two CPUs for the JVM-based workloads so it picks a better one such as ParallelGC.
And for runtimes that are single threaded by nature (e.g. Node) maybe consider a slightly different approach to compare: run two containers for Node at the same time and a third for LB, in a way that this set up equals to the JVM workload in terms of CPU and memory.
[1] https://www.baeldung.com/jvm-garbage-collectors

This I am not sure. I understand that technologies with GC struggle with single-core benchmark but it's also a valid test (not very real-world, but it's nice to see how different technologies behave under specific conditions). We do try to make it fair by benchmarking also with realistic 3 CPU limit, please look up the results. From these results it's rather clear which servers should be put behind a LB (e.g. rust_tonic_st, node_grpc_st) and which scale nicely without this (e.g. java_grpc). Adding another set of tests, with LB + single-threaded servers vs Java / Dotnet / Go sounds reallly interesting, thanks for the idea!
This setting -XX:+UseParallelGC -XX:+ParallelGCThreads=2 seem to force JVM to use this specific GC, am I correct? This would then hamper the performance for JVM-based benchmarks on 1 CPU, no? Shouldn't then it be chosen automatically, based on benchmark settings? Are those settings optimal for 3 CPUs as well? Feel free to correct me if I'm wrong, I'm not a Java expert. :)

@brunoborges current settings seem to have issues on Github Actions, does it work locally for you?
Benchmark finished. Detailed results are located in: results/200608T203118
Warning: no stats for reports/kotlin_grpc_test.stats
Warning: no stats for reports/scala_akka_test.stats
Warning: no stats for reports/java_grpc_test.stats
Warning: no stats for reports/java_micronaut_test.stats
----------------------------------------------------------------------------
| name               |   req/s |   avg. latency | avg. cpu |   avg. memory |
----------------------------------------------------------------------------
| rust_tonic_st      |   21650 |        2.26 ms |   44.53% |      5.71 MiB |
| cpp_grpc_st        |   18041 |        2.72 ms |   58.07% |      3.09 MiB |
| go_grpc            |   16282 |        3.01 ms |   66.58% |     12.88 MiB |
| lua_grpc_st        |   15450 |        3.17 ms |   83.05% |     15.01 MiB |
| rust_tonic_mt      |   14432 |        3.39 ms |   82.41% |      6.66 MiB |
| dotnet_grpc        |   14212 |        3.45 ms |   88.31% |     116.1 MiB |
| rust_thruster      |   14062 |        3.49 ms |   67.18% |      2.26 MiB |
| crystal_grpc       |   13417 |        3.67 ms |   48.34% |      5.54 MiB |
| csharp_grpc        |   11570 |        4.26 ms |  100.61% |     79.13 MiB |
| node_grpc_st       |   10309 |        4.78 ms |   91.29% |     23.55 MiB |
| cpp_grpc_mt        |   10060 |        4.90 ms |  124.25% |      5.06 MiB |
| java_aot           |    7196 |        6.90 ms |  118.83% |     100.2 MiB |
| node_grpcjs_st     |    6377 |        7.77 ms |   98.32% |     27.88 MiB |
| php_grpc           |    6318 |        7.85 ms |  117.03% |      48.1 MiB |
| dart_grpc          |    5102 |        9.70 ms |  110.13% |     29.36 MiB |
| elixir_grpc        |    3721 |       13.37 ms |  119.89% |     54.09 MiB |
| swift_grpc_st      |    3681 |       13.50 ms |   98.31% |      4.29 MiB |
| ruby_grpc          |    3481 |       14.20 ms |   87.22% |     18.27 MiB |
| python_grpc        |    2000 |       24.91 ms |   99.95% |     21.64 MiB |
| scala_akka         |       0 |        0.18 ms |       0% |         0 MiB |
| java_micronaut     |       0 |        0.28 ms |       0% |         0 MiB |
| java_grpc          |       0 |        0.28 ms |       0% |         0 MiB |
| kotlin_grpc        |       0 |        0.23 ms |       0% |         0 MiB |
----------------------------------------------------------------------------

These all valid points, but I do agree with @LesnyRumcajs with keeping the defaults 30s/1 cpu for the CI as it's used just to check the correctness. We should instead perform longer duration benchmarks while we produce the results for the wiki.
About ``ParallelGCThreads maybe we can pass it the number of cpus to the docker run command and derive the best value? For instance 1 for cpus < 2, otherwise number of cpus?

IMO the hardware limits should be there starting from 1 CPU. We should find a way to go beyond 3 CPUs though, as it seems Java scales really well...
10 minutes per test is a bit too much IMO. @brunoborges do you have any numbers to share running the test 30 s vs 2 min vs 10 min?

@berestovskyy 3 CPU is only the limit on our hardware, most of the machine's computing power is taken by gRPC client ghz. We'd probably need a 24 core machine to properly stress e.g. rust_tonic_mt with server limited to 5.

@Trisfald it's fair to use X threads (where X = # of CPUs) for the ParallelGC for benchmarks up to 4 cores where heap size is up to 1GB. Beyond that, other GCs should be considered.

@brunoborges scala bench still seems to fail, running the container yields:
Error: Could not find or load main class $JAVA_OPTS
Caused by: java.lang.ClassNotFoundException: $JAVA_OPT

Shall we perhaps go forward with using the latest LTS in this PR and address the JVM options in another one?

@LesnyRumcajs I ran a bench here and all worked, except scala.
Just for the record, here are the results I got:
GRPC_BENCHMARK_DURATION="300s"
GRPC_SERVER_CPUS="3"
GRPC_SERVER_RAM="512m"

Benchmark finished. Detailed results are located in: results/200808T001153
Warning: no stats for reports/scala_akka_test.stats
----------------------------------------------------------------------------
| name               |   req/s |   avg. latency | avg. cpu |   avg. memory |
----------------------------------------------------------------------------
| go_grpc            |   49413 |        0.96 ms |  229.07% |      13.0 MiB |
| rust_tonic_mt      |   46868 |        1.02 ms |  232.19% |      7.39 MiB |
| cpp_grpc_mt        |   43756 |        1.09 ms |  268.57% |      7.26 MiB |
| rust_tonic_st      |   42496 |        1.12 ms |   97.28% |      6.52 MiB |
| java_grpc          |   41119 |        1.16 ms |  295.16% |     223.1 MiB |
| java_micronaut     |   40661 |        1.18 ms |  298.23% |     248.6 MiB |
| dotnet_grpc        |   36798 |        1.31 ms |   217.9% |     81.08 MiB |
| csharp_grpc        |   29123 |        1.66 ms |  305.09% |     76.83 MiB |
| kotlin_grpc        |   28109 |        1.72 ms |  303.68% |    161.42 MiB |
| cpp_grpc_st        |   27694 |        1.76 ms |  101.31% |      3.22 MiB |
| lua_grpc_st        |   16525 |        2.97 ms |  101.22% |     12.93 MiB |
| java_aot           |   15369 |        3.19 ms |  301.45% |    105.56 MiB |
| node_grpc_st       |   11738 |        4.18 ms |  100.98% |     42.53 MiB |
| php_grpc           |    9597 |        5.15 ms |  305.35% |     38.64 MiB |
| node_grpcjs_st     |    8777 |        5.61 ms |  113.48% |     28.08 MiB |
| elixir_grpc        |    7486 |        6.61 ms |  295.49% |     58.88 MiB |
| dart_grpc          |    7048 |        7.04 ms |  108.55% |     29.11 MiB |
| rust_thruster      |    6445 |        7.68 ms |   72.08% |      2.32 MiB |
| swift_grpc_st      |    4580 |       10.82 ms |    99.8% |      4.05 MiB |
| python_grpc        |    3292 |       15.12 ms |  149.12% |     19.76 MiB |
| ruby_grpc          |    2745 |       18.13 ms |   131.3% |      18.4 MiB |
| crystal_grpc       |    2114 |       23.53 ms |    16.9% |      5.79 MiB |
| scala_akka         |       0 |        0.03 ms |       0% |         0 MiB |
----------------------------------------------------------------------------

I will look into the Scala bug.

Scala results are in for the same setup:
GRPC_BENCHMARK_DURATION="300s"
GRPC_SERVER_CPUS="3"
GRPC_SERVER_RAM="512m"

 Benchmark finished. Detailed results are located in: results/200808T230753
----------------------------------------------------------------------------
| name               |   req/s |   avg. latency | avg. cpu |   avg. memory |
----------------------------------------------------------------------------
| scala_akka         |   11735 |        4.20 ms |  303.77% |    267.56 MiB |
----------------------------------------------------------------------------

And for the record, this is the machine I am using. It is an 8-core VM with 16GB RAM.
vendor_id	: GenuineIntel
cpu family	: 6
model		: 63
model name	: Intel(R) Xeon(R) CPU E5-1620 v3 @ 3.50GHz
stepping	: 2
microcode	: 0x43
cpu MHz		: 1197.379
cache size	: 10240 KB

Looks really good to me, thank you! Faith in Java technology restored. ;)
Let's rebase and then we can merge.

I got even better results with the latest GA (14), especially in terms of memory consumption.
Given I made several changes beyond just upgrading Java, I'll go ahead and close this PR and submit a new one with less changes beyond upgrading Java and a few JVM settings for this kind of scenario.


Hiding frontend edit buttons

Can I hide the frontend edit buttons when logged in as an admin?

Yes they are in the templates you would have to remove the buttons, including the one in the footer :)

I don't see them in the templates, for instance I see the menu module adds it in the MenuServiceTrait.  Can I override that?  If the future made add a unique class to those so we can hide them in the css.

In the theme 'templates' there are blade directives that look like @edit('pages', $page->id) you need to remove those from the theme to get rid of them :) CSS would also be good I'll make a note thanks.

Sorry to bother.  I see this for my modules and the publish assets, but not for widgets or menus

Hmmm, it seems thats built into the menus and widgets.... I could make an override option. Do you think it should be config option or menu / widget specific?

I personally think a config option would be good enough.  Thank you.


'DATA' tab does not show statistics for converted columns

STR

Create a map from a table that has at least one column with numeric data
In DATA tab for the layer, it should show the usual stats

Then go to the table view and change the data type of that column to string
Reload the map, it now shows it's a string column

And if you add it as a widget, it will be a category one

go to table view and convert again to number. The DATA tab shows it's a number, but the preview histogram is gone. Also the column is now at the bottom of the list

If you add it as a widget, it will be a histogram

The column is correctly recognised as number, but statistics and preview histogram is not shown. After creating a new map from the same dataset, the DATA tab still don't show the preview histogram or the stats

Please ping me if the instructions to reproduce are not clear

Prioritizing this since it's happening a lot. Lots of columns are not being correctly rendered.

Stale issue. Closing 👋


Documentation: Upgrade Note edit

Provide more specific Cilium upgrade notes for documentation to remove ambiguity for the end-user.

This change is

test-docs-please

Please append the 'area' of your commit in the commit message, i.e. Documentation: upgrade note edit


Added a Pipelines architecture diagram

Partially addresses https://github.com/kubeflow/website/issues/573 and https://github.com/kubeflow/website/issues/532 - but only for Pipelines.

This change is

Preview: https://deploy-preview-614--competent-brattain-de2d6d.netlify.com/docs/pipelines/pipelines-overview/#architectural-overview

/assign @IronPan

/lgtm
/approve


create_site method to migrate sites; request timeout=30; refactor requests usage

Changes

Needed create_site method to get RED-2720 done.

Added default requests timeout to 30 seconds

@thraxil: Network requests should never be made without specifying a timeout. By default requests will hang forever if the service it's trying to connect to isn't available.

Refactored how requests are used for cleaner Client code.

Good catch @thraxil. I've set default timeout to 30, please give it another go.


Add anton-boyko

Docs Build status updates of commit 8aa7cd0:
:warning: Validation status: warnings

File
Status
Preview URL
Details

rd/index.yml
:warning:Warning

Details

rd/map.yml
:warning:Warning

Details

rd/anton-boyko.yml
:white_check_mark:Succeeded

rd/media/profiles/anton-boyko.jpg
:white_check_mark:Succeeded

rd/toc.yml
:white_check_mark:Succeeded

rd/index.yml

Line 0: [Warning-InvalidFileLink] Invalid file link:(~/about).
Line 0: [Warning-InvalidFileLink] Invalid file link:(~/CodeOfConduct).
Line 0: [Warning-InvalidFileLink] Invalid file link:(~/map).

rd/map.yml

Line 0: [Warning-InvalidFileLink] Invalid file link:(~/about).
Line 0: [Warning-InvalidFileLink] Invalid file link:(~/CodeOfConduct).
Line 0: [Warning-InvalidFileLink] Invalid file link:(~/map).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Testkit

This PR is the first step towards making it easier to do large-scale property tests on scala.meta-based libraries/applications. The code in this PR originates from fastparse/scalafmt/syntax-experiments but has been now been generalized and properly documented.
In the process of creating testkit, I found 9 examples of parser bugs and 2.249 examples of pretty-printing bugs. The pretty markdown tables are generated by the testkit in this PR.
Known issue: for some reason the ParserProperties analysis is super slow on the CI server but runs in <2 minutes on my laptop. I suggest we address this issue in a future PR, as I don't have time to investigate it further right now. This PR is already quite useful.

LGTM. Please merge when green/

This is awesome 🎉


debug/pe: RiscV64 is not supported

What version of Go are you using (go version)?

$ go version
go version go1.18.1 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/abeato/.cache/go-build"
GOENV="/home/abeato/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/abeato/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/abeato/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.18"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.18/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3245950783=/tmp/go-build -gno-record-gcc-switches"

What did you do?
IMAGE_FILE_MACHINE_RISCV64 is not supported in the debug/pe package. That should be a matter of simply adding a test for it in a couple of places, like in https://github.com/golang/go/commit/0ca0551f02257283d00c01303100a16433c526c6
What did you expect to see?
NA
What did you see instead?
NA

CC @alexbrainman, @golang/riscv64.


Make use of display value in confirms and responses

If the user says Seattle, response with "Weather for Seattle ..." , not "Weather for Seattle, King County, Washington, United States of America ..."

The specific location problem was fixed in https://github.com/stanford-oval/almond-cloud/pull/684 and the rest I don't think it's a bug. Closing.


Extend Eat to have the additional claims in EatCWTClaim

Currently ConciseTaStore depends on EatCWTClaim where EatCWTClaim had four additional fields needed in this context. The four additional fields are named: HardwareModelLabel, HardwareVersionScheme, SoftwareNameLabel, SoftwareVersionScheme.
The original Eat{} situated in veraison/eat, should be extended to include these four additional fields and EatCWTClaim should be made obsolete. This will result in ConciseTaStore depending on the original Eat{} object in veraison/eat

See also https://github.com/veraison/eat/issues/21


Allow override for Microsoft.Bot.Builder.AI.QnA.Dialogs.QnAMakerDialog

Class I'm referring to:
https://github.com/microsoft/botbuilder-dotnet/blob/main/libraries/Microsoft.Bot.Builder.AI.QnA/Dialogs/QnAMakerDialog.cs
Is your feature request related to a problem? Please describe.
The QnAMaker Dialog is a great boilerplate template to get up and running with the QnA service and Bot Service, but it is frustrating that I cannot modify the response back to the user. Particularly the method DisplayQnAResultAsync. With this change, I could return adaptive cards back to the user instead of plain text.
Describe the solution you'd like
change:
private async Task<DialogTurnResult> DisplayQnAResultAsync(WaterfallStepContext stepContext, CancellationToken cancellationToken)
to:
protected async virtual Task<DialogTurnResult> DisplayQnAResultAsync(WaterfallStepContext stepContext, CancellationToken cancellationToken)
Describe alternatives you've considered
Re-implement the class from the source code. It is pretty counter-productive to have to copy 600+ lines of code to just modify a response

@pchoudhari can you comment?

Thanks for the suggestion, we will triage this. Assigning to @vipeketi and @DishaAgarwal

@sahithikkss, could you address the PR comment so it could be merged?  Thanks! https://github.com/microsoft/botbuilder-dotnet/pull/4574


Solidarity Update from @netanoir

I am bring over this pull request by @netanoir https://github.com/netanoir/ml5-website/pull/1

remove Tony McDade's deadname
add names of Black women missing from this list: Regis Korchinski-Paquet, Nina Pop, Monika Diamond
remove donation suggestions to funds that have been criticized by the community, especially #8CantWait
add Breonna Taylor's fund to donation suggestions
add donation suggestions to lesser known & vetted funds: local bail funds list, Emergency Release Fund, Survived & Punished, Movement for Black Lives
reorganize donation suggestions to prioritize local & lesser known funds

@shiffman: While we're on the topic of conversation, a few others I think we could add here:

Sandra Bland
David McAtee

@bomanimc I addressed your comments in https://github.com/ml5js/ml5-website/pull/159/commits/cabfc11a1f883f16510c89ea8836bc6c0fbe1395 and https://github.com/ml5js/ml5-website/pull/159/commits/d7f2914e0992917111b4c5b31177f27ed5b169ec. I had some errors trying to build the site locally to double-check but since all the tests passed do you think it's ok to merge?

I'll also note that I made arbitrary decisions with the order of the names and I am glad to re-arrange based on any feedback of course.

@shiffman Hmmm, I'm not sure about the local tests (I also haven't worked in this repo for a while), but I think we should be okay to merge since the deploy preview looks good: https://deploy-preview-159--ml5-website.netlify.app/
Regarding the ordering, we could consider ordering reverse chronologically on the date that each person passed on, but I think having a less systematic ordering makes sense since it gives us the opportunity to include names that have not been called on enough to the top of the list (that's why I like the placement of the names of Black women that Neta added).
I think the order is probably okay overall. One change I'd suggest:

Move Breanna Taylor's to be among the first four names on the list since Breanna's name is one of the most widely know at the moment (along with George Floyd and Ahmaud Arbery). If we're starting the list with these more well-known names, my preference would be to put Breanna Taylor's name in the first position on the list.

I've adjusted the order according to @bomanimc's feedback and checked the deploy-preview. I am going to merge now. If there is additional feedback or comment I am glad to make further adjustments. Thank you everyone for your time working on this and thoughtfulness.


github author photo not rendered properly

node . -g https://github.com/josephsavona/rfcs/blob/server-components/text/0000-server-components.md

fixed by mira


steal-stache should be in plugins-config

steal-stache should be as default (like steal-less) in the plugin-config of steal.
https://github.com/donejs/generator-donejs/blob/major/app/index.js#L162
currently any donejs app will not work in production i steal-stache is missing in the plugins-config
cc @phillipskevin

done-component should also be added by the generator.


Fix common package installation errors

If there's a yarn.lock in the root, prefer yarn, unless there's a package-lock.json
Pass --no-immutable to yarn2 to override CI=true
Pass --no-frozen-lockfile to pnpm to override CI=true
Skip a bunch of unmanageable repos

Bonus: improve error output

yarn and pnpm tend to mix stderr and stdout, so print both
Drop all npm WARN lines, rather than trying to identify special ENOSPC lines (whackamole style)

How do you currently know if we should be using yarn 1, 2, or 3? Do the newer ones subsume the older ones?

isRepoYarn2

ah

Pass --no-immutable to yarn2 to override CI=true
Pass --no-frozen-lockfile to pnpm to override CI=true

So we intentionally want to run with newer dependencies, right?

How do you currently know if we should be using yarn 1, 2, or 3? Do the newer ones work on the older ones?

Is there a yarn 3?  There's one repo that rejects --mode:skip-build in favor of --skip-build and I couldn't figure out why.  Didn't seem important, so I didn't investigate.  Yarn 2 we detect based on additional config files.
AFAIK, yarn 1 and yarn 2 are mutually incompatible, chiefly because they take different arguments.

Pass --no-immutable to yarn2 to override CI=true
Pass --no-frozen-lockfile to pnpm to override CI=true

So we intentionally want to run with newer dependencies, right?

I didn't see a ci equivalent for yarn or pnpm, so I assumed this was just a sign that some people had failed to keep their lockfiles up-to-date.  If you know of one, I'm happy to switch.


invalid transaction: Transaction failed to sanitize accounts offsets correctly REOPEN

So what was the root cause of transactions ? My Code
I have 0.001 sol on account
`@GetMapping("/send_transaction")
public ResponseEntity<?> sendTransaction() {
PublicKey fromPublicKey = new PublicKey("PUBLIC-EXAMPLE-SECURED");
PublicKey toPublickKey = new PublicKey("PUBLIC-EXAMPLE-SECURED");
int lamports = 10000;
String secretBase64 = "SECRET-KEY-EXAMPLE-SECURED";
    Account signer = new Account(Base64.getDecoder().decode(secretBase64));

    TransactionInstruction instruction = SystemProgram.transfer(
            fromPublicKey,
            toPublickKey,
            lamports
    );
    Transaction transaction = new Transaction();
    transaction.addInstruction(instruction);

    try {
        RpcApi api = client.getApi();

        transaction.setRecentBlockHash(api.getRecentBlockhash());
        transaction.sign(signer);

        return ResponseEntity.ok(api.sendTransaction(transaction, signer));

    } catch (RpcException e) {

        return ResponseEntity.status(500).body(e);
    }
}`

You aren't supposed to sign the transactions outside of RpcApi (it handles it for you). Remove that line and try again


React-snap integration

Hi there!
So i'm trying to use react-snap wo SSR to prerender SPA and i have some loadable-components.
Been using this entry:
...
import { loadableReady } from '@loadable/component'

const Render = () => (
  <Provider store={store}>
    <PersistGate loading={null} persistor={persistor}>
      <ConnectedRouter history={history}>
        <App />
      </ConnectedRouter>
    </PersistGate>
  </Provider>
)

const rootElement = document.getElementById('app')

if (rootElement.hasChildNodes()) {
  loadableReady().then(() => {
    hydrate(<Render />, rootElement)
  })
} else {
  render(<Render />, rootElement)
}

App loads fine, but post-build with react-snap results in this error:
loadableReady() requires state, please use getScriptTags or getScriptElements server-side
cant i just pre render components client side?

Hello @yyynnn why is it closed? Did you solve it? React snap is not yet supported but we would like to work on it.

@neoziro unfortunately no. Just realized that pre-render wont cut it. But will try to dig in deeper on other project.

Hello, I close it. React Snap will not be supported at this time.


Put a default height, It cant be according to uploaded image height

Fixed issue. Please review.


"Choose file..." not being replaced with selected file name on File Input field (BS5-alpha2)

In Bootstrap v5, alpha 2, using the new File Input won't display the file name selected. I used this sample code from the v5 documentation:

  <input type="file" class="form-file-input" id="image_homepage" name="image_homepage">

    Choose file...
    Browse

When I click on "Choose file..." then select a file, the form-file-text still shows "Choose file..." instead of being replaced with the name of the file chosen. This same issue is present in the file input sample on the Bootstrap 5 documentation site. https://v5.getbootstrap.com/docs/5.0/forms/file/
Hopefully this can be fixed to show the file name selected just like the standard HTML file input field.

Duplicate of #30265.


Taker cannot rollover one position but can rollover another one

taker version 0.5.0
network: mainnet
peerid: 12D3KooWQKVeZWeD5WBKEjN4pDVjmd4VwyNrdm2Ey6bJWGW7FEw7
takerid: 921d68aa0b584901d038b6460d3155464febe2dbad74c77a9eae91be60a4c771
orderid: 2c6b3182-f648-4f96-87c2-60a698501e33
I noticed that I cannot collaborative settle a position. In the UI I only get

In the console I see:
2022-08-04 22:20:58 DEBUG http: Handled request method=POST path=/api/cfd/2c6b3182-f648-4f96-87c2-60a698501e33/settle status=500 Internal Server Error
2022-08-04 22:23:52 DEBUG POST /cfd/<id>/<action>{id=2c6b3182-f648-4f96-87c2-60a698501e33 action="settle"}:propose_settlement{order_id=OrderId(2c6b3182-f648-4f96-87c2-60a698501e33)}:xtra_actor_request{actor_type=daemon::taker_cfd::Actor<daemon::oracle::Actor, daemon::wallet::Actor<bdk::blockchain::electrum::ElectrumBlockchain, sled::tree::Tree>> message_type=daemon::taker_cfd::ProposeSettlement}:xtra_message_handler:Handle ProposeSettlement: daemon::taker_cfd: Proposing settlement of contract order_id=2c6b3182-f648-4f96-87c2-60a698501e33 proposal_closing_price=22560.5 bid=22560 ask=22560.5 quote_timestamp=2022-08-04T22:23:00Z
2022-08-04 22:23:52 ERROR POST /cfd/<id>/<action>{id=2c6b3182-f648-4f96-87c2-60a698501e33 action="settle"}:propose_settlement{order_id=OrderId(2c6b3182-f648-4f96-87c2-60a698501e33)}: daemon: error=could not start closing position
2022-08-04 22:23:52 ERROR POST /cfd/<id>/<action>{id=2c6b3182-f648-4f96-87c2-60a698501e33 action="settle"}: taker::routes: error=500 Internal Server Error - settle failed - could not start closing position: Failed to execute command on CFD: Collaborative close without DLC
2022-08-04 22:23:52 DEBUG http: Handled request method=POST path=/api/cfd/2c6b3182-f648-4f96-87c2-60a698501e33/settle status=500 Internal Server Error

I checked the maker logs and it looks like this position was not rolled over in 12h.
Last error from the maker with this peerid was an error:
{"timestamp":"2022-08-03T11:24:01.217609062Z","level":"DEBUG","fields":{"message":"Failed to send offers: Timeout in protocol negotiation","peer":"12D3KooWQKVeZWeD5WBKEjN4pDVjmd4VwyNrdm2Ey6bJWGW7FEw7"},"target":"xtra_libp2p_offer::maker","span":{"err":"Timeout in protocol negotiation","name":"fallible task handle_error"}}

Last error on the taker side:
2022-08-04 22:16:43 DEBUG fallible task handle_error{err=The stream has terminated.}: xtra_libp2p_offer::taker: Failed to process maker offers: The stream has terminated. peer=12D3KooWP3BN6bq9jPy8cP7Grj1QyUBfr7U6BeQFgMwfTTu12wuY

Interestingly, my other position c41068f5-d058-48bf-9f56-34dba41e43bd is being rolled over fine.

Oh, this seems to be the related error:
Collaborative close without DLC

coming from here:
https://github.com/itchysats/itchysats/blob/40da37ee059117039ceafcfe24abf44520fe5c62/model/src/cfd.rs#L1079

Taker logs 2h after the last successful rollover of the effected position:
2022-08-04 05:01:02  INFO model::cfd: Rollover was completed order_id=2c6b3182-f648-4f96-87c2-60a698501e33
2022-08-04 05:01:02 DEBUG daemon::oracle: Fetching attestation for /x/BitMEX/BXBT/2022-08-04T05:00:00.price?n=20
2022-08-04 05:01:02  INFO xtra_actor_request{actor_type=daemon::oracle::Actor message_type=daemon::oracle::NewAttestationFetched}:xtra_message_handler:Handle NewAttestationFetched: daemon::oracle: Fetched new attestation for /x/BitMEX/BXBT/2022-08-04T05:00:00.price?n=20
2022-08-04 05:01:03  INFO xtra_actor_request{actor_type=daemon::process_manager::Actor message_type=daemon::process_manager::Event}:xtra_message_handler:Handle Event: sqlite_db: Appended event to database event=RolloverCompleted order_id=2c6b3182-f648-4f96-87c2-60a698501e33
2022-08-04 05:01:03  INFO daemon::rollover::protocol: Rollover completed order_id=2c6b3182-f648-4f96-87c2-60a698501e33
2022-08-04 05:01:24 DEBUG Send message every interval{interval_secs=20}:xtra_actor_request{actor_type=daemon::monitor::Actor message_type=daemon::monitor::Sync}:xtra_message_handler:Handle Sync:Sync monitor: btsieve: Found relevant Bitcoin transaction txid=2d23b696ebcb9b732722495a51df7e2faec28272fbfcb72f38998e97d33070d3 status=confirmed with 278 blocks
2022-08-04 05:01:24 DEBUG Send message every interval{interval_secs=20}:xtra_actor_request{actor_type=daemon::monitor::Actor message_type=daemon::monitor::Sync}:xtra_message_handler:Handle Sync:Sync monitor: btsieve: Bitcoin transaction reached monitoring target txid=2d23b696ebcb9b732722495a51df7e2faec28272fbfcb72f38998e97d33070d3 target=confirmed with 1 blocks current=confirmed with 278 blocks
2022-08-04 05:01:24  INFO Send message every interval{interval_secs=20}:xtra_actor_request{actor_type=daemon::monitor::Actor message_type=daemon::monitor::Sync}:xtra_message_handler:Handle Sync:Sync monitor:xtra_actor_request{actor_type=daemon::process_manager::Actor message_type=daemon::process_manager::Event}:xtra_message_handler:Handle Event: sqlite_db: Appended event to database event=LockConfirmed order_id=2c6b3182-f648-4f96-87c2-60a698501e33
2022-08-04 05:26:41 DEBUG fallible task handle_error{err=The stream has terminated.}: xtra_libp2p_offer::taker: Failed to process maker offers: The stream has terminated. peer=12D3KooWP3BN6bq9jPy8cP7Grj1QyUBfr7U6BeQFgMwfTTu12wuY
2022-08-04 05:53:40 DEBUG fallible task handle_error{err=The stream has terminated.}: xtra_libp2p_offer::taker: Failed to process maker offers: The stream has terminated. peer=12D3KooWP3BN6bq9jPy8cP7Grj1QyUBfr7U6BeQFgMwfTTu12wuY
2022-08-04 06:00:13 DEBUG Send message every interval{interval_secs=60}:xtra_actor_request{actor_type=daemon::oracle::Actor message_type=daemon::oracle::SyncAnnouncements}:xtra_message_handler:Handle SyncAnnouncements:Fetch announcement: daemon::oracle: Fetching announcement event_id=/x/BitMEX/BXBT/2022-08-05T08:00:00.price?n=20
2022-08-04 06:01:12  INFO xtra_actor_request{actor_type=daemon::process_manager::Actor message_type=daemon::process_manager::Event}:xtra_message_handler:Handle Event: sqlite_db: Appended event to database event=RolloverStarted order_id=c41068f5-d058-48bf-9f56-34dba41e43bd
2022-08-04 06:01:12  INFO xtra_actor_request{actor_type=daemon::process_manager::Actor message_type=daemon::process_manager::Event}:xtra_message_handler:Handle Event: sqlite_db: Appended event to database event=RolloverAccepted order_id=c41068f5-d058-48bf-9f56-34dba41e43bd
2022-08-04 06:01:12  INFO daemon::rollover::taker: Rollover proposal got accepted order_id=c41068f5-d058-48bf-9f56-34dba41e43bd
2022-08-04 06:01:13 DEBUG daemon::oracle: Fetching attestation for /x/BitMEX/BXBT/2022-08-04T06:00:00.price?n=20
2022-08-04 06:01:13  INFO xtra_actor_request{actor_type=daemon::oracle::Actor message_type=daemon::oracle::NewAttestationFetched}:xtra_message_handler:Handle NewAttestationFetched: daemon::oracle: Fetched new attestation for /x/BitMEX/BXBT/2022-08-04T06:00:00.price?n=20
2022-08-04 06:01:22  INFO model::cfd: Rollover was completed order_id=c41068f5-d058-48bf-9f56-34dba41e43bd
2022-08-04 06:01:24  INFO xtra_actor_request{actor_type=daemon::process_manager::Actor message_type=daemon::process_manager::Event}:xtra_message_handler:Handle Event: sqlite_db: Appended event to database event=RolloverCompleted order_id=c41068f5-d058-48bf-9f56-34dba41e43bd
2022-08-04 06:01:24  INFO daemon::rollover::protocol: Rollover completed order_id=c41068f5-d058-48bf-9f56-34dba41e43bd
2022-08-04 06:01:44 DEBUG Send message every interval{interval_secs=20}:xtra_actor_request{actor_type=daemon::monitor::Actor message_type=daemon::monitor::Sync}:xtra_message_handler:Handle Sync:Sync monitor: btsieve: Found relevant Bitcoin transaction txid=cb0f94a037e85a2943cdb0d0c4879c123afd2bd7a003f63636c40e3f5c90d6e7 status=confirmed with 1525 blocks
2022-08-04 06:01:44 DEBUG Send message every interval{interval_secs=20}:xtra_actor_request{actor_type=daemon::monitor::Actor message_type=daemon::monitor::Sync}:xtra_message_handler:Handle Sync:Sync monitor: btsieve: Bitcoin transaction reached monitoring target txid=cb0f94a037e85a2943cdb0d0c4879c123afd2bd7a003f63636c40e3f5c90d6e7 target=confirmed with 1 blocks current=confirmed with 1525 blocks
2022-08-04 06:01:44  INFO Send message every interval{interval_secs=20}:xtra_actor_request{actor_type=daemon::monitor::Actor message_type=daemon::monitor::Sync}:xtra_message_handler:Handle Sync:Sync monitor:xtra_actor_request{actor_type=daemon::process_manager::Actor message_type=daemon::process_manager::Event}:xtra_message_handler:Handle Event: sqlite_db: Appended event to database event=LockConfirmed order_id=c41068f5-d058-48bf-9f56-34dba41e43bd
2022-08-04 06:07:45 DEBUG fallible task handle_error{err=The stream has terminated.}: xtra_libp2p_offer::taker: Failed to process maker offers: The stream has terminated. peer=12D3KooWP3BN6bq9jPy8cP7Grj1QyUBfr7U6BeQFgMwfTTu12wuY
2022-08-04 06:38:41 DEBUG fallible task handle_error{err=The stream has terminated.}: xtra_libp2p_offer::taker: Failed to process maker offers: The stream has terminated. peer=12D3KooWP3BN6bq9jPy8cP7Grj1QyUBfr7U6BeQFgMwfTTu12wuY
2022-08-04 07:00:48 DEBUG Send message every interval{interval_secs=60}:xtra_actor_request{actor_type=daemon::oracle::Actor message_type=daemon::oracle::SyncAnnouncements}:xtra_message_handler:Handle SyncAnnouncements:Fetch announcement: daemon::oracle: Fetching announcement event_id=/x/BitMEX/BXBT/2022-08-05T09:00:00.price?n=20
2022-08-04 07:01:29 DEBUG daemon::oracle: Fetching attestation for /x/BitMEX/BXBT/2022-08-04T07:00:00.price?n=20
2022-08-04 07:01:29  INFO xtra_actor_request{actor_type=daemon::oracle::Actor message_type=daemon::oracle::NewAttestationFetched}:xtra_message_handler:Handle NewAttestationFetched: daemon::oracle: Fetched new attestation for /x/BitMEX/BXBT/2022-08-04T07:00:00.price?n=20

It looks like my taker just stopped trying to rollover.

I restart of the taker seems to have solved this problem. I think this is a critical bug as we can't expect users to monitor their service and restart in time.

@bonomat and I had a look at this for a short while and we made some observations:

No RolloverStarted events were found in the database for this CFD after the last successful rollover before the restart. This means that the autorollover::Actor was either not finding it in the database or marking it as ineligible:

https://github.com/itchysats/itchysats/blob/b7d49fdf8cd68872a63e9e0cb913df122355c08f/daemon/src/auto_rollover.rs#L101-L114

Rollovers were being run for other CFDs whilst this was happening.
Collaborative settlement failed because of a missing DLC.
The CFD was rolled over successfully after a restart (and shortly thereafter closed collaboratively).

Therefore, we think the problem must lie in the database. We must have been unable to load the DLC from the database for the last RolloverCompleted event:
https://github.com/itchysats/itchysats/blob/b7d49fdf8cd68872a63e9e0cb913df122355c08f/sqlite-db/src/lib.rs#L680-L692
Or maybe something could have gone wrong when inserting, although we didn't see any errors:
https://github.com/itchysats/itchysats/blob/b7d49fdf8cd68872a63e9e0cb913df122355c08f/sqlite-db/src/lib.rs#L262-L265

Experienced this problem locally:
2022-08-31 04:55:40 ERROR Send message every interval{interval_secs=300}:xtra_actor_request{actor_type=daemon::auto_rollover::Actor message_type=daemon::auto_rollover::AutoRollover}:xtra_message_handler:Handle AutoRollover: daemon::auto_rollover: Cannot auto-rollover CFD without a DLC order_id=880374a1-bbf8-4408-bd5e-832c47ebd608

The taker has 2 cfds in the cfds table:

1:  880374a1-bbf8-4408-bd5e-832c47ebd608: on the maker side this one was marked as failed
2: 0103e4e3-9e73-48f1-8e5d-2e70bba17320: this one does not exist on the maker side

I assume both should end up in the failed_cfds table

@bonomat: Should we close this ticket then?

I'm not sure these situation are 100% related. On mainnet I had two open positions of which one was able to rollover and the otherone just stopped.

I'm not sure these situation are 100% related. On mainnet (when I openend this issue in the first place) I had two open positions of which one was able to rollover and the otherone just stopped.

But is this issue originally a duplicate of https://github.com/itchysats/itchysats/issues/2471 which was solved by https://github.com/itchysats/itchysats/pull/2671?

Fair enough :) Closing this for now. See comment above.

It looks like something similar to this happened on mainnet:
A taker had multiple positions but one never rolled over nor was requested a rollover: 4d904fab-cf99-435d-aede-8b2d0d2d43cf was never requested to be rolledover.

Experienced this problem locally:
taker side:
2022-08-31 04:55:40 ERROR Send message every interval{interval_secs=300}:xtra_actor_request{actor_type=daemon::auto_rollover::Actor message_type=daemon::auto_rollover::AutoRollover}:xtra_message_handler:Handle AutoRollover: daemon::auto_rollover: Cannot auto-rollover CFD without a DLC order_id=880374a1-bbf8-4408-bd5e-832c47ebd608

Maker does not show anything

Same behavior again. Note, the taker (12D3KooWRG3cBytxhAiHBZYeXCb8nDRWLLfDdy9Yn31MDr9WVdeR) is on version 0.7.0

Originally the conclusion of the problem was that we did not properly append rollover + data to the database in one transaction which was solve with https://github.com/itchysats/itchysats/pull/2671

Same behavior again. Note, the taker (12D3KooWRG3cBytxhAiHBZYeXCb8nDRWLLfDdy9Yn31MDr9WVdeR) is on version 0.7.0

So, we are seeing Cannot auto-rollover CFD without a DLC  again?
If we see this in the logs that is indeed worrying, did we touch that code recently?

Are you saying that you had an instance where you had seen Cannot auto-rollover CFD without a DLC in the logs again?

Unfortunately I can't because it's only on the taker side and we never got a rollover request on the maker side.

I'm closing this and will re-open a new one because it might not be related.


Fix/web platform auth

Support for WebApps is added via cross-origin requests.
Included CORS related documentation.

@tarek-berkane-dzexpert Could you please review it? I have tested it, and it works. I tried to keep it simple and reuse existing codes.

I need time to test it and make sure it works well and support both Android/Web, For now don't forget to change package version  in both pubspec.yaml and README.md and add version change to CHANGELOG.md. another thing @lem8r  is the only one who can migrate your PR.

At first glance it looks good to me. I will test it as well.
Thank you @adar2378

Hi @tarek-berkane-dzexpert
I’ve pushed some changes to the CHANGELOG, README, and pubspec. If you notice any small issues, it would be great if you could add the missing pieces directly to avoid back-and-forth.
I also highly recommend trying out melos. Even though you’re not using a monorepo, melos can still be quite helpful for generating changelogs and publishing packages efficiently.
Let me know if you have any questions.

Hi @adar2378
I tested your PR locally, and it works well on my computer. Thanks also for the suggestion (melos) I'll definitely take a look at it.

@tarek-berkane-dzexpert Any update on the possibility of merging it?

Hi @adar2378 , I hope you're doing well.
As mentioned earlier, I don't have access to this repository. The only person who can approve or merge the PR is @lem8r . Once he's finished reviewing it, we'll be updated.

Ah, okay. Thanks for the reply, @tarek-berkane-dzexpert  I am eagerly waiting for @lem8r 's review.

When will version 0.6.0 be released with the following changes?

Add isWebPlatform flag to OdooClient constructor
Implement web-specific login and logout methods
Modify RPC call to handle web platform differently
Update authentication process for web platform
Improve session management and error handling

@lem8r Any update on this?


Docker image - part 2

@andypetrella This PR changes the os to debian:jessie and uses --no-install-recommends. These 2 changes bring docker image size down to 1.005GB. It is over 300MB less than before the previous PR (originally the size was ~1.35GB).
The mesos version change should not affect dcos operability because the major mesos version stays the same but I had no chance to test. No need to rush this, it would be great to test beforehand.

LGTM
DCOS is running 0.25.0, but this can be parametrized too at some point,there is already this property mesos.version. It's available in the BuildInfo too... let's see later


Feature/preprocessing for embedding component

textblocks are now pre-processed before being embedded.
No code duplication between embedding and segmentation

This PR is again ready for review. Please have a look !

I ran into an issue with the new build context, if mongodb data exists in the root directory. Including
data
in the .dockerignore file resolves this. I added this change to the branch.
Rest looks good to me and works!
Maybe a few more comments in the code of the "benchmark"-stuff would help :)

@linusmichel :
Thanks for the Review,
I added some comments and a readme in the benchmark (as part of https://github.com/ls1intum/Athene/pull/24)


Fix for #458 - Allow unicode in SQS messages

The fix is in core/responses.py, which may impact non-sqs calls as well. If you would rather, I can isolate it to sqs. If you are OK with leaving it there, I wonder if there are places that could benefit from tests that would include unicode or other non-ascii content in responses. I would be happy to add those, if needed.

Thanks!
One small question, but will be happy to merge after.

Looks like Travis isn't happy

Coverage decreased (-2.1%) to 92.324% when pulling 3503c98755e4c992862aa6cf5557ec24cacc7157 on carldunham:issue/458/sqs-send-message-non-ascii into ea319698aab8c8e1c6f55d4e115808c725bac268 on spulec:master.

I Pulled these changes in with https://github.com/spulec/moto/commit/a0a205328d44f6f423fe8f4f25be6b2e0af8b7b1
Thanks!


Adds actionObjectProductCommentAddAfter action hook

Questions
Answers

Description?
This action hook is necessary for this feature: https://github.com/PrestaShop/ps_facetedsearch/pull/569. In PostComment front controller the PostComment entity is being used instead of ObjectModel, so we do not get addAfter event.

Type?
new feature

BC breaks?
no

Deprecations?
no

Fixed ticket?
n/a, developer feature

How to test?
after adding a comment from front office hook "actionObjectProductCommentAddAfter" should be executed

Hey @samberrry
Thanks! Sorry for the late reply. Let's move this topic of Faceted search improvements forward :)
I've added a minor suggestion to be more explicit with the argument.
Also, could you please create a simple feature request with the link to your two PRs and a description so we can have it validated by the QA?

Hey @kpodemski,
I'm seeing your great contributions. Thank you everybody ;)
Yes, let's move it.
And, where should I create the feature request? on the ps_facetedsearch repo?

@kpodemski @samberrry I see one problematic thing here guys.
This hook normally sends the ObjectModel instance as a parameter (Hook::exec('actionObject' . $this->getFullyQualifiedName() . 'AddAfter', array('object' => $this));), but here we send an array (obviously, because it's not using ObjectModel). Wouldn't it create some confusion?

@Hlavtox, you're absolutely right, I guess it'll be enough o pass $productComment


A bug with hls

Describe the bug
Use aerial's on_attach with hls(haskell-language-server) causes nvim to freeze and consumes huge memory, as can be seen in this reddit post and this issue in nvim-lspconfig.
I cannot find any solution to this until I disabled hls's on_attach config:
-- in a file
-- defaults.on_attach
local function lsp_highlight_document(client)
  if client.resolved_capabilities.document_highlight then
    vim.api.nvim_create_augroup('lsp_document_highlight', {})
    vim.api.nvim_create_autocmd('CursorHold', {
      group = 'lsp_document_highlight',
      pattern = '<buffer>',
      callback = vim.lsp.buf.document_highlight,
    })
    vim.api.nvim_create_autocmd('CursorMoved', {
      group = 'lsp_document_highlight',
      pattern = '<buffer>',
      callback = vim.lsp.buf.clear_references,
    })
  end
end

function M.on_attach(client, bufnr)
  require('aerial').on_attach(client, bufnr)
  lsp_highlight_document(client)
end

-- in another file
-- after commented the line the bug disappeared
local nlsp = require('lspconfig')
nlsp.hls.setup({
  --on_attach = defaults.on_attach,
  capabilities = defaults.capabilities,
  settings = {
    haskell = {
      formattingProvider = 'fourmolu',
    },
  },
})

System information

OS: macOS arm64
Neovim version: 0.7.0 stable
AerialInfo: (since the editor freezes no output)
Aerial config:

require('aerial').setup({
  backends = { 'lsp', 'treesitter', 'markdown' },
  close_behavior = 'auto',
  highlight_on_hover = true,
  highlight_on_jump = 300,
  max_width = { 40, 0.2 },
  manage_folds = true,
  min_width = 20,
  show_guides = true,
  filter_kind = false,
  guides = {
    mid_item = '├─',
    last_item = '╰─',
    nested_top = '│ ',
    whitespace = '  ',
  },
})

To Reproduce
Steps to reproduce the behavior:

setup hls with aerial's on_attach
cabal init in a new empty folder or stack new <anyname>
open a *.hs file in the above project

If possible, provide a minimal file that will trigger the issue:
the aerial setup above and with a config of hls
require('lspconfig').hls.setup({on_attach = <aerial_on_attach>, capabilities = ...})

Screenshots
As mentioned in the description links
Additional context
Or maybe it's a bug with hls?
But in hls's doc it says [textDocument/documentSymbol] is supported

Addition text
single non-project *.hs file seems to work fine

There's two bugs here.

hls responds to documentSymbol with this:

{ {
    children = { {
        kind = 12,
        name = "main",
        range = {
          end = {
            character = 33,
            line = 3
          },
          start = {
            character = 0,
            line = 3
          }
        },
        selectionRange = {
          end = {
            character = 33,
            line = 3
          },
          start = {
            character = 0,
            line = 3
          }
        }
      } },
    kind = 1,
    name = "Main",
    range = {
      end = {
        character = 0,
        line =<PHONE_NUMBER>
      },
      start = {
        character = 0,
        line = 0
      }
    },
    selectionRange = {
      end = {
        character = 11,
        line = 0
      },
      start = {
        character = 7,
        line = 0
      }
    }
  } }

The bad line is line =<PHONE_NUMBER>, which seems incorrect given that the file is 4 lines long.

Aerial shouldn't spin forever if it gets bad data.

I've pushed up a fix that should handle the bad data we're getting from hls. I'll file an issue on their repo about the bad symbol range and hopefully that'll get fixed at some point.

Thanks for taking time digging into it and the fix! That makes me realize where the problem lies.


Add WithPolarWarping

Codecov Report

Merging #489 into master will decrease coverage by 0.27%.
The diff coverage is 95.91%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   96.29%   96.01%   -0.27%
==========================================
  Files          35       35
  Lines       11955    12287     +332
==========================================
+ Hits        11511    11797     +286
- Misses        444      490      +46


Feat promise

return a Promise from:

loadFont even when font is loaded
preloadFonts
metadata

NodeJS

fonts

Already return a promise:

text

the callback is optional
Also updated the README
This closes: #128

Also, thanks again for putting this together!


add zephyr support in chatbot notebook

Hello, in running the notebook on HuggingFaceH4/zephyr-7b-beta, I noticed that fp16 and int8 convert; however, int4 runs into an nncf error as shown attached- claiming that the conversion to int4 cannot happen due to lack of support on bf16.I have been running these tests on SPR HBM Max 9480 if that helps! Are there additional setup steps I should be taking or is the int4 quantization not possible on this machine? Thanks for your help!

I was able to run on my 10th Gen Core Windows laptop with 32GB of RAM and generate int4 compressed IR, then run on CPU. Trying iGPU next.

Hello, in running the notebook on HuggingFaceH4/zephyr-7b-beta, I noticed that fp16 and int8 convert; however, int4 runs into an nncf error as shown attached- claiming that the conversion to int4 cannot happen due to lack of support on bf16.I have been running these tests on SPR HBM Max 9480 if that helps! Are there additional setup steps I should be taking or is the int4 quantization not possible on this machine? Thanks for your help!

I guess it's SPR specifics where bf16 was enabled in the conversion step. @eaidova , is it possible to avoid it?

@CalebXDonoho  could you please try to replace installation optimum-intel to my branch instead of provided in notebook ()?
%pip install git+https://github.com/eaidova/optimum-intel.git@ea/fp32_dtype
if it helps, then I'll submit fix to optimum-intel

I have seen (early and exotic variants of with early BSP, BIOS) SPR CPUs "not supporting BF16"; lscpu hasn't revealed the corresponding instruction sets...

@CalebXDonoho could you please try to execute following code in your env and share with me results:
import torch
print(torch.get_default_dtype())

Looks like on your system the defult dtype set to torch.bfloat16 that lead to converting model with preserving this dtype

hello @eaidova . This is what I see when attempting the steps discussed prior on my SPR HBM upon reinstall optimum-intel using the steps provided. This should also show the default dtype I am using. Let me know if I need to do further tests


Add back the Flux REPL to the influx CLI

Previously, we had a flux REPL in the CLI.
It was removed due to various concerns.
The following concerns we believe we can fix:

The flux version in the CLI was out of date: https://github.com/influxdata/influxdb/issues/18676
Startup time for the CLI was long and impacting other CLI commands negatively (hopefully this can be mitigated by not starting the flux engine unless we actually want the REPL).
filter commands were broken for some use cases: https://github.com/influxdata/influxdb/issues/15974 ,
https://github.com/influxdata/influxdb/issues/18210

This concern is more difficult:

multi-line execution didn't really work well (it should work like executing steps of a script, but e.g. if you import and then run a command in separate REPL executions it didn't work): https://github.com/influxdata/influxdb/issues/19014

This issue is for the MVP of authoring flux queries on the command line with good code completion.
Open question: How do we handle multiline queries?
>  import "prometheus"
> query1 = prometheus.scrape()
  |> filter(...)
  |> yield()
> query2 = query1 |> last()

Should the import affect query1? Should we keep the results of query1 in memory in order to run query2?
Proposed answer (needs input from flux team!)
For the MVP, don't handle multi-line. Leave https://github.com/influxdata/influxdb/issues/19014 as an open issue for now (unless the flux team is willing to take this on) and focus on providing a way to author flux queries on the command line ergonomically (no awful shell quoting around flux quotes, nice completions potentially via an LSP).

Potentially give a warning that this is under construction for users that were hoping for something more REPL-like.
Potentially support imports as a special case

Prior art:
https://github.com/influxdata/flux/tree/master/cmd/flux

@nathanielc would like your team's input on this

@rockstar Do you have any specific thoughts?
My general plan (although its not well thought out yet) is to do a complete rewrite of the REPL as its exists in the Flux repo today. I want to address some of the above points you mention as well as rethink what a REPL means for Flux. REPLs provide an iterative experience in working with code. What does that development iteration look like for Flux? That is the core of the multiline issue above.
Perhaps we should find a time to meet and sketch out an MVP of REPL from the ground up?

See also https://github.com/influxdata/influx-cli/issues/329 - if we rule this issue out of the next release, we should at least tidy up the CLI to say something like "flux repl under construction" and push people toward authoring flux queries in the UI or with VSCode (with docs links) instead of giving no help.

Does the CLI currently allow for a query to be executed without the REPL? To me the REPL is an experience above and beyond running a simple query. I don't think we need to push users to the UI or VSCode to run queries. Running influx query .... repeatedly from their shell is the MVP REPL we can offer now.

I suspect we lose on time-to-awesome here - code completion (which used to work in the influx CLI, before we ripped out the repl) would help a lot getting the first data back from flux.
Having to get all of something like:
influx query 'from(bucket: "mybucket") |> range(start: -10m) |> filter(fn: (r) => r._measurement == "cpu")

leaves a lot more places to fail for a first time user than something like:
select * from cpu

(I include the range in flux but not InfluxQL because flux errors without it).

And maybe we just need better exploratory functions - it would be cool if I could write (and tutorials suggested):
influx query `head("bucket")`

that gave some useful window on my data.

But overall I think people are just going to have a way better time if their first experience with flux is in the UI that can build their first query for them.


Force happens-before with match result and rating

Race condition, begone

the answer is always some builtin you've never heard of til you need it and google


NuGet.Server - Cache package metadata to disk

See https://github.com/NuGet/NuGetGallery/issues/2843

Keep those squirrels coming :)
/cc @xavierdecoster @joyhui

:shipit:

@yishaigalatzer Good to merge? (and if so, can this be released as a prerelease package to NuGet.org and blog about it?)

YES! I'm excited about this

As a prerelease first or a stable? (I'd say prerelease?)

pre-release


Mozilla Firefox 57 (Quantum) lost saved settings

Hi Daniel Schmitz,
I've installed icinga-multi-status at Mozilla Firefox 57 (Quantum), do my settings inside the Add-ons tab and save the settings.
After closing and starting Mozilla Firefox 57 (Quantum) again, all the settings of my Icinga instance will be lost and NO instance was set.
Please can you confirm that, or maybe I did something wrong on Mozilla Firefox 57 (Quantum) settings? So please can you help?
Thank you in advance.
Klaus.

Hello,
I tested this with Firefox 57 and it works fine for me and keeps all settings during restarts, so I'm unable to reconstruct your mentioned issue - also the first and only report about this. Maybe you run in private mode or have other addons blocking something? Can you try on a blank, new instance of Firefox?
Thanks for the report though.

Hello,
I've tried it on Windows 10 with Firefox 57 and on Linux (CentOS) with Firefox 57 - on both installations - same result. After restart, the Instance settings are gone. On both test, I'm NOT using the private mode.
The only thing is, I changed the settings at (German) "Datenschutz & Sicherheit" to delete all data, when Firefox are closed. But that's not supposed to be the problem?
Maybe you can change here some settings too and try it again at your installation?
Thank you, for your time!
Klaus.

Same on OSX. If you delete the history on exit and select cookies, website settings or offline website data, then the settings are gone at startup.
These settings work for me:

Hi Tobias,
thank you for analyzing the problem. BUT the settings are NOT reasonable, because clearing the data while closing Firefox are important AND even worse are, that I have to accept cookies till they expire - thats NOT acceptable, because if the cookie expire on 31.12.9999 you will tracked from the website/owner of the cookie till the end of days.
So, thank you for your work to find out, under what circumstances the settings are gone - good work!
Klaus.

Hi Daniel Schmitz,
meanwhile I'm not the only one with some Firefox setting that will delete the instance configuration from Firefox for the icinga-multi-status.
Can you tell me, what's the status of the project are, to solve the issue?
Thank you
Klaus.

I'm aware of this and know what is causing this (window.localStorage -> browser storage API).
Unfortunately this will require quite some re-factoring on the internal settings handling and this will take some time. Time I currently don't have on my hands to put into open-source projects.
Feel free to rewrite this on your own and hand in a PR and support this project if you'd like.
Otherwise, I hope I'll be able to squeeze some time in this year to implement this.

Hi Daniel Schmitz,
thank you for your answer, I'm not familiar with that kind of programming, so I will, or have to wait, till you will find time for that issue.
But thank you in advance!
Klaus.

Hi Daniel Schmitz,
what about the status of rebuilding part of the code, to solve the problem?
Thank you, in advance!
Klaus.

@tgerling, many thanks your patch works like a charm.
I have testet and build my own xpi and all settings keeps stored after firefox is closed.

Thanks to the patch provided by @tgerling I was able to release a new version. I updated jQuery and Bootstrap along the way, so it also looks a little more modern. I consider this issue resolved now, sorry it took so long :-)


Support for reorder list items

I'm submitting a ...  (check one with "x")
[ ] bug report
[ ] feature request
[ x] support request

Is this module supports the reordering of items. For example I have 5 input field and I want to reorder them so is it possible ?

@aitboudad any answer ?

I've done something similar but for repeatable type https://formly-js.github.io/ngx-formly/examples/advanced/repeating-section

is that what you're looking for ?

@aitboudad url that you shared is not getting load. My requirement is in repeatable section I have 5 items. I want to reorder them after inserting data in it. so is this you achieved ?

Thanks @aitboudad  This is exactly what I want

has anyone gotten an example like this to work with cdk Drag & Drop?

@randallmeeker see https://github.com/ngx-formly/ngx-formly/issues/1456#issuecomment-469894882


SignOut Blocked By CORS

Hello,
I am using Microsoft.AspNetCore.Authentication.WsFederation to authenticate to ADFS. The login works perfect, but at the time of logout the call is blocked by CORs. Could you help me?
It is a web application of the ASP.NET CORE 2.1 template with SPA in Angular 7.
The error in the browser is as follows:
Access to XMLHttpRequest at 'https://fstest.itesm.mx/adfs/ls/?wtrealm=https%3A%2F%2Fformalizacionprestamoqa.tec.mx&wa=wsignout1.0' (redirected from 'https://formalizacionprestamoqa.tec.mx/home/signout') from origin 'https://formalizacionprestamoqa.tec.mx' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.
The code I use to logout is as follows:
[HttpPost]
public async Task SignOut()
{
HttpContext.Session.Clear();
await HttpContext.SignOutAsync(WsFederationDefaults.AuthenticationScheme);
await HttpContext.SignOutAsync(CookieAuthenticationDefaults.AuthenticationScheme);
}
If I click on this link shown in the DevTools console: https://fstest.itesm.mx/adfs/ls/?wtrealm=https%3A%2F%2Fformalizacionprestamoqa.tec.mx&wa=wsignout1.0 'me open another tab in the browser where the session is closed. So I see that log out is working, I just don't know how to prevent the call from being blocked by he browser.
Try already adding the ADFS path in the application's CORS configuration, but it doesn't work.
Please help me.

Try already adding the ADFS path in the application's CORS configuration, but it doesn't work.

To be clear. It's ADFS that needs to be configured to accept requests from your app, not the other way around. It sounds like what you did was add the ADFS endpoint to your app's CORS config, which won't actually help here.

We're closing this issue as no response or updates have been provided in a timely manner. If you have more details and are encountering this issue please add a new reply and re-open the issue.


path updated

The update according to the discussion  https://github.com/vlobzakov/docs/blame/master/docs/creating-manifest/basic-configs.md#L20 is on the way


Full porting to astrapy 1.3+

This is a large rewrite of the internals in order to completely migrate to using the recent, idiomatic astrapy.
Motivation

enabling non-Astra Data API (such as HCD. I could run all integration testing on HCD as well)
simplify most of the Data API newer features (such as $vectorize)
use an astrapy API that is extensively documented and actively maintained

Guide to the PR
All the newest astrapy things are now usable (e.g. environments, TokenProvider, EmbeddingHeaderProvider classes and so on).
Along the way, several improvements came along:

deprecating (but still 100% working) passing "clients" to the constructors. Preferred: secret/strings in init methods
issuing warning if "legacy" parameters are used (as part of the full alignment to the modern astrapy). But without  breaking changes. Everything is 100% compatible with previous usage patterns
reorganization/modernization of the whole test suite (fixture re-use, uniform test function scheme, etc)
more testing added, esp. thoroughly probing the (totally rewritten) insert-very-many-with-possible-overwrite flows (sync/async)

Notes

The internals have changed a lot. Hence, code that directly uses the internals of these classes (e.g. using vector_store.collection) would stop working. Such usage, anyway, is brittle in the first place and should not be encouraged.
The document loader maintains the same signature, including its nb_prefetched parameter, which however is ignored - actually a warning is emitted if a prefetch is requested. This reflects the fact that prefetched finds have been found to be problematic in some corner cases on AstraPy and are at the moment disabled. Functionally, this has no effect on the document loader class.

LGTM, great work !
A few nits.


Increase JaCoCo code coverage version

Increase of library version required to get new feature of scala method automated filtration.
This feature provide more exact/real in JaCoCo reports.

Release notes proposal:
#8 - Increase JaCoCo code coverage version

Increased version JaCoCo library to get new feature of scala method automated filtration.


[TASK] backport base image updates to v1.1.3 images

What's the task? Please describe.
we need to backport base image and dependencies updates to v1.1.3 images
Describe the items of the task (DoD, definition of done) you'd like.

[ ] longhorn-manager
[ ] longhorn-engine
[ ] longhorn-intance-manager
[ ] longhorn-share-manager
[ ] backing-image-manager

Additional context
Add any other context or screenshots about the task request here.

@meldafrawi is this still valid? If yes, please update the ticket description to describe what the source of PRs needs to backport?


Update German Translation

Resolved / Related Issues
none
Details of Changes
I reviewed the German translation file (Files/MultilingualResources/Files.de-DE.xlf).

looked for all occurences of state="needs-review-translation" in the file  and reviewed them, editing if necessary
deleted all <note> entries, when no longer relevant
Added translations to all occurences of state="new"

Validation
How did you test these changes?

~Built and ran the app~
~Tested the changes for accessibility~

@R3voA3 fyi


fix: policies.yml parsing

Description
Due to the recent addition of policy groups, the parsing of policies.yml was broken.
This happened because of a pretty confusing serde behavior, as an attribute on an enum is renaming all the variants of the enum, not all the fields of those variants.
TODO:

[ ] update tests

I think this PR fixes the v1.15.0-rc1 issue we are discussing in other channels. I was testing the bug and when I applied the same change, the problem goes away. Serde was ignoring the policy mode field due the funky behavior that you linked here. To double check that, I've renamed the field to "policy_mode" in my testing policies.yml and that works as well. :slightly_smiling_face:


Copy LDAS.rc file into rc_out/year/month/ dir (post-processing)

To better capture the settings of all resource parameters, GEOSldas should automatically make a time-stamped copy of the LDAS.rc file into the rc_out/year/month output directory.
This should be done in lenkf.j.template, not ldas_setup.  Users do not usually run "ldas_setup" again  if they simply extend an existing experiment.

The resulting files should look something like
rc_out/Yyyyy/Mmm/[EXPID].ldas_LDASrc.YYYYMMDD_HHMM.txt

quote "rc_out/Yyyyy/Mmm/[EXPID].ldas_LDASrc.YYYYMMDD_HHMM.txt"  this file has always been there in GEOSldas simulation

Yes, indeed it's there.  I had been looking at SMAP ops output and found no trace of this file.  I suspect it gets lost in the L4 ops system.  No further action needed for GEOSldas.  Sorry for the false alarm.


When using github token a username is still required when running GitReleaseManager

When trying to run GitReleaseManager through Cake.Recipe using PAT, Cake.Recipe expects a username also to be available.
This is never used when using a PAT, but only when specifying a GitHub password, so this requirement should not be needed.
I could not find any instances in Cake.Recipe that uses the GitHub username when a token is specified. As such, I would recommend removing this requirement in these cases.
/cc @gep13

Looking at the code, I don't see why a Username would be requried:
https://github.com/cake-contrib/Cake.Recipe/blob/develop/Cake.Recipe/Content/gitreleasemanager.cake#L19
But I must be missing something.
Will check in more detail later.

It isn't required (afaik) anywhere except in the check here: https://github.com/cake-contrib/Cake.Recipe/blob/develop/Cake.Recipe/Content/parameters.cake#L172-L173 which requires the username or it won't run GRM no matter if a password or a token is being used.

Doh! That check is wrong. We can fix that up.

Seems to have been an oversight in the PR: https://github.com/cake-contrib/Cake.Recipe/pull/453
As that was merged in for 2.0.0, I am not sure if we need to have this on the 2.0.0 milestone?


Run prune code even when no folders change

Resolves #1534

Thinking about this and I don't think we want this fix because the fix for --set to keep the directories matching what the sparse cone will be should fix running prune.
The issue before that fix was that --set would not have any items in directories and prune would not run.  Now there will always be items in directories because --set adds them back it.  I'm going to update this to only have the test

azp /run GitHub VFSForGit Mac Functional Tests

/azp run GitHub VFSForGit Mac Functional Tests


Applies to TFS 2018?

I'm trying to verify whether multiple jobs running in parallel is supported in TFS 2018.3?  The dependencies option is not available and when I setup a basic multi-phase build, the phases are executing sequentially instead of in parallel.  Is the parallel options mentioned here really available in TFS 2018?  Or it not really available until 2019.RC1 or later?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a14fc554-e74e-2c76-34d1-37a2e0dd7b2f
Version Independent ID: e95259f4-61ef-5e99-a492-eb77d7d1e657
Content: Workflow using multiple jobs in Azure Pipelines Build and Release - Azure Pipelines & TFS
Content Source: docs/pipelines/process/multiple-phases.md
Product: devops
GitHub Login: @alexhomer1
Microsoft Alias: ahomer

Thank you for your feedback. I have passed this on to the product team for advice.


Dynamic dates and logos

To avoid manual labor every year we can consider extending the API a bit.
Changes required each year are:

Updating API URL to only fetch events after a set date
A potential fix for this is to only consider events for the current year instead.
Fadderuke start date
Can be added to API and set by velkom.
Committee application deadline
Can be added to API and set by velkom.
Theme logo
Can be added to API and set by velkom. If the logo has not been set a generic one is used instead.
Partner logos
Can be added to API and set by velkom. However, this can be a bit more tricky as manual adjustments are sometimes needed.

Hi, @duvholt I am a graphics designer and open source enthusiast, I was lloking to your project and I have noticed it doesn't have one yet, right? If you want I can contribute to your good project by proposing a logo design for the project.
Cheers!


making tesla coils and radiation collectors craftable

About the PR
This PR makes tesla coils and radiation collectors craftable and researchable.
Why / Balance
Solves #308
This should be added because it will help engineering generate the power needed for bitcoin miners (#286) as well as provide more power to the station at a balanced cost.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

tweak: tesla coils and radiation collectors are craftable and researchable

dont merge this PR yet, it doesnt work properly.

completing the craft of a tesla coil causes the server to crash and i dont know why, can anyone help me with that?

completing the craft of a tesla coil/rad collector causes the server to crash and i dont know why, can anyone help me with that?

check the yaml linter.

The machine board prototypes and lathe recipes should be in the goobstation folder.

still not working, im gonna work on other things and come back to this later.


Feature: Add {uploaded_id} macro

Right now, the {uploaded} macro inserts l_{uploaded_id}, but it would be good (especially for outgoing transformations, or transformations that do not use overlays) to grab the uploaded ID.
Optional would be to change the existing default for {uploaded}, and make it be the ID, whereas something like {uploaded_overlay} gets the old behavior.

Closed by PR #6


fix clippy ci check and fix clippy warning from main

 fix clippy ci check and fix clippy warning from main


when logged in as guest

don't allow me to download the data.

It isn't possible to download the data when being a guest. However, the buttons are visible. This has been updated now!


Extract modules

.acts_as_list was too long.

@swanandp, and @fabn, @ledestin has partitioned up the acts_as_list call. It's just a code reorganisation. Do you approve of these changes?

I personally like the idea of splitting the code in multiple files to have smaller pieces of code. The only concern about this is maybe that it contains too much meta programming, but current implementation has the same level of MP and I don't think is easy to avoid that.

@swanandp, your thoughts?
Also @ledestin, what do you think of placing all of the definers in a subdirectory called definers then removing definer from the file name and module name and then calling them say: ActiveRecord::Acts::List::Definers::Callback?

Thanks @fabn, yes, this is just organising the 'crap draw' basically without throwing anything away. I think because of the variable method names it's hard to avoid the class_eval stuff unfortunately. Though, there is possibly a case for using extend for those class methods that aren't variable. I asked Dmitry to look into it but I think he wanted to do this refactor first (is that right Dmitry?).

@brendon hopefully, Definers::Callback should be enough. Should be ok. But I wouldn't do it, unless you really want to have them in a separate directory, as I prefer the way it reads now.

@brendon it'd be hard to see what's changed (diff) after move to another file, so that's why I wanted to do this PR first.
Also, I reconsidered UpdatePositonMethodDefiner and now I think it should be merged into ColumnMethodDefiner, because those methods deal with position.

@ledestin, that's all good. Let's stick with the current arrangement. It's my habit that when there's a group of things, I like to put them in their own place and remove any repetition around their naming if possible. Your way does read cleaner though.
I'd probably use a plural for the class name if we went with that option: Definer::Callbacks. That still reads reasonably well, but then does that make it strange to have them in a directory named definers?
Merge those two classes you mentioned in your last message if you think it proper.

@brendon we probably would have to have Definers:: module to match directory name. Better for consistence and is probably necessary for autoloading to work.
Going to merge.

Thanks @ledestin. Is this ready to merge?

@brendon I've added a small change, I came up with later. Now it's ready.

Thanks @ledestin, I've merged this :)

Great @brendon :)

@ledestin @brendon @fabn This Pr induced a bug
There was an error while trying to load the gem 'acts_as_list'. (Bundler::GemRequireError) Gem Load Error is: uninitialized constant ActiveRecord::Acts
In the stack Kernel.require loads /lib/acts_as_list.rb, which in turn loads lib/acts_as_list/active_record/acts/column_method_definer.rb. First line of column_method_definer.rb  is module ActiveRecord::Acts::List::ColumnMethodDefiner but at that point ruby knows nothing about ActiveRecord::Acts
A fix would be to split the module definition in the following pattern:
module ActiveRecord
  module Acts
    module List
      module ColumnMethodDefiner
        ...
      end
    end
  end
end

The same should be done for all the definers created in this PR
acts_as_list/active_record/acts/column_method_definer
acts_as_list/active_record/acts/scope_method_definer
acts_as_list/active_record/acts/top_of_list_method_definer
acts_as_list/active_record/acts/add_new_at_method_definer
acts_as_list/active_record/acts/aux_method_definer
acts_as_list/active_record/acts/callback_definer

Hi @randoum, just checking you're getting this on master? I changed how acts_as_list loads itself here: https://github.com/swanandp/acts_as_list/pull/240
I remember getting a similar error due to the relative class references ColumnMethodDefiner etc... That's why they're absolute in the patch.
Can you provide an environment that triggers your bug as I haven't seen it and the suite runs green. Is it a bit random?

Yes on master. Does not show in the tests. You should reproduce in any projects if I you to your Gemfile
gem 'acts_as_list', git: 'https://github.com/swanandp/acts_as_list.git'

Then try:
$ rails c
/opt/rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.13.7/lib/bundler/runtime.rb:94:in `rescue in block (2 levels) in require': There was an error while trying to load the gem 'acts_as_list'. (Bundler::GemRequireError)
Gem Load Error is: uninitialized constant ActiveRecord::Acts
Backtrace for gem load error is:
/opt/rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bundler/gems/acts_as_list-83abef9f25ed/lib/acts_as_list/active_record/acts/column_method_definer.rb:1:in `<top (required)>'
/opt/rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/bundler/gems/acts_as_list-83abef9f25ed/lib/acts_as_list.rb:1:in `<top (required)>'
/opt/rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/bundler-1.13.7/lib/bundler/runtime.rb:91:in `require'

Solution is as I previously posted

Note that you may have to load your model class in order to see the error message, so in the console for example:
irb(main):001:0> TodoList

Thanks @randoum, that makes sense. I've tweaked the load order on master. Can you give that a go and let me know? It doesn't hurt to do this since there's no code being run anymore in list.rb.

Yep, that fixed it. Cheers

Good to hear :)


'timeout' prop doesn't seem to work

Notification is closed earlier than the time (ms) passed in 'timeout' prop.

https://github.com/mobilusoss/react-web-notification/issues/60#issuecomment-532015131
We can use requireInteraction option.


feat: added a timeout to the login command

Closes #989

@craicoverflow have you had a chance to review the changes?

The build is failing - this needs to be fixed.

@craicoverflow have you had a chance to review the changes?

We have a number of tasks to complete, but don't worry - this is on the backlog.

So first callback requires human interaction (if you need to login). Second callback uses SSO so it is almost instant.
I like global timeout but if we want to go with individual ones it should be 60 for first and 10 seconds for second.

So first callback requires human interaction (if you need to login). Second callback uses SSO so it is almost instant.
I like global timeout but if we want to go with individual ones it should be 60 for first and 10 seconds for second.

Global timeout makes sense then. We should try to avail of the built-in context.WithTimeout for this then.
The context can be passed to login.Execute(ctx) from the login command:
https://github.com/redhat-developer/app-services-cli/blob/b4128d56a571d998634901980f56fb958384c55c/pkg/auth/login/login.go#L41

Needs rebase.

Rebase needed.

@wtrocki , @craicoverflow please see a new PR #1027. This one can be closed as I lost my old local repo.


has anyone found a good way to test projects that depend on this in Travis or Codeship

Neither supports root.  Thanks!

I will close this for now...I figured it out using mocks
I am going to do a short blog post about it and will update the issue with a link, but a proof of concept is below:
https://github.com/hortinstein/testing_mock_event_emitters


Add Maintaining Balance for Open Source Maintainers article

This PR adds a new article written by @abbycabs — curated from notes taken at open source workshops with the maintainer community — with contributions from the following amazing humans: @agnostic-apollo @AndreaGriffiths11 @antfu @anthonyronda @CBID2 @Cli4d @confused-Techie @danielroe @Dexters-Hub @eddiejaoude @Eugeny @ferki @gabek @geromegrignon @hynek @IvanSanchez @karasowles @KoolTheba @ljharb @nightlark @plarson3427 @Pradumnasaraf @RichardLitt @rrousselGit @sansyrox @schlessera @shyim @smashah @ssalbdivad @The-Compiler @thehale @thisisnic @tudoramariei @UlisesGascon @waldyrious + many others!

Also tagging our amazing volunteer writers @thehale, @CBID2, @UlisesGascon, & @atapas for visibility in the process of updating the guides & in case they have any thoughts.

My feedback was shared during the drafting phase. This PR looks great, including the image for the article.
Thanks @abbycabs for the extra visibility.

Hi @leereilly! :) Your PR is off to a great start. I just have something proofreading tips to consider,so check them out in my inline comments. @abbycabs,thank you for tagging me in this PR! :)

Thanks for diving in @CBID2! I should have noted that the text has already gone through copyediting and we're at the final stage before publishing. The google doc was open for multiple weeks for edits (which you generously contributed to! Thank you!). Unfortunately, I don't think we'll be able to make more copy changes at this stage -- but please feel free to bring these suggestions to our next call!

Hi @leereilly! :) Your PR is off to a great start. I just have something proofreading tips to consider,so check them out in my inline comments. @abbycabs,thank you for tagging me in this PR! :)

Thanks for diving in @CBID2! I should have noted that the text has already gone through copyediting and we're at the final stage before publishing. The google doc was open for multiple weeks for edits (which you generously contributed to! Thank you!). Unfortunately, I don't think we'll be able to make more copy changes at this stage -- but please feel free to bring these suggestions to our next call!

Thanks for noting @Abby

Hi @leereilly! :) Your PR is off to a great start. I just have something proofreading tips to consider,so check them out in my inline comments. @abbycabs,thank you for tagging me in this PR! :)

Thanks for diving in @CBID2! I should have noted that the text has already gone through copyediting and we're at the final stage before publishing. The google doc was open for multiple weeks for edits (which you generously contributed to! Thank you!). Unfortunately, I don't think we'll be able to make more copy changes at this stage -- but please feel free to bring these suggestions to our next call!

Thanks for responding @abbycabs! :) I think we can still make those edits. They can just click on the commit suggestions button.

@CBID2 yes, but we'd have to loop in our copy editors again and potentially comms / redo formatting. I would have loved to incorporate this a few weeks ago when we had suggestions open on the google doc!

@CBID2 yes, but we'd have to loop in our copy editors again and potentially comms / redo formatting. I would have loved to incorporate this a few weeks ago when we had suggestions open on the google doc!

Ohh I see. Looking back, I wished I had those ideas back then 🤦🏾♀

I can't setup this project on my pc I don't know what is the issue local host doesn't work

Command doesn't recognize "script"

I'll update the README.md with some installation instructions, @eshal26 👍🏻
I agree it's not easy to build locally - especially if you're new to Ruby / Jekyll / GitHub Page.

Thank you for the comments and commits, everyone <3


Minor: Consolidate UDF tests

Which issue does this PR close?
Rationale for this change
When evaluating coverage of our user defined functions (UDFs) I found that some tests were in sql_integration, and some were in other places.
What changes are included in this PR?
Consolidate them all into the aptly named user_defined_integration so they are easier to find.
Are these changes tested?
all tests

Are there any user-facing changes?

Thanks @yjshen !


Add default values to labPrice

Not having a default unit cause the question.value check to fail even when labPriceMin and labPriceMax were set to permissible values.

Before

After

:+1: