Provide sync-rebuild functionality in a more integrated way

The automatic pkgrel increment of sync-rebuild is very useful but it doesn't intergrate well into the other commands, notably aur sync -c or sync-asroot. It would be nice if this could be restructured to replace the --rebuild arg of aur-sync that's currently undocumented and "not very good".

The pkgrel increment part could be split off to different command, e.g. build--rebuild. Using that in aur-sync might be simpler than an example which has to wrap both aur-sync and aur-repo

This is a start:
diff --git a/examples/sync-rebuild b/examples/sync-rebuild
index 1af00583..fa4d9539 100644
--- a/examples/sync-rebuild
+++ b/examples/sync-rebuild
@@ -111,11 +111,11 @@ def update_pkgrel(buildscript, backup, pkgrel=None, increment=0.1):

 # TODO: use vercmp to ensure rebuilds
 # XXX: perform rebuilds in dependency order, abort reverse depends when depends fails (sync--ninja)
-def rebuild_packages(repo_targets, db_name, fail_fast=False):
+def rebuild_packages(repo_targets, db_name, fail_fast=False, user=None):
     """Rebuild a series of packages in succession
     """
     # TODO: user-specified build arguments (e.g. --chroot)
-    build_cmd = ['aur', 'build', '-srn']
+    build_cmd = ['aur', 'build', '-srn', '--chroot']

     if db_name is not None:
         build_cmd.extend(('--database', db_name))
@@ -158,7 +158,17 @@ def rebuild_packages(repo_targets, db_name, fail_fast=False):

         # Build package with modified pkgrel
         try:
-            subprocess.run(build_cmd, check=True, cwd=src_dir)
+            if user is None:
+                subprocess.run(build_cmd, check=True, cwd=src_dir)
+            else:
+                asroot_env = {
+                    'AUR_ASROOT': 1,
+                    'AUR_MAKEPKG'      : f'runuser -u {user} -- makepkg',
+                    'AUR_GPG'          : f'runuser -u {user} -- gpg',
+                    'AUR_REPO_ADD'     : f'runuser -u {user} -- repo-add',
+                    'AUR_BUILD_PKGLIST': f'runuser -u {user} -- aur build --pkglist'
+                }
+                subprocess.run(build_cmd, check=True, env=dict(os.environ, **asroot_env))

             # Build process completed successfully, remove backup PKGBUILD if it
             # was created above
@@ -194,12 +204,16 @@ def print_cached_packages(pkgnames):
             p2.communicate()

-def main(targets, db_name, fail_fast, run_sync):
+def main(targets, db_name, fail_fast, run_sync, user):
     # Ensure all sources are available. Only packages are cloned that are
     # already available in the local repository.
     sync_cmd = ['aur', 'sync', '--no-build', '--no-ver-argv']
     repo_cmd = ['aur', 'repo', '--jsonl']

+    if user is not None:
+        sync_cmd = ['runuser', '-u', user] + sync_cmd
+        repo_cmd = ['runuser', '-u', user] + repo_cmd
+
     if db_name is not None:
         sync_cmd.extend(('--database', db_name))
         repo_cmd.extend(('--database', db_name))
@@ -241,15 +255,15 @@ def main(targets, db_name, fail_fast, run_sync):
             # Local repository targets not retrieved by `aur-sync` are missing from AUR
             # XXX: append to queue if target directories are available
             not_aur = list(set(repo_targets.keys()) - set(repo_targets_ordered.keys()))
-
+
             # Build in dependency order
-            rebuilds, failed = rebuild_packages(repo_targets_ordered, db_name, fail_fast)
+            rebuilds, failed = rebuild_packages(repo_targets_ordered, db_name, fail_fast, user)
         else:
             not_aur = []

             # Build in sequential (argument) order
             # XXX: support other directories than AURDEST
-            rebuilds, failed = rebuild_packages(repo_targets, db_name, fail_fast)
+            rebuilds, failed = rebuild_packages(repo_targets, db_name, fail_fast, user)

         if len(not_aur) > 0:
             print(f'{ARGV0}: the following targets are not in AUR:', file=sys.stderr)
@@ -280,7 +294,8 @@ if __name__ == '__main__':
     parser.add_argument('-d', '--database')
     parser.add_argument('--fail-fast', action='store_true')
     parser.add_argument('--no-sync', action='store_false')
+    parser.add_argument('--user')
     parser.add_argument('targets', nargs='+')
     args = parser.parse_args()

-    main({i:1 for i in args.targets}, args.database, args.fail_fast, args.no_sync)
+    main({i:1 for i in args.targets}, args.database, args.fail_fast, args.no_sync, args.user)

You'll need to chown the NamedTemporaryFile to the build user (contains the build queue in dependency order) and add ninja support as in sync-asroot, if needed.


Can't install  R bindings

The report shows

Executing: InstallBindings false
Start Time: Mon May 30 21:33:25 2016
Running script InstallBindings...
Saving URL to 'c:\users\admini~1\appdata\local\temp\arc35a2\tmpbed2zc\arcgisbinding_<IP_ADDRESS>.zip'

Traceback (most recent call last):
File "", line 164, in execute
File "I:\r-bridge-install-master\rtools\install_package.py", line 214, in install_package
execute_r('Rcmd', 'INSTALL', package_path)
File "I:\r-bridge-install-master\rtools\bootstrap_r.py", line 30, in execute_r
os.putenv("PATH", ";".join([rcommand_dir, sys_path]))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xcf in position 944: ordinal not in range(128)

Failed to execute (InstallBindings).
Failed at Mon May 30 21:33:28 2016 (Elapsed Time: 2.23 seconds)

@waholulu I believe I've fixed this in the latest release — could you try running the installation again?


Broker status doesn't show missing sink service

Problem
When creating KafkaBroker which has non-existing service set as sink, it is not possible to tell from broker status what the issue is.
Steps to reproduce the issue:

Apply this yaml (dlq-service does not exist): https://knative.dev/docs/eventing/broker/kafka-broker/#create-a-kafka-broker
Check the broker status via kn broker list
Check oc get events

$ oc apply -f broker_dlq.yaml
broker.eventing.knative.dev/default created
$ kn broker list
NAME      URL   AGE   CONDITIONS   READY     REASON
default         6s    3 OK / 6     Unknown
$ oc get events
LAST SEEN   TYPE      REASON            OBJECT           MESSAGE
11s         Normal    FinalizerUpdate   broker/default   Updated "default" finalizers
5s          Warning   InternalError     broker/default   failed to get contract configuration: failed to resolve Spec.Delivery.DeadLetterSink: services.serving.knative.dev "dlq-service" not found

Exit Criteria
Info about missing sink service is propagated into broker status.
Also, it would be good to have Events tab on the UI page with Broker (same as for Pod for example).

Thanks for reporting!
/triage accepted
/area broker
/area channel

/assign


Are the default weights etc necessary for simple lossless decoding?

I am researching a bit how to get JPEGXL decode of losless JXL images in my Android app. I am wondering about the size of the JAR file of this library. Are these weight files required for this functionality? They seem to take up a lot of space, undoing my gains with conversion of PNG to JPEGXL lossless.

They are necessary for VarDCT, but not for lossless images. They're in a file to avoid needing to compute them on the fly, which is a temporary measure before I optimize computing them.

I will say I hadn't considered the file size issue, so I will look into this.
Do note that I still have many optimizations to do, particularly in the lossless area.

Yeah, no worries. I am developing for Android, and have some visual assets in PNG. I saw I could save around 1MB of storage, with converted to jxl lossless. But if the code to decode them, is larger then that, it has not much use ofcourse. But I'll experiment a bit with this library and see what I can drop/cherrypick.

Fixed with recent commits.


[3777] DateTime.AddDays() results are not comparable with DateTime in…

Fixes #3777

I have a different fix for this issue and the fix will be included in a larger batch of DateTime revisions.

We'll copy over test N3777.cs into a new PR. Closing this PR.
https://github.com/bridgedotnet/Bridge/blob/a7ef6351d46a90fcb49f1cf8f41292546d210a96/Tests/Batch3/BridgeIssues/3700/N3777.cs
using Bridge.Test.NUnit;
using System;
using System.Collections.Generic;
using System.Linq;

namespace Bridge.ClientTest.Batch3.BridgeIssues
{
    [TestFixture(TestNameFormat = "#3777 - {0}")]
    public class Bridge3777
    {
        [Test]
        public static void TestAddDays()
        {
            DateTime d = DateTime.Now;
            DateTime d2 = d.AddDays(3);

            Assert.AreEqual(-1, DateTime.Compare(d, d2));
        }
    }
}


Nick: Watch Bereket[\W_]*+Nakliyat(?!.com(?<=bereketnakliyat.com))

Nick requests the watch of the watch_keyword Bereket[\W_]*+Nakliyat(?!\.com(?<=bereketnakliyat\.com)). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Bereket[\W_]*+Nakliyat(?!\.com(?<=bereketnakliyat\.com)) has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Reload dev server when adding assets

Right now new assets in app/assets does not cause the dev server to reload so you must reload manually.
Add more file types to nodemon? Or include nodemon config and better package.json scripts?

Fixed by using nodemon -e '*' in package.json dev script.


add nsg_group_id parameter to ip_configurations

We should have the possibility to assign a Network Security Group to network interfaces.
Purposed Changes
Variables
variable "network_interfaces" {
...
    nsg_id = optional(string)
...
}

Main
resource "azurerm_network_interface_security_group_association" "this" {
  for_each = {
    for k, v in var.network_interfaces : k => v if v.nsg_id != null
  }
  network_interface_id      = azurerm_network_interface.this[each.key]
  network_security_group_id = each.value.nsg_id
}

We shouldn't create conditionals on values that sometimes are unknown until the apply step.
Should wrap the NSG ID in an object, similar to how we do with subnets in the network module: https://github.com/equinor/terraform-azurerm-network/blob/2a45cc3eb667418ed7a98e1290dd9bd6c242756b/variables.tf#L34-L36

@hknutsen Do you think we should define the NSG association outside of the VM module ?


Correct grammar as per Issue #1524

Hello!
This PR is to address the issue I raised in Issue #1524 .
As per June's advice, I changed "old" to "mature" so as to be friendly to non-native speakers of English.
Cheers!

Thanks @junedev! I just familiarized myself with the test tool and have corrected the error I left in the exemplar solution. Instructions.md has also been updated.


BLDK-820: Compliance Issues in firebolt Repository

Pushed new changes to repo. Please verify, Changed folder name to special-images ,recreated soft-link and added NPM credit in NOTICE.


installing stop in error

when install sublimetext-markdown-preview console show the following message:
Package Control: No updated packages
ignored packages updated to: ["Markdown Preview"]
reloading settings Packages/User/Package Control.sublime-settings
reloading settings Packages/User/Preferences.sublime-settings
Package Control: The dependency 'pygments' is not currently installed; installing...
stop in installing, so I can not install in package control. Then I tried to install manually but it can not display correctly in browser.

So it never installs the pygments package?

I have installed markdown preview before, so there have been a pygments package. It can be installed now after I reboot my computer. thx !

I'm glad you got it to install.  I will go ahead and close this issue then.


Modify the readme File for this repo

can you please assign this to me !

Create a table with the project name with clickable link and modify the readme file to look more attractive


Please create a CMakeLists.txt, define a interface target, and export/install the target

Reasons:
a) clean integration into cmake projects. Use find_package(CTRE) to find the target
b) include it into another target with target_link_libraries(mytarget PRIVATE CTRE::CTRE) (whereever CTRE is located)
c) benefit from cmakes automatic compiler flags propagation e.g. mytarget would use c++17 because CTRE needs c++17

I'm not experienced with CMake enough. Can you send pull request with it?

Example for single header library: https://github.com/effolkronium/random/blob/master/CMakeLists.txt
;)


fix(react-tinacms-github): added action.name as key prop in actions.m…

added action.name as key prop in actions.map method
fix https://github.com/tinacms/tinacms/issues/1557

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Dan Gayle seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 I will fix.
On Tue, Oct 20, 2020 at 6:57 AM DJ<EMAIL_ADDRESS>wrote:

@dwalkr requested changes on this pull request.
In packages/react-tinacms-github/src/components/ActionableModal.tsx
https://github.com/tinacms/tinacms/pull/1559#discussion_r508528249:

@@ -50,8 +50,12 @@ export const ActionableModal = ({
{message}

       {actions.map(action => (

         <TinaButton primary={action.primary} onClick={action.action}>

       {actions.map((action) => (

         <TinaButton

           key="name"

key should not be a constant
https://reactjs.org/docs/lists-and-keys.html#keys
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tinacms/tinacms/pull/1559#pullrequestreview-512745600,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA7US5OOKV4AO5LMLV32XLSLWJM5ANCNFSM4SVLQIKQ
.

@dangayle FYI we also need contributors to this project to sign the Contributor License Agreement. It looks the commits in this PR aren't tied to your GitHub user. In order for CLAassistant to approve this, all committers need to be tied to GitHub.
You can fix this by setting a user email for git that matches an email associated with your GitHub account: https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address#setting-your-commit-email-address-in-git
You will then need to amend + force push your current commit to replace the author.
Sorry for making this so complicated, but once you set this up it shouldn't be an issue in the future!

Yeah, I did the CLA, but didn’t know I needed to amend the push. I’ll do
that. Thank you for your patience.
On Wed, Oct 21, 2020 at 7:03 AM DJ<EMAIL_ADDRESS>wrote:

@dangayle https://github.com/dangayle FYI we also need contributors to
this project to sign the Contributor License Agreement. It looks the
commits in this PR aren't tied to your GitHub user. In order for
CLAassistant to approve this, all committers need to be tied to GitHub.
You can fix this by setting a user email for git that matches an email
associated with your GitHub account:
https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address#setting-your-commit-email-address-in-git
You will then need to amend + force push your current commit to replace
the author.
Sorry for making this so complicated, but once you set this up it
shouldn't be an issue in the future!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tinacms/tinacms/pull/1559#issuecomment-713601264, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA7USYKE3XHHUZ44FHYEGTSL3S4BANCNFSM4SVLQIKQ
.

@dangayle I'm gonna close this PR as it's been open with no activity for a little while. You're welcome to reopen it if/when you're ready to come back to it!


eurobarometer - split up files, comment, visualize

Great visualization! Probably one suggestion:

[ ] create data (and also visualization) from the aggregated L1 data (with and without the majority language), so that we can see a general trend


Mutators returning arrays result in 'Undefined index: @type' error

Sorry to give you another bug. Assuming the model:
class PageGroup extends Model
{

    protected $appends = ['layout_settings'];

    public function getLayoutSettingsAttribute(){
        return ['test'=>'My Test Array'];
    }

}

I'm getting an Undefined index: @type error when trying to use the api. If I change getLayoutSettingsAttribute() to:
public function getLayoutSettingsAttribute(){
    return 'My Test String';
}

Everything works fine.

@jeremymlane mind checking the version used for nilportugues/json-api and nilportugues/laravel5-json-api?  Also, mind sharing the line throwing that error?
I'm sure it can be fixed quite easily.

Does https://github.com/nilportugues/laravel5-jsonapi/releases/tag/2.3.0 fix this? I believe it should.

@nilportugues That did it. Seems to be working now. I had<EMAIL_ADDRESS>and dev-master of laravel-json-api before I updated, but can't recall the line number.

@jeremymlane thanks for the feedback :+1:


Add travis config

I managed to add the right config to run on travisci, after that I'm going to fix the test suite and config the right dependencies.
For now, I added to run against ruby 1.9.3 (since it's a version specified on gemspec) and against ruby 2.3.0, since it's one of more recent versions of ruby.

Hey @brunoarueira, thank you very much. I'll take a look later today and will get back to you.


Install apex in CI build

Github action jobs don't have GPU access thus apex doesn't run. This can be done with self-hosted runners though


Added as_pure_dictionary method

I recently had a problem with pickling and unpickling UltraDict instances with recurse=True.
After some wild bug hunting I realized that accessing UltraDict's data attribute/property didn't convert nested UltraDict items also to basic dictionaries, thus breaking pickling and unpickling actions, other than stopping following updates from syncing.
I added the method as_pure_dictionary, with proper unit tests, and tested them in production with one single shared memory between 6 high frequency realtime processes both using reads and writes in different parts of the same UltraDict with recurse=True enabled, with success!
Basic usage for me in that project was something like this pseudocode:
ultra = UltraDict(
    {
        "1": "hello",
        "2": 5,
        "3": {
            "1": 1,
            "2": {
                "1": True,
                "2": None,
                "3": [1, 2, 3]
            },
            "3": [4, 5, 6, {"7": 8}]
        }
    },
    recurse=True,
    create=True
)

as_dict = ultra.as_pure_dictionary()
db.save(pickle.dumps(as_dict))
# Saving it to database

# Some time later, on the next app opening
as_dict = pickle.loads(db.load())
ultra = UltraDict(as_dict, recurse=True, create=True)

# And start reusing it as I left it!
ultra["2"] = 18

Hope it sounds good for you, and hope it helps somebody as well as it helped me!
If you have questions let me know, I'm happy to fix things if they aren't properly good enough :)

Thanks for your pull request. I expect to merge this on the weekend.

Hi, any problems regarding this pull request? Should I fix something?

Hey, sorry, no problem at all. I wanted to merge but then there were issues with my build pipeline as I added some performance tests (to detect performance regressions) which are not working yet and never had the time to finish it. I'll try to do it asap. Sorry again and thanks for your contribution. Much appreciated.

If you need help for contributions I'm here to help if needed :)

So it's finally merged, thanks for your patience. UltraDict v0.0.7 is coming soon.

Nice! Thanks for your support :)


Optimize images

Currently all images are not optimized at all: they all just PNGs with alpha transparency.  But it takes 2 MB to load a simple page. Way too much.
So what it did:

Converted all images to JPG with decent compression (70-80%)
Created 1x and 2x versions used in srcset attributes to load 2x only when it’s needed
Fixed size in manifest.json: 600 instead of 512 (actual size of the picture)

What it gives:

463 KB on 1x screen (4,3 times less)
877 KB on 2x screen (2,2 times less)

…without any noticable regression.
I hope you’ll accept this PR and will be careful with your next project.

Is the black outline around the white logos wanted?

I may have chosen the wrong matte color for white logo. Let me check.

Sorry for delay: yes, I specifically optimized white logo to use #333333 color matte since it’s only used on such background and there’s no need in alpha transparency. I guess it’s good to go then :)

Awesome, again - thanks a million for this :)


More a sugestion than an issue

Hello,
I've trying on and off for the sake of my sanity to get YOLO and yolo_mark to work on my machine for a final year college project.
It's been about 12 weeks since I started and, somehow, didn't manage to get anything to work, the instructions you provide are, for the most part, a bit unclear and shallow and every time something seems to be broken. It's either that or I'm just too dumb to understand and use this.
I would suggest for you to pair up with someone willing to go through and write the documentation in a better, more understandable and robust format.
Nevertheless this is some aw standing work and you deserve my admiration for that.
Thank you,
JRG

Is your problem in compilation, training or detection?

Had problems in understanding the instructions for the three of them.
Understanding what the auxiliary files you require do and must be located and the whole workflow of both yolo and yolo_mark It's not clear.

Do you mean that you could not compile darknet in 12 weeks?
Can you give some good instructions on another machine learning framework and object-detection neural network that you managed to build and train quickly?
What OS do you use?
Did you successfully install OpenCV, CUDA, cuDNN?
What is your primary programming language Python, C, ...?

Yes I do. Elsewise I would not humiliate myself like this.
I also tried Keras and none of anything seems to work. Implement (or build as we say now) as instructed in one place booom, something is broken, try another one, solves some issue that the previous elevated but other 3 emerge, try de official, instructions are fussy, incomplete or ambiguous.
I've not been able to do anything but trying to find fixes and troubleshooting for the past 12 weeks (hence I think the problem lies within me).
Please bare with me here, I come from a judiciary police/forensics background, things I use are usually very succinct and leave no room for guessing.
I use Ubuntu 18.04.4 LTS
12 GiB of RAM
intel core i7-4510U dual core, multi threaded processor
amd graphics card, don't bother, never worked on any distribuition.
opencv version: 4.3.0-dev as per my python interpreter
both python2 and 3 fully supported by the system.
Don't have a primary but I grasp C, C++, python, R, java and C# (also some arcane javascript).
Sorry if I sound angry and frustrated, I am and I'm not blaming you.

Did you read requirements? https://github.com/AlexeyAB/darknet#requirements

It can't use AMD graphic card, since it requires nVidia GPU https://en.wikipedia.org/wiki/CUDA#GPUs_supported
It requires OpenCV installation, run sudo apt-get install libopencv-dev

Did you try make to build Darknet?

The simplest way:

Download and un-zip Darket https://github.com/AlexeyAB/darknet/archive/master.zip
run make in the Darknet folder
Download file https://github.com/AlexeyAB/darknet/releases/download/darknet_yolo_v3_optimal/yolov4.weights to the Darknet folder
Run in the darknet folder:
./darknet detector test cfg/coco.data cfg/yolov4.cfg yolov4.weights data/dog.jpg

I try to understand which part is the most incomprehensible and difficult.
Also, if you try to train many other object detectors from other frameworks, then yolo will seem like a paradise to you)
In general, all machine learning frameworks are designed for developers, not for users.

Will try that.
My major is computer engineering btw.
Get back to you as soon as I can.
Thank you for your time.

https://www.youtube.com/watch?v=mKAEGSxwOAY


Incorporated pathlib.Path compatibility

In this PR I have added input (and explicit output) compatibility
between pymapdl-reader and the pathlib.Path class. All file path-input
arguments should now be accepted as either strings or pathlib.Path
objects. Additionally there is no breaking change regarding the filename
properties. These will continue to return strings. Wherever possible I
have made it so that internally we store paths as pathlib.Path objects
and they are returned as strings through properties. Setters
additionally will accept strings or pathlib.Path objects.
Users can access the pathlib.Path objects via new pathlib_filename properties.
I could not think of a better name, but suggestions are welcome.
Unfortunately i have not been able to get the test suite working on my
local machine and so have not been able to write tests to go with these
changes. I would appreciate input from others regarding how to get the
tests running and if my changes do break any existing tests. I do not
believe so but I am very limited in how I can check.
With the latest commits and #103 I have managed to get my development version
working and confirmed the changes work as well as adding tests for them.
This PR is ready for review and merging.
(closes https://github.com/pyansys/pymapdl-reader/issues/98)

Unfortunately i have not been able to get the test suite working on my
local machine and so have not been able to write tests to go with these
changes. I would appreciate input from others regarding how to get the
tests running and if my changes do break any existing tests. I do not
believe so but I am very limited in how I can check.

Let's open a separate PR to decouple the testing requirements of ansys-mapdl-core by caching the expected results to *.npy arrays within testfiles.

Ready for review!


Fix SonarQube violations

This PR fixes the violations for the following SonarQube rules:
https://rules.sonarsource.com/java/RSPEC-2272
If you do no want to receive automated PRs for SonarQube warnings, reply to this PR with 'STOP'

Reproduce:

clone repo
mvn verify


Chapter 1, Slices, second example("slices 2") does not compile

Hi, I'm new to Zig and I think I found a (minor) issue with one of your code examples. :)
Chapter 1, Slices, second example("slices 2") does not compile with neither Zig 0.6.0 nor 0.6.0+d907f574e (master at the time of writing).
Here's the complete code example I used:
const std = @import("std");
const expect = std.testing.expect;

test "slices 2" {
    const array = [_]u8{1, 2, 3, 4, 5};
    const slice = array[0..3];
    expect(@TypeOf(slice) == *[3]u8);
}

And here is the output of Zig 0.6.0+d907f574e (0.6.0 has identical output):
Test [1/1] test "slices 2"...test failure
/home/flandere/local/lib/zig/std/testing.zig:193:14: 0x20448b in std.testing.expect (test)
    if (!ok) @panic("test failure");
             ^
/home/flandere/tmpcode/zig/src/slices.zig:7:11: 0x204aae in test "slices 2" (test)
    expect(@TypeOf(slice) == *[3]u8);
          ^
/home/flandere/local/lib/zig/std/special/test_runner.zig:47:28: 0x22bc0e in std.special.main (test)
        } else test_fn.func();
                           ^
/home/flandere/local/lib/zig/std/start.zig:252:37: 0x20550d in std.start.posixCallMainAndExit (test)
            const result = root.main() catch |err| {
                                    ^
/home/flandere/local/lib/zig/std/start.zig:123:5: 0x20524f in std.start._start (test)
    @call(.{ .modifier = .never_inline }, posixCallMainAndExit, .{});

After some fiddling with it, I found out that it expects *[3]u8 to be const because array is const.
I made a few attempts to compare slice against a const version of *[3]u8, with little success.
These refuse to compile because const is invalid in this place:
expect(@TypeOf(slice) == const *[3]u8);
expect(@TypeOf(slice) == @TypeOf(const *[3]u8));

For completeness, the error:
./src/slices.zig:7:30: error: invalid token: 'const'
    expect(@TypeOf(slice) == const *[3]u8);
                             ^

Changing the array to be var allows the code to compile, but I'm not sure if it's possible to compare a const slice against a const *[3]u8.
Thank you for ziglearn! The first chapter has been a pleasure to read and helps me hit the ground running with learning Zig.

My apologies - I first wrote this with that being var, but later went to make things const where possible. Mustn't have caught that one - will update now - thanks for the report

Closed in https://github.com/Sobeston/ziglearn/commit/a975b488b98808a2add6541836dd346926fc2308


Update calculator.py

Added ability to cube a defined value

Hey @jkoors this looks great!
Only thing I'd change is how you submitted two pull requests, one for the code and one for the source. In the future, I'd submit one with both of them in the same pull request. I'll duplicate this exact comment on the other PR, so you'll hopefully see it.
Nice work!

thanks, @GregHilston , how would I have added 2 to the same PR?  Also, is there anything else I should do post approval of the merge into master?


Update dependency org.apache.cxf:cxf-rt-rs-client to v3.3.2

This PR contains the following updates:

Package
Update
Change
References

org.apache.cxf:cxf-rt-rs-client
patch
3.3.1 -> 3.3.2
homepage

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Pep8

I didn't test it, hopefully nothing breaks

This breaks training with
ModuleNotFoundError: No module named 'training'
Traceback (most recent call last):
  File "training/train_imagenet_nv.py", line 20, in <module>
    from training.fp16util import (model_grads_to_master_grads,
ModuleNotFoundError: No module named 'training'
Traceback (most recent call last):
  File "training/train_imagenet_nv.py", line 20, in <module>
    from training.fp16util import (model_grads_to_master_grads,
ModuleNotFoundError: No module named 'training'

reverting the PR @ternaus


toEntities/fromEntities lacks test coverage

I can't find any references to entities-based policies in the ginkgo framework. Appears to be a test gap.

Looks like #3359 addresses this more in-depth; @joestringer can this be closed?

Duplicate of #3359.


Add Getting Started section to README

README Update
Please add a getting started section to this README so folks know how to get started.

Added Getting Started section to README file.


Scroll Bar and Progress Bar added

#107
I have Added the appealing Scroll bar and Progress bar
Before: No progress bar and basic scroll bar

After: Adding scrollbar and progress bar

Over all performance :
https://github.com/user-attachments/assets/69cb2bf1-80c8-4a23-819e-bb7682302df9

@srishti023 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution to GSSOC'24 EXTENDED! 🎉


Add support to Llama.cpp

Allow the possibility to use llama.cpp models.
Planned changes:

We need to add new options in the bot.yml file to specify which client the bot should run with and any extra client configurations required by the clients.
We should create a factory that enables the use of different clients.
Develop OpenAI and LLamaCpp client implementations.

Currently exploring the implementation of llama.cpp by utilizing the llama_cpp.rb Ruby binding. This experimentation is taking place in the experimental-llama-client branch.


task: rename startContinuousSequenceAcquisition and startSequenceAcquisition events

The following events should be renamed to stay in keeping with the pattern of the other names:
startContinuousSequenceAcquisition -> continuousSequenceAcquisitionStarted
startSequenceAcquisition -> sequenceAcquisitionStarted
stopSequenceAcquisition -> sequenceAcquisitionStopped
not sure if that will require changes in pymmcore-widgets or napari-micromanager?
cc @fdrgsp

Agree! Yes there are a couple of widgets that will have to be fixed. I'll soon open a PR to change the names here and then when merged I'll fix the widgets.


Example has some problems running

(output from standalone BlastEm [same result for RetroArch BlastEm], I'm able to play it if I spam continue in the debugger enough times, but resetting locks up the game)
https://github.com/user-attachments/assets/622046f3-0f88-47c4-a1e7-ebd47873bbc7
On RetroArch, Genesis Plus GX works but some colors have weird artifacts (???) and dies on resetting, Picodrive doesn't boot at all.
https://github.com/user-attachments/assets/ffeeef6c-972c-4aa3-9ebf-4f3dd18f627a
(tested on an NTSC Sega Genesis model 1 VA7 with a Mega Everdrive X5)

Thanks for reporting this. I should have thought to check my emulator's debug log while testing this... it's been trying to tell me this the whole time!


Greaseweazle sometimes returns incomplete data after changing sides

 0.0: 500 ms in 141744 bytes
 0.1: 200 ms in 44151 bytes
 1.0: 500 ms in 97388 bytes
 1.1: 0 ms in 0 bytes
 2.0: 500 ms in 141019 bytes
 2.1: 500 ms in 88011 bytes
 3.0: 500 ms in 95254 bytes
 3.1: 300 ms in 59064 bytes
 4.0: 500 ms in 141091 bytes
 4.1: 500 ms in 92833 bytes
 5.0: 500 ms in 99403 bytes
 5.1: 400 ms in 80345 bytes
 6.0: 500 ms in 136271 bytes
 6.1: 300 ms in 54419 bytes
 7.0: 500 ms in 96136 bytes
 7.1: 0 ms in 0 bytes
 8.0: 500 ms in 137293 bytes
 8.1: 400 ms in 84312 bytes
 9.0: 500 ms in 103438 bytes
 9.1: 0 ms in 0 bytes
10.0: 500 ms in 136779 bytes
10.1: 500 ms in 88402 bytes
11.0: 500 ms in 95172 bytes
11.1: 0 ms in 0 bytes

Note that all truncated reads are on side 1 (and of suspicious duration).

It seems that gw always reads the status of pin 26 after doing a seek. Possibly this is adding enough delay to avoid problems.

Ah OK, I got this problem while reading from a single sided disk. So there is very little flux data on that side. However, it's still possibly an indication that something is a bit off with the length conversion (unless maybe the GW firmware has a max limit?)


Select row to view data

This adds the ability to select a row in the table, and highlight that data in the chart.

Whoops, wrong repo. :)


Add MCC DHCP Option

Description
Added a section here, possibly incomplete by your standards, that call out that there's a DHCP option to point endpoints at the MCC server. I think that's important to call out here in the MCC docs.
Why
It's the docs for MCC but they were incomplete in terms of the options available to point endpoints at MCC.
Changes
See Description

I did smile whence I came upon the owner of this doc.
Thanks for the swift reply. Feel free to nuke this PR from orbit then if that's what makes sense. With the public preview coming in 5 days I just thought I'd make sure these docs made some reference to indicates that hardcoding a reg key isn't the only option.
So truly; reject this PR if the re-arranged docs cover both config options.

closing on Meghan's behalf, should be addressed by recent updates. @bryandam if not, please just open a new PR, it'll be easier to do a new one with the new file than trying to reopen this and deal with the merge conflict. 😄

Thanks @aczechowski; looks like you're just going to point at the docs for setting DOCacheHost or DOCacheHostSource which calls out the DHCP option.
Admittedly, I think it might be a bit confusing in that your link is called 'Configure X policies with Intune' but you link to the DO docs instead of the Intune doc's Delivery Optimization settings in Microsoft Intune page. Yet, that page doesn't cover the HostSource setting so maybe that wouldn't work for that reason.


spr diff uses jujutsu to amend?

Hi everyone,
I've been using spr for the last year or so and really love it so far. As an ex-Meta source control person I've always preferred the stacked diff workflow and spr is the best tool of the lot.
I've been trying out Jujutsu version control with a colocated Git repository, and that works pretty well in conjunction with spr (since jj and spr are both about amend/rebase-based workflows).  This is okay, but essentially creates a separate commit with its own identity in jj -- jj cannot link the identities of the old and new commits.
Ideally spr would be able to run jj describe @- --stdin and feed in the message over stdin, which would avoid this problem. Would it be okay to extend spr's amending logic to use jj describe if a jujutsu repository is found?

Some ideas on the jj side of things:

If there is a branch attached to the commit, then jj will correctly track the rewrite the next time it imports refs. I don't know what your workflow looks like, exactly, but if you could attach a branch to help jj out, then everything should work fine.
It might be possible to create a post-rewrite hook that notifies jj about rewrites performed outside of its scope of knowledge. For example, if it piped the rewritten commits to a hypothetical jj util record-rewritten command, then neither you nor spr would have to make any architectural changes to support this use-case (if I understand it correctly).

If there is a branch attached to the commit, then jj will correctly track the rewrite the next time it imports refs. I don't know what your workflow looks like, exactly, but if you could attach a branch to help jj out, then everything should work fine.

Ahh part of the point of me using jj is that I really want the anonymous heads workflow :)

I wrote some very basic support via the jj cli -- it likely needs more polish, but it works okay: https://github.com/getcord/spr/compare/master...sunshowers:spr:master

^ I've been using the above for the last 4 months and it's been fine. Pretty good even!


StreamController API docs still refer to onSubscriptionStateChange

Reported by Kyaw:
https://groups.google.com/a/dartlang.org/d/msg/misc/Mmg9Zzl1MTk/MTj7xT4MAQAJ
https://api.dartlang.org/stable/1.24.2/dart-async/StreamController-class.html
cc @floitschG (who started the thread in 2013)

@kwalrath – fixed in bleeding edge? https://api.dartlang.org/be/154136/dart-async/StreamController-class.html

Yeah the docs no longer reference it.


Attribute node['chef_client']['file_cache_path'] reflected in client.rb

Signed-off-by: Kapil Chouhan<EMAIL_ADDRESS>Description

Attribute node['chef_client']['file_cache_path'] and node['chef_client']['file_backup_path'] are reflected in client.rb

Issues Resolved
Fixes: #384 , #646
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

@kapilchouhan99 what was the reason for removing the rescue here?

because of this issue #646

OK in the case there is no handler I understand we don't need the rescue, but otherwise it is required.


Too many segments in one singleton rowset

In previous compaction, only rowsets will be taken into consideration.
Doing streaming load, the singleton rowset may be made up of many overlapping segments.
Scanning these overlapping segments will result in read amplification.
To address this problem, overlapping segments should be taken into consideration
when doing cumulative compaction to reduce read amplification.

You can create table with hyperloglog type to reproduce the problem.
CREATE TABLE `store_sales` (
  `ss_item_sk` int(11) NULL COMMENT "",
  `ss_ticket_number` int(11) NULL COMMENT "",
  `ss_sold_date_sk` int(11)  NULL COMMENT "",
  `ss_sold_time_sk` int(11)  NULL COMMENT "",
  `ss_customer_sk` int(11)  NULL COMMENT "",
  `ss_cdemo_sk` int(11)  NULL COMMENT "",
  `ss_hdemo_sk` int(11)  NULL COMMENT "",
  `ss_addr_sk` int(11)  NULL COMMENT "",
  `ss_store_sk` int(11)  NULL COMMENT "",
  `ss_promo_sk` int(11)  NULL COMMENT "",
  `ss_quantity` int(11)  NULL COMMENT "",
  `ss_wholesale_cost` decimal(7, 2) replace NULL COMMENT "",
  `ss_list_price` decimal(7, 2) replace  NULL COMMENT "",
  `ss_sales_price` decimal(7, 2) replace  NULL COMMENT "",
  `ss_ext_discount_amt` decimal(7, 2) replace  NULL COMMENT "",
  `ss_ext_sales_price` decimal(7, 2) replace  NULL COMMENT "",
  `ss_ext_wholesale_cost` decimal(7, 2) replace  NULL COMMENT "",
  `ss_ext_list_price` decimal(7, 2) replace  NULL COMMENT "",
  `ss_ext_tax` decimal(7, 2) replace  NULL COMMENT "",
  `ss_coupon_amt` decimal(7, 2) replace  NULL COMMENT "",
  `ss_net_paid` decimal(7, 2) replace  NULL COMMENT "",
  `ss_net_paid_inc_tax` decimal(7, 2) replace  NULL COMMENT "",
  `ss_net_profit` decimal(7, 2) replace  NULL COMMENT "",
  `hll_col` HLL HLL_UNION
) ENGINE=OLAP
DISTRIBUTED BY HASH(`ss_item_sk`, `ss_ticket_number`) BUCKETS 1
PROPERTIES (
"replication_num" = "1"
);

Use TPC-DS tools to produce the data and use

LOAD LABEL load_hll (
DATA INFILE("hdfs_path")
INTO TABLE `store_sales`
COLUMNS TERMINATED BY "|"
(ss_item_sk, ss_ticket_number, ss_sold_date_sk, ss_sold_time_sk, ss_customer_sk, ss_cdemo_sk, ss_hdemo_sk, ss_addr_sk, ss_store_sk, ss_promo_sk, ss_quantity, ss_wholesale_cost, ss_list_price, ss_sales_price, ss_ext_discount_amt, ss_ext_sales_price, ss_ext_wholesale_cost, ss_ext_list_price, ss_ext_tax, ss_coupon_amt, ss_net_paid, ss_net_paid_inc_tax, ss_net_profit)
SET (hll_col=hll_hash(ss_item_sk))
)
WITH BROKER broker_name
properties ("max_filter_ratio" = "0.5", "strict_mode" = "false");


added displayRelativeDate option

Added config option to not show relative dates.

@Nolux This configuration is not needed. You can disable the relative days by emptying the texts for the relative days. Just add the following to your card configuration:
texts:
  yesterday:
  today:
  tomorrow:

Great I did not see that in the code. Thanks for the heads up. I'll close this PR then.


Crash

It would appear that there is a chunk of code causing a crash occasionally when opening a Controller or Action window.
Specifically, if this chunk of code gets executed, then this will cause an Array Out of Bounds exception.
I'm not too familiar with Slate programming, but commenting out the second line seemed to solve the crash for me.

c018111c1d1e481f6951ef9899ed485ca9d0f749
Added assert when no options are configured.


tableslurp (on master) is throwing an exception...?

I'm testing out the latest tableslurp code (I want/need --recursive) but it seems to be failing with an exception that I don't really understand...
I'm invoking with:
tableslurp -n backups/cassandra/dp/staging-data-01 --recursive --aws-region us-west-1 my-ec2-shared /var/lib/cassandra/data /var/lib/cassandra/data/
That seems to progress well for a while but then throws an exception and bails:
tableslurp [2018-06-14 05:45:45,565] INFO Thread #1 finished processing
tableslurp [2018-06-14 05:45:45,570] INFO Thread #2 finished processing
tableslurp [2018-06-14 05:45:45,577] INFO Downloading backups/cassandra/dp/staging-data-01:/var/lib/cassandra/data/dp/fi_b/dp-fi_b-ka-415-Summary.db from my-ec2-shared to /var/lib/cassandra/data/dp/fi_b/dp-fi_b-ka-415-Summary.db
tableslurp [2018-06-14 05:45:45,614] INFO My job is done.
Exception in thread Thread-112 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
  File "/usr/lib/python2.7/threading.py", line 763, in run
  File "/usr/local/bin/tableslurp", line 317, in _worker
<type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'info'

I'm a bit of a python novice but if I'm reading that stack trace correctly it maps to the following line in tableslurp (line 317):
log.info('Thread #%d finished processing' % (idx,))
That seems to suggest that 'log' in undefined...? However, I see several other log lines that show "Thread #2 finished processing" so I'm super confused...
My python novice Google foo suggests it might be something wrong with threading... Anyone have any ideas?

It does seem like all the files were copied over...
My currently guess is that its related to the worker threads having daemon = true set (https://github.com/danwashusen/tablesnap/blob/master/tableslurp#L334). That doesn't seem correct to me...?


Android javax.net.ssl and FIPS compliance openSSL. (In app vs android stack)

Hi folks,
AFAIK Android javax.net.ssl classes uses openSSL/BoringSSL library at C/Low level for any SSL/TLS.
https://developer.android.com/reference/javax/net/ssl/package-summary.html.
/**

Provides the Java side of our JNI glue for OpenSSL.
*/
https://android.googlesource.com/platform/external/conscrypt/+/f087968/src/main/java/org/conscrypt/OpenSSLSocketImpl.java

https://android.googlesource.com/platform/external/conscrypt/+/master/src/main/java/org/conscrypt/NativeCrypto.java
https://android.googlesource.com/platform/external/conscrypt/+/master/src/main/java/org/conscrypt
C++
https://android.googlesource.com/platform/external/conscrypt/+/master/src/main/native/org_conscrypt_NativeCrypto.cpp
org_conscrypt_NativeCrypto.cpp
https://android.googlesource.com/platform/external/conscrypt/+/master/Android.mk
(Build OpenSSL or BoringSSL).
Intention: Load FIPS compliance openSSL libaray in my application and make javax.net.ssl(okhttp) classes use the that library hence my application become fips complaince.
https://wiki.openssl.org/index.php/FIPS_Library_and_Android
http://square.github.io/okhttp/
Simlilar to WolfSSL provider but its at firrware level or aosp,  also its not JSSE compatible.
http://www.linuxjournal.com/article/10896
is this feasible to load FIPS openSSL .OS and link it , what are configuration at android java level ?
Thanks
Nithin

@mattcaswell pls share your thoughts on this..

Sorry, I'm not really the best person to ask about either FIPS or andriod. In any case this issue is probably better raised on the openssl-users email list rather than here as it isn't a bug. Sign up info here:
mta.openssl.org

If this is still an open question please raise on openssl-users as noted above. Closing this.


Release 2019-4-8

Reviewer: self merging
CC: @jdorweiler

Description:
Releasing the following changes:

#369 - Add logic to generalize ATB param if the service tells us to
#370 Check for and parse additional success page params
#372 Update minimum required node version to 10.0.0

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

👍


Update README.md and add CONTRIBUTING

README.md should contain license and contributing information.

Nice looks like this is done.  But can you update the README.md in the tests/ directory to include pre-requisites?

Will do.

Closing for now, in favor of #59


UnpaddedInternalThreadLocalMap.nextIndex should not be static

Expected behavior
UnpaddedInternalThreadLocalMap.nextIndex should not be static
Actual behavior
UnpaddedInternalThreadLocalMap.nextIndex is static.
FastThreadLocal use this static nextIndex to initiate index
    public FastThreadLocal() {
        index = InternalThreadLocalMap.nextVariableIndex();
    }

When set value , there possible cause many expand action:
    public boolean setIndexedVariable(int index, Object value) {
        //****************************************************************
        //the default length of lookup is 32
        //****************************************************************
        Object[] lookup = indexedVariables;
        if (index < lookup.length) {
            Object oldValue = lookup[index];

             /****************************************************************
              because index is generated by a static variable , when index is 31 ,
             it's possible that 1 ~ 30 occupied by other thread , so here may wast many slots ,
             especially when there are many threads and every thread have some FastThreadLocals.
           ***************************************************************/
            lookup[index] = value;
            return oldValue == UNSET;
        } else {
           //****************************************************************
           //If there are more than 32 FastThreadLocals , then the next new FastThreadLocals will expand every time.
           //****************************************************************
            expandIndexedVariableTableAndSet(index, value);
            return true;
        }
    }

Steps to reproduce
Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.92.Final
JVM version (e.g. java -version)
OS version (e.g. uname -a)

There is an index per thread-local, not per thread. This is how threads are able to tell thread-locals apart.

There is an index per thread-local, not per thread. This is how threads are able to tell thread-locals apart.

but the initial value of index if from a static Integer , UnpaddedInternalThreadLocalMap.nextIndex
this nextIndex will becaom bigger and bigger by using times of thread-local

this nextIndex will becaom bigger and bigger by using times of thread-local

Yes, it is best to avoid creating an unbounded number of FastThreadLocal objects. Their number should ideally be finite and small.

Why Netty don't design nextIndex to be a non-static Integer?
In non-static nextIndex way, FastThreadLocal can fully utilize UnpaddedInternalThreadLocalMap.indexedVariables.
In current static way , some slots of UnpaddedInternalThreadLocalMap.indexedVariables may be wasted.

    public boolean setIndexedVariable(int index, Object value) {
        Object[] lookup = indexedVariables;
        if (index < lookup.length) {
            Object oldValue = lookup[index];
            lookup[index] = value;
            return oldValue == UNSET;
        } else {
            expandIndexedVariableTableAndSet(index, value);
            return true;
        }
    }

See this function,
lookup[index] = value ,  that means  lookup[1 ...... index-1] are all UNSET and never use them, a little strange at here?

Say you have FastThreadLocal A and B.
And two threads T1 and T2.
If T1 initialises A, and T2 initialises B, and then T1 accesses B, then T1 will find that B has the same value as what A was initialised to.
In the best case this will cause a ClassCastException, and worst case who knows what problems random data sharing could cause.

The array is per thread, and each FastThreadLocal is an index into the array.

I guess @magiczhangx is concerned about having too large index number for a thread with just a few fast thread local variables. That's actually how FastThreadLocal is at the moment.
We could maybe improve this sparseness by keeping a Map<FastThreadLocal, Integer> in InternalThreadLocalMap, but it will likely make it not 'fast' anymore given its overhead? Please feel free to experiment and let us know if you found a way to make it as fast as before while making it more compact.


Darksiders Genesis - vkCreateInstance Failed to create Vulkan instance

I get these error messages when trying to run Darksiders Genesis using AMDVLK:
002c:err:vulkan:wine_vkCreateInstance Failed to create instance, res=-9
warn:  Failed to create Vulkan 1.1 instance, falling back to 1.0
002c:err:vulkan:wine_vkCreateInstance Failed to create instance, res=-9
err:   DxvkInstance::createInstance: Failed to create Vulkan instance

This issue doesn't happen with RADV, only with AMDVLK.
GPU: AMD HD 8750M 2gb of vram
AMDVLK: v-2019.Q4.5
Driver: Mesa 19.3.1 (kisak-mesa PPA)
OS: Linux Mint Cinnamon 19.3

That issue happened, because DXVK was using iGPU instead of dGPU. A restart fixed this issue.


Make hostname configurable

Hey there, I love your tool. It's dlite-ful.
In a bunch of projects we use a different host alias (docker.local).
Could you make the alias somehow configurable? I know it would be a small fix, but I am not too fit with go :+1:

yup, making the hostname configurable is a great idea. i'll work on that

That'd be cool. Parallels uses <machine>.shared, which might be interesting to emulate in case a work environment uses both tools.

I am adding my support to a configurable hostname. I use .dev, which has it's own issues but I already have it in a lot of code.

:tada: Thanks!


[Suggestion] Fuel

It would be really awesome if we had the option of fueling our vehicles.

Also (if possible): add fluid fuels


Allow changing remote origin with Repository

This is a bit of a power-user case, so actually I'm not sure we want this in huggingface_hub. I used this to be able to fork repos, but apart from that there might not be too much usage, so wanted to bring it up and see what you think.
We already have a getter method for the remote origin url.
cc @LysandreJik @muellerzr

I think a broader solution to this would be to add a very configurable git method  that would take as commands any git command. For example, something alongside:
repo.git_command("clone https://..")

As long as this is launched with the shell=False parameter of subprocess it should be somewhat security friendly, and would enable complex use-cases like you describe without needing to interact with the command line directly.

(closing as "wontfix" as Repository usage is deprecated anyway)


Support for scrolling using relative position mode

Add support for relative positioning like iscroll
https://github.com/cubiq/iscroll/issues/1029

Coverage decreased (-2.06%) to 93.769% when pulling b26a4c6808d755af38cc01393ba95f8b02f3d020 on cytle:master into 36f96e7405401deb55a013e26633f39641865875 on stackjie:master.


Version 3.14.3 of react modal fixes a race condition with the unmount

Version 3.14.3 of react modal fixes a race condition with the unmount of the component. Using this allow us to remove a fix in the tests to address this. Also, this will help with other project tests using DSR
Fixes #
When adding 3.14.2 react-model there was a race condition that was addressed with a timeout in the tests. This is addressed by https://github.com/reactjs/react-modal/pull/883 in 3.14.3 of react-modal.
This fix updates the react-modal version and removes the timeout in the tests that is no longer needed.
Additional description

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[done] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[done ] npm run lint:fix has been run and linting passes.
[done ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[done ] Tests have been added for new props to prevent regressions in the future. See readme.
[done ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ done] Review tests are passing in the browser. Open http://localhost:8001/.
[done ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

I believe this should be ready for review


Enrollment issue when user unenrolls and enrolls again and pays

Related to this issue https://github.com/mitodl/hq/issues/4367
the user has enrolled in audit then unenrolled from the run, then they enrolled in verified. As a result their status in the courseware is verified, but active is False.
Expected Behavior
When user pays and enrolls in verified track the enrollment in edx should be active.
Current Behavior
The user can't access the course bc their enrollment is not active.

@annagav, where you able to reproduce this issue locally or in RC?

no, I don't think so

I have not been able to reproduce this bug following the steps in this issue.

If a user has paid for a course run and they want to unenroll:

Don't allow. Need to contact CS.
Allow to unenroll. Decide what to do with the payment: Order, PaidCourseRun, etc.


Code Checkout Bug

When a branch is the same name as a file within the repo, the Yor action fails with:

/usr/bin/git checkout branch
fatal: 'branch' could be both a local file and a tracking branch.
Please use -- (and optionally --no-guess) to disambiguate

This issue in a different project suggests changing the below line from checkout to switch should fix this.
https://github.com/bridgecrewio/yor-action/blob/2320f4cc960e0b9f5407a4044f5cd63bd4260c59/src/main.ts#L18

hey @mikecarr2 thanks for reaching out.
Sounds like a good idea, since you already know what to change, how about doing a contribution? 🙂

When a branch is the same name as a file within the repo, the Yor action fails with:

/usr/bin/git checkout branch
fatal: 'branch' could be both a local file and a tracking branch.
Please use -- (and optionally --no-guess) to disambiguate

This issue in a different project suggests changing the below line from checkout to switch should fix this.
https://github.com/bridgecrewio/yor-action/blob/2320f4cc960e0b9f5407a4044f5cd63bd4260c59/src/main.ts#L18


Make UndefinedArgumentOrOptionRule fail sooner to avoid expensive type system calls

[x] Added or updated tests
[x] Documented user facing changes

Reorder the checks in UndefinedArgumentOrOptionRule so that cheap checks are first
this reduced the cost of this rule from 1% to 0% of total time on a decent sized class that is not an instance of Command.

Thank you!


[Bug] text_encoder failing kfp_ray test

Search before asking

[X] I searched the issues and found no similar issues.

Component
Transforms/Other
What happened + What you expected to happen
With the recent PR to properly enabled kfp workflow tests (PR https://github.com/IBM/data-prep-kit/pull/672) on transforms, we found that repo_level_ordering was not passing (see log here. To get the PR to pass, text_encoder/kfp_ray/Makefile was renamed to Makefile.disable-cicd.
Reproduction script
To reproduce
cd transforms/language/text_encoder/kfp_ray
git mv Makefile.disable-cicd Makefile
git commit -s -a -m "restore kfp_ray test for text_encoder"
git push
Make a PR and watch the cicd
Anything else
 make[5]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/kfp/kfp_ray_components'
rm -rf data-processing-lib-ray
rm -rf data-processing-lib-python
rm -rf shared_workflow_support_lib
rm -rf workflow_support_lib
make[4]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/kfp/kfp_ray_components'
make[3]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/kfp/kfp_ray_components'
make[3]: Entering directory '/home/runner/work/data-prep-kit/data-prep-kit/kfp/kfp_ray_components'
kind load docker-image quay.io/dataprep1/data-prep-kit/kfp-data-processing:latest --name=dataprep
Image: "quay.io/dataprep1/data-prep-kit/kfp-data-processing:latest" with ID "sha256:000fdabe3bf3f95eabb3f5aef098fed7e57e047bda1046df696ecf299eaeb7d0" not yet present on node "dataprep-control-plane", loading...
Image: "quay.io/dataprep1/data-prep-kit/kfp-data-processing:latest" with ID "sha256:000fdabe3bf3f95eabb3f5aef098fed7e57e047bda1046df696ecf299eaeb7d0" not yet present on node "dataprep-worker", loading...
Image: "quay.io/dataprep1/data-prep-kit/kfp-data-processing:latest" with ID "sha256:000fdabe3bf3f95eabb3f5aef098fed7e57e047bda1046df696ecf299eaeb7d0" not yet present on node "dataprep-worker2", loading...
ERROR: command "docker save -o /tmp/images-tar359392491/images.tar quay.io/dataprep1/data-prep-kit/kfp-data-processing:latest" failed with error: exit status 1

Command Output: write /tmp/images-tar359392491/.docker_temp_4286091745: no space left on device
make[3]: *** [Makefile:57: kind-load-image] Error 1
make[3]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/kfp/kfp_ray_components'
make[2]: *** [/home/runner/work/data-prep-kit/data-prep-kit/transforms/language/text_encoder/kfp_ray/../../../..//transforms/.make.workflows:45: .workflows.test-pipeline] Error 2
make[2]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/language/text_encoder/kfp_ray'
make[1]: *** [Makefile:45: workflow-test] Error 2
make[1]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/language/text_encoder/kfp_ray'
make: *** [Makefile:64: workflow-test] Error 2
make: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/language/text_encoder'
Error: Process completed with exit code 2.

OS
Ubuntu
Python
3.10.x
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Its added to the kfp black list in https://github.com/IBM/data-prep-kit/pull/684


[SPARK-41476][INFRA] Prevent README.md from triggering CIs

What changes were proposed in this pull request?
This PR prevents README.md-only changes from triggering CIs.
Why are the changes needed?
While CIs goes slower and slower, we are also getting more and more README.md.
$ find . -name 'README.md'
./resource-managers/kubernetes/integration-tests/README.md
./core/src/main/resources/error/README.md
./core/src/main/scala/org/apache/spark/deploy/security/README.md
./hadoop-cloud/README.md
./python/README.md
./R/pkg/README.md
./docs/README.md
./README.md
./common/network-common/src/main/java/org/apache/spark/network/crypto/README.md
./common/tags/README.md
./connector/docker/README.md
./connector/docker/spark-test/README.md
./connector/connect/README.md
./connector/protobuf/README.md
./dev/README.md
./dev/ansible-for-test-node/roles/common/README.md
./dev/ansible-for-test-node/roles/jenkins-worker/README.md
./dev/ansible-for-test-node/README.md
./sql/core/src/test/README.md
./sql/core/src/main/scala/org/apache/spark/sql/test/README.md
./sql/core/src/main/scala/org/apache/spark/sql/jdbc/README.md
./sql/README.md

We can exclude these files in order to save the community CI resources.
https://github.com/apache/spark/blob/435f6b1b3588d8c3c719f0e23b91209dd5f7bdb9/.github/workflows/build_and_test.yml#L86-L89
Does this PR introduce any user-facing change?
No. This is an infra-only change.
How was this patch tested?
Manually make a README.md-file-only-change commit and run the following.
$ APACHE_SPARK_REF=HEAD~1 dev/is-changed.py
false

Could you review this too please, @gengliangwang ?

Thank you so much, @gengliangwang !

BTW, if you don't mind, I'd like to land this to all live branches to reduce the community resources. WDTY, @HyukjinKwon and @gengliangwang ?

Thank you, @HyukjinKwon !

Merged to master/3.3.