Add method to check if limited

Would be nice, instead of just having a throttle, to check if the key should be throttled, and return true or false if it should be.

There is getEstimate, I use that for this purpose.

getEstimate doesn't increase the counter though.

That was by design, I don't think being refused something should increase the counter?

$estimate = $throttle->getEstimate('thing', 10, 60000);

if ($estimate > 0) {

    $retry = intval($estimate/1000) + 10;

    header("HTTP/1.1 429 Too Many Requests");
    header("Retry-After: $retry");

    exit;
}

$throttle->throttle('thing', 10, 60000);

Yeah, I guess I'm just asking for a shortcut method, that checks, and increments. Instead of needing two methods. Or that PR

Would this suffice?

function shortcut($throttle, $id, $limit, $milliseconds)
{
    if ($throttle->getEstimate($id, $limit, $milliseconds)) {
        return true;
    }

    $throttle->throttle($id, $limit, $milliseconds);

    return false;
}

should return the wait time, if its throttled, no?

Would be nice, instead of just having a throttle, to check if the key should be throttled, and return true or false if it should be.

I just went with what was said here.


Option to disable Physics

I wanted the option to disable physics, because with a bigger network it takes quite some time before things settle. Also organizing is not optimal, when devices do not have coordinates yet and start flying around when another is moved.
Unfortunately, simply disabling physics puts everything at (0, 0) by default.
So I got just overengineered some static clustering.
The idea is to find a random coordinate as a center point for each rack (using the rack name as a seed yields the same "random" coordinates for every rack) and adding a small random offset by using the (unique) device name as seed.
Currently there is two magic numbers (12 in line 218 and 2 in line 225/226). They scale the resulting graph.

I recognize the idea is a bit unorthodox, but I also think that having physics enabled by default is not great for larger networks.
Note: If you consider merging this, I think the commit should be squashed, as I initially had #488 as a single branch and split it into two PRs. This makes the history pretty ugly.

Hi,
first of all, thank you for your contribution.
Which accepted FR do you close with this PR actually? If it's #436, that one is under review for a good reason. It is absolutely not clear how to implement the FR. You've made a solution that only fits your personals needs. We should always find solutions that fits everyones needs or discuss until we get to a good compromise.

This PR does not have a FR, I just wanted the option to disable physics, since in my graph it was a chore to organize the nodes when things were moving constantly. Of course that changes once you turn on "save coordinates", but that still requires every node to be selected/moved once.
#436 and #122 both touch the idea of disabling physics, but it is not their main focus as far as I understand.

You've made a solution that only fits your personals needs. We should always find solutions that fits everyones needs or discuss until we get to a good compromise.

Agree with the second part. I built this as a simple fix to everything being located at (0, 0) when I disables physics in the module by setting the key to False for all nodes and edges. Also it fits my personal needs, but since I am working with a decently large setup, I hope it holds some value that can be applied generally.
The proposed code is a "best effort" clustering, instead of running a full ground state simulation on the server. While it does not look as pretty as the result of vis.js' physics simulation, it is obtained a lot faster and does not have a round shape (which is unusual for topology graphs).
A (in my opinion sane) assumption I made was, that users will re-organize the graph manually anyway, therefore I prioritized clustering racks over it looking pretty.
I maybe should have made it clearer, but this more or less is a Feature Request that offers an idea how to solve the issue of not having coordinates when simply disabling physics in vis.js.
If it is easier to discuss first, I am open to close this, create an Issue to discuss the option to disable physics.

This would be a great change to do!

Messed up managing my branches and pushed a merge that does not belong here. Removed those commits with a force push.

I tried this out but i am not convinced the seeding works very well (at least for my own testing).
I am not sure this is the way we want to implement it, however it gave me and idea on what to try.
I will not merge this for now.


[[FIX]] JSHint should warn about duplicate key 'proto'.

Spec (https://people.mozilla.org/~jorendorff/es6-draft.html#sec-B.3.1):
It is a Syntax Error if PropertyNameList of PropertyDefinitionList contains any duplicate entries for "_proto_" and at least two of those entries were obtained from productions of the form
PropertyDefinition : PropertyName : AssignmentExpression .
Fixes #2372

Coverage decreased (-0.0%) to 96.56% when pulling 81b60af376dd8ae686278d1abb73def5746725c6 on nicolo-ribaudo:issue-2372 into a093f784ee5298973c6233e9113842cbe8d16c74 on jshint:master.

What do you think about this code?
var __proto__ = 1;
var a = {
  __proto__: [],
  __proto__
};

This isn't a duplicated property, as Object.getPrototypeOf(a) is [], but a.__proto__ is 1.

ha, well IMO, I could be wrong, but I think that most likely the person writing
var a = {
  __proto__
};

probably made a mistake.. It seems to me like a dangerous thing to do.
I doubt anyone will complain if you still error..

@nicolo-ribaudo Despite appearances, I have not forgotten about this patch. It's what prompted my patch at gh-2539 last week, and just now it helped me identify a regression in master. It's been a deceptively involved review process for such an edge case, but I wanted to let you know that I'm still working with it.

Would this be a breaking change?

Superseded by gh-2566. The change there is preferable (now that gh-2559 has landed) because it covers additional identifier usages and because it works in more environments. Thanks for reporting the problem!


expiry clarification

Hi,
Can you explain to me the difference between
express-rate-limit windowMs and rate-limit-redis expiry?
windowMs: milliseconds - how long to keep records of requests in memory. Defaults to 60000 (1 minute).
expiry: seconds - how long each rate limiting window exists for. Defaults to 60.
Does one of these override the other? Or should they be set the same? Or do they do completely different things?

I'd like to know the same. I've set them to the same value for now and it seems to work alright, in fact, I think this one would override the other one, but haven't looked into the code yet.

Glad to help clarify @jzacharuk + @Ziao! The expiry here is used to control the time for which the first hit will count for during the rate limiting session. An example could be, expiry = 5:
11:31:00: First hit
11:31:01: --
11:31:02: --
11:31:03: --
11:31:04: Second hit
11:31:05: --
11:31:06: (the window created from "First hit" has expired, limit reset!)

I found this to be a good method to help buffer requests without getting locked out permanently.
Let me know if this helps!!

Please re-open if there's any other issues!

So, if I set expiry to 60(1 minute) and windowMs to 3600000(1 hour), the limiting window will reset after 1 minute not 1 hour?
I need to manually set expiry and windowMs matching each other to let rate-limit work as expected. Is it right? @wyattjoh

Bit late, but for others who stumble upon this: The answer to @Diluka's question is yes, you need to manually set them both so that they match. Just remember that the windowMs option is only used in the default rate-limit handler for express-rate-limit, specifically when it sets the Retry-After header.
So if you're overwriting the handler anyway, it doesn't really matter.


Why do we have to use yield for 'put'-effect?

I have two questions of understanding related to the yield put(someAction)-syntax (I suppose they are very simple questions, but I couldn't find an exact answer in the documentation).
1. Why do we have to yield when using put?
If my understanding is right, put-effect will only dispatch an action. Dispatching an action on a redux-store happens fully synchronous. Why do we need to use yield then? Is it just because every redux-saga effect is built up this way, or am I missing out some async-stuff happening which we need to wait for?
2. Is it safe to assume, that the new store is ready after yield put(...)?
Considering the following syntax:
yield put(action1)
yield put(action2)

Is it safe to assume that reducers will always work off action1 before action2 (in other words: action2 always works with the store previously updated from action1)?
Thank you very much for your help.

Hi there! From my understandings:
1 - Remember that put is an effect that tells the middleware to dispatch the real action, as a list of instructions. You can call the real dispatch from the generator, but it isn't declarative and it doesn't gives you any benefits for testing purposes.
2 - I'm not really sure if you make parallel work dispatching both actions, but making a put in that way, calls ultimately the dispatch, that runs synchronously (redux).

Yup, if you put a list of puts when the execution reaches the dispatches it will be executed synchronously

While it's true that put is a dispatch this is slightly more complex. To make various fork+take+put scenarios work we use a simple scheduler under the hood which queues the "nested" puts - that whole queue gets processed within single stack frame, but it means that a single put might not be executed right away.

Is it safe to assume, that the new store is ready after yield put(...)?

It is safe to assume that.

Thanks for the answers!

you can use yield yield put()

It's may be the case, whatever action you want to dispatch may have watcher to run some other saga. if you wont place yield before put both generator will run asynchronously and outcome wouldn't be as expected.


[New Port Request] JavaScriptCore

Library name
JavaScriptCore
Library description
WebKit's JavaScript engine
Source repository URL
https://github.com/webkit/webkit
Project homepage (if different from the source repository)
https://webkit.org
Anything else that is useful to know when adding (such as optional features the library may have that should be included)
JavaScriptCore is a component of the bigger WebKit project, but can be compiled standalone. JavaScriptCore is offered standalone on GNU/Linux distributions (i.e. https://packages.debian.org/bookworm/libjavascriptcoregtk-6.0-1) and by default on Apple systems (https://developer.apple.com/documentation/javascriptcore/c_javascriptcore_api)

Can standalone JSC and JSC that is a part of WebKit be used separately?
IIUC Debian splits WebKit into JSC and WebCore.
I think the same approach is not desirable in vcpkg.

@Osyotr It can. The WebKit build system supports the JSCOnly port for only building JavaScriptCore standalone as either a static or shared library.
I've done some early experiments on this here: https://github.com/jviotti/libjsc, but only got it to work on Linux so far. If you type make (or nmake on Windows), it will use CMake to build the JSCOnly port from a trimmed vendor version of WebKit, build it as a static library, and create a sample program that uses it.
Let me know what you think, and happy to help making the port.

To be more precise, the project above builds and links fine on Windows 11 with Visual studio 2022, but fails to run for some reason.

Still interested in this. We'll come to it soon.

We are actively working on this. We are still interested in this.

The PR is WIP. We are finalizing the PR.


Enable VERIFY_CERTIFICATE_AT_CLIENT by default

Enable proxies using their OS CA certificate bundle by default.
Enable VERIFY_CERTIFICATE_AT_CLIENT by default.

@kfaseela

@Kmoneal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
77c004dd8b9c1718ffb4b92b7ffc0f7d3345bfd1
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I recall in the design doc there was some roadmap to make this safer. Did those items get merged?

Not to my knowledge but I will double check with Faseela and look at next steps

I recall in the design doc there was some roadmap to make this safer. Did those items get merged?

Not to my knowledge but I will double check with Faseela and look at next steps

May be the PR can be updated with the links to whatever items were already done and merged. And what is pending. Atleast I see that the updates to security best practices documentation and other similar items have been merged.

@Kmoneal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Kmoneal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test release-notes_istio

integ-ipv6_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Kmoneal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test release-notes_istio

integ-ipv6_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-ipv6_istio

integ-distroless_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Kmoneal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test release-notes_istio

integ-ipv6_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-ipv6_istio

integ-distroless_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Kmoneal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test release-notes_istio

integ-ipv6_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-ipv6_istio

integ-distroless_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-istiodremote-mc_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Kmoneal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test release-notes_istio

integ-ipv6_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-ipv6_istio

integ-distroless_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-istiodremote-mc_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Kmoneal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test release-notes_istio

integ-ipv6_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-ipv6_istio

integ-distroless_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-istiodremote-mc_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot_istio

integ-pilot-multicluster_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Kmoneal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test release-notes_istio

integ-ipv6_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-ipv6_istio

integ-distroless_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-istiodremote-mc_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot_istio

integ-pilot-multicluster_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-pilot-multicluster_istio

integ-cni_istio
92db738074006704a171bbe64360d958956fd990
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[X] Add VERIFY_CERTIFICATE_AT_CLIENT as an opt-in environment variable
[ ] Added logging to warn users of proxies that are not verifying host certificates
[ ] Make VERIFY_CERTIFICATE_AT_CLIENT an opt-out environment variable
[ ] Add Metrics to warn of connections to external sites that lack caCertificates
[ ] Add Analyzer to warn of external hosts being connected to without certificate verification

We don't have the metrics. Is there value in adding metrics? Do we know if users will benefit from metrics?

Hello @Kmoneal @jacob-delgado  ,  will you be able to list down the changes needed at the integration test level to get this working? I remember you had mentioned this to me sometime back, but I have lost it. Better to add it here for tracking?

This is covered by https://github.com/istio/istio/pull/48225


bind IOErrorEnum

Are some variants of the enum only available on some platforms? I can't remember
Otherwise looks good to me

Strange travis error. I restarted the build.

@sdroege There's no #if guards around any of the values in the gio C headers so I think the values are available everywhere however they may not exactly be used everywhere but that's not our problem :)

LGFM

Thanks!


[suggestion] Frank 'n' Zombie golem

it would work similar to the killer Joe but it would be a whole mob instead of just a head.
it would look like the killer Joe on a body made of soularium and dark steel with 2 additional tanks on the back. it would work off nutrient distillation but might have upgrades/tools that require RF. the wireless charger would work on these.
you can set it to patrol on certain paths and attack specific mobs. like the dark steel armor it can be upgraded but is upgraded as a whole instead of individual parts. it can also be enchanted. it should be able to collect xp.
it comes with a recharge pad that acts as a home point and will automatically go there when low on nutrient. since it has armor built in, it can't wear armor. player heads can be used to change how the head inside the main tank looks. to bring it to life in the first place it requires a lightning strike(weather obelisk).
it requires nutrient for moving and attacking.

Thank you for your suggestion, but we manage suggestions on http://ideas.theideawall.com/EnderIO
This ticket will be closed because we want the list of open tickets to reflect known issues.


Audit gem depencies of SDK and remove unnecessary ones

Consider removing timeliness from the SDK dependencies

Done, all redundant dependencies are removed at PRs:
https://github.com/Azure/autorest/pull/310
https://github.com/Azure/azure-sdk-for-ruby/pull/257


cannot boot 1.9.0 image on RPI 1

I see the description that 1.9.0 release works on all Raspberry Pi models (1, 2, 3, 3 B+, Zero, Zero W & Compute Module) as the Docker Engine 18.04.0-ce is built for ARMv6
My Raspberry PI was bought in 2014, maybe it's RPI 1.
Anyway, after the image flashed into the SD card, it can not boot. The board never light on except the power. I tried to give it HDMI output, but nothing happens.
Here is the user-data I used:
#cloud-config
hostname: rasp512
manage_etc_hosts: true
users:
- name: peter
gecos: "Peter SONG"
sudo: ALL=(ALL) NOPASSWD:ALL
shell: /bin/bash
groups: users,docker,video,input
plain_text_passwd: xxxxxxxx
lock_passwd: false
ssh_pwauth: true
chpasswd: { expire: false }
locale: "zh_CN.UTF-8"
timezone: "Asia/Shanghai"
package_update: false
package_upgrade: false
write_files:
- content: |
{
"registry-mirrors": ["https://registry.docker-cn.com"]
}
path: /etc/docker/daemon.json
runcmd:
- systemctl restart avahi-daemon
- systemctl restart docker

Hey @eyakcn
I tried your cloud-init yml file and flashed a 1.9.0 SD image and booted a Raspberry Pi 1 from 2012.
On HDMI output you should see the resize filesystem dialog, then the pi reboots and logs its boot steps and cloud-init steps.
As you cannot see anything please check if you have flashed the SD image correctly.
There should be a FAT partition after flashing it and that partition is visible on a Windows or Mac computer.
You can also check you cloud-init file which is a YAML and sometimes hard to get the indenation right.
On my Mac I could use this line to verify the YML file.
ruby -e "require 'yaml';YAML.load_file('./issue258.yml'); puts 'YAML is ok'"

or use an online yaml validator https://coreos.com/validate/
The correct indented cloud-init file that works for me is:
#cloud-config

hostname: rasp512
manage_etc_hosts: true

users:
  - name: peter
    gecos: "Peter SONG"
    sudo: ALL=(ALL) NOPASSWD:ALL
    shell: /bin/bash
    groups: users,docker,video,input
    plain_text_passwd: xxxxxxxxxx
    lock_passwd: false
    ssh_pwauth: true
    chpasswd: { expire: false }

locale: "zh_CN.UTF-8"

timezone: "Asia/Shanghai"

package_update: false
package_upgrade: false

write_files:
  - content: |
      {
      "registry-mirrors": ["https://registry.docker-cn.com"]
      }
    path: /etc/docker/daemon.json

runcmd:
  - 'systemctl restart avahi-daemon'
  - 'systemctl restart docker'

This can be closed, I guess.

Closing due to inactivity


There might be something different between codes and paper

In the paper, it's mentioned that "Perspective Transformer is used in coarse-level lane detection to extract the dense BEV features and detect coarse 3D lanes at the lowest resolution." But in the codes, the "projs = self.pers_tr(input, frontview_features, _M_inv)" , and the projs have the four different levels of resolution of BEV features, so the training parameters does not decrease a lot.
Maybe I  misunderstood, Could you have some explanation?

We use the variable 'use_all_fea'  to control the generation of BEV features in the code of PerspectiveTransformer, as shown in https://github.com/YaoChengTang/Sparse-Point-Guided-3D-Lane-Detection/blob/be90159f66936d29e330e680aed834c0fec81800/models/ImplicitLane.py#L104 and https://github.com/YaoChengTang/Sparse-Point-Guided-3D-Lane-Detection/blob/be90159f66936d29e330e680aed834c0fec81800/models/PersFormer.py#L68.

thank for quick reply！


Add loopkill command

Kill players on a loop with loopkill command.
Resolves kohls-admin/kohls-admin#106

Could you move this into the Moderator DefaultCommands group next to the kill command, instead of an Addon?

Moved it 👍


Adding T2 Systems as a user

Added T2 Systems as a Marathon user.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

retest this please

retest this please

Thanks!


ADDED A PROGRAM OF LEADERS IN AN ARRAY

Description
Description
Given an integer array X[] of size n, write a program to find all the leaders in the array X[]. An element is a leader if it is strictly greater than all the elements to its right side.
PRs #1024
#1023
Domain
Data Structure
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

#1024
#1023
please take a look at my PRs
I had followed  guidelines and updated a readme accodingly

/assign


Added rate limits in upgrade

What is the purpose of the change
This adds the rate limits in the v15 upgrade for when https://www.mintscan.io/osmosis/proposals/427 passes.
Brief Changelog

Add rate limits in v15

Testing and Verifying

The upgrade has tests.
TODO: figure out how to make this not break E2E
This should also be tested on a testnet with state export.

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
How is the feature or change documented? (not applicable   /   specification (x/<module>/spec/)  /  Osmosis docs repo   /   not documented)

RIP goimports error. Do you have your editor set to format on save?

RIP goimports error. Do you have your editor set to format on save?

I do, but it doesn't work when I fix conflicts and some other weird situations like that.
@ValarDragon  but!! this is not ready. The E2E tests are passing because I deactivated them after failing to get them to work (rip).
I asked Nicco to test the upgrade with a state export to make sure the issue is with E2E and not with the upgrade

That change makes a lot of sense! I thought that was just initialization. Thanks for the find!

hmm, this is still failing when there contracts exist on v14. I'll try to test this again tomorrow on a real node and see what happens

Latest updates:

wired ibc-rate-limit as SDK module to have init and export genesis logic
changed querier to be code-gen compatible and fixed CLI
fixed bug with not getting params correctly due to not having a pointer receiver on ParamSetPairs: https://github.com/osmosis-labs/osmosis/blob/af89301de5270d9bb3f4b6e39c12d407ca331270/x/ibc-rate-limit/types/params.go#L44
fixed bug with overriding contract parameter due to ibc-rate-limit consensus version being set to 1, leading to overwrite during the upgrade. Fixed with: https://github.com/osmosis-labs/osmosis/blob/af89301de5270d9bb3f4b6e39c12d407ca331270/app/upgrades/v15/upgrades.go#L56

We manually checked the presence of the contract parameter and rate limits post-upgrade. However, we should add a test in e2e_test.go doing that for us. I think this is the only remaining TODO here


Add Docs for First Class Modules

First Class Modules were not documented in Reason so far, mostly on purpose to not overwhelm early adopters of the language, and due to fear that ppl will go crazy with abstractions when learning these concepts.
Let's propose to create a document in the Reason Manual within an "Advanced" section, explaining the concepts of FCM (also the acronym):

How do you write / use FCMs
When are they useful?
When NOT to use them / offer alternative patterns
Hint on performance / readability / generated output implications in JS (only use them when really needed, good hints on API building practise)

Examples should be less abstract, no single letter placeholders, no Mathematical patterns, in best cases UI related.
Related to #145

I don't know of significant performance/generated-readability issues (other than what's already present in Functors, which are already documented on the Module page).
For context, here's a code sample I put together to look into the generated JS.
Basically, in the example, you can call Array.containsBy(eqFn, value, array) or you can call Array.contains((module SomeModule), value, array);. The JS output in the second case just passes in {eq: SomeModule.eq} instead of passing in a plain function.
This probably isn't a great example for demonstrating why you'd want this (and the obvious alternative in this case is "pass in exactly what you need to the function instead of packaging things up in a module"), but it highlights that the output JS for packing and unpacking modules isn't any worse than using a record to pass a collection of values/functions.

@mlms13 Yeah, if I recall correctly, there was some kind of documentation (or perhaps someone's blog post) about why Belt insists on using FCM's for Set & Map. But it's not immediately obvious to newcomers.

I would, however, say it takes more thought to pack/unpack a module in many cases. There is a particular set of conventions people use which tends to work well, e.g. specifying very limited module signatures in the function argument, so many different modules will work with minimal conversion overhead (like renaming functions).
There are a lot of things that we now take for granted, which ultimately boil down to informal conventions.
Another good example is the "type t" pattern for modules oriented around a specific data type. This integrates nicely with most functor designs, which is, in turn, a product of community convention.
These are things that most people end up discovering eventually through trial and error. I suppose they could be called "design patterns." These are arguably just as important to document, IMO.


DNS lookups are very slow

OS X Host:
$ time nslookup smartystreets.com
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53

Non-authoritative answer:
Name:	smartystreets.com
Address: <IP_ADDRESS>
Name:	smartystreets.com
Address: <IP_ADDRESS>

nslookup smartystreets.com  0.00s user 0.02s system 21% cpu 0.101 total

Inside boot2docker VM w/ <IP_ADDRESS> DNS:
$ time nslookup smartystreets.com <IP_ADDRESS>
Server:    <IP_ADDRESS>
Address 1: <IP_ADDRESS> google-public-dns-a.google.com

Name:      smartystreets.com
Address 1: <IP_ADDRESS> li705-163.members.linode.com
Address 2: <IP_ADDRESS> li284-69.members.linode.com
real	0m 0.24s
user	0m 0.00s
sys	0m 0.00s

Inside boot2docker VM w/ default <IP_ADDRESS> DNS:
$ time nslookup smartystreets.com
Server:    <IP_ADDRESS>
Address 1: <IP_ADDRESS>

Name:      smartystreets.com
Address 1: <IP_ADDRESS> li284-69.members.linode.com
Address 2: <IP_ADDRESS> li705-163.members.linode.com
real	0m 5.39s
user	0m 0.00s
sys	0m 0.00s

This is on a just-launched boot2docker VM so it doesn't have a stale network config or anything like that.
EDIT: This is with VirtualBox 4.3.20 r96996 on OS X 10.10.1 and boot2docker 1.3.3.

wow, thats quite alot slower than i'm seeing - though i agree, its not fast


HMC refactor

Closes #267 by performing interpolation using ANTs
Outputs EPI in T1w space instead of the EPI space
Use float32 when applying transforms (turns out they were calculated using float32 anyway)

I'm waiting for @rwblair to run it through the paces and confirm that it indeed fixes #267.

On ds054 style datasets we error out with the following:
Module ConfoundDiscoverer has no input called inputnode.t1_transform
Module ConfoundDiscoverer has no input called inputnode.reference_image

Those two inputs are referenced in base.py, and are not defined in confounds.py

Yeah - the refactor, breaks ds054 (that's why the tests were
commented out). We agreed with @oesteban to not try to adapt the ds054 and
leave it to his fieldmap branch.
Did you check that this PR indeed removes the trend in DVARS?
On Wed, Feb 22, 2017 at 6:22 PM, Ross Blair<EMAIL_ADDRESS>wrote:

On ds054 style datasets we error out with the following:
Module ConfoundDiscoverer has no input called inputnode.t1_transform
Module ConfoundDiscoverer has no input called inputnode.reference_image
Those two inputs are referenced in base.py, and are not defined in
confounds.py
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/fmriprep/pull/370#issuecomment-281871921,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkpyWW1fKxzByNSoWhiG1ghCFS3LUlks5rfO15gaJpZM4MIT-I
.

Its currently being rerun on sub-313 from the beast dataset, will review its output in the morning.


Add PreprocessorIngestor

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f420f52) 99.86% compared to head (f60c54e) 99.87%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   99.86%   99.87%
=======================================
  Files          36       37    +1
  Lines         763      792   +29
  Branches       81       83    +2
=======================================
+ Hits          762      791   +29
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2023-02-10)
Features

best practices (#29) (ca47e02)
build: Dependabot, project file updates (ca47e02)
build: scripts cleanup (ca47e02)
docs: Highlight 11.7 (ca47e02)

Miscellaneous Chores

release 1.0.0 (39333d5)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/dschach/campaign-member-status/releases/tag/v1.0.0 :sunflower:


Support for multi-arch docker images on size badge

:clipboard: Description

![Docker Image Size (latest by date)](https://img.shields.io/docker/image-size/_/mysql/latest)

For example, mysql:latest image supports ["linux/amd64", "linux/arm64/v8"] os/architecture, but looks like I can't choose which one to use in the badge.
Is there any way to specify docker image's platform?
I can see docker version badge is available to select architecture with &arch=.. parameter.

For the docker image size badge, we don't have an arch param and we also don't explicitly make an assumption about architecture. We just report the value of full_size, so if we look at
https://registry.hub.docker.com/v2/repositories/library/mysql/tags/latest
{
  "creator": 7,
  "id": 20021,
  "images": [
    {
      "architecture": "amd64",
      "features": "",
      "variant": null,
      "digest": "sha256:44f98f4dd825a945d2a6a4b7b2f14127b5d07c5aaa07d9d232c2b58936fb76dc",
      "os": "linux",
      "os_features": "",
      "os_version": null,
      "size": 131789857,
      "status": "active",
      "last_pulled": "2022-07-23T14:07:03.54267Z",
      "last_pushed": "2022-07-13T07:05:12.182358Z"
    },
    {
      "architecture": "arm64",
      "features": "",
      "variant": "v8",
      "digest": "sha256:12cf01a51f803d0ad49ee0dbbb3025a6eef3341e24757c2ed8150b6654c3fb07",
      "os": "linux",
      "os_features": "",
      "os_version": null,
      "size": 138716495,
      "status": "active",
      "last_pulled": "2022-07-23T08:20:42.387497Z",
      "last_pushed": "2022-07-13T08:05:31.345335Z"
    }
  ],
  "last_updated": "2022-07-13T08:05:52.466381Z",
  "last_updater": 1156886,
  "last_updater_username": "doijanky",
  "name": "latest",
  "repository": 21179,
  "full_size": 131789857,
  "v2": true,
  "tag_status": "active",
  "tag_last_pulled": "2022-07-23T14:07:03.54267Z",
  "tag_last_pushed": "2022-07-13T08:05:52.466381Z"
}

It looks like full_size in this case is the size of the amd64 image, but I'm not 100% sure what the rule is for how the API decides which image size to report there.
I think it would be reasonable to add an arch param to this endpoint, but if it is not specified, we just report the value of full_size (deferring to the DockerHub API's rules for deciding which image is the "default") if it is not specified.

I would like to work on this :)

Cool - the post above should contain all the info. You can also have a look at the docker versions badge for some pointers (although this one should be a bit more straightforward!)


Dataview Update

This PR addresses an issue whereby if a layer has dataviews but they are all unchecked, ie not turn on. The dv.update() fails with update is not a function.
This PR simply checks and updates only dataviews that are display true - ie turned on.

Pushed commit to remove console log


Error resending user invitation

I clicked 'Resend user invite' for a user and received the 'Sorry an error occurred' message. The logs showed this:
{\"errors\":[{\"error\":\"BadRequestError\",\"message\":\"Missing personalisation: location\"}],\"status_code\":400}

Fixed in #111


refactor(app): removed unused code from useModuleOverflowMenu

DO NOT MERGE until after beta beta has merged
closes RAUT-154
Overview
This removes the unused disabledReason key in the MenuItemsByModuleType type that is being used in the ModuleOverflowMenu and the useModuleOverflowMenu hook. Additionally, this removes the unused tooltip in ModuleOverflowMenu, subsequently removing the usage of i18n in the component.
I originally thought this would be a large refactor because I thought I had to change the tests but the tests weren't thorough enough to test this unused code. So the tests remained the same.
Changelog

remove unused code from useModuleOverflowMenu and ModuleOverflowMenu

Review requests

smoke test the functionality (particularly when the buttons are disabled when run is in different states, etc) for all the module overflow menus. Buttons should be disabled when expected.

Risk assessment
low

Closing this since it should be targeting edge instead.


[MRG] Fix random forest regressor

Hello @holgern! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file skopt/learning/tests/test_forest.py:

Line 40:80: E501 line too long (80 > 79 characters)
Line 50:80: E501 line too long (80 > 79 characters)


[BUG] Is the wait_for option among the refresh options of Delete by query supported?

Describe the bug
An error occurs if refesh=wait_for is set when requesting Delete by query.
Related component
Search
To Reproduce

When requesting Delete by query, set refesh=wait_for. (ex: test_index/_delete_by_query?refresh=wait_for)
Check if an error occurs.

{
    "error": {
        "root_cause": [
            {
                "type": "illegal_argument_exception",
                "reason": "Failed to parse value [wait_for] as only [true] or [false] are allowed."
            }
        ],
        "type": "illegal_argument_exception",
        "reason": "Failed to parse value [wait_for] as only [true] or [false] are allowed."
    },
    "status": 400
}

Expected behavior
The document for the refresh option of Delete by query(https://opensearch.org/docs/2.12/api-reference/document-apis/delete-by-query/) must be modified or wait_for must be supported.
Additional Details
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

[Triage - attendees 1 2 3 4 5 6]
@bcc829 Thanks for filing. It does indeed look like a problem here.

Hello @andrross
I have been looking into this issue. I was playing with the available url parameters. Please look at my findings and let me know if my thought process is in the right direction.
The below query failed
curl -XPOST "http://localhost:9200/sample-index1/_delete_by_query?refresh=wait_for" -H 'Content-Type: application/json' -d' {   "query": {     "match": {       "movie-length": "124"     }   } }'
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"Failed to parse value [wait_for] as only [true] or [false] are allowed."}],"type":"illegal_argument_exception","reason":"Failed to parse value [wait_for] as only [true] or [false] are allowed."},"status":400}
But the below query actually deleted the document.
curl -XPOST "http://localhost:9200/sample-index1/_delete_by_query?refresh=true&wait_for_completion=true" -H 'Content-Type: application/json' -d' {   "query": {     "match": {       "movie-length": "124"     }   } }'
{"took":487,"timed_out":false,"total":1,"deleted":1,"batches":1,"version_conflicts":0,"noops":0,"retries":{"bulk":0,"search":0},"throttled_millis":0,"requests_per_second":-1.0,"throttled_until_millis":0,"failures":[]}
So as per my understanding - refresh takes only boolean values | on top of it for wait_for we need to send another url parameter "wait_for_completion" set to true.


clef support

Introduce musicxml clef element (https://www.w3.org/2021/06/musicxml40/musicxml-reference/elements/clef/)

Hi @soumas , thanks for your contributing. Could you please add some test cases to verify the correctness of this.

Hi @thaihuynhxyz, thank you for the merge!
I saw that you have already implemented tests. Does this solve your suggestion or would you like me to add more tests?

I think it is OK right now.
I see the lib is missing a lot of elements from Music XML 4.0. I'll update it soon.


Use https://github.com/Kotlin/kotlinx-datetime in shared code

Parse fixture time using https://github.com/Kotlin/kotlinx-datetime and then show localized time in UI

addressed by https://github.com/joreilly/FantasyPremierLeague/commit/e70fd3b2a517ec6d7209b57fc08bd8effd7c6eb0


Wagyu build fails

Hi @howardwu,
When trying to run cargo install wagyu I'm hit with the following:
    Updating crates.io index
  Downloaded wagyu v0.6.3
  Downloaded 1 crate (48.9 KB) in 0.48s
  Installing wagyu v0.6.3
error: failed to compile `wagyu v0.6.3`, intermediate artifacts can be found at `/run/user/1000/cargo-installoftX6F`

Caused by:
  failed to select a version for the requirement `aes = "^0.2"`
  candidate versions found which didn't match: 0.8.2, 0.8.1, 0.8.0, ...
  location searched: crates.io index
  required by package `wagyu-zcash v0.6.3`
      ... which satisfies dependency `wagyu-zcash = "^0.6.3"` of package `wagyu v0.6.3`

Not sure if I'm doing something wrong or the app needs some update.

Was happening for me too. Opted to follow the "build from source" instructions, which is only a few commands more and works just fine

still reporting back as a failed build, even from source.

Thanks Dylan for reporting this, it looks like we need to bump this up. If anyone is open to bumping versions and updating interfaces, I'd be happy to take a look at it.


FH-4208 Walkthrough of Mobile CI/CD with MCP

@david-martin Could you take a look?

@david-martin Fixed the typo


Add the content of AI summary to the i18n configuration file, and include a typing effect

Description
Add the content of AI summary to the i18n configuration file, and include a typing effect that can be displayed immediately upon clicking.
添加AI摘要的i18n配置文件内容，并且添加打字机效果，可点击立即显示。

'excerpt.ai is written in valaxy/packages/valaxy/locales. So we do not need add it for valaxy-theme-yun.
Since the excerpt is pre-generated, I think the typewriter effect is redundant for the display of the summary.


Ex migration

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/federation-and-hybrid/Enable-RemoteMailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/federation-and-hybrid/New-RemoteMailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/federation-and-hybrid/Set-RemoteMailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


change gitea username

Currently, the username for gitea is giteaAdmin. This causes some complications when using it for logging in and utilizing images in the gitea OCI registry. See here: https://github.com/cnoe-io/idpbuilder/pull/302#discussion_r1640460167
To simplify things, we should just rename the username from giteaAdmin to admin and update references and instructions where necessary.
When fixing this, make sure you search for both giteaAdmin and giteaadmin references to fix them.

k logs my-gitea-8674989bbc-xp4cq -c configure-gitea
==== BEGIN GITEA CONFIGURATION ====
2024/06/18 03:49:49 ...2@v2.27.1/command.go:272:Run() [I] PING DATABASE sqlite3
2024/06/18 03:49:49 cmd/migrate.go:33:runMigrate() [I] AppPath: /usr/local/bin/gitea
2024/06/18 03:49:49 cmd/migrate.go:34:runMigrate() [I] AppWorkPath: /data
2024/06/18 03:49:49 cmd/migrate.go:35:runMigrate() [I] Custom path: /data/gitea
2024/06/18 03:49:49 cmd/migrate.go:36:runMigrate() [I] Log path: /data/log
2024/06/18 03:49:49 cmd/migrate.go:37:runMigrate() [I] Configuration file: /data/gitea/conf/app.ini
2024/06/18 03:49:49 ...2@v2.27.1/command.go:272:Run() [W] Table system_setting Column version db default is , struct default is 1
No admin user 'admin' found. Creating now...
Command error: CreateUser: name is reserved [name: admin]

I am not sure how feasible this is with gitea. This was based off a quick look at trying an idpbuilder create after changing the admin username

interesting! yeah. looks like the username cannot come from this reserved list. maybe we call it administrator or root? root might be shorter and easier. kind of a bummer though. would have been nice to have the same username between argocd and gitea. thoughts on calling it root?

Can we move keycloak as core application and let ArgoCD and Gitea use managed accounts similar to other apps? I think when we add deployment to remote cluster support, this workflow will be seemless.

yeah we discussed this in the past. Problem is, we have users who have done integrations with other SSO providers, including Okta, Cognito, etc. Bringing Keycloak into the mix as a core package, makes it confusing if folks choose to enable alternative SSO solutions in other stacks.

root sounds better to me. Shorter and easier to type :)

root sounds better to me. Shorter and easier to type :)

admin is the default standard ;-)

@cmoulliard yeah admin would have been great but it is a reserved word. see this

Let's then use one of the followings: adminuser, gitadmin, supervisor ?

we use gitea_admin if that helps at all.


Missing link

in the section titled "Configuration keys and values" (https://learn.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-6.0#configuration-keys-and-values) on the first list, last bullet where it says "Array binding is described in the Bind an array to a class section," the link for "Bind an array to a class section." (https://learn.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-6.0#boa)  Seems to not be present.  When I click on that link (using Brave 1.50.115) nothing happens.  When I copy the link and open it in Edge I see the top of the page, not the referenced section.  Where do I find documentation on how the Configuration API binds arrays of objectss?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0eb4d762-3910-2c57-8741-3306c15537b6
Version Independent ID: ba2254a0-ea8e-9b28-e94b-edd0fc58c043
Content: Configuration in ASP.NET Core
Content Source: aspnetcore/fundamentals/configuration/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

#28994 warns you need to be on the current version for some links to work.

@SkipSailors  fix will be live in 10 minutes. Try it after that.

@tdykstra  fixed by include.

Same behavior.  I will try again tomorrow, to rule out strange cache things.
From: Rick Anderson @.>
Sent: Sunday, April 16, 2023 9:01 PM
To: dotnet/AspNetCore.Docs @.>
Cc: Skip Sailors @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Missing link (Issue #28993)
@tdykstrahttps://github.com/tdykstra fixed by include.
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/28993#issuecomment-1510661045, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADHHRURBRY47EL3SITTM7LXBS6A3ANCNFSM6AAAAAAXAJ5LOM.

Behavior persists.
I see a thing.  The phrase with the href says:
Bind an array to a class
The target anchor

Appears thrice in the page, once at line 1746 and then again at 3313 and again at 3382.  I didn’t do a lot of studying to see if any of those names are in commented sections or something.  If all of these are in active text, I expect my browser can’t really tell where it should go, so doesn’t go anywhere.
From: Rick Anderson @.>
Sent: Monday, April 17, 2023 11:51 AM
To: dotnet/AspNetCore.Docs @.>
Cc: Skip Sailors @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Missing link (Issue #28993)
^F
Go to top of document.
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/28993#issuecomment-1511912760, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADHHRSSBRNCBYWMQMORC7DXBWGJRANCNFSM6AAAAAAXAJ5LOM.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Go to current version.

I see.
ASP.NET 6 will not be corrected.  ASP.NET 8 works.
Thanks.
From: Rick Anderson @.>
Sent: Monday, April 17, 2023 5:29 PM
To: dotnet/AspNetCore.Docs @.>
Cc: Skip Sailors @.>; Mention @.>
Subject: Re: [dotnet/AspNetCore.Docs] Missing link (Issue #28993)
Go to current version.
—
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/AspNetCore.Docs/issues/28993#issuecomment-1512274165, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADHHRXR5FH4IIFKJVVM5LDXBXN25ANCNFSM6AAAAAAXAJ5LOM.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

ASP.NET 6 will not be corrected.  ASP.NET 8 works.

Or 7


The YouTube get_video_info API seems to be dead

The API https://www.youtube.com/get_video_info?video_id=${id}&el=detailpage returns HTTP 404.
Therefore your JSON API https://ytdl.maple3142.net/api?id=${id} always returns "Adblock conflict".

Yes it is. Here is an example to resolve the problem.
https://github.com/snakx/YouTubeApiSharp/commit/e0432b36f7416974548d56f33e27a48576b36e98


Add back SDL_FreeWAV

Add back SDL_FreeWAV
but doesn't compile.
because of SDL_oldnames :
#define SDL_FreeWAV SDL_FreeWAV_renamed_SDL_free
not sure, if we should remove it from SDL3, or change in sdl2-compat

In SDL3, we should probably replace
https://github.com/libsdl-org/SDL/blob/04f2820e073053a15961ec6340a7b741b1c42de5/include/SDL3/SDL_oldnames.h#L365
with e.g.
#elif !defined(SDL_OLD_NAMES_DO_NOTHING)

and do the following in sdl2-compat:
#ifdef SDL_ENABLE_OLD_NAMES
#undef SDL_ENABLE_OLD_NAMES
#endif
#ifndef SDL_OLD_NAMES_DO_NOTHING
#define SDL_OLD_NAMES_DO_NOTHING
#endif

testing it, this looks ok to me

(when building against a previous SDL3 revision..)

merging, since this was tested!


Decision task failure support

Coverage increased (+0.2%) to 66.239% when pulling 57ae7594a0ed62f39abd9f42d9d93466e31d3b60 on samarabbas:decision-task-failure-support into a5875a7e48ba575d0d9056fd4e23f1ac6048115a on uber:master.

Coverage increased (+0.1%) to 66.219% when pulling 2ceae9754e55f88b8a8401d983e1b214eaee009b on samarabbas:decision-task-failure-support into a5875a7e48ba575d0d9056fd4e23f1ac6048115a on uber:master.

Coverage increased (+0.3%) to 66.273% when pulling 68db8b4a043be6be0950ebdf2b62cee9e14c8d91 on samarabbas:decision-task-failure-support into 6b3fcff0074dafa1be8128427d577806f9be8385 on uber:master.


Eliminate remaining uses of g_connman in Dash-specific code.

Just a few days before code freeze comes this change. Here I'm cutting a huge loose end remaining after networking refactoring.
This monstrous change eliminates all remaining uses of g_connman global variable in Dash-specific code.
Unlike previous changes eliminating g_connman use that were isolated to particular modules, this one covers multiple modules simultaneously because they are so interdependent that change in one module was quickly spreading to others.
This is mostly invariant change that was done by

changing all functions using g_connman to use connman argument,
changing all functions calling these functions to use connman argument,
repeating previous step until there's nothing to change.

After multiple iterations, this process converged to final result, producing code that is mostly equivalent to original one, but passing CConnman instance through arguments instead of global variable.
The only exception to equivalence of resulting code is that I had to create overload of CMasternodeMan::CheckAndRemove() method without arguments that does nothing just for use in CFlatDB<CMasternodeMan>::Dump() and CFlatDB<CMasternodeMan>::Load() methods.
Normal CMasternodeMan::CheckAndRemove() overload now has argument of CConnman& type and is used everywhere else.
The normal overload has this code in the beginning:
    if(!masternodeSync.IsMasternodeListSynced()) return;

Masternode list is not synced yet when we load mncache.dat file, and we save mncache.dat file on shutdown, so I presume that it's OK to use overload that does nothing in both cases.
Please review and tell me if this assumption is wrong.

I've pushed updated branch. The only difference is a few typos fixed in commit message.

Build is failing but I can't reproduce the issue locally...

Looks like old compiler that is used in Travis doesn't like new-style class member initialisation. I've pushed updated branch that uses old-style initialisation. I've also rebased it on updated v012.2.x branch.


ForcedChunkEvent shouldn't extend TargetChunkEvent

The ForcedChunkEvent class shouldn't extend the TargetChunkEvent because the Chunk may still be absent/loaded after the event is called. The UnforcedChunkEvent class doesn't extend the class as well.

Closed in bleeding. Thanks!


@document

Tried searching for this on the caniuse website, but didn't get any results at all, so thought I would add it as a suggestion.
(This is in reference to the CSS(3) rule (@ rule)).
Example:
@document url("https://caniuse.com/")
MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/@document

This (sadly) never worked outside Firefox and even there as it seems from newly added note at the MDN page it will stop working outside the userContent.css soon :(

@myfonj Yeah, I know. While it's not something I would personally recommend using, it's kind of a "cool" feature - if it was usable in other browsers as well. But since it doesn't, it's better to juse stick to inlining styles if you need specific CSS rules for that underside(?).
What I do like about it, though, is that you can use regex's for the @document rule. Wish this would be implemented to CSS in general, example: input[name=/(fa-)?(github)/i] or something like that.

Duplicate of #2588


install issues

I just tried to install this on CentOS 7.5, and am having some issues:
# pip3 install netbox-scanner
WARNING: Running pip install with root privileges is generally not a good idea. Try pip3 install --user instead.
Collecting netbox-scanner
Downloading https://files.pythonhosted.org/packages/68/d5/e36874a35694a08bcd14f1b2c10b4ce8e274eb04d470d5a23f4e0782ae4c/netbox-scanner-0.7.2.tar.gz
Installing collected packages: netbox-scanner
Running setup.py install for netbox-scanner ... done
Successfully installed netbox-scanner-0.7.2
[root@simon-test ~]# python nbscanner
python: can't open file 'nbscanner': [Errno 2] No such file or directory
[root@simon-test ~]# find / -name nbscanner
[root@simon-test ~]# find / -name netbox-scanner
/usr/local/lib/python3.6/site-packages/netbox-scanner
[root@simon-test ~]# cd /usr/local/lib/python3.6/site-packages/netbox-scanner
[root@simon-test netbox-scanner]# ls -al
total 28
drwxr-xr-x.   3 root root   78 Jan  6 15:41 .
drwxr-xr-x. 127 root root 8192 Jan  6 15:41 ..
-rw-r--r--.   1 root root 1053 Oct 29  2018 dac.py
-rw-r--r--.   1 root root    0 Oct 29  2018 _init.py
-rw-r--r--.   1 root root 9271 Oct 29  2018 nbscanner.py
drwxr-xr-x.   2 root root   95 Jan  6 15:41 _pycache_
[root@simon-test netbox-scanner]# python ./nbscanner.py
File "./nbscanner.py", line 195
parsing = self.parser([f'{h[0]}/32' for h in hosts])
^
SyntaxError: invalid syntax_
OK, maybe something wrong with the pip version, let's try manually installing..
# wget https://github.com/forkd/netbox-scanner/archive/master.zip
--2020-01-06 15:50:30--  https://github.com/forkd/netbox-scanner/archive/master.zip
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/forkd/netbox-scanner/zip/master [following]
--2020-01-06 15:50:30--  https://codeload.github.com/forkd/netbox-scanner/zip/master
Resolving codeload.github.com (codeload.github.com)... <IP_ADDRESS>
Connecting to codeload.github.com (codeload.github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/zip]
Saving to: ‘master.zip’
[ <=>                                                                                ] 9,054       --.-K/s   in 0.02s

2020-01-06 15:50:30 (398 KB/s) - ‘master.zip’ saved [9054]
[root@simon-test ~]# unzip netbox-scanner-master.zip -d netbox-scanner
unzip:  cannot find or open netbox-scanner-master.zip, netbox-scanner-master.zip.zip or netbox-scanner-master.zip.ZIP.
[root@simon-test ~]# unzip master.zip -d netbox-scanner
Archive:  master.zip
02d573d4fa0b85f20ea24b706feb169c181bfe09
creating: netbox-scanner/netbox-scanner-master/
inflating: netbox-scanner/netbox-scanner-master/.gitignore
inflating: netbox-scanner/netbox-scanner-master/LICENSE
inflating: netbox-scanner/netbox-scanner-master/README.md
creating: netbox-scanner/netbox-scanner-master/netbox-scanner/
extracting: netbox-scanner/netbox-scanner-master/netbox-scanner/init.py
inflating: netbox-scanner/netbox-scanner-master/netbox-scanner/dac.py
inflating: netbox-scanner/netbox-scanner-master/netbox-scanner/nbscanner
inflating: netbox-scanner/netbox-scanner-master/netbox-scanner/nbscanner.py
inflating: netbox-scanner/netbox-scanner-master/requirements.txt
inflating: netbox-scanner/netbox-scanner-master/setup.py
[root@simon-test ~]# cd netbox-scanner
[root@simon-test netbox-scanner]# pip install -r requirements.txt
WARNING: Running pip install with root privileges is generally not a good idea. Try pip install --user instead.
Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt'
[root@simon-test netbox-scanner]# cd netbox-scanner-master
[root@simon-test netbox-scanner-master]# pip install -r requirements.txt
WARNING: Running pip install with root privileges is generally not a good idea. Try pip install --user instead.
Collecting asn1crypto==0.24.0 (from -r requirements.txt (line 1))
Using cached https://files.pythonhosted.org/packages/ea/cd/35485615f45f30a510576f1a56d1e0a7ad7bd8ab5ed7cdc600ef7cd06222/asn1crypto-0.24.0-py2.py3-none-any.whl
Collecting bcrypt==3.1.6 (from -r requirements.txt (line 2))
Downloading https://files.pythonhosted.org/packages/d0/79/79a4d167a31cc206117d9b396926615fa9c1fdbd52017bcced80937ac501/bcrypt-3.1.6-cp34-abi3-manylinux1_x86_64.whl (55kB)
100% |████████████████████████████████| 61kB 2.9MB/s
Collecting certifi==2019.3.9 (from -r requirements.txt (line 3))
Downloading https://files.pythonhosted.org/packages/60/75/f692a584e85b7eaba0e03827b3d51f45f571c2e793dd731e598828d380aa/certifi-2019.3.9-py2.py3-none-any.whl (158kB)
100% |████████████████████████████████| 163kB 3.6MB/s
Collecting cffi==1.12.2 (from -r requirements.txt (line 4))
Downloading https://files.pythonhosted.org/packages/20/f7/87b62a8895bf7c93e907b05b97bc4459c81a38a61151f03a6eae13d863aa/cffi-1.12.2-cp36-cp36m-manylinux1_x86_64.whl (428kB)
100% |████████████████████████████████| 430kB 2.3MB/s
Requirement already satisfied: chardet==3.0.4 in /usr/lib/python3.6/site-packages (from -r requirements.txt (line 5))
Collecting cpe==1.2.1 (from -r requirements.txt (line 6))
Downloading https://files.pythonhosted.org/packages/cd/8a/1dc2644a1fe6049cff29accd1d5830ef2b51b8c71b95b187a59f884777c7/cpe-1.2.1.tar.gz (2.2MB)
100% |████████████████████████████████| 2.2MB 635kB/s
Collecting cryptography==2.6.1 (from -r requirements.txt (line 7))
Downloading https://files.pythonhosted.org/packages/5b/12/b0409a94dad366d98a8eee2a77678c7a73aafd8c0e4b835abea634ea3896/cryptography-2.6.1-cp34-abi3-manylinux1_x86_64.whl (2.3MB)
100% |████████████████████████████████| 2.3MB 592kB/s
Collecting idna==2.8 (from -r requirements.txt (line 8))
Downloading https://files.pythonhosted.org/packages/14/2c/cd551d81dbe15200be1cf41cd03869a46fe7226e7450af7a6545bfc474c9/idna-2.8-py2.py3-none-any.whl (58kB)
100% |████████████████████████████████| 61kB 2.9MB/s
Collecting paramiko==2.4.2 (from -r requirements.txt (line 9))
Downloading https://files.pythonhosted.org/packages/cf/ae/94e70d49044ccc234bfdba20114fa947d7ba6eb68a2e452d89b920e62227/paramiko-2.4.2-py2.py3-none-any.whl (193kB)
100% |████████████████████████████████| 194kB 4.2MB/s
Collecting pyasn1==0.4.5 (from -r requirements.txt (line 10))
Downloading https://files.pythonhosted.org/packages/7b/7c/c9386b82a25115cccf1903441bba3cbadcfae7b678a20167347fa8ded34c/pyasn1-0.4.5-py2.py3-none-any.whl (73kB)
100% |████████████████████████████████| 81kB 8.4MB/s
Requirement already satisfied: pycparser==2.19 in /usr/local/lib/python3.6/site-packages (from -r requirements.txt (line 11))
Requirement already satisfied: PyNaCl==1.3.0 in /usr/local/lib64/python3.6/site-packages (from -r requirements.txt (line 12))
Collecting pynetbox==4.0.6 (from -r requirements.txt (line 13))
Downloading https://files.pythonhosted.org/packages/08/72/261842773f7f6a66379473eb76dd651117dcfaed0c1c15f4ee4e14b3d5f3/pynetbox-4.0.6.tar.gz (44kB)
100% |████████████████████████████████| 51kB 9.8MB/s
Collecting python-nmap==0.6.1 (from -r requirements.txt (line 14))
Downloading https://files.pythonhosted.org/packages/dc/f2/9e1a2953d4d824e183ac033e3d223055e40e695fa6db2cb3e94a864eaa84/python-nmap-0.6.1.tar.gz (41kB)
100% |████████████████████████████████| 51kB 8.8MB/s
Collecting requests==2.21.0 (from -r requirements.txt (line 15))
Downloading https://files.pythonhosted.org/packages/7d/e3/20f3d364d6c8e5d2353c72a67778eb189176f08e873c9900e10c0287b84b/requests-2.21.0-py2.py3-none-any.whl (57kB)
100% |████████████████████████████████| 61kB 8.5MB/s
Collecting six==1.12.0 (from -r requirements.txt (line 16))
Downloading https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Requirement already satisfied: urllib3==1.24.1 in /usr/lib/python3.6/site-packages (from -r requirements.txt (line 17))
Installing collected packages: asn1crypto, cffi, six, bcrypt, certifi, cpe, cryptography, idna, pyasn1, paramiko, requests, pynetbox, python-nmap
Found existing installation: cffi 1.13.2
Uninstalling cffi-1.13.2:
Successfully uninstalled cffi-1.13.2
Found existing installation: six 1.13.0
Uninstalling six-1.13.0:
Successfully uninstalled six-1.13.0
Found existing installation: bcrypt 3.1.7
Uninstalling bcrypt-3.1.7:
Successfully uninstalled bcrypt-3.1.7
Running setup.py install for cpe ... done
Found existing installation: cryptography 2.8
Uninstalling cryptography-2.8:
Successfully uninstalled cryptography-2.8
Found existing installation: pyasn1 0.4.8
Uninstalling pyasn1-0.4.8:
Successfully uninstalled pyasn1-0.4.8
Found existing installation: paramiko 2.6.0
Uninstalling paramiko-2.6.0:
Successfully uninstalled paramiko-2.6.0
Running setup.py install for pynetbox ... done
Running setup.py install for python-nmap ... done
Successfully installed asn1crypto-0.24.0 bcrypt-3.1.6 certifi-2019.3.9 cffi-1.12.2 cpe-1.2.1 cryptography-2.6.1 idna-2.8 paramiko-2.4.2 pyasn1-0.4.5 pynetbox-4.0.6 python-nmap-0.6.1 requests-2.21.0 six-1.12.0
[root@simon-test netbox-scanner-master]# ls
LICENSE  netbox-scanner  README.md  requirements.txt  setup.py
[root@simon-test netbox-scanner-master]# ls -al
total 20
drwxr-xr-x. 3 root root  118 May 14  2019 .
drwxr-xr-x. 3 root root   35 Jan  6 15:50 ..
-rw-r--r--. 1 root root 1203 May 14  2019 .gitignore
-rw-r--r--. 1 root root 1068 May 14  2019 LICENSE
drwxr-xr-x. 2 root root   76 May 14  2019 netbox-scanner
-rw-r--r--. 1 root root 2815 May 14  2019 README.md
-rw-r--r--. 1 root root  277 May 14  2019 requirements.txt
-rw-r--r--. 1 root root  657 May 14  2019 setup.py
[root@simon-test netbox-scanner-master]# cd netbox-scanner/
[root@simon-test netbox-scanner]# ls
dac.py init.py  nbscanner  nbscanner.py
[root@simon-test netbox-scanner]#
[root@simon-test netbox-scanner]# cd ..
[root@simon-test netbox-scanner-master]# python netbox-scanner/nbscanner
Traceback (most recent call last):
File "netbox-scanner/nbscanner", line 5, in
from configparser import ConfigParser
ImportError: No module named configparser
[root@simon-test netbox-scanner-master]# ls
LICENSE  netbox-scanner  README.md  requirements.txt  setup.py
[root@simon-test netbox-scanner-master]# python ./setup.py
File "./setup.py", line 11
SyntaxError: Non-ASCII character '\xc3' in file ./setup.py on line 11, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details
So I'm lost at this point. I don't know how to configure or run this.

Ah, the issue with the setup script is the accented e character in your name, I removed that and the setup runs, but doesn't help.
python ./setup.py
SyntaxError: Non-ASCII character '\xc3' in file ./setup.py on line 11, but no encoding declared; see http://www.python.org/peps/pep-0263.html for details
[root@simon-test netbox-scanner-master]# vi setup.py
[root@simon-test netbox-scanner-master]# python ./setup.py
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help
error: no commands supplied

@squigley I had the same issue using the pip module. remove it with pip3 uninstall python-nmap and install it manually from the release tarball https://xael.org/pages/python-nmap-en.html - that made it work for me.

This module will discontinued in the new version and overall script will be simplified focusing on the standar library, see #18 .


RipME doesn't rip from vk yet it says it did (v1.7.44)

Ripme version: v1.7.44
Java version: openjdk <IP_ADDRESS>
Operating system:  Ubuntu 16.04.3
Exact URL you were trying to rip when the problem occurred: any vk photo album

Expected Behavior
Album is downloaded correctly.
Actual Behavior
First of all I would like to point out that ripme expects the format to be https://vk.com/album#### or vk.com/photos#### however when you click on an album the format you get is https://vk.com/USERID?z=albums#### so one has to manually edit out userid.. Which I think was already reported in #252. Anyway what happens is that ripme throws "ripcomplete", however there is no trace of said folder in the rips folder and if I check "history" the number of photos is "0". So it clearly didn't rip.

Bump?Still happens with v1.7.51


System.Format Exception when opening the CPU view on on a Linux Trace

I'm getting the System.Format exception when trying to load .net core 2.1 trace from Linux. Using latest PerfView (2.0.46)
Shared trace at https://drive.google.com/open?id=1z-WOW_jjoOz_a7GKEjgHrbQFluSA0lfQ
Completed: Opening CPU Stacks (Elapsed Time: 115.629 sec)
Exception Occurred: System.AggregateException: One or more errors occurred. ---> System.FormatException: Input string was not in a correct format.
at System.Number.ParseDouble(String value, NumberStyles options, NumberFormatInfo numfmt)
at Diagnostics.Tracing.StackSources.LinuxPerfScriptEventParser.d__30.MoveNext()
at Diagnostics.Tracing.StackSources.LinuxPerfScriptEventParser.d__9.MoveNext()
at Diagnostics.Tracing.StackSources.ParallelLinuxPerfScriptStackSource.<>c__DisplayClass1_1.b__0(Object givenArrayIndex)
at System.Threading.Tasks.Task.Execute()

I have the same issue. .netcore 2.2.8 in kubernetes linux pod. perfview version is 2.0.55.

Same error on 2.0.58 from a 3.1.7 trace from a k8s pod.

Started: Opening CPU Stacks
Completed: Opening CPU Stacks   (Elapsed Time: 0.702 sec)
Exception Occurred: System.FormatException: Input string was not in a correct format.
at System.Number.ParseDouble(String value, NumberStyles options, NumberFormatInfo numfmt)
at Microsoft.Diagnostics.Tracing.StackSources.LinuxPerfScriptEventParser.d__30.MoveNext()
at Microsoft.Diagnostics.Tracing.StackSources.LinuxPerfScriptEventParser.d__9.MoveNext()
at Microsoft.Diagnostics.Tracing.StackSources.LinuxPerfScriptStackSource.DoInterning()
at Microsoft.Diagnostics.Tracing.StackSources.LinuxPerfScriptStackSource.InternAllLinuxEvents(Stream stream)
at Microsoft.Diagnostics.Tracing.StackSources.LinuxPerfScriptStackSource..ctor(String path, Boolean doThreadTime)
at PerfView.LinuxPerfViewData.OpenStackSourceImpl(String streamName, TextWriter log, Double startRelativeMSec, Double endRelativeMSec, Predicate1 predicate) in C:\A\_work\68\s\src\PerfView\PerfViewData.cs:line 8404    at PerfView.PerfViewStackSource.OpenStackSource(String streamName, TextWriter log, Double startRelativeMSec, Double endRelativeMSec, Predicate1 predicate) in C:\A_work\68\s\src\PerfView\PerfViewData.cs:line 3890
at PerfView.PerfViewStackSource.<>c__DisplayClass23_0.b__0() in C:\A_work\68\s\src\PerfView\PerfViewData.cs:line 3914
at PerfView.StatusBar.<>c__DisplayClass22_0.b__0() in C:\A_work\68\s\src\PerfView\GuiUtilities\StatusBar\StatusBar.xaml.cs:line 254
An exceptional condition occurred, see log for details.

This has been fixed in master, with #1244.  It will be included in the next release.


hardware?

Suggest fill in some details on hardware interfacing?
How do you get at the canbus?
What chipset are you using?
etc

https://github.com/UKSFM99/W203-canbus/blob/master/setup.png -> Setup diagram for breadboard
I'm using the sparkfun canbus shield v1.2 to read canbus.
In regards to wiring, I have ran some wires from underneath the drivers steering wheel area under the center console and up into the center console bin (which took about 3 hours to do). From there I simply plug the canbus shield into the wires and everything is ready. Hope this helps

Thank you, yes, helpful!
I'll see if i can find some details on the wiring on the car side, may be an easier way to get at the bus.  Is it exposed on the OBDII port, or did you cut in elsewhere?
I will need to dig into my W209 docs..

unfortunately no. canbus B is not exposed from odb2. I'm assuming you have a w203 as well. in which case if you take the panel off where the odb2 connector is connected to (the entire black panel with 3 screws at the front), you should be able to see the hub for canB

I have a C219/W219  (CLS350 2006 model) - COMAND APS NTG1, with a MOST bus.
W203 also used the same hardware I think, so should be comparable if not the same.
Mine is the Harman Kardon one, so a little more painful!
NTG1 + CD Changer with the DVD in the back for maps.

so yeah should be the same then. hopefully if you follow my hardware setup I can have another tester :D


Can't run example.py (model.evaluate_states getting None states)

I cloned the repo and installed requirements.txt
After configuring my API key, example.py seems to run just fine up to a certain point as seen in the output of the last loop quoted below.
When calling tree_of_thoughts.solve, however, we get a list with three None states, which causes the script to crash at this line
before it can complete the Monte Carlo search.
The error traceback is appended at the end.
Have I missed any steps here?
This bug happened when using the default 24 game prompt provided.
I have tried other GPT models and different initial prompts with no luck.
Exact same problem with huggingface_example.py, so it should be easy to reproduce...
Has anyone seen this before?
Output

Initializing Autonomous Agent tree_of_thoughts...
Autonomous Agent Activated.
All systems operational. Executing task...
Loop 1 of 1
Observation: The goal is to obtain a result of 24 using each of the four numbers provided (2, 8, 8, 14) exactly once and using basic arithmetic operations (+, -, *, /).
Thoughts: To achieve 24, I must consider combinations that can multiply or add up to 24 or its multiples/divisors. The number 14 stands out as it is the largest and can be used with other smaller numbers to adjust the final result towards 24. Because division by 2 yields a whole number when applied to both 14 and 8, and multiplication with 8 can reach close to 24, these operations are particularly promising.
Let's try multiplying the largest numbers and then see if we can adjust the result with the remaining numbers:
14 * 2 = 28 (Now we need to subtract 4 to get to 24, and we have two eights left)
Option 1:
14 * 2 = 28
8 / 8 = 1
28 - 1 = 27 (This is too high and does not use all numbers effectively).
Option 2:
From here, we realize that if we divide 8 by 8, we get 1 which can be subtracted from 28 to get to 27. We need to think of a way to subtract just enough to reach 24.
Continuing to explore our options, let's consider using the two 8's together, as their product is close to 24.
8 / 8 = 1 (Now we have 1, 2, and 14 left to reach 24)
14 + 1 = 15
2 + 15 = 17 (This is still not 24)
However, if we multiply 8 by 3, we can get 24. We can obtain 3 by adding 2 and 1. So:
8 * (2 + 1) = 24
We get:
8 * 3 = 24
And 3 can be obtained from 8/8 + 2.
Finally, find the arrangement that meets the requirements of the task.
Solution:
(8 / 8) + 2 = 3
8 * 3 = 24
Final Equation: 8 * ((8 / 8) + 2) = 24

Error:
Traceback (most recent call last):
  File "C:\Users\theo_\coding_workspace\gpt_tree_of_thoughts\tree-of-thoughts\example.py", line 62, in <module>
    solution = tree_of_thoughts.solve(
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\theo_\coding_workspace\gpt_tree_of_thoughts\tree-of-thoughts\tree_of_thoughts\treeofthoughts.py", line 559, in solve
    return self.monte_carlo_search(
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\theo_\coding_workspace\gpt_tree_of_thoughts\tree-of-thoughts\tree_of_thoughts\treeofthoughts.py", line 608, in monte_carlo_search
    evaluated_thoughts = self.model.evaluate_states(
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\theo_\coding_workspace\gpt_tree_of_thoughts\tree-of-thoughts\tree_of_thoughts\tot_agent.py", line 141, in evaluate_states
    state_text = "\n".join(state)
                 ^^^^^^^^^^^^^^^^
TypeError: can only join an iterable

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

+1

Have you solved this problem?

@TheodoroCardoso @dingdingqiuqiu @alxkolm @twilsonco @yhyu13 hey try again, I have fixed the code and let me know what happens, instructions are in README


Determine a safe location for the combo quick & canvas action menus

Feature Description
Originally reported by @agingoldseco

If scrollbar gets in the way, we should decide on a set spot for the combined quick action and canvas action menus in the corner that looks best

Alternatives Considered

Additional Context

Duplicate of #9808 as that issue should generally improve the UX of the combo menu.


2.16.1 - failed test it-display-plugin-updates-006

Test it-display-plugin-updates-006 has execution
invoker.goals=versions:display-plugin-updates

so the latest release version is used ....
After release new version - test are failing, we need investigate if release doesn't not introduce a new bug

I don't get why they were testing a release version instead of the current snapshot. The test should be testing the current snapshot and not the release version.
I need to verify this, but it looks like the message that is output to the log has changed. If you look at Maven output, you can see that all updates, including the one that there's checked for:
p = Pattern.compile( "maven-deploy-plugin \\.+ 2\\.3 ->" );
    m = p.matcher( buf.toString() );
    if ( !m.find() )
    {
        System.out.println( "cannot find update of deploy plugin");
        return false;
    }

are actually there, so the test should pass. I think the string announcing the updates has changed (not sure) and that's why it's now failing. See: https://github.com/mojohaus/versions/actions/runs/6240751197/job/16952395061
[INFO] All plugins with a version specified are using the latest versions.
[INFO]
Warning:  The following plugins do not have their version specified:
Warning:    localhost:dummy-maven-plugin ............................... 3.1
[INFO]
Warning:  Project does not define minimum Maven version required for build
[INFO] Plugins require minimum Maven version of: 3.8.4
[INFO]
Error:  Project does not define required minimum version of Maven.
Error:  Update the pom.xml to contain maven-enforcer-plugin to
Error:  force the Maven version which is needed to build this project.
Error:  See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
Error:  Using the minimum version of Maven: 3.8.4
[INFO]
[INFO] Require Maven 2.0 to use the following plugin updates:
[INFO]   maven-clean-plugin ............................................ 2.2
[INFO]   maven-deploy-plugin .................................... 2.3 -> 2.4
[INFO]   maven-install-plugin .......................................... 2.2
[INFO]
[INFO] Require Maven 2.0.2 to use the following plugin updates:
[INFO]   maven-site-plugin ............................... 2.0 -> 2.0-beta-7
[INFO]
[INFO] Require Maven 2.0.6 to use the following plugin updates:
[INFO]   localhost:dummy-maven-plugin ........................... 3.1 -> 3.0
[INFO]   maven-clean-plugin ..................................... 2.2 -> 2.5
[INFO]   maven-deploy-plugin .................................. 2.3 -> 2.8.1
[INFO]   maven-install-plugin ................................. 2.2 -> 2.5.1
[INFO]   maven-site-plugin .................................... 2.0 -> 2.0.1
[INFO]
[INFO] Require Maven 2.1.0 to use the following plugin updates:
[INFO]   maven-site-plugin .................................... 2.0 -> 2.1.1
[INFO]
[INFO] Require Maven 2.2.0 to use the following plugin updates:
[INFO]   maven-site-plugin ...................................... 2.0 -> 3.0
[INFO]
[INFO] Require Maven 2.2.1 to use the following plugin updates:
[INFO]   maven-clean-plugin ................................... 2.2 -> 2.6.1
[INFO]   maven-deploy-plugin .................................. 2.3 -> 2.8.2
[INFO]   maven-install-plugin ................................. 2.2 -> 2.5.2
[INFO]   maven-site-plugin .................................... 2.0 -> 3.7.1
[INFO]
[INFO] Require Maven 3.0 to use the following plugin updates:
[INFO]   maven-clean-plugin ................................... 2.2 -> 3.1.0
[INFO]   maven-deploy-plugin ............................... 2.3 -> 3.0.0-M2
[INFO]   maven-install-plugin .............................. 2.2 -> 3.0.0-M1
[INFO]   maven-site-plugin .................................... 2.0 -> 3.9.0
[INFO]
[INFO] Require Maven 3.0.5 to use the following plugin updates:
[INFO]   maven-site-plugin ................................... 2.0 -> 3.11.0
[INFO]
[INFO] Require Maven 3.2.5 to use the following plugin updates:
[INFO]   maven-clean-plugin ................................... 2.2 -> 3.3.1
[INFO]   maven-deploy-plugin .................................. 2.3 -> 3.1.1
[INFO]   maven-install-plugin ................................. 2.2 -> 3.1.1
[INFO]   maven-site-plugin ................................. 2.0 -> 4.0.0-M9
[INFO]
[INFO] Require Maven 3.8.4 to use the following plugin updates:
[INFO]   localhost:dummy-maven-plugin .................................. 3.1

I see that some of test was changed in https://github.com/mojohaus/versions/pull/996
This one has a wrong execution defined so was overlooked
should be:
invoker.goals=${project.groupId}:${project.artifactId}:${project.version}:display-plugin-updates

instead of:
invoker.goals=versions:display-plugin-updates

and after release the problem became apparent

Looks like my own mistake 🤣


feat: add custom events to Relay

Problem
There was a report that Relay.observers were not properly cleaned up and it was hard to debug in a runtime so some hack was introduced on the consumer side.
Solution
Add observer:added and observer:removed to track state of the internal observers structure.
Notes

Resolves #1142

Validation

Looks good. I only wonder if we should use CustomEvents from libp2p or have our own. The event does not seem libp2p related so just wonder if we are restricting ourselves here.

Not really, CustomEvent is just a browser abstract and we can avoid using it altogether any time even now.
Used it just to be consistent with GossipSub

Looks good bug I wonder if it's good enough for @therealjmj. We might need a dump function too.

Funny, in making 'observers' private, it's likely this broke our implementation.
We just want a way to log the current observers, as you say, a "dump".

@therealjmj I can followup with a "dump" function but isn't it enough to have these two events for you to track what happens to observers? If you have a need for full observers list it can be maintained by these events too.

@therealjmj I can followup with a "dump" function but isn't it enough to have these two events for you to track what happens to observers? If you have a need for full observers list it can be maintained by these events too.

I'm really not a fan of events - it'll add tech that needs to be tested and maintained on our end.
I initially wanted to be helpful, but now it's added work on our end 😅

Ok :) Adding dump function soon


JSON/XML Bug Fixed

the Bug regarding JSON/XML button has been fixed

@dapatel1998  thank you for your PR. But you have not followed the Best practices.

Link your PR to a proper issue.
Add a proper commit message
Squash your commits into one
No proper PR title
No proper PR description

Read through all the links mentioned above please. Especially this.

Duplicate of a lot of previous PRs.


What is the role of adjust function?

Hi, why do you use the function adjust after backbone? Can we directly input it into the transformer without any adjustment

Hi, the role of adjust is to (1) reduce the number of channels (typically from 1024 to 256) (2) add positional encoding, which is needed by Transformer (3) add "padding mask" to indicate where is the image and where is padding.


Conv1D is slow

The Conv1D block uses MXNet's implementation for Convolution, because CUDNN only implements 2-D convolution. In the operator, we can try to optimize the performance by reshaping the inputs to 4D, and kernels to 2D, so that CUDNN kernel can be used.

In our local case, it can be 10x faster :) We can provide the PR for CPU side @jinhuang415

That will be great!

@pengzhao-intel @jinhuang415 is there a PR for this issue?

@vandanavk Not yet, the 1D conv is still under the development.
We will file PR and merge it into MXNet in the next MKL-DNN release (0.17).
https://github.com/intel/mkl-dnn/commit/a1204e41d177c0117f129cfaef92dc81d030ef4e

@xinyu-intel please check the latest MKL-DNN and conv1d.
We could start the evaluate and integrate conv1d now.

https://github.com/apache/incubator-mxnet/pull/13530#issuecomment-449811865
The performance is listed in this PR @eric-haibin-lin


WIP refactor remaining bugdown to markdown.

This is This commit is part of series of commits aimed at renaming bugdown to
markdown.

Continuation to #15569
Testing Plan:
GIFs or Screenshots:

@timabbott almost done, frontend and doc. changes remain. I have some doubt posted here: https://chat.zulip.org/#narrow/stream/3-backend/topic/zerver.2Elib.2Ebugdown/near/917893

@timabbott Ready and complete for review.

Merged as f6820085852fa689de3e47214a93d2be3096fb76 after a few textual tweaks, thanks @thedeveloperr!
I think you should do another follow-up PR that renames markdown_convert in markdown/__init__.py and also version to MARKDOWN_VERSION in that same file, and then does all the imports using our normal style; that should be a nice final cleanup.  Thanks @thedeveloperr!


Make workbench.action.files.revert action label clearer

I suggest to rename workbench.action.files.revert action from "Revert file" to something more explicative like "Reload file" or "Load file content from disk".
I was looking for this action and I was not able to find it but by searching the web for "manually reload file in vscode" I landed on #17643.
The "revert" part does not make clear that the content will be read from disk, I for one, would expect an action named "revert" to walk back all the undo stack to the state the file tab was initially opened rather than reading content again.

edit: clarify period

I think File > Revert File is a quite established thing to have in an editor. I am not sure changing it would help people that are so used to it.

I now agree with this, considering even emacs has revert-buffer, therefore I am closing the ticket.


Pay To field accepts only 34 characters.

Pay To field accepts only 34 chars so it is impossible to enter stealth address.

See #215

Tnx.


Why this over yaml/json plugins

I'm trying to gauge why I might want to use this plugin over for example https://github.com/tomzo/gocd-yaml-config-plugin
Would it make sense to offer a list of supported features in the README, or even a comparison between current versions? Or maybe just a sentence about the philosophical differences (apart from which language it's defined in).

Ah, i just discovered this helpful comment:
https://github.com/gocd/gocd/issues/6123#issuecomment-697314550

@MPV yep, basically you will have the full power of a programming language to do complex things (like templating, conditional logic, etc) when building your pipelines. And, as you've linked, now it has first-class pull request and notification/build status support built-in.
Of course, I'd want to get some of this backported into the YAML/JSON plugins, but it's going to take a lot of thought on how to model the DSL concepts here in YAML/JSON. Not to mention a lot of work getting the plumbing working.

Closing this issue; open a new issue if you still have questions.

Closing this issue; open a new issue if you still have questions.


Add fields to cache

Hi!
I'm using the plugin to generate several different feeds for the same pages. One is for standard feed readers, and several others are for cross-posting to other places. Each feed uses different fields for the URL and description depending on the purpose of the feed. (e.g. some feeds get the entire content of the page as the description, others get a shorter excerpt, etc.)
Since modifiedHashFromKeys() only factors in the snippet value and the modified dates from the pages, feeds that are populated from the same list of pages share the same cache key even if they output different fields. This means all the variations display the cached version of whichever feed is loaded first rather than rendering their own.
Would it be possible to include more of the options in the modified hash to ensure each variation gets its own entry in the cache? For my specific purposes, just the urlfield and textfield would be enough. But for more general use-cases, it might make sense to include others as well.

New plugin v5 (matching the soon-to-be-release Kirby v5) has improved caching and takes the feed URL into account, which should be unique in your use case.
Despite being flagged as v5, you can use the plugin with k4.


[PT, FR DateTimeV2] Incorrectly splitting weekday from date

Describe the bug
When a weekday and date appear together, they are returned as separate dates, e.g. "Mon prochain salaire sera le 25 Mardi"
To Reproduce
Steps to reproduce the behavior:

Create an FR or PT app with datetimeV2
Test "Mon prochain salaire sera le 25 Mardi" for FR or "meu próximo salário será terça-feira dia 25" for PT
The result will be two timex values: "XXXX-WXX-2" and "XXXX-XX-25"

Expected behavior
The result should be a single date timex (e.g. for ES, "el martes 25" returns the timex "XXXX-WXX-2" and it resolves to "2020-08-25" and "2021-05-25", which are both Tuesdays).
Platform (please complete the following information):

Platform:
Environment: in browser
Version of package: ?

"meu próximo salário será terça-feira 25" should also be supproted.

The test case above succeeds when September 2018 is set as the reference date, because in that month the 25th fell on a Tuesday. When the reference date is a month that doesn't contain the specified date/weekday combination, the weekday-date split still happens. A weekday-date combination that doesn't occur in the current month is somewhat of an edge case though.


fix(infinite-scroll):infinite-scroll can be placed in child componene…

…ts, fixes #6531
Short description of what this resolves:
Resolves #6531 , Can now place infinite-scroll inside custom component
Changes proposed in this pull request:

Remove @Host from the content, so the dependency injection is looking for closest parent, and not just the immediate parent.

Ionic Version: 1.x / 2.x
2.0.1
Fixes: #6531

Why the thumps down? Did I do something wrong?

This could have unintended consequences if multiple infinite scrolls are placed in hidden divs inside of one ion-content, but I think that this should be managed by the developer and not be blocked by the component itself.

Hey @thielCole , thanks for this PR! Any chance you could put up a working example of this? In my testing of this PR i ran into an issue where infinite scroll does not seem to update and fire off the correct event emitter once you scroll to the bottom.

@jgw96 yeah sure. Give me a day or two though.

@thielCole no problem, thanks for taking the time to contribute to Ionic!

Sorry I havent gotten to this sooner. Working on a test now.

@jgw96 I created a repo with a test for this feature.
Custom Component Infinite Scroll
As a note, I'm not sure what the correct practice is for building and testing a local copy of ionic-angular. What I did was run a
gulp e2e.prod
And then copied over the infinite-scroll component folder to my local node_modules. It's normally poor practice to put node_modules inside a git repo, but I wasn't sure if there was a better way to do this as the test would not workout without the local copy I made.


Working for BVM-702?

I have both a MPPT and a BVM, on separate ESP8266s.  This code works perfectly on my MPPT, but im hoping to use it or the majority of it forked to work with my BVM.  I see there are some references in the code for BVM.  Does anyone have it working for BVM?

I have both a MPPT and a BVM, on separate ESP8266s.  This code works perfectly on my MPPT, but im hoping to use it or the majority of it forked to work with my BVM.  I see there are some references in the code for BVM.  Does anyone have it working for BVM?

For BMV and smartshunt look here https://github.com/KinDR007/VictronSmartShunt-ESPHOME


docs: add lightgbm ranker notebook example

add lightgbm ranker notebook example

/azp run

/azp run

closing as this was added by @serena-ruan in another PR, thank you!


GlowLayer tree shake import error

When I use
import { GlowLayer } from '@babylonjs/core/Layers/glowLayer';

the error appears

if use it like import { GlowLayer } from '@babylonjs/core'; - it is ok

Repro code
import { GlowLayer } from '@babylonjs/core/Layers/glowLayer';
import { Engine } from '@babylonjs/core/Engines/engine';
import { Scene } from '@babylonjs/core/scene';

const canvas = document.querySelector('canvas');
const engine = new Engine(canvas, true, {
  preserveDrawingBuffer: true,
  stencil: true,
});

const scene = new Scene(engine);

const gl = new GlowLayer('glow', scene);
gl.intensity = 2.0;

Goood Catch I ll fix it today in the meantime as a workaround, you could import as well the boundingboxrenderer.


Can't get --hidden to work

I can't get --hidden to work, this is really problematic since I use Q promises which make stepping tricky without the ability to black box q.js itself.
Q is a direct dependency at node_modules/q/q.js.
I've tried running node-inspector like:
node-inspector --hidden '["(.*/)?node_modules/.*"]' --web-port 3001
node-inspector --hidden '["node_modules/q"]' --web-port 3001
node-inspector --hidden "node_modules/q" --web-port 3001
node-inspector --hidden '["q.js"]' --web-port 3001

I've even tried creating a .node-inspectorrc in my project folder:
{
	"web-port": 3001,
	"hidden": ["(.*/)?node_modules/.*"]
}

No matter what I use when I breakpoint and step through my project I still end up stepping into q.js.

Still happens for me... node_modules appear in the sidebar in the inspector.
latest OS X
node v5.3.0
node-inspector: "0.12.5"
.node-inspectorrc
{
  "web-port": 9090,
  "debug-brk": false,
  "save-live-edit": false,
  "preload": false,
  "hidden": ["node_modules"]
}