bevy_reflect: Contextual serialization error messages

Objective
Reflection serialization can be difficult to debug. A lot of times a type fails to be serialized and the user is left wondering where that type came from.
This is most often encountered with Bevy's scenes. Attempting to serialize all resources in the world will fail because some resources can't be serialized.
For example, users will often get complaints about bevy_utils::Instant not registering ReflectSerialize. Well, Instant can't be serialized, so the only other option is to exclude the resource that contains it. But what resource contains it? This is where reflection serialization can get a little tricky (it's Time<Real> btw).
Solution
Add the debug_stack feature to bevy_reflect. When enabled, the reflection serializers and deserializers will keep track of the current type stack. And this stack will be used in error messages to help with debugging.
Now, if we unknowingly try to serialize Time<Real>, we'll get the following error:
type `bevy_utils::Instant` did not register the `ReflectSerialize` type data. For certain types, this may need to be registered manually using `register_type_data` (stack: `bevy_time::time::Time<bevy_time::real::Real>` -> `bevy_time::real::Real` -> `bevy_utils::Instant`)

Implementation
This makes use of thread_local! to manage an internal TypeInfoStack which holds a stack of &'static TypeInfo. We push to the stack before a type is (de)serialized and pop from the stack afterwards.
Using a thread-local should be fine since we know two (de)serializers can't be running at the same time (and if they're running on separate threads, then we're still good).
The only potential issue would be if a user went through one of the sub-serializers, like StructSerializer. However, I don't think many users are going through these types (I don't even know if we necessarily want to keep those public either, but we'll save that for a different PR). Additionally, this is just a debug feature that only affects error messages, so it wouldn't have any drastically negative effect. It would just result in the stack not being cleared properly if there were any errors.
Lastly, this is not the most performant implementation since we now fetch the TypeInfo an extra time. But I figured that for a debug tool, it wouldn't matter too much.
Feature
This also adds a debug feature, which enables the debug_stack feature.
I added it because I think we may want to potentially add more debug tools in the future, and this gives us a good framework for adding those. Users who want all debug features, present and future, can just set debug. If they only want this feature, then they can just use debug_stack.
I also made the debug feature default to help capture the widest audience (i.e. the users who want this feature but don't know they do). However, if we think it's better as a non-default feature, I can change it!
And if there's any bikeshedding around the name debug_stack, let me know!
Testing
Run the following command:
cargo test --package bevy_reflect --features debug_stack

Changelog

Added the debug and debug_stack features to bevy_reflect
Updated the error messages returned by the reflection serializers and deserializers to include more contextual information when the debug_stack or debug feature is enabled

Gentle reminder to fix merge conflicts here.

@MrGVSV I regret to inform you that someone has caused merge conflicts for this again in #15107 ;) 😩

@MrGVSV I regret to inform you that someone has caused merge conflicts for this again in #15107 ;) 😩

Now what kind of dummy would perform a huge refactor on the exact set of modules he just put up a PR for this PR is touching and urge the refactor to get merged first?!
...

CI failures look real: you seem to have forgotten to feature flag an import.


feat: Docker container for TensorRT-LLM environment

Problem
TensorRT-LLM is one of the biggest features in jan. As the docker environments usually include all kind of stuff to run the software with it's full set of features, why not include it too?
Success Criteria
A container that supports TensorRT-LLM backend out-of-the-box.

Closing all open TensorRT-LLM stories, the upstream team is not focusing on tensorrt-llm on windows
Parent issue: https://github.com/janhq/cortex.cpp/issues/1742


add photo api

add photo api

@twiss

@twiss can you merge this pr. thanks

@twiss thank you

@twiss  please check again. thank you

@izouxv You ignored all the comments that are hidden by default, you need to click "Load more..." or check the Files tab.

@twiss please check again. thank you

This comment was not addressed. I know it didn't exist at the time this PR was opened, so I apologize for the churn, but all new functionality should go in the openpgp/v2 package. Please move the changes (except those in openpgp/packet) there, if you can.

@twiss please check again. thank you

This comment was not addressed. I know it didn't exist at the time this PR was opened, so I apologize for the churn, but all new functionality should go in the openpgp/v2 package. Please move the changes (except those in openpgp/packet) there, if you can.

ok

@twiss please check again. thank you

@twiss please check again. thank you

@twiss  HI,When can this be merged?

In addition to the above, could you please write a brief summary of the changes and additions to the API in the PR description, so that I can include it in the commit message? Currently it's very vague.

In addition to the above, could you please write a brief summary of the changes and additions to the API in the PR description, so that I can include it in the commit message? Currently it's very vague.

ok

@twiss please check again. thank you

@izouxv where did you add the description? :s

@twiss please check again. thank you.
pr commit is: [feat](feat: Add AddPhotos to v2 api.)

@twiss please check again. thank you.

Sorry, I meant more like: could you write a short description of the functions you added and what they're for? See https://github.com/ProtonMail/go-crypto/commit/8b3893ee7fca8cf2f8ab27de531011586c2f7b0d for a random (unrelated) example.

Sorry, I meant more like: could you write a short description of the functions you added and what they're for? See 8b3893e for a random (unrelated) example.

my desc is : feat: Add Entity.AddPhotos function to v2
This change introduces a new function, Entity.AddPhotos,
and the Entity struct adds a new member variables "Attributes".
this enables user avatars encoded in jpeg format
please check , thank you

@twiss please check again. thank you.

@twiss please check again. thank you.

@twiss @lubux
can you check the pr.  thank you


test(amplify-e2e-tests): added longer delay to cloudwatchlogs collection

added longer delay on e2e grabbing cloudwatch
added minor config changes to

package.json
tsconfig.json

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #3566 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3566      +/-   ##
==========================================
- Coverage   59.43%   59.17%   -0.26%
==========================================
  Files         280      284       +4
  Lines       13202    13260      +58
  Branches     2652     2504     -148
==========================================
  Hits         7846     7846
- Misses       4933     5009      +76
+ Partials      423      405      -18

Impacted Files
Coverage Δ

...ges/graphql-transformer-core/src/util/fileUtils.ts
11.76% <0%> (ø)
:arrow_up:

...ges/amplify-util-mock/src/CFNParser/stack/index.ts
88.09% <0%> (ø)
:arrow_up:

...psync-simulator/src/resolvers/pipeline-resolver.ts
9.37% <0%> (ø)
:arrow_up:

...s-generator/src/generator/generateAllOperations.ts
90.69% <0%> (ø)
:arrow_up:

...c-simulator/src/schema/directives/aws-subscribe.ts
26.66% <0%> (ø)
:arrow_up:

...l-mock/src/CFNParser/appsync-resource-processor.ts
12.72% <0%> (ø)
:arrow_up:

...phql-docs-generator/src/generator/utils/loading.ts
41.66% <0%> (ø)
:arrow_up:

...amplify-appsync-simulator/src/server/operations.ts
28.12% <0%> (ø)
:arrow_up:

...mplify-appsync-simulator/src/resolvers/function.ts
9.67% <0%> (ø)
:arrow_up:

...lify-graphql-types-generator/src/compiler/index.ts
90.32% <0%> (ø)
:arrow_up:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc4a1d9...309b3b2. Read the comment docs.


Give all old forms a created and updated date

Thanks to @thomasiles for suggesting this in #43

Do merge this before Monday if you would like the migration to happen. Otherwise I'll do so then!

oh good my change failed rubocop, please don't fix!

It's dB test 7, not migration test 7. Maybe that naming is confusing...
On August 18, 2022, GitHub @.***> wrote:

@aliuk2012 requested changes on this pull request.
Am I missing something, where is the migration 7 file?

—
Reply to this email directly, view it on GitHub
<https://github.com/alphagov/forms-api/pull/57#pullrequestreview-
1076887891>, or unsubscribe
<https://github.com/notifications/unsubscribe-
auth/AAA33MNMOBGIFAR6YLATLFTVZXWI7ANCNFSM562I46JA>.
You are receiving this because you were assigned.Message ID:
@.***>

sorry folks I'm not used to the new merge strategy on git yet, I pulled in some commits from main that I'm to lazy to remove. New PR incoming

https://github.com/alphagov/forms-api/pull/60


interp_images in util_misc.py returning NaNs

Hi Cameron,
Been playing around with the code recently and think I've noticed an issue. It might be just because of the cubes I'm using (parts of POSSUM cubes cut out with CASA), but thought I would flag it just in case.
The part of do_RM_synth.py which starts with 'if dataI is not None:' (line 193 or somewhere around there) calls the interp_images function from util_misc. For my particular I cube, freqArr_Hz[idx]>freq0_Hz and so Ifreq0Arr = interp_images(dataI[idx-1, :, :], dataI[idx, :, :], f=0.5) is called.
However this just seems to return NaNs, meaning the overall output cubes becomes NaNs. When I instead force the code to do Ifreq0Arr = dataI[idx, :, :] by removing the ifs, it seems to be fine and I get sensible final outputs. It seems like the interp_images function for me just returns an array of NaNs, which then messes up the rest of everything.
From my understanding, this function just seems to want to grab the I image from the central frequency channel, or if there are two central ones to interpolate between them? Would there be a way to use the continuum-averaged I image instead? Is there a potential consistency issue with the packages used in interp_images?
Many thanks,
Emma

Hi Emma!
I think you're the first person to try out that particular feature in RM-Tools, so thanks for the bug report! Any chance you could send me the cubes you're using? That'll make it easier to track down why the interpolation is messing up.
Using the continuum-averaged I... might be possible. I'd have to think about it. I think it might not play well with normalizing the Q/U spectra.
Cheers,
Cameron

Thanks — will email you them now.

Hi Emma:
I found the problem. Looks like it was trying to do quadratic interpolation instead of linear (which failed because it was only getting the two nearest Stokes I planes). I've fixed it to do linear interpolation. There's a new version on Github and on pip.
You might also consider playing around with the do_fitIcube.py script inside RMtools_3D/. In theory it's supposed to fit and output a pixel-by-pixel Stokes I model to the data, which can be more reliable than using channel values for Stokes I if the S:N is not really high. I don't know if it's been tested though, so you're welcome to be a guinea pig if you have time. :) If it's broken, I was planning on looking at the 3D toolkit again sometime in September/October-ish in order to add some features needed for the POSSUM pipeline.
Cheers,
Cameron

Thanks Cameron!


Feature request - add vat validated customer to group

Would be awesome if the module could add all VAT validated customers to a selected group.
This way you can check in customer list if customer is a B2B customer, also make it possible to show price in frontoffice without vat for alll in this group :)

Hi @thbl
This actually was the original functionality but is removed since a user can have multiple addresses and each address has it's own VAT number.


Does it works on any printer?

I'm just wondering how this package works,
using native languages like java you need to get the SDK of the printer and install drivers to connect the printer to the app.
My question is: does this package doesn't need drivers/SDK installation?

i did https://www.youtube.com/watch?v=ZjWOiXC3nIk

I did https://www.youtube.com/watch?v=ZjWOiXC3nIk

Thanks, I saw this before but I end up using blue_print_pos (only Bluetooth)


no web_sys::console in the root

Trying to follow the guide at https://rustwasm.github.io/docs/wasm-bindgen/examples/console-log.html
It shows the following code:
use web_sys::console;

console::log_1(&"Hello using web-sys".into());

When I attempt to compile it, it errors:
error[E0432]: unresolved import `web_sys::console`
  --> src/lib.rs:34:9
   |
34 |     use web_sys::console;
   |         ^^^^^^^^^^^^^^^^ no `console` in the root

I can use other features of web_sys... for example, all these imports are working:
use js_sys::{Array, Intl, Object, Reflect};
use wasm_bindgen::prelude::*;
use web_sys::{CryptoKey, CryptoKeyPair};
use wasm_bindgen_futures::JsFuture;

What can be the issue? Has console been moved elsewhere recently?

Oh nevermind... just figured out using console also requires the feature console. Unexpected.

Because there are so many thousands of web APIs, compile times would be extremely long. So to make the compile times reasonable we use Cargo features so it only compiles the things that you actually use.
Although this approach is rare, it is used for other very large crates like winapi.
This is explained on the main page for web-sys and also on each individual function:

This API requires the following crate features to be activated: console

I agree that we should change the console-log example to make this more clear.

If anyone else gets here and is like "argh, why didn't you post the answer?!" the answer is:
[dependencies]
web-sys = { version = "0.3.49", features = ["console"] } # <!-- add the feature

You also don't need to use web_sys::console; like the example here shows, just console::log_X.


Elasticsearch and Kibana build as a Single Image

As a user, it would be great to have elasticsearch and kibana packaged in a single docker image. so that it can be ran in cloud environment easily with minimal configuration and compute resources where logs can be hosted from cloud services like cloudwatch, etc.

Thanks for your suggestion @vishleshpatel

Thanks for this suggestion. This single image for both of elasticsearch and kibana isn't in our plan currently


Problems when using English version (:script: en) of a GB standard

Problem 1.
"Introduction" is given as the 5th section when English is used. I presume it is because "== 引言" was expected. Is it possible to allow a localization file to take care of this?
Problem 2.
There's a lot of Chinese still on the cover page (and the "Index" title). Can we provide a separate YAML file for pairwise translations?

Basically this means English version of the front page templates, which can be done through YAML files. I'd make them additional YAML files.

Agree, thanks @opoudjis !

Front page in English version is now in English, apart from standard class and issuer.

DOne those too.

Wow, it's working! 👍


feat: add poseidon relations to UltraKeccak flavor and Solidity verifier

Please read contributing guidelines and remove this line.

Benchmark results
Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 768 (-44%)
avm_simulation_time_ms (Token:transfer_public): 27.0 (+63%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,746
1,559
714
760 (+1%)
787 (+1%)

proof_construction_time_sha256_30_ms
11,463
3,081 (-1%)
1,394 (+1%)
1,454 (+1%)
1,473 (+1%)

proof_construction_time_sha256_100_ms
45,341 (+3%)
12,152 (+2%)
5,694 (+4%)
5,810
5,801 (+4%)

proof_construction_time_poseidon_hash_ms
78.0
34.0
34.0
59.0 (+2%)
88.0 (-1%)

proof_construction_time_poseidon_hash_30_ms
1,530
423
202
227 (-2%)
271 (+2%)

proof_construction_time_poseidon_hash_100_ms
5,626
1,513
682 (+1%)
755 (+2%)
749

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
4,356
7,876
14,884

l1_rollup_calldata_gas
50,208
92,966
178,120

l1_rollup_execution_gas
843,049
1,576,703
3,361,913

l2_block_processing_time_in_ms
255
448 (-1%)
813 (+1%)

l2_block_building_time_in_ms
10,803 (-6%)
21,396 (-4%)
42,302 (-4%)

l2_block_rollup_simulation_time_in_ms
10,802 (-6%)
21,396 (-4%)
42,302 (-4%)

l2_block_public_tx_process_time_in_ms
9,214 (-6%)
19,771 (-4%)
40,663 (-4%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
3,037
3,913

node_database_size_in_bytes
12,615,760
16,752,720

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
simulation_time_in_ms
witness_generation_time_in_ms
input_size_in_bytes
output_size_in_bytes
proving_time_in_ms

private-kernel-init
71.4 (-10%)
382
21,377
44,898
N/A

private-kernel-inner
156 (-1%)
680 (-1%)
72,358
45,020
N/A

private-kernel-reset-tiny
276 (-6%)
711 (+3%)
65,018
44,886
N/A

private-kernel-tail
149 (-7%)
129 (-2%)
50,589
52,921
N/A

base-parity
5.52 (-1%)
N/A
160
96.0
N/A

root-parity
35.1
N/A
73,948
96.0
N/A

base-rollup
3,054 (-3%)
N/A
189,207
664
N/A

block-root-rollup
41.2
N/A
58,205
2,448
N/A

public-kernel-setup
78.7 (-3%)
N/A
105,085
71,222
N/A

public-kernel-app-logic
92.8 (-2%)
N/A
104,899
71,222
N/A

public-kernel-tail
802 (-6%)
N/A
390,582
16,414
N/A

private-kernel-reset-small
269 (-9%)
N/A
66,341
45,629
N/A

private-kernel-tail-to-public
:warning: 768 (-44%)
578 (-4%)
446,144 (-2%)
1,825
N/A

public-kernel-teardown
77.8 (-4%)
N/A
105,349
71,222
N/A

merge-rollup
20.0
N/A
38,174
664
N/A

undefined
N/A
N/A
N/A
N/A
82,512 (+1%)

Stats on running time collected for app circuits

Function
input_size_in_bytes
output_size_in_bytes
witness_generation_time_in_ms

ContractClassRegisterer:register
1,344
11,731
344 (-1%)

ContractInstanceDeployer:deploy
1,408
11,731
18.2

MultiCallEntrypoint:entrypoint
1,920
11,731
401 (-1%)

FeeJuice:deploy
1,376
11,731
391

SchnorrAccount:constructor
1,312
11,731
62.4 (-1%)

SchnorrAccount:entrypoint
2,336
11,731
369

FeeJuice:claim
1,344
11,731
34.3 (-2%)

Token:privately_mint_private_note
1,280
11,731
73.3 (-1%)

FPC:fee_entrypoint_public
1,344
11,731
24.7 (+1%)

Token:transfer
1,312
11,731
211 (-1%)

Benchmarking:create_note
1,344
11,731
75.6

SchnorrAccount:verify_private_authwit
1,280
11,731
26.7 (+1%)

Token:unshield
1,376
11,731
519 (+4%)

FPC:fee_entrypoint_private
1,376
11,731
693 (+4%)

AVM Simulation
Time to simulate various public functions in the AVM.

Function
time_ms
bytecode_size_in_bytes

FeeJuice:_increase_public_balance
45.2 (-1%)
2,307 (-5%)

FeeJuice:set_portal
15.5 (+18%)
2,680 (-9%)

Token:constructor
74.6 (-5%)
13,839 (-12%)

FPC:constructor
47.9 (-5%)
8,553 (-12%)

FeeJuice:check_balance
36.0 (-2%)
2,041 (-13%)

Token:mint_public
48.7 (-5%)
4,572 (-9%)

Token:assert_minter_and_mint
462 (-1%)
3,006 (-5%)

AuthRegistry:set_authorized
46.4 (+29%)
923

FPC:prepare_fee
65.5 (+3%)
3,925 (-8%)

Token:transfer_public
:warning: 27.0 (+63%)
9,482 (-12%)

FPC:pay_refund
44.4 (+9%)
4,856 (-7%)

Benchmarking:increment_balance
1,164 (-4%)
3,170 (-9%)

Token:_increase_public_balance
38.5
2,284 (-5%)

FPC:pay_refund_with_shielded_rebate
50.6 (-4%)
4,856 (-7%)

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.150

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.19 (-1%)
3.89 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.114 (-1%)
0.109 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.1 (-1%)
17.5 (-1%)
31.0 (-2%)
59.2
111 (-2%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.107 (-1%)
0.102 (-1%)
0.101 (-2%)
0.102
0.0994 (-2%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.2 (-1%)
25.4 (-1%)
43.7 (-1%)
82.6
159 (-1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
107
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.110 (-2%)
0.102 (-1%)
0.106 (-1%)
0.102
0.102 (-1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
16.5 (-1%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
132
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.106 (-1%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
64,838
668,997

Transaction size based on fee payment method
| Metric |  |
| - |  |


Merge Lolita code

Since PomeloFoundation/Lolita has not been effectively updated for two years, the BUG cannot be fixed, so it was decided to merge Lolita's code directly into the EntityFrameworkCore extension of Cosmos.Data.
https://github.com/PomeloFoundation/Lolita/issues/18
After the merger, Lolita ’s Cosmos branch code will be maintained by the cosmos-loops team.

The main project of Cosmosloops will abandon the use of Microsoft EntityFrameworkCore by default and use NCC FreeSql by default.
Therefore, cosmos-data-entityframeworkcore will give up upgrading to efcore 3.x. At the same time, it will decide whether to add support for efcore 5.x according to the situation.


Post processor fails with 'unknown build failure'

After migrating a bunch of libraries to the monorepo, the post processor is failing with unknown build failure:

I think this is because it is iterating through all packages, and then post processor takes longer to run than the timeout for the check, resulting in a failure.
I think the solution is to only run the post-processor on select files, in a given PR, the changed files.

Solved: https://github.com/googleapis/synthtool/pull/1715


Fix #1: add horse names in database

Fix #1: add horse names in database for user story 1 JJ and Flyka

/tina - can you have a look at this?

/tina - done.


differential prioritization, tests, full_results

Implementation differential prioritisation.
Add (overly) simple test.
Implemented full_results in results object, returning augur score results for all folds.

Looks great!


Added Strum Input to XInputHolder. Strum bar was not working prior to…

Found that the strum bar was not working with the latest commit on my wii guitar. Started working after including them as UP & DOWN Xbox360 inputs.

Oh nice, thanks for catching this! Didn't see this until now, apparently wasn't set to watch my own fork lol
I don't remember if this is something I may have broken myself, been a while since I worked on stuff. That's what I get for trying to make changes without the actual hardware to test with... (I have wiimotes, but not a wiitar)


az partnercenter marketplace offer plan listing image show

There aren't single image to show. Only implementing list command


Do you have the data loader on modelnet 40

Hi, please refer to DGCNN for loading ModelNet40 data.


...

[Enter steps to reproduce below:]

...
...

Atom Version: 1.2.4
System: Unknown Windows Version
Thrown From: language-babel package, v2.57.0
Stack Trace
Failed to load the language-babel package
At Proxy is not defined

ReferenceError: Proxy is not defined
    at Object.<anonymous> (C:\Users\yuan\node_modules\fs-plus\lib\fs-plus.js:708:24)
    at Object.<anonymous> (C:\Users\yuan\node_modules\fs-plus\lib\fs-plus.js:718:4)
    at Module._compile (module.js:434:26)
    at Object.defineProperty.value [as .js] (C:\Users\yuan\AppData\Local\atom\app-1.2.4\resources\app.asar\src\compile-cache.js:190:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (file:///C:/Users/yuan/.atom/packages/language-babel/lib/auto-indent.coffee:2:6)
    at Object.<anonymous> (file:///C:/Users/yuan/.atom/packages/language-babel/lib/auto-indent.coffee:1:1)

Commands

Config
{
  "core": {
    "themes": [
      "atom-material-ui",
      "atom-material-syntax"
    ],
    "disabledPackages": [
      "react-es6-snippets",
      "react-es6-snippets",
      "react-es6-snippets"
    ]
  }
}

Installed Packages
# User
atom-material-syntax, v0.4.6
atom-material-ui, v1.2.4
atom-react-native-autocomplete, v0.0.27
language-babel, v2.57.0

# Dev
No dev packages

This is a problem with Atom, in particular the fs-plus module has an issue with Node 4. See https://github.com/atom/fs-plus/issues/38
I would strongly suggest you update Atom as you are running a very old version. If you can't do that then
I would suggest you go to ~/.atom/.apm/fs-plus and do an npm update to get the latest version that supports Node 4.


Paranoid mode is non existent

While in default configuration here: https://github.com/lynndylanhurley/devise_token_auth/blob/master/config/initializers/devise.rb#L73 it seems that paranoid mode is supported, in fact it isn't at all. I stumbled upon this by accident when I was trying out the password reset api endpoint. It yields different messages depending on whether the email exists in the database or not. With config.paranoid = true this behavior isn't changed. I thought it's isolated case, but when I tried to search the repository for paranoid, one and only entry was... in that initializer file I mentioned above. Ergo - it's not implemented.
Is this on a roadmap maybe?

Version: 0.1.42

Hey @riggy ! We don't really have a roadmap. But we do accept PRs! Thanks for your help.


[fix] #3411: Properly handle peers simultaneous connection

Description

Prevent simultaneous connections by selecting who will be passive and active when connecting.
Prevent connection duplication by keeping track of outgoing connections.
If simultaneous connection happen add policy to resolve which connection to preserve.

Linked issue

Closes #3411.

Benefits
Test flakes at much smaller rate, i run it like 10000 times without any error + works a lot faster.
There still can be cases where we can lose message (and thus multiple_networks test can fail).

Checklist

[x] I've read CONTRIBUTING.md
[x] I've used the standard signed-off commit format (or will squash just before merging)
[x] All applicable CI checks pass (or I promised to make them pass later)
[ ] (optional) I've written unit tests for the code changes
[ ] I replied to all comments after code review, marking all implemented changes with thumbs up

Do you think the sumeragi view change indices inspired this design?

Im not sure what exactly affected my design.
Initially i was thinking about adding some kind of value that one peer will send to another and this value will be used as resolve connections, but i didn't want to introduce another stage of handshake.
And then i got insight that we already have such value.


Feature request: allow non semver version

At least document on the version config field that semver compatible version is required. I know it will get tricky for the update feature, so i understand if this is not implemented. I just lost some time migrating my project to another version format for nothing

I think we can add support for non-semver version, we already have a version_comparator function in the updater, we will just need to change its signature to take String instead of semver::Version.

I am curious though, where exactly did you face issues with sermver, during packaging? which packaging format? or during updating?

During packaging for nsis. I finally found a workarround, by using YYYY.MM.0 format. This way, the update should also works if i implement it.


[5.7] Add "any" method to Collection as an alias to "contains"

After going through the Collections documentation, I couldn't find an any method, especially after observing that an every method does exist!
After quite a long code walkthrough, I found that contains would the equivalent of any. However, it's not quite apparent especially from a predicate callback perspective. I think adding any as an alias to contains would be very helpful. Since this is an additional method, there are no breaking changes.

Based on other methods in the framework, I would expect an 'any' method to accept multiple parameters and return whether or not the collection contains "any" of those. It doesn't feel like any == contains.

IMO, a method that returns whether or not a collection contains any params, sounds like a where or a whereAny.
I'll demonstrate why I think any is a perfect alias for contains. Mentioned below are some use cases:

Check if any order has a book product:

$orders->any('product', 'book');

Check if any order has more than 5 items:

$orders->any('quantity', '>', 5);

Check if any order was paid by cash (truth test):

$orders->any(function($order) {
    return $order->paidByCash();
});

All of the above use cases look perfect for an any method. What's more is that they're similar to every that has all the above use cases in a different context.
That's why I think any should be an alias for contains.

@paras-malhotra I think the term you're looking for here is some instead of any, knowing that:

every will return true if all predicate is true
some will return true if any predicate is true

@phanan I agree. I checked the documentation of both Lodash and Underscore JS. Both of them have every and some methods that do the same thing that we're trying to do! I think this naming would also get rid of the confusion that @devcircus mentioned.
I'll update my PR to rename the method to some.


--defer flag to dbt docs generate

Describe the feature
Provide a --defer flag to dbt docs generate to accurately reflect deferred database objects and compiled SQL.
Describe alternatives you've considered
I've worked around it by manually messing with the schemas in manifest.json using this PowerShell code:
# Update the schemas in the docs manifest if we're not in the master branch
if ($Env:bamboo_planRepository_branchName -ne 'master') {
    $MasterState = .\scripts\Get-MasterState.ps1
    $Manifest = .\scripts\Get-Manifest.ps1
    $AllModels = $Manifest.nodes.PSObject.Properties | Select-Object -ExpandProperty Name |
        Select-String -Pattern '(?<=^model\.).*' | Select-Object -ExpandProperty Matches |
        Select-Object -ExpandProperty Value
    Write-Verbose "All models: $AllModels"
    $ModifiedModels = dbt ls --profiles-dir profiles --target $DocsTarget --models 'state:modified+' --state $MasterState |
        Select-String -Pattern '^[^\.]+|[^\.]+$' -AllMatches | foreach { "$($_.Matches[0].Value).$($_.Matches[1].Value)" }
    Write-Verbose "Modified models: $ModifiedModels"
    if ($ModifiedModels) {
        $UnchangedModels = Compare-Object -ReferenceObject $AllModels -DifferenceObject $ModifiedModels -PassThru
    } else {
        $UnchangedModels = $AllModels
    }
    Write-Verbose "Unchanged models: $UnchangedModels"
    $UnchangedModels | foreach { $Manifest.nodes."model.$_".schema = 'dbo' }
    $Manifest | ConvertTo-Json -Compress -Depth 100 | Set-Content .\target\manifest.json
}

However, I can't fix the compiled SQL as easily...
Additional context
Is this feature database-specific? Which database(s) is/are relevant? Please include any other relevant context here.
Who will this benefit?
Anyone who uses state deferral.
Are you interested in contributing this feature?
Sorry, probably not... Workarounds are the best I can do :D

I forgot about --no-compile... I knew I was doing something overly complicated... 😭

I can confirm that the --no-recompile workflow works for me. I use the following logic to back up the manifest after the deferred run and then restore it right before running:
$FinalManifest = if ($RunOutput | sls 'WARNING: Nothing to do') { "$MasterState\manifest.json" } else {
    '.\target\manifest.json' }
$ManifestBackup = New-TemporaryFile
Write-Verbose "Backing final manifest $FinalManifest up to $ManifestBackup"
Copy-Item -Path $FinalManifest -Destination $ManifestBackup

Thank you @jtcohen6 !


Add travis ci step to build pages

I'd like to move the travis CI stuff for deploying pages into its own stage and job and provide a mechanism to allow me to build them manually from master without having to make a release if I don't want to.

Tbh, I don't think this might be a really good idea since we might have added some new features to master that are not in the pypi version that the documentation is built for, which might cause confusion on users that try to use some feature that is not there


Unable to find images in remote docker registry

I was able to configure docker registry successfully.I am able to push and pull a particular repository from remote docker registry but when I run docker search :5000, I am not able to see anything. Anyone facing the same issue?
docker push <IP_ADDRESS>:5000/docker.io/mysql
The push refers to a repository [<IP_ADDRESS>:5000/docker.io/mysql]
dda5a64c9b27: Image successfully pushed
53ed9837cdc5: Image successfully pushed
b26238180bc8: Image successfully pushed
01e91410235e: Image successfully pushed
b610b16e919f: Image successfully pushed
1574ff8789b1: Image successfully pushed
e7048a1643a4: Image successfully pushed
1bc74a039df4: Image successfully pushed
6ebad06b3e49: Image successfully pushed
f1621398948b: Image successfully pushed
fe4c16cbf7a4: Image successfully pushed
Pushing tag for rev [cd88b71c6c8c] on {http://<IP_ADDRESS>:5000/v1/repositories/docker.io/mysql/tags/latest}
docker pull <IP_ADDRESS>:5000/docker.io/mysql
Using default tag: latest
Trying to pull repository <IP_ADDRESS>:5000/docker.io/mysql ...
Pulling repository <IP_ADDRESS>:5000/docker.io/mysql
cd88b71c6c8c: Already exists
fe4c16cbf7a4: Already exists
e6261350fc40: Already exists
d3639d3b76cc: Already exists
af37e9492c41: Already exists
e91a78270995: Already exists
b44b8bdb0b85: Already exists
7ddf3d4ce9c7: Already exists
1c83626f4ec2: Already exists
a1125db48858: Already exists
21dbefa406d6: Already exists
Status: Image is up to date for <IP_ADDRESS>:5000/docker.io/mysql:latest
<IP_ADDRESS>:5000/docker.io/mysql: this image was pulled from a legacy registry.  Important: This registry version will not be supported in future versions of docker.
docker search <IP_ADDRESS>:5000
INDEX     NAME      DESCRIPTION   STARS     OFFICIAL   AUTOMATED

The current version of the open source registry (https://github.com/docker/distribution) does not have indexing / search built-in. Indexing/searching is separate from the actual registry.
The "legacy" registry (v1) https://github.com/docker/docker-registry did have search built-in, but is deprecated and no longer maintained.
Please keep in mind that the GitHub issue tracker is not a general discussion/support forum, but for reporting bugs and feature requests. For other topics, use https://forums.docker.com
Since this is not a bug, I'll close this issue, but feel free to comment after I closed


WIP

TODO:

fix iterator hack
how to indicate the mate read is unmapped in GA4GH ReadAlignment (as
opposed to not present?)

Issue #783

Fundamentally the failing test cause stems from the fact that we weren't setting read flags 0x4 and 0x8 when writing reads to a SAM file.  But this brings up other related things...

Unmapped mates will often still have a position.  Consider the following scenario in BAM.
Read X/1 and X/2 being 1st and 2nd read in the template.  X/1 maps, X/2 does not.
We may therefore write X/1 as mapped to chr10 pos 1000 and X/2 as unmapped, but also at chr10 pos 1000.
The reason for this is that if we wish to locally pull out all the mates in a region in order to perform a local reassembly, for example, then we need to easily fetch out the reads that didn't map but should apparently do so in that vicinity.  The likely reason for not mapping would be a large insertion.
IMO therefore, using the position field as an indicator for being unmapped doesn't work well.  Instead it should be kept in the flags.

I don't think assumptions can be made about presence of a mate even if mate info claims it is mapped.

@jeromekelleher ready for review
I think the reads round-trip code is correct now as far is at can be.  But we can't really do a round trip since when we read reads we are losing some information from the BAM if the read is unmapped or its mate is unmapped -- that is, we set either read.alignment or read.nextMatePosition to None, and in order to write that read to another BAM as it was in the original BAM, we require information that is not set on the GA object since those would be fields on what is a null Position object.

Looks great to me @dcolligan, thanks. +1.
There are a couple of things it would be good to follow up on here:

You mentioned above that we can't roundtrip due to a limitation in the schema. Is this a currently known limitation? If it hasn't been discussed in https://github.com/ga4gh/schemas/issues/505, we should follow up there with a description of the problem. (I guess even if it has, we should update that thread with the issues we're having roundtripping.)

It would be good to get some expert review on these changes. @jmarshall/@jkbonfield, would you have a few spare minutes to scan over this code please? It would be very useful to get your view on this, particularly if we're up against schema limitations.

I haven't used any of the code in anger, so I'm not really qualified for code review on it.  I simply looked over the schema with an eye to spotting any potential round trip errors.  But again, I didn't actually test it (although I did try, and failed to navigate the maze of twisty web passages all alike before I ran out of time).

The limitation being hit is that the GA4GH schema does not allow unmapped reads to have a position, which IMO is a hack in BAM to get reads to come back in a desired order. It is a problem which could be solved more explicitly through the API (though admittedly we haven't done that). This is noted in ga4gh/schemas#505 you linked to:

Data isn't just mapped or unmapped; it can be "placed" but unaligned. (Chr/Pos but CIGAR *) This is commonly done where one read in a pair is mapped and the other is not. I believe the GA4GH format permits this, but perhaps needs spelling out explicitly. Is this simply achieved by having ALinearAlignment with a GAPosition and an empty GACigarUnit array?

Regardless of what we decide to do with implementation or schema changes in the future to be able to do round trips, we shouldn't let that stand in the way of merging this.  It fixes a system-dependent test failure and also brings our read code more in line with the spec(s).  I imagine I'll be filing at least one schema issue after it's merged (probably just to update docs)

@dcolligan, agreed, merging the PR.
We should follow up on the above comments though so the experience we've had here isn't lost.


official release of v3.1.2

to: @airbnb/streamalert-maintainers
Background
Reason for the change
Changes

Fixes a bug in scheduled_queries terraform module generation related to s3 buckets as map vs list.
Fixes bug in naming convention of athena results bucket (hypens vs periods as delimiter)
DRY out some code in athena generation code.

Testing
Adding unit tests for schedule queries terraform module generation.

Coverage increased (+0.05%) to 95.43% when pulling c98a66b05de723b27b036b93e350d8f30ed74346 on release-3-1-2 into 1714b1edf2e4f0e33427cb96ead66ae922c12e57 on master.


[SPARK-41846][CONNECT][PYTHON] Enable doctests for window functions

What changes were proposed in this pull request?
Enable doctests for window functions
Why are the changes needed?
for test coverage
Does this PR introduce any user-facing change?
No
How was this patch tested?
enabled tests

Merged to master.


Naive builtin range function

This just returns a list rather than a range object (which is what CPython does), and only accepts a single integer argument.

Nice, this will then be upgraded later to some sort of builtin class. But first we need classes support.


Lazy loading example?

The Slick library has "ondemand" and "progressive" options for lazy loading slides, which work really well.
I can't find anything in the pure-react-carousel docs discussing how to lazy load.  Is it a feature?  If not, can it be added?

PRC tries to be bare bones.
In PRC, the "currentSlide" is the leftmost visible slide.  You also have a value for "visibleSlides" which tracks how many carousel elements you show at a time.  Both of those values are stored in the carousel's context.  You can create a higher order component to pass these values to your slide content.  Your slide content can then determine if it wants to lazy load or not.
To find out how to compute if the current slide is visible, look at our code here:  https://github.com/express-labs/pure-react-carousel/blob/d7dd7388b7570b6aab6ba0bbbed39475f17eb033/src/Slide/Slide.jsx#L56
So, yes, this is possible.  It's not available out-of-the-box nor will it ever be.  It's not the goal of PRC to encapsulate other functionality outside of being a carousel.

Closing, since this isn't an issue. @rscotten feel free to open an RFC or draft PR if you'd like to see something like this added and find a way to do it that doesn't overstep the responsibility set of PRC.
Good luck!

@mrbinky3000 @bcarroll22 Thanks for the quick responses and clarification.
That's a bummer lazy-loading is beyond the scope of this package.  The biggest issue I have with carousels is them loading all images at once and slowing down the page load.
If it's beyond the functional scope, it still would be super helpful if there was at least a canonical lazy loading example provided to show us how to implement.  I'll do my best to figure it out, though.
Thanks again.

Hey everyone,
Thanks for this great package!
I was looking for Lazy Loading options and I saw @mrbinky3000's helpful message, and I came up with this code here, which is working as far as I see:
class MySlider extends React.Component {
    render() {
        const { images, currentSlide } = this.props

        return (
            <Slider>
                {images.map((s, i) => (
                    <LazySlide
                        key={i}
                        index={i}
                        src={s}
                        current={currentSlide}
                    />
                ))}
            </Slider>
        )
    }
}

const MyLazySlider = WithStore(MySlider, (state) => ({
    currentSlide: state.currentSlide,
}))

const LazySlide = ({ index, src, current }) => {
    const wasVisible = useRef(false)
    const isVisible = current === index // I have only one visible slide at once

    if (!wasVisible && isVisible) {
        wasVisible.current = true
    }

    return (
        <Slide index={index}>
            {wasVisible.current && (
                <Image
                    src={src}
                    style={{
                        width: '100%',
                        height: 250,
                        objectFit: 'cover',
                    }}
                />
            )}
        </Slide>
    )
}

That would be great if you guys give me some feedback if you got some time! and maybe add it as an example. Thank you.


should we rename 'watch' to be 'deploy-watch'?

based on this #364 - I wonder if watch is too vague? A deploy prefix might be more clear its a deploy-and-watch kinda thing?

Yeah its sad that mvn dont have parameters with just --watch or someting.

we could add a -Dfabric8.watch as replacement for a parameter (the "Maven way")


Begin deserializing error payload from JS in Android

Begins deserializing the error payload passed from JS to Android. This changeset handles the primitive fields in the error - separate PRs will be raised for exceptions etc.

Yep - arbitrary data can be serialised in deviceData etc.
As the connectedCheck issue appears to be affecting all the PRs I'm going to go ahead and merge this one then address it on the react-native branch. Strangely it seems to run the tests fine from Android Studio so I guess there's some classpath issue.


Responsive Razor Pages

It would be great to have the Responsive Middleware working for Razor Pages too.

should be working, let me check on that feature later in the week.

any news?

need to investigate what Razor Page using differently from from Mvc for RazorViewEngineOptions to configure ViewLocationExpanders

I have got it working with layout view.
Mobile view

Tablet view

Desktop default

Anybody got any idea how to parse the root Page folder for index?
foreach (var location in viewLocations)
{
    if (location.ToLower().Contains("pages"))
    {
        yield return location.Replace("{0}", "{0}." + device.Type.ToString());
        yield return location;
    }
    else
    {
        if (_format == ResponsiveViewLocationFormat.Subfolder)
            yield return location.Replace("{0}", device.Type.ToString() + "/{0}");
        else
            yield return location.Replace("{0}", "{0}." + device.Type.ToString());
        yield return location;
    }

The hard issue to resolve with Razor Pages is getting the right page(according to the device) to handle the request. Any other view (or partial view) to render after that point is working as expected.

There must be an intelligent way to resolve this. I don't have the time to focus on this yet.
Maybe somebody to could take up the challenge before i can come by and resolve this.

Need to investigate more on this concept
builder.Services.Configure<RazorPagesOptions>(options =>
{
    options.Conventions.AddPageRouteModelConvention("index", a => a.AreaName = "detection");
    options.Conventions.AddPageRouteModelConvention("preference", a => a.AreaName = "preference");
});

The hard issue to resolve with Razor Pages is getting the right page (according to the device) to handle the request (routing). Any other view (or partial view) to render after that point should works as expected.
I think the ViewLocationExpanders isn't used during this first step, instead we need to figure out some way to hook up into the routing to achieve this.
To workaround this, i used the URL Rewriting to redirect to a device specific page, if existent.

Do you have example of your url rewriting? Much appreciated.

Sure, here is:
`public class Startup
{
public Startup(IConfiguration configuration, IHostingEnvironment env)
{
Configuration = configuration;
HostingEnvironment = env;
}
public IConfiguration Configuration { get; }
public IHostingEnvironment HostingEnvironment { get; }

// This method gets called by the runtime. Use this method to add services to the container.
public void ConfigureServices(IServiceCollection services)
{
	//Configure detection services
	services.AddDetectionCore()
			.AddDevice();
	services.AddResponsive();

	services.AddMvc()
		.AddRazorPagesOptions(options => {
			options.Conventions.AuthorizePage("/Index");
		})
		.SetCompatibilityVersion(CompatibilityVersion.Version_2_1);
}

// This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
public void Configure(IApplicationBuilder app, IHostingEnvironment env)
{
	if (env.IsDevelopment())
	{
		app.UseDeveloperExceptionPage();
		app.UseDatabaseErrorPage();
	}
	else
	{
		app.UseExceptionHandler("/Error");
		app.UseHsts();
	}

	//Use responsive detection middleware
	//- detected device suffix path: *views/[controller]/[action]/index.{Desktop|Tablet|Mobile|Tv|Console|Car}.cshtml*
	//- detected device subfolder path: *views/[controller]/[action]/{Desktop|Tablet|Mobile|Tv|Console|Car}/index.cshtml*
	app.UseResponsive();

	var rewOpts = new RewriteOptions();
	rewOpts.Add(new DeviceAreaRule());
	app.UseRewriter(rewOpts);

	app.UseMvcWithDefaultRoute();
	app.UseCookiePolicy(); //Put this here, because there is an issue with the TempData if this is used before the UseMvc.
}

}
internal class DeviceAreaRule : IRule
{
private static readonly DeviceType[] SupportedDevices
= new DeviceType[] {
DeviceType.Mobile
//	DeviceType.Tablet
};
private static readonly IEnumerable<string> ExcludedPathPatterns
	= new string[] {
		  "/^Identity/.*$"
	  };

private static readonly IEnumerable<string> IncludedPathPatterns
	= new string[] {
		  "^/(Index)?$",
		  "^/Programs/.+$"
	  };

public void ApplyRule(RewriteContext context)
{
	var device = context.HttpContext.GetDevice();
	if (SupportedDevices.Contains(device) //Is a supported device, so we should have an Area for this device
		&& !IsExcluded(context.HttpContext.Request.Path) //Requested path isn't excluded
		&& IsIncluded(context.HttpContext.Request.Path) //Requested path is included
		&& !context.HttpContext.Request.Path.StartsWithSegments($"/{device}")) //Request path don't start already with the "/{device}" segment
	{
		var currUrl = context.HttpContext.Request.GetRawUrl();
		var deviceUrl = new UriBuilder(currUrl);
		var currPath = context.HttpContext.Request.Path;
		deviceUrl.Path = currPath.Value == "/"
						 ? new PathString($"/{device}")
						 : new PathString($"/{device}").Add(currPath);
		context.HttpContext.Response.Redirect(deviceUrl.ToString());
	}
}

private bool IsExcluded(string requestPath)
{
	return ExcludedPathPatterns.Any(pattrn => Regex.IsMatch(requestPath, pattrn, RegexOptions.IgnoreCase));
}

private bool IsIncluded(string requestPath)
{
	return IncludedPathPatterns.Any(pattrn => Regex.IsMatch(requestPath, pattrn, RegexOptions.IgnoreCase));
}

}`

@rpgkaiser Thank you very much,
Its look very interesting how is IRule and UseRewriter() to the pages.
But what is your pages file name and extension like? is it a suffix or subfolder.

The intention with this rewriting rule is changing the area portion of the URL.
We decided to create a whole area (one per supported device) to which redirect to.
So, whe the client navigates to "~/Page" our app redirect to "~/Mobile/Page", because our app have an Area named "Mobile".

It’s make sense and easier to look solve the problem. Sorry, for asking in more detail, I like to get a better understanding and how to find best solution to the problem.

How do you manage with PageModel and page codes?
Are the page code separate per device?
How so you manage shared common page code for UI between devices?

The main (and maybe the only one) problem with Razor Pages is to determine what page to associate with the HTTP request, due to in Razor Pages, C# code and Razor code are tightly coupled.
From that point, any other partial view to render works as expected, using the ViewLocationExpanders this library provide.

@rpgkaiser you in luck #297 Responsive Razor Pages view location expander is coming along with good progress.

Still have issue with Razor pages for Areas and the PR could be merged in the main branch.

Great news!

Great news!

Got a working concept with responsive razor pages using areas coming in with PR #339.
mobile

tablet

Finally feature completed with PR #297


Translation calendar.shortRunningText

Hi,
first of all thank you for your great work! It is great fun to configure the mirror.
I have a problem with the translation of the calendar.
In config.js I set lang: 'de'.
When I have an all-day event (for example a birthday) at the actual day (now), I get
first name last name hat Geburtstag	still 31 Minuten
The still should be something like noch or nach wie vor.
Can someone tell me where the translation take place?
I went through js/compliments/compliments.js, but I have no experience so far.
Thanks,
Fabian

@fabianhussl, this part unfortunally has no autotranslate yet. See https://github.com/MichMich/MagicMirror/blob/master/js/calendar/calendar.js#L15.

resolved #83
thank you @bitte-ein-bit then it's clear for me! so far no autotranslate - just still resp. until driectly written in the variables.


Directive results text may need refinement.

Description
Upon submitting a test result for a patient, the following message is generated:

Steps to reproduce
Submit a test result using the normal flow. The notification toast above is generated when a result is successfully submitted.
Expected behavior
The existing message is confusing to a user, as "Results" should refer to a header. The message should ideally read:
"See 'Results' to view past test results."
For bonus usability points, we may wish to consider rendering the bold "Results" word in the toast as a direct link to the results pane.

Great catch, @rin-skylight! Recommended copy:

Result for [Last, First] was saved and reported
See Results to view past tests

cc @emmastephenson


ivy-resume equivalent

It would be nice if there were a feature like ivy-resume to allow resuming the last completing-read session.

I am not opposed. It will need to operate by repeating the last interactive command, and then setting a variable such that selectrum-read will restore some previous state (limited most likely to the currently selected candidate and the current user input) after initializing. This will provide a better and more robust user experience than the implementation in Ivy, which is a giant hack.

Let me know how the new command works for you.

It works well. Thanks!

I noticed adding recursive minibuffer broke this feature!

Let me know if that fixes it.

Yes, fixed! Thank you!


Depth-Nerfacto + Masking = Very slow

Describe the bug
I'm trying to train depth-nerfacto with masking (depth + masks + alpha-transparent training). However, it is extremely slow when I don't move the images and masks to the GPU. This seems like a bug somewhere but I couldn't find it yet. I will continue investigating but wanted to post this in case someone has some intuition regarding where it might come from.
The key is that masking doesn't lead to a significant slowdown when using nerfacto without depth (especially due to the rejection sampling implementation). However, it somehow does when using depth-nerfacto with depth.
Slow
ns-train depth-nerfacto --pipeline.model.background_color "random" --pipeline.model.disable-scene-contraction False --data data --vis viewer_legacy

Fast
ns-train depth-nerfacto --pipeline.model.background_color "random" --pipeline.model.disable-scene-contraction False --data data --vis viewer_legacy --pipeline.datamanager.masks-on-gpu True --pipeline.datamanager.images-on-gpu True

Data
Happy to share the dataset if someone is interested.
This is with 50 images of 1920x1440 on a 4090.

@machenmusik adding you as I think you have previously worked with masks/ depth.
In particular, I'm looking for insights for why https://github.com/nerfstudio-project/nerfstudio/pull/2110 is no longer required for getting fast training with masks (makes zero difference in my experiments).


docs(v2): showcase personal site evantay

Motivation
I would like to showcase my personal open-source Docusaurus site on the official showcase.
Have you read the Contributing Guidelines on pull requests?
Yep, thanks for building this!
Test Plan
Tested locally:

Related PRs
N/A.

Hi @DigiPie!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at<EMAIL_ADDRESS>Thanks!

I signed the CLA (individual) a moment ago.


Correct error in Mapper instructions

It is plain "URL: http://example.com" not "(URL: http://example.com)"

Done with https://github.com/dotcomboom/gopherit/commit/62f602897b452bd785f9183065355bb5c2614947


support [ext] in output.filename (idea)

I'm thinking that something like:
entry: { 'app.js': ..., 'app.css': ... },
output: { filename:  '[name].[chunkhash].[ext]'  } // for prod env

would be useful, instead or in addition of Extract-Text-Plugin

Well, it's not really needed when you put the input like: {app: ['foo.js', 'foo.css'], bar: 'something.js'}


Changing Audio Output not possible on Android (Earpiece - Speaker)

Hi,
I am using opentok to voice only calls. Everything works as expected, but sound is playing on speaker.
I would like to switch from speaker to earpiece, but seems to be not possible.
I tried to use this plugins, but has not effect on opentok. (https://github.com/alongubkin/audiotoggle)
Is there any way to switch the sound output source?
Thanks,

You can switch speakers by calling the following before creating an instance of Session.
// voice calll
AudioDeviceManager.getAudioDevice (). SetOutputMode (BaseAudioDevice.OutputMode.Handset);
// or video call
AudioDeviceManager.getAudioDevice (). SetOutputMode (BaseAudioDevice.OutputMode.SpeakerPhone);
Please refer to this fork.
https://github.com/amatakasap/cordova-plugin-opentok/tree/feature/voice-headset

Hi, how can I install the plugin of "feature/voice-headset" branch and not "3.2.0"?
I changed this: cordova plugin add cordova-plugin-opentok
For this: cordova plugin add git@github.com:amatakasap/cordova-plugin-opentok.git#feature/voice-headset
But is not working.
Thanks,

Hello! I have this problem too. I'm using voice only calls and I really need this feature. @amatakasap  link is not working now, I get 404. Is there any workaround for this? thank you!

I succeeded in calling the method by correcting the latest version.
https://github.com/terikon/cordova-plugin-photo-library/pull/165

I succeeded in calling the method by correcting the latest version.
terikon/cordova-plugin-photo-library#165

Bro, what are you talking about?

I'm sorry. I was writing to a different issue.

The correct link is here.
https://github.com/amatakasap/cordova-plugin-opentok
I use this fork along with cordova-plugin-audiotoggle to make audio-only calls.
Step 1. Specify Type
// callType is 'voice' or 'video'
const session = OT.initSession (apiKey, sessionId, callType)

Step 2. Switch the speaker
// voice call on Android
window.AudioToggle.setAudioMode (window.AudioToggle.RINGTONE)

// voice call on iOS
 window.AudioToggle.setAudioMode (window.AudioToggle.EARPIECE)

Step 3. Replace the speakers (if necessary)
// Android
window.AudioToggle.setAudioMode (window.AudioToggle.NORMAL)

// iOS
 window.AudioToggle.setAudioMode (window.AudioToggle.SPEAKER)

try it.

The correct link is here.
https://github.com/amatakasap/cordova-plugin-opentok
I use this fork along with cordova-plugin-audiotoggle to make audio-only calls.
Step 1. Specify Type
// callType is 'voice' or 'video'
const session = OT.initSession (apiKey, sessionId, callType)

Step 2. Switch the speaker
// voice call on Android
window.AudioToggle.setAudioMode (window.AudioToggle.RINGTONE)

// voice call on iOS
 window.AudioToggle.setAudioMode (window.AudioToggle.EARPIECE)

Step 3. Replace the speakers (if necessary)
// Android
window.AudioToggle.setAudioMode (window.AudioToggle.NORMAL)

// iOS
 window.AudioToggle.setAudioMode (window.AudioToggle.SPEAKER)

try it.

I'll give it a shot! Thank you!

Hi @amatakasap is there a way to apply this feature also in this repo?
best regards


How to create user groups in GKE cluster

RBAC roleBinding & clusterRoleBinding API provide to create binding with kind: Group subjects. Is it possible to create groups on GKE. After going through lots of documentation, providing user group information is job of authenticator server. There are ways to use your own custom authenticator by using k8s webhook authentication system, but that requires setting special configuration in api-server which we cannot access directly on GKE.
My question is have you able to provide user group successfully in GKE using any kind of authentication system?

+1


ci/check-dependencies-merged-to-master.sh

This adds a new required Buildkite CI check -- as can be seen below, there's now a new entry -- buildkite/cardano-node/dependencies-at-master: https://buildkite.com/input-output-hk/cardano-node/builds/1494#d91bcbbd-8b4a-49ee-912e-0abec8926b25
When it fails, it provides output of the following kind:
bimap: master
cardano-binary: master
cardano-binary-test: master
cardano-crypto-class: cardano-crypto-class 0e26a4f00324100b4c34f2a9c7606ae03e94d7a1 not on master of https://github.com/input-output-hk/cardano-base
check:
curl --silent https://github.com/input-output-hk/cardano-base/branch_commits/0e26a4f00324100b4c34f2a9c7606ae03e94d7a1

Implementation

a mish-mash-of-bash is not the prettiest way to do it, can certainly be improved -- but it's a start

I think we should merge something like this, make sure it works and then move it to iohk-nix whne we are happy with it.

bors r+


What's wrong with schema and layout?

`{
  "schema": {
  "type": "object",
  "properties": {
    "name": {
		"type": "string"
    },
	"Objects": {
	 "type": "array",
	  "items": {
		"type": "object",
		"properties": {
		  "object": {
			"type": "object",
			"properties": {
			  "objectId": {
				"type": "string"
			  },
			  "attributes": {
				"type": "array",
				"items": {
				  "type": "object",
				  "properties": {
					"attributeId": {
						"type": "string"
					},
					"attrbuteName": {
						"type": "string"
					},
					"value": {
					  "type": "string"
					}
				  }
				}
			  }
			}
		  }
		}
	  }
	}
  }
},
  "form": [
      "name",
      {
          "key" :"Objects",
          "items": [
              {
                "key":"Objects[].object",
                "items": [
                    "objectId",
                    {
                        "key": "attributes",
                        "items": [
                            "['attributes'][]attributeId",
                            "['attributes'][]attrbuteName",
                            "['attributes'][]value"
                        ]
                    }
                ]
              }
            ]
      }
]
}`

Why I don't see "attributeId", "attrbuteName" and "value"?

This is probably an issue best handled by a question on stackoverflow.com.  In short, you need to use the full key like Objects[].object.attributes[].attributeId

You are right, thanks.

In general, my purpose is add appear Name of object when user input objectId. May be there is a better idea than add "attrbuteName" to schema and then customize it in layout?
Sample:

Start here for JSON Schema http://json-schema.org/learn/getting-started-step-by-step.html
And then for this library, https://github.com/json-schema-form/angular-schema-form/blob/development/docs/index.md#basic-usage and http://schemaform.io/examples/bootstrap-example.html are the best resources I have found.

Thanks @scottux
@person2713 please comment if you want to re-open or do not feel the question has been answered sufficiently.


Avatar with emoji is not displayed in room preview page

To reproduce:

Preview room #💩:matrix.org

Avatar is empty. It's not in riot-android / web.

Done

Validated in 0.3.13 ux_rework #1847


Added booter support, NullBooter and NetBooter

Added pkg/booter and updated uinit to use it.
pkg/booter defines a Booter interface that allows the creation of booting logic, e.g. network booting, local booting, and specific configuration.
A NullBooter and a NetBooter object have been included.
The booters follow a specification based on JSON, and the current implementation stores the content on VPD variables, but any key-value store can be used.

Things to fix before reviewing:

fixing linter warnings
adding unit tests

odd test failure. Only fails with go 1.0 and master, but doesn't fail with the same go version on my machine, and the output looks just ok, except that the exit code is 2.

What about the localboot / netboot stuff ?

What do you mean?


Making repo to community standard

Adding Contributing.md , code of conduct.md and license for making repo up to community standard.

Adding Contributing.md , code of conduct.md and license for making repo up to community standard.

well work on it


An error occurs when opening the command-line window

Description
To reproduce try to open the command-line window, e.g. by pressing q: in normal mode when the context is shown.
Neovim version
0.10.2
Expected behavior
No error should be shown.
Actual behavior
The following error is shown when opening the command-line window:
Error executing vim.schedule lua callback: ...vim-treesitter-context/lua/treesitter-context/render.lua:302: E11: Invalid in command-line window;  executes,
CTRL-C quits
stack traceback:
[C]: in function 'nvim_buf_delete'
...vim-treesitter-context/lua/treesitter-context/render.lua:302: in function <...vim-treesitter-context/lua/treesitter-context/render.lua:296>
Minimal config
local plugins = {
ts         = 'https://github.com/nvim-treesitter/nvim-treesitter',
ts_context = 'https://github.com/nvim-treesitter/nvim-treesitter-context',
}
for name, url in pairs(plugins) do
local install_path = '/tmp/nvim/site/'..name
if vim.fn.isdirectory(install_path) == 0 then
vim.fn.system { 'git', 'clone', '--depth=1', url, install_path }
end
vim.o.runtimepath = install_path..','..vim.o.runtimepath
end
Steps to reproduce

nvim --clean -u minimal.lua treesitter-context.lua (you can replace the treesitter-context.lua with any other large enough file where the context will be shown).
Move the cursor down until the context appears.
Press q: in normal mode to enter the command-line window mode.

https://github.com/user-attachments/assets/3e866dd5-1f29-4d8d-94f9-77d490ca7d08

@apollo1321 could this be from one of your recent changes?


Update README.md

Going to leave this open since there might be more things that will be added/changed.


fix(create-analog): restrain node 16 to 16.17.

Using 16.18 & 16.19 breaks Analog, let's retrains the version to the latest working Node16: 16.17
Fixes #532

This one should be updated also for the create-analog package.
https://github.com/analogjs/analog/blob/main/packages/create-analog/package.json

@allcontributors add @JeanMeche for infra


Rust build failures on some architectures

I've submitted rust-libnotcurses-sys for building on Fedora Rawhide, and am running into a problem with regards to a size_t argument. This type has implementation-defined size. Here's a failed build; they can all be found linked from here.
  --> src/bindings.rs:24:5
   |
24 |     __va_list_tag,
   |     ^^^^^^^^^^^^^ no `__va_list_tag` in `bindings::ffi`
error[E0432]: unresolved import `crate::ffi::__va_list_tag`
 --> src/plane/reimplemented.rs:5:5
  |
5 | use crate::ffi::__va_list_tag;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^ no `__va_list_tag` in `bindings::ffi`
error[E0308]: mismatched types
   --> src/notcurses/methods.rs:495:75
    |
495 |         error![unsafe { crate::notcurses_render_to_buffer(self, &mut buf, &mut len) }]
    |                                                                           ^^^^^^^^ expected `u32`, found `u64`
    |
    = note:    expected raw pointer `*mut u32`
            found mutable reference `&mut u64`
error[E0308]: mismatched types
   --> src/plane/reimplemented.rs:167:55
    |
167 |     unsafe { crate::ncplane_putnstr_yx(plane, -1, -1, size, cstring![gclustarr]) }
    |                                                       ^^^^ expected `u32`, found `u64`
    |
help: you can convert a `u64` to a `u32` and panic if the converted value doesn't fit
    |
167 |     unsafe { crate::ncplane_putnstr_yx(plane, -1, -1, size.try_into().unwrap(), cstring![gclustarr]) }
    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^
error[E0308]: mismatched types
  --> src/signal.rs:15:23
   |
15 |         Self { __val: [0; 16] }
   |                       ^^^^^^^ expected an array with a fixed size of 32 elements, found one with 16 elements

related: #5

Closing for now. Just commited https://github.com/dankamongmen/libnotcurses-sys/commit/5475b823562432458300a3181fd992dd3abbd841, https://github.com/dankamongmen/libnotcurses-sys/commit/917704943f40917b1630c80b1e597b37d1f72053 commits which simplifies and generalizes a lot of these fixes.

nice! i'll put the most recent one through fedora and debian and see if things have improved there.


Client Allocation Request for: Ai-Dapps

Client Allocation Questions
Core Information

Name: Ai-Dapps
Website / Social Media: aicon.online
Region: Asia excl. Greater China
DataCap Requested: 10TiB
Addresses to be Notarized: f1cooyvjngeup35k5qdjfklfeg4x2flombbn42yji
Notary Requested: MasaakiNawatani

@AICON-project Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hi @AICON-project , I have granted 1 TB for you. After you have made use of the allocation, you can come back to me and request for more. I will now close this issue. Thank you.


Include core formulae from API in Formula.all.

This is needed to allow Formula.all to behave as expected when using the API. Let's also (immediately, because it's broken) deprecate the CoreTap#formula_files method.
Fixes #15122

Let's also (immediately, because it's broken) deprecate the CoreTap#formula_files method.

This is kinda weird given it's a subclass so it can't really be "removed" and will be useful to keep around for the no-API case. But if it's deprecated in the sense that it will raise an error in the future without HOMEBREW_NO_INSTALL_FROM_API that makes sense.
LGTM though :+1:

This is kinda weird given it's a subclass so it can't really be "removed" and will be useful to keep around for the no-API case. But if it's deprecated in the sense that it will raise an error in the future without HOMEBREW_NO_INSTALL_FROM_API that makes sense.

Yeh, that's what I'm thinking. Ideally we should be moving away from much of caring about the path of a Formula given that it's not really needed and is kinda a made-up value for API installed.

Thanks for review @Bo98!


Added a working SignalR Chat page

Is this with the 4.0 branch as well? Very nice :+1: :100: :goal_net:
When we get the conflicts resolved I'll pull it in, so we can merge.
I'm going to move the old 2.x stuff into a new branch as well in case people still use that.

You can check it out here:
http://signalr-example.azurewebsites.net
Tried to not make any changes, just additions. So think the conflicts should be easily resolved.

Glad you did this on the 4.0 branch, did you have any other problems with VS2017 / etc?
Let me pull down the PR and take a look! :)

Thanks @MarkPieszak  :)
Did not really have any problems with VS2017 or Angular 4. Worked like a charm.
Publishing to Azure as well.
Next thing I want to add is Redux, so I can use Redux Dev Tools.
I'll start that next

We can always do a separate PR for anything else you want to do!

Not sure what you mean by this? A separate pull request?

Yeah if you want to add Redux for example, separate PR for sure :)

Working on the merge now

I'm having a heck of a time getting the chat example to connect.  Before the page renders I get an error saying: Failed to connect. Error: Error during negotiation request
Now I was thinking maybe it has to do with cross domain requests connecting to an Azure backend, but the weird thing is - I get this same error trying to run my own personal project with SignalR (was hoping the demo might show me what I was doing wrong).  Looks like the error occurs during the "negotiating" step (jquery.SignalR.js line 667).  It looks like the jQuery ajax call never actually runs.
Any ideas what I'm doing wrong?  Everything works fine in my own if I revert the project back to Angular 2.48.  Can't figure out why neither of these Angular 4 SignalR projects will connect locally.

I haven't tried In a little while, I noticed someone else posted the same issue w local host.
Not sure what could of changed all of this was working not long ago.. Ideally it shouldn't matter what version, it was working here with 4.0 here, have you tried pulling down this commit specifically seeing if it makes any difference?

Did a bit more digging and actually I'm getting an error before on line 671 of jquery.SignalR.js 'TypeError: Cannot read property 'apply' of undefined'

I'm not able to determine where this is happening with the Chrome debugger.  However if I switch over to IE11 it looks like it's happening inside '<EMAIL_ADDRESS>(line 3109)

Doesn't look like this file is included in Angular 2.4 so I'm guessing this must be the culprit.  Any idea what this might be?  Let me know if I should open a separate issue.

Ahh so this is an issue with IE, Object.assign doesn't exist on any version of IE ( way to go IE :disappointed: ), so you're going to want to include the polyfills in the ./Client/polyfills/polyfills.ts file.
https://github.com/MarkPieszak/aspnetcore-angular2-universal/blob/master/Client/polyfills/polyfills.ts#L6-L19
I might have to include the import 'core-js/es6/object'; one by default for this scenario.

I managed to solve this with a few different steps.
1.)  Uncommenting the polyfills from polyfills.ts fixed the SignalR error for IE11 but not other browsers.
2.)  It turns out there was a bug released with zone.js 0.8.8 (see here: https://github.com/angular/angular-cli/issues/6036).  Deleting zone from node modules and upgraging to 0.8.9 fixed SignalR for the other browsers.
Hope this helps!


zdns does not follow cnames during iterative mode ptr lookups

echo <IP_ADDRESS> | /opt/rdns6/zdns PTR --iterative
{"data":{"answers":[{"answer":"cnameptrtest.dirtside.com.","class":"IN","name":"<IP_ADDRESS>.in-addr.arpa","ttl":86400,"type":"CNAME"}],"protocol":"udp","resolver":"<IP_ADDRESS>:53"},"name":"<IP_ADDRESS>","status":"NOERROR","timestamp":"2023-12-04T16:33:42Z"}
Asked it for a PTR but it only gave me the intermediate CNAME. When not using iterative mode, I see the expected behavior:
echo <IP_ADDRESS> | /opt/rdns6/zdns PTR --name-servers <IP_ADDRESS>
{"data":{"additionals":[{"flags":"","type":"EDNS0","udpsize":512,"version":0}],"answers":[{"answer":"cnameptrtest.dirtside.com.","class":"IN","name":"<IP_ADDRESS>.in-addr.arpa","ttl":21600,"type":"CNAME"},{"answer":"acnamename.dirtside.com.","class":"IN","name":"cnameptrtest.dirtside.com","ttl":600,"type":"PTR"}],"protocol":"udp","resolver":"<IP_ADDRESS>:53"},"name":"<IP_ADDRESS>","status":"NOERROR","timestamp":"2023-12-04T16:35:50Z"}

This is "expected" behavior for that particular module. The raw protocol modules return back to you the exact output received from the server (recursive or authoritative server, depending on the mode). We aren't doing anything different in the recursive case here, <IP_ADDRESS> is just happening to helpfully also hand back the second record.
That said, obviously, most of the time you want to follow the CNAME, which is why we have the secondary lookup modules. I believe that the right course of action here is to create a ptr-lookup module that matches what we have for A and MX records, but for PTR lookups.

That's actually really weird. The only times you -don't- want to follow a CNAME are if the user requested a CNAME type or requested ANY records for the name. For every other record type, a CNAME return means: follow me.

I agree that it would be helpful beyond the few record types. I'd be fine
moving the logic from the a-lookup into a flag to follow CNAME and DNAMES
across all record types and then including the C/DNAME chain. MX is a bit
more complex because there are explicitly multiple lookups, and I think we
can leave that one be.
On Mon, Dec 4, 2023 at 12:51 PM William Herrin @.***>
wrote:

Well, yes. And no. And that's not really the point.
I'm trying to use zdns for some data collection at CAIDA. Discarding the
information about the CNAME would be bad. If there's a CNAME in the middle,
I want to know. But failing to follow it is also bad. That means I have to
deal with a bunch of extra logic in what is supposed to be a simple shell
script to go and resolve those CNAMES.
I don't just want to follow CNAMES to A and PTR records. I want it for
-every- record type. SOA records, MX records, NS records, whatever. Because
that's what a CNAME is.
So implementing a special module to follow CNAMES in A records and a
special module to follow CNAMES in PTR records is weird. It makes more
sense to me for it to be a flag to any lookup type. Follow them and give me
the complete chain. Or don't follow them.
—
Reply to this email directly, view it on GitHub
https://github.com/zmap/zdns/issues/347#issuecomment-1839168655, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABREUAO3IJAEKXF76RXUKDYHYETVAVCNFSM6AAAAABAGIZAO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGE3DQNRVGU
.
You are receiving this because you commented.Message ID:
@.***>

That makes sense to me. CNAME/DNAME are pretty consistent across record types. The "special case" ones are MX record (as you said) and "IP address" where both A and AAAA records are wanted. The latter one could probably be generalized by accepting more than one record type at a time. "echo www.google.com | zdns A AAAA" instead of just "zdns A".


[Feature] Add command bru.rmVar(varType, key) and/or bru.rmEnvVar(key)

I have checked the following:

[X] I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add
Add a command bru.rmVar(varType, key) that would allow users to unset a variable (equivalent of pm.environment.unset but more modular)
Javascript behavior (can be done in scripts tab) :
replace "toDelete" with the key to delete, and "envVariables" by another varType
bru = Object.entries(bru).reduce((acc, [key, value]) => {
  acc[key] = key === "envVariables" ?
    Object.fromEntries(Object.entries(value).filter(([k]) => k !== "toDelete")) :
    value;
  return acc;
}, {});

Mockups or Images of the feature

These three commands are available now in bruno
bru.deleteEnvVar(key)
bru.deleteAllVars()
bru.deleteVar(key)


split oeedgr8r 2016 and 2019 jenkins files

Signed-off-by: brmclaren<EMAIL_ADDRESS>

/test all


Added solution for divisibility for 100 program

Description
enter here if you have any details
Program Name -  Write a function to check Multiple of 100
Issue No.- #128

Type issue number after hash(#)

Checklist(self check)

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] My Filename is in camelCase format
[x] I have added Problem statement, Problem link in file.

wrong PR,  not assigned


Top Allegations chart is grouped by the allegation rule's paragraph and hard to read in Data Dashboard

In the Data Dashboard page, "Top Allegations" chart has multiple entries displayed within one bar and labels that are cut off, making it hard to read and understand the data. Seems like the chart is grouped together based on the paragraphs of the rule used for each allegation.

Steps to reproduce
List any steps to reproduce behavior

Navigate to Data Dashboard by clicking on top right profile icon.
Scroll to the "Top Allegations" chart

Expected behavior

Chart should be pushed to the right so that the text labels are clear and legible
1a. Use abbreviations: R. for rule, P. for paragraph
Charts should not be stacked, should have individual bars for each label (rule and paragraph should be unique)

Open Questions

Is there a way that users could configure what they want to see (grouped by rule, paragraph or just individual)?

Checklist

[x] Indicate bug severity on the right

https://hcsoc-data.hawaii.gov/public-data <---

Findings

we were able to fix the display so that now the "Rule" is showing on the y-axis instead of the "Paragraph" and we were able to fix the labels so that you can read them fully:

Other Findings (would require more time/work)
This is another potential option that would require more time:

Questions:

Which graph is preferred?
Should we invest time in implementing this change?
2a. To separate the data, we would need to write a loop and create new traces. RIght now, we are only plotting 1 trace as seen in the code here

Good work so far! I think the bottom is preferred! It's still showing as stacked, though, I think. But I like the different colors...Let's chat more. @rd-huerta

Would like to ensure rule and paragraph are their own line items, does the bottom allow for this?
E.g. the following are all unique lines:

Rule 1, Para 2
Rule 1, Para 3
Rule 3, Para 2

The implementation of the second graph would be more difficult. Also, we could have a really big graph horizontally given that there are several paragraphs in the system.

would it make sense to make the graph "stack" vertically then similar to how it is now? while obviously "unstacking" each rule/paragraph appropriately. and have users scroll within the box to view? i mean, that's awful but it would work for now.

From our perspective, there are a couple options:
Solution 1: We have a solution that can be implemented right now. We would need to spend a little more time refactoring the code and writing tests.

Solution 2: Unstacking/ungrouping the bars. This is a heavier lift that would require more time investment. We could use the same bar chart shown in the image above, but reduce the size of the bars to accommodate the 10 data points. We aren't sure this is the best approach, however.

Yes, as part of this card, would need to ungroup the bars. The users currently need each bar to be displayed separately such as this:

Met with @rnair-tw, @rowsnr , and @christina-luong to discuss which graph to use. Waiting on feedback from NOIPM.

Clarified with NOIPM, they like to screengrab the chart for reports etc, so does not work for them to have anything stacked (i.e. need to hover over it to see details). Instead, need the following:

All bars are separate (Rule 1, Para 2; Rule 1, Para 3; Rule 3, Para 2 are all their own line)
Only display the top 10 bars

Still needs some work, but here are the changes we have made so far:

I think this is looking good. Any chance we could push the y-axis title further to the left? Also the x-axis title is vague. Is that the number of allegations received? @rd-huerta @rnair-tw

What's been done:

adjusted the y-axis title
changed the x-axis title to "Number of Allegations"

What still needs to be done:

modify tests to account for the new structure of the graph

Questions

What is directive? Is it needed, or can we use just the rule & paragraph?

In the code, we are seeing some examples of directive || rule

Tests are passing. Tomorrow we will do a bit of refactoring and then a desk check.

We are blocked from doing a desk check by tests that are not related to our work failing in the pipeline. Once the pipeline is fixed, our changes can be pushed to the CI environment.

I talked with @rowsnr we decided to limit the paragraph text on the left size of the graph to 40 characters and include the ellipsis (...) at the end when this happens. If the paragraph is smaller than 40 characters there is not problem. Also, she suggested abbreviating paragraph to par. Finally, the hover text will be added back with the full paragraph text.

The allegations chart in the [data page] (https://noipm-production.herokuapp.com/data) is cutting the name of the rule + paragraph displayed on the left side of the chart.

@heliofreitastw Received some feedback on the Top Allegations chart in prod. The bars appear to be merging likely due to lack of space. Currently exploring the possibility of limiting Top Allegation to Top 5 or Top 8, but pending feedback from Christian.

Christian would prefer that we limit to Top 8 Allegations (or more).

Verified top allegations chart is showing top 8 allegations, and they are no longer grouped together and hard to read.


EOG Pass Improvements

[x] Doc URL to all nodes https://fraunhofer-aisec.github.io/cpg/CPG/specs/eog/ #1760
[ ] when instead of the current map
[x] createEOG() -> handle()?
[x] pushToEOG() -> connectWithCurrentPredecessors()?
[ ] nextEdgeBranch has to be set for branching nodes
[ ] nextEdgeBranch does it work with nested if?
[x] Add doc how to handle new nodes? createEOG / pushToEOG / nextEdgeBranch / ...
[ ] improve handleWhileStatemenet maintainability

I used attachToEOG instead of connectWIthCurrentPredecessors.

Yes, nextEdgeBranch works with nested ifs, the EOG-edge of the outer if, when going from the root node to the first node in the Then-Statement will have branch value true. This first node would then be the first node in the condition of the inner IF. Only after the condition evaluation of the inner IF will there be an EOG-edge to the root node of the inner IF, and then to the inner Then-Statement that then has nextEdgeBranch set to true again


badge not hiding on 0 entered.

neither the hide method nor the 0 input can hide the badge...

me ，two

me,too

neither the hide method nor the 0 input can hide the badge...

该问题是因为重复创建了BadgeView。应该让BadgeView只创建一次。

The problem is
if (mBadgeNumber < 0) {
mBadgeText = "";
@Override     public WynBadge setBadgeNumber(int badgeNumber) {         mBadgeNumber = badgeNumber;         if (mBadgeNumber < 0) {             mBadgeText = "";         } else if (mBadgeNumber > mMaxBadgeNumber) {             mBadgeText = mExact ? String.valueOf(mBadgeNumber) : mMaxBadgeNumber + "+";         } else if (mBadgeNumber > 0) {             mBadgeText = String.valueOf(mBadgeNumber);         } else {             mBadgeText = null;         }         measureText();         invalidate();         return this;     }
Try editing it in your source since apparently the developer ditched the project 2 years ago

I stumbled upon this issue but found a (rather hacky) way to solve this without having to modifying the library yourself
If you use Kotlin in your project, you can use this extension function snippet
// Extensions
fun QBadgeView.setup(count: Int, targetView: View) {
    this
            .setBadgeNumber(count)
            .setBadgeGravity(Gravity.TOP or Gravity.END)
            // add other setter / options according to your own need
            .bindTarget(targetView)
    if (count == 0) {
        val parent = this.targetView.parent
        if (parent is ViewGroup) {
            parent.children.forEach { child ->
                if (child is QBadgeView) { child.isVisible = false }
            }
        }
    }
}

// Usage
private fun setupView() {
    // val count = someMethodToGetCount()
    // val targetView = the view from findViewById / viewBinding / kotlin_synthetic
    QBadgeView(context).setup(count, targetView)
}

Basically, we just simply set the BadgeView's visibility to GONE when our number / count is 0
val parent = this.targetView.parent // "this" is the BadgeView object
        if (parent is ViewGroup) {
            // Iterate the parent to search for BadgeView object
            parent.children.forEach { child ->
                if (child is QBadgeView) {
                    child.isVisible = false  // If it's a BadgeView, we set visibility to gone,
                                             // isVisible is just a nicer way to do it from core-ktx library
                                             // otherwise just use setVisibility( ... )
                }
            }
        }

Hope this helpful


Is it installed temporarily just for the build where the task is defined?

Or will all other builds in all other build pipelines in the project be suddenly capable of using the key?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ce9d017-fc43-c904-d94b-87cf91265ffc
Version Independent ID: ecf3b0b7-6c2c-1cd9-33a9-2cf562932e2b
Content: Install SSH Key
Content Source: docs/pipelines/tasks/utility/install-ssh-key.md
Product: devops
GitHub Login: @erickson-doug
Microsoft Alias: dastahel

Keep-alive

Thanks for your question. It looks like your question isn't an issue with the documentation, but an issue or question specific to your implementation or a bug in the product itself.
For help with a specific task, here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot

If you've encountered an issue with the product itself, to make sure it gets in front of the right people, please submit your bug here.
If you have an idea for improving the product, please submit your idea here.


Add configuration/flags infrastructure

There are several sorts of configuration options that the client might want to set:

The allocation algorithm
Parameters to the algorithm, to configure various heuristics
Logging/tracing parameters
Enabling self-consistency checks (e.g., the regalloc checker)

Right now, we just have the RegAllocAlgorithm enum that folds together item 1 and item 4 above (algorithm and checker-enabled flag). Ideally, we would have a "settings" or "flags" or "configuration" struct passed to the main entry point, and a way to construct this from environment variables, or command-line flags, or other client-provided configuration sources.

I was thinking we could have a variant of allocate_registers, called allocate_registers_with_options, and that would take in a AlgorithmWithOptions enum instead of a RegAllocAlgorithm.
Then AlgorithmWithOptions would have one member attribute that's one of LinearScanOptions or BacktrackingOptions, so each can have its own settings. Then other common options can be other attributes of the parent data structure. All these new enums would implement the Default trait, so one can use the function ergonomically like this:
allocate_registers_with_options(func, AlgorithmWithOptions {
  algorithm: Backtracking {
    vreg_coalescing: false,
    ..Default::default()
  },
  request_block_annotations: true,
  ..Default::default()
}, rreg_universe)

It's a bit verbose, but that should cover all our uses cases. The other function that just takes in a RegAllocAlgorithm could stay, for users who don't care about specific features.


User >: Any In SwaggerSecurityExtractors

Hey guys. I was looking through the security templates and code and realized that the security extractors have the type parameters User :> Any. For example def basicAuth[User >: Any]:
I'm wondering: Is this a feature, or is this something that should be fixed?
I'd like to wrap the request with the data generated by the authentication process, through play's play.api.mvc.WrappedRequest with the WrappedRequest's type parameter being the type of the generated data.

Ah. I see. You don't pass the request over to the code modified by the user. So it doesn't matter. Whatever data that is needed is passed directly by type to the method changed by the user.

yeah, we don't pass authentication information to the controller as for now, but there is a ticket for that.

Hi, any news or ETA on this? I would like to get SecurityExtractors information in my controllers. Is there any way to access that info from the controllers. Or maybe getting de request itself?

@ashmcleod Can't find the ticket, may be I've confused it with comments in the code :) You are welcome to create a ticket for that :)

Hi slavaschmidt,
I think that my request is the same as moishy90's, to be able to get SecurityExtractors generated data in the generated controllers in some way. Do I have to open a new issue for this? or this one may be adecuate?
Is there any way i can get that data modifying de templates?

Let's leave it here for now.
The idea is to get the data obtained by the SecurityExtractor directly into the controller as a parameter.
The play.api.mvc.WrappedRequest @moishy90 is talking about is a bit low-level for our approach, I don't have a direct idea how to do this with the API-first approach. It might very well be doable but I can't answer the question right now.


Adding an event handler for the post 'pre-render' event to rewrite in…

Taking a stab at issue #11, as I needed the fix for it.
I added inline comments.
I'm not a ruby dev by any stretch of the imagination, so please, rip it apart if necessary :).
I did bundle the script into my own site as a _plugin, and it seems to work properly, though there could be other caveats/issues I'm not thinking of / covering.
In action (right now) at https://www.calvinallen.net (scroll down a bit, and you'll see the inline images).  The source for the blog is under my github profile for the markup.

how do I merge this into my branch... it says unknown repository so I'm not sure I can, where'd you get it from?

If you can't cherry-pick, maybe try to backport the commit

I tried downloading this as a patch through here and then applying it but I just kept running into errors. I'll cycle back to it another time. doesn't seem like a high priority.