Ensure emoji flags adhere to unicode spec

See similar issue in behdad/region-flags#8.
"The valid flags used to be less clearly specified, but they are defined in the newest (v2.0) spec, http://unicode.org/reports/tr51/
"ED-14. emoji flag sequence — A sequence of two Regional Indicator characters, where the corresponding ASCII characters are valid region sequences as specified by Unicode region subtags in [CLDR].
"Those Unicode region subtags are based on BCP47, but have some small changes (including http://unicode.org/emoji/charts/full-emoji-list.html#1f1fd_1f1f0."

I found a compact test page for this:
http://www.unicode.org/emoji/charts/emoji-style.html#emoji_emojifont that actually calls for "Noto Color Emoji" first in the style sheet for the page.
These flags showed as "unknown flag" when I tested:
BL = Saint Barthélemy; BQ = Carribean Netherlands; DG = Diego Garcia; EA = Ceuta & Melilla; EH = Western Sahara; FK = Falkland Islands; GF = French Guiana; GP = Guadeloupe; GS = South Georgia & the South Sandwich Islands; MF = Saint Martin; MQ = Martinique; NC = New Caledonia; PM = Saint Pierre & Miquelon; RE = Réunion; TF = French Southern Territories; WF = Wallis & Futuna; XK = Kosovo; YT = Mayotte

By default we don't build these for NotoColorEmoji. There's concern that the status of and appropriate flags for these territories are disputed.
I haven't tested this for awhile, but we do have resource data for these based on the wikimedia images and one ought to be able to build a font with them by changing the FLAGS variable to ALL_FLAGS in the Makefile.


Create carto package json

https://github.com/CartoDB/onpremises/issues/560
:eyes: @lekum @ivanmalagon
{
  "builder": {
    "repo_url": "https://github.com/CartoDB/cartodb.git",
    "tag_format": "v{VERSION}",
    "manifest": "carto-package.json"
  }
}

Would it be possible to use semver with the three period-separated number instead of abbrevitated versions as 3.0?

Not all packages have patch versions. e.g: zip, unp, postgresql (version 10+) only use two numbers for versioning. I mean, I can add a .0 but it won't always make sense.

Jumping on board to split the assets and Builder versions.


Link to categories card opens wrong card

Open Comms SE - http://utilsolutions.esri.com/datadictionary/index.html?cacheId=bd338e96f47941c191f781c518460c50
Open Categories
Open C:Copper
Expand Asset Group for Comms Junction Object
Click the link button next to Copper
Opens the wrong card

installed fix here
http://utilsolutions.esri.com/datadictionary/index.html?cacheId=bd338e96f47941c191f781c518460c50

Verified.


LND unable to open databases

My node crashed and upon recovering via SD card change, I started receiving the following error when LND attempts to start:
raspberrypi lnd[1532]: unable to open databases: unable to open local channeldb: unable to create new channeldb: writeat /home/bitcoin/.lnd/data/graph/mainnet/channel.db: negative offset
Here is my debug:
https://termbin.com/wrfx7
Thanks!

You can ask to confirm on the LND Slack https://dev.lightning.community/ or github to confirm but this looks like a database corruption to me.
Will likely need to recover from the SEED and SCB to have your channels force closed and return onchain after the timelock:
https://github.com/rootzoll/raspiblitz/blob/v1.7/FAQ.md#2-recover-from-wallet-seed
See https://github.com/rootzoll/raspiblitz/issues/2532 for similar.
Use stable hardware and a UPS to avoid power cuts!


Add function for using higher k8s version from rapid channel

Validate results are here.

GCP service creation with k8s 1.22,1.21,1.20 are all validated
https://test.infrabox.datahub.only.sap/dashboard/#/project/LabelTrigger/build/35/2/job/test
https://test.infrabox.datahub.only.sap/dashboard/#/project/LabelTrigger/build/36/4/job/test
https://test.infrabox.datahub.only.sap/dashboard/#/project/LabelTrigger/build/37/1/job/test


[Feature Request] Debuggable wrapper functions

@beartype dynamically wraps each decorated callable with a unique wrapper function efficiently type-checking that callable. That's great, because efficient. But that's also currently invisible to debuggers, because @beartype fails to register the Python code underlying these wrapper functions with the little-known standard linecache module.
This feature request tracks work towards rendering @beartype compatible with debuggers. For now, please refer to this superb writeup by witty QA strongman @posita for a detailed discussion of the exact issue under discussion here – complete with the inevitable working solution infused with wisdom by cautionary AI futurologist @TeamSpen210.
Humble gratitude to both @posita and @TeamSpen210 for finally shaming me into doing this thing that desperately needs doing.

[Mentioning #85 explicitly to take advantage of GH's auto-linking features….]

[Mentioning #84 explicitly to take advantage of GH's auto-linking features….]


Error: The 'cache' field on 'RequestInitializerDict' is not implemented.

Started seeing this error when using AWS S3 SDK to GetObject in a Cloudflare Pages App, which runs on workerd:
✘ [ERROR] Error: The 'cache' field on 'RequestInitializerDict' is not implemented.

 at FetchHttpHandler.handle
  (file:///.../node_modules/@smithy/fetch-http-handler/dist-es/fetch-http-handler.js:77:30)
      at null.<anonymous> (async

I will attempt a downgrade. I may try a standalone app to share.
Update pinning to 3.2.5 resolves the error.

Also running into this... cache setting is not implemented in Cloudflare workers.

Same, cloudflare workerd runtime.
Had to downgrade to 3.645.0
"@aws-sdk/client-s3": "3.645.0",
"@aws-sdk/s3-request-presigner": "3.645.0",

I believe the error is here: https://github.com/smithy-lang/smithy-typescript/blob/main/packages/fetch-http-handler/src/fetch-http-handler.ts#L115
This is the breaking commit: https://github.com/smithy-lang/smithy-typescript/commit/cf9257e5c37a2eb12d8df257e441b9bf7cc51158

https://github.com/cloudflare/workerd/issues/698

We will accept the patch once approved, but until then there is a workaround posted in the linked issue
const client = new SDKClient({
  requestHandler: {
    // Cloudflare doesn't support the cache option, so we remove it.
    requestInit: () => ({
      cache: undefined,
    }),
  },
});

released in<EMAIL_ADDRESS>

confirmed fixed for me with latest aws client s3 + v3.2.8 of fetch-http-handler


Rename our Primary branch to Main

Follow the instructions outlined by core K8s to do so -> https://www.kubernetes.dev/resources/rename/

Completed!


Cannot read property 'properties" of null

I tried to get it work with Ninja physics, but that always gave me the error: "Cannot set property 'game' of undefined" in phaser-ninja.physics.js.
Since I'm not using a lot of ninja physics yet, I tried it without, but now I always get:
"Cannot read property 'properties' of null" in phaser-tilemap-plus.js.
Did I forget something in the installation?

Hi,
It wasn't meant to be used with Ninja physics, but only with Arcade physics, sorry!

I am getting this same error attempting to use this with p2 phsics. The following (coffeescript) works without phaser-tilemap-plus:
# PRELOAD

@game.load.tilemap("tilemap1", @Assets.tilemap1, null, Phaser.Tilemap.TILED_JSON)
@game.load.image("tileset1", @Assets.tileset1)

  # CREATE

map = @game.add.tilemap("tilemap1", 16, 16, 700, 500)
map.addTilesetImage "tileset1"
tiles_layer = map.createLayer "Tiles"
tiles_layer.resizeWorld()

But as soon as I add the following line at the beginning of the create function:
@game.plugins.add Phaser.Plugin.TilemapPlus

I get the following error from the @game.add.tilemap line:
bundle.js:65102 Phaser.Cache.getJSON: Key "tilemap1-TilemapPlus" not found in Cache.

and from the same line get the following error as well:
bundle.js:2821 Uncaught TypeError: Cannot read property 'properties' of null
    at new t (bundle.js:2821)
    at Phaser.GameObjectFactory.tilemap (bundle.js:2821)
    at PlayState.module.exports [as create] (bundle.js:1540

I would really appreciate support, because I'm not sure of any other way to get Tiled animations exported to Phaser.

Hi, I tried to clone your repo, and ran "npm i" and "npm run dev" as per your instructuions.
I get the following:
$ npm run dev

><EMAIL_ADDRESS>dev C:\Dev\phaser_game
> sh build.sh && ./node_modules/.bin/webpack-dev-server --content-base . --inline --hot

build.sh: line 2: ruby: command not found

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "dev"
npm ERR! node v6.11.4
npm ERR! npm  v3.10.10
npm ERR! file C:\windows\system32\cmd.exe
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>dev: `sh build.sh && ./node_modules/.bin/webpack-dev-server --content-base . --inline --hot`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev script 'sh build.sh && ./node_modules/.bin/webpack-dev-server --content-base . --inline --hot'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the snood-pinball-coffee package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     sh build.sh && ./node_modules/.bin/webpack-dev-server --content-base . --inline --hot
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs snood-pinball-coffee
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls snood-pinball-coffee
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Dev\phaser_game\npm-debug.log

I suspect other dependencies are needed.

putting  game.plugins.add(Phaser.Plugin.TilemapPlus); after game.add.tilemap seems to fix it

I'm using Phaser CE and I have a preloader state.  When I move all the code to load assets into the play state everything works.  My assumption is there is something about preloading in a different state and reading from the cache

Using console.log( game.cache._cacheMap )  when loading everything together shows the new cached tilemap tilemap-TilemapPlus.  The tile map is not part of the cacheMap when using a preloader state

I am too. And when I move the code to add plugin in Boot state, everything works just fine.


4466 allow multiuser admin to set a new default quota

This closes #4466.

Frontend tests were OK :+1: (details)


New release

Hi there,
Thanks for providing this project, it's been super handy!
Would you mind cutting a new release for the latest code in the master branch? There's some features in there that would be a bit easier to use with a release tag
Take care!

Hi,
I don't mind becoming a little agile here, but the are too few features to release.  We will wait for another two weeks of contributions and do another release after that.


View volume percentage

Hey, i have updated the UI of the application allowing users to view the percentage of volume when adjusting the volume slider.
Please check my changes.

Thanks so much for contributing! That's a great idea and I like how you implemented it!


Update CHANGELOG.md for 0.1.1 release

Pushed a tag of 0.1.1 and this is the associated changelog

Coverage remained the same at 57.82% when pulling cfcc28946cd87b9d64087c5e49e7733db0436863 on release-0.1.1 into 28de954c12233a645b1eda7c8a7b0bd9c4582b74 on master.

LGTM


Unable to interact with RDP session. Mouse/Keyboad not working.

First off, thanks for building this as it appears to be exactly what I was looking for!
This is more of a question. I'm able to successfully establish an RDP session and see the remote desktop but am unable to interact with session. Seeing the same issue with an SSH session. I've tried modifying the z-index of canvas with no luck. My client app is build with React and I've followed the React component example from guacamole-lite repo.  Have you seen this issue or have any suggestions?

I might have answered my own question. Looks like the client application is responsible for passing keyboard/mouse events along :)

Hey, good to hear people are successfully using it!
Sounds to me like you solved the problem, so I'll close the issue tomorrow.


Question - Math comparison?

Hi, this is more of a question/maybe feature request.
Do you think it'd be reasonable to implement some sort of math-based comparisons (<, <=, ==, >=, >) in the math category?
I received a requirement to apply styling on elements on a list past a certain index eg
{{#each Items}}

 ...

{{/each}}

I'm wondering if this sort of thing might be useful in a general case, given there's already other useful math functions.

And for the record, one can technically achieve this right now with a little math trickery & the fact that 0 is falsy:

But that might be a bit too clever.

Maybe instead of the Math helpers, use the 'Handlebars.Net.Helpers.DynamicLinq' ?

@Zulu-Inuoe , a new NuGet will be released shortly.
With:
Equal,
NotEqual,
GreaterThan,
GreaterThanEqual,
LessThan,
LessThanEqual

#30

Sorry in being late responding to this. Thank you so much!
We pulled the latest version and the math puzzle from before is now gone 😄


PHPStan 0.12.82 compatibility

In PHPStan v0.12.82 release there were changes related to how static keyword is resolved. This caused some issues in Larastan. Need to investigate and fix.

Was it this PR? https://github.com/phpstan/phpstan-src/pull/474

Was it this PR? phpstan/phpstan-src#474

Probably.

Most of the errors in my project can be summed up to the following snippet:
$this->userOrNull = $office->user()->active()->first();

Model scopes Builder parameter is not ignored
Method Illuminate\Database\Query\Builder::active()  invoked with 0 parameters, at least 1 required.
Model type is lost on relations Builder: Property \MyClass::$userOrNull (App\User|null) does not accept Illuminate\Database\Eloquent\Model|null.

Hope it helps.

@shaffe-fr Thank you for the information!
I also changed the master branch so we can see which tests are failing. Here is the failing tests from the actions.

I spent a little bit of time on this. But couldn't come up with a good solution. So if anyone else is interested, we can collaborate on a solution!

Should I dare to mention Ondřej Mirtes? What if he will points out bad design in Larastan??

First one being
Method Tests\\Features\\Methods\\ModelExtension::testLockForUpdate() should return
Illuminate\\Database\\Eloquent\\Builder<App\\User> but returns
Illuminate\\Database\\Eloquent\\Builder<Illuminate\\Database\\Eloquent\\Model>.

in
https://github.com/nunomaduro/larastan/blob/f74befd87b7278285cbf6f1597509cbfaca46bf8/tests/Features/Methods/ModelExtension.php#L284-L288

Don't hesitate to reach out to me as I'm probably the only person that can help you here :) it would be great if you could isolate what Larastan extensions started behaving differently between PHPStan 0.12.81 and 0.12.82 then we can move on to a solution.

One side-effect of 0.12.82 changes is that generics + MethodsClassReflectionExtension/PropertiesClassReflectionExtension behave a bit differently. If you introduce new methods based on a template type variable (like @template T), the extension isn't going to work unless you introduce the object (or more specific) bound - @template T of object.
But of course the problem can be something completely different. For example if you have some custom types that override getProperty or getMethod, it now looks differently: https://github.com/phpstan/phpstan-src/blob/ed1736c045a29da4673ccbbbce7e9305841b00f9/src/Type/ObjectType.php#L512-L551


IMU erros and fluctuations readings when there is not movement.

Hi, I can see unusual fluctuations of IMU when it is resting, it happens in two different OAK-D in two different branchs, main and devel. It make it unusable not only to use it as main IMU, even to fuse it with other sensors
Also I noted likely there is not mag info or quaternions in any of the 3 modes after the linearization update (I didn't check many the IMU before).
Not sure what is the advantage of lose quaternions/AHRS and mag respect the other 3 new modes, more seeing the behaviour, which in discord someone told me is normal, even having errors as gyro data, or acc data not found.
I'm sure it is not and before make permanent changes, or give fast generic answers, the changes and documented issues  should be properly checked and to avoid users became betatesters instead users.
Later comes other derivates issues that comes to that decisions as that even to get that unreliable readings it force me to use a extra node to fuse in a CPU/SO that is not realtime and add latency, something that the IMU does itself much better (lots of filers in its Cortex M0 built in MCU) and without CPU cost.
Can please Luxonis check again and test the IMU behaviour and give a official  position about this?, because if this is the normal IMUs behaviour,and  it is the better we got in 1 year, seeing the results, for what I would want buy another OAK-D with IMU? For what a S2 instead a OAK Lite?
Worse if future customers start to make me questions about the IMU  if I include a OAK-D in my products. I'm sure they will not accept a is normal as answer, the same for other unresolved issues I'm having.
Sorry by be a PITA, I know it, I just do my thing.
https://youtube.com/shorts/YkSzmqhkz1Y?feature=share
https://youtu.be/jjtVldqyEhU

Any official response about this, is it what I can expect from OAKs IMUs or this will be improved.
I need planning the next projects and this IMU behaviour don't allow I  use OAK cameras.


dehumidifierMode values

Hi,
Thanks for publishing the plug-in! Some questions: t

The documentation says that dehumidiferMode only has two values: auto and dehumidifying. The example configuration has:

"dehumidifierMode": 9
Can you confirm what are the valid values for dehumidiferMode in the .json config file?

I have two Frigidaire dehumidifiers (model FGAC5044W1). Both dehumidifiers are in the same account. Does the plug-in support more than one dehumidifier?

Regards,
Randy

Hi

Homekit only has two modes for dehumider either "Auto" or "Dehumidifying". In contrast, the Frigidaire has 4 modes - Auto, Dry, Continous, and Quiet. Rather than the plug-in being hardcoded to "Dry" for Dehumidifying", it allows the user to select what Homekit "dehumidifying" mode map to which Frigidaire function. In the example configuration "9" is Quiet mode. The UX configurator (e.g. .json) set the default value to "Dry",  if the dehumidifierMode attribute is not set or not in the configuration file the defaults to "Dry". I will update the readme to make this clearer.

Yes, it written to support multiple devices. When the plugin starts, it automatically reads all appliances in your account, if the appliance is a dehumidifier it exposes it to Homekit. You can confirm the correct mapping by looking at SN in properties of devices when it is created in the Home App. If this doesn't work please let me know, this is not a use case I can test since I only have one device, but the plug-in is written to support multiple appliances at once.

Thanks. Yes, it would be good to document the integer values to use for auto, quiet, and continuous as well.
Regards,
Randy

Done,
It's now publish in the Readme in the repo and the package will be publish shortly. Noted the Air Purifier attribute was incorrect, updated the configure (.json) the code and document. Shouldn't be impactful, unless you disable the Air purifier in your configure, otherwise will need to change enableAirFilter to enableAirPurifier. UX will also clear and fix it as well.

Thanks!

Document updated and packaged publish.


Spelling and Shellcheck

Fixes some whitespace, spelling, and Shellcheck issues. I'm sure I missed some too, but this at least gets some of the quick n' dirty ones.
I also noticed a few errors with the word "crap" in them. I think it's funny, but they might be worth changing?
I might add a Github pipeline for https://vale.sh in a future PR if anyone is interested too.

Based on those ci failures, me thinks those shellcheck changes may not be ideal (or they're pointing out files that really ought to have been checked before weren't?) - I don't have time to investigate at the moment. I'll poke it more later.


请问编译bash tools/build-standalone-lib.sh出现错误

ERROR: /home/deep_learing/mace-master/WORKSPACE:14:1: name 'http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:24:1: name 'new_http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:35:1: name 'new_http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:46:1: name 'new_http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:57:1: name 'new_http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:68:1: name 'new_http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:80:1: name 'http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:89:1: name 'http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:98:1: name 'new_http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:115:1: name 'http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:144:1: name 'new_http_archive' is not defined
ERROR: /home/deep_learing/mace-master/WORKSPACE:155:1: name 'new_http_archive' is not defined
ERROR: Error evaluating WORKSPACE file
ERROR: Skipping 'mace/libmace:libmace_dynamic': error loading package 'external': Package 'external' contains errors
WARNING: Target pattern parsing failed.
ERROR: error loading package 'external': Package 'external' contains errors
INFO: Elapsed time: 0.082s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

Bazel的版本高了，请使用0.13.1版本


Error on Console

https://mclo.gs/lD8pJ25
This keeps showing up when I log out of the server.
Using latest versions of Simple Voice Chat and Server Replay 1.20.1
The server doesn't crash or anything but idk, thought it might be worth looking into.

Thank you for the report, this is a duplicate of #35


TextInput type email

Is there any way to get an input type of email, so it follows the same semantics as normal email input fields?

Yes, see https://tabrisjs.com/documentation/latest/api/TextInput#keyboard

Ah, perfect!


Update install-policy-framework.md

changes for the open source website

@ycao56 Thanks for the feedback, i made a couple of adjustments let me know if it is aligned appropriately

looks good!

/assign @qiujian16
/assign @mikeshng
please review and merge.

commit needs signoff

@dockerymick could you please rebase and sign off on your commits/PR. Ping me on slack if you need some help regarding the dco sign off part. Thanks.

Closing this PR so that I can sign-off as requested. Thanks @mikeshng for helping with the sign-off! I appreciate you


ES6 support?

I have using native-toast in my NodeJS projects with great convenience (Thanks!).
Now I am on a Python (with Flask) project and would not be able to use NodeJS. I was wondering if there is a way to use ES6 import of the native-toast library in some manner.
Thanks

Oops. Just realised that I can simply browserify the require and use it on a browser without nodejs.


fix: README link fixes & formatting

Description

Review broken links
Autohighlight/Format code examples using the appropriate tag.
Blank target for third-party links

Doesnt' look like target="_blank" works on GitHub. I tried the commit here https://github.com/clerkinc/clerk-sdk-node/tree/6ddace8c502524e04d8bcb010cea1d8424780796 and they don't open on a new tab.
More info: https://stackoverflow.com/questions/41915571/open-link-in-new-tab-with-github-markdown-using-target-blank
We should try and see if there's another way to do it and if there isn't, we should revert those changes to make everything looks cleaner.

@nachoiacovino  Thanks for your comment!

I would keep the formatting as it is since I would not consider GH as the only place  markdown is parsed
Also if and when GH supports it, it will probably be in the format that the standard supports (which is HTML in MD).
For the clean part, I do not have any strong feel about it, the only thing is that the full link tag is more expressive.


CI: Ensure at most one simultaneous run per PR

Updating a PR will cancel all the current runs
We still keep the runs on standard push, by using head_ref which is defined only on PR events or falling back on run_id which is unique otherwise
Closes #225.

I intentionally only did this for common first, in order to force an update of the PR with windows covered, and then check that all common-based workflows were indeed cancelled.

Thanks, this is great!
Love the meta-level testing :heart: :smile:
I'll let the CI finish and then merge.


bug: Wrong HL color for heading borders

Neovim version (nvim -v)
0.10
Operating system
Windows 11
Terminal emulator / GUI
Wezterm
Describe the bug
I have borders turned on for headings but the color is not the same as the main bg color. Im not sure if this is a bug, or what the correct hlgroup is for heading borders. This is what it looks like:

It seems to be using the fg color instead of the bg color?
This is the case for all headings at all levels:
# Heading 1

## Heading 2

### Heading 3

#### Heading 4

##### Heading 5

###### Heading 6

This is how my colors are set:
RenderMarkdownH1 = { fg = theme.rainbow.rainbow1 },
RenderMarkdownH2 = { fg = theme.rainbow.rainbow2 },
RenderMarkdownH3 = { fg = theme.rainbow.rainbow3 },
RenderMarkdownH4 = { fg = theme.rainbow.rainbow4 },
RenderMarkdownH5 = { fg = theme.rainbow.rainbow5 },
RenderMarkdownH6 = { fg = theme.rainbow.rainbow6 },

RenderMarkdownH1Bg = { fg = theme.rainbow.rainbow1, bg = <darker rainbow1> },
RenderMarkdownH2Bg = { fg = theme.rainbow.rainbow2, bg = <darker rainbow2> },
RenderMarkdownH3Bg = { fg = theme.rainbow.rainbow3, bg = <darker rainbow3> },
RenderMarkdownH4Bg = { fg = theme.rainbow.rainbow4, bg = <darker rainbow4> },
RenderMarkdownH5Bg = { fg = theme.rainbow.rainbow5, bg = <darker rainbow5> },
RenderMarkdownH6Bg = { fg = theme.rainbow.rainbow6, bg = <darker rainbow6> },

Expected behavior
The background color of a heading + border should be the same
Healthcheck output
render-markdown: require("render-markdown.health").check()
render-markdown.nvim [version] ~

OK plugin 6.3.2
OK neovim >= 0.10

render-markdown.nvim [configuration] ~

OK valid

render-markdown.nvim [nvim-treesitter] ~

OK installed
OK markdown: parser installed
OK markdown: highlight enabled
OK markdown_inline: parser installed
OK markdown_inline: highlight enabled
WARNING latex: parser not installed

ADVICE:

Disable LaTeX support to avoid this warning by setting { latex = { enabled = false } }

render-markdown.nvim [executables] ~

WARNING latex2text: not installed

ADVICE:

Disable LaTeX support to avoid this warning by setting { latex = { enabled = false } }

render-markdown.nvim [conflicts] ~

OK headlines: not installed
OK obsidian: not installed

Plugin configuration
  {
    "MeanderingProgrammer/markdown.nvim",
    opts = {
      heading = {
        position = "inline",
        sign = true,
        signs = { "󰫎 " },
        border = true,
        width = "full",
        icons = { " 󰲡 ", " 󰲣 ", " 󰲥 ", " 󰲧 ", " 󰲩 ", " 󰲫 " },
      },
      code = {
        sign = true,
        style = "full",
        width = "block",
        min_width = 60,
        left_pad = 2,
        language_pad = 2,
      },
      pipe_table = {
        preset = "round",
      },
      sign = {
        enabled = true,
        highlight = "RenderMarkdownSign",
      },
    },
  },

Plugin error log
NA
Confirmations

[X] I have provided markdown text for any screenshots used in my description & understand that my issue will be closed if I have not

Additional information
No response

Should be resolved by: https://github.com/MeanderingProgrammer/render-markdown.nvim/commit/12fdb6f6623cb7e20da75be68858f12e1e578ffd
Please update and LMK if it works!

works great, thanks!


Using Tauri vs Electron

THIS IS A NON-DESTRUCTIVE PR (aka. no existing functionality is removed)
Just an experimental PR to make use of Tauri instead of Electron for the desktop app publishing
JSRL is not using any real "Electron specific" functionality, other then just acting as the wrapper
This would help clean up a LOT of the electron-specific boilerplate
https://tauri.app/

To Install

Make sure cargo and rustup work on your system
configuration is in src-tauri/tauri.conf.json
npm run tauri dev will launch the dev build of the Tauri container, along with opening the dev tools
hot reloading works as you'd expect, so for example changes to src/Game.ts will trigger a reload of Tauri
npm run tauri build will build the app and run the Tauri packaging process
For Windows, .msi installers are generated in the src-tauri/target/release/bundle/msi
By default, it will try to install the app to c:\Program Files\jsrl but you can modify that
resulting app binary is ridiculously small: <5 MB on my system!

I was able to get a "Quit" working from my own Javascript frontend with passing an event back to Tauri. I did it in a way to detect if you're running on the web vs. inside Tauri
in the main.rs:
use tauri::Manager;

fn main() {
  tauri::Builder::default()
    .setup(|app| {
      let _window = app.get_window("main").unwrap();
      #[cfg(debug_assertions)] // only include this code on debug builds
      {
        _window.open_devtools();
        _window.close_devtools();
      }
      Ok(())
    })
    .invoke_handler(tauri::generate_handler![exit_app]) //register the exit_app handler
    .run(tauri::generate_context!())
    .expect("error while running tauri application");
}

#[tauri::command]
fn exit_app() {
  std::process::exit(0x0);
}
``

then from the JS side:

import {invoke} from '@tauri-apps/api/tauri'
// using ROT.js - if Tauri is on the window, provide a QUIT option
if (window.TAURI) {
display.drawText(hw - 8, hh + 4, '%c{yellow}[Q]uit');
}
// snip
if (inputData.keyCode === ROT.KEYS.VK_Q) {
invoke('exit_app')
}

I've got another idea for this and want to kill this PR @slashman - Been using electron-forge quite a bit, and I think it would help the development cycle of using JSRL "feel" better (IMHO)


ssl / https

What adjustments need to be made for ssl/https ?
I don't see anything in your repo about this.
Or is this webapp just for insecure lans ?
I ended up using ProxyPass in Apache to solve this in the interim.
Basically the user can access a secure url with https/ port 443 (gamepad.example.com or gamepad.pi.local), inside Apache is resolving the subdomain to Proxy Pass port 8089. Not that anyone cares because this repo is so outdated, but food for thought if anyone is interest

Sorry for the late reaction. Using a well established SSL proxy (e.g. Apache or nginx) as you did, is the usual way to approach this. Relying on some not so well established https sever is a potential security risk. As it stand right now, this project doesn't support secure connections out of the box. Even though this wouldn't be hard to add, it's not planned for the aforementioned reason and given how simple it is to add a reverse proxy.


How to find source code for specific nuget version

It seems that package is now automatically generated on every commit to master (or do you create nuget by hand every time)?
It would be nice if there was a git tag created for every release.

How to do it in yml file? Would sth like this work?
after_deploy:
- git tag -a v2.1.0.{build} -m "Version v2.1.0.{build}"
- git push origin v2.1.0.{build}

We actually just had a discussion about this not too long ago in #295. As of right now, each merge into master will create a new package release, automatically. It's possible we could tag each merge, but that might be a little extreme given our current release model.
To answer your question though, you can go to the history in AppVeyor for this project (https://ci.appveyor.com/project/tathamoddie/system-io-abstractions/history) and each time you see a full release (no hyphen at the end) the associated commit should be visible.

That's what I needed, thanks. :)
How can one find this link? If it is not obvious what server is being used, maybe you could add it to summary at the top of main repository's page?

That is an option, yes. I'm trying to decide if having AppVeyor tag every release would be a bad thing. It's a lot of tags, but it's a lot of releases.
That way were not reliant on a 3rd party to keep our version history that may get cleaned up, and it's not very searchable.

Independently of the tagging question, we could consider using https://github.com/dotnet/sourcelink for a much nicer debugging experience.

Starting now all versions deployed to NuGet.org will have corresponding tags/releases.


:sparkles: Build the space-framework image

We don't want to use .git in the docker image build instead we export the needed variables when we call make and then
when building in the image we use the imported file

Summary
Related issue(s)
Fixes #

/hold
fixing review comments

/unhold


Web database size limit

Is there any database size limitation for implementing moor database on web ?

The default WebDatabase writes to local storage internally, which browsers typically limit to around 10 MB. You can also use MoorWebStorage.indexedDb to use IndexedDB as a storage implementation, which has more lenient limits (typically around 50 MB). But both limits can be different across browsers.

Is there any way I can calculate the size of existing database?

Moor doesn't have a builtin api for this, no. Does StoreManager.estimate cover your use case?

I will check if this work,but this is only for Mozilla right?

From the compatibility chart at the bottom, it seems like all major browsers should support that api now.


Tiny docs fix (fixes #1611)

Just a tiny docs fix for #1611; some anchors didn't survive the transition to compile.futil from core.futil.

Looks great, glad it was so simple!

LGTM!


fix: deploy to existing projects in selected metro

While attempting to deploy, I noticed a few things that have been addressed in this PR.
I would like someone more familiar with the project to review these changes and ensure that deployment is still working as expected. With these changes, I did get a successful terraform apply, and after a few minutes, I was able to access the Harvester portal.

existing projects can be used when referenced by new project_id variable
spot market pricing lookups were occurring and blocking under conditions where spot_instance was false. These pricing lookups will be skipped when not requested. Additionally, the use_cheapest_metro value was overriding the user supplied metro value when spot_instance was false. This has been corrected.
organization_id variable added as it may be required when creating projects and multiple Equinix Metal organizations are available
harvester_os_password sensitive output variable added for chaining this module to additional modules where harvester credentials may be needed (also helpful for logging into the UI without looking through terraform state)
harvester_cluster_secret sensitive output variable added for chaining this module to additional modules where harvester credentials may be needed
added descriptions for all variables that lacked descriptions (looks like other PRs addressed most of this. I've added some details.)

@dnoland1 -- updated with terraform fmt

@dnoland1
The equinix_metal_project datasource will only take name or project_id, mutually exclusive, so the missing argument has to be sent as null instead of their default values of "".
I updated the logic and added precondition checks (required bumping to min TF 1.2). I verified that the datasource worked when I looked up by project name or id. I also noticed that datasource not needed when metal_create_project was set, so we count=0 it now to further simplify the logic.

CI is currently failing in because TF_VAR_project_name is not defined in the contributor PR pipeline. I believe this would succeed in the e2e pipeline. The requirement for either a project_id or project_name is real and it makes sense that the validation fails in the current state. We could add a TF_VAR_project_name to this workflow or change the defaults: set a default name "harvester_something" and create_project=true.

@glovecchi0 I applied your changes in the latest commit (with minor formatting tweaks and --author you).
I didn't apply the README.md and DOCS.md changes because #75 covers that, automating and persisting it going forward.

@glovecchi0 do you have the option to flip the workflow approval switch so CI will run checks?

The terraform plan check is still failing and needs to be fixed before merging. See https://github.com/rancherlabs/terraform-harvester-equinix/actions/runs/10831569903/job/30155965468?pr=93

Hey @dnoland1,
Is there a reason why all those variables are configured in the "Terraform Plan" section of the CI?
          METAL_AUTH_TOKEN: ${{ secrets.metal_auth_token }}
          TF_VAR_project_name: ${{ secrets.project_name }}
          TF_VAR_api_key: ${{ secrets.metal_auth_token }}
          TF_VAR_node_count: 3
          TF_VAR_plan: m3.small.x86
          TF_VAR_spot_instance: true
          TF_VAR_num_of_vlans: 10

I don't encounter any errors and the only thing I do is export the METAL_AUTH_TOKEN variable.

PS: the api_key variable cannot work, as it is not initialized in the provider.tf file.
Once this PR is resolved, I'll add a few fixes.

The api_key is used for the spot market pricing requests issued by the http provider (a feature not present in the Equinix TF provider).

@dnoland1 the CI failed because my PR is from a fork, it does not have access to the project's secrets.
The error, as follows, is sensible under root org executions where project_name is defined, https://github.com/rancherlabs/terraform-harvester-equinix/blob/main/.github/workflows/ghactions-ci.yml#L33. (as @glovecchi0 pointed out).
It may improve the contributor experience if the non-sensitive variables were moved to an environment variable (not secret) and made part of a CI build that only executes terraform validate. terraform plan requires secrets.
│ Error: Resource precondition failed
│
│   on data.tf line 13, in data "equinix_metal_project" "project":
│   13:       condition     = var.project_name != "" || var.project_id != ""
│     ├────────────────
│     │ var.project_id is ""
│     │ var.project_name is ""
│
│ One of project_name or project_id must be set when metal_create_project is
│ false

I put in a PR to hard code the project name in the GH action instead of using a secret.

PR is now merged. @displague if you want to update your PR/branch with the latest from main we can see if it passes the GH action checks.

Tests still aren't passing because it cannot retrieve the project id using the project name because the Equinix API key is not available. I'll merge and will need to make sure future internal PRs pass the tests.


IPFS Weekly for January 25th Sprint

This is the draft for the Weekly for the January 25th sprint, which will be polished and published following the sync on February 1st.
If you've done anything great this week, please highlight it and add it in here!

Add the Lisbon meetup: https://github.com/ipfs/community/issues/103

This Looks good to me.

Seeing as how I sent the last weekly out on Monday morning, I am going to wait until Thursday to merge and post this. No need to get too hasty.

You could add that i went through all of the go-ipfs pull requests and closed old ones, merges ones that were ready, and pinged the others for an update.

one more to add:

@noffle began a discussion about revamping the ipfs mount interface, join to voice your thoughts -- https://github.com/ipfs/notes/issues/105#issuecomment-178639005

@whyrusleeping there are several RFM PRs in the pipeline.

searching twitter for #ipfs gave me this:
Conferences:
- IPFS was presented at the last [Desert Blockchain](https://twitter.com/DesertBlockHack) miniconference: https://twitter.com/DesertBlockHack/status/693520940504784896

Tools:
- There was an unfortunate GitHub outage and many people started using IPFS to move around their repos, with @whyrusleeping's simple [git-ipfs-rehost](https://github.com/whyrusleeping/git-ipfs-rehost) [view on ipfs](fixme) and @cryptix's excellent [git-remote-ipfs](https://github.com/cryptix/git-remote-ipfs) [view on ipfs](fixme).
- @pipermerriam created [ipfs-persistence-consortium](https://github.com/pipermerriam/ipfs-persistence-consortium) to create networks of IPFS nodes which persist each other's content. This is similar to @victorbjelkholm's [pincoop](https://github.com/victorbjelkholm/pincoop). Perhaps there can be some cooperation in these efforts? :sunglasses:
- The [FullNode](https://github.com/MrChrisJ/fullnode) Project -- which includes IPFS, Tor, Bitcoin, OpenVPN and more -- [is having a crowdfund](https://www.startjoin.com/protip2) -- go get one! Thanks for making it @MrChrisJ!

Other (not sure what to categorize these):
- It's [Ralph Merkle's](https://en.wikipedia.org/wiki/Ralph_Merkle) birthday today. Happy Birthday, Ralph! :cake: :birthday:
- Our friends at [Mine](http://mine.nyc) are using IPFS for the excellent [Mediachain metadata protocol](https://medium.com/mine-labs/introducing-mediachain-a696f8fd2035) ([protocol proposal here](https://medium.com/mine-labs/mediachain-483f49cbe37a#.h6wrzm3ze)), a protocol to track media creation, attribution, and more. They have published [several great articles](https://medium.com/mine-labs?source=logo-lo_8f8cb62ab817-6838e0c89092) about it. This week @denisnazarov wrote about [The GIF That Fell To Earth](https://medium.com/mine-labs/the-gif-that-fell-to-earth-eae706c72f1f#.s0c7x59he), and @parkan gave a [Developer Update](https://medium.com/mine-labs/mediachain-developer-update-i-911c9e7a4524#.zc984cqen) that discusses [pHash](http://www.phash.org/), [IPLD](https://github.com/ipfs/specs/blob/ipld-spec/merkledag/ipld.md), and more.
- @lexansoft created a new Ethereum name registrar called [EtherID](http://etherid.org) ([repo here](https://github.com/lexansoft/etherid.org)), which uses IPFS for storing users' content. Then [@btsfav](https://twitter.com/btsfav) wrote an article about [Personal Websites on EtherID with IPFS](http://favs.pw/time-for-some-interplanetary-etheral-magic/)

the "view on ipfs" fixmes should be copies of those repos stored on ipfs (cc @whyrusleeping @cryptix). some people on twitter couldn't get to git-ipfs-rehost: https://twitter.com/MrChrisEllis/status/692541031200481280
@christianlundkvist anything to feature in the uport / consensys front?

@jbenet Thanks for writing up those Twitter searches. Added!

I think this is RFM. @jbenet?

yep, thanks  @RichardLitt

Hey there, thanks for doing this. Is there any reason to use gateway.ipfs.io instead of ipfs.io?

When you are making CNAME? Yes, ipfs.io has SAO, MX, dnslink and some more records, gateway.ipfs.io is pure. So when you are using DNS CNAME to gateway.ipfs.io, for just making links use ipfs.io.


Bot locales are not found if in a path with any upper case letter, and in linux

I have my locale files in path /home/ils/Projects/my-bot/locale/en-us, but before loading them, the correct full path is modified to lower case here, making the localizer to miss it, even though it exist in that path, but with an upper case letter P (in Projects).
The same code works for my team colleagues using OS X or Windows.

There's a patch coming for this...

Please install v3.4.0 which should fix the issue.

3.4.0 is not backwards compatible because, at least:

The class Library doesn't have a name property anymore. Correct me if I'm wrong but the new namespace property, that seems to correspond to the old name, is in the typings but it is NOT in the .ts code. Synch between code and typings still doesn't seem to work very well.
ISessionOptions added a mandatory ILocalizer attribute.

It should be 4.0.0 to follow semantic versioning and make npm work properly (see https://github.com/Microsoft/BotBuilder/issues/911)

So the first issue I just fixed in v3.4.2. That property name shouldn't have changed.  For the second issue around changing the Session to include a mandatory property, why is that impacting you?  You really shouldn't be creating a Session manually. If you are I'd like to understand what you're doing.
As for following Semver. We'd be at version 20 of the SDK if we were that rigorous. This is a pre-release SDK so there WILL be breaking changes from time to time. We try to keep them to an absolute minimum and by policy we'll only introduce a breaking change if we feel like it shouldn't impact very many (or in most cases any) bots.  The Library.name change was an oversight and the required attribute change to ISessionOptions shouldn't have impacted anyone.

I should also add that we haven't really started planning the 4.0 version of the SDK yet but if I had to guess it will include a broad set of truly breaking changes.  We're receiving a ton of feedback as to what's working and what isn't working with regards to the architecture of the current SDK.  We're trying to add features to the SDK to better address the needs of the bot developer without breaking existing bots. This is challenging because building bots is such a bleeding edge thing. We're learning right along side you guys. I know it can seem a bit painful at times but we appreciate you guys sticking with us.

Thanks @Stevenic. We create a Session manually in our unit tests. It's a minor issue for us, we can change it easily.

Oh I see... That's always going to be a little brittle. Currently it's assumed that the UniversalBot is always the one creating the Session so it's essentially a private interface and I'm always going to be adding & removing constructor params. You could make the argument that we shouldn't be documenting the Sessions as something you can create if that's the case but I'd hate to break your unit tests.

I'll try to minimize breaking changes to the options list in the future.


Add matrices/quaternions package

Haha, I was just about to write a matrix lib myself this week.
Good stuff  👍
Few things:

Naming should be mat2 and mat3 like vec
Do you have the rc cell naming from somewhere? The one is now is m00 etc. which is more common, but I might be wrong
Some functions who could need it, are without hotdoc

I will add comments to the code and additional function suggestions later.

Quaternions package was added as well.

No, keep that to a separate PR.


Update security.rst

Summary

Add missing punctuation marks and improve sentence clarity.
Ticket Link

Hello @Zaidtech,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Thanks for your PR! This isn't something we're looking to implement at the moment but we appreciate your contribution and look forward to working with you on other PRs. :)

Sure @justinegeffen


feat(tracer): auto-disable tracer when for AWS SAM and Chalice environments

Issue number: #3642
Summary
Changes
This pull request introduces the feature of automatically disable the Tracer when operating within AWS SAM and Chalice environments.
Changes Made

Added logic to detect AWS SAM and Chalice environments.
Updated relevant documentation to reflect the new behavior.

User experience
Before
sam local invoke --event events/event.json --skip-pull-image
Invoking app.lambda_handler (python3.10)
Requested to skip pulling images ...

Mounting /tmp/tracer/.aws-sam/build/HelloWorldFunction as /var/task:ro,delegated, inside runtime container
START RequestId: 73b2e7bb-877b-42db-a86a-453d4c976172 Version: $LATEST
[WARNING]	2024-03-13T17:04:37.159Z	73b2e7bb-877b-42db-a86a-453d4c976172	Subsegment ## lambda_handler discarded due to Lambda worker still initializing
[WARNING]	2024-03-13T17:04:37.160Z	73b2e7bb-877b-42db-a86a-453d4c976172	No subsegment to end.
END RequestId: 73b2e7bb-877b-42db-a86a-453d4c976172
REPORT RequestId: 73b2e7bb-877b-42db-a86a-453d4c976172	Init Duration: 0.09 ms	Duration: 578.13 ms	Billed Duration: 579 ms	Memory Size: 128 MB	Max Memory Used: 128 MB
"dummy payment collected for charge: "

After
sam local invoke --event events/event.json --skip-pull-image
Invoking app.lambda_handler (python3.10)
Requested to skip pulling images ...

Mounting /tmp/tracer/.aws-sam/build/HelloWorldFunction as /var/task:ro,delegated, inside runtime container
START RequestId: 6def6c92-c55c-44bd-acd6-84414286e151 Version: $LATEST
END RequestId: 6def6c92-c55c-44bd-acd6-84414286e151
REPORT RequestId: 6def6c92-c55c-44bd-acd6-84414286e151	Init Duration: 0.11 ms	Duration: 484.16 ms	Billed Duration: 485 ms	Memory Size: 128 MB	Max Memory Used: 128 MB
"dummy payment collected for charge: "

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.33%. Comparing base (e14e768) to head (d104136).
Report is 170 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3949      +/-   ##
===========================================
- Coverage    96.38%   96.33%   -0.05%
===========================================
  Files          214      215       +1
  Lines        10030    10255     +225
  Branches      1846     1913      +67
===========================================
+ Hits          9667     9879     +212
- Misses         259      269      +10
- Partials       104      107       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

This looks very good, but didn't you mention skipping on Amplify too?

Yes, you're right! But I tested locally and didn't see the environment variable, so I'd rather wait, have more time to test and make sure we're not doing anything wrong. I'll open another PR if needed, ok?


Lambda dlq check

I confirm these files are made available under CC0 1.0 Universal (https://creativecommons.org/publicdomain/zero/1.0/legalcode)
Issue: https://github.com/awslabs/aws-config-rules/issues/165
Description of changes:

Code looks good to me.
@jongogogo, kindly review this pull request

Closing the PR.


remote shortcuts not working

For the buttons that spawn in items (link tool, remote)

fixed with lua shortcut


GetBindingLocation in Base class is not returning Identity provider's complete URL

I am trying the Docker-compose example from:
https://github.com/simevo/spid-wordpress/tree/master/docker
but I find an issue when clicking the 'Accedi con SPID usando testenv2 come IdP' button.
The issue is that the application is redirecting me to the wrong URL (http://localhost:8099/sso?SAMLRequest=xxx which is the Service Provider url) instead of http://localhost:8088/sso?SAMLRequest=xxx which is the Identity Provider url).
The result is a NOT FOUND error.
After a bit of investigation the problem seems to be in the method GetBindingLocation of Base class:
https://github.com/italia/spid-php-lib/blob/ac609f350c0e09d936a8f139492108eb443fb625/src/Spid/Saml/Out/Base.php#L67
which seems to skip the Identity Provider url when building the redirect, infact if I change that line to:
if ($binding == $val['binding']) $location = $this->idp->metadata["idpEntityId"].$val['location'];
everything works.
BTW: I am not sure if that's the right place to compose the complete url (maybe it should be inside the IDP class itself).

see https://github.com/italia/spid-testenv2/issues/193
I'll be adding some extra checks on our end to better signal the error, but as a temporary solution you could manually edit the IDP metadata you downloaded.

if the testenv does not comply to our request, we can probably handle it with something like:
if ($binding == $val['binding']) {
    if ($val['location'][0] == '/') {
        // relative url
        $location = $this->idp->metadata["idpEntityId"].$val['location'];
    } else {
        // absolute url
        $location = $val['location'];
    }
}

PR https://github.com/italia/spid-testenv2/pull/194 was merged so the problem should be gone
waiting for confirmation ...

solved; if you are using docker, remember to docker pull italia/spid-testenv2


bug fixed

This solves:
https://github.com/oxon/dingg_lib_OXOcardV2/issues/65

would be nice if the title of commit/PR had a tiny bit more context. e.g.
Bugfix: math_increment in generator


Make types project-wide

Currently types are only within their "service" (server, client) so when we're passing objects between, there isn't a single source of truth.
ex. content of message when successfully creating a room.

I was forgetting that CRA does not allow for aliases and will overwrite the tsconfig when you try to build. create-react-app #6229
Might be worth considering an eject of the config and handling it ourselves. Would increase config complexity, but it's just webpack so it's not terribly foreign. Additionally, there's sections of the config which are included for CRA supported features, but aren't necessary for this project (ex. checking whether we're using jsconfig or a tsconfig). Removing some of this additional logic might reduce that new complexity.
Worth trying in a separate branch at least as I feel having consistent types for objects passed between server and client is more important than the CRA abstraction. Will keep event types copied for now, but will open new issue to track this.

Have become kind of fixated on sharing types, but not sure if that's actually all that necessary in the end.  There's not a whole lot that they need to share (event types and message format) and could simply "standardize" those a bit. It also introduces some annoying issues with module resolution in jest and overall makes the server and client less independent. Closing for now with recommendation to simply have consistent structure for socket messages.


Can't highlight an empty line

It's very annoying when deleting multiple lines when you can't highlight an empty one for example:
// My line of code
// Another line of code

// My line of code
// Another line of code

The blank line doesn't get deleted when dragging over the line numbers pane.

Hi, can you specify which action you are taking in order to highlight this text? I've tried it on both OSX and Windows and it works fine for me when I (CTRL + A) or (Shift + Arrow).

I'm using the mouse. Just hover over the line numbers and drag up/down to highlight the lines.

Just to understand this properly, you are referring to the fact that highlighting lines 2-4 and pressing backspace results in a file with 3 lines, the middle one empty?
If that is the case, I'd say this is to be expected since you have a selection, and replacing that selection (in this case, with nothing).
You could also press another key with your selection, say 'x', and would end up with line 2 having 'x' in it, as you just replaced the selection with 'x'.

Not really. It's when deleting multiple lines, some with content, some empty. Not all the empty lines get deleted - it's definitely noticeable coming from Visual Studio 2015.

Interesting, couldn't reproduce this on Linux with 0.10.6 either.
Multiple empty lines in-between, mouse selection as well as cursor selection works as expected, and leaves me with my cursor in exactly one empty line as expected.

I'm running it on Windows 10 64bit. I am also using a custom language extension which may be the cause but I dunno.

Here's an example: http://1drv.ms/1X5P1kJ

After looking at it more, it's very obvious that when highlighting any line, your caret stays on the same line you've highlighted which means when you press delete on an entire line, the line itself doesn't get deleted so you end up having to press delete twice to remove one line. This is also linked to the inability to highlight an empty line since it doesn't place the caret on the line below; it simply places the caret at the end of the highlighted line.
When I say "highlighting a line" I mean when placing the cursor on a line number and left clicking.
What currently happens:
1    // Line 1 content
2    // Line 2 content - highlighted line**<caret>**
3    // Line 3 content
4    // Line 4 content
5    // Line 5 content
What should happen:
1    // Line 1 content
2    // Line 2 content - highlighted line
3    <caret>// Line 3 content
4    // Line 4 content
5    // Line 5 content

@jameslkingsley What you're describing is standard behaviour for pretty much every editor I've used recently, e.g. Sublime, Atom, GEdit etc.
When you've selected a line and the caret is at the end of that line, pressing delete means "replace selection with nothing", with "replace selection" being the confusion here I think.
"Delete line" is a separate action, you can do that with Ctrl+Shift+k and it will delete the current line your caret is in, or the lines that are in your current selection.
If you wish to delete a line by using the replace selection action, you'll have to move the caret to the start of the line below. The keyboard shortcut for Shift+DownArrow will select a line and move the caret to the start of the line below for example, and you can just press delete and the line is gone.
I'd argue that VSCode just needs better visual cues for line selection, like Atom which does highlight the whole line regardless of it having characters or not.

What I described should happen is in Visual Studio 2015, Eclipse, Dreamweaver, Notepad++ and even Atom.  I'm not quite sure why it's necessary to have a keyboard shortcut for such a basic command.

Here's a video demonstrating Notepad++, Atom, VS2015 and VSCode: https://www.youtube.com/watch?v=bZdm1v3AUjE

@jameslkingsley Ah ok, this isn't about the behaviour when pressing delete or being able to select empty lines then, those appear to be working as expected when using the keyboard.
When using the mouse clicking line numbers, it does indeed not select linebreak markers as well, which it should.

@bpasero fyi, line break marker selection seems to be having odd behaviour when selecting with the mouse

For verification:
BEFORE:

Notice how the first line select also selects EOL and subsequent ones go to column 1
AFTER:

Perfect. Thank you very much :)


Problem installing the package

Problem: While trying to install the package, I am getting the below token error.
npm ERR! Unexpected token } in JSON at position 8263 while parsing near '...gBcVa+g=="
npm ERR!     },
npm ERR!   }
npm ERR! }
npm ERR! '
npm ERR! A complete log of this run can be found in:
I tried clearing the cache but of No help.
2018-06-22T21_14_33_237Z-debug.log

This is almost certainly a local or npm issue, completely outside of our control.  Try the following:

remove package-lock.json and install again (based on comments from https://github.com/npm/npm/issues/17340 )

temporarily move your package.json, install, then restore it

roll back to an older version of npm (like 4.3.0) and try installing

and if none of those work, raise an issue with npm: https://github.com/npm/npm/issues/

Yes. Creating a new node package worked. Thank you.


Ensure import of Projects works with Maven/Gradle in IntelliJ IDEA and Eclipse

I think you need this one fixed for Eclipse: robovm/robovm-eclipse#49.

@badlogic thanks, this would simplify a lot.

Importing via tje root pom into Idea works now. Will get Gradle going asap.
On Apr 17, 2015 3:51 PM, "Alexander Orlov"<EMAIL_ADDRESS>wrote:

@badlogic https://github.com/badlogic thanks, this would simplify a lot.
—
Reply to this email directly or view it on GitHub
https://github.com/robovm/robovm-samples/issues/36#issuecomment-93989933
.

Both Gradle & Maven importing works via IDEA now.
Next up Eclipse.

You can now also import the samples via Maven/Gradle in Eclipse. Requires snapshot 1.2.1 of RoboVM and the RoboVM Eclipse plugin.


add -XX:ErrorFile as option

From the comments in #401 I thought we might just want to make this a switch the users can set in the environment variables. I have set the location to the PV. @bparees @gabemontero let me know what you think of this implementation. I will do some more testing if this is a good idea. Thanks!

@bparees I have updated the name to follow the other true/false variables. I will add some documentation soon before this gets merged. Let me know if you want me to make more changes. Thanks!

lgtm but i think we'll want to hold this until we cut the 3.10 branch.

@Gl4di4torRr - can you update the README for the new environment variable ... there is a table at https://github.com/jenkinsci/kubernetes-plugin/pull/315/files
@bparees - I will run make update-examples in openshift origin after they cut the 3.10 branch

@gabemontero Yes will do ASAP.

@gabemontero added documentation. Would you like to see any more test results?

README update looks good @Gl4di4torRr
If you could squash the commits (that is our general practice), I'll go ahead and get this merged.
thanks again

/approve

@gabemontero commits have been squashed. Thanks! Excited to help out!

awesome thanks again @Gl4di4torRr

/lgtm


Min Stack #49

please share your number i will call u in your free time sir please
On Sat, Oct 16, 2021 at 1:04 PM Samrat Mitra @.***>
wrote:

@.**** requested changes on this pull request.
The file path will be like Stack/155. Min Stack/C++ Solution/Solutio.cpp
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lionelsamrat10/LeetCode-Solutions/pull/88#pullrequestreview-781338238,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARORJN5KYMW3MSCEVUTE5MTUHETGRANCNFSM5GCPG4SA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


How to add dynamic localization?

I have been trying to add a localization for different languages.
I can add one language not multiple.
Is it possible with react-dates?
`import React, { useState, useEffect } from "react";
import 'react-dates/initialize';
import 'react-dates/lib/css/_datepicker.css';
import { DateRangePicker } from "react-dates";
import moment from "moment";
import { getLanguage } from "./getLanguage";
function DateRangeSelector(props) {
const language = getLanguage();
const { start, end } = props;
const [startDate, setstartDate] = useState(start || moment());
const [endDate, setendDate] = useState(end || null);
const [focusedInput, setfocusedInput] = useState(null);
const handleDateChange = ({ startDate, endDate }) => {
setstartDate(startDate);
setendDate(endDate);
};
const handleFocusChange = (focusedInput) => setfocusedInput(focusedInput);
return (
<DateRangePicker
endDate={endDate}
endDateId="endDate"
numberOfMonths={1}
focusedInput={focusedInput}
isOutsideRange={() => null}
onDatesChange={handleDateChange}
onFocusChange={handleFocusChange}
startDate={startDate}
startDateId="startDate"
/>
);
}
export default DateRangeSelector;
`
I have a helper that gives me a language ("tr", "en", "de")
I couldnot find a way to achieve this. I can add a localization for "de" by simply adding "import  'moment/locale/de'". So how can I make it dynamically?

@sumeyradavran hey I just made small example on codesandbox.  The main idea is to run moment.locale() with new language. Also you need to import moment/min/locales.min

@mmarkelov I can add now thank you 👍 . Maybe we can add it on docs.


Saturation correction (from pax)

Correct for saturation in peaklets
Right after peaklets are built, we take a look at those containing saturated records. Replacing part of the 'bad' raw records with the summed waveform of the non-saturated channels. The cartoon illustration shows the effect of the peak_saturation_correction function, replacing the correction region black with red, thus the peaklet can be reconstructed with reduced bias.

Thank you, @jorana @WenzDaniel, for the review! I made some minor changes. Let me know if those are good. I also checked again for the peak classification; unfortunately, to the disappointment of @feigaodm, even with the gap-size clustering happening before this step, classification comes later.

@zhut19 @jorana @WenzDaniel Thanks all for your efforts to implement the saturation correction. I also think that we can merge this PR.

@zhut19 is there a way that you can apply peak classification in peaklet so that you can fully avoid correct S1s?

@feigaodm, sorry I haven't found a way to apply peak classification. I got stuck at getting the context inside the Peaklet plugin, thus making it impossible to call the compute of PeakletClassification during the desaturation step.

@feigaodm just approved this PR, I'm going to merge it as soon as travis finishes


Fix inference of wrapper views

Thank you!

I wonder if this would also be necessary for non-wrapping views, but I don't think it is? IIRC I only had issues yet when views either contain a ViewSequence or a  View.


Interests tag user-input while sign up

the app should show mini-blogs in the domain that interests user. thus, it is important that we collect that information.
Add an option in the sign up form to multi-select following predefined tags. It should be tap and select based system.
Domain(s): Software Engineering, Web Dev, Mobile App Dev, Product Designing, Machine Learning, Cyber Security
As of now, we will keep the domains limited for the initial version of the project.

@vedantbahel Can I take up this feature and work on it on the weekend?

Done!
Good luck and thank you!

@vedantbahel Thanks!

Please add one more feature. The user must select at least 3 domains to continue.

@vedantbahel I have implemented the feature with validation using the multi_select package. I have opened a PR on this please do check it out and let me know if any changes are required.


tex16.png not committed

046a52010cd8136f7d8496f9fa21776b6e89b027 tries to load an additional texture, but the file is missing

Just added the two texture files and pushed, this should fix that issue

Yep, fixed it. :)


Not able to redirect in streamlit to the next page even after clicking , PLs help

Table of Contents

What is LangChain("What is LangChain")?
Installing LangChain ("Installing LangChain ")
Setting your OpenAI API key("Setting your OpenAI API key")
Using LangChain("Using LangChain")

Are the name of the files the same ?
its a path issue


Fix AttributeError: 'Korea' and 'Vietnam' object has no attribute 'korean_cal'

It is a supplement for PR #306
Not only korea.py, but vietnam.py uses 'korean_lunar_calendar'. So this issue must deal with korea.py and vietnam.py together.

Thank you! 👍


⚠ Bofrost.lu has degraded performance

In 63ddc46, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1385 ms

Resolved: Bofrost.lu performance has improved in 36b9c2c after 9 minutes.


Scheduler Day/Week Appointments Viewed as Overlapping when Not

When one appointment starts at the same time another ends, they act as if they are overlapping if the time is not a slot boundary. If it is a slot boundary, everything works fine.

As you can see, with "Skype call" ending at 1pm and "Dentist appointment" starting at 1pm, there is no issue. With "Test overlap 1" ending at 3:15 and "Test overlap 2" starting at 3:15, they display differently like when an overlap happens. This happens with the default slot minutes of 30. If I change the slot minutes to 15, then this example works also (although there are other issues as noted in other posts that you are working on with changing slot minutes). Seems to happen when the appointments touch at non-slot boundaries if that makes sense.

Should work now.

Awesome!  Thank you!


Loss close to 0, acc nearly 1, but poor visual_feedbacks

Hi Shahrukhqasim,
Thanks for sharing your project. I tried to train the model by tf-record downloaded from google drive you provided. Used the same tfrecord for train, val and test.
For the training process, loss converged quickly, after 2000 iterations, I got the result as below:
Training Iteration 1999:
Accuracy - cells: 0.999771655 rows: 1 cols: 0.999677658
Loss     - cells: 0.00083513 rows: 0.00029534733 cols: 0.00229700166
Fraction - cells: 0.503221631 rows: 0.493117601 cols: 0.492601216
Total loss: 0.00114249298
But when I checked the visual feedbacks, I got poor visualized result :

Does anybody have some advice or have similar problems? Many thanks

@shahrukhqasim

@hxk11111 In the author's code, only six samples were taken to show whether the results were correct.

HI @hxk11111 . I have problem while training. I don't know you see this.
Training Iteration 105:
Accuracy - cells: 0.978424609 rows: 0.895143926 cols: 0.803354
Loss     - cells: 0.0991929844 rows: 0.293497771 cols: 0.486667097
Fraction - cells: 0.0215753876 rows: 0.104856044 cols: 0.19664596
Total loss: 0.293119282
Training Iteration 106:
Accuracy - cells: 0.98035419 rows: 0.896977782 cols: 0.827894092
Loss     - cells: 0.0928051174 rows: 0.2944884 cols: 0.456886739
Fraction - cells: 0.0196458325 rows: 0.103022188 cols: 0.172105893
Total loss: 0.281393409
Training Iteration 107:
2019-12-02 11:23:50.896536: W tensorflow/core/framework/op_kernel.cc:1502] OP_REQUIRES failed at gather_nd_op.cc:47 : Invalid argument: indices[26,190] = [26, 109, 90] does not index into param shape [30,109,109,128]
Traceback (most recent call last):
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1356, in _do_call
return fn(*args)
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1341, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1429, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.InvalidArgumentError: indices[26,190] = [26, 109, 90] does not index into param shape [30,109,109,128]
[[{{node conv_graph_dgcnn_fast_conv_1/GatherNd}}]]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "table_adjacency_parsing.py", line 31, in
trainer.train()
File "/home/hungdv/Documents/graphNN/TIES-verions2/python/iterators/table_adjacency_parsing_iterator.py", line 88, in train
model.run_training_iteration(sess, summary_writer, iteration_number)
File "/home/hungdv/Documents/graphNN/TIES-verions2/python/models/basic_model.py", line 400, in run_training_iteration
ops_result = sess.run(ops_to_run, feed_dict = feed_dict)
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 950, in run
run_metadata_ptr)
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1173, in _run
feed_dict_tensor, options, run_metadata)
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1350, in _do_run
run_metadata)
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/client/session.py", line 1370, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: indices[26,190] = [26, 109, 90] does not index into param shape [30,109,109,128]
[[node conv_graph_dgcnn_fast_conv_1/GatherNd (defined at /home/hungdv/Documents/graphNN/TIES-verions2/python/ops/ties.py:32) ]]
Errors may have originated from an input operation.
Input Source operations connected to node conv_graph_dgcnn_fast_conv_1/GatherNd:
conv_graph_dgcnn_fast_conv_1/Cast (defined at /home/hungdv/Documents/graphNN/TIES-verions2/python/ops/ties.py:31)
conv_graph_dgcnn_fast_conv_1/conv2d_14/LeakyRelu (defined at /tmp/tmp8vnsy1dh.py:74)
Original stack trace for 'conv_graph_dgcnn_fast_conv_1/GatherNd':
File "table_adjacency_parsing.py", line 31, in
trainer.train()
File "/home/hungdv/Documents/graphNN/TIES-verions2/python/iterators/table_adjacency_parsing_iterator.py", line 53, in train
model.initialize(training=True)
File "/home/hungdv/Documents/graphNN/TIES-verions2/python/models/basic_model.py", line 94, in initialize
self.build_computation_graphs()
File "/home/hungdv/Documents/graphNN/TIES-verions2/python/models/basic_model.py", line 365, in build_computation_graphs
vertices_y2, vertices_x2, scale_y, scale_x)
File "/home/hungdv/Documents/graphNN/TIES-verions2/python/ops/ties.py", line 32, in gather_features_from_conv_head
return tf.gather_nd(conv_head, indexing_tensor)
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/util/dispatch.py", line 180, in wrapper
return target(*args, **kwargs)
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/ops/array_ops.py", line 3796, in gather_nd
return gen_array_ops.gather_nd(params, indices, name=name)
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/ops/gen_array_ops.py", line 3991, in gather_nd
"GatherNd", params=params, indices=indices, name=name)
File "/home/hungdv/.local/lib/python3.5/site-packages/tensorflow/python/framework/op_def_library.py", line 788, in _apply_op_helper
op_def=op_def)

@hxk11111 Hi，I am facing the same problem，it is so strange. Could you tell me how do you solve it ?

@hxk11111 Hi，I am facing the same problem，it is so strange. Could you tell me how do you solve it ?

I also faced same problem. I have rewritten the code and able to solve many issues. I faced the above https://github.com/shahrukhqasim/TIES-2.0/issues/22#issuecomment-560256373 problem when running on my Ununtu (16.04) Machine. In windows machine (Windows 10.x) this problem seems to vanish.

@hxk11111 ,
I have very bad results for Columns and Cells validation. But getting good result for Rows. Could you please provide your Config.ini file.
Also, are you able to make inference on a single image..? If yes, please let me know how you did it.
Thank you in advance. :)

@hxk11111
Did you solved this provlem ?  many thanks


Generate PDF for pages

In our Travis CI, add the automatic generation of PDFs for pages (or at least Strategies) so that visitors can easily download one for later reading.
Example on how to implement in Travis: https://gist.github.com/willprice/e07efd73fb7f13f917ea

Once these files are automatically created, will they just be posted on our website or also posted on our internal SharePoint?


Restore thumbnail map

Restoring the thumbnail map on show_observation with simple in-house code.  No Javascript required!  The CSS, however, is a bit tricky.  It'd be awesome if anyone had the time to test it on additional browsers.  I tried to keep it as simple as possible, but you never know...

I have no idea why all those old tweak-mycoflora-report branch commits are in there.  This might not be 100% ready for public consumption.  Might have to close this and cherry pick the thumbnail-map commits into a new PR.  Waiting to see if the tests pass...

Okay, it's all working fine.  Let me just double-check that the Mycoflora report tweaks are still appropriate before we push this out.

Coverage increased (+0.01%) to 90.619% when pulling 8139548ee470822932d5969725777c67e4c959bb on pellaea:restore-thumbnail-map into e730c03410861652f0865427368595357388b887 on MushroomObserver:master.


Fix standard library modules for isolated object init method changes

Description:
We recently identified an in issue in the language that allowed invalid updates of restricted fields within the init method of an isolated object.
Currently we don't require using lock statements when accessing restricted fields (using self) in the init method of an isolated object. But while initialization of these fields doesn't require lock statements (requiring an isolated expression as the initial value guarantees that the object will be an isolated root), other kinds of access such as when using a langlib method to update a structure that is set to a restricted field require a lock statement to carry out the relevant transfer in/out analysis (which is associated with a lock statement) to ensure the object is an isolated root.
E.g.,
isolated class Class {
    private int[][] arr = [];

    function init(int[] node) {
        // self.arr = [node]; // error
        self.arr = [node.clone()]; // OK

        self.arr.push(node); // allowed at the moment,
                             // but violates the isolated root invariant
    }

    function fn(int[] node) {
        lock {
            // self.arr.push(node); // error
            self.arr.push(node.clone()); // OK
        }
    }
}

public function main() {
    int[] intArr = [1, 2];

    Class cl = new (intArr);

    // Same mutable array can be accessed via `cl` and `intArr`.
    // Therefore, `cl` is not an `isolated` root, which cannot be the
    // case since `Class` is an `isolated` object.
}

Draft PR with initial changes to fix this issue - https://github.com/ballerina-platform/ballerina-lang/pull/40737.
There are multiple stdlib module failures, including

HTTP
gRPC
GraphQL

Appreciate if these can be fixed. Will share a timestamp for a version with these changes once the PR is merged to the branch.

ballerina-lang branch - https://github.com/ballerina-platform/ballerina-lang/tree/fix-isolated-in-init
Timestamped snapshot version - 2201.7.0-20230620-082800-c0018aae

Is this going with Update 7?

Is this going with Update 7?

That was the original plan, because it would be better to merge this as soon as possible since it is a breaking change.
But we need the standard libraries to be fixed, so I guess it would depend on the time taken for that. For example, I'm assuming fixing HTTP may not be straightforward since interceptors are not isolated, whereas for some other modules it may be just a change to use lock statements.

The issue is we are past the code freeze and might not have enough time to complete this with Update 7. We can prioritize this for the next sprint aiming at Update 8. Will that be okay?

The issue is we are past the code freeze and might not have enough time to complete this with Update 7. We can prioritize this for the next sprint aiming at Update 8. Will that be okay?

Sorry, my bad, I meant next month's release, so Update 8 it is. :)

Can we get the versions bumped in packages that use these fixed modules too? Levels 6, 7, 8, and 9 are failing in today's build (https://github.com/ballerina-platform/ballerina-lang/pull/40757).

Can we get the versions bumped in packages that use these fixed modules too? Levels 6, 7, 8, and 9 are failing in today's build (ballerina-platform/ballerina-lang#40757).

Sure, will do

Closing the issue as this is now completed.


Building on js-web should exit with success if successful

A successful build on the js-web backend currently ends with an abort, which makes it very difficult to package things properly: it's difficult to recognise whether the build actually failed or if we're just announcing things to the user :/
https://github.com/effekt-lang/effekt/blob/b0342130d7bbd926e072e753f048b92a7395efd8/effekt/jvm/src/main/scala/effekt/Runner.scala#L220-L221

Also, we might want to add a id=app div into the HTML template :)


Add object lists to metrics api

fix #1219

LGTM. Thanks for the change!
Test failures unrelated.


feat: Release of 0.10 version

:tada: This PR is included in version 0.10.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


JSON formatter from scss lint is not used?

Hello,
I was wondering is there a specific reason to not use the JSON formatter available in the scss-lint gem?
It would be really useful for example if you use the json output to render to custom jade templates.

I haven't needed it, but it'll be very simple to implement so happy if you want to do a PR.

Alright, I'll give it a shot.

:+1:


pkg/index tests are failing

https://travis-ci.org/perkeep/perkeep/builds/408296704
Looks like it was broken at 13a8e948950460a26de6274ce037b3b0b7ed2d38

@euank Let me know if you want me to look into it or if you're on it please.

Apologies for my carelessness, it looks like I forgot to commit a change I had locally which let tests pass. I've submitted https://perkeep-review.googlesource.com/c/perkeep/+/17766 for this.
I think this is also a good argument for https://github.com/perkeep/perkeep/issues/1198... we should be catching these sorts of silly mistakes before merge, not after.


Improve the display of missing projects in the Project Manager

Use a "broken file" icon instead of a "folder" icon for missing projects
Fade out the project icon for missing projects
Use transparent modulate for grayed out projects as it results in better-looking text
Disable the "Edit", "Run" and "Rename" buttons if at least one missing project is selected
Make double-clicking or pressing Enter do nothing when a missing project is selected
Change the "Open in FileSystem" tooltip accordingly for missing projects
Don't connect the "Open in FileSystem" pressed signal to make the button ineffective for missing projects
Name missing projects as "Deleted Project" instead of "Unnamed Project"

Preview

Looks good, although I guess one could argue that Missing Project might fit even better (it could have been moved or renamed after all).
As for icon, I'd use a new one, combining icon_folder with icon_file_dead as icon_folder_dead. I've attached a quick edit, but can't figure out how to get a minified/simple SVG like the others.

@MarioLiebisch Thanks for providing an icon!
Unfortunately, it doesn't really scale down well. The "dead" icons were designed to be displayed at largere sizes, but at small sizes, details in the icon become hard to see:

I've still amended the pull request to use "Missing Project" instead of "Deleted Project". Thanks again for your feedback :slightly_smiling_face:

Yeah, true. Might need a different icon group/style showing it's actually missing.

Thanks!


npm run clean and npm run clean:all returns various errors

In trying to QA d56b84b79656b8b0483a858881a8ca83ed56ca8d, I first tried to run a npm run clean and npm run clean:all.
Both commands result in errors, but the errors seem to differ.
npm run clean
npm run clean
...
webpack built a4263e35f09fc642fb1c in 11977ms
webpack 5.90.3 compiled successfully

Seems to hang after "compiled successfully".
npm run clean:all
npm run clean:all

><EMAIL_ADDRESS>clean:all
> node meme clean --all

PATH         -- codebase located at: /Users/loh/dev/meme-2023/src
PATH         -- meme root folder located at: /Users/loh/dev/meme-2023
UR_EXPRESS   - COMPILING WEBSERVER w/ WEBPACK - THIS MAY TAKE SEVERAL SECONDS...
WEBPACK      - ... using webpack.base.config
WEBPACK      - ... using webpack.webapp.config
MEME EXEC    - removing dist/, data/, and built/ directories...
MEME EXEC    - directories removed!
MEME EXEC    - also removing node_modules/
MEME EXEC    - you will have to reinstall them with the
MEME EXEC    - npm ci command.
MEME EXEC    - operation complete!
node:internal/modules/cjs/loader:1143
  throw err;
  ^

Error: Cannot find module './hash/md4'
Require stack:
- /Users/loh/dev/meme-2023/node_modules/webpack/lib/util/createHash.js
- /Users/loh/dev/meme-2023/node_modules/webpack/lib/serialization/ObjectMiddleware.js
- /Users/loh/dev/meme-2023/node_modules/webpack/lib/util/serialization.js
- /Users/loh/dev/meme-2023/node_modules/webpack/lib/util/makeSerializable.js
- /Users/loh/dev/meme-2023/node_modules/webpack/lib/WebpackError.js
- /Users/loh/dev/meme-2023/node_modules/webpack/lib/DefinePlugin.js
- /Users/loh/dev/meme-2023/node_modules/webpack/lib/index.js
- /Users/loh/dev/meme-2023/src/config/webpack.webapp.config.js
- /Users/loh/dev/meme-2023/src/system/server-express.js
- /Users/loh/dev/meme-2023/src/system/server.js
- /Users/loh/dev/meme-2023/meme.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15)
    at Module._load (node:internal/modules/cjs/loader:981:27)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:177:18)
    at module.exports (/Users/loh/dev/meme-2023/node_modules/webpack/lib/util/createHash.js:169:17)
    at /Users/loh/dev/meme-2023/node_modules/webpack/lib/DefinePlugin.js:349:22
    at Hook.eval [as call] (eval at create (/Users/loh/dev/meme-2023/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:100:1)
    at Hook.CALL_DELEGATE [as _call] (/Users/loh/dev/meme-2023/node_modules/tapable/lib/Hook.js:14:14)
    at Compiler.newCompilation (/Users/loh/dev/meme-2023/node_modules/webpack/lib/Compiler.js:1139:26)
    at /Users/loh/dev/meme-2023/node_modules/webpack/lib/Compiler.js:1183:29 {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/loh/dev/meme-2023/node_modules/webpack/lib/util/createHash.js',
    '/Users/loh/dev/meme-2023/node_modules/webpack/lib/serialization/ObjectMiddleware.js',
    '/Users/loh/dev/meme-2023/node_modules/webpack/lib/util/serialization.js',
    '/Users/loh/dev/meme-2023/node_modules/webpack/lib/util/makeSerializable.js',
    '/Users/loh/dev/meme-2023/node_modules/webpack/lib/WebpackError.js',
    '/Users/loh/dev/meme-2023/node_modules/webpack/lib/DefinePlugin.js',
    '/Users/loh/dev/meme-2023/node_modules/webpack/lib/index.js',
    '/Users/loh/dev/meme-2023/src/config/webpack.webapp.config.js',
    '/Users/loh/dev/meme-2023/src/system/server-express.js',
    '/Users/loh/dev/meme-2023/src/system/server.js',
    '/Users/loh/dev/meme-2023/meme.js'
  ]
}

Node.js v18.20.2

@Sakelun I think there might be some errors related to webpack changes when we try to do npm run clean and npm run clean:all.
Can you guys take a look at that please?

@benloh claimfixed in #14
I've tested this issue and all of the scripts: start, dev, package, clean, and clean:all. The root cause was the insertion of an extra Start() statement in one of the core scripts that was likely introduced as a debug measure but kept by mistake.

@Sakelun Thanks!  Yes, it's helpful to flag this and assign it back to me.  I'll test it when we merge the PR.

Confirmed fixed!  Thanks!


Cannot select a custom design Report Layout

Describe the bug
I cannot select a custom design Report Layout. This Error appears:

To Reproduce
Try to select a custom report, which you have created for any report.
Expected behavior
No Error...
Versions:

Business Central: DE Dynamics NAV 13.3 (29060)

fixed


Fix spellcheck issue

Fix spellcheck issue, you may want to add a spellcheck action on your CI.
Detected in https://github.com/f3d-app/f3d/pull/1034/

Pull request checklist
Read the Contribution Guidelines for detailed information.

[x]  Changes are described in the pull request, or an existing issue is referenced.
[x]  The test suite compiles and runs without error.
[x]  Code coverage is 100%. Test cases can be added by editing the test suite.
[x]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

coverage: 100.0%. remained the same when pulling 59bd76c72582e315b08054ceaf0439967093a92d on mwestphal:fix_spellcheck into 35c0b3e54ce99716bf2a6bb6bdbd346f3e6d398b on nlohmann:develop.


Ubuntu 22.04.2 - could not find pthread_yield function

I cannot complete the build because this function is now deprecated.
https://manpages.ubuntu.com/manpages/lunar/man3/pthread_yield.3.html
How can I get past this? I had the same problem when trying on rocky 9.

No idea if this is ok but I replaced all pthread_yield text with sched_yield in 'configure' and that worked.
I ran 'configure' without errors then 'make' and 'make install' and that completed.
Again, no idea if I'm doing the right thing. Figured I've nothing to lose since I can simple restore the backup I made.

Is anyone monitoring these issues? Is it ok what I've done? It seems to work.

Here's a commit that removes pthread_yield usage entirely https://github.com/alistairking/libbgpstream/commit/4dd32e9c0b377415ff40093ff361dd301fc396b1

Thanks.
I changed the code in the file to the one you showed but now cannot compile.
make
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash /root/src/libbgpstream-2.2.0/missing aclocal-1.16 -I m4
configure.ac:65: error: AM_INIT_AUTOMAKE expanded multiple times
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:49: the top level
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:65: the top level
autom4te: error: /usr/bin/m4 failed with exit status: 1
aclocal-1.16: error: autom4te failed with exit status: 1
make: *** [Makefile:442: aclocal.m4] Error 1
`

You might need to re-run the bootstrapping scripts. From the README:

If you cloned BGPStream from GitHub, you will need to run ./autogen.sh before ./configure. Depending on your operating system, the ./autogen.sh execution may require a few extra packages to run. On Ubuntu, for example, you need autogen, autoconf, and libtool installed on the system before running the command.

I downloaded the source, there is no bootstrap.sh file. I believe I just went to .configure but not sure now. Have to figure it out from my history.

Oh yeah, if you're patching the source you'll need to get the full code from github rather than from a distribution tarball.

Sure, I can do that. Is that patch in the new source?

This should now be fixed by 2bce0f679c1703ef154588782af250ccd30c012e, which is part of the 2.3.0 release. Let me know if you still have issues with the latest release.


Use true as a default value for KNAPSACK_PRO_FIXED_QUEUE_SPLIT in Queue Mode for GitHub Actions, Buildkite, Travis, CodeShip

Use true as a default value for KNAPSACK_PRO_FIXED_QUEUE_SPLIT in Queue Mode for CI providers:

GitHub Actions
Buildkite
Travis
CodeShip

Examples:
GitHub Actions, CodeShip use the same CI build ID for retried CI node. In such a case, Queue Mode would think the queue is already consumed and there are no tests to run. You would expect to run the same set of tests as it was assigned to the CI node during the very first run. To achieve that, we use KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true then a retried CI node would run the same set of tests as on the very first run for a given (commit SHA, branch, and number of nodes).
Some CI providers like Buildkite (or Github Actions) allow you to retry an individual CI node. In such a case, you would expect to run the same set of tests as it was assigned to the CI providers. To do so, you need to set KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true.

@ArturT what if we make it true by default and set it to false where needed?
Since we should be able to configure all CIs, we can ensure this is always properly set. And, if the CI is "not supported," the behaviour is the most predictable (single retry gets the same tests). And the only downside is that full retries are slower (cached split instead of new split).

@3v0k4 I was thinking about it.
Maybe let's do something radical and use true as a default value (always) and leave false as an option to set if someone really wants to. This is what's done for regular mode with KNAPSACK_PRO_FIXED_TEST_SUITE_SPLIT=true default.
https://docs.knapsackpro.com/ruby/reference/#knapsack_pro_fixed_test_suite_split-regular-mode.
The biggest downside that I see by using KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true as default always is:
when someone retries the whole CI build (all parallel nodes are retried and a new CI build ID is used) AND the same (commit sha, branch, nodes) are used. Then tests are split based on the cache split (not well balanced). This should be a rare case, but in general, this would be when someone retries the whole build. But in such case, we can give users the answer that this is on purpose to run tests in the same order, but if they want, they can disable that with KNAPSACK_PRO_FIXED_QUEUE_SPLIT=false. I can image some users might want to run tests in a different order on purpose so that flaky tests are passed when run in a different order.
When you run tests locally with KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true and you keep testing something, for example during onboarding setup in development (if we recommend development setup first for new onboarding), you most likely work on the same commit hash so once you run tests once with a dynamic split (Queue split) then further splits will be cached even if you update CI build ID to a new one in development.

what if we make it true by default and set it to false where needed?

Maybe it should be set to false in development by default?
How can we know it is development environment? Maybe we should detect that non of the known CI provider env vars have been detected.
But this still might be a bit confusing that gem behaves differently in certain environments.
Maybe for the sake of simplicity, let's use  KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true as default always. If this will be problematic for someone, we can recommend using KNAPSACK_PRO_FIXED_QUEUE_SPLIT=false. In case of Regular Mode no one ever ask about this so maybe it wouldn't be a big issue for Queue Mode as well.
FYI @shadre

@ArturT

When you run tests locally with KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true and you keep testing something, for example during onboarding setup in development (if we recommend development setup first for new onboarding), you most likely work on the same commit hash so once you run tests once with a dynamic split (Queue split) then further splits will be cached even if you update CI build ID to a new one in development.

I haven't thought about the development case. At the same time, what's a good reason to want dynamic splits in development at the moment?
I'm pretty sure we will need to revisit some things anyway for the new onboarding, so I wouldn't mind this one too much now.
One problem I see with defaulting to a fixed split is if people onboard by retrying builds:

set up Knapsack
push
first (suboptimal) build completes
second build triggered with a full retry (same suboptimal build) instead of pushing a new commit

I haven't thought about the development case. At the same time, what's a good reason to want dynamic splits in development at the moment?

You mentioned it:

second build triggered with a full retry (same suboptimal build) instead of pushing a new commit

@3v0k4  I worry that people might think it's not optimal split when they do retry locally (the retry would be cache split). I suspect when someone does retries to set up something locally or debug issues with configuring their project locally, then they might experience cache split often. If so then there won't be mulitple batches of tests fetched from Queue API and it might be harder to reproduce a problem (a failing specs) that occurs only when you run many batches.

I worry that people might think it's not optimal split when they do retry locally (the retry would be cache split)

I cannot imagine people judging KS' perf in development. They would have to manually simulate multiple nodes and take the timings.

it might be harder to reproduce a problem (a failing specs) that occurs only when you run many batches.

Though, those batches are not the same batches because it's a new split. This could be a problem too in debugging.

second build triggered with a full retry (same suboptimal build) instead of pushing a new commit (Riccardo)

I'm still thinking about this one. If people onboard by retrying the first build on CI, they could be mislead.

Maybe we could also add some logging later on? Like printing out in the terminal the (auto)configuration of Knapsack:
Detected Github Actions, using KNAPSACK_PRO_FIXED=true (you can override this one)
Detected RSpec, using KNAPSACK_PRO_SPLIT=true (you can override this one)

Maybe we could also add some logging later on? Like printing out in the terminal the (auto)configuration of Knapsack:

Yes. I was also thinking about it.

second build triggered with a full retry (same suboptimal build) instead of pushing a new commit (Riccardo)

I'm still thinking about this one. If people onboard by retrying the first build on CI, they could be mislead.

Good point about being mislead unless they use different number of nodes on CI than in development.
If they use Github Actions they still might be mislead because they have to use fixed_queue_split=true

@ArturT ready for CR

@ArturT We definitely need to update docs; I'll do that when releasing. It's tracked already in the ticket thanks to your research 🙏


Fixes #571 annotations icon

Adds little comment icons when there are notes on an application letter

Coverage remained the same at 100.0% when pulling ba76a9894ebd005716b68ea06d50b01342097985 on 571_annotations_icon into 816c0d214c5fc79f74b4391b5ad151e90810225c on dev.

Coverage remained the same at 100.0% when pulling 637c653c2dbfc3eb16550176316b7b35f7b42ef8 on 571_annotations_icon into 816c0d214c5fc79f74b4391b5ad151e90810225c on dev.

Coverage remained the same at 100.0% when pulling 25aa4aef1db54898dc4456d7fc7ee91ba7bfa1e6 on 571_annotations_icon into 37853b15f41b3ee165b90a547c755dcfab104a90 on dev.

Coverage remained the same at 100.0% when pulling b3f3734f50abef027caffaa1c2a25f2790dbf2ec on 571_annotations_icon into dd4296ab5bc2db9d042654b582207695a661b02c on dev.