OCM-5034 | fix: Do not ask user about HCP account-roles when on fedramp + always classic on fedramp

User was prompted about HCP roles upon account-role deletion when using fedramp, this has been disabled for fedramp only
User was prompted about whether or not to use Classic roles when on fedramp, this has been defaulted to Yes and disabled for fedramp
Now role creation & deletion only deals with classic on fedramp
./rosa create roles --profile gov --region us-gov-west-1
I: Logged in as '<REDACTED>' on 'https://<REDACTED>.com'
I: Validating AWS credentials...
I: AWS credentials are valid!
I: Validating AWS quota...
I: AWS quota ok. If cluster installation fails, validate actual AWS resource usage against https://docs.openshift.com/rosa/rosa_getting_started/rosa-required-aws-service-quotas.html
I: Verifying whether OpenShift command-line tool is available...
I: Current OpenShift Client Version: 4.11.6
I: Creating account roles
? Role prefix: hk
? Permissions boundary ARN (optional):
? Path (optional):
? Role creation mode: auto
I: Creating classic account roles using 'user/hkepley'
I: Created role 'hk-Installer-Role' with ARN 'role/hk-Installer-Role'
I: Created role 'hk-ControlPlane-Role' with ARN 'role/hk-ControlPlane-Role'
I: Created role 'hk-Worker-Role' with ARN 'role/hk-Worker-Role'
I: Created role 'hk-Support-Role' with ARN 'role/hk-Support-Role'

./rosa delete accountroles hk --profile gov --region us-gov-west-1
? Role prefix: hk
? Account role deletion mode: auto
I: Deleting classic account roles
? Delete the account role 'hk-Support-Role'? Yes
I: Deleting account role 'hk-Support-Role'

? Delete the account role 'hk-Installer-Role'? Yes
I: Deleting account role 'hk-Installer-Role'
? Delete the account role 'hk-ControlPlane-Role'? Yes
I: Deleting account role 'hk-ControlPlane-Role'
? Delete the account role 'hk-Worker-Role'? Yes
I: Deleting account role 'hk-Worker-Role'
I: Successfully deleted the classic account roles

Tested and flow does not change in non-fedramp environment:
./rosa create account-roles
I: Logged in as 'hkepley_openshift' on 'https://api.stage.openshift.com'
I: Validating AWS credentials...
I: AWS credentials are valid!
I: Validating AWS quota...
I: AWS quota ok. If cluster installation fails, validate actual AWS resource usage against https://docs.openshift.com/rosa/rosa_getting_started/rosa-required-aws-service-quotas.html
I: Verifying whether OpenShift command-line tool is available...
I: Current OpenShift Client Version: 4.11.6
I: Creating account roles
? Role prefix: hk
? Permissions boundary ARN (optional):
? Path (optional):
? Role creation mode: auto
? Create Classic account roles: No
? Create Hosted CP account roles: Yes
I: Creating hosted CP account roles using 'arn:aws:iam:::user/hkepley'
I: Created role 'hk-HCP-ROSA-Installer-Role' with ARN 'arn:aws:iam:::role/hk-HCP-ROSA-Installer-Role'
I: Created role 'hk-HCP-ROSA-Support-Role' with ARN 'arn:aws:iam:::role/hk-HCP-ROSA-Support-Role'
I: Created role 'hk-HCP-ROSA-Worker-Role' with ARN 'arn:aws:iam:::role/hk-HCP-ROSA-Worker-Role'

 ./rosa delete account-roles
? Role prefix: hk
? Account role deletion mode: auto
W: There are no classic account roles to be deleted
? Delete hosted CP account roles: Yes
I: Deleting hosted CP account roles
? Delete the account role 'hk-HCP-ROSA-Installer-Role'? Yes
I: Deleting account role 'hk-HCP-ROSA-Installer-Role'
? Delete the account role 'hk-HCP-ROSA-Support-Role'? Yes
I: Deleting account role 'hk-HCP-ROSA-Support-Role'
? Delete the account role 'hk-HCP-ROSA-Worker-Role'? Yes
I: Deleting account role 'hk-HCP-ROSA-Worker-Role'
I: Successfully deleted the hosted CP account roles

/lgtm

@hunterkepley while we're at it, can you please modify create operator roles by prefix to skip the hosted CP question for the Fedramp environment?
Maybe we should also check if the --hosted-cp flag was provided, and return an error if the user provided the flag in a Fedramp environment.

Confirmed all commands exit when using --hosted-cp on govcloud, as well as the classic prompt does not appear when using govcloud

/lgtm

/lgtm


Incorrect lowercasing of params for nested routes

Taken from https://github.com/jorgegorka/svelte-router/issues/140

since this is a change which deals with route names this will be a breaking change from 7.1 - the lowercasing of the route names is a "feature" so this will be release in 7.2


⚠ Processors has degraded performance

In 00371ed, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 92 ms

Resolved: Processors performance has improved in 40df389.


Allow for using rustls instead of native-tls

Should restson maybe have parameters to allow for using rustls?

Hyper supports rustls so it should not be a big effort to add the support here, and I think such option parameter would make sense.
For now, it should already be possible (I haven't tested this) to use rustls by constructing your own Hyper client and using the with_client() in the builder: https://github.com/spietika/restson-rust/blob/master/src/lib.rs#L210
Though this is not very convenient so having it as an option would make sense.

This is now (finally) possible in version 1.4.0 by using rustls feature.


PBI-31-32: Edit & Delete Comment in Lesson Material

Student POV

Teacher POV

Teacher POV (student comment)

LGTM thank you uwu!


[BUG] Sometimes package managers fail to load installed packages

This happens with chocolatey (user reported) and with pip (self-reported)

Need to implement some kind of retry if package list is empty


unfeaturized slot/entity not working as expected

Rasa Core version: 0.10.4
Python version:  3.6
Operating system (windows, osx, ...): 0sx
Issue:
unfeaturized slot/entity not work
I am expecting utterance u_request{"city": "text", "state":"text"} will match exactly to story_0, because "state" is specified as "unfeaturized"
My intention:  I want "city" is required, and "state" is optional and  I don't want optional entity/slot impacting dialogue flow, and I don't need stories involving optional entities.
Content of domain file (if used & relevant):
slots:
  city:
    type: text
  state:
    type: unfeaturized

intents:
  - u_inform
  - u_request

entities:
  - city
  - state:
      type: unfeaturized

templates:
  goal.club_hours:
  - "dummy"
  Action.b_prompt.city:
  - "what is your city"

actions:
  - Action.b_prompt.city
  - goal.club_hours

Content of story file (if used & relevant):
## story_0
* u_request{"city": "text"}
  - goal.club_hours

## story_1
* u_request
  - Action.b_prompt.city
* u_inform{"city": "text"}
  - goal.club_hours

**sorry, the domain yml should be  (rasa_core don't allow set entity to be "unfeaturized":
Content of domain file:
slots:
  city:
    type: text
  state:
    type: unfeaturized

intents:
  - u_inform
  - u_request

entities:
  - city
  - state
templates:
  goal.club_hours:
  - "dummy"
  Action.b_prompt.city:
  - "what is your city"

actions:
  - Action.b_prompt.city
  - goal.club_hours

Yes, there is currently no way to make an entitiy unfeaturized completely, but you can make it so for specific intents, see this PR https://github.com/RasaHQ/rasa_core/pull/791

@lisongshan can we close this issue or do you need more help?

@akelad let me close it. thanks.


Getting always nginx welcome page

Hi,
I configured all correctly but I'm geting always the nginx welcome page.
I tried this http://stackoverflow.com/questions/24274387/using-laravel-homestead-no-input-file-specified, but no luck (couldn't execute: homestead up --provision).
What is the problem? How can it be solved?

You're using the wrong package. This box has no "homestead" command, and is not intended to be used as such. Follow the instructions in this post to the letter, and it will work: Homestead Improved


About the Adjacency Matrix

Hi,
Could you please tell me how to compute the adjacency matrix  for gcn baseline. Is the matrix extracted from Visual Genome or from the whole rooms?
Actually, I want to get the object relationships (e.g., the sink is next to the toilet) in a specific scene. However, I only find API to get the objects list in the scene with their centric coordinates. Because of the different scales of objects and coordinates of different rooms, I can not compute the connection relationship of the objects. Do you have any idea?
Thank you very much!

Hey, it's from visual genome and not per room -- more details in their paper!


wav file format

is there easy way in code to convert this to 16bit pcm instead of ieee float wav file which is not valid for openal to play

Check https://github.com/Artefact2/libxm/blob/master/examples/alsa_common.h#L170-L195


Defining String#to_a seems to break Sass

This is not a big problem but a strange behavior i've decided to report.  I think it is in sass, but could be in sass-rails.
If i define a custom String#to_a method, this seems to break Sass in Rails.
Steps to reproduce:

Create a new rails 3.2 application.

Create a controller:

$ rails generate controller Pages home

Add to app/controllers/pages_controller.rb:

class String
  def to_a
    chars.to_a
  end
end

Add to app/assets/stylesheets/pages.css.scss

$ab: #999;
$x: darken($ab, 10%);

(It is important that the $ab variable had at least 2 letters.)

Start the server and go to http://localhost:3000/pages/home, there is an error:

ArgumentError in Pages#home

Showing /Volumes/Data/Users/alexey/Development/rails_tests/test_sass/app/views/layouts/application.html.erb where line #5 raised:

wrong number of arguments (2 for 1)
  (in /Volumes/Data/Users/alexey/Development/rails_tests/test_sass/app/assets/stylesheets/pages.css.scss)
Extracted source (around line #5):

2: <html>
3: <head>
4:   <title>TestSass</title>
5:   <%= stylesheet_link_tag    "application", :media => "all" %>
6:   <%= javascript_include_tag "application" %>
7:   <%= csrf_meta_tags %>
8: </head>

I appreciate the report, but I'm closing this issue as invalid. It's my general feeling that if you're monkeypatching the core library, you should expect that to break code.

I understand, i simply thought that this behavior might be an indication of some other problem.


Complete swagger:route generator based on full OpenAPI router spec

Problem statement
Currently the swagger:route generator is incomplete and doesn't allow everything that's defined in the Paths Object and its children as specified in the OpenAPI (Swagger 2.0) spec.
Defining responses linked to status codes is already possible, but can currently only be defined when linked to an actual Golang type linked to an existing swagger:response Godoc comment. This is fine, and this behavior should remain to be supported, there are however situations where one cannot or doesn't want to link a REST API response to an explicitly defined type. In such cases it should be possible to define the response inline, as one can do in an actual OpenAPI spec file.
Defining parameters is currently also already possible, but again only when linked to an actual Golang type. Again this behavior should probably remain supported, but just as with Responses, we probably also should support inline definitions of parameters, as one would usually do when defining a pure spec file.
This is an enchantment issue to announce the work I'll be doing on this codebase to make this happen. I'll also keep a checklist of the tasks involved to get this issue 'solved', such that anyone can follow the work in progress. Please get involved if:

You are working on a very similar issue already;
You have feedback on the proposal and/or work in progress;
You know of related issues that I should take a look at, and potentially fix;

Tasks

[ ] Support Parameters as a multi-line tag, as part of the existing swagger:route specification;
[ ] Make Responses work similar to how it the OpenAPI::ResponseObject works, a reference should still be possible, but defining its schema completely inline should be possible as well;
[ ] Make it possible to define body response references, where the type does not need to be defined within an inline Body variable containing the actual definition;

Remaining open questions

What to do when a parameter is both defined inline as part of the swagger:route comment, and as a swagger:parameter comment?

Related issues

#782
#779
#361

This issue should probably be closed, as it might not be needed anymore after all.
Talking to @casualjim on slack helped me clarify things. It seems like I was making suggestions because I didn't fully understand the design behind go-swagger. I opened issue #791 so that documentation for this can be added, as I wasn't the first to talk to @casualjim about this. Secondly I opened issue #793 to support a new annotation, operation, that allows you to define a Path/Route as you would specify a Path Object in your Swagger YAML Specification.

fixed by #815


Chaining file formats breaks entry links

- Do you want to request a feature or report a bug?
Report a bug
- What is the current behavior?
If blog source files have chained formats (i.e. my-post.html.markdown), entry links are generated to my-post.html. This type of file naming scheme is required by middleman-blog.
- If the current behavior is a bug, please provide the steps to reproduce.

Create a blog source entry with a name ending in .html.markdown
Attempt to access the entry from the Netlify CMS UI.

- What is the expected behavior?
It should load the entry.
- What is the actual behavior?
It throws an "Entry not found" error, as the URL is missing the .markdown portion. Appending .markdown to the URL is the workaround.
- Please mention your node.js, and operating system version.
node version: 6.9.5
OS: Mac OS X 10.12.3
Using Middleman

As an additional data point; posts created and accessed entirely within the CMS don't suffer from this issue. Only affects previously-created entries loaded via the Contents API.

Misunderstood the nature of the issue. Closed in favor of #317.


Removing migration contracts from mssql

@corivera , are these sts changes okay to be brought in?
https://github.com/microsoft/sqltoolsservice/compare/<IP_ADDRESS>...<IP_ADDRESS>

Just realized that this version of sts still contains migration service in service layer. I have started a new build and wait for it to release.

Yeah, those changes are good to pull in.


Update test of ShadowAttack

Signed-off-by: Beat Buesser<EMAIL_ADDRESS>Description
This pull request updates the test of ShadowAttack to run with frameworks tensorflow and torch.
Type of change
Please check all relevant options.

[x] Improvement (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Codecov Report

Merging #556 into dev_1.3.3 will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           dev_1.3.3     #556      +/-   ##
=============================================
- Coverage      69.18%   69.10%   -0.08%
=============================================
  Files            132      132
  Lines          11256    11269      +13
  Branches        1900     1910      +10
=============================================
  Hits            7787     7787
- Misses          2792     2795       +3
- Partials         677      687      +10

Impacted Files
Coverage Δ

art/attacks/evasion/shadow_attack.py
15.87% <0.00%> (-0.26%)
:arrow_down:

...ted_gradient_descent/projected_gradient_descent.py
58.57% <0.00%> (-9.23%)
:arrow_down:

art/defences/detector/poison/activation_defence.py
84.84% <0.00%> (-0.34%)
:arrow_down:

@killianlevacher Thank you!


Add LazyFrame version of to_ipc/3 (#499)

Adds the to_ipc function for the lazy backend as it was done for to_parquet.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


Ingestion Pipeline and Metadata Management process overview

The Data Governance group needs a user view of pipeline management metadata use to understand the role of the data owner / steward / architect in the process.

First draft sent / reviewed with Data Governance and Management group on Monday 15/02/2022. To add quality gates in the data pipeline into the diagram - a key role of the data domain owner being defining data quality SLA and therefore testing gates to ensure SLA is met before releasing data.

Agreed to close this item as overview was presented to the Data Governance group. Extreme storming sessions to be arranged for each specific streams and specific issues raised for each stream to track the dependencies with Data Commons.


Capped is set to false when attempting to create collections after being deleted

Hey,
I've been investigating some issues we've been having at work and one of them is the failure to setup collections if they are deleted or disappear (we have been having issues with queues and a "fix" was to simply delete the mongo storage), but unfortunately the collections arent correctly created after they're gone as you can see:

When the service is first brought up, it correctly adds the collections.

When the collections are deleted, the collections are not only missing (due to some other issue, not sure) - but capped is set to false which causes about 500,000 errors to be thrown every 30 minutes.
Here is one time where it successfully created all the necessary tables but capped was still set to true:

As you can see, it throws a lot :D

I think you're right, that we should never "have" to delete collection but unfortunately we seem to have a use case where:

Deploy service + HF to cluster (this is another issue in and of it self it seems, but regardless)
Need to deploy due to contract / code changes etc
Need to remove collections in mongo ( + rehydrate other collections) -> easier to simply just drop mongo db itself (to flush the queue if we cant afford to wait for example)
Service (HF) shits itself (regardless if we drop mongo before or after, it will need to be redeployed)

The issue here is that the HF seems to die, spams logs and is generally unrecoverable - we currently use mongo on other services and we seem to have no issue simply dropping the collection (it then recreates it automatically and continues).
I'm not so well versed in mongo (or really HF at this point) - is there some way to set up the driver to be able to recover better?

@Memhave,
I'm not sure I fully understand the need for deleting the "notifications" collection. Do you Delete that collection only?
MongoDb needs to know if you want to create capped collection, which the "notifications" collection is. If you simply do GetCollection, and the collection has been dropped, it will create a default collection. eg NOT a capped collection. in Hangfire.Mongo we create the in a migration step so if dropped you need to manually tell mongodb that the notifications is capped. We add to the "notifications" collection each time we do queue a job or release a hangfire lock, so its quite frequent.
You can read more on capped collections here.
Would it be possible to simply drop the entire DB instead of collections? then the migrations would run again at startup?
It would be interesting to hear more on why HF service shits itself
more on capped collections
https://docs.mongodb.com/manual/core/capped-collections/

@gottscj
Thank you for the link, I'll take a read.
I did try to simply drop the whole DB itself, but the "issue" persists.
Unfortunately, we've moving away from HF (and "smart" solutions) and simply going without for now, but thank you for your help :).
Feel free to close the issue.

Hi @gottscj - thank you for your work. We had a similar problem, and found our server disabled due to 'out of space' on the logging disk. It had written over a terrabyte of log entries!
I believe dropping all HF collections solves it.

Hangfire.Mongo.MongoNotificationObserver[0]
Error observing notifications
MongoDB.Driver.MongoCommandException: Command find failed: error processing query: ns=wom._hangfire.notificationsTree: _id $gt ObjectId('5d555f5df7f761101b95e9ce')
Sort: {}
Proj: {}
tailable cursor requested on non capped collection.
at MongoDB.Driver.Core.WireProtocol.CommandUsingCommandMessageWireProtocol1.ProcessResponse(ConnectionId connectionId, CommandMessage responseMessage)          at MongoDB.Driver.Core.WireProtocol.CommandUsingCommandMessageWireProtocol1.Execute(IConnection connection, CancellationToken cancellationToken)
at MongoDB.Driver.Core.WireProtocol.CommandWireProtocol1.Execute(IConnection connection, CancellationToken cancellationToken)          at MongoDB.Driver.Core.Servers.Server.ServerChannel.ExecuteProtocol[TResult](IWireProtocol1 protocol, CancellationToken cancellationToken)
at MongoDB.Driver.Core.Servers.Server.ServerChannel.Command[TResult](ICoreSession session, ReadPreference readPreference, DatabaseNamespace databaseNamespace, BsonDocument command, IEnumerable1 commandPayloads, IElem          at MongoDB.Driver.Core.Operations.CommandOperationBase1.ExecuteProtocol(IChannelHandle channel, ICoreSessionHandle session, ReadPreference readPreference, CancellationToken cancellationToken)
at MongoDB.Driver.Core.Operations.CommandOperationBase1.ExecuteProtocol(IChannelSource channelSource, ICoreSessionHandle session, ReadPreference readPreference, CancellationToken cancellationToken)          at MongoDB.Driver.Core.Operations.ReadCommandOperation1.Execute(IReadBinding binding, CancellationToken cancellationToken)
at MongoDB.Driver.Core.Operations.FindCommandOperation1.Execute(IReadBinding binding, CancellationToken cancellationToken)          at MongoDB.Driver.Core.Operations.FindOperation1.Execute(IReadBinding binding, CancellationToken cancellationToken)
at MongoDB.Driver.OperationExecutor.ExecuteReadOperation[TResult](IReadBinding binding, IReadOperation1 operation, CancellationToken cancellationToken)          at MongoDB.Driver.MongoCollectionImpl1.ExecuteReadOperation[TResult](IClientSessionHandle session, IReadOperation1 operation, ReadPreference readPreference, CancellationToken cancellationToken)          at MongoDB.Driver.MongoCollectionImpl1.ExecuteReadOperation[TResult](IClientSessionHandle session, IReadOperation1 operation, CancellationToken cancellationToken)          at MongoDB.Driver.MongoCollectionImpl1.FindSync[TProjection](IClientSessionHandle session, FilterDefinition1 filter, FindOptions2 options, CancellationToken cancellationToken)
at MongoDB.Driver.MongoCollectionImpl1.UsingImplicitSession[TResult](Func2 func, CancellationToken cancellationToken)
at MongoDB.Driver.MongoCollectionImpl1.FindSync[TProjection](FilterDefinition1 filter, FindOptions`2 options, CancellationToken cancellationToken)
at Hangfire.Mongo.MongoNotificationObserver.Execute(CancellationToken cancellationToken)
fail: Hangfire.Mongo.MongoNotificationObserver[0]
Error observing notifications

@hitchhiker,
yikes. I will make a patch so that if the notifications observer fails with "NotCapped" failure. I will not try to read from that collection again. If the observer is not running, Hangfire.Mongo will behave like the previous versions where we poll for locks and queued jobs. I will add a error log entry though.

I added #215. If Hangfire.Mongo gets an MongoCommandError (if not capped), it will not try to restart the observer.
It will report an (one) error and stop. documents inserted into the notifications collection will not be cleaned up and Hangfire.Mongo will fallback to rely on polling for queued jobs and released locks.

closing


Add new session & SSO features

Add the following features:

Update existing Crowd session if session cookie is included in the request instead of credentials (Credentials override the cookie). This feature is bound to use_sessions parameters. Multiple cookies with the same name are supported (The correct one is found by validating against the Crowd API).
The session cookie name can be changed with parameters session_cookie. Defaults to 'crowd.token_key'
Sessions are now created (And validated on update) using the client IP address (Retrieved from X-Forwarded-For header or REMOTE_ADDRESS environment variable). This is needed at least for session validation if the session was created with a remote address validation factory.
Add support for using external SSO page using parameters sso_url and sso_url_image. If sso_url is defined the login form will have a link to the SSO page. The link will be decorated with a image is sso_url_image is defined.

NOTE
This commit breaks compatibility with older versions. The API itself doesn't break compability but the use_sessions parameter triggers new functionality.
Also, as keyword arguments are used the software depends on Ruby >= 2.0.0.

Closing these. One more commit needed. I'll bundle it with the other two and create a new PR.


fix(cloud_functions): bubble exceptions

Description
Ensures that thrown exceptions on VSCode are bubbled back up to the original error handler.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@Ehesp whats the status of this?

I don't quite understand what this does
The description implies that it fixes a problem, but from the code, I see no behavior change –this looks more like a refactoring.
So I'm confused

@rrousselGit for context: https://github.com/FirebaseExtended/flutterfire/issues/3475
No behaviour change, however fixes issues with VSCode debugger not catching errors.

Closing this in favour of a new PR with Null Safety and better tests. https://github.com/FirebaseExtended/flutterfire/pull/5869


move_topic_to_stream: Delete UserMessage for new stream unsubs.

For users who are unsubscribed from the new stream but are in
the old stream, we delete the UserMessage.
We send the delete_message event only to guest users,
who have completely lost asses to the moved messages, for other
users we send the normal update_message event which moves
the messages to the new unsubed stream which
otherwise would look broken to the
user without reloading to the webpage.

@timabbott do we need to run a script for already moved messages?

do we need to run a script for already moved messages?

No; the previous model is a valid user experience, given that we don't allow private streams; it's just not what we'd intended.

@timabbott updated this.

Merged as the series ending with 0c48c759200a95a37ecdc0c94a5e5e2c5528a339, after adding a bunch of cleanup commits and a fix for the semi-test failures we've been seeing.  I feel like there's a secondary bug that the exceptions here weren't failing the test suite entirely; more in the czo thread.

Okay. I will put more thought into it.


fix(docs): missing hyperlink

Motivation/Description of the PR

Type of change

[x] :clipboard: Documentation changes/updates

I don't understand how these empty links actually occurred
I would prefer to try to find the cause instead of adding a patch

Thank you for investigating and improving runok!
Looks good :+1:


Accounts: instance select design

implement primary action card form mui https://mui.com/material-ui/react-card/#primary-action

Need:

[ ] open Manager link
[ ] open preview link(s)
[ ] open live domain link(s)


Unreachable code in operations

Using version 11.17.21 from NuGet.
Example yaml and generated code in a gist here.
When generating a client for operations with typed default responses, after all the different cases for status codes, an extra else branch is added to handle the default response, but after this, an extra line (line 135 in my example) is added with a return, which causes build errors because it's dead code (all branches of the status if either throw or return).
I didn't try to understand all possible cases in the corresponding template, but I see that if I remove the default response from the YAML, then there's no conditionless branch in the if-else, so this last return statement makes sense, but in other cases, it's problematic.

Just avoiding
                    return default(ExampleClass);

in this case would solve the problem?

Yes, that would fix this particular case.


Fail to render Counter events on multi-thread trace

Perfetto can't render Counter events for multi-thread trace, not sure what went wrong.
{
	"traceEvents": [{
		"pid": 1,
		"tid": 1,
		"name": "test",
		"ts": 1,
		"dur": 1000,
		"ph": "X",
		"cat": "fee"
	}, {
		"pid": 1,
		"tid": 2,
		"name": "test",
		"ts": 1,
		"dur": 1000,
		"ph": "X",
		"cat": "fee"
	}, {
		"pid": 1,
		"tid": 2,
		"name": "counter",
		"ts": 5,
		"ph": "C",
		"args": {
			"value": 4
		}
	}]
}

It works if the Counter event does not have tid field. The chrome trace format mentioned the Counter events are "process-local", but the examples it gave in https://github.com/catapult-project/catapult/blob/master/tracing/test_data/instance_counters.json does have tid field.
It also works if there's only one thread in the process(and of course the Counter event has the same tid as that thread).
I think this should be considered as a Perfetto bug and should in theory be easy to fix?

Observed the same issue, Counter event with tid works in catapult_trace_viewer, but not Perfetto. And after deleting tid, it works as expect.

Fixed by https://github.com/google/perfetto/commit/9953102813e473dba8cd7d714d70ca33d1a98fb7


feat(quic): support rustls provider aws-lc-rs

Also see quinn-rs/quinn#2056

What if two features enabled together?
What if the user would like to use another crypto provider?

What if two features enabled together?

The user has to set a default provider via CryptoProvider::install_default or rustls will complain.

What if the user would like to use another crypto provider?

quinn-proto does not support other providers.

https://github.com/actions/setup-go
Use setup-go to specify a go version and run clippy CI.

What if the user would like to use another crypto provider?

quinn-proto does not support other providers.

Pretty sure it does, but not with any built-in support.

Pretty sure it does, but not with any built-in support.

@djc Well, you're right. There's only a little problem here: if neither rustls-ring or rustls-aws-lc-rs enabled, ring will not be imported in quinn-proto. If the user want to use a third-party provider, they need to at least introduce ring or aws-lc-rs together into the project.

Pretty sure it does, but not with any built-in support.

@djc Well, you're right. There's only a little problem here: if neither rustls-ring or rustls-aws-lc-rs enabled, ~ring~rustls will not be imported in quinn-proto. If the user want to use a third-party provider, they need to at least introduce ring or aws-lc-rs together into the project.
EDIT: ring -> rustls

That's fair. We could conceivably add a rustls-no-provider feature that doesn't pull in a crypto provider via rustls. The problem is that quinn-proto itself needs a bunch of non-TLS crypto which is currently also implemented using ring/aws-lc-rs so I guess, from that point of view @AsakuraMizu is correct in stating that Quinn does not currently support other backing cryptographic libraries.


ZeroShotClassifier not found

Hi,
I have Pytorch installed but I still get 'module 'ktrain.text' has no attribute 'ZeroShotClassifier' error. Any suggestion? ( Great library for NLP by the way, thanks for your work!)

Hello: Are you sure you're using the latest version of ktrain (v0.16.3 as of today)?
What does this output?
import ktrain
print(ktrain.__version__)

If you copy and paste this into Google Colab (and set Runtime to GPU) it works with no problem:
!pip3 install -q ktrain
from ktrain import text
zsl = text.ZeroShotClassifier()
topic_strings=['politics', 'elections', 'sports', 'films', 'television']
doc = 'I am unhappy with decisions of the government and will definitely vote in 2020.'
zsl.predict(doc, topic_strings=topic_strings, include_labels=True)

I'm using Spyder for this one and apparently my ktrain version is 0.14.6. I installed it via pip before, how can I upgrade to 0.16.3?

OK - that's the issue then, as ZeroShotClassifier wasn't added until v0.16.0.  You can upgrade to current version using either  pip3 install -U ktrain (or pip3 install ktrain==0.16.3 for specific version).   It should work once you upgrade.  Thanks.

Ah that came out too easy, I though I had the recent version. Thanks so much!


titanic dataset visualisation

:100: :+1: good one! please make the commit history clean and commit messages the same
:tada: Congratulations on the first submission!

sure sir
thank you!


Sell Button should be green, not red

correct colour:
.btn-danger {
background-color: #00ea90!important;
}

Done PR https://github.com/dexlab-io/DexEx/pull/38

@aesthytik can you please attach a screenshot?


Fix the Gemma generation

Fix the problem in generation.
Aligned with https://github.com/pytorch/torchtune/blob/main/torchtune/modules/transformer.py .
Context
What is the purpose of this PR? Is it to

[ ] add a new feature
[x] fix a bug
[ ] update tests and/or documentation
[ ] other (please add here)

Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?

Change mask = self.causal_mask[None, None, input_pos] to mask = self.causal_mask[None, input_pos].
Make GemmaTransformerDecoder aligned with TransformerDecoder in TransformerDecoder.py .

Test plan
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

[ ] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[ ] add unit tests for any new functionality
[ ] update docstrings for any new or updated methods or classes
[ ] run unit tests via pytest tests
[ ] run recipe tests via pytest tests -m integration_test
[ ] manually run any new or modified recipes with sufficient proof of correctness

[ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

Using tune generate does not seem to cause any problems, but if I reproduce and rewrite a generation method, the mask will have an extra dimension at that point. After the modification, the problem will not occur.
Actually I'm not sure if this repository needs this modification, if you have any questions, please let me know.

Yeah, I Update the docstrings.

Yeah, I Update the docstrings.

Sorry, there are some problems with docstring. I will modify it soon.

Failure is related to https://github.com/tensorflow/tensorboard/issues/6869, not anything wrong with this PR. Investigating now

@solitude-alive Can you rebase on main? I just merged #1095, which should allow the workflows here to pass.

Yeah, I merged main manually, is this work?


searchguard  SSL//TLS Received fatal alert: bad_certificate on reindex

Hi.
We have configured searchguard TLS/SSL module with the next configuration:
Elasticsearch 5.5.2
searchguard.ssl.http.enabled: true
searchguard.ssl.http.clientauth_mode: REQUIRE
searchguard.ssl.transport.resolve_hostname: false
When we try to launch reindex api from Elasticsearch to create a copy of indexes including the host we get the next Error:
"type": "s_s_l_exception",
"reason": "Received fatal alert: bad_certificate"
The sentence is:
curl -k -XPOST --cacert truestore.pem  --cert cert.pem https://coordinator-01:31504/_reindex  -d'{
"source": {
"remote": {
"host": "https://coordinator-01:31504"
},
"index": "test"
},
"dest": {
"index": "text2"
}
}'

This is already known: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/search-guard/OgvmsMR6mZo/u_QZX_2gBAAJ
Upstream issue is https://github.com/elastic/elasticsearch/issues/27267

Seem coming with 6.7+ https://github.com/elastic/elasticsearch/pull/37527


Handle Community Note data existing without note

When I had been testing this library, I got error messages related to the Community Notes data. It turns out, as a Community Notes contributer, I get the birdwatch_pivot property attached to the tweets I view if there are any Community Notes on the tweet, even if none of them are visible.
My change simply checks for the existence of the note property on the note before getting its data.

Summary by CodeRabbit

New Features

Enhanced the assignment of community notes in tweets to include more detailed information when available.

Thank you


Consistent filename/namespace names

Right now namespace filesnames can be different from the namespaces they contain. I think this can get quite confusing and would propose to use consistent namespace/filenames.
For example, the contour_hz.json file contains a namespace pitch_contour, which is extra confusing because we have a bunch of namespaces for representing pitch. Pitch can be represented either as note or contour, and those in turn are expressed in units of hz/midi. pitch_contour doesn't make it explicit that the unit is in hz. Also, for all the other pitch namespaces the filename does match the contained namespace.

I think this is not a huge deal.  The filenames are for internal use only, and no user-facing code should even be aware that namespace definitions live in json files at all.

@justinsalamon Can we mark this as won't-fix and close it out?


Is there a way to code in JS instead of coffescript?

Yes, if you use Framer.js directly (as described in the readme) you’ll see that the example is in JavaScript. Framer Studio however uses CoffeeScript.


Move mWriteResponseBuilder in WriteHandler to stack

As a followup (please do not try to address this in this PR): is there a reason mMessageWriter and mWriteResponseBuilder need to be persistent members of this object?  Shouldn't they just have stack lifetime here?
Originally posted by @bzbarsky-apple in https://github.com/project-chip/connectedhomeip/pull/13641#discussion_r802261592

OK, mWriteResponseBuilder is used in a bunch of methods called from various places outside this class, so having it be a member makes some sense.  But mMessageWriter I am pretty sure we can move.


Meaningful ECS service health checks

Some of our web application / API services expose health check endpoints, but none of these actually perform a meaningful check for service health.
There are 2 primary consequences of this:

ECS doesn't know that it needs to restart applications that have got into a broken state (we have had to do this manually sometimes)
During deployments we see a small number of failed requests due to the service not being able to serve requests at the time it receives them (see https://github.com/wellcomecollection/wellcomecollection.org/issues/10513)

Here are the services which need health checks adding/improving:

[x] Catalogue API: https://github.com/wellcomecollection/catalogue-api/pull/736
[ ] Content API: https://github.com/wellcomecollection/content-api/pull/94
[ ] Items API: https://github.com/wellcomecollection/catalogue-api/pull/739
[ ] Content (wc.org) webapp

Flagging that for wellcomecollection.org the healthcheck endpoints are HTTP but still terminate at the nginx container: https://github.com/wellcomecollection/platform-infrastructure/blob/main/images/dockerfiles/nginx/frontend.nginx.conf#L24


Docker loading forever on Mac

Hi,
Did anyone successfully building the codebase on Mac?
I'm trying to docker load the webpages on Mac, however
for my MacBook with intel, docker load command takes forever;
for my MacBook with M1X chip, it can load the 9G website, but for larger ones, it keeps getting "unexpected EOF" error.
Does anyone know how to deal with this? Thank you!

@kohjingyu Hi, thank you for the reply! May I know if you set 160GB to load all the webpages at once? As the file sizes add to up to more than 160GB, how do you get the number then? Thank you!

160GB for the shopping site only. @frankxu2004 do you thoughts on an estimation on the Docker virtual disk limit?

I wonder if it is possible to optimize the image size for each enviroment.
We have shop 72G, shop admin 9G, reddit 50G, gitlab 72G, wikipedia 89G here.


Add ISSUE_TEMPLATE.md files

Add issue templates to the .github folder of the repository.

We recently removed this as it felt like a hindrance.


LOCALEDIR=locale ./testlang
cupsLangGet("UåWè¾É"): FAIL (got "C")
cupsLangGet("UåWè¾É") again: FAIL (got "C")

This seems to be either a failure of cups_dentry_t::filename, or of test_language().

Weird, I'm not seeing this in the Github builders. Can you check the contents of the "cups/locale" directory in the build directory?

I've tested to add a cross-build to i686 on Github actions, and the testlang run fails there too.

@OdyX OK, so I still need to see the contents of that locale directory - something is messed up there!

(sorry for the mistaken close of this, I had two git issues open and didn't pay attention...)

I've added an "ls -al locale" in the makefile before testlang is run, just to see what is going on...

OK, so this remains weird. I added unit tests for the cupsDir functions (long overdue, but they are simple wrappers on Linux) as well as the "ls -al locale" and I can't figure out why the test is still failing.
Will continue to look at this but definitely not obvious to me...

[master 91fe48974] Make sure 'lang' is initialized.
The "lang" variable wasn't initialized, but the 64-bit runtime cleared the stack while the 32-bit runtime doesn't... :(
(and none of the code scanning programs caught it...)

Oah. That was a tough one. Nice job!


[BUG]: Fluent people picker reset or preselect based on record

Describe the bug
Regarding the fluent peoplepicker (1.0.22). We are trying to implement this component but we cannot get the component to reset i.e. empty the selectedPeople or prefill the selectedPeople based on a selected record.
To Reproduce
Steps to reproduce the behavior:
for the following properties
selectedPeople, PreselectedUserCollection, UserCollection
We tried :

Clear action
Set to Blank() or set to PreselectedData based on Selected record
RemoveIf() or remove
...

Expected behavior
An empty peoplepicker :D

I would like to add that:

OnSelect does not working
OnChange is executing on loading the screen if Items property has been configured


BotInfo

Hello sir for the botinfo command, is this discord.js version 11 or 13, i want one of those because i have hanlder

Hello sir for the botinfo command, is this discord.js version 11 or 13, i want one of those because i have hanlder

This is for v14. and No we don't go below v14 but if u do want to use then use our template https://github.com/LogicNovaX/DJS-v14-BotTemplate-v2


Implement Transaction::keys_with_tombstones

Returns all existing keys within the specified range, including soft-deleted and thus hidden by tombstones.
This is needed for the REMOVE WITH EXPUNGE functionality to work properly in SurrealDB. Without this change soft-deleted keys and their values will not be removed.
Let me know if another name is a better choice for this method. Maybe all_index_keys()?

LGTM! Name is very explicit and clear


Update support for Python 2.6+

As discussed here, there's a discussion to drop support for Python 2.4.
This pull takes the first step by updating the README, removing pre-2.6 library imports, and 2.6+ style exception syntax.
Moved https://github.com/joestump/python-oauth2/pull/177 to develop branch here.

LGTM @joestump

Is 2.5 even supportable? Travis doesn't run it so it'll never be ci tested.
I thought the new exception as syntax was backported to 2.6+ only...

I agree with @hayd. Honestly we should probably discuss a 2.6 EOL at some point in the next 12-18 months. I say we go 2.6+

I hadn't realised that. I agree also...

I confirmed that tests currently pass under 2.5, but you have to install an old version of mock to run them.
I'm not particularly persuaded to drop a version because of the CI used, but the exception syntax makes it really difficult to move forward.
So altogether, I support dropping 2.5 as well.
I'll update this PR.

This PR now updates README to 2.6+, removes pre-2.6 library imports, and 2.6+ style exception syntax.
@jaitaiwan @joestump this can go. I'm going to work on getting the 3.3 and 3.4 tests to pass.

There's going to be many merge conflicts in resolving these (e.g. the exception as syntax). We should fix up/merge #142 first.

I concur with @hayd. We should get PT3K merged in first. Also @jaitaiwan you should release what we have in master if you're comfortable as 1.9-RC1 IMO.

Ok, @rickhanlonii are you happy for current master to be 1.9-RC1?

Yeah I'm good with that.

@rickhanlonii probably need this updated since we've released 1.9

This is no longer relevant. README.md was already updated with the correct versions and syntax has been updated.


refactor: Refactor several components for improved UI and accessibility

Hello @manojVivek,
This pull request addresses issue #41 by replacing BlurSVG with a static SVG background. I focused on enhancing the UI and accessibility of the SVG elements used in the BlurBG component. The improvements include adding ARIA attributes, titles, and descriptions to enhance screen reader compatibility. Additionally, I addressed minor errors in other components to ensure a smoother user experience.
Changes Made:
BlurBG component:

Added role="img", aria-label="Bubbles 1", and  for improved accessibility.
Included a  element to provide a detailed description of the SVG content.
BluePurpleRedBubbles SVG:
Added role="img", aria-label="Blue Purple Red Bubbles", and  for improved accessibility.
Included a  element to provide a detailed description of the SVG content.
Container div in BlurBG component:
Set role="presentation" and aria-hidden="true" to indicate that it is decorative and should be ignored by screen readers.

Footer component:

Fixed the typo in the class, preventing it from appearing in the console error.

Testimonials component:

Removed<PHONE_NUMBER>361778688 from the list to prevent it from blocking the load time due to a non-existent ID, presumably because someone deleted their Twitter account.

Testing Done:

Tested locally in multiple browsers (Chrome, Firefox, Safari) and verified improved screen reader compatibility.
Checked for any potential visual regressions or layout issues.

Thanks,
Luis

I created another ticket, #30, to address performance issues. Please let me know if you prefer not to merge it, and I can close the ticket.

Sorry, missed the other one, merged both now! Thank you so much for these improvements! ♥


fix build on travis equalsraf/neovim-qt#88

Travis cannot download LuaJIT from the official download location, see:
http://www.freelists.org/post/luajit/luajit-git-is-not-accessible-from-Travis-CI
https://github.com/moteus/lua-travis-example/issues/19
and
https://github.com/equalsraf/neovim-qt/pull/88
Change the the resource location for LuaJIT to the github mirror. The
resource has to be renamed because a resource caching bug in Homebrew
breaks the build otherwise. The staging directory is still set to
"luajit".
Formula is tested and works.

Pushed a commit using the URL redirect result, plus a fixed commit message.


04 SEP 2024 - Diversity Equity & Inclusion Special Interest Group Meeting

Date
20240904 - 12:00pm EST / 5pm GMT
Untracked attendees

Fullname, Affiliation, (optional) GitHub username
...

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[x] Convene & roll call (5mins)
[ ] Display FINOS Antitrust Policy summary slide
[ ] Review Meeting Notices (see above)
[ ] Approve past meeting minutes

[ ] https://github.com/finos/DEI-SIG/issues/64

FINOS Community call

[ ] DEI co-chair to write slide and present on 11th September call

OSFF Planning

[ ] Update on September 1st DEI Session networking session & panel #52 (Rimma)
Addressing Bias in AI outputs from OSFF London 2024 to be shared as at AI Readiness panel contribution on the AI Readiness Keynote panel by Prachi Kashodian (Rimma)

GHC Planning

[ ] Open Source Day #56 - help needed/agree promotion needs with FINOS & ANita B/sponsorship opportunities for FINOS members/speakers (Paula)
[ ] #66
[ ] FINOS GHC presence at Morgan Stanley booth opportunity (Rita)
-August 2024 DEI SIG event Co-hosted with AnitaB.org Boston Community #58 Work with FINOS - outcomes and feedback (Paula)

Projects

[ ] Natwest follow on - Best Practices for DEI as a focused project & applying OSR model potential (LeeAnn & James)
[ ] DEI Project badge to FINOS Projects and promote the work #60 (Paula)
[ ] Updating DEI Github page goals/OKR messaging & FINOS microsite #43

[ ] Need volunteer(s) for content creation

Events planning through the rest of the year #40 (Kajaal)

DEI SIG Participant Recruiting #49 (Sergio) - call for additional GitHub task owners/maintainers

[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

Meeting Info
Join Zoom Meeting
https://zoom.us/j/94969868675
Meeting ID: 949 6986 8675
Passcode: 184472

Eteri / FINOS

Rimma FINOS

Peter Smulovics / Morgan Stanley

James McLeod and Lee-Ann Sansom / NatWest

Karl Moll / FINOS


nmrCV calibration compound vs reference compound confusion reflected in CHEBI - unasign roles

Dear ChEBI team,
we as NFDI4Chem has been working on curating NMR calibration compounds in nmrCV which lead us to find some errors there, mainly confusing the two concepts "calibration compound" and "reference compound, the peak shift is 0". As some of the definitions and entries were added to CHEBI referencing nmrCV, here you can find all the needed corrections and enhancements:

[ ] CHEBI:228364 - NMR chemical shift reference compound definition:  A compound that produces the peak used as reference frequency in the δ chemical shift scale.

Old definition included "data pre-processing" which isn't always true.

[ ] Remove the role reference compound from the following list. Some came from nmrCV and some were added by CHEBI team. However, this list is in actuality a collection of solvents, calibration compounds, and others, not references. While all reference compounds can be found in IUPAC recommendations 1, 2:

[ ] CHEBI:47032 - 1,4-dioxane
[ ] CHEBI:85365 - deuterated chloroform
[ ] CHEBI:85363 - sodium 3-(trimethylsilyl)propionate
[ ] CHEBI:55317 - tetramethylammonium bromide
[ ] CHEBI:34856 - morpholine
[ ] CHEBI:85364 - ammonium bromide
[ ] CHEBI:16227 - pyridine
[ ] CHEBI:63005 - sodium nitrate
[ ] CHEBI:55317 - tetramethylammonium bromide
[ ] CHEBI:228806 - 2,2-Dimethyl-2-silapentane-5-sulfonate

The correct reference is the Sodium salt, which already has the role in CHEBI.

[ ] CHEBI:38472 - acetonitrile
[ ] CHEBI:32954 - sodium acetate
[ ] CHEBI:85486 - 3-(trimethylsilyl)propionate
[ ] CHEBI:183318 - triphenylphosphine
[ ] CHEBI:36601 - triphenylphosphane oxide

The rest I believe came from CHEBI team for 19F, while the only reference there is CCl3F (IUPAC), so they need to be removed too.

[ ] CHEBI:36810 - (trifluoromethyl)benzene
[ ] CHEBI:38585 - 1,4-difluorobenzene
[ ] CHEBI:33093 - boron trifluoride

check IUPAC page 80 for Boron

[ ] CHEBI:30236 - difluorine
[ ] CHEBI:39429 - hexafluoroacetone
[ ] CHEBI:38589 - hexafluorobenzene
[ ] CHEBI:29228 - hydrogen fluoride
[ ] CHEBI:5115 - monofluorobenzene
[ ] CHEBI:66872 - potassium fluoride
[ ] CHEBI:30496 - sulfur hexafluoride
[ ] CHEBI:45892 - trifluoroacetic acid

Our apologies if you are using a different source to assign the references other than IUPAC, then part of this issue will be invalid.
Thanks a lot.

@NRayya I have removed the above compounds from having the NMR chemical shift reference compound role (CHEBI:228364). Please double check the list again (https://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:228364). If anything else needs removing, let me know. Thanks

Dear @amalik01
I checked the list and it is accurate, thanks a lot

great, thanks. I am closing this issue.


CREATE DATABASE location

#451 implemented support for CREATE DATABASE queries.
It includes two tests for the query.
Statement::CreateDatabase has two additional fields: location and managed_location. The syntax for these is not detailed; neither in the PR, nor anywhere else I can find.

Perhaps this could be detailed in the docs
Perhaps tests could be added for these fields
What is the syntax for these fields?

@KyGost hey! I'm a new maintainer of SQL-parser (see #808), but I'd like to apologize for the huge delay. I'm catching up on old issues/PRs in my first three weeks, so I can start discussing/helping with syntax expansions again.
You're entirely correct. For your interest, I could find the PR that this was implemented (#235), and the syntax is from Hive SQL (check apache docs).
I'll add some comments regarding the syntax and the specificity of the syntax. Thanks for noting this!