client.Close(): Properly terminate the session

AFAIK client.Close() (all languages) shuts down the connection and that's it.
This means we're not properly shutting down the session and there are some side effects. For instance, there's a few pieces of code here and there doing a time.Sleep to make sure all logs are outputted to the terminal.
Proposal:

All SDKs: Properly shutdown the session on Close() (e.g. terminate the process?)
Session: Support "clean" shutdown

/cc @sipsma

@aluzzardi Just for some more context: we should already be terminating the session child process when Close is called. The child process waits until its stdin pipe gets closed and then closes the localhost listener, which results in engine.Start exiting.
The stdin pipe technique is nice it handles the case where the parent process dies ungracefully. There is also a listener for sigint and sigterm that does the same thing as closing the stdin pipe though.
For each SDK:

In Go we close the stdin pipe when the client close is called
In nodejs we use SIGTERM
I'm not totally sure about python since a lot of the code has changed, but I think this gets handled by the exit stack here? cc @helderco to verify

I'm not sure yet, but one possible problem could be that the Go SDK doesn't actually wait for the process to shutdown fully, it just closes that pipe which then results in the child process to shutdown asynchronously. We could just change it to send SIGTERM and wait on the child proc to shutdown fully (w/ SIGKILL after some timeout). We'd want to leave in the stdin pipe approach to handle the unclean parent exit too, but SIGTERM should be the approach in the default happy path I think.
It's also possible there's problems elsewhere. E.g. maybe the remote engine hasn't flushed all the logs before the client session exits? Don't remember if buildkit handles that cleanly off the top of my head. But the SIGTERM fix is probably a good place to start w/ Go either way.

I'm not totally sure about python since a lot of the code has changed, but I think this gets handled by the exit stack here? cc @helderco to verify

Correct 👍


Built SMES and substations default to 1 kJ of storage + localization issue

Description

Build a SMES/substation with a machine frame, attach it to a HV network.

Screenshots

This is an issue with the starting charge of the entity so that when they're mapped the station isn't powerless on round start.
Solution right now not to break that behaviour is to have a new ID for constructed substations that's parented to BaseSubstation and changing   - type: Battery     maxCharge: 1000     startingCharge: 1000

the 1E+03 doesn't turn into k (no unit for thousands?)

the 1E+03 doesn't turn into k (no unit for thousands?)

Oh right, I'm used to seeing that form so didn't catch that. I'll check that out too. Thanks.

the 1E+03 doesn't turn into k (no unit for thousands?)

Could not reproduce this however I noticed the cable you were actually inspecting was not connected to anything. Still showed 0 J when I tried however. PR will close this issue but if localisation happens again we can reopen / specific issue.


undefined method `to_hash_with_metadata' for nil:NilClass

Logstash version: 6.6.1
Java version:
java version "1.8.0_131"
Java(TM) SE Runtime Environment (build 1.8.0_131-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)

Error log:
[2019-03-18T07:50:44,820][ERROR][logstash.pipeline        ] Exception in pipelineworker, the pipeline stopped processing new events, please check your filter configuration and restart Logstash. {:pipeline_id=>"main", "exception"=>"undefined method `to_hash_with_metadata' for nil:NilClass", "backtrace"=>["/usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-filter-multiline-3.0.4/lib/logstash/filters/multiline.rb:273:in `block in merge'", "org/jruby/RubyArray.java:1734:in `each'", "org/jruby/RubyEnumerable.java:936:in `inject'", "/usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-filter-multiline-3.0.4/lib/logstash/filters/multiline.rb:272:in `merge'", "/usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-filter-multiline-3.0.4/lib/logstash/filters/multiline.rb:230:in `previous_filter!'", "/usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-filter-multiline-3.0.4/lib/logstash/filters/multiline.rb:173:in `filter'", "/usr/share/logstash/logstash-core/lib/logstash/filters/base.rb:143:in `do_filter'", "/usr/share/logstash/logstash-core/lib/logstash/filters/base.rb:162:in `block in multi_filter'", "org/jruby/RubyArray.java:1734:in `each'", "/usr/share/logstash/logstash-core/lib/logstash/filters/base.rb:159:in `multi_filter'", "org/logstash/config/ir/compiler/AbstractFilterDelegatorExt.java:115:in `multi_filter'", "(eval):1092:in `block in initialize'", "org/jruby/RubyArray.java:1734:in `each'", "(eval):1089:in `block in initialize'", "(eval):392:in `block in filter_func'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:358:in `filter_batch'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:337:in `worker_loop'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:304:in `block in start_workers'"], :thread=>"#<Thread:0x290c9bee@/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:173 sleep>"}
[2019-03-18T07:50:44,927][FATAL][logstash.runner          ] An unexpected error occurred! {:error=>#<NoMethodError: undefined method `to_hash_with_metadata' for nil:NilClass>, :backtrace=>["/usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-filter-multiline-3.0.4/lib/logstash/filters/multiline.rb:273:in `block in merge'", "org/jruby/RubyArray.java:1734:in `each'", "org/jruby/RubyEnumerable.java:936:in `inject'", "/usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-filter-multiline-3.0.4/lib/logstash/filters/multiline.rb:272:in `merge'", "/usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-filter-multiline-3.0.4/lib/logstash/filters/multiline.rb:230:in `previous_filter!'", "/usr/share/logstash/vendor/bundle/jruby/2.3.0/gems/logstash-filter-multiline-3.0.4/lib/logstash/filters/multiline.rb:173:in `filter'", "/usr/share/logstash/logstash-core/lib/logstash/filters/base.rb:143:in `do_filter'", "/usr/share/logstash/logstash-core/lib/logstash/filters/base.rb:162:in `block in multi_filter'", "org/jruby/RubyArray.java:1734:in `each'", "/usr/share/logstash/logstash-core/lib/logstash/filters/base.rb:159:in `multi_filter'", "org/logstash/config/ir/compiler/AbstractFilterDelegatorExt.java:115:in `multi_filter'", "(eval):1092:in `block in initialize'", "org/jruby/RubyArray.java:1734:in `each'", "(eval):1089:in `block in initialize'", "(eval):392:in `block in filter_func'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:358:in `filter_batch'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:337:in `worker_loop'", "/usr/share/logstash/logstash-core/lib/logstash/pipeline.rb:304:in `block in start_workers'"]}
[2019-03-18T07:50:44,939][ERROR][org.logstash.Logstash    ] java.lang.IllegalStateException: Logstash stopped processing because of an error: (SystemExit) exit

This results in logstash intermittently "flapping"(going down and coming back again). Would be happy to provide more info if needed.

Have the same issue

@arhue I think I found a solution. Not sure yet.
Elastic advises not to parse multiline with Logstash, rather with Filebeat.
I removed the multiline filters from Logstash and added the following to filebeat:
multiline.pattern: '^\['
multiline.negate: true
multiline.match: after

Testing it as we speak with all the instances I had multiline configured on. Hopefully it will help, hope it helps you.

你就这样解决问题的吗？
@denzhel


Feature: Tabulator navigation [Accessibility]

I've added some lines that make it possible to navigate through the elements with tab.
However this only seems to work when anchors are used inside the element.

Thanks for the pull request, @saitho! It's great to have people like you willing to contribute. :)
This seems like it could be a useful feature to some, but I will close the PR because it's unfortunately not a general-enough use case (i.e., it would likely break behavior for some users), and it would fit more naturally as its own plugin, or as a separate extension of this one.
Thanks again, and feel free to open a new issue if you'd like to see other enhancements or bug fixes!


save file shortcuts repeat

VSCode Version:1.1.0
OS Version:Windows 10 64Bit

Steps to Reproduce:

hot key is same  'S' ,look this image

thanks, this was reported already.


Using paths in filters doesn't work

I've tried to define paths for the LessCSS filter in the following lines:
[filter_LessCss]
node = /usr/local/bin/node
node_path = /usr/local/lib/node_modules
paths[] = APP/vendor/twbs/bootstrap/less/*
paths[] = WEBROOT/css/*

I get this message:

Warning (2): strtr() expects parameter 1 to be string, array given [ROOT/vendor/markstory/mini-asset/src/AssetConfig.php, line 306]

I'm guessing that's because the settings array isn't processed recursively when constant substitution takes place, thus an array is passed instead of the elements of that array. This is the line: https://github.com/markstory/mini-asset/blob/master/src/AssetConfig.php#L443

Why are paths being defined in the filter? Paths are usually defined at the extension level not inside a filter. I'm not even sure that defining paths inside the filter will work, as the paths will be overwritten by the extension settings

Oops, my fault then. I wanted to define paths specific to LESS files and I thought this should work since the LessCss filter uses this setting, but now I see the filter would use the paths defined in the extension settings instead.
I tried to do this because I have some paths that are only needed for specific filters, but declaring them globally for all filters isn't causing any problem.

Okey doke.


feat(shared) support for Kubernetes v1.23

Description
As a developer  I want to upgrade and test bevel platform deployments on Kubernetes v1.23
Platforms to be tested -

[x] HL Besu
[ ] HL Fabric
[ ] HL Indy
[ ] R3 Corda
[ ] R3 Corda Enterprise
[ ] Quorum

Acceptance Criteria

All platforms and their reference application tested on EKS version 1.23

On EKS version 1.23, to deploy workloads that use Amazon EBS volumes, we install the Amazon EBS CSI driver in the cluster, and use storage class with provision set to ebs.csi.aws.com
This feature would test and add the storage class templates for AWS EKS (v1.23)


Adds diagram of Github stars over time to README

checkout README.md (scroll to bottom) --> https://github.com/ehrbase/ehrbase/tree/feature/Add_Stargazer-Diagramm-to-REAMDE#stargazers-over-time
see --> https://starchart.cc/ehrbase/ehrbase

@testautomation nice chart, but what's the use of that data?

@ppazos it shows how (fast) a project grows  ... AND looks nice as you noticed  😆
(not much to show there yet, of course, but the project was not advertised yet)


uv run and pyproject configuration

I searched some similar issue but I didn't find anything.
I have the following structure in my project:
workspace
├──  packages
│   ├── package-a
│   │    ├── pyproject.toml
│   └──  package-b
│          └── pyproject.toml
└──  pyproject.toml

I have installed pytest and pytest-env at package-a. After that, I put the following configuration on package-a's pyproject.toml:
[tool.pytest_env]
AWS_ACCESS_KEY_ID = ""
AWS_SECRET_ACCESS_KEY = ""
AWS_REGION = ""

Finally I have tried to execute uv run --package package-a pytest from workspace root when I got a error for it didn't find the configuration on pyproject.toml. I only got execute this one if it is executed on package folder.
uv platform: Linux
uv version: 0.4.9

Are you using uv's workspace feature or using the term "workspace" to refer to a parent folder/repo?

Are you using uv's workspace feature or using the term "workspace" to refer to a parent folder/repo?

I am using workspace feature as it is documented

This may depend on how pytest discovers that configuration. If it has to be in the current working directory specifically, then you may have to run uv run pytest from ./packages/package-a instead of the workspace root, since we can't control pytest's config discovery. Does that work?

@charliermarsh I think a good way could be consider package as root on execute uv run --package package-a pytest. I don't believe that there is any use case for using pyproject.toml on workspace root instead of package. What do you think about setting package as the PYTHONPATH?

I don't think we can change the working directory, it'd break relative paths which kind of defeats the purpose of working from the workspace root.

Maybe you can use uv --directory <path>?


Move spawn, spawn_with_handle into futures-util

These are currently in futures-executor/src/spawn.rs but they don't depend on anything from the futures-executor crate => they should live in futures-util because they're general purpose and similar to the kind of stuff in futures-util

Yeah, that sounds good! I'd also +1 spawn! and spawn_with_handle! macros for wrapping them in await!s.

I also favor the macro versions and would like to replace these with macro versions. However, @Nemo157 mentioned this use case once:
let handle = await!(spawn_with_handle(future).with_executor(...));

How could this work with macros?

@aajtodd You're right. It should say "the context's executor"

@cramertj How about providing only macros, but with an optional executor parameter?
spawn!(future);
spawn!(future, executor);

@MajorBreakfast if you have an executor and a future, you don't need a macro-- you can write executor.spawn_obj(Box::new(future).into()) (eventually executor.spawn(future)). I guess we'd be saving a few characters by avoiding the whole Box::new(...).into() dance, but we could do the same by providing an extension trait that delegated to spawn_obj internally (similar to the existing one for Context).

@cramertj You're right, the macro isn't needed for this use case. I've created an issue for ExecutorExt with an approach that I think would work. Once we have ExecutorExt, we can build easy to use spawn! and spawn_with_handle! macros around it.

The documentation on spawn says that the function will spawn the given future as a task onto the default executor, maybe I'm missing something but I don't see where this happens.

You're right. It should say "the context's executor"

I had the same initial reaction, eventually I figured out that "the default executor" is "the current context's executor", there's nothing else for it to refer to. :+1: for clarifying this a bit more.

Closed by https://github.com/rust-lang-nursery/futures-rs/pull/1156


Finish off builder flow for Deneb

PR Description

Resolved TODOs in ExecutionBuilderModule (basically implement getHeader and getPayload for both local, local fallback and builder + some logging)
Enabled disabled tests + fixed current tests for deneb building
Fixed a bug when setting the kzg commitments for blinded flow (tests are useful 🛩  )
Modified ExecutionLayerChannelStub for Deneb

Fixed Issue(s)
fixes #7170
Documentation

[X] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[X] I thought about adding a changelog entry, and added one if I deemed necessary.

I'm testing this in my stubbed interop and I get BuilderPayload hasn't been cached for slot N consistently.

I'm testing this in my stubbed interop and I get BuilderPayload hasn't been cached for slot N consistently.

Interesting. Let me give it a try as well.


HBASE-27340 Artifacts with resolved profiles

Make it so our published poms carry the minimum needed to run
an hbase; the published pom has no profiles -- the profiles
specified at build time are resolved, their dependencies inlined,
and then they are stripped -- and no build-time, or plugins
dependencies or properties, etc. Resultant poms have explicit
hadoop lib versions baked in -- no more being able to choose
hbase with hadoop2 or haddop3 at downstream build time by setting
a '-Dhadoop.profile=X.0'.
Pattern is to add profiles when none in sub-modules when
the flatten plugin complains it can't resolve an hadoop
dependency's 'version' (e.g. hadoop-common, hadoop-hdfs).
Adding the hadoop-2.0 and hadoop-3.0 profiles in the sub-module
make it so the flatten plugin can figure 'hadoop.version'
definitively.
Another spin on the above happens when profiles already exist
in submodule but the flatten plugin is complaining it can't
figure figure version on an hadoop dependency NOT under
profiles. Below, we move the delinquent hadoop dependency under
existing profiles (minikdc was the usual dependency outside
profiles in sub-modules that flatten complained about).
Sometimes, moving an hadoop dependency under a profile, there
would be excludes on the local dependency. If the parent pom
excludes section was missing the local excludes, we added them
up to the parent module so all excluding is done up there in
the parent profile dependencyManagement section.

hbase-asyncfs/pom.xml

hbase-endpoint/pom.xml

hbase-examples/pom.xml

hbase-http/pom.xml

hbase-rest/pom.xml

hbase-server/pom.xml
Move the minikdc under profiles so it picks up appropriate hadoop version
when the flatten plugin runs.

hbase-hadoop2-compat/pom.xml
Add hadoop2 and hadoop3 profiles and move hadoop-common, etc.
under them so we pick up appropriate hadoop version when flatten
plugin runs.

hbase-mapreduce/pom.xml
Move hadoop dependencies under profiles so right version is
available when the flatten plugin runs.

hbase-shaded/hbase-shaded-testing-util/pom.xml
Add profiles for hadoop-2.0 and hadoop-3.0 and move the
hadoop dependencies under them.

pom.xml
Add the flatten plugin with the flatten profiles enabled.
Add a few excludes on hadoop profiles picked up from sub-modules.
E.g. exclude bouncycastle bcprov-jdk15 when we include minikdc.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 21s
branch-2.5 passed

+1 :green_heart:
compile
6m 26s
branch-2.5 passed

-1 :x:
spotless
0m  9s
branch has 60 errors when running spotless:check, run spotless:apply to fix.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
6m 22s
the patch passed

+1 :green_heart:
javac
6m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  7s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 52s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.

-1 :x:
spotless
0m  8s
patch has 60 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
1m 35s
The patch does not generate ASF License warnings.

38m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4740

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux a2272c12c6cb 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 13841f52f0

Default Java
AdoptOpenJDK-1.8.0_282-b08

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/artifact/yetus-general-check/output/branch-spotless.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
139 (vs. ulimit of 30000)

modules
C: hbase-hadoop2-compat hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 53s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 57s
branch-2.5 passed

+1 :green_heart:
compile
1m 43s
branch-2.5 passed

+1 :green_heart:
shadedjars
4m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 39s
branch-2.5 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
1m 43s
the patch passed

+1 :green_heart:
javac
1m 43s
the patch passed

+1 :green_heart:
shadedjars
4m  3s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
230m 20s
root in the patch passed.

260m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4740

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c9cd75830b93 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 13841f52f0

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/testReport/

Max. process+thread count
4715 (vs. ulimit of 30000)

modules
C: hbase-hadoop2-compat hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 54s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 39s
branch-2.5 passed

+1 :green_heart:
compile
1m 34s
branch-2.5 passed

+1 :green_heart:
shadedjars
4m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 14s
branch-2.5 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 17s
the patch passed

+1 :green_heart:
compile
1m 33s
the patch passed

+1 :green_heart:
javac
1m 33s
the patch passed

+1 :green_heart:
shadedjars
4m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 17s
the patch passed

_ Other Tests _

-1 :x:
unit
351m 28s
root in the patch failed.

379m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4740

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6aa6b8f46615 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 13841f52f0

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/testReport/

Max. process+thread count
4738 (vs. ulimit of 30000)

modules
C: hbase-hadoop2-compat hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Approved pending clean spotless check and successful test run.
Current failures are relevant to this change e.g.
java.lang.NoClassDefFoundError: org/bouncycastle/jce/provider/BouncyCastleProvider

Let me fix the failure.
For master branch, +1 on removing hadoop profiles, etc. but I'd think we'd still want this patch too because hadoop is not only profile and even if no profiles, the published poms are slim w/ runtime-only dependencies w/ explicit versions filled in.

+1

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  4s
https://github.com/apache/hbase/pull/4740 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4740

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/2/console

versions
git=2.25.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  4s
https://github.com/apache/hbase/pull/4740 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4740

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/2/console

versions
git=2.25.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  6s
https://github.com/apache/hbase/pull/4740 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4740

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/2/console

versions
git=2.25.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

RELEASENOTE changes come of my running spotless locally.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  4s
https://github.com/apache/hbase/pull/4740 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4740

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/3/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  3s
https://github.com/apache/hbase/pull/4740 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4740

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/3/console

versions
git=2.25.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  5s
https://github.com/apache/hbase/pull/4740 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4740

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/3/console

versions
git=2.25.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  5s
https://github.com/apache/hbase/pull/4740 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4740

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/4/console

versions
git=2.25.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  5s
https://github.com/apache/hbase/pull/4740 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4740

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/5/console

versions
git=2.25.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  5s
https://github.com/apache/hbase/pull/4740 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4740

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/5/console

versions
git=2.25.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  5s
https://github.com/apache/hbase/pull/4740 does not apply to branch-2.5. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/4740

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/5/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 13s
branch-2.5 passed

+1 :green_heart:
compile
6m 20s
branch-2.5 passed

+1 :green_heart:
spotless
0m 38s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
6m 15s
the patch passed

+1 :green_heart:
javac
6m 15s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  7s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 43s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
1m 32s
The patch does not generate ASF License warnings.

39m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4740

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile

uname
Linux df553970a8bf 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 81ba1231dc

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
141 (vs. ulimit of 30000)

modules
C: hbase-hadoop2-compat hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 52s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.5 Compile Tests _

+0 :ok:
mvndep
0m 44s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 38s
branch-2.5 passed

+1 :green_heart:
compile
1m 45s
branch-2.5 passed

+1 :green_heart:
shadedjars
4m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 32s
branch-2.5 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 36s
the patch passed

+1 :green_heart:
compile
1m 43s
the patch passed

+1 :green_heart:
javac
1m 43s
the patch passed

+1 :green_heart:
shadedjars
4m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
236m 19s
root in the patch passed.

265m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4740

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e654f66d52b2 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.5 / 81ba1231dc

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/6/testReport/

Max. process+thread count
4741 (vs. ulimit of 30000)

modules
C: hbase-hadoop2-compat hbase-http hbase-asyncfs hbase-server hbase-mapreduce hbase-endpoint hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4740/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


kawaii-player: Add Version 5.0.0-1

Closes #XXXX

Relates to #XXXX

[x] I have read the Contributing Guide.

Please change the title of your PRs to (PACKAGE NAME): Add version xxx.

config location: $UserProfile\.config\kawaii-player
(This is a reminder. No need to modify anything regard to this.)

/verify


Return to base directory when clicking "Overview"

Request details
Currently, clicking "Overview" folder do nothing if current tab is overview.
I suggest that clicking "Overview" on overview tab move to base directory.

I can do this in some free time.


Added donation.html page

I have added a new Donation page

Unfortunately, due to a wrong PR that got merged, the website's structure became disorganized. We had to revert to the old code. Kindly pull the latest changes and create a new PR for your issue, as your current PR shows conflicts. I apologize for the inconvenience and appreciate your understanding. Looking forward to your new PR soon. Thank you! 😊

No Problem Sir, but i am having some doubts that my pull request for
Donation.html got merged 4 hours ago, so do i need to again create a pull
request with the same?
Looking for your response
Thank You!
On Wed, 2 Oct 2024 at 22:20, Anurag Verma @.***> wrote:

Unfortunately, due to a wrong PR that got merged, the website's structure
became disorganized. We had to revert to the old code. Kindly pull the
latest changes and create a new PR for your issue, as your current PR shows
conflicts. I apologize for the inconvenience and appreciate your
understanding. Looking forward to your new PR soon. Thank you! 😊
—
Reply to this email directly, view it on GitHub
https://github.com/anuragverma108/WildGuard/pull/150#issuecomment-2389145893,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGU7DKFNXM6VIW5ALOI5KF3ZZQP5XAVCNFSM6AAAAABPG6SBYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGE2DKOBZGM
.
You are receiving this because you were assigned.Message ID:
@.***>


unsupported NetBIOS session service message type

Hi
if i wana connect to server, i see this msg
error: [SMB] unsupported NetBIOS session service message type: 79
by
https://github.com/adobe/node-smb-server/blob/master/lib/smbconnection.js#L57
I wana use this server as a pass through proxy. Is this somehow possible?

please specify os version and client software used to connect to the SMB server.
WRT pass through proxy: could you please elaborate on your concrete use case?

insufficient information provided to diagnose issue,  closing

OS version is Windows 7
Client is Windows Explorer

i need help too

im with Windows 10 and Windows Explorer too

This appears to be caused by attempting to access the node SMB server using an alternative port (ex. \[server]:8445).  Windows tries to interpret this as a web URL and sends an HTTP request to the server.  Windows will only make outbound SMB connections on the standard port (445).  This could potentialy be worked around by using port translation on a firewall etc.

as @kkronyak correctly pointed out, Windows SMB clients only support the standard SMB port 445.
closing issue.


pending() fails with timeout in async tests

The following test fails with a timeout when run in Jest Electron environment. Works correctly in Node environment:
describe("foo", () => {
    it("bar", async () => {
        pending("Disabled");
        expect(await Promise.resolve("23")).toBe("23");
    });
});

Output is:
 FAIL  lib/test/support/foo.test.js (5.351s)
  foo
    ✕ bar (5005ms)

  ● foo › bar

    Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.

      1 | describe("foo", () => {
    > 2 |     it("bar", async () => {
        |     ^
      3 |         pending("Disabled");
      4 |         expect(await Promise.resolve("23")).toBe("23");
      5 |     });

      at Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:92:20)
      at Suite.it (lib/test/support/foo.test.js:2:5)

I'm using Jest 24.1.0 and Electron Runner 1.1.1.

what is pending('disabled') in your case? i don't think it's a default global method.
i just added an async test and it passes on my laptop and CI https://github.com/facebook-atom/jest-electron-runner/pull/46

pending() is a standard Jasmine feature and therefor also available in Jest.

Jest is not using standard jasmine and i don't think it's available in the standard build.
since i can run an async test in master i'll close this issue, but if you can provide a repro i can look at i'll be happy to debug the issue!


Fix not being able to link google account on data test app

As a developer, I need to be able to link my google account to the data example app in order to quickly test a variety of features. Right now I am unable to link the account - Google gives an error that the emulator browser is not secure enough, or something along those lines. This needs to be figured out and fixed.
the error:

Acceptance Criteria

Able to link my google account to data test app and fetch all my emails through android emulator.

Fixed the configuration files for Android in the example app #134


[v1.15] fix: Assign PodStore from Pod resource until cell migration is completed

Backport https://github.com/cilium/cilium/pull/34090 to 1.15
A couple of notes:

There was only one small change I needed to do: I added PodResource to operator/k8s/resource_ctors.go which was created recently in https://github.com/cilium/cilium/pull/33021 and didn't exist in 1.15
I also ignored the follow-up PR https://github.com/cilium/cilium/pull/34404

I tested the backport in our cluster running 1.15 and confirmed that "Unable to compute pending pods, will not surge-allocate" warnings were gone.
Fixed bug which prevented IP surge allocation from working

Thank you @antonipp!

/test-backport-1.15

@dlapcevic @antonipp FYI, https://github.com/cilium/cilium/pull/34090#issuecomment-2419066555. Could we fix this before we go and release this patch in another version without a proper release note?

Looks good to me. I think we can move forward with merging it.
@antonipp please confirm.

I added a release note to my PR to indicate that a bug was fixed. I don't have rights to change the labels on the PR though.
(By the way, it's clearly fixing a bug with user impact)

I added a release note to my PR to indicate that a bug was fixed. I don't have rights to change the labels on the PR though. (By the way, it's clearly fixing a bug with user impact)

I believe the release note and label need to be on the upstream PR. I'm unsure what effect they would have on the backport PR. AFAIK, we derive release notes for backport PRs from the upstream PR.

Ok, I didn't know it worked this way, I will let Dorde update the original PR then.

cc @dlapcevic


"Mark me as done" more visible

Many users are having difficulty locating the icon/button 'Mark me as done.' Therefore, we should consider finding an additional or alternative location for this action.

*Idea: Maybe double function: keep it in left user menu and also next to voting display.


UIImage support for UIBarButtonItem for DismissButtonConfig

Hi, 😀
I was thinking that it might be a good feature if there was a way to set an image for the  UIBarButtonItem through the DismissButtonConfig.
What do you think ? 🤔

Seems reasonable 👍
We could add a .image(UIImage) case to the Text enum:
https://github.com/jessesquires/PresenterKit/blob/develop/Source/DismissButtonConfig.swift#L70-L77
We should probably rename it from Text to something else... 🤔

Renaming enum Text would be a breaking change though 😢

Would you recommend a different approach in order to avoid renaming enum Text ?

@psartzetakis - Hm... probably not. I can't really thing of a better way to do this.
It's not a big deal. 😄
However, it would be nice include more changes for the 4.0 release.

However, it would be nice include more changes for the 4.0 release.

@jessesquires I have a couple of ideas..🤔.
However I believe it would be better to open separate issues so we can discuss them separately..  😀

However I believe it would be better to open separate issues so we can discuss them separately..

Definitely! 💯 👍


Deployment on Heroku and Render:  Ensure successful deployment on Heroku and Render, configure environment variables.

Coordinate with Developer 1 to ensure that the deployment configuration in package.json aligns with the backend setup.
Collaborate with other developers to address any deployment-related considerations.


Add tm

tm is a nice little tmux wrapper that I use everyday to ssh to multiple servers at the same time.
It doesn't seem as complete as tmux-cssh (that I just discovered), but it still served me well over the past years. :+1:

LGTM


[Addressbook]Default sorting in the addressbook table

Title/Description
Seems that the default sorting in the addressbook table is by creation date, but it's not clear for the user as no such column.
Also It's hard to find any address without clear sorting
Environment

Browser: Chrome
Safe: 0x1230B3d59858296A31053C1b8562Ecf89A2f888b
Wallet: MM
App Version: 3.7
Environment:

PR # https://pr2280--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x1230B3d59858296A31053C1b8562Ecf89A2f888b/address-book

Steps to reproduce

Create many addressbook entries using different name ( not structured )
Open addressbook

Expected result
The addressbook should have clear sorting by default that will help the user to find address quickly
Obtained result
Seems that it's sorted by creation date
Screenshots

@tschubotz what would be the best way to show this? Ordering by name could be the most normal, as ordering by safe is not that obvious

Agree, ordering by name, ascending sounds like the best option.

There is an issue with the sorting.
The names can have a blank space in front of the name, that causes to be first in the list no matter what.
This can happen either because the name in the csv has a blank space in front, or because it simple was edited with a blank space in front.

Also we still have the issue of uppercase characters are always first than lowercase characters, but that's an old issue.
We can ignore it for now, just leaving it here for the record

can be discussed and fixed in 3.8.0 or later, as it's a minor issue

@katspaugh  and @francovenica , I think that the space at the beginning of the name should be ignored in the name and should not influence on the sorting .
Should we create a separate issue for it ?

If anything, we should trim any leading and trailing whitespace in names.

reported separately - https://github.com/gnosis/safe-react/issues/2417


feature: add ArchivePage

Hi, first of all, thanks for building this interface for the Notion API!
I started using it and missed the "archive pages" feature, so i implemented it.
Cheers

Hi @Ronald-TR,
Glad to hear this package has been of use! As for the "Archive page" endpoint: While it exists, it's a deprecated endpoint; the API docs state:

"Please use the Update page endpoint to archive a page."

Similar to the "List databases" endpoint, I've deliberately decided not to support deprecated endpoints in this library.
Thus I'm closing this PR, but thank you very much regardless for taking the time to open it.

HI, i think that we have a missunderstanding, haha. I didn't use the archive endpoit, but the pages endpoint itself. I'm just editing the body with the {'archived': true} content. But is the same /pages endpoint used.

Ah, gotcha. In that case, would you mind updating the PR to add an Archived field to UpdatePageParams and update its methods to use this new field? If you could please rem remove the Title field, I added it by mistake probably because it doesn't seem to be supported (ref). You can also leave it and I can clean it up later.
This way, we can keep the existing UpdatePageProps, without the need for a separate method. The way I've modeled the Client struct, is that the methods are closely coupled to the API endpoints. Thanks again!

Cool, thanks for the insights, i will work on it asap!


Improvement: Update battery related datafields periodically, not only when changed

Due to the update machanism of the adapter battery scripts fail to detect wether the batteries are empty, because usualy the scripts use the update timestamp of the datapoint to detect the last update and hence if the device may be dead (Last update is older than x hours).
So it would be great if the adapter updates the battery field (Smartlocks.door.state.batteryCritical (indicator.lowbat) )) as long as it receives ANY data from the smartlock.
In addition: If it's possible to get more Information than only lowBat it would be great to get such datapoints.

+1
It would really be helpful to have the batteryChargeState value updated periodically in order to be able to rule out an empty battery!


Use cardano-git-rev from cardano-base

Description
The new version of gitRev (in the cardano-base repo) is no longer a function but instead, its a TH splice to ensure its always executed/evaluated at the call site.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated.  These may include:

golden tests
property tests
roundtrip tests
integration tests
See Runnings tests for more details

[ ] Any changes are noted in the CHANGELOG.md for affected package
[ ] The version bounds in .cabal files are updated
[ ] CI passes. See note on CI.  The following CI checks are required:

[ ] Code is linted with hlint.  See .github/workflows/check-hlint.yml to get the hlint version
[ ] Code is formatted with stylish-haskell.  See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
[ ] Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7

[ ] Self-reviewed the diff

Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges.  Please contact IOG node developers to do this
for you.

Has been fixed elsewhere.


v0.6 release

Adds score in playmode (current and previous scores)
Playmode now incorporates lights off directly (in examples try: python visualizeArena.py configs/lightsOff.yaml)
To simplify the environment several unnecessary objects have been removed see here
Several object properties have been changed also here
Frames per action reduced from 5 to 3 (i.e.: for each action you send we repeat it for a certain number of frames to ensure smooth physics)
Add versions compatibility check between the environment and API
Remove step_number argument from animalai.environment.step

Great work, Ben.


collection data upload from btcapeconics

We´ve created a new folder under collections. We added the inscriptions.json and meta.json file.
Please pull :) Thanks

Your meta.json needs an Https before the discord url for the test to pass <3

i will create a new one


Count Resource Virtual Router

Description
Currently the virtual router resources are not counted
towards domain resource count. Only the CPU/MEM of user
virtual machine are counted. If some customers have
VR's with higher cpu/memory values than the default value of
1 core, 256MB RAM then they are consuming extra resources
which are not counted towards the resource calculation
of the domain/account.
So two global settings are added to this change
"resource.count.running.routers" and "resource.count.running.routers.type"

"resource.count.running.routers" can have either true of false
"resource.count.running.routers.type" can have either "all" or "delta"
The default value is "all"

If "resource.count.running.routers" is true, then if
"resource.count.running.routers.type" is "all", then all VR resources
are counted towards the domain resource consumption

For example: If VR is running with 4 cores, and 4GB ram, then all 4 cores
and 4 GB are added to domain resource consumption

If "resource.count.running.routers.type" is "delta" then the diff
between the current VR CPU/ram and the default VR offering CPU/ram
is considered for domain resource calculation.

For example: If VR is running with 4 cores and 4Gb ram, then
3 cores and 4gb-0.25Gb will be counted for resource consumption

If "resource.count.running.routers" is false, then even if VR
has higher CPU/ram, then its not counted towards domain resource
consumption

Test cases:

It can be tested using.

nosetests --with-marvin --marvin-config=<your test config file>.cfg test_router_resources.py

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup that may add test cases)

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6899 (LL-JID-241)

@blueorangutan package

@soreana a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 266

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6899 (LL-JID-253)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan package

@soreana a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 280

@blueorangutan package

@DaanHoogland Can we also have this one in 4.18 please? :-)

@blueorangutan package

@soreana a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4647

@blueorangutan package

@soreana a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4676

@blueorangutan package

@soreana a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4733

@blueorangutan test

@weizhouapache can you review this, given time?

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian Build Failed (tid-5355)

Trillian Build Failed (tid-5359)

Trillian Build Failed (tid-5361)

Trillian Build Failed (tid-5363)

@CharlesQueiroz you have conflicts, can you have a look?

@DaanHoogland, sorry for the delay. The conflict was solved.

@blueorangutan package

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4940

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4943

@blueorangutan test

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4997

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian Build Failed (tid-5554)

Trillian Build Failed (tid-5563)

@CharlesQueiroz , the test environments mysteriously stop logging after
2022-12-19 10:45:55,415 DEBUG [o.a.c.f.c.i.ConfigDepotImpl] (main:null) (logid:) Retrieving keys from ConfigurationManagerImpl

Can you have a look at your changes in that class, please?

Yes. Let me check...

@CharlesQueiroz are you still looking at this? There are conflicts.

@CharlesQueiroz I am moving this to milestone 4.18.1. please move back to 4.18.0 if you manage to fix this in time.

@CharlesQueiroz is this no longer an issue (as you closed it)?

is this no longer an issue (as you closed it)?

Hi @DaanHoogland. I closed it because I created a new one from the main, and it was a suggestion from weizhouapache too. It will be more simple to manage some eventual problems. (I suppose). Do you see any trouble or have any other suggestions? pls, let me know.

No @CharlesQueiroz I was just wondering and hoping you haven't lost courage ;)

No @CharlesQueiroz, I was just wondering and hoping you haven't lost courage ;)

Absolutely not! hehe. I'm trying to understand how I can be more useful to the project starting with small tasks to be aware of all the processes. Like a soldier :)

No @CharlesQueiroz, I was just wondering and hoping you haven't lost courage ;)

Absolutely not! hehe. I'm trying to understand how I can be more useful to the project starting with small tasks to be aware of all the processes. Like a soldier :)

great, next time you can just git push --force  if you need to.


[BUG] No admin password available/settable for Docker

Describe the bug
The initial admin password procedure for Docker appears to be utterly broken.
This is from my compose.yml
services:
  opensearch:
    image: opensearchproject/opensearch:latest
    container_name: opensearch
    environment:
      - opensearch_host=opensearch1
      - opensearch_user=admin
      - opensearch_pass=DoesNotWork2024@
      - OPENSEARCH_INITIAL_ADMIN_PASSWORD=DoesNotWork2024@

Things I have tried:

admin:admin
admin and OPENSEARCH_INITIAL_ADMIN_PASSWORD in compose.yml
admin and OPENSEARCH_INITIAL_ADMIN_PASSWORD in .env
admin and export OPENSEARCH_INITIAL_ADMIN_PASSWORD=
not using opensearch_pass= in config
not using OPENSEARCH_INITIAL_ADMIN_PASSWORD anywhere

Strong8@ meets the stated requirement. It doesn't work, nor does doubling it. If you use a $ in the password it complains about interpolation and fails to start.

Password Strong8@Strong8@ failed validation: "Weak password". Please re-try with a minimum 8 character password and must contain at least one uppercase letter, one lowercase letter, one digit, and one special character that is strong.

This is an invocation using DoesNotWork2024@, reports success. Can't log in with admin or Admin. Commands with curl work fine with kibanaserver:kibanaserver.

opensearch               | Enabling OpenSearch Security Plugin
opensearch               | Enabling execution of install_demo_configuration.sh for OpenSearch Security Plugin
opensearch               | OpenSearch 2.12.0 onwards, the OpenSearch Security Plugin a change that requires an initial password for 'admin' user.
opensearch               | Please define an environment variable 'OPENSEARCH_INITIAL_ADMIN_PASSWORD' with a strong password string.
opensearch               | If a password is not provided, the setup will quit.
opensearch               |  For more details, please visit: https://opensearch.org/docs/latest/install-and-configure/install-opensearch/docker/
opensearch               | ### OpenSearch Security Demo Installer
opensearch               | ### ** Warning: Do not use on production or public reachable systems **
opensearch               | OpenSearch install type: rpm/deb on Linux 6.2.0-39-generic amd64
opensearch               | OpenSearch config dir: /usr/share/opensearch/config/
opensearch               | OpenSearch config file: /usr/share/opensearch/config/opensearch.yml
opensearch               | OpenSearch bin dir: /usr/share/opensearch/bin/
opensearch               | OpenSearch plugins dir: /usr/share/opensearch/plugins/
opensearch               | OpenSearch lib dir: /usr/share/opensearch/lib/
opensearch               | Detected OpenSearch Version: 2.14.0
opensearch               | Detected OpenSearch Security Version: <IP_ADDRESS>
opensearch               | Admin password set successfully.

Related component
Other
To Reproduce
Create a compose.yml and try to set the admin password.
Expected behavior
I would expect this to return some information about the cluster.
curl -ku 'admin:whatever' https://localhost:9200/_cluster/health
Additional Details
No response

Hi @nealrauhauser
Thank you for opening an issue. We did test it using below password in our test runs "OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123@456" See docker-compose file in the drop down here. Can you try once with that.
Also moving this issue to security repo to debug the error
Password Strong8@Strong8@ failed validation: "Weak password". Please re-try with a minimum 8 character password and must contain at least one uppercase letter, one lowercase letter, one digit, and one special character that is strong.


fix curl error

curl is having trouble, forcing it to HTTP 1.1 has corrected the problem previously.
https://github.com/sp3nx0r/bitrise-step-nowsecure-auto-analysis/pull/4 should fix the issue

Thanks for the note, PR merged. Will knock off the other issues can cut a new step version


Transfer keda.sh DNS to CNCF

Transfer keda.sh DNS to CNCF

@tomkerkhove ideally we could just use Netlify DNS when LF owns the domain: https://app.netlify.com/teams/keda-7ntn70/dns
:)

Certainly but @jeffhollan owns it AFAIK

This seems to be done, ok to close @caniszczyk ?


Command "arm-none-eabi-ar" "s" "<the_output_file>.a" with args "arm-none-eabi-ar" did not execute successfully

Hey there,
First of all, thank you for all your efforts with/for the Rust community.
I'm trying to get a library compiled that's made up of many files:
let sdk_includes = "the-library/includes";
let sdk_files = glob::glob("the-library/src/*.c");
cc::Build::new()
    .include(sdk_includes)
    .files(sdk_files.unwrap().map(|path| path.unwrap()))
    .compile("the_library_sdk");

This is failing with the following error:
cargo:warning=arm-none-eabi-ar: '[...]/out/libthe_library_sdk.a': No such file

I've gone through several different errors before this one and managed to fix them, and it looked like the compilation was actually happening: all of the errors had to do with missing header files or the link, which indicated to me that things were working fine.
Once I fixed all the errors related to compiling the actual library, I got this last one, and I can't figure out what's going wrong. I checked the source of cc-rs and I found some places where the file at dst gets removed, but I don't see why that should happen.
Maybe it's a matter of indirection and the actual problem lies in some other issue.
Leaving the full output here (paths edited):
warning: arm-none-eabi-ar: '/[...]/target/thumbv7m-none-eabi/debug/build/example-df510904a9be97f6/out/libthe_library_sdk.a': No such file

error: failed to run custom build command for `example v0.1.0 (/[...])`

Caused by:
process didn't exit successfully: `/[...]/target/debug/build/example-d483bb49e1993678/build-script-build` (exit code: 1)
--- stdout
cargo:rerun-if-changed=crate-name
TARGET = Some("thumbv7m-none-eabi")
HOST = Some("x86_64-unknown-linux-gnu")
AR_thumbv7m-none-eabi = None
AR_thumbv7m_none_eabi = None
TARGET_AR = None
AR = None
CROSS_COMPILE = None
running: "arm-none-eabi-ar" "s" "/[...]/target/thumbv7m-none-eabi/debug/build/example-df510904a9be97f6/out/libthe_library_sdk.a"
cargo:warning=arm-none-eabi-ar: '/[...]/target/thumbv7m-none-eabi/debug/build/example-df510904a9be97f6/out/libthe_library_sdk.a': No such file
exit code: 1

--- stderr

error occurred: Command "arm-none-eabi-ar" "s" "/[...]/target/thumbv7m-none-eabi/debug/build/example-df510904a9be97f6/out/libthe_library_sdk.a" with args "arm-none-eabi-ar" did not execute successfully
(status code exit code: 1).

Could you point me to some ways I could go about debugging underlying causes? I've read the library code but following it makes me think it should be working fine.

Ah sorry I'm not really sure how this could come about. It may just be an edge case internally or indicative of a further bug, but in theory this library isn't too too large and it should be somewhat easy to poke around and see what's going on.

Ooookay, this is embarrassing: I was passing an iterator of paths that I built using glob, and I messed up the search and was passing [] to cc-rs.
Sorry to have wasted your time!


Wrapper only seems to go one folder deep

I am adding my collections into the repo and building the wrapper to create my tests.
Now if you have the folder structure like
MyCollection1
MyFolder1
Request1
Request2
MyFolder2
Request3
Request4
All is good. However, my folder structure looks like
MyCollection1
MyFolder1
MyFolder1a
Request1
Request2
MyFolder1b
Request1
Request2
MyFolder2
Request3
Request4
This only creates tests for MyFolder1 and MyFolder2
Is it possible to make it look where the collection tests are and give an output like
MyFolder1a, MyFolder1b and MyFolder2

Even just the lowest folder would be ok. So if the tests where 3 folders deep. It would use that folder3 name

True, the discovery of folders only looked at one level.
I have rewritten the routine to fetch folders from an arbitrary depth in the tree.
Notice that folder names must still be unique within a single collection file, independent of their depth in the tree.
Please try out the code in the following branch, both regarding discovery of test cases as well as executing the test cases in ADO.
https://github.com/jbjakobs/Postman/tree/DiscoveryPostmanFolders

Excellent, thanks for your response. I will pull the branch down tomorrow and retest.


one or more of its instance fields aren't final

I'm using StatelessWidget and I'm facing case that I have to define none-final Class so there is a  warring show up to me that say
This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final

my code
class TestWidget extends StatelessWidget {
  ItemGetXController controller;
  final bool disableAnimation;
  final String itemId;

  TestWidget({
    this.itemId,
    this.disableAnimation = false,
  }) {
     controller = Get.put(ItemGetXController(itemId:Itemid);
   }

   @override
  Widget build(BuildContext context) {
    return Text(controller.item.value.title)
  }

}

so this is a correct approach  and I should ignore this warring or there is another approach !?

Hi, this issue is not related to GetX. You can use Discord/Slack/Telegram for this purpose.
Anyway regarding your problem, you need to define disableAnimation as final too.

Hi, this issue is not related to GetX. You can use Discord/Slack/Telegram for this purpose.
Anyway regarding your problem, you need to define disableAnimation as final too.

I know it's not issue but I want to know a best approach in this case

I have edited the code to more explain the approach.

Please upload your ItemGetXController too.. better if you can post minimal code to reproduce.

Btw for itemId you can put with arguments route and get it via Get.arguments in your controller.

Hi, if you are looking for help, or want to discuss using a tool, please use the platform channels. Your question will be resolved more quickly, and there will be no support issues here, making it easy for anyone looking for an issue/feature request.
Just so as not to leave you unanswered, all fields in a StatelessWidget class must be final.


Add example of a notification banner with 2 lines of text

Like this one:

The user wasn't sure how to mark up the second line of text.

I suspect you might also want a new class govuk-notification-banner__body or similar too.


Scroll on Animation with Firebase

I am using the RecyclerView animation library found here. I am also using the FirebaseRecyclerAdapter, documentation located here.
Essentially, I want to scroll to the top of the RecyclerView as items are added to Firebase. It is tricky since I am not actually initializing the adapter with an ArrayList(), or any list, for that matter. Firebase handles all of the data management through the FirebaseRecyclerAdapter.
Here is my basic onCreateView():
 @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
                         Bundle savedInstanceState) {
    // Inflate the layout for this fragment
    final View v = inflater.inflate(R.layout.fragment_new, container, false);
    Log.v("TAG", "ON CREATE CALLED FROM NEW");

    mRecyclerview = (RecyclerView) v.findViewById(R.id.list);
    mRecyclerview.setItemAnimator(new FadeInUpAnimator());

    mLayoutManager = new LinearLayoutManager(getContext());
    mLayoutManager.setOrientation(LinearLayoutManager.VERTICAL);
    mLayoutManager.setReverseLayout(true);
    mLayoutManager.setStackFromEnd(true);

    mRecyclerview.setLayoutManager(mLayoutManager);

    return v;
}

And my adapter:
    @Override
public void onStart() {
    super.onStart();

    mFireAdapter = new FirebaseRecyclerAdapter<Poll, PollHolder>(Poll.class, R.layout.latest_item, PollHolder.class, mBaseRef.child("Polls")) {
        @Override
        protected void populateViewHolder(PollHolder viewHolder, Poll model, int position) {
            mRecyclerview.scrollToPosition(position);
            viewHolder.mPollQuestion.setText(model.getQuestion());
            Picasso.with(getActivity().getApplicationContext())
                    .load(model.getImage_URL())
                    .fit()
                    .into(viewHolder.mPollImage);
            Log.v("TAG", model.getQuestion());
            Log.v("TAG", model.getImage_URL());
        }
    };

    mRecyclerview.setAdapter(mFireAdapter);
}

How would I scroll to the top of the RecylcerView as items are added? Note that I am calling:
mLayoutManager.setReverseLayout(true);
mLayoutManager.setStackFromEnd(true);

since I need to reverse the order of the data in Firebase.

Hello, can you a solution?


multiline install section

is there a way to make this work:
Custom install command for your formula.
      # Required - string
      install: |
        'bin.install "show-keys.sh" => "show-keys" \n prefix.install 'files''

Yeah you should be able to do this:
install: |
        bin.install "show-keys.sh" => "show-keys"
        prefix.install 'files'

Let me know if that works.

It shows up in the formula but looks like this and things arent happy about the missing tab...you have it without quotes though..let me try that.

Yeah the pip | in yaml indicates to take everything after it as literal, eg: https://yaml-multiline.info/. You shouldn't need the quotes at that point. You may need to play with the indentation to get it all working but checking the yaml documentation should get you where you need to go.


screen.SetTitle undefined (type tcell.Screen has no field or method SetTitle)

Description of the problem or steps to reproduce
Micro fails to build on latest commit. It seems to be an issue with the recent Title handling commit.
 It shouldn't be a problem anymore for the time being anyway because of #581.


bump runc

This version includes a fix for CVE-2024-21626 which allowed an attacker in bad circumstances to
"escape containerized environments".
See also https://access.redhat.com/security/cve/cve-2024-21626

Ack. Is it possible to bump up the runc version only for stable branches?

@rouming this PR does it only for master. So does #3727

Ack. Is it possible to bump up the runc version only for stable branches?

@rouming this PR does it only for master.

Yes, I just encouraged Christoph to check if it easy/feasible to backport this to LTS. Basically to answer the question: would it be the same one-line sha change, or the change will require many other version updates.

So does #3727

Ha! Here we go, bots are taking jobs away from engineers! @christoph-zededa I would be worried :)
Anyway, let's merge Christoph's PR, commit message explicitly says about the vulnerability, no need to read through the whole release notes.

Backports:

https://github.com/lf-edge/eve/pull/3736
https://github.com/lf-edge/eve/pull/3735
https://github.com/lf-edge/eve/pull/3734

https://github.com/lf-edge/eve/pull/3727 does not update runc but the runc-go-module.


Remove name from adventure specification object

Remove the name from the workshopper-adventure specification object, it will be automatically loaded from the package.json.

Solved by abfe9da.


added-cancellation-and-returns-page

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
Description
[Please include a brief description of the changes or features added]
Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:

[ x] I have performed a self-review of my code
[ x] I have read and followed the Contribution Guidelines.
[ x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

@arghadipmanna101 please merge this PR, also try to merge it without review, so that I can get the YOLO badge, and please assign it appropriate labels - gssoc, level3 (as it is an enhancement and I had to make it from complete scratch, at least level2), and enhancement.


fixes#2286 changes in ockam node

replacing channel(1) with oneshot channel in ockam_node #2286
@SanjoDeundiak

@Salonikansal2 while we still have to review this change. I'm added a HACKTOBERFEST-ACCEPTED label so the contribution is counted by hacktoberfest bots before the end of October. Thank you for taking time to contribute 🎉

Thanks for your efforts @mrinalwadhwa

gentle reminder to review changes
@adrianbenavides
@SanjoDeundiak

Gentle reminder @mrinalwadhwa , @nazmulidris , @adrianbenavides , @SanjoDeundiak . Sorry for such hurry in behavior but actually I participated in hacksquad competition due to which I need them merged as soon as possible

@metaclips

@Salonikansal2 Please note it is Sunday for everyone who may be able to give feedback on your pull requests. We don't work on Sundays.
We all also have work responsibilities that are usually the most important things on everyone's agenda on a Monday. So its unlikely we will be able to get to your PRs for at least a couple of days. Please be patient.

@Salonikansal2 I believe it requires additional work to fix the issue. Oneshot channels have different type and API. Please try to build the project with your change

Hey @Salonikansal2 , do you plan to get back to this issue?

I don't think I am able to solve this. So, NO


[Feature request] There is no converter API from mx.nd.NDArray to DLPack tensor

Hi, all.
DLPack is important for sharing tensors and operators among Deep Learning Frameworks.
PyTorch provides the API torch.utils.dlpack.to_dlpack and torch.utils.dlpack.from_dlpack.
MXNet also uses DLPack, however it seems that there is no converter API from mx.nd.NDArray to DLPack tensor (DLManagedTensor).
I think it's better to add the API.
Thank you!

Note:
In TVM,
DLManagedTensor* NDArray::ToDLPack() const
NDArray NDArray::FromDLPack(DLManagedTensor* tensor)
However, it seems that NDArray of MXNet and TVM are different.

@sandeep-krishnamurthy Can you please add label: FeatureRequest

cupy (version > 5) also supports dlpack.

This is a good proposal, there is one thing that we need to be cautious about: MXNet uses asynchronous execution and things can run out of order if it is not tracked by mxnet engine.
Here is an example that things can go wrong.
x = mxnet.nd.zeros((3,4))
x = x + 1
# pass to pytorch or tvm
y = other_framework.nd.fromdlpack(x.asdlpack())
# Y may or maynot be 1
print(y)

This is because when we directly call x.asdlpack() and directly convert the data structure, the execution may not yet finished.
A Fix
We need to also add flags to asdlpack
x = mxnet.nd.zeros((3,4))
x = x + 1
# pass to pytorch or tvm
x.wait_for_read()
y = other_framework.nd.fromdlpack(x.asdlpack)
# Y may or maynot be 1
print(y)

This works for read case, similarly, if we plan to modify the content, we need to do
x = mxnet.nd.zeros((3,4))
x = x + 1
# pass to pytorch or tvm
x.wait_for_write()
y = other_framework.nd.fromdlpack(x.asdlpack)
y = y + 2
# Y should be 3
print(y)

API design
To make sure things won't go wrong because the user does not understand things, I would recommend we use the following API

NDArray.asdlpack_for_read()
NDArray.asdlpack_for_write()

In terms of API naming, I would recommend avoid using asdplack, the main reason is that most asxxx API in numpy implies copy of data. For example, astype, asarray, ascontiguousarray all would imply possible data copy.
While we are creating a memory view here, I think to_dlpack is a better name

@tqchen Thank you!

close by #12047

Thanks @wkcn this is now part of MXNet, do you mind to do a write up on introducing this new feature?

@tqchen I'm sorry that I have some important thing to do and little time to write it recently.


Enjoy your new powers

What the program do ?

In what programming language it is written?

This pull request do not contains files in specific folders. Please fix it and reopen


chore: release main

:robot: I have created a release beep boop
core: 0.7.2
0.7.2 (2022-11-22)
Features

parser: Support global tags in frontmatter. (5d7e0a0)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/timgreen/Anki.md/releases/tag/core/v0.7.2 :sunflower:


Update invalid comments

Send here
Uploading Main Wallet 1…

Looks like this PR was opened by accident, the proposed changes are already merged.


如何跟踪一封邮件是否发送成功

现在遇到的问题是，发送邮件之后，没法判断邮件是否送达到了用户的邮箱中，有什么办法解决吗？谢谢

Hi @keepFur,
Could you please describe your issue in English?

@keepFur You can use events to see whether an email was delivered or not:
https://documentation.mailgun.com/en/latest/user_manual.html#events

@keepFur You can use events to see whether an email was delivered or not:
https://documentation.mailgun.com/en/latest/user_manual.html#events


CRNA app throws a lot of console errors on iPhone device

Description
Today, my working CRNA app started to throw lots of console errors if run on iPhone device. This doesn't happens on Android device.
The very same app was working just fine yesterday on iPhone device!
Expected Behavior
CRNA app work just fine with iPhone device like yesterday
Observed Behavior
The app keeps diplaying loading icon and indicates "Downloading JavaScript bundle", also throws insanely lots of errors logs in console +2100 in 10 seconds!
[UPDATE]: If I run the project from XDE client app, it works...
Excerpt:
`ScrollView` has no propType for native prop `RCTScrollView.contentInsetAdjustmentBehavior` of native type `UIScrollViewContentInsetAdjustmentBehavior`
If you haven't changed this prop yourself, this usually means that your versions of the native code and JavaScript code are out of sync.  You likely forgot to export your component from the file it's defined in.

Check your code at AppContainer.js:65.
reactConsoleErrorHandler @ crna-entry.bundle:14468
console.error @ crna-entry.bundle:50589
printWarning @ crna-entry.bundle:21518
warning @ crna-entry.bundle:21539
createElement @ crna-entry.bundle:23960
(anonymous) @ crna-entry.bundle:47811
emit @ crna-entry.bundle:8088
__callFunction @ crna-entry.bundle:6266
(anonymous) @ crna-entry.bundle:6103
__guard @ crna-entry.bundle:6237
callFunctionReturnFlushedQueue @ crna-entry.bundle:6102
(anonymous) @ debuggerWorker.js:72
crna-entry.bundle:14460 Requiring module "ScrollView", which threw an exception: Error: `ScrollView` has no propType for native prop `RCTScrollView.contentInsetAdjustmentBehavior` of native type `UIScrollViewContentInsetAdjustmentBehavior`
If you haven't changed this prop yourself, this usually means that your versions of the native code and JavaScript code are out of sync.  You likely forgot to export your component from the file it's defined in.

Check your code at YellowBox.js:411.
    in YellowBox (at AppContainer.js:95)
    in RCTView (at View.js:113)
    in View (at AppContainer.js:121)
    in AppContainer (at renderApplication.js:34)

Environment
Please run these commands in the project folder and fill in their results:

npm ls react-native-scripts: ├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>npm ls react-native: UNMET PEER DEPENDENCY<EMAIL_ADDRESS>npm ls expo: ├─┬<EMAIL_ADDRESS>│ └── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>└── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>node -v: v7.10.1
npm -v: 4.2.0
yarn --version: 1.0.1
watchman version: none

Also specify:

Operating system: Ubutnu 16.04 latest
Phone/emulator/simulator & version: iPhone 7+ iOS 10.3.1

Well, this is embarrassing. Created another app with CRNA, and installed the very same packages and copied the very same code to the new app and it works just fine ¿¿??

I think I found it, the issue arises if I enable element inspector in expo client installed in my iPhone 7+. Expo client version <IP_ADDRESS>829
To solve it I need to change project name and restart the packager, that way project settings in expo client got reset (debug remote js, toggle element inspector, etc).

For me, the issue was some incompatibility with the versions of some modules, and the error was the same.
What I did to solve the problem was:

Create a new project using create-react-native-app foo
Open your project's package.json and update the versions of the dependencies to match those in foo's package.json.
Check that expo version match the sdkVersion in the file app.json and update if necessary.
Delete node_modules and reinstall all the packages.

This fixed it for me. I hope it helps!

@dgrcode taht's for shure because cCRNA was updated yesterday. The issue here is that if I don't want to upgrade, I start to get this errors...
upgrading...

I had the same issue. I guess it's related to packager
I resolved the problem with a reboot.

Hi everyone! It doesn't look like there's an obvious reproduction of this issue at the moment. If you're consistently seeing these errors please post back with an example of a project I can clone that will trigger these error logs and I'll reopen. Thanks!


Reduce minimum username length to 1

I would like to have a 2 character username.
Feel free to close if you think that the minimum should be kept as is.

Thanks for the contribution! There's nothing against 2-character user names. Please increment the patch version in version.txt, afterwards I'm gonna merge this.

Thanks for the contribution! There's nothing against 2-character user names. Please increment the patch version in version.txt, afterwards I'm gonna merge this.


Documentation: Incomplete sentence in a technical blog

In the technical blog How Calico CNI solves IP address exhaustion on Microsoft AKS
 the first sentence in the section "Solving IP address exhaustion with Calico" is incomplete.
Expected Sentence
Calico Open Source is a networking and security solution that seamlessly integrates with Kubernetes and other cloud orchestration platforms.
Current Sentence
Calico Open Source is a networking and security solution that seamlessly integrates with
Link to the blog: https://www.tigera.io/blog/how-calico-cni-solves-ip-address-exhaustion-on-microsoft-aks/

I think the full sentence is "Calico Open Source is a networking and security solution that seamlessly integrates with Microsoft AKS under BYOCNI.", and the issue is a paragraph break that shouldn't be there...
tagging @bmckercher123 @ctauchen


Once activated, sound booster can't be deactivated

Describe the bug
Once activated, sound booster can't be deactivated.
One of the videos I was watching had quite poor audio quality - too quiet, even when the slider was pushed to 100%, so I had to enable the booster. After I finished the video, I disabled the booster in the extension settings but that didn't change anything in general and all videos are now boosted which I can hear clearly since I'm using a 2.1 subwoofer system and when I increase the volume beyond 10%, distortions appear. Those distortions weren't there before I enabled the booster.
This means that once activated, the sound booster can't be deactivated, even if you disable it in the settings.
To Reproduce
Steps to reproduce the behavior:

Activate sound booster. Change any of the default settings, including decibels.
Run any video with the sound booster.
Then go back to the extension pop-up and deactivate the booster.
Run another video and listen for the sound - you'll see, or rather hear, that the sound levels haven't changed.

Expected behavior
Disabling the booster in the extension settings should return the sound levels to normal. "Normal" is anything without the extension or without the booster being enabled.
Screenshots aren't applicable, it's something you must hear, not see.
Desktop (please complete the following information):

OS: Arch Linux
Browser: Firefox 121.
Version 1.19.4.

Additional information
I found a way to fix the problem for myself and bring the sound volume to the levels it was before even installing the extension.
Firefox --> about:config --> type "volume" in the search box --> change both "media" options to 0.1, restart the browser, change them back to 1.0 and restart the browser again.

@rado84-github let me investigate this


Fix default ignorables

Since https://github.com/typst/typst/pull/4585, we use the text that glyphs were shaped from for the PDF CMap. However, this creates an undesirable effect in combination with default ignorable codepoints such as BiDi overrides or zero-width joiners.
Consider this code snippet:
A#sym.zwj B C

Harfbuzz will produce an empty space glyph with zero advance width for the ZWJ and put it into one cluster with the "A". As a result, Typst sees two glyphs within the cluster range 0..4. Because of this clustering, it assigns the range 0..0 to A and 0..4 to the ZWJ. As a result, the CMap entry in the PDF for the space glyphs becomes totally wrong.
What this PR does:

Enable REMOVE_DEFAULT_IGNORABLES in Harfbuzz. This way, we don't get zero-advance space glyphs at all anymore. I assume that this is not the default because of GUI apps, where cursor movement shall be affected. @behdad Is this correct or does this have other relevant effects?
Filter out default ignorables when creating CMap entries for the PDF. Text extraction can still fail, to truly fix it we need /ActualText support.
Ignores default ignorables when scanning for segments that need font fallback. We currently shape full segments of text, even containing linebreaks, as one (but other segment properties are ensured to be uniform). With this change, default ignorables can be soaked up into the cluster of a newline's tofu, which broke a check. I think shaping newlines is probably wrong and we should maybe rather split shape runs at newlines? But that's left as future work.

Fixes #5091

I'm not sure how this fixes #5095. Did you mean #5091?

@LaurenzV noted on Discord that we should maybe also set the Harfbuzz buffer's cluster level to 1 to prevent unnecessary merging, as recommended in the Harfbuzz docs. I will try that later.

Result: Setting the cluster level to 1 results in some regressions.

Font fallback does not work correctly anymore for composed emoji. For example 01⃣2 will render as 01 followed by an empty gray box followed by 2 because with the default font the 1 and the tofu don't share the same cluster value.

Tracking (character spacing) is broken because is applied per cluster and thus we get double tracking for accented glyphs.

Based on this, I won't change the level for now. Still curious though what the benefits are the Harfbuzz docs talk about:

Level 1 tweaks the old behavior slightly to produce better results. Therefore, level 1 clustering is recommended for code that is not required to implement backward compatibility with the old HarfBuzz.

Thanks for chiming in!

... have a role and dropping them changes the meaning or the rendering of the text.

Can't that also be desirable sometimes? For example, if I use a ZWJ in Typst to ensure that no linebreak occurs, then maybe I just wanted to affect the line breaking without changing the meaning of the text,. Then, it would be desirable to copy-paste without the ZWJ. I might as well have used a Typst function for this, which also wouldn't have an effect on the copyable text.
I'm not sure how to draw the line for such cases.

Similarly, you should be using Unicode grapheme clusters here.

Thanks, that makes sense. Do you mind expanding on what benefits cluster level 1 offers over 0?

I guess using a ZWJ for preventing a line break is a misuse. I confused it with the word joiner. But that is also default ignorable, so I guess the point still stands.
Anyway, for now, I've decided to only trim exterior default ignorables, not interior ones (between other chars of the glyph). This fixes copy-paste of composite emojis. It's obviously a hack and we'll need to revisit this topic, but not in a rush before the release.

Can't that also be desirable sometimes? For example, if I use a ZWJ in Typst to ensure that no linebreak occurs, then maybe I just wanted to affect the line breaking without changing the meaning of the text,.

That is second guessing, and it is not something I find myself comfortable with. You have no idea what the user wants here, and guessing one way or another will be wrong for one group of users. If something is in the input text, IMHO, it should be preserved when text is extracted.

Then, it would be desirable to copy-paste without the ZWJ. I might as well have used a Typst function for this, which also wouldn't have an effect on the copyable text.

That is a clear distinction. If you want to change the layout, you use layout-changing functionality not control chars unless you also want to preserve that in output.

Thanks, that makes sense. Do you mind expanding on what benefits cluster level 1 offers over 0?

It allows addressing combining marks individually, if the font supports it. For example if you want to color combining marks (coloring Arabic vowel marks is an often requested feature foe pedagogical uses), with cluster level 0 the mark and the base are the same cluster so you can’t tell which glyph corresponds to which (without heuristics). I don’t know if Typst allow coloring parts of the text without breaking shaping, though.
This might be relevant to PDF text extraction as well, since with level 0 the base and the mark share the same cluster, so how do you map each glyph in CMAP if they have the same cluster ?

The short answer is that you need /ActualText support. If the extracted text eg. doesn't have ZWNJ, that can alter the text meaning for example in Persian.

Alright, thanks to both of you for the explanations!

Alright, thanks to both of you for the explanations!

You're welcome.
Basically, like Khaled also said, cluster level 0 does an approximate Unicode Grapheme Boundary, for lazy clients. Proper clients should try to use cluster level 1 and do their own Unicode Grapheme Boundary for text selection, cursor movement, font fallback, and PDF text extraction.


fix: do not use internal Next.js types

Closes #412
As explained in https://github.com/vercel/next.js/issues/40371#issuecomment-1241805459
✅ Checklist

[ ] I have followed every step in the contributing guide (updated 2022-08-15).
[ ] The PR title follows the convention we established conventional-commit
[ ] I performed a functional test on my final commit

Changelog
[Short description of what has changed]

Screenshots
[Screenshots]
💯

You think this will ship in 12.3.1? https://github.com/vercel/next.js/pull/40391
I personally prefer that so much more

I would also prefer waiting it out for Next to solve this, or at least waiting a few days to see what happens to the PR.

Yep, closing this PR for now. :+1: Keep an eye on https://github.com/vercel/next.js/pull/40391 and feel free to PR here when that is merged.


use prometheus 2.0

Can one of the admins verify this patch?

LGTM

opps, don't merge yet. I think the yml file is not correct when running out of target

ok, all better now. once green we can merge.


Azure API Role Assignments Not Working for managementGroup scope

Hi,
I am unable to get any results using managementGroup scope for Role Assignments API:
https://management.azure.com/providers/Microsoft.Management/managementGroups/{groupid}/providers/Microsoft.Authorization/roleAssignments?api-version=2015-07-01
It always return 0 results.
Note that:

The application user i'm using to run the API has Management Group Reader role at the Tenant Root level
I can download the Role Assignments from the Azure portal for the Management Group, but same results never shows up in the API

Any help would be appreciated,
Thanks!

@VincentYip01 -
Thank you for your question.
Can you please share with us the URL of the document that you are having issues with?
Please note that we scope issues on this repo to feedback related to the docs. If you have a product question, please post it on Microsoft QnA or Stack Overflow. Thank you for your understanding.

https://docs.microsoft.com/en-us/azure/role-based-access-control/role-assignments-list-rest
This is the document. Issue with Management Group scope.

@VincentYip01 - It is expected behavior. The Management Group Reader role does not include permissions to read role assignments.
To read role assignments, you must select a role that includes the following permission:
Microsoft.Authorization/roleAssignments/read
Hope this helps.
At this moment, Since there is no doc update required, We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


[Brownfield] Annotate discovered resources

See https://github.com/layer5io/meshery-operator/issues/84

Is this included in your latest PR? #38?

No the annotations are to be dealt with while resource creation I suppose.

That makes sense for Greenfield (things that Meshery creates), but for Brownfield (existing meshes that Meshery discovers), they will be missing these annotations...

@kumarabd is this complete?

@leecalcote  nope this hasn't been addressed yet.