TextInput inside FlatList based on API response.

Hi, i am displaying TextInputs inside FlatList based on API response. But in FlatList i have check-boxes, drop-downs and TextInputs. If i can check one item in array then it will add some objects (contains TextInputs) in array. When a value is entered on a particular TextInput it's working fine but if uncheck that item i should remove some objects (contains TextInputs) in array. In this case i am facing an issue like after unchecking the check-box text-field (what i have entered value before) is appending to below TextInput.
React Native version:

"react-native": "0.60.5"

Steps To Reproduce

How can i append the values to text-input after changing their positions like when i add some objects and remove some objects

this.state = {
     textInputsValue: [],
   };
 onChangeText(text) {
   const { index, item } = this.props;
   const textInputsValue = [...this.state.textInputsValue];
   textInputsValue[index] = text;
   this.setState({
     textInputsValue
   });
 }
 <Mytextinput
                 placeholder="Enter Here"
                 value={this.state.textInputsValue[index]}
                 onChangeText={this.onChangeText}
                 onEndEditing={this.onEndEditingText}
                 onSubmitEditing={() => Keyboard.dismiss()}
               />

Describe what you expected to happen:

Text-input values should not append to another text-inputs when i add some objects or remove some objects in array.

Screenshot:-

I don't think it's a bug in React Native. You should use keys so the inputs are not reused (or you have a mistake in your implementation). Also, you can use ScrollView instead of Flatlist.

hi @radko93, thank you for your response. I am getting response (array) from api. So i am using FlatList. Without FlatList how can i implement TextInputs based on array. Because i need to implement the UI elements based on API response. Please re-open this issue.

I cannot reopen because it's not a react native issue. Please ask this question on Stackoverflow. I can only say that you can try:
<ScrollView>
dynamicInputs.map(input =>
   (<TextInput />))
</ScrollView>

hi @radko93, i am asking about how to accept multiple values in TextInput.

Just render them separately, why not? Please ask on Stackoverflow, this is not a bug.

yes, i am using FlatList for rendering the Text-inputs. But i am displaying text-inputs based on API response. So it is a dynamic array. I am getting an issue in UI part. Please go through the above gif file.
I am adding some objects in an array and entered the values in text-inputs and remove that objects in an array. So that the input value is assigned to another object.


DSWE/aggregation fixes, consolidation of GEE request function, readme updates

Finally fixed the DSWE pixel counts. 72accd2 & 4114011

Take home is, you can tell GEE pretty much any variable name in the reducer (e.g. L465-475 of landsat_c2/literateCode/LandsatC2_M4-7_SurfaceRefTempStacks.Rmd in 72accd2), but it's always going to process them in the order you added them to the pixOut object irrelevant of the band name you tell it to grab (e.g. L441-464 of the same doc). The band name you give it is just the name in the output. Xiao is the hero for tracking this one down.

Closes #17
Closes #13

I consolidated the instances of redundant code that sends requests to GEE into a single code block and incorporated the landsat_c2/literateCode/LandsatC2_sceneMetadata.Rmd script into this same block. 31b3fd0 & 7ed178e

This just streamlines the process of sending the reducer functions to be processed in the GEE task list into a single loop. Included a try statement for the whole-lake extent, since folks outside of the US can't use the whole-lake function and others might not want it at all.

Wrapped update of README and the 'helps' directory da4fabd through 85499a8

These updates are aimed at making it more clear how to interact with the scripts for those outside of our lab. There are some suggestions for debugging common issues in the 'helps' directory.

Closes #6

Hey @mbrousil and @kathryn-willi - I'm pretty happy with this workflow now for the Landsat pull. Once Matt B has done the review of the PR and we've merged the pull request, I think it would be great if you two ran through Landsat code top-bottom for a lake of your choosing to provide and feed back or to point out places that are unclear in commenting, or in general understanding. The latter is helpful so that I know what to focus on when I give an overview of this repo at some point at a lab meeting. There is no rush on the testing of the scripts, that's really just for your general understanding.


Main go routine exits on startup for nil values of monitoring in getDomainEntity

There is a bug in src/lib/api/api.go, when you start bench-routes for the first time, the getDomainEntity for monitoring values can be nil which panics the main go-routing into exiting.

A simple solution can be just doing a nil check here. https://github.com/bench-routes/bench-routes/blob/b71131ae1437de8dc6719a3a5e91d157f72dd216/src/lib/api/api.go#L123


encryption: Add config to gate the log style file dictionary optimization

What problem does this PR solve?
Issue Number: close #9190
Problem Summary:
#8865 introduces an optimization to greatly reduce IO and mutex contention when encryption is enabled, by turning the file dictionary file into log style. The optimization is also useful to improve Lightning data import speed. We would like to include the optimization in 4.0.x branch as well.
However, the optimization introduce a data format that is not recognizable by TiKV <= 4.0.8. To address the problem, this PR introduce the security.encryption.enable-file-dictionary-log config to allow turning off the optimization and convert to previous data format. The option will be default to true for TiKV >= 5.0, and default to off for TiKV < 5.0 but >= 4.0.9. User can downgrade TiKV cluster with encryption turned on to <= 4.0.8 with the following steps:

set security.encryption.enable-file-dictionary-log = false and restart TiKV. After TiKV successfully start, the data format is converted back to the same as before the optimization.
downgrade to version between (included) 4.0.0 and 4.0.8 (since encryption is not supported pre-4.0).

What is changed and how it works?
What's Changed:
introduce the security.encryption.enable-file-dictionary-log config to allow turning off the optimization and convert to previous data format.
Related changes

#8865 introduces the backward-incompatible change.
Will update user docs

Check List
Tests

New unit tests
manual testing for downgrade to previous file dictionary format
Will do bank2 test for correctness

Release note

Fix TiKV not able to downgrade from 5.0 to 4.0.x, after TDE is enabled, by introducing the security.encryption.enable-file-dictionary-log config.

/test

/merge


Fix for over-writing subscription token

This commit includes

Fix to prevent over writing subscription token with normal GET request tokens.

@janjongboom @stephenkyle-ARM In case you would like to test with your subscription use case.

Failed

rebuild

Failed

rebuild

@anttiylitokola Morpheus CI needs to be checked today, if it is still broken, may be disable for today

On first look it seems to work 👍

rebuild

rebuild

rebuild

rebuild

rebuild

rebuild


Add A lookup for headless services

Adds caching for endpoints
When a service is headless (e.g. Cluster IP = None), look up the endpoints (pods) that serve the service
Adds headless service A record config and tests to k8s integration testing

Current coverage is 38.82% (diff: 0.00%)

Merging #451 into master will decrease coverage by 0.33%

@@             master       #451   diff @@
==========================================
  Files           113        113
  Lines          5450       5497    +47
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2134       2134
- Misses         3139       3186    +47
  Partials        177        177

Powered by Codecov. Last update 8faa835...c206616


Overlay opacity is shown even when the dialog is hidden

I have a problem when using react-native-simple-radio-button inside a dialog from react-native-popup-dialog https://github.com/jacklam718/react-native-popup-dialog
I found a similar issue here with react-native-modal-selector  https://github.com/peacechen/react-native-modal-selector/issues/76#issuecomment-405948871 . The solution provided there works, by removing
 if (Platform.OS === 'android') {       UIManager.setLayoutAnimationEnabledExperimental &&         UIManager.setLayoutAnimationEnabledExperimental(true);     }
From the RadioForm component.
I will make a pull request to remove this, I would like to know if these lines affect drastically the behaviour or performance of this module.

#98

Hope you can merge the pull request @moschan


Add network stats

Add incoming and outgoing bandwidth to ptop

The following psutil methods can be used.

.net_io_counters()
.net_if_addrs()

Network Stats can be added using psutil.net_io_counters() by which we can display the bytes sent and received in the ptop monitor.
net = psutil.net_io_counters()
sentt = net[0]*0.000001
sentt = str(round(sentt,2))
recc = net[1]*0.000001
recc = str(round(recc,2))
row4 = "Network Usage  {4}{0: <6}/{1: >6} MB{4}{2: >2} %{5}Boot Time{4}{3: <8}".format(sentt,
recc,
3,
4,
" "int(4self.X_SCALING_FACTOR),
" "int(9self.X_SCALING_FACTOR))

Hi Smeet, Thanks for the code snippet. Actually, I have a plan to not show users raw stats in numbers but to have a bar graph also by using a module https://github.com/darxtrix/lehar that i wrote for this purpose.

Thanks Ankush !
Will try to look into the bar graph thing using lehar.
[image: Mailtrack]
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
Sender
notified by
Mailtrack
https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&
10/29/18,
8:36:38 PM
ᐧ
On Mon, Oct 29, 2018 at 6:03 PM Ankush Sharma<EMAIL_ADDRESS>wrote:

Hi Smeet, Thanks for the code snippet. Actually, I have a plan to not show
users raw stats in numbers but to have a bar graph also by using a module
https://github.com/darxtrix/lehar that i wrote for this purpose.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/darxtrix/ptop/issues/18#issuecomment-433892742, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AiNRldjLwjFS01OzyUcOT82vwN7fNW6Hks5upvWBgaJpZM4OVmGF
.

--
Regards
Smeet Vora
Class Representative
Junior Undergraduate | Department of Computer Science and Engineering
IIT Gandhinagar
Contact No. :<PHONE_NUMBER>

@smeet20 Skipping the graph for now, fixed by #50


Remove dependency to common in the REST repository

Rplace org.eclipse.winery.common.Util with org.eclipse.winery.repository.backend.BackendUtils and remove the thereafter unnecessary dependecy in the repository
Signed-off-by: Lukas Harzenetter<EMAIL_ADDRESS>
[x] Ensure that the commit message is a good commit message
[x] Ensure to use auto format in all files
[ ] Change in CHANGELOG.md described
[ ] Tests created for changes
[ ] Screenshots added (for UI changes)

I thought, as a next step, the common methods can be moved to the Client, but this is not true as the repository still depends on it - see text of http://eclipse.github.io/winery/dev/#project-orgeclipsewinerycommon


Unable to specify parameters via properties

As a user, I would like to be able to specify the configuration parameters (eg. space key, ancestorId, user name, password, etc) as properties so that I can customize properties either using profiles or at the command line depending on the build.
For example, allowing the spaceKey to be set via command line would allow the CI build to select a different spaceKey depending on the type of build (e.g snapshot or release) or for the CI build to specify the user name and password for production.

Hi @garretfick
You can specify all the parameters using maven properties as described here (Under "Maven Plugin Configuration").
Parameters can also be set via command line like this: ./mvnw asciidoc-confluence-publisher:publish -D"publisher.username=username" -D"publisher.password=password" -D"publisher.spaceKey=spaceKey" -D"publisher.ancestorId=86378131"


Message 'No todos in this file' after a task has been completed

Bug Report
App Version: 2.0.12
Platform: Linux
Installation Method: App Store (Flatpak)
Expected Behavior:
If I mark a task as completed, it should disappear from the list - all other (uncompleted) tasks should remain visible.
Actual Behavior:
I mark a task as completed, then all tasks disappear from the list and the message 'No todos in this file' is displayed.
I can now close the file and reopen it - so all uncompleted tasks are back. Or I can just change the window size and all tasks will reappear.
I noticed this behavior for the first time after updating to version 2.0.12. And the error really occurs every time I check off a task.
Steps to Reproduce:

open the app
mark a task as completed
--> List empty, message 'No todos in this file'
change the window size
unfinished tasks are displayed

Screenshots:

before I have marked a task as completed

after I have marked a task as completed

after I have changed the size of the window

@mdbdb is there by any chance some file sync happening in the background, for example Synchting, Dropbox, Google Drive and so forth?

@mdbdb @TriggerDingus in 2.0.12 we were tweaking the filewatcher settings a bit, because some had issues with sleek and file syncing applications. Actually this has been a constant pain for years now. We also introduced new settings to tackle difficulties, which could arise in environment, where there is file syncing involved.
@aisbergde @RobLW @42web-ch this is also a heads up for you guys. In the next pre-release (2.0.13-rc.2) I will revert the default settings of the filewatcher to pre 2.0.12 since it seemed to worked better for the majority of users. 2.0.12 has only just been released and is already producing bug reports connected to the change.
I will furthermore remove the 3 settings we introduced over at https://github.com/ransome1/sleek/issues/676.
Instead I will introduce 1 new setting named chokidarOptions. This new setting represents the chokidar options object as described here: https://github.com/paulmillr/chokidar?tab=readme-ov-file#persistence
Like this you will have all of Chokidar's options available and can adjust the filewatcher precisely to your environment. Since you might have already adapted to the 3 new options you will now need to apply your changes using the chokidar syntax. For example:

{
usePolling: false,
interval: 100,
atomic: true
}

Chokidar has many more options, which can help figuring out a working setting for your particular environment.

@mdbdb @TriggerDingus before you start wrapping your head around all those Chokidar options, can I ask you to check out this pre-release and tell me if the issue still occurs? https://github.com/ransome1/sleek/releases/tag/v2.0.13-rc.2
If the config migration worked, it should regress to the behavior of sleek 2.0.11, where I understand you did not face these issues.
@aisbergde @RobLW @42web-ch you're invited to check the new option and let me know if this works for you.

@mdbdb @TriggerDingus before you start wrapping your head around all those Chokidar options, can I ask you to check out this pre-release and tell me if the issue still occurs? https://github.com/ransome1/sleek/releases/tag/v2.0.13-rc.2
If the config migration worked, it should regress to the behavior of sleek 2.0.11, where I understand you did not face these issues.
@aisbergde @RobLW @42web-ch you're invited to check the new option and let me know if this works for you.

I completed several tasks with the AppImage and no issues so far. I'll keep using it this afternoon and report if it happens again.

I have the exact same issue. I tried it with a file that is not synced to any other storage. But I observed that it happens if and only if the task is recurring: If I complete the following task
2024-03-27 test  rec:+1d due:2024-03-27

the UI will show no tasks any more, but if I complete
2024-03-27 test due:2024-03-27

all remaining open tasks will stay on the UI as desired.
Maybe it helps to narrow down the issue.

@GaloisGecko

the UI will show no tasks any more, but if I complete

What exactly does the UI show?
And how do your filter settings look like in the drawer?

This is the UI including filter settings before I complete the task:

And after I complete the task, it looks like this:

If the task would not be recurring, it would vanish, but the other task would remain on the UI.

Is this the latest pre-release (2.0.13-rc.2) or 2.0.12? If it is the latter, does the same happen with the pre-release as well? There is an AppImage in that release for a quick glance.

I am still on 2.0.12, sorry for that.

@mdbdb @TriggerDingus before you start wrapping your head around all those Chokidar options, can I ask you to check out this pre-release and tell me if the issue still occurs? https://github.com/ransome1/sleek/releases/tag/v2.0.13-rc.2
If the config migration worked, it should regress to the behavior of sleek 2.0.11, where I understand you did not face these issues.
@aisbergde @RobLW @42web-ch you're invited to check the new option and let me know if this works for you.

I just marked some of my tasks as done with version 2.0.13-rc.2 under the same conditions as before (todo.txt is synchronized via Syncthing).
➡ The error no longer occurs!

@ransome1 Hi, thanks for the update. I am switched from debian to arch on my work pc. All works fine on the new setup!

Apologies I've been neglecting the app recently so not noticed changes/issues.
I've just updated Fedora from 39 to 40. The issue took place then. When I opened the app and laid my mouse over the tabs, I noticed that it was referring to a location that I think was for temporary files.(sorry I forgot to make actual note or screenshot).
Thinking about it now, I'm wondering does the app use a temporary file while open, and occasionally writes this back to the actual todo files?.
If this is the case then when we reboot without closing down the app (which is always the case for me) the system will wipe the temp files and the app loads again expecting to find those files rather than loading the todo files in my home dir.? Just a thought.


[DataFactory]Added new features into 4.16.0

Added Amazon S3 Compatible and Oracle Cloud Storage connectors

Azure/azure-rest-api-specs#13368

Updated AzureDataExplorer LinkedService servicePrincipalId, servicePrincipalKey, tenant properties from required to optional

Added accountKind property to AzureBlobStorage LinkedService

Azure/azure-rest-api-specs#13291

Added AAD auth to CosmosDb LinkedService

Azure/azure-rest-api-specs#13257

Added authHeaders to HTTP/REST/OData LinkedService

Added MultiFactor auth to SFTP LinkedService
Azure/azure-rest-api-specs#13204

Added UAMI to Identity: Azure/azure-rest-api-specs#13174

Added privateEndpointConnection apis to DataFactory: Azure/azure-rest-api-specs#13249

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

/azp run

/azp run net - mgmt - ci


Tests appear as "terminated" in RubyMine 2018.3.1

Hello,
For some reason, even though all test passed, RubyMine shows the test run as "terminated":

There are no errors or stack traces in the log.
How can I gather more information to find out what went wrong?

A bit more info: https://youtrack.jetbrains.com/issue/RUBY-20717#u=1515471194920

according to the ticket the problem is caused by changes in minitest and Rubymine team is working on this (https://youtrack.jetbrains.com/issue/RUBY-21353) I will be happy to help them as soon as they will have something.
Since I have nothing to do here I'm closing the issue for now.

Is this issue related to #266?


Fix/add timestamps block

Description
This PR adds BlockOrder (order) creation timestamps to give the user an idea of when a blockorder was created on the broker.
This timestamp was added due to information needed in the CCXT fetchOrder command, however this is a good addition to our API for other users as well.
Related PRs
List related PRs if applicable
Todos

[x] Tests
[x] Documentation
[x] Link to Trello

 add fetchOrder to ccxt implementation

@martineehrlich it is set on its own, but you can also specify a timestamp (which we use when we need to re-create BlockOrders). See: https://github.com/sparkswap/broker/pull/259/files#diff-6149506167c1b50a1ee6bb28a20b83afR26

Ah I see


PDF kit is down

Hi,
When I open pdfkit.org, I get the following error "GitHub Pages is temporarily down for maintenance."
When can I expect the server to be back?

it's back online.


Fix Cert_URI Bug to string for Hangouts Channel

Proposed changes:

Changed the CERT_URI in hangouts.py to a string.

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[Fixed this error traceback (most recent call last):
File "/home/ec2-user/.local/lib/python3.6/site-packages/sanic/app.py", line 976, in handle_request
response = await response
File "/home/ec2-user/.local/lib/python3.6/site-packages/rasa/core/channels/hangouts.py", line 280, in receive
self._check_token(token)
File "/home/ec2-user/.local/lib/python3.6/site-packages/rasa/core/channels/hangouts.py", line 257, in _check_token
bot_token, self.project_id, cert_uri=CERT_URI,
File "/home/ec2-user/.local/lib/python3.6/site-packages/oauth2client/_helpers.py", line 133, in positional_wrapper
return wrapped(*args, **kwargs)
File "/home/ec2-user/.local/lib/python3.6/site-packages/oauth2client/client.py", line 1556, in verify_id_token
resp, content = transport.request(http, cert_uri)
File "/home/ec2-user/.local/lib/python3.6/site-packages/oauth2client/transport.py", line 282, in request
connection_type=connection_type)
File "/home/ec2-user/.local/lib/python3.6/site-packages/httplib2/init.py", line 1794, in request
(scheme, authority, request_uri, defrag_uri) = urlnorm(uri)
File "/home/ec2-user/.local/lib/python3.6/site-packages/httplib2/init.py", line 241, in urlnorm
(scheme, authority, path, query, fragment) = parse_uri(uri)
File "/home/ec2-user/.local/lib/python3.6/site-packages/httplib2/init.py", line 236, in parse_uri
groups = URI.match(uri).groups()
TypeError: expected string or bytes-like object ]
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for submitting a pull request 🚀 @tmbo will take a look at it as soon as possible ✨


When select InputEvent as base type the class constant is empty

Godot version:
v3.1.dev.calinou.1800664
OS/device including version:
windows 10 x64
Issue description:
In visual script
In Class constant node, when select InputEvent as base type the class constant is empty.

Can anyone still reproduce this bug in Godot 3.2.1 or any later release (e.g. 3.2.2-rc2)?

Can anyone still reproduce this bug in Godot 3.2.1 or any later release (e.g. 3.2.2-rc2)?

I can reproduce this in Godot 3.2.4 rc1 as shown in the screenshot below:

Can anyone still reproduce this bug in Godot 3.2.1 or any later release (e.g. 3.2.2-rc2)?

I can reproduce this in Godot 3.2.4 rc1 as shown in the screenshot below:


fix bidirectional zigzag

fixes #1486
TMPE.zip
when at least one track is bidirectional I reverse similar lane index if:

segments are in opposite directions
XOR only one segment is inverted
XOR lane directions do not match:

dir1
dir2
lanes match

bidirectional
backward
no

bidirectional
forward
yes

bidirectional
bidirectional
yes

Additional changes:

renamed a few variables with regards to direction.
added a few extension methods.

I converted to draft because I'd like to do some tests

I performed several tests involving building/deleting/spliting/reversing segment at junction and did not manage to break lane routing.

@kianzarrin can you merge latest changes for master

@Elesbaan70 any opinion on this?

I've spent very little time in the routing manager, so I don't think I have enough prior knowledge of how the code works to be of any use here. 🤷♂

what about you @aubergine10

@kianzarrin hoping to do some testing in a couple of hours

good idea. if someone can't understand the code then at least some testing can be done.


Error capturing f32 audio stream on Windows

Hi,
I would like to use your software to stream music to a Volumio server, but when I do so I have no sound. The log shows an error about capturing the audio, this happens on two machines I tested it on. I also tested with the VBAudio HiFi Cable but I get the same error. I hope you can fix this!
log.txt

Hi,
The most likely cause is that the application playing the audio has opened the WasApi device in exclusive mode. Foobar2000 is an example of such an application.
There are ways around this using the Windows audio mixer. For instance with Foobar2000 you choose the default audio output and in the sound mixer you direct the Foobar2000 output to VB audio.
(But with Foobar2000 you don't need swyh-rs as it suports upnp/dlna directly.)
What application are you using to play audio?

Hi,
I am using Firefox on Windows 10, but the issue is most likely caused by Kaspersky.
I will contact our IT provider about creating an exception for swyh-rs and see if that solves the problem and report back.
Thanks for your help!

I have no problem with Firefox and VB-Audio Hifi Cable, so Kaspersky might indeed be the culprit:

It was indeed caused by kaspersky.


Broken link

In the documentation logger where it says "Read more in the Experiment Logging use case", the link is broken.

@DKandrew mind send a PR? :rabbit:

Sure! Should I just route the link to this website?

Update: I think I can see where the problem comes from, but I don't know how to modify it.

mind check this link generation
https://github.com/PyTorchLightning/pytorch-lightning/blob/0914873bc2f588ae592c896460c0c9e6577324cf/docs/source/conf.py#L348-L382

@DKandrew how is it going, did the link generation helped?

@Borda Hi Borda, Sorry I did not look into it because this week is my final week. Could I fix this issue during the weekend?

Sure, and thanks for your help

Hi @Borda
After looking into this issue in the afternoon. I don't think I can come up with a perfect solution.
The only working solution that I have, is to change the link to the online linkage.
# Change from
Read more in the `Experiment Logging use case <./experiment_logging.html>`_.
# To
Read more in the `Experiment Logging use case <https://pytorch-lightning.readthedocs.io/en/latest/experiment_logging.html>`_.

The challenge is that the reference link is encoded in the docstring, not in a pure .rst file, so the Custom Anchor solution listed here does not work. The function linkcode_resolve does not help because it seems that it is generating a link to the main body of a Python function/variable, not an unnamed string put on top of the Python file.
Similar reference issue is also discovered in this link
https://pytorch-lightning.readthedocs.io/en/latest/api/pytorch_lightning.trainer.html
Again, because of the ../api/.. in the path of HTML, if you try to click

Multi-GPU training guide
Multi-node (SLURM) guide
Any link that does not belong to api folder

You will get the same 404 result.

The downside of my solution is that developers have to have a network connection when they test this link, and the link will not direct to their local file (which they may be also developing).
Any Suggestions?

"Read more in the Experiment Logging use case"

I didn't see this line on logger documentation.  Is it removed?

@DKandrew as it is a while, I am wondering if this is still valid, mind update?

Hello @Borda,  it seems like the documentation in the original page is gone, as @Kshitij09 points out. So this case may not be valid anymore.


Pip and conda install pydantic 2.0.2 by default, that causes ImportError

Bug description
I am developing library that requires lightning dependency. I am trying to build it using conda-build, but it crashes on testing with error ImportError: cannot import name 'ModelMetaclass' from 'pydantic.main'. It also crashes with the same error when I tried to test it with tox in appveyor in python 3.8, 3.9, 3.10 and 3.11 on both windows and ubuntu.
I also tried to create new clean venv in pycharm, install lightning via pip and import lightning shows the same error.
Looks like pip and conda install pydantic 2.0.2 by default, but in this version 'ModelMetaclass' is not located in 'pydantic.main' anymore.
Manual installation of pydantic <2.0 or adding requirement pydantic <2.0 to requirements in my setup.py and meta.yaml fixes the problem.
UPD: also I found out that in wheel from pypi in METADATA file pydantic dependency is Requires-Dist: pydantic (<4.0,>=1.7.4), in tar.gz from pypi in requirements/base.txt it is pydantic<3.0,>=1.7.4 and in requirements/app/base.txt it is pydantic >=1.7.4, <2.0.0. conda search lightning --info also shows dependency - pydantic <4.0,>=1.7.4. I think it was supposed to be <2.0, not <4.0?
What version are you seeing the problem on?
v2.0
How to reproduce the bug
1. Create new python venv
2. pip install lightning
3. import lightning

Error messages and logs
ImportError while importing test module 'C:\projects\remote-sensing-processor\tests\test_landsat.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
C:\Python311-x64\Lib\importlib\__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test_landsat.py:4: in <module>
    import remote_sensing_processor as rsp
..\.tox\python3.11\Lib\site-packages\remote_sensing_processor\__init__.py:21: in <module>
    from remote_sensing_processor import segmentation
..\.tox\python3.11\Lib\site-packages\remote_sensing_processor\segmentation\__init__.py:3: in <module>
    from remote_sensing_processor.segmentation.segmentation import segmentation_train, segmentation_test
..\.tox\python3.11\Lib\site-packages\remote_sensing_processor\segmentation\segmentation.py:12: in <module>
    import lightning as l
..\.tox\python3.11\Lib\site-packages\lightning\__init__.py:18: in <module>
    from lightning.app import storage  # noqa: E402
..\.tox\python3.11\Lib\site-packages\lightning\app\__init__.py:24: in <module>
    from lightning.app import components  # noqa: E402, F401
..\.tox\python3.11\Lib\site-packages\lightning\app\components\__init__.py:1: in <module>
    from lightning.app.components.database.client import DatabaseClient
..\.tox\python3.11\Lib\site-packages\lightning\app\components\database\__init__.py:1: in <module>
    from lightning.app.components.database.client import DatabaseClient
..\.tox\python3.11\Lib\site-packages\lightning\app\components\database\client.py:22: in <module>
    from lightning.app.components.database.utilities import _GeneralModel
..\.tox\python3.11\Lib\site-packages\lightning\app\components\database\utilities.py:23: in <module>
    from pydantic.main import ModelMetaclass
E   ImportError: cannot import name 'ModelMetaclass' from 'pydantic.main' (C:\projects\remote-sensing-processor\.tox\python3.11\Lib\site-packages\pydantic\main.py)

Environment
pip list after pip install lightning in clean venv
Package             Version
------------------- --------
aiohttp             3.8.4
aiosignal           1.3.1
annotated-types     0.5.0
ansicon             1.89.0
anyio               3.7.1
arrow               1.2.3
async-timeout       4.0.2
attrs               23.1.0
beautifulsoup4      4.12.2
blessed             1.20.0
certifi             2023.5.7
charset-normalizer  3.2.0
click               8.1.4
colorama            0.4.6
croniter            1.3.15
dateutils           0.6.12
deepdiff            6.3.1
exceptiongroup      1.1.2
fastapi             0.100.0
filelock            3.12.2
frozenlist          1.3.3
fsspec              2023.6.0
h11                 0.14.0
idna                3.4
inquirer            3.1.3
itsdangerous        2.1.2
Jinja2              3.1.2
jinxed              1.2.0
lightning           2.0.4
lightning-cloud     0.5.37
lightning-utilities 0.9.0
markdown-it-py      3.0.0
MarkupSafe          2.1.3
mdurl               0.1.2
mpmath              1.3.0
multidict           6.0.4
networkx            3.1
numpy               1.25.0
ordered-set         4.1.0
packaging           23.1
pip                 22.1.2
psutil              5.9.5
pydantic            2.0.2
pydantic_core       2.1.2
Pygments            2.15.1
PyJWT               2.7.0
python-dateutil     2.8.2
python-editor       1.0.4
python-multipart    0.0.6
pytorch-lightning   2.0.4
pytz                2023.3
PyYAML              6.0
readchar            4.0.5
requests            2.31.0
rich                13.4.2
setuptools          62.3.3
six                 1.16.0
sniffio             1.3.0
soupsieve           2.4.1
starlette           0.27.0
starsessions        1.3.0
sympy               1.12
torch               2.0.1
torchmetrics        1.0.0
tqdm                4.65.0
traitlets           5.9.0
typing_extensions   4.7.1
urllib3             2.0.3
uvicorn             0.22.0
wcwidth             0.2.6
websocket-client    1.6.1
websockets          11.0.3
wheel               0.37.1
yarl                1.9.2

setup.py with requirements
import setuptools

with open("README.md", "r") as fh:
    long_description = fh.read()

with open("src/remote_sensing_processor/__init__.py") as f:
    for line in f:
        if line.find("__version__") >= 0:
            version = line.split("=")[1].strip()
            version = version.strip('"')
            version = version.strip("'")
            continue

setuptools.setup(
	name = 'remote-sensing-processor',
	version = version,
	author = 'Mikhail Moskovchenko',
	author_email =<EMAIL_ADDRESS>	description = 'RSP is a tool for geospatial raster data processing',
	long_description = long_description,
	long_description_content_type = 'text/markdown',
	url = 'https://github.com/simonreise/remote-sensing-processor',
	project_urls = {
		'Bug Tracker': 'https://github.com/simonreise/remote-sensing-processor/issues',
        'Source': 'https://github.com/simonreise/remote-sensing-processor',
        'Documentation': 'https://remote-sensing-processor.readthedocs.io'
	},
	classifiers = [
		'Programming Language :: Python :: 3',
		'License :: OSI Approved :: GNU General Public License v3 (GPLv3)',
		'Operating System :: OS Independent',
		'Environment :: GPU :: NVIDIA CUDA',
		'Topic :: Scientific/Engineering :: GIS'
	],
    keywords = 'remote sensing, landsat, sentinel, gdal, rasterio',
	package_dir = {"": "src"},
    packages = setuptools.find_packages(where="src"),
    setup_requires = ['cython', 'numpy>=1.17'],
    install_requires = ['numpy>=1.17', 'h5py', 'torch>=1.10', 'torchvision>=0.10', 'lightning', 'tensorboard', 'transformers', 'timm', 'scikit-learn', 'scikit-image', 'rasterio', 'pyproj', 'geopandas'],
    python_requires = ">=3.8",
    include_package_data = True
)

meta.yaml for conda-build
{% set data = load_setup_py_data() %}

package:
  name: remote-sensing-processor
  version: {{ data.get('version') }}

source:
  path: ./..

requirements:
  build:
    - python {{ python }}
    - cython
    - numpy >=1.17
  host:
    - geopandas
    - h5py
    - lightning
    - numpy >=1.17
    - pip
    - pyproj
    - python {{ python }}
    - pytorch >=1.10
    - rasterio
    - scikit-image
    - scikit-learn
    - tensorboard
    - timm
    - torchvision
    - transformers
  run:
    - geopandas
    - h5py
    - lightning
    - numpy >=1.17
    - pyproj
    - python {{ python }}
    - pytorch >=1.10
    - rasterio
    - scikit-image
    - scikit-learn
    - tensorboard
    - timm
    - torchvision
    - transformers

build:
  noarch: python

test:
  imports:
    - remote_sensing_processor
    - remote_sensing_processor.common
    - remote_sensing_processor.imagery_types
    - remote_sensing_processor.indices
    - remote_sensing_processor.landsat
    - remote_sensing_processor.mosaic
    - remote_sensing_processor.segmentation
    - remote_sensing_processor.sentinel2
    - remote_sensing_processor.sentinel2.sen2cor
    - remote_sensing_processor.sentinel2.sentinel_postprocessing
    - remote_sensing_processor.sentinel2.superres
    - remote_sensing_processor.sentinel2.superres.weights
    - remote_sensing_processor.unzip

about:
  home: "https://github.com/simonreise/remote-sensing-processor"
  license: "GNU General Public v3 (GPLv3)"
  license_family: GPL3
  license_file:
  summary: "RSP is a tool for geospatial raster data processing"
  doc_url: "https://remote-sensing-processor.readthedocs.io"
  dev_url:

appveyor.yml
environment:
  matrix:
    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
      PYTHON: "3.8"
      PYTHONPATH: "C:\\Python38-x64"
      TOXENV: python3.8
    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
      PYTHON: "3.9"
      PYTHONPATH: "C:\\Python39-x64"
      TOXENV: python3.9
    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
      PYTHON: "3.10"
      PYTHONPATH: "C:\\Python310-x64"
      TOXENV: python3.10
    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
      PYTHON: "3.11"
      PYTHONPATH: "C:\\Python311-x64"
      TOXENV: python3.11
    - APPVEYOR_BUILD_WORKER_IMAGE: Ubuntu
      PYTHON: "3.8"
      TOXENV: python3.8
    - APPVEYOR_BUILD_WORKER_IMAGE: Ubuntu
      PYTHON: "3.9"
      TOXENV: python3.9
    - APPVEYOR_BUILD_WORKER_IMAGE: Ubuntu
      PYTHON: "3.10"
      TOXENV: python3.10
    - APPVEYOR_BUILD_WORKER_IMAGE: Ubuntu
      PYTHON: "3.11"
      TOXENV: python3.11
stack: python %PYTHON%

build: false

for:
-
  matrix:
    only:
      - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
        PYTHON: "3.8"
        PYTHONPATH: "C:\\Python38-x64"
        TOXENV: python3.8
  install:
    - "SET PATH=%PYTHONPATH%;%PYTHONPATH%\\Scripts;%PATH%"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2<IP_ADDRESS>/GDAL-3.6.2-cp38-cp38-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2<IP_ADDRESS>/rasterio-1.3.4-cp38-cp38-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2<IP_ADDRESS>/Fiona-1.8.22-cp38-cp38-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install tox"
  test_script:
    - "%PYTHONPATH%\\python.exe -m tox"

-
  matrix:
    only:
      - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
        PYTHON: "3.9"
        PYTHONPATH: "C:\\Python39-x64"
        TOXENV: python3.9

  install:
    - "SET PATH=%PYTHONPATH%;%PYTHONPATH%\\Scripts;%PATH%"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2023.4.22/GDAL-3.6.4-cp39-cp39-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2023.4.22/rasterio-1.3.6-cp39-cp39-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2023.4.22/Fiona-1.9.3-cp39-cp39-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install tox"
  test_script:
    - "%PYTHONPATH%\\python.exe -m tox"

-
  matrix:
    only:
      - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
        PYTHON: "3.10"
        PYTHONPATH: "C:\\Python310-x64"
        TOXENV: python3.10

  install:
    - "SET PATH=%PYTHONPATH%;%PYTHONPATH%\\Scripts;%PATH%"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2023.4.22/GDAL-3.6.4-cp310-cp310-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2023.4.22/rasterio-1.3.6-cp310-cp310-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2023.4.22/Fiona-1.9.3-cp310-cp310-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install tox"
  test_script:
    - "%PYTHONPATH%\\python.exe -m tox"

-
  matrix:
    only:
      - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
        PYTHON: "3.11"
        PYTHONPATH: "C:\\Python311-x64"
        TOXENV: python3.11

  install:
    - "SET PATH=%PYTHONPATH%;%PYTHONPATH%\\Scripts;%PATH%"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2023.4.22/GDAL-3.6.4-cp311-cp311-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2023.4.22/rasterio-1.3.6-cp311-cp311-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install https://github.com/cgohlke/geospatial-wheels/releases/download/v2023.4.22/Fiona-1.9.3-cp311-cp311-win_amd64.whl"
    - "%PYTHONPATH%\\python.exe -m pip install tox"
  test_script:
    - "%PYTHONPATH%\\python.exe -m tox"

-
  matrix:
    only:
      - APPVEYOR_BUILD_WORKER_IMAGE: Ubuntu
        PYTHON: "3.8"
        TOXENV: python3.8
  install:
    - sh: sudo add-apt-repository ppa:ubuntugis/ppa
    - sh: sudo apt-get update
    - sh: sudo apt-get -y install python-numpy gdal-bin libgdal-dev
    - sh: sudo apt-get -y install python3-pip
    - pip3 install tox
  test_script:
    - sh: python3 -m tox

-
  matrix:
    only:
      - APPVEYOR_BUILD_WORKER_IMAGE: Ubuntu
        PYTHON: "3.9"
        TOXENV: python3.9
  install:
    - sh: sudo add-apt-repository ppa:ubuntugis/ppa
    - sh: sudo apt-get update
    - sh: sudo apt-get -y install python-numpy gdal-bin libgdal-dev
    - sh: sudo apt-get -y install python3-pip
    - pip3 install tox
  test_script:
    - sh: python3 -m tox

-
  matrix:
    only:
      - APPVEYOR_BUILD_WORKER_IMAGE: Ubuntu
        PYTHON: "3.10"
        TOXENV: python3.10
  install:
    - sh: sudo add-apt-repository ppa:ubuntugis/ppa
    - sh: sudo apt-get update
    - sh: sudo apt-get -y install python-numpy gdal-bin libgdal-dev
    - sh: sudo apt-get -y install python3-pip
    - pip3 install tox
  test_script:
    - sh: python3 -m tox

-
  matrix:
    only:
      - APPVEYOR_BUILD_WORKER_IMAGE: Ubuntu
        PYTHON: "3.11"
        TOXENV: python3.11
  install:
    - sh: sudo add-apt-repository ppa:ubuntugis/ppa
    - sh: sudo apt-get update
    - sh: sudo apt-get -y install python-numpy gdal-bin libgdal-dev
    - sh: sudo apt-get -y install python3-pip
    - pip3 install tox
  test_script:
    - sh: python3 -m tox

More info
No response
cc @tchaton

From https://github.com/pydantic/pydantic/issues/6381, it seems that ModelMetaclass has been considered private and removed from public interface in Pydantic v2.

Seems to be fixed by #18022

I solved this issue by degrading pydantic using this command  pip install pydantic==1.10.11 --upgrade.

Thanks everyone. We are aware, the fix is in https://github.com/Lightning-AI/lightning/pull/18018 and 2.0.5 will be released very shortly. Downgrading the package is the immediate solution.

I believe the correct fix is here: https://github.com/Lightning-AI/lightning/pull/18030 @Borda This commit was missed in the 2.0.5 release.
@function2-llx The solution is to downgrade pydantic to < 2.0 until Lightning 2.0.6 is released.

@function2-llx, I've pinned pydantic<2.0 in the lightning=2.0.5 conda-forge package at https://github.com/conda-forge/lightning-feedstock/pull/8, maybe try installing again and see if it works for you.

And don't forget to uninstall pydantic_core
I just use pydantic==1.10.9

pip install lighting==2.0.7

pydantic==2.1.1 +lighting==2.0.7, while import lightning, got pydantic.errors.PydaydanticUserError
pydantic==1.10.11 +lighting==2.0.7, works well

pydantic==2.1.1 +lighting==2.0.7, while import lightning, got pydantic.errors.PydaydanticUserError

strange as we fixed 2626bf6d87d77e3330b0aa79af54c61bfa36c4f3 and released in 2.0.6

I'm also getting a pydantic.errors.PydanticUserError, see attached a traceback when I try to import lightning.

seems something strange with mlflow as the trace states
lightning -> mlflow -> pydantic

Facing the same issue. Maybe it's better to reopen this?

Another set of patches was landed on master in #18676

The problem with pydantic still persists. I installed autogluon v1.0 using conda and followed instructions on auto.gluon.ai homepage. the solution for me was
pip install lightning==2.0.9.post0
autogluon.timeseries needs lightning <2.1.
Installing pip install lightning==2.0.9.post0 will install the correct pydantic as well.


Update best-practices-agile-project-management.md

@vertify-swdev1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Support Rust using WinUI3+ProjectReunion

On top of the impl_inner branch, I am trying to build a sample that uses WinUI3+ProjectReunion. For that I have used the xaml_app and reunioncppdesktopsampleapp as a basis. My Application already partially works. I am able to generate bindings for the WinUI3 winmd files (which I extracted from the ProjectReuinion NuGet package) and then use these to implement Microsoft.UI.Xaml.Application and override OnLaunch (Really much like the xaml_app example). However the app crashes with an internal exception from WinUI3: Exception thrown at 0x00007FFD11A73B19 (KernelBase.dll) in winui3.exe: WinRT originate error - 0x80004005 : 'WinUI: Error creating an UWP Window. Creating an UWP window is not allowed.'.
The exception comes from a separate Thread (i.e. not the Main Rust thread and probably internally from within the WinUI3 implementation) with the following StackTrace:
KernelBase.dll!RaiseException()	Unknown
combase.dll!SendReport(HRESULT error, unsigned int cchMax, const wchar_t * message, unsigned short pSid, void * pExceptionObject, IUnknown *) Line 438	C++
combase.dll!RoOriginateError(HRESULT error, HSTRING__ * message) Line 590	C++
Microsoft.ui.xaml.dll!DirectUI::Window::Window(void)	Unknown
Microsoft.ui.xaml.dll!ctl::ComObject<class DirectUI::Window>::ComObject<class DirectUI::Window>(struct IInspectable *)	Unknown
Microsoft.ui.xaml.dll!DirectUI::Window::Create()	Unknown
Microsoft.ui.xaml.dll!DirectUI::DXamlCore::InitializeInstance()	Unknown
Microsoft.ui.xaml.dll!DirectUI::DXamlCore::InitializeImpl(enum InitializationType,bool)	Unknown
Microsoft.ui.xaml.dll!DirectUI::FrameworkView::Initialize()	Unknown
twinapi.appcore.dll!Windows::ApplicationModel::Core::CoreApplicationView::CreateAndInitializeFrameworkView()	Unknown
twinapi.appcore.dll!Windows::ApplicationModel::Core::CoreApplicationViewAgileContainer::InitializeView()	Unknown
twinapi.appcore.dll!<lambda>(void)()	Unknown
SHCore.dll!_WrapperThreadProc()	Unknown
kernel32.dll!BaseThreadInitThunk()	Unknown
ntdll.dll!RtlUserThreadStart()	Unknown

I have also compared my Application with the reunioncppdesktopsampleapp one written in C++ (from which I already use the Appxmanifest and other things) but I am unable to find any differences (except that the C++ one uses a single threaded apartment, which when used in Rust gives the following exception: Exception thrown at 0x00007FFD11A73B19 (KernelBase.dll) in winui3.exe: WinRT originate error - 0x8001010E : 'The Application Object must initially be accessed from the multi-thread apartment.'. 🤔).

Neither ProjectReunion nor WinUI officially support Rust at the moment so I'll just transfer this issue to the windows-rs repo in order to make the topic more searchable.

We're working on the windows-app crate to make it easier to use the Windows App SDK from Rust. This includes what was formerly known as Project Reunion and WinUI.

Close this issue as I don't believe there is any further actionable work here for the Windows crate. Ongoing support for the Windows App SDK (including WinUI) will come from the windows-app crate. I will of course continue to improve the underlying language support via issues like #81.


Feature Request: Share button on the new tab

I think a simple feature we can make to drive traffic to planet.com and downloads of the extension is to put a simple share button on the image. If we wanted to be fancy, we could potentially check if the user has twitter or facebook in their history, and, if present, display the facebook and/or twitter share there so we are not cluttering the UI with social channels they don't use.
User story is this:
As a user, when I see an image I like on a new tab with the Planet Chrome Extension, I want to be able to share it with my friends so they can see it as well.

We had this at some point.  Now it is gone.


Update style.php

check if caching is not enabled and empty style cache files only to keep kleeja log file for development needs instead of emptying all cache folder from cp.

Thanks for your contribution.
I added some comments, review them.

yes ok

this is faster and not delete kleeja log file

We can change delete_cache to ignore the log file.

i used delete_cache no more changes is needed

if we want to keep the log, we have to change functions.php

as you do this will delete kleeja log file

we realy need that because cachingis disabled in development mode
an developer need log file
what i did was more simple
keep them

kleeja log must not deleted only on development mode
not on general case like "index.html"

if you keep what i do first it is more easy ...

Change functions.php directly and add kleeja.log there to the exceptions array, and remove the exceptions and global thing from style and it will be ready.

no if then admin want to remove from cp he can not remove kleeja log
kleeja log can not exluded in general
only in caching disabled mode
do you understand me?

if you keep what i do first it will remove style cache without kleeja log in disabled mode
because disable caching using by developer


Handle OPENAI_KEY not set error in github_action_runner.py

User description
Fixes https://github.com/Codium-ai/pr-agent/issues/855

Type
bug_fix

Description

Improved error handling for the OPENAI_KEY environment variable in github_action_runner.py to allow the GitHub Action runner to proceed even if the OPENAI_KEY is not set. This change accommodates scenarios where users might be using models not provided by OpenAI.
Added informative logging to notify users when the OPENAI_KEY is not set, enhancing the user experience by clarifying the non-critical nature of this environment variable for certain use cases.

Changes walkthrough
Relevant filesError handling

github_action_runner.pyImproved Handling of Missing `OPENAI_KEY` Environment Variable

pr_agent/servers/github_action_runner.py
Modified the handling of the OPENAI_KEY environment variable to allow the GitHub Action runner to proceed without it being set.  Added a conditional check to set OPENAI.KEY only if OPENAI_KEY is present.  Added a message to inform the user when OPENAI_KEY is not set, indicating the possibility of using models not from OpenAI.

+5/-4

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

looks good


Webpack loops when running npm install -> npm run dev on /app

Webpack seems to never finish building the /app folder.

@thechrise - Chris, please could you help me with some details so that I can help you?

please describe the issue a bit more in detail
please copy the console output
please let me know your OS, Node and App Framework version

Thanks,
Dennis

I will reopen this issue upon your response with the requested details.

Hey @scriptPilot, sorry for the lack of clarification.
Creating a new app folder works, but trying to open the demo app doesn't. I just tried again this morning... I clone the repository, cd into the app folder, add the generic package.json file, npm install, and npm run dev. When I run dev, webpack starts building, and eventually, it'll say webpack build done, but then it'll output "webpack build process ongoing- please wait ..." again. It looks like there's a code-conformities.log, but it quickly deletes itself and starts the loop over. When I run "npm run reset-app", that works but results in the basic app.
I'm running on Mac OSX 10.12.4, NPM 3.10.10, Node 6.10.3, and app-framework 1.4.23.
Thanks for your help.

... I clone the repository ...
@thechrise - Please follow the documentation ... App Framework must be installed as a module:
https://github.com/scriptPilot/app-framework/blob/master/DOCUMENTATION.md#setup-your-project
Please let me know if you have still some trouble!
Regards


Docker Installation issue

I am using the latest version of Docker and Ubuntu 20.04.
I have installed the libreSBC Docker image and I have ran docker compose.
When I try and run the docker, I get this error.
root@sbc:~/libresbc/build/docker# docker run  hnimminh/libresbc
Traceback (most recent call last):
File "/opt/libresbc/liberator/main.py", line 13, in
from configuration import REDIS_HOST, REDIS_PORT, REDIS_PASSWORD, REDIS_DB, NODEID, HTTPCDR_ENDPOINTS, DISKCDR_ENABLE, CDRFNAME_INTERVAL, CDRFNAME_FMT
File "/opt/libresbc/liberator/configuration.py", line 103, in
NODEID_CHANNEL = f'{NODEID.upper()}_CHANNEL'
AttributeError: 'NoneType' object has no attribute 'upper'
I cannot seem to find where these files are located, as /opt does not contain a libresbc folder so I am unsure where it is getting these directories.

@spudgun1001  if you just get start to using libresbc or don't know how to setup libresbc with docker properly, please use docker-compose.yml

I have installed docker, I have put the docker-compose.yml file and ran the compose file.

I am encountered with this error. What have I missed?

I have installed docker, I have put the docker-compose.yml file and ran the compose file.

I am encountered with this error. What have I missed?

Figured it out, you need to extract the files into the container and then "docker compose up"


Added http wrapper over token method to login users by email+password

It`s small feature according to issue #2 .
Add wrapper over http method /token?grant_type=password only for simplifying user interaction api

@awalias , pls review it

I just need to check with the front end team that this is still required
thanks for implementing 👍

closing for now as no longer requirement


Make a form validation handler | handle form messages

A Javascript handler for form|fields messages.
As a developer, I have been several times, in the awkward position, needing  to implement custom code, that will co-operate with bs-form fields. So, many times I had the same thought. "What if bootstrap provided the base 'JS adapter' for its fields"
This PR tries to provide a Bootstrap component, that automatically handle browser validation messages, and in addition will give the opportunity to use custom, given feedback messages.
In advance, it contains JavaScript code, providing

on form component:

method  to clear these messages,
get FormData` (for ajax usage)
execute validation
access each formField instance
JS hook, through component configuration, where developers can use for Ajax submission (not provided by default) and/or attach any custom validation messages

per field methods:

clear appended feedbacks
append success | error | info  feedback messages

Needs:

[ ] Documentation
[ ] Tests
Feedback

Cons:
Adds a significant size as it  introduces two new classes :thinking:
Related #28414
close #28995
Preview : https://deploy-preview-34043--twbs-bootstrap.netlify.app/docs/5.1/forms/validation/#custom-styles

almost perfect. one annoying issue though: if the form field already has an aria-describedby to begin with (see for instance the "Username" control, which initially already references the element containing the "@" sign), then this is overwritten by the success or error message. instead, it should be concatenated (so that the aria-describedby shows what was there to begin with, a space, and the id of the error message) - see the server side static example later on.
also, not sure if this PR also touches on the tooltip case, but here the generated markup seems incorrect ... the actual valid/invalid tooltip sits outside of the
 that is referenced by the aria-describedby - so this references just an empty container, with the actual tooltip being a sibling of this.

After submitting with empty values, the username results in this structure

    Username

      @
      <input type="text" class="form-control" id="validationCustomUsername" aria-describedby="inputGroupPrepend" required="" data-bs-invalid="Please choose a username.">
Please choose a username.

note that this now gives both the  with the "@" and the invalid feedback
 the same id, which is invalid. and the end result is that the AT still only announces the latter.
what i meant above, which may not have been clear: the end result should be that the aria-describedby contains a reference to both the previous/existing value it had (pointing to the ) and to the validation
, as a space-separated value. so the end result should be something like

    Username

      @
      <input type="text" class="form-control" id="validationCustomUsername" aria-describedby="inputGroupPrepend validationCustomUsername-formTip" required="" data-bs-invalid="Please choose a username.">
Please choose a username.

also, the latest changes seem to have broken the tooltips case https://deploy-preview-34043--twbs-bootstrap.netlify.app/docs/5.0/forms/validation/#tooltips which now just show the browser default error handling rather than the custom tooltips

btw probably worth saying: it might look like i just come in here to point out what's wrong... but this is already a great way forward! if we can tweak these last few bits, it'll be wonderful to have validation properly addressed in BS.

btw probably worth saying: it might look like i just come in here to point out what's wrong... but this is already a great way forward! if we can tweak these last few bits, it'll be wonderful to have validation properly addressed in BS.

You are right on this. give me some minutes

note that this now gives both the  with the "@" and the invalid feedback  the same id, which is invalid. and the end result is that the AT still only announces the latter.

got it. Thanks

it's almost perfect now, thanks for indulging me there @GeoSot. the last aspect that would be good to address is potentially tricky.
if you try to submit an invalid/incomplete form, and you get the error messages...if you then go back and correct the errors, visually the error message disappears and the green success styling is shown. however, behind the scenes, the aria-describedby still points to the now hidden error message. and even if an error message is completely hidden using display:none, screen readers will still read/announce it when it's referenced by aria-describedby. this can then lead to confusing situation where the user corrects the form entry, it visually shows it's correct, but regardless it still announces the error.
i think the only way around this would be to watch for a change event on the form (or individual form controls themselves?), and then dynamically resetting aria-describedby to its initial value (e.g. in the case of "Username" only pointing to the @ container) / changing it to the success message id if present (and in the case of "Username", this would then need to point to BOTH the @ and the success message if it had one ... for this reason, will be good to keep a reference right at the start to whatever the aria-describedby value was before validation as well.)

i.e. after validation once the user does go back and edit, currently it visually then shows this

and the markup for that username input is
<input type="text" class="form-control" id="validationCustomUsername" aria-describedby="inputGroupPrepend validationCustomUsername-formTip" required="" data-bs-invalid="Please choose a username.">

i.e. note that aria-describedby now still points to inputGroupPrepend validationCustomUsername-formTip when it should just point to inputGroupPrepend

last outstanding aspect, if possible, is removing the reference to the error message in aria-describedby once a previously invalid field becomes valid (either right away when the user fulfills the validation requirement, or at least when they try to resubmit and the validation run happens again).
i.e. currently, even after filling in a previously empty field, and the field now not being valid, the error message is still associated/announced ... and with aria-describedby, even if the target referenced is display:none, it's still announced. see this animation (with NVDA speech viewer), and note that after filling in the "City" and then moving away and returning, it still announces as "City - please provide a valid city".

getting there :)
i see the aria-describedby is correctly updated if at first something was invalid, and you then go in to make it valid. great stuff.
however, doing multiple erroneous submissions results in error messages being multiplied...

in the case of the tooltip variant, visually there's only one tooltip, but the aria-describedby balloons out with multiple references...as a result, AT will announce the referenced tooltip multiple times too

lastly, in the "supported elements" case, the initial errors aren't associated with the form fields. and editing the form to then be valid, some of the errors remain visible (but still not announced) https://deploy-preview-34043--twbs-bootstrap.netlify.app/docs/5.0/forms/validation/#supported-elements

thank you @patrickhlauke :)
I was aware of duplicated feedback elements, but I wasn't sure how to solve it. Although, I think I have found a valid solution.

lastly, in the "supported elements" case

I didn't change something there (at least yet), as it is a fixed example that shows the classes usage. (it works the same way on our published docs)

In order to do our checks, the only changed sections are

Forms:

Custom styles
Tooltips

Examples:

Checkout
Checkout RTL

When we finish the basic tests, we can see more on documentation area, and js-code needs to be discussed|optimized with the help of the js team

I was aware of duplicated feedback elements, but I wasn't sure how to solve it. Although, I think I have found a valid solution.

conceptually, it likely needs to do a check of "if the relevant error is already shown/the aria-describedby already contains the reference, do nothing, otherwise show the error/add the reference to the aria-describedby".

I didn't change something there (at least yet), as it is a fixed example that shows the classes usage. (it works the same way on our published docs)

we probably need to make those dynamic as well (starting off with an already present error, but then following the same JS logic that removes any reference/hides the error message/etc once user interacts with it)

added a commit that normalises all ids used in the various form examples, and adds the relevant aria-describedby etc to the static examples, as a first step

i see the issue of multiple errors appearing when hitting submit multiple times has now been fixed. great stuff.
out of interest, how easy/hard would it be to hook up the validation script to https://deploy-preview-34043--twbs-bootstrap.netlify.app/docs/5.0/forms/validation/#supported-elements as well? as currently the CSS changes kick in (partially) and it leaves this in weird semi-states...

one other oddity i spotted (but likely no easy way around it) is that for the checkbox example, the generated error comes straight after the input, so ends up before the label

conceptually, it likely needs to do a check of "if the relevant error is already shown/the aria-describedby already contains the reference, do nothing, otherwise show the error/add the reference to the aria-describedby".

done

we probably need to make those dynamic as well (starting off with an already present error, but then following the same JS logic that removes any reference/hides the error message/etc once user interacts with it)

I think it will be a bit more interventional, than it should

out of interest, how easy/hard would it be to hook up the validation script to https://deploy-preview-34043--twbs-bootstrap.netlify.app/docs/5.0/forms/validation/#supported-elements as well? as currently the CSS changes kick in (partially) and it leaves this in weird semi-states...

It can be done, but  it is considerable better to make .is-valid & is-invalid to have more weight than pseudo-classes, as they are used as overrides

one other oddity i spotted (but likely no easy way around it) is that for the checkbox example, the generated error comes straight after the input, so ends up before the label

done

It can be done, but it is considerable better to make .is-valid & is-invalid to have more weight than pseudo-classes, as they are used as overrides

but without JS to remove the aria-describedby the error messages will still be announced even when display:none'd ... which is what led us down this path of using JS in the first place

Just for my own sanity (as I had lost track of where we were at with this), made a quick recording using Chrome/NVDA of how this all currently shakes out
https://user-images.githubusercontent.com/895831/169644477-cf5fc958-e5d9-4b62-8755-8b17e37b0efd.mp4

0:00 - 0:42 Custom styles: work great/as I'd expect/want them
0:42 - 1:27 Browser styles: work as expected by browser (with Chrome popping up the validation bubbles one at a time as you submit)
1:27 - 1:59 Server side: notice that only the errors are tied to the form fields. for consistency, probably makes sense to also tie the "Looks good" text to the form control, the same way that error messages are
1:59 - 2:18 Supported elements: no association between validation messages and their form fields - wonder if we can either automate this/run the script over it, or if we just manually add the aria-describedby here?
2:18 - 3:00 Tooltips: work as expected

@patrickhlauke for start, I want to really thank you for your patience and your help.
I saw the review above and :

1:27 - 1:59 Server side: notice that only the errors are tied to the form fields. for consistency, probably makes sense to also tie the "Looks good" text to the form control, the same way that error messages are

seems to be an issue of docs, because we are just indicating the proper markup in case of server validation, fixed in: 07240fedb72eadf739f94f6df59ee40081a3329d

1:59 - 2:18 Supported elements: no association between validation messages and their form fields - wonder if we can either automate this/run the script over it, or if we just manually add the aria-describedby here?

seems to be an issue of docs, which I handled, adding the aria-describedby attribute manually (we cannot use the js script as the submit btn is disabled ), fixed in: 07240fedb72eadf739f94f6df59ee40081a3329d

snuck in a tweak to the documentation text itself...

@GeoSot you'll probably also want to add a bullet point to the "how it works" section, to mention the extra scripting that ties the form control to its feedback/error message when it appears. just draft it up, happy to give it a read/tweak once there https://deploy-preview-34043--twbs-bootstrap.netlify.app/docs/5.2/forms/validation/#how-it-works

Thank you @patrickhlauke 🙂
I have it in my mind too, but I am holding myself, till I get some feedback from other @twbs/team members (or contributors), concerning the usefulness of this idea, and opinions over the JavaScript code.
(Just to minimize the process steps and avoid going back and forth on file changing)


Focusing dates should not change the value

Description
Currently <vaadin-date-picker> isn't aligned in keyboard a11y with native input[type="date"]. Focusing the date changes the value:

The conversation from Slack (click to expand)
Jouni Koivuviita [1 hour ago]
But in combo box and date picker the new value is already visible in the field when focusing new values, which doesn’t happen for dropdown-menu (or native select)

Vladimir Kovtun [1 hour ago]
> in date picker the new value is already visible in the field when focusing new values

Me again with the "unique" word :slightly_smiling_face: This behavior is unique, isn't it? If so, would it make sense to reconsider it and to align with the rest of the world (both native and custom solutions)? (edited)

Vladimir Kovtun [1 hour ago]
As a disabled person, I most probably do not expect any inconsistencies in keyboard navigation between native `input[type="date"]` and custom solutions. (edited)

Jouni Koivuviita [20 minutes ago]
Our date picker behaves more like a combo box, so it’s aligned with that. You type something and it “filters/focuses” a matching date. (edited)

Jouni Koivuviita [14 minutes ago]
I’ve been wanting to redesign the date picker for a long time already. If we get time for that from the maintenance budget, we can reconsider the keyboard navigation at the same time.

Expected outcome
vaadin-date-picker is aligned with the native input[type="date"], focusing dates doesn't change the value:

Actual outcome
vaadin-date-picker is not aligned with the native input[type="date"].

vaadin-date-picker is not aligned with the native input[type="date"].

That is only true for Chrome/Opera. There’s no standard for how a browser should implement the date type input. Firefox behaves differently, and is closer to vaadin-date-picker.

Firefox behaves differently, and is closer to vaadin-date-picker.

Well, Firefox behaves completely differently. There's no way to trigger the popup with a calendar from a keyboard.
Here's the list of custom accessible implementations: http://www.webaxe.org/accessible-date-pickers/


Component was still attached to body instead of element from attachTo

Subject of the issue
I don't know if what I'm doing is right but I am expecting the component to be attached in a div with an id of app but it's working as expected.
I provided a codesandbox to replicate my issue.
Steps to reproduce
Run the test.
Expected behaviour
The two logs of innerHTML of the body should have a parent of div with an id of app.
Actual behaviour
It attached the component on the directly in the body.
Possible Solution
What are the alternative solutions? Please describe what else you have considered?

I don't know why the wrapper div document was getting removed just before mounting the component.
I found that createElement  works just fine but if do that outside mount or before $mount, it will not work.
Now, the tests made on #1492 were passing because it didn't check whether it was really attached on the div wrapper. It was just checking if the root is null but I don't think it's the right behavior. Correct me if I'm wrong.

Not conforming to issue guidelines


Cannot run trinity
(venv) ➜  py-evm git:(py-evm-1466) ✗ trinity
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 659, in _build_master
    ws.require(__requires__)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 967, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 858, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (rlp 0.6.0 (/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages), Requirement.parse('rlp<2.0.0,>=1.0.3'), {'py-evm'})

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.6/bin/trinity", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3017, in <module>
    @_call_aside
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3003, in _call_aside
    f(*args, **kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3030, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 661, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 674, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/pkg_resources/__init__.py", line 853, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'cryptography<3.0.0,>=2.0.3' distribution was not found and is required by py-evm

py-evm Version: master

What's git describe --tags give? trinity-v0.1.0-alpha.16-194-g1f60fd85?

@veox I'm getting this v0.2.0-alpha.17-1005-g1f60fd85

Same commit on my Arch Linux box, using Python 3.7.0 and pip 18.0, and I'm not getting this error.
Suggests the issue either being Mac-specific, or your particular setup.
The exception message looks like it's trying to use some other environment. Do you have rlp==0.6.0 installed anywhere else, e.g. system-wide or for the user?..
Have you tried upgrading the packages in the virtual environment?
Have you tried a "clean room" install, i.e. re-creating the venv from scratch?

Do pip freeze outside of the venv and I found that somehow there's py-evm installed. I did pip uninstall py-evm and now trinity works ok
Wasn't to sure when / why I did pip install py-evm though


Update UI to expose new version-specific support level data

Following the completion of #5, the UI we output to GH Pages will need to expose the new version support information in some way.

We may also want to build in a CLI interface to cow to manage the supported module metadata...

Not applicable


[Feature] [SWCK] Add Instrument CRD to config and operate instruments.

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
To config agents, upgrade agents, enable/disable plugins globally(or by batch) are common senarios for operation engineer. The default configmap can not meet all the requirements. To define a CRD for instruments and let the skwaylking operator inject instruments by CRs, may solve these problems.
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for this proposal. There are some tips for you.
The CRD should contain the following configuration:

The sidecar configuration. As you said, the user can create a sidecar template to upgrade the agent.
The annotation configuration.  Users can create an annotation template.
The labelselector to define which target object should be updated, like deployment/statefulset etc.

The Controller should do the following things:

When the user creates/updates a CR, the controller can get the target object with the labelselector of the CR and inject the annotation to the target object.

Hi @dashanji,
I looked into the implements of SWCK, and saw the javaagent CRD is already exists. The javaagent CR is created by javaagent-controller when pods get annotations with "sidecar.skywalking.apache.org/succeed=true". It looks like the javaagent CR is a copy of agent configs.
If a controller was created to watch the change of javaagent CR and update target pod when CR changed. Then there will be two agent configs going their own block of code to operate agent injection/removal. And it will be diffecult to maintain the code in the future.
Besides, the annotation configs is pod specific, while the javaagent CR config could effect a batch of pods. And what more is that the pods have it's own Skywalking env configs. There are multi way for uses to config the agent.
For these two problems, I got some points to workaround.

to avoid increasing the difficulty of code maintainance, there should be a common method to do the agent injection/removal. Actually, I think there only two place who would invoke the common method: pod webhook handler and agent CR reconciler.
to solve the multi way of configs problem. we should define the override precedence for CR configs, annotations configs, pod env configs. And finally, the configs should be composed by override precedence into a patch to update the pod. (the precedence of default configmap is defined in skywalking, so it can not be change it in SWCK. )
The common method use the composed configs as its input.

what do you think about this?

And here are questions to be clarified:

extend JavaAgent CRD or create new one? and the same question for controller.
where and when to operate agent injection/removal?
(should be webhook handler and controller reconciler. webhook for annotation change, controller reconciler for agent CR change. i don't kown if there are any other situation to be operate?)
how many ways can user config agents? and the precedence?
(CR configs, annotation configs, pod env. i don't know if there are any other ways to config.)

FYI @hanahmily PTAL

Hi @dashanji,
I looked into the implements of SWCK, and saw the javaagent CRD is already exists. The javaagent CR is created by javaagent-controller when pods get annotations with "sidecar.skywalking.apache.org/succeed=true". It looks like the javaagent CR is a copy of agent configs.
If a controller was created to watch the change of javaagent CR and update target pod when CR changed. Then there will be two agent configs going their own block of code to operate agent injection/removal. And it will be diffecult to maintain the code in the future.
Besides, the annotation configs is pod specific, while the javaagent CR config could effect a batch of pods. And what more is that the pods have it's own Skywalking env configs. There are multi way for uses to config the agent.
For these two problems, I got some points to workaround.

to avoid increasing the difficulty of code maintainance, there should be a common method to do the agent injection/removal. Actually, I think there are only two places who would invoke the common method: pod webhook handler and agent CR reconciler.
to solve the multi way of configs problem. we should define the override precedence for CR configs, annotations configs, pod env configs. And finally, the configs should be composed by override precedence into a patch to update the pod. (the precedence of default configmap is defined in skywalking, so it can not be change it in SWCK. )
The common method use the composed configs as its input.

what do you think about this?

In my mind, because we have defined the precedence order to configure the agent,  the Javaagent CR is created for
observing the final injected agent configuration. It is not a CR for configuration.
Yep, your points are right, now the java agent injector is a pod webhook handler, so I think the agent CR reconciler is better. To keep the code compatible and make it easy to code, I recommend defining a precedence order like Agent Configuration CR > Annotations > Configmap > Default configmap.

And here are questions to be clarified:

extend JavaAgent CRD or create new one? and the same question for controller.
where and when to operate agent injection/removal?
(should be webhook handler and controller reconciler. webhook for annotation change, controller reconciler for agent CR change. i don't kown if there are any other situation to be operate?)
how many ways can user config agents? and the precedence?
(CR configs, annotation configs, pod env. i don't know if there are any other ways to config.)

Creating a new CR is good for me.
I think a simple Controller can solve the problem.
Currently, the annotation,  Configmap, Default configmap is our recommended method used to set the final injected configmap, and the pod env can work too. If the user set pod env, the precedence order should be Env > Annotations > Configmap > Default configmap.

Is a new CR and/or operator breaking anything deployed? We should consider forward compatibility as we are in 4.x iteration, which means no breakin change.

I think there is no breaking change, as the new CR could be considered as a Set of annotation.

From deployment, breaking doesn't have to mean conflicting, such as whether legacy configs would be ignored? This should be considered a breaking change for an operator.

@wu-sheng @dashanji, from our discussion, i got the idea. we can create a new CR and operator. CR have the same annotations as pod level annotation for agents. And add label selector and pod selector attribute in CR, so that CR operator can inject the correct batch of pods.
finally the CR may looks like:
apiVersion: skywalking.apache.org/v1
kind: SwAgent
metadata:
  annotations:
    sidecar.skywalking.apache.org/initcontainer.Image: "apache/skywalking-java-agent:8.8.0-java8"
    sidecar.skywalking.apache.org/configmapVolume.ConfigMap.Name: "skywalking-swck-java-agent-configmap"
    ...
    agent.skywalking.apache.org/logging.level: "DEBUG"
    agent.skywalking.apache.org/logging.output: "CONSOLE"
    ...
  name: skywalking-agent
  namespace: skywalking
spec:
  objectSelector:
    skywalking.apache.org/java-inject: true
    skywalking.apache.org/java-inject-batch: "batch1"
  podMatching: "*" (regular expression)

From deployment, breaking doesn't have to mean conflicting, such as whether legacy configs would be ignored? This should be considered a breaking change for an operator.

In my mind, the feature is to provide a new way to configure the agent for the targeted object, and will not affect the original configuration.
When users configure the agent in this way, they need to follow a precedence order such as Agent Configuration CR > Annotations > Configmap > Default configmap. If users don't need to configure the batch of applications, the original configuration is enough, so they don't need to create a new Agent Configuration CR.

@wu-sheng @dashanji, from our discussion, i got the idea. we can create a new CR and operator. CR have the same annotations as pod level annotation for agents. And add label selector and pod selector attribute in CR, so that CR operator can inject the correct batch of pods.
finally the CR may looks like:
apiVersion: skywalking.apache.org/v1
kind: SwAgent
metadata:
  annotations:
    sidecar.skywalking.apache.org/initcontainer.Image: "apache/skywalking-java-agent:8.8.0-java8"
    sidecar.skywalking.apache.org/configmapVolume.ConfigMap.Name: "skywalking-swck-java-agent-configmap"
    ...
    agent.skywalking.apache.org/logging.level: "DEBUG"
    agent.skywalking.apache.org/logging.output: "CONSOLE"
    ...
  name: skywalking-agent
  namespace: skywalking
spec:
  objectSelector:
    skywalking.apache.org/java-inject: true
    skywalking.apache.org/java-inject-batch: "batch1"
  containerMatcher: "*" (regular expression)

Overall, the CR is good for me.
What do you think about moving the annotation to the Spec field? In this way, we can validate whether the annotation key is right.

How about removing the config map to embrace the CRD? We could simplify the code base by supporting a single configuration system. That will bring some benefits like:

If users want to set up a batch or all agents, they could set up a CR.
If users have to debug a deployment, they could leverage annotation to override some items defined in CR.

The controller onboarding will create a default CR. Users have a chance to modify it later. And the most critical is to determine the precedence between CRs once they match the same agents.

Agree!  Configuration through CR is indeed clearer than configmap. However, the current agent configuration is mounted through configmap.  We can use CR to manage the original configmap configuration, which makes the agent configuration clear.

@dashanji, When moving the annotation to CR spec, its not a good way to hardcode the mapping from CR spec fields to skywalking app env keys. Because the app level env keys might be added or removed in any version update, it may cause many compatibility problem. what do you think about to move to a flexible fields like map, kv list, etc. Actually I am working on a version of it.
Agree with @hanahmily +1, CR is more earily to be used, and with CR, it's more flexible for us to control injection behaviour when configs changed.

One another, the current swck doesn't work for optional plugins properly. The plugin.mount is being used, but only set for default values, then it works for nothing.
swck should create a new folder (activated-plugins) for activated optional plugins, and set it to plugin.mount
Such as plugin.mount=plugins,activations,activated-plugins

Agree with @wu-sheng. Now is a good opportunity to configure the specific value of the optional plugin through a new CR.
@Duncan-tree-zhou There are two ways to debug SWCK operator locally.

You can refer the guide to disable the webhook then you can debug the controller locally.
If you find it hard to debug the webhook, you can refer the blog to deploy the SWCK and cert-manager in the kind cluster, then you could test your implementation.

Hi, here is the PR:
https://github.com/apache/skywalking-swck/pull/66
It looks like the PR in SWCK repo cannot be associated to this issue?
here are the changes:

add SwAgent CRD

inlcuding label selector and container matcher.
the sidecar configs variable is explicitly declared.
JavaSideCar.Env will be pass to target pods, in which way use can set agent configs.

update pod in SwAgent Reconcilor is not applicable, so nothing is done in SwAgent Reconciler
SwAgent CRD is take effect in admission webhook, the config precedence is overlay-annotations-config > swAgent-config > swAgent-default-config > overlay-default-config.
for batch updating agents in target pods, two steps to be execute:

add or update swAgent CR, and use the correct label selector
delete the pods with correct label selector, then k8s will rolling update pods to the corrects.


UI issues while restoring the wallet.

-When you touch them, they blink which makes it feel as though they are clickable but they are not.

-Should be Personal Device and should not touch the Let Received tag

Tested on Dev app v1.7.0 (286). As per the 2nd point, still showing secondary device instead of Personal device

-Verified this issue on Dev app v1.7.0 (289)


Another attempt to bump golang to v1.14.2

Based on the proposed changes from #1132

@mumoshu Could you check why the PR is not being built by CircleCI?
I set up a CircleCi project against my fork and the pipeline passed with the upgrade to 1.14 at https://app.circleci.com/pipelines/github/renehernandez/helmfile

@renehernandez sorry for the delay, I think I think I made the PR thru. If you dont mind, we can close this in favor of that one. :)


Set up unit tests

Unit tests for the components are both very important, and also a thing I have very little idea of how I'll go about it.
The main issue being that this crate depends on some npm packages (specifically, the @material/mdc-* component classes).  I'll have to figure out how to go about including such external dependencies in unit tests.

[x] Set up basic wasm testing
[ ] Figure out how to include JS dependencies
[ ] Set up Travis CI

Update: I just realized that while unit tests are hard to write here for little benefit, doctests are absolutely worth it; since yew component initialization is fully compile-time checked, writing one doc test per MDC component would at least ensure that it can be initialized as intended, and that would also help with #2 a lot (as the library is still really lacking there).


Selection Sort

Documentation on Selection Sort

Description 📜
Completed documentation of Selection Sort Algorithm
Fixes # <3298>

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] DSA

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

correct your syntax of writing issue number.


Update Notification never go away. Restart never bring the IDE back up

VSCode Version:
OS Version:
Mc OS Mojave 10.14.3
Steps to Reproduce:

Disable all the extension
Click on the Update Now button

Does this issue occur when all extensions are disabled?: Yes

/needsMoreInfo
What's your current version of VS Code?

Version: 1.38.0
Commit: 3db7e09f3b61f915d03bbfa58e258d6eee843f35
Date: 2019-09-03T21:47:00.464Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.2.0

Did you try this? https://github.com/microsoft/vscode/issues/7426#issuecomment-425093469

That's it! Thanks @joaomoreno


Slash command doesn't work correctly if difficulty is omitted

I think /puzzle lc will return a CW puzzle. /puzzle lc medium works though.

The parser should be redone, so this is irrelevant.


Fixes: pubspec description, universal file format

Codecov Report

Merging #13 (bf87018) into master (b1ae21a) will decrease coverage by 0.20%.
The diff coverage is 88.33%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   77.98%   77.77%   -0.21%
==========================================
  Files          14       14
  Lines         268      270       +2
==========================================
+ Hits          209      210       +1
- Misses         59       60       +1

Impacted Files
Coverage Δ

lib/src/domain/entities/response.dart
100.00% <ø> (ø)

lib/src/domain/usecases/fetch.dart
100.00% <ø> (ø)

...b/src/infra/repositories/http_repository_impl.dart
100.00% <ø> (ø)

lib/src/presenter/uno_base.dart
0.00% <0.00%> (ø)

lib/src/domain/dto/request.dart
88.23% <50.00%> (-5.52%)
:arrow_down:

lib/src/external/universal_http_client.dart
89.13% <90.00%> (ø)

lib/src/core/form_data/src/entry.dart
100.00% <100.00%> (ø)

lib/src/core/form_data/src/form_data.dart
100.00% <100.00%> (ø)

lib/src/core/form_data/src/result.dart
100.00% <100.00%> (ø)

lib/src/core/form_data/src/utils.dart
100.00% <100.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.