Restrict when try_reserve_2 is enabled

Ref: https://github.com/camino-rs/camino/pull/21#issuecomment-1212597255
If you decide this PR is too invasive, I won't be insulted if you close it without merging.

Thanks. This looks fine except it pulls in a couple extra dependencies. Can those dependencies be inlined?

(My concern is that those dependencies may have their own optional features—currently, camino is a zero-dep library.)

Apologies, one more change: could this just do "stable/beta 1.64 or later, nightly 1.65 or later"? That means we can avoid the date-parsing code.

Apologies, one more change: could this just do "stable/beta 1.64 or later, nightly 1.65 or later"? That means we can avoid the date-parsing code.

What do you think the CI toolchains should be in this case?

I'd just pick the nightly before the feature was stabilized (and add a comment to CI explaining this)

Thanks, going to land this and get a new version out after it passes CI.

Thanks for being so accommodating!


OmniSharp.exe virus on Bitdefender Antivirus for Mac

VSCode Version: Code 1.8.0 (38746938a4ab94f2f57d9e1309c51fd6fb37553d, 2016-12-13T17:38:28.425Z)
OS Version: Darwin x64 16.3.0
Extensions:

Extension
Author
Version

csharp
ms-vscode
1.6.2

Bitdefender Antivirus for Mac alerted me that..
"1/15/2560 BE, 5:24 PM
Gen:Variant.Barys.50536 deleted
/Users/1v5/.vscode/extensions/ms-vscode.csharp-1.6.2/bin/omnisharp/refs/OmniSharp.exe"

Is it really safe? Or it is just a false alarm?

This issue was moved to OmniSharp/omnisharp-vscode#1127


Add feature flag

Add PREDICATES_MULTIPLE_QUESTIONS_ENABLED feature flag for admin multi-question predicate UI, default to false.

Codecov Report

Merging #4000 (05338da) into main (b145e97) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4000      +/-   ##
============================================
- Coverage     80.05%   80.04%   -0.01%
  Complexity     2452     2452
============================================
  Files           298      298
  Lines          9796     9797       +1
  Branches        665      665
============================================
  Hits           7842     7842
- Misses         1698     1699       +1
  Partials        256      256

Impacted Files
Coverage Δ

server/app/featureflags/FeatureFlags.java
86.66% <0.00%> (-2.99%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Manhwaclub site

Source information
ManhwaClub 1.4.5
Source language
English
Source new URL
https://manhwaclub.net
Other details
No response
Acknowledgements

[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source URL has not changed yet.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I will fill out all of the requested information in this form.

Are you sure this is the new domain for ManhwaClub? The current domain (manhwa.club) redirects to another domain (manhwahentai.to) which exists as "Manhwa Hentai" in the English section.
This new domain (manhwaclub.net) also uses a different theme, which usually indicate that the site is unrelated.


Deploy to Polygon Mumbai testnet

First step to deploying to mainnet is deploying to public testnet.

Contracts deployed and frontend updated. d957f30093d57a0024a5acd6d4fe02ed39867288


Add oracle fallback

Is your feature request related to a problem? Please describe.
If a single price feed fails we may be unable to update the oracle before the parachain goes into an error state.
Describe the solution you'd like
We should add a configurable fallback to use a secondary API if we do not get a response from the primary API within some time bound.
Describe alternatives you've considered
With good monitoring we can catch when the oracle goes offline but since this may happen out-of-hours it is better to have the oracle client handle this automatically.

@greg Questions for the Issue:

Is it related to submitting the price feed to the blockchain or getting the price feed from the exchanges?
If it is the latter,

Will get_value_or_median always return the result "OK" since get_prices will return a result of "OK"? If not, would you like to switch to a secondary API endpoint if the primary API feed gives an error? You can find the relevant code here.

If it is the former,

Would you like to add a fallback btc_parachain_url in case the primary RPC endpoint is down?

Getting the price feed from the external endpoint
The code you linked will fail on the first error, at which point we should switch to a secondary API but actually now that I consider this it feels slightly over-engineered so I would be in favour of closing this actually - what do you think @sander2?
Not applicable, we control RPC endpoints and oracle should retry on disconnect

I'm no longer convinced this is necessary, we want to be very specific which price feed we use and I don't think it makes sense to switch to a backup. Besides, once https://github.com/interlay/interbtc/pull/1119 is merged the parachain will no longer enter an error state which I believe was the motivation for this feature request.


[Feat]Adding hover effect and animations in home page cards

Description
Idea is to add animation and hovering effect to the below section:
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[ ] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@Subashree-selvaraj As of now, we do not need it. We will let you know in the future if there is a need. Please search for another issue and raise it, which I'm happy to assign to you.


AI now uses the criminal console instead of the station console to view records.

About the PR

Makes the AI Station Records action instead be the Criminal Records console.
Why / Balance

The station records is useless and just an inferior version of the criminal records console. AI had essentially no use with it anyways. Now you can at least set criminals as wanted when sec asks you to without flying across the map.
Additionally when AI was using the sec console it would constantly get overwriten by whoever else was using it at the time in case several criminals had to be marked and it was annoying, though I guess a rare occurance.
Technical details

Made the CriminalRecordsConsole component networked.
Added a new action for AI to seperate aghost's station records and ai's criminal records. (Since Aghost is supposed to be able to delete the records, which AI couldnt do anyways)
Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

tweak: AI now uses a criminal console instead of the station records console.

why? Criminal records give you less information about the person than station records, and AI shouldn't really be setting criminals to wanted, that's the Wardens job

why? Criminal records give you less information about the person than station records, and AI shouldn't really be setting criminals to wanted, that's the Wardens job

Ive never seen the station records be used either way.
And security keeps yelling at AI to change wanted status anyways, might as well make it easier whenever possible.

why? Criminal records give you less information about the person than station records, and AI shouldn't really be setting criminals to wanted, that's the Wardens job

Robocop law set
AI is already perfectly capable of utilizing the criminal records terminals anyways, so this is more QoL than a new functionality/ai powercreep

You are correct though about station records havi no more info, I honestly think ai should have both and the ai player can pick and choose what terminals they want on hand with the actions menu
Other than that it is perfectly reasonable to give ai quick access without needing to scroll around looking for a terminal to jump into

As with the mindshield and wanted status vision, I don't really think it's a good idea to push the AI towards security-sided gameplay. Every tool that's given to them is an official "this is what you are expected to do for the station", so having a criminal records computer on demand will make AI players think this is what they should be doing

As with the mindshield and wanted status vision, I don't really think it's a good idea to push the AI towards security-sided gameplay. Every tool that's given to them is an official designation of "this is what you are expected to do for the station", so having a criminal records computer on demand will make AI players think this is what they should be doing

You see this is already a thing AI can do by simply flying across the map to security
this simply removes the fly across the map part and still serves essentially the same purpose
its not like letting AI see wanted status to report people instantly, simply means u dont gotta cross the map to do what you already could do
Besides borgs can see mindshield status im still confused why AI shouldnt

You see this is already a thing AI can do by simply flying across the map to security
this simply removes the fly across the map part and still serves essentially the same purpose

Is this really intended? I think AI being able to view criminal records is good, but changing them should be sec's job.

Besides borgs can see mindshield status im still confused why AI shouldnt

If Borgs see mind-shield/wanted status then that is a bug

If Borgs see mind-shield/wanted status then that is a bug

they do in fact see mindshields and ive never seen it be called a bug

If Borgs see mind-shield/wanted status then that is a bug

they do in fact see mindshields and ive never seen it be called a bug

This was supposed to be changed #26207, not that im against this pr but yes it is intended for Borgs to not see mind-shields or wanted status for the same reasons why AI can't

why? Criminal records give you less information about the person than station records, and AI shouldn't really be setting criminals to wanted, that's the Wardens job

Ive never seen the station records be used either way. And security keeps yelling at AI to change wanted status anyways, might as well make it easier whenever possible.

I use station records :(
And security really just needs to learn that that isn't the AI's job.

And security really just needs to learn that that isn't the AI's job.

"AI set x to wanted for y" seems like a perfectly reasonable request for an on-board station ai.  AIs job is whatever the crew deems its job to be.  Hell if someone asks for the AI to mark someone as wanted the AI literally cannot say no under Asimov laws due to law two.
So yes if someone tells the ai to mark someone as wanted it 100% is the ai's job.


Minimizing (repetitive) hallucinations and improving accuracy

Hello! This is a great repository, thank you very much @sanchit-gandhi!
We would like to use this repository in our system, but quite a few of our Word-Error Rate (WER) regression tests fail when used with the closest equivalent settings as compared to faster-whisper, as the backend for our transcription system. That is to the say, for the same model size and beam size and with (non-word-level) timestamps enabled, whisper-jax infers with a higher word-error rate for a significant proportion of our test files.
One of the main things that significantly affects WER, in my testing with longer English-only files, is repetitive hallucinations. It seems that oftentimes, whisper-jax will find itself in repetitive hallucination loops before eventually breaking out and inferring the next actual speech in the file.
I think that whisper-jax is missing a few features offered by faster-whisper that might be contributing to this disparity in WER, primarily (1) word-level timestamps and (2) voice-activity detection filtering (as in faster-whisper's implementation).
With all of the above in mind, I have a few questions regarding minimizing hallucinations and overall improving the accuracy of the inferences.

Do you have any suggestions for how to go about porting word-level timestamps to this repository? I would be willing to take a crack at it, but might need some guidance on porting the word timestamps algorithm from the HuggingFace whisper implementation. Related: #37
For the voice activity detection filtering, would that be an appropriate addition to this repository? We have already adapted faster-whisper's algorithm for VAD clipping audio, before submitting it to whisper-jax in our system. We can submit a PR to this repository to add the functionality, if it aligns with the goals of this repository. In our testing, we have found that the VAD filtering significantly reduces hallucinations caused by silence and/or non-speech sound or noise. (It also offers a nice speed-up for files with a lot of silence.)
Are there any other missing features or disparities that might be affecting Word-Error Rate that can be ported here?
Are there optimal settings for reducing repetitive hallucinations?
Is it possible to enable condition_on_previous_text=False with this repository?

Thank you again for this fantastic repository!

Hey @gl-jkeys! Glad to hear this has been a useful resource, and apologies for the late reply.

Word-level timestamps are possible through the dynamic time warping (DTW) algorithm, but first need to be ported from PyTorch to Flax: https://github.com/huggingface/transformers/blob/6af3ce7757e87e7e3380b0405bd0757805d41182/src/transformers/models/whisper/modeling_whisper.py#L2571-L2576
I think this should be quite straightforward since the DTW algorithm is written in numpy, so we'd just need to convert it all to jax.numpy (so as not to have a CPU operation in the modelling code, which would require a sync-point when we jit the forward pass)
Very cool! What's the VAD algorithm you've used? Is it based on just the outputs of Whisper? Or an additional model? The idea of this repository is that it's meant to be as streamlined as possible, so if it just relies on Whisper it could be a nice addition
You can try a lower chunk length, e.g. 25 seconds, since this sometimes help reduce hallucinations (especially when used with distilled models) https://github.com/sanchit-gandhi/whisper-jax/blob/9c50a6ee5f30f6429ad46dc748603296dfb3484b/whisper_jax/pipeline.py#L424

Hey @sanchit-gandhi, sorry for the extremely delayed response. I let it go over the holidays, and then forgot to come back to this message afterward. Apologies!
We decided not to use whisper-jax in our pipeline, largely because this repo is effectively archived. Thankfully, you released distil-whisper, and we are actively investigating dropping the distilled implementation into our pipeline! I respond point-by-point below, though, in case it helps anyone else who stumbles upon this repo and really wants to use TPUs.

Perfect, thanks.
We're using the exact same algorithm that faster-whisper uses, which relies on Silero VAD. It's an interesting idea to use a non-ensemble approach, or more specifically, use the same model to accomplish both tasks; I can't immediately think of how one would do that without doing two full inference passes, however. [Would you expect a slimmed down version of Whisper that does not infer the transcript to be significantly faster in the decoding phase?]
Thank you.
A data point: in our investigation of distil-whisper, we are using your recommended chunk length of 15s, and there are comparatively few hallucinations in that repo/implementation (using distil-medium.en).

Hey @sanchit-gandhi, sorry for the extremely delayed response. I let it go over the holidays, and then forgot to come back to this message afterward. Apologies!
We decided not to use whisper-jax in our pipeline, largely because this repo is effectively archived. Thankfully, you released distil-whisper, and we are actively investigating dropping the distilled implementation into our pipeline! I respond point-by-point below, though, in case it helps anyone else who stumbles upon this repo and really wants to use TPUs.

Perfect, thanks.
We're using the exact same algorithm that faster-whisper uses, which relies on Silero VAD. It's an interesting idea to use a non-ensemble approach, or more specifically, use the same model to accomplish both tasks; I can't immediately think of how one would do that without doing two full inference passes, however. [Would you expect a slimmed down version of Whisper that does not infer the transcript to be significantly faster in the decoding phase?]
Thank you.
A data point: in our investigation of distil-whisper, we are using your recommended chunk length of 15s, and there are comparatively few hallucinations in that repo/implementation (using distil-medium.en).

Did you do 1? If so, could you share how specifically? I'm new to AI and I'm struggling with this approach. I need better timestamps to ensure appropiate subtitles. And what about 3? Any advice or help?
Thanks for your post, and I hope we can continue improving this kind of archived model! I think is necessary.


⚠ Bofrost.at has degraded performance

In 924fb3f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1413 ms

Resolved: Bofrost.at performance has improved in c73cd58.


Module System

We want a module system for Effekt. At first we should focus on a simple and clear basis on which we then build interesting extensions.
Properties
Some features we might want are:

A "hello effekt" project should "just work". No configuration required.
It should be possible to define modules locally, in a file, and then gradually move parts to different files.
Separate compilation should be possible

Idea
We look at namespaces in Flix and objects as modules in Scala for inspiration.
We already have interfaces so a first step would be to make the following work:
interface A {
  def f(): Unit
}

def A = new A {
  def f() = ()
}

def main() = {
  A.f()
}

The second step is to introduce sugar for the above:
module A {
  def f(): Unit = ()
}

def main() = {
  A.f()
}

We add syntactic sugar with keyword module. It introduces the same name on the type level and on the term level.
Nested modules
As a next step we make the following work:
interface B {
  def f(): Unit
}

interface A {
  def B : B
}

def A = new A {
  def B = new B {
    def f() = ()
  }
}

def main() = {
  A.B.f()
}

As a final step we make the module sugar work within modules.
Interaction with Files
Files are completely orthogonal to modules. There is a keyword include that copy-pastes the content of the given file at this position. Each file with a certain path is only copied once. The order is topologically sorted.
Opening modules
Unsupported
Type members
Also see #68.
Consider:
module Http {
  type Request { Get(url: String)  }
  def send(r: Request): Unit = ...
}

def getExample(): Http.Request = Http.Get("example.com")

def main() = Http.send(getExample())

Could this be sugar for:
interface Http[R] {
  def send(r: R): Unit
}

type Request { Get(url: String) }

def Http = new Http[Request] {
  def send(r: Request): Unit = ...
}

def getExample(): Request = Get("example.com")

def main() = Http.send(getExample())

Does this always work?

WIP see branch feature/modules

Most use cases are covered by #388, but we still need to reconsider the design objects / classes etc.


Rubyinstaller (Windows) does not install enough root certs for kramdown-rfc to run

Reported by Michel Veillette.
Rough workaround:
$ wget http://curl.haxx.se/ca/cacert.pem
$ cp cacert.pem /c/Ruby193/
$ export SSL_CERT_FILE=/c/Ruby193/cacert.pem

(These are cygwin commands, to be translated to CMD.EXE commands.)

In 1.0.39, I have institutionalized a workaround:
Set the environment variable KRAMDOWN_DONT_VERIFY_HTTPS to any value and the certificates for the bibxml sources are no longer being verified.
I would rather fix this properly, but I can't really deliver kramdown-rfc with its own cert root store (or should I?), and the ones found on various installations are broken in ever more surprising ways.
(Another workaround is to use the web service version of kramdown-rfc at https://xml2rfc.tools.ietf.org/experimental — scroll down to bottom of page.)


Correction for raw affiliation Department of Psychology, Western University.

Correction needed for raw affiliation Department of Psychology, Western University.
raw_affiliation_name: Department of Psychology, Western University.
new_rors: 02grkyz14
previous_rors: 02agqkc58
works_examples: W4361279043;W4321376816;W4388193897;W4388734565;W4317358871;W4386027195;W4323075331;W4377014268;W4387579313;W4387820405;W4389743227;W4390029901
contact: 629a97fd5989bf1255d3c597c5108ce0:a8aeec8361163710 @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


add type annotation to public member

+validate will test against all Scala platform/version permutations.

@milessabin Executing validate in sbt shell cause linking errors.
How can I avoid these errors?
[info] Fast optimizing /Users/moriyamakazuki/development/Scala/shapeless/core/js/target/scala-2.13/shapeless-test-fastopt.js
[error] Referring to non-existent class shapeless.HListTests$Fruit
[error]   called from shapeless.HListTests$scalajs$junit$bootstrapper$.newInstance()java.lang.Object
[error]   called from private org.scalajs.junit.JUnitTask.$anonfun$executeTestMethod$2(org.scalajs.junit.Bootstrapper)java.lang.Object
[error]   called from private org.scalajs.junit.JUnitTask.$anonfun$executeTestMethod$1(org.scalajs.junit.Bootstrapper)scala.util.Try
[error]   called from private org.scalajs.junit.JUnitTask.executeTestMethod(org.scalajs.junit.Bootstrapper,org.scalajs.junit.TestMetadata,org.scalajs.junit.Reporter)scala.concurrent.Future
...
[error] There were linking errors
[error] (coreJS / Test / fastOptJS) There were linking errors

To fix this errors I delete core/js/target directory and recompile, but it doesn't work.

+validate should complete successfully ... what platform are you on?
One thing to try: make sure you've committed your changes and then git clean -dxf.

I develop on the mac os.

One thing to try: make sure you've committed your changes and then git clean -dxf.

Thank you for the advise, but it didn't work.
In the first place, should I execute sbt +vlaidate not sbt validate?
If so sbt +validate resulted in below, and is it the ideal behaivor?
sbt:shapeless> +validate
[warn] Issuing a cross building command, but not all sub projects have the same cross build configuration. This could result in subprojects cross building against Scala versions that they are not compatible with. Try issuing cross building command with tasks instead, since sbt will be able to ensure that cross building is only done using configured project and Scala version combinations that are configured.
[info] Reapplying settings...
[info] Set current project to shapeless (in build file:mypath/shapeless/)

The errors I described above are occurred when I execute sbt valdiate.
sbt validate command tested against jvm, native and js, and was successful in jvm and native.
The errors for the js, do I have to succeed in js on local machine?

I also get the errors on Mac. I think it has to do with case sensitivity of the file system.

Maybe it is this bug: scala/bug#11997

@kazchimo sorry I forgot to ask in your other PR, would you mind adding yourself to the contributors list?

@joroKr21 yes, i'd love it.

@milessabin I could resolve above error on #1029 thanks to information @joroKr21 gave. This PR seems to have no more issue.

Oh I was waiting for you to add yourself to the contributors list in the README.
Could you also squash your commits into one?

@joroKr21 sorry, I've misunderstood your words.
@milessabin @joroKr21
I squashed commits and edit contributors info.
Thanks for your help!


String type required validator

Hi,
I am wondering why the JSONEditor doesn't support required validator type? From what I can see there is support for minLength, maxLength etc.
Regards

Do you have an example schema?  I'm not sure exactly what you're referring to.

Sure,
Here is an example schema:
{
  "type": "object",
  "properties": {
    "id": {
      "required": true,
      "type": "string"
    },
    "description": {
      "required": true,
      "type": "string"
    }
  }
}

The required attribute in JSON Schema means the object property must exist. It doesn't say anything about the property value. This differs from the HTML5 required attribute which means the value cannot be empty.
If you want to force a non-empty value, set minLength to 1.


Added Padding option

https://refreshless.com/nouislider/slider-options/#section-padding

I'd like to have this available as padding is not currently supported. Hey @kennethkalmer is there something else missing we can help with?
Thanks in advance.

I needed this option as well so I have a branch in my fork with both this PR and #68 here if it helps

@kennethkalmer Would be great to get this one merged. I am now using it in production and it works exactly as expected. The documentation/example that @sonnyt put together is top-notch as well. :+1:

@kennethkalmer Possible to get this merged and released?
I'm happy to help out with this project if you're too busy or no longer using it. :)

Thanks @sonnyt for the contribution, and my sincere apologies that this took so long to land. I'm preparing a new release.


JS Fiddle example for setPriceGranularity throws JavaScript exception

This is the link to the JSFiddle: http://jsfiddle.net/prebid/bp9magow/86/?utm_source=website&utm_medium=embed&utm_campaign=bp9magow
and here is the offending line:
//set custom config object
pbjs.setPriceGranularity(customConfigObject);

Thanks @risenhoover this should be addressed by 7acbe69


vesktop: 0.4.4 -> 1.5.0

Description of changes
Release notes: https://github.com/Vencord/Vesktop/releases/tag/v1.5.0
Diff: https://github.com/Vencord/Vesktop/compare/v0.4.3...v1.5.0
Also enables downloading darwin-specific dependencies in pnpmDeps to avoid updating the hash if/when we support it
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This is a duplicate of #281256

oops! sorry about that


Add vite example

Because examples are built in CI, this means we at least don’t break building with vite.

we need to use es2020 or something for the big ints in vite...

Yes I see. It’s unfortunate it doesn’t just work for Vite. :(

I’m going to merge this, because I’d like to update dependencies and wish to avoid merge conflicts with this branch.

Sure ;) Just didn't find the time to test this locally 😄


only allow approving schema checks without composition errors

Today, users can approve schema checks that have composition errors. However, it does not make sense to approve schema checks with composition errors as it would result in a breaking publish when pushed to production.

Just noticed that this already is the case today.


Some render issue

Folks, not sure how precisely explain -
During initial rendering of message history, render happens pretty well:
<Conversation turnOffLoop messages={msgs}/>;
But when msgs object gets updated (say, new element added to it), rendering does not seems happening - I see only old messages.
Vitaliy

Hi @vvinton
Thank you for opening up this issue!
I'll add the ability to add a new message after the messages have loaded later today.
Thanks,
Paul

hi Paul - what I observed additionally - when the next time component created (i.e. Conversation) - new message pops up. In other word - with now:
<Conversation turnOffLoop messages={msgs}/>; - loads history
if to create (in on render method component again) as:
<Conversation turnOffLoop messages={newSingleMessage}/>; - it will be appropriatelly added to history - in other words previous and new message will appear.

HI @vvinton
Sorry, I've been busy the last few days so I haven't had a chance to fix/look at this issue.
Can you please create a working code example for the original issue and the issue above?
In your example above does it go through msgs and display the animation for it and then do you: Change the messages parameter to a different object called newSingleMessage that contains only one message and that plays the animation to add it to the chat with the history still there?
OR
Are you adding newSingleMessage to the original msgs object and it is adding it to the chat successfully?
I'll have a look at this tonight.
Thanks,
Paul

Apologies that it took me over a week to deliver the fix for this. I wasn't able to work on this issue until tonight.
I've created a Chat story in storybook. You should be able to add messages and they will display now. I've fixed this issue in the latest release.
Please update to the latest release and let me know if this fixes this issue.
In the meantime, I will close out this issue.


Add target to actions

Because I wanted to use target="_blank"

@Slimmmo thanks. can you please fix the conflict ? so i can merge it

Not until the end of the month sorry, will do it then.
On Wed, 10 Oct 2018 at 11:02 pm, Shakeeb Sadikeen<EMAIL_ADDRESS>wrote:

@Slimmmo https://github.com/Slimmmo thanks. can you please fix the
conflict ? so i can merge it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shakee93/vue-toasted/pull/67#issuecomment-428656041,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALfMOtKA7QQEyNVqHZGc1xEqNQpM7KDZks5ujiuQgaJpZM4T31U8
.


draft for Issue 54 models

An initial draft for #54. I think we'll have to work on the schema a bit, I just added the fields that were in the issue. But just to get it started

So are we going to write tests for each migration now? Or are we just writing a test that checks that the after the migrations are performed the database is set up the way we would like it to be.

I think we want to aim for testing at least the vast majority of all code, which includes the migrations. Note that I only wrote an explicit test for unapplying the 2nd migration, as this is otherwise not covered (as codecov told me :) ). I don't think we need to explicitly test applying the 1st and 2nd migration, as the tests of the models itself cover these (i.e. if the migrations failed, then the model tests will also fail).

@martinjrobins Do we need both this PR and #59? It looks like this one creates models which #59 also does...

@martinjrobins Do we need both this PR and #59? It looks like this one creates models which #59 also does...

@martinjrobins Do we need both this PR and #59? It looks like this one creates models which #59 also does...

This PR branch is branched from the #59 PR, as they follow on from each other. But they address different issues, so I kept them separate.

@martinjrobins Do we need both this PR and #59? It looks like this one creates models which #59 also does...

This PR branch is branched from the #59 PR, as they follow on from each other. But they address different issues, so I kept them separate.

@martinjrobins Ok, thanks -- sorry for duncing!

@martinjrobins Ok, thanks -- sorry for duncing!


Add String/Line Continuation cops

I believe the below may be more of a category of feature requests, than a single feature request. I will be glad to follow-up and break this out into multiple feature requests, but I am first seeking buy-in and/or direction or advice on if this is even possible to enforce with rubocop and the parser library.
Is your feature request related to a problem? Please describe.
My team frequently uses line continuation for String concatenation (as mentioned here, in the Style Guide). However:

I don't think any cops exist to enforce line continuation style. e.g.

# Good (no space before line continuation character).
"part 1 "\
"part 2"

# Bad (space before line continuation character).
"part 1 " \
"part 2"

# Good (conjoining space at end of first line of String).
"part 1 "\
"part 2"

# Bad (conjoining space at beginning of second line of String).
"part 1"\
" part 2"

# Bad (conjoining space at both end of first line and beginning of second line of String).
"part 1 "\
" part 2"

# Good (second line of String is aligned with start of first line of String).
"part 1 "\
"part 2"

# Bad (second line of String is misaligned with start of first line of String).
# (Or this could be good and the former could be bad, depending on team preference.)
"part 1 "\
  "part 2"

Auto-correction of various cops/offenses can cause manual cleanup work related to line continuation due to no enforcement of the above mentioned styles. e.g.

# Given:
# - Layout/FirstMethodArgumentLineBreak is enabled
# - Layout/FirstArgumentIndentation is enabled with:
#   `EnforcedStyle: consistent_relative_to_receiver`
# - Layout/HashAlignment is enabled with
#   `EnforcedHashRocketStyle: [key, table]` and
#   `EnforcedColonStyle: [key, table]`
mail(to<EMAIL_ADDRESS>     subject: "My super long subject that just keeps going and going and, "\
              "now has to line wrap to fit w/in Layout/LineLength chars.")

Then run:
> rubocop --auto-correct-all temp.rb
Inspecting 1 file
C

Offenses:

temp.rb:65:6: C: [Corrected] Layout/FirstMethodArgumentLineBreak: Add a line break before the first argument of a multi-line method argument list.
mail(to<EMAIL_ADDRESS>     ^^^^^^^^^^^^^^^^^^^^^^
temp.rb:66:1: C: [Corrected] Layout/FirstArgumentIndentation: Indent the first argument one step more than mail(.
to<EMAIL_ADDRESS>...
^^^^^^^^^^^^^^^^^^^^^^^
temp.rb:67:6: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.
     subject: "My super long subject that just keeps going and going and, "\ ...
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 3 offenses detected, 3 offenses corrected

Results in a code change of:
# Bad (line continuation alignment is now out of whack)
mail(
  to<EMAIL_ADDRESS>  subject: "My super long subject that just keeps going and going and, "\
                "now has to line wrap to fit w/in Layout/LineLength chars.") # <--- 👀

Which then requires manual intervention to go back and find all such issues and fix per the team's style.

Cops such as Layout/BlockAlignment are not reasonably usable along with line continuation for String concatenation. e.g.

# Given:
# - Layout/IndentationWidth is enabled with default values
# - Layout/BlockAlignment is enabled with
#   `EnforcedStyleAlignWith: start_of_block`
it "my really long test name that just keeps going and going and "\
   "now has to line wrap to fit w/in Layout/LineLength chars" do
  value(subject.my_method).must_equal("expected value")
end

Then run:
> rubocop --auto-correct-all temp.rb
Inspecting 1 file
C

Offenses:

temp.rb:72:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -1) spaces for indentation. (https://rubystyle.guide#spaces-indentation)
  value(subject.my_method).must_equal("expected value")
  ^
temp.rb:73:1: C: [Corrected] Layout/BlockAlignment: end at 73, 0 is not aligned with "now has to line wrap to fit w/in Layout/LineLength chars" do at 71, 3.
end
^^^

1 file inspected, 2 offenses detected, 2 offenses corrected

Results in a code change of:
# Bad (`end` should be aligned with beginning of `it`)
it "my really long test name that just keeps going and going and "\
   "now has to line wrap to fit w/in Layout/LineLength chars" do
     value(subject.my_method).must_equal("expected value")
   end # <--- 👀

Which I imagine is because the line continuation is seen as 2 or multi-lines when really I expect/want it to be treated like a single line. Because just removing the 2nd line of the String in the above example, e.g.
it "my really long test name that just keeps going and going and" do
  value(subject.my_method).must_equal("expected value")
end

results in no correction, as expected.
Describe the solution you'd like
I'd love to see a set of cops built for managing all of the above issues with line continuation. I'd be happy to help as much as I can with this, though I am still very green to rubocop's code base and to the parser gem and AST representations in general.
Describe alternatives you've considered
I've looked for cops dealing with line continuation but have found none.
I haven't yet looked into whether the parser gem's AST might represent (or not) line continuation characters -- which seems key to being able to enforce any of these style choices.
Additional context
These cops may provide further opportunity for style enforcement of https://rubystyle.guide/#no-trailing-backslash -- to not use line continuation in expressions. But this is not an issue that my team, in particular, struggles with.

The requested features are partly implemented now.
1

Layout/LineContinuationSpacing (added in 1.31, pending) checks space before backslash. Requires a space by default but is configurable.
Layout/LineEndStringConcatenationIndentation (added in 1.18, pending) checks the indentation of the next line after a line that ends with a string literal and a backslash. Enforces aligned by default, but can be set to indented.
Layout/LineContinuationLeadingSpace (added in 1.31, pending) checks where the space is in the concatenated strings. Also configurable (on master). Does not specifically report that there is space in both places, though.

2
The example is now corrected to
mail(
  to<EMAIL_ADDRESS>  subject: "My super long subject that just keeps going and going and, " \
           "now has to line wrap to fit w/in Layout/LineLength chars."
)

3
No change. Still aligns end as in the example.
@pdobb Would you close this issue and open a couple of new ones for the remaining problems? I think that would make it easier to fix them.

@jonas054 Looks like great progress, thanks! Unfortunately I'm out of the game now... Given that, I'm happy to just close this issue if it helps? I don't want to push work onto anyone else, but I'm gone as a stakeholder. Thanks again.

I'll close it, then. Given that only minor problems remain. Someone else will report if they're still bothered by these, I'm sure.


use pydantic EmailStr for email validation

Hi， @Festus-Kwafo
Can you describe your problem in detail?

So with the upgrade of pydantic to v2. I think it is redundant to write a function to check email if that will be done with EmailStr that has embedded in the new updates.

I didn't find such a function in the current branch, so I can't understand the problem because we're already using EmailStr.

yeah sure. it has been updated. Thank you


[BUG] Complete and improve HexDocs

This is considered a bug because of its importance.
The HexDocs should be complete and clear before shipping v1.0

This should also include typespecs.


Drop pedantic and nursery lints

Hey, I noticed with have a lot of #[allow  or #![allow attributes sprinkled around the codebase:
Non-clippy:
#![allow(unused_variables, dead_code)]
#[allow(dead_code)]
#[allow(unreachable_code)]
#[allow(unused_imports)]
#[allow(dead_code)]
#[allow(unreachable_patterns)]
#[allow(deprecated)]
#[allow(dead_code)]
#[allow(dead_code)]

Correctness:
#[allow(clippy::eq_op)]

Complexity:
#![allow(clippy::extra_unused_lifetimes)]

Style:
#[allow(clippy::disallowed_methods)]
#[allow(clippy::disallowed_methods)]

Perf:
#[allow(clippy::large_enum_variant)]
#[allow(clippy::large_enum_variant)]

Pedantic:
#![allow(clippy::cast_possible_truncation, clippy::cast_sign_loss)]
#![allow(clippy::cast_precision_loss)]
#[allow(clippy::semicolon_if_nothing_returned)]
#[allow(clippy::enum_glob_use)]
#[allow(clippy::wildcard_imports, unused_imports)]
#[allow(clippy::cast_precision_loss)]
#[allow(clippy::cast_lossless)]
#[allow(clippy::module_name_repetitions)]
#[allow(clippy::module_name_repetitions)]
#[allow(clippy::module_name_repetitions)]
#[allow(clippy::module_name_repetitions)]
#[allow(clippy::module_name_repetitions)]
#[allow(clippy::missing_panics_doc)]
#[allow(clippy::wildcard_imports)]
#[allow(clippy::missing_panics_doc)]
#[allow(clippy::missing_errors_doc, clippy::missing_panics_doc)]

Nursery:
#![allow(clippy::option_if_let_else)]

Some of them seem reasonable but it looks like the majority of these allow attributes are from the Pedantic group of lints.
In this PR I propose to drop the pedantic and nursery (the option_if_let_else one really rubs me the wrong way) lints and the respective allow attributes.

Codecov Report

Merging #411 (b3af728) into batching/main (b3af728) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head b3af728 differs from pull request most recent head 713344b. Consider uploading reports for the commit 713344b to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff               @@
##           batching/main     #411   +/-   ##
==============================================
  Coverage          43.50%   43.50%
==============================================
  Files                 30       30
  Lines               7354     7354
==============================================
  Hits                3199     3199
  Misses              4155     4155

Flag
Coverage Δ

test
43.50% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3af728...713344b. Read the comment docs.

We should do our best to avoid stuff like large_enum_variant , dead_code, unreachable_code, unused_imports... when possible. Thank you for cleaning some of it up!
I'm OK with dropping nursery.
Pedantic is a little annoying because we cast from insanely large eth numbers to db-friendly i64 quite often. module_name_repetitions is annoying but forces you to think about names. I actually found pedantic lints to improve code consistency and would like to keep them. Dunno, I'm curious what others think.

 Most seem fine, but  for example I don't think there's anything wrong with wildcard imports (like use super::*, I happen to use very frequently in tests). Nor is there anything wrong with having more identifiable names that would clash with module_name_repetitions - they are easier to find by symbol search across the codebase.
But the reason I want to drop them is simply because we had too many exceptions enabled everywhere.
What do you think about choosing a subset of pedantic lints that we'll explicitly enable?


Updates to support switching environment

Updated acr client to support adding/switching environment using cloud/context command modules.
Updated repository return value to support table format.

Minor updates so that we can use az cloud register and az context create to switch environments. /cc @SajayAntony @sivagms


K-23: API authorization

Description
Closes #23
Checklist

[x] An issue was first created before opening this pull request
[x] The new code follows the kaos contribution guidelines
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests to ensure that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@nithishr - Sorry for the late reply.
Since the standard Authorization header gets dropped from Ambassador (as per the last time you debugged), can you at least rename the header to X-Authorization-Token, it's more of a standard practice to prepend custom headers names with X-. Other than that, the PR looks ok to me.


Included contributing section into README:

Based on the discussions in PR #10 & issue #8, I added a small description to our README containing:
(1) requirements for PRs
(2) example data upload

Great! Maybe the PR requirements could also be in form of a pull_request_template.md, to be consistent with the other repo and that these checks will automatically appear when submitting a PR?

Great! Maybe the PR requirements could also be in form of a pull_request_template.md, to be consistent with the other repo and that these checks will automatically appear when submitting a PR?

@JuliaKukulies: Nice idea! I added a PR template based on your link!

@JuliaKukulies : Would you like to proceed the review?

@JuliaKukulies : Thanks for your suggestions! I removed the bullet that confused you & I added a small docu on how to run sphinx-based rendering locally. Please have a look ...

@JuliaKukulies : PR ready to merge? What do you think?

Sorry for delaying this @fsenf, but I am happy with it now and would say go ahead and merge!

@JuliaKukulies : Great, and be convinced that I am always slower than you ;-)


[Request] "Open Game" Event

An "Open Game" Event would be handy for multi-game collections.

Not quite sure what you mean. Are you saying having multiple projects in the same ROM? If so I think that's out of scope.

That is what I meant. I didn't know that it wasn't possible, sorry,


Deprecate internal Service for each resource (NodeService, PodService... etc)

WebUI doesn't use handlers and we deprecated handlers.
Services for each resource are created to implement the some specific logic to manage resources in the simulator.
For example, we need to use GracePeriodSeconds in the simulator when delete pods, because there are no actual Pods running in the simulator.
https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/541a021f8b98eb1ae102ec823fad721a91afd36e/pod/pod.go#L85
I expected to see more of this kinda simulator-specific logic in the future as the simulator grew larger, but actually that didn't happen.
I'd propose to remove services for each resource and use kubernetes client directly from all other services.
/priority important-long-term
/kind cleanup

/priority important-longterm

/assign

/triage accepted
Not to mark as stale.

/area simulator

/remove-lifecycle rotten
/lifecycle frozen


Show available years for options

Overview
When multiple years are selected, displays a badge or badges
beside each option in the question selector to indicate for
which years that option is available, given currently selected
geographies.
Connects #148
Demo

Notes
The red color of the badges is by specific client request.
Testing Instructions

Select multiple years and navigate to the questions selector
Options should indicate for which years they are available

Thank you for reviewing!


Building Docker image to run Spark on Ray with RAPIDS

Hey there!
We are trying to experiment Spark on Ray with RAPIDS but not sure if Spark on Ray can support this case.
Here is the example Dockerfile for spark-rapids k8s setup:
https://nvidia.github.io/spark-rapids/docs/get-started/Dockerfile.cuda
In the Dockerfile, we find the below commands to copy items under spark/:
COPY spark/jars /opt/spark/jars
COPY spark/bin /opt/spark/bin
COPY spark/sbin /opt/spark/sbin
COPY spark/kubernetes/dockerfiles/spark/entrypoint.sh /opt/
COPY spark/examples /opt/spark/examples
COPY spark/kubernetes/tests /opt/spark/tests
COPY spark/data /opt/spark/data

If running pip install raydp-nightly, we can find pyspark/.
Under pyspark, it has the below content.
/anaconda3/lib/python3.7/site-packages/pyspark# ls
__init__.py      context.py                java_gateway.py  rdd.py             statcounter.py
__pycache__      daemon.py                 join.py          rddsampler.py      status.py
_globals.py      data                      licenses         resource           storagelevel.py
_typing.pyi      examples                  ml               resultiterable.py  streaming
accumulators.py  files.py                  mllib            sbin               taskcontext.py
bin              find_spark_home.py        pandas           serializers.py     traceback_utils.py
broadcast.py     install.py                profiler.py      shell.py           util.py
cloudpickle      instrumentation_utils.py  py.typed         shuffle.py         version.py
conf.py          jars                      python           sql                worker.py

In this case, not sure if we should instead COPY pyspark/jars /opt/pyspark/jars or set SPARK_HOME to the existing .../pyspark installed by RayDP?
One small challenge: there is no /kubernetes/dockerfiles/spark/entrypoint.sh or /kubernetes/tests under pyspark/ - my guess is they might not be required if we are able to launch Spark with RayDP on k8s.
Any suggestions or pointers would be super helpful, thanks a lot!

I suggest you can start with a Ray image, install RayDP and pySpark in it and make sure Spark on Ray works on your K8s cluster first. Then you can try to run with other Spark plugins. If the plugin can work by setting a Spark configuration to include the jar, you can set it in RayDP when you init Spark like raydp.init_spark(..., configs={"key": "value"}).
However, we have no experience with spark-rapids. If it doesn't work, you may also want to check with the rapids team.

Related discussion in https://github.com/NVIDIA/spark-rapids/discussions/8062


[MIEB] Add image clustering

Checklist

[ ] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.

Adding datasets checklist

Reason for dataset addition: ...

[x] I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.

[ ] sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
[ ] intfloat/multilingual-e5-small

[x] I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
[x] If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
[x] I have filled out the metadata object in the dataset file (find documentation on it here).
[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.

looks amazing! Thanks for adding these. It seems like image clustering typically uses NMI, ARI and accuracy as metrics such as benchmark benchmark paper paper paper. Will be good to add support for these. Otherwise all good!

@gowitheflow-1998 I think there's an error when we run make test from tests/test_all_abstasks.py::test_load_data on the MSCOCOI2TRetrieval task. Could you please take a look when you have a chance?

@gowitheflow-1998 I think there's an error when we run make test from tests/test_all_abstasks.py::test_load_data on the MSCOCOI2TRetrieval task. Could you please take a look when you have a chance?

@isaac-chung The problem was load_dataset detected not called by AbsTaskI2TRetrieval, which should also be ignored following previous tests in main. I'll add or isinstance(task, AbsTaskI2TRetrieval) in test_all_abstasks.py if you could pull and push again after adding metrics?
def test_load_data(
    mock_concatenate_datasets: Mock, mock_load_dataset: Mock, task: AbsTask
):
    # TODO: We skip because this load_data is completely different.
    if (
        isinstance(task, AbsTaskRetrieval)
        or isinstance(task, AbsTaskI2TRetrieval)
        or isinstance(task, AbsTaskInstructionRetrieval)
        or isinstance(task, MultiSubsetLoader)
        or isinstance(task, AbsTaskSpeedTask)
    ):
        pytest.skip()

@gowitheflow-1998 thanks! Tests are passing now.
I've added accuracy for Tiny ImageNet. I think any additional metrics can be added along with the datasets that use them? I feel that this can be merged now and we can iterate.


OSCI: onboard local-roxctl-tests

Description
Per title.
Checklist

[ ] Investigated and inspected CI test results

Testing Performed
CI is sufficient:

/test

/test local-roxctl-tests

/test local-roxctl-tests


Aircraft routes don't appear anymore with the POS command

With the latest update, on my machine, aircraft routes do not appear anymore when using the POS command or double clicking an aircraft. The information is displayed in the command area, but no route path is visible on the map.

I am very sure that the aircraft have paths, as they follow them when simulating.

Fixed in bf888bb!


Monitor apt-updates with grafana

https://tom-henderson.github.io/2020/12/04/apt-grafana-prometheus.html

I probably wont need this...


Get ctrl-c to shutdown cluster after autoscale

There were a number of actors that were not being registered
as disposable created during a worker join. They are now
properly registered.
Closes #1704

@jtfmumm does this supersede #1672? Should #1672 be closed? I assume no but I want to check.

@SeanTAllen No, it's distinct from #1672, though it's possible you also registered new source boundaries there.  If so, that will be an easy merge conflict to resolve.

I'm not sure why log rotation tests would be failing because of these changes.  This commit registers more listeners, boundaries, and TCPConnections as disposables.  Any idea how that could cause log rotation tests to fail @nisanharamati?

@jtfmumm some of the tests use SIGTERM rather than SIGKILL to simulate a crash. They will then fail if SIGTERM is handled correctly. I thought I had fixed that everywhere. Maybe not. It's also possible that its a different error entirely.

Hmm, in 31 runs on OS X of make integration-tests-testing-correctness-tests-log_rotation verbose=true debug=true resilience=on, I see:
  18 ===================== 1 failed, 7 passed in ... seconds ======================
   3 ===================== 2 failed, 6 passed in ... seconds =====================
   5 ===================== 2 failed, 6 passed in ... seconds ======================
   5 ========================== 8 passed ... ===========================

Thanks @slfritchie.
I looked into this on Monday, and again today, and in most of these tests, the only thing that sticks out to me is that the surviving worker (initializer) never unmutes the source after the recovery, after log rotation.
Since the same thing doesn't happen in the simple recovery case (without log rotation), I think something here is messing with the mute/unmute state machine.

Specifically, I see this in the initializer's STDOUT:
Muting TCPSource
Muting TCPSource
Muting DataChannel
Unmuting DataChannel
RE-Connecting OutgoingBoundary to <IP_ADDRESS>:43303
RE-Connecting OutgoingBoundary to <IP_ADDRESS>:43303

I plan on removing mute and unmute as it currently exists and using the built in backpressure. Not planning on doing soon as it would require a decent amount of testing.

I'm currently stumped on this one.  It's not clear to me at all why registering more things as disposable (something that should only have an effect when you shutdown the cluster) would alter whether we unmute a source.

Perhaps timing related somehow @jtfmumm ?

I am pretty convinced this is timing related now.
I have been able to narrow down the circumstances to reproduce the failure to depend on the size of a delay between when the worker reports it has resumed processing, and when the test script kills that worker so that it can restart it to exercise recovery.
See branch error-in-1760 for the relevant changes.
If you edit https://github.com/WallarooLabs/wallaroo/blob/e783a79dfd7d81a5fdcba72f683c1d546875f228/testing/correctness/tests/log_rotation/log_rotation.py#L292
to be 0.001 instead of 0.01, then the test fails (on my laptop, you might need a different timing on yours).
What happens right before that sleep is a notifier that checks that these lines show up on the worker's stdout, before allowing the script to continue:
https://github.com/WallarooLabs/wallaroo/blob/e783a79dfd7d81a5fdcba72f683c1d546875f228/testing/correctness/tests/log_rotation/log_rotation.py#L40-L44
From looking at the output in a passing run, vs. the output in a failing run, these are still the last lines reported by the killed worker's STDOUT, so there is some farther action happening after that line is printed, and before 10ms elapse, that is necessary for the TCPSource to be properly unmuted by the initializer.

This one continues to confound me.  I narrowed it down to the following: if you revert all the changes in connections.pony, the test passes.  However, making _register_disposable do nothing does not make the test pass, which surprises me since calling that method is ultimately what all these changes are for.

I isolated the offending line to
https://github.com/WallarooLabs/wallaroo/blob/3fe2ae17d64052c3201d3fbeca197b82752f505d/lib/wallaroo/ent/network/connections.pony#L550
in  fun ref _create_control_connection
I'm still flummoxed as to why it causes the failure.
Here's what I've gathered so far:

registering control_conn as disposable is the line that causes the test to fail
The test fails because TCP Source isn't unmuted at the end of the recovery after a worker has been killed and restarted
Adding a 10ms delay before killing the worker, and after it has reported completing log rotation, prevents the failure
the number of _muted_downstream in tcp_source.pony doesn't go down to 0 in the failing case (which is why the source isn't unmuted)

Here's what I've been able to figure out today.

All of the test_log_rotation_external_trigger_recovery_pony cases that pass also have two requests by worker1 to initializer to unmute.
All of same test cases that happen fail also have exactly one request by worker1 to initializer to unmute.
In the cases that fail, the test harness is killing worker1 before it can finish requesting the 2nd unmute.
The sleep(0.01) that Nisan had added during his debugging work yesterday (?) and today gave enough time for worker1 to send its 2nd unmute request, and the test always passes.

Both of the unmute requests from worker1 are triggered by RouterRegistry's behavior rotation_complete():
  be rotation_complete() =>
    """
    Called when rotation has copmleted and we should resume processing
    """
    _connections.request_cluster_unmute()
    _resume_the_world()
    _unmute_request(_worker_name)

_connections.request_cluster_unmute() is an async call to the Connections actor, and it usually (?) ends up being scheduled later.

_resume_the_world() sends an unmute_request to initializer.

_unmute_request(_worker_name) sends to itself, i.e. worker1, so this isn't interesting.

Frequently, the test rig kills worker1 now.

If worker1 is lucky enough to be alive, then the Connections actor will process the request_cluster_unmute() message sent by step 1 and also be alive long enough to actually send the unmute_request to initializer ... and if so, then the test will pass.

I don't know why initializer is wanting two unmutes from worker1, but it is.  The test's Python code is lucky enough to exploit this race.  It'd be fantastic to require only one unmute, since that would reduce the opportunity window for the race ... but I also am not sure if that would close the window to zero.

My current hypothesis is that this is caused by a confluence of two things:

adding the control connection to disposables causes it to be disposed before it sends the last unmute request in the failing test case
the worker with the muted source (initializer) doesn't do anything to clear up that mute request from the now-defunct-and-replaced-by-the-recovered-worker's-control-connection (aka c: Consumer in the be unmute(c: Consumer) in tcp_source.poy)

leading to the source never getting unmuted, because of this clause:
    if _muted_downstream.size() == 0 then
      _unmute()
    end

in be unmute(c: Consumer) in tcp_source.pony
I think the Right Way™ to get around it is to fix whatever Consumer is to be a cluster-wide unique id, which is correctly recovered in the recovering worker phase, e.g. the Step ID.
I suspect that currently the consumer is not the Step ID, and so it's a different consumer between the killed worker and the recovering worker, leading to the _muted_downstream set never emptying.
I'm not sure what the Quick and Dirty™ way is. Perhaps just clearing the _muted_downstream from each connection if the connection is lost (and making each new connection start in MUTED and have to make an unmute request via RouterRegistry).

Because it is not necessary for resolving the issue this PR addresses, I have removed the offending line Nisan identified and all tests are passing.  I have opened issue #1784 to address the fact that we need to clean up our approach to keeping track of which actors we need to dispose of on shutdown.  Part of the problem with the offending line is that it caused the same TCPConnection to be disposed of twice (though I'm not sure if this is actually related to the failing tests for log rotation).
@nisanharamati Could you add information about what you've discovered chasing down these failing tests to that issue (#1784) so we don't lose track of it?
@SeanTAllen @nisanharamati I think this is ready to merge in its current state, pending your approval.

Seems good to me but I haven't been following along.

@jtfmumm I'm not sure #1784 would address the same issue as the failure mode I described.
The early disposing of the control_conn triggers a case where an upstream router doesn't receive all of the UNMUTE requests before the downstream disappears, and the replacement (recovered) downstream is unable to achieve a full UNMUTE because the upstream still holds a reference to the original and now-dead Consumer that requested the MUTE. #1784 addresses that case where we cause that by disposing of the control connection... But I suspect any crash after the MUTE has been processed and before UNMUTE completes would also result in an un-UNMUTE-able upstream scenario.


pip error: conflicting dependencies

Thanks for your great work!
i am trying to install qafacteval using pip install -e .and pip install qafacteval.
But I get the same error as follows.
There appears to be a dependency conflict. what should i do to solve this problem？
`pip install -e .
Obtaining file:///Users/tanhexiang/workplace/QAFactEval
Preparing metadata (setup.py) ... done
Collecting qaeval
Using cached qaeval-0.1.0-py3-none-any.whl (42 kB)
Using cached qaeval-0.0.9-py3-none-any.whl (36 kB)
Using cached qaeval-0.0.8-py3-none-any.whl (36 kB)
Using cached qaeval-0.0.7-py3-none-any.whl (28 kB)
Collecting urllib3>=1.25.10
Using cached urllib3-1.26.12-py2.py3-none-any.whl (140 kB)
Collecting allennlp==1.1.0
Using cached allennlp-1.1.0-py3-none-any.whl (485 kB)
Collecting qaeval
Using cached qaeval-0.0.6-py3-none-any.whl (26 kB)
Using cached qaeval-0.0.5-py3-none-any.whl (26 kB)
Using cached qaeval-0.0.3-py3-none-any.whl (18 kB)
Using cached qaeval-0.0.2-py3-none-any.whl (18 kB)
Using cached qaeval-0.0.1-py3-none-any.whl (18 kB)
INFO: pip is looking at multiple versions of qafacteval to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install qafacteval because these package versions have conflicting dependencies.
The conflict is caused by:
qaeval 0.1.0 depends on torch==1.6.0
qaeval 0.0.9 depends on torch==1.6.0
qaeval 0.0.8 depends on torch==1.6.0
qaeval 0.0.7 depends on torch==1.6.0
qaeval 0.0.6 depends on torch==1.6.0
qaeval 0.0.5 depends on torch==1.6.0
qaeval 0.0.3 depends on torch==1.6.0
qaeval 0.0.2 depends on torch==1.6.0
qaeval 0.0.1 depends on torch==1.6.0
To fix this you could try to:

loosen the range of package versions you've specified
remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts`

I use python==3.6 instead of 3.10, and it works. Maybe, it was the newest python that caused this problem

That might be it - the python version I was running it with was 3.8.13. Closing this for now, but feel free to reopen if there are related issues!

Having the same issue with python 3.9 - it looks like qaeval requires torch==1.6.0 which is not available for 3.9+.


cut at new layout logic for LinearLayout

This is an attempt to fix Bug #613
In theory, this code could be placed inside the desperation branch where cap is called. To fix the bug, you have to do most of the work that layout does, so it's here as a replacement for the layout code.
I wouldn't take this PR as is. I am not that familiar w/ cursive, nor rust. It likely needs some tweaking for both.
I think the algorithm is sound and generates similar (but different) results as the previous algorithm (plus bug fix). I personally think it's simpler? but that might be just because I wrote it.
If there is another / better / simpler way to address the bug in question, I'd be happy to take a stab at that w/ some guidance.

I think it would be fairly easy to update this logic to add weight support.


[TF] Rename ShapedArray initializers to init(repeating:shape:).

Deprecate init(shape:repeating:) for ShapedArray and ShapedArraySlice in favor of init(repeating:shape:).
This is a follow-up to https://github.com/apple/swift/pull/22979, in which Tensor.init(shape:repeating:) was similarly renamed/deprecated. The new initializer is consistent with tf.constant.
Update tests to use new initializers.

@swift-ci Please test tensorflow


Adjust Nix infrastructure to support passing custom target CPU and -march flags

With https://github.com/girlbossceo/conduwuit/commit/649e9da1f8f6404123f240af99cd801a7d16ed3a and release of v0.4.5 I can no longer run aarch64 executables and OCI images from the release page.
Even Raspberry 4 does not support Arm8.2, so this change limits self-hosting capabilities. Consider targeting something like a53 or producing artifacts for multiple optimization levels.

Hi! I did try to do a lot of research on what I should pick but I was having trouble finding a consistent answer on what most Raspberry Pi's supported. Sorry this broke 0.4.5 for you! I'm happy to lower it to a more reasonable level if you found one already.
I see you made this https://github.com/knightpp/conduwuit/commit/e579279288eaf2cb7355d14706d492f009e54375 and I would accept a PR for it, but it has a ton of other formatting changes which I'd like to have split up into separate commits.

I see. I'll try to do my own research, but I'm unsure what was the reason to change the target optimization level in the first place? target-cpu=generic is a good(?) default.
The formatting changed because I use alejandra to format Nix files. I didn't intend to make a PR out of that.

It's primarily for optimisation. conduwuit uses RocksDB, which is C, so having highly optimised bytecode makes a significant difference. We also use musl, which is slow, so any forms of optimisation also make a big difference hence things like jemalloc and io_uring are statically included in the static binaries.

I don't know if there's a middle ground. To get the best optimizations, everyone should customize and compile for their CPU, but on my(mid 8C) machine, full cross-compilation for ARM took ~2 hours, so it's not an easy task.
Another option is to add multiple CPU targets to the CI, though it won't reuse previous caches.
I'll continue building it for myself, but leave this issue open. However, there's room for improvement. It would be great to add documentation on how to cross-compile and improve Nix to be able to pass target CPU.
FIY: How to list CPU features

rustc --target aarch64-unknown-linux-musl -C target-cpu=cortex-a55 --print cfg

improve Nix to be able to pass target CPU.

I don't really know Nix to be able to add something like this, this will be something the community has to contribute unless I do manage to figure out (not this week).
As for cross-compilation documentation using Nix, I can work on that.
I did decide to just drop it down to ARMv8-A which I will merge/add soon (busy this week) and depending on what the community needs, I can figure out multiple target arch builds in CI. Though I don't think we'll run into this issue that much. I haven't produced (or even tested) ARM 32-bit builds and no one's really mentioned a need for them.

improve Nix to be able to pass target CPU.

I meant to pass optimization level as a string to Nix functions, because right now it is hardcoded into nix/pkgs/main/cross-compilation-env.nix and nix/pkgs/main/default.nix. That might be handy when someone decides to compile for themselves for some very specific CPU.

Going to change this to a feature request for the requested Nix infrastructure as I've dropped the target CPU to ARMv8-A, so next release and currently main should be "fixed".


Added CODE_OF_CONDUCT.md

Added Pledge Section
Added Standards Section
Added Enforcement Responsibilities Section
Added Scope Section
Added Enforcement Section
Added Enforcement Guidelines Section
Closes #3

@SurajSanap Please assign gssoc label and level label, then only this contribution will be considered for my points

@SurajSanap Please assign this PR to me.


Website [Masthead] Add guidance for when to use L0 and L1

A few variations of masthead is being misused
L0 default
L0 with platform
L1
A lot of pages with L0 with platform should instead be using L1:

https://ibm.com/cloud/go-hybrid

Some guidance top of mind (not all missing guidance are captured here)

Navigation should be labeled with nouns, not verbs, so it's like geographical locations.
Platform name at the moment is only reserved for IBM Cloud. Not even IBM Security or Watson
L1 is for all Topics (a topic is Security, Watson, Supply chain etc)

The latest proposal allows for QRadar and other items are allowed to be in the L0.  The rule is flexible.  This issue can be closed.  It is outdated.


Add a new "satisfies" edge kind to the Kythe schema. [phab:D1445]

Created by fromberger at 2017-03-23 20:41:00:
See #1822. In Go, types may implicitly satisfy interfaces.  Unlike with explicit
extension (class A extends B {...}), the set of possible implicit satisfactions
can't be constructed without a global scan to discover what interfaces exist.
In practice, however, it is useful to record the relationship a concrete type T
has to "known" interfaces, particularly those occurring in compilations T
depends on.  Because this relationship is useful, but heuristic, let's give it
a separate name from "extends" (even though they are similar in spirit) so that
tools can tell whether the information in the graph is likely to be complete.
This change updates the schema and the Go indexer, and adds examples.

craigbarber commented inline (context lost during migration) at 2017-03-23 20:47:32:
If "implements" isn't proper Go vocabulary, then perhaps re-naming this file to "satisfies" would be appropriate.
Also, I think the header comment should be updated to reflect these changes.

craigbarber accepted this revision at 2017-03-23 20:47:54

fromberger wrote at 2017-03-23 20:50:35:

Rename implements.go and its test to say 'satisfies'.

fromberger commented inline (context lost during migration) at 2017-03-23 20:52:19:
Done: I renamed the file and the test.
In Go it's common to say that a type "implements" an interface ("satisfies" is sometimes used within the compiler, but "implements" is the common vocabulary).
We avoided the word "implements" in the edge kind to avoid confusion with Java, though.

fromberger closed via commit c3ec1410ca077b12bd3de9ad776da7223c505ef7 at 2017-03-23 20:58:02


Rails: Check for indexs in tables for fields with XXX_id name

It can be possible to create cop for check field with "XXX_id" name. (Ended with "_id")
Such fields must be index field in database.

You can check for this by just inspecting the source code.

We can check all code issues by "just inspecting". :)
Ussualy we forgot add index to field.
And then in production we have slowly speed for some response.
Need to check such slowly response in NewRelic - it is big time for such easy bug.

below is check code example. Now i use it in tests:
tables = []

ActiveRecord::Base.connection.tables.each do |table|
  next if table.match(/\Aschema_migrations\Z/)
  klass = table.singularize.camelize.constantize
  tables << { table => klass.name }
end

tables.each do |table|
  klass = table.values[0]
  klass = klass.constantize
  assert klass.columns[0].primary,
         "First column '#{klass.columns[0].name}' ".bold +
           "is not Primary in model #{klass}".red

  klass.columns.each do |col|
    next if col.name[-3..-1] != '_id'
    exist = ActiveRecord::Base.connection.index_exists?(
      table.keys[0], col.name)
    assert exist, "Column '#{col.name}' ".bold +
      "is not index in model #{klass}".red
  end
end

RuboCop is a static code analyzer. It just inspects the AST of the Ruby source code, we can't do checks like the one you suggested.

@mpz You might want to take a look at the lol_dba gem instead. It can “scan your application models and displays a list of columns that probably should be indexed”.

@bbatsov, @bquorning thank you. It is true - rubocop is static code analyzer.


Require resolves to the sibling node_modules if lookup failed in the given dir.

Hi! :cow:
I have the following dir structure:
some-dir/node_modules/mah-package
some-dir/mah-project/resolve-from-here
If I run
resolveFrom('resolve-from-here', 'mah-package')

it resolves to some-dir/node_modules/mah-package. This can be avoided by keeping only subdirs of the given dir here: https://github.com/sindresorhus/resolve-from/blob/master/index.js#L18
I can issue a PR if you confirm that it's not expected behavior.

That's how the Node.js module resolution works.
https://nodejs.org/api/modules.html#modules_loading_from_node_modules_folders

That's how the Node.js module resolution works.

Thanks, I know it. I've had wrong impression that this module tries to find module exactly in the specified dir.


Inconsistent SliverAppBar behavior with scroll bar

Steps to reproduce

Open this dartpad in a desktop browser (i have tested with edge and firefox) and click run
scroll far down using the scroll bar (do not scroll using the mouse wheel)
scroll a bit up using the scroll bar

Expected results
Since SliverAppBar.floating = true it should reappear and expand as soon as the scroll view is scrolled up again. (at least, this would match the behavior on android)
Actual results
The appbar remains hidden until the scrollview is scrolled all the way to the top again, or the user scrolls up using the mouse wheel (any amount, as long as the scroll view is not already at the top. this fixes the behavior for the scroll bar as well).
Code sample
https://dartpad.dev/?id=12ab524b77adc962eb8ddebb73d637e1
Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/26089559/81559463-f38e-4cf2-af22-17fae8018473

Logs
No response
Flutter Doctor output
tested in dartpad with Dart 3.3.3, Flutter 3.19.5

Reproducible using the sample from dartpad.
This is not specific to web or desktop. It reproduces on mobile as well.
Labeling for further investigation
https://github.com/flutter/flutter/assets/88313112/ba1cee42-3052-482a-bcd6-e096d264199b

code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData.dark(),
      debugShowCheckedModeBanner: false,
      home:  Scaffold(
        body: Center(
          child: MyStatefulWidget(),
        ),
      ),
    );
  }
}

class MyStatefulWidget extends StatelessWidget {
  MyStatefulWidget({super.key});

  final ScrollController _scrollController = ScrollController();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Scrollbar(
        controller: _scrollController,
        child: CustomScrollView(
          controller: _scrollController,
          slivers: <Widget>[
            SliverAppBar(
              floating: true,
              expandedHeight: 200,
              actions: [
                TextButton(
                  onPressed: () {},
                  child: const Text('test'),
                ),
              ],
              flexibleSpace: const FlexibleSpaceBar(
                background: FlutterLogo(),
              ),
            ),
            SliverList.list(
              children: [
                for (var i = 0; i < 50; i++)
                  Container(
                    height: kToolbarHeight,
                    width: double.infinity,
                    color: i.isEven ? Colors.green : Colors.blue,
                  ),
              ],
            ),
          ],
        ),
      ),
    );
  }
}

flutter doctor -v
[!] Flutter (Channel stable, 3.19.5, on macOS 14.4.1 23E224 darwin-arm64, locale en-GB)
    • Flutter version 3.19.5 on channel stable at /Users/nexus/dev/sdks/flutter
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter. Consider adding /Users/nexus/dev/sdks/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutters/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutter. Consider adding /Users/nexus/dev/sdks/flutter/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (3 weeks ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Users/nexus/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode-15.3.0.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Users/nexus/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.5)
    • IntelliJ at /Users/nexus/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 77.2.2
    • Dart plugin version 232.10286

[✓] VS Code (version 1.87.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.86.0

[✓] Connected device (4 available)
    • Nexus (mobile)       • 00008020-001875E83A38002E • ios            • iOS 17.4.1 21E236
    • Dean’s iPad (mobile) • 00008103-000825C811E3401E • ios            • iOS 17.4.1 21E236
    • macOS (desktop)      • macos                     • darwin-arm64   • macOS 14.4.1 23E224 darwin-arm64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 124.0.6367.60

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 3.22.0-12.0.pre.33, on macOS 14.4.1 23E224 darwin-arm64, locale en-GB)
    • Flutter version 3.22.0-12.0.pre.33 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision eee2c6f6bf (6 hours ago), 2024-04-17 00:52:34 -0400
    • Engine revision 0cdbc8a6e4
    • Dart version 3.5.0 (build 3.5.0-68.0.dev)
    • DevTools version 2.35.0-dev.8

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Users/nexus/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode-15.3.0.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Users/nexus/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.5)
    • IntelliJ at /Users/nexus/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 77.2.2
    • Dart plugin version 232.10286

[✓] VS Code (version 1.87.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.86.0

[✓] Connected device (5 available)
    • Nexus (mobile)                  • 00008020-001875E83A38002E • ios            • iOS 17.4.1 21E236
    • Dean’s iPad (mobile)            • 00008103-000825C811E3401E • ios            • iOS 17.4.1 21E236
    • macOS (desktop)                 • macos                     • darwin-arm64   • macOS 14.4.1 23E224 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad     • darwin         • macOS 14.4.1 23E224 darwin-arm64
    • Chrome (web)                    • chrome                    • web-javascript • Google Chrome 124.0.6367.60

[✓] Network resources
    • All expected network resources are available.

• No issues found!

This is because dragging on the scrollbar is not the same as dragging on the scroll view, so the floating effect is not triggered. This should be fixed by https://github.com/flutter/flutter/pull/146654 though.


[Request/Bug?] Dimension arrows/lines are skewed

The dimension arrows/lines/indicator UI on the sides of a brush are offset in 2D-space, and appear skewed in 3D space
You can see in this screenshot the Z-axis length indicator crosses over the gridline, shouldn't it be parallel to the line? ie. parallel the brush's edge in 3D space, not 2D space?

I'll look into this. It has to do with scaling the arrows according to the distance to camera

This is now fixed in version 1.326!
It can be downloaded from https://prenominal.nl/updates/
I'll close this ticket once this version is available on the asset store


Record attestation metrics

Include

number of attestations in a generated block and
total number of attesters represented by those attestations.

we have lots of questions @ajsutton

Done.

Done.


The new site needs to be configured to add ".html" automatically at the end of URLs

The problem
Most web sites do understand that; however, the new staging server is not.
Suggestions
Try to fix it or liaise with perl6-infra to fix it.

Due to this error:
Real URL   https://docs-stage.p6c.org/perl6.html.html.html.html.html.html.html.html.html.html.html
Check time 12.367 seconds
Size       194B
Info       Redirected to
           `https://docs-stage.p6c.org/perl6.html.html'.
           Redirected to
           `https://docs-stage.p6c.org/perl6.html.html.html'.
           Redirected to
           `https://docs-stage.p6c.org/perl6.html.html.html.html'.
           Redirected to
           `https://docs-stage.p6c.org/perl6.html.html.html.html.html'.
           Redirected to
           `https://docs-stage.p6c.org/perl6.html.html.html.html.html.html'.
           Redirected to
           `https://docs-stage.p6c.org/perl6.html.html.html.html.html.html.html'.
           Redirected to
           `https://docs-stage.p6c.org/perl6.html.html.html.html.html.html.html.html'.
           Redirected to
           `https://docs-stage.p6c.org/perl6.html.html.html.html.html.html.html.html.html'.
           Redirected to
           `https://docs-stage.p6c.org/perl6.html.html.html.html.html.html.html.html.html.html'.
           Redirected to
           `https://docs-stage.p6c.org/perl6.html.html.html.html.html.html.html.html.html.html.html'.
Result     Error: TooManyRedirects: Exceeded 10 redirects.


Migrate to C++/Nasm

Main reason: C is good, but its lack of generic programming can sometimes drive you crazy trying to restructure kernel so GP is not needed in current version, and you pray it won't be needed later. Also, c-tors/d-tors are useful when writing safe code. Of course there will be no STL, but at least I would be able to use classes and templates.
Nasm is definitely better than GAS, it provides much more clear variation of Intel syntax. It doesn't support AT&T syntax, however, so I would need to port existing assembly sources.

Done


Change download url for arthas in Dockerfile

What changes are proposed in this pull request?
Changes the url to download arthas 3.4.6 to one hosted by github
Why are the changes needed?
The original url, hosted by maven.aliyun.com, is sometimes unavailable, causing errors when building the docker image.
Does this PR introduce any user facing changes?
Nope

Codecov Report

Merging #13931 (145b25c) into master (7eef117) will decrease coverage by 26.08%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #13931       +/-   ##
=============================================
- Coverage     43.53%   17.44%   -26.09%
+ Complexity     9135     2675     -6460
=============================================
  Files          1399     1399
  Lines         81248    81249        +1
  Branches       9878     9878
=============================================
- Hits          35371    14175    -21196
- Misses        42916    65821    +22905
+ Partials       2961     1253     -1708

Impacted Files
Coverage Δ

...ain/java/alluxio/master/file/LostFileDetector.java
26.92% <0.00%> (-45.08%)
:arrow_down:

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/stress/BaseParameters.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/client/UnderStorageType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/underfs/options/ListOptions.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/worker/block/io/BlockReader.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 661 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f025f...145b25c. Read the comment docs.

alluxio-bot, merge this please


[REF-1310] Formatting List/Bullet rx.markdown

With improvements to the markdown component this ticket is to add some default indentation so it matches the other components.
REF-1310

Markdown now has better default styling and supports a component_map prop.


ISIS-3200: broken Value Choices

[x] failing regression tests (JDO related)
[x] failing value showcases (demo app)

pre-store event fixes
object mementos simplified a lot
wicket viewer 'execution' still broken as was before the branch-off