Question: Multi-Language Custom Errors

I'm just thinking ahead on what will be on the roadmap, and this popped to mind.
What is the best approach to providing custom errors in multiple languages? Is it even possible right now? Something planned for when ajv-i18n become a proper plugin?
https://github.com/ajv-validator/ajv-i18n/issues/153

ajv-i18n should be ok to use with v7 - all it does is iterating errors and generating the messages.
But it would only work with the standard errors for draft-07, neither draft-2019-09 keywords nor user-defined keywords would be supported.
I’ll need to review again the linked proposal - I am not yet certain what’s the best design here, but it seems like it should be some cross-cutting concern that should be applied to all keywords - so possibly different from the current plugin approach...
I see it as a wider design question than just for internalisation - e.g. support for parsing seems to be in the same category - the extension mechanism that should be applied to all keywords. That’s why I didn’t want to rush it. Also see https://github.com/ajv-validator/ajv/issues/1161#issuecomment-735230717
At the moment there are two options:

Use errorMessage and generate schemas programmatically, supplying the messages you need.
Use ajv v7 and dynamically update error messages inside keyword definitions for your keywords - the new internationalisation is likely to do the same. It means that you’ll need a separate instance per language and keyword definitions need to be cloned, but it seems ok.

Assuming I settle on the latter approach (I don’t see any alternative tbh) v8 would include some type/function to support such extensions and ajv-i18n will be reimplemented using it.
We can collaborate on it if you need it sooner than end of March.
Maybe you have some better ideas?

ajv-i18n should be ok to use with v7 - all it does is iterating errors and generating the messages.
But it would only work with the standard errors for draft-07, neither draft-2019-09 keywords nor user-defined keywords would be supported.
I’ll need to review again the linked proposal - I am not yet certain what’s the best design here, but it seems like it should be some cross-cutting concern that should be applied to all keywords - so possibly different from the current plugin approach...
I see it as a wider design question than just for internalisation - e.g. support for parsing seems to be in the same category - the extension mechanism that should be applied to all keywords. That’s why I didn’t want to rush it. Also see https://github.com/ajv-validator/ajv/issues/1161#issuecomment-735230717
At the moment there are two options:

Use errorMessage and generate schemas programmatically, supplying the messages you need.
Use ajv v7 and dynamically update error messages inside keyword definitions for your keywords - the new internationalisation is likely to do the same. It means that you’ll need a separate instance per language and keyword definitions need to be cloned, but it seems ok.

Assuming I settle on the latter approach (I don’t see any alternative tbh) v8 would include some type/function to support such extensions and ajv-i18n will be reimplemented using it.
We can collaborate on it if you need it sooner than end of March.
Maybe you have some better ideas?

As always, thanks for the detailed and educational reply.
Generating two schema pragmatically and use ajv-errors was what I was thinking. Not a big burden to write, but added extra complexity. Sounds like I'm not the first to bring this up. Glad to hear it's something that's planned.
In our use case we currently allow contributors to upload large dataset to our service, before sending we have a web worker validate the file against our data schema. We do this client side to reduce the amount of data needed to be uploaded when there are errors that need to be resolved. A large number of our contributors are in remote locations in northern Canada where bandwidth is a valuable commodity. We're planning to rebuild our upload system to support multiple languages like french and maybe even some indigenous ones. Our roadmap has this in Q2, so lots of time.
I'm happy to collaborate on this if you think I can help. What you described in your linked comment and here sounds like the right approach from a high level. I should be free in a week or so after middy.js v2-alpha goes out for community feedback. Ping me an gitter, maybe we can put together a small working group for this? cc @ucarion

As always, thanks for the detailed and educational reply.
Generating two schema pragmatically and use ajv-errors was what I was thinking. Not a big burden to write, but added extra complexity. Sounds like I'm not the first to bring this up. Glad to hear it's something that's planned.
In our use case we currently allow contributors to upload large dataset to our service, before sending we have a web worker validate the file against our data schema. We do this client side to reduce the amount of data needed to be uploaded when there are errors that need to be resolved. A large number of our contributors are in remote locations in northern Canada where bandwidth is a valuable commodity. We're planning to rebuild our upload system to support multiple languages like french and maybe even some indigenous ones. Our roadmap has this in Q2, so lots of time.
I'm happy to collaborate on this if you think I can help. What you described in your linked comment and here sounds like the right approach from a high level. I should be free in a week or so after middy.js v2-alpha goes out for community feedback. Ping me an gitter, maybe we can put together a small working group for this? cc @ucarion

Hey, I was finally able to get back to this. Did some additional reading of past proposals and comments on the json-schema-spec. Seems there is a kind of agreement that translations should be external (too complicated within the schema) and that an identifier should be used.
I put together a proof of concept, https://github.com/willfarrell/ajv-ftl-i18n, based off ajv-i18n with the ability to pass in a fluent file and the ability to use errorMessage as an id w/ params. For now it's currently unpublished, but curious if you think it might be worth using this for<EMAIL_ADDRESS>One caveat is that the option message needs to be true to be able to have the resulting errorMessage accessible to be used for matching up to the translation file. Would it be possible to return the processed errorMessage as a param in this case or always, shaving off ~2kb of unused english messages?


LICENSE.md file

I'm an engineer on Google's Android team planning to write a tool to generate C APIs for some C++ libraries we are using in the Android NDK.  I found out about CPP2C and I'm interested in using it as a starting point.  But by company policy, I can't use any code without a specific open-source license, and this particular repository doesn't have one.
Would you mind committing a LICENSE.md file into the repository?  The Apache 2.0 license, like the one used in https://github.com/samanbarghi/wrap-syscall would be ideal.
Thanks a lot!

Done. Hope it helps.

Thanks for the quick response, much appreciated!


Fixes #1198

Description
Fixes #1198
Now notifications list retained across orientation change without fetching again from server.

Codecov Report

Merging #1202 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1202      +/-   ##
=========================================
- Coverage    3.82%    3.8%   -0.02%
=========================================
  Files         125     126       +1
  Lines        5810    5827      +17
  Branches      568     569       +1
=========================================
  Hits          222     222
- Misses       5573    5590      +17
  Partials       15      15

Impacted Files
Coverage Δ

...mmons/notification/NotificationWorkerFragment.java
0% <0%> (ø)

...nrw/commons/notification/NotificationActivity.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215c97e...01ad0c8. Read the comment docs.

Yes, this looks good to me! I have resolved the merge conflicts too. @neslihanturan Can you help in testing it. :)

Tested, thanks @knight-shade

Thanks @maskaravivek for resolving merge conflicts. :smile:


fix: add timeout for registry request

Fix:

added timeout

Test:
./bin/notation sign localhost:5003/hello:v1 --key e2e -d
INFO[2023-07-25T21:13:11+08:00] Using the referrers tag schema
DEBU[2023-07-25T21:13:11+08:00] > Request: "HEAD" "http://localhost:5003/v2/hello/manifests/v1"
DEBU[2023-07-25T21:13:11+08:00] > Request headers:
DEBU[2023-07-25T21:13:11+08:00]    "Accept": "application/vnd.docker.distribution.manifest.v2+json, application/vnd.docker.distribution.manifest.list.v2+json, application/vnd.oci.image.manifest.v1+json, application/vnd.oci.image.index.v1+json, application/vnd.oci.artifact.manifest.v1+json"
DEBU[2023-07-25T21:13:11+08:00]    "User-Agent": "notation/v1.0.0-rc.7+unreleased"
ERRO[2023-07-25T21:13:31+08:00] Error in getting response: %!w(*errors.errorString=&{net/http: request canceled})
Error: failed to get manifest descriptor: Head "http://localhost:5003/v2/hello/manifests/v1": net/http: request canceled (Client.Timeout exceeded while awaiting headers)

server script:
from flask import Flask, request
import time

app = Flask(__name__)

@app.route('/', defaults={'path': ''}, methods=['GET', 'POST', 'PUT', 'DELETE'])
@app.route('/<path:path>', methods=['GET', 'POST', 'PUT', 'DELETE'])
def delay_response(path):
    while True:
        time.sleep(1)

if __name__ == "__main__":
    app.run(host='<IP_ADDRESS>', port=5003)

Resolves #707
Signed-off-by: Junjie Gao<EMAIL_ADDRESS>

According to containerd implementation: https://github.com/containerd/containerd/blob/6eb90a63e061231a5aa79d5074be3d851e310ec1/client.go#L382-L386
There is no timeout for http.Client, so we need to more discussion on this issue. The PR may be not merged before v1.0.0.

https://github.com/docker/cli/blob/e0e27724390cbce21cf6d67568972a4227b07382/vendor/github.com/docker/docker/registry/auth.go#L105-L126
According to Docker CLI implementation, the http.Client.Timeout = 15s


cmd/go: go list std returns no packages

This was initially reported as https://github.com/dvyukov/go-fuzz/issues/234. I've migrated it here as we investigate further, since this appears to be the correct home for it.
@saschagrunert reports that:

My distribution links the go sources into the go lib sources.

 Are you using it in any unusual way? (I'm trying to scope how widespread this issue may be.)
You reported using Go 1.12.1, but those symlinks all say go/1.11. Any idea why there is this disparity? Are the Go 1.12.1 std sources present, and if so, at what path? (And what does which go report?
Are the symlinks created by you or by your distribution? IIRC, the go tool has long ignored symlinks.

Thanks for your help tracking this down.

@josharian thank you for taking care of the issue and the report here!

What distribution is it? Are you using it in any unusual way? (I'm trying to scope how widespread this issue may be.)

I'm running openSUSE Tumbleweed, the (default) go package can be found here:
https://build.opensuse.org/package/show/openSUSE:Factory/go1.11

You reported using Go 1.12.1, but those symlinks all say go/1.11. Any idea why there is this disparity? Are the Go 1.12.1 std sources present, and if so, at what path? (And what does which go report?

Sorry for the confusion, I tried multiple versions of go, like this development version of go1.12:
https://build.opensuse.org/package/show/devel:languages:go/go1.12
I did not modify anything by hand until I found out that a usual download from https://dl.google.com/go/go1.12.2.linux-amd64.tar.gz and a manual modification of GOROOT/GOPATH works like a charm.

Are the symlinks created by you or by your distribution? IIRC, the go tool has long ignored symlinks.

It's by the distributions package. Do you think it would be possible to not ignore symlinks when running go list?

cc @bcmills @jayconrod for cmd/go
It is not clear to me whether the right fix here is in cmd/go or in the upstream distribution.

I think this is an issue with the upstream distribution. Symbolic links cause a lot of issues with directory traversals, and they aren't supported on all platforms. If we followed them, it would very likely introduce bugs, and it would break projects that rely on the current behavior.
Note that in GOPATH mode, we do follow symbolic links for specific packages (e.g., I think go list flag would work in this situation), but we don't follow links while expanding wildcards or metapackages like std. In module mode, we actually remove symbolic links from module zip files before we load packages.

@saschagrunert do you have any interest in opening an openSUSE issue?
In the meantime, it appears that you have found a workaround (download the package directly). Given that, and given that is doesn't appear there are any changes forthcoming on the cmd/go side, I'm going to close this. Feel free to comment if you think that we should re-open and discuss more.

@saschagrunert do you have any interest in opening an openSUSE issue?
In the meantime, it appears that you have found a workaround (download the package directly). Given that, and given that is doesn't appear there are any changes forthcoming on the cmd/go side, I'm going to close this. Feel free to comment if you think that we should re-open and discuss more.


Faster black bar detection by using a gpu shader

Black bar detection could be faster by executing the detection algorithm in a GPU shader. Because the transfer of GPU memory to the CPU can be avoided.

[x] WebGLContext.readPixels() could be faster than Canvas2dContext.getImageData -> Nope
[ ] Create a GPU shader of the horizontal/vertical colored/black bar detection algorithm

readPixels is just as fast as getImageData


Fixed azure and DBCE

Fixed bugs in azure and dbce connector:
Azure:
if result.service_name != 'vcycle-':
changed to:
if not result.service_name.startswith('vcycle-'):
DBCE:

Added createdTime/updated/started fields
Fixed parameter in creation log.

Thanks: I've accepted the PR. Could you double check I've resolved the conflicts correctly. Thanks, Andrew


#166178952 Fetch API Create party

What does this PR do?

Adds admin ability to register a party
Description of Task to be completed?

[x] Create add party method

How should this be manually tested?
After cloning the repository to your local machine - check
README.md for instructions. Checkout the branch ft-fetchApi-create-party-166178952 open the index.html page to serve the homepage.  Click on the sign in option use the admin logins as folows:
{
    "email"<EMAIL_ADDRESS>    "password": "2019NBO37"
}

On the dashboard navigate to create party link. Fill out the form as required and submit the form.
What are the relevant pivotal tracker stories?
#166178952

Coverage remained the same at 97.381% when pulling d8161a28abb4740a9ba8a383dad65c99f40d5e0d on ft-fetchApi-create-party-166178952 into 3c621bf6684ddc3f9688ef8451a976b78f3cf19a on develop.


@ianvs/prettier-plugin-sort-imports needed as devDependency

Describe the bug
After installing the config, a prettier run fails because @ianvs/prettier-plugin-sort-imports is missing.
I think if this prettier plugin is included as default in the config, it should be included in the docs, e.g. for installing:
npm install -D @muenchen/prettier-codeformat @ianvs/prettier-plugin-sort-imports

original error if @ianvs/prettier-plugin-sort-imports is not present as devDependency:
["ERROR" - 10:52:48 AM] Error resolve node module '@ianvs/prettier-plugin-sort-imports'
Error: Error resolve node module '@ianvs/prettier-plugin-sort-imports'

To Reproduce

use like described in https://github.com/it-at-m/itm-prettier-codeformat#installation
run a prettier format run

Expected behavior
it should use the prettier config without errors
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

fixed in https://github.com/it-at-m/itm-prettier-codeformat/releases/tag/v1.0.1


Added popup animations and reveal animations for election results

The popup animations were done using React Spring and the reveal animations were done using pure CSS.

Damn, there were a ton of just small annoying bugs that took forever to fix...

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.55%. Comparing base (1d91da2) to head (3ec8412).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   98.09%   93.55%   -4.54%
==========================================
  Files          10       10
  Lines         419      419
  Branches       72       72
==========================================
- Hits          411      392      -19
- Misses          8       27      +19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix(auth): ensure that git credentials are set in jenkins

@edewit @gastaldi I didn't change the PR, just rebased it and moved the dependency declaration to dependencyManagement.


A non-transient ConcurrencyException is retried

I have encountered this case:
 INFO --- IntervalRetryScheduler            : Processing of Command [SaveDocumentCommand] resulted in an exception. Will retry 99 more time(s)... Exception was org.axonframework.modelling.command.ConcurrencyException, An event for aggregate [a6363de6-70a2-43db-84e7-eb7af7ded2d4] at sequence [0] was already inserted

This exception is non-transient, while is treated otherwise by default.  In this case, this is my fault for not checking if aggregate already exists. Does not block me, just for your information.

Hi Sam,
interesting situation. Actually, the ConcurrenyException is Transient, and it really is, except for situations where the concurrency conflict happens with sequence 0.
In all other cases, the ConcurrencyException is resolved by loading the aggregate again, and retrying the command. However, since creation of an Aggregate will always generate a 0, in that case, retrying is pointless.
Somehow we should create a special case for this situation, for example by throwing something like an "AggregateAlreadyExistsException" when an Aggregate is created with an ID for which there already is an Aggregate (or Event Stream).


Help：Auto lock screen disconnect

After I use a wireless connection to connect to the device, the screen will be blacked out and locked automatically after a period of time without operating the screen. After the screen is locked, the device will automatically disconnect. How can I solve this problem?

Console:
D:\Program Files\scrcpy-win64-v2.0>scrcpy --tcpip=<IP_ADDRESS>:5555 --turn-screen-off --stay-awake
scrcpy 2.0 https://github.com/Genymobile/scrcpy
INFO: Connecting to <IP_ADDRESS>:5555...
INFO: Connected to <IP_ADDRESS>:5555
D:\Program Files\scrcpy-win64-v2.0\scrcpy-server: 1 file pushed, 0 skipped. 62.9 MB/s (52867 bytes in 0.001s)
[server] INFO: Device: Xiaomi M2011K2C (Android 13)
INFO: Renderer: direct3d
INFO: Initial texture: 1440x3200
[server] INFO: Device screen turned off
WARN: Device disconnected

https://github.com/Genymobile/scrcpy/issues/2995#issuecomment-1029114499
https://github.com/Genymobile/scrcpy/issues/1382#issuecomment-627591729

#2995（评论） #1382（评论）

Thank you, I changed the default configuration of USB to charging only, and the above problems did not appear.


GitHub Standards Engagement Sessions

Background

Sessions to raise awareness of standards and get feedback from Service Teams
Approach

Engage with Dev Leads for each area
Set up sessions to talk about standards
Collate feedback
Use feedback to inform how we roll standards back out.

Acceptance Criteria

[ ] Sessions organised.

Reference
How to write good user stories

Wait for Tony to get back

Stale story. We'll complete private repo work and see where we are.


Assess additional .github files

Go through some popular .github repos and directories, and determine if our default .github repo should contain any of those additional files.

Closing due to inactivity. Updates have been made in the mean time.


Extension Not Showing

When I install an extension I press "Apply and restart UI" and once it's done refreshing the extension does not show up. How do I fix this?
I'm pretty sure it should be in between "Train" and "Settings"

check the console for any error output

Where do I find the console? And how do I restart the backend?

When I install an extension I press "Apply and restart UI" and once it's done refreshing the extension does not show up. How do I fix this?
I'm pretty sure it should be in between "Train" and "Settings"

I am experiencing the same issue.  Console is an old term for a computer used to interface with a server I think. Restarting the 'backend" is the same as saying go into settings and reloading the things that you see loading in the console at startup. the GUI will go blank and say there is no connection until the console says you are good to go again.
I had an error that wasn't allowing ddetailer to load (whatever that is, idk) so I am nuking my venv folder and trying a "fresh install" of the virtual environment, in the hopes that it fixes things. Ill update here when I know.

After I managed to delete it and reinstall it worked. Thank you so much for the solution.


Replicated Heap for the HIP module

The hipHostRegister can not guarantee the same virtual address between host and gpu memory. However, the current implementation of ReplicatedHeap of the CUDA module relies on the UVA, so we can not easily copy paste the implementation from the CUDA module into the HIP module. This will affect the MultiAffineAccessor for now.

@eddy16112 please keep in mind that NVIDIA CUDA cannot guarantee the same CPU and GPU address either, it just happens to be the case for the majority of Linux systems.  See CU_DEVICE_ATTRIBUTE_CAN_USE_HOST_POINTER_FOR_REGISTERED_MEM for more information.  We should not assume the pointer passed to cuMemHostRegister is the same as the gpu one for portability reasons.

Yeah, I think we need to check if the addresses are identical, and if not, we will need to raise an error.

But you nor the user can control this, you could get intermittent errors.  Why do these need to be the same address?  Why not just do the translation before using the address on the gpu?  You cannot assume the same address across non-local CPU processors, so can we not use the same logic between local GPU and CPU processors?

That will be a question for @streichler , AFAIK, without unified address, it will be much more complicated to implement the replicated heap.

See also my test results at https://github.com/StanfordLegion/legion/issues/1646#issuecomment-1992589777
It appears that unified addresses are supported with ROCm 5.6.0 and above.

@elliottslaughter I believe this has been fixed with the new ROCm, could you please confirm and close the issue?

I'm not sure if there's a specific test you want me to do for this? It appears that I ran a test in https://github.com/StanfordLegion/legion/issues/1646#issuecomment-1992589777, which I assume would generate the same results today as the software versions have not changed (and we're effectively ROCm 5.7.1+ for all Legion users at this point).

We have a multi_affine test that will test the replicated heap https://gitlab.com/StanfordLegion/legion/-/blob/master/test/realm/CMakeLists.txt#L85


Use unix.Ioctl{Get,Set}Termios on all unix platforms

Unify the implementation for all unix platforms to use IoctlGetTermios
and IoctlSetTermios from the golang.org/x/sys/unix package instead of
implementing it in terms of SYS_IOCTL. This avoids duplicating code,
makes error handling easier and fixes the build on darwin where direct
syscalls, i.e. unix.Syscall(SYS_IOCTL, ...) are no longer allowed and
exported as of golang/sys@6fcdbc0bbc04
Also fix a build issue with GOOS=solaris and bump the
golang.org/x/sys/unix dependency.
/cc @thaJeztah

@kolyshkin @cpuguy83 PTAL

Thanks for the review @kolyshkin! Changed according to your comments, PTAL.

@kolyshkin — is this good to merge? I'd love to see it merged.

Thanks 👍


html template inline scripts import statement fetching another script don't seem to resolve in output html files

It appears that if I have inline script such as shown below in my html template file, then the output html file still has the path ../scripts/someScript.js instead of changing this to HtmlBundlerWebpackPlugin js.filename that is changing the path that would point to output asset js files.
Does HtmlBundlerWebpackPlugin support resolving these kind of import statements in html templates?

@sam1git,
The code  in  tag stay as is, w/o transformation. This is right so.
If you want use import and other non-standard JavaScript constructions, you should do it in separate JS file, that will be compiled via Webpack.
If you want compile all-in-one HTML file, you can use the js.inline and css.inline options.
See please:

How to inline JS in HTML
How to inline CSS in HTML

For example:
myLib.js
const content = 'Hello World!';
export default content;

main.js
import content from './myLib.js';

console.log(content);
document.getElementById('root').innerHTML = content;

index.html
<!DOCTYPE html>

    <title>Home</title>

Add js.inline and css.inline options:
const HtmlBundlerPlugin = require('html-bundler-webpack-plugin');
module.exports = {
  plugins: [
    new HtmlBundlerPlugin({
      entry: {
        index: 'src/index.html',
      },
      js: {
        inline: true,  // inline compiled JS into HTML
        filename: 'js/[name].[contenthash:8].js', // JS output filename, used if inline is false
      },
      css: {
        inline: true,  // inline extracted CSS into HTML
        filename: 'css/[name].[contenthash:8].css', // CSS output filename, used if inline is false
      },
    }),
  ],
};

The generated HTML contains inlined JS code:

P.S. please use the language casting after leading 3 backticks: html, js, css, scss, etc to highlight you code snippet.

@sam1git,
The code in  tag stay as is, w/o transformation. This is right so.
If you want use import and other non-standard JavaScript constructions, you should do it in separate JS file, that will be compiled via Webpack. If you want compile all-in-one HTML file, you can use the js.inline and css.inline options.
See please:

How to inline JS in HTML
How to inline CSS in HTML

For example:
myLib.js
const content = 'Hello World!';
export default content;

main.js
import content from './myLib.js';

console.log(content);
document.getElementById('root').innerHTML = content;

index.html
<!DOCTYPE html>

    <title>Home</title>

Add js.inline and css.inline options:
const HtmlBundlerPlugin = require('html-bundler-webpack-plugin');
module.exports = {
  plugins: [
    new HtmlBundlerPlugin({
      entry: {
        index: 'src/index.html',
      },
      js: {
        inline: true,  // inline compiled JS into HTML
        filename: 'js/[name].[contenthash:8].js', // JS output filename, used if inline is false
      },
      css: {
        inline: true,  // inline extracted CSS into HTML
        filename: 'css/[name].[contenthash:8].css', // CSS output filename, used if inline is false
      },
    }),
  ],
};

The generated HTML contains inlined JS code:

P.S. please use the language casting after leading 3 backticks: html, js, css, scss, etc to highlight you code snippet.

sounds good, appreciate the help.


Handling Shutdown on Kubernetes

When running on Kubernetes, there is uncertainty regarding the order of processing between iptable changes and SIGTERM, which may lead to a situation where routing is closed immediately after receiving SIGTERM, causing new requests to receive a 503 error. We have confirmed that using preClose in fastify does not have any effect since all routing is already closed at that point.
I wanted to introduce a few seconds of wait time using fastify.gracefulShutdown, but it seems ineffective because the handlers using fastify.close are executed in parallel.
Alternatively, should I consider solving this issue by using the preStop container lifecycle hook in Kubernetes to introduce a sleep period?

Translated from Japanese
k8s上で動かす場合において、iptable変更とSIGTERMはどちらが先に処理されるか不明なため、SIGTERMが送られた直後にルーティングが閉じると新しいリクエストが503になる可能性がある。
fastifyのpreCloseはフックされた時点で全てのルーティングが閉じているため、preCloseに待機時間をいれても効果がないことは確認しています。
fastify.gracefulShutdownで数秒の待機時間を入れたいと思ったのだが、fastify.closeをしているハンドラーが並列で実行されているためうまくいかない。
それとも単純にk8sのcontainer lifecycle hooksのpreStopでsleepさせることで解決するべきでしょうか？

Thank you for your reply!
Unfortunately, it seems that this issue is quite rare, and I haven't been able to come up with a reliable way to reproduce it.
After giving it some thought overnight, I concluded that using the preStop sleep feature in Kubernetes would be the appropriate way to handle this problem.


apt-get install picap "E: Unable to locate package picap"

On a raspberry pi 2 I followed the instructions at "Setting up your Pi Cap on the Raspberry pi 1, 2, or 3...". But it would seem that your package is missing. I also did apt-cache search picap and it returned with zero results.

Hi Nicholas,
We'll have a look into it, in the meantime could you send us an email to<EMAIL_ADDRESS>Could you specify which version of Raspbian you are using?
Thank you!
Pascal

Hello,
I am having the same issue as @mosspassion
I'm unable to access the pi cap package.
Can you please help me resolve this?


Docs: Add info on what "cdk bootstrap" creates.

Is the user on the hook for any costs?
What do we create for them?
Do we have a list?
If they decide to no longer use the CDK, how do they delete these resources?

Do you need this info, or are these notes for yourself?

I need the info, hence the "needs contributors" label.

Here's what we create:
https://github.com/awslabs/aws-cdk/blob/master/packages/aws-cdk/lib/api/bootstrap-environment.ts#L14
Today it's a Bucket. They pay for what's in there. We don't clean it currently, so it accumulates.
In the future, we'll probably add ECR repositories. They will pay for what's in there as well.
In the future, we'll probably add a Lambda function that executes on a schedule. They will pay for the executions, but the Lambda function's gonna clean up unused resources, so that should save them some money.
They get rid of it by deleting the CDKToolkit stack from their account.

Thanks. I'll create a draft soon and send it out for review.

Here's what I have so far:
Bootstrapping the CDK
Before you can use the CDK you must bootstrap the CDK to create the infrastructure that the CDK needs. Currently the bootstrap command creates only an Amazon S3 bucket.
You incur any charges for what the CDK stores in the bucket. Because the CDK does not remove any objects from the bucket, the bucket can accumulate objects as you use the CDK. You can get rid of the bucket by deleting the CDKToolkit stack from your account.

Yep, good for now.

The part about it that I don't like is that it will just invite more questions. But I guess those are the ways.

Yep, opening Pandora's box.

See https://docs.aws.amazon.com/CDK/latest/userguide/tools.html#tools_bootstrap

What about adding a cdk bootstrap --destroy possibility (https://github.com/aws/aws-cdk/issues/986#issuecomment-432178288)? I think it would be much more intuitive than having to delete the CloudFormation stack from the AWS console.


Fleshing out the warehouse initialization

Creates the warehouse initialization, and the transition manager.

@TonyB9000 if you want to give this a test, go ahead and pull down the branch. Since the startup needs to go out to ESGF for the status of all the datasets, it can take a little while if it goes over all the datasets. You can limit the datasets that it selects by passing a substring of the dataset_ids to look for, so for example:
 python -m warehouse auto   --dataset-id E3SM.1_1_ECA.ssp585-BDRD. -s
will just run the 10 datasets from the given case. It doesnt do anything yet besides find the current state of each of the datasets.

@TonyB9000 if you want to give this a test, go ahead and pull down the branch. Since the startup needs to go out to ESGF for the status of all the datasets, it can take a little while if it goes over all the datasets. You can limit the datasets that it selects by passing a substring of the dataset_ids to look for, so for example:
 python -m warehouse auto   --dataset-id E3SM.1_1_ECA.ssp585-BDRD. -s
will just run the 10 datasets from the given case. It doesnt do anything yet besides find the current state of each of the datasets.


Tokens: average consumed gas and methods count

Token interfaces are defined in the only one place

 TQ: Stats / FA


Oscilliating behavior in Optical GF calc with Ver3 nuPyProp tables

When performing POEMMA360 and SPB2-360 energy scans, an oscillating behavior is seen the optical GF results vs energy for the POEMMA360 (525 km orbit) where the results deviate if not at half decade in energy (see attached). The neutrino aperture does not show this.  The SPB2-360 case does not show this in either the GF (but fluctuations do exist in the ratio) or neutrino aperture.
nuSpaceSimApers-COMP-OpticalGF-poemma360-7deg-escan-v1p2p5_vs_poemma360-7deg-v1p2p7.pdf
nuSpaceSimApers-COMP-OpticalnuAper-poemma360-7deg-escan-v1p2p5_vs_poemma360-7deg-v1p2p7.pdf
nuSpaceSimApers-COMP-OpticalGF-spb2_360-6p4deg-escan-v1p2p5_vs_spb2_360-6p4deg-v1p2p7.pdf
nuSpaceSimApers-COMP-OpticalnuAper-spb2_360-6p4deg-escan-v1p2p5_vs_spb2_360-6p4deg-v1p2p7.pdf

After discussion with @jfkrizmanic and @tventers we discovered a potential culprit for this behavior. It's likely caused by an artifact in the new (v3) nupyprop cdf tables, or the method used to interpolate values within them. The new npp tables only materialize half-decade entries in log_e_nu grid column (previously quarter-decade entries were materialized). The oscillatory behavior is only visible in these quarter decade regions. This suggests the interpolation scheme, designed for and employed successfully on quarter-decade tables, is improperly sampling the provided CDF tables.


Link fixed..

updated sample.json incase we need to do a major update later

Shall I let you merge, @kalyankrishna1 ?


update spec compliance matrix

Tables have been added for context, resources, and exporters. We should fill these out when we get a chance.

Fixed in https://github.com/open-telemetry/opentelemetry-specification/pull/978

This is done.


Correct setup documentation and fork me link.

Hello folks,
I was trying to setup a New Calico infrastructure and, for that, I need an  Etcd server running. Reading the https://coreos.com/etcd/docs/latest/docker_guide.html link, I just discovered that the correct command to run the container is:
[...] --name etcd quay.io/coreos/etcd etcd -name etcd0 [...]
Instead of:
[...] --name etcd quay.io/coreos/etcd  -name etcd0 [...]
Alas, the link of the "Fork Me Link" is pointing to https://github.com/coreos/etcd/tree/master/Documentation/docker_guide.md, which gave 404 Errors.
With this in mind, I know that is a simple correction, but from a starter point of view it can be troublesome ...
PS: The CMD is /usr/local/etcd, but to run with the container and receive the args I think that the image need to use ENTRYPOINT instead. No? If not, why the command provided in the documentation wont work?

Sorry, coreos.com docs are not up-to-date. It's in our queue.
In the meantime please try the docker guide here https://github.com/coreos/etcd/blob/master/Documentation/op-guide/container.md

@gyuho Just in time: There is support for calico on docker 1.12? I'm trying to use it, but I'm receiving "plugin not found" even if my vm's are not operating in swarm mode.

@gyuho Is this fixed?

@xiang90 Not yet. I will send a PR to fix it.

OK. Thanks.

I reported this to our UI team. Closing. Will keep you updated once fixed. Thanks!


use Foreignkeys as Primarykeys

Hi,
I wanted to use two foreign keys as a composite primary key. The problem is, that during compile time I get the error that it can't find TASK and TAG (task and tag are the names of the fields). Looking at where the error happens, it tries to get the column names from TaskTag$Table.TASK and TaskTag$Table.TAG.
Does this not work or do I need to set anything additionally? I simply added the @PimaryKey annotation to the fields.

Currently primary keys as foreign keys are not supported. It's more better design to leave them as foreign keys and use an Autoincrementing primary key instead. You can make them part of a @UniqueGroup I believe to enforce uniqueness.

@agrosner actually, you can't make them unique, it doesn't work. See this for reference: https://github.com/Raizlabs/DBFlow/issues/142

fixed in develop, now primary key as foreign key works.


add snowpack or base data

Right now we're using a weather forecast api that returns only forecast data. we need to layer in what the resorts are reporting for base snow pack. There is probably an API that will get all of this (like onthesnow or something).

http://docs.clientservice.onthesnow.com/


v55 Update

Hi there, I messaged on Discord about the source for the plugin, in order to fix for v55 update.
In my testing, the only issue in the code that I happened across, was the PlayerControllerB.KillPlayer part of the Class1.cs file, while in Versions <= v50, using just the body velocity seems fine, but in v55, this no longer works. Noting this, I took a look at the standard gamecode used for killing a player, and just by adding the bool for spawn body (true), setting CauseOfDeath to Gravity (this seemed to fit more since Physics apply up), and setting the death Animation to 0, fixes the issue.
Tested on v55 Beta public Branch, All effects work as intended, no major issues cropped up in a quick test of each CC Interaction.

Done some additional testing with friends locally on discord over the last few hours, all seems okay now. Will work on additional features tomorrow, but this should be fine to push to add preliminary support.

Regarding Coil Heads, they seem to work most of the time, however, there are occasions where spawning will fail, and lead to users being refunded. Old Birds spawn as expected in all instances.

I'm gonna close this, clean it up and reopen a new PR, there's been a few changes on my side, and this is looking a bit messy for me. Will document changes.


Infix to Postfix Algorithms

Description:
Infix to postfix conversion and evaluation using stack
It comes under applications of stack algorithm
Checklist:

I Contributor in GSSoC-ext
I Want to work on it

Additional Information:
Postfix notation, also known as Reverse Polish Notation (RPN), is used to make it easier for computers to evaluate expressions. Here are some advantages of postfix notation

@pankaj-bind I want to work on it. Please assign me this

I am a Contributor in GSSoC-ext. Please assign it to me

I would love to work on the Infix to Postfix Conversion task. I have experience in C and data structures like stacks, and I believe I can complete this task efficiently. Please assign it to me.

@Salini-sat you can start


Mesos Backend Incorrectly Configures Hostname for Host IPSource

Do you want to request a feature or report a bug?
Bug.
When you setup the mesos backend, the generated config files results in
the backend.url field being set to something like "http://:47675" when you
set IPSource to host.
Traefik uses mesosphere/mesos-dns@b47dc4c19f215e98da687b15b4c64e70f629bea5 to
easily communicate with mesos, however it doesn't fully bootstrap the
configuration with something mesos-dns expects. When Traefik retrieves the
list of running tasks from Mesos it manually sets task.SlaveIP to slave.Hostname.
https://github.com/containous/traefik/blob/c66d9de759b4bdebf8e170539eac1bcdd1295894/provider/mesos/config.go#L82-L86
The problem is task.IP() expects task.SlaveIP to be an actual IPv4 or IPv6, not
a hostname. As a result it tries to parse the hostname as an IP, but fails,
resulting in an empty string as the hostname.
https://github.com/containous/traefik/blob/c66d9de759b4bdebf8e170539eac1bcdd1295894/provider/mesos/config.go#L207-L209
Traefik should either be using slave.PID.Host or a special case in getHost to
properly get the hostname for the task.
What did you do?
Set up Traefik to use the Mesos Backend
What did you expect to see?
The host IP in the backend url.
What did you see instead?
An empty string in the place of an IP address.
Output of traefik version: (What version of Traefik are you using?)
containous/traefik@c66d9de759b4bdebf8e170539eac1bcdd1295894
What is your environment & configuration (arguments, toml, provider, platform, ...)?
[entryPoints]
  [entryPoints.http]
  address = ":80"

[mesos]
endpoint = "zk://zoo1:2181/mesos"
watch = true
domain = "mesos"
filename = "/mnt/mesos/sandbox/mesos.tmpl"
IPSources = "host"

I see this issue was reported 7 months ago in #1618, but it was closed. I'm guessing the mesos backend is deprecated or not well supported?

@nemosupremo my personal impression is that we happen to have a fairly low number of Mesos users, which may an impact on the quality of the provider. In contrary, quite a number of users run Mesos on top of Marathon which has fairly solid support.
Would you have a chance to run on Marathon, or is Mesos a must-have for you?

We would prefer to use Mesos as we'd like to use Traefik to route to Spark drivers we run on Mesos. I ended up fixing this specific issue in my own fork, as well as adding other functionality to make Mesos template generation a bit easier.
Next, I'm a bit less confident in the Marathon API as I feel Mesosphere puts more effort behind DC/OS and aspects of Marathon have been less than stellar. Currently Marathon 1.5.0+ doesn't even work with Traefik (#2115) because of a backwards incompatible API change.

Closed by #2590.


[FLINK-2456][fix]add a repository ID for hadoop2 in flink-hbase module

add a repository for hadoop-2 in flink-hbase.
It can be downloaded through a specified mirror like:

repo2
Human Readable Name for this Mirror.
http://repo2.maven.org/maven2/
hadoop-2-repo2

Or it will not affect the normal network environment when default.

Thanks for providing this path!
Can you help us understand this fix a bit? Why is this extra repository entry required for the HBase module, and not for any other modules?

This is just a method to solve the problem that some modules' dependencies cannot be downloaded from central maven repository.
You can specify every module dependency ID so that we can downloading dependencies from either central maven repository by default or other channel by setting maven mirrors when mvn package.
As for HBase, it`s just that I get some trouble in downloading this module dependency.
And sorry for the url.
I just want to push a example about maven mirror on the comment but it was blocked because of the XML format.
This complete code should be like this:
"<mirror>"
    "<id>repo2</id>"
    "<name>Human Readable Name for this Mirror.</name>"
    "<url>http://repo2.maven.org/maven2/</url>"
"<mirrorOf>hadoop-2-repo2</mirrorOf>"
"</mirror>"

The repository you add is the default Maven repository - it should be used by default anyways.
Is the change there override your mirror repository for HBase with the default repository?

The most important In the HBase pom.xml I add is the repository ID:
""
"	"
"		hadoop-2-repo2"
"					https://repo.maven.apache.org/maven2"
"					"
"						true"
"					"
"					"
"						false"
"					"
"				"
"			"
By using this id, you can get the hadoop-2 from any way(for example using mirror with this ID).
The default repository is the url(https://repo.maven.apache.org/maven2) above.
And the default means you need not do anything with maven configuration just print "mvn package".
As I see, every flink dependency is using this url.
Did I misunderstand? Is the hadoop-2 default repository path is another?

The most important In the HBase pom.xml I add is the repository ID:
""
""
"hadoop-2-repo2"
"https://repo.maven.apache.org/maven2"
""
"true"
""
""
"false"
""
""
""
By using this id, you can get the hadoop-2 from any way(for example using mirror with this ID).
The default repository is the url(https://repo.maven.apache.org/maven2) above.
And the default means you need not do anything with maven configuration just print "mvn package".
As I see, every flink dependency is using this url.
Did I misunderstand? Is the hadoop-2 default repository path is another?

The most important in the Flink-hbase pom.xml I add is the repository ID:
""
By using this id, you can get the hadoop-2 from any way(for example using mirror with this ID).
The default repository is the usl(https://repo.maven.apache.org/maven2) above.
And the default means you need not do anything with maven configuration just print "mvn pakcage".
As I see, every flink dependency is using this url.
Did I misunderstand?Is the hadoop-2 default repository path is another?

The most important in the Flink-hbase pom.xml I add is the repository ID:

By using this id, you can get the hadoop-2 from any way(for example using mirror with this ID).
The default repository is the usl(https://repo.maven.apache.org/maven2) above.
And the default means you need not do anything with maven configuration just print "mvn pakcage".
As I see, every flink dependency is using this url.
Did I misunderstand?Is the hadoop-2 default repository path is another?

I understand.
Will merge this...

Thank you for taking the time to explain the reason behind this issue...

My plessure.


Is it possible to implement all day on an event

Hey thanks for the great library.
Im wondering is there anyway to a full day event.
With the all day bar up the top.
Something like this

If it's not possible
Let me know what it would take to have this feature and I can take a look
Thanks

Unfortunately, this feature has not yet been implemented.
Anyone who needs this feature, please give it :+1:. If the feature is popular, I will implement it.

We are see day list on the top right with buttons. Is this button not good for you ?

Unfortunately, this feature has not yet been implemented.
Anyone who needs this feature, please give it :+1:. If the feature is popular, I will implement it.

Vkurko, how can I click button and add new calendar event i cant do this
Can you make a demo for me ?
For example I want to click button add 14.00 - 17.00 event than im using now add calendarr event save than page refresh i dont want to this

For example I want to click button add 14.00 - 17.00 event than im using now add calendarr event save than page refresh i dont want to this

I'm assuming the events are being fetched from the server. In this case, you are doing everything right, but instead of reloading the page, you need to call refetchEvents().

If its possible could you even show how to go about doing something like this where to look in the code ect..
and I could maybe make a PR.

This should definitely be in the time-grid plugin. You may also want to look at the FullCalendar's implementation and its options for it.

Hey thanks @vkurko
I've started taking a look at this in more depth.
In terms of adding the all day functionality.
It be great if you could let me know if Im heading in the right direction or if you have different ideas of the implementation of this.
I currently have a setup here locally for just testing a few things.
Some things that seem abit more complex is things like.

Dragging from all day back into a time range.
Correctly positioning of elements that are multiple days long (grouping them and displaying them across the days)
Resizing so that the all day can only be moved across the days when it is an all day event.

I have a very rough draft PR here and Im wondering your thoughts on doing something like this or if you have different ideas.
It be great to have this feature.

New component for the All Day Body for all the
New All Day component which filters on the all day events only

I have a very rough PR here.
https://github.com/vkurko/calendar/pull/42
https://www.loom.com/share/2c48a9baf8124e47ae3d27aa6f93ffe5

Hi @conoroshea1996
It's a great start! I think you are moving in the absolutely right direction.

Dragging from all day back into a time range.

Let's start small and not implement this feature :smile:
Yeah, FullCalendar has a really cool thing about dragging an event from the all-day section to the hourly one. But this will require the implementation of additional options like allDayMaintainDuration, defaultAllDayEventDuration and so on. In addition, I did not find such a feature in Google Calendar.
So I think it's ok to do just a drag and drop within the all-day section to start with.

Correctly positioning of elements that are multiple days long (grouping them and displaying them across the days)

It seems that the all-day section should be very similar to the month view. There is an algorithm[1][2] for arranging intersecting events. Maybe we can somehow share this logic between these two views.

Resizing so that the all day can only be moved across the days when it is an all day event.

This also looks like a thing that should work the same as in the month view.

In addition to the above, I would also change isAllDay to allDay as it is called in FullCalendar. And I would also remove the pointer event from the all-day section as it doesn't make much sense there.

Other than that, I think it's a great start. Keep it up!

Hey @vkurko
Great thanks very much for the quick response and feedback.
I'll keep going this way

Let's start small and not implement this feature 😄

That sounds good I think the dragging from all day to the hourly one isn't worth all the extra effort its not something we need need either at the moment so I'll forget about that  feature😄

It seems that the all-day section should be very similar to the month view. There is an algorithm[1][2] for arranging intersecting events. Maybe we can somehow share this logic between these two views.

Great I'll take a look at those some more and see if that works. Thanks for pointing me into the right direction.

In addition to the above, I would also change isAllDay to allDay as it is called in FullCalendar. And I would also remove the pointer event from the all-day section as it doesn't make much sense there.

Noted will updated this also
I'll keep going this way thanks again for the help

Hey @vkurko
I have made  a few changes to the all day bar.
I've made it similar to how the month view is working now as I think that makes sense?
Would it be possible to have a look at this PR.
Its still abit rough at the moment so I'll do some more cleaning up of it. (There's a few changes I have for running locally)
But Im wondering if you'd be happy to add something like this.
A Demo of it here for you to see
https://www.loom.com/share/34e3d2dc0f9349628e8c669e06f06254
Thanks

It looks nice. What about resource view?
Having realized that all-day is essentially a special case of the month view, I think I should refactor the day-grid plugin so that it can be used in time-grid/resource-time-grid without having to duplicate code.
Unfortunately, I don't have enough free time for that right now. But if you can finish your current code, I'll take the PR and do the refactoring myself later.

Hey thanks again for the response.
I've handled the resource view as there now as well.
Example
https://www.loom.com/share/f8b8c4c1cc5f49048b4c265123b04165
I agree there's definitely some unnecessary code duplication being done at the moment.
I don't have a deep enough knowledge of the code base to handle cleaning that up and refactoring sorry about that.
That would be great once you have some free time if you could take a look through that PR
Hopefully it gets some of the extra work done for you.
Its a feature we need for our application currently
I can't spend to much more time on it but hopefully this helps.
Thanks for the replies and for the nice library

if you could take a look through that PR

I'm going to merge it now, and review and refactor it later. Thanks for yout help!

No worries. Happy to help
Great thanks sounds good.
Yeah it could do with a good once over and review.
Let me know if I can do anything else to help.

Hey,
Just wondering would it be possible to release a beta version on to npm of what's currently on master branch.
So we could test out the new feature a bit in our application.
If not no worries.
Thanks again.
😃

Hi Conor. I hope to be able to make time for the calendar tomorrow.

Hey Vladimir that's great thanks for the update.
Sorry for all the messages as well if Im annoying you.

Hey @conoroshea1996
Unfortunately, I had very little time today, so the big refactoring did not happen. However, I still released a new version of the calendar (0.11.0). Please take a look at the new options allDayContent and allDaySlot.
Have a nice weekend :smile:

Hey @vkurko
That looks great nice aswell too add the option docs look good too.
Thanks for your time for releasing a new version
it's very much appreciated.
Thats brilliant to have that added now
Have a great weekend  😃🥳

I hope I can close this issue.

Ahh yes this issue is solved and thanks again for your hard work


Issue re44 part2 copy button

OK all the required implementations have been tested in yarn start after the conflict resolution, looks good to go!


change the name of kosmos-operator to clusterlink-operator

What would you like to be added:
The current functionality of kosmos-operator is quite singular, being only used for deploying the clusterlink service, thus it isn't appropriate to call it Kosmos-operator.
Why is this needed:
we also need to introduce a new operator for creating the control plane of k8s and Kosmos, so we need to change the current Kosmos-operator to clusterlink-operator.

/cc @ONE7live
/cc @OrangeBao


Fix ReferenceList ctor invocations with missing filterCurrentCommit values

Fixes this:

Also: Couldn't we just use mCommit.isValid() instead of filterCurrentCommit?

Also: Couldn't we just use mCommit.isValid() instead of filterCurrentCommit?

filterCurrentCommit is maybe the wrong word. Limit to current commit maybe better?
Could it be a usecase were a commit is provided and we would not like to limit to the current commit?
If we create a new branch we would like to use the current commit as base. I have to test what happens

I'd argue that the reference dropdown for creating a new branch only makes sense if you create the branch from somewhere other than the commit list


minor update the doc for docker env and custom_lib dir

Proposed changes

Update the doc for apache/doris:build-env-for-2.0
Update the doc for custom_dir

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


[FLINK-23055][docs][table] Add documentation for window tvf offset.

What is the purpose of the change
The pr adds documentation for window TVF offset.
Brief change log
window-tvf.md
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (docs)

@wuchong Thanks a lot for review, I've updated. Please have a look again, Thanks.


Windows Firewall

In my experience two Windows Firewall rules called "teams.exe" to ALLOW, not BLOCK as documented here, both TCP and UDP for the program.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6457d204-d229-9154-28fd-ca9bbb4bddcd
Version Independent ID: f5d82846-41cb-3548-6997-ce23bd8f89c6
Content: Get clients for Microsoft Teams
Content Source: Teams/get-clients.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

Any updates on this? We are trying to deploy this in a enterprise environment with 500+ employees and been placed on hold until this is fixed due to this behavior when we deployed it to a test group of 50 employees.

Thanks for providing a Powershell script, however that opens a new can of worms. By default remote and local Powershell execution is disabled, unless explicitly enabling it via GPOs. It is disabled by default for a reason, and allowing this can potentially allow any malicious Powershell scripts to run on all PCs.

Further to this, in the Powershell script provided the cmdlet "Get-NetFirewallRule" does not exist for Windows 7 computers. This should be stated in the script to avoid confusion.

@cliffhobbs can you please address this issue?

@juanand  Thank you very much for posting this issue. Considering the nature of the issue, it is advised that please open a service ticket in your tenant and follow with them for the resolution. If you wish to know how to open the service ticket, please follow this link https://www.youtube.com/watch?v=puuOy0sEg1Y
We will be very happy if you can share the outcome or resolution with us. We will certainly update this documentation with your valuable piece of information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


docs(databases): add Atgenomix SeqsLab as the supported database along with db engine spec

SUMMARY
This PR is for #25093
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Closing/re-opening to kick-start CI. This looks generally good to me, but someone like @betodealmeida might be more qualified to scrutinize the db engine spec.

@allen-chang this seems to need a rebase, otherwise we would have merged it. Hoping we can get it across the finish line!

Hmm... I don't think the rebase went as planned. Rebasing on current master will hopefully clear up all the files/commits seen here.


Gather SigStore signatures where possible.

I'd like to understand what idea we have around this, what we want, and what we want to offer. I think there's also the topic of "classic signatures", that we have, and ignore for the moment.
I could imagine that we:

Ingest signatures alongside the ingested document (1 -> n) – classic signatures
Discover signatures after a document was ingested (1 -> n) – sigstore
Validate signatures (what happens is that fails?)
Allow users to set up trust anchors for validating signatures


Actions

This PR takes care of #11.
It implements:

support for actions as icons (#13)
an overflow button and menu component (#14)
a base layout for actions (#15)
the concept of action visibility for icons
the concept of collapsibility to switch from icon to overflow menu item
dedicated preferences:

display order of the base layout
for each action:

their visibility (always|partially|overflow)
their collapsibility (boolean)
their shortcut (string or JSON template using a PlatformKey)

an helper to determine the PlatformKey (ctrlKey or metaKey)

@bluefirepatrick Thanks for taking the time to test and report this! Appreciated.


Add small mention to --lab flag

What
Mention an already existing --lab flag in the shell_plus docs
Why
It's a useful feature and easy to miss if one is not actively looking for it

This seems useful to add to the docs. I didn't know about this until i saw https://github.com/django-extensions/django-extensions/issues/1835


Update the website to point to v4 docs

keystonejs.com now resolves to the same website as v5.keystonejs.com. This removes the word alpha and provides a link to v4.keystonejs.com for people looking for this.
There is a similar PR for the old website to reference v5.
In a future PR we will update all the links and references to alpha when the packages change.

Does this mean v5 is moving out of alpha and is ready to start use in production projects?

Does this mean v5 is moving out of alpha and is ready to start use in production projects?

Yep! We're in the process of moving out of alpha in the coming days. There are various housekeeping things to do to make this happen, and the website is one of them. You'll see more PRs like this landing in the coming days and once we're happy that everything is all running smoothly we'll make an announcement. 🎉


求解决：登录过程验证码已经识别过了，登录请求返回tresult: {'code': 99999, 'message': '重试次数达到上限'}，网页上登录没有问题！

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

+1

更新105版本，改用selenium试试

+1


Bug? The setState callback isn't being called.

I have setState(state, callback) called from componentWillMount(), but the callback isn't being called as I'd expect.
Does Next somehow prevent this?

We don't do anything special. Could you send us a sample repo?

I somehow managed to get it working, and made the mistake of changing lots of things, so I'm not sure what my problem was. But, it appears it's not a Next bug, which is good :-).


 We’ll want to add some kind of js trigger to close those note popups on clickaway.

There are a few issues here:

Popovers do not dismiss on click away
Multiple popovers can be open at a time

By the plus sign icon (which pops up the note), I mean this:


[BEAM-5960] Revert "[BEAM-5817] Add Java only BoundedSideInputJoin benchmark

This reverts commit a62314eb80b3ff1d69940656aa4f5aa9f9394e9e.
The existing Nexmark runs scrape through the enum values and it is
trying to run it before it is ready. Rolling back while I fix it to be an explicit whitelist.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

run Direct Runner Nexmark Tests

Ah, no phrase triggering so we can't confirm signal.

Confirmed failure of the SMOKE suite on direct runner on master: https://scans.gradle.com/s/uscfucywf5dsg/
Confirmed succes after this: https://scans.gradle.com/s/xhd6sebzmpgys

Because it is a build break rollback, submitting then getting LGTM.

LGTM


Annotation in the papercannot be synchronized to my database

When I sync the annotated notes to notion, it already shows that the synchronization is successful, but there is no content in my database, the key is that the relevant notes or notes I have added tags such as Relevance or Problem or Purpose (note: paper is fine)

Hi @positivist1, I actually just released initial support for syncing notes/annotations. (See #4)
Would you mind following the usage instructions in the release notes for v0.4.8 and letting me know if you're able to sync annotations to Notion?

Hi @dvanoni ，now I can sync annotation to notion. Thank you very much!!

Hi @dvanoni ，now I can sync annotation to notion. Thank you very much!!

Great! @positivist1, are you good with closing this issue?

yes@dvanoni


Add installation functions

Should add installation for
1.go get
2. pip install
3. shell
4. wget binary

Function has been added


Minor documentation fix Structured Streaming Programming Guide

What changes were proposed in this pull request?
Update the python section of the Structured Streaming Guide from .builder() to .builder
How was this patch tested?
Validated documentation and successfully running the test example.
Please review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark before opening a pull request.
'Builder' object is not callable object hence changed .builder() to
.builder

Can one of the admins verify this patch?

Thanks - merging in master/branch-2.1/branch-2.0.


displaying social sign/register buttons (ie facebook) for mobile cordova

I am trying to use useraccounts:ionic to login/register using facebook via cordova plugin.
When I use using useraccounts:ionic and accounts-facebook package, the facebook register and sign buttons are displayed in the android app created. However, I can not get it to display if I replace accounts-facebook package with particle4dev:cordova-fb or  btafel:accounts-facebook-cordova . Is there a way to explicitly show the social buttons?

Seems to work once its externally deployed


[SPARK-27811][Core][Docs]Improve docs about spark.driver.memoryOverhead and spark.executor.memoryOverhead.

What changes were proposed in this pull request?
I found the docs of spark.driver.memoryOverhead and spark.executor.memoryOverhead exists a little ambiguity.
For example, the origin docs of spark.driver.memoryOverhead start with The amount of off-heap memory to be allocated per driver in cluster mode.
But MemoryManager also managed a memory area named off-heap used to allocate memory in tungsten mode.
So I think the description of spark.driver.memoryOverhead always make confused.
spark.executor.memoryOverhead has the same confused with spark.driver.memoryOverhead.
How was this patch tested?
Exists UT.

Test build #105660 has started for PR 24671 at commit ef6c505.

Can one of the admins verify this patch?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10914/
Test PASSed.

Test build #105660 has finished for PR 24671 at commit ef6c505.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105660/
Test PASSed.

Test build #105674 has started for PR 24671 at commit d018b35.

Test build #105674 has finished for PR 24671 at commit d018b35.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

I think the proposed new description is inaccurate because interned strings and native overheads (e.g. Netty direct buffers) aren't allocated outside the executor process, per se (since off-heap memory is still in the JVM's own process address space).

Thanks for your review. Yes, I ignored the detail off-heap memory is still in the JVM's own process address space.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105674/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10930/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10931/
Test PASSed.

Test build #105676 has started for PR 24671 at commit 554caa2.

Test build #105676 has finished for PR 24671 at commit 554caa2.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105676/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10932/
Test PASSed.

Test build #105677 has started for PR 24671 at commit 2fdc94f.

Test build #105677 has finished for PR 24671 at commit 2fdc94f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105677/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10934/
Test PASSed.

Test build #105679 has started for PR 24671 at commit 2c89b42.

Test build #105679 has finished for PR 24671 at commit 2c89b42.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105679/
Test FAILed.

Test build #105682 has started for PR 24671 at commit 3f79e89.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10937/
Test PASSed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10941/
Test PASSed.

Test build #105686 has started for PR 24671 at commit 3f79e89.

Test build #105682 has finished for PR 24671 at commit 3f79e89.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105682/
Test FAILed.

Test build #105686 has finished for PR 24671 at commit 3f79e89.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105686/
Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10966/
Test PASSed.

Test build #105710 has started for PR 24671 at commit 3f79e89.

Test build #105710 has finished for PR 24671 at commit 3f79e89.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105710/
Test PASSed.

@JoshRosen I have changed.

Test build #105812 has started for PR 24671 at commit c4ab8a9.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11069/
Test PASSed.

Test build #105814 has started for PR 24671 at commit f96f936.

Test build #105812 has finished for PR 24671 at commit c4ab8a9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105812/
Test PASSed.

Test build #105814 has finished for PR 24671 at commit f96f936.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105814/
Test PASSed.

Test build #105854 has started for PR 24671 at commit 1f31fc6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11110/
Test PASSed.

Test build #105854 has finished for PR 24671 at commit 1f31fc6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105854/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11142/
Test PASSed.

Test build #105886 has started for PR 24671 at commit f23c1b7.

Test build #105886 has finished for PR 24671 at commit f23c1b7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105886/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11191/
Test PASSed.

Test build #105939 has started for PR 24671 at commit 5dbbf4a.

Test build #105939 has finished for PR 24671 at commit 5dbbf4a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105939/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11202/
Test PASSed.

Test build #105950 has started for PR 24671 at commit 7980652.

Test build #105950 has finished for PR 24671 at commit 7980652.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105950/
Test PASSed.

@JoshRosen Could you review this PR again and find other issues?

Merged to master

@srowen Thanks for your merger. I thought that two change requested need every one to agree.
@JoshRosen Thanks for your detailed review.


Module aliases fail to resolve in workspace setup with browser config

Describe the bug
I'm trying to configure a monorepo workspace project from the root with all config in vitest.workspace.ts. My intent is to run the entire test suite in different environments to verify cross-platform compatibility. I want to configure this in the workspace config directly for more fine grained control instead of using cli options.
The bug is that any browser configuration (no matter which provider is used) fails to resolve module aliases if they are configured from the workspace root. It works if they are configured e.g. via a package specific vitest.config.ts file but not via the workspace root config.
The provided reproduction showcases that in the simplest way possible.
Reproduction
https://github.com/fubhy/vitest-workspace-repro
System Info
System:
    OS: macOS 14.0
    CPU: (12) arm64 Apple M2 Max
    Memory: 117.16 MB / 32.00 GB
    Shell: 3.6.1 - /nix/store/brlkinambh1hg2baqy43fyi7x66nqy8q-fish-3.6.1/bin/fish
  Binaries:
    Node: 20.9.0 - /etc/profiles/per-user/fubhy/bin/node
    npm: 10.1.0 - /etc/profiles/per-user/fubhy/bin/npm
    pnpm: 8.10.2 - /etc/profiles/per-user/fubhy/bin/pnpm
    bun: 1.0.11 - /etc/profiles/per-user/fubhy/bin/bun
  Browsers:
    Chrome: 120.0.6099.109
    Safari: 17.0
  npmPackages:
    @vitest/browser: ^1.0.4 => 1.0.4
    vite: ^5.0.4 => 5.0.8
    vitest: 1.0.4 => 1.0.4

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

There seems to be a problem with how the vitest server (createVitestServer) is initialized with project config. The server doesn't get the alias config passed to it at all because it appears to only load that from whatever it resolves as configFile in there.
By reading the source code there I managed to find a workaround. By dropping a vitest.aliases.ts file at the workspace root and pointing at that using the extends option for every project, it causes theconfigFile value to be resolved to that shared "alias" file.
That resolves my issue but it still appears to be a bug.

This is where things fall apart (unless using the extends workaround):
https://github.com/vitest-dev/vitest/blob/9c552b6f8decb78677b20e870eb430184e0b78ea/packages/vitest/src/node/workspace.ts#L30-L34


Feature: Add support for Hybrik as a service provider

Initial support for using Hybrik as a service provider

Codecov Report

Merging #185 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   81.07%   81.08%   +<.01%
==========================================
  Files          29       29
  Lines        2568     2569       +1
==========================================
+ Hits         2082     2083       +1
  Misses        298      298
  Partials      188      188

Impacted Files
Coverage Δ

config/config.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c49c678...a4eafc7. Read the comment docs.


feat(aws-lambda): added eventContextExtractor config option

Which problem is this PR solving?

Today, Lambda instrumentation supports trace propagation only for X-Ray or HTTP headers. This enhancement allows to add a custom configuration for extracting the context from incoming events to the Lambda function. This will allow the instrumentation to support more event types, such as SQS, CloudWatch or Kinesis.

Short description of the changes

Added eventContextExtractor config option to allow custom handling of events which carry the context in different ways. If not provided, a default context extractor is used and tries to pull the context from the HTTP headers - same as the behavior today.

Thanks for the addition! Generally LGTM as well, but can you explain a bit more how context would be extracted from those event types other than an HTTP header? I assume it's for context propagation for vendors other than X-Ray since we don't have any special context stored in e.g. Kinesis/CW Events. But perhaps a small example code in the readme or unit test for what the custom extractors would look like would help me greatly.

Sure!
One example could be a SQS message which triggers the Lambda function, where the trace header is found under the message attributes.
The event payload would look as follows:
{
    "Records":
    [
        {
            "body": "someBody",
            "receiptHandle": "someReceiptHandler",
            "md5OfBody": "somemd5value",
            "eventSourceARN": "arn:aws:sqs:us-east-1:000000000000:0a1b2c3e4d5f",
            "eventSource": "aws:sqs",
            "awsRegion": "us-east-1",
            "messageId": "2c45653f-43ad-87e0-947e-074da0a1b45d",
            "attributes":
            {},
            "messageAttributes":
            {
                "traceparent":
                {
                    "stringValue": "00-c0f3ad06b7d55d5f91e1b5cdf32a63aa-002e02c5e90f1e34-01",
                    "dataType": "String"
                }
            },
            "md5OfMessageAttributes": "somemd5hash",
            "sqs": true
        }
    ]
}

The custom context extractor would be able to catch such cases and extract the context from the event.

Please don't force push after any first review / comment

Please don't force push after any first review / comment

Sure! Thanks for the comment.
Could you please merge this PR?

Have a question regarding this.How will the context be propagated in terms of SQS batching or other services which support batching. As the context can be fetched for a single message at a single point of time.

@NikunjShah That's a great question. You could handle that in several ways:

Iterate the Records array and create a consumer span for each message (but the handling of the message will appear as a separate trace)
Patch the iteration functions of the Records array (forEach / map / filter) and so that each iteration handler creates a span with the context of the handled message. This is possible in Node, and not really in other languages (and does have limitations, like no support for a "regular" for loop which cannot be patched
You could provide a decorator function that's inserted manually to each iteration in the code


  That'd be bad (since it'd likely replace the database).
This brings up the versioning of blueprints like I was talking about - otherwise there's going to be a lot of conditionals just to avoid this sort of thing going forward.
If you haven't tested this, I'll try to get to it.

Yea thats a really good point. I have not tested that since I was using this to write stacks from scratch.
Do you have another thread where we can talk about the versioning?

#58 just created

So I just got around to testing this - and it does result in a rebuild of the database - which sucks, because it basically means that the existing database gets nuked.  I think a conditional and two DBInstance blocks would avoid this, though I'm not 100% certain.

IT's really annoying - since the databases it is building are exactly the same:
https://www.dropbox.com/s/w3uvu6ut7fwoi22/Screenshot 2015-08-10 11.48.30.png?dl=0

thats so annoying.
the versioning seems like the more longterm solution to this.
On Mon, Aug 10, 2015 at 11:48 AM Michael Barrett<EMAIL_ADDRESS>wrote:

IT's really annoying - since the databases it is building are exactly the
same:
https://www.dropbox.com/s/w3uvu6ut7fwoi22/Screenshot 2015-08-10 11.48.30.png?dl=0
—
Reply to this email directly or view it on GitHub
https://github.com/remind101/stacker/pull/57#issuecomment-129562844.

Agreed - though that's a pretty significant change, and I still haven't gotten my head around how we'd make it work.

yea, i might just change this to have a get_rds_parameters or something that can be overriden by a subclass so i can have encrypted dbs that are in my private stacks.

Yeah - that seems like a decent compromise for now.

No longer necessary w/ new RDS v2 blueprints.


Update functorch source installation command

We changed how one installs functorch: functorch is now included in the PyTorch binary. This PR removes the old installation command which effectively does nothing right now. We'll be removing support for the old installation command after we migrate people off of it.
Test Plan:

wait for CI

Looks like PyTorch didn't publish a nightly binary for mac yet, so this PR will have to wait until then

Wonderful! We'll need to update the readme.md and contributing.md accordingly I guess.
Will it work with nightly on M1 too?

EDIT: macos still failing :/

Looks like the torchtext/torchvision nightlies have the 20220913 torch binary as a dependency. Should be fixed tomorrow, so will wait another day.

Wonderful! We'll need to update the readme.md and contributing.md accordingly I guess.

Yup I can do that in this PR.

Will it work with nightly on M1 too?

It should, but we have not tested functorch extensively on M1 yet. There's a high probability that it works correctly on M1 but we'll add explicit tests soon.

Will it work with nightly on M1 too?

Confirmed that installing PyTorch from source on an M1 machine also installs functorch. So yes, we have M1 support now.


Unicode text issue

Hi,
I have an svg (please see attached zip file) which is rendered by edge like this:

In my application it is rendered like this, although I load the needed font "Leipzig" which is specified in the SVG file:

Within the SVG file, the source code looks like this:
 <tspan font-family="Leipzig" font-size="720px"></tspan>

By using online unicode tools, I can see that the character in question is U+EA64
Are these unicode characters in general supported by Image32, or isn't it supported?
sample.zip
(Leipzig font can be found here https://github.com/rism-digital/leipzig)
Kind regards
André

As far as I can tell it does render the glyph but it probably miscalculates the font base line because it does so waaaay outside the bitmap .
The following is a comparison between how GDI DrawText and Image32 renders the font at 28pt (GDI top, Image32 bottom):

@andersmelander thanks for having a look.
From your description, I am not sure whether I understand it correctly. Does it somehow work on your side?
For a moment I thought, maybe the issue is solved with the recent main branch, especially with the commit #111 (Img32.Text: Added support for 4-byte chars (USC-4))
But also with recent main branch it doesn't work on my side.

Does it somehow work on your side?

No, I can't really say that it does. Drawing the text directly, using Image32's DrawText method, does display the glyph but I haven't tried doing so via a SVG.
The whole metric thing was a red herring; While there does seem to be a slight problem it isn't relevant to this problem. I can see from your screenshot that Image32 displays the "missing glyph" symbol at the correct position so the problem is more that it can't find the glyph or is using the wrong font.

so the problem is more that it can't find the glyph or is using the wrong font.

I've found the problem and will upload the fix shortly. (Just checking a few other things before doing so.)

@AngusJohnson
Thank you so much for your quick help.
This looks now fantastic.


Openai model "gpt-3.5-turbo-0613" streaming=True raise error

The bug
Using "gpt-3.5-turbo" won't raise error but not streaming result #244
Using "gpt-3.5-turbo-0613" raise this error:
Traceback (most recent call last):
  File "d:\test\.venv\lib\site-packages\guidance\_program_executor.py", line 111, in run
    await self.visit(self.parse_tree, VariableStack([self.program._variables], self))
  File "d:\test\.venv\lib\site-packages\guidance\_program_executor.py", line 535, in visit
    visited_children.append(await self.visit(child, variable_stack, inner_next_node, inner_next_next_node, inner_prev_node, node, parent_node))
  File "d:\test\.venv\lib\site-packages\guidance\_program_executor.py", line 500, in visit
    command_output = await command_function(*positional_args, **named_args)
  File "d:\test\.venv\lib\site-packages\guidance\library\_assistant.py", line 13, in assistant
    return await role(name="assistant", hidden=hidden, _parser_context=_parser_context)
  File "d:\test\.venv\lib\site-packages\guidance\library\_role.py", line 17, in role
    new_content += await parser.visit(
  File "d:\test\.venv\lib\site-packages\guidance\_program_executor.py", line 535, in visit
    visited_children.append(await self.visit(child, variable_stack, inner_next_node, inner_next_next_node, inner_prev_node, node, parent_node))
  File "d:\test\.venv\lib\site-packages\guidance\_program_executor.py", line 535, in visit
    visited_children.append(await self.visit(child, variable_stack, inner_next_node, inner_next_next_node, inner_prev_node, node, parent_node))
  File "d:\test\.venv\lib\site-packages\guidance\_program_executor.py", line 256, in visit
    visited_children = [await self.visit(child, variable_stack, next_node, next_next_node, prev_node, node, parent_node) for child in node]
  File "d:\test\.venv\lib\site-packages\guidance\_program_executor.py", line 256, in <listcomp>
    visited_children = [await self.visit(child, variable_stack, next_node, next_next_node, prev_node, node, parent_node) for child in node]
  File "d:\test\.venv\lib\site-packages\guidance\_program_executor.py", line 353, in visit
    command_output = await command_function(*positional_args, **named_args)
  File "d:\test\.venv\lib\site-packages\guidance\library\_gen.py", line 163, in gen
    async for resp in gen_obj:
  File "d:\test\.venv\lib\site-packages\guidance\llms\_openai.py", line 186, in stream_then_save
    async for curr_out in gen:
  File "d:\test\.venv\lib\site-packages\guidance\llms\_openai.py", line 45, in add_text_to_chat_mode_generator
    c['text'] = c['delta']['content']
  File "d:\test\.venv\lib\site-packages\openai\openai_object.py", line 71, in __setitem__
    raise ValueError(
ValueError: You cannot set text to an empty string. We interpret empty strings as None in requests.You may set {
  "delta": {
    "content": "",
    "role": "assistant"
  },
  "finish_reason": null,
  "index": 0
}.text = None to delete the property

Error in program:  You cannot set text to an empty string. We interpret empty strings as None in requests.You may set {
  "delta": {
    "content": "",
    "role": "assistant"
  },
  "finish_reason": null,
  "index": 0
}.text = None to delete the property

To Reproduce
Give a full working code snippet that can be pasted into a notebook cell or python file. Make sure to include the LLM load step so we know which model you are using.
import guidance
guidance.llm = guidance.llms.OpenAI("gpt-3.5-turbo-0613")
program = guidance('''
{{#system~}}
You are helpful assistant.
{{~/system}}
{{#user}}
Write me a long poem.
{{/user}}
{{#assistant~}}
    {{gen "answer" save_prompt="prompt" max_tokens=300}}
{{~/assistant}}
''') # type: ignore

pos = 0
for p in program(stream=True, silent=True, caching=False):
    val = p.get("answer", "")
    print(val[pos:], end="", flush=True)
    pos = len(val)

System info (please complete the following information):

OS (e.g. Ubuntu, Windows 11, Mac OS, etc.):

Windows 11, Python 3.10.4

Guidance Version (guidance.__version__):

'0.0.63'

Version 0.0.64  fixed