Repeated tasks are being added“ 🏁 After the 'delete' field, the task status cannot be reset

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
test1

[ ] Delete my completed instance, leave my next instance 🔁 every day 🏁 delete ⏳ 2024-08-21

test2

[ ] Delete my completed instance, leave my next instance 🔁 every day 🏁 delete ⏳ 2024-08-22
[ ]

After the task is completed, the newly created task should be in an unfinished state.
Current behaviour
test1

[ ] Delete my completed instance, leave my next instance 🔁 every day 🏁 delete ⏳ 2024-08-21

test2

[x] Delete my completed instance, leave my next instance 🔁 every day 🏁 delete ⏳ 2024-08-22
[ ]

After the task is completed, the newly created task is in a completed state.
Steps to reproduce
Note from @claremacrae: the steps below are not relevant to this issue. They may relate to https://github.com/obsidian-tasks-group/obsidian-tasks/issues/3041.
1. Launch Obsidian Sandbox Vault
2. Enable Community Plugins
3. Install Tasks
4. Change "minimum match length for auto-suggest" to "1"
5. Restart Obsidian
6. In a new note, create a task with any title, type "du" and press enter to insert due date emoji from auto-suggest. Notice that the autosuggest box remains active.
Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[ ] Linux
[ ] macOS
[X] Windows

Obsidian Version
1.6.7
Tasks Plugin Version
7.9.0
Checks

[X] I have tried it with all other plugins disabled and the error still occurs

Possible solution
No response

Thanks, however there isn't enough information to reproduce the problem.

Please edit the description and include a screenshot of the problem result.
In the steps to complete, please edit them to say how exactly you are completing the task.

In Tasks plugin search results?
Clicking on the task in Live Preview?
Clicking on the task in Reading Mode?

Steps to reproduce

Launch Obsidian Sandbox Vault
Enable Community Plugins
Install Tasks
Change "minimum match length for auto-suggest" to "1"
Restart Obsidian
In a new note, create a task with any title, type "du" and press enter to insert due date emoji from auto-suggest. Notice that the autosuggest box remains active.

The above is nothing to do with the 🏁 delete option, and so will not be tracked here. Each issue needs to focus on one problem, please.
However, It looks similar to the following, which I have only been able to reproduce since updating to Obsidian 1.7.0.

https://github.com/obsidian-tasks-group/obsidian-tasks/issues/3041

Obsidian Version
1.6.7

I suspect that the cause of this issue is the following in the Tasks plugin Live Preview code:
https://github.com/obsidian-tasks-group/obsidian-tasks/blob/33efdee4aa448ce161f24971ed591c8252638c6e/src/Obsidian/LivePreviewExtension.ts#L93-L104
It probably needs to detect if the completed task has been discarded, and if so, not apply the workaround...

I am struggling to know how to explain to you what we need, but I will try one last time:

“ it still does not work in editing view.”: “does not work” is useless information. We need to know exactly what happened.
If you want someone to spend time helping you, we need a clear precise list steps to exactly and reliably reproduce what you did when the problem happened.
One problem per Issue: create new issues for different topics

Thanks @materemias - I really appreciate your taking the time.
For future reference,  we can't do anything with just screenshots...
So here is your video converted to a set of reproduction steps:

Paste the following line in to a Markdown note in Obsidian, with Tasks plugin v7.10.2 enabled:
- [ ] #task Do stuff 🔁 every day 🏁 delete 📅 2024-10-04

Switch to Reading Mode
Appearance:

Complete the task.
New markdown is correct - there is only one task, and its date has been increased by 1:
- [ ] #task Do stuff 🔁 every day 🏁 delete 📅 2024-10-05

And the new rendered task is correct, as in, it is not checked:

Switch to Live Preview
Appearance:

Complete the task:
New markdown is correct - there is only one task, and its date has been increased by 1:
- [ ] #task Do stuff 🔁 every day 🏁 delete 📅 2024-10-06

New appearance is incorrect, in that the checkbox wrongly remains checked:


Patch 1 Fixed broken fwlink

Global effort to fix broken links
@MandiOhlinger
The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only link fixes and does not change other content. I’d very much appreciate your timely review and feedback on the link changes I’ve suggested. Thanks!

Docs Build status updates of commit b0bda53:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/adapters-and-accelerators/accelerator-swift/windows-sharepoint-services-security.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@MandiOhlinger I'm afraid Laura has moved on to another project. Is it possible for you to move this out of draft mode so it can be merged? If not, we can close this and I'll submit a new PR to replace it. Thanks!


feat: deprecate SCARD_SCOPE_SYSTEM constant

Description
The SCARD_SCOPE_SYSTEM constant is now deprecated and will be removed in a future release. Use SCARD_SCOPE.SCARD_SCOPE_SYSTEM instead.
Related Issue

Type of Change

[x] 🚀 feat – New feature (non-breaking change that adds functionality)
[ ] 🛠 fix – Bug fix (non-breaking change that fixes an issue)
[ ] ❌ ! – Breaking change (fix or feature that causes existing functionality to change)
[ ] ⚡ perf – Performance improvement
[ ] 🧹 refactor – Code refactor (no functionality change)
[ ] 📝 docs – Documentation update
[ ] 🎨 style – Code style changes (formatting, renaming, etc.)
[ ] 🧪 test – Test update or addition
[ ] 🔧 build – Build related changes
[ ] ✅ ci – CI related changes
[ ] 🗑 chore – Chore (maintenance, non-production code change)
[ ] ◀  revert – Revert a previous commit

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.18%. Comparing base (dd09757) to head (f78a0a8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #930   +/-   ##
=======================================
  Coverage   62.18%   62.18%
=======================================
  Files          34       34
  Lines        1145     1145
=======================================
  Hits          712      712
  Misses        433      433

Flag
Coverage Δ

win32
60.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

packages/win32/lib/src/constants.dart
6.66% <ø> (ø)

----
🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles


Feedback tsx upgrade

Upgrade Feedback.js to Feedback.tsx
What user problem are we solving?
Migrating frontend to typescript
What solution does this PR provide?
Feedback.js is a relatively low hanging fruit for migration efforts
Testing Methodology
github actions
Any other considerations
having trouble with debugging why react-google-recaptcha is not recognized by yarn even though I did cd frontend/playground-frontend && yarn add react-google-recaptcha and confirmed this dependency was present in yarn.lock and package.json. Need help @farisdurrani

@farisdurrani please test that the feedback page works as intended first

Tested and verified feedback works. No issue with react captcha package. In your case, probably it wasn't installed correctly or that VSCode just didn't read the package right. But since I don't see that issue, I'm merging this in


Animation on OSX hangs

The recently added CombinationAnimationGenerator.swift fails to compile for OSX.
Adding
#if os(OSX)
import AppKit
#else
import UIKit
#endif

fixes the build but the animation example in the OSX Example hangs.

This issue fixed in the master branch and will be available in the 0.9.4 release.


Bls signatures

Adds a host call for verifying BLS signatures on the BLS12-381 curve.
Some questions regarding dependencies:

Should we wait with merging until arkworks libs mature from 0.4.0-alpha?
Should we use the w3f fork of arkworks curves, or upstream? (currently git = "https://github.com/w3f/arkworks-curves.git"). Probably best to use the crates.io version, again once 0.4.0 is fully out.

More details in this PPP. @claravanstaden
@alistairstewart @burdges @drskalman @swasilyev should review for correctness.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2186875

Why bls12-381? The plan was to adopt bls12-377

@volcano-mash let me know if I can contribute to get this PR in a ready to review state. 😄

We'll replace this PR by https://github.com/paritytech/substrate/pull/13031/ probably.

We'll replace this PR by #13031 or its successor I think.

Thanks @burdges, will follow that PR.


Add support for macOS release/profile mode (3 of 3)

Description
Add support for release/profile mode to macOS desktop target. This requires artifacts that have already been uploaded and should work with the existing macOS projects as is.
Related Issues
Fixes https://github.com/flutter/flutter/issues/38476

Still working on this, but I've confirmed the updated symlinks work when i enable codesigning on xcode locally


About training on waymo dataset

Hi, Thanks for your great works!
I have downloaded your preprocessed waymo dataset pytorch_block_nerf_data.zip and run the code to generate the masks for training following your instructions. However, the code throw an error about missing corrdinate.pt. Could you give some advice about this problem? Is the official waymo dataset necessary for training?
Looking forward to your reply.
Thanks.

coordinates.pt.zip
Thanks for your attention! Here is the coordinates.pt. You can create it via the latest data_preprocess/fetch_data_from_tf_record.py.
Besides this, we will provide the whole training materials soon.

At this version, you need to download the original dataset but things will be changed after a few days.

Thanks for your quick reply! looking forward to your updates.


Fix the issue with interviewer ask method; #trivial

Not sure how this one has not been fixed so far, please correct me if it's an intended behavior.
However, right now if you provide an answer to the interviewer question, you'll see You need to provide an answer. and in a case of an empty string, it will work.

          1 Warning

  :warning:
  Tests were not updated

          1 Message

  :book:
  @Antondomashnev is not a contributor yet, would you like to join the Danger org?

  Generated by :no_entry_sign: danger

Actually this method not being used, can we remove it? /cc @orta

Sure, kill it

@Antondomashnev Could you remove this ask method? Thanks!

@Antondomashnev Could you remove this ask method? Thanks!

Removed in 6dbc289

👍

nice one @Antondomashnev - we can invite you to the org any time

@orta I'd love to be a part of the Danger community ;)

sent


drawer is not in correct position when direction is RTL

when toggling to RTL , the drawer is not in its correct position .
as you see in below picture , i switched to RTL direction and drawer is not shown correct.

Looking for a solution to this.

is this bug fixed ?

@morteza-mortezai Yes. update to latest version (1.14.1)


add serialization

Description
Added serialization for NMatrix class using Marshal module and custom implementation of load and dump functions.
Default Marshal serialization methods threw error so We needed to create our own serialization/deserialization strategies.
nm_int is the default fallback for dtype if it's not nm_float64 or nm_bool
Closes #35
(Explain how this PR changes numruby.)
This PR adds the ability for NMatrix to serialize the class objects which can be used to store the data in a file for future and to pass it between different processes and to be utilized
Test Plan
the test is written for comparing the original object and the one after serialization and deserialization
it checks for nm_float64, nm_int, and nm_bool dtypes

@pkspyder007  CI is failing. Can you debug ?

@pkspyder007  CI is failing. Can you debug ?

@prasunanand According to my checking ,CI is failing due to the bundler version compatibility. Adding a Gemlock file similar to package.lock in npm should lock all the version of gems and bundler we are using.

@prasunanand According to my checking ,CI is failing due to the bundler version compatibility. Adding a Gemlock file similar to package.lock in npm should lock all the version of gems and bundler we are using.

@prasunanand If I add the Gemfile.lock the 5th test passes but the travis CI build fails and on removing Gemfile.lock the 5th test fails. You can see the result here
I read the error message in Travis build log I think the Issue is only with versions that we use of bundler and ruby.
So this would be a tradeoff between keeping the lock file vs not.

@prasunanand If I add the Gemfile.lock the 5th test passes but the travis CI build fails and on removing Gemfile.lock the 5th test fails. You can see the result here
I read the error message in Travis build log I think the Issue is only with versions that we use of bundler and ruby.
So this would be a tradeoff between keeping the lock file vs not.

@prasunanand @Uditgulati Any updates on this PR?


Prevent certain scripts from running simultaneously

Add mutex to ensure two calls to the same script can't be made simultaneously. This could be tied into #6 as a generic function / safeguard.
The mutex should be enabled only on specific scripts, essentially the ones which modify data.

Fixed in d705fe99142e5adfe4409540febd58e2af719a76


Thanks for the PR fixing it!


Update getting-started.md for a .NET tooling change

dotnet new -t web is no longer valid, using dotnet new web instead.

Hi @woachk, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@woachk  Thanks!


Upgrade pulldown-cmark to 0.10.0

Increases the version of pulldown-cmark to 0.10.0 and resolves breaking changes caused by pulldown-cmark #517 and pulldown-cmark #638.

Apologies! Undone the version bump in the latest commit.


Add Support for TypeScrict JSX files (TypeScript React) (.tsx)

Installed product versions

Visual Studio: 2019 Professional
This extension: 1.1.100

Description
Add support for TypeScript React files (.tsx)
Steps to recreate
N/A
Current behavior
Currently you can enable .jsx and .ts files, but TypeScript JSX files, i.e. TypeScript React files are not linted in Visual Studio.
Expected behavior
This would require the correct plugins for eslint to work, but on your side should just be adding the file extension. At least it appears that way from #55 .
I'm happy to contribute to a fix if you would prefer that. Just let me know.
Thanks!

Hey @mklosterboer
Sounds good to me. If you'd create a pull request for this change I'll be happy to review it! Let me know if I can help.

Perfect. I'll work on that and get a PR started. Thanks for the quick response!

@jwldnr
This may be a silly question, but I'm having trouble building the solution to test it because of what looks like some custom tools.
I am unable to test as a result of this, but I am pretty sure I'm done.
How do you feel about either of these options:

Building my branch and giving me the VSIX file to test
Me submitting a PR and you do any testing you would have done as part of the code review process.

This just seems to be a development environment issue and I don't know that I want to keep fighting it over a pretty simple code change.
Any thoughts?

@jwldnr
Nevermind. I figured out the issue. I'm was able to test it and I'm going to open a PR now. It looks like it's working like charm.


including a page to

Can we include a page to ? We are using showModalDialog by adding a page from URL, can we do same here?

You cannot directly do that, as it's not part of the <dialog> spec. Dialog exists inside a document, it isn't a separate document like showModalDialog was. Maybe the best way would be to put an <iframe> in a <dialog>.

Matto, thanks a lot for you reply. I have another confusion please help me in clearing it. Our clients use our application on Internet explorer and firefox. dialog tag is not supported on both as mentioned on w3schools. Some websites say dialog tag will not be the part of HTML 5 specification. Now I am confused should I use this polyfill? If in future these two browsers do not support dialog tag than where will I stand. Our application has around 1000 modal dialogs so what should I do?

The point of the polyfill is to allow you to use <dialog> in browsers that don't implement it. So today you can use <dialog> natively where available and then fallback to the polyfill for other browsers.
Ideally, you would never need the polyfill. Currently <dialog> is supported in Chrome and Opera but not other browsers. I've seen positive signals from other browsers but it's unknown when they will add support. For example, Firefox has a bug you can follow; they've also have good developer documentation.
The state of HTML specifications takes some time to explain. The short answer is yes, it is in the HTML spec. The longer answer is, the WHATWG HTML spec [has dialog] (https://html.spec.whatwg.org/multipage/forms.html#the-dialog-element), and the W3C HTML 5.1 spec also has dialog. The W3C decided to put it in HTML 5.1 rather than HTML 5 because of lack of browser support at the time.


Update .gitattributes

downloaded with tests

Why do you need tests on production?

@SuperManPHP what is the reason of this changes?

@SuperManPHP I'm closing this PR because you are not responding why this changes are needed. In my experience it's a good practice to not include tests files on production environment.


find does not transform the partitionKey back

I have a model defined like this
class BaseEvent {
    @Attribute()
    id!: string;
    @Attribute()
    sortKey!: number;
}

@Entity({
    name: 'SpecificEvent',
    primaryKey: {
        partitionKey: 'SpecificEvent___{{id}}',
        sortKey: {
            alias: 'sortKey',
        } as unknown as string,
    },
})
export class SpecificEvent extends BaseEvent {
    @Attribute()
    value!: number;
}

// connection
export const getConnection = (
    tableName: string,
    documentClient?: DocumentClient
) => {
    return createConnection({
        table: new Table({
            name: tableName,
            partitionKey: 'id',
            sortKey: 'sortKey',
        }),
        entities: [SpecificEvent],
        documentClient,
        name: v4(),
    });
};

Im storing some events via Batch in dynamo db and the partitionKey gets transformed into SpecificEvent___xxx. But when I now try to load the items with find or findOne I still receive in the loaded entity with id as the full string SpecificEvent___xxx rather than xxx. Am I missing something here?
Loading is done via:
const result = await this.entityManager.find(
    SpecificEvent,
    {
        id: conditionId,
    },
    {
        limit: limit,
        orderBy: QUERY_ORDER.DESC,
    }
);

Also in the debug log I see that there is no transformation applied.
Here is the log from the transformation
2021-12-03T09:14:35.005Z typedorm:transform:log 42a35974-8625-4de7-8131-e4db99b074a4 RESPONSE ConditionAlertEventDTO Before:
Body:
{
  "sortKey":<PHONE_NUMBER>772,
  "__en": "SpecificEvent",
  "id": "SpecificEvent___100ConditionId",
  "value": 6.831363201141357
}

2021-12-03T09:14:35.006Z typedorm:transform:log 42a35974-8625-4de7-8131-e4db99b074a4 RESPONSE ConditionAlertEventDTO After:
Body:
{
  "sortKey":<PHONE_NUMBER>772,
  "id": "SpecificEvent___100ConditionId", // this should have been "id": "100ConditionId"
  "value": 6.831363201141357
}

Hey @obiwabrakenobi,
I had a look at the issues you suggested were happening, but I can't replicate them.
Can you please provide the logs of the batch write operation? Looks like the id you are expecting to have the transformation applied for, isn't in the correct format in the first place.
Please Have a look at https://github.com/typedorm/typedorm/pull/185/files and let me know what is different in your case.
Thanks

I might have found the issue. I'm creating the table with
export const getConnection = (
    tableName: string,
    documentClient?: DocumentClient
) => {
    return createConnection({
        table: new Table({
            name: tableName,
            partitionKey: 'id',
            sortKey: 'sortKey',
        }),
        entities: [SpecificEvent],
        documentClient,
        name: v4(),
    });
};

but the keys do reflect properties of the entity. I investigated your PR and saw that the testTable in your tests is created like
export const testTable = new Table({
  name: 'test-table',
  partitionKey: 'PK',
  sortKey: 'SK',
  indexes: {
    GSI1: {
      type: INDEX_TYPE.GSI,
      partitionKey: 'GSI1PK',
      sortKey: 'GSI1SK',
    },
    LSI1: {
      type: INDEX_TYPE.LSI,
      sortKey: 'LSI1SK',
    },
  },
});

After I changed the provided example to
export const getConnection = (
    tableName: string,
    documentClient?: DocumentClient
) => {
    return createConnection({
        table: new Table({
            name: tableName,
            partitionKey: 'PK',
            sortKey: 'SK',
        }),
        entities: [SpecificEvent],
        documentClient,
        name: v4(),
    });
};

it worked like expected. There might be an issue when a table is created with partitionKey and sortKey with identifiers from the entity!?

@obiwabrakenobi
Aaha, I see the issue now.
The issue is what is defined as partition key/sort key.
Since you have a partition key set to 'id' and the entity also has an attribute called 'id', The TypeDORM decides to not parse the 'id' property( because it is a part of the partition key)
This is the desired behaviour, but I think it should throw an error when an entity has an overlapping attribute name to prevent such accidents as this one.

closing this in favor of https://github.com/typedorm/typedorm/issues/186.


CSS

CSS
User Story
As a boot camp student
I want the prevork notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a prevork Study Guide website
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow

Added CSS to project


RSA private key regex

As constructed, secret scanning pattern for RSA private keys will not detect RSA private keys.
https://github.com/advanced-security/secret-scanning-custom-patterns/tree/main/rsa
The issue is an unescaped delimiter when searching for matches within the character list.
Steps To Reproduce:
generate an RSA private key
place entire RSA private key into any repository.
turn on secret scanning, wait for results.
RSA private key is not detected.
navigate to regex101[dot]com
copy RSA private key to page as test string
copy RSA private key detection regex to page as regular expression.
see lack of match to result
change
--BEGIN (?:[A-Z]+ )?PRIVATE KEY--+(\r|\n|)+[a-zA-Z0-9+/=\s]+(\r|\n|)+--+END (?:[A-Z]+ )?PRIVATE KEY--
to
--BEGIN (?:[A-Z]+ )?PRIVATE KEY--+(\r|\n|)+[a-zA-Z0-9+/=\s]+(\r|\n|)+--+END (?:[A-Z]+ )?PRIVATE KEY--
see matched result

both versions work for GH version of regex


Name of .apkg file is something from the relativ path, not the deck_name. Should it be fixed?

Possible fix with os.rename().

the labeling of the .apkg file could work like this:

if the user provides a save_path argument like /dir/filename.apkg this naming should be used
if the user did not provide a save_path and the current dir will be used as a save directory but the deck_name is the filename
if nothing is provided the path argument will be used for naming

I think I already implemted it similar to that.


tour: [why cap(s) is 8 instead of 5 after the line "s = append(s, 2, 3, 4)"]

Context: https://tour.golang.org/moretypes/15

I just notice that cap(s) is 2 after the line "s = append(s, 0)", shouldn't it be 1?

Thank you WheeskyJack!


Rendermanager config

Adding RenderManagerConfig parsing and server string to osvrClient as an internal API. It will be used directly by the RenderManager API.

Assuming that it compiles and runs, this looks okay to me.  The Core is not my domain, though.  Would like to see this pulled in so we can go forward with the cleaner RenderManager branch.
Would like to see example config files added.


Complete tutorial how to train Anime4K on my own dataset?

I need to train Anime4K on my own dataset, but the train notebook lacks enough explanations. Is there a complete tutorial how to train the models and also how to do it for different model sizes (S, M, L, UL, etc)? Can you please add some notes to the notebook?
For instance, it uses /hdd/sdb/SYNLA_Plus_4096.npy but how to generate it from my own dataset?

https://github.com/bloc97/Anime4K/issues/220


update node.js docker file to a supported version

The node.js version in the demo app is no longer supported, updating the docker image to a supported tags (https://hub.docker.com/_/node/?tab=description&page=75)

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SonjaChevre
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @SonjaChevre. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SonjaChevre: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
46aad233a556556055395ef063b993770114f293
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SonjaChevre: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
46aad233a556556055395ef063b993770114f293
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SonjaChevre: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
46aad233a556556055395ef063b993770114f293
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
46aad233a556556055395ef063b993770114f293
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SonjaChevre: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
46aad233a556556055395ef063b993770114f293
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
46aad233a556556055395ef063b993770114f293
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
46aad233a556556055395ef063b993770114f293
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Jade: Characters used by Angular 2 are not recognized as valid attribute names

It seems that Jade syntax hightlighting is buggy: It does not support characters like * or [] in an attribute name.
Unfortunately, Angular 2 relies heavily on them :(
I guess that JadeTokenizer.GetAttribute() method is to blame

Thanks for the report.
I don't know too much about jade and its syntax so feel free to submit a pull request to fix this issue.
Does Jade support any HTML attribute names? The function you referenced does look like the correct place to update, but I'd like a more general solution if possible, instead of just adding support for these characters. A blacklist perhaps?

I'm not sure to be the right person to ask about html standards, nor about jade syntax.
I'm merely a jade user.
However, a quick search through the pug lexer  (yea, apparently they're renaming "jade" to "pug") tells me that it seems that attribute names can be everything except:

Whitespaces (regex  /\n\t/ ) and commas, which marks the end of an attribute
Characters that marks the begining of a value: '=' and '!'
Quotes (single or double quote)

So yes, I could probably push a fix sometimes when i have some time to setup things


cl.step can't feedback?

cl.step can't feedback?

Set disable_feedback to False.

cl.step can't feedback?

hi @lw3259111 , 我在学习chainlit应用，想请教下您是通过Literal AI 实现的吗？

@lw3259111 你好，我在学习chainlit，想问下您是怎么实现 feedback功能的？是通过literalai吗？还是有其他方式实现

其他方式
---- Replied Message ----
| From | @.> |
| Date | 02/06/2024 13:51 |
| To | Chainlit/chainlit @.> |
| Cc | lw3259111 @.>,
Mention @.> |
| Subject | Re: [Chainlit/chainlit] cl.step can't feedback? (Issue #723) |
@lw3259111 您好，我在学习chainlit，想问下您是怎么实现 feedback功能的？是通过literalai吗？还是有其他方式实现
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


add CLI to create empty MMIF

It would be great to have a CLI that takes a list of (document type, document location) tuples and generates empty MMIF strings (PipelineSource), as pictured in the following mock command.
$ clams source text:/path/to/textdocument video:/path/to/videodocument
# prints generated MMIF into stdout

closed via #17


rewrite tests using docker-compose and pytest

Following up #197.
I never was quite satisfied with Bats and more precisely having to write tests in Bash. While the current test suite serves a purpose it has not evolved as it could have. IMHO, Bash is hard to read and when a test case fails, it is time consuming to reproduce/understand/fix the issue. Those barriers might have dissuade potential contributors.
IIRC @jwilder originally expressed the idea of writing test cases with the help of docker-compose. That's what I started to work on.
I kept the actual test suite and added the new one under the test2 directory. The Travis config file is setup so that it will run both tests suites, but only legacy tests can mark the build as broken. This is to allow a transition period that should prove that a failing test case under test matches a failing test case under test2.
To sum up the objectives:

[x] make tests easier to read/write
[x] make it easier to understand what's going on with a failing test case
[x] no regression : a failing test case with legacy tests should match a failing test case with the new test suite
[x] in the end, get rid of Bats completely
[x] port all the actual tests

[x] default-host.bats
[x] docker.bats
[x] headers.bats
[x] multiple-hosts.bats
[x] multiple-ports.bats
[x] ssl.bats
[x] wildcard-hosts.bats

@thomasleveil This looks a lot easier to understand then the existing bats test. The compose files also provide some documentation of sample usage.

@jwilder this PR is now complete. I would appreciate  if you could try it on your machine and confirm there is no trouble to run this new test suite.

Is there a way to override the DNS resolver when running the tests to allow a different IP to to be used for the nginx-proxy container?  On a mac, I see:
$ pytest -s
...
INFO:patched DNS:resolving domain name 'nginx-proxy' as IP address is <IP_ADDRESS>

but <IP_ADDRESS> isn't routeable from my host so the tests just hang.

are you using docker for Mac or Docker Toolbox?
I don't own a Mac myself so I can't provide a solution that would work around the network specificities of Docker on Mac.
Some pointers thought for workaround solutions:
Maybe we can find a way to run pytest within a docker container:
Dockerfile-nginx-proxy-tester:
FROM python:2.7
COPY requirements.txt /requirements.txt
RUN pip install -r /requirements.txt
WORKDIR /test
ENTRYPOINT ["pytest"]

then build:
docker build -t nginx-proxy-tester -f Dockerfile-nginx-proxy-tester .

and run:
docker run -v $(pwd):/test -v /var/run/docker.sock:/var/run/docker.sock --rm nginx-proxy-tester

The issue with this is that for every test we start by removing all containers (including that one)... you would need to find a way to prevent that in https://github.com/thomasleveil/nginx-proxy/blob/pytest/test2/conftest.py#L113.

Or playing with dind (Docker in Docker): https://forums.docker.com/t/how-to-run-docker-inside-a-container-running-on-docker-for-mac/16268/3

I worked on the running pytest inside a container idea and it almost work. It fails in cases where the docker-compose file uses volumes ; so when it does solve the network issue you have on mac, it does raises a new one --> NOGO
I will give a try to the dind option.
@jwilder are you using docker for Mac or Docker Toolbox?

I managed to get the test suite running from a docker container. just call the test2/nginx-proxy-tester.sh script and let me know.

There is still an issue with the ./nginx-proxy-tester.sh script when a test is using docker compose syntax v2. (for instance when running test_composev2.py).
you can skip this particular test by running:
./nginx-proxy-tester.sh --ignore test_composev2.py

The ./nginx-proxy-tester.sh script is now able to handle tests using docker compose files written syntax v2.
Mac users should now be able to run the full test suite with it.

@kamermans since you contributed to the nginx-proxy test suite in the recent past, I would appreciate your feedback on this PR ;)
The related branch to checkout is https://github.com/thomasleveil/nginx-proxy/tree/pytest

Hi @thomasleveil, I did look over the PR last month and it made sense to me.   That having been said, I've also written a number of tests since then, particularly on the SSL side, so I'd like to see how they are implemented in Python.   I do think that the testing will be easier in Python than BATS, despite my soft-spot for Bash :).
I've got a red eye from Silicon Valley to Washington DC tonight. If I can't sleep, I'll try to give your PR a spin on the plane.

Hi @thomasleveil, I've tried it out and it works pretty well.  There were some bugs that I fixed, for example, you cannot create files with a * in the filename on Windows, so I was unable to clone the project at all.  As per the docs, for wildcard domains, like *.nginx-proxy.tld, nginx-proxy will load the cert nginx-proxy.tld, if present, so I renamed the *.nginx-proxy.tld files to nginx-proxy.tld and updated the yml files that referenced them.
I've fixed these issues in my fork of your fork (sounds like Inception :) ):
https://github.com/kamermans/nginx-proxy/tree/steve_pytest
To keep things in one place, I issued my PR against your fork (https://github.com/thomasleveil/nginx-proxy/pull/4), so if you pull it my commits will end up on this PR as well, and everything should be clean here.

@kamermans thank you for helping out on this PR, much appreciated 👍

Sure thing!  I'm pretty sure that's my first PR from 10,000 feet off the ground at 600 MPH :)

@thomasleveil I haven't forgotten about this.  Have not had a chance to try it out yet.

@thomasleveil This PR is awesome!  It works great locally for me.  If all the bats tests have been ported over, I think we can remove them as well.

@thomasleveil Let me know if you are ready for me to merge this.

I agree that we should remove the bats tests.  Most of the tests have been written or improved by the three of us anyway, and I don't mind chipping in if there are other open PRs with tests that need to be ported, assuming those PRs are approved.

@jwilder all bats tests have been ported and there are even additional tests covering even more features. Previous test suite is gone.
Note that on Travis-CI, IPv6 related tests are skipped since the Travis-ci boxes don't support IPv6
This PR is ready to be merged. If you which, I can squash all those commits together before you do. Let me know.

Thanks @thomasleveil!


Version 1.0 deadline

2020 February 9th.

Deadline postponed till January 6th 2020

Postponing till 9th February 2020.

Discarded. Not enough time to meet deadlines.


Can you use this with Optimizely?

https://www.optimizely.com/

Don't need this information anymore.


Add Sylo.app latest version

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked that the cask was not already refused in closed issues.

Added Sylo.app http://www.sylomusic.com/

Thank you for the contribution. It needed some fixes, so they were made in 552ce5573b41969d4e3eac795313f4daf943b970. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Ping Command

/ping command to check on your or other people's ping would be cool, would save me 1 plugin :)

I said /ping or /ping player, I don't know why GitHub removed it

Oo, that would be a cool command, may have a look into on Sunday if i become free :3 What is the name of the current plugin you use for it?

Oo idea! I could see if i can add a ping placeholder, and then users could use the find command type to make a ping command. I could add this with a TPS placeholder if possible.

Oo idea! I could see if i can add a ping placeholder, and then users could use the find command type to make a ping command. I could add this with a TPS placeholder if possible.

:D "PingPlayer", but I only can see the ping of players that are in the same server as me, you knwp, and what's the TPS placeholder for? really curious

ooo ping is easy xD

:D

Added to version 3.8.0 :3
Thank you for your feature request


Email field should not be optional for human users

The email field is declared as optional:
https://github.com/zitadel/terraform-provider-zitadel/blob/97b2d6c6cf46906ae4a15542bdf1b77bfba129f7/zitadel/v2/user.go#L105
But omitting it triggers this error:
Error: failed to create human user: rpc error: code = InvalidArgument desc = invalid AddHumanUserRequest.Email: value is required

Totally missed that, I will have a look at it.

corrected in v1.0.0-alpha.8


Eval.py get_split error?

Hi,
I found a issue of get_split() in eval.py. I think the index of valid and test should be switched. For example, the correct one would be:
def get_split(num_samples: int, train_ratio: float = 0.1, test_ratio: float = 0.8):
assert train_ratio + test_ratio < 1
train_size = int(num_samples * train_ratio)
test_size = int(num_samples * test_ratio)
indices = torch.randperm(num_samples)
return {
'train': indices[:train_size],
'test': indices[train_size: test_size + train_size],
'valid': indices[test_size + train_size:]
}
Thanks!

Thank you for your question! Actually we have fixed this problem in the develop branch.


Fix debug assert in Device::inner_read_pixels

Assert that the provided buffer is at least the size of the bytes to be read, which may be smaller than the texture's buffer size.

Thank you so much for the fix!


⚠ Bofrost.at has degraded performance

In 953b3a1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 986 ms

Resolved: Bofrost.at performance has improved in 635c108 after 13 minutes.


[Test server] body-number.json

[ ] Code generated
[ ] Tests for all scenarios
[ ] API shape questions
[ ] Fix identified issues

Done. Some tests were identified to not work in C#. Closing.


replaced fill_value to 1 instead of close.mean

As found in https://github.com/bukosabino/ta/issues/323, DailyReturnIndicator will cause future data leakage when filling nan values (possibly only on the first row, as it's used with shift(1)).
This PR removed the fillna argument from the shift operation.  This is because if there is no value for the stock in the previous row, the actual value should be NaN. Later, when calling the daily_return method, the user can chose if to fill the NaN or not.
In any case, filling with close.mean() is wrong.

Thank you @yarimiz
The changes will be included in the next version of the library!


error: ‘getuuid’ is not a member of ‘drogon’

while testing httpcontroller example code, getting following error
[ 25%] Building CXX object CMakeFiles/first.dir/controllers/demo_v1_User.cc.o
/home/kanagu/Desktop/first/controllers/demo_v1_User.cc: In member function ‘void demo::v1::User::login(const HttpRequestPtr&, std::function<void(const std::shared_ptrdrogon::HttpResponse&)>&&, std::__cxx11::string&&, const string&)’:
/home/kanagu/Desktop/first/controllers/demo_v1_User.cc:15:18: error: ‘getuuid’ is not a member of ‘drogon’
ret["token"]=drogon::getuuid();
^
CMakeFiles/first.dir/build.make:86: recipe for target 'CMakeFiles/first.dir/controllers/demo_v1_User.cc.o' failed
make[2]: *** [CMakeFiles/first.dir/controllers/demo_v1_User.cc.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/first.dir/all' failed
make[1]: *** [CMakeFiles/first.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

Sorry! This is a error on wiki, you should use the drogon::utils::getUuid() method.


add pre-commit and pre-push files to curl generator

Description:
We need to add pre-commit and pre-push hooks to enhance awareness of our code quality.
Steps to Reproduce:
To achieve this, we should add a configuration file to the project.
Expected Behavior:
Contributors will be more confident about their code quality as it will be automatically checked before commits and pushes.
Additional Information:
An additional file is suggested to be added to the project to implement these hooks.
Please review and consider implementing this enhancement.
pre-commit.zip

assign it to me, I will do it.

closed


Support skipping auto-registration for particular files via configuration code

In https://github.com/dry-rb/dry-system/pull/45#issuecomment-296590276, @solnic, you mentioned this:

We may also consider adding a configuration option ie config.auto_registration_exclude { |dir| dir.include?('entities') } or something like that.

I'm looking to start adding this now, so it can complement the magic comments behaviour and then we can consider a new dry-system release.
However, I feel hesitant to add another setting like config.auto_registration_exclude, for a few reasons:

Firstly, dry-configurable won't make it easy to have a block as the value for the setting like your example. Since it uses blocks for nested settings, we'd have to ask users to provide a proc as the value, which doesn't feel as natural
I'm also wary about "configuration-creep". If we can avoid a setting at the top-level of the container, I think that'd be good.
The user may not want this setting to apply to all their auto-registration paths.
Lastly, and perhaps most critically, the auto-registrar class is a setting itself, and if the default auto-registrar was replaced, it may not even want to pay any attention to a setting like auto_registration_exclude.

So instead of adding another container setting, I wonder if we could reuse the .auto_register!(path, &block) method we alreay have, just extending the block so it supports auto-registration configuration for that particular path. So instead of:
auto_register!('lib') do |component|
  # some custom initialization logic
  constant = component.loader.constant
  constant.create
end

We make it this:
auto_register!('lib') do |config|
  # Both of these configuration blocks are optional

  config.instance do |component|
    # some custom initialization logic
    constant = component.loader.constant
    constant.create
  end

  config.exclude do |component|
    component.path =~ /entities/
  end
end

What do you think? Since this configuration is coupled to our default Dry::System::AutoRegistrar, it feels like a more appropriate place for it.

@timriley oh this is a really nice idea!

Resolved by #47


Build status aborted instead of failed on sls failure ?

Is this intended ?
07:03:47 Running in batch mode. Batch size: 1
07:06:52 ERROR: One or more minion did not return code 0
07:06:52

07:06:52 Build was aborted
07:06:53 Notifying upstream projects of job completion
07:06:53 Finished: ABORTED

Was the build actually aborted? If so, displaying the ERROR message is a bug.

Salt just failed because of error in sls.
Job status is aborted.

That would also be a bug and is corrected in master branch.

Closing, since it's corrected in master branch


order by FIELD?

I want use custom rules in order by.  how implement order by ：3  1  4  2
eg:
| status  |   value |
|      A     |   1     |
|     B     |   2      |
|     C     |   3      |
|      D    |   4      |

Can you flesh this question out?  I don't understand it.

I solved the problem.
just want custom sorting data

Np @agoodcoolman.  So this can be closed?  Anything to add?

yes ,you can close~


Update README to be more of a tutorial

Modeled off of this tutorial and the app service readme. This definitely simplifies things and hopefully gives people the most bang for their buck. Moved some of the deleted sections to the wiki
Fixes https://github.com/microsoft/vscode-azurefunctions/issues/1726

I think @wwlorey is more than qualified to be the approving voice.


move all conf to pyproject

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

What does this PR do?
just minor cleaning
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @Borda! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/repo_stats/data_io.py:

Line 94:80: E501 line too long (103 > 79 characters)

In the file src/repo_stats/host.py:

Line 206:80: E501 line too long (102 > 79 characters)


[Cloud Tasks] Add HTTP push queue sample

Ping @dzlier-gcp, do you mind reviewing today or tomorrow?

Taking a look now.

In order to be consistent with other languages I moved the HTTP task sample to it's own directory.

ping @dzlier-gcp (Sorry to bug you again, but trying to get this done by the EOW)


Support for PascalCase class names

Is there any way this could support PascalCase class names? The codebase at my company has a lot of CSS modules that contain class names that match the components they style, i.e. <Task className={styles.Task}>...</Task>.
Currently, the lsp returns the class in camelCase which resolves to undefined and causes the element to have no className attribute.
For example:

Choosing the classOne option results in
Should be red
 being rendered

Apologies for getting back to you late. You can turn off camelCase option (false) and the class names will be returned as is. Please see the docs for camelCase option and how to set it depending on what you are using for lsp setup.

Ah my bad! I saw in the table that false is marked as the default so I thought that was the behaviour I was getting. Setting it to false manually does the trick!
Does that mean that false isn't the default?

Oh, there was a typo in the docs. true is the actual default setting. I've updated the docs to reflect it. Thanks for surfacing!


Add support for FileContents#getAsText() with a charset/encoding argument

Closes #15802
Context

Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

It might be good to also add a similar overload to ExecOutput.StandardStreamContent.

@mlopatkin

It might be good to also add a similar overload to ExecOutput.StandardStreamContent.

Do you expect it to be a separate PR or to be inside this one?

I don't mind having it here, but a separate PR can also work if it suits you better.

I will add a (real) good first issue as a follow-up @mlopatkin

Thanks for finally implementing this. :-)
Would it make sense to also improve the CC docs in the course of this PR regarding what I wrote in the first comment of that issue?

Would it make sense to also improve the CC docs

@Vampire Yes, I think so. I would wait for a consensus on the code implementation, and then I will patch the docs too


[MINOR][SQL] Fix comment in KeyGroupedPartitioning not match with parameter

What changes were proposed in this pull request?
Since #39540, change parameter partitionValuesOpt to partitionValues, but didn't change comment on method.

Why are the changes needed?
Fix comment not up to date.

Does this PR introduce any user-facing change?
No

How was this patch tested?
unnecessary.

Merged to master.

Late LGTM, thanks @Hisoka-X !


Prune events of closed positions

Likely keep around a read-model of last state.

Instead of pruning, we could also append a final snapshot event that summarizes the final values like payout, on-chain transactions, P/L etc.
The CFD would have to store a pointer to this event so we can skip ahead and directly load this.
This would improve CPU performance but not storage size. I believe we should address these two concerns differently though.

Closing in favor of https://github.com/itchysats/itchysats/issues/1404 because it is more general.


Problem with file pattern src/app/**/*.ts to get all ts files whatever the depth

When using the following command:
ngx-extractor -i src/app/**/*.ts -f xlf -o src/assets/i18n/source.xlf

I expect the command to handle all files with the extension ts in all folders under the src/app one whatever the depth. In my case, it only gets the file under direct subfolders of the src/app one.
I investigated a bit the problem but can't see option for this in the yargs library. It should be directly the case (every sub folders whatever the depth with the pattern src/app/**/*.ts.
Any idea? Thanks!

Hi, i had the same issue.
adding to the pattern solved the issue in my side :
ngx-extractor -i "src/**/*.ts" -f xlf -o src/locale/messages.xliff


Build plan should more clearly distinguish custom build steps

Currently each build script in a build produces two invocations in the build plan--one to compile the build script, and one to run it. However, they both have "target_kind": ["custom-build"] so it's difficult to distinguish them when consuming a build plan.
In my cargo-build-plan-graph tool I wound up using a heuristic that I do not love. It would be better if they had unique target_kind keys or some other straightforward way to distinguish them.
Here's a sample build plan from sccache.

For now a better heuristic might be endswith("build-script-build")

I think that would be starts_with("build-script-") since the user can change the name with the build key.

Huh, I never thought about the build being user dependent; is that documented anywhere? It seems needlessly complicated...

The key is documented in build scripts and the manifest reference.  It doesn't really talk about the binary/crate name of the build script, presumably because that's not something that's really relevant to most users.

Is changing the target_kind something we're happy to change in Cargo?  (post soft freeze)

It might get complicated if something like #5855 is implemented.  Something like Doctest would appear with target_kind=["lib"] with no other distinction.  target_kind could be sort of a mix between TargetKind and CompileMode.  I'm trying to think if it would be better to keep them separate, but I can't think of a good one.

cc #5508 which also discusses the problems with target_kind in the build-plan.


Add "view file before commit/PR"

When viewing a commit page, GitHub provides a link to view each file. The link points to the file at the current commit. Example.

However, sometimes we want to view the version of a file before the commit was made.
For the longest time I have been doing this manually, by clicking "view file" and then editing the URL to add a ^ at the end of the commit (to reference the parent commit).
It would be very useful if this was added as a link in the menu, so we don't have to resort to hacking the URL like this.
This would also be useful in PRs, where GitHub similarly shows a "view file" link for each file in the diff. Sometimes we want to view the version of a file before all of the commits in this PR.

For the longest time I have been doing this manually, by clicking "view file" and then editing the URL to add a ^ at the end of the commit (to reference the parent commit).

What about an alt-click to go to the parent commit?

Sometimes we want to view the version of a file before all of the commits in this PR.

I think this would make sense as its own button. Also it would need to handle files created with this pr.

@yakov116 That would work, although it's less discoverable.

I find the lack of this really annoying. Is it possible that there’s no path to that page? I think it’s at least 3 clicks/pages away, which isn’t good.
Suggestions welcome. Alt-click isn’t ideal in this case.

Is it possible that there’s no path to that page?

Isn't it just as simple as replacing the commit param in the URL with the following?

For commits, ${COMMIT}^
For PRs, the name of the base branch

My question was: how is it possible that GitHub didn’t add this feature? Is there any other non-obvious way to reach that page?
I’m not talking about “how to fix it,” because as you said it’s pretty easy.

How about this?

@OliverJAsh Where do you expect to see the commit on the base branch or the head branch?

On the base branch/commit I think? (The existing "view file" points to the head branch/commit.)

This is possible:

Made by:

Wrap the existing .dropdown-item link into .d-flex
Add identical link but use icon instead of text
width: min-content; padding-left: 8px

<div class="d-flex">
  {previousLink}
  <a {… previousLink classes} style="padding-left: 8px !important;width: min-content;">
    <GitHistoryIcon/>
  </a>
</div>

This should be applied to regular commits as well.
If a file is deleted by the current commit, the "View file" already points to the old commit, so in that case perhaps we should add the icon inside the existing link; this would indicate that the link points to the old commit.

That feature is much needed. Could I work on this?

Yes please! Refer to my last implementation example

Not one-click, but this is possible via the View History link added by more-file-links


feat: remove need of epmd

I've setup epmdless for the output of mix release.
I am not sure whether it's a good idea to make next-ls epmdless for development - it would involve a bit more work and would make remote shell connections a bit more challenging, namely, require a bunch of extra arguments. I've done some research and there does not seem to be a straightforward way to setup Erlang emulator flags in Elixir outside of mix release without using ERL_FLAGS environment variable.
Closes https://github.com/elixir-tools/next-ls/issues/204

I think that you'll need to pass some of those VM args to (like epmd_module) to the Port that starts the runtime, or else it will still use epmd
... but now I'm also wondering if that will work, since epmdless won't be installed in the runtime 🤔.
Let me know how it goes
Also, thank you so much for this contribution! I was just waffling whether to tackle this or to tackle something else, and you helped me make my choice 👍

Messed up my fork, and as we discussed this work is insufficient.


Make java - spring - tests more stable.

Now java - spring - tests pipeline always failed， it will success after retry. We need to investigate it, make it more stable.
Example: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1058988&view=logs&j=9964ab8e-8452-50bb-86e1-d9c7e04055fa&t=f7dd14df-ecb6-551c-c8a6-473ddede036b&l=568

Closing this issue. Because in version 4.0, Azure AD related integration test has been removed.


Add an option to enable/disable all scenarios requests

It shouldn't turn off the scenario but go over each mocked request and turn them on or off

Implemented in 2.0


Hub on another Flow

Hi how can i use the same hub on another flow? The port is busy.
"Error: listen EADDRINUSE :::80"
Unable to start on Port 80

You need to use only one hub and connect all to this. To connect to another flow, use link nodes.

That works for me thank you.


Defensively create custom turbo elements

There are instances when turbo attempts to create the frame and stream
elements when they have already been registered. This is easily
reproducible in development when using webpacker by following these steps:

Make a change to any file that webpacker compiles.
Click a turbo enabled link.
Boom.

When Turbo replaces the page it appears as if it reloads the Turbo
library and attempts to create the custom elements again. I have also
observed this behavior in my production app via my exception monitoring
service, but have been unable to reproduce this behavior in production
on my own.
This change simply checks for the existence of the custom element prior
to to attempting to define it. The get method used here explicitly
returns undefined when the element does not yet exist so it is safe to
use the strict equality operator here. Reference:
https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry/get
Fixes #188

Update: This happens reliably in production when the webpack bundle has changed (after a deploy) and a turbo enabled link is clicked.

Yet another update: After updating my application to use jsbundling-rails and esbuild I am no longer seeing this error on deploys (or at all for that matter).

Is that with or without this patch with your update to jsbundling-rails?

@t27duck Without the patch. I honestly don't know why. 🤷

We can also reproduce this in production where on deploy, the bundle changes and this error is triggered after clicking on any turbo link. Would love to see this merged.


Refactor function config key-values to experiment JSON file

Fixes issue #263.
Changes

Update Configuration struct to include Runtime field
Update SubExperiment struct to include Handler and PackagePattern fields
Add default values for newly added fields (Runtime, Handler, PackagePattern)
Update hellopy experiment JSON files to include new fields
Replace hardcoded values in src/setup/serverless-config.go with newly added fields (Awaiting Serverless config PR before doing this)

These fields must now be specified in the experiment JSON file. More fields can be added to the Configuration/SubExperiment struct as needed in the future.
Note: Github Actions seem to be failing because this branch is from a fork and does not have access to credentials.

Closed as this is replaced by #268.


Change filenames of report, timeline, trace, and dag files

Description of feature
A date such as 2024-01-03 some folks might confuse, unsure if its:

January 3rd, 2024
March 1st, 2024
so simply adding month in character form will avoid that issue.

Current

trace files have integers for month, should be letters
day of the week is not reported at all, and should be added

nextflow.config has a simple 1-liner:
def trace_timestamp = new java.util.Date().format("yyyy-MMM-dd EEE HH:mm:ss")
Request
Possible considerations to add lines prior:
def trace_timestamp = new java.util.Date().format('yyyy-MMM-dd_EEE_HH-mm-ss')
gives a filename of e.g., execution_trace_2024-Jan-10_Wed_14-31-28.txt
Having both in all caps might look better but would add extra lines to individually invoke .toUpperCase() on just the month and just the day of week. End goal is to have:  execution_trace_2024-JAN-10_WED_14-31-28.txt or just execution_trace_2024-Jan-10_Wed_14-31-28.txt which would correspond to a unix cmd like date '+%Y-%b-%d_%a_%H-%M-%S'

this was fixed in commit fc38a72b68df0895fc64e75933d5fafd1455b7b1


Schematica not printing for me Both SP and MP 1.8.9

Hey, I kept searching other issues about printer not working but none of them worked for me yet.
I am using Cosmic client 2.0 with schematica. All of schematica works for me besides the printer section. Might it be because of the (modpack) since the server allows printer i have no idea what to do.

Okay i got it to work i can now click the print button and it makes movement. Now the only problem is that the blocks aren't placing. I tried all the block placement options but none work

Test if it works with only Forge, LunatriusCore and Schematica.

Closing due to lack of feedback.


Anyone can access the dashboards and datasets via the login page even without logging in, anything wrong with my configuration?

Screenshot

Description
Anonymous user can access the dashboards and data(including datasets and databases), however if click charts, it throws an unexpected error like this

Version: 1.5.0
SHA: 24cf33ee
my superset_config.py:

from flask_appbuilder.security.manager import AUTH_LDAP
from celery.schedules import crontab
from superset.typing import CacheConfig

SQLALCHEMY_DATABASE_URI = 'xxxx'

APP_NAME = "xxxx"

# ----------------------------------------------------
# AUTHENTICATION CONFIG
# ----------------------------------------------------
# The authentication type
# AUTH_OID : Is for OpenID
# AUTH_DB : Is for database (username/password)
# AUTH_LDAP : Is for LDAP
# AUTH_REMOTE_USER : Is for using REMOTE_USER from web server
AUTH_TYPE = AUTH_LDAP

# Uncomment to setup Full admin role name
AUTH_ROLE_ADMIN = 'Admin'

# Uncomment to setup Public role name, no authentication needed
AUTH_ROLE_PUBLIC = 'Public'

# Will allow user self registration
AUTH_USER_REGISTRATION = True

# The default user self registration role
AUTH_USER_REGISTRATION_ROLE = "Public"

PUBLIC_ROLE_LIKE = "Gamma"

# When using LDAP Auth, setup the LDAP server
# AUTH_LDAP_SERVER = "ldap://ldapserver.new"
AUTH_LDAP_SERVER = " xxxx"
AUTH_LDAP_SEARCH = "xxxx"
AUTH_LDAP_UID_FIELD = "sn"
AUTH_LDAP_LASTTNAME_FIELD = "cn"
AUTH_LDAP_BIND_USER = "xxxx"
AUTH_LDAP_BIND_PASSWORD = "xxxx"

# FEATURE_FLAGS: Dict[str, bool] = {}
FEATURE_FLAGS = {
    "ALERT_REPORTS": True,
    # This could cause the server to run out of memory or compute.
    "ALLOW_FULL_CSV_EXPORT": True,
}

# ---------------------------------------------------
# Thumbnail config (behind feature flag)
# Also used by Alerts & Reports
# ---------------------------------------------------
THUMBNAIL_SELENIUM_USER = "xxxx"

# Default cache for Superset objects
CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "simple"}

# Cache for datasource metadata and query results
DATA_CACHE_CONFIG: CacheConfig = {"CACHE_TYPE": "simple"}

# CSV Options: key/value pairs that will be passed as argument to DataFrame.to_csv
# method.
# note: index option should not be overridden
CSV_EXPORT = {"encoding": "utf-8"}

# Default celery config is to use SQLA as a broker, in a production setting
# you'll want to use a proper broker as specified here:
# http://docs.celeryproject.org/en/latest/getting-started/brokers/index.html

class CeleryConfig:  # pylint: disable=too-few-public-methods
    # BROKER_URL = "sqla+sqlite:///celerydb.sqlite"
    BROKER_URL = 'xxxx'
    CELERY_IMPORTS = ("superset.sql_lab", "superset.tasks")
    # CELERY_RESULT_BACKEND = "db+sqlite:///celery_results.sqlite"
    CELERY_RESULT_BACKEND = 'xxxx'
    CELERYD_LOG_LEVEL = "DEBUG"
    CELERYD_PREFETCH_MULTIPLIER = 10
    CELERY_ACKS_LATE = True
    CELERY_ANNOTATIONS = {
        "sql_lab.get_sql_results": {"rate_limit": "100/s"},
        "email_reports.send": {
            "rate_limit": "1/s",
            "time_limit": 300,
            "soft_time_limit": 300,
            "ignore_result": True,
        },
    }
    CELERYBEAT_SCHEDULE = {
        "email_reports.schedule_hourly": {
            "task": "email_reports.schedule_hourly",
            "schedule": crontab(minute=1, hour="*"),
        },
        "reports.scheduler": {
            "task": "reports.scheduler",
            "schedule": crontab(minute="*", hour="*"),
        },
        "reports.prune_log": {
            "task": "reports.prune_log",
            "schedule": crontab(minute=0, hour=0),
        },
    }

# smtp server configuration
EMAIL_NOTIFICATIONS = True  # all the emails are sent using dryrun
SMTP_HOST = "xxxx"
SMTP_STARTTLS = True
SMTP_SSL = True
SMTP_USER = "xxxx"
SMTP_PORT = 465
SMTP_PASSWORD = "xxxx"
SMTP_MAIL_FROM = "xxxx"

ENABLE_CHUNK_ENCODING = True

# Enable / disable scheduled email reports
#
# Warning: This config key is deprecated and will be removed in version 2.0.0"
ENABLE_SCHEDULED_EMAIL_REPORTS = True

# A custom prefix to use on all Alerts & Reports emails
EMAIL_REPORTS_SUBJECT_PREFIX = "xxxx"

# The base URL to query for accessing the user interface
WEBDRIVER_BASEURL = "xxxx"
# The base URL for the email report hyperlinks.
WEBDRIVER_BASEURL_USER_FRIENDLY = "xxxx"

WTF_CSRF_TIME_LIMIT = None

update
By removing "menu access of dashboards", "menu access of charts", "menu access of data“ of Public role, anonymous user cannot access these components anymore.


Calculating addresses of call, jmp etc.

With zydis, you can call ZydisCalcAbsoluteAddressEx, but there is no way to retreive the relevant data to perform this from the Decoder.
Can you suggest any way to do this please?

You actually don't need to, the resulting Instruction object has no relative immediates, you can just read the first operand and its value.
Something like this should work:
if(auto* imm= instr.tryGetOperandAs<operands::Imm>(0); imm != nullptr)
{
   auto va = imm->value<uint64_t>();
}

Great, thank you @ZehMatt, it works perfectly.


[binary to decimal or other operations]

Description
converting the binary to hexa, octa or deci
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

We already have Number System Calculator for this, pls create new issues @prajwaldp223


Fix typo and wrong os.path.join usage in gluon_base_service.py

Fix typo and wrong os.path.join usage in gluon_base_service.py + update deprecated load_params to load_parameters

curl 'https://api.thomasdelteil.com/predictions/crepe' -H 'Accept: application/json' -H 'Content-Type: application/x-www-form-urlencoded' --data 'data=%5B%7B%22review%22:%22Test%22,%22review_title%22:%22%22%7D%5D'
{
  "confidence": {
    "Clothing_Shoes_and_Jewelry": 0.259,
    "Home_and_Kitchen": 0.157,
    "Sports_and_Outdoors": 0.092,
    "CDs_and_Vinyl": 0.069,
    "Movies_and_TV": 0.122,
    "Cell_Phones_and_Accessories": 0.218,
    "Books": 0.077
  },
  "predicted": "Clothing_Shoes_and_Jewelry"


Merge #15022 into berkeley

The changes from #15022 were already present in this branch, so this PR changes no files and just resolves the conflict.

!ci-build-me


[Bug] Annotation Tools are always synchronised across viewports

Describe the Bug
While using tools across multiple viewports, the annotations tools will draw across all viewports. This isn't the case with manipulation tools like pan, zoom, w/l, etc.
I have tried creating multiple RenderingEngines, but doesn't fix it. But I'm not sure if multiple RE's are the way to go.
Steps to Reproduce
I have used 'volumeViewportSynchronization' in the cs3d examples to reproduce the issue, mapped the Secondary Button to Length Tool, and the Primary to W/L.
In the screens below, you can see sync is off, and the W/L levels change for each viewport, but in the case of the LengthTool, drawing on one viewport will mirror the annotation on the other viewports.
The current behavior
Annotation Tools  (Probe, Length, CobbAngle) are being synchronized across multiple viewports, even when sync is off. Screenshot below.

The expected behavior
Annotations should only appear on the viewport being modified, in case of multiple viewports, unless synchronized.

OS
Ubuntu 22.04
Node version
20.11.1
Browser
Brave v1.62.165

so do you want it to not appear in the other viewports? volume viewports by design will show (not only the same series) but also if other seires are in the same position in the space, if you don't need MPR you can use stack viewports


Develop apps

Phylo was deleted because the idea was not the correct one. I do not want to stay too much behind master, so id rather merge at this point

Hey, dont worry about master. We can update branches easily since we dont have so much commits ahead. OS is almost ready.

Lookin' good! I have two more suggestions:

right-click -> format on all files 😈
rename namedPipes to namedPipesTest to avoid confusion

I have not applied the formatter over the files because im not sure if the result i got was the expected. Dispite of that , i think this branch is ready to be merged. All the changes and suggestions have been applied


Add tape recorders

About the PR
Added tape recorders
Based on https://github.com/space-wizards/space-station-14/pull/10522
I reused the assets and ideas
Why / Balance
More options for roleplay
Options for framing a person, by replaying part of a conversation out of context or using a voice changer
Technical details

Tape recorder hears all spoken words within a range of 4 tiles, whispers are only audible within 1 tile.
Messages are recorded onto the tape cassette, correctly handling the voice changer
Tape recorder can be swapped between playback, recording and rewinding modes - and then used in-hand to start/stop that mode
Tapes hold 3 minutes of audio, and the recorder will auto stop when the limit is reached
A tape can be damaged, which will corrupt a random entry - it must then be repaired (respooled) with a pen or screwdriver before it can be played again. Corrupted entries will remain corrupted.
On each damage event, a single message will have ~25% of its contents replaced with '#', the same message will be progressively more corrupted if its chosen on multiple damage events.
Tapes and a recorder have been added to the CuraDrobe, LawDrobe and DetDrobe, Reporter Backpack fill. And maints loot with a 5% spawn chance.
Its possible to define pre-recorded tapes, i have included a tape as an example (admin spawn only)
Tapes can be labelled

Media
https://github.com/space-wizards/space-station-14/assets/11758391/d814032f-8976-4116-815e-77f63560e4b1

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

add: Added tape recorders

I can add it to the CuratorDrobe, not sure how to add it to the reporter - they dont have lockers or a drobe.
Could also be added to maints loot?

not sure how to add it to the reporter - they dont have lockers or a drobe.

Add it to their backpack fill

Added to the reporter backpack

I'm keen to see this get in! I had a PR up with a similar idea, but this PR implements the idea more fully and integrates better with existing game systems.

would be good to add inhand sprites

this is really cool

would be good to add inhand sprites

Added them

Should the tape recorder when played back state the origin of the voice or should the voice be from tape recorder? Difficult one to answer.

Clown recorder is a separate thing - it just plays a sound effect on use.
This tape recorder doesnt have (currently) the ability to play sound effects.
I could make it say 'tape recorder says', but i imagine it has more uses for antags if it says the name of the voice.

Should the tape recorder when played back state the origin of the voice or should the voice be from tape recorder? Difficult one to answer. Currently when bob records his voice saying hello and then bob plays back the tape it appears as bob says hello. Should it be tape recorder hello.

In my defunct PR, the recorder wrapped the player's name in the name of the device, like a handheld radio does. I can maybe see potential for two versions of the recorder - a normal one that does that, and then a syndicate one that masks the origin for the purpose of misleading people.

It would be easy to add a 'High Quality Speaker' flag which determines if it says 'Tape Recorder (Bob)' or just 'Bob', then add the high quality version to the uplink.
At the same time i like the idea of antags being able to repurpose standard items for their goals - rather than relying on TC to aquire them, they only get a limited amount of TC after all and if they are caught they will probably lose most of the items they have.
Could use some input on that, are we shifting towards antags being required to purchase any item that can further their goals?

Maybe then it's something where you use a screwdriver, and it is examinable as "tampered with". The illusion of the voice will work as long as the person has a way of keeping the recorder hidden on their person (pocket, bag, storage implant...) - a clever detective would be able to figure it out, but it would fool anyone not looking carefully.

Just had a thought - this could be used for a minor antag, "Spy". Objective: "Record X seconds of Captain/CE/CMO/QM/RD speaking, then sneak the tape aboard a cargo shipment."

Licenses updated
Having some issues with keeping the tape position sync'd between client and server - client seems to be 8-10% faster than server on my setup.
Worked around this by making the position field networked, and dirtied when the tape recorder stops.
Let me know if more documentation is required

Isn't that going to spam network states every tick

No, it only dirties the tape position when you (or the Update method) stops the tape.

I think the attributions are correct now.

CI is a problem with LocId and an unrelated container fill - fixed.
I'm not really sure where to start with the prediction issue, both server and client are running the code from shared.
I checked the frame times and both are 0.0166666ms per tick.
The last thing i can think of is that some update ticks are not running client side - but the only difference between client/server is IGameTiming.IsFirstTimePredicted.

If the data isn't being dirtied properly then they won't ever get in sync until something happens.

The desync issue is resolved, turned out to be my client dropping frames.
Client side update now uses CurTime and keeps sync correctly.

It will be interesting to use this in the interrogation of the clown

I dont have any experience with UI's, besides adding a single label to the health analyzer.
As for the number of lines, i tend to be quite verbose - the majority (600) of the lines are in SharedTapeRecorderSystem.
Rewinding is pretty straight forward - im just decrementing the tape position by the elapsed time * rewind speed
https://github.com/space-wizards/space-station-14/blob/a9dad3afbbae7f517c8f2729020dc2040d30bf31/Content.Shared/TapeRecorder/SharedTapeRecorderSystem.cs#L225-L240
Codesize could be reduced by removing a bunch of the helper methods - at the expense of maintainability.

Sorry what status has this PR now? I tried to run it but this didn't build.

Closed due to feature freeze May 10th-June 14th. Comment to have it reopen after this.


Improve cycling routes and rider safety. Discourage car use.

i don't...

Sounds good to me
Vote: ✅


no rate-limiting for test environments

Summary
This reapplies the rate limiting if process.env.NODE_ENV 'development' is used, so rate limiting is only disabled if process.env.NODE_ENV === 'test'
Description for the changelog
no rate-limiting for test environments
Other info

rate limiting can not be applied when in 'development' mode, as this is used by the end-to-end tests


Fix Issue #367: Value of $_ overwritten in bash

Fix Issue #367 based on this answer

I don't think how we hook in chruby_auto works within the unit-test functions. I had to explicitly invoke chruby_auto to simulate it running after other commands.

@postmodern how should I deal with that in this PR?

@postmodern Merry Festivus. Where to from here?

@HaleTom so trap '...' DEBUG does not capture commands invoked from within functions, only at the top level. This means chruby_auto is automatically invoked in your unit-test. We need to device a test that actually exercises this somehow.

#!/bin/sh

trap 'echo "Command: $BASH_COMMAND"' DEBUG

func() {
	echo 'inside of a function'
}

echo 'outside of a function'
func

set -o functrace is what you're after.
Adding this, the output is:
Command: echo 'outside of a function'
outside of a function
Command: func
Command: func
Command: echo 'inside of a function'
inside of a function

I'm not sure why Command: func is duplicated... let me know if it's an issue.
I'm having a brain-fart: how do I run the tests again? (I couldn't see anything in CONTRIBUTING about it).
Let me know if I can help out with anything from here.

@postmodern Here is the code you want:
#!/bin/bash
set +o functrace
trap 'trap_func' DEBUG

trap_func() {
  [[ $BASH_COMMAND != "${FUNCNAME:0}" ]] && echo "Command: $BASH_COMMAND"
}

func() {
  echo 'inside of a function'
}

echo 'outside of a function'
func

Please let me know what the next step is.

@postmodern, @steakknife,
Any blockers to merge this?

Just checking in on this as it's been one human gestation since the last comment.
What is the next step here?

I see that Travis on Apple didn't seem to run correctly - it has null output.
Is this expected?  Any other blockers to merging?

@HaleTom Apple (still) ships with Bash 3, so unfortunately all code has to be Bash 3 compatible. I have since switched to GitHub Actions, however I still need to fix how the test suite downloads/installs the macOS test ruby, which must be compatible with GitHub Action version of macOS.


Bundler conflicts with ruby-2.6.1/bin/bundle

I'm using ruby 2.6.1 and bundler 2.0.1 for my ruby app.
When I was trying to deploy app I got the following error:
remote: -----> webpack-rails app detected
remote: -----> gem install bundler
remote: ERROR:  Error installing bundler:
remote: 	"bundle" from bundler conflicts with /tmp/build_5f23e64fd8050f5654d8fe6ab7e0bd8d/vendor/ruby-2.6.1/bin/bundle
remote:  !     Push rejected, failed to compile webpack-rails app.
remote:
remote:  !     Push failed

Is there any workaround to this issue?

Possibly related to rubygems/rubygems#2058.
Some people seem to run the bundler install with --force option, if I got that right.
I don't have the bandwidth right now to look properly into it, though, unfortunately.
@ktaras you find a solution yet?

@febeling thanks.
I had to downgrade ruby to version 2.5.3 and bundler to 1.17.3. I'm planning to migrate to webpacker anyway, so it's a temporary fix.


OpenJDK 14 for AdoptOpenJDK

Microsoft Reviewers: Open in CodeFlow

@karianna AFAICT the API does not give an MSI. Only ZIP.
https://api.adoptopenjdk.net/swagger-ui/#/Binary/get_v3_binary_version__release_name___os___arch___image_type___jvm_impl___heap_size___vendor_


program: add auction params to trigger limits

as discussed, should avoid letting trigger limit orders be makers if the following is true:

direction == long AND trigger < limit
direction == short AND trigger > limit


[BUG]: Deleting in a Git Tree Fails When Passing Null or "Null"

What happened?
https://docs.github.com/en/rest/git/trees?apiVersion=2022-11-28
When passing a null - the value is not serialized inside TreesPostRequestBody_tree and an error is thrown that Content or Sha must be passed.  If you pass a "null" it throws an error => sha null is not a valid blob
We need to be able to pass just a null to delete a blob in a Pull Request (Tree)
`sha string or null
The SHA1 checksum ID of the object in the tree. Also called tree.sha. If the value is null then the file will be deleted.
Note: Use either tree.sha or content to specify the contents of the entry. Using both tree.sha and content will return an error.`
Versions
octokit v.0.0.14
.net 8
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Interesting...our YAML OpenAPI schema definition looks like this:
  "/repos/{owner}/{repo}/git/trees":
    post:
      summary: Create a tree
      description: |-
        The tree creation API accepts nested entries. If you specify both a tree and a nested path modifying that tree, this endpoint will overwrite the contents of the tree with the new path contents, and create a new tree structure.

        If you use this endpoint to add, delete, or modify the file contents in a tree, you will need to commit the tree and then update a branch to point to the commit. For more information see "[Create a commit](https://docs.github.com/rest/git/commits#create-a-commit)" and "[Update a reference](https://docs.github.com/rest/git/refs#update-a-reference)."

        Returns an error if you try to delete a file that does not exist.
      tags:
      - git
      operationId: git/create-tree
      externalDocs:
        description: API method documentation
        url: https://docs.github.com/rest/git/trees#create-a-tree
      parameters:
      - "$ref": "#/components/parameters/owner"
      - "$ref": "#/components/parameters/repo"
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: object
              properties:
                tree:
                  type: array
                  description: Objects (of `path`, `mode`, `type`, and `sha`) specifying
                    a tree structure.
                  items:
                    type: object
                    properties:
                      path:
                        type: string
                        description: The file referenced in the tree.
                      mode:
                        type: string
                        description: The file mode; one of `100644` for file (blob),
                          `100755` for executable (blob), `040000` for subdirectory
                          (tree), `160000` for submodule (commit), or `120000` for
                          a blob that specifies the path of a symlink.
                        enum:
                        - '100644'
                        - '100755'
                        - '040000'
                        - '160000'
                        - '120000'
                      type:
                        type: string
                        description: Either `blob`, `tree`, or `commit`.
                        enum:
                        - blob
                        - tree
                        - commit
                      sha:
                        type: string
                        description: "The SHA1 checksum ID of the object in the tree.
                          Also called `tree.sha`. If the value is `null` then the
                          file will be deleted.  \n  \n**Note:** Use either `tree.sha`
                          or `content` to specify the contents of the entry. Using
                          both `tree.sha` and `content` will return an error."
                        nullable: true
                      content:
                        type: string
                        description: "The content you want this file to have. GitHub
                          will write this blob out and use that SHA for this entry.
                          Use either this, or `tree.sha`.  \n  \n**Note:** Use either
                          `tree.sha` or `content` to specify the contents of the entry.
                          Using both `tree.sha` and `content` will return an error."
                base_tree:
                  type: string
                  description: |-
                    The SHA1 of an existing Git tree object which will be used as the base for the new tree. If provided, a new Git tree object will be created from entries in the Git tree object pointed to by `base_tree` and entries defined in the `tree` parameter. Entries defined in the `tree` parameter will overwrite items from `base_tree` with the same `path`. If you're creating new changes on a branch, then normally you'd set `base_tree` to the SHA1 of the Git tree object of the current latest commit on the branch you're working on.
                    If not provided, GitHub will create a new Git tree object from only the entries defined in the `tree` parameter. If you create a new commit pointing to such a tree, then all files which were a part of the parent commit's tree and were not defined in the `tree` parameter will be listed as deleted by the new commit.
              required:
              - tree
            examples:
              default:
                value:
                  base_tree: 9fb037999f264ba9a7fc6274d15fa3ae2ab98312
                  tree:
                  - path: file.rb
                    mode: '100644'
                    type: blob
                    sha: 44b4fc6d56897b048c772eb4087f854f46256132
      responses:
        '201':
          description: Response
          content:
            application/json:
              schema:
                "$ref": "#/components/schemas/git-tree"
              examples:
                default:
                  "$ref": "#/components/examples/git-tree"
          headers:
            Location:
              example: https://api.github.com/repos/octocat/Hello-World/trees/cd8274d15fa3ae2ab983129fb037999f264ba9a7
              schema:
                type: string
        '422':
          "$ref": "#/components/responses/validation_failed"
        '404':
          "$ref": "#/components/responses/not_found"
        '403':
          "$ref": "#/components/responses/forbidden"
        '409':
          "$ref": "#/components/responses/conflict"
      x-github:
        githubCloudOnly: false
        enabledForGitHubApps: true
        category: git
        subcategory: trees

Note nullable: true, which should allow for passing null. Perhaps this is a Kiota issue?

is there a work around?


Proposal refactor : Use dockerCmd to run docker commands in integration-cli tests

As discussed a little bit on IRC, it would be could if almost all cli integration test would use dockerCmd.
This issue is there to list the files that need updates so we can share the work :wink:. I'll keep this list up-to-date when PR will be merged. If you wanna work on this, please comment which file(s) you wanna work on, and I'll add your name :sweat_smile:.
If the test needs to check out that it errors out (err != nil) then do not use dockerCmd — but you could use something like : runCommandWithOutput(exec.Command(dockerBinary, "diff", "")) (like here).

[ ] integration-cli/docker_cli_attach_test.go (vdemeester)
[ ] integration-cli/docker_cli_attach_unix_test.go (vdemeester)
[ ] integration-cli/docker_cli_build_test.go (vdemeester)
[ ] integration-cli/docker_cli_build_unix_test.go (vdemeester)
[ ] integration-cli/docker_cli_by_digest_test.go (vdemeester)
[ ] integration-cli/docker_cli_commit_test.go (vdemeester)
[ ] integration-cli/docker_cli_config_test.go (vdemeester)
[ ] integration-cli/docker_cli_cp_test.go (vdemeester)
[ ] integration-cli/docker_cli_create_test.go (vdemeester)
[ ] integration-cli/docker_cli_daemon_experimental_test.go
[ ] integration-cli/docker_cli_daemon_test.go
[ ] integration-cli/docker_cli_diff_test.go
[ ] integration-cli/docker_cli_events_test.go
[ ] integration-cli/docker_cli_events_unix_test.go
[ ] integration-cli/docker_cli_exec_test.go
[ ] integration-cli/docker_cli_exec_unix_test.go
[ ] integration-cli/docker_cli_experimental_test.go
[ ] integration-cli/docker_cli_export_import_test.go
[ ] integration-cli/docker_cli_help_test.go
[ ] integration-cli/docker_cli_history_test.go
[ ] integration-cli/docker_cli_images_test.go
[ ] integration-cli/docker_cli_import_test.go
[ ] integration-cli/docker_cli_info_test.go
[ ] integration-cli/docker_cli_inspect_test.go
[ ] integration-cli/docker_cli_kill_test.go
[ ] integration-cli/docker_cli_links_test.go
[ ] integration-cli/docker_cli_links_unix_test.go
[ ] integration-cli/docker_cli_login_test.go
[ ] integration-cli/docker_cli_logs_test.go
[ ] integration-cli/docker_cli_nat_test.go
[ ] integration-cli/docker_cli_network_test.go
[ ] integration-cli/docker_cli_pause_test.go
[ ] integration-cli/docker_cli_port_test.go
[ ] integration-cli/docker_cli_port_unix_test.go
[ ] integration-cli/docker_cli_proxy_test.go
[ ] integration-cli/docker_cli_ps_test.go
[ ] integration-cli/docker_cli_pull_test.go
[ ] integration-cli/docker_cli_push_test.go
[ ] integration-cli/docker_cli_rename_test.go
[ ] integration-cli/docker_cli_restart_test.go
[ ] integration-cli/docker_cli_rmi_test.go
[ ] integration-cli/docker_cli_rm_test.go
[ ] integration-cli/docker_cli_run_test.go
[ ] integration-cli/docker_cli_run_unix_test.go
[ ] integration-cli/docker_cli_save_load_test.go
[ ] integration-cli/docker_cli_save_load_unix_test.go
[ ] integration-cli/docker_cli_search_test.go
[ ] integration-cli/docker_cli_service_test.go
[ ] integration-cli/docker_cli_start_test.go
[ ] integration-cli/docker_cli_start_volume_driver_unix_test.go
[ ] integration-cli/docker_cli_stats_test.go
[ ] integration-cli/docker_cli_tag_test.go
[ ] integration-cli/docker_cli_top_test.go
[ ] integration-cli/docker_cli_version_test.go
[ ] integration-cli/docker_cli_wait_test.go
[ ] integration-cli/docker_test_vars_cli.go

Feels like a lot :blush:.
Notes: We might want a dockerCmdWithStdin or some way to customize a bit (in docker_cli_build_test.go for example).

Taking a-b-c letters for now :smile:

I'd like to help, let me take d,e,f,g,h,i,j,k :smile:

Haha :)
@hqhq @vdemeester We're so lucky to have such contributors.

I'd like to  take the last 6 from integration-cli/docker_cli_stats_test.go to integration-cli/docker_test_vars_cli.go

@hqhq, @coolljt0725 Thanks, added you :smile:

I'd like to take  integration-cli/docker_cli_rename_test.go and restart

@HuKeping go it :)

@LK4D4 I've added a dockerCmdWithError (which is as simple as it can get : https://github.com/vdemeester/docker/commit/f9efe7fab2bf3df7061c386c9c9c48cefdb96a16#diff-56e050aac937f91b9152c08ee4f7517dR553), for the "I want to check the error" cases.

Will this dockerCmdWithError be merged? I think my change will depend on it

Guys, I haven't started, but I think this work would be very simple replacement. Let's not split it into too many PRs, I think 4 or 5 PRs would be top. @HuKeping @coolljt0725 @vdemeester let's split all rest, WDYT?

I would like to take the following.
docker_cli_save_load_test.go
docker_cli_save_load_unix_test.go
docker_cli_search_test.go
docker_cli_service_test.go
docker_cli_start_test.go
docker_cli_start_volume_driver_unix_test.go

OK @hqhq, I think I could take all r

OK, I'll take all the s

@hqhq yes it's not that bad, it just takes some time (to re-run integration-cli, …). Some file are already using dockerCmd pretty well, other less.
For the "Let's not split it into too many PRs", I kinda agree :sweat_smile:. 5 it is, I'll update the list according to your comment.
@HuKeping I'll make a PR today, let's see how quick it's going in, but another way would be for your to add my fork as a remote and checkout my branch and go from there (but in this case, I'll have to rework my branch a bit :sweat_smile:).
@coolljt0725 & @sunyuan3 who's taking the s's then ? :stuck_out_tongue_closed_eyes:

I'm taking the p btw :smile:

@vdemeester  @sunyuan3  take the docker_cli_save_load_test.go docker_cli_save_load_unix_test.go docker_cli_search_test.go docker_cli_service_test.go docker_cli_start_test.go docker_cli_start_volume_driver_unix_test.go
and I take the rest
And I take the l and n

@coolljt0725 Perfect, we're good to go !

@HuKeping I've split my commit in two (one to add the dockerCmdWithError, the other for the tests), so if you add my fork as a remote, you should be able to cherry-pick my commit into your branch and thus having dockerCmdWithError :wink:. (https://github.com/docker/docker/commit/4290bdefabc46d6faada968ef7ddba1d3c21dcca)

@vdemeester great!

hi, @vdemeester  the  integration-cli/docker_cli_run_test.go has not been finished yet, it was not in #14623 . I'm working on it and will post another pr.
Maybe you should update the tasklist

ohh ok, will do :wink:

I guess now everything has been merged, we are done :wink: :smiley_cat:.
Thanks everyone :tada:.


Incorporate Weave Scope out the box

The toolkit should spin up Weave Scope by default to provide the user with an easy to understand holistic overview of what was built and running.
We simply need to execute
kubectl apply -f 'https://cloud.weave.works/launch/k8s/weavescope.yaml?k8s-service-type=NodePort'

Would it be better to copy the yaml file into the project? I could imagine some environments being locked down and not allow access to the weaveworks website.

@willvrny that is a great point and definitely something we should do.

@swade1987 Scope also runs in privileged mode. Should we make it opt in because of this?

I've also seen Scope be very resource intensive (but while being used) - I'd rather this be opt in

Closing this for now as installing weave scope should be simple enough with kubectl. Feel free to reopen.


Fix overlay icon for inscription transaction in activity

The down arrow here is faded out against the image of the inscription itself whereas it should be a fully filled-in element like the BTC transaction below it:

The colour was not being applied properly here. I've added a fix but it may need some more work to improve it

Was this fixed for BTC transactions as well? I noticed here that the BTC arrow was also showing funny (2nd item) but not sure if I did before or after your fix via this PR