Discussion: ways of implementing autofix and issues

This issue is meant for housing any discussions and implementations of autofix. I believe we should implement autofix relatively soon, this way we won't have a huge burden to add autofix to every rule once there are way more rules. As far as i see it, there are two ways of doing autofix:

Purely text based (eslint)
AST transformation based (rome)

Purely text based has the issue of often not being very flexible (i personally disagree), and AST transformation based has the issue of not being flexible for minor text based fixes and needing AST serialization. Collectively autofix has fundamental issues which must be overcome:

All/Some rules need to be rerun after, i propose we add the ability to mark rules as fix-unsafe which will rerun only them, instead of needing all rules to rerun, which is expensive. This is absolutely required for stylistic rules, a fix cannot always conform to style and it should not either ways.

How do we choose what rule's fixes take precedence, if a rule wants to delete a node but another wants to change something in the node, which one do we trust?

Im not an expert in autofix so i would love some other ideas. RSLint's syntax again shines in this because it allows us to:

Incrementally reparse only the changed bits of code extremely fast and efficiently (linting is 60%+ parsing in RSLint's case), i am working on incremental reparsing but its not a top priority, but it will be widely used for vsc, file watching, and autofix.
Make changes on individual tokens or nodes and delegate them to a rewriter which converts them to text edits

I for one think text based is the way to go, it allows for a wider range of edits, it provides a familiar UI to people who have used ESLint, and rslint's immutable tree makes it a little bit more difficult to apply AST transformations, moreover, RSLint does not have a way to make new nodes without the parser and serialize them.
As for implementation, i believe we should add a field to RuleCtx which is fixer: Option<Fixer>, rules can make a new fixer (similar to ESLint) and add it, then the linter can simply collect the fixers and apply them. I also thought about making a new provided method on RuleCtx but ended up scrapping it because rules will 100% want to know about context when fixing, so making it a separate method would mean that some of the linting logic would have to be repeated, this is very very ugly and i would rather not do that.
I for one am not sure how to get over the issue of "which rule do we trust when it comes to a fix, do we trust the one who wants to change the node or the one who wants to delete it?". I also believe we should not try applying fixes if the parser returned errors, that can cause an absolute ton of confusing errors which i would rather not meddle in, error tolerance is great for linting but as soon as you try changing the AST produced (which is potentially semantically wrong) you end up with confusion.

Is there a way to create a SyntaxNode without actually parsing something or making a whole tree?

Not without manually adding tokens, no

I think we can get away with an amazing UI with a fixer, we could leverage syntax nodes and the new Span trait to allow things like fixer.replace(node, other_node) or fixer.wrap(node, T![')']) or fixer.delete(span). I dont really believe we need AST transformations to do this.

That would work too.

I looked at eslint's approach, it seems that they just do not apply fixes for a rule if the fix collides with another, i think this is fine for now, we should maybe issue an internal error if the fix spans overlap.

What if we re run one of the fixes with the new fixed content if both fixes collide?

That would be arbitrary selection of which rule is "right", which i would rather stay away from.

Yea that's not ideal.

Eslint's approach seems to work well enough, they collect fixes and apply them sequentially, then if the next fix's range overlaps they don't apply the fix and just skip to the next iteration. I think this is good and we should try doing this. I would like to implement autofix for v0.2 once #16 has landed, since incremental reparsing will be a big part of the fix iterations.

I would also like to eventually add SSR (structural search and replace), SSR is a tool for search and replace which operates directly on the syntax tree, for example:
{ get $name:name() $body } -> function $name () $body

it could also be extended to match specific nodes like bin_expr, expr, etc. The premise of how it works is really simple and rslint's syntax makes it really easy (see rust analyzer's implementation). there are a few distinct steps:
1: template splitting, producing { get $name:name() $body } and function $name () $body
2: lexing, the templates are lexed to identify the patterns in the text
3: replacement, { get __rslint_match_name_0 () {__rslint_match_node_0} } and function __rslint_name_0 () __rslint_node_0
4: parsing, the template and the replacement are parsed with rslint_parser, they must parse or the process is exited instantly.
5: tree walking, we take the tree of the template and the tree of the file, for each descendant in the file root node, if the descendant has the same node type as the template we enter a separate walking function which will sequentially check each child in the tree and the template, if any child does not match 1 - 1 then the node is not a match, once it encounters something like __rslint_match_name_0 it will check for a name node, if there isnt one then the node isnt a match, if there is then it is bound to the 0th replacement binder. if the pattern has no hint then it will become {__rslint_match_node_0}, this is to allow for binding both block statements and expressions, there is no real way to bind ANY node because there isnt a piece of text which will parse in the place of any node.
6: replacement, we take the binders bound in the fifth step and use rowan's replace_with function to make a new tree with the replacement but replaced with each binder.
This could be very useful for a number of things:

We could expose it to the user as a tool through rslint ssr
We could use it for autofix and compile the templates and replacements at compile time using a proc macro
We could use it for matching patterns in rules and compile the templates at compile time like above

Closing as it is implemented in #45


URL validation within Description and ReleaseNotes is breaking on example URLs

The new URL validation is a little too strict for description and releaseNotes fields.
For example, https://chocolatey.org/packages/azure-pipelines-agent/2.163.1 now fails, presumably because 'example' URLs are used in the description.
I'd recommend that for description and releaseNotes, adopt the following approach:

Ignore any URLs that are inside code blocks
Ignore any URLs that are not within a MarkDown hyperlink
For any remaining URLs that are found to be invalid, just raise a warning (instead of a failing error) and display the actual URL in question (to help package maintainers figure out if there's a real problem they can fix or not)

For releaseNotes, while this element can contain any text, some packages do just put a single URL as the content. In that specific case, I think it would be reasonable to apply the strict failing validation to the URL, but for all other content in releaseNotes then apply the same rules above as for description

This issue is related to this one:
https://github.com/chocolatey/package-validator/issues/207
Switching Description and Release Notes to guidelines is in line with what this issue was created for.

@flcdrg I think that there is still work to be done on this issue to account for everything, but the package that you specifically mention in the issue has now successfully passed validation.


Bug: Contact form not working

Urls where issue was found
designsystem.webstandards.ca.gov
designsystem.webstandards.ca.gov/contact-us
Steps to reproduce
Fill out the form and hit submit
Expected result
Submission appears at https://airtable.com/app4B5KqaCTSHAdCS/tbliV5kSgz7jBnIyT/viwDkwTUo3wZOqYhF?blocks=hide
Emails are sent to Yesenia and Chach.
Acceptance criteria

Form is successfully submitted to Airtable
If possible, create an automated test to catch the issue if the API fails again.
I think the emails should go to Yesenia and Jon at this point since Chach is no longer active on this project.
The Airtable Base needs some clean up
Add information on the contact form to the root-level README so developers don't have to dig for documentation.
Stop using Aaron's Airtable API Key since it will stop working February 1st 2024.  Airtable recommends using OAuth instead.

Optional criteria

Filter out xss submissions on the server side

CC:
@chachasikes @YeseniaGtz

The form is working again. Aaron's Airtable Personal Access Token was disabled along with his account. Swapping to another Personal Access Token fixed the issue.
These Airtable Personal Access Tokens will not be depreciated on 2/1/2024; they're removing a different type of API key. Nonetheless, it's still a good idea to migrate to OAuth, as this ticket demonstrates.
The OAuth migration will require some real work.

Here's a quote from the email I got about API keys

The timeline for the Airtable API key deprecation is below:
February 2023: Provided API Key deprecation notice
August 1st, 2023: Users will no longer be able to create new API keys
February 1st, 2024 (next year): Existing API keys cannot be used to access the Airtable API

I'll forward you the whole email @xjensen

Got the email, thanks!
Aaron already did the work to replace the legacy API key with the newly supported Personal Access Token. I got my info about the Personal Access Tokens at this page. I believe he included this change when he converted the FaaS from Azure to AWS.
It's still a problem though, because his token expired when he left. (No fault of his, of course. Now we know.) So OAuth is still on the table as essential work IMO.

@xjensen Have you had time to work on OAuth? Should I assign to someone else?

@zakiya Nope, haven't worked on OAuth integration of the form.
At this point, I imagine it would be easier to just get a new Personal Access Token from our shared odi-engineering Airtable service account, so that it's not tied to my account. That would alleviate a lot of the concerns I had before about continuity of service.
But happy to look into it if OAuth is still desired.

We removed the contact forms from the design system. Closing.


Build an XMTP hello world app

Provides a tutorial for building an XMTP "hello world" app that enables you to send a preconfigured "gm XMTP bot" message to the XMTP message bot. The bot is programmed to send a reply back.
For example, here is a screenshot of the app with the "gm XMTP bot!" message sent by the connected address and an automated reply from the XMTP bot:

The app is built entirely through copy/paste commands and code. For this reason, this tutorial is meant to help people with any level of coding skills achieve a basic understanding of what it means to build with XMTP.

Open issues/Important notes:

Matt requested that we scratch out a contingency plan should the hard-coded bot address become compromised in some way or we lose control of it. I will write this out once the app is working as expected. But as a part of this request, I've attempted to use the actual address as little as possible in the code - setting the address as a state value of peerAddress and using that state instead of the hard-coded value wherever possible.
See my comments wrapped in <!-- --> in the raw MD for important comments and questions.
The big blocker right now is that the app displays only new messages, not existing messages. For example:

New messages:

But I have a bunch of existing messages with the bot as well:

While it might provide a "clean slate" experience for the user building the app, I think the app should display existing and new messages. It may be misleading to provide an app that only shows new messages because it may imply some constraints about the XMTP works? If we are OK with the hello world app displaying new messages only, we'd have to provide a very clear callout that this is not normal for XMTP.

Rich is taking over work here <3: https://github.com/xmtp/xmtp-dot-org/pull/263


Test Case for Prior-Sample Problem

I want to implement the test case for the Prior-Sample problem. But, I am not able to have a clear idea of how to go about it. Can anyone tell me how I can approach this?

I think what works best is taking a look at other similar functions from the same file and adjusting their tests for the function you want.
So, I suggest you take a look at test_probability.py and find how other tests in there are written. That should give you a head start.

According to the implementation, the prior_sample method returns a random event sampled from the Bayesian network, bn. So, the output is different every time. I wanted to ask how I can test this random output. One idea that comes to my mind is testing if the following equation holds:
SPS(x1, ..., xn) = Product(1 to n) P(xi | Parents(Xi))
This equation is in Page: 531 of the book below the Prior-Sample pseudocode.
Any suggestions on this?

Sure, the equation will work. I suggest you round it to, say, five digits to avoid floating point shenanigans.
Also, if the output is one from a list of outputs, you can check if outpus in list. This is not the best of approaches, since it is too broad, but at least it checks if the algorithm works.
Another way to write a test for random algorithms, is this: If you know that the algorithm should be returning output A 50% of the time, run the algorithm N times and check if A appears N * 4/10 (or another value close to but less than 5/10, to give a little room for error).

Since there has been no progress of this issue for a long time I am taking it up.


CatastrophicFailure in NavigationService.ClearCache

Sometimes, a CatastrophicFailure (0x8000FFFF) is thrown in NavigationService.ClearCache. I can see customer reports on this, but cannot reproduce this issue on my devices.

What to do what to do. The method is a little mysterious to me, to be honest. What's the goal of the method? Re/un-setting the cache to delete what's there?

Exactly. The page cache cannot be flushed directly, so it has to be set to 0 and then set back to the original size.

But you get a catastrophic error?

Yes, when setting the CacheSize to 0. Looks like this sometimes fails for unknown reasons. I do not get the failure myself, but we use HockeyApp and can see several crashes at our customers.

Would it help to wrap it in a try/catch block for the sake of HockeyApp?

Yes, that should help as a workaround. I will add a PR for this.

I dont know if this will help or related to your issue
but in my scenario , i need NavigationCacheMode enabled in my second page , but when go back to first page , set it to false
I just add this on my OnNavigatingFrom method:
if (e.NavigationMode == NavigationMode.Back) {                 this.NavigationCacheMode = NavigationCacheMode.Disabled;             }


Keyboard popup performance

I am experiencing my app crawling on android when I pop open the keyboard. I believe this is due to the number of widgets I have on the page, all forcing the resize event at once. It just so happens on this page I do not want to redraw anything on resize. What are your thoughts on a page/widget level property to disable reflow in the event of a resize. It may not be the desired behavior in all cases, but in this one it definitely is.
Thoughts?

The Android client behaves differently when your content is inside a scroll view. Maybe you could try that.
Also when layouting is slow, that is usually due to the fact that you are nesting your layouts very deeply. Try to avoid that if possible.

Closing this one as we know always resize the tabris.ui.contentView when the keyboard opens.


[Bug] [ChatData] ClickhouseConnector object has no attribute '_engine'

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating system information
Linux
Python version information
3.10
DB-GPT version
latest release
Related scenes

[X] Chat Data
[ ] Chat Excel
[X] Chat DB
[ ] Chat Knowledge
[ ] Model Management
[ ] Dashboard
[ ] Plugins

Installation Information

[ ] Installation From Source

[ ] Docker Installation

[ ] Docker Compose Installation

[ ] Cluster Installation

[ ] AutoDL Image

[ ] Other

Device information
Device: CPU
Models information
LLM: proxyllm
What happened
In DB-GPT v0.5.4. We have successfully connected to the clickhouse database. However, when we use ChatData or ChatDB, we receive the following error message

2024-03-30 03:00:53 bf433e6f3fa9 dbgpt.serve.core.schemas[1] ERROR common_exception_handler catch Exception: success=False err_code='E0003' err_msg='unhandled errors in a TaskGroup (1 sub-exception)' data=None
ERROR:    Exception in ASGI application
  + Exception Group Traceback (most recent call last):
  |   File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/base.py", line 109, in __call__
  |     await response(scope, receive, send)
  |   File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 270, in __call__
  |     async with anyio.create_task_group() as task_group:
  |   File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 678, in __aexit__
  |     raise BaseExceptionGroup(
  | exceptiongroup.ExceptionGroup: unhandled errors in a TaskGroup (1 sub-exception)
  +-+---------------- 1 ----------------
    | Exception Group Traceback (most recent call last):
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 273, in wrap
    |     await func()
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/base.py", line 134, in stream_response
    |     return await super().stream_response(send)
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 262, in stream_response
    |     async for chunk in self.body_iterator:
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/base.py", line 98, in body_stream
    |     raise app_exc
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/base.py", line 70, in coro
    |     await self.app(scope, receive_or_disconnect, send_no_error)
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/exceptions.py", line 79, in __call__
    |     raise exc
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/exceptions.py", line 68, in __call__
    |     await self.app(scope, receive, sender)
    |   File "/usr/local/lib/python3.10/dist-packages/fastapi/middleware/asyncexitstack.py", line 20, in __call__
    |     raise e
    |   File "/usr/local/lib/python3.10/dist-packages/fastapi/middleware/asyncexitstack.py", line 17, in __call__
    |     await self.app(scope, receive, send)
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 718, in __call__
    |     await route.handle(scope, receive, send)
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 276, in handle
    |     await self.app(scope, receive, send)
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 69, in app
    |     await response(scope, receive, send)
    |   File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 270, in __call__
    |     async with anyio.create_task_group() as task_group:
    |   File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 678, in __aexit__
    |     raise BaseExceptionGroup(
    | exceptiongroup.ExceptionGroup: unhandled errors in a TaskGroup (1 sub-exception)
    +-+---------------- 1 ----------------
      | Traceback (most recent call last):
      |   File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 273, in wrap
      |     await func()
      |   File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 262, in stream_response
      |     async for chunk in self.body_iterator:
      |   File "/app/dbgpt/app/openapi/api_v1/api_v1.py", line 449, in stream_generator
      |     async for chunk in chat.stream_call():
      |   File "/app/dbgpt/app/scene/base_chat.py", line 285, in stream_call
      |     payload = await self._build_model_request()
      |   File "/app/dbgpt/app/scene/base_chat.py", line 216, in _build_model_request
      |     input_values = await self.generate_input_values()
      |   File "/app/dbgpt/util/tracer/tracer_impl.py", line 179, in async_wrapper
      |     return await func(*args, **kwargs)
      |   File "/app/dbgpt/app/scene/chat_db/professional_qa/chat.py", line 70, in generate_input_values
      |     dialect = self.database.dialect
      |   File "/app/dbgpt/datasource/rdbms/base.py", line 124, in dialect
      |     return self._engine.dialect.name
      | AttributeError: 'ClickhouseConnector' object has no attribute '_engine'
      +------------------------------------

What you expected to happen
Successfully Use ChatData or ChatDB
How to reproduce

Connect clickhouse database
Do ChatDB or Chat Data

Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

v0.4.5 可以正常使用 clickhouse 数据库做查询

@dusens 感谢，已验证问题解决 👍


TS Error: 'properties' does not exist on type 'DocumentChange'

Been getting this error while subscribing to the documentchange event, but I know it's in the docs and in the log.

I tried:
npm rm @figma/plugin-typings
npm i -D @figma/plugin-typings

but that didn't do much.
I'm using node v19.6.0

Hi @xaviervalarino, I believe the reason typescript is unhappy here is because not all types in documentChanges have a "properties" attribute.
Here's more information on all the different types of changes that might appear in e.documentChanges: https://www.figma.com/plugin-docs/api/DocumentChange/
Try this instead:
figma.on("documentchange", (e) => {
  for (const change of e.documentChanges) {
    if (change.type === "PROPERTY_CHANGE") {
      const properties = change.properties;
      // DO STUFF
    }
  }
});

That fixed it. Thank you very much


[feature] Add a DenyContainersWithMutableTags

We should add an AdmitFunc that supports denying container URLs with “latest” or (optionally) without a digest/hash.
This speaks to the determinism of providing a hash rather than a mutable tag, since the underlying container image can be changed in the latter.
This would apply to Pods, Deployments & StatefulSets out of the box.

Leverage https://github.com/docker/distribution/blob/master/reference/reference.go for image URL parsing


Add uget

Closes #1510

For some reason autoupdate cannot extract hash using sourceforge mode.

@Ash258: Why provide two versions? uget and uget-portable only differ by one line:
"persist": "config", is in uget-portable.
Perhaps an install switch that ignores the persist tag would make more sense?

Everyone don't want to store settings inside application directory. (Mutliple users, some AD restrictions, ...)
See: palemoon, vscode

Sorry, I missed that line.


Changed Python version to 3.5 in environment.yml

I've been trying building the docs, but conda in ReadTheDocs seems to be using Sphinx 1.3.5 which needs Python 3.5, as documented in this issue: https://github.com/rtfd/readthedocs.org/issues/2566
@Juanlu001 I know you've participated in related discussions, and possibly this problem will be fixed very soon: https://github.com/rtfd/readthedocs.org/pull/2802, but meanwhile, it would be great to be able to compile and update the docs.

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   82.27%   82.27%
=======================================
  Files          24       24
  Lines         886      886
  Branches       66       66
=======================================
  Hits          729      729
  Misses        137      137
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f2475...2b74626. Read the comment docs.

Good catch @anhiga! The thing is that @humitos told me last night that he found a fix during PyCon sprints, so this might changereally soon. I'm holding this PR open for some time and if we see no progress on RTD side then we can merge it and upgrade later.

There is a PR in Read The Docs with makes RTD to not pin any of the packages from a conda environment that will help you guys to build the documentation with 3.6: https://github.com/rtfd/readthedocs.org/pull/2876

Thanks @humitos! I guess this will be available in the next deployment, so we will patiently wait :)

It got merged and probably the deploy it's today. Let's see :)

We are making lots of documentation changes and I would love to see them deployed, so I'm merging this pull request just for RTD to work while they deploy the conda fix :) We can revert later.

Wohooo it already works on Python 3.6! :)

Congratulations!
I'm happy to read your comment :)


worker MQTT clients not reconnecting after leader restart

Suppose leader goes down for a moment - the mqtt clients on the workers are disconnected. When the leader's broker comes back up, the clients are suppose to reconnect (loop_start takes care of reconnecting, and supposedly the subscription information is stored and reloaded from the broker). This is not happening though.

nvm this is working

Actually all my subscribers on the worker are not responding, so it's not working.


Bug: App crashes when repository opened in a non-existent application

🪟 What version of Windows is this issue present?
🪟 Windows 11
🔢 What version of FluentHub are you on?
<IP_ADDRESS> | X64 | DEBUG
(This does not affect the error)
📄 Description
App crashes when opening GitHub Desktop/Visual Studio from the repository Clone context menu if the appropriate app is not installed.
🪜 Steps To Reproduce

Navigate to a repo
Press on the Clone button
From the context menu, open the repo in an app you do not have installed (Visual Studio or GitHub Desktop as appropriate)
App crashes.

🤔 Expected behavior
App should check for application install and grey out the button or open a browser with arguments for the URI which would prevent app crash.
⚒ Did you find any workaround?
No response
📑 Stack Trace
Stack trace is not associated with this error.
📸 Assets
https://github.com/user-attachments/assets/48eedd8d-dbed-4564-9216-4b6ab064f243
As you can see, the app crashes when the user attempts to open the repository with GitHub Desktop which is not installed on the machine.

To fix this I will build a custom website that opens different github clients

Real? Why not just send user to GitHub Desktop download page.

Real? Why not just send user to GitHub Desktop download page.

There are other git clients as well such as gitlens, GitGUI and gitkraken

Ok but why do you have to set up a website?
I thought we can detect installation of any git clients?

Ok but why do you have to set up a website? I thought we can detect installation of any git clients?

We can but it's a project I've been meaning to make anyway lol

Real? Why not just send user to GitHub Desktop download page.

@0x5bfa I'll just try other clients on error and if still fails, show GitHub Desktop download page.


Update UpdateTask.php

This PR checker thing is becoming annoying...

Have you testd this?

multiple times

+1


setting up

Description
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change i.e pip installed requirements or other UI stuff.
Fixes # (issue)
Screenshots
Checklist

[ ] My Code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have written commits as required, and did not merge main to my branch. I rebased it instead.

Initial setup & migrations


Mongomock allows saving a value of type "set" for a key, while this should fail

On real mongo the following error is raised (for example when setting a key to set(['a', 'b', 'c']):
InvalidDocument: Cannot encode object: set([u'a', u'b', u'c'])

Hmm I cannot reproduce, can you provide a simple code that passes but should fail please?
I just run (in Python 3.6.5):
import mongomock
mongomock.MongoClient().db.test.insert_one({'a': set(['a', 'b', 'c'])})

and I got the error
bson.errors.InvalidDocument: Cannot encode object: {'b', 'c', 'a'}

I had this is python 2.7.12 and with an update call, rather than insert

Got it. I was indeed able to reproduce with an update or a `replace. I've sent a fix for review.


Use pip install docker-compose

Description
Update host.sh, use pip install docker-compose instead of curl
Motivation and Context
1.More consistent with setupRHELonZ.sh
2.It is faster than docker-compose official site for people network not good.
How Has This Been Tested?
no test
Checklist:

[x] I have added a Signed-off-by.
[x] I have either added documentation to cover my changes or this change requires no new documentation.
[x] I have either added unit tests to cover my changes or this change requires no new tests.
[] I have run golint and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.

Signed-off-by:Kai Chen<EMAIL_ADDRESS>

re-trigger Travis

@ghaskins Would you like review?

@ghaskins Are you available for reviewing this PR?
@rameshthoomu Would you like help re-trigger travis build?

@GrapeBaBa: I don't have access to restart the builds on Travis. As we moved to Gerrit now, we are verifying builds only in Jenkins CI machines not in Travis.  If you still want to test this PR in Travis,  please check with ghaskin or srderson to restart the build.

Not need.


What does "hasInstance" do?

Dear authors,
What exactly does "hasInstance" do? When I experiment with putting different class labels on True/False, I get very different results.
Can you elaborate a bit on how "hasInstances" is usually used, and when it should be set to False or True?
Thanks in advance and kind regards

Dear authors, i have the same question !  sky for example seems to have only one polygon per image and is as I expect set with HasInstance = False, but traffic sign , also set with HasInstance = False, has several polygons per image...


Add Ccache to the cmake build

Adding usage of the convenient tool Ccache https://ccache.dev/.
This tool will speedup the re-compilation time of the project on the UNIX systems.

ccache works on windows and macos too

ccache works on windows and macos too

@crackedmind, thanks for notice. UNIX, variable also includes macos system https://cmake.org/cmake/help/latest/variable/UNIX.html . But i have not tested it on windows, maybe I will update it later.

@crackedmind, thanks for notice. UNIX, variable also includes macos system https://cmake.org/cmake/help/latest/variable/UNIX.html . But i have not tested it on windows, maybe I will update it later.

@NancyLi1013 , Do I have to change something or to close this PR ?
I do not want to push you with the processing with this PR, just want to clarify on what stage we with this PR. :blush:

@NancyLi1013 , Do I have to change something or to close this PR ?
I do not want to push you with the processing with this PR, just want to clarify on what stage we with this PR. :blush:

@Mr-Leshiy
Have you tried to test if it supports Windows?

@Mr-Leshiy
Have you tried to test if it supports Windows?

@NancyLi1013 , yes I have tried on windows. But it also possible to use only with the Ninja, here it is a description.
https://cmake.org/cmake/help/latest/prop_gbl/RULE_LAUNCH_COMPILE.html .

@NancyLi1013 , yes I have tried on windows. But it also possible to use only with the Ninja, here it is a description.
https://cmake.org/cmake/help/latest/prop_gbl/RULE_LAUNCH_COMPILE.html .

Unfortunately, this is not something we're interested in taking. If you wish to use ccache, you should set your CXX environment variable, or pass CMAKE_CXX_COMPILER.

Unfortunately, this is not something we're interested in taking. If you wish to use ccache, you should set your CXX environment variable, or pass CMAKE_CXX_COMPILER.

@strega-nil , understood. So I will close this PR.

@strega-nil , understood. So I will close this PR.

@Mr-Leshiy thank you for understanding :)

@Mr-Leshiy thank you for understanding :)


Numbering and organization for ADRs

Should client and server ADRs be in separate folders?
If ADRs are in same folder should there be a file naming convention

with a server/client qualifier i.e. nnnn-server-title...md / nnnn-client-title...md
numbering prefix i.e. 0001 for server, 5001 for client
both a numbering and a qualifier

If ADRs are in different folders should there be a naming convention

both files sets start at 0001
server starts at 0001 and client starts at 5001

If ADRs are in different folders should there be a naming convention that requires a file naming qualifier.

The ADR format is not something we designed. It’s in use by many projects and standard tooling for this already exist
it’s a directory with sequentially files as per the example in the server.
Is it perfect? No. But it’s a standard process. Please follow along.


How to group/separate?

I exactly would like to create a plot like https://www.machinelearningplus.com/wp-content/uploads/2018/11/24_JoyPlot_joypy-min-1024x741.png  found on https://www.machinelearningplus.com/plots/top-50-matplotlib-visualizations-the-master-plots-python/ , where they use fig, axes = joypy.joyplot(mpg, column=['hwy', 'cty'], by="class", ylim='own', figsize=(14,10))
To do so I use fig, ax = joypy.joyplot(Temperatures_df, by="Transformer", figsize=(14,7),                         linewidth=0.05,overlap=3,colormap=cm.OrRd_r)
but I receive the following:

but I would like to have the variables separated and then each variable grouped by "Transformer". Hence, I tried fig, ax = joypy.joyplot(Temperatures_df, figsize=(14,7), linewidth=0.05,overlap=3, colormap=cm.OrRd_r) but then I receive:

What I am actually looking for is a combination of both of them. Respectively I don't understand why I can't create the same appearance like in the first image as this fulfills my expectations already.
Why is that?
The Temperatures_df looks like following:

BotTmp | EnvTmp | HPTmpClc | LTCTmp | Transformer
timestamp
2018-02-02 14:31:00 | NaN | NaN | 54.400000 | NaN | Transformer S1
2018-02-02 14:45:00 | NaN | NaN | 54.400000 | NaN | Transformer S1
2018-02-02 15:00:00 | NaN | NaN | 54.400000 | NaN | Transformer S1
(...)
2018-10-25 01:30:00 | NaN | NaN | NaN | 30.790190 | Transformer S2

Hi,
not sure what is your expected result. I would suggest looking at the notebook with examples, in the last few examples (about colors).
Currently, if you use both the by and colormap argument, the same colormap is applied to all groups. This is why you obtain the result in the first figure. (Not sure this is the most sensible default indeed, but it's like this at the moment).
You should use the color argument and pass explicitly the colors, if you want each group to have a separate color, like this:
fig, axes = joypy.joyplot(iris,fill=True, legend=True, by="Name", color=["k","b","r","g"])

You could even pass a list of different colormaps, if the list has the same length as the number of groups.


Update to support Amazon Linux 2

There are some user_data.sh incompatibilities with Amazon Linux 2 which prevent container instances from booting with connectivity to your ECS cluster.

i got it working using the docs here: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/using_cloudwatch_logs.html
metadata can only be inside the service as ecs agent starts after cloud init

Yep, that's what would be good to merged back into this repo. :+1:

user_data.sh looks like this: https://gist.github.com/lethaldose/4103a64320b93475d7b308523b4a6c68
assuming the ecs_cluster uses new amis.


chore: unpin dask

Proceed with caution. Last night tests were failing about 50% of the time. This morning I can't get them to fail. Something still seems flaky.

Managers tests fail horribly with same manner of failures seen intermittently in the tools tests.

Works now with latest commit.


Investigate a reason for double logs in database

All log messages are recorded twice in database in dev, and some of them in local. Probably multiple loggers are initialized.

Looks like logs will be duplicated when multiple functions are running at the same time. (Analyzer and importer). Handlers should be removed but probably running them on a same environment causes the problem. One possible fix would be to check if handlers are initialized before creating a new.


Bau - Update readme and add overview documentation

fix typo with licence file
add licence to readme
make readme more accurate
add an 'overview of the proxy node doc' which is reference by the readme. Similar to what we have in the hub.

@CharlesIC Thanks. Changes made. Git makes it so easy!


Is there a way to render marker thru layers and feature?

It works in this code.
<Layer
type="symbol"
type="circle" id="marker" paint={{
'circle-color': "#ff5200",
'circle-stroke-width': 1,
'circle-stroke-color': '#fff',
'circle-stroke-opacity': 1
}}
>
{
this.state.assets.map((element, index) => {
return <Feature
key={index}
coordinates={[element..longitude, element.latitude]}
anchor="bottom"
/>
})
}

But how am i going to put my image per coordinates and not the circles?

Answered your question on Stack Overflow as well, here it is again:
To render something with layers and features, put one or more Feature components inside of a Layer component. You can give each Feature a position using the coordinates prop.
Now, what's left over is to style these features. How you do this depends on what your markers previously contained, but for example, if you'd like to draw circles for each of the positions, you can set the Layer's type to circle and under the paint prop, provide values for circle-color and circle-radius (these are described in the mapbox-gl API docs.
For drawing images for each coordinate, you can use the icon-image layout property on the Layer (you would have to either use a preexisting icon or upload one to Mapbox Studio).
You can see some sample code in the demos, for example the all-shapes demo styles data with circles.

Thanks for the response.

I have tried uploading icon image on Mapbox and it works.
<Layer
type="symbol"
layout={{
"icon-image": "car_active",
'text-allow-overlap': true,
'icon-allow-overlap': true,
}}
>
{
this.state.assets.map((element, index) => {
return <Feature
key={index}
coordinates={[element.longitude, element.latitude]}
style={{ transform: rotate(${element.bearing}deg) }} --> doesn't work
/>
})
}

What i want is that every coordinates has different icon-image, how do i do it?

You can't style features using CSS, they are not HTML elements but instead rendered natively using WebGL.
One way to have every coordinate have a different icon-image is to have a separate layer for each different image, but depending on the amount you need, this might have a significant performance hit.
Another way is to give every Feature a property signifying the icon you want, e.g
<Feature
  {...otherProps}
  properties={{
    thisCanBeNamedWhatever: 'car-1'
  }}
/>
<Feature
  {...otherProps}
  properties={{
    thisCanBeNamedWhatever: 'car-2'
  }}
/>

and then instead of hardcoding the icon-image value as a string in the layer paint options, use mapbox-gl-js's identity functions, referring to the property name you set above:
<Layer
  {...otherProps}
  layout={{
    'icon-image': {
      'type': 'identity',
      'property': 'thisCanBeNamedWhatever'
    }
  }}
/>


[BUG] error

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[X] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v2.5.3
What problem did you encounter?
error
Bloxstrap Log
System.AggregateException: One or more errors occurred. (The given key 'content-platform-dictionaries.zip' was not present in the dictionary.)

[Inner Exception]
System.Collections.Generic.KeyNotFoundException: The given key 'content-platform-dictionaries.zip' was not present in the dictionary.

Update.


Unable to use vue-cli ui

Version
4.3.1
Environment info
  System:
    OS: Linux 5.3 Ubuntu 18.04.4 LTS (Bionic Beaver)
    CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
  Binaries:
    Node: 12.16.3 - /usr/bin/node
    Yarn: 1.22.4 - /usr/bin/yarn
    npm: 6.14.4 - /usr/bin/npm
  Browsers:
    Chrome: 81.0.4044.138
    Firefox: 76.0.1
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce

Install vue-cli using yarn
Run vue ui

What is expected?
Show the main page of the vue ui
What is actually happening?
Got stuck at loading

Error in console: Schema must be an instance of GraphQLSchema. Also ensure that there are not multiple versions of GraphQL installed in your node_modules directory.

I get the same

just got this at v4.5.8
I even tried running the vue ui command outside of any node project to ensure it isn't a conflict with local node_modules folder.  Verified that I don't have graphql installed globally.  So confusing.


internal/lsp: use empty string to replace 'go\n\n' with markdown enabled.

There are some circumstances where go langserver returns 'go\n\n',
clients may render this empty markdown string. It's better to return
an empty string instead. Related issue:
https://github.com/golang/go/issues/33000.

The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@movie-travel-code: Do you confirm your consent to have your PR contributed to this project?

Yes!
I have no idea why my cla is not working today.
Rebecca Stambler<EMAIL_ADDRESS>周三上午1:18写道：

The bad news is that it appears that one or more commits were authored or
co-authored by someone other than the pull request submitter. We need to
confirm that all authors are ok with their commits being contributed to
this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the
cla/google commit status will not change from this state. It's up to you to
confirm consent of all the commit author(s), set the cla label to yes (if
enabled on your project), and then merge this pull request when
appropriate.
@movie-travel-code https://github.com/movie-travel-code: Do you confirm
your consent to have your PR contributed to this project?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/tools/pull/134?email_source=notifications&email_token=ABKDBQX2D4Y736KBXNF6ZRDP6TB6NA5CNFSM4H7CVD6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZQ53HA#issuecomment-509730204,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKDBQUGNPFGVROHMWVZ35TP6TB6NANCNFSM4H7CVD6A
.

--
Liushuai Wang
Elastic Code Search Team


Crash on Android 5.01 / Samsung S4

Received this via email (Translated from German):

On the Samsung S4, which supposedly still meets the requirements with Android 5.01, trying to delete any received message produces a program crash: "App stopped". I took the opportunity to send a message. Reinstalling the app didn't help either. Since I am not familiar with Gitub, I am writing to you directly and attaching four hard copies. The information may help to fix the error with one of the next updates.

I checked in the Google Play Console, and I didn't see any stack traces for Android 5. Without a stack trace, I cannot help, sadly. Was ntfy installed via Google Play, or F-Droid, or manual .apk file? Install the Google Play version if you can.
If that doesn't work, you can attach adb to your phone (Google how that works) and use adb logcat to get stack traces.
Hope this helps.

Fixed in https://github.com/binwiederhier/ntfy-android/commit/e64cd79c28122596c9989563af12c59916eb27e5


Test SDK TracerProvider

Move the tracerProvider type and related functionality to its own file to help discoverability.
Use a singleton instance of the tracerProvider for tracerProviderInstance instead of having a new value created each call to TracerProvider.
Test the singleton nature of TracerProvider.
Test the concurrent safe behavior of the provided TracerProvider (part of #1297).

Which part here addresses concurrency? If I understood this correctly, the old code also used a singleton?

Which part here addresses concurrency? If I understood this correctly, the old code also used a singleton?

Correct. The old code is already concurrent safe. This just adds a test to ensure that it remains that way.
The old code uses a default value as the file scope tracer provider. Since Go will always copy-by-value, each value returned from TracerProvider was being copied to new memory. This also changes that to always reference the same instance of a *tracerProvider that is allocated to the heap.


improved signup

Added the password validation and also email format validation!

Thanks You @Nupur19nj  for your Contributing look for such more good contribution from you

Ya sure!

give @Nupur19nj   100 points


[My habits] It is impossible to "Give up" the habit, button "Give up" ("Здатися") does not work

Environment: macOS 10.10.5, Google Chrome 87.0.4280.141, Safari 10.1.2
Reproducible: always
Build found: 12.10.2022
Preconditions

Login into the Green City https://www.testgreencity.ga/GreenCityClient/#/
"My habits" page is opened

Steps to reproduce

Click on "Edit" habit button
Scroll down and click on "Give up" ("Здатися") button

Actual result
"Give up" button does not work. System doesn't return to the previous "My habits" page.
Expected result
When user clicks on the button "Give up" a pop-up notification "Are you sure you want to give up the habit? All your progress of habit's tracking will be lost." and buttons "No" and "Yes" appear. System returns to the previous "My habits" page. Appropriate edited habit is deleted.
Epic My habits https://github.com/ita-social-projects/GreenCity/issues/938
User story https://github.com/ita-social-projects/GreenCity/issues/2167
Labels to be added
"Bug", Priority ("pri: "), Severity ("severity:"), Type ("UI, "Functional"), "API" (for back-end bugs).

Duplicate #4833


Mystery solved? Less than 14.8 Mpps w/ 64-byte packets

Since forever we have noticed that when we tested with the minimum frame size we typically don't see the theoretical maximum packet rate of ~14.8 Mpps. Instead we see a lower rate typically around 12-13 Mpps. This has always been a little mystifying but because it has not been a practical problem for any application we have mostly ignored it. However, we are reminded of it any time we run packetblaster with a 64-byte packet input file.
I have looked into this a little bit now: first googling for a hypothesis and then running a small test to confirm. I think I have the answer. drumroll...
The problem seems to be that the 82599 cannot achieve full line rate on 64-byte packets with only one TX queue. I have seen multiple mailing list threads suggesting this. UPDATE: See comment below for fix/workaround.
I tested a multiqueue transmit by connecting one Source app to two Intel apps sharing the same port (VMDq mode) and then I do see the full 14.8 Mpps rate in total (half on each app).
app network fragment:
config.app(c, "source", require("apps.basic.basic_apps").Source)
config.app(c, "nic1", Intel82599, { pciaddr = "0000:02:00.0", vmdq=true, mac="00:00:00:00:00:01" })
config.app(c, "nic2", Intel82599, { pciaddr = "0000:02:00.0", vmdq=true, mac="00:00:00:00:00:02" })
config.link(c, "source.tx -> nic1.rx")
config.link(c, "source.tx -> nic2.rx")

and result after running for 100 seconds:
link report:
         743,653,162 sent on source.tx -> nic1.rx (loss rate: 0%)
         743,643,612 sent on source.tx -> nic2.rx (loss rate: 0%)

which yields 14.872787 Mpps.
Compare with a single app/queue for transmit:
link report:
       1,290,189,769 sent on source.tx -> nic1.rx (loss rate: 0%)

i.e. 12.9 Mpps.
So if correct then what does this mean? I would say that for most apps it actually does not matter in practice but it is nice to have an explanation anyway. For certain apps though it could actually be worth using multiple queues (something to consider for packetblaster).

Oh actually it looks like one queue is enough when descriptor prefetch is enabled. Here is a preliminary patch that does the job:
diff --git a/src/apps/intel/intel10g.lua b/src/apps/intel/intel10g.lua
index a3b1584..437082d 100644
--- a/src/apps/intel/intel10g.lua
+++ b/src/apps/intel/intel10g.lua
@@ -421,6 +421,7 @@ function M_sf:init_transmit ()
    self.r.HLREG0:set(bits{TXCRCEN=0})
    self:set_transmit_descriptors()
    self.r.DMATXCTL:set(bits{TE=0})
+   self.r.TXDCTL:set(bor(bits{Enable=25, SWFLSH=26, hthresh=8}, 32))
    return self
 end

then I see 14.878 Mpps with just a source feeding one Intel app.
Have to verify this and check out the receive side too.

@alexandergall Sorry if I am duplicating work that you are already doing. I know you mentioned wanting to solve this mystery and that kind of captured my imagination too :).

I didn't have time to look at it yet, so I'm very happy about your progress :) It looks like you nailed it down pretty well.

Thinking about it a bit more, I'm pretty sure that we're dealing with two distinct problems. One is on the sending side, which you solved. The other is on the receiving side, because I already verified that the receiving NIC is logging input drops. There doesn't seem to be a similar pre-fetching mechanism on the RX side, but I haven't looked very hard yet.


General Grievance: Watch vairt.com

General Grievance requests the watch of the watch_keyword vairt\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

vairt\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


tests: interrupt: Use IPI to trigger interrupt in test and refine the test cases

This PR include 3 changes to refine the testcases:

Now we using IPI to trigger interrupt in testing instead of INT instruction,
this means we don't need to hardcode the vector number. That can avoid
some problem.

Fixes: #40374

Refined the test cases. Tigger interrupt by INT instruction and IPI cannot
be masked by irq_disabled(). Unless it's a external interrupt, such as a timer.
Now remove those incorrect part of these testcases.

use IPI instead of int instruction for testing on x86:
For x86, make the testing purpose trigger_irq() function to send interrupt
processor interrupt to CPU by APIC, instead of executing INT instruction.
Doing this because we don't need to hardcode the interrupt vector.

Sorry I don't want create a new PR but it seems like the original PR cannot be opened again.

Excuse me, @andyross @dcpleung, could you please help to review this PR again? I appreciate your feedback :)


Move @types/node to the root package.json

Summary
Fixes #8092.

Anybody wanna send a PR? We can just add @types/node to the root package.json and remove it from the individual packages.
Note that this is just @types/node, all other @types/* should remain

https://github.com/facebook/jest/issues/8092#issuecomment-472339505
Test plan
N/A.

Codecov Report

Merging #8129 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8129   +/-   ##
=======================================
  Coverage   62.43%   62.43%
=======================================
  Files         264      264
  Lines       10368    10368
  Branches     2515     2515
=======================================
  Hits         6473     6473
  Misses       3318     3318
  Partials      577      577

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f06ee4...82742dc. Read the comment docs.

@SimenB done.

Thanks!


update swiftlint config

What

[x] update the swiftlint config to match https://github.com/airbnb/swift

I was surprised as well!


[BUG] Criteo 1TB dataset missing

Describe the bug
Is there another source for the criteo data by day?
The links at https://labs.criteo.com/2013/12/download-terabyte-click-logs/ like http://azuremlsampleexperiments.blob.core.windows.net/criteo/day_0.gz seem unavailable.
If there is a mirror, this would be great.  The smaller dataset I found but not the full 1TB.

Hi @rllin , thank you for your feedback! It's a known issue, we are trying to solve this problem with criteo. We will keep you posted.

thanks!  if theres anyway we can help and/or get the dataset privately before it is rehosted, please let us know!

@zehuanw do you have any sense of timeline?

Hi @rllin , sorry that we don't have a clear timeline can be shared. It depend on the response from Criteo. We are keep contacting with them. We will keep you posted.

@zehuanw have they been responsive?  we have also tried reaching out to criteo with no responses

Hi @rllin The dataset is available now from Google cloud service. Please check here. We also updated our samples and notebooks accordingly.
Please let me know if it works for you. Thanks!

Thank you for your feedback! Close the issue.


About converting CPU training to GPU

I am trying to speed up the training process by using GPU:
# implements the multiple-instance learning model using Neural Networks, as described in
# https://arxiv.org/abs/1609.07257
# Using Neural Network Formalism to Solve Multiple-Instance Problems, Tomas Pevny, Petr Somol
using FileIO, JLD2, Statistics, Mill, Flux
using Flux: throttle, @epochs
using Mill: reflectinmodel
using Base.Iterators: repeated
using CUDAapi, CUDAdrv, CUDAnative

gpu_id = 0

if has_cuda_gpu() && gpu_id >=0
    device!(gpu_id)
    device = Flux.gpu
    @info "Training on GPU-$(gpu_id)"
else
    device = Flux.cpu
    @info "Training on CPU"
end

# load the musk dataset
fMat = load("example/musk.jld2", "fMat")            # matrix with instances, each column is one sample
bagids = load("example/musk.jld2", "bagids")        # ties instances to bags
x = BagNode(ArrayNode(fMat), bagids)        # create BagDataset
y = load("example/musk.jld2", "y")                  # load labels
y = map(i -> maximum(y[i]) + 1, x.bags)     # create labels on bags
y_oh = Flux.onehotbatch(y, 1:2)             # one-hot encoding

# create the model
model = BagModel(
    ArrayModel(Dense(166, 10, Flux.tanh)),                      # model on the level of Flows
    SegmentedMeanMax(10),                                       # aggregation
    ArrayModel(Chain(Dense(20, 10, Flux.tanh), Dense(10, 2)))) |> device  # model on the level of bags

# define loss function
loss(x, y_oh) = Flux.logitcrossentropy(model(x |> device).data, y_oh |> device)

# the usual way of training
evalcb = throttle(() -> @show(loss(x |> device, y_oh |> device)), 1)
opt = Flux.ADAM()
@epochs 10 Flux.train!(loss, params(model), repeated((x, y_oh), 1000), opt, cb=evalcb)

# calculate the error on the training set (no testing set right now)
mean(mapslices(argmax, model(x |> device).data, dims=1)' .!= y)

But an error raised:
ArgumentError: cannot take the CPU address of a CuArrays.CuArray{Float32,2,Nothing}

Stacktrace:
 [1] unsafe_convert(::Type{Ptr{Float32}}, ::CuArrays.CuArray{Float32,2,Nothing}) at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/CuArrays/YFdj7/src/array.jl:226
 [2] gemm!(::Char, ::Char, ::Float32, ::CuArrays.CuArray{Float32,2,Nothing}, ::Array{Float32,2}, ::Float32, ::Array{Float32,2}) at /home/buildbot/build-worker/worker/juliapro-release-centos7-0_6/build/tmp_julia/share/julia/stdlib/v1.4/LinearAlgebra/src/blas.jl:1167
 [3] gemm_wrapper!(::Array{Float32,2}, ::Char, ::Char, ::CuArrays.CuArray{Float32,2,Nothing}, ::Array{Float32,2}, ::LinearAlgebra.MulAddMul{true,true,Bool,Bool}) at /home/buildbot/build-worker/worker/juliapro-release-centos7-0_6/build/tmp_julia/share/julia/stdlib/v1.4/LinearAlgebra/src/matmul.jl:597
 [4] mul! at /home/buildbot/build-worker/worker/juliapro-release-centos7-0_6/build/tmp_julia/share/julia/stdlib/v1.4/LinearAlgebra/src/matmul.jl:169 [inlined]
 [5] mul! at /home/buildbot/build-worker/worker/juliapro-release-centos7-0_6/build/tmp_julia/share/julia/stdlib/v1.4/LinearAlgebra/src/matmul.jl:208 [inlined]
 [6] * at /home/buildbot/build-worker/worker/juliapro-release-centos7-0_6/build/tmp_julia/share/julia/stdlib/v1.4/LinearAlgebra/src/matmul.jl:160 [inlined]
 [7] adjoint at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Zygote/1GXzF/src/lib/array.jl:310 [inlined]
 [8] _pullback at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/ZygoteRules/6nssF/src/adjoint.jl:47 [inlined]
 [9] Dense at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Flux/Fj3bt/src/layers/basic.jl:122 [inlined]
 [10] Dense at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Flux/Fj3bt/src/layers/basic.jl:133 [inlined]
 [11] applychain at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Flux/Fj3bt/src/layers/basic.jl:36 [inlined]
 [12] Chain at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Flux/Fj3bt/src/layers/basic.jl:38 [inlined]
 [13] #159 at /data/zhangzhi/nn-rebuttal/Mill.jl/src/modelnodes/arraymodel.jl:14 [inlined]
 [14] mapdata at /data/zhangzhi/nn-rebuttal/Mill.jl/src/datanodes/datanode.jl:57 [inlined]
 [15] mapdata at /data/zhangzhi/nn-rebuttal/Mill.jl/src/datanodes/arraynode.jl:18 [inlined]
 [16] ArrayModel at /data/zhangzhi/nn-rebuttal/Mill.jl/src/modelnodes/arraymodel.jl:14 [inlined]
 [17] _pullback(::Zygote.Context, ::ArrayModel{…}, ::ArrayNode{…}) at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Zygote/1GXzF/src/compiler/interface2.jl:0
 [18] BagModel at /data/zhangzhi/nn-rebuttal/Mill.jl/src/modelnodes/bagmodel.jl:28 [inlined]
 [19] _pullback(::Zygote.Context, ::BagModel{…}, ::BagNode{…}) at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Zygote/1GXzF/src/compiler/interface2.jl:0
 [20] loss at ./In[12]:36 [inlined]
 [21] _pullback(::Zygote.Context, ::typeof(loss), ::BagNode{…}, ::Flux.OneHotMatrix{Array{Flux.OneHotVector,1}}) at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Zygote/1GXzF/src/compiler/interface2.jl:0
 [22] adjoint at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Zygote/1GXzF/src/lib/lib.jl:179 [inlined]
 [23] _pullback at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/ZygoteRules/6nssF/src/adjoint.jl:47 [inlined]
 [24] #17 at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Flux/Fj3bt/src/optimise/train.jl:89 [inlined]
 [25] _pullback(::Zygote.Context, ::Flux.Optimise.var"#17#25"{typeof(loss),Tuple{BagNode{…},Flux.OneHotMatrix{Array{Flux.OneHotVector,1}}}}) at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Zygote/1GXzF/src/compiler/interface2.jl:0
 [26] pullback(::Function, ::Zygote.Params) at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Zygote/1GXzF/src/compiler/interface.jl:172
 [27] gradient(::Function, ::Zygote.Params) at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Zygote/1GXzF/src/compiler/interface.jl:53
 [28] macro expansion at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Flux/Fj3bt/src/optimise/train.jl:88 [inlined]
 [29] macro expansion at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Juno/f8hj2/src/progress.jl:134 [inlined]
 [30] train!(::typeof(loss), ::Zygote.Params, ::Base.Iterators.Take{Base.Iterators.Repeated{Tuple{BagNode{…},Flux.OneHotMatrix{Array{Flux.OneHotVector,1}}}}}, ::ADAM; cb::Flux.var"#throttled#20"{Flux.var"#throttled#16#21"{Bool,Bool,var"#24#25",Int64}}) at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Flux/Fj3bt/src/optimise/train.jl:81
 [31] top-level scope at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Flux/Fj3bt/src/optimise/train.jl:122
 [32] top-level scope at /home/zhangzhi/.juliapro/JuliaPro_v1.4.1-1/packages/Juno/f8hj2/src/progress.jl:134
 [33] top-level scope at In[12]:41

By checking the code, I found that the encapsulation of datanodes, arraymodel and arraynode affects the operation of |> device. I need to hack in the source code of Mill.jl to manually migrate the data to the gpu. In your architecture, do you have any other suggestions to implement cuda operations more simply?
Thanks!

We were making experiments regarding training on gpu and there is a branch https://github.com/pevnak/Mill.jl/tree/gpu, which implements it to some extent.
Later we found out it's not so much priority for us, so we stopped focusing on it, but feel free to continue.
We used the CuArrays library and now there is the CUDA.jl, which we haven't tried yet, so it's hard to estimate how much effort it would be.

Maybe @horakka5 could comment on this more.

Thanks for your fast reply! Got a picture of the basic idea and will try more on the latest version.

In my current work, I plan to modify a GPU version using Flux.gpu and CUDA.jl based on the CPU version without changing operators. The first step maybe changes the pointer to support CuArray:
# the original code only support CPU
Flux.activations(::typeof(identity), x::Array{Float32,2}) = (x,)

Then during training all the Array can be converted to CuArray by |> device as mentioned before. Hope all used operators are supported on CuArray now...

I thought you'd need to use CUDA.jl and not CuArrays, because latest version uses Zygote 0.5, which uses CUDA.jl instead of CuArrays.


Shared UART driver

Summary
I want to build thin wrappers around STM's peripherals, since STM's documentation is pretty obtuse and this could theoretically allow us to port our code to non-STM targets. This should support polling, interrupt, and DMA mode. Interrupt and DMA will require a user-provided callback function.
Will be required for wireless telemetry and refactoring the SBG Ellipse GPS.

Moved to Jira.


[release-1.16] add http protocol option for external sds cluster

This is an automated cherry-pick of #41503

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio_release-1.16
554efcf7eda59cf2f6f5e70bb9574a2e66a31dfe
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-cni


FI-1771: Update landing page to mention new standards supported

Updated the landing page:

I think the request may have been against the README (not sure, but makes sense to describe what the specific standards are there).  Should we add more specificity in there now or create a new ticket?

I'd like that to be a separate ticket. I want to do a reference server release ASAP so we can get it up on dev.

I also just bumped the version so that I don't need to do another PR to release this.


Health check instance stuck in "Initilaizing" state

Rancher Versions: Build from wagyu
Steps to reproduce the problem:
Add 2 hosts to "Default" environment.
Health check instance stuck in "Initializing" state on 1 of the host and there is no health check instance that gets created on the  other host
mysql> select id,name,state,created,removed,health_state from instance where name like "health%";
+----+---------------------------+---------+---------------------+---------+--------------+
| id | name                      | state   | created             | removed | health_state |
+----+---------------------------+---------+---------------------+---------+--------------+
| 12 | healthcheck-healthcheck-1 | running | 2017-04-03 22:42:23 | NULL    | initializing |
+----+---------------------------+---------+---------------------+---------+--------------+
1 row in set (0.00 sec)

mysql>

Service activation fails with error - Failed to acquire lock [DEPLOYMENT.UNIT.5])

Can you re-test with the new container refactoring?

Tested with rancher-server builds from master (07/07) with 3 hosts.
Health check instances get deployed successfully on all hosts and get to "healthy" state.


Removed references to screenshots

This PR

[x] updates README.md and removes references to screenshots

Maybe we should add new screenshots of how it looks now. Though in that case i'd suggest adding those to a separate file. Takes a lot more scrolling than needed when you want to check something.

👍 On an unrelated note... Firefox 57 is pretty amazing.


Learning all features about spring-vault

List all features.
Whether this feature can be supported in spring-cloud-azure-autoconfigure.
Whether spring-vault support Azure Key Vault. (So we can deprecate spring-cloud-azure-starter-keyvault-secrets)

Here are some of the features:

Vault Repositories
@VaultPropertySource
etc.. (to be done)

Closing this feature in favor of https://github.com/Azure/azure-sdk-for-java/issues/25708


Next state does not have document removed from remaining

https://github.com/abhi1345/deep-q-rank/blob/1f97dfed934351b5fb24e63515beed11a7bf87a0/model/mdp.py#L60

The more I look at this, the less sense it makes. A state is defined by $X$, $Y$, and $t$, where $X$ is the set of remaining documents, $Y$ is the ordered documents, and $t$ is the timestamp. But the State class doesn't even contain $Y$.


Bug/2366 style changes breaks react inline forms text input

Adding color: inherit;'s back in on inline forms to fix issue #2362

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Xavier Mirabelli-Montan:x: xaviemirmonXavier Mirabelli-Montan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Missing parameter in authFinish::handleAccessTokenResponse

NoSuchMethodError: No top-level method 'handleAccessTokenResponse' with matching arguments declared.
Receiver: top-level
Tried calling: handleAccessTokenResponse(Instance of 'Response', Instance of '_SimpleUri', Instance of 'DateTime', Instance(length:1) of '_GrowableList')
Found: handleAccessTokenResponse(Response, Uri, DateTime, List, String)
This happened for me on line 147:
  `oauth2.Credentials credentials = handleAccessTokenResponse(response, _TOKEN_ENDPOINT, startTime, ["*"];`

fixed by adding empty quotes in the parameter list (not sure what the actual value is supposed to be though)

Are you talking about this line? It does have the quotes there..

Strange. The line is missing when I pulled it down from the pub

I pushed an update to pub. I'm very sorry for the inconvenience!

Thanks for the fix! Glad I could "help"


add instruction to spm installation + separate env command

Codecov Report

Merging #65 into master will decrease coverage by 2.64%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   85.28%   82.64%   -2.65%
==========================================
  Files          32       32
  Lines        1312     1325      +13
  Branches      114      115       +1
==========================================
- Hits         1119     1095      -24
- Misses        159      195      +36
- Partials       34       35       +1

Impacted Files
Coverage Δ

neurodocker/interfaces/spm.py
88.57% <94.11%> (+2.6%)
:arrow_up:

neurodocker/interfaces/afni.py
50% <0%> (-40.48%)
:arrow_down:

neurodocker/interfaces/tests/test_afni.py
64.28% <0%> (-35.72%)
:arrow_down:

neurodocker/interfaces/tests/test_fsl.py
41.17% <0%> (-29.42%)
:arrow_down:

neurodocker/interfaces/tests/test_ants.py
76.19% <0%> (-23.81%)
:arrow_down:

neurodocker/interfaces/fsl.py
60.93% <0%> (-4.69%)
:arrow_down:

neurodocker/interfaces/ants.py
91.48% <0%> (-4.26%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507d7a7...c881150. Read the comment docs.


Payload validation failed

hello friend, come tell something that happened to me, I do not know if it was by your module, but it happened so, I have a s5 with rom ressurection remix v5.7.4 day 23 using magisk migration method for suhide, installed your module and it worked perfect, turned off the function to detect the GPS soon after went to a website and I logged my account, the site was pogobag, compared iv and transfer some pokemons, log out and went pro game, worked regular, spent about 30 minutes not I was more into the game, I logged my account on the phone my wife and work, there on my phone I tested the application "SafetyNET for help" and was giving error "response payload validation failed", I had to reset my phone to voltata to work, however today took a sleep in the afternoon and when I woke up gave the same problem, and after a few minutes returned to work! I really want to use Snorlax module, but to give apprehending some new problem. I await your help

Sounds like SafetyNet is detecting xposed... I bypassed it with suhide.
Closing because is not related to Snorlax


ErrorException

Hi,
After installed, I can login, put I receive these 3 messages:
ErrorException in 34e4b611ec528e06b78fd64f43c7aa157e4bb0f6.php line 18: getimagesize(http://MY_URL/index.php/uploads/fakers/b7fa5278b160386db95eae190ebef675.jpg): failed to open stream: HTTP request failed! HTTP/1.0 404 Not Found
(View: /MY_PATH/connfa/resources/views/partials/speaker.blade.php) (View: /srv/connfa.curitibalivre.org.br/www/connfa/resources/views/partials/speaker.blade.php)
ErrorException in 34e4b611ec528e06b78fd64f43c7aa157e4bb0f6.php line 18: getimagesize(http://MY_URL/index.php/uploads/fakers/b7fa5278b160386db95eae190ebef675.jpg): failed to open stream: HTTP request failed! HTTP/1.0 404 Not Found
(View: /MY_PATH/connfa/resources/views/partials/speaker.blade.php)
ErrorException in 34e4b611ec528e06b78fd64f43c7aa157e4bb0f6.php line 18: getimagesize(http://MY_URL/index.php/uploads/fakers/b7fa5278b160386db95eae190ebef675.jpg): failed to open stream: HTTP request failed! HTTP/1.0 404 Not Found
Thanks.

Hi, @phls
We found this error to. It appears when images has unreachable link.
We will fix this issue in next release.
For now you can fix it in file resources/views/partials/speaker.blade.php line 14
Instead of code
@if(empty($speaker->avatar))
{{ Html::image('/assets/images/user.png', $speaker->fullname, ['width' => 85, 'height' => 85, 'class' => 'img-circle dash-circle-profile-img']) }}
@else
    <?php list($width, $height, $type, $attr) = getimagesize($speaker->avatar);
    $class = '';
    if($width < $height){
        $class = 'dash-circle-profile-img-height';
    }
    ?>
{{ Html::image($speaker->avatar, $speaker->fullname, ['width' => 85, 'height' => 85, 'class' => "img-circle dash-circle-profile-img $class"]) }}
@endif

use this
 @if(empty($speaker->avatar))
    {{ Html::image('/assets/images/user.png', $speaker->fullname, ['width' => 85, 'height' => 85, 'class' => 'img-circle dash-circle-profile-img']) }}
@else
    <?php
    try {
        list($width, $height, $type, $attr) = getimagesize($speaker->avatar);
        $class = '';

        if ($width < $height) {
            $class = 'dash-circle-profile-img-height';
        }
        $real_image = true;
    } catch (\Exception $e) {
        $real_image = false;
    }
    ?>
    @if ($real_image)
        {{ Html::image($speaker->avatar, $speaker->fullname, ['width' => 85, 'height' => 85, 'class' => "img-circle dash-circle-profile-img $class"]) }}
    @else
        {{ Html::image('/assets/images/user.png', $speaker->fullname, ['width' => 85, 'height' => 85, 'class' => 'img-circle dash-circle-profile-img']) }}
    @endif
@endif

Done. Thanks.


Restrict produces empty dataset with EPSG:6670

Sample dataset: /home/jovyan/shared/nkd-W_02PC8404_ept_1-1-0-0.laz

Most likely because the CRS swaps coordinates. Should be solved by adding a swapped_coordinates parameter to DataSet that is set to True if EPSG:4326 or explicitly by the user. Important: Needs to be passed on every Dataset construction.

#249 might be related.


Javascript coloring: function keyword not colored in default themes

@egamma FYI

I would like to add that I've seen other reserved word not being correctly colored (I'm in dark theme).

default is blue but in switch statement turns back to normal color when followed by :
typeof
instanceof

I'm still looking for other...

@Nimzozo can you check whether these keywords are are colored when you use the Dark+ theme?
In the example from @dbaeumer above the Dark+ theme colors  function as a key word.

@egamma When I use Dark+ theme, that's exactly the same behaviours that I described.
I just see there are new colors for parameters, identifers, etc...

In monokai theme :

constructor
default followed by : inside a switch statement
extends
static
yield

are not in pink color.

@Nimzozo for those 5 it is likely because https://github.com/Microsoft/TypeScript-TmLanguage doesn't support highlighting them yet.

I can confirm that @Nimzozo list does not get colored in Dark+ theme.

@dbaeumer The reason for function not beeing colored in the Default Visual Studio theme is https://github.com/Microsoft/TypeScript-TmLanguage/issues/44
(Please always append the code example to save some time on reproducing the issue)

@Nimzozo Thanks for reporting. The issues you are mentioning are mostly caused by
https://github.com/Microsoft/TypeScript-TmLanguage/issues/37
We are working with the TypeScript team to get these fixed.


problems with src and local bib

I have two files in the same folder: index.html and CoolPropBibTeXLibrary.bib (the same file you used in examples).
If the code of index.html is
<!DOCTYPE html>

	<bibtex src="https://raw.githubusercontent.com/CoolProp/CoolProp/master/CoolPropBibTeXLibrary.bib"></bibtex>

it works perfectly well, but if I just change the src to src="CoolPropBibTeXLibrary.bib" it doesn't work.
The wrong index.html code is:
<!DOCTYPE html>

	<bibtex src="CoolPropBibTeXLibrary.bib"></bibtex>

¿How can I do to work with local bib files? ¿What's wrong?

Are you providing the local file through a web server? If you are just working with the file on your computer without a server then the problem is probably due to cross origin requests which are not allowed by most browsers.
You can quickly fix this by make that folder into a web server by running python -m SimpleHTTPServer in the folder (assuming you have python installed).
Then go to: http://localhost:8000/folder/folder2/index.html in your browser.
Hopefully that helps.

Thanks, that's it


Transfer Go code in docs into separate files

Move code snippets inlined in markdown into their own files (e.g. docs/current/sdk/go/snippets) and import them back from markdown

If possible, if we could make them testable, that would be great.
That would require to follow the Go example conventions, but also, to display only a subset of this snippets, to avoid showing all those Go example conventions.
ref: https://go.dev/blog/examples

This is currently being done so I believe this issue can be closed now.


[BSO] Commands don't show cooldowns

🐛 Bug Report
ENGINE UPDATE BUG!!!
Doing a command with cooldown doesn't tell you how long until its available again.

(Only showed the "ty" so you can see how the bot didnt respond)

I believe this has been fixed.


Query: Fixes Group By queries with Select Value returning incorrect return type

Pull Request Template
Description
Currently, a query with Select Value and an Aggregate is returning the incorrect response format
SELECT VALUE COUNT(1)
FROM c
GROUP BY c.id

is returning
[ [ {"item":1} ] , [ {"item":1} ] ]

whereas the correct format should be
[1,1]

This PR provides a fix for this issue. Essentially during GroupBy Pipeline creation the current code does not propagate the aggregate operators for VALUE query correctly. This PR also added some more test coverage for GROUP BY queries both in execution and in Query Plan generation
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[] This change requires a documentation update

Closing issues
To automatically close an issue: closes #IssueNumber

Please add a proper description for the PR

Please add a proper description for the PR

Updated

    public AggregateItem(CosmosElement cosmosElement)

AggregateItem is used outside of GroupBy as well, no? Can you confirm how if/how it is able to handle a query like following without your change?
SELECT VALUE avg(c.age) FROM c

Refers to: Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/AggregateItem.cs:17 in 334a061. [](commit_id = 334a061b3199cf95617ee70b9b02b5e6f9f88a78, deletion_comment = False)

    public AggregateItem(CosmosElement cosmosElement)

It works. The SanityQueryTests.cs has a test cover for this

In reply to:<PHONE_NUMBER>

Refers to: Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/AggregateItem.cs:17 in 334a061. [](commit_id = 334a061b3199cf95617ee70b9b02b5e6f9f88a78, deletion_comment = False)


Nuscenes validation detection performance

I am not able to reproduce the nuscenes validation dataset performance that was reported. I am training on 8xV100 GPU with the provided config in the convfuser.yaml file.
When I evaluated the pre-trained model the performance is mAP: 0.6846, NDS: 0.7143 as reported. But when I trained the model from scratch the performance is only mAP: 0.6440, NDS: 0.6933. I also tried training with the pretrained lidar weights (using --load_from pretrained/lidar-only-det.pth) as mentioned in #207 and the performance is only mAP: 0.6752, NDS: 0.7121.
There is still a gap of about 1% in mAP. Is this to be expected or is there a way to address this in training?

Hi, when you trained with the pretrained lidar weights, have you found the validation map and nds values was getting lower and lower after each epoch? I meet this problem, but i don't know why....

Please use a cosine annealing learning rate schedule with starting learning rate = 2e-4 and train for six epochs. Loading pretrained LiDAR weights is necessary. Also, please remember to run the test.py script separately after the training. I'll release the configs very soon.

Closed due to inactivity.


This seems awesome, but...

I'm running on ZSH on MacOS Sierra, and have no idea where to start with this. I don't really know how I can build a binary out of this source, since I don't work with go, and adding it to my path says /Users/wilsonhobbs/.zshrc:16: command not found: bronze. I would love some clarification and improved documentation!

Thanks for showing interest in this project!
The first thing you'll want to do if you want the custom icons, is install and enable a Nerd Font. If you don't want to install a patched font, you can disable icons.
Then you need to install the binary. Since you're running macOS, I'm unable to cross-compile for Darwin on Linux because of the git2go dependency. (Once go-git provides support for everything bronze requires, I will use go-git, so I can provide pre-compiled binaries for macOS.)
Install Go, add $HOME/go/bin to your $PATH, and run go get github.com/reujab/bronze. bronze should now be executable.
Add the following to your ~/.zshrc:
BRONZE=(status:black:white dir:blue:black git:green:black cmdtime:magenta:black)
export BRONZE_SHELL=zsh
eval "$(bronze init)"

You can read more about the available modules here.
I've never compiled this on macOS, so I'm not entirely sure it will compile. If it gives an error, please reply with the error message. I will probably be able to make the switch to go-git soon, but if I am still unable to, I will create an issue on that repository requesting the required functionality.
If it does compile on macOS, I will update the documentation accordingly.

Ok the error I am getting is bronze: unrecognized shell with Zsh in iTerm 2

Nevermind, I goofed, but now I get the error precmd:1: bad math expression: operator expected at `N-15050598...'

What is the output of date +%s%3N?

15050599393N

The GNU date that comes with Linux is different that the BSD date that comes with macOS. The BSD date does not support nanoseconds/milliseconds in the output, and I cannot find any easy way to get the UNIX timestamp in milliseconds other than installing the GNU date on macOS.

Install Homebrew
Install GNU binaries (brew install coreutils)
Add alias date="gdate" to your .zshrc before bronze init.

Or if you're not interested in the cmdtime module, you can skip this and remove cmdtime:magenta:black from $BRONZE.

I did that and now get error env: 0: No such file or directory

And apparently BSD env differs from GNU env. This has been fixed. Update bronze using go get -u github.com/reujab/bronze and try again.

Awesome, but now I'm getting this error fatal: No url found for submodule path 'vendor/libgit2/tests/resources/rebase-submodule/my-submodule' in .gitmodules Failed to recurse into submodule path 'vendor/libgit2' package gopkg.in/libgit2/git2go.v26: exit status 1
I really really really appreciate your help with this! Sorry to bother you on the weekend!

That is an issue with git2go. See libgit2/git2go#407. You can safely ignore this error.

it's not letting me install the update because of the error.

go get -u github.com/reujab/bronze downloaded the latest commit from GitHub, but didn't install it since git2go failed to compile for the second time. Running go get github.com/reujab/bronze after the previous command will install the latest version that was just downloaded. My bad.

That worked, but now this 😢
panic: strconv.Atoi: parsing "       0": invalid syntax

goroutine 19 [running]:
main.die(0x462bae0, 0xc42001a150)
	/Users/wilsonhobbs/go/src/github.com/reujab/bronze/main.go:25 +0x4a
main.statusSegment(0xc420073290)
	/Users/wilsonhobbs/go/src/github.com/reujab/bronze/status.go:31 +0x147
main.handleModule(0x7fff5fbff955, 0x6, 0xc420073290, 0xc420073260, 0x0, 0x0)
	/Users/wilsonhobbs/go/src/github.com/reujab/bronze/modules.go:12 +0x525
main.cmdPrintAction.func1(0xc420073260, 0x3, 0x3, 0xc420073290, 0xc42006f690)
	/Users/wilsonhobbs/go/src/github.com/reujab/bronze/print.go:46 +0x7f
created by main.cmdPrintAction
	/Users/wilsonhobbs/go/src/github.com/reujab/bronze/print.go:48 +0x20c

Wow, I didn't realize the BSD tools differed so much from the GNU tools.
Run the following:
go get -u github.com/reujab/bronze
go get github.com/reujab/bronze

You should see the same git2go error, you can ignore it.

YES! IT WORKS!
And it looks amazing, can't wait to dive in. Thanks so much for your help!

Thanks again for helping me make this compatible with macOS. If you have any other problems/requests, I'll be glad to help.


[stable/jenkins] Fix: Always mount jenkins-secrets volume if secretsFilesSecret is set

What this PR does / why we need it:
If secretsFilesSecret is set we should always mount /var/jenkins_secrets not depending on enableXmlConfig being set to true.
Which issue this PR fixes

Reference #16477

Special notes for your reviewer:
Tuned config.yaml to match and also moved secrets-dir up to get rid of a conditional.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @viglesiasce

/assign @torstenwalter

May I ask you to also update the CHANGELOG.md?

Sure, where is it? :)

May I ask you to also update the CHANGELOG.md?

Sure, where is it? :)

https://github.com/helm/charts/blob/master/stable/jenkins/CHANGELOG.md

https://github.com/helm/charts/blob/master/stable/jenkins/CHANGELOG.md

Ah, recently added 👍

/assign @torstenwalter

/lgtm

@bergemalm Thanks for your PR and the patience to resolve the issues. Well done.


mount point supports non-repeatable mount

Signed-off-by: mfordjody<EMAIL_ADDRESS>What this PR does / why we need it:
Client mount point supports non-repeatable mount.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes https://github.com/cubefs/cubefs/issues/1904
Special notes for your reviewer:
None
Release note:

None

Codecov Report

Merging #1961 (7a761da) into master (97c59a4) will decrease coverage by 0.03%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master    #1961      +/-   ##
==========================================
- Coverage   45.29%   45.26%   -0.03%
==========================================
  Files         472      472
  Lines       84824    84824
==========================================
- Hits        38420    38398      -22
- Misses      43361    43380      +19
- Partials     3043     3046       +3

see 13 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mfordjody Can you explain in detail the principle of your implementation?

@mfordjody Can you explain in detail the principle of your implementation?

If the length of the dir string is 1, then it is returned immediately. It is also returned directly if the OpContext field of the config structure is not nil. Send a nil value to ready to notify that the mount operation is ready. Open the /dev/' directory with os.Openand return it directly if an error occurs during the open operation, or if the error indicates that the file or directory already exists. Finally, at the end of the function execution, the file descriptordev` is closed and the corresponding resources are freed.

@mfordjody能详细说说你的实现原理吗？

If the length of the dir string is 1, then it will be returned immediately. It is also returned directly if the OpContext field of the config structure is not nil. Send a nil value to ready to notify that the mount operation is ready. Open the /dev/ directory with os.Open and return directly if an error occurs during the open operation, or if the error indicates that the file or directory already exists. Finally, at the end of the function execution, the file descriptor dev is closed and the corresponding resources are freed.

Not suitable for merging


AWS Secret Access Key / Secret not saving

It appears the AWS Access Key / Secret fields do not save properly.  No matter what I put in the field, they always come back empty.  This is true on both the global as well as job-specific settings.
Not sure if related or a different problem, but when trying to use alternative method of injecting environment variables for AWS_ACCESS_KEY and AWS_SECRET_KEY, the plugin does not seem to recognize and use them either.

+1.  Experiencing the same issue.

Same problem with the saving here. Actually the codes uses AWSSecurityTokenServiceClient which uses different variables (see http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/securitytoken/AWSSecurityTokenServiceClient.html): AWS_ACCESS_KEY_ID and AWS_SECRET_KEY. But I don't seem to have success with them, too.

I am also having the same issue. Any ideas when the fix will be merged and available on the Jenkins Update Server?

@afitzgibbon Can this get some love?

I am also seeing this issue, Any ETA when the fix will be available. Also are there any workarounds.

Thank you for bringing this to our attention. We've reproduced the issue and are working on a fix for it. We will post an update once the fix is rolled out.


[v1.5] Navigate Command for finding directions

[x] NavigateCommand for directions between people, tasks and manually input addresses
[x] NavigateCommandParser
[x] Implement TaskAddress
[x] JUnit Tetsts
[x] Update UG
[x] Update DG

#129, #132, #134


Trampoline function call v2

Close #757.

Codecov Report

Merging #795 (d42f19d) into main (e025c21) will decrease coverage by 0.04%.
The diff coverage is 22.72%.

@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
- Coverage   85.26%   85.21%   -0.05%
==========================================
  Files         315      315
  Lines       29080    29100      +20
==========================================
+ Hits        24796    24799       +3
- Misses       4284     4301      +17

Impacted Files
Coverage Δ

lib/ffi/src/cps/async_stack.rs
79.59% <0.00%> (-10.41%)
:arrow_down:

lib/ffi-macro/src/function.rs
94.69% <100.00%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e025c21...d42f19d. Read the comment docs.


Og title

related issue: #198

fixed the PR in https://github.com/Stockholm-AI/stockholm-ai/compare/setup_og_preview_thumbnail?expand=1
great work @ycpei !!

fixed the PR in https://github.com/Stockholm-AI/stockholm-ai/compare/setup_og_preview_thumbnail?expand=1
great work @ycpei !!

fixed the PR in https://github.com/Stockholm-AI/stockholm-ai/pull/248
great work @ycpei !!


Fix automatic update

Files were not added before commiting the changes
Signed-off-by: Romain Arnaud<EMAIL_ADDRESS>

Forcing merge without review as cannot impact users, and I'd like to troubleshoot any credential issue if there is any.


neon to nmdc-schema mappings

I will define a neon.schema prefix in the nmdc-schmea, with an obvious placeholder expansion
@bmeluch and others will create a assets/neon_nmdc_term_mappings.tsv document in the nmdc-schema repo with four/five columns

nmdc_class
nmdc_slot
neon_table
neon_column
notes?

I will write some code that asserts mappings in slot_usages like

mappings:
- neon.schema:<neon_table>.<neon_column>

Nice work!
Are you requesting that dna_concentration and dna_absorb1 should be attributes of the Extraction process? I suggest associating those slots with the ProcessedSample that actually has those characteristics. Maybe we should relocate sample_mass too.
Think about it this way: if a schema had a Cooking processes, and a served_to slot that pointed to a Person, then a satisfaction slot should be associated with the Person, not the Cooking.
It doesn't matter how our data source models the data, especially if it's coming form relational tables, which are notorious for mixing concerns. It's our responsibility to determine  what entities have what qualities, and the nmdc-schema supports doing that in a way that reflects reality better than most relational databases.
Sometimes you can double check your intentions by looking at the other things that use those slots. dna_concentration and  dna_absorb1 are only associated with Biosample, which is a MaterialEntity, not a PlannedProcess

@turbomam We were discussing which ones it belongs to, and ProcessedSample makes a lot of sense. I think since sample_mass was in the Extraction class, we thought those should go in there too. But it makes sense to move those slots into ProcessedSample!

Are we done with this?

@turbomam are we done with this?

Might want to revisit this some day


Renamed batchUpdatesCollector to batchUpdates fixes #556

Changes in this pull request
Issue fixed: #556

Thanks @jessesquires 💃  🎉


Fix CHANGELOG typo/formatting

Correct 'where' to 'were' and add missing code formatting.

My pedantry is satisfied. :smile:


Use set operations to check for matching certificates and keys

When searching for a match between the pinned certificates and the server certificates, using set operations would express the logic in a simpler way. Same thing goes for public key matching.

Just realised unit tests fail on iOS 8, will close this PR for now


[WIP] Document how to migrate all the descriptions and helpers to i18n.T and raise a first good issue later

This is an umbrella issue to migrate all the descriptions and helpers from all the commands to use i18n.T + ensure that future commands and changes gets the proper translations.

We need to figure out all the parts of kubectl that uses 'translatable' strings and are not using i18n.T strings
We need to figure out all the parts that already have i18n.T strings but miss parts on other translations (like translations/kubectl or the matrix files for the translation templating)
With this issue, define how to 'test' a translation process (like, is there possible to fetch all the i18n strings and check if they exists in a specific matrix file, and also in translation files?)

With all of this proper written and defined, we can re-take again the 'convert all the strings to i18n' with a proper PR that covers:

Files / groups of files being changed
Adding the text into a matrix file that is used by translations (if it exists, need to figure out)
Verify if the proper test exists for that string

@apelisse @eddiezane sounds good? If this is ok, I'll start to document into this issue (feel free to unsubscribe!) and then turn this into a proper good first issue so we can work on the missing commands, and also into a test that can check if any command lacks the translation and fails when someone adds a new command.

/assign @rikatz

/assign @rikatz

xref: https://github.com/kubernetes/kubernetes/pull/97610

xref: https://github.com/kubernetes/kubernetes/pull/97610

/cc

/cc

/triage accepted
/priority backlog

/remove-lifecycle stale

/remove-lifecycle stale

Hey @raelga  👋  long time no see :D
Do you want helping me on this? I was going to write a KEP, but bandwidth is pretty hard here. Did some experiments over this, and discussed with @eddiezane on past about having some "language generator" where we have some "indexed texts" and each "translation team" could change only that translation when a new command was created, etc :D


WIP: Make MenuButton's switch_on_hover work again

Since Popups were made into full-fledged windows, the switch_on_hover feature (which allowed to switch from the popup of one MenuButton to another) broke completely. This PR fixes that.
...Well, mostly. On X11 at least, it's a coin toss if the popup will show properly or if it will disappear immediately. Any help on how to fix that is welcomed.

After investigation on X11 (ArchLinux/Gnome) I found out there's an issue in the popup logic itself (so it's actually different from #50367). There's a boolean popped_up in Popup which is used to avoid closing a popup before it has been focused, when the parent closes. But in some cases it's not reset properly, that's why it randomly fails.
I've opened #50711 to fix this case.
Also, I've tested on Windows and unfortunately this PR is not working properly on that platform. Mouse motion events are received only while the cursor is in the specific window (in this case the popup menu itself) so the case where another menu button is hovered is never triggered. I'm not sure if there could be a different logic that works on all platforms, otherwise this PR might require specific fixes on Windows to make it work.

@pouleyKetchoupp Thanks for the fix! Gonna investigate for another way of implementing this.

Thanks!


Re-integrate 1-99-dev into master

@indirect please make sure I didn't miss anything here?

@homu retry

This should pass now. @indirect / @smlance I'm not sure if we want to keep those man page changes though?

:umbrella: The latest upstream changes (presumably #4674) made this pull request unmergeable. Please resolve the merge conflicts.

:pushpin: Commit f94755c has been approved by indirect

@segiddins code climate doesn't like TODOs 😝
@homu r+

:hourglass: Testing commit f94755c with merge ce40e1f...

:sunny: Test successful - status


allow wallet configuration of number of confirmations before an invoice is considered paid

maybe use the suggested_confirmations_threshold field in the transfer since it seems reasonable, is based on the amount, and doesnt burden the user with having to configure anything


prepare for 2.1.0 release

docs rebuilt

Thanks!

As soon as Christoph updates his page, I'll grab windows wheels from there and upload them to pypi


Parent directories containing periods are erroneously filtered

Issue Description
When using a dataset where data files are organized into labelled directories, if the label (parent) directory of the record contains a . then ParentPathLabelGenerator will mistakenly use the parent directory as the label.
For example, if a dataset is structured as:
/msceleb
  - m.1298
    -- 1.jpg
    -- 2.jpg
  - m.088d832
    -- 1.jpg
    -- 2.jpg

When ParentPathLabelGenerator is used by a RecordReader such as ImageRecordReader, the label selected is ultimately msceleb and not the child directories. This will cause total labels to equal 1. If no label generator is provided, then total labels will be 0.
Version Information
Current master
Contributing
Investigating possible fixes currently.

Is this issue still viable?