[attachDiskAsync]: Attach disk does not work unless "iam.serviceAccounts.actAs" permission is set

Environment details

[attachDiskAsync]: Attach disk does not work unless "iam.serviceAccounts.actAs" permission is set
OS type and version: Linux amd64-64-Bit
Java version: 11.0.19
Version(s): Compute 1.38.0

Steps to reproduce

Set permissions to include "compute.instances.attachDisk", Attempt to attach a disk to a VM using "attachAsyncDisk".  It will fail, and in the operation details there is a message that the user does not have access to a different service account.
Now add permission "iam.serviceAccounts.actAs" and try it again.  It now works.
Other operations such as "create disk", "detach disk", "start instance", "stop instance" all work without this super permission.
This high level permission should not be required when the appropriate "compute.instances.attachDisk" permission is already set.

Code example
// example

Stack trace
Any relevant stacktrace here.

External references such as API reference guides

?

Any additional information below
Following these steps guarantees the quickest resolution possible.
Thanks!

Would you be able to share a repro (project or code sample) so I can run to replicate this issue? Or a guide if you were following a guide for running this inside Compute?
Also, could you share the stacktrace?

Thanks Lawrence, from the SDK call to “attachDiskAsync”, the stack trace was not very informative, but the image that I shared below on the operations console had a more detailed error that outlined the permissions issue.  This is the stack trace.
@.***
@.***
Here is a code snippet on how we attach the disks to the instance:
public Operation<EMAIL_ADDRESS>String projectId,
        @Nonnull String zone,
        @Nonnull String instanceName,
        boolean isBootDisk,
        boolean forceAttach,
        boolean autoDelete,
        @Nonnull String diskLink,
        @Nonnull String mode,
        @Nullable String deviceName
        ) throws IOException, InterruptedException, ExecutionException {

    final InstancesClient client = sdkClientSession.getOrCreateSdkClient(
            InstancesClient.class, this::createInstancesClient);

    AttachedDisk.Builder attachedDisk = AttachedDisk.newBuilder().setSource(diskLink).setMode(
            mode);

    if (isBootDisk) {
        attachedDisk.setBoot(true);
    }

    if (forceAttach) {
        attachedDisk.setForceAttach(true);
    }

    if (autoDelete) {
        attachedDisk.setAutoDelete(true);
    }

    if (!Strings.isNullOrEmpty(deviceName)) {
        attachedDisk.setDeviceName(deviceName);
    }

    AttachDiskInstanceRequest attachDiskInstanceRequest = AttachDiskInstanceRequest.newBuilder()
            .setProject(projectId)
            .setZone(zone)
            .setInstance(instanceName)
            .setAttachedDiskResource(
                    attachedDisk
                    .build())
            .build();

    return client.attachDiskAsync(attachDiskInstanceRequest).get();
}

Aalim Lakhani
IBM Toronto Software Lab
Phone:<PHONE_NUMBER>
Email<EMAIL_ADDRESS>From: Lawrence Qiu @.>
Sent: Thursday, February 15, 2024 2:26 PM
To: googleapis/google-cloud-java @.>
Cc: Aalim Lakhani @.>; Author @.>
Subject: [EXTERNAL] Re: [googleapis/google-cloud-java] [attachDiskAsync]: Attach disk does not work unless "iam.serviceAccounts.actAs" permission is set (Issue #10391)
Would you be able to share a repro (project or code sample) so I can run to replicate this issue? Or a guide if you were following a guide for running this inside Compute? Also, could you share the stacktrace? — Reply to this email directly,
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
Report Suspicious  https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!18-rKVWVoTMwki6Tu2uuZYVCxJJ3clOi8BaBV3LGEh06WPlRcR_5sbp62OUKmP-mkIiNxyhzkg_FooVc1C7NzQjDWrRMVyYBYm9su6xvFcsWWLg-7Ibd$
ZjQcmQRYFpfptBannerEnd
Would you be able to share a repro (project or code sample) so I can run to replicate this issue? Or a guide if you were following a guide for running this inside Compute?
Also, could you share the stacktrace?
—
Reply to this email directly, view it on GitHubhttps://github.com/googleapis/google-cloud-java/issues/10391#issuecomment-1947065054, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIXZGFYKHXXFVKINXAQ4F63YTZOMBAVCNFSM6AAAAABDKWVHWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBXGA3DKMBVGQ.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

but the image that I shared below on the operations console had a more detailed error that outlined the permissions issue

I am unable to see an image on GH (might not have uploaded to GH).
Looking at the IAM permissions: https://cloud.google.com/compute/docs/access/iam#compute.instanceAdmin.v1, I don't think anything is special regarding compute.instances.attachDisk. From this section, it seems like you wouldn't need to add serviceAccounts.actAs.
Was this something that had been working previously and suddenly failed? Or perhaps you added new permissions but the changes didn't propagate yet?

Thanks Lawrence, we are recently starting to use these APIs, so there was no previous usage scenario. We didn’t change anything recently. Other related operations such as detachDisk works, but attachDisks seems to have different behavior.
Aalim Lakhani
IBM Toronto Software Lab
Phone:<PHONE_NUMBER>
Email<EMAIL_ADDRESS>From: Lawrence Qiu @.>
Sent: Thursday, February 15, 2024 3:30 PM
To: googleapis/google-cloud-java @.>
Cc: Aalim Lakhani @.>; Author @.>
Subject: [EXTERNAL] Re: [googleapis/google-cloud-java] [attachDiskAsync]: Attach disk does not work unless "iam.serviceAccounts.actAs" permission is set (Issue #10391)
but the image that I shared below on the operations console had a more detailed error that outlined the permissions issue I am unable to see an image on GH (might not have uploaded to GH). Looking at the IAM permissions: https: //cloud. google. com/compute/docs/access/iam#compute. instanceAdmin. v1,
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
Report Suspicious  https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!18-rKVWVoTMwki6Tu2uuZYVCxJJ3clOi8BaBV3LGEh06WPlRcR_5sbp62OUKmP-mkMlNh0hyEg_FooVc1C7NzZfcNeqnfZRZ8meoq0Cug6GIb4k_-4jZ$
ZjQcmQRYFpfptBannerEnd
but the image that I shared below on the operations console had a more detailed error that outlined the permissions issue
I am unable to see an image on GH (might not have uploaded to GH).
Looking at the IAM permissions: https://cloud.google.com/compute/docs/access/iam#compute.instanceAdmin.v1https://cloud.google.com/compute/docs/access/iam#compute.instanceAdmin.v1, I don't think anything is special regarding compute.instances.attachDisk. From this section, it seems like you wouldn't need to add serviceAccounts.actAs.
Was this something that had been working previously and suddenly failed? Or perhaps you added new permissions but the changes didn't propagate yet?
—
Reply to this email directly, view it on GitHubhttps://github.com/googleapis/google-cloud-java/issues/10391#issuecomment-1947287358, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIXZGF4VTYZQHBGJLODCAQDYTZV4VAVCNFSM6AAAAABDKWVHWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBXGI4DOMZVHA.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

I see. I will try to create a repro for the behavior above.
Also, if you have a support plan, feel free to reach out to our support hub for faster response times.

My simple repro:
String projectId = "{PROJECT_ID}";
    String zone = "us-central1-a";
    String instanceName = "{INSTANCE}";
    try (InstancesClient instancesClient = InstancesClient.create()) {
      AttachedDisk attachedDisk = AttachedDisk.newBuilder().setSource("projects/{PROJECT_ID}/zones/us-central1-a/disks/{DISK_ID}").build();
      AttachDiskInstanceRequest attachDiskInstanceRequest = AttachDiskInstanceRequest.newBuilder()
              .setProject(projectId)
              .setZone(zone)
              .setInstance(instanceName)
              .setAttachedDiskResource(attachedDisk)
              .build();
      Operation operation = instancesClient.attachDiskAsync(attachDiskInstanceRequest).get();
      System.out.println(operation);
    } catch (IOException e) {
      throw new RuntimeException(e);
    } catch (ExecutionException e) {
      throw new RuntimeException(e);
    } catch (InterruptedException e) {
      throw new RuntimeException(e);
    }

Result:
id: {ID}
kind: "compute#operation"
name: "operation-1234"
...
zone: "https://www.googleapis.com/compute/v1/projects/{PROJECT_ID}/zones/us-central1-a"
target_link: "https://www.googleapis.com/compute/v1/projects/{PRPJECT_ID}/zones/us-central1-a/instances/{INSTANCE}}"
...
self_link: "https://www.googleapis.com/compute/v1/projects/{PRPJECT_ID}/zones/us-central1-a/operations/operation-1234"

I just checked inside the console and I see that my disk is in use by the instance. Can you double check your permissions?

Thanks for your reply Lawrence, I’m not sure if you saw the problem detail that I sent Bharat.  We have an environment like the following:

We have a service account that is granted with three roles.  These roles have some assigned permissions.  We are noticing that unless one of these roles has assigned permissions for "iam.serviceAccounts.actAs", the SDK operation to attach a disk to an instance does not work, even though one of the permissions on the same role is:  "compute.instances.attachDisk".  As I mentioned, other very similar operations (including detaching disks, does not have this same behavior).
So we do not have a single user with the permission, but instead have a service account that is granted three roles, and these roles have the permissions.  In this scenario, it is where we see that the “attachDisk” fails unless we give “actAs” to one of the roles.
Aalim Lakhani
IBM Toronto Software Lab
Phone:<PHONE_NUMBER>
Email<EMAIL_ADDRESS>From: Lawrence Qiu @.>
Sent: Friday, February 16, 2024 2:26 PM
To: googleapis/google-cloud-java @.>
Cc: Aalim Lakhani @.>; Author @.>
Subject: [EXTERNAL] Re: [googleapis/google-cloud-java] [attachDiskAsync]: Attach disk does not work unless "iam.serviceAccounts.actAs" permission is set (Issue #10391)
My simple repro: String projectId = "{PROJECT_ID}"; String zone = "us-central1-a"; String instanceName = "{INSTANCE}"; try (InstancesClient instancesClient = InstancesClient. create()) { AttachedDisk attachedDisk = AttachedDisk. newBuilder(). setSource("projects/{PROJECT_ID}/zones/us-central1-a/disks/{DISK_ID}"). build();
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
Report Suspicious  https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!18-rKVWVoTMwki6Tu2uuZYVCxJJ3clOi8BaBV3LGEh06WPlRcR_5sbp62OUKmP-nUndKn18NsvEjK7_REO1jPPUTAYxUkq7WDGtLikI0oHutAHKjW8ci$
ZjQcmQRYFpfptBannerEnd
My simple repro:
String projectId = "{PROJECT_ID}";
String zone = "us-central1-a";

String instanceName = "{INSTANCE}";

try (InstancesClient instancesClient = InstancesClient.create()) {

  AttachedDisk attachedDisk = AttachedDisk.newBuilder().setSource("projects/{PROJECT_ID}/zones/us-central1-a/disks/{DISK_ID}").build();

  AttachDiskInstanceRequest attachDiskInstanceRequest = AttachDiskInstanceRequest.newBuilder()

          .setProject(projectId)

          .setZone(zone)

          .setInstance(instanceName)

          .setAttachedDiskResource(attachedDisk)

          .build();

  Operation operation = instancesClient.attachDiskAsync(attachDiskInstanceRequest).get();

  System.out.println(operation);

} catch (IOException e) {

  throw new RuntimeException(e);

} catch (ExecutionException e) {

  throw new RuntimeException(e);

} catch (InterruptedException e) {

  throw new RuntimeException(e);

}

Result:
id: {ID}
kind: "compute#operation"
name: "operation-1234"
...
zone: "https://www.googleapis.com/compute/v1/projects/{PROJECT_ID}/zones/us-central1-ahttps://www.googleapis.com/compute/v1/projects/{PROJECT_ID}/zones/us-central1-a"
target_link: "https://www.googleapis.com/compute/v1/projects/{PRPJECT_ID}/zones/us-central1-a/instances/{INSTANCE}https://www.googleapis.com/compute/v1/projects/{PRPJECT_ID}/zones/us-central1-a/instances/{INSTANCE}}"
...
self_link: "https://www.googleapis.com/compute/v1/projects/{PRPJECT_ID}/zones/us-central1-a/operations/operation-1234https://www.googleapis.com/compute/v1/projects/{PRPJECT_ID}/zones/us-central1-a/operations/operation-1234"
I just checked inside the console and I see that my disk is in use by the instance. Can you double check your permissions?
—
Reply to this email directly, view it on GitHubhttps://github.com/googleapis/google-cloud-java/issues/10391#issuecomment-1949194318, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIXZGFZII3HXYYXF5BU6ZCLYT6XFHAVCNFSM6AAAAABDKWVHWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGE4TIMZRHA.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Hi sorry, I wasn't been able to look at this issue earlier. I see the comment you copied below (apologies I may have missed that above, but GH is doing something weird with your emails and I have to manually expand our conversation).
We have a service account that is granted with three roles. If I'm understanding this correctly, one of those roles is compute.instanceadmin.v1 (https://cloud.google.com/compute/docs/access/iam#compute.instanceAdmin.v1), correct? From reading the docs, that should have the attachDisk permission.
I see from the section above in the same page: https://cloud.google.com/compute/docs/access/iam#the_serviceaccountuser_role, it talks about also granting roles/iam.serviceAccountUser. Can you check that this role is also granted to the Service Account? It specifically calls out Attach a persistent disk to an instance that runs as a service account., so my assumption is that attaching a disk requires the additional iam.serviceAccounts.actAs permission.

Thanks for replying Lawrence, maybe its terminology, but I think we are slightly talking slightly about different things.  We do not use specifically grant the role “compute.instanceadmin.v1“, also the docs that you reference say: “Attach a persistent disk to an instance that runs as a service account.”, I don’t think we are doing that.  I’m not sure what it means for an instance to “run as a service account”, but this instance is just a normal instance created by a user.  There is no configuration that I can see that shows that it is running as a service account.
To elaborate on our config. We have a service account that is bound to three separate custom roles.  These are not roles from GCP, but roles that we created.  Each of these roles has a set of permissions applied to it.  On one of these roles, we have the permission to attach a disk, but we need to add “actAs” as a permission on one of these roles, to get the attach to work.
If I sect the service account from the list on the console and click on “Permissions->View Access->Analyze->Run Query”, I see that the Results list has three rows, with the Principal as the service account, and the Role grant” column containing   the three custom roles that I mentioned above.  If I click the “View Binding” link, I see that each of these roles has several members, and one of these members is this service account.
I hope this description helps you to understand the configuration.  I would be happy to meet with you to show you in a call, if this would help.  Thanks.
Aalim Lakhani
IBM Toronto Software Lab
Phone:<PHONE_NUMBER>
Email<EMAIL_ADDRESS>From: Lawrence Qiu @.>
Sent: Tuesday, February 20, 2024 11:33 AM
To: googleapis/google-cloud-java @.>
Cc: Aalim Lakhani @.>; Author @.>
Subject: [EXTERNAL] Re: [googleapis/google-cloud-java] [attachDiskAsync]: Attach disk does not work unless "iam.serviceAccounts.actAs" permission is set (Issue #10391)
Hi sorry, I wasn't been able to look at this issue earlier. I see the comment you copied below (apologies I may have missed that above, but GH is doing something weird with your emails and I have to manually expand our conversation). We have
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
Report Suspicious  https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!18-rKVWVoTMwki6Tu2uuZYVCxJJ3clOi8BaBV3LGEh06WPlRcR_5sbp62OUKmP-GhaBSxmnUT7QCSo5pc7qC4rp1se2Y_EpyefOVCv3tvTLC7XS8p_QC$
ZjQcmQRYFpfptBannerEnd
Hi sorry, I wasn't been able to look at this issue earlier. I see the comment you copied below (apologies I may have missed that above, but GH is doing something weird with your emails and I have to manually expand our conversation).
We have a service account that is granted with three roles. If I'm understanding this correctly, one of those roles is compute.instanceadmin.v1 (https://cloud.google.com/compute/docs/access/iam#compute.instanceAdmin.v1https://cloud.google.com/compute/docs/access/iam#compute.instanceAdmin.v1), correct? From reading the docs, that should have the attachDisk permission.
I see from the section above in the same page: https://cloud.google.com/compute/docs/access/iam#the_serviceaccountuser_rolehttps://cloud.google.com/compute/docs/access/iam#the_serviceaccountuser_role, it talks about also granting roles/iam.serviceAccountUser. Can you check that this role is also granted to the Service Account? It specifically calls out Attach a persistent disk to an instance that runs as a service account., so my assumption is that attaching a disk requires the additional iam.serviceAccounts.actAs permission.
—
Reply to this email directly, view it on GitHubhttps://github.com/googleapis/google-cloud-java/issues/10391#issuecomment-1954598104, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIXZGF23CI75O3ZUVFYXOFDYUTF23AVCNFSM6AAAAABDKWVHWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJUGU4TQMJQGQ.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Gotcha. I think we are on the same page regarding the configs and your setup, but let me know if I'm misunderstanding anything.
You may have custom configs for your use case and I was referring the docs as they provided general GCP defaults (general roles that can be used if you're not creating custom ones). The compute.instanceadmin.v1 role contains the attachDisk permission:
. If one of the three roles that the SA is assigned to contains this, then we should be good on this permission. I believe from your comments above, this is the case.

There is no configuration that I can see that shows that it is running as a service account.

I have a question regarding how you're using the SA and our client library. I believe you're using the google-cloud-compute client library v1.38.0 and most likely authenticating with the SA Key: https://github.com/googleapis/google-cloud-java/?tab=readme-ov-file#using-a-service-account-recommended (i.e. most likely setting the GOOGLE_APPLICATION_CREDENTIALS with the path to the SA Key), right? You would be authenticating as the Service Account and would have access to anything the SA does.
The reason why I'm asking the question above is that I believe our docs is suggesting that the SA will need to additional role roles/iam.serviceAccountUser to run these actions:

with one of them being attaching a disk. Or specifically, your SA would at least need the additional permission of iam.serviceAccounts.actAs
. Your SA wouldn't have the compute.instanceadmin.v1 specifically, but rather three custom roles in your project.
From the docs above, I believe the behavior you're experiencing is intended.

Thanks Lawrence, generally what you are saying makes sense, but I am having a little trouble understanding how to add the “roles/iam.serviceAccountUser” and then giving this the “attachDisk” action.  This is probably because I am not that familiar with configuring IAM access in GCP.
I’ll run this past some of the devs here that may be able to interpret this better than me.  If you have any suggestions or info on how to best attach this role and permission to an existing service account please let me know.
Aalim Lakhani
IBM Toronto Software Lab
Phone:<PHONE_NUMBER>
Email<EMAIL_ADDRESS>From: Lawrence Qiu @.>
Sent: Tuesday, February 20, 2024 12:43 PM
To: googleapis/google-cloud-java @.>
Cc: Aalim Lakhani @.>; Author @.>
Subject: [EXTERNAL] Re: [googleapis/google-cloud-java] [attachDiskAsync]: Attach disk does not work unless "iam.serviceAccounts.actAs" permission is set (Issue #10391)
Gotcha. I think we are on the same page regarding the configs and your setup, but let me know if I'm misunderstanding anything. You may have custom configs for your use case and I was referring the docs as they provided general GCP defaults
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
Report Suspicious  https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!18-rKVWVoTMwki6Tu2uuZYVCxJJ3clOi8BaBV3LGEh06WPlRcR_5sbp62OUKmP-GheEzpqj0z7QCSo5pc7qC4rDz96AXGL-3UyWg55nwbI_43YnrFa1d$
ZjQcmQRYFpfptBannerEnd
Gotcha. I think we are on the same page regarding the configs and your setup, but let me know if I'm misunderstanding anything.
You may have custom configs for your use case and I was referring the docs as they provided general GCP defaults (general roles that can be used if you're not creating custom ones). The compute.instanceadmin.v1 role contains the attachDisk permission:
image.png (view on web)https://github.com/googleapis/google-cloud-java/assets/6621793/5b375e6a-c580-4d23-b732-bd7e2080a44f. If one of the three roles that the SA is assigned to contains this, then we should be good on this permission. I believe from your comments above, this is the case.
There is no configuration that I can see that shows that it is running as a service account.
I have a question regarding how you're using the SA and our client library. I believe you're using the google-cloud-compute client library v1.38.0 and most likely authenticating with the SA Key: https://github.com/googleapis/google-cloud-java/?tab=readme-ov-file#using-a-service-account-recommendedhttps://github.com/googleapis/google-cloud-java/?tab=readme-ov-file#using-a-service-account-recommended (i.e. most likely setting the GOOGLE_APPLICATION_CREDENTIALS with the path to the SA Key), right? You would be authenticating as the Service Account and would have access to anything the SA does.
The reason why I'm asking the question above is that I believe our docs is suggesting that the SA will need to additional role roles/iam.serviceAccountUser to run these actions:
image.png (view on web)https://github.com/googleapis/google-cloud-java/assets/6621793/f0d69d49-9ab1-4955-bdcc-4d5686cbaca9
with one of them being attaching a disk. Or specifically, your SA would at least need the additional permission of iam.serviceAccounts.actAs
image.png (view on web)https://github.com/googleapis/google-cloud-java/assets/6621793/af7967f5-ad70-4dea-b1a5-87cd6ed60cd2. Your SA wouldn't have the compute.instanceadmin.v1 specifically, but rather three custom roles in your project.
From the docs above, I believe the behavior you're experiencing is intended.
—
Reply to this email directly, view it on GitHubhttps://github.com/googleapis/google-cloud-java/issues/10391#issuecomment-1954723790, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIXZGFYLLBNTPGPKLWTU3UDYUTODPAVCNFSM6AAAAABDKWVHWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJUG4ZDGNZZGA.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

From my understanding of our conversation above, I think that one of the roles linked to your SA already has the attachDisk permission, so nothing needs to be done for that.
Unless there is a new GCP policy, I don't think you can directly add a permission to a SA. Rather, I think the correct action(s) would to be:

Modify one of the existing roles to include the iam.serviceAccount.actAs permission
Create a new custom role that has the iam.serviceAccount.actAs permission

I think this guide might be helpful: https://cloud.google.com/iam/docs/manage-access-service-accounts#single-role

Closing due to no response and @lqiu96's context on managing service account access. @aalimlakhani please feel free to re-open this issue if you have any further questions!


Error using flux1-redux image prompting/Style Model - CLIPVisionEncode.encode() missing 'crop' argument

Expected Behavior
I'm trying to used flux1-redux-dev as a style model with flux1-dev as main model; a) I'm dragging taking an existing pic to main screen, b) clicking More->Use as Image Prompt (which makes the Image Prompting options appear on the left), and selecting flux1-redux-dev from the Use Style Model dropdown. As per docs, I'm setting Style Model Apply Start to 0.2, but when I try to generate, I get the issue below. I've re-tried with/without Use Reference Only option, and various pics, models etc.
Actual Behavior
The generation fails, with the error in the Debug Logs below.
Steps to Reproduce
As above.
Debug Logs
2024-11-29 17:37:53.094 [Warning] [ComfyUI-0/STDERR] Traceback (most recent call last):
2024-11-29 17:37:53.095 [Warning] [ComfyUI-0/STDERR]   File "E:\SwarmUI\SwarmUI\dlbackend\comfy\ComfyUI\execution.py", line 323, in execute
2024-11-29 17:37:53.095 [Warning] [ComfyUI-0/STDERR]     output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
2024-11-29 17:37:53.096 [Warning] [ComfyUI-0/STDERR]                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-29 17:37:53.096 [Warning] [ComfyUI-0/STDERR]   File "E:\SwarmUI\SwarmUI\dlbackend\comfy\ComfyUI\execution.py", line 198, in get_output_data
2024-11-29 17:37:53.097 [Warning] [ComfyUI-0/STDERR]     return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
2024-11-29 17:37:53.097 [Warning] [ComfyUI-0/STDERR]                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-29 17:37:53.098 [Warning] [ComfyUI-0/STDERR]   File "E:\SwarmUI\SwarmUI\dlbackend\comfy\ComfyUI\execution.py", line 169, in _map_node_over_list
2024-11-29 17:37:53.098 [Warning] [ComfyUI-0/STDERR]     process_inputs(input_dict, i)
2024-11-29 17:37:53.099 [Warning] [ComfyUI-0/STDERR]   File "E:\SwarmUI\SwarmUI\dlbackend\comfy\ComfyUI\execution.py", line 158, in process_inputs
2024-11-29 17:37:53.100 [Warning] [ComfyUI-0/STDERR]     results.append(getattr(obj, func)(**inputs))
2024-11-29 17:37:53.101 [Warning] [ComfyUI-0/STDERR]                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-11-29 17:37:53.101 [Warning] [ComfyUI-0/STDERR] TypeError: CLIPVisionEncode.encode() missing 1 required positional argument: 'crop'
2024-11-29 17:37:53.102 [Warning] [ComfyUI-0/STDERR]
Other
This may just me being unclear on how to use the flux1-redux-dev model correctly, and if so, apologies.

Great stuff, many thanks for sorting.


[Bug][Scarthgap] ERROR caused by the do_deletebinaries task conflicting with the create-spdx class tasks

there is a race condition between the find/delete of the do_deletebinaries task and the create-spdx tasks, the later must be creating a temporary directory and cleaning it up right after.
here is the log output:
Build Configuration:
BB_VERSION           = "2.8.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "debian-12"
TARGET_SYS           = "x86_64-oe-linux"
MACHINE              = "..."
DISTRO               = "..."
DISTRO_VERSION       = "2.0a-9"
TUNE_FEATURES        = "m64 corei7"
TARGET_FPU           = ""
meta
meta-poky
meta-yocto-bsp       = "HEAD:f7def85be9f99dcb4ba488bead201f670304379b"
meta-oe
meta-multimedia
meta-python
meta-networking
meta-gnome
meta-webserver
meta-filesystems
meta-xfce
meta-perl
meta-initramfs       = "HEAD:18f939a5fb37528a5415b05077ece383c346a119"
meta-tpm             = "HEAD:abfa203aa6ec8a93d636f362b2ab2166d9952c98"
meta-clang           = "scarthgap:7d9bf6d3ca4df27cfd5fbd9482daa5bddc471362"
meta-intel           = "HEAD:d172a00f487a8ea4391b96e0f6cef5279c5a07d7"
meta-java            = "HEAD:ac65b6e5bbd2c9b55a64a13ab4c55d212a8b585f"
meta-python2         = "HEAD:c09fe5012b009af40b3d08b6e841de63d03ab341"
meta-qt5             = "HEAD:eb828418264a49b8d00035cb3d7b12fcea3be801"
meta-qt5-extra       = "HEAD:bcc4f2e08823dcb7a37f2d14c8c2f727938bd32c"
meta-rauc            = "scarthgap:f4d80f95952e15b1f98b5adacce7e21508d89b74"

Checking sstate mirror object availability: 100% |############################################################################################################################################################################################################| Time: 0:00:09
Sstate summary: Wanted 7780 Local 0 Mirrors 0 Missed 7780 Current 0 (0% match, 0% complete)
NOTE: Executing Tasks
ERROR: cup-native-0.10k-r0 do_deletebinaries: ExecutionError('/build/tmp-glibc/work/x86_64-linux/cup-native/0.10k/temp/run.do_deletebinaries.1246741', 1, None, None)
ERROR: Logfile of failure stored in: /build/tmp-glibc/work/x86_64-linux/cup-native/0.10k/temp/log.do_deletebinaries.1246741
Log data follows:
| DEBUG: Executing shell function do_deletebinaries
| find: ‘/build/tmp-glibc/work/x86_64-linux/cup-native/0.10k/sstate-build-create_spdx’: No such file or directory
| WARNING: exit code 1 from a shell command.
ERROR: Task (virtual:native:/build/../sources/meta-java/recipes-core/cup/cup_0.10k.bb:do_deletebinaries) failed with exit code '1'
NOTE: Tasks Summary: Attempted 4230 tasks of which 0 didn't need to be rerun and 1 failed.
NOTE: Build completion summary:
NOTE:   do_populate_sysroot: 0.0% sstate reuse(0 setscene, 114 scratch)
NOTE:   do_deploy_source_date_epoch: 0.0% sstate reuse(0 setscene, 457 scratch)
NOTE:   do_recipe_qa: 0.0% sstate reuse(0 setscene, 452 scratch)
NOTE:   do_populate_lic: 0.0% sstate reuse(0 setscene, 456 scratch)
NOTE:   do_create_spdx: 0.0% sstate reuse(0 setscene, 226 scratch)
NOTE:   do_create_runtime_spdx: 0.0% sstate reuse(0 setscene, 225 scratch)

Summary: 1 task failed:
  virtual:native:/build/../sources/meta-java/recipes-core/cup/cup_0.10k.bb:do_deletebinaries
Summary: There was 1 ERROR message, returning a non-zero exit code.
/sources/poky/bitbake/bin/bitbake failed with exit status 1.

I guess, ${WORKDIR}/sstate-build-* dirs should be ignored too


Fix/22/volume mounts override

Reloves #22
This PR fixes the issue with overriding volumeMounts for containers which are used op-cli to inject secrets.
Instead of applying only op volumeMount to the mutated container, it appends it to the existing volumeMounts.
Test steps:

Deploy injector, connect and you application pod (make sure application pod has mounted volumes for example redis. You can grab the app pod spec from the issue description
Verify that the secrets are injected into you application pod successfully (if you used the pod spec from the issue description just run  kubectl logs app-example-podname --namespace <namespace> the logs should print <Concealed by 1Password>).
Run kubectl describe pod <pod-name> --namespace <namespace> and check Mounts section. It should contain op mount along with redis. Something like

Mounts:
      /etc/redis from redis (rw)
      /op/bin/ from op-bin (ro)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-nmcmv (ro)

Note that before that fix, there were no redis entry in the Mounts.

@edif2008 I added steps to verify the fix in the PR description.


Anternative fix for CI to #3018

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

The version change in the expected pom is unnecessary, because version strings are ignored, but I think it would be good to keep them up-to-date in any case.
By applying the geode-dependency-management plugin at the root project, all top-level tasks, including but not limited to the resolveDependencies task, will depend on the local publication of the BOM, as intended.

Apparently I have to comment in a comment and not the commit message to link to #3018


Preview/Forced view shows OSX screen saver, not Aerial.

General troubleshooting tips
Before logging an issue please check that:

[x ] You have the latest version installed (There may be a beta version that fixes your issue), see here for the latest releases and bug fixes: https://github.com/JohnCoates/Aerial/releases
[x ] Your issue isn't already mentioned in our issues. You may find a workaround there or a similar request already made.
[ x] Your problem isn't mentioned in the troubleshooting page.

If none of this fixes your issue, tell us about the problem you are experiencing or the feature you'd like to request.
Required information
In order to help us sort your issue, we ask that you provide the following information:

[ ] Mac model: Macbook Pro
[ ] macOS version: 11.3.1
[ ] Monitor setup:

Description of issue / Feature request
When I preview, or force the screensaver with hot corners, I get another built in OSX screen saver, not this one. It could be a lock down setting or some such (this is a work computer), but every other aspect (selecting it, options) seems to work.

hey @cfjedimaster
Just to clarify, do you see a black screen for a few seconds THEN the other screen saver launches, or does it just goes straight to a built in saver (if so which ?).
Reason I'm asking is that in the event of a crash of a saver, macOS may launch another "safe" built in saver in its place. But it's usually pretty obvious that something was wrong (black screen hanging on for a few seconds etc).
I would suggest double checking in Console.app, see if you have any crash of legacyScreenSaver, ScreenSaverEngine, or Aerial, just to be sure, but this may be your machine being locked down here (I'm unfamiliar with the various locking down mechanisms so unclear how they work).
Here's another suggestion, try this in Terminal (make sure you've selected Aerial first in System Preferences then closed it) :
defaults -currentHost read com.apple.screensaver

Let me know what that says. You should see a section like this :
moduleDict =     {
        moduleName = Aerial;
        path = "/Users/you/Library/Screen Savers/Aerial.saver";
        type = 0;
    };

System Preferences may not be able to change that files and thus you're not able to change saver, is a possibility.

Nope, don't see a black screen (well I do, but for like one second, if that). Running that check gives me:
{
    CleanExit = YES;
    PrefsVersion = 100;
    idleTime = 300;
    moduleDict =     {
        moduleName = Aerial;
        path = "/Users/raycamde/Library/Screen Savers/Aerial.saver";
        type = 0;
    };
    tokenRemovalAction = 0;
}

Ok so very likely not a crash, though please check Console.app as mentioned above. Other think I can think of is, in Console.app too, filter with saver top right and start monitoring, then launch the saver via a hot corner, and paste the log lines you see. There might be some relevant info there that could explain what's happening to you.

Couldn't find anything. I swear this feels like something related to IT locking stuff down, but locking the screensaver seems like a weird thing. I appreciate your help.

No problem, it kinda looks like it. You could double check with another one such as Fliqlo : https://fliqlo.com/screensaver/ and see if you hit the same locking down issue.


为什么会出现这个错误

Main Thread Checker: UI API called on a background thread: -[UIApplication applicationState]
PID: 14860, TID: 2802484, Thread name: (none), Queue name: com.alipay.log, QoS: 0
Backtrace:
4   WIUUMPJSSBSdk                       0x00000001054f5bd8 __41-[APLogManager setupTimeForCheckFileSize]_block_invoke_2.608 + 140
5   libdispatch.dylib                   0x0000000105714c74 _dispatch_client_callout + 16
6   libdispatch.dylib                   0x0000000105717ffc _dispatch_continuation_pop + 524
7   libdispatch.dylib                   0x000000010572a610 _dispatch_source_invoke + 1444
8   libdispatch.dylib                   0x000000010571ca4c _dispatch_lane_serial_drain + 288
9   libdispatch.dylib                   0x000000010571d8b4 _dispatch_lane_invoke + 456
10  libdispatch.dylib                   0x000000010572777c _dispatch_workloop_worker_thread + 1148
11  libsystem_pthread.dylib             0x00000001a52fd114 _pthread_wqthread + 304
12  libsystem_pthread.dylib             0x00000001a52ffcd4 start_wqthread + 4
2019-07-10 14:51:02.906098+0800 SmartCity[14860:2802484] [reports] Main Thread Checker: UI API called on a background thread: -[UIApplication applicationState]
PID: 14860, TID: 2802484, Thread name: (none), Queue name: com.alipay.log, QoS: 0
Backtrace:
4   WIUUMPJSSBSdk                       0x00000001054f5bd8 __41-[APLogManager setupTimeForCheckFileSize]_block_invoke_2.608 + 140
5   libdispatch.dylib                   0x0000000105714c74 _dispatch_client_callout + 16
6   libdispatch.dylib                   0x0000000105717ffc _dispatch_continuation_pop + 524
7   libdispatch.dylib                   0x000000010572a610 _dispatch_source_invoke + 1444
8   libdispatch.dylib                   0x000000010571ca4c _dispatch_lane_serial_drain + 288
9   libdispatch.dylib                   0x000000010571d8b4 _dispatch_lane_invoke + 456
10  libdispatch.dylib                   0x000000010572777c _dispatch_workloop_worker_thread + 1148
11  libsystem_pthread.dylib             0x00000001a52fd114 _pthread_wqthread + 304
12  libsystem_pthread.dylib             0x00000001a52ffcd4 start_wqthread + 4

@panfeng1104 I don't see why you assume this is a problem with CocoaLumberjack. Our code doesn't do [UIApplication applicationState]. Closing the issue, feel free to comment and detail about it if I misunderstood.


Move wheel building to prep-relase script

This PR will move the building of wheels for PyPi to the prep-release.sh script to allow us to locally test the wheels to ensure correct usage before uploading to PyPi.

For some reason we now produce wheels both containing the release version and the actual OS version. (the 0_1_3 should not be there).


add share to teams

Docs Build status updates of commit 2dc6c59:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/resources/dev-preview/developer-preview-features.md
:warning:Warning

Details

msteams-platform/resources/dev-preview/developer-preview-intro.md
:white_check_mark:Succeeded

msteams-platform/resources/dev-preview/developer-preview-features.md

Line 15: [Warning] Invalid file link:(~/concepts/share-to-teams.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 60a9eeb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/resources/dev-preview/developer-preview-features.md
:white_check_mark:Succeeded

msteams-platform/resources/dev-preview/developer-preview-intro.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Swiper2 - Loop Mode - Full browser gallery (Duplication is visible)

I have a full browser gallery with some parts of the image visible, but the duplication is noticeable when it reaches the end of the loop, is there a simple way to get around this?

below is the code, nothing special;
$('#sec02 .swiper-container').swiper({
  slidesPerView:'auto'
  watchActiveIndex: true
  centeredSlides: true
  resizeReInit: true
  keyboardControl: true
  grabCursor: true
  #autoplay: 5000
  loop: true
  onImagesReady: ->
    changeSize()
})

changeSize: =>

  imgWidth = $('#sec02 .swiper-container .swiper-slide img').width()
  imgWidth += 44

  if $(window).width() <= 640

    imgWidth = 320

  $('#sec02 .swiper-container .swiper-slide').css('width', imgWidth)

I'm using Swiper2 and thank you for making this!

Okay I found the answer, just need to +1 the negative limit
params.loopedSlides = 2;
Haven't done any intense test, but looks good.

cheers!


Sharing stateful RNN between models

When sharing stateful rnn between models computational graph asks for inputs across these models. So I wonder if this is a good idea at all?
import keras
import numpy as np
from keras import layers
from keras.layers import merge

'''Large model - weights container'''
a_input = keras.layers.Input(batch_shape=(1,1,8))
a_gru = keras.layers.GRU(8, return_sequences=True, stateful=True)
a_top = a_gru(a_input)

b_input = keras.layers.Input(batch_shape=(1,1,8))
b_add = layers.add([b_input, a_top])
b_gru = keras.layers.GRU(8, return_sequences=True, stateful=True)
b_top = b_gru(b_add)

''' Small predictor - sharing b_gru from large '''
c_input = keras.layers.Input(batch_shape=(1, 1, 8))
c_gru = b_gru
c_top = c_gru(c_input)

ab = keras.models.Model(inputs=[a_input, b_input], outputs=b_top)
c = keras.models.Model(inputs=[c_input], outputs=c_top)

x = np.ones((1,1,8))
'''Here ab model wants input from model "c" due to statefulness of b_gru'''
ab.predict_on_batch([x,x])

here is the error:
`Caused by op u'input_3', defined at:
File "ii.py", line 18, in
c_input = keras.layers.Input(batch_shape=(1, 1, 8))
File "/Users/sz/anaconda/lib/python2.7/site-packages/keras/engine/topology.py", line 1414, in Input
input_tensor=tensor)
File "/Users/sz/anaconda/lib/python2.7/site-packages/keras/legacy/interfaces.py", line 88, in wrapper
return func(*args, **kwargs)
File "/Users/sz/anaconda/lib/python2.7/site-packages/keras/engine/topology.py", line 1325, in init
name=self.name)
File "/Users/sz/anaconda/lib/python2.7/site-packages/keras/backend/tensorflow_backend.py", line 391, in placeholder
x = tf.placeholder(dtype, shape=shape, name=name)
File "/Users/sz/anaconda/lib/python2.7/site-packages/tensorflow/python/ops/array_ops.py", line 1507, in placeholder
name=name)
File "/Users/sz/anaconda/lib/python2.7/site-packages/tensorflow/python/ops/gen_array_ops.py", line 1997, in _placeholder
name=name)
File "/Users/sz/anaconda/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 768, in apply_op
op_def=op_def)
File "/Users/sz/anaconda/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 2336, in create_op
original_op=self._default_original_op, op_def=op_def)
File "/Users/sz/anaconda/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1228, in init
self._traceback = _extract_stack()
InvalidArgumentError (see above for traceback): You must feed a value for placeholder tensor 'input_3' with dtype float and shape [1,1,8]
[[Node: input_3 = Placeholderdtype=DT_FLOAT, shape=[1,1,8], _device="/job:localhost/replica:0/task:0/cpu:0"]]`

Setting stateful flag to False in b_gru = keras.layers.GRU(8, return_sequences=True, stateful=False) resolves the issue, but it is not a desirable solution.


Ecapture  does not work in pcapng mode.

what?
I use ecapture to capture the rdp protocol flow to analyze the protocol details, but the packets captured in the pcapng mode are incomplete.
ecapture version
linux_x86_64:0.4.11-20230107-7b66305:5.15.0-1023-azure
arch and os
Linux localhost.localdomain 5.10.0-<IP_ADDRESS>.oe2209.x86_64 #1 SMP Wed Sep 28 07:03:00 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
And I checked the kernel's support for btf debug

freerdp
U can download freerdp、Xvnc directly using yum:
yum install freerdp tigervnc-server

run Xvnc
Xvnc :0 -rfbport 5900 -depth 24 -SecurityTypes None -pixelformat RGB888
run xfreerdp
DISPLAY=:0 xfreerdp -u foo --sec nla -v <IP_ADDRESS> -p bar
and ecapture
./ecapture tls -i foo --port 3389 --hex -w rdp.pcapng

Could you please provide some details of the pcapng file. I've tested in my ubuntu 22.04 with ecapture opened, which seems works well...

Could you please provide some details of the pcapng file. I've tested in my ubuntu 22.04 with ecapture opened, which seems works well...

wireshark can not open this file,file format maybe wrong. cat like:
�M<+��������
            ecapture.luaHsee https://ecapture.cc for more information. CFC4N<EMAIL_ADDRESS>Hardware�`��ens192/eCapture (旁观者): github.com/gojue/ecapture    `\��lo/eCapture (旁观者): github.com/gojue/ecapture              \`��ens192/eCapture (旁观者): github.com/gojue/ecapture         `
$KSLTCLIENT_RANDOM 3f1875bde5f56b1b264c7c461ef3a127a656dc0a56a6356d7a0e2f4702eaaeca 560b52cab00dfb95ef2a1e2938ca06b133fab34fcdf4c6edeb6ee400c86915fc6253fb47263085cb9cbf545d3972d996
CLIENT_RANDOM a330e461fb848806ddbfdab70fc6dbb2b2cfc6704d961bcd02a93f234e37df9b 333ba1c150300af43d95d457fca20cbdcaa0ee2fbe379e219025764261b691c934258d93ce725f9d087f1518f68c3d3b
CLIENT_RANDOM d410d9ea509db4194ad74fda7742760628179eeaa9a4bf77ba9d9ccaa722684b 3b07b24b336b995d89999e828378423e8d96e4c6a59698679b48b669b84ab5785e4c7b3108ecba67313fdccca551593f

Got it. I'll try this again on openEuler.

Problem is solved. To solve this, just compile the ecapture from source, where the vmlinux.h will be generated.


Review branch

surveysparrow flutter sdk

@sachin-kumar56 , Can we add this file .DS_Store to the .gitignore?


Add missing closing quotation

Bower install was broken with EMALFORMED error

Review and pull this in fast please :-)

Woops. thanks


chore(deps): bump passport from 0.6.0 to 0.7.0

tests work as expected.

I did this already with the dependabot push


update dependencies

What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

seems so, I will continue in next week

I am waiting answer to https://github.com/kubernetes/kubernetes/pull/115961#issuecomment-1512040807 to solve these issues:
I0417 20:42:21.346] tests/e2e/csi/manila/manilavolume.go:65:2: SA1019: framework.ExpectNotEqual is deprecated: use gomega.Expect().ToNot(gomega.BeEqual()) (staticcheck)
I0417 20:42:21.346] 	framework.ExpectNotEqual(shareID, "")
I0417 20:42:21.347] 	^
I0417 20:42:21.347] tests/e2e/csi/manila/manilavolume.go:90:2: SA1019: framework.ExpectNotEqual is deprecated: use gomega.Expect().ToNot(gomega.BeEqual()) (staticcheck)
I0417 20:42:21.347] 	framework.ExpectNotEqual(accessID, "")
W0417 20:42:21.457] exit status 1
W0417 20:42:21.646] make: *** [Makefile:84: check] Error 1
W0417 20:42:21.646] Traceback (most recent call last):
W0417 20:42:21.646]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 50, in <module>
W0417 20:42:21.647]     main(ARGS.env, ARGS.cmd + ARGS.args)
W0417 20:42:21.647]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 41, in main
W0417 20:42:21.647]     check(*cmd)
W0417 20:42:21.647]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 30, in check
W0417 20:42:21.647]     subprocess.check_call(cmd)
W0417 20:42:21.654]   File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
W0417 20:42:21.654]     raise CalledProcessError(retcode, cmd)
W0417 20:42:21.654] subprocess.CalledProcessError: Command '('make', 'check')' returned non-zero exit status 2.
I0417 20:42:21.654] 	^
I0417 20:42:21.654] tests/e2e/csi/manila/testdriver.go:190:2: SA1019: framework.ExpectEqual is deprecated: use gomega.Expect().To(gomega.BeEqual()) (staticcheck)
I0417 20:42:21.654] 	framework.ExpectEqual(ok, true, "Failed to cast test volume to Manila test volume")
I0417 20:42:21.655] 	^

/override openstack-cloud-csi-manila-sanity-test
/override openstack-cloud-csi-manila-e2e-test

@dulek @mdbooth @jichenjc could you review this PR? Do we have other items to finish before we could release 1.27?

/approve
I don't have further 1.27 items , thanks for driving this

I wonder if we can really say manila is supported right now, btw. We need to fix #2142

/retest

@mdbooth can you add lgtm again, I added your suggestions

/override openstack-cloud-csi-manila-e2e-test
/override openstack-cloud-csi-manila-sanity-test


Update request: python311Packages.uvicorn 0.24.0.post1 → 0.27.1

Package name: uvicorn
Latest released version: 0.27.1
Current version on the unstable channel: 0.24.0.post1
Current version on the stable/release channel: 0.23.2
[x] Checked the nixpkgs pull requests

Notify maintainers
@wd15
https://github.com/encode/uvicorn/releases/tag/0.27.1

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

This should be closed, since the PR was merged.


Pin a TaxonName

When I pin a taxonname and go to the pin board, and click on the taxonName there, The hyperlink should bring me to the BrowseNomenclature page, not to the TaxonName data page.

I also have noticed this and would like it changed. It breaks up the workflow.


Feature Request - Get heart rate data

We are still development new feature. In next releases this will be available.

I @addingama.
In the 0.3.0 we released the heart rate. You can try it


Not properly reset to HEAD commit of remote branch

See this run.
It seems here that the action is not properly including the latest changes on the remote.

It seems the commit SHA is different during the v1 checkout than what has been used as the commit SHA for the PR ref up until that point.

Still not working. Try perhaps changing to use GITHUB_REF instead of GITHUB_SHA?

Hi there! Looks like this is still an issue.
Here are the steps
      -
        name: Indexing Magick
        run: |
          INDEX_LIST=$(ls -1 ./migrations/indices/pending)
          node -r ./config/startup/ts-node-register ./migrations/indices --execute
          echo "COMMIT_MESSAGE=[skip ci] DB indices created ${INDEX_LIST}" >> $GITHUB_ENV
      -
        name: Git Magick
        run: |
          COMMIT_AUTHOR=$(git --no-pager show --format="%aN <%aE>" $GITHUB_SHA -s)
          CURRENT_BRANCH=$(echo $GITHUB_REF | sed -e "s#refs/heads/##g")
          git add ./migrations/indices/finished/
          git commit -m "${COMMIT_MESSAGE}" --author "${COMMIT_AUTHOR}"
          git push origin --delete ${CURRENT_BRANCH}
      -
        name: Push to protected branch
        uses: CasperWA/push-protected@v2
        with:
          token: ${{ secrets.PAT }}
          branch: development
          unprotect_reviews: true

And here is an output of "Push to protected branch" step
 * [new branch]          push-action/1525307555/14689-24028-13227 -> push-action/1525307555/14689-24028-13227
Creating temporary branch 'push-action/1525307555/14689-24028-13227' ... DONE!

Waiting for status checks to finish for 'push-action/1525307555/14689-24028-13227' ...

Configuration:
    interval: 30 seconds
    timeout: 15 minutes
    required status checks: ['Run Automated Tests']
        of which are:
            GitHub Action-related: 0
            Third-party checks: 0

All required GitHub Actions jobs complete!
Waiting for status checks to finish for 'push-action/1525307555/14689-24028-13227' ... DONE!

Remove 'development' pull request review protection ...
Remove 'development' pull request review protection ... DONE!

Pushing 'push-action/1525307555/14689-24028-13227' -> 'origin/development' ...
Branch 'development' set up to track remote branch 'development' from 'origin'.
Switched to a new branch 'development'
HEAD is now at e3ea94d90 [skip ci] DB indices created 1-test1.ts
To https://github.com/REDACTED/REDACTED.git
 ! [rejected]            development -> development (non-fast-forward)
error: failed to push some refs to 'https://github.com/REDACTED/REDACTED.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Removing temporary branch 'push-action/1525307555/14689-24028-13227' ...
Removing temporary branch 'push-action/1525307555/14689-24028-13227' ... DONE!

Please ignore my previous message. Github was right, I tried to push from another brach which was behind the protected one. Thanks for such a useful action!


Mongodb & Fastify

I loved this package. I'll be happy If You'd add MongoDB and Fastify support.

Hey,
Sure, do you think you could do a pull-request ?
I should write a CONTRIBUTING.md file and ISSUE_TEMPLATE.md.
Basically you can create a new template by following these steps :

Create a new folder  /templates/ap/<template-name>, where <template-name> you could name it something like fastify-mongodb and put the template files in there.
Then in the /src/constants/templateChoices.ts file, you can edit the templateChoices variable, so you can add a new object in the array of the api key, with name property and the path of the template folder created in step one.
For example it could be something like this :

{
  name: 'Fastify with MongoDB',
  value: {
    path: path.join(TEMPLATE_API_PATH, 'fastify-mongodb')
  }
}

Feel free to discuss there, if there is something you don't understand or questions. 😃
I could work on that, but I never used Fastify. Anyway thank you for your interest and feedback, looking forward to discuss there.

Hello, after publishing the Contributing.md, I'll take this PR and I'll add this feature. Thanks.

I'm adding the js template, because this project I think it should be wider. I'll add the ts version early.

https://github.com/Divlo/create-fullstack-app/pull/7


Fix CircleCI setup script

"-n" no longer works in the "microk8s.ctr" command. It returns this error when running in circleCI: "ctr: Cannot use two forms of the same flag: n namespace"

@jmprusi The other PRs are failing because of this.


OutOfMemoryError

I am trying to train YOLONAS on a 100k dataset of mathematical images. However, upon running the necessary train commands, it errors out giving me the following error:
OutOfMemoryError: CUDA out of memory. Tried to allocate 14.00 MiB (GPU 0; 14.75 GiB total capacity; 13.38 GiB already allocated; 2.81 MiB free; 13.45 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

I already halved the batch_size (as suggested by https://stackoverflow.com/questions/59129812/how-to-avoid-cuda-out-of-memory-in-pytorch) however still the same problem.
To Reproduce
To reproduce this, I just copied over the training colab file called Intro to SuperGradients + YOLONAS Starter Notebook.ipynb into my data-prep file.
Expected behavior
I expected it to start training
Screenshots
Environment:
Google Colab (with GPU)
super-gradients==3.1.0

My guess is that it comes because the coco_detection_yolo_format_train method caches everything which fills up the memory (no idea how to fix)

@frankvp11 Hello (:
Actually, caching is just for the labels, and they are all stored in RAM so CUDA memory shouldn't be affected.
It seems that even though you halved the batch size, it might is still be too large (colab does not have so much GPU memory...).
Can you detail whther this happens toyou during validation or training part?
If it happens in validation, it could be that you also need to modify the validation batch size.

I modifying all the batch sizes to be 2 now (used to be 16) and it's now "stuck" as in hasn't changed in 5 minutes from this:
[2023-05-07 14:44:23] INFO - sg_trainer.py - Using EMA with params {'decay': 0.9, 'decay_type': 'threshold'}
The console stream is now moved to checkpoints/my_first_yolonas_run/console_May07_14_44_23.txt
[2023-05-07 14:44:26] INFO - sg_trainer_utils.py - TRAINING PARAMETERS:
    - Mode:                         Single GPU
    - Number of GPUs:               1          (1 available on the machine)
    - Dataset size:                 85000      (len(train_set))
    - Batch size per GPU:           2          (batch_size)
    - Batch Accumulate:             1          (batch_accumulate)
    - Total batch size:             2          (num_gpus * batch_size)
    - Effective Batch size:         2          (num_gpus * batch_size * batch_accumulate)
    - Iterations per epoch:         42500      (len(train_loader))
    - Gradient updates per epoch:   42500      (len(train_loader) / batch_accumulate)

So it could be that the batch size might still have been to large, however not much is happening right now

First, YOLO-NAS should train just fine with bs=2 on Colab. You can easily verify this by taking starter notebook, and replacing yolo_nas_s to yolo_nas_l. This should train fine with smaller batch size.
Second, since your notebook contains additional imports & training commands using ultralitics - !yolo task=detect mode=train model=yolov8x.yaml data=/content/dataset/data.yaml epochs=5 device=0 it could be still using GPU.
Try removing all unnecessary cells from your notebook that you don't strictly require (E.g any imports of ultralitics,  inference calls !yolo task=detect mode=train).
After you cleaned up the notebook please restart it to ensure you don't have any leftovers in memory and restart the training of YOLO-NAS.

Yes. As I specified in the previous message, you should have read the text boxes. I specifically put text boxes saying which part was for yolo (my initial model) and for yolonas (lower down). If you hadn't run the code between the two text boxes, your previous message wouldn't be applicable. Those imports wouldn't be affecting anything if you hadn't run those.

Any update on this?

Hi @frankvp11 ,
I am really not sure why you would have a problem  batch_size of 2 on yolo_nas_s .
You can try out a few different configurations and see what works/what doesn't. This can help us better understand the root of the problem you are facing.

Run on another dataset (ideally small images) to see if it runs faster
Apply model.predict on some of your images (see doc)
Run the training again and monitor the resources
Test the model (see snippet) and see if it is also slow

trainer.test(
    model=model,
    test_loader=val_data,
    test_metrics_list=[
        DetectionMetrics_050(
            score_thres=0.1,
            top_k_predictions=300,
            # NOTE: num_classes needs to be defined here
            num_cls=len(dataset_params["classes"]),
            normalize_targets=True,
            post_prediction_callback=PPYoloEPostPredictionCallback(score_threshold=0.01, nms_top_k=1000, max_predictions=300, nms_threshold=0.7),
        )
    ],
)

Closing as can't reproduce. Your notebook that you've shared seems to be using Kaggle datasets and require external kaggle.json with access credentials.
You can share the Kaggle notebook that do not require any additional steps to even run the notebook and re-open the issue.


Add a local PHP configuration example

Question
Could you add an example of how to configure now-php to work with now dev? On this page it says "check that PHP executable is added to the PATH environment variable". I'm guessing this means create a .env file and put something like<EMAIL_ADDRESS>in it. Is that right? I tried that and also tried using the path from my .bash_profile, with no luck.

Hi, I prefer starting php app via php -s localhost:8000 (php development server).

Ahh OK, thanks. You do that from the api folder?
(I think that needs to be a capital S btw php -S localhost:8000)

Yup, I was on mobile. xD
php -S localhost:8000 api/index.php (or any other php file).

Using this server, rather than now dev means everything is expected to be inside the api directory, right? If index.php is referencing a CSS file for example. How would you deal with that?

Well, it starts full webserver. All assets are handled properly.
Could you show me your project? I might with.


Fix #17321

The adjacent sibling selector no longer applies to the dropdown toggle when the dropdown is opened and a .dropdown-backdrop element is created. When it no longer applies then the dropdown toggle loses its 8px padding and inherits 1rem padding making it wider.
The general sibling selector will apply regardless of the backdrop element being created.

This is no longer needed after #18807 in Alpha 3. Thanks though!


Handling renaming events better

fixes https://github.com/Shopify/themekit/issues/392
Problem
In Atom and Sublime Text when deleting a file instead of a delete event, a rename happens. The editors rename the file to be in the trash can. Also while testing this it seems that the same would happen when renaming a file. The renamed file would have no content with the original filename and stay existing with the newly named file
Solution
Change rename events to delete files.
This solves renaming because it will delete the first file then create a new file with the new name and content.
Problems
This may cause confusion if a new developer tried deleting or renaming critical files because it will fire a delete action on the critical file and fail. Then it will succeed in creating the new file. Unfortunately I cannot see a way around this.
This has been validated for:

[x] renaming
[x] deleting in sublime
[x] deleting in atom

cc @NathanPJF

An example of a rename event

This solves renaming because it will delete the first file then create a new file with the new name and content.

Love it!
/cc @Shopify/themes-fed

Thank you @tanema !!
You are amazing! 👍

Hey @alvin-ahn, the fix should probably be release in the next week or two.


Add spaces around dashes

Since the site uses monospace by default, an em dash without spaces around it is hard to distinguish from a hyphen, hindering the reading flow. Consider adding spaces around them, either converting them to en dashes (the UK style) or not (the AP style). An alternative is to use two hyphens, as was common in typewriter/pre-Unicode days.

Thanks, I've done this!


How to intergrate GTK with penrose

Hello i creating my window manager and i dont know how to integrate GTK Decorations with Penrose. Please help.

I'll need a little more information on what it is you are trying to achieve to be able to help I'm afraid. For one thing, GTK decorations are all client side so there isn't any involvement from the window manager. As for Penrose providing decorations itself, that is possible in theory but it's not something I've looked at previously.


example is not working

The development server returned response error code: 500
URL: http://<IP_ADDRESS>:8081/index.android.bundle?platform=android&dev=true&hot=false&minify=false
Body:
{"from":"/Users/barron9/Downloads/react-native-youtube-master/YouTube.android.js","to":"react","message":"Unable to resolve module react from /Users/barron9/Downloads/react-native-youtube-master/YouTube.android.js: Module does not exist in the module map\n\nThis might be related to https://github.com/facebook/react-native/issues/4968\nTo resolve try the following:\n  1. Clear watchman watches: watchman watch-del-all.\n  2. Delete the node_modules folder: rm -rf node_modules && npm install.\n  3. Reset packager cache: rm -fr $TMPDIR/react-* or npm start --reset-cache.","name":"UnableToResolveError","type":"UnableToResolveError","errors":[{}]}
onResponse
DevServerHelper.java:332
execute
RealCall.java:126
run
NamedRunnable.java:32
runWorker
ThreadPoolExecutor.java:1162
run
ThreadPoolExecutor.java:636
run
Thread.java:764

That is a React Native problem
I would follow the suggestions in the error message


Could not load npm packages which uses ASYNC AWAIT

Short description of the problem:
We load some npm packages/libs, which are written in javascript, this for example is the lib I'm talking about: https://github.com/Streamedian/html5_rtsp_player/
There are also another bug we resolved by our own and for not it is not included in the github repo.
Anyway the problem is, they are using ASYNC and AWAIT in some of there functions, and this is breaking the app.
As I know this is es6 standard and is not supported so for angular/ionic, so is there a possibility to support it, and if not could this be a feature request? Are there any plans to pass to es6?

For development builds, we do not transpile code down to es5 for performance reasons. It takes too long to do.
For prod builds, we do. Is this getting converted for the prod build?
Typically libraries do not ship es201x code on npm. For example, ionic and angular both ship as es5.
Thanks,
Dan

You are right. But there are some libs which are 3rd part and they don't care about that like angular and ionic does.
What if is so?
The lib is to complicate to convert it manually and using online convert is a solution where he had always problema before.
We are using this lib in dev and production mode. For no we tried to get it work only on dev mode, we need it on dev before we can release it on production.
We also tried to convert it to typescript but also this would be too much work?
Perhapase you could add an feature to configure single file to be transpiled down to es5 also in dev mode?


aubo_i3_moveit_config/config/kinematics.yaml

should change the name manipulator to manipulator_i3,am right?

The name has now been changed to  manipulator_i3

@PeakDing  The name has now been changed to manipulator_i3


feat: updates CLI to use https flag

Closes #801
✅ Checklist

[X] I have followed every step in the contributing guide
[X] The PR title follows the convention.
[X] I ran and tested the code works

Testing
I started my NextJs server using the  --experimental https flag with the  nextjs project in the references folder and the used the -https flag on the CLI and it workded, then I also tested the CLI without the flag on the nextJs server not running https and it also worked.
Changelog
NIL
Screenshots

💯

I'll love your feedbacks on this

Hey ! Can't wait to get this merged onto main branch to finally use it 🙏

Thanks a lot @Chigala, this is great 😄


lib: move internal packages to lib/internal and export ParseDockerURL and annotations

Good things brought by this PR:

Internal functions are clearly separated from the rest
People can use annotations from outside docker2aci
We weren't exporting ParseDockerURL which is used by rkt, fix that

Fixes https://github.com/appc/docker2aci/issues/133

Something to consider before releasing 1.0 in a separate PR - replace the pkg/log with a Logger field in the CommonConfig struct, so users can pass their own logger. The Logger fields would be of some interface type like:
type Logger interface {
    Debug(i ...interface{})
    Info(i ...interface{})
}

so the implementer could implement the Debug function in the same way as currently pkg/log does without resorting to some global boolean variable set by the InitDebug() function. Possibly export two implementation like DefaultLogger with configurable debugging function and DevNullLogger.

Alright, I think I'll put my comment into a separate issue.
LFAD.

Filed #136.

Thanks!


Sanity Check-custom-manufacturing/custom-protein-services

Hi Team,
I have noticed a few observations which are given below. Please look into the below and do the needful.
Reference Links:-
Main:- https://main--aldevron--hlxsites.hlx.page/custom-manufacturing/custom-protein-services
Legacy:- https://www.aldevron.com/service/custom-protein-services
1. Borders issue for the H1 text.
2. Bullet points padding issue
3. Text size issue
4. Form Image alignment issue.
Detailed:-

Borders issue for the H1 text, In the legacy there are no borders for the h1.

Bullet points padding issue, padding is available in the legacy site but not in the Franklin

Text size issue, Please look into the below snap.

Form Image alignment issue, The image in the form is not aligned as expected.

For point 1, vertical bars will be available for all headings upto H3 to make it consistent. This is agreed with client.
Point 3 is fixed.
Point 2 and 4 - callout made to client as technical limitation.

As per the above thread, This is working as expected.


Deploys with no Errors but Properties Unchanged

I installed the plugin and configured. When I deploy I do not get any errors but the auto scaling properties of the tables do not change. I am trying to set auto scaling for two tables and there are no indexes.
I am using the latest version of serverless.  The tables already exist from a previous deploy.
Before attempting to use this plugin, I configured auto scaling manually through the aws console.  I removed my manual configuration before trying to use the plugin.  Maybe something was left behind when I did it manually that is preventing the plugin from working.
Any ideas?

Are the tables part of the CloudFormation resources in your serverless.yml ? The plugin configuration needs the resource identifier and not the table name:
custom:
  capacities:
    - table: CustomTable  # DynamoDB Resource identifier

Can you provide an example serverless.yml configuration ?

Yes.
plugins:
- serverless-dynamodb-autoscaling
custom:
capacities:
- table: subscriptionDetailTable
read:
minimum: 50
maximum: 300
usage: 0.70
write:
minimum: 50
maximum: 300
usage: 0.70
- table: subscriptionPoliciesTable
read:
minimum: 50
maximum: 300
usage: 0.70
write:
minimum: 50
maximum:300
usage: 0.70
resources:
Resources:
subscriptionDetailTable:
Type: AWS::DynamoDB::Table
Properties:
TableName: ${self:service}-subscription-details
AttributeDefinitions:
- AttributeName: subscription_detail_id
AttributeType: S
KeySchema:
- AttributeName: subscription_detail_id
KeyType: HASH
ProvisionedThroughput:
ReadCapacityUnits: 50
WriteCapacityUnits: 50
StreamSpecification:
StreamViewType: KEYS_ONLY
subscriptionPoliciesTable:
  Type: AWS::DynamoDB::Table
  Properties:
    TableName: ${self:service}-subscription-policies
    AttributeDefinitions:
      - AttributeName: subscription_policy_id
        AttributeType: S
    KeySchema:
      - AttributeName: subscription_policy_id
        KeyType: HASH
    ProvisionedThroughput:
      ReadCapacityUnits: 50
      WriteCapacityUnits: 50
    StreamSpecification:
      StreamViewType: NEW_IMAGE

Thanks 👍

Got the same issue.
Creating a fresh new table works, CloudFormation completes successfully, but the table is not configured with auto scaling.
service: test

plugins:
  - serverless-dynamodb-autoscaling

resources:
  Resources:
    TokensTable:
      Type: AWS::DynamoDB::Table
      Properties:
        TableName: Tokens
        AttributeDefinitions:
          - AttributeName: user_id
            AttributeType: S
          - AttributeName: key_id
            AttributeType: S
        KeySchema:
          - AttributeName: user_id
            KeyType: HASH
          - AttributeName: key_id
            KeyType: RANGE
        ProvisionedThroughput:
          ReadCapacityUnits: 1
          WriteCapacityUnits: 1
        TimeToLiveSpecification:
          AttributeName: ttl
          Enabled: TRUE

custom:
  capacities:
    - table: TokensTable
      read:
        minimum: 1
        maximum: 1000
        usage: 0.75
      write:
        minimum: 1
        maximum: 200
        usage: 0.75

The corresponding CloudFormation template is:
{
  "AWSTemplateFormatVersion": "2010-09-09",
  "Description": "The AWS CloudFormation template for this Serverless application",
  "Resources": {
    "ServerlessDeploymentBucket": {
      "Type": "AWS::S3::Bucket"
    },
    "testDynamoDBAutoscaleRoleTokensTableDevUseast1": {
      "DependsOn": [
        "TokensTable"
      ],
      "Properties": {
        "AssumeRolePolicyDocument": {
          "Statement": [
            {
              "Action": "sts:AssumeRole",
              "Effect": "Allow",
              "Principal": {
                "Service": "application-autoscaling.amazonaws.com"
              }
            }
          ],
          "Version": "2012-10-17"
        },
        "Policies": [
          {
            "PolicyDocument": {
              "Statement": [
                {
                  "Action": [
                    "cloudwatch:PutMetricAlarm",
                    "cloudwatch:DescribeAlarms",
                    "cloudwatch:DeleteAlarms",
                    "cloudwatch:GetMetricStatistics",
                    "cloudwatch:SetAlarmState"
                  ],
                  "Effect": "Allow",
                  "Resource": "*"
                },
                {
                  "Action": [
                    "dynamodb:DescribeTable",
                    "dynamodb:UpdateTable"
                  ],
                  "Effect": "Allow",
                  "Resource": {
                    "Fn::Join": [
                      "",
                      [
                        "arn:aws:dynamodb:*:",
                        {
                          "Ref": "AWS::AccountId"
                        },
                        ":table/",
                        {
                          "Ref": "TokensTable"
                        }
                      ]
                    ]
                  }
                }
              ],
              "Version": "2012-10-17"
            },
            "PolicyName": "testDynamoDBAutoscalePolicyTokensTableDevUseast1"
          }
        ],
        "RoleName": "testDynamoDBAutoscaleRoleTokensTableDevUseast1"
      },
      "Type": "AWS::IAM::Role"
    },
    "testTableScalingPolicyReadTokensTableDevUseast1": {
      "DependsOn": [
        "TokensTable",
        "testAutoScalingTargetReadTokensTableDevUseast1"
      ],
      "Properties": {
        "PolicyName": "testTableScalingPolicyReadTokensTableDevUseast1",
        "PolicyType": "TargetTrackingScaling",
        "ScalingTargetId": {
          "Ref": "testAutoScalingTargetReadTokensTableDevUseast1"
        },
        "TargetTrackingScalingPolicyConfiguration": {
          "PredefinedMetricSpecification": {
            "PredefinedMetricType": "DynamoDBReadCapacityUtilization"
          },
          "ScaleInCooldown": 60,
          "ScaleOutCooldown": 60,
          "TargetValue": 75
        }
      },
      "Type": "AWS::ApplicationAutoScaling::ScalingPolicy"
    },
    "testAutoScalingTargetReadTokensTableDevUseast1": {
      "DependsOn": [
        "TokensTable",
        "testDynamoDBAutoscaleRoleTokensTableDevUseast1"
      ],
      "Properties": {
        "MaxCapacity": 1000,
        "MinCapacity": 1,
        "ResourceId": {
          "Fn::Join": [
            "",
            [
              "table/",
              {
                "Ref": "TokensTable"
              }
            ]
          ]
        },
        "RoleARN": {
          "Fn::GetAtt": [
            "testDynamoDBAutoscaleRoleTokensTableDevUseast1",
            "Arn"
          ]
        },
        "ScalableDimension": "dynamodb:table:ReadCapacityUnits",
        "ServiceNamespace": "dynamodb"
      },
      "Type": "AWS::ApplicationAutoScaling::ScalableTarget"
    },
    "testTableScalingPolicyWriteTokensTableDevUseast1": {
      "DependsOn": [
        "TokensTable",
        "testAutoScalingTargetWriteTokensTableDevUseast1"
      ],
      "Properties": {
        "PolicyName": "testTableScalingPolicyWriteTokensTableDevUseast1",
        "PolicyType": "TargetTrackingScaling",
        "ScalingTargetId": {
          "Ref": "testAutoScalingTargetWriteTokensTableDevUseast1"
        },
        "TargetTrackingScalingPolicyConfiguration": {
          "PredefinedMetricSpecification": {
            "PredefinedMetricType": "DynamoDBWriteCapacityUtilization"
          },
          "ScaleInCooldown": 60,
          "ScaleOutCooldown": 60,
          "TargetValue": 75
        }
      },
      "Type": "AWS::ApplicationAutoScaling::ScalingPolicy"
    },
    "testAutoScalingTargetWriteTokensTableDevUseast1": {
      "DependsOn": [
        "TokensTable",
        "testDynamoDBAutoscaleRoleTokensTableDevUseast1"
      ],
      "Properties": {
        "MaxCapacity": 200,
        "MinCapacity": 1,
        "ResourceId": {
          "Fn::Join": [
            "",
            [
              "table/",
              {
                "Ref": "TokensTable"
              }
            ]
          ]
        },
        "RoleARN": {
          "Fn::GetAtt": [
            "testDynamoDBAutoscaleRoleTokensTableDevUseast1",
            "Arn"
          ]
        },
        "ScalableDimension": "dynamodb:table:WriteCapacityUnits",
        "ServiceNamespace": "dynamodb"
      },
      "Type": "AWS::ApplicationAutoScaling::ScalableTarget"
    },
    "TokensTable": {
      "Type": "AWS::DynamoDB::Table",
      "Properties": {
        "TableName": "Tokens",
        "AttributeDefinitions": [
          {
            "AttributeName": "user_id",
            "AttributeType": "S"
          },
          {
            "AttributeName": "key_id",
            "AttributeType": "S"
          }
        ],
        "KeySchema": [
          {
            "AttributeName": "user_id",
            "KeyType": "HASH"
          },
          {
            "AttributeName": "key_id",
            "KeyType": "RANGE"
          }
        ],
        "ProvisionedThroughput": {
          "ReadCapacityUnits": 1,
          "WriteCapacityUnits": 1
        },
        "TimeToLiveSpecification": {
          "AttributeName": "ttl",
          "Enabled": true
        }
      }
    }
  },
  "Outputs": {
    "ServerlessDeploymentBucketName": {
      "Value": {
        "Ref": "ServerlessDeploymentBucket"
      }
    }
  }
}

Deploying a second time enables auto scaling as expected.

Have the same issue. Have any of you found a solution? @sbstjn @pierreis

I have a similar issue, though it worked the first time.
Yes, the very first time I created a table with autoscaling it worked.
But I then removed the entire stack and redeployed. So, to be clear: The DynamoDB tables were completely gone. Nothing left.
After the second deploy, the tables were created, but no autoscaling was selected.
Wondering if some policy or IAM user or role that gets created when you enable autoscaling was still around, and the second deploy has an internal throw when creating that role fails.

I released v0.6.2 with the "fix" introduced in #25 . Does this change anything for you?
Maybe it's a CloudFormation behaviour with default configurations for DynamoDB …

Looks promising.
I can't do a full test right now, but I ran sls package before and after the upgrade, just to compare the CloudFormation templates, and sure enough, the new version at least has configuration in it related to the autoscaling. My previous version had zero autoscaling configuration in it.
I'll be testing it some time this week, but it looks likely to be fixed, at least for me.
Thanks!


FEBS model work flow  scripting

= Description =

Script the work flow tested in #4 in Python.

= Context =

The !BioPreDyn project consists in implementing a work flow for systems biology model analysis. The FEBS model is a very simple enzyme / substrate model (used as an example in [http://www.ncbi.nlm.nih.gov/pubmed/19215296 this paper]) which will be used for prototyping the different tools used in the [wiki:Resources/Modeling/SBModelBuildingCycle model building cycle].
SBML was chosen as the main language for describing models in !BioPreDyn.

= Success criteria =

An executable Python script implementing the systems biology life cycle is released at the end of the task.

= Expected issues =

Medium:
Difficulties in combining system calls of several different tools.
Low:
No functional command line API is available for some tools.

Trac comment by bmoreau on 2014-01-23 10:18:41:
Add a subticket #19.

Imported from trac issue 5.  Created by bmoreau on 2013-05-27T15:30:31, last modified: 2015-01-19T10:59:14

Trac comment by bmoreau on 2014-02-21 10:48:39:
Add a subticket #29.

Trac comment by bmoreau on 2015-01-19 10:56:11:
Remove a subticket #29.

Trac comment by bmoreau on 2015-01-19 10:59:14:
CWI scripts demonstrated the prototype's capabilities to be used as a Python library for scripting systems biology experiments.


Feature match with official driver in radio init

Partially resolves the many issues present due to lack of documentation.
Tested on my own devices and seems to work better than the original implementation.
XREF: #13
CC @trembel @JohannesProgrammiert

Please test if this works for you, I am going to merge to main anyways and we can fix the issues later :)


cargo test builds binaries without panic

If you have panic="abort" set in the dev profile and run cargo test, the binaries (and examples) are built without panic set (assuming you have an integration test which triggers the inclusion of binaries).  This doesn't seem correct to me.
Repro:
cargo new --lib foo
cd foo

cat > src/main.rs <<EOL
extern crate foo;
fn main() { foo::f(); }
EOL

echo "pub fn f() { panic!(\"xxx\"); }" >> src/lib.rs

mkdir tests
touch tests/t1.rs

cat >> Cargo.toml <<EOL
[profile.dev]
panic = "abort"
EOL

cargo test -v
target/debug/foo   # <- NOTE this does not abort!

Fixing this is not entirely simple.  If you build the lib.rs dependency twice (once with panic, once without), then rustdoc (for doctests) will pick up both and fail to run.  The code that collects the libraries to link (in Compilation.libraries) would probably need to be adjusted to collect only the libs that are needed for doctests.
I can tackle this if you'd like.  One idea I had to approach this would be:

Fix doctests to not be over-eager in what it links with:

Ensure a Doctest unit is always created.  (This might be helpful for fixing other bugs, such as cargo test --doc overriding all other command-line options.)
In run_doc_tests, instead of iterating over Compilation.libraries, grab the actual dependencies of the Doctest unit.

Remove the global test flag from BuildConfig.

I also wanted to double-check.  This would result in lib.rs being compiled three times with cargo test when you have panic set (once with panic for bins, once without for tests, and once as a unit-test).  Is that OK?

Yeah this is one of those things I'm not entirely sure about. On one hand this definitely seems like a bug and would possibly be good to fix. On the other hand though it's really subtle and unlikely to really bring up any otherwise existing bugs (and can also increase compile times as we have to compile the library twice).
I think I'd be somewhat tempted to lean towards fixing this though if we can. It may be surprising to users using cargo test to compile everything twice, but there's unfortunately not a lot we can do about that :(


The progress of intergrating neo4j

Hi,
Thank you for your excellent work. I am curious about the progress on integrating Neo4j and also vector databases. If the project is still in its early stages, I would be interested in taking on this task.

Thanks for the interests!
I'm still looking at Neo4j now. Neo4j will be a GraphStorage and requires some efforts.
In the other way, VectorDatabase's integration is relatively easy. For example, in #2 , some of them requires pg-vector as the backend. Maybe you can start with this.
And yes, nano-graphrag is absolutely on its early-stage. Check out our ROADMAP and maybe add some things you find interesting

OK. I will take a try. Thanks.


ES384?

Are there any plans to support the ES algorithms?

Yes, I'm looking to add this soon

@mhsjlw just implemented support in master.
Will publish shortly


generate JavaScript code to access the generated REST service

Example at https://github.com/tlaitinen/yesod-dsl/blob/master/extras/yesod-dsl-extjs4.js . It is easy to customize this for other libraries or frameworks.


Add Danger screenshot

I'd be cool to add a screenshot illustrating the beauty of danger-junit. Something like this:

Thanks - README is now vastly improved. 👍


Bug: Docker Build

Build Docker Failed
When I build the environment for TeXt Theme with docker, I failed to Step 8/10 RUN bundle install. And I want to know how to fix this bug with docker.
Steps to Reproduce

Install Docker on my machine. Ubuntu20.04
docker run --rm -v "$PWD":/usr/src/app -w /usr/src/app ruby:2.6 bundle install
docker-compose -f ./docker/docker-compose.build-image.yml build

When I do step 3, I get into the following trouble.
Step 8/10 : RUN bundle install
 ---> Running in a1b07add330a
/usr/local/lib/ruby/2.7.0/rubygems.rb:277:in `find_spec_for_exe': Could not find 'bundler' (1.17.2) required by your /usr/src/app/Gemfile.lock. (Gem::GemNotFoundException)
To update to the latest version installed on your system, run `bundle update --bundler`.
To install the missing version, run `gem install bundler:1.17.2`
        from /usr/local/lib/ruby/2.7.0/rubygems.rb:296:in `activate_bin_path'
        from /usr/local/bin/bundle:23:in `<main>'
ERROR: Service 'jekyll-text-theme_dev' failed to build: The command '/bin/sh -c bundle install' returned a non-zero code: 1

Same error here.


NAV_CSV data for Anubis and Tuscan?

Is your feature request related to a problem? Please describe.
When working with awpy.data.NAV_CSV, there is data for de_dust2, de_inferno, de_vertigo, and others, but de_anubis and de_tuscan are missing.
Describe the solution you'd like
It would be great if awpy.data.NAV_CSV was extended by data for de_anubis and de_tuscan.

Thanks for finding this. We'll get that in with the next update.

Added in #209


Bug/Crash tooltip with Enchanted Shield with Banner

One of my players enchanted a shield that had an ominous banner pattern applied to it, and at that point kept crashing out of the game. We don't know what the enchant was as mousing over the shield causes the crash.
He was able to drop the shield into a hopper, at which point he remained in game, and when the shield is moused over in the hopper the client of whoever does so crashes.
I'm assuming this is Inspiration caused as this is the only mod referenced in the crash and the reference is to fixShieldTooltip.
Pastebin of crash log: https://pastebin.com/H42iWMsw
We can just avoid enchanting patterned shields so no big issue for us. I just hope the log is helpful.
Have a good day.

Disable the client config option for fixShieldTooltip. If I remember, it's just a whitespace fix. I'll look into properly fixing this when I have more time.

I had the same problem, but it was because I opened a chest with an shield from your mod.... Crashed twice...
crash-2020-12-12_19.11.12-client.txt

Fixed in 1.2.2

Fixed in 1.2.2


Add TimerTrigger to the list of triggers

Signed-off-by: Mustafa Ulu<EMAIL_ADDRESS>

This PR grew out of scope.

Ok. I merged some of them  for the next release.

Thanks. Looking forward for the release.
We are using this plugin to deploy from 100+ jobs. Next release will turn our build monitor green again (all yellow currently).


Set Ropsten node to auto reset every 12 hours...or use geth

Ropsten is currently having some difficulties due to some sort of network attacks or something, which is why we cannot stay in sync.
If this is not solvable by switching to geth, please ghetto-rig it to restart if it's out of sync or every X hours so that it's not completely useless, 100% of the time

couldn't get parity to sync, running geth now. Ropston is fully functional

ignore the trace_call not found error until latest version goes live @tayvano


[mis][ci/test] fix flaky test in tests/test_sharded_state_loader.py

This flaky test is observed in https://buildkite.com/vllm/ci/builds/9517#018ff9e8-1c4b-4fac-b3c5-af50946523d8 . torch.empty tensor can contain NaN values.

FYI: @WoosukKwon this is the investigation result of https://github.com/vllm-project/vllm/pull/5074#issuecomment-2156252454 .


Note, important and warning blockquote

Hello,
It’s a new github flavored markdown feature: https://github.com/orgs/community/discussions/16925 (still in beta).
Is it possible to add this?
Markdown:
> [!NOTE]
> Highlights information that users should take into account, even when skimming.

> [!IMPORTANT]
> Crucial information necessary for users to succeed.

> [!WARNING]
> Critical content demanding immediate user attention due to potential risks.

Rendered:

[!NOTE]
Highlights information that users should take into account, even when skimming.

[!IMPORTANT]
Crucial information necessary for users to succeed.

[!WARNING]
Critical content demanding immediate user attention due to potential risks.

This looks interesting, but probably out of scope of the basic HTML renderer or this crate.
However, it seems a useful feature for the parser, though it will not be included in the 0.10 version and needs more discussion.
Thanks!

This feature is now stable: https://github.blog/changelog/2023-12-14-new-markdown-extension-alerts-provide-distinctive-styling-for-significant-content/

This looks interesting, but probably out of scope of the basic HTML renderer or this crate.

Is it possible to just add a css class to a div, with some tricks it’s possible to have a similar rendering: https://jsfiddle.net/p1ngdavk/

Thanks for the update, but I think this feature will be deferred for the 0.11 release.

I'm happily surprised to see this feature implemented, thank you!
Here the complete CSS: https://jsfiddle.net/rnoLxgqb/

I'm happily surprised to see this feature implemented, thank you!
Here the complete CSS: https://jsfiddle.net/rnoLxgqb/

Do you know what the license is on those SVGs?
I'd like to support this in the pulldown-cmark-based renderer I wrote a few years ago to render single-page documents which is likely to end up merged with something like Zola to become my new blog generator, and I'd like to bundle nice default CSS with it.

Do you know what the license is on those SVGs?

I’m not sure. I copied/pasted the SVG from github.
According to the source of the page, it’s probably

Makes sense.
info-16.svg, light-bulb-16.svg, report-16.svg, alert-16.svg, and stop-16.svg, respectively, from octicons appear to be matches.
Bit of a shame there's no Other(name) variant on BlockQuoteKind though. It could be useful to be able to map things like [!BUG] to blocks using icons like bug-16.svg to render custom stuff such as known-but-not-yet-diagnosed bugs in project user guides.


[BugFix] Fix subpartitions with tablet pruing bug

Why I'm doing:

Table with subpartitions may return empty after LimitPruneTabletsRule rule.

mysql> select count(1) from t1;
+-----------+
| count(1)  |
+-----------+
| 109396015 |
+-----------+
1 row in set (0.36 sec)

mysql> select * from t1 limit 1;
Empty set (0.25 sec)

Bad plan:
mysql> explain verbose select * from t1 limit 1;

|   0:OlapScanNode                                                                                |
|      table: t1, rollup: t1                                                                                |
|      preAggregation: on                                                                                |
|      dict_col=type                                                                                |
|      partitionsRatio=1/1, tabletsRatio=1/0           <-                                                                                |
|      tabletList=12023                                                                                |
|      actualRows=0, avgRowSize=323.28174                                                                                |
|      limit: 1                                                                                |
|      cardinality: 1                                                                                |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
33 rows in set (0.24 sec)

What I'm doing:

Filter out empty partitions from all selected partitions, original selected partition ids may be only parent partition ids if table contains subpartitions, use the real sub partition ids instead.

                // Filter out empty partitions from all selected partitions, original selected partition ids may be
                // only parent partition ids if table contains subpartitions, use the real sub partition ids instead.
                // eg:
                // partition        : 10001 -> (tablet_1)
                //  subpartition1   : 10002 -> (tablet_2)
                //  subpartition2   : 10004 -> (tablet_3)
                // original selected partition id with tablet ids: 10001 -> (tablet_2)
                // after:
                // selected partition ids   : 10002
                // selected tablet ids      : tablet_1
                // total tablets num        : 1
                List<Long> selectedNonEmptyPartitionIds = Lists.newArrayList();

After:
|   0:OlapScanNode                           |
|      table: t1, rollup: t1                 |
|      preAggregation: on                    |
|      partitionsRatio=1/1, tabletsRatio=1/1 |
|      tabletList=23033                      |
|      actualRows=100, avgRowSize=2.0        |
|      limit: 1                              |
|      cardinality: 1                        |
+--------------------------------------------+
32 rows in set (0.01 sec)

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@mergify backport branch-3.2


Middleware redirect infinity loop

I'm using auth route with middleware and when using the below snippet the application going on a infinity loop.
export default function ({ store, redirect, error }) {
  console.log('store.state.authUser',store.state.authUser);
  if (store.state.authUser!=null) {
	  console.log('inside null')
	  redirect('/secret')
  }
}

Login View

Successful Login

When clicking the link

The same route when accessed using direct url its working fine. But not when using
<nuxt-link to="/secret">Super secret page</nuxt-link>
Update:
Also the store.state.authUser is globally accessible across different browser, when using with express.
Express Code below:
let config = require('./nuxt.config.js')

config.dev = !(process.env.NODE_ENV === 'production')

// Init Nuxt.js
const nuxt = new Nuxt(config)

// Build only in dev mode
if (config.dev) {
  const builder = new Builder(nuxt)
  builder.build()
}
// Give nuxt middleware to express
app.use(nuxt)

Please download the complete sample project which has the re-producible scenario.
I hope this will help identify the issue in detail.
I was trying to make JWT works with Cookie both server and client.
Below is the list of prerequisites used in this sample project

Mongoose
Express
jsonwebtoken
express-jwt
@nuxtjs/axios
config
vue-cookie
@nuxtjs/router

Download Sample Project Here

Check current route in middlewares before redirect. This can only be a infinite loop as it will redirect to secret over and over

@uptownhr how about the Vuex data issue? that seem to be a major blocker to Nuxt.js

Guys... Am also facing same  issue on nuxt.js,
Please do a look into it....,

Is your store being set on the nuxtserverinit?

Yes indeed..
async nuxtServerInit({ commit, dispatch }, { req }) {
  if (req.cookies && req.cookies.token) {
    await commit('SET_USER', req.cookies.token)
  }
}

Shouldn't i do that ???

I am also facing the same issue. It is stopping me to kickstart my project using nuxt

@fahidmohammad
You need to wrap the login for avoiding state sharing in node cache. Such as:
store/index.js
import Vue from 'vue'
import Vuex from 'vuex'
import login from './modules/login'

Vue.use(Vuex)

const store = () => new Vuex.Store({
  ...login()
})

export default store

store/modules/login.js
/* eslint-disable */
import axios from 'axios'
import cookie from 'vue-cookie'

const login = () => ({
  state: {
    signupEnable: true,
    signinEnable: false,
    token: null
  },
  mutations: {
    SET_USER: function (state, token) {
      /* ... */
    }
  },
  actions: {
    async nuxtServerInit({ commit, dispatch }, { req }) {
      /* ... */
    },
    /* ... */
    async ACTION_LOGOUT({ commit, state }) {
      await commit('SET_USER', null)
    }
  },
  getters: {}
})

export default login

Thank you so much @clarkdo for the heads, your approach solved the issue with the  Vuex issue 👍
And Thank you @uptownhr for the redirection solution 👍