[openssl] Build error

Package: openssl:x64-linux -> 1.0.2j
Host Environment

Host: x64-linux
Compiler: GNU 7.4.0
vcpkg-tool version: 2023-08-09-9990a4c9026811a312cb2af78bf77f3d9d288416
vcpkg-scripts version: 9edb1b8e5 2023-08-14 (9 months ago)

To Reproduce
vcpkg install
Failure logs
CMake Warning at /home/jenkins/vcpkg/scripts/cmake/vcpkg_common_functions.cmake:3 (message):
  vcpkg_common_functions has been removed and all values are automatically
  provided in all portfile.cmake invocations.  Please remove
  `include(vcpkg_common_functions)`.
Call Stack (most recent call first):
  /home/jenkins/vcpkg/buildtrees/versioning_/versions/openssl/f18f7a91cacba1703f571e5c0a06c0f6b0d2a13f/portfile.cmake:6 (include)
  /home/jenkins/vcpkg/scripts/ports.cmake:147 (include)

-- Downloading https://www.openssl.org/source/openssl-1.0.2j.tar.gz -> openssl-1.0.2j.tar.gz...
-- Configuring x64-linux-rel
CMake Error at /home/jenkins/vcpkg/scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /var/opt/teradata/jenkins/cmake-3.27.6-linux-x86_64/bin/cmake /home/jenkins/vcpkg/buildtrees/openssl/src/openssl-1.0.2j -G "NMake Makefiles" -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/home/jenkins/vcpkg/packages/openssl_x64-linux -DCURRENT_INSTALLED_DIR=/home/jenkins/google-cloud-cpp/cmake-out/vcpkg_installed/x64-linux -DCURRENT_PACKAGES_DIR=/home/jenkins/vcpkg/packages/openssl_x64-linux -DCURRENT_BUILDTREES_DIR=/home/jenkins/vcpkg/buildtrees/openssl -DOPENSSL_SOURCE_ARCHIVE=/home/jenkins/vcpkg/downloads/openssl-1.0.2j.tar.gz -DCMAKE_MODULE_PATH=/home/jenkins/vcpkg/scripts/cmake -DTRIPLET_SYSTEM_ARCH=x64 -DVERSION=1.0.2j -DTARGET_TRIPLET=x64-linux -DCMAKE_SYSTEM_NAME=Linux -DBUILD_SHARED_LIBS=OFF -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/home/jenkins/vcpkg/scripts/toolchains/linux.cmake -DVCPKG_TARGET_TRIPLET=x64-linux -DVCPKG_SET_CHARSET_FLAG=ON -DVCPKG_PLATFORM_TOOLSET=external -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DVCPKG_APPLOCAL_DEPS=OFF -DCMAKE_TOOLCHAIN_FILE=/home/jenkins/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -DVCPKG_CXX_FLAGS= -DVCPKG_CXX_FLAGS_RELEASE= -DVCPKG_CXX_FLAGS_DEBUG= -DVCPKG_C_FLAGS= -DVCPKG_C_FLAGS_RELEASE= -DVCPKG_C_FLAGS_DEBUG= -DVCPKG_CRT_LINKAGE=dynamic -DVCPKG_LINKER_FLAGS= -DVCPKG_LINKER_FLAGS_RELEASE= -DVCPKG_LINKER_FLAGS_DEBUG= -DVCPKG_TARGET_ARCHITECTURE=x64 -DCMAKE_INSTALL_LIBDIR:STRING=lib -DCMAKE_INSTALL_BINDIR:STRING=bin -D_VCPKG_ROOT_DIR=/home/jenkins/vcpkg -DZ_VCPKG_ROOT_DIR=/home/jenkins/vcpkg -D_VCPKG_INSTALLED_DIR=/home/jenkins/google-cloud-cpp/cmake-out/vcpkg_installed -DVCPKG_MANIFEST_INSTALL=OFF
    Working Directory: /home/jenkins/vcpkg/buildtrees/openssl/x64-linux-rel
    Error code: 1
    See logs for more information:
      /home/jenkins/vcpkg/buildtrees/openssl/config-x64-linux-rel-err.log

Call Stack (most recent call first):
  /home/jenkins/vcpkg/scripts/cmake/vcpkg_configure_cmake.cmake:344 (vcpkg_execute_required_process)
  /home/jenkins/vcpkg/buildtrees/versioning_/versions/openssl/f18f7a91cacba1703f571e5c0a06c0f6b0d2a13f/portfile.cmake:27 (vcpkg_configure_cmake)
  /home/jenkins/vcpkg/scripts/ports.cmake:147 (include)

/home/jenkins/vcpkg/buildtrees/openssl/config-x64-linux-rel-err.log
CMake Error: Could not create named generator NMake Makefiles

Generators
  Green Hills MULTI            = Generates Green Hills MULTI files
                                 (experimental, work-in-progress).
* Unix Makefiles               = Generates standard UNIX makefiles.
  Ninja                        = Generates build.ninja files.
  Ninja Multi-Config           = Generates build-<Config>.ninja files.
  Watcom WMake                 = Generates Watcom WMake makefiles.
  CodeBlocks - Ninja           = Generates CodeBlocks project files
                                 (deprecated).
  CodeBlocks - Unix Makefiles  = Generates CodeBlocks project files
                                 (deprecated).
  CodeLite - Ninja             = Generates CodeLite project files
                                 (deprecated).
  CodeLite - Unix Makefiles    = Generates CodeLite project files
                                 (deprecated).
  Eclipse CDT4 - Ninja         = Generates Eclipse CDT 4.0 project files
                                 (deprecated).
  Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files
                                 (deprecated).
  Kate - Ninja                 = Generates Kate project files (deprecated).
  Kate - Ninja Multi-Config    = Generates Kate project files (deprecated).
  Kate - Unix Makefiles        = Generates Kate project files (deprecated).
  Sublime Text 2 - Ninja       = Generates Sublime Text 2 project files
                                 (deprecated).
  Sublime Text 2 - Unix Makefiles
                               = Generates Sublime Text 2 project files
                                 (deprecated).

**Additional context**
vcpkg.json
{
  "name": "google-cloud-cpp-development",
  "version": "2.18.0",
  "description": "Describes the vcpkg dependencies for vcpkg development.",
  "homepage": "https://github.com/googleapis/google-cloud-cpp",
  "license": "Apache-2.0",
  "supports": "!uwp",
  "dependencies": [
    "abseil",
    "crc32c",
    {
      "name": "curl",
      "features": [
        "ssl"
      ]
    },
    {
      "$description": "If cross-compiling, we need the gRPC protoc plugin on the 'host' environment.",
      "name": "grpc",
      "host": true
    },
    {
      "$description": "If cross-compiling, we need the protoc compiler on the 'host' environment.",
      "name": "protobuf",
      "host": true
    },
    "grpc",
    "protobuf",
    "nlohmann-json",
    "benchmark",
    "gtest",
    {
      "$description": "Only used for the opentelemetry feature.",
      "name": "opentelemetry-cpp"
    },
    {
      "$description": "Only used for the docfx feature.",
      "name": "pugixml"
    },
    {
      "$description": "Only used for the docfx feature.",
      "name": "yaml-cpp"
    }
  ],
  "builtin-baseline": "9edb1b8e590cc086563301d735cae4b6e732d2d2",
  "overrides": [
    {
      "name": "openssl",
      "version-string": "1.0.2j"
    },
    {
      "name": "curl",
      "version": "8.2.1"
    }
  ]
}

Package: openssl:x64-linux -> 1.0.2j

Outdated, won't be fixed.

vcpkg-tool version: 2023-08-09-9990a4c9026811a312cb2af78bf77f3d9d288416
vcpkg-scripts version: 9edb1b8 2023-08-14 (9 months ago)

Outdated, won't be fixed.
Why are people flooding vcpkg with outdated stuff ATM? A teacher providing outdated materials?

It might be outdated, but it's still supported by google cloud cpp
https://github.com/googleapis/google-cloud-cpp/blob/main/doc/packaging.md#required-libraries

You might be able to build old versions of openssl with an up-to-date vcpkg, using manifest mode. That's what versioning exists for. However, you leave the area of tested configurations, and you don't get fixes for old port versions from this registry.

Can you point me to how I can do this?

https://learn.microsoft.com/en-us/vcpkg/consume/lock-package-versions

This  was what were done above using the "overrides" list in the vcpkg.json.
"overrides": [
{
"name": "openssl",
"version-string": "1.0.2j"
},
{
"name": "curl",
"version": "8.2.1"
}
]
After it downloaded the openssl version then it failed cmake
-- Downloading https://www.openssl.org/source/openssl-1.0.2j.tar.gz -> openssl-1.0.2j.tar.gz...
-- Configuring x64-linux-rel
CMake Error at /home/jenkins/vcpkg/scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
Command failed: /var/opt/teradata/jenkins/cmake-3.27.6-linux-x86_64/bin/cmake /home/jenkins/vcpkg/buildtrees/openssl/src/openssl-1.0.2j -G "NMake Makefiles" -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/home/jenkins/vcpkg/packages/openssl_x64-linux -DCURRENT_INSTALLED_DIR=/home/jenkins/google-cloud-cpp/cmake-out/vcpkg_installed/x64-linux -DCURRENT_PACKAGES_DIR=/home/jenkins/vcpkg/packages/openssl_x64-linux -DCURRENT_BUILDTREES_DIR=/home/jenkins/vcpkg/buildtrees/openssl -DOPENSSL_SOURCE_ARCHIVE=/home/jenkins/vcpkg/downloads/openssl-1.0.2j.tar.gz -DCMAKE_MODULE_PATH=/home/jenkins/vcpkg/scripts/cmake -DTRIPLET_SYSTEM_ARCH=x64 -DVERSION=1.0.2j -DTARGET_TRIPLET=x64-linux -DCMAKE_SYSTEM_NAME=Linux -DBUILD_SHARED_LIBS=OFF -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/home/jenkins/vcpkg/scripts/toolchains/linux.cmake -DVCPKG_TARGET_TRIPLET=x64-linux -DVCPKG_SET_CHARSET_FLAG=ON -DVCPKG_PLATFORM_TOOLSET=external -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DVCPKG_APPLOCAL_DEPS=OFF -DCMAKE_TOOLCHAIN_FILE=/home/jenkins/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -DVCPKG_CXX_FLAGS= -DVCPKG_CXX_FLAGS_RELEASE= -DVCPKG_CXX_FLAGS_DEBUG= -DVCPKG_C_FLAGS= -DVCPKG_C_FLAGS_RELEASE= -DVCPKG_C_FLAGS_DEBUG= -DVCPKG_CRT_LINKAGE=dynamic -DVCPKG_LINKER_FLAGS= -DVCPKG_LINKER_FLAGS_RELEASE= -DVCPKG_LINKER_FLAGS_DEBUG= -DVCPKG_TARGET_ARCHITECTURE=x64 -DCMAKE_INSTALL_LIBDIR:STRING=lib -DCMAKE_INSTALL_BINDIR:STRING=bin -D_VCPKG_ROOT_DIR=/home/jenkins/vcpkg -DZ_VCPKG_ROOT_DIR=/home/jenkins/vcpkg -D_VCPKG_INSTALLED_DIR=/home/jenkins/google-cloud-cpp/cmake-out/vcpkg_installed -DVCPKG_MANIFEST_INSTALL=OFF
Working Directory: /home/jenkins/vcpkg/buildtrees/openssl/x64-linux-rel
Error code: 1
See logs for more information:
/home/jenkins/vcpkg/buildtrees/openssl/config-x64-linux-rel-err.log
CMake Error: Could not create named generator NMake Makefiles
Generators
Green Hills MULTI            = Generates Green Hills MULTI files
(experimental, work-in-progress).

Unix Makefiles               = Generates standard UNIX makefiles.
Ninja                        = Generates build.ninja files.
Ninja Multi-Config           = Generates build-.ninja files.
Watcom WMake                 = Generates Watcom WMake makefiles.
CodeBlocks - Ninja           = Generates CodeBlocks project files
(deprecated).
CodeBlocks - Unix Makefiles  = Generates CodeBlocks project files
(deprecated).
CodeLite - Ninja             = Generates CodeLite project files
(deprecated).
CodeLite - Unix Makefiles    = Generates CodeLite project files
(deprecated).
Eclipse CDT4 - Ninja         = Generates Eclipse CDT 4.0 project files
(deprecated).
Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files
(deprecated).
Kate - Ninja                 = Generates Kate project files (deprecated).
Kate - Ninja Multi-Config    = Generates Kate project files (deprecated).
Kate - Unix Makefiles        = Generates Kate project files (deprecated).
Sublime Text 2 - Ninja       = Generates Sublime Text 2 project files
(deprecated).
Sublime Text 2 - Unix Makefiles
= Generates Sublime Text 2 project files
(deprecated).

Linux doesn't need the "NMake Makefiles" generator.
And nobody cares about a port version from 2016, in particular in a security-sensitive area.
(Maybe you need to use port "openssl-unix" if you really want stone age.)

This issue hasn’t been updated for a long time; if it is still an issue, please ping me and I will reopen this issue.


Build order issue with RCL static assets and TSC generated JS files in wwwroot

If you believe you have an issue that affects the security of the platform please do NOT create an issue and instead email your issue details to<EMAIL_ADDRESS>Your report may be eligible for our bug bounty but ONLY if it is reported through email.
Describe the bug
A build of a Razor Class Library that has static assets in wwwroot may or may not include a JS file that is generated from a Typescript source.
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core '3.0P7'
Create a RazorClassLib
Add the current Microsoft.Typescript.MSBuild nuget package to the project
Place a TS file in wwwroot
Build the library
There are 3 individuals with identical repositories (@chrissainty, @sql-mistermagoo, and @markStega). On two of the three environments the DLL does not contain the JS content. On the third it does. We have a work-around in place that adds an explicit embedded resource by name in the fashion of a BlazorLib project. The repository is found at https://github.com/Blazored/LocalStorage

Expected behavior
I expect the build to be consistent from one developer system to the next given the same version of VS, .NetCore, etc.
Screenshots
n/a.
Additional context
VS 16.3.0 Preview 1.0
C:\Solutions\TemporarySolutions\Typeahead>dotnet --info
.NET Core SDK (reflecting any global.json):
Version:   3.0.100-preview7-012821
Commit:    6348f1068a
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.18362
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview7-012821\
Host (useful for support):
Version: 3.0.0-preview7-27912-14
Commit:  4da6ee6450
.NET Core SDKs installed:
2.1.701 [C:\Program Files\dotnet\sdk]
2.1.800 [C:\Program Files\dotnet\sdk]
2.1.801 [C:\Program Files\dotnet\sdk]
2.2.301 [C:\Program Files\dotnet\sdk]
2.2.400 [C:\Program Files\dotnet\sdk]
2.2.401 [C:\Program Files\dotnet\sdk]
3.0.100-preview7-012821 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.0-preview7.19365.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.0-preview7-27912-14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.0.0-preview7-27912-14 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download
C:\Solutions\TemporarySolutions\Typeahead>

Thanks for contacting us, @MarkStega .
This is quite interesting and unexpected. @javiercn can you please look into this? Thanks!

@MarkStega Could you clarify something real quick?
Seems like you are referring to the old blazor support for static assets (which embedded them into the assembly) we are moving from that model to the new model where the static assets are just part of the package as content.
Which one are you using?

We are trying to use the new model without the ItemGroup with EmbeddedResources being called out (If you look at the repository the csproj for LocalStorage has those, that is the workaround for the build issue). The problem occurs when that ItemGroup is removed and we are trying to build the dll as a 'new style' RCL.

Ok, just to be clear.
We don't/won't be supporting embedded resources going forward. The content is just a file that we include in the package under staticwebassets and that we copy to the output folder of consuming apps during publish.
Apps need to manually reference the file in their HTML/Razor file through a script tag with src="_content/{libraryname}/{filepathunderwwwroot}.
Provided those things, it might be that the TS compilation happens after we compute the static web assets. You can add the following to your project to force typescript compilation to happen before we compute the static web assets.
  <PropertyGroup>
    <ResolveStaticWebAssetsInputsDependsOn>
      CompileTypeScript;
      $(ResolveStaticWebAssetsInputsDependsOn)
    </ResolveStaticWebAssetsInputsDependsOn>
  </PropertyGroup>

I haven't seen this be an issue while packing the project, but I filed an issue for further improvements. My current recommendation is that you use the snippet above and avoid putting the ts file directly in the wwwroot and instead, set the ts output folder to wwwroot.
Closing this as there's no further action to be performed here.
https://github.com/aspnet/AspNetCore/issues/12727 for the mentioned improvements.

I added the suggested snippet and now the build fails:
Severity	Code	Description	Project	File	Line	Suppression State Error	CS0006	Metadata file 'C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\bin\Debug\netstandard2.0\Blazored.LocalStorage.dll' could not be found	BlazorClientSide	C:\Solutions\OHI\LocalStorage\samples\BlazorClientSide\CSC	1	Active Error	TS1005	Build:'(' expected.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	30	 Error	TS1005	Build:'(' expected.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	31	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	31	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Trynpm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	32	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	32	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	32	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	33	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	34	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	35	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	36	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	37	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	37	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	37	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	38	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	39	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	40	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	41	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	42	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	42	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	42	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	43	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	44	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	45	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	46	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	47	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	47	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	47	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	48	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	49	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	50	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	51	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	52	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	52	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	52	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	53	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	54	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	55	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	56	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	57	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	57	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	57	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	58	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	59	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	60	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	61	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	62	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	62	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	62	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	63	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	64	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	65	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	66	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	67	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	67	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	67	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	68	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	69	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	70	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	71	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	72	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	72	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	72	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	73	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	74	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	75	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	76	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	77	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	77	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	77	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	78	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	79	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	80	 Error	TS2304	Build:Cannot find name 'CompileTypeScript'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	81	 Error	TS2581	Build:Cannot find name '$'. Do you need to install type definitions for jQuery? Try npm i @types/jquery.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	82	 Error	TS2365	Build:Operator '<' cannot be applied to types 'boolean' and 'RegExp'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	82	 Error	TS2304	Build:Cannot find name 'ResolveStaticWebAssetsInputsDependsOn'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	82	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	83	 Error	TS1161	Build:Unterminated regular expression literal.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	84	 Error	TS2693	Build:'any' only refers to a type, but is being used as a value here.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	86	 Error	TS2741	Build:Property 'LocalStorage' is missing in type '{}' but required in type 'typeof Blazored'.	Blazored.LocalStorage	C:\Solutions\OHI\LocalStorage\src\Blazored.LocalStorage\wwwroot\blazored-localstorage.ts	96

If I move the TS file out of wwwroot and add this to the project file
  <PropertyGroup>
    <TypeScriptOutDir>wwwroot</TypeScriptOutDir>
  </PropertyGroup>

I indeed have the wwwroot directory created during the build and the JS file within. The bad news is that the fancy ResolveStaticWebAssetsInputsDependsOn no longer works and the JS is no longer included in the DLL.

That's likely because you need a target to declare the embedded file that happens after the typescript build.

I have a blazorlib project and a blazor client-side project consuming it. In the blazorlib I

removed the "old" EmbeddedResouces ItemGroups
renamed the content folder to wwwroot
created a msbuild target that calls webpack creating a js file in the wwwroot folder
added the ResolveStaticWebAssetsInputsDependsOn calling the webpack target
manually added the script tag to the index.html file

The application runs and the nupkg contains the staticwebassets folder with my js file.
The problem I'm having now is publishing the client-side project: the _content folder is missing. Is it intended to be added automatically or should I configure something?

That's likely because you need a target to declare the embedded file that happens after the typescript build.

But I thought that was the point of the 'ResolveStaticAssetsDependOn'? Are you saying I have to explicitly have another msbuild target?


Feat/add new lambda input variables

what

Add two new input variables for tuning lambda configuration

lambda_memory_size
lambda_timeout

why

in high throughput condition, current default values may not be enough
for instance, in a context of heavily used AWS Cloudtrail log forwarding
current values of timeout (3 seconds only) and, in some cases, memory size (128MB) can lead to invocation errors with loss of logs (meaning no log sent to Datadog)

references

Datadog's CloudFormation template show default recommended values:

https://datadog-cloudformation-template.s3.amazonaws.com/aws/forwarder/latest.yaml

These values are:

1024 MB for memory size (which is huge and probably overkill)
120 seconds for timeout (which helps a lot to reduces the problem describe in this PR)

/test all


Optionally depend on TensorFlow through bazel.

Upgrades to TF 1.12-rc2. Do I need to change other bits for this?
Simplifies and checks configuration, makes it safer to share dependencies with TensorFlow.
It requires a bit of Starlark magic to offer both pre-building TensorFlow as well as depending on it through bazel.
This PR affects cc/... only, i.e. the python code still uses the installed TensorFlow.

Upgrades to TF 1.12-rc2. Do I need to change other bits for this?
It would also have required bazel 1.18. Too many moving parts. I reworked it to support TF 1.11 and bazel 1.17 as before.

It's great that using TF as an external dependency works now, but can you explain the motivation for this PR please?
We are well aware of the short comings of cc/configure_tensorflow.sh, however I think I've clearly explained our motivation for having it to you before: If I'm a user with a 4 core machine, and I want to change some build flags for whatever reason (debugging, profiling, enabling optimizations), I don't want to have to wait for literally hours for Bazel to recompile TensorFlow.
In an ideal world, optionally using Bazel to build TensorFlow would be great. However, this PR demonstrably adds a significant maintenance burden: it breaks our current test infrastructure and apparently makes it harder to upgrade TF versions. Before we take on the burden for a feature that we haven't historically needed, I'd like to understand whether the benefits outweigh the costs.

Andrew pointed out that it wasn't clear from the PR description that you can prebuild TF just like before ("offer both pre-building TensorFlow as well as depending on it through bazel").
You run cc/configure_tensorflow.sh as before to configure TF.  TensorFlow is built with -c opt and tucked away under cc/tensorflow and bazel will pick it from there and not ever build it again until you run configure_tensorflow.sh again.

The fact that you initially attempted to upgrade to TF 1.12 in this PR and then gave up suggested that it does in fact make upgrading TF versions harder but I don't know what problems you ran into, so I was just inferring from your own PR comments.
I understand that this is a optional alternative to cc/configure_tensorflow. That's the thrust of my objection to the PR: it creates additional maintenance burden. The next time we want to upgrade to a later version of TF, we'll have to test both methods of building TF and fix the problems that inevitably show up twice.
Andrew told me you had some concerns about potential ODR violations, which I agree could be a problem. However, we've never seen any symptoms of an ODR violation and as Titus pointed out in his recent keynote at Pacific++, every C++ codebase that use prebuilt libraries has the same problem.
If we had infinite time & resources, I'd happily accept this PR but we don't. So I shall ask again: before we accept the extra maintenance burden associated with this PR, can you please explain what problems it solves?

It's not that I gave up, I wanted to avoid having to upgrade to TF 1.12. It would have made this change easier because TF 1.12 is easier to configure from an inverse dependency. Same for updating to bazel 0.18. With some extra work this change can stay with TF 1.11 but it does require bazel 0.15, I think. I've only been able to test with 0.17 locally. I haven't figured out what bazel versions are installed in the images. The documentation for C++ Minigo says it requires bazel 0.17, but I think the test image uses an older version.
Maintenance burden: configure_tensorflow.sh builds exactly what would otherwise be the TF dependency. In other words, if you test the prebuilt path and keep it working, the bazel dependency path is covered as well.
ODR violations: google3 and others have this issue, yes. Bazel effectively avoids different versions of common dependencies, which is just one thing that can go wrong. But it clearly doesn't hurt to have that covered.
Benefits:

Only build the parts of TensorFlow needed for C++ MiniGo, not the entire wheel. tensorflow_configure.sh takes 11min 42sec instead of 20min on my machine.
No need to prebuild toco.
Fixes incomplete headers when not building TF with CUDA.
Adding the grpc dependency is cleaner. A similar dependency will be needed to enable XLA:GPU.
Reuses TF configuration of CUDA and TensorRT.
Once we have BUILD files for the python code as well, there is no need to pip install TF (in a virtual env or docker), and you can run directly from IDEs with bazel integration like CLion.
It works with bazel 0.19 which is the current and only version on rodete. Of course, fixing master is a much smaller change.

Thanks for the explanation, that makes a lot of sense. In general, that's the kind of information that would be good to put in the change description: while these issues may be obvious to you, I wasn't aware of them.
Given that motivation, I'm on board with adding this PR. Any idea when TF will add support for CloudTPU to a release? I'd like to remove cc/configure_tensorflow.sh if we're going with this approach.
That said, I cloned your fork and tried building and it failed:
$ bazel build cc:main
DEBUG: /usr/local/google/home/tmadams/.cache/bazel/_bazel_tmadams/396ac1642031eaf41fabab3b3dfaf61c/external/bazel_tools/tools/build_defs/repo/http.bzl:46:9: patch file //cc/tensorflow:tensorflow.patch, path /usr/local/google/home/tmadams/chsigg_minigo/cc/tensorflow/tensorflow.patch
ERROR: /usr/local/google/home/tmadams/chsigg_minigo/cc/BUILD:88:1: no such target '@com_google_absl//absl/container:flat_hash_map': target 'flat_hash_map' not declared in package 'absl/container' defined by /usr/local/google/home/tmadams/.cache/bazel/_bazel_tmadams/396ac1642031eaf41fabab3b3dfaf61c/external/com_google_absl/absl/container/BUILD.bazel and referenced by '//cc:mcts'
ERROR: /usr/local/google/home/tmadams/chsigg_minigo/cc/BUILD:88:1: no such target '@com_google_absl//absl/container:flat_hash_set': target 'flat_hash_set' not declared in package 'absl/container' defined by /usr/local/google/home/tmadams/.cache/bazel/_bazel_tmadams/396ac1642031eaf41fabab3b3dfaf61c/external/com_google_absl/absl/container/BUILD.bazel and referenced by '//cc:mcts'
ERROR: Analysis of target '//cc:main' failed; build aborted: Analysis failed

Looks like TF v1.11 uses an old version of ABSL that doesn't contain flat_hash_map or flat_hash_set. Do you know if v1.12 is updated?

I don't want to interfere with the discussion whether we actually want this PR, but just lay out the plan to fix the test failure. The PR now builds with bazel 0.11, but the testing procedure still needs some changes. Specifically, it should call cc/configure_tensorflow.sh first, and the cp command to pull in the pre-built TF needs to change slightly. I could work around both by adding a default TF configuration file and using the same directory structure in cc/tensorflow, but this seems the cleaner approach:

Copy C++ test script from test-infra to this repo (something like https://github.com/chsigg/minigo-fork/commit/62b9da7174fe3b907316662f24897fa9025c2abb)
Change https://github.com/kubernetes/test-infra/blob/master/config/jobs/tensorflow/minigo/minigo.yaml to call the new script.
Change the script as part of this PR to run tensorflow_configure.sh and update the cp command.

/retest

\retest


It is missing to show how to update path params in ServiceUrl (e.g. https://my_url/{my_param}) if we have POST request and SendClaimsIn -> Body

How to resolve the path param (objectId) in ServiceUrl if I have the following example:

REST API call to communicate with Legacy IdP

https://my_host_address/{objectId}
Body
POST
True
ApiKeyHeader
application/x-www-form-urlencoded
true

After executing this profile I got: POST https://my_host_address/{objectId}, without resolving a value for objectId
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6dff7a38-a459-4eb9-22fe-d225eeac5e34
Version Independent ID: c3e92211-d07e-edec-3a08-eb68a26859bb
Content: Define a RESTful technical profile in a custom policy - Azure AD B2C
Content Source: articles/active-directory-b2c/restful-technical-profile.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@askovic
Thanks for your feedback! We will investigate and update as appropriate.

@askovic
I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1)
Thank you for your time and patience throughout this issue.


Maven Debug [DO NOT MERGE]

Checklist:

[x] Read the Code of Conduct and Contributing Guidelines.

[x] Followed the commit message guidelines.

Updates to the collections
Changes to gather information from maven during travis build.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@BarDweller Do we still need this PR?

Have there been any more incidents of the weird maven build error ?


Problem with tests and vue-router throwing warnings

While running the tests, I'm getting a warning, followed by a stack trace:
[Vue warn]: Error in render function: "TypeError: undefined is not an object (evaluating 'router.resolve')"

found in

---> <RouterLink>
       <Root>'

to reproduce this you can simply
vue init webpack project-name
pressing enter for all of the prompts
then, in Hello.vue, append this li to the first ul:

<router-link :to="{'name': 'foo'}">foo</router-link>

then, npm run test and you should see a vue warning and a stack trace printed out.
I can push up a functioning repro if needed but I thought this was simple enough.

So I guess this happens because there is no router object on the vue instance, which is injected in main.js. However, that file is not in the test-context. Did you find a way around it yet @doman412?

I too getting same warning, please help me to figure it out.

Also getting this.

Hi,
Perhaps importing the router component will help here?
Here's what I tried:
In Hello.vue:

<router-link :to="{'name': ''}">foo</router-link>

And Hello.spec.js
import Vue from 'vue'
import Hello from '@/components/Hello'
import router from '@/router'

describe('Hello.vue', () => {
  it('should render correct contents', () => {
    const Constructor = Vue.extend(Hello)
    const vm = new Constructor({router}).$mount()
    expect(vm.$el.querySelector('.hello h1').textContent)
      .to.equal('Welcome to Your Vue.js App')
  })
})

Here is the link for more details: https://forum-archive.vuejs.org/topic/3929/how-to-unit-test-a-router-hook
I'm still a beginner at Vue.js, so take all this with a grain of salt.

I've managed to resolve the warning, I'm not 100% sure why this works as inside the router it's already calling Vue.use(VueRouter) although maybe it's due to extending rather than newing inside the tests. Either way, after importing BOTH router and Vue Router, the sample test below ran for me fine.
  it('Renders correct subtitle', () => {
    Vue.use(VueRouter)
    const Constructor = Vue.extend(FullPageHero)
    const vm = new Constructor({
      router,
      propsData: {
        title: '',
        subtitle: 'TEST'
      }
    }).$mount()
    expect(vm.$el.querySelector('.subtitle').textContent.trim())
      .to.equal('TEST')
  })

If you're using the vue-test-utils package (in beta at time of writing), their suggestion is to "create a localVue, and install Vue Router on that":
import { createLocalVue } from 'vue-test-utils'
import VueRouter from 'vue-router'
const localVue = createLocalVue()

localVue.use(VueRouter)

shallow(Component, {
  localVue
})

or to stub the router-link component
import { shallow } from 'vue-test-utils'

shallow(Component, {
  stubs: ['router-link']
})

We will re-write the testing story soon, vue-test-utils will be added to this template and we will switch the test runner to jest.
I will close this for now, But rest assured that the upcoming changes will cover this better.


Adding contract calls to the frontend

This PR adds the following features to the frontend

replace web3 with ether.js #34
Fetch tokens owned by the connected user from developer dao's mainnet contract
Call the method mintWithDevDaoToken() after pressing the claim butten (WIP)

Hey @AlexNi245, I think you used npm instead of yarn and added package-lock files as the result. Can you remove the lock files and use yarn from now on?

Can't see & hence claim my token both on Rinkbey and mainnet.

Can't see & hence claim my token both on Rinkbey and mainnet.

You'll need to mint some tokens from the DevDao rinkeby contract first. https://rinkeby.etherscan.io/token/0x25ed58c027921E14D86380eA2646E3a1B5C55A8b#writeContract

Thanks @etherinsight. Was able to mint one smoothly. Nice work @AlexNi245

@AlexNi245 Thanks a ton for your work on this. I played around with it, and works great!
I worked on a few UX improvements including  error + success messages locally, so I'll merge this in and push a couple updates to the #44 PR :-)


change too general class name

lrm-mapzen is currently using .info as a class name to display the costing option. This is too general, it might conflict with others

cloased via https://github.com/mapzen/lrm-mapzen/commit/3277a05373341e23ed3bb97ef860f3b08cea9a33


cuda >= 11 support?

same here
Working with cuda 11.4 on a jetson orin nx.
The package compiles but fails at import .
>>> from nvjpeg import NvJpeg
NvRmMemInitNvmap failed with No such file or directory
549: Memory Manager Not supported

****NvRmMemInit failed**** error type: 196626

*** NvRmMemInit failed NvRmMemConstructor


Execute tests in parallel in CI build

Apply learning from the OSS build to the CI build:

[x] Execute tests in parallel
[x] Extract test steps into a template

CI build takes 50 mins and a good target would be 30 mins by running tests in parallel.

Done with 2be99473d5aa8f5995ba089e65d7d60c3bdbc12d.


Cope with trailing tabs in allele_synonyms.txt

Currently fails with: "value for --synonym-column too large at line 3"

There is no problem for files with trailing spaces.  I don't know what I was thinking.


Improve performance of BlurImageFilter via copying the outer radius from one drawing / saves scaled drawing in beginning

will be part of next release


feat: improve enforce_no_store policy

Checklist

[ ] I have read the Contributor Guide
[ ] I have read and agree to the Code of Conduct
[ ] I have added a description of my changes and why I'd like them included in the section below

Description of Changes
enforce_no_store_policy is used to enforce no-store cache-control header in the response for requests that can be computed. This policy now removes expires, etag and last-modified response headers to improve efficiency.
Related Issues
No related issue

lgtm !

Ok cool 👍  in the future I'd consider to make this behaviour configurable for each project (by customers), to provide more control on the caching side of things

It's already configurable, in the edgee.toml (or the console)


[bug] NtopNG interface selection

on the ntopng page we can choose an interface for ntopng to listen to.
however, you can only select a SINGLE interface.
i have several vlans dispersed over 10.0.x.0/24 where X marks the vlan, and ntop can currently only monitor one vlan... thereby considering all the other traffic it sees from internal hosts as being remote networks....
It is currently impossible, using the gui, to configure ntopng to listen to all my interfaces,
meaning i have to go into the shell and manually edit /usr/local/etc/ntopng.conf (not persistent) or the template file for ntopng.conf (not desired)
the interface selection should either allow for multiple selected interfaces (preferred) or at the very least offer an 'all' option.

If you dont set an interface you can choose it the normal way via ntopng own UI. Does this work for you?

this does seem to pretty much match what i want, though it then also adds interfaces like the vpn and pppoe which are 2 that i dont personally care for in ntop statistics.
but i'm not one to complain for minor issues, so for me this works.
maybe change the 'none' text to 'default' or add an info text that 'selecting none will show all interfaces in ntopng' to the gui for clarity.

Will do :)

Sorry for reopening this issue but the problem with only being able to select a single interface persists with current OPNsense 21.7.7:

This is not an issue as long as you only have <= 8 interfaces on your router, but the moment you have more interfaces and want to select a few specific interfaces for ntopng to monitor, (ntopng community only allows to monitor <= 8 interfaces) you simply can't.
Can we get a multiselect dropdown window for this plugin?

You mean there is no scroll bar when there are more than eight? Do you see cthem when you search for name?

You mean there is no scroll bar when there are more than eight? Do you see cthem when you search for name?

I mean you can't select multiple interfaces. You can either select one or none (aka all) which results in random interface monitoring within ntopng.


possibility to add line numbers to code blocks

we should have the ability to add line numbers to code blocks, both those generate by nbCode and nbFile. Ideally it should be something customizable by single block and one could set a global option. defaults would probably be to have it disabled in code blocks produce by nbCode and maybe enabled for blocks produce by nbFile.

What about the new block nbCodeSkip?
Should the global option enable line numbers for both, or only for nbCode?
Should this work for nbPython code blocks too?

IMO, we should have a single switch in nimib that all the official nbCode-like blocks use. nbPython will be moved to nimibex but I think we should implement it for it as well.

Yes I think one way to implement a global switch would be to make sure that nbCodeSource partial is general enough to support all code blocks and is used by all code blocks. Then implement a addLineNumbers renderProc and make sure it is present in all code blocks. This proc would only adds line numbers if a boolean flag enableLineNumbers is present (and true) in either block context or (only if not present) it would check the presence of enableLineNumbers true in doc context. In this way can have a global switch (add enable true in doc context), that can be switched off for specific blocks (add enable false to specific block). Also line numbers can be added only to specific blocks if disabled globally (add enable true for specific block).

notes from call nimib speaking hours:

proc addLineNumbers(doc: var NbDoc, blk: var NbBlock) =
  if blk.context["enableLineNumbers].getBool or doc.context["enableLineNumbers].getBool:
    blk.context["codeHighlighted"] = addLineNumbersToHIghlightedCode(blk.context["codeHighlighted"].getStr)

template enableLineNumbersDoc =
  nb.context["enableLineNumber"] = true

template enableLineNumbersBlock =
  nb.blk.context["enableLineNumber"] = true

assert addLineNumbersToHIghlightedCode("""
func decode(secret: openArray[int]): string =
  ## classified by NSA as <strong>TOP SECRET</strong>
  for c in secret:
    result.add char(c)
""") == """
1 func decode(secret: openArray[int]): string =
2   ## classified by NSA as <strong>TOP SECRET</strong>
3   for c in secret:
4     result.add char(c)
"""

I noticed that the example you gave to me has one issue. If someone tries to select the code, he would also select the line numbers.
I have asked ChatGPT4 for a small html/JS example to render a code block snippet with a copy-to-clipboard button and lines numbering.

HTML
<!DOCTYPE html>

  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Code Renderer</title>
  <link rel="stylesheet" href="styles.css">

  <button id="copyButton">Copy to Clipboard</button>

// Here is your code snippet
function helloWorld() {
  console.log('Hello, world!');
}

JS
document.addEventListener("DOMContentLoaded", function() {
  const codeElement = document.getElementById('code');
  const copyButton = document.getElementById('copyButton');
  const codeText = codeElement.innerText;
  const lineCount = codeText.split('\n').length;

  let lineNumberHTML = '';
  for (let i = 1; i <= lineCount; i++) {
    lineNumberHTML += i + '\n';
  }

  const lineNumberElement = document.createElement('code');
  lineNumberElement.className = 'line-numbers';
  lineNumberElement.innerText = lineNumberHTML;
  codeElement.insertBefore(lineNumberElement, codeElement.firstChild);

  copyButton.addEventListener('click', function() {
    navigator.clipboard.writeText(codeText).then(function() {
      console.log('Code copied to clipboard');
    }).catch(function(err) {
      console.error('Could not copy text: ', err);
    });
  });
});

CSS
body {
  font-family: 'Courier New', Courier, monospace;
}

pre {
  position: relative;
  border: 1px solid #ccc;
  padding-left: 30px;
}

code {
  display: block;
  white-space: pre;
}

.line-numbers {
  position: absolute;
  left: 0;
  top: 0;
  padding: 0 10px;
  user-select: none; /* Prevent text selection */
  color: #888;
}

It encloses the code inside
 and  tags. I do not know how I could do something similar as the JS code.

Hello,
I am not sure how to integrate the last changes that I made in my draft Pull Request, to the code block template.
I guess that I have to give as argument nb and nb.blk so my best guess for now is to change the template definition in src/nimib.nim:
template nbCode*(body: untyped) =
  newNbCodeBlock("nbCode", body):
    addLineNumbers(nb, nb.blk)
    captureStdout(nb.blk.output):
      body

This does absolutely nothing. Would you have any hint on how to proceed?

We have something we call renderPlan which are procs that are run when we render a proc. We do the code highlighting in the renderPlan for example. It is defined here: https://github.com/pietroppeter/nimib/blob/e256687a007f4e45e7f0291d5be96121aea9a470/src/nimib/renders.nim#L48
A renderPlan consists of a list of renderProcs that are run in order. So that would be the correct place to add this feature.
I think the reason your example doesn't work is because the codeHighlighted hasn't been filled yet in the context because it is filled on render. So you pass in an empty string to your proc basically. And then it is overridden on render.
Let me know if you want a more thorough explaination, but it might take some time. I'm quite busy at the moment 😄

To flesh out my previous answer, you could say nimib has 3 phases when it generates a document:

Initialization: all the partials, renderProcs and renderPlans are populated. This is basically what you see in render.nim.
Creation of blocks: this is what happens when you use a block, like nbCode: echo "Hello world". This will populate the block with its inputs in its context object. In the case of nbCode these are the raw code and captured output.
Render: here the renderPlan (and its renderProcs) are run. And once they have run the partial for the block is rendered. It's here that the highlighted code is populated in the context.

So the problem you had was that you tried to add the line numbers in step 2 while the highlighted code wasn't available until step 3. But if you add it as a renderProc and add it to the renderPlan och nbCode it should be available to you.

Thank you for the explanations. I was able to move forward and debug the code. There are still discussions to have on the enableLineNumbersBlock and the HTML rendering of the numbers, but otherwise, I have a working proof of concept.
I wish you all the best for your work.

Awesome, thanks 😄 regarding the copy-ability of the code blocks without including the line numbers, is wrapping the code in a table the usual solution to this? If so I'd say we could try it out and see how it works out 👍

If I believe the above JS generated by ChatGPT4 (thus highly not reliable), it's first approach is a div container.
It replaces in the above HTML:

  <button id="copyButton" class="copy-button">Copy</button>

1
2
3
4// Here is your code snippet
function helloWorld() {
  console.log('Hello, world!');
}

I am unsure of what is the “usual” method here. It could be interpreted as table values as well as element of a div. I'll give in a second post a table solution.

from a google search, it appears there are alternative approaches that do not even need to add numbers in text but automatically generate them through css, it seems something we could explore if it works for us too: https://stackoverflow.com/a/41309213

Hello,
I tried to update the HTML approach but I don't remember exactly what I had in mind.
The table approach is too complex and risky. It removes code's indentation.
Both approaches, CSS and HTML should be tested, as some CSS styling might turn off line numbers.
I think that generating them through CSS is the best approach, as it can be changed on the fly.

This css has an interesting recipe based on simple css and html manipulation: https://css.winterveil.net/


Add changelog and update actions

Codecov Report

Merging #25 (886822c) into main (d0f6e1f) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@          Coverage Diff          @@
##            main     #25   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files         17      17
  Lines        448     448
=====================================
  Misses       448     448

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


The action overflow menu in a data-table is going below pagination

Describe the bug
Couple of issue are there:
1- The overflow menu is going under the pagination option.
2- There is a large gap between the last row of the table and the pagination option.
Here is the snap taken from storybook.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This seems to need two different considerations:

We need to prevent the closed menu from taking up space.
When used within a container with overflow: scroll/auto, like the data table, the menu opens within the scrollable area, potentially hidden. We can add an option to used position: fixed instead of absolute, but that will have some caveats of it's own we need to be careful of. This is because position: fixed will make the menu relative to the window, rather than the anchor.

I changed the animation to use transform: scale so it has no height when hidden. I also added a fixed prop that you can enable, but I would recommend trying without it first.

:tada: This issue has been resolved in version 1.1.14 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Hi @brian-patrick-3, this mostly resolves the issue except in the last row; where the overflow goes under pagination and dragging it up brings the white space.

Hi @brian-patrick-3, this mostly resolves the issue except in the last row; where the overflow goes under pagination and dragging it up brings the white space.

That's correct. With relative absolute positioning, the menu renders within the scrollable container. The only way around that is to use the new fixed property, which has it's own caveats that I mentioned already.


AVRO-1635 C++ schema aware encoders throw tr1::bad_weak_ptr exception for recursive schema

Use indirect symbols to "own" the production needed for records (so that weak_ptrs have something to point to)
Use a stack instead of a counter for the number of items in a repeated symbol
A handful of tests.

Hi! I wanted to follow up on this. I'd be happy to restructure the code if that'd help get this in. Please let me know!


When a url contains colon, it makes 404 response. After I upgrade fastapi from 0.75.0 to 0.77.1.

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
main.py

....
@app.post("/files:upload_homework")
async def create_file():
    ......

--------------------
$ curl -X POST "http://<IP_ADDRESS>:8000/files:upload_homework"
{"detail":"Not Found"}%

------------
I run my fastapi App below command:

uvicorn main:app --host <IP_ADDRESS> --port 80

Description
It works in below packages:
$ pip freeze
anyio==3.5.0
asgiref==3.5.0
click==8.0.4
fastapi==0.75.0
h11==0.13.0
httptools==0.4.0
idna==3.3
Jinja2==3.0.3
MarkupSafe==2.1.1
pydantic==1.9.0
python-dotenv==0.19.2
python-multipart==0.0.5
pytz==2022.1
PyYAML==6.0
six==1.16.0
sniffio==1.2.0
starlette==0.17.1
typing-extensions==4.1.1
uvicorn==0.17.6
uvloop==0.16.0
watchgod==0.8.1
websockets==10.2

It can not works below packages:
$ pip freeze
anyio==3.5.0
asgiref==3.5.0
click==8.0.4
fastapi==0.77.1
h11==0.13.0
httptools==0.4.0
idna==3.3
Jinja2==3.0.3
MarkupSafe==2.1.1
pydantic==1.9.0
python-dotenv==0.19.2
python-multipart==0.0.5
pytz==2022.1
PyYAML==6.0
six==1.16.0
sniffio==1.2.0
starlette==0.19.1
typing-extensions==4.1.1
uvicorn==0.17.6
uvloop==0.16.0
watchgod==0.8.1
websockets==10.2

Operating System
Linux, macOS
Operating System Details
No response
FastAPI Version
0.77.1
Python Version
Python 3.9.12
Additional Context
No response

I can't reproduce your issue
$ curl -X POST "http://<IP_ADDRESS>:80/files:upload_homework"
{"fastapi_version":"0.77.1"}
linsg@linsg-PF2ZKK2Z MINGW64 ~/source_code
$ curl -X POST "http://<IP_ADDRESS>:80/files:upload_homework"
{"fastapi_version":"0.75.0"}

This is my code:
from fastapi import FastAPI
from fastapi import __version__
import uvicorn

app = FastAPI()

@app.post("/files:upload_homework")
def create_file():
    return {"fastapi_version": __version__}

if __name__ == '__main__':
    uvicorn.run(app, host="<IP_ADDRESS>", port=80)

And I found that your run on port 80 but request port 8000.
Will you just run another service on port 8000?

This is not FastAPI issue, that is starlette issue.
You can run below code to see the differences
from starlette.routing import compile_path
from starlette import __version__
print(__version__)

print(compile_path("/files:upload_homework"))

Here is my result
0.17.1
(re.compile('^/files:upload_homework$'), '/files:upload_homework', {})

0.19.1
(re.compile('^/files$'), '/files:upload_homework', {})

So you can see that starlette use different reget to math url path
let's why is for this
Here is the code
And we got from commit message that is for Remove port from Host routing regex https://github.com/encode/starlette/pull/1322
# 0.17.1
path_regex += re.escape(path[idx:].split(":")[0]) + "$"

# 0.19.1
path_regex += re.escape(path[idx:]) + "$"

So you should not use : on url path  or you make one issue to starlette for this

Thank you for reply.
We use google API design standard in my team. (https://cloud.google.com/apis/design/custom_methods?hl=zh-cn)
Maybe I should make an issue to starlette for this.

We have the same problem. As a workaround you can append {dummy:path} at the end of your route, @kevinGan .

Starlette 0.20.2 contains a fix for this. We've just released that version. :)

Wouldn't it be worth having a warning or something in documentation? This is a pretty major regression.

It is already fixed in starlette. The dependency "just" needs to be updated in fastapi now.

This is issue is fixed in fastapi 0.85.0.

close?

Thanks for the help here everyone! 👏  🙇
If that solves the original problem, then you can close this issue @kevinGan  ✔


Output as Text

I'm back with my hat in hand :)
Plain text output please, with hard line breaks at a set column.
Currently I do this with pandoc
pandoc -f markdown -t markdown --columns=80 document.md > newdocument.md

Then I could build refomatter into Markdown Edit.

To clarify - you are not looking for plain text output but rather markdown output, preserving all the little details?
One problem that I see right away - inline links and reference links - the details on how they were entered are not preserved. So the formatter has to choose the resulting formatting - but what should it be? For example, are the references added after the paragraph or at the end? Does it use numeric reference labels or creates some magic strings?

Correct, I want to preservie the mMarkdown although some interpretation, as you point out, will occur. I don't use references so I can't speak to the issue. Pandoc reformats # headers into === and --- headers. I imagine there are some other things it does like thatl, but nothing I have ever been bothered by. Hard line breaks make reading text from the console a bit nicer.

Header texts can be left alone - AST contains information from which format it was parsed. I would avoid converting them between formats.
For now reference links seem to be the only thing that loses significant information during parsing.

I have started work on this in the md-writer branch. Perhaps you could try it out and list the issues you can find.
Some I know already:

[ ] hard-wrapping lines are not yet implemented
[ ] blockquote prefix >  is not rendered on blank lines within the quote
[ ] links and images loses title attribute

ooooh, new shiny to play with this weekend. Thanks!
On Thu, Mar 5, 2015 at 3:50 PM, Kārlis Gaņģis<EMAIL_ADDRESS>wrote:

I have started work on this in the md-writer
https://github.com/Knagis/CommonMark.NET/tree/md-writer branch. Perhaps
you could try it out and list the issues you can find.
Some I know already:

hard-wrapping lines are not yet implemented
blockquote prefix > is not rendered on blank lines within the quote
links and images loses title attribute

—
Reply to this email directly or view it on GitHub
https://github.com/Knagis/CommonMark.NET/issues/26#issuecomment-77448800
.

Hey, this is looking nice. Here's something I noticed
Header Text
=========

is formatted as
Header Text
===

I think in the spirit of, "keeping it pretty", we should either keep the number of underlines elements in the original document or better still, match the number of underline elements to the length of the text.
The parser correctly  preserves # Header elements. +1
In ordered and unordered lists, the original indent is not preserved
  1. line 1
  2. line 2

is rendered as
1. line 1
2. line 2

This is not big issue. However, when I write markdown I usually indent these items a couple of spaces to simulate how they appear in HTML
If preserving the original indentation is difficult, I would settle for a configuration option.
Same thing goes for blocks quotes. Source indentation in not preserved.
Finally, the following:
  1. hello
  2. there

  > block
  > quote

renders as:
1. hello
2. there
> block quote

Should there be a blank line b/t the numbered list and block quote?
That's all for now. Great job!

Horizontal breaks present some interesting challenges.
----------------

is  currently output as
---

Couple of options here.

Keep current behavior. It's correct but not stylish
Perserve the original number of dashes
Pad with dashes to the column length

Not sure what I want here. Probably option 3 but 2 would likey suffice.

header texts

I will change this to match the number of characters in the previous line

In ordered and unordered lists, the original indent is not preserved

I think that the parser preserves this information so the list could be indented based on the first item.

block quote after list

that is a bug coming from the fact that the list is tight so the paragraphs do not render the newline. this should be easy to fix.

horizontal breaks

I suppose that the only reasonable solution is to add a configuration option on how many dashes to add. Leaving the count from the source goes against the idea of reformatting the document accoring to a single style.
Thank you for the feedback!

I agree on all your points.

One other thought. You might want to include a configuration to always force H1/H2 headers to underline. Or if you're really crazy a 3 way setting.

always underlined
always #
keep document format

I'm looking for a new feature to add to Markdown Edit this weekend. Hint, hint, hint :smile:

Unfortunately I had no time to work on this so it is still in the state you last reviewed...

Any movement on this guys? Is it still living in the branch? Any idea what kind of work is outstanding and if I can contribute to get it out and into a release? Cheers.

Just FYI, I am interested in a markdown parser that can do full-fidelity "round trip", as well as normalization on top of that. The work described in this thread seems aimed at normalization, but being able to just do round-trip (emitting the exact same text as the original output) is also useful when you want to do programmatic transformations without mucking about with the existing style.


Supporting Cookie Parameter Types

In Django, FastAPI, and Flask projects, you can receive cookie parameters, and cookies act as one of the input vectors for the API. Therefore, let's add support for cookie parameter types to the src/models/endpoint.cr model.

Hello again @ksg97031
I added the cookie type to the Param type. Currently, the available types are as follows.
"query", "json", "form", "header", "cookie"

# It would be good to consider file types later on as well.

When you provide the param_type as cookie during Param.new(), it will be created as a cookie type. I also made some improvements to the output format for this. (Please review the pull request #170 😉)
Param.new(param, "", "cookie")

Basic Result

JSON Result


Ability to reindex Elastic Search from CLI

It would be nice if we had ability to reindex the Elastic search indexes from the CLI:
Suggested command:
amplify api --reindex [modelName|all]
Process would be do:

Create new indexes from existing amplify table (option is available to do all, or specific models)
Some sort of sanity check to ensure there are the correct number of items
Swap/Rename the indexes in elastic search
Delete the old index

(Created in response to comments in: #78)

@GeorgeBellTMH One way to do this today would be to delete that index and back fill. We have a sample backfill script here: https://docs.amplify.aws/cli/graphql-transformer/directives#backfill-your-elasticsearch-index-from-your-dynamodb-table
We do have a feature request open for making sure that a user of the CLI has the option to re-index the cluster when changing types for example. Please follow this issue for updates: https://github.com/aws-amplify/amplify-cli/issues/3340
Closing this issue as a duplicate of #3340

I know about the script, this ticket was to make the script part of the cli since this is a thing that occasionally users of the cli need to do when things break...downloading and installing a bunch of other dependencies and configuration seems like a bad user experience when it could all just be done via the cli.


sonar doesn't start because of conection refused to database

steps for reproduce:
1 - install docker tools in windows
2 - do a compose up -d
3 - everything runs ok but sonar.
some output:
2016.04.06 10:57:01 ERROR web[o.a.c.c.C.[.[.[/]] Exception sending context initialized event to listener instance of class org.sonar.server.platform.PlatformServletContextListener
java.lang.IllegalStateException: Can not connect to database. Please check connectivity and settings (see the properties prefixed by 'sonar.jdbc.').
at org.sonar.core.persistence.DefaultDatabase.checkConnection(DefaultDatabase.java:117) ~[sonar-core-5.1.2.jar:na]
at org.sonar.core.persistence.DefaultDatabase.start(DefaultDatabase.java:73) ~[sonar-core-5.1.2.jar:na]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_45-internal]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_45-internal]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_45-internal]
at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_45-internal]
at org.picocontainer.lifecycle.ReflectionLifecycleStrategy.invokeMethod(ReflectionLifecycleStrategy.java:110) ~[picocontainer-2.14.3.jar:na]
at org.picocontainer.lifecycle.ReflectionLifecycleStrategy.start(ReflectionLifecycleStrategy.java:89) ~[picocontainer-2.14.3.jar:na]
at org.picocontainer.injectors.AbstractInjectionFactory$LifecycleAdapter.start(AbstractInjectionFactory.java:84) ~[picocontainer-2.14.3.jar:na]
at org.picocontainer.behaviors.AbstractBehavior.start(AbstractBehavior.java:169) ~[picocontainer-2.14.3.jar:na]
at org.picocontainer.behaviors.Stored$RealComponentLifecycle.start(Stored.java:132) ~[picocontainer-2.14.3.jar:na]
at org.picocontainer.behaviors.Stored.start(Stored.java:110) ~[picocontainer-2.14.3.jar:na]
at org.picocontainer.DefaultPicoContainer.potentiallyStartAdapter(DefaultPicoContainer.java:1015) ~[picocontainer-2.14.3.jar:na]
at org.picocontainer.DefaultPicoContainer.startAdapters(DefaultPicoContainer.java:1008) ~[picocontainer-2.14.3.jar:na]
at org.picocontainer.DefaultPicoContainer.start(DefaultPicoContainer.java:766) ~[picocontainer-2.14.3.jar:na]
at org.sonar.api.platform.ComponentContainer.startComponents(ComponentContainer.java:91) ~[sonar-plugin-api-5.1.2.jar:na]
at org.sonar.server.platform.Platform.startLevel1Container(Platform.java:96) ~[sonar-server-5.1.2.jar:na]
at org.sonar.server.platform.Platform.init(Platform.java:72) ~[sonar-server-5.1.2.jar:na]
at org.sonar.server.platform.PlatformServletContextListener.contextInitialized(PlatformServletContextListener.java:43) ~[sonar-server-5.1.2.jar:na]
at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4720) [tomcat-embed-core-8.0.18.jar:8.0.18]
at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5154) [tomcat-embed-core-8.0.18.jar:8.0.18]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) [tomcat-embed-core-8.0.18.jar:8.0.18]
at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1409) [tomcat-embed-core-8.0.18.jar:8.0.18]
at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1399) [tomcat-embed-core-8.0.18.jar:8.0.18]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_45-internal]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_45-internal]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_45-internal]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45-internal]
Caused by: org.apache.commons.dbcp.SQLNestedException: Cannot create PoolableConnectionFactory (Connection refused. Check that the hostname and port are correct and that the postmaster is accepting TCP/IP connections.)
at org.apache.commons.dbcp.BasicDataSource.createPoolableConnectionFactory(BasicDataSource.java:1549) ~[commons-dbcp-1.4.jar:1.4]
at org.apache.commons.dbcp.BasicDataSource.createDataSource(BasicDataSource.java:1388) ~[commons-dbcp-1.4.jar:1.4]
at org.apache.commons.dbcp.BasicDataSource.getConnection(BasicDataSource.java:1044) ~[commons-dbcp-1.4.jar:1.4]
at org.sonar.core.persistence.DefaultDatabase.checkConnection(DefaultDatabase.java:115) ~[sonar-core-5.1.2.jar:na]
... 27 common frames omitted
Caused by: org.postgresql.util.PSQLException: Connection refused. Check that the hostname and port are correct and that the postmaster is accepting TCP/IP connections.

apart from that, thank you for your work.
i am learning a lot about docker and docker-compose and continous integration.
thank you very much.

line 36 in docker-compose.yml
- SONARQUBE_JDBC_URL=jdbc:postgresql://localhost:5432/sonar replace localhost with IP of your docker-machine. You can discover IP by running docker-machine ip command

Hi @mercuriete
can you try it again. I replaced the deprecated Links feature with "docker network".
I also added a missing depends_on relation.
Greetings,
Marcel

Hi again.
Sonar does work now. But now gitlab and node-chrome-debug and node-firefox-debug are not working.
steps to reproduce:

git clone
docker-compose up -d
see log output.

i will put some output:
node-chrome-debug:
/opt/bin/entry_point.sh: line 3: /opt/bin/functions.sh: No such file or directory
/opt/bin/entry_point.sh: line 34: get_server_num: command not found
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
node-firefox-debug:
/opt/bin/entry_point.sh: line 3: /opt/bin/functions.sh: No such file or directory
/opt/bin/entry_point.sh: line 34: get_server_num: command not found
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
Waiting xvfb...
gitlab:
Initializing logdir...
Initializing datadir...
Installing configuration templates...
Configuring gitlab...
Configuring gitlab::database
Configuring gitlab::redis...........................................................

node-chrome-debug and firefox dies almost instantainly.
gitlab waits a long period and it seems that it can't connect with redis. but i'm not sure.
Thank you very much.

Hi @mercuriete
I am running the toolchain on MacOS (16GB RAM) with the latest version of the Docker Toolbox (Docker 1.10).
Which version are you using?
Greetings,
Marcel

FYI: The latest version of the toolbox is 1.11 ;-)

i had 1.10.3. I'm installing 1.11.1.
Thanks for pointing that issue.
:)

@marcelbirkner please can you give a bit more detail about what you did to fix it? For example: Are those changes you made, to configuration files? Where are they located, what settings did you change, where did you add the links you describe, what were the links?
We are seeing the same problem and can't see a way forward.

Issue solved by dropping the Docker version back down to Docker version 1.12.5, build 7392c3b

We found this was cured by:

Stopping and starting the Docker daemon, after this start SonarQube and it connects to the database.
Further crashes were caused by Puppet client configuration. Turning off the Puppet client stopped crashes. This is most likely misconfiguration and not a fundamental incompatibility with SQ.


secret manager - key and bip32 impls

What does this implement/fix? Explain your changes.

支持多种签名算法
支持多签名算法 bip32

Does this close any currently open issues?
If it fixes a bug or resolves a feature request, be sure to link to that issue.
…
Pull request type

Put an x in the boxes that apply

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Where has this been tested?
…
Any other comments?
…

谁有空可以帮忙看下这个 PR，都添加上测试用例了，我有个 PR 会对这个 PR 有依赖。多谢

@taimanhui 我把 secret manager 相关的也已经合并提到这个 PR 里了，有空帮忙看下


Add 'H2' as editable element.

This will almost certainly require further modifications down the road, but let's start here.

what about h1?

I'm not sure exactly what you're trying to accomplish here, but I'm fairly sure this isn't the way to do it. The removeFormat function is about removing specific inline styles. If you want to change block type, you should use the modifyBlocks function. If what you're looking for is a more generic remove all formatting feature (#7), this is not the right basis for a solution.


fix wait logic when waiting for the root cert

This PR is for the wait logic when generate secret in SDS service, there is a wait time which should be double during retry, but seems in the origin logic the wait parameter is not used and it always waiting with the initial duration.

Hi @DahuK. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot I signed it

/ok-to-test
Did this cause any issues or just something you noticed? lgtm in general just curious

/ok-to-test
Did this cause any issues or just something you noticed? lgtm in general just curious

just my notice and no issue found in current @howardjohn


Make the modelcar injection idempotent

Due to changes in https://github.com/kserve/kserve/commit/39b8a6748732349f72d0701076c85e66d630755f which added reinvocationPolicy: IfNeeded to the WebHook configuration, the injection function can (and will be) called multiple times, and needs to be idempotent (which is a good thing anyway).
This commit fixes the array field handling and adds volumes, volume mounts, and containers only if they are still needed to be added.

What this PR does / why we need it:
It fixes an issue with model car injection when using reinvocationPolicy: IfNeeded in the webhook configuration.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3506
Type of changes
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[x] Unit test that checks via reflect.DeepEquals that running the inject code twice results in the same pod

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[X] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[X] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation? --> no change needed

Release note:

Fix issue with modelcar injection

@yuzisun quick heads up, this is an essential fix for a blocker for modelcars that slipped into 0.12.0 (triggered by some other change). Maybe this fix could get into 0.12.1 ?

/approve


how is it security

For security-related information, please refer to the following link:
Secure Configuration


Creating and Traversing a Doubly Linked List

Please allow me to add "Creating and Traversing a Doubly Linked List" problem in JAVA section.
I have participated in HACKTOBERFEST2021
THANK YOU

PLEASE ACCEPT MY PR


Feature/scrum 3793

tests?

{suggestion} Is it to late to rename the tuple fields to 'first' and 'second' rather than their shorthand 'fst' & 'snd'? Thought they were deep/binary third-party library fields for a bit.


Revise team application

https://github.com/gratipay/gratipay.com/blob/master/www/new.spt
Follows from https://github.com/gratipay/gratipay.com/pull/4117 as part of Decouple that we'll need to change the team application form.

I'd like to break this down into groups:

Basics (required)

Team name
Image
Product or service
Homepage
Agree to public review
Agree to TOS

Open work fields (optional)

Include short sentence explaining open work, with links.
Onboarding URL
Todo URL

TWYW fields (optional)

Include short sentence explaining TWYW payouts, with links.
Agree to Payroll TWYW payouts

Do we need the open work and TWYW fields?
We're not going to offer TWYW as a product again for a year or three. If/when that happens I expect we'll have a new flow for Projects to turn that feature on. We can explain the product and re-up terms agreement then.
For open work ... I guess we've already gone to the trouble of verifying most of the existing 200+ projects as providing open work. Can we make that a separate verification flow rather than tying it to initial onboarding? What's the benefit we offer to those that go through the process?

We're not going to offer TWYW as a product again for a year or three. If/when that happens I expect we'll have a new flow for Projects to turn that feature on. We can explain the product and re-up terms agreement then.

Good with that.

For open work ... I guess we've already gone to the trouble of verifying most of the existing 200+ projects as providing open work. Can we make that a separate verification flow rather than tying it to initial onboarding? What's the benefit we offer to those that go through the process?

I can be good with that. We don't currently have any benefit. I think the levels we've talked about would be appropriate under https://github.com/gratipay/gratipay.com/issues/3736 (once we sort, we need to have a default sort order...). We should keep track of those projects that are already "open work" approved, so we can grandfather them in when we get to that (which I suppose could just be a list on a ticket somewhere, rather than dumping it into the database right now).

Help (include short description and/or link to other pages at Gratipay.com/about; https://github.com/gratipay/gratipay.com/issues/3859)

Why do we have to apply?
What happened to "open work"?
Do I need a project for everything I do, or can one project cover everything? (Teams of one)

Basics (required)

Team name
Image
Product or service
Homepage
Agree to public review
Agree to TOS

I think it should remain an "application" (along with verbs on the form) because we review it for approval, but @whit537 just calls it a "form" at https://github.com/gratipay/inside.gratipay.com/issues/821#issuecomment-248935715. Thoughts on either way?

I'd be working on this but am running into installation issues, apparently due to upgrading to El Capitan: https://github.com/gratipay/gratipay.com/issues/4131.

Back on it, comments over at https://github.com/gratipay/gratipay.com/pull/4130.

What's the difference between this and #4130, @mattbk?

This is an issue, that's a PR.

Gotcha.


Testing

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7d2e8c3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   66.43%
=========================================
  Files             ?        1
  Lines             ?      143
  Branches          ?        0
=========================================
  Hits              ?       95
  Misses            ?       48
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2e8c3...d87ba35. Read the comment docs.