Process stuck in a sleep

Step To Reproduce / Observed behavior
I'm running some scrapper as part of Sidekiq jobs, but unfortunately sometimes they get stuck forever.
By doing a dump of Sidekiq I can clearly see that there is an infinite sleep happening under the hood when using Playright gem, here is the trace below:
2023-09-14T09:48:21.654990+00:00 app[worker.1]: pid=2 tid=3nq WARN: /app/vendor/bundle/ruby/3.2.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/promises.rb:775:in `sleep'
2023-09-14T09:48:21.654991+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/promises.rb:775:in `wait'
2023-09-14T09:48:21.654991+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/promises.rb:775:in `block in wait_until_resolved'
2023-09-14T09:48:21.654991+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/promises.rb:771:in `synchronize'
2023-09-14T09:48:21.654991+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/promises.rb:771:in `wait_until_resolved'
2023-09-14T09:48:21.654991+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/promises.rb:1256:in `wait_until_resolved!'
2023-09-14T09:48:21.654991+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/concurrent-ruby-1.1.10/lib/concurrent-ruby/concurrent/promises.rb:1471:in `value!'
2023-09-14T09:48:21.654992+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/playwright-ruby-client-1.37.1/lib/playwright/connection.rb:104:in `send_message_to_server'
2023-09-14T09:48:21.654992+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/playwright-ruby-client-1.37.1/lib/playwright/channel.rb:34:in `block in send_message_to_server_result'
2023-09-14T09:48:21.654992+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/playwright-ruby-client-1.37.1/lib/playwright/channel.rb:65:in `with_logging'
2023-09-14T09:48:21.654992+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/playwright-ruby-client-1.37.1/lib/playwright/channel.rb:33:in `send_message_to_server_result'
2023-09-14T09:48:21.654992+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/playwright-ruby-client-1.37.1/lib/playwright/channel.rb:20:in `send_message_to_server'
2023-09-14T09:48:21.654992+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/playwright-ruby-client-1.37.1/lib/playwright/channel_owners/browser_type.rb:14:in `launch'
2023-09-14T09:48:21.654993+00:00 app[worker.1]: /app/vendor/bundle/ruby/3.2.0/gems/playwright-ruby-client-1.37.1/lib/playwright_api/browser_type.rb:109:in `launch'
2023-09-14T09:48:21.654993+00:00 app[worker.1]: /app/app/models/scrappers/job.rb:7:in `block in getJobUrls'

Any recommendation on how to solve this issue?
Environment

Rails 7
Playright Gem 1.37.1
Heroku

We're also seeing a similar issue.  Here's a stack trace from one of our freezes:
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:785:in `sleep'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:785:in `wait'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:785:in `block in wait_until_resolved'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:773:in `synchronize'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:773:in `wait_until_resolved'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:1267:in `wait_until_resolved!'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:1482:in `value!'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.37.0/lib/playwright/connection.rb:104:in `send_message_to_server'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.37.0/lib/playwright/channel.rb:34:in `block in send_message_to_server_result'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.37.0/lib/playwright/channel.rb:65:in `with_logging'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.37.0/lib/playwright/channel.rb:33:in `send_message_to_server_result'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.37.0/lib/playwright/channel.rb:20:in `send_message_to_server'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.37.0/lib/playwright/channel_owners/frame.rb:177:in `wait_for_selector'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.37.0/lib/playwright/channel_owners/page.rb:233:in `wait_for_selector'
      /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.37.0/lib/playwright_api/page.rb:1611:in `wait_for_selector'

We have playwright deployed to an ECS Fargate service that runs a single playwright instance behind an ALB, where the ALB handles SSL termination.  When we redeploy the playwright service (ECS will spin up a new playwright instance, add it to the ALB pool, and then teardown the old playwright), I would say 50% of the time our code that uses the playwright client hangs with the above backtrace.  The other half of the time, we'll get a SSL_write: protocol is shutdown error (which is easy to rescue and retry from).
Will also try the latest version of the client once I get a chance.

I updated the gem to the latest version 1.41.1 and still see it hanging.  Here's a backtrace:
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:785:in `sleep'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:785:in `wait'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:785:in `block in wait_until_resolved'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:773:in `synchronize'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:773:in `wait_until_resolved'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:1267:in `wait_until_resolved!'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/concurrent-ruby-1.2.3/lib/concurrent-ruby/concurrent/promises.rb:1482:in `value!'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.41.1/lib/playwright/connection.rb:118:in `send_message_to_server'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.41.1/lib/playwright/channel.rb:35:in `block in send_message_to_server_result'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.41.1/lib/playwright/channel.rb:67:in `with_logging'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.41.1/lib/playwright/channel.rb:34:in `send_message_to_server_result'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.41.1/lib/playwright/channel.rb:20:in `send_message_to_server'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.41.1/lib/playwright/channel_owners/page.rb:342:in `reload'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.41.1/lib/playwright_api/page.rb:1085:in `reload'

@cswilliams Hi, very sorry for no response.
Could you execute the script with DEBUG=1 and provide a log around the error occurs?
I guess some event notifications from playwright driver are ignored/missed unexpectedly by playwright-ruby-client.

Sure, here you go:
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"remove"=>"commit"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"remove"=>"load"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"remove"=>"domcontentloaded"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"remove"=>"networkidle"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"add"=>"commit"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"navigated", "params"=>{"url"=>"https://XXXXXXXXXXX", "name"=>"", "newDocument"=>{"request"=>{"guid"=>"request@e9d03f1d7e1dbce06b223b81003031de"}}}}
RECV>{"guid"=>"browser-context@bbd47438250a28b9b159bca16f359ba1", "method"=>"requestFinished", "params"=>{"request"=>{"guid"=>"request@e9d03f1d7e1dbce06b223b81003031de"}, "response"=>{"guid"=>"response@4f79ce449ecfafb171e3936006a176f2"}, "responseEndTiming"=>3764.611, "page"=>{"guid"=>"page@11181cc114c6f06b410fa35c3236d4b5"}}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"add"=>"domcontentloaded"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"add"=>"load"}}
RECV>{"id"=>46, "result"=>{"response"=>{"guid"=>"response@4f79ce449ecfafb171e3936006a176f2"}}}
SEND>{:id=>47, :guid=>"frame@6968aeafe16d223ff32e33beb320c3fa", :method=>"waitForSelector", :params=>{:selector=>".link-record", :timeout=>5000}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"add"=>"networkidle"}}
RECV>{"id"=>47, "error"=>{"error"=>{"message"=>"Timeout 5000ms exceeded.\n=========================== logs ===========================\nwaiting for locator('.link-record') to be visible\n============================================================", "stack"=>"TimeoutError: Timeout 5000ms exceeded.\n=========================== logs ===========================\nwaiting for locator('.link-record') to be visible\n============================================================\n    at ProgressController.run (/home/pwuser/.npm/_npx/b8f8556362a868f7/node_modules/playwright-core/lib/server/progress.js:88:26)\n    at Frame.waitForSelector (/home/pwuser/.npm/_npx/b8f8556362a868f7/node_modules/playwright-core/lib/server/frames.js:618:23)\n    at FrameDispatcher.waitForSelector (/home/pwuser/.npm/_npx/b8f8556362a868f7/node_modules/playwright-core/lib/server/dispatchers/frameDispatcher.js:103:103)\n    at DispatcherConnection.dispatch (/home/pwuser/.npm/_npx/b8f8556362a868f7/node_modules/playwright-core/lib/server/dispatchers/dispatcher.js:313:46)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)", "name"=>"TimeoutError"}}}
SEND>{:id=>48, :guid=>"frame@6968aeafe16d223ff32e33beb320c3fa", :method=>"querySelector", :params=>{:selector=>".no-results-msg"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"__create__", "params"=>{"type"=>"ElementHandle", "initializer"=>{"preview"=>"JSHandle@node"}, "guid"=>"handle@acda47679b32e6b99b6dd3208c3f36e9"}}
RECV>{"id"=>48, "result"=>{"element"=>{"guid"=>"handle@acda47679b32e6b99b6dd3208c3f36e9"}}}
RECV>{"guid"=>"handle@acda47679b32e6b99b6dd3208c3f36e9", "method"=>"previewUpdated", "params"=>{"preview"=>"JSHandle@No records are available in this view"}}
SEND>{:id=>49, :guid=>"page@11181cc114c6f06b410fa35c3236d4b5", :method=>"reload", :params=>{:timeout=>120000}}
RECV>{"guid"=>"page@11181cc114c6f06b410fa35c3236d4b5", "method"=>"__create__", "params"=>{"type"=>"Request", "initializer"=>{"frame"=>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa"}, "url"=>"https://XXXXXXXXXXX", "resourceType"=>"document", "method"=>"GET", "headers"=>[{"name"=>"Upgrade-Insecure-Requests", "value"=>"1"}, {"name"=>"User-Agent", "value"=>"Mozilla/5.0 (X11; Linux aarch64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/116.0.5845.82 Safari/537.36"}, {"name"=>"sec-ch-ua", "value"=>"\"Chromium\";v=\"116\", \"Not)A;Brand\";v=\"24\", \"HeadlessChrome\";v=\"116\""}, {"name"=>"sec-ch-ua-mobile", "value"=>"?0"}, {"name"=>"sec-ch-ua-platform", "value"=>"\"Linux\""}], "isNavigationRequest"=>true}, "guid"=>"request@d4a96cd8fd5814afb6e6bba48cd1b424"}}
RECV>{"guid"=>"browser-context@bbd47438250a28b9b159bca16f359ba1", "method"=>"request", "params"=>{"request"=>{"guid"=>"request@d4a96cd8fd5814afb6e6bba48cd1b424"}, "page"=>{"guid"=>"page@11181cc114c6f06b410fa35c3236d4b5"}}}
RECV>{"guid"=>"request@d4a96cd8fd5814afb6e6bba48cd1b424", "method"=>"__create__", "params"=>{"type"=>"Response", "initializer"=>{"request"=>{"guid"=>"request@d4a96cd8fd5814afb6e6bba48cd1b424"}, "url"=>"https://XXXXXXXXXXX", "status"=>200, "statusText"=>"", "headers"=>[{"name"=>"cache-control", "value"=>"private"}, {"name"=>"content-length", "value"=>"34664"}, {"name"=>"content-type", "value"=>"text/html; charset=utf-8"}, {"name"=>"date", "value"=>"Thu, 07 Mar 2024 00:11:35 GMT"}, {"name"=>"server", "value"=>"Microsoft-IIS/10.0"}, {"name"=>"x-aspnet-version", "value"=>"4.0.30319"}, {"name"=>"x-content-type-options", "value"=>"nosniff"}, {"name"=>"x-powered-by", "value"=>"ASP.NET"}, {"name"=>"x-xss-protection", "value"=>"1; mode=block"}], "timing"=>{"startTime"=>1709770292844.012, "domainLookupStart"=>-1, "domainLookupEnd"=>-1, "connectStart"=>-1, "secureConnectionStart"=>-1, "connectEnd"=>-1, "requestStart"=>0.455, "responseStart"=>2836.57}, "fromServiceWorker"=>false}, "guid"=>"response@df0fff516aa45e6b8a8c6b5d1fdbdcd2"}}
RECV>{"guid"=>"browser-context@bbd47438250a28b9b159bca16f359ba1", "method"=>"response", "params"=>{"response"=>{"guid"=>"response@df0fff516aa45e6b8a8c6b5d1fdbdcd2"}, "page"=>{"guid"=>"page@11181cc114c6f06b410fa35c3236d4b5"}}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"remove"=>"commit"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"remove"=>"domcontentloaded"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"remove"=>"load"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"remove"=>"networkidle"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"add"=>"commit"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"navigated", "params"=>{"url"=>"https://XXXXXXXXXXX", "name"=>"", "newDocument"=>{"request"=>{"guid"=>"request@d4a96cd8fd5814afb6e6bba48cd1b424"}}}}
RECV>{"guid"=>"browser-context@bbd47438250a28b9b159bca16f359ba1", "method"=>"requestFinished", "params"=>{"request"=>{"guid"=>"request@d4a96cd8fd5814afb6e6bba48cd1b424"}, "response"=>{"guid"=>"response@df0fff516aa45e6b8a8c6b5d1fdbdcd2"}, "responseEndTiming"=>2838.363, "page"=>{"guid"=>"page@11181cc114c6f06b410fa35c3236d4b5"}}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"add"=>"domcontentloaded"}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"add"=>"load"}}
RECV>{"id"=>49, "result"=>{"response"=>{"guid"=>"response@df0fff516aa45e6b8a8c6b5d1fdbdcd2"}}}
SEND>{:id=>50, :guid=>"frame@6968aeafe16d223ff32e33beb320c3fa", :method=>"waitForSelector", :params=>{:selector=>".link-record", :timeout=>5000}}
RECV>{"guid"=>"frame@6968aeafe16d223ff32e33beb320c3fa", "method"=>"loadstate", "params"=>{"add"=>"networkidle"}}

Just to make sure everything is clear, the hanging issue appears when the playwright server behind our load balancer is replaced. Our script that utilizes the playwright client connects to a load balancer over SSL, which then forwards the web socket connection to the underlying playwright server.  When this underlying playwright server is shutdown and a replacement is added, it seems like the client doesn't disconnect properly from the old server sometimes.  50% of the time our script exits with an OpenSSL::SSL::SSLError: SSL_write: protocol is shutdown (which is fine behavior and can be easily caught/retried), but the other half of the time it gets stuck in that promise and hangs forever.

Also, if it helps, this is what the backtrace looks like when it disconnects properly and doesn't hang:
Error: OpenSSL::SSL::SSLError::SSL_write: protocol is shutdown
Backtrace: /Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/3.1.0/openssl/buffering.rb:354:in `syswrite'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/3.1.0/openssl/buffering.rb:354:in `do_write'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/3.1.0/openssl/buffering.rb:371:in `block in write'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/3.1.0/openssl/buffering.rb:370:in `each'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/3.1.0/openssl/buffering.rb:370:in `inject'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/3.1.0/openssl/buffering.rb:370:in `write'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.42.1/lib/playwright/web_socket_client.rb:42:in `write'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/websocket-driver-0.7.6/lib/websocket/driver/hybi.rb:229:in `send_frame'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/websocket-driver-0.7.6/lib/websocket/driver/hybi.rb:187:in `frame'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/websocket-driver-0.7.6/lib/websocket/driver/hybi.rb:151:in `close'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.42.1/lib/playwright/web_socket_client.rb:121:in `close'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.42.1/lib/playwright/web_socket_transport.rb:45:in `stop'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.42.1/lib/playwright/connection.rb:44:in `stop'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.42.1/lib/playwright.rb:48:in `stop'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.42.1/lib/playwright.rb:134:in `ensure in connect_to_playwright_server'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/gems/playwright-ruby-client-1.42.1/lib/playwright.rb:134:in `connect_to_playwright_server'

If it helps, I made a branch with the fixes (based of 1.37.0 since that's what we currently use, I think it should apply cleanly to main tho): https://github.com/YusukeIwaki/playwright-ruby-client/compare/main...cswilliams:1.37.0_fix_hang?expand=1
Hopefully that's a bit easier to see.
Another issue I'm running into is that if I try to source this gem from either your github repo or my fork, like so:
Gemfile:
gem "playwright-ruby-client", git: 'https://github.com/YusukeIwaki/playwright-ruby-client'

Then run bundle install and try to run my script.  When calling Playwright.connect_to_playwright_server I get this error:
NoMethodError undefined method `new' for Playwright:Module

          @impl._api ||= api_class.new(@impl)
                                  ^^^^
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/bundler/gems/playwright-ruby-client-aeb9671a1b13/lib/playwright/playwright_api.rb:45:in `wrap'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/bundler/gems/playwright-ruby-client-aeb9671a1b13/lib/playwright/playwright_api.rb:13:in `wrap'
/Users/cswilliams/.rbenv/versions/3.1.4/lib/ruby/gems/3.1.0/bundler/gems/playwright-ruby-client-aeb9671a1b13/lib/playwright.rb:124:in `connect_to_playwright_server'

Do you know why that might be? It only seems to appear when sourcing the gem from git in the Gemfile.

Please ignore my last question, I was finally able to get it working in a Gemfile via git after running bundle exec ruby development/generate_api.rb, adjusting the .gitignore files, and then committing the changed files into my branch.  Now that I am able to build my own gem with the fixes, I will do some more testing against my changes next week and let you know if I run into any issues.

@cswilliams Thank you for your detailed information.
I tried the code and merged it into 1.42.x and 1.37.1.
Could you try playwright-ruby-client 1.37.2.alpha1 ? If it works well, I will set the version to 1.37.2.
https://github.com/YusukeIwaki/playwright-ruby-client/pull/292/files

@YusukeIwaki Unfortunately my contract just ended with the company that ran into this problem so I am not able to test it further.  However, I did build a custom gem from the changes I outlined above and deployed it to production several weeks ago.  We did not observe any more hangs (nor any other negative behavior) so I think it should be safe to use.


Integration tests fail with "VM error"

An integration test that queries a contract for a list of ids is failing with "VM error:".
Tried it in cosmwasm-plus (see branch https://github.com/CosmWasm/cosmwasm-plus/tree/atomic-swap-integ_test_query for PoC).
Reproduced also in coswasm, under the queue contract.
The errors are of the form:
thread 'test_query' panicked at 'VM error: CommunicationErr { source: InvalidRegion { source: LengthExceedsCapacity { length:<PHONE_NUMBER>, capacity:<PHONE_NUMBER>, backtrace: Backtrace(()) } } }', ...

,
thread 'query_list' panicked at 'VM error: CommunicationErr { source: RegionLengthTooBig { length:<PHONE_NUMBER>, max_length: 65536, backtrace: Backtrace(()) } }', ...

The problem seems to be related to the use of cosmwasm-storage. Or, maybe, adding cosmwasm-storage as new dependency changed the versions of some packages, and that is what is triggering the error.
Creating this issue for tracking and documentation.

I just gave you permission to push a branch.
Can you please make a PR with the test showing the failure?

https://github.com/CosmWasm/cosmwasm/pull/509
Tomorrow I'll continue testing. I find something else I'll publish it here.

Nice find! This is most likely a bug in cosmwasm-std.


attempting to fix markdown

sorry, my first attempt didn't work, I think you need to do 2 carriage returns before list in order for it to render like a list.
You can check https://azure.microsoft.com/en-us/documentation/articles/automation-dsc-getting-started/#viewing-the-list-of-dsc-nodes - it still doesn't render like a list. Althou on the github it does render like a list. I think it should work now.

Hi @4c74356b41, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@4c74356b41 : Thanks for your contribution to the Azure documentation! The author, @eslesar, has been notified to review your proposed change.

@4c74356b41 thank you for taking the time to submit a request to make corrections/updates to this article.  I have reviewed them and approve them to be merged.  @sign-off


[WIP]Add bokeh plot

Code was taken from https://github.com/bytesandbrains/ProcessOptimizer with permission
Thanks to @sigurdcarlsen

Hello @holgern! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file skopt/bokeh_plot.py:

Line 7:80: E501 line too long (101 > 79 characters)
Line 91:35: E122 continuation line missing indentation or outdented
Line 139:36: E122 continuation line missing indentation or outdented
Line 143:17: E128 continuation line under-indented for visual indent
Line 151:80: E501 line too long (91 > 79 characters)
Line 234:80: E501 line too long (87 > 79 characters)
Line 237:80: E501 line too long (84 > 79 characters)
Line 239:80: E501 line too long (84 > 79 characters)
Line 260:80: E501 line too long (83 > 79 characters)
Line 261:25: E225 missing whitespace around operator
Line 283:80: E501 line too long (101 > 79 characters)
Line 320:17: E265 block comment should start with '# '
Line 324:80: E501 line too long (80 > 79 characters)
Line 391:80: E501 line too long (81 > 79 characters)
Line 404:8: E114 indentation is not a multiple of four (comment)
Line 474:42: E131 continuation line unaligned for hanging indent
Line 476:54: W291 trailing whitespace
Line 481:61: W291 trailing whitespace
Line 486:42: W291 trailing whitespace
Line 512:61: W291 trailing whitespace
Line 516:42: W291 trailing whitespace


Cant connect to db after opening a new file

Issue Type: Bug
Whenever I open a .sql file and try to connect to an azure sql database I  get...
An unexpected error occurred while connecting. Please file an issue with the title 'Unexpected Error Occurred while Connecting' and include the log file C:\Users\nwicke\AppData\Roaming\azuredatastudio\logs\20210325T104427\renderer1.log
Azure Data Studio version: azuredatastudio 1.27.0 (765c7064d46253d88393e0e1ff78874b6fe8fa64, 2021-03-16T21:24:59.168Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz (4 x 2808)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.83GB (7.76GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (4)

Extension
Author (truncated)
Version

agent
Mic
0.48.0

dacpac
Mic
1.8.0

import
Mic
1.3.0

profiler
Mic
0.11.0

Can you please include the log file here?

Closing as inactive


history-graph caches the image between views

Hi
I have a couple of views which use history-graph but have different entities. When I switch between views, the graph needs a page refresh to get the correct graph.
Home:

  - title: Home
    icon: mdi:home-assistant
    id: home
    cards:
      - type: history-graph
        title: Outside Temperature
        entities:
          - entity: sensor.yr_temperature
            name: YR
          - entity: sensor.owm_temperature
            name: OWM
          - entity: sensor.dark_sky_temperature
            name: Dark Sky

Now off to Living Room:

  - title: Living Room
    id: lr
    cards:
      - type: history-graph
        title: Temperature
        entities:
          - entity: climate.living_room
            name: ac
          - entity: sensor.kitchen_temperature
            name: Kitchen
          - entity: sensor.dark_sky_temperature
            name: outside

Then F5 (refresh), to what Living Room should be like:

Yes I'm seeing this too:
Raspberry Pi 3 B+
Home Assistant: 0.74.1
Hass.io 121
HassOS 1.7 (64bit)
Browser: Google Chrome 67.0.3396.99
Even with cards on the same tab I get mis-matches of entities being plotted on this card type.

I wonder if there is something wrong with the used cacheKey


50-character-long msg popup frequently

I think this needs to be suppressable since some of the problems can be mentioned without 50 character

@VaibhavSys

Added in https://github.com/is-a-dev/fire/commit/b1212c3a55379be5b06ec15982674b42b5bedc0d


Bug in ignore method of EfficientBackdoor class

Hi there. Sara Taheri pointed out the optimaladj package was giving the wrong answer in the following simple example:
treatment = 'T'
outcome = 'Y'

L = []
N = ['T', 'Z1', 'Z2', 'Z3', 'M1', 'M2', 'Y']

G = CausalGraph()
G.add_edges_from([('Z1', 'Z2'),
                  ('Z1', 'T'),
                  ('Z2', 'Z3'),
                  ('Z3', 'Y'),
                  ('T', 'M1'),
                  ('M1','M2'),
                  ('M2', 'Y')])

G.ignore(treatment, outcome, L, N)

The output should be M1, M2, and it is only M2.
Since doWhy has the same implementation as optimaladj, the analogous error in this package. The error is due to a bug in the method that constructs the forbidden set, specificially here. The problem is that when node name has more than one character, each separate character is added to the forbidden set, instead of the whole string.
This PR fixes this and adds new test cases.

thanks @esmucler for adding this fix!


Update to Arches Core version 7.5.x

Need to update to version 7.5 to have latest version when going to PROD

Marking as closed. Any new problems to be addressed in new issue.


Horizontal scroll for particular section

Hi
i have 9 sections totally, need to scroll horizontal for 3 sections.
in the below delegate method i added  these two lines., but still it doesn't work
collectionView.isPagingEnabled = true
layout.defaultScrollViewConfiguration.isPagingEnabled = true
func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize
If i add the below code in viewDidLoad its reflecting to all sections.
let layout = JEKScrollableSectionCollectionViewLayout()
dashBoardCollectionView.collectionViewLayout = layout
can you please help me out from this., please share some sample code(swift) in detail with these possibilities..
Thanks

Hi!
To achieve this, your controller class should conform to JEKCollectionViewDelegateScrollableSectionLayout, and then implement the following method. This example disables scrolling for section 2:
func collectionView(_ collectionView: UICollectionView, layout: JEKScrollableSectionCollectionViewLayout, scrollViewConfigurationForSection section: UInt) -> JEKScrollViewConfiguration? {
    let config = JEKScrollViewConfiguration.default()
    if section == 2 {
        config.isScrollEnabled = false
    }
    return config;
}

You can customize each section in several ways using this method.

Hi!
To achieve this, your controller class should conform to JEKCollectionViewDelegateScrollableSectionLayout, and then implement the following method. This example disables scrolling for section 2:
func collectionView(_ collectionView: UICollectionView, layout: JEKScrollableSectionCollectionViewLayout, scrollViewConfigurationForSection section: UInt) -> JEKScrollViewConfiguration? {
    let config = JEKScrollViewConfiguration.default()
    if section == 2 {
        config.isScrollEnabled = false
    }
    return config;
}

You can customize each section in several ways using this method.

Thanks much.,its working fine..
i have one more query. i have few sections need to display full array count in vertical. like i have 8 cells in one section need to show in vertical, but here its showing in horizontal with 3 cells in screen without scroll.
which delegate method we need to use . please help..

Ah, I think you want to use a flow layout in those sections. Try this method instead:
func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: JEKScrollableSectionCollectionViewLayout, shouldUseFlowLayoutInSection section: Int) -> Bool {
    if section == 2 {
        return true
    }
    return false
}

This way, the whole section should layout like a standard flow layout, meaning that if there are more cells than fit horizontally it will add several rows instead.

Right in the bottom of the file Tests.swift there's an example of this delegate method in Swift.
The signature is func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: JEKScrollableSectionCollectionViewLayout, shouldUseFlowLayoutInSection section: Int) -> Bool {
If that's never called in your delegate, I think I need to see your whole controller class to find the error. Make sure you implemented it in the object set as collectionView.delegate.

i tried with all the possibilities., still i didnt get the right solution.., shouldUseFlowLayoutInSection delegate method is never called.
scrollViewConfigurationForSection this delegate method is calling.
is the below lines mandatory to call., i wrote this two lines in viewDidLoad()
let layout = JEKScrollableSectionCollectionViewLayout()
dashBoardCollectionView.collectionViewLayout = layout
pls let me know if i need to correct anywhere..
Thanks

Right in the bottom of the file Tests.swift there's an example of this delegate method in Swift.
The signature is func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: JEKScrollableSectionCollectionViewLayout, shouldUseFlowLayoutInSection section: Int) -> Bool {
If that's never called in your delegate, I think I need to see your whole controller class to find the error. Make sure you implemented it in the object set as collectionView.delegate.

delegate and datasource is configured through sotryboard., how to implement this below line :
"Make sure you implemented it in the object set as collectionView.delegate."
Thanks

That should be OK. And since the other delegate method is called, I think it's wired up correctly. Very strange that this one ins't. Feels like it might be a typo or spelled incorrectly or something then? Anyway, it's hard for me to help unless you could post your whole controller class

That should be OK. And since the other delegate method is called, I think it's wired up correctly. Very strange that this one isn’t called. Feels like it might be spelled incorrectly or something then? Since the tests pass (and example project works) the library itself should be doing the correct thing. Anyway, it's hard for me to help unless you could post your whole controller class

how to share class file to u., can u provide any email or any other way.?

Send it to<EMAIL_ADDRESS>

Thanks much bro., issue resolved..


Flavor name

Create nova flavors
Use flavor name for tempest
This need the patch JioCloud/puppet-tempest#9 to be merged
Purge unmanaged nova flavors
This is a superset of PRs #401 and #396. The review and merge can be done on all individual PRs or only this PR.
Here are the dependant patches which need to be merged before this one.
JioCloud/puppet-tempest#9
JioCloud/puppet-nova#1
JioCloud/puppet-nova#1
JioCloud/puppet-openstack_extras#2
JioCloud/puppet-openstacklib#1

please test this

please test this

please test this

last failure was an ntp failure on ceph, retrying build

please test this

@hkumarmk @sorenh  from a code/functionality perspective, this is ready to merge, but I think this one requires planning in terms of how it's rolled out to production (it breaks our layouts, I'm not sure if we can expect the existing flavors to be purged if they have images of that flavor type, etc...). I'm happy to say +1, but I think we should move this through CI separately from the rest of the reference architecture changes.

Deleting flavors should be fine without affecting running instances.
Continuous deployment is hosed anyway, so this is hardly more disruptive than anything else anyway. If it works, ship it. There will be period of time of getting things rolling again anyway.


more robust features of Item Query (boolean logic, date ranges)

Hi,
It seems like the selections you make for the Item Query for the Neatline Time plug-in for Omeka uses only AND logic -- so if you select a bunch of things (two tags, or a tag and a Collection name), it will only pull in items that contain both things. It would be useful to insert a few other options: an OR would be helpful (allowing for one query to pull in multiple tags or other identifiers).
Also, since we have to input properly formatted DATE data in our Omeka items to be able to use this timeline, it would be helpful to be able to input a date range for an inquiry (the most useful would be from X to Y dates, but many sites also offer options such as AFTER X, BEFORE X, etc.). Right now, under "Narrow by Specific Fields," looks like you'd have to insert an exact text match for the Date field, rather than treating the Date as a real date.
Not sure how you would implement the Boolean logic on the UI for the Item Query ... perhaps at the top of the page, where you list "The XXX timeline displays items that match the following query," when each search term is displayed, there could be a drop-down menu between each item where you could select AND/OR/NOT? Like this:
Cambodia [AND/OR/NOT] 1800s
(Although I guess this would run into problems of grouping and order of operations, but I'd be happy with just a rudimentary "All of these" or "Any of these" logic, that would be an improvement over "All of these" by default)

There are a variety of filters that we'll need to hook into for this:

search_form_default_action
search_query_types

I'd like to spend a couple of weeks figuring this out, since it's very compelling, but if we can't do it in that time, then we'll need to suggest a feature request to core Omeka.


OptionsWrapper throws NotImplementedException in Add and Remove

I've seen that OptionsWrapper.cs currently throws a NotImplementedException in Add and Remove.
It seems like these are new methods in 2.0 so I'm wondering if they are here by mistake? If not, shouldn't they throw a NotSupportedException?

Yeah those look to be methods that got added accidentally by VS, they aren't implementing any interface methods and can be removed


bug: $state.go() doesn't work inside a resolve

Type: bug
Platform: all
It just doesn't. It should, but it doesn't. I've tried returning a rejected promise but this does not allow the state to redirect. No, I don't think I should be putting this logic into the $stateChangeStart event because it would mean strewing resolve logic i normally disperse through each state all lumped together in one place. It's just bad juju. You can't simply have everything fall on the floor just because a resolve is going to reject.

Greetings @ProLoser!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

@ProLoser  im not sure this is an Ionic bug and Im not sure the behaviour is supported in angular because the routing has not yet completed by error or success. Normally when you return a promise in the resolve, and if this promise fails a $routeChangeError event is fired. You can catch this event with the $rootScope service and do a new $state.go.

@saniyusuf as someone who has contributed to the router's development, I can assure you this behavior does in fact work, and the currently required design is quite poor (catching things in the error event). This would mean I would have to catch all my different resolve errors across the board for all sorts of different reasons in one unified location, vs in the location they were originally created in.
If it's not a direct fault of ionic, then the default build of ionic may be shipping with a dated version of the router (that would be my first guess).

Is there any update on this? I had my controller for route change working before but now my login controller and interceptors no longer work for $ionicHistory.goBack()

Greetings @ProLoser!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


[api-minor] Remove the postMessageTransfers parameter, and thus the ability to manually disable transferring of data, from the API

By transferring, rather than copying, ArrayBuffers between the main- and worker-threads, you can avoid unnecessary allocations by only having one copy of the same data.
Hence manually setting postMessageTransfers: false, when calling getDocument, is a performance footgun[1] which will do nothing but waste memory.
Given that every reasonably modern browser supports postMessage transfers[2], I really don't see why it should be possible to force-disable this functionality.
Looking at the browser support, for postMessage transfers[2], it's highly unlikely that PDF.js is even usable in browsers without it. However, the feature testing of postMessage transfers is kept for the time being just to err on the safe side.

[1] This is somewhat similar to the, now removed, disableWorker parameter which also provided API users a much too simple way of reducing performance.
[2] See e.g. https://developer.mozilla.org/en-US/docs/Web/API/MessagePort/postMessage#Browser_compatibility and https://developer.mozilla.org/en-US/docs/Web/API/Transferable#Browser_compatibility

/botio test

Looks good! I also don't see any reason to keep this around.


[chore](error msg) print type info when colocate with ddl failed due type mismatch

pick #28773

run buildall


customcluster:support kubeImageRepo and cluster setting config

What type of PR is this?
/kind feature
What this PR does / why we need it:
part of #128
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Please give more explict description about what does this pr support, and donot use ambiguous words like more config

ok


Validator v6

Closes #270

Coverage remained the same at 94.619% when pulling 1efdc52b283c5c6e6f84525996532befcc445c6e on validator-v6 into 2bb8fe08b24a41d5bfb4330d709fc5151b109e67 on master.


ERR_DLOPEN_FAILED rerunning tests

Describe the bug

only appears in mac (native module with Napi & object-c)
It works running vitest watching mode
Triggering vitest rerun case following error:

ps:

isolate will solve this problem
I guess it has something to do with tinypool and native module code (napi or object-c)

Reproduction
https://github.com/tangdaoyuan/vitest-bug-reporter
Reproduction Step

pnpm install
pnpm run test
trigger rerun

System Info
System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
    Memory: 740.74 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 16.0.0 - ~/.nvm/versions/node/v16.0.0/bin/node
    npm: 7.10.0 - ~/.nvm/versions/node/v16.0.0/bin/npm
  Browsers:
    Chrome: 103.0.5060.114
    Firefox: 86.0.1
    Safari: 13.1.3
  npmPackages:
    vite: 2.9.14 => 2.9.14
    vitest: 0.18.0 => 0.18.0

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This also happens to me.
Is there any progress on this?

Use --pool=forks if you have a native dependency. A lot of native dependencies don't support multi-threading which Vitest uses by default.


fix: overflow feature now works correctly when menu-bar has "min-width: 0".

The __detectOverflow method was changed. It will now reset visibility of all buttons and then hide any buttons that are overflowing, adding them to the "overflow" button.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Fixes #130

Fixes #130


separate cabbage and perf for different tests

:clipboard: Slack discussion: here
Overview
We want to get mono-repo benefits while keeping integration tests and load tests isolated. Moving priv to priv/cabbage and add new umbrella app priv/perf.
Changes

Move priv to priv/cabbage and fix paths in Makefile, tests, circle ci configs to make it run!
Create new umbrella app perf and add an app under it load_test.
Add a dummy chaperon tests under load_test app.

Testing

testing priv/perf

cd priv/perf
mix deps.get
mix test

Coverage remained the same at ?% when pulling 2f29391d8b1570f7c1cffbded96324aab9c0034c on boolafish/seperate_cabbage_and_perf into d85b93c1e4928815ae4e6274c062c4a7634b2ac7 on master.


I have added a description with my name

Hi Alejando!
Can you please approve my PR

We will check it!


Fix contributing docs

Signed-off-by: Kevin Earls<EMAIL_ADDRESS>Which problem is this PR solving?

Resolves #1758

Short description of the changes

Corrections for out of date text

Not really.  I can put it on a single line if you prefer
On Mon, Feb 21, 2022 at 11:57 AM Pavol Loffay @.***>
wrote:

@.**** commented on this pull request.
In CONTRIBUTING.md
https://github.com/jaegertracing/jaeger-operator/pull/1762#discussion_r811008433
:

Once minikube has finished starting, get the Operator running:

make cert-manager
-IMG=docker.io/$USER/jaeger-operator:latest make generate bundle docker push deploy
+export IMG_PREFIX=docker.io/<dockerusername>
+export IMG=${IMG_PREFIX}/jaeger-operator:latest

any reason why the command is split? The original one is a single like
copy paste and run which is easier to do.

—
Reply to this email directly, view it on GitHub
<https://github.com/jaegertracing/jaeger-operator/pull/1762#pullrequestreview-888517102>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHWJ2GOWVBI5TWLUQBAOXDU4ILAJANCNFSM5O54NLTA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

You are receiving this because you authored the thread.Message ID:
<EMAIL_ADDRESS>


add headers

Without these headers I get a 500 response back from resy on the /find endpoint

@rkass  I am getting 500 response back as well - how do I fix this - I have resy version 0.6.0
Error: failed to fetch slots for date, status code: 500
Usage:
resy book [flags]
Flags:


[MM-26972] Ignore pagination when loading group data

Summary

Skips pagination when calling getGroups in the loadGroupData fn to load all groups instead of just the first 60

Ticket Link

https://mattermost.atlassian.net/browse/MM-26972

Screenshots

60+ Groups loaded

Device Information

Tested on iOS simulator

So if there are 10k or 100k we just fetch them all? Can this be a problem?

For now fetching everything is better than just fetching the first 60, no-one has 10k+ ldap groups enabled at the moment so it shouldnt be an issue but yes this method needs to be improved in the future, but im not exactly sure what the best way would be.
Considering the fact that no customers noticed this bug (despite being there in the webapp since 5.24) there probably isnt a customer with that many groups enabled (else they would have noticed groups not being highlighted since we were only loading 60 into the state)

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/9052
https://circleci.com/gh/mattermost/mattermost-mobile/9050

Artifact links:
https://9052-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa
https://9050-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk


"boost thread: trying joining itself: Resource deadlock avoided" when running rosflight_io

Ubuntu 16.04/kinetic/rosflight compiled from source
branch/fork: https://github.com/tu-darmstadt-ros-pkg/rosflight/tree/enu_output (This is equivalent to master, but with some minor edits to output IMU data in ENU format).
Machine: NUC with Core i5-7260U

When trying to connect to the flight controller running

rosrun rosflight rosflight_io

I get the following:

[ INFO] [1523636817.582107242]: Connecting to serial port "/dev/naze_fc", at 921600 baud
terminate called after throwing an instance of 'boost::exception_detail::clone_impl >'
  what():  boost thread: trying joining itself: Resource deadlock avoided

I tried different USB ports and things started working as expected after plugging the cable into one of them. Afterwards I could also use other USB ports and everything worked as expected. Then I rebooted the system and I couldn't get it to work again, no matter how much USB port switching I'd do. Getting the exception seems to be the default now and I have no idea how to fix it currently.
I noticed the same issue is described in https://github.com/byu-magicc/fcu_io/issues/42. I tried removing the drivers with rmmod, but this did not appear to help.
I also peppered the startup code of the rosflight_io node with sleep calls (as the expection looks like some race conditions/threading issue), but this does not help either.
Here's a gdb backtrace (rosflight compiled in Release mode though, can try Debug later):

(gdb) bt
#0  0x00007ffff634d428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007ffff634f02a in __GI_abort () at abort.c:89
#2  0x00007ffff6c9084d in __gnu_cxx::__verbose_terminate_handler() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3  0x00007ffff6c8e6b6 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x00007ffff6c8e701 in std::terminate() () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff6c8e919 in __cxa_throw () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6  0x00007ffff7bae5fc in void boost::throw_exception(boost::thread_resource_error const&) () from /home/jasmine/argo/devel/.private/rosflight/lib/libmavrosflight.so
#7  0x00007ffff7ba93f7 in mavrosflight::MavlinkComm::close() () from /home/jasmine/argo/devel/.private/rosflight/lib/libmavrosflight.so
#8  0x00007ffff7bb4157 in boost::asio::detail::descriptor_read_op >::do_complete(boost::asio::detail::task_io_service*, boost::asio::detail::task_io_service_operation*, boost::system::error_code const&, unsigned long) () from /home/jasmine/argo/devel/.private/rosflight/lib/libmavrosflight.so
#9  0x00007ffff7badc18 in boost::asio::io_service::run() () from /home/jasmine/argo/devel/.private/rosflight/lib/libmavrosflight.so
#10 0x00007ffff61035d5 in ?? () from /usr/lib/x86_64-linux-gnu/libboost_thread.so.1.58.0
#11 0x00007ffff5edc6ba in start_thread (arg=0x7fffeaffd700) at pthread_create.c:333
#12 0x00007ffff641f41d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Any ideas/hints on how to fix things are appreciated.

Have you verified that you can connect to /dev/naze_fc with other programs, like screen or miniterm, when you're getting this message? That's the error message that also gets thrown if the USB is unplugged while rosflight_io is running, so it'd be good to verify that this problem is specific to rosflight_io and isn't a system level thing.

Ok so after your comment my first suspected culprit was the USB cable. Tried multiple ones, same issues.
Then I tried connecting the FC to another computer running the same S/W setup - worked as intended every single time.
Running screen

screen /dev/ttyUSB0 921600

gives me this kind of stuff running across the screen:

�������!�������������!������������� ������������ �����������L ������������L���������������,!��~��������!�������������!�������������!�����������$!������������`!��������<���A!������������` ������������ ��������� ����������� �����������, ��~���������m ������������!��<���������i!������������!������������ !��}����������!������������E!������������!!�����
      ��                  ����I ������������i!������������(!�����������e!�������������!�����                                                               �����D ������������! ������������� ���������!�� ��}���������������                                                                                �����-!�����������I!�������������!������������!�������a �����������I ������������ ������������� ��������� ������������!��>��������H!�����������h!���������� !��-�    �}���O���L ������������H!�����
                                   �Y?���!�����������Ip��������\���9����������!�����������a!������y��}��`!�����������!�]���������e�������g���� ����������������%!������������!��x�������� ���������`

This (from manual inspection) looks the same on the machine where things are working and the one where I experience the described issue.
Going out on a limb here, but maybe there is some race conditions in MavROS that gets exposed on this relatively fast single-core performance (7th generation i5) CPU (?)

Ok, so I compiled in 'Debug' mode to get a better backtrace and now the problem is gone. Given 'Debug' runs slower, this is another reason to suspect that we're seeing a timing/race condition issue.

So using some console output in 'Release' I could confirm that the expection happens in this line: https://github.com/rosflight/rosflight/blob/master/rosflight/src/mavrosflight/mavlink_comm.cpp#L73 (not very surprising I guess :) ).

That is super interesting.  I'm running 6th gen i7's on several computers and have never seen this, except in the condition @dpkoch described.  How is your computer so fast!?!  Haha!
I've seen a similar problem, but with different conditions, and solved it by resetting the port through linux with
stty -F /dev/ttyUSB0 sane
I wonder if that might help here too, though from what you've said it sounds like something different.


disable .slogs?

NotSoBotBOT - Today at 5:47 PM
[04:47:47 PM]:exclamation: Command Log
User: *****#4827 <208346603642159104>
Command: img

just say .slogs in the channel slogs is enabled again


Parse and validate break/continue

This adds support for break/continue and closes #127.

bors r+

bors r-

Actually, can you add a test for that last bug fix?

Oh, I see you're saying the test didn't fail as expected. Well, ok. Let's just land it.
bors r+


How to handle name changes

I have been wondering how should name changes be reflected in the CFF format.
Say my family-name changes from "A" to "B". Is there a clean way to include both in the CFF format?
The documenation mention that family-names can be double names, thus adding both old and new name could be mistaken for a double name.

Hi @dschwoerer, and welcome to the project. I am not aware of any ongoing or past discussions that cover the use case you describe-- family-names was indeed intended to include double or even more names, but not name changes. Perhaps this is already desired behavior for the format, because one could argue that at the time of a release / publication, each author has one name, either "A" or "B", but not both. I'm guessing the closest thing is to use alias, like so:
authors:
  -
    alias: A
    family-names: B

although a more typical use case for alias would be something like:
authors:
  -
    alias: jspaaks
    family-names: Spaaks
    given-names: "Jurriaan H."

Thanks @dschwoerer!


Updated to 1.1.0.  Suddenly 'ng serve' isn't catching changes automatically...

[ X ] bug report -> please search issues before submitting
[ ] feature request

### Versions.
<!--
Output from: `ng --version`.
@angular/cli: 1.1.0
node: 6.10.3
os: darwin x64
@angular/animations: 4.1.3
@angular/common: 4.1.3
@angular/compiler: 4.1.3
@angular/compiler-cli: 4.1.3
@angular/core: 4.1.3
@angular/forms: 4.1.3
@angular/http: 4.1.3
@angular/platform-browser: 4.1.3
@angular/platform-browser-dynamic: 4.1.3
@angular/platform-server: 4.1.3
@angular/router: 4.1.3
@angular/cli: 1.1.0

macOS Sierra v10.12.5
-->

### Repro steps.
<!--

ng serve

Packs everything fine.  Serves everything fine.  Does *not* automatically notice file-changes.
I changed WebStorm (v 2017.1) so that it *doesn't* save a 'temp' file first -- I disabled "use 'safe write" in Settings | Appearance & Behavior | System Settings, so it's writing to the file(s) directly.

-->

### The log given by the failure.
<!--
No log.  It just completely ignores file-changes.  I have to Ctrl+C and 'ng serve' again when I make a change.  It just started when I upgraded to v 1.1.0 of @angular/cli.  I uninstalled and reinstalled just to be safe.  Same problem.

I *downgraded* back to v1.0.6 of @angular/cli -- and the problem STILL exists...  So I don't know what's going on now...
 -->

Well, I don't know what happened -- but apparently it's only affecting the one project.
After downgrading back to 1.0.6 and still experiencing the same issue, I thought maybe it was something local to the project...
So I created a new project, and 'ng serve' works properly and detects changes on the new project...
So I simply copied the files in 'src/app' to the new project and resumed working like normal...  No clue why it suddenly stopped working for the project I was in...


lock screen picture

Can you upload your origin lock screen picture? I really like it!

Shared :)


Reduce frequency of incident creation/email

Description
Reduces frequency of notifications due to constantly changing amounts
Issues Resolved
N/A
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ x ] New functionality has been documented in the README if applicable
[ x ] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:
Please add labels to this Pull Request

          1 Warning

:warning:
Should this include readme changes

  Generated by :no_entry_sign: Danger


Office online server replacement?

Hi all,
it´s possible to use onlyoffice like office online server?
https://docs.microsoft.com/en-us/officeonlineserver/office-online-server
Best

Hello @unicorn667  yes, Onlyoffice is the best alternative to MS. We have many installation solutions. Please check our site https://www.onlyoffice.com/ for more information. Or contact our sales department<EMAIL_ADDRESS>

Closed for a reason - there has been no activity for a long time.


APM not working with typescript, lambda, serverless

Application Performance Monitoring Question Template
I am using typescript and serverless to deploy to lambda, i followed this article: https://docs.newrelic.com/docs/serverless-function-monitoring/aws-lambda-monitoring/get-started/enable-serverless-monitoring-aws-lambda#connect-aws
I am using node v12 as well
serverless version: v2.1.1
When i deploy I get this error:
ERROR	Error: Cannot find module './newrelic-lambda-wrapper.js'
Require stack:
- /var/task/s_api.js
- /var/runtime/UserFunction.js
- /var/runtime/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:966:15)
    at Module._require.o.require (/var/task/serverless_sdk/index.js:9:72934)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/var/task/s_api.js:25:23)
    at Module._compile (internal/modules/cjs/loader.js:1138:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
    at Module.load (internal/modules/cjs/loader.js:986:32)
    at Function.Module._load (internal/modules/cjs/loader.js:879:14)
    at Module.require (internal/modules/cjs/loader.js:1026:19)
    at require (internal/modules/cjs/helpers.js:72:18) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/var/task/s_api.js',
    '/var/runtime/UserFunction.js',
    '/var/runtime/index.js'
  ]
}

I also tried to add it manually with the node module and adding the config file.  When it runs i keep getting this:
	    2020-09-14T23:36:05.877-04:00

		{
		    "v": 0,
		    "level": 30,
		    "name": "newrelic_bootstrap",
		    "hostname": "<IP_ADDRESS>",
		    "pid": 8,
		    "time": "2020-09-15T03:36:03.415Z",
		    "msg": "Cross application tracing is explicitly disabled in serverless_mode."
		}

		{"v":0,"level":30,"name":"newrelic_bootstrap","hostname":"<IP_ADDRESS>","pid":8,"time":"2020-09-15T03:36:03.415Z","msg":"Cross application tracing is explicitly disabled in serverless_mode."}

		2020-09-14T23:36:05.877-04:00

		{
		    "v": 0,
		    "level": 30,
		    "name": "newrelic_bootstrap",
		    "hostname": "<IP_ADDRESS>",
		    "pid": 8,
		    "time": "2020-09-15T03:36:03.416Z",
		    "msg": "Logging is disabled by default when serverless_mode is enabled. If desired, enable logging via config file or environment variable and set filepath to a valid path for current environment, stdout or stderr."
		}

		{"v":0,"level":30,"name":"newrelic_bootstrap","hostname":"<IP_ADDRESS>","pid":8,"time":"2020-09-15T03:36:03.416Z","msg":"Logging is disabled by default when serverless_mode is enabled. If desired, enable logging via config file or environment variable and set filepath to a valid path for current environment, stdout or stderr."}

		2020-09-14T23:36:05.877-04:00

		{
		    "v": 0,
		    "level": 30,
		    "name": "newrelic_bootstrap",
		    "hostname": "<IP_ADDRESS>",
		    "pid": 8,
		    "time": "2020-09-15T03:36:03.416Z",
		    "msg": "The native-metrics module is disabled by default when serverless_mode is enabled.  If desired, enable the native-metrics module via config file or environment variable."
		}

		{"v":0,"level":30,"name":"newrelic_bootstrap","hostname":"<IP_ADDRESS>","pid":8,"time":"2020-09-15T03:36:03.416Z","msg":"The native-metrics module is disabled by default when serverless_mode is enabled. If desired, enable the native-metrics module via config file or environment variable."}

		2020-09-14T23:36:05.878-04:00

		{
		    "v": 0,
		    "level": 30,
		    "name": "newrelic_bootstrap",
		    "hostname": "<IP_ADDRESS>",
		    "pid": 8,
		    "time": "2020-09-15T03:36:05.746Z",
		    "msg": "Cross application tracing is explicitly disabled in serverless_mode."
		}

		{"v":0,"level":30,"name":"newrelic_bootstrap","hostname":"<IP_ADDRESS>","pid":8,"time":"2020-09-15T03:36:05.746Z","msg":"Cross application tracing is explicitly disabled in serverless_mode."}

		2020-09-14T23:36:05.878-04:00

		{
		    "v": 0,
		    "level": 30,
		    "name": "newrelic_bootstrap",
		    "hostname": "<IP_ADDRESS>",
		    "pid": 8,
		    "time": "2020-09-15T03:36:05.746Z",
		    "msg": "Logging is disabled by default when serverless_mode is enabled. If desired, enable logging via config file or environment variable and set filepath to a valid path for current environment, stdout or stderr."
		}

		{"v":0,"level":30,"name":"newrelic_bootstrap","hostname":"<IP_ADDRESS>","pid":8,"time":"2020-09-15T03:36:05.746Z","msg":"Logging is disabled by default when serverless_mode is enabled. If desired, enable logging via config file or environment variable and set filepath to a valid path for current environment, stdout or stderr."}

		2020-09-14T23:36:05.878-04:00

		{
		    "v": 0,
		    "level": 30,
		    "name": "newrelic_bootstrap",
		    "hostname": "<IP_ADDRESS>",
		    "pid": 8,
		    "time": "2020-09-15T03:36:05.746Z",
		    "msg": "The native-metrics module is disabled by default when serverless_mode is enabled.  If desired, enable the native-metrics module via config file or environment variable."
		}

Any ideas on whats going on?

Sorry you're having trouble, @svarughese91. Thanks for the report.
With the manual method, do you have the NEW_RELIC_SERVERLESS_MODE_ENABLED environment variable set on your lambda function? If so, try removing that environment variable entirely.

@svarughese91 Can you provide your serverless.yml? (be sure to omit any secrets)
The newrelic-lambda-wrapper module is provided by the layer, but './newrelic-lambda-wrapper.js' is a relative import and doesn't look right.

Sure yes here is the serverless.yml
name: Dev Deploy

on:
  push:
    branches: [ dev ]

env:
  SERVERLESS_ACCESS_KEY: ${{ secrets.XXXXXXXX}}
  AUTH0CLIENTID: ${{ secrets.XXXXXXXX }}
  AUTH0CLIENTSECRET: ${{ secrets.XXXXXXXX }}
  AUTH0_IDENTIFIER: https://XXXXXXXX.com
  NODE_ENV: dev

jobs:
  test:
    name: Test
    runs-on: ubuntu-latest
    steps:
      # Send Slack message at start of deploy
    - uses<EMAIL_ADDRESS>      name: Slack Notification
      env:
        SLACK_CHANNEL: build-automation
        SLACK_COLOR: '#3278BD'
        SLACK_ICON: XXXXXXXX
        SLACK_MESSAGE: 'Starting test'
        SLACK_TITLE: Dev Test Deploy
        SLACK_USERNAME: Tesr-CICD
        SLACK_WEBHOOK: ${{ secrets.XXXXXXXX }}
      # Check out from repo and setup node environment
    - uses: actions/checkout@v2
    - name: Cache node modules
      uses: actions/cache@v1
      env:
        cache-name: cache-node-modules
      with:
        path: ~/.npm # npm cache files are stored in `~/.npm` on Linux/macOS
        key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
        restore-keys: |
          ${{ runner.os }}-build-${{ env.cache-name }}-
          ${{ runner.os }}-build-
          ${{ runner.os }}-
    - uses: actions/setup-node@v1
      with:
        node-version: '10.x'
    - run: npm install
    - run: npm run test
      #On failure send slack message
    - uses<EMAIL_ADDRESS>      if: failure()
      name: Slack Notification
      env:
        SLACK_CHANNEL: build-automation
        SLACK_COLOR: '#FC100D'
        SLACK_ICON:XXXXXXXX
        SLACK_MESSAGE: ':rotating_light: Dev Test Deployment Failure'
        SLACK_TITLE: Dev Test Deploy Failure
        SLACK_USERNAME: XXXXXXXX
        SLACK_WEBHOOK: ${{ secrets.XXXXXXXX }}

  deploy:
    name: deploy
    runs-on: ubuntu-latest
    needs: [test]
    steps:
    - uses: actions/checkout@v2
    - name: Cache node modules
      uses: actions/cache@v1
      env:
        cache-name: cache-node-modules
      with:
        path: ~/.npm # npm cache files are stored in `~/.npm` on Linux/macOS
        key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
        restore-keys: |
          ${{ runner.os }}-build-${{ env.cache-name }}-
          ${{ runner.os }}-build-
          ${{ runner.os }}-
    - uses: actions/setup-node@v1
      with:
        node-version: '10.x'
    - run: npm install -g serverless
    - run: npm install
    - name: Deploy Dev
      run: npm run deploy:dev
      #On succces send slack message
    - uses<EMAIL_ADDRESS>      if: success()
      name: Slack Notification
      env:
        SLACK_CHANNEL: build-automation
        SLACK_COLOR: '#28a745'
        SLACK_ICON: XXXXXXXX
        SLACK_MESSAGE: 'Dev Test Deployed :rocket:'
        SLACK_TITLE: Dev Test Deploy Complete
        SLACK_USERNAME: XXXXXXXX
        SLACK_WEBHOOK: ${{ secrets.XXXXXXXX }}
      #On failure send slack message
    - uses<EMAIL_ADDRESS>      if: failure()
      name: Slack Notification
      env:
        SLACK_CHANNEL: build-automation
        SLACK_COLOR: '#FC100D'
        SLACK_ICON: XXXXXXXX
        SLACK_MESSAGE: ':rotating_light: Dev Test Deployment Failure'
        SLACK_TITLE: Dev Test Deploy Failure
        SLACK_USERNAME: XXXXXXXX
        SLACK_WEBHOOK: ${{ secrets.XXXXXXXX }}

@svarughese91 That should be enough to get you deploying...though I am wondering about that newrelic-lambda-wrapper.js--are you referencing that as an import or require in your function code?

nope its not being referenced in the code, if i remove:   - serverless-newrelic-lambda-layers from the serverless yaml it deploys fine, which indicates it could be something with the plugin?

@svarughese91 Thank you!  Just out of curiosity, if you deploy a test function into a different region, does it deploy correctly, or is it the same error?

@svarughese91 I've done a successful deployment/invocation of a clean test function in us-east-1, with this minimal package.json and serverless.yml:
package.json:
{
  "devDependencies": {
    "serverless-newrelic-lambda-layers": "^0.2.3"
  }
}

serverless.yml:
service: deploymenttest

frameworkVersion: '2'

provider:
  name: aws
  runtime: nodejs12.x
  timeout: 6
  region: us-east-1
  logRetentionInDays: 1

functions:
  deployTest:
    handler: handler.deployTest

plugins:
  - serverless-newrelic-lambda-layers

custom:
  newRelic:
    accountId: {$env:myAccountId}

Would you be able to share your package.json?

Interesting and did you get any errors?  Of course, here is the package.json
{
  "name": "test",
  "version": "1.0.0",
  "description": "TekDash test microservice",
  "main": "index.js",
  "scripts": {
    "test": "npm run build && jest --coverage --coverageDirectory=output/coverage/jest --forceExit && jest --ci --reporters=default --reporters=jest-junit  --forceExit",
    "test:serverless": "serverless invoke local --function hello",
    "build": "tsc",
    "deploy:prod": "npm run build && serverless deploy --stage prod",
    "deploy:dev": "npm run build && serverless deploy --stage dev"
  },
  "repository": {
    "type": "git",
    "url": "git+https://github.com/svarughese91/microservice_test.git"
  },
  "author": "TekDash Inc",
  "license": "ISC",
  "bugs": {
    "url": "https://github.com/svarughese91/microservice_test/issues"
  },
  "homepage": "https://github.com/svarughese91/microservice_test#readme",
  "dependencies": {
    "@types/jest": "^25.1.1",
    "@types/joi": "^14.3.4",
    "@types/node": "^13.5.3",
    "cors": "^2.8.5",
    "express": "^4.17.1",
    "express-jwt": "^6.0.0",
    "jest": "^25.1.0",
    "jest-junit": "^10.0.0",
    "joi": "^17.1.1",
    "jwks-rsa": "^1.6.2",
    "moment": "^2.27.0",
    "mongoose": "^5.8.10",
    "newrelic": "^6.13.0",
    "request": "^2.88.0",
    "serverless-domain-manager": "^3.3.1",
    "serverless-http": "^2.3.1",
    "serverless-iam-roles-per-function": "^2.0.2",
    "simple-crypto-js": "^3.0.0",
    "ts-jest": "^25.1.0",
    "typescript": "^3.8.3",
    "winston": "^3.3.3"
  },
  "devDependencies": {
    "serverless-newrelic-lambda-layers": "^0.2.3"
  }
}

Interesting and did you get any errors? Of course, here is the package.json

@svarughese91 Thanks! No errors from my minimal setup. I'm curious about how it'll interact with those dependencies, though--and we've found some issues relating to some dependencies as well. (We have a patch for some of those problems being released shortly.)

ok i just tried to deploy with this version and i am getting new errors:
2020-09-23T13:07:37.6199457Z Serverless: Invoke deploy
2020-09-23T13:07:37.6216668Z Serverless: Invoke package
2020-09-23T13:07:37.6226231Z Serverless: Invoke aws:common:validate
2020-09-23T13:07:37.6232182Z Serverless: Invoke aws:common:cleanupTempDir
2020-09-23T13:07:37.6282107Z Serverless: Plugins: ["serverless-domain-manager","serverless-iam-roles-per-function","serverless-newrelic-lambda-layers"]
2020-09-23T13:07:37.6284328Z Serverless: Adding NewRelic layer to api
2020-09-23T13:07:37.9352441Z
2020-09-23T13:07:37.9359266Z   Syntax Error -------------------------------------------
2020-09-23T13:07:37.9359778Z
2020-09-23T13:07:37.9362061Z   SyntaxError: Unexpected token u in JSON at position 0
2020-09-23T13:07:37.9362851Z   SyntaxError: Unexpected token u in JSON at position 0
2020-09-23T13:07:37.9363513Z       at JSON.parse (<anonymous>)
2020-09-23T13:07:37.9365276Z       at request.then.response (/home/runner/work/microservice_test/microservice_test/node_modules/serverless-newrelic-lambda-layers/dist/index.js:264:38)
2020-09-23T13:07:37.9366769Z       at process._tickCallback (internal/process/next_tick.js:68:7)
2020-09-23T13:07:37.9367424Z   From previous event:
2020-09-23T13:07:37.9368533Z       at PluginManager.invoke (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/lib/classes/PluginManager.js:498:22)
2020-09-23T13:07:37.9370097Z       at PluginManager.spawn (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/lib/classes/PluginManager.js:518:17)
2020-09-23T13:07:37.9371519Z       at BbPromise.try (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/lib/plugins/deploy/deploy.js:122:50)
2020-09-23T13:07:37.9372382Z   From previous event:
2020-09-23T13:07:37.9373438Z       at Object.before:deploy:deploy [as hook] (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/lib/plugins/deploy/deploy.js:102:22)
2020-09-23T13:07:37.9374920Z       at BbPromise.reduce (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/lib/classes/PluginManager.js:498:55)
2020-09-23T13:07:37.9375848Z   From previous event:
2020-09-23T13:07:37.9376907Z       at PluginManager.invoke (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/lib/classes/PluginManager.js:498:22)
2020-09-23T13:07:37.9378473Z       at getHooks.reduce.then (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/lib/classes/PluginManager.js:533:24)
2020-09-23T13:07:37.9379446Z   From previous event:
2020-09-23T13:07:37.9380489Z       at PluginManager.run (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/lib/classes/PluginManager.js:533:8)
2020-09-23T13:07:37.9382146Z       at variables.populateService.then (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/lib/Serverless.js:168:33)
2020-09-23T13:07:37.9383496Z   From previous event:
2020-09-23T13:07:37.9384437Z       at Serverless.run (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/lib/Serverless.js:155:74)
2020-09-23T13:07:37.9385896Z       at serverless.init.then.then (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/scripts/serverless.js:50:26)
2020-09-23T13:07:37.9386959Z       at runCallback (timers.js:705:18)
2020-09-23T13:07:37.9387577Z       at tryOnImmediate (timers.js:676:5)
2020-09-23T13:07:37.9388381Z       at processImmediate (timers.js:658:5)
2020-09-23T13:07:37.9389292Z       at process.topLevelDomainCallback (domain.js:126:23)
2020-09-23T13:07:37.9390094Z   From previous event:
2020-09-23T13:07:37.9391022Z       at Object.<anonymous> (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/scripts/serverless.js:50:4)
2020-09-23T13:07:37.9392042Z       at Module._compile (internal/modules/cjs/loader.js:778:30)
2020-09-23T13:07:37.9392955Z       at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
2020-09-23T13:07:37.9393846Z       at Module.load (internal/modules/cjs/loader.js:653:32)
2020-09-23T13:07:37.9394626Z       at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
2020-09-23T13:07:37.9395485Z       at Function.Module._load (internal/modules/cjs/loader.js:585:3)
2020-09-23T13:07:37.9396436Z       at Module.require (internal/modules/cjs/loader.js:692:17)
2020-09-23T13:07:37.9397332Z       at require (internal/modules/cjs/helpers.js:25:18)
2020-09-23T13:07:37.9398367Z       at Object.<anonymous> (/opt/hostedtoolcache/node/10.22.0/x64/lib/node_modules/serverless/bin/serverless.js:47:1)
2020-09-23T13:07:37.9399353Z       at Module._compile (internal/modules/cjs/loader.js:778:30)
2020-09-23T13:07:37.9400252Z       at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
2020-09-23T13:07:37.9401134Z       at Module.load (internal/modules/cjs/loader.js:653:32)
2020-09-23T13:07:37.9401929Z       at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
2020-09-23T13:07:37.9402767Z       at Function.Module._load (internal/modules/cjs/loader.js:585:3)
2020-09-23T13:07:37.9403736Z       at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
2020-09-23T13:07:37.9404581Z       at startup (internal/bootstrap/node.js:283:19)
2020-09-23T13:07:37.9405393Z       at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
2020-09-23T13:07:37.9405980Z
2020-09-23T13:07:37.9406696Z   Get Support --------------------------------------------
2020-09-23T13:07:37.9407282Z      Docs:          docs.serverless.com
2020-09-23T13:07:37.9408005Z      Bugs:          github.com/serverless/serverless/issues
2020-09-23T13:07:37.9408726Z      Issues:        forum.serverless.com
2020-09-23T13:07:37.9409213Z
2020-09-23T13:07:37.9409913Z   Your Environment Information ---------------------------
2020-09-23T13:07:37.9410513Z      Operating System:          linux
2020-09-23T13:07:37.9411014Z      Node Version:              10.22.0
2020-09-23T13:07:37.9411516Z      Framework Version:         2.1.1
2020-09-23T13:07:37.9412021Z      Plugin Version:            4.0.4
2020-09-23T13:07:37.9412493Z      SDK Version:               2.3.2
2020-09-23T13:07:37.9413030Z      Components Version:        3.1.4
2020-09-23T13:07:37.9413451Z
2020-09-23T13:07:37.9531847Z npm ERR! code ELIFECYCLE
2020-09-23T13:07:37.9532508Z npm ERR! errno 1
2020-09-23T13:07:37.9553940Z npm ERR<EMAIL_ADDRESS>deploy:dev: `npm run build && serverless deploy --stage dev`
2020-09-23T13:07:37.9554685Z npm ERR! Exit status 1
2020-09-23T13:07:37.9555118Z npm ERR!
2020-09-23T13:07:37.9555718Z npm ERR! Failed at the<EMAIL_ADDRESS>deploy:dev script.
2020-09-23T13:07:37.9556698Z npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
2020-09-23T13:07:37.9631964Z
2020-09-23T13:07:37.9633514Z npm ERR! A complete log of this run can be found in:
2020-09-23T13:07:37.9637155Z npm ERR!     /home/runner/.npm/_logs/2020-09-23T13_07_37_955Z-debug.log
2020-09-23T13:07:37.9700196Z ##[error]Process completed with exit code 1.

@svarughese91 Thank you for the report! I'm getting a fix ready.

@svarughese91 Can you test a deploy after commenting out the following lines?
org: xxxxxxx
app: test-api

Commenting out these lines will disable Serverless' monitoring, which may be conflicting with New Relic.

@svarughese91 I also have a fix for the latest error in https://github.com/newrelic/serverless-newrelic-lambda-layers/pull/77; that should resolve the json response parsing issue.

@svarughese91 The fix was included in v0.2.5.

I updated to version 0.2.5.  It deploys now but i am still getting these errors:
2020-09-23T22:26:39.529Z	d5d4d15f-0e4c-4eb6-9faf-f8cdbfadf38f	ERROR	Error: Cannot find module './newrelic-lambda-wrapper.js'
Require stack:
- /var/task/s_api.js
- /var/runtime/UserFunction.js
- /var/runtime/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Module._require.o.require (/var/task/serverless_sdk/index.js:9:72934)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/var/task/s_api.js:25:23)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/var/task/s_api.js',
    '/var/runtime/UserFunction.js',
    '/var/runtime/index.js'
  ]
}

and this:
2020-09-23T22:26:39.536Z	d5d4d15f-0e4c-4eb6-9faf-f8cdbfadf38f	ERROR	Invoke Error
{
    "errorType": "Error",
    "errorMessage": "Cannot find module './newrelic-lambda-wrapper.js'\nRequire stack:\n- /var/task/s_api.js\n- /var/runtime/UserFunction.js\n- /var/runtime/index.js",
    "code": "MODULE_NOT_FOUND",
    "requireStack": [
        "/var/task/s_api.js",
        "/var/runtime/UserFunction.js",
        "/var/runtime/index.js"
    ],
    "stack": [
        "Error: Cannot find module './newrelic-lambda-wrapper.js'",
        "Require stack:",
        "- /var/task/s_api.js",
        "- /var/runtime/UserFunction.js",
        "- /var/runtime/index.js",
        "    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)",
        "    at Module._require.o.require (/var/task/serverless_sdk/index.js:9:72934)",
        "    at require (internal/modules/cjs/helpers.js:72:18)",
        "    at Object.<anonymous> (/var/task/s_api.js:25:23)",
        "    at Module._compile (internal/modules/cjs/loader.js:1137:30)",
        "    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)",
        "    at Module.load (internal/modules/cjs/loader.js:985:32)",
        "    at Function.Module._load (internal/modules/cjs/loader.js:878:14)",
        "    at Module.require (internal/modules/cjs/loader.js:1025:19)",
        "    at require (internal/modules/cjs/helpers.js:72:18)"
    ]
}

@svarughese91 Did you comment out the lines I mentioned earlier?

yes i tried deploying without app and org but was getting errors deploying because serverless deployed the cloudfoundation resources.  Is there something else i can try?

@svarughese91 Could you try a sls remove -f {functionName} and then try deploying again?

so it looks like that worked! it does not give the error anymore but that being said i still dont see the data in new relic and i get these logs so it seems like its not doing anything:
2020-09-25T18:03:49.365-04:00Copy{     "v": 0,     "level": 30,     "name": "newrelic_bootstrap",     "hostname": "<IP_ADDRESS>",     "pid": 8,     "time": "2020-09-25T22:03:47.775Z",     "msg": "Cross application tracing is explicitly disabled in serverless_mode." } | {"v":0,"level":30,"name":"newrelic_bootstrap","hostname":"<IP_ADDRESS>","pid":8,"time":"2020-09-25T22:03:47.775Z","msg":"Cross application tracing is explicitly disabled in serverless_mode."}
-- | --
  | 2020-09-25T18:03:49.365-04:00Copy{     "v": 0,     "level": 30,     "name": "newrelic_bootstrap",     "hostname": "<IP_ADDRESS>",     "pid": 8,     "time": "2020-09-25T22:03:47.775Z",     "msg": "Logging is disabled by default when serverless_mode is enabled. If desired, enable logging via config file or environment variable and set filepath to a valid path for current environment, stdout or stderr." } | {"v":0,"level":30,"name":"newrelic_bootstrap","hostname":"<IP_ADDRESS>","pid":8,"time":"2020-09-25T22:03:47.775Z","msg":"Logging is disabled by default when serverless_mode is enabled. If desired, enable logging via config file or environment variable and set filepath to a valid path for current environment, stdout or stderr."}
  | 2020-09-25T18:03:49.365-04:00Copy{     "v": 0,     "level": 30,     "name": "newrelic_bootstrap",     "hostname": "<IP_ADDRESS>",     "pid": 8,     "time": "2020-09-25T22:03:47.775Z",     "msg": "The native-metrics module is disabled by default when serverless_mode is enabled.  If desired, enable the native-metrics module via config file or environment variable." }

@svarughese91 Those log messages are coming from the New Relic agent, so it is present and running. When you run sls logs -f (function name) do you see any log lines like this?
[1,"NR_LAMBDA_MONITORING","..."]

Where the ... is a base64 encoded string? If so, then the agent is reporting and the issue is downstream. If downstream, you'll want to look at the logs of your newrelic-log-ingestion function to see if it is getting these NR_LAMBDA_MONITORING payloads. If you're not seeing NR_LAMBDA_MONITORING log lines, then there's still an issue with how the function is instrumented.

@svarughese91 Do you see a payload? It'd be a CloudWatch log line that looks like
[1, "NR_LAMBDA_MONITORING", "a very long base64 string"]

If you don't see a line like that in the CW logs, check to see if your function has an environment variable NEW_RELIC_SERVERLESS_MODE_ENABLED. If so, just remove that environment variable.

yes i do see that payload

OK. That suggests that there's instrumentation, but it's not being delivered. I'd suggest installing the https://github.com/newrelic/newrelic-lambda-cli if you haven't already, and then
newrelic-lambda functions list

Do you see your function in the output? Does it say the CW log subscription is installed?  If not, you can use the cli to install the subscription:
newrelic-lambda subscriptions install --function <name or arn>

(You may need to add aws-region or another flag; if so, you'll be prompted by the output.)
If you do see that your function's got a subscription, then we should look to make sure your other env vars are correct. For example, if your NR account is a sub-account, you need to specify the main account ID as the value of the  NEW_RELIC_TRUSTED_ACCOUNT_KEY env var.
If you've done these and everything looks correct except for no instrumentation in NR...let's take a look at the env vars.

so it looks like it does have a subscription.  Here are the env variables that are configured:
NEW_RELIC_ACCOUNT_ID | XXXXXXX
NEW_RELIC_APP_NAME | test2-api-dev
NEW_RELIC_LAMBDA_HANDLER | build/app.handler
NEW_RELIC_NO_CONFIG_FILE | true
NEW_RELIC_TRUSTED_ACCOUNT_KEY

OK, good that there's a subscription. Is your NR account a main account of its own, or is it a sub-account of another? If you have just the one account, both NEW_RELIC_ACCOUNT_ID and NEW_RELIC_TRUSTED_ACCOUNT_KEY should be set to your account ID.
If, on the other hand, your account is a sub-account of a parent account, the env vars should be
NEW_RELIC_ACCOUNT_ID: id_of_your_account
NEW_RELIC_TRUSTED_ACCOUNT_KEY: id_of_the_parent_account

yeah i have 1 account and it looks like both NEW_RELIC_ACCOUNT_ID and NEW_RELIC_TRUSTED_ACCOUNT_KEY are set

@svarughese91 If they're set to the same value, should be right. What happens when you invoke the function? Do you see anything appear in the function's overview on NR? (You can find it using the Entity Explorer.)

@mrickard Sorry I guess i wasnt looking in the right spot i am seeing the data in entity explorer.  So its working now WITHOUT hooking it up to serverless monitoring.  The problem is all my lambda functions use serverless monitoring, is there a fix to allow this?

@svarughese91 I recommend contacting New Relic Support about this. They can review your New Relic and AWS setup via a screen share to get to the bottom of why it isn't working.

Closing this issue as the 0.2.5 release resolves the plugin-related problems. Thank you for reporting, @svarughese91 !

I am using 0.2.5 but the issues still persists. Following is the error code:
{     "errorType": "Error",     "errorMessage": "Cannot find module './newrelic-lambda-wrapper.js'\nRequire stack:\n- /var/task/s_app.js\n- /var/runtime/UserFunction.js\n- /var/runtime/index.js",     "code": "MODULE_NOT_FOUND",     "requireStack": [         "/var/task/s_app.js",         "/var/runtime/UserFunction.js",         "/var/runtime/index.js"     ],     "stack": [         "Error: Cannot find module './newrelic-lambda-wrapper.js'",         "Require stack:",         "- /var/task/s_app.js",         "- /var/runtime/UserFunction.js",         "- /var/runtime/index.js",         "    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)",         "    at Module._require.o.require (/var/task/serverless_sdk/index.js:9:72934)",         "    at require (internal/modules/cjs/helpers.js:72:18)",         "    at Object.<anonymous> (/var/task/s_app.js:25:23)",         "    at Module._compile (internal/modules/cjs/loader.js:1137:30)",         "    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)",         "    at Module.load (internal/modules/cjs/loader.js:985:32)",         "    at Function.Module._load (internal/modules/cjs/loader.js:878:14)",         "    at Module.require (internal/modules/cjs/loader.js:1025:19)",         "    at require (internal/modules/cjs/helpers.js:72:18)"     ] }

@roysailor Is this for a function that you're also monitoring simultaneously with Serverless?

@roysailor If you have org and app lines in your serverless.yml, try commenting them out and see if that fixes it. Serverless' monitoring can conflict with this plugin.


Optionally disable mpi4py imports with an env flag

This allows for the same environment to run on a compute node (where mpi4py should work) and a login node (where mpi4py often doesn't work) on HPC systems.

This PR corresponds to the patch in https://github.com/conda-forge/distarray-feedstock/pull/4.  The changes are equivalent to https://github.com/CDAT/cdms/pull/428 and https://github.com/CDAT/cdms/pull/438 in cdms2, and uses the same flag CDMS_NO_MPI=True for convenience.

@jasonb5, this is ready to review.

LGTM I'll get this merged.


Understand how to use leggedodometry with the knowledge of foot position

While using the legged odometry I noticed a strange behavior.
I initialized the estimator with the following paramateres
sampling_period_in_s            0.001

[ModelInfo]
base_link                       "root_link"
base_link_imu                   "root_link"
left_foot_contact_frame         "l_foot"
right_foot_contact_frame        "r_foot"

[LeggedOdom]
initial_fixed_frame             "l_sole"
switching_pattern               "external"

Then I tried to use it as follows
    m_floatingBaseEstimator.changeFixedFrame(contactListMap["left_foot"].defaultIndex(),
                                             contactListMap["left_foot"].firstContact()->pose.quat(),
                                             contactListMap["left_foot"].firstContact()->pose.translation());
    m_floatingBaseEstimator.setKinematics(m_currentJointPos, m_currentJointVel);
    m_floatingBaseEstimator.advance();

    m_baseTransform = m_floatingBaseEstimator.getOutput().basePose;
    m_baseVelocity = m_floatingBaseEstimator.getOutput().baseTwist;

Independently on the content of contactListMap["left_foot"].firstContact()->pose,
m_baseTransform is always equal to
base pose   0.0234848  -0.0798684    0.601393   -0.051003 0.000236203    0.998698 0.000178679

For instance (notice the different value stored in left foot pose). The pose vector contains [x y z qx qy qz qw]
Index 53 l_sole
left foot pose 0 7 0 0 0 0 1
base pose   0.0234848  -0.0798684    0.601393   -0.051003 0.000236203    0.998698 0.000178679

or
Index 53 l_sole
left foot pose 0 0.07 0 0 0 0 1
base pose   0.0234848  -0.0798684    0.601393   -0.051003 0.000236203    0.998698 0.000178679

Should I initialize the estimator in some way? I'm expecting that m_floatingBaseEstimator.changeFixedFrame() is used to translate/rotate the base.
cc @prashanthr05

Try to call the changeFixedFrame() after calling advance(). Since, within the advance() as a first step, we set the robot state for the kindyncomputations, The changeFixedFrame()  computes relative transforms which depends on the robot state to be set.

I tried
    m_floatingBaseEstimator.setKinematics(m_currentJointPos, m_currentJointVel);
    m_floatingBaseEstimator.advance();

    m_floatingBaseEstimator.changeFixedFrame(contactListMap["left_foot"].defaultIndex(),
                                             contactListMap["left_foot"].firstContact()->pose.quat(),
                                             contactListMap["left_foot"].firstContact()->pose.translation());

but nothing changed.
Also this is not working
    m_floatingBaseEstimator.setKinematics(m_currentJointPos, m_currentJointVel);
    m_floatingBaseEstimator.advance();

    m_floatingBaseEstimator.changeFixedFrame(contactListMap["left_foot"].defaultIndex(),
                                             contactListMap["left_foot"].firstContact()->pose.quat(),
                                             contactListMap["left_foot"].firstContact()->pose.translation());

    m_floatingBaseEstimator.advance();

I printed the content of the following variables
https://github.com/dic-iit/bipedal-locomotion-framework/blob/665e04d5af781f4df0c23e96c7c21444cffed6d3/src/Estimators/src/LeggedOdometry.cpp#L482-L485
m_world_H_fixedFrame     0 -0.07     0     0     0     0     1
fixedFrame_H_imu   0.0234823  -0.0799371     0.60138  -0.0509665 9.69215e-05      0.9987 0.000130399
world_H_imu   0.0234823   -0.149937     0.60138  -0.0509665 9.69215e-05      0.9987 0.000130399

Do you think are fine?

Just noticed the parameter value you were passing for switching_pattern.
It must be external -> useExternal. Looks like, since this is wrong, it considers the default value latest which chooses the latest contact from the list of contacts. However, in this case we are not filling the contact measurements using m_floatingBaseEstimator.setContactStatus() method, so there are not contacts and thus, the base pose doesn't seem to be updated at all.

Here you can find a working receipt to use legged odometry plus FixedFootDetector class


Update KV

Codecov Report

Merging #1093 into master will decrease coverage by <.01%.
The diff coverage is 98.38%.

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   56.48%   56.48%   -0.01%
==========================================
  Files        2027     2027
  Lines       57061    57051      -10
==========================================
- Hits        32231    32224       -7
+ Misses      24830    24827       -3

Impacted Files
Coverage Δ

...eyvault/generated/models/certificate_attributes.py
100% <ø> (ø)
:arrow_up:

...keyvault/generated/models/key_create_parameters.py
100% <ø> (ø)
:arrow_up:

...keyvault/azure/mgmt/keyvault/models/permissions.py
57.14% <ø> (ø)
:arrow_up:

...mt-keyvault/azure/mgmt/keyvault/models/resource.py
100% <ø> (ø)
:arrow_up:

...ure/keyvault/generated/models/backup_key_result.py
100% <ø> (ø)
:arrow_up:

...re-mgmt-keyvault/azure/mgmt/keyvault/models/sku.py
100% <ø> (ø)
:arrow_up:

...yvault/azure/keyvault/generated/models/key_item.py
100% <ø> (ø)
:arrow_up:

...-mgmt-keyvault/azure/mgmt/keyvault/models/vault.py
100% <ø> (ø)
:arrow_up:

...re/keyvault/generated/models/issuer_credentials.py
100% <ø> (ø)
:arrow_up:

...keyvault/generated/models/administrator_details.py
100% <ø> (ø)
:arrow_up:

... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc5425...a08826d. Read the comment docs.


fix(command-dev): use custom functions timeout if present

- Summary
The CLI synchronous functions timeout was hardcoded to 10 seconds.
This PR retrieves the timeout based on the site information and uses it, if present.
- Test plan
Added a test
- A picture of a cute animal (not mandatory but encouraged)
🐼

Still looking into the test failure (it passes locally)


release: Add sha256sum CHECKSUMS.sha256 file to release

What this PR does / why we need it:
Adds a simple CHECKSUMS.sha256 file to each release containing sha256sum checksums for the released bundles.
See an example release below on my personal repo:
https://github.com/lyarwood/common-instancetypes/releases/tag/v1.3.5
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

`sha256sum` checksums are now provided for each release by a `CHECKSUMS.sha256` file

/cherry-pick release-0.3


[FLINK-11836] Update NOTICE-binary and licenses-binary for Flink 1.8.0

It turns out that we had both LICENSE.slf4j and LICENSE.slf4j-api before, with identical contents. I'll see what I can do about sorting the license files before concatenating. 👌

@zentol I'm now sorting the NOTICE files before concatenation. This makes the diff bigger now but should lead to less changes in the future.

Ha, we may want to keep LICENSE.slf4j actually. I don't know where the slf4j-api one comes from (it is not from any Flink module), so we should keep the slf4j license to be sure we have it.

Beyond that, +1.

ok, will manually keep that. But someone might forget that in the future 😅

thanks!

merged


[Cortex Tales of Xadia Playtest] Fixes

Fixing minor issues,
Adding mobile responsive
Legacy set false
Set Assets for the play test characters
Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Default year directive is not taken into account

Hi!
My muscle memory prefers dates in the 2021-12-31 or 12-31 format, and I am running hledger-iadd as follows:
$ hledger-iadd --completion-engine fuzzy --date-format '[%Y-]%m-%d'

The journal file (pointed by $LEDGER_FILE) contains a default year directive: Y2021.
Yet when I enter the transaction date without the year (e.g. "11-03"), but in the future (because reasons), the year suggestion is 2020; the heuristics for year suggestion goes astray. Is there a an additional configuration step for default year - to bypass that heuristics - that I missed?
Cheers!
$ hledger-iadd --version
This is hledger-iadd version 1.3.14

Yes, iadd currently ignores the default year set in the journal. The year that's suggested is based on the current date and the (incomplete) entered date. The assumption is that iadd is mostly used to record past transactions and so it will helpfully suggest the most recent matching date from the past.
I don't know how to best accommodate your use-case without breaking mine, as I exclusively enter past transactions and the current behavior is quite helpful for that. Maybe the default year could indeed be used if set, but I have a feeling that this would somewhat conflate two concepts that ought to be separate: The in-journal date format and the completion mechanism.

Thanks for clarifications! Indeed, current heuristics is correct if we input only past transactions.