Fix bug in customizing URI property

API change check
API changes are not detected in this pull request.


Program fails to start - Qt5Core.dll error

I can no longer start up the program. I think this happened after I updated from 7.2.1 to 7.3.0, or from 7.3.0 to 7.3.2, but I'm not sure. Running the installer for the older version of the software did not fix the issue. I was "installing" the old program version over top of the existing installation. The program was working just fine when I last used it a few weeks ago.
I had several tabs open, and I usually leave these tabs open for later downloading in between sessions.
What happens is that I try to start up the program. I get the message that says "it looks like the program didn't shut down correctly last time. Do you want to restore your last session?". Regardless of whether I click yes or no, a blank window with the Grabber titlebar opens up for a second, and then shuts down.

The main.log file has been attached here.
main.log

The Windows Event Viewer gives the following Application Error:
Faulting application name: Grabber.exe, version: <IP_ADDRESS>, time stamp: 0x5f25d7b9
Faulting module name: Qt5Core.dll, version: <IP_ADDRESS>, time stamp: 0x5dc59681
Exception code: 0xc0000005
Fault offset: 0x0000000000039da0
Faulting process id: 0x5560
Faulting application start time: 0x01d67a98d80d2130
Faulting application path: E:\Programs\Grabber\Grabber.exe
Faulting module path: E:\Programs\Grabber\Qt5Core.dll
Report Id: 0306113d-ed44-4be3-8600-9b66bb09e55b
Faulting package full name:
Faulting package-relative application ID:

The Windows Event Viewer gives the following information in the Windows Error Reporting source
Fault bucket<PHONE_NUMBER>807207873, type 4
Event Name: APPCRASH
Response: Not available
Cab Id: 0

Problem signature:
P1: Grabber.exe
P2: <IP_ADDRESS>
P3: 5f25d7b9
P4: Qt5Core.dll
P5: <IP_ADDRESS>
P6: 5dc59681
P7: c0000005
P8:<PHONE_NUMBER>039da0
P9:
P10:

Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8BC1.tmp.dmp
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8DE5.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8E05.tmp.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8E03.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER8E43.tmp.txt

These files may be available here:
\\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_Grabber.exe_c5f39273df4ed63317c9fbd701c2979ea62a94_31dce014_91dd8585-d06e-4571-81ea-d99c361e7cc8

Analysis symbol:
Rechecking for solution: 0
Report Id: 0306113d-ed44-4be3-8600-9b66bb09e55b
Report Status: 268435456
Hashed bucket:<PHONE_NUMBER>21a750d3da9ecc805643c1
Cab Guid: 0

Settings.ini file here (note: settings.ini was not a supported file type, so I renamed it settings.log
settings - Copy.log
System information

OS: Windows 10
Grabber version: 7.3.2, but I have tried running the installers for 7.3.0 and 7.2.1 to downgrade to an earlier version to fix the issue, and it didn't work.

Other Info
I used an old version of Grabber that was still compatible with SankakuComplex, and I made that critical file read only so that Grabber would stop auto-deleting it. This was working fine for a long time, but it's a possible confounding factor. I have also added a small handful of source websites which worked fine, but at least one of them was taken off the internet in the last couple months.
---
In the very short term, I would like to know how I can restore most of my settings. I want to keep the naming scheme for the files, and the auto-sorting for them. How can I extract that? I assume the database of already-downloaded files isn't going to be an issue.

I'll investigate your crash. The fact that downgrading Grabber doesn't work is worrying though.
It seems to be caused by the monitoring, would you be able to share your favorites.json / monitors.json files? If it's not convenient, you can also send them to me by email (bio.nus@hotmail.fr).

I used an old version of Grabber that was still compatible with SankakuComplex, and I made that critical file read only so that Grabber would stop auto-deleting it. This was working fine for a long time, but it's a possible confounding factor. I have also added a small handful of source websites which worked fine, but at least one of them was taken off the internet in the last couple months.

It shouldn't be related. Even if a source disappeared, it shouldn't cause a crash, at best a few 404 errors in the log.

In the very short term, I would like to know how I can restore most of my settings. I want to keep the naming scheme for the files, and the auto-sorting for them. How can I extract that? I assume the database of already-downloaded files isn't going to be an issue.

All your settings are located in C:\Users\%USERNAME%\AppData\Local\Bionus\Grabber.
I'd suggest making a backup of this folder then deleting it, as well as deleting your installation of Grabber in C:\Program Files\Grabber (or wherever you installed it).
Then, install Grabber and check if Grabber can start properly.
Afterwards, you can start restoring your settings either all at once or step by step:

settings.ini: contains the settings that are edited in the "options" window (so most of them)
md5s.txt: the duplicate database of already downloaded files
restore.igl: batch and single images downloads
tabs.json: your opened tabs
monitors.json: your monitors
favorites.json: your favorites (together with the thumbs/ folder that contain their thumbnail)
viewitlater.txt: the "kept for later" tags
ignore.txt / blacklist.txt: the ignored and blacklisted tags

There's also site-specific settings you might want to restore, in sites/%SOURCE%/%SITE%/settings.ini. It contains stuff such as your identifiers, throttling, etc.

Email sent.
I've transferred over my file renaming stuff and my metadata file configuration stuff.
Thank you for the list of where the settings are and what they do. It helped me get back up to speed faster than I would have been able to do otherwise.


Added ability to extend a defualt attributeMap.

This looks good!
We should probably test to make sure Meteor.settings.saml.attributeMap exists though.

_.extend ignores undefined parameters, but doesn't hurt to have a default.


Hello services run

Fix https://github.com/flutter/flutter/issues/4429, support building and running a gradle based project from flutter tools.

augment the flutter config command to allow users to configure specific paths to installed tools, like gradle-dir and android-studio-dir
recognize when a project is gradle based
locate gradle
create an android/gradle file as necessary
create an android/local.properties file as necessary
inject compileSdkVersion  and buildToolsVersion into android/app/build.gradle

This updates the behavior of flutter build apk ad flutter run. @abarth @jason-simmons


Determine citation formats for people referencing OpenDP work

Update initial authors section to include all contributors.
(changed after @Shoeboxam's comment below)

We merged a CITATION.cff. You can use Cite this repository on the rightpanel of the repo root to retrieve a formatted citation.

@Shoeboxam - updated issue to be more specific

Should we use this or an acknowledgements page


enable multi core proving

Description
Problem
The berrenberg backend uses @noir/bb.js which need cross origin Isolation to enable multi core proving
It checks if window.crossOriginIsolated === true and if SharedArrayBuffer is defined.  However these are disabled due to a workaround involving the specter meltdown bug. This only effects the browser.
The only way to re-enable mulit-core proving is to set the appropriate CORS headers:
"Cross-Origin-Embedder-Policy":"require-corp",
"Cross-Origin-Opener-Policy":"same-origin"

Resolves https://github.com/noir-lang/tiny-noirjs-app/issues/9
Summary*
Some CORS headers need to be set in order to enable multi-core for proving.
Additional Context
It's not going to speed up the hello world circuit here ofc. But maybe it helps someone that got stuck on this (like me :p)
More info about SharedArrayBuffer here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer#security_requirements
bb.js check here: https://github.com/AztecProtocol/aztec-packages/blob/master/barretenberg/ts/src/barretenberg_wasm/helpers/browser/index.ts#L3
PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

thanks for figuring this out!


combustionRange contains a wrong value - at least for hybrid cars

Describe the issue
In the vehicle status output of bimmerconnected for my car (G21, PLUGIN_HYBRID) I get these values:

combustionRange: 87 km
combinedRange: 87 km
electricRange: 17 km

Expected behavior
Same output as in the car and in the My BMW App:

combustionRange: 70 km
combinedRange: 87 km
electricRange: 17 km

Which Home Assistant version are you using?
core-2021.11.4 / bimmerconnected 0.8.0
What was the last working version of Home Assistant Core?
No response
What is your region?
Rest of world
ConnectedDrive website

[X] I can still successfully login to the BMW ConnectedDrive website and the car status is available there.
[X] I have ConnectedDrive enabled for my vehicle.

Number of cars

[ ] I have 2 or more cars linked to the ConnectedDrive account.
[ ] I have a Mini vehicle linked to my account.

Output of bimmer_connected fingerprint
[
  {
    "a4aType": "NOT_SUPPORTED",
    "bodyType": "G21",
    "brand": "BMW",
    "capabilities": {
      "canRemoteHistoryBeDeleted": false,
      "climateNow": {
        "executionMessage": "Do you want to ventilate now? Remote functions may take a few seconds.",
        "executionPopup": {
          "executionMessage": "Turn pre-conditioning on now? Remote functions may take a few seconds.",
          "iconId": 59733,
          "popupType": "DIALOG",
          "primaryButtonText": "Start",
          "secondaryButtonText": "Cancel",
          "title": "Start Climatization"
        },
        "executionStopPopup": {
          "executionMessage": "Stop climate control in your vehicle now? Remote functions may take a few seconds.",
          "title": "Climate control is running"
        },
        "isEnabled": true,
        "isPinAuthenticationRequired": false
      },
      "horn": {
        "executionMessage": "Using your horn is only allowed in certain situations in many countries. Responsibility for the use and adherence to the respective regulations lies solely with you as the user. \n\nDo you want to use the horn now? Remote functions may take a few seconds.",
        "isEnabled": true,
        "isPinAuthenticationRequired": false
      },
      "isBmwChargingSupported": true,
      "isCarSharingSupported": false,
      "isChargeNowForBusinessSupported": true,
      "isChargingHistorySupported": true,
      "isChargingHospitalityEnabled": false,
      "isChargingLoudnessEnable": false,
      "isChargingPlanSupported": true,
      "isChargingPowerLimitEnable": false,
      "isChargingSettingsEnabled": false,
      "isChargingTargetSocEnable": false,
      "isCustomerEsimSupported": false,
      "isDCSContractManagementSupported": true,
      "isDataPrivacyEnabled": false,
      "isEasyChargeSupported": false,
      "isEvGoChargingSupported": false,
      "isFindChargingEnabled": true,
      "isMiniChargingSupported": false,
      "isRemoteHistorySupported": true,
      "isRemoteServicesActivationRequired": false,
      "isRemoteServicesBookingRequired": false,
      "isScanAndChargeSupported": true,
      "lastStateCall": {
        "isNonLscFeatureEnabled": false,
        "lscState": "ACTIVATED"
      },
      "lights": {
        "executionMessage": "Flash headlights now? Remote functions may take a few seconds.",
        "isEnabled": true,
        "isPinAuthenticationRequired": false
      },
      "lock": {
        "executionMessage": "Lock your vehicle now? Remote functions may take a few seconds.",
        "isEnabled": true,
        "isPinAuthenticationRequired": false
      },
      "remote360": {
        "isComingSoonEnabled": false,
        "isDataPrivacyEnabled": false,
        "isEnabled": true,
        "isPinAuthenticationRequired": false,
        "isToggleEnabled": true
      },
      "remoteSoftwareUpgrade": {
        "isEnabled": true,
        "isPinAuthenticationRequired": false
      },
      "sendPoi": {
        "executionMessage": "Send POI now? Remote functions may take a few seconds.",
        "isEnabled": true,
        "isPinAuthenticationRequired": false
      },
      "speechThirdPartyAlexa": {
        "executionMessage": "Activate Alexa now? Remote functions may take a few seconds.",
        "isEnabled": true,
        "isPinAuthenticationRequired": false
      },
      "unlock": {
        "executionMessage": "Unlock your vehicle now? Remote functions may take a few seconds.",
        "isEnabled": true,
        "isPinAuthenticationRequired": true
      },
      "vehicleFinder": {
        "executionMessage": "Find your vehicle now? Remote functions may take a few seconds.",
        "isEnabled": true,
        "isPinAuthenticationRequired": false
      }
    },
    "connectedDriveServices": [
      "WIFI_HOTSPOT_SERVICE"
    ],
    "driveTrain": "PLUGIN_HYBRID",
    "driverGuideInfo": {
      "androidAppScheme": "com.bmwgroup.driversguide.row",
      "androidStoreUrl": "https://play.google.com/store/apps/details?id=com.bmwgroup.driversguide.row",
      "iosAppScheme": "bmwdriversguide:///open",
      "iosStoreUrl": "https://apps.apple.com/de/app/id714042749?mt=8",
      "title": "BMW\nDriver's Guide"
    },
    "exFactoryILevel": "S18A-20-11-530",
    "exFactoryPUStep": "1120",
    "headUnit": "MGU",
    "hmiVersion": "id7",
    "iStep": "S18A-21-07-550",
    "isLscSupported": true,
    "isMappingPending": false,
    "isMappingUnconfirmed": false,
    "model": "330e xDrive",
    "properties": {
      "areDoorsClosed": true,
      "areDoorsLocked": true,
      "areDoorsOpen": false,
      "areWindowsClosed": true,
      "chargingState": {
        "chargePercentage": 53,
        "isChargerConnected": true,
        "state": "CHARGING",
        "type": "NOT_AVAILABLE"
      },
      "checkControlMessages": [],
      "climateControl": {
        "activity": "INACTIVE"
      },
      "combinedRange": {
        "distance": {
          "units": "KILOMETERS",
          "value": 87
        }
      },
      "combustionRange": {
        "distance": {
          "units": "KILOMETERS",
          "value": 87
        }
      },
      "doorsAndWindows": {
        "doors": {
          "driverFront": "CLOSED",
          "driverRear": "CLOSED",
          "passengerFront": "CLOSED",
          "passengerRear": "CLOSED"
        },
        "hood": "CLOSED",
        "trunk": "CLOSED",
        "windows": {
          "driverFront": "CLOSED",
          "driverRear": "CLOSED",
          "passengerFront": "CLOSED",
          "passengerRear": "CLOSED"
        }
      },
      "electricRange": {
        "distance": {
          "units": "KILOMETERS",
          "value": 17
        }
      },
      "electricRangeAndStatus": {
        "chargePercentage": 53,
        "distance": {
          "units": "KILOMETERS",
          "value": 17
        }
      },
      "fuelLevel": {
        "units": "LITERS",
        "value": 6
      },
      "fuelPercentage": {
        "value": 17
      },
      "inMotion": false,
      "isServiceRequired": false,
      "lastUpdatedAt": "2021-11-18T20:13:18Z",
      "originCountryISO": "DE",
      "serviceRequired": [
        {
          "dateTime": "2022-11-01T00:00:00.000Z",
          "distance": {
            "units": "KILOMETERS",
            "value": 12000
          },
          "status": "OK",
          "type": "OIL"
        },
        {
          "dateTime": "2024-11-01T00:00:00.000Z",
          "distance": {
            "units": "KILOMETERS",
            "value": 45000
          },
          "status": "OK",
          "type": "VEHICLE_CHECK"
        },
        {
          "status": "OK",
          "type": "TIRE_WEAR_FRONT"
        },
        {
          "status": "OK",
          "type": "TIRE_WEAR_REAR"
        },
        {
          "dateTime": "2023-11-01T00:00:00.000Z",
          "status": "OK",
          "type": "BRAKE_FLUID"
        },
        {
          "dateTime": "2024-01-01T00:00:00.000Z",
          "status": "OK",
          "type": "VEHICLE_TUV"
        },
        {
          "dateTime": "2024-01-01T00:00:00.000Z",
          "status": "OK",
          "type": "EMISSION_CHECK"
        }
      ],
      "tires": {
        "frontLeft": {
          "details": {
            "dimension": "0/0 R0 0",
            "mountingDate": "11/16/2021",
            "optimizedForOemBmw": "No"
          },
          "status": {
            "currentPressure": 230,
            "localizedCurrentPressure": "2.3 bar",
            "localizedTargetPressure": "2.2 bar",
            "targetPressure": 220,
            "wear": 0
          }
        },
        "frontRight": {
          "details": {
            "dimension": "0/0 R0 0",
            "mountingDate": "11/16/2021",
            "optimizedForOemBmw": "No"
          },
          "status": {
            "currentPressure": 230,
            "localizedCurrentPressure": "2.3 bar",
            "localizedTargetPressure": "2.2 bar",
            "targetPressure": 220,
            "wear": 0
          }
        },
        "rearLeft": {
          "details": {
            "dimension": "0/0 R0 0",
            "mountingDate": "11/16/2021",
            "optimizedForOemBmw": "No"
          },
          "status": {
            "currentPressure": 240,
            "localizedCurrentPressure": "2.4 bar",
            "localizedTargetPressure": "2.8 bar",
            "targetPressure": 280,
            "wear": 0
          }
        },
        "rearRight": {
          "details": {
            "dimension": "0/0 R0 0",
            "mountingDate": "11/16/2021",
            "optimizedForOemBmw": "No"
          },
          "status": {
            "currentPressure": 230,
            "localizedCurrentPressure": "2.3 bar",
            "localizedTargetPressure": "2.8 bar",
            "targetPressure": 280,
            "wear": 0
          }
        }
      },
      "vehicleLocation": {
        "address": {
          "formatted": "some_formatted_address"
        },
        "coordinates": {
          "latitude": 90,
          "longitude": 90
        },
        "heading": 123
      }
    },
    "puStep": "0721",
    "status": {
      "chargingProfile": {
        "chargingControlType": "weeklyPlanner",
        "chargingMode": "immediateCharging",
        "chargingPreference": "noPreSelection",
        "chargingSettings": {
          "hospitality": "NO_ACTION",
          "idcc": "NO_ACTION",
          "isAcCurrentLimitActive": false,
          "targetSoc": 100
        },
        "climatisationOn": true,
        "departureTimes": [
          {
            "action": "activate",
            "id": 1,
            "timeStamp": {
              "hour": 7,
              "minute": 50
            },
            "timerWeekDays": [
              "monday",
              "wednesday",
              "thursday",
              "friday"
            ]
          },
          {
            "action": "deactivate",
            "id": 2,
            "timeStamp": {
              "hour": 8,
              "minute": 5
            },
            "timerWeekDays": [
              "tuesday"
            ]
          },
          {
            "action": "deactivate",
            "id": 3,
            "timeStamp": {
              "hour": 7,
              "minute": 30
            },
            "timerWeekDays": []
          },
          {
            "action": "deactivate",
            "id": 4,
            "timeStamp": {
              "hour": 7,
              "minute": 50
            },
            "timerWeekDays": [
              "friday"
            ]
          }
        ],
        "reductionOfChargeCurrent": {
          "end": {
            "hour": 7,
            "minute": 0
          },
          "start": {
            "hour": 23,
            "minute": 0
          }
        }
      },
      "checkControlMessages": [
        {
          "criticalness": "nonCritical",
          "iconId": 60117,
          "state": "OK",
          "title": "Tires"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 60197,
          "state": "OK",
          "title": "Engine Oil"
        }
      ],
      "checkControlMessagesGeneralState": "No Issues",
      "currentMileage": {
        "formattedMileage": "21148",
        "mileage": 21148,
        "units": "km"
      },
      "doorsAndWindows": [
        {
          "criticalness": "nonCritical",
          "iconId": 59757,
          "state": "Locked",
          "title": "Lock status"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 59722,
          "state": "Closed",
          "title": "All doors"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 59725,
          "state": "Closed",
          "title": "All windows"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 59706,
          "state": "Closed",
          "title": "Hood"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 59704,
          "state": "Closed",
          "title": "Trunk"
        }
      ],
      "doorsGeneralState": "Locked",
      "fuelIndicators": [
        {
          "chargingType": null,
          "iconOpacity": "high",
          "infoIconId": 59691,
          "infoLabel": "Combined Range",
          "isCircleIcon": false,
          "isInaccurate": false,
          "levelIconId": null,
          "levelUnits": null,
          "levelValue": null,
          "mainBarValue": 0,
          "rangeIconId": 59691,
          "rangeUnits": "km",
          "rangeValue": "87",
          "secondaryBarValue": 0,
          "showsBar": false
        },
        {
          "barType": null,
          "chargingStatusIndicatorType": "CHARGING",
          "chargingStatusType": "CHARGING",
          "chargingType": "charging",
          "iconOpacity": "high",
          "infoIconId": 59689,
          "infoLabel": "100% at ~03:21 AM",
          "isCircleIcon": true,
          "isInaccurate": true,
          "levelIconId": 59689,
          "levelUnits": "%",
          "levelValue": "53",
          "mainBarValue": 53,
          "rangeIconId": 59683,
          "rangeUnits": "km",
          "rangeValue": "17",
          "secondaryBarValue": 0,
          "showBarGoal": false,
          "showsBar": true
        },
        {
          "chargingType": null,
          "iconOpacity": "high",
          "infoIconId": 59930,
          "infoLabel": "Fuel Level",
          "isCircleIcon": false,
          "isInaccurate": false,
          "levelIconId": 59682,
          "levelUnits": "%",
          "levelValue": "17",
          "mainBarValue": 17,
          "rangeIconId": 59681,
          "rangeUnits": "km",
          "rangeValue": "70",
          "secondaryBarValue": 0,
          "showsBar": true
        }
      ],
      "issues": {},
      "lastUpdatedAt": "2021-11-18T20:13:18Z",
      "recallExternalUrl": null,
      "recallMessages": [],
      "requiredServices": [
        {
          "criticalness": "nonCritical",
          "iconId": 60197,
          "id": "Oil",
          "longDescription": "Next service due after the specified distance or date.",
          "subtitle": "some_road \u2022 duration \u2022 -- EUR",
          "title": "Engine oil"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 60215,
          "id": "VehicleCheck",
          "longDescription": "Next vehicle check due after the specified distance or date.",
          "subtitle": "some_road \u2022 duration \u2022 -- EUR",
          "title": "Vehicle check"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 60447,
          "id": "TireWearFront",
          "subtitle": "some_road \u2022 duration \u2022 -- EUR",
          "title": "Tire service, front tires"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 60447,
          "id": "TireWearRear",
          "subtitle": "some_road \u2022 duration \u2022 -- EUR",
          "title": "Tire service, rear tires"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 60223,
          "id": "BrakeFluid",
          "longDescription": "Next service due by the specified date.",
          "subtitle": "some_road \u2022 duration \u2022 -- EUR",
          "title": "Brake fluid"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 60111,
          "id": "VehicleAdmissionTest",
          "longDescription": "Next state inspection due by the specified date.",
          "subtitle": "some_road \u2022 duration \u2022 -- EUR",
          "title": "Vehicle Inspection"
        },
        {
          "criticalness": "nonCritical",
          "iconId": 60200,
          "id": "EmissionCheck",
          "longDescription": "Next state emission inspection due by the specified date.",
          "subtitle": "some_road \u2022 duration \u2022 -- EUR",
          "title": "Emission inspection"
        }
      ],
      "timestampMessage": "Updated from vehicle 11/18/2021 09:13 PM"
    },
    "telematicsUnit": "ATM02",
    "themeSpecs": {
      "vehicleStatusBackgroundColor": {
        "blue": 92,
        "green": 89,
        "red": 85
      }
    },
    "vin": "some_vin",
    "year": 2020
  }
]

Anything in the logs that might be useful for us?
fuelIndicators show the correct ranges.
properties.combustionRange is wrong

Additional information
No response

I want to clarify: I have installed Home Assistant core-2021.11.5 with the included version of bimmerconnected. It is the unusable broken version, which should be fixed in version 0.8.0.
I installed bimmer_connected version 0.8.0 in my WSL and executed it there via CLI.
The raw values in the output from bimmerconnected fingerprint/status still show a wrong value for combustionRange. But if it isn't used, I don't care.
And if you say the Home Assistant integration will use the values from fuelIndicator, I'm fine. As I said fuelIndicators show the correct ranges.
And as I see now in the status output, the values remaining_range_fuel, remaining_range_total and (as before) remaining_range_electric have the correct values. I guess these are the values used in Home Assistant.
So I'm looking forward to the integration of the fixed version 0.8.0 into Home Assistant.

Perfect - then you will see the correct values once the data is merged into Home Assistant.

Thanks!


math: MaxFloat32/64 and SmallestNonzeroFloat32/64 value comments misleading

What version of Go are you using (go version)?
Playground 1.20 as of Fri Jul  7 15:17:35 UTC 2023.
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
Playground
What did you do?
https://go.dev/play/p/HZ_Nr7FpU9d
strconv.FormatFloat(math.MaxFloat64, 'e', -1, 64)

What did you expect to see?
1.79769313486231570814527423731704356798070e+308
(since this longer value is listed in the doc comment for math.MaxFloat64)
What did you see instead?
1.7976931348623157e+308
This applies to MaxFloat32, MaxFloat64, SmallestNonzeroFloat32, and SmallestNonzeroFloat64.
Since all of these cases are rational numbers defined in terms of the type itself, I expect their doc comments to have exactly the same value that strconv.FormatFloat would produce with -1 precision.
Note that C# (link) and Java (link) also express the constant in terms of the value that strconv.FormatFloat prints with -1 precision.

Further request for clarification: float64(math.MaxFloat32) != float64(float32(math.MaxFloat32))
https://go.dev/play/p/feXsT2QSRIU
Why doesn't math.MaxFloat32 exactly represent the maximum finite value that can be stored in a float32? It may happen to produce the maximum-finite bit-pattern when stored in a float32, but is it still reasonable to claim that this is the maximum finite value that a float32 holds when it's not exactly that same finite value?

From strconv.FormatFloat:

The special precision -1 uses the smallest number of digits necessary such that ParseFloat will return f exactly.

So the "actual" you're generating here is not the actual value contained in the float. It is the shortest possible string that parses to that float.
fmt.Println I think also does not print with arbitrary precision. (It prints with "default format", whatever that means.)
If you print with %.0f it will give you the exact value. The resulting value is what is listed in comments for float32, and probably would be listed for float64 only it is too long.
	f32 := float32(math.MaxFloat32)
	fmt.Printf("f32:   %.0f\n", f32)
	fmt.Printf("f32    %x\n", math.Float32bits(f32))
	f64 := float64(math.MaxFloat64)
	fmt.Printf("f64:   %.0f\n", f64)
	fmt.Printf("f64    %x\n", math.Float64bits(f64))

Ah. I misunderstood. Thanks for the explanation!


NACK support

Currently we only support two states:

Not accepted, where not enough LGTMs have been received.
Accepted, where >n LGTMs have been received and it's good to merge.

I think we should consider having another state:

Rejected or NACK'd, where a maintainer has said "No" to a change. Now, this will be a bit tricky to make configurable (purely because of how hard it is to specify what the maintainence politics of a project are in code) but there should be a way to make it so that a NACK can't be overlooked by a maintainer.

WDYT?

Makes sense, I also like NACK for that per default

Like the idea, can definitively see it being abused 😆


Config Validator violations produce duplicate findings for CSCC

Story
Forseti uses a violation hash to use as the finding id in CSCC. Config Validator violation data typically just contains the resource name, so if a resource has multiple violations, only one of those violations will make it into CSCC.
Proposed Solution
Add an option to include the constraint name in the violation data. By making it an option that is disabled by default, it would not affect any current users.

Why not simply use the constraint name + resource name as the violation hash?

I meant to include the constraint name in the violation hash, which is then used as the finding id. I think it's better to have this as optional behavior because some users can have many findings in CSCC right now, and if the finding id changes for all findings, then it can take a while for Forseti to deactivate the existing findings and create new ones.


Reporting page shows initial odds, not final odds

In the FAQ about rep it states that much of the reporting will be fairly trivial as the final odds (share price) will make it clear how the question was resolved.  As I am doing the reporting, everything seems set to the initial equally distributed model (50/50 for example).  Either the FAQ should be changed, or the final info needs to pull through to the reporting page.

I noticed that every single report I was asked to find info on had 0 trade volume. If your set was the same, then initial was final. Already posted an issue about reporting on 0 volume markets.

Should reporting page show any odds?

If event only has 1 market should show that market's final odds

Old UI issue.


[VS Code] Joining collaboration session: Cannot get the response back because the session has been disconnected.

Error:
Joining collaboration session: Cannot get the response back because the session has been disconnected.
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS

extensionVersion
1.0.752

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.37.1

platformName
Linux

platformVersion
4.19.28-1-MANJARO

Hey @ivanilsonmota , is it possible this was a valid error message? I.e. is it possible that you tried to join a session the host had already ended?

Closing due to inactivity. Please re-open if this you're still encountering the issue and can share more details. Thanks!

the cluster admin installed vso for us, but when we use "vso start" and choose "process mode", the error comes:
[!ERROR] Cannot get the response back because the session has been disconnected.
after looking the agent log file, there are several key errors:
Connecting to <https://prod.liveshare.vsengsaas.visualstudio.com/b23094a 6> via proxy failed with exception System.Net.Http.HttpRequestException: Bad value for ai_flags  ---> System.Net.Sockets.SocketException (0xFFFFFFFF): Bad value for ai_flags
System.Threading.Tasks.TaskSchedulerException: An exception was thrown by a Ta skScheduler.  ---> System.OutOfMemoryException: Exception of type 'System.OutOfMemoryException' was thrown.
RPC session #1 disconnected: Failed to read from RPC stream: An exception was thrown by a TaskScheduler.
I have no idea on what is this. The vso process can not be launched and codespaces creating will be fail.


flutter 3.22.0

Latest flutter removes bottomAppBarColor. Can this be fixed in the code please.
Thanks!

Same goes for headline6

see #209


POD example for Catalyst::Model::DBIC::Schema

Per mst's request, submitting a patch for POD.

Eh, I even forgot about this. Why is this still not merged? :)

Will this ever merge?


Effect property on Button component

About styles 🛠
I have a problem setting this property to false, because the effect doesn't change.
If i'm not wrong, that property should change the effect on hover on the button component, and it will have no effect by setting to false.
Code:
<Button size="small" type="success" ghost effect={false}>
  MyButton
</Button>

Result

Uh huh, yeah, the effect prop does not change the hover effect.
When the normal Button components are clicked, they will have animation effect like water waves. Prop effect is used of turn off the animation effect.
There's a little difference here, If the Button component is in special mode (ghost / loading / disabled ...),  the animation is disabled.

I don't know if you noticed, If Button component has shadow prop, the hover effect  is disabled.
If you just want to disable hover effect, this style (shadow) may help you?

Thanks for the explanation. I wanted the same that happens on shadow style, but without the shadow effect. I mean, i want a ghost button, but without any hover effect. I don't know if that is supported.

Currently, there is no plan to support disable some styles, but as an alternative, you can customize a Button component to implement this style.
I have an online  example on codesendbox for you, Is this what you need?

Yeah, that's the best alternative, thank u so much! 😊


Sameerch/keyvault

The Azure Key Vault [Sample] connector.
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Do we need an icon in public repo?

Do we need an icon in public repo?

Not required.


[Feature]: Rewrite last N commits in repo via CLI

Description
Suppose I am very satisfied with the commit messages generated by oco and I would like oco to rewrite my project's past commit messages, it seems that there is no easy way to do it now.
Suggested Solution
An easy way to rewrite past N commits with oco via the CLI.
Alternatives
Writing a script based off the current GitHub action would work but I believe that this should be possible from via the CLI as well.
Additional Context
No response

actually good idea, will look into it


Swap flash id for a class

Generally speaking, it’s best practice to style off class’s instead of id’s. There are exceptions, but in this case, I would consider the id of flash not very useful, so this swaps it for a class instead. Also, the flash key on Line 4 was already being output as a class; this unifies the two.

Looks good! Can you please add context/the PR description into the commit message before merging?
Thank you!

Since this wraps a collection (user_facing_flashes), would flashes be more descriptive?

@andyw8 Great point. flashes makes more sense when multiple flashes are being shown. Updated.

If we don't need to update any CSS or JS for this, feel free to rebase and merge @tysongach! Thank you.


Marine request response missing most request metadata

When using the marine API I cannot access attributes like latitude and longitude.
these do not necessarily correspond to the request coordinates as they are the centre of the nearest model cell.

Hi,
do you have an example URL request which does not return coordinates? This should not be possible.


Return a non-zero exit code for all unhandled errors

main() returns a result only for errors we can't easily intercept and log. An example is config file parsing. The config file is the source of truth for the kind of logger we need to build. Any Err's returned are displayed to STDERR and result in a non-zero exit code. And due to the behavior of our logger, simply calling exit() early prevents any error logging from reaching its destination.
The solution is an immediately invoked lambda expression, which is the program's exit code.
An alternative could be to have yet another intermediate 'runner' fn, but I felt that would be just as confusing and messy as it would result in this: main() → new_runner() → run().

@xandkar

Is the intermediate closure strictly necessary? If so, then why?

It was necessary at first, when I was handling runtime build failure. I switched that to expect() because it's such an uncommon error, and nothing can be done when it happens.

Would not let retcode = {...}; be sufficient?

Yep! I updated the code to that. Thanks.


Small introduction to Mojo::Base

The documentation in Mojo::Base is very minimalistic and doesn't cover the concepts at all. For a beginner the learning curve can be quite steep here. Especially a little explanation for what use Mojo::Base 'Mojolicious' is actually good for, and what attribute accessors are would be really helpful.

I think a small tutorial in the Mojo::Base reference docs, similar to how Mojo::Template explains the template syntax, would make sense.

There's already some doc from @jberger's https://mojolicious.io/blog/2017/12/12/day-12-more-than-a-base-class/ so maybe distilling from that would be helpful.

Until Mojolicious v7.79, for beginners, the learning curve is still very steep. Need more sample case studies in the Mojo::Base documentation.

I've started by explaining fluent interfaces. https://github.com/kraih/mojo/commit/7b6bb4e8df21886cbcdff55ba4aaa03bd64af2fc

:+1:


[BONUS] Add gatling load tests

Gatling now added to project.
Add load tests mainly on selection for now, this is just for demonstration purposes.


Examine trans-fit processing

I see that the content trans-fit for unit-anchors (a3) isn't being processed.
Check this is representative of the content.  It certainly has unusual body content (missing id).
See how extensive this pattern is, and decide if we:

fix content
introduce special handling (possibly including _fit or _SF in the page title).

This issue is fixed.


Add support for qldb driver cs 273

:tada: This PR is included in version 1.81.0 :tada:
The release is available on:

GitHub release
v1.81.0

Your semantic-release bot :package::rocket:


Share state between reducers

Hi, I have some question about accessing state inside a Reducer.
In my app I have multiple sub states. It's actually sub state for each view controller. Now for each sub-state I have a reducer that change it. For simplicity let's assume that I have the following AppState
struct AppState {
   let currentUserState : CurrentUserState
   let itemState : ItemState
}
func appReducer(action: Action, state: AppState?) -> AppState {
    return AppState(
       currentUserState: currentUserReducer(state: state?.currentUserState, action: action),
       itemState : itemReducer(action, state: state?.itemState, action: action)
   )
}

My question is: what should I do if I need to access the currentUserState or part of it inside the itemReducer.  I need it because the itemReducer must know if the current user is logged in or not and react to it. The user loginInfo is stored inside the currentUserState and as much as I know it's not recommended to do: store.state.currentUserState inside the itemReducer function. I wanted to know what is the recommended way to do it.
Thanks in advance.

I’d say two things on this.

I’ve found it helpful to keeping real business logic out of reducers.   Better to have some sort of component— what I call a Feature class-- that pays attention to global changes like authentication.  This class determines what actions are best at the appropriate time.

This could be an opportunity for middleware.  Middleware would intercept your actions before they get to the reducers.  A middleware class could check authentication state, then swallow or redirect the action as needed.

Mark
Mark Broski | Senior Manager
<EMAIL_ADDRESS>c<PHONE_NUMBER> / o<PHONE_NUMBER>
[X]http://www.captechconsulting.com/
[X]http://www.facebook.com/CapTechCareers [X] http://www.twitter.com/CapTechListens  [X] http://www.linkedin.com/company/captech-ventures  [X] http://www.stackoverflow.com/jobs/companies/captech-consulting  [X] http://www.youtube.com/user/CapTechConsulting  [X] https://www.instagram.com/lifeatcaptech/
Best Firms 2016 #2 in Information Technology
On July 19, 2018 at 8:36:38 AM, Ran Hassid (notifications<EMAIL_ADDRESS>wrote:
Hi, I have some question about accessing state inside a Reducer.
In my app I have multiple sub states. It's actually sub state for each view controller. Now for each sub-state I have a reducer that change it. For simplicity let's assume that I have the following AppState
struct AppState {
let currentUserState : CurrentUserState
let itemState : ItemState
}
func appReducer(action: Action, state: AppState?) -> AppState {
return AppState(
currentUserState: currentUserReducer(state: state?.currentUserState, action: action),
itemState : itemReducer(action, state: state?.itemState, action: action)
)
}
My question is: what should I do if I need to access the currentUserState or part of it inside the itemReducer. I need it because the itemReducer must know if the current user is logged in or not and react to it. The user loginInfo is stored inside the currentUserState and as much as I know it's not recommended to do: store.state.currentUserState inside the itemReducer function. I wanted to know what is the recommended way to do it.
Thanks in advance.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/ReSwift/ReSwift/issues/364, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB1EpT25Q1TTkC-1ftPoCScYf-uJUOh9ks5uIH1LgaJpZM4VWUWM.

@ranhsd In my experience, when something like this is happening is because I'm coupling logic that shouldn't belong together. Ideally, you would react in your views to some changes in different parts of your state and make decisions there. Also, some actions won't happen in certain circumstances because they won't make sense (for instance, if the user isn't logged in, you won't be able to dispatch a change on their avatar because that part of the UI won't be loaded), and finally, you know that all reducers manage certain parts of the state, but they can be recalculated based on all actions (for instance, if you dispatch a log out action, you can reset different reducers at once, not only the ones related with the user's authentication).
I hope this makes sense to you!

@danielmartinprieto thanks for your answer but it's really depend on the app that you're building. For example in my app I need to show to guests users also some part of the Item but I need to check if they were logged in or not.

I usually partition my reducers by action instead of by substate. Those that need access to multiple substates or the root state are passed AppState; those that only need substate info are passed e.g. ItemState. That should help.
Also, maybe the underlying question is not about how to access other substates, but how to utilize login info that is needed in various parts of your app. To that question, there are different answers, so maybe ask that if that's what you're really puzzled with.

Hi @DivineDominion I am talking more about REDUX selectors (If you are familiar with...) selectors allows you to derive state to other sub states in your app. Of course that I can add another property in my ItemState of logInStatus or something similar and set it with an action but the idea of selectors is to keep the store as small as possible and as simple as possible to avoid complexity and to reuse state properties in multiple places.

@ranhsd what you're looking for is in this sentence I wrote before: Ideally, you would react in your views to some changes in different parts of your state and make decisions there.

@ranhsd The virtue to keep the state as small as possible sure sounds nice an all, but you don't tell what you want to do :)
Maybe this is a case of the http://xyproblem.info/? :)
What do you need the auth info for? @mbroski  suggested middleware -- you could swallow actions (e.g. not process them) before they reach reducers in a middleware: if state.isLoggedIn { next(action) }, otherwise do not forward, for example. If you need to access the userName when you reduce FooAction, well, then write reducers differently, I suggest. Or you need to stop dispatching certain kinds of actions when the state.isLoggedIn == false in the view controller or whatever is dispatching them, as @danielmartinprieto suggested.
You need to be more specific about the problem you want to solve, not just the effect you fail to achieve, I suggest.

Hi @DivineDominion the auth is only one example. There are so many examples. I will try to explain it more.
In my app each view controller subscribe to one sub state. I have a lot of view controller in my app that each one of them subscribe to specific sub state all the sub-states together construct on big Redux AppState. I also divided it into Actions so each one of the view controller has its own actions which are being dispatched from time to time during the specific view controller lifetime (e.g. network requests, update the UI and so on). Now each one of the sub-states has its own reducer. The reducer listen to actions which are being dispatched in the view controller but it also listen to actions from other view controller. So if for example I updated the user first name in the profile screen other screens which also use the user first name can update their UI as well.
Now sometimes in my reducer I need to access to values of other states in my REDUX store but in my current architecture each one of my reducer receive the sub-state  as an input and need to return a new one and this specific sub-state sometimes not contains some data that I need. my example on the loginStatus is just one but there are more examples like: user info, settings info and more. I read about how REACT/REDUX solve this issue and they do it by deriving the state and this is done via selectors. There is a very popular library in here: https://github.com/reduxjs/reselect which solve it

@raheelahmad: As you mentioned selectors, ReSwift also has this feature actually. It (and the library you mentioned) doesn't seem to solve the issue, since selectors are meant for use from store to views. Of course, you can use selectors to create a composed state from substates, and pass to reducers. This leads to the question: what does prevent you from simply doing that without need of selectors? e.g. itemReducer(action, state: (state?.itemState, state?. currentUserState), action: action)
Even so, it raises another question: What if it doesn't only happen for one reducer or one substate (which I guess your case)? For example, there're 4 substates A, B, C, and D. To reduce A, the reducer needs A and B; to reduce B, the reducer need C and D, and so on. If it's really the case, @DivineDominion's suggestion(and others') should help.
I will also consider reorganize the store to avoid this couple between substates. One substate for each view controller might not a good idea as it implies you're using the store to keep view states as well (not completely wrong though), while it should keep data, and data are displayed to views (through selectors if necessary), as @danielmartinprieto's comment.

Yes! Selectors are already built in ReSwift, check this example. Using that function you can map the whole state of your app to a substate with only the pieces of information that you need.
As I understand it, the whole point or Redux and its (sometimes hated) boilerplate is the separation of concerns. That's why it's not (a priori) a good idea to couple state, actions and views.

Organise your state as a normalised database, without duplicating information and without heavy nesting.
Define actions in terms of the events you want to log in the app, instead of thinking about the piece of the state that it's going to change (avoid 1 to 1 relationships between actions and reducers).
Reduce each part of the state depending on the actions/events (two different parts of the state can be recalculated based on the same action, that's the cool thing).
In each view, subscribe only to the part of the state that it really needs, even combining different substates. I usually declare the substate for each view (struct MySubstate { ... }), make it Equatable, and then subscribe to the store like this: store.subscribe(self) { 0$.select(MySubstate.init) }.

Hi @danielmartinprieto thanks for your detailed response. This is exactly how I am working currently. I subscribe to sub-states and use Equatable + SkipRepeates. BTW its not always possible to subscribe to specific model or object of your sub-state but of course that it is possible. If I will implement all your recommendations above (which seems to be correct) it means that in order to get all the info that I need I will need to subscribe to multiple objects or sub-state in part of my view controllers. I can do that (by using blocks instead of delegates) but if you have a look on the example in here:  https://github.com/svdo/ReRxSwift you will notice that it's done in much more generic and nice way but in order to do it I need to use RxSwift which currently is not part of my architecture.

Hi, @ranhsd. I don't understand this:

BTW its not always possible to subscribe to specific model or object of your sub-state but of course that it is possible.
and neither this:
I can do that (by using blocks instead of delegates) but if you have a look on the example [...]
so I can't help you a lot there, but regarding ReRxSwift, you can do exactly the same until point 4 (included) without the need of RxSwift, just using the ReSwift API. If you post a small code example illustrating the problem you have, I think I will be able to help you better.

Hi @danielmartinprieto I really appreciate your help but I think that I will try to figure it out on my own. I like the ReRxSwift approach but the problem is that it is dependent on RxSwift which currently not part of my project.
Anyway, I will try to find some solution and will reopen the issue if I will have more questions.
Thanks a lot!


Set meaningful filename for combined PDF

It would be nice if the filename of the combined output file wouldn't be combined.pdf but rather derived from site_name or configurable by a separate option. This would help people downloading the docs to get a file with a meaningful name.

According to the readme this is already possible.
You can add combined_output_path as an option to the pdf-export plugin.
See here.

According to the readme this is already possible.
You can add combined_output_path as an option to the pdf-export plugin.
See here.

You are perfectly right. The option already exists and works just fine. I somehow missed it when I was looking for it. Thanks!


Amended BackfillNinoAndPersonPostcodeInEmploymentHistory to update records 1000 rows at a time

Context
The ad hoc job in Hangfire which populates the national_insurance_number and person_postcode fields in all existing person_employments records using the data in the tps_csv_extract_items table for previous imports errors in production as it is trying to update all records in one go.
Changes proposed in this pull request
Amend the query in BackfillNinoAndPersonPostcodeInEmploymentHistory in TpsCsvExtractProcessor to include LIMIT 1000 to only update 1000 records at a time.
Checklist

[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Amend one off job to populate NINO and postcode in existing person employments records to update 1000 records at a time


Doorbell motion for packages

I'm not seeing Doorbell motion for packages alerts. Is this a limitation of their API? Thanks!

Hi @krayzie32, the SDM API does not fire any events related to packages.  Here is the full list of events it supports:
wired: https://developers.google.com/nest/device-access/api/doorbell#handle_doorbell_and_camera_events
battery: https://developers.google.com/nest/device-access/api/doorbell-battery#handle_doorbell_and_camera_events


Can not connect gripper by USB

When I run  rosrun robotiq_c_model_control CModelRtuNode.py,there is a misstake.What should I do?

@james2254, looks like the node is expecting command line arguments.

@shaun-edwards I download the package and run the node by the ROS wiki .Change the node or other
method, which can solve this issue ?  thank you !

Hi @james2254 , don't know if you solved the issue.
After you connect the gripper, check with lsusb it connected, you should see something like:
Bus 001 Device 008: ID 0403:6015 Future Technology Devices International, Ltd Bridge(I2C/SPI/UART/FIFO)
Then check with dmesg | grep tty what port it connected to. You should see something like:
[ 6416.940532] usb 1-2: FTDI USB Serial Device converter now attached to ttyUSB0
If that all goes well, then you also need to create a modbus config file (at least for me, it didn't work until I did this), you can run this bash script to do so:
# configuration of virtual port com FT X series
FTDI_CONF_FILE='/etc/modprobe.d/ftdi_sio.conf'
FTDI_CONF_OPTION='options ftdi_sio product=0x6015 vendor=0x0403'
FTDI_CONF_ALIAS='alias usb:v0403p6015d*dc*dsc*dp*ic*isc*ip* ftdi_sio'
if [ -f $FTDI_CONF_FILE ]; then
        MSG="FTDI conf file already exists."
        echo $MSG
else
        MSG="FTDI conf file does not exist. Creating it."
        echo $MSG

        echo "# This file allows the ftdi_sio driver to use FT X series." > $FTDI_CONF_FILE
        echo $FTDI_CONF_OPTION >> $FTDI_CONF_FILE
        echo $FTDI_CONF_ALIAS >> $FTDI_CONF_FILE

        #reload the module for the changes to have effect
        modprobe -r ftdi_sio
        modprobe ftdi_sio
fi

If all that went well, then you can run in one terminal (it does not print anything):
rosrun robotiq_c_model_control CModelRtuNode.py /dev/ttyUSB0
And in another terminal:
rosrun robotiq_c_model_control CModelSimpleController.py
to get a simple menu to activate and move the gripper using the USB adaptor... the rest is up to you.
Cheers :beers:

@carlosjoserg Thank you very much! I have not sloved it and I will try it recently.

＠james2254 How did you solve the problems mentioned above?
I also could not the robotiq gripper by USB

@james2254 How did you solve the problems mentioned above?
I also could not the robotiq gripper by USB

I've sloved the problem, which arise from my socket version.

@newuhe I think I have exactly the same problems that you had. How did you manage to solve them?
Thanks

@newuhe here you say that you found other useful packages. Can you please specify which package you used?


[ansible] minimize dependencies of roles on another roles

Lot a roles depends on common role which defines facts as is_atomic, is_coreos and others. Which make dependent roles less reusable.

pre-ansible:

is_coreos (used to detect coreos, specific with coreos.yml task file only)
bin_dir (so far coreos only, could be moved under coreos.yml task file)
is_atomic (used to detect atomic, if not atomic => install some packages)

common:

is_atomic (used in node, flannel, master, ...)
is_coreos (used in node, flannel, master, ...)
has_rpm (used in common role only)
has_firewalld (used in node, flannel, master, ...)
has_iptables (used in node, flannel, master, ...)

The common role can be broken out into two parts:

detection part: setting facts
modification part: create basic dirs, install packages

In order to run self-standing roles (etcd, docker, ...), the detection part needs to be separated from the modification part. No need to run the modification part each time a dependent role is run.


Allow to specify working address of a section

I've just seen this tool by @zzazzdzz: https://github.com/zzazzdzz/rgbbin
Basicaly, it's a tool that lets the user write code in RAM sections (which is somehow loaded by another tool).
It is an interesting idea, and the GNU linker allows you to do it:
   It is possible to specify that a segment should be loaded at a
particular address in memory.  This is done using an `AT' expression.
This is identical to the `AT' command used in the `SECTIONS' command
(Section Options:.).  Using the `AT' command for a program
header overrides any information in the `SECTIONS' command.

In short, you write some code in a ROM section, but specify that it is actually going to run at some address in RAM.
This is not a trivial change, but pretty much every single GB ROM does this when they copy the OAM update function to HRAM.

Closing this as a duplicate of #274


some code are still obfuscated.

i tried to deobfuscate a file but half of the code are still obfuscate and i dont understand how to solve that, i u could pls help me with this!!

I apologise for taking so long to reply... I will fix this problem in the next few days. I also saw your email, would it be possible to send me the obfuscated code that creates this bug by email so that it can help me fix the problem?

basically it's a regex problem it seems, but I'll look at it in more detail tomorrow or the next day

I apologise for taking so long to reply... I will fix this problem in the next few days. I also saw your email, would it be possible to send me the obfuscated code that creates this bug by email so that it can help me fix the problem?

i replied the mail with the file link. please check it.

Good evening, I've just fixed the bugs as best I could, I hope I've fixed them completely, if not I'll continue to fix them.


Update sbt to 1.5.8

Updates org.scala-sbt:sbt from 1.5.7 to 1.5.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #245 (7cfdcfa) into main (295ac2e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   88.84%   88.84%
=======================================
  Files          91       91
  Lines        2770     2770
  Branches       67       67
=======================================
  Hits         2461     2461
  Misses        309      309

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295ac2e...7cfdcfa. Read the comment docs.


[BUG] - Listbox: Hover not working

NextUI Version
react 2.2.9
Describe the bug
Listbox background is not changing when hovering over it.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Follow installation instructions
Copy any listbox snippet from the official page

Expected behavior
Is expected to show a background default 100 when the ListboxItem is hovered, instead it doesn't detect the data- attribute.
(Im using the recommended TW version)
Screenshots or Videos
No response
Operating System Version
Windows 11
Browser
Chrome

I think you should provide the mini-reproduced demo

Hi guys, any solution to this?

It looks fine on my side. or anyone can share a reproducible environment for demonstration?

This works tho
<LinkboxItem
classNames={{
base: p-3 gap-8 items-center mb-4 ${isActive ? 'bg-brand_color_02 text-white' : ''},
title: text-[14px],
}}
className={clsx(
data-[hover=true]:bg-brand_color_02 data-[hover=true]:text-white data-[selectable=true]:focus:bg-brand_color_02 data-      [selectable=true]:focus:text-white ${isActive ? 'text-white font-semibold' : 'text-cool_text font-regular'} text-[14px] data-      [hover=true]:ease-in-out duration-300
)}
/>

@I-am-abdulazeez Can you share the code that reproduce the issue?

Closing - Not able to reproduce + inactivity.


Add [QUANTOM Corp. quantomfinancial.org] #custodian GAOFMM…K5NQTM

Address: GAOFMMR7E6RFFPAKR7C6TQO5GRKQVHLLQWDVBL2ZAHQUW2LJ33K5NQTM
Tags: custodian
Title: QUANTOM Corp.  Domain: quantomfinancial.org
Requested by @luckinsi

@luckinsi Thank you for your input. I know that the token got tagged as "custodian" instead of "malicious" yesterday. I have asked @orbitlens to change the tag to the intended "malicious" instead of "custodian".
Yesterday they minted 100 scam tokens that:
-were up to the edge infringing on the rights of every brand and trademark used.
-the word quantum is intentionally spelled wrong,
-the website is just a template with no working links except to someone else's telegram channel
-the domain was also registered with NameCheap and will most likely get shut down for not following their pretty clear AUP.
-there is no working TOML for these tokens
As you may or not know the idea of the new Quantum Financial System QFS is a well known and a concept used in many scams targeting many good conservative people following some of those influencers.
Please continue to help shine the spotlight on malicious activity on the Stellar Blockchain. If you have further input feel free to reopen this issue.
Looking Towards The Future With You,
Rob TheCryptoHobbyist

@luckinsi I also just found out the email is either fake or just not working.

On Sat, Jan 14, 2023 at 4:38 PM CryptoHobbyist @.***>
wrote:

@luckinsi https://github.com/luckinsi I also just found out the email
is either fake or just not working.
—
Reply to this email directly, view it on GitHub
https://github.com/stellar-expert/public-directory/issues/349#issuecomment-1382925421,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5IAW3CR4DXBPXK4KICQ6O3WSMMD3ANCNFSM6AAAAAAT3KRBVA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Ok thanks , i love all your reviews
Can i send you more to check for me

@luckinsi We are always trying to shine the spotlight onto any scams.


add error name to error deser

Now SDK throws error like:
{Error: 1 validation error detected: Value null at 'certificateArn' failed to satisfy constraint: Member must not be null
...

After the change, the thrown error looks like:
{ValidationException: 1 validation error detected: Value null at 'certificateArn' failed to satisfy constraint: Member must not be null
...

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Cool! Curious though -- how does adding "name" make this display better error messages?

@mtdowling name it's like error's "class" which doesn't exist in JavaScript. By default the error name is Error with different error message. Changing name makes it shows the error code from service side, like ValidationException or SignatureMismatchException

@mtdowling Merge?

MDN on Error.prototype.name https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/name


What is Row from the result stream?

Operating System:
Node Version:
NPM Version:
csv-parser Version:

Expected Behavior
Actual Behavior
How Do We Reproduce?
I used the sample from here:
const csv = require('csv-parser')
const fs = require('fs')
const results = [];

fs.createReadStream('data.csv')
  .pipe(csv())
  .on('data', (data) => results.push(data))
  .on('end', () => {
    console.log(results);
    // [
    //   { NAME: 'Daffy Duck', AGE: '24' },
    //   { NAME: 'Bugs Bunny', AGE: '22' }
    // ]
  });

But what is row? I don't need it in my result output.

My dude, this is nowhere near a proper issue. I would recommend reading up on some Node.js fundamentals to understand what you're seeing in your console.


Add memory usage benchmarks

Adding benchmarks for memory usage could illuminate details about datashader's runtime performance that were previously not being measured. Among other things we should benchmark memory usage for different dataset sizes, and see how memory usage changes as datasets grow.

Memory usage takeaways
With memory usage measurements in place, we can start validating the dataframe size and how it corresponds to memory usage in the overall datashader benchmarks. The following statements were added to filetimes.py immediately before the first call to timed_agg, to display the dataframe's per-column memory usage and data types:
mem_usage = df.memory_usage(deep=True)
if p.dftype == 'dask':
    mem_usage = mem_usage.compute()
print('DEBUG:', mem_usage)
mem_usage_total = mem_usage.sum()
print('DEBUG: DataFrame size:\t\t\t{} MB'.format(mem_usage_total / 1e6))
for colname in df.columns:
    print('DEBUG: column "{}" dtype: {}'.format(colname, df[colname].dtype))

The results show that the memory usage of the persisted dask dataframe align with what we'd expect:
$ python filetimes.py times/census.parq dask census meterswest metersnorth race --debug --cache=persist
DEBUG: Cache "persist" mode enabled
DEBUG: Memory usage (before read):      135.733248 MB
DEBUG: read_parquet(times/census.parq, index=False, columns=['meterswest', 'metersnorth', 'race'])
DEBUG: Force-loading Dask dataframe
DEBUG: Memory usage (after read):       5997.34272 MB
DEBUG: Index                 560
metersnorth<PHONE_NUMBER>
meterswest<PHONE_NUMBER>
race            306677314
dtype: int64
DEBUG: DataFrame size:                  5213.477938 MB
DEBUG: column "meterswest" dtype: float64
DEBUG: column "metersnorth" dtype: float64
DEBUG: column "race" dtype: category
DEBUG: Memory usage (after agg1):       7549.800448 MB
DEBUG: Memory usage (after agg2):       8219.004928 MB
times/census.parq            dask    Aggregate1:017.39 (009.76+007.63)  Aggregate2:003.94  In:05213483268  Out:00000625044  Total:026.49

Let's verify these calculations:

Number of rows of data in dataset: 306675004
metersnorth and meterswest are each represented as 8-byte double-precision floats (np.float64); our expected size for each column is 8 x 306675004 =<PHONE_NUMBER> (correct)
race is a categorical data type; each categorical value is represented by a 1-byte integer, which makes it fairly close. The 2310 bytes leftover indicate that pandas probably stores some metadata for categoricals
the index looks strange at first, but after some digging it starts to make sense: in v0.18.0 pandas began using a RangeIndex which dramatically reduces index size by storing metadata about the index (as long as it's sequential). One dataframe index typically takes up about 80 bytes, but since dask was used here, each of the 7 partitions kept its own separate index (probably a RangeIndex), which leads to a total of 560 bytes

Great! And do they change in the appropriate ways (and with what impact on performance?) when changing from doubles to floats?

Yep, they do change, and they do affect performance. I'm opening a PR shortly with some additions to filetimes.py so we can more-easily observe / reproduce this, and see how changing the data types affects performance. I'll also update the post above with the results after converting doubles to floats.

Thanks.  And how does the total memory usage for the process compare with the total usage for the dataframes reported here?  The difference between those two numbers should tell us a lot...

@jbednar I added another section with results for the float32 data after running PR #323 and writing out the data as float32 instead of float64.

Excellent!

Closing this issue, since the memory-usage benchmarks have been added.


Add Gold sponsors to website, we finally have one 🚀

We just need another section, below current Platinum sponsors, that is called Gold and there is RedHat logo
Somehow related https://github.com/asyncapi/website/issues/528
@fmvilas I'm not sure if we need to do something about the logos size, if this section should be kinda smaller or is it ok if it is just below platinum and marked as gold.

@derberg I will love to work on this issue. Kindly assign it to me (if required).
Also, Do provide me with the logo you want to show on the website if you have a particular one.

go ahead, and pick one that works best with current design -> https://www.redhat.com/en/about/brand/standards/logo

Sounds good to me. Regarding size of the logo, I'd say it's a common approach to make them smaller but don't have an opinion. Maybe @mcturco has a better perspective regarding design. What's clear to me is that it should be somehow easy to identify that Platinum are "more prominent" as they're paying more.

@fmvilas oops! Sorry just now seeing your comment here. I think that what we have just merged works for now to have it up on the website ASAP, but yes I was thinking that we could redesign that section to make the Platinum sponsors stand out more than the Gold sponsors.


Added State and Transition constants to React example

Added State and Transition constants so they can be exported and consumed.

I'm coming at this from a newcomers perspective so please excuse me if I have misunderstood the concepts, I am still reading through the docs.
Reading this page: https://xstate.js.org/docs/recipes/react.html#hooks
It seemed that re-writing the example to use state and transitions to constants would be a better pattern.

Thanks for the PR; this would be better as a separate section. For getting started quickly, the additional boilerplate provides noise for little gain.
For maintainable projects, it's a good practice to do what you've done, though!

Thought that might be the case, feel free to close this, I can set up another PR/section in the future if it makes sense after I finish reading the docs.
Or if you have another section in mind happy to move it to that.


Invalid generated source maps unreadable by source-map-explorer

Command
build
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
v15
Description
When I run an ng build with source maps turned on, I can't read them with source-map-explorer (source-map-explorer@2.5.3).
Seems like the generated source map may be invalid?
Minimal Reproduction
git clone github.com/stephenfluin/baby-log/
cd baby-log
yarn
ng build

INstall source-map-explorer wherever you want (yarn global add source-map-explorer)
source-map-explorer dist/baby-log/src_app_home_home_module_ts.js
Exception or Error
src_app_home_home_module_ts.js
  Your source map refers to generated line 23, but the source only contains 19 line(s).
  Check that you are using the correct source map.

Your Environment
Angular CLI: 16.0.0
Node: 16.14.2
Package Manager: yarn 1.22.19
OS: linux x64

Angular: 16.0.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, language-service, localize, material
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1600.0
@angular-devkit/build-angular   16.0.0
@angular-devkit/core            16.0.0
@angular-devkit/schematics      15.2.8
@angular/fire                   7.5.0
@schematics/angular             16.0.0
rxjs                            7.8.1
typescript                      5.0.4

Anything else relevant?
No response

I have similar issue, but in my case error is slightly different:
Error parsing mappings (code 1): the mappings contained a negative line, column, source index, or name index.
It started happening after upgrading to Angular 16.

@StephenFluin did u resolve it by any chance?

I didn't resolve this, but I can't reproduce right now, so perhaps it's
fixed?
On Thu, Sep 14, 2023 at 3:52 AM polonmedia @.***> wrote:

@StephenFluin https://github.com/StephenFluin did u resolve it by any
chance?
—
Reply to this email directly, view it on GitHub
https://github.com/angular/angular-cli/issues/25168#issuecomment-1718228874,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABIJQCZAH4MMEIZQFS4VZTX2IFH3ANCNFSM6AAAAAAX2JREK4
.
You are receiving this because you were mentioned.Message ID:
@.***>


feat: crypt hasher

Checklist

[x] I have read the coding guide
[ ] My change requires a documentation update and I have done it

Description

We now return 403 Forbidden in only one case - when the provided token is valid but does not have sufficient privileges to access the requested resource.
All the other cases will result in a 401 Unauthorized return code.

Added a new command  hasher that can generate a bcrypt hash for a given plain text password. The returned value can be used for admin-password configuration parameter. The tool can also validate that the provided hash matches a plain text password (using the --check option). Note: when checking the hash please make sure to quote it, the shell does not take kindly to the dollar signs in the hash text.

Motivation and context
The hasher command is a handy offline alternative to https://bcrypt-generator.com/
Usage
> bee hasher super$ecret
$2a$10$eZP5YuhJq2k8DFmj9UJGWOIjDtXu6NcAQMrz7Zj1bgIVBcHA3bU5u
> bee hasher --check super$ecret '$2a$10$eZP5YuhJq2k8DFmj9UJGWOIjDtXu6NcAQMrz7Zj1bgIVBcHA3bU5u'
OK: password hash matches provided plain text

This change is

LGTM, but actually I would like to bring up why we actually even need to hash the password? What is the goal?
I guess protection of the password, but I am not sure if it is not overkill? This just seems to me like a bad UX...

LGTM, but actually I would like to bring up why we actually even need to hash the password? What is the goal?
I guess protection of the password, but I am not sure if it is not overkill? This just seems to me like a bad UX...

I don't remember the exact reason (except not having plain text passwords) but there was an explanation given by Janos about this in one of the comments here: https://github.com/ethersphere/bee/pull/2400

LGTM, but actually I would like to bring up why we actually even need to hash the password? What is the goal?
I guess protection of the password, but I am not sure if it is not overkill? This just seems to me like a bad UX...

Yes, as @notanatol said more details are in the previous pr comments, but basic the reason is the same as passwords are not stored in plain text in databases in common web applications. Or, why web servers like apache2 and nginx are doing the same for basic auth configurations. Apache2 and nginx are very popular web servers.

So I wonder whether it would not make sense to pack this as a subcommand in bee. Ideally we would not have this sort of stuff in bee, not sure why this cannot be a command as part of swarm-cli. @agazso input please?

I agree that creating a new binary can make things cumbersome. Alternatively it makes sense to add this functionality to swarm-cli.

OK so in this case I'm going to split this PR in two - one with the fixes (HTTP codes) requested by @AuHau and another one with the embedded hasher.
Then we'll have all the time we need to make a decision if we want this hasher in the binary or a separate js tool.

Maybe it will be worth considering just using something existing as htpasswd: https://unix.stackexchange.com/questions/307994/compute-bcrypt-hash-from-command-line

Oh, I haven't noticed that it is a standalone command. I originally envisioned it as bee's subcommand, so I agree that makes more sense.
Although I would strongly suggest incorporating this functionality directly into bee. The @mrekucci mentioned htpasswd command requires apache-utils package which is a dependency completely unrelated to Bee's stack and requires the user to actually understand what command and what parameters it should use to produce hash compatible with Bee's requirements.
Also, I am not in favor of outsourcing this to swarm-cli as it is directly related to the Bee's configuration and not "Swarm functionality" (which is the domain of swarm-cli). For example, I am doing this hashing as part of Bee Factory setup for the restricted API support and this would require also to install swarm-cli to make it work...

Oh, I haven't noticed that it is a standalone command. I originally envisioned it as bee's subcommand, so I agree that makes more sense.
Although I would strongly suggest incorporating this functionality directly into bee. The @mrekucci mentioned htpasswd command requires apache-utils package which is a dependency completely unrelated to Bee's stack and requires the user to actually understand what command and what parameters it should use to produce hash compatible with Bee's requirements.
Also, I am not in favor of outsourcing this to swarm-cli as it is directly related to the Bee's configuration and not "Swarm functionality" (which is the domain of swarm-cli). For example, I am doing this hashing as part of Bee Factory setup for the restricted API support and this would require also to install swarm-cli to make it work...

@AuHau I moved it to be a bee sub-command, feel free to give it a try.

Also, I am not in favor of outsourcing this to swarm-cli as it is directly related to the Bee's configuration and not "Swarm functionality" (which is the domain of swarm-cli). For example, I am doing this hashing as part of Bee Factory setup for the restricted API support and this would require also to install swarm-cli to make it work...

I guess here we are not 100% agreeing (which is fine). IMO it is not in bee's responsibility to hash passwords just as much as it does not have an explicit command that generates you with a V3 ethereum key (you use external libraries for that). It also also raises the question on what is exactly the responsibility of swarm-cli. For me swarm-cli can easily be a sort of apache-utils suite. Just some thoughts.

Ups sorry 😅  Mis-click 🙈
Just wanted to write that I have tried it and LGTM! 😅

And ad @acud:
I guess I agree with you, except that until now "configuration of Bee" is not really domain of swarm-cli and that was why I have though of Bee's CLI as better place to put it. If swarm-cli will start to be in the configuration business of Bee then I agree there it would make more sense...

go run $(pwd)/cmd/bee bcrypt --check super$ecret `go run $(pwd)/cmd/bee bcrypt super$ecret
OK: password hash matches provided plain text


[Feature Request] Button for copying last Sample names to next Source names

Is your feature request related to a problem? Please describe.
If a workflow of several assays is installed (e.g. in the Proteomics Template: Sample preparation → Measurement → Data procession), one has, in most cases, to copy the Sample names of the previous assay to the Source names of the following.
Describe the solution you'd like
A button that automatically copies all entries of the Source name column of the previous (non-selected) worksheet (that, btw., MUST contain a Swate table) and paste it into the Sample name column of the current worksheet (that also MUST contain a Swate table of course).
Describe alternatives you've considered

The same like above but it doesn't have to be the Source name column of the target worksheet. It just pastes it into the column selected (which can be any kind of column).
Just copypasting yourself which is the standard procedure atm.

Additional context
May be rather low priority since the alternative (see above: 2.) is so easy to perform. It would rather be a comfort feature.

This issue will be handles as part of #167.


Understand and explain LED Bar in more depth

[ ]  add instructions for how to understand the part (with reference to datasheet)

Not required for this part


Tiny checkmarks in track gear menu

The checkmarks are tiny in the gear menu. I think this was fixed in the latest igv.js, but the web-app is using 2.2.4.

This was fixed a long time ago.


Fix 404 to android 3.3.0 Android platform guide

oh, didn't check previously as GitHub automatically created the fork and PR. Mine fixes also the iOS platform guide link which is broken as well: #296

:+1:


Run regular XCM test

idea: cron job in github action on bridge/UI repo to test XCM every X hours with chopsticks to validate that XCM is still working considering runtime upgrades

If we ignore the UI part, it'll be straight forward to test - we can just have a ts script that does a bunch of xcm transfers, and then checks if the tokens arrived. I would suggest doing this in 2 steps:

[ ] Write TS script to make and check xcm transfers
[ ] Write a cron job or bash script to start a new chopsticks instance, and to launch the script (and report errors if there are any)

You don't actually need to write a cron job but rather write the cron job as a github action using the schedule trigger: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule
So something along those lines:
# in .github/workflows/xcm-prod-test.yml
on:
  schedule:
    - cron: '30 9 * * *'

jobs:
  test_schedule:
    runs-on: ubuntu-latest
    steps:
      - name: Test XCM Interlay
        run: yarn test ...
      - name: Test XCM Kintsugi
        run: yarn test ...

Here's the link of how to setup a matrix: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#example-using-a-multi-dimension-matrix

Completed with PRs #57 and #66


Expanded and updated examples.

Refactored examples getStreaming.js and getStreamingWiFiDirect.js

Removed dead code
Renamed variables
Variables properly classed into const and let
Improved readability
Eliminated functional redundancies

Added example xstreamCSV.js

Direct WiFi
Pipes data from OpenBCI hardware into an XStream producer
Outputs to console, CSV (via WriteStream) using listeners

Thanks @jagrafft
Great work!

@andrewjaykeller Thank you!
OpenBCI and the WiFi Shield were a huge find for me and my lab. It's likely I'll be actively developing on the platform for the foreseeable future, and I will continue to submit pull requests as I work with the codebase(s).


proposal: crypto/x509: decryption of PEM file failure not being caught

I'd like to propose a way of early and fast detection of PEM decryption errors.
How this check works: it uses the ASN.1 basic encoding rules (BER) to parse the first length field.  This length field will contain a number which, when [properly decoded and] parsed, contains the length of the PEM encoded message blob (plus the 2-4 bytes declaring this length).  The power of doing this size comparison check via length field is that the decoding routine will then have a verification, with high certainty, that the blob was decoded properly -- and since this does not depend on knowing which kind of crypto pkcs PEM file is being decoded, it is not tied to the knowing or testing any of the pkcs formats; thus it is forward compatible.
Please see the proposal here
https://go-review.googlesource.com/c/proposal/+/281454
and pull request here
https://github.com/golang/go/pull/43463
View pull request discussion here
https://go-review.googlesource.com/c/go/+/281112
resolves issue:
#10171

/cc @rolandshoemaker

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

Agreed. I don't see a pressing need for this, and there are better avenues to pursue if we want to provide better PKCS encryption options.

No change in consensus, so declined.
— rsc for the proposal review group


Improved spring-cloud-wiremock documentation

Sometimes people want to use methods like addMockServiceRequestListener, which are not static. But there is no any notes about  WireMockServer in spring-cloud-wiremock documentation.
I saw how the developers did not know about it and made a mistake.
They mixed junit4 and junit5 even for new services, because WireMockRule inherits from WireMockServer and  provides non static methods.
This situation may seem funny, but many can get into it.

Codecov Report

Merging #780 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #780   +/-   ##
=========================================
  Coverage     51.87%   51.87%
  Complexity     2020     2020
=========================================
  Files           245      245
  Lines          9427     9427
  Branches       1471     1471
=========================================
  Hits           4890     4890
  Misses         3789     3789
  Partials        748      748

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31eab3e...f746871. Read the comment docs.

Congrats @ioanngolovko on your first contribution :)


stats.hasWarnings() should respect warningsFilter (or there should be an API for that)

Feature request

What is the expected behavior?
stats.warningsFilter allows flagging warnings to be irrelevant, so they aren't logged. But hasWarnings() will still return true in cases where all warnings were ignored. This results in (my opinion) weird behavior in other tools which use this API. E.g. you get output like this:

"Compiled with warnings." is shown, but no warning is shown (which is logical, because the only warning was filtered out).
What is motivation or use case for adding/changing the behavior?
In our build setup there is one kind of warning we currently ignore with stats.warningsFilter, because it is not relevant for us. Seeing "Compiled with warnings." messages in the build log however confuses other developers who need to build the project, but don't know about our specific build configuration. We do want to see warnings in other cases, but if the only warning in the build is the one we actually filtered out, we want a successfully compiled response. In this case we want hasWarnings() to actually return false.
How should this be implemented in your opinion?
I guess this is the call which needs to be modified so it uses static filterWarnings: https://github.com/webpack/webpack/blob/9f16238054bad5c3ec62d24c41b12625defa72e5/lib/Stats.js#L70. Sadly it looks like the warningsFilter are only created in the toJson method with help of the options param. Not sure if it would be possible top access options on the compilation as well or if we would need to allow passing options to the constructor as well? 🤷
If this is too disruptive I could imagine to make this an optional flag: stats.hasWarnings({ warningsFilter }) ( if the caller should be in charge to pass warningsFilter) or stats.hasWarnings({ filter: true }) (if it should be just a flag to show you're interested in the filtered results).
Are you willing to work on this yourself?
yes

From the closed MR:

I probably refactor this a bit for the next major,

@sokra, has this issue changed for webpack v5?

Ref for use case - https://github.com/webpack-contrib/source-map-loader/pull/50

bump

Afaik this is fixed by using ignoreWarnings on root level


Docker Fix for Gitlab Feature Collector

Had the wrong filename, so wasn't taking the properties.

@tabladrum LGTM


Support yielding promise => cancellation-token in coroutines

This PR uses the key => value generator syntax to support yielding a cancellation token with a promise as a convenient way of providing an escape to yielding promises that slowly or never resolve.

Thoughts on this? Is this providing a convenient syntax for a common use-case or hiding too much?
yield $socket->enableCrypto() => new TimeoutCancellationToken(100);
// vs.
yield \Amp\Promise\cancellable($socket->enableCrypto(), new TimeoutCancellationToken(100));

The short syntax is a bit weird imo. Sorry to be negative.

@joshdifabio No reason to be sorry. @kelunik and I just came up with this idea and we're looking for feedback. The function Amp\Promise\cancellable() will definitely be added (not necessarily with that name), but I'm not sure about the coroutine syntax yet.

Closing this as it seemed like an interesting approach, but overall it's unclear what's happening. I'll consider opening another PR for just the cancellable function.


Introduce JsonRenderer that know how to render json based on the chosen style

A minor enhancement to compact render to optionally render null nodes, just like can be done when pretty render. This will also enable removal of the custom render code in the http4k format module.

Thanks, merged! I'm planning to release 2.0.0 soon.
I want to keep the the old methods with an obsolete annotation for a couple of versions anyway.


The error occurs as soon as the external overlay display research is completed.

The error occurs as soon as the external overlay display research is completed.
Error while running event factorissimo-2-notnotmelon::on_research_finished (ID 18)
factorissimo-2-notnotmelon/script/overlay.lua:15: attempt to index field 'building' (a nil value)
stack traceback:
factorissimo-2-notnotmelon/script/overlay.lua:15: in function 'build_display_upgrade'
factorissimo-2-notnotmelon/control.lua:819: in function <factorissimo-2-notnotmelon/control.lua:808>
There have been no issues with any other research up to this point (including other research projects within Factorissimo2).
The error only occurs with the display overlay research.

Here is the list of mods applied to the map. Please refer to it.
» base 2.0.11

CleanFloor 2.0.0
keep-inventory 1.2.1
VehicleSnap 2.0.0
aai-containers 0.3.1
aai-loaders 0.2.3
Actual_Craft_Time_20.6.5
Adjustable-Inventory-Size 2.2.0
Advanced-Electric-Revamped-v16 0.7.1
BeltSpeedMultiplier 1.0.2
BetterAlertArrows 1.1.0
BlackModule 0.1.46
bullet-trails 0.7.1
CheaperGears 1.0.0
CheaperSteelProdE 1.0.0
ConfigurableMiningDrills 1.0.0
ElectricFurnacesRevamp 1.1.1
ElectricPoleRangeMultiplier 1.0.1
even-distribution 2.0.2
» factorissimo-2-notnotmelon 1.5.11
FactorySearch 1.12.1
far-reach 2.0.0
Fill4Me 0.11.2
flib 0.15.0
informatron 0.4.0
inventory-repair 20.0.1
jetpack 0.4.4
large-storage-tank 1.2.0
Load-Furn-2-SpaceAgeFix 0.2.5
MachineSpeedMultiplier 1.1.0
pump 2.0.1
RitnLib 0.9.1
shield-projector 0.2.1
some-squeak-through 2.0.0
Teleporters_SpaceAge 1.1.0
TinyStart-2 1.2.2
Tiny_Equipment 2.1.0
Warehousing 0.6.0
Waterfill_v17 2.0.2
yo-tweak-robots 2.0.1
zzzz9999-better-restack 1.1.10
aai-loaders-reduced-cost 0.0.4

BottleneckLite 1.3.0

cybersyn 2.0.6
fluid-connection-indicators 0.2.1
Milestones 1.4.1
RateCalculator 3.3.1


hcloud: 1.38.3 -> 1.40.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/hetznercloud/cli/releases.
meta.description for hcloud is: A command-line interface for Hetzner Cloud, a provider for cloud virtual private servers
meta.homepage for hcloud is: https://github.com/hetznercloud/cli
meta.changelog for hcloud is: https://github.com/hetznercloud/cli/releases/tag/v1.39.0
Updates performed

Golang update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.39.0 with grep in /nix/store/yycrkwm4fbj6cnrswnmi1y08mphg8w3f-hcloud-1.39.0
found 1.39.0 in filename of file in /nix/store/yycrkwm4fbj6cnrswnmi1y08mphg8w3f-hcloud-1.39.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
hcloud

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/yycrkwm4fbj6cnrswnmi1y08mphg8w3f-hcloud-1.39.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A hcloud https://github.com/r-ryantm/nixpkgs/archive/8d66ab54ed8ca433ab975fc4bd1b7e0d02ff0cbb.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8d66ab54ed8ca433ab975fc4bd1b7e0d02ff0cbb#hcloud

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/yycrkwm4fbj6cnrswnmi1y08mphg8w3f-hcloud-1.39.0
ls -la /nix/store/yycrkwm4fbj6cnrswnmi1y08mphg8w3f-hcloud-1.39.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

hcloud

Maintainer pings
cc @elmarx @techknowlogick for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/hcloud/versions.
meta.description for hcloud is: A command-line interface for Hetzner Cloud, a provider for cloud virtual private servers
meta.homepage for hcloud is: https://github.com/hetznercloud/cli
meta.changelog for hcloud is: https://github.com/hetznercloud/cli/releases/tag/v1.40.0
Updates performed

Golang update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.40.0 with grep in /nix/store/ipinclwrwa90j9mw4mgdfb48kbn666vn-hcloud-1.40.0
found 1.40.0 in filename of file in /nix/store/ipinclwrwa90j9mw4mgdfb48kbn666vn-hcloud-1.40.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
hcloud

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ipinclwrwa90j9mw4mgdfb48kbn666vn-hcloud-1.40.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A hcloud https://github.com/r-ryantm/nixpkgs/archive/6ed8feeec15696a8e2350efe4a387f96e98da623.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/6ed8feeec15696a8e2350efe4a387f96e98da623#hcloud

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ipinclwrwa90j9mw4mgdfb48kbn666vn-hcloud-1.40.0
ls -la /nix/store/ipinclwrwa90j9mw4mgdfb48kbn666vn-hcloud-1.40.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

hcloud

Maintainer pings
cc @elmarx @techknowlogick for testing.

Result of nixpkgs-review pr 265295 run on aarch64-linux 1

1 package built:

hcloud


Several Markers with nested InfoWindow

I noticed that InfoWindows aren't closed when you open an other InfoWindow if more than one Marker with a nested InfoWindow is used.
Code Snippet:
<MarkerCluster :options="clusterOptions">       <Marker         v-for="(item, index) in markers"         :key="index"       >           <InfoWindow>              Dummy Content passed through slot           </InfoWindow>       </Marker> </MarkerCluster>

I would argue this is the expected behavior but happy to be proven otherwise


crust-firmware: untagged-2023-02-28 -> 0.6

It would be nice to include in a release tagged (released) version of the program.

Sorry it took a while to get to this, I verified it all still builds. Not verified the results, but given the project and how it operates, there is no reason to think there will be an issue. If there is, it will be picked-up when testing later on.
Thank you!


Update from original

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)
Update from original

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:kernoslabs/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

I assume this was opened by mistake, so i'll close this PR


DCOS-6165: Force user email address to wrap

Should we have a native browser tooltip on the email, if we are potentially hiding parts of it?

Good call @mlunoe, opened a separate PR for that.


Bug : Conflict dropdown-toggle with ui-bootstrap.0.11.0.js

I have a  tag. The first time I click on it,it opens and then suddenly closes without allowing me to see its content. Except the first time it works correctly.I think it's because of conflict between dropdown-toggle and ui-bootstrap.0.11.0.js

@SamiraJafari I am sorry but your plunkr is cluttered. I will close this issue for now. Feel free to reopen once you come up with a clear and minimal reproducible plunkr.
rgds