Cannot parse splash:html() returned item

I am trying to parse a response from a SplashRequest execute endpoint but seem to be unable to, would you be able to help me figure out what i am doing wrong? run log is attached and code below:
import scrapy
from scrapy_splash import SplashRequest
class Kapow_crawler(scrapy.Spider):
    name = "Kapow_crawler"

    def start_requests(self):

        urls = [
            "https://vmatrix1.brevardclerk.us/beca/name_search.cfm"
        ]
        for url in urls:
            yield SplashRequest(url=url, callback=self.parse_first_page, endpoint='render.html')

    def parse_first_page(self, response):
        id_list=[]
        inputs = response.css('input').extract()
        input_count = 0
        for inp in inputs:
            input_count = input_count+1
            if 'Yes'.upper() in inp.upper():
                disc_yes = input_count -1
                try:
                    id_list.append(['id',response.css('input::attr(id)')[disc_yes].extract()])
                except Exception:
                    id_list.append(['name',response.css('input::attr(name)')[disc_yes].extract()])
                if 'radio'.upper() in inp.upper():
                    inputs = response.css('input').extract()
                    input_count = 0
                    for inp in inputs:
                        input_count = input_count+1
                        if 'Submit'.upper() in inp.upper():
                            disc_submit = input_count -1
                            try:
                                id_list.append(['id',response.css('input::attr(id)')[disc_submit].extract()])
                            except Exception:
                                id_list.append(['name',response.css('input::attr(name)')[disc_submit].extract()])
            elif 'Accept'.upper() in inp.upper():
                disc_accept = input_count -1
                try:
                    id_list.append(['id',response.css('input::attr(id)')[disc_accept].extract()])
                except Exception:
                    id_list.append(['name',response.css('input::attr(name)')[disc_accept].extract()])
        buttons = response.css('button').extract()
        button_count = 0
        for button in buttons:
            button_count = button_count +1
            if 'Yes'.upper() in button.upper():
                disc_yes = button_count -1
                try:
                    id_list.append(['id',response.css('input::attr(id)')[disc_yes].extract()])
                except Exception:
                    id_list.append(['name',response.css('input::attr(name)')[disc_yes].extract()])
            elif 'Accept'.upper() in button.upper():
                disc_accept = button_count -1
                try:
                    id_list.append(['id',response.css('input::attr(id)')[disc_accept].extract()])
                except Exception:
                    id_list.append(['name',response.css('input::attr(name)')[disc_accept].extract()])
        if len(id_list) == 1:
            disclaimer_script="""
            function main(splash)
              assert(splash:go("{0}"))
              assert(splash:wait(0.5))
              local disc_accept = splash:select('[{1}="{2}"]')
              assert(disc_accept:mouse_click())
              assert(splash:wait(0.5))
              return splash:html()
            end
           """.format(response.url,id_list[0][0],id_list[0][1])
        if len(id_list) == 2:
           disclaimer_script="""
           function main(splash)
             assert(splash:go("{0}"))
             assert(splash:wait(0.5))
             local disc_check = splash:select('[{1}="{2}"]')
             local disc_sub = splash:select('[{3}="{4}"]')
             assert(disc_check:mouse_click())
             assert(disc_sub:mouse_click())
             assert(splash:wait(0.5))
             return splash:html()
           end
           """.format(response.url,id_list[0][0],id_list[0][1],id_list[1][0],id_list[1][1])
        if len(id_list) >= 1:
            yield SplashRequest(url=response.url, callback=self.parse_second_page,
endpoint='execute',args={'har':1,'html':1,'lua_source':disclaimer_script,'wait':0.5})
        else:
            yield SplashRequest(url=response.url, callback=self.parse_second_page,
endpoint='render.html')

    def parse_second_page(self, response):
        inputs = response.css('input').extract()
        for inp in inputs:
            yield print(inp)

log.txt

Hey @Swordyjohn there are no errors in the log and the first request is being made via splash as expected. If you have general scrapy questions, stackoverflow would be a better place. If you have some scrapy-splash question, please be more specific.

Hello @lopuhin, I really just need to figure out how to parse the returned splash:html() from the SplashRequest. On Stack Overflow I have seen similar questions that have gone unanswered and I cannot seem to understand from the doc's how to parse this. From the Scrapy docs i can see that you can pass response from one parse func to another (https://doc.scrapy.org/en/latest/topics/request-response.html) but it does not seem to work in this case. Is it possible to parse a splash html response?

Is it possible to parse a splash html response?

@Swordyjohn yes, if everything is configured correctly for scrapy-splash (see README), then if you are using render.html endpoint, response should work like a usual scrapy response. If you suspect that the problem is here, I suggest dropping into a debugger and examining what is this response - at least it's type, and then either it's an issue with response, or it's an issue in the parse method. Also note that exact html returned by a normal scrapy spider and a spider which is using splash can be different, because splash is running a real browser (this is the same difference in html which you can get in spider vs. regular browser).

Hello @lopuhin I have parse the render.html endpoint response in the original parse function, i have printed it while testing so It appears that splash is configured correctly. The issue i am having is parsing the response from the 'execute' endpoint, really i am asking if it is possible to pare the html which should be returned from the execute endpoint request. Thank you for your assistance I sincerely appreciate it :)

really i am asking if it is possible to parse the html which should be returned from the execute endpoint request.

ah I see - sorry I didn't get that at first. Yes it's possible but requires some extra steps, you need to make sure that your splash script returns results in correct format (with correct keys), see this section https://github.com/scrapy-plugins/scrapy-splash#responses - e.g. you need to return html in the "html" field, then it will be picked up.

@Swordyjohn can you show the splash script you are using? Because the one in the issue just returns html, instead of something like:
return {
        html = splash:html(),
        -- ... other fields you might need
    }

which is recommended by the README

The original script is the one I am using, with the lua script defined by the variable disclaimer_script. Is that what you are referring to as the splash script? The different methods I have tried in my above comment are related to the parse_second_page function defined in the original script. The fact that it returns html as you state is what I believe is desired, as I would like it to return html to be parsed by python if possible.

Is that what you are referring to as the splash script?

yes

The fact that it returns html as you state is what I believe is desired, as I would like it to return html to be parsed by python if possible.

I'm not 100% sure that's supported, but it might also work. To be clear, by "it" I mean return splash:html() instead of return {html = splash:html()} which I'm sure should work.

       function main(splash)
         assert(splash:go("{0}"))
         assert(splash:wait(0.5))
         local disc_check = splash:select('[{1}="{2}"]')
         local disc_sub = splash:select('[{3}="{4}"]')
         assert(disc_check:mouse_click())
         assert(disc_sub:mouse_click())
         assert(splash:wait(0.5))
         return {html = splash:html()}
       end

like that?
when i run it and attempt to parse the response with yield print(response.data['html']) i get
KeyError: 'html = splash'

yield print(response.data['html']) i get KeyError: 'html = splash'

Hmm that's strange, you are using response.data['html'], not response.data['html = splash'], right? In any case, with such a script response.css should already work.
I think we really need an example spider with a lua script, currently we have only a render.json example here https://github.com/scrapy-plugins/scrapy-splash/blob/e40ca4f3b367ab463273bee1357d3edfe0601f0d/example/scrashtest/spiders/quotes.py - I'll see if I can add it next week.

@Swordyjohn Did you even manage to solve your issue?

@gallaecio unfortunately not, I ended up switching to a selenium framework for scraping, it was just easier to use for JS heavy sites. I would love to get scrapy-splash working, but I no longer work in web scraping so the need is no longer there.

This is definitely a bug.
return {     --html = splash:html(),     png = splash:png(),     har = splash:har(),   }
Decodes into json propertly. Note that html is commented out.
On the other hand, when I uncomment splash:html()
return {     html = splash:html(),     png = splash:png(),     har = splash:har(),   }
raise JSONDecodeError("Expecting value", s, err.value) from None json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
This is how I deserialize
    def parse(self, response):         splash_response = json.loads(response.body_as_unicode())         logging.info(f'response: {splash_response}')


Simple hack to display multiple instances

Use the "x" key to show more copies, "z" key to show fewer. It's limited to 256 at the moment as I find there are artifacts with more instances. This is hacky and pretty much made just for demo purposes, so not sure whether I want to check it in just yet.

Is this ok to close? @raphlinus

Raph added a thumbs up here, so I'll close it


helm release from Jellyfin is called Mosquitto

https://github.com/xUnholy/k8s-gitops/blob/main/k8s/namespaces/base/home-system/jellyfin/app/helmrelease.yaml#L5
Should be called: 'mosquitto'

Fixed, thanks for spotting!


sarif-fmt: init at 0.4.2

Description of changes
sarif-fmt is a CLI tool to pretty print SARIF diagnostics. It is a part of the sarif-rs group of projects
related to #266558
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 266570 run on x86_64-linux 1

1 package built:

sarif-fmt

The darwin build fails error[E0463]: can't find crate for profiler_builtins`
https://github.com/NixOS/nixpkgs/blob/c40ee67f05e978a7eaf9c7e24fbca4fdac26f90c/pkgs/development/compilers/rust/rustc.nix#L143
asked in the nix rust matrix room about enabling profiling on darwin

Result of nixpkgs-review pr 266570 run on x86_64-linux 1

1 package built:

sarif-fmt

Test still fails, either skip it on darwin or mark broken on darwin.

Remember to include the reason why it's disabled in the comment. Added it for you.


why is  n/file-extension-in-import a stylic?

i don't consider  file extension as something that is stylic
it's more of a problem if you want to trully run ESM scripts that demands that you use file extension
it will possible only work b/c someone is using a build script anyways.
i think demanding a extension should be a recommended rule.
when using remote path resolver like http import you can't guess what you meant to import cuz you do not have access to the fs
https://nodejs.org/dist/latest-v18.x/docs/api/esm.html#mandatory-file-extensions (<-- mandatory is in the link desc)
https://github.com/standard/standard/issues/1674

I agreed it's more like an "possible errors" rule. it's just the original implemention a few yerars ago.

well, I think it's time to rethink the rule. It was written when the node.js esm was not stabilized. Nowadays it's stabilized in node v12. time to make some changes.

renaming to file-extension, and also check requires(common.js). the rule was only checking imports. but some devs may still  want to use file extensions for some reasons.

more configurable:

"n/file-extension-in-import": [2, { "requires": "always", "imports": "always"}

recommended preset changes:
a. recommended-script:

"n/file-extension-in-import": [2, { "requires": "never"}

b. recommended-module:

"n/file-extension-in-import": [2, { "requires": "always", "imports": "always"}

do you mean the meta.docs.category?
https://github.com/weiran-zsd/eslint-plugin-node/blob/d7b975a07e1b876ca2c75597d054a81564b25685/lib/rules/file-extension-in-import.js#L40
it's not actually used anywhere, and eslint has removed it in all its core rules.

I think both of import(x) and require(x) should by default require file extensions
It don't hurt to use extension in CommonJS too. in fact it makes things faster to lookup and also easier for build tools to not having to 2nd guess what you meant to import. it only complicates things further and they need to apply to the same rule as node.js resolve algoritm over at: https://nodejs.org/dist/latest-v18.x/docs/api/modules.html#all-together (which is just insane)
Ryan dhal regretted all of it and it is not how the web/esm works.
more and more ppl are switching over to esm and refactor cjs to esm is no easy task as just simply switching out all require calls to import() and using the same path. it needs to solve the path to index.js as well if things where just require('./index.js') then it would be as simple as just changing it to an import statement and an auto fix would be easier to write.
After reading The cost of many small modules i made a bench test that tried to require many files with and without file extension and using index.js vs just a normal name such as mod.js
And the script loaded faster if the path was more explicit as it did not have to stat files/folder to look up as many files to quickly figuring out what you ment to import

any progress on this part? would like to resolve https://github.com/standard/standard/issues/1674 but are a bit blocked

If we want to convert n/file-extension-in-import to a recommended rule, can we create another issue for this please? 🙏


Dynamically setting a ROI or AE set point

Required Info

Camera Model
D435f

Firmware Version
<IP_ADDRESS>

Operating System & Version
Linux Ubuntu 20

Kernel Version (Linux Only)
5.15.0-89-generic

Platform
PC

SDK Version
2.50.0

Language
C++ + OpenCV

Segment
Robot

Issue Description
We are thinking of transitioning from D435i to D435f to improve the behaviour with repetitive structures. While doing a performance comparison between both cameras, we have noticed that while the D435f yields much better performance when bright spots (like lighting on the ceiling) exists in the scene, it performs quite poorly when relatively small objects like hands are close to the camera (less than 0.5 meters) in large scenes. In contrast, the D435i still performs pretty well on the same scene.
This of course happens because the D435f filters quite a bit of the visible light and then on short distances, pretty much only IR light from the projector is present, over-exposing the area, and consequently the depth information is lost. Our assessment is that the AE is actually working pretty well when the ROI is correct. The problem is that in such a large scene (e.g., a long room), objects that are within the detection range of the camera have the same consideration as objects that are outside the detection range of the camera. The former become overexposed and lost in the depth because the IR imagers are simply compensating for overall luminance.
Approach
We have dived into the depths of the issues here and the white papers and have tried a few approaches based:

Set a ROI dynamically to some calculated tiles (i.e,. by calling rs2::sensor::set_region_of_interest())
Set the AE set point dynamically to prevent overexposing some of our areas of interest (i.e., by calling rs400::advanced_mode::set_ae_control())

From a qualitative perspective, both approaches seem to work -depth is not lost and the overall image quality is preserved, however, both are dramatically slow (approximately, a 66% of the frames are dropped if you set either values on every frame).
Questions

Is there a way to achieve what we need and keep a decent frame rate?
Is there any other setting we need to adjust to prevent dropping as many frames? - Not counting tricks like setting it every other frame and whatnot
Are there other recommended settings to compensate for over-exposed areas?

Some of our constraints:

Must use AE since lighting changes a lot throughout the year
Setting gain or exposure limits are not an option because large lighting changes
Cannot set a static ROI since objects can show up on any area of the image
Scenes have a lot of motions from many agents happening at the same time
Repetitive structures are present
Hardware is fixed and the re-positioning of the cameras is not an option

Hi @mjc6fe  I would recommend dropping the processing-heavy method of updating the ROI on every frame and instead explore the possibility of helping the camera to handle situations of under-exposure and over-exposure better by using the High-Dynamic Range (HDR).feature, which allows two distinct exposure values to be used.
https://dev.intelrealsense.com/docs/high-dynamic-range-with-stereoscopic-depth-cameras
In HDR mode auto-exposure is disabled, though you may find that the ability of the HDR mode to alternate between two exposures can still enable the camera to cope with lighting changes throughout the year.

Hi @mjc6fe  Do you require further assistance with this case, please?  Thanks!

Hi @MartyG-RealSense, we don't need any further assistance for the time being, but thanks for your input!

You are very welcome.  Thanks very much for the update!


fix disabled

When I set disabled to true, it was trying to hide the pikaday element before the pikaday element existed.

Now it hides the pikaday element after it is created.

Thanks for discovering and fixing this, in addition to your pull request I added a test to guard against future regressions.


[WIP] [feat] Add enableCache prop

This PR 'fixes' https://github.com/react-native-community/react-native-webview/issues/128
cc @Titozzz @jamonholmgren as per linked issue above. Let me know your thoughts and if anything needs changing. I've enabled it by default as discussed with @Titozzz  on slack.
Checklist

[x] Android support
[x] iOS support
[x] Flow Types updated
[x] Reference Documentation updated

Release Notes

[BREAKING] [FEAT] Added a new enableCache prop to toggle Android & iOS webview caching behavior. This change makes caching enabled by default when previously there was no caching behavior which may cause unexpected behaviour changes in your existing implementations.

I need to do a few minor changes for Android still, please don't merge yet. Thanks
https://developer.android.com/reference/android/webkit/WebSettings.html#setAppCacheEnabled(boolean)
https://developer.android.com/reference/android/webkit/WebSettings.html#setAppCachePath(java.lang.String)
Both needed as well.

Right, this should be good to go now, cc @Titozzz @jamonholmgren

Hey there! Thanks for your work! Is there anything stopping this PR from getting merged (besides the conflicts now)?

Yeah, it needs testing, because when I tested it I did not feel the expected improvements

I think this cacheEnabled prop is missing from the typescript prop type declarations (intypings/index.d.ts) so I've opened a PR for that: #335


[bug] Domains getAll

Hey,
Started using this library for a Git managed DNS and Firewall setup we are creating at work (we have probably 150 domains)
During my testing I have run into an issue specifically with the domains.getAll() functionality but I assume it affects many other all functions due to the problem existing within the request-helper
The issue is only apparently when running:
doAPI.domains.getAll('', true)
        .then((response) => console.log(response))
        .catch((err) => console.log("Error:", err))

I receive an error with
TypeError: Cannot read property 'total' of undefined
at .../node_modules/do-wrapper/dist/request-helper.js:90:31

I took a look into the dist copy of my request-helper and played around until I found there to be multiple issues relating to how the Promises are managed for the multi-request setup.
Namely:
Request Helper:
    private submitRequest(options: any, callback: any): void {
        const requestOptions = this.requestBuilder(options);

        got(this.apiUrl + options.actionPath, requestOptions)
            .then((response: any) => {
                callback(response.body);
            })
            .catch((error: any) => {
                callback(error);
            });
    }

The callback(response.body) does not match required callback in getAllPages which makes total = body.meta.total; attempt to fetch meta on undefined.
I also found that even if I fixed the callback the response was never run through a parse so it's attempting to fetch meta and total on a string which obviously doesn't work.

Hoping the below changes will help with understand what I mean and potentially can be used to fix the issue, I would add a PR for these changes but I haven't got the setup to test other use cases past domains and records.
/src/request-helper.ts
Lines 58-60
            .then((response: any) => {
                callback(null, JSON.parse(response.body));
            })

Lines 90-115
        this.submitRequest(options, (err: any, body: any) => {
            if (err) {
                callback(null, err);
            }

            total = body.meta.total;
            items = items.concat(body[key]);
            required = Math.ceil(total / (options.qs.per_page || 25));

            if (items.length >= total) {
                return callback(items);
            } else {
                this.getRemainingPages(options, 2, required, function (err: any, response: any, body: any) {
                    if (err) {
                        callback(null, err);
                    }

                    completed++;
                    items = items.concat(body[key]);

                    if (completed === required) {
                        callback(response);
                    }
                });
            }
        });

With the above changes, the callback to submitRequest drops support for 'response' being an outcome, fixes the callback from submitRequest to match the expected callback from request  which is (body, error)
Also makes sure body is parsed.
I might be entirely missing the idea or something as I rarely dabble in Promise stuff.
Thanks.

@TisRyno yep this looks like a bit of an oversight, I'll look in to this and get it fixed.

@TisRyno this should be fixed as of v4.0.0-alpha.4


Helm Chart with null digest fails to display

Describe the bug
Currently, there is a bug in K8 IDE Lens when adding a GitLab repository as a Helm repository. The issue arises because GitLab does not set the "digest" field in the index.yaml file, which causes charts from the GitLab repository not to be displayed within Lens.
To Reproduce
Open K8 IDE Lens.
Navigate to the Helm Repositories section.
Add a GitLab repository as a Helm repository.
Attempt to view the charts from the GitLab repository.
Expected behavior
The Helm charts from the GitLab repository should be displayed and accessible within Lens.
Actual Behavior
The Helm charts from the GitLab repository are not displayed within Lens due to the missing "digest" field in the index.yaml file.
Screenshots

Environment (please complete the following information):

Lens Version: 2023.10.181418-latest
OS: Windows 10

Same behavior with our GitLab repository.


Remove: InfiniteRed.Reactotron.Pre-release version <IP_ADDRESS>6

The stable version has been released and the pre-release versions can be removed

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/infinitered/reactotron/releases/download/reactotron-app%403.0.0-beta.35/Reactotron.3.0.0-beta.35.msi
Response status code does not indicate success: 401 (Unauthorized).
(Automated message - build 656)


Fix incorrect description of glob matching

Description of the change
The previous description of how globs are matched is incorrect.
Since the underlying "evaluation engine" is simply an OPA policy (which is described here), the Golang doublestar library has nothing to do with the evaluation. OPA uses its own built-in glob evaluation, which does not follow the same rules as doublestar.
Additionally, if any custom push policies are attached, the default policy gets thrown out; it's purely up to those policies to interpret the project globs however they see fit (if at all).
This PR modifies the glob section to point to the correct documentation for pattern matching, and updates the examples for quality and accuracy.
Checklist
Please make sure that the proposed change checks all the boxes below before requesting a review:

[x] I have reviewed the guidelines for contributing to this repository.
[x] The preview looks fine.
[ ] The tests pass.
[x] The commit history is clean and meaningful.
[x] The pull request is opened against the main branch.
[x] The pull request is no longer marked as a draft.
[x] You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
You have updated the navigation files correctly:

[x] No new pages have been added, or;
[ ] Only nav.yaml has been updated because the changes only apply to SaaS, or;
[ ] Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
[ ] Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.
Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.
Thank you for your contribution! 🙇

👋🏻 @spacelift-io/solutions-engineering


Perf testing between deepspeed and FSDP

Ensure performance does not degrade if we switch deepspeed to FSDP for Nvidia support

Hey @Maxusmusti just as an FYI - I have a PR tee'd up to change the default training backend: https://github.com/instructlab/instructlab/pull/2526
Once the work in this ticket is complete we can merge that in!

I can confirm performance (throughput/memory/time-to-train) is within acceptable bounds to switch to FSDP as default, you can go ahead with #2526


Release new version of jest-environment-enzyme

5 months ago this PR was merged https://github.com/FormidableLabs/enzyme-matchers/pull/339
But this changes was not published to NPM.
Could you please publish it?

@blainekasten can you please share the current release plans?

This release is necessary for Node 14 support:
jest-enzyme > jest-environment-enzyme > jest-environment-jsdom > @jest/environment > @jest/transform > jest-haste-map ><EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.

This release is necessary for Node 14 support:
jest-enzyme > jest-environment-enzyme > jest-environment-jsdom > @jest/environment > @jest/transform > jest-haste-map ><EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.

it also breaks when working with react 17 cause of an old jsdom version
https://github.com/testing-library/user-event/issues/592

+1

+1

+1

+1 🙏

+1


Fix a few small issues

GC code for RO segments had some bugs because it had never been
tested.  CoreCLR doesn't use RO segments.  The fix is to update
sorted_table to keep both the segment memory and the segment
descriptors separately as key/value pairs.  This isn't needed
for normal segments because they are the same, but with RO
segments the memory is in an executable file, while the descriptor
is dynamically allocated.  I also changed "insure" to "ensure".
Changed HndEnumHandles to use a bool parameter instead of BOOL.
This side-steps some differences in the definition of BOOL that
led to some compilation issues.
Port LABELED_RETURN_ADDRESS changes from PN tree.
Fixed a couple of DAC issues.

@jkotas, @Maoni0, PTAL

LGTM


[Question] Upload custom TrustStore to accept internal CAs for organizations and enterprises

Question
For some enterprises and organizations, the SSL issuing organizations are likely to be internally managed, and the internal websites with SSL certificates issued by these organizations also needs to be monitored.
There have been a few issues that have mentioned similar scenarios. #2773
We may need a feature to upload user-defined TrustStore (I'd like to be involved in the development if possible) to be compatible with any enterprise or organization's internally-issued certificates.

hi, good idea. Maybe we need to implement support for input file as monitoring parameter, and then implement the custom trustStore. If you'd like, you're very welcome to develop.


Not being able to insert data in external Hive table connected to Solr

Hi all,
Hive Version 1.2.1000
Solr Version <IP_ADDRESS>.5
Hadoop Version <IP_ADDRESS>
solr-hive-serde-3.0.0.jar
I wanted to implement an external hive table connected to solr.
I built the JAR file on my local pc and uploaded it to HDFS. After that I connected to our cluster using putty, then connected to Hive using Beeline.
After being successfully connected I loaded the jar file
add jar hdfs:///user/hbx/solr-hive-serde-3.0.0.jar;

Then I create an empty external table following the example from the documentation:
CREATE EXTERNAL TABLE solr_test (city STRING, edition INT, sport STRING,
sub_sport STRING, athlete STRING, country STRING, gender STRING, event
STRING, event_gender STRING, medal STRING) STORED BY
'com.lucidworks.hadoop.hive.LWStorageHandler' LOCATION '/tmp/solr'
TBLPROPERTIES('solr.server.url' = 'https://hdpmst003.example.hbx:8080/',
'solr.collection' = 'collection1', 'solr.query' = '*:*', 'lww.jaas.file' =
'/etc/solr/conf/solr-server-jaas.conf');

I ensured that lww.jaas.file is present in the same location on all active nodes per the following doc:

"The JAAS configuration file must be copied to the same path on every node where a Node Manager is running (i.e., every node where map/reduce tasks are executed)"

After creating the table without data and without error messages I try to insert data from another table into this table. Here the code breaks down and we get various error messages.
The errors start during the mapping tasks, the start reads:
0: jdbc:hive2://hdpmst001.example.hbx:8080> INSERT OVERWRITE TABLE solr_test
SELECT * FROM solr_olympics;
INFO : Session is already open
INFO : Dag name: INSERT OVERWRITE TABLE solr_...solr_olympics(Stage-1)
INFO :

INFO : Status: Running (Executing on YARN cluster with App id
application_1492773261214_8070)

INFO : Map 1: -/-
INFO : Map 1: 0/1
INFO : Map 1: 0(+1)/1
INFO : Map 1: 0(+1,-1)/1
INFO : Map 1: 0(+1,-1)/1
INFO : Map 1: 0(+1,-2)/1
INFO : Map 1: 0(+1,-3)/1
INFO : Map 1: 0(+1,-3)/1
INFO : Map 1: 0(+1,-3)/1
ERROR : Status: Failed
ERROR : Vertex failed, vertexName=Map 1,

vertexId=vertex_1492773261214_8070_5_00, diagnostics=[Task failed,
taskId=task_1492773261214_8070_5_00_000000, diagnostics=[TaskAttempt 0
failed, info=[Error: Failure while running task:java.lang.RuntimeException:
java.lang.RuntimeException:
org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while
processing row

The end of the error message reads:
Caused by: java.lang.NullPointerException
at com.lucidworks.hadoop.io.impl.LWSolrDocument.getId(LWSolrDocument.java:46)
at com.lucidworks.hadoop.io.LucidWorksWriter.write(LucidWorksWriter.java:195)
... 27 more
]], Vertex did not succeed due to OWN_TASK_FAILURE, failedTasks:1 killedTasks:0, Vertex vertex_1492773261214_8070_6_00 [Map 1] killed/failed due to:OWN_TASK_FAILURE]DAG did not succeed due to VERTEX_FAILURE. failedVertices:1 killedVertices:0 (state=08S01,code=2)

Any help in finding a thread to pull on would be greatly appreciated.

The table must have an id.
Try with:
CREATE EXTERNAL TABLE solr_test (id STRING, ...

Hi acesar, thank you for your reply. I amended my creation of the table to
solr_test (ID INT, name STRING)
Now I get a new error, start of the error:
ERROR : Vertex failed, vertexName=Map 1, vertexId=vertex_1492773261214_14661_4_00, diagnostics=
[Task failed, taskId=task_1492773261214_14661_4_00_000000, diagnostics=[TaskAttempt 0 failed,
info=[Error: Failure while running task:java.lang.RuntimeException: java.lang.RuntimeException: Hive
Runtime Error while closing operators
at org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:173)
at org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:139)
at
org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.run(LogicalIOProcessorRuntimeTask.java:347)
End of the error:
Caused by: java.io.IOException
at com.lucidworks.hadoop.io.LucidWorksWriter.makeIOException(LucidWorksWriter.java:287)
at com.lucidworks.hadoop.io.LucidWorksWriter.close(LucidWorksWriter.java:282)
at com.lucidworks.hadoop.hive.LWHiveOutputFormat$1.close(LWHiveOutputFormat.java:50)
at org.apache.hadoop.hive.ql.exec.FileSinkOperator$FSPaths.closeWriters(FileSinkOperator.java:199)
... 21 more
Caused by: shaded.org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException: Error from server at https://hdpmst003.adam.payvision:8983/collection1: Expected mime type application/octet-stream but got text/html.

Error 404

HTTP ERROR: 404
Problem accessing /collection1/update. Reason:
    Not Found
Powered by Jetty://

    at shaded.org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:578)
    at shaded.org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:279)
    at shaded.org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:268)
    at shaded.org.apache.solr.client.solrj.impl.ConcurrentUpdateSolrClient.request(ConcurrentUpdateSolrClient.java:436)
    at shaded.org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160)
    at shaded.org.apache.solr.client.solrj.SolrClient.commit(SolrClient.java:484)
    at shaded.org.apache.solr.client.solrj.SolrClient.commit(SolrClient.java:501)
    at com.lucidworks.hadoop.io.LucidWorksWriter.close(LucidWorksWriter.java:278)
    ... 23 more

Any further suggestion would be greatly appreciated.

@Oswfrans the Solr url does not seem correct:
TBLPROPERTIES('solr.server.url' = 'https://hdpmst003.example.hbx:8080/',

Usually is in the format http://<hostname>:8983/solr
If you are using SolrCloud please use the solr.zkhost instead


Should hosts inherit network settings from the general pool?

I'm configuring a server by assembling a Dhcp_server.Config.t . I have one host included in the list.  I was surprised that when there's no Subnet_mask set in the host's list of options, it doesn't inherit one from the more general network configuration in the Dhcp_server.Config.t.  Is this a bug, or just a failure of understanding on my part?

It should advertise the Subnet_mask on a DHCPOFFER, but the option itself will not show up in the hosts lists, if this is not happening, it is a bug, I did some changes and might have introduced it recently.

Hmm it seems I'm ignoring hosts.options, but the subnet mask should be included anyway.
But if you add a host specific option that is not address or lease time, it will get ignored, I'll fix it.

Fixed in<PHONE_NUMBER>75727cd19d5da6003ccf11faa736d6


flexget: 3.1.103 -> 3.1.106

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116494 at 1eb0d1e3 run on aarch64-linux 1

6 packages built successfully:

flexget
python38Packages.APScheduler
python38Packages.python-telegram-bot
python39Packages.APScheduler
python39Packages.python-telegram-bot
vorta

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/APScheduler/default.nix:65:3:
   |
65 |   meta = with lib; {
   |   ^


Alexcmonnet/i-want-the-rest-api-351

Closes #351

Added REST endpoint for getting available plugin commands
Added REST endpoint for executing AaC plugin commands
Added filter to prevent long-running commands from being executed via the REST API

After our conversation about restarting the Rest API to test unsuccessful commands, I was able to confirm everything was working but we should probably have some kind of statement somewhere saying that it's required since, without thinking about it and knowing that the language context won't update definitions that are already present, I could see that being confusing and leading to erroneous results.
The last thing I'd point out is that aac_rest_app.py and test_rest_api.py seem to have been reformatted (at least partially) due to, what I assume is the result of a mismatched line length. Can you fix that - i.e. revert those formatting changes - please?

I've fixed the formatting. The files are currently formatted per the black settings. Confirmed no change when black was run against the files python -m black --line-length=127 --diff --quiet ./tests/plugins/test_rest_api.py


Add style fix circleci

Based on #21

Some nitpicking about commit messages (generally consider https://chris.beams.io/posts/git-commit/. A nice summary why commit messages are important and how to write good ones):

Style fix

Better would be
Fix code style issue introduced by #20

 Add style check to circleci test

   - adding line - run: make style-check to config.yml

That you added this line is clear from the diff itself. Generally try to mention why you changed something and what the implications are (not what you changed, that is clear from the diff)
Better may be something like this:
Check code style during CI

To avoid code style issues like the one introduced by #20 we check it during CI.


🐛 Bug Report: Flaky Tests

📜 Description
Hey there, it seems that tests in the build are becoming more and more flakey.
I'm finding more and more, submitting prs, random tests break in the build process even though you haven't touched them. Its very annoying!
Especially as you can't run re-run failed pipes in this account at the moment
👍 Expected behavior
Tests should always be working if they work
👎 Actual Behavior with Screenshots
tests are flakey and keep randomly failing
👟 Reproduction steps
Create a pr and run the tests multiple times
📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

Agreed, it's getting annoying.
The only major source of flakiness I have seen the last couple of weeks is the database related errors. They can happen in several different places of the code, and seem to be because the GitHub actions database services that we use get torn down. Maybe the tests are too long running at this point so it shuts down? Maybe it's a side effect of some error elsewhere that is yet to be found?
We'd love some help with pinning down this particular flakiness.
But now that I look through recent CI runs the kubernetes test failure stood out and is new to me. Let's look into that too.

@freben yup I've been looking at the kubernetes test failure. I can't replicate it locally and as it happens at the end of an 18 min run its a killer... 😢

I'm wondering if that is getting run on in a different order in local vs on the action and that means that the test is picking up something


shortcut to go to last unread message ?

Hi,
Just installed it, and while I like the G key to go to the folder, I find that after that pressing either key will take me all the way up to the first message. I have years of messages in each folder, and scrolling down with page down is just unthinkable.
Is there some key I'm missing to scroll down instantly ? Right now I have to use the mouse to do that, which defeats the purpose.
Thanks

Wouldn't End be good enough? It may over-shoot the last unread depending on what you've done previously, but it will almost certainly get you much closer.

I agree with @r2evans that End should solve this.
Another solution would be to View -> Sort by -> (x) Date + (x) Descending, which shows the latest message first.
Closing this issue, as it's out of the scope of Nostalgy.


TS-2109: Allows CC: no-cache objects to be stored in cache

However, we still honor the no-cache header, such that we perform an IMS
request against the origin to validate the request before serving.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1152/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1257/ for details.


Digitisation on demand

✨ Feature

Looking at the existing workflows and UX for user requested digitisation of assets, understanding tech changes and requirements, creating new internal workflows and external experience.

@kenoir FYI

@nancetron I was involved in the project for the current digitisation request process implementation (from the Sierra end of creating links with useful parameters for the online forms). Not sure if that makes me someone to talk to or someone to avoid talking to about it at some point!

Nancy's final document here: https://wellcomecloud.sharepoint.com/sites/wcdigitalexperience/Shared Documents/_wellcomecollection.org - current/PhotographyRequest_BackgroundResearch_NW.pdf?csf=1


No routes on map

The map doesn't show any routes, see screenshot
The screenshot was created using Firefox 91.0.2, Chromium 93.0.4577.63 looks the same
Yesterday, the routes were visible.

@UncleOwen thanks for reporting this problem
The routes have disappeared after I installed a new version of knooppuntnet this afternoon.  There was an error in the url that is used to pick up the map tiles with the routes and nodes from the server. As a result of your report this has been fixed now. So thanks again!!
While preparing the map image below I thought for a minute I discovered another problem: an island in the North See (Helgoland) included in Pinneberg.  Luckily, Wikipedia confirms OSM is right about Helogland... :)


DITA to PDF output does not work with store-type=memory

I get this error reported:
 /../dita-ot-3.x/plugins/org.dita.pdf2/build.xml:167: A source file is missing: /.../flowers/temp/pdf/flowers_MERGED.xml

There is an ANT call to this task:
<detect-lang documentPath="${inputFile.url}"/>

and the task takes as a parameter a reference to the DITA map in the temporary folder, reference which no longer exists.

I think an option would be to parse the DITA Map directly from the input folder, but the DetectLang would need an XML catalog passed to it. Otherwise it would probably need some sort of access to the Job class.

I think an option would be to parse the DITA Map directly from the input folder, but the DetectLang would need an XML catalog passed to it. Otherwise it would probably need some sort of access to the Job class.

The error above is for the case when the "preprocess" target is used.
When "preprocess2" is used there is a different publishing error in preproces2.init:
preprocess2.init:
 [echo] *****************************************************************
 [echo] * input = /../samples/dita/flowers/flowers.ditamap
 [echo] * resources = ${args.resources}
 [echo] *****************************************************************
 Error: java.nio.file.NoSuchFileException: /var/folders/.../.job.xml

The error above is for the case when the "preprocess" target is used.
When "preprocess2" is used there is a different publishing error in preproces2.init:
preprocess2.init:
 [echo] *****************************************************************
 [echo] * input = /../samples/dita/flowers/flowers.ditamap
 [echo] * resources = ${args.resources}
 [echo] *****************************************************************
 Error: java.nio.file.NoSuchFileException: /var/folders/.../.job.xml

If I comment out that "" from build_preprocess2.xml, then the code ends up in "transform.topic2fo.init" which does a:
<makeurl file="${inputFile}" property="inputFile.url" validate="true"/>

which fails, if I set validate="false" on it, then it fails further on the "detect-lang" task, thus coming full circle.

If I comment out that "" from build_preprocess2.xml, then the code ends up in "transform.topic2fo.init" which does a:
<makeurl file="${inputFile}" property="inputFile.url" validate="true"/>

which fails, if I set validate="false" on it, then it fails further on the "detect-lang" task, thus coming full circle.

So, I believe this error happens because using store-type=memory means that the preprocess target does not store the topic-merged output (*_MERGED.xml) anywhere on disk.
I would be very interested in a solution to this issue as the MiramoPDF DITA-OT plugin (and any others which rely on using the preprocess target to create a topic-merged intermediate file for further processing) is also affected.
Ideally, as Radu says, having "some sort of access to the Job class" would mean that the entire transformation could happen in memory, which would be super.
Thanks a million, as always, for all your work on constantly improving and updating the DITA-OT!

So, I believe this error happens because using store-type=memory means that the preprocess target does not store the topic-merged output (*_MERGED.xml) anywhere on disk.
I would be very interested in a solution to this issue as the MiramoPDF DITA-OT plugin (and any others which rely on using the preprocess target to create a topic-merged intermediate file for further processing) is also affected.
Ideally, as Radu says, having "some sort of access to the Job class" would mean that the entire transformation could happen in memory, which would be super.
Thanks a million, as always, for all your work on constantly improving and updating the DITA-OT!

The "com.idiominc.ws.opentopic.fo.index2.IndexPreprocessorTask" needs to be updated as well to work with streams created through the Job object.

The "com.idiominc.ws.opentopic.fo.index2.IndexPreprocessorTask" needs to be updated as well to work with streams created through the Job object.


[site] move Hero and its image into routes directory

Corresponding PR in the sites repo: https://github.com/sveltejs/sites/pull/375
Two changes:

Moves Hero.svelte from sites repo and removes an unused prop
Moves hero image into src/routes and removes $img alias (thank you directory routing!)

this is way nicer


Implementation of next() looks inefficient

This is the C code that Cython uses to implement the builtin next():
static CYTHON_INLINE PyObject *__Pyx_PyIter_Next2(PyObject* iterator, PyObject* defval) {
    PyObject* next;
    // we always do a quick slot check because always PyIter_Check() is so wasteful
    iternextfunc iternext = Py_TYPE(iterator)->tp_iternext;
    if (likely(iternext)) {
#if CYTHON_USE_TYPE_SLOTS
        next = iternext(iterator);
        if (likely(next))
            return next;
        #if PY_VERSION_HEX >= 0x02070000
        if (unlikely(iternext == &_PyObject_NextNotImplemented))
            return NULL;
        #endif
#else
        // note: PyIter_Next() crashes if the slot is NULL in CPython
        next = PyIter_Next(iterator);
        if (likely(next))
            return next;
#endif
    } else if (CYTHON_USE_TYPE_SLOTS || !PyIter_Check(iterator)) {
        __Pyx_PyIter_Next_ErrorNoIterator(iterator);
        return NULL;
    }
    return __Pyx_PyIter_Next2Default(defval);
}

static PyObject *__Pyx_PyIter_Next2Default(PyObject* defval) {
    PyObject* exc_type;
    __Pyx_PyThreadState_declare
    __Pyx_PyThreadState_assign
    exc_type = __Pyx_PyErr_Occurred();
    if (unlikely(exc_type)) {
        if (unlikely(!__Pyx_PyErr_GivenExceptionMatches(exc_type, PyExc_StopIteration)))
            return NULL;
        if (defval) {
            __Pyx_PyErr_Clear();
            Py_INCREF(defval);
        }
        return defval;
    }
    if (defval) {
        Py_INCREF(defval);
        return defval;
    }
    __Pyx_PyErr_SetNone(PyExc_StopIteration);
    return NULL;
}

The logic if CYTHON_USE_TYPE_SLOTS is false looks wrong: it should not use tp_iternext. Instead, it should first check PyIter_Check and then call PyIter_Next.

The function __Pyx_PyIter_Next2Default is called only from one place, so why not fold the implementation inside __Pyx_PyIter_Next2?

__Pyx_PyIter_Next2Default checks __Pyx_PyErr_Occurred() but it seems to me that this is always true.

If defval is NULL, then there is no need to check whether the exception is StopIteration: it should immediately return NULL.

I was trying to be smart there and assumed that CYTHON_USE_TYPE_SLOTS would only be disabled on platforms that potentially do not set tp_iternext. Since users can also -Ddefine it themselves, that might not be a safe assumption. Definitely the kind of code that would have deserved a couple of comments...

I split both to limit the scope of the CYTHON_INLINE request. The second function is a non-critical fallback, and I want the C compiler to understand the difference.

tp_iternext is allowed to return NULL without setting an exception when the iteration terminates.

Sounds good.


For completions of union, exclude types with methods

Fixes #13036

I don't really know about this change. Removing method-declared properties is a bit heavy-handed and likely to impact the experience negatively for a large class of users where .d.ts files have taken advantage of method syntax.

@DanielRosenwasser This only affects union types. In the usual case where you have just a single type, we will still show methods.

@DanielRosenwasser Any more comments?

What about excluding arrays only? i am having second thoughts here. Are Map/Set common? have you seen PropertyBag | SomeOtherTye pattern a lot in DT?

@mhegazy and I talked about just de-prioritizing items in the completion list from Array.

and I talked about just de-prioritizing methods in the completion list as well.

i do not think this is gonna work. for arrays, you do not want to see them period. you do not want to see length either..
Similarly for Map, and Set, having their methods in the list is just confusing regardless of search order.
But in the absence of a general solution that gets us Map and Set, we might just settle for Array.

@mhegazy @DanielRosenwasser OK, new version only deals with arrays (including types such as ReadonlyArray and NodeArray).

thanks!


Publish the podcast

Soundcloud, iTunes, pod network, etc

Examples:

Service for distribution: https://www.libsyn.com/

Spotify

Anchor (which was acquired by Spotify) allows you to create, distribute, and host unlimited episodes and shows for free - https://anchor.fm
There is also an open-source project for podcast hosting (sponsored by Software Engineering Daily, I believe) - https://github.com/crablar/podsheets

Super appreciated @petermbenjamin! 👍

Done.


Do users understand what is a good quality picture? Do they need additional help

Most have a clear understanding of what is acceptable. Users tend to scan the photo criteria and then assume that these are the same as those for a passport.
As a result, some additional criteria are assumed:
“No smiling”

Users understand basics of what is required for the photo, but need help with uploading and cropping their photos


[core] 3d camera smooth zoom not work on macos

Issue description
build and run, examples/core/core_3d_camera_free.c
3d camera smooth zoom not work
Environment
osx 10.14.6
raylib master

Ok, that's right, because it requires CTRL key... you should redefine that key with SetCameraSmoothZoomControl().
In any case, I'd recommend using a custom camera implementation. Provided camera modes are quite limited...

Thanks for your reply and thanks for all your work on raylib, I enjoy raylib!
I made new golang binding for raylib, it called go-raylib.
https://github.com/chunqian/go-raylib


Configure git-cz and commitlint

Align git-cz and commintlint to @melfore/mosaic

:tada: This issue has been resolved in version 1.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


added some agile quiz questions

Summary of changes
added some agile quiz questions

#103
Checklist

[x] I have read and followed the contribution guidelines.
[x] I have read through the Code of Conduct and agree to abide by the rules.
[x] This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
[x] My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
[x] I have provided a summary of my changes.

i have made all changes as required please review it @jdwilkin4


remove other versions from versions.yml

Description

Remove other versions from versions.yml
Convert format from dictionary to list by removing the toplevel vX.Y|master key

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit ca1a17b878a62c4e80f03d38f249b6a5a8ce9525
https://deploy-preview-3119--calico.netlify.com


Using File Dialog in Preferences

Folks,
I need to have the preferences window allow the user to bring up a file dialog window. I am unable to find any examples on how to do this. I was thinking of maybe using a link or button to a javascript function but am not familiar enough with the preferences "sections" to display a url to the user. Any help would be much appreciated.
Thanks,
Daryl

Hi Daryl
Sorry, apparently I've overlooked this issue. But if I'm not mistaken, this one can also be linked to #55 ?
FYI: the way this is now done in the 'directory' component, is by showing a button which opens the dialog window when clicked on. Once a directory is selected the path will be shown near the button to indicate a folder is set in electron-preferences.
I'll close this issue for now. If you have more questions about how to implement it, or suggestions for features on the 'file' component, please comment on #55.


Organization or Legislator Sign Up

Needs #596
right below the blue "Sign up" header, insert hyperlinked text "signing up as an organization or state legislator? click here."

when clicked, it opens up a new pop-up (same as normal sign up pop-up), except there is a dropdown to select legislator or organization
there is also text at the top that says "please use your professional/government email to register. Your account will be authenticated and ready-for-use within 72 hours."
there is no option for a legislator/org to sign up via gmail/apple/facebook

How should we handle the authentication of legislators/orgs? Should they not be able to log in until we have performed this authentication? @alexjball


🐞 [BUG] - In Dark mode text color need to be updated

Issue Verification

[X] I have verified that this is a new bug report.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Describe the bug
In dark mode color of text is need to be changed.It is not visible.Attaching a screenshot

Expected behavior
No response
Steps to reproduce
No response
Additional Context
No response

@jfmartinz ,I have sent a pull request.Could you please check it and let me know any issues.I am attaching screen shot in darkmode.

I already sent pull request.Kindly check it


Upgrade Docker installation to latest packages

See https://docs.docker.com/install/linux/docker-ce/ubuntu/ there are some new packages in town we should use

We should also reflect the possible Ubuntu distros reflected in https://docs.docker.com/engine/install/ubuntu/#os-requirements - so let's add Focal and Xenial also. And doing this, we should use Travis Jobs to separate the Molecule scenarios: https://docs.travis-ci.com/user/build-stages/#naming-your-jobs-within-build-stages


Edit without scrolling

re: your comment on IRC earlier: what you're describing isn't currently possible. It sounds like you probably want a plugin, although I appreciate that it's a bit annoying to write plugins right now. If you can explain what you're trying to do a little bit maybe I can be more useful?

Thanks for your prompt reply.
I’m trying to embed vim emulation in my front-end and doing lots of motion logic at the front-end side. The ones I couldn’t do right now is the d commands in vim. I could get around with selection first and delete but that would cause flickering in the front-end. So I’m wondering if front-end could directly modify content. It would be easy to achieve my goals including “join lines” (delete the \n of the current line), yank paste multiple times, etc.

I guess I'll just wait for the core to evolve more then. My ultimate goal is to replace the neovim backend of https://github.com/dzhou121/gonvim with Xi core.
On a separate note, neovim's front-end (external UI) and remote plugins are using the same API so they can call the same API. Also, they can send to and listen to RPC channels so it's very easy for them to talk to each other. The benefit is that in gonvim (take the fuzzy search for example), other plugins can extend the GUI fuzzy search implementation.

Yea, that's interesting. I hadn't really been following neovim architecturally, although it is my daily editor right now.
The question of what commands should be supported in xi-core is a tricky one for sure.
Something raph and I have been talking about a bit lately is just how similar a frontend and a plugin are; there's a lot of overlap in certain areas. In other areas this is less true; a plugin might care about spans, but it doesn't need text to actually be styled. Lots of room for exploration here, though.

I would really love to see frontend and a plugin can call the same set of commands supported by xi-core. It's also easier for writing API libraries since you only need one for both frontend and plugins.

@dzhou121 I'll give that some thought. It isn't clear to me that this makes total sense, though; for instance I don't think a plugin should be sending Click events, or things like MoveLeft. (A plugin might want to move the cursor, but it would do that by passing an explicit selection, not by emulating a keyboard event).
Writing an API library that supports both shouldn't be that hard as is; the core RPC mechanism is all shared, there are just two sets of commands you need to describe. That they're distinct doesn't make it much more complicated than having them be unified?

Take the vim easy motion plugin(https://github.com/easymotion/vim-easymotion) for example, it needs the ability to Click. What I’m talking is maximum flexibility of the API since we couldn’t imagine what kind of things front end or plugin developers want to achieve.
Also personally it’s easier to put in mind that I can do everything than I can only do these in front end and those in my plugins. A front end author is very likely to write plugins.

I've thought about this some more, and maybe one solution is to handle these types of actions through custom plugin commands; so when you encounter a vim command like di< which requires access to the buffer, you send a custom command to a companion plugin that can access the buffer and perform  the task.
This would let you do much of what you want today, although there are certain things plugins can't currently do (if only because we haven't gotten around to it) such as modify a user's selections. They do support custom commands, though, at least in theory; I don't believe this functionality is in the rust plugin library, but it was in the python plugin library (which is broken at the moment but could definitely be fixed)

I'll try this approach then. But I do hope front-end can also have access to the buffer as it would be much easier.


Fix RedisVectorStore not closing Jedis pipelines

Fixes https://github.com/spring-projects/spring-ai/issues/422 using try-with-resources.

@Bragolgirith , Thank you for catching and fixing this.


Mashlib recipe : no login from an android browser

Fail to login on a CSS server with mashlib from an android phone and an MI 5 tablet (android) :

login popup and consent appear correctly. then just no login with no error message
tested https://solidcommunity.net:3000/ (subdomain server) and also on my own test servers (subdomain and suffix)
tested with chrome and brave browser
no issue on a PC

There are no problems to login with an android browser to a NSS server

It is not clear yet to me exactly what is failing. Does the CSS not redirect back to the client after pressing the button on the consent page? Or does the server not return access tokens when requested afterwards?

CSS does redirect to the client after pressing the consent button
the client seems to not receive access tokens. The client is in the same state as before pressing login

It is hard to say immediately what the probably might be since multiple pieces of software are involved here. If the redirect back to the client did happen that means the solid authn client received something. Question is if there is something missing in the response, if there was an error, or if there is an issue with how the authn client interprets the data.

resolved using private navigation. Then everything is back again.
I suppose this relates to cleaning the browser cache.


ContactsServicePlugin.java uses or overrides a deprecated API

I'm using contacts_service 0.6.3 and am building APK (android).
There is a red note of Flutter:
C:\Users\f\AppData\Local\Pub\Cache\hosted\pub.dartlang.org\contacts_service-0.6.1\android\src\main\java\flutter\plugins\contactsservice\contactsservice\ContactsServicePlugin.java uses or overrides a deprecated API.
Is that important? Can you update this API?
Thanks so much.

same here
you need to look here
https://docs.flutter.dev/development/packages-and-plugins/plugin-api-migration


[Bug]: Issues with the radar

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
The radar chart is not correctly responding to the system's color (System mode is not working). Also There's a small typo in the data mapping for issues that's why it is not getting pointed in the radar.
Expected behavior
after the correction it will work properly like this in system mode as well

Add ScreenShots
No response
On which device are you experiencing this bug?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊
You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

this is what it looks now... now i realized what's the mistake. i forgot to set the theme for systems here and also there is a typo due to which it will display only 3 parameters instead of 4.

GO ahead @Swastik19Nit

Hey @Swastik19Nit,
Do the changes to your issue after #336 this PR gets merged. Or else there will be merge conflicts.
@ashutosh-rath02 give #336 a priority. So, Swastik can work on this issue.

@dhairyathedev Your recent issue aligns much with this one. You can guide @Swastik19Nit what needs to be done here only

i have solved the issue of the ticks as well.. now it will be dynamically calculated on the radar and will be displayed neat

Ok raise a PR @Swastik19Nit

 i have solved the issue of the ticks as well.. now it will be dynamically calculated on the radar and will be displayed neat

How are you setting the tick count? Fixed count or programmatically? @Swastik19Nit

The calculateStepSize function uses logarithms and powers of 2 to find a step size that's easy to read (like 20, 50, 100, etc.) and that dividdes the max value into a reasonable number of steps. This makes sure that the radar chart remains readable regardless of whether the users stats are in tens, hundreds, or thousands.
@ashutosh-rath02

I have raised a common PR

Hello @Swastik19Nit! Your issue #332 has been closed. Thank you for your contribution!


Join table

Join table

Created vets, specializations, and visits table.
Updated schema.sql, data.sql, and queries.sql.

Screenshots :

Thank you so much


Sync request into workspace

Describe the solution you'd like
Could be very usefull the option to save the request in the workspace, without need to make an export all time. Like this all team can sync the request avoiding lost endpoints
Describe alternatives you've considered
Make an export on push

Confirm .It was working good in Thunder client before they required a subscription.
Pls. This feature is really necessary!

Hi @usarral and @egorovsa
Thank you for using the Fetch Client extension. This feature has added in the latest version Fetch Client v1.5.1
Please update the Fetch Client and let me know if you have any queries/feedback.
@egorovsa Thank you for your contribution. I have done few changes on top of your code with my PR.


Allow use of db.join* methods more than once

The db.InnerJoinWithFilter and db.LeftOuterJoinWithFilter methods use $1 when building the join string, so using any of them more than once fails because of invalid parameters.

thanks @danut007ro , LGTM (will be added to the next tag incl. CHANGELOG.md entry).

Thanks again, https://github.com/allaboutapps/go-starter/blob/master/CHANGELOG.md#2022-03-28


update openapi 3.1 base schema url

Thanks for the PR, but the example is correct as is. https://spec.openapis.org/oas/3.1/schema-base is what you should use to validate an OpenAPI document. https://spec.openapis.org/oas/3.1/dialect/base could be used if you have just a JSON Schema that needs validation using the OpenAPI JSON Schema dialect. However, a better way to validate a schema is just to compile it. It's better because it does additional validation that can't be done with meta-schema validation.
registerSchema({ type: "string" }, "https://example.com/string", "https://spec.openapis.org/oas/3.1/dialect/base");
const validator = validate("https://example.com/string"); // Will throw InvalidSchemaError if there's something wrong with the schema


Twemproxy hangs parsing nested Array responses from Redis

Twemproxy hangs when processing a Redis Lua script via EVALwhich returns nested sub-arrays.
This is easy to reproduce.
Setup:

On Mac OS 10.12.6.
Running redis-server 2.8.24 at localhost:7379 (installed via Homebrew).
Running nutcracker-0.4.1 at localhost:221221 which is configured with:

development:
  redis:            true
  auto_eject_hosts: false
  listen:           <IP_ADDRESS>:22121
  servers:
    - <IP_ADDRESS>:7379:1

Demo of direct connection to Redis being happy:
$ redis-cli -p 7379
<IP_ADDRESS>:7379> EVAL 'return {1,2,3}' 1 x
1) (integer) 1
2) (integer) 2
3) (integer) 3
<IP_ADDRESS>:7379> EVAL 'return {1,{2},3}' 1 x
1) (integer) 1
2) 1) (integer) 2
3) (integer) 3
<IP_ADDRESS>:7379>

Demo of connection through Twemproxy being unhappy:
$ redis-cli -p 221221
<IP_ADDRESS>:221221> EVAL 'return {1,2,3}' 1 x
1) (integer) 1
2) (integer) 2
3) (integer) 3
<IP_ADDRESS>:221221> EVAL 'return {1,{2},3}' 1 x
^C

The last command hangs as long as I was willing to wait (several minutes), until I cancel it.
I see no messages in the twemproxy logs during this time.
I notice that src/proto/nc_redis.c has special cases for nested multi bulk reply element from sscan/hscan/zscan.  Perhaps eval and evalsha are simply missing the special case treatment?
I apologize for phrasing this as a bug report instead of as a pull request with a fix, but I am afraid it may be a long time before I can dig deeper.
Thank you for a wonderful tool.  It is a critical piece of our infrastructure at ProsperWorks and has made our lives much easier.

I think the code in question is https://github.com/twitter/twemproxy/blob/v0.4.1/src/proto/nc_redis.c#L2084-L2107 and possibly others
Changing from a tail recursive parser (with goto) to a real recursive parser for multi-bulk calls is possibly how that would be handled - I assume the performance of sscan/hscan/zscan isn't important to the vast majority of applications, and recursive should still be fairly efficient
I think I had the same workaround of JSON encoding return values (or using some other portable encoding) in lua scripts

Fixed in #612 - it turns out it didn't make sense to make it recursive - the only state that needed to be tracked was

Whether this was currently at the top level
The number of remaining elements to parse, increasing when new arrays are encountered

This will be part of an upcoming 0.5.0 release


chore: updated the first prompt

Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Follow the CONTRIBUTING Guide.
[x] You are listed as the author in your notebook or README file.

[x] Your account is listed in CODEOWNERS for the file(s).

[x] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
[x] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
[x] Appropriate docs were updated (if necessary)

@iamthuya Could you check how you can fix the notebook for the linter check that failed?


Do not remove container if underlying resource cleanup failed

This should fix issue #10955 and #6746
This patch series does two things. First of all it does not remove container from a user's view if container removal failed. Secondly, it extends force option (-f) to forcibly remove the container even if resource cleanup failed. That way those user who are willing to let resources leak, can use --force.

Hmm..., there are more calls to daemon.Rm(). Will fix those to adjust for additional parameter.

Pushed one more time fixing all the instances of daemon.Rm(). Hopefully I got them all.

can you add fixes #6746 to your first comment so when this is merged it will close that issue as well

Also is there anyway to add an integration test

@jfrazelle
Where should I add "fixes #6746" now? Create a new pull request?

@jfrazelle
I just edited my initial pull request comment. I guess that's what you were referring to.
I will look into current integration tests and see if they are sufficient to test this or not.

oh just in the first comment
On Wed, Mar 4, 2015 at 6:46 AM, Vivek Goyal<EMAIL_ADDRESS>wrote:

@jfrazelle https://github.com/jfrazelle
Where should I add "fixes #6746
https://github.com/docker/docker/issues/6746" now? Create a new pull
request?
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11137#issuecomment-77169770.

editing the comment should do it, no need for a new PR
On Wed, Mar 4, 2015 at 6:47 AM, Jessica Frazelle<EMAIL_ADDRESS>wrote:

oh just in the first comment
On Wed, Mar 4, 2015 at 6:46 AM, Vivek Goyal<EMAIL_ADDRESS>wrote:

@jfrazelle https://github.com/jfrazelle
Where should I add "fixes #6746
https://github.com/docker/docker/issues/6746" now? Create a new pull
request?
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11137#issuecomment-77169770.

@jfrazelle
I see that integration-cli/docker_cli_rm_test.go already has bunch of container removal tests. I think adding two more tests to it should make sense.

Create a failure situation so that container removal fails and container state is "Dead".
Use "docker rm -f" to be able to remove a dead container.

But I am not sure how to create that failure situation reliably. In my testing I use device mapper driver and bind mount container thing device somewhere so that device deactivation fails which in turn leads to container removal failure. But it is not generic method and I can't see an easy way to force it.
I am looking for something which can be easily used with all graphdrivers and can cause container removal failure. Any ideas?

@rhvgoyal Really you should be able to mount anything into the container fs path and then try to remove the container, this should result in Device or resource busy shouldn't it, since there is another fs mounted on top?

@cpuguy83
I think there are couple of issues.

I am assuming that daemon is running in a separate mount namespace. And if I bind mount something in client namespace, that would not help.

Even if I figure out a way to get into daemon mount namespace and bind mount something else on container rootfs, it will not work with my pending proposed patches.  I have proposed another set of patches to unmount container rootfs from daemon mount namespace after successful container start to solve various issues. Once that is in, that means,  container rootfs has already been unmounted and once container exits only device will be deactivated. So bind mounting something on container rootfs will not help.

I proposed my patches here.
https://github.com/docker/docker/pull/11114

@jfrazelle
So generic container removal tests are already there. What is missing is couple of tests for testing behavior in case of failure. And right now I can't find a good way to force failure.
Can these patches be merged without tests.

@jfrazelle @crosbymichael @cpuguy83 We would like to get this in for docker-1.6 if possible.

@rhatdan I added the milestone

Pushed top most patch again to take care of comment from @LK4D4

Something interesting is happening. The container I removed using -f, comes back to life if I restart the docker service. Wow, I need to look into it. May be we are not deleting underlying files somewhere and restart scans for these files and gets it back.

Ok, /var/lib/docker/container/<container_id> directory is removed after container root and container init root has been removed.
So it depends on when failure occurs. If failure occurs before container file removal, it will come back to life. And I think it is a bad idea. Container might be half deleted and if somebody tries to start it, bad things will happen. I will save the container state "Dead" back to disk before proceeding with actual deletion. This will make sure that once container is marked dead, it remains dead even if docker is restarted.

Ok, pushed one more time. Have taken care of the review comments so far. And also took care of making "Dead" state persistent to disk.

@jfrazelle
This windows test failure seems unrelated to my patches.

I reran and it passes, sorry we are working through some windows CI things

So this is shaping up to be a slightly different implementation of my PR (#10099) from awhile ago; although there are some better choices here about ordering of operations (rather than remove and re-add).  The naming piece is still difficult, but I'm fine with "Dead" if that is reasonable for others.
The one piece I don't like is that I was preserving the failing error--whatever kept the container from being removed successfully is now a transient error that after hours (or days or weeks?) is now lost, although I guess another try at docker rm will resurface it?  However, having it available for docker ps was something I liked about my impl, although it added the painful UI problem of "way too long/wide output".

@estesp
I think storing the error in container is not a bad idea. And it is not orthogonal to my patches. Right now I am trying to fix the problem of not removing container from main view if deletion failed and create new container state to represent that.
If this works well, then next step can be to also store the failure message. And there can be a separate patch for that. But I don't think that storing error should be a requirement for this patch series to go in.

look like needs a rebase sorry :(

@jfrazelle
Why are we removing this from 1.6.0 milestone?

Since its a bug fix we can include it at anytime in an RC but I don't want
it to hold up RC1 unless you can make these changes in the next hour :)
On Monday, March 23, 2015, Vivek Goyal<EMAIL_ADDRESS>wrote:

@jfrazelle https://github.com/jfrazelle
Why are we removing this from 1.6.0 milestone?
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11137#issuecomment-85168695.

@jfrazelle
I can do it but I don't like to rush in the changes as it always increases the possibility of breaking something.
All the comments are minor code cleanup commands, nothing major. It does not sound fair that just before RC1, one can give code cleanup comments and block the inclusion of fixes.
Can't we take these in 1.6.0 and I can open a separate issue to follow up on code cleanup comments.

That's sounds reasonable to me
On Monday, March 23, 2015, Vivek Goyal<EMAIL_ADDRESS>wrote:

@jfrazelle https://github.com/jfrazelle
I can do it but I don't like to rush in the changes as it always increases
the possibility of breaking something.
All the comments are minor code cleanup commands, nothing major. It does
not sound fair that just before RC1, one can give code cleanup comments and
block the inclusion of fixes.
Can't we take these in 1.6.0 and I can open a separate issue to follow up
on code cleanup comments.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11137#issuecomment-85169616.

@LK4D4
Would you have an objection to including these fixes as it is in 1.6.0 and I follow up with your cleanup comments in a separate issue for next release?

@rhvgoyal Dunno, do you want me to prepare PR for your branch. Because I don't want to have changed signature in release. This can lead to some nasty merges.

we can always include it in another RC when it is ready

I would rather wait and have it be good

@jfrazelle @LK4D4
Ok, I will make changes and generate another PR. Hopefully we can pull it in next RC release.

well just push to this one :) we can then include all of it in one RC

@jfrazelle
Ok.

@jfrazelle @LK4D4
Pushed changes again after taking care of some of the comments. Please have another look.
And this build failure seems unrelated to my changes.

I don't see any big problems
LGTM

This looks ready, but I still think it makes sense to test this functionality as it has new codepaths that current tests won't exercise.  Given our integration-cli environment is well-known, and many tests assume client == daemon/host, then wouldn't a simple file open inside the container's mount dir disallow unmounting, causing a "busy" error and removal to fail (in the same way that an extra mount would, but much more simply).  The path to the mount point should be easy to discern, given our knowlege of the test harness/daemon config, right?

@estesp

How do we know the mount point of container? Docker daemon does  not export that and hardcoding that in tests is not a good idea as if we change it later, test will be broken.

Mount point will also depend on graphdriver being used. I am not sure how to query daemon for graphdriver in use.

I did not understand your comment about client == daemon/host. Can you elaborate  bit more. And also point me to a test which assumes it.

@estesp
Also I think it is not a good idea to assume that container root is mounted in daemon namespace after container launch. I have another PR request waiting to change that behavior.
https://github.com/docker/docker/pull/11114
I think to make it work, we will have to have some sort of mount/unmount commands from docker so that it can mount a container's root for us explicitly and allow us to query mount point of container explicitly. That will work only if daemon is not running in a separate mount namespace.

needs a rebase also can you squash to 1 commit otherwise cherry-picking into the release branch is going to be kinda annoying

@jfrazelle
rebased and put everything into a single patch and pushed one more time. Tests are passing on my local system. So there might be something wrong with the build.

Testing this manually and it works.
Looks like CI is having an issue pulling lxc :(

If it fails lxc we aren't merging can you rebuild
On Tuesday, March 31, 2015, Brian Goff<EMAIL_ADDRESS>wrote:

Testing this manually and it works.
Looks like CI is having an issue pulling lxc :(
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11137#issuecomment-88162127.

linuxcontainers.org is down :-(

we will wait...

--- FAIL: TestEventsFilterContainerID (0.94s)
	docker_cli_events_test.go:355: Expected 3 events, got 2: [2015-03-31T17:36:02.000000000Z ab26eddbd0f26fad7fb1263785e701e23d5f5021afbb196a94d4c31c06a97de9: (from busybox:latest) create 2015-03-31T17:36:02.000000000Z ab26eddbd0f26fad7fb1263785e701e23d5f5021afbb196a94d4c31c06a97de9: (from busybox:latest) start]

ya that one has been racy lately
On Tue, Mar 31, 2015 at 10:51 AM, Vincent Batts<EMAIL_ADDRESS>wrote:

--- FAIL: TestEventsFilterContainerID (0.94s)
docker_cli_events_test.go:355: Expected 3 events, got 2: [2015-03-31T17:36:02.000000000Z ab26eddbd0f26fad7fb1263785e701e23d5f5021afbb196a94d4c31c06a97de9: (from busybox:latest) create 2015-03-31T17:36:02.000000000Z ab26eddbd0f26fad7fb1263785e701e23d5f5021afbb196a94d4c31c06a97de9: (from busybox:latest) start]
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/11137#issuecomment-88186867.

@estesp what are your thoughts

are you ok with this getting in 1.6.0, it needs to be merged today otherwise, since it is not really a regression and was a bug in earlier versions I will remove from the milestone

passes all tests @vbatts you think ok to merge?

so after learning up on this PR, it will make clean up of containers much nicer.
Like happens occasionally where a container fails to be removed (outside mounts, mount namespace overlap, etc), it will leave the container and underlying state to where it needs to be cleaned up by hand.
With this PR, now it is possible to get the error on docker rm ... earlier, fix the issue, then docker rm ... again. Without having to bring down the daemon for container cleanup.
I've just walked through a couple of cases by hand, and it's improved the experience.
LGTM

ah shoot sorry @tiborvass my GH page hadn't refreshed until after the button click!


Pin simplecov to < 0.18

Something stopped being compatible with simplecov 0.18 so pinning the version for now.
Think we need to do something about all the coverage reporting dependencies, are they adding value?

@excpt Think we could have this in master for the CI to pass. Then the pending PRs would need a rebase to get greener CIs


Add the builtin functions len...

Add the built-in function len  that returns the number of elements in a quote (#16)

commit e33d65cb9c1ecd2a93ddaf261f831cf1e4093352 closes this issue.


Include branch name for kubernetes-sigs/image-build project

Description of changes:
Project upgrades on release branches was added in #2375. This PR includes the build tooling branch name in the kubernetes-sigs/image-builder project version bump branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/cherry-pick release-0.20

/cherry-pick release-0.19


Need to limit Page History

I want to limit History Pages in ionic App. I mean backbuton should take limit(eg: 3 pages) pages only when I click back whuch will take to menu button after 3 history pages in Android ionic Mobile App.

Hello @RanjitReddy ! Thanks for opening an issue with us! Since this issue is more of a question on how to implement certain functionality and not an issue with the ionic framework i am going to close this issue and ask that you ask this question on our forum (forum.ionicframework.com). Thanks again! There are a ton of awesome devs on the ionic forum that will be able to help you implement this.


Rework AnsibleJob definition

Currently, Ansible Job definition is at its bare minimum. We need to come up with something which is a more structured way to handle Ansible Job definition - https://github.com/ansible/ansible-sdk/blob/60ef7e694567507c919d94159571f9234ff8bc3a/ansible_sdk/model/job_def.py#L8

Rename AnsibleJobDef to more generic to reflect its use
Populate Dataclass members to reflect ansible-runner counterpart e.g. we right now have only https://github.com/ansible/ansible-sdk/blob/60ef7e694567507c919d94159571f9234ff8bc3a/ansible_sdk/model/job_def.py#L9-L13
Add documentation around the data model

resolved_by_pr https://github.com/ansible/ansible-sdk/pull/32


Inlining of critical CSS ng build optimization

Command
build
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Inlining of critical CSS is one of the optimizations applied by default when running ng build.
The non-critical CSS should be deferred, i.e. fetched asynchronously.
Here is the Angular implementation for this:
<link rel="stylesheet" href="styles.css" media="all" onload="this.media='all'">

Unfortunately, this stylesheet link will block rendering and its onload handler is a no-op.
I'm wondering if this is intentional or an actual bug.
The loadCSS project recommends this code:
<link rel="stylesheet" href="styles.css" media="print" onload="this.media='all'; this.onload=null;">

They also have a blog post explaining the logic behind it.
Minimal Reproduction
N/A
Exception or Error
No response
Your Environment
N/A

Anything else relevant?
No response

Ignore this issue.
I was looking at the DOM instead of the source code.
The optimization works well.


Quotation marks included or not in the EN tag

In the following:

political opponents such as Marxists, liberals, Christians and the "reactionaries" who were viewed as wayward "National Comrades"

I want to anotate "reactionaries" like the others PERSON_TYPE entities. Should I include the quotes in the tag or not?
1) <ENAMEX type="PERSON_TYPE">"reactionaries"</ENAMEX>

or
2) "<ENAMEX type="PERSON_TYPE">reactionaries</ENAMEX>"

From my point of view, the quotes should not be included. The presence of absence does change the significate of the class? I think not, as reactionaries is still a PERSON_TYPE class.

Yes, as a general rule in GROBID, punctuations and any similar sugar should be left outside the tagged "field".


Remove Logserver module

What changes are proposed in this pull request?
Remove Log server module
Why are the changes needed?
Few users are using this feature which is introduce unnecessary complexity to the code
Does this PR introduce any user facing changes?
Yes, no log server will be available

@LuQQiu  I remember there is a CVE issue caused by the log4j dependency introduced by logserver. can you double check if we can fix it now?

alluxio-bot, merge this please


Update setup.py

plot_graph() function is incompatible with matplotlib versions newer than 3.5.

@msinamsina Thank you for your PR, merged +1


Collection item template updates

At the moment, the itemtemplate information at:

api/core/collections/{UUID}/itemtemplate

contains too much detail:

inArchive
discoverable
withdrawn
...

These need to be removed, because for an item template, these properties etc don’t actually MEAN anything. A template item can never be archived for example, should never be discoverable, and the like.
Where previously an 'ItemTemplate' was basically just an instance of an Item, the removal of the superfluous information now has differentiated the actual usages of an item vs an item template.
Since these differences have now occurred, a split has been made so that the TemplateItemRest is an object in and of itself that can be used in the appropriate related code.
In the future, this also allows us to do more fine-grained tweaking to either object without altering the other object

@jonas-atmire : This PR has merge conflicts after the merger of #2625.  Could you please rebase it?

This PR has merge conflicts after the merger of #2625. Could you please rebase it? Once rebased, this looks ready to merge.

@tdonohue An update for this, The rebase on the latest master has been done.

Thanks @jonas-atmire ! This looks good to me. Merging


Including a file in multiple targets

I have a project that uses multiple targets inside one project. Each target is a different version of the app, i.e. a target for CakeMania, a target for CakeMania for Kids. I believe this is a fairly standard way of managing app variants.
Most of the files are shared between the targets, but some targets include additional SDKs and of course some different files (for icons, built-in assets, configuration, etc).
CocoaPods helps us organize our 3rd party components using Ruby functions, making the configuration very clean and easy to read. I hoped Xcake could do the same for our project files.
The Cakefile looks like this (omitting project configuration block):
def cakemania_shared(target)
  target.include_files = ["Source/App/APIHelper.*"]
end

application_for :ios, 8.0 do |target|
    target.name = "CakeMania"
    cakemania_shared(target)
  end

application_for :ios, 8.0 do |target|
      target.name = "CakeMania for Kids"
      cakemania_shared(target)
end

The desired output project file would have one copy of the APIHelper.m file, with membership in both targets.

The current output project file includes the file in the project twice, with non-overlapping membership.

Ah nots great, Xcake should definatly be doing the first screenshot. I'll try and recreate this locally and issue a fix.

Agree this is important and should be a priority.

:) Going to look at this this weekend and try to fix all the XC 8 issues

Hey guys! News on this issue?
For now I'm using version 0.6.25 since multiplying files don't happen.

@eiditakahashi  I've done some work but I'm currently unit testing it. That would make sense there was a change in the architecture in 0.7 so maybe that broke it.
could you upload an example project with the issue ? I would love to test it against your project.

@jcampbell05 here it is:
test project running 0.7.1 https://www.dropbox.com/s/4i0h4jv580mps7c/test.zip?dl=0

@jcampbell05 yeah, it works! Not duplicating anymore! But now I am facing another problem related to build_phase I will open another issue for this. Thanks!


importing IMGT files with repLoad

Hi, i have just installed immunarch package. I don't seem to be able to import IMGT data.
I have downloaded the IMGT result files that i stored into a LyT1_15092 local directory. This dir contains the following files:

The code i have used is the follinwg, as well as the errors produced:

It appears that the only IMGT file that the script parses is 3_Nt-sequences.txt.
It warns of parsing failures and of Missing column names.
The imported data is in the right format ($data + $meta) but the clumns Clones and Proportion are obviously wrong : no summary of the same clone was calculated.
Maybe all is right, but this means then that i should first calculate the right values for these columns.

Thank you.

Hello, have you solved this problem? How to use this package to import IMGT data？

Hi.
I've experienced the same problems with this. Any updates?
Thanks

Hi, @drossille, @yujia-w and @aislinnjennings!
My name is Aleksandr Popov, I am a developer of the Immunarch package. Thank you for using our software!
When you start the analysis with IMGT V-Quest, select the option "Download AIRR formatted results" (like shown on the picture).

After the analysis, unzip the result and load tsv file to Immunarch with repLoad function.
If this AIRR file still doesn't open, please provide a minimal reproducible example of your data that produces error on loading.
Best regards,
Aleksandr

Hi Team.
Hope you are well.
I was wondering if this issue has been resolved:
https://github.com/immunomind/immunarch/issues/104
I'm also trying to determine Shannon-evenness from my dataset. If this is possible with Immunarch it would be great.
Thanks so much.
Ais

Hi Team.
Hope you are well. I was wondering if you can help me with something please.
When I run the following command on the practice immdata dataframe;
pr.aav <- pubRephttps://immunarch.com/reference/pubRep.html(immdata$data, "aa+v", .verbose = F)
the result is a dataframe with the CDR3 amino acid sequence and the V gene (which is as expected and great).
However, I've found when I run the same command on my data, I obtain the CDR3 amino acid sequence and V allele as opposed to the gene.
I'm not sure how to change this or if maybe its's a bug?
I was wondering if you have any ideas please.
Thanks a million.
Aislinn

Hi, Aislinn!
I've moved this question to a new issue: https://github.com/immunomind/immunarch/issues/302
Best regards,
Aleksandr


testing checks

TEST

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

CLA check was successful. nothingtodohere.