ssh causes system halt, BSOD after KB4489868

I know it says not to post BSOD, but this issue is impacting multiple users.  When using ssh with the -A flag, or for some people when using any key, it causes a blue screen of death.
Details in the reddit thread: https://www.reddit.com/r/bashonubuntuonwindows/comments/b0o6v6/after_update_ssh_to_remote_hosts_cause_blue_screen/

I reported at https://github.com/Microsoft/WSL/issues/3915 I will close mine. I emailed minidumps to<EMAIL_ADDRESS>which refused them.

We were able to repro this internally and are working on a fix.

I have this problem too. I used ssh-agent and it lead to BSOD.
Good to know you are aware of the problem.

Also experiencing this problem when using ForwardAgent. Waiting for your fix!

same issue on my side. It occurs only when I forward the agent (with -A option).

As https://www.reddit.com/r/bashonubuntuonwindows/comments/b0o6v6/after_update_ssh_to_remote_hosts_cause_blue_screen/ says rolling back KB4489868 means I can continue to use my machine until there is another fix.
I really came to say thank you for making windows useable for developers and admins.

My experiments shows that problem disappears when I have not used or turned off Agent Forwarding.
I had it turned on for all my SSH connections in the .ssh/config. So after commenting the following line in my config I have avoided BSOD:
ForwardAgent yes

Take into account that this setting could be defined for every host definition in your config so it could cause that some hosts are accessible and some will cause problem.
If you do not use config file then you still could reach to problem if you use Agent Forwarding by setting -A  option for your ssh command. Just as temporary solution - you could avoid to use it.
Fortunately this and next week I don't need to work actively with hosts that need Agent Forwarding so I will just wait when guys will have fixed the root of the problem, prepare it as regular update and let us know in this thread that we can turn on Agent Forwarding again. :)

This is a really annoying one.....the ssh is a core service.

@Brian-Perkins

We were able to repro this internally and are working on a fix.

8 days gone since you could reproduce the problem.
I would appreciate any news and estimation about when it could be fixed? Maybe you need any help?

@achernyakevich-sc - as you are aware, shipping new bugs as part of updates is not ideal (where we find ourselves here), so there are a number of processes we have internally, designed to increase the quality of our update packages. We are navigating through those processes now. In this case, the issue is serious and the fix is fairly simple, so I am hopeful we can make the April release. We tend to avoid dates in these scenarios, as providing a date would imply more certainty than we actually have. I can say with certainty that everyone is aware that this needs fixed as quickly as possible.

Is there any workaround that can help us to fix this issue? Agent forwarding is a part of my deployment process, sorry but we can not to wait until April, ssh is a core service.
May be its possible at least to build and install manually a beta prerelease version of this fix?

I have no workaround, in fact I wish there was something to just disable or ignore this update... (I'm using windows home), every 2 days this updates gets installed again and I have to manually remove it...
disabling the windows update service doesn't seem to do much as it re enables itself after a day or 2.
so I'll be removing this update until April I guess.

Seems like you can pause updates in Settings > Windows Update > Advanced Settings

@crostine hey, thanks for the suggestion. Can you pls explain or send a link how to revert this update? I think it will be useful for everyone!

I have tried many things, believe me.
in my windows home there is no such thing as pausing updates
I just tried this tool: https://support.microsoft.com/en-us/help/3073930/how-to-temporarily-prevent-a-driver-update-from-reinstalling-in-window
It looked like it was working, until I restarted the computer, then the update got installed anyway and well it's not hidden anymore even after removing it.
so maybe I can fake my connection to be a metered connection and prevent windows from downloading that way, at the cost of all the problems metered connections have.
@ggolda to remove the update
I go to windows update overview in settings
then click "view update history" almost at the top
then click "uninstall updates" at the top
it then opens a new window with the title "Installed Updates"
here you can uninstall the update by finding it in the list, selecting it and select uninstall.
and do the restart after the uninstall.

Dear @Brian-Perkins

so I am hopeful we can make the April release.

I know how is it when you develop and maintain complicated software solutions and what kind processes could be behind of it. Thank you very much for providing information about April release. We will keep fingers crossed to get it fixed as you plan. :)

@crostine thanks!

My Laptop does not get this update, even if I press check for updates several times.
I think this update might be removed temporary.

@Brian-Perkins Hope April update will be better and more stable!

Could this be related to:
https://community.mcafee.com/t5/Endpoint-Security-ENS/blue-screen-mfeepmpk-wsl-git/td-p/616729
I can't even open WSL from ConEmu or MobaXterm without a BSOD due to a pagefault by mfeepmpk.  I don't even get to run SSH.

The driver mentioned from the bugcheck is the Exploit Prevention driver (mfeepmpk.sys).  A possible work-around would be to disable Exploit Prevention.
This works but is not an option for many of us working in restrictive corporate environments.  I'll see if I can remove the update mentioned here.

To remove the patch I'm running wusa /uninstall /kb:4489868 via admin console.
Will try the pause updates to stop the re-installation too!

The driver mentioned from the bugcheck is the Exploit Prevention driver (mfeepmpk.sys). A possible work-around would be to disable Exploit Prevention.

Worked for me! Can't tell if it was the windows-update or McAfee...

Uninstalling kb4489868 is just a temp fix; Windows Update will just reinstall it. Disabling WU just because of this will miss out on other potential key fixes. Very much hoping on a swift fix here!

@achernyakevich-sc how are you doing this?
I do not have a .ssh/config in any of my ubuntu directories so I can't see how this works.
I switched it off in /etc/ssh/ssh_config, but it didn't make a difference - it still blue screens when I try to ssh using Jsch via java. I couldn't find any way to turn off agent fowarding in Jsch.

My experiments show that problem disappears when I have not used or turned off Agent Forwarding.
I had it turned on for all my SSH connections in the .ssh/config. So after commenting the following line in my config I have avoided BSOD:
ForwardAgent yes

Take into account that this setting could be defined for every host definition in your config so it could cause that some hosts are accessible and some will cause problem.
If you do not use config file then you still could reach to problem if you use Agent Forwarding by setting -A option for your ssh command. Just as temporary solution - you could avoid to use it.
Fortunately this and next week I don't need to work actively with hosts that need Agent Forwarding so I will just wait when guys will have fixed the root of the problem, prepare it as regular update and let us know in this thread that we can turn on Agent Forwarding again. :)

I`ve upgraded to 1809 and the problem is gone.

Yes. 1809 fixes the BSOD, but now I can't ssh to a remote host. Regular Windows ssh works fine. Argh!!
WSL SCP works fine too. SMH

I had SSH do that for me and a reboot fixed it. Go figure.

Just joined the club and installed 1809.
So far no issues.

Dear @draycasejr

@achernyakevich-sc how are you doing this?
I do not have a .ssh/config in any of my ubuntu directories so I can't see how this works.
I switched it off in /etc/ssh/ssh_config, but it didn't make a difference - it still blue screens when I try to ssh using Jsch via java. I couldn't find any way to turn off agent fowarding in Jsch.

SSH client config file usually is located at ~/.ssh/config, If you cant find it then you have no special config. But this is used only for ssh utility.
So in your case as you use Java solution this config file even if it exists will not be applied. You need to find a way how to disable AgentForwarding from inside of Java utility.
Though it looks as not actual anymore. I have just installed Features Update 1809 and problem is gone completely. So the simplest way for you could be just install latest updates.
Finally,  @Brian-Perkins - it looks this issues could be marked as resolved and get closed.
Thanks to everybody who helped to get it fixed! :)

To address this on RS3 (version 1709, build 16299.*), apply KB4493441. If you are able to upgrade to a newer release, that is also a good solution as there are new WSL features in every release.

So according to https://support.microsoft.com/en-us/help/4493464/windows-10-update-kb4493464 a patch was rolled out to address this and I can confirm on my system that it no longer blue screens when I enabled agent forwarding in the config....that being said its NOT actually agent forwarding at all..
To be sure prior to the update I tried to agent forward - and it blue screens I then updated and tried again nad we had no blue screen  = however no I have no agent forward despite using -A  to force it.

@Narimm - now you are likely running into #3183 which unfortunately was not fixed until a couple of releases later RS5/1809. Prior to this fix we did not support closing one end of a unix socket and still getting credentials from the other, so it would only work when you got lucky racing with the close. That race windows has narrowed with the latest RS3 packages, so the unfortunate side-effect is you are more apt to hit this issue.

Yeah thanks I just installed RS5/1809 and confirm via the verbose ssh logs that forwarding now works as expected - I would suggest this issue be marked as resolved and closed

Working after latest win update May 2019 version 1809.

I replicated the  problem with May 2019 Update. I don't think it is solved.

I have pretty the same issue. After some discovering I found out this article. For me, the issue is that McAfee is blocking this action with Exploit Prevention mechanism.
Check this link: https://community.mcafee.com/t5/Endpoint-Security-ENS/blue-screen-mfeepmpk-wsl-git/td-p/616729
Maybe it will help you. Best regards

BUMP. Almost 10 months since this issue was raised. I'm not using any 3rd party anti-virus or tool, just naked Windows Enterprise, Build 18362.19h1_release.190318-1202 which is latest build available, still I can reproduce this.
What is core objective to develop enterprise version, when we even can't use SSH and simple git fetch/git pull properly. Any ETA to fix this issue?

I found that this crash is also caused by the Windows Security 'ransomware protection'. Turning off the 'controlled folder access' setting fixed the BSODs for me.

I found that this crash is also caused by the Windows Security 'ransomware protection'. Turning off the 'controlled folder access' setting fixed the BSODs for me.

I take that back. I later tried running npm install in a project, which again caused the PAGE_FAULT_IN_NONPAGED_AREA error.

@JoshTumath this might be a separate problem


Xmla.js Ln 59 : window not defined

_useAX = window.ActiveXObject ? true : false
git://gist.github.com/1714653.git

Changing to _useAX = false;

Ok. You'll probably find that by the time all work in the Xhr has been done, this var can vanish completely from the node.js implementation.


Support restricted network environments

Update operator to support installation in restricted network environments. Specifically:

switch from image tags to image digests
add relatedImages metadata for additional images.

Additional details in

https://docs.openshift.com/container-platform/4.3/operators/operator_sdk/osdk-generating-csvs.html#olm-enabling-operator-for-restricted-network_osdk-generating-csvs
https://docs.openshift.com/container-platform/4.3/openshift_images/image-configuration.html#images-configuration-registry-mirror_image-configuration

Fixed via https://github.com/application-stacks/runtime-component-operator/pull/146


Effect paging doesn't work

When you see effect for selected transaction (e.g. https://goo.gl/47WXEq ) and click on _links:next:href, it brings you on the same page (page with empty effect is expected). When accessing the JSON directly, it works fine.

I'm seeing an additional bug at the same URL. Click the next.href link and lab tries to open it in testnet, resulting in a 404.
ie. effects for txn on live network; next points to 404 on test network.   Removing -testnet from the subdomain results in exactly the same page as the first.

Looking into this.
@Synesso the testnet/pubnet error is fixed as of #316 .


Bootstrap uses nested labels for check/radio

Using :inline will leave a bottom margin on the label, resulting in a misaligned label for checkboxes / radiobuttons.

Would you like to submit the PR at rafaelfranca/simple_form-bootstrap were the generator is maintained.
Here you see the direct implication of your change within the different form types of bootstrap.


Kubernetes Conformance update

This change adds support for Kubernetes 1.9, 1.10, and 1.11

Coverage remained the same at 42.733% when pulling e2d60710678f87476f810b34f2a7c4131e7ef33c on gopherstein:release-1.0 into 4c4e56ad03c84cbb901eefddcede30eab039fc32 on supergiant:release-1.0.

LGTM


Nicer handling of PTR queries

amphp DNS doesn't handle calls like this:
yield Amp\Dns\resolve('<IP_ADDRESS>', $options = ['types' => Amp\Dns\Record::PTR])

Currently, you need to manually convert the IP address to the right PTR query:
yield Amp\Dns\resolve('<IP_ADDRESS>.in-addr.arpa', $options = ['types' => Amp\Dns\Record::PTR])

The legacy Net_DNS library has some code to handle PTR queries correctly, when the input looks like an IP address:
        /*
         * If the name looks like an IP address then do an appropriate
         * PTR query.
         */
        if (preg_match('/^(\d+)\.(\d+)\.(\d+)\.(\d+)$/', $name, $regs)) {
            $name = $regs[4].'.'.$regs[3].'.'.$regs[2].'.'.$regs[1].'.in-addr.arpa.';
            $type = 'PTR';
        }

https://github.com/pear/Net_DNS/blob/5786b8c6f21c3cc8915fe251dac1571fa524a417/Net/DNS/Resolver.php#L552-L559
It would be nice for amphp to do this too.

You should use Amp\Dns\query for everything that doesn't resolve to an IP address. So in this case yield Amp\Dns\query('<IP_ADDRESS>.in-addr.arpa', Amp\Dns\Record::PTR); But you're right, we could add auto-rewrite here.
@bwoebi Didn't we have a protection that restricts resolve to A and AAAA queries?

Amp\Dns\resolve actually seems to work properly, Amp\Dns\resolve('<IP_ADDRESS>.in-addr.arpa', ['types' => Amp\Dns\Record::PTR]) gives me the right result.

Yes, I know that it works, but it's not supposed to work. I think we had a restriction in there before.

Do you have any suggestion for a better function name? I'm not sure what to do with an invalid IP, probably throw an exception, but not sure which one. InvalidAddressException might make sense, but it should probably not extend the ResolutionException in this case.
function ip2arpa($ip) {
    $packedIp = inet_pton($ip);

    if ($packedIp === false) {
        return null; // FIXME
    }

    if (isset($packedIp[5])) { // IPv6
        return wordwrap(strrev(bin2hex($packedIp)), 1, ".", true) . ".ip6.arpa";
    }

    return inet_ntop(strrev($packedIp)) . ".in-addr.arpa";
}

I created a PR now. It doesn't use a separate function, see #52.

It's now included in https://github.com/amphp/dns/releases/tag/v0.8.14.


[BUG] "Cannot find name..." unless empty <script> tag is present in .vue file?

Initial clarification: When I create my Vue app I do an app.config.globalProperties.$payload = reactive(...); to make some server injected data accessible across my application on the client side. I generally treat the data as read only, and use it even sometimes in tiny components with no need for logic outside of the <template>.
Now the bug: Using the following minimal test.vue file:
<template>
  {{ $payload }}
</template>

I get a Cannot find name '$payload' TS error.

Oddly, I can resolve this error by simply adding an empty <script> to the file like so:
<script>
</script>

<template>
  {{ $payload }}
</template>

I never got this error when previously using Vetur. I also am not using TypeScript in my project, just JavaScript. Possible solutions I've thought of:

Always adding an empty <script> tag to silence the error. Nasty.
Somehow telling Volar/TypeScript what $payload is, but I don't know how to do this.
Going back to Vetur (but overall that feels like a downgrade).
Using inject("payload") with an app.provide("payload", ...) instead of app.config.globalProperties. I'd rather not do this, I know that an argument can be made for better clarity or whatever but in my project it really only adds extra boilerplate code across  many of my components.

What is the solution?

// file: main.ts

...

app.config.globalProperties.$payload = 1;
declare module "@vue/runtime-core" {
  interface ComponentCustomProperties {
    $payload: number
  }
}

Hi @xiaoxiangmoe, I haven't used TypeScript before in any of my projects, as I sort of implied above. Would you mind explaining what exactly the code you shared is doing?

This is using Declaration Merging in TypeScript.
When I write
declare module "@vue/runtime-core" {
  interface ComponentCustomProperties {
    $payload: number
  }
}

I registered $payload to the global type ComponentCustomProperties.
Volar will read ComponentCustomProperties interface in @vue/runtime-core and use it in all template type checking.


Build on OSX

It seems like the Makefile is not longer able to work on OSX 10.7.5.
I keep getting issues along the lines of :
In file included from src/c/luajava.c:39:
src/c/luajava.h:2:17: error: jni.h: No such file or directory
It seems that in the switch from Apple to Oracle, things have been moved.

I have successfully compiled it on Mac OSX, altering the following lines in...
Makefile:
$(SO_FILE): $(OBJS)
export MACOSX_DEPLOYMENT_TARGET=10.11; $(CC) $(LIB_OPTION) -o $@ $? $(LIB_LUA)
config:
INCS= -I$(JDK)/include -I$(JDK)/include/linux -I$(LUA_INCLUDES) -I$(JDK_HOME)/include -I$(JDK_HOME)/include/darwin


support query hint context for sharding-proxy

Feature Request
For English only, other languages will not accept.
Please pay attention on issues you submitted, because we maybe need more details.
If no response more than 7 days and we cannot make decision by current information, we will close it.
Please answer these questions before submitting your issue. Thanks!
Is your feature request related to a problem?
No.
Describe the feature you would like.
Support query hint context for sharding-proxy.It looks like that:

sctl:hint show status
result like that:

master_only
database_only
database_sharding_values
table_sharding_values

0
1
value1,value2

sctl:hint show status table=user
result like that:

master_only
database_only
database_sharding_values
table_sharding_values

0
0
value1,value2
value3,value4

Maybe the commands design is not clearly enough.We can discuss here.

this is my opinion

sctl:hint show status
result like that:

master_only
sharding_type

true / false
databases_only / tables_only? / databases_tables

sctl:hint show table status
result like that:

table_name
database_sharding_values
table_sharding_values

t_order
value1,value2
value1,value2

Ok,I understood that.Two main differences between our opinions:

the type of master_only is CHAR not BIT
show table status command have no parameters,and will show all tables's status.

Agree with that.I will do this feature today.

@cherrylzhao what 's  tables_only meaning in sharding_type?

what 's tables_only meaning in sharding_type?I think databases_only and databases_tables is enough.

we have example to shard table only, so I'm doubting about whether it could be supported in hint, you can ignore it at first.

thow to show database sharding values if database_only?

we can list all the logic tables if possible, or just list a wildcard of abbreviation.

With the second question,I mean how to show database sharding values if database_only,because if the database_only,the table_name will be empty.

if table_name is empty, we can get all the logic table from ShardingRule if possible.

I understand.

Seems that in sharding-proxy command-line, it doesnt support "sctl:hint show stauts", it threw errors:
mysql> sctl:hint show status;
ERROR 10002 (C1000): 2Unknown exception: [sctl:hint show status]
sharding-proxy version: 4.0.0-RC2

@Myshiner This feature is planned to be added in version 4.0.0-RC3 and is still under development.

Great.Sent from my Huawei Mobile-------- Original Message --------Subject: Re: [apache/incubator-shardingsphere] support query hint context for sharding-proxy (#3057)From: liya To: apache/incubator-shardingsphere CC: Myshiner ,Mention @Myshiner This feature is planned to be added in version 4.0.0-RC3 and is still under development.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/apache/incubator-shardingsphere/issues/3057?email_source=notifications\u0026email_token=ALQCBEMG3ABJH4BGOFOSKVDQLNFHXA5CNFSM4IX5ARJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7RS5RI#issuecomment-534982341",
"url": "https://github.com/apache/incubator-shardingsphere/issues/3057?email_source=notifications\u0026email_token=ALQCBEMG3ABJH4BGOFOSKVDQLNFHXA5CNFSM4IX5ARJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7RS5RI#issuecomment-534982341",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]


imagemagick does not have a relocatable bottle

I received this warning from Pkg.update() for Julia master (with Homebrew 0.3.1):
WARNING: New JSON object doesn't agree with old in key "installed"; we screwed something up while translating imagemagick
WARNING: Original formula: Any[Dict{String,Any}(Pair{String,Any}("built_as_bottle",false),Pair{String,Any}("used_options",Any[]),Pair{String,Any}("version","6.9.5-0"),Pair{String,Any}("poured_from_bottle",false))]
WARNING: Translated formula: Any[]
WARNING: The following packages do not have relocatable bottles, installation may fail!
Please report these packages to https://github.com/JuliaLang/Homebrew.jl:
  imagemagick

This is coming from the base problem as #127, so I'm going to close this as a duplicate.  Thank you for the report!


GH-1140 add safe usage of SCM variable

This fixes #1140 by using shell parameter expansion to ensure that accessing the variable SCM succeeds even if it's unbound and the environment is using set -u

hey @nwinkler
Per your suggestion I'm initializing the variable before access and removed the 'defaulting' syntax from uses.
As an aside, the ${var:-} form is generally accepted when making set -u compatible code, but I think your suggested approach is actually less error-prone!

Looks good to me - thanks!


Feature Request: Some sort of ARIA-landmarking for each header/section

It would be super cool to get better ARIA screenreader strings on the headers to delineate where a user's context is at on the query.
There's probably a way to do it like "if the user enters this section, read the header aria text out" but I'm not entirely sure.
I would assume the best way to read it out would be "You are in Query Builder - Section X" and then add "in Section Y" at the end of this string if it is nested.  You might be able to get away with an aria label but I would be inclined to landmark I thiiiiink.

Just getting back to this and wanted to jot down some notes:
Going by https://www.w3.org/WAI/GL/wiki/Using_ARIA_landmarks_to_identify_regions_of_a_page, it seems like we would only need to add role="form" to the outermost div, and aria-label="[something about position in the hierarchy]" to each rule group. Both should be configurable, maybe within the translations prop.
According to https://www.w3.org/WAI/ARIA/apg/patterns/landmarks/examples/form.html:

If a page includes more than one form landmark, each should have a unique label.

This complicates the aria-label config since it could be dynamic based on the path. Maybe it could accept a function with path as a parameter?

Hey @lkarvec, I've been noodling and researching this one for a while and came up with a new prop (see #580) that generates a title for the outer <div> of each rule group. I was going to use aria-label, but after reading the "first rule of ARIA" (also on MDN) and testing with React Testing Library's toHaveAccessibleName matcher, it seems title is preferred.
If this doesn't work, please let me know if you have any suggestions. I don't have much (read: enough) experience with a11y.

I'm always stumbling through it myself, not gunna lie.  If you want some feedback in testing, I could ask our testing team to tackle it if free.  I do feel like this is adequate though.  Thank you!

I'm always stumbling through it myself, not gunna lie.  If you want some feedback in testing, I could ask our testing team to tackle it if free.  I do feel like this is adequate though.  Thank you!

Thanks for getting back to me. I would love for someone to take a look at it if possible. I'll see if I can publish an alpha version this weekend that you can use. It'll be the first v7 prerelease.

I went ahead and merged #580 into main, which automatically closed this one, but I'd still like any feedback you or your testing team could provide. I also published v7.0.0-alpha.0 that includes the new accessibleDescriptionGenerator prop. The default implementation is here.


Proxy calls to InfluxDB with nginx

So, having something like
yaml
- name: "INFLUXDB_HOST"
  value: '"+window.location.hostname+"/api/v1beta1/proxy/services/monitoring-influxdb'

is very limitative when it comes to running influxdb + grafana, especially inside Kubernetes.
See my suggested solution.

+1 to making this change. As long as it works on most kubernetes cluster
setups, I am fine with that change.
On Thu, Feb 26, 2015 at 6:19 AM, Paulo Pires<EMAIL_ADDRESS>wrote:

So, having something like
yaml

name: "INFLUXDB_HOST"
value: '"+window.location.hostname+"/api/v1beta1/proxy/services/monitoring-influxdb'

is very limitative when it comes to running
influxdb

grafana , especially inside Kubernetes.

See my suggested solution
https://github.com/GoogleCloudPlatform/kubernetes/issues/4841.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/heapster/issues/135.

In progress..


fix: clean files before startup & model compatible

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[ ] commit message follows commit guidelines

Affected core subsystem(s)

Description of change

Codecov Report

Merging #43 into master will decrease coverage by 1.51%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   98.97%   97.45%   -1.52%
==========================================
  Files          19       16       -3
  Lines         681      629      -52
  Branches       85       84       -1
==========================================
- Hits          674      613      -61
- Misses          1        5       +4
- Partials        6       11       +5

Impacted Files
Coverage Δ

src/utils.ts
95.62% <100%> (-2.68%)
:arrow_down:

src/config.ts
100% <100%> (ø)
:arrow_up:

src/index.ts
96.87% <93.33%> (-1.44%)
:arrow_down:

src/generators/plugin.ts
95.65% <0%> (-4.35%)
:arrow_down:

src/generators/custom.ts
96.42% <0%> (-3.58%)
:arrow_down:

src/generators/config.ts
97.61% <0%> (-2.39%)
:arrow_down:

src/bin.ts

src/cmd/clean.ts

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc3daf...29dc490. Read the comment docs.

1.24.1


Bugfix: strOutpath in Report_KRI()

Expected Behavior
If I pass a filename or relative path, I expect the report to write to my working directory (or relative to my working directory).
Current Behavior
If you pass something other than an absolute path, it writes to the directory where the template report comes from (inst during dev, the root of the installed package for users). This behavior is inherited from rmarkdown::render().
Possible Solution
Use {rprojroot} to put it relative to the project, or perhaps fs::path_abs() to do it relative to the working directly (not taking a project into account). The here::here() docs recommend NOT using it in functions.
Steps to Reproduce

Context (Environment)

Possible Implementation

Additional Comments

fixed in #1768


Update lsp3-universal-profile-metadata.md

I'm assuming the LSP2 Standard should maintain a particular structure, or it doesn't matter?

@EngrGord Thanks for the PR, you are right
You can re-open so we can merge 🚀

It doesn't matter as it is at the end just a JSON object, so order has no importance. But we can be consistent in our docs - for the human - so this PR makes sense. Thanks !

For the erc725js pages we need to update in the erc725js repo as well


Fix: bad comment.

sorry im trying fix

I fix this problem in https://github.com/aki017/slack-ruby-gem/commit/dd76753bde0bfe4b2587e80877ba73644b87dde7
and released new version(1.1.6) https://rubygems.org/gems/slack-api/versions/1.1.6


Pandabot won't show until i set export LC_NUMERIC="en_US.UTF-8"

Description
After following all tutorials this line
ros2 launch moveit2_tutorials demo.launch.py rviz_tutorial:=true
won't work as predicted
move_group-4] [ERROR] [1662375043.529176769] [moveit_robot_model.robot_model]: Joint 'wheel_left_joint' not found in model 'panda' [move_group-4] [ERROR] [1662375043.529211279] [moveit_robot_model.robot_model]: Joint 'wheel_right_joint' not found in model 'panda'
Your environment
ROS Distro: Galactic
OS Version: e.g. Ubuntu 20.04
git clone -b galactic https://github.com/ros-planning/moveit2_tutorials.git --depth 1

Steps to reproduce
Freshly install, ros2 via ros2 tutorial and moveit2 via tutorial -
https://moveit.picknik.ai/galactic/doc/tutorials/quickstart_in_rviz/quickstart_in_rviz_tutorial.html#getting-started
Expected behaviour
rviz should open with panda robot
Backtrace or Console output
[Use gist.github.com to copy-paste the console output or segfault backtrace using gdb.](https://gist.githubusercontent.com/MightyMirko/c371c035d11626f21605bf18e4b848a3/raw/d6a511abf2d2b8b43a5c51b2d361bfdacf8765d6/error.log)

i need to set
export LC_NUMERIC="en_US.UTF-8"

then it will work
if it is not set one will see this error:
`rviz2-1] [ERROR] [1662547064.760901552] [moveit_background_processing.background_processing]: Exception caught while processing action 'loadRobotModel': parameter 'panda_arm.kinematics_solver_timeout' has invalid type: Wrong parameter type, parameter {panda_arm.kinematics_solver_timeout} is of type {double}, setting it to {string} is not allowed.
`

rviz2-1] [ERROR] [1662547064.760901552] [moveit_background_processing.background_processing]: Exception caught while processing action 'loadRobotModel': parameter 'panda_arm.kinematics_solver_timeout' has invalid type: Wrong parameter type, parameter {panda_arm.kinematics_solver_timeout} is of type {double}, setting it to {string} is not allowed.

isn't it an issue by having , instead of . in decimal numbers?

Yes, locale=de_DE expects a comma instead of a dot due do a bug in parameter parsing. However, it's not a bug related to liburdfdom, which was another well-known issue in the past.

And to answer your question: yes! the exception is gone after setting to en_US

This is a known issue with ROS. The instructions for installing ROS (https://docs.ros.org/en/rolling/Installation/Ubuntu-Install-Debians.html#set-locale) include a section on setting your locale for this reason.


Why is IPMI internal?

After understanding internal packages in Go, I now know why we have to have such a code in Actor. My question is: Why?
The code in Actor is now inconsistent, and it will definitely remain so.

The IPMI implementation in Actor was done before bmclib got its implemention of the IPMI interface methods. What is your point in this issue, do you have a suggestion for a way forward?


Type of Administrator required

The use of an OATH hardware token can be a great option.  Many people would like to make sure that this can be assigned by an administrator using the least privilege principle.  The document describes that an administrator can perform the task but not which Azure AD Role is required.  I believe at present this is Global Admin (rather than authentication admin) I think this would be good to state explicitly here.
Dave

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3580bf07-789b-a9c0-26c2-68d21eb66b70
Version Independent ID: f61c354b-cac2-c3e2-881a-2f0540bdd8e1
Content: OATH tokens authentication method - Azure Active Directory
Content Source: articles/active-directory/authentication/concept-authentication-oath-tokens.md
Service: active-directory
Sub-service: authentication
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@DGuest44 Thank you for your inputs. We will have this suggestion reviewed and update this thread.

Hello @MicrosoftGuyJFlo , can you please take a look at this and update the doc accordingly.

@mmcla Thoughts on required role to upload hardware tokens?

For now it is still global administrator. #please-close

For now it is still global administrator. #please-close


Pandas 1.5 support

Adds support for Pandas 1.5, along with the group_keys argument to groupby
Fixes #22847

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python PreCommit

Local env tests are currently failing on master - https://github.com/apache/beam/actions/workflows/local_env_tests.yml - its unclear to me why, but it seems related to #7849

Run Python PreCommit

Run Python PreCommit


#error in source file causes hlint toprint stack trace

In this source file, we have:
#ifndef PROJECTM36_VERSION
#error PROJECTM36_VERSION is not defined
#endif

The version is passed in via cabal configuration so that the versioning is centralized. However, hlint actually gives up because of this:
hlint: #error PROJECTM36_VERSION is not defined
in src/bin/TutorialD/tutd.hs  at line 75 col 1
CallStack (from HasCallStack):
  error, called at ./Language/Preprocessor/Cpphs/CppIfdef.hs:113:21 in cpphs-1.20.8-JLeLxWRxjmm1BBYuZIZezR:Language.Preprocessor.Cpphs.CppIfdef

In this case, I can tack on --cpp-define PROJECTM36_VERSION=0.1, but it would be nice if this looked less like a crash and included a tip on how to resolve it.

Makes sense. We should probably make runCpphs from https://github.com/ndmitchell/hlint/blob/4e669a7cd2a535212a04e0102373e53a24c384b3/src/HSE/All.hs#L53 return Either ParseError String, and catch any exceptions thrown out of cpphs.


[REQUEST] Select which audio file to use for a beatmap

Is your feature request related to a problem? Please describe.
Some of my maps are packs with different songs, or the same song on different rates, and it's annoying when a sped up song song starts playing (it's hard to counter that with the playback speed slider + pitch is modified), or I simply can't listen to a specific song in a pack because that mp3 file isn't the chosen one.
Describe the solution you'd like
In my opinion the best solution would be to have a dropdown menu for maps that have more than one mp3 file (maybe look for metadata inside difficulties to distinguish between hitsounds and songs, or simply filter by duration or something like that), so you can chose whatever rate / song of the beatmap you prefer to listen to. It doesn't have to be anything fancy, just something funcitonal. This would be enough as it's already a niche case, but as a mania player where packs and rates are very common, I feel like it's still important. As a step further, adding an option to choose the default way of picking the audio file (to keep the current way or to always pick "audio", or something like that) and an option to remember your audio file pick would be perfect.
Describe alternatives you've considered
Another option would be to list all the mp3's as different songs, although that may be a little bit more annoying when dealing with different rates, assuming hitsounds and other sound effects don't get converted into songs and there is some way to give names to different audio files instead of default ones (not to have something like "audio1" and "audio2", but check difficulties of the map to give each audio file its proper diffname).
Additional context

All these have different songs on different diffs

Excuse my dan filled osu! folder, this was just an example

This will def. be possible to do. But I would probably prefer the soluton that each audio file has its own entry either with their filename or dif name  slapped to the back, depending on what data the actual .db and realm files give. Usually I thought it will import all those extra difs as well already, as those have their own beatmap info, including all their audio files and .osu file.
Maybe they get skipped for some reason.
But yes this is def. an improvement that makes sense.


greedy -> picsl_greedy

Description
Replaces greedy with its python binding picsl_greedy.
Related Issues
#7
Motivation and Context
Currently the user has to have greedy binary in their system to be able to run pyalfe with greedy as the image registration. Recently, python bindings were created for greedy and released on pypi.
Test Plan
The greedy image registration test already covers the change.
Reviewers
@btuan

please run integration


Multiple blocks?

Any interest in supporting multiple blocks? Layouts with multiple named insertion points that can be extended by other layouts/templates that define content overrides for the parents' named sections.
Or does that warrant a separate module?

@doowb and I talked about this a while back, I think we thought it was a good idea but couldn't decide what that would look like. any ideas for conventions/syntax etc?

:+1:


WIP Update sun.py

Description:
This pull request proposes some useful enhancements to the sun component. Without any configuration changes the new component will function exactly as the current component, so it is fully backward compatible, and hence is not a "breaking change."
The first change is to add some new, optional attributes - specifically daylight, next_daylight, prev_daylight, sunrise and sunset.
The sunrise and sunset attributes are particularly useful for paralleling the existing sun conditions in template code. Unfortunately the existing next_rising and next_setting attributes do not work well in this scenario because they change as soon as sunrise and sunset are passed, respectively. The new attributes stay constant throughout the day (only updating at midnight local), so they can be used effectively in templates.
The next change allows optional selection of which attributes the sun component maintains via a new monitored_conditions configuration parameter. The default is to maintain the original set of attributes. Since the component must update at each maintained attribute/event, if only a subset of the attributes are of interest to the user, there is really no need to take time to update the component for a data point the user does not use. This can be particularly useful if the user does not use or need azimuth and elevation, since these attributes are updated every minute.
Which leads to the next change, the addition of an optional scan_interval configuration parameter. If azimuth and/or elevation are being used, then this parameter controls how often they are updated. The default is to implement the existing behavior. If specified the rate at which these attributes are updated can be reduced, resulting in a potentially significant reduction in corresponding state_changed events. Of course, if azimuth and elevation are not used or needed, then all of the corresponding, frequent updates can be eliminated entirely.
To these ends the following, specific changes were implemented:
Add monitored_conditions config item to specify which attributes to maintain. If not specified then original set will be used. For elevation and azimuth, add scan_interval (minimum of one minute.) If next_rising or next_setting are not specified they will not be added as attributes. However, they will always be maintained so that sun's state can be determined/maintained. Add optional new attributes daylight, next_daylight, prev_daylight, sunrise & sunset, all of which will be updated at midnight local.
Additional background and discussion can be found here and here.
Related issue (if applicable): none
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
To be completed. In the interim, see Enhanced Sun Component for details.
Example entry for configuration.yaml (if applicable):
sun:
  monitored_conditions:
    - elevation
    - next_rising
    - next_setting
    - sunrise
    - sunset
  scan_interval:
    minutes: 10

Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @pnbruckner,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

I tried to fix the under and over indention failures but I don't seem to understand what it wants. If someone could point me to the coding standard where this is defined, I'll try again.

The test failure is because no tests were added for the new functionality.

I'm glad someone is taking the time to kill the state change events every minute, such a spamming feature.

I'm still pretty new to HA. This is my first code pull request. I haven't yet setup the development environment, and I haven't even begun to look at how to add test cases. I'll start on that tomorrow. I have over 40 years of software development experience, but not a whole lot with HA. Any pointers, etc. are appreciated. Thanks!

Great work by @pnbruckner > Been using this as a custom component and it's a great enhancement.

I set up the development environment on a clean Linux Mint virtual machine and switched to my patch-1 branch. FYI, I discovered the docs didn't mention the following components that I had to install to get tox to work: autoconf g++. And I had to install git. After doing all of this, I finally realized that it wasn't the tox testing that failed due to insufficient test cases - it was coverage/coveralls. Hmm, the docs don't mention how to install and use that. I guess I'll try to add some tests to tests/components/test_sun.py and try again.
BTW, actually the tox typing tests failed with a fairly useless error message:
ERROR: InvocationError for command '/bin/bash -c mypy homeassistant/*.py homeassistant/util/' (exited with code 1)

If you look at the coveralls result, "NEW MISSED LINES IN DIFF" shows up the codes missed in unit test.
If you still failed quality gate in coveralls, you can try to rebase your branch against dev.

coveralls details show the component I'm working on - sun.py - now has 100% coverage. So I'm going to start working on updating the documentation.

Hi all. I realize this is just one of 86 open pull requests, and there are only so many "members" to go around. But since this is my first code pull request, I just wanted to make sure there wasn't anything else I need to do. E.g., should I remove the lines under "If the code communicates with devices, web services, or third-party tools:" in the description, since these don't apply? Or should I simply "check" them? As it is, I see this results in "4 of 8" showing under the title of the PR, which might lead people to think I'm not done yet. Thanks!

Code looks good to me. @MartinHjelmare ?
Just one suggestion, if next_rising, next_setting and elevation has to be monitored for front end and for backward compatibility, shall we remove them from monitored_conditions list
By the way, 3 days is not too long for new pull request be reviewed.

Thanks @awarecan. Yep, not concerned about how long the process takes. Just wanted to make sure I wasn't the hold up.
If elevation was always maintained, then one of the biggest advantages of these changes would be lost - i.e., reducing the large number of state_changed events the sun component causes. And if a user doesn't care about elevation, or need it for something else, what does it hurt for it to be blank in the UI? For those who do want to see it or need it for something else, they can simply add it to the monitored_conditions list.
BTW, unless someone specifically adds monitored_conditions to their sun configuration, all the previous attributes, including next_rising, next_setting & elevation will be maintained anyway. So a user would have to explicitly add monitored_conditions before they could possibly lose these attributes. I did that purposely to maintain backward compatibility.
As for next_rising & next_setting, I could see removing them from the monitored_conditions and always having them as attributes. If that's the consensus I'm happy to do that.

I updated the code per the review change requests. It might be easier to compare to the original version, since I reverted some code back to the way it was. Also some of my new code should be simpler and easier to understand, especially as compared to the original code.

@pvizeli, just wondering if my last update satisfies your change requests. Also, what do you want me to do about async_added_to_hass? Per my reply I can't see how I can do what you suggested regarding that function. Thanks! If this is still on your to-do list, that's fine. Again I'm new to this so I just wanted to make sure this wasn't still waiting on something from me.

@pvizeli Can this be merged now?

@balloob, sorry, I know you're a busy guy, but is it common to wait this long? I first submitted this over two weeks ago. Then four days later (which, of course, was not an unreasonable wait) changes were requested. I provided changes the same day. But now I've been waiting a week and a half with no update, and not even a courtesy reply to my questions.
It's not necessarily the amount of time. It's getting no response at all that is disheartening. I've got other ideas of where I can contribute, but if this is any indication of how things go, I'm not sure it's worth the effort. I understand that this is a spare time project for most people, and I'm happy to wait my turn, but waiting with no end in sight is not encouraging.
Thanks for listening!

I've thought about it. Allowing picking of the attributes that the sun entity will contain is against how the rest of the system works. Monitored conditions should control the different individual entities that are being published. The only reason this one is called sun.sun is because it's one of the very first components ever built for Home Assistant. Before there even was a concept of (binary) sensors.
I think that this functionality should be added as new platforms for sensor and binary sensor (above horizon/below horizon). We should probably leave the old component alone just to not do any breaking changes. Things like daylight, next setting etc can all be published under a new device class timestamp.

Ok, fair enough. But I'm not up to creating a whole new set of platforms, so I'll just close this PR. Feel free to use any of my ideas or code. Thanks.


Style/SafeNavigation throws an exception when auto-correcting

The Style/SafeNavigation cop blows up when auto-correcting. Strangely this cop only activates when the TargetRubyVersion is specifically set to 2.3 or later in .rubocop.yml. It seems to not pick up the Ruby version from a .ruby-version for example.
The full source of files required to reproduce the issue is listed below, and also available in a gist: https://gist.github.com/jimeh/c65abfdd6e2bf36dcadc9b5364a0b741

Expected behavior
Auto-correct the reported style issue.
Actual behavior
Throws an exception by printing a backtrace of Rubocop internals and then exists.
Steps to reproduce the problem

Create three files:

.rubocop.yml
AllCops:
  TargetRubyVersion: 2.4

Gemfile
# frozen_string_literal: true

source 'https://rubygems.org/'

gem 'rubocop', '0.50.0'

foobar.rb
# frozen_string_literal: true

foo[bar] if foo

Bundle install:
 $ bundle install

Run Rubocop:
 $ bundle exec rubocop
 Inspecting 2 files
 C.

 Offenses:

 foobar.rb:3:1: C: Use safe navigation (&.) instead of checking if an object exists before calling the method.
 foo[bar] if foo
 ^^^^^^^^^^^^^^^

 2 files inspected, 1 offense detected

Run Rubocop auto-correct:
 $ bundle exec rubocop --auto-correct
 Inspecting 2 files

 0 files inspected, no offenses detected
 undefined method `begin' for nil:NilClass
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/parser-<IP_ADDRESS>/lib/parser/source/rewriter.rb:67:in `insert_before'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/corrector.rb:78:in `insert_before'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/style/safe_navigation.rb:99:in `block in autocorrect'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/corrector.rb:56:in `block (2 levels) in rewrite'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/parser-<IP_ADDRESS>/lib/parser/source/rewriter.rb:194:in `transaction'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/corrector.rb:55:in `block in rewrite'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/corrector.rb:53:in `each'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/corrector.rb:53:in `rewrite'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/team.rb:126:in `autocorrect_all_cops'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/team.rb:70:in `autocorrect'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/team.rb:98:in `block in offenses'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/team.rb:115:in `investigate'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/team.rb:94:in `offenses'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cop/team.rb:44:in `inspect_file'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:258:in `inspect_file'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:205:in `block in do_inspection_loop'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:237:in `block in iterate_until_no_changes'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:230:in `loop'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:230:in `iterate_until_no_changes'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:201:in `do_inspection_loop'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:111:in `block in file_offenses'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:121:in `file_offense_cache'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:109:in `file_offenses'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:100:in `process_file'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:78:in `block in each_inspected_file'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:75:in `each'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:75:in `reduce'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:75:in `each_inspected_file'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:67:in `inspect_files'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/runner.rb:39:in `run'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cli.rb:86:in `execute_runner'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/lib/rubocop/cli.rb:32:in `run'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/bin/rubocop:13:in `block in <top (required)>'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/2.4.0/benchmark.rb:308:in `realtime'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/rubocop-0.50.0/bin/rubocop:12:in `<top (required)>'
 /Users/jimeh/.rbenv/versions/2.4.1/bin/rubocop:22:in `load'
 /Users/jimeh/.rbenv/versions/2.4.1/bin/rubocop:22:in `<top (required)>'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/cli/exec.rb:74:in `load'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/cli/exec.rb:74:in `kernel_load'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/cli/exec.rb:27:in `run'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/cli.rb:362:in `exec'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/cli.rb:22:in `dispatch'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/cli.rb:13:in `start'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/exe/bundle:30:in `block in <top (required)>'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors'
 /Users/jimeh/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/bundler-1.15.4/exe/bundle:22:in `<top (required)>'
 /Users/jimeh/.rbenv/versions/2.4.1/bin/bundle:22:in `load'
 /Users/jimeh/.rbenv/versions/2.4.1/bin/bundle:22:in `<main>'

RuboCop version
$ rubocop -V
0.50.0 (using Parser <IP_ADDRESS>, running on ruby 2.4.1 x86_64-darwin16)

Fixed in #4749. 🙂 Feel free to open an issue about the version detection if you can isolate it.

@Drenmi Apologies, apparently I'm blind when I had a look for existing issues >_<
As for the version detection, I'll see what I can find out about it.

Apologies, apparently I'm blind when I had a look for existing issues >_<

No worries. The issues were closed, and we only released 0.50.0 a few days ago. 🙂


fix the item system

Hey it's me again. Shop is disabled for some reason.
I am willing to contribute to re-enabling it but since Node is not my language of choice the fix will be just the quickest, dirtiest one I can think of.

Right now I'm looking for commits from other repos so if you wanna help just reply!

Right now I'm looking for commits from other repos so if you wanna help just reply!

Hey it's me again. Shop is disabled for some reason.
I am willing to contribute to re-enabling it but since Node is not my language of choice the fix will be just the quickest, dirtiest one I can think of.

I'll examine the issue

const { GenericCommand } = require('../../models/')
module.exports = new GenericCommand(
  async ({ Memer, msg, addCD }) => {
    return 'The shop will be available in an update coming very soon... Better save your coins!'
  },
  {
    triggers: ['shop'],
    cooldown: 1000,
    donorBlocked: true,
    description: 'Shop for some dank items and upgrades!'
  }
)

Either try turning donorBlocked to false or set yourself as donor but it will just send ''The shop will be available in an update coming very soon... Better save your coins!''
As mentioned before this is an older version and not the latest version.

const { GenericCommand } = require('../../models/')
module.exports = new GenericCommand(
  async ({ Memer, msg, addCD }) => {
    return 'The shop will be available in an update coming very soon... Better save your coins!'
  },
  {
    triggers: ['shop'],
    cooldown: 1000,
    donorBlocked: true,
    description: 'Shop for some dank items and upgrades!'
  }
)

Either try turning donorBlocked to false or set yourself as donor but it will just send ''The shop will be available in an update coming very soon... Better save your coins!'' As mentioned before this is an older version and not the latest version.

i'll see what I can do to fix this - Closing for now


Makes the nuclear operative hardsuit descriptions a little more consistent

About the PR
Updates the blood-red and elite blood-red hardsuit's descriptions to reflect that of /tg/'s. Also changes the commander's hardsuit description to fit in more.
Because of this, they're also more consistent between the helmet and hardsuit.
Also shuffles around the position of the jugg suit in the yaml file to make more sense.
Why / Balance
The descriptions on the helmet / hardsuits were riddled with a lot of minor inconsistencies, which was the main goal of this PR. That aside, though, having more mentions of the various syndicate corporations like this is probably a good thing - I often see people assume that the syndicate is just Cybersun since that's the only real branded item in the regular uplink.
Also, the commander hardsuit description was just kind of weird and barebones. Not much to say there.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
not notable enough for CL, probably

ERT suits have the same description as the syndie suits by the way

Thank you. In the future, reducing unnecessary moves or splitting them into a separate commit makes these types of changes easier to review.


Assert build and unit test sessions have been run

A CI/CD session should not be validated when no build nor unit test have been run.
This unexpected event may occur when the build system is broken, or some script failed to execute.

LGTM


Vagrant tests should depend on build and actually test the docker image being built.

Should we include building hadoop base image?
test pipeline sequence will be like:
build base image ~> build hive image ~> test hive image

Coupled with #25

TODO:

[ ] resolve #25
[ ] build docker image with github-actions
[ ] make docker image available on next github-actions step
[ ] render new image tag for nomad_job using terraform template_file
[ ] run terraform and test against docker container


[feat] update the list data automatically

Thank you very much for making this amazing ranking, the current ranking data is still in 2021, can the data be automatically updated? The time span may be a month or a quarter~

It is currently updated to 2024.
Automatic updates via GitHub Action will be added later.


add example data files for recent updates esp. enums

Closing this due to lack of specificity.  If we need specific Enums added to example files, let's reopen with some specific details.  Otherwise this isn't actionable.


Delete / mark as broken image from task

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Context
Sometimes I want to delete few images from created task (they are low quality or contains too many objects / whatever reason).
Currently there is no possible solution for this.
Many other tools provides this feature or 'broken image' flag instead.
Current process:

export whole dataset
find & delete image with related annotation
re-upload dataset

@Ursanon , probably it can be supported exactly as a flag. Internally we will have all images but don't show them by default in UI. The flag has to be stored in DB (e.g. inside image info table).

Dear Contributors,
I just want to emphazise the necessity of this feature. Following new EU regulations, hosts must ensure that hosted images do not endorse violence. This might be the case in many datasets for certain images, e.g. in the widerface dataset, which contains army imagery (including some brutal scenes). Right now when detecting such an image in our cvat, I have to manually download the task, delete the image from the hdd and the annotations and re-upload the task. Then I have to adapt our scripts to the new task ID, which is a time-consuming work. Having a delete-button would make my life much easier!
Cheers!

hi @dnns92 , thanks for the comment. The feature is mostly ready: https://github.com/openvinotoolkit/cvat/pull/4194. We will merge it as soon as it will be possible. Sorry for the bad experience.

Hi guys, @kbegiedza @dnns92
The feature has been finished and implemented in our CVAT fork, here: https://github.com/cvat-ai/cvat


path-reducer

I've developed this path-reducer which makes easy to save the form values inside redux state.
Please, let me know your opinion. Also some examples on how to implement it with tcomb-form and tcomb-form-native are coming in the future.

Hi @miqmago,
Personally I like to decouple actions from state changes. Actions should just describe what happened, not what to do. So instead of:
const action = {
    type: 'updateElementInObject',
    meta: ['bar', 'boo'],
    payload: {
        boo: 1
    }
};

I'd choose something like:
const action = {
    type: 'update_requested',
    payload: {
        boo: 1
    }
};

This comment of @slorber (as lot of other comments of the same author) explains perfectly my thoughts: https://github.com/reactjs/redux/issues/1528#issuecomment-216012453

Thanks. In that case, maybe there is a better option for this problem. I'm sorry for extending so much, but the problem is not easy and I very appreciate your help:
I've got an structure with about +150 nested types (t.struct(t.struct(t.struct(...)))). In fact this is structured with import small files, each one defining a type and the options for the form presentation:
PartiesType.js
import t from 'tcomb-form-native';
import { getBusinessType, getBusinessTypeOptions } from './BusinessType';

export function getPartiesType(options) {
    const PartiesTypeBase = {
        SellerParty: getBusinessType(options),
        BuyerParty: getBusinessType(options),
    };

    return t.struct(PartiesTypeBase);
}

export function getPartiesTypeOptions(options) {
    return { fields: {} };
}

BusinessType.js
import t from 'tcomb-form-native';
import {
    getAdministrativeCentresType,
    getAdministrativeCentresTypeOptions,
    getIndividualType,
    getIndividualTypeOptions,
    getLegalEntityType,
    getLegalEntityTypeOptions,
    getPartyIdentificationType,
    getPartyIdentificationTypeOptions,
    getTaxIdentificationType,
    getTaxIdentificationTypeOptions,
} from '../reused-simple-enums';

export function getBusinessType(options) {
    const { personTypeCode = 'I' } = options;
    const BusinessTypeBase = {
        TaxIdentification: getTaxIdentificationType(options),
        PartyIdentification: getPartyIdentificationType(options),
        AdministrativeCentres: getAdministrativeCentresType(options),
        Individual: {},
        LegalEntity: {},
    };

    if (personTypeCode === 'J') {
        BusinessTypeBase.LegalEntity = getLegalEntityType(options);
        delete BusinessTypeBase.Individual;
    } else { // 'I' per defecte
        BusinessTypeBase.Individual = getIndividualType(options);
        delete BusinessTypeBase.LegalEntity;
    }
    return t.struct(BusinessTypeBase);
}

export function getBusinessTypeOptions(options) {
    return {
        auto: 'placeholders',
        fields: {
            TaxIdentification: getTaxIdentificationTypeOptions(options),
            PartyIdentification: getPartyIdentificationTypeOptions(options),
            AdministrativeCentres: getAdministrativeCentresTypeOptions(options),
            Individual: getIndividualTypeOptions(options),
            LegalEntity: getLegalEntityTypeOptions(options),
        },
    };
}

And so on. This structure makes easy to create the corresponding t.form.Form to ask the whole tree or part of it.

Personally I like to decouple actions from state changes

Does that mean that every change in a tcomb-form should be mapped to an specific action for the specific part of the tree that is being updated? I.e:
action = {
    type: 'update/Parties/SellerParty/TaxIdentification/PersonTypeCode',
    payload: {
        PersonTypeCode: 'J'
    }
};

Anyway this is a different way to let the action know what it has to be done. The difference is that it's difficult to operate with type, comparing with operate directly with an array in meta:
action = {
    type: 'updateEInvoice',
    meta: ['Parties', 'SellerParty', 'TaxIdentification', 'PersontTypeCode'],
    payload: {
        PersonTypeCode: 'J'
    }

Ths action is very easy to construct with the onChange method in t.form.Form, which already comes with the updated path.
Also does it mean that the whole structure should be duplicated with reducer functions, mapping the state? I personally think that it makes hard to maintain: every change made in tcomb type should be changed also in the state reducers.... Doesn't it make sense to move the knowledge of the tree to the action via meta path to the updated part of the tree?
This was the motivation when writting path-reducer: to not duplicate the tcomb structure with reducer's and actions structure...

I see, makes sense. So it's a matter of taste I guess. I just prefer:
const action = {
    type: 'form_changed',
    payload: {
      what: ['bar', 'boo']
      value: 1
    }
}

but the result will be the same as yours.
Maybe I just can't see the use case and it's a dumb question, but out of curiosity, why are you interesting in such granular updates rather than storing the whole form value?
const action = {
    type: 'form_changed',
    payload: {
      ...whole form value here...
    }
}

Also, values coming from the onChange handler are not validated.

I like your proposal, I will try to update the plugin. It makes sense to keep all data in payload and maybe it's better for action validation purposes.
I'm interested in granular updates as the tcomb-native-form gives the exact path which is being updated, so I found this was the only option. Regarding the validation problem, what I'm trying to do is creating a new object with the whole data and validate it at the end.
The problem here is that due it is a big form, I had to split it in small forms that are being filled each one in a tab screen. The whole form is not submitted until all the screens are filled in. I still haven't dedicated enought time to think deep about the validation problem...

Closing for inactivity


Use https protocol for demo site

The domain supports https, and there's no reason not to use it.

Yes there is: configuring the Recorder for https requires extra steps because of the certificate verification. This is something we will revisit once we have a browser plugin recorder.

Ah, got it. Thanks for clarifying!


Issue 10 add prop documentation

What:

This PR adds documentation of the props of components that didn't have it defined before. We are using the PropsTable component for the same

Why:

Closes #10

How:

Create a <component>PropTable.tsx file to define the props according to the PropsTable API
Import it in the component doc file

Media:
The documentation for Textarea looks as shown below:

Checklist:

[x] Ready to be merged

I see that some files appear as changes introduced in this PR when they should already be in master, is this up to date? Could you double check?

@martimalek the issue is that the default merge strategy is to squash. So the commit histories of both look different, that's why they show up on the PR. As you mentioned those changes are already on master


Remove hard-coded http:// and ws:// in shared.js, replace with dynamic and relative values

Closes #156
Description
Remove hard-coded http:// and ws:// in shared.js, replace with dynamic and relative values
Type of Pull Request

[ ] Adding a feature
[x] Fixing a bug
[ ] Maintaining documents
[ ] Others ()

Verify the followings

[x] Code is up-to-date with the main branch
[x] No build errors after npm run build
[x] No lint errors after npm run lint
[x] No errors on using charites help globally
[x] Make sure all the existing features working well
[ ] Have you added at least one unit test if you are going to add new feature?
[ ] Have you updated documentation?

CI build failures seem unrelated.


Text Box updates

Is your feature request related to a problem? Please describe.
As of now, the text shown is sort of static. As in there is no way to change the font family, no way to update background colour, no option to change the shape of the text background shape.
Describe the solution you'd like

Add a colour picker to chose and update the background of the text. (Possible additions for options to chose a gradient - just like Figma, linear, radial, etc)
A drop down to choose a selected few font families for the text. No need for separate ones for name and guild, a common would do the job.
The design team could come up with a few shapes as background. So a carousel of shapes to choose from for the text box would be great.

Interested


Suggestion: Option to not check inside of strings

First, thanks for creating this plugin. I think it will be quite helpful to the JavaScript community.
I'd like to suggest adding an option to not search inside of strings. Frequently, the content of strings cannot be changed without changing the meaning of the text inside the strings. For example, if I'm running execSync("git fetch origin/master"), I can't actually change the use of "master" until the Git repository is updated.
I'd suggest that the rule not search inside of strings by default and then allow people to turn this ability on with an option.
Thanks again.

Sorry, just seeing this. Busy times.
I am torn on this one. I'd say it's in general rare that these kinds of strings exist (just in comparison to what's else in a code base). And for those cases it could be simply disabled for the line - on purpose by the developer.

Sorry, just seeing this. Busy times.
I am torn on this one. I'd say it's in general rare that these kinds of strings exist (just in comparison to what's else in a code base). And for those cases it could be simply disabled for the line - on purpose by the developer.

Yes, one-off disabling was created for such instances. In my case, though, this wasn’t just a one-off occurrence, and because I don’t want to litter my code with disable comments my only choice is to disable the entire rule. Rules get used more when there are some basic options that let people opt-out of some cases.
Up to you, of course, just speaking from experience.

Yes, one-off disabling was created for such instances. In my case, though, this wasn’t just a one-off occurrence, and because I don’t want to litter my code with disable comments my only choice is to disable the entire rule. Rules get used more when there are some basic options that let people opt-out of some cases.
Up to you, of course, just speaking from experience.

Point well made. Thanks for raising it.
I'd put it down as an enhancement in the next iteration to allow disabling text occurrences, but would leave the default on "on".

Point well made. Thanks for raising it.
I'd put it down as an enhancement in the next iteration to allow disabling text occurrences, but would leave the default on "on".

Just released v2.1.0 that switched string value linting to opt-in.


Site Provisioned without XML

We recently deployed a new instance of TEOC, and after distribution and adding the application to one of our Teams, I see that none of the data / lists were provisioned as part of the EOCSiteTemplate.XML.  There are no lists populated on the Site, so any paths referencing a list return a path not found.  Is is possible to provision the missing data without creating a new instance on a different site?

@asdraper27 , Thank you for reporting this.
Yes, you can run the provision script if you are not able to find any lists, while running the PS script make sure to provide the full path for xml as shown in the screenshot below and as mentioned in the wiki -

Invoke-PnPSiteTemplate is looking for the xml file.
Can you please provide xml file path as mentioned and let us know if it is working for you?

I provided the path the first time I ran the script, but it is possible that I mistyped something.  Now when I run the script, it states the site exists and exits from the script.
Adam Draper
Lead Infrastructure Technician
Will County ICT Department
(815) 774-7466
@.***

From: v-ajaysahu @.>
Sent: Wednesday, March 27, 2024 4:14 AM
To: OfficeDev/microsoft-teams-emergency-operations-center @.>
Cc: Adam Draper @.>; Mention @.>
Subject: [EXTERNAL] Re: [OfficeDev/microsoft-teams-emergency-operations-center] Site Provisioned without XML (Issue #184)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
CAUTION:This email originated from outside your organization. Exercise caution when opening attachments or clicking links, especially from unknown senders.

@asdraper27https://github.com/asdraper27 , Thank you for reporting this.
Yes, you can run the provision script if you are not able to find any lists, while running the PS script make sure to provide the full path for xml as shown in the screenshot below and as mentioned in the wiki -
image.png (view on web)https://github.com/OfficeDev/microsoft-teams-emergency-operations-center/assets/154988719/f049b419-cca7-44da-a9af-61464b78d492
Invoke-PnPSiteTemplate is looking for the xml file.
Can you please provide xml file path as mentioned and let us know if it is working for you?
—
Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/microsoft-teams-emergency-operations-center/issues/184#issuecomment-2022276168, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BHLND6O2V4ADATZ3AP6LBJTY2KEZFAVCNFSM6AAAAABFJPI36CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRSGI3TMMJWHA.
You are receiving this because you were mentioned.Message ID: @.***>

@asdraper27 ,
Kindly note-down the site URL, delete the site from Admin Center from both Active and Deleted sites. Then, you need to wait for at least 30 minutes and try to re-run the script with the same Site Name.


Add a unittest to check the license.md file date range

The LICENSE file is read and checked if the end year is current year or not.
Closes #563

Hello @lvarayut,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Feat: add FatFs and SpiSD component, and a demo with RTC

I need to address the license issue before adding FatFs. For the time being I will close this PR, please re-submit it when everything is ready.


Reporting backend infrastructure

We want to be able to automatically produce data derived from existing data, for reporting.
An example are KPIs, but often it's data which is used to better explain to users what happened in the past.
These reports should be triggerable by a CLI command, so we can periodically create and persist reporting data.
Work on this issue will add the CLI command and four generic report functions will be added, which can build many straightforward formulas.
Furthermore, we can lay the foundation for a function store for FlexMeausures and plugins to use.
Outcomes:

A new CLI command to run an existing report function: flexmeasures add report --name <str> [--input-sensors <Union[List[int], Dict[str, int]]] --output-sensor <int> [--preferred-unit <str>] [--last-hour <bool>] [--yesterday <bool>] [last-week <bool>] [last-month <bool>]  Note: Many arguments are optional, because (a) only one time range identifier is needed and (b) custom reports will often decide sensor and units themselves.
A function store for reporting functions, which we'll keep in app.config["func_store"]["reports"]. Functions are loaded with the util logic we've just developed for #9. Also provide a utility function register_function_in_store(app: Flask, name: str, func: Callable, store: str).
Four simple implementations, inspired by earlier work we did in our E-mission plugin. These are registered when FlexMeasures starts up. One is add_andor_multiply (from E-mission), the others add_andor_divide, subtract_andor_multiply and subtract_andor_divide.
Documentation for plugins how they can add their own reporting functions (by writing a function adhering to the signature we impose and adding it to __functions__.py) under REPORTS, a list (we could also enable to use SCHEDULERS, actually, a dict).

Potentially we can keep the function store out of this, but it might be necessary in #9 anyways.

Should this become a project with sub-tickets? (then we can also link it on the roadmap)

Closing in favour of project 19.


Discuss: Add member and collection macros to actions?

I would like to encourage RESTful routes, but sometimes this is useful. Maybe these macros should be added? This decision doesn't need to be made now since people that want to do this can still use the get/put/post/delete macros to do non RESTful routes.
class Files::Archive < BaseAction
  # Same as "files/:id/archive"
  member do
    archive_the_file
  end
end

Whatever the method for having non-RESTful routes, I think they shouldn't become 'second class'. As long as they're as useful as "normal" RESTful routes, any solution will do.
On a side note, what made you not want to have a router?

get/post/put/delete work for non-RESTful routes. That might be enough for people. Since most routes can be RESTful. But I'm unsure. Might be something we need to experiment with.
There were a few reasons for not going with a router

I hate working with path helpers. It's always a pain to remember the naming conventions
I wanted type safe params in actions/controllers.
If it can be inferred from the class then it's just one less thing to write
Part of the reason for using one class per action was to get type safe params, which also led to not having a router

More explanation:
1. Path helpers
Stuff like this
resources :users do
  resources :tasks
end

new_users_tasks_path # or whatever it is, isn't that intuitive to me.

It's also kind of hard to do since you can't create a module inside a of another class or module with macros. There are workarounds, but it's a bit wonky.
Instead I can generate the self.route/path helpers on the class itself which IMO is really easy to remember and work with.
2. Type safe params in controller/actions
I wanted to have type safe params
class Users::Show < BaseAction
  action do
    UserQuery.new.find(id) # I like that I *know* id is a param that I can get at. It's even nicer when dealing with nested actions.
  end
end

I couldn't figure out a way to do this with a separate route definition. And even if I could I kind of like that it's done right there in the controller
3. If it can be inferred from the class then it's just one less thing to write
Pretty self-explanatory. It's nice to not even have to write the route at all IMO.
4. Part of the reason for using one class per action was to get type safe params, which also led to not having a router
Also pretty self-explanatory. The other reason is that now we can do cool stuff like described in #105

One thing I'd urge you to consider: there's weight to supporting edge-cases and options you (and likely others) won't run into often. My experience with Rails and other web frameworks is routing to REST is 98%+ of what both I do, and what I see on client projects.
Having worked on Factory Girl over a number of years, I think my biggest regret is supporting features I had a hard time understanding need for. I'd encourage you to think about whether you think this is necessary, and if not, promote that opinion and provide examples so others are aware of what's possible with REST.

@joshuaclayton are you advocating for non-RESTful routes to not even by supported?

@sardaukar perhaps! My experience with apps I write, and apps I see, is that they're not used, or when they're used, it's done so incorrectly. I think it's worth considering omitting them, at least for now, and gathering feedback as to whether they're absolutely necessary.

Transferred from Slack:

I will for sure support non-RESTful routes. It’s already there and sometimes you need pretty URLs for stuff. Like /my-fancy-landing-page or something like /sign_in

So I think the real discussion is whether to add the more non-RESTful stuff like member/collection since vanity URLs and SEO optimized URLs are sometimes necessary

@paulcsmith some thoughts on the params.
I think it would be nice to be able to explicitly define the params that should be available to the action.
param id : String
The macro can then define a getter with the correct type. Taking it a little further, maybe add validation.
WDYT?

@eliasjpr Right now the params and the getter for the params are automatically generated from the path name. http://luckyframework.org/guides/actions-and-routing.html#path-parameters
The downside for now is that they are always strings, but in practice that is usually fine since LuckyRecord casts the params for you.
I do want to make it so that you can use different types though. I think it would look like this:
get "/posts/:slug", slug: Slug do
end

# You'd then have a Slug type that can cast the string param
class Slug
  def self.cast(param : String) : Int32
    # Just return the id part of the slug. E.g. "123-my-cool-title" returns 123
  end
end

Does that make sense?

Chatted with @eliasjpr in Gitter:

I would say “Don’t add it now and wait for a demand"
you will notice that people will start asking which will hint you
https://gitter.im/luckyframework/Lobby?at=59f12a1181cd9a5d7e9fbea0

I think this is a good point. So I'll close this for now and re-open later if people want it and have reasonable use cases.


400 error

What happened?
400 This model's maximum context length is 65536 tokens. However, you requested 294899 tokens (294899 in the messages, 0 in the completion). Please reduce the length of the messages or completion.
this happens with deepseek, is there any way to improve or add caching feature so that cline wouldn't all the time the whole data context at least at once, maybe a context steaming approach desirable
Steps to reproduce

if the project gets bigger
Relevant API REQUEST output
No response
Operating System
windows 11
Cline Version
3
Additional context
No response

same issue

same issue, also using deepseek

same

I think it's fixed, thanks for such fast action!

i got the same error , do you do anything to get fixed ?

I think it's fixed, thanks for such fast action!


Cleanup and rspec upgrade

Coverage increased (+0.6%) to 93.329% when pulling 10bd05a040f9f58fda31530575c471b3b79650a0 on careo:cleanup-and-rspec-upgrade into 7dfc0810bf0893ec0878ae4938ad8419ac4af481 on rightscale:master.

LGTM


Upgrade Nebula Netflix OSS Project Plugin

Coverage increased (+0.03%) to 91.638% when pulling 1399717d9137824e34fcb89d96e06e5c724a4d86 on mprimi:master into 33b55366d5462ec100465e956cb3412a886e3d86 on Netflix:master.


Simple widget to show scroll progress

隨便做了一個醜醜的 indicator 試試。

Codecov Report

Merging #329 into master will not impact coverage.

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   85.02%   85.02%
=======================================
  Files          58       58
  Lines        1883     1883
=======================================
  Hits         1601     1601
  Misses        282      282

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429b8ba...063af92. Read the comment docs.

有沒有讚可以按，太優了 ！


ManyWriteAheadLogsIT is flakey

While attempting to tune the timing of many of our ITs, I found that ManyWriteAheadLogsIT occassionally fails with an assertion error:
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 21.762 s <<< FAILURE! - in org.apache.accumulo.test.functional.ManyWriteAheadLogsIT
[ERROR] testMany(org.apache.accumulo.test.functional.ManyWriteAheadLogsIT)  Time elapsed: 21.538 s  <<< FAILURE!
java.lang.AssertionError: Open WALs not in expected range 0
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.apache.accumulo.test.functional.ManyWriteAheadLogsIT.addOpenWals(ManyWriteAheadLogsIT.java:167)
	at org.apache.accumulo.test.functional.ManyWriteAheadLogsIT.testMany(ManyWriteAheadLogsIT.java:140)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:834)

This occurs on the 1.9 branch, at the very least, but probably also affects the master/2.1 branch.

This test is passing for me in master branch.

I am having trouble reproducing this error, both on 1.9 and on the master branch. What command did you use to run this IT or did you run the entire suite of IT's when running into this bug?

@Manno15 I was running the entire suite in Jenkins, but to reproduce, I would probably repeatedly run something like: mvn clean verify -Dtest=blah -Dit.test=ManyWriteAheadLogsIT -Dspotbugs.skip -Dcheckstyle.skip; the assertion error on the 1.9 branch was particularly concerning to me, since it was more than a simple timeout.

@ctubbsii That's how I am running it. Still not hitting the error. Interesting.

It might be rare. We could close it as not reproducible, but I'd feel a bit more comfortable if we had an explanation for how the above error could occur.

I will take a deeper investigation into the IT.

@ctubbsii ,  I have run this test inside of IntelliJ IDE on repeat mode for 30 times and have not seen the test fail in the way you show up above.  Maybe allowing the number of open WALs to be 0 is what you want to do.  That way the assertTrue on line 212 in addOpenWals in ManyWriteAheadLogsIT.java won't throw an assertion error:
assertTrue("Open WALs not in expected range " + open, open > 0 && open < 4);

changed to:
assertTrue("Open WALs not in expected range " + open, open >= 0 && open < 4);

I ran the following to try to reproduce, expecting it to take some time:
while mvn clean verify -Dtest=blah -Dit.test=ManyWriteAheadLogsIT -Dspotbugs.skip -Dcheckstyle.skip; do echo Test passed...; done

It failed on the first attempt with:
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 17.589 s <<< FAILURE! - in org.apache.accumulo.test.functional.ManyWriteAheadLogsIT
[ERROR] testMany(org.apache.accumulo.test.functional.ManyWriteAheadLogsIT)  Time elapsed: 17.354 s  <<< FAILURE!
java.lang.AssertionError: Open WALs not in expected range 0
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.apache.accumulo.test.functional.ManyWriteAheadLogsIT.addOpenWals(ManyWriteAheadLogsIT.java:167)
	at org.apache.accumulo.test.functional.ManyWriteAheadLogsIT.testMany(ManyWriteAheadLogsIT.java:140)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:834)

It is possible that @jzgithub1 's suggestion to include 0 as a possible value in the test will "fix" the test, but without investigating further, I suspect, doing so would merely circumvent the test case the IT is looking for.

@ctubbsii ,  I tried to force the situation of more WALs being open by reducing the TSERV_WALOG_MAX_SIZE to 850K but that caused the test to fail.  Raising it to 2M caused failure also.  I have reached the point of diminishing returns working on this issue and I really only have the the idea I posted above.  I will disengage from this issue for the time being.  Let me know if you would like me to re-engage this issue.

@ctubbsii ,  the addOpenWals function ( where that assert statement exists)  is called on lines 140 and 183.  You are observing it fail on line 140 from the call stack above.  At that point in the test neither of the two BatchWriters have been flushed to at all.  On my system there are two open WALs after the addOpenWals function on line 140 (I would have thought there would be zero at that point).  If you were asserting on the addOpenWals call on line 183 (after data was flushed) I would be more concerned.
In any case, the intent of this test in explained in the issue #854 which was the reason the test was made.  My understanding of #854 is that the intent of this test is to demonstrate that if a " tablet server   has more than 5 write ahead logs then it should probably minor compact/flush any tablet referencing the WALs created before the 5th one. These tablets themselves may have less than 5 write ahead logs".  Less than five means that zero might be OK.  @keith-turner what do you think about allowing the open WALs to be equal zero?

The original issue that this IT was added, may still exist in 1.9.  https://github.com/apache/accumulo/issues/1336


Fix runtime error from split barrier

When enabling split barrier, RuntimeError: Triton Error [ZE]: 0x78000018.
4 in !spirv.Source = !{!1} !1 = !{i32 4, i32 100000} corresponds to OpenCL C++,
so OpenCL C builtins e.g., _Z29intel_work_group_barrier_waitii is not translated to SPIRV builtins,
which causes IGC to not recognize the split barrier builtins and not lowered them to GenISA.
Change device library module metadata from
!spirv.Source = !{!1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1}
!1 = !{i32 4, i32 100000}

to
!spirv.Source = !{!1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1, !1}
!1 = !{i32 3, i32 100000}

Note: 4 in !spirv.Source = !{!1} !1 = !{i32 3, i32 100000} corresponds to OpenCL C.

Will measure the performance impact before merging in the PR.

Will measure the performance impact before merging the PR.

Enabling split barrier doesn't give performance improvement in geomean for different problem sizes of GEMM,
so we are not going to enable split barrier in this PR.


Error:(42, 66) error: cannot find symbol variable skip

in MyIntro.java i got this error:
Error:(42, 66) error: cannot find symbol variable skip
the code is:
@Override
public void onSkipPressed() {
    loadMainActivity();
    Toast.makeText(getApplicationContext(),getString(R.string.skip), Toast.LENGTH_SHORT).show();
}

line:
Toast.makeText(getApplicationContext(),getString(R.string.skip),
what's the problem?

Maybe you imported wrong R file !

Already fixed thanks


odo logs too slow for non-local clusters

What versions of software are you using?
Operating System: all
Output of odo version: main
How did you run odo exactly?
odo logs against a cluster that's not minikube/CRC. For example, one spun up using ClusterBot
Actual behavior
Takes many seconds to show the logs
Expected behavior
Take lesser time
Any logs, error output, etc.?
Originally discussed at https://github.com/redhat-developer/odo/pull/5846#issuecomment-1164423486.
/kind bug
/area log

Expected behavior
Take lesser time

To ensure we won't have regressions in the future, I think it could be great to include some kind of performance testing for this, with an acceptable threshold for what we mean by "lesser time". Relates to #5830, but for odo logs.

Self-note:

Look at client-go caching mentioned by Tomas
By threshold, Armel referred to how long odo should wait till odo logs exits if it doesn't get a response it's looking for.

Tasks pending on this issue:

Address odo logs --follow issue explained in https://github.com/redhat-developer/odo/pull/5942#issuecomment-1187685258.
In a further PR, modify the code to first fetch the resources most likely to have Pods of interest for odo. This would include Deployments, ReplicaSets and Pods itself. Check other resources after that.
Use channels instead of sharing a slice+mutex in the go routines, as is the case here: https://github.com/redhat-developer/odo/blob/e7588e33ef412177cf050efe68fc2af0e16ac79b/pkg/kclient/all.go#L29-L57
Anything else that we might be able to think of while working on the above.

We have discussed adding tests that would help us track the performance of odo logs so that we can know if it slows down in the future. This is to avoid regression, or at least finding it ourselves before it becomes a problem for the users. I prefer it be done in a separate issue than this.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v5.15.22",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=70caa32e6d81f45f0702070c0e4dfe945e92fbd7"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "70caa32e6d81f45f0702070c0e4dfe945e92fbd7",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "selinux: fix double free of cond_list on error paths\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.22 by commit 70caa32e6d81f45f0702070c0e4dfe945e92fbd7. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000279