All grouped dependencies not updated

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
npm
Package manager version
10.0.0
Language version
18.17.1
Manifest location and content before the Dependabot update
package.json
{
  "name": "aws-cdk-dependabot",
  "version": "0.1.0",
  "bin": {
    "aws-cdk-dependabot": "bin/aws-cdk-dependabot.js"
  },
  "scripts": {
    "build": "tsc",
  },
  "devDependencies": {
    "@types/jest": "^29.5.5",
    "@types/node": "20.6.3",
    "aws-cdk": "2.99.1",
    "jest": "^29.7.0",
    "ts-jest": "^29.1.1",
    "ts-node": "^10.9.1",
    "typescript": "~5.2.2"
  },
  "dependencies": {
    "@aws-cdk/aws-apigatewayv2-alpha": "2.99.1-alpha.0",
    "@aws-cdk/aws-apigatewayv2-integrations-alpha": "2.99.1-alpha.0",
    "aws-cdk-lib": "2.99.1",
    "constructs": "10.0.0",
    "source-map-support": "0.5.21"
  }
}

dependabot.yml content
version: 2
updates:
  - package-ecosystem: "npm"
    directory: "/"
    schedule:
      interval: "weekly"
      day: "monday"
      time: "06:00"
      timezone: "Europe/Helsinki"
    groups:
      aws-cdk:
        patterns:
          - "aws-cdk"
          - "aws-cdk-lib"
          - "constructs"
          - "@aws-cdk/aws-apigatewayv2-alpha"
          - "@aws-cdk/aws-apigatewayv2-integrations-alpha"

Updated dependency
Updated correctly:

aws-cdk from 2.99.1 to 2.100.0
aws-cdk-lib from 2.99.1 to 2.100.0
constructs from 10.0.0 to 10.3.0

Not updated:

@aws-cdk/aws-apigatewayv2-alpha from 2.99.1-alpha.0 to 2.100.1-alpha.0
@aws-cdk/aws-apigatewayv2-integrations-alpha from 2.99.1-alpha.0 to 2.100.1-alpha.0

What you expected to see, versus what you actually saw
Some packages in the aws-cdk group were correctly updated, but two packages were not:

@aws-cdk/aws-apigatewayv2-alpha
@aws-cdk/aws-apigatewayv2-integrations-alpha

Dependabot log shows that it correctly checked if these packages have updates available. Both of them have a newer version (2.100.1-alpha.0) available, but Dependabot still consider the old version as latest:
updater | 2023/10/09 03:18:59 INFO <job_732254050> Starting update group for 'aws-cdk'
updater | 2023/10/09 03:18:59 INFO <job_732254050> Checking if @aws-cdk/aws-apigatewayv2-alpha 2.99.1-alpha.0 needs updating
  proxy | 2023/10/09 03:18:59 [014] GET https://registry.npmjs.org:443/@aws-cdk%2Faws-apigatewayv2-alpha
  proxy | 2023/10/09 03:18:59 [014] 200 https://registry.npmjs.org:443/@aws-cdk%2Faws-apigatewayv2-alpha
  proxy | 2023/10/09 03:19:00 [016] GET<EMAIL_ADDRESS>  proxy | 2023/10/09 03:19:00 [016] 200<EMAIL_ADDRESS>updater | 2023/10/09 03:19:00 INFO <job_732254050> Latest version is 2.99.1-alpha.0
updater | 2023/10/09 03:19:00 INFO <job_732254050> No update needed for @aws-cdk/aws-apigatewayv2-alpha 2.99.1-alpha.0
updater | 2023/10/09 03:19:00 INFO <job_732254050> Checking if @aws-cdk/aws-apigatewayv2-integrations-alpha 2.99.1-alpha.0 needs updating
  proxy | 2023/10/09 03:19:00 [018] GET https://registry.npmjs.org:443/@aws-cdk%2Faws-apigatewayv2-integrations-alpha
  proxy | 2023/10/09 03:19:00 [018] 200 https://registry.npmjs.org:443/@aws-cdk%2Faws-apigatewayv2-integrations-alpha
  proxy | 2023/10/09 03:19:00 [020] GET<EMAIL_ADDRESS>  proxy | 2023/10/09 03:19:00 [020] 200<EMAIL_ADDRESS>updater | 2023/10/09 03:19:00 INFO <job_732254050> Latest version is 2.99.1-alpha.0
updater | 2023/10/09 03:19:00 INFO <job_732254050> No update needed for @aws-cdk/aws-apigatewayv2-integrations-alpha 2.99.1-alpha.0

Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
https://github.com/nicou/aws-cdk-dependabot/pull/2
Smallest manifest that reproduces the issue
version: 2
updates:
  - package-ecosystem: "npm"
    directory: "/"
    groups:
      aws-cdk:
        patterns:
          - "aws-cdk"
          - "aws-cdk-lib"
          - "@aws-cdk/aws-apigatewayv2-alpha"
          - "@aws-cdk/aws-apigatewayv2-integrations-alpha"

I think the reason for this behavior is this line:
https://github.com/dependabot/dependabot-core/blob/b7bd33be0161e2a123bdcfa6b574e0999fc4964a/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/latest_version_finder.rb#L86
The intention of that line is to filter out pre-releases from the versions Dependabot will choose from, unless the pre-release is related to the current version which is also a pre-release.
That prevents Dependabot from updating a 1.0.0 dependency to a 1.0.1-alpha dependency, or if you're on a pre-release 1.0.0-pre.1 you will be offered a related pre-release 1.0.0-pre.2, but not an unrelated one like 1.0.1-pre.1. The idea there being when a pre-release version 1.0.0-pre is available there will eventually be a 1.0.0 too.
In the case of @aws-cdk/aws-apigatewayv2-alpha and @aws-cdk/aws-apigatewayv2-integrations-alpha, they ONLY release pre-releases which means Dependabot will never offer updates for them.
So I'm not sure how Dependabot could offer updates in this case, but not break existing functionality.

Thanks for the explanation @jakecoffman. Do you think there's a way to add a flag to enable pre-release versions/release candidates? Similar to https://github.com/dependabot/dependabot-core/issues/2250

closing out as the crew has shipped multiple fixes; please reopen if this still occurs

@abdulapopoola , I believe this is still happening.
Here's my dependabot.yml group:
groups:
  cdk-updates:
    applies-to: version-updates
    patterns:
      - '@aws-cdk/*'
      - 'aws-cdk'
      - 'aws-cdk-lib'
    update-types:
      - patch
      - minor
      - major

In the output, I see:
updater | 2024/08/16 18:05:41 INFO <job_870396983> Starting update group for 'cdk-updates'
updater | 2024/08/16 18:05:41 INFO <job_870396983> Updating the / directory.
updater | 2024/08/16 18:05:42 INFO <job_870396983> Checking if aws-cdk-lib 2.149.0 needs updating
  proxy | 2024/08/16 18:05:42 [019] GET [https://registry.npmjs.org:443/aws-cdk-lib](https://registry.npmjs.org/aws-cdk-lib)
  proxy | 2024/08/16 18:05:42 [019] 200 [https://registry.npmjs.org:443/aws-cdk-lib](https://registry.npmjs.org/aws-cdk-lib)
  proxy | 2024/08/16 18:05:42 [021] HEAD [https://registry.npmjs.org:443/aws-cdk-lib/-/aws-cdk-lib-2.152.0.tgz](https://registry.npmjs.org/aws-cdk-lib/-/aws-cdk-lib-2.152.0.tgz)
  proxy | 2024/08/16 18:05:43 [021] 200 [https://registry.npmjs.org:443/aws-cdk-lib/-/aws-cdk-lib-2.152.0.tgz](https://registry.npmjs.org/aws-cdk-lib/-/aws-cdk-lib-2.152.0.tgz)
updater | 2024/08/16 18:05:43 INFO <job_870396983> Latest version is 2.152.0
  proxy | 2024/08/16 18:05:47 [023] GET [https://ofcncog2cu-dsn.algolia.net:443/1/indexes/npm-search/aws-cdk-lib?x-algolia-agent=Algolia%20for%20JavaScript%20(4.22.1)%3B%20Node.js%20(20.16.0)&attributesToRetrieve=%5B%22types%22%5D](https://ofcncog2cu-dsn.algolia.net/1/indexes/npm-search/aws-cdk-lib?x-algolia-agent=Algolia%20for%20JavaScript%20(4.22.1)%3B%20Node.js%20(20.16.0)&attributesToRetrieve=%5B%22types%22%5D)
  proxy | 2024/08/16 18:05:47 [023] 200 [https://ofcncog2cu-dsn.algolia.net:443/1/indexes/npm-search/aws-cdk-lib?x-algolia-agent=Algolia%20for%20JavaScript%20(4.22.1)%3B%20Node.js%20(20.16.0)&attributesToRetrieve=%5B%22types%22%5D](https://ofcncog2cu-dsn.algolia.net/1/indexes/npm-search/aws-cdk-lib?x-algolia-agent=Algolia%20for%20JavaScript%20(4.22.1)%3B%20Node.js%20(20.16.0)&attributesToRetrieve=%5B%22types%22%5D)
  proxy | 2024/08/16 18:05:48 [025] GET [https://registry.yarnpkg.com:443/aws-cdk-lib](https://registry.yarnpkg.com/aws-cdk-lib)
  proxy | 2024/08/16 18:05:48 [025] 200 [https://registry.yarnpkg.com:443/aws-cdk-lib](https://registry.yarnpkg.com/aws-cdk-lib)
  proxy | 2024/08/16 18:05:48 [028] GET [https://registry.yarnpkg.com:443/<EMAIL_ADDRESS>  proxy | 2024/08/16 18:05:48 [029] GET [https://registry.yarnpkg.com:443/aws-cdk-lib/-/aws-cdk-lib-2.152.0.tgz](https://registry.yarnpkg.com/aws-cdk-lib/-/aws-cdk-lib-2.152.0.tgz)
  proxy | 2024/08/16 18:05:48 [028] 200 [https://registry.yarnpkg.com:443/<EMAIL_ADDRESS>  proxy | 2024/08/16 18:05:48 [029] 200 [https://registry.yarnpkg.com:443/aws-cdk-lib/-/aws-cdk-lib-2.152.0.tgz](https://registry.yarnpkg.com/aws-cdk-lib/-/aws-cdk-lib-2.152.0.tgz)
updater | 2024/08/16 18:05:52 INFO <job_870396983> Requirements to unlock own
2024/08/16 18:05:52 INFO <job_870396983> Requirements update strategy bump_versions
2024/08/16 18:05:52 INFO <job_870396983> Updating aws-cdk-lib from 2.149.0 to 2.152.0
  proxy | 2024/08/16 18:05:57 [031] GET [https://registry.yarnpkg.com:443/aws-cdk-lib](https://registry.yarnpkg.com/aws-cdk-lib)
  proxy | 2024/08/16 18:05:57 [031] 304 [https://registry.yarnpkg.com:443/aws-cdk-lib](https://registry.yarnpkg.com/aws-cdk-lib)
updater | 2024/08/16 18:05:58 INFO <job_870396983> Checking if aws-cdk 2.149.0 needs updating
  proxy | 2024/08/16 18:05:58 [033] GET [https://registry.npmjs.org:443/aws-cdk](https://registry.npmjs.org/aws-cdk)
  proxy | 2024/08/16 18:05:58 [033] 200 [https://registry.npmjs.org:443/aws-cdk](https://registry.npmjs.org/aws-cdk)
  proxy | 2024/08/16 18:05:58 [035] HEAD [https://registry.npmjs.org:443/aws-cdk/-/aws-cdk-2.152.0.tgz](https://registry.npmjs.org/aws-cdk/-/aws-cdk-2.152.0.tgz)
  proxy | 2024/08/16 18:05:59 [035] 200 [https://registry.npmjs.org:443/aws-cdk/-/aws-cdk-2.152.0.tgz](https://registry.npmjs.org/aws-cdk/-/aws-cdk-2.152.0.tgz)
updater | 2024/08/16 18:05:59 INFO <job_870396983> Latest version is 2.152.0
  proxy | 2024/08/16 18:06:03 [037] GET [https://ofcncog2cu-dsn.algolia.net:443/1/indexes/npm-search/aws-cdk?x-algolia-agent=Algolia%20for%20JavaScript%20(4.22.1)%3B%20Node.js%20(20.16.0)&attributesToRetrieve=%5B%22types%22%5D](https://ofcncog2cu-dsn.algolia.net/1/indexes/npm-search/aws-cdk?x-algolia-agent=Algolia%20for%20JavaScript%20(4.22.1)%3B%20Node.js%20(20.16.0)&attributesToRetrieve=%5B%22types%22%5D)
  proxy | 2024/08/16 18:06:03 [037] 200 [https://ofcncog2cu-dsn.algolia.net:443/1/indexes/npm-search/aws-cdk?x-algolia-agent=Algolia%20for%20JavaScript%20(4.22.1)%3B%20Node.js%20(20.16.0)&attributesToRetrieve=%5B%22types%22%5D](https://ofcncog2cu-dsn.algolia.net/1/indexes/npm-search/aws-cdk?x-algolia-agent=Algolia%20for%20JavaScript%20(4.22.1)%3B%20Node.js%20(20.16.0)&attributesToRetrieve=%5B%22types%22%5D)
  proxy | 2024/08/16 18:06:03 [039] GET [https://registry.yarnpkg.com:443/aws-cdk](https://registry.yarnpkg.com/aws-cdk)
  proxy | 2024/08/16 18:06:03 [039] 200 [https://registry.yarnpkg.com:443/aws-cdk](https://registry.yarnpkg.com/aws-cdk)
  proxy | 2024/08/16 18:06:04 [041] GET [https://registry.yarnpkg.com:443/aws-cdk/-/aws-cdk-2.152.0.tgz](https://registry.yarnpkg.com/aws-cdk/-/aws-cdk-2.152.0.tgz)
  proxy | 2024/08/16 18:06:04 [041] 200 [https://registry.yarnpkg.com:443/aws-cdk/-/aws-cdk-2.152.0.tgz](https://registry.yarnpkg.com/aws-cdk/-/aws-cdk-2.152.0.tgz)
updater | 2024/08/16 18:06:05 INFO <job_870396983> Requirements to unlock own
updater | 2024/08/16 18:06:05 INFO <job_870396983> Requirements update strategy bump_versions
updater | 2024/08/16 18:06:05 INFO <job_870396983> Updating aws-cdk from 2.149.0 to 2.152.0
  proxy | 2024/08/16 18:06:10 [043] GET [https://registry.yarnpkg.com:443/aws-cdk](https://registry.yarnpkg.com/aws-cdk)
  proxy | 2024/08/16 18:06:10 [043] 304 [https://registry.yarnpkg.com:443/aws-cdk](https://registry.yarnpkg.com/aws-cdk)
updater | 2024/08/16 18:06:11 INFO <job_870396983> Checking if @aws-cdk/aws-apigatewayv2-alpha 2.114.1-alpha.0 needs updating
  proxy | 2024/08/16 18:06:11 [045] GET [https://registry.npmjs.org:443/@aws-cdk%2Faws-apigatewayv2-alpha](https://registry.npmjs.org/@aws-cdk%2Faws-apigatewayv2-alpha)
  proxy | 2024/08/16 18:06:11 [045] 200 [https://registry.npmjs.org:443/@aws-cdk%2Faws-apigatewayv2-alpha](https://registry.npmjs.org/@aws-cdk%2Faws-apigatewayv2-alpha)
  proxy | 2024/08/16 18:06:12 [047] HEAD [https://registry.npmjs.org:443/<EMAIL_ADDRESS>  proxy | 2024/08/16 18:06:12 [047] 200 [https://registry.npmjs.org:443/<EMAIL_ADDRESS>updater | 2024/08/16 18:06:12 INFO <job_870396983> Latest version is 2.114.1-alpha.0
updater | 2024/08/16 18:06:12 INFO <job_870396983> Checking if @aws-cdk/aws-apigatewayv2-integrations-alpha 2.114.1-alpha.0 needs updating
  proxy | 2024/08/16 18:06:12 [049] GET [https://registry.npmjs.org:443/@aws-cdk%2Faws-apigatewayv2-integrations-alpha](https://registry.npmjs.org/@aws-cdk%2Faws-apigatewayv2-integrations-alpha)
  proxy | 2024/08/16 18:06:12 [049] 200 [https://registry.npmjs.org:443/@aws-cdk%2Faws-apigatewayv2-integrations-alpha](https://registry.npmjs.org/@aws-cdk%2Faws-apigatewayv2-integrations-alpha)
  proxy | 2024/08/16 18:06:13 [051] HEAD [https://registry.npmjs.org:443/<EMAIL_ADDRESS>  proxy | 2024/08/16 18:06:13 [051] 200 [https://registry.npmjs.org:443/<EMAIL_ADDRESS>updater | 2024/08/16 18:06:13 INFO <job_870396983> Latest version is 2.114.1-alpha.0
updater | 2024/08/16 18:06:13 INFO <job_870396983> Checking if @aws-cdk/aws-scheduler-alpha 2.149.0-alpha.0 needs updating
  proxy | 2024/08/16 18:06:13 [053] GET [https://registry.npmjs.org:443/@aws-cdk%2Faws-scheduler-alpha](https://registry.npmjs.org/@aws-cdk%2Faws-scheduler-alpha)
  proxy | 2024/08/16 18:06:14 [053] 200 [https://registry.npmjs.org:443/@aws-cdk%2Faws-scheduler-alpha](https://registry.npmjs.org/@aws-cdk%2Faws-scheduler-alpha)
  proxy | 2024/08/16 18:06:14 [055] HEAD [https://registry.npmjs.org:443/<EMAIL_ADDRESS>  proxy | 2024/08/16 18:06:15 [055] 200 [https://registry.npmjs.org:443/<EMAIL_ADDRESS>updater | 2024/08/16 18:06:15 INFO <job_870396983> Latest version is 2.149.0-alpha.0
updater | 2024/08/16 18:06:15 INFO <job_870396983> Checking if @aws-cdk/aws-scheduler-targets-alpha 2.149.0-alpha.0 needs updating
  proxy | 2024/08/16 18:06:15 [057] GET [https://registry.npmjs.org:443/@aws-cdk%2Faws-scheduler-targets-alpha](https://registry.npmjs.org/@aws-cdk%2Faws-scheduler-targets-alpha)
  proxy | 2024/08/16 18:06:16 [057] 200 [https://registry.npmjs.org:443/@aws-cdk%2Faws-scheduler-targets-alpha](https://registry.npmjs.org/@aws-cdk%2Faws-scheduler-targets-alpha)
  proxy | 2024/08/16 18:06:16 [059] HEAD [https://registry.npmjs.org:443/<EMAIL_ADDRESS>  proxy | 2024/08/16 18:06:16 [059] 200 [https://registry.npmjs.org:443/<EMAIL_ADDRESS>updater | 2024/08/16 18:06:16 INFO <job_870396983> Latest version is 2.149.0-alpha.0
updater | 2024/08/16 18:06:16 INFO <job_870396983> Creating a pull request for 'cdk-updates'

Since these repos are released along with aws-cdk-lib, the most current should have been 2.152.0-alpha.0, but it's incorrectly reporting that the latest version is 2.149.0-alpha.0.
Could we re-open this issue?

Sorry to hear that @blimmer , could you please file a new issue so we have fresh context to start with?

Sure, no problem. I recreated it in a public repo and filed #10458 to track the problem.


[FLINK-26093][tests] Adjust SavepointFormatITCase for ChangelogStateBackend

What is the purpose of the change
The test vaildates corrects types of state handles created by savepoint. For NATIVE savepoints, it expects IncrementalRemoteKeyedStateHandle and KeyGroupsStateHandle.
However, with changelog those will be wrapped into ChangelogStateBackendHandle and the test fails.
This change explicitly controls whether changelog is enabled or disabled and adjusts expectations accordingly.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

Thanks for the review @dawidwys !


You do not need a VPN to access this from India

Describe the bug
The README currently says that if christitus.com/win doesn't load, you would be required to use a VPN tunnel. This is not true. Simply changing the DNS server used will fix this error.
Source:

Current discussion in github's orgs.
Stackoverflow answer

To Reproduce

Change the DNS server to anything other than Jio's DNS
This link should work

Additional context
There's also a simpler workaround: Use a raw link that doesn't have raw.githubusercontent.com as the hostname. For example, this link should work. I currently do not use Jio as my ISP, so I cannot confirm this, but it worked when I used to use it as my ISP.

This issue was fixed, closing.


Interprocedural optimizations

Scope & Purpose
Enable IPO/LTO in our builds.

[X] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[X] The behavior in this PR can be (and was) manually tested

This is expected to (but these aren't verified yet):

Improve overall performance
Allow moving of inline definitions in .h files to .cpp files without performance degradation, and thus
improve compile time after many inline definitions are moved

It also allows for

More warnings like -Wodr (we do currently have ODR violations!)

Testing & Verification
This change is already covered by existing tests, such as all of them.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/5476/

Some changes first made here moved to https://github.com/arangodb/arangodb/pull/9666.

The INTERPROCEDURAL_OPTIMIZATION property is set for every executable separately to the same value (${IPO_ENABLED}). What is the case against using CMAKE_INTERPROCEDURAL_OPTIMIZATION (https://cmake.org/cmake/help/v3.9/variable/CMAKE_INTERPROCEDURAL_OPTIMIZATION.html#variable:CMAKE_INTERPROCEDURAL_OPTIMIZATION)?

 Thanks for the hint!

@ObiWahn sadly, when setting CMAKE_INTERPROCEDURAL_OPTIMIZATION, we get dozens of warnings for 3rd party libraries:
  Policy CMP0069 is not set: INTERPROCEDURAL_OPTIMIZATION is enforced when
  enabled.  Run "cmake --help-policy CMP0069" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  INTERPROCEDURAL_OPTIMIZATION property will be ignored for target 'rocksdb'.
This warning is for project developers.  Use -Wno-dev to suppress it..```

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6280/

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6281/

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6306/

The last PR run is green, considering the new Mac run.
The package builds are also okay, but for a permission problem on Mac which is unrelated.


admin statistics uptime broken

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/7604/

We need the same fix for devel.

Test blue.


pg_inspector_server cron job use credentials and host from database.yml

Currently, pg_inspector_server cron job is always dump for local database, which is bad for our debug purpose. This fix and should be merged after https://github.com/ManageIQ/manageiq/pull/16419/files is merged. I think this also need to be back ported.
\cc @jrafanie @yrudman @gtanzillo
@miq-bot add-label enhancement, tools

@miq-bot add-label enhancement, tools

@carbonin @jrafanie Please review


Correct documentation to describe what order interceptors are run in

What is changing
The current implementation of the Ruby gRPC library applies interceptors in LIFO order to the call. The documentation is being updated to make that information easily discoverable.
Why is it changing
There doesn't appear to be any easily discoverable documentation on the specifics of the interceptor implementation.
One detail that is surprising is that the server interceptors are applied to a call in the reverse order that they are specified in the array.
Whether or not this is the intent of the code it is now part of the API so should be documented / made explicit to avoid further surpised.
Re-raise of https://github.com/grpc/grpc/pull/23752 due to CLA not working.
@markdroth / @apolcyn

@nicolasnoble

🤦 hub...


Update Monitor Agent Migration Tools

Learn Build status updates of commit db77d4a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/azure-monitor/agents/azure-monitor-agent-migration-tools.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@guywi-ms
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@shayoniseth please review and approve.

#sign-off

@aenichols Thanks very much for your contribution and dedication to our documentation!


lib: os: ring_buffer: Fix not handled return value

Some function return values were not handled. Added assert in case
those functions return error. It is possible only if same ring buffer
instance is used without any protection from multiple contexts.
Fixes #10755.
Signed-off-by: Krzysztof Chruscinski<EMAIL_ADDRESS>

Codecov Report

Merging #14150 into master will increase coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master   #14150      +/-   ##
==========================================
+ Coverage   52.66%   52.67%   +0.01%
==========================================
  Files         307      307
  Lines       45478    45475       -3
  Branches    10535    10532       -3
==========================================
+ Hits        23952    23956       +4
+ Misses      16643    16640       -3
+ Partials     4883     4879       -4

Impacted Files
Coverage Δ

lib/os/ring_buffer.c
97.93% <50%> (-2.07%)
:arrow_down:

boards/posix/nrf52_bsim/argparse.c
31.32% <0%> (-15.67%)
:arrow_down:

boards/posix/nrf52_bsim/irq_handler.c
65.09% <0%> (-13.21%)
:arrow_down:

lib/os/printk.c
84.32% <0%> (ø)
:arrow_up:

subsys/net/ip/net_context.c
58.76% <0%> (+0.26%)
:arrow_up:

subsys/net/ip/tcp.c
57.47% <0%> (+1.52%)
:arrow_up:

drivers/clock_control/nrf_power_clock.c
52.1% <0%> (+2.1%)
:arrow_up:

subsys/net/lib/sockets/sockets.c
49.01% <0%> (+2.2%)
:arrow_up:

subsys/net/lib/sockets/sockets_internal.h
100% <0%> (+71.42%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90132d3...d76245b. Read the comment docs.

@ceolin ping


fix git image

/hold

The change itself looks ok.
But I would like to stress again, that this is the old chart, legacy, deprecated chart we are making changes to.

Yes we know but is the chart used to generate the template used by app-sre

/retest


Handle EKS token refresh when using this as a library

Hi there, how do you handle token refresh for deployments taking more than 15 minutes?
All I can think of is using the ExecProvider in rest.Config to invoke the aws cli, is there a way to do that with the aws sdk instead?
A couple of years ago this code used to call the factory the user provides instead that the c.getKubeClient() directly which would have allowed to inject a token refresh in between.
// IsReachable tests connectivity to the cluster.
func (c *Client) IsReachable() error {
	client, err := c.getKubeClient()
	if err == genericclioptions.ErrEmptyConfig {
		// re-replace kubernetes ErrEmptyConfig error with a friendy error
		// moar workarounds for Kubernetes API breaking.
		return errors.New("Kubernetes cluster unreachable")
	}
	if err != nil {
		return errors.Wrap(err, "Kubernetes cluster unreachable")
	}
	if _, err := client.ServerVersion(); err != nil {
		return errors.Wrap(err, "Kubernetes cluster unreachable")
	}
	return nil
}

Cheers,
Matteo

I had that problem once. I just created a serviceaccount and used it's token for authentication.

I suspect my use case needs something more flexible that this, during the pod lifespan there are multiple instances of Helm targeting different clusters in other accounts

I wonder if running your credential refresh in another window would work.
Otherwise, if you could run from an instance inside the same aws account, you could use an instance role that wouldn't expire.

One thing I could do is having a goroutine periodically overriding rest.Config which is passed by reference to the Helm configuration but this would simply be bad.
I understand that the mentioned PR change fixed an issue but that very issue could have been fixed without removing from the user the ability to implement getKubeClient() in the factory.
This change is biased towards the use case of running this as a CLI tool

I was digging through client-go. It looks like it might try to reload tokens every minute. Did you try updating the kubeconfig in the background?

I was digging through client-go. It looks like it might try to reload tokens every minute. Did you try updating the kubeconfig in the background?

Thanks, I'll try

No feedback so I'm hoping this means you were successful.


Text composables: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-text-composables?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-1-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-text-composables#7
In which task and step of the codelab can this issue be found?
Task 8, "Arrange the text elements in a row"
Describe the problem
When highlighting "Text" as instructed and bulb is clicked and text surround with row is selected, it only puts the first text composable in a row and not the second one also. But the instruction says select the two Text composables, and then the code that codelab shows isn't the same as the code that you get in Android Studio.
Versions
Android Studio version: 2022.2.1
API version of the emulator:
Additional information
Spot the difference on the attached images.
Include screenshots if they would be useful in clarifying the problem.

Hi @DeocBrut
Thank you for writing in.
I worked through this part of the lesson again and after selecting the two Text composables I was able to click on the "bulb" and surround them with a Row composable as the following steps instructed.
If you are still having an issue and have the time, please redo this portion of the lesson by removing the Row composable and trying to reselect both Text composables and then surrounding them with the Row composable.
As you are doing this, take screenshots (including the two Text composables being selected) so the team can redo your example step-by-step for troubleshooting.
Create a new GitHub issue and lease provide these screenshots, your Android Studio information, your OS information, and anything else you feel could help us resolve this issue.
Hope you are still enjoying the course!
Regards.


Display User Events List

Description
Allow user to easily find events that they're hosting or have RSVP'd to
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[x] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

 Display upcoming events to pizza eater dashboard

This component has come out very nicely. I'm looking forward to the sort-by implementation!

really smart using a controller to render the component

We will need to revisit later to deal with code climate.


benchmark test very slow

This is probably due to RTOs happening during the test.

The benchmark tests seem quite predictable now, so I guess this issue was resolved by something.

@marten-seemann
I'm using your benchmark project from github.com/marten-seemann/quic-go-benchmarks.
And It looks like the performance is terrible. Is this test result correct?
• [MEASUREMENT]
File Transfers
QUIC: transfering 100 MB of data
Ran 3 samples:
runtime:
Fastest Time: 2.586s
Slowest Time: 2.728s
Average Time: 2.660s ± 0.058s
• [MEASUREMENT]
File Transfers
TCP: transfering 100 MB of data
Ran 3 samples:
runtime:
Fastest Time: 0.102s
Slowest Time: 0.105s
Average Time: 0.103s ± 0.001s

@marten-seemann
I have the same issue as @lnykww :
• [MEASUREMENT]
File Transfers
QUIC: transfering 100 MB of data
Ran 3 samples:
runtime:
Fastest Time: 2.611s
Slowest Time: 2.740s
Average Time: 2.676s ± 0.053s
• [MEASUREMENT]
File Transfers
TCP: transfering 100 MB of data
Ran 3 samples:
runtime:
Fastest Time: 0.160s
Slowest Time: 0.204s
Average Time: 0.178s ± 0.019s
It looks like quic-go limits UDP packets to a length of 1251 bytes (according to wireshark), making it much more inefficient than TCP which uses larger packet sizes.
I also could verify it with h2quic with a ~5MB response, where the difference increases with larger response payload:
HTTPS(QUIC): Needed 147.163026 ms
HTTPS(TCP):  Needed 43.492046 ms
HTTP(TCP):   Needed 34.801348 ms

It seems the missing path MTU discovery is causing the limited packet size.
But even if I set the MaxPacketSizeIPv4 variable in internal/protocol/params.go value to 10000 bytes, it is not sending larger UDP packets than 1451bytes.
@marten-seemann Do you have any suggestions on how to increase packet size manually, so we could check if this is the performance bottleneck and I could increase it for controlled local environements?


Tagged release

Can you make a tagged release so we can use it in automated processes, e.g. build for Armbian?

@PanderMusubi I love Armbian!
https://github.com/clach04/fake_vcgencmd/releases/tag/0.0.1 created.

Thanks. See https://github.com/armbian/build/pull/5095

@clach04 what board do you have Armbian running on? On those boards, does vcgencmd work? Currently, I only have added it to the build for the Pine 64.

x86 machines
rock64 - armbian and non-armbian
odroid

Not had chance to try on Orange Pi and Potato yet.

Sorry to use this issue for this, which of the boards listed in https://github.com/armbian/build/tree/main/config/boards can I add that fake vcgencmd gets installed during the build? In other words, are you sure (tested) that it will work when I add https://github.com/armbian/build/pull/5095/commits/f2788d5a997685a8b22fd9d5cef814ab8be1f2bf ? I can provide you with custom builds to download or a simple command to build an image you can test.

@PanderMusubi I wont have access to do a test for a while BUT from memory I can confirm:

https://github.com/armbian/build/blob/main/config/boards/rock64.conf
https://github.com/armbian/build/blob/main/config/boards/odroidxu4.conf

What  can't guarantee is that the odroid one was unmodified fake_vcgencmd (there is a remote chance the thermal value paths are different).


Don't register the driver under the "postgres" name by default

To allow this forked lib/pq to be linked along the original.

LGTM


bugfix: avoid to escape html; empty base_url

Main Changes

#1322 进行 json 序列化时，避免对于 html 的特殊字符（如 &）进行转义
运行测试用例 prepareUrlParams 时，避免 base_url 为空所导致的异常

Codecov Report

Merging #1323 (ccdd95f) into master (036b063) will decrease coverage by 9.58%.
The diff coverage is 36.84%.

@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
- Coverage   58.68%   49.10%   -9.59%
==========================================
  Files          82       48      -34
  Lines        9868     6521    -3347
==========================================
- Hits         5791     3202    -2589
+ Misses       3801     3045     -756
+ Partials      276      274       -2

Flag
Coverage Δ

unittests
49.10% <36.84%> (-9.59%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

hrp/internal/builtin/utils.go
0.00% <0.00%> (ø)

hrp/internal/convert/converter_har.go
66.92% <100.00%> (ø)

hrp/step_request.go
50.00% <100.00%> (+0.83%)
:arrow_up:

httprunner/__init__.py

httprunner/step_testcase.py

httprunner/__main__.py

httprunner/step_testcase_test.py

httprunner/cli.py

httprunner/make.py

httprunner/step.py

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 036b063...ccdd95f. Read the comment docs.


Issue #164 - mapping switch proposal

Moved leaflet maps changes to a new branch - leaftlet-maps

Please ignore this pull request, I need to pull changes you had made to add the leaflet files locally.


Design a client experience for serverless

We never actually did this, it just happened. So let's review it and shore it up in 3.0.

Closing this for now, given discussions.


general: tool for code coverage report

coverage report
ci
github badget
...

Checkout codecov I have integrated it into rust ci.

Ok cool, closed as it is already integrated.


Support asynchronous validation operations to allow for server-based checks or third-party libraries

Yup would be a great example of why we would want to support async operations (namely promises) for third-party libraries.  Yup is fairly robust but unfortunately in order to validate you have to use promises.

This adds a whole layer of complexity for field-based validation when it comes to calculating the isValid property on load.  Struggling to find an appropriate solution for this particular problem.

Nevermind, got a working solution though it may not be the cleanest or most performant option.  Would love to remove the full form check loop form the render() call.


Material popup doesn't work on iPad 2017 Chrome 64

Clicking on "OPEN POPUP" button changes the button text to "CLOSE POPUP" but doesn't open popup box.
https://dart-lang.github.io/angular_components_example/#/material_popup
Device info:
ipad 2017, MODEL MPGT2HN/A
iOS version : 10.3.3
Chrome 64.0.3282.112

From an iPhone,  I can't recreate this issue on all of the popups on that page but the last one does not open.

Just tried it on my ipad with the latest version and everything seems to be working for me. A slight delay but all the popups open.


Toothpick.openScopes Lint Warning

Hi,
In kotlin, I open a scope with TP in the "init {}". Lint trigger a warning  "Leaking ‘this’ in constructor."
Is there something special to do ?
abstract class BaseViewModel(app: Application) : ViewModel() {
    init {
        // TODO fix warnings
        LogUtil.i(LOG_TAG, "base onCreated")
        val viewModelScope = Toothpick.openScopes(app, this)
        ...

Please follow up on this, we're not yet very knowledgeable on Kotlin.

@afaucogney we don't think we can do anything about this. TP3 provides automatic injection of the view model instances. Please look at smoothie-lifecycle-viewodel and its Kotlin extension.


Manage debt optimism

This Pr enables the manage debt tab for Optimism.

I walked @jmzwar  through it. The commits should be fairly easy to follow but happy to go through if anyone else wants to review.


'function' object has no attribute 'symbolic_function'

Hi, when I try to run the DQN.py inside examples/LandmarkDetection using the command:
python DQN.py --task play --algo DQN --gpu 0 --load data/models/DQN_multiscale_brain_mri_point_pc_ROI_45_45_45/model-600000 --files './data/filenames/image_files.txt'
I got the following error:

File "DQN.py", line 88, in _get_DQN_prediction
with argscope(Conv3D, nl=PReLU.symbolic_function, use_bias=True):
AttributeError: 'function' object has no attribute 'symbolic_function'

Can you help please?

I had the same error, because I was using the wrong tensorpack version. Downgrading tensorpack to version 0.9.5 solved the issue for me.

Hey @Vonisoa
As @klekass mentioned, you will need to use the same package versions as here requirments


custom icon font size

please add support for custom font size for icons

Does the symbol-font-size setting not do what you wish?
The icon will be the size of the symbol-font-size setting when just the icon and not the action label is shown, and will be the size of the label-font-size setting when both the icon and the action label is shown.

Indeed. My fault!


Fix typo in README.md

Teeny tiny typo. Added 'of' before 'Virtualization', also made 'Virtualization' lowercase.

Thanks. I think the sentence was supposed to say

This is not true virtualization...

Ah. Never mind, then.

You were right on the capitalization though. I fixed that in https://github.com/github/hoosegow/commit/9add7f7ab57333bc7e25e4aa11109928473f94b7#diff-04c6e90faac2675aa89e2176d2eec7d8. Thanks!

:)
On Tue, May 12, 2015, 9:41 AM Ben Toews<EMAIL_ADDRESS>wrote:

You were right on the capitalization though. I fixed that in 9add7f7
#diff-04c6e90faac2675aa89e2176d2eec7d8
https://github.com/github/hoosegow/commit/9add7f7ab57333bc7e25e4aa11109928473f94b7#diff-04c6e90faac2675aa89e2176d2eec7d8.
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/github/hoosegow/pull/4#issuecomment-101304574.

Oh, I get what you are saying! I understand now that you meant it was not a
pure example of virtualization.
On Tue, May 12, 2015 at 10:16 AM, Isaac Moldofsky<EMAIL_ADDRESS>
wrote:

:)
On Tue, May 12, 2015, 9:41 AM Ben Toews<EMAIL_ADDRESS>wrote:

You were right on the capitalization though. I fixed that in 9add7f7
#diff-04c6e90faac2675aa89e2176d2eec7d8
https://github.com/github/hoosegow/commit/9add7f7ab57333bc7e25e4aa11109928473f94b7#diff-04c6e90faac2675aa89e2176d2eec7d8.
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/github/hoosegow/pull/4#issuecomment-101304574.


stanza 1.4.0, add maintainer

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Notes:

includes #6
simplify recipe a bit
removes vendored LICENSE file (now included in upstream distribution)
adds self as maintainer

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge/stanza ready for review

@conda-forge/stanza will probably request this gets force-merged tomorrow

Many thanks!


Electron example: ImageData: Invalid array length

It seems to paint the first few frames OK then fails. The array length looks valid to me i.e an int less than<PHONE_NUMBER> and not negative.
Node: v10.8.0
OS: Windows 10 Pro x64
Exokit: 0.0.432
Log output:
c:\workspace\exokit>node . -l http://localhost:8080/electron.html
THREE.WebGLRenderer 95

paint 5504000
got bytelength 5504000 1600<PHONE_NUMBER>
loaded
paint 5504000
got bytelength 5504000 1600<PHONE_NUMBER>
paint 627200
got bytelength<PHONE_NUMBER> 98 627200
paint 1633320
got bytelength 1633320<PHONE_NUMBER>20
Error: ImageData: Invalid array length
    at BrowserWindow.browserWindow.on.o (http://localhost:8080/electron.html:79:30)
    at BrowserWindow.emit (events.js:182:13)
    at BrowserWindow.EventEmitter.emit (domain.js:442:20)
    at EventEmitter.messageEmitter.on.m (c:\workspace\exokit\src\electron.js:227:37)
    at EventEmitter.emit (events.js:182:13)
    at EventEmitter.emit (domain.js:442:20)
    at Client.localChannel.on.data (c:\workspace\exokit\src\electron.js:97:32)
    at Client.emit (c:\workspace\exokit\node_modules\event-pubsub\es5.js:74:21)
    at Socket.<anonymous> (c:\workspace\exokit\node_modules\node-ipc\dao\client.js:210:24)
    at Socket.emit (events.js:182:13)
    at Socket.EventEmitter.emit (domain.js:442:20)
    at addChunk (_stream_readable.js:283:12)
    at readableAddChunk (_stream_readable.js:260:13)
    at Socket.Readable.push (_stream_readable.js:219:10)
    at Pipe.onread (net.js:639:20)

Thanks! Managed to repro this by switching the url to https://facebook.com
Probably an IPC problem; investigating 👀.

I'm also seeing cases where the electron API is giving us back oversized buffers.
I'm thinking the correct behavior is for ImageData to accept these as long as they as sufficiently sized...


Update zip action to v1.1

Zip action was updated over the weekend to solve issues with Node JS 12 version. Now it is using Node JS 16. However, tag @v1 was not updated when releasing and for making use of this new version we need to add the minor version to the call. Dependabot won't update it automatically either since we are only specifying the major version.

We may need to do a new patch release =)


Change roundingPriority "significantDigits" to "auto"

I found while writing the spec that it is misleading to call the default option "significantDigits", because if minimumSignificantDigits/maximumSignificantDigits are undefined, then fraction digits are used for rounding, despite the setting on the roudingPriority option.  I think "auto" is less misleading.

2021-07-01 discussion and consensus: https://github.com/tc39/ecma402/blob/master/meetings/notes-2021-07-01.md#change-roundingpriority-significantdigits-to-auto-32


Enhancement: Correctly parsing flags with minimist and centrally validating them

We're using minimist to parse command arguments. Recently, we've been updating the way the CLI interacts with minimist, to make sure we have consistent input. We've done this around booleans (#3853) and we've started it around strings and numbers (#5396)
However, flag options also have a potential issue.
Consider the following example:
m365 spo site list --includeOneDriveSites

This takes care of including a boolean value in an API call to sharepoint. (true or false) By default it's false, but if the flag is included, the value is true.
We generally do not validate these flags however, which means that a user might inadvertently add a string value after them:
m365 spo site list --includeOneDriveSites abc

The actual value that is parsed by minimist will now be a string abc, instead of the expected true. That's potentially a cause for issues. In the code we now need to make sure that the flag is never used directly, but is always used with a condition:
//this is rather safe
if (args.options.includeOneDriveSites) {
}

// this as well.
!!args.options.includeOneDriveSites

// this is not safe
const requestbody: {
  someProp: 'someValue',
  someOtherProp: args.options.includeOneDriveSites
}

Our current implementation puts the burden of checking the flag in the command itself, we should however handle it centrally.
Solution
I propose adding flags to this.types.booleans, to make sure the values are validated centrally and type safe.
Another solution would be to look at zod

I'd suggest looking into zod. It would mean a significant refactoring, but the other solution feels like putting a bandaid and a temporary fix that doesn't address all cases and will until we ran into another limitation.

good find 👍

I propose adding flags to this.types.booleans, to make sure the values are validated centrally and type safe.

I wonder would this really take that much time? maybe we could do that to have this 'safe' before we move research with zod?

I wonder would this really take that much time?

I think it's a shame to spend time on a solution that we know we'll remove it anyway. Going through all commands at our scale is not trivial and will easily get into hours, including doing the work and reviewing the PR. I'd rather we spend that time on reviewing PRs and providing new functionality.
If we need an interim solution, I wonder if there's a different approach that we could do centrally rather than for each command separately.

gotchya 👍.. and BTW I may relate to that, I also like adding new stuff more than refactoring the old stuff 😉

as we're implementing ZOD, let's close this one!


Auto format on save doesn't work when quitting VS Code (and saving changes)

VSCode Version: Insiders
OS Version: Mac OS X El Capitan

Steps to Reproduce:

Have a file with unformatted code in a dirty state
Try to quit VS Code
Click save changes when prompted
Open VS Code and the previous file that had unformatted code.

Note that the code is still unformatted.

We do that on purpose and it's documented here: https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L3795. The reasoning is that saving on close is critical since the OS might not gives us much time to shutdown. Therefore no save participant is being called here

@bpasero On a second though this is also a change wrt trim whitespace. Before we would run that despite save on shutdown

Yeah, tricky. Instead of me checking for shutdown and not running the participants, we could move this into the save participant to only run the main-side participants but not the extension host ones (https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/common/editors/textFileEditorModel.ts#L450)


make skip a provided method of RingBufferRead

skip was implemented with a macro that was repeated for all ringbuffers. I've copied the #[inline] attribute, but I don't really know whether #[inline] works on a provided method. I've also removed the .map(drop), because I think it's unnecessary (correct me if I'm wrong).

won't correct cause you're not wrong


244/implement the layout for integrating the search for international results

Closes #244, #247 and #274.

If you search for a country on the start page and then go back to the start page from the ResultPage, the input field for the country is empty. But, if you now search again without further input, again only results of the previously selected country are displayed.
The reason could be that the store is not updated when reloading the start page.

This error was already present before this issue. It occurs not only in the international version, but also in the national version. Only the Radius field gets reseted. Please create another issue for this error.

If you search for a country on the start page and then go back to the start page from the ResultPage, the input field for the country is empty. But, if you now search again without further input, again only results of the previously selected country are displayed.
The reason could be that the store is not updated when reloading the start page.

This error was already present before this issue. It occurs not only in the international version, but also in the national version. Only the Radius field gets reseted. Please create another issue for this error.

Ok. I have created an issue: #281 LocationSearchBar store not cleared after reload

If you search for a country on the start page and then go back to the start page from the ResultPage, the input field for the country is empty. But, if you now search again without further input, again only results of the previously selected country are displayed.
The reason could be that the store is not updated when reloading the start page.

This error was already present before this issue. It occurs not only in the international version, but also in the national version. Only the Radius field gets reseted. Please create another issue for this error.

Ok. I have created an issue: #281 LocationSearchBar store not cleared after reload

Right in the second you created the issue I found and fixed the bug :)
Closes #281.


Don't use same container for all builds

Use BUILD_NUMBER (available in Jenkins environment) for docker container name.
For jenkins job 123, container name would be fabric8-wit-123 and for local build it would be fabric8-wit-local-build
Fixes - https://github.com/openshiftio/openshift.io/issues/3838

@jarifibrahim please note that the root cause as mentioned by @aslakknutsen here (https://github.com/openshiftio/openshift.io/issues/3838#issuecomment-399006019) is not being solved by this: Why are two jobs assigned to use the same build machine at the same time? In fact, your PR @jarifibrahim will not change that we might get failures on locked yum repos and such because we do install things like docker before using it on a machine. This can potentially be blocked.
Please remove the line Fixes - openshiftio/openshift.io#3838 from the description to not clause this issue automatically!

In fact, your PR @jarifibrahim will not change that we might get failures on locked yum repos and such because we do install things like docker before using it on a machine. This can potentially be blocked.

Yes, I didn't think about this issue. Changing the container name will reduce the failures but we will still have failures on yum lock.

[test]


Add asdf def, bump ubi version

Part of regular maintenance cycles with this piece of software. Updates to ubi 9.4 and adds an asdf definition for local dev.

LGTM


⚠ Samsung has degraded performance

In ebc8de1, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2390 ms

Resolved: Samsung performance has improved in e32ef57.


Vulnerability section

9 of 14 elements implemented for Vulnerability section.
New example cvrf_example_vulnerabilities.xml can be used for testing.

Talked through with @tschmidtb51, ready for Merge! @sustefil


Question about OpenEats Docker

Hi,
I try to use Openeats but when I start all my dockers, I have this message. I don't know if it is normal or not.
web_1    | Compiled successfully.
web_1    |
web_1    | File sizes after gzip:
web_1    |
web_1    |   264.98 KB (-5 B)  build/static/js/main.cd245a94.js
web_1    |   5.79 KB           build/static/css/main.8d187868.css
web_1    |
web_1    | The project was built assuming it is hosted at the server root.
web_1    | You can control this with the homepage field in your package.json.
web_1    | For example, add this to build it for GitHub Pages:
web_1    |
web_1    |   "homepage" : "http://myname.github.io/myapp",
web_1    |
web_1    | The build folder is ready to be deployed.
web_1    | You may serve it with a static server:
web_1    |
web_1    |   yarn global add serve
web_1    |   serve -s build
web_1    |
web_1    | Find out more about deployment here:
web_1    |
web_1    |   http://bit.ly/2vY88Kr
web_1    |
web_1    | Done in 25.58s.
openeats_web_1 exited with code 0
Thanks.
Jerome CARBEL

Hey there,
That is normal for the web container. It's job is to compile the static content and the nginx server that comes with OpenEats will then server it.
Are you having issues running OpenEats? if so can you please provide some more information as to what is going wrong?
Thanks,
Ryan

Hello, thank you for the response. I did not understand the usefulness of the docker web. I put a pause on my project. If I have some issues I'll post them.


Add link to NewHelp

Details

Add link to NewHelp site from Settings page and Get assistance page.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/240970
Tests

Open Settings menu
Click on "Help" item and verify it opens the site https://help.expensify.com/
Open the menu of an existing workspace.
Open the Get assistance page (Click on the "?" icon at the top of the page)
Click on "Explore help docs" item and verify it also opens the site https://help.expensify.com/

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Same as Test steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/6829422/211429950-c2a4dfce-e14d-4581-afa0-9dfe806d73dc.mov

Mobile Web - Chrome

https://user-images.githubusercontent.com/6829422/211430467-0cf091f3-5913-47cb-9499-d8c00e6222c5.mov

Mobile Web - Safari

https://user-images.githubusercontent.com/6829422/211430576-d32e7044-4b8c-4c9b-b3be-a00d0133cbfb.mov

Desktop

https://user-images.githubusercontent.com/6829422/211430828-e22fed44-342c-483d-8487-44f6bc300c68.mov

iOS

https://user-images.githubusercontent.com/6829422/211431808-d79817e6-0423-4ae5-8e53-d85f201737ad.mov

Android

https://user-images.githubusercontent.com/6829422/211431772-1e7a29ae-8b9f-4a2d-8588-aec522fa6a3f.mov

@ctkochan22 @eVoloshchak could you complete the PR Reviewer checklist to pass the GH checks?

@eVoloshchak you have time to do the checklist?

@eVoloshchak you have time to do the checklist?

I will be able to do that in ±12 hours, would that be ok?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/9059945/212478490-eea78a7e-d4a3-40f0-8803-6dfa046c079b.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/9059945/212478475-4ff83035-2255-45df-b8d2-b6b5c144c10c.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/9059945/212478522-c545a560-87a9-4cde-bb44-54e9754e2ecb.mov

Desktop
https://user-images.githubusercontent.com/9059945/212478506-5f6f5c0f-2fcb-45bd-bc0c-e9a68a33e2c7.mov

iOS
https://user-images.githubusercontent.com/9059945/212478513-eb1cfa6a-4df5-474d-94dc-65eba638df67.mov

Android
https://user-images.githubusercontent.com/9059945/212478460-ab79c5ec-cf42-4dd6-ad9d-8aa281ae937b.mp4

Thank you guys! I'm going to merge it now

@marcochavezf @eVoloshchak @ctkochan22 local app is crashing because of this PR, we are using themeColors on GetAssistance Page but we have not imported

local app is crashing because of this PR, we are using themeColors on GetAssistance Page but have not imported

local app is crashing because of this PR, we are using themeColors on GetAssistance Page but have not imported

Oh, true, thank you
The import was there, then it got removed in https://github.com/Expensify/App/pull/14289 since at that point this PR wasn't merged
I always thought GitHub does a lint check when merging, it should have caught that

Then again, even if linter would have caught it and we added the themeColors import back, it wouldn't crash anymore, but there would still be a bug, the icon wouldn't change the color oh hover (since this behavior was just recently added by https://github.com/Expensify/App/pull/14289)
https://user-images.githubusercontent.com/9059945/212534137-f1f9bd5d-4caf-4f83-9e86-32c9a15a62ac.mov
So to actually fix this we need to delete this line. I'm going to open a PR shortly
https://github.com/Expensify/App/blob/7ca2979f550c812171017e7b20b4ba659be17800/src/pages/GetAssistancePage.js#L62
There's also a post for this on Slack @jayeshmangwani created

🚀 Deployed to staging by @marcochavezf in version: 1.2.55-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @AndrewGable in version: 1.2.55-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@marcochavezf - Can you please production QA this?

was checking if am I eligible for the bonus to reporting a regression.
cc: @eVoloshchak @aimane-chnaif

was checking if am I eligible for the bonus to reporting a regression.
cc: @eVoloshchak @aimane-chnaif

@eVoloshchak @aimane-chnaif can you please confirm this, I am not able to find the original issue to comment

Test comment

@aimane-chnaif, thank you for the info!
I can't approve the PR since it was already merged, so I'm going to ask BZ members for help in Slack

This also had a regression that couldn't be prevented by following the checklist, not sure what're the rules on that


Correct get last version task

Correct GetLastVersion task not returning good package when there are strings and numbers in the package name

In this case this is even not working correctly, I found a case where the original GetLastVersion task was not returning the latest version as ordered by XLD, but another package that was in the middle of my packages list in XLD.
The correction I've done is returning the most recent package, based on the version number containing in the package names. This is working and more relevant I think.

Hello,
@pegail , can you tell me if this PR were accepted or not please .
Thanks

Hello,
@pegail , can you tell me if this PR were accepted or not please .
Thanks

Hello Fabien,
Unfortunately this PR has not yet been accepted, I have no answer since my last comment.

Thank you for this quick response :) . I've resume the work of Clement and i don't use the plugin for list the version (i use the rest API directly) . You can refuse this PR i you want, i don't correct the code of Clement.
Thanks


[prim_ram*] Support for generating multiple physical tiles

For ASIC implementations, it would be good if we had a parametric way to split up large logical RAMs into multiple physical RAM banks/tiles, mainly for two reasons:

the size of physical SRAM cuts that we can compile for ASIC has an upper limit,
for floorplanning reasons in physical design.

An instance of such a large memory is our main RAM. While in this case we could still compile one giant macro of that size, we found in our discussions with Nuvoton that breaking that RAM up into multiple tiles is preferable.
Technically, this could be achieved by manually instantiating multiple prim_ram_* with appropriate sizes in the design. However, this would also complicate memory loading via backdoor interfaces.
Hence I wanted to ask how people feel about adding a parameter to prim_ram_* that can be used to control the tiling factor. E.g.:
module prim_ram_* #(
  parameter  int Width           = 32, // bit
  parameter  int Depth           = 128,
  parameter  int DataBitsPerMask = 1,  // Number of data bits per bit of write mask
  parameter  int PhysicalTiles   = 1,  // Number of physical memory tiles (only relevant for ASICs)
  parameter      MemInitFile     = "", // VMEM file to initialize the memory with

  localparam int Aw              = $clog2(Depth)  // derived parameter
) (
...

Note that this parameter would only affect the ASIC primitives, since the FPGA tools can automatically infer block RAMs and perform the appropriate tiling. I.e., the PhysicalTiles parameter would not be used in the  prim_generic_ram* implementations.

Also note that by doing it this way, ECC/Parity logic in the *_adv wrappers would be automatically shared among all tiles.

i actually filed a duplicate issue :) #2445
let me go close that one.

so the width / depth, does that represent the overall size? Or individual tile size?  Are we basically going to take those, and if tile is > 1, re-calculate the per tile size?

o i guess only depth is impacted in this case.

yeah sorry about that :).
Yes that was the intent. I.e., you would specify the total size of the RAM that you want, and for ASIC prims the tiling parameter is used under the hood to split the RAM into multiple cuts.

sounds excellent to me.

We could technically add a second tiling parameter for the RAM width, since sometimes in certain cases you cannot achieve a certain width/depth ratio with a single cut.

ah you mean like split entries across multiple rams, and also a word across
multiples rams?
That would certainly be good to add, but probably not something needed for
this project....yet...
On Tue, Jun 9, 2020 at 6:02 PM Michael Schaffner<EMAIL_ADDRESS>wrote:

We could technically add a second tiling parameter for the RAM width,
since sometimes in certain cases you cannot achieve a certain width/depth
ratio with a single cut.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/2451#issuecomment-641658239,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSRVEBGSLRLOH63O46LRV3LQRANCNFSM4NZ4ZT2A
.

Yeah this would only be to make the prim wrappers a bit more generic (for now).

Sounds good to me, though it might need hw/dv/sv/mem_bkdr_if to be re-jigged perhaps, to fit this construct.

So the tiling parameter would split it up into multiple banks of the same width and add some address decoding/muxing logic to set enables and route read data out from the right bank?
Sounds like a reasonable approach to me, though I do wonder if an option to expose the banking structure might be useful for the icache, it's possible we could have more efficient logic (as the icache is already doing some logical banking for the ways so folding it all together could give better results). @tomroberts-lowrisc ?

If ECC is used in multi-bank SRAM macros, I think it should be two separate instance in current SRAM wrapper design. ECC, as I learned, shall be per bank, for instance, if we want to make 4x 32bit SRAMs for 128 wide bit, then ECC should be per SRAM so eventually the macro shall be 4x 39bit SRAMs. As OT's ECC applies prior to prim_ram_*p module, it is not doable unless the wrapper instantiates ram_*p_adv multiple times (do we plan to to this?)

@eunchan is right that under some circumstances (e.g. when ECC is employed), tiling should be explicit.
Hence, based on the comments above I think we can proceed as follows:

in cases where multiple banks are functionally needed (e.g. because ECC needs to be separate, or because higher bandwidth is required as e.g. in the I$), the RAM tiles / banks shall be explicitly instantiated in RTL.

in cases where multiple physical tiles are needed solely for the purpose of creating a certain logical RAM configuration, the tiling shall be performed "under the hood" in the technology-specific primitive wrapper, since this is not something that RTL needs to care about (this is also how inferred RAMs are assembled by the FPGA tool).

Note that this does not affect our current RAM loading mechanisms for DV/Verilator simulations, since those use the "generic" memory wrappers. We need to discuss how to deal with RAM loading once we add support for siomulating the actual "ASIC" view instead of the "generic" view - but this is a separate discussion.


test that we tolerate out-of-band data

Motivation:
We don't support OOB data but we should make sure that nothing breaks if
OOB arrives.
Modifications:
Add a test that makes sure we tolerate OOB data.
Result:
More test coverage.

New test failed on 5.1... 👎

Aged out, closing.


Select text and add hyperlink not workin

While selecting a text and adding a hyperlink, the text is lost and the hyperlink is added as raw hyperlink. Using this component in a SPFx solution.
SPFx version 1.8.2

I will pick it.

This repo is archived now. For react wrapper of roosterjs, please refer to roosterjs-react package in roosterjs repo. Thanks.


⚠ Bofrost.lu has degraded performance

In 8f39beb, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 957 ms

Resolved: Bofrost.lu performance has improved in 03714e6 after 9 minutes.


Add diffSync

This PR adds a diffSync variant for when you only have small lists to compare and need a synchronous response (i.e., without using a Future).

Published as version 1.3.0 to pub.dev


View provenance of result assets

User story
As a visitor, I want to understand how results were generated.
Acceptance criteria

[ ] See a list of all results assets
[ ] For each result asset, see what capsule generated it

name
version
date and time of run
link to capsule
link to github (if available) <-- go ahead and fake this e.g. (https://github.com/allenneuraldynamics/<capsule_name>)

[ ] For each result asset, see which raw data it was derived from

name
tags

Sprint Ready Checklist

[ ] Acceptance criteria defined

[ ] Team understands acceptance criteria

[ ] Team has defined solution / steps to satisfy acceptance criteria

[ ] Acceptance criteria is verifiable / testable

[ ] External / 3rd Party dependencies identified

[ ] Ticket is prioritized and sized

Notes

We used to call this the "pipeline run view."
Only need to go back one "hop" in the provenance chain.

Not currently a milestone


.8 test issues

Tested on win self host, 8.6 and 1.3.3 dnd5e, accessed through web browser. Midi-Qol, DAE, libwrapper, and socketlib installed. run with debug mode on

Auto Proficiency: Tested with Dagger pulled from srd. tested with customer "Dagger" prof marked on actor, than with "simple melee" marked, removing dagger in-between.   Neither marked weapon as prof
Wild Magic Surge: works as expected but with hidden results check in settings still shows to player.
Remove targeting after turn: errors in the console. see photo

Action, Reaction Tracking: hud not updating when actions taken. errors in the console.

Cover Sytem: message when turn ends after cover is applied. Had a strange error where it said cover effect lasted for two turns on the actors effect tab. After first time, could not get error to repeat.

Thanks a bunch for the report. Will work through them.
Ive gotten (5) a couple times myself, but during a totally different activity. Unsure what's going on exactly, but it does stop firing after a while for me too...

All but (2) should be addressed in 2.0.4.
(2) will be addressed at a later date.


Parse .babelrc as JSON5

.babelrc is JSON5 not plain JSON -- this pull requests add the json5 package so that it can be parsed as JSON5.
This pull request also bubbles parse errors from JSON or JSON5 to the end user, instead of ignoring them so that any syntax errors present in .babelrc can be fixed.
Reference: https://babeljs.io/docs/usage/babelrc/

I've published 7.0.1 with just this change. I then merged the upstream changes and released that as 7.1.0


Feat: Support for spell checking

Could be useful the support for the "Spell checking" of NeoVim. In the others status line, when the spell checking is active the status bar has the format
Hello.txt [text][utf8][unix][en_US.utf8]

The last part ([en_US.utf8]) appears only when the checking is on.

I think this can be easily done with a function component in config .

I've tried adding lualine_c = {'%{&spell}'} but obtain only 0 a 1 (for inactive and active).
I'm sorry but I'm not familiar with lua programming.

You can try something like
lualine_c = {function()
    if vim.bo.spell == 1 then
       return '[en_US.utf8]'  -- Probably should return based on which spell file being used not hardcoded value.
    end
    return ''
  end
}

This would work too but not recomended
lualine_c = {"%{&spell?'[en_US.utf8]' : '[NoSpell]'}"}

@shadmansaleh Probably this:
local function spell()
  if vim.wo.spell == true then -- Note that spell is a window option, so: 'wo'
    return 'spell [' .. vim.bo.spelllang .. ']'
  end
  return ''
end

-- ~~~
    lualine_x = { spell, 'encoding', 'fileformat', 'filetype' },
-- ~~~            ^^^^^


Feed showing only a few new notes

Describe the bug
My feed is only showing a few new notes and then it shows the notes from 1 day ago
Steps to reproduce
Using latest with replies.
Expected behavior
In other apps like yana, amethyst and nozzle it shows a lot more notes
Environment
Additional context

Can you post the screenshot of the Feed Picker? Does it happen with other feeds?
"Latest with replies" is not yet supported on Android. You should not even see it in the feed picker.

I reset my feeds recently. But the feed shows a lot more notes on the web. Before the reset the same thing happened with follows, my network, my tribe etc.

I think the bug here is in the naming of the feed. You probably seeing the "Latest" feed, but instead it says "Latest with Replies". I'll double check with the team to see why naming issue happens.
You are using only Android and Web app?

Yes, only using the web and the android app

Cool, thanks. Can you post the screenshot from the Feed Settings on Primal Web? You can crop to show feed settings only. Direct link: https://primal.net/settings/feeds

Android app shows wrong feed label if you put "Latest with Replies" first on top. We'll fix the labelling bug in the next release.
"Latest with Replies" feed feature is still in the backlog. In the meantime, you could add https://primal.net/explore/follows/latest to your feed list to see all notes (including replies) from your followers. The difference between this feed and "Latest with Replies" is that LwR shows also reposts while Follows;Latest; feed is not showing reposts.

Same issue. It loaded some recent notes but them it jumped to notes from 3 days ago.

Same issue. It loaded some recent notes but them it jumped to notes from 3 days ago.

I have this kind if problems too. Notes from 2 hours ago then jump do 6 hours ago. For sure many notes are missing:

We were able just recently to find the cause for this issue. It will be fixed as soon as backend is ready.


TypeError on Filler bots

Hey, I am still getting the type error on both filler and filler lite bots after pulling the updates with git pull and making sure I ran yarn.
src/utils.ts:129
if (!node.node.userAccount) {
^
TypeError: Cannot read properties of undefined (reading 'node')

i believe this was fixed at some point, please reopen if you see it again


[Style Change] Remove italic from highlight "Special"

The Special highlight has the style italic. This let looks the \-character for escapes look like a |-character.
I do not know if this is intended.
I would propose to change the style of Special to empty/none.

So I opened a PR for this, see #43

Closed in https://github.com/luisiacc/gruvbox-baby/pull/43


Support for empty string value

This pull request allows empty string value.

This repo is no longer maintained by happn.


Logged-in Home page doesn't have clear actions for the most likely use case

When I'm logged in and visit the domain, I am sent to the communities page. I suspect that most users would want to view offers first but I'm not sure if it's better for them to go straight to a list of offers or if it's better that they choose a community first.

Thank you for reporting!
This is a bug in the app. It can be fixed along the lines of https://github.com/ditup/ditup-solid/commit/2b75df4775bee940ed0502112054be809274d0e2


[terra-dev-site] Added option to switch router type

Summary

Added option to switch between BrowserRouter and HashRouter. Defaults to "BrowserRouter"
Added isHashRouter property which can be set in the "site.config.js" to either enable or disable HasRouter.

Closes #228
Deployment Link

https://terra-dev-site-deployed-pr-#.herokuapp.com/
Testing

@avinashg1994 tests?

@avinashg1994  I'm not sure we still want to make this change. I will have to sync up with a couple other terra maintainers.

We don't need this enhancement anymore. We've decided to use a different site for the situation where we can't know the base path up front.


[macOS] Implement new directories hierarchy

Description
This PR implements new unified directories hierarchy for macOS image source code:

assets: Configuration files that are copied to the image during the build process.
scripts:

build: Scripts that are executed during the image build process.
helpers: Scripts used by other scripts during the image build process.
docs-gen: Script and PowerShell modules for generating software and configuration reports.
tests: Test scripts and related files for validating the image.

templates: Packer templates for the image build process.
toolsets: JSON files that define the software versions to be installed on the image.

Related issue: https://github.com/actions/runner-images-internal/issues/5514, https://github.com/actions/runner-images/issues/8706
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[x] Changes are tested and related VM images are successfully generated

Description
This PR implements new unified directories hierarchy for macOS image source code:

assets: Configuration files that are copied to the image during the build process.

scripts:

build: Scripts that are executed during the image build process.
helpers: Scripts used by other scripts during the image build process.
docs-gen: Script and PowerShell modules for generating software and configuration reports.
tests: Test scripts and related files for validating the image.

templates: Packer templates for the image build process.

toolsets: JSON files that define the software versions to be installed on the image.

Related issue: https://github.com/actions/runner-images-internal/issues/5514, #8706
Check list

[x]  Related issue / work item is attached
[ ]  Tests are written (if applicable)
[ ]  Documentation is updated (if applicable)
[x]  Changes are tested and related VM images are successfully generated

Description
This PR implements new unified directories hierarchy for macOS image source code:

assets: Configuration files that are copied to the image during the build process.

scripts:

build: Scripts that are executed during the image build process.
helpers: Scripts used by other scripts during the image build process.
docs-gen: Script and PowerShell modules for generating software and configuration reports.
tests: Test scripts and related files for validating the image.

templates: Packer templates for the image build process.

toolsets: JSON files that define the software versions to be installed on the image.

Related issue: https://github.com/actions/runner-images-internal/issues/5514, #8706
Check list

[x]  Related issue / work item is attached
[ ]  Tests are written (if applicable)
[ ]  Documentation is updated (if applicable)
[x]  Changes are tested and related VM images are successfully generated


history 模式下刷新页面 hash 会丢失

What problem does this feature solve?
保留 hash
What does the proposed API look like?
无

Hi!
Please make sure to follow the Issue Reporting Guidelines before opening an issue. You need to provide a repro when reporting bugs.
Thanks!


Add Collegeboard, FreeCodeCamp, and gPodder

Add info for 3 sites: Collegeboard.org, FreeCodeCamp.org, and gPodder.net

Thank you for your contribution!


SamsaGlyph.prototype.svg has hardcoded width and height

Some fonts are not based on 1000 units, it would be better if the width and height of the SVG can be set dynamically, based on the font data, such as unitsPerEm
Right now it is being hardcoded as width="1000" height="1000"
SamsaGlyph.prototype.svg = function (style={}) {
	...
	return `<svg version="1.1" xmlns="http://www.w3.org/2000/svg" width="1000" height="1000">
	<g${style.transform ? ` transform="${style.transform}"` : ""}>
		<path d="${this.svgPath()}"${extra}></path>
	</g>
</svg>`;
}

alternative pull request #76
use viewBox instead of width and height, this will make the SVG responsive

Thanks for this! I’ve been meaning to improve the SVG sizing for a while. I’ll take a look soon and almost certainly accept your PR.


enlightenment: add missing update scripts

Description of changes
enlightenment.econnman: reformat the nix expression
enlightenment.econnman: fix file name extension in url
enlightenment.econnman: add update script
enlightenment.ecrire: add update script
enlightenment.ephoto: add update script
enlightenment.evisum: add update script
enlightenment.rage: add update script
enlightenment.terminology: add update script
pythonPackages.pythonefl: add update script
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1318


Bundler 2.5.17 vendoring git gem test

What I did
$ b u --bundler
Fetching gem metadata from https://rubygems.org/.
Updating bundler to 2.5.17.
Fetching bundler 2.5.17
Installing bundler 2.5.17
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Installing strscan 3.1.0 with native extensions
Installing localhost 1.3.1
Installing ruby2_keywords 0.0.5
Installing github-markup 5.0.1
Installing json 2.7.2 with native extensions
Installing bigdecimal 3.1.8 with native extensions
Installing minitest 5.24.1
Installing public_suffix 6.0.0
Installing parallel 1.25.1
Installing racc 1.8.0 with native extensions
Installing regexp_parser 2.9.2
Installing warning 1.4.0
Installing net-http 0.4.1
Installing addressable 2.8.7
Installing faraday 2.9.1
Installing faraday-retry 2.2.1
Installing octokit 9.1.0
Installing parser <IP_ADDRESS>
Installing rubocop-ast 1.31.3
Installing rexml 3.3.1
Installing rubocop 1.65.0
Installing webmock 3.23.1
Installing sequel 5.82.0
Updating files in vendor/cache
Bundle updated!
1 installed gem you directly depend on is looking for funding.
  Run `bundle fund` for details

~/local_code/wikimum bundler-git-vendoring* 12s
$ vim Gemfile

~/local_code/wikimum bundler-git-vendoring* 51s
$ git diff
diff --git a/Gemfile b/Gemfile
index f19a796..6299a49 100644
--- a/Gemfile
+++ b/Gemfile
@@ -18,7 +18,7 @@ gem 'commonmarker'
 gem 'rest-client'
 gem 'octokit'
 gem 'faraday-retry'
-gem 'addressable'
+gem 'addressable', github: 'sporkmonger/addressable'
 gem 'sentry-ruby'
 gem 'racksh'
 gem 'warning'
diff --git a/Gemfile.lock b/Gemfile.lock
index 4dc4aa1..710a4e6 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -188,4 +188,4 @@ RUBY VERSION
    ruby 3.2.3p157

 BUNDLED WITH
-   2.5.6
+   2.5.17

$ b
Fetching https://github.com/sporkmonger/addressable.git
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Updating files in vendor/cache
Removing outdated .gem files from vendor/cache
  * addressable-2.8.7.gem
Bundle complete! 29 Gemfile dependencies, 75 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
1 installed gem you directly depend on is looking for funding.
  Run `bundle fund` for details

$ git st
On branch bundler-git-vendoring
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   Gemfile
	modified:   Gemfile.lock
	deleted:    vendor/cache/addressable-2.8.7.gem

$ git diff
diff --git a/Gemfile b/Gemfile
index f19a796..6299a49 100644
--- a/Gemfile
+++ b/Gemfile
@@ -18,7 +18,7 @@ gem 'commonmarker'
 gem 'rest-client'
 gem 'octokit'
 gem 'faraday-retry'
-gem 'addressable'
+gem 'addressable', github: 'sporkmonger/addressable'
 gem 'sentry-ruby'
 gem 'racksh'
 gem 'warning'
diff --git a/Gemfile.lock b/Gemfile.lock
index 4dc4aa1..a1bbec8 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,8 +1,13 @@
-GEM
-  remote: https://rubygems.org/
+GIT
+  remote: https://github.com/sporkmonger/addressable.git
+  revision:<PHONE_NUMBER>616783287ca359bbe38b574f1908a3
   specs:
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
     ast (2.4.2)
     base64 (0.2.0)
     bigdecimal (3.1.8)
@@ -154,7 +159,7 @@ PLATFORMS
   x86_64-linux

 DEPENDENCIES
-  addressable
+  addressable!
   climate_control
   commonmarker
   dyno_metadata
@@ -188,4 +193,4 @@ RUBY VERSION
    ruby 3.2.3p157

 BUNDLED WITH
-   2.5.6
+   2.5.17
diff --git a/vendor/cache/addressable-2.8.7.gem b/vendor/cache/addressable-2.8.7.gem
deleted file mode 100644
index c489068..0000000
Binary files a/vendor/cache/addressable-2.8.7.gem and /dev/null differ

Why don't we have addressable in the cache after this?

$ cat .bundle/config
---
BUNDLE_CACHE_ALL_PLATFORMS: "true"

Why don't we have addressable in the cache after this?

Maybe https://github.com/rubygems/rubygems/pull/7926 is needed too (not yet released)

For reference: https://github.com/rubygems/rubygems/pull/4469/ was released in Bundler 2.5.17 (https://github.com/rubygems/rubygems/releases/tag/bundler-v2.5.17)

We need from https://bundler.io/man/bundle-config.1.html

cache_all (BUNDLE_CACHE_ALL): Cache all gems, including path and git gems. This needs to be explicitly configured on bundler 1 and bundler 2, but will be the default on bundler 3.

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   .bundle/config
	modified:   Gemfile
	modified:   Gemfile.lock
	deleted:    vendor/cache/addressable-2.8.7.gem

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	vendor/cache/addressable-422916484361/

$ git st
On branch main
Your branch is up to date with 'origin/main'.

Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	modified:   .bundle/config
	modified:   Gemfile
	modified:   Gemfile.lock
	deleted:    vendor/cache/addressable-2.8.7.gem
	new file:   vendor/cache/addressable-422916484361/.bundlecache
	new file:   vendor/cache/addressable-422916484361/FETCH_HEAD
	new file:   vendor/cache/addressable-422916484361/HEAD
	new file:   vendor/cache/addressable-422916484361/config
	new file:   vendor/cache/addressable-422916484361/description
	new file:   vendor/cache/addressable-422916484361/info/exclude
	new file:   vendor/cache/addressable-422916484361/objects/pack/pack-cd362be2c7bd1cec0e0a3e39439b5f1257676596.idx
	new file:   vendor/cache/addressable-422916484361/objects/pack/pack-cd362be2c7bd1cec0e0a3e39439b5f1257676596.pack
	new file:   vendor/cache/addressable-422916484361/packed-refs
	new file:   vendor/cache/addressable-422916484361/shallow


Preparing the Gem for promotion to Core Component

This resolves #59

May I please request a review and merge from @samvera-labs/maintenance members (or, if available, @cjcolvar [sorry]) in order to ensure that this can be promoted to https://github.com/samvera. Thank you very much!


Desktop storage box

Description of the new feature / enhancement
Similar to the desktop on the mobile phone, multiple software shortcuts/files are put into a folder, and the folder icon displays the icon of the software/file
Scenario when this would be used?
It is used when desktop software is plentiful and desktop Windows are plentiful
Supporting information
No response

Hi @moligod, this seems like a /dup of #27653 so I will close this. Please feel free to open it if this is not a dupe.
If it is a dupe, please redirect your discussion to #27653. Thank you! :)


Custom Field Content Type Removal Issue

Custom Field Content Type Removal Issue
Describe the bug
When managing custom fields of type selection in Nautobot, I've encountered an inconsistency. Specifically:

If a custom field choice is being used by an object, I cannot delete the custom field choice. This is expected behavior to prevent data loss.
However, I can remove a content type from the custom field, which results in the custom field being removed from all objects associated with that content type. This action causes loss of information, which seems incorrect.

To Reproduce
Steps to reproduce the behavior:

Create a custom field of type selection and apply it to a content type.
Assign values to the custom field in various objects.
Attempt to delete a custom field choice that is in use - this correctly shows an error.
Remove the content type from the custom field settings.

Expected behavior
Removing a content type from a custom field should not be allowed if it results in data loss from objects currently using that custom field. This action should be restricted similar to deleting custom field choices that are in use.
Environment:

Nautobot version: v2.2.4
Python version: 3.11.9
Docker version: 26.1.2

Additional context
This issue was raised in a discussion, and I was advised to open a GitHub issue for further investigation. The behavior described seems contrary to data integrity principles, and clarification on whether this is by design or a bug would be appreciated.

It's "by design" in that there is code present specifically to implement the above data-removal behavior, but I can absolutely understand your concern here.
However, if we were to change this behavior to disallow removing a content-type from a custom field if there are any objects that would be affected by the removal, that would potentially make it impossible for users to ever remove a content-type from a custom field, as there's no user-facing mechanism for removing (as opposed to setting to an empty value) custom field data from objects except for doing exactly this (or deleting the custom field altogether, which functionally is equivalent to removing all content-types from the custom field before deleting it).