Workspace general settings save button does not have visual feedback Action performed: - reported by @mdneyazahmad

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
Settings -> Workspace -> General settings
Change name or default currency
Click save

Expected Result:
Save button does not have visual feedback when the changes are saving.
Actual Result:
Save button should have visual feedback when the changes are saving.
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.2.5-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/192687677-e64f440d-cd08-4ae0-bc25-7d31ae4edd46.mov
Expensify/Expensify Issue URL:
Issue reported by: @mdneyazahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663135200801149
View all open jobs on GitHub

I think this issue is similar to this one.
https://github.com/Expensify/App/issues/11195#issuecomment-1258666293

I think we should ask @Expensify/design if this is expected, and if not, what to do about it. I guess we could show a success message above the save button?

I think we should close this because I believe this page is ripe to be revamped a bit with push to page. CC @trjExpensify

Yeah, agreed. I suspect the growl was deprecated with the workspace API refactors as we're moving away from growls in App.

Okay, then I say we just close this one out for now. Reopen if you disagree!


Tech refactoring on Angular part of the Console

Issue
NA
Description

Rename files of some shared components to have the same gio prefix on all of them.
In tests, flush null instead of an empty object or status code when the server returns nothing

Gravitee.io Automatic Deployment
📚 View the storybook of this branch here

Gravitee.io Automatic Deployment
Congrats, all the CI steps were 🟢 . The Bot was able to deploy the build of this PR, so you can now try it directly here! 🚀
Notes: The deployed app is linked to the management API of the Element Zero team's environment.

Gravitee.io Automatic Deployment
📚 View the storybook of this branch here

Gravitee.io Automatic Deployment
Congrats, all the CI steps were 🟢 . The Bot was able to deploy the build of this PR, so you can now try it directly here! 🚀
Notes: The deployed app is linked to the management API of the Element Zero team's environment.

Gravitee.io Automatic Deployment
📚 View the storybook of this branch here

Gravitee.io Automatic Deployment
Congrats, all the CI steps were 🟢 . The Bot was able to deploy the build of this PR, so you can now try it directly here! 🚀
Notes: The deployed app is linked to the management API of the Element Zero team's environment.


[cherry-pick] [branch-2.1] [enhancement] Opt the binary search of find partition end in Analytor(#5864)

In the past, every time a new Chunk was read, the start pos of the binary search was PartitionStart. Currently, we execute binary search from the last pos, to reduce the frequency of compare.
This is not the main point that affects the calculation performance of the window function. The actual test has no effect on the performance. The main purpose is to release the memory earlier of the PartitionColumn in advance later.

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_fe_unittest


Set initial version to 0.0.1

To indicate we're still testing the release process and aren't ready to advertise to the world yet, let's start with major and minor version 0.
I'm not sure who has access to push new tags to the repo (I don't), but assuming it's one of @ptomecek @timkpaine @robambalu, could one of you merge this and afterwards do the following on your local clone of csp:
$ git checkout main
$ git pull origin main
$ git tag v0.0.1
$ git push origin v0.0.1

Assuming you have the point72/csp remote configured with the name origin.
If there are issues with any of the release scripts, I'll debug that and iterate once more on this, but hopefully everything will "just work".

fixed:
goldbaum at Nathans-MBP in ~/Documents/csp on reset-versions
± make show-version
0.0.1


feat: expandedEntity validation

When trying to create an entity it returns the following error:
{
    "detail": "class java.util.LinkedHashMap cannot be cast to class java.util.List (java.util.LinkedHashMap and java.util.List are in module java.base of loader 'bootstrap')",
    "title": "There has been an error during the operation execution",
    "type": "https://uri.etsi.org/ngsi-ld/errors/InternalError"
}

There were a second call to getAttributesOfType() declared in the companion object.
With attributes that contains temporalValues.


[Distributed] Review followups, cleanups

Removes an unused request and a few more code-reuse and minor cleanups.
Cleanups for:

https://github.com/apple/swift/pull/41916
https://github.com/apple/swift/pull/41740

@swift-ci please smoke test and merge

@swift-ci please build toolchain macOS


Document optional arguments when opening a modal

We document the optional arguments when opening a modal. This is similar to how we allow optional arguments when opening a side panel.
SDK PR: https://github.com/DataDog/ui_apps_sdk/pull/47

[x] We're tracking a branch for the SDK, since it needs to be merged/released first. We'll need to update that before merging this.

Thanks for the review!


Mute topic/stream for a limited time

It would be nice if I could ignore a topic or stream for a limited amount of time (like 1h or 24h or so). I'm generally interested in that topic or stream, but not in the current conversation.

I think this is a reasonable feature concept.  I think it needs some thought about exactly how the UI should work for enabling this "temporary mute", and the exact details of what it should do (e.g. does one want a fixed time window like 24hr, or wait until its idle for 1hr, or something else?).

@ruchit2801 that's exactly what I want

@zulipbot claim

Shut up zulipbot

Closing in favor of #17008 because this issue is hopelessly spammed.


fix: better server side protocol detection (fixes #123)

Use module that detects protocol used in more accurate way.

Thanks @rchl !


[SPARK-29758][SQL][2.4] Fix truncation of requested string fields in json_tuple

What changes were proposed in this pull request?
In the PR, I propose to remove an optimization in json_tuple which causes truncation of results for large requested string fields.
Why are the changes needed?
Spark 2.4 uses Jackson Core 2.6.7 which has a bug in copying string. This bug may lead to truncation of results in some cases. The bug has been already fixed by the commit https://github.com/FasterXML/jackson-core/commit/554f8db0f940b2a53f974852a2af194739d65200 which is a part of Jackson Core since the version 2.7.7. Upgrading Jackson Core up to 2.7.7 or later version is risky. That's why this PR propose to avoid using the buggy methods of Jackson Core 2.6.7.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By new test added to JsonFunctionsSuite

Test build #113965 has started for PR 26563 at commit a28f90c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18831/
Test PASSed.

cc @gatorsmile , @cloud-fan

Test build #113965 has finished for PR 26563 at commit a28f90c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113965/
Test PASSed.

Test build #114004 has started for PR 26563 at commit 2ec9120.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18865/
Test PASSed.

Test build #114004 has finished for PR 26563 at commit 2ec9120.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114004/
Test PASSed.

@HyukjinKwon @gatorsmile any thoughts?

I think it's fine.

@MaxGekk let's resolve conflicts and get this in. Thanks!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18969/
Test PASSed.

Test build #114112 has started for PR 26563 at commit f4fd00f.

Test build #114112 has finished for PR 26563 at commit f4fd00f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 class TimestampParser(fastDateFormat: FastDateFormat)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114112/
Test PASSed.

thanks, merging to 2.4!


[1.12.2 v1.12-1.0.0 Radon Modpack v1.3.0:Rare Cities setting] Cleared buildings still spawn Lost Souls mobs

As an added note, the frequency of rare cities was changed in config to 0.0001 and this is on a server. The city consists of about 20-ish buildings. Once clearing one and receiving the message lost souls mobs still spawn. If you need more detail, let me know.

This is per building. Are you sure you cleared every building and got a message for every building?

My understanding was that one building clear would allow that one building freedom from the lostsouls. You would still need to clear other buildings to release each of them?
Are you saying there is possible overlap of lostsoul building claim or that all infested buildings need clearing in that city?

There is no overlap but keep in mind that when you get that message that a building is cleared it depends on where that creature you just killed spawned from. If it was a mob from another building then this does not mean that your current building is cleared. It means that the other one is cleared. This makes it sometimes hard to know which building is safe and which is not

I'll look further into this and report back


If I want to find conditional GAN architecture , what should I do?

Hi,
You need to build a conditional search space and modify the training process accordingly.

Thank you I will try it, although I really don`t how to implement yet.


adding docker-slim to the list of open source projects using Colly

let me know if you need any other information about the project or if you need more details about the Colly package use

Great project, thanks!

Thanks for gocolly :-)


Update docs from subscription.Close to subscription.Dispose

There is no Close method on Subscription. I assume there perhaps was at one point, but that it was replaced with Dispose.

Thank again Michael!


UI Elements - Bootstrap Accordion & Carousel

[ ] Collapsible Accordion
[ ] Carousel

https://almsaeedstudio.com/themes/AdminLTE/pages/UI/general.html

Closed Bootstrap Accordion & Carousel


environment version

Hello, thank you for sharing. I would like to ask about your specific environment version, because when configuring the environment, it always shows that I do not have CuPy installed (but it is actually installed), so I guess it is a version problem.Or do you have any solution?
AssertionError: CuPy is not installed! You can install it from "https://github.com/cupy/cupy".

Please check previous issues https://github.com/BICLab/Spike-Driven-Transformer/issues/4 first.


[Test Failed] Android smoke test failed

Test issue(s)
https://github.com/project-chip/connectedhomeip/actions/runs/5605998363/job/15187576000
Platform
android
Anything else?
No response

I think pigweed update with "do not generate mapfile" in #28161 should make android stable again.


Support INSERT IGNORE Statement for Primary Key Table

Feature request
Support INSERT IGNORE Statement for Primary Key Table
Insert ignore is a very common use in mysql community.
https://dev.mysql.com/doc/refman/8.0/en/insert.html
grammar:
INSERT IGNORE
    INTO table_name
    [( column_name [, …] )]
    [VALUES]
    [(value_list[, …])]
    [query];

If where are same primary keys, default insert will use the newer row replace the old row but the insert ignore stmt will ignore the newer row and keep the old row.
So INSERT IGNORE was only enabled in Primary Key table.
Also the other kinds of data load such as StreamLoad and Broker Load should be suppported.

Seems that this feature is sub set of merge into statement.
Do you consider if it is possible to support this feature through merge into statement?

Seems that this feature is sub set of merge into statement. Do you consider if it is possible to support this feature through merge into statement?

merge into statement was more complexed.

I think it's OK to implement it in the INSERT statement.
And it's OK to set the default behavior without IGNORE keyword as upsert, althought it's not compatible with MYSQL in which the default behavior without IGNORE is to throw an error, while currently SR can't throw errors when meeting pk conflicts.


Google Compute Engine VMs only support virtio-scsi disk devices

GCE has only one type of disk: virtio-scsi (from https://cloud.google.com/compute/docs/tutorials/building-images#hardwaremanifest). We currently don't support this virtio device. This issue is tracking that effort.

Marking this as "help wanted" in the sense that its up for grabs for someone that needs the functionality. Current goals are concentrated on targets other than virtio.

I've offered a $100 bounty for this. Perhaps others will join me: https://www.bountysource.com/orders/133856
It might be better to implement the virtio SCSI device in pure OCaml and introduce hooks into Solo5 to support it. But your call really.

The URL seems to have moved slightly: https://cloud.google.com/compute/docs/images/building-custom-os


Do not rely anymore on Puppet Lint to track trailing whitespaces

Fixed in PR https://github.com/iwarapter/sonar-puppet/pull/6

Thanks for your contribution!


How to test if IPv4Address is inside IPv4Network?

You can find it in the README, but I think you can test it as follows.
var address = ipaddr.IPv4Address('<IP_ADDRESS>');
var network = ipaddr.IPv4Network('<IP_ADDRESS>/24');
if (network.addresses.contains(address)) {
  print('$address is included $network'); // <IP_ADDRESS> is included <IP_ADDRESS>/24
}


Bug: Cannot start VR with Windows Mixed Reality - Context lost.

Windows Mixed Reality Portal
Edge browser
When I click the orange Goggles to start WebVR, the canvas within the browser turns black. The VR environment does not launch.
F12 Developer Tools console output:
WARNING: Context lost.
WEBVR22602: VRDisplay.requestPresent is rejected - presenting HTMLCanvasElement's context is not compatible with the VRDisplay. Event.preventDefault() must be called during the firing of webglcontextlost event on the presenting HTMLCanvasElement.
Tested projects: WebVR Hello World, WebVR Lab
Environment: Windows 10 Pro 1709
Hardware: Samsung HMD Odyssey, Microsoft Surface Pro 2
Taking similar action in three js WebVR sites works correctly: gives the browser prompt, then the VR portal environment is replaced by the WebVR project environment.

We don't have that device. I don't suppose you're in a position to develop a fix? 😄

Thanks for taking the time to investigate.
So implementing this doesn't seem too complicated. The main issue is recreating the WebGL resources for certain PlayCanvas objects, namely:

pc.Texture
pc.VertexBuffer
pc.IndexBuffer
pc.RenderTarget

There might be some others but those 4 are the main ones. To create any of those, we pass the graphics device into the constructor. We could just add 'this' to an array on the graphics device. So when the context is restored, we just iterate over the arrays and invalidate or recreate the required WebGL resources.

Made pretty good progress on this today. It's maybe 90% implemented now. 😄


A way to display the help message

Hello,
I have two options that are lists of integers. I'd like to show the help message if both lists are empty.
I don't think you can express that requirement in optparse-generic (please correct me if I'm wrong!), so it would be nice to be able to get the help message or cause the help message to be printed out in cases where the data structure cannot encode certain option requirements. I don't think this would exactly work, but something like this that instead gets the option data type in there:
main = do
  opts <- unwrapRecord "unwrap-example"
  if (doesntMatchRequirements opts)
  then printHelp "unwrap-example"
  else print (opts :: Options Unwrapped)

Ryan

I could add a variation on getRecord/unwrapRecord called getWithHelp/unwrapWithHelp that returns the command to print the help output.  Then you could do:
main = do
    (opts, printHelp) <- unwrapWithHelp "unwrap-example"
    if doesn'tMatchRequirements opts  -- Note: Apostrophes in the middle of names are legal
        then printHelp
        else print (opts :: Options Unwrapped)

How does that sound?

Sounds great!


Notification Panel not working after poe 3.3.1c

I've never had any troubles with MercuryTrade but after the update the introduced the race i couldn't see notifications neither the sound aswell, the test ones work just fine but everything else doesn't i have 3 other friends who have the same problem. *Yeah i'm in the latest ver of both poe and MT

There is a workaround, though that's all it is. Click the pin icon in the tool bar. You might have to click more than once, oddly. Then, when the window pops up to reposition, move the notification window very slightly and lock position. Now everything should start working again.


Add a GeometricDetector class

This PR focuses on adding a new type of detector to the framework that uses the geometric learning-free approach to produce tree crown detections using a CHM.
Algorithm followed to obtain treetops:
Seeing the Trees in the Forest: Using Lidar and Multispectral Data Fusion with Local Filtering and Variable Window Size for Estimating Tree Height
Algorithm followed to produce tree crowns:
Imputation of individual longleaf pine (Pinus palustris Mill.) tree attributes from field and LiDAR data
To visualize the predictions, please view tree-detection-framework/sandbox/detection/geometric_detections.ipynb

A couple things we discussed in this morning's meeting (not exhaustive):

Splitting treetop detection and crown delineation into separate methods
Adding a linear term (coefficient b) to the treetop window function
Vectorizing crown delineation across all rows of the treetops data frame, as opposed to a for loop
See creating the height mask is more efficient by first cropping the tile CHM to the maximum possible bounds of the tree crown, as opposed to applying the mask to the whole tile CHM for each tree
If a crown consists of a multipolygon, keep just the polygon in which the treetop point actually falls


Mixed Set Additions

Some simple functions to help support MixedSet

I'd still like to add these functions, but probably in a separate PR:

PointSet.fromMixedSet(contPercent) -> makes uniform dist in this set of ranges.
PointSet.truncate(MixedSet) -> Removes the PointSet outside of the MixedSet.


readthedocs page won't load, hangs when other websites load

What happened?
I'm not sure if this issue is a problem with batcher but wanted to call it out in case others experience the same issue.
https://xbatcher.readthedocs.io/en/latest/
hangs when I navigate. I can load all other sites with no problem, including this other readthedocs website: https://scipy-cookbook.readthedocs.io
What did you expect to happen?
page loads

closing! seems like it was an issue with my connection, sorry for the noise.


parameterize the global scrape_interval in prometheus config

allow to customize the scrape_interval in the global section of the prometheus

Neat! Thanks for the contribution!
Could you run make generate, to re-generate the API docs from the code? :slightly_smiling_face:

doku updated.

@coreosbot test this please

@coreosbot test this please

Having some trouble with CI so I ran tests myself, and it all looks good, thanks! :+1:


Prevent potential divide by 0 error

I haven't experienced this myself but I had a user report that at least in a simulator they're sometimes getting a divide by 0 error here with a specific server, so I figure it's probably safest to prevent that form happening here anyway.  Also cast the integer to float for division.
Related issue with error/stack trace info: https://github.com/austinried/subtracks/issues/119

Thanks but I already fixed it before i saw the PR


Maestro Provider | Is protocolParamExtraPraosEntropy unnecessary?

https://github.com/geniusyield/atlas/blob/0cf1d0977a4c2b1c837f4339f13c20aa7a4133b6/src/GeniusYield/Providers/Maestro.hs#L559

Removed for in Babbage.


[WIP] Cleanup and reorg of handle callback code

NOTE: Still thinking through these changes and the ramifications, I have
a PR up to see if copybara has any issues. Feel free to weigh in with
thoughts, if you're bored and want to review this early.
What started as adding start/stop functionality to handles turned
into a re-imagining of the callbacks pattern.
Observations:

registerHandle (which was to be called via a start method on the
handle) is only setting up callbacks to the handle.
The only action a handle takes when receiving storageProxy callback
calls is to trigger any developer-supplied callbacks.
Adapting between the single-interface-with-all-3-callbacks and
callbacks-as-individual-methods approach seemed to cause some
complicated interface adaption needs.

PENDING TOODs:

Decide on when to request synchronization of the Handle
Figure out a callback removal strategy (per handle, per particle?)
Consider dispatch model for callbacks
Fix up a few tests

You may want to take a look at what I did in https://github.com/PolymerLabs/arcs/pull/4782
I moved all of the onXXX methods to a HandleLifecycle interface and generalized them so that Singleton and Collection share the same interface. This allows you to write code to listen to any type of Handle which would allow more general purpose utility methods/combinators/operators to be designed to work on arbitrary handles .
So for example, you could write
fun <T, S> combine(h1: ReadableHandleLifecycle<T>, h2: ReadableHandleLifecycle<S>, block: (T,S) -> Unit) = flow {
    h1.onUpdate { e1 -> emit(e1) }
    h2.onUpdate { e2  -> emit(e2) }
}.collect { block(e1, e2) }

combine(handles.foo, handles.bar) { entity1, entity2 -> doStuff(entity1, entity2) }

Oh, that's really nice. I think I can tweak things here to support that pattern!

That's been a WIP PR because I haven't run the changes past the team yet, just experimenting.
Another thing I'm playing with is changing HandleMode to a sealed class, so that HandleManager can return a strongly typed result, e.g.
sealed class HandleMode<S<*>, C<*>> {
  object Read : HandleMode<ReadSingleton<*>, ReadCollection<*>>()
  object Write : HandleMode<WriteSingleton<*>, WriteCollection<*>>()
  object ReadWrite : HandleMode<ReadWriteSingleton<*>, ReadWriteCollection<*>>()
}

then
// the IDE will infer this as ReadSingletonHandle<RawEntity>
val handle = handleManager.rawSingletonEntityHandle(..., HandleMode.Read, ...)

because e.g.
fun <E, S, T> rawSingletonEntityHandle(..., HandleMode<S<E>, T<E>>, ...): S { ... }

So you get type checking and completion in IDE instead of just returning the base Handle

Oh, I'm looking forward to seeing the results of that!

I'm feeling pretty positive about these changes, so I'm cleaning things up and converting to a real PR

Yuan's demo needs to unhook callbacks, so I'm adding that functionality to this PR.


RC test: Natural Selection 1.3.0-rc.2

@KatieWoe, @kathy-phet, @amanda-phet natural-selection/1.3.0-rc.2 is ready for RC testing.
The publication deadline is 4/30/21, which is 2 days from now.
Document issues in https://github.com/phetsims/natural-selection/issues and link to this
issue.
This is a spot-check test for phet and phet-io brands.  See "Issues to Verify" for testing instructions.
Assigning to @kathy-phet and @KatieWoe for prioritization.

General RC Test

What to Test
This is a spot-check test.  In addition to whatever you typically do for a spot-check, it is sufficient to test only "Issues to Verify".

Issues to Verify

[ ] https://github.com/phetsims/natural-selection/issues/269
[ ] https://github.com/phetsims/natural-selection/issues/270

See the last comment in each issue for  instructions on how to verify.  It is sufficent to verify these issues on 1 platform of your choosing.
These issues are labeled "status:ready-for-qa". Check these issues off and close them if they are fixed.

Link(s)

Simulation
iFrame
XHTML

PhET-iO RC Test

What to Test
This is a spot-check test.  In addition to whatever you typically do for a spot-check, it is sufficient to test only "Issues to Verify".

Issues to Verify

[ ] https://github.com/phetsims/natural-selection/issues/259 @amanda-phet
[ ] https://github.com/phetsims/natural-selection/issues/273 @amanda-phet
[ ] https://github.com/phetsims/natural-selection/issues/271
[ ] https://github.com/phetsims/natural-selection/issues/272

See the last comment in each issue for  instructions on how to verify. It is sufficent to verify these issues on 1 platform of your choosing.
These issues are labeled "status:ready-for-qa". Check these issues off and close them if they are fixed.
Note that two of the above issues should be verified by @amanda-phet (as labeled, and assigned). These issues deal with changes to the PhET-iO Guide, and it will quicker for her to verify.

Link(s)

Wrapper Index

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

[ ] Win 10 Chrome (Time = )
[ ] Win 10 Firefox (Time = )
[ ] MacOS Safari (Time = )
[ ] MacOS Chrome (Time = )
[ ] ChromeOS (Time = )
[ ] iPadOS (Time = )

Spot-check is done

Thanks for the quick turnaround @KatieWoe and QA team.
Another RC spot-check coming up, to test the Diff Wrapper.
Closing.


Fix: Improve performance of get snapshots queries by using IN instead of AND/OR

ansi standard, we tested on a couple different common ones and they all have it


404 when deleting a menu item after deleting its BREAD

Laravel version
8.67
PHP version
7.4.3
Voyager version
1.5.1
Database
MySQL 8
Description
Getting a 404 when deleting a menu item after having deleted its BREAD
Steps to reproduce
Create a BREAD along with its menu item
Delete the BREAD
Go on to delete its menu item
Expected behavior
No 404
Screenshots
No response
Additional context
No response

try to run: php artisan clear:cache
For some reasons the menu items are cached


Bump up swift-nio version

This is needed due to conflicts while using Leaf with other Vapor packages.

This is technically a breaking change. You might have to depend on the Vapor 3 versions of Leaf to keep things compatible.
The latest version of Leaf is intended for use with Vapor 4, which depends on NIO 2

Yes Core is a Vapor 3 package, which is based upon NIO v1, so this wouldn't allow future fixes into Vapor 3. Will close


[Mac OS] add Android NDK 25

Description
Add Android NDK 25 to MacOS

Related issue:
https://github.com/actions/virtual-environments-internal/issues/4036
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run macos1015, macos11, macos12


Element ref was specified as a string (input) but no owner was set. You may have multiple copies of React loaded

Input 调用组件出错。由于旧版本在mac下编译出现问题，导致element-react/dist/npm/es5中的require没有被编译，找不到报错。所以升级了react(^16.1.1)、react-dom(16.1.1)、element-react(1.4.1)，跑起来后，浏览器报错。

"webpack": "^2.6.0"
"babel-polyfill": "^6.23.0",
"babel-core": "^6.25.0",
"babel-eslint": "^7.2.3",
"babel-loader": "^7.1.0",
node: v9.2.0

https://github.com/eleme/element-react/issues/626

恢复 React和React-dom的版本到 16.0.0解决了


cannot download file

afrer I use $page->pdf()
getting error
Protocol error (Page.printToPDF): PrintToPDF is not implemented in /Users/romanvladynskyi/Projects/fame10/scripts/SUS/vendor/nesk/rialto/src/ProcessSupervisor.php:307
Any ideas how to download file will be helpfull

if you call

$page->pdf(["path" => public_path('page.pdf')]);
response()->download(public_path("page.pdf"))->deleteFileAfterSend(true);

you should get the download response

See puppeteer/puppeteer#1829


fix dotenv-expand usage

This PR intends to fix the error found in issue #873

Closing this PR in favor of #880


Profile Page Redirect not Working

There are some issues in profile page so when we click on profile page it is not navigating us to profile page

hey @thestarsahil i need to fix this first in order to complete #1134


Comments on git-intro

While going through the git-intro, I felt that mentioning few additional things may be important. Perhaps, @Jyrsa  has already thought about them and is planning to discuss while lecturing.

Something about why sharing software and data is getting more popular in research context and github being a popular platform for sharing software
Why Git over other VCS? Difference between Distributed VCS and centralized VCS? Radovan is talking about Distributed VCS in the advanced session, but in my opinion it may be helpful to briefly mention about distributed VCS in the introduction session.
Mentioning difference between master and Head? I noticed that people often confuse about master and head.

Typos:
Have you ever had to start working software written by others? --> Have you ever had to start working on software written by others?
You can avoid using one one by always passing messages on the command line, but that limits you in the long run --> You can avoid using one by always passing messages on the command line, but that limits you in the long run.

Good points. For typos I recommend to file PRs directly.
As to centralized/distributed: You can mention that distributed gives more flexibility to delegate quality control and also allows external contributions from people without write access.


Improve geocoder

Adresses parts of #1262.

Support for custom geocoders
Support for automatic suggestions

Something I haven't quite decided on is whether there should be different methods for getting geocoder search suggestions and the actual geocoding. This would be necessary if a certain service has different API endpoints for this, or if they otherwise need to be handled differently. It would probably be better to keep this separate.
A custom geocoder is expected to look like:
{
    geocode: function(query) {...},
    getSuggestions: function(query) {...} // Currently not used -- should we have this?
}

The default geocoder in Cesium remains largely unchanged in this PR.
I've marked the GeocoderViewModel properties key and url for deprecation. I think these don't make sense to expose as public properties since they are implementation details (and may not exist) of the custom geocoder provided.

I've marked the GeocoderViewModel properties key and url for deprecation.

Please submit an issue for this: https://github.com/AnalyticalGraphicsInc/cesium/tree/master/Documentation/Contributors/CodingGuide#deprecation-and-breaking-changes

@erikmaarten this is a great start, but I think there are a few changes we can make here to improve the API.

Create an GeocoderService interface that describes the properties and functions needed by a custom geocoding service (Feel free to use a better name if you can think of one.  Unfortunately we're already using Geocoder for the widget name.)  For example, here is the interface we created to describe an ImageryProvider: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Scene/ImageryProvider.js
Create BingMapsGeocoderService to abstract the bing maps geocoder functionality out of GeocoderViewModel
Make GeocoderViewModel take an optional GeocoderService parameter.  If none is specified, use new BingMapsGeocoderService()
Possibly create OpenStreetMapGeocoderService using the functionality from your sandcastle example, then update the sandcastle example to pretty much be viewer.geocoder.geocoderService = new OpenStreetMapGeocoderService()

This will make it really easy to plug in different services in the future.  For example, I know people on the forum were asking how to use the Mapbox geocoder as well.  We could eventually add MapboxGeocoderService to make it easy for users to plug that in instead.  This would also make it brainless to switch the default in case we ever decide to stop using Bing.
Also, if you could, it would be better to make the custom geocoder changes and the autocomplete changes in separate PRs so we can review each individually

@hpinkos Ready for review.

Update the doc for Geocoder since it pipes the GeocoderService param through to the GeocoderViewModel

Those are all the comments I have for now

@hpinkos Review comments addressed.

Just those comments from me.

@pjcozzi @hpinkos This is ready.
I removed the Nominatim geocoder from Core and put it into a Sandcastle example. It would be easy to move this to core but it would likely violate the usage policy of Nominatim which is fairly restrictive.

Thanks @erikmaarten!
@hpinkos can you please do the final review and merge?

@erikmaarten For Cesium widgets, we use the knockout es5 plugin so observables look like regular javascript properties.  I just pushed a commit to convert your observables to knockout es5 properties instead.  I also rate limited the search box update for autocomplete and fixed a few odds and ends with when to show the suggestions when autocomplete is enabled.
Since I made significant code changes, @mramato can you do a quick review?

Thanks @hpinkos. (I found the removed displayName property in two more places, the custom Geocoder and the Bing Maps one, so I removed them.)

We need a screenshot for the Sandcastle example (even if it's basically just the viewer with autocomplete open

I found an issue:

Type Bird's Nest into the geocoder, this will pop up several options.
Click on the second one (in China)
The complete address will get filled in and the flight will happen, but the autocomplete pop-up will stay up with the single returned result.

I'll look into this

Is there a reason Bing autocomplete defaults false?
It looks like we never autocomplete until typing stops, but shouldn't we also do it after something like 500ms even if they are still typing?  Otherwise it's possible that they won't even realize autocomplete is available.  I think that's how these systems normally work.

I defaulted Bing to autocomplete=true locally, but when I test it in Viewer the styling is wrong, the text is black in the autocomplete dialog.

I think that's everything I have for this go around.  You did an awesome job here @erikmaarten!

@mramato ready for another review.  I fix the problem you found, and also re-did the way the GeocoderViewModel was handling the promises for multiple geocoders.  Instead of running geocoderService.geocode on each geocoder service, it treats it like a priority queue.  It keeps asking down the chain until one of the geocoders returns a successful result.
@erikmaarten you should review the changes I made in https://github.com/AnalyticalGraphicsInc/cesium/pull/4723/commits/f10c75f3d99d5a6966e3bb4ccca379fcb0c703ea with regards to promises to see how I changed them together.  Your use of when.all and creating an extra when.defer wasn't necessary, especially since in your last then you were just taking the first result returned.

Thanks @mramato for reviewing.
@hpinkos that's a nice refactor, but the functionality is not what I intended, if I'm reading the code correctly. It's good to avoid superfluous requests, but now users will be forced to wait for requests to start and fail in turn. If a more specifically scoped geocoder (like a geocoder with radio station codes as mentioned in the forums) is higher in priority, which I think would be normal, than a general geocoder, then users of that app would often have to wait for one extra network request (slow in the context of users interacting with the geocoder search bar), or more if more geocoders are used.
So while it makes technical sense to avoid requests that aren't necessary, doing the extra network requests upfront makes for better UX. A middle ground might also be sensible if we anticipate large numbers of geocoders in the same app: chaining the requests, but with chunks of five requests each time or something like that.

Is this ready?  If we want to ship this in 1.29, we should merge it this week.

@mramato had some comments on the interface design that I've replied to, and @hpinkos asked him for a follow-up review of the last changes, but since he's out for the holidays we won't be able to get any updates from him there.
@hpinkos have you seen my comments? Would like to hear what you think. Also, since my comments don't affect the interface, we could just settle with the current functionality and see how people actually use and then adapt to that.

It's good to avoid superfluous requests, but now users will be forced to wait for requests to start and fail in turn

I get what you're saying here.  I did make it a bit more synchronous by waiting for the previous call to complete before making the next one.  I was thinking the first one would often be the geocode that we ended up using, so I didn't see the point of making calls to the other geocoders and waiting for them all to either resolve or fail.
I'm really not sure which is best, so I'll wait to hear what @mramato thinks before changing things more

What is the plan with this pull request?

@mramato can you take a look at this?

On my list for later today.

Start the Cesium Viewer
Click on the magnifying glass (not the text box, just the icon part)
Start typing and autocomplete doesn't trigger.

If you click inside the text field at any point, autocomplete starts to work as expected.

Thanks again @erikmaarten, I don't want to bikeshed this too much since it clearly works well (except in the couple cases I mentioned).  Once my last round of comments are addressed we can merge this up to master.

@erikmaarten I'll take care of cleaning this up

@mramato ready

Thanks @hpinkos for taking care of this.
@mramato do you have any opinion on https://github.com/AnalyticalGraphicsInc/cesium/pull/4723#issuecomment-267757101?
I updated the release numbers here to deprecate those properties in 1.30 and remove them in 1.31 since we didn't make it in time for the 1.29 release. Also update the deprecation issue.

Thanks @hpinkos for taking care of this.
@mramato do you have any opinion on #4723 (comment)?
I updated the release numbers here to deprecate those properties in 1.30 and remove them in 1.31 since we didn't make it in time for the 1.29 release. I also updated the deprecation issue.

Ultimately, I think the use of multiple geocoders will be uncommon, so the point is probably moot.  However, I agree that having a slow geocoder first could end up slowing down the entire operation in that use case, so firing multiple requests and letting the first one that returns "win" may be a good idea.
We should probably also make the limit of 5 an option in the view model so that users can allow more returns if desired.
I'm going to merge this as-is for now since it's in good shape, but if you (@erikmaarten) want to open another PR right away to add back the gecode "race" then we'll merge that too (and it will be easier to review since it will be a smaller change).
Thanks again!


SharingController's Delegate Not Being Called?

I could be doing something wrong but attempting to customize item title doesn't seem to work, nor does the delegate seem to be called in CloudSharingView as my print statement below isn't printing.
  struct CloudSharingView: UIViewControllerRepresentable {

  // MARK: - Properties

  @Environment(\.presentationMode) var presentationMode
  let container: CKContainer
  let share: CKShare

  // MARK: - UIViewControllerRepresentable

  func updateUIViewController(_ uiViewController: UIViewControllerType, context: Context) {}

  func makeUIViewController(context: Context) -> some UIViewController {
      let sharingController = UICloudSharingController(share: share, container: container)
      sharingController.availablePermissions = [.allowReadWrite, .allowPrivate]
      sharingController.delegate = context.coordinator
      return sharingController
  }

  func makeCoordinator() -> CloudSharingView.Coordinator {
      Coordinator()
  }

  final class Coordinator: NSObject, UICloudSharingControllerDelegate {
      func cloudSharingController(_ csc: UICloudSharingController, failedToSaveShareWithError error: Error) {
          debugPrint("Error saving share: \(error)")
      }

      func itemTitle(for csc: UICloudSharingController) -> String? {
          print("is this called?")
          return "Test 1234"
      }
  }
}

Hi @gesabo ! As per the itemTitle(for:) documentation, that function is only called when creating a new share. Since we create the CKShare first and using the .init(share:container:) initializer, this is never actually called in this example.

Closing this as I believe the above has answered your question, but please re-open if you need further info. Thanks!


When TARGET is unset, it doesn't default to /home/username

https://github.com/easingthemes/ssh-deploy/blob/85987f45673377acac05c68558e18e5d4d0bcfec/src/inputs.js#L14
Somehow if TARGET is not set, it'll try to rsync into /home/REMOTE_USER, looks like that L14 fails to obtain the proper value.  Tested this on all versions of this action.  Once I've set TARGET: /home/${{ secrets.AWS_EC2_SSH_USERNAME }} in my YAML file, everything worked.

Fixed in v4.1.1.


Update developer guide pages for performance and binary data usage

Coverage remained the same at 60.087% when pulling 6e298c335ce395805de4a7fba71a3e1956f08b3b on developer-guide-update into a46aac7fe545a1b5948bd3c48b0467569e98fea0 on master.


Add label to logo on mobile

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2273
Originally created by @DouweM on 2020-08-17 21:17:43

View 5 previous comments from the original issue on GitLab


[Extensibility Enhancement] Page 113 Budget Filters should be editable

Business Central stores only the latest filter value in this page. If you use multiple budgets, with different filters you have to change the filters every time you change the budget.
The Filters

DateFilter
GLAccFilter
GLAccCategoryFilter
IncomeBalanceGLAccFilter
GlobalDim1Filter
GlobalDim2Filter
BudgetDim1Filter
BudgetDim2Filter
BudgetDim3Filter
BudgetDim4Filter

are defined in the OnOpenPage Trigger in Page 113 Budget.
Only the GLAccFilter is editable from external.
All other filters should be definable from external too.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Infinite scroll pagination

Hi,
Context: I've evaluated the new Google paging library and while it's nice it is very hard to customise / insert items arbitrarily.
Disclaimer: I don't want a complete answer or demo I'd rather start a discussion about functionality/limitation of flexible adapter. 😄
I need to build the following :

Infinite scroll of X + every 10 X a Y element.
Y is a banner like element, not returned by API
Scroll bar reflect the total elements and not loaded elements are placeholders so user can jump to any part of the data.
When user scroll over a chuck of placeholder, load data and replace placeholders
Place holder can be FlexibleItems with bind(null)

What I have :

Total count is known
Api is positional (load item at page X is independent of previous or next page) and flexible

Is this possible to have this kind of behaviour with flexible adapter ? (the important part for me is the placeholder thing and scroll). If so, what strategy would you use to represent the chucks of data (I'm think about sections but is this really the way to go ?)  ?

@AlexisQapa, regarding the infinite scroll, it does a specific work: it loads new items from repository to append to the list, so the adapter doesn't know them!
To show the content in the items you have to manage the binding, but that is automatic as soon as the item is going to be shown.
Placeholders for text you need to do something similar for images when you download them, you need to link the repository to the items if the text isn't already loaded. But as said before you need to know the item identification first, so the item as placeholder must be added to the list.
You know that as soon as you scroll and the item is partially or temporarily visible, it loads everything in that item.
Y element as banner is your problem only.

Ok after thinking about it another time it's not infinite scroll as I already know the items count.
What I want is to pass a list with nullable items to the adapter and to get a callback when a null item will be requested so I can lazy load it. My list won't grow and user can scroll to the end before any item is loaded.

Items themselves can't be null! As said they must have an unique identifier (non null as well) otherwise you don't know what are you going to load and show.
The others fields can be null.
The bindView method is already a callback, you just need to pass the repository instance to each item at the creation. It's a bit strange however.

This means that if I have a list of 40k items I need to initialise a list of 40k placeholders. Even if they are minimalistic it's a memory cost. I made an abstract list that work the way I want. It works with a classic DiffUtil adapter + a updateCallback which reload loaded rows.
Here is a simpler version of my list :
class MyPagedList(val service: QapaAPI, private val updateCallBack: (from: Int, to: Int) -> Unit) : AbstractList() {
init {
    launch(UI) {
        delay(2)    // Delai after init so vars are initialized
        loadPage(0) // force load the first page so we get the total items count
    }
}

private val pageSize = 30
private var itemsCount = 0
private var pageCount = 0
private var storage: MutableMap<Int, Page> = emptyMap<Int, Page>().toMutableMap()

// List implementation :
override val size: Int get() = itemsCount

override fun get(index: Int): Recyclable {
    val pageIndex = index / pageSize
    val itemIndex = index % pageSize
    val storedPage = storage[pageIndex]
    loadAround(index)
    return when (storedPage) {
        is LoadedPage -> storedPage.data[itemIndex]
        is LoadingPage -> PlaceHolderItem()
        else -> {
            loadPage(pageIndex)
            PlaceHolderItem()
        }
    }
}

// Helpers
private fun loadAround(index: Int) {
    val indexWithOffset = index + pageSize / 2
    val pageIndex = indexWithOffset / pageSize
    loadPage(pageIndex)
}

private fun loadPage(pageIndex: Int) {
    if (pageIndex in 0..pageCount && storage[pageIndex] !is LoadedPage && storage[pageIndex] !is LoadingPage) {
        storage[pageIndex] = LoadingPage()
        launch(CommonPool) {
            try {
                val response = with(search) {
                    service.getData(pageIndex * pageSize, pageSize).execute()
                }
                val model = response.body()?.toModel()
                if (response.isSuccessful && model != null) {
                    if (pageIndex == 0) {
                        itemsCount = model.metadata.totalItems
                        pageCount = model.metadata.pageCount
                    }
                    storage[pageIndex] = LoadedPage(model.results)
                    val startIndex = pageIndex * pageSize
                    updateCallBack(startIndex, startIndex + pageSize)
                } else {
                    throw Error(response.message())
                }
            } catch (t: Throwable) {
                storage[pageIndex] = ErrorPage()
                Timber.e(t)
            }
        }
    }
}

}
Here is the page definition :
sealed class Page
class LoadingPage : Page()
class ErrorPage : Page()
class LoadedPage(val data: List) : Page()
You said with FlexibleAdapter I can't have nullable items so I made my list not nullable (I return a placeholder item), but I present a list that seems to be of the size of the complete data without loading in memory placeholder nor data. Could this work with your adapter ?

@davideas the whole goal of this is to have a perfect smooth scroll all the way to the bottom of the data and / or be able to jump to the middle with a fastscroller.

40K items in a small device? you need a filter and / or endless scrolling.
That number is not manageable by human eyes, which we all have to deal with, anyway.
I would put a local database, and if the element is not available you load it from remote. The repository should do that logic.
I didn't read the code, sorry. I can't help more: we are asking architecture consultancy.

I am sorry, I didn't wanted to take too much of your time. I wasn't asking for architecture help. The issue with the load more pattern is that user doesn't know where he is in the data as the data grows as the user scroll. Etsy engineering team wrote a nice article about cons of this pattern.
My lazy list is working with another adapter and I think the issue is that FlexibleAdapter use a copy of the list and not the one given in the init. I'll continue working on this and provide a working example if you are interested. This would enable using fastscroller and so on paginated data.
Again sorry I asked much


Added RAM Free memory to Linux/Windows

Does not build on Windows and MacOS. To fix this, please implement the getFreeAvailableMemory within src/windows/ram.cpp and src/apple/ram.cpp aswell and just return -1.
Also please rename the method to getFreeMemory. Free and Available kind of are the same


Bitcode

Rebased and ready to merge.

Although this seems to be merged, it is not possible to use tesseract with bitcode
ld: -weak_library and -bitcode_bundle (Xcode setting ENABLE_BITCODE=YES) cannot be used together


Explicit check of chainerx arrays on fallback functions

We don't allow numpy or cupy arrays to reach fallback functions on chainer x, and we also forbid advanced indexing of chainerx arrays using numpy or cupy arrays.
The behavior is according to the following code:
x = chx.array([[0., 1., 2.], [3., 4., 5.]],dtype=chx.float32,device='cuda:0')
xnp = np.array([[0., 1., 2.], [3., 4., 5.]])
x_i = (chx.array([1],device='cuda:0'),)
x_inp = np.array([1])
x_icp = cp.array([1])
x_tup = ([1],)
print(chx.fix(x)) #ALLOWED
print(chx.fix(xnp)) #TYPE ERROR
print('CX ',x[x_i]) #ALLOWED
print('NP ',x[x_inp])#TYPE ERROR
print('CP ',x[x_icp])#TYPE ERROR
print('TU ',x[x_tup])#ALLOWED

Thanks for the fix.
Jenkins, test this please

Jenkins CI test (for commit 531b7272ccf280f2e5db741c1357833616b5a309, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit 531b7272ccf280f2e5db741c1357833616b5a309, target branch master) succeeded!

LGTM


$fetch 'DELETE': 500 (Internal Server Error)

Environment
Nitro 2.9.4
Reproduction
$fetch('/api/web/images/del/123456', {method: 'DELETE'})
Describe the bug
nuxt.config.ts
routeRules: {
  '/api/**': {
    proxy: 'http://<IP_ADDRESS>:3600/api/**'
  }
}

DeleteImageModal.vue
$fetch('/api/web/images/del/123456', {method: 'DELETE'})

This issue only occurs with 'DELETE' requests.
Additional context
No response
Logs
# browser console output:
catch FetchError: [DELETE] "/api/web/images/del/123456": 500 Internal Server Error
    at async $fetch22 (ofetch.37386b05.mjs:268:15)

# Nuxt3 console:
 ERROR  [nuxt] [request error] [unhandled] [500] fetch failed
  at Object.fetch (node:internal/deps/undici/undici:11372:11)
  at async sendProxy (./node_modules/h3/dist/index.mjs:1157:20)
  at async ./node_modules/h3/dist/index.mjs:1962:19
  at async Object.callAsync (./node_modules/unctx/dist/index.mjs:72:16)
  at async Server.toNodeHandle (./node_modules/h3/dist/index.mjs:2249:7)

Upgrading to 2.9.6 is no problem now.


Deal with infrequent error message complaining that resource already exists

Issue
We saw a failure in this bara:
[Fail] revisions deployment when there is a new droplet [It] creates a new revision
/go/src/github.com/cloudfoundry/capi-bara-tests/baras/revisions.go:412

with error message:
[2019-03-06 21:24:22.48 (UTC)]> cf curl /v3/deployments -X POST -d {"relationships": {"app": {"data": {"guid": "ca6a20af-a696-488a-97eb-93e2767285af"}}}}
{
   "errors": [
      {
         "detail": "Runner error: Process Guid: 61c34bfd-9649-47ba-86d0-68d968e62f28: the requested resource already exists",
         "title": "CF-RunnerError",
         "code": 170016
      }
   ]
}

Also reported by https://cloudfoundry.slack.com/archives/C07C04W4Q/p1551201149087000
Context
This is triggered from the process_observer. Maybe in between the time the change was
made to create the process and the desire_app call was made, the process_sync job
was triggered and created the app. It's likey this error can be ignored.
Steps to Reproduce
Make a temporary change in the code to have the process observer sleep for a few seconds before continuing
Expected result
We should never see this error message if it is in fact bogus
Current result
hard to predict when this happens

Could we get a full traceback? There are at least two points in the code where this could happen, but "requested resource already exists" isn't specific enough.

(with @sethboyles): Thank you for reporting this, we've replicated the bug and it is another occurrence of a problem we've been seeing in CI. Being tracked at https://www.pivotaltracker.com/n/projects/966314/stories/167495930

@nrxus do you still see this after using capi-release versions 1.85.x+?


.gemrelease doesn't work with key and host

running gem build followed by gem push --key foo --host http://foo.host/private works.
However with a .gemrelease
release:
  key: foo
  host: http://foo.host/private

Running gem release fails, with a 401 from my gem server:
...
Pushing gem to http://foo.host/private...
Authorization key is invalid
...
Tasks: TOP => release => release:rubygem_push

Are host and key not designed to work in this manner? Documentation leads me to believe they are.

Thanks for the report, @eprothro, and sorry for not following up on this earlier.
I believe your issue should be addressed in 2.0.0.pre.1, see https://github.com/svenfuchs/gem-release/pull/64
Specifically, there's now more flexibility in configuring gem-release. And things are tested better. See https://github.com/svenfuchs/gem-release/tree/sf-v2#configuration for configuration options.
I believe in your case it should be sufficient to use:
# top level keys, apply to all commands
key: foo
host: http://foo.host/private

or
export GEM_RELEASE_KEY=foo
export GEM_RELEASE_HOST=http://foo.host/private

I am going to close this here. Please let me know if things do not work as expected.
❤

Thanks @svenfuchs! I'll check it out and get back to you here if there's an issue.


Modify ACL routes

Coverage remained the same at 26.891% when pulling 5f31f98035c0d04a97c855938948eb7ee53ab4d7 on alyiwang:master into 2ce34407c318596cb4d42efb9ada1cc6ca5f925e on linkedin:master.

Codecov Report

Merging #1025 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   29.77%   29.77%
=======================================
  Files         174      174
  Lines        4634     4634
  Branches     1220     1220
=======================================
  Hits         1380     1380
  Misses       3254     3254

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce3440...5f31f98. Read the comment docs.


Use Maybe a for vector and matrix products to improve runtime and space complexity

Hi,
I've made a simple modification in the way vector-vector, matrix-vector, and matrix-matrix products are computed.
The basic change is that IntMapUtilities.(··) returns Nothing for zero values and Just v for all other values. This way we can use IntMap.mapMaybe to process only the nonzero values. Furthermore, we can use the same idea to remove empty rows in matrix-matrix multiplications directly without filtering (for which I added the utility function IntMapUtilities.(···)).
This has two advantages:

Memory complexity: We don't create a lot of zero values or empty rows we wil never use.
Time complexity: We don't have to filter all the unwanted zeros and empty rows.

Hi @mnick! Nice idea! Thanks for the contribution :+1:
I'll take a look at the code this weekend and merge this.
Could you also integrate your benchmarking code in the tests?

I will integrate the benchmark into the tests.
One thing I noticed since proposing the changes is that GHC doesn't automatically parallelize as well when using M.mapMaybe instead of M.map.
I still get the better runtime performance, but this might be something to consider before merging the changes.

Hey @mnick, what do you mean about GHC not automatically parallelizing? What are you using to achieve parallelization? Have you understood this any better?
I am testing your changes with some code I'm writing now. Will try parallel / single-threaded alternatives.


Add Windows 2019 test builders to CI

We should check that Windows 2019 works with some known MinGW builds to help with issues like this:

https://github.com/microsoft/go/issues/1081

We should document what combination(s) we're testing, which we recommend, and how to get them.
Ideally we should also provide a script/command to check which MinGW version is actually being used, to diagnose in CI and locally without guesswork. I imagine I'll be making a tool to run in our CI to download several known versions of MinGW, so perhaps that could be shared to also use in CI to avoid depending on whatever the image provider includes.

Windows Server 2019 has reached EOL on January 9th. We will add 2025 builders to the CI once they become EA


MAIN B-20808

Agility ticket
Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the
Login as a

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

:warning:
This PR does not include changes to storybook, even though it affects component code.

  Generated by :no_entry_sign: dangerJS against fb67b258a3ca6c1a140f803b742a5c2a3e550160

Test coverage on client failed.
Last run: Tue 22 Oct 2024 04:00:35 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

Test coverage on client failed.
Last run: Thu 24 Oct 2024 08:13:48 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

Wrong int pr linked, correct one is here https://github.com/transcom/mymove/pull/13994/commits
Commits are good, only diffs are merge conflicts and cherry-pick sha's 90a0ab2 38988d7 ee32d71

Ooph. Coffee isn't working this morning - fixed the link. Thanks!


track user creation stats (keen.io)

was: Add stats back in as #4 on the all projects menu.
now: using keen.io

We’ve rolled out keen.io analytics on edge and staging.  We should test to make sure we’re happy, and it’s stable, before rolling out to production instances.


API Improvements

For #332
Adds new serializers/endpoints to make it easier to perform a search and go straight to downloading data
This splits up the geodata endpoints into three new tags:

geodata: for accessing models via serializer and downloading raw data
geosearch: for performing searches against data in the catalog
geoprocess: for performing operations on data in the catalog (e.g. subsampling, COG conversion, tiling)

I updated the demo notebook (demos/GeoData-API.ipynb) to show what is now possible - this is a developer's demo and not intended to be shown externally. @AlmightyYakob, this should be everything needed to proceed with #332

I appear to get an off-by-one error when comparing the subentry_pk and detail fields of a geosearch result. Example:
      ...
      "subentry_type": "RasterMetaEntry",
      "subentry_pk": 7,
      "subentry_name": "20091021202517-01000100-VIS_0001.ntf",
      "detail": "http://localhost:8000/api/geodata/imagery/raster_entry/6"

Notice how subentry_pk is 7, while the raster entry referenced in detail has a pk of 6.

Is this due to the difference between RasterEntry and RasterMetaEntry?

Yes, the spatial entry type is RasterMetaEntry and the "detail" link points to RasterEntry.
I will fix this

Good catch

Now the SpatialEntry serializer points directly to RasterMetaEntry and that serializer holds the RasterEntry to avoid confusion on the client side. This is consistent with our approach for ImgeFile/ImageEntry, GeometryArchive/GeometryEntry, and FMVFile/FMVEntry.
The following are subtypes of SpatialEntry and accessible via the API: FMVEntry, GeometryEntry, and RasterMetaEntry
The following are prerequisite, user-generated models for the above (respectfully): FMVFile, GeometryArchive and RasterEntry
Each of the "prerequisite" models are serialized under the spatial entry subtypes and not directly accessible via the API. At a later time, we can expose POST endpoints for these models nut not GET.
The naming choice for RasterMetaEntry/RasterEntry is a bit confusing/inconsistent with the other models but the logic is the same.


add loading overlay to all the things

Overview
from @msorens in #2331

Based on the pattern you have applied--replacing  for page-loading events--I believe the following pages should also be updated to this new mechanism (though should double-check with SuperTeam):
-- client-runs-table.component.html
-- profile-overview.component.html
-- reporting-controls.component.html
-- reporting-nodes.component.html
-- reporting-profiles.component.html
-- jobs-list.component.html
-- job-list.component.html
-- nodes-list.component.html
-- data-feed-form.component.html
-- integrations-add.component.html
-- integrations-edit.component.html
-- integrations-list.component.html
-- notification-form.component.html

this work has been deprioritized, so closing.


--fix does not cope with @use scopes.

Using the information gathered about scopes on parsing a file apply a scope to fixes.

Complete with v2.1.0


Fix response hijacking with TLS enabled.

Vendors engine-api 0.2.2
Fixes #19280

ping @tiibor @cpuguy83 for review :+1:

LGTM

LGTM

Merging, failures are unrelated.


Add support for reading volt or ampere

Hi,
Thanks for a great library!
I have made some extensions that I think might also help other users of the Python wrapper.
The Monarco supports reading either Volt or Ampere via the analog inputs. Switching between the two involves sending commands via the SDC to flip a resistor. This commit allows the user to control this when the library is initiated.
The default configuration is to measure Volt on both ain1 and ain2. The change should therefore not make any difference for existing users.
The commit has been tested against a controlled ampere and voltage source to make sure the measurements are correct even with the change.
This commit does not require any changes to the C library.

Thank you so much for this! Did not know that the Monarco also can measure current, I will merge this as soon as I have tested it on my setup :)

Hi @bjarnekvae,
I just stumbled across this old very PR - completely forgot about it. I no longer use the Monarco and don't really remember what the change does.
You are welcome to just close this PR if you want. No reason to merge it for my sake.

Thank you for the heads up! I have also stopped using the Monarco HAT as I do not have any relevant projects at the moment. I will however keep this PR so when I need to use the Monarco again I can merge your code.
Cheers!


System.ArgumentNullException: Value cannot be null in Windows Phone 8 store app.

Hi,
I am using Humanizer in one of my projects to humanizer TimeSpan and I see this error at a rate of 1000 instances per day. Can you please take a look?
Thanks.
System.ArgumentNullException: Value cannot be null.
Parameter name: format
at System.String.Format(String format, Object[] args)
at Humanizer.Localisation.Formatters.DefaultFormatter.Format(String resourceKey, Int32 number)
at Humanizer.Localisation.Formatters.DefaultFormatter.GetResourceForTimeSpan(TimeUnit unit, Int32 count)
at Humanizer.Localisation.Formatters.DefaultFormatter.TimeSpanHumanize(TimeUnit timeUnit, Int32 unit)
at Humanizer.TimeSpanHumanizeExtensions.GetTimePart(TimeSpan timespan, CultureInfo culture)
at Humanizer.TimeSpanHumanizeExtensions.Humanize(TimeSpan timeSpan, Int32 precision, CultureInfo culture)
at Flashlight.MainPage.SetBatteryText(Int32 remainingChargePercent, TimeSpan remainingDischargeTime)

Thanks for reporting @yenelcs
This is the first time I see this error and it's quite strange. What locale are you using and what are the TimeUnit and the count that cause this error? Would you please be able to send us a repro file/project?

@MehdiK Unfortunately I don't have a repro project. It happens on production. All I try to do is Humanize a timespan structure with count = 2. Some locale that this error happening are: Romanian (Romania), Czech (Czech Republic), Romanian (Romania), English (United Kingdom), Serbian (Latin, Serbia), Slovak (Slovakia), English (United States), Romanian (Romania). Top 3 locale are Serbian (Latin, Serbia), Romanian (Romania) and Slovak (Slovakia).
Thanks,

@MehdiK TimeSpanHumanize_MultipleMilliseconds is missing in the resources. Could it be the reason?

Hmmm, that's interesting and most likely the cause of the problem. Which resources file was missing the entries?

Default one = English.

Would you please be able to update to the latest and see if the problem persists?

I updated the Humanizer from nuget to version 1.32. This issue still happens but number of exceptions per day dropped ~%90 which is good. However there might be some entries in the code that are being used but not present in the resources.

Thanks for the update. It's a shame some of the resources are missing. Would you be able to dig further to see what resources might be missing so we can add them back in please? Thanks.

Ok, I will try.

Awesome. Thanks a lot. Would you be able to send a PR with missing keys please?
It would also be very beneficial to have a unit test that verifies the keys to avoid missing keys in the future.

First commit to GitHub, I think that I made a mistake… Can someone please help me to fix? Sorry.

This should hopefully be fixed by #446. Will release soon.


show PasswordBox content

I use PasswordBox control in my login form.
but i dont able to show it`s content
i use PasswordChar = '\0'; not work Correctly
does Material Design have tools for show password box characters ?

@omp-git You can show a Password in clear text with the MetroButtonRevealedPasswordBox or Win8MetroPasswordBox style.

Hey - I'm trying to use the 'MetroButtonRevealedPasswordBox' and can insert it no problem. However, when clicking on the eye to reveal, the "stars" are still showing...

Tried on 2 diff computers but same issue.
Nothing special in my XAML code, just 'Watermarks' and 'ClearTextButton'
Thanks

@punker76 I'm using MahApps 1.6.5 and my project is on .NET Framework 4.5.2

@VeronicaGeek Can you show me your Xaml code for the password box? I tested it with the following lines and doesn't see this issue:
<PasswordBox Controls:TextBoxHelper.ClearTextButton="True"
             Controls:TextBoxHelper.Watermark="Revealed PasswordBox"
             Style="{StaticResource MetroButtonRevealedPasswordBox}" />

@punker76  Sure
<PasswordBox x:Name="AdminPwdTextbox" HorizontalAlignment="Left" Margin="1505,50,-1435,0" VerticalAlignment="Top" Width="230"  Controls:TextBoxHelper.Watermark="Enter your Global Admin password" Controls:TextBoxHelper.ClearTextButton="True" Style="{StaticResource MetroButtonRevealedPasswordBox}" Height="21" PasswordChar="*"/>

Is it possible to keep password visible (cleartext) without press the "eye button" ?

@GreatFireWall,
please ask questions like this in the future on gitter or StackOverflow.
You can override the Style (get it here: https://github.com/MahApps/MahApps.Metro/blob/develop/src/MahApps.Metro/Styles/Controls.PasswordBox.xaml ) to match your needs. But I think this is not what a PasswordBox should do
Happy coding
Tim

RevealButtonContentTemplate is this property can we use in Dot net Core 3.0 ?

Hi @Vishal708 ,
yes you can use this Style but in the latest pre-release (which you need to target .NET Core3.x) the Key changed to MahApps.Styles.PasswordBox.ButtonRevealed
See:  https://github.com/MahApps/MahApps.Metro/blob/00c221bbc57fda4f9d48cce486eee9425d4b6b0c/src/MahApps.Metro/Styles/Controls.PasswordBox.xaml#L577
Happy coding
Tim


feat: playground

Please describe the changes this PR makes and why it should be merged:
Status

[ ] Code changes have been tested against prettier, or there are no code changes
[ ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 37.323%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
822

Relevant Lines:
2317

💛  - Coveralls

Yo, this can be merged too, right? After all the conflicts have been resolved.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 5 committers have signed the CLA.:x: aidenybai:x: SoonIter:x: GuiBibeau:x: ethanniser:x: brunoeduardodevYou have signed the CLA already but the status is still pending? Let us recheck it.

@aidenybai , the merge conflicts in this repo hasn't been fixed
could you consider fixing them so it can be merged or it can be closed


[Usage]: convert llava-v1.5-7b to liuhaotian/llava-v1.5-7b-hf format

Your current environment
Collecting environment information...
PyTorch version: 2.1.2+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 20.04.6 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.31

Python version: 3.11.4 (main, Jul  5 2023, 13:45:01) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.15.0-91-generic-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: 12.2.91
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA A100-SXM4-80GB
Nvidia driver version: 535.129.03
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_precompiled.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_runtime_compiled.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_graph.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_heuristic.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops.so.9.0.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
架构：                              x86_64
CPU 运行模式：                      32-bit, 64-bit
字节序：                            Little Endian
Address sizes:                      46 bits physical, 48 bits virtual
CPU:                                80
在线 CPU 列表：                     0-79
每个核的线程数：                    2
每个座的核数：                      20
座：                                2
NUMA 节点：                         2
厂商 ID：                           GenuineIntel
CPU 系列：                          6
型号：                              85
型号名称：                          Intel(R) Xeon(R) Gold 6133 CPU @ 2.50GHz
步进：                              4
CPU MHz：                           1068.607
CPU 最大 MHz：                      3000.0000
CPU 最小 MHz：                      1000.0000
BogoMIPS：                          5000.00
虚拟化：                            VT-x
L1d 缓存：                          1.3 MiB
L1i 缓存：                          1.3 MiB
L2 缓存：                           40 MiB
L3 缓存：                           55 MiB
NUMA 节点0 CPU：                    0-19,40-59
NUMA 节点1 CPU：                    20-39,60-79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit:        KVM: Mitigation: VMX disabled
Vulnerability L1tf:                 Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds:                  Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown:             Mitigation; PTI
Vulnerability Mmio stale data:      Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed:             Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; IBRS, IBPB conditional, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Mitigation; Clear CPU buffers; SMT vulnerable
标记：                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts pku ospke md_clear flush_l1d arch_capabilities

Versions of relevant libraries:
[pip3] numpy==1.26.3
[pip3] nvidia-nccl-cu12==2.18.1
[pip3] torch==2.1.2
[pip3] torchvision==0.16.2
[pip3] triton==2.1.0
[conda] numpy                     1.26.3                   pypi_0    pypi
[conda] nvidia-nccl-cu12          2.18.1                   pypi_0    pypi
[conda] torch                     2.1.2                    pypi_0    pypi
[conda] torchvision               0.16.2                   pypi_0    pypi
[conda] triton                    2.1.0                    pypi_0    pypiROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: N/A
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      20-39,60-79     1               N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

How would you like to use vllm
Thank you for your outstanding work. I recently fine-tuned the Llava model based on the liuhaotian/llava-v1.5-7b model. Now, I want to adapt the Llava model using the VLLM framework to improve inference speed. I found that VLLM uses files in the format of llava-v1.5-7b-hf. I want to know how to convert my fine-tuned Llava-v1.5-7b model to the llava-v1.5-7b-hf format. Because if I directly load the Llava-v1.5-7b model using VLLM, I will get an error saying "Model architectures ['LlavaLlamaForCausalLM'] are not supported for now". So I must do the conversion. I want to know how the llava-v1.5-7b-hf format is obtained.

Try using this script.

Thank you for your reply. I'll give it a try later. If successful, I'll update the instructions here

It works, thanks.


Sam Coe Dialogue Typo

When not selecting a dialogue option whilst talking to Sam Coe, there's a typo in the subtitles for one of his lines.

Details
When not selecting a dialogue option whilst talking to Sam Coe, one of his lines is "Guess we're having a good old-fashioned staring contest."
However, the subtitles are incorrectly typed as "Guess we're having a good old fashion staring contest."
Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
Yes
Reproduction Steps
See report details.

Form ID [0026C574]


about metrics

Hi folks,
I've installed ouroboros and prometheus in two containers.
I've understood at least 3 metrics should see about containers:
'containers_updated',
'containers_being_monitored'
'all_containers_updated'
But in prometheus I see only 'containers_being_monitored'. Maybe because I've updated all my containers before installing prometheus, and I need to wait next update to see something?
Please advise
thanks
Andrea

@nesys you are correct. Those metrics will be created when an update has occurred.


Add hosted documentation

Let's add hosted documentation of the API but also of the data to this repository. We can build something already around the current README.md but it would be good to document the data loader in more detail. On my side, I'd also like to contribute more documentation providing more information about the data.

I have added the hosted documentation using pydoc, eventually switching to sphinx might be an idea as it gives more flexibility.
If there is an option to have a subdomain added to the aidos website we can also provide a custom url to have the docs hosted under the aidos domain.
For adding documentation that would be great! Either in form of a pull request or directly to the main branch is fine.


switch to use libfirmware timer

Current issue:
Why is this here, instead of util.mk?

I assume that timer.cpp assumes some "abstract" methods are implemented by the consumer.
In order for consumers to have an option not to use timer.cpp and thus not implement dependencies it's currently not in util.mk
I am open to all improvements! At the moment I believe the consumers of libfirmware are ECU, WBO, GDI4 and stim.


Not showing preview

I use Debian 12 stable and lf file manager, but the file preview doesnt show. Nothing show. I use st terminal.

I try ranger, and get preview wit ueberzug. Maybe missing some packages?

I try Ubuntu 23.04, and the problem remains the same.
Both have ueberzug version: 18.1.9

Is the preview window just empty? Do you have ueberzug installed?

I test with scripts (https://github.com/gokcehan/lf/wiki/Previews), and working fine. When I use ctpv, not working. So maybe get plus package or change code in ctpv.

Did you ever resolve this or does the issue persist? I'm also on Debian 12 stable using the st terminal and I'm having the same issue


Font loader doesn't work with .ttf fonts

Steps to Reproduce

Download a font in 2 formats: ttf and woff2. For this example, I used the Rubik Vinyl font.
Import the ttf font:local: [
  {
    src: "/fonts/RubikVinyl-Regular.ttf",
    family: "Rubik Vinyl",
    display: "swap",
  },
],

Current Behavior
Now if you try to use the font it won't work. In the console, you will see this warning:
The resource http://localhost:3000/fonts/RubikVinyl-Regular.ttf was preloaded using link preload but not used within a
few seconds from the window's load event. Please make sure it has an appropriate `as` value and it is preloaded
intentionally.

Expected Behavior
If instead you use the woff2 font it will work as excepted.

Additional Details
When externally importing the google font, it works as expected. This is because it using the woff2 format.
external: [
  {
    src: "https://fonts.googleapis.com/css2?family=Rubik+Vinyl:wght@400&display=swap",
    family: "Rubik Vinyl",
  },
],

This is not related but I'm using tailwindcss in order to generate the font class.
module.exports = {
  darkMode: "class",
  theme: {
    extend: {
      fontFamily: {
        rubik: ["Rubik Vinyl", "sans-serif"],
      },
    },
  },
  plugins: [],
};

this generated the font-rubik css class.

Version
2.2.1

The resource RubikVinyl-Regular.ttf was preloaded using link ...

If that notification appears, it means that the font has been loaded and is working as expected.
Most likely, you did not specify the font via css.
The module provides an option class and variable through which it automatically generates the styles needed to load fonts in templates.
The docs mentions this with example code.
// nuxt.config.ts

{
  fontLoader: {
    local: [
      {
        src: '/fonts/Aspekta.woff2',
        family: 'Aspekta',
        class: 'font-aspekta' // optional
      }
    ]
  }
}

<template>

Nuxt Font Loader

</template>

Of course, these options are optional, which means that you don't have to use them, but then you have to manually create a css class with a specific font.
Create custom class inside your main.css file or specified global font via body or html it's up to you.
.font-rubik {
  font-family: 'Rubik Vinyl';
}

/* or alternativelly */

body {
  font-family: 'Rubik Vinyl';
}

And use it in template:
<template>

Title

</template>

Or if you use tailwind you can extend theme fontFamily.
Try again and feel free to leave feedback.

As mentioned above, I did specify the font via css. When reproducing the bug, I only edited the src option.
Here is a minimal reproduction environment for the bug.
As you can see, the woff2 font loads correctly but the ttf font doesn't.

Ah yes, I see what the problem is.
Module automatically generates format from the src option and adding it to the css.
@font-face {
  src: url('/fonts/RubikVinyl-Regular.ttf') format('ttf'); /* wrong format */
}

It should be:
@font-face {
  src: url('/fonts/RubikVinyl-Regular.ttf') format('truetype');
}

I have updated the module, feel free to try it.
Also, thanks for the report 👍

That's amazing thank you!


Null exception in VoiceAssistantClient because of FromId

Line 255 of Cognitive-Services-Voice-Assistants\clients\csharp-wpf\VoiceAssistantClient\MainWindow.xaml.cs
if (!string.IsNullOrEmpty(this.settings.RuntimeSettings.Profile.FromId))
            {
                // Set the from.id in the Bot-Framework Activity sent by this tool.
                // from.id field identifies who generated the activity, and may be required by some bots.
                // See https://github.com/microsoft/botframework-sdk/blob/master/specs/botframework-activity/botframework-activity.md
                // for Bot Framework Activity schema and from.id.
                config.SetProperty(PropertyId.Conversation_From_Id, this.settings.RuntimeSettings.FromId);
            }

should be
if (!string.IsNullOrEmpty(this.settings.RuntimeSettings.Profile.FromId))
            {
                // Set the from.id in the Bot-Framework Activity sent by this tool.
                // from.id field identifies who generated the activity, and may be required by some bots.
                // See https://github.com/microsoft/botframework-sdk/blob/master/specs/botframework-activity/botframework-activity.md
                // for Bot Framework Activity schema and from.id.
                config.SetProperty(PropertyId.Conversation_From_Id, this.settings.RuntimeSettings.Profile.FromId);
            }

@rohit21agrawal  Thank you for creating an issue.
You should feel free to create a PR if you would like. Otherwise, we will add it to our work and try to fix as soon as possible.


Flaky test: GeneratesAssemblyAttributeFile

This test fails occasionally with the following error:
Assert.Equal() Failure
Expected: 0
Actual:   1
   at Microsoft.Extensions.Configuration.UserSecrets.MsBuildTargetTest.GeneratesAssemblyAttributeFile() in /_/test/Config.UserSecrets.Test/MsBuildTargetTest.cs:line 71

Future instance of this failure can be seen here.

No occurrences lately, but I made some changes to the test which should increase the stability anyways.


kanata-with-cmd: 1.5.0 -> 1.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/jtroo/kanata/releases.
meta.description for kanata-with-cmd is: A tool to improve keyboard comfort and usability with advanced customization
meta.homepage for kanata-with-cmd is: https://github.com/jtroo/kanata
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.0 with grep in /nix/store/c0qh3g1qsfybrcfsmygp97wq76xr2rna-kanata-1.6.0
found 1.6.0 in filename of file in /nix/store/c0qh3g1qsfybrcfsmygp97wq76xr2rna-kanata-1.6.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

kanata
kanata-with-cmd

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c0qh3g1qsfybrcfsmygp97wq76xr2rna-kanata-1.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A kanata-with-cmd https://github.com/r-ryantm/nixpkgs/archive/8e26ba11b75c98210b2662556a307c24538f86d6.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8e26ba11b75c98210b2662556a307c24538f86d6#kanata-with-cmd

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c0qh3g1qsfybrcfsmygp97wq76xr2rna-kanata-1.6.0
ls -la /nix/store/c0qh3g1qsfybrcfsmygp97wq76xr2rna-kanata-1.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages built:

kanata
kanata-with-cmd

Maintainer pings
cc @bmanuel @jian-lin for testing.

duplicate of https://github.com/NixOS/nixpkgs/pull/306546


Gradle 8.8-rc-1 is not compatible with Develocity plugin + Test Distribution

Current Behavior
When applying Develocity plugin via a Settings plugin, ex.
buildscript {
    repositories {
        mavenCentral()
        maven {
            url = uri("https://plugins.gradle.org/m2/")
        }
    }
    dependencies {
        classpath 'com.gradle:develocity-gradle-plugin:3.17.2'
    }
}

apply plugin: MyPlugin

class MyPlugin implements Plugin<Settings> {

    @Override
    void apply(Settings settings) {
        settings.pluginManager.apply(com.gradle.develocity.agent.gradle.DevelocityPlugin)
    }
}

And configuring the test tasks to use testDistribution:
configure(subprojects) {
    apply plugin: 'java'

    repositories {
        mavenCentral()
    }

    dependencies {
        testImplementation 'org.junit.jupiter:junit-jupiter:5.10.2'
        testImplementation 'org.junit.platform:junit-platform-launcher:1.10.2'
    }

    tasks.withType(Test) {
        useJUnitPlatform()
        develocity {
            testDistribution {
                enabled = true
                remoteExecutionPreferred = false
                maxLocalExecutors = 1
                maxRemoteExecutors = 0
            }
        }
    }
}

results in:

* Where:
Build file '/Users/rperezalcolea/Projects/github/rpalcolea/develocity-gradle-8_8-rc-1-issue/build.gradle' line: 32

* What went wrong:
A problem occurred evaluating root project 'develocity-gradle-8_8-issue'.
> Could not find method testDistribution() for arguments [build_f1zxr60n0efii4e7esqgee7dt$_run_closure1$_closure4$_closure6$_closure7@88f523c] on extension 'develocity' of type com.gradle.develocity.agent.gradle.internal.a_Decorated.

* Try:
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.

It looks like the Test task is being decorated with com.gradle.develocity.agent.gradle.internal.DevelocityConfigurationInternal instead of com.gradle.develocity.agent.gradle.internal.test.DevelocityTestConfigurationInternal
Expected Behavior
It should decorate the Test task using DevelocityTestConfiguration and DevelocityTestConfigurationInternal accordingly
Context (optional)
No response
Steps to Reproduce
reproducer in https://github.com/rpalcolea/gradle-enterprise-plugin-test-distribution-issue/tree/main
Gradle version
8.8-rc.1
Gradle version that used to work
8.7
Build scan URL (optional)
No response
Your Environment (optional)
No response

The issue is in the backlog of the relevant team and is prioritized by them.

Thanks for the report @rpalcolea, this will be fixed in the next RC.
Notice however that the pattern tasks.withType(Test) { ... } causes all Test tasks on every subproject to be realized regardless of whether they will be actually used in a particular Gradle invocation.
In general, It's be better to use the tasks.withType(Test).configureEach { ... } pattern instead.

hi @bamboo ,
Yeah... I totally forgot when putting the thing together. We actually have some internal linting to continuously move build files that missed that, it is a great callout! thanks for bringing it up :) and also thanks for looking at this !

Fixed via #29083


update report_traffic_time()

set_device_system_time(system_time: u64) -> report_traffic_time(sharing_traffic: u64,system_time: u32)

Codecov Report

Merging #271 (61c40a0) into master (568e329) will increase coverage by 0.01%.
The diff coverage is 68.00%.

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   69.65%   69.67%   +0.01%
==========================================
  Files          57       57
  Lines       16114    16123       +9
==========================================
+ Hits        11224    11233       +9
  Misses       4890     4890

Impacted Files
Coverage Δ

pallets/deeper-node/src/benchmarking.rs
91.57% <0.00%> (ø)

pallets/deeper-node/src/weights.rs
0.00% <0.00%> (ø)

pallets/deeper-node/src/lib.rs
77.26% <69.23%> (+0.15%)
:arrow_up:

pallets/deeper-node/src/tests.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568e329...61c40a0. Read the comment docs.


Tree Select

I'm experiencing some weird behavior when using rowSelection: true, groupSelectsChildren:true and tree data enabled.

Click a row without tree data. Row is selected as expected.
Click a row with tree data. Row and children are selected as expected. But the previously selected row is not unselected. I believe this behavior should only occur with CTRL + click.

Additionally, I'm not able to select a parent node by clicking it. I've tried with groupSelectsChildren equal to true, false and 'group'

rowSelection: true should be rowSelection: 'multiple'
from the docs: rowSelection: Type of row selection, set to either 'single' or 'multiple' to enable selection.
i'm wondering if fixing this will fix most of your problems.
one item that is not working as you describe is click selection - click selection doesn't work for group rows. this is because double clicking the row where the group is displayed (assuming you are using the provided group cell renderer) will expand / collapse the group.
what you should consider doing is using checkbox selecton. if using the provided group cellRenderer, then do as follows:
groupColumnDef: {headerName: "Athlete", field: "athlete", width: 200,
        cellRenderer: 'group',
        cellRendererParams: {
            checkbox: true
        }}

it makes sense to use checkbox when groupSelectsChildren, otherwise there is no visual way to know if the group is half selected.


test-ci script / Travis Stage Builds

Mentioned in several issues already (ie https://github.com/freeCodeCamp/freeCodeCamp/issues/30709 and https://github.com/freeCodeCamp/freeCodeCamp/issues/24688) there's a desired to implement Travis CI Stage Builds.

For very selfish reasons, could someone break down the flow of the current .travis.yml and overall testing?
              For example:

               script:
                  - npm run test-ci

               triggers: `gulpfile.js `>> `karma.conf.ci.js` ?
               then some how eventually triggers:  ../tools/challenge-md-parser

Is there anything that can be put in stages currently (pending all the items @raisedadead raised/mentioned in https://github.com/freeCodeCamp/freeCodeCamp/issues/30709) ?
               .travis.yml
               jobs:
                 include:
                   - stage: unit-testing
                   - script: ./content-linter
                   - script: ./curriculm-test
                   - stage: deploy
                      script: ./deploy target-1
                   - script: ./deploy target-2

We have stage builds.


[Fix][Bug][Dev]Switch version in pom.xml to dev-SNAPSHOT (#9223)

Purpose of the pull request

Versions in pom.xml files of dev branch is currently set to 2.0.4-SNAPSHOT, which is confusing. This PR switches the version from 2.0.4-SNAPSHOT to dev-SNAPSHOT.
This PR closes: #9223

Brief change log

As stated above in Purpose section.

Verify this pull request

Compile the code with cmd mvn -U install package -Prelease -Dmaven.test.skip=true and related output jars/packages should be of version dev-SNAPSHOT

Codecov Report

Merging #9299 (4b1275a) into dev (9d68b17) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9299      +/-   ##
============================================
- Coverage     40.25%   40.23%   -0.02%
+ Complexity     4390     4389       -1
============================================
  Files           820      820
  Lines         32834    32834
  Branches       3650     3650
============================================
- Hits          13216    13211       -5
- Misses        18382    18386       +4
- Partials       1236     1237       +1

Impacted Files
Coverage Δ

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...erver/master/processor/queue/TaskEventService.java
64.22% <0.00%> (-3.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d68b17...4b1275a. Read the comment docs.

@zhongjiajie After I cleaned some target folder, I cannot reproduce this log4j.properties issue. I think it was caused by some maven cached things. This PR cloud be merged now.

@zhongjiajie CI checks passed. PTAL. Thanks! : )