Clarification on redirect status code (303)

According to documentation:
https://turbo.hotwire.dev/handbook/drive#redirecting-after-a-form-submission

After a stateful request from a form submission, Turbo Drive expects the server to return an HTTP 303 redirect response, which it will then follow and use to navigate and update the page without reloading.

It appears that Turbo works fine with any 3xx code (e.g. 301 or 302). However is this going to be a hard rule? Many non-Rails frameworks (e.g. Django) assume a 301 or 302 redirect by default, and this will break standard behavior. Is there a good reason for this or should the docs be updated?

HTTP 303 is the correct status code to return in response to a non-idempotent request when you want the browser to follow the Location header with a GET instead of the original verb.
Further reading:

https://en.wikipedia.org/wiki/HTTP_303
https://tools.ietf.org/html/rfc2616#section-10.3.4
https://bugs.webkit.org/show_bug.cgi?id=46183
https://bugzilla.mozilla.org/show_bug.cgi?id=598304
https://hg.mozilla.org/mozilla-central/rev/9525d7e2d20d
http://code.google.com/p/chromium/issues/detail?id=56373
http://ftp.ics.uci.edu/pub/ietf/http/hypermail/1997q3/0611.html
https://github.com/rails/rails/issues/4144

HTTP 303 is the correct status code to return in response to a non-idempotent request when you want the browser to follow the Location header with a GET instead of the original verb.
Further reading:

https://en.wikipedia.org/wiki/HTTP_303
https://tools.ietf.org/html/rfc2616#section-10.3.4
https://bugs.webkit.org/show_bug.cgi?id=46183
https://bugzilla.mozilla.org/show_bug.cgi?id=598304
https://hg.mozilla.org/mozilla-central/rev/9525d7e2d20d
http://code.google.com/p/chromium/issues/detail?id=56373
http://ftp.ics.uci.edu/pub/ietf/http/hypermail/1997q3/0611.html
https://github.com/rails/rails/issues/4144

Is it a hard requirement to return a 303 or is any 3** response acceptable? What is Turbo's actual behavior here?

Is it a hard requirement to return a 303 or is any 3** response acceptable? What is Turbo's actual behavior here?

It isn't a Turbo requirement, it's an HTTP requirement. The Fetch API follows redirects automatically and doesn't give clients access to the redirect status codes; clients only have access to the status of the final request, plus a flag which says whether a redirect took place.

https://github.com/hotwired/turbo/blob/7eab20f7537338f983d58b8910a35108d81d2467/src/http/fetch_response.ts#L26-L28
https://developer.mozilla.org/en-US/docs/Web/API/Response/redirected

It isn't a Turbo requirement, it's an HTTP requirement. The Fetch API follows redirects automatically and doesn't give clients access to the redirect status codes; clients only have access to the status of the final request, plus a flag which says whether a redirect took place.

https://github.com/hotwired/turbo/blob/7eab20f7537338f983d58b8910a35108d81d2467/src/http/fetch_response.ts#L26-L28
https://developer.mozilla.org/en-US/docs/Web/API/Response/redirected

OK so then isn't the documentation incorrect? Any 3** redirect is acceptable, regardless whether 303 is the "right" code or not?

OK so then isn't the documentation incorrect? Any 3** redirect is acceptable, regardless whether 303 is the "right" code or not?

Thanks for the conversation on this. I'm looking into this now.
Before we change all the 302s to 303s in our legacy app we want to know if there is meaningfully different behavior in a Turbo app when responding to non-idempotent requests with 302s vs 303s. As noted, the documentation makes it sounds like it is a Turbo requirement ("... Turbo Drive expects the server to return an HTTP 303 redirect response..."), but the response to this issue sounds like HTTP best practice rather than an operational requirement.
Like @danjac I have found no difference in the way the "Turbo stack" (including its use of fetch here) operates when returning a 302 or a 303 to a non-idempotent request. For example, our login POST endpoint validates credentials and redirects logged in users back to our app homepage. Whether I respond to the login POST request with a 302 or 303, I see no meaningful difference in behavior in the browser or the Rails log: a POST request to the login endpoint of type TURBO_STREAM followed by a GET request to the homepage of type TURBO_STREAM.
I understand that best practice has a role to play in development and the good tools will guide users that. But without an understanding of why 303s are required/expected  we risk cargo-culting and misinformation when trying to troubleshoot Turbo integration issues.
Is there a case currently where a Turbo app handles 302 and 303 responses differently for non-idempotent requests?

@johnmaxwell So im currently rewriting UJS in typescript, and slammed into this head on. There are definitely different semantic differences.
The issue stems from the Fetch / HTTP spec. Basically if I issue a request like so:
fetch("/posts/5", {method: "delete"})

and /posts/5 redirects to /posts on success, then both requests are made as DELETE requests instead of /posts/5 being a DELETE request and the request to /posts being a GET request.
This happens if the header is not 303. If the header is 303, the first request is DELETE, and the following is GET.
Heres a video of an ajax delete using fetch with the standard 302 headers to show what happens.
https://user-images.githubusercontent.com/26425882/122270594-7a827980-ceac-11eb-9b0b-b6df84a63635.mov
Also of note, this behavior does not happen with POST, most likely for backwards compatibility of some kind.

If one of the following is true:
* actualResponse’s status is 301 or 302 and request’s method is POST
* actualResponse’s status is 303 and request’s method is not GET or HEAD

then:

Set request’s method to GET and request’s body to null.
For each headerName of request-body-header name, delete headerName from request’s header list.

https://fetch.spec.whatwg.org/#http-redirect-fetch
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/303

@ParamagicDev Yep, okay. I confirmed that sending using fetch to send DELETE, PATCH, and PUT requests do what you describe when receiving a 302: redirect with the original verb instead of making a subsequent GET request. This is what @sstephenson said above -- and I should have understood it -- but I didn't, and seeing your illustration drove it home. Thanks for taking the time to document.

fetch method
fetch response
redirect method

GET
302
GET

GET
303
GET

POST
302
GET

POST
303
GET

PUT
302
PUT

PUT
303
GET

PATCH
302
PATCH

PATCH
303
GET

DELETE
302
DELETE

DELETE
303
GET


Fix required to allow compilation with PlatformIO

Without this fix, projects using PlatformIO fails to compile.

One thing to note is that I have HomeSpan's source in the lib folder as a git submodule, and main.cpp sits in src.
frankonski@inspiron MINGW64 ~/Documents/PlatformIO/Projects/LightStrip (dev)
$ find . -type d -not -path "./.git*" -not -path "./lib/HomeSpan/examples*" -not -path "./lib/HomeSpan/.git*" -not -path "./.pio*"
.
./.vscode
./include
./lib
./lib/HomeSpan
./lib/HomeSpan/docs
./lib/HomeSpan/docs/images
./lib/HomeSpan/docs/StepperDrivers
./lib/HomeSpan/documents
./lib/HomeSpan/src
./lib/HomeSpan/src/src
./lib/HomeSpan/src/src/extras
./lib/HomeSpan/tools
./src
./test

Thanks for the details.  This doesn't seem to be a linking error:  PIO is claiming it cannot find the DNSServer.h file.  If that's true, it means the file is missing.  But if it's missing, how come it does find the file when the link as added to HomeSpan.cpp (which does not use DNSServer at all)?
Did this error just start occurring when you moved HomeSpan 2.X (which is based on IDF5)?  If so, I think this means something is amiss in your PIO setup.  Have you tried posting the issue to the PIO discussion boards?  Even though your fix may address the issue, it could easily come up again as the code continues to migrate and it would probably be best to sort this out and get to the root cause.

Your comment got me thinking. Unfortunately, PlatformIO does not yet support esp32-arduino v3 source.. but there are workarounds as I have used above.
Nevertheless, running a verbose build (to see all of the IncludePath) showed the dependency graph, which PlatformIO uses to create its build command.
Using the unmodified HomeSpan.cpp (without #include <DNSServer.h), I could see the following dependency graph:
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ chain, Compatibility ~ soft
Found 41 compatible libraries
Scanning dependencies...
Dependency Graph
|-- HomeSpan @ 2.0.0 (License: Unknown, Path: C:\Users\frankonski\Documents\PlatformIO\Projects\LightStrip\lib\HomeSpan)
|   |-- ESPmDNS @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ESPmDNS)
|   |-- ArduinoOTA @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ArduinoOTA)
|   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
|   |   |-- Update @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Update)
|   |   |-- ESPmDNS @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ESPmDNS)
|   |-- WiFi @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\WiFi)
|   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
Building in release mode

When adding #include <DNSServer.h> to HomeSpan.cpp, it then printed this:
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ chain, Compatibility ~ soft
Found 41 compatible libraries
Scanning dependencies...
Dependency Graph
|-- HomeSpan @ 2.0.0 (License: Unknown, Path: C:\Users\frankonski\Documents\PlatformIO\Projects\LightStrip\lib\HomeSpan)
|   |-- ESPmDNS @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ESPmDNS)
|   |-- ArduinoOTA @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ArduinoOTA)
|   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
|   |   |-- Update @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Update)
|   |   |-- ESPmDNS @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ESPmDNS)
|   |-- DNSServer @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\DNSServer)
|   |   |-- ESP32 Async UDP @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\AsyncUDP)
|   |   |-- WiFi @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\WiFi)
|   |   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
|   |-- WiFi @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\WiFi)
|   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
Building in release mode

As you can see above, PIO added DNSServer as a dependency to HomeSpan.
Then that bit.ly link points to https://docs.platformio.org/en/latest/librarymanager/ldf.html
The solution was to simply add lib_ldf_mode = deep to my platformio.ini file, which produced a differently ordered dependency graph, but allowed successful compilation:
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ deep, Compatibility ~ soft
Found 41 compatible libraries
Scanning dependencies...
Dependency Graph
|-- HomeSpan @ 2.0.0 (License: Unknown, Path: C:\Users\frankonski\Documents\PlatformIO\Projects\LightStrip\lib\HomeSpan)
|   |-- ESPmDNS @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ESPmDNS)
|   |-- WiFi @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\WiFi)
|   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
|   |-- DNSServer @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\DNSServer)
|   |   |-- WiFi @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\WiFi)
|   |   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
|   |   |-- ESP32 Async UDP @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\AsyncUDP)
|   |-- ArduinoOTA @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ArduinoOTA)
|   |   |-- ESPmDNS @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ESPmDNS)
|   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
|   |   |-- Update @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Update)
Building in release mode

Is it possible that in the refactoring you did in HS 2.x, the inclusion of DNSServer.h was done in a different place?

I just re-checked 1.9.1 and no changes at all to anything related to DNSServer when I moved to 2.0.0.  The #include <DNSServer.h> and all the calls are exclusively in Network.cpp.

I found what caused the change (I think): rename of Network.h to Network_HS.h without its respective .cpp file.
I don't know the exact reason why you renamed your own Network.h to Network_HS.h, but by simply renaming Network.cpp to Network_HS.cpp, I was then able to recompile the dev branch without lib_ldf_mode = deep.
I don't know how PIO creates its dependency graph, but I think the mismatch of the basename (Network.cpp / Network_HS.h) causes PIO to miss including Network_HS.h altogether.
Here is the dependency graph when I renamed Network.cpp to Network_HS.cpp:
Dependency Graph
|-- HomeSpan @ 2.0.0 (License: Unknown, Path: C:\Users\frankonski\Documents\PlatformIO\Projects\LightStrip\lib\HomeSpan)
|   |-- DNSServer @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\DNSServer)
|   |   |-- ESP32 Async UDP @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\AsyncUDP)
|   |   |-- WiFi @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\WiFi)
|   |   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
|   |-- ESPmDNS @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ESPmDNS)
|   |-- ArduinoOTA @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ArduinoOTA)
|   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
|   |   |-- Update @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Update)
|   |   |-- ESPmDNS @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\ESPmDNS)
|   |-- WiFi @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\WiFi)
|   |   |-- Networking @ 3.0.7 (License: Unknown, Path: C:\Users\frankonski\.platformio\packages\framework-arduinoespressif32\libraries\Network)
Building in release mode

Any chance to have the basenames in sync?

As previously mentioned, when Espressif launched version 3.X of the Arduino-ESP32 library they made a LOT of changes to their code base, including many that were not backwards compatible.  One of the changes they made was to create a globally-scoped  Network object that unified their globally-scoped WiFi and ETH objects. This was actually a very good move since it enabled me to more readily integrate Ethernet support into HomeSpan, and you will see that apart from just a small number of ETH and WiFi-specific calls, HomeSpan now uses the Network object for all communication (hence it works whether using Ethernet or WiFi).
But the one downside to all this is that Espressif also changed their own code-base names, including adding a new Network.h header file.  Of course they did not document this anywhere and it took me a week to figure out why HomeSpan would not compile --- my own Network.h file was clashing with the newly-added Arduino-ESP32 Network.h file.  So I changed the name of my Network.h to file Network_HS.h to avoid the conflict.
As for changing the name of my Network.cpp file, I'd rather not make changes to file names for such reasons - I need the flexibility to rename anything at any time in library updates, either because of design changes in HomeSpan, or in response to design changes in the Arduino-ESP32 library, or the IDF itself.  Also, I think it was only by luck that things compiled before the change.  For example, HomeSpan has PSRAM.h, Settings.h, etc. files without corresponding .cpp files.
I think the root of the problem is the way you've configured things in PIO.  According to https://docs.platformio.org/en/latest/librarymanager/ldf.html there are a number of things you can do to address the issue more robustly. One is to use the "deep" option, but it looks like there are other configuration changes you can make to solve the problem more generally so this does not re-surface in the future.

Generally speaking, it would be nice if the whole HomeSpan code base had its own namespace to prevent such conflicts from the get-go, such having a prefix on all filenames & global variables like hs_ or hspn_.
Nevertheless, ideally we can use default build settings (not having to specific lib_ldf_mode = deep).
I just tested moving #include <DNSServer.h> from Network.cpp to Network_HS.h and this also resolves the issue. Would you be willing to make this change? I can update the PR.
The definition of "chain" is

Parses ALL C/C++ source files of the project and follows only by nested includes (#include ..., chain...) from the libraries. It also parses C, CC, CPP files from libraries which have the same name as included header file.

Since currently, #include <DNSServer.h> is in a cpp file which does not have the same name as the header file, the cpp file is not parsed, and DNSServer.h is not included by the dependency builder. And it is not found in any nested include either, as only .h files are parsed.
This is why it would be appreciated if my latest suggestion could be implemented (move #include <DNSServer.h> from Network.cpp to Network_HS.h)

The problem is that DNSServer.h is not used by Network_HS.h and has no business being in that file.  As written the current code seems 100% compliant with best-practices. I think the issue is with how you configured PIO.  I assume PIO knows (or should know) the difference between library files and your primary sketch - it should NOT be recompiling everything each time as if was one big program.
The change you suggest above may work for now, but it won't the next time I change the naming conventions of the files, or my headers.  The whole point of a library is that the underlying code structure should not matter.   Though I don't use PIO, it seems that the problem is PIO wrote it's own dependency driver instead of using gcc directly, or make, or any other tool that's been standardized for decades.  That's fine - PIO claims their method to parse all the files and find dependencies is faster.  But that apparently comes at a cost in that you (A) have to organize your code certain ways.  Alternatively, you can (B) make sure to add the required dependencies to your .ini file, or (C) select "deep" or something similar that causes the tool-chain to properly parse the files to find the dependencies.
To avoid any issues in the future, I suggest you implement the alternatives (B) and/or (C) above.  Method (A) (changing the files structure) is not going to work, especially as the release after I complete 2.1.0 will be related to trying to reduce the size, which inevitably will mean every file name and header file will likely change.

I added a comment to discussion #923 before I saw this PR.  Figured I should mention it here in case anyone else is having the same trouble and lands here before seeing the discussion.

The problem is that DNSServer.h is not used by Network_HS.h and has no business being in that file.
I guess that becomes a coding preference. I'm ok if you prefer to keep things this way.

And I'll stick with Option C (deep) as it is a clean option. Feel free to close this PR.


Can now create nonProgram events

*There is no Github issue attached to this PR
Issue:
When a user attempted to create a non-program event they were thrown an error from the dict object since it was looking for program in the event data but since there is no program in non-program events the didn't know what to do.
Did:
Added a new conditional to check whether or not there was a program in the event data. If there was a program then continue on to the existing logic and if there was no program then it would just skip it.
To test:

Run the test suite with a freshly reset database and make sure all tests pass (things were only changed in the HTML so the  had better pass)
Run the application and make sure that you are able to create non-program events
With the application running verify that the requirements dropdown appears as it should on the Bonner event creation page but not on any of the other pages.

 Can now create nonProgram events


Backport 2.16: all.sh: Enable verbose failure messages for CMake

Set the CMake-observed variable CTEST_OUTPUT_ON_FAILURE, so that when
a "make test" run by CMake fails, verbose test output about the detail
of failure is available.
Backport of https://github.com/ARMmbed/mbed-crypto/pull/52. Rebase of https://github.com/ARMmbed/mbedtls/pull/2434.

We didn't get all the CI job results but they all passed, thus ready to be merged.


admin access to repository, or greater access

Organization or repository
tower_configuration
tower_utilities
Description of the issue
Had noticed when ah_configuration  was created, I was given the ability to change settings including actions/secrets in that repository. Would like myself and another admin to be given the privileged access in the other two repositories we help maintain. Was this PR, but not sure what specifically is different compared to the other two.
The purpose of this would be to be able to create/maintain secrets, and create our own self-hosted runners that would embed on an openshift cluster for deploying tests.
Users or Teams affected
@sean-m-sullivan
@tompage1994

Review request:
cc: @redhat-cop/container-cop-core

@sabre1041 Possible for you to handle this, or assign to someone? Thanks

@sean-m-sullivan the CoP is attempting to avoid individual users with specific rights to a repository and instead leveraging GitHub teams from a management point.
For example, do we want to use an existing team (such as automation-cop-mgrs) or create a new team?

I understand that, I'm thinking of a tower team? automation-cop-tower-mgrs perhaps? Would put Tom and I in that group to manage the 3 tower repos and the AH repo. Actual goal was to make changes to how we do tests and the runners over the holidays without pinging you guys, and/or copying a Personal access token from someone to setup said runners.


fix: autocomplete label after selecting a query type context provider

Description

After selecting a query type context provider from the dropdown, the editor will now update to complete the provider label.
Resolves #1540

Checklist

[x] The base branch of this PR is dev, rather than main
[x] The relevant docs, if any, have been updated or created

Should I reopen the PR with the dev branch as the base? Just noticed that the checklist has changed to say dev instead of preview

@devbyjonah that's okay, this is a recent change so I'm happy to merge straight to preview. Nice work!


Discussion - Growth Media

Please post any suggestions and ideas related to Growth Media here

What about an option to replace water with other liquids with different grow modifiers. Like mineralized/fertilized water for faster growth or lava for growing nether warts.

I've been looking into this but haven't settled on anything yet. I don't really want to add custom liquids to the mod at this point as it may overcomplicate things, but it would be cool to use liquids from other mods. If you can think of any that would work let me know.


Remove pointless warning on pkcs12 import

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

This pull request is ready to merge

Merged. Thanks!


brew update fails with "Git must be installed and in your PATH!"

brew update fails with this error:
$ brew update
Warning: git 2.15.1 is already installed
Error: Git must be installed and in your PATH!

I already searched the issues and found a workaround like:
cd $(brew --prefix) && git fetch && git reset --hard origin/master

But I got the result:
cd $(brew --prefix) && git fetch && git reset --hard origin/master
fatal: Not a git repository (or any of the parent directories): .git

Detailed info follows. Thanks for any help!
 $ brew config
HOMEBREW_VERSION: >=1.4.0 (shallow or no git repository)
ORIGIN: (none)
HEAD: (none)
Last commit: never
Core tap ORIGIN: (none)
Core tap HEAD: (none)
Core tap last commit: never
HOMEBREW_PREFIX: /usr/local
HOMEBREW_NO_ANALYTICS_THIS_RUN: 1
CPU: octa-core 64-bit kabylake
Homebrew Ruby: 2.3.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/bin/ruby
Clang: N/A
Git: N/A
Curl: 7.54.0 => /usr/bin/curl
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
Java: 1.8.0_144
macOS: 10.13.2-x86_64
Xcode: N/A
CLT: N/A
X11: N/A

 $ brew update
Warning: git 2.15.1 is already installed
Error: Git must be installed and in your PATH!

 $ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Git could not be found in your PATH.
Homebrew uses Git for several internal functions, and some formulae use Git
checkouts instead of stable tarballs. You may want to install Git:
  brew install git

Warning: No developer tools installed.
Install the Command Line Tools:
  xcode-select --install

 $ which -a git
/usr/local/bin/git
/usr/bin/git

$ git --version
git version 2.15.1

$ echo $PATH
/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/Wireshark.app/Contents/MacOS

xcode-select --install

From the issue template:

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you do not read fill out the issue template repeatedly you will be blocked from ever submitting issues to Homebrew again.

If you add the necessary information this issue may be reopened.

If you add the necessary information this issue may be reopened.

Except in this case: you've already posted in your comment what needed to be done to fix the issue.

@ilovezfs thanks, it works now!


Search results are limited to 500 items

Need to loop with next_cursor https://support.cloudinary.com/hc/en-us/community/posts/360008223779-How-to-use-next-cursor-to-get-the-rest-of-the-files-in-a-specific-folder-

Fixed https://github.com/jpvalery/archive.jpvalery.photo/commit/299d40a95b27bb8ad7f58d9c97817ed9b45003dc


Y-axis labels not aligned in IE11 on horizontal bar chart

I'm having trouble getting the y-axis labels aligned on a horizontal bar chart in IE11. Alignment is fine in Chrome, Safari and Firefox. I'm noticing the same problem on the Chartist example page:

+1, same issue

Same issue with the x-axis labels on a vertical bar chart. It looks like a flexbug.

IE can't render foreignObject and that's the reason why the labels are misaligned. Search for foreignObject in github to find some solution on how to fix the positioning using the draw event.

This worked for me:
foreignObject span{
height: 70% !important;
}


[BUG] CPU Adam failing

Describe the bug
When I try to train using deepspeed and the huggingface Trainer, I get an error that cpu_adam.o failed.  It is possible this is not a deepspeed issue, but a ninja issue—this is far outside my expertise.
I can paste the entire error message, but I don't want to overwhelm any respondents.  I believe the relevant parts of the error are here:
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/2] c++ -MMD -MF cpu_adam.o.d -DTORCH_EXTENSION_NAME=cpu_adam -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="gcc" -DPYBIND11_STDLIB="libstdcpp" -DPYBIND11_BUILD_ABI="cxxabi1013" -I/home/ubuntu/.local/lib/python3.8/site-packages/deepspeed/ops/csrc/includes -I/usr/include -isystem /usr/lib/python3/dist-packages/torch/include -isystem /usr/lib/python3/dist-packages/torch/include/torch/csrc/api/include -isystem /usr/lib/python3/dist-packages/torch/include/TH -isystem /usr/lib/python3/dist-packages/torch/include/THC -isystem /usr/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -std=c++17 -O3 -std=c++17 -g -Wno-reorder -L/usr/lib64 -lcudart -lcublas -g -march=native -fopenmp -D__AVX512 -D__ENABLE_CUDA_ -DBF16_AVAILABLE -c /home/ubuntu/.local/lib/python3.8/site-packages/deepspeed/ops/csrc/adam/cpu_adam.cpp -o cpu_adam.o
FAILED: cpu_adam.o
c++ -MMD -MF cpu_adam.o.d -DTORCH_EXTENSION_NAME=cpu_adam -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="gcc" -DPYBIND11_STDLIB="libstdcpp" -DPYBIND11_BUILD_ABI="cxxabi1013" -I/home/ubuntu/.local/lib/python3.8/site-packages/deepspeed/ops/csrc/includes -I/usr/include -isystem /usr/lib/python3/dist-packages/torch/include -isystem /usr/lib/python3/dist-packages/torch/include/torch/csrc/api/include -isystem /usr/lib/python3/dist-packages/torch/include/TH -isystem /usr/lib/python3/dist-packages/torch/include/THC -isystem /usr/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -std=c++17 -O3 -std=c++17 -g -Wno-reorder -L/usr/lib64 -lcudart -lcublas -g -march=native -fopenmp -D__AVX512 -D__ENABLE_CUDA_ -DBF16_AVAILABLE -c /home/ubuntu/.local/lib/python3.8/site-packages/deepspeed/ops/csrc/adam/cpu_adam.cpp -o cpu_adam.o
In file included from /usr/lib/python3/dist-packages/torch/include/torch/csrc/api/include/torch/python.h:11,
from /usr/lib/python3/dist-packages/torch/include/torch/extension.h:6,
from /home/ubuntu/.local/lib/python3.8/site-packages/deepspeed/ops/csrc/adam/cpu_adam.cpp:7:
/usr/lib/python3/dist-packages/torch/include/torch/csrc/Exceptions.h:14:10: fatal error: pybind11/pybind11.h: No such file or directory
14 | #include <pybind11/pybind11.h>
|          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/torch/utils/cpp_extension.py", line 1901, in _run_ninja_build
subprocess.run(
File "/usr/lib/python3.8/subprocess.py", line 516, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.
 You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable TF_ENABLE_ONEDNN_OPTS=0.
2023-07-26 22:15:59.245840: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX512F AVX512_VNNI, in other operations, rebuild TensorFlow with the appropriate compiler flags.
WARNING: No preset parameters were found for the device that Open MPI
detected:
Local host:            192-9-138-111
Device name:           mlx5_0
Device vendor ID:      0x02c9
Device vendor part ID: 4126
Default device parameters will be used, which may result in lower
performance.  You can edit any of the files specified by the
btl_openib_device_param_files MCA parameter to set values for your
device.
NOTE: You can turn off this warning by setting the MCA parameter
btl_openib_warn_no_device_params_found to 0.
No OpenFabrics connection schemes reported that they were able to be
used on a specific port.  As such, the openib BTL (OpenFabrics
support) will be disabled for this port.
Local host:           192-9-138-111
Local device:         mlx5_0
Local port:           1
CPCs attempted:       udcm
/home/ubuntu/.local/lib/python3.8/site-packages/pandas/core/computation/expressions.py:20: UserWarning: Pandas requires version '2.7.3' or newer of 'numexpr' (version '2.7.1' currently installed).
from pandas.core.computation.check import NUMEXPR_INSTALLED
DeepSpeed C++/CUDA extension op report
NOTE: Ops not installed will be just-in-time (JIT) compiled at
runtime if needed. Op compatibility means that your system
meet the required dependencies to JIT install the op.
JIT compiled ops requires ninja
ninja .................. [OKAY]
op name ................ installed .. compatible
[WARNING]  async_io requires the dev libaio .so object and headers but these were not found.
[WARNING]  async_io: please install the libaio-dev package with apt
[WARNING]  If libaio is already installed (perhaps from source), try setting the CFLAGS and LDFLAGS environment variables to where it can be found.
async_io ............... [NO] ....... [NO]
cpu_adagrad ............ [NO] ....... [OKAY]
cpu_adam ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
random_ltd ............. [NO] ....... [OKAY]
[WARNING]  sparse_attn requires a torch version >= 1.5 and < 2.0 but detected 2.0
[WARNING]  please install triton==1.0.0 if you want to use sparse attention
sparse_attn ............ [NO] ....... [NO]
spatial_inference ...... [NO] ....... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
DeepSpeed general environment info:
torch install path ............... ['/usr/lib/python3/dist-packages/torch']
torch version .................... 2.0.1
deepspeed install path ........... ['/home/ubuntu/.local/lib/python3.8/site-packages/deepspeed']
deepspeed info ................... 0.10.0, unknown, unknown
torch cuda version ............... 12.2
torch hip version ................ None
nvcc version ..................... 12.2
deepspeed wheel compiled w. ...... torch 2.0, cuda 12.2
Screenshots
Not applicable, I think.
System info (please complete the following information):

OS: Ubuntu 20.04.5
GPU count and types: one machine with one A10
Interconnects (if applicable): N/A
Python version: 3.8.10
Any other relevant info about your setup: I'm using an instance from Lambda Labs using the Lambda Stack.

Launcher context
deepspeed launcher
Docker context
No Docker used
Additional context
I removed dashes from the ds_report output, as it does not play nice with Markdown.  You may want to change the format of the output so that it does play nicely.

{ "_links": { "self": { "href": "https://horizon.kuknos.org/transactions/9ecbb47c6078a44265a9b0b77fade490de7d7275e32cf09f0320d47b19bed179" }, "account": { "href": "https://horizon.kuknos.org/accounts/GCLP66FFKNYAZMZ2PTBBGFDQ67V5JBN7VPZ7KM54P3DXQ2BAD6ZX4I7G" }, "ledger": { "href": "https://horizon.kuknos.org/ledgers/20350505" }, "operations": { "href": "https://horizon.kuknos.org/transactions/9ecbb47c6078a44265a9b0b77fade490de7d7275e32cf09f0320d47b19bed179/operations{?cursor,limit,order}", "templated": true }, "effects": { "href": "https://horizon.kuknos.org/transactions/9ecbb47c6078a44265a9b0b77fade490de7d7275e32cf09f0320d47b19bed179/effects{?cursor,limit,order}", "templated": true }, "precedes": { "href": "https://horizon.kuknos.org/transactions?order=asc\u0026cursor=87404753432088576" }, "succeeds": { "href": "https://horizon.kuknos.org/transactions?order=desc\u0026cursor=87404753432088576" }, "transaction": { "href": "https://horizon.kuknos.org/transactions/9ecbb47c6078a44265a9b0b77fade490de7d7275e32cf09f0320d47b19bed179" } }, "id": "9ecbb47c6078a44265a9b0b77fade490de7d7275e32cf09f0320d47b19bed179", "paging_token": "87404753432088576", "successful": true, "hash": "9ecbb47c6078a44265a9b0b77fade490de7d7275e32cf09f0320d47b19bed179", "ledger": 20350505, "created_at": "2022-11-19T06:42:59Z", "source_account": "GCLP66FFKNYAZMZ2PTBBGFDQ67V5JBN7VPZ7KM54P3DXQ2BAD6ZX4I7G", "source_account_sequence": "85635437359530010", "fee_account": "GCLP66FFKNYAZMZ2PTBBGFDQ67V5JBN7VPZ7KM54P3DXQ2BAD6ZX4I7G", "fee_charged": "100000", "max_fee": "100000", "operation_count": 2, "envelope_xdr": "AAAAAgAAAACW/3ilU3AMszp8whMUcPfr1IW/q/P1M7x+x3hoIB+zfgABhqABMDz6AAAAGgAAAAEAAAAAAAAAAAAAAABjeHtoAAAAAAAAAAIAAAAAAAAABgAAAAFJUlJQAAAAAJ/3RgSJS9ocCZWqhTmpV1i6nKahsdFwfnpRjMF4ZXKXAAAAAABMS0AAAAAAAAAAAQAAAACDKBOhch9bmbbBkZpVhxvNq2+aWwdwWujnbrIQU+OvIgAAAAAAAAAAAvrwgAAAAAAAAAABIB+zfgAAAEAYo3DeWyYYdCKbs6I1KSJxieoxpwZtDDKdyL1TkgaWvIRGDVoJaYFI22h93mE9H7EgLF3zgOwclv2OlDA5hCcC", "result_xdr": "AAAAAAABhqAAAAAAAAAAAgAAAAAAAAAGAAAAAAAAAAAAAAABAAAAAAAAAAA=", "result_meta_xdr": "AAAAAgAAAAIAAAADATaGKQAAAAAAAAAAlv94pVNwDLM6fMITFHD369SFv6vz9TO8fsd4aCAfs34AAAAAB74d4AEwPPoAAAAZAAAABAAAAAEAAAAAjX8c2+eLhdarLC7vKRL4r29MGqdXjpanAj1KLGmKNWYAAAAAAAAADXd3dy5rdWtub3MuaXIAAAABAAAAAAAAAAAAAAAAAAAAAAAAAQE2hikAAAAAAAAAAJb/eKVTcAyzOnzCExRw9+vUhb+r8/UzvH7HeGggH7N+AAAAAAe+HeABMDz6AAAAGgAAAAQAAAABAAAAAI1/HNvni4XWqywu7ykS+K9vTBqnV46WpwI9SixpijVmAAAAAAAAAA13d3cua3Vrbm9zLmlyAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAIAAAADAAAAAwE2hikAAAAAAAAAAJb/eKVTcAyzOnzCExRw9+vUhb+r8/UzvH7HeGggH7N+AAAAAAe+HeABMDz6AAAAGgAAAAQAAAABAAAAAI1/HNvni4XWqywu7ykS+K9vTBqnV46WpwI9SixpijVmAAAAAAAAAA13d3cua3Vrbm9zLmlyAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAEBNoYpAAAAAAAAAACW/3ilU3AMszp8whMUcPfr1IW/q/P1M7x+x3hoIB+zfgAAAAAHvh3gATA8+gAAABoAAAAFAAAAAQAAAACNfxzb54uF1qssLu8pEvivb0wap1eOlqcCPUosaYo1ZgAAAAAAAAANd3d3Lmt1a25vcy5pcgAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAATaGKQAAAAEAAAAAlv94pVNwDLM6fMITFHD369SFv6vz9TO8fsd4aCAfs34AAAABSVJSUAAAAACf90YEiUvaHAmVqoU5qVdYupymobHRcH56UYzBeGVylwAAAAAAAAAAAAAAAABMS0AAAAAAAAAAAAAAAAAAAAAEAAAAAwE2evMAAAAAAAAAAIMoE6FyH1uZtsGRmlWHG82rb5pbB3Ba6OdushBT468iAAAACohp+4AAf3sHAAAACAAAAAQAAAABAAAAAI1/HNvni4XWqywu7ykS+K9vTBqnV46WpwI9SixpijVmAAAAAAAAAA13d3cua3Vrbm9zLmlyAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAEBNoYpAAAAAAAAAACDKBOhch9bmbbBkZpVhxvNq2+aWwdwWujnbrIQU+OvIgAAAAqLZOwAAH97BwAAAAgAAAAEAAAAAQAAAACNfxzb54uF1qssLu8pEvivb0wap1eOlqcCPUosaYo1ZgAAAAAAAAANd3d3Lmt1a25vcy5pcgAAAAEAAAAAAAAAAAAAAAAAAAAAAAADATaGKQAAAAAAAAAAlv94pVNwDLM6fMITFHD369SFv6vz9TO8fsd4aCAfs34AAAAAB74d4AEwPPoAAAAaAAAABQAAAAEAAAAAjX8c2+eLhdarLC7vKRL4r29MGqdXjpanAj1KLGmKNWYAAAAAAAAADXd3dy5rdWtub3MuaXIAAAABAAAAAAAAAAAAAAAAAAAAAAAAAQE2hikAAAAAAAAAAJb/eKVTcAyzOnzCExRw9+vUhb+r8/UzvH7HeGggH7N+AAAAAATDLWABMDz6AAAAGgAAAAUAAAABAAAAAI1/HNvni4XWqywu7ykS+K9vTBqnV46WpwI9SixpijVmAAAAAAAAAA13d3cua3Vrbm9zLmlyAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAA=", "fee_meta_xdr": "AAAAAgAAAAMBNoYaAAAAAAAAAACW/3ilU3AMszp8whMUcPfr1IW/q/P1M7x+x3hoIB+zfgAAAAAHv6SAATA8+gAAABkAAAAEAAAAAQAAAACNfxzb54uF1qssLu8pEvivb0wap1eOlqcCPUosaYo1ZgAAAAAAAAANd3d3Lmt1a25vcy5pcgAAAAEAAAAAAAAAAAAAAAAAAAAAAAABATaGKQAAAAAAAAAAlv94pVNwDLM6fMITFHD369SFv6vz9TO8fsd4aCAfs34AAAAAB74d4AEwPPoAAAAZAAAABAAAAAEAAAAAjX8c2+eLhdarLC7vKRL4r29MGqdXjpanAj1KLGmKNWYAAAAAAAAADXd3dy5rdWtub3MuaXIAAAABAAAAAAAAAAAAAAAAAAAA", "memo_type": "none", "signatures": [ "GKNw3lsmGHQim7OiNSkicYnqMacGbQwynci9U5IGlryERg1aCWmBSNtofd5hPR+xICxd84DsHJb9jpQwOYQnAg==" ], "valid_after": "1970-01-01T00:00:00Z", "valid_before": "2022-11-19T06:44:56Z" }

@avivbrokman, your error log suggests a missing dependency: pybind11


Ensure driver-emitted errors inherit from ZWaveError and supply an appropriate ZWaveErrorCode

Continuing from #1042
I want my application to selectively dismiss known recoverable errors, and shut down the program for all unknown errors encountered.
To this end, all known errors that can be recovered from should contain an appropriate ZWaveErrorCode.
I searched the code base for "new Error", and found several points where generic, non-zwave errors without codes are making their way to the driver's error event:

LanguageCCSet.language
Recommended code: ZWaveErrorCodes.Argument_Invalid
LanguageCCSet.country
Recommended code: ZWaveErrorCodes.Argument_Invalid
Driver.restoreNetworkStructureFromCache
Recommended code: ZWaveErrorCodes.Driver_InvalidCache
Secure node without a security manager
Not sure about this one, it probably deserves a new error code, maybe Node_SecurityNotConfigured

I will look at making a MR for this when I get a moment, probably over the weekend.

Thanks for the investigation! I've gone ahead and created a PR already

fixed in v5.3.2


Implementation of BlenderNC nodes

Implementation of BlenderNC nodes:

Changes:

Addition of apply materials
Addition of custom sockets for interaction between custom nodes in BlenderNC node tree.
Implementation of custom nodes: path, netcdf_input, resolution and image_output
Independent use of simple UI and custom node tree.

WIP:
[ ] Fix warnings of non-connected nodes.
[ ]  Allow user to sample data at multiple resolutions, to increase performance, particularly when visualizing in real-time.
[x]  Divide BlenderNC node tree in multiple nodes to increase flexibility.
[x] Read the Docs documentation
[ ] Animation examples.
[ ] Support for versions of Blender above 2.8.
[ ] Display and load data by coordinates (Using node tree), i.e. box experiments, to display faces.
[ ] Implement vmax and vmin in colorbar, as well as an object to display colorbar.
Future development:

Switch from indexes to coordinates using xarray capabilities
Implementation of Voxel Data.
Support for 1D and 4D data

Note: Preload node hasn't been implemented yet.

Thanks.

Isn't enough to have an operator to load a file?
This separates the simple UI and the node tree, by allowing the user to input netCDFs directly in the node tree.

Maybe the input node can be split into two nodes?
Currently, the nodes allow to select any of the loaded netCDFs, but perhaps to better handle memory, unused netCDFs will be poped from the dictionary. I believe then, we could deprecate the input node with a file selection.

When you first apply the material to an object it does not use the resolution value provided.
I've tried to reproduce this issue, however, it seems to work for me, could you create an issue an explain the steps to reproduce it?

Node-section math.
The idea of this node is to allow transpose and flip axes, as well as to implement derivatives, isosurfaces, and other nodes by using xgcm and xarray.

TODO:
Distribute new nodes over the window space.
Modify materials to fit with @orioltinto suggestion.


Tooltip: stops working after backdrop filter is applied

Environment

Operating System: Darwin
Node Version:     v18.20.4
Nuxt Version:     3.11.2
CLI Version:      3.11.1
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      telemetry, server, runtimeConfig, devtools, ui, colorMode, swiper, app, site, ssr, ogImage, googleFonts, typescript, loading, tailwindcss, build, vite, i18n, gtag, dayjs, prometheus, modules
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Version
v2.9.0
Reproduction
https://stackblitz.com/edit/nuxt-ui-aaekcsib?file=app.config.ts,app.vue
Description
Every time that I want to apply a backdrop filter blur to the parent of the Tooltip component, the hover effect stops working and the tooltip doesn't show up. Can someone help me on this?
Thanks for your attention.
Additional context
No response
Logs

I don't exactly understand the purpose of blurring the tooltip's parent? Wouldn't the aim be to apply it to either the tootltip or the button?

@HugoRCD a parent div that I want to apply blur to the background of it, that's why I was using the backdrop filter on it. Not the tooltip itself.

I think it has something to do with that:
https://stackoverflow.com/questions/57327586/why-does-clip-path-and-other-properties-affect-the-stacking-order-z-index-of

I think this is a duplicate of #869 which is an upstream issue with Popper.js and as answered there we can't do much about this. However, this has been fixed in v3 already with the migration to Reka UI (Radix Vue) which now uses floating-ui.


v14 - .NET framework - Exception on start

Just downloaded v14. However, when I run RoslynPad.exe, I see this

and I can only close the window.

@raghur You should probably clean up your directory, seems like you have an older version of some assembly.

Did a fresh download and extracted to a new folder - still getting the same exception. Is there anything else from the environment that's picked up?

That can cause a MissingMethodException for an internal type? Not that I'm aware of. Very weird  :)
I just downloaded and extracted the version and it works for me. I'll try a different machine later.

I've tried on several different machines, this doesn't repro. Closing for now. Please reply if you have more info. You can also try compiling a version for yourself.

So installed 4.7.2 again and restarted and now the error has disappeared :-o


Fips patch ocp

Based on:

https://github.com/openshift-knative/eventing-kafka-broker/pull/269

Will be rebased after #269 got merged

merging this, as has no effect on the e2e tests


Rename tracing enums

This makes the enum names much more user-friendly on the SQL level.
We made them lowercase and removed the prefix.
See https://github.com/timescale/promscale_extension/pull/225 for
more details.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR:

[ ] CHANGELOG entry for user-facing changes
[ ] Updated the relevant documentation

@cevian This also needs respected changes in our mixins https://github.com/timescale/promscale/tree/master/docs/mixin/dashboards


scsh: Update to latest head, unbreaking build on macOS

This is just a minor change in autoconf header-file detection.
Description of changes
This just adds this PR, unbreaking the macOS build:
https://github.com/scheme/scsh/pull/49
Everything else is as before.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[X] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[X] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

4 neutral checks, doesn't look good...

Oh, a patch has been added in #294559.

@wegank Yes - and gets us to the same result as this one, so this PR can be closed.


Compact N support

I have adapted the code to suit a Nilan Compact_N (Nordic compact P model) and I see that the code tries to read the LED state for all modells. I have the CTS602 with HMI Touch panel which does not have any led, and apparently it seems like the modbus addresses are removed for my firmware.  Does every other version of the panel have the LED states? I see that the get_display_led_1_state is has "supported_devices": ("all",). If this is the case, can we maybe make a boolean in the config flow that ask the user if they have the HMI interface or not?
Logger: custom_components.nilan.device
source: custom_components/nilan/device.py:334
integration: Nilan (dokumentasjon, problemer)
first seen 11:30:26 (161 hendelser)
Last logged: 12:50:27
Could not read get_display_text_2
FIY.

Hi,
Sounds great. You are mistaken. The functionality is primarly determined by the modbus version (protocol version). Which is different depending on display etc. I think your model is another edge case, where you need to adhere to the compact +air/geo definitions. This is defined in device map, but also you need to add this device number to the device handling logic.

    "get_display_led_1_state": {
        "entity_type": "binary_sensor",
        "min_bus_version": 1,
        "max_bus_version": 19,
        "supported_devices": ("all",),
    },
    "get_display_led_2_state": {
        "entity_type": "binary_sensor",
        "min_bus_version": 1,
        "max_bus_version": 19,
        "supported_devices": ("all",),
    },
    "get_display_text_1": {
        "entity_type": "sensor",
        "min_bus_version": 1,
        "max_bus_version": 19,
        "supported_devices": ("all",),
    },
    "get_display_text_2": {
        "entity_type": "sensor",
        "min_bus_version": 1,
        "max_bus_version": 19,
        "supported_devices": ("all",),

These entities are the ones failing for my device, but the code says "supporte_devices" : ("all",),. Would the right way to handle this be to replace "all" with all of the device ID's execept for the model I am running (30 in the case for COMPACT_N)?

No. It is not that simple.

If you do that you can fix it for you, but you will not be able to receive updates in the future. I will not accept such thing in this integration, since it would break everything. You need to understand the code to be able to solve this on your own.

Sorry, I did not intending to offend, I just wanted to make sure I understood you correctly.
I written my own HA-integration before I discovered your integration which was more generic and mature. I thought I would help out as I also have access to the Nilan firmware files and have work quite a lot with the Modbus.
What is the best way to resolve this? Should I start looking into the modbus to find out what distinguishes the HMI interface from the classic one?

Can you share your modbus version, device id, and the pictures asked in the readme? As I said the logic is already implemented, but the device ID has to be added to it. Without this information I cannot help at all.

Device ID is 30, I will post the Modbus version when I find it.

Hi,
Ok.
Are you sure it is 30. Did you get this from the debug log or where?

I got it from debugging the Nilan component and and it also corresponds to the ID I have extracted before.

Have you found the Bus Version?

Bus version is 13. I see that you also check for a hps_bus_version, but I can't see that printed in the logs?

I also have also been working on mapping up the device, but I am not done yet.

Thanks. Unfortunately this means Nilan has made another outlier of this device.
Have you asked Nilan for a protocol manual for this? Could you please do this and provide that to me?

I made a table of all the firmwares available from the Nilan aftermarket site. Maybe the firmware version number is better for determining the capabilites?


More examples to the Sending Files Please

Hey @edisonchee,
Please add more examples to the Sending Files demo.
So far it only sends Photos. When I tried to copy and use sendVideo() I got the error of:
error_code":400,"description":"Bad Request: there is no video in the request"}
    at Request.then.resp (/.../node_modules/slimbot/src/telegram.js:61:15)

Are the video/document parameter supposed to be binary strings (obtained from fs.createReadStream)?
Thx

Hi @suntong, thanks for raising this issue. After looking at the source, I realised there are quite a number of bugs that need to be fixed:

sendVideo method and other send methods are not making requests with formData
it seems like you can no longer pass a fs.readStream object directly to any of the send methods
sendFile example code is actually broken

My bad. I'll update you here once I fix the bugs and publish a new release in a bit.

Send methods now make requests with formData if the file you're using is a readable stream.
sendFile no longer broken; let me know if you have any issues using it.

Fantastic! I'll give it a try. THX a lot!


Document normalized coordinates

Fixes #1044.
Please check those coordinates before merging.

Vulkan:

Vulkan 15.1.1: Normalized texel coordinates: The s coordinate goes from 0.0 to 1.0, left to right. The t coordinate goes from 0.0 to 1.0, top to bottom.
Vulkan A.3: fragment entry points must declare OriginUpperLeft.
SPIR-V (OriginUpperLeft): Pixel coordinates appear to originate in the upper left, and increase toward the right and downward.
Vulkan 23.2: In clip coordinates, the view volume is defined by: 0 <= z <= w

Metal:
https://developer.apple.com/library/ios/documentation/Miscellaneous/Conceptual/MetalProgrammingGuide/Render-Ctx/Render-Ctx.html#//apple_ref/doc/uid/TP40014221-CH7-SW34
LGTM

Oh thanks I did look at this page but expected some kind of graphical element and missed this text xD.

@homu r+

:pushpin: Commit 0ff9ddf has been approved by kvark

:zap: Test exempted - status


[BUG] Inky Impression displays have inverted colors.

On Inky Impression displays, black/white is inverted. Inverting the BG, and other colors doesn't fix this, neither does PIL inverting colors.
Continuing to try and fix this, but it may be a few days before I find a solution.

So with the wHAT display, I made the background images with GIMP. I had to index the colors so that they would properly show up. I'm seeing that the Impression varies a lot, but maybe there needs to be a new image created to suit that display. Check this out:
https://learn.pimoroni.com/article/getting-started-with-inky-what#displaying-images-on-inky-what

Will do. Thanks!

Update: Still trying to figure out what colors go where, but the background is now white with black text! We're getting somewhere!

okay - got something partially working, almost done!

Due to limitations of PIL, unfortunately I think having inverted colors are the only option. I'm going to try and see if there's an API to invert colors, but that requires sending images to a 3rd party.


Fix default Transaction#info [ECR-3193]:

Overview
Empty string caused panic in the native code,
and, subsequently, failed request processing.
Made #info return an empty object, though, one might
argue it will be more difficult to understand
why transactions returns nothing. That, however,
is to be addressed after Dynamic Services.

See: https://jira.bf.local/browse/ECR-3193
Definition of Done

[ ] There are no TODOs left in the code
[ ] Change is covered by automated tests
[ ] The coding guidelines are followed
[ ] Public API has Javadoc
[ ] Method preconditions are checked and documented in the Javadoc of the method
[ ] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Pardon me, but why not return the actual status of the transaction instead of an empty object?

this would be aligned with the behaviour exhibited by similar services written in Rust
JS light client inherently expects some status in Transaction.send method (which polls blockchain until status of the tx changes to committed)

For example, the front end for the cryptocurrency Java service uses Transaction.send
https://github.com/exonum/exonum-java-binding/blob/5ea07356bf6005d1b7bfe90c83a6539a412d44ae/exonum-java-binding/cryptocurrency-demo/frontend/src/plugins/blockchain.js#L79
This method will fail if the info method is not overridden as such
https://github.com/exonum/exonum-java-binding/blob/master/exonum-java-binding/cryptocurrency-demo/src/main/java/com/exonum/binding/cryptocurrency/transactions/CreateWalletTx.java#L83

I am not sure I understand — you will get everything you see here: https://github.com/exonum/exonum-java-binding/blob/7225ed76b143051a996bab1120de26a15fe2e469/exonum-light-client/src/main/java/com/exonum/client/response/TransactionResponse.java#L29
in the response, i.e.:
{
  "type": "committed",
  "content": {
    "comment": "That's our default Transaction#info below, everything else is intact:",
    "debug": {},
    "message": "41c453a7f45cb0dd73644aa376d3802bb7da4c6797bcf6749211fbcabb5aa8710000800000000a220a20ae740320999e335dd4f5fdc0468f34eb46544aa1995b6cacfcedc82428bd71dd100a1896f7fda8bf8c8af71cfccd80d4c0d5d6f82955cf7c081969282604d3f7e416274a4319484ceea947981b8d337bd170210acd62508f3663acba395bd131456c0b6cd7f09690aec68a05"
  },
  "location": {
    "block_height": 11,
    "position_in_block": 0
  },
  "location_proof": {
    "val": "2f23541b10b258dfc80693ed1bf6ed6f53ccf8908047f7d33e0fec4f29a4a613"
  },
  "status": {
    "type": "success"
  }
}

The thing that Transaction#info returns is put in an extra field content.debug. It isn't even included in TransactionResponse in Java light client.


Create Contact Page Design

I redesigned the contact pages for both desktop and mobile in Hi-FI.


Add ability to change columnLength

@sdepold

I assume changes to umzug will not be backported into sequelize core, right?

So basically we would like to be able to configure the datatype of the column right?

It doesn't really couple this to Sequelize any more than it currently is. It's not unreasonable to assume that each different storage mechanism will require different options.
That being said, @sdepold is right, the underlying issue is one of configurable datatype, so maybe a better solution is to change that rather than explicitly changing the key length. I'm not sure how you'd like to add that level of abstraction.

Oh. Wow. I totally missed that this is a PR

Maybe it would be the better idea to actually pass the type of the column rather than the length of the varchar?

Btw. after this change we have to actually pass the options to umzug here: https://github.com/sequelize/cli/blob/master/lib/tasks/db.js#L224

Hi @Willyham,
in case you are providing a PR for the CLI either, would you consider this ticket as well ? https://github.com/sequelize/cli/issues/20

Sorry, just got around to this. I'll hopefully follow up with a CLI diff next week and then I'll take a look at that one too.

Thanks for your excellent work :)

Released as 1.3.0


how can i inject html after input

I need to add this html code after input tag

what can I do?

Hey @mohammad6006,
Would you like to elaborate more on what are you trying to do? cause I can't get your point...

But It doesn't work correctly
as you see in this image

It rendered in ul list but I need inject it after input tag in div form group
its main html code without autocomplete :

                        <input type="text" class="form-control" id="inputSuccess" placeholder="کافه رستورانو...">

I couldn't find any method to render span tag after input tag in div form-group


Add --version flag

I found this useful, because I wasn't always sure which version I'm at.
Let me know if you prefer some adjustments!

Well, it's your choice. But I think having a --version is a good practise to have.
It doesn't show the version upon startup for me, at least not with a valid config? Some automations rely on version checks (e.g. when automatically updating once a version get's out of date).
 tibber-exporter
2023/12/04 20:30:30 Starting tibber-exporter (https://github.com/terjesannum/tibber-exporter)
2023/12/04 20:30:30 Error getting homes: Message: 400 Bad Request; body: "{\"errors\":[{\"message\":\"Context creation failed: no token specified\",\"extensions\":{\"code\":\"UNAUTHENTICATED\"}}]}\n", Locations: [], Extensions: map[code:request_error]. Exiting...

Also, this patch adds the current version as a Prometheus metic, which might also be nice to have (when e.g. running a fleet of exporters).

If you run your own build you don't get any version, that is set by the github action and present in the prebuilt binaries and docker image:
https://github.com/terjesannum/tibber-exporter/blob/806e1870508e8221d5af670fd4e72f9d869b0d15/.github/workflows/release.yaml#L40
https://github.com/terjesannum/tibber-exporter/blob/806e1870508e8221d5af670fd4e72f9d869b0d15/.github/workflows/release.yaml#L103
I have no problem with adding a --version option, and having it as a metric too is a nice feature. But it should then use the same mechanism used to set the version in the user-agent and don't be a constant in the source code.

You're right, I'm using nixOS which builds my exporters automatically.
I agree that using the same procedure is nice, but I'm not sure if that's possible in a way that works with Github actions as well as with a default GO build. Maybe an environment variable?
I've also noticed that https://github.com/terjesannum/tibber-exporter/blob/master/charts/tibber-exporter/Chart.yaml#L3 uses a hardcoded version, too?

Other popular exporters, like postgres_exporter or node_exporter use a central VERSION file.

Not much different from here really. The version in consistent in all artifacts, but the source is the version in the helm chart not a separate file.
If you want to set a version in your go build, just use -ldflags '-X main.userAgent=tibber-exporter/x.x.x'

I like your idea of also getting the version in a build_info metric, so I think I will merge this as it is and make the necessary adjustments in the build workflow. Thanks

I think everything is ready now. If you do your own build, there is now a Makefile which should set all the ldflags for you


Filter/Export

Hi, pretty great app to work with Notes... Im wondering if you can filter by country? ( select only user notes country specific ). And the other question is about export Notes like Geojson?
Thanks a lot!

Filter by country - not yet, depends on what you mean by it:

if it's downloading notes only for a specific country: There's no easy way to get them though the api, geographically it can limit the selection only by bounding boxes. I plan to implement getting note ids from arbitrary xml feeds which is going to make it possible to use Pascal Neis' note feeds for a specific country. But that won't let you see all of the user's notes.
if it's hiding part of downloaded notes not belonging to a country using the Filter form: I'd have to either store country boundaries or ask Nominatim or similar service for a boundary... In the latter case it could be not just a country boundary but any kind of a boundary. Then I'd have to come up with a filter syntax for note locations. Current filter implementation only works with comments.

The general idea is to simplify working with notes... We are doing something like a Mapathon but with Notes ( Notathon )[1], and having an app like "osm-note-viewer" help a lot because we can organize better the notes resolution ( export / filter / etc ). Maybe in the future we can export Notes directly to "Divide and Map"[2] to help with this task.
[1] https://www.openstreetmap.org/user/AngocA/diary/399317
[2] https://www.damn-project.org/
Thanks for your great work!

Added GeoJSON selected notes export similar to GPX export.

Added showing API requests when Show request parameters and URLs checkbox is checked. It prints links with API requests under Fetch notes and Load more buttons. For Fetch notes there are links for data in various formats like xml and rss.
Like I said earlier, it can function as kind export with data exported directly from the OSM API. It may be enough if you don't use the filter or note checkboxes inside note-viewer and set the limit high enough to download all the notes you're interested in.

Added this:

I plan to implement getting note ids from arbitrary xml feeds which is going to make it possible to use Pascal Neis' note feeds for a specific country. But that won't let you see all of the user's notes.

Use Load an XML file dialog above the filter. Later I'll make tabs to switch between different download dialogs.

Added tabs.

Added tabs.

Awesome tabs upgrade :-)

Hi, closing this... Thanks a lot!!


Cannot grab browser logs on failure with multiple workers - question

What are you trying to achieve?
I want to grab browser logs when some test failed, tests are run using command: ./node_modules/.bin/codeceptjs run-workers 2 --grep "@sometesttag" --plugins allure
And I see that custom hook:
event.dispatcher.on(event.test.failed, async (test, error) => {

})

inside which I use await I.grabBrowserLogs(); is not working when we use multiple workers. (when we use run-workers command, with run this code works OK)
Tried also surround some part of the code with try / catch block and call await I.grabBrowserLogs(); on error, but it does not work either.
Is this possible to make it working, simply to grab logs from browser on test failure (i.e. some element is not clickable on the page, or it is not in DOM), when we are using multiple workers? FYI - with standard run command I am using custom hook and it works like a charm. And I would like to achieve something similar but when multiple workers are used. Is this possible? I believe it might be doable using https://codecept.io/parallel/#custom-parallel-execution but then, I assume that browser control must be customized as well, and then we simply won't be able to use built-in method on I actor, right?
Details

CodeceptJS version: 3.0.5
NodeJS Version: 12.20.2
Operating System: macOS Catalina
puppeteer

Good idea for feature


Integration issue with kotlinx.serialization plugin: kotlinx.serialization compiler plugin internal error: unable to transform declaration

Molecule version: 0.7.0
Kotlin version: 1.8.0, 1.8.10
Kotlinx Serialisation: 1.5.0-RC
> Task :shared:compileKotlinIosSimulatorArm64 FAILED
e: Compilation failed: Back-end: Please report this problem https://kotl.in/issue
/Users/TFNX46/Developer/MULTIPLATFORM/KotlinXIssues/shared/src/commonMain/kotlin/io/github/xxfast/kotlinx/issues/Models.kt:5:1
Problem with `@Serializable
@StabilityInferred(parameters = 0)
sealed class EntitySearchResult {
  protected constructor() /* primary */ {
    super/*Any*/()
    /* <init>() */

  }

  companion object Companion : SerializerFactory {
    private constructor() /* primary */ {
      super/*Any*/()
      /* <init>() */

    }

    @GCUnsafeCall(callee = "Kotlin_Any_equals")
    external /* fake */ override operator fun equals(other: Any?):  Boolean
  /* fake */ override fun hashCode(): Int
  /* fake */ override fun toString(): String
  @Deprecated(message = "This synthesized declaration should not be used directly", replaceWith = ReplaceWith(expression = "", imports = []), level = DeprecationLevel.HIDDEN)
  constructor(seen1: Int, serializationConstructorMarker: SerializationConstructorMarker?)
  private val $stableprop: Int
    field = 0

}

`
Details: kotlinx.serialization compiler plugin internal error: unable to transform declaration, see cause

 * Source files: Models.kt
 * Compiler version info: Konan: 1.8.10 / Kotlin: 1.8.10
 * Output kind: LIBRARY

This took me a while to figure out what exactly was causing this problem. I've raised this issue on kotlinx.serialization issue tracker but from what they mentioned, this was due to

In short, compose plugin produces incorrect IR which serialization plugin is unable to work with

I was originally suspecting it was compose-multiplatform that was causing this issue (given that there is a similar issue), but after isolating the issue to a standalone project - i was able to pinpoint this to molecule, or the version of compose compiler plugin that used by molecule gradle plugin, is what causing this issue.
Full stacktace.log
Standalone project to reproduce the issue: KotlinXIssues.zip

Pretty sure this is fixed by https://github.com/JetBrains/androidx/pull/371 and we just need to point at the JetBrains compiler and give up pointing at AndroidX. This is the approach we've taken with Redwood now. May as well do the same here.

@JakeWharton why was this switched from jetbrains to androidx compose compiler?

Because all the necessary fixes were upstreamed


Hotkeys not being saved

On my local setup the mod does not save hotkeys after changing them.
This is especially annoying since it shares a key with liteatica.

Which version of the mod are you using? It was supposed to be fixed in 1.1.

I downloaded the latest version from Modrinth.
Hmm yeah I ended up with that Version somehow.

As per v1.4.0 hotkeys are stored in /.minecraft/config/redstone_multimeter/hotkeys.txt which makes sure they are saved even when the game is launched without the mod installed. That means this issue is finally properly fixed.


goimports - reports improperly formatted file as "file is not goimported"

When running gometalinter.v2 with --enable=goimports on a directory containing a file that hasn't been through gofmt, I get an error which seems to suggest that the file has something wrong with the imports rather than the format. When consulting with README.md for the gometalinter, it describes goimports as "Checks missing or unreferenced package imports" which would lead one to further believe there is something wrong with the imports despite go building and testing properly. Since the format is at fault, I would expect a message like "file not formatted" or "file needs gofmt" instead of "file is not goimported".
main.go:1::warning: file is not goimported (goimports)
Simple example of issue here: https://github.com/briantkennedy/gometalinter-issue

https://godoc.org/golang.org/x/tools/cmd/goimports

In addition to fixing imports, goimports also formats your code in the same style as gofmt so it can be used as a replacement for your editor's gofmt-on-save hook.

This is how goimports is implemented. It's gofmt + "import formatting". I don't see any way to adjust that behaviour.
I'm going to close this issue, since I don't think there is any way to make this work the way you want, but please do comment if I've missed something.

My main comment is that it refers to using goimports as "goimported" which does not seem like an effective term to explain what's going on here. Google searching for "goimported" yeilds 227 results that are all bug descriptions, so it would be helpful for the error message to say "you need to run goimports on this file" instead of using the term "goimported" which isn't realy well defined anywhere.

I am new to Go, and gometalinter, but I just spent 20 minutes trying to track down the meaning of file is not goimported (goimports). Fortunately, I found this thread eventually, and realized I was missing a newline in between a built in package import and a github package import.

@dnephin It looks like another user has encountered the same issue, you may want to reconsider the error message emitted when the file is not properly formatted.

golangci-lint reports it slightly differently, and better IMO:
$ golangci-lint run -E goimports
main.go:12: File is not goimports-ed (goimports)

I see this error and I know it is a format issue now. No big deal. Except, best I can tell there is no way for either gofmt or goimports to tell me why and where the error is.
Ultimately this seems like an issue with gofmt, but adding to this conversation incase someone knows what I am missing.


Admin Page: Unnecessary Network Requests on Keydown

AHHHHHH BUGS EVERYWHERE!!!
jk jk
Description
When I type, on each letter keydown, an unnecessary network request is made.
To Reproduce
Steps to reproduce the behavior:

Go to 'http://localhost:3000/#/Admin/Login'
Click on the 'Username' field
Open dev tools with option+command+J
Type 1 letter, see network request error to access tokens in console. Type another letter to see another request made.
This also occurs within the 'Password' field

Expected behavior
I expected a network request not to be made to access tokens.
Screenshots
If applicable, add screenshots to help explain your problem.

take a screenshot

Mac: shift + command + 3
Windows: use desired screenshot program

drag & drop screenshot image here:

System Info (please complete the following information):

Device: Macbook Air
OS: Mac
Browser: Chrome
Version 72.0.3626.121 (Official Build) (64-bit)

Additional context
N/A

Working on this.


Create interactive Card (Our rockets)  and responsive background

I have made changes in card and background

@Wadgaonkarprathameshdeepak , please remove the background color , I want to go with the current color it have.

ok
On Tue, 20 Feb 2024 at 14:11, Jagroop @.***> wrote:

@Wadgaonkarprathameshdeepak
https://github.com/Wadgaonkarprathameshdeepak , please remove the
background color , I want to go with the current color it have.
—
Reply to this email directly, view it on GitHub
https://github.com/Jagroop2001/AcmeRockets/pull/106#issuecomment-1953722529,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWYZGUXJPHKERLKWPB2MFETYUROVLAVCNFSM6AAAAABDNF6G76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTG4ZDENJSHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

I made changes as you said please check it


Add support of multiple wallets

It closes #580 and fixes #630
Also, I've introduced tests and added running them as a part of CI workflow.

Meanwhile, when the User recovers the wallet from the file — we do not copy it and just store the path to this file.
When Smapp has more than one wallet available — it shows up dropdown on the unlock screen.

We discussed with @avive that we need to tweak these things:

The restore existing wallet screen should have 2 commands: 1. Open from file. 2. Restore from 12 words
In short, change the label of the button :)
When displaying wallets' drop-down, remove the parentheses and format date-time in a more user-friendly manner. e.g Tuesday, March 3rd, 16:50pm
The default name for the 2nd user-created wallet is not good - it is currently called exactly like the first one, "Main wallet". It should be automatically called ‘Wallet 1’, ‘Wallet 2’, etc by default so the names are uniques and the user can always rename a wallet from settings….


Changelog for tools.fastlane:screengrab:1.0.2

Can't find an information about what is changed for  tools.fastlane:screengrab [1.0.1 -> 1.0.2]. Is there somewhere CHANGELOG.md maintained? Could you post a link, please?
✅ fastlane environment ✅
Stack

Key
Value

OS
10.11.4

Ruby
2.2.4

Bundler?
false

Git
git version 2.12.0

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.11.4 (15E65)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
false

Is homebrew
true

Is installed via Fabric.app
false

Xcode Path
/Library/Developer/CommandLineTools/

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.28.7
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
1.5.1

CFPropertyList
2.3.5

claide
1.0.1

colored2
3.1.2

nanaimo
0.2.3

xcodeproj
1.4.4

rouge
1.11.1

xcpretty
0.2.6

terminal-notifier
1.7.1

unicode-display_width
1.1.3

terminal-table
1.7.3

plist
3.2.0

public_suffix
2.0.5

addressable
2.5.1

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.5.0

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.4

excon
0.55.0

faraday
0.12.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.0

gh_inspector
1.0.3

uber
0.0.15

representable
2.3.0

retriable
2.1.0

mime-types-data
3.2016.0521

mime-types
3.1

hurley
0.2

little-plugger
1.1.4

multi_json
1.12.1

logging
2.2.2

jwt
1.5.6

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

google-api-client
0.9.28

json
1.8.1

mini_magick
4.5.1

multi_xml
0.6.0

rubyzip
1.2.1

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.0

bundler
1.14.6

faraday_middleware
<IP_ADDRESS>

generated on: 2017-05-03

Same issue. 1.0.3 is release, but how do we supposed to figure out what is changed? 🤔

No, the issue is not resolved. There is an 1.1.0 binary available but where is the changelog.
Should we update? Should we not? Whats changed? Is it backward compatible? Any breaking changes?
Should we just ignore any updates for tools.fastlane:screengrab because apparently they are used internally and not meant to be used outside.

Sorry for the late reply. I don't think there was any changes, besides bugfixes.


Disable video controls on explore cards

since we have buy now and cart displayed over it, it does not make sense to have video controls - lets leave them for detail

I will probably do a followup with adding icons to the cards so its clear that its video

but, since we no longer autoplay videos in explorer
disabling video controls would mean that video cards are unplayable

video cards are unplayable

yes, it is blocked by the cart and buy controls anyway

👋


Clicking on items in the navigation area doesn't work

https://constructs.dev/packages/cdk-construct-simple-nat/v/0.1.125?lang=typescript#whats-the-difference-between-ec2-nat-instancesnatinstances-and-nat-instances-created-by-this-construct
Try to click the items under the FAQ

This appears to be due to link-in-link here, making the heading anchor not be what it's supposed to be.


chore: add jpengar as codeowner

What type of PR is this?

subproject management

What this PR does / why we need it:
Jesus Peña will be leading TEF participation in this WG

I have approved, but Github says:
Unknown owner on line 8: make sure @jpengar exists and has write access to the repository

Change the write access rights and will merge now. Then you should be set.


chore(deps): update devdependency @types/node to ^20.11.16

This PR contains the following updates:

Package
Type
Update
Change

@types/node (source)
devDependencies
patch
^20.11.15 -> ^20.11.16

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Hywax Assistant.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (48ee4de) 100.00% compared to head (5377fe2) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          146       146
  Branches        26        26
=========================================
  Hits           146       146

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Wrong line separators again but line 635

I'm using Android studio with mac os x, when i try to add Template it say:
Wrong line separators: '...e License.\r\n-->\n\n\n\n<re...' at offset 635 (show balloon)
please help!

Check the other issues for help

#1 can't sloved problem for me. plz check it again...

Could you describe how are you installing the template?

I clone lastest version of git and download release   in you blog. But both can't creat template.

I followed all step to setup template

I'm not on my PC right now. And I find really weird that bug. Could you search for a tool called dos2unix and run that tool on the file that is generating the problem. Or build a script that runs that tool on all files?

I'm sorry, i try to use dos2unix to replace \r\n --> \n\n but it not work, same error. :D
I'm comeback to win to create project to use template. but you fix it next version. Thank a lot!

I've been looking at my project and I don't seem to find any word "License" on it. Could you tell me what file is creating the error?


PackSelection: Reinstate white background

PackSelection has an EkSlidableGrid, not an EkChannelCard, so removing the 'hasWhiteBackground' property was a mistake.
Reinstate that.

GitHub forbids me to approve this, but a Canadian bird was happy with this fix!


Invalid IP

Hi!
I had a Koha installation where the EDS plugin was working nicely, but after some upgrades it does not work. I have narrowed the problem down to this:
When I go to the configure page, I enter the username, password, profileid and customerid, plus all the other information requested. Then I click on "Load setting from EBSCOadmin now", a small window appears and disappears, the button says to wait 10 seconds and then an error is displayed in the "ED settings" field:
{"DetailedErrorDescription":"InvalidÂ IP.","ErrorDescription":"Invalid IP","ErrorNumber":"139"}
I also notice that the password field has changed. The customer's password contains a @, but this has disappeared!
EBSCO Support has provided me with the information "In EBSCOAdmin you have the following IP addresses registered...", and I have entered them into the "IP Addresses" field.
So I am confused as to which IP is invalid? Do I have to do the configuration from one of the IPs that are recognized as belonging to the customer? Can I enter my own IP into the IP field? Any clarification would be most welcome!
Best regards,
Magnus Enger
Libriotech, Norway

Any thoughts on this?

We have the same problem. Any updates?

The "Invalid IP"-error went away when EBSCO added the IP of the Koha server to their list of accepted IPs. Now I get the EDS Settings back from the server, but when I try to save the config form I get a 500 Internal Server Error.

Ah it looks like the 500 error does not matter. The config is saved and EDS works in the OPAC again! I suspect the 500 will be solved by #68.

I was going to circle back to this after the 1905 release is out but looks like you've found the solution. You can contact EBSCO support to get them to add the IP address to your EDS profile, or do it yourself here. Shouldn't be a too common of an issue though.
Thanks!


Refresh charts view when the data change

Hello, I have this problem: I like to refresh the chart when i change the values of the dataSet, but with an animation that pass from the actual values to the new values directly (not refresh the chart going to the begining).
If someone has the solution I will be grateful.

:+1:

Duplicate https://github.com/danielgindi/ios-charts/issues/189


winter_workshop

👷 Deploy Preview for rayko-research processing.

Name
Link

🔨 Latest commit
23316c8ece3cee2c97dfa1f9e87ca692ac8b2e7c

🔍 Latest deploy log
https://app.netlify.com/sites/rayko-research/deploys/66f4c5f45d233500090b555c


draw a call graph of the google apps codebase

Using a technique such as http://stackoverflow.com/a/14244166
draw a diagram or two showing which function calls which.

if drawing more than one diagram, you could break it down by end-user menu options.


Make compatible with gym 0.23.1

Description
Adapted to gym version 0.23.1. The following changes were made:

Adapt setup.py.
Replace GoalEnv with Env.
Explicitly set data type of Box spaces to np.float64 (as observations are np.float64 and gym does not ignore this in contains anymore).
Imported gym_wrappers to be able to make reach-v0 environment with gym.make.

How I Tested
Ran tests with pytest.

Sorry about the swap files. I removed them and added *.swp to .gitignore. I also ran black.

Thanks a lot!


Refactor of document importing

I am leaving a few issues at the same time, but this is just the things a noticed in the last couple of days and a reminder for me if I want to do some PRs.
Document importing is the major cornerstone of Papermerge, but right now the code is scattered in a few places and it does not support plugins at all. One solution would be to make an importer app and move the DocumentImporter class there. Then I propose there should be a split with a new class DocumentProcessor. As subclasses DocumentValidator would check mimetypes (using python-magic and not file extension) and count pages, while DocumentImporter does the actual importing itself. They could also be merged into DocumentProcessor. Then such a class could be used both in the upload view and other importers to do all the heavy lifting. This would allow to add custom pre- and post- processing on the documents and go a long way to provide more pluggability.
This is just a proposal, the spirit is to make document importing more unified and modular, so a number of solutions is possible.

@francescocarzaniga, description is too generic. Maybe you can be more specific.

I guess this and #167 stem from the same problem, lack of plugin support. This issue is a suggestion to change the document importing system to be more modular and plugin-friendly.
While I think this may not be urgent, the sooner you standardise a plugin system and document it the quicker people will get on board. If you truly want Papermerge to be plugin centric, then more people working on plugins => more features => bigger userbase.

lack of plugin support.

I am working on it ... :). In future Papermerge will be apps (app=plugin in django parlance) oriented.

@francescocarzaniga
Document Pipelines are now part of Papermerge.


it does not install latest version like nvm does

Hello! :octocat:
I want to talk about the handling of versions in nvm-windows in compare to nvm and semver. I know that you already talked about this, like here. But I would like to bring this back to topic, because I think this is actually a pretty neat feature and would be nice for automated tasks too.
To be honest, I actually don't see a usecase for the current handling instead of the handling like nvm nad semver uses it.
I understand that you don't want toy copy the behavior of nvm, what always installs/ueses the latest possible version of a given semver.
For all who don't understand what I'm talking about. When using nvm (or things like semver) it will always use the latest possible version availbale:
$ nvm install 6    ->  will install node 6.10.3
$ nvm install 6.9  ->  will install node 6.9.5
$ nvm use 7        ->  will use node 7.10.0
$ nvm use 4.8.X    ->  will use node 4.8.3

What nvm-windows currently does is just to assume the lowest version available:
$ nvm install 6    ->  will install node 6.0.0
$ nvm install 6.9  ->  will install node 6.9.0
$ nvm use 7        ->  will use node 7.0.0
$ nvm use 4.8.X    ->  will use node 4.8.0

So, you don't want to implement that behavior. I don't know why you would like to have it this way, but I'm fine with this. But how about a new command parameter for the commands install and use to select the latest version?
$ nvm install 7 --latest
$ nvm use 7 --latest

$ nvm install latest 6
$ nvm use latest 6

$ nvm install -l 6
$ nvm use -l 4.3

With such commands, it is easily possible to create script and use a behavior like travis does in test runners (which actually uses nvm). This will remove a huge overhead to look for the latest version and put them manually in test cases and runners.
Thanks in advance! Looking forward to what you think about this ...

I am not opposed to this particular feature and there has been some progress towards it tracked in #214.
Just to clarify my position re: nvm, I'm not trying to keep NVM4W different for difference sake. It has some great ideas that clearly resonate with people. My stance is to separate opinionated workflow from non-opinionated workflow. This pretty much means anything that has to do with project-level or per-shell-level configurations. There is still value in project-level configurations, but it differs by user/opinion/need. I feel there are alternative ways to serve this need that are more flexible, which is what I'm working towards for the next major version (which is cross-platform).
Using the latest release of a particular major version falls into system level configuration, so I think it's a perfectly valid use case to add now. The only reason I haven't added it already is time constraints.
I'm going to close this since there are a few other related threads already open.


Build issues since commit 0e64e49

Logs are full of errors like this:
(1:661338) postcss-is-pseudo-class: Complex selectors in '.app-body .actions-modal ul li:not(:empty) a:is(:focus button)' can not be transformed to an equivalent selector without ':is()'.

Thanks. Is there a Github issue to track this Mastodon-related issue?


App script Microsoft.Azure.EventHubs is deprecated

Currently I am working on some diagnostic code to view IoT Hub messages (via Event Hub). I am currently just trying to get everything to work in the 1st place (without the event grid). So I am using the C# Script in the Function App (will be replaced by C# later on).
If I look in the documentation on how to display the full EventData packet I see that Microsoft.Azure.EventHubs package is being used.
However if we look on nuget this package is deprecated.
What has to change in the script in order to make it work again?
If I update the script to the following.
#r "Azure.Messaging.EventHubs"

using System.Text;
using System;
using Azure.Messaging.EventHubs;

public void Run(EventData myEventHubMessage,
    DateTime enqueuedTimeUtc,
    Int64 sequenceNumber,
    string offset,
    TraceWriter log)
{
    log.Info($"Event: {Encoding.UTF8.GetString(myEventHubMessage.Body)}");
    log.Info($"EnqueuedTimeUtc={myEventHubMessage.SystemProperties.EnqueuedTimeUtc}");
    log.Info($"SequenceNumber={myEventHubMessage.SystemProperties.SequenceNumber}");
    log.Info($"Offset={myEventHubMessage.SystemProperties.Offset}");

    // Metadata accessed by using binding expressions
    log.Info($"EnqueuedTimeUtc={enqueuedTimeUtc}");
    log.Info($"SequenceNumber={sequenceNumber}");
    log.Info($"Offset={offset}");
}

I am getting an Function compilation error as well as a few other exceptions and warnings.
run.csx(11,5): warning CS0618: 'TraceWriter' is obsolete: 'Will be removed in an upcoming version. Use Microsoft.Extensions.Logging.ILogger instead.'
run.csx(13,48): error CS1503: Argument 1: cannot convert from 'System.ReadOnlyMemory<byte>' to 'System.ReadOnlySpan<byte>'
run.csx(14,68): error CS1061: 'IReadOnlyDictionary<string, object>' does not contain a definition for 'EnqueuedTimeUtc' and no accessible extension method 'EnqueuedTimeUtc' accepting a first argument of type 'IReadOnlyDictionary<string, object>' could be found (are you missing a using directive or an assembly reference?)
run.csx(15,67): error CS1061: 'IReadOnlyDictionary<string, object>' does not contain a definition for 'SequenceNumber' and no accessible extension method 'SequenceNumber' accepting a first argument of type 'IReadOnlyDictionary<string, object>' could be found (are you missing a using directive or an assembly reference?)
run.csx(16,59): error CS1061: 'IReadOnlyDictionary<string, object>' does not contain a definition for 'Offset' and no accessible extension method 'Offset' accepting a first argument of type 'IReadOnlyDictionary<string, object>' could be found (are you missing a using directive or an assembly reference?)

Edit: I just noticed the string sample is also wrong.
It should be more like this (the default sample)
using System;

public static void Run(string myIoTHubMessage, ILogger log)
{
    log.LogInformation($"C# IoT Hub trigger function processed a message: {myIoTHubMessage}");
}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a109c38e-b241-c9a2-7ef8-2e828659191c
Version Independent ID: 69842b0f-607f-5cf5-6e1a-4d312c98100c
Content: Azure Event Hubs trigger for Azure Functions
Content Source: articles/azure-functions/functions-bindings-event-hubs-trigger.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@the-programmer
Thanks for your feedback! We will investigate and update as appropriate.


getkey not working on mac

My code is like this

import readchar

def console_loop():
    while True:
        key = readchar.readkey()
        print(key)

def main():
    console_loop()

I get the following error.
Traceback (most recent call last):
  File "/Users/current_user/Dropbox/Coding/Python/current_project/main.py", line 19, in <module>
    main()
  File "/Users/current_user/Dropbox/Coding/Python/current_project/main.py", line 11, in main
    console_loop()
  File "/Users/current_user/Dropbox/Coding/Python/current_project/main.py", line 7, in console_loop
    key = readchar.readkey()
  File "/Users/current_user/.virtualenvs/current_project/lib/python3.5/site-packages/readchar/readchar.py", line 20, in readkey
    c1 = getchar()
  File "/Users/current_user/.virtualenvs/current_project/lib/python3.5/site-packages/readchar/readchar_linux.py", line 12, in readchar
    old_settings = termios.tcgetattr(fd)
termios.error: (25, 'Inappropriate ioctl for device')

i installed readchar-0.7 using pip

I think this should be closed because I am running mac with readchar==2.0.1 and it works fine.


🎨 [UI] Implement Payments > Verify payments page

Please describe the improvement request
Developers need a way to verify the status of payments initiated using the Lazerpay payment SDK.
Describe the solution you'd like
Design and code the functionality to explain payment verification
Does this solution have a figma design url attached to it? paste it here (optional)
Figma URL

Hi @MeisterJustice, I would like to work on this

you can go ahead please

Alright, on it

Hi @MeisterJustice , I noticed the syntax highlighting for the code block in the "Official JS SDK" section isn't working. I want to confirm if it's an issue from my side.

@MeisterJustice Also, there's currently no component for the RESPONSE snippets. I'm kinda stuck on it at the moment, what do you suggest I do?

Thanks for pointing these out @gzkdev . I'm going to create an issue for this. We can have one of our engineers hop on this, or do you want to take it on?

I'll create an issue for the RESPONSE snippets component. As for the syntax highlighting the issue, I think issue #21 will help resolve that.
Bear with me for a slow response, please.  Can I make a pull request for the changes I've already made?


Add capability for additional network plugin related packet capture

RFE : Parameterize NetworkType related packet capture.

/lgtm
thanks! @a7vicky

/lgtm

/lgtm

/approve


Tests fail with Rakudo v2020.12 or later

The failures are due to rebinding of typed variables no longer being valid. zef install --force-test in the meantime.

Fixed by https://github.com/Kaiepi/raku-container-action/commit/89927f9fd2c35a3d63937e1f0fd5030059203c08.

A release still needs to be made.

Resolved in release v0.2.5.