Improve mapping for classes and exceptions with required properties

The C# mapping for a simple class Person:
class Person {
    name: string
    age: int32
    tag(1) phoneNumber: string?
}

is currently:
public partial class Person : SliceClass
{
    public string Name { get; set; }

    public int Age { get; set; }

    public string? PhoneNumber { get; set; }

    /// Constructs a new instance of <see cref="Person" />.
    public Person(
        string name,
        int age,
        string? phoneNumber)
    {
        this.Name = name;
        this.Age = age;
        this.PhoneNumber = phoneNumber;
    }

    /// Constructs a new instance of <see cref="Person" />.
    public Person(
        string name,
        int age)
    {
        this.Name = name;
        this.Age = age;
    }

    /// Constructs a new instance of <see cref="Person"/> for the Slice decoder.
    [global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
    public Person()
    {
        this.Name = default!;
    }

    // encode/decode logic
}

We provide:

a primary constructor to initialize all properties (including nullable properties and value types that have a reasonable default)
(optionally) another constructor to initialize all non-tagged properties
a hidden parameterless constructor used for decoding. This paramerless ctor assigns default! to all properties with a non-nullable reference type.

This structure is dictated in large part by the Slice1 decoding logic for classes and exceptions, where we decode the fields of the most derived slice first and then go up the inheritance chain.
Proposal:

Always make the parameterless constructor public / non-hidden, with an empty body (no more = default!)
Add required to all properties with a non-nullable reference type
When there is at least one required property, add [SetsRequiredMembers] to the generated constructor(s) other than the parameterless constructor.

This gives users more flexibility while making the generated code cleaner.

Always make the parameterless constructor public / non-hidden, with an empty body (no more = default!)

Doesn't this result in a warning about non-required required properties not being initialized?

Doesn't this result in a warning about non-required required properties not being initialized?

It does not, provided all properties with non-nullable reference types are marked "required".


Foundation: populate the .creationDate attribute on Windows

Ensure that we pass along the creation date from stat when querying
the attributes of an item.  This was being dropped resulting in the
creation date for files being unavailable.
Partially addresses SR-13617

@swift-ci please test

CC: @spevans @millenomi

@swift-ci please test

Hmm, appears that ctime is not available on Darwin's stbuf?

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test


ttl - second vs minute

In Laravel 5.5 cache ttl is set in minutes and in the latest code seconds is used, any chance for a config setting for ttl, or other solution?
private function setAccessToken($accessToken, $ttlSeconds = null)
{
    Cache::tags($this->cache_tags)->put('access-token', $accessToken, $ttlSeconds ?? Carbon::now()->addHour());
     return $this;
}

We can't update right now the project to L5.8+ because it's so huge not feasible
thanks

Hmmm, don't want to create a separate branch... and the value is also dynamically set on responses from the Goto API. For example:
`
private function refreshAccessToken()
{
$response = $this->sendAuthenticationRequest([
'grant_type' => 'refresh_token',
'refresh_token' => $this->getRefreshToken(),
]);
    $this->setAccessToken($response->access_token, $response->expires_in);

    return $response;
}

`
Any ideas on how we can have both worlds in there?

Our recommendation:
Modify the following method in the trait Slakbal\Gotowebinar\Client\AccessProvider
private function setAccessToken($accessToken, $ttlSeconds = null)
{
    Cache::tags($this->cache_tags)->put('access-token', $accessToken, $ttlSeconds
        ? Carbon::now()->addSeconds($ttlSeconds)
        : Carbon::now()->addHour()
    );

    return $this;
}

same approach works with setRefreshToken

Hi @subdesign
Sorry for the late reply. Is this still required, or can it be closed?
Thanks!

This can be closed, minutes to seconds was a breaking change in Laravel anyway. 6.x is the LTS, not 5.x.


Issue when requesting id token with openid scope using the access token received from SAML bearer grant

Describe the issue:
When trying to request an id token with openid scope using the access token received from SAML bearer grant the process halts in midway. But this works in the previous WSO2 Identity Server version (5.11.0)
How to reproduce:

add a country and email for the admin account in the IS
Deploy the travelocity.com webapp (https://is.docs.wso2.com/en/latest/learn/deploying-the-sample-app/#deploying-the-travelocity-webapp)
Use the following Callback URL when configuring OAuth: [https://curl-app/callback]
Add emailaddress as "Requested Claim" and "Mandatory Claim". Also add country as Requested Claim. (Claim Configuration > Define Custom Claim Dialect, in the service provider of travelocity.com)
Put tick mark to both "Use tenant domain in local subject identifier" and "Use user store domain in local subject identifier" (Local & Outbound Authentication Configuration, in the service provider of travelocity.com)
Run travelocity webapp
Acess travelocity.com site using tomcat8
Click Click here to login with SAML from Identity Server (Post binding or Redirect Binding).
Enter the username and password and click SIGN IN.
Click Request OAuth2 Access Token to receive the access token.
Use that access token and,
curl -v -X POST -H "Authorization: Bearer 7ee57bc28a3336ccb7818b499941e4e4" -H "Content-Type: application/x-www-form-urlencoded;charset=UTF-8" -k -d "response_type=code&client_id=<CLIENT_ID>&redirect_uri=<REDIRECT_URI>&scope=openid"  https://localhost:9443/oauth2/authorize
Copy the URL in the location tag,

Paste that link on a browser and go to the link

Expected behavior:
After that it should show a single tick box, but in the IS 6.0.0m1 version it prompts the user to enter the email address again which was already filled.

After filling that field it prompts an error screen

Environment information (Please complete the following information; remove  any unnecessary fields) :

IS 6.0.0
Mac
DB2 11.5
JDBC
Firefox 91.0
Oracle JDK 11

More details
https://is.docs.wso2.com/en/latest/learn/oauth-request-path-authentication/#using-the-authorization-header

The same error comes up when trying to Single Sign-On with SAML to an external Identity Provider and use SAML bearer grant for access delegation.
How to Reporduce

Setup another IS server according the details given in the below article
https://medium.com/identity-beyond-borders/configuring-saml-federated-identity-provider-initiated-logout-in-wso2- identity-server-f1bc7612b270

Change the Authentication type to Federated Authentication and select the set (in the above step) identity provider.

Try out the steps in the main text

Update
When trying to reproduce the above issue, met with another issue where the  user id with username@<TENANT_DOMAIN> cannot be found. This error caused by this improvement.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Missing import and attribute in .NET generated code

When generating CRDs code for .NET the generated code has no import for the correct KubernetesResource base class, as well as using the CrdsResourceType attribute, which is nowhere to be found.
Steps to reproduce

run ./crd2pulumi -d cert-manager.crds.yaml
open the Pulumi.Crds.csproj project
the project has errors in all the generated CDR code files

Expected: the generated project compiles
Actual: the generated project doesn't compile
Example:
using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Threading.Tasks;
using Pulumi.Serialization;

namespace Pulumi.Crds.Certmanager.V1
{
    /// <summary>
    /// A Certificate resource should be created to ensure an up to date and signed x509 certificate is stored in the Kubernetes Secret resource named in `spec.secretName`.
    ///  The stored certificate will be renewed before it expires (as configured by `spec.renewBefore`).
    /// </summary>
    [CrdsResourceType("kubernetes:cert-manager.io/v1:Certificate")]
    public partial class Certificate : KubernetesResource
    {

In this file, the KubernetesResource is not resolved in any using namespace. Adding this:
using Pulumi.crds;

solves the issue, but it must be done in all the files.
Also, the CrdsResourceType attribute is not resolved, and I cannot find it anywhere.

Same issue here, the code generated with the latest release in both linux and windows is missing the correct imports, CrdsResourceType and the Utilities class, even after importing the generated namespace, is conflicting with the namespace Pulumi.Utilities.

Possibly related to https://github.com/pulumi/crd2pulumi/issues/48?

Possibly related to #48?

the code generated with the latest release in both linux and windows is missing the correct imports

@nwrox Was this working previously for you and started not working with the latest release?

First time using the tool. I'm trying to convert the traefik crds (https://github.com/traefik/traefik/tree/master/docs/content/reference/dynamic-configuration/traefik.containo.us_*.yaml) and i got the following errors:
Missing import (^1.0.5)

Namespace conflict (^1.0.5)

Stop the conflict if edited manually:

Missing reference (^1.0.6)

This last one i couldn't find a reference anywhere in pulumi's organization.

I had the same problem. I fixed it by adding the flag --dotnetName Crds to the command ./crd2pulumi -d --dotnetName Crds cert-manager.crds.yaml. This changes the namespace from Pulumi.crds to Pulumi.Crds in both KubernetesResource.cs and Utilities.cs. This fixes all namespace errors regarding KubernetesResource and the Version from the Utilities class.
The missing CrdsResourceType is because of a temporary fix here.
I added the following class after the Utilities class in the file Utilities.cs to fix the issue. The following class is a snippet from the template from the main pulumi repository which is missing from the temporary fix in this repository.
internal sealed class CrdsResourceTypeAttribute : Pulumi.ResourceTypeAttribute
{
    public CrdsResourceTypeAttribute(string type) : base(type, Utilities.Version)
    {
    }
}

Added to epic https://github.com/pulumi/home/issues/3431


Fixed interface conversion

Fixed interface conversion for string values when dealing with integer request values.
Request API Parameters which required int values did not work because of wrong interface conversions (panic was not thrown due to the "if ok" handling).
The values therefore were never added to the request payload when requested.
What was i thinking :) !?

Nevermind, i mistakenly mixed .Search and .Request, there is no need for this PR


Category action buttons not showing

🐛 Bug Report
I send a push notification to android and iOS specifying click_action but when I receive it i do not see any notification tray button.
Expected behavior
Notification shows with tray button
Reproduction steps

Set up everything as explained here: https://github.com/CrossGeeks/FirebasePushNotificationPlugin/blob/master/docs/NotificationActions.md
I use Firebase Admin to send notifications (to multiple devices, this is a MulticastMessage):

{
  "Tokens": [
    "eEK8smTvsErmvdAhHK3F9v:APA91bFDUeQMDEcBnUHhaLKaIcv4r_SwviUA9fDQcw7HuJkxAkII6OjXOySKiZrLvzbsQG5EQlz4rbRGKYVmwyZ5CD0_SuHTP8ihvudaksXDl7aHZAjJUUgmlMjE93-S9DAi7F1VdpL_"
  ],
  "Data": {
    "Title": "Check-in Reminder",
    "Message": "Tap here to respond with a check-in.",
    "ScheduledCheckIn": "97",
    "click_action": "scheduled_check_in"
  },
  "Notification": {
    "title": "Check-in Reminder",
    "body": "Tap here to respond with a check-in.",
    "image": null
  },
  "Android": {
    "collapse_key": null,
    "restricted_package_name": null,
    "data": {
      "click_action": "scheduled_check_in"
    },
    "notification": {
      "title": null,
      "body": null,
      "icon": null,
      "color": null,
      "sound": null,
      "tag": null,
      "image": null,
      "click_action": "scheduled_check_in",
      "title_loc_key": null,
      "title_loc_args": null,
      "body_loc_key": null,
      "body_loc_args": null,
      "channel_id": null
    },
    "fcm_options": null,
    "priority": null,
    "ttl": null
  },
  "Webpush": null,
  "Apns": {
    "headers": null,
    "fcm_options": null,
    "payload": {
      "aps": {
        "badge": null,
        "category": "scheduled_check_in",
        "thread-id": null,
        "alert": null,
        "sound": "default",
        "content-available": 1,
        "mutable-content": null
      }
    }
  }
}

To be sure, I am passing click_action in Data and in Android.Notification and in Android.Data....and in neither case I get the button to show up.
Configuration
Version: 3.3.10
Platform:

[x] :iphone: iOS
[x] :robot: Android
[ ] :checkered_flag: WPF
[ ] :earth_americas: UWP
[ ] :apple: MacOS
[ ] :tv: tvOS
[x] :monkey: Xamarin.Forms

Same

@stesvis have you solved this problem?

I switched to OneSignal. It seems much easier and it gets updated
regularly..
On Thu., Nov. 11, 2021, 4:06 a.m. Федор Благодырь @.***>
wrote:

@stesvis https://github.com/stesvis have you solved this problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CrossGeeks/FirebasePushNotificationPlugin/issues/395#issuecomment-966211747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOIEXBKKIA2FKH75QBPGPTULOPU3ANCNFSM5CK2POSA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Facing the same problem :(


Increase default HTTP timeout to 30s

Context
Now the default value of HTTP time out is 10s, which could cause some pontential issues.
This PR increases it to 30s.
Gradle Core Team Checklist

[x] Verify test coverage and CI build status

@blindpirate What exactly was the driver for changing this? Did we get reports that the HTTP calls time out too fast?

@bmuschko After this change, I observed many read time out on our CI, which didn't appear before. So I think it's necessary to increase it. For example, this happened just now: https://builds.gradle.org/viewLog.html?buildId=8899700&tab=buildResultsDiv&buildTypeId=Gradle_Check_Stage_QuickFeedbackLinuxOnly_Trigger

is there going to be a 4.3.1 release with this? i know you can "fix" this by setting the timeout in gradle.properties, but it is rather surprising when your builds start failing.

@jmcampanini Yes, we'll make the change for 4.3.1 as well. Please see https://github.com/gradle/gradle/issues/3370 for more information.


Enhancement: Custom Endpoint Permissions

What features would you like to see added?
Allow usage of endpoints depending on User Group Claim.
Think of the following Scenario:
There are 2 endpoints in Custom section:
Endpoint A - OpenAI
Endpoint B - Google
# If you want to restrict access by groups
OPENID_REQUIRED_ROLE_TOKEN_KIND=id
OPENID_REQUIRED_ROLE_PARAMETER_PATH="roles"
OPENID_REQUIRED_ROLE="Your Group Name" <--- Should be List, comma separated

In order to route via teams, additional configuration params are required:
permissionsRole <- Should match the name of the group in AD\Entra
Example:
SecurityGroup - Team-A
permissionsRole: "${OPENAI_GROUP_CLAIM_NAME}"
The Config.yaml would look like:
    endpoints:
      custom:
      - name: "ChatGPT"
        apiKey: "${LITELLM_OPENAI_API_KEY}"
        baseURL: "http://litellm.default:4000"
        models:
          default: ["gpt-4-turbo"]
          fetch: true
        titleConvo: true
        titleModel: "gpt-4-turbo"
        summarize: false
        summaryModel: "gpt-4-turbo"
        forcePrompt: false
        modelDisplayLabel: "ChatGPT"
        permissionsRole: "${OPENAI_GROUP_CLAIM_NAME}" <-- New parameter
      - name: "Google"
        apiKey: "${LITELLM_GOOGLE_API_KEY}"
        baseURL: "http://litellm.default:4000"
        models:
          default: ["gemini"]
          fetch: true
        titleConvo: true
        titleModel: "Gemini"
        summarize: false
        summaryModel: "Gemini"
        forcePrompt: false
        modelDisplayLabel: "Gemini"
        permissionsRole: "${GOOGLE_GROUP_CLAIM_NAME}"

In UI, when Person Z from Team-A logs in with SSO with GroupClaim - team-a
The JSON from Azure Entra would contain:
{
  ...
  "_claim_names": {
   "groups": "team-a"
    },
    {
  "_claim_sources": {
    "src1": {
        "endpoint":"[Url to get this user's group membership from]"
        }
       }
     }
  ...
}

The user is then allowed to access the UI.
User clicks on "ChatGPT" Icon in the UI to start a chat with this endpoint.
Endpoint compares groupClaim with configuration and allows usage of Endpoint.
Person Z from Team-A tries to click on Google Endpoint and is thrown an error.
Assuming this works, we can then parse groups: team-a
to the proxy, LiteLLM in this case by adding this to the endpoint's configuration in the yaml:
...
        headers:
          team_id: "${OPENAI_GROUP_CLAIM_NAME}"
          Content-Type: "application/json"
...

On LiteLLM side, its possible to configure a team based routing and associate it with this group so it would work.
More details
None
Which components are impacted by your request?
Endpoints
Pictures
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

There will be role based access controls but not quite like this


[CI] Testdata catalogs are invalid

What happened?
On a connected cluster:
$ oc get pod -A -l app=packageserver
NAMESPACE                              NAME                             READY   STATUS    RESTARTS   AGE
openshift-operator-lifecycle-manager   packageserver-76c948d469-68gmw   1/1     Running   0          28m

$ oc apply -f- << EOF
apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: oc-mirror-dev
  namespace: openshift-marketplace
spec:
  displayName: oc-mirror Test Catalog
  image: quay.io/redhatgov/oc-mirror-dev:test-catalog-latest
  publisher: RH4G
  sourceType: grpc
EOF
catalogsource.operators.coreos.com/oc-mirror-dev created

$ oc get pod -A -l app=packageserver
NAMESPACE                              NAME                             READY   STATUS    RESTARTS   AGE
openshift-operator-lifecycle-manager   packageserver-76c948d469-68gmw   1/1     Running   0          29m

$ oc delete pod -l app=packageserver -n openshift-operator-lifecycle-manager
pod "packageserver-76c948d469-68gmw" deleted

$ oc get pod -A -l app=packageserver
NAMESPACE                              NAME                             READY   STATUS             RESTARTS      AGE
openshift-operator-lifecycle-manager   packageserver-76c948d469-q8pj4   0/1     CrashLoopBackOff   5 (15s ago)   3m29s

$ oc logs -n openshift-operator-lifecycle-manager -l app=packageserver
	/build/vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/apis/operators/packagemanifest.go:126 +0x19f
github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/apis/operators.CreateCSVDescription(0xc00176e000, 0xc000f82000, 0x1b5, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/build/vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/apis/operators/packagemanifest.go:38 +0x1e6
github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/provider.newPackageManifest(0x246e2c0, 0xc00208b440, 0xc002f5e8c0, 0xc001f11e00, 0xc000bde860, 0x0, 0x0, 0xc001f11e00)
	/build/vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/provider/registry.go:506 +0xd14
github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/provider.(*RegistryProvider).refreshCache.func1(0xc001315090, 0xc000bde860, 0x246e2c0, 0xc00208b440, 0xc00150e4c0, 0xc002f5e8c0, 0xc000440ee0, 0xc001315088, 0xc0007e8450)
	/build/vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/provider/registry.go:309 +0x2e5
created by github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/provider.(*RegistryProvider).refreshCache
	/build/vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/provider/registry.go:301 +0x57e

What you expected to happen?
I expected the packageserver to be able to parse the catalog and provide a list of PackageManifests for listing in OperatorHub.
How to reproduce it (as minimally and precisely as possible)?
With a connected OpenShift or CRC cluster:
$ oc apply -f- << EOF
apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: oc-mirror-dev
  namespace: openshift-marketplace
spec:
  displayName: oc-mirror Test Catalog
  image: quay.io/redhatgov/oc-mirror-dev:test-catalog-latest
  publisher: RH4G
  sourceType: grpc
EOF

Anything else we need to know?
It appears to be relatedImages that's causing the crash:
https://github.com/operator-framework/operator-lifecycle-manager/blob/aa20d1cea93e3e0a82aab1e586c28f935ffdd297/pkg/package-server/apis/operators/packagemanifest.go#L38
The relatedImages from the CSVs appear to be here:
https://github.com/openshift/oc-mirror/blob/de53a7e4fe7683b37836cafb5d31a9cb24f09574/test/operator/testdata/bundles/bar-bundle-v0.1.0/manifests/bar.csv.yaml#L16
And those appear to be getting manipulated here:
https://github.com/openshift/oc-mirror/blob/de53a7e4fe7683b37836cafb5d31a9cb24f09574/test/operator/setup-testdata.sh#L43
Except that I believe the result is, for example quay.io/redhatgov/oc-mirror-dev/bar-operator/bar:v0.1.0 when it should be quay.io/redhatgov/oc-mirror-dev:bar-v0.1.0

WIP here


[Pattern - Filtering]: Icon usage for overflow menu

Detailed description
In the filtering pattern (https://www.carbondesignsystem.com/patterns/filtering), the icon settings--adjust is used across all screenshots that show an overflow menu. Is this intentional or should we use the filter icon for implementation?
Additional information

@janhassel Yes, this should be showing the filter icon and not the settings adjust icon. We need to update that. 👍🏻

@laurenmrice Thanks for the clarification! 👍


fix: multiple server-tracing headers aren't handled

When multiple server-tracing headers are present, handle all of them. Previously only the first instance would be handled.

Thank you @jtmalinowski!

@jtmalinowski Please do a similar PR against the 1.7.x branch as well.


Rename or move the feedback link in the sidebar

The Feedback link in the sidebar should either be reframed (since it's feedback for the site and not feedback for the APIs) or should be moved to a less prominent placement, such as in the footer.

addressed by the redesign.


propsForDots added to ChartConfig interface

propsForDots was missing at index.d.ts. So  propsForDots added to ChartConfig interface

Good stuff! Why did I not merge this sooner. This is now available in v5.2.0

Thanks for the project. 👍


issue between fluxed redstone & reborncore

there seems to be an issue between those two mods, lemme show you the report
http://paste.ubuntu.com/14629485/
mods versions are the newest from jenkins

I just pushed a new version of fluxed redstone that works with the new reborn core.
Reborn core rendering was rewitten, so just grab the latest version of Fluxed Redstone


assign ignores some arguments

This ignores the last argument for some reason:
_.assign({}, {a:1}, {b:2}); // expected: {a:1, b:2} (where the input b:2 object is modified)
// => { a: 1 }

However this works:
_.assign({a:1}, {b:2}, {}); // => {a:1, b:2} as expected
// => { b: 2, a: 1 }

I suppose that either I misunderstand something seriously or that this is a bug. Thank you!

Hi @jakubholynet! As mentioned here variadic methods don't fare well with this style which is why _.assign is capped to two params. You can always leverage composition of _.reduce + _.assign to get what you want.


fix: exit out of application if authentication fails

as authentication is passed in via env vars the only way to access
updated creds is to restart the app.
fixes #3

ping @ocadotechnology/osp-cfc-cloud-platform


Breakpoint supported should live on SessionData in the breakpoint

As @dgozman points out
When breakpoint is supported by one session, and not supported by another, we render it differently depending on focused session. Also, rendering in the editor and in the breakpoints list sometimes disagrees (unsupported vs verified). I think that if we move notion of supported to the breakpoint model (similar to verified), this will be automatically fixed.

@dgozman please try it out and let me know if it behaves good for you now.
I basically implemented what you suggested 0 that the is supported data also lives on the breakpoint which makes a lot of sense imho.


How to serialize an Object using Avro Serializer where it is registered in the Schema Registry?

Hi @Marc19, for moment Avro SerDes which interact with Schema Registry is not available.

Hi @LGouellec, thanks man. Looking forward to it!

You have a workaround :

Sample stream application with avro + registry [here](https://github.com/LGouellec/kafka-streams-dotnet/tree/master/samples/sample-stream-registry]. Please read my ReadMe
Sample producer to mocking data here

Do not hesitate, if you have any questions
++

I think I don't have access for the sample stream repo.

Retry, I made mistake in my comment

Thank you, I really appreciate your effort!
I'm not sure but I think my current problem is, that my object is auto registered in the schema registry when it is first produced in a Kafka topic. So, I would prefer not to define the schema manually like you did in the Person object.
So is there something I can do to achieve this?

With both modifications, it should be OK for your use case :)

https://github.com/LGouellec/kafka-streams-dotnet/blob/a6f22cb047c04225ad2a771fa2c623031e0d6ee1/samples/sample-stream-registry/PersonSerDes.cs#L22
https://github.com/LGouellec/kafka-streams-dotnet/blob/a6f22cb047c04225ad2a771fa2c623031e0d6ee1/test/Producer-Avro/Program.cs#L30

Streamiz packages was released in 1.0.0 version.
A new nuget packages with name : Streamiz.Kafka.Net.SchemaRegistry.SerDes.Avro was release too. It contains avro serdes which interact with Schema Registry.
Don't hesitate to test !!
So I close this issue 😃


Missing a couple redefinitions (math section, paragraph)

From Bruno:

The math section and paragraph signs are missing from the Unicode redefinitions in unicode-math's unicode-math-table.tex. Instead, the definitions from fontmath.ltx are used assigning them to "78 and "7B, respectively, hence yielding "x" and "{".
I spent quite some time trying to use \UnicodeMathSymbol as in unicode-math-table.tex to add the missing definitions, then switching to all the possible variants of the solutions suggested at
http://tex.stackexchange.com/questions/161871/how-to-change-the-mathematical-symbol-class-of-a-unicode-math-symbol
https://tug.org/pipermail/xetex/2009-June/013464.html
with no luck. I have the impression unicode-math-table.tex is a database read once and for all while processing \setmathfont, and that later additions using \UnicodeMathSymbol are simply not possible. (Indeed, editing unicode-math-table.tex to add the missing definitions works, but this is not a solution I was willing to consider.)
So after reading one more time the unicode-math doc, I tried out of desperation
\DeclareMathSymbol{\mathsection}{\mathord}{symbols}{"00A7}
\DeclareMathSymbol{\mathparagraph}{\mathord}{symbols}{"00B6}
and this did work! It feels a bit odd to specify a math alphabet (symbols) in the redefinition, as I thought unicode-math made this notion obsolete, but I imagine this is the way Unicode is made to fit within LaTeX's math design.

#371 talks additionally lists missing \surd as well.


edit channel/room added

Description
Please provide a short summary explaining what this PR is about.
I changed former PR(edit-room)due to a lot of merge conflict and added un related lot of files
Fixes # (57)
How to test?
npm run  dev
Please provide a short summary how your changes can be tested?
Checklist

[ x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x ] I have made corresponding changes to the documentation
[ x] This PR is ready to be merged and not breaking any other functionality

You have some errors that you need to fix


Prevent Error in console

Current behaviour:
If a person opened the motions/amendments and then logs out. then there is an error in the console TypeError: Cannot read properties of undefined (reading 'amendment_ids') and it is possible that the login page is spinning indefinitely
Reproduction:

Login as a person who can see the dashboard
open any motion-detail view
log out
log in with the same account
there is either a spinning login button or an error in the console

Wanted behaviour:
The Error and the long (indefinitely) spinning time should be prevented

The error does not seem to be related to the login issue

This seems to be related to the operator not getting ready. There were already issues regarding this kind of issue (e.g. #1609, #1390).
After fixing that we might also want to add an integration test for this.

This seems to be a race condition within autoupdate-stream.ts.
On logout the client sends the following messages to the shared worker:

Individual subscription closes
Endpoint update
Auth change

It seems that subscriptions do not get correctly closed if the set endpoint or auth change message (not exactly sure which one, maybe both) get sent before the close message was sent.

I cannot replicate this anymore.

I updated the Issue description

Problem is solved.


databricks-cli: 0.229.0 -> 0.234.0

upstream update https://github.com/databricks/cli/releases/tag/v0.234.0
Test TestConsistentDatabricksSdkVersion was added to ignored as it relies on internal subpackage which building is also skipped
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Maintainers ping
cc @kfollesdal
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 356926 run on x86_64-linux 1

1 package built:

databricks-cli

I realized that I should have added the comment about the test into the package declaration. @kfollesdal, should I fix it?

I realized that I should have added the comment about the test into the package declaration. @kfollesdal, should I fix it?

Think it is ok as it is now. The disabled TestConsistentDatabricksSdkVersion need network and you have added it under # Need network, so think that is enough.


Quality of Image

Is there a way to change the quality of the image dynamically.

Please look at the compressImage function


scale grid() based on current transform.

Not very useful to say grid(50) and when scale(0.5) is active and have it draw lines every 50 pixels instead of every 25.

Also see #71


bug (app): removed repeat line for testlogs

Previously the test log was repeated 1000 times, now it is not.

bors merge


Add Instruction.assign_parameter to delegate correct binding to instructions themselves

Summary
Fixes #7486 and fixes #6674.
Details and comments
WIP as the PR misses reno and test.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0008%) to 83.118%

Totals

Change from base Build<PHONE_NUMBER>:
0.0008%

Covered Lines:
51947

Relevant Lines:
62498

💛  - Coveralls

As I commented in the referenced issue you can see this has been seen by end users. Maybe this fix should be backported too.

I think a more robust solution is to have Instruction define a new method assign_parameters which can take a dictionary {old_param: param}, and delegate the modifications to those classes.

Yes, I agree that's the more sustainable solution. I'll give that a shot 🙂

Could you run some benchmarks on applications which make heavy use of parameterised circuits and controlled instructions?  There might be some suitable in the metapackage's benchmark suite already, which you can run with asv dev.
It'd be good to know exactly what sort of performance hit we're dealing with (if at all) before reviewing everything.

Just wanted to explicitly add to this that I see this as compatible with other changes to parameter handling, but maybe not totally needed. I believe that with run-time parameters in CircuitInstruction (i.e. within QuantumCircuit.data explicitly), the initial problem this PR tried to solve (ControlleeGate) will automatically be fixed, but there will still be the possibility for custom Instruction subclasses to contain ParameterExpression values in their "state" fields.  The new method in this PR would still be needed/useful to support that use-case.

Closing for now as stalled.


res_generic_po device extraction changed from R devices to X devices

In commit 13a8c5d2b10f1ec959d24bb1c9b580f0abbebe91 the res_generic_po device extraction was changed from R devices to X devices. I think this change enables the extraction of l and w parameters which may have been previously ignored.
The corresponding standard cell spice libraries and possible xschem primitive should be modified to correspond.

FYI, the L and W parameters were not previously ignored, as the "R" component in SPICE does have a variation which is a "semiconductor resistor" and takes parameters L and W instead of a resistance value.  So the only change needed to the standard cell libraries was to change "R" to "XR".  This has been done.


GraphQLTestClient doesn't handle variables correctly if files are present

If at least one file is used, the query method of the test client interprets all variables as if they were a file upload, although the query may contain other variables that are not files.
I think the cause is the implementation of BaseGraphQLTestClient._build_multipart_file_map in strawberry.test.client which behaves as if each variable is a file.

Oh I will have a look at this!


Adding catalog breadcrumbs

Hey, I just made a Pull Request!
Adding breadcrumbs to the catalog component entity header for consistency with the similar feature present on the tech docs entity page. Clicking on the breadcrumb will take you back to the catalog (as does the techdocs breadcrumb with the techdocs catalog).
Included a new breadcrumbTitleOverride to the Header component to prevent the favourites button appearing alongside the breadcrumbs.

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

thanks for taking a look! I think I agree with you regarding displaying the page title that you're on in the breadcrumb. I only included it as that's exactly what's shown on for the techdocs components?

You're right, the route you're taken to when clicking on the bredcumb link in this case shouldn't just take you back to the catalog but perhaps the catalog filtered for whatever kind you've selected in the dropdown (APIS, Components, Domains, Groups etc)


Server 2003 Timeout

Works on my Windows 10 target but not my server 2003 target.
[*] Verbose mode: On
[v] handler::handle() - Incoming HTTP from ('x.x.x.x', 1155)
[v] handler::handle_new_session()
[+] Zombie 1: Staging new connection (x.x.x.x)
[v] handler::reply() - sending status 200 with 12373 bytes to ('x.x.x.x', 1155)
[v] handler::handle() - Incoming HTTP from ('x.x.x.x', 1156)
[v] handler::find_session() - found session.key = 499ea8fb505d41c1b1c4489d4296f7c3
[v] session::parse_user_info() - 'split(...).1' is null or not an object
[v] handler::reply() - sending status 200 with 0 bytes to ('x.x.x.x', 1156)
[!] Zombie 1: Timed out.

I kept searching for a python error, but since this is a verbose statement that prints 'data', that's a javascript error. Luckily there's only 1 split during Koadic.user.info() and it's here: https://github.com/zerosum0x0/koadic/blob/master/data/stager/js/stdlib.js#L262
Does ipconfig on that 2003 not have IPv4 in there? I'm adding error handling and a fallback, but that would be interesting to know.

Oh OK I just realized that the string for 2003 is just 'IP Address'. All add some shtuff in there and have push it out in a few.

 It should be correct and in the case of any errors, it will set the IP to the IP of the request. If we can't get to a super reliable method of getting the correct IP each time, I might add the ability to manually edit a Zombie's IP.

Seems to be working now. Thanks!


Should SpanContext use Java toTraceId/toSpanId signature?

(Conversation forked from https://github.com/opentracing/specification/issues/123#issuecomment-429925629)
The recently-merged Trace Identifier RFC to the Java library chose to implement Trace Identifiers differently (see https://github.com/opentracing/opentracing-java/pull/280 for more) - essentially, rather than as a property on their span context, they add a toTraceId and toSpanId method. The rationale for this is to indicate that this action will perhaps cause memory allocations as Tracers would need to convert from their current in-memory representation to a string.
Should the C# library change as well?

I have mixed feelings about this. It's important to stick to the spec but it's also important to not break stuff for "trivial" reasons - especially on the instrumentation/app side.
While the "to"-prefix in Java definitely indicates the potential allocations, it was also chosen (AFAIK) because existing tracers already used the initially proposed "traceId" name. We do not have this problem in C#.
So I'm undecided and looking forward to other opinions!

My immediate thought is that we could easily extend the XML doc to indicate that calling TraceId/SpanId could trigger a conversion from whatever-to-string and may have performance impacts; We could also just note it in the README somewhere. Given that we're in technical compliance with the RFC as its written today, I'm generally against changing the interface but in favor of clarifying XML doc/general documentation comments.


Track symbol has a very long line (leader for course)

The track symbol's course line becomes very long when zooming in (Leaflet zoom level 2).

When I zoomed out (Leaflet zoom level 10), it became normal again.

No idea how to make it shorter while zooming in or have a consistent length.

The leader line shows how far the vessel would travel in the amount of time specified by leader time. It shows the relative speed of a vessel.
The leader line is affected by:

https://org-arl.github.io/leaflet-tracksymbol2/typedoc/interfaces/PositionReport.html#sog
https://org-arl.github.io/leaflet-tracksymbol2/typedoc/classes/TrackSymbol.html#setSpeed
https://org-arl.github.io/leaflet-tracksymbol2/typedoc/interfaces/ShapeOptions.html#leaderTime
https://org-arl.github.io/leaflet-tracksymbol2/typedoc/interfaces/AISTrackSymbolOptions.html#leaderTime

If you wish to shorten the leader line when zooming in, you can reduce leaderTime (defaults to DEFAULT_LEADER_TIME = 60s).


Added MongoDB support

This is in regards to #4
Things to note

Must have MongoDB installed and running
must have a database with two different collections

One for wins and one for fails

All config values are environment variables. Which I updated in the DockerFile (Must use your own proper configs).
You can have a .env file that will be loaded on start so you don't have to set your environment before run locally.
Please critique it. This was the solution I came up with.

Wow ! Ty for your time @dixonwille , I'll try to take time along the week to hands on this. I'll have to update the current infrastructure tu provide mongo inside the container.
Keep the contributions ! ;)

Mongo in Docker is not persistant...
http://stackoverflow.com/questions/34753792/howto-persist-mongodb-data-of-a-running-docker-container-in-a-new-image
I would suggest running a separate instance outside of docker and point to it. If you are using AWS I would use AWS EBS

Thanks for the suggestion dixon and also for the info on not persistance, as it really makes sense.
I guess the idea of writing mongodb data into a volume of the current host and being able to run a new container with the previous volume path is what best fits in my mind.
I'll try to make my way through this approach as AWS is not an option right now :) Really want to make the service as portable as posible to anybody who wants to contribute.

@MarcosSegovia sounds good. I was in the rut and could not figure out why my DB was not persisting and didn't want others to fall into that route.

I'm merging into a feature branch since I get the docker working properly. Ty @dixonwille

Hi @dixonwille I've fully merged your proposal after dockerizing the process and getting my hands dirty with the code.
Still things to get done:

Normalize the Entry in the API as it would be our Primary Entity of the Domain, and has to be completely agnostic of the persistence system.
Even though could run in separate containers and link application container with database container, still did not find a way to get the data persisted into a new container. When stop and resume data is still available. But I guess has to do with the inmutability. Anyway I'll find a way.

If you are interested in the code changes, let me know, we can discuss about it 👍

Saw the changes and makes since. I don't like messing with too many files in other people's repository. So I just like to get it working. Glad to see you pulled it apart as I try and do that with my projects as well. As for persisting you tried storing the db files to a volume through docker? use that same volume everytime you connect and you get persistence. The issue is when you go for a distributed system (AWS, Digital Ocean, Heroku for testing etc.). Then you would probably just want to stand up a DB outside of Docker in that case.


[Backport r0.9] Added the DepreciationWarning for the custom op version of activations functions

Backport 0d528c18e639432f2686a8bd4d125d2cc77a557e from #1791

We need to backport the fix for macos in github actions

Let me update this pull request

Let's not merge that. The ci is broken in the 0.9 branch.


fix: library crashes when localStorage is not callable

Currently, we're checking for localStorage's presence but not its
actual usability. In some scenarios, browsers can disallow
localStorage to be called upon and in such cases, the library will hard
crash.
In this change, I added a catch statement to intercept these errors and
return an empty string when localStorage cannot be called upon.

[X] Bug fix (non-breaking change which fixes an issue)

[ ] New feature (non-breaking change which adds functionality)

[ ] Breaking change (fix or feature that would cause existing functionality to change)

[X] I have used ESLint & Prettier to follow the code style of this project.

[X] I have updated the documentation accordingly.

[X] I have added tests to cover my changes.

[X] All new and existing tests passed.

Hi @YuLeven ! Just following up on this, let me know your thoughts!

:tada: This PR is included in version 8.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Initial dark mode prep

Summary of the changes
This is an initial PR to help us get going on dark mode (and actually will enable theming too)
This has been implemented in such a way that there is a hierarchy of settings
If someone is not using the ic-theme component, then the os\device settings for dark\light mode will be used
If using ic-theme, then there is “theme” prop, which can be set to
“system”, to honour device settings
“dark”, to always use our dark mode
“light” to always use our light mode
Ultimately, it will also be possible to override an individual instance of a component too (using the a prop, but that’s not really shown here (slight caveat to that below using a different mechanism)
There has been some change s to the structure of our css tokens. They are now split out into files such as “borders.css”, “fonts.css”, “colors.css” rather than a single file. There are also separate files for light & dark mode, so the tokens can be specified there. At the moment, the tokens are set to use the light values, even in dark mode, but you can pull the code down locally & uncomment the dark tokens to see them in action. Obviously more tokens will be added as we go forwards
One nice side effect of the ic-theme work is that you can actually use it as a mechanism to wrap some components in a different mode\theme.
For example, you could set a light mode to wrap your whole app, but then maybe have a single card that is wrapped in a ic-theme with theme=dark set
<ic-theme theme=”light”>
   …..loads of light comps
   <ic-theme theme=”dark”>
     <ic-card>
        Dark mode card stuff
     </ic-card>
    </ic-theme>
 …. More light mode stuff
</ic-theme>

I’m not proposing this as a solution/alternative to having an “appearance” prop on all the components, but it’s a little extra bonus
You may notice that currently very little changes depending on the mode prop. This is because the ic-typography component needs to be modified to honour a text colour. However, doing so is a huge breaking change (all the visual tests will break). So for the time being, if you want to see this in action, please uncomment the code in the ic-typography.css file and also enable the dark mode variables in global/color-mode.css

Looks good, my only comment is one we already discussed. Less about this PR, but more about one of your next maybe. I want to make sure that customers apps will not be broken from them adopting v3, where they haven't or have no plans to support dark mode, if someone comes with dark mode enabled and no theme, it simply defaults to dark.
I couldn't see any code in here I could reference, but my ideas to achieve that, in order of preference:

Where either the ic-light or ic-dark css class is applied when set to "inherit" at a component level, it either inherits what is set at a theme level, or if no theme, it defaults to light, to match how it works currently. Surely there's some logic we can put in place to just default to light, if there is no theme?
We simply force people to adopt ic-theme in our getting started, and say without it, system settings will break apps. Currently it is optional, so we'd change it to not be.
There is an option of adding some css manually as you've mentioned, but I feel at that point, just tell them to use theme as that's what it does.

My top preference being option 1.


BUG: need better wording for councils that offer unlimited number of permits

See evidence from user research

Solution: remove "up to" when unlimited number.

Fixed with localisation for Cambridgeshire


gnutls_handshake() failed while accessing apt.dockerproject.org

Since today, https mirror is failing on every node with:
Err https://apt.dockerproject.org ubuntu-trusty/main amd64 Packages
gnutls_handshake() failed: Handshake failed

Workaround is to switch to http mirror in sources.list
Found on twitter someone else writing about this: https://twitter.com/schulzbo/status/798791665464901632

Thanks for reporting @gionn, we are aware of this, and are still investigating. There looks to be an issue with our CDN (Cloudfront), and some mirrors are having this issue. Also see the discussion here; https://github.com/docker/docker/issues/16941#issuecomment-260877805
This IP address is known to work, so as a temporary measure you can add this to your /etc/hosts;
<IP_ADDRESS> apt.dockerproject.org

Thanks @thaJeztah your workaround is working nicely for me.

A quick status update; the infra team is now working on this issue as well, and is currently in contact with AWS. So far it looks like the issue is not on our side, but I'll post more information when it becomes available

What about updating Travis-CI status in the meantime so people are aware of this?

@The-Compiler I think you're on the wrong repository (it's docker here, we don't have anything to do with travis :angel:)

@thaJeztah looks like from travis-ci if I force the DNS resolution to IP <IP_ADDRESS> it's not working, I have this message:
 Failed to connect to apt.dockerproject.org port 443: Connection refused

Can I spefify instead the IP <IP_ADDRESS>?

Status update: the team is still working together with AWS locating the problem.

Just got informed that AWS identified a possible cause and is rolling out updates. It may take some time for those to be available everywhere. Hopefully the issue will be resolved by that
For those that used my workaround; don't forget to remove the entry from your /etc/hosts :smile:

@thaJeztah FYI, we are still seeing the issue from a GCE instance:
$ cat /etc/apt/sources.list.d/docker.list
deb https://apt.dockerproject.org/repo ubuntu-trusty main

$ sudo apt-get update | tail
W: Failed to fetch https://apt.dockerproject.org/repo/dists/ubuntu-trusty/main/binary-amd64/Packages  Failed to connect to apt.dockerproject.org port 443: Connection refused

E: Some index files failed to download. They have been ignored, or old ones used instead.
Hit http://ppa.launchpad.net trusty/main Translation-en
Hit http://ppa.launchpad.net trusty Release
Hit http://ppa.launchpad.net trusty Release
Hit http://ppa.launchpad.net trusty/main amd64 Packages
Hit http://ppa.launchpad.net trusty/main amd64 Packages
Ign http://ppa.launchpad.net trusty/main Translation-en_US
Ign http://ppa.launchpad.net trusty/main Translation-en
Ign http://ppa.launchpad.net trusty/main Translation-en_US
Ign http://ppa.launchpad.net trusty/main Translation-en
Fetched 1,167 kB in 5s (220 kB/s)

@BanzaiMan I don't know how long the rollout of that update will take, but will post updates if I get more information. If may just take time 😢

@thaJeztah Thanks. I will be patient. :-)

about 30 minutes ago AWS support answered to my request:

We're investigating reports of intermittent TLS connection timeouts to CloudFront endpoints from certain Linux command-line tools that use the GnuTLS library. We are in the process of re-routing affected requests to minimize impact.

Currently the issue seems to be resolved for us.

This is now working for me.


no-shadow broken in nightly 2.0.0-rc.3-201612021933

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request
Current behavior:
The no-shadow attribute no longer works in RC3 nightly (2.0.0-rc.3-201612021933)
<ion-header no-shadow>
  <ion-navbar>
    <ion-buttons end *ngIf="showSkip">
      <button ion-button (click)="startApp()">Skip</button>
    </ion-buttons>
  </ion-navbar>
</ion-header>

Ionic info:
Your system information:

Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.3-201612021933
Ionic CLI Version: 2.1.13
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 0.0.46
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.7.0
Xcode version: Not installed

Please, can you describe the issue better?
What do you expect? and what is actually happening? also, or screenshot or something
Thanks

Here are 2 screenshots both using the same markup. Please notice the line below "Skip" on the right
<ion-header no-shadow>
  <ion-navbar>
    <ion-buttons end *ngIf="showSkip">
      <button ion-button (click)="startApp()" color="primary">Skip</button>
    </ion-buttons>
  </ion-navbar>
</ion-header>

The image on the left is using = "ionic-angular": "2.0.0-rc.3-201611211919",
the right one is using = "ionic-angular": "2.0.0-rc.3-201612021933",

Hey there, no-shadow has only ever affected md mode. The ios header has never had a box-shadow. The border was moved from the toolbar to the header, so adding no-border for ios would remove it. I'm wondering if there is an attribute we should use that targets both of them.

Hi @brandyscarney, that is very strange because both screenshots from above were taken on a Chrome browser in iOS mode. But thanks for the no-border tip. I'll use that!

@brandyscarney I am recopening this issue since none of those options work in iOS mode when using  Chrome or device
<ion-header no-shadow>
  <ion-navbar>
    <ion-buttons end *ngIf="showSkip">
      <button ion-button (click)="startApp()" color="primary">Skip</button>
    </ion-buttons>
  </ion-navbar>
</ion-header>

<ion-header no-border>
  <ion-navbar>
    <ion-buttons end *ngIf="showSkip">
      <button ion-button (click)="startApp()" color="primary">Skip</button>
    </ion-buttons>
  </ion-navbar>
</ion-header>

Thanks @gigocabrera! This will be fixed in the rc.4 release, and I've also released a nightly if you want to use it sooner:
npm install --save ionic-angular@nightly

Just so you know - I renamed the no-shadow attribute to no-border since it seems confusing to have 2 different attributes that visually do the same thing. Let me know if you find any issues. :)


Failed to connect to the remote extension host server (Error: WebSocket close with status code 1006)

When I open a workspace using VSCode extension, I get Failed to connect to the remote extension host server (Error: WebSocket close with status code 1006.
Looking at the logs, it tries to connect 8 times, each time it says Resolved "ssh-remote+coder-vscode--redacted--redacted" to "<IP_ADDRESS>:12345", but immediately starts reconnection (after few blank log lines). Then, after around 5 seconds I see local-server-1: timeout.
The developer tools logs show lots of Websocket errors.

Deployment -

Coder server: Kubernetes
Workspace: Kubernetes

Feature status -

VSCode Extension Does not work
VSCode Server Works
SSH Works (both ssh, and coder ssh)
Browser Terminal Works

Debugging attempted -

[X] I tried the remote.ssh.localServer thing (both didn't work)
[X] Running manually the ssh command from the logs -v -T -D 12345 -o ConnectTimeout=15 coder-vscode--redacted bash. The command itself works and I can run bash commands.
[X] Increasing Remote SSH timeout to 30 seconds didn't affect anything.

Logs

[13:33:38.926] Log Level: 2
[13:33:38.935] VS Code version: 1.77.3
[13:33:38.935] Remote-SSH version<EMAIL_ADDRESS>[13:33:38.935] darwin arm64
[13:33:41.768] SSH Resolver called for "ssh-remote+coder-vscode--redacted--redacted", attempt 1
[13:33:41.769] "remote.SSH.useLocalServer": true
[13:33:41.769] "remote.SSH.path": undefined
[13:33:41.769] "remote.SSH.configFile": undefined
[13:33:41.769] "remote.SSH.useFlock": true
[13:33:41.769] "remote.SSH.lockfilesInTmp": false
[13:33:41.769] "remote.SSH.localServerDownload": auto
[13:33:41.769] "remote.SSH.remoteServerListenOnSocket": false
[13:33:41.769] "remote.SSH.showLoginTerminal": false
[13:33:41.769] "remote.SSH.defaultExtensions": []
[13:33:41.769] "remote.SSH.loglevel": 2
[13:33:41.769] "remote.SSH.enableDynamicForwarding": false
[13:33:41.769] "remote.SSH.enableRemoteCommand": false
[13:33:41.769] "remote.SSH.serverPickPortsFromRange": {}
[13:33:41.770] "remote.SSH.serverInstallPath": {}
[13:33:41.773] SSH Resolver called for host: coder-vscode--redacted--redacted
[13:33:41.773] Setting up SSH remote "coder-vscode--redacted--redacted"
[13:33:41.775] Acquiring local install lock: /var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-remote-ssh-52b8bf33-install.lock
[13:33:41.775] Looking for existing server data file at /Users/redacted/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-52b8bf33-704ed70d4fd1c6bd6342c436f1ede30d1cff4710-0.100.0/data.json
[13:33:41.775] Using commit id "704ed70d4fd1c6bd6342c436f1ede30d1cff4710" and quality "stable" for server
[13:33:41.778] Install and start server if needed
[13:33:41.779] PATH: /opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/homebrew/opt/fzf/bin
[13:33:41.780] Checking ssh with "ssh -V"
[13:33:41.783] > OpenSSH_9.0p1, LibreSSL 3.3.6
[13:33:41.784] askpass server listening on /var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-df1468e0e3620bf02dd94704bad33fb94479244b.sock
[13:33:41.785] Spawning local server with {"serverId":1,"ipcHandlePath":"/var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-087f0dc4211bdd591a0b463e3ab3f118258cc10d.sock","sshCommand":"ssh","sshArgs":["-v","-T","-D","55015","-o","ConnectTimeout=15","coder-vscode--redacted--redacted","bash"],"serverDataFolderName":".vscode-server","dataFilePath":"/Users/redacted/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-52b8bf33-704ed70d4fd1c6bd6342c436f1ede30d1cff4710-0.100.0/data.json"}
[13:33:41.785] Local server env: {"SSH_AUTH_SOCK":"/private/tmp/com.apple.launchd.ZSLaAxS9eQ/Listeners","SHELL":"/bin/zsh","DISPLAY":"1","ELECTRON_RUN_AS_NODE":"1","SSH_ASKPASS":"/Users/redacted/.vscode/extensions/ms-vscode-remote.remote-ssh-0.100.0/out/local-server/askpass.sh","VSCODE_SSH_ASKPASS_NODE":"/Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Plugin).app/Contents/MacOS/Code Helper (Plugin)","VSCODE_SSH_ASKPASS_EXTRA_ARGS":"--ms-enable-electron-run-as-node","VSCODE_SSH_ASKPASS_MAIN":"/Users/redacted/.vscode/extensions/ms-vscode-remote.remote-ssh-0.100.0/out/askpass-main.js","VSCODE_SSH_ASKPASS_HANDLE":"/var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-df1468e0e3620bf02dd94704bad33fb94479244b.sock"}
[13:33:41.785] Spawned 4012
[13:33:41.844] > local-server-1> Running ssh connection command: "-v -T -D 55015 -o ConnectTimeout=15 coder-vscode--redacted--redacted bash"
[13:33:41.845] > local-server-1> Spawned ssh, pid=4017
[13:33:41.848] stderr> OpenSSH_9.0p1, LibreSSL 3.3.6
[13:33:44.857] stderr> debug1: Server host key: ssh-rsa SHA256:REDACTED
[13:33:44.858] stderr> Warning: Permanently added 'coder-vscode--redacted--redacted' (RSA) to the list of known hosts.
[13:33:45.160] stderr> Authenticated to coder-vscode--redacted--redacted (via proxy) using "none".
[13:33:45.448] > ready: 104f63a5e5ad
[13:33:45.593] > Linux 5.4.228-131.415.amzn2.x86_64 #1 SMP Tue Dec 20 12:51:02 UTC 2022
[13:33:45.593] Platform: linux
[13:33:45.736] > /bin/bash
[13:33:45.736] Shell: bash
[13:33:45.736] Creating bash subshell inside "bash"
[13:33:45.881] > bash version:  5.0.17(1)-release
[13:33:45.930] > bash version:  5.0.17(1)-release
[13:33:45.986] > bash version:  5.0.17(1)-release
[13:33:46.039] > 104f63a5e5ad: running
[13:33:46.057] > Acquiring lock on /home/coder/.vscode-server/bin/704ed70d4fd1c6bd6342c436f1ede30d1cff4710/vscode-remote-lock.coder.704ed70d4fd1c6bd6342c436f1ede30d1cff4710
[13:33:46.059] > Found existing installation at /home/coder/.vscode-server/bin/704ed70d4fd1c6bd6342c436f1ede30d1cff4710...

Checking /home/coder/.vscode-server/.704ed70d4fd1c6bd6342c436f1ede30d1cff4710.log and /home/coder/.vscode-server/.704ed70d4fd1c6bd6342c436f1ede30d1cff4710.pid for a running server
[13:33:46.061] > Looking for server with pid: 2532
[13:33:46.066] > Running ssh connection command... /home/coder/.vscode-server/bin/704ed70d4fd1c6bd6342c436f1ede30d1cff4710/bin/code-server --start-server --host=<IP_ADDRESS> --accept-server-license-terms --enable-remote-auto-shutdown --port=0 --telemetry-level all   &> "/home/coder/.vscode-server/.704ed70d4fd1c6bd6342c436f1ede30d1cff4710.log" < /dev/null
printenv:
[13:33:46.067] >     CODER_PORT=tcp://redacted:80
KUBERNETES_SERVICE_PORT_HTTPS=443
KUBERNETES_SERVICE_PORT=443
HOSTNAME=redacted
CODER_PORT_80_TCP_PORT=80
GIT_SSH_COMMAND=/tmp/coder.zrLIOK/coder gitssh --
CODER_PORT_80_TCP_PROTO=tcp
CODER=true
CODER_DB_POSTGRESQL_PORT=tcp://redacted:5432
CODER_DB_POSTGRESQL_PORT_5432_TCP_ADDR=redacted
VSCODE_PROXY_URI=
PWD=/home/coder
CODER_DB_POSTGRESQL_SERVICE_HOST=redacted
CODER_SERVICE_PORT_HTTP=80
HOME=/home/coder
LANG=en_US.UTF-8
KUBERNETES_PORT_443_TCP=tcp://redacted:443
CODER_SERVICE_PORT=80
GIT_ASKPASS=/tmp/coder.zrLIOK/coder
VSCODE_AGENT_FOLDER=/home/coder/.vscode-server
SSH_CONNECTION=<IP_ADDRESS> 0 <IP_ADDRESS> 0
CODER_DB_POSTGRESQL_SERVICE_PORT_TCP_POSTGRESQL=5432
CODER_AGENT_AUTH=token
CODER_AGENT_TOKEN=redacted
CODER_SERVICE_HOST=redacted
CODER_AGENT_URL=https://redacted/
USER=coder
CODER_DONT_PASS=true
SHLVL=1
CODER_DB_POSTGRESQL_PORT_5432_TCP=tcp://redacted:5432
KUBERNETES_PORT_443_TCP_PROTO=tcp
KUBERNETES_PORT_443_TCP_ADDR=redacted
CODER_PORT_80_TCP_ADDR=redacted
CODER_DB_POSTGRESQL_PORT_5432_TCP_PORT=5432
SSH_CLIENT=<IP_ADDRESS> 0 0
CS_DISABLE_GETTING_STARTED_OVERRIDE=true
KUBERNETES_SERVICE_HOST=redacted
KUBERNETES_PORT=tcp://redacted:443
KUBERNETES_PORT_443_TCP_PORT=443
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/tmp/coder.zrLIOK
CODER_DB_POSTGRESQL_SERVICE_PORT=5432
CODER_DB_POSTGRESQL_PORT_5432_TCP_PROTO=tcp
CODER_PORT_80_TCP=tcp://redacted:80
OLDPWD=/
_=/usr/bin/printenv
[13:33:46.070] > Removing old logfile at /home/coder/.vscode-server/.704ed70d4fd1c6bd6342c436f1ede30d1cff4710.log
[13:33:46.071] > Spawned remote server: 284
[13:33:46.074] > Waiting for server log...
[13:33:46.107] > Waiting for server log...
[13:33:46.141] > Waiting for server log...
[13:33:46.173] > Waiting for server log...
[13:33:46.206] > Waiting for server log...
[13:33:46.239] > Waiting for server log...
[13:33:46.272] > Waiting for server log...
[13:33:46.305] > Waiting for server log...
[13:33:46.338] > Waiting for server log...
[13:33:46.372] > Waiting for server log...
[13:33:46.405] > Waiting for server log...
[13:33:46.439] >
*

Visual Studio Code Server
[13:33:46.440] > *
By using the software, you agree to
the Visual Studio Code Server License Terms (https://aka.ms/vscode-server-license) and
the Microsoft Privacy Statement (https://privacy.microsoft.com/en-US/privacystatement).

[13:33:46.447] > 104f63a5e5ad: start

DISPLAY====
webUiAccessToken====
listeningOn==45909==
osReleaseId==ubuntu==
arch==x86_64==
tmpDir==/tmp==
platform==linux==
unpackResult====
didLocalDownload==0==
downloadTime====
installTime====
extInstallTime====
serverStartTime==371==
connectionToken==redacted==
104f63a5e5ad: end
[13:33:46.448] Received install output:
DISPLAY====
webUiAccessToken====
listeningOn==45909==
osReleaseId==ubuntu==
arch==x86_64==
tmpDir==/tmp==
platform==linux==
unpackResult====
didLocalDownload==0==
downloadTime====
installTime====
extInstallTime====
serverStartTime==371==
connectionToken==redacted==

[13:33:46.448] Remote server is listening on 45909
[13:33:46.448] Parsed server configuration: {"serverConfiguration":{"remoteListeningOn":{"port":45909},"osReleaseId":"ubuntu","arch":"x86_64","webUiAccessToken":"","display":"","tmpDir":"/tmp","platform":"linux","connectionToken":"redacted"},"serverStartTime":371,"installUnpackCode":""}
[13:33:46.449] Persisting server connection details to /Users/redacted/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-52b8bf33-704ed70d4fd1c6bd6342c436f1ede30d1cff4710-0.100.0/data.json
[13:33:46.452] Starting forwarding server. localPort 55024 -> socksPort 55015 -> remotePort 45909
[13:33:46.452] Forwarding server listening on 55024
[13:33:46.452] Waiting for ssh tunnel to be ready
[13:33:46.454] Tunneled 45909 to local port 55024
[13:33:46.454] Resolved "ssh-remote+coder-vscode--redacted--redacted" to "<IP_ADDRESS>:55024"
[13:33:46.460] ------
[13:33:46.469] ------
[13:33:46.470] SSH Resolver called for "ssh-remote+coder-vscode--redacted--redacted", attempt 2, (Reconnection)
[13:33:46.471] SSH Resolver called for host: coder-vscode--redacted--redacted
[13:33:46.471] Setting up SSH remote "coder-vscode--redacted--redacted"
[13:33:46.471] Acquiring local install lock: /var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-remote-ssh-52b8bf33-install.lock
[13:33:46.472] Looking for existing server data file at /Users/redacted/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-52b8bf33-704ed70d4fd1c6bd6342c436f1ede30d1cff4710-0.100.0/data.json
[13:33:46.472] Found local server running: {"remoteListeningOn":{"port":45909},"osReleaseId":"ubuntu","arch":"x86_64","webUiAccessToken":"","display":"","tmpDir":"/tmp","platform":"linux","connectionToken":"redacted","pid":4012,"ipcHandlePath":"/var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-087f0dc4211bdd591a0b463e3ab3f118258cc10d.sock","socksPort":55015,"startupTime":1682937221785}
[13:33:46.472] Running server is stale. Ignoring
[13:33:46.472] Using commit id "704ed70d4fd1c6bd6342c436f1ede30d1cff4710" and quality "stable" for server
[13:33:46.473] Install and start server if needed
[13:33:46.475] askpass server listening on /var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-bc84d9cd8cfa3bc7989cc7344893178d6b756058.sock
[13:33:46.475] Spawning local server with {"serverId":2,"ipcHandlePath":"/var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-6ebad9e8cde873f36a0dfcaf5ecb52b60e451f23.sock","sshCommand":"ssh","sshArgs":["-v","-T","-D","55027","-o","ConnectTimeout=15","coder-vscode--redacted--redacted","bash"],"serverDataFolderName":".vscode-server","dataFilePath":"/Users/redacted/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-52b8bf33-704ed70d4fd1c6bd6342c436f1ede30d1cff4710-0.100.0/data.json"}
[13:33:46.475] Local server env: {"SSH_AUTH_SOCK":"/private/tmp/com.apple.launchd.ZSLaAxS9eQ/Listeners","SHELL":"/bin/zsh","DISPLAY":"1","ELECTRON_RUN_AS_NODE":"1","SSH_ASKPASS":"/Users/redacted/.vscode/extensions/ms-vscode-remote.remote-ssh-0.100.0/out/local-server/askpass.sh","VSCODE_SSH_ASKPASS_NODE":"/Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Plugin).app/Contents/MacOS/Code Helper (Plugin)","VSCODE_SSH_ASKPASS_EXTRA_ARGS":"--ms-enable-electron-run-as-node","VSCODE_SSH_ASKPASS_MAIN":"/Users/redacted/.vscode/extensions/ms-vscode-remote.remote-ssh-0.100.0/out/askpass-main.js","VSCODE_SSH_ASKPASS_HANDLE":"/var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-bc84d9cd8cfa3bc7989cc7344893178d6b756058.sock"}
[13:33:46.476] Spawned 4023
[13:33:46.542] > local-server-2> Running ssh connection command: "-v -T -D 55027 -o ConnectTimeout=15 coder-vscode--redacted--redacted bash"
[13:33:46.543] > local-server-2> Spawned ssh, pid=4028
[13:33:46.545] stderr> OpenSSH_9.0p1, LibreSSL 3.3.6
[13:33:49.532] stderr> debug1: Server host key: ssh-rsa SHA256:REDACTED
[13:33:49.533] stderr> Warning: Permanently added 'coder-vscode--redacted--redacted' (RSA) to the list of known hosts.
[13:33:49.837] stderr> Authenticated to coder-vscode--redacted--redacted (via proxy) using "none".
[13:33:50.142] > ready: eb90e7035509
[13:33:50.294] > Linux 5.4.228-131.415.amzn2.x86_64 #1 SMP Tue Dec 20 12:51:02 UTC 2022
[13:33:50.294] Platform: linux
[13:33:50.444] > /bin/bash
[13:33:50.445] Shell: bash
[13:33:50.445] Creating bash subshell inside "bash"
[13:33:50.597] > bash version:  5.0.17(1)-release
[13:33:50.648] > bash version:  5.0.17(1)-release
[13:33:50.728] > bash version:  5.0.17(1)-release
[13:33:50.760] > eb90e7035509: running
[13:33:50.776] > Acquiring lock on /home/coder/.vscode-server/bin/704ed70d4fd1c6bd6342c436f1ede30d1cff4710/vscode-remote-lock.coder.704ed70d4fd1c6bd6342c436f1ede30d1cff4710
[13:33:50.778] > Found existing installation at /home/coder/.vscode-server/bin/704ed70d4fd1c6bd6342c436f1ede30d1cff4710...

Checking /home/coder/.vscode-server/.704ed70d4fd1c6bd6342c436f1ede30d1cff4710.log and /home/coder/.vscode-server/.704ed70d4fd1c6bd6342c436f1ede30d1cff4710.pid for a running server
[13:33:50.779] > Looking for server with pid: 284
[13:33:50.783] > Found running server...
[13:33:50.784] >
*

Visual Studio Code Server

By using the software, you agree to
the Visual Studio Code Server License Terms (https://aka.ms/vscode-server-license) and
the Microsoft Privacy Statement (https://privacy.microsoft.com/en-US/privacystatement).

[13:33:50.791] > Checking server status on port 45909 with wget
[13:33:50.799] > eb90e7035509: start

DISPLAY====
webUiAccessToken====
listeningOn==45909==
osReleaseId==ubuntu==
arch==x86_64==
tmpDir==/tmp==
platform==linux==
unpackResult====
didLocalDownload==0==
downloadTime====
installTime====
extInstallTime====
serverStartTime====
connectionToken==redacted==
eb90e7035509: end
[13:33:50.799] Received install output:
DISPLAY====
webUiAccessToken====
listeningOn==45909==
osReleaseId==ubuntu==
arch==x86_64==
tmpDir==/tmp==
platform==linux==
unpackResult====
didLocalDownload==0==
downloadTime====
installTime====
extInstallTime====
serverStartTime====
connectionToken==redacted==

[13:33:50.800] Remote server is listening on 45909
[13:33:50.800] Parsed server configuration: {"serverConfiguration":{"remoteListeningOn":{"port":45909},"osReleaseId":"ubuntu","arch":"x86_64","webUiAccessToken":"","display":"","tmpDir":"/tmp","platform":"linux","connectionToken":"redacted"},"installUnpackCode":""}
[13:33:50.801] Persisting server connection details to /Users/redacted/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-52b8bf33-704ed70d4fd1c6bd6342c436f1ede30d1cff4710-0.100.0/data.json
[13:33:50.803] Starting forwarding server. localPort 55037 -> socksPort 55027 -> remotePort 45909
[13:33:50.803] Forwarding server listening on 55037
[13:33:50.804] Waiting for ssh tunnel to be ready
[13:33:50.804] Tunneled 45909 to local port 55037
[13:33:50.804] Resolved "ssh-remote+coder-vscode--redacted--redacted" to "<IP_ADDRESS>:55037"
[13:33:50.807] ------
[13:33:50.813] ------
[13:33:50.813] SSH Resolver called for "ssh-remote+coder-vscode--redacted--redacted", attempt 3, (Reconnection)
[13:33:50.814] SSH Resolver called for host: coder-vscode--redacted--redacted
[13:33:50.814] Setting up SSH remote "coder-vscode--redacted--redacted"
[13:33:50.815] Acquiring local install lock: /var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-remote-ssh-52b8bf33-install.lock
[13:33:50.816] Looking for existing server data file at /Users/redacted/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-52b8bf33-704ed70d4fd1c6bd6342c436f1ede30d1cff4710-0.100.0/data.json
[13:33:50.816] Found local server running: {"remoteListeningOn":{"port":45909},"osReleaseId":"ubuntu","arch":"x86_64","webUiAccessToken":"","display":"","tmpDir":"/tmp","platform":"linux","connectionToken":"redacted","pid":4023,"ipcHandlePath":"/var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-6ebad9e8cde873f36a0dfcaf5ecb52b60e451f23.sock","socksPort":55027,"startupTime":1682937226476}
[13:33:50.816] Running server is stale. Ignoring
[13:33:50.816] Using commit id "704ed70d4fd1c6bd6342c436f1ede30d1cff4710" and quality "stable" for server
[13:33:50.818] Install and start server if needed
[13:33:50.821] askpass server listening on /var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-79cc3efeb4c118433d798481c04d9944299c74f8.sock
[13:33:50.821] Spawning local server with {"serverId":3,"ipcHandlePath":"/var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-0740537d705abf9e0ca5cdf88650e6349d5e2abe.sock","sshCommand":"ssh","sshArgs":["-v","-T","-D","55040","-o","ConnectTimeout=15","coder-vscode--redacted--redacted","bash"],"serverDataFolderName":".vscode-server","dataFilePath":"/Users/redacted/Library/Application Support/Code/User/globalStorage/ms-vscode-remote.remote-ssh/vscode-ssh-host-52b8bf33-704ed70d4fd1c6bd6342c436f1ede30d1cff4710-0.100.0/data.json"}
[13:33:50.821] Local server env: {"SSH_AUTH_SOCK":"/private/tmp/com.apple.launchd.ZSLaAxS9eQ/Listeners","SHELL":"/bin/zsh","DISPLAY":"1","ELECTRON_RUN_AS_NODE":"1","SSH_ASKPASS":"/Users/redacted/.vscode/extensions/ms-vscode-remote.remote-ssh-0.100.0/out/local-server/askpass.sh","VSCODE_SSH_ASKPASS_NODE":"/Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Plugin).app/Contents/MacOS/Code Helper (Plugin)","VSCODE_SSH_ASKPASS_EXTRA_ARGS":"--ms-enable-electron-run-as-node","VSCODE_SSH_ASKPASS_MAIN":"/Users/redacted/.vscode/extensions/ms-vscode-remote.remote-ssh-0.100.0/out/askpass-main.js","VSCODE_SSH_ASKPASS_HANDLE":"/var/folders/b3/v_w4bdvd0h118mlxh266s9g40000gn/T/vscode-ssh-askpass-79cc3efeb4c118433d798481c04d9944299c74f8.sock"}
[13:33:50.822] Spawned 4034
[13:33:50.884] > local-server-3> Running ssh connection command: "-v -T -D 55040 -o ConnectTimeout=15 coder-vscode--redacted--redacted bash"
[13:33:50.885] > local-server-3> Spawned ssh, pid=4039
[13:33:50.888] stderr> OpenSSH_9.0p1, LibreSSL 3.3.6
[13:33:51.299] > local-server-1> Timed out
[13:33:51.302] Local server exit: 0

Digging further - it appears it works properly on Linux, but not in Apple Silicon.

Looks like problem with Remote SSH extension. Downgrading from 0.100.0 to 0.84.0 solved it.


Allow creation of services which don't require Bluetooth connection

Bluetooth is required by default, it means that device services stop when it's off.
That can be changed by overriding isBluetoothConnectionRequired.
A better solution would be not to require Bluetooth by default and to have a separate class encapsulating Bluetooth-related behaviour:
public abstract class BluetoothDeviceService extends DeviceService  {

but that would be a breaking API change.

In the split_login_manager, the bluetooth listener only activates if there is a BLUETOOTH permission requested. Would that also resolve your issue?

Yes and no. We have at least one exception, namely PhoneBluetoothManager. It requires BLUETOOTH permission but should be able to work even when Bluetooth is off.

Good point.

@strangepleasures would this merge solve both issues?


Add ALB Context to API GW Payload V2

Issue #489
Description of changes:
Adds ALB Context to Request Context. Source
By submitting this pull request

[ X ] I confirm that my contribution is made under the terms of the Apache 2.0 license.
[ X ] I confirm that I've made a best effort attempt to update all relevant documentation.

Done

Any ETA on this one ?

On my list for this week, first tests were successful.
We may switch to aws-lambda-java-events lib in the future and I'm wondering about this:
https://github.com/aws/aws-lambda-java-libs/blob/events-v4-serialization-v2/aws-lambda-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/ApplicationLoadBalancerRequestEvent.java

Alb request is pretty much the same as Payload V2. I also agree this lib should be switched to use Events Library, but that would probably be a breaking change.

Yeah that's a 2.0 thing, we will not do it now. I was just thinking that it is probably not enough to have a single event (like in aws-lambda-java-events lib) but we rather need ApplicationLoadBalancerRequestEventV1 and ApplicationLoadBalancerRequestEventV2, don't we?

@deki , I think that SRP (Single Responsibility Principle) should be applied where possible, as in, 1 Event = 1 Class

@deki , do you want me to change to separate events and apply SRP ?

No let's keep it like this for know and refactor for 2.0.


Fix failure when generating sitemap with >25000 links

Resolves #123

Thanks @DavidBoone

@DavidBoone your solution worked without any issue. Thank you. Right now i'm seeing another issue when I'm trying to generate sitemap including images from the server "Check this box if you wish to check the presence of the image files on the server".
memory_limit 2048
max_execution_time 10000
max_input_vars 10000
Can u suggest me any solution? Thank you very much!

@zsocialmedia Please create a new issue. That permis to our @PrestaShop/prestashop-product-team to prioritize issues to being fixed ;) Thanks


Model download URLs need to be changed

The model download links starting at line 63 on english_booknlp.py need to be updated (needs to be people.ischool.berkeley.edu)

Thanks this should be updated now!


Adding icon and category for TMC catalog

Currently, adding Cloudhealth helm repo shows the cloudhealth-collector helm chart but displays no category (can't sort) and no icon like all of the bitnami repos do. This should change that.

@lucasmarzocco Check this PR out: https://github.com/CloudHealth/helm/pull/102/files.  I was adding an icon there anyway.. For the category field, helm does not allow a new field in Chart.yml. I added category: Cost to annotations in the above mentioned PR.
Let me know if it works.

@gm-cht: Should I close this MR if you're going to merge the same changes in yours? When do you expect to have them merged and ready to be used?

Yes. This PR can be closed. The other PR will be merged early next week..

Release 4.2.0 of the helm chart (currently being tested) has these changes.


pubsub error - Cannot read property 'onAuthorized' of undefined

Cannot read property 'onAuthorized' of undefined,

TypeError: Cannot read property 'onAuthorized' of undefined
    at onAuthorizedRequest (/home/leibale/workspace/images-processor/node_modules/gcloud/lib/common/util.js:397:19)
    at /home/leibale/workspace/images-processor/node_modules/gcloud/node_modules/google-service-account/connection.js:56:5
    at Connection.<anonymous> (/home/leibale/workspace/images-processor/node_modules/gcloud/node_modules/google-service-account/connection.js:116:5)
    at processImmediate [as _immediateCallback] (timers.js:354:15)

What version of gcloud are you using? If not master, would you mind testing against that, as we have made significant changes since 0.12.0 was released back in December.

ok, now it's working.
thanks.

Phew!

@stephenplusplus I got this error again
Cannot read property 'onAuthorized' of undefined,

TypeError: Cannot read property 'onAuthorized' of undefined
    at onAuthorizedRequest (/home/leibale/workspace/images-processor/node_modules/gcloud/lib/common/util.js:478:19)
    at /home/leibale/workspace/images-processor/node_modules/gcloud/node_modules/google-service-account/connection.js:56:5
    at Connection.<anonymous> (/home/leibale/workspace/images-processor/node_modules/gcloud/node_modules/google-service-account/connection.js:116:5)
    at processImmediate [as _immediateCallback] (timers.js:354:15)

Is there some method you are calling where you aren't specifying a callback?

only file.createReadStream() and file.createWriteStream(), but i listen to err and finish events

Ok! If you have a small snippet we could run to reproduce this it would greatly speed up tracking down the bug. That line throwing the error is used by every api request.

i using file.createWriteStream(), file.createReadStream(), subscription.pull().
i think it's from subscription.pull(), but..

it's happening on subscription.ack(result.id);

ok, i'ts


Inconsistent echo behavior on certain android devices

Reported in Slack community.
I’m playing a lot with RoomOptions.audioTrackCaptureDefaults flags and with LiveKitOverrides.javaAudioDeviceModuleCustomizer (to set UseHardwareAcousticEchoCanceler and UseHardwareNoiseSuppressor). Sometimes I find combination that seems to solve the problem, but the flags configurations end up being completely different on every device I try. On some other devices I don’t find a working configuration at all.
Examples

Samsung S8 (with Android 9): this one generates echo for all the other participants in the room if the audioTrackCaptureDefaults are true, but it doesn’t if they are false
pixel 2 we need to enable hardware cancellation not to get echoes & audio artifacts (by setting UseHardwareAcousticEchoCanceler to true in the audio module)

Hello! I think I managed to solve it for all my use cases/devices by not touching the audioTrackCaptureDefaults and only tweaking the setUseHardwareAcousticEchoCanceler() in the JavaAudioDeviceModule. I connect by doing something like this:
LiveKit.connect(
            context, url, token,
            roomOptions = RoomOptions(adaptiveStream = true),
            overrides = LiveKitOverrides(
                javaAudioDeviceModuleCustomizer = { builder ->
                    val useHardwareAudioProcessing = Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q
                    builder.setUseHardwareAcousticEchoCanceler(useHardwareAudioProcessing)
                        .setUseHardwareNoiseSuppressor(useHardwareAudioProcessing)
                }
            )
        )

If it's not too much trouble, could you list the devices this worked on?

Sure:

Samsung Galaxy S8 (Android 9)
Pixel 2 (Android 11)
Sony Xperia Z5 Compact (Android 7)
Xiaomi Mi 9T (Android 11)

@symphonybiz how did you get echo to reproduce? Is this by holding two devices close to each other so they are picking up each other's feedback?

@davidzhao no, actually the opposite. I put one in a different room.
I encountered 2 types of "echo": one is basically a single repetition of what's being said coming back from the offending device, while the other is a very noisy feedback loop.
From the Samsung s8 I would get the first type, while from the Sony Xperia I would get the other.

@symphonybiz just to confirm, the proposed solution is to turn on the hardware cancellers in devices Q and above?
This issue seems to imply the opposite, so just want to confirm.

yes @davidliu this is what it seems to work for us: disabling HW cancellation on < API 29

@davidliu from my POV this can be closed, because we're using the javaAudioDeviceModuleCustomizer customization above and have no problems now


Maximum call stack size exceeded

Bug report

What is the current behavior?
I use HMR in my project.When i edit any component(e.g.  'src/component/Header.js'),HMR hot update will result in error.

If the current behavior is a bug, please provide the steps to reproduce.

Clone/Download  https://github.com/Andytreee/react-starter
yarn && yarn start
3.Turn on this button in ur browser

Edit  'src/component/Header.js'

What is the expected behavior?
No error emitted and enjoy the convenience of HMR.

Other relevant information:
webpack version:  4.41.2
Node.js version: 13.6.0
Operating System:  Windows 10.0.18362.720
Additional tools:

It was a long time @

@Andytreee Problem still exists? Please create reproducible test repo

@Andytreee Problem still exists? Please create reproducible test repo

Problem still exists.The steps above can be reference to reproduce the problem.
Thx.

Remove new webpack.HotModuleReplacementPlugin() from webpack/webpack.config.dev.babel.js, webpack-dev-server automatically enable HotModuleReplacementPlugin when you set hot: true, anyway we can improve checking for HotModuleReplacementPlugin on webpack-dev-server for better DX


[Discussion] What is the main objective of Sacred

I've tried following the discussion #663, but it took a fast pace, and I would like to discuss some point about Sacred.

I'm not sure to understand what is the orientation of the project. What is Sacred ? is it a config manager and/or a observer/logging tool for experiment.

From my understanding, I don't see where is the reproductibility part here since the logging is not force (could be a txt file or a mongoDB). All I can see is Sacred offer me a config manager and also offer a option of logging (which you call observer, but I strongly disagree with the name as explain in my PR #667 ). But, there not an option to checkpoint my experiment and be able to reproduce it.
Meaning, we should define was is the scope of the project first and after define the appropriate features to keep/work on. Because, for now, it's confusing the reason I should use Sacred instead of other option like MLFlow.

Also, the workflow of config seem confusing for me, why when you call run you override the named config ? It's seem illogical for me if you in some case, and we had to use a work around to make it work in our case.

Dear @davebulaval,
you point to some valid questions, but they way you ask them bothers me. To be honest, I had put off answering PR and your other comments, because I wasn't sure how to react.
I am sure you mean well, but I am finding it hard not to be offended.
You seem to be new to the Sacred project and as you have emphasized yourself, you do not yet fully understand its purpose. Yet you judge design choices and naming, and claim to know better. You use the phrase "we should define" indicating somehow that we are on the same team and should follow your suggestions. But to me you are just a stranger with strong opinions. In short, in my eyes you have not yet earned the respect you seem to presume.
I will draft a vision statement for sacred and post it for discussion, as soon as I find the time. But meantime I would ask you to tone yourself down, and be more careful with your participation.

@Qwlouse I must say I'm disapointed of your respond. The point of open source is to implicated the community and also accept critism again your work. If you don't think the community is in the same team as you, (I think) you misunderstood the concept of open source and collaboration.
I don't think I know the truth, I only have enonciated  arguments to defend my PR. What I'm trying to do is to open a discussion about implementation and flaws I see from my knowledge and i'm trying to fix them.
I really like the project and I see a lot of use in my work and I would really like to help improve it, but  if this is the approach of this project, to shutdown discussion, I will not tone myself down, I will just stop trying to help your project, and I think you will make a mistake (not for loosing me, clearly not the point here), but to block people to help your project and closing PR without proper reason.
Bottom line, sorry to have offended you when I've tried to discuss the improvement of the architectural design, that was not my intention.

@Qwlouse My reasoning is about to find what is the appropriate responsability of Sacred and by defining it, it would help scope the next step. I may be wrong but when I read this (good mighty python reference btw)

Every experiment is sacred
Every experiment is great
If an experiment is wasted
God gets quite irate

All I can think is Sacred is all about the experiment and should not wasted my config when I do a experiment. Meaning of that the main core is about automatic logging and good config management. And now, config management is really good and the logging is quite awesome (but not automatic). So one should define what the next step of not wasting and experiment should be.

Bottom line, sorry to have offended you when I've tried to discuss the improvement of the architectural design, that was not my intention.

Thank you, the apology is appreciated.
My goal is certainly not to shutdown discussion, nor to cut you out.
But you have a rare gift when it comes to triggering me.
This is of course mainly my problem, and I'll try to remain calm as best I can.
But would ask you to help me out in this by being more diplomatic in your feedback and reducing the agressiveness in your comments. I hope you understand.

I must say, I don't see were i'm aggresive but I rethink about it in the future.

@davebulaval please weight your words when you disagree or dislike a feature (think about the number of hours that were spent into making it), and please keep your vocabulary as profesional as possible. It's github, not reddit. It's fine to make a joke here and there, but  "logging a shitload of data" isn't something that's appropriate for a work environment with strangers.

@gabrieldemarmiesse I think the discussion is becoming a lot personnal, you all mayde your point that you don't like my attitude. As a last comment, keep in mind that we don't all have the same standard (and definition) of professionnalism and appropriate behavior (and don't apply it at the same level). One may said a sentence that trigger in some context (and country) and not at all in another one.
 I've try explainning why implementing of some feature may break on the long run. My proposition was a tiny step into that direction (that I though would be better in the long run) and it's seem to transform in this huge conflict between some (all) of the key contributor and the position I took trying to explain why naming and respecting SOLID principles is a key to better code.
At last, I hope by ... taking strong position that I've helped some redefining in the key features and design choice  to improve Sacred by challenging some of these choices. At least, we could all get that from this Github conflict by having a better Sacred.


[feature request] file complete path on titlebar tooltip

I often work on files with the same name in two nvui windows. It would be very useful to have a preview of the complete path to distinguish them more easily. Would it be possible to add a tooltip to the titlebar? Thank you.

By complete path do you mean the full working directory/file path?
If you want to show the full file path then you can override NvuiGetTitle like so
" Put this somewhere in your init.vim
" Titlebar text will be something like "nvui • D:\Dev\file.txt"
function! NvuiGetTitle()
  return join(split("nvui," . expand("%:p"), ","), g:nvui_tb_separator)
endfunction

Thanks for the reply!
Yes, by complete path I mean just that.
I followed your instructions and got the expected result.
This wil be a wonderful tip for the wiki!
WARNING!!! THE OVERRIDE MUST BE OUT OF BLOCK:
if exists('g:nvui') ... endif

Nice, I added it to the wiki as well.


When entering in Japanese, if you press enter to confirm the text only for the first time, a line break will occur at the same time as confirmation.

#![ダウンロード](https://github.com/xdan/jodit/assets/135815496/4d8ce673-9bea-46ea-8544-8745760a37d5)

Jodit Version:  v3
Browser:  Safary
OS:  Mac
Is React App:
Code
// A *self-contained* demonstration of the problem follows...

Expected behavior:
no extra line breaks
Actual behavior:
When entering characters in Japanese, it occurs that a line break occurs when you press enter to confirm the text content.

How's the situation?


how to create inline forms

Hiya. Best to take your question to the Django discussion group, or stack overflow, or similar.
Vanilla views exposes the same functionality as Django's generic views, so the answer for vanilla views should be the same (or very similar) as the answer for django in general.


Migrate default theme to Bootstrap 3

Pull requests for this won't be considered/accepted until 0.6.0 is delivered, which will be this week.

how far is the work around?

Done with #434 💃


added > to access key ID field

Signed-off-by: Babatunde Olu-Isa<EMAIL_ADDRESS>What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

/assign @alvaroaleman

/release-note-none
/lgtm
/approve
@boluisa :wave: Thanks for this change! I also noticed that you created a similar PR (https://github.com/kubermatic/machine-controller/pull/536). In general, if the PR gets a dco-signoff: no, feel free to force push on your branch. This will automatically remove that label and change it to dco-signoff: yes.
Btw in case you find some more changes like these, could you batch them up into a single PR? Typos should definitely be corrected but we try to bundle small changes into one PR in this repo. :smile:

/retest

/retest

/retest

/retest


select blocks to calculate seemed not work

select blocks to calculate seemed not work? Or more information for using this command?

This is a program that performs addition between blocks containing only numbers. First, select the first block and press the Esc key, then use the Ctrl key to select each subsequent block. Please move the block with the total value to any desired location by dragging it with the mouse.


Do not remove out.js, let linker overwrite existing file

Usually during development I run continuous compilation
$ ./mill -w webapp.fastOpt

and webpack dev server which watches js output for changes and refreshes the page if any.
Webpack dev server doesn't like when the file it is watching disappears. In such cases dev servers fails with an error.
ERROR in ../out/client/fastOpt/dest/out.js
Module build failed (from ./node_modules/react-hot-loader/webpack.js):
Error: ENOENT: no such file or directory, open '/workspace/webapp/out/client/fastOpt/dest/out.js'

Does that really solve the issue? I doubt it. The targets which calls the link method (fastOpt, fullOpt) are not persistent and will clean the whole dest directory even before calling the link method.

Ok then, if that's the case this fix is worthless.

You could work around by creating a new perstistent target, which replaces a copy of `out.js whenever a new version was build.


Emit System Error?

I was having a go at porting melor/node-posix#30 to run on node 0.12/io.js and it had code like this:
if(chdir(*dir_path)) {
  return ThrowException(ErrnoException(errno, "chroot: chdir: "));
}

When dir_path referred to a non-existent directory, this resulted in the thrown JavaScript Error object having a code property with the string value ENOENT and an errno property with the value 2.  I translated it to:
if(chdir(*dir_path)) {
  return NanThrowError("chroot: chdir: ", errno);
}

code then had the value 2 and no errno property, which is less useful.
Is there an easy way to get the code translated to a string with nan?  Or does there need to be a new NanThrowSystemError macro or similar?

Currently there is no easy way. The ErrnoException function does many things.
https://github.com/iojs/io.js/blob/v1.x/src/node.cc#L712-755 There would have
to be a new NanSomething.
On Wednesday 11 February 2015 01:53:10 Alex Potsides wrote:

I was having a go at porting melor/node-posix#30 to run on node 0.12/io.js
and it had code like this:
if(chdir(*dir_path)) {
  return ThrowException(ErrnoException(errno, "chroot: chdir: "));
}

When dir_path referred to a non-existent directory, this resulted in the
thrown JavaScript Error object having a code property with the string
value ENOENT and an errno property with the value 2.  I translated it
to:
if(chdir(*dir_path)) {
  return NanThrowError("chroot: chdir: ", errno);
}

code then had the value 2 and no errno property, which is less useful.
Is there an easy way to get the code translated to a string with nan?  Or
does there need to be a new NanThrowSystemError macro or similar?

Reply to this email directly or view it on GitHub:
https://github.com/rvagg/nan/issues/281

Seeing how you're already using errno, can't you do e.g. NanThrowError(strerror(errno))?

Perhaps.  But if I do that I only get a message property on the Error object with the value No such file or directory - no code, no errno and no way of adding any extra contextual information to make it easier to work out what went wrong.

Just set up something similar to NanError(const char *msg, const int errorNumber). You can quite easily add all sorts of properties to the error object. Finally, throw the error object using NanThrowError.

If I do:
return NanThrowError(NanError("my message", errno));

I get:
{
  message: 'my message',
  code: 2,
  stack: '...'
}

So, a magic number for code and no actual error message other than what I provide.
If I do:
return ThrowException(ErrnoException(errno, "my message"));

I get:
{
  message: 'my message',
  code: 'ENOENT',
  errno: 2,
  stack: '...'
}

The magic number is in the errno property and a friendly(ish) string is in code.
I guess what I really want is something a bit like a System Error, so I'd do:
return NanThrowSystemError("my message", errno);

And get get:
{
  message: 'my message',
  code: 'ENOENT',
  errno: 2,
  stack: '...'
}

I'd rather not have to set up each property of the error object every time because it will become very verbose very quickly.

This is too POSIX-specific. It is unlikely to happen. Best way is to write your own utility function which does what you want and then use that.


Increase non-breaking error level

If there is an error in a non explicit gotemplate file, we used to simply add a notice. But that often resulted in hidding the actual error, so we display it as an error, but still not breaking.

Pull Request Test Coverage Report for Build 542

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.714%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

template/template_process.go
0
1
0.0%

Totals

Change from base Build 539:
0.0%

Covered Lines:
3766

Relevant Lines:
5645

💛  - Coveralls