PyInstaller hooks needed

When bundling pygfx with PyInstaller into an application, there are some data files and some dynamic libs missing.
We need to bundle:

dynamic libs of freetype (collect_dynamic_libs)
data from pygfx.pkg_resources (collect_data_files)

I noticed that when just using collecting_data_files("pygfx.pkg_resources") results in a name clash with pkg_resources module from setuptools. We might consider replacing the use of pkg_resources with importlib.resources?

dynamic libs of freetype (collect_dynamic_libs)

At least within the pygfx library, we can and should only provide a hook for pygfx' resources. Freetype needs to get a hook of its own, or a hook can be contributed to to the pyinstaller community hooks.

data from pygfx.pkg_resources (collect_data_files)

If anyone wants to take a shot at this, please adopt the modern approach we also applied in wgpu-py. It includes unit testing on CI. Note that it's only run as part of one testing job (py3.9 I believe) since it's a little slow to run that test.
https://github.com/pygfx/wgpu-py/tree/main/wgpu/__pyinstaller
(Modern here means that hooks can be included in packages themselves, and unit tested. Previously all hooks would live inside pyinstaller which introduces a lot of maintenance churn as you can probably imagine).

I noticed that when just using collecting_data_files("pygfx.pkg_resources") results in a name clash with pkg_resources module from setuptools. We might consider replacing the use of pkg_resources with importlib.resources?

I don't have a problem with that.

I agree that it's probably easiest (also on the long term) to implement the approach that we use in wgpu-py. This then needs to be applied in pygfx and also contributed to freetype-py.
As for the name clash, would renaming the directory to just resources (as in wgpu) help?

As for the name clash, would renaming the directory to just resources (as in wgpu) help?

Yes, that would work for now.
The freetype problem actually stems from a path/resource lookup that expects the path at a certain location relative to the original source file, which doesn't take into account packaged applications: https://github.com/rougier/freetype-py/blob/51ee6e15e6d7b3a9ca0f5e96b11bfa8c07575c36/freetype/raw.py#L32
It seems that the dynamic library is already found by PyInstaller but it is moved to the root of the bundled package, hence the lookup fails. So it might suffice to have freetype make use of the following snippet:
is_frozen = getattr(sys, "frozen", False)
if is_frozen:
    package_root = Path(sys._MEIPASS)
else:
    package_root = Path(__file__).parent.resolve()

Here's freetype: https://github.com/rougier/freetype-py/pull/162


Error while not importing all model variables from another script

from annuity.submodel.interest_rates import yearly_forward_rate, forward_rate

works well
from annuity.submodel.interest_rates import forward_rate

then I get
cashflower.CashflowModelError: Ensure that model variable and formula have different names. Please check: yearly_forward_rate_formula

That's a correct behaviour but not a clear error message.
All model variables defined by the user must be present in the model.py script to be picked up by the model.
Please use, for example, the following code:
from annuity.submodel.interest_rates import *

Error message has been changed in https://github.com/acturtle/cashflower/commit/f2c2eca8b75a2930a10972898f3fba9db50f99f8


Show help option

coverage: 96.774%. remained the same
when pulling 9ea1be1f05c1ac1d2d17262182e7f91fdff50c4a on chore/show_help_option
into bb38741a9c0922898eba7b65ea7597dca11cdce9 on 2.0.


Cloudstrap hooks may need access to determined AWS region, access key, and secret key

Since the current determination of these values is a mixture of cloudstrap configuration and aws sdk conventions for reading these from environment and ~/.aws/ configuration files (and environment variables which can specify the location of the configuration files), it's not obvious what values cloudstrap will use for the region, access key, and secret key.

This should be exposed via environment, using the standard AWS variables:

AWS_REGION
AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY

Currently this is not the case. I'll add this. Thanks!


New flat styling of the transaction log

Task description
In some of the need-to-have flows a new flat style for the transaction log can be seen. This is a nice to have task with low priority.
The new flat design can e.g. be seen in Flow 3, or in the screenshot below.
Important! Please coordinate between between iOS and Android development, so these nice-to-have changes are only done, if there is time to do them on both platforms.

Verified.
Versions

Software Version: Testnet 2.0.1 (71)
OS: Android 11
Browser: N/A
Mobile device: Pixel 4a


If the page is not under the docs, the next link is incorrect.

please check out the link at https://nextra.site/docs/custom-theme

@Sahil-B07 thanks for following up the issue.
you can visit the page https://nextra.site/docs/custom-theme#, we can't redirect to About Nextra page.

ohh, got it !
I'll work on this issue :)

this was fixed in Nextra v3 https://nextra.site/docs/custom-theme


MudAutocomplete: Make the autocomplete attribute configurable (#9318)

Description
This PR introduces an autocomplete parameter to the MudAutocomplete component, allowing developers to configure the autocomplete attribute directly.
Problem
The existing method of disabling autocomplete—by appending a unique identifier to the autocomplete attribute—no longer works in Chrome as of 2024. Recent changes in browser behavior for security and usability reasons have rendered this approach ineffective.

As shown in the screenshot, the hardcoded autocomplete value overrides other methods that developers might use to customize it, such as setting an HTML element attribute or using splatting.
Solution
This change adds an autocomplete parameter to the MudAutocomplete component, enabling developers to configure this attribute as needed. This approach not only resolves the current issue but also future-proofs the component against further changes in browser behavior.
Impact

Developers: Provides flexibility to set the autocomplete attribute based on their specific needs, enhancing usability and accessibility.
Backward Compatibility: The default value remains the same to avoid breaking existing implementations. Developers can opt-in to configure it differently.

References

Fixes #9318

How Has This Been Tested?
Visually, I have run my build on a local test project and checked if everything works as intended.
Type of Changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

How about placing the attribute before @attributes="UserAttributes" instead so it can be overridden that way without requiring an extra property?

@Aaron2404 If I read correctly, this doesn't fix the underlying issue of chrome displaying native autocomplete options? Shouldn't we rather add a fix for the underlying problem instead of just allowing certain experts internal access to fix it in their app and every user will have to fight Chrome on their own?

@Aaron2404 If I read correctly, this doesn't fix the underlying issue of chrome displaying native autocomplete options? Shouldn't we rather add a fix for the underlying problem instead of just allowing certain experts internal access to fix it in their app and every other user will have to fight Chrome on their own?

You are correct that this change doesn't directly address the underlying issue of Chrome displaying native autocomplete options. However, the biggest problem is that developers lack a straightforward way to modify the method to handle this issue effectively. This is not just a Chrome-specific problem but one that could occur with any browser implementing autocomplete functionality.
Our default solution should be robust enough to handle these cases across different browsers. I agree that addressing the root cause is crucial, but we also need to ensure that developers are able to customize the behavior in their applications easily.
Therefore, I propose a dual approach:

We work on a fix for the issue of autocomplete in chrome.

In the interim, we improve the current method to allow easier customization and flexibility for developers, ensuring that they can manage this behavior in their applications more effectively e.g. if there are any issues with other browsers.

By pursuing both strategies, we can provide an immediate workaround while still working towards a long-term solution that benefits all users.
Although, I should then probably create a new issue for this PR because the issue I made for this one is indeed too chrome specific.

Fair enough. Thanks!

How about placing the attribute before @attributes="UserAttributes" instead so it can be overridden that way without requiring an extra property?

@danielchalmers Sorry, I accidentally skipped over your reply. Actually you are right, it would be the best solution to just allow overriding autocomplete  via splashed user attributes and it should technically be possible like this:
autocomplete="GetAutocomplete()"
with
private GetAutocomplete() {
   if (UserAttributes.TryGetValue("autocomplete", out var userAutocomplete))
      return userAutocomplete;
  return "mud-disable-"+Guid.NewGuid();
}


Reasons for failing watermark removal

thankful for any pointers
iopaint run --model=lama --device=cpu \
--image=/inputdir/ \
--mask=/mask-artlist.png \
--output=/outputdir/

The white area on the mask will be considered as the area that needs to be inpainted.
Your mask is a PNG image with a transparent channel. The first three channels, RGB, are pure black and need to be converted, keeping the alpha channel as the mask. Below is the conversion code and the converted mask.

import cv2
img = cv2.imread("mask.png", cv2.IMREAD_UNCHANGED)
alpha = img[:, :, 3]
cv2.imwrite("real_mask.jpg", alpha)

The result

You can see that the inpaint results around the original mask are not very good; this is because the model expects the mask to be slightly larger than the original target, we can perform dilation on the mask.
import cv2

img = cv2.imread("mask.png", cv2.IMREAD_UNCHANGED)
alpha = img[:, :, 3]
cv2.imwrite("real_mask.jpg", alpha)

kernel = cv2.getStructuringElement(cv2.MORPH_RECT, (5, 5))
alpha_dilated = cv2.dilate(alpha, kernel, iterations=1)
alpha = alpha_dilated
cv2.imwrite("mask_dilated.jpg", alpha)

The following is the expanded mask and the inpaint result.


escape branch name

Trying to fetch base from branch joachim/no-word
{ name = "base"
        , repo = "https://github.com/dfinity/motoko-base"
        , version = "joachim/no-word"
        , dependencies = [] : List Text
        }

vessel install fails, maybe due to / in the branch name?
$ vessel install
[INFO] Installing 3 packages
[INFO] Downloading tar-ball: "base"
[WARN] Downloading tar-ball failed, cloning as git repo instead: "base"
Error: No such file or directory (os error 2)

Yeah it's because of the slash. I'm thinking I'd prefer to improve the error message here instead and forbid slashes in version. You can always use a commit hash instead.

Closing since package names and versions are now restricted to letters, numbers, dashes, underscores, and the . character.


Humid Heat Metrics

PR Summary
Human heat metrics applications notebook demonstrating different 4 methods of calculating wet bulb global temperature.
Related Tickets & Documents
Closes Comp #192
PR Checklist
General

[ ] PR includes a summary of changes
[ ] Link relevant issues, make one if none exist

This PR addresses 2 methods (ABM and Bernard)

Also (had a hard time including this on reviewNB, sorry), it looks like the docs are still having trouble with the equations.
Not sure if this is a formatting thing here or if we haven't set up the config file properly to handle latex formatting, though.

Also (had a hard time including this on reviewNB, sorry), it looks like the docs are still having trouble with the equations.

Oh I've seen this before with Pythia. We'll have to ensure Mathjax is in the config file. I feel like it was more finicky than should be (appearing correctly in local builds but not in the .md cells or something like that).

Math is working now. I cleared the output because we're making the notebooks execute on build soon.

Just dropping a note that this is waiting on #97

Looks like the preview action is having a bit of trouble. I'm going to look into it now and make an issue if this is a broader issue than this PR.

preview action is having a bit of trouble

Thanks @anissa111 for bringing this to my attention. I removed the loooong list of authors in references.bib.

preview action is having a bit of trouble

Thanks @anissa111 for bringing this to my attention. I removed the loooong list of authors in references.bib.

Wait, I don't think we have to do this, bibtex just wants us to use "and" instead of commas. I have it working locally with that change, I'll push it to save you the trouble of remaking it.

Okay no worries either way, it seems like enough authors that "et al" is appropriate.


After serial.open() onDestroy() gets called, app crashes

Hi,
my android app crashes after serial.open(...)
my js code is from one of the examples
serial.requestPermission(
          {
            vid: '1670',
            pid: '196'
          },
        	function(successMessage) {
            log(successMessage);

                serial.open({
                  dtr: true
                }, function success(successMessage){
                  log(successMessage);
    	             serial.write("10", log, log);
                }, log);
            },
            log
        );

Here is the logcat output
D/Serial  (15640): Resumed, driver=com.hoho.android.usbserial.driver.CdcAcmSeria
                   lDriver@3c7b8cae
D/Serial  (15640): Action: openSerial
D/Serial  (15640): Serialport:<CdcAcmSerialPort device_name=/dev/bus/usb/001/002
                   device_id=1002 port_number=0>
D/Serial  (15640): Destroy, port=null
I/Serial  (15640): Starting io manager.
D/Serial  (15640): Runner stopped.

Why is onDestroy() called?
Thanks!

Hello,
It seems there is a problem witht the port creation.
Can you give me more info about your setup?
Regards

Thank you for the fast reply!
I'm using cordova 5.4.0 and no other plugins.
I did run this both on my phone (HTC one s with cm12) and a intellibook tablet (these have excellent usb host functionalitiy). The device I'm trying to read data from is recognized (I can read the name and manufacturer)
Some additional debug info:
D/Serial(5009): driver:com.hoho.android.usbserial.driver.CdcAcmSerialDriver@3ccc8e7b
D/Serial(5009): device:UsbDevice[mName=/dev/bus/usb/001/002,mVendorId=5744,mProductId=406,mClass=0,mSubclass=0,mProtocol=0,mManufacturerName=OTT Hydromet,mProductName=OTT netDL,mSerialNumber=OH OTT HYDROMET,mConfigurations=[
D/Serial(5009): UsbConfiguration[mId=1,mName=null,mAttributes=192,mMaxPower=50,mInterfaces=[
D/Serial(5009): UsbInterface[mId=0,mAlternateSetting=0,mName=null,mClass=255,mSubclass=0,mProtocol=0,mEndpoints=[
D/Serial(5009): UsbEndpoint[mAddress=130,mAttributes=2,mMaxPacketSize=64,mInterval=0]
D/Serial(5009): UsbEndpoint[mAddress=3,mAttributes=2,mMaxPacketSize=64,mInterval=0]]]]

//port.open(connection) gets called

D/CdcAcmSerialDriver(5009): claiming interfaces, count=1
D/CdcAcmSerialDriver(5009): Control iface=UsbInterface[mId=0,mAlternateSetting=0,mName=null,mClass=255,mSubclass=0,mProtocol=0,mEndpoints=[
D/CdcAcmSerialDriver(5009): UsbEndpoint[mAddress=130,mAttributes=2,mMaxPacketSize=64,mInterval=0]
D/CdcAcmSerialDriver(5009): UsbEndpoint[mAddress=3,mAttributes=2,mMaxPacketSize=64,mInterval=0]]
D/CdcAcmSerialDriver(5009): Control endpoint direction: 128
D/CdcAcmSerialDriver(5009): Claiming data interface.

E/AndroidRuntime(5926): java.lang.ArrayIndexOutOfBoundsException: length=1; index=1
E/AndroidRuntime(5926): 	at android.hardware.usb.UsbDevice.getInterface(UsbDevice.java:232)
E/AndroidRuntime(5926): 	at com.hoho.android.usbserial.driver.CdcAcmSerialDriver$CdcAcmSerialPort.open(CdcAcmSerialDriver.java:117)
E/AndroidRuntime(5926): 	at fr.drangies.cordova.serial.Serial$3.run(Serial.java:233) // port.open(connection), line numbers are different because I added some log calls for debugging perposes
E/AndroidRuntime(5926): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
E/AndroidRuntime(5926): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
E/AndroidRuntime(5926): 	at java.lang.Thread.run(Thread.java:818)
W/ActivityManager(511):   Force finishing activity 1 io.cordova.hellocordova/.MainActivity

Thanks for taking the time :)

What is the device you try to plug?

It's a water quality logging device called OTT netDL

It seems to be this: http://www.ott.com/en-us/products/data-logging-and-telemetry/ott-netdl-datalogger-1/ ?
How do you connect it? Via the D-SUB? The USB?

Because obviously the problem is here:
E/AndroidRuntime(5926): java.lang.ArrayIndexOutOfBoundsException: length=1; index=1
E/AndroidRuntime(5926):     at android.hardware.usb.UsbDevice.getInterface(UsbDevice.java:232)

It seems the interface is not here, without the hardware it is hard to debug.

Hello,
Any updates ?
Regards
Xavier

Hi, I have the exact same problem. After successful permission confirmation there is an exception in open function of CdcAcmSerialDriver (same thing, opening interface at index 1 where there is just 1 interface). I am working with FT230x FTDI used on a custom board.
As far as I can tell probing (usb-serial-for-android) returns UsbSerialDriver, in my case it should be FtdiSerialDriver and not CdcAcmSerialDriver. Any idea why this is so? I am quite time pressed to solve this quickly so any help will be appreciated ...

So, the reason for default cast is in Serial.java (159):
customTable.addProduct(vid, pid, CdcAcmSerialDriver.class)

when using custom vid and pid, driver is always CdcAcmSerialDriver

So, in my case the solution is easy: I was using custom vid & pid because i had trouble recognizing the device. Using custom values seemed to help but then resulted in wrong driver class assignment. It turned out the problems I had with device recognition were issues of the device (it's a custom product in development) and that  FT230x is actually supported by usb-serial-for-android (though not listed by name there is a corresponding vid & pid). Connecting without explicit ids results in correct FtdiSerialDriver class.
It would be nice though if driver class of an unknown device could also be passed as an option ....
Thank's for great work!

Hello @matinca
Thanks for the neat investigation.
A qucik fix would be to be able to pass a third argument along with vidand `pid, this arg would then call the right class. I'll try to fix that in the next couple of hours.
Regards

So I published v0.0.6 to npm.
Please try the followig to get a fresh version of the plugin:
cordova plugin remove fr.drangies.cordova.serial
cordova plugin add cordovarduino

You now have the ability to specifiy which driver to use, please refer to the README
Let me know if it is OK for you.
Regards
Xavier

One issue: String comparison in Java. I suggest using this and importing the necessary classes:
String driver = opts.has("driver") ? (String) opts.opt("driver") : "CdcAcmSerialDriver";

					if (driver.equals("FtdiSerialDriver"))
							customTable.addProduct(vid, pid, FtdiSerialDriver.class);
					else if (driver.equals("CdcAcmSerialDriver"))
							customTable.addProduct(vid, pid, CdcAcmSerialDriver.class);
					else if (driver.equals("Cp21xxSerialDriver"))
							customTable.addProduct(vid, pid, Cp21xxSerialDriver.class);
					else if (driver.equals("ProlificSerialDriver"))
							customTable.addProduct(vid, pid, ProlificSerialDriver.class);
					else {
						Log.d(TAG, "Unknown driver!");
						callbackContext.error("Unknown driver!");
					}

Great!
I have to confess I didn't test what I did yesterday since I don't have any hardware right now.
I take your feedback in account tonight.
Thanks for your help!

I published v0.0.7 to npm.
cordova plugin remove fr.drangies.cordova.serial
cordova plugin add cordovarduino

To get a fresh copy.
Let me know if it is OK for you.
Regards,
Xavier

I haven't had a chance to test it yet (github was down for a while and hardware currently out of my hands). I hacked the plugin with the above code and it worked, I'll check with your update next week.
Thanks again for great work!

And to be honest, you code it, not me ;)
Regards

hi, sorry for not getting back sooner - everything works well ;)

Great!
Thanks for the head up @matinca.
I think we can close this issue.
Feel free to re-open if needed!
Regards


VAnchor proof generation for wasm-utils,sdk-core

Overview
After this PR webb.js will support generating ZKP for vanchor API
Checklist

[x] Proof input for vanchor
[x] implemente /proof/vanchor.rs create_proof
[x] Rust/wasm tests
[x] Update sdk-core
[x] TS Unit tests for proof generation
[ ]  Integration tests for VAnchor transfare

@drewstone  This is ready but still one piece missing in filling the gaps between the inputs (2,16)
Input UTXOs should have an index what value to use for that?


Light theme

There's an idea when could release the light version?
Thanks for this nice theme!

I can start working on one soon. Any PRs will be appreciated also. I've been busy lately

Any guide on how to find the colors to do it?

Any guide on how to find the colors to do it?

This The colours are there, make a PR I'll review it and give my critique etc and adjust if needs to be. Thanks


Update to Denizen 1.1.0, fixes #845

Now that the repo is fixed and I'm able to test build, I went ahead and updated the compatibility for you!
Fair warning that I'm pretty sure I committed all needed changes, however my IDE (IntelliJ IDEA) changed a few hundred lines of misformated code automatically so I had to carefully select only the lines that were actually intentionally changed (you might want to run an autoformatter over the entire project, seems to be a lot of stray whitespace in particular). It's possible I forgot to select a line, but I don't think I missed any.
Tested at least insofar as compiling properly against Denizen 1.1.0.

Thanks for doing this! However, I've already made these changes locally along with an attempt to support <1.1.0 via reflection (as Quests has many pre-MC 1.12 users whom won't be able to upgrade), so I'm holding off on this pending a roadblock. If it does, I'll merge your PR.
In the meantime, feel free to share the jar you've compiled with everyone at #845
Will put the stray whitespace on the to-do list.

Closing as legacy support was successful.


How to reset the file date ?

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've searched the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Question
Is there a feature not to keep the date of the downloaded file ?
Often the dates are far older than the download's date and Linux only keep this old date (modified) when moving or copying on an NTFS partition, that's why I want to get rid of this useless dates that make lose the download date
Verbose log
No response

--no-mtime

Yes, I ve checked, this work on my system, thanks a lot

Also see https://github.com/yt-dlp/yt-dlp/issues/3514#issuecomment-1105875575.


Feature/customizable user

This PR allows using a different user type than the usual AdminPanelUser as long as it conforms to AdminPanelUserType. I've tried to keep the current API in tact by using type aliases.
This PR also fixes the issue that user selected passwords would be emailed in plain text. Now it only does that when a random password was generated.

@steffendsommer I made the changes. Could you approve?


re-implement the signal_distortion_ratio metric

What does this PR do?
Fixes #803
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@quancs this is great! :purple_heart:

I assume we can safely remove this check right?
https://github.com/PyTorchLightning/metrics/blob/10b3a8529311579b3db1330842f730a643533065/torchmetrics/audio/sdr.py#L109-L113
else LGTM :]

Removed


nixosTest: pass attrs via simpleTest/makeTest

pass all input attrs to allow setting more options mentioned in the Test Options Reference when using simpleTest.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

nixosTest is a bit weird. Instead we could recommend runNixOSTest.

@m1-s I smell an antipattern here. Plz switch to runNixOSTest, as @roberth suggested.

@roberth @tfc thx for your advice. Worked as expected after setting node.pkgsReadOnly = false so needed overlays are applicable again.
Closing this one now.


Added test_quickstart_rules workflow (tests rules section of quick start)

@DoriftoShoes indeed, originally I added those 2 things (the name and path of the rule) as vars. But then I realized that there are 4 steps that are not quite as flexible: setup_post_to_web_hook_via_curl, test_check_output_after_post_via_wget, setup_post_to_web_hook_via_st2 and test_check_output_after_post_via_st2
So how should we handle those steps? We can of course make the entire cmd string in those steps a parameter, but then it won't be very readable.
What do you think?


refactor: Change visibility of constructor for testability

Pull Request
Description
PR contains a change that is required for the correct operation of dependent modules.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Code cleanup/refactoring
[ ] Documentation update
[ ] This change requires a documentation update
[ ] CI system update
[ ] Test Coverage update

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.91%.  Consider uploading reports for the commit 8487616 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #467   +/-   ##
=========================================
  Coverage     90.91%   90.91%
  Complexity      491      491
=========================================
  Files            47       47
  Lines          1750     1750
  Branches        210      210
=========================================
  Hits           1591     1591
  Misses           93       93
  Partials         66       66

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Is this repository dead?

Hello there,
do you have any plan on updating this repo?  Is this project still alive? 🙍

Any other real alternative out there?

@Victoor this would be... if it actually worked for me https://github.com/stefalda/ReactNativeLocalization/issues/21

I also tried that and it didn't worked for me either.
This one (react-native-i18n) works in Android and iOS.

This one (react-native-i18n) seems dead but it works for me. I'm using it in Android and iOS and no problem.

Yup, same here, I't just a bit sad to see all that pending pull requests

Maybe we can create a copy or something… The author seems to be disappeared. His email and website are offline too… What do you think?

Hey guys,
Sorry, I haven't been using react-native recently, so I don't have much time to dedicate to this repo. I'm looking for someone to take over. Any volunteers?

No worries, the lib is still working even on the last version of RN... btw I'm available if you want, let me know.

@mmazzarolo I think that you have to write him an email

ATTENTION: This repo is looking for a new developer to take over. Please email me<EMAIL_ADDRESS>

@Victoor whoops, thanks

I've been added to the collaborators, I'll take a look at the pending pull requests and update the lib a bit in the next days 👍
I'm closing now but feel free to comment if needed!

@Victoor and @Chris-Petty I've found the problem and updated the instructions to use ReactNativeLocalization with the newest RN versions with Android https://github.com/stefalda/ReactNativeLocalization


Filter sentences ahead of time

do some grammatical-goodness checks and ignore some sentences... mixed case is a sign of bad text..

CoreNLP has a component for case correction, e.g., “THis is BAD” => “This is bad” (hopefully steal some code from there to check for this?)
Processors uses an approach to determining if a period is part of an abbrev or sent end, can we use this alg here?

closes #385


OpenJDK tests on jdk18 result in error about wrong jtreg version

i.e. https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/367/console
Error: The testsuite at /home/jenkins/workspace/Grinder/aqa-tests/openjdk/openjdk-jdk/test/jdk requires jtreg version 6.1 b1 or higher and this is jtreg version 6-dev+0.
@llxia fyi

This one was also needed and has just been merged: https://github.com/adoptium/ci-jenkins-pipelines/pull/212

PR #3112 and https://github.com/adoptium/TKG/pull/247 are merged. test.getDependency job at 3 Jenkins servers are updated.
Running Grinder: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/390/

Noticed the failure in Grinder https://github.com/adoptium/TKG/pull/247#issuecomment-970346423. We are working on the fix.

https://openj9-jenkins.osuosl.org/job/Grinder/395/

Grinder passed with JDK18. The issue is resolved.


Regression test Mar 27 2019 lib release

[ ] Run all the E2E tests on the nightly branch on jenkins:
Note: Make sure that ALL the tests are being run (about 29 tests).
If the branch is not ready on jenkins, run them from your computer, pointing to dev17 server.

Because these ones have not been migrated to cypress yet, you have to run them manually:
Use this server: http://dev-com-17.accdemo.b2c.ydev.hybris.com:4200/
Keep the browser's console open at any time and monitor for errors.

[ ] Order history page
[ ] Change language/currency

Additionally, do a quick smoke test (equivalent to the big happy path test) on:

[ ] Safari
[ ] Firefox

Tested on dev17

[X]  Run all the E2E tests on the nightly branch on jenkins:
Note: Make sure that ALL the tests are being run (about 29 tests).
If the branch is not ready on jenkins, run them from your computer, pointing to dev17 server.

Because these ones have not been migrated to cypress yet, you have to run them manually:
Use this server: http://dev-com-17.accdemo.b2c.ydev.hybris.com:4200/
Keep the browser's console open at any time and monitor for errors.

[X]  Order history page
[X] Change language/currency

Additionally, do a quick smoke test (equivalent to the big happy path test) on:

[X] Safari (Registration didn't work for me, but it worked for Gil & Patrick).
[X] Firefox


Bad compositor / incorrect dependencies even though GraphicsMagick is installed

Hey there,
I just got this stack trace on my AppVeyor build all of a sudden - happens intermittently which is confusing:
The Broccoli Plugin: [object Object] failed with:
Error: Either you defined a bad compositor or you dont have the correct dependencies installed.
    at generateSprite (C:\projects\dashboard\node_modules\node-sprite-generator\lib\nsg.js:66:25)
    at C:\projects\dashboard\node_modules\broccoli-sprite\index.js:56:5
    at initializePromise (C:\projects\dashboard\node_modules\rsvp\dist\rsvp.js:589:5)
    at new Promise$1 (C:\projects\dashboard\node_modules\rsvp\dist\rsvp.js:1077:33)
    at BroccoliSprite.updateCache (C:\projects\dashboard\node_modules\broccoli-sprite\index.js:55:17)
    at C:\projects\dashboard\node_modules\broccoli-sprite\node_modules\broccoli-caching-writer\index.js:49:36
    at lib$rsvp$$internal$$tryCatch (C:\projects\dashboard\node_modules\broccoli-sprite\node_modules\broccoli-caching-writer\node_modules\rsvp\dist\rsvp.js:493:16)
    at lib$rsvp$$internal$$invokeCallback (C:\projects\dashboard\node_modules\broccoli-sprite\node_modules\broccoli-caching-writer\node_modules\rsvp\dist\rsvp.js:505:17)
    at C:\projects\dashboard\node_modules\broccoli-sprite\node_modules\broccoli-caching-writer\node_modules\rsvp\dist\rsvp.js:1001:13
    at lib$rsvp$asap$$flush (C:\projects\dashboard\node_modules\broccoli-sprite\node_modules\broccoli-caching-writer\node_modules\rsvp\dist\rsvp.js:1198:9)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

Here's my GraphicsMagick version:
gm version
GraphicsMagick 1.3.25 2016-09-05 Q16 http://www.GraphicsMagick.org/
Copyright (C) 2002-2016 GraphicsMagick Group.
Additional copyrights and licenses apply to this software.
See http://www.GraphicsMagick.org/www/Copyright.html for details.
Feature Support:
  Native Thread Safe       yes
  Large Files (> 32 bit)   yes
  Large Memory (> 32 bit)  yes
  BZIP                     yes
  DPS                      no
  FlashPix                 no
  FreeType                 yes
  Ghostscript (Library)    no
  JBIG                     yes
  JPEG-2000                yes
  JPEG                     yes
  Little CMS               yes
  Loadable Modules         yes
  OpenMP                   yes (200203)
  PNG                      yes
  TIFF                     yes
  TRIO                     no
  UMEM                     no
  WebP                     yes
  WMF                      yes
  X11                      no
  XML                      yes
  ZLIB                     yes
Windows Build Parameters:
  MSVC Version:            1500

Not sure what else could cause this issue besides a bad gm installation, but it seems fine. Any ideas?

Can you check if an error is catched here and what it is? https://github.com/selaux/node-sprite-generator/blob/2b51f7880dfc9131c0a3499f5a4f2845e97f6e79/lib/nsg.js#L38

trying to require gm
{ Error: Cannot find module 'gm'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (C:\projects\node-sprite-generator\lib\compositor\gm.js:7:10)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3) code: 'MODULE_NOT_FOUND' }

Looked for it in the tree but couldn't see it trying to get installed either.

Can you try installing it manually, it is an optional dependency thus npm install might not have raised an error if it cannot install.

Where do you want me to try and install it? Globally or within node-sprite-generator?

The gm module within node-sprite-generator

@kevingelion Any update?


Remove Serilog as a dependency

Serilog.Formatting.ITextFormatter exists in the Serilog package. Sans an Abstractions package, this dependency is mandatory 😢


Unable to find wetty.conf file

I installed Wetty using yarn global add wetty and it was installed in /usr/local/share/.config/yarn/global/node_modules/wetty. However, it only has LICENSE README.md build node_modules package.json files and folders. I am unable to find the /conf/wetty.conf in wetty directory.

these conf are now being bundled in the npm module again


Build step validation for network names

Pull list of supported networks from the network subgraph and validate the subgraph manifest with that list.
cc @schmidsi @azf20 can you share the link to subgraph?

Aligned with "chain registry" efforts

Done


Refactoring package.json for Better Compatibility and Efficiency

Hello,
This pull request includes several changes to the package.json file to improve the library's compatibility and efficiency:

Move from jest to peerDependencies: This change allows users of this library to use their own version of Jest, increasing compatibility with different projects.

Move from @types/jest to optionalPeerDependencies: Similar to the above, this allows consumers to optionally use their own TypeScript typings for Jest.

Type libraries moved to devDependencies: This prevents these libraries from being installed by consumers of this library, thus reducing unnecessary installations.

These changes are intended to make this library more efficient and compatible with a wider range of projects.
Please review these changes and provide your feedback.
Best.

Thanks! Some of these ideas I've considered in the past, and I'll have a look at this tonight.


Client doesn't have permission to access the desired data.

i have configured the emberfire like that
confg/environment
module.exports = function(environment) {
var ENV = {
modulePrefix: 'route-map',
environment: environment,
baseURL: '/',
locationType: 'auto',
firebase: {
apiKey: "AIzaSyCYgcIqEaeC8edqDFlyW0evpQkpi8CFpBg",
authDomain: "route-map-1469c.firebaseapp.com",
databaseURL: "https://route-map-1469c.firebaseio.com",
storageBucket: "route-map-1469c.appspot.com",
},
// if using ember-cli-content-security-policy
contentSecurityPolicy: {
'script-src': ''self' 'unsafe-eval' apis.google.com',
'style-src': ''self' 'unsafe-inline' fonts.googleapis.com',
'font-src': ''self' fonts.gstatic.com',
'frame-src': ''self' https://.firebaseapp.com',
'connect-src': ''self' wss://.firebaseio.com https://*.googleapis.com'
},
EmberENV: {
EXTEND_PROTOTYPES: false,
FEATURES: {
// Here you can enable experimental features on an ember canary build
// e.g. 'with-controller': true
}
},
APP: {
  // Here you can pass flags/options to your application instance
  // when it is created
}

};
if (environment === 'development') {
// ENV.APP.LOG_RESOLVER = true;
// ENV.APP.LOG_ACTIVE_GENERATION = true;
// ENV.APP.LOG_TRANSITIONS = true;
// ENV.APP.LOG_TRANSITIONS_INTERNAL = true;
// ENV.APP.LOG_VIEW_LOOKUPS = true;
}
if (environment === 'test') {
// Testem prefers this...
ENV.baseURL = '/';
ENV.locationType = 'none';
// keep test console output quieter
ENV.APP.LOG_ACTIVE_GENERATION = false;
ENV.APP.LOG_VIEW_LOOKUPS = false;

ENV.APP.rootElement = '#ember-testing';

}
if (environment === 'production') {
}
return ENV;
};
application/adapter.js
import FirebaseAdapter from 'emberfire/adapters/firebase';
export default FirebaseAdapter.extend({
});
I am getting the following error
ember.debug.js:28550 Error while processing route: newcase permission_denied at /cases: Client doesn't have permission to access the desired data. Error: permission_denied at /cases: Client doesn't have permission to access the desired data.
at Error (native)
at G (http://localhost:4200/assets/vendor.js:66575:36)
at Object.G (http://localhost:4200/assets/vendor.js:66579:86)
at http://localhost:4200/assets/vendor.js:66550:503
at kh.g.wd (http://localhost:4200/assets/vendor.js:66555:104)
at Ye.wd (http://localhost:4200/assets/vendor.js:66458:364)
at rd.gg (http://localhost:4200/assets/vendor.js:66456:280)
at vd (http://localhost:4200/assets/vendor.js:66409:464)
at WebSocket.La.onmessage (http://localhost:4200/assets/vendor.js:66408:245)logError @ ember.debug.js:28550error @ ember.debug.js:28493triggerEvent @ ember.debug.js:28609trigger @ ember.debug.js:53444trigger @ ember.debug.js:53258(anonymous function) @ ember.debug.js:53078tryCatch @ ember.debug.js:53777invokeCallback @ ember.debug.js:53792publish @ ember.debug.js:53760publishRejection @ ember.debug.js:53695(anonymous function) @ ember.debug.js:32068invoke @ ember.debug.js:333flush @ ember.debug.js:397flush @ ember.debug.js:205end @ ember.debug.js:560run @ ember.debug.js:682run @ ember.debug.js:21194(anonymous function) @ firebase.js:137(anonymous function) @ firebase.js:386(anonymous function) @ firebase.js:377Tb @ firebase.js:273uc @ firebase.js:260vc @ firebase.js:259(anonymous function) @ firebase.js:446(anonymous function) @ firebase.js:417g.wd @ firebase.js:422Ye.wd @ firebase.js:325(anonymous function) @ firebase.js:323vd @ firebase.js:276La.onmessage @ firebase.js:275
ember.debug.js:32110 Error: permission_denied at /cases: Client doesn't have permission to access the desired data.
at Error (native)
at G (http://localhost:4200/assets/vendor.js:66575:36)
at Object.G (http://localhost:4200/assets/vendor.js:66579:86)
at http://localhost:4200/assets/vendor.js:66550:503
at kh.g.wd (http://localhost:4200/assets/vendor.js:66555:104)
at Ye.wd (http://localhost:4200/assets/vendor.js:66458:364)
at rd.gg (http://localhost:4200/assets/vendor.js:66456:280)
at vd (http://localhost:4200/assets/vendor.js:66409:464)
at WebSocket.La.onmessage (http://localhost:4200/assets/vendor.js:66408:2

Default security rules in the Firebase 3.0 SDK require users to be authenticated to read or write data.  So you will either need to be logged in to make a call to the database or change your security rules in your Firebase project to not require users to be authenticated.

thank you

I have added this to the database rules section:
{   "rules": {     ".read": true,     ".write": true   } }
still, the same error persist. I have chosen database option while doing firebase init for my ember app. Later I have deleted the database.rules.json. Still it doesn't turned up...

@gokulk13 please start your own thread rather than repurposing tangentially related topics. Be sure to include an mcve, as well as the output from the simulator tab (at https://<YOUR-FIREBASE-APP>.firebaseio.com/database/rules) when you run the same write event and the output from your debug logs (obtained from firebase.database.enableLogging(true);)


feat: remove the format element from the bibxml-id source of truth

fixes #5018

cc: @alicerusso, @ajeanmahoney, @cabo, @reschke
Note that this does not add a target attribute. We can discuss that in a separate issue.

Note that this does not add a target attribute. We can discuss that in a separate issue.

This is pretty much what kramdown-rfc now does for RFCs and I-Ds in default mode (it also deletes any target attributes on RFCs and I-Ds, so you don't need to bother putting them in).
xml2rfc does a great job computing the URIs (this is not so REST, but works great).


add distanceX and distanceY to tooltip

distanceX and distanceY, if given overrides the distance option.
change clampPosition to the edge and not opposite. ie. if you go distanceY = 400 it will max out on the top of the graph.

Demo:
http://jsfiddle.net/ucstdgsa/

@parikhshiv and @narenranjit
When you guys get the chance can you take a look at this and https://github.com/forio/contour/pull/251?
The only thing I am still debating about is distanceX, right now a positive number will send the tooltip left while a negative number will send the tooltip right. Not sure if that is intuitive, so might be best to switch it.

@senluchen2015 i haven't looked at the code or demo, so take with a grain of salt -- but i vote for distanceX positive values moving right / negative values moving left like a standard number line.

Code looks good to me, but I'd agree with Molly that positive values should move the tooltip right (and vice versa). Also, I'm not able to reposition the tooltip in the jsfiddle example, but I might be doing something wrong.

Flipped the direction so that positive number means towards right on distanceX. Positive distanceY is still going up.
Demo:
http://jsfiddle.net/ucstdgsa/1/

Updated tooltip distance to take object  or number
tooltip: {
    distance: {
          x: 100,
          y: 20,
    }
}

http://jsfiddle.net/ucstdgsa/2/


Add combat dialogue fix

This should fix the bug that causes NPCs to use LostToNormal dialogue instead of CombatToNormal after killing their targets.
I simply added a check if the combat target is dead. If it is, CombatToNormal will be used.

 They use LostToNormal dialogue instead of CombatToNormal (sometimes they don't say anything, and it needs a couple of tries)

In case you want to take a look yourself:
The patched location is I think related to CombatController though that's just a guess, I didn't find too much about this class. This is the enum that is used here (there are other members too), probably some kind of an event type.
It's not just dialogue as it seems to control other things as well (some values trigger combat music for example).
	kAlertIdle = 55,			// 37
	kLostIdle = 56,				// 38
	kNormalToAlert = 57,		// 39
	kAlertToCombat = 58,		// 3A
	kNormalToCombat = 59,		// 3B
	kAlertToNormal = 60,		// 3C
	kCombatToNormal = 61,		// 3D
	kCombatToLost = 62,		    // 3E
	kLostToNormal = 63,		    // 3F
	kLostToCombat = 64,		    // 40
	kDetectFriendDie = 65,		// 41


QuickFix: RouteOptions.init(coder: NSCoder)

Fixing issue where a missing (or invalid) value for distanceMeasurementSystem keypath would cause initializer to fail entirely.

/cc @1ec5 @bsudekum


make JSON Schema for validation rule validate against the JSON meta-Schema

Thank you for your help!


New WFRP Cursor

Is your feature request related to a problem? Please describe.
There isn't a WFRP cursor for the link state, this is probably new to the Foundry update I guess. So rather than having Mickey Mouses hand show up it would be nice to have something more WFRPy. Low priority
https://user-images.githubusercontent.com/68729767/133468975-dd8aaa6a-0152-46a7-be15-0ea44c5fea14.mov
Describe the solution you'd like
Something more like (below) perhaps? You know best it's your ui.
Additional context

There is already a cursor for the "pointer" state, it's an issue with it being rather complicated to get it working with PIXI (tokens)


Add dictionary support

Get word lists (format?)
dictionaries setting in new game creation
If a dictionary is set, validate words

Alternatively, consider using a dictionary API (or parse a dictionary website)

This has been partially completed: words that are not found via https://api.dictionaryapi.dev/ will display a validation error which does not block their play.
Further expansion: add native functionality for:

uploading a wordlist, e.g. via management command, which will construct and save a DAWG for word lookup (open question: should these live in codebase source? What file format?)
Option during game creation to pick from available word lists. Maybe also separate option to choose whether invalid words should block play
API endpoint to check word against chosen wordlists for game
Upload own wordlist?

Native functionality should also support blanks


IO config for Yi model

Hi, I'm trying to convert Yi model to onnx model. Since Yi model is not supported by optimum and transformers, where can I get IO of Yi model?

Nvm. Seems IO is same as llama model. Closing.


Allow adding lightning addresses as contacts

Description
Lightning addresses are email like address formats that are easy to use. BitBanana already supports lightning addresses for payments and has a contact list option, but there is no way to add a lightning address as a contact.

Context
When starting to add a contact, the app instantly starts into a QR scanning mode, without the possibility to enter text.

Possible Implementation
There could be an in-between screen that lets the user either enter a text (lightning address, pubkey etc) or start the QR scanning mode.

@jigglycrumb
Thanks for the issue.
I have to think more about how this could be best achieved. I am not sure if contacts should be combinable so one contact can have both a nodeUri and a lnAddress or if you should have to create 2 contacts in that case.
The tricky part is, what do I show as image if a contact has both?

I wouldn't mind having 2 contacts if one person has both. If that makes implementation easier 😄

Yes this is easier and most likely the way I will go.
It will still take a while until this is implemented tough, but it will come :)

Nice, looking forward to it! Thanks for your work!

This feature is implemented now and will be released with the next release.
Please se #33

Very nice, looking forward to testing it! :)

This was released with v0.6.3


Fix Executable File Not Found Error

storage-preview/azext_storage_preview/azcopy/util.py changed subprocess.call() param to array

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

I found this issue when running the command: az storage azcopy blob upload ... on Linux
The issue is that the call to subprocess.call() with the args param as a str results in a FileNotFoundError error:
FileNotFoundError: [Errno 2] No such file or directory: '/home/__REDACTED__/.azure/cliextensions/storage-preview/azext_storage_preview/azcopy/azcopy_linux_amd64_10.3.1/azcopy copy dist/__REDACTED__/** https://__REDACTED__.blob.core.windows.net/$web/?se=2020-07-13T16%3A42%3A15Z&sp=rwdlacup&sv=2018-03-28&ss=b&srt=sco&sig=__REDACTED__%3D --recursive'

This DOES work on Windows however on *nix, it treats the entire string as the executable name. The behavior of subprocess.call(), when passed a str is documented as platform-dependent (refer to this StackOverflow answer)

add to S173

Hi @jmostella, thanks for your fix and I will help you merge the PR. In addition, for azcopy related commands, we already supported them in azure cli, e.g. az storage blob sync, az storage copy, az storage remove and you can have a try.

@Juliehzl Thanks a lot! I'll have a look at those other commands as well.
Basically our use case is that we want to upload a web app directory tree to blob storage. Since we are using Static website hosting in Azure Storage.


Remove Grid lines from chart js at specific place

Expected behavior
I am using latest version of Chart js and I have implemented multiple X Axis and added grid lines on X axis, but I want to remove grid lines at a specific place but it is not working
https://stackoverflow.com/questions/75170264/remove-grid-lines-from-chart-js-at-specific-place
Current behavior
I am using latest version of Chart js and I have implemented multiple X Axis and added grid lines on X axis, but cannot remove grid lines at a specific place.
Reproducible sample
https://stackoverflow.com/questions/75170264/remove-grid-lines-from-chart-js-at-specific-place
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
No response
chart.js version
v4.2.0
Browser name and version
No response
Link to your project
No response

As stated in the documentation you need to configure the options in options.scales[scaleId].grid not in options.scales[scaleId].gridLines
Also you can use a scriptable function for the color by making the transparant or use a tick callback that returns null.
For these kind of questions please only post them on SO since they are not bugs


build(deps): bump golang.org/x/oauth2 from 0.1.0 to 0.5.0

Description
Related issues

Close #XXX

Remove this section if you don't have related PRs.
Checklist

[ ] I've read the guidelines for contributing to this repository.
[ ] I've added tests that prove my fix is effective or that my feature works.
[ ] I've updated the documentation with the relevant information (if needed).
[ ] I've added usage information (if the PR introduces new options)
[ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).

@fengshunli as discussed , no need to bump dependencies , there is a dependency bot for it. I suggest to close this PR

This new version, bots can't detect

@fengshunli as discussed , no need to bump dependencies , there is a dependency bot for it. I suggest to close this PR

This new version, bots can't detect

currently lets keep the current version.

Rely on updating the latest version to avoid vulnerability risk

Rely on updating the latest version to avoid vulnerability risk

we have a nightly build who scan for vulnerabilities , and if one found we update the dependency

not scanned

not scanned

Security management doesn't mean bump version to solve potential vulnetability.
Lets keep the existing version , no need to bump it

You can change weekly to daily


1077 rename endpoints

card: https://github.com/orgs/bcgov/projects/122/views/2?filterQuery=&pane=issue&itemId=56218560

continuing in another PR


Scheduled events on standalone VM - terminate notification

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. https://github.com/Azure/azure-rest-api-specs/pull/13351
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

/check-enforcer evaluate

/check-enforcer reset

@shpa-microsoft Could you provide a link to the swagger review pr in azure-rest-api-specs repo?

@YalinLi0312 I updated the description and pasting it here too https://github.com/Azure/azure-rest-api-specs/pull/13351

@shpa-microsoft You can follow the checklist in this PR's description, please update:

Mgmt metadata file
Versions in *.csproj and AssemblyInfo.cs
Release notes in *.csproj
If there's an API-version update, update the API tags in Az.Sdk.props

Additionally, make sure there's no manual change in the generated code and has proper test coverage for your updates.

@Sandido , Adam can you take look this PR as it goes into your feature release branch. Few problems from 2nd hand conversation from Yalin, 1. swagger not from master. 2. new field should adjust order to avoid breaking change 3. misc files in PR. Can you work with @shpa as per your feature branch policies.

@shpa-microsoft You can follow the checklist in this PR's description, please update:

Mgmt metadata file
Versions in *.csproj and AssemblyInfo.cs
Release notes in *.csproj
If there's an API-version update, update the API tags in Az.Sdk.props

Additionally, make sure there's no manual change in the generated code and has proper test coverage for your updates.

@YalinLi0312 , we will handle these changes when we want to merge the Feature Branch. Not in this PR.

@Sandido , Adam can you take look this PR as it goes into your feature release branch. Few problems from 2nd hand conversation from Yalin, 1. swagger not from master. 2. new field should adjust order to avoid breaking change 3. misc files in PR. Can you work with @shpa as per your feature branch policies.

@allenjzhang , I addressed your points. But the SDK is not generated from Master as the swagger has not yet been merged.


How to get a list of consumer groups?

Is there a way to obtain a list of consumer groups using the current Admin API?

We currently don't have a way to list of consumer groups, but this is a feature we want to add at some point.

Thanks! That would be great, I'm currently writing a lag monitoring application for our project and this would be a nice feature to have. Currently I have to manually provide the consumer group id, but it would be nice to be able to retrieve it via the Admin API.

For anyone who's keen, this would actually be a pretty good start to contributing (beyond something like documentation, etc). It's pretty much a one off request with the Kafka protocol, all the utilities of which are already in place!

I had a very noob question, how does kafkajs invoke the kafka APIs? Is it through RPC or REST? I was trying to find the starting point of the connection to the brokers in the source could, but was unsuccessful >~< Thanks!

@HunderlineK kafkajs use a socket. See the network code in this dir: https://github.com/tulios/kafkajs/tree/master/src/network

Hi @HunderlineK, Kafka has its protocol on top of TCP. In KafkaJS, you have the network layer which is responsible for the socket connection, and the protocol layer, which works encoding and decoding the binary payloads returned by Kafka. The closest thing to a rest client in the library is the broker, which uses the connection and the protocol to interact with Kafka.
You can take a look at the broker code here:
https://github.com/tulios/kafkajs/blob/master/src/broker/index.js
You can find the protocol requests here:
https://github.com/tulios/kafkajs/tree/master/src/protocol/requests
And the network code here:
https://github.com/tulios/kafkajs/tree/master/src/network

Oh, I think now I understand why developing a modern JavaScript Kafka client has been such an undertaking!
If I have understood the implementation correctly, all the helper functions are already provided, so this will only require, concretely speaking, creating a new folder under protocol/requests called ListGroups and implementing request and response handlers?
For each API, you need to first encode the message into bits based on its signature and then decode the response from bits. For each version of the API, we will also need a corresponding encoder/decoder? Though it seems sometimes one of them e.g. the request signature, remains the same across different versions.
Maybe I haven't noticed this, but all of the parameters are always required, correct? As in, we don't have situations where first we need to check the initial bits of the response in order to find out exactly what parameters we should be reading? (Or, set some initial bits in the request to specify what parameters we will be providing?)
Thanks.

@HunderlineK everything you will need is already in KafkaJS, the encoder and decoder can generate all types the Kafka protocol needs. The workflow is exactly what you have mentioned before, first you create a folder with the protocol method you want to implement, in this case, request/ListGroups. In there, you add all versions up to Kafka v1. Then you add your new protocol method in the list of available requests (https://github.com/tulios/kafkajs/blob/master/src/protocol/requests/index.js#L4). Finally, you add a method to the broker class.
I can help you land a PR, you can create a proposal PR in GitHub, and we can bounce ideas there.

@tulios So I've started implementing this; one thing I've noticed is that this particular ListGroups API does not accept any input, so after a bit of digging I found this:

The purpose of the ListGroups API is to get a simple list of the groups that are managed by each broker. To get a list of all groups in the cluster, tools will have to query each broker separately and combine the results.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-40%3A+ListGroups+and+DescribeGroup#KIP-40:ListGroupsandDescribeGroup-Motivation

I'm somewhat lost, as I'm not sure exactly how we can specify the broker?
Looking at a couple of other implementations, they approach it differently:

kafka-node iterates over all the brokers and returns the aggregate result:
https://github.com/SOHU-Co/kafka-node/blob/26fac1c16353b906e610def5fba4380778574339/lib/kafkaClient.js#L523

sarama accepts the broker as a parameter:
https://github.com/Shopify/sarama/blob/07c15a999b96f1a792f9ebd106a0a33924fa5042/broker.go#L442

I think kafka-node's approach makes more sense. We shouldn't offload that responsibility to the user, unless there's a compelling reason to.
I think the cluster has all the information you need - the current metadata with the broker's node id, and methods for retrieving those brokers. cluster.metadata() and cluster.findBroker. That gives you a Broker instance per broker, where you'd make the ListGroups call.

I think kafka-node's approach makes more sense. We shouldn't offload that responsibility to the user, unless there's a compelling reason to.

Couldn't agree more. As far as the user should be concerned, you're talking to the Kafka Cluster. Brokers should be an implementation detail of that as much as possible (not possible everywhere, like the amount of acks in producing message, where you'd have to think about the fact that there are individual Brokers). Querying all brokers and aggregating seems like a straightforward way to achieve that in this case.

I think this issue can be closed. This is fixed in release 1.13 and PR #645.

Yes indeed. Closing.


Improve Sentinel-2 timelapse function

This PR changes the sentinel2_timelapse function to use S2_HARMONIZED, which has a long timespan than S2_SR_HARMONIZED
import ee
import geemap
geemap.ee_initialize()
roi = ee.Geometry.BBox(104.295181, 3.570619,104.395181, 3.670619)
geemap.sentinel2_timelapse(
    roi,
    'S2.gif',
    2016,
    2017,
    start_date='02-01',
    end_date='03-30',
    frequency='day',
    apply_fmask=False,
    frames_per_second=0.5,
    )

Thank you for making these changes, I thought it might be due to the image collection :). The timelapse now working great. However, I have noticed that the images in the timelapse are of a considerably lower quality than when I add them to an interactive plot (see below). Is it possible to get images at full quality as using the timelapse? I am creating timelapses to quickly scan for features of interest (that can be quite subtle) that I can then use to find the images of interest and thus map.
Image A from timelapse

image A displayed on a geemap, notice feature in centre to edge of image that not as obviously visible in the image above

Image B from timelapse

Image B displayed on a geemap

GEE limit how much data you can download as a gif. It will be lower resolution than the original images if you try to create the timelapse for a large area.
The timelapse function has a dimension parameter. Change it to a larger value. If it exceeds the maximum dimension that GEE allows, it will download the thumbnails and create the gif offline. But it will take much longer. Under the hood, it uses a combination of the three methods below.
https://geemap.org/notebooks/47_image_thumbnails
https://geemap.org/timelapse/#geemap.timelapse.make_gif
https://geemap.org/notebooks/16_add_animated_text/


All namespaces and headers that use transparent_auth to authservice

Fixes #45
Any time I saw transparent_auth as a header, namespace, or in the comments I changed it to authservice in both the src and test folders. I also followed the same coding conventions.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: neilong31
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: neilong31, nickrmc83
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

Thanks!


Downloading videos has a delay

I just noticed today 5/20 that when I try to download a video from a profile or a story it takes forever, like over a minute at times.
Edit, it looks like Instagram is restricting video download to 32KB/s

Which browser are you using? Have the same in Firefox, no problems with Edge.

@Ascathon Using Chrome

Having the same issue. Firefox has a huge delay, Chrome downloads instantly but it's incredibly slow.


arraySort Function enhancement

sr arraySort function is too simple
I want to sort the array by other dimensions
similar to clickhouse
For path analysis, visual inspection still lacks many functions. Take your time, one by one

Please describe the requirement by priority and in detail, so that we could schedule the development.

OK, I try to describe my needs and examples in English
Usually, examples of arrays look like  ['logout','recharge','login','killboss']
But in fact, the business order cannot be excluded for specific strings
So I want to sort an array by another array
similar ['logout','recharge','login','killboss'] [4,2,1,3]
SELECT arraySort((x, y) -> y, ['logout','recharge','login','killboss'] [4,2,1,3) as res;
Output the sorting result of the first array according to the sorting of the second array
arraySort([func,] arr, …)
My example is that this writing method is actually clickhouse. I hope the official can seriously consider whether such a function can be available

Hi, we will enhance this function in version 2.5. You can use the branch-2.5 or main.


Not showing model name

What Happened?

Not showing model name when using cloudflare workers AI , but showing when using google AI
What Should Have Happened?
It should show @cf/meta/llama or something similar
Relevant Code Snippet
No response
Your Twitter/LinkedIn
twitter - mrinank100

I would like to work on this issue


Add goreleaser

Adds an action that will update releases (when tags are created) uploading binaries and annotating the release notes with a git diff. If you don't want the diff, we can set the fetch depth back to 1 and just upload binaries.
Currently configured to build amd64/arm64 for Linux and macOS.
Closes #106

An example with the same settings is ova here: https://github.com/arbourd/git-get/releases

@arbourd I think I'd prefer to keep the release notes out of it since we have a process to add our own text to the release, so could we just stick with the binaries?
This is awesome, and so simple!

Sounds good! Any preference to the name of the checksums file (or including it at all)?

@arbourd nope! LGTM :)

You might wanna give this a shot with a fake release (0.0.1-old) to ensure that the hooks are all gucci.

@arbourd we test in prod 😈


Don't error on atom lookup on custom classes

I have several classes that are custom like form-input along with vanilla tailwind classes. If these go through tw/1 calls, an error is returned. Is it possible to have unknown values fall through?

I am running into the same error I believe. String.to_existing_atom fails for my classes. I do use a custom tailwind prefix, so my classes are tw-text-red-500 for example. Hopefully Twix supports custom prefixes?

For now can you try pulling from master in your mix.exs and see if it works for what you need?

@bratsche works for me. the to_existing_atom  bug is gone and classes with custom prefix works too!


Milestone 1 Feedback

Project Setup:

Include a license.
Better to put the milestone write ups in a separate file rather than the main project readme
The contributing document is intended for you not the general public (unless you really will you be monitoring this project after the course is over. Instead, describe how you plan to collaborate on the project - will you work on a local version or the master branch? Will you track task assignments through issues?

Milestone 1:

Give the possible respondent answers for each question, particularly for the independent variable.
You might want to collect some demographic information. Age is likely a confounder.
Expand on the analysis. What potential problems do you foresee? How will you determine whether there is sufficient variation in first language learned and language preference?

(I apologize for the delay in getting this to you - you won't be docked marks for the survey specific questions in future milestones)

Issues have been addressed in latest commit!


Microsoft.Build.Traversal conflicts with .NET 8 SDK simplified output paths

When using the new .NET 8 simplified output paths feature with multiple dirs.proj projects using Microsoft.Build.Traversal they conflict with each other. The automatic ArtifactsProjectName determined by the .NET 8 SDK for all of the projects is dirs so they end up sharing a obj path within the artifacts directory, overwriting each other.
The only workaround I have found so far is to manually set the ArtifactsProjectName differently for each project. However, this must be done before the Microsoft.Build.Traversal SDK is imported. This means the simple Sdk="Microsoft.Build.Traversal" mechanism doesn't work and props and targets must be imported separately, which is messier and more difficult.

Traversal projects don't really produce any output, do you think it would be okay to just disable the simplified output paths feature all together for them?
<PropertyGroup>
  <UseArtifactsOutput Condition="'$(UseArtifactsOutput)' == ''">false</UseArtifactsOutput>
</PropertyGroup>

They do produce a variety of outputs, primarily related to the NuGet restore process.

While using the artifacts directory could be disabled, this would default some of the purpose of the directory, at least in my view. While there are many advantages to it, one advantage is a single directory that can be deleted to do a "clean" rather than something more aggressive like git clean -xdf that also nukes VS caches and user options. This is pretty valuable for large repositories with many projects, which is also the main use case for Microsoft.Build.Traversal.
Regardless, if the decision is not to support the artifacts directory, then it should probably be disabled by default within Microsoft.Build.Traversal before Microsoft.NET.Sdk is imported.

Yes the only real output is the intermediate folder (obj) but the project itself doesn't output anything like an assembly (bin folder).
The only other option I can think of is to uniquify the directory name under the artifacts which can be tricky.  Since each traversal project is probably named dirs.proj, we could somehow change the full-ish path to a string like:

ArtifactsPath
Actual Path

artifacts\root-dirs
D:\MyProject\dirs.proj

artifacts\root-src-dirs
D:\MyProject\src\dirs.proj

artifacts\root-src-something-dirs
 D:\MyProject\src\something\dirs.proj

This could end up exceeding path length limits.  Alternatively, we could preserve the paths like this:

ArtifactsPath
Actual Path

artifacts\dirs
D:\MyProject\dirs.proj

artifacts\src\dirs
D:\MyProject\src\dirs.proj

artifacts\src\something\dirs
D:\MyProject\src\something\dirs.proj

Does anyone else have a suggestion?

FWIW this is the workaround I'm using now. It's clearly not quite right for general inclusion because it makes some assumptions, but it may be helpful. It uses the nested directory approach.
<Project>
  <PropertyGroup>
    <!-- Put all artifacts beneath /artifacts instead of project bin/obj directories -->
    <ArtifactsPath Condition=" '$(ArtifactsPath)' == '' ">$(MSBuildThisFileDirectory)artifacts\</ArtifactsPath>
  </PropertyGroup>

  <!-- Avoid conflicts with dirs.proj having the same name -->
  <PropertyGroup Condition=" '$(MSBuildProjectFile)' == 'dirs.proj' ">
    <_TraversalProjectRelativeToRoot>$([MSBuild]::MakeRelative('$(MSBuildThisFileDirectory)', '$(MSBuildProjectDirectory)'))</_TraversalProjectRelativeToRoot>
    <ArtifactsProjectName>dirs\$(_TraversalProjectRelativeToRoot)</ArtifactsProjectName>
  </PropertyGroup>
</Project>


D.VA and Zarya Colors change when using HSV (Overwatch)

What are you experiencing an issue with?

[ ] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[x] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[x] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
The colors should stay Pink as they do when you use the "Linear" color enhancement
Actual behavior:
They change to a red-ish
How often does this problem occur?
Everytime you use the HSV enhancement
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Open Aurora
Open Overwatch
Use HSV color enhancement
Choose D.VA or Zarya ingame

What is the version of Aurora you are experiencing this issue with?

My version is 0.6.1 dev 3
Does the previous version of Aurora have this issue?
I'm afraid so

Can confirm this. It's annoying because you can only get reaper and doomfist to even display at all with hsv

Up

I will look into this

Issue fixed through PR #766. Thanks @LukasACH! The fix will be available in the next release


Another error msg (may be duplicate)

This was from my attempts to save/open a Meerk40T file and working on the "sample" file
MeerK40t crash log. Version: 0.6.17
Please report to: https://github.com/meerk40t/meerk40t/issues
Traceback (most recent call last):
File "xml\etree\ElementTree.py", line 1080, in _escape_attrib
TypeError: argument of type 'float' is not iterable
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "wxMeerK40t.py", line 1360, in on_click_save
File "wxMeerK40t.py", line 1373, in on_click_save_as
File "Kernel.py", line 2259, in save
File "Kernel.py", line 1374, in save
File "DefaultModules.py", line 125, in save
File "xml\etree\ElementTree.py", line 777, in write
File "xml\etree\ElementTree.py", line 942, in _serialize_xml
File "xml\etree\ElementTree.py", line 934, in _serialize_xml
File "xml\etree\ElementTree.py", line 1103, in _escape_attrib
File "xml\etree\ElementTree.py", line 1058, in _raise_serialization_error
TypeError: cannot serialize 0.23137254901960785 (type float)

What are you doing? I cannot duplicate these crashes but failure to write that would absolutely also break during the write... That would produce files that could not be loaded since they would not work that way either.
It looks like something that is supposed to be an attribute or a series of attributes but is really just a floating point number and thus cannot serialize. And thus makes a broken file that cannot load. What data is going into this file?

Hm. Apparently it should be a string and is a float. I'll double check. Seems legit.

Here is my test file from Inkscape
I loaded it into Meerk40T, and tried to edit something and then do a save and got the error msg shown
MeerK40t-2021-02-05_21_19_47.txt
New Material test.zip

Yeah, that proves the fix I made fixed it. This causes #331 since the save file it will make is broken. Which is why that crash happens.

The 0.6.18 version should correct this issue. The corrupted files won't be openable still because they are broken. But, this also prevents #331 accordingly.


F5 refactor

the answers may not match the solutions; even if they do, a different choice of substitution would get a different answer anyway.

Have students find the implicit solution for each.

Or maybe just remove the separable ODE from the prompt and instead say "show both can be rewritten as the same separable ODE".


Updates SPM install instructions to use Moya 9

I tried to find a way to not have to specify a version at all, but couldn't find anything in SPM docs (or even in the codebase). 🤔

Codecov Report

Merging #1264 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1264   +/-   ##
======================================
  Coverage      83%     83%
======================================
  Files          24      24
  Lines         753     753
======================================
  Hits          625     625
  Misses        128     128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd6ef7...ea84ca7. Read the comment docs.


ScrollToEnd does not scroll to end when using WordWrap

My AvalonEdit has to show the content of a log file. Changes to the log file will be attached automatically with AppendText(). Afterwards the editor should scroll to the end of the document. But it does not. A few lines (the ones after the selected one) are (almost) always missing. See screenshot:

XAML:
<avalonEdit:TextEditor xmlns:avalonEdit="http://icsharpcode.net/sharpdevelop/avalonedit"
  Grid.Row="0"
  Name="LogBox"
  FontFamily="Consolas"
  FontSize="9pt"
  HorizontalScrollBarVisibility="Hidden"
  VerticalScrollBarVisibility="Visible"
  />

Some code:
LogBox.Document.UndoStack.SizeLimit = 0;
LogBox.Options.EnableRectangularSelection = true;
LogBox.Options.EnableVirtualSpace = true;
LogBox.Options.HighlightCurrentLine = true;
LogBox.TextArea.TextView.LineTransformers.Clear();
LogBox.TextArea.TextView.LineTransformers.Add(new CustomDocumentColorizingTransformer());
LogBox.IsReadOnly = true;
LogBox.WordWrap = true;
SearchPanel.Install(LogBox);

LogBox.ScrollToEnd();

I've also tried ScrollToLine() and ScrollToVerticalOffset() but the result stays the same.
The only thing which solves my issue (but is not an option for me) is to set WordWrap to false.
Any suggestions?
Best regards,
Carsten

I have this issue currently as well (ScrollToEnd works for me but is really slow, I'm using ScrollToVerticalOffset).  To elaborate, does this happen when you have lines wrapped (e.g. is the line wrapping causing the issue, that's what triggers the issue for me and I need to leave line wrapping on myself)?

As mentioned before:

The only thing which solves my issue (but is not an option for me) is to set WordWrap to false.

So, yes: Word wrapping causes my issue.

See if this words.  I had it in an inherited class but you get the idea.  It seems to perform as well as ScrollToVerticalOffset and also takes it all the way to the bottom (including wraps).  I haven't tested it extensively but I'm going to.
        /// <summary>
        /// Similar functionality to ScrollToEnd but considerably more efficient.
        /// </summary>
        public void ScrollToLastLine()
        {
            this.ScrollTo(this.LineCount, 0);
        }

Doesn't work for me. Or let's say: It does not work if there are wrapped lines in the view. If there are only "not wrapped" lines in the view, everything's fine.
I just saw the the search has the same issue: The found result may be out of the view if there are wrapped lines in the view. So you have to scroll a view lines to see the result.

Apparantly I spoke too quickly.  The scroll to still seems inefficient with a profile my app.  I finally figured out how to determine if a line is wrapped though (and then can use the vertical offset approach when the last line isn't wrapped).  I inherited from the editor.
Something like this should work:
public bool IsLineWrapped(int lineNumber)
{
    return (this.TextArea.TextView.VisualLines.FirstOrDefault(x => x.FirstDocumentLine.LineNumber == lineNumber)?.TextLines.Count ?? 0) > 1;
}

public int LinesCountWithWrap(int lineNumber)
{
    return this.TextArea.TextView.VisualLines.FirstOrDefault(x => x.FirstDocumentLine.LineNumber == lineNumber)?.TextLines.Count ?? 0;
}

I have an approach that works for me (but doesn't take scrolling into effect).  I put an event on text changing (and then at that point I check for wrapping).  Since this is a scrolling log window kind of thing it's almost always at the bottom anyway and thus gives me the result I want (it isn't foot proof but I works for the constantly incoming data and scrolling to bottom scenario).  I created a bool property and set that when the document text changes.  Then, in my scroll to last line function I can determine if there's wrapping, if there is wrapping, I use the less efficient scroll to bottom (that always works), if there is no wrapping I go to the vertical offset which is more efficient (and works perfect when there is no wrapping).
It still was coming back with no visual lines in some cases, I didn't change the value if that was the case.  It seems like that might be a fail point but so far I let this run through 250,000 plus incoming lines and it's working for me.
/// <summary>
/// Code that should be executed when the text of the document changes.
/// </summary>
private void AvalonTerminal_TextChanged(object sender, EventArgs e)
{
    this.TextArea.TextView.EnsureVisualLines();

    if (this.TextArea.TextView.VisualLinesValid && this.TextArea.TextView.VisualLines.Any())
    {
        foreach (var item in this.TextArea.TextView.VisualLines)
        {
            // If it's more than one line
            if (item.TextLines.Count > 1)
            {
                this.HasVisibleWrappedLines = true;
                return;
            }
        }
    }
    else
    {
        return;
    }

    this.HasVisibleWrappedLines = false;
}

I solved it by calling ScrollToEnd twice.

Here's where I finally fell.  I set a bool property on whether anything is wrapped during the VisualLineConstructionStarting event.  As I was poking and prodding at it seemed to be a place where I could get at the VisualLines when they were valid.  Since my logger is constantly scrolling to the bottom it was pretty accurate for me (even if it ran before the lines updated).  I was able to determine which way to scroll then.  My event looked something like this:
/// <summary>
/// Code to execute when the visual lines begin construction (I think this happens just before).
/// </summary>
/// <param name="sender"></param>
/// <param name="e"></param>
private void TextView_VisualLineConstructionStarting(object sender, ICSharpCode.AvalonEdit.Rendering.VisualLineConstructionStartEventArgs e)
{
    if (this.TextArea.TextView.VisualLinesValid && this.TextArea.TextView.VisualLines.Any())
    {
        foreach (var item in this.TextArea.TextView.VisualLines)
        {
            // If it's more than one line
            if (item.TextLines.Count > 1)
            {
                this.HasVisibleWrappedLines = true;
                return;
            }
        }
    }
    else
    {
        return;
    }

    this.HasVisibleWrappedLines = false;
}

I don't set any value if the lines aren't valid.  I didn't want a false positive or negative.

I solved it by calling ScrollToEnd twice.

I was desperate enough to give it a try but it did not work for me.

So now you have HasVisibleWrappedLines either true or false. What are you doing in either case to scroll to the very bottom? I have tried ScrollToVerticalOffset(), ScrollToEnd() in various combinations without any success, I do not really see how this new variable should help.

This is what I'm using in my mud client:
public void ScrollToLastLine()
{
    if (this.HasVisibleWrappedLines)
    {
        this.ScrollTo(this.LineCount, 0);
    }
    else
    {
        this.ScrollToVerticalOffset(this.TextArea.TextView.GetVisualTopByDocumentLine(this.LineCount));
    }
}


Upgrade linter - fix found issues - use go1.20

Changes are looking good to me, but I think we should also bump the version in the go.mod file since we are not testing 1.18 anymore.

Hmm .. i did that, not sure why it's not in the commit, let me push again :-)

/approve


Workflow fully supported

Codecov Report

Merging #330 (4e966a2) into main (0975ae5) will increase coverage by 0.26%.
The diff coverage is 98.42%.

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   97.03%   97.29%   +0.26%
==========================================
  Files          57       55       -2
  Lines        3238     3185      -53
==========================================
- Hits         3142     3099      -43
+ Misses         60       51       -9
+ Partials       36       35       -1

Impacted Files
Coverage Δ

client/dtmcli/barrier_mongo.go
97.14% <ø> (ø)

client/dtmcli/barrier_redis.go
100.00% <ø> (ø)

client/dtmcli/dtmimp/db_special.go
100.00% <ø> (ø)

client/dtmcli/dtmimp/trans_base.go
92.40% <ø> (ø)

client/dtmcli/dtmimp/vars.go
100.00% <ø> (ø)

client/dtmcli/logger/log.go
96.22% <ø> (ø)

client/dtmcli/trans_saga.go
100.00% <ø> (ø)

client/dtmcli/types.go
100.00% <ø> (ø)

client/dtmgrpc/barrier.go
100.00% <ø> (ø)

client/dtmgrpc/dtmgimp/grpc_clients.go
100.00% <ø> (ø)

... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0975ae5...4e966a2. Read the comment docs.


EOF error

I use shadowsocks-go server version 1.1.5.
My server cannot connect these days. The error log as following:
##############
20:22:48 server listening port 8390 ...
08:02:46 creating cipher for port: 8390
08:02:46 error getting request <IP_ADDRESS>:49861 xxxxxxxxx:8390 addr type 0 not supported
01:12:14 error getting request <IP_ADDRESS>:59729 xxxxxxxxx:8390 EOF
##############
For my privacy, I use 'xxxxxxxxx' to hidden my serer IP.

I have the same error info， hope to resolve

same issue here, have no idea


allow non-roundrobin manner of mesos scheduling

What changes were proposed in this pull request?
Added an option to not assign tasks in round robin manner to mesos workers.
How was this patch tested?
Added a unit test

test build: http://aws-mgmt-jenkins-master.metamx-mgmt.com:8080/job/spark-test/66/

I'm just wondering are we going to push this changes to apache/spark repo?


Healthcheck fail. Different tests fail, but failures are caused by Cilium health check not passing.

https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/10118/testReport/junit/Suite-k8s-1/11/K8sDatapathConfig_Transparent_encryption_DirectRouting_Check_connectivity_with_transparent_encryption_and_direct_routing/
https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/10109/testReport/junit/Suite-k8s-1/17/K8sDatapathConfig_ManagedEtcd_Check_connectivity_with_managed_etcd/
https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/10108/testReport/junit/Suite-k8s-1/11/K8sDatapathConfig_Transparent_encryption_DirectRouting_Check_connectivity_with_transparent_encryption_and_direct_routing/
https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/10103/testReport/junit/Suite-k8s-1/17/K8sDatapathConfig_ManagedEtcd_Check_connectivity_with_managed_etcd/

Closing as all of the links are dead.
Feel free to reopen and upload zips, copy/paste failure content here for further triage.


/lp editor does not give me any input.

When I do /lp editor all it does it this: https://gyazo.com/3c2b0372756100c9aa904c23c8cc474c
And it gives me this in the console: https://pastebin.com/wA621xkL.
Don't know what to do, I've been searching around and I really haven't found any solution, hope you can help me!

Which version of LuckPerms are you running?

I am using LuckPerms for Bukkit/Spiggot v 4.4.31

The console extract isn't the full error - I think you missed a line (the most important one!)
I'm guessing it's something to do with your servers network connection to the web editor host.


Allow for update in config.

Allow for an update in config and CLI to include --update-only flag to figure out the delta and only make those changes to dimensions, datasets, and event definitions. Same with datasets.
Make config.json act like git or prisma migrations //details this out

This issue has been implemented as a part of the upsertion POC.


Upgrade deps & migrate to ESM

Unified has moved to ESM. As a result, this PR updates all major packages and adds in ESM support to the package
This is a breaking change and should bump the major version of the package. It's encouraged to link something like this in a changelog so others know what to change
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
My follow-up PR will be to add TS typings

@blahah any chance at getting this merged? :)


[2025H1] Propose a null and alignment checks goal

Rendered
cc: @tmandry, @RalfJung, @rcvalle

This mostly already exists? @saethlin added alignment checks in debug builds.

Oh I didn't see that! I could pivot this goal to something different in the area? E.g. around pointer arithmetics or checking enum discriminants?

I would be happy to collaborate on sketching out a coherent story for our hodgepodge of runtime UB checks, but I'm a bit busy this week and next.

I would like to collaborate on this! I send you a message on Zulip to discuss this further.
For this goal: I'd love to pivot it to something helpful regarding runtime checks, so probably update it after having synced with @saethlin.

@1c3t3a ok, I'll hold off on merging until you and @saethlin align on the right description.

I haven't heard anything here, I'm going to close this PR as the initial deadline for goals has passed and I don't think it's ready to merge -- please feel free to re-open once you've got a consensus plan in place (although time IS running out...).

I actually pivoted the proposal here and just uploaded the new version. I was waiting for @saethlin's feedback but I think I can work that in later as well. The new PR is: #177. I hope I am not too late, sorry for the delay!


Add TLS certificates configuration

As part of the Mesh Config, we need to distribute certificates to Envoy proxies.
This can be done using Kubernetes Secrets and envoy.MeshConfig fields that are configurable as flags at start-up time. In the future, MeshConfig will be dynamically updated, but at first cut, we need to get certs loaded statically to Envoy.

What will the certificates be used for?

For SSL context in Envoy to terminate and initiate HTTPS connections (perhaps, for raw TCP as well?)

cc @lookuptable

Since there is a separate auth component, I'm reassigning it to @lookuptable. Please keep us in the loop on HTTPS termination solution.

This is done by Istio CA or by ingress proxy. Unifying the two is delayed to beta.


Update http links

@NextTurn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @NextTurn - thanks for taking the time to submit this PR.
Dominic
#sign-off


Audio file recognition does not respond for a long time

Use startContinuousRecognitionAsync() to start recognition, but some audio only recognizes a segment, and then no notification will be given. After ten minutes, there will be an exception notification. What can we do to make the notification respond faster? The following is log.
2019-02-28 16:31:35.587 724-1151/ I/System.out: RECOGNIZING: Text=今天是我不是
2019-02-28 16:31:35.681 724-1151/ I/System.out: RECOGNIZING: Text=今天是
2019-02-28 16:31:35.683 724-1151/ I/System.out: RECOGNIZING: Text=今天是我不是
2019-02-28 16:33:01.398 724-752/E/CellLocation: create GsmCellLocation
2019-02-28 16:33:01.414 724-752/E/CellLocation: create GsmCellLocation
2019-02-28 16:33:41.292 724-760/ I/System.out: close [socket][/<IP_ADDRESS>:45776]
2019-02-28 16:36:29.839 724-761/ I/System.out: close [socket][/<IP_ADDRESS>:56948]
2019-02-28 16:36:29.839 724-761/ D/FlymeTrafficTracking: untag(55) com.transn.onemini OkHttp ConnectionPool uid 10326 316596ms
2019-02-28 16:37:00.128 724-788/ D/libc-netbsd: getaddrinfo: c.data.mob.com get result from proxy gai_error = 0
2019-02-28 16:37:00.128 724-788/ D/FlymeTrafficTracking: tag  (55) com.transn.onemini Thread-27 uid 10326
2019-02-28 16:37:00.129 724-788/ I/System.out: [socket][8] connection c.data.mob.com/<IP_ADDRESS>:80;LocalPort=-1(30000)
2019-02-28 16:37:00.152 724-788/ I/System.out: [socket][/<IP_ADDRESS>:45785] connected
2019-02-28 16:37:00.542 724-788/ D/FlymeTrafficTracking: untag(55) com.transn.onemini Thread-27 uid 10326 413ms
2019-02-28 16:37:43.478 724-752/ E/CellLocation: create GsmCellLocation
2019-02-28 16:37:43.490 724-752/ E/CellLocation: create GsmCellLocation
2019-02-28 16:38:19.112 724-729/I/art: Do full code cache collection, code=203KB, data=252KB
2019-02-28 16:38:19.114 724-729/ I/art: After code cache collection, code=186KB, data=208KB
2019-02-28 16:38:41.476 724-788/ D/FlymeTrafficTracking: tag  (55) com.transn.onemini Thread-27 uid 10326
2019-02-28 16:38:41.536 724-788/ D/FlymeTrafficTracking: untag(55) com.transn.onemini Thread-27 uid 10326 60ms
2019-02-28 16:42:08.616 724-752/ E/CellLocation: create GsmCellLocation
2019-02-28 16:42:08.632 724-752/ E/CellLocation: create GsmCellLocation
2019-02-28 16:43:33.066 724-1151/ I/System.out: CANCELED: Reason=Error
2019-02-28 16:43:33.067 724-1151/ I/System.out: CANCELED: ErrorDetails=Connection was closed by the remote host. Error code: 1000. Error details: Idle timeout
2019-02-28 16:43:33.067 724-1151/I/System.out: CANCELED: Did you update the subscription info?

What version of the SDK?
Do you keep transmitting audio to the service?

I use the 1.3.1 version of SDK   I don't know if I've been transmitting audio to the server all the time.
I just use it.
AudioConfig audioInput = AudioConfig. fromWavFileInput (filePath);
AudioFileRecognizer. startContinuous Recognition Async ()
Then wait for notification

I think you may need to stop recognition when the whole file has been recognized. You can do it by subscribe to the Canceled event, and check if the CancellationReason is EndOfStream, then you can stop the recognition. There is sample in C# showing how to do that, and I hope it could be helpful. Another option if that if you know when the recognition should end (e..g press a button), you can stop the recognition at the time you feel appropriate. This is what we show in the Java sample.
Thanks,
Zhou

I have subscribed to the Canceled event， But sometimes Canceled event it takes ten minutes to call back.

When did you get all the result via Recognized event? Could you please send us the SessionId and the time if you see that Canceled event is triggered much later than the last Recognized result, so that we can investigate.

2019-03-01 15:43:21.231 26978-27665 I/System.out: CANCELED:sessionId=F93E7786258B2FF494B7E863EA7B0F5C
2019-03-01 15:43:21.231 26978-27665 I/System.out: CANCELED: Reason=Error
2019-03-01 15:43:21.231 26978-27665 I/System.out: CANCELED: ErrorDetails=Connection was closed by the remote host. Error code: 1000. Error details: Idle timeout
2019-03-01 15:43:21.231 26978-27665 I/System.out: CANCELED: Did you update the subscription info?
This is a log of what happened.


not working missing files

every time i try to start it it says its missing file try reinstalling ive reinstalled 4 times still save codes

What file is missing?
Reinstall what?

This issue appears to be the same as #9, I'm merging this issue and marking both as closed with the latest release:
<EMAIL_ADDRESS>

i was wating for you to veiw it sometimes people done ever look at these things i will post them here (the code execution could not proceed because VCRUNTIME40D.dll was not found) (MSVCP40D.dll WAS NOT FOUND) (could not proceed bc ucrtbased.dll was not found) i had tried to run as admin still did not work never went into first time setup

it was the samne issue ty


fix: Improve performance of global dimension search on druid

closes #4983

[x] Add a new endpoint for global dimension search.
[x] Make a native druid query for dimension search.
[x] Use UNION ALL query for non druid olap.
[x] Apply security filter to druid native queries. We are running EXPLAIN PLAN to get a json and pass on the filter object. Right now this will not always work, especially if the security filter is a subquery. We fallback to UNION ALL in this case.

Will do a follow up for making the requests in parallel.

Frontend code looks reasonable. Though the requests in my test are taking 30s+ to resolve. I'll send a JAM privately.
One frontend performance improvement – when closing the Search box, it'd be good to cancel in-flight requests.