Jump to image year on selection

Given the transformations that took place in Rio, sometimes the image seems to be wrongfully positioned if you're on the wrong year. For best UX it would be good to open an image with the appropriate basemap, and let the user mess with the timeline later if he/she so wishes.


Search bar: Mobile view hidden

Want to create a hamburger.

Hey, can i work on this issue

Hello @HarshKumarraghav, What type of Hamburger Menu and Exactly where in your design?
I can help with that

hey, @fallen-ecstasy I have shared a basic sketch below for you to you can understand what I want.

hey, @fallen-ecstasy I have shared a basic sketch below for you to you can understand what I want.

Okay, on it 👍🏻

hey, @fallen-ecstasy I have shared a basic sketch below for you to you can understand what I want.

Okay, on it 👍🏻

so due you get the issue, should I assign this issue to you?

Is this issue still not assigned? I am interested for working on it

Hey There! Would Love To Work On This Issue. Kindly Assign It To Me @HarshKumarraghav

Is this issue still not assigned? I am interested for working on it

ok, @psankhe28 I'm assigning this issue to you.

Hi, @psankhe28 are you working on this part do you have any update.

@HarshKumarraghav if there is no one working on this kindly assign this to me I will fix this asap.

Hi, @MananAgr2003  @psankhe28  is working on that she confirmed It.

@HarshKumarraghav if there is no one working on this kindly assign this to me I will fix this asap.

I am working on the contact us page, so If you are willing to work on that, I can create an issue.

@HarshKumarraghav if there is no one working on this kindly assign this to me I will fix this asap.

ok, @MananAgr2003 I'm assigning this task to you.

@HarshKumarraghav is this issue still open, i would like to work on this


fix: Paginator UI doesn't always update when used with a DataGrid and an async ItemProvider

🐛 Bug Report
The Paginator UI doesn't update correctly if a DataGrid uses an ItemProvider with async calls where the result should update the current page index to the new last page index.
💻 Repro or Code Sample
The Sample is a DataGrid with a Paginator that shows 10 pages.
Via the search box above the grid you can directly update the total page count of the data grid in the item provider result.
Steps to repro:

Navigate to page 5 on the Paginator
In the search box enter 4 and hit enter

@page "/"

<PageTitle>Paginator UI Bug</PageTitle>

<FluentSearch @bind-Value="totalCount"></FluentSearch>
<FluentDataGrid ItemsProvider="LoadData"
                TGridItem="GridItem"
                Pagination="@pagination">
    <PropertyColumn Property="@(x => x.Value)"></PropertyColumn>
</FluentDataGrid>
<FluentPaginator State="@pagination"></FluentPaginator>

@code
{
    readonly PaginationState pagination = new() { ItemsPerPage = 1 };
    string totalCount = "10";

    private async ValueTask<GridItemsProviderResult<GridItem>> LoadData(GridItemsProviderRequest<GridItem> request)
    {
        if (!int.TryParse(totalCount, out var count))
        {
            count = 10;
        }

        await Task.Delay(100);

        return GridItemsProviderResult.From([new GridItem("hello")], count);

    }

    record GridItem(string Value);

}

🤔 Expected Behavior
I would expect that the Paginator displays the new state e.g. "4 of 4" when the current page index is greater than the last page index.
😯 Current Behavior
The Paginator still displays "5 of 10" and didn't update its UI.

It seems the state is correct under the hood because after navigating to the previous page the UI updates to "3 of 4".

If you repeat the described example without any async calls then it works as expected.
💁 Possible Solution
I didn't find or understand the cause for this issue. :(
🔦 Context
The issue breaks the UI and could confuse users. It is also possible in some circumstances that you are allowed to navigate to page 0 because of the broken UI, which may produce additional errors.
🌍 Your Environment

OS & Device: Windows 10 on PC
Browser Microsoft Edge and Chrome
.NET and FAST Version: .NET8

This seems t be a rather niche case. I dont think you should manipultate the pagecount like that. The component calculates the number based ion the data provided and your code is interfering with that, If you absoutelty want to do it async, I suggest you take a look at the PaginationState.SetCurrentPageIndexAsync method.
Colsing this as the effect of this is small

Sorry, it seems I didn't formulate my use case well. Maybe there is a misunderstanding.
I only manipulate the count result in the repro to simulate a asynchronous query to a remote data source that queries the data for the current page where a filter may return less items so my current page wouldn't be valid anymore. My comprehension is that the PaginationState handles this and sets the current page to the last page.
For example I have 18 books and I want to display 10 books per page.

The first query takes 10 books and skips 0. The result are the first 10 books and a total count of 18.
Now I navigate to page 2. The item provider now executes a query which skips 10 books and take the next 10 books. The result are 8 books and a total count of 18.
Now I enter a search for "Orwell". The item provider executes a query which applies the filter skips 10 take 10. The result now is 0 Books and a total count of 1.
The pagination state gets updated and handles the case that the current page index (1) is greater than the last page index (0 because only 1 books satifies the filter). As a result the current page index gets updated to the new last page index.
This results in another query from the item provider which now still applies the filter, skips 0 and take 10. The result is 1 book with the total count of 1.
The paginator UI doesn't reflect the current state. Only after the next UI update the paginator displays the correct state again.

A workaround was to set pagination state to a current page of 0 when triggering a search. But a caveat with this solution seems to be that I trigger an additional request because of setting the current page in addition to the requests described above.
Nonetheless, if it wasn't a misunderstanding I am sorry and thank you for your work and time.


Create & Discuss Design Doc for Peggy V3

The operator roles have an inordinate amount of power in this system. What are the current proposals for further decentralization and security of Peggy?

Using another oralce for validator sets and weights?
Including validator sets and weights with every claim to keep them self updated?
Threshold signatures of claims that can be collected off chain and verified on chain?

@okwme What are the actionables here? Is the next step perhaps a separate design document?

I think that's a good idea. I'd keep this issue open for the design doc to be posted and discussed as well as alternative ideas / designs.

@cwgoes It would be great to get your feedback on the latest cryptoeconomic spec doc I emailed you in relation to this.
The original plan for decentralization of this bridge was to make the "bridge owner" the set of Peggy validators rather than a single entity.  I still think this is the best approach for our architecture

I'd like to collaborate here too


Bump default to 180 minutes (3 hours)

Along with the scanner update this Fixes #468
Signed-off-by: Chuck Ha<EMAIL_ADDRESS>Release note:
The default timeout increases to 3 hours

/lgtm


React Components for Confirm Action Screens

We need to be able to launch the Confirm Action dialog in the extension to display user components.
Since many other projects here are react it makes sense to me to do it.
As far as design framework I am down with tailwind, @GuiDeMa is that the best choice here?

I like tailwind but people are very opinionated about design frameworks in general. I can help you with these UI components


adding troubleshooting for agent install

@asgang,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@asgang : Thanks for your contribution to the Azure documentation! The author, @v-bllydi, has been notified to review your proposed change.

@asgang. As team member, please close this PR and submit changes to articles thru azure-docs-pr

#please-close


Refactor lifecycle of root build task graph for consistency

Fixes #?
Context
Some restructuring so that the task graphs of the main build and included builds are created, populated and executed the same way. This removes some more artificial differences between the builds in a tree and simplifies some later fixes for parallel execution.
Introduces a type that represents a set of tasks and work to be executed across the build tree and allows multiple instances of this to be created, populated and executed, for example to allow plugins to be built while calculating the task graph of the main build. This was already possible, but this is more explicitly modelled now.
Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.


Screen Saver Page Error

When i try to click on the screen saver tab it displays, "error loading page".

When i try to click on the screen saver tab it displays, "error loading page".

You need to do a full install. The web pages are on the filing system, not in the firmware.


Make renameLabels a toggleable transform (like renameVariables)

Is your feature request related to a problem? Please describe.
RenameLabels is a default transform applied every time, however there are cases where this could be unwanted.
Such as scripts with already minified & renamed labels, which contain a huge amount of said labels.
The current implementation takes over 60 seconds to rename labels for my custom 2MB script!
Describe the solution you'd like
Make renameLabels into a configurable transform.
Describe alternatives you've considered
Reducing the amount of labels in the script, however this isn't convinient

Hmm. What about the obfuscation time for Preparation ? Because they both do something similar:

Preparation assigns a placeholder label to every non-labeled control-flow structure
RenameLabels changes all labels to randomized names, and removes unused labels

I will try to optimize RenameLabels and if not, an option will be added to disable it. I just don't want this to end up breaking other transformations because some of them rely on labels to accurately read/change the AST.
If you could provide a sample that would help too.

Hey, I've disabled renameLabels manually on a script with 1k+ labels, causing zero issues (with all high preset transforms enabled),
so I'm led to believe it won't end up breaking other transformations.
Unfortunately my script is propiretary, therefore I'm not allowed to share it publicly, however I will try to write a similar script to showcase the large amount of time the afformentioned transform takes.

Added in 2.0. (Currently 2.0.0-alpha.2)
https://new--confuser.netlify.app/docs/options/renamelabels#rename-labels


Schrodinger's Container: A file both exists and doesn't

$ docker version
Client:
 Version:      1.12.0-rc4
 API version:  1.23
 Go version:   go1.6.2
 Git commit:   e4a0dbc
 Built:        Wed Jul 13 03:28:51 2016
 OS/Arch:      darwin/amd64
 Experimental: true

Server:
 Version:      1.11.2
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   b9f10c9
 Built:        Wed Jun  1 21:20:08 2016
 OS/Arch:      linux/amd64

$ docker info
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 3
Server Version: 1.11.2
Storage Driver: aufs
 Root Dir: /mnt/sda1/var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 32
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge null host
Swarm:
 NodeID:
 IsManager: No
Security Options:
Kernel Version: 4.4.12-boot2docker
Operating System: Boot2Docker 1.11.2 (TCL 7.1); HEAD : a6645c3 - Wed Jun  1 22:59:51 UTC 2016
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 995.9 MiB
Name: boot2docker
ID: T2PN:ZJO3:232C:5XD3:QDIR:DZJZ:VVPV:EHD4:XSVQ:ZLSK:NTY4:63GR
Docker Root Dir: /mnt/sda1/var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 23
 Goroutines: 40
 System Time: 2016-07-17T18:20:18.753688777Z
 EventsListeners: 0
Registry: https://index.docker.io/v1/
Labels:
 provider=xhyve
Insecure Registries:
 <IP_ADDRESS>/8

$ cat Dockerfile
FROM python:2.7

# Add the dockerproject repo
RUN apt-get update -y && \
    apt-get install -y apt-transport-https ca-certificates && \
    echo "deb https://apt.dockerproject.org/repo debian-jessie main">/etc/apt/sources.list.d/docker.list && \
    apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D && \
    apt-get update -y && \
    apt-get install -y python-setuptools git python-pip docker-engine && \
    apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

ADD builder.sh /usr/local/bin/builder.sh
RUN pip install -q --no-cache-dir 'ansible==<IP_ADDRESS>'

$ cat docker-compose.yml
ansible-container:
  image: "sha256:cf6161c67baec3d4e75c472f51175a7d5b9eb26b25530374e5efe70d582ef9ab"
  command: /usr/local/bin/builder.sh /usr/local/bin/ansible-playbook -i /tmp/working/hosts -c docker  --list-hosts main.yml
  environment:
    - DOCKER_HOST
    - DOCKER_TLS_VERIFY
    - DOCKER_CERT_PATH=/docker-certs/
    - COMPOSE_HTTP_TIMEOUT=3000
    - DOCKER_API_VERSION=1.23
  volumes:
    - $DOCKER_CERT_PATH:/docker-certs/
    - /Users/jginsberg/Development/ansible/ansible-container/example:/ansible-container/
    - /var/folders/wg/d5z1m_tn7d31p142wgc800tw0000gp/T/tmpvUCVPU:/tmp/working/
  working_dir: /ansible-container/ansible/
  stdin_open: true
  tty: true

The head-slamming-against-desk whiskey tango foxtrot:
$ docker-compose up
ERROR: for ansible-container  Container command '/usr/local/bin/builder.sh' not found or does not exist.
$ docker images
REPOSITORY                  TAG                 IMAGE ID            CREATED             SIZE
ansible-container-builder   latest              cf6161c67bae        22 seconds ago      839.3 MB
python                      2.7                 a047e3d0ae2b        5 weeks ago         688.1 MB
$ docker ps -a
CONTAINER ID        IMAGE               COMMAND                  CREATED              STATUS              PORTS               NAMES
5b74e8e9f99d        cf6161c67bae        "/usr/local/bin/build"   About a minute ago   Created                                 ansible_ansible-container_1
$ docker run --rm -it cf6161c67bae /usr/local/bin/builder.sh ls -l /usr/local/bin/builder.sh
-rwxr-xr-x 1 root root 115 Jul 14 15:52 /usr/local/bin/builder.sh
$ docker run --rm -it cf6161c67bae /usr/local/bin/builder.sh cat /usr/local/bin/builder.sh
#!/bin/bash

# test '(! -f /src/requirements.txt)' || pip install --no-cache-dir -q -U -r /src/requirements.txt
$@

How can builder.sh both exist and not exist?

Even more fun. If in my docker-compose.yml I change the command to /bin/bash, I get:
ERROR: for ansible-container  Container command '/bin/bash' not found or does not exist.

I can't even...
$ docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
620f5ca52905        7fdfaee09d2a        "/bin/bash"         4 minutes ago       Created                                 ansible_ansible-container_1
$ docker start 620f5ca52905
Error response from daemon: Container command '/bin/bash' not found or does not exist.
Error: failed to start containers: 620f5ca52905

The Container command ... not found or does not exist. could be a false positive, as it's also output if there's something wrong with the script (see, for example, https://github.com/docker/docker/issues/20789, https://github.com/docker/docker/issues/23411, and https://github.com/docker/docker/issues/23571)
Docker 1.12 contains a change to give a better error message, and was merged in https://github.com/docker/docker/pull/22983/files#diff-3cb140026df40998ea29c5bcb6bb292eR150
Can you try if this is resolved in the 1.12 release candidates? https://github.com/docker/docker/releases (at least, if it returns an error message that may explain what the issue is?)

builder.sh not being able to be executed will also happen if /bin/bash is not found, so it is kind of the same issue. But I am not sure how bash is being uninstalled...

@j00bar not necessarily, wouldn't they be using /bin/sh which is not bash in Debian, it is ash.

Beware: you can get erroneous messages like the one you have if the script is saved in dos format: the line endings  will cause the #!/bin/bash to fail.

Version wrangling on my laptop between Docker for Mac and Docker Toolbox. I can say this does not happen on 0.11 Toolbox. Trying out other versions...

I guess this is a duplicate of https://github.com/moby/moby/issues/29420. Let me close this one.


Are pretrained model damaged?

try to extract pretrained model in Windows 10, it shows the error message above.
Thanks

@bill2239
You do not need to unzip these .tar files and can directly load them by torch.load().

got it Thanks


build deps should respect skip-recommended

For example, brew deps libass --skip-recommended shouldn't print
harfbuzz because, even though libass builds with harfbuzz when harfbuzz
is not skipped, we asked to skip recommended, of which harfbuzz is one.

Actually, now after some thought, I think current existing behavior is correct. brew uses/deps sort of behaves like brew reinstall/upgrade. So the current installation should be taken into the account. For example, if I brew install foo --with-optional-bar. brew deps foo should still return bar, even when the default is to filter optional deps.

That would mean --skip-recommended basically does nothing unless it's :run.

Perhaps we need to revert to the old behavior that had it in the reverse, --skip-optional and --include-recommended because --skip-recommended isn't useful right now, if you're saying the behavior is actually correct.

To be more clearly, local installation should be treated with higher priority than --skip/include flags. The latter is used more often to determine deps before you install it.

As far as I can tell the existing logic has nothing to do with local installation.

Look at output of brew deps libass --skip-recommended and look at the libass formula, and tell me that makes sense!

because --skip-recommended isn't useful right now'

It can be useful if you want to do: brew install $(brew --skip-recommended foo); brew install foo --without-recommended-deps

As far as I can tell the existing logic has nothing to do with local installation.

The dependant.build will check local installation.

I'm looking locally at the command output in the absence of having these formulae installed. I thought brew deps and brew uses were currently supposed to be stateless commands having nothing to do with the user's local Cellar and that the output should match between systems.

I thought brew deps and brew uses were currently supposed to be stateless commands having nothing to do with the user's local Cellar and that the output should match between systems.

That may not be the case but I agree it should be.

Sorry, I made a mistake here. You are right that the existing logic won't check for local installation. What will check is the flag declared in formula. e.g. depends_on: foo => [with-bar, without-baz]. In this case, the build flags(declared by formula authors) should be still considered with higher priority than user's input flag.

  depends_on "pkg-config" => :build
  depends_on "yasm" => :build

  depends_on "freetype"
  depends_on "fribidi"
  depends_on "harfbuzz" => :recommended
  depends_on "fontconfig" => :optional

iMac-TMP:~ joe$ brew deps --skip-recommended libass
cairo
fontconfig
freetype
fribidi
gettext
glib
gobject-introspection
harfbuzz
icu4c
libffi
libpng
pixman
pkg-config

I think the problem is because we don't take into account whether a filter(include or skip) is enforced by users or enforced by Homebrew's default behavior.
What should happen should be this:
skip if user explicitly passes --skip- flag
keep if user explicitly passes --include- flag
keep if the defendant should be built with it (declared by formula)
skip if it's optional (default behavior)
keep if it's recommended (default behavior)

En, this question is not very straight forward. I probably need to take more time to figure this out the correct behaviors.

The output with various combinations of the flags made sense to me with the "build veto" removed but take your time thinking about it.

After some thought, I think this may be what we want.
f.recursive_dependencies do |dependent, dep| do
  if dep.build?
    Dependency.prune unless ARGV.include? "--include-build"
  elsif dep.recommended?
    Dependency.prune if ARGV.include?("--skip-recommended") || dependent.build.without?(dep)
  elsif dep.optional?
    Dependency.prune if !ARGV.include?("--include-optional") && !dependent.build.with?(dep)
  end
end

@xu-cheng what does it do in case of :run / dep.run??

dep.run? has nothing to do with this. As it's used only as a tag for brew audit or bottle system.

@xu-cheng That looks right to me.

@ilovezfs Any news here?

@mikemcquaid @xu-cheng OK, I refreshed the PR with @xu-cheng's proposal. There are still some weird results, though. --include-optional seems to get extended recursively. So brew deps lnav gives you pcre and readline, with no mention of curl because
depends_on "curl" => ["with-libssh2", :optional]

OK, that makes sense. So let's say we want to see that curl show up, and make sure it's using with-libssh2.
brew deps --include-optional lnav

which now drags in all of curl's optional dependencies as well, yielding;
$ brew deps lnav --include-optional
atk
berkeley-db4
boost
c-ares
cairo
curl
doxygen
fontconfig
freetype
gdbm
gdk-pixbuf
gettext
glib
gobject-introspection
graphite2
graphviz
gsettings-desktop-schemas
gtk+3
gts
harfbuzz
hicolor-icon-theme
homebrew/dupes/tcl-tk
icu4c
jansson
jasper
jpeg
libcroco
libepoxy
libev
libevent
libffi
libgsf
libidn
libmetalink
libpng
libressl
librsvg
libssh2
libtiff
libxml2
netpbm
nghttp2
openssl
pango
pcre
pixman
pkg-config
python
readline
rtmpdump
spdylay
sqlite

This isn't a regression caused by this PR, but I do think we need to reconsider not showing first level optional by default since the output of --include-optional is now pretty over the top, and passing -1 will hide the libssh2 altogether.

There are still some weird results, though. --include-optional seems to get extended recursively.

How are you proposing to resolve this issue? I'd find it weird and hard to understand if --include-optional only applied to the immediate dependencies. And if we added a new option like --include-optional-for=<formula1>,<formula2>,…, our already hard to grasp brew deps with all its options would become even more complicated. And we'd need to do something similar for --include-build and --skip-recommended.
I'd say the list brew deps returns is more useful for consumption by scripts and only really simple queries by humans. For more complicated cases like the one you sketched, a human would need to look at the dependency tree (or graph), thus I'd suggest to improve deps --tree for this. It's functionality is currently very limited, but it shouldn't be too difficult to make it output a tree where build, optional, recommended, and hard dependencies are all printed together, but are still distinguishable. This form of visualization is also much better suited for adding something like --max-levels=<n> where the tree would be truncated at depth <n>, but leaves that haven't been fully expanded could be annotated as such.

Something that does this (but with deps command, I'd think):
iMac-TMP:local joe$ brew install --with-curl lnav
readline
pcre
pkg-config
openssl
libssh2
curl
Error: OK

which is generated using
diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb
index 4b8dcf2..f93a1e6 100644
--- a/Library/Homebrew/formula_installer.rb
+++ b/Library/Homebrew/formula_installer.rb
@@ -268,6 +268,8 @@ class FormulaInstaller
     check_requirements(req_map)
     deps = expand_dependencies(req_deps + formula.deps)

+    puts deps
+raise "OK"
     deps
   end

@@ -354,8 +356,8 @@ class FormulaInstaller
         Dependency.prune
       elsif dep.build? && install_bottle_for?(dependent, build)
         Dependency.prune
-      elsif dep.satisfied?(options)
-        Dependency.skip
+#      elsif dep.satisfied?(options)
+#        Dependency.skip
       end
     end

Bump.

I think the PR as-is is fine and good to go.
The discussion about how to make the output of --include-optional more useful with extensive dependency trees like in the lnav case probably needs to continue somewhere else. (I still believe that brew deps --tree can be more useful in this case, if it is extended a bit to respect the --include-* and --skip-* options and to annotate its output with “optional” etc.)

@UniqMartin on a related note to the formula-specific-options thing, it occurred to me the other day that it's related to the same usage attempted here for nearly the same purposes https://github.com/Homebrew/legacy-homebrew/issues/48986#issuecomment-215114587

Perhaps despite the redundancy, the formula specific options thing might be more trivially added to brew install as demonstrated above. Effectively, that's a brew install --dry-run for the sake of spitting out the dependencies that will actually be used, modulo whether to include or to exclude what's already satisfied on a given system.

A brew install --dry-run (or some other command that has the same effect) makes sense to me. In the end, all of this just shows that our dependency handling and dependency resolution isn't as flexible and as hackable as it could be. I'm not sure at which point it is preferable to reimplement it from scratch (and with a proper design phase preceding it) instead of just tweaking various commands that try to use it. But this is certainly not an easy task to tackle …

I think the --dry-run thing for install helps to distinguish between the questions that each command is trying to answer. brew deps is context free, describing the tree of dependencies and requirements from a universal perspective. But I think often the user is trying to answer a very context specific question: if I install foo with a given option set what specific set of deps/reqs is both necessary and sufficient to accomplish that task, and what subset do I not have already. I think part of the problem with deps is that it's not really designed to answer that context specific question. Sure it can be, if you sit there and reason through the tree and pick the right command line switches, and consult a graph theory text book, and meditate for a while, and then intersect that with your Cellar being careful to track what's already satisifed, etc. etc., but it's a silly enterprise if brew install already knows the exact answer to the context specific question without any other fuss.

@xu-cheng :shipit: ?

👍

Not super happy with the commit subject, but I guess that ship has sailed. I think we prefer something more along the lines of deps: respect --skip-recommended.

It was specifically build.with? deps that were overriding everything else in case that wasn't clear that that's the meaning of "build" in the commit subject.

Yes, I realize that my example was poorly chosen. I was more referring to the style and not to the exact contents of my example. Anyway, it has been committed … so that's idle talk.


Mock PA2 Level 5 Sub NaN : 8 issue

Hi all, getting the Nan : 8 issue in my sub method.

Not too sure how I can use .filter(isValid()??) or even use the AbstractNum.valid method. A little confused because I thought the optional passed into my Of method would have cleared the isValid() check? Why would I need to do another round of valid checks?

your sub method uses a different constructor with, Frac.of(Num, Num) instead of Fraction.of(int, int)

i did the filter within my sub class as it is the only function that might produce an invalid result despite having 2 valid inputs. what i did was i filtered the output fraction to check if the numerator is a valid input, then returned that result

if you want to filter here, you should create a new predicate for when num can be a denominator, but a better idea is to probably filter in the sub class instead

i think a simple fix is to just use an if-else in your sub method.
If the resulting numerator is valid, return what you have, else return new Fraction(Optional.empty())

to add on from @MaverickWongKeJun, it will be to add filter() after map() from other.opt. This will valid check the new Frac and will auto return Optional.empty() if it fails the valid, else it will return Optional with the new Frac inside

I think its becuase in your sub function, you're generating a new Fraction using your private constructor Fraction(Optional) and not the function Fraction.of() so it doesn't filter the optional. What you could do is filter the optional again before finally returning the new Fraction.

check for the validiity again otherwise return opt empty

Hi everyone, thanks for the help! I'll post what I did to fix it here in case anyone else faces the same issue.

@kaiju10 also advised to add a .filter() to check validity of only the numerator. since only numerator undergoes the sub function defined earlier, and could be negative.


🐛 BUG: wrangler init --from-dash doesn't work with pnpm

Which Cloudflare product(s) does this pertain to?
C3
What version(s) of the tool(s) are you using?
<EMAIL_ADDRESS><EMAIL_ADDRESS>What version of Node are you using?
18.17.1
What operating system are you using?
Mac
Describe the Bug
Using<EMAIL_ADDRESS>pnpm dlx wrangler init --from-dash some-worker fails, although npx wrangler init --from-dash some-worker succeeds. This seems to be because pnpm explicitly doesn't used cached global dependencies, which means that when c3 invokes wrangler to download the existing workers files, it fails.
To resolve, we need to change c3 so that it depends on the locally installed copy of wrangler rather than a globally cached version. This can be done pretty easily by just moving the logic to copy the existing worker files after the package manager install step.
Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
No response

This was fixed with https://github.com/cloudflare/workers-sdk/pull/4754


[WIP] Add container image signature / verification docs

Adding docs about how to verify the image signatures.
https://github.com/kubernetes/website/pull/31610 accidentally merged before so we have to review the whole "Container Images" section from a docs team perspective.
This is the placeholder PR for KEP  https://github.com/kubernetes/enhancements/issues/3031
Refers to https://github.com/kubernetes/release/issues/2383
Closes https://github.com/kubernetes/website/issues/31420
cc @kubernetes/release-engineering
/hold

Preview: https://deploy-preview-31611--kubernetes-io-vnext-staging.netlify.app/releases/download/#verifying-container-image-signatures
(Since Netlify bot comment is not properly updated 😅)

/retitle [WIP] Add container image signature / verification docs

/assign @chrisnegus

@saschagrunert Still working on this?

@saschagrunert Still working on this? Maybe we should close this in favor of #32184 which is being actively worked on?

Ah yeah makes sense, thank you for the hint!


aws_batch extract-metadata timeout

Hi - an aws configuration problem on my end I would think:
However I was wondering if anyone has any insight here?
2024-05-27 23:38:18,585 [INFO] aws_s3.py:59 -- S3 client created - Region: us-west-2
2024-05-27 23:38:20,691 [INFO] aws_batch.py:89 -- AWS Batch client created - Region: us-west-2 - Env: FARGATE_SPOT
READING: books/Calibre Library/
2024-05-27 23:38:21,387 [INFO] aws_s3.py:59 -- S3 client created - Region: us-west-2
['books/Calibre Library/A. P. Klosky/Cold Steel Wardens (22904)/Cold Steel Wardens - A. P. Klosky.pdf', 'books/Calibre Library/A. P. Klosky/Cold Steel Wardens CSW Cover (12-2 (23034)/Cold Steel Wardens CSW Cover (1 - A. P. Klosky.pdf', "books/Calibre Library/A. R. Holmes/T&T - Vaults of K'Horror gm solo a (25119)/T&T - Vaults of K'Horror gm sol - A. R. Holmes.pdf"]
2024-05-27 23:38:30,333 [INFO] config.py:139 -- Lithops v3.3.0 - Python3.10
2024-05-27 23:38:31,088 [INFO] aws_s3.py:59 -- S3 client created - Region: us-west-2
2024-05-27 23:38:33,095 [INFO] aws_batch.py:89 -- AWS Batch client created - Region: us-west-2 - Env: FARGATE_SPOT
2024-05-27 23:38:33,097 [INFO] invokers.py:107 -- ExecutorID a3cd50-1 | JobID M000 - Selected Runtime: book-mentat-runtime-batch:01 - 2048MB
2024-05-27 23:38:33,313 [INFO] invokers.py:115 -- Runtime book-mentat-runtime-batch:01 with 2048MB is not yet deployed
2024-05-27 23:38:33,313 [INFO] aws_batch.py:428 -- Deploying runtime: book-mentat-runtime-batch:01 - Memory: 2048 Timeout: 180
2024-05-27 23:38:34,502 [INFO] aws_batch.py:333 -- Extracting metadata from: book-mentat-runtime-batch:01
Traceback (most recent call last):
  File "/home/richard/book-mentat/src/games/lithops_test_multimap.py", line 105, in <module>
    fexec2.map(process_pdf, plist)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/executors.py", line 254, in map
    runtime_meta = self.invoker.select_runtime(job_id, runtime_memory)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/invokers.py", line 116, in select_runtime
    runtime_meta = self.compute_handler.deploy_runtime(self.runtime_name, runtime_memory, runtime_timeout)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/serverless/serverless.py", line 84, in deploy_runtime
    return self.backend.deploy_runtime(runtime_name, memory, timeout=timeout)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/serverless/backends/aws_batch/aws_batch.py", line 433, in deploy_runtime
    runtime_meta = self._generate_runtime_meta(runtime_name, memory)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/serverless/backends/aws_batch/aws_batch.py", line 373, in _generate_runtime_meta
    raise Exception('Could not get metadata')
Exception: Could not get metadata

First time using Batch with Lithops - lambda working fine for the same thing.
Thanks very much.

config file like this
lithops:
    backend: aws_batch
    storage: aws_s3

aws_batch:
    region : us-west-2
    assign_public_ip: true
    execution_role: arn:aws:iam::ecsTaskExecutionRoleLithops
    instance_role: arn:aws:iam::ecsInstanceRolelithops
    subnets:
        - subnet-
        - subnet-
        - subnet-
        - subnet-
    security_groups:
        - sg-0
    runtime: book-mentat-runtime-batch:01
    runtime_memory: 2048
    worker_processes: 1
    container_vcpus: 1
    service_role: None
    env_total_cpus: 10
    env_type: FARGATE_SPOT

aws:
    region: us-west-2

aws_s3:
    storage_bucket: lithopsdata

with appropriate boring account numbers etc. removed

This error which I will have to look into more tomorrow
lithops.storage.utils.StorageNoSuchKeyError: No such key /lithopsdata/book-mentat-runtime-batch:01.meta found in storage.

As suspected, there was a missing role in the job definition. I added a fix for this. Follow the instructions to create the required ecsTaskJobRole role and provide it in the config, so that you don't need to put the AWS credentials in the Lithops config as I suggested before. For example,:
aws_batch:
    execution_role: arn:aws:iam::691987788901:role/ecsTaskExecutionRole
    instance_role: arn:aws:iam::691987788901:role/ecsInstanceRole
    job_role: arn:aws:iam::691987788901:role/ecsTaskJobRole
    security_groups:
        - sg-6510771e
    subnets:
        - subnet-7b7eb40d
        - subnet-5935797d
        - subnet-d2b7348a

Thanks! Will give that a shot this morning,

ok, added that role and the line in aws_batch.py  - looks like it is still happening
each time I run it still trying to deploy the runtime I have as a test - so I must have something wrong there - no runtime deploying - so no metadata to pull from the configured s3 bucket?

nothing in the bucket that looks like one of those batch job runtime strings as per the code

Can you access the AWS dashboard? If so, you will see the job deployed in the batch service, along with a link to the CloudWatch logs where you will likely see the error.

Yes, no Job
Job definition and Job Queue look ok

I added the keys to test as you suggest above, and different error:
2024-05-28 08:14:29,505 [INFO] invokers.py:174 -- ExecutorID c33c2c-1 | JobID M000 - Starting function invocation: process_pdf() - Total: 7328 activations
Traceback (most recent call last):
  File "/home/richard/book-mentat/src/games/lithops_test_multimap.py", line 105, in <module>
    fexec2.map(process_pdf, plist)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/executors.py", line 276, in map
    futures = self.invoker.run_job(job)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/invokers.py", line 268, in run_job
    futures = self._run_job(job)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/invokers.py", line 210, in _run_job
    raise e
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/invokers.py", line 207, in _run_job
    self._invoke_job(job)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/invokers.py", line 255, in _invoke_job
    activation_id = self.compute_handler.invoke(payload)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/serverless/serverless.py", line 70, in invoke
    return self.backend.invoke(runtime_name, runtime_memory, job_payload)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/lithops/serverless/backends/aws_batch/aws_batch.py", line 564, in invoke
    self.batch_client.submit_job(
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/botocore/client.py", line 565, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/home/richard/miniconda3/envs/mentat/lib/python3.10/site-packages/botocore/client.py", line 1021, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.ClientException: An error occurred (ClientException) when calling the SubmitJob operation: Error executing request, Exception : Job size must be less than 30 KiB, got 209 KiB, RequestId: 960e7b34-5c19-43dd-a566-9ff4137bc995

The last error is probably because of the size of the payload it is trying to pass for the execution.
Can you try running a simple hello world function with: lithops hello -b aws_batch -s aws_s3 -d

Yes, with config keys in .lithops_config that works

yes, basically running  a map across a list of books - and checking in those jobs for those that failed to process because of lambda timeouts  [around 300 or so]- would you handle it differently and sumit many separate things?

was used to doing batch array jobs of 10K each, so didn't consider that

looks like a no keys hello world is no completing - so I have something wrong - been going for several minutes

Ok, now I see Batch jobs - that test failed as per clouodwatch
<html>
<body>
<!--StartFragment-->
2024-05-27T22:56:08.374Z | environ({'HOSTNAME': 'ip-172-31-29-181.us-west-2.compute.internal', 'PYTHON_PIP_VERSION': '23.0.1', 'HOME': '/root', 'GPG_KEY': 'A035C8C19219BA821ECEA86B64E628F8D684696D', 'AWS_EXECUTION_ENV': 'AWS_ECS_FARGATE', 'AWS_BATCH_JOB_ID': '6175f5a5-002b-4451-8127-937a1150ab57', 'ECS_AGENT_URI': 'http://<IP_ADDRESS>/api/cde268447a974bd4a429224430fe9520-2470140894', 'AWS_DEFAULT_REGION': 'us-west-2', 'PYTHON_GET_PIP_URL': 'https://github.com/pypa/get-pip/raw/0d8570dc44796f4369b652222cf176b3db6ac70e/public/get-pip.py', 'AWS_BATCH_JQ_NAME': 'lithops_v330_vztq_FARGATE-SPOT_queue', 'ECS_CONTAINER_METADATA_URI_V4': 'http://<IP_ADDRESS>/v4/cde268447a974bd4a429224430fe9520-2470140894', 'APP_HOME': '/lithops', 'ECS_CONTAINER_METADATA_URI': 'http://<IP_ADDRESS>/v3/cde268447a974bd4a429224430fe9520-2470140894', 'PATH': '/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin', 'LANG': 'C.UTF-8', 'AWS_BATCH_JOB_ATTEMPT': '1', '__LITHOPS_PAYLOAD': '{"config": {"lithops": {"backend": "aws_batch", "storage": "aws_s3", "mode": "serverless", "monitoring": "storage", "execution_timeout": 1800, "chunksize": 1}, "aws_batch": {"region": "us-west-2", "assign_public_ip": true, "execution_role": "arn:aws:iam::958539196701:role/ecsTaskExecutionRoleLithops", "instance_role": "arn:aws:iam::958539196701:role/ecsInstanceRolelithops", "job_role": "arn:aws:iam::958539196701:role/ecsTaskJobRolelithops", "subnets": ["subnet-70515309", "subnet-4ad6fa01", "subnet-4a342910", "subnet-bd069396"], "security_groups": ["sg-0eabf99e212627078"], "runtime": "book-mentat-runtime-batch:01", "runtime_memory": 2048, "worker_processes": 1, "container_vcpus": 1, "service_role": "None", "env_total_cpus": 10, "env_type": "FARGATE_SPOT", "runtime_timeout": 180, "env_max_cpus": 10, "max_workers": 10, "user_agent": "lithops/3.3.0"}, "aws": {"region": "us-west-2"}, "aws_s3": {"storage_bucket": "lithops-data-books", "region": "us-west-2", "user_agent": "lithops/3.3.0"}}, "chunksize": 1, "log_level": 20, "func_name": "hello", "func_key": "lithops.jobs/2c372d-0/7b42ce6f22352d1a3c07c803020bd434.func.pickle", "data_key": "lithops.jobs/2c372d-0-A000/aggdata.pickle", "extra_env": {}, "total_calls": 1, "execution_timeout": 175, "data_byte_ranges": [[0, 31]], "executor_id": "2c372d-0", "job_id": "A000", "job_key": "2c372d-0-A000", "max_workers": 10, "call_ids": ["00000"], "host_submit_tstamp":<PHONE_NUMBER>.8832364, "lithops_version": "3.3.0", "runtime_name": "book-mentat-runtime-batch:01", "runtime_memory": 2048, "worker_processes": 1}', 'PYTHON_VERSION': '3.10.12', 'PYTHON_SETUPTOOLS_VERSION': '65.5.1', 'AWS_REGION': 'us-west-2', '__LITHOPS_ACTION': 'run_job', 'PWD': '/lithops', 'PYTHON_GET_PIP_SHA256': '96461deced5c2a487ddc65207ec5a9cffeca0d34e7af7ea1afc470ff0d746207', 'AWS_BATCH_CE_NAME': 'lithops_v330_vztq_FARGATE-SPOT_env'})
-- | --
  | 2024-05-27T22:56:08.374Z | File "/lithops/entry_point.py", line 69, in <module>
  | 2024-05-27T22:56:08.374Z | function_handler(lithops_payload)
  | 2024-05-27T22:56:08.374Z | File "/lithops/lithops/worker/handler.py", line 71, in function_handler
  | 2024-05-27T22:56:08.375Z | job = create_job(payload)
  | 2024-05-27T22:56:08.375Z | File "/lithops/lithops/worker/handler.py", line 60, in create_job
  | 2024-05-27T22:56:08.375Z | internal_storage = InternalStorage(storage_config)
  | 2024-05-27T22:56:08.375Z | File "/lithops/lithops/storage/storage.py", line 352, in __init__
  | 2024-05-27T22:56:08.375Z | self.storage.create_bucket(self.bucket)
  | 2024-05-27T22:56:08.375Z | File "/lithops/lithops/storage/storage.py", line 98, in create_bucket
  | 2024-05-27T22:56:08.375Z | return self.storage_handler.create_bucket(bucket)
  | 2024-05-27T22:56:08.375Z | File "/lithops/lithops/storage/backends/aws_s3/aws_s3.py", line 84, in create_bucket
  | 2024-05-27T22:56:08.375Z | self.s3_client.head_bucket(Bucket=bucket_name)
  | 2024-05-27T22:56:08.375Z | File "/usr/local/lib/python3.10/site-packages/botocore/client.py", line 565, in _api_call
  | 2024-05-27T22:56:08.375Z | return self._make_api_call(operation_name, kwargs)
  | 2024-05-27T22:56:08.375Z | File "/usr/local/lib/python3.10/site-packages/botocore/client.py", line 1001, in _make_api_call
  | 2024-05-27T22:56:08.376Z | http, parsed_response = self._make_request(
  | 2024-05-27T22:56:08.376Z | File "/usr/local/lib/python3.10/site-packages/botocore/client.py", line 1027, in _make_request
  | 2024-05-27T22:56:08.376Z | return self._endpoint.make_request(operation_model, request_dict)
  | 2024-05-27T22:56:08.376Z | File "/usr/local/lib/python3.10/site-packages/botocore/endpoint.py", line 119, in make_request
  | 2024-05-27T22:56:08.376Z | return self._send_request(request_dict, operation_model)
  | 2024-05-27T22:56:08.376Z | File "/usr/local/lib/python3.10/site-packages/botocore/endpoint.py", line 198, in _send_request
  | 2024-05-27T22:56:08.376Z | request = self.create_request(request_dict, operation_model)
  | 2024-05-27T22:56:08.376Z | File "/usr/local/lib/python3.10/site-packages/botocore/endpoint.py", line 134, in create_request
  | 2024-05-27T22:56:08.376Z | self._event_emitter.emit(
  | 2024-05-27T22:56:08.376Z | File "/usr/local/lib/python3.10/site-packages/botocore/hooks.py", line 412, in emit
  | 2024-05-27T22:56:08.376Z | return self._emitter.emit(aliased_event_name, **kwargs)
  | 2024-05-27T22:56:08.376Z | File "/usr/local/lib/python3.10/site-packages/botocore/hooks.py", line 256, in emit
  | 2024-05-27T22:56:08.376Z | return self._emit(event_name, kwargs)
  | 2024-05-27T22:56:08.376Z | File "/usr/local/lib/python3.10/site-packages/botocore/hooks.py", line 239, in _emit
  | 2024-05-27T22:56:08.376Z | response = handler(**kwargs)
  | 2024-05-27T22:56:08.376Z | File "/usr/local/lib/python3.10/site-packages/botocore/signers.py", line 105, in handler
  | 2024-05-27T22:56:08.377Z | return self.sign(operation_name, request)
  | 2024-05-27T22:56:08.377Z | File "/usr/local/lib/python3.10/site-packages/botocore/signers.py", line 199, in sign
  | 2024-05-27T22:56:08.377Z | auth.add_auth(request)
  | 2024-05-27T22:56:08.377Z | File "/usr/local/lib/python3.10/site-packages/botocore/auth.py", line 418, in add_auth
  | 2024-05-27T22:56:08.377Z | raise NoCredentialsError()
  | 2024-05-27T22:56:08.377Z | botocore.exceptions.NoCredentialsError: Unable to locate credentials

<!--EndFragment-->
</body>
</html>

In this case it is a permissions issue, in principle the patch I added should fix it. Can you make sure the JobARN in the job definition is correctly set? for example:

ok, will check

looks like not
making a new one with your code addition likely would?

making a new one with your code addition likely would?

yes, my addition must add it always

can you run lithops clean -b aws_batch -s aws_s3 -d ?
This will cleanup all the lithops job definitions you deployed previous my patch, and then run again lithops hello -b aws_batch -s aws_s3 -d

yes, will do - the test might have to wait until I get back this arvo will see how it goes

the teardown and rebuild worked, thanks [been in transit] - so now presumably just code problems  - I will try a test just sending a few through and check that works when I get home from what I was trying and go from there

Framework worked on that test
2024-05-28 17:00:40,367 [INFO] wait.py:101 -- ExecutorID cbd67f-1 - Waiting for 10 function activations to complete

  100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 10/10

2024-05-28 17:01:39,690 [INFO] executors.py:610 -- ExecutorID cbd67f-1 - Cleaning temporary data

Seems like magic when that happens, so thank you!


Release 2024-03-27 - compute only release

Release 2024-03-27
Please merge this Pull Request using 'Create a merge commit' button

Reviewed for 04-29-2024 changelog. Nothing to add.


pure text should be properly resolved

There are cases when a user uses a non rust convention parameters
e.g.
 -- /path/to/file1
which resolves to
cargo run -p packageName --bin binName -- --=/path/to/file1

that should resolve to
cargo run -p packageName --bin binName -- path/to/file1

also passing text without -- right now is erroring out Cannot read properties of undefined (reading 'replace')
not all CLI built with rust arent using the cli convention as such there would be error on the overriding of parameters
possible solution is...
pass in the text as is....

when appending parameters we will put the responsibility to the user to pass in the required -- flag
and would not be automatically appended, that way it would work to non conventional overriding of parameters


Feature Request: Add waitOnLogMessage

From hamiltont on May 24, 2012 13:24:38
Currently the waitOnXX options are a bit sparse. Perhaps also add a waitOnLog(String TAG, String message), where either can be a regex?
Original issue: http://code.google.com/p/robotium/issues/detail?id=264

From hamiltont on May 24, 2012 13:44:15
Another thought: waitForTabIndexToChange() e.g. once some code completes the tab will be switched

From<EMAIL_ADDRESS>on May 25, 2012 01:17:39
Thanks for the request. I really like the idea of waiting for a certain log message. Lets investigate this :)
Status: Accepted
Owner<EMAIL_ADDRESS>

From<EMAIL_ADDRESS>on August 04, 2012 11:31:59
This will be included in 3.4.
Labels: -Type-Defect Type-Enhancement

From<EMAIL_ADDRESS>on August 07, 2012 01:51:52
This has been included in 3.4.
Status: Verified


Specialized function overloading (type guards)

Sorry, It maybe duplicate, but I can't find an issue.
Let we have this code:
class C {
    x:number;
}
function fn(name:"a" );
function fn(name:"b", x:string );
function fn(name:"c", x:C);
function fn(name:"a"|"b"|"c", x?:string|C) {
    if (name ==="c") {
        x.x = 1; //error
    }
}

We can infer that x has C type inside "c" = true branch of the condition.
Is there special type guard for this case?
If isn't then are there any plans to support this behavior?

#14515

@RyanCavanaugh thanks


Allow custom implementations of PublishArtifact

These used to work in the past and we don't want to break them
now unless we have a very compelling reason to.

Fixes #17273

@bot-gradle test QF

@bot-gradle help

Currently I support the following commands:

@bot-gradle test {BuildStage} to trigger a build

e.g. @bot-gradle test SanityCheck plz
SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/ReadyForMerge/ReadyForNightly/ReadyForRelease are supported
test this means test ReadyForMerge
test and merge to trigger a pre-tested commit build
cancel to cancel a running pre-tested commit build or remove it from queue
SanityCheck can be abbreviated as SC, ReadyForMerge as RFM, etc.
Specific builds:

AST: AllSmokeTestsReadyForMerge
AFT: AllFunctionalTestsReadyForMerge
ASB: AllSpecificBuildsReadyForMerge
ACC: AllConfigCacheTestsReadyForMerge
ACT: AllCrossVersionTestsReadyForNightly
APTN: AllPerformanceTestsReadyForNightly
AFTN: AllFunctionalTestsReadyForNightly
ACTR: AllCrossVersionTestsReadyForRelease
AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle help to display this message
@bot-gradle clean to clear the conversation history

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


SSO doesn't work?

I follow the instructions and use Cmd+Shift+P to login to Zeplin.
VS Code indicates that I successfully login.
Running zeplin connect gives either one of two messages:

Access token not found in ZEPLIN_ACCESS_TOKEN environment variable.
// or
Looks like your session has expired, please login again.

Then asks for username/password, but obviously errors because we use SSO.

my-project$ zeplin connect

Zeplin CLI - v1.0.1

Connecting all connected components into Zeplin…
Access token not found in ZEPLIN_ACCESS_TOKEN environment variable.

Login into Zeplin…
? Username/Email<EMAIL_ADDRESS>? Password [hidden]
Connecting components to Zeplin components failed.
    Your organization requires SSO for login - You need to login using your organization's SSO provider.

Please check ~/.zeplin/cli.log for details.

I believe this is still be considered a bug in the VS Code extension as the suggested login procedure in the docs doesn't work (at least not with SSO), but I was able to find a workaround.
The token supplied by the Cmd+Shift+P workflow is apparently different (and "appears expired") than the token you get by logging into the Zeplin web app directly 😖

Go to zeplin.io
Login with SSO
Profile > Connected Apps
CLI > Connect
Copy the token value
Export that token to your environment or add it to your shell profile

export ZEPLIN_ACCESS_TOKEN=your_token_value_here


Get log messages when executing test cases

Hello,
I am wondering if it is possible to run a test case and collect log messages that reflect the system behavior.
For example, for the Chart (jfreechart) project, can I run a test case and save the log messages (that are introduced by the log printing statements in the source code) to a file.
thank you for your help.
Salma

Hi @SalmaMessaoudi,
You can see all program output by enabling the debugging mode (export D4J_DEBUG=true). If you want to capture the program output in a file, you can add another JUnit test result formatter to Defects4J's top-level build file. For example, adding <formatter type="plain" usefile="true" /> should suffice.
Best,
René

Hi @rjust,
Thank you for your reply.
I have tried what you suggested and indeed I can see there is a text file being generated for each executed test case. But those files contain only the test methods being executed and their execution time. They do not contain any log messages that refer to the target system behavior.
For example, I did the following: checkout the fixed version of the bug number 1 from the JxPath project ( defects4j checkout -p JxPath -v 1f -w /tmp/jxpath_1_fixed ), compile and test using defects4j and I got, for example, for the test case in StressTest:
        Testsuite: org.apache.commons.jxpath.ri.StressTest
        Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.684 sec

        Testcase: testThreads took 0.684 sec

This looks like they are debug messages related to defects4j and not to the target project (in this case the JxPath).
Is there a way to obtain debug messages that show the target system behavior when running test cases?
Thanks again for your help and your time.
Best,
Salma


New questions batch

I'v added new questions for your pack.

Hi @seregazhuk,
thank you for your contribution.  I will review asap.
Mickaël

thank you @seregazhuk  (and thank you @xabbuh for review)


Back button history doesn't update when using the search feature

When you click links, the back button history is updated allowing you to press the back button to go back. This does not happen when using the search feature.
Steps to reproduce:

Navigate to the page of block 1111.
Type "1234" into the search bar and press Enter.
1111 does not appear in your history. Pressing the back button will take you back to the page before it (or no page at all if you go directly to /block/1111)

It's expected that if you navigate to /block/1111 and then go to 1234 from the search bar, you can press the back button in the browser to go back to /block/1111.

yeah, I think it's "replacing page" instead of "navigating to". I don't remember if that was intentional or not (there is another place where I think I made it "replace" on purpose), let me recall I did it that way :)

considering as a bug for now :)

Merged, thanks!
About my original comment, I think I put replace: true at first to test something, then forgot it, then it replicated by copy/pasting :(


fix: update actions/setup-python@v5

As per internal discussion, this pull-request fixes the version of the actions/setup-python.

I wonder why dependabot does not open pull-requests for updating the reusable actions. May it be possible that only pays attention to the .github/ dir... despite being configure with / dir...?

Looks like!


Update documentation for Vector2Angle

Clarified that the angle is signed and that positive angles appear visually clockwise. I am coming from Unity and their Vector2.Angle is unsigned so this confused me for some time. This might help others too.

@mrjonjonjon thanks for the review


Css fix

Hey,
Just a small fix for the issue "Overlapped Labels with input on Linux" currently open. I actually had this problem on both Linux and Windows myself. I also took the opportunity to expand those fields to use the full width so that they always align - as well as centering the grouped fields in the bottom for a better visual.

Thanks a lot. It look really great !


feat(routes): basic game routes

Implements collect and upgrade routes that allow for playing a very basic idle game.

collect route that collects the user's production by comparing the last time they've collected to the current time
upgrade route that upgrades the user's levels to the max amount of levels they're able to purchase with their balance
GameCalculations trait implementation on the User model to access functions for quickly completing game-related actions
NotEnoughMoney error struct that will be returned from the upgrade route if the user doesn't have enough in their balance for a level

also could you write tests for the collection math and whatnot


[Request] Botanical Addons (Botania) support

The fancy new Dendric Suffuser. Sort of a hybrid of the Runic Altar and Thaumcraft's Infusion Altar.
Functionality:
https://www.youtube.com/watch?v=KlrQioZ9fN0&feature=youtu.be
Context:
https://www.reddit.com/r/botania/comments/43fouv/botanical_addons_botania_thaumcraft_aspects_sound/cziae2r?context=3
Github:
https://github.com/L0neKitsune/Botanical-Addons

Also iridescent sapling variants! Custom trees, yay

imma implement this on BA's side, please close this in favor of https://github.com/L0neKitsune/Botanical-Addons/issues/82

close this, please


[release/1.7] fix: ImagePull should close http connection if there is no available data to read.

Cherry-picking https://github.com/containerd/containerd/pull/9369 to 1.7

cc @samuelkarp  @qiutongs

cc @fuweid @henry118


Repo sync for protected CLA branch

The pull request is created from master637490095100241508 to master to fix git push error for protected CLA branch

@cmcclister : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Sort new /balances by fiat balance

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.553%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
9526

Relevant Lines:
11006

💛  - Coveralls


Improve modal form component

Add the enter to submit functionality on the modal form.

#16 Done!


ruamel.yaml

Hello, the author, thank you very much for opening the code. During the running process, I found that there seems to be no ruamel.yaml file, which will lead to the failure to run the code successfully. I look forward to your providing this file.

The YAML file is config.yaml.

Thank you for your reply. In the train.py file, there is from ruamel.yaml import safe_ Load code, safe_ Load will be used later. There is no such file in config.yam to export, so the code cannot be run successfully. We look forward to your repair!

I'm really sorry, but I didn't notice that ruamel.yaml is a function package. The problem has been solved. Thank you again.

Hello, the author, there seems to be a problem when preprocessing the dataset STARE. The following error occurred during the arrival test preprocessing phase:
Traceback (most recent call last):
File "data_process.py", line 204, in
args.patch_ size, args.stride, "test")
File "data_process.py", line 122, in data_ process
img_ list = get_ square(img_list, name)
File "data_process.py", line 137, in get_ square
pad = nn.ConstantPad2d((0, shape-w, 0, shape-h), 0)
UnboundLocalError: local variable 'shape' referenced before assignment
How to solve this problem? We look forward to your reply!


Add Social Links for CFI

So I want to add the links above to the Dharma page for CFI: https://www.dharma.io/token/0x63b4f3e3fa4e438698ce330e365e831f7ccd1ef4
I haven't used GitHub before to create Pull Requests and make changes, so i'm not sure if I've done this right? Please can you let me know if you need more information or anything else to get these changes made? Thanks a lot in advance.

Ignore


GalleryItem: Check address validity before Transfer

On galleryItem I would like to check the validity of an address before sending NFT (related with #4834 to show error msg)
right now we're using checkTsxSend, IMO we can do better and trigger it on input?


fix(docs): fix minor typo in documentation for code-splitting

Summary

Fix minor typo in code-splitting documentation on website

Test plan
N/A

Thanks!


missing cmath include

cmath include missing, failed to compile under Clang++ 3.9 with libc++

Please don't merge until we verify the android build against earlier NDKs.  Jsoncpp and cmath have been consistent problems across NDK versions.

added comment

This should be fixed in the latest version of the SDK.  Thanks for your help.


Phase 0 packages - connector, auth

Filing this issue to track work related to getting the Phase 0 packages for Python in. This should cover the connector and auth components

These packages have been completed and published:
https://pypi.org/project/botbuilder-core/
https://pypi.org/project/botbuilder-schema/
https://pypi.org/project/botframework-connector/


Idea for enhancing manual control

This is to hopefully resolve the by far #1 complaint my wife has with our smart home. When she turns on a light, AL adjusts it to what it thinks it should be, she changes it to what she wants it to be, then AL adjusts it back.
Could you add a check in after the initial turn on transition for the light? If the light is where AL thinks it should be, great. If it's not, set it to manually controlled and stop adjusting it.

There is an option take over control which does exactly that.

It doesn’t though. If I turn it on and immediately change the brightness like a normal person would AL still takes over. Manual control doesn’t seem to kick in until at least the first check in after it’s turned on.

@broyuken Make sure that the lights defined in adaptive line match the lights in whatever automation you are using if any. If you set up adaptive light using a group of some sort (native/Zigbee) and try to set an individual light, AL won't respect that change.

It works fine after the first check in. But if I adjust the lights right away after AL changes them it doesn’t mark it as manually adjusted.

Hey @broyuken,

It works fine after the first check in. But if I adjust the lights right away after AL changes them it doesn’t mark it as manually adjusted.

While this might be a bug, version 2 is planned to get a completely new output module anyway, so this bug will likely disappear.
Additionally the manual/automatic controlling of lights/groups/rooms should be much more comfortable in v2 as well. So there might be a big improvement in "wife compatibility" ahead ;)
Keep this ticket open until you can verify that it's properly working in the upcoming version 2.

Awesome, thank you! I have a bunch of tickets open around manual control and random lights turning back on.
No pressure, and we’re not holding you to any hard dates but do you have a rough ETA on v2? Are you thinking days, weeks, months, next year, etc. really looking forward to any improvements because this is by far my most used integration.

I've been debugging the same issue and it looks like if you adjust brightness after turning the light on it does not trigger manual mode on state change.
Brightness change is checked only when adapt light is called, so if you change brightness it first sets new adaptive light brightness and then sets manual mode and quits.
You could pre-emptively enable the set manual mode. Looking forward v2 too!
I know some Python and do a lot of other coding so I'm happy to test an early release/dev branch.

Resurrecting this as I am experiencing the same behaviour. A lot of work has happened on this component since this ticket was filed -- should this have been fixed in the mean time, or will an adjustment right after turning the lights on still be overridden by AL?

I think this is a planned fix for v2 whenever that is going to happen. I haven’t heard a rough ETA or anything yet

That wouldn’t work. If you turn a light off at noon when it should be at 100% and white, and then don’t turn it on again until 7pm when it should be 50% and warm it shouldn’t be set to manual control.

PR #450 fixes this with the config options strict_adapting: false OR alt_detect_method: true set.

It does seem to be fixed, thank you!!!


Nested list: parse delimeter in parent item

This example should generate a note:

Question ?::

Answer

Would require that I add some sort of "captive" mode: when a parent item ends with a delimeter, all items in the nested list should be notes.
I am not currently interested in adding this.


docs: fix grammatical and linguistic issues in the documentation!

Signed-off-by: Binit Ghimire<EMAIL_ADDRESS>Resolved several grammatical and linguistic issues!
GitHub Issue: None
PR Type
What kind of change does this PR introduce?

Documentation content changes

Description
This PR resolves several grammatical and linguistic issues present in the existing README.md documentation.

PR Checklist
Please check if your PR fulfills the following requirements:

Commits must be following the Conventional Commits specification
[x] Tested UWP
[x] Tested iOS
[x] Tested Android
[x] Tested WASM
[x] Tested MacOS
[x] Contains No breaking changes

If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information
No, there is no further information that has to be provided regarding this PR.

Internal Issue (If applicable):

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@TheBinitGhimire thank you a lot for your contribution!
I will close this PR as the current documentation structure and content changed lately.
You are more than welcome to contribute again to the Uno Platform and if you need help don't hesitate to check our contributing guide.


Update Composer dependencies (2023-06-09-00-10)

Visual regression test passed!
View the visual regression test report


Natasha/episode card cell refactor

Sorry to put these in the same PR!

Series Detail Bug fix #31
Episode / Card Cell Refactor  #137, #129

@drewsdunne Please Review


Make DispatchError impl MEL

Polkadot companion: https://github.com/paritytech/polkadot/pull/6583

Build failure due to MaxEncodedLen not properly respecting codec(skip)

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2283417

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2283416

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2283401

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2283402

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2283407

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2283405

bot merge

bot merge


DeviceTypeProvider: add new component

Summary
What changed?
This PR introduces a new component, DeviceTypeProvider. The associated docs page is skeletal for now, as this component is an alpha that may change. The docs page can be navigated to directly but has not yet been added to the sidebar index, so it is somewhat hidden for now. I will flesh out the rest of the docs page before this component officially launches.
Why?
We'd like to start offering device-specific UI for certain components, e.g. migrating Pinboard's MobileModal into Gestalt and rendering that UI for mobile devices. Using the same 'desktop' | 'mobile' | 'tablet' device types as Pinboard, this context provider is the first step in this project, making device type available within components. Future work will add logic within components to use this device type.
I'm imagining this will be used something like
// App.js

return (
  <DeviceTypeProvider value={useDeviceType()}>
    {children}
  </DeviceTypeProvider>
);

// Gestalt Modal.js

const deviceType = useDeviceType();

return deviceType === 'mobile' ? <MobileModal /> : <Modal />;

Links

Jira

Checklist

[ ] ~Added unit and Flow Tests~ Don't seem necessary for a context this simple
[x] Added documentation + accessibility tests

That's a really good point. This is less about showing/hiding content and
more about switching completely from one UI to another. That's definitely
something we should cover in the guidance when this is released officially.
On Tue, Feb 15, 2022 at 1:51 PM Christian Vuerings @.***>
wrote:

@.**** commented on this pull request.
In packages/gestalt/src/contexts/DeviceTypeProvider.js
https://github.com/pinterest/gestalt/pull/1939#discussion_r807346498:

@@ -0,0 +1,31 @@
+// @flow strict
+import { type Context, type Node, createContext, useContext } from 'react';

+const defaultDeviceType = 'desktop';
+
+type DeviceType = 'desktop' | 'phone' | 'tablet';
Currently we show/hide content through breakpoints (e.g. smDisplay /
mdDisplay and lgDisplay) instead of device type. It would be good to
clarify when we should use what.
—
Reply to this email directly, view it on GitHub
https://github.com/pinterest/gestalt/pull/1939#pullrequestreview-883691992,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC4AHE3DI2F3CZGNTRYPYSTU3LDHLANCNFSM5OMX2BWA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Fuzzing

Fuzzing is a good way to detect problems with your parser when you are using a custom scanner.c. See instructions here: https://github.com/ikatyang/tree-sitter-markdown/issues/14
❯ ./out/rst_fuzzer
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed:<PHONE_NUMBER>
INFO: Loaded 1 modules   (21960 inline 8-bit counters): 21960 [0x7fe5f0, 0x803bb8),
INFO: Loaded 1 PC tables (21960 PCs): 21960 [0x803bb8,0x859838),
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes
test/fixtures/grammars/rst/src/tree_sitter_rst/scanner.c:88:10: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/include/string.h:44:28: note: nonnull attribute specified here
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior test/fixtures/grammars/rst/src/tree_sitter_rst/scanner.c:88:10 in
lib/src/lexer.c:76:55: runtime error: applying zero offset to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior lib/src/lexer.c:76:55 in
INFO: A corpus is not provided, starting from an empty corpus
#2      INITED cov: 2709 ft: 2710 corp: 1/1b exec/s: 0 rss: 35Mb
        NEW_FUNC[1/70]: 0x55bed0 in is_start_char /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/chars.c:196
        NEW_FUNC[2/70]: 0x569e10 in parse_text /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/parser.c:1514
#3      NEW    cov: 4667 ft: 6706 corp: 2/2b lim: 4 exec/s: 0 rss: 36Mb L: 1/1 MS: 1 ChangeByte-
#4      NEW    cov: 4676 ft: 6783 corp: 3/4b lim: 4 exec/s: 0 rss: 36Mb L: 2/2 MS: 1 CopyPart-
#5      NEW    cov: 4680 ft: 7675 corp: 4/6b lim: 4 exec/s: 0 rss: 36Mb L: 2/2 MS: 1 CopyPart-
        NEW_FUNC[1/1]: 0x6e6340 in ts_subtree_repeat_depth (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x6e6340)
#8      NEW    cov: 4839 ft: 9105 corp: 5/8b lim: 4 exec/s: 0 rss: 36Mb L: 2/2 MS: 3 ChangeByte-CopyPart-InsertByte-
        NEW_FUNC[1/2]: 0x6776c0 in ts_subtree_is_error (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x6776c0)
        NEW_FUNC[2/2]: 0x69bda0 in ts_subtree_symbol (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x69bda0)
#9      NEW    cov: 4864 ft: 9310 corp: 6/10b lim: 4 exec/s: 0 rss: 36Mb L: 2/2 MS: 1 ChangeBit-
        NEW_FUNC[1/6]: 0x5c7360 in ts_subtree_total_bytes (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x5c7360)
        NEW_FUNC[2/6]: 0x5cafd0 in ts_subtree_total_size (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x5cafd0)
#11     NEW    cov: 4984 ft: 10767 corp: 7/12b lim: 4 exec/s: 0 rss: 37Mb L: 2/2 MS: 2 ChangeBinInt-ChangeBit-
        NEW_FUNC[1/1]: 0x69c790 in ts_realloc (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x69c790)
#15     NEW    cov: 5009 ft: 11307 corp: 8/15b lim: 4 exec/s: 0 rss: 37Mb L: 3/3 MS: 4 CrossOver-ChangeBit-ShuffleBytes-CrossOver-
        NEW_FUNC[1/2]: 0x567d30 in parse_inner_numeric_bullet /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/parser.c:367
        NEW_FUNC[2/2]: 0x56ba40 in parse_numeric_bullet /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/parser.c:346
#16     NEW    cov: 5072 ft: 11655 corp: 9/17b lim: 4 exec/s: 0 rss: 37Mb L: 2/3 MS: 1 InsertByte-
#18     NEW    cov: 5078 ft: 11662 corp: 10/19b lim: 4 exec/s: 0 rss: 37Mb L: 2/3 MS: 2 EraseBytes-ChangeBit-
#19     NEW    cov: 5078 ft: 11668 corp: 11/20b lim: 4 exec/s: 0 rss: 37Mb L: 1/3 MS: 1 EraseBytes-
#23     NEW    cov: 5090 ft: 11680 corp: 12/22b lim: 4 exec/s: 0 rss: 37Mb L: 2/3 MS: 4 CrossOver-ShuffleBytes-ChangeByte-ChangeBinInt-
#26     NEW    cov: 5090 ft: 11736 corp: 13/25b lim: 4 exec/s: 0 rss: 38Mb L: 3/3 MS: 3 EraseBytes-ShuffleBytes-CrossOver-
        NEW_FUNC[1/5]: 0x579950 in rst_scanner_push /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/scanner.c:53
        NEW_FUNC[2/5]: 0x579c20 in rst_scanner_pop /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/scanner.c:61
#29     NEW    cov: 5321 ft: 12281 corp: 14/27b lim: 4 exec/s: 0 rss: 38Mb L: 2/3 MS: 3 EraseBytes-ChangeByte-ChangeBit-
#33     NEW    cov: 5326 ft: 12293 corp: 15/30b lim: 4 exec/s: 0 rss: 38Mb L: 3/3 MS: 4 CopyPart-CopyPart-EraseBytes-InsertByte-
#35     NEW    cov: 5339 ft: 12306 corp: 16/32b lim: 4 exec/s: 0 rss: 38Mb L: 2/3 MS: 2 ShuffleBytes-ChangeByte-
#36     NEW    cov: 5340 ft: 12307 corp: 17/34b lim: 4 exec/s: 0 rss: 38Mb L: 2/3 MS: 1 ChangeBinInt-
        NEW_FUNC[1/1]: 0x55ed90 in parse_overline /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/parser.c:64
#38     NEW    cov: 5373 ft: 12346 corp: 18/36b lim: 4 exec/s: 0 rss: 38Mb L: 2/3 MS: 2 EraseBytes-ChangeBinInt-
#39     NEW    cov: 5379 ft: 12353 corp: 19/38b lim: 4 exec/s: 0 rss: 38Mb L: 2/3 MS: 1 ChangeByte-
#41     NEW    cov: 5379 ft: 12355 corp: 20/39b lim: 4 exec/s: 0 rss: 38Mb L: 1/3 MS: 2 ShuffleBytes-EraseBytes-
#46     NEW    cov: 5381 ft: 12357 corp: 21/41b lim: 4 exec/s: 0 rss: 39Mb L: 2/3 MS: 5 CopyPart-ShuffleBytes-EraseBytes-ShuffleBytes-ChangeByte-
        NEW_FUNC[1/3]: 0x59f520 in ts_realloc (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x59f520)
        NEW_FUNC[2/3]: 0x677880 in pop_error_callback (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x677880)
#49     NEW    cov: 5563 ft: 13378 corp: 22/43b lim: 4 exec/s: 0 rss: 39Mb L: 2/3 MS: 3 CopyPart-CrossOver-ChangeByte-
#54     NEW    cov: 5563 ft: 13379 corp: 23/45b lim: 4 exec/s: 0 rss: 39Mb L: 2/3 MS: 5 ShuffleBytes-CrossOver-ChangeByte-ShuffleBytes-ShuffleBytes-
#58     NEW    cov: 5570 ft: 13407 corp: 24/48b lim: 4 exec/s: 0 rss: 39Mb L: 3/3 MS: 4 ChangeByte-CopyPart-ShuffleBytes-CrossOver-
#59     NEW    cov: 5590 ft: 13932 corp: 25/51b lim: 4 exec/s: 0 rss: 39Mb L: 3/3 MS: 1 CMP- DE: "\x13\x00"-
#61     NEW    cov: 5595 ft: 13938 corp: 26/54b lim: 4 exec/s: 0 rss: 39Mb L: 3/3 MS: 2 ChangeBit-ChangeBit-
#65     NEW    cov: 5595 ft: 13940 corp: 27/58b lim: 4 exec/s: 0 rss: 40Mb L: 4/4 MS: 4 InsertByte-ChangeByte-EraseBytes-InsertByte-
#66     NEW    cov: 5602 ft: 14085 corp: 28/61b lim: 4 exec/s: 0 rss: 40Mb L: 3/4 MS: 1 InsertByte-
#67     NEW    cov: 5602 ft: 14094 corp: 29/63b lim: 4 exec/s: 0 rss: 40Mb L: 2/4 MS: 1 ChangeByte-
        NEW_FUNC[1/1]: 0x5634a0 in parse_inner_inline_markup /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/parser.c:1065
#69     NEW    cov: 5633 ft: 14127 corp: 30/65b lim: 4 exec/s: 0 rss: 40Mb L: 2/4 MS: 2 EraseBytes-ChangeBit-
#71     NEW    cov: 5635 ft: 14679 corp: 31/68b lim: 4 exec/s: 0 rss: 40Mb L: 3/4 MS: 2 ShuffleBytes-PersAutoDict- DE: "\x13\x00"-
        NEW_FUNC[1/2]: 0x55c7b0 in is_internal_reference_char /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/chars.c:282
        NEW_FUNC[2/2]: 0x56bdf0 in parse_inner_standalone_hyperlink /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/parser.c:1282

=================================================================
==27362==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x52368d in malloc (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x52368d)
    #1 0x56bed8 in parse_inner_standalone_hyperlink /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/parser.c:1287:18
    #2 0x568b29 in parse_inner_numeric_bullet /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/parser.c:412:14
    #3 0x56bc7a in parse_numeric_bullet /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/parser.c:360:12
    #4 0x57b6a5 in rst_scanner_scan /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/tree_sitter_rst/scanner.c:165:12
    #5 0x57cd6e in tree_sitter_rst_external_scanner_scan /home/stephan/projects/tree-sitter/test/fixtures/grammars/rst/src/scanner.c:43:10
    #6 0x5a67f0 in ts_parser__lex (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x5a67f0)
    #7 0x594076 in ts_parser__advance (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x594076)
    #8 0x58e391 in ts_parser_parse (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x58e391)
    #9 0x59eba9 in ts_parser_parse_string_encoding (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x59eba9)
    #10 0x59e7d3 in ts_parser_parse_string (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x59e7d3)
    #11 0x558453 in LLVMFuzzerTestOneInput (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x558453)
    #12 0x45b831 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x45b831)
    #13 0x45ad7a in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x45ad7a)
    #14 0x45ca27 in fuzzer::Fuzzer::MutateAndTestOne() (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x45ca27)
    #15 0x45d5c5 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, fuzzer::fuzzer_allocator<fuzzer::SizedFile> >&) (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x45d5c5)
    #16 0x44b76b in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x44b76b)
    #17 0x4750a2 in main (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x4750a2)
    #18 0x7f9ab47f7cb1 in __libc_start_main csu/../csu/libc-start.c:314:16

SUMMARY: AddressSanitizer: 8 byte(s) leaked in 1 allocation(s).
INFO: to ignore leaks on libFuzzer side use -detect_leaks=0.

MS: 1 ChangeBit-; base unit: 26776e135b7c21e4484e3a0abb629a51864fad48
0x4a,0x5a,
JZ
artifact_prefix='./'; Test unit written to ./leak-52ee862de32ba73e341b7c6be241b00d4a5c23ee
Base64: Slo=

I guess bfredl has already fixed this in upstream tree-sitter
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior test/fixtures/grammars/rst/src/tree_sitter_rst/scanner.c:88:10 in
lib/src/lexer.c:76:55: runtime error: applying zero offset to null pointer

When running without memory leaks: -detect_leaks=0

0x000000794664 is located 60 bytes to the left of global variable '<string literal>' defined in 'test/fixtures/grammars/rst/src/tree_sitter_rst/chars.c:418:5' (0x7946a0) of size 7
  '<string literal>' is ascii string 'mailto'
0x000000794664 is located 0 bytes to the right of global variable '<string literal>' defined in 'test/fixtures/grammars/rst/src/tree_sitter_rst/chars.c:417:5' (0x794660) of size 4
  '<string literal>' is ascii string 'ftp'
SUMMARY: AddressSanitizer: global-buffer-overflow (/home/stephan/projects/tree-sitter/out/rst_fuzzer+0x4be9eb) in MemcmpInterceptorCommon(void*, int (*)(void const*, void const*, unsigned long), void const*, void const*, unsigned long)
Shadow bytes around the buggy address:
  0x0000800ea870: 00 00 00 04 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9
  0x0000800ea880: 00 00 f9 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9
  0x0000800ea890: 00 00 00 f9 f9 f9 f9 f9 00 00 00 04 f9 f9 f9 f9
  0x0000800ea8a0: 00 00 00 04 f9 f9 f9 f9 00 00 00 00 00 00 00 00
  0x0000800ea8b0: 00 00 00 00 00 00 00 00 00 00 00 00 05 f9 f9 f9
=>0x0000800ea8c0: f9 f9 f9 f9 06 f9 f9 f9 f9 f9 f9 f9[04]f9 f9 f9
  0x0000800ea8d0: f9 f9 f9 f9 07 f9 f9 f9 f9 f9 f9 f9 07 f9 f9 f9
  0x0000800ea8e0: f9 f9 f9 f9 04 f9 f9 f9 f9 f9 f9 f9 00 00 00 00
  0x0000800ea8f0: 00 00 f9 f9 f9 f9 f9 f9 00 00 00 00 00 00 00 00
  0x0000800ea900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0000800ea910: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==32376==ABORTING
MS: 2 PersAutoDict-PersAutoDict- DE: "\x1f\x00"-"DNDD"-; base unit: 468b68de792d7dec386b15fa0d7d26eae33ca74b
0x1b,0x0,0x41,0x44,0x4e,0x44,0x44,0x3a,
\x1b\x00ADNDD:
artifact_prefix='./'; Test unit written to ./crash-d925baf19dcb1aea830b3687907d6fa778872982
Base64: GwBBRE5ERDo=

oops, somehow missed this, I'm not that familiar with fuzzing, but I'll check the instructions, thanks. There are some things that are expected to give errors https://github.com/stsewd/tree-sitter-rst/blob/aa61d0e2930de134089326973686ac547cca9e03/Makefile#L24-L31

I've run the fuzzer, I think everything should be good now. I may create a dockerfile later to run it after each change.

I've run the fuzzer, I think everything should be good now. I may create a dockerfile later to run it after each change.


Typo in third paragraph

"If you have experience cooking" should be "If you have experience with cooking"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 17d27a0d-c072-8c9f-7e31-3de60bee9ae8
Version Independent ID: e0c09794-e712-19ff-cb9f-12648d60d4f6
Content: Asynchronous programming in C#
Content Source: docs/csharp/programming-guide/concepts/async/index.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thank you for opening this issue. I'll get this fixed up.
Thanks again!


Forgot to fix the commnads.py file

This file had a few clauses and edge cases where certain commands and things did not work. I need to add test cases to prevent things like this from happening

Commands can now be easier to make, you dont need to include "client" inside each of the functions parameters. The check_command function now has control over checking for you


⚠ Bofrost.it has degraded performance

In f9f77e3, Bofrost.it (https://www.bofrost.it) experienced degraded performance:

HTTP code: 200
Response time: 3291 ms

Resolved: Bofrost.it performance has improved in 466a53b after 7 minutes.


🐳 Fix docker-things

Remove poetry.lock from .dockerignore
Add optional dependencies named pro
Add link to DockerHub in README.md

Codecov Report

Merging #13 (5b256e3) into master (3e34c64) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        14
  Lines          385       385
=========================================
  Hits           385       385

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Deserialization things

add to public API: consume_length and consume_prefix to have less code duplication in kms
remove explicit return statements: src/encoding.rs
rustfmt on amino-derive/src/lib.rs
authors

Looks great

Thanks for the review :-) You need to approve the changes, so that I can merge.

circleci seems stuck :-/ closing and reopening to trigger build

Ah OK. That's annoying: https://circleci.com/docs/2.0/workflows-waiting-status/


Images interoperability issue between hosted parse and S3 hosting

Check out this issue for an ideal bug report. The closer your issue report is to that one, the more likely we are to be able to help, and the more likely we will be to fix the issue quickly!
For implementation related questions or technical support, please refer to the Stack Overflow and Server Fault communities.
Make sure these boxes are checked before submitting your issue -- thanks for reporting issues back to Parse Server!

[x] You've met the prerequisites.

[x] You're running the latest version of Parse Server.

[x] You've searched through existing issues. Chances are that your issue has been reported or resolved before.

Environment Setup

Set up S3 to host your app's image.
Run the latest parse-server.
Create a web app pointing to the parse-server.
Store images using PFFile and parse-server.

The images could be stored in a class in two ways
A. as a field in the class
B. in an array field in the class.
If PFFile is stored in a field in a class, it only contains the image name, but if it is stored as an array in a field, then it contains the url also.
Interop Problem 1.
The users who are using an app that is still pointing to hosted parse api server, are not able to see the S3 image for option A above. This is because hosted parse returns the url prefixed with files.parsetfss.com + <name_of_the_image.jpeg>. However, they are able to see the images which are stored in an array field as it contains the full url of the images (option B above).
Interop Problem 2.
The users who are on the app pointing to parse-server are not able to see the images stored as option A by hosted parse because not all the images start with the name "tfss-". Parse-server returns the constructed url as if it was stored in S3. Users are able to see the images stored as in option B.

Closing as duplicate of #8


fix update-pipeline-service

Improper ordering of 2 function calls was triggering an 'unbound variable' error
Signed-off-by: Romain Arnaud<EMAIL_ADDRESS>

/retest


Let network module handle ipv4 and ipv6 simultaneously

I often switch between networks that use either IPv4 or IPv6.
As the network module supports IPv4 or IPv6 (but not both at the same time) I currently need to add two instances of the network module to my config and explicitly set the family to "ipv6" for one of them.
This PR makes the network module able to handle both IPv4 and IPv6 simultaneously. It is enough to have a single instance of the network module that handle both protocols and the family doesn't have to be specified. This is a bit simpler and probably what most users would expect.

Thanks!


Follow symlinks when loading models.

Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

@freemanliu
Thanks a lot for your contribution. Without contributions like yours it'd be impossible to keep DJL going with the high standards.


Benchmarking

Rough benchmarking on trivial hello world, a simple point of comparison.
Requires #9.

Closing in favour of #18


onShrink attempted on undefined object

During certain manual stress tests, I ended up with the following error.
main.9f41ae4….js:16 Uncaught TypeError: Cannot read property 'onShrink' of undefined
Unfortunately, it was a production system I was testing, so I just narrowed it down to this library, and the location of the minimized code looks something like this:
O(w,"scroll",function(){c(e).onShrink&&c(e).onShrink()})}
which leads to this line on the scroll detection strategy file: https://github.com/wnr/element-resize-detector/blob/master/src/detection-strategy/scroll.js#L370
So, probably a scroll event executed even the element's state is invalid. I'm unsure on when exactly that happened, due to the nature of my tests. However, I'm certain enough to file this issue (I'm using the resizer at only one point in the whole application, and it properly disposes of its resources, so its not from the app directly, but just likely just sets it up for this bug).

Hi, and thanks for the report.
It seems to me that the state property of the element has been manually removed, which results in that when the scroll event is executed the element._erd property is missing. Perhaps your app is altering the element in some way that removes the property?

Hi. That makes sense.
My component was rendered using React, and once rendered the scroll sensor is initialized and disposed off as necessary as it updated. However, only later did I realize I had an edge case, where the resize sensor was setup in a nested component deeper down the tree which was managed by another react component. So, as the inner one updated, it re-rendered the tree which constituted of the sensor, causing the problem.
My bad. Thanks for your time pointing me in the right direction! :)

Okay, great :) No problems, I'm happy to help.


Restore remap_boxes function

Bug description
Following #731, the function remap_boxes and its associated test test_remap_boxes that were introduced in #488 were removed. This prevents the correct remapping of the boxes after they were rotated (parameter straighten_pages of OCRPredictor set to True).
Code snippet to reproduce the bug
from pathlib import Path

import matplotlib.pyplot as plt

from doctr.io import DocumentFile
from doctr.models.detection.zoo import detection_predictor
from doctr.models.predictor import OCRPredictor
from doctr.models.recognition.zoo import recognition_predictor
from doctr.utils.visualization import visualize_page

file = Path(r"myfile.jpg")

doc = DocumentFile.from_images(file)
det_bs=2
reco_bs=128

det_predictor = detection_predictor('db_resnet50', pretrained=True, batch_size=det_bs, assume_straight_pages=True)
reco_predictor = recognition_predictor('crnn_vgg16_bn', pretrained=True, batch_size=reco_bs)

predictor = OCRPredictor(det_predictor=det_predictor, reco_predictor=reco_predictor, assume_straight_pages=True, straighten_pages=True)

# Plot OCR output
out = predictor(doc)

fig = visualize_page(out.pages[0].export(), doc[0], interactive=False)
plt.show()

Error traceback
No error, however, the boxes that appear are misplaced.
Environment
Note: I pulled the last version from the repo but the DocTR version still appears as 0.4.1a0.
DocTR version: 0.4.1a0
TensorFlow version: 2.5.0
PyTorch version: 1.9.1+cpu (torchvision 0.10.1+cpu)
OpenCV version: 4.5.2
OS: Could not collect
Python version: 3.8.7
Is CUDA available (TensorFlow): No
Is CUDA available (PyTorch): No
CUDA runtime version: 11.0.221
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\bin\cudnn_ops_train64_8.dll

Hi @Rob192,
Thanks for opening the issue :pray:
So I suggest doing the following in a PR:

starting by designing a relevant unittest where we mock a white page with only a few lines (easy)
we rotate this page, and we create a unittest where passing this image to estimate_orientation should yield the rotation angle with some margin (I think this is already setup)
now we need to add almost the same test, with either light random or pretrained predictors with the straighten_pages option.

This should produce an error according to what you say. So then, in the same PR, we try to fix this so that it works :+1:
What do you think @Rob192? :pray:

Hello @fg-mindee
Sounds good !

Alright! I won't be able to take a look at this before at least next week, but I consider this to be mandatory for the v0.5.1 patch release. Do you think you could work on PR in the coming days? :pray:
No problem if you can't, we'll postpone the patch release in that case!

Hi @fg-mindee, I was busy these past days, I could not get back to you earlier. I pushed the PR #812 to fix this issue !


Crash in the Intel OpenGL driver on Linux/Ubuntu

Sorry to interrupt, but after I entered the following codes as instructed
python3 -m motion_imitation.examples.test_env_gui --robot_type=A1 --motor_control_mode=Position --on_rack=True"
The UI comes out but the terminal comes out the following codes:
workaround for some crash in the Intel OpenGL driver on Linux/Ubuntu
And after a while, the UI crashed.

Update driver or buy a new GPU. The essential log info is missing too, about GPU.

Update driver or buy a new GPU. The essential log info is missing too, about GPU.