Netstandard 1.0 PCL (classic) cannot add P2P ref to cross-compiled CPS proj

I have a "classic" PCL project that targets netstandard1.0 and has a project.json. When I try to add a P2P reference to a "modern" cross-compiled project that also has a netstandard1.0 target, I get an error.

Manually adding the p2p ref in code has a compile time failure:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.Sdk.Common.targets(70,5): error : Project 'C:\dev\Zeroconf\Zeroconf\Zeroconf.csproj' has no target framework compatible with '.NETPortable,Version=v5.0'.

This also happens when trying to add a P2P ref from a WP8 Silverlight project to the same cross-compiled lib. Do you want a new issue or attach it to this one?

Single issue is fine.

Okay, cool.
So if I add it manually to the WP8 SL project, I get a different compile time error:
2>Skipping target "GenerateTargetFrameworkMonikerAttribute" because all output files are up-to-date with respect to the input files.
2>CoreCompile:
2>  C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\csc.exe /noconfig /nowarn:1701,1702,2008 /nostdlib+ /errorreport:prompt /warn:4 /define:DEBUG;TRACE;SILVERLIGHT;WINDOWS_PHONE /errorendlocation /preferreduilang:en-US /reference:C:\Users\oren\.nuget\packages\WPtoolkit\4.2013.8.16\lib\wp8\Microsoft.Phone.Controls.Toolkit.dll /reference:C:\Users\oren\.nuget\packages\System.Reactive.Core\3.1.1\lib\netstandard1.0\System.Reactive.Core.dll /reference:C:\Users\oren\.nuget\packages\System.Reactive.Interfaces\3.1.1\lib\netstandard1.0\System.Reactive.Interfaces.dll /reference:C:\Users\oren\.nuget\packages\System.Reactive.Linq\3.1.1\lib\netstandard1.0\System.Reactive.Linq.dll /reference:C:\Users\oren\.nuget\packages\System.Reactive.PlatformServices\3.1.1\lib\netstandard1.0\System.Reactive.PlatformServices.dll /reference:C:\dev\Zeroconf\Zeroconf\bin\Debug\netstandard1.0\Zeroconf.dll /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.CSharp.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.Devices.Sensors.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.Phone.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.Phone.Interop.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.Phone.Maps.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.Phone.Reactive.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.Xna.Framework.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.Xna.Framework.GamerServices.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.Xna.Framework.GamerServicesExtensions.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.Xna.Framework.Input.Touch.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\Microsoft.Xna.Framework.MediaLibraryExtensions.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\mscorlib.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\mscorlib.extensions.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Collections.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.ComponentModel.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.ComponentModel.EventBasedAsync.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Core.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Data.Linq.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Device.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Diagnostics.Contracts.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Diagnostics.Debug.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Diagnostics.Tools.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Dynamic.Runtime.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Globalization.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.IO.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Linq.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Linq.Expressions.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Linq.Queryable.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Net.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Net.NetworkInformation.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Net.Primitives.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Net.Requests.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.ObjectModel.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Observable.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Reflection.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Reflection.Emit.IlGeneration.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Reflection.Emit.Lightweight.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Reflection.Extensions.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Reflection.Primitives.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Resources.ResourceManager.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Runtime.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Runtime.Extensions.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Runtime.InteropServices.WindowsRuntime.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Runtime.Serialization.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Runtime.Serialization.Json.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Runtime.Serialization.Primitives.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Runtime.Serialization.Xml.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Runtime.WindowsRuntime.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Security.Principal.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.ServiceModel.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.ServiceModel.Http.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.ServiceModel.Primitives.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.ServiceModel.Security.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.ServiceModel.Web.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Text.Encoding.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Text.Encoding.Extensions.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Text.RegularExpressions.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Threading.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Threading.Tasks.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Windows.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Xml.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Xml.Linq.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Xml.ReaderWriter.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Xml.Serialization.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Xml.XDocument.dll" /reference:"C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\WindowsPhone\v8.0\System.Xml.XmlSerializer.dll" /reference:"C:\Program Files (x86)\Windows Phone Kits\8.0\\Windows Metadata\Windows.winmd" /debug+ /debug:full /optimize- /out:obj\x86\Debug\ZeroconfTest.WP.dll /ruleset:"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Team Tools\Static Analysis Tools\\Rule Sets\MinimumRecommendedRules.ruleset" /resource:obj\x86\Debug\ZeroconfTest.WP.g.resources /resource:obj\x86\Debug\ZeroconfTest.WP.Resources.AppResources.resources /target:library /utf8output App.xaml.cs LocalizedStrings.cs MainPage.xaml.cs Properties\AssemblyInfo.cs Resources\AppResources.Designer.cs C:\dev\Zeroconf\ZeroconfTest.WP\obj\x86\Debug\App.g.cs C:\dev\Zeroconf\ZeroconfTest.WP\obj\x86\Debug\MainPage.g.cs "C:\Users\oren\AppData\Local\Temp\WindowsPhone,Version=v8.0.AssemblyAttributes.cs" obj\x86\Debug\\TemporaryGeneratedFile_E7A71F73-0F8D-4B9B-B56E-8E70B10BC5D3.cs obj\x86\Debug\\TemporaryGeneratedFile_036C0B5B-1481-4323-8D20-8F5ADCB23D92.cs obj\x86\Debug\\TemporaryGeneratedFile_5937a670-0e60-4077-877b-f7221da3dda1.cs
2>  Using shared compilation with compiler from directory: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin
2>C:\dev\Zeroconf\Zeroconf\Zeroconf.csproj : error MSB4057: The target "GetPackagingOutputs" does not exist in the project.
2>
2>Build FAILED.
2>
2>Time Elapsed 00:00:00.70
========== Build: 1 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

@onovotny Is there anything blocking you from migrating the classic PCL project which targets .NET Standard to a .NET SDK project that targets .NET Standard?

@srivatsn You'll probably want two issues, two different code paths and two different changes.

There's 4 bugs in this issue really, all with different changes - @srivatsn I think we'll want to represent that, and then tag them as blocking end-to-end.

@dsplaisted I tried that but then hit a different regression where the path to csc wasn't found. @kzu

sorry, hit the wrong button!

I've submitted a fix for the portable block. We no longer block in this case, and let the reference succeed to fall back to the normal p2p checks during design-time builds/builds.
I've filed: https://github.com/dotnet/roslyn-project-system/issues/1463 to track the warnings that I see when we let this reference succeed.
@onovotny There is no WP8 SL project in VS 2017 - did you file that above before we pulled it?

@davkean In GitHub.com/onovotny/zeroconf, the dev branch, there's a ZeroconfTest.WP project that's WP8 SL. It may not have full editors, but it definitely still compiles by using the language targets.
I'm still seeing that issue with GetPackagingOutputs on it.

Split out the WP8 issue and closing this out since both the PCL ref and build issues have been fixed.

@srivatsn I'm seeing the same error from a UWP project (No GetPackagingOutputs in the P2P references) but don't see an associated issue. Is that ultimately related to these, or should it file separately?

There's another report of this in a muli-targeted project. We are tacking that with https://github.com/dotnet/sdk/issues/707

The reference works now but I get build failures:
https://github.com/dotnet/sdk/issues/879


Clarify some definitions

While reading through the definitions collection, I came across some parts that need clarification. Since, after personal discussion with @bogovicj, it wasn't immediately clear to us how to resolve these issues, I'm opening them up for general discussion:

What is meant by "linear measurements" in the definition of "field of view".
I appreciate that the definition of "image" is more general than "a collection of pixels". However, I don't quite get the example of a "set of solutions for a discrete function".
In the second part of the definition of "origin", the "origin of an image" seems to be a specific point in the physical domain that is tied to the underlying data representation of the image. Given that an image doesn't have to be an array and "origin in the physical domain" is a different (and arbitrary) concept, is it worthwhile to define "origin of an image" at all?

I'd like to loop in @virginiascarlett too.

after some thought, we might change "linear measurements" with "physical distance", or "physical extents" which is what I think we meant and may be clearer (let me know).
I often like to think of an image as a function whose inputs are ordered tuples of non-negative integers and whose outputs are something (numbers, colors, vectors, whatever).  Having a short phrase that expresses this, would be nice.
Good point. What I wrote and was thinking of might better be called "offset" or something similar. I'd like to communicate is that many images have the origin of their array correspond to a point that is not the origin of the physical domain.  Maybe a definition is not the place for this, especially if there isn't consensus about what "origin" means in software.  On the other hand, maybe we can just be clear about what we mean by it.  I'll think on this some more.

I'd like to relax the definition of sample. Specifically, "a measurement of the energy sensed by a particular cell on a sensor" is too specific, in my opinion.  I do like that text as a description of how many image samples are acquired though. Important points: it is the value at a single infinitesimal point. I'm having trouble saying what it's a value of though. A (continuous) function (too general?), an image (risk being circular?).  I will need more thought and your all's ideas.

Ad 4: I like the definition of sample being tied to the actual creation of the data, but it seems that all your suggestions have a particular application in mind. What about "the smallest subunit of data acquisition, e.g., the energy sensed by a particular cell on a sensor"?
I'm not familiar enough with all the methods of data acquisition, but this would also cover output of post-processing steps (e.g., a single location from a superresolution image).

Thanks for a productive chat today over coffee. ☕ On second thought, you're right, we should create a PR so we can see the diffs. I see Michael already has a restructure-definitions branch, and it feels messy to me to create yet another branch for definitions... what's the deal with that branch? Maybe you could create a PR, Michael? 🙏
Here's what I have now:
Field of view: The physical extent of the observed space. In microscopy, FOV may be expressed as the diameter of the circular view seen through the eyepiece. In scientific bioimaging, FOV is typically expressed as the horizontal, vertical, and/or diagonal extent of the space captured by the digital sensor. For example, the FOV for a 2D image may be 44mm by 22mm, where 44mm is the length and 22mm is the width of the observed space.
Image: A set of numbers intended to be displayed on a screen. It is also a set of values, each of which is associated with a position in a domain. Ancillary data structures may be required to display or interpret an image (such as a lookup table), but these are not part of the image itself. An image is often, but not necessarily, acquired by a sensor situated within an optical system. Images can be represented in compact forms, for example as a compressed sequence of bytes or as a discrete function over a finite domain, but these are not canonical uses of the word “image”, and the word “image” by itself typically refers only to arrays and array-like data structures.
Origin: A special location that acts as a reference point, relative to which other locations are defined. Unless otherwise specified, the image's origin is the same as the array's origin (assuming the image is an array). An array's origin is typically the point in the discrete domain with the minimum index (usually zero) for all dimensions. Physical or anatomical spaces can also have origins; for example, in MR imaging, the anterior/posterior commissure is commonly regarded as an origin for the brain.
The term "offset" is sometimes used to refer to the origin.
^Note: Say something about a crop of an image?
I'll reach out to you about another chat ☕ so we can review these and discuss 'sample'.

Side note: The Nyquist-Shannon Sampling Theory is commonly misinterpreted and misapplied. Often, microscopists may say things such as "my microscope has a resolution of 200 nm so I need to have a pixel size smaller than 100 nm". The problem is that Shannon in "Communication in the Presence of Noise" refers to ideal periodic signals where it makes sense to capture acquire equispaced samples just beyond the "Nyquist Limit" (e.g. 100 nm in the example above). Equispaced samples only make sense in the context of periodic signals. Also the presence of noise increases the need for additional samples beyond the "Nyquist sampling".
For bounded signals (e.g. images with a field of view), we need more samples located near the boundary of the the signal than in the center of the signal. Practically, we also need to sample at least 3x the band limit frequency, and I would argue we need about 6x the band limit for equispaced samples.

As discussed, I created a PR (#11), which will receive updates as this discussion progresses.
Thanks, @mkitti for that insightful comment! I agree that it seems we ran into the terrain/map issue. Part of the reason why is that we are still not sure about the scope of these definitions, I believe.
Ultimately, these definitions should provide an umbrella-framework for the multiple different data formats we encounter in the wild. From this point of view, maybe a sufficient definition of image is, in fact, "an array with metadata about acquisition and/or visualization". This would allow us to clearly separate the two notions:

We define all the terms (except image) in terms of physical quantities to develop a clear domain language;
Every data format can then be described by how it relates those physical quantities to arrays by means of its metadata.

In this context, your comment would be a very good starting point for developing such a domain language.

Thanks @mkitti !
Regarding the definition of image, adding clarifications for discrete
/ digital and continuous images will be important.
It's not totally clear to me how to modify the definition based on your comment,
but it sounds like you'd want image to mean only (?) an (idealized)
continuous signal; suggesting that the sampling of it is "just" some
re-presentation of it. My strong preference would to be permissive in
the definition both because (these days) the common usage of the term
refers to digital images (collections of samples), and because the usage
in the standards documents here will most often refer to the digital
images. As well, that might seem to readers to imply that discrete
representation as "second-class" somehow, and I'd like not to give
readers that perception.
In my view, these definitions have two purposes:

Define (more or less formally) these terms in the context of data standards and
specifications in this repository, specifically.  (i.e. image means
"X" when you see it in one of the standards documents).
Relate those formal definitions to the common, informal usage a typical user
or developer may encounter in a textbook, software documentation,
discussion with a practitioner.

We should discuss these.
Because these documents are primarily about storing images as files on
computers, they will be about digital images. I expect most
occurrences of "image" in the documents we write will refer to digital
images on regular grids, and having the primary definition refer
to exactly that will be good.
However, because of purpose (2), it will be valuable to have definitions
and/or discussions relating to image reconstruction and how that relates
to sampling + the Nyquist limit. I've been avoiding those terms...
It would be really great if you're willing have a go at writing some definitions
on those topics!
One last thing:

Both a digital array and film are representations of the image but is not the image itself.

I would have phrased this:  "Both a digital array and film are images but not the physical object itself."

If have one sampling of an image and I know the point spread function, could then upsample or downsample the image without aliasing. Are the resampled arrays new images in and of themselves or are they just new representations of the same image?

A high resolution image will have more samples than a low resolution image for the same field of view.

This statement is problematic. A low resolution image could have as many samples as a high resolution image if it were oversampled.
A high resolution image requires more samples than a low resolution image in order to faithfully retain the information ("level of detail") within, but otherwise the relationship between resolution and the number of samples is no direct. I can increase the number of samples all that I want, but it will not actually increase the resolution of the image.

"resolution" is used in confusing ways  -- colloquially, we use it to describe the sampling density of a measurement but as Mark notes, in signal processing terms a signal's resolution is determined before you sample it. You can acquire a trillion samples of a defocused optical image, but the result will still be defocused (i.e., low resolution).
I would suggest we avoid using the word "resolution" to describe the number of samples in an image. We have other ways to describe this property. Like the word "pixel", we should probably note that there is a colloquial use of the term, but also note that such usage is potentially confusing and should probably be avoided wherever possible.

As a practical consideration, how do we incorporate microscopy data that is not primarily described by an array of pixel values?
Data from Single Molecule Localization Microscopy (SMLM) is often given as a series of points. Examples of SMLM include PALM, STORM, PAINT, and MinFlux.
Combined with a radial basis function, these could be rastered as an array of pixel values, but that is not their primary representation. Does our definition of "image" require this kind of data to be rastered in order to become an "image"?


Rewrite

Goal: Change Imperium so that it's not like CRA, but just another library.
This means there will have to be SOME boilerplate to copy into the main app.
We need to reduce this boilerplate as much as possible, moving the code into
proper packages under @imperium prefix.
Tech:

Typescript
Babel
Eslint
Cluster with node workers

Server

Cluster processes
Create connectors (defined elsewhere)
Load server modules
Create express app
Express middleware setup
Express endpoints
Default endpoint serves HTML <---- remove this, server HTML statically (production, anyways)
Module startup

In development, we want the client to use HMR in some way. This doesn't have to be run from the server process anymore. I guess we can either make a development node server that just serves up the client, or even use a combination of ready-made tools like webpack-hmr.

Auth
Imperium package should not have any UI. It should have server/client code that can be called for auth, but not actually provide any UI.


iOS: Use force ratio instead of absolute force.

https://getsatisfaction.com/newsblur/topics/swiping-on-images-brings-up-image-menu-sometimes

Thanks for looking into this!


Added options to render Axes, bounding cube, colored plate

Related to Issue #62

@thehans closed this. why? the changes look interesting.

There is a kind of delay including small improvements due the new csg.js integration; the general settings (like size of plate, colors, position of editor, and axis rendering) I started in index.html (commented out), but will come, then @thehans change(s) can be integrated.


Question about PartiPrompts

Hey,
I was just going over the annotated PartiPrompts data you've uploaded, and had a hard time figuring out the exact structure.
Could you please describe what the different attributes here mean? I assume the prompt basically means the caption corresponding to the images shown.
Prompt	Category	Challenge	Note	Decisions
bond	Abstract	Basic	Biology-inspired concepts with multiple meanings	ret,gen,gen,same,gen
element	Abstract	Basic	Biology-inspired concepts with multiple meanings	ret,ret,ret,ret,same
molecule	Abstract	Basic	Biology-inspired concepts with multiple meanings	gen,gen,gen,gen,gen

Another related question is: Can we access the exact images that the human annotators saw while making the decisions? i.e. from the paper Fig. 9, it seems like you've collected text-image alignment and fidelity ratings from annotators for each pair of images, is the raw pairwise preference data public (with both annotations)?

Thanks, we've added more details here in the README about the structure. It is the same structure as the original PartiPrompts dataset, but we add a column with human annotations indicating whether they preferred the retrieved or generated images.

is the raw pairwise preference data public (with both annotations)

We've uploaded the annotations for the realism/fidelity setting here.

Can we access the exact images that the human annotators saw

Unfortunately we will most likely be unable to release the exact images used because there are some prompts involving humans, and we are also unable to distribute CC3M images. The generated images can be reproduced by running the PartiPrompts through Stable Diffusion v1.5 and the retrieved images can be acquire by using CLIP ViT-L to retrieve the closest image in CC3M (details in Sec 3.3 of the paper).
Hope that helps!

I see, thanks @kohjingyu that helps. For the generated images being as close as possible to the ones you'd have likely shown to the users, could you please provide the exact StableDiffusion configuration you used i.e. text guidance, random seed, number of diffusion steps etc.
Thanks again! :)

I've uploaded the Stable Diffusion script here. Hope that helps!

Awesome, thanks so much!


8th release organ icons

Design work in progress
@u-p-design to add 3 new organ icons for the 8th release:

sternum
manubrium
renal pelvis

Figma Design System Repo Components

Organ icons
Branded organ icons

@bherr2 @axdanbol - Please see the old style cards with the icons/text here for the new organ icons: https://www.figma.com/design/TtpcTcJNLCxAQiNb2wOA2s/HRA-2022-2024-(HuBMAP-Styles)?node-id=6379-16561&t=XUBjnQHDLjmJ8wA3-4


Update windows-sys to 0.42

windows-sys 0.42 has some fixes required for us to build for rust+mingw on arm64. It would be nice if this new version would be adopted if possible :)

Published parking_lot_core 0.9.4.

Thanks!


Treeview Opacity not working

The treeview stays opaque when the editor is started/restarted. It does work when I disable and then enable the package.
It also turns opaque when focused.
I disabled all other packages and tried restarting Atom, in various orders with the same result, so there seem to be no conflicts. It only works when I disable and enable this package.

Me too. under Ubuntu 14.04

Add this to styles.less:
.atom-dock-mask {
  background-color: transparent!important;
}

Seems like the package isn't being maintained anymore @Illyasviels, since there haven't been any updates in 2 years.

But it can still use...
I use this package and style.less to make atom more beatiful
.tree-view {
  // background-color: whitesmoke;
  background-color: rgba(33, 37, 43, 0.18)!important;
}

// style the background and foreground colors on the atom-text-editor-element itself
atom-text-editor {
  // color: white;
  // background-color: hsl(180, 24%, 12%);
}

// style UI elements inside atom-text-editor
atom-text-editor .cursor {
  // border-color: red;
}

.atom-dock-mask, .terminal-view .standard {
  background-color: transparent!important;
}

.panel-bottom, .panel-footer, .status-bar {
  background-color: rgba(33, 37, 43, 0.18)!important;
}

.tab-bar {
  background-color: rgba(33, 37, 43, 0.36)!important;
  .tab {
    background-color: transparent!important;
  }
}

.settings-view {
  background-color: rgba(33, 37, 43, 0.64)!important;
  * {
    background-color: transparent!important;
  }
}

.scrollbars-visible-always ::-webkit-scrollbar {
  width: 8px!important;
  height: 8px!important;
}
.scrollbars-visible-always atom-text-editor ::-webkit-scrollbar-track {
  background: transparent!important;
}
.scrollbars-visible-always atom-text-editor ::-webkit-scrollbar-corner {
  background: transparent!important;
}
.scrollbars-visible-always atom-text-editor ::-webkit-scrollbar-thumb {
  border-color: rgba(40, 44, 52, 0)!important;
  background: rgba(75, 83, 98, 0.36)!important;
}

Didn't meant to say this can't be used, just that sadly it seems it isn't being actively developed.


⚠ ClamAV has degraded performance

In 617146e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 64 ms

Resolved: ClamAV performance has improved in 8999f2e.


Linked Map - map pin property causing cyclic dependency.

Describe the bug
A cyclic error occurs when linking a map via linked map pin properties. This happens when the Map has a pin that tries to load itself which confuses the engine. More explanation :- Video by Godot tutorial explaining this. Apparently it only happens when loading something. The already cached will work normally without any error.
To Reproduce
Steps to reproduce the behaviour:

Select any map
Right Click → New → Pin (new pin will be added to the map)
Select the current map
Right Click → go to map (to check if it's working)
Exit
Reopen the app

Expected behaviour
The app should just open normally and does not cause any error

Well looks like removing the ability to assign itself as a linked map was enough to fix the problem.


Consider basing some images on adoptopenjdk instead of openjdk

The AdoptOpenJDK OpenJDK distribution gives me noticeably (30% ish) better performance out of the box with my Clojure application, and includes Shenandoah, which Oracle refuses to enable in the default build. In addition, AdoptOpenJDK has slim alpine images.
The one gap between them is, right now, the lack of an OpenJDK 15 distribution on AdoptOpenJDK, and some of the base distribution options are considered "unofficial".

I think this situation has changed since this issue was opened. OpenJDK 17 has shenandoah, is the new LTS (and will soon be our default jdk version), AdoptOpenJDK is itself undergoing a big transition to the Eclipse Foundation w/ lots of renaming etc., and the debian slim variants have largely covered the alpine use cases.
I think given all of the above and the lack of other requests for this, I'm included to close this.

Yeah, I think that in practice, when this matters, you'll be shipping an uberjar in the image, so you can use any base image you want.

we're now on Temurin (rebranded adoptopenjdk)


Notification via email, error at delivery

Laravel Version: 8.21.0
PHP Version: 7.4.13
Database Driver & Version: MariaDB 10.3.25

Description:
I need to send notifications through email, I queued those notifications, and then the job is dispatched without exceptions, but the email never arrives to another domain (gmail.com, outlook.com), not even in junk folder.
I think is due a lack of HELO field in queued emails, because it arrives if the recipient is in the same domain, and this is the difference between queued, and sync emails.

Email sent with queue=sync

Email sent with queue=database
Steps To Reproduce:
Send email notification with and without queue, compare
Template to reproduce
https://github.com/halivert/email-test

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

Hi Dries,
Maybe I didn't use the correct description
I think the issue is in the queue worker, it didn't cache correctly (or something like that) the HELO field to use in the queued notifications.
I don't know the reason of the difference between sync notifications having correct HELO and queued not.
Greetings and thank you so much for your time

Hi Dries,
Maybe I didn't use the correct description
I think the issue is in the queue worker, it didn't cache correctly (or something like that) the HELO field to use in the queued notifications.
I don't know the reason of the difference between sync notifications having correct HELO and queued not.
Greetings and thank you so much for your time

Update
It was, indeed, caused by HELO field.
Searching in swiftmailer docs and laravel source code I found that you need to specify config.mail.local_domain key if you want to preserve HELO in queued mails in a daemon queue.

Update
It was, indeed, caused by HELO field.
Searching in swiftmailer docs and laravel source code I found that you need to specify config.mail.local_domain key if you want to preserve HELO in queued mails in a daemon queue.


[VSCode] Live share icons need love

Hi VScode dev here,
Platform independent

VSCode, install live share extension
Open the live share view in the sidebar, notice how the icons look like as if they were designed for Visual Studio and reused in Visual Studio Code. They are completly out of style with the rest of VSCode icons
When I say out of style I mean in color, thickness and detail

fyi @misolori
@jramsay I have created a couple of issues in your repository based on my usage of your extension. Hope you find it useful

@isidorn Hey! I'd love to understand how we could ensure our iconography is more inline with VS Code styles. We actually took some inspiration from the Azure Functions and Azure App Service extensions, both of which have accent color in their icons (e.g. notice the green plus sign next to the lightning bolt). I'll sync up with our UX lead to see how we might be able to improve our icon set. Thanks for the feedback!
Live Share

Azure Functions

Azure App Service

Closing this per my previous comment, and the fact that the icons are generally inline with other VS Code extensions.


Question : Setting up Prometheus (dockerized) to monitor OpenVPN clients

What did you do?
Setup prometheus / alertmanager in their docker containers on a user defined bridged network.
Works fine to monitor assets that are running on the hosts / reachable via the internet.
I'm hoping for some guidance on how such a setup could work to monitor OpenVPN clients connected via a tun+ interface (either directly on the host, or via another docker container on the same network).

The idea is to monitor external devices (that expose prometheus metrics) that connect to the OpenVPN.
I've asked a more generic question (not involving Prometheus, as I assume this has nothing to do with Prometheus itself) on superuser.
If somebody has some pointers on how to get this up and running I'd be happy to write up a blog post on how such a setup could work.

Are you wondering how best to discover the service, route traffic to it, or perhaps how you might get metrics from it @grobie?

Please send questions to the prometheus-users usergroup https://groups.google.com/forum/#!forum/prometheus-users instead.


Set two csp headers (enforced and report only)

Is there a way using secure headers, to set both an enforced and report only header? A lot of people might want to do this in order to experiment with a different policy configuration and see what violation may occur before actually enforcing it.

`secure_headers

secure_headers provides classes for generating headers based on configs. However, there isn't a way to do this with just config.
response.headers["Content-Security-Policy"] = ContentSecurityPolicy.new(config, user_agent).value

I think this would be a great addition.

I think adding something like this would work well:
SecureHeaders::Configuration.default do |config|
  config.csp = { default_src: 'self' ... }
  config.csp_report_only = { default_src: 'none' ... }
end

I was just thinking about this. Specifically, should there be a flag to indicate which policy the override is meant for (that defaults to both)?
SecureHeaders::Configuration.default do |config|
   config.csp = {
     default_src: ['none'],
     script_src: %w(example.com anotherexample.com)
   }

   config.csp_report_only = config.csp.merge {
     script_src: %w(example.com) # more restrictive, fewer hosts
   }
end

Somewhere in a controller...
append_content_security_policy_directives(:script_src, ['thirdparty.com'], :enforced)
override_content_security_policy_directives(:script_src, ['none'], :report_only)

Would result in
Content-Security-Policy: default-src 'none'; script_src example.com anotherexample.com thirdparty.com
Content-Security-Policy-Report-Only: default-src 'none'; script_src 'none'

fyi there's a PR for this https://github.com/twitter/secureheaders/pull/281


use r0 by default for classic connection requests

I don't remember why this was set as r2 by default, but r0 is a better default, as it will connect better/faster.
(a future PR should allow this to be customized of course)

Actually, by experience using R0 will result in far more page timeouts. I need to find the reason why since I don't quite remember! Let me check the spec

Ok it depends on the page scan activity of the remote device:

R0 listens continuously, the initiator will not miss it
Listen every 1.28s, the initiator can miss it if it uses R0
Listen every 2.56s, the initiator can miss it if it uses R0 or R1

Since we don't know the peer device, the safer mode is R2 which is more aggressive. But I don't think it will be slower 🤔


Fixes to compile under Win64 with VS2013

All this does is add a bunch of casts to resolve templates that otherwise fail to resolve when compiling with VS2013 under Windows when running in a 64-bit environment.

Superceded by #45 I believe.


chore: prepare release manifests

Signed-off-by: iam-veeramalla<EMAIL_ADDRESS>What type of PR is this?

/kind chore

What does this PR do / why we need it:
Prepares release manifests for v0.5.0
Have you updated the necessary documentation?

[x] Documentation update is required by this PR.
[x] Documentation has been updated.

How to test changes / Special notes to the reviewer:

The only failing test is --- FAIL: kuttl/harness/1-021_validate_notification_controller (322.46s)
Ignoring, it as a known issue.


Incorrect generated enum values in TS model

Describe the bug
The java enum is:
public enum TYesNo {

    ДА("\u0434\u0430"),

    НЕТ("\u043d\u0435\u0442");

    private final String value;

}

This is generated TS class:
enum TYesNo {
    ДА = "\u0414\u0410",
    НЕТ = "\u041D\u0415\u0422"
}
export default TYesNo;

As you can see, unicode values are different.
Expected-behavior
Unicode values from java and TS  should match
Reproduction
above
System Info
Hilla 2.2.2

This is an expected behavior. Currently, the generator accepts only the name of the enum variant but not its value. The reason is that the value type in Java can be anything while the TypeScript enum supports only strings and numbers.
For your case, since the difference is only in the letter case, I would suggest to use TYesNo.ДА.toLowerCase(). Another possible workaround is to use a map with correct values along with the enum or instead of it.


GC+: Committed and Uncommitted listing do not skip external addresses

Uncommitted GC will only cleanup objects in the storage namespace. Committed & uncommitted data frames should not include external (imported) addresses.

Uncommitted will be filtered on the server side.
Committed will be filtered after it was read from the committedDF.


Interactive Modal using Pan crashes on Dismiss

Hi,
Great library.  I'm trying to do a simple interactive modal transition.  I'm using PanInteractionController(forModalTransitionsAtEdge...) and the TransitionController(forInteractiveModalPresentationsFrom...) to setup the interactionController and transitionController.  Presenting works fine.
When I try to dismiss the view by flicking upwards, I get "fatal error: unexpectedly found nil while unwrapping an Optional value" in "UIViewControllerContextTransitioning+Properties.swift".  Basically "toView" is nil here:
        case .dismiss:             if toView.superview == nil {                 containerView.insertSubview(toView, belowSubview: fromView)             }
Is this an issue, or am I not setting up the transition controller correctly.
Thanks.
Jan-Michael
PS: Here's the code to produce the issue.  The StickerViewController is just a view with a UILabel.
import UIKit
import Transition
class ViewController: UIViewController
{
private(set) var transitionController: TransitionController!
private(set) var interactionController: PanInteractionController!
fileprivate weak var stickerViewController: StickerViewController?

override func viewDidLoad()
{
    super.viewDidLoad()
    self.view.backgroundColor = UIColor.red
}

override func viewDidAppear(_ animated: Bool) {
    super.viewDidAppear(animated)

    if interactionController == nil
    {
        self.interactionController = PanInteractionController(forModalTransitionsAtEdge: .top)
        self.transitionController = TransitionController(forInteractiveModalPresentationsFrom: self, transitionsSource: self, interactionController: interactionController)
    }
}

override func didReceiveMemoryWarning() {
    super.didReceiveMemoryWarning()
    // Dispose of any resources that can be recreated.
}

}
extension ViewController : TransitionsSource
{
// proivide transition for presentation / dismissal
func transitionFor(operationContext: TransitionOperationContext, interactionController: TransitionInteractionController?) -> Transition
{
//animation
let transitionAnimation = MoveTransitionAnimation(forModalTransitionsAtEdge: .top)
let transition = Transition(duration: 0.4, animation: transitionAnimation)
return transition
}
}
extension ViewController : InteractiveModalTransitionOperationDelegate
{
func viewControllerForInteractiveModalPresentation(by sourceViewController: UIViewController, gestureRecognizer: UIGestureRecognizer) -> UIViewController
{
let vc = self.storyboard?.instantiateViewController(withIdentifier: "sticker")
vc?.modalPresentationStyle = .overCurrentContext
vc?.transitioningDelegate = self as? UIViewControllerTransitioningDelegate
    self.stickerViewController = vc as? StickerViewController
    return vc!
}

}

Hi,
I believe I found the issue.  The function 'defaultViewSetup(for modalOperation:' assumes the UIViewControllerContextTransitioning context toView key is not nil when dismissing.  However, the UIKit context object stores a nil for 'fromView' when presenting, and a nil for 'toView' when dismissing.  The defaultViewSetup code breaks down because of this.  I created a workaround by doing the following.  Not sure if this is correct:
`        let _toView = toViewController.view
let _fromView = fromViewController.view
let _superview = _toView?.superview
    switch modalOperation {
    case .present:
        containerView.addSubview(toView)
    case .dismiss:

        if (_superview == nil)
        {
            containerView.insertSubview(_toView!, belowSubview: _fromView!)
        }
    default: return nil
    }

    _toView?.frame = finalFrame(for: toViewController)
    return modalOperation == .present ? _toView : _fromView`

Thoughts?
Thanks,
Jan-Michael

Hi @jtressle , first of all apologies for the delayed response, I just got a little 👶 so I didn't get to coding matters for a while.
I haven't yet checked what you describe but it sounds plausible. Your code example seems fine, and I must admit that the defaultViewSetup() function was a bit of an afterthought, just to make the examples a bit more legible. When developing it, I noticed indeed that the properties weren't always what you'd logically expect. Given your suggestion, do I read correctly that although the toView is nil, the toViewController can be non-nil? (and similarly for the from counterparts) That would really surprise me.
Either way, the logic that I tried implementing is: if we're dismissing, and the view that will be shown (the toView, being the view visible when we initiated presenting) is available but is NOT in the view hierarchy (it doesn't have a superview), than we need to add it in the containerView, under the currently visible view (the fromView).
Your suggested fix will still crash when toView is nil, because then _superview will also be nil, after which you force-unwrap _toView to insert it.
I'm thinking out loud here, and as said have not yet tested this scenario. Have you made any progress or gained insights in the past few days?

I finally had the time to address this issue. I used the ModalTransitionsExample as testing project, and indeed when I replace DropTargetViewAnimation.swift line 57:
dropTargetView = operation.isPresenting ? transitionContext.toView : transitionContext.fromView

with this:
dropTargetView = transitionContext.defaultViewSetup(for: operationContext.operation)

The app will crash on dismissal, due to a force-unwrapped fromView was nil. Quite odd if you think about it, because the fromViewController is not nil, but the fromView is.
The fix that I applied is simple:
public var fromView: UIView! {
    return self.view(forKey: .from)
}

now is this:
public var fromView: UIView! {
    return self.view(forKey: .from) ?? fromViewController.view
}

@toineheuvelmans great and congrats on the baby!  I'll test it out this week.
Best,
Jan-Michael


Preserve primitives when cloning directly

Eg. should: deepCopy(42) === 42
This is especially useful when using deepCopy in a situation where the identity of an object is unknown.

:+1:


multi-root workspace - Test Explorer gets stuck after 7 folders and discovery still pending

@eleanorjboyd - I don't know about others, but I'm still experiencing a situation where the Test Explorer gets stuck and stops enumerating discovered tests (or test discovery itself is stuck...). Some (~7) of my workspace folders populate with tests, 2 of them show errors, but the loading indicator never goes away and the rest of them (~10) never populate.

I'm on ms-python.python pre-release version 2024.23.20241219, which I think should include the fix for this issue (?). I've been able to reproduce it with every version since 2024.21.0 (including every pre-release version).
My work-around is to revert back to 2024.20.0 where the issue is not reproducible.
From the logs, it's clear that discover HAS completed for some of the missing folders, but the Test Explorer is stuck and hasn't added/rendered those nodes. Is there perhaps some disconnect between the background processes and the "listeners" for them? Do they become "misaligned" after one discovery hits an error? I'll note that, in the past, I've noticed that test discovery/run/debug has had a harder time recovering from import-time Exceptions/failures (e.g. ModuleNotFoundError: No module named '...') than test/fixture Exceptions - I have had to explicitly stop/cancel in those cases. Could that be related?
Originally posted by @tboddyspargo in #24594

Hello! This should be fixed in 2024.22.1 - there should no longer stall. But as a result of the workaround for now the issue seen here https://github.com/microsoft/vscode-python/issues/24656 will then appear. If you have >2 workspaces and >30 tests you should downgrade to 2024.20.*

Thank you for confirming, @eleanorjboyd - indeed, the "stall" that I'm experiencing sounds very much like #24656. I just didn't know that the reproduction was dependent on the number of tests exceeding ~30! Our workspace has thousands across dozens of folders and the Test Explorer area doesn't seem to go further than the smallest few folders, which presumably complete the fastest and have a total number of tests of ~30 between them, so that checks out!


support jaegar endpoint for tracing

Jaegar endpoint is required as part of kiali . At present , zipkin is supported as part of tracing.
Add jaegar endpoint as part of knative.
Below output shows that zipkin is being configured as part of knative  under istio-system namespace
Output :
kubectl get po -n istio-system
NAME                                      READY   STATUS      RESTARTS   AGE
istio-citadel-6cb576cb8-bwfwb             1/1     Running     0          4m22s
istio-cleanup-secrets-1.1.3-9fqjp         0/1     Completed   0          4m23s
istio-galley-8685b6778d-8hrvr             1/1     Running     0          4m23s
istio-ingressgateway-87f9cb5c-8z2rq       1/1     Running     0          4m22s
istio-pilot-577c6b579d-6rbdj              2/2     Running     0          4m22s
istio-pilot-577c6b579d-n5w4h              2/2     Running     0          4m7s
istio-policy-6887f4649-22bcc              2/2     Running     1          4m22s
istio-security-post-install-1.1.3-qfbqm   0/1     Completed   0          4m23s
istio-sidecar-injector-77f787c45-jkmn7    1/1     Running     0          4m22s
istio-telemetry-7dfd9dfdbc-hqs96          2/2     Running     1          4m22s
kiali-6c5897d9d5-4tpfs                    1/1     Running     0          4m22s
zipkin-5bf9dcc949-cj2bj                   1/1     Running     0          3m5s
Config map of kiali
kubectl get cm kiali -n istio-system -o yaml
apiVersion: v1
data:
config.yaml: "istio_namespace: istio-system\nserver:\n  port: 20001\nexternal_services:\n
\ istio:\n    url_service_version: http://istio-pilot:8080/version\n  jaeger:\n
\   url: \n  grafana:\n    url: \n"
kind: ConfigMap
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"v1","data":{"config.yaml":"istio_namespace: istio-system\nserver:\n  port: 20001\nexternal_services:\n  istio:\n    url_service_version: http://istio-pilot:8080/version\n  jaeger:\n    url: \n  grafana:\n    url: \n"},"kind":"ConfigMap","metadata":{"annotations":{},"labels":{"app":"kiali","chart":"kiali","heritage":"Tiller","release":"release-name"},"name":"kiali","namespace":"istio-system"}}
creationTimestamp: "2019-07-16T15:30:35Z"
labels:
app: kiali

/close
I believe this now works. I have followed https://knative.dev/docs/serving/installing-logging-metrics-traces/#jaeger and seen traces show up correctly in Jaeger. Note that it still uses a Service named zipkin, but points at the Jaeger instance.
If those instructions don't work for you, please re-open the issue.


Attempting to import a networks.AlertsSettings results in a nil pointer dereference panic

What happened?
When attempting to import a networks.AlertsSettings I encounter a panic.
Example
running pulumi import meraki:networks/alertsSettings:AlertsSettings example "REDACTED" results in a panic. I will include the full error in a separately.
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x2 addr=0x68 pc=0x1038a12f4]
    goroutine 46 [running]:

Output of pulumi about
CLI
Version      3.117.0
Go Version   go1.22.3
Go Compiler  gc

Plugins
KIND      NAME    VERSION
resource  meraki  0.2.1
language  nodejs  unknown

Host
OS       darwin
Version  14.2.1
Arch     arm64

This project is written in nodejs: executable='/Users/zbuchheit/.nvm/versions/node/v18.17.1/bin/node' version='v18.17.1'

Current Stack: zbuchheit-pulumi-corp/meraki-org-policy-groups-ts/dev

TYPE                     URN
pulumi:pulumi:Stack      urn:pulumi:dev::meraki-org-policy-groups-ts::pulumi:pulumi:Stack::meraki-org-policy-groups-ts-dev
pulumi:providers:meraki  urn:pulumi:dev::meraki-org-policy-groups-ts::pulumi:providers:meraki::default_0_2_1_github_/api.github.com/pulumi/pulumi-meraki

Found no pending operations associated with dev

Backend
Name           pulumi.com
URL            https://app.pulumi.com/zbuchheit-pulumi-corp
User           zbuchheit-pulumi-corp
Organizations  zbuchheit-pulumi-corp,
Token type     personal

Dependencies:
NAME            VERSION
@pulumi/pulumi  3.119.0
@pulumi/meraki  0.2.1

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

upon further testing this appears to be an upstream issue, I opened an issue on the upstream provider here

Thank you for filing upstream - we'll be pullling in the fix as soon as it's available.

closing as completed and resolved via https://github.com/pulumi/pulumi-meraki/pull/71


Feed API slow

Querying the API, e.g. /api/feeds/all/all/recent.json, takes a while. Requesting the feed on my GreedyBear instancees with curl -so /dev/null -w '%{time_total}\n' http://HOSTNAME/api/feeds/all/all/recent.json takes about 6 seconds. This also produces significant CPU load on the server. However the Honeynet instance seems to be much quicker. Is it just an issue of my installations?

It could probably due to caching mechanisms in Nginx
        uwsgi_cache_valid 200 10m;

I measured the number of queries sent to the DB when this API endpoint is requested: it's > 5000. I was able to reduce it to 3 by using prefetch_related. This also dramatically reduces the response time. I'll open a PR tomorrow.


phosphoprotein phosphatase question

GO:0004647 phosphoserine phosphatase activity
I have one annotation to this, and the rest to the sibling
GO:0004722 protein serine/threonine phosphatase activity
(so it is the same as the serine kinase vs serine/threonine protein kinase issue)

I thought it meant removing a phosphate group from a serine residue.

Ok in that case the same applies as to
corrected, I meant
phosphoprotein phosphatase.
Although didn't we decide
sereine kinase and threonine kinase,
we decided we only needed serine/threonine protein kinase?
so the same would apply to phosphoserine phosphatase?

ignore me!

It was this term I have a problem with
phosphoserine phosphatase activity
I have one annotation to this, and the rest to the sibling
protein serine/threonine phosphatase activity
(so it is the same as the  serine kinase vs   serine/threonine protein kinase issue)

It was this term I have a problem with
phosphoserine phosphatase activity
I have one annotation to this, and the rest to the sibling
protein serine/threonine phosphatase activity
(so it is the same as the  serine kinase vs   serine/threonine protein kinase issue)

Note that there is also

GO:0036425 D-phosphoserine phosphatase activity
GO:0036424 L-phosphoserine phosphatase activity
( not used; merge?)

Hi Pascale,
there seem to be rheas for each of these GOs
L - https://www.rhea-db.org/rhea/21208
D - https://www.rhea-db.org/rhea/24873
both linked to EC <IP_ADDRESS> Phosphoserine phosphatase, which seems to be capable of either, see https://www.qmul.ac.uk/sbcs/iubmb/enzyme/EC3/1/3/3.html. Note this is for free amino acids and not residues in proteins.
All the best, Alan

Thanks @alanbridge
There is some inconsistency - those are linked to https://enzyme.expasy.org/EC/<IP_ADDRESS>
that links to some protein phosphatases, such as P60487 (maybe only the 'PLPP's' are wrong? Who could check that ? )
It's also surprising that
L - https://www.rhea-db.org/rhea/21208
D - https://www.rhea-db.org/rhea/24873
have the same number of associations to UniProt entries - does that mean that the enzymes are non-specific ?
Thanks, Pascale

I guess the numbers are identical as this is a set of Rhea annotations based originally on EC numbers and the mapping to them - pinging @morgat and @kaxelsen who might be able to expound further.

@ValWood GO:0004647 phosphoserine phosphatase activity should NOT be used to annotate proteins, but only free amino acids.

@lbreuza could you please check the EC number / Rhea on PLPP?

Got it!

I changed the definition and added a comment to make it clearer taht we are talking about free amino acids and not phosphoproteins:
Catalysis of the reaction: L(or D)-O-phosphoserine + H2O = L(or D)-serine + phosphate, on a free amino acid." [PMID:9188776]
+comment: Do not confuse with protein phosphatases. For protein phosphatases, consider GO:0004722 ; protein serine/threonine phosphatase activity or GO:0008138 ; protein tyrosine/serine/threonine phosphatase activity.
Thanks, Pascale

@lbreuza I cannot find evidence for any enzyme with GO:0036425 D-phosphoserine phosphatase activity- can you ?
If not I will merge the triad into the L-serine phosphatase.
Thanks, Pascale

Why not leave the D-specific term for the time being? There is old literature (I don't have time to go into now) on D-phosphoserine functions and regulation like https://pubmed.ncbi.nlm.nih.gov/8858931/
e.g.
D-Serine is a stereospecific agonist of the NMDA-associated glycine receptor
phosphoserine phosphatase may be an important enzyme in regulating the steady-state levels of D-serine in neocortical synaptosomes.
So there may be a specific need to capture it.
Cheers, Alan

OK, sure, just there seems to be no phosphatase. We can leave it.

Hi,
I am updating P60487 and there are a few papers to check. Will check the other aspects.

Thanks @alanbridge
There is some inconsistency - those are linked to https://enzyme.expasy.org/EC/<IP_ADDRESS>
that links to some protein phosphatases, such as P60487 (maybe only the 'PLPP's' are wrong? Who could check that ? )
It's also surprising that
L - https://www.rhea-db.org/rhea/21208
D - https://www.rhea-db.org/rhea/24873
have the same number of associations to UniProt entries - does that mean that the enzymes are non-specific ?
Thanks, Pascale

Hi,
I updated PDXP UniProtKB/Q96GD0 and orthologs to remove EC <IP_ADDRESS> since I could not find evidence for such activity. On the other hand I added EC=<IP_ADDRESS> since it has 2 activities: Pyridoxal phosphate phosphatase and possibly a protein serine phosphatase.
I also checked P78330, the other proteins with EC <IP_ADDRESS> and they are indeed phosphoserine phosphatases (GO:0004647 phosphoserine phosphatase activity). However, I believe they are phospho-L-serine phosphatases and I will remove the [Rhea:24873] from these entries.
Will it remove also the Rhea2GO mapping?
DR GO=GO:0036425; F:D-phosphoserine phosphatase activity; {IEA:RHEA}
Best, Lionel


[BUG] Text should be inside the field

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
The text on send window should be inside the field, like the receive window.
Screenshots [optional]
Send window with text outside the field:

Should be like receive window with text inside the field:

Steps To Reproduce
1- Go to send window
Expected behavior
See the text inside the field, like the receive window.
Alby information
Alby: 1.25.1
Device information
No response
Additional context
No response
Are you working on this?
No

This current result was done on purpose because of #1517
Placeholders are made to display input examples, not as a replacement for labels or hints I believe.
In that case the hint-text (used as a placeholder displayed inside the input) was too long and gets cut off in some languages.
Might be better to check the extension and align this behaviour?
wdyt @reneaaron @jankoegel @jakubszwedo

I don't care the text be cut. Why not mouseover on text and see the full text?

Why do you dislike the hint-text below the input?

I don't care the text be cut.

We need to consider more users though.

Why not mouseover on text and see the full text?

Not very accessible. We should try to find a better way to handle this.

I agree with @escapedcat on this - the consensus is to to use a placeholder only to show examples of the input, MAYBE some hints, but as far as I research it's also advised to show them outside, especially if they are convening some important info - otherwise leave it empty. There shouldn't be any crucial information in there, which in the case of Send and types of input we can paste here, is quite important, so I'd leave it outside. We have a lot of space below so we can easily display the hint below the input.
We could think of taking hints out of the input in the case of Receive screen. I think it's less crucial here, as the hints do not show any new information to the user, and are just a little helper. One could argue "amount in satoshis" does, but we use satoshis all over the extension, so it's not really new and we display fiat value all the time.

What about this idea?
https://user-images.githubusercontent.com/1178856/221208072-3086bc12-9778-4698-a603-a573bf13b07a.mp4

I agree with @escapedcat on this - the consensus is to to use a placeholder only to show examples of the input, MAYBE some hints, but as far as I research it's also advised to show them outside, especially if they are convening some important info - otherwise leave it empty. There shouldn't be any crucial information in there, which in the case of Send and types of input we can paste here, is quite important, so I'd leave it outside. We have a lot of space below so we can easily display the hint below the input.
We could think of taking hints out of the input in the case of Receive screen. I think it's less crucial here, as the hints do not show any new information to the user, and are just a little helper. One could argue "amount in satoshis" does, but we use satoshis all over the extension, so it's not really new and we display fiat value all the time.

What I don't like is the font size. Is very small compared to other windows.

Why do you dislike the hint-text below the input?

I don't dislike it, I dislike the font size that is very small compared to others windows.

What about this idea?

This will lead to same issues. A label should be a short precise text to "label" the input. Not an lengthy explanation.

What I don't like is the font size. Is very small compared to other windows.
I don't dislike it, I dislike the font size that is very small compared to others windows.

In this case we could just think about updating the style of that hint-text I guess.
The smaller size should just somehow show that this is not normal text but belongs to the input.
@stackingsaunter you got an idea what could be done here?

@escapedcat 12px for under-input text is quite common, I think this is the most common size for that thext, eg. Material Design uses precisely 12px. I think bigger font there will be disctracting

The only way to make it bigger is to take this text out and use normal paragraph, but hmm I don't think that looks better?

12px for under-input text is quite common, I think this is the most common size for that thext, eg. Material Design uses precisely 12px.

Agreed, that's why I styled it this way. This seems common practice to me.
I don't think this is urgent. We could leave it for now and see if we get any further feedback in the future.


GH-4549 javadocs aggregate goal is brittle

GitHub issue resolved: #4549
Briefly describe the changes proposed in this PR:
The aggregate goal uses forking, and there are some issues with how dependent modules are built. Switching to the aggregate-no-fork goal fixes this.

PR Author Checklist (see the contributor guidelines for more details):

[ ] my pull request is self-contained
[ ] I've added tests for the changes I made
[ ] I've applied code formatting (you can use mvn process-resources to format from the command line)
[ ] I've squashed my commits where necessary
[ ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

To reproduce this you need to:

change the version of all the modules in the project to one that doesn't exist (ex: 4.3.0-M3)
run mvn package -Passembly -DskipTests


Add information for supported method for retrieving user MRI

This document references user MRIs for user specific views but provides no instructions or samples on how to retrieve user mri for implementation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47dee5d9-bd9f-f550-8fc2-c2e3b67bba65
Version Independent ID: 04264d26-1036-342a-e0ea-5edadebc3352
Content: Overview of Universal Actions for Adaptive Cards - Teams
Content Source: msteams-platform/task-modules-and-cards/cards/Universal-actions-for-adaptive-cards/Overview.md
Product: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

@TheBluLion - I think getting User MRI is the part of SDK and TeamsChannelAccount Class where channel id is the actual MRI value for user.
Reference link:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.bot.schema.teams.teamschannelaccount?view=botbuilder-dotnet-stable#properties

We are closing this issue for now, Please feel free to reopen it, if required.


cmd/gofmt: inconsistent indentation in var block

What version of Go are you using (go version)?

$ go version
go version go1.16.2 linux/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/charles/.go/bin"
GOCACHE="/home/charles/.cache/go-build"
GOENV="/home/charles/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/charles/.go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/charles/.go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.2"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3438103609=/tmp/go-build -gno-record-gcc-switches"

What did you do?

See this go playground link
What did you expect to see?
package main

var (
	someLoooonnnnnnngName = NewBuilder().
		WithB(
			NewB().
				WithC(),
		).
		Build()

	short = NewBuilder().
		WithB(
			NewB().
				WithC(),
		).
		Build()
)

var yetAnotherLooooonnnnnnngName = NewBuilder().
	WithB(
		NewB().
			WithC(),
	).
	Build()

What did you see instead?
diff:
5c5
< 		WithB(
---
> 				WithB(

full file:
package main

var (
	someLoooonnnnnnngName = NewBuilder().
				WithB(                                            // <- Wrong indentation here
			NewB().
				WithC(),
		).
		Build()

	short = NewBuilder().
		WithB(
			NewB().
				WithC(),
		).
		Build()
)

var yetAnotherLooooonnnnnnngName = NewBuilder().
	WithB(
		NewB().
			WithC(),
	).
	Build()

possibly duplicate of #41889 ?

This behavior is intentional.  See #644, #7335, #10392, #22852.


BaseViewController leaks in tests

Next tests fails in dev branch:
BaseChatViewControllerTests.testThat_WhenUpdatesFinish_ControllerIsNotRetained
BaseChatViewControllerTests.testThat_WhenLayoutFinishes_ControllerIsNotRetained

They pass for me and Travis: https://travis-ci.org/badoo/Chatto/builds/139774280
Any iOS version / device in particular??

Tests fails if they are compiled for armv7 architecture (iPhone 4s/5, iPad 2/3) on iOS 9.3 (iOS 8.4 is fine). I'm looking for the problem

Issue is in UIKit. This test fails on iPhone 4S/5, iPad 2/3 with iOS 9.3:
func testThat_ViewControllerLeaks() {
    var viewController: UIViewController? = UIViewController()
    weak var weakViewController = viewController
    viewController?.view.frame = CGRect.zero
    viewController = nil
    XCTAssertNil(weakViewController)
}

Compiler inserts retain/release/autorelease differently on different architectures:
armv7:

armv64

On armv7 additional autorelease message doesn't allow controller to be deallocated during test execution


Support for fixed arguments / question about dynamic args lists?

I'm checking out GuildAI on an existing ML repository. I may have just missed it in the docs, in which case apologies, but it appears that GuildAI may not support fixed arguments being passed to main: in guild.yml or a dynamic args list.
Fixed arguments: We have a top-level running which can do a few different things to a data set. Which thing gets done is determined by the first argument, e.g., python main/train.py task1/something.py [args]. I tried using e.g. exec: python main/train.py task1/something.py, but GuildAI refused to import flags for this setup. From the documentation, it would seem that a main entry might be required instead, but then there would be no way to pass the fixed argument task1/something.py. So, this doesn't seem supported by GuildAI.
Dynamic args list: I've gotten a lot of use out of dynamic args lists based on e.g. pyobjconfig.ConfigurableSwitch. Basically, it cheats by reading an argument, and using that value to alter the list of available options such that they match that argument. This is useful for e.g. switching out an activation function, where not all activation functions are parameterized the same way. Due to the first issue, fixed arguments, I haven't actually tried this in Guild, but from e.g. the documentation on meta-parameter optimization, it seems that there might be some issues with a changing argument list. Any thoughts on that?
Thank you in advance -- let me know if there was a better forum for these particular issues/inquiries than a GitHub issue.

GitHub issues are totally fine. For general questions, you can also post something to https://my.guild.ai (the Guild AI community website).
Are you using pyobjconfig to implement this dynamic behavior?
Guild does not really handle dynamic flags per operation. The idea is that each operation defines a single set of flags that can be compared across runs of the same operation. If your scripts support different sets of flag combinations, those would typically be defined as separate operations in Guild. But even with that, Guild is not going to know how to import these flags today. There is planned support for Python sub-commands, but that's not in place yet.
If you have a simple/trimmed-down example of the script that you're describing, I will see if there's a way to accomplish what you're looking for.

Right -- I understand why you want a fixed set of flags for, say, the meta-optimizers.
However, my current issue is that GuildAI won't allow me to both pass default arguments and infer flags. So here might be my use case, complete with a pyobjconfig example and a stab at a reasonable guild.yml:
main.py
import argparse
import pyobjconfig as poc
class SubThing1(poc.ConfigurableObject):
    class config(poc.PydanticBaseModel):
        var: int = 8
class SubThing2(poc.ConfigurableObject):
    class config(poc.PydanticBaseModel):
        iable: int = 5
class Thing(poc.ConfigurableObject):
    class config(poc.PydanticBaseModel):
        width: float = 10.5
    sub_thing = poc.ConfigurableSwitch({
            'thing1': SubThing1,
            'thing2': SubThing2,
    })

if __name__ == '__main__':
    ap = argparse.ArgumentParser()
    Thing.argparse_setup(ap)
    args = ap.parse_args()
    t = Thing.argparse_create(args.__dict__)
    print('do something with t.')

guild.yml
train-thing-1:
  exec: python main.py --sub_thing thing1
  flags-import: all
train-thing-2:
  exec: python main.py --sub_thing thing2
  flags-import: all

Does that make sense? Basically, the available flags (which are properly populated in the --help command) aren't being harvested. I think this is due to the exec, rather than main, configuration in guild.yml, but main doesn't work here because of the need to pass --sub_thing thing[1|2] to get the correct list of flags.
Put another way, if GuildAI would call python main.py --sub_thing thing1 --help to try to infer flags on an exec call, it would be fine (in this use case).
If it helps, here's some console output:
bash$ python3 main.py --sub_thing thing1 --help
usage: main.py [-h] [--width WIDTH] [--sub_thing SUB_THING] [--sub_thing-var SUB_THING-VAR]

optional arguments:
  -h, --help            show this help message and exit
  --width WIDTH         Default: 10.5
  --sub_thing SUB_THING
                        Inferred 'thing1'; help shown corresponds to that option. Switch accepting: ['thing1', 'thing2']. Pass another option to see available arguments for that option.
  --sub_thing-var SUB_THING-VAR
                        Default: 8
bash$ python3 main.py --sub_thing thing2 --help
usage: main.py [-h] [--width WIDTH] [--sub_thing SUB_THING] [--sub_thing-iable SUB_THING-IABLE]

optional arguments:
  -h, --help            show this help message and exit
  --width WIDTH         Default: 10.5
  --sub_thing SUB_THING
                        Inferred 'thing2'; help shown corresponds to that option. Switch accepting: ['thing1', 'thing2']. Pass another option to see available arguments for that option.
  --sub_thing-iable SUB_THING-IABLE
                        Default: 5

I just committed a change that should address your issue. This is available in master and will be available in 0.7.4.dev1, which is a pre-release that will be available later today.
Here's your example: https://github.com/guildai/issue-resolution/tree/master/282-support-for-fixed-arguments-question-about-dynamic-args-lists. The FIX.md doc there shows the expected output (you can run these using guild check -nt FIX.md to actually check). I'd start with that project to confirm that things are working for you. That will make things easier to troubleshoot if there's a problem.

Works great! Thanks for the quick fix.
Closing this issue, but leaving one little note -- it took a bit of digging in the docs to realize that the working directory for the script differed from the source code directory! Might want to document that information a little earlier, in case someone needs to use the requires: -file:  option or equivalent.

Great, I'm glad that's working for you! And thank you for the feedback. I'd say this is the number one surprise for users - so much so that it might make sense to have Guild look for a FileNotFound error and add a note about this behavior, e.g. with a link to some docs.
Out of curiosity, when if you comment out the requires section for the operation, what error message do you get? I'm assuming it would be something like:
FileNotFoundError: [Errno 2] No such file or directory: '...'

In my case it's a ValueError: No model file: model/test20210401.py. I can see how the common case would be FileNotFoundError, but not this time. The added difficulty of a "no changes required" experiment tracking framework, I suppose. Though, FWIW, that's the whole reason I'm looking into GuildAI.
FWIW, The whole "red exclamation point in a box" style of documentation seems fairly effective at getting people's attention. At the first talk of "guild run" in the docs, one approach would be to stick such a warning there.

Yeah I see what you mean about the docs. For some reason I thought we had covered this in Get Started but we don't. I think even a new step in the tutorial there would be helpful. I'll look for some spots to put this info. Thanks again for the input!

Taking your advice, I updates the docs in Get Started at the point of the first run example with a list of "tasks that Guild performs". This includes a call out box highlighting the dependencies issue.
https://my.guild.ai/t/get-started-with-guild-ai/35#run-the-script

Great, I like the call-out to the dependencies section specifically. Thanks for putting that in there, hope it helps some people down the line!


Brandnew 2040W has newer FW/examples than V0.0.3 FW here

It looks like you did the "pimoroni-badger2040-v0.0.3-micropython-with-badger-os.uf2" and the "pimoroni-badger2040w-v0.0.3-micropython-with-badger-os.uf2" with the 2040 firmware, since it the "pimoroni-badger2040w-v0.0.3-micropython-with-badger-os.uf2" does not know either modul 2040w nor badger_os, which is used in the examples of
Link2040W.
I ended up flashing the "pimoroni-badger2040w-v0.0.3-micropython-with-badger-os.uf2" and all of my backed up example-files didn't run anymore. Took the .uf2 with an 7 months old version of the badge_os and the brandnew delivered badger doesnt run anymore. Can you please supply the new files? Thanks!

It has moved here
https://github.com/pimoroni/badger2040
Releases here
https://github.com/pimoroni/badger2040/releases/tag/v0.0.3

Thanks for reply, @exussum12!
Thats exactly where I went and nothing works anymore.
2030w Modul not known.
And when I install the 2030w *.uf2 package, WiFi doesn’t work (clock.py).
Also badger_os.warning (in the newer examples) is not know and causes the *.py not running.
The newer code does not fit to the V0.0.3 *.uf2 fw , it seems.
Seems lately many people have this problem only with 2030w, so I guess

Was there. Done that.
I think you are on it.

And see, if I‘m wrong.
The (new) code from the given link doesn’t run with the V0.0.3 firmware.
I installed the firmware V0.0.3 with Badger_OS all fine, I can start any *py.
The 2040w V0.0.3 code has no module 2040w for import…
If I install the linked examples of September 2023, they won’t work.
They import 2040w, which does not come with the firmware 2040w nor with the firmware2040w-badger_os.
The V0.0.3 firmware for the 2040w doesn’t know the modul 2040w.

There is not, and never has been a 2040w module. If you're trying to import badger2040w it's because you're running old code on a new firmware. It should be import badger2040 so code is portable between 2040 and 2040W.
I flashed the mentioned firmware to my Badger 2040W and the examples run fine.
The docs and examples in this repository are out of date and should probably be deleted now.

:x: Out of date: https://github.com/pimoroni/pimoroni-pico/tree/main/micropython/examples/badger2040w
:heavy_check_mark:  Correct examples: https://github.com/pimoroni/badger2040/tree/main/badger_os/examples

@Gadgetoid: oh dang! 😝
I tried to ride old horses and actually did everything right - except for sticking my nose it files from September 2023. Holy crap! 🫣
Thanks 🙏🏻 for clarifying!


TLVBody.SerializeTo doesn't write to io.writer

Line 30 on pdufield/tlvbody.go, SerializeTo function doesn't write anything to io.Writer.

Pull request: https://github.com/fiorix/go-smpp/pull/13

Not surprised, I never really tested TLV. There's probably TODOs in the code, which is mostly inherited from Kevin's lib.


Improve tutorial

I think this still puts some of the burden on the user to read through every installation option, whereas there could just be a section at the top with something like this:
**Unsure about which installation instructions to follow?** Here's a bit more guidance:

Are you on Windows?

* Yes → Follow the instructions for DirectML<link to DML instructions>.
* No → Do you have an NVIDIA GPU?
  * Yes → Follow the instructions for NVIDIA CUDA GPU <link to CUDA instructions>.
  * No → Follow the instructions for CPU and Mobile <link to CPU instructions>.

*Note: Only one package is required based on your hardware.*

This way, people who already know their hardware don't have to read through guidance about how to determine which hardware they have, and people who are unsure about their hardware don't need to read through all of the installation instructions.

@sophies927 Do you want to edit as per your comment above? Or just add a PR suggestion?

@natke I can go ahead and add a PR suggestion!


SSO Tab C Sharp

Added Personal Tab and configurable Tab SSO authentication
Displaying user profile information in Tab
Language : C#

Okay wajeed will be doing this

Okay wajeed will be doing this

Updated Main Index ReadMe for C#

Updated Main Index ReadMe for C#


Finer grained quota filling for exclusive striping

Currently, if chunks are grouped before striping, the total size is used to determine if there's space available, instead of the size of each chunk individually.

Idea: in stripe.S.Stripe(), make dests a func(*scat.Chunk) Locs instead of a Locs


Tab Bar

Steps to Reproduce

...
...
...

Logs

This issue is empty?

@escamoteur Completely empty issues should be closed; they are likely accidentally created.


CommonJS module loader is error-prone

Graal.js's CommonJS module loader implementation is naive. A module's source code is prepared in exactly the same manner that Node.js used to do it and could suffer from the same problems.
Here is the relevant section from CommonJSRequireBuiltin.java
// Read the file.
Source source = sourceFromPath(modulePath.toString(), realm);
TruffleString filenameBuiltin = Strings.fromJavaString(normalizedPath.toString());
if (modulePath.getParent() == null && !modulePath.exists()) {
throw fail(moduleIdentifier);
}
// Create `require` and other builtins for this module.
String dirnameBuiltin = modulePath.getParent() == null ? "." : modulePath.getParent().getAbsoluteFile().normalize().toString();
JSObject exportsBuiltin = createExportsBuiltin(realm);
JSObject moduleBuiltin = createModuleBuiltin(realm, exportsBuiltin, filenameBuiltin);
JSObject requireBuiltin = createRequireBuiltin(realm, moduleBuiltin, filenameBuiltin);
JSObject env = JSOrdinary.create(getContext(), getRealm());
JSObject.set(env, Strings.ENV_PROPERTY_NAME, JSOrdinary.create(getContext(), getRealm()));
// Parse the module
CharSequence characters = MODULE_PREAMBLE + source.getCharacters() + MODULE_END;
Source moduleSources = Source.newBuilder(source).content(characters).mimeType(JavaScriptLanguage.TEXT_MIME_TYPE).build();

ContextifyContext::CompileFunction was created to fix this in Node and is used by vm.compileFunction. Some other implementations of CommonJS, such as jvm-npm, use Function to create the module function.

I just verified this with this module code:
})();

console.log("This shouldn't work!");

(function () {
Calling require on the above module results in the message being printed.

This module code demonstrates the line/column offsets being incorrect in a stack trace:
throw Error("Is the stack trace correct?");

Output in JS launcher:
Error: Is the stack trace correct?
    at <js> :anonymous(/usr/local/lib/node_modules/throw_error/index.js:1:67-106)
    at <js> :program(<shell>:1:1:0-21)

The column offset is off by the length of MODULE_PREAMBLE, or 62 bytes.

Hi, Thank you for reporting this issue, we will take a look into it and get back to you

Hi,
I'll ask @eleinadani to have a look at your problem; maybe there is a simple way to improve our loader.
In general, though, you will be right: it is a "naive" implementation that tries to mimic what Node is doing, but is certainly far from perfect.
-- Christian

We pushed a fix for this scenario here.

@eleinadani I meant to add this comment here a few days ago, but I was delayed and I just noticed you closed this issue.
A function should be added internally which behaves like Node's ContextifyContext::CompileFunction. For Graal.js's purposes, such a function would not need to be as complex and should take code representing a valid function body, a list of parameter names (that the created function would take), a source name that would be seen in stack traces, a column offset, and a line offset. If possible, a JavaScript binding for it should be added to the Debug or Polyglot builtins.

@wirthi @oubidar-Abderrahim Please see the above comment.


Performance drop because of not yet implemented batching rule.

Hello, @zou3519 , @samdow
I get the following warning when i try to compute jacobians of my model.
UserWarning: There is a performance drop because we have not yet implemented the batching rule for aten::bitwise_xor_.Tensor. Please file us an issue on GitHub so that we can prioritize its implementation. (Triggered internally at /opt/conda/conda-bld/pytorch_1666642991888/work/aten/src/ATen/functorch/BatchedFallback.cpp:82.)
The above error is triggered by the code below.
def spatial_hash(coords: List[Tensor]) -> Tensor:     PRIMES = (1,<PHONE_NUMBER>, 805459861,<PHONE_NUMBER>)     #assert len(coords) <= len(PRIMES), "Add more PRIMES!"     if len(coords) == 1:         i =  (coords[0] ^ PRIMES[1])# torch.logical_xor(coords[0], torch.tensor(PRIMES[1]).cuda()) # (coords[0] ^ PRIMES[1])     else:         i = coords[0] ^ PRIMES[0] # torch.logical_xor(coords[0], torch.tensor(PRIMES[0]).cuda()) # coords[0] ^ PRIMES[0]         for c, p in zip(coords[1:], torch.tensor(PRIMES[1:]).cuda()):             i  ^= c * p # torch.logical_xor(i, c * p) # ^= c * p     return i
Are there plans to implemented batching for the above operations in the near future ?
Thank you

This shouldn't be difficult to do, we can prioritize it

This is also true for other bitwise ops. What concerns me is that why test_op_has_batch_rule does not catch it 🤔 ?
import torch
import functorch

for bitwise_op in ['bitwise_xor_', 'bitwise_or_', 'bitwise_and_', 'bitwise_not_', 'bitwise_left_shift_', 'bitwise_right_shift_']:

    x = torch.zeros(3, 3, dtype=torch.long)

    def fn(x):
        op = getattr(x, bitwise_op)
        if bitwise_op == 'bitwise_not_':
            op()
        else:
            op(1)
        return x

    t = functorch.vmap(fn)(x)


Increase amount of search snippet text displayed

@divoxx @brupm @jeyb

https://www.pivotaltracker.com/story/show/113457185

:+1: no-qa


Rename optIntoASA to optInToASA

Describe the bug
The function names are not maintained properly. For instance optIntoASA has "t" where as optInToApp has "T". To avoid confusion and consistency I suggest that we should only have optIntoASA and optInToASA where "t" is used.
Possible Solution
Rename all references of optIntoASA -> optInToASA

Thanks @kashishkhullar!


Add media compression level uncompressed

Added Uncompressed media quality level. Skips compression completely and just continues with original media.
Screen_recording_20240911_173255.webm

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
Can I fix it or do you have to fix the build workflow @vitorpamplona?

I will fix the actions/upload-artifact: v2 thing

Yeah, it's a nice option to have for media creators. Especially with their own media server.
I didn't think about it in the original pull request.

Yeah, it's a nice option to have for media creators. Especially with their own media server.

Exactly.

Loos fixed. thanks @vitorpamplona

This didn't work, no changes were merged 😱.
Maybe it was the last merge from main into the branch that confused the PR merge.
I will create a new PR and redo it.

Are you sure? I can see them on main

I'll triple check

Ah yes, thanks for checking. I didn't update my main 😂😂


Check and correct use of MBEDTLS_ERR_SSL_INTERNAL_ERROR

Context: The error code MBEDTLS_ERR_SSL_INTERNAL_ERROR is (to my understanding) meant to be used solely for internal assertion failures only which double-check what should unconditionally hold regardless of API (mis-)use or malformed data received from the peer. In particular, to the best of our knowledge, we should be able to remove all of these checks without compromising the security of the library.
Issue:

Sometimes we do use MBEDTLS_ERR_SSL_INTERNAL_ERROR for things that can be triggered by malformed input. One example is here which would be triggered if a peer sent a datagram containing a valid record, followed by a single overhead byte. We should go through all uses of MBEDTLS_ERR_SSL_INTERNAL_ERROR and verify that they are indeed assertion failures, and if not, replace them by appropriate and expressive error codes.
Most of the time we just print should never happen for internal assertion failures - we should have more expressive error messages.

ARM Internal Ref: IOTSSL-2488

Most of the time we just print should never happen for internal assertion failures - we should have more expressive error messages.

I'm not sure I agree with that point. Once the first point has been fixed, these messages should never ever be seen by anybody, except sometimes ourselves during development/debugging, so I don't think it's worth spending time to enhance them. The file and line number already give us all the information we need to know what instance of "should never happen" it is.


OpenVINO patch: where was it taken from?

This patch is unexpected: https://github.com/dimstav23/tdx-tools/blob/e32d4375ed62b08055492bd2d81ce44de74970f9/benchmarks/openvino/openvino_benchmark.patch
Where did you get this patch from? Did you write it yourself? Why?

Is this because you install OpenVINO in virtual environment?


3-bit (indexed 8) color level

This would be the first 8 colors mentioned here https://en.wikipedia.org/wiki/ANSI_escape_code#3-bit_and_4-bit (same as 4 bit/indexed 16, except only the first half)
The use case I'm interested in is Discord ansi code blocks (they only support 3-bit color)
Alternatively if ColorLevel was a interface, I could implement this myself

Added in #36


Issue 46188: fix get unix from datetime when empty dict

Reopened PR as discussed in #46902 pointing to master @Calinou

You should likely redo the changes on a new branch created from your master branch. This PR didn't work as it attempted to merge changes from 3.2 into master, which are quite divergent by now.


Changing mgw to Choreo Connect

Changing mentions of Micro Gateway to Choreo Connect.

Fixes https://github.com/wso2/docs-apim/issues/3539


Keep the original template name

If the template name is template.yml the plugin has to generate .aws-sam/build/template.yml instead of .aws-sam/build/template.yaml

@fayezgb I can't use this PR because it breaks support for building multiple projects. It results in the last template name being used for all projects which is not the desired outcome. I've created a new issue to track it #40 and will fix this shortly.


New version: Libgpg_error_jll v1.42.0+0

Autogenerated JLL package registration

Registering JLL package Libgpg_error_jll.jl
Repository: https://github.com/JuliaBinaryWrappers/Libgpg_error_jll.jl
Version: v1.42.0+0
Commit: bb5b32e983ee53a1b185798767c82da59e0323bf
Revision on Yggdrasil: https://github.com/JuliaPackaging/Yggdrasil/commit/0a4d1bf7a26aa8a74a37bb216d315499dd16aff8
Created by: @giordano

Wait also here....


Add JSDocs

One thing I'd like to add here is - it would be super cool to provide simple example of usage for most important functions, such as createActor or whatever. rxjs is an example package where internal impl. is full of explanations and examples. I know it might be quite some effort to get there, but at least simple usage examples would be very useful.

One thing I'd like to add here is - it would be super cool to provide simple example of usage for most important functions, such as createActor or whatever. rxjs is an example package where internal impl. is full of explanations and examples. I know it might be quite some effort to get there, but at least simple usage examples would be very useful.

The createActor function, as well as many other functions, do have examples in them 👍
Just some gaps that need to be filled

Let's merge this sooner than later. We don't need a long-lived umbrella branch for this - those JSDoc improvements can land incrementally.


Metadata

Issue #159: Add certain dropdown fields to Metadata section of Admin for easy editing
Modified requested fields on various models to translate them into ForeignKey relationships with new metadata classes.
Created associated migrations. Added methods to these migrations that translate the existing data into the new fields and creates the applicable relationships.
Migrations under apps.content are misnumbered due to another migration in the pending PR #348 which should be merged in first.

Coverage increased (+0.2%) to 89.056% when pulling cac16c7fd7b74ab92cf6412e67f2151a0ffe11a7 on metadata into 651e238858ddb9c45e0919bd93d1382311964e87 on master.

Coverage decreased (-0.1%) to 87.26% when pulling bdfa11aaa231c582601e7ebd8a89ff2c8d65d316 on metadata into 0a1c73b10117d8ad6f1164e84d237fa58223e50a on master.

Coverage increased (+1.8%) to 89.127% when pulling 61450ab5e65b422668661b5e8d722b0d012c092d on metadata into 0a1c73b10117d8ad6f1164e84d237fa58223e50a on master.


(chores) camel-cassandra: minor cleanups

@orpiske i think the removal of System println should go on 3.x too


Do not retry on TransientError caused by user terminating tx

@lutovich Test added to address the wrong method call


Spawn Eggs and Potions are broken

Not sure if you know about this but the pictures explain themselves.
1.7.10

1.16 Retro Items

Ooh, that's a big oversight on my part. I think i can manage to put in a special case to render these. If all else fails, fast item rendering off should work fine in the meanwhile.


[codecov] pull request status checks is broken

Describe the bug
codecov status checks are either not being reported or updated properly.

#6130
#6131
#6132

also for #5384

And https://github.com/openthread/openthread/pull/6123 is reporting wrong coverage.

also for #6070

Technically speaking, this issue of wrong codecov reporting is not resolved yet.
Should we keep it open until the actual codecov dropping issue is resolved? @jinran-google @jwhui


Create Sign-up page

I like to create this.

@A-jha383 I would like to work on it

Is this taken I am working on it

not yet

@A-jha383  Can I also work on this issue?

surely

hi can you please asign this to me il do it ASAP

Hello @A-jha383 , I would like to work on it. Could you assign it to me?


Fix the Java export default password generator

When exporting a certificate to a Java Keystore or Java Truststore, the password is an optional parameter. When a password is not supplied by the caller, a default password is generated by the export method. The generation library creates the random password as a bytes object. The bytes object raises an error in the 'keytool' command used to export the certificate. The keytool is expecting the password to be a str object.
The fix is to decode the generated password from a bytes object to a str object.
The associated Java plugin tests have been updated to verify the export method returns the password as a str object. In addition, the tests have been updated to correctly test the export methods response object. The original tests treated the response as a single object. The current export methods return a tuple of data (type, password, data).
In order to make the tests compatible with both Python2 and Python3, the 'six' library was used to test the password is in fact a string.

Lgtm


[UIE-95] Run yarn install before publishing packages

#4116 changed packages to be built with Vite.
The publish job run after merging that PR failed because ESBuild wasn't available. This is because we aren't running yarn install in that workflow.
Building @terra-ui-packages/components.
/home/runner/work/terra-ui/terra-ui/.pnp.cjs:261[60](https://github.com/DataBiosphere/terra-ui/actions/runs/5860272821/job/15887987415#step:14:61)
  return Object.defineProperties(new Error(message), {
                                 ^

Error: Required unplugged package missing from disk. This may happen when switching branches without running installs (unplugged packages must be fully materialized on disk to work).

Missing package: esbuild@npm:0.18.17
Expected package location: /home/runner/work/terra-ui/terra-ui/.yarn/unplugged/esbuild-npm-0.18.17-384f2c63dc/node_modules/esbuild/

    at makeError (/home/runner/work/terra-ui/terra-ui/.pnp.cjs:2[61](https://github.com/DataBiosphere/terra-ui/actions/runs/5860272821/job/15887987415#step:14:62)60:34)
    at resolveUnqualified (/home/runner/work/terra-ui/terra-ui/.pnp.cjs:27921:17)
    at resolveRequest (/home/runner/work/terra-ui/terra-ui/.pnp.cjs:27973:14)
    at Object.resolveRequest (/home/runner/work/terra-ui/terra-ui/.pnp.cjs:28029:26)
    at resolve$1 (file:///home/runner/work/terra-ui/terra-ui/.pnp.loader.mjs:1989:21)
    at async nextResolve (node:internal/modules/esm/loader:1[63](https://github.com/DataBiosphere/terra-ui/actions/runs/5860272821/job/15887987415#step:14:64):22)
    at async ESMLoader.resolve (node:internal/modules/esm/loader:835:24)
    at async ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:7)
    at async ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:79:21)

https://github.com/DataBiosphere/terra-ui/actions/runs/5860272821/job/15887987415

Realized that I needed to bump the versions of components and core-utils because, even though their builds failed in https://github.com/DataBiosphere/terra-ui/actions/runs/5860272821/job/15887987415, empty packages were still published. Filed UIE-115 to improve error handling in the publish script.