Source exposes decorators

Describe the bug
I've got a Card component that expands to fill its parent but doesn't make sense to present without a grid Container decorator. However I probably don't want to expose this grid Container decorator as the source, which seems to be how this is working.
Is there a way around this currently? unsure if this is a bug or expected behaviour (in which case a feature request!)
To Reproduce
import { storiesOf } from '@storybook/vue'
import VueInfoAddon from 'storybook-addon-vue-info'

// the component we wish to showcase
import Card from './index.vue'

// import our wrapper component to be used in the decorator, which we want to hide
import Container from '../Container/index.vue'

storiesOf('Card', module)
  .addDecorator(() => ({
    // Decorated with Container component
    components: {
      Container
    },
    template: '<container><story/></container>'
  }))
  .addDecorator(VueInfoAddon)
  .add('Card', () => ({
    components: { Card },
    template: '<card uri="/" text="Card title"></card>'
  }))

Expected behavior
I had hoped the source would show:
<card uri="/" text="Card title text"></card>
Instead this is currently showing:
<container><story/></container>
Obviously we'd ideally like this to automagically get the expected source, but I am not really across how decorators work in storybook and am unsure if it's possible?
Alternative Proposal
As a fallback second-best idea: One way I can imagine this working is to change the above example to use withInfo, in which case, could the source option also accept a string?
eg:
storiesOf('Card', module)
  .addDecorator(() => ({
    // Decorated with Container component
    components: {
      Container
    },
    template: '<container><story/></container>'
  }))
  .add('Card', withInfo({
    source: '<card uri="/" text="Card title text"></card>'
  })(() => ({
    components: { Card },
    template: '<card uri="/" text="Card title text"></card>'
  })))

A little clunky though (not DRY). Keen to hear thoughts on this issue.

@tbredin Thank you for reporting :smile_cat:
It seems difficult to fix because this addon uses story component that was wrapped with decorators (in your example, we get <container><story/></container>, not <card ...>). I think it's hard to obtain "real" story source from this addon.
But, of course, I'll look for the way to archive this :)

As a fallback second-best idea: One way I can imagine this working is to change the above example to use withInfo, in which case, could the source option also accept a string?

This idea will makes possible to show correct story source, but writing duplicated template is not a good API design...

Is there a way around this currently? unsure if this is a bug or expected behaviour (in which case a feature request!)

With storysource addon and setting source option to false, you might see expected source.

Try switching the order of the decorators:
storiesOf('Card', module)
  .addDecorator(VueInfoAddon)
  .addDecorator(() => ({
    // Decorated with Container component
    components: {
      Container
    },
    template: '<container><story/></container>'
  }))
  .add('Card', () => ({
    components: { Card },
    template: '<card uri="/" text="Card title"></card>'
  }))

I had a similar problem- I had a container decorator in a specific story and the withInfo decorator added in the global storybook config.js. After moving my container decorator to the global config and placing it after the withInfo decorator, I was able to see the actual source in the addon panel.
// storybook/config.js
import { withInfo, setDefaults } from 'storybook-addon-vue-info'
addDecorator(withInfo)
setDefaults({
    header: false
})

const padded = () => {
    return {
        template: '
<story/>
',
    }
}
addDecorator(padded)

Not positive if the ordering will still work when the decorators are added locally to a specific story.

I had the same problem. The only way to fix it without duplicating the template code was changing the code in the file @storybook\vue\dist\client\preview\index.js in the prepare method when it asks if innerStory is defined:
    if (innerStory) {
      if (story.template && story.template.indexOf('<story/>') > -1) {
        // improved code for decorated stories
        const keys = Object.keys(innerStory.options.STORYBOOK_WRAPS.extendOptions);
        for (let i = 0; i < keys.length; i++) {
          if (keys[i] != 'template' && !keys[i].startsWith('_'))
            story[keys[i]] = Object.assign({}, story[keys[i]] || {}, innerStory.options.STORYBOOK_WRAPS.extendOptions[keys[i]]);
        }

        story.template = story.template.replace('<story/>', innerStory.options.STORYBOOK_WRAPS.extendOptions.template);
      } else {
        // original code
        story.components = Object.assign({}, story.components || {}, {
          story: innerStory
        });
      }
    }

Until now it works like a charm.
I hope you can include this fix in the next version since having decorators is very common and necessary.

Fixed in #113 (only works with >= SB5)


PHP fatal error running test.php

When running test.php i am getting this error:
PHP Fatal error:  Uncaught RuntimeException: Cannot negotiate in /var/www/php-signalr-client/src/Hammershark/SignalR/Client.php:24
I think this is due to bittrex cloudflare protection and missing cookie values.

use https protocol at ur signalr server...

still no answers... so sad...

I solved this issue myself but it is a long time ago and i don't remember the solution

I solved this issue myself but it is a long time ago and i don't remember the solution

i fixed now too, most probles was with ssl certificate, and most at client.php with connect()
cos its needs ignore cert verify... im fix it now... but... its not working correctly..
its just subscribe to some server method. thats all... it cant call methods, only listen... useless...
lost many time to fix it ... so far...

我自己解决了这个问题，但这是很久以前的事了，我不记得解决方案了

我现在也修复了，大多数问题都与 ssl 证书有关，并且大多数在 client.php 与 connect() 因为它需要忽略证书验证...我现在修复它...但是...它无法正常工作.. 它只是订阅一些服务器方法。仅此而已...它不能调用方法，只能听...没用... 浪费了很多时间来修复它...到目前为止...

How did the big guy fix it


!important property doesn't work

I don't know if it's in all cases, but when I was trying to override inline styling the !important property, Stylebot was removing it.
In my scenario the pages html had this:

and I was trying to use Stylebot to override this with:
[style*="background-color: White"] {     background-color: pink !important; }
This definitely works with css, I've tested it, and I found the trick at https://css-tricks.com/override-inline-styles-with-css/.
When I add !important in the CSS Editor and click Save, it is removed.

stylebot automatically(forcibly) adds "!important" to the style actually applied to the page.
Check the "style actually applied to the page" in the following steps!

F12(DevToolsOpen)
Ctrl+Shif+C(select element mode)
click target element
check the Styles tab in Elements tab in DevTools.

I'm sorry, you are right.
My problem turned out to be letter casing. I didn't know css cared about the casing of the colors in the selector.
It my problem was that I had:

and
[style*="background-color: White"] { background-color: pink !important; }
One is uppercase "White," and the other is lowercase "white."


Webpack5 update [DRAFT]

Webpack 5 update
Includes the work listed in #9994
Additional changes:

persistent cache
upgrade to dev server ´v4 (still beta)
terser is now included in webpack

Known issues:

currently the WebpackManifestPlugin is commented out due to "path undefined" error (feel free to investigate)
It feels like webpack emits compile twice - triggers a re print out on the screen (might be due to hook behavior change - or some of the code I removed in that area - maybe rewrite?)

Things I wanted to do but left out:

extract loaders/plugins etc. into separate files to make the main webpack config clean / easier to read
allowed domains - we should allow configuration and wildcard support imho
print out performance stats of the build - really hard to track / compare build speeds - eg. detecting regression
fix the test suite or comment out failing tests - eg. the pnp test is currently failing on master not sure if this pr. makes things better or worse

Credit include @andriijas, @sebinsua and @jasonwilliams (let me know if I missed out on any)

Hey, I noticed file-loader and url-loader are still used in this PR, however they are deprecated in Webpack 5 and can be replaced with asset modules.

Yep good catch! I'll see if I'll update in the weekend :)

@raix are you on discord? I would like to get you in to be able to chat about creating a branch for webpack 5

@andriijas RaiX and 1028

@raix feel free  to join create-react-app https://discord.gg/e9q5RcPn

Could you publish updates to npm - would make testing easier...
I.e. Swap react-scripts to @raix/react-scripts

currently the WebpackManifestPlugin is commented out due to "path undefined" error (feel free to investigate)

This error is raised from webpack-manifest-plugin. Webpack 5 is not supported at now, but maintainer are planning to add support. So you can change several lines in default.config.js output section from:

output: {
// The build folder.
path: isEnvProduction ? paths.appBuild : undefined,
// blah blah blah
}
to:
output: {
// The build folder.
path: paths.appBuild,
// blah blah blah
}
Source: https://stackoverflow.com/questions/64019154/migrating-cra-to-webpack-5

@rickihastings now using asset modules
@kumarlachhani thanks, the config is simplified
@vjpr nope not going to take on the task of releasing npm packages, I don't have the time for it - I did talk with @andriijas about creating a WP5 feature branch - maybe do prereleases from that branch (eg. a cra v5 branch as removing nodejs builtin shims could be a breaking change although necessary)
Thank you for the feedback! :)

@raix
I try to change the code in App.js
import {ReactComponent as Logo} from './logo.svg';
Then the error shows:
 Can't import the named export 'ReactComponent' (imported as 'Logo') from default-exporting module (only default export is available)

Is there anything I can support with? I do like the initiative on updating webpack to v5 and would like to support if possible/needed

@lukaskoeller Currently svgr react component imports seems broken + when starting in watch mode it seems a bit clucky/extra refresh + general QA/test pnp etc. I'll try to get a feature branch up this week making it easier to test/contribute

How can i help with this PR?

I want to help too if you have too if you need any :). Hopefully this is released soon

Closing this pull-request in favor of #10961 targeted the wp5 branch


identify every moving object and mark it with rectangles

Hi, Davis,
There is a requirement on recognizing all kinds of bags on Conveyor Belt, typically, the conveyor belt in airport.
It DO NOT need to classify the bags(trolley case or any other bags) , but need to mark every bags with rectangles, no matter the type or size of the bag. After marked the rectangles, we will crop the images and send it to the server for viewing and storage.
My question is, which algorithm in DLIB is best to do with this requirement? there are many algorithms in DLIB, I am not sure which one is the best.
Thanks in advance.

I would look at these examples:
https://github.com/davisking/dlib/blob/master/examples/dnn_mmod_ex.cpp
https://github.com/davisking/dlib/blob/master/examples/fhog_object_detector_ex.cpp


High light current session card of the background

Overview (Required)

I think that it is better to change the color of the background of session card so that we can more easily notice the currently open session

Links

Thanks! Assigned 👍


Unknown error occurred

Unable to run the extension as it just says "Unknown error" and refers to a log. Not sure which log that is.

Command 'Gcov Viewer: Toggle' resulted in an error (An unknown error occurred. Please consult the log for more details.)

I face the same problem. Loading the .gcda files a second time seems to work. But I'm getting frequently that error too.
About the log files:
Command Palette: Developer: Open Extensions Log Folder.
I'm seeing the following errors in the exthost.log:
2023-10-18 14:36:14.539 [error] undefined gcov-viewer.show {"value":"JacquesLucke.gcov-viewer","_lower":"jacqueslucke.gcov-viewer"}
2023-10-18 14:37:22.818 [error] undefined gcov-viewer.reloadGcdaFiles {"value":"JacquesLucke.gcov-viewer","_lower":"jacqueslucke.gcov-viewer"}
2023-10-18 14:48:07.346 [error] undefined gcov-viewer.reloadGcdaFiles {"value":"JacquesLucke.gcov-viewer","_lower":"jacqueslucke.gcov-viewer"}


Feature request: order array items

Any chance we can either persist changes when the order of elements change in an array, or ignore the order altogether?
Things like this create a loop where terraform plan always displays this change, and apparently nothing happens after doing terraform apply, so the only way of fixing it is manually changing the order in the tf files to match it, which is not practical when using references instead of the plain uuids (i.e, going: pact_user.john_doe.uuid)

# pact_team.myTeam will be updated in-place
  ~ resource "pact_team" "myTeam" {
        id           = "b3a82ec1-a34e-4f82-845f-e41f9de3da78"
        name         = "MyTeam"
      ~ users        = [
            "967155a1-29a7-4aa3-8520-7bad949abad8",
          - "1e8c0d39-7937-4647-8886-9e40690e6886",
            "4e161b2b-b07a-4979-a69e-f5ed2727bfa4",
          - "50011c55-2fa0-4e70-b5e5-9592fc38e36a",
            "781a1bf2-9723-40c8-9cee-69ff9515c7f6",
          + "50011c55-2fa0-4e70-b5e5-9592fc38e36a",
          + "1e8c0d39-7937-4647-8886-9e40690e6886",
        ]
        # (2 unchanged attributes hidden)
    }

I believe it can be addressed if we sort items on store.

re-opening due to https://pact-foundation.slack.com/archives/C02NN7XSHDM/p1649732362957959?thread_ts=1647571379.124189&cid=C02NN7XSHDM.

Note on issue. Simple fix is to move from schema.TypeList to schema.TypeSet. The issue is that terraform change detection is performed internally, so any attempt to sort the arrays is unstable across versions and is cumbersome to address. Moving to a Set which is order independent solves the issue more natively. Tested on the roles attribute of a user in f3db0fb.


Add user signatures to PDF

Enable auto generated signatures
Enable manual signatures

Thoughts on possible methods: https://blog.stackfindover.com/signature-pad-javascript/

This can be utilized https://github.com/szimek/signature_pad

Adding signatures work, can export the data. Need to connect to the backend by adding a "signature" to a given sender. Then inserting the image via javascript.
There's a straightforward way to export the data to a file, this in Ruby:
require "base64"

data_uri = "data:image/png;base64,iVBORw0K..."
encoded_image = data_uri.split(",")[1]
decoded_image = Base64.decode64(encoded_image)
File.open("signature.png", "wb") { |f| f.write(decoded_image) }

Rather than saving an maintaining files, I'm going to attempt to save an array of the data. Then load the data into the PDF frame and use javascript to redraw:
const canvas = document.querySelector("canvas");

const signaturePad = new SignaturePad(canvas);

data = document.getElementById('signature_data').value

// Draws signature image from an array of point groups
signaturePad.fromData(data);

https://github.com/mileszs/wicked_pdf#usage-conditions---important

Added 6a7d30922d589776934611d63e75db35bd2a4988


[AutoPR graphrbac/data-plane] graph: improve API coverage on application & service principal

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5181

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/1548


'Invalid tar file' from 'keyboard-aware-scroll-view', while running yarn start

Please see log below:
yarn install v0.18.1
[1/4] Resolving packages...
[2/4] Fetching packages...
error An unexpected error occurred: "https://github.com/GeekyAnts/react-native-keyboard-aware-scroll-view: invalid tar file".

Closing this as it seems to be working fine.
Let us know if you are still facing the issue


Update color palette: Sync up with code

Add transparent palette
Turn light/dark red/yellow/blues/... into singular continuous color palettes vs. light/dark palettes (based on feedback/input by @kyranjamie)

@fabric-8 Is this issue still relevant?

Just checked, this has been resolved


Support Generating Enum Cases Asynchronously

GraphQLEnum currently only supports creating enums from CaseIterable. There are however cases where you want to create an enum from a Swift Type that is not actually an enum, but all the cases are generated from a data-source...
Is an issue for generating the Size Enums from the configuration TMDb endpoint for:
https://github.com/nerdsupremacist/tmdb
And can be considered for generating a CountryIdentifier enum for:
https://github.com/nerdsupremacist/CovidQL

As part of alpha.20 we have added support for enums that are not case iterable
But due to how the Resolution is basically BFS: asynchronous type resolution could lead to strange behavior.
Type Resolution has to be synchronous for now.
If we need to do networking to generate the enum cases we will have to use .wait()


feat: DPoP

Please go the the Preview tab and select the appropriate sub-template:

🐞 Bug Fix
⚙ Improvement
🎉 New Feature

Pull Request Test Coverage Report for Build 24

68 of 78 (87.18%)  changed or added relevant lines in 7 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 93.318%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/oidcc_userinfo.erl
10
11
90.91%

src/oidcc_token_introspection.erl
5
7
71.43%

src/oidcc_auth_util.erl
24
27
88.89%

src/oidcc_token.erl
15
19
78.95%

Files with Coverage Reduction
New Missed Lines
%

src/oidcc_token.erl
1
87.37%

Totals

Change from base Build 6:
-0.1%

Covered Lines:
824

Relevant Lines:
883

💛  - Coveralls


with docker-compose.yml "Root or postgres or any role does not exist", postgres, postgrest, swagger connect to db

Hi,
i'm new to docker and need your help .. i just cant find any solution. Trying to connect to the DB via docker-compse.yml.
C:\Users\iso01>docker ps
CONTAINER ID        IMAGE                   COMMAND                  CREATED             STATUS              PORTS                            NAMES
4960b440ac65        postgrest/postgrest     "/bin/sh -c 'exec po…"   5 minutes ago       Up 5 minutes        <IP_ADDRESS>:3000->3000/tcp           server
de9721b44783        swaggerapi/swagger-ui   "/docker-entrypoint.…"   5 minutes ago       Up 5 minutes        80/tcp, <IP_ADDRESS>:8080->8080/tcp   swagger
4bbcb3f9a698        postgres                "docker-entrypoint.s…"   5 minutes ago       Up 5 minutes        <IP_ADDRESS>:5432->5432/tcp           level3

C:\Users\iso01>docker exec -it level3 bash
root@4bbcb3f9a698:/# psql
psql: error: could not connect to server: FATAL:  role "root" does not exist
root@4bbcb3f9a698:/# psql -U postgres
psql: error: could not connect to server: FATAL:  role "postgres" does not exist
root@4bbcb3f9a698:/# psql -U app_user
psql: error: could not connect to server: FATAL:  database "app_user" does not exist
root@4bbcb3f9a698:/#

I'm using this docker-compose.yml
docker-compose.yml
version: '3.5'
services:
  server:
    image: postgrest/postgrest
    ports:
      - "3000:3000"
    links:
      - db:db
    environment:
      PGRST_DB_URI: postgres://app_user:password@db:5432/app_db
      PGRST_DB_SCHEMA: public
      PGRST_DB_ANON_ROLE: app_user #In production this role should not be the same as the one used for the connection
      PGRST_SERVER_PROXY_URI: "http://<IP_ADDRESS>:3000"
    depends_on:
      - db
    container_name: server

  db:
    image: postgres
    ports:
      - "5432:5432"
    environment:
      POSTGRES_DB: app_db
      POSTGRES_USER: app_user
      POSTGRES_PASSWORD: password
  # Uncomment this if you want to persist the data.
    volumes:
      - "./pgdata:/var/lib/postgresql/data"
    container_name: level3

  swagger:
    image: swaggerapi/swagger-ui
    ports:
      - "8080:8080"
    expose:
      - "8080"
    environment:
      API_URL: http://localhost:3000/
    container_name: swagger

maybe there is a problem with starting the container without the env variables set. So it was then initialized without user or DB info?

Thank you!

Your error Database directory appears to contain a database; Skipping initialization means the environment variables weren't applied. Whatever is in the host's ./pgdata is what's in the container, if you don't see anything in that folder then there's probably a hidden file that's causing it to be non-empty
https://github.com/docker-library/docs/tree/master/postgres#environment-variables

the Docker specific variables will only have an effect if you start the container with a data directory that is empty; any pre-existing database will be left untouched on container startup.

You might also try using a named volume instead

First of all thanks for your quick response. However, what do you mean with in the host's ./pgdata . The only time i use it is in the .yml
i've tried a lots of things from your link, but it didnt worked for me. I'm not a Developer maybe that's why i dont get it :D

I noticed a new user, wich i couldnt delete because there always a Notification with th folder is been used so i cant delete. Maybe thats the hidden problem?

The folder being used as the data directory ./pgdata:/var/lib/postgresql/data has files in it so the entrypoint script won't modify your data, which means the docker-specific environment variables aren't going to be interpreted in the container. https://github.com/docker-library/postgres/issues/203#issuecomment-255200501
You could also try asking over at the Docker Community Forums, Docker Community Slack, or Stack Overflow. Since these repos aren't really a user-help forum

alright, yea i will try it there, too. Just could you please tell me how i can find the data directory to ./pgdata:/var/lib/postgresql/data ? #203 didn't help for me either. I want to inspect it.
So all in all you can't tell me why this problem appears? i'm learning a lot but going insane too...
When i do docker inspect level3 only i can see it. I tried to change the ports or remove all (volumes too) and start all over again etc. but no
Thank you a lot!

remove all (volumes too) and start all over again

You are not technically using a docker volume, you are mounting a local folder, ./pgdata, into the container. To "start all over", you need to delete that folder (or everything in it; likely as root). Be warned, that this will delete anything that you had put into the database.

Ok, I see that point.. so the big question is, how can I delete that folder in the container? There is no problem for me to delete anything in the database, because it's empty and I'll put in data after i can bring up an API for postgres ...
Thank you guys! :)

how can I delete that folder in the container

The point is that it is not in the container. Just delete the folder: sudo rm -rf ./pgdata

ok i'm just "mounting" a folder right there, alright ^^
One last thing hopefully.. the command sudo .. ist not working for windows. I know that i need to go to command prompt with activating administration rights to over-do this, but then how can command this exactly? :/
I'm searching now for a while to find this folder

I'm not sure why or how this actually works, but I was hung up on this issue for a while now.
I had a postgres service where I specified an env_file that looked like this:
POSTGRES_USER=test_user
POSTGRES_PASSWORD=test_pass
POSTGRES_DB=test_db

Here's the docker-compose excerpt:
db:
        image: postgres:latest
        restart: always
        env_file:
            - ./.env.db
        ports:
            - "5423:5432"
        volumes:
            - postgres-data:/var/lib/postgresql/data

Outputting my config showed that all of those vars WERE being set, except for POSTGRES_USER:
  db:
    environment:
      POSTGRES_DB: test_db
      POSTGRES_PASSWORD: test_pass
      POSTGRES_USER: postgres
    image: postgres:latest
    ports:
    - published: 5423
      target: 5432
    restart: always
    volumes:
    - postgres-data:/var/lib/postgresql/data:rw
version: '3.8'
volumes:
  postgres-data: {}

I noticed that the order of environment variables differed slightly from how I defined them in my ./env.db, specifically the POSTGRES_USER var: it appeared to be defined last.
So I changed my .env.db to reflect that order:
POSTGRES_PASSWORD=test_pass
POSTGRES_DB=test_db
POSTGRES_USER=test_user

Now, running docker-compose config  to check my env vars, showed the following correct values 😄 😄 😄
db:
    environment:
      POSTGRES_DB: tesdt_db
      POSTGRES_PASSWORD: test_pass
      **POSTGRES_USER: test_user**
    image: postgres:latest
    ports:
    - published: 5423
      target: 5432
    restart: always
    volumes:
    - postgres-data:/var/lib/postgresql/data:rw

References: #203

I had the same issue, i proactively remove the volumes docker-compose down --volumes, then worked for me

delete the postgres_data folder and run  docker-compose up -d again.

remove all (volumes too) and start all over again

You are not technically using a docker volume, you are mounting a local folder, ./pgdata, into the container. To "start all over", you need to delete that folder (or everything in it; likely as root). Be warned, that this will delete anything that you had put into the database.

Thank you, it's help me. (+ removed all containers and start from scratch)

In the future, these sorts of questions/requests would be more appropriately posted to a dedicated support forum, such as the Docker Community Forums, the Docker Community Slack, or Stack Overflow.

I had the same issue, i proactively remove the volumes docker-compose down --volumes, then worked for me

After run command again docker-compose up  <container_name>


binary_search_tree.cpp: Add Binary search tree

This adds C++ implementation of binary search tree with search, insert and delete functions.
Closes https://github.com/NITSkmOS/Algorithms/issues/54
By submitting this pull request I confirm I've read and complied with the
below declarations.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the commit guidelines for this project.
[x] My code follows the standard code structure.
[x] This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
[x] This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
[x] I have mentioned the issue number correctly (with hyperlink) in this pull request description.

ack b9fe5a7


merge monero_syncer_address tests

create tuple {lws_bool, socket_name, block offset} and combine two tests monero_syncer_address_lws_test & monero_syncer_address_test. See #401.

closed by #416


docs(xslt): nesting in escape-for-regex.xspec

https://github.com/xspec/xspec/blob/529bdc4e7177821992dc99df4857bad3fd6b4f2c/tutorial/escape-for-regex.xspec#L31-L36
(2) isn't demonstrated well. This pull request fixes it.
Further work
Update Wiki with the latest examples.

Further work
Update Wiki with the latest examples.

Done (diff)


Sidebar guides

You can add the links you want in the sidebar and/or change their icons, as discussed in #1698.

Where did the Twitch integration end up?

Oh it is still just below, obviously it can be put above or anywhere.

I think it's good below. I just wondered since we discussed its position

Well, I don't really mind the placement. What's bothering me is that it always looks like it's being part of the section above it.
On another note, I updated the gap thingy.

This works and looks good. Should make these guides much easier to find!

While I'm happy to see activity around here, I must admit that after that much of a review time I probably don't have a usable dev environment for this project anymore.
I could certainly setup everything once again. Although I guess it'd even be quicker for someone else to make those changes because I don't know when I'll be able to re-download vagrant images etc.

That's fine, #1819 has your changes


Forward-port PR#366 from 2.5.x to 2.6.x (cherry-pick)

Hello Apache Struts Team.
This PR is just a cherry-pick of PR#366 into master.
Merge pull request #366 from JCgH4164838Gh792C124B5/local_25x_SendErrorEnh
Improved logging for DefaultDispatcherErrorHandler, DefaultStaticContentLoader
(cherry picked from commit 12d4feaf8f90b3af3853eb53263410e8e6f1e956)

Coverage increased (+0.06%) to 48.522% when pulling 1a93a300bb75184179bc223441d9d6684f0434f1 on JCgH4164838Gh792C124B5:local_26x_CPickPR366 into 9453e05559731a4f20e720fa268e25c0040b80c0 on apache:master.


add Sierra College

@Cxristian I am sorry, the domain sierracollege.edu is blacklisted because the school allows to register an email address there even if you are not a student of the school. If you are the student of this school, please apply with official document (OFFICIAL DOCUMENT tab at https://www.jetbrains.com/shop/eform/students).


Musician PDA doesn't play music for anyone but the musician

Description
title
Thonk?

_>

https://github.com/space-wizards/space-station-14/blob/12b7bf78b7a3d507b4d4a119dabefc3eca673b0c/Content.Server/Instruments/InstrumentComponent.cs#L32
https://github.com/space-wizards/space-station-14/blob/12b7bf78b7a3d507b4d4a119dabefc3eca673b0c/Content.Server/Instruments/InstrumentSystem.cs#L42
Found the issue. InstrumentPlayer is null in the case of the musicianpda's entity setup, so OnMidiStart returns, and the instrument doesn't get broadcast from the server. I have a fix but its extremely hacky and not robust, so its not a real fix.


Regexp Lookbehind not support with safari

The code uses regexp Lookbehind which is not supported by safari. This cause safari to error out during rendering.
https://caniuse.com/js-regexp-lookbehind

Thank you for reporting this bug @Najtu !  Would you be interested in contributing a solution via pull request?

Hi, @Najtu .  This should be fixed now with recent changes.  Could you try again and let me know if this fixed it for you?  Thank you again for bringing this to our attention :-)


#159 feat: add ConditionalPerformable to permit flow control

Here's the specs and code to permit the following kinds of conditional flow control:

Check.whether(boolean).andIfSo(...).otherwise(...)
Check.whetherQuestionTrue(Question<boolean>).andIfSo(...).otherwise(...)
Check.whetherPromiseTrue(Question<PromiseLike<boolean>>).andIfSo(...).otherwise(...)

Actually - I wanted the api to be Check.whether() for all constructor arguments for consistency with the java api, but couldn't find a way to overload the different types. Can you suggest a tweak for this please @jan-molak ?

Hey @nbarrett, I'll get back to you with more feedback on this PR as soon as I'm done with #162. Apologies for keeping you waiting.

Thanks for integrating this feature into the base product @jan-molak! 😀 I'll integrate your changes into my prod app soon!


ENH Convert ElementList into a functional component

This is needed to allow the use of hooks for dnd-kit.
This PR should change nothing about the user experience or functionality of the module, it should be a perfect like-for-like comparison to 6.0 without this PR.
Test everything you can think to test - sorting, saving, publishing, archiving, etc both from a page and an element level to check everything works the way it used to.
Issue

https://github.com/silverstripe/.github/issues/343

behat failure will be fixed by https://github.com/silverstripe/silverstripe-elemental/pull/1296 separately


FDPIN-2661 ORC-264 backport, orc and hive version bumped

Added comments to FDPSchemaEvalOrcInputFormat.java