Attribute data of actuator type is not stored

Steps to reproduce the problem:

Create a flow that generates an action

Run the flow

attribute "mensagem" is of type actuator

log flowbroker:

flowbroker_1                  | [ingestor] got new device event: { metadata: { deviceid: 'd618c9', tenant: 'admin', timestamp:<PHONE_NUMBER>066 },
flowbroker_1                  |   attrs: { str: 'atue' } }
flowbroker_1                  | [executor] will handle node switch
flowbroker_1                  | debug: Executing switch node...
flowbroker_1                  | debug: ... switch node was successfully executed.
flowbroker_1                  | [executor] hop (switch) result: [{"payload":{"str":"atue"}}]
flowbroker_1                  | [executor] will handle node change
flowbroker_1                  | debug: Executing change node...
flowbroker_1                  | [executor] hop (change) result: [{"payload":{"str":"atue"},"saida":{"mensagem":"LIGAR"}}]
flowbroker_1                  | debug: ... change node was successfully executed.
flowbroker_1                  | [executor] will handle node actuate
flowbroker_1                  | debug: Executing actuate node...
flowbroker_1                  | debug: Sending message...
flowbroker_1                  | debug: Message is: { meta: { deviceid: 'd618c9', service: 'admin' },
flowbroker_1                  |   metadata: { tenant: 'admin' },
flowbroker_1                  |   event: 'configure',
flowbroker_1                  |   data: { attrs: { mensagem: 'LIGAR' }, id: 'd618c9' } }
flowbroker_1                  | will produce to dojot.device-manager.device
flowbroker_1                  | debug: ... message was sent.
flowbroker_1                  | [executor] hop (actuate) result: undefined
flowbroker_1                  | debug: ... actuate node was successfully executed.
flowbroker_1                  | [ingestor] got new device event: { metadata:
flowbroker_1                  |    { deviceid: 'd618c9',
flowbroker_1                  |      tenant: 'admin',
flowbroker_1                  |      status: 'online',
flowbroker_1                  |      reason: 'statusUpdate' } }

Verify that the actuator attribute data is not stored

$ curl -X GET -H 'Content-Type:application/json' -H "Authorization: Bearer ${JWT}" "http://<IP_ADDRESS>:8000/history/device/d618c9/history?lastN=10&attr=str&attr=mensagem"
{
"mensagem": [],
"str": [
{
"device_id": "d618c9",
"ts": "2018-10-08T16:44:14.066000Z",
"value": "atue",
"attr": "str"
},
{
"device_id": "d618c9",
"ts": "2018-10-08T16:40:44.097000Z",
"value": "atue",
"attr": "str"
}
]
}

Affected Version: 0.3.0-nightly_20180926

Resolved by #780


In the Download page it is not mentioned that Windows 7 is not supported by the new OSGeo4W v2 repository

Description
The Download page doesn't contain a statement about the Windows version supported by the new OSGeo4W v2 repository (say Windows 10 64 bit) and the old OSGeo4W v1 repository (say Windows 7 32/64 bit) packages.
Page URL:
https://qgis.org/it/site/forusers/download.html

Fixed with https://github.com/qgis/QGIS-Website/commit/39449fd43a82ca49da2a43b7771c5cf31078edcd and https://github.com/qgis/QGIS-Website/commit/796aefe289bd24a4a682b2f27668944fe4a4432b.


Pre Genesis: The PR to make testnet happen!

Sorry for this huge PR. Really, don't have time to split into pieces. However, you can look at the history of commits as they are logically separated(the second major part at least) and hope they will make sense to you.

Is this still under active development or ready for review?

These are effectively 3 PRs I think. this contains the changes of:

https://github.com/celestiaorg/celestia-node/pull/211
then #220 itself contains fixes for #211
then all sorts of different smaller fixes and refactorings

IMO, this should be split up into at least 2 if not 3 PRs again and merged separately (on Monday and before devnet ideally).

Closing in favor of #221


wireless/bcm43xxx: handle sdpcm data only if rx sframe is available

Summary

wireless/bcm43xxx: handle sdpcm data only if rx sframe is available
handle sdpcm data only if rx sframe is available to avoid rx data drop
wireless/bcm43xxx: allocate tx frame with nonblock mode
allocate tx frame with nonblock mode
allocate rx frame with block mode
wireless/bcm43xxx: replace private queue implement to list_node

Impact
N/A
Testing
bcm43013 iperf test

please rebase the code

please rebase the code

Done, please review again

@xiaoxiang781216 @pkarashchenko ready for review now


Split compound + Optimize fusing facets

Faceting algorithm's busted. I'll reopen the pull request after I fix the algorithm.

i fixed

still experimental...


Single digit columns not scanned?

Environment details

OS: Linux Mint 19.2
Node.js version:
npm version:
@google-cloud/vision version: 1.7.2

Steps to reproduce

None really

Hey all, so I am new to the cloud vision API world. I do have familiarity with tesseract but wanted to take a stab at the cloud vision API. I am using the Node client library.
Is there any reason why in this document (screenshot below) that the single digit columns are just complete wiped? I have tried both text detect as well as document text detect. "documentTextDetection" does not see that column at all. "textDetection" does see it but not all of them. Maybe the font is too small?
Is there some configuration settings I can tweak or that I am missing? I have gone through the API docs 2-3 times now.

I also noticed that the order of the returned results don't really make much sense. For the most part its setting the rows in the document/image and reading them in vertically. Some of the items are out of order though. Not sure if this is specifically the node client or Google Cloud Vision. Figured, I'd start here. Example:
REAL IMAGE

OCR RENDER (odd order?):

did anyone find the solution

Closing this issue as the thread has been inactive for over a year. Please re-open if this is still an active issue.


Added conditional loading, fixed bug with timestampedFilename, made init public, removed setDumpdirectory

init method made public, added options hash to init to control what is loaded and from where, removed setDumpDirectory, updated lookup method to only use loaded data, fixed bug with timestampedFilename

Thanks a ton :-) Really appreciate your contributions, @chriskinsman!


[bn] Merging dev-bn into main

Describe your changes
Merged the main branch into the dev-dn branch.
Related issue number or link (ex: resolves #issue-number)
Related Issue: #410
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@sajibAdhi Thank you for your contribution, but could you open a PR that does the same thing with this PR, using this link:
https://github.com/cncf/glossary/compare/main...dev-bn
The PR you will open with that link will propose a merge of dev-bn into main without creating a separate feature branch (which is 20230623-merge-main-into-dev-bn in this PR).

@jihoon-seo, I have created this PR as you have suggested.

Closing this PR since the superseding PR #2177 is merged into main.


Fabric 1.19 crash on startup, both with other mods and alone

Launching the game with FerriteCore crashes on startup, both with and without other mods.
Here's latest.log
latest.log

Does C:\Users\censor\AppData\Roaming\PolyMC\instances\1.19 Fabric\.minecraft\config exist, and if it does, is it a file or a folder?

it is a folder

Hm, interesting. That call is not supposed to fail for existing folders AFAIK, but I can wrap it in a check anyway.

Has this been fixed? I also have this issue on 1.19.2. I haven't updated to 1.19.3 because I'm waiting on other mods

I've added a workaround, but I still don't entirely understand how this is possible. Is there anything strange about your config directory (or your MC directory)? Network folder, symlinks, strange symbols in the path, anything like that?

@malte0811  I've added a workaround, but I still don't entirely understand how this is possible. Is there anything strange about your config directory (or your MC directory)? Network folder, symlinks, strange symbols in the path, anything like that?

I'm facing a very similar crash. I am using symlinks.
What I have done is that I have two different minecraft servers proxied together using velocity.
To keep them in sync I have extracted the mods and config folder from their respective server folders into a higher folder. The symlink to mods works perfectly fine, all mods load correctly. The config symlink also worked for reading and writing in config for some installed mods, but when I copied my whole modpack including ferritecore over, it fails to launch when the symlink is set, and launches correctly with the symlink not set. (it may be important to note that I am using relative symlinks, aka ln -s ../config)
Interestingly when manually copying all contents from normal config into the symlinked config, then restoring the symlink and launching the server, it launches correctly.
That would imply to me that it is specifically an issue with how ferritecore writes to a symlinked folder.
latest.log


rename api gateway to just api

Signed-off-by: Krasi Georgiev<EMAIL_ADDRESS>

cc @metalmatze @squat

:thinking: I could have sworn I already lgtm'd this yesterday

I could have sworn I already lgtm'd this yesterday

That was in the obs/obs repo. Too many repos!

:see_no_evil:


Fix new-commit-check condition

The following two have been fixed.

test command condition
exclude .github, .gitignore, .golangci.yml when checking commits

This is the result of an action on a time-adjusted commit with git commit --date='2 days ago'.
https://github.com/shiena/goneovim/runs/6224173841?check_suite_focus=true

Thank you!
I appreciate your contribution.
Merged.


Use cake-contrib icon for NuGet package

For #14

@bdukes your changes have been merged, thanks for your contribution :+1:


Config to prevent Kemal server running.

HTTP server of Kemal always runs even if exit() is called explicitly, because server.listen is called in at_exit.
However, sometimes I want Kemal to exit without server.listen.
For example:

Illegal command-line parameters are given.
Another process of same Kemal app is already running.

Do you think how about adding Kemal.config.run property?
It should be true by default to cause no change to default behavior.
When it is false, Kemal silently exits without service.
if already_running?
  Kemal.config.logger.write "[#{Kemal.config.env}] another process is running.\n" if Kemal.config.logger
  Kemal.config.run = flase
  exit(1)
end

It is possible by adding a few lines to "kemal.cr" and "kemal/config.cr" .
I have tested it in my forked branch.

I've been thinking about this for a while. Sounds like a good idea but still there's work to do before implementing this behavior.
Currently i'm decoupling the default logger to be replacelable.

@sdogruyol  Also would it be possible to not start the server if an unhandled exception happened before at_exit is reached ? Because for now as soon as this happens it jumps to at_exit and starts the server anyway.

@sdogruyol I see.
I also think the replaceable(customizable) logger is very useful feature.
Please consider this when you can be available.

@arcage i've implemented pluggable logger behaviour please see https://github.com/sdogruyol/kemal/issues/80 for more info.
P.S: I havent documented it yet :disappointed:

@sdogruyol Thanks. I'll try it.

With version 0.11.0 Kemal won't run until you told him to run with Kemal.run. See the release notes here With version 0.11.0 Kemal won't run if there's an exception. Be sure to read the release notes https://github.com/sdogruyol/kemal/releases/tag/v0.11.0


Folder permission 777 in linux?

Since v4 new dowloads are rwxrwxrwx permission 777 in linux????

Sorry, I don't know. I don't used it for last 3-4 years.


icon font codes in TabView *tabItem directives don't work

There is what I want to accomplish :
<TabView selectedIndex="1">
  <StackLayout *tabItem="{title: ''}" class="fa">

  </StackLayout>
  <StackLayout *tabItem="{title: ''}" class="fa">

  </StackLayout>
</TabView>

Here, the font-awesome icon code shows correctly in the Label block but in the tab it doesn't.
It could be really useful to have that working :)

Hello, i have the same issue here, can someone help ? :(

The class that describes the font wouldn't find its way to the tab (the text is set via that directive).
Here is said directive:
https://github.com/NativeScript/nativescript-angular/blob/master/nativescript-angular/directives/tab-view.ts#L62
Which sets the title on TabViewItem, which can be found here.
So to add font awesome to the tab view items... I'm not sure. If the tab item were a view another directive could do a similar job in setting the item className for the element. However, the TabView is the view, and it has items so I'm not sure where the font setting would get described, or if it can be described. I need to stop looking at things when sleepy, It's a bit of a blur at the moment.

Any updates on this ?

Is there a particular reason why this was closed? As far as i can tell the problem persists.

Please open!

At first I thought this was an encoding issue, but now I realize I should have read @matt4446's explanation more carefully. It turns out {N} tab item titles are very hard to customize and I couldn't find an easy way to set a font there -- that's why the font awesome setting isn't being applied in the example above.
Once support for fonts and CSS classes for tab items lands in tns-core-modules, we can extend the directive to apply those settings in Angular apps.
You can track progress in these issues:

NativeScript/NativeScript#1269
NativeScript/NativeScript#2551
NativeScript/NativeScript#2738

Hi there,
first attempt to help, so please be gentle with the newbie ^^
For now, I use successfully the plugin nativescript-ngx-fonticon wrote by Nathan Walker
In the TabView I use it as follow:
<TabView [(ngModel)]="tabSelectedIndex" selectedColor="#FF0000" class="fa" style="font-size: 14">     <StackLayout *tabItem="{title:'fa-bluetooth' | fonticon}"> 		<TextView text='{{item.title}}' style="font-size: 12"></TextView>     </StackLayout>     <StackLayout *tabItem="{title:'fa-cog' | fonticon}">              </StackLayout> </TabView>
It just does what I expect, display an icon at the expected place.
Hope this helps,
Cheers,
Youss

I'm using nativescript-ng2-fonticon and I can use the icons directly in the tabs like this
<TabView #tabview [selectedIndex]="tabindex" class="mdi">
    <StackLayout *tabItem="{title: ' Favorites' }" orientation="vertical">
    </StackLayout>
</TabView>

@dgomezs I'm not able to do it :(

@Jonatthu you can use iconSource attribute on tabItem https://docs.nativescript.org/cookbook/tab-view-ng

@dgomezs What about fonticon from Nathan Walker? Is it possible to get that working here?

I saw this issue is fixed for the plain {N} in #4302, where you can target directly the TabView Item.
In Angular the template structor is completely different so I think there should be a fix for the Angular  version, too.
This issue should be reopened or a new one created.

Has anyone managed to add a font awesome icon to a TabBar on NativeScript-Vue yet?
I can't believe that a framework that puts itself as a sophisticated mobile development tool hasn't come up with a solution for such a ridiculously simple and obvious feature. The proposed workaround - using images through iconSource - is painfully laborious due to the whole image resizing drama.


Provide image for v1.28.0 version

Hi,
Are you working on providing v1.28 kubectl image to resolve installation issues on the last version of Kubernetes please ?
Failed to pull image "clastix/kubectl:v1.28": rpc error: code = NotFound desc = failed to pull and unpack image "docker.io/clastix/kubectl:v1.28": failed to resolve reference "docker.io/clastix/kubectl:v1.28": docker.io/clastix/kubectl:v1.28: not found

Sorry for being late, and thanks for opening this issue.
I just triggered the request for building a v1.28 compatible kubectl image, once the job is finished it should be available.
Feel free to close once ensured the artifact is there!

Thanks !


Refactor/#88 migrate contentful markdown

Change all content from contentful to markdown and remove contentful dependency.
Closes #88

@all-contributors please add @micaelr95  for code


unwinder/native: Export metrics

The unwinder stats that we have been logging using BPF's printing facilities have been very useful during the development of the DWARF-based unwinder. It has surfaced areas of improvement and bugs.
This commit exports the counters via Prometheus so our users and ourselves can track how the native unwinder is doing.
In this commit, there are some other changes:

Grouped the statistics to a single struct to be able to read the whole struct at once;
Before, the JIT samples that we are dropping weren't accounted properly if the first frame was already JIT'ed;

Note that these metrics will always be inherently racy and the sum of success + failure might be slightly different than the total sample count. For more context, check out the comment in metrics.go.
Notes
Just to reiterate for those of you following at home, we are working on improving the JIT support. Any samples that we don't know if it's correct it's dropped, never producing wrong results.
Test Plan
[javierhonduco@fedora parca-agent]$ curl --silent http://localhost:7071/metrics | grep native_unwinder | grep -v "#"
parca_agent_native_unwinder_error_catchall 0
parca_agent_native_unwinder_error_frame_pointer_rule 0
parca_agent_native_unwinder_error_pc_not_covered 0
parca_agent_native_unwinder_error_should_never_happen 0
parca_agent_native_unwinder_error_truncated_stacks 0
parca_agent_native_unwinder_error_unsupported_expression 0
parca_agent_native_unwinder_error_unsupported_jit 42
parca_agent_native_unwinder_success_dwarf 61
parca_agent_native_unwinder_total_samples 103

The wiki is maintained by the community. So if there aren't any up to date instructions, we recommend you to explore the solution yourself and hopefully contribute your findings back!


Incorrectly iterated bullets

Within the section 'Use the Security & Compliance Center to configure the user submissions mailbox' (https://docs.microsoft.com/en-us/microsoft-365/security/office-365-security/user-submission?view=o365-worldwide#use-the-security--compliance-center-to-configure-the-user-submissions-mailbox) for the second level bullets of the section, both the first and second bullets are "a".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e53205b5-8850-42b6-0b0c-8a61b7ef7776
Version Independent ID: 0a9e7903-ce3c-e877-e6b3-b45d09642308
Content: User submissions policy - Office 365
Content Source: microsoft-365/security/office-365-security/user-submission.md
Product: m365-security
Technology: mdo
GitHub Login: @siosulli
Microsoft Alias: siosulli

@coproyer Thank you for your feedback. We have created a PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/4621 to fix this.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @coproyer Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


After latest WordPress update (4.7.5) all sliders gone

Hi there,
after last update of WordPress (4.7.5) - all sliders aren't displayed anymore.
Shortcode is still active. Plugin (Version: 1.2.1) is activated. In WPs backend all slider-settings (crellyslider) are still present,but on frontend they won't show up anymore. Any hint or idea please?
Best regards,
John

Thank you for your fast response, fabiorino.
Everything else is just fine. ++Update++ It's not only me who have the issue: Other people I asked to visit our site - have the same frontend issue ++Update++: no sliders are displayed after the latest WP update on website.
Best regards,
John

Sorry, I wanted to ask you if you have any JavaScript errors on frontend

No problem. OK, here is what I got (Mozilla Firefox):

ReferenceError:  jQuery is not defined
JQMIGRATE: Migrate is installed, version 1.4.1

Error:  Permission denied to access property "href"

Error:  Permission denied to access property "href"

I have changed nothing, what else is to do to run crellyslider properly again, please?

Spotted the problem. I don't think it depends on Crelly Slider... What theme are you using?

It's a self-developed one based on Twenty Fifteen - I think. Do you think it would be better to downgrade it. It worked till now. Even Upgrade to WP 4.8 haven't fixed anything. After updating jQuery I got: TypeError: a.event.props is undefined  jquery.crellyslider.min.js:11:4868

I've released an update of the plugin that fixes an incompatibility with WordPress 4.8. Please, try to update and tell me this solves the problem.


Add sleeping dragon sequence

changes include :-

change the wording of first ending { made it reasonable for new sequence also }
player now meets a sleeping dragon instead of treasure after touching the magic circle
if the player tries to sneak towards the dragon he/she finds it's treasure
now the player have 2 options

take the treasure  -> leads to ending 1 {dragon finds you}
take care of the dragon first -> leads to ending 2-1C {where you try to fight dragon and dies}

Hi @Arsenic-ATG, welcome and thanks for your contributions 🎉


Does torchvision nightly support rocm 5.0 Linux?

🚀 The feature
I couldn't find Linux version torchvision in https://download.pytorch.org/whl/nightly/rocm5.0/torch_nightly.html. Does vision nightly support rocm 5.0 Linux? If not, any reason it doesn't? Can we add support for this?
Motivation, pitch
Our image needs torchvision on Linux for ROCM 5.0
Alternatives
No response
Additional context
No response
cc @jeffdaily @jithunnair-amd

Thanks for reporting this issue @xiaoyu-work ... we will be filing a PR for this shortly, stay tuned!

Hi @jithunnair-amd, any update on this?

Closed as torchvision nightly added rocm 5.0 Linux support now.


vs code python uses system language, not vs code display language

Environment data

VS Code version: 1.28.2
Extension version: 2018.10.1
OS and version: MacOS High Sierra 10.13.6
Python version: 3.7.0
Type of virtual environment used: virtualenv
Relevant/affected Python packages and their versions: none

Actual behavior
VS Code python extension uses system language in stead of vs code language settings. System language is german, vs code display language is english. vs-code-python language (in command palette) is german.
Expected  behavior
VS Code python extension honors the configuration of VS Code and language is the same throughout VS Code. So, vs-code-python language should be english, as stated in vs code display language.
Steps to reproduce:

switch mac os to some different language than english (german in my case, this was my macs default)
install vs code & vs code python settings
change vs code Display language to english
type "> python" into command palette

Pythons command palette(All german except the Jupyter cell commands):

Language settings of MacOS

Output of locale on the terminal:
$ locale
LANG="de_DE.UTF-8"
LC_COLLATE="de_DE.UTF-8"
LC_CTYPE="de_DE.UTF-8"
LC_MESSAGES="de_DE.UTF-8"
LC_MONETARY="de_DE.UTF-8"
LC_NUMERIC="de_DE.UTF-8"
LC_TIME="de_DE.UTF-8"
LC_ALL=

I found this issue https://github.com/Microsoft/vscode/issues/62623, but no corresponding one for vscode-python.

That's because we don't have translations for the Jupyter commands, these are new messages that haven't been translated.

Closing in favor of https://github.com/Microsoft/vscode-python/issues/3310

No, I am not reporting about the Jupyter commands being english. My vs code display language is english, but the python extension is all german.

Thanks, I'll follow this up. https://github.com/Microsoft/vscode/issues/62623#issuecomment-437991724

Reinstalling python extension fixed the issue. Not sure if/how the malfunctioning state can be reached again.

The above solution does not work for:
VS Code version: 1.28.2
Extension version: 2018.10.1
OS and version: Win10 18.09
Python version: 3.7.0
Type of virtual environment used: none
Relevant/affected Python packages and their versions: none

Thanks, @nikau6
Your workaround saved me.

This is fixed: with display language set to fr.

locale:
~$ locale
LANG=en_US.UTF-8
LANGUAGE=
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=


Wrong target framework version

KSP mods should have v3.5 here:
https://github.com/nav0t/DecouplerShroud/blob/713ac229991b0f51dbad59a57f4100a268f80047/Sources/DecouplerShroud/DecouplerShroud.csproj#L12
Originally reported by forum user Tonka Crash at https://forum.kerbalspaceprogram.com/index.php?/topic/183869-mods-with-wrong-net-target-framework/

Thanks for pointing it out. Fixed the issue in the latest commit


Include lwc_local_insert config in example config

It is very much poor design that the lwc_local connector will silently run against data in nihdb if the lwc_local_insert config isn't provided. This is an artifact of the design of our integration test suite. If the lwc_local tests are not running against data in the local filesystem, they should not run at all. We just don't have time to fix this now.

Also I want to mention that Travis has always been doing the right thing. It adds (and always has added) the lwc_local_insert config. So this PR is just clarifying how to run lwc_local tests locally.

From travis logs:
The command "docker/scripts/assembleTestingConf -i quasar_$CONNECTOR" exited with 0.
0.01s$ cat it/testing.conf
postgresql_metastore="{\"host\":\"localhost\",\"port\":5432,\"database\":\"metastore\",\"userName\":\"postgres\",\"password\":\"\"}"
lwc_local="{\"mimirDataDir\": \"/tmp/lwc-local/\"}"
lwc_local_insert="{}"


There should not be a blank value in the items per page dropdown. on customer orders page

Bagisto Version: Master
Steps To reproduce--
1. Login as a customer.
2. Click on the orders inside the profile section
3. Select the blank value from the items per page dropdown.
4. Refresh the page.
Expected result: There should not be a blank value in the items per page dropdown.
Actual result:  The customer is not able to show any order after selecting the blank value from the items per page dropdown. Please find the screenshot Here.

@devansh-webkul
Now, this issue is fixed. so I am closing this issue. and I have attached a screenshot Here. for future reference.


"memory" filesystem throws FileNotFoundError when deleting multilevel folders

When you try to delete a dir recursively in "memory" filesystem, it fails if the directory has only one sub-directory with files in it. So something like this breaks:
>>> import fsspec
>>> fs = fsspec.filesystem("memory")
>>> with fs.open("/foo/bar/baz", "w") as f:
...   f.write("qux")
...
3
>>> fs.rm("/foo", recursive=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/naman/.pyenv/versions/bionic/lib/python3.8/site-packages/fsspec/spec.py", line 821, in rm
    self.rm_file(p)
  File "/Users/naman/.pyenv/versions/bionic/lib/python3.8/site-packages/fsspec/spec.py", line 797, in rm_file
    self._rm(path)
  File "/Users/naman/.pyenv/versions/bionic/lib/python3.8/site-packages/fsspec/implementations/memory.py", line 165, in _rm
    raise FileNotFoundError
FileNotFoundError

It breaks even if I specify the maxdepth, although as per the rm documentation, no depth means no limit.
FWIW, the same structure can be deleted in other filesystems, like "file" filesystem.

I added some print statements to see what's going on. It first deletes /foo/bar/baz and then, as you suspected, fails when trying to delete the directory foo/bar/.
But it works when you don't have the bar directory and baz is directly inside foo, basically /foo/baz. In that case, it only deletes /foo/baz file and doesn't try to delete the /foo/ directory.

It sounds like you have a nice test case that can be added to the fsspec/implementations/test_memory.py file, and a potential fix which ignores errors from rmdir (see the attribute pseudo_dirs) either during recursive rm or perhaps generally.

@martindurant I have a proposed fix for this bug but I don't seem to have required access. How do I request write access to the repo? Would you be able to grant it?

The standard procedure is to

fork the repo (button in the very top right of this page), giving you a version where you do have write permission under your own account
add a new remote to your local repo pointing to the new fork
push a branch to your version of the repo
submit a pull request, either from the github screen showing your repo, or by the URL that git will give you when pushing your changes.

For safety reasons, we keep the number of people with write permissions to the repo as small as possible.

This was fixed in #454.


regex purity issues

braddr (@braddr) reported this on 2017-05-27T07:30:09Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=17442
CC List

uplink.coder

Description
At least two of the functions in std.regex that ought to be usable in a pure context aren't.  I suspect there's a broader issue with that subsystem, but haven't investigated.

---------
module bugregex;

string unifyNewLine(string str) pure
{
    import std.regex;

    return std.regex.replace(str, regex(`\r
|\r|
`, "g"), "
");
}
---------

$ dmd -c -ofbugregex.o bugregex.d
bugregex.d(7): Error: pure function 'bugregex.unifyNewLine' cannot call impure function 'std.regex.regex!string.regex'
bugregex.d(7): Error: pure function 'bugregex.unifyNewLine' cannot call impure function 'std.regex.replace!(match, string, char, Regex!char).replace'

braddr commented on 2017-05-29T02:25:15Z
That's a tiny tip of a much larger iceberg.

uplink.coder commented on 2017-05-29T02:06:34Z
The reason for this is that regex calls malloc


nixos/cinnamon: Do not set QT_QPA_PLATFORMTHEME

Mostly same as https://github.com/NixOS/nixpkgs/pull/317047.
Mint no longer ships qt5ct since Mint 22 and no longer ships a qt5ct.conf in Mint 22.1. Following their changes I think we will also drop our override and delegate the decision to user. Also the gtk2 platform theme actually depends on gtk2.
https://github.com/linuxmint/linuxmint/issues/718

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg eval


Py38

By removing the optional dependency trollius we can install this one in Python >=3.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


[SPARK-41433][CONNECT] Make Max Arrow BatchSize configurable

What changes were proposed in this pull request?
Make Max Arrow BatchSize configurable
Why are the changes needed?
make batchsize configurable
Does this PR introduce any user-facing change?
yes, one new configration
How was this patch tested?
existing tests

cc @grundprinzip @hvanhovell

+1 late LGTM


Failed to clone nvm repo. Installation on Cygwin Bash

Operating system and version: Windows 11 22H2 (Cygwin)
How did you install nvm?

Tried to install it in a cygwin bash shell.
What steps did you perform?
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash

What happened?
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15916  100 15916    0     0   244k      0 --:--:-- --:--:-- --:--:--  246k
=> Downloading nvm from git to '/home/joel/.nvm'
=> Cloning into '/home/joel/.nvm'...
fatal: cannot copy 'C:/Program Files/Git/mingw64/share/git-core/templates/description' to 'C:/home/joel/.nvm/.git/description': Permission denied
Failed to clone nvm repo. Please report this!

What did you expect to happen?
That the correct windows filepaths are getting used on cygwin.

@ljharb The problem is that C:/home/joel/.nvm/ doesn't exist. In cygwin the $HOME is pointing to /home/username.

aha, thanks. That's strange then. How is git installed?

winget install --id=Git.Git -e --accept-source-agreements --scope machine

It’d be ideal if the install script could detect that scenario tho.


zsh-autosuggestions (in antigen?) breaks some keybindings

I'm trying to use zsh-autosuggestions with antigen, apparently it works, but it breaks some keybindings:

The Home and End key do nothing, but ^A and ^E still work to move the cursor to the beginning and end of line;
^C has to be pressed two times to kill the line (^U still works, but I find ^C more convenient);
The right arrow does not accept the autosuggestion, but here I'm not sure if it is supposed to do so.

It does not matter if I add "antigen use oh-my-zsh" in my zshrc, I still get these problems. No errors are printed.
If you need me to perform any test just let me know.
Thanks!

Fixed now?

The completion is still broken. For example git commands are not completed, only files are.

Happens for me too, Home and End are not working. German keyboard and Terminology as terminal emulator.

I am also affected by @legovini's sub-issue 1:

With zsh-autosuggestions installed, the Home and End keys fail to move the cursor to the beginning and end of the line...
... but ^A and ^E still work...
.... and deinstalling zsh-autosuggestions restore working Home and End.

I run gnome-terminal-3.16, zsh-5.0.8, oh-my-zsh, and load zsh-autosuggestions with:
source $HOME/.zsh-autosuggestions/autosuggestions.zsh
unset COMPLETION_WAITING_DOTS # https://github.com/tarruda/zsh-autosuggestions#known-issues
AUTOSUGGESTION_HIGHLIGHT_COLOR='fg=3'
zle-line-init() {
  zle autosuggest-start
}
zle -N zle-line-init

Any idea?

@legovini as I use oh-my-zsh, this is not an antigen issue. Can you update the issue title?

Workaround if you use tmux \o/ ! In your ~/.tmux.conf ,
# move to next/prev word with Ctrl, http://stackoverflow.com/questions/9444900/settings-to-move-to-end-of-line-using-tmux
bind -n C-left send-keys M-b
bind -n C-right send-keys M-f

I don't think this is still an issue w/ v0.1.x.


[beta] Preview pane out of sync with challenge code

The preview pane reflects changes if and only if the "Run Test" is triggered.
And as a result falls out of sync with the code in the code editor. I submitted a challenge and this is what the next challenge looks like

This also happens mid-challenge. If you change CSS of some HTML element, it should immediately reflect that in the preview pane. Instead, it takes a Ctrl + Enter to trigger the rendering in the pane.
Browser: Google Chrome latest on Linux Mint

This is expected behavior. This prevents malformed code from freezing the preview/test iframes.


Add support for async VWO snippet

The tests remain using only the "sync" mode, which is a lie anyway since it doesn't actually invoke VWO, which doesn't seem to work within tests anyhow.
This seems to work, based on manual testing -- the relevant global variables appear to all be present and with sensible values, and the integration does successfully call .ready().

Codecov Report

Merging #9 into master will decrease coverage by 10.76%.
The diff coverage is 30%.

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
- Coverage     100%   89.23%   -10.77%
===========================================
  Files           1        1
  Lines          56       65        +9
===========================================
+ Hits           56       58        +2
- Misses          0        7        +7

Impacted Files
Coverage Δ

lib/index.js
89.23% <30%> (-10.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae84d04...3371115. Read the comment docs.


hadoop in vms

hello , i am using a tool that requires hadoop gcs connecter and hadoop in the vm. As dsub only works on compute instances. Is there a way to install hadoop into instance(tried may stuff in  vm but dint worked when submiting through dsub) Please do help me in this. I am stuck with this for so long.
Thank you

how to use dsub for dataproc? As dataproc already have hadoop installed in it which saves my time a lot

Hello,
Can you describe what you have tried doing so far? What have you tried installing? How did you try to install it? What errors do you see in dsub?
See this doc for an unofficial guide on setting up GCE instances as a hadoop cluster.
Those instructions are a bit involved, so depending on your use case, setting up clusters with dataproc may be better for you (as you have hinted at). See these docs for dataproc, and these docs for submitting jobs.

dsub 0.3.7 has requirement google-auth<=1.10.0, but you'll have google-auth 1.11.2 which is incompatible. will this create problem when authorizing since the versions are incompatable?

ERROR: (gcloud.auth.login) invalid_requestMissing required parameter: code
(base)
:~$```  when i tried to run gcloud auth login

Yes, dsub 0.3.7 introduced the requirement google-auth<=1.10.0, and you will run into issues if you have other dependencies.
My recommendations would be to either:
a) If you just need the dsub binary, install dsub in a standalone virtual environment.
a) Use dsub 0.3.6, which doesn't have this requirement.
The next version will likely upgrade the dependencies to more recent versions.


flet build windows wrong

When using flet build windows, it gets stuck at "Packaging Python app...".

Code example to reproduce the issue:
import flet as ft

def main(page: ft.Page):
    page.add(ft.Text("Hello world!"))

ft.app(main)

Describe the results you received:
PS C:\Users\hionwi\PycharmProjects\pythonProject\myApp> flet build windows
Creating Flutter bootstrap project from gh:flet-dev/flet-build-template with ref 0.22.1...OK
Customizing app icons and splash images...OK
Generating app icons...OK
Packaging Python app...

Describe the results you expected:Correct build

Additional information you deem important (e.g. issue happens only occasionally):
Flet version (pip show flet):
Name: flet
Version: 0.22.1
Summary: Flet for Python - easily build interactive multi-platform apps in Python
Home-page:
Author: Appveyor Systems Inc.
Author-email<EMAIL_ADDRESS>License: Apache-2.0
Location: c:\Users\hionwi\PycharmProjects\pythonProject\.venv\Lib\site-packages
Requires: cookiecutter, fastapi, flet-runtime, packaging, qrcode, uvicorn, watchdog
Required-by:

Give your requirements.txt file (don't pip freeze, instead give direct packages):
flet==0.22.*

Operating system:
Windows

Additional environment details:

Try use pack. Example:
flet pack main.py --onedir --icon "some_icon.ico" --name "App Name" --add-data "assets:assets"


Added LCD Brightness and LCD Lock

GoPro Camera(s): HERO4 Silver
Tested on: HERO4 Silver, 2016-07-03
Firmware version: HD<IP_ADDRESS>.00

Cool, I'll add HERO4 Silver LCD screen turn on/off and LCD timeout sleep tomorrow


Error parsing Date header

I have the following PGN file header:
[Event "I OPEN DANOBAT ELGOIBAR SUB2200"]
[Site "ELGOIBAR ESP"]
[Date "2018.10.11" ]
[Round "2"]
[White "Manso Marquez, Felix"]
[WhiteFideId "2224445"]
[Black "Fernandez Del Pozo, Anibal"]
[BlackFideId "2285584"]
[Result "*"]
[WhiteElo "2120"]
[BlackElo "1888"]
[PlyCount "0"]
[EventDate "2018.09.27"]
[SourceDate ""]

When parsing it with chess.js, it does not fully parse the date:

chess.load_pgn(value);
chess.header('Date')
[Date "[Date "2018.10.11" ]"]

I was expecting:

chess.header('Date')
2018.10.11

But it parses correctly if the date is written in ISO format (2018-11-20 instead of 2018.11.20).

Thanks for the report. For the time being you can work around this by removing the space the between quote and the square bracket (e.g. " ] to "]) in the date field.

I see where the error is: my Date header has a whitespace just before the closing bracket. I don't know if that's just an error in my PGN file or the parser should handle this. If so, I can add a PR adding the support for such whitespaces to the regex that parses the header.

Thank you.  I'll merge as soon as I fix the tests in the master branch (for some reason, tests are failing with node 0.10)


Revert "Hotfix: swedish locale as default (#40)"

yoyoyo

Whoopsie, it seems like I tricked you; I discovered that this app already exists in both Swedish and English:

English: https://splendid-resume.vercel.app/editor
Swedish: https://splendid-resume.vercel.app/sv/editor

However, it seems like the dates are not localized, but defaults to English:


[reskin] Update Proposal Details

Figma (Proposal Details): https://www.figma.com/file/9hUYtvCKjOyB92vt8ukYtD/Product-Handoff?type=design&node-id=64-3590&mode=design&t=0qs91ZixwevlTbgo-0
Should be picked up after #1563, as some components are shared (Mostly the top most details). For now the Responsiveness for these screen will remain the same. Follow up with design for any questions.

[x] Update Executable code section styles
[x] Update Proposal Details (left side)
[x] Update Breakdown section, (removing Circular Proposal Bar)
[x] Update vote section
[x] Update Proposal Action section.

Completed, closing


Animationplayer does not immediately change tracks on .play() (regression)

Tested versions

Reproducible in 4.2.2.stable
Not reproducible in: 3.x, 4.1.4.stable

System information
Godot v4.1.4.stable - Ubuntu 22.04.4 LTS 22.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1050 Ti (nvidia; 535.171.04) - Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz (4 Threads)
Issue description
Playing an animation ("Anim2") in a method called via call method track ("Anim1") and using advance(0) (like described in the docs to update immediately) still plays the calling animation ("Anim1"). This results in an endless loop causing a stack overflow.
This worked fine in 3.x and 4.1.4.
Steps to reproduce
Create 2 animations ("Anim1" and "Anim2")
Add a call method track to the first and call the following method:
func call_track() -> void:
	$AnimationPlayer.play("Anim2")
	$AnimationPlayer.advance(0)

Minimal reproduction project (MRP)
animationplayer_bug.zip

Can't reproduce in 4.2.2, the print results look like follows, I think it is correct:
1 called
2 called

I remember early 4.2 had this bug but I fixed it in https://github.com/godotengine/godot/pull/85221 so please make sure your version again.

Sorry, I somehow missed that it works correctly for the 'deferred' call method mode. It only breaks for the 'immediate' mode.
Godot v4.2.2.stable.mono - Ubuntu 22.04.4 LTS 22.04 - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1050 Ti (nvidia; 535.171.04) - Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz (4 Threads)

I could confirm this, but I think this is a fairly rare use case and extremely spec-changed, so I don't know if we can support this. Also I remember making some fixes to the process immediately after playback in AnimationPlayer, so it might no longer be necessary to hack advance(0) after 4.2. Please check if you realy need to do that.
The reason for this issue is that since 4.2, it keeps a track cache for all animations, so to reproduce the past behavior, just discard the cached method once, but this may corrupt the crossfade.
I will look into whether play() can destroy the in-process track cache if there is no fade there, but the workaround available to you now is to explicitly destroy the cache by firing stop() before the animation changes, as shown in the code below.
func call_track() -> void:
	print("1 called")
	$AnimationPlayer.stop(false)
	$AnimationPlayer.play("Anim2")
	$AnimationPlayer.advance(0)


文档描写错误

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link
https://g6.antv.vision/zh/docs/api/graphFunc/stack
Steps to reproduce
pushStack(action, data, stackType)方法中stackType 描写错乱，且默认值应该是'undo'

Environment
Info

g6
4.1.3

System
-

Browser
-

已经修复了哈，谢谢

已经修复了哈，谢谢


use new UploadRequest which is shared

by this and Unicorn.  This way we can consolidate on the same req object
remove legacy methods from V2

 IC/ICG : Turn on V2, support uploading existing assets


⚠ Orpheus has degraded performance

In 9cd1c36, Orpheus ($OPS) experienced degraded performance:

HTTP code: 200
Response time: 2374 ms

Resolved: Orpheus performance has improved in 088bcaf after 5 minutes.


chore(format): Android project formatting

Added an extremely simple .editorconfig I inferred from the main part of the project, then reformatted the codebase according to it. 🙂

👍 thanks for this.
@sjchmiela just so you know I'm going to land a full TS refactor soon #425  (hopefully today/tomorrow).


Ephemeral Dust

Only differences from https://github.com/bitcoin/bitcoin/pull/30239 are a couple lines in the functional test to use a clean chain, switch to autotools, and I did not port the release notes.
Was a trivial port otherwise.

Merged; but probably will defer cutting a release and updating miner/nodes until upstream 28.1, unless there's a reason to go faster?


Keyboard functionality for ListView

Why aren't the ScrollView functionalities

keyboardShouldPersistTaps
keyboardDismissMode

available for ListView?
Is there a reason why they aren't available? (or are they simply not done yet?)

They should be... Have you tried them?

I'm using React-native 0.8.0. Did it come after that?

I don't think so.. but we support only the latest code so you may want to try that.

I can't seem to get it working.
Love it if someone could confirm that it works or doesn't work.

If it works for someone else then updating (the ListView documentation accodordingly)[https://facebook.github.io/react-native/docs/listview.html#content] would be a solid move.

If it doesn't work then fixing/adding this feature would be wildly appreciated

My bad. I got it all working (was getting pretty tired yesterday and didn't notice I was using the main.jsbundle :< )
Adding this to the ListView documentation would be nice though. Thanks for the help @ide

@gudmundurmar @ide I've added keyboardShouldPersistTaps="always" to my ListView. However, I'm experiencing the need for the user to tap twice when selecting an item in the list – one to close the keyboard and one to press the ListView row which houses a TouchableHighlight.
I'm using a TextInput for the search box and the ListView houses the results. I'd like the user to be able to choose an item in the list without having to close the keyboard first.
I must be missing something 😐


Fix some NumPy 2.x CI failures (cont.)

Related to #8565 and #8690 .
This PR also partly fixes https://ci.preferred.jp/cupy.linux.cuda126/176161/ .


Enable single source handling

Closes #8

This will need more adaptations though, because Annoy and NGT store indexes for source and target, which would be redundant. I can adapt that.

Now it works as expected and I would merge it.


Unable to change avatar of an organisation

Observed/problematic behavior
Unable to change avatar of an organisation

Expected behavior
Avatar should save successfully
Steps to reproduce

Create an org
Attempt to upload avatar

Other
No response

I'm still getting the same error, @MiniDigger.

Having the same error notification but I am now able to change the avatar successfully.

can you test again?

Image doesn't change and error notification appears

Access to fetch at 'https://hangarauth.papermc.dev/avatar/user/HiddenOrgOnMyProfile' from origin 'https://hangar.papermc.dev' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled

reee

Access to fetch at 'https://hangarcdn.papermc.dev/images/61/612982169A864550723FB60807883A93.webp' (redirected from 'https://hangarauth.papermc.dev/avatar/user/HiddenOrgOnMyProfile') from origin 'https://hangar.papermc.dev' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

no way to fix this other than allowing all origins

https://bugs.chromium.org/p/chromium/issues/detail?id=154967

allowed *, purged cache, fixed.

Confirmed fixed on my end 👍🏻


link is broken

DebouncedBuffer used for the fancier variant of the demo
doesn't work

🙏  thanks for pointing that out. I fixed the links and pointed to versions of the post that should now hopefully be permanent. The formatting may not yet be upto snuff, but the content should be there.
Btw that post is 👉  http://blog.kaush.co/2015/01/05/debouncedbuffer-with-rxjava/


bosh-setup/azuredeploy.json needs a default network gateway set in the template

https://github.com/Azure/azure-quickstart-templates/issues/1509

Close it since it is not a bug of CPI.


Add salt to random number

salt should be a environment variable, but doing that in dart isn't as simple as in JS where you just create a .env file and .gitignore it
need to learn how to properly use environment variables in dart, add salt and then benchmark the performance with and without salt

this was NOT done, i didnt mean to close it


No BuildFrom for IArray

Compiler version
3.3.1
Minimized code

def diffs(ns: IArray[Long]): IArray[Long] =
  ns.lazyZip(ns.tail).map((a, b) => b - a)

Output
Cannot construct a collection of type C with elements of type Long based on a collection of type IArray[Long]..
I found:

    scala.collection.BuildFrom.buildFromIterableOps[CC, A0, A]

But method buildFromIterableOps in trait BuildFromLowPriority2 does not match type scala.collection.BuildFrom[IArray[Long], Long, C]

where:    C is a type variable with constraint <: IArray[Long]

Expectation
compiles

something someone from @scala/collections might like to tackle?

Another annoyance is IArray doesn't have a Factory so no .to(IArray)

with advent of code I am again bitten here, relevant methods to copy:

scala.collection.BuildFrom.buildFromArray
Array.toFactory

I wouldn't bother with IArray for normal use.  It's nice in principle that one can declare that it should be immutable, but in practice there's so much friction with the rest of existence that it's not really a win.  Obviously if anyone wants to try to get it better integrated, that's fine, but I think basically it's an idea that doesn't pan out as well in practice as one might hope.

Array is really deeply enmeshed with the entire ecosystem, both in Scala and Java.  Because of that, the surface area that you need to cover to get an IArray that works comparably is quite large, and there remain many points of friction.
In cases where you have opaque types where the point is to generate a different interface, that isn't as much of an issue: you don't want to pick up the behavior of the underlying type.  That's the point!
But with IArray, you want to pick out a small subset of a huge number of behaviors of Array that you don't obey (the mutable ones), and everything else you want to work the same (much like mutable.Seq vs immutable.Seq).  It's a ton of work.
Thus, I think pragmatically, the better approach is just to accept Array as a special snowflake, and maintain appropriate caution.  There are lots of areas where the type system can't help you.  Even though it might be able to here, I think it's easier, usually, to declare that this is a case where it could but isn't worth the effort.
In fact, I'd expect the easier interface to be having a general-purpose box Imm[A] that marks that whatever is inside shouldn't be mutated any longer.
But I have odd preferences sometimes.  Maybe IArray is the way to go for not-like-me people.  But I tried it pretty extensively, and found that for me the cognitive overhead of maintaining two interfaces was considerably worse than the cognitive overhead of just being careful around Array.

In fact, I'd expect the easier interface to be having a general-purpose box Imm[A] that marks that whatever is inside shouldn't be mutated any longer.

coming soon™ with caprese https://infoscience.epfl.ch/entities/publication/0d93a16f-f957-4c40-99db-43ed1301dff3

@Ichoran funny - i am quite happy with IArray. almost everything i need, and none of the disconcerning
mutability :)

@ritschwumm - Well, like I said, my tastes do not match everyone's tastes!


Shader preview does not reload when dependencies are changed

Simply if a shader is included in the shader that is rendered, changing the included file will not reload the preview.
The same might be true for buffer dependencies, though I had no chance to test that yet.

@Malacath-92 Can you please shoot me an email on my profile?


Tags and tests

Summary Change Description

Added test tags: multi_working, multi_broken, multi_unknown, and multi_mixed
Changed the test run in ci to use tag multi_fixed
Updated the PR template to make the author check that they updated the tags.
Fixed/tweaked broken tests I encountered.
Rearranged some more tests.

Affected Issue Numbers

Resolves no issue

Code Review Notes
none
Checklist

[x] All issue requirements satisfied (or no linked issues)
[x] Linting passes.
[x] Migrations created & committed (or no model changes)
[ ] Tests implemented (or no code changes)
[x] All tests pass

I fixed about a half dozen tests that came up in 1 test run with --tag multi_working.  I'm assuming the run I'm doing locally right now will all pass since I made the fixes and tested the broken ones individually, but I'm not sure whether github runs tests that are changed in the PR's code or whether it runs the test file as it exists in main... I guess we'll see.

Looks like run tests actually works - no errors, but there's an error in the loading of example sample table data.  I'll fix it in the load_study branch...

For some reason, running them with this tag seems to load the same data multiple times (at least I'm pretty sure), which makes things take a lot longer.

Yeah. It does load data multiple times. I was operating with the goal of "get it working and make it efficient later". I haven't fully grasped the ins & outs of what data/data-changes persist from test to test under what context, so it was easier development-wise to go with the context where I was confident I knew what data existed at the start of a test. I have some learning to do to know precisely what the test data is at any one point.

Might be an issue with the how the tests are organized (I'm sure we can improve that at some point) or might be partially due to how things run when specifying a tag that is one individual tests vs. a test class. Regardless, not really an issue atm, just noting it.

I will create an issue about this test efficiency issue and the example data load.

If we do something like this again (hopefully not), it might be worth trying to use skip-tag and just marking those classes or tests that don't pass. We can then search for that tag and eventually remove them all.

Noted, though I do like the option to run tests in those 4 cases.  I kept the tags on their own lines, so removal should be easy (could be done with a grep -v).  And inserting them was largely a search & replace operation. The thing that took time was fixing broken tests.

Merged & pushed locally.


[#4701] revise middleware

Resolves #4701 by updating custom middleware so that it is compliant with our current Django version.
The middleware that I added in https://github.com/hydroshare/hydroshare/pull/4983 was preventing ALL REQUESTS CONTAINING FILES > 2.5MB TO FAIL :(

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

METRIC
VALUE

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-5000


Enhancment: Proper support for relationships in SQLAlchemyPlugin

What's the feature you'd like to ask for.
The SQLAlchemyPlugin currently only supports the simplest of relationships, that is: Non-self-referential to-one relationships.
Support for to-many relationships at least would be crucial for this plugin.
Proposal
Given these models:
class Pet(Base):
    __tablename__ = "pet"
    id = Column(Integer, primary_key=True)
    name = Column(String)
    owner = relationship("User")
    owner_id = Column(ForeignKey("user.id"))

class User(Base):
    __tablename__ = "user"
    id = Column(Integer, primary_key=True)
    name = Column(String, default="moishe")
    pets = relationship("Pet", uselist=True)

The plugin currently generates:
class PetModel(BaseModel):
    id: int
    name: str
    owner: Optional[Owner]

class UserModel(BaseModel):
    id: int
    name: str
    pets: Optional[Any]

What we should probably be generating is:
class PetModel(BaseModel):
    id: int
    name: str
    owner_id: int

class UserModel(BaseModel):
    id: int
    name: str
    pets: List[PetModel]

@peterschutt What are your thoughts on this?

@peterschutt What are your thoughts on this?

I agree with everything said here so far. I will get the sqla 2.0 compat PR sorted first, and then look at this if no one else wants to work on it before then.

Relationships are supported now.


Pyic 7526 update text

Proposed changes
What changed
Updated some text on the app download pages.
Why did it change
New designs from UCD
Issue tracking

PYIC-7526

I also updated some of the other bits of text on the pages to match the new Figma


robyn_refresh fails to plot refreshed results when plot_folder is specified

Project Robyn
Describe issue
I am trying to refresh a Robyn model persisted to JSON. The (re)training went fine, but R displays an error when trying to save refreshed plots and CSVs to file. Here is the code I ran.
data("dt_prophet_holidays")

df <- read_csv("data/DesignHome_ANDROID.csv") %>%
    mutate(INSTALL_DATE = as.Date(INSTALL_DATE, format="%Y-%m-%d"))

RobynRefresh <- robyn_refresh(
    json_file = json_file,
    dt_input = df,
    dt_holidays = dt_prophet_holidays,
    plot_folder = "robyn_results/refresh_attempt",
    refresh_steps = 7,
    refresh_iters = 700, # 1k is an estimation
    refresh_trials = 5
)

And here is a screenshot of the error.

Most output is generated and present, except the files prefixed report_*. There are no report_decomposition.png and report_actual_fitted.png; the associated CSVs are absent, too.
This problem disappears if I do not specify a plot_folder when calling robyn_refresh.
Provide reproducible example
Here is the obfuscated CSV containing refreshed data, along with a JSON file of the model I intend to refresh. (Extension .json changed to .txt, so that GitHub would allow the upload.)
RobynModel-1_433_1.txt
bug_report.csv
Environment & Robyn version
Robyn 3.7.2, R 4.2.1

Thanks for reporting this issue and special thanks for sharing a reproducible example; without it would have been pretty hard to debug. That said, I've deployed a fix into the master branch that should take care of this case. Can you please update Robyn to the latest dev version, retry, and let me know if it ran OK?

It fixed the problem: Robyn is now producing all expected output files. Thanks for the quick fix!


Support for Craft 4

Add support and test plugin for Craft 4
https://craftcms.com/docs/4.x/extend/updating-plugins.html

Yes please! We would really love Craft 4 support.

@timeverts & @romainpoirier please see https://github.com/perfectwebteam/craft-mailchimp-transactional/releases/tag/v2.0.0


[v1.2.x] fix: backport caused missing import

https://github.com/longhorn/longhorn-tests/pull/1019
https://github.com/longhorn/longhorn/issues/4260

Test result - https://ci.longhorn.io/job/private/job/longhorn-tests-regression/1709/


Build system compatibility

Default build configuration file
It seems that default build configuration file has changed from MRUBY_ROOT/build_config.rb to MRUBY_ROOT/target/host.rb, but I think this is unnecessary incompatibility and has a large impact.
For compatibility, I think it's better to use MRUBY_ROOT/build_config.rb if it exits when MRUBY_CONFIG or MRUBY_TARGET is not specified.
enable_debug and enable_test
enable_debug and enable_test were not specified in host target in mruby2's default build configuration file, but they are specified in mruby3's default build configuration file. I think it is better not to specify these for the following reasons.

enable_debug is turned off at #4045.
Since default configurations are used in ruby-build etc., it is better not to have unnecessary options.
target/host-debug.rb can be used for debugging. We may prepare target/host-test.rb for testing.

The term "target"
I think the term "target" has been used mainly for things that can be obtained by MRuby.each_target and MRuby.targets (instance name of MRuby::Build). However, MRUBY_TARGET is used as name of build configuration file, which is a bit confusing.
Especially the following points are confusing.

Multiple MRuby::Build instances can be specified in the build configuration file, so there is no one-to-one connection with MRUBY_TARGET.
The required name host as instance name of MRuby::Build is the same as default value for MRUBY_TARGET.

enable_debug was turned off by default by 3c55cb0. enable_test was kept as it was turned on by default in mruby2's build_config.rb.
Regarding the term "target", I have no strong opinion. Do you have any idea? "config"? "build"?

enable_debug was turned off by default by 3c55cb0. enable_test was kept as it was turned on by default in mruby2's build_config.rb.
Regarding the term "target", I have no strong opinion. Do you have any idea? "config"? "build"?

I'm sorry, I made a wrong comment and closed this issue. I will comment again later.

enable_test was kept as it was turned on by default in mruby2's build_config.rb.

enable_test was turned on in the test target, but off in the host target.

Regarding the term "target", I have no strong opinion. Do you have any idea? "config"? "build"?

I wish there was a good term to replace MRUBY_TARGET, but I can't think of it.
However, I don't think it is necessary to introduce a new mechanism because the MRUBY_TARGET mechanism can be realized by the existing mechanism in the first place.
For example, I think the following two have almost the same meaning and ease of use.
$ rake MRUBY_TARGET=boxing

$ rake MRUBY_CONFIG=target/boxing.rb

And to avoid the term "target", the target/ directory should be changed to build_config/ and so on.

It seems that default build configuration file has changed from MRUBY_ROOT/build_config.rb to MRUBY_ROOT/target/host.rb

In explanation of mruby, the expression build_config.rb is frequently used including official documents, so I think that it will not make sense if the file is no longer used.
The MRUBY_TARGET mechanism seems to have little improvement, so I don't think it should be changed to avoid unnecessary confusion.

$ rake MRUBY_TARGET=boxing

$ rake MRUBY_CONFIG=target/boxing.rb

If this difference is also unacceptable, you can change it to use build_config/${MRUBY_CONFIG}.rb if the path specified in MRUBY_CONFIG does not exist.
I will create a PR in this direction later.

#5098 was merged.


Add rocket chat import tool

This PR adds the support to import the following data from Rocket Chat:

All users
All public/private channels
All teams and their public/private channels
All discussion rooms as topics in their parent channel
All the messages in all the channels
All private conversations
Reactions on messages (except for custom emojis)
Mentions in messages (except @all, @here mentions)

Features remaining to be added:

User avatars
Attachments
Default streams
Custom emojis
@all, @here mentions
Starred messages
Threads as separate topics
Import messages longer than 10,000 characters.

Should this already work for the initial list of data?
I'm seeing if message["rid"] in direct_channels_list: on a first run.

@iammattmartin Thanks for reporting this. Would it be possible for you to add a print(message) statement before this line, i.e., line 432, and share the message object for which the error is occurring? I'm not sure what kind of message this is which is not having a room_id.

Sure.
{'_id': 'TNFWJeb6ivXkkzFcL', 't': 'room_changed_privacy', 'rid': 'cGbD4N6B4QAZYSf2T', 'ts': datetime.datetime(2019, 2, 22, 1, 55, 58, 787000), 'msg': 'Private Group', 'u': {'_id': 'ztSfEeAh5uaFYLLWq', 'username': 'xxxx'}, 'groupable': False, '_updatedAt': datetime.datetime(2019, 11, 6, 8, 59, 31, 295000)}

@iammattmartin But this does have a rid key. The message object causing error shouldn't have that key and it must be printed just before the error.

Ah sorry, here is the full error.
Converting Data ...
Traceback (most recent call last):
  File "./manage.py", line 157, in <module>
    execute_from_command_line(sys.argv)
  File "./manage.py", line 122, in execute_from_command_line
    utility.execute()
  File "/srv/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/srv/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/srv/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/srv/zulip/zerver/management/commands/convert_rocketchat_data.py", line 45, in handle
    do_convert_data(rocketchat_data_dir=data_dir, output_dir=output_dir)
  File "/srv/zulip/zerver/data_import/rocketchat.py", line 621, in do_convert_data
    private_messages=private_messages,
  File "/srv/zulip/zerver/data_import/rocketchat.py", line 432, in separate_channel_and_private_messages
    if message["rid"] in direct_channels_list:
KeyError: 'rid'

Is this what got logged after including the print(message) statement above line 432? I just want the last message that got printed just before the error trace, to see what kind of message that is that does not have a rid, i.e., it doesn't belong to any room.

The output was quite large, (many hundreds of lines) but last line above the traceback was:
{'_id': 'p4v37myxc6yLZ8AHh', 't': 'livechat_navigation_history', 'ts': datetime.datetime(2019, 11, 6, 0, 38, 42, 796000), 'msg': ' - applewebdata://9124F033-BFEF-43C5-9215-DA369E4DA22D', 'u': {'_id': 'rocket.cat', 'username': 'cat'}, 'groupable': False, 'unread': True, 'navigation': {'page': {'change': 'url', 'title': '', 'location': {'href': 'applewebdata://9124F033-BFEF-43C5-9215-DA369E4DA22D'}}, 'token': 'ebxuypgh0updo6klkobzhp'}, 'expireAt':<PHONE_NUMBER>794.0, '_hidden': True, '_updatedAt': datetime.datetime(2019, 11, 6, 0, 38, 42, 796000)}

We never actively used this and deleted it but seems that some data is never actually removed from Rocket.Chat

On testing a bit more removing the livechat entries, we now get:
Traceback (most recent call last):
  File "./manage.py", line 157, in <module>
    execute_from_command_line(sys.argv)
  File "./manage.py", line 122, in execute_from_command_line
    utility.execute()
  File "/srv/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/srv/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/srv/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/srv/zulip/zerver/management/commands/convert_rocketchat_data.py", line 45, in handle
    do_convert_data(rocketchat_data_dir=data_dir, output_dir=output_dir)
  File "/srv/zulip/zerver/data_import/rocketchat.py", line 661, in do_convert_data
    output_dir=output_dir,
  File "/srv/zulip/zerver/data_import/rocketchat.py", line 390, in process_messages
    raw_messages.append(message_to_dict(message))
  File "/srv/zulip/zerver/data_import/rocketchat.py", line 337, in message_to_dict
    reactions = list_reactions(message["reactions"])
  File "/srv/zulip/zerver/data_import/rocketchat.py", line 320, in list_reactions
    for react_code in reactions:
TypeError: 'NoneType' object is not iterable

Printing the last error gives:
{'_id': '4MYyEiVTk3vLBsJLcW', 'rid': 'TPX9byRJwy4Wmsh5tztSfEeAh5uaFYLLWq', 'msg': 'Message text here', 'ts': datetime.datetime(2018, 9, 25, 21, 3, 18, 704000), 'alias': 'Person Name', 'u': {'_id': 'TPX9byRJwy4Wmsh5t', 'username': 'user', 'name': 'Person Name'}, '_updatedAt': datetime.datetime(2018, 9, 25, 21, 3, 30, 211000), 'editedBy': None, 'editedAt': None, 'emoji': None, 'avatar': None, 'customFields': None, 'attachments': None, 'mentions': [], 'channels': [], 'reactions': {':joy:': {'usernames': ['username2']}}}

Looks like I won't be able to remove those as easy.

Updated code to ignore the messages which do not belong to any channel (these messages generally represent server-wide events) and use conditionals of form if dict_name.get("key_name") instead of if "key_name" in dict_name, as the latter passes if there's an item in the dictionary of the form dict_name["key_name"] = None, which we don't want.
@iammattmartin Can you try running this again?

Looking good.
2021-07-12 15:12:56.878 INFO [] Start making tarball
2021-07-12 15:12:57.030 INFO [] Done making tarball

Imported and no errors, but will let you know if we see any other oddities.

Final note, all data seems to look good. Can't comment on the bits unsupported but we didn't use attachments, threads or starred messages.
Many thanks for this!

Added test coverage for this PR.
The CI failure is unrelated to this PR.
ERROR: zerver/models.py no longer has complete backend test coverage
  Lines missing coverage: [869]

@garg3133 this looks great!  In addition to resolving the inline notes above, we should add a /help/import-from-rocketchat article similar to the existing ones for Slack/Mattermost; that's worth doing in this PR since it's a place to document caveats like the lack of support for custom emoji and uploaded files.
(BTW, I think rather than commenting out the custom emoji code, we'd be better off just having it be an empty array at the top-level function, so the plumbing doesn't need to be cluttered with commented blocks that likely work).

@garg3133 can you rebase this, so that it drops the already-merged commits from the PR?

Also, it'd be great to have a long comment with the overall status; I think we're close to merging but am not sure where my attention would be best spent on further work.
@hackerkid I'd like your thoughts from another round of review as well.

At this point, this PR majorly misses the documentation part, which I plan to add this weekend. I have updated the code resolving all other review comments, except for the stream_post_policy which I haven't looked into yet.
All the other remaining review comments (the comment at the top, first comment of second review and the mention_user_ids thing) involve changes that affect all the import tools and are better done as separate PRs.

I've added the stream_post_policy as well for the read-only channels in Rocket.Chat. While looking for it in the Rocket.Chat docs, I also find out that Rocket.Chat also supports multi-user direct messaging and archiving a stream.
I've added the support for huddles in the To-Do list above (in PR description) but I'm not sure about the equivalent for archive feature in Zulip.
According to Rocket.Chat docs:

Archived: Tells if a channel is archived and toggles the archived status of a channel. Nobody can post messages in an archived channel, and channel search will not find that channel.

I've added documentation for Rocket.Chat as well, please take a look.

Added support for importing huddles as well, since it is an important feature and should be available on the first merge.

It looks like links to the stream are broke.

Yes, as the markdown of the messages is not processed in the backend during the import, mentions and links to other streams are broken. For mentions, we explicitly mark for each user (if this user is mentioned in this message or not) during the run of this tool only, so clicking over the mentions do not open their profile popovers.

Currently we mention whether a channel is part of the team in description. Unless it's the main channel.
I think there are two main issues because of this.

We loose the original description of the stream.

No, we don't lose the original description, it is just prepending the [Team {team_name} channel]. to the actual description of the team channel. It is not appearing here because those channels actually don't have any channels.

It's not at all obvious from the main stream menu on the leftside of the app which stream belongs to which team.

This is actually true for Rocket.Chat too. In Rocket.Chat, all the normal public-private channels are mixed up with teams' public-private channels, so you can't tell just by looking at the channels in the left sidebar if the channel is a normal channel or it belongs to a team, and if it does belong to a team, to which team? You can only tell this by first opening the channel and looking at the channel header, where the team name is mentioned.

Could probably even a bigger issue if two or more teams have channels with the same name since users can be part of multiple teams.

Yes, users can be a part of multiple teams but still, no two teams can have channels with the same name in Rocket.Chat. All the channel names appearing in the left sidebar (whether it is a team's main channel, team's public/private channel or a normal channel) have unique names.

I think the solution might to have a naming convention like this
* For the main channel let's call it - {team_name} - main
* For other channels lets call it - {team_name} - {channel_name}
* And we keep the original description

Yes, we can do this but it will just make the streams look different to how they looked in Rocket.Chat (users might be used to how the channels were arranged in Rocket.Chat and such a change in channel arrangement might get them confused?):

Teams' main channels are no longer together and at the top of stream list (this was the main reason of pretending [TEAM] to the teams' main channel names.
Teams' channels names will change in the left sidebar and {team_name} might happen to occupy a large space in the left sidebar and then the actual channel name mighe not be visible properly.

What does the following mean? Does it means the user used to be part of team-harry-potter and thp-channel-2 and no longer does? Since the topic is mentioned in the room and not the actual stream itself. At the moment we treat it lilke the user is not subscribed to the stream right? Was that the case when you created the import as well?

"__rooms": [
	"GENERAL",
	"random",
	"team-harry-potter > t-h-p discussion",
	"thp-channel-2 > thp-channel-2 discussions",
	"random > random discussion"
],

This means that the user is subscribed to the discussions t-h-p discussion and thp-channel-2 discussions in Rocket.Chat, but is not subscribed to the channels to which these discussions belong. For the random channel, the user is subscribed to the channel as well as one of its discussions.
For such cases, while importing the discussions as a topic in their parent stream, we do not subscribe such users to the streams. After importing the organization to Zulip, admins would have to decide themselves whether to subscribe such people to the whole stream, leave those people from the discussion or just move the topic to a new stream to which the users who are left out can be unsubscribed.
I should have mentioned all this in the Ceveats section of the documentation, my bad!

In Rocket.Chat, all the normal public-private channels are mixed up with teams' public-private channels, so you can't tell just by looking at the channels in the left sidebar if the channel is a normal channel or it belongs to a team, and if it does belong to a team, to which team? You can only tell this by first opening the channel and looking at the channel header, where the team name is mentioned.

hmm. I would have imagined they must have a better UI than that. If they don't explicitly show the team name either then I guess it's probably fine for us to not show that in the stream name as well.

Yes, users can be a part of multiple teams but still, no two teams can have channels with the same name in Rocket.Chat.

Ahh. I got confused by their documentation which showed "docs" as one of the example channels they have shown in the their documentation demonstrating the "team" feature. Kind of a misleading example since, docs is the exactly the kind of channel which multiple teams can have.
https://docs.rocket.chat/guides/user-guides/teams/teams-channels/create-new-channel-for-a-team

This means that the user is subscribed to the discussions t-h-p discussion and thp-channel-2 discussions in Rocket.Chat, but is not subscribed to the channels to which these discussions belong. For the random channel, the user is subscribed to the channel as well as one of its discussions.

Cool. Thanks for the clarification. I wonder whether we should subscribe the users to the channels in that case? Better they unsubscribe themselves later than they missing some probably important messages right?

Better they unsubscribe themselves later than they missing some probably important messages right?

But if the channel is private, wouldn't that lead them to access the messages they are not supposed to see? Isn't there a way to somehow just notify the users that they are no longer a part of these discussions/topics and should contact admin to either invite you to the stream itself or shift the topic to a new stream which you can subscribe to, if your presence is important in the discussion?
Maybe we can create an additional bot user with some name like Zulip importer bot in the imported organization and send some direct messages to the user from this bot account that they are no longer subscribed to so and so discussions?

But if the channel is private, wouldn't that lead them to access the messages they are not supposed to see?

hmm. How does the feature work exactly in Rocket.Chat? Can users be added to only certain discussions instead of adding to the entire stream or is it more like the user choosing to only follow certains discussions in a channel which they are already added?
if it's the former, then we can skip the subscriptions for private streams and keep the public ones. Yeah. Something like the bot will also work. But I imagine we need to modify our import tool to support this particular use case.
I can't really seem to find anything useful in their docs. They also seems to also have "threads" along with discussions. How does that fit in here?

Can users be added to only certain discussions instead of adding to the entire stream or is it more like the user choosing to only follow certains discussions in a channel which they are already added? Who decides what discussions the user have access to in private streams?

I tried playing with the discussions a bit and found out that both parts of the first statement above are true. Initially, the person creating a discussion decides who is going to be a part of that discussion (invitees may or may not be subscribed to the parent channels). But after a discussion is created, anyone who has access to that channel can join the discussion voluntarily. So, for public channels, anyone can join a discussion (even without joining the parent channel) and for private channels, only the people who are subscribed to that channel can join the discussion themselves (others would need to be invited to join the discussion).

then we can skip the subscriptions for private streams and keep the public ones

Yeah, this makes sense.

They also seems to also have "threads" along with discussions. How does that fit in here?

When they created discussions, they were initially called Threads. But I guess when the users didn't like it much, they changed its name to Discussions and just copied Slack's implementation of Threads. More details here.
For threads, currently we just mix them with the normal messages according to timestamps, but we'll be making them as separate topics in a follow-up of this PR.

I think given the complexity of this PR at this point, it makes sense to merge what we have and make further improvements in follow-ups.  I've done so after a quick pass on the documentation.  My top priorities are the following:

The documentation should spell out the exact commands required to get the Rocket.Chat database dump into the right format, including a tar command to generate something that they can send to the Zulip Cloud team (and can also unpack in the self-hosted instructions).
From experience talking to users of past import tools, custom emoji are probably the most important missing feature, followed by attachments.

I'm going to delay advertising that this feature exists for anything other than early testing/QA while we do near-term improvements.
Huge thanks for adding this!


refactor BaseClassifier attribute _threads_to_use to _n_jobs

refactor the the base classifier attribute _threads_to_use to _n_jobs in order to conform to the general style.

Classes still using Parallel(n_jobs=self.n_jobs) (without underscore):
_tsf.py
_boss.py
_rise.py
_ensemble.py
_muse.py
_weasel.py
clear_sky.py
Maybe I missed some ...

Classes still using Parallel(n_jobs=self.n_jobs) (without underscore):
_tsf.py _boss.py _rise.py _ensemble.py _muse.py _weasel.py clear_sky.py
Maybe I missed some ...

So I guess this is why it hasnt been changed .... I agree that they should all use _n_jobs, but I think I will keep it to classifiers for now, not sure what clear_sky.py is

I'm not touching _tsf as I had to hack it to work, it needs redoing. This refactor is more complex that I imagined.

I'm going to close this for now and just raise the issue https://github.com/scikit-time/scikit-time/issues/102


Show error test: application after rollback is possible

Coverage remained the same at 47.185% when pulling 62d46dca2e28e04227751b10ad9fceae1ceede5f on testkit into 4e41494067aa16e42103d2eff612822cf6cf105e on master.


€ character cannot be entered

[x] I have read the FAQ.
[x] I have searched in existing issues.

Environment

OS: Windows
scrcpy version: 1.18
installation method: Windows zip
device model: OnePlus 7T
Android version: 11

Describe the bug
When I'm writing a text, everything works, except the € character.
When I press ALTGR+E or CTRL+ALT+E, I get this error in the console.
On errors, please provide the output of the console (and adb logcat if relevant).
[server] WARN: Could not inject char u+20ac

Yes, unfortunately, Android does not support injecting non-ASCII chars on text injection.
It's the same with adb shell input text €.
https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#special-characters-do-not-work
Duplicate of #37.

Are you sure? ASCII doesn't include öäüß and I can enter it.

See https://blog.rom1v.com/2018/03/introducing-scrcpy/#handle-accented-characters for explanation.

Thanks. I hope this can be fixed in the future.

AFAIKT this isn't fixed at all with #2632
For Linux yes but not for Windows if you require mirroring mode.
I couldn't find any way to enter €, µ, ² or ³ - not even in --otg --hid-keyboard mode.
Tried

-otg --hid-keyboard -> no mirroring :-(
--serial=<....> because of #2632
--prefer-text		-> doesn't work.
--raw-key-events	-> doesn't work.

Changing the language of the physical OTG keyboard didn't help either.
With 4. I can't get anything else but the English keyboard layout...

@l1m3r Yes, unfortunately, € could not be injected from the Android API. I'm also annoyed by that.
With scrcpy --hid-keyboard (scrcpy -K), it works, but not on Windows because we can't access USB if adb already uses it (on other platforms this is not a problem).

Maybe there's a way around it - One can enter € and so on via copy/paste.

[server] WARN: Could not inject char u+20ac
disable clipboard-sync temporarily (if it's used).
store clipboard content of device temporarily.
set device clipboard to just the character from 1. and paste it.
restore 3.
re-enable 2.

@l1m3r I tried something similar in the paste #1426 but I abandoned the idea (see the thread).


Vickel: Watch hotstream10.com

Vickel requests the watch of the watch_keyword hotstream10\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

hotstream10\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


[SP-6527] Backport of PDI-20071 - Broken Welcome page help link in 10.1 PDI Client (10.1 Suite)

Original PRs:

pentaho-kettle#9245
pentaho-kettle#9264

@ddiroma

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 17m 47s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl assemblies/static

:exclamation: No tests found!
:information_source:  This is an automatic message


[faucet] add waypoint for testnet revision 7c4b87a

Motivation
Fix testnet.
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
yolo
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r+

:pushpin: Commit ad766f0 has been approved by sherry-x

:hourglass: Testing commit ad766f0b0457d1779d39dc9012570456fe8019d7 with merge 18d65e37a3d1ca0ade3dd7454f18a5dab15334e9...

This will break faucet for devnet tho

@bors-libra r-

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
State: approved= try=False


optimize code style

Coverage remained the same at 100.0% when pulling 8e6524dc9785c99680ed5d63a0b631ac9f65171a on master into 4c356f4cd87265ea3391ac1386e4c6c22e681601 on upload.


remove unnecessary proto def in FunctionsConfig

Remove unnecessary proto def in FunctionsConfig. We don't need to fqfn field in FunctionsConfig

retest this please

@jerrypeng As far as I can tell this is necessary for users to be able to specify FQFN in a function's YAML config, like so:
jar: my-jar.jar
className: org.example.functions.MyFunction
inputs:
- persistent://sample/standalone/ns1/in
output: persistent://sample/standalone/ns1/out
fqfn: sample/ns1/my-func

@lucperkins My feeling is that this is should be a command line helper rather than something in the fqn. Thus I would vote it to be removed from protobuf, even if that means that in the config file, we need to specify tenant/namespace/name

@srkukarni I feel like FQFN should be settable either via the command line and via YAML or neither. Inconsistent interfaces will likely sow a lot of unnecessary confusion.

In that case, I'm now questioning the viability of having this feature. Having tenant/namespace/name AND fqn clearly pollutes/increases the surface area unnecessarily imo. @jerrypeng @sijie do you guys have thoughts on this?

I am ok with users specifying functions via fqfn but currently FunctionConfig already has tenant, namespace, and name fields.  Adding another field fqfn would be redundant and create multiple sources of truth which can easily result in bugs later on.

I think the underlying issue here is that using a Protobuf definition as a source of truth for configuration management is an anti-pattern in itself. At some point we should strongly consider using a more native approach.

@lucperkins I have discussed with @sijie @srkukarni, we are going to create another class for functions that is user facing and the FunctionConfig proto will be the internal representation.

retest this please

retest this please

@sijie can we merge this?


Support for new GPT4 models

Describe the feature or improvement you're requesting
`const configuration = new Configuration({
apiKey: OPENAI_API_KEY,
});
const openai = new OpenAIApi(configuration);
function createCompletion(questionText) {
const request = openai
.createCompletion({
model: "gpt-3.5-turbo",
prompt: questionText,
max_tokens: 1200,
temperature: 0.7,
})
return request.then((response) => {
return response.data
})
}`
When I set the model to new model "gpt-3.5-turbo", I got 404
Additional context
No response

your "gpt-3.5-turbo" request has to look like something like this:
const { Configuration, OpenAIApi } = require("openai");

const configuration = new Configuration({
  apiKey: process.env.OPENAI_API_KEY,
});
const openai = new OpenAIApi(configuration);

const completion = await openai.createChatCompletion({
  model: "gpt-3.5-turbo",
  messages: [{role: "user", content: "Hello world"}],
});
console.log(completion.data.choices[0].message);

https://platform.openai.com/docs/api-reference/chat/create?lang=node.js

How do I tell it to use gpt-4?

@ralyodio set model: "gpt-3.5-turbo", to gpt-4. You have to get access though via the waitlist.

I'll give that  a try. I currently used text-davinci-003

Doesn't work I get a 404.

is there something I'm doing wrong? I wish they would document their api for this library:
			const res = await this.ai.createChatCompletion({
				model: "gpt-3.5-turbo",
				// prompt: aiPrompt,
				messages: [{ role: 'user', content: aiPrompt}],
				temperature: 0.4,
				max_tokens: 4000 - aiPrompt.length,
				top_p: 1,
				frequency_penalty: 0,
				presence_penalty: 0,
				stop: ["\"\"\""],
			});


refactor: cleanup producer code

no need to different config flags (mongoConfig, redisConfig...). Use just --config`
naming should be consistent to avoid redundancy since it is already namescoped

e.g. change gcs.GCSProducer in gcs.Producer

move Producer interface in the producer package for consistency and isolation
define a factory for producer instead of different createXXX methods
change emitter.Emitter.Initialize sequence of if using factory with a producer factory map

e.g. producerFactory["mongodb"].createProducer()

@ugol
In this branch

added factory  in emitters to simplify the producers creation
changed the various --xxxConfig in --producerConfig
changed the Redis configuration to add the TTL in the config file to uniform the factory interface

In producers/factory.go there is an (unused for now) factory and the Producer interface. The Factory is filled with factory func by the init method that should go in every concrete impl (see https://github.com/ugol/jr/blob/161-refactor-cleanup-producer-code/pkg/producers/http/init.go for an example, unused for now)
It is true that that best practices say that "Go interfaces generally belong in the package that uses values of the interface type, not the package that implements those values" but I believe that it depends on how you structure the code. If you move everything that is not "exportable" to internal and use the pkg to export producers than I think it is better to have a producers.Producer interface (like io.Closer) in a separate package the defines the behaviour (someone could use JR as a framework and just implement his own producer somewhere else.
Moreover, if we leave the Producer interface in the emitter package the Factory must go there as well to avoid circular references
See the crypto and the aes or cipher std packages for an example
See also this


Trajectory file cannot be written with UFCalculator

This mini-script demonstrates the issue. I have an ASE Atoms object and want to run dynamics/optimization with it using the UFCalculator from UF3.
from uf3.forcefield import calculator
from ase import Atoms
from ase.io import trajectory
from ase.optimize.sciopt import SciPyFminCG

atoms = Atoms(...)
uf3_calc = calculator.UFCalculator(uf3_model)
atoms.calc = uf3_calc
traj = trajectory.Trajectory(traj_file, mode='w', atoms=atoms)
dyn = SciPyFminCG(atoms)
dyn.attach(traj.write)
dyn.run(steps=1)

The last line above raises an attribute error:
Traceback (most recent call last):
  File "/home/sung/UFMin/sung/data/pt_bulk/ufmin.py", line 74, in <module>
    dyn.run(steps=1, fmax=ufmin_fmax)
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/optimize/sciopt.py", line 113, in run
    self.callback(None)
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/optimize/sciopt.py", line 102, in callback
    self.call_observers()
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/optimize/optimize.py", line 108, in call_observers
    function(*args, **kwargs)
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/io/trajectory.py", line 132, in write
    self._write_atoms(image, **kwargs)
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/io/trajectory.py", line 167, in _write_atoms
    c.write(name=calc.name)
AttributeError: 'UFCalculator' object has no attribute 'name'

If I try to work around this by setting calc.name manually in my mini-script, it raises yet another attribute error:
Traceback (most recent call last):
  File "/home/sung/UFMin/sung/data/pt_bulk/ufmin.py", line 75, in <module>
    dyn.run(steps=1, fmax=ufmin_fmax)
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/optimize/sciopt.py", line 113, in run
    self.callback(None)
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/optimize/sciopt.py", line 102, in callback
    self.call_observers()
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/optimize/optimize.py", line 108, in call_observers
    function(*args, **kwargs)
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/io/trajectory.py", line 132, in write
    self._write_atoms(image, **kwargs)
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/io/trajectory.py", line 169, in _write_atoms
    c.write(parameters=calc.todict())
  File "/home/sung/miniforge3/envs/ufmin/lib/python3.10/site-packages/ase/calculators/calculator.py", line 623, in todict
    for key, value in self.parameters.items():
AttributeError: 'UFCalculator' object has no attribute 'parameters'

I think the incorporation of UF3 into ASE should be made more complete.

Closing, since it was resolved in #110


refactor settings, add AwardYear scope

@dreamfall worth to rebase

@dreamfall something wrong with these tests

specs fail in master

I will check mailer collab spec later - as it on master