[BUG] Very slow load of flashcard modal (since 1.11.2)

Describe the bug
Extremely sluggish performance when loading the flashcard review modal. I will click the "Review Flashcards" button and nothing will happen. After ~30 seconds, the review flashcards modal will finally pop up. The issue occurs on the most recent versions of the plugin on both Windows Desktop and Android. This seems related either to the most recent plugin version or the most recent Obsidian version as 2 days ago things were working fine.
Versions (please complete the following information):

OS: Windows 11, Android
Obsidian version: 1.5.11
Plugin version: 1.12.1
If on desktop, Installer version: 1.4.13

I'm experiencing the same issue on a MacBook Pro (MacOS 13.04.1) after the most recent update.
Versions:

OS: Catalina 13.04.1
Obsidian version: 1.5.11
Plugin Version: 1.12.1
Installer version: 1.4.14

What is more, on my iPhone the flashcard review modal won't show up at all.
Versions:

iOS 17.4.1
Obsidian: 1.5.11
Plugin version: 1.12.1

I have the same issue.
OS: Windows 10, Android 13
Obsidian version: 1.5.11
Plugin version: 1.12.1
If on desktop, Installer version: 1.5.11

I've always experienced times when there are very slow load times, i.e. prior to recent upgrades of either Obsidian or the plugin.
I haven't paid too much attention, but I'm quite sure this has happened for either:

When plugin first loads
When showing the flashcard review deck selection tree

Sometimes with load times probably of the order of 30 seconds.
When the plugin first loads, or when opening the flashcard review deck selection tree, the plugin iterates through every note in the vault to find flashcards. This overall process hasn't changed.
If you turn on logging, the actual load times will be available through the chrome debugger tools (ctrl-shift-i)

My vault has about 3000 markdown files, load times on Windows 10 Desktop using 1.12.1 are:

Thanks @bgreenawald for summarizing that so clearly.
I'll look into it in the next few days...

I turned on logging and tested a few loads using the previous and current versions of the plugin, both with the current version of Obsidian. This was on my Windows 11 PC.
Plugin Version 1.11.2

SR: Sync took 1496ms
SR: Sync took 1123ms
SR: Sync took 1080ms

Plugin Version 1.12.2

SR: Sync took 22449ms
SR: Sync took 23439ms
SR: Sync took 21797ms

dear @bgreenawald, could You explain how to switch the plugin to old version?

@19031988 I used the BRAT plugin (https://github.com/TfTHacker/obsidian42-brat) which lets you load plugins from Github and pointed it to the 1.11.2 release.

Hi there
To implement enhancements for 1.12, I needed to make use of a different Obsidian API for obtaining tags. This likely is the cause of the slow down.
I have reverted the code to use the API that was originally used, but because I personally didn't experience the slow down, I can't test myself.
Could you please try...
There is a file called main.js in this zip file
main_914A.zip
You will need to copy that to the obsidian plug-in folder, e.g.
D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition
Then reload the plug-in, or restart obsidian.
There is some extra debug. This might give a clue about the reason for our different experiences.

Ronny

dear @ronzulu . I used a file from your zip.
But the behavior of my application has not changed:

note tree loading is very slow when Obsidian is first started too;
command showing the next note to repeat freezes on the PC;
the same command showing the next note to repeat does not work at all on Android.

Hi @19031988 thanks for trying that out
Could you please send through a screenshot from the developer console.

Restart Obsidian
Within Obsidian press Ctrl-Shift-I - the developer tools should appear
click on "console" and
take a screenshot - I'm after everything

Thanks
Ronny

dear @ronzulu here You are

Dear @19031988
Sorry, I forgot to mention one thing.
Before taking the screenshot, wait for the status bar to display the plugin's info:

Then after that, click on the flashcard icon, and wait for the flashcard tree to be displayed.
Then take the screenshot like you did earlier.
And happy birthday for a couple of weeks ago :-)
Cheers
Ronny

dear @ronzulu here You are again. And the greatest thanks for happy-birthday-words )

I'm getting similar results with the new beta. See screenshot below (this is all I could capture in a single screenshot but nothing else in the console seemed particularly relevant):

Hi again
I've come up with a new version which logs quite detailed timing info. It doesn't fix the problem, but hopefully will give me enough info to identify the problem.
Could you please try this out:
main_914B.zip
After restarting Obsidian (or reloading the plugin), wait for the initial load to complete, i.e. when the status bar shows the plugin info:

From the developer console, you should see something like:

Because there is so much info, save the log to a file, right-click:

And post the file to me.
Cheers
Ronny

@ronzulu here you are. Great that you don't give up)
obsidian.md-1712426543860.log

Hi @19031988 thanks for that (and the encouragement)
I've updated main.js in the post above (now main_914C.zip), and added a note regarding clicking on "show more..."
If you could please try the new version with extra logging, and post the log file, that would be appreciated.
Cheers
Ronny

@ronzulu here you are the updated log. It is exciting how is deep this rabbit hole )
obsidian.md-1712489190423.log

Hi @ronzulu
For what it's worth, I also attach a log of the plugin's performance on my system. I do appreciate your looking into this issue!
Cheers
Joachim
obsidian.md-1712489672963.log

Hi @19031988
Thanks for that. for some reason the last few lines from the log wasn't saved (the highlighted lines shown below).
If you still have that session open, a screenshot would be great:

Otherwise, please go through the process again, save the log and take a screenshot of the last page of the debug outlook.
The log file and screenshot must be from the same session.
Thanks
Ronny

Hi @jharst , thanks for sending that through.
Strange though - it seems to be with an older version. Can you please redo with the main_914C.zip above.
In the log it should say "C3":

Also, please take a screenshot (same as for @19031988 in the previous post).
Cheers
Ronny

I'm sorry I missed the new version. Here is my log and a screenshot as requested!
obsidian.md-1712491719594.log

Thanks @jharst @19031988
I think I've fixed the issue, could you please try:
main_914D.zip
If this hasn't worked, please send through the log file again.
Cheers
Ronny

Hi, Thanks again – this works very well for me and the load time is considerably shorter!

dear @ronzulu ! Big yes it works!
And as you may be remember on old version   showing random note didn't work on my mobile.
And I tested this your D-version on mobile, and it works! Great thanks!
You plugin is base, is fundamental instrument of my approach in job. With these freezes i was sad, so i am glad like shining toad now! )

Great, thanks @jharst @19031988 for all the back and forth diagnosing this!
@bgreenawald are you able to give this a test? Would be good if you can before I put in the PR.

Hey @ronzulu
Unfortunately, my computer isn't letting me download the latest beta for some reason. It's triggering my anti-virus and completely blocking the download (I've never seen it do this before and don't know how to fix it). If you can upload the raw main.js file, I can give that a try.
Best,
Ben

Hi @bgreenawald Unfortunately GitHub won't late me upload a JavaScript file...
So I've put the zip file on dropbox, hopefully you can download:
https://www.dropbox.com/scl/fi/2dbi1v9mcnxxfglz20w04/main_914D.zip?rlkey=wskn5aewbi9594h9qljv0wh7f&dl=0
Cheers
Ronny

The newest beta has ~5-second load times for me. Seems like the issue is largely resolved.
Best,
Ben


Mutex causing trouble on OSX

Hi there.
I got a problem on Fmod GDNative implementation using a Mutex on OSX.
The lock is called in runCallbacks, which is called by update.
Here is stack trace:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib            0x00007fff6c3202c6 __pthread_kill + 10
1   libsystem_pthread.dylib           0x00007fff6c3dbbf1 pthread_kill + 284
2   libsystem_c.dylib                 0x00007fff6c28a6a6 abort + 127
3   org.godotengine.godot             0x0000000104770d75 handle_crash(int) + 1605
4   libsystem_platform.dylib          0x00007fff6c3d0b5d _sigtramp + 29
5   ???<PHONE_NUMBER>00000000 0 + 0
6   libGodotFmod.osx.dylib            0x000000011d4777b7 godot::___godot_icall_void(godot_method_bind*, godot::Object const*) + 55
7   libGodotFmod.osx.dylib            0x000000011d44b7a4 godot::GodotFmod::runCallbacks() + 52
8   libGodotFmod.osx.dylib            0x000000011d44704c godot::GodotFmod::update() + 412 (godot_fmod.cpp:141)
9   libGodotFmod.osx.dylib            0x000000011d44cc9b godot_variant godot::__wrapped_method<godot::GodotFmod, void>(void*, void*, void*, int, godot_variant**) + 59 (Godot.hpp:211)

I tried with the engin version, the problem is not present.
I tried GDNative version on windows and the problem is not present.
So it seems to be a problem with Mutex gdnative binding on OSX platform.
Here is the code
Look for runCallbacks method in godot_fmod.cpp.
It does the same thing with a Mutex as local variable.
Even if I change gdnative init (just to test):
extern "C" void GDN_EXPORT fmod_gdnative_init(godot_gdnative_init_options *o){
    Callbacks::mut = new Mutex();
    Godot::gdnative_init(o);
}

by:
extern "C" void GDN_EXPORT fmod_gdnative_init(godot_gdnative_init_options *o){
    Callbacks::mut = new Mutex();
    Mutex mut2;
    mut2.lock();
    Godot::gdnative_init(o);
}

It crash at starting.

wrong place I create one in godot-cpp, sorry.


set contract error detail is_type(t.second)!!

i create a contract and it's error when i set it :
Reading WAST...
Assembling WASM...
Publishing contract...
Error 3030000: transaction validation exception
Ensure that your transaction satisfy the contract's constraint!
Error Details:
is_type(t.second):

Can you post a link to the source code?

i use the string type, and i think it's the error:
      private:
        // @abi table
         struct test {
            account_name    user_name;
            string         letter;

            uint64_t primary_key() const { return user_name; }
         };

Please, link to the full source code including the ABI file.

This issue has been silent for a while, so I am closing.
If you still have the problem and wish to discuss further, please post it in https://eosio.stackexchange.com. To keep things organized, Github issues are intended for bugs reporting and features tracking, and Stack Exchange is the right place for any technical support discussions. Thanks!


rp2040 tiny support?

is there a rp2040 tiny support planned?

also is it posible to flash it via xblast?

Havent tested it yet, but i assume is the same pinout as rp2040 zero.
RP2040 zero is compatible.

I am not currently working on any xbox application, but surely it will be flashable in a future

Could you please test rp2040 tiny with "v0.2"?

Tt's weird none of rp2040 including tiny is working when I flashed them with v0.2. All of them are working fine with v0.1. Although I've reflashed from scratch using flash_nuke. Now, I'm rolling back to v0.1.

Thanks i will check that.

RP2040 Tiny deffo works. I built one, initially running beta 0.0, I didnt get around to trying 0.1 but just flashed 0.2 and its still working fine with Cerbios with my v1.1 Xbox.
I'm not sure if this has any bearing but my d0 is tied directly to ground, not to the RP2040 at all.


Run Spring Boot from a docker container

Run Spring boot project from a docker container

TO DO

export login and password of BDD
build and publish docker image of server from github workflow

It work's! https://github.com/pierrick-marie/spring-blog/commit/eb27c7dff87f471a19a984c5932ca7cd645d854a


question about software SMBus wait function

my MCU is ESP32, run at frequence 80Mhz. develop with esp-idf.
i read the PDF, and confuse with the wait function.
i have modified the implement of function waitEE with
vTaskDelay(ms/portTICK_PERIOD_MS);
however, i have no idea how to modified the wait function.
should i just leave it like this?
MLX90614_SMBusFreqSet(160);
For now, i got always -1(wrong ACK value) from function MLX90614_GetTa while everything work fine with
Arduino running on atmega32 (use library Adafruit_MLX90614)
i am looking forward for your reply and assistant.

oh~there is an i2cTools in esp-idf. i have solve it~


free(): invalid pointer

我以以下代码方式尝试运行代码，能够输出结果，但是会有指针错误，错误信息如下图：
import torch
from LightMUNet import LightMUNet
model = LightMUNet(
            spatial_dims = 32,
            init_filters = 32,
            in_channels=3,
            out_channels=1,
            blocks_down=[1, 2, 2, 4],
            blocks_up=[1, 1, 1],
        )

model.cuda()
x = torch.randn(4, 3, 256, 256).cuda()
outputs = model(x)
outputs = torch.sigmoid(outputs)
print(outputs.shape)

Not sure exactly what went wrong but spatial_dims=32 doesn't look right. It should be either 2 or 3. Most likely 2 in your case if you have a 256x256 image with 3 input channels and a batch size of 4.
class LightMUNet(nn.Module):

    def __init__(
        self,
        spatial_dims: int = 3,
        init_filters: int = 8,
        in_channels: int = 1,
        out_channels: int = 2,
        dropout_prob: float | None = None,
        act: tuple | str = ("RELU", {"inplace": True}),
        norm: tuple | str = ("GROUP", {"num_groups": 8}),
        norm_name: str = "",
        num_groups: int = 8,
        use_conv_final: bool = True,
        blocks_down: tuple = (1, 2, 2, 4),
        blocks_up: tuple = (1, 1, 1),
        upsample_mode: UpsampleMode | str = UpsampleMode.NONTRAINABLE,
    ):
        super().__init__()

        if spatial_dims not in (2, 3):
            raise ValueError("`spatial_dims` can only be 2 or 3.")

Maybe try something like:
model = LightMUNet(spatial_dims=2,
        init_filters=32,
        in_channels=3,
        out_channels=1,
        blocks_down=[1, 2, 2, 4],
        blocks_up=[1, 1, 1])

Not sure exactly what went wrong but spatial_dims=32 doesn't look right. It should be either 2 or 3. Most likely 2 in your case if you have a 256x256 image with 3 input channels and a batch size of 4.
class LightMUNet(nn.Module):

    def __init__(
        self,
        spatial_dims: int = 3,
        init_filters: int = 8,
        in_channels: int = 1,
        out_channels: int = 2,
        dropout_prob: float | None = None,
        act: tuple | str = ("RELU", {"inplace": True}),
        norm: tuple | str = ("GROUP", {"num_groups": 8}),
        norm_name: str = "",
        num_groups: int = 8,
        use_conv_final: bool = True,
        blocks_down: tuple = (1, 2, 2, 4),
        blocks_up: tuple = (1, 1, 1),
        upsample_mode: UpsampleMode | str = UpsampleMode.NONTRAINABLE,
    ):
        super().__init__()

        if spatial_dims not in (2, 3):
            raise ValueError("`spatial_dims` can only be 2 or 3.")

Maybe try something like:
model = LightMUNet(spatial_dims=2,
        init_filters=32,
        in_channels=3,
        out_channels=1,
        blocks_down=[1, 2, 2, 4],
        blocks_up=[1, 1, 1])

yeah,I got some of the parameters wrong.Thanks for your help.


Can i suppress diagnosing message?

Thank you for your efforts,
I want to see only lsp loading messages, but recently fidget shows additional messages about diagnosing.
I cannot find the options which can do this. Is there any way to suppress them?

The "Diagnosing" message is specific to an LSP server (in this case, lua_ls).
I just pushed a feature that supports filtering on a per-message basis. You should be able remove those messages with something like:
progress.ignore = { -- NOTE: this is short-hand, not the actual syntax for specifying a nested table
  function(msg)
    return msg.lsp_client.name == "lua_ls" and string.find(msg.title, "Diagnosing")
  end,
}

@j-hui
It is solved, Thanks


500 error when trying to create a course for an organization that is not published

Bug Report
Problematic behavior/code
When an organization is not published, if we try to add a course page via the page creation wizard, we get a 500 error.
Expected Behavior
We expect to be able to create a new course page even if the related organization is not published.
Steps to Reproduce

Create an organization page but don't publish it
Go to this organization's page on the frontend
Click "create" at the top right of the page
Choose "New course page..."
Fill in the title and code information
Click "create" at the bottom right of the modal
You should get the 500 error

Environment

Richie version: 2.6.0
Platform: Docker

Closing as I could not replicate this error but only a 500 error related to code validation which is fixed in PR https://github.com/openfun/richie/pull/1422.


added IntelliJ settings

I know this can be a controversial topic, but I've found it helpful during collaboration if everyone involved uses the same IDE settings.
JetBrains provides details on how to safely share IntelliJ configurations here: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839 , which is what I used for this pull request.

@nhajratw I'm OK merging this, but as I don't use IntelliJ myself, someone else will have to make sure those files are updated.


Lower default min_collection_interval to 10s

What does this PR do?
Lower the default min_collection_interval for postgres & mysql to bring the metric interval inline with the default interval that dogstatsd uses.
Motivation
This makes plotting the DBM query metrics (postgresql.queries.*, mysql.queries.*) less error prone because the interval lines up more closely with the default rollup windows currently used in the query engine.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Closing as this default needs to be applied at a deeper level.


Add results table

Updating README to contain a table of results obtained in our experiments

Looks good. I wish my other repos had nice README files like this.


Fix typo

https://github.com/AngryLawyer/rust-sdl2/commit/96646020331d9fdc6b967200ee5f5901863ee9f0#commitcomment-9472599
https://wiki.libsdl.org/SDL_ControllerButtonEvent#line-16
Seems that it should be which anyway.
Maybe improve comments on this file as a whole later.


Settings persistence

Store JSON in %ProgramData%.
File should be read when visualizer is first started.
File should be written at two points:

after TransferObject returns (as the debuggee might have changed settings)
after PropertyChanged is triggered on settings object

How can we persist parser specific settings? If we have a single settings file, we'll have to find some way of merging settings from multiple parser/lexer classes into a single object.
Alternatively, we could store each lexer / parser settings in its own file. We'd need some sort of naming scheme, as we couldn't use \ from the path as the file name.
We could simply use numbers and store the corresponding assembly / classname in the global settings file.

You might want to consider that such setting might be project-specific (or more likely, solution-specific). Can you use .suo file for that purpose?

@bclothier I don't think so. The visualizer is purely a runtime DLL, parts of which are injected into the debugged DLL. There may not always be a loaded project.
But I'm thinking to make it assembly-specific; IOW, every time a given assembly (either the executing assembly, or the current assembly) is debugged, it will use the same selected parser as last time.

There's another wrinkle here. The visualizer DLL is loaded in two places: in Visual Studio, and in the debugged assembly; both halves communicate using serialized data. But the Visual Studio side has no knowledge of which DLLs are loaded; we have to make a special request to the debuggee side.

And the only DLL which has any meaning in this context is the assembly of the visualizer target type (Assembly.GetAssembly). For the purposes of this visualizer, that's enough. I tried these others, and they all returned either the Microsoft visualizer base DLL, or null (I don't recall).

Assembly.CallingAssembly
Assembly.GetEntryAssembly
Assembly.GetExecutingAssembly

It should be noted that reading the type of the object targeted by the visualizer, is only useful for the ANTLR visualizer; it doesn't say which assembly is currently being debugged.


Redirect to trailing Slash

Is there a way to redirect a ghost url to include a trailing slash
https://example.com/blog/post -> https://example.com/blog/post/
Default behavior seems to be that ghost serves a page for both the slashed and non-slashed URL. This is causing problems for us and we need a way to choose one or the other.
Is there a configuration option for this somewhere?

Hi @russelltaylor05, I'm not sure what you're seeing but Ghost does not serve a page at both, it always enforces the trailing slash. If you've got a configuration problem and need support, please use our slack community or stackoverflow. GitHub is for tracking issues with the software.


pull request for e2e test at 12/28/2016 22:56:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


style: changing border radius descriptions to reflect latest guidance

:tada: This PR is included in version 4.17.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Cafe Menu Step 58 font casing

Describe the Issue
The instructions ask to learner to use the Impact font.
One learner on the forum posted that the tests fails use of using lower case first letter for the font name.
In the screenshots, one picture is the rendering of the unaltered code, the other using impact (lower case) font name.
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-basic-css-by-building-a-cafe-menu/step-58
Your code
h1, h2 {
  font-family: impact;
}

h1, h2 {
  font-family: Impact;
}

// both are valid syntax

Expected behavior
The tests should pass use of either impact or Impact.
Screenshots

System
NA
Additional context
No response
### Tasks

The test right now is:
const hasFontFamily = new __helpers.CSSHelp(document).getCSSRules().some(x => x.style['font-family'] === 'Impact');

which constrict to a specific casing
it could be transformed into
const hasFontFamily = new __helpers.CSSHelp(document).getCSSRules().some(x => x.style['font-family'].toLowerCase() === 'impact');

Thanks for opening this issue.
This looks like something that can be fixed by "first-time" code contributors to this repository. Here are the files that you should be looking at to work on a fix:
List of files:

curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/5f3ef6e056bdde6ae6892ba2.md

Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or our forum if you need help contributing; our moderators will guide you through this.
Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first.
Happy contributing.


first_value and last_value should have identical signatures

Describe the bug
Less of a bug per se, but it would be nice to have identical function signatures between first_value and last_value
To Reproduce
No response
Expected behavior
No response
Additional context
No response

take

@timsaucer
Could you provide more details about what you mean by ‘nice to have identical function signatures’? From what I’ve reviewed in both the code and documentation, the function signatures for first_value and last_value already appear to be identical. I’d appreciate your insights!

first-value
last-value

It seems like the signature is identical already, feel free to reopen it with more detail about the issue


diff in weeks seems to be off

Steps to reproduce

d1 = Timex.date {2016, 3, 27}
d2 = Timex.date {2016, 4, 3}
Timex.diff d1, d2, :days # => 7
Timex.diff d1, d2, :weeks # => 0

Description of issue

if the diff in days is 7 I would expect the diff in weeks to be 1

Fixed in master


Misspelling

The "using Newtonsoft.json;" had been misspelled, it should be "using Newtonsoft.Json;"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ef71b45e-0bb6-6e61-3b42-8e8f150db9fb
Version Independent ID: 129fb470-7186-059a-fbe8-29b1caf96bf9
Content: Introductory Guide to Using NuGet Packages from within Visual Studio
Content Source: docs/quickstart/install-and-use-a-package-in-visual-studio.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

thank you for your feedback.

You're welcome :)
Please change "using Newtonsoft.json;" in part 3, please.

oops. Thanks for pointing out the other, more important, instance. It'll go live then next time fixes are merged.


toRepresentation/fromRepresentation for a single field?

@s-ludwig
Can we define a toRepresentation/fromRepresentation for a single field?
eg if I have a single (or a few) problematic field but the other ones should follow the default serialization/deserialization rules
ideally it'd work as an UDA:
struct Foo{
 int normal1;
 string normal2;
 string fun1(){...}
 auto fun2(string repr){...}
 @toRepresentationCustom!fun1
 @fromRepresentationCustom!fun2
 byte[]bar;
}

A way to achieve this without UDA support is to use properties:
struct Foo {
    @ignore byte[] bar;
    @property @name("bar") {
        string barString() const { return ...; }
        void barString(string) { bar = ...; }
    }
}

toRepresentation would require a custom type, similar to this:
struct Bar {
    byte[] data;
    alias data this;
    string toRepresentation() { ... }
    static void fromRepresentation() {}
}

struct Foo {
    Bar bar;
}

@s-ludwig Thanks!

how about if we want to override to/from Bson conversion (instead of to/from string), eg to map DateTime to Bson's DateTime (but more generally than that example)?
what if I have little control over Foo (eg it is auto generated such as via dproto), how would define barString outside of Foo (again, in the single field case) ?

Sorry for the noob questions ...

ping on this, especially the 2nd point: what if I have little control over Foo (eg generated via dproto)


New Multiplayer Levels require going to ladder after submitting

When playing one of the new levels and using the submit button, after it runs I'm met with this dialog:

I don't have the option to just return to the code, I'm forced to return to the ladder, then reload the page.

Yep. seen this as well. I just press escape though

Even after so much redesigning, this is still a (frustrating) issue, by the way. The Esc workaround works, but it is non-intuitive.
Also, there's no way to get back to the world map, the multiplayer game view only has a button to go back to the ladder view.

You're right. We have another redesign coming for this focusing on the user experience; we've got some wireframes together, just need to find time to build it.

Oh, nice to hear that. :smile:
I've just opened an unrelated user experience issue (#3215), I wonder if the next redesign already covers that?

After pressing Esc you can then press the browsers back button and it should load up the campaign you were just in before starting the level.
Now I don't know if causes issues with how the game state is being tracked by the web application, but it should at least get the student back to the campaign area.

@Harry-the-Wanderer CoCo is not a SPA and does not intercept the back button navigation as far as I know. When navigating back to the campaign view, I believe the application sends an uncached request to fetch the player information, so it should work properly.

This might be a hack, but why not just create a hyperlinked button on the multiplayer level complete screen that just creates a browsers back button effect.  So when you click on the "button" all it really does is a window.history.back(); effect or similar.

@Harry-the-Wanderer the problem with history.back() is that it won't work when you open the level in a new tab. I guess it could work for most cases, though it is not the ideal solution.

Actually, CoCo is a single-page web application (using Backbone) and does not perform a new page load when you go back, instead keeping a lot of data that it had loaded previously.

Oh, that's good to know, my bad! 😅
I knew about Backbone, but really, CoCo does not feel very much like a SPA—the UI doesn't shake around nor slows down when transitioning views, there's hardly any of the bugs or quirks typically found in SPAs (such as memory leaks, broken back/forward navigation or accumulated event listeners). I may have to take a second look at Backbone sometime soon.


Fix debug_signals method bug introduced in #334

I have found by coincidence, that #334 introduced a bug to debug_signals method and because of that core tests with traces failed. Here is a fix for that issue.
This case also show, that #316 is needed, so that problems with traces can be found before merge.

And the type-checker didn't catch that because auto_debug_signals is, by necessity, weakly typed.


Analyzer incorrectly reports this as an unidentified_identifier if followed by an interpolation

For example:
class A {
  void f() {
    var foo = '';
    print('$this$foo');
  }
}

reports a diagnostic on $this.

FWIW, this is blocking a linter roll into the SDK: https://dart-review.googlesource.com/c/sdk/+/264961

I'm not sure I'd consider this a P1, but that said, there's a slightly shorter test case:
class C {
  void m() {
    print('$this$this');
  }
}

The first use is flagged but the second isn't.
In case it's useful, the dump of the relevant portion of the AST for the above code is
┊   ┊   ┊   ┊   ┊   ┊   ┊   ArgumentListImpl [32..45]
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊        static parameter types = [Object? object]
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   StringInterpolationImpl [33..44]
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊        static type = String
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   InterpolationStringImpl [33..33]
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   InterpolationExpressionImpl [34..38]
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   SimpleIdentifierImpl [35..38]
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊        name = this
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊        static type = dynamic
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   InterpolationStringImpl [39..38]
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   InterpolationExpressionImpl [39..43]
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ThisExpressionImpl [40..43]
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊        static type = C
┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   ┊   InterpolationStringImpl [44..44]

The first use is not recognized as a this expression while the second one is.

I'm not sure I'd consider this a P1

Fair.  I'd rather it not get lost though since it's blocking the linter roll (which will take a while to get unblocked even once this lands since it needs to get to flutter before I can update flutter to be prepared for the new linter 😬).
Is there a tag I can apply that communicates that this is blocking something downstream?

Not that I know of. I'll note that I wasn't aware that this issue is blocking a roll when I said that. Given what I know now, I'd mark this a P1 too.

https://dart-review.googlesource.com/c/sdk/+/265083

I am not sure if the test can ideally be in the analyzer, or be better in _fe_analyzer_shared. I don't know how to execute (or write expectations of ) CFE tests.

Could also the previous condition in the proposed change identical(next, $_) be removed? As the underscore is not separate from the lexeme I think, but that could be another change.

Thanks so much for jumping on this @asashour.  Much appreciated!


Momo does not recover when loosing the db connection

Possible solution: Increase the number of attempts to reconnect to the db (do you actually ever want to stop?)
See Mongo Docs: connection-settings/
Probably increase reconnectTries to something very very high.

I think the linked documentation is somewhat outdated. It looks like those reconnection options are no longer supported.


Split most of the Numeric specs into separate spec files.

This big file was getting too unwieldy tracking all the Numeric functionality in one place - it has now been mostly split up into many files, by trait name.

Suddenly this morning the FreeBSD build is failing, even though it was working yesterday.
I'm going to merge this PR regardless of that failure.


Emoticons cannot be completely turned off

After turning off emoticons, the emoticon icon on the homepage has disappeared, but once you enter the tool and exit, a blank emoticon box will appear.
This problem has been around for a long time. I always thought this bug was obvious enough to be fixed in the next version, but it didn't.

Just not noticed that😅 thanks


Maintenance release 0.14.2 broke our use

I haven't had the chance to look into it yet, but upgrading to 0.14.2 broke our system, downgrading to 0.14.1 works.
It seems to stem from the response not always having values, especially if they have just been set.
Some further research required, which I currently don't have the time to do, but just a heads up, the maintenance release may be a critical breaking change.

Our setup uses redis:
$driver = new Redis([
    'servers' => [
        [
            'server' => $options['redis_ip'],
            'port' => $options['redis_port'],
            'ttl' => $options['redis_timeout'],
        ]
    ],
    'password' => $options['redis_password'],
    'database' => 1,
]);

$this->pool = new Pool();
$this->pool->setDriver($driver);
$this->pool->setNamespace($options['namespace']);

$cache_instance = CacheRepository::getInstance();
$pool = $cache_instance->pool;
$item = $pool->getItem(Settings::$cache_keys['admin_all']);

if ($item->isMiss()) {
    $settings = Settings::all(['fields' => ['name', 'value'], 'conditions' => ['deleted' => 0]]);
    $pool->save($item->set($settings->data(), CacheRepository::MONTH));
}

$settings = $item->get();

Array
(
    [driver] => redis
    [file_cache_path] => /var/www/sites/current/xxx/app/resources/tmp/cache/stash/
    [redis_ip] => <IP_ADDRESS>
    [redis_port] => 6379
    [redis_password] => vagrant
    [redis_timeout] => 2
    [namespace] => merchant4
)

@alexbowers - if you want to push out a revert release I'd approve of that. We can then push out this change as 0.15, or wait until the issue has been found and resolved.

@tedivm Unfortunately, I do not know how to revert a release.
Do you have any idea how I would go about doing that?

Find the commit from the tag you want to go to (v0.14.1) and then make a new tag from that commit-

git tag -a v1.2 9fceb02 -m "Message here"

https://stackoverflow.com/questions/4404172/how-to-tag-an-older-commit-in-git
Once the tag is up it'll get picked up by packagist.

Same problem.
->save('data'); then ->get(); will return always null;

I've been really. Hey lately so locked it to a specific versions for now. Any chance you can bisect the commit causing this valery?

On 27 Jun 2017, at 18:37, Valery Ozarnichuk<EMAIL_ADDRESS>wrote:
Same problem.
->save('data'); then ->get(); will return always null;
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Busy *

On 27 Jun 2017, at 18:37, Valery Ozarnichuk<EMAIL_ADDRESS>wrote:
Same problem.
->save('data'); then ->get(); will return always null;
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry, I don't understand what you want. What does mean "bisect"? Detect?
I'm Russian, English is not my own language.
Now I just set version 0.14.1 in composer.json
When it switch to 0.14.2 - then brokes.
You can test it very easy:
$driver = new Ephemeral();
$pool = new Pool($driver);
$cache = $pool->getItem('some/item/name');
$cache->get(); // null
$cache->set('some value');
$cache->expiresAfter(3600);
$cache->save();
$cache->get(); // null on 14.2 and 'some value' in 14.1

I'll try to have another look this evening.
To clarify, bisect is a command in git, which allows you to track down bugs.
It's worth looking into, it's definitely worth looking and learning for future https://git-scm.com/docs/git-bisect

Oh, I got it, thanks.
I'll try little later.


metasploit no longer builds on unstable

Describe the bug
Metasploit no longer builds when pulled from unstable branch.
Steps To Reproduce
Steps to reproduce the behavior:
nix run nixpkgs/nixos-unstable#metasploit
Additional context
The commit https://github.com/NixOS/nixpkgs/commit/ee79ba102299e06b0b3d2cde443c85282a6a8588 seems to be the point at which it stops building.
Example of failing build
This fails for me:
nix run nixpkgs/ee79ba102299e06b0b3d2cde443c85282a6a8588#metasploit
This runs as expected:
nix run nixpkgs/c0e1f01e435e69be409a98d92934a51495ceb2c4#metasploit
Notify maintainers
@makefu
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.61, NixOS, 21.05.20210902.6bfe71f (Okapi)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.4pre20210802_47e96bb`
 - channels(root): `""`
 - nixpkgs: `/etc/nixpkgs`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
    metasploit
# a list of nixos modules affected by the problem
module:

Looks like that nokogiri is causing trouble again.

Can confirm I am hitting this bug.


(WIP) BEFP for unordered shares

Overview
Closes https://github.com/celestiaorg/rsmt2d/issues/191
Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Quick update on this: attempted to import the NMT wrapper to use for root construction in rsmt2d extended square, but encountered a cyclic dependency issue, I am actively investigating it.

Closing this PR, as it is a duplicate of https://github.com/celestiaorg/rsmt2d/pull/242.


Datafile size reduction: check if Traffic.key is needed

When generating datafiles, we also include the rule keys.
The keys are needed when generating datafiles keeping bucketing consistent, but they may not be needed when evaluating them via SDKs.
If we can remove them, we can reduce the datafile sizes then.
Areas to check
See Traffic.key type as available in @featurevisor/types package.

key is needed for logging purposes. so it stays.


inferFromVolume functional tests skipped in sig-compute jobs

/area instancetype
What happened:
As highlighted in #9804 the inferFromVolume functional tests are currently skipped by the compute job:
https://github.com/kubevirt/kubevirt/blob/cc55a57526331102cd73b59e8ddf285f25e7d9fb/tests/instancetype_test.go#L992-L995
This really shouldn't be the case as there's not direct requirement between the feature and underlying storage class being used.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Additional context:
Using the local SC is causing more headaches as the underlying size of the disk provided to the nodes isn't big enough to accommodate the 34Gi PVs.

/area instancetype


improvements to coordinator lookups management

PR for https://github.com/druid-io/druid/issues/3821
Most major changes are done to LookupCoordinatorManager and LookupReferencesManager. This will not be backward compatible in that users will now have to specify version explicitly in addition to lookup specs when making requests for lookup adds/updates to coordinator.
what changed?

LookupExtractorFactory.replaces(LookupExtractorFactory other) is deprecated and kept only to allow smooth transition from 0.9.x to 0.10.x
Versioning of the lookups is managed via wrapping LookupExtractorFactory and is managed by druid core. LookupReferencesManager now stores LookupExtractorFactoryContainer which is just a wrapper on LookupExtractorFactory with a version. Also Coordinator would accept LookupExtractorFactoryContainer in user requests, so user would explicitly provide a version.
Improvements to LookupCoordinatorManager loop that manages lookups
New Lookup Listener endpoint to accept request for batch add and drop of lookups
LookupReferencesManager now manages add/delete requests asynchronously in single thread
provide backward compatibility with older lookup specs stored in db, this code would read them from "lookups" key in config table, convert them and store them in new "lookupsConfig" key in the config table

Release Notes -
All coordinators should be stopped and then started with newer druid version. There should never be a situation where one coordinator is running 0.9.x while other coordinator is running 0.10.x

As per https://github.com/druid-io/druid/issues/3821#issuecomment-273244796 :

In the face of of a historical tier being full, coordinator can spend lots of cpu time trying to figure out where to place segments. Please make sure the callbacks do not make this worse.

If we move the lookup json as it stands now, to something that is handled more like a loadspec, and have a wrapping metadata that holds the version, I think that should work.

@drcrallen replied to all comments

Can you please document the behavior of updates happening when a user rolls back and forth between versions? (0.9.2 and 0.10.0)

@drcrallen added a blurb on downgrade in lookups.md

@drcrallen @leventov can we please finish this??

@drcrallen also just realized that lookup management is being done by all coordinators and not just by the leader. though it wouldn't cause any harm but its certainly not necessary and significant waste of resources. was there a reason to run it on all coordinators?

It's supposed to be just the leader. If it's all thats a bug

@drcrallen ok, i double checked and indeed all coordinators run the lookup management. given that, it was unintentional I will do a follow up PR to fix that.
filed https://github.com/druid-io/druid/issues/3975

@drcrallen @leventov the 0.10.0 is blocked on your reviews, appreciate please finishing them up

@fjy I doubt it could be finished in less than a week. I suggest to push it to 0.10.1. Also see https://groups.google.com/forum/#!topic/druid-development/73uBdOF7rSo

@fjy @leventov major reason for this PR to be in 0.10.0 are following...

coordinator HTTP endpoint APIs changes
on upgrade, it is required that all coordinators are brought down and then started with new version. "rolling" upgrade should not be done for coordinators.

given that QTL is considered experimental feature and if we are fine with above in 0.10.1 then, we can move this .

Pushing to 0.10.1 as discussed in the dev sync

we decided to move this PR to 0.10.1 , given the experimental nature of lookup , coordinator API backward compatibility is fine

@drcrallen also added support to roll back historical nodes without worrying about snapshots stored ... 0.9.2 code will now be able to read the snapshots stored by 0.10.0 code

@leventov ok finally changed https://github.com/druid-io/druid/pull/3855#discussion_r106595927 :)

@drcrallen @leventov this PR also fixes https://github.com/druid-io/druid/issues/3975 now

@himanshug please don't rebase PR, merge master into the PRed branch instead. It simplifies review and preserves older review comments in the code, if the part of code is not changed by merge/later commits, addressing PR review. With rebase and force push, comments are vanished anyway.

@leventov please write your comments on the PR diff and not on commit diff , it appears I can't reply to those comments.

@drcrallen added test for lookupManagementLoop

I went through the code a little fast though, so if I missed something please let me know.

@drcrallen handled the review comments and added comments in LookupCoordinatorManager start()/stop() to explain maintaining single instance of executorService.


Select IOL #2 location (not North America)

Brainstorm possible (warm) locations in Jan, 2016

Cable re-sent e-mail to Stavros: thread: Institute for Open Leadership #2 - in Rio?

Done - Cape Town selected


Directly link Germplasm to the source Cross

@daveneti from Slack

"... Or is the only way to know the cross that resulted in the germplasm via the inventory lot?"

@BrapiCoordinatorSelby from Slack

"This is an excellent point. I did some digging and there is no direct link between the cross and germplasm object. I assumed there was and I think there should be.
In V2.1, crossDbId and germplasmDbId can only be linked through SeedLot.contentMixture or ObservationUnit. Both a seed lot and an observation unit can be created from a cross before a germplasm exists, and can therefor optionally hold both IDs. "

There is a one-to-one relationship between cross and germplasm. If a cross is successful then a germplasm is created, so a Cross would zero or one germplasm. A Germplasm is created by a cross in the case of both generative and derivative breeding methods there are cases when a cross is not known or recorded. These include often self-crossing, open pollination, mutation etc. So a germplasm would have a zero or one crosses.
To the JSON schema model

add germplasm : Germplasm field to Cross
add cross: Cross field to Germplasm

To the Open API model

add germplasmDbId : string field to Cross
add germplasmName : string field to Cross
add crossDbId: string field to Germplasm
add crossName: string field to Germplasm

@BrapiCoordinatorSelby two possibly useful endpoint changes might be:

adding parameters to the GET crosses endpoint to filter on parent1 and parent2 (by germplasmDbId would likely be most useful),
adding a search endpoint for crosses, which could support an array of parent germplasmDbIds among other things.

I don't know how a client would know which germplasmDbId to send for "parent1" vs. "parent2", so 2. would probably be more useful (though more work to implement).
And for the search endpoint, I'm not sure if it could provide a way to get crosses with both all and any parent germplasmDbIds. Basically I could see potential use cases for an AND or OR type search. The search request body could contain two arrays of parent germplasmDbIds, one for "parent1" and one for "parent2", this would allow AND and OR type requests, but the implementation would probably need to check "parent1" and "parent2" against both fields since they don't seem to have a distinct meaning (like male/female). Also, are there use cases for crosses with more than 2 parents of record? That would further complicate things.
This is what the GET endpoint currently returns for the parents according to SwaggerHub.
"parent1": {
  "germplasmDbId": "d34b10c3",
  "germplasmName": "TME_419",
  "observationUnitDbId": "2e1926a7",
  "observationUnitName": "my_Plot_9001",
  "parentType": "MALE"
},
"parent2": {
  "germplasmDbId": "d34b10c3",
  "germplasmName": "TME_419",
  "observationUnitDbId": "2e1926a7",
  "observationUnitName": "my_Plot_9001",
  "parentType": "MALE"
},

I agree that both AND and OR searches would be useful. Convention is that Female is usually parent1 (see breedbase BrAPI implementation, Purdy notation, etc) but a check would probably be warranted.  Yes, there are use cases where the user would want to track a set of possible (male) parents.


add Fedora ARM option

Changes:

EFI image is located as /usr/share/edk2/ovmf/OVMF_CODE.fd in Fedora.
Create install requirements for Fedora.
Update README.md for last changes.

Thx for your help!


Right, so I've investigated the issue and have a possible fix ready.

Right, so I've investigated the issue and have a possible fix ready.
But first I'd like to address a couple points.

instead of waiting, justs tries requesting and exits with error code 439(Too many requests), when it should wait for the rate limit to pass.

The underlying http client does actually stall the request waiting for the rate limit to pass over. This issue here was that the stalling is performed only for that request and not all requests client wide resulting in a form of head of line blocking.
Additionally due to a large amount of requests made in a short period of time, which the library did not anticipate in the original design of the stalling mechanism, requests could essentially start "choking" each other out where one request finishes their rate limit stall but is then immediately rate limited again due to a sibling request taking its slot. The exception you received was a result of this following ten consecutive request failures all being rate limited.

When i do something like:
SNIP
And i get ratelimited

Unfortunately the API response does not let us know how many tries we have remaining in order to start performing client side throttling so the rate limit as a whole can be avoided. The response will only let us know if we've been rate limited or not and the library can only deal with that to the extent of waiting out the rate limit but not avoiding it.
If you do not want to hit the rate limit in the first place then you must throttle your own requests manually (this can be as simple as sleeping for a small amount of time between requests) or use multiple client applications as rate limits are applied on a per client app basis (although I do not know if this is endorsed by Spotify)

Right, so I've investigated the issue and have a possible fix ready.

I was a little reluctant to use the patch as it is right now since it feels inefficient (I performed 4096 search queries in four minutes with over 30 rate limits and I feel like that its possible to assume that either less time taken or less rate limits triggered but maybe not both) but I think its acceptable to release it under 0.8.6 temporarily and then succeed it with 0.8.7 as quickly as possible.
The fix that I've hacked together uses a barrier to stall all requests uniformly which gets controlled by the request that first gets rate limited. Unfortunately once the barrier gets lifted it's essentially a mad max free for all zerg rush for all stalled requests leading to more frequent rate limiting responses feeding a frequent stall, release, stall cycle until the amount of requests being made lowers enough to allow the API to recover from the clients madness.
Additionally that doesn't stop the possibility of choking out the entire pipeline leading to the same exception being raised, it merely delays it as much as possible. To combat this I've added a fallback stalling around the entire process, so when a request gets choked out the stalling falls back to an exponential backoff algorithm supplied by the new backoff dependency.
Ideally the two systems would get merged into one to avoid unnecessary overhead and allow some sort of slow bleed of requests back into the http session, but I'm not sure of how to tackle this and am experimenting in the dark for the time being.
Originally posted by @mental32 in https://github.com/mental32/spotify.py/issues/51#issuecomment-596093335

I think you could also try using a library like https://github.com/hallazzang/asyncio-throttle/ for handling concurrency, maybe?

@creator1372 I've pinned #51 and I'm going to close this issue to try and keep the relevant discussion in there.
Feel free to repost your comment in that issue to continue the discussion


Binary tree to Doubly ended Linked list

Description
Convert a Binary Tree to a Doubly Linked List In-Place. The left and right pointers in nodes are to be used as previous and next pointers respectively in converted DLL. The order of nodes in DLL must be same as Inorder of the given Binary Tree. The first node of Inorder traversal must be the head node of the DLL.
Domain
CPP
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


Add private method for setting query without triggering search submission

Fixes #113.
Add new private method (setQueryWithoutSubmitting()) to set the value of the search view without triggering onSubmitQuery().
setQueryWithoutSubmitting() is now called inside setQuery() (to avoid code duplication), and inside onRestoreInstanceState().

Aaaaaawesome :). Thanks.


Add started at finished at

It closes #121

Changes Unknown when pulling 58171cae7c484e1963967419f7dbab866d8700e7 on add-started-at-finished-at into ** on master**.

Changes Unknown when pulling 58171cae7c484e1963967419f7dbab866d8700e7 on add-started-at-finished-at into ** on master**.


nodejs/iojs-es repo

The https://github.com/nodejs/iojs-es repo has disappeared.

OH! What happened? :/

No idea

cc @mikeal?

scaring scaring... I hope we can find out what happened.. @stringparser did you get to merge the last changes that we were commenting yesterday?

Not yet, but those changes are in the org you created iosj-es/website. Lucky we did the migration of all the stuff there and leaved the nodejs/iojs-es repo to centralize things.

The changes got merged today #362 @edsadr

Great.. but still ... we need to know what happened with our repo :( @julianduque will help asking ...

I can confirm it was deleted, I hope there were no important discussions on it, afaik deleted repos are lost  forever.
Who sorta leads iojs-es at the moment? There is a possibility someone ended up with admin access who shouldn't have had it.

@stringparser is the main lead right now, could you please recreate it? we were using it to sync final stuff to be merged in website...

Would you folks prefer if it was forked and then unforked from iojs-es/website, or does someone have a most recent branch then can push up to a new repo?
All I can dig up right now is that the user who apparently deleted it appears to have left the org entirely.

All website changes are in the org you created @edsadr, on the repo we are working from iojs-es/website so they are safe there. The nodejs/iojs-es repo was left to centralize communications. There was a PR from @sametsisartenep hopefully he still has the zlib doc files he was translating.
The local repo I have, sure others do as well, has the changes till May 18th. So we could push them up to a new repo.
@Fishrock123 Is there any hint of what happened on the audit log?

We should ask GitHub if they can restore the repo.

@mikeal thanks
@stringparser @edsadr the lost repo had the summaries of the WG meetings, right? :/

Yes @sergiolepore we better take more care this time.

yeah... would be nice to have it back...  @mikeal did somebody ask GitHub?

Hey guys, I'm sorry , @julianduque ask me right now and looking at my history I was the one who eliminated the repo . I was cleaning my github account and I must have confused.

Right now I'm writing to github to see if something they can do. sorry again.

Ok, GitHub fix the problem, the repo have life again. sorry again.

:) thanks @italoacasas ... and we are back :boom:

@stringparser .. I guess you can close the issue

I talked with @julianduque and it appears like this has been resolved. \o/

Thanks @italoacasas and @Fishrock123 <3


bump dependencies

Applied mkpr on undefined
/tmp/mkpr.sh

:tada: This PR is included in version 1.31.14 :tada:
The release is available on:

v1.31.14
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Dk/add jammy only

Changes

Add jammy flavors of docker images for all except Azure-ml

Notes
There is no r-base/jammy image available only focal; There is no rsp-monitor-workbench-azureml version for focal but there is for jammy. In order to get non-bionic builds for the azure image we would need to build r-base with jammy, or rockylinux8 in the case of a RHEL8 compatible image.

Looks like Snyk does not like checking the Azure-ml container

We should also go about passing along the need for those other jammy builds for azureml, etc.


Create Player-List-Indicators

Based on Player Indicators. Allows the user to add players names to lists. These lists are then used to highlight the name of those players in different colours over their heads, on the minimap and in right click menu boxes.

I believe the plugin file names must be lowercase, so try renaming it to eg plugins/player-list-indicators

This is Rejected:

Highlighting "Offline" Friends (and generic player highlighting): Not included to respect players with their messaging mode set to Private and to avoid harassing players (see runelite/runelite#951)

@Adam-  sorry I'm kind of new to all this, how would I go about editing it to lowercase without removing this pull request and making another.
@Hydrox6 the plugin that this is based off of, Player Indicators which is a main plugin (not via pluginhub) has an option to highlight all other players, this would just be highlighting specific ones instead of every one, I don't believe thats any different than the original

I don't believe thats any different than the original

It's very different. Highlighting everyone doesn't allow you to easily pick off specific targets for ragging/harassment. It's why the rejected line exists.

alright thank you for the clarification


Custom webpack config breaks storybook

Hi. I'm trying trying to solve super-weird bug when custom config in my new project is breaking whole storybook. I've basically just copy-pasted whole storybook stuff from another project which is working perfectly. In this new project it's a problem. Deleting custom config makes storybook working again.
Storybook output:
➜ react-library-starter-kit (master) ✗ npm run start:storybook

><EMAIL_ADDRESS>start:storybook /Users/davidvass/Work/react-library-starter-kit
> start-storybook --dont-track -p 9001

Environment: production
=> Loading custom webpack config.

React Storybook started on => http://localhost:9001/

webpack built 17d12a0d8ee6b520b2b5 in 54ms
Hash: 17d12a0d8ee6b520b2b5
Version: webpack 1.13.2
Time: 54ms
                   Asset     Size  Chunks             Chunk Names
static/preview.bundle.js  23.1 kB       0  [emitted]  preview
static/manager.bundle.js  22.7 kB       1  [emitted]  manager
chunk    {0} static/preview.bundle.js (preview) 76 bytes [rendered]
    [0] multi preview 76 bytes {0} [built] [5 errors]
chunk    {1} static/manager.bundle.js (manager) 52 bytes [rendered]
    [0] multi manager 52 bytes {1} [built] [3 errors]

ERROR in multi manager
Module not found: Error: Cannot resolve 'file' or 'directory'<EMAIL_ADDRESS>in /Users/davidvass/Work/react-library-starter-kit
 @ multi manager

ERROR in multi manager
Module not found: Error: Cannot resolve 'file' or 'directory'<EMAIL_ADDRESS>in /Users/davidvass/Work/react-library-starter-kit
 @ multi manager

ERROR in multi preview
Module not found: Error: Cannot resolve 'file' or 'directory'<EMAIL_ADDRESS>in /Users/davidvass/Work/react-library-starter-kit
 @ multi preview

ERROR in multi manager
Module not found: Error: Cannot resolve 'file' or 'directory'<EMAIL_ADDRESS>in /Users/davidvass/Work/react-library-starter-kit
 @ multi manager

ERROR in multi preview
Module not found: Error: Cannot resolve 'file' or 'directory'<EMAIL_ADDRESS>in /Users/davidvass/Work/react-library-starter-kit
 @ multi preview

ERROR in multi preview
Module not found: Error: Cannot resolve 'file' or 'directory'<EMAIL_ADDRESS>in /Users/davidvass/Work/react-library-starter-kit
 @ multi preview

ERROR in multi preview
Module not found: Error: Cannot resolve 'file' or 'directory' /Users/davidvass/Work/react-library-starter-kit/node_modules/webpack-hot-middleware/client.js in /Users/davidvass/Work/react-library-starter-kit
 @ multi preview

ERROR in multi preview
Module not found: Error: Cannot resolve 'file' or 'directory' /Users/davidvass/Work/react-library-starter-kit/.storybook/config.js in /Users/davidvass/Work/react-library-starter-kit
 @ multi preview

Webpack configs:
// /.storybook/webpack.config.js
const mainWebpackConfig = require('../webpack.config');

module.exports = {
  resolve: mainWebpackConfig.resolve,

  module: {
    loaders: [
      ...mainWebpackConfig.module.loaders,
      {
        test: /\.(?:png|jpe?g|otf|gif|svg|woff2?|ttf|eot|ico)$/,
        loader: 'file-loader',
      },
    ]
  }
};

// /webpack.config.js
const path = require('path');
const packageJson = require('./package.json');
const args = require('yargs');
const LoaderOptionsPlugin = require('webpack/lib/LoaderOptionsPlugin');

const development = args.argv.env === 'development';
const libraryName = packageJson.name;
const rootPath = path.resolve(__dirname);
// eslint-disable-next-line
console.log(`Environment: ${development ? 'development' : 'production'}`); //

module.exports = {
  entry: path.join(__dirname, '/src/index.js'),

  output: {
    path: path.join(__dirname, '/umd'),
    filename: `${libraryName}.js`,
    library: libraryName,
    libraryTarget: 'umd',
    umdNamedDefine: true,
    auxiliaryComment: {
      // temporary brunch support
      // eslint-disable-next-line
      commonjs2: ` Brunch module definition follows:\n\tif(typeof require === "function" && typeof require.register === "function"){\n\t\trequire.register("${libraryName}", function(exports, require, module){ module.exports = factory(); });\n\t}`
    },
  },

  // generates source maps as a separate file
  devtool: 'source-map',

  module: {
    loaders: [
      {
        test: /\.js$/,
        exclude: /node_modules/,
        loader: 'babel-loader',
        query: {
          presets: [
            ['es2015', { modules: false }],
            'react',
          ],
          cacheDirectory: development,
          babelrc: false,
          plugins: [
            'transform-object-rest-spread',
          ],
        },
      },
    ],
  },

  plugins: [
    new LoaderOptionsPlugin({
      // switch loaders to debug mode
      debug: development,
      eslint: {
        cache: development,
        failOnError: !development,
      },
    }),
  ],

  resolve: {
    extensions: ['.js'],
    alias: {
      src: path.resolve(rootPath, 'src'),
    },
  },
};

npm ls: http://hastebin.com/akofavuruh.pl
Whole project: https://drive.google.com/a/showmax.com/file/d/0B_k3b24rVwCaSGtMZXFSeVB6WEk/view?usp=sharing

You should try to keep our babel-loader. It's configured to load our JS files.

I have thought that this config is used only for my code, not storybook code. So you suggest not using babel-loader at all in my config?

@vass-david not that.
Storybook needs it's own code and we need to load it.
What I mean is, use our own version of babel-loader rather that using your version for storybook.
Just use your babel-loader for your app only.

@arunoda I'm sorry but I'm confused now. I've installed<EMAIL_ADDRESS>which is version in your package.json under devel dependencies and it does not work as well. How can I use your version of babel-loader in this .storybook/webpack.config.js? Do you export some special modified babel-loader version in storybook? Or do I need to set babel-loader config exactly same as your one?

Any update here? Would be nice to be able to use custom webpack config here.

@vass-david i solved this issue by copying my webpackConfig over to the custom config (it's similar to yours) and adding the steps per object key, like this:
const webpackConfig = require('../config/webpack/webpack.config')

module.exports = {
  context: webpackConfig.context,
  // plugins: webpackConfig.plugins,
  resolve: {
    extensions: ['', '.js', '.jsx', '.json', '.scss'],
    alias: webpackConfig.resolve.alias,
  },
  module: {
    loaders: webpackConfig.module.loaders,
  },
};

When trying this i found out that storybook seems to need an empty '' at the beginning of the extensions array. Once i added this in the custom config it worked.
You can't add it to your main config because it's invalid configuration (especially for webpack 2)
Also i had to add a custom .babelrc to the story book folder where i wrote 'es2015', instead of ['es2015', { modules: false }],
Hope this helps.

@derpoho Man, thank you so much. Missing empty string extension was the thing.

I hope we could close this.

Is this still an issue? Do we actually need an empty string in the first index?

I have been trying to get storybooks to work with typescript using a similar method to this. If I include '' in my extensions list, however, I get the following error.
 - configuration.resolve.extensions[5] should not be empty.```

Is this due to updates that have happened since this post?


desktopToDarwinBundle: produces 16x and 32x icons which get misrenderred by Finder

Describe the bug
I noticed that some app bundles that are created through desktopToDarwinBundle have icons that appear corrupted when viewed in Finder. This seems to only apply to 16x16 and 32x32 icon sizes.

16x16
32x32
64x64

The affected apps in the screenshot are dsview, ghidra and pulseview (that version of q2pro is WIP and not present in nixpkgs yet, but it also suffers from the same problem).
App bundles created through different means don't seem to have this issue (example: openboardview, kitty, 1password, vscode)
Steps To Reproduce

Install pulseview (systemPackages or through home-manager)
Open nix application bundle directory in Finder
Set view icon size to 16x16 or 32x32

Expected behavior
App icons should show up in Finder correctly
Metadata

 - system: `"aarch64-darwin"`
 - host os: `Darwin 24.1.0, macOS 15.1.1`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.8`
 - channels(carlossless): `"darwin, home-manager"`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Notify maintainers

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

This issue exists most likely because icnsutil assigns icp4 and icp5 OSTypes for 16x16 and 32x32 icons respectively
https://en.wikipedia.org/wiki/Apple_Icon_Image_format#Icon_types


Report Plugin: Support for Asset revision

Description
Often, scientists will iterate on the creation of a plot (correction, font tweaking, ...).
It would be useful to add an image as a revision of an other.
Work around
For now, it was agreed that removing a plot and adding an other one would suffice.

Not sure if this requires much change to the data model, seems like we already support revisions for images / files and it would just be a matter of exposing that in the UI and editing the upload, edit UI to suit revisions. If my assumptions are correct then I estimate 3

need to rebase and fix conflict


Add All-Contributors

Describe your PR

Setup the initial all-contributors spc

Related to #269  Setting up all-contributors spec
Pages/Interfaces that will change
README
Screenshots / video of changes

Steps to test

Scroll to bottom of README

Additional notes
I was having trouble requesting access for this bot to be installed in the repo. https://allcontributors.org/docs/en/bot/overview It'll be easier to maintain this once the bot is installed in the repo.

@M0nica going to merge this so that we can get this out in the world ASAP. We'll adjust folks contribution types incrementally! Thank you for getting this handled!


How can I run tests using Headless browser using this framework

How can I run tests using Headless browser using this framework

here you can find instruction
https://github.com/ObjectivityLtd/Ocaramba/wiki/Override-browser-profile-preferences,-install-browser-extensions


AOT Build when using date-fns

Hi everyone,
Hope you are well and might be able to assist me.
I'm struggling with my aot build after having included date-fns into my project (through angular-calendar). It all builds okay with the normal production build.
I'm including the functions in my code like this:
import {
  startOfDay,
  subDays,
  addDays,
  endOfMonth,
  isSameDay,
  isSameMonth,
  addWeeks,
  subWeeks,
  addMonths,
  subMonths,
  addHours
} from 'date-fns';

In my seed.config.ts I am including the lib in the following way (also as illustrated in other examples):
paths: {
    ....
   'date-fns': 'node_modules/date-fns/index.js',

packages: {
    ....
    'date-fns': {
        main: './index.js',
        defaultExtension: 'js'
      }

Everywhere I read and everyone I ask tells me the above is sufficient for them. But for some reason I am not able to compile it when used in the angular-seed here.
The error is:
 Error on fetch for date-fns/get_iso_week.js
Obivously the mapping is for some reason not correct. Is there anything special I need to do for the angular-seed-advanced to make it right?
If I add the following line to my paths it can succesfully build aot and prod build, but then nothing that uses date-fns works anymore on runtime so I am but out of ideas:
'date-fns/*': 'node_modules/date-fns/index.js',
Any suggestions?

For support requests you can use gitter or take a look at project's the wiki page in order to get more complete idea on how the it works.

Hi @blaur can you the post codes for using date-fns
Thanks


Expand prelude

Currently the standard library prelude is way too short. Essentials are required to be imported nearly in every contract. Heres some nominations for addition to the prelude

Address
ContractId
Identity
transfer()
msg_sender()
msg_amount()
msg_asset_id()
StorageMap
Vec
assert
require
revert

If I'm not mistaken, we need to create the prelude first and have the compiler include it in every module. https://github.com/FuelLabs/sway/issues/841 seems to be tracking that work.

Yeah, I was going to say, zero sized probably is too short. :slightly_smiling_face:

Closing in favour of https://github.com/FuelLabs/sway/issues/841


NameError: uninitialized constant Hobbit::Render

Hey!
The current documentation is not entirely accurate for Hobbit::Render - It causes this error: NameError: uninitialized constant Hobbit::Render
As is, it should probably be:
require 'hobbit'
require 'hobbit/render'

class App < Hobbit::Base
  include Hobbit::Render

  get '/' do
    # will render views/index.erb using views/layouts/application.erb as layout
    render 'index'
  end
end

Another alternative would be to change https://github.com/patriciomacadden/hobbit-contrib/blob/master/lib/hobbit/contrib.rb and add this line:
require 'hobbit/render'

I can submit a PR for this. I prefer the second alternative. What do you think?
Please let me know.
Thanks!

Hey @etagwerker!
lib/hobbit/contrib.rb has a require 'hobbit/render' sentence, but wrapped in a begin-rescue block. This is because Hobbit::Render requires tilt, which is an optional dependency (it's not on the gemspec as one could probably not want to use Hobbit::Render).
Does it work if you include tilt in your Gemfile or keeps failing?
I'm happy to receive a PR if it solves your problem. :smile:

@patriciomacadden yeah, that was it. I had forgotten to add tilt to my project. I'll submit a PR to improve the documentation.


Updated writePreview example

when running current example, you would get a
(node:7851) UnhandledPromiseRejectionWarning: Error: 3 INVALID_ARGUMENT: Preview settings are missing.
    at Object.callErrorFromStatus (/Users/mish/Downloads/action-builder-test/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
    at Object.onReceiveStatus (/Users/mish/Downloads/action-builder-test/node_modules/@grpc/grpc-js/build/src/client.js:247:52)
    at Object.onReceiveStatus (/Users/mish/Downloads/action-builder-test/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:336:141)
    at Object.onReceiveStatus (/Users/mish/Downloads/action-builder-test/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:299:181)
    at /Users/mish/Downloads/action-builder-test/node_modules/@grpc/grpc-js/build/src/call-stream.js:145:78
    at processTicksAndRejections (internal/process/task_queues.js:75:11)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:7851) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:7851) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

@mishushakov What did you changed?


feat: add clone_without_body_instructions to Program

Resolves #235.
I noticed a couple of tests that were not testing the correct thing, so I fixed them while I was here.

Is this fix something that needs to be applied here as well?

Is this fix something that needs to be applied here as well?

I don't think so. In pyQuil a Program maintains a declaration mapping separately from the instructions in the program. The bug there had to do with copying the declarations mapping without the corresponding instructions, leading to a Program in an invalid state.
In quil-rs, the instructions in the program are derived directly from each member of Program. When a DECLARE instruction is added to a Program, it gets added to the memory_regions field and when a user calls to_instructions(), memory_regions is used to derive the corresponding Instructions. With this approach the internal state of the program and the instructions it outputs can't differ like they can in pyQuil.


[Storage] Figure out what to do with long-running tests

Long running unit tests timeout in Pipelines, and take too long to run every time locally.  We should find a solution for managing these tests.

One remaining test is https://github.com/Azure/azure-sdk-for-net/blob/5b7afe2813a8ae3ab0dda21746cf27d62d9b0f35/sdk/storage/Azure.Storage.Files.DataLake/tests/DataLakePartitionedUploaderTests.cs#L223-L255 . afaik azurite doesn't have DFS apis, but on the other hand dfs endpoint will go away and datalake sdk will talk to blob endpoint some day for this scenario.

Hi @seanmcc-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.


Autogenerated Go libraries for IngressRoute CRD

Do you want to request a feature or report a bug?

Feature
What did you expect to see?

tl;dr: Do autogenerated Go libraries for CRDs exist, if so, could we document them?
Thanks for Traefik! I'm using 1.7, currently considering upgrading to 2 due to its TCP support that we need.
The issue we're facing here is that we create a new ingress/service/deployment for each of our customers. We can create ingresses normally through the appropriate client-go library plus importing the ingress package from there, however, the new IngressRoute that comes with Traefik does not have the ingressroute go package that we can import so that we can start replacing our Ingresses with IngressRoutes.
Would you be able to provide these code-generated libraries for your CRDs, or if they are present, have it documented?

Hello,
there is no "standalone" library for the Traefik CDR but you can use Traefik as lib.
The relevant packages:

https://github.com/containous/traefik/tree/master/pkg/provider/kubernetes/crd/traefik/v1alpha1
https://github.com/containous/traefik/tree/master/pkg/provider/kubernetes/crd/generated

Thank you! I tried to import them, but I ended up having some issues — got some errors saying something to the amount of "this package does not exist in<EMAIL_ADDRESS>which is fair. I'm not entirely sure why trying to import this package normally through go tries to import 1.7 and not 2.0 though.

The go module for v2.0 is module github.com/containous/traefik/v2@latest.

Ah — makes sense. Thanks for the help. Should I close this request or leave it open as 'documentation request' for the website?

We don't really have a section for that in the documentation, as it's just a standard Go module approach.
Maybe this issue can be enough, I'm don't really known what is the best approach :thinking: .

In the parts of the documentation that talk about the CRDs, it might be a good idea to give a full import path to the clientsets involved in the case the user needs to create or manage them via the Kubernetes' client-go. It could have saved me an hour or two. :)
I'm leaving this up so you guys can decide what to do with it.

Hi! I'm Træfiker :robot: the bot in charge of tidying up the issues.
I have to close this one because of its lack of activity :disappointed:
Feel free to re-open it or join our Community Forum.


change the base of an existing PR

Just as you can use the -b <base_branch> argument to hub pull-request when creating a PR, it would be useful to be able to change the base branch on an existing PR.
This is useful in the workflow where you have stacked a few PRs on top of each other and are now landing them, but want to land from the bottom of the stack up, so that each PR is landed separately rather than landing from the top down where you just keep merging one PR into another until you finally merge one large PR into the base branch.
For the desired workflow, one needs to land the first PR (let say, to master for the example), then merge origin/master into the second PR, then set the base branch of that PR to master and land that.  Rinse repeat, until the whole stack is landed.
Having to keep going back to the GitHub website to do that base branch change is tedious and goes completely against the goal of hub (IMHO).

Thanks for writing in! This is planned as part of the feature to update pull requests #1523

Excellent!


Feature/screen resolution

Description
Fixes #14
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@mreiche Please update README.md to note that screenResolution of browser container is releated to Testerra setting tt.window.size


Update encrypting proxy to use actual tx envelope format

The cbor thing, not the packed byte thing.

The encrypting proxy has been superseded by client support 🎉 . This issue will be reopened if the EP ever comes back.


Offline vote + party

I think if a voteparty happens, you don't get the key when you're offline.
Same with voting, I tested it and if you vote while not ingame, no key/money get delivered.

This is a known issue, it appears not to cache at all if you vote online. That said, vote parties only apply to online users at the time, therefore, closing this issue.


bulid does not work on jenkins but builds on zoscan2b

https://<IP_ADDRESS>:8443/job/Port-Pipeline/944/
ASCII translation of the unprintable stuff (from @IgorTodorovskiIBM )
Building /jenkins/igor/libxml2port...
Checking if tarball already downloaded
VERBOSE: 'curl -L -o libxml2-2.9.12.tar.gz http://xmlsoft.org/sources/libxml2-2.9.12.tar.gz'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 5548k  100 5548k    0     0   694k      0  0:00:07  0:00:07 --:--:-- 1112k
Extract tarball libxml2-2.9.12.tar.gz into libxml2-2.9.12
Usage: iconv [-c] [-s] [-f fromcode] [-t tocode] [file ...]
or:    iconv -l
Try 'iconv --help' for more information.
***ERROR: Unable to convert EBCDIC text to ASCII for .gitattributes
zopen-build completed in 12 seconds.

Results are now different - Jenkins environment needs 'python3' to be set up so testing can use it:
https://<IP_ADDRESS>:8443/job/Port-Build/69/console
@IgorTodorovskiIBM can you update the Jenkins environments?


[SMALLFIX] more efficient locking for listStatus

before this change, listStatusInternal was locking from the root to the child node, now we lock from the parent node to the child node.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20226/
Test PASSed.

@gpang addressed comments, PTAL

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20253/
Test PASSed.

@yuzhu Please cherry-pick to branch-1.8


Demangling: Add option for printing simplified async resume functions

Add a new option to DemangleOptions for the purpose of printing  async resume partials by the name of their top-level function.
This will initially be used lldb when generating backtraces. This will allow the backtrace to show frames in the backtrace using the function names found in the source code.
For demonstration, instead of a backtrace like this:
asyncHelper() at main.swift:2
(1) await resume partial function for static Main.main() at main.swift:13

with this change the backtrace will be:
asyncHelper() at main.swift:2
static Main.main() at main.swift:13

Terminology question: what words are we using for the "relationship" between a function and its generated coroutines? I used "top-level" in the PR description, but is there a word that should be used instead?

There doesn't seem to be a lot of testing options for this, does anyone have suggestions?

@swift-ci test

There doesn't seem to be a lot of testing options for this. Is it fine or does anyone have recommendations?

You could expose it via a command line option in swift-demangle and add it to test/Demangle/demangle-special-options.test

@adrian-prantl The command doesn't have many options to begin with, so I wasn't sure if it was appropriate to add an option just to test. Maybe a hidden option.

Build failed
Swift Test OS X Platform
Git Sha - 07686979db6501cda17d5f4fa01f43ea4cb5fc76

@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - 07686979db6501cda17d5f4fa01f43ea4cb5fc76

swift-demangle is a utility to manually do all sorts of demangling, so it seems to be appropriate to expose these options

I'll add a hidden flag and add FileCheck tests in a follow up. I'd prefer to merge this to allow https://github.com/apple/llvm-project/pull/2868 to be merged.


419 duck db version

@paigeh1 this is the DuckDB code
Pull Request submission
Insert detailed bullet points about your changes here!
Insert any instructions to help the reviewer, e.g. "install new requirements from requirements.txt"
*Let the reviewer know what data files are needed (to be grabbed from sync)
Closes or fixes
Fixes #
Code

[ ] Requirements My/our code matches the requirements of the ticket
[ ] Functionality: New functions meet requirements in issue ticket
[ ] Compliant Code Code is as PEP 8 compliant as I can humanly make it
[ ] Code runs The code runs on my machine
[ ] Clean Code

[ ] Code has been linted (use your favourite linter)
[ ] Code adheres to DRY

Documentation
Any new code includes all the following forms of documentation:

[ ] Function Documentation Docstrings within the function(s') definition(s) have been created

[ ] Includes parameters and returns for all major functions
[ ] Includes data types

[ ] Updated Documentation: Working doc has been updated and a new ticket to update the master documentation has been created.

Data

[ ] All data needed to run this script has been added to Sync

Testing

[ ] Unit tests Unit tests have been created and are passing or a new ticket to create tests has been created

Peer Review Section

[ ] All requirements install from (updated) requirements.txt
[ ] Documentation has been created and is clear - check the google Doc
[ ] Doctrings (Google format) have been created and accurately describe the function's functionality
[ ] Unit tests pass, or if not present a new ticket to create tests has been created
[ ] Code runs The code runs on reviewer's machine

Final approval (post-review)
The author has responded to my review and made changes to my satisfaction.

[ ] I recommend merging this request.

Review comments
Insert detailed comments here!
These might include, but not exclusively:

bugs that need fixing (does it work as expected? and does it work with other code
that it is likely to interact with?)
alternative methods (could it be written more efficiently or with more clarity?)
documentation improvements (does the documentation reflect how the code actually works?)
additional tests that should be implemented (do the tests effectively assure that it
works correctly?)
code style improvements (could the code be written more clearly?)

Your suggestions should be tailored to the code that you are reviewing.
Be critical and clear, but not mean. Ask questions and set actions.

Issue with loading all csvs, going to look into this. Appears to just be loading London atm

Next steps:

[ ] Rerun the script
[ ] Check output of the data is what we expect
[ ] Make the final output data as the input data used in the pipeline (SDG_eng_wales.py)

Listing some requirements for the xlsx output:

headers on 5th row (starting from 1, not 0)
3 tabs to be named:

Mid-{year} Persons
Mid-{year} Males
Mid-{year} Females

Columns to be named: ["OA11CD", "LSOA11CD", "All Ages".....] then "0", "1", "2"....through to "89" and "90+"
Other tabs and information probably not needed

I am stuck on running this code after having re-downloaded the archive csvs again. This is a problem I had before and was previously (if I remember correctly) to do with the ordering of columns in the column dtypes dictionary.
I have read the csvs in via the command line head -n 1 path_to_csv and this showed that the column order was the same as my dictionary. Same for reading it in Pandas.
The dtypes are correct too I believe.

The code which is trying to be converted to Int (which shouldn't be) is from the "LAD11CD" column.

This now works to rename columns and create all tabs in the excel


[BUG] x86 fonts are corruptet

Description
After update to 3.116.1 My application works perfectly in Any CPU and x64 profile, but rendering fonts crashes after few seconst in x86 profile. Older nuget version worked perfectly.
Code
The best way to share code for larger projects is a link to a GitHub repository: https://github.com/user/repo/tree/bug-123
But, you can also share a short block of code here:
// some C# code here

You can also share some XAML:
<!-- xaml code here -->

Expected Behavior
No response
Actual Behavior
No response
Version of SkiaSharp
3.116.0 (Current)
Last Known Good Version of SkiaSharp
2.88.9 (Previous)
IDE / Editor
Visual Studio (Windows)
Platform / Operating System
Windows
Platform / Operating System Version
No response
Devices
No response
Relevant Screenshots

Relevant Log Output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Are you using CPU or GPU rendering? Can you attach a repro sample with the code and the font? This issue does not enough information to start testing.


SQL Server WithHealthCheck will wait forever if the database itself does not exists

SQL Server WithHealthCheck will wait forever if the database itself does not exists.
Imagine this code:
var db = builder.AddSqlServer("sqlserver")
    .WithDataVolume("sqldata")
    .AddDatabase("sqldb")
    .WithHealthCheck();

var migrator = builder.AddProject<Projects.MigrationService>("migrator")
    .WithReference(db)
    .WaitFor(db);

The MigrationService will run the migrations and create the database if it does not exist. When WaitFor(db) and WithHealthCheck() is used, the migration service will never start. It looks like there is no valid solution for this except trying to connect to the SQL server without specifying the database name?

You can wait for sqlServer
var server = der.AddSqlServer("sqlserver");
var db= ...

var migrator = builder.AddProject<Projects.MigrationService>("migrator")
    .WithReference(db)
    .WaitFor(server);


Why does using the "generate" feature installs dependencies to my package.json

Question
After running "generate" I noticed the following dependencies were added to my devDependencies:
"commander": "^10.0.0",
"inquirer": "^8.2.5",

Is that really necessary? Can this be avoided?

It requires to asking prompt. If you write every arguments in the CLI, they wouldn't be installed.

Can typia not rely on those packages itself?

@EricDunaway When running npx typia setup command without install, it can't import dependencies by itself.


kitchen-sink-controlled example link to CodeSandbox leads to kitchen-sink repo

https://github.com/tannerlinsley/react-table/tree/master/examples/kitchen-sink-controlled - the anchor in README.md links to https://codesandbox.io/s/github/tannerlinsley/react-table/tree/master/examples/kitchen-sink instead of https://codesandbox.io/s/github/tannerlinsley/react-table/tree/master/examples/kitchen-sink-controlled - which, by the way, seems to be broken for me. I'm not sure what's wrong there since I'm getting that infamous cross-origin error in Code Sandbox, but it's not working.

The link is now fixed.

And the controlled example is now fixed.


Update README.md

There is no 1.2.4 in Maven Central Repository.

Same for me  http://search.maven.org/#search|ga|1|photoview :/

Hi @smarek - do you know if 1.2.4 will be built and pushed to a Maven repo at some point? Thanks for your work!

Same http://mvnrepository.com/artifact/com.github.chrisbanes.photoview/library

@pmq nope, sorry, this is up to Chris to do that, I never had the signature keys. You have to urge him directly, nothing I could do for you, sorry.

Thanks @smarek for the info. I guess we'll continue to consume our own builds.

so frustrating this was never handled.

As simple workaround you can use my repo instead of Maven Central for 1.2.4. Just add repo to repos list:
repositories {
    maven { url 'https://dl.bintray.com/alexeydanilov/maven' }
}

I just published the actual version (29 Apr 2015).

@chrisbanes any news on that? Can you publish the 1.2.4 version to maven central? Or give the keys to another maintainer?

Maintenance has been turned over, the gradle dependency should work correctly now. Check the README for the latest.


lib/bindings fail to build with system lua.h installed

make[4]: Nothing to be done for `all-am'.
Making all in bindings
  CXX      lua.lo
  CXX      bindings.lo
  CXX      repl.lo
  CXX      metrics.lo
lua.cc:56:14: error: use of undeclared identifier 'lua_equal'; did you mean 'lua_rawequal'?
    result = lua_equal(L, -1, -2) == 1;
             ^~~~~~~~~
             lua_rawequal
/opt/local/include/lua.h:217:16: note: 'lua_rawequal' declared here
LUA_API int   (lua_rawequal) (lua_State *L, int idx1, int idx2);
               ^
1 error generated.
make[3]: *** [lua.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from metrics.cc:24:
./bindings.h:65:67: error: unknown type name 'luaL_reg'; did you mean 'luaL_Reg'?
  static void register_metatable(lua_State *, const char *, const luaL_reg *);
                                                                  ^~~~~~~~
                                                                  luaL_Reg
/opt/local/include/lauxlib.h:34:3: note: 'luaL_Reg' declared here
} luaL_Reg;
  ^
In file included from repl.cc:25:
./bindings.h:65:67: error: unknown type name 'luaL_reg'; did you mean 'luaL_Reg'?
  static void register_metatable(lua_State *, const char *, const luaL_reg *);
                                                                  ^~~~~~~~
                                                                  luaL_Reg
/opt/local/include/lauxlib.h:34:3: note: 'luaL_Reg' declared here
} luaL_Reg;
  ^
1 error generated.
In file included from bindings.cc:24:
./bindings.h:65:67: error: unknown type name 'luaL_reg'; did you mean 'luaL_Reg'?
  static void register_metatable(lua_State *, const char *, const luaL_reg *);
                                                                  ^~~~~~~~
                                                                  luaL_Reg
/opt/local/include/lauxlib.h:34:3: note: 'luaL_Reg' declared here
} luaL_Reg;
  ^
make[3]: *** [repl.lo] Error 1
bindings.cc:330:77: error: unknown type name 'luaL_reg'; did you mean 'luaL_Reg'?
BindingInstance::register_metatable(lua_State *lua, const char *name, const luaL_reg *metatable)
                                                                            ^~~~~~~~
                                                                            luaL_Reg
/opt/local/include/lauxlib.h:34:3: note: 'luaL_Reg' declared here
} luaL_Reg;
  ^
bindings.cc:339:3: error: use of undeclared identifier 'luaL_register'
  luaL_register(lua, nullptr, metatable);
  ^
metrics.cc:51:5: error: use of undeclared identifier 'luaL_typerror'; did you mean 'luaL_argerror'?
    luaL_typerror(L, index, "userdata");
    ^~~~~~~~~~~~~
    luaL_argerror
/opt/local/include/lauxlib.h:46:17: note: 'luaL_argerror' declared here
LUALIB_API int (luaL_argerror) (lua_State *L, int arg, const char *extramsg);
                ^
3 errors generated.
metrics.cc:141:5: error: use of undeclared identifier 'luaL_typerror'; did you mean 'luaL_argerror'?
    luaL_typerror(L, 3, "userdata or table");
    ^~~~~~~~~~~~~
    luaL_argerror
/opt/local/include/lauxlib.h:46:17: note: 'luaL_argerror' declared here
LUALIB_API int (luaL_argerror) (lua_State *L, int arg, const char *extramsg);
                ^
metrics.cc:199:16: error: unknown type name 'luaL_reg'; did you mean 'luaL_Reg'?
  static const luaL_reg metatable[] = {
               ^~~~~~~~
               luaL_Reg
/opt/local/include/lauxlib.h:34:3: note: 'luaL_Reg' declared here
} luaL_Reg;
  ^
make[3]: *** [bindings.lo] Error 1
4 errors generated.
make[3]: *** [metrics.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
make: *** [all-recursive] Error 1
zymMBPr:trafficserver zym$

@mingzym what is the system lua package version you've tried to build TS against?

@mingzym couldn't reproduce the issue with default TS configuration step and system lua package installed (liblua5.2-dev package used).

luajit in no longer in our tree and we depend on the installed package.


Kotlin wasm: improved API for handle declaration

Same idea as #4149

Couldn't the Singleton be lazily-instantiated within the getValue method?
On Tue, Dec 10, 2019 at 3:08 PM mykmartin<EMAIL_ADDRESS>wrote:

@mykmartin commented on this pull request.
In particles/Native/Wasm/source/TestParticle.kt
https://github.com/PolymerLabs/arcs/pull/4226#discussion_r356327320:

private val data = Singleton(this, "data", { TestParticle_Data() })

private val res = Singleton(this, "res", { TestParticle_Res() })
private val info = Collection(this, "info", { TestParticle_Info() })

It doesn't look like that's going to work. The Singleton class needs the
Particle reference during construction, and thisRef (which would be the
Particle) only seems to be available via the getValue/setValue calls,
which only occur when the field is accessed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PolymerLabs/arcs/pull/4226?email_source=notifications&email_token=AABBCLQ3QUUXKZTEG25H2UTQYAONFA5CNFSM4JWMOFQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOXI7SY#discussion_r356327320,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABBCLSOOQKXS2YC6UPR653QYAONFANCNFSM4JWMOFQA
.

--
Jason Feinstein
Software Engineer | Cerebra | Seattle

I don't think so. particle.registerHandle(this) needs to be called with this == the Singleton object, so that entity data from the JS runtime can be routed to the correct handles. That transfer may happen before anything accesses the handle fields on a particle.

+1 to Jason's changes.

This PR broke google3 -- rolling back in https://github.com/PolymerLabs/arcs/pull/4262

Good stuff @mykmartin, also linking #3665.


feat: Shape context

Shape will implement in: https://github.com/WiredSolutions/react-azure-maps/pull/35


tests run should fail if any pageerror detected

pageerror should be treated as whole tests run failure

Not really page error, since I've already encountered a cases where negative tests performed and there are intentional errors (either network related [400, 404], or code related ones).
This issue needs further digesting.


leminiscate calculator

I would like to add calculator for leminiscate

Go ahead
Deadline 17 May,2021

#1948
Check this

I have already done it earlier.


Make "Things I Do" cards link-able

I really like this theme for personal websites. I like the "Things I do" cards, but I think they would be even cooler if you could link something to them to send people to either other parts of the content on the site or to another URL where I have some content.
Let me know if you need any more info or screenshots for what I mean. I appreciate it!

Hii @dombraccia , I moved the V2 to separate repo. You can check them here

I like the "Things I do" cards, but I think they would be even cooler if you could link something to them to send people to either other parts of the content on the site or to another URL where I have some content.

It was already added there.

config.yaml
demo


Upgrades rust stable toolchain to 1.80.0

Rust 1.80.0 has been released.
https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html

uploaded the docker image but got the cfg warning in this PR. iirc our py script will complain about this new lint field

okay. I think I will take over this one!