WillPopScope + alerttDialog throws an exception when tapping the background

Steps to Reproduce

Run the following app
When navigating back from the second page, tap the background of the AlertDialog
...this returns null instead of false, throwing an exception

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Home'),
      ),
      body: Center(
        child: RaisedButton(
          child: Text('Go to other page'),
          onPressed: (){
            Navigator.push(
              context,
              MaterialPageRoute(builder: (context) => MyOtherPage()),
            );
          },
        ),
      ),
    );
  }
}

class MyOtherPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return WillPopScope(
      onWillPop: () => showDialog(
        context: context,
        builder: (BuildContext context) {
          return AlertDialog(
            title: Text('Quit Without Saving?'),
            actions: <Widget>[
              FlatButton(
                child: Text('Cancel'),
                onPressed: () {
                  Navigator.of(context).pop(false);
                },
              ),
              FlatButton(
                child: Text('Quit'),
                onPressed: () {
                  Navigator.of(context).pop(true);
                },
              ),
            ],
          );
        }
      ),
      child: Scaffold(
        appBar: AppBar(
          title: Text('Home'),
        ),
        body: Center(
          child: Column(
            children: <Widget>[
              Text('Go back, then hit the background of the modal'),
              Text('...this will trigger an exception <asyncronous gap>'),
            ],
          ),
        ),
      ),
    );
  }
}

Expected results:
To not throw an exception
Actual results:
It throws an exception (see logs below)
Fix
Chain the future to add null safety.
Interface-wise this is correct, but it's a sneaky caveat that keeps tripping me up. Not sure if it's a bug, or just worth mentioning in the docs.
onWillPop: () => showDialog(
  context: context,
  builder: (BuildContext context) {
    return AlertDialog(
      ....
    );
  }
).then((value) => value ?? false),

Logs

> tmp flutter run --verbose
(REDACTED)
Unhandled Exception: Failed assertion: boolean expression must not be null
[        ] [DEVICE LOG] #0      ModalRoute.willPop (package:flutter/src/widgets/routes.dart:1135:26)
[   +2 ms] [DEVICE LOG] <asynchronous suspension>
[        ] [DEVICE LOG] #1      NavigatorState.maybePop (package:flutter/src/widgets/navigator.dart:2078:57)
[        ] [DEVICE LOG] #2      Navigator.maybePop (package:flutter/src/widgets/navigator.dart:1337:34)
[        ] [DEVICE LOG] #3      BackButton.build.<anonymous closure> (package:flutter/src/material/back_button.dart:105:21)
[        ] [DEVICE LOG] #4      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:706:14)
[        ] [DEVICE LOG] #5      _InkResponseState.build.<anonymous closure>
(package:flutter/src/material/ink_well.dart:789:36)
[        ] [DEVICE LOG] #6      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
[        ] [DEVICE LOG] #7      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:486:11)
[        ] [DEVICE LOG] #8      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:264:5)
[        ] [DEVICE LOG] #9      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestur<…>
[   +9 ms] [VERBOSE-2:ui_dart_state.cc(157)] Unhandled Exception: Failed assertion: boolean expression must not be null
[        ] #0      ModalRoute.willPop (package:flutter/src/widgets/routes.dart:1135:26)
[        ] <asynchronous suspension>
[        ] #1      NavigatorState.maybePop (package:flutter/src/widgets/navigator.dart:2078:57)
[        ] #2      Navigator.maybePop (package:flutter/src/widgets/navigator.dart:1337:34)
[        ] #3      BackButton.build.<anonymous closure> (package:flutter/src/material/back_button.dart:105:21)
[        ] #4      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:706:14)
[        ] #5      _InkResponseState.build.<anonymous closure> (package:flutter/src/material/ink_well.dart:789:36)
[        ] #6      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
[        ] #7      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:486:11)
[        ] #8      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:264:5)
[        ] #9      BaseTapGestureRecognizer.acceptGesture (package:flutter/src/gestur<…>

flutter analyze
Analyzing tmp...
No issues found! (ran in 1.8s)

flutter doctor -v
[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.3 19D76,
    locale en-GB)
    • Flutter version 1.12.13+hotfix.8 at /Users/david/Development/flutter
    • Framework revision 0b8abb4724 (3 weeks ago), 2020-02-11 11:44:36 -0800
    • Engine revision e1e6ced81d
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/david/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.2.1, Build version 11B500
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 40.2.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build
      1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.42.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (1 available)
    • iPhone 8 Plus • 4F6B6FB8-B9F1-431F-B67F-AC9074C6A2DC • ios •
      com.apple.CoreSimulator.SimRuntime.iOS-13-2 (simulator)

• No issues found!

Hi @oodavid
Please check this DartPad Gist
Unable to reproduce the exception from your code
Thank you

@TahaTesser your DartPad Gist throws an exception - see the console.
Uncaught (in promise) Error: Failed assertion: boolean expression must not be null
  ...

DartPad should probably bubble the errors into the UI...


Vulkan: vkGetImageMemoryRequirements doesn't work on swapchain images with RenderDoc attached

Description
With RenderDoc attached, calling vkGetImageMemoryRequirements with a swapchain image as the parameter, fills the corresponding VkMemoryRequirements object with all zeroes.

Steps to reproduce

Create a swapchain with vkCreateSwapchainKHR
Fetch swapchain images using vkGetSwapchainImagesKHR
Call vkGetImageMemoryRequirements on one of the returned swapchain images.
Observe that the VkMemoryRequirements struct has been filled with all zeroes.

Environment

RenderDoc version: 1.18 official. Issue couldn't be reproduced on version 1.16.
Operating System: Windows 10
Graphics API: Vulkan
GPU: NVIDIA RTX 2070 Super
Driver version: 511.23

This is invalid behaviour, swapchain images are fully bound to memory so it should be invalid to query for their memory requirements - even if you could query for it the return values would not be actionable since you can't bind their memory so you shouldn't expect any particular values.
I can't see an obvious VUID in the spec preventing this which seems like a spec bug, I'll file an issue.


Add riscv64 arch

@SuperQ  PTAL!

@dongjiang1989 This needs rebase

@dongjiang1989 sorry man but looks like this needs another rebase.


invalid_api_key: when editing API key using Godot editor is overridden on save

When I edit the API key in addons/GPTIntegration/settings.json using Godot text edit and save it this new value is not used and overridden when closing Godot.
Workaround

disable plugin
edit addons/GPTIntegration/settings.json
enable plugin

I have just fixed this
Thanks!


Fix path in PowResetPassword README.md

Maybe we should add <%= ... %> too, for easier ctrl+c?

Oh 🤦♂ It's correct, nvm. A bit confusing naming, though :p

Yeah I know. It’s because the extension is called PowResetPassword and the controller is called ResetPasswordController so the full alias becomes pow_reset_password_reset_password. Not pretty, but I couldn’t find a better option when I built the extension router logic 😅

I’m fine with adding <%= ... %> btw.


Defined new revisions for golang dep: github.com/square/go-jose

Ran component through the scanners since I noticed it had not been harvested yet and it correctly declared the license. Closing PR as it is no longer needed.


[IO-557] Perform locale independant upper case conversions.

To handle properly lower cased character encoding name in XML prolog
with any default system locale, notably Turkish which has specific rules for case conversion of dotted and dotless i characters.
Fixes issue IO-557.

Coverage remained the same at 89.894% when pulling 9969d9b4fbe25c136031d70734de286a4e08ff7a on luccioman:case_conversion into 65c4a9c0ec651dd99f28b9fae40378728d071985 on apache:master.


how to apply in InceptionV3

how to apply in InceptionV3

Hi @fuchao01 , the procedure of applying in InceptionV3 is the same as the other networks:

I would not suggest to replace all of them which would not only affect the speed but also cause overfitting problem.

I would suggest to first only replace one ReLU in each bottleneck (e.g.this one) which is supposed to see improvements, then you can gradually add more to achieve an optimum speed-accuracy trade-off.


update submodules to get to latest LUS main

needs:

https://github.com/louist103/ZAPDTR/pull/19
https://github.com/louist103/OTRExporter/pull/27

fixes https://github.com/HarbourMasters/2ship2harkinian/issues/571, https://github.com/HarbourMasters/2ship2harkinian/issues/557, https://github.com/HarbourMasters/2ship2harkinian/issues/582 (via https://github.com/Kenix3/libultraship/pull/609)
fixes https://github.com/HarbourMasters/2ship2harkinian/issues/519 (via https://github.com/Kenix3/libultraship/pull/606)

Build Artifacts

2ship-mac.zip
2ship-windows.zip

closing in favor of https://github.com/HarbourMasters/2ship2harkinian/pull/614


[3.5] plan change removed local hot backups

…nconsistencies
Pull Request Guidelines
Pull requests are an essential collaborative tool for modern software development.
The below list is intended to help you figure out whether your code is ready to be reviewed
and merged into ArangoDB. The overarching goal is to:

Reduce the amount of recurring defects
Reduce the impact to the other developer’s time and energy spent on defects in your code
Increase the overall autonomy and productivity of individual developers

Acceptance Checklist
The below list is not exhaustive, think thoroughly whether the provided information is sufficient.
Remove options that do not apply
Scope & Purpose
(Can you describe what functional change your PR is trying to effect?)

[ ] Bug-Fix for devel-branch (i.e. no need for backports?)
[ ] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[ ] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[ ] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[ ] The behavior change can be verified via automatic tests

Related Information
(Please reference tickets / specification etc )

[ ] There is a GitHub Issue reported by a Community User:
[ ] There is an internal planning ticket:
[ ] There is a JIRA Ticket number (In case a customer was affected / involved):
[ ] There is a design document:

Testing & Verification
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This PR adds tests that were used to verify all changes:

[ ] Added Regression Tests (Only for bug-fixes)
[ ] Added new C++ Unit Tests (Either GoogleTest or Catch-Test)

Did you add tests for a new RestHandler subclass ?
Did you add new mocks of underlying code layers to be able to verify your functionality ?
...

[ ] Added new integration tests (i.e. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

Additionally:

[ ] There are tests in an external testing repository (i.e. node-resilience tests, chaos tests)
[ ] I ensured this code runs with ASan / TSan or other static verification tools

(Include link to Jenkins run etc)

Think about whether the new code you added is modular enough to be
easily testable by unit tests written with GTest / Catch. It is not good if your feature is so interconnected
that it prevents other people from writing their own unit gests. It should be possible
to use your code in future without extensively mocking your classes.
A bad example that required some extensive effort would be the storage engine API.

Documentation

All new Features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the changelog so that
developers and users have a concise overview.

[ ] Added a Changelog Entry (referencing the corresponding public or internal issue number)
[ ] Added entry to Release Notes
[ ] Added a new section in the Manual
[ ] Added a new section in the http API
[ ] Added Swagger examples for the http API

CLA Note
Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/8737/

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/8739/ new try.

The one test that is broken in the Jenkins run is dump in the cluster, which seems to be broken in the 3.5 branch from my local tests.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/8760/

Tests blue.


Repair test utility files that are not compiling due to changes made in the model component.

I'll not do this for now because everyone is still working on the test cases and it may cause lots of merge conflicts later.


PR: Restore sorting of types and natural sorting

related: https://github.com/spyder-ide/spyder-kernels/pull/246
I've re-implemented the natural sorting, now it should also work when sorting for types, etc.
Issue(s) Resolved

Fixes #13733
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
skjerns

I don't quite understand why the merging is blocked, can someone enlighten me? according to https://github.com/spyder-ide/spyder/pull/13791/files all should be fine

Hi @skjerns I think the base was set to master instead of 4.x Thanks for the help with this one :+1:

Hello @skjerns! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file external-deps/spyder-kernels/spyder_kernels/utils/nsview.py:

Line 263:9: E731 do not assign a lambda expression, use a def
Line 265:9: E731 do not assign a lambda expression, use a def

In the file spyder/plugins/variableexplorer/widgets/collectionseditor.py:

Line 75:39: E701 multiple statements on one line (colon)

In the file spyder/plugins/variableexplorer/widgets/tests/test_collectioneditor.py:

Line 850:1: E303 too many blank lines (3)
Line 858:28: E231 missing whitespace after ':'
Line 858:57: E231 missing whitespace after ':'
Line 859:26: E231 missing whitespace after ':'
Line 859:29: E231 missing whitespace after ':'
Line 859:38: E231 missing whitespace after ':'
Line 881:46: E231 missing whitespace after ','
Line 881:48: E231 missing whitespace after ','

Hi @skjerns I think the base was set to master instead of 4.x Thanks for the help with this one 👍

Ah! That makes sense.

Line 263:9: E731 do not assign a lambda expression, use a def
Line 265:9: E731 do not assign a lambda expression, use a def

I would like to keep it as a lambda. I think a lambda is far more comprehensible in this case. What do you think, can we make an exception?

Thanks for the changes @skjerns I think that using the lambda is fine :+1:
Now I will merge the spyder-kernels PR and then we will need to update the git-subrepo of the kernel here (that will also re-trigger the CI and hopefully the flaky test in mac will pass without issues). After that this should be ready to be merged :)

@skjerns I merged spyder-ide/spyder-kernels#246 now the missing thing is to update the git subrepo of the kernel to have the latest version in 1.x. Let us know if you want to do that or if you want me to take care of that. Thanks again for working on this one!

@dalthviz can you do that? I had quite some trouble setting up the subrepo under Windows


java.util.logging (JUL) messages below INFO level are not recorded in Karaf logs

Deploying Karaf 4.4.3 using Equinox OSGi System Bundle, log messages from java.util.logging.Logger below the INFO level (i.e. FINEST, FINER and FINE) are not recorded in karaf.log

I did compile your example as-is.
I modified etc/org.ops4j.pax.logging.cfg following your directions.
I restarted the Karaf service (hereby I'm testing on a Windows machine)
I even restarted the test.grgr bundle to be sure I did not miss something.
Here is my output:
2023-03-29T18:12:21,568 | DEBUG | Karaf ssh console user karaf | LoggingCommandSessionListener    | 45 - org.apache.karaf.shell.core - 4.4.3 | Executing command: 'start 53'
2023-03-29T18:12:21,570 | DEBUG | pipe-start 53    | configurator                     | 14 - org.apache.felix.configurator - 1.0.16 | Adding bundle grgr.test:<IP_ADDRESS>303291811 (53) : starting
2023-03-29T18:12:21,573 | DEBUG | pipe-start 53    | ActivatorLogging                 | 53 - grgr.test - <IP_ADDRESS>303291811 | event [1 testKey="testValue"] message
2023-03-29T18:12:21,574 | DEBUG | pipe-start 53    | ActivatorLogging                 | 53 - grgr.test - <IP_ADDRESS>303291811 | From SLF4J
2023-03-29T18:12:21,574 | DEBUG | pipe-start 53    | configurator                     | 14 - org.apache.felix.configurator - 1.0.16 | Adding bundle grgr.test:<IP_ADDRESS>303291811 (53) : active
2023-03-29T18:12:21,574 | DEBUG | pipe-start 53    | InfoBundleTrackerCustomizer      | 44 - org.apache.karaf.shell.commands - 4.4.3 | Ignore incorrect info null provided by bundle grgr.test
2023-03-29T18:12:21,575 | DEBUG | Karaf ssh console user karaf | LoggingCommandSessionListener    | 45 - org.apache.karaf.shell.core - 4.4.3 | Command: 'start 53' returned 'null'

So still not JUL output.
Note 1: I'm using Eclipse Equinox as OSGi system bundle.
Note 2: I found a bit unfair that the ticket has been closed before had a the chance either confirm or infirm that this is working ...
I will retry with a very plain install "vanilla" fresh install, i.e. without Windows Service and without change the OSGi system bundle from Felix to Equinox to see if I've more chance
PS. here is my MANIFEST.MF:
Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: Test
Bundle-SymbolicName: grgr.test
Bundle-Version: 1.0.0.qualifier
Bundle-Activator: grgr.test.ActivatorLogging
Bundle-RequiredExecutionEnvironment: JavaSE-17
Automatic-Module-Name: grgr.test
Import-Package: org.osgi.framework;version="1.3.0",
 org.apache.logging.log4j;version="[2,3)",
 org.apache.logging.log4j.message;version="[2,3)",
 org.slf4j;version="[1,2)"
Bundle-ActivationPolicy: lazy

On the vanilla install it even worse, I've simply nothing from your test bundle.
I just realized that I've changed in the Windows Service installation, the log4j2.rootLogger.level from INFO to DEBUG in etc/org.ops4j.pax.logging.cfg configuration file.
So in the fresh "vanilla" installation, log4j2.rootLogger.level=INFO ...

Tested on Linux, still vanilla Karaf installation:
2023-03-29T18:55:20,995 | DEBUG | pipe-start 52    | ActivatorLogging                 | 52 - grgr.test - <IP_ADDRESS>303291811 | event [1 testKey="testValue"] message
2023-03-29T18:55:20,996 | DEBUG | pipe-start 52    | ActivatorLogging                 | 52 - grgr.test - <IP_ADDRESS>303291811 | From SLF4J

Still no messages from java.util.logging

Please show me the changes you made to your original Karaf 4.4.3 installation (that you've chosen Equinox and what exactly did you add to etc/org.ops4j.pax.logging.cfg).
If possible, please attach the bundle (source or jar). This simply must work ;)

Some clarifications: For my project I made an "Windows Service" of the Karaf installation using Equinox as OSGi System bundle.
But to test your example I downloaded the latest version, i.e. version 4.4.3, of Karaf OSGi Runtime and deployed it on both a Windows machine and a Linux machine, plain vanilla, i.e. no change for Equinox, still using Felix as it is configured by default!
Deployed the zip (Windows), tar.gz (Linux) in both OSes in the current logged-in user's home directory, started it on both OSes from command line (i.e. no Windows Service, no Unix Daemon) with current logged-in user privileges (note the user hasn't the  Windows Admin privilege, and on Linux it is not the root user and Karaf has not been started with sudo)
The only thing I changed to fresh install is the etc/org.ops4j.pax.logging.cfg configuration file, adding these two lines at the end of the file as you instructed me:
log4j2.logger.grgr.name = grgr.test
log4j2.logger.grgr.level = ALL

Then I deployed the bundle.
And ensured that it is properly started
Writting these lines, I just re-do all these steps on the Linux machine.
Shell:
curl -L https://archive.apache.org/dist/karaf/4.4.2/apache-karaf-4.4.2.tar.gz -o ~/Downloads/apache-karaf-4.4.2.tar.gz
tar xzf ~/Downloads/apache-karaf-4.4.2.tar.gz
cat << EOF | tee -a ~/apache-karaf-4.4.2/etc/org.ops4j.pax.logging.cfg
log4j2.logger.grgr.name = grgr.test
log4j2.logger.grgr.level = ALL
EOF
mkdir -p ~/apache-karaf-4.4.2/data/log && touch ~/apache-karaf-4.4.2/data/log/karaf.log
tail -f ~/apache-karaf-4.4.2/data/log/karaf.log &
cd ~/apache-karaf-4.4.2/bin && ./karaf

Karaf:
bundle:install file:///${user.home}/Downloads/grgr.test_<IP_ADDRESS>303291811.jar
bundle:start grgr.test
shell:logout

karaf.log
2023-03-30T11:27:15,391 | DEBUG | pipe-bundle:start grgr.test | ActivatorLogging                 | 52 - grgr.test - <IP_ADDRESS>303291811 | event [1 testKey="testValue"] message
2023-03-30T11:27:15,392 | DEBUG | pipe-bundle:start grgr.test | ActivatorLogging                 | 52 - grgr.test - <IP_ADDRESS>303291811 | From SLF4J

Hereby your code compiled and exported as  "Plug-in Development => Deployable plug-ins and fragments"  (Eclipse Plugin == OSGi bundle) by Eclipse IDE for RCP and RAP Developers
Note: I had to rename the extension from ".jar" to ".zip" in order to have Github accepting the file attachment.
So please rename it back to ".jar" (... as technically Jar files are Zip files)
grgr.test_<IP_ADDRESS>303291811.zip

Also when I start this sample bundle, then restart pax-logging-log4j2 bundle and then restart the sample bundle again, the FINE level is logged.

Doing the same steps
Karaf:
bundle:start grgr.test
bundle:restart org.ops4j.pax.logging.pax-logging-log4j2
bundle:restart grgr.test

I confirm that I can see karaf.log the FINEST, FINER and FINE logs from java.util.logging
2023-03-30T14:41:34,316 | DEBUG | pipe-bundle:restart grgr.test | ActivatorLogging                 | 52 - grgr.test - <IP_ADDRESS>303291811 | event [1 testKey="testValue"] message
2023-03-30T14:41:34,317 | DEBUG | pipe-bundle:restart grgr.test | ActivatorLogging                 | 52 - grgr.test - <IP_ADDRESS>303291811 | From SLF4J
2023-03-30T14:41:34,319 | DEBUG | pipe-bundle:restart grgr.test | ActivatorLogging                 | 52 - grgr.test - <IP_ADDRESS>303291811 | "fine" From java.util.logging
2023-03-30T14:41:34,320 | TRACE | pipe-bundle:restart grgr.test | ActivatorLogging                 | 52 - grgr.test - <IP_ADDRESS>303291811 | "finer" From java.util.logging
2023-03-30T14:41:34,321 | TRACE | pipe-bundle:restart grgr.test | ActivatorLogging                 | 52 - grgr.test - <IP_ADDRESS>303291811 | "finest" From java.util.logging

Thank you! Now I've a workaround!

Still I would like to emphasis that going for java.util.logging is not a choice but a constraint.
Possibly I could pick a different logging library for the bundles that that I'm developing.
... And I'm not so fond to the idea to go for Log4J2, first it will and yet another bundle dependency, and last but not least, its is not like Log4J2 never had Common vulnerabilities and Exposures!
That said to come back to the constraint aspect, I'm not the owner of the other bundles that are still using java.util.logging, e.g. SQLServer JDBC Library, or any other JDBC Library relying on java.sql.Driver.getParentLogger()
I believe that my troubleshooting nightmare began with pax-logging-api bundle taking over the root java.util.logging.Logger (cf. org.ops4j.pax.logging.internal.Activator line #80 without any indication neither in the Karaf logs not in its documentation (or maybe is there a Wiki/Documentation somewhere else!?).
I mean if pax-logging-api would read the org.ops4j.pax.logging.skipJUL System Property flag with true as default value, it would let the option to the packager to rely on the well documented java.util.logging.LogManager and to configure it to record the log messages from java.util.logging in a side log file (e.g. etc/data/log/jul.log). It would not be very fancy, but at least it will work.
So would it be possible to ...

change the default behavior of org.ops4j.pax.logging.internal.Activator to not take over JUL root Logger by default, i.e. assign true as default value for org.ops4j.pax.logging.skipJUL ?
add these lines in $KARAFE_HOME/etc/system.properties to indicate how to take over java.util.logging by the pax-logging-api?

org.ops4j.pax.logging.skipJUL = false # Change to "true" in order to redirect java.util.logging to "$KARAFE_HOME/etc/karaf.log"
org.ops4j.pax.logging.skipJULReset = false # Change to "true" to reset the root java.util.logging.LogManager

add a log message in org.ops4j.pax.logging.internal.Activator to indicate the redirection is effective?
document both flags org.ops4j.pax.logging.skipJUL and org.ops4j.pax.logging.skipJULReset in the documentation main Web page?

Thanks again for your analysis.
Definitely there's a problem with JUL logger configured after the backend has been configured. However, because only you've found it, it may mean that JUL is not that popular ;)
Some ancient (without skipJUL) documentation is available here: https://ops4j1.jira.com/wiki/spaces/paxlogging/pages/499286109/Configuration
Sure - Log4J has CVEs, but it also means it's used, analyzed and taken care of. To be honest I think JUL is quite limited (imagine multiple WARs configured in Tomcat, each trying to configure logging differently) and mostly usable with flat-classpath deployments...
So I'll definitely have a look at proper configuration of JUL - in the scenario you've found when the logger is obtained after Log4J2 / Logback is configured.

... imagine multiple WARs configured in Tomcat, each trying to configure logging differently

Tomcat has since a long time addressed this issue with JULI, cf. Logging in Tomcat
And the configuration syntax for JULI is based on the one of JUL with some extensions that are inherent to the fact that JULI handles logs from multiple WARs
(Note here: I can understand that Log4J has different calls and log levels as it predate JUL!)
To my point of view, java.util.logging (JUL), wherever we like it or not, should be considered as a first class citizen as it is the logger that comes along with the JDK.
I appreciate that you envision to put in place another hack to cover this corner case,
still please also consider my 4 recommandations/requests above.
... I understand that coding is fancy, still documentation matters and helps*!
*) E.g. #519 provides a record of org.ops4j.pax.logging team rationale behind the implementation choice with pros and cons.

As mentioned in ops4j/org.ops4j.pax.jms#65, documentation is a bit lacking in ops4j projects. These are community driven project with quite little interest these days (OSGi's golden age is long gone I guess...).
(Un)fortunately, known bugs should be simply visible at this page ;) https://github.com/ops4j/org.ops4j.pax.logging/issues
And I really know that this particular problem can be fixed - I just didn't have time to do it...

I found this issue today when trying to enable low level logging for the MS SQL JDBC driver which (as mentioned above) uses JUL. @ffays suggestion of an option to not try and take over JUL and just let me write a logging.properties would work for me.


Explicit latitude/longitude in card config may use the wrong time zone for computing Sun/Moon events

The latitude and longitude settings allow users to override the configured location of their HA. Originally these options were intended mostly for debugging but I realised they can be very useful for configuring a card that shows the Sun/Moon in a different location just because you want so. Unless you also explicitly configure the right time zone via time_zone (or the time zone of HA is close enough to the one of the explicit location) the computation for the location may be slightly wrong. Since the time_zone setting is meant to alter the displayed event times and not affect computation I plan to change the computational time zone to be derived from the longitude of the location (note for nerds: SunCalc, the library used to compute the events, needs to know when it's noon/midnight at the location).
The change should result in more accurate and stable calculations for everyone (i.e., regardless of whether an explicit location is configured) and allow for these use cases:

I want to show the Sun/Moon events in a remote location and see the event times in that location's time zone (latitude, longitude, time_zone need to be set)
I want to show the Sun/Moon events in a remote location and see the event times in my local time zone (latitude, longitude need to be set)

Sounds great. Imho version 1.1 though :)

It's not a new feature per se and there is no action required by those who upgrade (i.e., no need for new config options). It just fits a patch level release.


Limited x by width and y by height.

Hi, Chintan-Dave.
I encountered bugs that lines.
X and Y could be exeeded width and height.
So I fixed to they can't be exeeded width and height.
Am I right?
Sincerely, Kim.

@kimjj81 Thanks


Update CI infra to test Docker Compose deployment

This commit enhances the CI environment (Travis-CI) to deploy Docker
containers via our docker-compose scripts. We then deploy with Ansible
against those containers in order to test our Ansible plays.

It failed due to a known issue, but it did point out that the log is far too long because of all the extra verbosity. Adding a new version which removes the verbosity. Then I'll merge this down, where things will be failing, but I'll work on "fixing" the known issues with filebeat deployment.

I'm going to merge this down anyways, because the failures we are seeing are either transient, or due to a known issue. The fact that the deploy tries to happen means the changes pushed here are active :)


Logs are not in documented path for Windows with Containerd

What happened:
Create an aks-engine cluster with containerd, schedule a pod and look for azure cni logs.  The are not in documented location but in c:\Windows\system32\
Example https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-aks-engine-azure-1-19-windows-containerd/1318630275701280768/artifacts/6211k8s000/
What you expected to happen:
Logs to be in c:\k\azure-vnet.log (https://github.com/Azure/azure-container-networking/blob/master/docs/cni.md#logs)
How to reproduce it:
Create windows cluster with containerd.  Example cluster config: https://github.com/kubernetes-sigs/windows-testing/blob/master/job-templates/kubernetes_containerd_1_19.json
On the Containerd machine:
PS C:\> Get-ChildItem -Path . -Filter '*azure-vnet*' -Recurse | %{$_.FullName}
C:\k\azurecni\bin\azure-vnet-ipam.exe
C:\k\azurecni\bin\azure-vnet-ipamv6.exe
C:\k\azurecni\bin\azure-vnet-telemetry.config
C:\k\azurecni\bin\azure-vnet-telemetry.exe
C:\k\azurecni\bin\azure-vnet.exe
C:\Windows\System32\azure-vnet-ipam.json
C:\Windows\System32\azure-vnet-ipam.log
C:\Windows\System32\azure-vnet-telemetry.log
C:\Windows\System32\azure-vnet.json
C:\Windows\System32\azure-vnet.log

Orchestrator and Version (e.g. Kubernetes, Docker):
Operating System (Linux/Windows):
Kernel (e.g. uanme -a for Linux or $(Get-ItemProperty -Path "C:\windows\system32\hal.dll").VersionInfo.FileVersion for Windows):
Anything else we need to know?:
[Miscellaneous information that will assist in solving the issue.]
Looks like the working directory for the executable is not set and the log path is https://github.com/Azure/azure-container-networking/blob/147c4388c80f643fff3138c35a913aba26dc1850/log/logger_windows.go#L14

Spoke with @jsturtevant offline - it seems that in the Docker scenario, kubelet invokes CNI, and kubelet's working directory is C:\k. In the containerd scenario, containerd invokes the CNI, and its working directory is C:\Windows\System32.
The current behavior of the CNI is to log to the current working directory (on Windows), so @jsturtevant is going to try setting the current working directory of containerd to C:\k and see if there are any side-effects.

Did a bit more digging and found that:

In the docker flow, the CNI is invoked by kubelet which has it's working directory in c:\k via nssm's APP Directory command in aks-engine
In the containerd flow, the CNI is invoked by containerd which is installed via service manager (--register-service flag containerd provides). Services default work directories are C:\system32 which is why the logs are set there.

As far as I know there isn't a way to set working directory of a service except via the code after the process starts up

As far as I know there isn't a way to set working directory of a service except via the code after the process starts up

In windows 10 you can set it via the AppDirectory service parameter (which is just a reg key)
https://stackoverflow.com/questions/54456689/change-start-in-path-of-windows-service
I'm wondering if we want the logs to show up in the containerd directory or the CNI bin directory (which it sounds like would happen if containerd set a work directory when calling CNI binaries)

As far as I know there isn't a way to set working directory of a service except via the code after the process starts up

In windows 10 you can set it via the AppDirectory service parameter (which is just a reg key)
https://stackoverflow.com/questions/54456689/change-start-in-path-of-windows-service
I'm wondering if we want the logs to show up in the containerd directory or the CNI bin directory (which it sounds like would happen if containerd set a work directory when calling CNI binaries)

generic issue for containerd: https://github.com/containerd/containerd/issues/4928

generic issue for containerd: https://github.com/containerd/containerd/issues/4928


AppCapability.Create: No explanation of valid capabilityName string values

AppCapability.Create(String) Method
should have link to https://docs.microsoft.com/en-us/windows/uwp/packaging/app-capability-declarations and explanation to use these capability names as string values to create AppCapability object.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 57a9ffe3-3b6a-f087-080d-b06c9e24435d
Version Independent ID: 67c5b36b-1c84-af6c-0489-ffe496f78192
Content: AppCapability.Create(String) Method (Windows.Security.Authorization.AppCapabilityAccess) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.Security.Authorization.AppCapabilityAccess/AppCapability.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @lastnameholiu
Microsoft Alias: alholiu

Have the same question here, it will be great to have more clear instructions on how to specify capabilityName

Hello. We apologize for the delay in resolving this issue. As we transition to a new feedback system, we are closing all outstanding issues. Any issues that can be addressed will be tracked using a different internal tool, and we regret that we won't be able to provide further updates on this particular matter. We value your input and assure you that all feedback is reviewed. We recommend visiting the Microsoft Q&A site, where your issue may have already been discussed.


Add Vijay Michalik to maintainers

Vijay has helped the Besu project through contributions to user questions, documentation and managing issues on the project.
Voting ends 2 weeks from the publication of this PR.
For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.
Approval of this PR
As for the maintainer addition, this PR being a significant change to the process, I require the same rules to be followed:

[ ] 2 weeks voting period (ends June 3rd 2021)
[x] at least 3 approvals
[x] no veto
[ ] absolute majority makes it pass immediately (currently 11 approvals).

From a process perspective #2307 needs to pass first, as without it there is insufficient justification in this PR.  Hence I vote block until either #2307 or a similar proposal passes. (to be explicit, if #2307 passes my block is removed).

@vmichalik has contributed variously and significantly to docs, Rocket Chat and support issues. Additionally triaging and organising GitHub issues.

Assuming @atoulme  is voting in favor, we reached 11 which is the absolute majority.


Add documentation for using external device services with snap

We should add documentation and/or examples that show how to create a snap with a device-service and hook it up with the edgexfoundry snap.

Related: https://github.com/edgexfoundry/device-sdk-go/issues/279

We can probably also use the recently published edgex-device-mqtt and the mosquitto snap as an example too.


Hermes channel create CLI

Closes: #715
Description

For contributor use:

[ ] Updated the Unreleased section of CHANGELOG.md with the issue.
[ ] If applicable: Unit tests written, added test to CI.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

Codecov Report

Merging #732 (cdb46b3) into master (b1b37f5) will increase coverage by 30.2%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #732      +/-   ##
=========================================
+ Coverage    13.6%   43.9%   +30.2%
=========================================
  Files          69     156      +87
  Lines        3752   10352    +6600
  Branches     1374       0    -1374
=========================================
+ Hits          513    4546    +4033
- Misses       2618    5806    +3188
+ Partials      621       0     -621

Impacted Files
Coverage Δ

...application/ics20_fungible_token_transfer/error.rs
0.0% <ø> (ø)

...ion/ics20_fungible_token_transfer/msgs/transfer.rs
0.0% <ø> (ø)

..._transfer/relay_application_logic/send_transfer.rs
0.0% <ø> (ø)

modules/src/events.rs
0.0% <ø> (ø)

modules/src/handler.rs
100.0% <ø> (ø)

modules/src/ics02_client/client_def.rs
47.3% <ø> (ø)

modules/src/ics02_client/client_type.rs
79.1% <ø> (+31.5%)
:arrow_up:

modules/src/ics02_client/context.rs
100.0% <ø> (ø)

modules/src/ics02_client/error.rs
100.0% <ø> (ø)

modules/src/ics02_client/events.rs
15.7% <ø> (+15.7%)
:arrow_up:

... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0c5d6...e1262af. Read the comment docs.

@ancazamfir @cezarad can you please have a look over this?


Update jasypt.adoc

Fix Title order affecting Camel website

Everything under docs is generated. You need to edit the source in the jasyptextension module here:
extensions/jasypt/runtime/src/main/doc/usage.adoc

Then run the build in that module (E.g mvn clean install) and it'll sync and assemble the final content over to docs.


charset trouble when irc to mattermost

Hi,
The plugin is great !
But i'm french and when there are accents in IRC sentences, mattermost shows strange characters.
Can you make matterbridge converting to the right charset, even if you need to create a new option in the conf file to give you the outgoing charset ?
Thanks,
Rémi

Is it possible to show a screenshot of those strange characters ? And what they should be?

@rizys, we've had reports of some browsers in Mattermost showing strange characters but we're not able to reproduce the issue. Could you join #matterbridge on freenode and post the characters causing issue?
They'll show up in the core team's Mattermost instance and we'll have a better chance of tracking down the issue.


Knotx Snippet defnition

Current
Fragment Splitter splits Template with a pattern <script data-knotx-knots=. So every Knotx snippet must define data-knotx-knots attribute and this attribute must be first in attribute in script tag. Knotx snippet contains `type="text/knotx-snippet" attribute but now it is not used.
Proposal
Fragment Splitter splits Template with pattern <script type="text/knotx-snippet". data-knotx-knots attribute is optional and if it is not defined all Knots configured in Knots Routing process Fragment. This could be very helpful while prototyping phase where we are not familiar with Knots.

Closing as outdated.


APIM 4.2.0 RC APICTL Testing

Description
This is to track APIM 4.2.0 ATICTL RC testing progress of @piyumaldk
Affected Component
APICTL
Version
4.2.0-RC
Related Issues
No response
Suggested Labels
No response

Work Log [2022-03-03]

Tested

Export Apis with --all flag
Import an existing API with --update flag with deployment-environments
Import an existing API with --update flag without deployment-environments

Tested

Prepare the environments
Create, Deploy, Publish and Export an API in a lower environment
Initialize the project using a Swagger/OpenAPI specification
Prepare an API project for CI/CD
Import the API to an upper environment
Get keys for an API/API Product
Extending a CI/CD pipeline to support API Products
Extending a CI/CD pipeline to support applications

Tested Adding an environment with MI, but stop that effort after that since I got informed that these MI related things are automated and already tested.

Major Blockers Faced during Testing

When deploying applications, faced below error.
Response: {"count":1,"list":[{"id":null,"name":"SwaggerPetstore","description":null,"context":null,"version":"1.0.0","type":null,"createdTime":null,"provider":"admin","lifeCycleStatus":null,"thumbnailUri":null,"avgRating":null,"throttlingPolicies":[],"advertiseInfo":null,"businessInformation":null,"isSubscriptionAvailable":null,"monetizationLabel":null,"gatewayVendor":null,"additionalProperties":[]}]}
But application was visible in the prod UI without the subscription API.

apictl get keys -n PizzaShackAPI -v 1.0.0 -e dev  -r admin -t https://localhost:8243/token did not work. This may more likely problem with local setup and need to dig deep to verify that I follow all steps correctly. Note that, without "-t https://localhost:8243/token", command works fine.

Noted that we don't have to commit changes to deploy. Only adding them will let us deploy them. Should have a discussion to figure out if this is expected.


Update double-key-encryption.md

Added information about including keyname to the URL when creating a label in the Compliance center.

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/4754

@JohanFreelancer9 Please copy review

@KCCross Please merge this PR. Thanks

@KCCross Gentle reminder


Update supported Rails versions in Readme

Clear-up that rspec-rails works with Rails versions above 5.0

Thanks @hayesr


implement #131: create bucket if it doesn't exist yet, mc only yet

The PR does NOT contain the AWS code yet, as I don't have neither the tool nor the means to test it.

Thanks for the contribution!

please test https://github.com/maxisam/mgob/releases/tag/2.0.25

Sorry for the delay! I'll test it on a test cluster next week.


Support csv with irregular column count

CSV files sometimes have missing columns. This makes it possible to still view them.

Thanks @mhuang74!


Nfd development

Silly code to generate, collect, and trade non-fungible dinos.

Could you rebase your commit and move the images out of the src folder and into a separate assets folder?

Can do. Not sure when it will happen. But it will happen.
Rebase my commits onto what? The current master branch?

Ok. Should be updated and ready to go.

Alright! Should be ready to go!


Segfault running example-1 with ocaml-multicore

Hi, I just tried running the dream tutorials on ocaml.4.12+domains and it segfaulted after a minute or so. I can reproduce it with the first example using siege (though when it originally happened it was idle).
Here's the test-case as a Dockerfile:
FROM ocaml/opam:debian-11-ocaml-4.12-domains
RUN sudo apt-get update && sudo apt-get install -y --no-install-recommends siege
RUN git clone https://github.com/aantron/dream.git --recursive
WORKDIR dream
RUN opam-2.1 install --deps-only -t .
RUN opam-2.1 exec -- dune build ./example/1-hello/hello.exe
RUN (./_build/default/example/1-hello/hello.exe || echo CRASH &); sleep 1; siege http://<IP_ADDRESS>:8080/ 2> /dev/null

I get a crash within a second or so:
$ docker build .
[...]
Step 7/7 : RUN (./_build/default/example/1-hello/hello.exe || echo CRASH &); sleep 1; siege http://<IP_ADDRESS>:8080/ 2> /dev/nl
 ---> Running in efdb276b969f
10.01.22 13:57:03.735                       Running at http://localhost:8080
10.01.22 13:57:03.735                       Type Ctrl+C to stop
New configuration template added to /home/opam/.siege
Run siege -C to view the current settings in that file
Segmentation fault (core dumped)
CRASH

The crash is in caml_darken. Is Dream expected to work on multicore?

Dream is expected to work on multicore. cc @yawaramin, who observed a similar failure. I haven't had time to look into this yet.

Looks like this is a bug in Ssl's C stubs: https://github.com/savonet/ocaml-ssl/issues/76

@talex5, many thanks for tracking that down!

This has been fixed upstream. Thanks again!


lndb.init with a brand new DB fails with NoReferencedTableError

Using a fresh init of lndb with a brand-new AWS postgreSQL server passed, it seems that there's an ordering issue with table and foreign key creation, resulting in the following exception:
sqlalchemy.exc.NoReferencedTableError: Foreign key associated with column 'dobject_experiment.experiment_id' could not find table 'experiment' with which to generate a foreign key to target column 'id'
Full stack trace:
Traceback (most recent call last):   File "/home/stgoodman123/storage/base.py", line 47, in <module>     _ = BaseConnection()   File "/home/stgoodman123/storage/base.py", line 22, in __init__     lndb.init(storage=blob_uri, db=sql_alchemy_uri, schema="bionty,wetlab", name="omni")   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/lndb_setup/_init_instance.py", line 112, in init     setup_schema(isettings, settings.user)   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/lndb_setup/_setup_schema.py", line 73, in setup_schema     msg, schema_names = load_schema(isettings)   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/lndb_setup/_setup_schema.py", line 65, in load_schema     module = importlib.import_module(get_schema_module_name(schema_name))   File "/home/stgoodman123/miniconda3/lib/python3.9/importlib/__init__.py", line 127, in import_module     return _bootstrap._gcd_import(name[level:], package, level)   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load   File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked   File "<frozen importlib._bootstrap>", line 680, in _load_unlocked   File "<frozen importlib._bootstrap_external>", line 850, in exec_module   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/lnschema_wetlab/__init__.py", line 45, in <module>     from ._core import (  # noqa   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/lnschema_wetlab/_core.py", line 87, in <module>     from ._actual import Biosample, Experiment, ExperimentType, Readout, Techsample   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/lnschema_wetlab/_actual.py", line 82, in <module>     add_relationship_keys(Biosample)   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/lnschema_core/dev/sqlmodel.py", line 109, in add_relationship_keys     for i in getattr(table, "__mapper__").relationships:   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/util/langhelpers.py", line 1184, in __get__     obj.__dict__[self.__name__] = result = self.fget(obj)   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/mapper.py", line 2621, in relationships     return self._filter_properties(   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/mapper.py", line 2643, in _filter_properties     self._check_configure()   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/mapper.py", line 1924, in _check_configure     _configure_registries({self.registry}, cascade=True)   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/mapper.py", line 3483, in _configure_registries     _do_configure_registries(registries, cascade)   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/mapper.py", line 3522, in _do_configure_registries     mapper._post_configure_properties()   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/mapper.py", line 1941, in _post_configure_properties     prop.init()   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/interfaces.py", line 231, in init     self.do_init()   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/relationships.py", line 2147, in do_init     self._setup_join_conditions()   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/relationships.py", line 2243, in _setup_join_conditions     self._join_condition = jc = JoinCondition(   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/relationships.py", line 2638, in __init__     self._determine_joins()   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/orm/relationships.py", line 2734, in _determine_joins     self.secondaryjoin = join_condition(   File "<string>", line 2, in join_condition   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/sql/selectable.py", line 1212, in _join_condition     constraints = cls._joincond_scan_left_right(   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/sql/selectable.py", line 1281, in _joincond_scan_left_right     col = fk.get_referent(left)   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/sql/schema.py", line 2378, in get_referent     return table.corresponding_column(self.column)   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/util/langhelpers.py", line 1113, in __get__     obj.__dict__[self.__name__] = result = self.fget(obj)   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/sql/schema.py", line 2519, in column     return self._resolve_column()   File "/home/stgoodman123/miniconda3/lib/python3.9/site-packages/sqlalchemy/sql/schema.py", line 2530, in _resolve_column     raise exc.NoReferencedTableError( sqlalchemy.exc.NoReferencedTableError: Foreign key associated with column 'dobject_experiment.experiment_id' could not find table 'experiment' with which to generate a foreign key to target column 'id'

Hi @samgoodman! Great to meet you here and thanks for reporting!
We can't judge what's going on based on what you shared. It runs stably in several test instances across AWS & GCP and our enterprise customers but might require some configuration work.
We could investigate what is happening here given your configuration and needs within a pilot project for an enterprise plan if you're interested! Let us know! ☺

Will do today, thanks Alex.

Awesome! Let me know when you'd like to have a first meeting - probably better to schedule via email!


Explore improvements to notifications when using a screen reader

During an inclusive design workshop focused on developer tools hosted by design teams at Microsoft, a panel of developers with a variety of disabilities singled out notifications as a pain point when using VS Code.
Screen reader users mentioned a few key areas to be improved:

How the notification announces itself (could be improved with audio cues as well)
How to know there were actions/buttons on a notification
How to reference the notification again when it disappears or is accidentally dismissed
Understanding the severity of a notification and if it was something they needed to engage with right away

cc @meganrogge

cc @jooyoungseo

How to reference the notification again when it disappears or is accidentally dismissed

We have this command Notifications: Show Notifications, but I'm not sure it's very discoverable

How to know there were actions/buttons on a notification

We could add a hint to the aria label and an accessibility.verbosity setting similar to the recent fix for discovering how to change a keybinding when a row is focused in the keybinding editor.

How the notification announces itself (could be improved with audio cues as well)

I believe we alert at the moment, so it should be clear that it has come in. We could consider an audio cue though I think that might be extra noise with little added value.

Understanding the severity of a notification and if it was something they needed to engage with right away

I think that hearing the notification's message should suffice here and we don't want to interpret the severity for a screen reader user.


Support tagged metrics in local backend

Coverage increased (+0.3%) to 96.887% when pulling 6b7d21c7b3c2bc0b99e72ef9714f47f091ada974 on support_tag_metrics into 7b113fceac673e60e5b10dff7039787bab5c5ed7 on master.


Proposed to my girlfriend with this

Just wanted to say thanks for making this. Just wrote an 8 branch adventure to propose to my girlfriend, taking her through turning points in our relationship with a ton of funny little hidden easter eggs if she made any negative choices. Definitely took a lot of googling and a little hacking to make it work 11 months since the last commit, but well worth it and still much easier than going from scratch. Thanks for making two kids' days out in Philadelphia.

That is Awesome Sauce! Thanks for sharing that story!
Johnny

I'd love to get that "little hacking to make it work 11 months since the last commit".  I teach technology to grades 2-6 and would love to do a simple project around this if I could get it installed and running on the class computers!


WebServiceTarget - Avoid re-throwing exceptions in async completion method

Attempt to resolve #2035

Codecov Report

Merging #2040 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2040   +/-   ##
======================================
  Coverage      82%     82%
======================================
  Files         286     286
  Lines       19663   19663
  Branches     2309    2309
======================================
  Hits        16042   16042
  Misses       3056    3056
  Partials      565     565

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9e2b2...cdbd236. Read the comment docs.

Why do we need this? If throwexceptions is enabled, we like to get exceptions?

@304NotModified We like exceptions, but not those that cannot be caught and crashes the application.

OK clear,  thanks!


add hitomi student bio

Checklists
General Checks

[x] the branch is up to date with main/master
[x] the code works when pulled and run locally
[x] All CI checks pass
[x] all conflicts are resolved (if any)
[x] PR has a descriptive title
[x] PR has appropriate labels and milestones for easy identification
[x] PR it is assigned to the owner
[x] reviewers are assigned
[x] the PR contributes only one focused change
[x] It is in the appropriate column in the project board (if necessary)
[x] has short and clear description
[x] is linked to an issue (if it is related)
[x] feedback is addressed (if any and if it is appropriate feedback.)

Markdown

[x] the markdown source is formatted
[x] spelling and grammar is correct in all text
[x] The markdown looks correct when you preview the file
[x] all links and images work
[x] any embedded code snippets are formatted

@bermarte  Thank you for checking my pull request.
I changed the name of the md file to "hitomipupil" and tried to push it from my local to main but it doesn't appear. Is there any issue in the command on terminal?


UpdateNaturalFrequencyPropsRequest API

🔍 Before submitting the issue

[x] I have searched among the existing issues
[x] I am using a Python virtual environment

🐞 Description of the bug
Dear Team,
I found a bug when updating Natural Frequency Analysis Properties.
UpdateNaturalFrequencyPropsRequest API accepts "float" in SherlockAnalysisService_pb2.pyi

It results in Float number when updating Natural Frequency Properties.

Best regards,
Kim
📝 Steps to reproduce
sherlock = launch_sherlock(port = 9090)
sherlock.analysis.update_natural_frequency_props(
project=project_name,
cca_name=pcb_name,
natural_freq_count=6,
natural_freq_min=20,
natural_freq_min_units="HZ",
natural_freq_max=2000,
natural_freq_max_units="HZ",
part_validation_enabled=False,
require_material_assignment_enabled= False,
analysis_temp=22.0,
analysis_temp_units="C"
)
💻 Which operating system are you using?
Windows
📀 Which ANSYS version are you using?
2024R2
🐍 Which Python version are you using?
3.12
📦 Installed packages
annotated-types==0.7.0
ansys-api-sherlock==0.1.35
ansys-sherlock-core==0.8.1
greenlet==3.1.1
grpcio==1.67.1
grpcio-tools==1.67.1
jproperties==2.1.2
numpy==2.1.3
pandas==2.2.3
pika==1.3.2
protobuf==5.29.0
psycopg2==2.9.10
pydantic==2.10.2
pydantic_core==2.27.1
python-dateutil==2.9.0.post0
pytz==2024.2
PyYAML==6.0.2
setuptools==75.1.0
six==1.16.0
SQLAlchemy==2.0.36
typing_extensions==4.12.2
tzdata==2024.2
wheel==0.44.0

Hi again,
I have tried to change the naturalFreqMin and naturalFreqMax in UpdateNaturalFrequencyPropsRequest to "bulletin.int" but with no success.
Also, it is not possible to leave out any parameters in the function as you will get an "Analysis.update_natural_frequency_props() missing X required positional arguments:" error.
Best regards,
Kim


Invalid SPDX generated for flagger

Flagger uses sbom-action to produce spdx with release artifacts. However, the file is an invalid SPDX.
SPDX2.3 requires at least one SHA to be SHA1 for File.
However, the SBOM is missing SHA1 checksums for all files starting line 1835 -
"checksums": [
    {
     "algorithm": "SHA256",
     "checksumValue": "21fd7be6572c8892b02ff91926cf72f456e150c50b58e5f2bb534077bf455551"
    }

Steps to reproduce the issue:
Anything else we need to know?:
Environment:

Output of syft version:
From SBOM:  "Tool: syft-0.68.1"

OS (e.g: cat /etc/os-release or similar):

Hi @surendrapathak, the solution here should be the same as the previous ticket: https://github.com/anchore/syft/issues/1568#issuecomment-1429822797 -- if you set the environment variables @kzantow listed, you should see the checksums in the result.


Question - When is the next release going to be available?

I am not sure of best channel to ask this question hence raising an issue here. I noticed that some PRs are merged in last few days. When is the new release with merged PRs is going to be available?

We're reviewing and testing the latest merges, and a new release should be available next week.

Hi @schatekar, great question.  And this is a totally great place to ask.
I should be able to get this released over the weekend.  We just want to test a few things on OS X to make sure we are good.
Major props to @apolloclark and @cgotcu for knocking off some PRs and getting us to this release.


⚠ ClamAV has degraded performance

In 31c03e4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 464 ms

Resolved: ClamAV performance has improved in 7e03123.


WatchedCDXSource Enhancements

As per #219, this adds optional recursion and filename filtering to the WatchedCDXSource. The defaults are equivalent to:
<property name="source">
    <bean class="org.archive.wayback.resourceindex.WatchedCDXSource">
        <property name="recursive" value="false" />
        <property name="filters">
            <list>
                <value>^.+\.cdx$</value>
            </list>
        </property>
        <property name="path" value="/wayback/cdx-index/" />
    </bean>
</property>

I had to add a equals() method for the FlatFile class as it wasn't possible to easily delete a CDXIndex otherwise—they're now considered equivalent if both are of the FlatFile class and getPath() returns the same for both.

I think it would be good to have a commented example config added in the CDXCollection.xml file. Also, the default path should be ${wayback.basedir}/cdx-index/ and if ${wayback.basedir} is not available where defaults are set then it should be hard-coded to /tmp/openwayback/cdx-index/ which is the default in default wayback.xml where placeholders are set.

While the example in the Wiki should be changed to use ${wayback.basedir}/cdx-index/, I'm averse to adding more examples to the default config. files.
The current wayback.xml is an example of overly large config. file dominated by commented-out, unused sections; I'd much prefer that the documentation was accurate and, if our users are having genuine difficultly finding examples, easier to access.

Merged manually.


Implement Prism -> Sorbet translation for return

Motivation

Test plan

See included automated tests.

Sorry, I keep making my PRs against this repo by accident 🤦♂
Is there a way to change the default GH behaviour for this?


[BD-46] docs: added Leave Feedback link

Description
Issue: https://github.com/openedx/paragon/issues/2243
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

Thanks for the pull request, @PKulkoRaccoonGang!
When this pull request is ready, tag your edX technical lead.

@PKulkoRaccoonGang 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.

:tada: This PR is included in version 20.39.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 21.0.0-alpha.31 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


inletsctl create displays an incomplete delete command for Azure

When you run inletsctl create, it prints a command to run in order to delete the server again. The command generated for an Azure deployment is incomplete and will not run without additional parameters.
Expected Behaviour

Run the inletsctl delete command generated by inletsctl create
The inlets server is deleted.

Adding the subscription id succeeds:

$ inletsctl delete --provider azure --id "inlets-flamboyant-buck2|deployment-c1f95ea9-6957-4aca-be24-26274269e52d" --access-token-file az-sp.json --subscription-id $SUBSCRIPTION_ID
Using provider: azure
Deleting host: inlets-flamboyant-buck2|deployment-c1f95ea9-6957-4aca-be24-26274269e52d from azure

Possible Solution
Maybe including at least the --subscription-id in the generated command would be a good idea. Alternatively, the subscription ID is already in the access token file so if it's not specified from the command line it could just be read from there too.

Hi,
This seems like a reasonable improvement in user-experience. We'd be open to a pull request / contribution to inletsctl (which is an open source component).
Alex


python310Packages.flask-babel: 3.0.0 -> 3.0.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.flask-babel is: Adds i18n/l10n support to Flask applications
meta.homepage for python310Packages.flask-babel is: https://github.com/python-babel/flask-babel
meta.changelog for python310Packages.flask-babel is: https://github.com/python-babel/flask-babel/releases/tag/v3.0.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.0.1 with grep in /nix/store/zqg9vjlq9rz221zbmnddi9n7xpg1y1k8-python3.10-flask-babel-3.0.1
found 3.0.1 in filename of file in /nix/store/zqg9vjlq9rz221zbmnddi9n7xpg1y1k8-python3.10-flask-babel-3.0.1

Rebuild report (if merged into master) (click to expand)

18 total rebuild path(s)

18 package rebuild(s)

First fifty rebuilds by attrpath
apache-airflow
calibre-web
fava
octoprint
pgadmin4
privacyidea
python310Packages.apache-airflow
python310Packages.flask-appbuilder
python310Packages.flask-babel
python310Packages.flask-security-too
python310Packages.ihatemoney
python311Packages.apache-airflow
python311Packages.flask-appbuilder
python311Packages.flask-babel
python311Packages.flask-security-too
python311Packages.ihatemoney
searx
searxng

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zqg9vjlq9rz221zbmnddi9n7xpg1y1k8-python3.10-flask-babel-3.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.flask-babel https://github.com/r-ryantm/nixpkgs/archive/87b4173defe9e658149c9e1e0053ea6f37676963.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zqg9vjlq9rz221zbmnddi9n7xpg1y1k8-python3.10-flask-babel-3.0.1
ls -la /nix/store/zqg9vjlq9rz221zbmnddi9n7xpg1y1k8-python3.10-flask-babel-3.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

10 packages failed to build:

apache-airflow (python310Packages.apache-airflow)
calibre-web
fava
octoprint
privacyidea
python310Packages.flask-appbuilder
python310Packages.ihatemoney
python311Packages.apache-airflow
python311Packages.flask-appbuilder
python311Packages.ihatemoney

5 packages built:

python310Packages.flask-babel
python310Packages.flask-security-too
python311Packages.flask-babel
searx
searxng

Maintainer pings
cc @timokau @omasanori @7c6f434c @collares @matejc for testing.

Result of nixpkgs-review pr 214362 run on x86_64-linux 1

8 packages failed to build:

apache-airflow (python310Packages.apache-airflow)
octoprint
privacyidea
python310Packages.flask-appbuilder
python310Packages.ihatemoney
python311Packages.apache-airflow
python311Packages.flask-appbuilder
python311Packages.ihatemoney

7 packages built:

calibre-web
fava
python310Packages.flask-babel
python310Packages.flask-security-too
python311Packages.flask-babel
searx
searxng


Documentation on setting up web job with separate configurations for development and production

Hi, I cannot find any documentation on how to set up the web job with separate configurations for different development states. I tried to achieve this by reading separate json files into IConfigurationRoot and then putting this object into IConfigurationBuilder.AddConfiguration(). However, this will not read my connection strings from my appsettings.dev.json. So what happens in the AddConfiguration or the AddAzureStorage methods? How can I achieve this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2e9e1a8a-6284-a230-061e-7cb27258571a
Version Independent ID: 43390e30-04d6-6d4e-018e-21419dbb11e8
Content: Get started with the WebJobs SDK - Azure
Content Source: articles/app-service/webjobs-sdk-get-started.md
Service: app-service-web
GitHub Login: @ggailey777
Microsoft Alias: glenga

@anetschka Thanks for the feedback! We are currently investigating and will update you shortly.

Any news on this topic?

@anetschka Thank you for your question. We try to keep feedback on this repro related to the specific docs. Since this is an architecture/design question that goes beyond the scope of this doc, we kindly invite you to share it on MSDN or Stack Overflow.
Thank you for your understanding.


Add OSD repo to the manifest for the next developer iteration

Signed-off-by: Louis Chu<EMAIL_ADDRESS>Description
Add OSD repo to the manifest for the next developer iteration
Ref PR: https://github.com/opensearch-project/opensearch-build/pull/2459
Issues Resolved
https://github.com/opensearch-project/OpenSearch-Dashboards/issues/2308
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2597 (be35973) into main (4731b00) will increase coverage by 5.58%.
The diff coverage is n/a.

:exclamation: Current head be35973 differs from pull request most recent head a627132. Consider uploading reports for the commit a627132 to get more accurate results

@@              Coverage Diff              @@
##               main     #2597      +/-   ##
=============================================
+ Coverage     94.41%   100.00%   +5.58%
=============================================
  Files           219         6     -213
  Lines          4462       105    -4357
  Branches         29        19      -10
=============================================
- Hits           4213       105    -4108
+ Misses          243         0     -243
+ Partials          6         0       -6

Impacted Files
Coverage Δ

...flow/dependency_installer_opensearch_dashboards.py

src/test_workflow/test_kwargs.py

tests/jenkins/jobs/UploadIndexFile_Jenkinsfile

...rc/test_workflow/test_result/test_suite_results.py

src/paths/assemble_output_dir.py

src/git/git_commit.py

src/ci_workflow/ci_target.py

..._workflow/opensearch/build_artifact_check_maven.py

src/run_bwc_test.py

...bs/PrintArtifactDownloadUrlsForStaging_Jenkinsfile

... and 203 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Looks like DCO check is failing @noCharger

Hi @noCharger We have workflow that auto detects the version increment for core repos (OS and OSD). This is where is created the PR: https://github.com/opensearch-project/opensearch-build/pull/2599
Are you okay with going ahead with that one since this one has some checks failing?

Closing this in favor of #2599

Hi @noCharger We have workflow that auto detects the version increment for core repos (OS and OSD). This is where is created the PR: #2599 Are you okay with going ahead with that one since this one has some checks failing?

sure, thanks for the info!


Understand the Mechanism of the hand thumb oppose and proximal

We have 2 joints for the thumb oppose and thumb proximal. Also, we have two motors/axes for controlling them.
But we have one hall position sensor to retrieve the joint information.
Also, when we control the  thumb oppose, we see that the thumb proximal will move.
So, the question is how they are constrained to each other? What we are measuring with the hall sensor?
cc @pattacini  @xEnVrE @traversaro

Hi @kouroshD

We have 2 joints for the thumb oppose and thumb proximal

Reading the code, it comes out that the feedback of the thumb opposition is retrieved straight from the motor, lacking the readout from the joint, so we have no hall sensor here.
Differently, the first hall readout goes feeding the thumb proximal joint.

Also, when we control the thumb oppose, we see that the thumb proximal will move.

Yep, the design foresees a mechanical coupling between those two joints of the thumb. When you manually move one of the two, the other will start moving too. However, the FW at the low-level acts in such a way that the two joints appear to be decoupled, instead, from the SW standpoint.

Yep, the design foresees a mechanical coupling between those two joints of the thumb. When you manually move one of the two, the other will start moving too. However, the FW at the low-level operates in such a way that the two joints appear to be decoupled, instead, from the high-level SW standpoint.

I should say that in tests I have performed when the robot joints reaches its boundaries, the other joint moves as well, for example moving the thumb opposition close to its boundaries, causes the motion of thumb proximal.
@ale-git

the hall sensor gives us the position of the proximal joint.

I will test this on iCub04 and will confirm it. Because, when I was moving the joints using yarpmotorgui this is not what I have observed.

when I was moving the joints using yarpmotorgui this is not what I have observed.

Uhm, the yarpmotorgui doesn't allow you to see the low-level joint feedback but only the motors' readouts if I'm not mistaken.

the FW at the low-level operates in such a way that the two joints appear to be decoupled, instead, from the high-level SW standpoint.

Perhaps, @randaz81 can also give heads-up on this.

Uhm, the yarpmotorgui doesn't allow you to see the low-level joint feedback but only the motors' encoders readouts if I'm not mistaken.

What I meant was the fact that I was giving the motor ref commands through the yarpmotorgui and checking the values of the analog sensors bay reading the related port.

I am re-opening this issue to ask clarifications about some doubts that I have on the coupling between thumb opposition and thumb proximal.
Considering the firmware (at least the one that I think is used in iCubGenova01, should be this one) it is clear that these two are coupled as also @pattacini clarified in a previous comment.
In the past, we had issues while trying to take advantage of the iCub forward kinematics library resulting in situations like this

where basically the predicted configuration of the thumb (check the contour in red) is different from the actual one.
As clarified in previous comments, the iKinFwd library takes the feedback for the thumb opposition straight from the motor encoder. Thus, I would like to ask whether this "motor reading" is already taking into account the coupling or if this is just the position of one of the two motors that control the thumb opposition.
cc @kouroshD

Ok @xEnVrE 👍🏻
We can work on this in our next sprint PI05-sprint03-fix (i.e. >= 23 Nov).

Reading the code, it comes out that the feedback of the thumb opposition is retrieved straight from the motor, lacking the readout from the joint, so we have no hall sensor here.

After a very interesting journey in the iCub schematics it seems that there is an additional hall sensor for the thumb opposition actually.

Thanks @xEnVrE for the journey 😄
We'll have a look at it to understand from the ground up why we're not employing it, that is if it's a mistake or there's a reason.

Let me report here below what @xEnVrE and @randaz81 have just found out during their analysis:

The hall sensor of the thumb opposition is actually exposed to the high-level software, although not through the usual analog port but rather through the port /...[right|left]_arm/state:o. The forward kinematics lib makes use of it consistently.
The joint encoders are those used to close the control loop, actually.

Thus, the problem reported in https://github.com/robotology/QA/issues/431#issuecomment-726087161 might be due to either a malfunctioning encoder or it's needed to perform calibration again.

Thank you @pattacini for reporting this. I just wanted to add that our analysis is limited to CAN robots like iCubGenova01.

From a quick discussion, it turned out that ETH robots behave similarly.
Closing then, feel free to comment further if needed.


Descriptor 0x2901 "Characteristic User Description" is being read differently across platforms

Describe the bug
It seems that descriptor with UUID 0x2901 (00002901-0000-1000-8000-00805f9b34fb), also known as "Characteristic User Description", has special significance and is being read differently on Web, Android and iOS.
If we try to use readDescriptor on two descriptors with identical values, one of them having UUID 0x2901, and the other any other random UUID (e.g. 0x29f2), we'll see different byte lengths in the resulting ArrayBuffers.
To Reproduce
First, we need a peripheral which contains a service with a characteristic which has "Characteristic User Description" descriptor. Such peripheral can be simulated by using nRF Connect app for Android, or EFR Connect app for iOS. Here's the configuration of a simulated peripheral that can be loaded into nRF Connect app:
<server-configuration name="desc_test">
   <service name="service1" uuid="00001234-0000-1000-8000-00805f9b34fb">
      <characteristic name="characteristic1" uuid="00009999-0000-1000-8000-00805f9b34fb" value-string="hello">
         <descriptor uuid="00002901-0000-1000-8000-00805f9b34fb" value-string="abcdefgh">
            <permission name="READ"/>
         </descriptor>
         <descriptor name="descriptor2" uuid="000029f2-0000-1000-8000-00805f9b34fb" value-string="abcdefgh">
            <permission name="READ"/>
         </descriptor>
         <property name="READ"/>
         <property name="WRITE"/>
      </characteristic>
   </service>
</server-configuration>

There's just one service with id 00001234-0000-1000-8000-00805f9b34fb, characteristic 00009999-0000-1000-8000-00805f9b34fb and two descriptors:
00002901-0000-1000-8000-00805f9b34fb (also known as "Characteristic User Description")
and
000029f2-0000-1000-8000-00805f9b34fb which is a random custom descriptor I chose.
Both descriptors have the same value: string abcdefgh.
We can use the following piece of code to test how both of these descriptors are being read. The code requests the peripheral (simulated from nRF Connect app on some Android phone, for example), connects to it, then reads both descriptors from the single characteristic. The byte lengths of both readings should be 8 (the character length of string abcdefgh)
  const descriptorsTest = async () => {
    try {
      console.log("Running descriptorsTest");

      await BleClient.initialize({androidNeverForLocation: true});
      const peripheral = await BleClient.requestDevice({
        optionalServices: ["00001234-0000-1000-8000-00805f9b34fb"]
      });
      await BleClient.connect(
        peripheral.deviceId,
        (id) => console.log(`Device disconnected: ${id}`),
        {timeout: 15000}
      );

      // read the "Characteristic User Description" descriptor (0x2902)
      const characteristicUserDescriptionValue = await BleClient.readDescriptor(
        peripheral.deviceId,
        "00001234-0000-1000-8000-00805f9b34fb",
        "00009999-0000-1000-8000-00805f9b34fb",
        "00002901-0000-1000-8000-00805f9b34fb"
      );

      // read the other descriptor (0x29f2)
      const differentDescriptorValue = await BleClient.readDescriptor(
        peripheral.deviceId,
        "00001234-0000-1000-8000-00805f9b34fb",
        "00009999-0000-1000-8000-00805f9b34fb",
        "000029f2-0000-1000-8000-00805f9b34fb"
      );

      // the byte lengths of both results should be 8
      console.log(`0x2901 read result byte length: ${characteristicUserDescriptionValue.buffer.byteLength}`);
      console.log(`0x29f2 read result byte length: ${differentDescriptorValue.buffer.byteLength}`);

    } catch (error) {
      console.log("Error!");
      console.log(error);
    }
  }

When we run this code on Web platform (Chrome on MacOS), we see this in console output:
0x2901 read result byte length: 8
0x29f2 read result byte length: 8

On Android, we see this:
0x2901 read result byte length: 9
0x29f2 read result byte length: 8

Which means the value of descriptor 0x2901 now contains one extra character at the end.
On iOS, the result is the weirdest:
0x2901 read result byte length: 1
0x29f2 read result byte length: 8

But BluetoothLe logs in XCode give us a hint about what's happening here:
⚡  BluetoothLe - Resolve readDescriptor|00001234-0000-1000-8000-00805F9B34FB|00009999-0000-1000-8000-00805F9B34FB|00002901-0000-1000-8000-00805F9B34FB abcdefgh
⚡  TO JS {"value":"abcdefgh"}
⚡  BluetoothLe - Resolve readDescriptor|00001234-0000-1000-8000-00805F9B34FB|00009999-0000-1000-8000-00805F9B34FB|000029F2-0000-1000-8000-00805F9B34FB 61 62 63 64 65 66 67 68
⚡  TO JS {"value":"61 62 63 64 65 66 67 68 "}

It seems the descriptor 0x2901 is being directly translated to the UTF8 string (by the platform?), and my assumption is that bluetooth-le plugin isn't expecting this. Unfortunately, I'm not knowledgeable in native iOS code, so please take that with a grain of salt.
Expected behavior
The result of using readDescriptor() on a descriptor with UUID 0x2901 should be the same on all platforms (in this case, 8 bytes).
Plugin version:

@capacitor-community/bluetooth-le: 2.2.0

Desktop

OS: MacOS Ventura 13.2.1
Browser: Chrome
Version: 111.0.5563.146

Smartphone

iOS device: iPhone7, iOS 15.4.1
Android device: Xiaomi Redmi Note 8 Pro, MIUI Global 12.5.7. (Android 11)

Additional context
The question arises - are there any other descriptors which have special significance and are being read differently across platforms?

Thank you for reporting this.
You are right, iOS treats the 0x2901 descriptor specially and returns directly a UTF8 string, which the plugin didn't handle correctly. This is fixed in 2.2.1.
However, I'm not able to reproduce the Android behavior you're describing. In version 2.2.1 I'm now getting the same value on all platforms.
Can you check what the values of the 9 bytes are that you are getting on Android compared to the other platforms?

The question arises - are there any other descriptors which have special significance and are being read differently across platforms?

According to the Assigned Numbers document, these are the descriptors with special significance:
0x2900 Characteristic Extended Properties
0x2901 Characteristic User Description
0x2902 Client Characteristic Configuration
0x2903 Server Characteristic Configuration
0x2904 Characteristic Presentation Format
0x2905 Characteristic Aggregate Format
0x2906 Valid Range
0x2907 External Report Reference
0x2908 Report Reference
0x2909 Number of Digitals
0x290A Value Trigger Setting
0x290B Environmental Sensing Configuration
0x290C Environmental Sensing Measurement
0x290D Environmental Sensing Trigger Setting
0x290E Time Trigger Setting
0x290F Complete BREDR Transport Block Data

If any other of them directly return a string on iOS, this should already be handled correctly now, but I haven't tested all of them.

Thank you so much for dealing with this so quickly @pwespi ! I just tried 2.2.1 and can confirm the iOS problem is fixed for 0x2901 descriptor. I haven't tried other descriptors yet.
As for Android problem - now, I have to admit, I have to test Android devices differently, because I have only one Android device. Therefore, when I want to read descriptors from my Android device, I can't use nRF Connect app on the same device as a peripheral simulator.
So I'm using EFR Connect on my iPhone, where I manually created the same simulated peripheral with two descriptors, and I read those from Android phone and from Web. When I do that, I still see that resulting buffer's byte length for 0x2901 is 8 on Web and 9 on Android.
The last byte seems to simply be 00 (screenshot from console from chrome inspect connected to Android device):

But reading the same descriptor on the Web looks like this:

But maybe there's something I don't understand - if you have some other suggestions I could test or try, I'm happy to help! Otherwise, for my purposes, I consider this bug to be fixed, so thank you for that!

As the iOS part is fixed and I cannot reproduce the Android problem, I will close this issue for now. If it cases any more problems, let me know and I can take another look.


Correct requirements pathing

why need to specify branch?

Oh thats not a branch. Because we're working with the repo and plugin I have them seperated. This repo is checked out to main and the plugin release is added to plugin.

oh I get you

Actually we don't even need to do that. It's faster and easier to checkout to the current working directory and have the plugin in a sub folder.

yes no need to do so

Possible to force?

@jjw24

Possible to force?

@Garulf sorry what do you mean?

hold on wait him add the fix for the unrun test.

Possible to force?

@Garulf sorry what do you mean?

PR wont merge because it can't pass test-python workflow (which should only trigger if plugins.json is changed in the PR).

Possible to force?

@Garulf sorry what do you mean?

PR wont merge because it can't pass test-python workflow (which should only trigger if plugins.json is changed in the PR).

Fix that here

I got it. One moment.

Looks like it's running correctly.


[Python Debugger]:Keeping Logpoints working when no breakpoint is active.

Hi there,
In my experience, when debugging my python code, the Log-point only works when there be at least one active break-point set in the editor, otherwise becomes inactive/suppressed (provide no output message).
It would be nice to still receive Log messages when debugging code, to inform of the code behavior even if there were no active break-point set.
P.S
Based on the VSCode documentation, Log-points supposed to replace temp print() lines in the code to help keeping it clean, which is nice, but in the above mentioned situation, developers still have to use those print() lines to get insights!
Regards

/extPython


Ensure char is valid

Fixes an error which could occur if an input's state was set to active without user interaction

thanks!


Schem is not out for 1.12

I know this is not a bug or anything but this is an issue for my faction cause our server is resetting soon and we really need schem for 1.12 cause all our ship ideas is on schem

This does not belong on a bug tracker. It will be released when it's done.

World edit is functional with 1.12. You can save/paste schematics with world edit, if that's the functionality that you require.

It's not, schematica does not use or require WorldEdit. That being said,
asking if that's the required functionality implies that Lunatrius would
copy someone else's code. Just, no. Also, poor taste to tell the Dev that
their mod should work because this other one does, without understanding
the first thing about the program. Further bad taste to do so in a closed
bug's comment section.
Sent from my Galaxy S7
On Jun 27, 2017 5:53 AM, "MrDrummer"<EMAIL_ADDRESS>wrote:

World edit is functional with 1.12. You can save/paste schematics with
world edit, if that's the functionality that you require.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Lunatrius/Schematica/issues/225#issuecomment-311323831,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APH7E0m_EGuIQSxtw_12lwJJLRWC7VHWks5sIN87gaJpZM4N9Nye
.

I doubt the OPs server is going to allow that, to be honest. I can suggest downloading your portion of the world with a tool that saves chunks from a server as an offline world, so that you can later use schematica on them for rebuilding though?

We have used schematics with worldedit our own creative server but we are gonna need it for survival
Skickat från min Samsung Galaxy-smartphone.
-------- Originalmeddelande --------Från: MrDrummer<EMAIL_ADDRESS>Datum: 2017-06-27  12:53  (GMT+01:00) Till: Lunatrius/Schematica<EMAIL_ADDRESS>Kopia: Elias040319<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Rubrik: Re: [Lunatrius/Schematica] Schem is not out for 1.12 (#225)
World edit is functional with 1.12. You can save/paste schematics with world edit, if that's the functionality that you require.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Lunatrius/Schematica","title":"Lunatrius/Schematica","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/Lunatrius/Schematica"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MrDrummer in #225: World edit is functional with 1.12. You can save/paste schematics with world edit, if that's the functionality that you require."}],"action":{"name":"View Issue","url":"https://github.com/Lunatrius/Schematica/issues/225#issuecomment-311323831"}}}

Im sorry if i offended you but for the first english isnt my first language so i dont understand english to a 100% and for the second i had never used that website so i didnt really know where to post and for the third i dont know anything about programming or coding
Skickat från min Samsung Galaxy-smartphone.
-------- Originalmeddelande --------Från: PhoenixCodes<EMAIL_ADDRESS>Datum: 2017-06-27  14:35  (GMT+01:00) Till: Lunatrius/Schematica<EMAIL_ADDRESS>Kopia: Elias040319<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Rubrik: Re: [Lunatrius/Schematica] Schem is not out for 1.12 (#225)
It's not, schematica does not use or require WorldEdit. That being said,
asking if that's the required functionality implies that Lunatrius would
copy someone else's code. Just, no. Also, poor taste to tell the Dev that
their mod should work because this other one does, without understanding
the first thing about the program. Further bad taste to do so in a closed
bug's comment section.
Sent from my Galaxy S7
On Jun 27, 2017 5:53 AM, "MrDrummer"<EMAIL_ADDRESS>wrote:

World edit is functional with 1.12. You can save/paste schematics with

world edit, if that's the functionality that you require.

—

You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub

https://github.com/Lunatrius/Schematica/issues/225#issuecomment-311323831,

or mute the thread

https://github.com/notifications/unsubscribe-auth/APH7E0m_EGuIQSxtw_12lwJJLRWC7VHWks5sIN87gaJpZM4N9Nye

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Lunatrius/Schematica","title":"Lunatrius/Schematica","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/Lunatrius/Schematica"}},"updates":{"snippets":[{"icon":"PERSON","message":"@PhoenixCodes in #225: It's not, schematica does not use or require WorldEdit. That being said,\nasking if that's the required functionality implies that Lunatrius would\ncopy someone else's code. Just, no. Also, poor taste to tell the Dev that\ntheir mod should work because this other one does, without understanding\nthe first thing about the program. Further bad taste to do so in a closed\nbug's comment section.\n\nSent from my Galaxy S7\n\nOn Jun 27, 2017 5:53 AM, "MrDrummer"<EMAIL_ADDRESS>wrote:\n\n\u003e World edit is functional with 1.12. You can save/paste schematics with\n\u003e world edit, if that's the functionality that you require.\n\u003e\n\u003e —\n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/Lunatrius/Schematica/issues/225#issuecomment-311323831\u003e,\n\u003e or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/APH7E0m_EGuIQSxtw_12lwJJLRWC7VHWks5sIN87gaJpZM4N9Nye\u003e\n\u003e .\n\u003e\n"}],"action":{"name":"View Issue","url":"https://github.com/Lunatrius/Schematica/issues/225#issuecomment-311344758"}}}


Language detect order

This allows detection of language via querystring or cookies before header is checked. Previously, if a lang header was sent, cookies and query string would be ignored.

Can you bump the minor version and release a new version?


Possible to flash someone elses HT_FLASH?

I didn't know that the HT_FLASH folder contained the whole backup of the HooToo device and it seems that over the years at some point I've overwritten said stick already... Is there any way to use someone elses HT_FLASH backup on my own device? Is the MAC hardcoded into the backup? If not, if someone reads this issue who still has a backup, could you send it my way?
Thanks in advance!

This isn't solved?


[Feature][Docs] Enhance Python Calculator Script

Changes Made

Added Mathematical functions from Math Module.
Added docstrings for clarity.

Context
The Python Calculator looked unprofessional with basic operations and no documentation. It has been updated with new features and documented well.
Checklist

[x] Documentation is updated.
[x] Code follows project coding standards.
[x] No linting errors.

I like it, merging it.


PointLight Feedback

Can not access Visibility property of the Point Light Object. Also, the API reference page only has four properties (hasNaturalFalloff, falloffExponent, sourceRadius, sourceLength). But I can access Visibility and other advanced options in the editor.

That is because PointLight inherits from CoreObject that has these properties.


Update to PR 4852 ({{navigation}} helper)

This is a small update / cleanup on top of PR #4852, to fix the tests and the output notes by @JohnONolan
Note: I have cleaned up the space around the nav-current class, but I wasn't certain if there was some other issue with it not working? I tested it out on various page types, both with and without a subdirectory, and here is the result:

If there's a case I've missed please let me know :)

@ErisDS Does nav-current work on the homepage? That's where it was not working for me

Watches gif properly - ok I see it works on the homepage there - it didn't on mine previously. :+1: looking good

Yeah, the thing is it appeared to work for me anyway, so it might be worth you taking this for a spin as I'm concerned I missed something.

Tested - works for me now


Carousel:Transition bug

Instructions
On https://design-system.pluralsight.com/components/carousel#carousel the second carousel has a blip behavior when transitions. We see the same problem on our home page carousels after upgrading
The first carousel does not exhibit this behavior (only the one under the Using Portals section)
Bug
Expected behavior
Actual behavior
Screenshots/casts are helpful
https://user-images.githubusercontent.com/10716479/103587469-8c470600-4ea4-11eb-9eb8-e6f3d1cb72ed.mp4
Related packages

<EMAIL_ADDRESS>
Environment

OS - MacOS 10.12
Browser version - Chrome v60

By "blip", I'm observing that on the backside of the animation direction, when paging, the last carousel item will prematurely disappear.
If I remove the Toggle, blip still there.

By "blip", I'm observing that on the backside of the animation direction, when paging, the last carousel item will prematurely disappear.
If I remove the Toggle, blip still there.

After investigating this a week ago, I'm not sure where to go with it.  @EdwardIrby or @danethurber , any ideas?

After investigating this a week ago, I'm not sure where to go with it.  @EdwardIrby or @danethurber , any ideas?

i'd have to dig in. initially i handled the transition states with a TransitionGroup but that maybe have stopped working throughout our refactoring

i'd have to dig in. initially i handled the transition states with a TransitionGroup but that maybe have stopped working throughout our refactoring