Why " j < i " not " j < size_ " ?

Don’t all bases need to be judged in pairs ? (ignore my poor english)

Thanks for pointing this out. This is indeed a bug and skipped unit testing. Luckily this method is not currently used in SEAL library. It is fixed now and will be released soon. Please use RNSBase::extend(Modulus value) for now.


Using sample code causes "Uncaught TypeError: Cannot read property 'appendChild' of null" exceptions

Hi,
It appears an update to JSuites possibly broke JExcel. When I try to paste this sample code below from the last release ZIP (3.5.0) into a HTML file and open it, I get two exceptions as of today, in the latest Chrome:
Uncaught TypeError: Cannot read property 'appendChild' of null
    at jsuites.js:5738
    at jsuites.js:5937
    at jsuites.js:15
    at jsuites.js:19

And
Uncaught TypeError: Cannot read property 'contextmenu' of undefined
    at Object.obj.createTable (jexcel.js:470)
    at Object.obj.prepareTable (jexcel.js:343)
    at Object.obj.init (jexcel.js:5768)
    at jexcel (jexcel.js:5981)
    at example.html:16

Code:
I updated the first script include so both pull the CDN versions.

<link rel="stylesheet" href="https://bossanova.uk/jexcel/v3/jexcel.css" type="text/css" />

<link rel="stylesheet" href="https://bossanova.uk/jsuites/v2/jsuites.css" type="text/css" />

Could you take a look and see what is going on?

This has been already fixed. Can you please download jSuites again? Thanks

Looks good now, thanks.

×
TypeError: Cannot read properties of undefined (reading 'contextmenu')
obj.createTable
https://bossanova.uk/jspreadsheet/v4/jexcel.js:6560:21
obj.prepareTable
https://bossanova.uk/jspreadsheet/v4/jexcel.js:6395:21
obj.init
https://bossanova.uk/jspreadsheet/v4/jexcel.js:12903:21
jexcel
https://bossanova.uk/jspreadsheet/v4/jexcel.js:13183:13
(anonymous function)
F:/ms-admin/src/pages/AverageRecruitManager/ProjectManager/components/DetailsPage/components/ListSpreadsheet/index.jsx:176
173 | const spreadsheet = document.getElementById('spreadsheet');
174 | console.log(spreadsheet);
175 | // console.log(window.jspreadsheet(spreadsheet, {}));

176 | window.jspreadsheet(spreadsheet, {
177 |     data: data,
178 |     columns: [
179 |         { type: 'text', title: 'Car', width: 120 },
View compiled
▶ 16 stack frames were collapsed.

Why do I have this problem?

TypeError: Cannot read properties of undefined (reading 'contextmenu')
obj.createTable
https://bossanova.uk/jspreadsheet/v4/jexcel.js:6560:21
obj.prepareTable
https://bossanova.uk/jspreadsheet/v4/jexcel.js:6395:21
obj.init
https://bossanova.uk/jspreadsheet/v4/jexcel.js:12903:21
jexcel
https://bossanova.uk/jspreadsheet/v4/jexcel.js:13183:13
const spreadsheet = document.getElementById('spreadsheet');
174 | console.log(spreadsheet);
175 | // console.log(window.jspreadsheet(spreadsheet, {}));

176 | window.jspreadsheet(spreadsheet, {
177 |     data: data,
178 |     columns: [
179 |         { type: 'text', title: 'Car', width: 120 },

https://jsuites.net/v4/jsuites.js
I think the certificate has expired. I'll just force access；

The certificate is updated. But, please upgrade to a CDN. It will be much faster.
<EMAIL_ADDRESS><EMAIL_ADDRESS>

All right. Thank you very much.


zng.Marshal: support marshaling to time

I'm not sure this if this is best approach for marshaling/unmarshaling fields with nano.Ts. Yet the problem remains.

What we should probably do in the long run is have pkg/nano implement the resolver.(Un)Marshaler interface (this is what the go std does with Time and json). The problem with this is that nano.Ts is in pkg which means it shouldn't be dependent on anything outside it. Additionally I think package zng/resolver has nano as a dependency. There's some untangling to do here.

What we should probably do in the long run is have pkg/nano implement the resolver.(Un)Marshaler interface (this is what the go std does with Time and json). The problem with this is that nano.Ts is in pkg which means it shouldn't be dependent on anything outside it. Additionally I think package zng/resolver has nano as a dependency. There's some untangling to do here.

I agree we need to untangle. I think this PR is currently the best way to get the marshal support in. I think we should remove nano.Ts as a dependency of the zng & zng/resolver packages.


Availability feature

This is a feature request.
Has anyone thought of implementing an Availability feature in Algolia somehow. Lets say if your "room" was booked next week, and I add a search time, I would filter that room out.
Any thoughts or ideas how something like this could be done? My mind is going to an parse-able availability string, and then some sort of custom ranking.
Thanks!

You could have a record structure like this:
{
  "available": [
    { "from": 123123, "to": 123124 },
    { "from": 123125, "to": 123126 }
  ]
}

Then you can use the filters attribute (not in instantsearch.js, but in the js client) to filter based on a period between those.
This is obviously a quite complicated feature, so we might want to implement this in instantsearch if there's a lot of request for it.
Let me know if you need more than an overview

Awesome @Haroenv.
Could you show me a rough logic example of that filter query based on something similar?
As my time would be from-to and comparing that with algolia might be difficult.
{   "not-available": [     { "from": 123123, "to": 123124 },     { "from": 123125, "to": 123126 }   ] }
my request "are you not available"
from: 123127 to 123129

oh you're right @jaarkko, it's more complicated than it first seemed, I'd need to sync with someone on this.

This is more on the engine side of sides that this could be solved, and it's not high in the list. There is a way but it requires to compute combinations of possible bookings as different records, this could have a huge impact on the number of records in your index.

Just popping up and asking if anyone has any ideas on this, ping here. Would help a lot of people!

@jaarkko Can you go through support to ask about that? There are some solutions but there are no one-size-fits-all kinda solution. If you go through support and mention that you want to implement a booking mechanism then we can start talking about a solution tailored for your use case.


Router Not Found

I use the laravel 5 and mongodb. But suddenly the router not found. that could show up only on the public page. In addition to the public as public page/login, public/etc can not be used. What's the problem?

If you have routing issues, this package can't be the source of the problem.
Anyway, we can't help you with so few informations about your problem and your existing configuration.


request: allow other kernels

I see now that request #14 to add regression testing won't be useful (for me) until runipy could work with external kernels. What would be the bare minimum needed for runipy to work with an external kernel? I guess you'd need to open the sockets, generate a connection_file, and then fire up the kernel in a process (there is probably an easy way to do that from the IPython codebase). Then I guess you could talk to the kernel the same way as runipy works currently. Then send it a shutdown_request when done. Maybe not too bad...

So, this could be doable. In particular, I would expose this as a constructor argument for NotebookRunner.
However, there is a bit of a trick. In iPython 2.x, there is kernel_cmd, which is the command to be run to start the kernel and provide it a connection file provided via a list. In iPython 3.x and 4.x (not 2.x), there is still kernel_cmd, but it is deprecated and kernel_name is preferred, which takes the name of a kernel as some sort of str. I expect kernel_cmd won't survive to iPython 5.x, but I could be surprised.
Here are the options:

Expose both kernel_cmd and kernel_name directly.

Simplest solution. Works on all version of iPython currently supported.
Will eventually need to break API and remove kernel_cmd, which breaks iPython 2.x support.

Expose kernel_name directly and construct kernel_cmd for iPython 2.x.

Avoids having to break the API later.
Explicit about what it represents.
May run into weird commands used for iPython 2.x that we can't easily be reproduced.

Expose something like kernel, which is interpreted as kernel_cmd or kernel_name.

Avoids having to explicitly break the API later.
Works on all iPythons.
Avoids weird command construction.
Eventually, will need to break interpretation of argument as kernel_cmd at some future point, which could be thought of as breaking the API.

Drop iPython 2.x support and add kernel_name. Thinking of this ( https://github.com/paulgb/runipy/issues/78 ).

Avoids breaking the API.
Explicit about what it is.
No weird conversions or interpretations.
Breaks version compatibility.

Personally, 3 doesn't sound so bad to me for now. Thoughts?

Are there lots of installations still with 2.x running out there? /me votes for 4


Syntax fixes

@nvkelso is this in line with your intent for these rules?

@blair1618 When I try this in Tangram Play it crashes. When I try it locally I get:
Unhandled promise rejection Expected () to start arrow function, but got ')' instead of '=>': SyntaxError: Expected () to start arrow function, but got ')' instead of '=>'

And some other debug:
 at Function (native)
    at Object.b [as match] (https://mapzen.com/tangram/0.4/tangram.min.js:8:7564)
    at t.m.value (https://mapzen.com/tangram/0.4/tangram.min.js:14:304)
    at t.e (https://mapzen.com/tangram/0.4/tangram.min.js:14:107)
    at new t (https://mapzen.com/tangram/0.4/tangram.min.js:14:862)
    at f (https://mapzen.com/tangram/0.4/tangram.min.js:13:30309)
    at Object.h [as parseRules] (https://mapzen.com/tangram/0.4/tangram.min.js:13:30529)
    at c.default.isWorkerThread.i.updateConfig (https://mapzen.com/tangram/0.4/tangram.min.js:12:21933)
    at DedicatedWorkerGlobalScope.<anonymous> (https://mapzen.com/tangram/0.4/tangram.min.js:16:10817)

@nvkelso @blair1618 looking into it...

OK, the issue appears to be a spectacular mis-parsing of this line: https://github.com/tangrams/eraser-map/pull/80/files#diff-939bb555547386cbe68c2ce87237df85R2213
Last line of:
    address-labels:
        data: { source: osm, layer: buildings }
        filter:
            all:
                - $zoom: { min: 20 }
                - kind: address
                - [addr_housenumber: true, name: false]

This, [addr_housenumber: true, name: false], is not valid in that context. The all filter is trying match each of the following items of the array (denoted in YAML with a -) as a filter. A bare array is not a valid filter object; arrays are used to match a property to multiple values (kind: [restaurant, shop]), or to list multiple filter objects for the all, any, or none keywords to match against.
Clearly more input validation is needed on the Tangram, side here, so the filter is rejected gracefully with an error message, and the rest of the scene is parsed.
In the meantime, can we clarify the intent for when address labels are applied? Is it at zoom 20, when either kind is address, or addr_housenumber is not null but name is null? If so, that would be most concisely expressed as:
filter:
   $zoom: { min: 20 }
   any:
      - kind: address
      - { kind: true, addr_housenumber: true, name: false }

The doc page on filters made me believe that an array is a valid filter object (this part). Am I misreading it? Should the docs be changed?

Eh, that appears to be incorrect :/  I can't find any code that would have
behaved that way (though I vaguely recall discussing that idea).
What do we do in ES? We can clarify docs, and/or bring JS into line if ES
supports this.
On Wed, Nov 11, 2015 at 9:05 PM, Matt Blair<EMAIL_ADDRESS>wrote:

The doc page on filters made me believe that an array is a valid filter
object (this part
https://github.com/tangrams/tangram-docs/blob/gh-pages/pages/Filters-Overview.md#lists-imply-any-mappings-imply-all).
Am I misreading it? Should the docs be changed?
—
Reply to this email directly or view it on GitHub
https://github.com/tangrams/eraser-map/pull/80#issuecomment-155973808.

I see! ES does accept this as a filter (which is why I thought it was valid, oops), it just arose naturally when we implemented filter parsing recursively. Allowing this seems consistent with the logic of filter structures.

I agree, implicit any there does make sense. I will amend JS (and add better validation in general).

Will update here when fixed.

Interesting, As Matt mentioned, we are handing an array in filter as a any on all elements of the array, which is precisely what is documented, and also make sense to me.

Just saw your comment, Brett. :+1:

To be clear, you mean that when a filter object is an array, it is interpreted as if it is an any object, meaning:
[addr_housenumber: true, name: false]
is equivalent to:
{ any: [addr_housenumber: true, name: false] }
Correct? I think the only reason we didn't do this (I remember discussing it) was potential confusion over the subtly of {} vs.[] having very different behavior. But I also think it makes sense (especially with implicit all already) and will update in JS.

Yup, when a filter object is an array it will be interpreted as any operator, and when a filter object is a map, it will be interpreted as all operator.

Should be resolved in: https://github.com/tangrams/tangram/commit/6a785eae0f83c3e4bee6775834179ad7c56c02a6
Will confirm once Tangram 0.4.1 is released.

Awesome!
In the meantime, I've revised the filter to use @bcamper 's suggestion. @nvkelso does this look good to you?

Tangram 0.4.1 is out, this branch loads OK:
https://tangrams.github.io/tangram-play/?scene=https://raw.githubusercontent.com/tangrams/eraser-map/syntax-fixes/eraser-map.yaml


Add Vietnamese translation. Thêm bản dịch Việt.

Thank you very much for this tool!!
I will update the translation if there is any new item.

Thank you for the translation. I will make a new release soon.


Regular Kubeflow argument handling

Updates it to match how other addons handle arguments, instead of environment variables. Keeps the environment variables around for now.

Where are we going to document these arguments? Should we create a page for the kubeflow addon to mention the arguments? https://microk8s.io/docs/addons#heading--list

@ktsakalozos: Sure, how do I go about creating that page?


feat: bump kotlin version

Kotlin 1.6.0 was released today.

@cla-bot check

Hi @koraykoska Thanks for the PR. I think upgrading to 1.6 will break the compiler plugin that needs to be updated as well, we'll look at this soon.
'compileDebugJavaWithJavac' task (current target is 1.7) and 'compileDebugKotlinAndroid' task (current target is 1.8) jvm target compatibility should be set to the same Java version.
e: java.lang.NoSuchMethodError: org.jetbrains.kotlin.backend.common.extensions.IrPluginContext.getIrBuiltIns()Lorg/jetbrains/kotlin/ir/descriptors/IrBuiltIns;
        at io.realm.compiler.RealmModelSyntheticPropertiesGeneration.irNull(RealmModelSyntheticPropertiesGeneration.kt:596)
        at io.realm.compiler.RealmModelSyntheticPropertiesGeneration.access$irNull(RealmModelSyntheticPropertiesGeneration.kt:100)
        at io.realm.compiler.RealmModelSyntheticPropertiesGeneration$addProperties$1$1.invoke(RealmModelSyntheticPropertiesGeneration.kt:137)
        at io.realm.compiler.RealmModelSyntheticPropertiesGeneration$addProperties$1$1.invoke(RealmModelSyntheticPropertiesGeneration.kt:137)
        at io.realm.compiler.RealmModelSyntheticPropertiesGeneration.addVariableProperty(RealmModelSyntheticPropertiesGeneration.kt:521)
        at io.realm.compiler.RealmModelSyntheticPropertiesGeneration.addProperties(RealmModelSyntheticPropertiesGeneration.kt:137)
        at io.realm.compiler.RealmModelLowering.lower(RealmModelLoweringExtension.kt:65)

Support for 1.6.0 was merged in #556


[Preview] Full Fidelity Change Feed: Adds new LatestVersion and AllVersionsAndDeletes to ChangeFeedMode

Pull Request Template
Description
Based on issue 3588, renaming FullFidelity to AllVersionsAndDeletes and adding LatestVersions that has the same behavior as Incremental on ChangeFeedMode. This is to make the names more intentional and makes more sense to the customer from a business perspective.
What this does not include are members like FullFidelityRetention and FullFidelityNoRetention on ChangeFeedPolicy and other deeper internal types like ChangeFeedModeFullFidelity and ChangeFeedModeIncremental. I want to practice making smaller, incremental changes moving forward.
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Closing issues
To automatically close an issue: closes #IssueNumber

Preview ChangeLog needs to explicitly about breaking change aspect
Also how about capture the changelogs part of PR it-self?
@ealsur , @philipthomas-MSFT thoughts?

Preview ChangeLog needs to explicitly about breaking change aspect
Also how about capture the changelogs part of PR it-self? @ealsur , @philipthomas-MSFT thoughts?

Our process is to generate the changelog at the moment of the release. We have been doing that for quite a long time.
I guess we can certainly switch to doing it as part of the PR, if we choose to do it now, then our next release will still need to manually go through the commits and add the missing ones.
At some point we wanted to have an automatic process to use the commit messages to autogenerate it.
This PR is not introducing a breaking change though.


Made extensive changes

Replaced all copy

I'm fixing this upstream and I'll add a commit to the PR, so don't merge just yet.


Dynamic.DynamicIndex is exposed in the expression

After upgrading from 1.1.8 to 1.2.0 I'm getting MethodNotSupported exception because my expression parser finds Dynamic.DynamicIndex(object, string) method in the expression. Strangely this method was introduced in 1.1.8, but the error started happening only in 1.2.0
Here are the failing tests: https://ci.appveyor.com/project/hazzik/nhibernate-core/builds/35962348/job/uvi4bg3jew1giw41/tests

Hello @hazzik, thanks for reporting.
I'll take a look.

Hello @hazzik, thanks for reporting.
I'll take a look.

@hazzik
Can you provide a full source code example which displays this error?

@hazzik
Can you provide a full source code example which displays this error?

This is the simplest reproduction: https://dotnetfiddle.net/8Az1F6
It outputs
Product[].Where(Param_0 => (DynamicIndex(Param_0.Properties, "Name") == Convert("First Product", Object)))

And DynamicIndex method call is a problem here.

This is the simplest reproduction: https://dotnetfiddle.net/8Az1F6
It outputs
Product[].Where(Param_0 => (DynamicIndex(Param_0.Properties, "Name") == Convert("First Product", Object)))

And DynamicIndex method call is a problem here.

Hello @hazzik,
I think I found a possible fix for this issue, however I want to test this using NHibernate.
Can you please provide me with a minimal console-app which can reproduce this issue?

Hello @hazzik,
I think I found a possible fix for this issue, however I want to test this using NHibernate.
Can you please provide me with a minimal console-app which can reproduce this issue?

Dear @hazzik , can you please provide a minimal console-app to reproduce this issue?

Dear @hazzik , can you please provide a minimal console-app to reproduce this issue?

I'll do it on or by this weekend.

I'll do it on or by this weekend.

@StefH here is the console app with reproduction: https://github.com/hazzik/nhibernate-linq-dynamic

@hazzik Thank you very much, I'll copy this example to verify/reproduce the bug.

I'm working on a fix, but dynamic cannot be supported.
This is also not supported in normal code:

The code is reworked that this scenario can work:
class Product
	{
		public virtual Guid Id { get; set; }
		public virtual string Name { get; set; }
		public virtual IDictionary<string, object> Properties { get; set; }   // <--
	}

with:
var properties1 = new Dictionary<string, object>
{
	["Name"] = "First Product",
	["Description"] = "First Description"
};
session.Save(
	new Product
	{
		Id = Guid.NewGuid(),
		Properties = properties1
	});

//var properties2 = new
//{
//	Name = "Second Product",
//	Description = "Second Description"
//};
//session.Save(
//	new Product
//	{
//		Id = Guid.NewGuid(),
//		Properties = properties2
//	});

dynamic properties3 = new ExpandoObject();
properties3.Name = "Third Product";
properties3.Description = "Third Description";
session.Save(
	new Product
	{
		Id = Guid.NewGuid(),
		Properties = properties3
	});

And this works:
var x = session.Query<Product>().Where(p => p.Properties["Name"] == "First Product").ToList();

				var y = session.Query<Product>()
					.Where("Properties.Name == @0", "First Product")
					.ToList();

I'm working on a fix, but dynamic cannot be supported.

This code was working fine in 1.1.8. I know that dynamic expressions are supported in the linq-tree, but not supported on a language level. To properly support them it would probably be required to depend on Microsoft.CSharp package.

@hazzik
I did test previous versions.
However it seems that 1.1.7 does work, and higher versions fail with:
Unhandled exception. System.NotSupportedException: System.Object DynamicIndex(System.Object, System.String)
Correct ?

Yes, that is correct. I might misremembered the working version due it is being long time since I've tested it myself.

Can you try
https://www.myget.org/feed/system-linq-dynamic-core/package/nuget/System.Linq.Dynamic.Core/1.2.8-preview-01

Hello @hazzik , did you have time to test this preview package?

Seems to be working:

https://ci.appveyor.com/project/nhibernate/nhibernate-core/builds/37695599
https://travis-ci.org/github/nhibernate/nhibernate-core/builds/758298116?utm_source=github_status&utm_medium=notification

Thanks

Hello @hazzik,
Thanks a lot for your analysis and help.
In some day(s) , I'll merge this PR and create a new official 1.2.8 NuGet package


List of people who taught at events of specific type

Usecase: Tracy wants to grab list of people who taught at DC workshops, so that she knows who is experienced DC instructor.

Filter the "Events" display by tag?

@gvwilson and you'll end up with list of events, not instructors.

@gvwilson and you'll end up with list of events, not instructors.

But we can get the instructors from those events, right?

@maneesha yes, but it requires you to open each workshop and look at the list of tasks.

Right - we'll probably need to filter people by award ("has instructor
badge") and then by properties of associated events.

@gvwilson right now it's possible to filter people by their badges on All Persons page. I'm going to add "filter by type of workshop where person taught", which is not the same - some people have 'instructor' task for event but are actually missing the badge.


facing some error during debugging and live server preview

Environment (please complete the following information):

OS (e.g., Windows 10):
Extension version (e.g., 1.2.3):

Describe the bug:

Repro steps:

Expected behavior:

Additional context:

Closing as incomplete. Please feel free to add more information if you have any and we can re-open the issue.


Add support for S3 compatible services

Would it be possible to add support for other S3 compatible services to upload the reports to? AWS-sdk supports it so it would only require to add support for endpoint directive (https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Endpoint.html) in to this module :)

Hi @iler - thanks for opening this. This project uses lighthouse-persist under the hood. Would you mind opening an issue in that project with the identical description? We'd still need to ensure this project supports it, so we can keep this open for a bit.
To answer your question - yes, although I'm not familiar with the endpoint directive, I'd say it is do-able. But, the main change would need to be made in lighthouse-persist. I'd invite a PR or wait for other interest and otherwise prioritize it accordingly.


fix docs workflow

Currently, I can't access the url at http://env-logger-rs.github.io/env_logger and I am not sure why, as this should be the URL that the gh-pages branch can be accessed from.

It works if you append /index.html manually: https://env-logger-rs.github.io/env_logger/index.html
Seems like this has been a problem for others before and it might just randomly fix itself after a few deployments: https://stackoverflow.com/questions/45362628/github-pages-site-not-detecting-index-html

Ahhhh! Thank you very much! I didn't think about adding the index file to it! Maybe the ci crate shouldn't be documented though :)

To only document env_logger itself, we can just use cargo doc -p env_logger.

Fixed!

To only document env_logger itself, we can just use cargo doc -p env_logger

Turns out I passed --workspace, which is in most of my libraries right but here wrong :)


Non integer chat ids are not working for tgcf live mode for source

Problem
Non-integer chat ids are not working for tgcf live mode
forwards:
  - source: aahnikdaw
    dest: [-1001198424910]

a configuration like this fails in live mode, although succeeds in past mode.
Probable reason
message handlers have something like this on top:
    if chat_id not in from_to:
        return

the chat_id is not in from_to as, from_to is now having the string username or other type of things.
Probable solution
some conversion should take place, and comparison must be done for same type
related docs https://docs.telethon.dev/en/latest/concepts/entities.html

non int chat ids, work fine in the dest. This problem is only in the source

v0.2.4 or above fixes this.


Feature Request: Add MODE as reset option

With the TerraOnion MODE release on the horizon, adding it to the reset options would be beneficial to end users.
The reset type is the same as the GDEMU reset. This means the change is mostly cosmetic but still beneficial for user experience.
A special pin was added on MODE specifically to allow easy connection to DCDigital via JST XH 9pin connector. This option is specifically just for controlling disc switching. The DCDigital standard system reset is already supported by MODE and returns to menu or reboots game depending on user options. If there are any questions, please let me know. I would be happy to help.

Ok, great!
So I will add a "MODE" option to the web console setup's "Opt. reset mode" setting.
The menu will then show:
Y: MODE disc switch
Correct?

Yes sir. That would be perfect. I didn't look at the code but I assume it's an enumeration addition. So hopefully very low complexity.

No worries, it's easy to add :)

Added in 135135b
This is currently on the develop branch, if you like to test :)

Yes absolutely. Thank you.

I loaded the develop branch and can see the changelog stating it was added. It looks like the option hasn't been added as a valid option in the setup. Is there a way to force it?

Please try to do empty your browser cache and then reload the web console.

My apologies. That did work. I was able to see and set it to mode. I can confirm that the disc switching is working as well. Thank you very much!

Cool!


West Midlands | Samira Hekmati | Module-User-Focused-Data | sprint 2

Learners, PR Template
Self checklist

[x] I have committed my files one by one, on purpose, and for a reason
[x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x] I have tested my changes
[x] My changes follow the style guide
[x] My changes meet the requirements of this task

Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.

Hi @samirahekmati, if you have already made the changes that were requested - feel free to add the Complete label to your PR 😄


Extension methods for where filter

Hi @remorses ,
Is it possible to create extension methods for filters alongside the where extension method. the likes of .eq(), .neq(), .gt(),.lt() etc .
This will help make the query less bloated the way the where clause packs/holds this data . for e.g
client
    .query({
        countries: [
            {
                filter: { code: 'BR' },
            },
            {
                name: true,
                code: true,
                languages: {
                    name: true,
                },
            },
        ],
    })

can be
await client
    .query({
        countries:
            {
                name: true,
                code: true,
                languages: {
                    name: true,
                },
            },
    }).eq('Code','BR')

No, it is not possible
If you want you can create your own functions that create an argument object
client
    .query({
        countries: [
            eq('code', 'BR'),
            {
                name: true,
                code: true,
                languages: {
                    name: true,
                },
            },
        ],
    })

function eq(field, value) {
  return { filter: {[field]: {eq: value }}
}

I don't think this adds much value tho


Adding filter select

Soves the issue #6 (fuzzy select search).

@antoinePutmans have you closed it accidentally?

@antoinePutmans have you closed it accidentally? UPD: I reopened it.

Hey, I wanted to do a little change in my code before reopening it
It is done so everything is fine 😄

Hello guys, this is the code for the feature we were talking about in the following issue https://github.com/fadeevab/cliclack/issues/6
This may not be the most idiomatic or optimised Rust code, so I would appreciate it if you could review it and suggest any improvements. Thanks in advance! 😄
@fadeevab I have changed the filtering input to the top, underneath the header as you mentioned
@cylewitruk I added a function called enable_filter() to activate the feature but the shrinking of the list is not implemented yet

@antoinePutmans Overall, I could merge your PR and refactor it to my taste. :)

Good work @antoinePutmans :) I'll definitely be using this!

@antoinePutmans I tested a little bit, in your example it cannot find the last element by the second word "KEY".

@antoinePutmans I tested a little bit, in your example it cannot find the last element by the second word "KEY".

I did some changes to the matching algorithm, it should handle this case now 👍
I also cleaned up the function because it was pretty ugly

@antoinePutmans I tested a little bit, in your example it cannot find the last element by the second word "KEY".

I did some changes to the matching algorithm, it should handle this case now 👍 I also cleaned up the render function because it was pretty ugly

still nope :)

@antoinePutmans I tested a little bit, in your example it cannot find the last element by the second word "KEY".

I did some changes to the matching algorithm, it should handle this case now 👍 I also cleaned up the render function because it was pretty ugly

still nope :)

Should be good, I forgot to lowercase the bonus points 😓

@antoinePutmans not sure whether you have noticed but I merged the PR.

Oh great ! 😁 Thank you guys for all of your comments and advice, it was really helpful !!


Fix obsoleted tf.train.SummaryWriter() in the document page of Embedding Visualization

The original document use an incorrect function to instantiate the summary file writer.

Can one of the admins verify this patch?

I signed it!

I signed it!

See https://patch-diff.githubusercontent.com/raw/tensorflow/tensorflow/pull/7666.patch for which commit you signed with, make sure it matches the one you signed the CLA with.

@vrv I am unsure how to specify the commit I sighed with in the Google CLA website.
I went to https://cla.developers.google.com/ and signed in my Google account. However, I signed in with a different Google account in the first attempt. Could you

Closing out because it's already fixed in master. Thanks for the pull request! In the future, you'll need to make sure that you signed the CLA with the same e-mail address you committed with.


Dataset download is very slow

Is there an alternate host to sharepoint? For some reason they're downloading somewhere from 10s of KBps to ~3MBps

Sorry for the inconvenience. I only have access to OneDrive storage service provided by HKU. Maybe, it would be faster sometime. Or you may render the images from objaverse directly.


Roll Engine from 47af169980a0 to 24adff36c8a4 (2 revisions)

https://github.com/flutter/engine/compare/47af169980a0...24adff36c8a4
2022-04-20<EMAIL_ADDRESS>Roll Skia from 2cf8e9b602ec to 5b64108aa768 (1 revision) (flutter/engine#32797)
2022-04-20<EMAIL_ADDRESS>Verbose display list comparisons (flutter/engine#32737)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


pkgsx86Darwin: init

Many packages don't work on aarch64-darwin yet or are x86-only binary packages.
This gives aarch64-darwin users easy access to x86_64-darwin packages to run via
Rosetta 2.

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I'm not 100% sure about the name.
Other candidates I had in my head were pkgsIntelDarwin and pkgsx86Darwin.
Suggestions welcome.

I was gravitating more towards the shorter pkgsx86Darwin since i686-darwin is not a thing.
Another thought crossed my mind while typing this: Why don't we generate such a set for all of our systems combinations?

I don't like Intel being present in the name, tbh. pkgsx86Darwin is probably the best option suggested so far imo

I think in general it's very simple to override the system of the package set, so there's no need for a specific set, unless there's more complex changes to be done to make it work, or a particular reason for it to exist.

Well for one, the premise isn't true: It's not at all simple to override the system of a package set AFAIK. You need to re-import nixpkgs which non-trivial in everything but the simplest cases. Non-trivial example:
{ pkgs, ... }:
{
  nixpkgs.overlays = [ (final: prev: { baz = ...; }) ];
  foo = with pkgs; [ bar pkgsx86Darwin.baz ];
}

rosetta

This package set is that it's technically also usable under x86_64-darwin. This actually has a use-case in cross-arch configs.
In the example above, we'd get aarch64 bar and x86 baz on aarch64 while we'd get x86 versions of both on x86; it's compatible.

I may not have been clear enough but pkgsx86Darwin would not be a mixed-arch set. What I meant is that pkgsx86Darwin == pkgs when system == x86_64-darwin and you therefore don't need special handling when using the same Nix expressions for aarch64 and x86.

I don’t have much to add except I agree regarding the name. Considering that macOS 10.12 (the version supported by the default x86_64-darwin SDK) supports 32-bit processes, I can see there being some confusion with the name even though nixpkgs doesn’t (and shouldn’t) support 32-bit Darwin.
One thing I wonder is how usable pkgsCross.x86_64-darwin should be from aarch64-darwin. I get an infinite recursion when trying to do nix build nixpkgs#pkgsCross.x86_64-darwin.hello, but if that were fixed, would it be preferable to pkgsx86_64Darwin.hello in most cases (due to using aarch64-darwin nativeBuildInputs where possible)?

Hmm, no. Never mind the last bit. It wouldn’t help if nativeBuildInput didn’t work on aarch64-darwin.


Add Alarm App in Android Projects

Requirements for the app:-

Store multiple alarms
Set individual days the alarm should repeat
Shows notification with noise when the alarm sounds

Requirements for the README.md:-

Concepts used while making the app
Documentation and resources used
Future Aspects of the app

@kunal299  Do you need a nice looking UI too?

@avinash14022002 No, the UI of the app should be minimal.

Could you assign this task to me??

@avinash14022002 It's based on first come first serve pull request.

@avinash14022002 You can proceed with this project.

Can I make edits to the Readme? Like will that be valid?

@Prajata123 Are you talking about the README.md file of our repository or the app's README.md?

The readme of the app.
On Sun, Oct 4, 2020, 7:48 PM Kunal Mali<EMAIL_ADDRESS>wrote:

@Prajata123 https://github.com/Prajata123 Are you talking about the
README.md file of our repository or the app's README.md?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dubesar/Java-A-Z/issues/326#issuecomment-703262512,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALDWKKPD2UTP5CEYDUOALCLSJB73ZANCNFSM4SDOS7TQ
.

@Prajata123 Yeah sure, you can improve the quality of the README file of the app.

Will it be approved for Hacktoberfest. I'm sorry I don't know a lot about
development and I'm starting.
On Sun, Oct 4, 2020, 7:53 PM Kunal Mali<EMAIL_ADDRESS>wrote:

@Prajata123 https://github.com/Prajata123 Yeah sure, you can improve
the quality of the README file of the app.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dubesar/Java-A-Z/issues/326#issuecomment-703263145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALDWKKP3RZI3GC5GFSKVRTLSJCAM3ANCNFSM4SDOS7TQ
.

For Hactoberfest most of your PR's should be of high quality which should include some development. But don't feel sad, you can start contributing from the README.md file and then slowly start contributing to projects. Learn a technology side by side and when u r done with 40-50%, you can start contributing for bigger contributions.

Give a star to our repo if you liked the project.


Track active observables

Hey all, first of all thanks for creating and managing this library.
I'd like to discuss adding support for tracking active observables so that we may support features like this on tests:
import { activeObservables, clearActiveObservables } from 'kefir'

beforeEach(() => { clearActiveObservables() })
afterEach(() => { expect(activeObservables.length).toEqual(0) })

and to eventually create a browser extension or even simpler to do a $K.activeObservables on the browser console - assuming you've bound kefir to window window.$K = Kefir - and see if there are any memory leaks on your code.

[x] docker support https://github.com/kefirjs/kefir/pull/316
[x] upgrade mocha https://github.com/kefirjs/kefir/pull/318
[x] npm run watch https://github.com/kefirjs/kefir/pull/319
[x] track active observables on dev build only
[x] update tests that were not unsubscribing from all observables

P.S.: I've pushed two commits labeled "remove me" with the intention to diff the modified dist files (see second commit), these commits are going to be removed before merging this PR.

Definitely going to need to ponder this a bit.

I'm not confident on my Proxy usage. Perhaps someone has another idea on how to track observables?

I don't think we need to go full Proxy. You can just monkeypatch the method. If you wanted to use Proxy, you should probably Proxy the entire Observable object and then trap the particular methods in the Proxy handlers.

You can just monkeypatch the method.

What is your suggestion so I could try? One problem I had before was that Kefir.atom and other will extend this Observable class and thus remove any implementation we set on _onActivation and _onDeactivation.

What is your suggestion so I could try implementing it?

Ultimately not terribly different from what you have, except instead of returning a proxy, you return a new function.

One problem I had before was that Kefir.atom and other classes will extend this Observable class and thus remove any implementation we set on _onActivation and _onDeactivation.

Not 100% sure I follow; if you have an example, that would be helpful. But if we're wrapping the method, because we still end up calling the underlying method, I don't think it'll be an issue.

Ultimately not terribly different from what you have, except instead of returning a proxy, you return a new function.

Ok, I'll update this PR soon.

Not 100% sure I follow; if you have an example, that would be helpful. But if we're wrapping the method, because we still end up calling the underlying method, I don't think it'll be an issue.

I misunderstood what you said earlier, I thought you had suggested we wouldn't call the original method. 👍

Okay, so I've pushed another code which does not use Proxy, now there is something weird happening, the following test would not unsubscribe the observable:
export const getValue = maybeObservable => {
  if (!isObservable(maybeObservable)) return maybeObservable
  let value
  const setValue = val => value = val
  const firstValue = maybeObservable.take(1)
  firstValue.onValue(setValue)
  firstValue.offValue(setValue)
  return value
}

test('returns syncronous value from observables', () => {
  expect(streams.getValue(K.constant(1))).toBe(1)
})

The following observable is still tracked by Kefir.activeObservables:
    [ AnonymousObservable {
        _dispatcher: null,
        _active: false,
        _alive: false,
        _activating: false,
        _logHandlers: null,
        _spyHandlers: null,
        _onActivation: [Function: _onActivation],
        _onDeactivation: [Function: _onDeactivation],
        _currentEvent: { type: 'value', value: 1 },
        _source: null,
        _name: 'constant.take',
        _n: 0,
        '_$handleAny': null } ]

I don't understand yet why this observable (which is not active, and not alive) has not been removed from the array, but I'll debug it further.
P.S.: Would you rather use apply from src/utils/function ?

@mAAdhaTTah I've finally come back to this PR and while there are commits that I need (some I have already)  to extract into smaller PRs, this is ready for review.
I have a commit where I had to brute-force subscription deactivation because I don't think there is another way to handle it with the existing code. I'm not sure if it's worth exporting the onAny function on toPromise or if the subscription is deactivating automatically on non-test environments because a promise always ends.

@mAAdhaTTah I'm thinking that maybe we shouldn't introduce a new dev dist and just include these methods on the normal distributed files?

Maybe I should ask more generally: what's the purpose of this? Why do you need to track active observables?

For now, we are only tracking active observables to track memory leaks.
afterAll(() => {
  if (activeObservables.length !== 0) {
    fail()
  }
})

test('all observables are unsubscribed', () => {
  render(<MyComponent />)
})

It's very easy to make a mistake and forget to unsubscribe a component when using .observe for instance.

We could, though I think that tracking observables during a test environment is not the only usage. We could for instance want to run this on our browser window and make sure that while navigating from one page to another the number of observables is corresponding to what we expect.
I was thinking about using a configurable environment variable that would default to the test environment so that users could opt in and out in any environment.
const { NODE_ENV, TRACK_OBSERVABLES }
const trackObservables = TRACK_OBSERVABLES || NODE_ENV === 'test'


Implement Blobstore

Implement the blobstore library as seen here.
Url: https://vedantroy-step-2020.uc.r.appspot.com/
Note: The file upload works locally, but does not seem to work when deployed. Currently figuring out what is going on with that.
Note 2: I noticed a bit of duplication of constants in my code. Should I extract them into a constants class?
@sooniln @alexanderkuznetsov96

@sooniln I addressed comments.

I left the constants as is, since, from your explanation, there aren't that many constants that should be shared across files (really, just the paths)
I added code to delete extra blob keys
Formatted the code
Rebased to remove the weird Javascript regression

@sooniln I overhauled the code so that each comment was associated with an optional image. As a result a decent chunk of code is outdated.


Add Snappy Canopy-App Flowchart/Diagram Using Markdown

@zmoon suggested using markdown to create a canopy-app flowchart/diagram to add to the README or eventual ReadTheDocs page for user information.
Markdown Suggestions
Mermaid (https://mermaid-js.github.io/mermaid/#/)
MyST:  (https://js.myst.tools/guide)

@zmoon Do you have any progress on making this?  Does our latest code structure changes help improve the logic and organization of such a diagram?


Failed to validate a input field of type 'number' with a schema declared as a number.

It has followed every step from https://www.shadcn-svelte.com/docs/components/form. The only difference is the declaration of the Zod schema and the data type for the text input. However, when submitting the form, it doesn't pass validation because the text input field converts the value to a string instead of maintaining it as a number.
const formSchema = z.object({
    budget: z.number()
})

<FormField {config} name="budget">
	<FormLabel>Presupuesto</FormLabel>
	<FormInput type="number" min="1"/>
        <Validation/>
</FormField>

Try:
const formSchema = z.object({
    budget: z.coerce.number()
})

Thanks, I didn't know about the coerce method. In the end I had solved it using a regular expression.

Yeah I think this is the optimal approach for handling this. We could do some proxy things but then it would become messy with needing <FormNumberInput /> etc!


Flow Interface File Naming Convention Isn't Well-Documented

Hello there,
I spent more time than I care to admit trying to figure out why Flow wouldn't detect my interface files.
I made an interface file called interfaces/isomorphic-fetch.flow:
declare module 'isomorphic-fetch' {
  declare var exports: (url: string, options?: Object) => Promise;
}

... And I updated .flowconfig to point at the interfaces directory:
[libs]
interfaces/

Then, within a file called index.js, I wrote some JavaScript:
// @flow
import fetch from 'isomorphic-fetch'

fetch(10)

I was expecting Flow to emit an error because fetch does not take a number (in this case, '10'), but I didn't get one.
After a bit of research, I deduced that Flow wasn't detecting the interface file so I tried to be as explicit as I could in telling Flow where to find it:
flow stop && flow start --lib ./interfaces/isomorphic-fetch.flow && flow

... I still didn't get the error I was expecting.
After some more research I learned that Flow convention dictates that interface files be called interfaces/isomorphic-fetch.js.flow but mine was called interfaces/isomorphic-fetch.flow. Renaming the interface file caused the type error I was expecting to be emitted. Cool.
Trouble is:

This information does not appear to be documented in the obvious place, which is http://flowtype.org/docs/third-party.html. I had to learn about it via #1469.
I think Flow could have been more helpful by emitting a warning or some information relevant to my problem in the .log file.

Thanks for writing this up! I'll follow up with a documentation update to better explain that we expect just .js files in the [libs] directory.
Can I ask how you came to the conclusion that .flow was the expected file extension?

I inferred it from #1469.
Thanks :smile:


Fix type property of attributes in rules json

This PR contains the changes for the following:

Update the type property for the attributes in the rules json from DATA to DATA

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fixes to playbookgenerator controller reconcile

This adds some appropriate requeue's, and quiets down
some logging that were occuring when this controller
reconciled a playbookgenerator.

/lgtm


Try and let processes exit on their own instead of calling process.exit();

See discussion on #239

Still failing. I've had enough, let's just remove Node.js 0.10 from AppVeyor. It's already tested on Linux. ?

I begrudgingly agree. Very disappointed this is the route we have to take:
http://help.appveyor.com/discussions/problems/1352-output-of-commands-is-often-trimmed
https://github.com/mapnik/node-mapnik/issues/257#issuecomment-45571226
http://help.appveyor.com/discussions/problems/1257-console-output-suppressed

Here is the core issue: https://github.com/nodejs/node-v0.x-archive/pull/7196
The fix needs to be back-ported to the Node 0.10 branch. A number of people have plus oned the issue, without a lot of traction.
@sindresorhus Do you know anybody working on node that could push that along? This will impact our ability to provide TAP output on Node 0.10 / Windows.
If we can't get this fixed upstream, we should at least do our users the courtesy of officially NOT supporting it, and documenting the lack of support. Something along the lines of "We support all LTS versions of Node, with the exception of 0.10 on Windows." (and a link to the relevant issue).

Do you know anybody working on node that could push that along?

@silverwind

This will impact our ability to provide TAP output on Node 0.10 / Windows.

Yeah, let's just document it. I honestly couldn't care less about an ancient Node.js version on Windows. Most people test on Travis anyways. I think we've wasted more than enough time dealing with this.

There's https://github.com/cowboy/node-exit, but process.on('exit') won't work correctly when using it.

I honestly couldn't care less about an ancient Node.js version on Windows

I am perfectly fine leaving it at that.

but process.on('exit') won't work correctly ...

I don't think process.on('exit') is being used anywhere in our code, we are using signal-exit which does things a bit different (not sure how it would be affected without testing).

@jamestalmage you could just do a PR on node with that backport, targeting the v0.10 branch. Maybe it'll even make it in time for the upcoming release, see https://github.com/nodejs/node/pull/2805. I don't think anyone would object merging it.


updated risc0 verifier to latest version

updated the risc0 verifier to the latest version.
the updated risc0 verifier needs to get the image ID from the XXX_GUEST_ID instead of previously claim.digest()
so in the host code you have to do:
println!(
    "Method ID: {:?} (hex)",
    Digest::from(CHESS_GUEST_ID).to_string()
);

compared to the previous versions (the version of collatz for example):
println!("Method ID: {:?} (hex)", claim.pre.digest());

The XXX_GUEST_ID is given by risc0 template by default
tbh I'm still unsure of what's the difference between the two hashes but it works! maybe you guys could take a look

btw the naming of my variables kinda sucks lmk if i should change it haha


Cursor position is wrong on startup

Self-Diagnosis

[x] I have searched the issues for an answer to my question.
[x] I have reviewed the NERDTree documentation. :h NERDTree
[x] I have reviewed the Wiki.
[x] I have searched the web for an answer to my question.

Environment (for bug reports)

[x] Operating System: RHEL 7.7

[x] Vim/Neovim version :echo v:version: 800

[x] NERDTree version, found on 1st line in NERDTree quickhelp ?: 6.7.0

[x] vimrc settings

[x] NERDTree variables

" open on start up in console for directory
augroup OpenNerdTreeOnDirectory
    autocmd!
    autocmd StdinReadPre * let s:std_in=1
    autocmd VimEnter * if argc() == 1 && isdirectory(argv()[0]) &&
        \ !exists("s:std_in") | ene | exe 'NERDTree' argv()[0] | endif
augroup END

" close when only nerdtree left
augroup CloseNerdTree
    autocmd!
    autocmd bufenter * if (winnr("$") == 1 && exists("b:NERDTree") &&
        \ b:NERDTree.isTabTree()) | q | endif
augroup END

" ignore certain files and directories
let g:NERDTreeIgnore = ['^.git$', '^node_modules$']

" show hidden files by default in certain directories
augroup NerdTreeShowHiddenFiles
    autocmd!
    autocmd BufEnter ~/.dotfiles** let g:NERDTreeShowHidden = 1
augroup END

" automatically delete buffer for files deleted in NERDTree
let g:NERDTreeAutoDeleteBuffer = 1

nnoremap <Leader>f :NERDTreeFocus<CR>

Other NERDTree-dependent Plugins

[ ] jistr/vim-nerdtree-tabs
[ ] ryanoasis/vim-devicons
[ ] tiagofumo/vim-nerdtree-syntax-highlight
[x] Xuyuanp/nerdtree-git-plugin
[ ] Others (specify):

[x] I've verified the issue occurs with only NERDTree installed.

Steps to Reproduce the Issue

Open neovim on a directory (e.g. nvim .)

Current Result (Include screenshots where appropriate.)
vim-airline shows that the nerdtree window is active (has the color in the airline). However, the cursor is actually in the empty buffer window.
Expected Result
cursor stays in nerdtree window.
Additional notes
I think this only started to happen after I upgraded my plugins yesterday. Previously it has been working fine (last time I update should be around mid-January). I'm not sure if some code change

If I manually run ene  followed by exe 'NERDTree' '/some/path' it will correctly open and focus on NERDTree. Only when on startup it's not working as expected.

With only NERDTree, nerdtree-git-plugin and vim-arline installed, and using the vimrc given in the issue, I do not see this behavior. My cursor is located in the NEDTree window, as expected, and Airline indicates it is the active window. Perhaps you have another autocommand interfering with the ones you show above.

Turns out this is due to a recent change in the indentLine plugin (https://github.com/Yggdroot/indentLine/issues/289).
Closing the issue.


Add a forEach method to Observable

Add a forEach method to Observable, for use with synchronous code, which will behave similarly to subscribe, except that it'll block (await) until complete.

I don't know if we need to have this feature block 2.0 as it can be added after without BC.


fix tag ordering

fix the tag ordering issue when using FIX44's spec.
This contains a few formatting/typos fixes in addition to the bug fix changes, let me know if you want me to split these changes out. The test changes pass against the FIX44.xml reference. I'll look at running the tests automatically against multiple specs.

Good point! Thank you! I’ll add a test case for that, and think about the header tags.
François

On 18 Apr 2019, at 19:45, raoyitao<EMAIL_ADDRESS>wrote:
@raoyitao commented on this pull request.
In pyfixmsg/reference.py:

 """

 Retrieve the sorting key for an object.
 The sorting key is used to serialise tags in the order they appear in the spec.
 It is unclear whether that's required for the root of the message (aside from header and tail)
 but it is essential in repeating groups. This takes the safe approach of enforcing it at all
 levels.
 """

sorting_key = sorting_key or {35: -1, 10: int(10e9)}

if sorting_key is None:

   sorting_key = {35: -1, 10: int(10e9)}

   for index, item in enumerate(spec.header_tags):

       sorting_key[item.tag] = index

start_index = index + 1
Thanks for your PR, I have some comment for it. It seems good for FIX4.2 or FIX4.4, but Quick FIX 5.0 spec has no headers defined (they were defined in another transportation spec, we might support it later). So, I don't think it works for FIX5.0 or later version.
For example, my message is '8=FIX.4.2;9=97;35=B;215=1;216=1;146=2;55=EURUSD;55=EURGBP;10=000;', after parsing it and serializing the message, I found tag 8 and 9 are not in correct order.

Something could be considered:
1). In FixSpec::init(), self.header_tags = [...] or [self.tags.by_tag(tag) for tag in HEADER_TAGS]
HEADER_TAGS is pre-defined in this file, but it's for FIX4.2 so I'm afraid it needs a little change for FIX5.0, is there any idea to make is available for all versions?
2). HEADER_TAGS of FIX4.4/5.0 also has group, just enumerating spec.header_tags to get tags' index is not enough to handle repeating groups.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes that’s my virtual environment, will remove.
François

On 18 Apr 2019, at 19:50, raoyitao<EMAIL_ADDRESS>wrote:
@raoyitao commented on this pull request.
In .gitignore:

@@ -9,3 +9,5 @@ fixspecs/FIX40.xml
.idea/.name

.idea/pyfixmsg.iml
+
+venv/*
Well, why add a venv dir here, is it in your own develop environment ? maybe the fixspecs/FIX40.xml could be removed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Update num_classes in reset_classifier in ResNet V2

@M-Salti thanks for the PR but I addressed in my commit to fix #540

Great! Thanks for the fix.


mypy plugin internal error

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
Pydantic v1.10 mypy plugin is not compatible with mypy v1.4.1
whatever I'm trying to check with mypy fails with the mypy internal error stack trace.
poetry run mypy . --show-error-context --pretty --namespace-packages --explicit-package-bases --show-traceback
PyProjects/.venv/lib/python3.11/site-packages/pydantic/env_settings.py:22: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 1.4.1
Traceback (most recent call last):
  File "mypy/semanal.py", line 6451, in accept
  File "mypy/nodes.py", line 1139, in accept
  File "mypy/semanal.py", line 1582, in visit_class_def
  File "mypy/semanal.py", line 1667, in analyze_class
  File "mypy/semanal.py", line 1694, in analyze_class_body_common
  File "mypy/semanal.py", line 1777, in apply_class_plugin_hooks
  File "pydantic/mypy.py", line 154, in pydantic.mypy.PydanticPlugin._pydantic_model_class_maker_callback
  File "pydantic/mypy.py", line 317, in pydantic.mypy.PydanticModelTransformer.transform
  File "pydantic/mypy.py", line 496, in pydantic.mypy.PydanticModelTransformer.add_construct_method
TypeError: __init__() missing required argument 'default' (pos 6)
/PyProjects/.venv/lib/python3.11/site-packages/pydantic/env_settings.py:22: : note: use --pdb to drop into pdb

Example Code
import pydantic

class Item(pydantic.BaseModel):

    any_field: str

Python, Pydantic & OS Version
pydantic version: 1.10.8
            pydantic compiled: True
                 install path: .venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.4 (main, Jun  7 2023, 12:45:48) [GCC 11.3.0]
                     platform: Linux-5.19.0-50-generic-x86_64-with-glibc2.35
     optional deps. installed: ['typing-extensions']

### Affected Components

- [ ] [Compatibility between releases](https://docs.pydantic.dev/changelog/)
- [ ] [Data validation/parsing](https://docs.pydantic.dev/usage/models/#basic-model-usage)
- [ ] [Data serialization](https://docs.pydantic.dev/usage/exporting_models/) - `.dict()` and `.json()`
- [ ] [JSON Schema](https://docs.pydantic.dev/usage/schema/)
- [ ] [Dataclasses](https://docs.pydantic.dev/usage/dataclasses/)
- [ ] [Model Config](https://docs.pydantic.dev/usage/model_config/)
- [ ] [Field Types](https://docs.pydantic.dev/usage/types/) - adding or changing a particular data type
- [ ] [Function validation decorator](https://docs.pydantic.dev/usage/validation_decorator/)
- [ ] [Generic Models](https://docs.pydantic.dev/usage/models/#generic-models)
- [ ] [Other Model behaviour](https://docs.pydantic.dev/usage/models/) - `construct()`, pickling, private attributes, ORM mode
- [X] [Plugins](https://docs.pydantic.dev/) and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Selected Assignee: @dmontagu

Because we did a fairly significant overhaul of the mypy plugin for v2, I don't think we currently intend to maintain the pydantic v1 mypy plugin for compatibility with the latest versions of mypy (unless there is enough demonstration of interest), but I would be happy to review a PR against the 1.10.X-fixes branch if someone wants to fix this.

Anecdotally, I've seen creating a fresh virtual environment and re-installing mypy 1.4.1 and pydantic v1.10` resolve this issue.
Notably just clearing the mypy cache did not seem to be enough to fix this.

I had the same problem here after upgrading mypy from version 1.3.0 to 1.4.1 using Pydantic version 1.10.2.
I tried clearing mypy's cache and rebuilding the virtual environement and the problem persisted.
I went back to version 1.3.0 and it worked perfectly.

I am going to close this issue because:

I can't reproduce the issue using the provided example code with the latest pydantic-v1 and mypy (note, various issues with the mypy plugin have been fixed in patch releases of 1.10.X)
Other users have indicated above that updating mypy and pydantic and in a new environment resolved the issue for them.

I do suspect that this is just fixed in the latest version of pydantic, given the traceback is pointing at a line in the plugin code that has been changed/no longer exists.
If you still run into this with the latest version of pydantic (even v1), feel free to re-open the issue with additional details describing the issue after updating (since, at the very least, the traceback would be different).


ncompress: split "name" in "pname" and "version"

Motivation for this change
Split "name" in "pname" and "version" as requested in #113590
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 113626 at 2be7907c run on aarch64-linux 1

7 packages built:

ncompress
python37Packages.binwalk
python37Packages.binwalk-full
python38Packages.binwalk
python38Packages.binwalk-full
python39Packages.binwalk
python39Packages.binwalk-full

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/tools/compression/ncompress/default.nix:14:3:
   |
14 |   meta = {
   |   ^

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 113626 run on x86_64-linux 1

8 packages built:

cdesktopenv
ncompress
python37Packages.binwalk
python37Packages.binwalk-full
python38Packages.binwalk
python38Packages.binwalk-full
python39Packages.binwalk
python39Packages.binwalk-full

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

cdesktopenv:

lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.
Near pkgs/desktops/cdesktopenv/default.nix:77:5:
   |
77 |     license = licenses.lgpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
tcl is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/desktops/cdesktopenv/default.nix:32:3:
   |
32 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/desktops/cdesktopenv/default.nix:67:3:
   |
67 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
Unused argument: libredirect.
Near pkgs/desktops/cdesktopenv/default.nix:5:21:
  |
5 | , autoPatchelfHook, libredirect, makeWrapper, xset, xrdb, fakeroot
  |                     ^

ncompress:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/tools/compression/ncompress/default.nix:14:3:
   |
14 |   meta = {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python37Packages.binwalk-full:

Package is missing a license
Near pkgs/development/python-modules/binwalk/default.nix:53:3:
   |
53 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

python37Packages.binwalk:

Package is missing a license
Near pkgs/development/python-modules/binwalk/default.nix:53:3:
   |
53 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

python38Packages.binwalk-full:

Package is missing a license
Near pkgs/development/python-modules/binwalk/default.nix:53:3:
   |
53 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

python38Packages.binwalk:

Package is missing a license
Near pkgs/development/python-modules/binwalk/default.nix:53:3:
   |
53 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

python39Packages.binwalk-full:

Package is missing a license
Near pkgs/development/python-modules/binwalk/default.nix:53:3:
   |
53 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md

python39Packages.binwalk:

Package is missing a license
Near pkgs/development/python-modules/binwalk/default.nix:53:3:
   |
53 |   meta = with lib; {
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/license-missing.md


Overlay will not run w/o work arounds/fixes

Is there an existing issue for this?

[X] I have searched the existing issues

Greenfield/Brownfield provisioning
greenfield
Terraform Version
1.4.4
Module Version
2.0.3
AzureRM Provider Version
3.60
Affected Resource(s)/Data Source(s)
n/a
Terraform Configuration Files
# Azurerm provider configuration
provider "azurerm" {
  environment = "USGovernment"
  skip_provider_registration = "true"
  features {
    resource_group {
      prevent_deletion_if_contains_resources = false
    }
  }
}
data "azurerm_virtual_network" "hub-vnet" {
  name                = "tf-anoa-usgaz-hub-core-dev-vnet"
  resource_group_name = "tf-anoa-usgaz-hub-core-dev-rg"
}

data "azurerm_storage_account" "hub-st" {
  name                = "tfanoausgaz3202fb10aedev"
  resource_group_name = "tf-anoa-usgaz-hub-core-dev-rg"
}

data "azurerm_log_analytics_workspace" "hub-logws" {
  name                = "tf-anoa-usgaz-ops-mgt-logging-dev-log"
  resource_group_name = "tf-anoa-usgaz-ops-mgt-logging-dev-rg"
}

module "vnet-wl-spoke" {
  source  = "azurenoops/overlays-workload-spoke/azurerm"
  version = "2.0.3"

  # By default, this module will create a resource group, provide the name here
  # To use an existing resource group, specify the existing resource group name,
  # and set the argument to `create_resource_group = false`. Location will be same as existing RG.
  create_resource_group = true
  location              = var.aks_vnet_location
  deploy_environment    = var.aks_deploy_environment
  org_name              = var.aks_vnet_org_name
  environment           = var.aks_vnet_environment
  workload_name         = var.aks_vnet_workload_name

  # Collect Hub Virtual Network Parameters
  # Hub network details to create peering and other setup
  hub_virtual_network_id          = data.azurerm_virtual_network.hub-vnet.id
  hub_firewall_private_ip_address = "<IP_ADDRESS>"
  hub_storage_account_id          = data.azurerm_storage_account.hub-st.id

  # (Required) To enable Azure Monitoring and flow logs
  # pick the values for log analytics workspace which created by Hub module
  # Possible values range between 30 and 730
  log_analytics_workspace_id           = data.azurerm_log_analytics_workspace.hub-logws.id
  log_analytics_customer_id            = data.azurerm_log_analytics_workspace.hub-logws.workspace_id
  log_analytics_logs_retention_in_days = 30

  # Provide valid VNet Address space for spoke virtual network.
  virtual_network_address_space = ["<IP_ADDRESS>/24"] # (Required)  Hub Virtual Network Parameters

  # (Required) Specify if you are deploying the spoke VNet using the same hub Azure subscription
  is_spoke_deployed_to_same_hub_subscription = true

  # (Required) Multiple Subnets, Service delegation, Service Endpoints, Network security groups
  # These are default subnets with required configuration, check README.md for more details
  # Route_table and NSG association to be added automatically for all subnets listed here.
  # subnet name will be set as per Azure naming convention by defaut. expected value here is: <App or project name>
  spoke_subnets = {
    default = {
      name                                       = var.spoke_subnets_name
      address_prefixes                           = ["<IP_ADDRESS>/26"]
      service_endpoints                          = ["Microsoft.Storage"]
      private_endpoint_network_policies_enabled  = false
      private_endpoint_service_endpoints_enabled = false
    }
  }

  # By default, forced tunneling is enabled for the spoke.
  # If you do not want to enable forced tunneling on the spoke route table,
  # set `enable_forced_tunneling = false`.
  enable_forced_tunneling_on_route_table = true

  # Private DNS Zone Settings
  # By default, Azure NoOps will create Private DNS Zones for Logging in Hub VNet.
  # If you do want to create addtional Private DNS Zones,
  # add in the list of private_dns_zones to be created.
  # else, remove the private_dns_zones argument.

  #private_dns_zones_to_link_to_hub = ["privatelink.file.core.windows.net"]

  # By default, this will apply resource locks to all resources created by this module.
  # To disable resource locks, set the argument to `enable_resource_locks = false`.
  enable_resource_locks = false

  # Tags
  add_tags = {
    Example = "Workload Identity Core Spoke"
  } # Tags to be applied to all resources
}

tfvars variables values
variable "existing_resource_group_name" {
  description = "The name of the existing resource group to use. If not set, the name will be generated using the `org_name`, `workload_name`, `deploy_environment` and `environment` variables."
  type        = string
  default     = null
}

# AKS vNet | spoke variables
variable "aks_vnet_location" {
  description = "The location of the AKS cluster."
  type        = string
  default     = "usgovarizona"
}
variable "aks_vnet_environment" {
  description = "The environment of the AKS cluster."
  type        = string
  default     = "usgovernment"
}
variable "aks_vnet_org_name" {
    description = "The organization name of the AKS cluster."
    type        = string
    default     = "tf-anoa2"
}
variable "aks_vnet_workload_name" {
    description = "The workload name of the AKS cluster."
    type        = string
    default     = "aks"
}
variable "aks_deploy_environment" {
    description = "The deployment environment of the AKS cluster."
    type        = string
    default     = "dev"
}

variable "spoke_subnets_name" {
  description = "The name of the spoke subnets to create."
  type        = string
  default     = "AKSSubnet"
}

Debug Output/Panic Output
n/a

Expected Behaviour
deploy wl spoke rg, vnet, & 1 subnet
Actual Behaviour

Steps to Reproduce
issues in the list above happened/occurred in ascending order with first issue posted at the bottom of the list.
Important Factoids
doing this in Azure Gov
References
n/a

OBE -- closing


Change test data

Change the test data from downloading them to static data in the repo.

Addressed in commit https://github.com/OpertusMundi/profile/commit/4c8f8f68dc0ca769cfcedf0f7e8ca83f4224c790


[ToDo] Refactor

Refactors todo and cleans up most of the code

Gonna close this, I'm not happy with it yet


Multimodals should be dealt with better

Currently they are quite slow and lossy. I think some of this is that it's because they are handled with each pair combined separately; this seems suboptimal.
I think there should be a way to combine a bunch of distributions at once, like it used to be, instead of only accepting functions with 2 arguments.
This could mean we should make a new function in ExpressionTree that accepts an array of nodes, instead of only 2.
Example input:
mm(normal(-5, 1), normal(0,1), normal(5, 1), normal(8,1), normal(12,1), normal(16,1))+33
Old version:

New version

I'm open to making an array version, but I can't reproduce the lossiness (it's due to downsampling; just set that to 1000 like it used to be) nor the slowness (it's pretty fast here).
I'd be surprised if there's any real difference actually. Each individual distribution is rendered at n points, and then they're all combined, one by one, via linear interpolation. That hasn't changed at all :thinking:

The string,
mm(normal(0, 1), normal(4, 1), normal(8, 1), normal(12, 1), normal(16,1))
Is definitely much slower in development than when done in the app here, for me.
I may be misunderstanding how this is processed. My impression is that originally, with multimodals, the algorithm worked by,

find the min and max of all the distributions
take n points between the totalMean and totalMax, then calculate each pdf at each of those points. Sum these.

The new algorithm seems to work by,
Do (1 and 2) above for the first two distributions, then combine those two. Then do (1 and 2) on that combination, plus the next distribution. If this were true, I'd imagine it would keep on choosing different points to do the calculations on, meaning it would need to do a fair bit more interpolation (on each of the intermediate nodes, as well as the subnodes)

Ah, interesting. You're absolutely right. So the old code first joins all the individual ByWeight xs, and then evaluates the pdfs of all functions everywhere:
  let continuousShape = (dists: t, sampleCount: int) => {
    let xs =
      dists
      |> E.A.fmap(r =>
           r
           |> fst
           |> GenericSimple.interpolateXs(
                ~xSelection=`ByWeight,
                _,
                sampleCount / (dists |> E.A.length),
              )
         )
      |> E.A.concatMany;
    xs |> Array.fast_sort(compare);
    let ys = xs |> E.A.fmap(pdf(_, dists));
    XYShape.T.fromArrays(xs, ys) |> Distributions.Continuous.make(`Linear, _);
  };

The new algorithm works as you described: it renders each pdf, and then interpolates them together.
I underestimated the slowness of the interpolation step. It does a binary search for the corresponding array indices at each step of the loop (so it's something like O((n+m)*(log n + log m))). I've now added an alternative implementation that loops through both arrays simultaneously and interpolates as it goes along (should be O(n+m)).
Whether or not this is faster should now depend entirely on which takes longer: evaluating e.g. a Gaussian at a single point, or doing a single linear interpolation (correct me if I'm missing something). That's something we can benchmark in the future.
Can you confirm whether this improves things on your end?
PS. I do think there's value in keeping track of minX and maxX as we recurse through the expression tree (not least to bound the sampler, when we have to use it), and we should probably do that in the future.

First, I removed the "Truncate To" parameter. These are the resulting stats. It looks like the first version took 150ms per key change, the second (the new one) around 400ms or so.
This is what it is on master for me:

This is what it is on the current epic branch

Interesting, thanks for sharing the screenshots! I'm curious about the breakdown of the render and combine parts at the very bottom of the second chart ...
But yeah, let me find out what the sampleCounts are when the truncateTo/downsampleTo field is empty.

I do recommend spending some time in the performance flame chart, at least in Firefox, I've found it to be really useful for optimization.

I'm going to close, as is not a huge deal right now.


docs(usePermission): remove undefined variable

usePermission document is broken due to this undefined variable.
First I was trying to implement that permission. Looks like it is renamed to 'speaker-selection' from 'speaker' on latest draft. That require me to polyfill types like how you did for clipboard permission. Then I realized no one of existing browsers support that permission. And probably that's why this variable was removed.

Thanks!


Finalize docs

[x] Fix broken image
[x] Make vignettes appear
[x] Fix Reference
[x] Import reticulate classes
[x] Write simple (parameters) & complex (inheritance) usage vignettes

Done


Rewarded AdUnits

Introduce rewarded ad units to SDK:

it is only available to GAM integration, using it with another one will simply ignore it and log the thing
cdb calls now use the isRewarded flag and parse the rewarded response in slots.

Side note: bumped dependencies before starting development of this branch
Jira: DPP-3644 / DPP-3645

Tests are bugging, tried various things but they are still annoying, digging further...


Cannot assign to immutable expression of type 'URLSession.Type'

hi, i need to know how did you resolve this issue?

I am facing the same issue.


Add web authentication

yo can easily use nginx  in front of ovpn-admin to provide this

Sure, I can. But it is not very useful for people who are not familiar with linux commands to update credentials.

hmm, ok.  i will think about it

even if you add nginx proxy in front of it , it'll always be accessible at <IP_ADDRESS>:8080 ( on the first IP based on your openvpn cidr range )


Update Set-CsPhoneNumberAssignment.md

Add again support for DR numbers with extension for resource accounts

@JohanFreelancer9 I added another example to the PS page and removed a note. Do you mind reviewing it again? Sorry about the extra work.

@JohanFreelancer9 I added another example to the PS page and removed a note. Do you mind reviewing it again? Sorry about the extra work.

No problem at all. Done!

@tiburd Please merge this PR. Thanks


fix: prepare cache against workCache

Now have changed their requirements for the cache. It now must be built relative to workPath or prepareCachePath. This PR implements this.
In addition, it no longer creates or copies files into the cache directory, as Now do this step subsequent to the running of prepareCache.
Closes #133

@pi I've asked for a review to check that cache directory maintenance isn't required for a reason of which I'm unaware.

LGTM!

I've asked for a review to check that cache directory maintenance isn't required for a reason of which I'm unaware.

Would you please elaborate more?

I've asked for a review to check that cache directory maintenance isn't required for a reason of which I'm unaware.

Would you please elaborate more?

I've removed the bit where we delete the cache directory and rebuild it. It doesn't seem necessary to me - but just want to check there's no hidden gotcha that you're aware of.

Nop. Was just to ensure ++ Better tests (as we reuse same FS)
Feel free merge ;)


fix: baseBinary not compatible with windows builds, also pointing to wrong folder

PR Checklist
Please check if your PR fulfills the following requirements:

[ x] The commit message follows our guidelines: https://github.com/scullyio/scully/blob/main/CONTRIBUTING.md#commit
[x ] Tests for the changes have been added (for bug fixes / features)
[x ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Use path.join() to add paths.  Fixes a path issue when building scully.
Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


unable to get stats for execution engines Tez,spark.

@akshayrai @shankar37  Please help me on this.
I have configured new webUI for Dr.elephant, but could able to see the stats if the job ran with hive.execution.engine=mr only. If I try the same query with TEZ it doesn't show up, same goes with spark-shell also.

Any parameters needs to be added in Fetcherconf.xml for tez and spark ?

Any suggestions of adding params would be more helpful

@akshayrai @ljank Can you please help me on this ?

Can anyone please suggest me for hadoop jobs , for tez execution engine ?

@ashokhellboy do you see any error in the dr_elephant.log file?


Using :after does not work

I want to load ement.el (which depends on plz.el) with use-package and straight.el. I figured that I have to manually load plz.el, too. It works when I first invoke (use-package plz) and afterwards (use-package ement):
Just start emacs -Q and evaluate this file:
(setq package-enable-at-startup nil)
(setq straight-use-package-by-default t)

(load "~/.emacs.d/straight/repos/straight.el/bootstrap.el")

(add-to-list 'load-path "~/.emacs.d/straight/build/use-package")
(add-to-list 'load-path "~/.emacs.d/straight/build/bind-key")

(require 'use-package)

(setq use-package-always-defer nil)
(setq use-package-always-demand t)

(use-package plz
  :straight (plz :host github :repo "alphapapa/plz.el"))

(use-package ement
  :straight (ement :host github :repo "alphapapa/ement.el"))

But I like to keep my use-package invocations sorted. I.e. I want (use-package ement) to appear in the code before (use-package plz). But whether or not I add :after plz, I get this error:
;; ...

(use-package ement
  :after plz
  :straight (ement :host github :repo "alphapapa/ement.el"))

(use-package plz
  :straight (plz :host github :repo "alphapapa/plz.el"))

straight--convert-recipe: Could not find package plz. Updating recipe repositories: (org-elpa melpa gnu-elpa-mirror el-get emacsmirror-mirror) with ‘straight-pull-recipe-repositories’ may fix this

How to get this working?

(use-package ement
  :after plz
  :straight (ement :host github :repo "alphapapa/ement.el"))

Expands to:
(progn
  (straight-use-package
   '(ement :host github :repo "alphapapa/ement.el"))
  (eval-after-load 'plz
    '(require 'ement nil nil)))

The installation of the package happens prior to the rest of the use-package forms.
In order to get this working you could, as you mentioned, order the use-package declarations so that plz's declaration comes first. Alternatively, you could make an explicit call to `straight-use-package prior to the use-package declaration for ement. e.g.
(straight-use-package '(plz :host github :repo "alphapapa/plz.el"))
(use-package ement
  ;etc
  )
(use-package plz
  :straight nil
  ;;etc
  )

Personally, I would opt for the first solution because it keeps the installation with the rest of plz's configuration.
Does that help?

Thank you.

Why does installing ement.el already throw an error that it's missing plz.el (although it's apparently not "required" yet)?

Why does this

(use-package ement
  :after plz
  :straight (ement :host github :repo "alphapapa/ement.el"))

not expand to something like
(progn
  (eval-after-install 'plz
    (straight-use-package
     '(ement :host github :repo "alphapapa/ement.el")))
  (eval-after-load 'plz
    '(require 'ement nil nil)))

?

Why does installing ement.el already throw an error that it's missing plz.el (although it's apparently not "required" yet)?

The dependencies are required to build the package prior to it being loaded.
The error you posted happens during recipe conversion:

straight--convert-recipe: Could not find package plz. Updating recipe repositories: (org-elpa melpa gnu-elpa-mirror el-get emacsmirror-mirror) with ‘straight-pull-recipe-repositories’ may fix this

Straight is looking for the recipes for ement's dependencies.
It does not find plz becuase there is no registered recipe in any of the recipe repositories.
Providing that recipe as described in the previous comment will bypass that error.

Why does [package installation take place before use-package's package configuration forms]?

This is the consistent with use-package's :ensure keyword behavior. e.g.
(use-package test
  :after before
  :ensure t)

Expands to:
(progn
  (use-package-ensure-elpa 'test
                           '(t)
                           'nil)
  (eval-after-load 'before
    '(require 'test nil nil)))

See also this related issue:
https://github.com/raxod502/straight.el/issues/235

If you have any more questions, feel free to comment and we can reopen this issue.


develop/README.md: Fix link

Fix link to develop/docker-compose.yml which had square brackets and
parentheses interchanged.
https://github.com/msabramo/docker-registry-frontend/blob/develop_doc_fix_link/develop/README.md

Thank you.


Feature/nav 173 results and discussion limitations

A first version of the limitations.
@Brunner246 Can you check if the last two parapgraphs about the RAPTOR in C++ are correct?

PS: We are not able to route on the GTFS of germany... somehow there are many invalid references. But it could also be a bug on our side. I would suggest fixing this or omit this in the thesis.

@munterfi i would not start refactoring/bugfixing 2 days before submition 🙃

PS: We are not able to route on the GTFS of germany... somehow there are many invalid references. But it could also be a bug on our side. I would suggest fixing this or omit this in the thesis.


New metric: Perceptual Path Length

What does this PR do?
Fixes #1933

Before submitting

[ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?
Make sure you had fun coding 🙃

:books: Documentation preview :books:: https://torchmetrics--1939.org.readthedocs.build/en/1939/

@Borda, @justusschock please re-review. After a second look at this, we already had a lot of the needed functionality already, so torch-fidelity is no longer needed for the implementation (only testing). A bit of code needed to be copied, but I have linked where needed to original implementation.

After a second look at this, we already had a lot of the needed functionality already, so torch-fidelity is no longer needed for the implementation (only testing). A bit of code needed to be copied, but I have linked where needed to original implementation.

I am fine with the code, my only concern is the dependency, can we somehow use the released package? what we really need form the master branch?

It's no longer a dependency of this metric, only torchvision is needed.
But we need it for testing to compare against. And we specific need master because the addition of PPL in torch-fidelity happened after latest release


Editting a page with dependent pages "modifies" dependent pages

When a page is edited which has dependent pages attached to it, the dependent pages have the "modified" tag pop up on them, this can be confusing for content editors.

This should be fixed in 4.0; There is a lot less recursive-publishing now that all images and links are shortcoded only.


wip: Fix generation

Fixes #508

/reopen

I think this is an environment specific issue, I just cloned jobset into tmp/ and ran make generate and it worked. Last time I saw make generate failing it was due to a missing GOPATH.

Yea I just don't understand why if I change v1alpha2 -> v1alpha1 or v1alpha2->v1beta1 it works without issue.
My gopath is set (I use gobrew so it points to 1.22.2 version).

/close


Date Picker is not being bootstrapped

Hi,
I am using following json but date picker is not being bootstrapped.
{   "schema": {     "client": {       "type": "object",       "title": "Client",       "properties": {         "forename": {           "type": "string",           "title": "Forename",           "minLength": 3,           "maxLength": 10         },         "gender": {           "type": "string",           "title": "Gender",           "enum": ["male", "female"]         },         "dateOfBirth": {           "type": "string",           "title": "Date of Birth"         }       }     }   },   "form": [     {       "key": "client.forename",       "title": "Forename"     },     {       "key": "client.gender",       "title": "Gender",       "titleMap": {         "male": "Dude",         "female": "Dudette",         "alien": "I am from out of space"       }     },     {       "key": "client.dateOfBirth",       "title": "Date of Birth",       "type": "date",       "fieldHtmlClass": "date"     }   ],   "value": {     "client": {       "forename": ""     }   } }
I am calling following jquery method in java script as well but of no use.
$('.date').datetimepicker();
It is currently rendering as per below image.

Where as I would like it to render as per below image, including a calendar image

Can you please provide guidance on how to achieve? I have tried setting "fieldHtmlClass" but of no use?

I'm closing this since it's relevant to the external plugin you use. Feel free to reopen if there is a bug in JSONform


glTF Material Variants are broken

Describe the bug
The "Display Variant" button has no effect after creating variants and assigning different material properties to them. Tested on the default cube. Am I doing it wrong?
To Reproduce
See video:

Version

OS: macOS
Blender Version: 4.2.1 LTS
Add-on Version: 4.2.60

Additional context

Previous Blender versions were affected too
Info panel does not show any errors

Hello,
You have to use 2 different materials, 1 for each variant.
If you assign the same material in each variant, we you modify the material, it is modified in each variant because there is only 1 material shared by multiple variants.
Closing this ticket


fix: set correct availability zones for us-east-1 and us-east-2

please merge this commit to fix us-east AZs

Closing since it wasn't merged and I don't personally need this anymore. Feel free to manually re-apply the changes as you wish.


Check for nil before accessing Status

Add nil check for Cillium property before accessing the Status
Fixes: #4256
Signed-off-by: Mark deVilliers<EMAIL_ADDRESS>

This change is

@mdevilliers Thanks a lot for your PR :tada:


Member search without needing filter opened.

Is your feature request related to a problem? Please describe.
When wanting to search for members for a value, I don't often know where I need to look or if I need to look in the production code (which as have many thousands of members).  Opening a filter over production RPG source takes a bit of time and feels like a waste just to search.
Describe the solution you'd like
Some menu item or action that brings ups a prompt that requires me to fill out the search items and then trigger the search function.
Describe alternatives you've considered
I do like the quick prompt popup but for this, I think it would fit best like an action prompt form.   If its an action-style form please have the Enter key trigger the functionality.
Additional context
I am not concerned about the length of time it might take to perform the search, I would like to just get it to start and then go back to something else which the search is cooking.
Thanks, Matt

@m-tyler Just to be clear, you're talking about a member name search and not member content search - right?

I mean a member content search just like done with the right-click option on a source file.  I just want to be able to specify the (IASP?) library and file without needing open a filter to do it.

@m-tyler Now I am following along. The reason you can't do that right now is because out search function grep does not return the source type in the result (it returns everything as .mbr instead). If we can get around that limitation (e.g. finding the source type/attribute) with a fast performing system call, then we can easily do it.

ah yea, I never noticed the return results list from grep before.
Well, thanks for entertaining the idea.

There isn't much we can do about this due to the reasons I specified above. I will close for now.

@m-tyler Hello, just wanted to let you know that with the new release 1.7.4 of the extension, it is now possible to search members and streamfiles without using any filter.
Now we just need to fix your problem #1082 so you can open the members from the search result...! 😄
HTH.


Import multiple envs when importing OpenAPI3

When the OpenApi file to import contains multiple servers, import each one as an environment.
Closes #3627

Really looking forward to using this, thank you!

Thank you for the PR! A couple of notes, namely the _id and name generation for the sub-environments.

I also hope to have this improvement in Insomnia.

This feels very necessary to work with insomnia when our primary source is OpenAPI. Is there a problem with the PR?


Refactor selectedBudget to use DataState

Right now, it uses nullability to indicate the unloaded state.

No. We don't want to do this. 🙄 😅
The budget list is already data-state'd … which one is selected should just be a value.


Make function to return random input?

Might look a little clearer

function in mutations.py
default return 1 child, but param to return N number

Could send GP class structure, wouldn't need to send AST and ins, just the structure.


Handle kdims referencing multi-index in dask

Since dask dataframes do not support multi-indexes the current code does not detect when a multi-index is referenced. The only way of checking whether the multi-index exists is to speculatively reset the index (which is almost free when using dask) and check whether the columns exist on the reindexed dataframe. This code now resets the index and uses the reindexed dataframe if the columns are present there (otherwise the validation code will complain about missing columns as before).

[x] Adds unit tests

Ready to merge once tests pass.

Looks good though I think it is worth adding a comment to the code to explain the approach (i.e '# speculatively reset index to detect....' or something similar).

Looks good and the addition of the comment definitely shouldn't affect the tests. Merging.


Matlab/Julia/Python: Improved data logging functions

Is your improvement request related to a problem? Please describe.
Right now data variables can only be fetched from hopsanc interfaces (Matlab/Julia/Python) through the getDataVector function, which works for only one variable. This is not very nice if you want to log all variables from the simulation.
Describe the solution you'd like
New functions:

getAllDataVectors
disableLogging
enableLogging

The two latter functions should enable or disable logging for specified variables, preferably using wildcards.

While using the python API I have noticed that the variable port names are hard to determine correctly.
For example, if we use the getDataVector() function incorrectly, the error states,

Component name, port name and variable name must be specified.

If the component name is incorrect then all the components in the model are printed for the user. This is useful.
An improvement would be that in the event that the port is incorrect that all the ports for the component are listed. Same with the variable.
In other words, if the user enters an incorrect component - list all components. If the user enters a correct component but incorrect port, list the ports for the correct component, and if the component and port are correct but the variable is not, then list all the available variables for the given component port.

While using the python API I have noticed that the variable port names are hard to determine correctly.
For example, if we use the getDataVector() function incorrectly, the error states,

Component name, port name and variable name must be specified.

If the component name is incorrect then all the components in the model are printed for the user. This is useful.
An improvement would be that in the event that the port is incorrect that all the ports for the component are listed. Same with the variable.
In other words, if the user enters an incorrect component - list all components. If the user enters a correct component but incorrect port, list the ports for the correct component, and if the component and port are correct but the variable is not, then list all the available variables for the given component port.