Reduce the binary size needed for build reusing

Currently the entire target directory is needed when reusing build on another machine. This is quite a setback for us because previously we only need to transfer a specific test binary under target/debug/deps/ generated by cargo test --no-run.
I'm wondering if it's possible to reduce the binaries that must be shared between two machines, and make this information easy enough to use. Or better yet, package the necessary test artifacts by nextest itself.
This would be especially useful for test partitioning. For our use case, test cases from one large repo are sharded to tens of partitions. With this feature, each partition wouldn't have to download all the test binaries.

Thanks for the report and I'm really excited to hear about how many partitions you use! I think working on this would be really cool.
Even today, you can definitely just transfer the binaries you need over as long as you maintain the directory structure -- the current recommendation is a really conservative overestimate, since we've found that some tests do need other files in the target directory.

Or better yet, package the necessary test artifacts by nextest itself.

This would be a fantastic addition. Maybe by adding an archive command, and allowing the run command to accept a --test-archive flag.

For our use case, test cases from one large repo are sharded to tens of partitions. With this feature, each partition wouldn't have to download all the test binaries.

So this is a separate feature request, which is to allow partitioning by binary (the current partitioning/sharding implementation uses both binary and test names as inputs). That's not done by nextest at the moment but can be added as an option (maybe as part of filter expressions).
How about we try solving the archive problem first and then see if binary partitioning is still required for you?

the current recommendation is a really conservative overestimate, since we've found that some tests do need other files in the target directory.

Yes, I thought of that too. But it's not very easy to leverage it at the moment, because (1) there is no public documentation to guarantee it's safe and stable to use; (2) it doesn't work well with partitioning (we don't know the exact binaries referenced by a certain partition). So I think adding the archive option is probably a more natural solution.

How about we try solving the archive problem first and then see if binary partitioning is still required for you?

That would be awesome! I'd love to help.

Thanks! I'm working on this now, hope to have something in the next couple of days.

BTW are you using nextest over at Pingcap?

Not at the moment, we are still hand-partitioning the test binaries. But I want to push for adoption if this issue is resolved. The flaky test retry feature is something we'd love to use.

@tabokie I just released cargo nextest 0.9.15 (it should show up via the release URLs in a few minutes). See https://nexte.st/book/reusing-builds.html#creating-archives -- would be interested to hear how this works for you!

@sunshowers I tried it out, it looks very promising (the filtered files are still a little bloated though, look forward to some improvements there). But unfortunately I hit a bug, the issue is here: https://github.com/nextest-rs/nextest/issues/247.

Thanks, I'll try and fix that (and improve the error message) in the next couple of days. Looks like the grpcio-sys library is producing linked paths that don't exist on disk, fun.

Hi @tabokie -- just released cargo-nextest 0.9.16, with a workaround for this issue (now prints a warning and suggests fixing this upstream rather than failing). I also reduced the size of the archive by not recursing into subdirectories of linked paths (I tried it with raft-engine and it appears to shrink the archive by around 3-4x).

That's awesome! I'll try using it in our main repo tikv next week.

Could you update the thread when you get a chance? I do believe this is overall done—would be happy to take further suggestions as code contributions though.


Update Requirements

This pull requests adds the following packages to the requirements:

flask_wtf
email_validator

I needed to install these additional packages in order to run the flask server without errors.
Thanks for writing such a neat application!

Thanks for the fix!


Failed to display Jupyter Widget of type VBox

Hi All,
When Trying to use ipyvolume with juptyter notebook I always get the error message :
Failed to display Jupyter Widget of type VBox.
If you're reading this message in the Jupyter Notebook or JupyterLab Notebook, it may mean that the widgets JavaScript is still loading. If this message persists, it likely means that the widgets JavaScript library is either not installed or not enabled. See the Jupyter Widgets Documentation for setup instructions.
If you're reading this message in another frontend (for example, a static rendering on GitHub or NBViewer), it may mean that your frontend doesn't currently support widgets.
However when running all the instructions in the Jupyter Widgets Documentation, the error still occurs. Did anynone have a similar problem or does know how to solve this? Would be happy for any suggestions. Thanks in advance.

Hi, did you solve the issue?


New Skin server and Username Capitaling

Hi, I changed it to the correct skin server and added and username case fixer.
This is completely untested code, I edited it from a project I started a while ago: https://github.com/tenten8401/MineAvatar

Thanks for the PR, but the problem with the new URL is that it requires CURL FOLLOW_LOCATION to be enabled, and allowed on the server. You see http://skins.minecraft.net/MinecraftSkins/jamiebicknell.png redirects to http://textures.minecraft.net/texture/3c8bd98d9d5d3912c9f7e925bcd88abecc4c32bcc57972e13f07ebbf9bc0
I can't find any official documentation of the Mojang API either, other than http://wiki.vg/Mojang_API but even that doesn't look official. It looks like it's a private API, that's been reverse engineered.
Will investigate further

After further investigation I still can't see any official mentions of the correct URL for the skin, so based on the fact the Amazon S3 URL has worked for around 2 years I'm going to keep it the same for the time being...
However, following the Mojang API (still unsure whether official and/or stable), I can query the API to get the UUID based on username, then query the API again to get textures for that UUID, which returns the correct URL for the skin that doesn't need FOLLOW_LOCATION enabled.
The issue with this is this route are:

3 HTTP requests instead of just one (increased load time)
You can request the same profile only once per minute due to the API limit (potential of getting server banned from API)
Potentially

The benefits would mean:

Avatar / skin would show the most up to date version, as current method takes some time to update, and this is the same with other Avatar services like Minotar.net
Username automatic capitalisation fixing so that user doesn't have to enter the username in the exact same case
Better computability on servers that disallow FOLLOW_LOCATION

Another more suitable option would be to just use http://skins.minecraft.net/MinecraftSkins/USERNAME.png and then manually code in the FOLLOW_LOCATION bit to get the skin URL directly. The bonus of this too is that it automatically fixes the username capitalisation and doesn't apply to any API limits.
Thanks for bringing this to my attention, I'm going to update the files to use the latter method, and do some serious testing, and also build in support for 3 pixel width arms too, as I seemed to have missed that announcement.

Really need the new servers. The skins isn't chaning on amazonaws...

I'll be finishing the code off tomorrow, but I'll need to do some serious testing to make sure it works as it should and there aren't any API limits enforced. So overall probably end of the week before it's on the master branch, providing I don't encounter any issues.
If you need to use it in the meantime and your server allows FOLLOW_LOCATION just add that CURL option, and change the old URL on line 18 of face.php and line 16 of skin.php. I can't promise it'll work and can't promise it'll be stable, but until I complete my code and test it full, it's the best I can do.

Thanks, it works like a charm when using FOLLOW_LOCATION :)

Yeah, I'm hoping it's not rate limited too. If you do encounter any 404's or messages like that, please do let me know. My solution won't need FOLLOW_LOCATION either, which means better compatibility on servers.


ci(clang-tidy-differential): point to the new config

Description
This new config file we are pointing is located atautoware/main/.clang-tidy-ci.
It is supposed to be less restrictive to make it a required check.
And we will make it more strict over time as we adjust existing code to adhere these new standards.
Related links
Follow up from:

https://github.com/autowarefoundation/autoware/pull/4918

Parent discussion:

Proposal to enable clang-tidy as a required CI for Autoware #4876

How was this PR tested?

https://github.com/autowarefoundation/autoware.universe/actions/runs/9697046266?pr=7729

Notes for reviewers

https://github.com/autowarefoundation/autoware.universe/pull/7729/files#r1657097594

Interface changes
None.
Effects on system behavior
None.

@veqcc it failed the test:

https://github.com/autowarefoundation/autoware.universe/actions/runs/9697046266/job/26761095747?pr=7729#step:9:447

I think you need to either:

update the config file in autoware/main/.clang-tidy-ci
or fix the packages to conform to the new rules
before we can make it a Required workflow.

@xmfcx

@veqcc it failed the test:

https://github.com/autowarefoundation/autoware.universe/actions/runs/9697046266/job/26761095747?pr=7729#step:9:447

I think you need to either:

update the config file in autoware/main/.clang-tidy-ci
or fix the packages to conform to the new rules
before we can make it a Required workflow.

Thank you for informing me!
I have confirmed the workflow result. It seems the clang-tidy just warns and invokes no errors, which is the expected behavior.
I have to check why the Run clang-tidy step ends up with exit code 1. I'll do it tomorrow 👍

I have to check why the Run clang-tidy step ends up with exit code 1. I'll do it tomorrow

https://github.com/autowarefoundation/autoware-github-actions/blob/6c71a4d6718a29d385cfb22ce6ac94ad1ad8f543/clang-tidy/action.yaml#L129

clang-tidy -p build/ -export-fixes /tmp/clang-tidy-result/fixes.yaml ${{ steps.get-target-files.outputs.target-files }} || true

https://github.com/autowarefoundation/autoware-github-actions/blob/6c71a4d6718a29d385cfb22ce6ac94ad1ad8f543/clang-tidy/action.yaml#L148-L152

    - name: Mark the workflow as failed if the fixes.yaml file exists
      if: ${{ steps.check-fixes-yaml-existence.outputs.exists == 'true' }}
      run: |
        exit 1
      shell: bash

This is the reason it is making the job fail. I'll leave the rest to you.

This is the reason it is making the job fail. I'll leave the rest to you.

I have fixed in https://github.com/autowarefoundation/autoware-github-actions/pull/306


Tag management

@yakky or @jrief we have a weird tag system where 2.x tags and 3.x tags are around, can those be deleted? It creates now conflict with 2.0.0

Really weird! I just deleted all tags down to 1.0.0 which did have an unrelated revision history.
You should be able to create 2.0.0 now.
Btw.: The proper version string according to PEP 440 would be to tag it 2.0 and not 2.0.0.


Change name network_interface_id

Change name from repeated string network_interface_id = 2; to network_interface_ids?

Changed by commit bfe691b.

Changed by commit bfe691b.


i105 export django model data

Change Summary
Can now export user data from django endpoints. Password not included and users without consent are not exported.
Change Form
na

[x] The pull request title has an issue number
[x] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

Other Information
no
Related Issue

Resolve #105

Hi, I don't think I have fixed all the errors yet, I still need to do exporting team data, that one is easy but in the Users.csv, you want team name instead of team_id right, right now it changes all the team_id so.... we still need work on that

Hi, I don't think I have fixed all the errors yet, I still need to do exporting team data, that one is easy but in the Users.csv, you want team name instead of team_id right, right now it changes all the team_id so.... we still need work on that

oops, my bad. Let me know when its all good

Hi, it should be all good now. Could you please confirm?


What did you used for training target / tutor signal?

Dear authors,
Recently we planned to used your model to evaluate the illust generation performance in our paper.
But, I could not found what did you used for target in the training process.
Danbooru2020 tag["score"] or tag["favorite"]?
I am looking forward to your responce.
BEST regards,

This model was trained using images from 3 sources that were scored by people, so the model uses image path and rating for retraining.

But not sure how that would evaluate your paper, unless it is about making gens look better pre or post process. Otherwise, it can only tell you how much the people that graded the original model this runs on would like them or not from 1-10.
Keep in mind this was trained on gens and no gens, so it does a poor job on gens only, since it over scores them down.


build: add tests extras & update developer_docs.md

Description
Since the only option to setup a development environment was via conda and not all the users don't use conda, I've included the extra dependencies to run the tests as extras, to be able to easily install those via pip without forcing the users to rely on conda.
Besides that, I've also included some more information in the developer_docs.md to make it easier for the users to install everything and run the tests locally.
Additionally, while tackling this PR, some other minor things have been spotted and solved in other PRs:

https://github.com/argilla-io/argilla/pull/3015
https://github.com/argilla-io/argilla/pull/3012
https://github.com/argilla-io/argilla/pull/3105

Type of change

[X] Improvement (change adding some improvement to an existing functionality)
[X] Documentation update

How Has This Been Tested

[x] Tested in Python 3.8, 3.9 and 3.10 by installing everything as pip install -e ".[server,postgresql,listeners,tests]" and then running pytest
[X] Tested that conda installation still works fine

Checklist

[X] I have merged the original branch into my forked branch
[X] I added relevant documentation
[X] I made corresponding changes to the documentation
[X] My changes generate no new warnings

Hey @alvarobartt, LGTM! This will be really helpful 😄 Maybe it would be good also to mention in the developer docs something about the dependencies needed to be installed to be able to build and install psycopg2.

Sure, thanks for the feedback @gabrielmbmb! I'll push a couple more commits and ask you to re-review 😄

cc @gabrielmbmb this works fine up until Python 3.10, I've tested in 3.11 and it doesn't work well, I guess it's related to psycopg-binary and some required dependencies in macOS, can you please check? Thanks


{vorfinal} is still in the relations search view

https://viecpro-frontend.acdh-ch-dev.oeaw.ac.at/de/search/relations?page=1&facets=source_kind:=[`Person`]%26%26target_kind:=[`Place`]
Thas coming from the viecpro_relations collection here is the raw query url.

Just saw that its also still in some tables. Ege here its in Verwandtschaftsverhältnissen


[Enhancement] Log more information when the docker-machine command fails

Triggered by bug report #78.
Currently, when the 'docker-machine' command fails, we only logs
"exit status 1'
Which is not very helpful in root cause analysis.
With this patch, the 'docker-machine' command's stderr output is also
logged.
To cause docker-machine command fail
$ export DOCKER_MACHINE_NAME=xx
$ k3d create
2019/06/13 16:45:31 Created cluster network with ID 6fc91e0e5e912443e6b847f113a6a0bb85ccd610e5232592296d4b199f0347cf
2019/06/13 16:45:31 Error executing 'docker-machine ip'
2019/06/13 16:45:31 Docker machine "xx" does not exist. Use "docker-machine ls" to list machines. Use "docker-machine create" to add a new one.
exit status 1

a) give the user the option to disable the check for docker-machine (e.g. in hybrid environments)

The docker client is also controlled by this environment variable in a hybrid environment, so disable check k3d will not work right in a working environment.

b) if we fail to execute docker-machine, ask for confirmation to try without it or simply do it
?
I agree. There is room for further improvement. I will work on a follow on PR.  I am not a fan of user confirmation since some people may want to use k3d in a script.

Thanks for the review!


Enable breadcrumbs on the maintenance page

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the change
Turn breadcrumbs on on the maintenance page

@spryor,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Please update handlebars

Version 4.0.x of handlebars has an update for its version of uglify-js, to avoid this vulnerability.  (The current version in package.json is only "handlebars": "^2.0.0".)
FWIW, I attempted to update packages myself and submit a pull request, but even before I changed anything, I could not get the tests to pass (12 failures), and so I gave up.

I think we don't use uglify from handlebars, but update won't hurt.. We need to know what are the breaking changes between handlebars 2.0.0 and 4.0.0. Hm?

Yup, we don't use "min" option from handlebars.

https://github.com/wycats/handlebars.js/blob/master/release-notes.md, specifically the "Compatibility notes" sections

We use handlebars as so:
    cache[name] = Handlebars.compile(contents, {
        noEscape: !escape
    });

And I can't find docs for noEscape, though. We need to make sure we handle it. PR is welcome.
@plynchnlm What were the error messages in tests? What's your platform?

My platform is RHEL 6.7.  BTW-- It is now 4.0.5 of handlebars that is needed to avoid another vulnerability.  After changing package.json to use 4.0.5, the errors messages (from the tests) are as below.  I was thinking someone familiar with the bower code would be better able to resolve them.

StandardRenderer outputs help command log:
RangeError: Invalid array length
at Object.assignToHash (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:759:22)
at Object.compile (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:113:27)
at Object.compileChildren (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:794:49)
at Object.compile (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:97:10)
at Object.compileChildren (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:794:49)
at Object.compile (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:97:10)
at Object.compileChildren (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:794:49)
at Object.compile (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:97:10)
at compileInput (node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:516:53)
at Object.ret [as std/help-generic.std] (node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:523:18)
From previous event:
at Object.exports.capture (test/helpers.js:253:30)
at Context. (test/renderers/StandardRenderer.js:755:24)

integration tests bower runs bower installation:
Uncaught RangeError: Invalid array length
at Object.assignToHash (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:759:22)
at Object.compile (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:113:27)
at Object.compileChildren (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:794:49)
at Object.compile (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:97:10)
at Object.compileChildren (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:794:49)
at Object.compile (node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:97:10)
at compileInput (node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:516:53)
at Object.ret [as std/help.std] (node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:523:18)
at render (lib/util/template.js:20:27)
at Object.render (lib/util/template.js:30:12)
From previous event:
at withLogger (lib/commands/index.js:41:10)
at Object.command [as help] (lib/commands/index.js:20:16)
at bin/bower:80:33

integration tests bower "after all" hook for "runs bower installation":
Error: expected '\u001b[2K\u001b[0G    \u001b[31m  2) runs bower installation\u001b[0m\n' to contain 'Usage:'
at Assertion.assert (node_modules/expect.js/index.js:96:13)
at Assertion.string.Assertion.contain (node_modules/expect.js/index.js:410:12)
at Context. (test/commands/bower.js:28:25)

We don't use uglify feature of handlebars so vulnerability doesn't affect us

@plynchnlm @sheerun If uglify is the main issue when it comes to the vulnerability and Bower does not use it, is this an open issue?

I'm closing this because it doesn't affect us, but if someone manages to update handlebars, and sends a working PR, I'd accept it.


Parse configs in parallel

Fixes: #1867
The most efficient way is with nested parallel streams
There is a slight speed improvement. I'm including the config parsing time reported by kompile -v
EVM: 1.0s, down from 1.6s (3 configs)
Algorand: 6.1s, down from 8.6s
I've tried creating FutureTasks directly with the exact dependencies to send to the ThreadPool, but that made the code look a lot uglier and no speed improvement.
This doesn't entirely fix the problem with extra scanners being generated, but I'm fine with that. The extra scanners are not that expensive anyway. Here is the output for a simple test file:
First time
Outer parsing [58 modules]                                   =  0.728s
New scanner: TEST-CONFIG-CELLS                               =  0.138s
New scanner: STDIN-STREAM-CONFIG-CELLS                       =  0.211s
New scanner: STDOUT-STREAM-CONFIG-CELLS                      =  0.206s
Parse configurations [3/3 declarations]                      =  0.452s
New scanner: TEST-RULE-CELLS                                 =  0.121s
New scanner: STRING-KORE-RULE-CELLS                          =  0.197s
New scanner: STRING-COMMON-RULE-CELLS                        =  0.195s
New scanner: K-IO-RULE-CELLS                                 =  0.281s
New scanner: STDOUT-STREAM-RULE-CELLS                        =  0.285s
New scanner: STDIN-STREAM-RULE-CELLS                         =  0.311s
Parse rules [101/101 rules]                                  =  0.575s

second time:
Outer parsing [58 modules]                                   =  0.750s
Parse configurations [0/3 declarations]                      =  0.263s
New scanner: TEST-RULE-CELLS                                 =  0.121s
Parse rules [0/101 rules]                                    =  0.251s

I think the code looks simpler this way.
For rule parsing, you have scala threads and java threads, and auto detection if you need to build a new scanner.
Config parsing is simpler, one scanner per module and rarely multiple configs per module.
I've tried multiple implementations and found that this performs the best, and it's the shortest piece of code I could come up with.

I mean, if this really performs better than the alternative, then that's fine, but I need more persuasion. I need to see the code modeled after the rule parsing code that you tried, so I can make sure it looks right to me, and then I need to see the performance numbers of both versions on the Algorand semantics.

It would also be good to try to test a contrived definition with like, 50 modules, each containing 50 configurations, to make sure it doesn't deadlock. I could easily see this doing exactly that, theoretically speaking.

@dwightguth I concede. Using two thread pools seems to work well enough for our situation.
There is some thread contention but the 'correct' solution would be to create tasks that never have to wait for another thread to finish. Then handle all the synchronization from the main thread. The implementation will look ugly.


Hydraulics import

Please write the logic to import hydraulics from HDF files for both steady and unsteady.
Please speak with @Brennan1994 about the details.

I would like to amend this language to say, please write the controls and VMs to import steady and unsteady. There will need to be a new VM  and Control for each of these. We should still discuss the details when you're ready @codymccoy

My notes from a meeting with Brennan:

This task is mostly done. I am waiting on Brennan to fix a file/folder browser bug where it is setting the path twice. I also am waiting for my latest change to get merged into framework where the file browser checks if the ok was clicked before setting the path. Also waiting for Brennan to figure out how to use RasMapper to get the list of strings for "Steady". Right now i am using a dummy list of strings.

It looks like we're looking for a single .hdf when attempting to import unsteady hydraulics. Instead, we should be looking for a folder that contains 8 .hdfs

looks like the dummy list of strings is cody kayak and test, right?

yes


feat(jsonschema): add strictness setting that controls whether additional fields will be allowed

Current dependencies on/for this PR:

main

PR #40   👈

This comment was auto-generated by Graphite.


Link to StackdriverLogging

Let's link to https://github.com/Brainfinance/StackdriverLogging by @jordanebelanger
Would you want to submit a PR adding a link to it to the https://github.com/apple/swift-log#selecting-a-logging-backend-implementation-applications-only section @jordanebelanger?

Fixing back milestone to 1.1.2 where this was merged and closing.


ADF, AKV, and RBAC model

When using Key Vault as a linked service in a Data Factory, can the Key Vault use the RBAC model of access instead of the Access Policy model?  In other words, can the Data Factory managed ID be granted an RBAC role to gain access to the vault instead of having to use an Access Policy.

@SteveColegrove Thanks for the question. Are you referring to any document from the ADF service that could help us direct this query to the correct team. If Yes, could you please post the link here?

Hi @SteveColegrove Yes, you can use RBAC to grant ADF to access the key vault. Please note the the RBAC access for Key vault is public preview and not recommend to use production environments until it goes GA.
For more info please refer to this doc: https://docs.microsoft.com/en-us/azure/key-vault/general/secure-your-key-vault#resource-endpoints

I have tested ADF to access Key Vault using RBAC and it works as expected. Please make sure to provide the appropriate role assignment to ADF.
Hope this helps.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply and reopen the issue. We will gladly continue the discussion.


Enables running of multiple tasks in batches

Description
Implements batching with worker-side batch methods.
Motivation and Context
Sometimes it's more efficient to run a group of tasks all at once rather than
one at a time. With luigi, it's difficult to take advantage of this because your
batch size will also be the minimum granularity you're able to compute. So if
you have a job that runs hourly, you can't combine their computation when many
of them get backlogged. When you have a task that runs daily, you can't get
hourly runs.
For the user, batching is accomplished by setting batch_method in the parameters
that you wish to batch. This takes a list of parameter values (already parsed)
and combines them into a single parameter. You can limit the number of tasks
allowed to run simultaneously in a single batch by setting the class variable
batch_size. If you want to exempt a specific task from being part of a batch,
simply set its is_batchable property to False.
Unlike #1538, this does batch combining on the worker side, allowing arbitrary
batch methods and keeping better track of task ids for things like execution
summary.
Have you tested this? If so, how?
Added many unit tests. Will test this in production if I get an okay on the idea.

Ok. This looks more promising for every iteration. Thought caught my attention the most is that it seems like batch_mode=my__pure_python_func is strictly stronger than the decorator method that you also have created. Why wouldn't one just use something like batch_method=(lambda x: x) or batch_mode=list?

Instead of batch_mode=list, you'd need something like batch_mode=flatten as otherwise you'd have a list of lists. You'd then also need to implement parsing and serialization to handle lists and worry about escaping your separators, etc. I agree that just setting batch_mode=function would be better but unfortunately list parameters are tricky. Maybe we should just leave this feature out?

It's basically the same problem we had previously with list parameters, it's difficult to do with just a single argument.

Are there any more issues with this? I think I've addressed them all.

Starting to look good. I would like to get this in and then release 2.4.0. There's a lot of new cool features added recently. :)

Thanks so much for all the comments! I'm very excited that we're finally going to get this feature into Luigi. It'll be very nice to end the ~2 years of having a significantly different fork.

Hi @daveFNbuck, I was hopeful to start using this. But in my case I would actually need something like the batch_tuple_parameter you had described here. I have an idea for a slightly different and hopefully even better API I'm willing to implement, but I couldn't find your original implementation. I see the docs in a commit here, but I don't see the code being in that commit.  Please push a branch if you have anything. Otherwise I can re-implement it.
My thought for api could be something like:
class MyTask(luigi.Task)
     city, cities = batch_tuple_parameter(ChoiceParameter)(choices=('stockholm', 'hcmc'))

Where you still do luigi MyTask --city stockholm and MyTask(city='hcmc'), but within run you aren't supposed to touch self.city but only self.cities.
Would this make sense? Perhaps we should even recommend _cities as to clarify that you can optimize your task by batching really shouldn't affect the API.

@Tarrasch sorry I didn't notice your comment until now. I don't think I have the implementation anymore. I like your idea, as it would simplify an issue I have where I can't batch tasks that have standardized parameters.


URI Too Large Errors

Came across this issue when our security tags started getting large. It appears that the headers sent to algolia are being inlined as query params in the url. This can be seen on line 74 here. When I removed those and put them in the request header I only received a 400 when the header x-algolia-agent was removed from the query params. Leaving just that one in the query params and moving the rest to request headers solved my issue.
I'd like to understand why these headers are being inlined into the url so that I might be able to supply a patch for this issue. Also any documentation on required headers/query params would be awesome as I could not find any.

Hi @pthurlow, could you maybe send here a CURL like command that results in an error when your security tags are too big? If this is not OK given the security of your application, please send this to<EMAIL_ADDRESS>(and mention me and algolia javascript client)
You can get a CURL like command from the network tab in chrome, right clicking a failed request and "copy as CURL".
We recently updated the way we provide security at Algolia and you can now always use secured API keys: https://www.algolia.com/doc/guides/security/api-keys.
Those keys will then be sent in POST when doing searches if the key is too big.
Since then, I am interested in seing what's inside your query.
As for the reasoning, we only put in the HTTP headers, headers that are considered as "simple HEADERS" given the XHR spec: https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Simple_requests
That way, we can avoid doing an extra OPTIONS request in browsers.
Let me know how it goes.

I sent an example request header to your support.  When you say "Those keys will then be sent in POST when doing searches if the key is too big" do you just mean the request is made as a POST rather than a GET? If that is the case this problem will still persist because this is nginx or other server limits on URI request length. Ideally these keys would be inserted into the body to avoid this issue altogether, but as I mentioned it appears the js client is simply inlining all security tags and api keys into the header.

After a bit more digging I think I've found the issue. The logic which determines whether to stick the apiKey into the body seen here assumes that the body object contains a params field. However this is not the case for non fallback requests as there is a query request array on the body with the params field on each array element.  This is done here
If I remove the check for body.params it correctly inserts the api key into the POST body. So maybe you can advise on the best course of action for a fix.
as a related issue, we also use the setSecurityTags() method to send what we thought were required security tags by the api so it can compare it to the encoded api key. This also causes issues because it appears this header cannot be stuck in the post body like the api key (i tried but it didn't recognize any names i guessed, heh). since security tags are long just like the api key this causes the same URI too large issue but there is no discernible way to put them into the body. Of course, when I tried just not sending the security tags it still worked! so I supposed those are not required after all (maybe you can comment on that)

After a bit more digging I think I've found the issue. The logic which determines whether to stick the apiKey into the body seen here assumes that the body object contains a params field. However this is not the case for non fallback requests as there is a query request array on the body with the params field on each array element. This is done here

It seems not to be an issue with "fallback requests" but an issue being that requests done using client.search() will not have their API keys inlined when too big.

If I remove the check for body.params it correctly inserts the api key into the POST body. So maybe you can advise on the best course of action for a fix.

I will fix this and release.

Of course, when I tried just not sending the security tags it still worked! so I supposed those are not required after all (maybe you can comment on that)

Yes there's no more a need to use setSecurityTags if you already generated a secured API key with all the tags. All our security features are now provided by secured API keys and can be found here: https://www.algolia.com/doc/guides/security/api-keys.


Apply QA API  implementation feedback

Description

WIP for apply https://github.com/tendermint/liquidity/issues/173 feedbacks
WIP swagger v2.2.1

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

To apply some urgent modifications first, we will merge first and continue the rest in other PRs.


cli browser-sync refresh with white screen

When saved. browser-sync refresh itself with white screen (or blank).
Need manually refresh. Kinda annoying.

@plugza You should be clearer. Let me know what's going on. What do you want to do?

@plugza for now, I will close this issue.
Please, if you need help feel free to reopen or open a new!


Build a basic layout (4. Add images to your Android app): Alignment.CenterHorizontally link 404 error

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-add-images?authuser=1&continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-1-pathway-3%3Fauthuser%3D1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-add-images#8
In which task and step of the codelab can this issue be found?

click "Here's a hint: Use the Alignment.CenterHorizontally argument with the wrapContentWidth() function."
Sorry, we couldn't find that page.

Describe the problem
broken link
https://developer.android.com/reference/kotlin/androidx/compose/ui/Alignment.Companion?authuser=1#CenterHorizontally()
Steps to reproduce?

go to URL of codelab above
click "Here's a hint: Use the Alignment.CenterHorizontally argument with the wrapContentWidth() function."
3.see  Sorry, we couldn't find that page.

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Hello @zerexei,
The broken link issue that you presented to us is extremely important, and I thank you for bringing it to our attention. It will be fixed and republished soon.


Fix View Past Events toggle

Currently, we have a check at the bottom of event_list.html to which sets the past events toggle, we should change the check to compare against the new termOrder instead of g.current_term.

 Fix View Past Events toggle #1047

Issue resolved on #1069


Updated examples in Readme

The code said actions: {} but the codepen says reducers: {}
So, updating the readme to be in sync with the actual working code.

Thanks @vishnun, after #127, reducers/effects became actions, and I'm still updating everything. Everything should be in synced soon.

So I'm just using hyperapp today.  I think I remember things in the wiki need revisions too.

Hi @jamen! Yep. Going through those too as we speak. The CodePen examples are out of date because I haven't released 0.7.0, but I intend to do that very soon too.

@jamen That's actually a good point against using the wiki. If we move the docs to master they will always fit the revision you checked out in git.

@dodekeract I don't think the most common use case for hyperapp is to clone the repo.
I prefer a wiki (and will use a wiki from now on in future projects too). This is a decision I reached after more than 200 commits to the now-deprecated user manual and weighing cons and pros in my head. The main reasons I favor public wikis are:

Makes editing docs easy for maintainers. I'd like to commit something and see how it looks and change my mind based on gut and feeling a lot.
Makes editing docs easy for anyone else since they don't have to create a PR. They don't even have to let maintainers know. I like this openness.
It's a GitHub feature and I am using GitHub. If I provide docs in the repo or as a separate document, then I'd have to use the wiki for something else or disable it. Disabling the wiki is also acceptable if docs go on a website, but websites cost incur a cost, whereas using the wiki is "free".

Number 2. above is

@jbucaran The use-case isn't to "clone the repo" the use case is to be able to work with older versions of hyperapp without knowing every single detail.
There'll be issues when we switch from v1 to v2 since we have to destroy the old wiki.

There'll be issues when we switch from v1 to v2 since we have to destroy the old wiki.

No idea what that means.

Okay, I see what you mean.
Hyperapp v1, then v2 changes everything and there would be no v2 documentation.

@jbucaran v2 will by definition have breaking changes compared to v1. We only have one wiki. Having the docs in master means they're always the important ones, no matter which revision you look at.

🤔 I didn't consider that possibility. That definitely poses an interesting problem.
I think this particular project has the potential to avoid that scenario, since I hope to freeze the API with 1.0. If there's a 2.0 there may be new features, but no removal of older ones.
Well, that's not something I'm worried about at this moment, but thanks for opening my eyes.

If there's a 2.0 there may be new features, but no removal of older ones.
not really, IMO, vue and angular actually have some big changes between v1 and v2, you can not always control what software is going on...however, wiki is a good place to place some tutorial that explains concepts and architecture, which mostly will not change between versions, to help users and contributors to undersatnd repo, but api need another place like standalone website.


Right clicking in creative deletes the item your holding

Just a minor bug I found, Right clicking in creative deletes the item your holding

What's your version of Twigs, and what's the context? In the creative menu or in the game world or?


Create ReverseNumber.c

Why:

Closes #https://github.com/codinasion/program/issues/3469
What's being changed:

@grraghav120 please review my code


Avoid unnecessary vsnprintf() calls in log_callback()

mov_read_trak() and mov_read_trun() generate a lot of AV_LOG_TRACE
logs, which are ultimately thrown away. However, log_callback() still
formats and processes them. This causes av_log() to - at least in some
cases I observed with perf record - to take 97% of
avformat_open_input() run time. Improve this by returning from
log_callback() early when a log is obviously not needed.

This sounds like a good idea in general but I have some questions:

if the filtering is already performed in log_callback, why do it as well in log_callback_gil?
your filtering is not identical to the existing one, why the level != lib.AV_LOG_ERROR special case?

Thanks, merged!


Extract Virtual DOM out into its own independent crate

I was having a discussion with @Demonthos on optimizing Yew's rendering performance and came to the conclusion that we should separate static vs dynamic items in the VDOM tree, similar to Dioxux.
Dioxus has done a great job at optimizing it's Virtual DOM. I would like to see it extracted into a separate crate that everyone can use and build upon. This crate should be independent of any frameworks but could/should have concepts of components and such.
If this is something that is wanted, I would be happy to lend a hand in extracting the code and publishing it (preferably in a separate repository)

Our core crate is the closest thing we have to an extracted virtualdom implementation. Anyone should be able to build around it.
https://github.com/DioxusLabs/dioxus/tree/master/packages/core


gitsynch should not auto update repos when there are untracked changes

When the git repo has untracked changes, we should issue a warning along with git status output instead of trying to upgrade the git repo (which could create an infinitive loop and crash)

verified, closed.


increase # cluster

Purpose of PR

Type of PR

[ ] Code changes
[ ] Documentation changes
[ ] CI-CD changes
[ ] YAML changes

Issues Closed or Referenced

Closes #issue_number

LGTM


ND4J compilation time

ND4j javadoc compilation takes so much time now. @saudet can we exclude jcpp-generated classes from javadoc targets somehow?

Or, maybe, speed it up somehow...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 08:26 min
[INFO] Finished at: 2017-11-24T14:23:48+03:00
[INFO] Final Memory: 222M/3008M

Javadoc is pretty slow for any class. I always build with
"-Dmaven.javadoc.skip" for anything. We can put this in some environment
variable, and in bash profile too...

It turns out it takes all my ram during javadoc generation for nd4j-native. 26.5GB is max i've saw there.

@saudet ye, i think we should be able to disable javadoc build by default...

It looks like only windows is affected... On linux memory use is reasonable, somewhere between 1 and 3 GBs

Last time I disabled something like that @huitseeker reprimanded me severely saying that developers should disable things in their own settings. So I'll leave him decide what to do...

+1 on the javadoc memory use for Windows. I'm seeing a very large number of independent JVMs here, and literally the only java-related thing I have running is an ND4J build.

Not a lot of docs out there, but it seems possible to exclude certain packages and individual source files from javadoc...
https://maven.apache.org/plugins/maven-javadoc-plugin/examples/exclude-package-names.html
https://stackoverflow.com/questions/14518220/maven-how-do-i-exclude-specific-source-files-from-javadoc
Every time I build ND4J on windows and forget to include (or simply mistype) -Dmaven.javadoc.skip=true it costs me time (either for the whole build to finish, or to cancel + restart) and has given me OOMs in other things running concurrently.
@saudet @raver119 do we know for sure that this is due to javacpp generated classes only? If so, maybe we just exclude those by default (what would be the path/package to indentify them?)

Javadoc is slow in general, but if you want to disable it only for nd4j-native, adding this to the pom.xml file should work:
           <plugin>
                <artifactId>maven-javadoc-plugin</artifactId>
                <configuration>
                    <skip>true</skip>
                </configuration>
           </plugin>

Though this will create problems when trying to do a release...

Then again, we already have a profile for release, so maybe we could disable the Javadoc plugin for all artifacts, but have it enabled via the performRelease profile. Thoughts, @huitseeker?

The proper way to disable javadoc by default is to set this property -Dmaven.javadoc.skip=true in the ${project.dir}/.mvn directory of the repo.
This requires mvn > 3.3.1 but I believe we otherwise require it anyway.
https://maven.apache.org/docs/3.3.1/release-notes.html

@huitseeker Yes, ok, but you were against disabling SNAPSHOT download by
default, but are you ok with disabling Javadoc by default?

Disabling Javadoc by default will lead to a confused developer that won't find his doc in the right place.
Disabling Snapshot update by default pins the developer/user to an antiquated version of a snapshot dependency, in a silent, invisible state of affairs.

Guys, i'm really sorry, but what we're going to do here? Have you got some sort of conclusion here? :)
Can we disable it by default or not? :)

Well, my preference for the options, in order that I prefer:
(a) disable by default for generated sources (assuming they alone are causing these long build times + excessive memory)
(b) disable for all but maybe nd4j-api
(c) disable for all modules
Regardless of the solution, we override it in the release profiles.


removed evaluate references to test source of issue

Issue was due to invalid download link. Reached out to service owner who rectified the issue.


use-sequence-id-for-XXX-conversation casue send message error Could not get a long value from the invalid response

when config
use-sequence-id-for-group-conversation: true
use-sequence-id-for-private-conversation: true

send message will cause "code 201 Could not get a long value from the invalid response"

You need to ensure the local property turms.service.redis.sequence-id.uri-list[0]=redis://<ip>:<port> has been set when you run turms-service servers and try again.
I will add a warning log later to tell developers that they may forget to set the Redis server settings if they set use-sequence-id-xxx to true.

after add property to mongo

and restart service, try send message , still same error

when I debug, I found redisClientManager is always null

issue solved, after delete all old data, and re-deploy server


Confused About compatibílity

Hi there. The compatibilty is solely for STD2 tech/preh or it is also doable for STD2Plus Tech/Preh using soldering method?
MST2_EU_VW_PQ_P0478T
5K7035200L
H29.319.58_STD2PlusPQ_EU
Thank you.

Thank you once again.


Running vCheck on VSphere 5.5

I am in the process of getting the vCheck install in the Vsphere 5.5 environment. I have all the PowerCli installers installed but still get some errors.. Figure if i get these i think will clean up others.
Begin Plugin Processing
[12:46:55] ..start calculating Connection settings for vCenter by Alan Renouf v
.5 [1 of 106]
[12:46:55] Connecting to VI Server
Connect-VIServer : Method not found: 'Boolean VMware.VimAutomation.Sdk.Util10.C
ommonUtil.IsEmpty(System.Collections.IEnumerable)'.
At C:\VMscripts\vCheck-vSphere-master\Plugins\00 Initialize\00 Connection Plugi
n for vCenter.ps1:62 char:34

$VIConnection = Connect-VIServer <<<<  -Server $VIServer -Port $Port

CategoryInfo          : NotSpecified: (:) [Connect-VIServer], MissingMet
hodException
FullyQualifiedErrorId : System.MissingMethodException,VMware.VimAutomati
on.ViCore.Cmdlets.Commands.ConnectVIServer

C:\VMscripts\vCheck-vSphere-master\Plugins\00 Initialize\00 Connection Plugin f
or vCenter.ps1 : Unable to connect to vCenter, please ensure you have altered t
he vCenter server address correctly. To specify a username and password edit th
e connection string in the file $GlobalVariables
At C:\VMscripts\vCheck-vSphere-master\vCheck.ps1:667 char:53

$TTR = [math]::round((Measure-Command {$Details = . <<<<  $_.FullName}).T

otalSeconds, 2)
+ CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorExcep
tion
+ FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorExceptio
n,00 Connection Plugin for vCenter.ps1
[12:46:55] Adding Custom properties
[12:46:56] Collecting VM Objects
Get-VM : 1/14/2015 12:46:56 PM    Get-VM        Method not found: 'Boolean VMwa
re.VimAutomation.Sdk.Util10.CommonUtil.IsEmpty(System.Collections.IEnumerable)'
.
At C:\VMscripts\vCheck-vSphere-master\Plugins\00 Initialize\00 Connection Plugi
n for vCenter.ps1:113 char:13

$VM = Get-VM <<<<  | Sort Name

CategoryInfo          : NotSpecified: (:) [Get-VM], VimException
FullyQualifiedErrorId : Core_BaseCmdlet_UnknownError,VMware.VimAutomatio
n.ViCore.Cmdlets.Commands.GetVM

[12:46:56] Collecting VM Host Objects
Get-VMHost : 1/14/2015 12:46:56 PM    Get-VMHost        Method not found: 'Bool
ean VMware.VimAutomation.Sdk.Util10.CommonUtil.IsEmpty(System.Collections.IEnum
erable)'.
At C:\VMscripts\vCheck-vSphere-master\Plugins\00 Initialize\00 Connection Plugi
n for vCenter.ps1:115 char:18

$VMH = Get-VMHost <<<<  | Sort Name

CategoryInfo          : NotSpecified: (:) [Get-VMHost], VimException
FullyQualifiedErrorId : Core_BaseCmdlet_UnknownError,VMware.VimAutomatio
n.ViCore.Cmdlets.Commands.GetVMHost

Thanks

Yeah,  looks like something failing on the vCenter connection. Can you run Connect-VIserver manually and see if you have the same issue?

Yes I get the following:
PowerCLI C:\Program Files (x86)\VMware\Infrastructure\vSphere PowerCLI> Connect-
VIServer
cmdlet Connect-VIServer at command pipeline position 1
Supply values for the following parameters:
Server[0]: cmhpvcntw001
Server[1]:
Connect-VIServer : Method not found: 'Boolean VMware.VimAutomation.Sdk.Util10.C
ommonUtil.IsEmpty(System.Collections.IEnumerable)'.
At line:1 char:17

Connect-VIServer <<<<

CategoryInfo          : NotSpecified: (:) [Connect-VIServer], MissingMet
hodException
FullyQualifiedErrorId : System.MissingMethodException,VMware.VimAutomati
on.ViCore.Cmdlets.Commands.ConnectVIServer

PowerCLI C:\Program Files (x86)\VMware\Infrastructure\vSphere PowerCLI>

It seems like an issue with your PowerCLI install not with vCheck.
Try reinstalling PowerCLI and updating .NET
Perhaps try posting in the VMware communities, you may get a better response over there: https://communities.vmware.com/community/vmtn/automationtools/powercli
Failing that, you should be able to raise a support call with VMware.


Parallel DQN Agent not working.

When I trying to train the Parallel DQN Agent, it did create n worker, but as I plot the portfolio, it doesn't do anything for trading, so it might be the Parallel DQN Agent lib not build in the right way...?

Would like to know the new release contains any update of this?

Not in scope anymore, since agents are mainly offloaded to ray and\or other frameworks. Thanks anyway so much for the help\interest

Probably it's good to delete them from repo or put some notification about it


LANG-1523: Avoid unnecessary allocation in StringUtils.wrapIfMissing.

Now StringUtils#wrapIfMissing(String, char) and StringUtils#wrapIfMissing(String, String) does not allocate buffer when input is already wrapped.
Here are the benchmark results on my machine:
Benchmark                    (input)   Mode  Samples    Score  Score error   Units
optimized    /should not be wrapped/  thrpt       20  357.849        4.525  ops/us
optimized          should be wrapped  thrpt       20   33.779        0.246  ops/us
original     /should not be wrapped/  thrpt       20   35.581        0.236  ops/us
original           should be wrapped  thrpt       20   33.671        0.360  ops/us

Coverage increased (+0.003%) to 95.104% when pulling e4d937d63b5936ab4bc0ca80acd0d32cdc01457a on nstdio:optimize-wrap-if-missing into 94b3784fdec5d0e9d63e4aec6772144b68283790 on apache:master.

Done.
@kinow

Hello, I just saw this issue in Jira, and if I understand the issue correctly. The  StringUtils.wrapIfMissing is making a StringBuilder even when a string is already wrapped for example Str "xabx" with wrapper "x". Rather than not creating a instance of String Builder. What we can do is check if the string is already wrapped, if so then just return the String. This would avoid the String Builder being created.

@RameshDhungel I merged this PR four days ago. If you have something else in mind, please offer it up in a new PR. Thank you.

Okay thank you, I did pull an new PR with the changes I described earlier. If you could let me know if I made any mistake I would appreciate it thank you.


Deferred image manipulation

One of the most important (and difficult) feature of an image library is deferred image manipulation.
Basically not loading the image pixels in memory. For example if I do the following:
mybg = image.load_reference("huge_background.jpg")
mybg.set_pixels(0, 0, 100, 10, Color.red)

// at this point, in memory we should only have a small data structure referring the image file + a 1000 pixel buffer of red pixels
mybg.commit()
// only here we update the pixels we need to update, some image format will require loading the whole data, but many don't

Apple API does it with NSImage (proxy) and NSBitmapRepresentation (actual pixels):
https://developer.apple.com/documentation/appkit/nsimage
https://developer.apple.com/documentation/appkit/nsbitmapimagerep

Good suggestion, it could used to implement a drawing API on top of image like #32

Yes I think the base image lib should have some kind of simple transaction (like the commit() call in my example) and the drawing API (in a separate, higher level lib) should use it.


Update Call Quality Dashboard's "Is Teams" dimension for interop scenarios

In interop scenarios, the "Is Teams" dimension will have "True" as the value.

Approved and republished live. Thanks Gage!


-flist doesn't support wildcards

Currently the implementation of -flist does not support wildcards in the filenames. It may be useful to add it.

Be sure to update texconv, texassemble, texdiag, meshconvert, uvatlas and any other tool with the same support code.

In addition to adding support for wildcards in -flist files, I should also implement the - indicates a file to remove from the file list. Currently it just errors out assuming you mean a command-line argument.

Also updated other tools:
https://github.com/microsoft/DirectXMesh/commit/9782d1f731b2077c0ea230289314f4f5d3b18cd3
https://github.com/microsoft/DirectXTK/commit/7fe78e38dfe5b1b38a49f6825a83cda77a755450
https://github.com/microsoft/UVAtlas/commit/829f9cea074b419c2d048ecd308d659f57a525f7


Improve Gym Website template

[Documentation]
I want to change css of this template please assign it to me
Screenshots

I want to Improve this Website Template and I also have experience in CSS.

@12345678-nishitagole issues are assigned on FCFS basis, you can check out other issues/find bugs/ create issues on your own

i want to contribute in this issue under gsscoc'22

@Sanghu01 issues are assigned on FCFS basis


Adiabatic Master Equation with Sparse Operators

Current implementation of Davies object does not take care of Sparse Hamiltonian.

Closes by issue.


WOR-841 Configure 30-minute data collection interval for Container Insights

https://broadworkbench.atlassian.net/browse/WOR-841

I think it'd be good to make an assertion in our integration tests that these rules are being configured properly, now that we know they can silently break via an SDK upgrade (i.e., something like this
https://github.com/DataBiosphere/terra-landing-zone-service/blob/5dcef4bebdc98e89ded4bf55403979882f3c9b9b/service/src/test/java/bio/terra/landingzone/stairway/flight/create/CreateLandingZoneResourcesFlightIntegrationTest.java#L162-L168
). What do you think?

That's a good suggestion especially because this feature is in preview.


Adding success/failure handler

Found the problem with running test via adb, that it doesn't return failing exit code if tests was failed. The PR is fixed that behaviour by adding python script for log parsing.

It was tested by two runs:

with error - https://github.com/nova-wallet/test-runner/actions/runs/2487524723
without error - https://github.com/nova-wallet/test-runner/actions/runs/2493699690


Implement user interface

Related Issue: https://github.com/tuziemon/upx-pacman-hook-creator/issues/22

@tuziemon
Be careful to push main branch directly


i18n(ko-KR): update configuring-astro.mdx

Description (required)

update configuring-astro.mdx
#9240

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

ko/guides/configuring-astro.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


added auth database

Added all of the necessary packages and wrote out a full user authentication DB using Bcrypt for encryption and JWT for authorization.

We'll need to add a .gitignore. So we aren't uploading/downloading node modules all the time.


Support prefix scopes

Added support for prefixed scopes (trailing slash)
Also made it use locally resolved files and not always return them as externals
Is this of any interest?

Definitely interested in this :)
Just one small comment.

@trygve-lie What are the chances of getting this updated and merged? Just came across it, would be tremendously helpful for Deno build steps.


Add ES5 version

Currently I cannot even use babel to transpile the the it to ES5 - I get the following warning
export 'EqualHeightElement' (imported as 'EqualHeightElement') was not found in 'react-equal-height/clean' (module has no exports)
Therefore it cannot be used as NPM package when you need to support IE11.

Solved via adding sourceType: "unambiguous" to babel.config.js.


Status of the VJ Makers’ website

Current status of VJ Maker’s Website
Right now it's a pretty simple website made up of a few base files for the layout and design, and files for each page. It’s currently built by hand, using HTML, CSS, Jekyll and a few other technologies.
The first thing we should decide is whether to continue to use this setup, or switch to a separate system like WordPress or Blogger.
Components of the website

Component
Description

HTML
Simple markup language used to display content of the site

CSS
Used to style/design the site

Jekyll
Simple static site generator - converts our templates into a proper site

Markdown
Allows people to write text which can be formatted into HTML easily

GitHub
Online storage for code

GitHub Pages
Simple way to host pages on GitHub

List of VJ Makers’ Sites

Link

Website
https://vjmakers.github.io/ (Source Code)

Instagram
https://www.instagram.com/vjmakers/

YouTube
https://www.youtube.com/channel/UCdF_Fxfn2WNCpO5eB_UjD_w

GitHub
https://github.com/vjmakers

/cc @casualvisitor @wei2912 @knowyourenemy
What do y’all think? Just look through this and after that we can discuss with Mr Ho and Joshua.

@demoneaux what exactly is this for? Status wise, I think we should stick
to Jekyll, but with Ruby plugins (meaning we build on a separate server,
similar to what I do on my website). It's Makers Club so we should probably
make good use of the flexibility that Jekyll offers us as opposed to using
WordPress or Blogger with way less flexibility.
On Sun, 27 Nov 2016, 19:10 Benjamin Tan<EMAIL_ADDRESS>wrote:

/cc @casualvisitor https://github.com/casualvisitor @wei2912
https://github.com/wei2912 @knowyourenemy
https://github.com/knowyourenemy
What do y’all think? Just look through this and after that we can discuss
with Mr Ho and Joshua.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vjmakers/vjmakers.github.io/issues/2#issuecomment-263116056,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB-Xl3FFbbHY01qC4j_BHd6eCHsHt4MAks5rCWUIgaJpZM4K9Hsz
.

@demoneaux what exactly is this for?

Just listing our options, for us to consider.

Status wise, I think we should stick to Jekyll

Yep.

but with Ruby plugins (meaning we build on a separate server,
similar to what I do on my website)

Currently it's built on Travis servers and pushed to GitHub pages.

@demoneaux There's no separate repository for the generated files? Or has
GitHub Pages changed
On Sun, 27 Nov 2016, 19:41 Benjamin Tan<EMAIL_ADDRESS>wrote:

@demoneaux https://github.com/demoneaux what exactly is this for?
Just listing our options, for us to consider.
Status wise, I think we should stick to Jekyll
Yep.
but with Ruby plugins (meaning we build on a separate server,
similar to what I do on my website)
Currently it's built on Travis servers and pushed to GitHub pages.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vjmakers/vjmakers.github.io/issues/2#issuecomment-263117433,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB-XlwXx0jPzSZBVFZ2vwN-WwAEg-4Foks5rCWx2gaJpZM4K9Hsz
.

@wei2912 nope, but instead of using a separate repo I use one branch for the source and the master branch for the generated code.

@demoneaux I see, that's a pretty nice solution. I'll push my edits soon.


Missing tags on docker hub

9.4-2.0 and 9.5-2.0 tags are not available.

Please see my comment on https://github.com/clkao/docker-postgres-plv8/pull/17#issuecomment-274527306. tl;dr we're trying to reach Docker Hub for support as the build compiles fine locally.


Collection::mapWithKeys() works incorrectly for keys with integer values

Laravel Version: 5.3.9
PHP Version: 7.0.8
Database Driver & Version:

Description:
Collection::mapWithKeys() works incorrectly for keys with integer values (and for string values like '1', '2', ...);
It returns a collection with numerical keys starting from zero (0, 1, 2, ...)
Steps To Reproduce:
Try to run following code:
            $collection = collect([
                ['id' => 1, 'name' => 'A'],
                ['id' => 2, 'name' => 'B'],
                ['id' => 3, 'name' => 'C']
            ]);

            $collection = $collection->mapWithKeys(function($item) {
                return [$item['id'] => $item];
            });

            dd($collection->keys()->all());

The result will be:
array:3 [
  0 => 0
  1 => 1
  2 => 2
]

Expected result:
array:3 [
  0 => 1
  1 => 2
  2 => 3
]

Hello @aguimaraes, what's your input here? I know this issue is more related to collapse() but hope you had this case in mind while building mapWithKeys() is that intended?

Hello @themsaid.
This function was not meant to be used with numeric keys.
This weird behavior was predicted by @adamwathan here:
https://github.com/laravel/framework/pull/14430#discussion_r74266705
The problem arises when flatMap calls collapse which calls array_merge who will renumber numeric keys.
Using the +  operator would avoid that in collapse.
I don't know if this change is worth it, because it is a breaking change.
Thanks,
Álvaro.

Thank you @aguilarcarlos using + is breaking indeed.
@mikelmi Looks like you'll need to make your own collection macro.

You're welcome @themsaid
@mikelmi take a look here:
https://github.com/spatie/laravel-collection-macros
Talk to @freekmurze about that feature.

Supposing that you need to use mapWithKeys to format the key and the values thus being not viable to use pluck.
There's two simple fixes for this issue, depending on what return you want.

You need to get a key=>single value pair, then  you can combine mapWithKeys and pluck:

$collection = $collection->flatMap(function($item) {
      return [$item['id'] => ['name' => $item['name'], 'key' => $item['id']]];
    })->pluck('name','key');

You need to get a key => array value pair, then you can combine maWithKeys and keyBy.

$collection = $collection->flatMap(function($item) {
      return [$item['id'] => ['name' => $item['name'], 'key' => $item['id']]];
    })->keyBy('key');

// 1 => ['name' => 'A', 'key' => 1];

Both of these are easy workarounds for keeping your integer key.
Not sure if you got the idea but it should be helpful.

Thanks all
For my case keyBy() resolves the problem

why is this issue closed? This has bitten me. It is also undocumented. It should be documented or fixed.
Also 'filter' is broken, i.e. the example given in the documentation fails (it does not return [3,4], but [2=>3, 3=>4])
I'm inclined to stop using Collections altogether because I cannot trust the documentation/behavior.

For my use case I was able to just do a simple workaround, by putting them the opposite way then calling flip()...
$collection = $collection->mapWithKeys(function($item) {
    return [$item['name'] => $item['id']];
})->flip();

Not sure why this behaviour is not documented, I spend an hour tracing it. In the end I ditched laravel collection methods all together and just:
$keyed = [];
foreach ($items as $item) $keyed[$item->id] = $item;

As far as I know this behavior was corrected for 5.4:
https://github.com/laravel/framework/pull/16564
@datune, try the latest version and see if it behaves the way you want, I think it likely does 👍

adster13 fix will only work if the $item['name'] values are unique otherwise there's a chance previous values will get overwritten.

Hey guys, come on, this should be documented! I was pulling my hair out trying to get this to work, it wasn't until I dug into the source code and saw it used array_merge and happened to remember from past experience with array_merge that it re-indexed integer keys (which is desirable in the case of array_merge, but totally unexpected in a method called mapWithKeys()). What's the point of having the documentation be versioned if known issues (bugs!) are not called out in old versions?

Sometimes things get missed. Great thing is the docs are open source. Help out the next person.


Unique comparison is case sensitive

It seems that the where clause in the unique_translation rule is case sensitive.
https://github.com/codezero-be/laravel-unique-translation/blob/1eb3d56b1f4af36b4985730619838bb124436b81/src/UniqueTranslationValidator.php#L161-L164
According to my Google searches, MySQL is supposed to be case insensitive when using a collation that ends in _ci (I'm using utf8mb4_unicode_ci). But that's not what my tests are saying...
Is anyone else having this issue?

yep

Fixed by #22

Just for later reference: using a LIKE query seems to be case insensitive too and improves compatibility with other database types than MySQL.

@ivanvermeyen
I got the same problem while using UniqueTranslationRule validation rule with Filament.
I have a mytable.name translatable field. Here the Filament Resource:
    public static function form(Form $form): Form
    {
        return $form
            ->schema([
                Forms\Components\TextInput::make('name')
                    ->rules([
                        fn (Forms\Get $get) => UniqueTranslationRule::for('mytable', 'name')
                            ->ignore($get('id')),
                    ])
                    ->required(),
            ]);

Validation works pretty well when respecting the case (I cannot use Foo twice), but seems to fail when using different case (I can save a record with name=Foo and another with name=foo using the same locale, but I shouldn't be allowed).
Database is MySQL with utf8mb4_unicode_ci collation.
Am I missing or doing anything wrong?
Thanks!

@ivanvermeyen Thanks for reopening the issue


Refactor code written so far

Developers should discuss this and split it in specific issues

Added prettier config and ran it on all files from #83


Keep the picker open after onPressConfirm

Added possibility to keep the picker open, after pressing the confirmation button (onPressConfirm).
The management of the picker closure can be managed manually

Coverage increased (+0.02%) to 97.391% when pulling f8c6dedda788b6fe73b7e45894271aee3b33cae5 on matteocollina:master into 2a209bd4f11a84ff4543fbde930fed60dcbc0f68 on xgfe:master.


Day 410

Good morning! Here's your coding interview problem for today.
This problem was asked by Airbnb.
 These can be rounded up or down to create a corresponding array Y of integers y1, y2, ... yn.
Write an algorithm that finds an appropriate Y array with the following properties:
The rounded sums of both arrays should be equal.
The absolute pairwise difference between elements is minimized. In other words, |x1- y1| + |x2- y2| + ... + |xn- yn| should be as small as possible.
For example, suppose your input is [1.3, 2.3, 4.4]. In this case you cannot do better than [1, 2, 5], which has an absolute difference of |1.3 - 1| + |2.3 - 2| + |4.4 - 5| = 1.

Identical to Day 355: https://github.com/vaskoz/dailycodingproblem-go/issues/704


🪲[BUG] Breaks when used with SPI (st7735 QMK)

Describe the bug you encountered:
I'm using  this with a QMK converter; tried to hook up a st7735_spi driver with quantum painter and found that when the USB device is connected, the keyboard & display both stop working.
USB enumeration works correctly but neither the display, nor the keyboard work.
Without the keyboard connected, the display works;
If I do not connect the to the SPI device, the usb keyboard works fine.
...
What did you expect to happen instead?
Both the LCD display and physical keyboard connected to the USB hub work
...
What actually happened in your case?
USB enumeration works correctly but neither the display, nor the keyboard work.
Without the keyboard connected, the display works;
If I do not connect the to the SPI device, the usb keyboard works fine.
If I delay the initialization of the SPI connection by a few seconds, then for those few seconds, the keyboard works fine and keyboard reports are received.
...
Additional information

Using QMK
tinyusb master
this project at master.
https://github.com/raghur/adafruit_rp2040_usbh/tree/759ea3097d089acad65517d01dec5a5a7a68d712

branch: https://github.com/raghur/adafruit_rp2040_usbh/tree/st7735, commit: 759ea3097d089acad65517d01dec5a5a7a68d712

This is likely caused by DMA conflict since QMK uses chibios;
Setting pio_cfg.tx_ch = 11;  is a workaround that partially addresses it (not foolproof); with that in place, the display initializes properly but there is still some other conflict since the keyboard itself is never usable.


Set required error

Can we get error message text to display our errors?

What do you mean?
To have exposed the component errors/s so you can show them in any other way (ie: on a toast component) ?

I'm using react hooks form
import { useForm, Controller } from 'react-hook-form';
...
  const { handleSubmit, control, errors, reset } = useForm<PrescriptionData>({
    validationSchema: schema,
    defaultValues: {
      files: [],
    },
  });
...
        <Controller
          as={ImageUploader}
          name="files"
          control={control}
          withIcon={true}
          withPreview
          singleImage
          className={classes.alert}
          buttonClassName={classes.button}
          buttonText="Choose/Capture Prescription"
          label="Upload or take a picture of your prescription, (Max file size: 5mb, accepted: jpg, png)"
          imgExtension={['.jpg', '.png']}
          maxFileSize={5242880}
        />
        <Card className={classes.container}>
          <Controller
            as={TextField}
            name="telNo"
            margin="normal"
            required
            fullWidth
            label="Telephone Number"
            control={control}
            error={errors.telNo ? true : false}
          />

So when required false error triggers I should be able to set the error in the box. What to you think use it as errorSize for the other? can we get expose errorMessage prop?

This component dont expose errors, that could be achieved having a "onError" method.
Feel free to add that functionality on a PR, I will review and if it works I will add that to the component.

@ivnnv onError method is exactly what I'm looking for

Any contributions are welcome


Close consumer gracefully #2991

This PR address both issues raised in #2991 and #3144
The First commit is the fix that means the TopicConnector now waits for both client threads to close, and removes an uncalled method "stop".
The second commit add exception handling to the calls to the consumer.commitSync().

If we fail to update the sync point I am presuming that what will happen is that when next started (which is likely) we will end up potentially re-processing some messages. Most of the time we sync quickly in any case, and we should be able to handle a duplicate message, so I don't think this adds undue concern. If we are concerned we probably need to unwrap the next level of analysis and testing (beyond the high level architecture) in terms of everything around transactionality...

@planetf1 - Agreed - the fact that this is consumer side, as you say, means we would duplicate not drop a message.

I think we're good here then and should merge once the build is up to date...
(Note that it will be going into 2.1)

@grahamwallis  and @planetf1 In this case I believe the root cause is that there isn't actually a message consumed, we've opened a transacted poll, no message has arrived and then we issued a WakeUP and tried to commit an empty transaction. I don't think there is any underlying problem , (except that the consumer doesn't track if there is anything to actually commit , before calling commitSync )


Set torch default device and dtype

Upon initialization of artist, call torch.set_default_device and torch.set_default_dtype and get rid of explicit dtype and devices within the code base

Currently the device is set once in the beginning and is passed down through each function.
We might want to change that and use torch.set_default_device() once.


feat(connlib): support resource updates from the portal

This PR doesn't yet provide support for the update of upstream DNS but it does provide support for all the other resources update messages.
Partially fixes #2022

This is part of the same thing as #3750 right? I have a stacked PR at #3775 for the Windows client part.
They seem a little inter-dependent but I think I could build remove_route for Windows and a unit test for it without waiting on anything else.

This is part of the same thing as #3750 right? I have a stacked PR at #3775 for the Windows client part. They seem a little inter-dependent but I think I could build remove_route for Windows and a unit test for it without waiting on anything else.

This is independent from #3750
the remove_route is implemented on windows in https://github.com/firezone/firezone/pull/3754/commits/4316b2ad6a4c841fb40cab4e2908cba708ec7859

Partially fixes #2022

Writing it like that will still close the issue, FYI.


Add a more generic bind() method to allow Unix socket server

I also need to implements an unix socket server ( like #17 and #6 ) so I added a simpler method bind($address) to bind a server to any socket type.
I converted the listen() method to use this new method for BC.

+1

Closed via #61


@OptIn is included into generated Native classes and breaks iOS builds

We are having an issue when trying to use the app that was built for iOS, we couldn't compile it on XCode if one of our @NativeCouroutines annotated methods contained an @OptIn annotation.
Since the library is open source too, you should be able to reproduce it easily on this branch
Migration steps on the iOS side are not complete yet, but by removing the @OptIn annotations from this file the error dissapears and we can continue with the migration steps on iOS.
However, when generating the Native version of the FlowForm file, it shouldn't copy the @OptIn annotations, or if it should then it shouldn't affect the iOS build on Xcode.

Thanks for the report! Depending on your code (e.g. when the return type needs an opt-in) the @OptIn annotations might be needed on the native declaration as well, which is why it's always added.
However there indeed seems to be some issue with the generated code. I will take a look at that.

FYI this should be fixed in v1.0.0-ALPHA-9.

Ey thank you for the quick fix! Highly appreciated


⚠ Bofrost.lu has degraded performance

In 4299bc3, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 976 ms

Resolved: Bofrost.lu performance has improved in 46f43a7.


Add nats-server binary

Description
Add nats-server binary.
Motivation and Context

[X] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required) #678

How Has This Been Tested?
Covered with unit tests and tested with e2e test as well.
Are you a GitHub Sponsor yet (Yes/No?)

[ ] Yes
[X] No

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[X] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

[X] I have tested this on arm, or have added code to prevent deployment

@Shikachuu thanks for the PR. Can you show the output from the "dagger tests" we have been using?

All good, but please remove the windows / ARM64

Done! :heavy_check_mark:


Add messages for logging enabled and capture in progress

Also capture complete and elapsed time captured

Completed in numeric-investigations branch.


Add subtreeID, depositCount to DepositQueued event

Resolves https://github.com/thehubbleproject/hubble-contracts/issues/637

Gas changes
master

Deposit 0: 139601
Deposit 1: 109921
This PR

Deposit 0: 142333
Deposit 1: 110665
Deposit 2: 108145
cha-cha-cha-changes
Deposit 0 change: +2732
Deposit 0 % change: 1.957%
Deposit 1 change: +744
Deposit 1 % change: 0.677%
Deposit 2 N/A

Thanks for the help @ChihChengLiang ! Suggestions implemented, gas stats updated, slight decrease :tada:

Suggestion - we can start using eth-gas-reporter. It also comes with codechecks plug-in which can compare gas change with the target branch so we don't need to calculate manually!

@kautukkundan I have a branch up that would add contract test coverage as well as hopefully implement the reporter you mentioned https://github.com/thehubbleproject/hubble-contracts/pull/552 . We would need to update a number of spots for it to work properly but I agree that it would be much easier than manually calculating and reporting in PRs :)


Update release.yml

Codecov Report

Merging #58 (f06c433) into main (bedf40c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   54.54%   54.54%
=======================================
  Files          12       12
  Lines        1023     1023
=======================================
  Hits          558      558
  Misses        399      399
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedf40c...f06c433. Read the comment docs.


Update 00-update-resource-providers.md

Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:

Submitted by benjames007 on behalf of MOC Labs Review


Nodes Manager

The Problem
Today we don't have a dedicated component in the Requester node that manages the compute nodes in the network. We only have a transient NodeInfoStore that discovers compute nodes through gossiping, and evict nodes that stop heartbeating for over 10 minutes. This state is transient, will be lost when the Requester node is restarted, and not possible for operators to interact with, such as draining or manually  marking a node as unhealthy.
In addition to that, we don't have a mechanism today to schedule daemon jobs on newly joined compute nodes that match the job selection criteria of existing daemon jobs, or when a compute node changes its labels to match or no longer match existing daemon jobs.
Requirements

As an operator, I want to have the power to manually approve compute nodes before they join the network, ensuring better control and security.
As an operator, I need a feature that allows for the auto-joining of pre-authorized compute nodes, eliminating the need for manual intervention.
As an operator, I want to mark certain nodes as ineligible for new job placements, while existing jobs on these nodes can continue to run uninterrupted.
As an operator, I want to drain nodes when necessary and have Bacalhau re-schedule the jobs to other nodes.
As an operator, I want the ability to add labels to nodes from the control plane and override any labels that the compute nodes have set themselves.
As an operator, I need to set the criteria for timeouts and missed heartbeats that will determine when a node is considered in 'unknown' state.
As an operator, I need to set the criteria for timeouts and missed heartbeats that will determine when a node is considered 'unhealthy'.
As an operator, I want the flexibility to set these timeout and heartbeat thresholds at individual node levels, for groups of nodes, or as default settings for any nodes not specified.
As a user, I expect Bacalhau to automatically reschedule 'batch' and 'service' jobs if their nodes are marked as unhealthy.
As a user, I want Bacalhau to mark the execution of 'ops' jobs as failed if their nodes are flagged as unhealthy.
As a user, I want Bacalhau to schedule daemon jobs on new compute nodes that join the network and match selection criteria of existing jobs
As a user, I want Bacalhau to evict daemon jobs on existing compute nodes if their labels are updated to no longer match existing jobs

The Proposal

The proposal is to have a dedicated NodeManger component inside the Requester node that persists the state of compute nodes, managers their lifecycle, and expose APIs to allow operators to query and mutate the nodes.
The NodeManager will also be responsible for queueing new evaluations for daemon jobs if new nodes join, or their labels are updated.
The NodeManager shall persist stable info about compute nodes, such as their state, labels and supported engines, and store in-memory always changing metadata, such as available resources

Open Questions

Evaluate the need for an explicit RegisterNode API that compute nodes shall call when they start up and want to register with a requester node, instead of just always publishing their info.

Reference: #355

Duplicate of https://github.com/bacalhau-project/bacalhau/issues/3945


Upgrade assistant stuck in Xamarin Forms upgrade (UA0014)

Describe the bug
The upgrade assistant keeps trying to fix the UA0014 code fix for the same file. If the Fix failed it won't continue to the next issue, but keeps retrying it.
It looks like it isn't able to handle a fully qualified base class in for example a custom renderer or a PlatformEffect.
To Reproduce
Add a custom renderer or platformeffect to a platform project. Fully qualify the base class like this:
public class ListViewRenderer : Xamarin.Forms.Platform.Android.ListViewRenderer
{
}

Exceptions (if any)
Further technical details
Upgrade-assistant version: 0.4.0-dev
In the class/method UsingXamarinFormsAnalyzerCodeFixProvider.RegisterCodeFixesAsync the node.RawKind is of type SyntaxKind.ClassDeclaration, which isn't handled.
Looks like it should be doing similar to what the assistant is doing to the MainActivity class. And add the using "Microsoft.Maui.Controls.Compatibility.Platform".

Please try the newest version.


Ignore go.work.sum

Reasons for making this change:

As the go.work file is excluded, the go.work.sum file, which is generated based on the go.work file, should be excluded, too.
Also mentioned in https://github.com/github/gitignore/commit/fbc053fe49d7f3b4a882ddf9651fc60f8954db21#commitcomment-73352144
Links to documentation supporting these rule changes:
Currently there isn't much documentation regarding go.work.sum (see https://github.com/golang/go/issues/51941), the only thing I can refer to is the proposal, which suggests to not check in the go.work file.

Why not **go.sum?
The sum file is used to check locally, I think.

Why not **go.sum? The sum file is used to check locally, I think.

 Typically your module's go.sum file should be committed along with your go.mod file.

@avelino, @Nirusu will this get merged?

I'm in favor of this change - if go.work is ignored, then go.work.sum should also be ignored.  Note that there's not actually a recommendation or even consensus on whether these files should be ignored.  My read on the situation is that for cases like a monorepo, you probably do want to commit these files but in many other situations, you do not. See the discussion at https://github.com/golang/go/issues/53502.

@bdougie, could you please take a look at this PR since you already merged #3884? The file mentioned here is a checksum file that is autogenerated, and present iif go.work file is present in the local repository.  Since go.work is ignored, we should ignore go.work.sum files as well.

Hey there, I noticed that the PR is already approved. is there an estimated timeframe for when it might be merged? Just curious and looking forward to it

I think those gray check marks indicate that the approvals are by developers who are not CODEOWNERS.  I don't even see a merge button!


opteesign.py: fix exception when .ta-version not present

The cleanup of the .ta-version file will throw a FileNotFoundError if the file is not present.  Catch the exception and continue.

Thanks @Lexmark-chad


00:37:18_GMT_Sun. 10.17.21:2000a;#$¡SSH:}#[reevesPAC(¡658101)];[2]::||;<rust.h>;<tsdbint64.h.k>;<[css:alpha.sCss.keth]>,',/-//((self-connect)(122,122../..123,124),/("wTc.hwebpc.kIS¡"));https://cli@github.com/Dev.cangobuild7(s)+\'TDengine'/(reevesPAC)@github.com;<[ANDROID:ver11/(TMOBILE-SM-A125U-11_0010)]>;

00:37:18_GMT_Sun. 10.17.21:2000a;#$¡SSH:}#[reevesPAC(¡658101)];[2]::||;<rust.h>;<tsdbint64.h.k>;<[css:alpha.sCss.keth]>,',/-//((self-connect)(122,122../..123,124),/("wTc.hwebpc.kIS¡"));https://cli@github.com/Dev.cangobuild7(s)+\'TDengine'/(reevesPAC)@github.com;<[ANDROID:ver11/(TMOBILE-SM-A125U-11_0010)]>;
Sunday, October 17, 2021
12:59 AM
delayed.distributionstamp00:57:--.accrd.to5062zaT2

I did this in this doubled display for comparative analytics. thanks again!
I'm sorry


Right click should not trigger resize

Steps to recreate:

Go to: https://allotment-storybook.netlify.app/?path=/story/basic--horizontal
Right click on any sash
Left click outside of the resize panes
Panes resize incorrectly

Hi @gkiely. Well spotted!
I'll investigate what's going on.


Social buttons

GitHub's unofficial Fork / Star / Follow buttons (with counts) are here: http://ghbtns.com/
Twitter's Tweet / Follow / Hashtag / Mention buttons (with page share count, for a tweet button) are here: https://about.twitter.com/resources/buttons
Facebook's numerous plugin buttons, usually with a box specifying the number of friends / likes / etc.: https://developers.facebook.com/docs/plugins/follow-button
Youtube's subscribe buttons (with a figure for the number of subscribers): https://developers.google.com/youtube/youtube_subscribe_button
Google+ has "badges" that we don't want, but they also have a follow button that is reminiscent:
https://developers.google.com/+/web/follow/ and a +1 button that has no reason to be so different: https://developers.google.com/+/web/+1button/

All those buttons are iframes designed to track users, but I don't see why that should be the case. I believe we can offer consistent buttons that are really fast to load (grr, G+, I am looking at your huge
downloads!) and that do not track users.
Given access to their respective APIs, I can easily add a custom design to more closely match their button style (a clickable element next to a speech bubble with a number in it).
Challenges:

The left-hand-side custom logo. Both GitHub and Twitter use an url() base64 image (SVG for GitHub, PNG for Twitter). We may simply detect GitHub-specific (etc.) badges, and include the correct logo. It is unclear how we will go about allowing any logo.
The left-hand-side has a link, the right-hand-side has a different link. Links can be implemented by SVG's xlink:href. Dynamic CSS works, but not in every form. Both links and CSS don't work inside <img> tags, but they work in inline SVG, <embed>, <object>, <iframe>. What's great is that the same code, gracefully degraded in <img>, still gives a good result, just a static one. How we will receive those links, given the current API design, is unclear.

Some buttons, such as Twitter's, also do some menuitem magic to provide specific actions in the right-click menu. I doubt that can happen in our SVGs, but we never know.

Test
Image

img

embed

object

iframe

Camo seems to refuse images inside SVG in an img.

Issue mistake, it seems.

While SVG in <img> is very limiting, it allows the use of SMIL. However, the implementation of SMIL seems lacking in Chrome. For instance, this fails:
<rect id="llink" stroke="#d5d5d5" fill="url(#a)" x="0.5" y="0.5"
  width="51" height="19" rx="2"/>
<animate xlink:href="#llink" begin="llink.mouseover" end="llink.mouseout"
  attributeName="fill" from="url(#b)" to="url(#b)" dur="1s"/>

It looks like Safari fails to show images directly in an SVG in an <img> tag. In any other occurrence (inline, embed, object, iframe), it shows up fine. WebKit issue here.

When live, this will work:
https://img.shields.io//github/forks/badges/shields.svg?style=social&label=Fork&logo=data%3Aimage%2Fsvg%2Bxml%3Bbase64%2CPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4NCjwhLS0gR2VuZXJhdG9yOiBBZG9iZSBJbGx1c3RyYXRvciAxNy4xLjAsIFNWRyBFeHBvcnQgUGx1Zy1JbiAuIFNWRyBWZXJzaW9uOiA2LjAwIEJ1aWxkIDApICAtLT4NCjwhRE9DVFlQRSBzdmcgUFVCTElDICItLy9XM0MvL0RURCBTVkcgMS4xLy9FTiIgImh0dHA6Ly93d3cudzMub3JnL0dyYXBoaWNzL1NWRy8xLjEvRFREL3N2ZzExLmR0ZCI%2BDQo8c3ZnIHZlcnNpb249IjEuMSIgaWQ9IkxheWVyXzEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiIHg9IjBweCIgeT0iMHB4Ig0KCSB3aWR0aD0iNDBweCIgaGVpZ2h0PSI0MHB4IiB2aWV3Qm94PSIxMiAxMiA0MCA0MCIgZW5hYmxlLWJhY2tncm91bmQ9Im5ldyAxMiAxMiA0MCA0MCIgeG1sOnNwYWNlPSJwcmVzZXJ2ZSI%2BDQo8cGF0aCBmaWxsPSIjMzMzMzMzIiBkPSJNMzIsMTMuNGMtMTAuNSwwLTE5LDguNS0xOSwxOWMwLDguNCw1LjUsMTUuNSwxMywxOGMxLDAuMiwxLjMtMC40LDEuMy0wLjljMC0wLjUsMC0xLjcsMC0zLjINCgljLTUuMywxLjEtNi40LTIuNi02LjQtMi42QzIwLDQxLjYsMTguOCw0MSwxOC44LDQxYy0xLjctMS4yLDAuMS0xLjEsMC4xLTEuMWMxLjksMC4xLDIuOSwyLDIuOSwyYzEuNywyLjksNC41LDIuMSw1LjUsMS42DQoJYzAuMi0xLjIsMC43LTIuMSwxLjItMi42Yy00LjItMC41LTguNy0yLjEtOC43LTkuNGMwLTIuMSwwLjctMy43LDItNS4xYy0wLjItMC41LTAuOC0yLjQsMC4yLTVjMCwwLDEuNi0wLjUsNS4yLDINCgljMS41LTAuNCwzLjEtMC43LDQuOC0wLjdjMS42LDAsMy4zLDAuMiw0LjcsMC43YzMuNi0yLjQsNS4yLTIsNS4yLTJjMSwyLjYsMC40LDQuNiwwLjIsNWMxLjIsMS4zLDIsMywyLDUuMWMwLDcuMy00LjUsOC45LTguNyw5LjQNCgljMC43LDAuNiwxLjMsMS43LDEuMywzLjVjMCwyLjYsMCw0LjYsMCw1LjJjMCwwLjUsMC40LDEuMSwxLjMsMC45YzcuNS0yLjYsMTMtOS43LDEzLTE4LjFDNTEsMjEuOSw0Mi41LDEzLjQsMzIsMTMuNHoiLz4NCjwvc3ZnPg0K

@espadrine https://img.shields.io// should be https://img.shields.io/ without a second / at the end for the SVG path.

Thanks! Fixed it. I'll put it live tonight.

The WebKit issue that prevents Safari from showing the logo was fixed a couple of months ago. It might be in Safari 9. I can confirm that WebKit Nightly does not have the bug.

Here are examples of built-in logos:

This is the only issue mentioning "Facebook" but that shield is not yet available. Is something in the making for FB? Wouldn't have to be the follow shield with all the bells'n whistles. A simple share shield would help.

@marcelstoer You can definitely open a new issue for that. Big names like Facebook are slightly tricky in that we risk having tons of people use the badge, only to have it start failing once we reach a rate limit, so there is some analysis to be performed on that front. Ideally, we'd use whatever existing buttons already use, but obviously we don't make user agents download JS code, it's all server-side.

Looking at the huge, largely uncommented PR backlog I felt very reluctant to invest any time. However, even though the JS universe is very new to me it felt doable with little effort. So, here it is: #861.


Loco.gg Downloader

Checklist

[X] I'm reporting a site feature request
[X] I've verified that I'm running yt-dlp version 2022.02.04. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
India
Example URLs
https://loco.gg/stream/e2d319b4-f2f9-430f-a830-4ef76cf6c161
Description
I confirm that i am on latest yt-dlp and this url is not supported!
Verbose log
[debug] Command-line config: ['-vU', 'https://loco.gg/stream/e2d319b4-f2f9-430f-a830-4ef76cf6c161']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, err utf-8, pref cp1252
[debug] yt-dlp version 2022.02.04 [c1653e9ef]
[debug] Python version 3.10.1 (CPython 64bit) - Windows-10-10.0.22000-SP0
[debug] exe versions: ffmpeg 2022-02-03-git-e1a14479a8-full_build-www.gyan.dev (setts), ffprobe 2022-02-03-git-e1a14479a8-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2022.02.04, Current version: 2022.02.04
yt-dlp is up to date (2022.02.04)
[debug] [generic] Extracting URL: https://loco.gg/stream/e2d319b4-f2f9-430f-a830-4ef76cf6c161
[generic] e2d319b4-f2f9-430f-a830-4ef76cf6c161: Requesting header
WARNING: [generic] Falling back on generic information extractor.
[generic] e2d319b4-f2f9-430f-a830-4ef76cf6c161: Downloading webpage
[generic] e2d319b4-f2f9-430f-a830-4ef76cf6c161: Extracting information
[debug] Looking for video embeds
ERROR: Unsupported URL: https://loco.gg/stream/e2d319b4-f2f9-430f-a830-4ef76cf6c161
Traceback (most recent call last):
  File "C:\Users\lucigendu\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1381, in wrapper
    return func(self, *args, **kwargs)
  File "C:\Users\lucigendu\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 1451, in __extract_info
    ie_result = ie.extract(url)
  File "C:\Users\lucigendu\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\common.py", line 612, in extract
    ie_result = self._real_extract(url)
  File "C:\Users\lucigendu\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\generic.py", line 3986, in _real_extract
    raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://loco.gg/stream/e2d319b4-f2f9-430f-a830-4ef76cf6c161

Any updates on this ?


Switch type to datatype (?)

Avoids conflict with dublin core terms and matches with http://w3c.github.io/csvw/metadata/index.html

@rgrp @danfowler this is open for quite a while. Either we make this breaking change, or we close the issue IMHO. I'm -1 on the change.

WONTFIX. We will not make this change. It was largely to try and seek compatibility with w3c spec but that diverged in lots of other ways.