Figure out why JsonParser.parseString blocks infinitely

Gson allows parsing json strings in a JsonElement by doing either:
new JsonParser().parse(string)
JsonParser.parseString(string)
The problem is that the former is deprecated in favor of the latter, which in testing has killed execution even though the former parses just fine.

I verified that redis intercom is working as intended and changed only the method that is called to decode the JSON message from the deprecated method to the new static method and it immediately hung with no output.
What makes this more frustrating is that the deprecated method calls the static method as its only operation.....

Velocity ships with Gson > 2.8.5
Bungeecord: Gson > 2.8.0
Miraculously, I managed to depend on 2.8.6 which is the version that this method was deprecated. The odds are... yeah..


Support Swift 5

Update to Swift 5, and use official Docker images for CI.

@ianpartridge The Xcode 10.2 testing is using the $SWIFT_DEVELOPMENT_SNAPSHOT. Judging by the LoggerAPI travis.yml I assume you mean you also want a test for Xcode 10.2 without an env being set?

Yes that's right, so that we test with Swift 5. In the future $SWIFT_DEVELOPMENT_SNAPSHOT won't be Swift 5.


[Event Request] Codeunit 80 "Sales-Post" - OnBeforePostItemTracking

Describe the request
Hi, would it be possible to modify the OnBeforePostItemTracking event in codeunit 80 (Sales-Post) by adding the ItemJnlRollRndg parameter, like this:
    local procedure PostItemTracking(SalesHeader: Record "Sales Header"; SalesLine: Record "Sales Line"; TrackingSpecificationExists: Boolean; var TempTrackingSpecification: Record "Tracking Specification" temporary; var TempItemLedgEntryNotInvoiced: Record "Item Ledger Entry" temporary; HasATOShippedNotInvoiced: Boolean)
    var
        QtyToInvoiceBaseInTrackingSpec: Decimal;
        ShouldPostItemTrackingForReceipt: Boolean;
        ShouldPostItemTrackingForShipment: Boolean;
        ShouldProcessReceipt: Boolean;
        IsHandled: Boolean;
    begin
        IsHandled := false;
        // OnBeforePostItemTracking(SalesHeader, SalesLine, TrackingSpecificationExists, TempTrackingSpecification, IsHandled, TempItemLedgEntryNotInvoiced, HasATOShippedNotInvoiced, PreciseTotalChargeAmt, RoundedPrevTotalChargeAmt, RemQtyToBeInvoiced);
        OnBeforePostItemTracking(SalesHeader, SalesLine, TrackingSpecificationExists, TempTrackingSpecification, IsHandled, TempItemLedgEntryNotInvoiced, HasATOShippedNotInvoiced, PreciseTotalChargeAmt, RoundedPrevTotalChargeAmt, RemQtyToBeInvoiced, ItemJnlRollRndg);
        if IsHandled then
            exit;

        ...

    end;

    [IntegrationEvent(true, false)]
    local procedure OnBeforePostItemTracking(SalesHeader: Record "Sales Header"; var SalesLine: Record "Sales Line"; var TrackingSpecificationExists: Boolean; var TempTrackingSpecification: Record "Tracking Specification" temporary; var IsHandled: Boolean; TempItemLedgEntryNotInvoiced: Record "Item Ledger Entry" temporary; HasATOShippedNotInvoiced: Boolean; var PreciseTotalChargeAmt: Decimal; var RoundedPrevTotalChargeAmt: Decimal; RemQtyToBeInvoiced: Decimal; var ItemJnlRollRndg:Boolean)
    begin
    end;

Additional context
The customization requires update ItemJnlRollRndg variable by the additional condition.
Internal work item: AB#506315

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 17295.


PR Merge Bot should pick up #sign-off comment in PR Review response

Is your feature request related to a problem? Please describe.
It seems like the "PRMerger" account doesn't pick up your control comments like #sign-off if they are embeded in the PR approval text.
EX: working for "issue comment" https://github.com/MicrosoftDocs/azure-docs/pull/9637#issuecomment-394444816
EX: not working for "pull request review" https://github.com/MicrosoftDocs/azure-docs/pull/9610#pullrequestreview-125692618
Describe the solution you'd like
The PR merger bot should also trigger when the sign off message is given in a PR review.
Describe alternatives you've considered
Maybe there is a separate bot that runs on a cron job to handle this case.

@dend Can you take a look at this issue?

This would be an ask for @meganbradley

Thanks for following up 👍
The second PR has also been merged now manually, but the bot didn't clear the tag. This is still an issue AFAIK

Could this get bumped up the priority a bit. I've hit this in a few PRs on the Azure docs already, and I'm guessing that there might be other PRs that don't get landed in some of the larger repos for the same reason

@nschonni Thanks for your feedback. I've initiated a internal item to track it. Will let you know the status.

Hello - reviewing and cleaning up some older feedback/issues. Thanks!


No documentation on how to trigger pipeline build on 'master' branch.

import os
from azure.devops.connection import Connection
from msrest.authentication import BasicAuthentication
Fill in with your personal access token and org URL
PERSONAL_ACCESS_TOKEN = os.getenv("PERSONAL_ACCESS_TOKEN")
ORGANIZATION_URL = 'xxxxxx'
PROJECT_NAME = "xxxxxx"
def create_pipeline_client():
# Get connection from devOps & create pipeline client
credentials = BasicAuthentication('', PERSONAL_ACCESS_TOKEN)
connection = Connection(base_url=ORGANIZATION_URL, creds=credentials)
pipeline_client = pipeline_client = connection.clients_v5_1.get_pipelines_client()
return pipeline_client
def build_pipeline():
pipeline_client = create_pipeline_client()
run_params = {'sourceBranch' : "master"}
pipe_id = 2098
pipeline_client.run_pipeline(
run_parameters=run_params,
project=PROJECT_NAME,
pipeline_id=pipe_id,
pipeline_version=None)
print("Pipeline run successfully activated.")
build_pipeline()

@SamuelDeveloper3 are you providing an example, or are you having issues with this endpoint?
This pipeline client is in early preview, and is not documented yet.

I'm asking for help on how to specify what branch I want my pipeline to run on.
Currently, I am able to build a pipeline from the python script to run. However, whenever I try to specify the branch I want it to run on and send the following dictionary object to the pipeline client build_run method it doesn't work.
``
def build_pipeline(pipe_id, run_params, pipe_version=None):
pipeline_client = create_pipeline_client()
print(run_params)
print("Running Pipeline with id " + str(pipe_id))
#try:
pipeline_client.run_pipeline(
    run_parameters=run_params,
    project=PROJECT_NAME,
    pipeline_id=pipe_id,
    pipeline_version=pipe_version)
print("Pipeline run successfully activated.")

"run_params = {'sourceBranch' : "master"}"
How should, I specify devOps to run the desired pipeline on master instead of release branch.

The pipeline client run_pipeline client. Sorry, the build pipeline method is the one I create. Here is my entire code.
from azure.devops.connection import Connection
from msrest.authentication import BasicAuthentication
#pip install azure-devops
# Fill in with your personal access token and org URL
PERSONAL_ACCESS_TOKEN = ''"
ORGANIZATION_URL = ''"
PROJECT_NAME = ""
def main():
    print("Automation script to run pipelines on DevOps.")
    list_pipelines()
    get_run("3011","81104")

def create_pipeline_client():
    # Get connection from devOps & create pipeline client
    credentials = BasicAuthentication('', PERSONAL_ACCESS_TOKEN)
    connection = Connection(base_url=ORGANIZATION_URL, creds=credentials)
    pipeline_client = pipeline_client = connection.clients_v5_1.get_pipelines_client()
    return pipeline_client

def build_pipeline(pipe_id, run_params, pipe_version=None):

    pipeline_client = create_pipeline_client()
    print(run_params)
    print("Running Pipeline with id " + str(pipe_id))
    #try:
    pipeline_client.run_pipeline(
        run_parameters=run_params,
        project=PROJECT_NAME,
        pipeline_id=pipe_id,
        pipeline_version=pipe_version)
    print("Pipeline run successfully activated.")
    #except Exception as ex:
    #print("Pipeline run failed with exception: " + str(ex))

def get_pipeline(pipe_id, pipe_version=None):
    pipeline_client = create_pipeline_client()
    pipeline = pipeline_client.get_pipeline(
        project=PROJECT_NAME,
        pipeline_id=pipe_id,
        pipeline_version=pipe_version)
    print(pipeline)

def list_pipelines():
    pipeline_client = create_pipeline_client()
    pipeline_list = pipeline_client.list_pipelines(PROJECT_NAME)
    for x in dir(pipeline_client):
        print(x)

def get_run(pipe_id, runid):
    pipeline_client = create_pipeline_client()
    run = pipeline_client.get_run(project=PROJECT_NAME, pipeline_id=pipe_id, run_id=runid)
    print(run)

# Create a connection to the org
if __name__ == '__main__':
    main()

@SamuelDeveloper3  are you sure the pipeline id 3011 is of build pipeline and not a release pipeline?

I am also trying to use the run_pipeline method to trigger a pipeline.  I am able to trigger a pipeline run without trouble, but I can't seem to figure out how to trigger the pipeline on a branch other than master.  Any guidance?

I'll answer my own question.  In order to run a pipeline using a particular source branch, you can use the queue_build method on the build client (instead of the pipelines client).  When doing this, you should use the pipeline id as the build definition id.

MS pointed me to your post and I am glad you figured out a work around. Do you have any suggestions on, how would we send pipeline variables It seems to have a parameters :param parameters: The parameters for the build of type string.

I haven’t tried to do this yet, but I would recommend trying to solve it using the same approach I used to solved my first problem:

Install the azure cli
Run the command “azure pipelines run” to run a pipeline, passing in all the options needed for branches, variables, etc
Turn on debug mode for the cli
Watch what REST calls it makes
See what SDK method corresponds to the REST calls it is making

Since it is possible to send in variables and a custom branch via the CLI, I’m confident there is a way to do it through the SDK, even if it is not obvious.
Good Luck!
-Nick
From: venutm<EMAIL_ADDRESS>Reply-To: microsoft/azure-devops-python-api<EMAIL_ADDRESS>Date: Sunday, May 3, 2020 at 10:19 AM
To: microsoft/azure-devops-python-api<EMAIL_ADDRESS>Cc: Nick Komen<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [microsoft/azure-devops-python-api] No documentation on how to trigger pipeline build on 'master' branch. (#290)
MS pointed me to your post and I am glad you figured out a work around. Do you have any suggestions on, how would we send pipeline variables It seems to have a parameters :param parameters: The parameters for the build of type string.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fazure-devops-python-api%2Fissues%2F290%23issuecomment-623134530&data=02|01|nick.komen%40churchofjesuschrist.org|551e67f9fbc94c23f4ba08d7ef7db5d4|61e6eeb35fd74aaaae3c61e8deb09b79|0|0|637241195516731709&sdata=7R0tU2Ph8H3BRHNaaDugUAm934xCOpIGXCMY3WiwgAA%3D&reserved=0, or unsubscribehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMUSH4LPFXPE7TH4FKDGM43RPWKPZANCNFSM4JHT5Z7Q&data=02|01|nick.komen%40churchofjesuschrist.org|551e67f9fbc94c23f4ba08d7ef7db5d4|61e6eeb35fd74aaaae3c61e8deb09b79|0|0|637241195516741704&sdata=%2Bhvxd7uVYN%2BT%2FAzP18dbHdikHilt5Q4ZKT%2BFEiF9ofE%3D&reserved=0.

Thanks fr the suggestions. I am able to pass all the variables as a json string against the parameters: "{}".
Now I have a different challenge. How would I pass the template parameters? I tried adding templateParameters to the run_parameters in pipeline_client as well. None of these seem to work.

I'll answer my own question. In order to run a pipeline using a particular source branch, you can use the queue_build method on the build client (instead of the pipelines client). When doing this, you should use the pipeline id as the build definition id.

@nickkomen can you please provide a code example? I'm trying like below and unfortunately getting errors
a = build_client.get_build(project='MyProject', build_id=1769, property_filters=None)
response = build_client.queue_build(build=a, project='MyProject')


Newly assigned #Admin rooms are being shown as read without me opening the message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Logged in and logged out on all platforms
Cleared cache and cookies

Expected Result:
New leads should automatically be showing up as unread
Actual Result:
#Admin room is being read without me opening the chat
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.2.87-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Guide team
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679075146430009
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01718d045eb4096299
Upwork Job ID:<PHONE_NUMBER>983927808
Last Price Increase: 2023-03-28

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@alex-mechler I heard you may have some ideas about how to reproduce this (as you've worked with guide stuff). Do you know how to generate a lead as if you were a guide on prod? Nobody responded when I asked in Slack a couple times. 😭

You can't do that on prod. We just had an issue to do the opposite, and mark them all as read 🤣 https://github.com/Expensify/Expensify/issues/270850. Asked in slack what the intended behavior here is https://expensify.slack.com/archives/C07F03W66/p1679999300158849

Oh wow that's good to know, thanks! subscribed

Per discussion this requires backend changes, so I'll mark it Internal accordingly

Job added to Upwork: https://www.upwork.com/jobs/~01718d045eb4096299

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

It looks like https://github.com/Expensify/Web-Expensify/pull/36885 should have fixed this cc: @jasperhuangg

Actually this is just a dupe of https://github.com/Expensify/Expensify/issues/270848, closing this out


Random crash on Mac OS

Probably some slow networking, refreshing UI and handling user click at the same time:
9   UIKitCore                     	       0x1c4d73c40 -[UICollectionView _selectItemAtIndexPath:animated:scrollPosition:notifyDelegate:deselectPrevious:performCustomSelectionAction:] + 1004
10  UIKitCore                     	       0x1c4b3aa94 -[UICollectionView touchesEnded:withEvent:] + 480
11  UIKitCore                     	       0x1c4b29b34 forwardTouchMethod + 284
12  UIKitCore                     	       0x1c4b29b34 forwardTouchMethod + 284
13  UIKitCore                     	       0x1c4b29b34 forwardTouchMethod + 284
14  UIKitCore                     	       0x1c4b294a8 -[UIWindow _sendTouchesForEvent:] + 780
15  UIKitCore                     	       0x1c4b0fcfc -[UIWindow sendEvent:] + 3240
16  UIKitCore                     	       0x1c4b0e748 -[UIApplication sendEvent:] + 672
17  UIKit                         	       0x226faf88c -[UIApplicationAccessibility sendEvent:] + 96

I have steps:

Select Android makers 2023
Close/Open app
Select second day
Tap to "Are you secrets secure..." talk

App crashes on Mac

Thanks for the repro.  I see issue here and will push fix shortly.


Add non-exercise stage

As an author, I want to be able to add non-exercise stages that trigger some other action.

Add separate button to editor for new stage type
Add select menu for stage type (end, + life/lives, +time)
Add conditional options for stage type (always show/number of lives, number of seconds)

As a user, when I open a non-exercise stage, I want its effect to take effect.

end stage (finish flag icon): open confirmation dialog for ending the game.
+lives (heart icon): Receive the assigned number of lives (if not yet opened), play sound
+time (clock icon): Receive the assigned time as bonus (if not yet opened), play sound

Done, just needs refinement and testing.


(WIP) feat: add Renovate

Closes #998.

I've enabled the Renovate GitHub App 😁

Now, hopefully, a PR like this will be opened: https://docs.renovatebot.com/getting-started/installing-onboarding/#repository-onboarding

Changed it to Mode: Interactive. Also we don't need the changes in this PR right?

@epr3  should be good now https://github.com/radix-vue/radix-vue/pull/1049

Changed it to Mode: Interactive. Also we don't need the changes in this PR right?

@zernonia Yes, I'll close this PR. Thank you for changing the setting! 🚀


setup ci to cut a release on tag push

@rsvihladremio didnt you already fix this in https://github.com/rsvihladremio/dremio-diagnostic-collector/commit/a3566e0f0f8f8aa43cea6464f6e30e5c475eead6

no this is an actual release..so instead of cutting it from our laptops it is pushed out via github runner, I have done this on several repositories prior for example https://github.com/foundev/astra-cli/blob/main/.github/workflows/goreleaser.yml


Update Reading-List.md publish date

@Sonya-7 I somehow removed this change from the previous PR haha

Also fixed Salaries.md publishDate in this PR

@Sonya-7 I somehow removed this change from the previous PR haha

No worries 👍


Create a SceneBoundary widget

Create a RepaintBoundary like widget that indicates that its complex widget subtree is static and should be raster cached with an eviction mechanism in the render object.

Should we just expose the bits on RepaintBoundary?

Unassigning and clearing milestone since my understanding is @xster is working on iOS features now.

@xster : is this still something that you'd like to pursue considering our newly added retained-engine-layer subtree raster cache? (See https://github.com/flutter/flutter/issues/21756 and https://github.com/flutter/flutter/issues/23535)

The raster cache is a legacy feature at this point (no plans on adding it to impeller) so I'm going to close this.


Can't import in Meteor 1.4.2-beta.6

If I import SimpleSchema from 'simpl-schema' in Meteor 1.4.2-beta.6 I get complaints of Promise.await not being a function. This is what occurs when babel-runtime is not being included properly.
It looks like you're including babel-polyfill in main.js. You shouldn't be include a runtime polyfill in a library. That's up to the application developer to handle.
If you need a polyfill within the library you should add the babel-plugin-transform-runtime plugin in your .babelrc as a build step.

The tests still pass without babel-polyfill. I don't think you need to use babel-plugin-transform-runtime either.
See https://babeljs.io/docs/usage/polyfill/

This will emulate a full ES2015 environment and is intended to be used in an application rather than a library/tool. This polyfill is automatically loaded when using babel-node.

Any movement on this?

Fixed via #31. Please see https://github.com/clayne11/node-simple-schema.


View helpers in rabl template throws 'undefined method' if used with gon

My rabl templates are working fine if I use it outside gon for example as a response to XHR requests, but if I use the same template with gon it throws error in view helper methods used in the rabl templates. In Rabl, using Rails view helpers are allowed, so it seems that gon might be causing some issue in there, is it an issue with the view context ?
Here's my sample rable template:
attributes :id, :name, :created_at
node(:time_ago) { |m| distance_of_time_in_words(m.created_at, Time.now) }

There seems to be an issue filed in the Rabl repository related to this problem:
https://github.com/nesquena/rabl/issues/147
Thanks,
Arnab

Bumping this thread to see if there is any update on it? @gazay


aiologger closes sys.stdout

Why does aiologger close sys.stdout or any handler it doesn't open()?
import asyncio
import aiologger

async def testaiolog():
    logger = aiologger.Logger.with_default_handlers(name="my-logger")
    await logger.info("foo")

print("works")
asyncio.run(testaiolog())
print("doesn't work")

results in:
Traceback (most recent call last):
  File "/Users/mike/Documents/.../aiologgertest.py", line 12, in <module>
    print("doesn't work")
ValueError: I/O operation on closed file.
works
foo

Why does aiologger close sys.stdout or any handler it doesn't open()?
import asyncio
import aiologger

async def testaiolog():
    logger = aiologger.Logger.with_default_handlers(name="my-logger")
    await logger.info("foo")

print("works")
asyncio.run(testaiolog())
print("doesn't work")

results in:
Traceback (most recent call last):
  File "/Users/mike/Documents/.../aiologgertest.py", line 12, in <module>
    print("doesn't work")
ValueError: I/O operation on closed file.
works
foo

Any chance you found a solution?

Any updates on this issue?

Hello there! I think I've got a semi-reasonable workaround for anyone that's curious. Rather than directly passing sys.stdout or sys.stderr, we create a dup of either and pass that. Example below:
import os
import sys
from aiologger.handlers.streams import AsyncStreamHandler

AsyncStreamHandler(
    stream=os.fdopen(
        os.dup(sys.__stdout__.fileno())
))

Full credit to this StackOverflow answer for the idea: https://stackoverflow.com/a/40845164. Hope this helps!


Disable asynchronous message transfer?

Hi, I am new to Timely Dataflow
I am so impressed by the design philosophy of Timely Dataflow.
Currently, I am investigating the performance impact of its asynchronous execution engine on
for some BSP-based algorithms such as PageRank.
Is there any way for me to disable 'asynchronous booster' in the system so that I can check the performance benefit of it?
Thanks!

Hello.
Thanks for the nice words!
There is no easy way to make message transmission synchronous, without writing your operators to hold back the data themselves. The main point of timely dataflow (and dataflow models generally) is that the movement of data should drive the computation, rather than an external scheduler. So, 100% the system is designed for asynchronous message transfer, to the extent that there isn't a thing for it to be "synchronous" with.
Hope this helps!


Prompt shows [default value: ...] for Consult narrowing

This is not strictly a Selectrum issue but due to some bad interaction with a recent consult-buffer change. In order to ensure that pressing C-x b RET works properly with consult-buffer if Icomplete and default completion is used, I had to specify a default candidate (https://github.com/minad/consult/commit/8821545c151f21bec8b965992bb9d7cc0702ed9a). Now the problem is if I am using narrowing, the minibuffer completion predicate is set to perform the narrowing. Then the default candidate is not present in resulting candidate list, which leads Selectrum to show this [default value: ...] message which is annoying given that there is already a Consult narrowing indicator present. Now I wonder what the proper way is to suppress the Selectrum default value indicator.

I tried to set minibuffer-default to nil when narrowing is active, but this unfortunately does not work. It is also pretty much a hack I would like to avoid.
Fix it on the side of Selectrum to only show the default value indicator when the default value is not part of the initial set of candidates. This also does not sound like the perfect solution.
Offer some other way to suppress the indicator? I could then advise consult-narrow such that the suppression flag is set when narrowing is active.
Maybe you have some better idea?

Maybe the best solution would be if selectrum offers a customizable option selectrum-show-default-indicator. This could then be disabled globally and I could also use it locally for narrowing. This would also fix my general annoyance with this message. Maybe even better, use a selectrum-default-value-format which could be customized and also set to nil to disable. Then I would probably configure it in my init.el such that it is less verbose, e.g., [default: ...].

I think adding an option is good, we can also allow it to be a function so users have full freedom to indicate it however they like.

I tried to create a patch for this. One question - Why is selectrum--current-candidate-index negative?

This is used to indicate selection of the prompt it's not part of the candidates so -1 was chosen for that.

Thanks for merging!


Various tweaks to the first chart

Move y-axis label to the left of the axis
Have the max posts on the left
Sort bars alphabetically, disregarding capitalization
Fix missing icon
Orange bars / white text
Remove {{ template }} thing on first load
Grab total comments from JSON without calculating it

lgtm


 Learn more about stacking.

Join @benesjan and the rest of your teammates on  Graphite

Docs Preview
Hey there! 👋 You can check your preview at https://66b3464bcbacdaac3c2b6095--aztec-docs-dev.netlify.app

Benchmark results
Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 4,241 (+79%)
avm_simulation_time_ms (Token:_increase_public_balance): 9.55 (-54%)
protocol_circuit_witness_generation_time_in_ms (base-parity): 600 (+103%)
protocol_circuit_proving_time_in_ms (base-parity): 1,698 (+55%)
l2_block_building_time_in_ms (16): 42,596 (+16%)
l2_block_rollup_simulation_time_in_ms (16): 42,596 (+16%)
l2_block_public_tx_process_time_in_ms (16): 40,683 (+16%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,726
1,541
703
749 (+1%)
761 (-1%)

proof_construction_time_sha256_30_ms
11,696
3,151
1,405
1,436
1,470

proof_construction_time_sha256_100_ms
43,906
12,376
5,665
5,580
5,494 (+1%)

proof_construction_time_poseidon_hash_ms
78.0
48.0 (+2%)
34.0
58.0 (-2%)
88.0

proof_construction_time_poseidon_hash_30_ms
1,519
417
201 (+1%)
222 (-2%)
272 (+1%)

proof_construction_time_poseidon_hash_100_ms
5,627
1,515
677
748 (+4%)
751

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
740
740
740

l1_rollup_calldata_gas
6,704
6,718
6,704

l1_rollup_execution_gas
611,971
612,136
612,273

l2_block_processing_time_in_ms
241 (+2%)
433 (-1%)
810 (+3%)

l2_block_building_time_in_ms
10,512 (+11%)
19,446 (+5%)
:warning: 42,596 (+16%)

l2_block_rollup_simulation_time_in_ms
10,511 (+11%)
19,446 (+5%)
:warning: 42,596 (+16%)

l2_block_public_tx_process_time_in_ms
8,894 (+13%)
17,563 (+5%)
:warning: 40,683 (+16%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
2,691 (-2%)
3,589

node_database_size_in_bytes
12,714,064
16,912,464

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

GasToken:_increase_public_balance
92.9 (-3%)
8,139

GasToken:set_portal
10.1 (+1%)
2,362

Token:constructor
119 (+1%)
31,107

FPC:constructor
94.4
24,011

GasToken:mint_public
78.5 (-1%)
6,150

Token:mint_public
93.1 (+11%)
11,720

Token:assert_minter_and_mint
79.1 (-11%)
8,028

AuthRegistry:set_authorized
9.13 (+26%)
4,537

FPC:prepare_fee
281 (-5%)
8,812

Token:transfer_public
26.3 (+3%)
47,374

FPC:pay_refund
67.4 (+4%)
12,114

Benchmarking:increment_balance
1,071 (+7%)
7,450

Token:_increase_public_balance
:warning: 9.55 (-54%)
8,960

FPC:pay_refund_with_shielded_rebate
138 (+8%)
12,663

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.154 (-1%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.15 (+1%)
3.92 (+2%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.112 (+1%)
0.111 (+2%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.6 (+6%)
17.6 (-3%)
30.9 (+3%)
58.0 (-2%)
115 (+3%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.112 (+6%)
0.103 (-3%)
0.101 (+2%)
0.100 (-2%)
0.102 (+2%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.9 (+5%)
25.2
43.3 (+2%)
81.0 (+1%)
161 (+1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.113 (+5%)
0.102 (+1%)
0.105 (+1%)
0.101 (+1%)
0.101 (+1%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
17.0 (+2%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
133
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.109 (+2%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
63,593
665,010

Transaction size based on fee payment method
| Metric |  |
| - |  |


Added the ability to add and remove margins and paddings responsively

@adamrenklint @mlabod @adamschroder Could one of you guys take a look at this PR please? I'd really appreciate it. Love you all

LGT Nathan


Added a name in jam-contribution

changes :
I have added my name in jam-contribution.

name added and accepting commit


Utility: retrieve function from PC

We should have a utilitiy function that can determine the currently active function (as an AST node) given the PC or bytecode offset. Additional information required is the source mapping and the AST.

In order to solve this task, we could implement a function that takes an AST, a source location and an AST node type and returns the ast node that contains the given source location. For every node it sees which child node contains the given source location and descends into that child until it reaches a node that has the given type.


Local IP Address (Homebase)???

What IP is this asking for in the CONFIG? Door-bell, hoobs??
Thanks for the help, I think my main issues is Im old:)

It is for the Homebase. But I don't think we use it.

We should remove the ip address from the config.

PR #110

Lan IP address can be catch later. Better if we use the function instead of relying on this static settings which could be pretty hard to guess.


[Enhancement] Improve overall UI

Improving the overall UI to provide an exceptional user experience. Users can easily and intuitively interact with the website.
Could you please assign this task to me under GSSoC with the appropriate level?

@ParthNakum21 There are currently many issue raised regarding the UI change, let them finish first & then if the UI needs improvement, I'll assign the issue to you :)

@ParthNakum21 There are currently many issue raised regarding the UI change, let them finish first & then if the UI needs improvement, I'll assign the issue to you :)

Thank you for the reply!, I'll be ready to tackle any improvements afterward.

hello, please assign this issue to me under GSSOC'24.

@ParthNakum21 What changes you want to make, do provide a prototype for that.


Allow editor to edit metadata name during builk upload or single upload.

Fixes #5549
@tisto screenshot

Hey @iFlameing , Can you please help me in passing acceptance test ? I tried all the things that were mentioned in docs

Hey @iFlameing , Can you please help me in passing acceptance test ? I tried all the things that were mentioned in docs

In which pr do you need help.

@Aarav238 all the acceptance tests in this PR pass, so I don't understand what help you need here.

Yeah @stevepiercy I am not talking about this PR, I was seeking help for my PR, It was failing for acceptance tests. Now it is working fine.
Thanks @iFlameing @stevepiercy.

@sneridagh new screenshot

@sneridagh ping. You can merge this now.


[#114083869] Buyer views responses to a brief

Completes this story: https://www.pivotaltracker.com/story/show/114083869
Depends on new content:

[x] https://github.com/alphagov/digitalmarketplace-frameworks/pull/213

Once that is merged it should all work. (At least everything works locally and all tests pass).
Things it does:

Adds closing date to live briefs on the buyer dashboard
Shows closed briefs on the buyer dashboard, along with the number of responses received these link to...
A new page where buyers can read instructions about what to do next and download a csv file of eligible responses:

The link to download the csv downloads a csv with a header row and then a row for each eligible response, sorted in order with the most nice-to-haves at the top of the file

Things that still would be nice to be done (please if someone can pick this up after Easter while I'm away):

Content of the brief responses page needs a serious overhaul (what's there is just a placeholder not proper at all) - I know @roz and @ralph-hawkins have plans for it.  If they have the words then should be an easy fix-up.
Re-generate new schemas for the brief responses to include the new email field, and put them in the API (sorry, I forgot to do this right away because the story wasn't really about inputting responses)
Validation of the new email address field - i.e. that it looks like a real email address (don't know if this can this be done in the generated schema - might need something custom).  If it isn't straightforward then I'd be tempted to leave it out of this story and add to Pivotal to do later (as this isn't really a story about inputting brief responses).
Generating the csv all the logic is all in one big lump in the view - it might be nice to break out one or two bits of logic (e.g. the sorting of responses) into helper methods that can be unit tested, but I haven't had time to do that.  NOTE: I lost a lot of time trying to push the logic of matching responses to "boolean list" questions to their respective questions back into the ContentLoader.  It was ugly and hard and while it seems like the best place for it at first, believe me I think we should just stick with doing it in the view (or a helper method if you like).  Unless you really want to get involved.  But I really advise against it.

Some of the failure modes for the new page and csv download aren't tested - would be nice to get some more tests in (e.g. different framework states, brief states, etc.)

So it's just a bit of tidying up really :) Good luck, and thanks x

I have some design reckons :pencil2:

I've spoken to @ralph-hawkins in real life. He is happy for design issues to be picked up in a later story as there is a bit of a design backlog right now.

Looks good!
:+1:

Looks good to go once the other couple of things are fixed though :+1: :+1: :+1:

All fixed - will merge once the functional tests are back in action.


Create database model

As a ...
I need ...
So that ...
Details & Assumptions:

...

Acceptance Criteria:
Given [some initial state]
When [some event]
Then [some measurable outcome]

??? nothing shows here


Feature Request: SecureNAT supports IPV6

I had this post at vpnusers.com, but that forum seems idle and there are not many developers around. So I decide to post a duplicate here.

Hi guys,
I have been using Softether for years, which is a really convenient and powerful tool.
Recently, I'd like to get ipv6 connection on a ipv4 network while I have several VPS with ipv6.
After a bit search, I found some solutions by using soft tap and dnsmasq to accomplish ipv6 over ipv4, and I realize that SecureNAT function doesn't support IPV6.
Is it possible to add this feature in future version? Any plan about this?
Or anyone may know any easy way to setup ipv6 over ipv4 by Sothether?
Thank you guys to make such amazing tool!

I'm curious if this has been implemented yet. Can anyone confirm or deny? Thanks!

You don't need secure NAT to tunnel Dual Stack... You can tunnel dual stack by using a bridge to TAP_INTERFACE and using dnsmasq for the dhcp server functions. You also have to use iptables and ip6tables NAT... In order to use ip6tables NAT you need kernel version 3.3 or higher on the server.

@cmdwhoami
Thanks for your information, I am now mainly using something else.
SecureNAT is really easy to set up, that is why I request this feature at first place. Seems two years don't count, Softether is still there.... the same :smile:

You don't need secure NAT to tunnel Dual Stack... You can tunnel dual stack by using a bridge to TAP_INTERFACE and using dnsmasq for the dhcp server functions. You also have to use iptables and ip6tables NAT... In order to use ip6tables NAT you need kernel version 3.3 or higher on the server.

Probably, yes, but this isn't documented properly anywhere. Do you have any pointers? Thank you!

Depends on what the VPN server software is run on. If it's a Openvz container (VPS) you might be out of gas... If it's on a server behind NAT where the router will handle the DHCP it's as easy as disabling secure NAT and bridging to eth0 or wlan0... if your not behind NAT and need to handle the DHCP with dnsmasq you might need to come over to discord and we can talk about it in real time in chat. discord invite: https://discord.gg/QByKXA9

It was indeed an OpenVZ container, but I now have dedicated hardware at my discretion. I'll join tomorrow so we can discuss.

I'm stuck at the moment myself with tunneling Dual Stack cuz I'm inside a OpenVZ container with a kernel that doesn't support ip6tabes NAT... Since it's OpenVZ and I don't control the host I can't upgrade the kernel... Now if it was a KVM container it'd be a different story... I wonder if I could open a support ticket and asked them to put my IPv6 addresses on tap_interface??? I've read bridge utils won't work inside a OpenVZ container either but I've been contemplating trying it anyway. Yea, stop by the discord server... Its only a week or so old ATM but its growing daily.


Remove Picasso dependency

Make it out of box.
Just add a callback to return the ImageView.

You think it's better to add just a getter to the imageview ?
It's an good idea, but I added the dependency for implementing directly the fading animation in the callback.
mViewPager.setImageUrl(imageUrl,fadeDuration);
how do you think we can proceed ?

I'll do it.

ok great :+1:
thanks for helping me improving MaterialViewPager, it's so cool

@ppamorim
is there any news about this?
thanks


No by-summoner endpoint in leagues-v3

Hello, as far as I can tell by the wiki, there is no by-summoner endpoint in your leagues-v3.
https://developer.riotgames.com/api-methods/#league-v3/GET_getAllLeaguesForSummoner
I'd like to use your API in a project, but I cannot until this feature is added.
(No rush)
Thanks.

I assume since you only pushed the other league-v3 endpoints the other day that this is in the works.

@ImNatho Oh, this is already in the library. Sorry, I still am updating the Wiki haha. I forgot to include it in the Tables of Contents, but it's actually in between the Challenger League and Master League section.
/lol/league/v3/leagues/by-summoner/{summonerId}
Get leagues in all queues for a given summoner ID.
getLeagues({ region, accountId/accId (int), id/summonerId/player/Id (int), name (str) }, cb)
Namespaced Functions: League.getLeagues, League.leagues, League.get
Example 1: k.League.getLeagues({ summonerId: 20026563 }, KindredAPI.print)
Example 2: k.League.get({ summonerId: 20026563 }, KindredAPI.print)
Example 3: k.League.get({ id: 20026563 }, KindredAPI.print)
Example 4: k.League.get({ name: 'Contractz' }, KindredAPI.print)

@ImNatho Out of curiosity, do you think the current state of documentation is fine (easy to understand, easy to move around)? I've completely finished it, but am interested in your opinion.

It's pretty good. I was able to covert my existing application to kindred-api in ~40 minutes. (Over 100 endpoint implementations)


Dispatch hash operations through the driver wrapper layer

Description
This PR is (mostly) a refactoring of existing code, in order to dispatch psa_hash_xxx calls through the driver wrapper layer. The hashing implementation on top of Mbed TLS code that used to reside inside of psa_crypto.c has been moved out into its own compile unit psa_crypto_hash.c as defined by the documentation work from @ronald-cron-arm in #3933
There is one other change: the implementation of psa_hash_compare now first calls the all-in-one psa_hash_compute function to calculate the hash into a local buffer, and then does a time-constant memcmp. This way of setting up the call tree will lead to more efficient execution when plugging in actual hardware drivers, since you'll only hit the driver once instead of potentially up to three times (setup/update/verify).
Supersedes #4043
Status
READY
Requires Backporting
NO
(new functionality)
Migrations
NO
(not present in earlier releases)
Todos

[X] Tests
[X] Documentation

Steps to test or reproduce
Test coverage through existing test cases, since the previous implementation has been fully moved inside of a 'software driver'.

CI is failing.
Error in all_sh-freebsd-test_clang_opt:

test_clang_opt: build/test: clang -O0, full config

Thu Feb 18 17:53:26 UTC 2021

CC    aes.c
CC    aesni.c
CC    arc4.c
CC    aria.c
CC    asn1parse.c
CC    asn1write.c
CC    base64.c
CC    bignum.c
CC    blowfish.c
CC    camellia.c
CC    ccm.c
CC    chacha20.c
CC    chachapoly.c
CC    cipher.c
In file included from cipher.c:29:
In file included from ../include/mbedtls/cipher_internal.h:36:
In file included from ../include/psa/crypto.h:3763:
../include/psa/crypto_struct.h:98:43: error: missing field 'ctx' initializer [-Werror,-Wmissing-field-initializers]
const struct psa_hash_operation_s v = PSA_HASH_OPERATION_INIT;

                                      ^

../include/psa/crypto_struct.h:95:36: note: expanded from macro 'PSA_HASH_OPERATION_INIT'
#define PSA_HASH_OPERATION_INIT {{0}}
                               ^

1 error generated.
make[1]: *** [Makefile:270: cipher.o] Error 1
make: *** [Makefile:17: lib] Error 2
^^^^test_clang_opt: build/test: clang -O0, full config: command make CC=clang CFLAGS=-O0 -std=c99 -pedantic -Wall -Wextra -Werror -> 2^^^^
(skipped because the build failed)

Other jobs are failing but it seems it is always the same error as above.

@ronald-cron-arm should be fixed now. Strange that the local test runs are not complaining about that.

This PR is changing the API. Please add a changelog entry.

@mstarzyk-mobica It is not changing any public API. The content of the struct is checked by the CI ABI checker, but changing these hasn't required a changelog entry before...

I confirm that psa/crypto_struct.h is a private header, so changing it is not an API change, only an ABI change. No changelog entry is necessary just because psa/crypto_struct.h changes. I don't think this PR should have a changelog entry since the feature it's adding (driver dispatch) is not in its final intended form, but requires modifying a library source file (library/psa_crypto_driver_wrappers.c).

@mstarzyk-mobica It is not changing any public API. The content of the struct is checked by the CI ABI checker, but changing these hasn't required a changelog entry before...

Ah, alright! :)

@ronald-cron-arm I believe I have addressed all of your feedback now.

Dynamic allocation of driver contexts is gone, and a new paradigm for declaring driver context structures has been set up
Test driver hooks are added for hash operations
Superfluous operation pointer null-checks have been removed
Input argument checking has been moved back into psa_crypto.c where it made sense (i.e. all of the ones you pointed at minus the output buffer checking, which I believe belongs with the code that is doing the actual output).

A few jobs are failing. All the ones have checked have the same error:
psa_crypto_hash.c: In function 'mbedtls_psa_hash_update':
psa_crypto_hash.c:215:12: error: unused parameter 'input_length' [-Werror=unused-parameter]
size_t input_length )

Thanks, should be fixed now

CI is OK no genuine failure.

@ronald-cron-arm @tom-daubney-arm @mstarzyk-mobica Given the PR now has design approval, it's ready for your (re-)review.

All of @ronald-cron-arm 's feedback should now be addressed. I rebased as per the rewrite request, and added the other changes as new commits.

@ronald-cron-arm I updated the define guards like you asked.

@tom-daubney-arm Please have a look to the last version.

@mpg @gilles-peskine-arm @yanesca Could you have the final look to this PR and merge it if this is ok ?


Merge option not there.

Migrating from redis  424 to 426 we checked that merge option has been removed from stubs and we have to manually  put values in the sample stubs.
Can you please confirm us whether same process will be followed is future releases?

Hi @rahul221192
We've recently updated our docs and manifest templates to use the new BOSH2 structure. Manifest generation and deployment should be a lot simpler now.
We'll be removing the stubs from templates/ in the near future and corresponding generate manifest scripts. The README describes the new way to deploy cf-redis-release: https://github.com/pivotal-cf/cf-redis-release/blob/master/README.md
Thanks


Error while compiling 7.3

Describe your problem here.
everytime i try to compile, this happens:
source/psychlua/CallbackHandler.hx:55: characters 18-33 : Class<llua.Lua_helper> has no field sendErrorsToLua
export/release/windows/haxe/ApplicationMain.hx:153: characters 5-36 : ... Called from macro here

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
I took out the "Call" in "TeaCall"

I have the same problem, but with this message:
source/psychlua/HScript.hx:317: characters 89-96 : Type not found : TeaCall

I have the same problem, but with this message: source/psychlua/HScript.hx:317: characters 89-96 : Type not found : TeaCall

take out all the "call" by selecting one of these "teacall", right click and click on "change all ocurrences", then rewrite just "Tea"

I did that but this now popped up:
source/psychlua/CallbackHandler.hx:55: characters 18-33 : Class<llua.Lua_helper> has no field sendErrorsToLua
export/release/windows/haxe/ApplicationMain.hx:153: characters 5-36 : ... Called from macro here
source/psychlua/CallbackHandler.hx:55: characters 41-46 : Class<llua.LuaL> has no field error
export/release/windows/haxe/ApplicationMain.hx:153: characters 5-36 : ... Called from macro here
C:/Users/Marqus/Desktop/haxe/lib/flxanimate/3,0,4/flxanimate/frames/FlxAnimateFrames.hx:142: characters 21-27 : Field concat should be declared with 'override' since it is inherited from superclass flixel.graphics.frames.FlxAtlasFrames
C:/Users/Marqus/Desktop/haxe/lib/flxanimate/3,0,4/flxanimate/frames/FlxAnimateFrames.hx:142: characters 21-27 : Field concat overrides parent class with different or incomplete type
C:/Users/Marqus/Desktop/haxe/lib/flixel/5,8,0/flixel/graphics/frames/FlxAtlasFrames.hx:472: characters 18-24 : ... Base field is defined here
C:/Users/Marqus/Desktop/haxe/lib/flxanimate/3,0,4/flxanimate/frames/FlxAnimateFrames.hx:142: characters 21-27 : ... Different number of function arguments
source/backend/Paths.hx:605: characters 7-18 : flxanimate.FlxAnimate has no field loadAtlasEx (Suggestion: loadAtlas)
source/objects/Character.hx:304: characters 87-101 : flxanimate.animate.FlxAnim has no field lastPlayedAnim
source/objects/Character.hx:335: characters 20-26 : flxanimate.animate.FlxAnim has no field resume
source/psychlua/FunkinLua.hx:280: lines 280-283 : Int should be Bool
source/psychlua/FunkinLua.hx:280: lines 280-283 : ... For function argument 'f'


Head Plugin Not Registered when invoked via elasticsearch-transport-thrift.

When I attempt to invoke the elastic search head plugin via the transport thrift plugin, elasticsearch will give the following response:
[Error: {"error":"IndexMissingException[[_plugin] missing]","status":404}]
It was invoked with the following url http://localhost:8124/_plugin/head/
This is because the elasticsearch-transport-thrift plugin does recognize the _plugin/head as a registered handler.  When I invoke the service through HTTP port 9200, then the head plugin works, so it seems that the rest controller between elasticsearch and the elasticsearch-transport-thrift are out of synch. for some reason.
I'm thinking a fix would be to just register the head plugin manually.  The only problem is that the head plugin is written in pure javascript.

This plugin has been stopped since elasticsearch 2.0.


Link to these bindings in the official Nuklear README

Feel free to make a PR to the Nuklear repo adding a link to this V bindings endeavor. I'll happily merge it. If you think it's not the time yet, then no hurry :wink:.

Good idea @dumblob
I think I first have to clean things a bit first..

Done !
I set @dumblob as PR reviewer :-)

Merged :wink:.

thanks


Can not name a symlink with no extension

I want to symlink a file and rename it without an extension...
gulp.task('default', function() {
  return gulp.src('.pre-commit')
    .pipe(symlink('.git/hooks/pre-commit'));
});

What I want: .git/hooks/pre-commit -> ../../.pre-commit
What I get: .git/hooks/pre-commit/.pre-commit -> ../../../.pre-commit

@ben-eb I use gulp-util 3.0.2 and get the error
fs.js:185
  binding.stat(pathModule._makeLong(path), cb);
      ^
TypeError: path must be a string

@gaowhen See also: https://github.com/ben-eb/gulp-symlink/pull/22

@ben-eb thanks, #22 works.


Serialize/deserialize tagged newtype variant containing unit

To me, it seems that a tagged newtype variant containing () should be serializable/deserializable in the same way as unit variants. Specificly I have the following enum:
#[derive(Serialize, Deserialize, Debug)]
#[serde(tag = "result", rename_all = "snake_case")]
enum Response<T> {
    Success(T),
    Error {
        ...
    },
}

I'd expect Success(()) to pe deserialized from and serialized to { "result": "success"}, but that doesn't seem to be the case. It doesn't work to deserialize it and when I try to serialize it (with serde_json) I get the following error:
Error("cannot serialize tagged newtype variant Response::Success containing unit", line: 0, column: 0)

Is there any reason why this doesn't work, or should we fix this? I'd would be happy to make a PR.

It would be fine to make this work I think.

The PR is: #2303


[SR GeekCamp] show partitions statement support of list partition

issue #4035
What type of PR is this：

[ ] bug
[X] feature
[ ] enhancement
[ ] others

Create Table for single column partition
create database example_db  ;
use example_db ;

CREATE TABLE t_recharge_detail_single(
    id bigint  ,
    user_id  bigint  ,
    recharge_money decimal(32,2) ,
    province varchar ,
    dt varchar
) ENGINE=OLAP
DUPLICATE KEY(id)
PARTITION BY LIST (province) (
   PARTITION p1 VALUES IN ("beijing","chongqing"),
   PARTITION p2 VALUES IN ("shanghai","tianjing")
)
DISTRIBUTED BY HASH(id) BUCKETS 1
PROPERTIES(
    "replication_num" = "1"
)

Create Table for multi column partition
CREATE TABLE t_recharge_detail_multi(
    id bigint  ,
    user_id  bigint  ,
    recharge_money decimal(32,2) ,
    province varchar ,
    dt varchar
) ENGINE=OLAP
DUPLICATE KEY(id)
PARTITION BY LIST (dt,province) (
   PARTITION p1 VALUES IN (("2022-04-01", "beijing"),("2022-04-01", "chongqing")),
   PARTITION p2 VALUES IN (("2022-04-01", "shanghai"))
)
DISTRIBUTED BY HASH(id) BUCKETS 1
PROPERTIES(
    "replication_num" = "1"
);

Show partitions from tableName
show partitions  from  t_recharge_detail_single  \G;
show partitions  from  t_recharge_detail_multi  \G;

Show result

Can you give a show result example?

Can you give a show result example?

Thanks for review , I had paste the result

[FE PR Coverage check]
:disappointed: fail : 108 / 171 (63.16%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/common/proc/TablesProcDir.java
1
50
02.00%

:large_blue_circle:
com/starrocks/common/proc/PartitionsProcDir.java
29
34
85.29%

:large_blue_circle:
com/starrocks/catalog/ListPartitionInfo.java
46
52
88.46%

:large_blue_circle:
com/starrocks/analysis/ListPartitionDesc.java
21
23
91.30%

:large_blue_circle:
com/starrocks/analysis/ShowPartitionsStmt.java
11
12
91.67%

[FE PR Coverage check]
:heart_eyes: pass : 162 / 178 (91.01%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/common/proc/PartitionsProcDir.java
29
34
85.29%

:large_blue_circle:
com/starrocks/catalog/ListPartitionInfo.java
51
57
89.47%

:large_blue_circle:
com/starrocks/analysis/ListPartitionDesc.java
21
23
91.30%

:large_blue_circle:
com/starrocks/analysis/ShowPartitionsStmt.java
11
12
91.67%

:large_blue_circle:
com/starrocks/common/proc/TablesProcDir.java
50
52
96.15%

[FE PR Coverage check]
:heart_eyes: pass : 162 / 178 (91.01%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/common/proc/PartitionsProcDir.java
29
34
85.29%

:large_blue_circle:
com/starrocks/catalog/ListPartitionInfo.java
51
57
89.47%

:large_blue_circle:
com/starrocks/analysis/ListPartitionDesc.java
21
23
91.30%

:large_blue_circle:
com/starrocks/analysis/ShowPartitionsStmt.java
11
12
91.67%

:large_blue_circle:
com/starrocks/common/proc/TablesProcDir.java
50
52
96.15%

run starrocks_be_unittest


BindingEngine injected as undefined

In the code bellow bindingEngine is undefined.
I'm doing something wrong or it's a bug?
I'm using latest aurelia bits.
import {inject} from ‘aurelia-framework’;
import {BindingEngine} from ‘aurelia-binding’;

@inject(BindingEngine)
export class MyClass {
   constructor(bindingEngine) {
            this.observer = bindingEngine.propertyObserver(this.foo, ‘x’);
   }
}

hmm strange- seems to be working on the plunker:  http://plnkr.co/edit/T1WjaU?p=preview
What does jspm inspect --forks say?

@jdanyow I figured out the problem... it's not related to inject and it's not a bug, sorry.
The question is that I'm using compose with a class created by a factory and that factory creates the instance of MyClass so, the DI is not used.
How to make a factory, or better, how to load a module dynamically in a way that DI injected constructor is respected? should I use aurelia-default-loader?

I solved the problem with the factory bellow, but I want to know if there's a way to do this in a way that I can create more xInput type without InputFactory need to import that new type.
import {inject, Aurelia} from 'aurelia-framework';
import {MemoInput} from 'res2/fields/memo/memo-input';
import {QpdInput} from 'res2/fields/qpd/qpd-input';
import {PioInput} from 'res2/fields/pio/pio-input';
import {CidInput} from 'res2/fields/cid/cid-input';

@inject(Aurelia)
export class InputFactory {
	constructor(aurelia) {
		this.container = aurelia.container;
		this.container.autoRegisterAll([MemoInput, QpdInput, PioInput, CidInput]);
	}

	create(fieldType) {
		switch (fieldType.toLowerCase()) {
			case 'memo':
				return this.container.get(MemoInput);
			case 'qpd':
				return this.container.get(QpdInput);
			case 'pio':
				return this.container.get(PioInput);
			case 'cid':
				return this.container.get(CidInput);
			default:
				throw new Error('cannot found input for filedType: ' + fieldType + '.');
		}
	}
}

Would container.registerTransient('memo', MemoInput) work for your use case?
Then you could do container.get('memo') or @inject('memo').

:+1:
thanks!

import $ from 'jquery';
import moment from 'moment';
import {bindable, inject, BindingEngine} from 'aurelia-framework';
import {HttpClient} from 'aurelia-fetch-client';
@inject(HttpClient, BindingEngine)
export class Rules {
constructor(bindingEngine) {
    this.rules = {
    ObsRanges: [
        { id: 1, low:1.0, high:1.99 },
        { id: 2, lowd:8.0, high:8.99 },
        { id: 3, low:3.0, high:3.99 },
        { id: 4, low:9.0, high:9.99 },
        { id: 5, low:5.0, high:5.99 }]
    };

    let subscription = bindingEngine.propertyObserver(this.rules, 'ObsRanges').subscribe((newValue, oldValue) => this.objectValueChanged(newValue, oldValue));
}

objectValueChanged(newValue, oldValue) {
    console.log(`observeMe value changed from: ${oldValue} to:${newValue}`);
}

}
Sorry, new to Aurelia. why I get following error:
RROR [app-router] Error: Error invoking Rules. Check the inner error for details.
Inner Error:
Message: bindingEngine.propertyObserver is not a function
Inner Error Stack:
TypeError: bindingEngine.propertyObserver is not a function
at new BetRules (http://localhost:9000/scripts/app-bundle.js:129:40)
at Object.invoke (http://localhost:9000/scripts/vendor-bundle.js:12057:14)
at InvocationHandler.invoke (http://localhost:9000/scripts/vendor-bundle.js:12022:168)
at Container.invoke (http://localhost:9000/scripts/vendor-bundle.js:12286:25)
at StrategyResolver.get (http://localhost:9000/scripts/vendor-bundle.js:11739:37)
at Container.get (http://localhost:9000/scripts/vendor-bundle.js:12225:23)
at http://localhost:9000/scripts/vendor-bundle.js:23128:73
at tryCatcher (http://localhost:9000/scripts/vendor-bundle.js:3411:23)
at Promise._settlePromiseFromHandler (http://localhost:9000/scripts/vendor-bundle.js:2627:31)
at Promise._settlePromise (http://localhost:9000/scripts/vendor-bundle.js:2684:18)
at Promise._settlePromise0 (http://localhost:9000/scripts/vendor-bundle.js:2729:10)
at Promise._settlePromises (http://localhost:9000/scripts/vendor-bundle.js:2808:18)
at http://localhost:9000/scripts/vendor-bundle.js:153:25
End Inner Error Stack


Increase unit tests coverage in package api

What this PR does / why we need it: This PR increases coverage of pkg/api/types.go from 40.32% to 100%.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): helps solve #2576
Special notes for your reviewer:
If applicable:

[ ] documentation
[x] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

tested accelerated networking still works at https://jenkins.azure-containers.io/view/acs-engine/job/k8s-accelerated-networking/186/console

/approve
/lgtm
🎉


Time when next Task should be run

I think thats not possible at the moment - but maybe a nice-to-have feature.

Is it possible to get the time from scheduler, when the next task should be run?
If i know, when next task should be run, i can sleep until this time.
Maybe this can reduce power consumption a lot.
I have tested this in a little proof of concept where i calc the shortest time to the next task run in the sleep callback.
At a first look it looks like working properly - maybe thats a nice feature for the future?
Have you thought about such a function till now - and do you think that there are some architecture problems for code this in a fast and stable way?
My quick-and.dirty test has reduced my power consumtion round about 50% (calced sleep time <> sleep time fixed 1000us)

I did think about this. It would work only in very simple cases, and there are other issues with putting MCU to sleep for longer than 1 ms:

TS relies on millis() to keep track of time. Most MCUs that do not have RTCs will lose track of time if put to sleep for longer since millis() will not be updated and when MCU wakes up it will think no time passed, so the scheduling will be off. YOu can argue that you know the sleep interval and can update the tasks schedule accordingly. Yes, BUT if MCU is woken up by an interrupt before the sleep interval was over, you cannot be sure that exactly what time passed and the scheduling will be off.
TS has a concept of event-driven task invocation (StatusRequest objects). There is no actual "start time" for those as they are just waiting for an event. If you put MCU to sleep the event maybe missed.

Since I have to maintain TS for general purpose I chose not to implement longer sleep intervals.
You can use this method:
https://github.com/arkhipenko/TaskScheduler/wiki/API-Task-Scheduler#long-timeuntilnextiteration-task-atask
for simple cases with just a few tasks, but remember - you need to reset the scheduling after wake up since millis() will be off.

thank you for your comments. I think you are right with the points given.


[CSBindings] Don't attempt to rank unviable bindings

If a type variable doesn't have any "direct" bindings let's not
consider it as viable to be attempted next. Such type variables
are helps purely to accommodate transitive binding inference
for other members of subtype chain.
Resolves: rdar://problem/66234725

@swift-ci please smoke test

@swift-ci please test source compatibility debug

@swift-ci please smoke test

@swift-ci please test source compatibility debug

@swift-ci please test source compatibility debug


Add Routes as module for path functions for Phoenix >= 1.4

I could try to add this feature for upcoming Phoenix 1.4 release.
# Phoenix 1.3
static_path

# Phoenix 1.4
Routes.static_path

@doomspork Nice. Always wanna take participation in Hacktoberfest and this look like a good opportunity.
How I should implement this?

Backward compatibility for Phoenix 1.3 ?
Mix generators with if condition or split in 2 different templates for generators ?
Any other suggestions...

That's a good question @sveredyuk 🤔  I believe @scarfacedeb's changes in #64 are not backwards compatible so these changes need not be.  I'm kind of the mind that we encourage people to upgrade to the latest Phoenix along with the latest Slime.  If they can't, they can continue to use an older version of phoenix_slime.
Any thoughts @Rakoth / @scarfacedeb?

I also think that backward compatibility it's legacy. Anyway people that use generators, use it for newest stable phoenix version. Task would be much simple without mind about Phoenix 1.3 support.

I think that generators are mostly used by newer projects, therefore it should be ok to drop phoenix 1.3 support for the generators.

On my way

I've been using phoenix from the master branch with slime for a little while and it seems to me like Routes.* works without any modification. I have a project with a whole bunch of
li = link("Log out", to: Routes.session_path(@conn, :delete, @current_user), method: "delete")
...
link rel="stylesheet" href="#{Routes.static_path(@conn, "/css/app.css")}"

And all those links and resources seem to be coming in fine. I think Routes is just an alias dropped in by the view module from Phoenix.Router.Helpers.

@the-mikedavis Yes, if you added Routes module to your existing path macros. We discussing here generators for slime. Now templates are not support Routes module


Add FileSystem.prototype.copy

-- should take advantage of faster native copying available in the underlying FS, when copying files within the same FS. That will also preserve maximum number of file attributes. In addition, this is the only easy guaranteed way to implement copying of Google Docs formats on GDrive. See mv.js.

Done


French translation v1

This is a PR concerning french translation of seed/challenges/00-getting-started/getting-started.json

@fnonga thanks for the PR.
Your branch name should start with one of fix/, feature/ prefixes. Name, your branches correctly next time, please.
You have pushed more than one commit. When you finish editing, squash your commits into one.
Please, review our Guidelines for Contributing, thank you!.

@fnonga Thanks so much for mixing up my bad french! I'll pull these commits into my PR so they're all together. I'll give you admin access.

@fnonga Do you have gitter?

@fnonga @bugron This can be closed as I've merged it into mine and the user has been notified.

Closing. Don't mix PRs, please, work in separate branches/PRs until you know what are you doing.


can't debug with ts-node

VSCode Version: 1.21.0
OS Version: win10
Today I update the  vscode， then I found the debug can't work with ts-node

launch.json
{

    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "launch",
            "name": "启动程序",
            "program": "${workspaceFolder}/start.js"
        }
    ]
}

start.js
require("ts-node/register");
require("./1.ts");

1.ts
var a = 1;
var b = 1;
console.log(a);

I can't debug in the 1.ts now.

VSCode Version: 1.20.0 is ok , just the 1.21.0 doest't work well

I can't add breakpoint, but add debugger can works

This is probably https://github.com/Microsoft/vscode/issues/45657#issuecomment-373556464, please see the comment there and try in the next Insiders build.


Update availability.md

Azure SignarlR and Azure Relay are GA on private link support

@juliansprt : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@asudbring - This PR was approved but not signed off, so it didn't enter the reviewer queue for merge. The article has been substantially updated since this PR was created. Could you take a look at the merge conflict and let us know whether you'd like to merge this PR after merge-conflict modifications (which our reviewer team can make, based on your directions) or instead move any relevant changes to the private repo?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
@MicrosoftDocs/public-repo-pr-review-team

Article previously updated
#please-close


Fixed bug in tm calculation

There was a problem in the calculation of the last days of a month.

Hi @Tekl7 & thank you for your contribution!
Would you be disappointed if I refactored this code to skip all the manual calculations and use the built-in C/C++ functions for date/time conversion? This would make your pull request obsolete. I personally never looked at this module in detail before and I just saw that it could probably be optimized using  gmtime and just adding the offset between Excel timestamp epoch and POSIX epoch.

Hi, if I'm not wrong, there is a disadvantage in the approach with POSIX epoch and gmtime function, that the dates before 1.1.1970 used in Excel cells could not be converted to tm structure because the dates could not be expressed in POSIX epoch timestamp, hence the gmtime function could not be used.

Hi @Tekl7 - timestamps (and tm_year) can be negative relative to the epoch:
#include <ctime> // struct tm, gmtime, strftime
#include <iostream>

void printTime( time_t timestamp )
{
	constexpr const size_t maxDateSize = 200;
	char dateString[ maxDateSize + 1 ];

	struct tm *structuredTime = gmtime( &timestamp );
	size_t actualSize = strftime(dateString, maxDateSize, "%FT%T", structuredTime);
	std::cout << "timestamp " << timestamp << " was converted to " << dateString << " (" << actualSize << " characters)" << std::endl;
}
int main()
{
	printTime( time( NULL ) ); // now
	printTime( 0 );            // begin of epoch
	printTime( -365 * 86400 );         // one year before epoch
	printTime( -( 365 * 1971 + 113 ) * 86400L );  // ca. year 0 CE
	printTime( -( 365 * 1972 + 113 ) * 86400L );  // ca. year -1 CE

	return 0;
}

Output:
timestamp<PHONE_NUMBER> was converted to 2024-09-05T11:41:23 (19 characters)
timestamp 0 was converted to 1970-01-01T00:00:00 (19 characters)
timestamp -31536000 was converted to 1969-01-01T00:00:00 (19 characters)
timestamp -62167219200 was converted to 0-01-01T00:00:00 (16 characters)
timestamp -62198755200 was converted to -1-01-01T00:00:00 (17 characters)

Does this answer your concern?

Researching this, I see one additional issue: Excel appears to have an epoch that wrongly assumes 1900 was a leap year, therefore epoch is off by 1 day until 1 March 1900.
This may require a manual patch when converting to gmtime.

Hi,
oh, wow, I did not know that the timestamp could be negative. Regarding this, I have no other concerns about using the gmtime approach.

It wasn't always like this - many systems until recently (and some older systems still do, I guess) were storing timestamps in 32 bit, and making those unsigned ints because the signed 32bit POSIX epoch would end in 2039, which isn't really good for storing dates.
But luckily, time_t is a signed long (int64_t) on modern compilers.

I started looking at XLDateTime, and realized I was overthinking the leap year logic - maybe a simpler logic is still possible, in which case I'll come back to your pull request. Keeping it open for now.


chore Don't print the stack for file system and it's derived class

Proposed changes
Issue Number: close #xxx
It would print tons of logs when fs returns error and it's too disk-consuming. This pr tries to disable all the stackprint logic for fs class and it's derivation.
This implementation is not the most optimal in terms of performance because the default-constructed Status carries a stack, which consumes a certain amount of memory. However, considering that error conditions are expected to be rare and this implementation requires minimal code modifications, I chose this approach. I would appreciate the reviewer's input: Should I specialize the template to false when constructing Status at each occurrence, or should I keep the current implementation?

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


How and where to credit upstream DH developers

We should mention the cidgoh/DataHarmonizer developers, funders, etc. in our documentation and on the submission portal
@ddooley

Just pointing to cidgoh/DataHarmonizer and acknowledgement of help from our DH developers is sufficient and appreciated!

I believe this has been addressed, but please reopen and post additional information if not. Thanks!


Refactor prometheus alerts. Lint and check robocop rules

lgtm

Latest version tested successfully here: https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods-ci-pr-test/442

Tested successfully here: https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods-ci-pr-test/442


Possible to use ngmap with multiple maps with direction panels?

Need to generate dynamic panel names during runtime.
But it seems the current direction directive does not support it.
Any work-around? Thanks.
http://plnkr.co/edit/pBz9lk

I need the same thing.
komushi did you find a solution for it?

This issue has been resolved with 1.13.3, please check it out.

Thanks!


tests: setup browser testing using playwright

Codecov Report

Merging #75 (2225f49) into master (cd8c5c4) will decrease coverage by 6.65%.
The diff coverage is 60.71%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   35.25%   28.59%   -6.66%
==========================================
  Files          67       68       +1
  Lines        4238     4263      +25
==========================================
- Hits         1494     1219     -275
- Misses       2744     3044     +300

Impacted Files
Coverage Δ

lona/app.py
26.37% <55.55%> (-3.04%)
:arrow_down:

lona/pytest.py
63.15% <63.15%> (ø)

lona/exceptions.py
0.00% <0.00%> (-100.00%)
:arrow_down:

lona/html/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

lona/events/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

lona/html/nodes.py
2.45% <0.00%> (-81.97%)
:arrow_down:

lona/__init__.py
0.00% <0.00%> (-80.00%)
:arrow_down:

lona/unique_ids.py
33.33% <0.00%> (-66.67%)
:arrow_down:

lona/errors.py
0.00% <0.00%> (-66.67%)
:arrow_down:

lona/command_line/terminal.py
0.00% <0.00%> (-66.67%)
:arrow_down:

... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8c5c4...2225f49. Read the comment docs.

@maratori I am pretty happy with this infrastructure. If we choose this approach, i will add lona_project_context as well to make testing against existing Lona projects possible.

@maratori i added a fixture to test Lona projects as well

@fscherf Are you going to add more tests in this PR?

@maratori: @sobolevn didn't post his proposal yet. I want to start adding more tests when we agreed on a test framework. These two tests are just a proof of concept for now.


What happens when a pod disappears

do we have to do anything to "clean up" after the bpf program?
keep the metrics?

/cc @alban @iaguis

Your daemon can read the metrics from the bpf maps a last time. The daemon should still have the file descriptors of the bpf maps open. Then, you can close the module used for that cgroup:
https://github.com/iovisor/gobpf/blob/36406ec/elf/module.go#L540-L550
// Close takes care of terminating all underlying BPF programs and structures.
// That is:
//
// * Closing map file descriptors and unpinning them where applicable
// * Detaching BPF programs from kprobes and closing their file descriptors
// * Closing cgroup-bpf file descriptors
// * Closing socket filter file descriptors
//
// It doesn't detach BPF programs from cgroups or sockets because they're
// considered resources the user controls.
// It also doesn't unpin pinned maps. Use CloseExt and set Unpin to do this.
func (b *Module) Close() error {


Navigation bar animation does not adhere to locale: left to right and right to left (e.g. Arabic and English).

Navigation bar animation does not adhere to locale: left to right and right to left (e.g. Arabic and English).
When using Easy Localization package, and switching from LTR and RTL from the package it does not apply to the bottom navigation bar tab switching animations.
STEPS:
set up easy localization
set up navigation bar
change tabs with English locale (correct behavior)
change language to arabic
switch tabs (the animation is still LTR when it should be RTL).

i have the same probleme i hope they will solve it since the package is good

Hi, which animation exactly do you expect to change? The sliding of the pages when switching tabs?
So from what I understand: When switching from Tab 1 to Tab 2 the pages slide to the left in LTR mode. In RTL mode they should slide to the right, correct?
Same when switching from Tab 2 to Tab 1: The pages slide to the right in LTR mode. In RTL mode they should slide to the left, correct?
Feel free to open a pull request if you have a solution.

Solved since version 5.0.0-beta.7


reth-revm no-std support

support no-std in reth-revm

I can take this (btw the linear link is not accessible)

I can take this (btw the linear link is not accessible).
Update: I've seen @JackG-eth is taking this issues, let's wait for him to say if he wants it before assigning it to me.

Hey!
I'm happy to let you pick this up if you want to. Ping me if you have any questions as i'm well versed in it now :)

I can take this (btw the linear link is not accessible).
Update: I've seen @JackG-eth is taking this issues, let's wait for him to say if he wants it before assigning it to me.

Hey!
I'm happy to let you pick this up if you want to. Ping me if you have any questions as i'm well versed in it now :)

Hey! I am also taking an issue of this kind. would you mind sharing your previous PRs as a reference we can take a look at? Thanks!

I can take this (btw the linear link is not accessible).
Update: I've seen @JackG-eth is taking this issues, let's wait for him to say if he wants it before assigning it to me.

Hey!
I'm happy to let you pick this up if you want to. Ping me if you have any questions as i'm well versed in it now :)

Hey! I am also taking an issue of this kind. would you mind sharing your previous PRs as a reference we can take a look at? Thanks!

Sure, heres a few:
https://github.com/paradigmxyz/reth/pull/8792
https://github.com/paradigmxyz/reth/pull/8729
https://github.com/paradigmxyz/reth/pull/8817

Any ideas on how to do no-std for use std::time::Duration;?

Any ideas on how to do no-std for std::time::Duration @JackG-eth ?

you can use this, if I'm not wrong.

Oh yeah, somehow I didn't find it. Thanks


DE: Certificate Signing Algorithm / Size

@SZoerner   Please check this with high urgency:
https://github.com/eu-digital-green-certificates/dgca-verifier-service/issues/42
I can see that one of your CSCA: <IP_ADDRESS> = NTRDE-HRB74346,CN = D-TRUST Root Test CA 2 2018,O = D-Trust GmbH,C = DE
is using the RSA-SSA-PSS Signature Algorithm, with a Key-Size of 4096.
I think this is causing the problem with validation of the CSCA against the DSC Certificate, which leads to the DSC to be unverifiable against the CSCA, and thus excluded in the Trust List in the Verifier Service.

@psavva There was a issue the last date which alreay solved that problem with a fix: https://github.com/eu-digital-green-certificates/dgc-testdata/issues/242

Closing this issue, Fix has been tested and verified working.


nameConfigs folder does not exist

Hey, thanks for this project!
When trying it out, I got an error on this line: https://github.com/daw1012345/vscode-for-toolbox/blob/main/bin/code#L25
The nameConfigs directory did not exist for me, so I had to create it by hand.
Misusing this issue, I think it might be worth a mention this method will not work on existing containers – that took me a while to figure out.

Thanks for your bug report! To address all the issues one by one:

When trying it out, I got an error on this line: https://github.com/daw1012345/vscode-for-toolbox/blob/main/bin/code#L25

I have addressed this with #2. The installation script will now create that directory if it is missing.

I think it might be worth a mention this method will not work on existing containers – that took me a while to figure out.

The project actually supported existing containers before 944a9dbe085e013c7ec49fbc4b65a3bc76c3b3a2. However, the process was annoying (a command had to be manually ran on the host every time the container restarted). It is also possible to reconcile the current approach with the old one to support the convenient workaround for new containers, but revert to the old one if it's an existing container. Either way, I will make a note of this in the README.


Realtime randomly stops working

Describe the bug
I'm running into a very strange issue that I'm having trouble reproducing but it's being reported a lot on production.
The app uses realtime streams extensively for pretty much all the queries. That seems to be ok and there were no issues on firestore before but now that we migrated to supabase streams sometimes just stop emitting any data and it only gets fixed after app restart.
As I said I can't really reproduce locally so I'm not sure if there's maybe some connection drop or we hitting some kind of a limit.
The usage of streams is just typical
  Stream<List<T>> watchMany() {
    return supabase.from(tableName).stream(primaryKey: ['id']).map(
      (data) => data.map((e) => fromJson(e)).toList(),
    );
  }

Is there any tips to debug this or idea what could be going on?

Same here :confused: Realtime just stops after a while when connected to a remote database. We can't reproduce the issue locally and no error ist thrown. Updates just stop coming through.
This issue has been around for well over a year, though, with no solution. (https://github.com/supabase/supabase-flutter/issues/388)
Pretty poor show. Superbase is cool. But we really don't care about any other fancy features you guys might be implementing if the basics don't work.
And as with any open source project, most of us users don't have the time or the knowledge to mess around in the supabase code ourselves.
I'll open a bottle of champagne on your behalf when you get this fixed. :champagne:

Yup, this is a known issue, and we are sorry that we haven't been able to fix it yet. We have allocated some time to take a deeper look at the issue, but we have yet to find the cause, but the same issue does not happen on JS SDK, so we know it's the Flutter SDK's issue. I will take another stab at it soon.
Closing as a duplicate of https://github.com/supabase/supabase-flutter/issues/388

duplicate of #388

I don't think this is a duplicate of issue #388. We've been experiencing instability with Supabase for the past two weeks, resulting in unpredictable errors. This has caused significant disruption.

Describe the bug
I'm running into a very strange issue that I'm having trouble reproducing but it's being reported a lot on production. The app uses realtime streams extensively for pretty much all the queries. That seems to be ok and there were no issues on firestore before but now that we migrated to supabase streams sometimes just stop emitting any data and it only gets fixed after app restart. As I said I can't really reproduce locally so I'm not sure if there's maybe some connection drop or we hitting some kind of a limit.
The usage of streams is just typical
  Stream<List<T>> watchMany() {
    return supabase.from(tableName).stream(primaryKey: ['id']).map(
      (data) => data.map((e) => fromJson(e)).toList(),
    );
  }

Is there any tips to debug this or idea what could be going on?

I'm facing a similar issue. The stream listener isn't emitting the initial data, and it seems to be behaving unpredictably.
For the past two weeks, I've been experiencing instability with Supabase, leading to unpredictable errors. This has caused significant disruptions.
Have you been able to resolve the problem you mentioned?

Well given that I can't rely on realtime I decided to go oldschool and just do without streams. Instead I manually refresh my providers on creates/updates etc so I know it's always up to date in those cases.
Also to still have the realtime I manually subscribed to all db changes and refresh providers based on what changed.
In this case it's more of a nice to have and if it stops working I still have the manual one.


returnNull parameter of getComponent() never used in method

Self explanatory.
I don't think the returnNull parameter is being used in any calls, but needs to be double checked.
https://github.com/terrapower/armi/blob/4894a56c4c5498272d47b6bc307765eb207f4801/armi/reactor/composites.py#L2451-L2493

Agreed.
I have looked around our ecosystem a bit and can't find anyone that is subclassing this and using returnNull either.
So, it seems like it should be quite safe to remove.


Settings editor funnel button: How does it source extensions?

Testing #147935

Open Settings editor, select funnel -> Extension ID...
See several extension suggestions:

I want to view Remote-Containers settings, so I start searching containers
No results, so I'd need to find and paste the Remote-Containers ID myself

How do these suggestions get populated? I thought it would've been all extensions installed, or all installed extensions with settings, but that doesn't appear to be the case (in the latter scenario, there are extensions populated that don't have any settings to show).

Verification steps:
In the Settings editor, press the funnel button on the right side of the search widget, and then select the "Extensions" option. The list of extensions that show up should include both built-in extensions such as Emmet, and user-installed extensions such as Remote Containers. Note that the extension IDs will show instead of the extension names themselves.

LGTM, thanks @rzhao271!


☂ Add support for ARM macOS host

Umbrella issue tracking developing Flutter on macOS ARM.
Use case: developer buys ARM Mac, installs Flutter tooling on the Mac, deploys Flutter to an iPhone.

Build tool on macOS ARM
Build ARM host dependencies (iproxy, libimobiledevice).  Rosetta translation?
IDE support
Infrastructure support

Note: this is tracking host-side issues.  Running Flutter on ARM macOS as a target is tracked by https://github.com/flutter/flutter/issues/60113.
Wiki page: https://github.com/flutter/flutter/wiki/Developing-with-Flutter-on-Apple-Silicon
Update: Flutter should be fully working on M1 with Rosetta translation (particularly tooling and iOS simulator).  The remaining work is to get it working natively without Rosetta.
Infrastructure

[ ] https://github.com/flutter/flutter/issues/87508 Add Mac M1 ARM machines to the prod pool

Native host development (flutter tool)

[x] https://github.com/flutter/flutter/issues/84453
[ ] https://github.com/flutter/flutter/issues/69157 (ios-deploy, libimobiledevice, etc)
[x] https://github.com/flutter/flutter/issues/86926
[x] https://github.com/flutter/flutter/issues/97658
[ ] https://github.com/flutter/flutter/issues/101138

Completed
Sub-issues

[x] https://github.com/flutter/flutter/issues/84601 Update iOS and macOS engine builders to Xcode 12.0
[x] https://github.com/flutter/flutter/pull/60119 [flutter_tools] separate target platform, host platform, and architecture
[x] https://github.com/dart-lang/sdk/issues/42534 Building flutter tool on ARM macOS host fails
[x] https://github.com/dart-lang/sdk/issues/42773 Dart SDK version is built for macOS ARM host
[x] https://github.com/flutter/flutter/issues/96745 Support building the engine on macOS ARM hosts

Physical devices

[x] https://github.com/flutter/flutter/issues/65133 "flutter build ios" fails on ARM macOS, ibtoold crashes compiling xcassets/storyboards
[x] https://github.com/flutter/flutter/issues/65976#issuecomment-717523043 Add macOS architecture to doctor output for host
[x] https://github.com/flutter/flutter/issues/79430 Add mac m1 machines to the staging pool

Simulator

[x] https://github.com/flutter/flutter/issues/85062 iOS engine artifacts Flutter.xcframework contains old architecture triples directories
[x] https://github.com/flutter/flutter/issues/84672 Update Flutter Engine recipes to handle ARM64 simulator
[x] https://github.com/flutter/flutter/issues/82736 Adding ARM iOS simulator times out the engine artifacts build
[x] https://github.com/flutter/flutter/issues/66926 engine gn updates required for simulator on macOS arm
[x] b/162290052 Cannot launch Android emulators
[x] https://github.com/flutter/flutter/issues/60109 Distribute engine as Flutter.xcframework
[x] https://github.com/flutter/flutter/issues/69718 Deprecate flutter build ios-framework --universal
[x] https://github.com/flutter/flutter/issues/65901 XCode SDK needs to be updated on mac LUCI builders
[x] https://github.com/flutter/flutter/issues/66925 flutter engine on iOS arm simulator does not build
[x] https://github.com/flutter/flutter/issues/73066 Update engine script create_ios_framework to optionally take ARM simulator path
[x] https://github.com/flutter/flutter/issues/84670 Add buildroot support for ARM64 simulator engine builds
[x] https://github.com/flutter/flutter/issues/69334 Add ARM simulator architecture slice to App.framework to support Apple Silicon
[x] https://github.com/flutter/flutter/issues/64502 Flutter cannot build against iOS ARM simulators (on ARM macOS host)
[x] https://github.com/flutter/flutter/issues/85713 When plugins do not support ARM iOS simulators, the app fails to build

Plugin support

[x] https://github.com/flutter/flutter/issues/70796 Work around ffi "symbol not found" error from CocoaPods
[x] https://github.com/ffi/ffi/issues/800 SEVG on Apple silicon macOS
[x] https://github.com/invertase/firestore-ios-sdk-frameworks/issues/16 firestore-ios-sdk-frameworks pre-built xcframeworks should support Apple Silicon ARM simulators
[x] https://github.com/flutter/flutter/issues/73686 CocoaPods Rosetta workaround has issues
[x] https://github.com/flutter/flutter/issues/87242 Mark google_maps_flutter as not supporting arm64 iOS simulator
[x] https://github.com/flutter/flutter/issues/87243 Mark google_sign_in as not supporting arm64 iOS simulators
[x] https://github.com/flutter/flutter/issues/85713

Tracking Apple Silicon as a target device separately at https://github.com/flutter/flutter/issues/60113.

Building flutter tool on ARM macOS host currently fails with:
Building flutter tool...
oah error: unhandled 16KB-unaligned mmap addr=0x0 len=0xdd28c0 offset=0x1000 prot=1 flags=2
/Users/ben/development/flutter/bin/internal/shared.sh: line 20:  1298 Trace/BPT trap: 5       "$PUB" upgrade "$VERBOSITY" --no-precompile
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds... (9 tries left)

Leaving this here so it can be found by a google search. But maybe it should be moved to a separate issue?

Building flutter tool on ARM macOS host currently fails with:
Building flutter tool...
oah error: unhandled 16KB-unaligned mmap addr=0x0 len=0xdd28c0 offset=0x1000 prot=1 flags=2
/Users/ben/development/flutter/bin/internal/shared.sh: line 20:  1298 Trace/BPT trap: 5       "$PUB" upgrade "$VERBOSITY" --no-precompile
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds... (9 tries left)

Leaving this here so it can be found by a google search. But maybe it should be moved to a separate issue?

Yes, can you file a separate issue?  I heard about this but we don't have DTKs yet.  I'll link it back to this umbrella meta issue.

@cbenhagen Can you file in https://github.com/dart-lang/sdk ?

Done: https://github.com/dart-lang/sdk/issues/42534

Just to cross reference, tracking linux arm host support on https://github.com/flutter/flutter/issues/56992

I'm happy to report that my experience with Flutter master branch on Apple Silicon / DTK has been much better than others early experiences ( ala https://github.com/dart-lang/sdk/issues/42534 ). At this point Rosetta seems to be able to run most of the host tooling, and I am able to target iOS using the generated Xcode project.
Per https://github.com/flutter/flutter/issues/65132 the flutter run tool is still not working. Also, per https://github.com/flutter/flutter/issues/64502 the simulator does not work correctly on ARM hosts.
However, and I think this is super cool, actually building and running the Flutter application on-device using Xcode 12.2 Beta is working as expected. I can even use flutter attach to observe and interact with the running application!
If I am able to get my local development environment to work correctly ( https://github.com/dart-lang/sdk/issues/43488 ) I'm optimistic that I can participate in the porting effort to get the tooling running natively on the ARM host.

flutter run -d macos worked out of the box (as a rosetta app):

@jmagman I think we were talking about "XCode SDK needs to be updated on mac LUCI builders" just now. Should that be better named as "mac LUCI builders' Xcode need to use the iOS 14 SDK"?

@jmagman I think we were talking about "XCode SDK needs to be updated on mac LUCI builders" just now. Should that be better named as "mac LUCI builders' Xcode need to use the iOS 14 SDK"?

Done at https://github.com/flutter/flutter/issues/65901#issuecomment-702368354.

Ship it!

Trying to understand the current state of this issue.. Is it accurate to say that if I were to buy an ARM Mac next week, I would probably require a physical iOS device to do Flutter development as Flutter would not be able to build on ARM simulators running on the new Macs.

Trying to understand the current state of this issue.. Is it accurate to say that if I were to buy an ARM Mac next week, I would probably require a physical iOS device to do Flutter development as Flutter would not be able to build on ARM simulators running on the new Macs. But I should still be able to build a release version of the app for iOS without problems.

That's a good summary. I would add that mac desktop apps are working in Rosetta.

Sorry didn't mean to close this.

Trying to understand the current state of this issue.. Is it accurate to say that if I were to buy an ARM Mac next week, I would probably require a physical iOS device to do Flutter development as Flutter would not be able to build on ARM simulators running on the new Macs. But I should still be able to build a release version of the app for iOS without problems.

That's a good summary. I would add that mac desktop apps are working in Rosetta.

Also, last time I tried, CocoaPods wasn't working on arm, so apps with plugins won't work.

Trying to understand the current state of this issue.. Is it accurate to say that if I were to buy an ARM Mac next week, I would probably require a physical iOS device to do Flutter development as Flutter would not be able to build on ARM simulators running on the new Macs. But I should still be able to build a release version of the app for iOS without problems.

That's a good summary. I would add that mac desktop apps are working in Rosetta.

Also, last time I tried, CocoaPods wasn't working on arm, so apps with plugins won't work.

I saw in one of the linked issues someone posted a workaround, is that not a viable solution?
https://github.com/CocoaPods/CocoaPods/issues/9907#issuecomment-656418556

I saw in one of the linked issues someone posted a workaround, is that not a viable solution?
CocoaPods/CocoaPods#9907 (comment)

It didn't work for me, CocoaPods would crash with LoadError - dlsym(0x7fbbeb6837d0, Init_ffi_c): symbol not found.  Workaround is to install x86_64 ffi gem:
arch -x86_64 sudo gem install ffi

Flutter work tracked at https://github.com/flutter/flutter/issues/70796

excited to see this working soon!

Today, is it possible to use flutter to make mobile app on Apple Silicon Big Sur ?
I would by mac mini but if we can't.... ?

expected to see this before the end of this year :)

Today, is it possible to use flutter to make a mobile app on Apple Silicon Big Sur ?
I would buy the new mac mini but if we can't.... ?

Is is possible, but you have to use physical devices to test your code. I tested it with the Apple Silicon MBP 13 16GB, IPhone XS Max, IPad Pro 2020.
Flutter web just works as expected.
If you want to use plugins, you should install the ffi gem mentioned earlier.

This [wiki page](Wiki page: https://github.com/flutter/flutter/wiki/Developing-with-Flutter-on-Apple-Silicon) is a more digestible form of what works and what doesn't.  This issue is a convenience meta issue, so I'm going to lock for now to prevent noise.

Should we leave https://github.com/flutter/flutter/issues/64502 and create a separate bug for running iOS simulator on rosetta?

Should we leave #64502 and create a separate bug for running iOS simulator on rosetta?

https://github.com/flutter/flutter/issues/72294

Created https://github.com/flutter/flutter/issues/74662 to wrap up documentation for the next stable

Created https://github.com/flutter/flutter/issues/74662 to wrap up documentation for the next stable

On Flutter 2 deploying your app in Rosetta mode to the iOS simulator with the command line tool flutter run/ flutter build ios --simulator, or from a Flutter IDE plugin should work.  Targeting the iOS simulator from Xcode is supported without manual project changes as of https://github.com/flutter/flutter/pull/73828, which is currently available on the master channel.

Native arm64 iOS simulator without Rosetta now available as of https://github.com/flutter/flutter/pull/85642.

Engine building on arm64 mac hosts as of https://github.com/flutter/engine/pull/33244

There are also arm64 Mac tests running like
https://github.com/flutter/flutter/blob/708c363920b9a11c8aa4fdc5dd9d7eb78fe6f56f/.ci.yaml#L3122
This is complete.  We can track the ew remaining x64 binaries separately at https://github.com/flutter/flutter/issues/69157.

SGTM. We're now arm64/arm64 (as well as x64/simarm64) binaries for gen_snapshot in macOS engine host builds. I'm happy to take a look at getting a lipo'ed universal binary for gen_snapshot in place.

SGTM. We're now generating arm64/arm64 (as well as x64/simarm64) binaries for gen_snapshot in macOS engine host builds. I'm happy to take a look at getting a lipo'ed universal binary for gen_snapshot in place.

@zanderso says it's more complicated than lipoing, more info in https://github.com/flutter/flutter/issues/101138.

If I understand the issue pointed to there, a bunch of that was fixed in https://github.com/flutter/engine/pull/33244. That's what I meant by us now generating native arm64/arm64 binaries rather than x86/simarm64. But maybe I'm misreading this?

If I understand the issue pointed to there, a bunch of that was fixed in https://github.com/flutter/engine/pull/33244.

Neat, I didn't see that PR.  Feel free to close what you think is complete.

but my understanding was that https://github.com/flutter/flutter/issues/101138 is about an arm64->arm64 gen_snapshot, not the arm64->x64 case.

That's what I meant to track with that issue since that's within our ability do to now given dart limitations.
@zanderso I thought we couldn't just lipo gen_snapshots together because of... some reason you've explained to me at least 4 times.

We could lipo together the gen_snapshot binaries that target arm64, but not the gen_snapshot binaries that target x64. The reason is that Dart only supports generating intel code when running on an intel host.
My suggestion for now is to keep things simple and ship non-lipo'd gen_snpashots targeting both arm64 and x64 as intel binaries, which will run under Rosetta on M1.

sgtm!


7.12.1 Build?

Any chance there is a pending 7.12.1 release of this plugin?

Need help guys: https://github.com/dlumbrer/kbn_network/issues/98