Toggle should consider content changes applied within beforeToggle hook

I'm currently trying to use https://www.npmjs.com/package/clampify together with readmore-js v3 where I have two nested elements (div and p): the div with readmore, the paragraph with clampify. I'd like to clampify the content after readmore-js has collapsed it. Now since clampify actually changes the content of the paragraph, readmore-js naturally can't expand to the original contents height when toggling open; I tried to reset clampify in the beforeToggle method so that the original content is restored from which readmore-js should be able to calculate and set its height, but this doesn't seem to work, it looks like the hook is called too late. Any ideas on how I could handle this or would it require an update for your plugin? (I'm open to diving into this and offering a PR)

UPDATE funnily enough it works all fine after some specific actions:

I open the page and try to click on a "show more" button: it switches to "show less" and the reset of clampify happens (ellipsis disappear, content is all there), but then nothing triggers going further.
I resize the browser window and then click "show less": readmore-js expands the content, nothing else happens - we now have the proper state with expanded content and "show less" button.
From here on everything works as intended: I can toggle "show less"/"show more" and it correctly collapses/expands content, switches the button and triggers clampify.

So I've found a workaround for this and made a PR: https://github.com/jedfoster/Readmore.js/pull/245


Added **kwargs to Collection.find method in order to allow MongoEngine t...

Added **kwargs to Collection.find method in order to allow MongoEngine to use MongoMock instead of PyMongo.
This change don't break anything, but allows MongoEngine to use MongoMock instead of PyMongo (MongoEngine also requires minor changes that I'm also pull requesting to their repository).
I've added **kwargs as a "general" solution, but the problem I was trying to solve was the need of the parameter slaves_okay .
I'm open to any suggestion to achieve the same result if this change don't seems to you OK.
Thanks for your attention :) .

The slave_okay parameter of the find method has ben removed anyhow so I guess that his PR is obsolete by now. I you think otherwise please re-open it!


docs: Added documentation for automatic session refresh

🔗 Linked issue
❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Added some documentation details on how to configure the automatic session refresh. Before these changes it was necessary to search the source code for the configuration details. I would like to spare others from making this journey.
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have added tests (if possible).
[x] I have updated the documentation accordingly.

Hi, thanks for the contribution :)


Handle instance methods and constructor calls in ReplaceLambdaWithMethodReference

The ReplaceLambdaWithMethodReference recipe now also handles instance methods, where the method select corresponds to the first lambda parameter.
So for example in a Stream a map() call like map(o -> o.toString()) will now be rewritten as map(Object::toString).
Also constructor calls are now replaced by method references. E.g. ThreadLocal.withInitial(() -> new Object()) becomes ThreadLocal.withInitial(Object::new).

Thanks @knutwannheden !


feat(frontend): Credentials section in settings

Motivation
We want users to present the POUH credetial to Oisy.
In this PR, I introduce the different UIs that will be rendered in the Settings page based on the value of the user profile store.
Changes

New env var VITE_POUH_ENABLED and app feature flag POUH_ENABLED.
Move POUH_CREDENTIAL_TYPE to a credentials constants file.
New util hasPouhCredential.
New derived store userHasPouhCredential.
New i18n keys for new copy.
New UI section in SettingsSignedIn.

Tests

Tested manually the different UIs.
Add test for the new util.

New UI:

@peterpeterparker ready for another review

@peterpeterparker ready for another review


Create a 0.9.1 release

Some bugs in handling nullable types were fixed, magic property support was added, additional inference rules were added, etc.

Just published https://github.com/etsy/phan/releases/tag/0.9.1


03/30/2018 10:55 : Create Pull Request for branch master -> prTesting1_2018033010

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ReDet with Dota 1 multiscale OBB - only able to achieve 79.2% so far

Hello,
thanks for the code. I'm trying to archive the 80.1% mAP on the Dota 1 dataset. I noticed when comparing the logs - that I got a different maximum amount of iterations compared to you  -  5848 compared to 8650.
I just used the prepare_dota1_v2.py script creating 101611 images in trainval and 52460 images in test. Is that correct or did I miss something? I'm also training on 4 GPU's with imgs_per_gpu = 2.
Any other ideas where I could have lost the 0.9% mAP - the only thing I changed was the  THREADS_PER_BLOCK in riroi_align_kernel.cu from 1024 to 512.

Maybe we use empty images for training. I'm not sure. Try to change the difficult key to difficult=-1.
https://github.com/csuhan/ReDet/blob/f4a8e7dadec990f8a92437024416f0fb07a868db/DOTA_devkit/prepare_dota1_v2.py#L139
The multiscale result is not very stable since we use random rotation augmentation.

Thanks for the fast reply. I will try that and report back.

With difficult = -1 the amount of images goes down(from 101611 to 69018) and thus also the maximum amount of iterations goes down to 4135. I also get a lower mAP in the end.
I also want to train on custom data and wanted to use --validate with distributed training but it doesn't seem to be supported? Then the easiest way to check the results is just parsing the results.pkl data to .json and use cocoeval with the json annotations of the test data?

Our code does not support online validation:  --validate.
You can convert your data to DOTA's txt format, then you can train and test your model as DOTA.

Hello,
thanks for the code. I'm trying to archive the 80.1% mAP on the Dota 1 dataset. I noticed when comparing the logs - that I got a different maximum amount of iterations compared to you - 5848 compared to 8650.
I just used the prepare_dota1_v2.py script creating 101611 images in trainval and 52460 images in test. Is that correct or did I miss something? I'm also training on 4 GPU's with imgs_per_gpu = 2.
Any other ideas where I could have lost the 0.9% mAP - the only thing I changed was the THREADS_PER_BLOCK in riroi_align_kernel.cu from 1024 to 512

你好，想问一下使用DOTA 数据集进行训练的时候是将train和val放在了一起，最后想得到评价指标是用的trainval.json还是test.json
是运行的python tools/test.py .......--eval bbox    ?

Hello,
thanks for the code. I'm trying to archive the 80.1% mAP on the Dota 1 dataset. I noticed when comparing the logs - that I got a different maximum amount of iterations compared to you - 5848 compared to 8650.
I just used the prepare_dota1_v2.py script creating 101611 images in trainval and 52460 images in test. Is that correct or did I miss something? I'm also training on 4 GPU's with imgs_per_gpu = 2.
Any other ideas where I could have lost the 0.9% mAP - the only thing I changed was the THREADS_PER_BLOCK in riroi_align_kernel.cu from 1024 to 512.

Hello, I would like to ask whether train and val are put together when using DOTA data set for training. Finally, I want to know whether trainval.json or test.json is used as the evaluation indicator
It is the python tools/test run py .......--eval bbox ?


Sometimes hover colour makes text/buttons disappear

Have a look at the logged out header, then hover over the LOGIN button... it will mostly disappear...

I fixed it by applying class="text-white" to router-links on primary background. Seems a bit hackish to me, maybe there's a better general solution?


Updated spark example with docker images moved to gcr.io/google_containers

Take Spark from the official Apache mirror instead of http://ci.radanalytics.io
Upgrade Spark from 1.2.1 to 1.4.0
Use kubectl logs instead of links dump to check master status
Kubectl outputs in the new format

@ihmccreery Can you walk through this on GCE & GKE and make sure it works? Thanks.

@ihmccreery, the docker images have NOT been pushed to gcr.io/google_containers yet so you may have to hack the PR a bit.

@mwielgus Can you please push the Docker images?  Once they're live, I can run through this.

@ihmccreery I pushed the images and they seem to be OK.

@mwielgus See comments above.  Otherwise, LGTM.  Checked on GKE; I'll wait to re-check on GCE when the comments are resolved.

A couple things (including list of fixes below).
We need to figure out whats going to be most beneficial for the user as far as what they can learn/take from this example and then use (the ease of the example is not as important). Im not familiar with Apache Spark at all, so my question is: "What's the expected/common use scenario for installing the Spark base image?"
If we expect users to want to install the base image on a node on their local machine, then we should focus this example in that direction. Otherwise, if the common use scenario is that user will SSH into a remote node in order to install the base image, than we should build that up more. So first, we need to determine what the common use scenario is, and then help them learn how its done. The last option would be to address both scenarios add in a short alternative option (see example below).
Either way, we should improve "Step Three" to make it clear what we are going to accomplish and why.
Example (remember i dont know spark so this might be technically incorrect):
--------"example-start"-------------
Step Three: Install the Spark base image on a worker node
Depending on the getting started guide that you used to create your cluster, you can install the Spark base image on a remote node or local node.

If you are using a cloud provider like Google Compute Engine (GCE) or Google Container Engine (GKE), then you can SSH into a remote node and install the Spark base image.
 show-SSH-steps-here

If you have a cluster running locally, you can download and install Docker[URL here to download docker] on your local machine before installing the Spark base image on a node.
 define-localinstall-steps-here

--------"example-end"---------
Other fixes we should make to improve this doc:

In Step One, Add a link to the file "examples/spark/spark-master-service.json" (like the link to the ...spark-master.json file)

In Step Two, explain more about why creating a rep controller results in new worker pods (ie. the rc keeps your pods alive and automatically creates the worker pods when it finds that the number of pods does not equal the number of replicas specified in the pod spec.)

In Step Three:

Provide (1) the "kubectl get nodes" code example and output, plus (2) glcoud compute ssh example with name from "get nodes" ouput:

"For example, run:
  kubectl get nodes
  show-output-here

  gcloud comput ssh NAMEFROMOUTPUT
  show-ouput-here

Fix typo: "besed" -> "based"
use capital "IP"
The TLDR section does not point them back to installing the spark base image
Replace "After running it you are good to go." With a paragraph at the very end of the example (maybe a separate section "Result"). Something like:
"Result:
You now have services, replication controllers, and pods for the Spark master and Spark workers. You can take this example to the next step and start using the Apache Spark cluster you just created, see [point to spark docs here] for more information."

@RichieEscarez Thank you for the review.
The most convenient (from the developer's perspective) would be to have Spark client running on the desktop. But it would require much more steps to have it up and running and would be rather focused no things unrelated to Kubernetes itself like docker installation on mac/windows/linux, setting up Spark's security so that not everyone has the access to the spark cluster. I think we should not go this way.
So the other option - sshing to the cluster - is IMHO much easier. I added the steps describing how to ssh to a node on GCE (and applied you other comments). But ssh should be rather covered in details on a separate doc page, so that the other examples that also involve sshing to the cluster can point to it too. And speaking about examples in general - I think this one is quite decent now and I would rather focus on fixing others before the launch instead of adding all possible use scenarios to this particular one.

@mwielgus, I agree on all points.

This example should remain simple (perhaps in the future, maybe an advanced version can be created to build on and cover the more complicated scenario?).
We should eventually create a standalone "how to SSH into a node" document that others can point to/reuse (ive found that a few of other examples also SSH into nodes). - ill open an issue for about this
From my point of view LGTM (pending: @ihmccreery to check on GCE). Ultimately, this doc has been improved/fixed and we should move on to the next "to do" (although we can spend more time editing it [for consistency with other examples, ie formatting, structure, etc.] but lets save that for post v1 when there are fewer competing priorities).

@ihmccreery, can you give the "ok-to-merge" when this is all tested and ready to go?

LGTM, checked on GCE & GKE.  We don't need ok-to-merge because this is only a docs change.  Thanks to you both for contributing so much to this doc.

LGTM, checked on GCE & GKE. We don't need ok-to-merge because this is only a docs change. Thanks to you both for contributing so much to this doc.

This PR seems to be more than a docs change as it touches scripts too :)
@ihmccreery (or @roberthbailey), please label it as "ok-to-merge" when the PR is ready. Thanks!
@mwielgus, shippable complains about the boilerplate header. Please resolve this, thanks.
 ./hack/verify-boilerplate.sh
Boilerplate header is wrong for: ./examples/spark/images/base/setup_client.sh
Boilerplate header is wrong for: ./examples/spark/images/worker/start.sh
Boilerplate header is wrong for: ./examples/spark/images/master/start.sh

Boilerplate fixed.

I can't give ok-to-merge because I'm not a tech lead.  Assigning to @brendandburns.

Ok to merge.


improve istioctl pc secret performance using mask param

Describe the feature request
Today, istioctl pc secret appears to dump a proxy's entire config, then parse whatever items it needs specifically; https://github.com/istio/istio/blob/master/istioctl/pkg/proxyconfig/proxyconfig.go#L131-L141
This can be quite slow for proxies with large configs; in our larger production clusters this actually times out completely, preventing us from using the command at all.
If istioctl instead used the mask GET param to filter results on server side, this transfer data could be reduced dramatically.
➜  ~ curl -s -o /dev/null -w '%{size_download}\n' 'http://localhost:15000/config_dump'
3289250

➜  ~ curl -s -o /dev/null -w '%{size_download}\n' 'http://localhost:15000/config_dump?mask=dynamic_active_secrets'
27157

This approach could probably be used for other istioctl pc functions too, but I've only explored the secret use case.
Describe alternatives you've considered
N/A
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[X] Networking
[X] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

Thanks for the quick resolution @my-git9 !


Cross-compiled Nix references build platform binaries

Describe the bug
Building the cross-compiled version of Nix (I'm using an x86_64 system and want to use Nix in armv7l) with the following command succeeds:
nix-build . -A pkgsCross.armv7l-hf-multiplatform.nixUnstable
But it references the x86_64 versions of bash, coreutils and a few more derivations. This makes using Nix in my ARMv7l system fail because it will try to run x86_64 binaries.
To Reproduce
Steps to reproduce the behavior:

Run nix-build . -A pkgsCross.armv7l-hf-multiplatform.nixUnstable inside the nixpkgs directory (tested with master and release-19.09 branches`)
Run nix-store -q --references result | grep -E 'bash|coreutils'. The printed outputs won't have armv7l-unknown-linux-gnueabihf in their name, indicating they are x86_64 derivations

Expected behavior
Rebuilding and running nix-store -q --references result | grep -E 'bash|coreutils' should print outputs with armv7l-unknown-linux-gnueabihf in their name.
Workaround
I was able to fix the bug with an ugly hack:
diff --git a/pkgs/tools/package-management/nix/default.nix b/pkgs/tools/package-management/nix/default.nix
index 5c55ac31588..afcb5303da7 100644
--- a/pkgs/tools/package-management/nix/default.nix
+++ b/pkgs/tools/package-management/nix/default.nix
@@ -16,6 +16,7 @@ common =
   , storeDir
   , stateDir
   , confDir
+  , coreutils, bash, gzip, gnutar
   , withLibseccomp ? lib.any (lib.meta.platformMatch stdenv.hostPlatform) libseccomp.meta.platforms, libseccomp
   , withAWS ? stdenv.isLinux || stdenv.isDarwin, aws-sdk-cpp

@@ -59,6 +60,18 @@ common =
       # Seems to be required when using std::atomic with 64-bit types
       NIX_LDFLAGS = lib.optionalString (stdenv.hostPlatform.system == "armv6l-linux") "-latomic";

+      preBuild = ''
+        coreutils="${coreutils}/bin" \
+          bash="${bash}/bin/bash" \
+          bzip2="${bzip2}/bin/bzip2" \
+          gzip="${gzip}/bin/gzip" \
+          xz="${xz}/bin/xz" \
+          tar="${gnutar}/bin/tar" \
+          tr="${coreutils}/bin/tr" \
+          substituteAllInPlace corepkgs/config.nix.in
+      '';
+
       preConfigure =
         # Copy libboost_context so we don't get all of Boost in our closure.
         # https://github.com/NixOS/nixpkgs/issues/45462
@@ -80,6 +93,7 @@ common =
           "--sysconfdir=${confDir}"
           "--disable-init-state"
           "--enable-gc"
+          "--with-coreutils-bin=${coreutils}/bin"
         ]
         ++ lib.optionals (!is20) [
           "--with-dbi=${perlPackages.DBI}/${perl.libPrefix}"

It built a working derivation of Nix, and I have been able to install and run Nix in my ARMv7l system (it is an Odroid HC2).
The --with-coreutils-bin option fixes the result/etc/profile.d/nix.sh file referencing an x86_64 version of coreutils. I haven't tested this change with other architectures, but this seems to be an acceptable change.
The substituteAllInPlace part is a horrible hack (that's why I didn't open a PR) that fixes the references to x86_64 derivations in the result/share/nix/corepkgs/config.nix file. There should be a better way to fix this, but I'm not sure how :(
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 4.19.80, NixOS, 19.09.1510.131ff6dd9c8 (Loris)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3`
 - channels(root): `"nixos-19.09.1510.131ff6dd9c8"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
    - nix
    - nixUnstable
# a list of nixos modules affected by the problem
module:

This was removed in an unreleased version of Nix here: https://github.com/NixOS/nix/commit/6a9c815734de3549a5116796830bd4ebfd006025. Unfortunately adding rust comes with its own issues in cross compiling.

This appears to be fixed by @eamsden in #81317. It looks like #81153 was a duplicate of this issue. Unfortunately I can't confirm the issue is fixed because building pkgsCross.armv7l-hf-multiplatform.nixUnstable in master fails because of rustc.
If I cherry-pick the changes of #81317 into commit 131ff6dd9c8 (I used it when I originally reported the issue) and resolve the conflicts, pkgsCross.armv7l-hf-multiplatform.nixUnstable builds successfully but still contains a reference to x86_64 coreutils.
Although I think this issue should be fixed, it isn't important to me anymore. I already have a running armv7l machine with Nix, so now I build everything using it instead of cross-compiling.


What is max_tokens in the token counting utilities, please?

Hi @shobrook
Thanks for the tool!
Asking here a similar question as on https://github.com/blaze-Youssef/openai-ratelimiter/issues/2 , which uses the same code.
What does the argument max_tokens correspond to, please, in https://github.com/shobrook/openlimit/blob/master/openlimit/utilities/token_counters.py#L14 , please?
I am trying to understand it, but the way you count tokens seems different than in OpenAI's cookbook https://github.com/openai/openai-cookbook/blob/main/examples/How_to_count_tokens_with_tiktoken.ipynb (see section 6), which does not have such a starting count at n*max_tokens.
Thanks for any clarification!

Ah! Found max_tokens in the OpenAI API, as an optional parameter: https://platform.openai.com/docs/api-reference/completions/create#completions/create-max_tokens
Do I understand correctly that setting the baseline to n*max_tokens is here to preemptively count into the rate limit the maximum possible number of output tokens?

Ungh, now I see that OpenAI has a separate token counter in their batch-API script than in their tutorial Notebook: https://github.com/openai/openai-cookbook/blob/main/examples/api_request_parallel_processor.py#L339
The former does indeed take max_tokens into account. But is also less recent than their notebook, which has different token increments for roles' names. So I don't know which version of their token counter to believe 😅
Shouldn't a rate limiter, in any case, be updated after the actual completion is returned by the API, to account for the actual number of output tokens?

Do I understand correctly that setting the baseline to n*max_tokens is here to preemptively count into the rate limit the maximum possible number of output tokens?

Yes.

Shouldn't a rate limiter, in any case, be updated after the actual completion is returned by the API, to account for the actual number of output tokens?

No. This implementation attempts to throttle requests before they're made to OpenAI. To do this, we have to assume the worst case scenario for token consumption.


Environment Name is bleeding into menu text

Rancher Version: master 6/15
Steps to Reproduce:

have a environment with more than 24 characters

Results: Environment name bleeds into menu

Expected:  should not bleed.  Please check namespace as well.

https://github.com/rancher/ui/pull/763

Version - master
Verified fixed


Implement CIDR.Value() to make it possible to send it to the database

Go doesn't inherit functions from its base type (unless you embed it in
a struct, but that'd be a backwards incompatible change) so we need to
explicitly implement .Value()
Requested on https://github.com/kyleconroy/sqlc/issues/1588

Looks like the workflow file is broken, will take a look today or tomorrow.


Risky IP / azuread_sign_in_report error

Describe the bug
In the Azure SignIn Report, IP Address can be "risky", if so, the IP address contains some "X", and azuread failed with the following error :
select * from azuread_sign_in_report;
Warning: executeQueries: query 1 of 1 failed: ERROR: rpc error: code = Unknown desc = ip_address: invalid ip address [DELETED].XX  (SQLSTATE HV000)
More documentation : https://learn.microsoft.com/en-us/azure/active-directory/hybrid/how-to-connect-health-adfs-risky-ip
Note : [DELETED] is the first 3 parts of a normal IP Address.
Steampipe version (steampipe -v)
Example: v0.16.4
Plugin version (steampipe plugin list)
Example: v0.8.1
Many thanks for your help !

Hi @Bobaero, welcome to Steampipe! Sorry to see that you are running into issues.
Appreciate the extra information; it really helps!
I have pushed a commit addressing the above issue: https://github.com/turbot/steampipe-plugin-azuread/pull/95
If possible, can you please refer to this PR to validate whether the changes resolve the error?
You can use the below steps to build the plugin locally:

Clone the repo: git clone https://github.com/turbot/steampipe-plugin-azuread.git
Go to the directory: cd steampipe-plugin-azuread
Go to the branch: git checkout issue-94
Run make
Then try steampipe query

Let us know if you need any help. Thanks!

Hi @Subhajit97 ,
First, it's me who thanks you for your time ! You've doing a great job and my Azure AD bring bugs which you can't detect until someone get it :D
I've tried to make the issue-94 branche but i can't build as i get the following error :
build github.com/Azure/azure-sdk-for-go/sdk/azcore: cannot load github.com/Azure/azure-sdk-for-go/sdk/azcore: no Go source files
Can you point me the must have go modules ?
Many thanks !

Hum, I'm using Ubuntu on Windows through WSL2.0 and i can only update golang-go to the 1.13.8 linux/amd64 through apt install.
go mod tidy failed with an error :
runtime/metrics: malformed module path "runtime/metrics": missing dot in first path element
I'll try to find a way to update my go version.

Ok, with go 1.19, things are going smoothly, i'm waiting for the make to complete.

And it's working ! No more error due to IP address !
Many thanks !!!

Great! Thanks again, @Bobaero, for helping out in testing so quickly. Glad the fix worked for you! We have released a new Azure AD plugin version, v0.8.3, including this fix.


Load iframe once user interacts with mockup

@MattCCC I think iframe seems to be reloading after loading for the first time, could you confirm, please?


Error recreating the container after a change in the volume local path

When I have a container running and I want to change the local folder in one of the volume definition, the container stop and try to restart (as I think it is the normal behavior) but cannot do it because there are a port collision and I get this error:

When this happens  I cannot operate with the container (I cannot start it again or remove it or do anything with it). My only choice is to restart the kitematic application and it's gone for once.
This doesn't happen all the times but usually (80%) and I don't see the port is occupied (no LISTEN or WAIT when I do a netstat inside the VM)

Did you pull the latest master? Some of the port binding logic was updated recently.
Is the image private or can I get it from docker hub in order to replicate this?

Yeah, I test it from the master. To reproduce that error I used a private
dockerfile but I'm going to try to reproduce with a public one so you can
test it too.
I'll keep you posted.
-- Sent from my mobile phone. Please excuse any typo.
On Nov 12, 2015 12:09 AM, "French Ben"<EMAIL_ADDRESS>wrote:

Did you pull the latest master? Some of the port binding logic was updated
recently.
Is the image private or can I get it from docker hub in order to replicate
this?
—
Reply to this email directly or view it on GitHub
https://github.com/kitematic/kitematic/issues/1205#issuecomment-155938334
.

I haven't been able to reproduce this error with different public repos (I tried with the hello-ngnix, tutum/centos and rabbitmq) so I'm pretty sure that the problem is with the private dockerfile I'm using and no with the program. So, I'm closing the issue now.
Thanks a lot anyway!!

:+1:


capture() function not working

Issue Description
The function async onCaptureImagePressed() on CameraScreen does not work and capture() dont work either, whether i use promise or not, i f I dont use the promise i just get '{"_U": 0, "_V": 0, "_W": null, "_X": null}', if i use the promise the code is not executed after. I have try Camera and. CameraScreen components
Steps to Reproduce / Code Snippets / Screenshots
this is not fixed, I am using latest release @aarongrider
try {
      let t1 = this.camera.capture();
      console.log(t1);
    } catch (e) {
      console.log(e);
    }
const image = await this.camera.capture();
    console.log(image);

Environment

React Native Navigation version: 0.63.4
React Native version: 16.13.1
Platform(s) (iOS, Android, or both?): Android for now, haven’t tested on ios yet.
Device info (Simulator/Device? OS version? Debug/Release?): Android 8.0, sdk 26, CAT device.

[UPDATES:]
It works with classpath('com.android.tools.build:gradle:4.1.1') but not classpath("com.android.tools.build:gradle:4.2.0");
The captured images don’t have a correct uri, or type, when trying to use the uri, it wont render in image.
{
"height": 1920,
"id": "/external/images/media/691",
"name": "691",
"path": "/external/images/media/691",
"uri": "content://media/external/images/media/691",
 "width": 1080
}

please update for com.android.tools.build:gradle:4.2.x. I'm using react-native v0.65.1 and have error when use com.android.tools.build:gradle:4.1.x

I'm getting this problem. Just tried saving camera reference to state, but don't see any difference. Did it work for anyone else?

It should work. I have already tried that earlier. Please check again. You might have missed something.

It's not working no matter what I do. I've tried putting the camera ref in state, using different components (Camera vs CameraScreen). Tried changing all different props, and just using it with a few props as possible.
It hangs on camera.capture(), only on Android. If the component is dismounted it then shows an error that says "Camera is closed" - otherwise I've waited 10 minutes for it to do anything after capture() and it just doesn't do it. No code after capture() is executed. I've even tried not using await and just executing it synchronously.
This is on Pixel 5, API 32 (Android 12)

It turned out to be something to do with the "virtual scene" that android emulates. If I set the emulator to just "emulate" the camera, instead of using a virtual scene, it works

It turned out to be something to do with the "virtual scene" that android emulates. If I set the emulator to just "emulate" the camera, instead of using a virtual scene, it works

Did you manage to run on the physical device? it works?

my problem was solved by using this
const {uri}= await webcamRef?.current?.capture?.(); and Im using   classpath('com.android.tools.build:gradle:4.1.1')

When you see '{"_U": 0, "_V": 0, "_W": null, "_X": null} output, it usually means you are logging the output of a promise. You can't rely on the exact characters here, but I've seen this before.
Make sure you await or .then(...) the promise returned by .capture().
Also make sure you access .current before you call .capture as such:
const myRef = useRef(); myRef.current.capture() - notice the .current.


Retrying with a backward compatible task type on unknown task type error in parallel indexing

Fixes https://github.com/apache/incubator-druid/issues/8836.
Description
I think I don't like this patch much, but don't see a better solution. Please leave comments if anyone has a better idea.
TaskMonitor.submit() creates a sub task for a given spec submits it to the overlord. Here, if the task type was unknown to the overlord (can happen during a rolling update), the overlord would return an HTTP error to TaskMonitor. HttpIndexingServiceClient would throw an IllegalStateException if the HTTP response was not 200.
To handle this, I added a new method SubTaskSpec.newSubTaskWithBackwardCompatibleType() which will be called if SubTaskSpec.newSubTask() fails with an IllegalStateExceptoin with a message starting with "Could not resolve type id".

This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths.
[ ] added integration tests.
[x] been tested in a test Druid cluster.

This change is

@gianm thanks for the review. I also tested this patch with a cluster of an overlord of 0.15.0 and middleManagers of this patch.


Airtable Destination

Description
this include the implementation of airtable destination
How Has This Been Tested?

[x] Test Destination UI

Checklist

[x] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[x] I have performed a self-review of my own code
[ ] I have added unit tests that prove my fix is effective or that my feature works
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

cc:
@wangxiaoyou1993

UI Tests:
Destination:

Config:

Run:

Logs:

Airtable:

Hi @wangxiaoyou1993
There is an issue in the config file as the template didn't show when I chose AIrtable as a destination. As this one below:

Config:


Update LWT version to 2.0.3

Use the latest version of LWT.
Change the link to 2.0.3 instead of latest to avoid issues.

Great Idea! Sorry for my delay! I merge it right now! thank you!


Request: Add option of user-specified function prefixes

Many projects which follow the cmake-based "superbuild" route of building all their dependencies during compile (particularly, ITK and VTK) like to prefix the functions of commonly used libraries as to guarantee they don't clash with system libraries accidentally.
Previously ITK had been using a forked zlib with mangled symbols https://gitlab.kitware.com/third-party/zlib/-/compare/master...for%2Fitk-v1.2.11-2017-01-15-cacf7f1d but want to transition to zlib-ng as their officially bundled codebase.
With the existing PREFIX features in zbuild.h I'd like to propose adding a user-specified prefix option to facilitate such use cases. I'm looking at adding a PR myself, but I need to learn the cmake part of things for this to work properly.

That's already in our To-Do list... I can't say currently how long it will take to implement.
We wanted to make the first official build first and then start adding more features.
If you make a pull request, we can help with getting cmake and configure to support it.

Is there any update on this?

I think the infrastructure already exists at https://github.com/zlib-ng/zlib-ng/blob/develop/zbuild.h#L41-L55
But I don't know cmake well enough to make this configurable in such a way that we could use it (yet)

The main issue is that the prefix is still hard-coded in the externally visible headers... What we need is version of those files that have the prefix adjusted to user-defined one. I know it can be done with simple string substitution during configuration step.

@dzenanz String substitution is quite easy with both cmake and configure, but I haven't really looked up how it can be done using nmake.

I will give this a try - at least for CMake. Then one of you could "port" it to configure.

PR in ITK works for me. Waiting for patches here to be merged: #1043, #1042, and #1041 or #1040.


[move-lang] do not coalesce nested loops into a shared header

Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/diem/diem/tree/main/developers.diem.com, and link to your PR here.)
If targeting a release branch, please fill the below out as well

Justification and breaking nature (who does it affect? validators, full nodes, tooling, operators, AOS, etc.)
Comprehensive test results that demonstrate the fix working and not breaking existing workflows.
Why we must have it for V1 launch.
What workarounds and alternative we have if we do not push the PR.

release binaries dependency change summary:
target packages:
  A disassembler 0.1.0 (workspace, path 'language/tools/disassembler')
    * features: default
  A move-coverage 0.1.0 (workspace, path 'language/tools/move-coverage')
    * features: default
  A colored 2.0.0 (direct third-party, crates.io)
    * features: [none]

Closing in favor of #8049.


i can't find release file

@socialpercon Its because build system is not functional yet. You will have to compile the app from source to generate binaries. We are working on getting releases up to pace at the moment.


Create documentation for deployment

Include inside the README.md process to explain how to deploy the website when changes are made

@redat97 this issue title should also include deployment of what "Create documentation for deployment of our public AI Lab site" and be set to Projects DevOps. I've already mentioned this before to you.


ModelViewInheritance throws if BO is not exported

add check for null

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.


ios socket.io-client is ok, android  ''Error: undefined is not an object (evaluating RCTWebSocketModule.connect)

my project,ios call npm socket.io-client is ok
but android has error.
build.gradle
compile 'com.facebook.react:react-native:0.12.+'
my code:
var ioc = require('socket.io-client/socket.io')
var socket = ioc('ws://<IP_ADDRESS>:8030', {})
socket.on('connect', function() {
console.log('socket server connected')
})

WebSocket is not in the 0.12 release.

This was fixed by #2870

I still see this on 0.14-rc. Is there some special way of setting up web sockets? Edit the android manifest or something?

@whokilledtheelectricmonk do you have an old project? I believe people are using WebSockets successfully so probably a configuration problem on your end unless 0.13 works but 0.14-rc doesn't.

The project was created on an older version but all the dependencies are reporting as up-to-date. Is there a way to cleanly update a project's Android component, or compare it to the latest default config?
-----Original Message-----
From: "James Ide"<EMAIL_ADDRESS>Sent: 10/27/2015 7:47 PM
To: "facebook/react-native"<EMAIL_ADDRESS>Cc: "Alex Krolick"<EMAIL_ADDRESS>Subject: Re: [react-native] ios socket.io-client is ok, android  ''Error:undefined is not an object (evaluating RCTWebSocketModule.connect) (#3378)
@whokilledtheelectricmonk do you have an old project? I believe people are using WebSockets successfully so probably a configuration problem on your end unless 0.13 works but 0.14-rc doesn't.
—
Reply to this email directly or view it on GitHub.

There's a brand new tool you could try: https://facebook.github.io/react-native/docs/upgrading.html, though it's hard to beat creating a new project and copying over your JS files in terms of complete reliability.

Ok, no more red screen. Submitting #3741 to put a link to that on the README.

same issue


Postal does not start up Rake error

09:43:58 requeuer.1         | Started with PID 1982
09:43:58 requeuer.1         | => rake aborted!
09:43:58 requeuer.1         | => LoadError: cannot load such file -- /opt/postal/config/application
09:43:58 requeuer.1         | => /opt/postal/Rakefile:4:in `require_relative'
09:43:58 requeuer.1         | => /opt/postal/Rakefile:4:in `<top (required)>'
09:43:58 requeuer.1         | => /opt/postal/vendor/bundle/ruby/2.6.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>'
09:43:58 requeuer.1         | => /usr/local/bundle/bin/bundle:23:in `load'
09:43:58 requeuer.1         | => /usr/local/bundle/bin/bundle:23:in `<main>'
09:43:58 requeuer.1         | => (See full trace by running task with --trace)
09:43:58 cron.1             | => rake aborted!
09:43:58 cron.1             | => LoadError: cannot load such file -- /opt/postal/config/application
09:43:58 cron.1             | => /opt/postal/Rakefile:4:in `require_relative'
09:43:58 cron.1             | => /opt/postal/Rakefile:4:in `<top (required)>'
09:43:58 cron.1             | => /opt/postal/vendor/bundle/ruby/2.6.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>'
09:43:58 cron.1             | => /usr/local/bundle/bin/bundle:23:in `load'
09:43:58 cron.1             | => /usr/local/bundle/bin/bundle:23:in `<main>'
09:43:58 cron.1             | => (See full trace by running task with --trace)
09:43:58 worker.1           | => script/worker.rb:2:in `require_relative': cannot load such file -- /opt/postal/config/environment (LoadError)
09:43:58 worker.1           | =>        from script/worker.rb:2:in `<main>'
09:43:58 smtp.1             | => rake aborted!
09:43:58 smtp.1             | => LoadError: cannot load such file -- /opt/postal/config/application
09:43:58 smtp.1             | => /opt/postal/Rakefile:4:in `require_relative'
09:43:58 smtp.1             | => /opt/postal/Rakefile:4:in `<top (required)>'
09:43:58 smtp.1             | => /opt/postal/vendor/bundle/ruby/2.6.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>'
09:43:58 smtp.1             | => /usr/local/bundle/bin/bundle:23:in `load'
09:43:58 smtp.1             | => /usr/local/bundle/bin/bundle:23:in `<main>'
09:43:58 smtp.1             | => (See full trace by running task with --trace)
09:43:58 web.1              | => bundler: failed to load command: puma (/opt/postal/vendor/bundle/ruby/2.6.0/bin/puma)
09:43:58 web.1              | => Errno::ENOENT: No such file or directory @ rb_sysopen - config/puma.rb
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/gems/puma-4.3.1/lib/puma/dsl.rb:46:in `read'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/gems/puma-4.3.1/lib/puma/dsl.rb:46:in `_load_from'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/gems/puma-4.3.1/lib/puma/configuration.rb:195:in `block in load'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/gems/puma-4.3.1/lib/puma/configuration.rb:195:in `each'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/gems/puma-4.3.1/lib/puma/configuration.rb:195:in `load'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/gems/puma-4.3.1/lib/puma/launcher.rb:58:in `initialize'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/gems/puma-4.3.1/lib/puma/cli.rb:71:in `new'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/gems/puma-4.3.1/lib/puma/cli.rb:71:in `initialize'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/gems/puma-4.3.1/bin/puma:8:in `new'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/gems/puma-4.3.1/bin/puma:8:in `<top (required)>'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/bin/puma:23:in `load'
09:43:58 web.1              | =>   /opt/postal/vendor/bundle/ruby/2.6.0/bin/puma:23:in `<top (required)>'

OK, missing Puma for some reason on an automated build. To look into in a couple days, otherwise try earlier relase.

There is only one tag 🤔

Oh dear. Added to list on Monday after I review my production copy.
Potentially has changed on upstream so will investigate.

No problem. Have a good weekend 😊


Propagate allow-listed exception to GHCollectionNode.

@kivancmuslu what with this PR? (doing some housekeeping)


Added next/previous controls to template detail view

Fixes #1280.
This PR does a couple things:

Lets the left railsnav hide itself based on route.
Adds next/prev buttons to navigate through the pool of templates based off the templates stored in context (which I think... might actually be the correct way to handle this in the long run too 🤔)

NOTE:  The left/right arrows I'm using are the old ones, until we get some updated figma goodness I figured it'd do just to use the old svgs so we can focus on the code and functionality.
All the pages for each template is the same which is why the pages aren't changing, but the title and description changing means it's properly jump from template to template:

Left arrow disabled on first template:

Both arrows enabled in the middle:

Right arrow disabled on last template:

Speaking of arrows...should navigation also work using the arrow keys?

Looking great. Works with a keyboard, but i noticed that the outline that shows when using a keyboard is a little long.

I wanted a large click area so people wouldn't need to click exactly on the arrow to navigate next/previous, but I went ahead and reduced its size to 40% so it's still a goodly button, but not ginormous.

Speaking of arrows...should navigation also work using the arrow keys?

Interesting... I think I'll push keyboard work into another PR for a later date just to jump to other work.


Training code

Hi, Jizhizi Li 🤗 🤗 🤗.
Many thanks for this amazing repo! Works very nice for my images with clothes! 🥳 👌👋
But it seems to me that the results can be further improved by additional training on individual cases. 👀
Some results:

Do you have some plans for realization the training code?
I have already seen the previous question on this topic, but I can't wait. 😈 😈 😈
Thank you for the answer! Have a very very nice day 🤓😄😄

Hi there,
Thanks for showing interest in our project, we have just released the training code and the code for data processing, welcome to have a try on your own dataset. :)


🙋♂ Interactive Logger

It would be really cool if signale would provide a way to create interactive loggers (not sure if that's what there called, but lemme explain 😄)
Pretty much if I have an interactive CLI that continuously changes it's output, I want to override any previous output whenever I log something new.
For example, this:
signale.pending();

setTimeout(()=>{
  signale.success();
}, 500)

Should output:
☐  pending

and then 500ms later replace it with:
✔  success

Instead of just writing both and ending up with both:
☐  pending
✔  success

This oubviously shouldn't be the default, but it would be really cool if this would be a feature that could be enabled.
tldr; add option to override previous output

This should be easily accomplished by adding a configuration option that prefixes specified logs with the \033c character. Logging that to the console clears/resets the terminal and start from the beginning as you described.
I can work on an implementation and do a PR if you want @klauscfhq

Nice suggestion!
The stream.clearLine(), stream.cursorTo() & stream.moveCursor() methods might also be useful.
Help is super welcome! : )

@davidnagli is your assumption that these pending logs would be blocking to the rest of the logs, meaning that nothing else will be logged until the pending process is resolved?


using this on debian 11 aka. bullseye is resulting in a non-systemd

System
Debian 11 aka. bullseye with the debian docker.io packages. (more details later)
Description
While trying to use the image directly in docker or via molecule, the image starts, but it seems it is not systemd enabled, resulting in failed test runs.
A self-brewn docker immage based on the official debian:bullseye works instead as expected.
But to be honest, docker is really not my area of expertise...
The issue seems to occur not only on the debian11 image, others like geerlingguy/docker-centos8-ansible, geerlingguy/docker-ubuntu2004-ansibleetc. seem affected too.
Steps to reproduce
$ docker run --detach --privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro geerlingguy/docker-debian11-ansible:latest
0c103204a41a3dd1487ab70813ac5fd4480f3f9e904f70cbe0c8a2b02443d986
$ docker ps
CONTAINER ID   IMAGE                                        COMMAND                  CREATED          STATUS          PORTS     NAMES
0c103204a41a   geerlingguy/docker-debian11-ansible:latest   "/lib/systemd/systemd"   39 seconds ago   Up 38 seconds             jovial_wilson
$ docker exec --tty 0c103204a41a /bin/systemctl status
Failed to connect to bus: No such file or directory

Test with own dilettantic build
$ cat Dockerfile

FROM debian:bullseye

ENV container docker
ENV LC_ALL C
ENV DEBIAN_FRONTEND noninteractive

RUN apt-get update \
    && apt-get install -y python3 sudo bash ca-certificates iproute2 python3-apt aptitude systemd systemd-sysv \
    && apt-get clean \
    && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

RUN rm -f /lib/systemd/system/multi-user.target.wants/* \
    /etc/systemd/system/*.wants/* \
    /lib/systemd/system/local-fs.target.wants/* \
    /lib/systemd/system/sockets.target.wants/*udev* \
    /lib/systemd/system/sockets.target.wants/*initctl* \
    /lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup* \
    /lib/systemd/system/systemd-update-utmp*

RUN systemctl set-default multi-user.target

#VOLUME [ "/sys/fs/cgroup" ]

CMD [ "/lib/systemd/systemd", "log-level=info", "unit=sysinit.target" ]

$ docker build .
Sending build context to Docker daemon  3.072kB
Step 1/8 : FROM debian:bullseye
...
Successfully built eb8ff56c63ab

$ docker tag eb8ff56c63ab test-deb11-systemd

$ docker  run --detach --privileged  --name test-deb11-systemd test-deb11-systemd
7b0afaa24585c10a5ddcab18c0b1d06aef23501282dc0e8918e505784862a2a8

$ docker exec --tty 7b0afaa24585c10a5ddcab18c0b1d06aef23501282dc0e8918e505784862a2a8 /bin/systemctl status
* 7b0afaa24585
    State: running
     Jobs: 0 queued
   Failed: 0 units
    Since: Fri 2022-01-21 21:50:32 UTC; 6s ago
   CGroup: /
           |-init.scope
           | |- 1 /lib/systemd/systemd log-level=info unit=sysinit.target
           | |-35 /bin/systemctl status
           | `-42 (pager)
           `-system.slice
             `-systemd-journald.service
               `-26 /lib/systemd/systemd-journald

Distro and Packages:
Distributor ID:	Debian
Description:	Debian GNU/Linux 11 (bullseye)
Release:	11
Codename:	bullseye

Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                      Version                 Architecture Description
+++-=========================-=======================-============-=====================================================
ii  docker                    1.5-2                   all          transitional package
ii  docker.io                 20.10.5+dfsg1-1+deb11u1 amd64        Linux container runtime
ii  python3-docker            4.1.0-1.2               all          Python 3 wrapper to access docker.io's control socket

check-config
$ /usr/share/docker.io/contrib/check-config.sh
warning: /proc/config.gz does not exist, searching other paths for kernel config ...
info: reading kernel config from /boot/config-5.10.0-10-amd64 ...

Generally Necessary:
- cgroup hierarchy: cgroupv2
- apparmor: enabled, but apparmor_parser missing
    (use "apt-get install apparmor" to fix this)
- CONFIG_NAMESPACES: enabled
- CONFIG_NET_NS: enabled
- CONFIG_PID_NS: enabled
- CONFIG_IPC_NS: enabled
- CONFIG_UTS_NS: enabled
- CONFIG_CGROUPS: enabled
- CONFIG_CGROUP_CPUACCT: enabled
- CONFIG_CGROUP_DEVICE: enabled
- CONFIG_CGROUP_FREEZER: enabled
- CONFIG_CGROUP_SCHED: enabled
- CONFIG_CPUSETS: enabled
- CONFIG_MEMCG: enabled
- CONFIG_KEYS: enabled
- CONFIG_VETH: enabled (as module)
- CONFIG_BRIDGE: enabled (as module)
- CONFIG_BRIDGE_NETFILTER: enabled (as module)
- CONFIG_IP_NF_FILTER: enabled (as module)
- CONFIG_IP_NF_TARGET_MASQUERADE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_ADDRTYPE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_CONNTRACK: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_IPVS: enabled (as module)
- CONFIG_NETFILTER_XT_MARK: enabled (as module)
- CONFIG_IP_NF_NAT: enabled (as module)
- CONFIG_NF_NAT: enabled (as module)
- CONFIG_POSIX_MQUEUE: enabled

Optional Features:
- CONFIG_USER_NS: enabled
- CONFIG_SECCOMP: enabled
- CONFIG_CGROUP_PIDS: enabled
- CONFIG_MEMCG_SWAP: enabled
    (cgroup swap accounting is currently enabled)
- CONFIG_LEGACY_VSYSCALL_NONE: enabled
    (containers using eglibc <= 2.13 will not work. Switch to
     "CONFIG_VSYSCALL_[NATIVE|EMULATE]" or use "vsyscall=[native|emulate]"
     on kernel command line. Note that this will disable ASLR for the,
     VDSO which may assist in exploiting security vulnerabilities.)
- CONFIG_BLK_CGROUP: enabled
- CONFIG_BLK_DEV_THROTTLING: enabled
- CONFIG_CGROUP_PERF: enabled
- CONFIG_CGROUP_HUGETLB: enabled
- CONFIG_NET_CLS_CGROUP: enabled (as module)
- CONFIG_CGROUP_NET_PRIO: enabled
- CONFIG_CFS_BANDWIDTH: enabled
- CONFIG_FAIR_GROUP_SCHED: enabled
- CONFIG_RT_GROUP_SCHED: missing
- CONFIG_IP_NF_TARGET_REDIRECT: enabled (as module)
- CONFIG_IP_VS: enabled (as module)
- CONFIG_IP_VS_NFCT: enabled
- CONFIG_IP_VS_PROTO_TCP: enabled
- CONFIG_IP_VS_PROTO_UDP: enabled
- CONFIG_IP_VS_RR: enabled (as module)
- CONFIG_EXT4_FS: enabled (as module)
- CONFIG_EXT4_FS_POSIX_ACL: enabled
- CONFIG_EXT4_FS_SECURITY: enabled
- Network Drivers:
  - "overlay":
    - CONFIG_VXLAN: enabled (as module)
    - CONFIG_BRIDGE_VLAN_FILTERING: enabled
      Optional (for encrypted networks):
      - CONFIG_CRYPTO: enabled
      - CONFIG_CRYPTO_AEAD: enabled (as module)
      - CONFIG_CRYPTO_GCM: enabled (as module)
      - CONFIG_CRYPTO_SEQIV: enabled (as module)
      - CONFIG_CRYPTO_GHASH: enabled (as module)
      - CONFIG_XFRM: enabled
      - CONFIG_XFRM_USER: enabled (as module)
      - CONFIG_XFRM_ALGO: enabled (as module)
      - CONFIG_INET_ESP: enabled (as module)
  - "ipvlan":
    - CONFIG_IPVLAN: enabled (as module)
  - "macvlan":
    - CONFIG_MACVLAN: enabled (as module)
    - CONFIG_DUMMY: enabled (as module)
  - "ftp,tftp client in container":
    - CONFIG_NF_NAT_FTP: enabled (as module)
    - CONFIG_NF_CONNTRACK_FTP: enabled (as module)
    - CONFIG_NF_NAT_TFTP: enabled (as module)
    - CONFIG_NF_CONNTRACK_TFTP: enabled (as module)
- Storage Drivers:
  - "aufs":
    - CONFIG_AUFS_FS: missing
  - "btrfs":
    - CONFIG_BTRFS_FS: enabled (as module)
    - CONFIG_BTRFS_FS_POSIX_ACL: enabled
  - "devicemapper":
    - CONFIG_BLK_DEV_DM: enabled (as module)
    - CONFIG_DM_THIN_PROVISIONING: enabled (as module)
  - "overlay":
    - CONFIG_OVERLAY_FS: enabled (as module)
  - "zfs":
    - /dev/zfs: missing
    - zfs command: missing
    - zpool command: missing

Limits:
- /proc/sys/kernel/keys/root_maxkeys: 1000000

Yes. Her the relevant part from a failing example:
  - name: keepalived-bionic
    pre_build_image: yes
    image: geerlingguy/docker-ubuntu1804-ansible:latest
    privileged: true
    command: /lib/systemd/systemd
    volumes:
    - /sys/fs/cgroup:/sys/fs/cgroup:ro

and a tasks that enables a service via systemd fails with:
"stderr_lines": ["Failed to connect to bus: No such file or directory"]

@zerwes - Can you try changing the command to match what I have set up in mine?

Hello @geerlingguy
Unfortunately makes no difference:
@@ -71,6 +71,6 @@ platforms:
     pre_build_image: yes
     image: geerlingguy/docker-ubuntu2004-ansible:latest
     privileged: true
-    command: /lib/systemd/systemd
+    command: ${MOLECULE_DOCKER_COMMAND:-""}
     volumes:
     - /sys/fs/cgroup:/sys/fs/cgroup:ro

but on the invocation of systemctl: "rc": 1, "stderr": "Failed to connect to bus: No such file or directory"

/me watches this :)

I run into the same problem as @zerwes

@stefanDeveloper is something like the docker file mentioned in the description of the issue or like https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-role-unbound/blob/main/molecule/default/Dockerfile-debian-bullseye.j2 working for you?

@zerwes you saved my week, thanks that works like a charm!

@stefanDeveloper glad to hear it helped.
and maybe it helps @geerlingguy better to drill down the problem ...

I got a similar problem like @zerwes (Hi, by the way :-) ) in https://github.com/NETWAYS/ansible-role-elasticsearch/pull/53 .
As another change that might have an influence I had to remove the following lines because it made starting Elasticsearch in the containers impossible on CentOS:
     volumes:
     - /sys/fs/cgroup:/sys/fs/cgroup:ro

Since I removed that, CentOS tests succeed but Debian ones fail. I put some debugging code into my roles to put out what's wrong. What I'm seeing is:
  fatal: [elasticsearch-cluster2]: FAILED! => {"changed": false, "cmd": "/bin/systemctl", "msg": "Failed to connect to bus: No such file or directory", "rc": 1, "stderr": "Failed to connect to bus: No such file or directory\n", "stderr_lines": ["Failed to connect to bus: No such file or directory"], "stdout": "", "stdout_lines": []}

Hello @widhalmt, is something like the docker file mentioned in the description of the issue or like https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-role-unbound/blob/main/molecule/default/Dockerfile-debian-bullseye.j2 working for you?

@zerwes So you mean, disabling mounting cgroups? As far as I understood the information from https://discuss.elastic.co/t/error-when-running-7-12-1-on-centos-7-in-docker/271508 the problem was cgroups being mounted in two parts of the test. Looks like you disabled it in the Docker file, I disabled it in molecule.yml. My approach did work with CentOS but not with Debian.
I use several containers by @geerlingguy so I can't easily exchange the container I'm using. I could give it a try to exchange it temporarily, though.

I'm seeing the same effect with Rock Linux 8 now, too. After removing the mount for cgroups in molecule.yml CentOS 7 works again but Debian 10, Debian 11 and Rock Linux 8 fail.

I use several containers by @geerlingguy so I can't easily exchange the container I'm using. I could give it a try to exchange it temporarily, though.

My intention is surely not to replace the widely< used docker images (therefore my docker foo is much to weak, as I consider myself in this topic just a average user), I just wanted to give @geerlingguy a hint and some help what works and what not ...

I use several containers by @geerlingguy so I can't easily exchange the container I'm using. I could give it a try to exchange it temporarily, though.

My intention is surely not to replace the widely< used docker images (therefore my docker foo is much to weak, as I consider myself in this topic just a average user), I just wanted to give @geerlingguy a hint and some help what works and what not ...

Sorry, that was just me being unclear in my reply. I understood that you did only suppose that for tests and not to replace them completely. What I forgot to mention is, that I'm using them in a matrix check with different OS'es and I can't easily replace a single one, because it wouldn't even start. I need time to change the whole CI configuration to use the container in a test.

@geerlingguy I really don't get it either. I see the problems mostly when running them in GitHub actions. For now it works flawlessly with CentOS 7 (when I remove mounting the cgroups in molecule.yml. But it breaks in Rocky Linux 8, Debian 10 and Debian 11.

@tbumke - On macOS, that has to do with the implementation of cgroups v2 in Docker for Mac. I believe there's a way to work around it...

@widhalmt @zerwes apologies if I have overlooked this but which host system are you using? I ran into the same issues and decided to give up on this matter, just watching this issue.
I am trying to run this in a WSL2 on either Windows 10 or 11 resulting in Debian based containers not starting with systemd or not starting at all. Concerning this all that I have found online is that for some reason the WSL2 seems to be incompatible to handle this virtualization.
If it's a Windows-Virtualization issue it would explain why it works fine on (most) MACs and Jeff's Ubuntu

@Paul-Weisser my first touch with this was running a debian 11 container on debian 11 ...

@tbumke - On macOS, that has to do with the implementation of cgroups v2 in Docker for Mac. I believe there's a way to work around it...

Thanks @geerlingguy , this pointed me in the right direction. Searching for cgroups v2 and Docker for Mac, I found this issue  https://github.com/docker/for-mac/issues/6073 which also describes a workaround.
Configuring "deprecatedCgroupv1": true (note the missing "s") in ~/Library/Group\ Containers/group.com.docker/settings.json tells Docker for Mac to use legacy cgroups v1. This of course is only a temporary fix until Ansible Molecule supports the cgroupns Docker parameter.
Running the container as this also works in my setup:
docker run -it --privileged --cgroupns=host -v /sys/fs/cgroup:/sys/fs/cgroup:rw \
  --name instance -d geerlingguy/docker-debian11-ansible

Note also, that the sysfs volume permissions need to be changed to rw as well. Then I can successfully run systemd services and commands from the container.

Thanks @tbumke !!
Changing
    volumes:
    - /sys/fs/cgroup:/sys/fs/cgroup:ro

to
    volumes:
    - /sys/fs/cgroup:/sys/fs/cgroup:rw

did the trick!
Now' I only have to find a way to get around a bug Elasticsearch that keeps instances on multiple instances from starting because the Java Option parser print to stdout insttead of a file. But that only hits when I fire up several containers in a single test and won't keep me from proceeding with the other roles. Thank you everyone, that kept me in a constant state of rage for weeks now. :-)

Ok, guess now I'm completely lost. Now it works sometimes and sometimes it doesn't. I'll have to take a deeper look, sorry.

+1 have the same

also have this, anything I can provide of information to get this fixed @geerlingguy?

As I've said before, I haven't had any issues running this with systemd (for example, see my Docker role: https://github.com/geerlingguy/ansible-role-docker/blob/master/.github/workflows/ci.yml#L48 / https://github.com/geerlingguy/ansible-role-docker/runs/5959693637?check_suite_focus=true)
If someone can get a reproducible fault that works with the base image and the same kind of setup I'm using, that would be helpful.

When using the CI/CD environment (gitlab ci or any), you can use the settings for the docker daemon:
daemon.json
{
  "debug": false,
  "default-cgroupns-mode": "host",
  "storage-driver": "vfs"
}

Thanks, @echohes . For Elasticsearch it didn't work. There's a bug that interferes with Cgroups, maybe I just have to wait for a fix. Thanks anyway. Hopefully it works for others.

@geerlingguy for using Docker on Mac it is in fact Docker Desktop I presume, right?
Looks like from the version 4.3.0 / 2021-12-02 release notes we have cgroups v2:

Docker Desktop now uses cgroupv2. If you need to run systemd in a container then:

Ensure your version of systemd supports cgroupv2. It must be at least systemd 247. Consider upgrading any centos:7 images to centos:8.
Containers running systemd need the following options: [--privileged --cgroupns=host -v /sys/fs/cgroup:/sys/fs/cgroup:rw]
(https://serverfault.com/questions/1053187/systemd-fails-to-run-in-a-docker-container-when-using-cgroupv2-cgroupns-priva).

And from version 4.4.2 / 2022-01-13 release notes:

Added a deprecated option to settings.json: "deprecatedCgroupv1": true, which switches the Linux environment back to cgroups v1. If your software requires cgroups v1, you should update it to be compatible with cgroups v2. Although cgroups v1 should continue to work, it is likely that some future features will depend on cgroups v2. It is also possible that some Linux kernel bugs will only be fixed with cgroups v2.

I faced a similar issue in MacOS with an M1 Mac. My work around was to add the following setting in the Docker Engine configuration:
"default-cgroupns-mode": "host"

I then had to change the bind mount to be rw instead of ro:
    volumes:
      - /sys/fs/cgroup:/sys/fs/cgroup:rw

@dataoscar but we can't configure Docker Engine of GithubActions to run molecule, or can we?

I've never had any issues with whatever docker engine GitHub Actions uses and Molecule for Ansible using @geerlingguy's Molecule config as a template. I.e., with the platforms block looking like this,
platforms:
  - name: instance
    image: "geerlingguy/docker-${MOLECULE_DISTRO:-centos7}-ansible:latest"
    command: ${MOLECULE_DOCKER_COMMAND:-""}
    volumes:
      - /sys/fs/cgroup:/sys/fs/cgroup:ro
    privileged: true
    pre_build_image: true

In my setup, cgroups only caused issues on Docker Desktop for Mac.

I have a Fedora36 host and an Ubuntu 22.04 host and I get the same issue testing with https://github.com/geerlingguy/molecule-playbook-testing
The container is not actually running systemd completely.
MOLECULE_DISTRO=debian11 molecule converge
...
...
MOLECULE_DISTRO=debian11 molecule login
root@instance:/# ps faxwww
    PID TTY      STAT   TIME COMMAND
   1421 pts/0    Ss     0:00 bash
   1429 pts/0    R+     0:00  \_ ps faxwww
      1 ?        Ss     0:00 /lib/systemd/systemd
root@instance:/# systemctl status
System has not been booted with systemd as init system (PID 1). Can't operate.
Failed to connect to bus: Host is down

This change, taken from what @zerwes post at the top of this issue, is what fixes it for me.
# Dockerfile
...
...
-COPY initctl_faker .
-RUN chmod +x initctl_faker && rm -fr /sbin/initctl && ln -s /initctl_faker /sbin/initctl

 # Install Ansible inventory file.
 RUN mkdir -p /etc/ansible
 RUN echo "[local]\nlocalhost ansible_connection=local" > /etc/ansible/hosts

+RUN systemctl set-default multi-user.target

-VOLUME ["/sys/fs/cgroup"]
 CMD ["/lib/systemd/systemd"]

and
# molecule/default/molecule.yml
...
...
   ansible-lint
 platforms:
   - name: instance
     image: geerlingguy/docker-${MOLECULE_DISTRO:-centos8}-ansible:latest
     command: ""
-    volumes:
-      - /sys/fs/cgroup:/sys/fs/cgroup:ro
     privileged: true
     pre_build_image: true
 provisioner:
   name: ansible

Rerunning with these changes results in
MOLECULE_DISTRO=debian11 molecule converge
...
...
MOLECULE_DISTRO=debian11 molecule login
root@instance:/# ps -faxwww
    PID TTY      STAT   TIME COMMAND
   1796 pts/0    Ss     0:00 bash
   1808 pts/0    R+     0:00  \_ ps -faxwww
      1 ?        Ss     0:00 /lib/systemd/systemd
     25 ?        Ss     0:00 /lib/systemd/systemd-journald
   1719 ?        Ss     0:00 /usr/sbin/apache2 -k start
   1720 ?        Sl     0:00  \_ /usr/sbin/apache2 -k start
   1721 ?        Sl     0:00  \_ /usr/sbin/apache2 -k start
root@instance:/# systemctl status
● instance
    State: running
     Jobs: 0 queued
   Failed: 0 units
    Since: Sun 2022-08-21 06:10:29 UTC; 9min ago
   CGroup: /
           ├─init.scope
           │ ├─   1 /lib/systemd/systemd
           │ ├─1796 bash
           │ ├─1809 systemctl status
           │ └─1810 (pager)
           └─system.slice
             ├─apache2.service
             │ ├─1719 /usr/sbin/apache2 -k start
             │ ├─1720 /usr/sbin/apache2 -k start
             │ └─1721 /usr/sbin/apache2 -k start
             └─systemd-journald.service
               └─25 /lib/systemd/systemd-journald

I have learnt some more since I posted above.

@aussielunix Thx for the investigation! The Debian/buster container works fine, but it seems like Debian/buster is missing in the gitlab registry: https://gitlab.com/aussielunix/ansible/molecule-containers/container_registry/3343441

@jkirk ahh the auto-pruning was set too aggressive.
I have relaxed it and triggered new containers to be built.

I am finally able to overcome the issue. Copying from https://github.com/ansible-community/molecule/issues/3632

Upgrade to molecule 4.0.3
Add cgroupns_mode: host
Change /sys/fs/cgroup:/sys/fs/cgroup:ro to /sys/fs/cgroup:/sys/fs/cgroup:rw

Example: https://github.com/ansible-community/molecule/pull/3665#issuecomment-1254979734

Indeed, I just noticed the update, tested it, and wrote this blog post: Docker and systemd, getting rid of dreaded 'Failed to connect to bus' error.

Hi. cgroupns_mode: host fixes the issue with systemctl, but other commands (like localectl and timedatectl) have the same problem. I get the same behavior with the rocky linux 9 container. Any suggestions are welcome

@artis3n in my case it was also necessary to install the current community.docker collection from Ansible Galaxy

Ok, I'm officially confused and ready to drop the towel in favor of testing directly inside Github Runners.
The fix everybody likes only works for me for docker-debian11-ansible:latest containers:
  - name: instance
    image: "geerlingguy/docker-${MOLECULE_DISTRO:-centos7}-ansible:latest"
    command: ${MOLECULE_DOCKER_COMMAND:-""}
    volumes:
      - /sys/fs/cgroup:/sys/fs/cgroup:rw
    cgroupns_mode: host
    privileged: true
    pre_build_image: true

It fails inside docker-centos7-ansible:latest with
fatal: [instance]: FAILED! => {"changed": false, "msg": "Service is in unknown state", "status": {}}

On the other hand @aussielunix fix looking like this:
platforms:
  - name: instance
    image: "geerlingguy/docker-${MOLECULE_DISTRO:-centos7}-ansible:latest"
    command: ${MOLECULE_DOCKER_COMMAND:-""}
    override_command: false
    tmpfs:
      - /run
      - /tmp
    cgroupns_mode: host
    privileged: true
    pre_build_image: true

works for  docker-centos7-ansible:latest but fails with  docker-debian11-ansible:latest with:
Failed to connect to bus: No such file or directory

Running locally on Ubuntu 22.04 latest versions of ansible, molecule, community.general, community.docker.

Thank to @artis3n
I am running molecule 5.0.1 with ansible 2.14.5. Adding the command: ${MOLECULE_DOCKER_COMMAND:-"/lib/systemd/systemd"} worked for me when using ubuntu2204, together with volumes, privilged mode and cgroupsns_mode

Yeah, if it is helpful to others here are all the distros I was testing and what command I had to use:
https://github.com/artis3n/ansible-role-tailscale/blob/7e9907a606df08ce79fa675bbf45c59be97a1e9b/.github/workflows/pull_request_target.yml#L24-L44
and https://github.com/artis3n/ansible-role-tailscale/blob/7e9907a606df08ce79fa675bbf45c59be97a1e9b/.github/workflows/pull_request_target.yml#L59-L65
Default if not provided is /usr/sbin/init


Does this work with private repo?

Hey, thanks for building this. I went for a try but seems to get no luck:
λ git spr u
> git rev-parse --show-toplevel
> git fetch
> git rebase origin/main --autostash
> github fetch pull requests
> git branch
> git log origin/main..HEAD
> git status --porcelain --untracked-files=no
> github fetch pull requests
> git branch
pull request stack is empty

So i'm wondering is it because i'm working with a private repo? I guess this script works by querying Github API?

From your log it looks like your setup is all good, you just don't have any new commits.
You should be able to make a commit, call git spr u and the pr should be created.

Thanks everyone!
@ejoffe Emm...I actually had 4 more commits ahead of origin/main. git log origin/main..HEAD shows them as well. Do you know what could go wrong and how can I triage?
They are in a different branch.
I even tried

rebasing them to main and git spr u
checkout toe the 1st commit and git spr u
but still got pull request stack is empty

As long as you are calling git spr u in the branch that has the commits, it should work.
In general you can work in whatever branch you want, or work in multiple branches, each branch creates its own stack of commits/prs. The behavior you are experiencing is very odd.
You can try to run it with debug and see if it sheds any light:
git spr --debug --verbose update

@ejoffe Thanks! Here is what I got
repo_name git/branch_name  64s
λ git spr --debug --verbose update
> git rev-parse --show-toplevel
Config : {
  "Repo": {
    "GitHubRepoOwner": "",  // omitted
    "GitHubRepoName": "repo_name",
    "GitHubHost": "github.com",
    "RequireChecks": true,
    "RequireApproval": true,
    "GitHubRemote": "origin",
    "GitHubBranch": "main",
    "MergeMethod": "rebase"
  },
  "User": {
    "ShowPRLink": true,
    "LogGitCommands": true,
    "LogGitHubCalls": true,
    "StatusBitsHeader": true,
    "StatusBitsEmojis": true,
    "CreateDraftPRs": false,
    "Stargazer": false,
    "RunCount": 24
  }
}
3:00PM DBG ../../../runner/work/spr/spr/git/realgit/realcmd.go:45 > git fetch
> git fetch
3:00PM DBG ../../../runner/work/spr/spr/git/realgit/realcmd.go:45 > git rebase origin/main --autostash
> git rebase origin/main --autostash
> github fetch pull requests
3:00PM DBG ../../../runner/work/spr/spr/git/realgit/realcmd.go:45 > git branch
> git branch
3:00PM DBG ../../../runner/work/spr/spr/github/githubclient/client.go:273 > GetInfo Info={"LocalBranch":"\u001b[1;32mbranch_name\u001b[m","PullRequests":null,"RepositoryID":"R_kgDOGziB_g","UserName":"Huxpro"}
3:00PM DBG ../../../runner/work/spr/spr/git/realgit/realcmd.go:45 > git log origin/main..HEAD
> git log origin/main..HEAD
3:00PM DBG ../../../runner/work/spr/spr/git/realgit/realcmd.go:45 > git status --porcelain --untracked-files=no
> git status --porcelain --untracked-files=no
> github fetch pull requests
3:00PM DBG ../../../runner/work/spr/spr/git/realgit/realcmd.go:45 > git branch
> git branch
3:00PM DBG ../../../runner/work/spr/spr/github/githubclient/client.go:273 > GetInfo Info={"LocalBranch":"\u001b[1;32mbranch_name\u001b[m","PullRequests":null,"RepositoryID":"R_kgDOGziB_g","UserName":"Huxpro"}
pull request stack is empty

But my git lg be like
* 10a1700 - (HEAD -> branchname) ...
* 8879720 - ...
* 7d26df0 - ...
* 928f83f - ...
* 8d52a85 - (origin/main, main) ...

Unfortunately that doesn't add too much color.
It looks like an issue with parseLocalCommitStack function, I am guessing that for some reason it's returning an empty list of commits.
This function goes through the output of git log origin/main..HEAD and mainly looks for the following two regexes to parse the output:
	commitHashRegex := regexp.MustCompile(`^commit ([a-f0-9]{40})`)
	commitIDRegex := regexp.MustCompile(`commit-id\:([a-f0-9]{8})`)

can you check or paste a sanitized version of the output of git log origin/main..HEAD?

@ejoffe thanks for the prompt response!
repo_name git/main*  13s
commit 10a17001e7b11484ed4610db6f0c1e405ed19c9e (HEAD -> branch_name)
Author: Xuan Huang<EMAIL_ADDRESS>Date:   Wed Mar 9 17:32:08 2022 -0800

    [Blah] Blah

commit 887972046e17485d3559c6b666329c2a7c5c5671
Author: Xuan Huang<EMAIL_ADDRESS>Date:   Wed Mar 9 16:48:48 2022 -0800

    [Foo] Bar

commit 7d26df0bced0efff96bd57470c1a187afa9248bf
Author: Xuan Huang<EMAIL_ADDRESS>Date:   Wed Mar 9 15:11:20 2022 -0800

    [Wola] Hey

commit 928f83faaad4d4fa79d0592c4641556f4a66a676
Author: Xuan Huang<EMAIL_ADDRESS>Date:   Tue Mar 8 22:00:10 2022 -0800

    [Tag] Title

I'll add some more debug logs to the next version of spr, and hopefully we can get more insight into what's going on.
If you are comfortable with go, feel free to debug and try to root cause this yourself as well. Bug fixes are always more than welcome.

@Huxpro - I added some more debug logs in v0.8.3. You can try to run with -debug flag and see if we can get more insights into what's going on.

Hey @ejoffe, I just upgraded to v0.8.3 and tested it out. But you know what, this times it just works™! The shame is that we don't know what was happened but I think we can close this for now.
It took me a while to get back to you since I was in the middle of a stack using https://github.com/ezyang/ghstack and I'm pretty sure using both would blow my stack up hah. I'm going to give spr a try before settling down on either spr or ghstack, but I'm curious how do you compare spr vs. ghstack? At a high-level they seems to be really close: stacked commits -> stacked PR; nice PR message on Github; Needs special command for merging, etc.
I do see https://github.com/ejoffe/spr/issues/115 (git error: There is no tracking information for the current branch.) when I was trying to git amend though.

Actually, git spr merge doesn't do anything because the stack check failed
 ┌─ github checks pass
 │ ┌── pull request approved
 │ │ ┌─── no merge conflicts
 │ │ │ ┌──── stack check
 │ │ │ │
[✅❌✅❌]
[✅❌✅❌]

I'm not sure what happened? That's the only two PRs out there and Github shows them "rebase and merge"-able as well.

Ok it seems like git error: There is no tracking information for the current branch. is caused by the local branch doesn't have an origin upstream. So rebasing on main (which is tracking origin/main) then git amend works fine (although it fired up another stack of PR, Oops)
But the stack check still failed and git spr merge still does nothing...emm

Glad it's working!
I haven't used ghstack, so I'm not the best person to compare. I'd love to know though, so if you use both, I would be interested to know the differences.
Looks like your pr hasn't be approved, you either need someone to approve the pr on the github review ui, or you can disable pr approval in your repository .spr.yml, set requireApproval to false.
The amend bug #115 should be fixed in v0.8.4, if you get the latest you'll have the fix.

@ejoffe Oh wasn't know the stack check flag is correlated to the approval flag. Yea it merged just fine! Thanks for the supports!

I haven't used ghstack, so I'm not the best person to compare. I'd love to know though, so if you use both, I would be interested to know the differences.

I'll use spr for a while and let you know. My first impression is that the CLI TUI feels more friendly!

I am also getting the same issue, version 0.14.4.
$ git spr --verbose --debug up --detail
> git rev-parse --show-toplevel
Config : {
  "Repo": {
    "GitHubRepoOwner": "<redacted>",
    "GitHubRepoName": "<redacted>",
    "GitHubHost": "github.com",
    "GitHubRemote": "origin",
    "GitHubBranch": "develop",
    "RequireChecks": true,
    "RequireApproval": true,
    "MergeMethod": "rebase",
    "MergeQueue": true,
    "PRTemplatePath": "",
    "PRTemplateInsertStart": "",
    "PRTemplateInsertEnd": "",
    "MergeCheck": "",
    "ForceFetchTags": false
  },
  "User": {
    "ShowPRLink": true,
    "LogGitCommands": true,
    "LogGitHubCalls": true,
    "StatusBitsHeader": true,
    "StatusBitsEmojis": true,
    "CreateDraftPRs": true,
    "PreserveTitleAndBody": false,
    "NoRebase": false
  },
  "State": {
    "MergeCheckCommit": {},
    "Stargazer": false,
    "RunCount": 29
  }
}
5:14PM DBG ../../../Users/runner/work/spr/spr/git/realgit/realcmd.go:58 > git fetch
> git fetch
5:14PM DBG ../../../Users/runner/work/spr/spr/git/realgit/realcmd.go:58 > git rebase origin/develop --autostash
> git rebase origin/develop --autostash
> github fetch pull requests
5:14PM DBG ../../../Users/runner/work/spr/spr/git/realgit/realcmd.go:58 > git log --format=medium --no-color origin/develop..HEAD
> git log --format=medium --no-color origin/develop..HEAD
5:14PM DBG ../../../Users/runner/work/spr/spr/git/helpers.go:100 > parseLocalCommitStack lines=11
5:14PM DBG ../../../Users/runner/work/spr/spr/git/helpers.go:155 > parseLocalCommitStack commits=null
5:14PM DBG ../../../Users/runner/work/spr/spr/git/realgit/realcmd.go:58 > git branch --no-color
> git branch --no-color
5:14PM DBG ../../../Users/runner/work/spr/spr/github/githubclient/client.go:204 > GetInfo Info={"LocalBranch":"daniel.simmons/<redacted>","PullRequests":[],"RepositoryID":"<redacted>","UserName":"dansimau"}
5:14PM DBG ../../../Users/runner/work/spr/spr/git/realgit/realcmd.go:58 > git log --format=medium --no-color origin/develop..HEAD
> git log --format=medium --no-color origin/develop..HEAD
5:14PM DBG ../../../Users/runner/work/spr/spr/git/helpers.go:100 > parseLocalCommitStack lines=11
5:14PM DBG ../../../Users/runner/work/spr/spr/git/helpers.go:155 > parseLocalCommitStack commits=null
5:14PM DBG ../../../Users/runner/work/spr/spr/git/realgit/realcmd.go:58 > git status --porcelain --untracked-files=no
> git status --porcelain --untracked-files=no
> github fetch pull requests
5:14PM DBG ../../../Users/runner/work/spr/spr/git/realgit/realcmd.go:58 > git log --format=medium --no-color origin/develop..HEAD
> git log --format=medium --no-color origin/develop..HEAD
5:14PM DBG ../../../Users/runner/work/spr/spr/git/helpers.go:100 > parseLocalCommitStack lines=11
5:14PM DBG ../../../Users/runner/work/spr/spr/git/helpers.go:155 > parseLocalCommitStack commits=null
5:14PM DBG ../../../Users/runner/work/spr/spr/git/realgit/realcmd.go:58 > git branch --no-color
> git branch --no-color
5:14PM DBG ../../../Users/runner/work/spr/spr/github/githubclient/client.go:204 > GetInfo Info={"LocalBranch":"daniel.simmons/<redacted>","PullRequests":[],"RepositoryID":"<redacted>","UserName":"dansimau"}
pull request stack is empty

Running git log manually shows my commit:
$ git log --format=medium --no-color origin/develop..HEAD
commit 44ffc995 (HEAD -> daniel.simmons/<redacted>)
Author: Daniel Simmons <dan.simmons@<redacted>>
Date:   Fri Nov 24 17:13:00 2023 +0100

    <redacted>

commit 97e609a1
Author: Daniel Simmons <dan.simmons@<redacted>>
Date:   Fri Nov 24 15:57:42 2023 +0100

    <redacted>

Will try to debug more later, but it looks like commit parsing is failing.
$ git version
git version 2.42.0

Okay issue here is that I have this in my ~/.gitconfig:
[log]
abbrevCommit=true

And thus it doesn't match the regexp. I'll file a separate issue.


Spring-boot integration context loading for every test case

Hi,
I have recently migrated from H2 to MariaDB4J. Test cases are executing but it is taking longer time than H2. When I see the logs, the spring context is loaded for every test case and the database schema initialisation is happening. We have hibernate.hbm2ddl = auto setting to sync the database schema.
Any help would be appreciated. Basically, I want only to load the DB only once and use it for all the test cases.

Hello!
Thank you for your interest in this project.
The problem you are raising here isn't particular specific to MariaDB4j, but perhaps more of a general how to use Spring Framework question.
I'm unfortunately unable to offer you support for this particular problem, but have full faith in you that you will be able to figure this out yourself by searching more online.
I'll therefore be closing this issue. Please comment if you disagree and opine that this is an issue with this project (the MariaDB4j Java library).
M.


importScripts files are not generating in build

Hi, I am trying to implement a push event listener by adding a custom script using workbox.importScripts in vitePWA() plugin. I works fine on development but when I build the code and preview it, it gives an error

i just want to know, how to generate this push-sw.js file in build

Try moving it to public folder, should work in both, dev and build

I have tried to move it to the public folder and it's now generating in the build, but the sw.js file looking for public/push-sw.js while in the build the push-sw.js is located in the same folder. And it's again giving the import error


transformation of E (ensemble) or F (forecast) axis gives spurious missing values

Reported by andrew wittenberg on 19 Dec 2012 00:06 UTC
Computing the variance along an E- or F-dimension leads to missing values along an orthogonal dimension:
 	NOAA/PMEL TMAP
 	FERRET v6.83 (beta)
 	Linux 2.6.32-279.5.1.el6.x86_64 64-bit - 08/22/12
 	18-Dec-12 18:53

yes? def ax/e=1:3:1 e_ax
yes? def ax/t=1:10:1 t_ax
yes? let a = t[+ _e[ge=e_ax](gt=t_ax])
yes? list a[            VARIABLE : Variance of T[GT=T_AX](m=@var]
) + _E[GE=E_AX]
             SUBSET   : 10 points (T)
             E        : 0.5 to 3.5 (variance)
 1    /  1:  0.6667
 2    /  2:  0.6667
 3    /  3:  0.6667
 4    /  4:    ....
 5    /  5:    ....
 6    /  6:    ....
 7    /  7:    ....
 8    /  8:    ....
 9    /  9:    ....
 10   / 10:    ....

Only the first 3 values are valid, which interestingly is exactly the same number of coordinates that we had along the E axis.  The same occurs if we try this for the F axis.  Is the wrong axis length used somewhere inside the Ferret code?
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2014

Comment by ansley.b.manke on 19 Dec 2012 00:15 UTC
This looks to be fixed in v6.84. There were a few fixes in handling the new dimensions in grids.
        NOAA/PMEL TMAP
        FERRET v6.84
        Linux 2.6.32-279.14.1.el6.x86_64 64-bit - 12/18/12
        18-Dec-12 16:11

yes? def axis/t=1:10:1 t_ax
yes? def axis/e=1:3:1 e_ax
yes? let b = t[+_e[ge=e_ax](gt=t_ax])
yes? list b[            VARIABLE : Variance of T[GT=T_AX](m=@var]
) +_E[GE=E_AX]
             SUBSET   : 10 points (T)
             E        : 0.5 to 3.5 (variance)
 1    /  1:  0.6667
 2    /  2:  0.6667
 3    /  3:  0.6667
 4    /  4:  0.6667
 5    /  5:  0.6667
 6    /  6:  0.6667
 7    /  7:  0.6667
 8    /  8:  0.6667
 9    /  9:  0.6667
 10   / 10:  0.6667

Comment by ansley.b.manke on 20 Dec 2012 20:37 UTC
just to complete the report, this was a bug in implementing 6D Ferret, only in the code for @VAR.  So not anything complex with grids, but just a coding bug which has been fixed.


Test coverage and remove cp as dep

@bodepd I know this change set doesn't introduce the site_lib directory, but I'm having trouble understanding it.  I've never seen the need for site_lib in a module and the only reference I see to it is this:
spec/spec_helper.rb
8:$LOAD_PATH.unshift("#{dir}/../site_lib")

Could you briefly explain why site_lib is being used instead of the lib directory?

@bodepd I'm also having a hard time understanding the "big picture" for this change.  I've read all the commit messages, but I don't have a sense of why this change set is important.  (That's not to say I think it's not important, just that I don't understand.)
As a concrete example:

commit ba004aa664dabf50ff3ee1807093bbe03706ad64
Author: Dan Bode<EMAIL_ADDRESS>Date:   Thu Dec 15 21:12:38 2011 -0800

    (#11438) Inline code from CP for connection options

    Previously, the connection options were being
    retrieved by calling the add_classify_options
    method of the cloud proivisioner method. This added
    an extra option (node-group).

    This commit inlines the relevent options from cloud
    provisioner.

Is the extra option named node-group a problem?  It appears this commit copies and pastes the options from cloud provisioner, but I don't understand why.  Is there some problem you've run into where this is too tightly coupled with cloud provisioner or something?  If so, what is the problem and how do these changes resolve the problem?
Another example:
commit a8d53028c883d4533f266824b3c41541e688d260
Author: Dan Bode<EMAIL_ADDRESS>Date:   Thu Dec 15 21:07:11 2011 -0800

    (#11438) Inline http methods from cloud provisioner

    Inlines the http_request and
    handle_json_response methods from cloud provisioner.

I'm still not sure why...  What led you to inline these methods?  See what I'm getting at with these comments?
  It's not a huge omission, but really the big picture would help a lot.  I have a pretty clear picture of what you're changing and the commits are logically separated out nicely, I'm just not sure why these patches should to be applied.
If you could amend the commit messages to help with the why that I think it'll be ready to merge.  The what is described pretty well already.

reason for site_lib:

http://projects.puppetlabs.com/issues/10956
since this is a module, everything in the lib directory may be plugin synced. I moved the code from lib to site_lib to avoid the auto-plugin sync b/c I did not need the code to reside on all of the clients.
The fact that the code was pluginsynced WAS also causing things to break on the client when cloud provisioner was a dependency of the code(which has been updated by this pull request). This is b/c the pluginsync was causing the code to be evaluated which was triggering the cloudprovisioner require statement which would fail if cloud provisioner was not installed on each of the clients. It basically introduced a requirement that cloud provisioner be installed on all nodes even though I didn't need the face to be synchronized. The introduction of site_lib may be a little confusing and may need to be discussed a little further, but it easily solved my issues.
I renamed the lib directory to be site_lib so that it would not be pluginsynced.

I believe that these commit messages together with the ticket number they refer to should adequately explain the motivation for this change:
http://projects.puppetlabs.com/issues/11438

@bodepd Unfortunately, it's not good enough to have the commit message in combination with the ticket number.  The commit message itself needs to say the "what" and the "why" (at a high level) without requiring the reader to go read the ticket.
Are you willing to amend the commits with a single sentence to cover the "why?"  The end of the sentence can refer the reader to the ticket for more detailed information if you'd like.

@bodepd Is this module meant for internal only consumption, or is it meant for public use?
It seems to me site_lib is basically wrong since the Faces framework is actually designed and documented to use the module lib directory.
I ask because site_lib is probably fine for internal hacks, but if we're expecting end users to take advantage of this module then we shouldn't use site_lib.


[11.x] feat: add virtual methods to SoftDeletes trait

Hello!
This PR adds the other SoftDelete macros to the trait as virtual methods.
Thanks!

Thank you sir!


Add feature: New Scroll Bar added. Completed the assign issue #34 done.

I have completed the issue that is assigned to me #34 of this project and after changes it looks like
https://github.com/user-attachments/assets/dd3929ed-9786-4620-81e1-6b5250949777

great job!! do let me know if you would like to work on more frontend issues


bosh-softlayer-cpi-release with pooling support

Changed the specs of jobs to support softlayer pooling
@maximilien  @mattcui

Hey JQ, please squash commits next time. All these intermediary commits are noisy... they add no value.


[TC-SDOCONC-1.1] SDK has to be implemented for Sulfur Dioxide Concentration Measurement Cluster

All-clusters-app has to be enabled with below mentioned commands :

[ ]  generated-command-list
[ ]  accepted-command-list
[ ]  event-list
[ ]  attribute-list
[ ]  feature-map
[ ]  cluster-revision

Bug prevalence
Whenever I try to read all these Global attributes
GitHub hash of the SDK that was being used
7ae5919a046a18c7e60537aff814977ee424b9cf - Master
Platform
raspi
Platform Version(s)
RPI - 4, 8GB RAM

Will be fixed by https://github.com/project-chip/connectedhomeip/issues/27662

Will be fixed by https://github.com/project-chip/connectedhomeip/issues/27662


Update all dependencies and fix HTML sanitization escape

This PR fixes issues #7, #18, #19, #21, #26, #27, and #30, and partially addresses issue #16.  It subsumes PRs #12, #14, #17, #20, #29, #31, #33, and #36. See individual commits for explanation of the changes.
PRs #13 and #34 may still have worthwhile changes, I haven't looked at them very hard.

Pull request #41 superseeds this one.
@zackw your pull request have been sleeping for nearly two years. Should there be an official fork ? What is your opinion ?


Server Exception in MemCache construct package

In Package v.4.3.2, the MemCache construct has an error:
Uncaught Exception: Please added servers in ./vendor/koolreport/cache/MemCache.php:29
$ttl = Utility::get($settings,"ttl",5*60);
       $servers = Utility::get($servers,"servers"); // <---- calls $server instead $settings
        if($servers==null)
        {
            throw new \Exception("Please added servers");
        }

Yes, thank you for letting us know. We have applied the fixes to the MemCache in koolreport/cache package. It will be releases in next version together with koolreport.


chore: Add v1 APIs and Conversion webhooks for v0.37.x

Fixes #N/A
Description

Add v1 APIs and the conversion webhooks
This is a copy and from main to release a patch version of 0.37

How was this change tested?

make presubmit

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

263 of 719 (36.58%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-4.4%) to 78.081%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1/ec2nodeclass_defaults.go
0
1
0.0%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/webhooks/webhooks.go
0
6
0.0%

pkg/apis/v1/ec2nodeclass_status.go
0
14
0.0%

pkg/apis/v1/ec2nodeclass.go
37
60
61.67%

pkg/apis/v1/zz_generated.deepcopy.go
0
410
0.0%

Totals

Change from base Build<PHONE_NUMBER>7:
-4.4%

Covered Lines:
5810

Relevant Lines:
7441

💛  - Coveralls


Cannot read property 'interlace' of undefined

Oh my god, the only issue I can find with the same problem and it's not answered. FML
TypeError: Cannot read property 'interlace' of undefined
    at module.exports (/home/debian/MOO/moobot/9b9t/node_modules/@jimp/png/node_modules/pngjs/lib/parser-sync.js:79:16)
    at Object.exports.read [as image/png] (/home/debian/MOO/moobot/9b9t/node_modules/@jimp/png/node_modules/pngjs/lib/png-sync.js:10:10)
    at Jimp.parseBitmap (/home/debian/MOO/moobot/9b9t/node_modules/@jimp/core/dist/utils/image-bitmap.js:196:53)
    at Jimp.parseBitmap (/home/debian/MOO/moobot/9b9t/node_modules/@jimp/core/dist/index.js:431:32)
    at /home/debian/MOO/moobot/9b9t/node_modules/@jimp/core/dist/index.js:373:15
    at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:63:3) {
  methodName: 'constructor'
}

Oh my god, the only issue I can find with the same problem and it's not answered. FML
TypeError: Cannot read property 'interlace' of undefined
    at module.exports (/home/debian/MOO/moobot/9b9t/node_modules/@jimp/png/node_modules/pngjs/lib/parser-sync.js:79:16)
    at Object.exports.read [as image/png] (/home/debian/MOO/moobot/9b9t/node_modules/@jimp/png/node_modules/pngjs/lib/png-sync.js:10:10)
    at Jimp.parseBitmap (/home/debian/MOO/moobot/9b9t/node_modules/@jimp/core/dist/utils/image-bitmap.js:196:53)
    at Jimp.parseBitmap (/home/debian/MOO/moobot/9b9t/node_modules/@jimp/core/dist/index.js:431:32)
    at /home/debian/MOO/moobot/9b9t/node_modules/@jimp/core/dist/index.js:373:15
    at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:63:3) {
  methodName: 'constructor'
}

It was because I was reading the file while it was being written.

It was because I was reading the file while it was being written.


Build for aarch64-apple-darwin (arm64, apple silicon/M1)

Waiting for Rust tier 1 support: https://github.com/rust-lang/rust/issues/73908

See also https://aws.amazon.com/about-aws/whats-new/2021/12/amazon-ec2-m1-mac-instances-macos/


Add initial controller logic

@mfojtik rebased. ptal.

@sttts the basic skeleton looks good, can you replace the SSCS in types/vars across the code?

I think this is a good block to build on top of
/lgtm


feat: Support with_row_id options for spark connector

Java only has long type for 86 bit interge. And Spark arrow reader can't read the _rowid column for uint64 type.
So wrap the array batch stream converting the uint64 into int64 and change the schema of _rowid from uint64 into int64

Codecov Report
Attention: Patch coverage is 0% with 71 lines in your changes missing coverage. Please review.

Project coverage is 77.24%. Comparing base (ceaf49c) to head (45f91ec).

Files with missing lines
Patch %
Lines

rust/lance-io/src/ffi.rs
0.00%
59 Missing :warning:

java/core/lance-jni/src/blocking_scanner.rs
0.00%
12 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   77.31%   77.24%   -0.07%
==========================================
  Files         240      240
  Lines       79322    79391      +69
  Branches    79322    79391      +69
==========================================
  Hits        61326    61326
- Misses      14821    14893      +72
+ Partials     3175     3172       -3

Flag
Coverage Δ

unittests
77.24% <0.00%> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@LuQQiu I plan to convert the type like this.

@SaintBacchus Can we support generic type conversion?
like convert all UInt64 in rust to BigInt/Long for java? no special handling for with_row_id, but more generic how should we process UInt64 in java/spark stack


update docker-registry image

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/test pre-main-third-party-images-protecode-guard


Completing C# inside single line @{} doesn't complete

When doing: @{th} and completing this the is is never inserted.
https://i.imgur.com/QrgltyC.gifv

This seems to be because we don't generate C# place holders in the middle of a single line @{}
VSTS Issue: https://devdiv.visualstudio.com/DevDiv/Project Cascade/_workitems/edit/602933
/cc @ToddGrun

dc76027a7affd0a9fa4bac8bbaf07ed1effdf687

Confirmed this is indeed fixed in latest VSMac. Thanks!


Fix active and focus states on register button on summit page

The active and focus states for the register button are set to default. Needs updating to hover state and remove outline.
http://blockstack.org/summit

Adjust the .less .button-variant() mixin to cover variable state adjustments

Deprecated. As item will be resolved with #63


[TIMOB-18540] Tooling: Update versions of node.js in use on Travis

TIMOB-18540

@jhaynie Appears there is an issue with Node 12 here. Should we take a look?

if you can great, otherwise me or @alasdairhurst can fix it.

@muhammaddadu can you see if you can figure out the issue here?

While running the tests i came across the same issue as this: https://jira.appcelerator.org/browse/API-445
Looks like we were right about the logger not closing the file stream when exiting causing issues on Windows.
Removing this from the tests causes all tests to pass with Windows & node 0.12.
Also confirmed working on OSX node 0.12
Is there any way we can re-run the build?

This is no longer necessary.