Deserialization of unknown enum value

Hello!
Whilst testing we found a regression after switching from nswag -> kiota, we used to get a Newtonsoft.Json.JsonSerializationException when we deserialized an entity with an unknown enum value, it'd give us an error like Error converting value "EXAMPLE_ENUM_STRING_VALUE" to type 'System.Nullable`1[Example.Project.Models.ExampleEnum]'..
With kiota, the JsonParseNode returns null if it can't parse it, I know we can implement our own IParseNode and IParseNodeFactory for this, however it does seem wastefulhaving to have a copy of the entire JsonParseNode class for what is effectively a one line change, and it means that  we'll need to keep our implementation up to date with changes made here if we want to keep it as close to the default implementation as possible.
Currently we've made a change to GetEnumValue as below:
{
	var rawValue = _jsonNode.GetString();
	if(string.IsNullOrEmpty(rawValue)) return null;

	var type = typeof(T);
	rawValue = ToEnumRawName<T>(rawValue!);
	if(type.GetCustomAttributes<FlagsAttribute>().Any())
	{
		return (T)(object)rawValue!
			.Split(',')
			.Select(x => Enum.TryParse<T>(x, true, out var result) ? result : (T?)null)
			.Where(x => !x.Equals(null))
			.Select(x => (int)(object)x!)
			.Sum();
	}
	else
-		return Enum.TryParse<T>(rawValue, true,out var result) ? result : null;
+		return Enum.TryParse<T>(rawValue, true,out var result) ? result :
+				throw new ArgumentOutOfRangeException(type.FullName, rawValue, "Unable to parse enum value");
}

Reasoning for this is we'd like to catch and log when we receive a new enum value as sometimes third parties do add new ones without telling us and we need to be aware.
What are your thoughts on potential solutions to adding something official to be able to handle cases like this?

Hi @HaydnDias
Thanks for using kiota and for raising this.
This is something where we have a bit of an implementation drift I believe.
Upon receiving an unknown value, the following languages will return null

[java](https://github.com/microsoftgraph/msgraph-sdk-java/blob/3017cbe32a2a3b1934916b094bbc3e6a244c6d04/src/main/java/com/microsoft/graph/generated/models/BodyType.java#L220
dotnet (as demonstrated above)
typescript

where-as the following languages will throw:

python
php
go

We could see two different ways: it's better to quietly fail as it doesn't break the application right away, but it might derail its logic. Or no, it's better to fail loudly so people know they need to update their code.
Before we take any action on that (alignment will be required either way), I'd like @darrelmiller opinion on the matter.

@baywet Hey! Yeah we're adopting Kiota for one of our core libraries, we actually found some other concerns, I think it is likely the case that the provided JsonParseNode implentation just doesn't suit our needs.
I agree there are two different ways, could it be that we have two JsonParseNode implementations in this package, or potentially more ways to configure behaviour.
For us we want loud sirens for when something fails to deserialize, we've modified your provided JsonParseNode implementation here https://github.com/CapitalOnTap/marqeta-csharp-core-sdk/blob/9cecf3065ae4649c96ae0b4c25c85d8de50a3436/Marqeta.Core.Sdk/Serialization/Json/CustomJsonParseNode.cs
Some notable changes are, removing safety around JsonNode.ValueKind, as we would rather the deserializer throw an exception, we added a try/catch around the fieldDeserializer.Invoke in the AssignFieldValues method, which then throws a descriptive exception, and the exception throwin for non-parsed Enum, so far this is working for us, and the information provided when something goes wrong is invaluable.
It's not a final, we have more testing to do, but I think it's fair to say we want a stricter parser, with allowances for some things like string -> number.
Appreciate all the work you do on Kiota, I forsee us using it heavily and hope we get time to contribute back with PRs rather than just issues!

a) Yes we need to align across languages
b) One of the reasons we isolated serialization into separate packages is so that Kiota users can create their own serialization libraries if necessary.
c) Having said that, I think if we can relax the initial rules on reading the value to allow nulls and then support a secondary set of rules that can be run after parsing to do additional checks.
Something like this:
Address.Rules = new[]
{
    (address) =>  address.Street == null ? throw new ArgumentException("Street is required") : null,
    (address) => address.Type == null ? throw new ArgumentException("Type is required") : null,
};

Transferring issue as part of https://github.com/microsoft/kiota-abstractions-dotnet/issues/238


LeaderBoard module translated from the Java as is.

Thankyou for this! You've translated from the Java, and this leads to a problem in that the Java version has a serious bug, that I havn't got around to addressing yet! In the Leaderboard class, "driver_rankings" method will fail spectacularly when two drivers have the same number of points. Could you take a look at the Scala or Python versions? Neither have this problem, and will probably translate much better to idiomatic Ruby.


switch to solidity-parser-diligence to support Solidity 0.6

Switching to solidity-parser-diligence adds support for Solidity 0.6, see #47 - there are some newer pieces of Solidity syntax we will be able to cover when the parser is updated further.

FWIW, I tested this with a set of Solidity 0.6 contracts I have (including some imports from OpenZeppelin 3.0 beta), and it works fine when reverting a {value: ...} construct I have in there (which is not supported, see https://github.com/ConsenSys/solidity-parser-antlr/issues/14 for upstream issue)

Thanks for this PR @KaiRo-at.
I've just released a new version that uses @solidity-parser/parser. Sorry I haven't seen this before doing that.


How to style correctly

I'd like to use my own svg for the button but when I add any children as suggested in the docs the button looks strange, e.g. using the code below the button gets positioned somewhere off on the lefthand side of the screen and is not fading in/out nicely anymore:
<ScrollUpButton>
  <img src="foo.svg" />
</ScrollUpButton>

Any hints on how to customize the plugin correctly would be appreciated! Do I really need to recreate the positioning/transitions?

ok sorry, i didn't see the elaborate instructions here https://react-scroll-up-button.com :)


Si si si

Geode Issue

[X] I confirm that this bug is NOT related to a mod but directly to Geode Loader itself.

Platform
MacOS
SDK commit
Si
Geode Version
Si
Mods Installed
Si ok
Expected Behavior
Si ok
Actual Behavior
Si ok
Steps to Reproduce
Si
Additional Information
Si

Mejor

Me jor juego


Automate the ignite version realese copy

Describe the bug
Currently we're manually updating the copy whenever there's a new ignite release. Let's automate it!

Closed by #135


Api context provider

Api context providers for Polkadot and Web3
@plasm/types update
chain token decimals

Thank you for your work! I have pointed out some parts that I think could be improved on for the application. Please give it a look and let me know what you think.

Thank you for the code review. I think that you made a good points with your comments. I will make changes according to yout comments


Upgrade to Gradle 2.3, fix zulip/zulip-android#467.

We needed to upgrade to Gradle 2.3 for better functionality.

Automated message from Dropbox CLA bot
@maxymilianz, it looks like you've already signed the Dropbox CLA. Thanks!

Some checks failed, but before I changed anything in the code, they were failing too. Anybody can help?

the project build is failing

@kunall17 I know, but isn't it normal? I mean, I've revoked all the changes I made and the ckecks still fail on my computer.


Web App login alert typo

login alert's '&' is not escaped correctly?, displays as '&'

was using html code, which doesn't work so well in html, uses \u0026 now.


⚠ Bofrost.be has degraded performance

In c372964, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1251 ms

Resolved: Bofrost.be performance has improved in fd31449 after 6 minutes.


Duplicate data points showing up in pf_best in assignment 9

Hello Prof. Zhe,
Sometimes when I run A9.py, I get duplicate data points in pf_best, as mentioned by another student during the lecture today. The result of that is I get duplicate precision and recall values as shown below:
[array([0.95041809, 0.96006597]), array([0.95041809, 0.96006597]), array([0.95041809, 0.96006597]), array([0.95041809, 0.96006597]), array([0.95041809, 0.96006597]), array([0.95041809, 0.96006597]), array([0.95041809, 0.96006597]), array([0.95041809, 0.96006597]), array([0.95041809, 0.96006597]), array([0.95041809, 0.96006597])]
[0.96479161]

If we check for duplicate points before adding into pf_best, this doesn't occur.
Origninal code:
if not_dominated:
    to_add.append(j)
    modified = True

Suggestion:
if not_dominated and pf_new[j] not in pf_best:
    to_add.append(j)
    modified = True

Does this suggestion look good?
Thank you

If you do this:
forall y in pf_best; self.is_better(y, x) == -1

The duplicate points should not be added into pf_best since
is_better(a,b) returns 0 if a==b

Thank you Prof. Zhe. I had misinterpreted that entire comment:
# If one point x in pf_new is not dominated by any point y in pf_best (and does not exist in pf_best)
# (forall y in pf_best; self.is_better(y, x) == -1)
# add that point x to pf_best

Only when x is not dominated by even a single y, then we should add x to pf_best.


Repo Overhaul

organized files
sorted js files with leading numbers in file name
light styling on index.html
standard.js formatting
renderAlbums changed to renderBands
render2Rectangles and renderEllipses added
renderSquare and renderCircles pre-solved as helpful guides
IFFE wrappers on all code, no global declarations (side note... i have been showing students that they can access information about their variables using the console... IFFE-wrapping blows that up. (i know... they can log and assert inline))

still no readme content


If a file with multiple faces is fed to the algo it only detects one face

Description
https://images.newscientist.com/wp-content/uploads/2022/02/14174128/PRI_223554170.jpg?crop=4:3,smart&width=1200&height=900&upscale=true
only one face gets highlighted when given the above image
Steps to reproduce
just paste and submit
Screenshots

Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response

this one's been resolved in #10


[Staging Updates] Update Icons

Please update settings and eye icons.

@nicoletting
please upload the latest updated icons.

please download here:
https://drive.google.com/drive/folders/1WmC0M6sCQM2SjyZVxjfcGPNrQmBKTKy5?usp=sharing


fix(schedules): remove auto assigned opening prayer from schedules history

:tada: This PR is included in version 2.76.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


NCP/Spinel Add new spinel property to test assert

This commit adds SPINEL_PROP_DEBUG_TEST_ASSERT as a new read-only
spinel property and also adds its associated get handler.
Getting this property will cause an assert on the NCP. This is
intended as method for testing the the assert functionality of
underlying platform.

Codecov Report

Merging #1389 into master will increase coverage by 0.19%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1389      +/-   ##
==========================================
+ Coverage   69.16%   69.35%   +0.19%
==========================================
  Files         171      171
  Lines       26962    26965       +3
  Branches     3395     3395
==========================================
+ Hits        18647    18702      +55
+ Misses       6895     6841      -54
- Partials     1420     1422       +2

Impacted Files
Coverage Δ

src/ncp/spinel.c
77.6% <ø> (ø)
:white_check_mark:

src/ncp/ncp_base.cpp
40.09% <ø> (+3.06%)
:white_check_mark:

src/core/mac/mac.cpp
79.81% <ø> (-0.46%)
:x:

src/core/thread/mle_router.cpp
79.63% <ø> (-0.11%)
:x:

src/core/thread/mle.cpp
80.53% <ø> (+0.07%)
:white_check_mark:

src/core/thread/mesh_forwarder.cpp
80.79% <ø> (+0.11%)
:white_check_mark:

third_party/mbedtls/repo/library/bignum.c
51.09% <ø> (+0.13%)
:white_check_mark:

src/core/thread/network_data_leader_ftd.cpp
68.47% <ø> (+0.47%)
:white_check_mark:

src/core/openthread.cpp
46.15% <ø> (+0.99%)
:white_check_mark:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f35cdb...612e983. Read the comment docs.

Should this property be documented here?

Yes. Indeed... I was planning to do this in a seperate PR...We probably need to add a new section for debug related properties....

@darconeous asked for docs to be updated along with the implementation in #1371.  We should have a consistent policy.

Fair point... will update the md files in this PR, but I think we should add the (auto-generated) xml and txt files (for draft-spinel-protocol) separately in another PR/commit.... I think adding them in same commit makes the diff unnecessarily large and sort of un-readable...
I think this would be a good policy to follow:
We should always update/edit the md files  in the same commit that changes/introduces the spinel related code changes but  the draft-spinel-protocol (xml,txt files) change should preferably go in separate (documentation only) commit (afterwards)....
@jwhui, @darconeous  thoughts? suggestions?

In #1371, @darconeous indicated keeping the md files in sync with the implementation, but not rendering the txt and html files.  But I defer to @darconeous, since he is the maintainer of the spinel doc.

In the new pushed commit, added the documentation change (md files only) for spinel-draft.

Corresponding PR in wpantund: https://github.com/openthread/wpantund/pull/135


EM: Tiled service publishing as hosted service is failing

@conklinbd I did one last test for hosted tile service publishing on the nsec portal and it failed also...

map doc and data: \mrhyde\public\Jess\OPSServer

@jessnoo I tried publishing the same tiled service and succeeded.
after copying your zip file I changed 3 things.

The data source was broken so I reset the data source and change the map to relative paths (probably not the cause)
-I change the feature class name to all lower case (possibly the cause)
-I changed the field name for Evacuation Zones (the symbology field) to all lower case (probably the cause).

After that I published to the server. I didn't know what scales to caches so I only cached a couple of levels  but it looks like it works.
https://nsec.esri.com/arcgis/home/item.html?id=8faa8be621c44fe1b7a70a822469fad4
Let me know if you want to try these steps yourself, or if you just want me to reassign the item I created back to you.

as discussed @conklinbd will publish our tiled services on the GIS Server.


Update CMakeLists.txt to add OpenMPDialect

Jenkins Linux ppc64le Build #11709 [push] Update CMakeLists.txt to... started at 16:43

Jenkins Linux s390x Build #12716 [push] Update CMakeLists.txt to... started at 16:33

Jenkins Linux amd64 Build #12693 [push] Update CMakeLists.txt to... started at 15:33

Jenkins Linux amd64 Build #12693 [push] Update CMakeLists.txt to... passed after 1 hr 10 min

Jenkins Linux s390x Build #12716 [push] Update CMakeLists.txt to... aborted after 1 hr 32 min

Jenkins Linux ppc64le Build #11709 [push] Update CMakeLists.txt to... aborted after 1 hr 34 min


Allow users to subscribe to badge state changes

In the (further future), allow users to 'subscribe' to projects so that they are notified when the badge changes state.  I don't think we need that in the nearer term.

Note that this is related to #132.  We already send notifications to the Linux Foundation when a badge status changes.

Note that we now send emails on every state change to the project owner. That may be enough.

It could be beneficial to notify all who have edit rights to a badge entry? Sometimes the project owner may be LF staff, with TSC and Security Chairs provided edit access? (captured as a field under Basics > Other)


React capstone project: Metrics webapp - Deezer Music App

In this pull request, I have implemented the following:

Created a single-page application with React and Redux
Used a get request to fetch data from an API and then stored it in the Redux store
Used a Filter stateless component to filter the received data.
All pages have a unique route as can be seen on the address bar.

Here is the link to the short video explaining the features of the app.
And here is the link to the live demo
Thank you

Thank you for the feedback.


docs: update workflow badge

📦 Published PR as canary version: 0.0.1-canary.3.3745af2148c8ebf6d32b85221ee9a6f14ececa88.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v0.0.5 :rocket:


No audio

When i run the game, there is no sound.I try to use the update patch.txt ,but it is no use.

there's a patch exe on the server that fixed this problem.

thanks a lot.i tried to upgrade the sound card drive,and i succeed.


Introducing the do ... catch ... end structure

This PR is a first step in trying to handle exceptions in Nit, replacing the behaviour of abort if it happens within a do ... catch ... end.
In the compiler, setjmp() et longjmp() are used to jump directly from the abort to the nearest catch bloc.

This is nice code. and a nice PR.
+1 once you fixed the tests

+1


Update istorageitemextraproperties_retrievepropertiesasync_507906171.md

Added a note that null can be passed to retrieve all properties.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


create dynamic play area for bot

Create extra class for bot

This also addresses the issue of stacking cards

Done with menu screen issue


flow is ignored within switch statements or === if's

ignored: (undesired case....)

same code within if statement (==): (this is what i expected)

flowconfig attached (default file that was generated using react-native init)
also, using a project flow-bin package (not global)
flowconfig.txt

ok, it something to do with how the action's flowtype is defined

cause when i change it to

it works fine.
i was following the example in https://flow.org/en/docs/frameworks/redux/
which clearly shows what you can use a string value on the type def.


Multiline function arguments with trailing comma - SyntaxError: Unexpected token )

When I use a global install of "json-graphql-server" has it, I encounter an error because of trailing commas in multiline function arguments.
My version of Node is the following: v7.1.0. According to this thread, trailing comma support will be enabled by default in V8.
For the moment, I'm able to use the server with this command.
node --harmony_trailing_commas /usr/lib/node_modules/json-graphql-server/bin/json-graphql-server.js
Maybe we should remove them and adapt prettier rules (trailingComma) according to that ?
Anyway, thanks for this awesome work ! :+1:

I agree, would you mind opening a PR changing the prettier rule and updating the affected files?

Yes, the following PR will fix it.
https://github.com/marmelab/json-graphql-server/pull/21/files

Fixed by #21


Update README

As a developer
I need to keep an updated README file for the shopcarts service repository
So that users understand how to set up, run, and contribute to the project
Details and Assumptions

The README will follow standard conventions and include necessary sections such as installation and usage
The README is an evolving file, and needs to be updated as features are built each sprint

Acceptance Criteria
Given a new README.md file in the root of the repository
When the README file is viewed
Then it should contain the following sections:
 - Project Title
 - Description
 - Installation
 - Usage
 - API Documentation
 - Testing

[Reminder] File tree needs re-list. models/*.py shoule be added.


No DB Prefix in key name, When migrate with db prefix.

Laravel Version: 5.5.x, 5.6.x
PHP Version: 7.1.13
Database Driver & Version: MySQL 5.7.20

Description:
In case of used prefix database.
When you run migrate, If use look at key name in indexs and foreign key. It has no prefix in key_name or name.
It will be a problem when you use same table structure in same database with not same prefix.

Steps To Reproduce:
It should have prefix in key_name and name.

looks like a duplication of #7889


Fix error detail type resolving issue new parser

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes https://github.com/ballerina-platform/ballerina-lang/issues/24715
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@shehan360 Please check whether this fixes the anonymous errors we talked about.

Merging this PR should Fix #25205

@MaryamZi this noType is set for scenario like below
public type NewPostDefinedError distinct PostDefinedError; // not resolved set later
public type PostDefinedError error<ErrorData>; // ErrorData not resolved set later

public type ErrorData record {|
    string code;
|};


*: fix add merge region api

What problem does this PR solve?
Now the merge region via pd-ctl not work.
What is changed and how it works?
Fix the logic.
Check List
Tests

Unit test

/run-integration-ddl-test


issue when running consoleplus

https://gyazo.com/1742e09d5f2400f3aef4152b04617015
that is what happens, i have tried to change the ports. Doesnt work.

How do i change the port?

.-.


Chapter 01 - Data.ipynb error accessing XLSX.DataTable (G)

Error while executing G[1]
MethodError: no method matching getindex(::XLSX.DataTable, ::Int64)
Stacktrace:
[1] top-level scope
@ In[42]:1
or accesing G in with all instructions
Help needed !!!
Thank you !!!

The output of XLSX.readtable() is no longer a tuple but a class. According to XLSX.jl docs ([https://felipenoris.github.io/XLSX.jl/stable/api/#XLSX.readtable]) one should use this function to create DataFrame with DataFrame.jl, which makes much more sense.
For example:
G = DataFrame(XLSX.readtable("data/zillow_data_download_april2020.xlsx","Sale_counts_city"))
Hope it helps.

Thank You !!! It works !!!
El dom, 30 abr 2023 a las 22:04, cr00k @.***>)
escribió:

The output of XLSX.readtable() is no longer a tuple but a class. According
to XLSX.jl docs ([
https://felipenoris.github.io/XLSX.jl/stable/api/#XLSX.readtable]) one
should use this function to create DataFrame with DataFrame.jl, which makes
much more sense.
For example:
G =
DataFrame(XLSX.readtable("data/zillow_data_download_april2020.xlsx","Sale_counts_city"))
Hope it helps.
—
Reply to this email directly, view it on GitHub
https://github.com/JuliaAcademy/DataScience/issues/49#issuecomment-1529128056,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3ZRCDWFJFW62AOSYCGJP63XD3AVHANCNFSM6AAAAAAVU65MKI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
 Pedro Rodriguez Cervera

From Raw Data to Action S.L.*

web : www.rawdata2action.com
phone: +34 690264566


[Spike] Check possibility of using Elasticsearch Curator with Opendistro for Elasticsearch

Is your feature request related to a problem? Please describe.
After moving to Opendistro for Elasticsearch, Elasticsearch curator stopped working since there is a different way of authentication.
Describe the solution you'd like
Describe configuration of using Elasticsearch Curator with Opendistro
Additional context
See this article.

DoD checklist

[ ] Changelog updated
[ ] COMPONENTS.md updated / doesn't need to be updated
[ ] Feature has automated tests
[ ] Automated tests passed (QA pipelines)

[ ] apply
[ ] upgrade

[ ] Idempotency tested
[ ] Documentation added / updated / doesn't need to be updated
[ ] All conversations in PR resolved
[ ] Solution meets requirements and is done according to design doc
[ ] Usage compliant with license

What I see Index Management for ODFE was created to replace Curator see or RFC
So the aim of this spike is to check possibilities to continue using Curator and describe how complex it would be. This will help us compare both solutions later on.

As Open Distro for Elasticsearch is using basic authentication, we can use this with already implemented in Elasticsearch Curator authentication. On Epiphany side this would require to create proper Open Distro role with access to the given indexes with password authentication.
Thing to check is probably how to secure passwords stored inside Curator configuration.
More you can find under links below:
https://www.elastic.co/guide/en/elasticsearch/client/curator/current/configfile.html#username
https://discuss.opendistrocommunity.dev/t/curator-set-up-with-keys-and-certificates/1368

This should probably also solve #2153

This task is a spike for the task: #2423


Laravel Mix - Hot file issue

Laravel Version: 5.8.32
PHP Version: 7.3.3
Database Driver & Version:

Description:
When using Laravel mix to load assets, the URL generated includes the Hot reload domain and port. Even when not using hot reload.
<link href="{{ mix('/css/app.css') }}" rel="stylesheet"/>
Returns the following
<link href="http://localhost:1022//css/app.css" rel="stylesheet"/>
It looks like a file called hot is specified within the public folder, which causes the problem, as this file exists and is created automatically by Laravel and is checked for in Mix.php
The hot file contents are:
http://localhost:1022/
Steps To Reproduce:
Fresh install of Laravel, edit welcome.blade.php and add <link href="{{ mix('/css/app.css') }}" rel="stylesheet"/>
Check the console, an incorrect URL appears and the assets cannot be found at that URL.

You can manually delete the public/hot file and the mix() blade helper should behave normal now.
Usually laravel-mix should auto delete this file, but it may left there for various reasons.
In order to delete the public/hot file properly, we need to add this patch
// Make sure to delete the `hot` file when user press CTRL+C
// https://stackoverflow.com/questions/10021373/what-is-the-windows-equivalent-of-process-onsigint-in-node-js
process.on('SIGINT', () => {
  deleteHotFile();
  process.exit(0);
});

// Detect IDE window close action
process.on('SIGHUP', () => {
  deleteHotFile();
  process.exit(0);
});

The same approach works fine with my custom made webpack solution, laravel-bundler

@jonathanmacgregor Are you sure the Steps To Reproduce just like that? Fresh install of Laravel don't include mix-manifest.json, so if you just write mix('/css/app.css'), it should throw an error, since you haven't run yarn run hot/dev.
Anyway, I think this is not an issue, it's just use don't use it correctly. Since the hot file is still exists, it means you just run yarn run hot before, then you stop it, just open the web without build the assets using yarn run dev.

Apologies, i missed the yarn run dev command off the steps to reproduce. I haven't ever run yarn run hot command before. and it still does it.

@jonathanmacgregor Ah ok if that the case. Ok now, are you sure you don't run yarn run hot before? So why the hot file inside your public folder (It looks like a file called hot is specified within the public folder)? The default Laravel instalation doesn't come with hot file :/

@nmfzone it isn't there when i install. But when i run the application it is created automatically.

@jonathanmacgregor Huh, what do you mean run the application? What laravel-mix version you're using?
Actually I've follow your step, but can't reproduce your issue. Could you try to reproduce again with fresh Laravel installation?

How are you creating a "fresh install"? The first I've ever heard of this happening.
I just installed with "laravel new" and couldn't reproduce.
Probably better to ask around on some of the community support channels.

I've spent the last few hours reinstalling my mac completely. I believe it was an issue with Laravel valet somehow.
It works now without issue.


Error in python3: double free or corruption (fasttop)

Most of the time, it takes 2 or 3 tries, to get the script running. The first error occurs very often.
Python 3.5.0 (default, Sep 14 2016, 20:23:07)
naimo:~ $ sudo python3 /opt/nuimo/examples/test.py
*** Error in `python3': double free or corruption (fasttop): 0x75b016e8 ***

naimo:~ $ sudo python3 /opt/nuimo/examples/test.py
Traceback (most recent call last):
  File "/opt/nuimo/examples/test.py", line 55, in <module>
    main()
  File "/opt/nuimo/examples/test.py", line 27, in main
    nuimo.connect()
  File "/opt/nuimo/examples/nuimo.py", line 194, in connect
    GATTRequester.connect(self, wait=True, channel_type="random")
RuntimeError: Could not update HCI connection: Connection timed out

naimo:~ $ sudo python3 /opt/nuimo/examples/test.py
Displaying LED Matrix...
Waiting for Nuimo events, use CTRL+C to quit

I don't know, if it's related to this problem, but gatttool also has a problem
Connection successful [FA:B7:DD:4A:BE:1B][LE]> characteristics Error: Discover all characteristics failed: Internal application error: I/O [FA:B7:DD:4A:BE:1B][LE]> (gatttool:28989): GLib-CRITICAL **: g_queue_pop_head: assertion 'queue != NULL' failed
or another one
[FA:B7:DD:4A:BE:1B][LE]> connect Attempting to connect to FA:B7:DD:4A:BE:1B Error: connect error: Connection timed out (110)

Unfortunately we can't reproduce this behavior. Given that your gatttool also fail I would assume that the error source might be the same.

pi@raspberrypi:~/nuimo-linux-python $ sudo PYTHONPATH=. python examples/test.py
INFO:nuimo:hci0, started Nuimo discovery
started discovery
INFO:nuimo:hci0, discovered Bluetooth device D8:3F:75:D5:45:0E, {'appearance': 384, 'flags': 6, 'name': 'Nuimo', 'uuids': [6159, 6154]}
INFO:nuimo:hci0, NuimoController(D8:3F:75:D5:45:0E)
added Nuimo: NuimoController(D8:3F:75:D5:45:0E)
finished discovery
INFO:nuimo:D8:3F:75:D5:45:0E: connecting
*** Error in `python': double free or corruption (fasttop): 0x759016a8 ***
pi@raspberrypi:~/nuimo-linux-python $ python --version
Python 2.7.9

I saw similar errors and the problem that it often failed to connect. A workaround which worked well for me is to remove the nuimo.pyc file before each run.

I have the same issue on RPI3 with python2
Sometimes, directly after starting it (probably when the connection is attempted)
*** Error in python': double free or corruption (fasttop): 0x75901710 ***`
Removing the pyc-file did not help it..

I'm closing this issue in favor of the new Nuimo SDK that will be based on BlueZ's D-Bus API


Remove z_qso_training_min_cut and not normalize the flux in preload_qsos.m

Previously I ran the preload_qsos.m in my jibanCat/zestimation branch, but I did not update the version in jibanCat/zoutdata. The updated version is the same as the one in zqsos2. Now we should have a consistent preload_qsos.m across zqsos2 and zestimation.
Modifications:

learn_qso_model.m: remove the "redshifts outside the training region" filter
preload_qsos.m: don't normalize the flux
preload_qsos.m: remove unused available_ind variable
set_parameters.m: min_lambda 1176 -> 910

Makes sense, merged.


I've tried a small program on gmail to login and logout with protractor tool, but unsuccessful as unable to move to password filed

describe('Gmail', function() {
beforeEach(function(){
browser.driver.ignoreSynchronization = true;
});
it('NavGmail', function() {
browser.driver.get('http://gmail.com');
browser.driver.findElement(by.id('Email')).sendKeys('anandrajan143');
browser.driver.findElement(by.id('next')).click();
browser.driver.findElement(by.id('Passwd')).sendKeys('9441415941');
browser.driver.findElement(by.id('signIn')).click();

});
});

Hi there!
Your question is better suited for StackOverflow. Please ask a question there with the 'protractor' tag to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Hi Nick,
Thanks!


eval_refinedet.py RuntimeError: Legacy autograd function with non-static forward method is deprecated. Please use new-style autograd function with static forward method.

E:\anaconda\envs\env_ref\python.exe E:/code/RefineDet.PyTorch-master/eval_refinedet.py
Finished loading model!
Traceback (most recent call last):
File "E:/code/RefineDet.PyTorch-master/eval_refinedet.py", line 441, in
tet_net(args.save_folder, net, args.cuda, dataset,
File "E:/code/RefineDet.PyTorch-master/eval_refinedet.py", line 389, in tet_net
detections = net(x).data
File "E:\anaconda\envs\env_ref\lib\site-packages\torch\nn\modules\module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "E:\code\RefineDet.PyTorch-master\models\refinedet.py", line 141, in forward
output = self.detect(
File "E:\anaconda\envs\env_ref\lib\site-packages\torch\autograd\function.py", line 148, in call
raise RuntimeError(
RuntimeError: Legacy autograd function with non-static forward method is deprecated. Please use new-style autograd function with static forward method. (Example: https://pytorch.org/docs/stable/autograd.html#torch.autograd.Function)
Process finished with exit code 1
I wouldn't like to use pytorch=1.2.0, and there is also '@staticmethod' in my code.
what can I do to solve the problem?

thanks. i've got it.

Hi, I'm using pytorch 1.5.0, may I know how do you solved it, thanks in advance. @sdwangyifan001


About the molecule generation with optimized chemical properties

Hi,
I recently came across your work "Molecular Language Model as Multi-task Generator" and found it very interesting. I have a question regarding molecule generation with optimized chemical properties.
I noticed that in your code, the QED and PlogP features are calculated using RDKit, which relies on SMILES strings as input. However, I was wondering if it is possible to use other chemical features that do not rely on SMILES strings to achieve the generative task.
For example, if I have a dataset with SMILES and their chemical properties (which are experimental data), would it be possible to use your model to achieve the generative task?
I am very interested in exploring this idea further and would appreciate any insights or suggestions you may have. Thank you so much for your time.
Best regards,
Song

Dear Song,
Thank you for your attention to our work! I'm not sure if I understand your meaning correctly, but do you want to input the chemical properties of molecules as features into our model, and use our model to generate new molecules (also represented by these chemical properties)?
If that's the case, I'm sorry to say that our model doesn't support such an operation. Our model is based on a specific chemical language called SELFIES, and only supports input and output in the form of SELFIES. If you want to use chemical properties as features of molecules, you need to train a new model specifically for that feature.
Additionally, it's worth considering that currently, most mainstream uses of molecules involve calculating various properties of SMILES using RDKit or converting them into 2D molecular graphs. If you adopt chemical properties as features of molecules, you may encounter difficulties in determining what molecule you are generating.
Sincerely,
Yin Fang

Dear Yin,
I apologize for the confusion that may have arisen in my previous comment. I think you are correct. If I want to generate/optimize molecules based on certain chemical features, I must train a new model specifically for that feature. But as you said, these additional chemical features may also confuse the model when generating new molecules.
Nonetheless, I think your pre-trained model is still great progress to generate/optimize molecules that are easier to synthesize and more likely to be drug candidates based on logP score and QED. And thank you for your valuable insights.
Sincerely,
Song

Dear Song,
I am glad we are on the same page regarding this. Thank you again for your attention to our work.☺ Please feel free to let me know if you have any further questions.
Best wishes,
Yin Fang


Modified selection

See issue #1, this adresses the first 3 points

EDIT: forgot to post results:
similarity metric with 1 doc > 0.5: 19 topics,
		topic sparsity : 0.4848
		doc sparsity : 0.4383
		perplexity : 209.1635
		distinctness : 0.9586

perplexity metric with 1 doc > 0.5: 11 topics,
		topic sparsity : 0.4520
		doc sparsity : 0.3301
		perplexity : 216.6694
		distinctness : 0.7814

Got 0 topics when taking 1% of docs (~190)
similarity metric with 0.1 % of docs > 0.5 (19 docs): 3 topics,
		topic sparsity : 0.2471
		doc sparsity : 0.1041
		perplexity : 282.3403
		distinctness : 0.3614

perplexity metric with 1 doc > 0.5: 11 topics,
TBA


BNN broadcastable error

Hi,
I would be really glad if I could get some help. Thank you!
I am using Tyxe: Pyro model, according to which I have converted the fc layer to probabilistic layer.  I am facing the broadcastable error :
Value is not broadcastable with batch_shape+event_shape:

 net.fc.2.bias dist      |   4
              value          |   4
           log_prob       |
 likelihood.data dist      |   8
                   value       8 |   4

I am using the categorical likelihood!
Below I have added my model for reference:
model.conv1 = nn.Conv2d(1, 64, kernel_size=7, stride=2, padding=3, bias=False)
model.fc = nn.Sequential(
    nn.Linear(512, 50),
    nn.Tanh(),
    nn.Linear(50, 4)
)
prior = tyxe.priors.IIDPrior(dist.Normal(0, 1))
likelihood = tyxe.likelihoods.Categorical(len(training_Set),event_dim=1)
guide = tyxe.guides.AutoNormal
bnn = tyxe.VariationalBNN(model, prior, likelihood, guide)

lr = 1e-3
optimizer = pyro.optim.Adam({"lr": lr})
device = torch.device("cuda" if torch.cuda.is_available() else "cpu")
training_5epoch = []
pred_params_num_predict_1 = []

with tyxe.poutine.local_reparameterization():
    training_5epoch = bnn.fit(train_loader, optim=optimizer, num_epochs=5, callback=None, num_particles=1, closed_form_kl=True, device=device)
    pred_params_num_predict_1 = bnn.predict(test_images, num_predictions=1, aggregate=True, guide_traces=None)

Hi! I think the issue is that you're giving your Categorical likelihood an event dim, if I remember correctly it should automatically account for the classes on the trailing dimension. Try changing to
likelihood = tyxe.likelihoods.Categorical(len(training_Set))

Hope that solves it! Otherwise I will have to have another look at this in more detail.

Hi,
I tried the way you suggested i.e.
likelihood = tyxe.likelihoods.Categorical(len(training_Set))
still I am getting the below error
Value is not broadcastable with batch_shape+event_shape: {actual_shape} vs {expected_shape}.

                   net.fc.2.bias dist     |   4
                                value     |   4
                             log_prob     |
                 likelihood.data dist   8 |
                                value 8 4 |

Are your target variables one-hot encoded? They need to be label encoded, i.e. 0, 1, 2, 3 for your four classes.

yes, my target variables are one-hot encoded. Below is an example of my tensor target labels and I have given batch_size = 8  in dataloader.
tensor([[0., 0., 1., 0.],
        [1., 0., 0., 0.],
        [1., 0., 0., 0.],
        [1., 0., 0., 0.],
        [1., 0., 0., 0.],
        [0., 0., 1., 0.],
        [1., 0., 0., 0.],
        [1., 0., 0., 0.]])


Consider refactoring ReadRowsParser::HandleChunk()

This function should work in terms of google::cloud::Status instead of grpc::Status. It should also be reduced in cognitive complexity.

Closing, not enough time to fix this.


Async startnode

This ports the startnode script to use asyncio to start multiple nodes in parallel.
It creates an asyncio task for each host that's being asked to start. These tasks can then be run concurrently as long as each yields control while it's waiting for some external I/O to happen. At present it only yields on the call to launch_instance and while sleeping for waiting for VNICs to attach and instances to terminate.
Since this can now send all the launch requests in parallel, it will make the rate limiting issue in #29 worse. To this end, I have also applied a default retry strategy as documented in the Python OCI docs.
The two potential pitfalls of this retry strategy is that it has a limit of 5 retries and a max timeout of 5 minutes for for the request to go through. We'll have to test this on our large 117 node cluster again.
Fixes #29
Fixes #31

We're finding that the default strategy's limit of 5 attempts is too limiting and so we're going to try implementing a custom strategy configuration with this raised to at least 10.

This branch with the retry strategy changes is working on my checkout in my tenancy.

:+1: LGTM
Having tested this a couple of times on a large cluster it seems to be working well.


Cody Gray: Watch sonneriepro.com

Cody Gray requests the watch of the watch_keyword sonneriepro\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by tripleee in Charcoal HQ

sonneriepro\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.


feat(codejam): add the 2019 qualification for java

Hi there,
Here is a solution for one af the codejam event.
Best regards

Thanks! We should contribute to this repo a lot more with these kind of exercises from events :)
Do you know where else can I find exercises of this genre from contests and such?

Looks good @yirrilo. Merging. Thanks for your contribution.

@TheMly, I use to work on Google events like Code Jam, Hashcode and so forth.  Let's have a look !

@mre, thanks for merging.

@yirrilo That's nice! I see there are a lot of these exercises in the archive of those events. Will take a look sure. thanks! ;)


Can't run app/console server:run

Hi Benjamin!
It looks like running app/console server:run does not work as expected. Obviously, it does not load any env variables.. Running php -S ... works fine though.
William

I'm also having this issue when trying to use Dotenv

@kbond solution is to make Dotenv mutable:
Dotenv::makeMutable();


[Question] Error: "Sorry my bot code has an issue" - on sending messages to the bot at the same time from different instances

System Information (Required)

SDK Language: .NET
SDK Version: 3.8.4
Development Environment: Azure App Service and DirectLine

Bot Info

Bot name: ProgMngmentBotPOC

Bot handle: progmntbotpoc

App ID:  bbc75279-a183-4bb3-a148-b9faee0bcac9

Connected channels: Directline

Issue Description
I have hosted my chatbot inside a webapp via DirectLine. Whenever I am trying to run two different instance of this webapp on same or different browser I get "Sorry my bot code has a issue".
It happens only when I try to send messages to both the bots at the same time. I also have noticed that the error message appears on the bot which was 2nd in sending the request.
For Eg : BotA and BotB running at the same time. I send message to BotA and quickly send a message to BotB. Both will process the request and display the result, but "Sorry my bot code has a issue" will appear only on 'BotB'  sent after BotA.
There is no way I can debug this exception. It does not appear in any of the catch blocks in bot. The only log we have is the following :
directline.botframework.com/v3/directline/conversations/A9pzYz8BfNfHl2hXTLdyon/activities:1 POST https://directline.botframework.com/v3/directline/conversations/A9pzYz8BfNfHl2hXTLdyon/activities 502 (Bad Gateway)
{error: {code: "ServiceError", message: "Failed to send activity: bot returned an error"}}
error:{code: "ServiceError", message: "Failed to send activity: bot returned an error"}
code:"ServiceError"
message:"Failed to send activity: bot returned an error"
The bot dashboard reports the error as  There was an error sending this message to your bot: HTTP status code InternalServerError
Its very difficult to figure out the reason based on these few error messages.
What could be the reason for this error? Any way where I can debug this internal error message "Sorry my bot code has an issue" and get the full stacktrace?
Any help or pointers will be highly appreciated.
Steps to Reproduce the Issue
1.Run the web app in two different instance and send the message at the same time to the bot.
2. It throws "Sorry my bot code has an issue" message in second bot.
3.The execution of the bot continues smoothless despite the error message.
Expected Behavior
Smooth execution without "Sorry my bot code has an issue" message.
Actual Results

Any feedback on this from community? Has anyone faced the same issue ?

@PreranaPolekar Please post the webchat code you are using on your website.
I you want to have multiple webchat instances, try configuring the WebChat channel and add multiple site configurations there. This way, each iFrame will have a unique key so the bot/user messages won't clash.
Example multiple site definitions in WebChat channel config:

@PreranaPolekar Were you able to solve the issue by setting up multiple Web Chat site configurations? Let me know if you have additional questions.

Hi @nwhitmont, Sorry for delay in response. Sure I will try your suggestion and will get back with my results. Thanks a ton

@nwhitmont any suggestion?

Hoping that issue has been resolved, closing it. Feel free to reopen if any questions.

Nope the issue was not resolved :(

Hi @PreranaPolekar  did you able to resolved your problem now? . i also have same problem
help  me

Hi, I'm having similar issue. At start it runs smoothly but after a couple of test from a few people  it started to show bot is having an issue.

@PreranaPolekar @Suneethae7 @nitecloack Multiple connections to the Direct Line from different users should not be causing issues. The Microsoft Bot Framework has a multitude of bots doing this on a daily basis, without this issue.
Would one of you please share your bot code, so we can help determine what the issue is exactly?

@EricDahlvang  Exactly! It should be able to handle thousands of users at the same time. Sorry I didn't understand but exactly which part of code you require as I am not sure the root cause of the issue ? Do mean to say the bot ID and password ?

If you can debug this locally, you should be able to get a stack trace or obtain more information about the error.  This blog post discusses how to debug any channel locally using ngrok: https://blog.botframework.com/2017/10/19/debug-channel-locally-using-ngrok/
Application Insights would also provide more detail, with stack traces for errors between the connector service and the bot: https://docs.microsoft.com/en-us/bot-framework/resources-app-insights-keys
If you are able to provide us with a simplified code example, it would be useful for us to help diagnose the issue further. (note: secrets and passwords should always be kept private, or someone could impersonate the bot).

reopen if you're still having issues

Thanks @EricDahlvang .Sorry for delay in reply, was switched to another project. Currently I am not able to work on this but will get back if the issue persists. Thanks again guys :) Happy New Year, Happy Coding :)

If anybody experience this issue in the future, i was able to resolve by specifying unique id for user as following.
BotChat.App({
bot: { id: '{{Chat_Bot_Id}}' },
botConnection: botConnection,
user: { id: {{Any_Unique_ID}} },
resize: 'detect',
locale: 'en-en'
}, document.getElementById('bot'));


Cannot GET /

When I start rekit-studio, it starts successfully but then when I go on the web app I got

Cannot GET /

Here's what I do to start it:
PS C:\Workspace\web\project> rekit-studio
[2020-05-26 07:09:23.878] [studio] [info] Starting Rekit Studio:  {"port":3000,"projectRoot":"C:\\Workspace\\web\\project","pluginDir":null,"pluginsDir":null}
[2020-05-26 07:09:23.923] [info] All plugins: ["default","terminal","scripts","test","git-manager","pty","typescript","rekit-studio-info","common-core","rekit-plugin","rekit-react"]
[2020-05-26 07:09:23.924] [info] Applied plugins for appType rekit-react:  ["default","terminal","scripts","test","git-manager","pty","typescript","rekit-studio-info","rekit-react"]
[2020-05-26 07:09:23.926] [studio] [info] Remote ui plugins: []
[2020-05-26 07:09:24.335] [studio] [info] Rekit Studio is running at http://localhost:3000/

Update: It's working when I use the startDevServer script instead of start

I think this is a problem with installing directly from GitHub. Could you confirm that this was caused from something like npm install http://github.com/user/repo? The reason is that it looks like the official packages in npm are deployed a specific way that includes the generated static assets alongside the package. Without redeploying using the scripts in the repo (ie. just installing directly through git), it can't GET any of the static assets.


Keep track of sessions by user

We need a way to keep track of 'successful' sessions for each user - regardless of if they've deleted them or not. A successful session is when they've collected a trial that is not calibration or neutral, and its status==done.
Here's a way we could do it:
opencap-core: when a trial finishes processing a dynamic trial and status == done, we could do a POST sessions/session_id/add_successful_session
opencap-api: sessions/add_successful_session checks some list for the user of successful sessions and adds the session if it doesn't yet exist.
Open to other ideas, @olehkorkh-planeks

@suhlrich I have a few questions.
First of all, as I understand, we need to implement the API endpoint that allow to "mark" the given session as a "successful". That API endpoint will be used by opencap-core. We can also add the boolean field to the Session model, like is_successful and set it to True when opencap-core will invoke the endpoint. The only moment, I propose to use a bit different URL: sessions/session_id/set_successful.

opencap-api: sessions/add_successful_session checks some list for the user of successful sessions and adds the session if it doesn't yet exist.

This part is not clear for me. Do you want the endpoint for bulk operation. Like
POST sessions/set_successful
Authentication Token user_token
{"session_ids": ["session_id_1", "session_id_2", "session_id_3"]}

And the response would be like:
{
    "session_id_1": {"updated": true, "created": false},
    "session_id_2": {"updated": true, "created": false},
    "session_id_3": {"updated": true, "created": true},
}

Where updated shows if the value of is_successful has been changed (from False to True, for example). It can be false if you run the same request second time. The created attribute is true if the new session has been created.
Do you need also some sort of endpoint for getting the list of successful sessions? Or, just adding the list filter to the Session section in the admin UI is enough?

The sessions/session_id/set_successful endpoint is good. It does not need to return anything, and it should only be accessible if the user is admin or backend. We don't need an endpoint explicitly that sets it to false.
We will also need an endpoint that gets a list of successful sessions ids for a user (doesn't need to return the whole session, just the id). Let's add a query parameter `just_n' that is false by default. If true, it returns just the number of successful sessions for the user, if false, it returns all of the session identifiers.

@olehkorkh-planeks following up on your questions. Sorry I did not answer them all in December.

We do not need the ability to do it in bulk, so POST sessions/session_id/set_successful should work

We do need an endpoint to get the list of successful sessions by user.

GET sessions/get_successful
Authentication Token user_token

response
{session_id1, session_id2,...}

@suhlrich @antoinefalisse
Please check the PR https://github.com/stanfordnmbl/opencap-api/pull/156/files
There are two endpoints:
POST /sessions/get_session_statuses/ - returns session ids with a given status in the specified range
## session get_session_statuses
curl -X "POST" "http://localhost:8000/sessions/get_session_statuses/" \
     -H 'Authorization: Token 8188103f9aa87cedda86587822db8c7ffbec01c2' \
     -H 'Content-Type: application/json; charset=utf-8' \
     -d $'{
  "status": "init",
  "date_range": [
    "2024-01-01",
    "2024-01-24"
  ]
}'

Response:
[
  {
    "id": "8e8f8bd2-2295-4786-8186-35098c9c9287"
  },
  {
    "id": "c06cee1f-bc12-469c-9d8b-057867b7a9db"
  },
  {
    "id": "654c8dc1-5794-41f9-8ea2-a5339292d936"
  },
  {
    "id": "feeb5bbd-0e5a-42c3-a123-2f3e8eb02ad1"
  },
  {
    "id": "64d9ccd2-d771-4c51-9917-e356fe343a7b"
  },
  {
    "id": "994aeb61-20be-4e66-be42-86a435df4185"
  },
  {
    "id": "6c256f1c-3660-41b9-b050-ca1642595e3d"
  },
  {
    "id": "3cbc7dc8-6b1b-4d5f-841a-df7a19902e94"
  },
  {
    "id": "14427e93-5429-494c-913c-bf7fef693734"
  }
]

POST /sessions/...session_uuid.../set_session_status/ - set the status for the specified session
## session set_session_status Duplicate
curl -X "POST" "http://localhost:8000/sessions/5747af67-5eb9-4282-8215-4cccdef4082f/set_session_status/" \
     -H 'Authorization: Token 8188103f9aa87cedda86587822db8c7ffbec01c2' \
     -H 'Content-Type: application/json; charset=utf-8' \
     -d $'{
  "status": "blah"
}'

Response
{
  "status": "blah"
}

@suhlrich Was this solved in #156? If so, we should close this issue.


Is there any intention of building a version of couchsurfing hangouts?

yes, but this is not the place for feature requests :)


Update Dependencies

Bump dependencies

Update docusaurus version
Update typescript version
Update prism-react-renderer version

Going forward we should try stick to one package manager. yarn or npm

Subsumed by later PRs


Alignment mismatch in atom about page/tab

With Love from Github seems to be misaligned. It is not aligned to the middle vertically.

Thanks very much for the report!
I'm honestly not sure if this is intentional (I thought it was?) but would you mind reopening this issue in the https://github.com/atom/about repository? We use multiple repositories to keep the work items tied to the code they apply to. This helps the maintainers spend more time working directly on Atom and less time triaging issues.
If you can also use the issue template in the new issue, that would be helpful too.
Thanks for meeting us half way 👍


Force Multipart request (Mashape/unirest-java#88)

Added the ability to force Unirest to make a Multipart request when there are no File objects present in the request. It only takes a boolean flag.

@aemreunal  please update the readme.

Just checking, did this change ever make it to a release?

this is now supported


Meta tag support

Allow pages to set custom meta tags. The default is not to index anything but allow all links. Only pages with content should be indexed so a site doesn't pollute the search index and might be punished for it. The second thing I've added are feed tags for category and tag feeds added recently.

I like this. I've been doing this a lot myself. I've just been using block named meta. What do you think about that?

meta sounds good to me but the reason why I named it metaTags because it clarifies it's for meta tags and not other kinds of meta data.

OK. The things I've been doing is:

meta (gets injected just before the local stylesheet is included)
styles (gets injected just before </head>)
script (gets injected just before </body>)

I'd love to come up w/ something that can be more consistent. I suppose we could do meta, style, script, or meta, styles, scripts?
I also think the idea of being more specific could be helpful. Maybe head_meta instead of metaTags? So head_meta, head_styles, scripts_after or something?

head_meta, head_styles, scripts_after makes perfect sense because it's clear where things are going to be. Want me to extend that into this PR and update it? I might even consider adding head_scripts that is injected right after head_styles for small snippets that aren't blocking the loading of the page.

Yep, that sounds good to me.

Read: yes, if you want to make those changes and add it to this PR, that would be awesome. You can either add commits or rebase / squash. I'm fine with either.

It will be only 1 other commit so not rebasing or squashing so the history is clear on why the changed happened.

I won't get a notification when you push new code so ping the issue manually when you're ready for me to take a look again! Thanks. :)

Will do :).

ping

Thanks!


Add automatic links (remove manual linkes)

MD code blocks like mlem {cmd} ... (CLI commands), mlem.api.{method}(...) (API methods), and .mlem (meta-files/dirs) can be automatically, linked like in dvc.org.

[ ] Enable for CLI and API command/method names (https://github.com/iterative/gatsby-theme-iterative/issues/19) (https://github.com/iterative/mlem.ai/pull/81)
[ ] Configure other terms e.g. metafiles, cmd aliases (https://github.com/iterative/mlem.ai/pull/83)
[ ] Remove all manual links

Bonus

[ ] Add mlem command info to cmd ref index.

@julieg18 @yathomasi did https://github.com/iterative/gatsby-theme-iterative/pull/16 close this? Thanks

@julieg18 @yathomasi did https://github.com/iterative/gatsby-theme-iterative/pull/16 close this? Thanks

I think automatic linking has all been configured but we still haven't removed all manual links.


Add page number to spells table

taken care of in https://github.com/jderam/hyperborea-tools/pull/65


Auto reloading databases

Hey there, thanks for this incredible application. I wanted to know if it would be possible to add auto-reloading capabilities into this application similar to how this nginx plugin does it. Essentially every day or every week, the three database files would be reopened to ensure the most up to date databases are being used. Currently, the only way to achieve this is by restating the echoip service through a cronjob. Thanks.

I have thought about this as it also makes deployment easier if echoip can just fetch the databases by itself. Pull requests are welcome!

@dharmendrakariya Hey there, we don't actually use helm charts or k8s, we simply installed echoip through go get github.com/mpolden/echoip/... and ran the binary via systemd.


Investigate base10 genetics message error.

One of the reports today with id<PHONE_NUMBER>0601 seems to have additional errors that are not on the other responses.  Would you be able to let me know if there are any additional errors with it?

Done.


fix "attic info" all archives stats, fixes #183

the problem was that calc_stats() dirties cache.chunks by decrementing
the chunk reference counters (so it can compute the deduplicated size
of the archive correctly).
the fix is to create a local Cache instance inside calc_stats, so the dirty cache
instance can not be used elsewhere.
also:
fix internal consistency of calc_stats function: always use "cache" (not "self.cache").
minor cosmetic pep8 fixes

We don't really want to open more copies of the cache unless we really have to.
The real issue here was that cache.rollback() did not properly rollback cache.chunks data structure used by "All archives". I've pushed a fix for this.

ah, ok. :)


Improve compatibility with Measurements.jl

Currently PekerisRayModel works well with Measurements.jl, but RaySolver does not. Improve compatibility.

Duplicate of #3


"Tutorials" section content audit

Reviewing content, layout, links, etc.

closing due to https://github.com/celo-org/docs/pull/227


Installing git during Kitematic installation

I already have git installed in C:\Program Files (x86)\Git.
During Kitematic installation it's impossible to unselect "git installation".
So, is it going to install the different copy of git in its own directory or it will try to reinstall my git? Won't it cause any errors? Won't it damage my git files?

Can you open this within https://github.com/docker/toolbox as this section is for Kitematic related issues only.
Thanks!


TEMP: Trigger travis build

This PR is a workaround to trigger historical build of https://github.com/dfahlander/Dexie.js/commit/90b51386aeb7375014f434a193c5b0cce5202487
(Dexie cloud addon merged into master).
Trying to nail down why latest master fails for IE11. Were out of travis credits for a week.

Closing as the the historical failing commit has been found.


Does any filter need addListenSocketOption[s]?

ListenerFactoryContext::addListenSocketOption[s] is here
I search this repo and no filter is using it. ListenerImpl itself implements addListenSocketOption but it doesn't mean this function should be exposed to ListenerFactoryContext
If no known use cases we should keep the code base simple by removing this function from ListenerFactoryContext. It brings trouble when I further split the filterchainmanager from listener.

I think this is being used by filters external to the tree.

At the following steps of filter chain discovery service which allows filter chain update without recreate the listener, it's critical to know that if the listener modular filter chain is remaining the same.
One example: if a newly added filter chain need to change the ListenSocketOption, the listener need to created.
Previously a listener is always created so the addListenSocketOption as ListenerFactoryContext is fine.
@mattklein123  Could you share some light? Can we move the addListenSocketOption out of ListenerFactoryContext, or, add a function, something like is-current-listen-socket-options works for this filter/filterchain?

@silentdai fundamentally, I think addListenSocketOptions should only be allowed to be called by listener filters, and not network filters, otherwise I don't think it makes any sense. So we might have to look at a change there? I can't imagine this is being used outside of listener filters. Can you look at who added this originally and ask them? I'm guessing @jrajahalme or @klarose?

addListenSocketOptions should only be allowed to be called by listener filters, and not network filters

Agree!

Can you look at who added this originally and ask them?

Will look into the git history. Thanks!

Looks like it came in before I started working on the src transparency stuff: https://github.com/envoyproxy/envoy/commit/725457cbeca5e49563da3787b424d2f564ec7e9e.

@klarose Yes addListenSocketOption was not introduced earlier. However, in https://github.com/envoyproxy/envoy/commit/725457cbeca5e49563da3787b424d2f564ec7e9e

ListenerFactoryContext doesn't need addListenSocketOptions, it is the Listener who need it. Listener should implement this function but not because of ListenerFactoryContext
What I am trying to achieve is that NetworkFilterChains should not use addListenSocketOptions. Hopefully ListenerFilters should not use either but it is NBD
The feature in 725457cbeca5e49563da3787b424d2f564ec7e9e is gone. Probably moved to a different place.

So @klarose what is the src transparency stuff you are mentioning? Is it in this repo or somewhere else?

@silentdai It's in tree. It has two filters: one listener filter, and one http filter. The listener filter adds options, but to the connection socket, not the listener socket: https://github.com/envoyproxy/envoy/blob/ba0b5a760acc0a445df47e7cc8bdbae47312776b/source/extensions/filters/listener/original_src/original_src.cc#L32

We should be good. This addOptions doesn't belong to class/interface ListenerFactoryContext. Happen to be the same name.


removes try-catch block around require when resolving a module

fixes #962

Tests fail. Rebase master, run prettier and try again.

@koskimas done. Should run through, hopefully it won't fail on specs.

now it shall pass!

@capaj nice work, this actually caused me a several hours of pain early on when I was setting up my relations as well - thx for bringing it up and fixing.

I added one more comment. If you fix that, then I'm ready merge this. Thanks for doing this!

Will move it. I might have to add an ignore to mocha so that mocha won't load it on start of a test run.


Issue with ng-blur directive

Using ng-change with the picker works as expected, i.e. the function gets called each time when the value changes:
<mdp-date-picker ng-model="..." ng-change="someFunction()"></mdp-date-picker>
Although, this event may get called a lot of times, especially when user will start using the arrows, mouse scroll etc. to change the value. So if upon that change I need to make a server request to check something, I used to use ng-blur event, i.e. to do it after the element loses focus:
<mdp-date-picker ng-model="..." ng-blur="someFunction()"></mdp-date-picker>
Unfortunately, the function defined in ng-blur directive gets never called.

I need this feature too


ISSUE - spring-data-cosmosdb - 2.2.2 version - @Id value is not autogenerated

Currently I am using Spring data cosmosdb 2.1.0 version with Spring boot 2.1.7.RELEASE.
        <dependency>
            <groupId>com.microsoft.azure</groupId>
            <artifactId>spring-data-cosmosdb</artifactId>
            <version>2.1.0</version>
        </dependency>

@Id field was autogenerated.
I would like to upgrade Spring data cosmosdb client:
<dependency>
    <groupId>com.microsoft.azure</groupId>
    <artifactId>spring-data-cosmosdb</artifactId>
    <version>2.2.2</version>
</dependency>

The issue i am facing is with @Id field, it's not autogenerating. It's saving as null in CosmosDB.
Can you please suggest why @Id field is not autogenerating. It's explicitly expecting me set value.
Kindly help.
Thanks.

@sivawipro  - @id is not autogenerated any more and is not supported by Cosmos DB SDK.
Auto generate ID feature was removed in Cosmos DB SDK v3. You will need to generate id on your own.

Closing this issue now.


[Nikhil] - Sage - Build a Decentralized Lottery Game on Celo

Thanks for submitting this tutorial for Celo Sage
Before you hit "Create Pull Request", make sure you have read the Tutorial Contribution Guidelines and reviewed the Sample Tutorial Structure.
Please confirm the following before submitting your tutorial for review -

[x] My tutorial follows the Tutorial Contribution Guidelines.
[x] The title of the Pull Request matches the title of my tutorial.
[x] I've followed the tutorial template structure.
[x] I've proofread the tutorial for spelling and grammar mistakes.
[x] I've thoroughly explained the code, with inline code comments and text explanations.
[x] I've run a linter & prettifier to format my code blocks.
[x] I've run the tutorial to test it and the code works.

NOTE: We cannot review your Pull Request if it does not meet the standard outlined above.
Reviewers - @joenyzio & @viral-sangani

@Julius170  I wanted to check if all is good in this pull request.

@viral-sangani Even though this branch is merged, I can find this tutorial. Is there something wrong here?


Example schematic?

Hi Tim,
Any chance of adding a simple example schematic that uses this, to make getting started with it a little easier?
Thanks,
Paul.

I never built anything using this. Would happily merge such an example....

Hi Tim,
Ok.  Will do.  Also, looking forward to catching up at CCC next week.
Paul.
On Fri, 16 Aug 2019 at 07:18, Tim Ansell<EMAIL_ADDRESS>wrote:

I never built anything using this. Would happily merge such an example....
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mithro/kicad-mini-pci-express/issues/6?email_source=notifications&email_token=AAFCOTY54P7QAZOTCL7U3BDQEXFJHA5CNFSM4ILGFYK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4NC52A#issuecomment-521809640,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFCOT6QEXB2PHCCJVN5UNLQEXFJHANCNFSM4ILGFYKQ
.


AND operator

Enter calculator name -
AND operation of multiple numbers
Describe calculator functionality -
Does AND operation of multiple numbers
Under which category you wish to place it -
[] Computer Science

I would like to work on this issue

Hey @7twik,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\computer_science\and_operator
Issue completion deadline - 4th Oct 3:00:00 pm IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant


json.Marshal() silently ignores custom implementations on pass by value

What version of Go are you using (go version)?

$ go version
go version go1.11 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/tkmamhf/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/tkmamhf/go"
GOPROXY=""
GORACE=""
GOROOT="/Users/tkmamhf/.gvm/gos/go1.11"
GOTMPDIR=""
GOTOOLDIR="/Users/tkmamhf/.gvm/gos/go1.11/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/y6/dbk1vvs179nbpfv38j__10b5rsnf87/T/go-build193800130=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Carefully implemented json.Marshaler and json.Unmarshaler interfaces, and passed my struct directly to json.Marshal().
What did you expect to see?
The resulting JSON byte array uses my custom json.Marshaler interface method.
What did you see instead?
The resulting JSON byte array ignores my custom json.Marshaler interface method, instead presenting the keys and values of the plain Go struct declaration. This causes downstream breakages, as my custom JSON marshaling is needed to offset some issues with the data I happen to be handling.
Workaround
As a workaround, I am making sure that I pass a reference (&) of my object to the json.Marshal() method. This is quite dangerous, as it is a really easy mistake to make, across a large codebase. And currently no way to validate this with the Go type system on the existing API.
In the future, can we improve the json API to prevent this from happening?

FWIW: you only need to pass a pointer to json.Unmarshal if you implement (*T).MarshalJSON.
See: https://play.golang.org/4i6MZABdBa7

If at all possible, please include in the "what did you do" section the actual code, and in the "what did you see instead" the actual result and errors if any. This would make it so much easier to analyze and help.
My guess is that the value you pass to json.Marshal(yourval) does not actually implement the json.Marshal interface at all, probably because the method had a pointer receiver e.g., func (x *MyType) MarshalJSON() ([]byte, error and you passed a MyType value, not a pointer.
Example: https://play.golang.org/p/K2M4Ap6uO-C


[editor] Descriptions for PromptSchema (OpenAIChatModelParser)

[editor] Descriptions for PromptSchema (OpenAIChatModelParser)
The settings renderers already support info tooltips for 'description' specified in the schema, so just add the descriptions as an example:

Ok, weird Github UI state here. I hit 'Merge pull request' and it was stuck spinning for a minute so I reloaded the page and now the button is disabled. It actually did get merged but the PR is still open for some reason. Closing to prevent more weirdness


Add instruction to be used in .zon

Don't merge this yet! You need to publish your own archive files, and change this patch to mention the files you created.
See https://github.com/ziglang/zig/issues/17064 https://github.com/keybase/client/issues/10800#issuecomment-525815159
Edit: I misunderstood this.

So do I need to have a script like this one that I run to upload tarballs to GitHub?

I will merge this and get working instructions on the readme

Here is a patch for your repository that uses zon:
commit 047a494cf09d73b840a75350c660f1dea93e9dca
Author: Dmitry Matveyev<EMAIL_ADDRESS>Date:   Tue Sep 26 00:48:57 2023 +0600

    Use zon module instead of a git submodule

diff --git a/.gitmodules b/.gitmodules
deleted file mode 100644
index 762339d..0000000
--- a/.gitmodules
+++ /dev/null
@@ -1,3 +0,0 @@
-[submodule "lib/jzignet"]
-	path = lib/jzignet
-	url = https://github.com/greenfork/jzignet/
diff --git a/build.zig b/build.zig
index be5bf00..4554160 100644
--- a/build.zig
+++ b/build.zig
@@ -15,7 +15,7 @@ pub fn build(b: *std.Build) void {
     // set a preferred release mode, allowing the user to decide how to optimize.
     const optimize = b.standardOptimizeOption(.{});

-    const lib_jzignet = b.anonymousDependency("lib/jzignet", @import("lib/jzignet/build.zig"), .{});
+    const lib_jzignet = b.dependency("jzignet", .{ .target = target, .optimize = optimize });

     const exe = b.addExecutable(.{
         .name = "janet-zig-catalog",
diff --git a/build.zig.zon b/build.zig.zon
new file mode 100644
index 0000000..74af452
--- /dev/null
+++ b/build.zig.zon
@@ -0,0 +1,10 @@
+.{
+    .name = "janet-zig-test",
+    .version = "0.0.1",
+    .dependencies = .{
+        .jzignet = .{
+            .url = "https://git.sr.ht/~greenfork/jzignet/archive/0.7.0.tar.gz",
+            .hash = "1220e5739ec063602a628d5b03265f7b55933158574e97dbac0696a73586d9416162",
+        },
+    },
+}
diff --git a/lib/jzignet b/lib/jzignet
deleted file mode 160000
index 35d7f61..0000000
--- a/lib/jzignet
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit 35d7f61d34450f332f10bc8d5a698cfe3c937ace

Thanks! I've applied the patch.


System unavailable: sparc nodes

I've just spoken to Oliver at Inspira who sent me the following ILOM fault:
-> show faulty
Target              | Property               | Value
--------------------+------------------------+---------------------------------
/SP/faultmgmt/0     | fru                    | /SYS/MB
/SP/faultmgmt/0/    | class                  | fault.chassis.voltage.fail
 faults/0           |                        |
/SP/faultmgmt/0/    | sunw-msg-id            | SPT-8000-DH
 faults/0           |                        |
/SP/faultmgmt/0/    | uuid                   | aae3aade-000b-e734-ca0f-ec0d16cd
 faults/0           |                        | 49e2
/SP/faultmgmt/0/    | timestamp              | 2021-04-10/15:57:42
 faults/0           |                        |
/SP/faultmgmt/0/    | fru_part_number        | 541-3857
 faults/0           |                        |
/SP/faultmgmt/0/    | fru_serial_number      | 1005LCB-1132B20D4F
 faults/0           |                        |
/SP/faultmgmt/0/    | product_serial_number  | 1135BDRC8F
 faults/0           |                        |
/SP/faultmgmt/0/    | chassis_serial_number  | 1135BDRC8F
 faults/0           |                        |

He's tried clearing the fault and rebooting a couple of times but it faults out again within about 5 seconds of powering up. He has also verified that everything internally appears to be seated correctly.

closing as duplicate of https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/2129


Workflow REST API and Replay/Retry/Error handling

Completes almost all of what we wanted for V1 release of this feature, including good UI support (PR to follow, will reference this) for showing workflow steps and retrying (replaying) manually, and extensive support for retrying automatically, configuring retries, and configuring error handling.

addressed everything but constants; merging

entitlements (and expiry) will be done in a following PR


Setup proper unit tests

Run through java checkstyle based on sun and google styles. Use their xmls to run checkstyle against.


App settings: visual inconsistencies

Hi everyone,
In the app settings, there are many visual issues:
Changing the country and/or the language are selectable on the whole line.
However, for the theme and the source, it's only by clicking exactly in the bounds of the dropdown menu:

The rounded corners of the country and the language pickers are different:

The rate app button doesn't have a correct bottom padding:

The share app icon is misaligned:

Hi @g123k!
while adding that share app and reate us i could not get to test with iphone! in android it looked okay ! 😅, I fixed the padding and mis allignment problem ! Shall I make pr for it ?

Closing this issue, as the PR is now merged


Ignore class attribute when dynamically binding attributes

Simple fix for https://github.com/DockYard/ember-one-way-controls/issues/80

I think we also need a test to ensure we don't regress in the future...

@EWhite613 thanks!
@homu r+

:pushpin: Commit f436b93 has been approved by martndemus

:zap: Test exempted - status

Published v0.6.2 including this fix.


[ENH] Drop all ICA/MELODIC work. Expect individual files.

Closes #27. I think this will bring us a lot closer to an MVP for fMRIPrep integration.

Changes proposed in this pull request:

Add individual required files to workflow parameters.
Remove option for a FEAT directory or a MELODIC directory, and do not perform ICA, BET, etc. in workflow.

Thanks! The only other thing I think we need before merging is @oesteban's thoughts. Unfortunately, I can't request a review from him, so tagging will have to suffice.

Thanks! The only other thing I think we need before merging is @oesteban's thoughts. Unfortunately, I can't request a review from him, so tagging will have to suffice.

Since this PR is delaying #46 , why don't we merge if @oesteban has no comments by this Friday? If he has any comments, we could also address them after this PR is merged.

@eurunuela CI is passing, so do you mind if I merge?

@eurunuela CI is passing, so do you mind if I merge?

Go ahead!


Update update-and-delete-bot-messages.md

Needs TS samples

Docs Build status updates of commit 8342916:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
:bulb:Suggestion

Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md

Line 72: [Suggestion] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bot-conversations/bots-conversations' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 76: [Suggestion] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bot-conversations/bots-conversations#updating-messages' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 77: [Suggestion] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bot-conversations/bots-conversations#deleting-messages' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit f70cf8f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md
:bulb:Suggestion

Details

msteams-platform/bots/how-to/update-and-delete-bot-messages.md

Line 91: [Suggestion] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bot-conversations/bots-conversations' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 95: [Suggestion] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bot-conversations/bots-conversations#updating-messages' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 96: [Suggestion] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bot-conversations/bots-conversations#deleting-messages' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. NOTE: This Suggestion will become a Warning on 12/20/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

The C# update activity sample is weird. I commented inside the article (in .

It looks good.


Add HostName widget

This PR adds a HostName widget.  This shows the current machine hostname.
It is relatively simple, but I have a question about it.  Should it poll for a new hostname?  That is to say, should it be based on a PollingLabelWidget?  It don't know how frequently it is for people to change their hostname, but for me, I never change my hostname, so I don't need any sort of polling functionality.
If this hostname widget should poll for an updated hostname, then the HostNameConfig data type should probably have a field to specify the polling interval.
It if should not poll for an updated hostname, then a PollingLabelWidget should probably not be used.  Maybe I should create a new non-polling LabelWidget?  That way it could be reused by other widgets.
Closes #250

@IvanMalison Thanks for the review.  I've pushed commit 448f623 that addresses your comments.
What do you think of how I've added theming support?  Is there a better way to do it?

@cdepillabout I meant to add theming support as in
https://github.com/travitch/taffybar/blob/2647bc9071fb926d460e447ba1c333c06736b7d7/src/System/Taffybar/WorkspaceHUD.hs#L844
In the new gtk3 version this will be css theming instead of gtks weird stylesheets as in:
https://github.com/travitch/taffybar/blob/92d1df8a2035142b3e05620db19aff30ef3d566d/src/System/Taffybar/WorkspaceHUD.hs#L153

@IvanMalison Is there an example of using GTK's theming support in another widget currently in the code?  I'm afraid I don't understand how Gtk.widgetSetName is related to theming support.  Did you maybe mean to link to another part of the code?
In my original code, I am just using pollingLabelNew.  The pollingLabelNew function doesn't seem to take any arguments related to GTK theming.  Am I missing something here?

I should add that I am not very familiar with GTK.  Is theming support some sort of basic functionality of GTK?
Since I am just using pollingLabelNew, most of the code in my original PR doesn't do that much GTK stuff.  A simple example that shows how to set the foreground color for a label using the theming functionality of GTK would probably help me understand what you're talking about.

widgetSetName allows you to target the widget that has been named with your taffybar.rc (taffybar.css in gtk3) file. It works the way that css does in that you specify the theme/appearance properties separately.
You can take a look at the taffybar.rc file in the root of the repository

@IvanMalison Is there some sort of documentation about taffybar.rc?  There is no mention of it in the README.  There is a one-sentence explanation of it in the System.Taffybar documentation, but the default theme does not exist on my machine.  (Maybe because I'm compiling with stack instead of cabal?)  Also, the link in the documentation doesn't work.
As an end user, I don't want to have two separate configuration files that I must update to configure taffybar.  I would much rather specify everything in taffybar.hs.
If I use widgetSetName, is there a way to override the color specified in taffybar.rc and just use the color specified in HostNameConfig?  None of the other widgets I've looked at seemed to be using widgetSetName.

@IvanMalison Is there some sort of documentation about taffybar.rc?

Nothing that is taffybar specific. Here is something on gtkrc files in general:
https://www.gtk.org/tutorial1.2/gtk_tut-21.html

As an end user, I don't want to have two separate configuration files that I must update to configure taffybar. I would much rather specify everything in taffybar.hs.

I WOULD be inclined to agree with this sentiment, but unfortunately it seems that certain types of appearance properties including rounded edges and transitions are actually not possible without the use of rc files(actually css files in gtk3).

If I use widgetSetName, is there a way to override the color specified in taffybar.rc and just use the color specified in HostNameConfig?

I believe that if you set the color of a widget explicitly in code that will take precedence over any appearance stuff that is set through css/rc I'm not 100% sure on that one though.

None of the other widgets I've looked at seemed to be using widgetSetName.

WorkspaceHUD, WorkspaceSwitcher and WindowSwitcher all use it. Many widgets in taffybar don't really need to be explicitly themed as long as they just use the default top level taffybar themes (rc/css files use a type of selector that can be applied to all children), but it is true that there are a few spots where theming works differently.
While I can't say that I love having to edit a separate file to control certain things about taffybar's appearance, we have to do things that way to achieve certain visual effects (as far as i can tell). As such, I think that its better that we have all of the color/theming stuff in one place as much as possible. There are certain advantages to doing things with css (selectors /classes etc.), especially if you want to share theming across different widgets.

You might want to try to work with #237 as a base for your changes since that is likely to get merged soon, and it is possible that some of the stuff you are using here will need to be slightly different in gtk3.

#237 is merged, and now you seem to have some conflicts.
Now instead of widgetSetName, you'll want to use something like:
https://github.com/travitch/taffybar/blob/b2e9577b3de272f56f9c89dfb01c3d3d9107cf55/src/System/Taffybar/WorkspaceHUD.hs#L143
to add a css class.

Unfortunately work has gotten busy for me, so I won't have any time to continue with this PR.  As I mentioned on #250, I can use commandRunnerNew for this, so it is not critical that it exists.
However, I have Allow edits from maintainers checked, so if you would like to continue working on it, please feel free.
Otherwise feel free to close this PR.

You can very easily use:
commandRunnerNew 60.0 "hostname" [] "failed"


Support instant deletion

Description
SegmentDeletionManager currently perform a move when segment deletion is being invoked, this causes huge overhead (both time and read/write IO) in some cloud PinotFS such as S3 (because "move" is implemented as "copy-and-delete").
Goal
We would like to eliminate the move (copy-and-delete) step in S3 by instant delete the segments.
Status Quo
Currently deleting segment goes through

SegmentDeletionManager, deleting one or more segments from deep store is implemented by moving from active segment file to deleted_ prefix segment files.
RetentionManager checks and deletes these deleted_ prefixed segment files after the retention period default to 7 days.

Proposal
We propose to create a way to instantly delete the segment. e.g. SegmentDeletionManager directly delete the segment files in PinotFS.

Can you state the problem you want to solve?  Is it that the retention of a deleted segment taking up storage cost in the cloud? Or, is it that deletion takes a long time (it is a background task, so I don't see why that should matter much).

Hi @mcvsubbu, yes. I think the problem I stated to solve is "this (copy-and-delete) cause huge overhead during the deletion operation". this is both in time and I/O cost.
One example is I wanted to delete and recreate a table, it is not ideal to wait until the background task to finish.

Recreating a table is a more involved problem. What we need to do is to wait for the external view to disappear in the table drop API. I believe there is an issue for it already.
Deletion of segments from the deep store happens right away, it is the wait on externalview that takes time. Hopefully in your cluster, this is a short time.
Deletion via retention manager happens MUCH later and does not interfere with the recreation of a table.
Let us formulate the problem correctly before we start looking for solutions.

hmm I think I understand your confusion when I give examples here and there. let me rephrase the entire description of the issue and let's restart the discussion from this point forward.

I still don't understand why the latency is a problem.  Is it that the background task takes too long  to complete ? Or, is it that each I/O to S3 costs, and we want to minimize the number of I/Os (at the cost of not having a backup, of course)? Or, is it both?
Assuming it is both, the best way to solve this problem as of now will be to

Set the retention days to 0 (instead of default 7) AND
Change the code so that deletion manager deletes it right away if the retention time is set to 0.

This is a cluster-wide behavior. So, if you want to change this on a per table basis, we should have a table config (that overrides the cluster config) with a different retention time (which can be 0 to indicate immediate deletion).
A change to the API is not the best way to solve this IMO. You could have clients make a mistake while deletion, causing some segments to be retained and others to be deleted. Better to enforce uniform behavior across all segments in the table.

I agree we should have both cluster config and table config override for retention time, but we also want to give user the flexibility to delete the segment immediately without moving to a deleted folder through the rest API (note that for some cloud storage, move is not supported, and it is implemented as copy then delete which can be super expensive).
Some scenarios I can think of:

User pushed a bad segment (or several) and want to delete it
User wants to delete a table they no longer need

What does "super-expensive" mean? We should not be adding/deleting segments at hundreds per second, so I am just curious here.  I think segment reads/downloads will have much more cost (but perhaps that is where the "tiered storage" comes in).
With that, yes, there may be use cases where user wants to drop the segment or segments right away. So, both segment delete and table delete can have the ultimate override, maybe?

@mcvsubbu agreed! I was not proposing to change the API to solve the problem (that's why I created this issue instead of continuing the discussion in the previous PR), as the proposal is to "find a way support instantly delete the segment".
I am fine with going through setting the RETENTION setting to 0 instead of 7 approach, as long as I can change the logic (as you mentioned) to instantly delete in SegmentDeletionManager
Regarding the use cases @Jackie-Jiang mentioned, I think we can achieve both scenarios (technically) via using a table-level config that overrides cluster level config as @mcvsubbu mentioned. whether this is convenient for the user or not is a different story and we can leave that out of this discussion.
So to summarized, I will

change the logic in SegmentDeletionManager and instantly delete the segment if retention period is set to 0
create a tableConfig for retention that overrides cluster level config.

this should be closed by #8122


Set CONFIG_USB_CONFIGFS_QCRNDIS

Hybris kernel config requires
CONFIG_USB_CONFIGFS_QCRNDIS=y

until the build issue is resolved, I had to disable it.
Related: https://github.com/sonyxperiadev/bug_tracker/issues/484

Closing as there was different config used to get rndis working